From xen-devel-bounces@lists.xenproject.org Sat Oct 01 01:39:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 01:39:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414471.658766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeRT3-0001db-1G; Sat, 01 Oct 2022 01:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414471.658766; Sat, 01 Oct 2022 01:39:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeRT2-0001dT-S8; Sat, 01 Oct 2022 01:39:00 +0000
Received: by outflank-mailman (input) for mailman id 414471;
 Sat, 01 Oct 2022 01:38:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RiOR=2C=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1oeRT1-0001dN-9Y
 for xen-devel@lists.xenproject.org; Sat, 01 Oct 2022 01:38:59 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf71482c-4129-11ed-964a-05401a9f4f97;
 Sat, 01 Oct 2022 03:38:56 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6AE6C5C00F0;
 Fri, 30 Sep 2022 21:38:54 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 30 Sep 2022 21:38:54 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 30 Sep 2022 21:38:53 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf71482c-4129-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664588334; x=
	1664674734; bh=4Y1yVEfUHPk1tElemZjziRLNumjA2Ps5jgjeAEWF4UE=; b=Q
	zqH/a/TeYiFYyRaAaD5zCv6ae1HXvh7HG1UV6PaWizMqhVKnqI97PFx38i2ZCEyv
	geL3ylE9ORr1buGnpy15GRFjNY+ZeIJYVjTUj2Ak8Eo8CA6owzO3+Ke4GTiXX/fC
	md1XvCKDEcsNL3iNP48LU0IrLcXQYfZqp29K4Hj1+1/LsIQxj5LSJFiJB0DWV4X4
	yfGQidkKL/2UrZ7EliI3E8vVQxqFOcPYuGwgPr7GM3/GvpQ/N6aBjmM5tEOcK/P8
	y5YhR0LAV1MePV5SoOh9QY2KqrJEUuH+rvBXi6sne7GfO0DDrq5MbLrFZj7ie8J+
	JrkMHsqGAxNdbhjvr1iyA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664588334; x=1664674734; bh=4Y1yVEfUHPk1tElemZjziRLNumjA
	2Ps5jgjeAEWF4UE=; b=nXSuBGaC5K2a0uVtiNzniKoS9tfiTJuXy3UPZSbI2uWf
	3sPahyNajPXkS+HZMXq3FftaUnPxNYF8jitWSWOvd6nUL7MpZn36lqjYbK081MoA
	HxioIlmOFz05ECUrz/wIeQ1po3DZ8DsXp7AcOLJ5qHY+WENAHof01zejXFRznCw5
	qgTRCXzWtiqsmZTWzIWJ1evSBY7sWs/v4seWAdUlXNeGaNZisbTWD7JDQMFt+cRD
	x93qaadUysAd+j+6cwkKmt6kgz5PhaA6YPq21WTdZ84MwdfMjdzEErcWKGMP2ehO
	rvgRVBw9rAeD6bHcDBzX0ZMA6Mapjv5NHQZkjryS2g==
X-ME-Sender: <xms:LZo3Y-0KxuPrZpe2HQQEaqoQp1BgYLejrOGlRHJGP_4Rf1vkYViXyg>
    <xme:LZo3YxGxlcn_mt2lbtukromnsxtxSslFWB8J7A1UxnKFZleuk4S1lE1NtHjS6Gavm
    ntIzHhycR6ZDZk>
X-ME-Received: <xmr:LZo3Y24C3kJeAJXeIh4k22CLtAu49surux5t7XlyDedSaxB_AA39kY1Vs5y0>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehfedghedtucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff
    gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:LZo3Y_1IAdXgv4YYDbOrjjKze3HiE_vbNIcJx50EOgXNsWvzuKbUfg>
    <xmx:LZo3YxEmn8S7b5mzTbMPZbEPO-BC_iwt2D5oPKiJc5HGUuH31ZTB6g>
    <xmx:LZo3Y48XiQqlR8rrn9nGSFBUkgrdIjFIxmlqdO8j37jk5ObuidaDMA>
    <xmx:Lpo3Y59ez1ow0lpmym_wBbXUZ1Vyxh4SAo9Z548i5ec9ryhGJidBSg>
Feedback-ID: iac594737:Fastmail
Date: Fri, 30 Sep 2022 20:30:33 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Message-ID: <YzeaKjmls1YI/3ox@itl-email>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="f1U+J1ZNYcGqSCmT"
Content-Disposition: inline
In-Reply-To: <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>


--f1U+J1ZNYcGqSCmT
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 30 Sep 2022 20:30:33 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered

On Fri, Sep 30, 2022 at 08:27:09PM +0200, Ard Biesheuvel wrote:
> On Fri, 30 Sept 2022 at 19:12, Demi Marie Obenour wrote:
> > On Fri, Sep 30, 2022 at 06:30:57PM +0200, Ard Biesheuvel wrote:
> > > I know very little about Xen, but based on the context you provided in
> > > this thread, I'd say that the best approach from the Xen side is to
> > > convert all EfiBootServicesData regions that have configuration tables
> > > pointing into them into EfiAcpiReclaimMemory.
> >
> > Should Xen convert the entire region, or should it try to reserve only
> > the memory it needs?  The latter would require it to parse the
> > configuration tables.  Is there a list of configuration tables that can
> > legitimately be in EfiBootServicesData regions?
> >
>=20
> Not really, no. So you would have to convert the entire region
> /unless/ Xen knows the GUID, and therefore knows how to derive the
> size of the table, allowing it to reserve memory more conservatively.
> However, I doubt whether this is worth it: splitting entries implies
> rewriting the memory map, which is a thing I'd rather avoid if I were
> in your shoes.

I actually wonder if Xen needs to reserve *all* of EfiBootServicesData.
The reason is that some (probably buggy) firmware may store ACPI tables
there, and Xen does not have an ACPI implementation.  From my
perspective, a much safer approach would be to pass all of
EfiBootServicesData memory directly to dom0, and have dom0 give Xen back
what it doesn=E2=80=99t wind up using.  That allows dom0=E2=80=99s memory r=
eservation
code to work properly, which it currently does not.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--f1U+J1ZNYcGqSCmT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM3misACgkQsoi1X/+c
IsGokg/7BmeYWsuHyIip8QSpGg0PqxUx5LZTS8crGjyQ76Ielz5tCIMITIEk0ofl
gjlnPHVH+wY2M2M0i3GWCpgpzkEBCuWkIgujegbXEZ8YVg9K9Sow5dZBwCgP3DdR
guREHEgIs44F7K3GPle8IePmGH7ZHkele570faQkyPElgZaxxeqrUGVUz7QUN3pz
7tFOpvY1MVFYLXi9d0V7HbbcFUhXIGWAoi81o8hHiY+t29OTjlVfrPh9ruwXQxA/
DUYzlDA4aMvJxeSvmqvXbb9ZhN4RmKu/OxKsnph48qCs5QEwbAhWqj40cTtcQdBL
xcO/BsV2VrekeP5CIT2BlI0RxUZAWtG99YKztzy4n0VMgsS/lT0JSomzND4CgyDx
sv+freSMGzt6XX8/JvOl8E93TWVG/iorAIWZc1skzaMsX6mmdwhUyhhKNVunn3ZR
RIkluLvFCroAjGvvCBXLlmNtfT86N0DcOgD5n1lrt3J/sOLF2Dkq6Nmjj90VJYEV
KM1UZvJU/oKv8I2/2rxWbO/FiqwcGuU50gqQ92HfpJDrQtilUSCSWRje6/Cz4JZP
ySRaOshV8CICgQ5cQPZavMIVDAFoOh9b0eJ5w4emU/LrnJkY9RaAKA72rsZZTu4A
lhTBLEj/to92QAmoyX9x/d5tW+f6QQwRM1lW9o7PLBEODo693bo=
=MD/M
-----END PGP SIGNATURE-----

--f1U+J1ZNYcGqSCmT--


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 03:01:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 03:01:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414479.658777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeSkA-0001oc-O3; Sat, 01 Oct 2022 03:00:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414479.658777; Sat, 01 Oct 2022 03:00:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeSkA-0001oV-KQ; Sat, 01 Oct 2022 03:00:46 +0000
Received: by outflank-mailman (input) for mailman id 414479;
 Sat, 01 Oct 2022 03:00:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeSk9-0001oL-Ah; Sat, 01 Oct 2022 03:00:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeSk9-0003n4-6b; Sat, 01 Oct 2022 03:00:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeSk8-00067G-Lc; Sat, 01 Oct 2022 03:00:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeSk8-0004to-KS; Sat, 01 Oct 2022 03:00:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6boUuRe1pOnyYF/a1oX0UqQWSFTbBmucXmM6IoBkXYo=; b=LqT2jn2L9HTweic2NZEWyKPf1P
	6n7TgbVUlAnlzgJ8+FOmJt8eeVHk0gMOiuIU/66rvPfKiKza+AOHYV5ymOi4thp3SSZhzEqDIVyg7
	saBMM32Z9LTCoC2rZNDvRhen1CYW/ZIiH+f42dqbe0jw4JIQUcRBkLGPzr3AVY8AG+hY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173388-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173388: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-i386:<job status>:broken:regression
    linux-linus:build-i386-pvops:<job status>:broken:regression
    linux-linus:build-i386-xsm:<job status>:broken:regression
    linux-linus:build-i386-xsm:host-install(4):broken:regression
    linux-linus:build-i386:host-install(4):broken:regression
    linux-linus:build-i386-pvops:host-install(4):broken:regression
    linux-linus:build-i386-libvirt:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5a77386984b513ebfb2700e70dac44509fc81aa9
X-Osstest-Versions-That:
    linux=511cce163b75bc3933fa3de769a82bb7e8663f2b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 03:00:44 +0000

flight 173388 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173388/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                      <job status>                 broken
 build-i386-pvops                <job status>                 broken
 build-i386-xsm                  <job status>                 broken
 build-i386-xsm                4 host-install(4)        broken REGR. vs. 173364
 build-i386                    4 host-install(4)        broken REGR. vs. 173364
 build-i386-pvops              4 host-install(4)        broken REGR. vs. 173364

Tests which did not succeed, but are not blocking:
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173364
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173364
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173364
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173364
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173364
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                5a77386984b513ebfb2700e70dac44509fc81aa9
baseline version:
 linux                511cce163b75bc3933fa3de769a82bb7e8663f2b

Last test of basis   173364  2022-09-29 15:40:21 Z    1 days
Failing since        173378  2022-09-30 00:41:06 Z    1 days    3 attempts
Testing same since   173388  2022-09-30 15:41:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrien Grassein <adrien.grassein@gmail.com>
  Al Viro <viro@zeniv.linux.org.uk>
  Alex Deucher <alexander.deucher@amd.com>
  Alvin Lee <Alvin.Lee2@amd.com>
  Andi Shyti <andi.shyti@linux.intel.com>
  Andrzej Hajda <andrzej.hajda@intel.com>
  Aric Cyr <aric.cyr@amd.com>
  Ashutosh Dixit <ashutosh.dixit@intel.com>
  August Wikerfors <git@augustwikerfors.se>
  Bokun Zhang <Bokun.Zhang@amd.com>
  Brian Norris <briannorris@chromium.org>
  Chris Wilson <chris@chris-wilson.co.uk>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Douglas Anderson <dianders@chromium.org>
  Eric Bernstein <eric.bernstein@amd.com>
  Evan Quan <evan.quan@amd.com>
  Francesco Dolcini <francesco.dolcini@toradex.com>
  Graham Sider <Graham.Sider@amd.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jiadong.Zhu <Jiadong.Zhu@amd.com>
  Leo Li <sunpeng.li@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Neil Armstrong <neil.armstrong@linaro.org>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Philippe Schenker <philippe.schenker@toradex.com>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Samson Tam <samson.tam@amd.com>
  Taimur Hassan <Syed.Hassan@amd.com>
  Thomas Zimmermann <tzimmermann@suse.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               broken  
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   broken  
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             broken  
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-i386 broken
broken-job build-i386-pvops broken
broken-job build-i386-xsm broken
broken-step build-i386-xsm host-install(4)
broken-step build-i386 host-install(4)
broken-step build-i386-pvops host-install(4)

Not pushing.

(No revision log; it would be 678 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 06:12:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 06:12:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414486.658787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeVjZ-0003rM-DV; Sat, 01 Oct 2022 06:12:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414486.658787; Sat, 01 Oct 2022 06:12:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeVjZ-0003rF-Ad; Sat, 01 Oct 2022 06:12:21 +0000
Received: by outflank-mailman (input) for mailman id 414486;
 Sat, 01 Oct 2022 06:12:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeVjX-0003r5-Io; Sat, 01 Oct 2022 06:12:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeVjX-0007VO-0b; Sat, 01 Oct 2022 06:12:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeVjW-00055f-Gr; Sat, 01 Oct 2022 06:12:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeVjW-00081C-GQ; Sat, 01 Oct 2022 06:12:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=V8qS6Bc0iaIXVSe+pRBoquJ6dng5Z5KbAnSVAOZ0tA8=; b=GLNLY/v/C2Y6fVklrP8FgqBgwO
	Ga8CV9cTv3WO/Cy8QEvmJzoS33Jw9PGH9cLtH68jm4iMkVqqSQjdXHDLL/KNp6zkDCYCngy4JmkQ+
	o1UqT71nBUkA5fvSF2PIezYwUN7cmDfBIsWRDe4Ua5velLI0Ea+qbr3yPgY1n8P6h7B4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173390-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173390: trouble: blocked/broken/pass
X-Osstest-Failures:
    ovmf:build-i386:<job status>:broken:regression
    ovmf:build-i386-pvops:<job status>:broken:regression
    ovmf:build-i386-xsm:<job status>:broken:regression
    ovmf:build-i386-xsm:host-install(4):broken:regression
    ovmf:build-i386:host-install(4):broken:regression
    ovmf:build-i386-pvops:host-install(4):broken:regression
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=7aa06237b856fd6f8187cc1715a3fe08ab4e98ed
X-Osstest-Versions-That:
    ovmf=b7213bbd59833fb0786c83a28df5f8244602ab5e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 06:12:18 +0000

flight 173390 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173390/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                      <job status>                 broken
 build-i386-pvops                <job status>                 broken
 build-i386-xsm                  <job status>                 broken
 build-i386-xsm                4 host-install(4)        broken REGR. vs. 173356
 build-i386                    4 host-install(4)        broken REGR. vs. 173356
 build-i386-pvops              4 host-install(4)        broken REGR. vs. 173356

Tests which did not succeed, but are not blocking:
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed
baseline version:
 ovmf                 b7213bbd59833fb0786c83a28df5f8244602ab5e

Last test of basis   173356  2022-09-28 14:40:29 Z    2 days
Testing same since   173386  2022-09-30 12:10:28 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               broken  
 build-amd64                                                  pass    
 build-i386                                                   broken  
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             broken  
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-i386 broken
broken-job build-i386-pvops broken
broken-job build-i386-xsm broken
broken-step build-i386-xsm host-install(4)
broken-step build-i386 host-install(4)
broken-step build-i386-pvops host-install(4)

Not pushing.

------------------------------------------------------------
commit 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed
Author: Rodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>
Date:   Thu Sep 22 15:35:36 2022 +0800

    SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands
    
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077
    
    Following the design described in the TCG specification,
    the driver implementation of the CRB protocol does not require
    enforcing completing the transition to goIdle at the end of a command
    sequence.
    
    Signed-off-by: Rodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>
    Cc: Jiewen Yao <jiewen.yao@intel.com>
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 09:14:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 09:14:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414498.658799 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeYZO-0004nr-Gu; Sat, 01 Oct 2022 09:14:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414498.658799; Sat, 01 Oct 2022 09:14:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeYZO-0004nk-DJ; Sat, 01 Oct 2022 09:14:02 +0000
Received: by outflank-mailman (input) for mailman id 414498;
 Sat, 01 Oct 2022 09:14:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeYZM-0004na-MT; Sat, 01 Oct 2022 09:14:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeYZM-0002Ng-IK; Sat, 01 Oct 2022 09:14:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeYZL-0002h1-VZ; Sat, 01 Oct 2022 09:14:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeYZL-0005aW-V7; Sat, 01 Oct 2022 09:13:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0mJbRHBHG0w4flfRsgVnt47eTAa8yE78116zteN8fxs=; b=6gMTUs8H83HcXdLiPW0EPYO356
	t9V+oKwA6b3NEtPbOtbvYILeWolo8JGtrOIaiDA3ueYpcSeARfF7ht6Yd7ZIjthwKUQ4+j2YZryYe
	zuVXk6Ih53xW0J3Zf4mo7Q5uMWbz77Mw7SAM2bbrCMlkJAhGNko3OfwoRlH830VweFGI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173389-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173389: trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    xen-unstable:build-i386:<job status>:broken:regression
    xen-unstable:build-i386-prev:<job status>:broken:regression
    xen-unstable:build-i386-pvops:<job status>:broken:regression
    xen-unstable:build-i386-xsm:<job status>:broken:regression
    xen-unstable:build-i386-pvops:host-install(4):broken:regression
    xen-unstable:build-i386-prev:host-install(4):broken:regression
    xen-unstable:build-i386-xsm:host-install(4):broken:regression
    xen-unstable:build-i386:host-install(4):broken:regression
    xen-unstable:test-amd64-i386-examine-bios:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine-uefi:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-unstable:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
X-Osstest-Versions-That:
    xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 09:13:59 +0000

flight 173389 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173389/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                      <job status>                 broken
 build-i386-prev                 <job status>                 broken
 build-i386-pvops                <job status>                 broken
 build-i386-xsm                  <job status>                 broken
 build-i386-pvops              4 host-install(4)        broken REGR. vs. 173379
 build-i386-prev               4 host-install(4)        broken REGR. vs. 173379
 build-i386-xsm                4 host-install(4)        broken REGR. vs. 173379
 build-i386                    4 host-install(4)        broken REGR. vs. 173379

Tests which did not succeed, but are not blocking:
 test-amd64-i386-examine-bios  1 build-check(1)               blocked  n/a
 test-amd64-i386-examine-uefi  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-examine       1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173379
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173379
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173379
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173379
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173379
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173379
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173379
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173379
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124
baseline version:
 xen                  211d8419ef8d8a237ff914fd8304b8fefc3ff2cc

Last test of basis   173379  2022-09-30 01:52:22 Z    1 days
Failing since        173385  2022-09-30 11:39:55 Z    0 days    2 attempts
Testing same since   173389  2022-09-30 22:09:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Dmytro Semenets <dmytro_semenets@epam.com>
  Jan Beulich <jbeulich@suse.com>
  Michal Orzel <michal.orzel@amd.com>
  Nathan Studer <nathan.studer@dornerworks.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               broken  
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   broken  
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              broken  
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             broken  
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         blocked 
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-i386 broken
broken-job build-i386-prev broken
broken-job build-i386-pvops broken
broken-job build-i386-xsm broken
broken-step build-i386-pvops host-install(4)
broken-step build-i386-prev host-install(4)
broken-step build-i386-xsm host-install(4)
broken-step build-i386 host-install(4)

Not pushing.

------------------------------------------------------------
commit 1666086b00442b23e4fd70f4971e3bcf1a16b124
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Sep 30 15:16:22 2022 +0200

    x86/NUMA: improve memnode_shift calculation for multi node system
    
    SRAT may describe individual nodes using multiple ranges. When they're
    adjacent (with or without a gap in between), only the start of the first
    such range actually needs accounting for. Furthermore the very first
    range doesn't need considering of its start address at all, as it's fine
    to associate all lower addresses (with no memory) with that same node.
    For this to work, the array of ranges needs to be sorted by address -
    adjust logic accordingly in acpi_numa_memory_affinity_init().
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>

commit 38e1276db4c5457cd6e7811b4e168aa85c8a0b06
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Sep 30 09:56:27 2022 +0200

    Arm/vGIC: adjust gicv3_its_deny_access() to fit other gic*_iomem_deny_access(
    
    While an oversight in 9982fe275ba4 ("arm/vgic: drop const attribute
    from gic_iomem_deny_access()"), the issue really became apparent only
    when iomem_deny_access() was switched to have a non-const first
    parameter.
    
    Fixes: c4e5cc2ccc5b ("x86/ept: limit calls to memory_type_changed()")
    Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Michal Orzel <michal.orzel@amd.com>
    Tested-by: Michal Orzel <michal.orzel@amd.com>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

commit b1f4b45d02cac2bf704c2fcc61c70c3567cfaa5b
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Sep 30 09:55:34 2022 +0200

    x86/NUMA: correct off-by-1 in node map size calculation
    
    extract_lsb_from_nodes() accumulates "memtop" from all PDXes one past
    the covered ranges. Hence the maximum address which can validly by used
    to index the node map is one below this value, and we may currently set
    up a node map with an unused (and never initialized) trailing entry. In
    boundary cases this may also mean we dynamically allocate a page when
    the static (64-entry) map would suffice.
    
    While there also correct the comment ahead of the function, for it to
    match the actual code: Linux commit 54413927f022 ("x86-64:
    x86_64-make-the-numa-hash-function-nodemap-allocation fix fix") removed
    the ORing in of the end address before we actually cloned their code.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Wei Chen <Wei.Chen@arm.com>

commit defa4e51d20a143bdd4395a075bf0933bb38a9a4
Author: Tamas K Lengyel <tamas.lengyel@intel.com>
Date:   Fri Sep 30 09:53:49 2022 +0200

    x86/vpmu: Fix race-condition in vpmu_load
    
    The vPMU code-bases attempts to perform an optimization on saving/reloading the
    PMU context by keeping track of what vCPU ran on each pCPU. When a pCPU is
    getting scheduled, checks if the previous vCPU isn't the current one. If so,
    attempts a call to vpmu_save_force. Unfortunately if the previous vCPU is
    already getting scheduled to run on another pCPU its state will be already
    runnable, which results in an ASSERT failure.
    
    Fix this by always performing a pmu context save in vpmu_save when called from
    vpmu_switch_from, and do a vpmu_load when called from vpmu_switch_to.
    
    While this presents a minimal overhead in case the same vCPU is getting
    rescheduled on the same pCPU, the ASSERT failure is avoided and the code is a
    lot easier to reason about.
    
    Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>

commit fb7485788fd7db3b95f4e7fc9bfdfe9ef38e383f
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Thu Sep 29 10:51:31 2022 +0100

    automation: Information about running containers for a different arch
    
    Adding pointer to 'qemu-user-static'.
    
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Reviewed-by: Michal Orzel <michal.orzel@amd.com>
    Acked-by: Stefano Stabellini <sstabellini@kernel.org>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit a210e94af38a957fcc99db01d2cfcc3039859445
Author: Michal Orzel <michal.orzel@amd.com>
Date:   Mon Sep 19 20:37:37 2022 +0200

    xen/arm: domain_build: Always print the static shared memory region
    
    At the moment, the information about allocating static shared memory
    region is only printed during the debug build. This information can also
    be helpful for the end user (which may not be the same as the person
    building the package), so switch to printk(). Also drop XENLOG_INFO to be
    consistent with other printk() used to print the domain information.
    
    Signed-off-by: Michal Orzel <michal.orzel@amd.com>
    Acked-by: Stefano Stabellini <sstabellini@kernel.org>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit b726541d94bd0a80b5864d17a2cd2e6d73a3fe0a
Author: Jan Beulich <jbeulich@suse.com>
Date:   Thu Sep 29 14:47:45 2022 +0200

    x86: wire up VCPUOP_register_vcpu_time_memory_area for 32-bit guests
    
    Forever sinced its introduction VCPUOP_register_vcpu_time_memory_area
    was available only to native domains. Linux, for example, would attempt
    to use it irrespective of guest bitness (including in its so called
    PVHVM mode) as long as it finds XEN_PVCLOCK_TSC_STABLE_BIT set (which we
    set only for clocksource=tsc, which in turn needs engaging via command
    line option).
    
    Fixes: a5d39947cb89 ("Allow guests to register secondary vcpu_time_info")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit 9214da34a3cb017ff0417900250bd6d18ca89e15
Author: Jan Beulich <jbeulich@suse.com>
Date:   Thu Sep 29 14:46:50 2022 +0200

    x86: re-connect VCPUOP_send_nmi for 32-bit guests
    
    With the "inversion" of VCPUOP handling, processing arch-specific ones
    first, the forwarding of this sub-op from the (common) compat handler to
    (common) non-compat one did no longer have the intended effect. It now
    needs forwarding between the arch-specific handlers.
    
    Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code")
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-acked-by: Henry Wang <Henry.Wang@arm.com>

commit c4e5cc2ccc5b8274d02f7855c4769839989bb349
Author: Roger Pau Monné <roger.pau@citrix.com>
Date:   Thu Sep 29 14:44:10 2022 +0200

    x86/ept: limit calls to memory_type_changed()
    
    memory_type_changed() is currently only implemented for Intel EPT, and
    results in the invalidation of EMT attributes on all the entries in
    the EPT page tables.  Such invalidation causes EPT_MISCONFIG vmexits
    when the guest tries to access any gfns for the first time, which
    results in the recalculation of the EMT for the accessed page.  The
    vmexit and the recalculations are expensive, and as such should be
    avoided when possible.
    
    Remove the call to memory_type_changed() from
    XEN_DOMCTL_memory_mapping: there are no modifications of the
    iomem_caps ranges anymore that could alter the return of
    cache_flush_permitted() from that domctl.
    
    Encapsulate calls to memory_type_changed() resulting from changes to
    the domain iomem_caps or ioport_caps ranges in the helpers themselves
    (io{ports,mem}_{permit,deny}_access()), and add a note in
    epte_get_entry_emt() to remind that changes to the logic there likely
    need to be propagaed to the IO capabilities helpers.
    
    Note changes to the IO ports or memory ranges are not very common
    during guest runtime, but Citrix Hypervisor has an use case for them
    related to device passthrough.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 9982fe275ba4ee1a749b6dde5602a5a79e42b543
Author: Roger Pau Monné <roger.pau@citrix.com>
Date:   Thu Sep 29 14:41:13 2022 +0200

    arm/vgic: drop const attribute from gic_iomem_deny_access()
    
    While correct from a code point of view, the usage of the const
    attribute for the domain parameter of gic_iomem_deny_access() is at
    least partially bogus.  Contents of the domain structure (the iomem
    rangeset) is modified by the function.  Such modifications succeed
    because right now the iomem rangeset is allocated separately from
    struct domain, and hence is not subject to the constness of struct
    domain.
    
    Amend this by dropping the const attribute from the function
    parameter.
    
    This is required by further changes that will convert
    iomem_{permit,deny}_access into a function.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

commit 0db195c1a9947240b354abbefd2afac6c73ad6a8
Author: Jan Beulich <jbeulich@suse.com>
Date:   Thu Sep 29 14:39:52 2022 +0200

    x86/NUMA: correct memnode_shift calculation for single node system
    
    SRAT may describe even a single node system (including such with
    multiple nodes, but only one having any memory) using multiple ranges.
    Hence simply counting the number of ranges (note that function
    parameters are mis-named) is not an indication of the number of nodes in
    use. Since we only care about knowing whether we're on a single node
    system, accounting for this is easy: Increment the local variable only
    when adjacent ranges are for different nodes. That way the count may
    still end up larger than the number of nodes in use, but it won't be
    larger than 1 when only a single node has any memory.
    
    To compensate populate_memnodemap() now needs to be prepared to find
    the correct node ID already in place for a range. (This could of course
    also happen when there's more than one node with memory, while at least
    one node has multiple adjacent ranges, provided extract_lsb_from_nodes()
    would also know to recognize this case.)
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>

commit e1de23b7c1bfa02447a79733e64184b3635e0587
Author: Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
Date:   Thu Sep 29 14:38:22 2022 +0200

    MAINTAINERS: ARINC 653 scheduler maintainer updates
    
    Add Nathan Studer as co-maintainer.
    
    I am departing DornerWorks. I will still be working with Xen in my next
    role, and I still have an interest in co-maintaining the ARINC 653
    scheduler, so change to my personal email address.
    
    Signed-off-by: Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
    Acked-by: Nathan Studer <nathan.studer@dornerworks.com>

commit 3ab6ea992b0e5e1a332bdbc8ae56d72f1b66fcbd
Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Date:   Thu Sep 29 14:38:02 2022 +0200

    tools: remove xenstore entries on vchan server closure
    
    vchan server creates XenStore entries to advertise its event channel and
    ring, but those are not removed after the server quits.
    Add additional cleanup step, so those are removed, so clients do not try
    to connect to a non-existing server.
    
    Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
    Signed-off-by: Dmytro Semenets <dmytro_semenets@epam.com>
    Reviewed-by: Juergen Gross <jgross@suse.com>
    Acked-by: Anthony PERARD <anthony.perard@citrix.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 10:42:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 10:42:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414508.658809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeZwz-0005NE-4L; Sat, 01 Oct 2022 10:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414508.658809; Sat, 01 Oct 2022 10:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeZwz-0005N7-1W; Sat, 01 Oct 2022 10:42:29 +0000
Received: by outflank-mailman (input) for mailman id 414508;
 Sat, 01 Oct 2022 10:42:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeZwy-0005Mx-J8; Sat, 01 Oct 2022 10:42:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeZwy-0003nI-Ey; Sat, 01 Oct 2022 10:42:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeZwy-0004ss-02; Sat, 01 Oct 2022 10:42:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeZwx-0003hM-Vt; Sat, 01 Oct 2022 10:42:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yY+bADkDN7kqSCU/CkpcmKMvNLjTkE0XkFV3UlOnCF4=; b=06RSwj/P+cxU0fgByicZqUoOLa
	6yZTUpVENlcL3KZHLRatD4S15ZBfmmpOYvyVG+TFn3swk5MqbPtWVOMS3teA3i1+UD0gBLY9hz+Tl
	MROIlGdjqfffXXpuXRmBSTiRo37JVno9IXQ8x5wxETatLzorxbzAMPZDaV3Von0bcd0Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173391-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173391: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:build-i386-pvops:<job status>:broken:regression
    linux-linus:build-i386-xsm:<job status>:broken:regression
    linux-linus:build-i386-xsm:host-install(4):broken:regression
    linux-linus:build-i386-pvops:host-install(4):broken:regression
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-saverestore.2:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ffb4d94b4314655cea60ab7962756e6bab72fc7e
X-Osstest-Versions-That:
    linux=511cce163b75bc3933fa3de769a82bb7e8663f2b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 10:42:27 +0000

flight 173391 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173391/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386-pvops                <job status>                 broken
 build-i386-xsm                  <job status>                 broken
 build-i386-xsm                4 host-install(4)        broken REGR. vs. 173364
 build-i386-pvops              4 host-install(4)        broken REGR. vs. 173364
 test-amd64-amd64-freebsd11-amd64 18 guest-saverestore.2  fail REGR. vs. 173364

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173364
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173364
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173364
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173364
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173364
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173364
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                ffb4d94b4314655cea60ab7962756e6bab72fc7e
baseline version:
 linux                511cce163b75bc3933fa3de769a82bb7e8663f2b

Last test of basis   173364  2022-09-29 15:40:21 Z    1 days
Failing since        173378  2022-09-30 00:41:06 Z    1 days    4 attempts
Testing same since   173391  2022-10-01 03:05:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrien Grassein <adrien.grassein@gmail.com>
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Al Viro <viro@zeniv.linux.org.uk>
  Alex Deucher <alexander.deucher@amd.com>
  Alexandre Courbot <acourbot@chromium.org>
  Alvin Lee <Alvin.Lee2@amd.com>
  Andi Shyti <andi.shyti@linux.intel.com>
  Andrzej Hajda <andrzej.hajda@intel.com>
  Angus Chen <angus.chen@jaguarmicro.com>
  Aric Cyr <aric.cyr@amd.com>
  Arnaldo Carvalho de Melo <acme@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Ashutosh Dixit <ashutosh.dixit@intel.com>
  Athira Jajeev <atrajeev@linux.vnet.ibm.com>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  August Wikerfors <git@augustwikerfors.se>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bokun Zhang <Bokun.Zhang@amd.com>
  Brian Norris <briannorris@chromium.org>
  Chris Wilson <chris@chris-wilson.co.uk>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Conor Dooley <conor.dooley@microchip.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  David Matlack <dmatlack@google.com>
  Douglas Anderson <dianders@chromium.org>
  Dylan Yudaken <dylany@fb.com>
  Eli Cohen <elic@nvidia.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Eric Bernstein <eric.bernstein@amd.com>
  Evan Quan <evan.quan@amd.com>
  Fabio Estevam <festevam@denx.de>
  Florian Fainelli <f.fainelli@gmail.com>
  Francesco Dolcini <francesco.dolcini@toradex.com>
  Graham Sider <Graham.Sider@amd.com>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Han Xu <han.xu@nxp.com>
  Hawking Zhang <Hawking.Zhang@amd.com>
  Ian Rogers <irogers@google.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jiadong.Zhu <Jiadong.Zhu@amd.com>
  Jim Mattson <jmattson@google.com>
  Jing Zhang <renyu.zj@linux.alibaba.com>
  Jiri Olsa <jolsa@kernel.org>
  Kees Cook <keescook@chromium.org>
  lei he <helei.sig11@bytedance.com>
  Leo Li <sunpeng.li@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maxime Coquelin <maxime.coquelin@redhat.com>
  Michael Kelley <mikelley@microsoft.com>
  Michael S. Tsirkin <mst@redhat.com>
  Namhyung Kim <namhyung@kernel.org>
  Neil Armstrong <neil.armstrong@linaro.org>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peng Fan <peng.fan@nxp.com>
  Philippe Schenker <philippe.schenker@toradex.com>
  Rafał Miłecki <rafal@milecki.pl>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Samson Tam <samson.tam@amd.com>
  Sean Christopherson <seanjc@google.com>
  Sonny Jiang <sonny.jiang@amd.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Stephen Boyd <sboyd@kernel.org>
  Suwan Kim <suwan.kim027@gmail.com>
  Taimur Hassan <Syed.Hassan@amd.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tina Hsu <tina_hsu@phison.corp-partner.google.com>
  Xing Zhengjun <zhengjun.xing@linux.intel.com>
  Xuan Zhuo <xuanzhuo@linux.alibaba.com>
  Zhengjun Xing <zhengjun.xing@linux.intel.com>
  Zhu Lingshan <lingshan.zhu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               broken  
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             broken  
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-i386-pvops broken
broken-job build-i386-xsm broken
broken-step build-i386-xsm host-install(4)
broken-step build-i386-pvops host-install(4)

Not pushing.

(No revision log; it would be 2276 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 11:24:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 11:24:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414515.658821 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeab5-0001F7-8L; Sat, 01 Oct 2022 11:23:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414515.658821; Sat, 01 Oct 2022 11:23:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeab5-0001F0-4T; Sat, 01 Oct 2022 11:23:55 +0000
Received: by outflank-mailman (input) for mailman id 414515;
 Sat, 01 Oct 2022 11:23:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeab3-0001Eq-RD; Sat, 01 Oct 2022 11:23:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeab3-0004RR-QA; Sat, 01 Oct 2022 11:23:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeab3-0006vK-Bk; Sat, 01 Oct 2022 11:23:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeab3-0007nN-BJ; Sat, 01 Oct 2022 11:23:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Bqxgazd4O3tEHEW+s+4iOUkgD6gtbk0P0snSZgm8hfs=; b=Moh5dNYn8m8PRzApBu4cNg6nyA
	brdju1KxW9xAmLKtnqYihIgllLON5/RqH/JgsjUcYibsGgoZHxo8gAj67ci1t/n7aD4/UfGmxkuno
	fVPgH3h30rRMJMuwExk5dzAtpiXWli4f1oZ9KYjL7GPf5xFxmwXgR68LBuDYm1sGothY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173393-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173393: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=7aa06237b856fd6f8187cc1715a3fe08ab4e98ed
X-Osstest-Versions-That:
    ovmf=b7213bbd59833fb0786c83a28df5f8244602ab5e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 11:23:53 +0000

flight 173393 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173393/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed
baseline version:
 ovmf                 b7213bbd59833fb0786c83a28df5f8244602ab5e

Last test of basis   173356  2022-09-28 14:40:29 Z    2 days
Testing same since   173386  2022-09-30 12:10:28 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rodrigo Gonzalez Del Cueto <rodrigo.gonzalez.del.cueto@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b7213bbd59..7aa06237b8  7aa06237b856fd6f8187cc1715a3fe08ab4e98ed -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 11:48:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 11:48:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414523.658832 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeayW-0003kQ-4r; Sat, 01 Oct 2022 11:48:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414523.658832; Sat, 01 Oct 2022 11:48:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeayW-0003kJ-23; Sat, 01 Oct 2022 11:48:08 +0000
Received: by outflank-mailman (input) for mailman id 414523;
 Sat, 01 Oct 2022 11:48:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeayV-0003k9-Ed; Sat, 01 Oct 2022 11:48:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeayV-0004ob-Ci; Sat, 01 Oct 2022 11:48:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeayU-00081f-VL; Sat, 01 Oct 2022 11:48:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeayU-00069p-Ru; Sat, 01 Oct 2022 11:48:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rONOKBp97UtNLr1zF3qVbXokN8kV6+hwj4OBkeFE/0U=; b=faxuEjjneTGpG02mR8fuS8rfV+
	hK84KM5i0j7B5pwSQbF4dGxQRBoYnCMxGpRicvqP3ngcqZE4YJKsWqHTkuUS51xOedpqQ+03RD72h
	r4x28MiMGrkEuXeXf4GdFrNR3Jb0T6NQz99rbzx66dJsZ/e2BbHZNaV9szSb36lQpJ/0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173392-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173392: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=30899c65a2c6860c714be14f14d97e7e2dcf9c4e
X-Osstest-Versions-That:
    libvirt=8ead926cb46f1892116cb56aa89390d194ce0b71
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 11:48:06 +0000

flight 173392 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173392/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173345
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173345
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173345
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              30899c65a2c6860c714be14f14d97e7e2dcf9c4e
baseline version:
 libvirt              8ead926cb46f1892116cb56aa89390d194ce0b71

Last test of basis   173345  2022-09-28 04:20:21 Z    3 days
Failing since        173381  2022-09-30 04:18:50 Z    1 days    2 attempts
Testing same since   173392  2022-10-01 04:18:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jim Fehlig <jfehlig@suse.com>
  Ján Tomko <jtomko@redhat.com>
  Kristina Hanicova <khanicov@redhat.com>
  Lin Ma <lma@suse.com>
  Michal Privoznik <mprivozn@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   8ead926cb4..30899c65a2  30899c65a2c6860c714be14f14d97e7e2dcf9c4e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 15:33:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 15:33:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414548.658858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeeUo-0000PU-9V; Sat, 01 Oct 2022 15:33:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414548.658858; Sat, 01 Oct 2022 15:33:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeeUo-0000PN-6S; Sat, 01 Oct 2022 15:33:42 +0000
Received: by outflank-mailman (input) for mailman id 414548;
 Sat, 01 Oct 2022 15:33:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeUn-0000P7-07; Sat, 01 Oct 2022 15:33:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeUm-0008K5-Tf; Sat, 01 Oct 2022 15:33:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeUm-0006sy-Gb; Sat, 01 Oct 2022 15:33:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeUm-0002Va-E1; Sat, 01 Oct 2022 15:33:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3cu0XZL6g6HyNodzSVJn/xV9zEL5eeGTkhLtYdRbJyg=; b=bb54WfOdGP36ANVcXIuGISreAb
	p6QRjduvkm0dDRiDrm947jd2S4Iu5HMYYFo8pqd5ts+lSD8N1omrBOL/Z4V/51cCAnslFagsVUkJN
	5FrhTTrRWtVkGsBeqduXTIrHZUoW4CjuPnacLIWmV7TAvqoxQgUgXYtOk0+ZkPUp7KAs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173394-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173394: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
X-Osstest-Versions-That:
    xen=211d8419ef8d8a237ff914fd8304b8fefc3ff2cc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 15:33:40 +0000

flight 173394 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173394/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173379
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173379
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173379
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173379
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173379
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173379
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173379
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173379
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173379
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173379
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173379
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173379
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124
baseline version:
 xen                  211d8419ef8d8a237ff914fd8304b8fefc3ff2cc

Last test of basis   173379  2022-09-30 01:52:22 Z    1 days
Failing since        173385  2022-09-30 11:39:55 Z    1 days    3 attempts
Testing same since   173389  2022-09-30 22:09:42 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Dmytro Semenets <dmytro_semenets@epam.com>
  Jan Beulich <jbeulich@suse.com>
  Michal Orzel <michal.orzel@amd.com>
  Nathan Studer <nathan.studer@dornerworks.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tamas K Lengyel <tamas.lengyel@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   211d8419ef..1666086b00  1666086b00442b23e4fd70f4971e3bcf1a16b124 -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 15:43:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 15:43:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414565.658906 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeeeH-0002LA-KH; Sat, 01 Oct 2022 15:43:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414565.658906; Sat, 01 Oct 2022 15:43:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeeeH-0002L3-HX; Sat, 01 Oct 2022 15:43:29 +0000
Received: by outflank-mailman (input) for mailman id 414565;
 Sat, 01 Oct 2022 15:43:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeeG-0002Kt-QB; Sat, 01 Oct 2022 15:43:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeeG-0008UL-Mn; Sat, 01 Oct 2022 15:43:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeeG-0007FL-71; Sat, 01 Oct 2022 15:43:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeeeG-00067e-6W; Sat, 01 Oct 2022 15:43:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/GLcrzfVxswKWY3GjmrsFXi3bO64HRRO7nIRL0/mVZQ=; b=BcGJ8HclMAidXWgcwBGB0Cr9S0
	8CUc0Y8J11hHrTyys38WBixiovBz0U668OnyCpG/wmCPF/Nzs22UIBbYXXxa+WaoWLUOYBAs+HfaI
	Sp1/7lAAr8uKjAXnrMhga7yh8RkwBz12y4VRFKgsonEUHm+0LU1SCrczc7vwu9dUpK18=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173396-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173396: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=6a2b20ff97e4256970644a07f74a4c5655bf5072
X-Osstest-Versions-That:
    ovmf=7aa06237b856fd6f8187cc1715a3fe08ab4e98ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 15:43:28 +0000

flight 173396 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173396/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 6a2b20ff97e4256970644a07f74a4c5655bf5072
baseline version:
 ovmf                 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed

Last test of basis   173393  2022-10-01 06:14:08 Z    0 days
Testing same since   173396  2022-10-01 11:42:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jeff Brasen <jbrasen@nvidia.com>
  Jeff Brasen via groups.io <jbrasen=nvidia.com@groups.io>
  Liming Gao <gaoliming@byosoft.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   7aa06237b8..6a2b20ff97  6a2b20ff97e4256970644a07f74a4c5655bf5072 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 18:07:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 18:07:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414579.658917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oegtn-0007pp-0G; Sat, 01 Oct 2022 18:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414579.658917; Sat, 01 Oct 2022 18:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oegtm-0007pi-Tb; Sat, 01 Oct 2022 18:07:38 +0000
Received: by outflank-mailman (input) for mailman id 414579;
 Sat, 01 Oct 2022 18:07:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oegtk-0007pW-RT; Sat, 01 Oct 2022 18:07:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oegtk-0002qj-Nq; Sat, 01 Oct 2022 18:07:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oegtk-0002LV-Ap; Sat, 01 Oct 2022 18:07:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oegtk-0003VZ-AM; Sat, 01 Oct 2022 18:07:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oCealOOwVI5y5rpGdayWgDrQIWxRxVPBPv+6be3Rvzw=; b=UiqvF8VLbxBTESzKKLB5rmoTux
	SeWhLRUMouR0z+NUkhqX3ZP6WiT6s4yag9lXn/CIjSLS/b6pc38Ds2EcGH6gTb6I+dCFso+rc07TS
	ju9m7PKIES7+2+0F4WI39HTg7I1WGnV1yYINA2jAnqEnfUCSbaCkzklukSxvbeili/Ak=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173395-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173395: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ffb4d94b4314655cea60ab7962756e6bab72fc7e
X-Osstest-Versions-That:
    linux=511cce163b75bc3933fa3de769a82bb7e8663f2b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 18:07:36 +0000

flight 173395 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173395/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173364
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173364
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173364
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173364
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173364
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173364
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                ffb4d94b4314655cea60ab7962756e6bab72fc7e
baseline version:
 linux                511cce163b75bc3933fa3de769a82bb7e8663f2b

Last test of basis   173364  2022-09-29 15:40:21 Z    2 days
Failing since        173378  2022-09-30 00:41:06 Z    1 days    5 attempts
Testing same since   173391  2022-10-01 03:05:01 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrien Grassein <adrien.grassein@gmail.com>
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Al Viro <viro@zeniv.linux.org.uk>
  Alex Deucher <alexander.deucher@amd.com>
  Alexandre Courbot <acourbot@chromium.org>
  Alvin Lee <Alvin.Lee2@amd.com>
  Andi Shyti <andi.shyti@linux.intel.com>
  Andrzej Hajda <andrzej.hajda@intel.com>
  Angus Chen <angus.chen@jaguarmicro.com>
  Aric Cyr <aric.cyr@amd.com>
  Arnaldo Carvalho de Melo <acme@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Ashutosh Dixit <ashutosh.dixit@intel.com>
  Athira Jajeev <atrajeev@linux.vnet.ibm.com>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  August Wikerfors <git@augustwikerfors.se>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bokun Zhang <Bokun.Zhang@amd.com>
  Brian Norris <briannorris@chromium.org>
  Chris Wilson <chris@chris-wilson.co.uk>
  Christian König <christian.koenig@amd.com>
  Christoph Hellwig <hch@lst.de>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Conor Dooley <conor.dooley@microchip.com>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  David Matlack <dmatlack@google.com>
  Douglas Anderson <dianders@chromium.org>
  Dylan Yudaken <dylany@fb.com>
  Eli Cohen <elic@nvidia.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Eric Bernstein <eric.bernstein@amd.com>
  Evan Quan <evan.quan@amd.com>
  Fabio Estevam <festevam@denx.de>
  Florian Fainelli <f.fainelli@gmail.com>
  Francesco Dolcini <francesco.dolcini@toradex.com>
  Graham Sider <Graham.Sider@amd.com>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Han Xu <han.xu@nxp.com>
  Hawking Zhang <Hawking.Zhang@amd.com>
  Ian Rogers <irogers@google.com>
  Jasdeep Dhillon <jdhillon@amd.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jiadong.Zhu <Jiadong.Zhu@amd.com>
  Jim Mattson <jmattson@google.com>
  Jing Zhang <renyu.zj@linux.alibaba.com>
  Jiri Olsa <jolsa@kernel.org>
  Kees Cook <keescook@chromium.org>
  lei he <helei.sig11@bytedance.com>
  Leo Li <sunpeng.li@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maxime Coquelin <maxime.coquelin@redhat.com>
  Michael Kelley <mikelley@microsoft.com>
  Michael S. Tsirkin <mst@redhat.com>
  Namhyung Kim <namhyung@kernel.org>
  Neil Armstrong <neil.armstrong@linaro.org>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peng Fan <peng.fan@nxp.com>
  Philippe Schenker <philippe.schenker@toradex.com>
  Rafał Miłecki <rafal@milecki.pl>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Samson Tam <samson.tam@amd.com>
  Sean Christopherson <seanjc@google.com>
  Sonny Jiang <sonny.jiang@amd.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Stephen Boyd <sboyd@kernel.org>
  Suwan Kim <suwan.kim027@gmail.com>
  Taimur Hassan <Syed.Hassan@amd.com>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tina Hsu <tina_hsu@phison.corp-partner.google.com>
  Xing Zhengjun <zhengjun.xing@linux.intel.com>
  Xuan Zhuo <xuanzhuo@linux.alibaba.com>
  Zhengjun Xing <zhengjun.xing@linux.intel.com>
  Zhu Lingshan <lingshan.zhu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   511cce163b75..ffb4d94b4314  ffb4d94b4314655cea60ab7962756e6bab72fc7e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 01 23:44:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 01 Oct 2022 23:44:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414601.658927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oem9x-0005Vr-MF; Sat, 01 Oct 2022 23:44:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414601.658927; Sat, 01 Oct 2022 23:44:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oem9x-0005Vk-Jc; Sat, 01 Oct 2022 23:44:41 +0000
Received: by outflank-mailman (input) for mailman id 414601;
 Sat, 01 Oct 2022 23:44:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oem9w-0005Va-Ir; Sat, 01 Oct 2022 23:44:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oem9w-0008Bx-F1; Sat, 01 Oct 2022 23:44:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oem9v-0005lo-TJ; Sat, 01 Oct 2022 23:44:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oem9v-0000kh-Sn; Sat, 01 Oct 2022 23:44:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1UZpXjiIEgVr4s0B8ddjks4ev9LlydEqEc2fQaKlHVM=; b=crNvrD/btsRMiutfU6TGXMHCgE
	5g1dOzAk4+z5eKJ3tyy7QjgGjka5m9pIRBNZC9NicsP+/EyyOMqWriIgQoCK2+bSEirWTmiE74w3f
	e+v9qm0ioZ0zJId4jT+NcCSD+pQkCTu1qAiiljMED6D9CumBdZSip/7KT64wLcUlS128=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173397-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173397: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b357fd1c2afc1a3e1b73dc4574bb7ac0e3bd4193
X-Osstest-Versions-That:
    linux=ffb4d94b4314655cea60ab7962756e6bab72fc7e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 01 Oct 2022 23:44:39 +0000

flight 173397 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173397/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173395
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173395
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173395
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173395
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173395
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173395
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173395
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173395
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                b357fd1c2afc1a3e1b73dc4574bb7ac0e3bd4193
baseline version:
 linux                ffb4d94b4314655cea60ab7962756e6bab72fc7e

Last test of basis   173395  2022-10-01 11:13:16 Z    0 days
Testing same since   173397  2022-10-01 18:13:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Andrew Morton <akpm@linux-foundation.org>
  Brian Norris <briannorris@chromium.org>
  Florian Westphal <fw@strlen.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Hangyu Hua <hbh25y@gmail.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Hongling Zeng <zenghongling@kylinos.cn>
  Levi Yun <ppbuk5246@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Michal Hocko <mhocko@suse.com>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Nicolas Dufresne <nicolas.dufresne@collabora.com>
  Nícolas F. R. A. Prado <nfraprado@collabora.com>
  Patrice Chotard <patrice.chotard@foss.st.com>
  Ricardo Ribalda <ribalda@chromium.org>
  SeongJae Park <sj@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   ffb4d94b4314..b357fd1c2afc  b357fd1c2afc1a3e1b73dc4574bb7ac0e3bd4193 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 08:09:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 08:09:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414621.658938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeu2E-0004oZ-4g; Sun, 02 Oct 2022 08:09:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414621.658938; Sun, 02 Oct 2022 08:09:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeu2E-0004oS-26; Sun, 02 Oct 2022 08:09:14 +0000
Received: by outflank-mailman (input) for mailman id 414621;
 Sun, 02 Oct 2022 08:09:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeu2D-0004oI-2e; Sun, 02 Oct 2022 08:09:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeu2C-0003e8-Us; Sun, 02 Oct 2022 08:09:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oeu2C-0008UZ-IZ; Sun, 02 Oct 2022 08:09:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oeu2C-0000Ek-Hd; Sun, 02 Oct 2022 08:09:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mAY087mvkGf90XuQKVjVF2bU9rHABI9EeOlsMCvSUq0=; b=en7qPZjL3dC/Flqu+iYntl3LiL
	C3SsvU2GK/KJ0XZyKA/p0ioqnfoxLGsv7wK+UEe0O3uVzY1J8pJVAAtQgU9VamLFQtkOrUzIP7cGI
	/hCmQmWWBeIU+AGmvDaXGhEiEc97VeblWwOzXawBjaiTsbfCiE29yJbyY3YEY811OUWo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173398-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173398: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
X-Osstest-Versions-That:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 02 Oct 2022 08:09:12 +0000

flight 173398 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173398/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173394
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173394
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173394
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173394
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173394
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173394
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173394
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173394
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173394
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173394
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173394
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173394
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124
baseline version:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124

Last test of basis   173398  2022-10-02 01:56:23 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:14:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:14:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414637.658950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oev2j-0003Hv-S9; Sun, 02 Oct 2022 09:13:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414637.658950; Sun, 02 Oct 2022 09:13:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oev2j-0003Ho-O8; Sun, 02 Oct 2022 09:13:49 +0000
Received: by outflank-mailman (input) for mailman id 414637;
 Sun, 02 Oct 2022 09:13:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oev2i-0003He-Mp; Sun, 02 Oct 2022 09:13:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oev2i-0004lh-Dx; Sun, 02 Oct 2022 09:13:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oev2i-0001Vq-1r; Sun, 02 Oct 2022 09:13:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oev2i-0008OX-0p; Sun, 02 Oct 2022 09:13:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=trxYJivEWWgPhBJuSKOWWV6J+uTOnTEDkGy02m1294Q=; b=I5QwaV87wMR4GBEE+uQuKPXcrX
	jNVqIZFZINQKnXlHuj62VATW6QWpm2ncL3dX8YrAriPVnVP/WdQ7uBBTHGwyH/9Pnr81dz/UZfFs/
	RshHJGuQ0x048spu5IWh1ROvXTmQBVwh4r+dHx3qxbT67oHVpZYRN+qfpird8D1pI2Qc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173399-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173399: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f01d3ee12caf5eae4ece4fc5b85c57c56fb06cc0
X-Osstest-Versions-That:
    ovmf=6a2b20ff97e4256970644a07f74a4c5655bf5072
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 02 Oct 2022 09:13:48 +0000

flight 173399 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173399/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f01d3ee12caf5eae4ece4fc5b85c57c56fb06cc0
baseline version:
 ovmf                 6a2b20ff97e4256970644a07f74a4c5655bf5072

Last test of basis   173396  2022-10-01 11:42:04 Z    0 days
Testing same since   173399  2022-10-02 05:41:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Konstantin Aladyshev <aladyshev22@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6a2b20ff97..f01d3ee12c  f01d3ee12caf5eae4ece4fc5b85c57c56fb06cc0 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:56:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:56:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414646.658972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviG-0007k7-Bt; Sun, 02 Oct 2022 09:56:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414646.658972; Sun, 02 Oct 2022 09:56:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviG-0007ju-8d; Sun, 02 Oct 2022 09:56:44 +0000
Received: by outflank-mailman (input) for mailman id 414646;
 Sun, 02 Oct 2022 09:56:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1oeviD-0007U5-UD
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 09:56:42 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 82c234b1-4238-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 11:56:40 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6CE2360EA5;
 Sun,  2 Oct 2022 09:56:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99CEFC433D7;
 Sun,  2 Oct 2022 09:56:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82c234b1-4238-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664704598;
	bh=lpQ4+WmITmtmOnKFnxuwxQHGwlCFJ4zTtvospQM9GKk=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=u75V4g0DaCA0ZQDJyuudL0J6EFnCEVUdstGm9JIJ8+8/bo6JA2B8PIvyXoOX8/Qaz
	 AqZLqOlFoTNZ9lEyARC2NMC2meCMsnddw32aGqID86u4rY+pnQsR9zn/YZn+za7Yak
	 hsLQxoo+S0DkynDmIJbMsZDmYz4C6sK5vZcSaubpeT57g+18nMkQuQcKdiycn6NS5w
	 sR3XMwywW2gTcPJ1QsFZzxmiiL035nOOau/JoCE0zU41hZxxiyf8olX9yEQHoCljY/
	 ArHOoEtzIlCx410w7dZksLlUzN19E5vFGi9MRC3HHTytmhIaFwf1KqxhZPnssjhw0C
	 CEX+v95o9W59g==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [RFC PATCH 1/5] efi: Move EFI fake memmap support into x86 arch tree
Date: Sun,  2 Oct 2022 11:56:22 +0200
Message-Id: <20221002095626.484279-2-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221002095626.484279-1-ardb@kernel.org>
References: <20221002095626.484279-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=11648; i=ardb@kernel.org; h=from:subject; bh=lpQ4+WmITmtmOnKFnxuwxQHGwlCFJ4zTtvospQM9GKk=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOWA8zvxr8yONNNbEpLG35L+GKpYlawmf5lOH3UFh k0+XysqJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzlgPAAKCRDDTyI5ktmPJHYaDA CRLj6/2ttCOAAK4GTtMzxeOtLDKOJFAVwaYboNA2SQYX1qMGjuRiSvqojDy9pdF/R2PSMfaLmujBG4 fgQl9zJoPjcdeC1T/S6aFhzAIAkLZEAUnl+zXy2BwAPDeFc5pDVBxDcChOtGagbTd7pwuKWTQn3Vub nXcsrE5HRxjO4Q+NnZkN/Gb6Y2E3uddNEjXq+Oy8cxgdP+avcw/7GsU9KXc8nErIDkSmASjXCgpgxf bs1/QzX8+Bp0c7e6S7iU1g99Ji1OaDAz8wKxkZZ9TiNbwyVakn4TXRQp8MViBUAKQPj0i6EBrr50/l hfLu49cGYMC40JfTfGiA2LhHRNU3Pc6y4KPOK0ELP1EQXTM3wRys8J9axZ1bVOhd3IOJMRITiQSWyP jto7fbaG8fltwSIpO3q1pCQTRjroXNSiNeNhwjlgNI591kEz3JmvSl04qwnwC4pYVCqEPsSfPxUZ7P Wqc/BvKHiiMh350PPaQFHMMhXHEUwKfJ+r5VGXlDDtWf8=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

The EFI fake memmap support is specific to x86, which manipulates the
EFI memory map in various different ways after receiving it from the EFI
stub. On other architectures, we have manages to push back on this, and
the EFI memory map is kept pristine.

So let's move the fake memmap code into the x86 arch tree, where it
arguably belongs.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/Kconfig                                       | 20 +++++
 arch/x86/include/asm/efi.h                             |  5 ++
 arch/x86/kernel/setup.c                                |  1 +
 arch/x86/platform/efi/Makefile                         |  1 +
 {drivers/firmware => arch/x86/platform}/efi/fake_mem.c | 79 +++++++++++++++++++-
 drivers/firmware/efi/Kconfig                           | 22 ------
 drivers/firmware/efi/Makefile                          |  4 -
 drivers/firmware/efi/fake_mem.h                        | 10 ---
 drivers/firmware/efi/x86_fake_mem.c                    | 75 -------------------
 include/linux/efi.h                                    |  6 --
 10 files changed, 103 insertions(+), 120 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index f9920f1341c8..b98941c2fec4 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1978,6 +1978,26 @@ config EFI_MIXED
 
 	  If unsure, say N.
 
+config EFI_FAKE_MEMMAP
+	bool "Enable EFI fake memory map"
+	depends on EFI
+	help
+	  Saying Y here will enable "efi_fake_mem" boot option.  By specifying
+	  this parameter, you can add arbitrary attribute to specific memory
+	  range by updating original (firmware provided) EFI memmap.  This is
+	  useful for debugging of EFI memmap related feature, e.g., Address
+	  Range Mirroring feature.
+
+config EFI_MAX_FAKE_MEM
+	int "maximum allowable number of ranges in efi_fake_mem boot option"
+	depends on EFI_FAKE_MEMMAP
+	range 1 128
+	default 8
+	help
+	  Maximum allowable number of ranges in efi_fake_mem boot option.
+	  Ranges can be set up to this value using comma-separated list.
+	  The default value is 8.
+
 source "kernel/Kconfig.hz"
 
 config KEXEC
diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
index 897ea4aec16e..68414d924332 100644
--- a/arch/x86/include/asm/efi.h
+++ b/arch/x86/include/asm/efi.h
@@ -404,10 +404,15 @@ static inline void efi_reserve_boot_services(void)
 
 #ifdef CONFIG_EFI_FAKE_MEMMAP
 extern void __init efi_fake_memmap_early(void);
+extern void __init efi_fake_memmap(void);
 #else
 static inline void efi_fake_memmap_early(void)
 {
 }
+
+static inline void efi_fake_memmap(void)
+{
+}
 #endif
 
 #define arch_ima_efi_boot_mode	\
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 216fee7144ee..41ec3a69f3c7 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -31,6 +31,7 @@
 #include <xen/xen.h>
 
 #include <asm/apic.h>
+#include <asm/efi.h>
 #include <asm/numa.h>
 #include <asm/bios_ebda.h>
 #include <asm/bugs.h>
diff --git a/arch/x86/platform/efi/Makefile b/arch/x86/platform/efi/Makefile
index a50245157685..b481719b16cc 100644
--- a/arch/x86/platform/efi/Makefile
+++ b/arch/x86/platform/efi/Makefile
@@ -4,3 +4,4 @@ GCOV_PROFILE := n
 
 obj-$(CONFIG_EFI) 		+= quirks.o efi.o efi_$(BITS).o efi_stub_$(BITS).o
 obj-$(CONFIG_EFI_MIXED)		+= efi_thunk_$(BITS).o
+obj-$(CONFIG_EFI_FAKE_MEMMAP)	+= fake_mem.o
diff --git a/drivers/firmware/efi/fake_mem.c b/arch/x86/platform/efi/fake_mem.c
similarity index 58%
rename from drivers/firmware/efi/fake_mem.c
rename to arch/x86/platform/efi/fake_mem.c
index 6e0f34a38171..41d57cad3d84 100644
--- a/drivers/firmware/efi/fake_mem.c
+++ b/arch/x86/platform/efi/fake_mem.c
@@ -17,10 +17,13 @@
 #include <linux/memblock.h>
 #include <linux/types.h>
 #include <linux/sort.h>
-#include "fake_mem.h"
+#include <asm/e820/api.h>
+#include <asm/efi.h>
 
-struct efi_mem_range efi_fake_mems[EFI_MAX_FAKEMEM];
-int nr_fake_mem;
+#define EFI_MAX_FAKEMEM CONFIG_EFI_MAX_FAKE_MEM
+
+static struct efi_mem_range efi_fake_mems[EFI_MAX_FAKEMEM];
+static int nr_fake_mem;
 
 static int __init cmp_fake_mem(const void *x1, const void *x2)
 {
@@ -122,3 +125,73 @@ static int __init setup_fake_mem(char *p)
 }
 
 early_param("efi_fake_mem", setup_fake_mem);
+
+void __init efi_fake_memmap_early(void)
+{
+	int i;
+
+	/*
+	 * The late efi_fake_mem() call can handle all requests if
+	 * EFI_MEMORY_SP support is disabled.
+	 */
+	if (!efi_soft_reserve_enabled())
+		return;
+
+	if (!efi_enabled(EFI_MEMMAP) || !nr_fake_mem)
+		return;
+
+	/*
+	 * Given that efi_fake_memmap() needs to perform memblock
+	 * allocations it needs to run after e820__memblock_setup().
+	 * However, if efi_fake_mem specifies EFI_MEMORY_SP for a given
+	 * address range that potentially needs to mark the memory as
+	 * reserved prior to e820__memblock_setup(). Update e820
+	 * directly if EFI_MEMORY_SP is specified for an
+	 * EFI_CONVENTIONAL_MEMORY descriptor.
+	 */
+	for (i = 0; i < nr_fake_mem; i++) {
+		struct efi_mem_range *mem = &efi_fake_mems[i];
+		efi_memory_desc_t *md;
+		u64 m_start, m_end;
+
+		if ((mem->attribute & EFI_MEMORY_SP) == 0)
+			continue;
+
+		m_start = mem->range.start;
+		m_end = mem->range.end;
+		for_each_efi_memory_desc(md) {
+			u64 start, end, size;
+
+			if (md->type != EFI_CONVENTIONAL_MEMORY)
+				continue;
+
+			start = md->phys_addr;
+			end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+
+			if (m_start <= end && m_end >= start)
+				/* fake range overlaps descriptor */;
+			else
+				continue;
+
+			/*
+			 * Trim the boundary of the e820 update to the
+			 * descriptor in case the fake range overlaps
+			 * !EFI_CONVENTIONAL_MEMORY
+			 */
+			start = max(start, m_start);
+			end = min(end, m_end);
+			size = end - start + 1;
+
+			if (end <= start)
+				continue;
+
+			/*
+			 * Ensure each efi_fake_mem instance results in
+			 * a unique e820 resource
+			 */
+			e820__range_remove(start, size, E820_TYPE_RAM, 1);
+			e820__range_add(start, size, E820_TYPE_SOFT_RESERVED);
+			e820__update_table(e820_table);
+		}
+	}
+}
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 4f7e65293297..fceeea74522e 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -37,28 +37,6 @@ config EFI_RUNTIME_MAP
 
 	  See also Documentation/ABI/testing/sysfs-firmware-efi-runtime-map.
 
-config EFI_FAKE_MEMMAP
-	bool "Enable EFI fake memory map"
-	depends on EFI && X86
-	default n
-	help
-	  Saying Y here will enable "efi_fake_mem" boot option.
-	  By specifying this parameter, you can add arbitrary attribute
-	  to specific memory range by updating original (firmware provided)
-	  EFI memmap.
-	  This is useful for debugging of EFI memmap related feature.
-	  e.g. Address Range Mirroring feature.
-
-config EFI_MAX_FAKE_MEM
-	int "maximum allowable number of ranges in efi_fake_mem boot option"
-	depends on EFI_FAKE_MEMMAP
-	range 1 128
-	default 8
-	help
-	  Maximum allowable number of ranges in efi_fake_mem boot option.
-	  Ranges can be set up to this value using comma-separated list.
-	  The default value is 8.
-
 config EFI_SOFT_RESERVE
 	bool "Reserve EFI Specific Purpose Memory"
 	depends on EFI && EFI_STUB && ACPI_HMAT
diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
index 8d151e332584..8e4f0d5b26e5 100644
--- a/drivers/firmware/efi/Makefile
+++ b/drivers/firmware/efi/Makefile
@@ -23,7 +23,6 @@ obj-$(CONFIG_UEFI_CPER)			+= cper.o
 obj-$(CONFIG_EFI_RUNTIME_MAP)		+= runtime-map.o
 obj-$(CONFIG_EFI_RUNTIME_WRAPPERS)	+= runtime-wrappers.o
 subdir-$(CONFIG_EFI_STUB)		+= libstub
-obj-$(CONFIG_EFI_FAKE_MEMMAP)		+= fake_map.o
 obj-$(CONFIG_EFI_BOOTLOADER_CONTROL)	+= efibc.o
 obj-$(CONFIG_EFI_TEST)			+= test/
 obj-$(CONFIG_EFI_DEV_PATH_PARSER)	+= dev-path-parser.o
@@ -32,9 +31,6 @@ obj-$(CONFIG_EFI_RCI2_TABLE)		+= rci2-table.o
 obj-$(CONFIG_EFI_EMBEDDED_FIRMWARE)	+= embedded-firmware.o
 obj-$(CONFIG_LOAD_UEFI_KEYS)		+= mokvar-table.o
 
-fake_map-y				+= fake_mem.o
-fake_map-$(CONFIG_X86)			+= x86_fake_mem.o
-
 obj-$(CONFIG_SYSFB)			+= sysfb_efi.o
 
 arm-obj-$(CONFIG_EFI)			:= efi-init.o arm-runtime.o
diff --git a/drivers/firmware/efi/fake_mem.h b/drivers/firmware/efi/fake_mem.h
deleted file mode 100644
index d52791af4b18..000000000000
--- a/drivers/firmware/efi/fake_mem.h
+++ /dev/null
@@ -1,10 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __EFI_FAKE_MEM_H__
-#define __EFI_FAKE_MEM_H__
-#include <asm/efi.h>
-
-#define EFI_MAX_FAKEMEM CONFIG_EFI_MAX_FAKE_MEM
-
-extern struct efi_mem_range efi_fake_mems[EFI_MAX_FAKEMEM];
-extern int nr_fake_mem;
-#endif /* __EFI_FAKE_MEM_H__ */
diff --git a/drivers/firmware/efi/x86_fake_mem.c b/drivers/firmware/efi/x86_fake_mem.c
deleted file mode 100644
index 0bafcc1bb0f6..000000000000
--- a/drivers/firmware/efi/x86_fake_mem.c
+++ /dev/null
@@ -1,75 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Copyright(c) 2019 Intel Corporation. All rights reserved. */
-#include <linux/efi.h>
-#include <asm/e820/api.h>
-#include "fake_mem.h"
-
-void __init efi_fake_memmap_early(void)
-{
-	int i;
-
-	/*
-	 * The late efi_fake_mem() call can handle all requests if
-	 * EFI_MEMORY_SP support is disabled.
-	 */
-	if (!efi_soft_reserve_enabled())
-		return;
-
-	if (!efi_enabled(EFI_MEMMAP) || !nr_fake_mem)
-		return;
-
-	/*
-	 * Given that efi_fake_memmap() needs to perform memblock
-	 * allocations it needs to run after e820__memblock_setup().
-	 * However, if efi_fake_mem specifies EFI_MEMORY_SP for a given
-	 * address range that potentially needs to mark the memory as
-	 * reserved prior to e820__memblock_setup(). Update e820
-	 * directly if EFI_MEMORY_SP is specified for an
-	 * EFI_CONVENTIONAL_MEMORY descriptor.
-	 */
-	for (i = 0; i < nr_fake_mem; i++) {
-		struct efi_mem_range *mem = &efi_fake_mems[i];
-		efi_memory_desc_t *md;
-		u64 m_start, m_end;
-
-		if ((mem->attribute & EFI_MEMORY_SP) == 0)
-			continue;
-
-		m_start = mem->range.start;
-		m_end = mem->range.end;
-		for_each_efi_memory_desc(md) {
-			u64 start, end, size;
-
-			if (md->type != EFI_CONVENTIONAL_MEMORY)
-				continue;
-
-			start = md->phys_addr;
-			end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
-
-			if (m_start <= end && m_end >= start)
-				/* fake range overlaps descriptor */;
-			else
-				continue;
-
-			/*
-			 * Trim the boundary of the e820 update to the
-			 * descriptor in case the fake range overlaps
-			 * !EFI_CONVENTIONAL_MEMORY
-			 */
-			start = max(start, m_start);
-			end = min(end, m_end);
-			size = end - start + 1;
-
-			if (end <= start)
-				continue;
-
-			/*
-			 * Ensure each efi_fake_mem instance results in
-			 * a unique e820 resource
-			 */
-			e820__range_remove(start, size, E820_TYPE_RAM, 1);
-			e820__range_add(start, size, E820_TYPE_SOFT_RESERVED);
-			e820__update_table(e820_table);
-		}
-	}
-}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index e739196ce9b2..a6dbf354d2c3 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -749,12 +749,6 @@ extern struct kobject *efi_kobj;
 extern int efi_reboot_quirk_mode;
 extern bool efi_poweroff_required(void);
 
-#ifdef CONFIG_EFI_FAKE_MEMMAP
-extern void __init efi_fake_memmap(void);
-#else
-static inline void efi_fake_memmap(void) { }
-#endif
-
 extern unsigned long efi_mem_attr_table;
 
 /*
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:56:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:56:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414645.658961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviC-0007UI-4h; Sun, 02 Oct 2022 09:56:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414645.658961; Sun, 02 Oct 2022 09:56:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviC-0007UB-1J; Sun, 02 Oct 2022 09:56:40 +0000
Received: by outflank-mailman (input) for mailman id 414645;
 Sun, 02 Oct 2022 09:56:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1oeviA-0007U5-PW
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 09:56:38 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80a7726a-4238-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 11:56:37 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id AC23E60EA2;
 Sun,  2 Oct 2022 09:56:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29E61C433D6;
 Sun,  2 Oct 2022 09:56:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80a7726a-4238-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664704595;
	bh=7esb6YPYkrd+cv3sS3o+s4EfXDusBD+g0wEqShG+32A=;
	h=From:To:Cc:Subject:Date:From;
	b=Ss07N6JmrKfUNdOIENH6an0d3hWbHND736qLLMDXCxQM2oV4U1cDSRv6nJxu2LLEq
	 Mk7qpOotNHug4RUHT4u9kC57w/LglOizLgvaOIUPvnmy477ScfkxZrR0kDD2LAR6cI
	 LtpD0H8D1PQIpzPIMImjJ9t6yR/akd05lY4iDQwZnOVgP8nDkGmeSKX145fcXRZ0gG
	 Zk3cKVHe+uonWMKGYcGLVT43hcoQmc106v+uVRfSods3/DldarES6io6joTfzUI+sq
	 xYpePyNbazkr8V9aN7N6Dq5QUZrwPHIxBVDD0oHx/RY9WE4DV1NCHF2q4RHkmcRFmE
	 QgTGDwUVsCBzg==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [RFC PATCH 0/5] efi/x86: Avoid corrupted config tables under Xen
Date: Sun,  2 Oct 2022 11:56:21 +0200
Message-Id: <20221002095626.484279-1-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=4408; i=ardb@kernel.org; h=from:subject; bh=7esb6YPYkrd+cv3sS3o+s4EfXDusBD+g0wEqShG+32A=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOWA6KKLbNxdyE3WYFUnkIoD4K2KMxMzVqnB/MmcB FkQw2BSJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzlgOgAKCRDDTyI5ktmPJJY3DA CAD6udbDfm1DhJmdyq4SARqiM82Wf/BNTqMuN4SnN/W8hyK1eNLXIbdtLOGZlIuoRe+ZXTt+DOWT21 T7JZjSQV3RCEayhduxEVc10dD2b4ILPXhBQYZ4Exe38ieW66inG3Ce4WB2w/o5xx6w6GthtAk9ndQu LT7hDZymIoqNDFWxqq6qVfdTSGAgLPF35zZAMYOXT1RJ8RI4o0O9p4SsFBtaLFhunDZSrmmCkGZ5Kj FXwUQET3WbaQLR72VXK3H4izixs9JuWMEg6gi/JppvQvIhTpIjtw6fO1lLJm4LSBzdAEulZePxi1ch sEy9MiI42BFPJ1yphzQGD9OqVQiYck5F5UM3IrTCJFDrvlb8BcWsrbXAipOCZt0SBJkEEF+BzKfqS3 i2WnhhgDt/8MMEURMV2s+F7BzgwFv1ShoUXY03AstIYkIHOt6OTKf1S6GcKMA0dd6GE2WSbaplWkRd tFf+MQOdFpOKBDKn4rHpP2vXo/DsbpuHgD5U+H7xmMOyk=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is an alternate approach to addressing the issue that Demi Marie is
attempting to fix in [0] (i.e., ESRT config table exposed to a x86 dom0
is corrupted because it resides in boot services memory as per the EFI
spec, where it gets corrupted by Xen). My main objection to that approach
is that it needs Xen-specific fixes in multiple different places, but we
still end up only fixing the ESRT case specifically.

So instead, I am proposing this series as a more generic way to handle
configuration tables that reside in boot services memory, and confining
the Xen specific logic to the Xen EFI glue code.

Given that EFI boot without a memory map is only permitted on x86 and
only when doing Xen boot, let's clear up some inconsistencies there
first so we can set the EFI_PARAVIRT flag on all architectures that do
pseudo-EFI boot straight into the core kernel (i.e., without going
through the stub). This moves a good chunk of EFI memory map
manipulation code into the x86 arch tree, where it arguably belongs as
no other architectures rely on it. This is implemented in patches 1 - 3.

Patch #4 updates the configuration table iteration logic so that only
ACPI and SMBIOS tables are exposed automatically when EFI_PARAVIRT is
set, and other config tables only if they reside in a memory region of a
EFI memory type that is guaranteed to be preserved. This effectively
hides the ESRT, but also the memory attributes table and the runtime
properties (and potentially others) when doing Xen dom0 boot unless they
have been moved out of EFI boot services memory.

The final patch relaxes the ESRT sanity check so that the ESRT is parsed
and exposed even if EFI_MEMMAP is not set, which is the case with Xen
dom0 on x86. If additional memory map checks are required in this code
path, the best way to achieve this is for Xen to expose a EFI memory map
on x86 just like it does on other architectures that support Xen (ARM
and arm64)

[0] https://lore.kernel.org/all/cover.1664298147.git.demi@invisiblethingslab.com/

Cc: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Peter Jones <pjones@redhat.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Ard Biesheuvel (5):
  efi: Move EFI fake memmap support into x86 arch tree
  efi: memmap: Move manipulation routines into x86 arch tree
  efi: xen: Set EFI_PARAVIRT for Xen dom0 boot on all architectures
  efi: Apply allowlist to EFI configuration tables when running under
    Xen
  efi: esrt: Omit region sanity check when no memory map is available

 arch/x86/Kconfig                                       |  20 ++
 arch/x86/include/asm/efi.h                             |  16 ++
 arch/x86/kernel/setup.c                                |   1 +
 arch/x86/platform/efi/Makefile                         |   4 +-
 arch/x86/platform/efi/efi.c                            |   8 +-
 {drivers/firmware => arch/x86/platform}/efi/fake_mem.c |  79 ++++++-
 arch/x86/platform/efi/memmap.c                         | 238 ++++++++++++++++++++
 arch/x86/platform/efi/quirks.c                         |   3 +
 drivers/firmware/efi/Kconfig                           |  22 --
 drivers/firmware/efi/Makefile                          |   4 -
 drivers/firmware/efi/efi.c                             |   7 +
 drivers/firmware/efi/esrt.c                            |  61 ++---
 drivers/firmware/efi/fake_mem.h                        |  10 -
 drivers/firmware/efi/fdtparams.c                       |   4 +
 drivers/firmware/efi/memmap.c                          | 224 +-----------------
 drivers/firmware/efi/x86_fake_mem.c                    |  75 ------
 drivers/xen/efi.c                                      |  69 ++++++
 include/linux/efi.h                                    |  18 +-
 18 files changed, 481 insertions(+), 382 deletions(-)
 rename {drivers/firmware => arch/x86/platform}/efi/fake_mem.c (58%)
 create mode 100644 arch/x86/platform/efi/memmap.c
 delete mode 100644 drivers/firmware/efi/fake_mem.h
 delete mode 100644 drivers/firmware/efi/x86_fake_mem.c

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:56:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:56:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414647.658983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviJ-000822-LX; Sun, 02 Oct 2022 09:56:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414647.658983; Sun, 02 Oct 2022 09:56:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviJ-00081v-HV; Sun, 02 Oct 2022 09:56:47 +0000
Received: by outflank-mailman (input) for mailman id 414647;
 Sun, 02 Oct 2022 09:56:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1oeviI-000817-Qd
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 09:56:46 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 84fc4187-4238-11ed-9375-c1cf23e5d27e;
 Sun, 02 Oct 2022 11:56:44 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2B42760C3A;
 Sun,  2 Oct 2022 09:56:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F739C43470;
 Sun,  2 Oct 2022 09:56:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84fc4187-4238-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664704602;
	bh=ZjDr14OxWTrew0/fwyFI+XUBboCoGDstHicLfif2Djw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=SYAbnexg2vVB1Ubx7iKWwvKipe8jqzlVNJ59mTk5OZatQLacV3nQAPuUtC3nOR8V4
	 lhVyVnKERtFuuR/QgAHyPQFv2prWZCGYPy/aW3ThLPGroBdPEV516wv0chfYbcL+9T
	 3uMAyrpHceKOBPN7vQnetNsCyf0xRXCQjghdCzcKIbtwAba3HDxFX4JoXxYSr4t6uS
	 PTzNhrkeiDP0/naziDCGJY/igr9pBlEqHrsg25jpVzlDszKtQBn3M4pTBzhc0DzQMb
	 tMBCz4HvJVm3wKhYCJjAVoFsK5v+lCrcvaEJFPGUuVIw2LBZ4KWk363H3t8rS4WKJt
	 CZ5cIx7kRubOg==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [RFC PATCH 2/5] efi: memmap: Move manipulation routines into x86 arch tree
Date: Sun,  2 Oct 2022 11:56:23 +0200
Message-Id: <20221002095626.484279-3-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221002095626.484279-1-ardb@kernel.org>
References: <20221002095626.484279-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=17368; i=ardb@kernel.org; h=from:subject; bh=ZjDr14OxWTrew0/fwyFI+XUBboCoGDstHicLfif2Djw=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOWA/g6dqX0FgOlAp0B3+vbe93/8K1X6EJXBcxSer Yrj6+geJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzlgPwAKCRDDTyI5ktmPJJnxC/ 0aACTxYmvHXRsjsJaqZYZRSmDe67wHbWOwyECaskr/J9cKGuY17WqaCXdDQoQI2Nsx1aZrjDp9rTXt ZFWlax5/HUP4ux2eN+zaqI+fW6SLYFHS4T29ql7PxKsEmd7QE31YwtvyXuV8JPj/awOGjNerkNFZu+ 4A0bq0Ya6LOJ14dO38rHyCl4qJlXkbprtM5D+yJEPYFf4oIRmpad2mVjpVfO6IA7FdYegXzG09APsI oKxZIX9HSKDmOMBdf4hlecFu+GXONuyFvNdxckwgoTesiyhs4jWLApd5iNCtf63di381AWtNEraHTJ h/TPAF692y5o/m5l8MFTXqXxFY1sYTmXkcFmil/3iE1tauQlQIBPjy0GWLMFw1BJb8R+1oUJgoE/oz ZT1JIElQYeGTlJEdKj+LGPv7sOsrz071FJRSgAIIEayMEv88BbZ3/TY2VsYtQibH1LAeYJ9me3vZU5 ZbI8zMyeOJ6UZzCn1KozadsjsJrWaTX1XaAL2zJifvhhA=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

The EFI memory map is a description of the memory layout as provided by
the firmware, and only x86 manipulates it in various different ways for
its own memory bookkeeping. So let's move the memmap routines that are
only used by x86 into the x86 arch tree.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/include/asm/efi.h     |  11 +
 arch/x86/platform/efi/Makefile |   3 +-
 arch/x86/platform/efi/memmap.c | 235 ++++++++++++++++++++
 drivers/firmware/efi/memmap.c  | 221 +-----------------
 include/linux/efi.h            |  10 +-
 5 files changed, 251 insertions(+), 229 deletions(-)

diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
index 68414d924332..1fb4686f3d12 100644
--- a/arch/x86/include/asm/efi.h
+++ b/arch/x86/include/asm/efi.h
@@ -415,6 +415,17 @@ static inline void efi_fake_memmap(void)
 }
 #endif
 
+extern int __init efi_memmap_alloc(unsigned int num_entries,
+				   struct efi_memory_map_data *data);
+extern void __efi_memmap_free(u64 phys, unsigned long size,
+			      unsigned long flags);
+
+extern int __init efi_memmap_install(struct efi_memory_map_data *data);
+extern int __init efi_memmap_split_count(efi_memory_desc_t *md,
+					 struct range *range);
+extern void __init efi_memmap_insert(struct efi_memory_map *old_memmap,
+				     void *buf, struct efi_mem_range *mem);
+
 #define arch_ima_efi_boot_mode	\
 	({ extern struct boot_params boot_params; boot_params.secure_boot; })
 
diff --git a/arch/x86/platform/efi/Makefile b/arch/x86/platform/efi/Makefile
index b481719b16cc..ed5502a5185d 100644
--- a/arch/x86/platform/efi/Makefile
+++ b/arch/x86/platform/efi/Makefile
@@ -2,6 +2,7 @@
 KASAN_SANITIZE := n
 GCOV_PROFILE := n
 
-obj-$(CONFIG_EFI) 		+= quirks.o efi.o efi_$(BITS).o efi_stub_$(BITS).o
+obj-$(CONFIG_EFI) 		+= memmap.o quirks.o efi.o efi_$(BITS).o \
+				   efi_stub_$(BITS).o
 obj-$(CONFIG_EFI_MIXED)		+= efi_thunk_$(BITS).o
 obj-$(CONFIG_EFI_FAKE_MEMMAP)	+= fake_mem.o
diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c
new file mode 100644
index 000000000000..44b886acf301
--- /dev/null
+++ b/arch/x86/platform/efi/memmap.c
@@ -0,0 +1,235 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Common EFI memory map functions.
+ */
+
+#define pr_fmt(fmt) "efi: " fmt
+
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/efi.h>
+#include <linux/io.h>
+#include <asm/early_ioremap.h>
+#include <linux/memblock.h>
+#include <linux/slab.h>
+
+static phys_addr_t __init __efi_memmap_alloc_early(unsigned long size)
+{
+	return memblock_phys_alloc(size, SMP_CACHE_BYTES);
+}
+
+static phys_addr_t __init __efi_memmap_alloc_late(unsigned long size)
+{
+	unsigned int order = get_order(size);
+	struct page *p = alloc_pages(GFP_KERNEL, order);
+
+	if (!p)
+		return 0;
+
+	return PFN_PHYS(page_to_pfn(p));
+}
+
+void __init __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
+{
+	if (flags & EFI_MEMMAP_MEMBLOCK) {
+		if (slab_is_available())
+			memblock_free_late(phys, size);
+		else
+			memblock_phys_free(phys, size);
+	} else if (flags & EFI_MEMMAP_SLAB) {
+		struct page *p = pfn_to_page(PHYS_PFN(phys));
+		unsigned int order = get_order(size);
+
+		free_pages((unsigned long) page_address(p), order);
+	}
+}
+
+/**
+ * efi_memmap_alloc - Allocate memory for the EFI memory map
+ * @num_entries: Number of entries in the allocated map.
+ * @data: efi memmap installation parameters
+ *
+ * Depending on whether mm_init() has already been invoked or not,
+ * either memblock or "normal" page allocation is used.
+ *
+ * Returns zero on success, a negative error code on failure.
+ */
+int __init efi_memmap_alloc(unsigned int num_entries,
+		struct efi_memory_map_data *data)
+{
+	/* Expect allocation parameters are zero initialized */
+	WARN_ON(data->phys_map || data->size);
+
+	data->size = num_entries * efi.memmap.desc_size;
+	data->desc_version = efi.memmap.desc_version;
+	data->desc_size = efi.memmap.desc_size;
+	data->flags &= ~(EFI_MEMMAP_SLAB | EFI_MEMMAP_MEMBLOCK);
+	data->flags |= efi.memmap.flags & EFI_MEMMAP_LATE;
+
+	if (slab_is_available()) {
+		data->flags |= EFI_MEMMAP_SLAB;
+		data->phys_map = __efi_memmap_alloc_late(data->size);
+	} else {
+		data->flags |= EFI_MEMMAP_MEMBLOCK;
+		data->phys_map = __efi_memmap_alloc_early(data->size);
+	}
+
+	if (!data->phys_map)
+		return -ENOMEM;
+	return 0;
+}
+
+/**
+ * efi_memmap_install - Install a new EFI memory map in efi.memmap
+ * @ctx: map allocation parameters (address, size, flags)
+ *
+ * Unlike efi_memmap_init_*(), this function does not allow the caller
+ * to switch from early to late mappings. It simply uses the existing
+ * mapping function and installs the new memmap.
+ *
+ * Returns zero on success, a negative error code on failure.
+ */
+int __init efi_memmap_install(struct efi_memory_map_data *data)
+{
+	efi_memmap_unmap();
+
+	return __efi_memmap_init(data);
+}
+
+/**
+ * efi_memmap_split_count - Count number of additional EFI memmap entries
+ * @md: EFI memory descriptor to split
+ * @range: Address range (start, end) to split around
+ *
+ * Returns the number of additional EFI memmap entries required to
+ * accommodate @range.
+ */
+int __init efi_memmap_split_count(efi_memory_desc_t *md, struct range *range)
+{
+	u64 m_start, m_end;
+	u64 start, end;
+	int count = 0;
+
+	start = md->phys_addr;
+	end = start + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+
+	/* modifying range */
+	m_start = range->start;
+	m_end = range->end;
+
+	if (m_start <= start) {
+		/* split into 2 parts */
+		if (start < m_end && m_end < end)
+			count++;
+	}
+
+	if (start < m_start && m_start < end) {
+		/* split into 3 parts */
+		if (m_end < end)
+			count += 2;
+		/* split into 2 parts */
+		if (end <= m_end)
+			count++;
+	}
+
+	return count;
+}
+
+/**
+ * efi_memmap_insert - Insert a memory region in an EFI memmap
+ * @old_memmap: The existing EFI memory map structure
+ * @buf: Address of buffer to store new map
+ * @mem: Memory map entry to insert
+ *
+ * It is suggested that you call efi_memmap_split_count() first
+ * to see how large @buf needs to be.
+ */
+void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf,
+			      struct efi_mem_range *mem)
+{
+	u64 m_start, m_end, m_attr;
+	efi_memory_desc_t *md;
+	u64 start, end;
+	void *old, *new;
+
+	/* modifying range */
+	m_start = mem->range.start;
+	m_end = mem->range.end;
+	m_attr = mem->attribute;
+
+	/*
+	 * The EFI memory map deals with regions in EFI_PAGE_SIZE
+	 * units. Ensure that the region described by 'mem' is aligned
+	 * correctly.
+	 */
+	if (!IS_ALIGNED(m_start, EFI_PAGE_SIZE) ||
+	    !IS_ALIGNED(m_end + 1, EFI_PAGE_SIZE)) {
+		WARN_ON(1);
+		return;
+	}
+
+	for (old = old_memmap->map, new = buf;
+	     old < old_memmap->map_end;
+	     old += old_memmap->desc_size, new += old_memmap->desc_size) {
+
+		/* copy original EFI memory descriptor */
+		memcpy(new, old, old_memmap->desc_size);
+		md = new;
+		start = md->phys_addr;
+		end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+
+		if (m_start <= start && end <= m_end)
+			md->attribute |= m_attr;
+
+		if (m_start <= start &&
+		    (start < m_end && m_end < end)) {
+			/* first part */
+			md->attribute |= m_attr;
+			md->num_pages = (m_end - md->phys_addr + 1) >>
+				EFI_PAGE_SHIFT;
+			/* latter part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->phys_addr = m_end + 1;
+			md->num_pages = (end - md->phys_addr + 1) >>
+				EFI_PAGE_SHIFT;
+		}
+
+		if ((start < m_start && m_start < end) && m_end < end) {
+			/* first part */
+			md->num_pages = (m_start - md->phys_addr) >>
+				EFI_PAGE_SHIFT;
+			/* middle part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->attribute |= m_attr;
+			md->phys_addr = m_start;
+			md->num_pages = (m_end - m_start + 1) >>
+				EFI_PAGE_SHIFT;
+			/* last part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->phys_addr = m_end + 1;
+			md->num_pages = (end - m_end) >>
+				EFI_PAGE_SHIFT;
+		}
+
+		if ((start < m_start && m_start < end) &&
+		    (end <= m_end)) {
+			/* first part */
+			md->num_pages = (m_start - md->phys_addr) >>
+				EFI_PAGE_SHIFT;
+			/* latter part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->phys_addr = m_start;
+			md->num_pages = (end - md->phys_addr + 1) >>
+				EFI_PAGE_SHIFT;
+			md->attribute |= m_attr;
+		}
+	}
+}
diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c
index 6ec7970dbd40..3501d3814f22 100644
--- a/drivers/firmware/efi/memmap.c
+++ b/drivers/firmware/efi/memmap.c
@@ -13,35 +13,8 @@
 #include <linux/memblock.h>
 #include <linux/slab.h>
 
-static phys_addr_t __init __efi_memmap_alloc_early(unsigned long size)
+void __weak __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
 {
-	return memblock_phys_alloc(size, SMP_CACHE_BYTES);
-}
-
-static phys_addr_t __init __efi_memmap_alloc_late(unsigned long size)
-{
-	unsigned int order = get_order(size);
-	struct page *p = alloc_pages(GFP_KERNEL, order);
-
-	if (!p)
-		return 0;
-
-	return PFN_PHYS(page_to_pfn(p));
-}
-
-void __init __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
-{
-	if (flags & EFI_MEMMAP_MEMBLOCK) {
-		if (slab_is_available())
-			memblock_free_late(phys, size);
-		else
-			memblock_phys_free(phys, size);
-	} else if (flags & EFI_MEMMAP_SLAB) {
-		struct page *p = pfn_to_page(PHYS_PFN(phys));
-		unsigned int order = get_order(size);
-
-		free_pages((unsigned long) page_address(p), order);
-	}
 }
 
 static void __init efi_memmap_free(void)
@@ -51,41 +24,6 @@ static void __init efi_memmap_free(void)
 			efi.memmap.flags);
 }
 
-/**
- * efi_memmap_alloc - Allocate memory for the EFI memory map
- * @num_entries: Number of entries in the allocated map.
- * @data: efi memmap installation parameters
- *
- * Depending on whether mm_init() has already been invoked or not,
- * either memblock or "normal" page allocation is used.
- *
- * Returns zero on success, a negative error code on failure.
- */
-int __init efi_memmap_alloc(unsigned int num_entries,
-		struct efi_memory_map_data *data)
-{
-	/* Expect allocation parameters are zero initialized */
-	WARN_ON(data->phys_map || data->size);
-
-	data->size = num_entries * efi.memmap.desc_size;
-	data->desc_version = efi.memmap.desc_version;
-	data->desc_size = efi.memmap.desc_size;
-	data->flags &= ~(EFI_MEMMAP_SLAB | EFI_MEMMAP_MEMBLOCK);
-	data->flags |= efi.memmap.flags & EFI_MEMMAP_LATE;
-
-	if (slab_is_available()) {
-		data->flags |= EFI_MEMMAP_SLAB;
-		data->phys_map = __efi_memmap_alloc_late(data->size);
-	} else {
-		data->flags |= EFI_MEMMAP_MEMBLOCK;
-		data->phys_map = __efi_memmap_alloc_early(data->size);
-	}
-
-	if (!data->phys_map)
-		return -ENOMEM;
-	return 0;
-}
-
 /**
  * __efi_memmap_init - Common code for mapping the EFI memory map
  * @data: EFI memory map data
@@ -101,7 +39,7 @@ int __init efi_memmap_alloc(unsigned int num_entries,
  *
  * Returns zero on success, a negative error code on failure.
  */
-static int __init __efi_memmap_init(struct efi_memory_map_data *data)
+int __init __efi_memmap_init(struct efi_memory_map_data *data)
 {
 	struct efi_memory_map map;
 	phys_addr_t phys_map;
@@ -220,158 +158,3 @@ int __init efi_memmap_init_late(phys_addr_t addr, unsigned long size)
 
 	return __efi_memmap_init(&data);
 }
-
-/**
- * efi_memmap_install - Install a new EFI memory map in efi.memmap
- * @ctx: map allocation parameters (address, size, flags)
- *
- * Unlike efi_memmap_init_*(), this function does not allow the caller
- * to switch from early to late mappings. It simply uses the existing
- * mapping function and installs the new memmap.
- *
- * Returns zero on success, a negative error code on failure.
- */
-int __init efi_memmap_install(struct efi_memory_map_data *data)
-{
-	efi_memmap_unmap();
-
-	return __efi_memmap_init(data);
-}
-
-/**
- * efi_memmap_split_count - Count number of additional EFI memmap entries
- * @md: EFI memory descriptor to split
- * @range: Address range (start, end) to split around
- *
- * Returns the number of additional EFI memmap entries required to
- * accommodate @range.
- */
-int __init efi_memmap_split_count(efi_memory_desc_t *md, struct range *range)
-{
-	u64 m_start, m_end;
-	u64 start, end;
-	int count = 0;
-
-	start = md->phys_addr;
-	end = start + (md->num_pages << EFI_PAGE_SHIFT) - 1;
-
-	/* modifying range */
-	m_start = range->start;
-	m_end = range->end;
-
-	if (m_start <= start) {
-		/* split into 2 parts */
-		if (start < m_end && m_end < end)
-			count++;
-	}
-
-	if (start < m_start && m_start < end) {
-		/* split into 3 parts */
-		if (m_end < end)
-			count += 2;
-		/* split into 2 parts */
-		if (end <= m_end)
-			count++;
-	}
-
-	return count;
-}
-
-/**
- * efi_memmap_insert - Insert a memory region in an EFI memmap
- * @old_memmap: The existing EFI memory map structure
- * @buf: Address of buffer to store new map
- * @mem: Memory map entry to insert
- *
- * It is suggested that you call efi_memmap_split_count() first
- * to see how large @buf needs to be.
- */
-void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf,
-			      struct efi_mem_range *mem)
-{
-	u64 m_start, m_end, m_attr;
-	efi_memory_desc_t *md;
-	u64 start, end;
-	void *old, *new;
-
-	/* modifying range */
-	m_start = mem->range.start;
-	m_end = mem->range.end;
-	m_attr = mem->attribute;
-
-	/*
-	 * The EFI memory map deals with regions in EFI_PAGE_SIZE
-	 * units. Ensure that the region described by 'mem' is aligned
-	 * correctly.
-	 */
-	if (!IS_ALIGNED(m_start, EFI_PAGE_SIZE) ||
-	    !IS_ALIGNED(m_end + 1, EFI_PAGE_SIZE)) {
-		WARN_ON(1);
-		return;
-	}
-
-	for (old = old_memmap->map, new = buf;
-	     old < old_memmap->map_end;
-	     old += old_memmap->desc_size, new += old_memmap->desc_size) {
-
-		/* copy original EFI memory descriptor */
-		memcpy(new, old, old_memmap->desc_size);
-		md = new;
-		start = md->phys_addr;
-		end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
-
-		if (m_start <= start && end <= m_end)
-			md->attribute |= m_attr;
-
-		if (m_start <= start &&
-		    (start < m_end && m_end < end)) {
-			/* first part */
-			md->attribute |= m_attr;
-			md->num_pages = (m_end - md->phys_addr + 1) >>
-				EFI_PAGE_SHIFT;
-			/* latter part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->phys_addr = m_end + 1;
-			md->num_pages = (end - md->phys_addr + 1) >>
-				EFI_PAGE_SHIFT;
-		}
-
-		if ((start < m_start && m_start < end) && m_end < end) {
-			/* first part */
-			md->num_pages = (m_start - md->phys_addr) >>
-				EFI_PAGE_SHIFT;
-			/* middle part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->attribute |= m_attr;
-			md->phys_addr = m_start;
-			md->num_pages = (m_end - m_start + 1) >>
-				EFI_PAGE_SHIFT;
-			/* last part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->phys_addr = m_end + 1;
-			md->num_pages = (end - m_end) >>
-				EFI_PAGE_SHIFT;
-		}
-
-		if ((start < m_start && m_start < end) &&
-		    (end <= m_end)) {
-			/* first part */
-			md->num_pages = (m_start - md->phys_addr) >>
-				EFI_PAGE_SHIFT;
-			/* latter part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->phys_addr = m_start;
-			md->num_pages = (end - md->phys_addr + 1) >>
-				EFI_PAGE_SHIFT;
-			md->attribute |= m_attr;
-		}
-	}
-}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index a6dbf354d2c3..256e70e42114 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -707,18 +707,10 @@ static inline efi_status_t efi_query_variable_store(u32 attributes,
 #endif
 extern void __iomem *efi_lookup_mapped_addr(u64 phys_addr);
 
-extern int __init efi_memmap_alloc(unsigned int num_entries,
-				   struct efi_memory_map_data *data);
-extern void __efi_memmap_free(u64 phys, unsigned long size,
-			      unsigned long flags);
+extern int __init __efi_memmap_init(struct efi_memory_map_data *data);
 extern int __init efi_memmap_init_early(struct efi_memory_map_data *data);
 extern int __init efi_memmap_init_late(phys_addr_t addr, unsigned long size);
 extern void __init efi_memmap_unmap(void);
-extern int __init efi_memmap_install(struct efi_memory_map_data *data);
-extern int __init efi_memmap_split_count(efi_memory_desc_t *md,
-					 struct range *range);
-extern void __init efi_memmap_insert(struct efi_memory_map *old_memmap,
-				     void *buf, struct efi_mem_range *mem);
 
 #ifdef CONFIG_EFI_ESRT
 extern void __init efi_esrt_init(void);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:56:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:56:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414648.658994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviM-0008Kt-3d; Sun, 02 Oct 2022 09:56:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414648.658994; Sun, 02 Oct 2022 09:56:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviM-0008Ki-0B; Sun, 02 Oct 2022 09:56:50 +0000
Received: by outflank-mailman (input) for mailman id 414648;
 Sun, 02 Oct 2022 09:56:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1oeviK-0007U5-MX
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 09:56:48 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87041ff0-4238-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 11:56:47 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 9E33F60EA4;
 Sun,  2 Oct 2022 09:56:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15F90C433D6;
 Sun,  2 Oct 2022 09:56:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87041ff0-4238-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664704606;
	bh=naWVhxVJzgFHTYyzbP8aferDZudNO8L5WZJcvq28kz8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=HJMy/vz6C1WPkgKcpbpoO/EQRrz6yAjgPpzrVFvMZ+walD/yM0Y0/LdUToEzYOP3e
	 wUcz8Fmrta2nkGJSkkaAMVqgSnRvfmZmPgOh64OvJXPY22FVdCh2GBjdhDG4v1U+V+
	 TaUklRaC8k0+i0H9PXGPupfBhktKg1OYLU/ocnnKIjMY9R8buaQcGOij3ETjE9/2Qt
	 oY5U6tIueXURJFbXveR38cWmsqyll1PJbi+gTNKBGbJahbxp1vFmCekLGFIeShpnXs
	 8e6DpsKFM2Oa/iyyEWtIilU9DcihAXqFelN6xor9DoI0MdNoHBhhhwi5wcZdRq3AZU
	 1VazOsR6kr94g==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [RFC PATCH 3/5] efi: xen: Set EFI_PARAVIRT for Xen dom0 boot on all architectures
Date: Sun,  2 Oct 2022 11:56:24 +0200
Message-Id: <20221002095626.484279-4-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221002095626.484279-1-ardb@kernel.org>
References: <20221002095626.484279-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3190; i=ardb@kernel.org; h=from:subject; bh=naWVhxVJzgFHTYyzbP8aferDZudNO8L5WZJcvq28kz8=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOWBBUImNh+oNISz7kaell7P1ADDK/YsLUV10IJbU Cm3Ms7iJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzlgQQAKCRDDTyI5ktmPJL+CDA CI6goexpgFxPze+H/P1pGk+2TCSeapYidebHraqvYuivMVNgqTUEXJD0MTuefrzj2RYWLr8Z8Nl5F/ NW37j0Kc7I7UDApHt22+UHn2mgOpMu69tN7r+1EKj5j1AH7GTJ8RfzfLxMrKqPkr9JP4TAlfMSq6wr 2H4u2aITOj9clf0ga9hYyBm3uEKdK9sPATjTKKCKtknjUMPT5fp6mmrNw1qR2ZnWh/sAUexJ/eRIeH QlUEGEHPOPeWmBtJQC+QkGKRNKPT5186B/uDeeHtlgPnKDvLlKZF99n8nyHceFjUn6T8s/S7CFJUQ3 vQz7ohfix1KUdhAZ+b7u+2BJ11t4BiTfRE84Mrq9+xxPvMVwTBfEdkrc1qGDRIaHbQCkVSZOCKhYPo 5UvNVhJFzkfY/qc+sCyiEjw3IIkG2fYKSZyzeuDaM0lR1ukIud+LEqEodpxUEcEs+cEQcW2XGgl9yB nqsQmxUsIhyvMWKdmMgVeTi9+JDpm2Qczoo9bNk+ZQh4Y=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

Currently, the EFI_PARAVIRT flag is only used by x86, even though other
architectures also support pseudo-EFI boot, where the core kernel is
invoked directly and provided with a set of data tables that resemble
the ones constructed by the EFI stub, which never actually runs in that
case.

Let's fix this inconsistency, and always set this flag when booting dom0
via the EFI boot path. Note that Xen on x86 does not provide the EFI
memory map in this case, whereas other architectures do, so move the
associated EFI_PARAVIRT check into the x86 platform code.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/platform/efi/efi.c      | 8 +++++---
 arch/x86/platform/efi/memmap.c   | 3 +++
 drivers/firmware/efi/fdtparams.c | 4 ++++
 drivers/firmware/efi/memmap.c    | 3 ---
 4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 6e598bd78eef..6a6f2a585a3d 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -214,9 +214,11 @@ int __init efi_memblock_x86_reserve_range(void)
 	data.desc_size		= e->efi_memdesc_size;
 	data.desc_version	= e->efi_memdesc_version;
 
-	rv = efi_memmap_init_early(&data);
-	if (rv)
-		return rv;
+	if (!efi_enabled(EFI_PARAVIRT)) {
+		rv = efi_memmap_init_early(&data);
+		if (rv)
+			return rv;
+	}
 
 	if (add_efi_memmap || do_efi_soft_reserve())
 		do_add_efi_memmap();
diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c
index 44b886acf301..18e14ec16720 100644
--- a/arch/x86/platform/efi/memmap.c
+++ b/arch/x86/platform/efi/memmap.c
@@ -93,6 +93,9 @@ int __init efi_memmap_install(struct efi_memory_map_data *data)
 {
 	efi_memmap_unmap();
 
+	if (efi_enabled(EFI_PARAVIRT))
+		return 0;
+
 	return __efi_memmap_init(data);
 }
 
diff --git a/drivers/firmware/efi/fdtparams.c b/drivers/firmware/efi/fdtparams.c
index e901f8564ca0..0ec83ba58097 100644
--- a/drivers/firmware/efi/fdtparams.c
+++ b/drivers/firmware/efi/fdtparams.c
@@ -30,11 +30,13 @@ static __initconst const char name[][22] = {
 
 static __initconst const struct {
 	const char	path[17];
+	u8		paravirt;
 	const char	params[PARAMCOUNT][26];
 } dt_params[] = {
 	{
 #ifdef CONFIG_XEN    //  <-------17------>
 		.path = "/hypervisor/uefi",
+		.paravirt = 1,
 		.params = {
 			[SYSTAB] = "xen,uefi-system-table",
 			[MMBASE] = "xen,uefi-mmap-start",
@@ -121,6 +123,8 @@ u64 __init efi_get_fdt_params(struct efi_memory_map_data *mm)
 			pr_err("Can't find property '%s' in DT!\n", pname);
 			return 0;
 		}
+		if (dt_params[i].paravirt)
+			set_bit(EFI_PARAVIRT, &efi.flags);
 		return systab;
 	}
 notfound:
diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c
index 3501d3814f22..9508082af907 100644
--- a/drivers/firmware/efi/memmap.c
+++ b/drivers/firmware/efi/memmap.c
@@ -44,9 +44,6 @@ int __init __efi_memmap_init(struct efi_memory_map_data *data)
 	struct efi_memory_map map;
 	phys_addr_t phys_map;
 
-	if (efi_enabled(EFI_PARAVIRT))
-		return 0;
-
 	phys_map = data->phys_map;
 
 	if (data->flags & EFI_MEMMAP_LATE)
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:56:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:56:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414649.659005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviQ-0000G4-Du; Sun, 02 Oct 2022 09:56:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414649.659005; Sun, 02 Oct 2022 09:56:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviQ-0000Fp-AS; Sun, 02 Oct 2022 09:56:54 +0000
Received: by outflank-mailman (input) for mailman id 414649;
 Sun, 02 Oct 2022 09:56:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1oeviO-0007U5-6V
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 09:56:52 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 890d9203-4238-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 11:56:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 101F460EA5;
 Sun,  2 Oct 2022 09:56:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 832B8C4347C;
 Sun,  2 Oct 2022 09:56:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 890d9203-4238-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664704609;
	bh=kklnL55pKWR1vQ/19hTjFP18KyqfhrdVX1+/k9SG5KE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=u30qGzyh+tD3uTA+5MwooaeSIG3R7K46GLISQHthQk0IPFp6wFEREKYfV4cAwZH4l
	 29tBU8c+/EzhtdSavIkJUuL0yjTYoXoUcSIu11EcnRwAN2YvaCI+Q9KN9yPubwXNVc
	 hH/2WplQPMDx8Kv6+oWcSd8JH3LbkW0DGUiiiicysD15n2DWcO4YnBcL9oGqGqot3j
	 5SkWHBdHp1RWCWp+6O5NeWcP4KAIJiTffms0EEkZ/LLK9ZF+4SeWW0GpXzszzSMt4E
	 n95nzqAy4sZimgR0qgb/cOd/54zjc2W5Gx209+l6ID9r+QsAhyawmZNFhDrHUqL/PC
	 7UA5fBTSYWyJg==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [RFC PATCH 4/5] efi: Apply allowlist to EFI configuration tables when running under Xen
Date: Sun,  2 Oct 2022 11:56:25 +0200
Message-Id: <20221002095626.484279-5-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221002095626.484279-1-ardb@kernel.org>
References: <20221002095626.484279-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=4992; i=ardb@kernel.org; h=from:subject; bh=kklnL55pKWR1vQ/19hTjFP18KyqfhrdVX1+/k9SG5KE=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOWBDcjLC/XtL6TWD7SlqFc53BFZWSGH0tWLY5HiL Of+IqTeJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzlgQwAKCRDDTyI5ktmPJBG+C/ 9n9inwyfpMFqxsvtl0IevAjclopZMTaAwU+rafEbqvQ2K9fxsY6k4Tuzs9y0I6HVaTCKQ+/e83E8Ut oQkrveg0sb6Etbd7qZ98homL8bG2F3tJcTXv/BXpl2FIhx2E7vgjTbYE5ixklJl/55Ix+0YyrwzOmj lms21xFGzlJqVG6QHauTZwp/lUHBFtsm/xApqCGl1U67X6M2WQayQ32iAGd2FKTcUjNpPmJ7dgUgV8 nQhD7d3tfyIUbyVlaXXdhwDbTqcFQFBC+8/IiO3y+PHfRtNlO2ow6r5l0YanlRBGTGSpDIpJNRcxuH +SXQs51/NIH8jSMDlx22/tQfTnUDh70rVwpuE0ymR4Hwydyh6Jt44AdNAK/ydXbAiPx22IwrigbRQG EDzCdjUdg5RvyYLAiSuqmNyxdAtslbqqiFHmEUNQXvFvtsDsUu2r+6Jn96kUMuCcYe94+YOgRUqE5c 8VancdiCM4aEwcFqGq9gsv/K8byblK2VJNzOvn19NodFQ=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

As it turns out, Xen does not guarantee that EFI bootservices data
regions in memory are preserved, which means that EFI configuration
tables pointing into such memory regions may be corrupted before the
dom0 OS has had a chance to inspect them.

Demi Marie reports that this is causing problems for Qubes OS when it
attempts to perform system firmware updates, which requires that the
contents of the ESRT configuration table are valid when the fwupd user
space program runs.

However, other configuration tables such as the memory attributes
table or the runtime properties table are equally affected, and so we
need a comprehensive workaround that works for any table type.

So let's first disregard all EFI configuration tables except the ones
that are known (or can be expected) to reside in memory regions of a
type that Xen preserves, i.e., ACPI tables (which are passed in
EfiAcpiReclaimMemory regions) and SMBIOS tables (which are usually
passed in EfiRuntimeServicesData regions, even though the UEFI spec only
mentions this as a recommendation). Then, cross reference unknown tables
against either the EFI memory map (if available) or do a Xen hypercall
to determine the memory type, and allow the config table if the type is
one that is guaranteed to be preserved.

Future patches can augment the logic in this routine to allow other
table types based on the size of the allocation, or based on a table
specific header size field.

Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 drivers/firmware/efi/efi.c |  7 ++
 drivers/xen/efi.c          | 69 ++++++++++++++++++++
 include/linux/efi.h        |  2 +
 3 files changed, 78 insertions(+)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 11857af72859..e8c0747011d7 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -556,6 +556,13 @@ static __init int match_config_table(const efi_guid_t *guid,
 
 	for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
 		if (!efi_guidcmp(*guid, table_types[i].guid)) {
+			if (IS_ENABLED(CONFIG_XEN_EFI) &&
+			    !xen_efi_config_table_is_usable(guid, table)) {
+				if (table_types[i].name[0])
+					pr_cont("(%s=0x%lx) ",
+						table_types[i].name, table);
+				return 1;
+			}
 			*(table_types[i].ptr) = table;
 			if (table_types[i].name[0])
 				pr_cont("%s=0x%lx ",
diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
index d1ff2186ebb4..3f1f365b37d0 100644
--- a/drivers/xen/efi.c
+++ b/drivers/xen/efi.c
@@ -292,3 +292,72 @@ void __init xen_efi_runtime_setup(void)
 	efi.get_next_high_mono_count	= xen_efi_get_next_high_mono_count;
 	efi.reset_system		= xen_efi_reset_system;
 }
+
+static const efi_guid_t cfg_table_allow_list[] __initconst = {
+	ACPI_20_TABLE_GUID,
+	ACPI_TABLE_GUID,
+	SMBIOS_TABLE_GUID,
+	SMBIOS3_TABLE_GUID,
+};
+
+bool __init xen_efi_config_table_is_usable(const efi_guid_t *guid,
+					   unsigned long table)
+{
+	u32 memtype;
+	int i, rc;
+
+	if (!efi_enabled(EFI_PARAVIRT))
+		return true;
+
+	for (i = 0; i < ARRAY_SIZE(cfg_table_allow_list); i++) {
+		if (!efi_guidcmp(*guid, cfg_table_allow_list[i]))
+			return true;
+	}
+
+	if (efi_enabled(EFI_MEMMAP)) {
+		/* check against the EFI memory map */
+		efi_memory_desc_t md;
+
+		rc = efi_mem_desc_lookup(table, &md);
+		if (rc) {
+			pr_warn("Failed to lookup header 0x%lx in EFI memory map (%d)\n",
+				table, rc);
+			return false;
+		}
+		memtype = md.type;
+	} else {
+		/* check against the Xen hypercall */
+		struct xen_platform_op op = {
+			.cmd = XENPF_firmware_info,
+			.u.firmware_info = {
+				.type = XEN_FW_EFI_INFO,
+				.index = XEN_FW_EFI_MEM_INFO,
+				.u.efi_info.mem.addr = table,
+				.u.efi_info.mem.size = U64_MAX - table,
+			}
+		};
+		union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info;
+
+		rc = HYPERVISOR_platform_op(&op);
+		if (rc) {
+			pr_warn("Failed to lookup header 0x%lx in Xen memory map (%d)\n",
+				table, rc);
+			return false;
+		}
+		memtype = info->mem.type;
+	}
+
+	switch (memtype) {
+	case EFI_RUNTIME_SERVICES_CODE:
+	case EFI_RUNTIME_SERVICES_DATA:
+	case EFI_ACPI_RECLAIM_MEMORY:
+	case EFI_RESERVED_TYPE:
+		return true;
+	case EFI_BOOT_SERVICES_DATA:
+		break;
+	default:
+		return false;
+	}
+
+	return false;
+}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 256e70e42114..6edc627798b6 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -1351,4 +1351,6 @@ struct linux_efi_initrd {
 /* Header of a populated EFI secret area */
 #define EFI_SECRET_TABLE_HEADER_GUID	EFI_GUID(0x1e74f542, 0x71dd, 0x4d66,  0x96, 0x3e, 0xef, 0x42, 0x87, 0xff, 0x17, 0x3b)
 
+bool xen_efi_config_table_is_usable(const efi_guid_t *, unsigned long table);
+
 #endif /* _LINUX_EFI_H */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 09:56:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 09:56:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414650.659016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviS-0000bE-Ms; Sun, 02 Oct 2022 09:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414650.659016; Sun, 02 Oct 2022 09:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oeviS-0000b6-Jl; Sun, 02 Oct 2022 09:56:56 +0000
Received: by outflank-mailman (input) for mailman id 414650;
 Sun, 02 Oct 2022 09:56:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1oeviR-000817-Hx
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 09:56:55 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b236ded-4238-11ed-9375-c1cf23e5d27e;
 Sun, 02 Oct 2022 11:56:54 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8949D60EA2;
 Sun,  2 Oct 2022 09:56:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 030F7C433D6;
 Sun,  2 Oct 2022 09:56:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b236ded-4238-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664704613;
	bh=i9J/bhcOyc3uNnBq9NxPgkx0ZJaejS+t55ZIN9kwhto=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=lZZQATYJk3ivDIqSahLAWOXxDG540XSQg4SOZtKoDcInYHh5WAIvtQ708cDyde62y
	 qFcJoIpjQKJhjdEr2eKLrqneN9dxTRKeluZC1+osIcRdGYu6bpOar8CPXS63b7QZ0I
	 +t3NvNXP6iJNDe9PTzQMhuatCVpMQNvX0WmZcZiifFHPenOOUfGYFr5Pm4vaJE5xaX
	 tiqgBusQE4dcXX+IK74AtS1ovjH6syVgbox8r0Aoh44N36UvpuyCEsT0/GwjDuaTsg
	 hoAxaFqgIJOVnDfMXTxZWzPMVwxzpsrzfQg5J17/FA+QnqhkMIYJmMJlEuemLiYTU/
	 sTEBGyK60tsYg==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [RFC PATCH 5/5] efi: esrt: Omit region sanity check when no memory map is available
Date: Sun,  2 Oct 2022 11:56:26 +0200
Message-Id: <20221002095626.484279-6-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221002095626.484279-1-ardb@kernel.org>
References: <20221002095626.484279-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3849; i=ardb@kernel.org; h=from:subject; bh=i9J/bhcOyc3uNnBq9NxPgkx0ZJaejS+t55ZIN9kwhto=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOWBG4cz437cHlvB5hCAVDNcjf0OGuWo2clK4E5EB xJGhzOeJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzlgRgAKCRDDTyI5ktmPJGICDA CiILORMzCoGuRyx58JurLNRhBnK5oQH+9xzw8gRRd+Vz3g6c3EKvPNk1k5x/NyZiqptY5b/6kkST0z L3hL8qwjhwFvSm+hK8lb11IHTiOu5W3BLWF4tN3i1+n/y4mJo0NtJUAFwMt1dVCJH31hZFqNAJ8NQ/ svEJL86U6S+8AQbXU/v1TMcjV7C4Bf3uPyjg7L6HaCBwiREnJ8QlZ06QYWieJ4VZQUnS2l7eV6Z30f dlpPBhWgtaarwosLJ8Hd/FOw0nudZB3/c0Pma8xBvF58WeRddf/URLRL/KZ3OEwWcwddlmZdz4jHZa 6SI8cTLmCQpjeEvYZ8FJVyTQoI6El+Pt94uuWwnQIcpQjqeQD4/20RKdAxmOseZfoWRajOLTBeJgdH ppCdmUvll+/kB0Kl2bY+2FWH8d2E1jcLHeqXrFGUFZeP1eNzkJsiGE7f3iF2vXdIq5T65oGQGMTU+Q YCpsZXqv93o6Ztb2Cid6MB1cAtrtmds7CWvHCe2Je4z1k=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

In order to permit the ESRT to be used when doing pseudo-EFI boot
without a EFI memory map, e.g., when booting inside a Xen dom0 on x86,
make the sanity checks optional based on whether the memory map is
available.

If additional validation is needed, it is up to the Xen EFI glue code to
implement this in its xen_efi_config_table_is_valid() helper, or provide
a EFI memory map like it does on other architectures.

Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/platform/efi/quirks.c |  3 +
 drivers/firmware/efi/esrt.c    | 61 +++++++++++---------
 2 files changed, 37 insertions(+), 27 deletions(-)

diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c
index b0b848d6933a..9307be2f4afa 100644
--- a/arch/x86/platform/efi/quirks.c
+++ b/arch/x86/platform/efi/quirks.c
@@ -250,6 +250,9 @@ void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size)
 	int num_entries;
 	void *new;
 
+	if (!efi_enabled(EFI_MEMMAP))
+		return;
+
 	if (efi_mem_desc_lookup(addr, &md) ||
 	    md.type != EFI_BOOT_SERVICES_DATA) {
 		pr_err("Failed to lookup EFI memory descriptor for %pa\n", &addr);
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 2a2f52b017e7..adb31fba45ae 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -243,40 +243,45 @@ void __init efi_esrt_init(void)
 	void *va;
 	struct efi_system_resource_table tmpesrt;
 	size_t size, max, entry_size, entries_size;
-	efi_memory_desc_t md;
-	int rc;
+	bool reserve_esrt;
 	phys_addr_t end;
 
-	if (!efi_enabled(EFI_MEMMAP))
-		return;
-
 	pr_debug("esrt-init: loading.\n");
 	if (!esrt_table_exists())
 		return;
 
-	rc = efi_mem_desc_lookup(efi.esrt, &md);
-	if (rc < 0 ||
-	    (!(md.attribute & EFI_MEMORY_RUNTIME) &&
-	     md.type != EFI_BOOT_SERVICES_DATA &&
-	     md.type != EFI_RUNTIME_SERVICES_DATA)) {
-		pr_warn("ESRT header is not in the memory map.\n");
-		return;
-	}
+	size = sizeof(*esrt);
+	if (efi_enabled(EFI_MEMMAP)) {
+		efi_memory_desc_t md;
+		int rc;
+
+		rc = efi_mem_desc_lookup(efi.esrt, &md);
+		if (rc < 0 ||
+		    (!(md.attribute & EFI_MEMORY_RUNTIME) &&
+		     md.type != EFI_BOOT_SERVICES_DATA &&
+		     md.type != EFI_RUNTIME_SERVICES_DATA)) {
+			pr_warn("ESRT header is not in the memory map.\n");
+			return;
+		}
 
-	max = efi_mem_desc_end(&md);
-	if (max < efi.esrt) {
-		pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n",
-		       (void *)efi.esrt, (void *)max);
-		return;
-	}
+		reserve_esrt = (md.type == EFI_BOOT_SERVICES_DATA);
+		max = efi_mem_desc_end(&md);
+		if (max < efi.esrt) {
+			pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n",
+			       (void *)efi.esrt, (void *)max);
+			return;
+		}
 
-	size = sizeof(*esrt);
-	max -= efi.esrt;
+		max -= efi.esrt;
 
-	if (max < size) {
-		pr_err("ESRT header doesn't fit on single memory map entry. (size: %zu max: %zu)\n",
-		       size, max);
-		return;
+		if (max < size) {
+			pr_err("ESRT header doesn't fit on single memory map entry. (size: %zu max: %zu)\n",
+			       size, max);
+			return;
+		}
+	} else {
+		reserve_esrt = true;
+		max = SIZE_MAX;
 	}
 
 	va = early_memremap(efi.esrt, size);
@@ -332,9 +337,11 @@ void __init efi_esrt_init(void)
 	esrt_data_size = size;
 
 	end = esrt_data + size;
-	pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data, &end);
-	if (md.type == EFI_BOOT_SERVICES_DATA)
+	if (reserve_esrt) {
+		pr_info("Reserving ESRT space from %pa to %pa.\n", &esrt_data,
+			&end);
 		efi_mem_reserve(esrt_data, esrt_data_size);
+	}
 
 	pr_debug("esrt-init: loaded.\n");
 }
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 16:28:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 16:28:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414687.659027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of1pJ-0004aP-Sb; Sun, 02 Oct 2022 16:28:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414687.659027; Sun, 02 Oct 2022 16:28:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of1pJ-0004aI-PV; Sun, 02 Oct 2022 16:28:25 +0000
Received: by outflank-mailman (input) for mailman id 414687;
 Sun, 02 Oct 2022 16:28:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9ZZD=2D=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1of1pI-0004a7-1H
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 16:28:24 +0000
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38ac10e8-426f-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 18:28:21 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id BBD9F3200312;
 Sun,  2 Oct 2022 12:28:15 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sun, 02 Oct 2022 12:28:16 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 2 Oct 2022 12:28:14 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38ac10e8-426f-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664728095; x=
	1664814495; bh=MiecNKyXd2mjQKvsiXXO7VUmoA5W7UHlKNcygluiYqQ=; b=d
	IS0utWmebj985wLTUYcwtwPGdLb/rcuFhmqLL4Q/gW/kiEj5WKLtLLKgmztqiEAm
	CUkVGzXH+ztEb1QecYfLoqcMHRJYBX4yKKKalT89gwS9WaTIV9GAeIAhoLuq1USh
	t/jKBYsG86yfhCxGJ3kgUXOaseOK1OFJpDbkf35MfqEIIJqMXO0ybVSw3hB1gB3M
	d1RDx/4+Ru0K2yWQGAXQvnJqd6dyZNhcWT760K3pwFfwPEJ8AHpt0QvXSRqG41va
	iJsGUGFVbCNp1fuZJ1So2yzH+yjyWQ10mMWfKdK5gM+m668wjea45jh7aqC1vWVF
	SF+Uu13kg0gLhB19gZ16Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664728095; x=1664814495; bh=MiecNKyXd2mjQKvsiXXO7VUmoA5W
	7UHlKNcygluiYqQ=; b=wOZdpC3j8qBpb/YpaHsXpp1cVz4CLQJ1jlIgjmziRtnh
	J+tmUA4dcgoq6E86tHV4Qn1FUZ1OAhN1M5Z5WosdbPcdHrx+UWAjhiwj9ZQyEsF5
	pDemQSyJ9kyT1U6bdw5sfZHByiI1kjE3moiA5Frifhr9vAezX/z7rX4I4PjVnCyG
	/k6kmQAp1t0vTf56gLGXUHiO0esOW7sZbLMWUXMsXgodW93+8YrncWWkWikPoqiU
	OjUjtvHrquWOwhcFvAwgCdecBUBbRuPRfovNIM31RRqXdyI1TTderDmgQbgnhR/U
	N9rz2vLmQiMImpELeNDw8rCv9xVHUhctkG4qU/Ak3w==
X-ME-Sender: <xms:Hrw5Y1J49C4jmA53GcWuk7dtf2LN8dfTrPedyYhHj9ooDOn7jAAXmw>
    <xme:Hrw5YxIDv_HF6ZhWP25CohWp91uf1FA4IQTWF1dovLPc6fOL8_WKwcv9I_K3uirPr
    Lwe0UWkq0q134k>
X-ME-Received: <xmr:Hrw5Y9vSDvP-7wY4IgaeW6bUwY9tRnNaVyXovEkntJL_0xxCU6FlNbDhZ1b5>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehjedguddtudcutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg
    fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne
    curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg
    shhlrggsrdgtohhm
X-ME-Proxy: <xmx:Hrw5Y2b1h18k9DkfRUlh5XU_7Vat04XMHgsb2Fo9laHllyRj2zpAdQ>
    <xmx:Hrw5Y8bkqL3K5OAVjumTnOzquydFVgYiohkqpZXNc9mgJVfJ5jNalQ>
    <xmx:Hrw5Y6Do4ZmpspLh-PfUIdrJUDUUcAQy43hT5Oc_BsJY1Cg9SJsIyg>
    <xmx:H7w5Y6k7veAW2bt3yGZlllmkjXHtrmhsjXPeBSg7hF2-hM_SydZD1Q>
Feedback-ID: iac594737:Fastmail
Date: Sun, 2 Oct 2022 12:27:45 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [RFC PATCH 5/5] efi: esrt: Omit region sanity check when no
 memory map is available
Message-ID: <Yzm8HIccvuxyicYx@itl-email>
References: <20221002095626.484279-1-ardb@kernel.org>
 <20221002095626.484279-6-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QQU1t/S22Mb/zn2F"
Content-Disposition: inline
In-Reply-To: <20221002095626.484279-6-ardb@kernel.org>


--QQU1t/S22Mb/zn2F
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sun, 2 Oct 2022 12:27:45 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [RFC PATCH 5/5] efi: esrt: Omit region sanity check when no
 memory map is available

On Sun, Oct 02, 2022 at 11:56:26AM +0200, Ard Biesheuvel wrote:
> In order to permit the ESRT to be used when doing pseudo-EFI boot
> without a EFI memory map, e.g., when booting inside a Xen dom0 on x86,
> make the sanity checks optional based on whether the memory map is
> available.
>=20
> If additional validation is needed, it is up to the Xen EFI glue code to
> implement this in its xen_efi_config_table_is_valid() helper, or provide
> a EFI memory map like it does on other architectures.

I don=E2=80=99t like this.  It is easy to use a hypercall to get the end of=
 the
memory region containing the config table, which is what my one of my
previous patches actually does.  Skipping all of the validation could
easily lead to a regression.  I understand wanting to get Xen-specific
code out of esrt.c, but this isn=E2=80=99t the answer.  Some sort of abstra=
ction
over both cases would be a much better solution.

> Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  arch/x86/platform/efi/quirks.c |  3 +
>  drivers/firmware/efi/esrt.c    | 61 +++++++++++---------
>  2 files changed, 37 insertions(+), 27 deletions(-)
>=20
> diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirk=
s.c
> index b0b848d6933a..9307be2f4afa 100644
> --- a/arch/x86/platform/efi/quirks.c
> +++ b/arch/x86/platform/efi/quirks.c
> @@ -250,6 +250,9 @@ void __init efi_arch_mem_reserve(phys_addr_t addr, u6=
4 size)
>  	int num_entries;
>  	void *new;
> =20
> +	if (!efi_enabled(EFI_MEMMAP))
> +		return;
> +

This function does not actually work under Xen, even if EFI_MEMMAP is
set.  When running under Xen, either this function must never be
called (in which case there should be at least a WARN()), or it should
return an error that callers must check for.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--QQU1t/S22Mb/zn2F
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM5vBwACgkQsoi1X/+c
IsEwCxAAlyb5VQUqy3kjfzT9uVV2XGHHsFY5oUp2S1DOf2/vSL4zaWmqVB/AkYDt
kavthj4HgkbYaZcwxMtxlwQ+W0dLDoTjRQrIVOmT09JmQptihevWVjOrCEqIxSt9
BUw04yrgVUaG6GgkI0oierJOfgUpUfYSk2Le3kDR+KmparUv5zVHbVYmmERPOQnF
zNYuYx9s+Vw8TeOXvO7a6uba41ebD6eLbd+pWtBT/qaP7+0tqUGbGSEemesC4/us
XU/pHjJZAyyNc60c12xziMd+dCCcHD0SJ8iuevAOUD6dgXE2WAhiGxMeXH34tLGK
cCEPwSYf34OW77qeOZLDuqzRUmidh5U87a57onxkcnYBsP2sWP/2INXcfP0LhZkI
XRhO7xJQewPkAvAY7KYVByXarMmCEosSwSuwyu6FncBwrvrSEW6BaPmDmv2lW49A
5+OUaLXuUPW9/9AHoaneIssBmd/f1cpnFE+6coHk0EakKyUtxLb+BAOzk3krT6Hd
Og9qaOOrttTVwkTvegPcsAyElcJ23KJk6HbJDYeSvN/BIihyHkE3yUpYbD35qgM6
xpdR/B7y5/+YDxi1NopNBZSha6VM24+THP9qVT6M2dzxdtG+HpwPq7mtP70vpI6j
aR6qe3DIJWdbnI68PXWOtu8xLW7y5UIv7KIqblKYmXdTBXAKQhM=
=za8l
-----END PGP SIGNATURE-----

--QQU1t/S22Mb/zn2F--


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 16:28:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 16:28:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414688.659033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of1pK-0004du-6T; Sun, 02 Oct 2022 16:28:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414688.659033; Sun, 02 Oct 2022 16:28:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of1pK-0004da-1P; Sun, 02 Oct 2022 16:28:26 +0000
Received: by outflank-mailman (input) for mailman id 414688;
 Sun, 02 Oct 2022 16:28:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9ZZD=2D=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1of1pI-0004a7-VK
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 16:28:25 +0000
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3a18ed84-426f-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 18:28:21 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id DAA6932003F4;
 Sun,  2 Oct 2022 12:28:18 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sun, 02 Oct 2022 12:28:19 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 2 Oct 2022 12:28:17 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a18ed84-426f-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664728098; x=
	1664814498; bh=G0vV3Oa2ZZq1J9zBhSTJatfU2fwQHSYgySIi6UczSXI=; b=E
	h9naX8daSDPCN2bBf+ktQHwsOkwd6zMSTRgfCd8CwbInXFvpfKRwKQYQbwSLDtgX
	sv2hZzgiq/oBCrgccWLXTy/S34QrEt/O3ZyErr6WtGBW2u72yOjEbskFaKxSvvqs
	QzMPR9D7Sn8NOJRV8uBwGV48aKe5ezZCPlb5RlcFOdIvyFiW8NsR4pSnAkRsUuw2
	CRXKzz2Ze89Lk4wS4w7vaHfXn3AfSrctTlEPx6Tgu1JVEJMQ6WghYE66cCftdvAM
	FSFiYc3wYrCZmiB/pRraGXQR1Saz4Kz1pKznbATsY6ddiSNyv7oAChH7JYlwZzzA
	0Y9K5Hk0RtIPsi72LHwYQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664728098; x=1664814498; bh=G0vV3Oa2ZZq1J9zBhSTJatfU2fwQ
	HSYgySIi6UczSXI=; b=0apj9EM8OTeJ0iftmlwc/NwcnlDsgsp9dfGuHy5Z05Ys
	kUdPs37l2y6km4wJjO1Tjk6U4UDxk7Xk3aGPYsJseBMc6g6AvM0cXWmmiy0EhT+y
	bilWUV5I55mnUVz9yL7tV9klq9JUxGEYstCe/blnV2uoKeDTFs8i31D7EKk+uVwv
	RERP8VtLEr84FSMe07MA3PfXXpJxFLhCseNkG7VyM+3jgVvc8JxDqgy+RsG3iKKW
	m7DxNK6KK9r84jL1wtWgqhjDWh7xhvtTtp2mhdaEEloxk2iil8vUSmnrXp5NNkhc
	eGabTJgxNkhaIgSVhhrvMGiECxk9AmaNluVbvtQxAw==
X-ME-Sender: <xms:Irw5Y4wxMc8m7vvTwVCO-LHpZ5FJiQxu58DzWuVy2tM4XMEkS3-iDQ>
    <xme:Irw5Y8T8e8fy45SSLM9XIwChS_RBLUrS8Ft0jeRK_1Fz0V-kbwDdmAg7U8k_RNDCG
    5x6nHmgHXUD_IQ>
X-ME-Received: <xmr:Irw5Y6UP80h-oFOIVjThpaGrmkRjcC9f_GmwjfNmqXdd32Yz-DCL4iV22vSO>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehjedguddtudcutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg
    fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedune
    curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg
    shhlrggsrdgtohhm
X-ME-Proxy: <xmx:Irw5Y2hTizZVN9EkjLWYlUUVGL3OFx5XeQoQGS5lPwjJP8D_BKuhYw>
    <xmx:Irw5Y6C3Zbb69t_mfQAbSO5Nw5qh_qkgpASZPbtUmeFFwqaUvyXfcA>
    <xmx:Irw5Y3KLr5RmWCJNql17ZEnrZWvs1ymwDyM0N-3RV8Lp25WkaPtBvQ>
    <xmx:Irw5YysePNjv21Hz7XRJc12XZoq7CtCrWeTex6IolgvWfv4HEO6A3w>
Feedback-ID: iac594737:Fastmail
Date: Sun, 2 Oct 2022 12:27:57 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [RFC PATCH 4/5] efi: Apply allowlist to EFI configuration tables
 when running under Xen
Message-ID: <Yzm8H3iS7ziWsh7E@itl-email>
References: <20221002095626.484279-1-ardb@kernel.org>
 <20221002095626.484279-5-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JTIF6sEbcgRHIDwD"
Content-Disposition: inline
In-Reply-To: <20221002095626.484279-5-ardb@kernel.org>


--JTIF6sEbcgRHIDwD
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sun, 2 Oct 2022 12:27:57 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [RFC PATCH 4/5] efi: Apply allowlist to EFI configuration tables
 when running under Xen

On Sun, Oct 02, 2022 at 11:56:25AM +0200, Ard Biesheuvel wrote:
> As it turns out, Xen does not guarantee that EFI bootservices data
> regions in memory are preserved, which means that EFI configuration
> tables pointing into such memory regions may be corrupted before the
> dom0 OS has had a chance to inspect them.
>=20
> Demi Marie reports that this is causing problems for Qubes OS when it
> attempts to perform system firmware updates, which requires that the
> contents of the ESRT configuration table are valid when the fwupd user
> space program runs.
>=20
> However, other configuration tables such as the memory attributes
> table or the runtime properties table are equally affected, and so we
> need a comprehensive workaround that works for any table type.
>=20
> So let's first disregard all EFI configuration tables except the ones
> that are known (or can be expected) to reside in memory regions of a
> type that Xen preserves, i.e., ACPI tables (which are passed in
> EfiAcpiReclaimMemory regions) and SMBIOS tables (which are usually
> passed in EfiRuntimeServicesData regions, even though the UEFI spec only
> mentions this as a recommendation). Then, cross reference unknown tables
> against either the EFI memory map (if available) or do a Xen hypercall
> to determine the memory type, and allow the config table if the type is
> one that is guaranteed to be preserved.
>=20
> Future patches can augment the logic in this routine to allow other
> table types based on the size of the allocation, or based on a table
> specific header size field.
>=20
> Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  drivers/firmware/efi/efi.c |  7 ++
>  drivers/xen/efi.c          | 69 ++++++++++++++++++++
>  include/linux/efi.h        |  2 +
>  3 files changed, 78 insertions(+)
>=20
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 11857af72859..e8c0747011d7 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -556,6 +556,13 @@ static __init int match_config_table(const efi_guid_=
t *guid,
> =20
>  	for (i =3D 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
>  		if (!efi_guidcmp(*guid, table_types[i].guid)) {
> +			if (IS_ENABLED(CONFIG_XEN_EFI) &&
> +			    !xen_efi_config_table_is_usable(guid, table)) {
> +				if (table_types[i].name[0])
> +					pr_cont("(%s=3D0x%lx) ",
> +						table_types[i].name, table);
> +				return 1;
> +			}
>  			*(table_types[i].ptr) =3D table;
>  			if (table_types[i].name[0])
>  				pr_cont("%s=3D0x%lx ",
> diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> index d1ff2186ebb4..3f1f365b37d0 100644
> --- a/drivers/xen/efi.c
> +++ b/drivers/xen/efi.c
> @@ -292,3 +292,72 @@ void __init xen_efi_runtime_setup(void)
>  	efi.get_next_high_mono_count	=3D xen_efi_get_next_high_mono_count;
>  	efi.reset_system		=3D xen_efi_reset_system;
>  }
> +
> +static const efi_guid_t cfg_table_allow_list[] __initconst =3D {
> +	ACPI_20_TABLE_GUID,
> +	ACPI_TABLE_GUID,
> +	SMBIOS_TABLE_GUID,
> +	SMBIOS3_TABLE_GUID,
> +};

This allowlist seems redundant.  Either the tables are already in memory
that Xen will preserve or they aren=E2=80=99t.  In both cases the subsequent
code will do the right thing.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--JTIF6sEbcgRHIDwD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM5vCAACgkQsoi1X/+c
IsFlDxAAqU0aemId9IrdaxQg73+mapJXMkGjC3ASXWfOTnPkkzgJfZKYpgPnatRQ
Rr5RX9xyMl/vm8KFYsiBZXh9x2b5CPzbZ/lrmtVdgVtSJxSIMQMayGtPeBTL/ZkW
Y4WouKbgn9uj5UTyWFSTlorn4xUHY1Sot1Xowek1pezMrG33qzdycCSW9Epi7bEo
JxXgpXN2Gq8Slns6s//DvxSSOYMFCafRN9HZjl4+oc1lElR/tYDGWWhmWNTrEy50
WxoJjH8NDzb0aNJPuGiADidlMI+pAQXAleHBNl4zCxc8PuUkCsHuNYubrmfHuo55
0X21DUMnsS4m96qAFcQoWFTLy2JEDNQuW7souGNtiPQcQW7uyrIUq1f/ZdXLJnlr
5ZXK9QDagePjlFIbYdLTb4zO0WcJEXOf7TKpG7GLHhwE4DrI1/GoMdTRQrzB+Kcd
ZlGR4theXCih9+19qCasrHZQc8Gic3w6jynjrWuEVz9qa8VNklUEvus6fOp5+Ah/
Q2UPD2vgP8F8RohrTtoxLPSU2aZpZYcDzxcaZlbptMI4BE63gLNaevsbLG+VTW2o
ITjtfMBpjfn5gixxIWJ7dlBu52sUtergum2hmrZD2QzrBGsdalrXE5sl2dmMw3CO
sFoCyfgsyPUxgQHidAWUTRoRynQYlul3cxT35sjrHaYyqoF8he0=
=IJcK
-----END PGP SIGNATURE-----

--JTIF6sEbcgRHIDwD--


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 21:23:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 21:23:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414700.659049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of6Qh-0007bH-Uj; Sun, 02 Oct 2022 21:23:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414700.659049; Sun, 02 Oct 2022 21:23:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of6Qh-0007bA-Rv; Sun, 02 Oct 2022 21:23:19 +0000
Received: by outflank-mailman (input) for mailman id 414700;
 Sun, 02 Oct 2022 21:23:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1of6Qg-0007b4-1j
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 21:23:18 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6bff718d-4298-11ed-9375-c1cf23e5d27e;
 Sun, 02 Oct 2022 23:23:14 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id E870C60F49
 for <xen-devel@lists.xenproject.org>; Sun,  2 Oct 2022 21:23:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA81CC43140
 for <xen-devel@lists.xenproject.org>; Sun,  2 Oct 2022 21:23:11 +0000 (UTC)
Received: by mail-lf1-f44.google.com with SMTP id o7so6833584lfk.7
 for <xen-devel@lists.xenproject.org>; Sun, 02 Oct 2022 14:23:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bff718d-4298-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664745791;
	bh=0nNY8bCYUKoCFv7L9DxhKWtTW9KM4y+517wmHIAOs58=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=NhOMyRznBbhA6BsLS63d0grbgr/ob9A1/EnJfFdIN2JJAnzrc71FV7Gy6Arty4L2T
	 +LfGqx41AfuldsgDDesSwpT9MLGgJa1auhABxu+6/BS7MtGbcLCOPeYrD7v0l/PzeT
	 3aVmZr4BpfZgJ+Svc89R6L+g4KFC/aSrChYtODfCDfWsnwppvFTZtt0xQ2gIYjlz0U
	 ocVOiRwkR6Mw4xAnX5dIX2QpZ+FRxe4gT0Np/LbkHEeuPdq6d2ZJFotbit9mr4dXz9
	 KBAK92Un0j/gIews+sWPBTF3zvF4JNT/GA4ts3kHym2bpJa5G3xfyfXFkL5o8+AGHn
	 keVgfvHkUddSw==
X-Gm-Message-State: ACrzQf3u1x7ugLdJw/NjzKpBwYAhFZarWNVfNo7Tc2fz02IFyfFdGEGn
	lwc8sTkFhI4TgWOLRB+ceDJf4qRkATDm8WMjMww=
X-Google-Smtp-Source: AMsMyM65/tOSFAGff3kubN/KRJEKo5eRy1SIh573DTKw2LTBa6vPYzy9QMui3K/FZnPpk1r072gHON+N+0xFncjh3MY=
X-Received: by 2002:a05:6512:150e:b0:492:d9fd:9bdf with SMTP id
 bq14-20020a056512150e00b00492d9fd9bdfmr6130056lfb.583.1664745789709; Sun, 02
 Oct 2022 14:23:09 -0700 (PDT)
MIME-Version: 1.0
References: <20221002095626.484279-1-ardb@kernel.org> <20221002095626.484279-5-ardb@kernel.org>
 <Yzm8H3iS7ziWsh7E@itl-email>
In-Reply-To: <Yzm8H3iS7ziWsh7E@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Sun, 2 Oct 2022 23:22:58 +0200
X-Gmail-Original-Message-ID: <CAMj1kXFWS0kXp7f75x=BDYDyTHKNzMCTZ_bXg7v23Aw=pJtSzQ@mail.gmail.com>
Message-ID: <CAMj1kXFWS0kXp7f75x=BDYDyTHKNzMCTZ_bXg7v23Aw=pJtSzQ@mail.gmail.com>
Subject: Re: [RFC PATCH 4/5] efi: Apply allowlist to EFI configuration tables
 when running under Xen
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, 
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2 Oct 2022 at 18:28, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Sun, Oct 02, 2022 at 11:56:25AM +0200, Ard Biesheuvel wrote:
> > As it turns out, Xen does not guarantee that EFI bootservices data
> > regions in memory are preserved, which means that EFI configuration
> > tables pointing into such memory regions may be corrupted before the
> > dom0 OS has had a chance to inspect them.
> >
> > Demi Marie reports that this is causing problems for Qubes OS when it
> > attempts to perform system firmware updates, which requires that the
> > contents of the ESRT configuration table are valid when the fwupd user
> > space program runs.
> >
> > However, other configuration tables such as the memory attributes
> > table or the runtime properties table are equally affected, and so we
> > need a comprehensive workaround that works for any table type.
> >
> > So let's first disregard all EFI configuration tables except the ones
> > that are known (or can be expected) to reside in memory regions of a
> > type that Xen preserves, i.e., ACPI tables (which are passed in
> > EfiAcpiReclaimMemory regions) and SMBIOS tables (which are usually
> > passed in EfiRuntimeServicesData regions, even though the UEFI spec onl=
y
> > mentions this as a recommendation). Then, cross reference unknown table=
s
> > against either the EFI memory map (if available) or do a Xen hypercall
> > to determine the memory type, and allow the config table if the type is
> > one that is guaranteed to be preserved.
> >
> > Future patches can augment the logic in this routine to allow other
> > table types based on the size of the allocation, or based on a table
> > specific header size field.
> >
> > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  drivers/firmware/efi/efi.c |  7 ++
> >  drivers/xen/efi.c          | 69 ++++++++++++++++++++
> >  include/linux/efi.h        |  2 +
> >  3 files changed, 78 insertions(+)
> >
> > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > index 11857af72859..e8c0747011d7 100644
> > --- a/drivers/firmware/efi/efi.c
> > +++ b/drivers/firmware/efi/efi.c
> > @@ -556,6 +556,13 @@ static __init int match_config_table(const efi_gui=
d_t *guid,
> >
> >       for (i =3D 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
> >               if (!efi_guidcmp(*guid, table_types[i].guid)) {
> > +                     if (IS_ENABLED(CONFIG_XEN_EFI) &&
> > +                         !xen_efi_config_table_is_usable(guid, table))=
 {
> > +                             if (table_types[i].name[0])
> > +                                     pr_cont("(%s=3D0x%lx) ",
> > +                                             table_types[i].name, tabl=
e);
> > +                             return 1;
> > +                     }
> >                       *(table_types[i].ptr) =3D table;
> >                       if (table_types[i].name[0])
> >                               pr_cont("%s=3D0x%lx ",
> > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > index d1ff2186ebb4..3f1f365b37d0 100644
> > --- a/drivers/xen/efi.c
> > +++ b/drivers/xen/efi.c
> > @@ -292,3 +292,72 @@ void __init xen_efi_runtime_setup(void)
> >       efi.get_next_high_mono_count    =3D xen_efi_get_next_high_mono_co=
unt;
> >       efi.reset_system                =3D xen_efi_reset_system;
> >  }
> > +
> > +static const efi_guid_t cfg_table_allow_list[] __initconst =3D {
> > +     ACPI_20_TABLE_GUID,
> > +     ACPI_TABLE_GUID,
> > +     SMBIOS_TABLE_GUID,
> > +     SMBIOS3_TABLE_GUID,
> > +};
>
> This allowlist seems redundant.  Either the tables are already in memory
> that Xen will preserve or they aren=E2=80=99t.  In both cases the subsequ=
ent
> code will do the right thing.

Will it? Currently, Xen simply accepts all ACPI and SMBIOS tables,
regardless of what type of memory region they reside in (if any).

So what will happen with buggy firmware where the ACPI or SMBIOS
tables are not covered by the memory map at all? Currently, this works
fine but now, it will be rejected. And without ACPI tables, the boot
will not get far enough to even inform the user what is wrong. And
SMBIOS tables are used for platform quirks, which means they might be
essential for a platform to boot as well.


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 21:43:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 21:43:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414705.659061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of6kN-0001XE-N1; Sun, 02 Oct 2022 21:43:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414705.659061; Sun, 02 Oct 2022 21:43:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of6kN-0001X7-Ho; Sun, 02 Oct 2022 21:43:39 +0000
Received: by outflank-mailman (input) for mailman id 414705;
 Sun, 02 Oct 2022 21:43:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1gGO=2D=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1of6kM-0001X1-Qc
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 21:43:38 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43e77172-429b-11ed-964a-05401a9f4f97;
 Sun, 02 Oct 2022 23:43:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 1B221CE0ABB
 for <xen-devel@lists.xenproject.org>; Sun,  2 Oct 2022 21:43:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CD0EC4347C
 for <xen-devel@lists.xenproject.org>; Sun,  2 Oct 2022 21:43:31 +0000 (UTC)
Received: by mail-lf1-f52.google.com with SMTP id d6so20171lfs.10
 for <xen-devel@lists.xenproject.org>; Sun, 02 Oct 2022 14:43:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43e77172-429b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664747011;
	bh=IAPSgTIJ2zWHmsG/r3356fUhr6dadqjrzGJLMrSOPZw=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=Z3PVkcW1VFO5tHecQ62YmtGJqa/Trl+xbSnKgdsr9BeaI3b1FRi3piTdyidsrbemE
	 7JVAEt2WCtsGYZeGhQivdX0sY8pz2/7F6A95sTpUAiR99th5Q2TFtdO2X8kBVSMtFb
	 H/NBbWLQf4Bq0pu1E+nA1WOkWjWvafgbpo/vh+Dch9jz3KhH7Ouqxyh3bpb0Ifp2u4
	 BV5LQzrYohl/NMmrOhbRsoOj8agJmKzK4QE2EeALzgqFgW2Wwzc/Pupem0XUUZ9eUd
	 yoY6hyv2OKCfIiVoaekI7Rjrf5fJ8zszXqj4vSgpIiH8i1lBWdmg703WrjDpuQjCdG
	 osqwUex8gaPOQ==
X-Gm-Message-State: ACrzQf16JWVzXJrQLq1NaeTyncIRqdb+jVKELrWD+sqrd3ax0uPHHZnw
	xx1i4cYEFaNPoCd4WHW2oCMBocky/AnIXABgsaM=
X-Google-Smtp-Source: AMsMyM585Xujcy26w6Ya5o+jV4sDOXs2w1GklBdKzIVYftuz6Q4NJYiDHea6a2mBWjS3AxbZTV8fZ2FoQ/xS1ntA6VE=
X-Received: by 2002:a19:c20b:0:b0:4a2:40e5:78b1 with SMTP id
 l11-20020a19c20b000000b004a240e578b1mr393347lfc.228.1664747009153; Sun, 02
 Oct 2022 14:43:29 -0700 (PDT)
MIME-Version: 1.0
References: <20221002095626.484279-1-ardb@kernel.org> <20221002095626.484279-6-ardb@kernel.org>
 <Yzm8HIccvuxyicYx@itl-email>
In-Reply-To: <Yzm8HIccvuxyicYx@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Sun, 2 Oct 2022 23:43:17 +0200
X-Gmail-Original-Message-ID: <CAMj1kXG-0Bpc5B08EAJTGsNKan4S4628Wwz7wPh-EAY9p4zg1Q@mail.gmail.com>
Message-ID: <CAMj1kXG-0Bpc5B08EAJTGsNKan4S4628Wwz7wPh-EAY9p4zg1Q@mail.gmail.com>
Subject: Re: [RFC PATCH 5/5] efi: esrt: Omit region sanity check when no
 memory map is available
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, 
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2 Oct 2022 at 18:28, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Sun, Oct 02, 2022 at 11:56:26AM +0200, Ard Biesheuvel wrote:
> > In order to permit the ESRT to be used when doing pseudo-EFI boot
> > without a EFI memory map, e.g., when booting inside a Xen dom0 on x86,
> > make the sanity checks optional based on whether the memory map is
> > available.
> >
> > If additional validation is needed, it is up to the Xen EFI glue code t=
o
> > implement this in its xen_efi_config_table_is_valid() helper, or provid=
e
> > a EFI memory map like it does on other architectures.
>
> I don=E2=80=99t like this.  It is easy to use a hypercall to get the end =
of the
> memory region containing the config table, which is what my one of my
> previous patches actually does.  Skipping all of the validation could
> easily lead to a regression.

I don't like putting Xen specific hacks left and right because Xen on
x86 cannot be bothered to provide an EFI memory map. And as for
regressions, ESRT does not work at all under Xen (given the lack of a
memory map) and so I fail to see how this could break a currently
working case.

>  I understand wanting to get Xen-specific
> code out of esrt.c, but this isn=E2=80=99t the answer.  Some sort of abst=
raction
> over both cases would be a much better solution.
>

We have such an abstraction already, it is called the EFI memory map.

So there are two options here:
- expose a EFI memory map
- add a ESRT specific check to xen_efi_config_table_is_valid() so that
the ESRT is withheld from dom0 if there is something wrong with it.

And frankly, the validation itself could use some attention as well:

"""
rc =3D efi_mem_desc_lookup(efi.esrt, &md);
...
max =3D efi_mem_desc_end(&md);
if (max < efi.esrt) {
"""

Unless I am missing something, this can never occur so the check is
pointless and the pr_err() that follows is unreachable.

Then we have

"""
size =3D sizeof(*esrt);
max -=3D efi.esrt;

if (max < size) {
"""

'size' is 16 bytes here, so the only way this can become true is if
the memory descriptor describes a region of 0 pages in length, which
is explicitly forbidden by the EFI spec. If such a descriptor exists
in spite of that, this is a memory map problem not a ESRT problem.

So actually, instead of making these checks conditional on EFI_MEMMAP
being set, I might just rip them out entirely and be done with it.



> > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  arch/x86/platform/efi/quirks.c |  3 +
> >  drivers/firmware/efi/esrt.c    | 61 +++++++++++---------
> >  2 files changed, 37 insertions(+), 27 deletions(-)
> >
> > diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/qui=
rks.c
> > index b0b848d6933a..9307be2f4afa 100644
> > --- a/arch/x86/platform/efi/quirks.c
> > +++ b/arch/x86/platform/efi/quirks.c
> > @@ -250,6 +250,9 @@ void __init efi_arch_mem_reserve(phys_addr_t addr, =
u64 size)
> >       int num_entries;
> >       void *new;
> >
> > +     if (!efi_enabled(EFI_MEMMAP))
> > +             return;
> > +
>
> This function does not actually work under Xen, even if EFI_MEMMAP is
> set.  When running under Xen, either this function must never be
> called (in which case there should be at least a WARN()), or it should
> return an error that callers must check for.
> --
> Sincerely,
> Demi Marie Obenour (she/her/hers)
> Invisible Things Lab


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 22:20:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 22:20:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414713.659070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7KE-0005kj-Kf; Sun, 02 Oct 2022 22:20:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414713.659070; Sun, 02 Oct 2022 22:20:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7KE-0005kc-HT; Sun, 02 Oct 2022 22:20:42 +0000
Received: by outflank-mailman (input) for mailman id 414713;
 Sun, 02 Oct 2022 22:20:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=STlk=2D=runbox.com=m.v.b@srs-se1.protection.inumbo.net>)
 id 1of7KD-0005kR-0n
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 22:20:41 +0000
Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com
 [2a0c:5a00:149::26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 71af7d7a-42a0-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 00:20:39 +0200 (CEST)
Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com)
 by mailtransmit05.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <m.v.b@runbox.com>)
 id 1of7K9-009uTo-Fw; Mon, 03 Oct 2022 00:20:37 +0200
Received: from [10.9.9.74] (helo=submission03.runbox)
 by mailtransmit02.runbox with esmtp (Exim 4.86_2)
 (envelope-from <m.v.b@runbox.com>)
 id 1of7K8-0006iO-SE; Mon, 03 Oct 2022 00:20:37 +0200
Received: by submission03.runbox with esmtpsa [Authenticated ID (536975)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1of7Jz-00061b-RQ; Mon, 03 Oct 2022 00:20:28 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71af7d7a-42a0-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com;
	 s=selector2; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To
	:Message-Id:Date:Subject:Cc:To:From;
	bh=IbJuVdq/QrQKAp9cm0ptCR4E1O6oLQr+Cte2Q8caJXI=; b=gZDesZiFM3cDQyvzP/+EZKGsLv
	VX3w8pGR4ncemINA23fRwh3L1UHLJqYcR+r/6gOT87AeeRBjL3ntG5JYS1YHObVtFYSJ63kBlecsL
	A9qJMgNRIIXClOqv8xTX03vROUmwQtk6nZI83NkpiMyGkQ+TvmbUCxrB8rwW2wJlxGLHHm9Z9CUPg
	8diqLHynunkM48gcmDXSRbInkXZZbnv5/jCrTHel5eVwi6p30URPPkU/G0ywkXSGRNvy3xHX1670a
	cWP1ABHyJ+SD/39QDsD3MuTo7UBdLy4TkqdOUmBlAG6q7DH5wLE7yk8MzIv62/REqrEV+x7CTbZBh
	UqzrzK9g==;
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: m.v.b@runbox.com,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 2/2] xen/gntdev: Accommodate VMA splitting
Date: Sun,  2 Oct 2022 18:20:06 -0400
Message-Id: <20221002222006.2077-3-m.v.b@runbox.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221002222006.2077-1-m.v.b@runbox.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Prior to this commit, the gntdev driver code did not handle the
following scenario correctly with paravirtualized (PV) Xen domains:

* User process sets up a gntdev mapping composed of two grant mappings
  (i.e., two pages shared by another Xen domain).
* User process munmap()s one of the pages.
* User process munmap()s the remaining page.
* User process exits.

In the scenario above, the user process would cause the kernel to log
the following messages in dmesg for the first munmap(), and the second
munmap() call would result in similar log messages:

  BUG: Bad page map in process doublemap.test  pte:... pmd:...
  page:0000000057c97bff refcount:1 mapcount:-1 \
    mapping:0000000000000000 index:0x0 pfn:...
  ...
  page dumped because: bad pte
  ...
  file:gntdev fault:0x0 mmap:gntdev_mmap [xen_gntdev] readpage:0x0
  ...
  Call Trace:
   <TASK>
   dump_stack_lvl+0x46/0x5e
   print_bad_pte.cold+0x66/0xb6
   unmap_page_range+0x7e5/0xdc0
   unmap_vmas+0x78/0xf0
   unmap_region+0xa8/0x110
   __do_munmap+0x1ea/0x4e0
   __vm_munmap+0x75/0x120
   __x64_sys_munmap+0x28/0x40
   do_syscall_64+0x38/0x90
   entry_SYSCALL_64_after_hwframe+0x61/0xcb
   ...

For each munmap() call, the Xen hypervisor (if built with CONFIG_DEBUG)
would print out the following and trigger a general protection fault in
the affected Xen PV domain:

  (XEN) d0v... Attempt to implicitly unmap d0's grant PTE ...
  (XEN) d0v... Attempt to implicitly unmap d0's grant PTE ...

As of this writing, gntdev_grant_map structure's vma field (referred to
as map->vma below) is mainly used for checking the start and end
addresses of mappings. However, with split VMAs, these may change, and
there could be more than one VMA associated with a gntdev mapping.
Hence, remove the use of map->vma and rely on map->pages_vm_start for
the original start address and on (map->count << PAGE_SHIFT) for the
original mapping size. Let the invalidate() and find_special_page()
hooks use these.

Also, given that there can be multiple VMAs associated with a gntdev
mapping, move the "mmu_interval_notifier_remove(&map->notifier)" call to
the end of gntdev_put_map, so that the MMU notifier is only removed
after the closing of the last remaining VMA.

Finally, use an atomic to prevent inadvertent gntdev mapping re-use,
instead of using the map->live_grants atomic counter and/or the map->vma
pointer (the latter of which is now removed). This prevents the
userspace from mmap()'ing (with MAP_FIXED) a gntdev mapping over the
same address range as a previously set up gntdev mapping. This scenario
can be summarized with the following call-trace, which was valid prior
to this commit:

  mmap
    gntdev_mmap
  mmap (repeat mmap with MAP_FIXED over the same address range)
    gntdev_invalidate
      unmap_grant_pages (sets 'being_removed' entries to true)
        gnttab_unmap_refs_async
    unmap_single_vma
    gntdev_mmap (maps the shared pages again)
  munmap
    gntdev_invalidate
      unmap_grant_pages
        (no-op because 'being_removed' entries are true)
    unmap_single_vma (For PV domains, Xen reports that a granted page
      is being unmapped and triggers a general protection fault in the
      affected domain, if Xen was built with CONFIG_DEBUG)

The fix for this last scenario could be worth its own commit, but we
opted for a single commit, because removing the gntdev_grant_map
structure's vma field requires guarding the entry to gntdev_mmap(), and
the live_grants atomic counter is not sufficient on its own to prevent
the mmap() over a pre-existing mapping.

Link: https://github.com/QubesOS/qubes-issues/issues/7631
Fixes: ab31523c2fca ("xen/gntdev: allow usermode to map granted pages")
Cc: stable@vger.kernel.org
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
---

Changes since v1:
- Amended the patch description to note that the reported issues affect
  paravirtualized (PV) Xen domains.
- Note that Juergen Gross reviewed the first version of this patch.
  (Thanks!) I did not add a Reviewed-by tag in v2, because I have
  since amended the patch description.
- No source code changes.

My original note follows.

Note for reviewers:

I am not 100% sure if the "Fixes" tag is correct. Based on a quick look
at the history of the modified file, I am under the impression that VMA
splits could be broken for the Xen gntdev driver since day 1 (i.e.,
v2.6.38), but I did not yet attempt to verify this by testing older
kernels where the gntdev driver's code is sufficiently similar.

Also, resetting the being_removed flags to false after the completion of
unmap operation could be another potential solution (that I have not yet
tested in the context of this change) to the mmap and MAP_FIXED issue
discussed at the end of the patch description.
---
 drivers/xen/gntdev-common.h |  3 +-
 drivers/xen/gntdev.c        | 58 ++++++++++++++++---------------------
 2 files changed, 27 insertions(+), 34 deletions(-)

diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h
index 40ef379c28ab..9c286b2a1900 100644
--- a/drivers/xen/gntdev-common.h
+++ b/drivers/xen/gntdev-common.h
@@ -44,9 +44,10 @@ struct gntdev_unmap_notify {
 };
 
 struct gntdev_grant_map {
+	atomic_t in_use;
 	struct mmu_interval_notifier notifier;
+	bool notifier_init;
 	struct list_head next;
-	struct vm_area_struct *vma;
 	int index;
 	int count;
 	int flags;
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index eb0586b9767d..4d9a3050de6a 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -286,6 +286,9 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map)
 		 */
 	}
 
+	if (use_ptemod && map->notifier_init)
+		mmu_interval_notifier_remove(&map->notifier);
+
 	if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
 		notify_remote_via_evtchn(map->notify.event);
 		evtchn_put(map->notify.event);
@@ -298,7 +301,7 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map)
 static int find_grant_ptes(pte_t *pte, unsigned long addr, void *data)
 {
 	struct gntdev_grant_map *map = data;
-	unsigned int pgnr = (addr - map->vma->vm_start) >> PAGE_SHIFT;
+	unsigned int pgnr = (addr - map->pages_vm_start) >> PAGE_SHIFT;
 	int flags = map->flags | GNTMAP_application_map | GNTMAP_contains_pte |
 		    (1 << _GNTMAP_guest_avail0);
 	u64 pte_maddr;
@@ -508,11 +511,7 @@ static void gntdev_vma_close(struct vm_area_struct *vma)
 	struct gntdev_priv *priv = file->private_data;
 
 	pr_debug("gntdev_vma_close %p\n", vma);
-	if (use_ptemod) {
-		WARN_ON(map->vma != vma);
-		mmu_interval_notifier_remove(&map->notifier);
-		map->vma = NULL;
-	}
+
 	vma->vm_private_data = NULL;
 	gntdev_put_map(priv, map);
 }
@@ -540,29 +539,30 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn,
 	struct gntdev_grant_map *map =
 		container_of(mn, struct gntdev_grant_map, notifier);
 	unsigned long mstart, mend;
+	unsigned long map_start, map_end;
 
 	if (!mmu_notifier_range_blockable(range))
 		return false;
 
+	map_start = map->pages_vm_start;
+	map_end = map->pages_vm_start + (map->count << PAGE_SHIFT);
+
 	/*
 	 * If the VMA is split or otherwise changed the notifier is not
 	 * updated, but we don't want to process VA's outside the modified
 	 * VMA. FIXME: It would be much more understandable to just prevent
 	 * modifying the VMA in the first place.
 	 */
-	if (map->vma->vm_start >= range->end ||
-	    map->vma->vm_end <= range->start)
+	if (map_start >= range->end || map_end <= range->start)
 		return true;
 
-	mstart = max(range->start, map->vma->vm_start);
-	mend = min(range->end, map->vma->vm_end);
+	mstart = max(range->start, map_start);
+	mend = min(range->end, map_end);
 	pr_debug("map %d+%d (%lx %lx), range %lx %lx, mrange %lx %lx\n",
-			map->index, map->count,
-			map->vma->vm_start, map->vma->vm_end,
-			range->start, range->end, mstart, mend);
-	unmap_grant_pages(map,
-				(mstart - map->vma->vm_start) >> PAGE_SHIFT,
-				(mend - mstart) >> PAGE_SHIFT);
+		 map->index, map->count, map_start, map_end,
+		 range->start, range->end, mstart, mend);
+	unmap_grant_pages(map, (mstart - map_start) >> PAGE_SHIFT,
+			  (mend - mstart) >> PAGE_SHIFT);
 
 	return true;
 }
@@ -1042,18 +1042,15 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 		return -EINVAL;
 
 	pr_debug("map %d+%d at %lx (pgoff %lx)\n",
-			index, count, vma->vm_start, vma->vm_pgoff);
+		 index, count, vma->vm_start, vma->vm_pgoff);
 
 	mutex_lock(&priv->lock);
 	map = gntdev_find_map_index(priv, index, count);
 	if (!map)
 		goto unlock_out;
-	if (use_ptemod && map->vma)
-		goto unlock_out;
-	if (atomic_read(&map->live_grants)) {
-		err = -EAGAIN;
+	if (!atomic_add_unless(&map->in_use, 1, 1))
 		goto unlock_out;
-	}
+
 	refcount_inc(&map->users);
 
 	vma->vm_ops = &gntdev_vmops;
@@ -1074,15 +1071,16 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 			map->flags |= GNTMAP_readonly;
 	}
 
+	map->pages_vm_start = vma->vm_start;
+
 	if (use_ptemod) {
-		map->vma = vma;
 		err = mmu_interval_notifier_insert_locked(
 			&map->notifier, vma->vm_mm, vma->vm_start,
 			vma->vm_end - vma->vm_start, &gntdev_mmu_ops);
-		if (err) {
-			map->vma = NULL;
+		if (err)
 			goto out_unlock_put;
-		}
+
+		map->notifier_init = true;
 	}
 	mutex_unlock(&priv->lock);
 
@@ -1099,7 +1097,6 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 		 */
 		mmu_interval_read_begin(&map->notifier);
 
-		map->pages_vm_start = vma->vm_start;
 		err = apply_to_page_range(vma->vm_mm, vma->vm_start,
 					  vma->vm_end - vma->vm_start,
 					  find_grant_ptes, map);
@@ -1128,13 +1125,8 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 out_unlock_put:
 	mutex_unlock(&priv->lock);
 out_put_map:
-	if (use_ptemod) {
+	if (use_ptemod)
 		unmap_grant_pages(map, 0, map->count);
-		if (map->vma) {
-			mmu_interval_notifier_remove(&map->notifier);
-			map->vma = NULL;
-		}
-	}
 	gntdev_put_map(priv, map);
 	return err;
 }
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 22:20:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 22:20:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414714.659082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7KF-000602-Sk; Sun, 02 Oct 2022 22:20:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414714.659082; Sun, 02 Oct 2022 22:20:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7KF-0005zv-Pk; Sun, 02 Oct 2022 22:20:43 +0000
Received: by outflank-mailman (input) for mailman id 414714;
 Sun, 02 Oct 2022 22:20:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=STlk=2D=runbox.com=m.v.b@srs-se1.protection.inumbo.net>)
 id 1of7KE-0005kR-2x
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 22:20:42 +0000
Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com
 [2a0c:5a00:149::25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 71b0edbf-42a0-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 00:20:39 +0200 (CEST)
Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com)
 by mailtransmit04.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <m.v.b@runbox.com>)
 id 1of7KA-009okT-24; Mon, 03 Oct 2022 00:20:38 +0200
Received: from [10.9.9.74] (helo=submission03.runbox)
 by mailtransmit03.runbox with esmtp (Exim 4.86_2)
 (envelope-from <m.v.b@runbox.com>)
 id 1of7K9-0005p1-PJ; Mon, 03 Oct 2022 00:20:37 +0200
Received: by submission03.runbox with esmtpsa [Authenticated ID (536975)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1of7Jw-00061b-Fs; Mon, 03 Oct 2022 00:20:24 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71b0edbf-42a0-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com;
	 s=selector2; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=wdiqOw82kPT1f9ktexLlKmUwEG+CKPWabDmPDS+O5k4=; b=wYPGzt
	cVD85qsBwNR5V3UzKo6NABK2mV5YimckAEe1rJn6C58rw3Um+9f1iSq6b14BgGk32a7OnRA4oommC
	tH29aMsQOWFTsWz+OI+QT7zDoc0hEYBI3krmBwjwvEJbJOP3JncutshClTuhBC+npxsobKszlFrkE
	x6CwGXPkumXI3ZtLiRa56HwnEBRRlI1+Dw26cXCtY6UHng4dhi9l0XNKRMbpicpJW7Utc4wJa9E2w
	UiUjTsM2sAGAfP9oVbunQrsrDDh0I1w92ZjKrffOLhyGVyVasenvTwHGGvbrXgGA+46aWj/YMNGoB
	1HriGkKs66eEe6hIEHAPMqlh+X4A==;
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: m.v.b@runbox.com,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 0/2] xen/gntdev: Fixes for leaks and VMA splitting
Date: Sun,  2 Oct 2022 18:20:04 -0400
Message-Id: <20221002222006.2077-1-m.v.b@runbox.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi all,

First of all, sorry for the delay!

These patches continue the code review for the following patches:
  https://lore.kernel.org/xen-devel/20220912040002.198191-1-m.v.b@runbox.com/t/#u

The original description of the patch set is as follows:

  "The changes in this patch series intend to fix the Xen grant device
  driver, so that grant mapping leaks caused by partially failed grant
  mapping operations are avoided with the first patch, and so that the
  splitting of VMAs does not result in incorrectly unmapped grant pages
  with the second patch. The second patch also prevents a similar issue
  in a double-mapping scenario, where mmap() is used with MAP_FIXED to
  map grants over an existing mapping created with the same grants, and
  where grant pages are unmapped incorrectly as well."

A summary of the changes from v1 is as follows:
- Addressed Juergen's code review comment regarding the first patch.
- Amended the description of the second patch to note that the described
  issues are encountered with PV domains.

Verification notes:

- I have tested these commits on top of Linux v5.15.70 and v5.15.71, and
  I verified that they compile successfully on top of the tag
  "next-20220930", which corresponds to the base commit ID included at
  the bottom of this e-mail.

- My tests consist of using a kernel with Qubes OS v4.1's patches and
  these patches on my main computer for day-to-day tasks, in conjunction
  with Qubes OS's version of the Xen hypervisor v4.14.5, with the latter
  custom-compiled with CONFIG_DEBUG.

- I used a test program that verifies the following scenarios with an
  unprivileged paravirtualized (PV) Xen domain:

  - A program mmap()s two pages from another Xen domain and munmap()s
    the pages one by one. This used to result in implicit unmap errors
    to be reported by Xen and a general protection fault to be triggered
    by Xen in the affected domain, but now works as expected.
  - A program mmap()s two pages from another Xen domain and then
    attempts to remap (via MAP_FIXED) the same mapping again over the
    same virtual address. This used to result in similar issues
    (implicit unmap errors and general protection fault), but now is
    rejected by the kernel.
  - A program mmap()s two pages from another Xen domain and then
    attempts to mmap() the same mapping again to a different virtual
    address, by passing NULL as mmap()'s first argument. This used to be
    rejected by the kernel, and it continues to be rejected by the
    kernel.

- Unprivileged PVH Xen domains were also sanity tested with the same
  test program. I should note that PVH domains worked as expected
  without these patches too.

- Finally, I have verified that the original "g.e. 0x1234 still pending"
  issue does not appear after rapidly resizing GUI windows in Qubes OS
  v4.1.

Thank you,

Vefa

M. Vefa Bicakci (2):
  xen/gntdev: Prevent leaking grants
  xen/gntdev: Accommodate VMA splitting

 drivers/xen/gntdev-common.h |  3 +-
 drivers/xen/gntdev.c        | 80 +++++++++++++++++++------------------
 2 files changed, 44 insertions(+), 39 deletions(-)


base-commit: 274d7803837da78dfc911bcda0d593412676fc20
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 22:20:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 22:20:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414715.659093 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7KH-0006FU-4J; Sun, 02 Oct 2022 22:20:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414715.659093; Sun, 02 Oct 2022 22:20:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7KH-0006FN-1c; Sun, 02 Oct 2022 22:20:45 +0000
Received: by outflank-mailman (input) for mailman id 414715;
 Sun, 02 Oct 2022 22:20:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=STlk=2D=runbox.com=m.v.b@srs-se1.protection.inumbo.net>)
 id 1of7KF-0005uq-JF
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 22:20:43 +0000
Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com
 [2a0c:5a00:149::26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73698cfa-42a0-11ed-9375-c1cf23e5d27e;
 Mon, 03 Oct 2022 00:20:41 +0200 (CEST)
Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com)
 by mailtransmit05.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <m.v.b@runbox.com>)
 id 1of7KD-009uU3-JR; Mon, 03 Oct 2022 00:20:41 +0200
Received: from [10.9.9.74] (helo=submission03.runbox)
 by mailtransmit02.runbox with esmtp (Exim 4.86_2)
 (envelope-from <m.v.b@runbox.com>)
 id 1of7K7-0006iK-RD; Mon, 03 Oct 2022 00:20:35 +0200
Received: by submission03.runbox with esmtpsa [Authenticated ID (536975)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1of7Jy-00061b-Dp; Mon, 03 Oct 2022 00:20:26 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73698cfa-42a0-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com;
	 s=selector2; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To
	:Message-Id:Date:Subject:Cc:To:From;
	bh=+Vie5gCZlh7QnEM5LNxxIlolyHehCAwhUeGnQuCZCG0=; b=EZXHAHDS8IVNmG694ijMXgA1Pt
	1z/7+aVAN/itRJpFoSIC1u6kfGApGr8EWO7gKXvlilauTHt8gJvXSoVojZorlGNOLBmmTYB6BR/tW
	bDOFIOzeONac7Aat1QAEb6uflXvMkZs2qsGHdQsheYhXgcLlnm9jsMvQ0n6RKZq3RZ7RlGeDr+n3I
	ldeKPtVtebOfP/clRJBtegyCYcJ0hS+mSHfHcaVYxhKFppc5JjN2B4uT3UkPqnaQJw/1ELMlotkdm
	F+PEI/rQqnLpIwla60ZblaUxAlUf0uBBW3eG8SeYyeS4/4A+AAIdcPGdBuogG28RH46gSbE8mXdX2
	+PTE01qA==;
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: m.v.b@runbox.com,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
Date: Sun,  2 Oct 2022 18:20:05 -0400
Message-Id: <20221002222006.2077-2-m.v.b@runbox.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221002222006.2077-1-m.v.b@runbox.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Prior to this commit, if a grant mapping operation failed partially,
some of the entries in the map_ops array would be invalid, whereas all
of the entries in the kmap_ops array would be valid. This in turn would
cause the following logic in gntdev_map_grant_pages to become invalid:

  for (i = 0; i < map->count; i++) {
    if (map->map_ops[i].status == GNTST_okay) {
      map->unmap_ops[i].handle = map->map_ops[i].handle;
      if (!use_ptemod)
        alloced++;
    }
    if (use_ptemod) {
      if (map->kmap_ops[i].status == GNTST_okay) {
        if (map->map_ops[i].status == GNTST_okay)
          alloced++;
        map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
      }
    }
  }
  ...
  atomic_add(alloced, &map->live_grants);

Assume that use_ptemod is true (i.e., the domain mapping the granted
pages is a paravirtualized domain). In the code excerpt above, note that
the "alloced" variable is only incremented when both kmap_ops[i].status
and map_ops[i].status are set to GNTST_okay (i.e., both mapping
operations are successful).  However, as also noted above, there are
cases where a grant mapping operation fails partially, breaking the
assumption of the code excerpt above.

The aforementioned causes map->live_grants to be incorrectly set. In
some cases, all of the map_ops mappings fail, but all of the kmap_ops
mappings succeed, meaning that live_grants may remain zero. This in turn
makes it impossible to unmap the successfully grant-mapped pages pointed
to by kmap_ops, because unmap_grant_pages has the following snippet of
code at its beginning:

  if (atomic_read(&map->live_grants) == 0)
    return; /* Nothing to do */

In other cases where only some of the map_ops mappings fail but all
kmap_ops mappings succeed, live_grants is made positive, but when the
user requests unmapping the grant-mapped pages, __unmap_grant_pages_done
will then make map->live_grants negative, because the latter function
does not check if all of the pages that were requested to be unmapped
were actually unmapped, and the same function unconditionally subtracts
"data->count" (i.e., a value that can be greater than map->live_grants)
from map->live_grants. The side effects of a negative live_grants value
have not been studied.

The net effect of all of this is that grant references are leaked in one
of the above conditions. In Qubes OS v4.1 (which uses Xen's grant
mechanism extensively for X11 GUI isolation), this issue manifests
itself with warning messages like the following to be printed out by the
Linux kernel in the VM that had granted pages (that contain X11 GUI
window data) to dom0: "g.e. 0x1234 still pending", especially after the
user rapidly resizes GUI VM windows (causing some grant-mapping
operations to partially or completely fail, due to the fact that the VM
unshares some of the pages as part of the window resizing, making the
pages impossible to grant-map from dom0).

The fix for this issue involves counting all successful map_ops and
kmap_ops mappings separately, and then adding the sum to live_grants.
During unmapping, only the number of successfully unmapped grants is
subtracted from live_grants. The code is also modified to check for
negative live_grants values after the subtraction and warn the user.

Link: https://github.com/QubesOS/qubes-issues/issues/7631
Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")
Cc: stable@vger.kernel.org
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
---

Changes since v1:
- To determine which unmap operations were successful, the previous
  version of this patch set the "unmap_ops[i].status" and
  "kunmap_ops[i].status" fields to the value "1" prior to passing these
  data structures to the hypervisor. Instead of doing that, the code now
  checks whether the "handle" fields in the same data structures were
  *not* set to "INVALID_GRANT_HANDLE". (Suggested by Juergen Gross.)
---
 drivers/xen/gntdev.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 84b143eef395..eb0586b9767d 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
 	for (i = 0; i < map->count; i++) {
 		if (map->map_ops[i].status == GNTST_okay) {
 			map->unmap_ops[i].handle = map->map_ops[i].handle;
-			if (!use_ptemod)
-				alloced++;
+			alloced++;
 		} else if (!err)
 			err = -EINVAL;
 
@@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
 
 		if (use_ptemod) {
 			if (map->kmap_ops[i].status == GNTST_okay) {
-				if (map->map_ops[i].status == GNTST_okay)
-					alloced++;
+				alloced++;
 				map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
 			} else if (!err)
 				err = -EINVAL;
@@ -394,8 +392,14 @@ static void __unmap_grant_pages_done(int result,
 	unsigned int i;
 	struct gntdev_grant_map *map = data->data;
 	unsigned int offset = data->unmap_ops - map->unmap_ops;
+	int successful_unmaps = 0;
+	int live_grants;
 
 	for (i = 0; i < data->count; i++) {
+		if (map->unmap_ops[offset + i].status == GNTST_okay &&
+		    map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE)
+			successful_unmaps++;
+
 		WARN_ON(map->unmap_ops[offset + i].status != GNTST_okay &&
 			map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE);
 		pr_debug("unmap handle=%d st=%d\n",
@@ -403,6 +407,10 @@ static void __unmap_grant_pages_done(int result,
 			map->unmap_ops[offset+i].status);
 		map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
 		if (use_ptemod) {
+			if (map->kunmap_ops[offset + i].status == GNTST_okay &&
+			    map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE)
+				successful_unmaps++;
+
 			WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay &&
 				map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE);
 			pr_debug("kunmap handle=%u st=%d\n",
@@ -411,11 +419,15 @@ static void __unmap_grant_pages_done(int result,
 			map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
 		}
 	}
+
 	/*
 	 * Decrease the live-grant counter.  This must happen after the loop to
 	 * prevent premature reuse of the grants by gnttab_mmap().
 	 */
-	atomic_sub(data->count, &map->live_grants);
+	live_grants = atomic_sub_return(successful_unmaps, &map->live_grants);
+	if (WARN_ON(live_grants < 0))
+		pr_err("%s: live_grants became negative (%d) after unmapping %d pages!\n",
+		       __func__, live_grants, successful_unmaps);
 
 	/* Release reference taken by __unmap_grant_pages */
 	gntdev_put_map(NULL, map);
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Sun Oct 02 23:00:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 23:00:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414729.659104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7wx-0002e8-81; Sun, 02 Oct 2022 23:00:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414729.659104; Sun, 02 Oct 2022 23:00:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7wx-0002e1-4G; Sun, 02 Oct 2022 23:00:43 +0000
Received: by outflank-mailman (input) for mailman id 414729;
 Sun, 02 Oct 2022 23:00:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9ZZD=2D=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1of7wv-0002dv-KV
 for xen-devel@lists.xenproject.org; Sun, 02 Oct 2022 23:00:42 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06c8d52d-42a6-11ed-9375-c1cf23e5d27e;
 Mon, 03 Oct 2022 01:00:38 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 21E2F5C00C0;
 Sun,  2 Oct 2022 19:00:36 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Sun, 02 Oct 2022 19:00:36 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 2 Oct 2022 19:00:34 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06c8d52d-42a6-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664751636; x=
	1664838036; bh=cNciw2J5Orp3JpPbWkHqpqGm5hUpKrl4SmiJ2KcbhH8=; b=S
	tzowsnM8VUFP9jNA1d27nHp5QlrEviDhtKSxdP/MY6TEgnK0eo1T3cRCa3uUbiAp
	LZ1O6BUmN6C4ekbVXueBFi6AjnkRFhPvxXrdAB9XaW2Y5sCtlvebHdGNns4UaR87
	98i/+z6WvyBzUwjWQ8cil7CiyKb9ABrWpndfHtk6gFmyXjImddoCbmQluTyubJtX
	5lZfLA+UApxRN8NOH/cm/exfR8iZXVCoaqXRqFpY8Ekc+VHymtgrMUeXUEVjMTrJ
	fmae98hbjLeiiKG+5gHMs2zyrOPnyKSbHI3qLiaYubRW/XP9V89QkOeQ+GcMndnA
	8I7SUTC4bB3I1Npn0SqKw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664751636; x=1664838036; bh=cNciw2J5Orp3JpPbWkHqpqGm5hUp
	Krl4SmiJ2KcbhH8=; b=JdGnrZ+iLYBG6LzPmDP3jOJv64VEFip/hOipznNdeiUc
	o1Jr+pN3OQR4ysJrt2y98O1kCDwbH7NCH+qQId8kJmKy0WUQZzgdPfo+5i7yx3+m
	kq/eYIepJPiaJQzchG26RMIvQY1WVVi9GESPCCE1DKavHdkQlDR0BTYS86PHCB0C
	xh+YJkgcnZMojUFJrB1zILldqNaLCXJX3TSrc1teEdcmxScZSYt1LTDUoq5x8VtV
	4UuifB4kj8CM9fWzuiOuINWARyICq0ohDm24kAvjeUUkkAjBTykAUoWeY/Sj0b4a
	qU+DfPJYWI8cPljqU3+FJHy5jm5uX9m4heWubMYhmQ==
X-ME-Sender: <xms:Exg6YyCbz9sByCIIQljqFgkNCPeuxQmDhsaMWa6wGicvjRytAzNjZg>
    <xme:Exg6Y8joOSZ5zzpJGsrYmbE6OgKkU77YXGXHirguXPjzIU9wxSsmPRMFtyRzZUj1-
    deQU6-SJF0l2wo>
X-ME-Received: <xmr:Exg6Y1kljE3_n27GmgMEjkJYhFGOwjkmF3RSb1z7zqcsL3TIETazcUH2zPpV>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehkedgudekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff
    gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:Exg6YwxJKc-wmkmNwhLsxE2oIxI-nZaKtEDu19BrP2dB9JI0x_1L0g>
    <xmx:Exg6Y3SmiEcbMdqzdD3-2SdgO6W8Mq9hrs_m05kn1-FZ1jHUyqJsmw>
    <xmx:Exg6Y7azkcapAbTvHYgcytdLYYZuTmVS2fr3YExZybs-YQTgV-CF1w>
    <xmx:FBg6Y8_EkqLgAuteYDAfltj7vRVWKG2Qo7Dcaz-QTb_s47gjjlIv6w>
Feedback-ID: iac594737:Fastmail
Date: Sun, 2 Oct 2022 19:00:01 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [RFC PATCH 4/5] efi: Apply allowlist to EFI configuration tables
 when running under Xen
Message-ID: <YzoYEewoSoj1a2Ss@itl-email>
References: <20221002095626.484279-1-ardb@kernel.org>
 <20221002095626.484279-5-ardb@kernel.org>
 <Yzm8H3iS7ziWsh7E@itl-email>
 <CAMj1kXFWS0kXp7f75x=BDYDyTHKNzMCTZ_bXg7v23Aw=pJtSzQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PghubVJsF+8O07oQ"
Content-Disposition: inline
In-Reply-To: <CAMj1kXFWS0kXp7f75x=BDYDyTHKNzMCTZ_bXg7v23Aw=pJtSzQ@mail.gmail.com>


--PghubVJsF+8O07oQ
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sun, 2 Oct 2022 19:00:01 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [RFC PATCH 4/5] efi: Apply allowlist to EFI configuration tables
 when running under Xen

On Sun, Oct 02, 2022 at 11:22:58PM +0200, Ard Biesheuvel wrote:
> On Sun, 2 Oct 2022 at 18:28, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Sun, Oct 02, 2022 at 11:56:25AM +0200, Ard Biesheuvel wrote:
> > > As it turns out, Xen does not guarantee that EFI bootservices data
> > > regions in memory are preserved, which means that EFI configuration
> > > tables pointing into such memory regions may be corrupted before the
> > > dom0 OS has had a chance to inspect them.
> > >
> > > Demi Marie reports that this is causing problems for Qubes OS when it
> > > attempts to perform system firmware updates, which requires that the
> > > contents of the ESRT configuration table are valid when the fwupd user
> > > space program runs.
> > >
> > > However, other configuration tables such as the memory attributes
> > > table or the runtime properties table are equally affected, and so we
> > > need a comprehensive workaround that works for any table type.
> > >
> > > So let's first disregard all EFI configuration tables except the ones
> > > that are known (or can be expected) to reside in memory regions of a
> > > type that Xen preserves, i.e., ACPI tables (which are passed in
> > > EfiAcpiReclaimMemory regions) and SMBIOS tables (which are usually
> > > passed in EfiRuntimeServicesData regions, even though the UEFI spec o=
nly
> > > mentions this as a recommendation). Then, cross reference unknown tab=
les
> > > against either the EFI memory map (if available) or do a Xen hypercall
> > > to determine the memory type, and allow the config table if the type =
is
> > > one that is guaranteed to be preserved.
> > >
> > > Future patches can augment the logic in this routine to allow other
> > > table types based on the size of the allocation, or based on a table
> > > specific header size field.
> > >
> > > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > ---
> > >  drivers/firmware/efi/efi.c |  7 ++
> > >  drivers/xen/efi.c          | 69 ++++++++++++++++++++
> > >  include/linux/efi.h        |  2 +
> > >  3 files changed, 78 insertions(+)
> > >
> > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > > index 11857af72859..e8c0747011d7 100644
> > > --- a/drivers/firmware/efi/efi.c
> > > +++ b/drivers/firmware/efi/efi.c
> > > @@ -556,6 +556,13 @@ static __init int match_config_table(const efi_g=
uid_t *guid,
> > >
> > >       for (i =3D 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++)=
 {
> > >               if (!efi_guidcmp(*guid, table_types[i].guid)) {
> > > +                     if (IS_ENABLED(CONFIG_XEN_EFI) &&
> > > +                         !xen_efi_config_table_is_usable(guid, table=
)) {
> > > +                             if (table_types[i].name[0])
> > > +                                     pr_cont("(%s=3D0x%lx) ",
> > > +                                             table_types[i].name, ta=
ble);
> > > +                             return 1;
> > > +                     }
> > >                       *(table_types[i].ptr) =3D table;
> > >                       if (table_types[i].name[0])
> > >                               pr_cont("%s=3D0x%lx ",
> > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > > index d1ff2186ebb4..3f1f365b37d0 100644
> > > --- a/drivers/xen/efi.c
> > > +++ b/drivers/xen/efi.c
> > > @@ -292,3 +292,72 @@ void __init xen_efi_runtime_setup(void)
> > >       efi.get_next_high_mono_count    =3D xen_efi_get_next_high_mono_=
count;
> > >       efi.reset_system                =3D xen_efi_reset_system;
> > >  }
> > > +
> > > +static const efi_guid_t cfg_table_allow_list[] __initconst =3D {
> > > +     ACPI_20_TABLE_GUID,
> > > +     ACPI_TABLE_GUID,
> > > +     SMBIOS_TABLE_GUID,
> > > +     SMBIOS3_TABLE_GUID,
> > > +};
> >
> > This allowlist seems redundant.  Either the tables are already in memory
> > that Xen will preserve or they aren=E2=80=99t.  In both cases the subse=
quent
> > code will do the right thing.
>=20
> Will it? Currently, Xen simply accepts all ACPI and SMBIOS tables,
> regardless of what type of memory region they reside in (if any).
>=20
> So what will happen with buggy firmware where the ACPI or SMBIOS
> tables are not covered by the memory map at all? Currently, this works
> fine but now, it will be rejected. And without ACPI tables, the boot
> will not get far enough to even inform the user what is wrong. And
> SMBIOS tables are used for platform quirks, which means they might be
> essential for a platform to boot as well.

If the tables are not in the memory map at all, I recommend
add_taint(TAINT_FIRMWARE_WORKAROUND) but otherwise continuing to boot.
If the tables are somewhere nonsensical, then the platform is FUBAR
anyway.  Linux alone might be able to work by reserving the memory, but
under Xen that does not work.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--PghubVJsF+8O07oQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM6GBAACgkQsoi1X/+c
IsEE/A/+Ks8HuxLZxVxAaS7z+iHz3lOARj1WpxeoJRhXMQkVNeKQBniOhBUgxeGg
D2njhATzF7PGa/c+JFDXMoNWxMk5XC2nmgSvOL6WIXezXIx/foZomlWTMkMkTECh
Vc9qvu5xaRuGIj43UxxOsawMfS9mWEpv6HM56mpN26erPsm9uDqPzbWZLMVSh/tp
bfH9ZmrLP8T+k+S+gqzyf4kUhpVEyMNw7lz30n7dqvq9Nzjg4cEZ95zzJimUdSMe
MQWNTRFN1/OGLiDSn5JiUhfKboqfDMdBuFpGKD6xeP8Z3vl9ACDpPPZgYosKfil8
LjzkV+2lThyeqwfVSv5v/PpIQs9ZJtzfhCunWEsUscWu0Ak76XIcUCnGDdOV7bAB
ywAUl+KsrhCZeV+zvQugxUC2z/byEBFM0DxnI/VUbyo1gkaSurukIo54SMIerigy
tXPgk+/hohb/2qW1kYie9EeL98hGLgLiy4hZZRoFl23iJLCJKdVp/rICCyxwgGTf
iCBxekyikbYplQ5zOmsHzsJqeW79GxrzevS5HRxedrFCSHIseVGSD/g1G9+AkqBg
kuK0uxl3VGg3jIIcOmyBOrMJXYSmj6CXmPFVA1Uo0ZEyiu6aNtWFJJ85KtAKRczH
zAguzKPKMR5qR1/hcv4OKPFVIwBYdDbuATZfIf5D7WGIm/cx4sg=
=vFGe
-----END PGP SIGNATURE-----

--PghubVJsF+8O07oQ--


From xen-devel-bounces@lists.xenproject.org Sun Oct 02 23:02:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 02 Oct 2022 23:02:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414737.659114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7yK-0003GG-Kb; Sun, 02 Oct 2022 23:02:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414737.659114; Sun, 02 Oct 2022 23:02:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of7yK-0003G9-Hw; Sun, 02 Oct 2022 23:02:08 +0000
Received: by outflank-mailman (input) for mailman id 414737;
 Sun, 02 Oct 2022 23:02:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1of7yI-0003Fx-Rr; Sun, 02 Oct 2022 23:02:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1of7yI-0002nY-P6; Sun, 02 Oct 2022 23:02:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1of7yH-00074A-9u; Sun, 02 Oct 2022 23:02:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1of7yH-000688-9P; Sun, 02 Oct 2022 23:02:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=obJyIbo9wT+1f8zwczdD6GVxC25YiG0BM2Xh4etvZIM=; b=SQvxkDmK5gQ44dt71qNPSvJr8q
	AdfCoAVvkVBwv/neG7pWk/ZU49ptv9RGI3ECXg4ttLPIRVQCWIMJaKQRBpqseirgLBVKlLpSawRYH
	R6Jf2C32kGD/uTwDUiAyqN+AxdfvwboZy2e0IrV6Zb5VYm2RrOy2DhgZaUpGEKKD6pSU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173400-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173400: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a962b54e162c2977ff37905726cab29728380835
X-Osstest-Versions-That:
    linux=b357fd1c2afc1a3e1b73dc4574bb7ac0e3bd4193
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 02 Oct 2022 23:02:05 +0000

flight 173400 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173400/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173397

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173397
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173397
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173397
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173397
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173397
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173397
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173397
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173397
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                a962b54e162c2977ff37905726cab29728380835
baseline version:
 linux                b357fd1c2afc1a3e1b73dc4574bb7ac0e3bd4193

Last test of basis   173397  2022-10-01 18:13:19 Z    1 days
Testing same since   173400  2022-10-02 17:41:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Borislav Petkov <bp@suse.de>
  Kan Liang <kan.liang@linux.intel.com>
  Like Xu <likexu@tencent.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marek Vasut <marex@denx.de>
  Nadav Amit <namit@vmware.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Rob Herring <robh@kernel.org>
  Wolfram Sang <wsa@kernel.org>
  Yang Jihong <yangjihong1@huawei.com>
  Zhang Qilong <zhangqilong3@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b357fd1c2afc..a962b54e162c  a962b54e162c2977ff37905726cab29728380835 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 00:30:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 00:30:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414746.659126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of9Lc-00045i-1E; Mon, 03 Oct 2022 00:30:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414746.659126; Mon, 03 Oct 2022 00:30:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1of9Lb-00045b-Td; Mon, 03 Oct 2022 00:30:15 +0000
Received: by outflank-mailman (input) for mailman id 414746;
 Mon, 03 Oct 2022 00:30:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TmDc=2E=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1of9Lb-00045V-1b
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 00:30:15 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89874fae-42b2-11ed-9375-c1cf23e5d27e;
 Mon, 03 Oct 2022 02:30:11 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 6BE0F5C008F;
 Sun,  2 Oct 2022 20:30:09 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sun, 02 Oct 2022 20:30:09 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 2 Oct 2022 20:30:08 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89874fae-42b2-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664757009; x=
	1664843409; bh=Z/3fPXqHkxLvccFTzKhxM1kh18KV+Cenh/41gK+IhpI=; b=Z
	D8Bzycy09HpE3xYgQHiXzBpdfoAkfCDQ+wi+zjfd0qMnmRVlePBdgEs4juDyk6r/
	8+HiA7UyK+5Qn+AiASg1h/j6BKiI7y7d4NErZun+JzIpZ48v1Xkuu7x2tj1oorUy
	BS0Dv8rGDGVw2vLg4g8ce3ARBVPKMUxu96jv/9PsfqWIr9nI4nzXRMCw1jcSoevH
	66APp/CqX69/mYVCqd6r/kHWruklj1I+lv0nv1ta2eNdOvnhJlLLabJhNI4bRCWc
	2FIYFeI7jVTNWZ/nDu5UrAuaildnmWAdEZhnVKFTho4Nf7Yhv4h0SS8M7Ab4RSv7
	GCgDfhaaqaXQgMa09b0qA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664757009; x=1664843409; bh=Z/3fPXqHkxLvccFTzKhxM1kh18KV
	+Cenh/41gK+IhpI=; b=ofS7b3luTnNUN4AtFqv/WuMerBjFOSn+5LV07RbucO6N
	9jTuICkd4uI2L0rNzIFnZCU0Z/gt4nFhwAuSpY98bxrNNBNBuzN0cDM0oD6gtEKz
	58cXj2dXqdE0oTXIOfKGaFPlk4A46ub8AZ6eg7bFlrE8ou39K4xMf4pTjpEu9aVQ
	WOG0uXRtNLOqBXNJYx2hTbkeC3AOQj9Vm5Yruz/iVFHb/tYHKcStJK8JupVx7slI
	X3XbmIQpvYMAmIEAfB986AAPuSUi8bEhtG1I4ygvTMK49Op4tjdr99GGBD0aoM6b
	WO4Xd62Wc4tiwmEf1YWOApQjjvTZm8/8O/MBFtn15g==
X-ME-Sender: <xms:EC06Yz4DAcCHX55brUwmYYxlVKAjvCYmb9QdzflE-DNplnRtkgS59g>
    <xme:EC06Y44xdrLfndOTyPAF316HMAka63DvQqdiFODrLcutDJXm7vwFVvDVG4vExvBTq
    EXMOIoEKXFtuEM>
X-ME-Received: <xmr:EC06Y6cFIfelQNBkcDfDzAQjV73Ohrv7IuDMQLZSJqL9R14NLGbvya0QQmQi>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehkedgfeejucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeuvdekffffieduhedtkeevkedu
    fedvkeeiheffvdegueetteehgfefieetudfgnecuffhomhgrihhnpehgihhthhhusgdrtg
    homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu
    vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:ES06Y0Le-jDevxbMM0UpqOpoSFAaSQP-MS4wzoT-6j1tGSY9Igri5A>
    <xmx:ES06Y3Kym5tvLCZEPgu0jxXjA_bZBk-7XQH2gGsd2DEu46ob--Y5kQ>
    <xmx:ES06Y9wCnAFFko8ap7rfovubX3hkPhVm8y6_8JV2PDMT-93iXZaujQ>
    <xmx:ES06Y0E0dL4Ka8lmAbd3h8fuMD5pYvjo09ggeEy6oHhz7W4LO4m3Pw>
Feedback-ID: iac594737:Fastmail
Date: Sun, 2 Oct 2022 20:29:59 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
Message-ID: <YzotDube4gTn7r9b@itl-email>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-2-m.v.b@runbox.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="g3VIftLCTfH9xeQV"
Content-Disposition: inline
In-Reply-To: <20221002222006.2077-2-m.v.b@runbox.com>


--g3VIftLCTfH9xeQV
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sun, 2 Oct 2022 20:29:59 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants

On Sun, Oct 02, 2022 at 06:20:05PM -0400, M. Vefa Bicakci wrote:
> Prior to this commit, if a grant mapping operation failed partially,
> some of the entries in the map_ops array would be invalid, whereas all
> of the entries in the kmap_ops array would be valid. This in turn would
> cause the following logic in gntdev_map_grant_pages to become invalid:
>=20
>   for (i =3D 0; i < map->count; i++) {
>     if (map->map_ops[i].status =3D=3D GNTST_okay) {
>       map->unmap_ops[i].handle =3D map->map_ops[i].handle;
>       if (!use_ptemod)
>         alloced++;
>     }
>     if (use_ptemod) {
>       if (map->kmap_ops[i].status =3D=3D GNTST_okay) {
>         if (map->map_ops[i].status =3D=3D GNTST_okay)
>           alloced++;
>         map->kunmap_ops[i].handle =3D map->kmap_ops[i].handle;
>       }
>     }
>   }
>   ...
>   atomic_add(alloced, &map->live_grants);
>=20
> Assume that use_ptemod is true (i.e., the domain mapping the granted
> pages is a paravirtualized domain). In the code excerpt above, note that
> the "alloced" variable is only incremented when both kmap_ops[i].status
> and map_ops[i].status are set to GNTST_okay (i.e., both mapping
> operations are successful).  However, as also noted above, there are
> cases where a grant mapping operation fails partially, breaking the
> assumption of the code excerpt above.
>=20
> The aforementioned causes map->live_grants to be incorrectly set. In
> some cases, all of the map_ops mappings fail, but all of the kmap_ops
> mappings succeed, meaning that live_grants may remain zero. This in turn
> makes it impossible to unmap the successfully grant-mapped pages pointed
> to by kmap_ops, because unmap_grant_pages has the following snippet of
> code at its beginning:
>=20
>   if (atomic_read(&map->live_grants) =3D=3D 0)
>     return; /* Nothing to do */
>=20
> In other cases where only some of the map_ops mappings fail but all
> kmap_ops mappings succeed, live_grants is made positive, but when the
> user requests unmapping the grant-mapped pages, __unmap_grant_pages_done
> will then make map->live_grants negative, because the latter function
> does not check if all of the pages that were requested to be unmapped
> were actually unmapped, and the same function unconditionally subtracts
> "data->count" (i.e., a value that can be greater than map->live_grants)
> from map->live_grants. The side effects of a negative live_grants value
> have not been studied.
>=20
> The net effect of all of this is that grant references are leaked in one
> of the above conditions. In Qubes OS v4.1 (which uses Xen's grant
> mechanism extensively for X11 GUI isolation), this issue manifests
> itself with warning messages like the following to be printed out by the
> Linux kernel in the VM that had granted pages (that contain X11 GUI
> window data) to dom0: "g.e. 0x1234 still pending", especially after the
> user rapidly resizes GUI VM windows (causing some grant-mapping
> operations to partially or completely fail, due to the fact that the VM
> unshares some of the pages as part of the window resizing, making the
> pages impossible to grant-map from dom0).
>=20
> The fix for this issue involves counting all successful map_ops and
> kmap_ops mappings separately, and then adding the sum to live_grants.
> During unmapping, only the number of successfully unmapped grants is
> subtracted from live_grants. The code is also modified to check for
> negative live_grants values after the subtraction and warn the user.
>=20
> Link: https://github.com/QubesOS/qubes-issues/issues/7631
> Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")

Looks like this patch has been pretty buggy, sorry.  This is the second
time there has been a problem with it.  Thanks for the fix.

> Cc: stable@vger.kernel.org
> Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
> ---
>=20
> Changes since v1:
> - To determine which unmap operations were successful, the previous
>   version of this patch set the "unmap_ops[i].status" and
>   "kunmap_ops[i].status" fields to the value "1" prior to passing these
>   data structures to the hypervisor. Instead of doing that, the code now
>   checks whether the "handle" fields in the same data structures were
>   *not* set to "INVALID_GRANT_HANDLE". (Suggested by Juergen Gross.)
> ---
>  drivers/xen/gntdev.c | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 84b143eef395..eb0586b9767d 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *m=
ap)
>  	for (i =3D 0; i < map->count; i++) {
>  		if (map->map_ops[i].status =3D=3D GNTST_okay) {
>  			map->unmap_ops[i].handle =3D map->map_ops[i].handle;
> -			if (!use_ptemod)
> -				alloced++;
> +			alloced++;
>  		} else if (!err)
>  			err =3D -EINVAL;
> =20
> @@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *m=
ap)
> =20
>  		if (use_ptemod) {
>  			if (map->kmap_ops[i].status =3D=3D GNTST_okay) {
> -				if (map->map_ops[i].status =3D=3D GNTST_okay)
> -					alloced++;
> +				alloced++;
>  				map->kunmap_ops[i].handle =3D map->kmap_ops[i].handle;
>  			} else if (!err)
>  				err =3D -EINVAL;
> @@ -394,8 +392,14 @@ static void __unmap_grant_pages_done(int result,
>  	unsigned int i;
>  	struct gntdev_grant_map *map =3D data->data;
>  	unsigned int offset =3D data->unmap_ops - map->unmap_ops;
> +	int successful_unmaps =3D 0;
> +	int live_grants;
> =20
>  	for (i =3D 0; i < data->count; i++) {
> +		if (map->unmap_ops[offset + i].status =3D=3D GNTST_okay &&
> +		    map->unmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE)
> +			successful_unmaps++;
> +
>  		WARN_ON(map->unmap_ops[offset + i].status !=3D GNTST_okay &&
>  			map->unmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE);
>  		pr_debug("unmap handle=3D%d st=3D%d\n",
> @@ -403,6 +407,10 @@ static void __unmap_grant_pages_done(int result,
>  			map->unmap_ops[offset+i].status);
>  		map->unmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE;
>  		if (use_ptemod) {
> +			if (map->kunmap_ops[offset + i].status =3D=3D GNTST_okay &&
> +			    map->kunmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE)
> +				successful_unmaps++;
> +
>  			WARN_ON(map->kunmap_ops[offset + i].status !=3D GNTST_okay &&
>  				map->kunmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE);
>  			pr_debug("kunmap handle=3D%u st=3D%d\n",
> @@ -411,11 +419,15 @@ static void __unmap_grant_pages_done(int result,
>  			map->kunmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE;
>  		}
>  	}
> +
>  	/*
>  	 * Decrease the live-grant counter.  This must happen after the loop to
>  	 * prevent premature reuse of the grants by gnttab_mmap().
>  	 */
> -	atomic_sub(data->count, &map->live_grants);
> +	live_grants =3D atomic_sub_return(successful_unmaps, &map->live_grants);
> +	if (WARN_ON(live_grants < 0))
> +		pr_err("%s: live_grants became negative (%d) after unmapping %d pages!=
\n",
> +		       __func__, live_grants, successful_unmaps);
> =20
>  	/* Release reference taken by __unmap_grant_pages */
>  	gntdev_put_map(NULL, map);
> --=20
> 2.37.3

Is there a possibility that live_grants could overflow, as it is now
set to a value twice as large as what it had been previously?

If not, you can add:

Acked-by: Demi Marie Obenour <demi@invisiblethingslab.com>
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--g3VIftLCTfH9xeQV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM6LQ8ACgkQsoi1X/+c
IsE/mxAAjAWZ3FBXk78lfnRfKqcGSGmPfM6Mztzu0e1i3Q1ckY25IIvfM8kKRc/y
LpUo2Ei39YXyJNitexDxjqd2+HfOYOI1Ln2mmiI8IpvjBSgTwOO5XAA8YoSstc8g
IQUXK+wukBYaO+AAmb0JPMhpfKGrDV0tvfyz4G2k7u11pcY8F218pAiSQHtoSrCg
3MCO0g7rZMCwM6CcWiHup5dujAzgUDgr0Zen1JWAicRjeXewHoSCDcPwdTHWExft
ETT/FcI67wjSL9QTiCliZDLBcuJ4/HMs6fNDv8SFB0xM29ebxN08aJFyHzqps/8A
ZOA5n5g6Ltnjda9f7k9Zfx+nLkn2aKaw4qc5YLMqt0XzdVPMZEGiOo8mZvnlMfHK
V/QczwqHXcX4bPw/gjftXFIdXQN7jWOfr2svI5Lp07jD5QVhHQD3/2Asgjh6U9/F
R1j1c6i34SuVothF9kHKtBRGW/L7wY5WrLBOx75uXSYB/aKVgewNA1aVo+098sRN
6/TtuYnwmSAJl3O0iIMYaXME6+CRU63b2XMj/1t1KE9N1nfcNPqqegABhIQbgn0q
kBz9a+DGhjb7xSwN56g4JUpQ2A48ij7/x7aQGkQqbkfUBQsyLZNGS5ALhEmEUaIZ
MOKGzzC8G5IgwyvXa/+mdloMIZkyWUYqQ/lECYAjv3BhTPxTIWQ=
=6a+L
-----END PGP SIGNATURE-----

--g3VIftLCTfH9xeQV--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 04:51:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 04:51:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414755.659137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofDPi-00069R-Jw; Mon, 03 Oct 2022 04:50:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414755.659137; Mon, 03 Oct 2022 04:50:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofDPi-00069J-Eo; Mon, 03 Oct 2022 04:50:46 +0000
Received: by outflank-mailman (input) for mailman id 414755;
 Mon, 03 Oct 2022 04:47:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F43x=2E=gmail.com=ksc2093@srs-se1.protection.inumbo.net>)
 id 1ofDMa-0005LV-5o
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 04:47:32 +0000
Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com
 [2607:f8b0:4864:20::92c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7ca5b4f9-42d6-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 06:47:30 +0200 (CEST)
Received: by mail-ua1-x92c.google.com with SMTP id h25so1188186uao.13
 for <xen-devel@lists.xenproject.org>; Sun, 02 Oct 2022 21:47:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ca5b4f9-42d6-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject
         :date;
        bh=0knQzcN1+igXN7erVVnZ8k1FnrHLXX3xSGYYoKdk4lw=;
        b=QJZXDQ4qwXjnkeb5YTraa2TGk22X357OOj4xVci3c1OPcsjLHGO8NNpb02qVdCneG3
         w65W7SUuH1XM5ppg6dYeROZS+avOk6QnHJmROSAaFlnzZUjaBtVJFPpduZ2OVRZnXzuB
         nyr4q/X7G3CDTC5UnzGr7kmBOxrFS1s20FNGPCCWPkAik5t+sjuVtJR9szH7h0+HjPgT
         Yn1OqNpRS0XRy37FdXLbgN1Ic613kKENZTYYi/gVmukyDsEA65Ro5IV6LPCsc847cVX0
         PAtFg7vnDzqkyZ12fG55rpwOWFS6YRisNOaIUuuoOFw811Ifa9LoOJ0rKV4A+C9y8GWY
         Yw1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state
         :from:to:cc:subject:date;
        bh=0knQzcN1+igXN7erVVnZ8k1FnrHLXX3xSGYYoKdk4lw=;
        b=fGCQKHy1YFsl7yqwcjGkTsgAOBq1dIivF/K9iHQww6qEOYPUKh39py+0F69TwvrsAa
         yBS2kguULJFOMybMBlsloeh4CqIcD5DZxtzn/84ncZptJ5hWx8OTDq0/IGNBqO0Zk9oA
         d3uiQyj3ynYEdjTaKL0k/5Xu7mfeKIK4ACvI28QSQ1kfk4rfYZgYws/A5ToCwsPdfiOC
         +uEXGqWMXV4QB1QZCKghsSNA/lqNBeOll+NZ/y0hulroWsLF6wKrwUWCEL8G4U5/SZ+J
         MMZQDk9SJ3+DsL9yae1GAzKLPITy2d4G+c6TH300gmBotkfP5dBPtwR97tUXPr+0lvBU
         PhSA==
X-Gm-Message-State: ACrzQf1NkisBRf6S6GBMp7vB6x4zQswgpcABxvi2PFcTrqBiWHAy9Xsd
	HckPtasJLHurYIk5kktFzuOcJTv7EFbXYfhenlacU1kRLPc=
X-Google-Smtp-Source: AMsMyM7+hIe7ovJPqPnODbSmknvFNzXJhAwbrJkk9W2mi3qEnkZc0THatsrBPn0IvubpAWx7swaLdBsB5+H+4TaDMBc=
X-Received: by 2002:ab0:5711:0:b0:3b5:13e0:23b4 with SMTP id
 s17-20020ab05711000000b003b513e023b4mr9117671uaa.101.1664772449269; Sun, 02
 Oct 2022 21:47:29 -0700 (PDT)
MIME-Version: 1.0
From: sarath chandu <ksc2093@gmail.com>
Date: Mon, 3 Oct 2022 10:17:18 +0530
Message-ID: <CAFWs62=ZPLF6RTQawKH=5ofEtBsXf-hmUq+TPEX=b2Uwj1P=0g@mail.gmail.com>
Subject: Re:Xen compatability and performance for imx8qm target with Andriod
 Auto as Guest Os
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, julien@xen.org
Content-Type: multipart/alternative; boundary="000000000000787bbf05ea1a0a87"

--000000000000787bbf05ea1a0a87
Content-Type: text/plain; charset="UTF-8"

*Hi Team,*
*I am trying to port xen hypervisor on i.MX8QM EVK. Planning to port
xen-image as DOM0,*
*Automotive Grade Linux as guest1 & Automotive Android as guest2.*
*Can you please guide me with the steps for porting android as a guest?*
*What are the drivers & packages that need to be included to achieve this?*
*Looking forward to hearing from you.*






*Regards,*

*Ksc.*

--000000000000787bbf05ea1a0a87
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><b>Hi Team,</b><br></div><div dir=3D"auto"><div style=
=3D"color:black;font-size:12pt;font-family:Calibri,Arial,Helvetica,sans-ser=
if"><div><b>I am trying to port xen hypervisor on i.MX8QM EVK. Planning to =
port xen-image as DOM0,</b></div>
<div><b>Automotive Grade Linux as guest1 &amp; Automotive Android as guest2=
.</b></div>
<div><b>Can you please guide me with the steps for porting android as a gue=
st?</b></div></div>
<div style=3D"color:black;font-size:12pt;font-family:Calibri,Arial,Helvetic=
a,sans-serif"><b>What are the drivers &amp; packages that need to be includ=
ed to achieve this?</b><br aria-hidden=3D"true">
</div>
<div style=3D"color:black;font-size:12pt;font-family:Calibri,Arial,Helvetic=
a,sans-serif"><b>Looking forward to hearing=C2=A0from=C2=A0you.</b></div><d=
iv style=3D"color:black;font-size:12pt;font-family:Calibri,Arial,Helvetica,=
sans-serif"><b><br></b></div><div style=3D"color:black;font-size:12pt;font-=
family:Calibri,Arial,Helvetica,sans-serif"><b><br></b></div><div style=3D"c=
olor:black;font-size:12pt;font-family:Calibri,Arial,Helvetica,sans-serif"><=
b><br></b></div><div style=3D"color:black;font-size:12pt;font-family:Calibr=
i,Arial,Helvetica,sans-serif"><b><br></b></div><div style=3D"color:black;fo=
nt-size:12pt;font-family:Calibri,Arial,Helvetica,sans-serif"><b><br></b></d=
iv><div style=3D"color:black;font-size:12pt;font-family:Calibri,Arial,Helve=
tica,sans-serif"><b><br></b></div><div style=3D"color:black;font-size:12pt;=
font-family:Calibri,Arial,Helvetica,sans-serif"><b>Regards,</b></div><div s=
tyle=3D"color:black;font-size:12pt;font-family:Calibri,Arial,Helvetica,sans=
-serif"><b>Ksc.<br></b></div><div style=3D"color:black;font-size:12pt;font-=
family:Calibri,Arial,Helvetica,sans-serif"><b><br></b></div><div style=3D"c=
olor:black;font-size:12pt;font-family:Calibri,Arial,Helvetica,sans-serif"><=
b><br></b></div><div dir=3D"auto"><br></div></div>
</div>

--000000000000787bbf05ea1a0a87--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 05:14:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 05:14:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414762.659148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofDmN-0000SR-CO; Mon, 03 Oct 2022 05:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414762.659148; Mon, 03 Oct 2022 05:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofDmN-0000SK-9P; Mon, 03 Oct 2022 05:14:11 +0000
Received: by outflank-mailman (input) for mailman id 414762;
 Mon, 03 Oct 2022 05:14:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofDmL-0000SA-Pa; Mon, 03 Oct 2022 05:14:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofDmL-00054x-M9; Mon, 03 Oct 2022 05:14:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofDmL-0006RR-2U; Mon, 03 Oct 2022 05:14:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofDmL-0004hj-24; Mon, 03 Oct 2022 05:14:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WeRoNGyFy6fCTrkLsHHzN2iTnZiDFoR/hpNoetpt9cg=; b=MEY/ML7QO2sMjk+g+UbtLESXFM
	e32cR0qBrMr8tnp+g8j+GWVZU2K3ungdk/AmLFT4bXPvDI46dojva/B56Q5/IJ4U3BiLDQIKqBri+
	Ei4R5zKXgvAOsrQ5bjFXPuEG+VNMWcAUfPJfh9BWrDT254duSVmRYF8uOqSmQWAVbJF4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173401-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173401: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-arndale:host-ping-check-xen:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4fe89d07dcc2804c8b562f6c7896a45643d34b2f
X-Osstest-Versions-That:
    linux=a962b54e162c2977ff37905726cab29728380835
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 03 Oct 2022 05:14:09 +0000

flight 173401 linux-linus real [real]
flight 173403 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173401/
http://logs.test-lab.xenproject.org/osstest/logs/173403/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-arndale  10 host-ping-check-xen fail pass in 173403-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173403 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173403 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173400
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173400
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173400
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173400
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173400
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173400
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173400
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173400
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                4fe89d07dcc2804c8b562f6c7896a45643d34b2f
baseline version:
 linux                a962b54e162c2977ff37905726cab29728380835

Last test of basis   173400  2022-10-02 17:41:30 Z    0 days
Testing same since   173401  2022-10-02 23:12:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a962b54e162c..4fe89d07dcc2  4fe89d07dcc2804c8b562f6c7896a45643d34b2f -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 07:47:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 07:47:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414773.659158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofGAh-0006Eu-Ax; Mon, 03 Oct 2022 07:47:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414773.659158; Mon, 03 Oct 2022 07:47:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofGAh-0006En-8F; Mon, 03 Oct 2022 07:47:27 +0000
Received: by outflank-mailman (input) for mailman id 414773;
 Mon, 03 Oct 2022 07:47:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dEQx=2E=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofGAg-0006Eh-1a
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 07:47:26 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e905b36-42ef-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 09:47:24 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 072E121985;
 Mon,  3 Oct 2022 07:47:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D123D1332F;
 Mon,  3 Oct 2022 07:47:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id pwNpMYuTOmOTTwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 03 Oct 2022 07:47:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e905b36-42ef-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664783244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uWX7RFJSJ1NYVsarb0IojJUfEmcfN7y8PFYpoIZ60HY=;
	b=OCz1qupSkkysk4MXEC3Gt2c6RM6roOFmCEsvGUQvEFKDc+MFjnwyvUiHDLYWCdYVVnamib
	ZP9lgwjcQYmEpgk6l/oI+Yof2AlfdrGZSffAdbNnfR+gLpGDzxB1F5d2wkn5vTBsS2A9GS
	vcjPAkFh2QvcQBsyfd7qhIunOpXkqL8=
Message-ID: <601e21a6-f42b-f972-1eb0-52d5f97804e5@suse.com>
Date: Mon, 3 Oct 2022 09:47:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging
 runqueues
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>, xen-devel@lists.xenproject.org
References: <20220919150927.30081-1-marmarek@invisiblethingslab.com>
 <a0f02ef8-d93e-6083-a0b7-c8dae8905ada@suse.com> <Yym+1k7YlkMpvvaU@mail-itl>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <Yym+1k7YlkMpvvaU@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------1taOcUNHkTpgYSIr9oBnQ9m0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------1taOcUNHkTpgYSIr9oBnQ9m0
Content-Type: multipart/mixed; boundary="------------KTB59QFqkZoIAaqa0vYRr5OF";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Jan Beulich <jbeulich@suse.com>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>, xen-devel@lists.xenproject.org
Message-ID: <601e21a6-f42b-f972-1eb0-52d5f97804e5@suse.com>
Subject: Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging
 runqueues
References: <20220919150927.30081-1-marmarek@invisiblethingslab.com>
 <a0f02ef8-d93e-6083-a0b7-c8dae8905ada@suse.com> <Yym+1k7YlkMpvvaU@mail-itl>
In-Reply-To: <Yym+1k7YlkMpvvaU@mail-itl>

--------------KTB59QFqkZoIAaqa0vYRr5OF
Content-Type: multipart/mixed; boundary="------------A9pEQZbTgTMNnAgOdKwPSNC4"

--------------A9pEQZbTgTMNnAgOdKwPSNC4
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDkuMjIgMTU6MjMsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gVHVlLCBTZXAgMjAsIDIwMjIgYXQgMTE6MDY6NTdBTSArMDIwMCwgSmFuIEJldWxp
Y2ggd3JvdGU6DQo+PiBPbiAxOS4wOS4yMDIyIDE3OjA5LCBNYXJlayBNYXJjenlrb3dza2kt
R8OzcmVja2kgd3JvdGU6DQo+Pj4gLS0tIGEveGVuL2NvbW1vbi9zY2hlZC9jcmVkaXQyLmMN
Cj4+PiArKysgYi94ZW4vY29tbW9uL3NjaGVkL2NyZWRpdDIuYw0KPj4+IEBAIC05OTYsOSAr
OTk2LDEzIEBAIGNwdV9hZGRfdG9fcnVucXVldWUoY29uc3Qgc3RydWN0IHNjaGVkdWxlciAq
b3BzLCB1bnNpZ25lZCBpbnQgY3B1KQ0KPj4+ICAgICAgICAgICAgICAgICoNCj4+PiAgICAg
ICAgICAgICAgICAqIE90aGVyd2lzZSwgbGV0J3MgdHJ5IHRvIG1ha2Ugc3VyZSB0aGF0IHNp
YmxpbmdzIHN0YXkgaW4gdGhlDQo+Pj4gICAgICAgICAgICAgICAgKiBzYW1lIHJ1bnF1ZXVl
LCBwcmV0dHkgbXVjaCB1bmRlciBhbnkgY2lucmN1bW5zdGFuY2VzLg0KPj4+ICsgICAgICAg
ICAgICAgKg0KPj4+ICsgICAgICAgICAgICAgKiBGdXJ0aGVybW9yZSwgdHJ5IHRvIHJlc3Bl
Y3QgY3JlZGl0Ml9ydW5xdWV1ZT1hbGwsIGFzIGxvbmcgYXMNCj4+PiArICAgICAgICAgICAg
ICogbWF4X2NwdXNfcnVucSBpc24ndCB2aW9sYXRlZC4NCj4+DQo+PiBUaGlzIGxhc3QgcGFy
dCBpcyBxdWVzdGlvbmFibGUsIHBhcnRseSBiZWNhdXNlIHRoZSBjb21tYW5kIGxpbmUgZG9j
IGlzDQo+PiBhbWJpZ3VvdXMgYXMgdG8gd2hpY2ggb2YgdGhlIHR3byBvcHRpb25zIGlzIGlu
dGVuZGVkIHRvICJ3aW4iLiBJIGd1ZXNzDQo+PiBvbmUgbmVlZHMgdG8ga25vdyB0aGUgb3Jp
Z2luYWwgaW50ZW50aW9ucyB0byByZXNvbHZlIHRoaXMuDQo+IA0KPiBSaWdodCwgSSd2ZSBj
aG9zZW4gdGhpcyBhcHByb2FjaCwgYmVjYXVzZSB5b3UgY2FuIHN0aWxsIGVtdWxhdGUgdGhl
DQo+IG90aGVyIGJ5IHNldHRpbmcgc3VmZmljaWVudGx5IGxhcmdlIG1heF9jcHVzX3J1bnEu
IEkgY2FuIGFkZCBkb2MNCj4gY2xhcmlmaWNhdGlvbiBpbiB2Mi4NCj4gDQoNCkkgdGhpbmsg
dGhpcyBpcyB0aGUgYmV0dGVyIGFwcHJvYWNoLCBhcyBpdCBhbGxvd3MgbW9yZSBmbGV4aWJp
bGl0eS4NCg0KVXBkYXRpbmcgdGhlIGRvYyB3b3VsZCBiZSBtYW5kYXRvcnksIHRob3VnaC4g
V2l0aCB0aGF0IGFkZGVkIHlvdSBjYW4NCmhhdmUgbXk6DQoNClJldmlld2VkLWJ5OiBKdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K
--------------A9pEQZbTgTMNnAgOdKwPSNC4
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------A9pEQZbTgTMNnAgOdKwPSNC4--

--------------KTB59QFqkZoIAaqa0vYRr5OF--

--------------1taOcUNHkTpgYSIr9oBnQ9m0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM6k4sFAwAAAAAACgkQsN6d1ii/Ey/t
/Qf+MyU67JKHXriyUxXEIFIm5fdlEwQ5/a9kPdDNy/4v5LFMzMb45ahYDaxtHMRL0CkTK6abFxEe
HSVgYgQVku7n7eqWs2Gq7SxrJEBi5DYgcwOdqp8k+N3qVfW9SCtFurWhlwcxuTBvB9BhFijR6B51
ixJ0Z13Ub9Uo718dSsBvd11pw8avy5ToP8G9txsN8Ikkyu+p+S0FUYUWQk9Lh0pQhWt24Z5cFVF1
5AgpmeuStDN2g5PhnmwCdOXCmuGExWFeC6Y0313mAwAOnPuzUdfPYdTJUU3ScWZweNLVTFOsRxNd
5ZaNcvXCmSVaTi47MYPmR9LrxyfhDOhB1K0NbCURZg==
=tAcQ
-----END PGP SIGNATURE-----

--------------1taOcUNHkTpgYSIr9oBnQ9m0--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 08:20:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 08:20:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414785.659170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofGgM-0002XG-Bq; Mon, 03 Oct 2022 08:20:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414785.659170; Mon, 03 Oct 2022 08:20:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofGgM-0002X9-7N; Mon, 03 Oct 2022 08:20:10 +0000
Received: by outflank-mailman (input) for mailman id 414785;
 Mon, 03 Oct 2022 08:20:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofGgK-0002Wz-Vr; Mon, 03 Oct 2022 08:20:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofGgK-0000Uq-RF; Mon, 03 Oct 2022 08:20:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofGgK-0006Tq-89; Mon, 03 Oct 2022 08:20:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofGgK-0006QL-7j; Mon, 03 Oct 2022 08:20:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=p/OwhJeWYq7F1QS2uEm84DWqey4egqBzBnAoz9DAZRc=; b=uUCk+Yc08AhoVAZ4v4TTWHpw6H
	dAyXJhY5/XfUxp2EcLBlxiMtPKE855EaV4WzQDc+1htjeLLudf0m9r4/FpdXsXnyhBHxS6hNdWwOw
	XkaiRCkwOtw28itTx0q2YMxpyQhleqCrRIoLzMWr11+VtBjC6GkSok+PPmn8CgXq0wXA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173402-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173402: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-xsm:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
X-Osstest-Versions-That:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 03 Oct 2022 08:20:08 +0000

flight 173402 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173402/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-shadow     7 xen-install                fail pass in 173398
 test-amd64-amd64-xl-xsm      20 guest-localmigrate/x10     fail pass in 173398

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173398
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173398
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173398
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173398
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173398
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173398
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173398
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173398
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173398
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173398
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173398
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173398
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124
baseline version:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124

Last test of basis   173402  2022-10-03 01:53:43 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 08:41:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 08:41:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414794.659180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofH1C-0004wR-VV; Mon, 03 Oct 2022 08:41:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414794.659180; Mon, 03 Oct 2022 08:41:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofH1C-0004wK-Sx; Mon, 03 Oct 2022 08:41:42 +0000
Received: by outflank-mailman (input) for mailman id 414794;
 Mon, 03 Oct 2022 08:41:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofH1C-0004wE-7N
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 08:41:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32e5a69b-42f7-11ed-9375-c1cf23e5d27e;
 Mon, 03 Oct 2022 10:41:40 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CE3B3B80E6B
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 08:41:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 813A0C4347C
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 08:41:37 +0000 (UTC)
Received: by mail-lj1-f181.google.com with SMTP id s17so654530ljs.12
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 01:41:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32e5a69b-42f7-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664786497;
	bh=v2U6BZJDvr14oOCX6NYP8Ep8ieHeh6yTLas8+pjXhtc=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=qr8NU3RbqCczA4aiTujFWiQu5lNkBBvbs53V+ANGqQC5ShzahsUeezBUB+zRCXa6X
	 6F2XDh6e//s+0S/DMOgPhH1HFHuFscLhKUYTubP9tsGlh4gRmhezTCzYxioqZyPOl/
	 AgBxRN4EPBC652os36dxhfjXj2OdLwuktvurCJyojrrR90AZEUQgH5UstIEs1BnkSg
	 DMCgBgTpAfFthYsdU7zfamjlJZvNr1jw+rbI/62kd/bUcJynrXA4L4xnG3CihEcsEe
	 7WKnarjYOSnTOxqx//rskan9L284cwy8X5+yRGnfT9wu+bU2u/eqHIwGyJ9CY/pQE/
	 Wr1ofM9FNa8jg==
X-Gm-Message-State: ACrzQf3SwDoDWOqCpkWROIH1Dp6ZPNxt566Oye3nIwguzVMlZAGr408F
	ah8yN6BelrLfGg67OEmWN5G1/IyzjAayD+RGGUw=
X-Google-Smtp-Source: AMsMyM54GabGSBFDJa25jVqciI4CR+sj6LpueHp3yBJdL7CAze93ucqNTSKMeYSQpVfVNklAVT53FzRQ6bUCGnHtOJ8=
X-Received: by 2002:a05:651c:1590:b0:26c:4311:9b84 with SMTP id
 h16-20020a05651c159000b0026c43119b84mr4371997ljq.152.1664786495531; Mon, 03
 Oct 2022 01:41:35 -0700 (PDT)
MIME-Version: 1.0
References: <20221002095626.484279-1-ardb@kernel.org> <20221002095626.484279-6-ardb@kernel.org>
 <Yzm8HIccvuxyicYx@itl-email> <CAMj1kXG-0Bpc5B08EAJTGsNKan4S4628Wwz7wPh-EAY9p4zg1Q@mail.gmail.com>
In-Reply-To: <CAMj1kXG-0Bpc5B08EAJTGsNKan4S4628Wwz7wPh-EAY9p4zg1Q@mail.gmail.com>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Mon, 3 Oct 2022 10:41:24 +0200
X-Gmail-Original-Message-ID: <CAMj1kXE+64akXeGPopDO+Qg37fhndRbuBCGg2gr7ZSJb0WP2eg@mail.gmail.com>
Message-ID: <CAMj1kXE+64akXeGPopDO+Qg37fhndRbuBCGg2gr7ZSJb0WP2eg@mail.gmail.com>
Subject: Re: [RFC PATCH 5/5] efi: esrt: Omit region sanity check when no
 memory map is available
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, 
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2 Oct 2022 at 23:43, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Sun, 2 Oct 2022 at 18:28, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Sun, Oct 02, 2022 at 11:56:26AM +0200, Ard Biesheuvel wrote:
> > > In order to permit the ESRT to be used when doing pseudo-EFI boot
> > > without a EFI memory map, e.g., when booting inside a Xen dom0 on x86=
,
> > > make the sanity checks optional based on whether the memory map is
> > > available.
> > >
> > > If additional validation is needed, it is up to the Xen EFI glue code=
 to
> > > implement this in its xen_efi_config_table_is_valid() helper, or prov=
ide
> > > a EFI memory map like it does on other architectures.
> >
> > I don=E2=80=99t like this.  It is easy to use a hypercall to get the en=
d of the
> > memory region containing the config table, which is what my one of my
> > previous patches actually does.  Skipping all of the validation could
> > easily lead to a regression.
>
> I don't like putting Xen specific hacks left and right because Xen on
> x86 cannot be bothered to provide an EFI memory map. And as for
> regressions, ESRT does not work at all under Xen (given the lack of a
> memory map) and so I fail to see how this could break a currently
> working case.
>
> >  I understand wanting to get Xen-specific
> > code out of esrt.c, but this isn=E2=80=99t the answer.  Some sort of ab=
straction
> > over both cases would be a much better solution.
> >
>
> We have such an abstraction already, it is called the EFI memory map.
>
> So there are two options here:
> - expose a EFI memory map
> - add a ESRT specific check to xen_efi_config_table_is_valid() so that
> the ESRT is withheld from dom0 if there is something wrong with it.
>

Actually, the obvious answer here is to implement
efi_mem_desc_lookup() for the EFI_PARAVIRT / !EFI_MEMMAP case. I'll
have a go at that and send a v2 shortly.


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 10:02:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 10:02:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414800.659192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofIGj-0004LC-I8; Mon, 03 Oct 2022 10:01:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414800.659192; Mon, 03 Oct 2022 10:01:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofIGj-0004L5-FC; Mon, 03 Oct 2022 10:01:49 +0000
Received: by outflank-mailman (input) for mailman id 414800;
 Mon, 03 Oct 2022 10:01:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zoY7=2E=citrix.com=prvs=2684d4d0d=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofIGi-0004Kz-2a
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 10:01:48 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60419a69-4302-11ed-9375-c1cf23e5d27e;
 Mon, 03 Oct 2022 12:01:42 +0200 (CEST)
Received: from mail-dm6nam04lp2047.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 03 Oct 2022 06:01:38 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA0PR03MB5561.namprd03.prod.outlook.com (2603:10b6:806:bc::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Mon, 3 Oct
 2022 10:01:37 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.028; Mon, 3 Oct 2022
 10:01:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60419a69-4302-11ed-9375-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664791302;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=V/GDoceBNcvErv+mop6ozWhndyuwrzfH1EsNijPs3Bs=;
  b=XnOqoAj/C3hBecJ84FPko8nSHFM4Md0TgxIiWr0Gfv/hhRaQfssAlqTu
   3yEoxY6gh4dHOxc5uur6vq8kHCu6/TgfG+Y6vPWkdxpE8+d7xrkDKRzI1
   eux21lG3UDwyTirPHZ/Gj+c3X8ALiwO3fjmX9r63RndPnEVbrlJLxRvlb
   w=;
X-IronPort-RemoteIP: 104.47.73.47
X-IronPort-MID: 81829358
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:wpscd6khErqu/3PyLYLw8TLo5gxLJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNXW/TOP+JY2emLtkiOYqxp0hTvZTUz9dgT1c5/n1gFCMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS83uDgNyo4GlC5wRmPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfXm9n7
 fFIMzoxYDvTusyZ37PnbbdliZF2RCXrFNt3VnBI6xj8VapjbbWdBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6Pk2Sd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL11rWexn6rMG4UPO2V0/NP22aP/288UwI7ZFzg+cuYrnfrDrqzL
 GRRoELCt5Ma+EGuT/H8WQO5u3+OuhMAW9tWHPY+4QvLwa3Riy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/HmqZs2hwjCTf5iFrC0ldz/HTzsw
 zGMozM6jr9VhskOv5hX5njCijOo45TMEAg8412LWnr/tl8mIom4e4av9F7Xq+5aK5qURUWAu
 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF7n9hx0xZPpbxt3Qw=
IronPort-HdrOrdr: A9a23:Se+IsKOgaMF+C8BcTyT155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ
 uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2cqYRJd
 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S
 zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8
 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ
 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt
 WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv70voxKhNNKWs2N
 60TJiAtIs+O/P+PpgNcNspcI+QNlHnZy7qHSa7HWnHfZt3S04l7aSHqIkI2A==
X-IronPort-AV: E=Sophos;i="5.93,365,1654574400"; 
   d="scan'208";a="81829358"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HmvROMxynk68SByMS3SBLLC9sQwg0nCXd3QpUXxWKxtvhpfi+x2peF32/9PyS41h9uQNOfWU2PafTn4qTuNWlspn/Yqabmi7Z+Va8DUMxtWIs2hLVog0/xtQE7qvCcZcFufZntIjDYgmNcmP57Xgfv7/TjSUpIZGEwmxDtQdUJLVj8D/AgX2I/NLYc2sHXoLSjPkz/LXQInLiVYxAEDyHC32GgRSHGzLtJV4RoN6vcuGIVICFtJkp3ZZ4cWTHoMKeupaIux8VmLtbLFDBmU6rcsVVjpwgDUrZfGD7RATijRWVYgiRVHP/hXY0bfteJxSaOp/+9bNZJpj8S8Bj0valw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pPMRIbOzXmorty30qTqxzLTymVeMQTiurG3jYHFjYO4=;
 b=fP7LL/iYAj8zRnkWGNXGUIFXehYWZmnhbizrvWLCwW7x24Sbc0ZUzy+8po2tmsH1o9T0SgpdzEFuWOO2ARyQ6l3dlUGRLPBjvx+zFPwCmNYE6pnUKBITy62wsqHJKKAvQlgz2hOJuVD9VkBIJa4CqBYxRjwgDRqlx9BUX3Mr4Ac1cOFN1k4L/gSCcG/3TIh+azgEt12FU+G3kRM+6poeDkGBLOXmlJE6Xt8PaFsw+lEMFJrXwvUQJNZRR4/q1F3AY7tDhHwRhkDI/I9wWR4YCgpNNPAmlNQazJbWmM1RbdwyGe+Z/itdJVxgjGm49fWOxrG5MYmkTEUTSrt5DZIKwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pPMRIbOzXmorty30qTqxzLTymVeMQTiurG3jYHFjYO4=;
 b=GSuw5ZrGnsPw7Aj3LrTBcyl+s+823DBOdxR9wfgAo5lt9423xh/Os8x3SHGn2R0D+OSbJYzXF18NmIX/rwe7igL13DT/LEHSYbosVOLdtpu8Ej5sQf/paMZ4QEoIpGxTjEcKk6Z3nnEZwWR3hoJnMc1keec0wcCVItgOH5CDGC8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 3 Oct 2022 12:01:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH] Use EfiACPIReclaimMemory for ESRT
Message-ID: <Yzqy+c+jmI8xwEBD@MacBook-Air-de-Roger.local>
References: <2561c7fc38d9b4d17cb0205fec49b941894cfcc0.1664570575.git.demi@invisiblethingslab.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2561c7fc38d9b4d17cb0205fec49b941894cfcc0.1664570575.git.demi@invisiblethingslab.com>
X-ClientProxiedBy: PAZP264CA0199.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:237::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5561:EE_
X-MS-Office365-Filtering-Correlation-Id: 7ea7f849-ba68-43a2-ca9a-08daa526425e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5X4TRnlSqi+RlzuC1u/hNP1lm8k6evzeG5qJQMo1d7bSfjFZ/6sgP6aKEg7MVoizh3L0SwlZP8aX6avwX+ceSfhnRpEqgxBK1jGOTnX2Y0cT5oqihxD4SYzNAFHmbLPrIu2DyuhWcqZSSciC8Oaur4XazEsv7mvLL0aQAP1pgKZR6GPiOwf1bW4p3BblRAdgQrFgipexkZBf2uLbnVPp06JUjIfeCLB5h36OmlRxKXqhhb4VUB0LIQTsLtLViXy3AuQsSH+6ExwRMgpxU7tM3X3fCc0yIMWDUOOL/jgNeTygi8YuCLPeJZqG8EigjBNkNoWII++X0VPm7gApQ3idnUiK0uWOWPxtUbtmnyaRirRJIoa5ftLtbbZ6NKurU+6BjO7YqvJtVJlPikmvCx8orCYLDODA8KmS1KACIqUHTbLC2Nb+CoXpZjwbDuS0p5kXE2n/M63RoiyzKu1zksrOH2mg57Shs1Wy6JxIsV0/xVlKzrtiIDaDp/8IaRims4CeJJaXuCJ6ThI1DhTy2t7fwAtYr0ftpVBaKsPufiOKfgSHYy5Vu9r4E3Bgx+GU/y4L2dxo4mWR1ZtsEvSwbvUr0QNmCCZWuyqYdamWivX7mrVHnG76+1YuBKLvAp7GymjOEHbjTKIP7nYzVnj2WQIkseC4au1xEM9Rtns7iUugXh4+iNNv7E84c90ZlzyodYCbWErmhNlSfjvxItbgvkdwrw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(376002)(39860400002)(396003)(451199015)(9686003)(26005)(6512007)(6506007)(86362001)(4744005)(8676002)(54906003)(4326008)(316002)(82960400001)(38100700002)(85182001)(6916009)(186003)(83380400001)(478600001)(6666004)(6486002)(2906002)(5660300002)(66946007)(66556008)(66476007)(8936002)(41300700001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dkFjeHlaWE8vdVJSOGtkL05tRENTOTVPQXBRWXhmN05tUlpIMTZwV1U5SzM5?=
 =?utf-8?B?NGtXazU5UktSZDNQcUt6VFdmbU83a3V1S0tCZ2FrK1VEOE5ld2NZMnJEZWRm?=
 =?utf-8?B?eFVrV213UXpzV21MYkJEaEw2MCtKSmo4VVlPSnFmVFhhN0laS3A4bnZCTS9R?=
 =?utf-8?B?OEZhZnZYMmNUanoyazBGbzBuY2ZRdHpraVNib1dvemQ5NFU5UHRVK2ZVdUY4?=
 =?utf-8?B?QVpuTEVLV3l5aVYwRXQzMVFnMjhsVXZIeGxJb1JQUExMYXhUemhWRURldnBU?=
 =?utf-8?B?L3VOVnZxTDNRWHU4eWFEZWlxc0p3UlRsVG45OS9VcnEreGdiMkdRU3R4a0pR?=
 =?utf-8?B?eUZaaFNPNHpQUlU1ekpLWEFLTzBkYVY1NjFjaDRrSW1TcHNHcm1XcnF6U21n?=
 =?utf-8?B?cXFCZ0ZLSlVxUDJsVVFBMVRaWi9mdS9FZDBsWUtuL0xrZk1KbXVFc0J3OEw0?=
 =?utf-8?B?cUFFTFdYQVNpMkdONHEyakZDakxmUDZ4RmtoLzVDZTVYOTVSc0NubyszRDVO?=
 =?utf-8?B?UWdwV3Ezdy9lV0RQU1JPeHExcmhKZWp4b2lpL2xGOVBNT2ZpV2ZFTXpsZkg2?=
 =?utf-8?B?UERLYTVySnUrQUtQY3A4bXp1bU9pamk5QTIwVk9wakczblVIbE1tWkt4WDFp?=
 =?utf-8?B?V0oyMlFubEpKZUNQUGdCa3pRTnp1RFZNRkg5R0NFYWVlMjc5eGhWRXMzVTgy?=
 =?utf-8?B?V25SN0hYWHU5NE1qa282YUpYWU9WZ2hiQ0dsUnF5T0gwSmlBenV0N3NBRXRZ?=
 =?utf-8?B?MjVPbkxHLy9QUXMwQ2ZwMitET28rdUExMkoweWkrSHRaRXM5dkJjQTRRN0k0?=
 =?utf-8?B?SnBTME52UUlYbmlLSGx5VlE2aWJzU3Jwc3c4Z1V2N2ZqZlJsOUlCcmtCM2d2?=
 =?utf-8?B?cWE2a3B6d1ZNS3V2bXNrYmRXdmlHNlpqcUtrOFBzamRkK0hYMVBCMnA2QVRy?=
 =?utf-8?B?aUhBaEVVajEybTFBVTZqaHF1aWI2RHBXaEhmaFUxTUpacUxqRkF2cnFYSjdW?=
 =?utf-8?B?dFJQRm5KT05WVW0vZWZaUzNRL0sveXpROW1qWEJxdThQY2Uramc3ZlJpUEFP?=
 =?utf-8?B?NHI2NDIxU3F6U2JNQ3dYV3ZBenFGelFmaVhaaGJKUWpWK2pIa2NsV05ERWU1?=
 =?utf-8?B?RnFtS203bURzWGRNTjBpeXVVQkNVeXpZYk1pR0kxeS95MlNMSktELzVwbWJx?=
 =?utf-8?B?MnJHaDFDZnpyT1ZKSWRTWmlDaHJpUHlmeWF4OVlPYS96MlE5c1d2Nk84aWxT?=
 =?utf-8?B?SXhhM3dadTJKQTFSMS8rN0hQQzJJNExJaG9LS3VnTURPd0RYaVVJR0NVdFdv?=
 =?utf-8?B?U1FRWTZ1QlJaRERudDdVQUtON1FOL0JCbm1LTDVtZnhhOGdvcnlOVWhHUFhF?=
 =?utf-8?B?T0lhd1hkVkxPQXpHMU9hUXNXWmRWM1dzWkN2M0w5ZEJkS0FGc3hqbGF0ZkQw?=
 =?utf-8?B?SGtGREwwVFlvR1Jjc240YzRkVVZ5WGd3VHN3VnVQWmp1MmszWVNnMGcrTVhn?=
 =?utf-8?B?VzZoYlNZaTNaeHQ5alV0TnVSRnU5ZkZsa0t3ZUp1Zy9hTXUrSmdyS01JREpW?=
 =?utf-8?B?R084VnJTUlZRRUxrQlJ1U3FVSjZKZ1YvMm5ab0tKK1plSjluT1NZRGxxTnpK?=
 =?utf-8?B?NEQ0VjRLSDg5Zk5qcDN1d25kMjRVYzZoWldjdG5pM1RqcFFFN2NFU1lBZHk5?=
 =?utf-8?B?SEVvV1Rtam9XdFNnbnlvWE1RV3p4Yk1OR1Q4YTVTNzdQYnpMdko4Y1lwa08z?=
 =?utf-8?B?YWR1VVRuQml2V3JaUzNEOXFadnU2QlRHYktrZE9hU0s0c21sSVlvMXBvQ3VW?=
 =?utf-8?B?ck4wSTVVd2tnNjB5dHF3TXJMWGkxSXRDY2ZKWDhaaFNoRWp4V3FldFlMYXlQ?=
 =?utf-8?B?bE5XZkFzRFhaS3A4eERXQjBPb0Q0VUwxc3hjaVBZT1NRSUpnYW9Wb2RKTWF3?=
 =?utf-8?B?TDdMdFNaNUxBRTA5eW92OHdPenNQS3IzR0d5REZqNXdvRldFaXNSYXh4WEFP?=
 =?utf-8?B?NHlSU0YvdVVuZlZXQXRURmpBZnlnelZybEIyRzFWelZnRXJxN2ZMM1RyUER5?=
 =?utf-8?B?VVVsSXg3TXVDakRydzlGN1dIc05ZUVF4VUJmcDRUUUNBNGJ5dWJjb2JNTkVn?=
 =?utf-8?Q?9yJGDQUWlNsYhzcu9Pe0vzxfE?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea7f849-ba68-43a2-ca9a-08daa526425e
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 10:01:36.8601
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: unhcP+ZC0jGnWOqcVHcXX01M2ZeaF3ww4XK0slluSCiGPx6ffZv3PLGqcMX2rF+gPjlQRwPNyi4AyUrZJbYD3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5561

On Fri, Sep 30, 2022 at 05:02:02PM -0400, Demi Marie Obenour wrote:
> As discussed on xen-devel, using EfiRuntimeServicesData for more than is
> absolutely necessary is a bad idea.

I'm afraid this needs a proper commit message: commit messages need to
be able to stand alone on it's own in most cases, without references
to external sources.  IMO I would add a summary of the thread that
happened on xen-devel: scenario, issue and how it's fixed, and also
provide a link (from lists.xenproject.org) to the conversation thread.

It's also missing a SoB.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:20:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:20:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414809.659203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJUi-0003hq-Bu; Mon, 03 Oct 2022 11:20:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414809.659203; Mon, 03 Oct 2022 11:20:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJUi-0003hj-8K; Mon, 03 Oct 2022 11:20:20 +0000
Received: by outflank-mailman (input) for mailman id 414809;
 Mon, 03 Oct 2022 11:20:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tjbh=2E=citrix.com=prvs=268c0e076=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ofJUh-0003hd-2y
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:20:19 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5af99fa1-430d-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 13:20:17 +0200 (CEST)
Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 03 Oct 2022 07:20:09 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MW4PR03MB6347.namprd03.prod.outlook.com (2603:10b6:303:11e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Mon, 3 Oct
 2022 11:20:06 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Mon, 3 Oct 2022
 11:20:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5af99fa1-430d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664796017;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ZElAJ2dOaE3bi1kjESNtokaqE9uVSLzHW8SawOBAA1k=;
  b=M2vdOc6TWTpCmfPt/afsxl0yQ2AyuNtrclMRkUAGmhtcNfVhvxq38Mlo
   8EjAbQ6mkQAFclxp4lSr96UVfRMM/Qz2q4wcWDR/VHvhKpUhiqTItZqTU
   NAA+6zCl8Et/knSGsLJZIWf+XsZ8VqOimfs1o2GgUS5SR6EMRF9+mkxSa
   k=;
X-IronPort-RemoteIP: 104.47.55.101
X-IronPort-MID: 81491051
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KWNELqC5UCWS/BVW//Piw5YqxClBgxIJ4kV8jS/XYbTApDIj0zEGm
 GQWWmmGbvmCNGD9KN9wPdm/pEIBvJ+EytNrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8vWo4ow/jb8kk25Kyp4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kaHrQz8PZpGV1gq
 +whMRU2TByxjruPlefTpulE3qzPLeHNFaZG4jRF8mucCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAF7gvN/MLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toivw17aXwHqTtIQ6FoK11tR6vlKqn1c5IycuV3ibotOrlRvrMz5YA
 wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4CPYm4QuAzq7V5QexBWUeSDNFLts8u6ceWjgCx
 lKP2dTzClRHsqCRSH+b3qeZq3W1Iyd9BU8PYzUVCzQM5dbLqZs2yBnIS75LAKOzy9H4Bzz06
 zSLtzQlwaUei9YR0Ke29kyBhCijzqUlVSYw7wTTG2e6tAVwYdf9Y5TysACCq/FdMIyeU1+N+
 mAenNST5/wPCpfLkzGRROIKH/ei4PPt3CDgvGOD1qIJr1yFk0NPt6gJiN2iDC+F6vo5RAI=
IronPort-HdrOrdr: A9a23:3hAjNaPFxoKIucBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+
 Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu
 UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+
 jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI
 SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
X-IronPort-AV: E=Sophos;i="5.93,365,1654574400"; 
   d="scan'208";a="81491051"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GxqA51IIl0cIHF1VG6H89F8YFYF4D1inYXYdTUtp2Rg42JldkAdCPO+yMjWuO8/AWTLX03tnPE/uyOQlw33AY1/xibjA7p9Nlkfp+8G9IYhOwWr1UFVIC1pudVdY8//h+bQZFSBGEbwkPeGH9YuBFGd8lk+npkXm4gLqnC5Lz0nJwTBxnggLNbGuu06YxVPvy5DuN3yl3Wc56sV+cEoLvyxKaMTIHJaArXmOwfLKPclQht868gshAOs2r3JbcPwLuD0zZHJNoaJfOnQut898p4Bqf4SQpCrwQLVhfGyXGyoWvulbyeFbCr+2vUgf7sduPkQl/r3TCqpNdghnKbcfkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZElAJ2dOaE3bi1kjESNtokaqE9uVSLzHW8SawOBAA1k=;
 b=RZ1Wk1agYlvkt9qxuLjoz1y4DuaFBIBvEgNwGPxgGMtFl7XbPPxt1cj9PDYvhjjdkXYTIsVR92OB054kSwyvVaHgpE36onroEm6HPbgR+BX0KgzBNP8+DFEb3krtoP1xA41/q2yAT1YN31y7I3cXvZAsc3TO2L5nM4qdiFFy9g6yX+UO3Hfns2sDeZWoVwO4PhakzCKIviwqGiQmEkVeoN5TEY/L+XPmR3B3XgtvhyiQ52Rjb9sgezQvV07VQvBt6Uc6U9YKmPbSOYU5aX7Nie1AJgXgDs1dkFCcXR4/7Vhq5Emi1UFafh7SuNAROXEyVeOmy5QuDOUjy7JR1x8zaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZElAJ2dOaE3bi1kjESNtokaqE9uVSLzHW8SawOBAA1k=;
 b=fHpgAYwe9IiQJ3EwWB5eb1iChM5wGvf6NCCbyBVO1jXlQbU0XfkBEyvLgDNLPf8a4/UxkueMfMb6okkPSMjbkiZWWh4NvZ4rkXf8yFXQqvtOMoSuaN0RVe2vQOhQBwsdp1XILgDMB5VDcgd5GEwYQNOOsIRFGjOrBWDW8HBbgmk=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <George.Dunlap@citrix.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS
Thread-Topic: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS
Thread-Index: AQHY0oiAaGzY0Q9w4UWHsGMrupWMzq32MXQAgAZdp4A=
Date: Mon, 3 Oct 2022 11:20:06 +0000
Message-ID: <764f281d-fd97-7413-02d9-f856c0a5771b@citrix.com>
References: <20220927154708.15787-1-andrew.cooper3@citrix.com>
 <77d1bd6f-fce6-bcd2-96f1-a672aedaa7f6@suse.com>
In-Reply-To: <77d1bd6f-fce6-bcd2-96f1-a672aedaa7f6@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6347:EE_
x-ms-office365-filtering-correlation-id: df4f8632-3b2d-40aa-623a-08daa531396a
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 DKwtF3EY2LodUUAh9wR0InmL8Ft3c1cjqJxMl/U3Ea3FBtiI1N9UlxaorniKS5H+iJHhbv0JcTcDFNkjb0nn/wc3ogh9tQyd5WwTqHOlzJVgR+JDsRfbuAl6wXWXca90Jf0Dxbq/zvFLRF+E16X6zQTdZ7/hnZJ3HYxAUCx7AgizUvdMwRv+jno3gTV9aY5jCMl7qH8gxXNnqVhG8m8Pwim68E38IkC+ZWsKw+DR0pVFwMi34b7J1FWXN5PtH0ZtjFNin1NwV9Q0AquXJ6ZYDbXU/97o0Xr7OounVsn3nbj2/0ZWxnLsMQMfQ8CYsbY4/tuHfKOWTgp9qKPCAcwIa/m3BCu68OFAw/48ifHYUYrNAUo4/sQ9fMFFpJFqPXbGvG6OG6L+aWdNDT8cqccEsLiC2cn/rpOpnfcFeghbIMwUBtSmQGC8xjkQ2uV2TisQ9QHYWJ0mjSCXncVIPQIk0Z3qEmMvhdh3ws5Bhs4159GHzc72Ai69UM5THrROOzNL6jPHa57GHGRjJN57Qs10UwWrnKrbvXEHhBowkKKGUgMlATFUR+E5rYLCZXbMvS3hJSVNb9HviR4b/3ZuW2gk8c84JbcqPhNVHtIqZhXVxhAN/r2TVUWgSt5K2Y940681ZY/9c0FBixTpWTrFiCZDcpb66SnvpJKShhrFkVjcyFc+LtDXngUwME2W+3WNloL8l9P+URpWNmf9SyrQXPIybkeoXMhRKXHvC+OcsuR9ipRlotLgzxezJOyGgT6pevl9VvxZ0sMVZnzilUl0i6LwErT/ZAKb7ausnPdXjITOtLARnlC3j9BMzxr3n5MJKM9vAUwrBckLaogxKuNvGm9+Mw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(451199015)(316002)(66446008)(66476007)(4326008)(5660300002)(64756008)(31696002)(6486002)(71200400001)(66556008)(478600001)(8936002)(2616005)(36756003)(91956017)(82960400001)(76116006)(26005)(53546011)(66946007)(122000001)(83380400001)(54906003)(8676002)(41300700001)(6506007)(6916009)(38100700002)(186003)(86362001)(38070700005)(6512007)(31686004)(2906002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UFo1ZjJXSXB5SXc2SUt1R1laaXFZNXV4Nm5RYkdxZ3RvTjVvNE42cGNrM1Nm?=
 =?utf-8?B?SFppL0dDSHAveGVvWEtJeEtBZDBRNVJSa0tPQVQwZVBEQmNVSWFOOHJaOUpn?=
 =?utf-8?B?QWxCTklCLzhENzhkTDgxWmJaTW84WVo3aHdVQlNJczBnalplTVgyOG51RnpS?=
 =?utf-8?B?cTJ3WkpYUEk2M3pEN2p5bDZOaEZZU0F4MGorZDQ4cFpiaVNsMENyQkJNUXBl?=
 =?utf-8?B?TlB6SStuSm9uQ1hMMUdJcjlXVjVnaVQ5dkIzVENmR1lKS282QWdVTkZBKzZ3?=
 =?utf-8?B?MVZsb3NBOTZWSmprZWg1aHhoN0lyaTlOUkNXalNrWU00U2V5Q3c3bW5KNCt5?=
 =?utf-8?B?TTJmZW1pc3grZUdGV1k4RFR3bTR5WnNSeXJWRENXakVueEpOTW5TdzdxZEVv?=
 =?utf-8?B?bUNKcTM2MHNoaTVsRk10VzB3VE1TbW9jbDlMVzdtMEE0dmx4NC8zTmlRczFX?=
 =?utf-8?B?akRnS2RXRmpvd01TS2JRbUQ3T09hOCtHdjAza1Ivd09yMzdqQlc1R0ZOY2Vo?=
 =?utf-8?B?RVRrM0RibDJ2YjBPaE5MOHFtQVB6Y3ltUzlaYjFCQnp3WURiR0RHWEhseVdh?=
 =?utf-8?B?bEtTQk90ZDNENXlROW5TbVpYaXdZWEw2MlhxSVYrNi94Tkd3Nk04VWQ5ZTdS?=
 =?utf-8?B?VXd3UDluREszV3JHUFFKd09yVlBXaWFmMklEM1FJMHZaZS9wcGZGUXlsaUEx?=
 =?utf-8?B?NEVjVTNlcHFyVlNKTDBZMndEV05mYTgyWDJpOS9rcFZvejhCN0t5a0hNUHJI?=
 =?utf-8?B?aENvbEdjYVMxWUFxWE5WQnZTZGpkak5KNHdXYmxZbFAxQzljNUJqdHI0aXU5?=
 =?utf-8?B?M1hENHRiT3VNMzFTV2g3Y1BVSDFWVitNQytFVXVISnphQXJ4ZnU0allib1NU?=
 =?utf-8?B?bUY2Tmk3MUVYSU8vYndMR1Aza0RaMytHMXlKUTArd25XOGlKcUNnR3BFeFN4?=
 =?utf-8?B?WFdqbFpTTERqa01aWlVUVWxManZIYi9DM3BxdFBWNnZxeGxnODh3UjVJc1cz?=
 =?utf-8?B?QzljQVgrYmFEYmRsbEZPbWlNRVV5YVhrNUllN1BoWnczYVNqRXBXZytORUFJ?=
 =?utf-8?B?cVUzRktIaStWOEo1NHlkN2lZYmc0MVlIR0k3enlJZGdOOXFRcFlrWDlOa2JB?=
 =?utf-8?B?VTh5YU0yRzcyVUZ0QjVaYVJwdGczdzRJTDdHV3ZYaFpvc09EVURQeUp3QXgz?=
 =?utf-8?B?WmpwNWg4bEhVSnk0M0JsUHNLOVQxaDc0bFhKWDhFTzNEeSsybHdDbXM0dUZx?=
 =?utf-8?B?Y3IyRWsxYXdSUFFJRE5kUHpTRy9BQVVNUmowYUpQWTFZaDUwb21QYUhJOFlM?=
 =?utf-8?B?S2RwL1MwcHVJK2V3VHdEK1hjQ0ZOcnptYS9nc1Fyd0RvbTBmZ3JpWjUwS2Fm?=
 =?utf-8?B?RThkUzBPWFAxeTB1US9PMExGU2FmUjAzcWpGYkh1TVp2ZmNuUlowNmJCSTJT?=
 =?utf-8?B?YytNRG9kc3B2Ly92Rk9sTTBmVDdZNkhBVU9wL0xkYmUzUkcwcExMenFrc0dq?=
 =?utf-8?B?SG1ZUHFzK0tSV1hqMVY2dUJwVUtYY09DenpJclFidHZYYStWcGJlMjZKR1du?=
 =?utf-8?B?VEx0RjBJM3F3SXhYTDlPQ2lwUUN4R3YyajFUUDVOVnBpb0ZhVnZxb253S0U5?=
 =?utf-8?B?NUdiY0sxd245V1c3MStnellwWWRDZzYrQ3dtTWtqcXFHWnNjMUVMMDgvNFNH?=
 =?utf-8?B?dVlKUCt5M1doQXJkcjFsY0pjemtMZEpBWlVmWHNpNkNOd3ZvbFEvQmx2N1l6?=
 =?utf-8?B?cndPWnk3dCtpb3J4Z29RNG4yR01hQktRclY2R2tNMTR1ZHlHak00cVYwdHZ2?=
 =?utf-8?B?SzlLdzFQbWxKWHZaSTNSOGF0a0tRQ01zdlNiM2F1YXpSbHJkMEp5L2dNTGZx?=
 =?utf-8?B?NDdXR2YxSGx6RmNUWjAxMVZGeFdyVlpHMlZJdHdDYUFIS3VGYXhHbjNQYXpz?=
 =?utf-8?B?dmw0Zy9NSXpyazJKaHNGYWZ0ZVpTZDVBejEzdCtWbGRSMEkyeENka056T01Y?=
 =?utf-8?B?V3FkWlo5dFpwOXByWHdPNXliU3ZmK1lHSTdieVdLTzNxYjVhTjcwMmVxUnBE?=
 =?utf-8?B?cFJQbmp0VWdQa0prVXlQMnRVV1FVVjNQa1RkZVJseE5QUlhVRks3cGl0MFlu?=
 =?utf-8?Q?zq1fDnNt/FZtiVnWgQ+rdbpX8?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <70DB8E9DE8A893449C0B87F3876D0FA1@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df4f8632-3b2d-40aa-623a-08daa531396a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 11:20:06.1287
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZoOhytpF4w4UT4Y3EZU4pGkk2oETAnt8k85jexZmVgj8TLCkSqef4+HaFj/++tS3ideofyyKe89Pvs17VCrscEUErmuPmSBJx7NI7TGjnbg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6347

T24gMjkvMDkvMjAyMiAxMTowNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI3LjA5LjIwMjIg
MTc6NDcsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGlzIGJyZWFrcyBhbGwgQ2xhbmcgYnVp
bGRzLCBhcyBkZW1vc3RyYXRlZCBieSBHaXRsYWIgQ0kuDQo+Pg0KPj4gQ29udHJhcnkgdG8gdGhl
IGRlc2NyaXB0aW9uIGluIGVjZDZiOTc1OTkxOSwgLW5vLXBpZSBpcyBub3QgZXZlbiBhbiBvcHRp
b24NCj4+IHBhc3NlZCB0byB0aGUgbGlua2VyLiAgR0NDJ3MgYWN0dWFsIGJlaGF2aW91ciBpcyB0
byBpbmhpYml0IHRoZSBwYXNzaW5nIG9mDQo+PiAtcGllIHRvIHRoZSBsaW5rZXIsIGFzIHdlbGwg
YXMgc2VsZWN0aW5nIGRpZmZlcmVudCBjcjAgYXJ0ZWZhY3RzIHRvIGJlIGxpbmtlZC4NCj4+DQo+
PiBFTUJFRERFRF9FWFRSQV9DRkxBR1MgaXMgbm90IHVzZWQgZm9yICQoQ0MpLWRvaW5nLWxpbmtp
bmcsIGFuZCBub3QgbGlhYmxlIHRvDQo+PiBnYWluIHN1Y2ggYSB1c2VjYXNlLg0KPiBTaW5jZSBp
dCB3YXMgbGFyZ2VseSB1bmF2b2lkYWJsZSBmb3IgbWUgdG8gbm90aWNlIHRoaXMgd2hpbGUgcHV0
dGluZw0KPiB0b2dldGhlciB0aGUgdHdvIFhURiBwYXRjaGVzIGp1c3Qgc2VudCAtIGlzbid0IHRo
ZSBjdXJyZW50IHdheSBvZiB1c2luZw0KPiAtbm8tcGllIHRoZXJlIGJvZ3VzIHRoZW4gYXMgd2Vs
bD8NCg0KSG1tLCBpdCBpcyBub3cuwqAgSW4gdGhlIHBhc3QsIFhURiBkaWQgdXNlICQoQ0MpIGZv
ciBsaW5raW5nLCBidXQgdGhhdCBpcw0Kbm90IHRoZSBjYXNlIG5vdy7CoCBJJ2xsIGRyb3AgaXQu
DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414818.659224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJaq-0004dx-9k; Mon, 03 Oct 2022 11:26:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414818.659224; Mon, 03 Oct 2022 11:26:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJaq-0004dq-6j; Mon, 03 Oct 2022 11:26:40 +0000
Received: by outflank-mailman (input) for mailman id 414818;
 Mon, 03 Oct 2022 11:26:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJan-0004Xj-Ve
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:38 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3db2adcc-430e-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 13:26:36 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 884F4B8105F;
 Mon,  3 Oct 2022 11:26:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4010C43470;
 Mon,  3 Oct 2022 11:26:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3db2adcc-430e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796394;
	bh=lpQ4+WmITmtmOnKFnxuwxQHGwlCFJ4zTtvospQM9GKk=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=K9ID/meLYrn0iHyhvkrGaVzZES7EFVJpDW0Uw9aDg2M81HUgIx3frx0cFPJop1arF
	 vgRUsJ37RND+bWXPfbtBFAdH5j+1mk+62cnz90JM8A40hCCp4oTwAnZyGKNkF/2dwE
	 KBqstIRcIaoSImv4Mne7Gja/jq71Kp4NI/jjGDNpaNbzgz9oe372Ridjm0lBwXGcyr
	 iwSpUGMJX/8UxZ2AS32VumjW87yYtxSe1Chbd1asWLgLqGyQoyz8qmXULZxXUjsIed
	 MxkcNn1E3uEfsCTPRGFWY5eaTMnpaYyJXrS44pjrZjiba6qmhAd+2w5s9S0le4zqDP
	 vN6tusSTeesmg==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 1/6] efi: Move EFI fake memmap support into x86 arch tree
Date: Mon,  3 Oct 2022 13:26:20 +0200
Message-Id: <20221003112625.972646-2-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221003112625.972646-1-ardb@kernel.org>
References: <20221003112625.972646-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=11648; i=ardb@kernel.org; h=from:subject; bh=lpQ4+WmITmtmOnKFnxuwxQHGwlCFJ4zTtvospQM9GKk=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbWzvxr8yONNNbEpLG35L+GKpYlawmf5lOH3UFh k0+XysqJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG1gAKCRDDTyI5ktmPJBRBDA CixbtB0CwvPLakaVceoJAQw8qQp1WDRfoHfeuCKX7ncix1T1+dYnYT7rv36evcoTla9LTIKQ+9Mkci UsRk9egPOu2Iji+te1wm5kdK5zHzh632bZ7S8hxo0DxaqPGheCnlh4ZVjht6EgSGZZYB8zvFSYQ5GU /am/hsSBLOMBjJS53c8heoJFAVYCzdZa9Q4GbxZliAE5s3So7A12gFwWpera0POthgZCzk89JQkPgE 8JFKcrU8H5uRzx2tEFQHfkaWgV+5Ce3Y4j2tFkqTYvCNkYJkyh2ndPk+eod5JVdww+/NYpYNl/Xm6p hQZI1XSSHGWqoGecrPpipl954qmi6j78R/xW9xF8prTJPNnfmHHi0EDMrOp3M3gO8M1R7oE85P7FVy JuXTKcPq5BZnsS3h8FnmGocp9kjpQuDf6rMLbCvgloMNiKNYClETqusN3AA5QXnExGnGmMnSkBGC0s 0ZodJ7yi6FzBLeCp4AaqflSxHSUCwxu5iWdHdNB+cwX+o=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

The EFI fake memmap support is specific to x86, which manipulates the
EFI memory map in various different ways after receiving it from the EFI
stub. On other architectures, we have manages to push back on this, and
the EFI memory map is kept pristine.

So let's move the fake memmap code into the x86 arch tree, where it
arguably belongs.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/Kconfig                                       | 20 +++++
 arch/x86/include/asm/efi.h                             |  5 ++
 arch/x86/kernel/setup.c                                |  1 +
 arch/x86/platform/efi/Makefile                         |  1 +
 {drivers/firmware => arch/x86/platform}/efi/fake_mem.c | 79 +++++++++++++++++++-
 drivers/firmware/efi/Kconfig                           | 22 ------
 drivers/firmware/efi/Makefile                          |  4 -
 drivers/firmware/efi/fake_mem.h                        | 10 ---
 drivers/firmware/efi/x86_fake_mem.c                    | 75 -------------------
 include/linux/efi.h                                    |  6 --
 10 files changed, 103 insertions(+), 120 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index f9920f1341c8..b98941c2fec4 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1978,6 +1978,26 @@ config EFI_MIXED
 
 	  If unsure, say N.
 
+config EFI_FAKE_MEMMAP
+	bool "Enable EFI fake memory map"
+	depends on EFI
+	help
+	  Saying Y here will enable "efi_fake_mem" boot option.  By specifying
+	  this parameter, you can add arbitrary attribute to specific memory
+	  range by updating original (firmware provided) EFI memmap.  This is
+	  useful for debugging of EFI memmap related feature, e.g., Address
+	  Range Mirroring feature.
+
+config EFI_MAX_FAKE_MEM
+	int "maximum allowable number of ranges in efi_fake_mem boot option"
+	depends on EFI_FAKE_MEMMAP
+	range 1 128
+	default 8
+	help
+	  Maximum allowable number of ranges in efi_fake_mem boot option.
+	  Ranges can be set up to this value using comma-separated list.
+	  The default value is 8.
+
 source "kernel/Kconfig.hz"
 
 config KEXEC
diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
index 897ea4aec16e..68414d924332 100644
--- a/arch/x86/include/asm/efi.h
+++ b/arch/x86/include/asm/efi.h
@@ -404,10 +404,15 @@ static inline void efi_reserve_boot_services(void)
 
 #ifdef CONFIG_EFI_FAKE_MEMMAP
 extern void __init efi_fake_memmap_early(void);
+extern void __init efi_fake_memmap(void);
 #else
 static inline void efi_fake_memmap_early(void)
 {
 }
+
+static inline void efi_fake_memmap(void)
+{
+}
 #endif
 
 #define arch_ima_efi_boot_mode	\
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 216fee7144ee..41ec3a69f3c7 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -31,6 +31,7 @@
 #include <xen/xen.h>
 
 #include <asm/apic.h>
+#include <asm/efi.h>
 #include <asm/numa.h>
 #include <asm/bios_ebda.h>
 #include <asm/bugs.h>
diff --git a/arch/x86/platform/efi/Makefile b/arch/x86/platform/efi/Makefile
index a50245157685..b481719b16cc 100644
--- a/arch/x86/platform/efi/Makefile
+++ b/arch/x86/platform/efi/Makefile
@@ -4,3 +4,4 @@ GCOV_PROFILE := n
 
 obj-$(CONFIG_EFI) 		+= quirks.o efi.o efi_$(BITS).o efi_stub_$(BITS).o
 obj-$(CONFIG_EFI_MIXED)		+= efi_thunk_$(BITS).o
+obj-$(CONFIG_EFI_FAKE_MEMMAP)	+= fake_mem.o
diff --git a/drivers/firmware/efi/fake_mem.c b/arch/x86/platform/efi/fake_mem.c
similarity index 58%
rename from drivers/firmware/efi/fake_mem.c
rename to arch/x86/platform/efi/fake_mem.c
index 6e0f34a38171..41d57cad3d84 100644
--- a/drivers/firmware/efi/fake_mem.c
+++ b/arch/x86/platform/efi/fake_mem.c
@@ -17,10 +17,13 @@
 #include <linux/memblock.h>
 #include <linux/types.h>
 #include <linux/sort.h>
-#include "fake_mem.h"
+#include <asm/e820/api.h>
+#include <asm/efi.h>
 
-struct efi_mem_range efi_fake_mems[EFI_MAX_FAKEMEM];
-int nr_fake_mem;
+#define EFI_MAX_FAKEMEM CONFIG_EFI_MAX_FAKE_MEM
+
+static struct efi_mem_range efi_fake_mems[EFI_MAX_FAKEMEM];
+static int nr_fake_mem;
 
 static int __init cmp_fake_mem(const void *x1, const void *x2)
 {
@@ -122,3 +125,73 @@ static int __init setup_fake_mem(char *p)
 }
 
 early_param("efi_fake_mem", setup_fake_mem);
+
+void __init efi_fake_memmap_early(void)
+{
+	int i;
+
+	/*
+	 * The late efi_fake_mem() call can handle all requests if
+	 * EFI_MEMORY_SP support is disabled.
+	 */
+	if (!efi_soft_reserve_enabled())
+		return;
+
+	if (!efi_enabled(EFI_MEMMAP) || !nr_fake_mem)
+		return;
+
+	/*
+	 * Given that efi_fake_memmap() needs to perform memblock
+	 * allocations it needs to run after e820__memblock_setup().
+	 * However, if efi_fake_mem specifies EFI_MEMORY_SP for a given
+	 * address range that potentially needs to mark the memory as
+	 * reserved prior to e820__memblock_setup(). Update e820
+	 * directly if EFI_MEMORY_SP is specified for an
+	 * EFI_CONVENTIONAL_MEMORY descriptor.
+	 */
+	for (i = 0; i < nr_fake_mem; i++) {
+		struct efi_mem_range *mem = &efi_fake_mems[i];
+		efi_memory_desc_t *md;
+		u64 m_start, m_end;
+
+		if ((mem->attribute & EFI_MEMORY_SP) == 0)
+			continue;
+
+		m_start = mem->range.start;
+		m_end = mem->range.end;
+		for_each_efi_memory_desc(md) {
+			u64 start, end, size;
+
+			if (md->type != EFI_CONVENTIONAL_MEMORY)
+				continue;
+
+			start = md->phys_addr;
+			end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+
+			if (m_start <= end && m_end >= start)
+				/* fake range overlaps descriptor */;
+			else
+				continue;
+
+			/*
+			 * Trim the boundary of the e820 update to the
+			 * descriptor in case the fake range overlaps
+			 * !EFI_CONVENTIONAL_MEMORY
+			 */
+			start = max(start, m_start);
+			end = min(end, m_end);
+			size = end - start + 1;
+
+			if (end <= start)
+				continue;
+
+			/*
+			 * Ensure each efi_fake_mem instance results in
+			 * a unique e820 resource
+			 */
+			e820__range_remove(start, size, E820_TYPE_RAM, 1);
+			e820__range_add(start, size, E820_TYPE_SOFT_RESERVED);
+			e820__update_table(e820_table);
+		}
+	}
+}
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 4f7e65293297..fceeea74522e 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -37,28 +37,6 @@ config EFI_RUNTIME_MAP
 
 	  See also Documentation/ABI/testing/sysfs-firmware-efi-runtime-map.
 
-config EFI_FAKE_MEMMAP
-	bool "Enable EFI fake memory map"
-	depends on EFI && X86
-	default n
-	help
-	  Saying Y here will enable "efi_fake_mem" boot option.
-	  By specifying this parameter, you can add arbitrary attribute
-	  to specific memory range by updating original (firmware provided)
-	  EFI memmap.
-	  This is useful for debugging of EFI memmap related feature.
-	  e.g. Address Range Mirroring feature.
-
-config EFI_MAX_FAKE_MEM
-	int "maximum allowable number of ranges in efi_fake_mem boot option"
-	depends on EFI_FAKE_MEMMAP
-	range 1 128
-	default 8
-	help
-	  Maximum allowable number of ranges in efi_fake_mem boot option.
-	  Ranges can be set up to this value using comma-separated list.
-	  The default value is 8.
-
 config EFI_SOFT_RESERVE
 	bool "Reserve EFI Specific Purpose Memory"
 	depends on EFI && EFI_STUB && ACPI_HMAT
diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
index 8d151e332584..8e4f0d5b26e5 100644
--- a/drivers/firmware/efi/Makefile
+++ b/drivers/firmware/efi/Makefile
@@ -23,7 +23,6 @@ obj-$(CONFIG_UEFI_CPER)			+= cper.o
 obj-$(CONFIG_EFI_RUNTIME_MAP)		+= runtime-map.o
 obj-$(CONFIG_EFI_RUNTIME_WRAPPERS)	+= runtime-wrappers.o
 subdir-$(CONFIG_EFI_STUB)		+= libstub
-obj-$(CONFIG_EFI_FAKE_MEMMAP)		+= fake_map.o
 obj-$(CONFIG_EFI_BOOTLOADER_CONTROL)	+= efibc.o
 obj-$(CONFIG_EFI_TEST)			+= test/
 obj-$(CONFIG_EFI_DEV_PATH_PARSER)	+= dev-path-parser.o
@@ -32,9 +31,6 @@ obj-$(CONFIG_EFI_RCI2_TABLE)		+= rci2-table.o
 obj-$(CONFIG_EFI_EMBEDDED_FIRMWARE)	+= embedded-firmware.o
 obj-$(CONFIG_LOAD_UEFI_KEYS)		+= mokvar-table.o
 
-fake_map-y				+= fake_mem.o
-fake_map-$(CONFIG_X86)			+= x86_fake_mem.o
-
 obj-$(CONFIG_SYSFB)			+= sysfb_efi.o
 
 arm-obj-$(CONFIG_EFI)			:= efi-init.o arm-runtime.o
diff --git a/drivers/firmware/efi/fake_mem.h b/drivers/firmware/efi/fake_mem.h
deleted file mode 100644
index d52791af4b18..000000000000
--- a/drivers/firmware/efi/fake_mem.h
+++ /dev/null
@@ -1,10 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __EFI_FAKE_MEM_H__
-#define __EFI_FAKE_MEM_H__
-#include <asm/efi.h>
-
-#define EFI_MAX_FAKEMEM CONFIG_EFI_MAX_FAKE_MEM
-
-extern struct efi_mem_range efi_fake_mems[EFI_MAX_FAKEMEM];
-extern int nr_fake_mem;
-#endif /* __EFI_FAKE_MEM_H__ */
diff --git a/drivers/firmware/efi/x86_fake_mem.c b/drivers/firmware/efi/x86_fake_mem.c
deleted file mode 100644
index 0bafcc1bb0f6..000000000000
--- a/drivers/firmware/efi/x86_fake_mem.c
+++ /dev/null
@@ -1,75 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Copyright(c) 2019 Intel Corporation. All rights reserved. */
-#include <linux/efi.h>
-#include <asm/e820/api.h>
-#include "fake_mem.h"
-
-void __init efi_fake_memmap_early(void)
-{
-	int i;
-
-	/*
-	 * The late efi_fake_mem() call can handle all requests if
-	 * EFI_MEMORY_SP support is disabled.
-	 */
-	if (!efi_soft_reserve_enabled())
-		return;
-
-	if (!efi_enabled(EFI_MEMMAP) || !nr_fake_mem)
-		return;
-
-	/*
-	 * Given that efi_fake_memmap() needs to perform memblock
-	 * allocations it needs to run after e820__memblock_setup().
-	 * However, if efi_fake_mem specifies EFI_MEMORY_SP for a given
-	 * address range that potentially needs to mark the memory as
-	 * reserved prior to e820__memblock_setup(). Update e820
-	 * directly if EFI_MEMORY_SP is specified for an
-	 * EFI_CONVENTIONAL_MEMORY descriptor.
-	 */
-	for (i = 0; i < nr_fake_mem; i++) {
-		struct efi_mem_range *mem = &efi_fake_mems[i];
-		efi_memory_desc_t *md;
-		u64 m_start, m_end;
-
-		if ((mem->attribute & EFI_MEMORY_SP) == 0)
-			continue;
-
-		m_start = mem->range.start;
-		m_end = mem->range.end;
-		for_each_efi_memory_desc(md) {
-			u64 start, end, size;
-
-			if (md->type != EFI_CONVENTIONAL_MEMORY)
-				continue;
-
-			start = md->phys_addr;
-			end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
-
-			if (m_start <= end && m_end >= start)
-				/* fake range overlaps descriptor */;
-			else
-				continue;
-
-			/*
-			 * Trim the boundary of the e820 update to the
-			 * descriptor in case the fake range overlaps
-			 * !EFI_CONVENTIONAL_MEMORY
-			 */
-			start = max(start, m_start);
-			end = min(end, m_end);
-			size = end - start + 1;
-
-			if (end <= start)
-				continue;
-
-			/*
-			 * Ensure each efi_fake_mem instance results in
-			 * a unique e820 resource
-			 */
-			e820__range_remove(start, size, E820_TYPE_RAM, 1);
-			e820__range_add(start, size, E820_TYPE_SOFT_RESERVED);
-			e820__update_table(e820_table);
-		}
-	}
-}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index e739196ce9b2..a6dbf354d2c3 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -749,12 +749,6 @@ extern struct kobject *efi_kobj;
 extern int efi_reboot_quirk_mode;
 extern bool efi_poweroff_required(void);
 
-#ifdef CONFIG_EFI_FAKE_MEMMAP
-extern void __init efi_fake_memmap(void);
-#else
-static inline void efi_fake_memmap(void) { }
-#endif
-
 extern unsigned long efi_mem_attr_table;
 
 /*
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414817.659214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJan-0004NB-1T; Mon, 03 Oct 2022 11:26:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414817.659214; Mon, 03 Oct 2022 11:26:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJam-0004N4-V1; Mon, 03 Oct 2022 11:26:36 +0000
Received: by outflank-mailman (input) for mailman id 414817;
 Mon, 03 Oct 2022 11:26:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJal-0004My-3V
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:35 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b9110f2-430e-11ed-9376-c1cf23e5d27e;
 Mon, 03 Oct 2022 13:26:33 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id E85A560F2F;
 Mon,  3 Oct 2022 11:26:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEFAFC433C1;
 Mon,  3 Oct 2022 11:26:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b9110f2-430e-11ed-9376-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796391;
	bh=wDKdvPqZk8WFP3BSEQAf+e1kb18kQtYKCBG/O7eLNv0=;
	h=From:To:Cc:Subject:Date:From;
	b=Ox1XEvSG5hre/gdrN8BcIEz5750FiEiwpqaTtH1yliO3nlxMWBlgLqBEP5e+DE03L
	 v90fR6LmgX3pmCD68wFhPw52XWpwjN7AtUxY/C6T4OhaC8IJ7mueTOxoRBhZV/bjZR
	 sHBJWb+xThSAUWMBUTBo5yCKmmhJVcaj5//6OJTiylgOZijQg6dDnDR870yDZP9vBB
	 EruxTPvCJNuxS6rbfAntaK3i3lBF39S9Os1oFxTvGF5x4pw9HvXPUU3lt21bb+9qTz
	 Qx0AFO/N5h0m9LJK2DUJq00+LzV7T56zwOTzist88UVsTx36ao1RaGFe73f0SaPDPL
	 /6joHonQhT0qA==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 0/6] efi/x86: Avoid corrupted config tables under Xen
Date: Mon,  3 Oct 2022 13:26:19 +0200
Message-Id: <20221003112625.972646-1-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=4415; i=ardb@kernel.org; h=from:subject; bh=wDKdvPqZk8WFP3BSEQAf+e1kb18kQtYKCBG/O7eLNv0=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbUkV47vOIBB1yBzipVxR5+t08QxSlOcR7wO8t8 rB2jnJ2JAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG1AAKCRDDTyI5ktmPJKXNC/ 4rqTC55/+RKNpsaZYCqdCfNe63UwVnTnjPbkbRZpnd1HZHDobN5uCK/Scgvs1lJzCwy9sP1/m2E5Yg L3ODc9VWyIAzw+23tHHYjh5y0f0s0uz3ZeKAFvZfijcuVHQxcMRPnyLZ9Rw9swyA7MFn62CZEiPO7n Yzp7ZfSMNgn2C9PbztvXbT8wOVpZTbOqcSpAZ3aEUc4qJmvcAYyAnGGAa11f9lGbyvqWUjXAWPxraA VgHZktlLipkXG/fUbz0pvIKd52bSamLGC781kUr2w6hntbI/gVpr2VUuMYhAkn2gUxMvSYkLEhKSgA Qa1DdsFZiJODc41MuBwKn/oLwWKO4gmpMwdvpFx6Lv5BMTFMa3aYH9aPX9+aWeHrbNCt4RYX8X3mLa lyV4lr0XPQFHKhLvMnq5QO3tLe/y+etF1IsUkc2fA0kk0lfhcnKjB8j3Dhl8pq6vC8DiN/4CwIMeBe T4lYzxP2oKyxRfFUOf9CX/QhXswyXc9139KispRVezaqw=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is an alternate approach to addressing the issue that Demi Marie is
attempting to fix in [0] (i.e., ESRT config table exposed to a x86 dom0
is corrupted because it resides in boot services memory as per the EFI
spec, where it gets corrupted by Xen). My main objection to that approach
is that it needs Xen-specific fixes in multiple different places, but we
still end up only fixing the ESRT case specifically.

So instead, I am proposing this series as a more generic way to handle
configuration tables that reside in boot services memory, and confining
the Xen specific logic to the Xen EFI glue code.

Given that EFI boot without a memory map is only permitted on x86 and
only when doing Xen boot, let's clear up some inconsistencies there
first so we can set the EFI_PARAVIRT flag on all architectures that do
pseudo-EFI boot straight into the core kernel (i.e., without going
through the stub). This moves a good chunk of EFI memory map
manipulation code into the x86 arch tree, where it arguably belongs as
no other architectures rely on it. This is implemented in patches 1 - 3.

Patch #4 refactors the ESRT sanity checks on the memory descriptor, by
moving them into the efi_mem_desc_lookup() helper, which should not
return corrupted descriptors in the first place.

Patch #5 adds a Xen hypercall fallback to efi_mem_desc_lookup() when
running under Xen without a EFI memory map, so that, e.g., the existing
ESRT code will perform its validation against the Xen provided
descriptor if no memory map is available.

Patch #6 updates the config table traversal code so that the Xen glue
code can force them to be disregarded, which happens when the table in
question points into a memory region that is not of a type that Xen
automatically reserves. Future changes can refine this logic if needed.

Changes since v1:
- add patch #4
- move Xen descriptor lookup into efi_mem_desc_lookup()
- drop allowlist for ACPI and SMBIOS tables

[0] https://lore.kernel.org/all/cover.1664298147.git.demi@invisiblethingslab.com/

Cc: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Peter Jones <pjones@redhat.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Ard Biesheuvel (6):
  efi: Move EFI fake memmap support into x86 arch tree
  efi: memmap: Move manipulation routines into x86 arch tree
  efi: xen: Set EFI_PARAVIRT for Xen dom0 boot on all architectures
  efi: memmap: Disregard bogus entries instead of returning them
  efi: xen: Implement memory descriptor lookup based on hypercall
  efi: Apply allowlist to EFI configuration tables when running under
    Xen

 arch/x86/Kconfig                                       |  20 ++
 arch/x86/include/asm/efi.h                             |  16 ++
 arch/x86/kernel/setup.c                                |   1 +
 arch/x86/platform/efi/Makefile                         |   4 +-
 arch/x86/platform/efi/efi.c                            |   8 +-
 {drivers/firmware => arch/x86/platform}/efi/fake_mem.c |  79 ++++++-
 arch/x86/platform/efi/memmap.c                         | 238 ++++++++++++++++++++
 drivers/firmware/efi/Kconfig                           |  22 --
 drivers/firmware/efi/Makefile                          |   4 -
 drivers/firmware/efi/efi.c                             |  25 +-
 drivers/firmware/efi/esrt.c                            |  18 +-
 drivers/firmware/efi/fake_mem.h                        |  10 -
 drivers/firmware/efi/fdtparams.c                       |   4 +
 drivers/firmware/efi/memmap.c                          | 224 +-----------------
 drivers/firmware/efi/x86_fake_mem.c                    |  75 ------
 drivers/xen/efi.c                                      |  58 +++++
 include/linux/efi.h                                    |  19 +-
 17 files changed, 446 insertions(+), 379 deletions(-)
 rename {drivers/firmware => arch/x86/platform}/efi/fake_mem.c (58%)
 create mode 100644 arch/x86/platform/efi/memmap.c
 delete mode 100644 drivers/firmware/efi/fake_mem.h
 delete mode 100644 drivers/firmware/efi/x86_fake_mem.c

-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414819.659236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJar-0004uz-Ng; Mon, 03 Oct 2022 11:26:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414819.659236; Mon, 03 Oct 2022 11:26:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJar-0004uq-Ka; Mon, 03 Oct 2022 11:26:41 +0000
Received: by outflank-mailman (input) for mailman id 414819;
 Mon, 03 Oct 2022 11:26:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJaq-0004Xj-Ht
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:40 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f54293b-430e-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 13:26:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 90BAEB80D9D;
 Mon,  3 Oct 2022 11:26:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF3ECC4347C;
 Mon,  3 Oct 2022 11:26:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f54293b-430e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796397;
	bh=ZjDr14OxWTrew0/fwyFI+XUBboCoGDstHicLfif2Djw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=TxY/bRfjhtxLaZp+RLCj8LsBeH7rHezBCOV0B0BosD9Voq51KCp6mICHNQZ5Ug4lI
	 fukIwRaNQit/mbut/F+dmvt07Pbuanyh5ido7DTpsVSXiX/SGgnxx7OyTPsF1lxU2W
	 WJ2FQ4K0Bf2lg64zbnlGBEWb8U/xZkt5fxKrmmmedFuW2CY2PpZIlZwR54Zse2l6kV
	 wd6LXmtYDCLfh7Zd+voJ6uPiUqaHhylCrSUSomr0erOhQTtmUnvFvzLr1MmVyoMJwi
	 bJF8A1MWl8fxpuXoc7j2iCZnP2pZmVJy8Uw4cYU25gqBrSZj9i5tQlem3iuh5mTo5j
	 SPvnR6hX5M1jA==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 2/6] efi: memmap: Move manipulation routines into x86 arch tree
Date: Mon,  3 Oct 2022 13:26:21 +0200
Message-Id: <20221003112625.972646-3-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221003112625.972646-1-ardb@kernel.org>
References: <20221003112625.972646-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=17368; i=ardb@kernel.org; h=from:subject; bh=ZjDr14OxWTrew0/fwyFI+XUBboCoGDstHicLfif2Djw=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbYg6dqX0FgOlAp0B3+vbe93/8K1X6EJXBcxSer Yrj6+geJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG2AAKCRDDTyI5ktmPJP2YC/ 9WT0L6a3hxPwo9zokLU/i5YXQBAxRuRvN1iiXsD2aWDn0MhaURJXR3BtmTvAOwnKdqu5D3aHBk8VZC zjpzyBOyo/dufs4+tx0LAO8RBRUU8VSHa0/UlkIG8xJXui8s2LcA/EF4ym62OyVqD5f4N+KtKVo9wL BWW+axOJ1KnRj2Su2S8XYoK4Wn0DRaUQJsfAKAmZZnRBe+gE2hXrv71b3zQErfaGF/eSOKWncDym8+ 7LKamaAPo1+dWZP7QZyURbypNI03XyQb4AuE8cUlDjqDVNrZORmTubs2PZqrkj9febHXtteZYEKuCH nr4mvsF0o+VDcOcmY5/ZMWlAjdEgQBopSt514lEBdVphFBuqoa3OA1FIbZhDUnjfOAzlY2QhWVnOrM msyBu3Wnb8obJtr7j2lbmyS48g/Mi7qTNJZa59ZzYW3J0QrwSDAGnfSke2ax4D7ayknBRkBIOq5KKC ZEahyULh4jtcvHic9eggO6E77OtHGkgR4/Ht1dgz/4bfA=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

The EFI memory map is a description of the memory layout as provided by
the firmware, and only x86 manipulates it in various different ways for
its own memory bookkeeping. So let's move the memmap routines that are
only used by x86 into the x86 arch tree.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/include/asm/efi.h     |  11 +
 arch/x86/platform/efi/Makefile |   3 +-
 arch/x86/platform/efi/memmap.c | 235 ++++++++++++++++++++
 drivers/firmware/efi/memmap.c  | 221 +-----------------
 include/linux/efi.h            |  10 +-
 5 files changed, 251 insertions(+), 229 deletions(-)

diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
index 68414d924332..1fb4686f3d12 100644
--- a/arch/x86/include/asm/efi.h
+++ b/arch/x86/include/asm/efi.h
@@ -415,6 +415,17 @@ static inline void efi_fake_memmap(void)
 }
 #endif
 
+extern int __init efi_memmap_alloc(unsigned int num_entries,
+				   struct efi_memory_map_data *data);
+extern void __efi_memmap_free(u64 phys, unsigned long size,
+			      unsigned long flags);
+
+extern int __init efi_memmap_install(struct efi_memory_map_data *data);
+extern int __init efi_memmap_split_count(efi_memory_desc_t *md,
+					 struct range *range);
+extern void __init efi_memmap_insert(struct efi_memory_map *old_memmap,
+				     void *buf, struct efi_mem_range *mem);
+
 #define arch_ima_efi_boot_mode	\
 	({ extern struct boot_params boot_params; boot_params.secure_boot; })
 
diff --git a/arch/x86/platform/efi/Makefile b/arch/x86/platform/efi/Makefile
index b481719b16cc..ed5502a5185d 100644
--- a/arch/x86/platform/efi/Makefile
+++ b/arch/x86/platform/efi/Makefile
@@ -2,6 +2,7 @@
 KASAN_SANITIZE := n
 GCOV_PROFILE := n
 
-obj-$(CONFIG_EFI) 		+= quirks.o efi.o efi_$(BITS).o efi_stub_$(BITS).o
+obj-$(CONFIG_EFI) 		+= memmap.o quirks.o efi.o efi_$(BITS).o \
+				   efi_stub_$(BITS).o
 obj-$(CONFIG_EFI_MIXED)		+= efi_thunk_$(BITS).o
 obj-$(CONFIG_EFI_FAKE_MEMMAP)	+= fake_mem.o
diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c
new file mode 100644
index 000000000000..44b886acf301
--- /dev/null
+++ b/arch/x86/platform/efi/memmap.c
@@ -0,0 +1,235 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Common EFI memory map functions.
+ */
+
+#define pr_fmt(fmt) "efi: " fmt
+
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/efi.h>
+#include <linux/io.h>
+#include <asm/early_ioremap.h>
+#include <linux/memblock.h>
+#include <linux/slab.h>
+
+static phys_addr_t __init __efi_memmap_alloc_early(unsigned long size)
+{
+	return memblock_phys_alloc(size, SMP_CACHE_BYTES);
+}
+
+static phys_addr_t __init __efi_memmap_alloc_late(unsigned long size)
+{
+	unsigned int order = get_order(size);
+	struct page *p = alloc_pages(GFP_KERNEL, order);
+
+	if (!p)
+		return 0;
+
+	return PFN_PHYS(page_to_pfn(p));
+}
+
+void __init __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
+{
+	if (flags & EFI_MEMMAP_MEMBLOCK) {
+		if (slab_is_available())
+			memblock_free_late(phys, size);
+		else
+			memblock_phys_free(phys, size);
+	} else if (flags & EFI_MEMMAP_SLAB) {
+		struct page *p = pfn_to_page(PHYS_PFN(phys));
+		unsigned int order = get_order(size);
+
+		free_pages((unsigned long) page_address(p), order);
+	}
+}
+
+/**
+ * efi_memmap_alloc - Allocate memory for the EFI memory map
+ * @num_entries: Number of entries in the allocated map.
+ * @data: efi memmap installation parameters
+ *
+ * Depending on whether mm_init() has already been invoked or not,
+ * either memblock or "normal" page allocation is used.
+ *
+ * Returns zero on success, a negative error code on failure.
+ */
+int __init efi_memmap_alloc(unsigned int num_entries,
+		struct efi_memory_map_data *data)
+{
+	/* Expect allocation parameters are zero initialized */
+	WARN_ON(data->phys_map || data->size);
+
+	data->size = num_entries * efi.memmap.desc_size;
+	data->desc_version = efi.memmap.desc_version;
+	data->desc_size = efi.memmap.desc_size;
+	data->flags &= ~(EFI_MEMMAP_SLAB | EFI_MEMMAP_MEMBLOCK);
+	data->flags |= efi.memmap.flags & EFI_MEMMAP_LATE;
+
+	if (slab_is_available()) {
+		data->flags |= EFI_MEMMAP_SLAB;
+		data->phys_map = __efi_memmap_alloc_late(data->size);
+	} else {
+		data->flags |= EFI_MEMMAP_MEMBLOCK;
+		data->phys_map = __efi_memmap_alloc_early(data->size);
+	}
+
+	if (!data->phys_map)
+		return -ENOMEM;
+	return 0;
+}
+
+/**
+ * efi_memmap_install - Install a new EFI memory map in efi.memmap
+ * @ctx: map allocation parameters (address, size, flags)
+ *
+ * Unlike efi_memmap_init_*(), this function does not allow the caller
+ * to switch from early to late mappings. It simply uses the existing
+ * mapping function and installs the new memmap.
+ *
+ * Returns zero on success, a negative error code on failure.
+ */
+int __init efi_memmap_install(struct efi_memory_map_data *data)
+{
+	efi_memmap_unmap();
+
+	return __efi_memmap_init(data);
+}
+
+/**
+ * efi_memmap_split_count - Count number of additional EFI memmap entries
+ * @md: EFI memory descriptor to split
+ * @range: Address range (start, end) to split around
+ *
+ * Returns the number of additional EFI memmap entries required to
+ * accommodate @range.
+ */
+int __init efi_memmap_split_count(efi_memory_desc_t *md, struct range *range)
+{
+	u64 m_start, m_end;
+	u64 start, end;
+	int count = 0;
+
+	start = md->phys_addr;
+	end = start + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+
+	/* modifying range */
+	m_start = range->start;
+	m_end = range->end;
+
+	if (m_start <= start) {
+		/* split into 2 parts */
+		if (start < m_end && m_end < end)
+			count++;
+	}
+
+	if (start < m_start && m_start < end) {
+		/* split into 3 parts */
+		if (m_end < end)
+			count += 2;
+		/* split into 2 parts */
+		if (end <= m_end)
+			count++;
+	}
+
+	return count;
+}
+
+/**
+ * efi_memmap_insert - Insert a memory region in an EFI memmap
+ * @old_memmap: The existing EFI memory map structure
+ * @buf: Address of buffer to store new map
+ * @mem: Memory map entry to insert
+ *
+ * It is suggested that you call efi_memmap_split_count() first
+ * to see how large @buf needs to be.
+ */
+void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf,
+			      struct efi_mem_range *mem)
+{
+	u64 m_start, m_end, m_attr;
+	efi_memory_desc_t *md;
+	u64 start, end;
+	void *old, *new;
+
+	/* modifying range */
+	m_start = mem->range.start;
+	m_end = mem->range.end;
+	m_attr = mem->attribute;
+
+	/*
+	 * The EFI memory map deals with regions in EFI_PAGE_SIZE
+	 * units. Ensure that the region described by 'mem' is aligned
+	 * correctly.
+	 */
+	if (!IS_ALIGNED(m_start, EFI_PAGE_SIZE) ||
+	    !IS_ALIGNED(m_end + 1, EFI_PAGE_SIZE)) {
+		WARN_ON(1);
+		return;
+	}
+
+	for (old = old_memmap->map, new = buf;
+	     old < old_memmap->map_end;
+	     old += old_memmap->desc_size, new += old_memmap->desc_size) {
+
+		/* copy original EFI memory descriptor */
+		memcpy(new, old, old_memmap->desc_size);
+		md = new;
+		start = md->phys_addr;
+		end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+
+		if (m_start <= start && end <= m_end)
+			md->attribute |= m_attr;
+
+		if (m_start <= start &&
+		    (start < m_end && m_end < end)) {
+			/* first part */
+			md->attribute |= m_attr;
+			md->num_pages = (m_end - md->phys_addr + 1) >>
+				EFI_PAGE_SHIFT;
+			/* latter part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->phys_addr = m_end + 1;
+			md->num_pages = (end - md->phys_addr + 1) >>
+				EFI_PAGE_SHIFT;
+		}
+
+		if ((start < m_start && m_start < end) && m_end < end) {
+			/* first part */
+			md->num_pages = (m_start - md->phys_addr) >>
+				EFI_PAGE_SHIFT;
+			/* middle part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->attribute |= m_attr;
+			md->phys_addr = m_start;
+			md->num_pages = (m_end - m_start + 1) >>
+				EFI_PAGE_SHIFT;
+			/* last part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->phys_addr = m_end + 1;
+			md->num_pages = (end - m_end) >>
+				EFI_PAGE_SHIFT;
+		}
+
+		if ((start < m_start && m_start < end) &&
+		    (end <= m_end)) {
+			/* first part */
+			md->num_pages = (m_start - md->phys_addr) >>
+				EFI_PAGE_SHIFT;
+			/* latter part */
+			new += old_memmap->desc_size;
+			memcpy(new, old, old_memmap->desc_size);
+			md = new;
+			md->phys_addr = m_start;
+			md->num_pages = (end - md->phys_addr + 1) >>
+				EFI_PAGE_SHIFT;
+			md->attribute |= m_attr;
+		}
+	}
+}
diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c
index 6ec7970dbd40..3501d3814f22 100644
--- a/drivers/firmware/efi/memmap.c
+++ b/drivers/firmware/efi/memmap.c
@@ -13,35 +13,8 @@
 #include <linux/memblock.h>
 #include <linux/slab.h>
 
-static phys_addr_t __init __efi_memmap_alloc_early(unsigned long size)
+void __weak __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
 {
-	return memblock_phys_alloc(size, SMP_CACHE_BYTES);
-}
-
-static phys_addr_t __init __efi_memmap_alloc_late(unsigned long size)
-{
-	unsigned int order = get_order(size);
-	struct page *p = alloc_pages(GFP_KERNEL, order);
-
-	if (!p)
-		return 0;
-
-	return PFN_PHYS(page_to_pfn(p));
-}
-
-void __init __efi_memmap_free(u64 phys, unsigned long size, unsigned long flags)
-{
-	if (flags & EFI_MEMMAP_MEMBLOCK) {
-		if (slab_is_available())
-			memblock_free_late(phys, size);
-		else
-			memblock_phys_free(phys, size);
-	} else if (flags & EFI_MEMMAP_SLAB) {
-		struct page *p = pfn_to_page(PHYS_PFN(phys));
-		unsigned int order = get_order(size);
-
-		free_pages((unsigned long) page_address(p), order);
-	}
 }
 
 static void __init efi_memmap_free(void)
@@ -51,41 +24,6 @@ static void __init efi_memmap_free(void)
 			efi.memmap.flags);
 }
 
-/**
- * efi_memmap_alloc - Allocate memory for the EFI memory map
- * @num_entries: Number of entries in the allocated map.
- * @data: efi memmap installation parameters
- *
- * Depending on whether mm_init() has already been invoked or not,
- * either memblock or "normal" page allocation is used.
- *
- * Returns zero on success, a negative error code on failure.
- */
-int __init efi_memmap_alloc(unsigned int num_entries,
-		struct efi_memory_map_data *data)
-{
-	/* Expect allocation parameters are zero initialized */
-	WARN_ON(data->phys_map || data->size);
-
-	data->size = num_entries * efi.memmap.desc_size;
-	data->desc_version = efi.memmap.desc_version;
-	data->desc_size = efi.memmap.desc_size;
-	data->flags &= ~(EFI_MEMMAP_SLAB | EFI_MEMMAP_MEMBLOCK);
-	data->flags |= efi.memmap.flags & EFI_MEMMAP_LATE;
-
-	if (slab_is_available()) {
-		data->flags |= EFI_MEMMAP_SLAB;
-		data->phys_map = __efi_memmap_alloc_late(data->size);
-	} else {
-		data->flags |= EFI_MEMMAP_MEMBLOCK;
-		data->phys_map = __efi_memmap_alloc_early(data->size);
-	}
-
-	if (!data->phys_map)
-		return -ENOMEM;
-	return 0;
-}
-
 /**
  * __efi_memmap_init - Common code for mapping the EFI memory map
  * @data: EFI memory map data
@@ -101,7 +39,7 @@ int __init efi_memmap_alloc(unsigned int num_entries,
  *
  * Returns zero on success, a negative error code on failure.
  */
-static int __init __efi_memmap_init(struct efi_memory_map_data *data)
+int __init __efi_memmap_init(struct efi_memory_map_data *data)
 {
 	struct efi_memory_map map;
 	phys_addr_t phys_map;
@@ -220,158 +158,3 @@ int __init efi_memmap_init_late(phys_addr_t addr, unsigned long size)
 
 	return __efi_memmap_init(&data);
 }
-
-/**
- * efi_memmap_install - Install a new EFI memory map in efi.memmap
- * @ctx: map allocation parameters (address, size, flags)
- *
- * Unlike efi_memmap_init_*(), this function does not allow the caller
- * to switch from early to late mappings. It simply uses the existing
- * mapping function and installs the new memmap.
- *
- * Returns zero on success, a negative error code on failure.
- */
-int __init efi_memmap_install(struct efi_memory_map_data *data)
-{
-	efi_memmap_unmap();
-
-	return __efi_memmap_init(data);
-}
-
-/**
- * efi_memmap_split_count - Count number of additional EFI memmap entries
- * @md: EFI memory descriptor to split
- * @range: Address range (start, end) to split around
- *
- * Returns the number of additional EFI memmap entries required to
- * accommodate @range.
- */
-int __init efi_memmap_split_count(efi_memory_desc_t *md, struct range *range)
-{
-	u64 m_start, m_end;
-	u64 start, end;
-	int count = 0;
-
-	start = md->phys_addr;
-	end = start + (md->num_pages << EFI_PAGE_SHIFT) - 1;
-
-	/* modifying range */
-	m_start = range->start;
-	m_end = range->end;
-
-	if (m_start <= start) {
-		/* split into 2 parts */
-		if (start < m_end && m_end < end)
-			count++;
-	}
-
-	if (start < m_start && m_start < end) {
-		/* split into 3 parts */
-		if (m_end < end)
-			count += 2;
-		/* split into 2 parts */
-		if (end <= m_end)
-			count++;
-	}
-
-	return count;
-}
-
-/**
- * efi_memmap_insert - Insert a memory region in an EFI memmap
- * @old_memmap: The existing EFI memory map structure
- * @buf: Address of buffer to store new map
- * @mem: Memory map entry to insert
- *
- * It is suggested that you call efi_memmap_split_count() first
- * to see how large @buf needs to be.
- */
-void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf,
-			      struct efi_mem_range *mem)
-{
-	u64 m_start, m_end, m_attr;
-	efi_memory_desc_t *md;
-	u64 start, end;
-	void *old, *new;
-
-	/* modifying range */
-	m_start = mem->range.start;
-	m_end = mem->range.end;
-	m_attr = mem->attribute;
-
-	/*
-	 * The EFI memory map deals with regions in EFI_PAGE_SIZE
-	 * units. Ensure that the region described by 'mem' is aligned
-	 * correctly.
-	 */
-	if (!IS_ALIGNED(m_start, EFI_PAGE_SIZE) ||
-	    !IS_ALIGNED(m_end + 1, EFI_PAGE_SIZE)) {
-		WARN_ON(1);
-		return;
-	}
-
-	for (old = old_memmap->map, new = buf;
-	     old < old_memmap->map_end;
-	     old += old_memmap->desc_size, new += old_memmap->desc_size) {
-
-		/* copy original EFI memory descriptor */
-		memcpy(new, old, old_memmap->desc_size);
-		md = new;
-		start = md->phys_addr;
-		end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
-
-		if (m_start <= start && end <= m_end)
-			md->attribute |= m_attr;
-
-		if (m_start <= start &&
-		    (start < m_end && m_end < end)) {
-			/* first part */
-			md->attribute |= m_attr;
-			md->num_pages = (m_end - md->phys_addr + 1) >>
-				EFI_PAGE_SHIFT;
-			/* latter part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->phys_addr = m_end + 1;
-			md->num_pages = (end - md->phys_addr + 1) >>
-				EFI_PAGE_SHIFT;
-		}
-
-		if ((start < m_start && m_start < end) && m_end < end) {
-			/* first part */
-			md->num_pages = (m_start - md->phys_addr) >>
-				EFI_PAGE_SHIFT;
-			/* middle part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->attribute |= m_attr;
-			md->phys_addr = m_start;
-			md->num_pages = (m_end - m_start + 1) >>
-				EFI_PAGE_SHIFT;
-			/* last part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->phys_addr = m_end + 1;
-			md->num_pages = (end - m_end) >>
-				EFI_PAGE_SHIFT;
-		}
-
-		if ((start < m_start && m_start < end) &&
-		    (end <= m_end)) {
-			/* first part */
-			md->num_pages = (m_start - md->phys_addr) >>
-				EFI_PAGE_SHIFT;
-			/* latter part */
-			new += old_memmap->desc_size;
-			memcpy(new, old, old_memmap->desc_size);
-			md = new;
-			md->phys_addr = m_start;
-			md->num_pages = (end - md->phys_addr + 1) >>
-				EFI_PAGE_SHIFT;
-			md->attribute |= m_attr;
-		}
-	}
-}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index a6dbf354d2c3..256e70e42114 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -707,18 +707,10 @@ static inline efi_status_t efi_query_variable_store(u32 attributes,
 #endif
 extern void __iomem *efi_lookup_mapped_addr(u64 phys_addr);
 
-extern int __init efi_memmap_alloc(unsigned int num_entries,
-				   struct efi_memory_map_data *data);
-extern void __efi_memmap_free(u64 phys, unsigned long size,
-			      unsigned long flags);
+extern int __init __efi_memmap_init(struct efi_memory_map_data *data);
 extern int __init efi_memmap_init_early(struct efi_memory_map_data *data);
 extern int __init efi_memmap_init_late(phys_addr_t addr, unsigned long size);
 extern void __init efi_memmap_unmap(void);
-extern int __init efi_memmap_install(struct efi_memory_map_data *data);
-extern int __init efi_memmap_split_count(efi_memory_desc_t *md,
-					 struct range *range);
-extern void __init efi_memmap_insert(struct efi_memory_map *old_memmap,
-				     void *buf, struct efi_mem_range *mem);
 
 #ifdef CONFIG_EFI_ESRT
 extern void __init efi_esrt_init(void);
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414820.659247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJau-0005DH-1H; Mon, 03 Oct 2022 11:26:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414820.659247; Mon, 03 Oct 2022 11:26:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJat-0005D5-Sw; Mon, 03 Oct 2022 11:26:43 +0000
Received: by outflank-mailman (input) for mailman id 414820;
 Mon, 03 Oct 2022 11:26:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJas-0004Xj-JL
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40f7b3c9-430e-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 13:26:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7A83EB8105D;
 Mon,  3 Oct 2022 11:26:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C25F8C433B5;
 Mon,  3 Oct 2022 11:26:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40f7b3c9-430e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796400;
	bh=naWVhxVJzgFHTYyzbP8aferDZudNO8L5WZJcvq28kz8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=BNiDIoSRsqO6SP/YjvMUB6npIWVImtY4mWHh4pvmCWYVqDtQtuHY5bBr3jdPo2inm
	 /WfRwXzUvzpvHSn/RH0owMjbn2jYGvoOcszGqXzM65/xpvJ1CLY2fs+srTkOMfQA0m
	 Sl4u0VnyhkuQL3/G7xKroOexeRf06KCKag0XxURSv3xsxamdKMNHzmM7rxbviila7s
	 0FIMpSBAkDd5YR34wQT5Q+v8Tg8V+HoYB7AB88iHGrBIGoj6XXykMrvBJDF6/Gqlcb
	 kOGtDYhRAeA50gW7pjYE1OY7Nfrk3aZFZc7OM6CR6QSgSMD01eoC23/CcBOj+wQff7
	 /mNndy+5mRPWg==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 3/6] efi: xen: Set EFI_PARAVIRT for Xen dom0 boot on all architectures
Date: Mon,  3 Oct 2022 13:26:22 +0200
Message-Id: <20221003112625.972646-4-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221003112625.972646-1-ardb@kernel.org>
References: <20221003112625.972646-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3190; i=ardb@kernel.org; h=from:subject; bh=naWVhxVJzgFHTYyzbP8aferDZudNO8L5WZJcvq28kz8=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbZUImNh+oNISz7kaell7P1ADDK/YsLUV10IJbU Cm3Ms7iJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG2QAKCRDDTyI5ktmPJChlC/ 9o6m0Iy1WpuoP8dAvEJvjXUGENSrHQz1jwTqztxBAtbc7GoxtN2OD7Yo6fcYU1htSLmDa3LtV1LVp9 hzxE4shcSNXWA3qsx0Q7kv9LuimlvTR1oYqnphlO1ArYa7K6Vv1iEw538UOR3DGgXep8hlTrdQWCxu l9S4x9xdNCP5eBLDSnNEnu2RLEwFQztbYxocM2UTZvu6p5ZIrFrZ/v/JFh2hMECJluOfJ78LFVfvLr SWti8jAOjrVPsdyXhwiFGxpgqxcJenX/ugwqvO/Zovirqc/+Saao7vAabuAlj5QxmLa8timHCLfif7 HCZy2GbDBepiQhA3JqrH5ARl1H54OQT5/wEVbwca8DTLe3wpg0gfJ1LTbScvFQhloWWFhfIEYdyYUw tPEZaeKi6iKAP1MQJAXYSb5sVSl5P8d9p/VqtN13bVvy+mf/MgKXmQSL/SOHt6jtDfY8OtqUTHRGMx ZnhVe0pgimwQIeEKMm+MLR2YT26b5k0pqVz0nruFr/1uU=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

Currently, the EFI_PARAVIRT flag is only used by x86, even though other
architectures also support pseudo-EFI boot, where the core kernel is
invoked directly and provided with a set of data tables that resemble
the ones constructed by the EFI stub, which never actually runs in that
case.

Let's fix this inconsistency, and always set this flag when booting dom0
via the EFI boot path. Note that Xen on x86 does not provide the EFI
memory map in this case, whereas other architectures do, so move the
associated EFI_PARAVIRT check into the x86 platform code.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/platform/efi/efi.c      | 8 +++++---
 arch/x86/platform/efi/memmap.c   | 3 +++
 drivers/firmware/efi/fdtparams.c | 4 ++++
 drivers/firmware/efi/memmap.c    | 3 ---
 4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index 6e598bd78eef..6a6f2a585a3d 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -214,9 +214,11 @@ int __init efi_memblock_x86_reserve_range(void)
 	data.desc_size		= e->efi_memdesc_size;
 	data.desc_version	= e->efi_memdesc_version;
 
-	rv = efi_memmap_init_early(&data);
-	if (rv)
-		return rv;
+	if (!efi_enabled(EFI_PARAVIRT)) {
+		rv = efi_memmap_init_early(&data);
+		if (rv)
+			return rv;
+	}
 
 	if (add_efi_memmap || do_efi_soft_reserve())
 		do_add_efi_memmap();
diff --git a/arch/x86/platform/efi/memmap.c b/arch/x86/platform/efi/memmap.c
index 44b886acf301..18e14ec16720 100644
--- a/arch/x86/platform/efi/memmap.c
+++ b/arch/x86/platform/efi/memmap.c
@@ -93,6 +93,9 @@ int __init efi_memmap_install(struct efi_memory_map_data *data)
 {
 	efi_memmap_unmap();
 
+	if (efi_enabled(EFI_PARAVIRT))
+		return 0;
+
 	return __efi_memmap_init(data);
 }
 
diff --git a/drivers/firmware/efi/fdtparams.c b/drivers/firmware/efi/fdtparams.c
index e901f8564ca0..0ec83ba58097 100644
--- a/drivers/firmware/efi/fdtparams.c
+++ b/drivers/firmware/efi/fdtparams.c
@@ -30,11 +30,13 @@ static __initconst const char name[][22] = {
 
 static __initconst const struct {
 	const char	path[17];
+	u8		paravirt;
 	const char	params[PARAMCOUNT][26];
 } dt_params[] = {
 	{
 #ifdef CONFIG_XEN    //  <-------17------>
 		.path = "/hypervisor/uefi",
+		.paravirt = 1,
 		.params = {
 			[SYSTAB] = "xen,uefi-system-table",
 			[MMBASE] = "xen,uefi-mmap-start",
@@ -121,6 +123,8 @@ u64 __init efi_get_fdt_params(struct efi_memory_map_data *mm)
 			pr_err("Can't find property '%s' in DT!\n", pname);
 			return 0;
 		}
+		if (dt_params[i].paravirt)
+			set_bit(EFI_PARAVIRT, &efi.flags);
 		return systab;
 	}
 notfound:
diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c
index 3501d3814f22..9508082af907 100644
--- a/drivers/firmware/efi/memmap.c
+++ b/drivers/firmware/efi/memmap.c
@@ -44,9 +44,6 @@ int __init __efi_memmap_init(struct efi_memory_map_data *data)
 	struct efi_memory_map map;
 	phys_addr_t phys_map;
 
-	if (efi_enabled(EFI_PARAVIRT))
-		return 0;
-
 	phys_map = data->phys_map;
 
 	if (data->flags & EFI_MEMMAP_LATE)
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414821.659258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJax-0005Y4-CT; Mon, 03 Oct 2022 11:26:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414821.659258; Mon, 03 Oct 2022 11:26:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJax-0005Xx-8F; Mon, 03 Oct 2022 11:26:47 +0000
Received: by outflank-mailman (input) for mailman id 414821;
 Mon, 03 Oct 2022 11:26:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJav-0004My-Ni
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:45 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4275023f-430e-11ed-9376-c1cf23e5d27e;
 Mon, 03 Oct 2022 13:26:44 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id BA64560F2F;
 Mon,  3 Oct 2022 11:26:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD778C433D6;
 Mon,  3 Oct 2022 11:26:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4275023f-430e-11ed-9376-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796403;
	bh=W8obWGwmcyzn5+VXhc6GfBg92Z+wLrsUyqrdMHjxep0=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=YTGegz+V40gx32fSy3+ERPuWauQ9SGX/uyZftYxZvb467SzxmwKVEXTMytzhQH7M4
	 1V2VKfiVYH7TcozRWRHaiRvjYuXJnU7IvA2olmMY0WGaftBs2Wudq34NFeznUROMkf
	 eEKT2c2BHrvwIO56Rzxa+c2tXnHsopKi5rFQ8dcQVnCQmh0iLDqkj0BYghKh88t0pV
	 ULDcjx0TaFehBTvC0LpqUhrWXl8AuGFXSEa+GLPK6LQT0oJW1e//vLHd+Ci6+dIj7n
	 xxJvJpZglhpkIcm+iL9P6RnGDwu7fekz6jzPSYG5rUJjgpQsCa8Ggp2E/znkC/Nfmw
	 X2n7ROAkqY1Aw==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 4/6] efi: memmap: Disregard bogus entries instead of returning them
Date: Mon,  3 Oct 2022 13:26:23 +0200
Message-Id: <20221003112625.972646-5-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221003112625.972646-1-ardb@kernel.org>
References: <20221003112625.972646-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=2717; i=ardb@kernel.org; h=from:subject; bh=W8obWGwmcyzn5+VXhc6GfBg92Z+wLrsUyqrdMHjxep0=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbbl+ejDPGi0x7EecnkWLLI5uBb8hfx+mNuYEHL SGFCPwKJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG2wAKCRDDTyI5ktmPJBDfC/ 9BMiukxbjQZgrq2K+4VvI3jjsxzxCI4AmtyKuHFCUBrg62qhcftHWoNGouY0pXptyDabOuNA8Tczdq x93UinMLN5X0NyKvuGmQty4oFhA8rEpRD6B2KX/VHKtu6kwGFBF8gaXmWeGfFv8ZNaQUzZCW51+Ah6 xt81Vx4p8RGFSrmoIzV6bamToULbrhLug9i/9Jsd6mg7Ggpisdj5E2rLXjTIYgtsnnoEXnwZsp9gXW PeBo+4rcj7CsYM7PfupkE6/uX6qAiYPA3UV2nJ9mBJTahiFmwKA58HVUtsv3j16lIEdROHb/bqPvTY /Iw/rmhC+gDxqBhlWoytmTnJWKB1EZpKPo3WESWHuZFKxwFAoqgMWHTFXe5dTWPeEsDBh6rC4WLY7q ylZMZsE9c0QQw1zdPhqNFcK1cGUaorxsMrxlPNm8LYO+qpRsl4HaWKrvSoGF9BMB8PI9R2X+LmbP2Y lhrKABraz+MgDmjFbkI55I1cVGbvO3j4AVGjPmERfskUM=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

The ESRT code currently contains some sanity checks on the memory
descriptor it obtains, but these can only trigger when the descriptor is
invalid (if at all).

So let's drop these checks, and instead, disregard descriptors entirely
if the start address is misaligned, or the number of pages reaches
beyond the end of the address space. Note that the memory map as a whole
could still be inconsistent, i.e., multiple entries might cover the same
area, or the address could be outside of the addressable VA space, but
validating that goes beyond the scope of these helpers.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 drivers/firmware/efi/efi.c  | 13 +++++++------
 drivers/firmware/efi/esrt.c | 18 +-----------------
 2 files changed, 8 insertions(+), 23 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 11857af72859..55bd3f4aab28 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -461,19 +461,20 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 	efi_memory_desc_t *md;
 
 	if (!efi_enabled(EFI_MEMMAP)) {
-		pr_err_once("EFI_MEMMAP is not enabled.\n");
+		pr_warn_once("EFI_MEMMAP is not enabled.\n");
 		return -EINVAL;
 	}
 
-	if (!out_md) {
-		pr_err_once("out_md is null.\n");
-		return -EINVAL;
-        }
-
 	for_each_efi_memory_desc(md) {
 		u64 size;
 		u64 end;
 
+		/* skip bogus entries */
+		if ((md->phys_addr & (EFI_PAGE_SIZE - 1)) ||
+		    (md->phys_addr > 0 &&
+		     (md->num_pages > (U64_MAX - md->phys_addr + 1) >> EFI_PAGE_SHIFT)))
+			continue;
+
 		size = md->num_pages << EFI_PAGE_SHIFT;
 		end = md->phys_addr + size;
 		if (phys_addr >= md->phys_addr && phys_addr < end) {
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 2a2f52b017e7..8f86f2b0734b 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -247,9 +247,6 @@ void __init efi_esrt_init(void)
 	int rc;
 	phys_addr_t end;
 
-	if (!efi_enabled(EFI_MEMMAP))
-		return;
-
 	pr_debug("esrt-init: loading.\n");
 	if (!esrt_table_exists())
 		return;
@@ -263,21 +260,8 @@ void __init efi_esrt_init(void)
 		return;
 	}
 
-	max = efi_mem_desc_end(&md);
-	if (max < efi.esrt) {
-		pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n",
-		       (void *)efi.esrt, (void *)max);
-		return;
-	}
-
+	max = efi_mem_desc_end(&md) - efi.esrt;
 	size = sizeof(*esrt);
-	max -= efi.esrt;
-
-	if (max < size) {
-		pr_err("ESRT header doesn't fit on single memory map entry. (size: %zu max: %zu)\n",
-		       size, max);
-		return;
-	}
 
 	va = early_memremap(efi.esrt, size);
 	if (!va) {
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414822.659268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJaz-0005tb-Rk; Mon, 03 Oct 2022 11:26:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414822.659268; Mon, 03 Oct 2022 11:26:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJaz-0005tK-O3; Mon, 03 Oct 2022 11:26:49 +0000
Received: by outflank-mailman (input) for mailman id 414822;
 Mon, 03 Oct 2022 11:26:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJay-0004Xj-Sb
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:48 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 442494b1-430e-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 13:26:47 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id A949461024;
 Mon,  3 Oct 2022 11:26:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97E0AC4347C;
 Mon,  3 Oct 2022 11:26:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 442494b1-430e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796406;
	bh=WSRp6bNX/TJAZPmOt6U+CC+sxwlMaJT3eET5g/MHr2M=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=RUvZ35FsjQc9G8ENmYBxfeFUtDDJUFK2UMo+/cHo6gpHbn8ONmbPI3AHn8VN9L1DZ
	 pqxSj1M/59aMOVtdAMqgPSAtTUFJ/omqlMu6l28mUHZuN4iHOB91xUSgZ1iZkJ7amJ
	 JvcMd9Z/AxM/W1cnUQlsNR/RpGOCVARUTY1j5ke0C7GhyUdKb9Ze67VFdsmKgk7LwN
	 Yw6TkFInATddLQqNhcAOsoeUzTuNa0pXPyvkA5KPe+9qbbBmJdMNEQTX9Qfw/tSKXp
	 +CS79iIXCGAbyJC1T4KiK1j1JW8UiGBxSl49JnLPwrBpL7X7n2ejiwIX3WhJ3U510R
	 oDXiacweOf8TA==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup based on hypercall
Date: Mon,  3 Oct 2022 13:26:24 +0200
Message-Id: <20221003112625.972646-6-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221003112625.972646-1-ardb@kernel.org>
References: <20221003112625.972646-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3715; i=ardb@kernel.org; h=from:subject; bh=WSRp6bNX/TJAZPmOt6U+CC+sxwlMaJT3eET5g/MHr2M=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbcX3efqx7JPMOFFFmoUJQ0kqs3RTBogBvQjO3M /uoVk6+JAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG3AAKCRDDTyI5ktmPJFNIC/ 4z2IbS7WT9Pkoo7uw6cgC6n6RngdfnXEwUX3q4vv58mt2Q0iHQL4ns7hgXyPfxarD3WIISuJof/j5r cCK5/b6ZdHKAWA7hkitKX0J8CsB/0TZXv45uLpX0mLxVQmYfESgzgkxfBKgrZ+3iMOdxHiEngEMZAv jEkPD4N2LhTlYgqBcxGNnq1dPYhkTqnft5J+Aw3xsM8yj+nLvb5gcD5i+HymlThNZ1tdNIM3OByz9z 5fr/WIcJjzoS7avHP8tPVcEJnVW+rJuWJ9+HuU2QMIp2WCobQHNhvs30Q1YSp4LYFIeF68Oyf5XDG6 AI98jS6cRy055WOW8uchbDKXBvfE9g7oK8DErOjD1BNPhc+ARHEjo4hSGyT1OidxGMUXvwLAPXVxZ7 84ARkFLSx+X8GLpIohsbJODPQrBR9JASQEJpnXhQ14EMiFN10dLoN88rpIyWwHGLFdoKWqwK395xiu /dN2zr1zBiVc7Q/W6DTOo2/W5IYcvjkb7ci8y+KMYpeMI=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

Xen on x86 boots dom0 in EFI mode but without providing a memory map.
This means that some sanity checks we would like to perform on
configuration tables or other data structures in memory are not
currently possible. Xen does, however, expose EFI memory descriptor info
via a Xen hypercall, so let's wire that up instead.

Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 drivers/firmware/efi/efi.c |  5 ++-
 drivers/xen/efi.c          | 34 ++++++++++++++++++++
 include/linux/efi.h        |  1 +
 3 files changed, 39 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 55bd3f4aab28..2c12b1a06481 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
  * and if so, populate the supplied memory descriptor with the appropriate
  * data.
  */
-int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
+int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 {
 	efi_memory_desc_t *md;
 
@@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 	return -ENOENT;
 }
 
+extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
+	 __weak __alias(__efi_mem_desc_lookup);
+
 /*
  * Calculate the highest address of an efi memory descriptor.
  */
diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
index d1ff2186ebb4..74f3f6d8cdc8 100644
--- a/drivers/xen/efi.c
+++ b/drivers/xen/efi.c
@@ -26,6 +26,7 @@
 
 #include <xen/interface/xen.h>
 #include <xen/interface/platform.h>
+#include <xen/page.h>
 #include <xen/xen.h>
 #include <xen/xen-ops.h>
 
@@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
 	efi.get_next_high_mono_count	= xen_efi_get_next_high_mono_count;
 	efi.reset_system		= xen_efi_reset_system;
 }
+
+int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
+{
+	static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT,
+		      "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT");
+	struct xen_platform_op op = {
+		.cmd = XENPF_firmware_info,
+		.u.firmware_info = {
+			.type = XEN_FW_EFI_INFO,
+			.index = XEN_FW_EFI_MEM_INFO,
+			.u.efi_info.mem.addr = phys_addr,
+			.u.efi_info.mem.size = U64_MAX - phys_addr,
+		}
+	};
+	union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info;
+	int rc;
+
+	if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
+		return __efi_mem_desc_lookup(phys_addr, out_md);
+
+	rc = HYPERVISOR_platform_op(&op);
+	if (rc) {
+		pr_warn("Failed to lookup header 0x%llx in Xen memory map: error %d\n",
+			phys_addr, rc);
+	}
+
+	out_md->phys_addr	= info->mem.addr;
+	out_md->num_pages	= info->mem.size >> EFI_PAGE_SHIFT;
+	out_md->type		= info->mem.type;
+	out_md->attribute	= info->mem.attr;
+
+        return 0;
+}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 256e70e42114..e0ee6f6da4b4 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -731,6 +731,7 @@ extern u64 efi_mem_attribute (unsigned long phys_addr, unsigned long size);
 extern int __init efi_uart_console_only (void);
 extern u64 efi_mem_desc_end(efi_memory_desc_t *md);
 extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md);
+extern int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md);
 extern void efi_mem_reserve(phys_addr_t addr, u64 size);
 extern int efi_mem_reserve_persistent(phys_addr_t addr, u64 size);
 extern void efi_initialize_iomem_resources(struct resource *code_resource,
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 11:26:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 11:26:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414823.659279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJb3-0006LD-6q; Mon, 03 Oct 2022 11:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414823.659279; Mon, 03 Oct 2022 11:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofJb3-0006Ky-2n; Mon, 03 Oct 2022 11:26:53 +0000
Received: by outflank-mailman (input) for mailman id 414823;
 Mon, 03 Oct 2022 11:26:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofJb2-0004Xj-2F
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 11:26:52 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 463dc92d-430e-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 13:26:50 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 52C40B8105F;
 Mon,  3 Oct 2022 11:26:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83587C433D6;
 Mon,  3 Oct 2022 11:26:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 463dc92d-430e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664796409;
	bh=9C7AAPmVD5BjjmNEGbxNnPMoOUW0Ie0fKwQ10Ayhy8c=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=Ef/m3g0HgmSAdlLxc6fqIZiY6+uN5iitg2tKlqJBx2kqyn1LxQerWZsFjBQKGZPPo
	 5UCqsf8JYBVwYIfm0t42Hd+d2AkVCw26i1ECycyFRk8twGtzgdzIzgWc12l/6u6YF6
	 LH5J/jNu7aqKOutEydBgmoMzH+yaikiyc6cA7saaEgHV1A3iyLAml1itploasROBbw
	 zlMGZ5MRNQ3RhSk4/QnAogqaAsUikGi6wXIXrS7VXzzc39CQEabYr11vCF3zMIXCFC
	 vMYmvKSVN6NxPaW7VX5h4lWeDPKFV5OOaSAzWX7+9Psix9WpMLL3i9IWNGwX55IQYM
	 bFfyndgoAL10w==
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>,
	Tony Luck <tony.luck@intel.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2 6/6] efi: Apply allowlist to EFI configuration tables when running under Xen
Date: Mon,  3 Oct 2022 13:26:25 +0200
Message-Id: <20221003112625.972646-7-ardb@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221003112625.972646-1-ardb@kernel.org>
References: <20221003112625.972646-1-ardb@kernel.org>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=3156; i=ardb@kernel.org; h=from:subject; bh=9C7AAPmVD5BjjmNEGbxNnPMoOUW0Ie0fKwQ10Ayhy8c=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjOsbenzLnpjmFV4NFmLKMBzkM6EYzVcY2tgtXvDcv bUFOheqJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCYzrG3gAKCRDDTyI5ktmPJJBDC/ 43/+s+cosevfZ50pJwVpCc4I/DH7QKq7kvyhnFWKLHDPwOMJ93i8yiedrIbu95b4QIMIPJEc8tBq9y cW38DNbTE6rxfpTMb73VT4UiZ6bDN/qv+/x6zmOCHVaThg0MLBnjYO1SUCvck73IxWowiReFOO1WGA U7s9cJds+g1X15WxZf9dnt6+muhFLE2Dk5JXvjzjLPBfrXW14dHcCseM7PfBgtwrR8aSkv67OV1yTo mfZNAn3PtjxCdEsecnBhnrAytAQu4yW30XYa8DqqR6mLgjRSs7yzsdhtNCrO04A4C+eqjTpZAePYdy XXMRhHa/tIhzLLb+53o6W3/IUwm8sXP4fLwN892QVrkRXlRmwSmYcMiFf2neJxawz+DjREv9MSIa47 QJPwQvr6LGddffvkVCGaKavWwhMxpj3Q46J6qhGfbsF7f2vkS3Kso6HtD4OuXi3KVF1pcclOHbOvfT qiDRgl+P1O5UEKV58pQHT1jpiJ1EjxP/f4HUFXDu0VYmQ=
X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909
Content-Transfer-Encoding: 8bit

As it turns out, Xen does not guarantee that EFI bootservices data
regions in memory are preserved, which means that EFI configuration
tables pointing into such memory regions may be corrupted before the
dom0 OS has had a chance to inspect them.

Demi Marie reports that this is causing problems for Qubes OS when it
attempts to perform system firmware updates, which requires that the
contents of the ESRT configuration table are valid when the fwupd user
space program runs.

However, other configuration tables such as the memory attributes
table or the runtime properties table are equally affected, and so we
need a comprehensive workaround that works for any table type.

So when running under Xen, check the EFI memory descriptor covering the
start of the table, and disregard the table if it does not reside in
memory that is preserved by Xen.

Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 drivers/firmware/efi/efi.c |  7 ++++++
 drivers/xen/efi.c          | 24 ++++++++++++++++++++
 include/linux/efi.h        |  2 ++
 3 files changed, 33 insertions(+)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 2c12b1a06481..0a4583c13a40 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -560,6 +560,13 @@ static __init int match_config_table(const efi_guid_t *guid,
 
 	for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
 		if (!efi_guidcmp(*guid, table_types[i].guid)) {
+			if (IS_ENABLED(CONFIG_XEN_EFI) &&
+			    !xen_efi_config_table_is_usable(guid, table)) {
+				if (table_types[i].name[0])
+					pr_cont("(%s=0x%lx) ",
+						table_types[i].name, table);
+				return 1;
+			}
 			*(table_types[i].ptr) = table;
 			if (table_types[i].name[0])
 				pr_cont("%s=0x%lx ",
diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
index 74f3f6d8cdc8..c275a9c377fe 100644
--- a/drivers/xen/efi.c
+++ b/drivers/xen/efi.c
@@ -326,3 +326,27 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 
         return 0;
 }
+
+bool __init xen_efi_config_table_is_usable(const efi_guid_t *guid,
+					   unsigned long table)
+{
+	efi_memory_desc_t md;
+	int rc;
+
+	if (!efi_enabled(EFI_PARAVIRT))
+		return true;
+
+	rc = efi_mem_desc_lookup(table, &md);
+	if (rc)
+		return false;
+
+	switch (md.type) {
+	case EFI_RUNTIME_SERVICES_CODE:
+	case EFI_RUNTIME_SERVICES_DATA:
+	case EFI_ACPI_RECLAIM_MEMORY:
+	case EFI_RESERVED_TYPE:
+		return true;
+	}
+
+	return false;
+}
diff --git a/include/linux/efi.h b/include/linux/efi.h
index e0ee6f6da4b4..b0cba86352ce 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -1352,4 +1352,6 @@ struct linux_efi_initrd {
 /* Header of a populated EFI secret area */
 #define EFI_SECRET_TABLE_HEADER_GUID	EFI_GUID(0x1e74f542, 0x71dd, 0x4d66,  0x96, 0x3e, 0xef, 0x42, 0x87, 0xff, 0x17, 0x3b)
 
+bool xen_efi_config_table_is_usable(const efi_guid_t *, unsigned long table);
+
 #endif /* _LINUX_EFI_H */
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 12:23:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 12:23:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414875.659290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofKTC-0005Xh-CM; Mon, 03 Oct 2022 12:22:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414875.659290; Mon, 03 Oct 2022 12:22:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofKTC-0005Xa-9m; Mon, 03 Oct 2022 12:22:50 +0000
Received: by outflank-mailman (input) for mailman id 414875;
 Mon, 03 Oct 2022 12:22:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bYUz=2E=citrix.com=prvs=2680ed0a5=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ofKTB-0005XU-EP
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 12:22:49 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1486ae77-4316-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 14:22:46 +0200 (CEST)
Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 03 Oct 2022 08:22:33 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by BY5PR03MB5014.namprd03.prod.outlook.com (2603:10b6:a03:1e6::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Mon, 3 Oct
 2022 12:22:29 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%7]) with mapi id 15.20.5676.030; Mon, 3 Oct 2022
 12:22:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1486ae77-4316-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664799765;
  h=from:to:subject:date:message-id:mime-version;
  bh=HSHZmj61xvJNi5ELYPNW1YMrni+2a5ZAWKeGASPDiaQ=;
  b=g3AqjFIEk0LJtaWbEp1jem26fKbMBgWLvpegfZtMcPoApkLElvbXsO9z
   G3Sm/gIksaK2pQJ1aYgN28LhBZH7+CIZL+LCa/62fO3MDXcWUo8ZLmyXN
   nac982AcqNVureIOHeSZXn+6cX0FLOihfDcCgvrzvGk9RkOfNQL93kEil
   U=;
X-IronPort-RemoteIP: 104.47.56.172
X-IronPort-MID: 80969980
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:U5Qe5K6dnpwZXkwCQCTQAgxRtNDCchMFZxGqfqrLsTDasI4TYg02e
 lBvGjDRZK7OJyCgZYg1O70CxjoE75CGytVnSFNv/HpjH3lAoJSVCYzHdhioZX2eJJDKEEg2s
 JgUNICddphoRSLW/hzxaeawpyl12PHRG+qiWb6UUswdqXeIbQ944f40s7Jp0uaE+OSEPj5hm
 e8eguXTNAP112F/OG9O4fuO9E5htfiv5D1D4VdnPv5A5FSGyShJAMoTK5/qIiqjSOG4PAIYq
 8Xrl+jlozyDr3/BLvv/z94Xp2VTGua60TCm0yYQAe766vR7jnRa+r4hM/YBYltghTyMntRgo
 P1ArpX1QgoyVkH2sL11vyJwTmcvZsWqxJedeSLl6JTLlBWfG5fR664G4H8ebNVwFtlfWQmix
 dRAQBgRYxaKgf6Bwb7TYoGAUex6caEHlKtG0p1R5Wmx4cQOGPgvcI2TjTNs5x8ih9gmIBrrT
 5FxhQyDzvj3S0Yn1l8/UPrSlQoz75X1W2UwRFm9/cLb74VPpeDYPXeE3Nf9I7S3qctpckmwl
 mLq4UmjAAEhNOeh0hys62Oz2fPpknauMG4SPOXQGv9CpnS2nzVWIzpPEFyxrL++l1K0XM9ZJ
 woM4C0yoKMu9UutCN7gQxm/p33CtRkZMzZSO7RitEfRleyJvUDAWTJsoj1pMbTKsOcZSDsw2
 VLPs87vATV3mLaUVWic5vGfqjba1S09fTdTO35VHVNtD9/Lm7MC1gjWF4ZfC4mTkPzPJi7q2
 m+bs31r71kUpYtRv0mhxnjXjjTpqpXXQwod4gTMQnnj/g5/fJSiZYGj9R7c9/koBIefUlSF+
 WgJneCf6vwDCdeGkynlaOkEGrCk47CGMSXRm3ZoBZAq8znr8HmmFahb4Ct/P1tuKsYJY3n2J
 kTXsBlSzJBWNXquK6RwZuqZE8kw1qH9D/zqU/nVapxFZZ0ZXAyK4iBoI1ad1nr2l04ElrsjP
 J6desGqFmseFaVhw3y9QOJ1+b0k3Ccl3kvIWIv2iR+g1NK2fHKIU60MNkemZ+Uw/qSC5g7S9
 r53NcyKzVNdUcX/ZDXa9cgYKlViBWQyAJnt7c8RcuOFLRtrHEkuDvbQxfUqfIkNt6lZme7Su
 HCyXkJDyVPkrW3GLQSMejZob7aHdb9lsX8+Cgk9Ml+p1mYLbJ6m6eEUcJ5fVZwu6PAl9uZ5S
 fIIYe2JGPEJQTPCkxwmcZTipZZ+MjSqgQ6DNTCsZjQXc5l6QQHT5dj+fRCp/y4LZgKpss85r
 6ylxxnsS5MJTAR/D+7bcPuqiVi2uBA1uu98UQ3rP9NaY07t86BmLDb3g+UoJNsPMlPIwT7y/
 x2NHR4SqO3Jook02NrEn6aJq8GuCeQWNkhHG2jW656mOC+c+XCsqadaUe+OZC3cUmXc96CrZ
 OETxPb5WNUdm1xLtcxmGrBnzash7vPmvbocxQNhdF3Hd0+uC69gCnCe0NNTq7ZWwbtEpQqxX
 FnJ8d5fUZ2CMdnpF1M5LwM/YuOOk/oTn1H64eswP23z4SZl+7zBWkIUIhrkoDJUNrJ5P4o43
 e4kkMET4g27zBEtN76uhDpV/mLKMXsHX74PppAeAYn7zAEszzlqe5vWTDPx/5eLZsRkPUwjI
 zvSj63H75xWwUDIYjw+DnjJ0O9Ug7wBvRlLyBkJIFHhstHAh/km1Qdd2TEpTx9Jx1NM1OcbE
 m9vNlN0KL/I+z5tjsVZQ0iyEh1MH1uX4CTZwkAJ0m+fUEisWm3LI0UyPO+M+AYS9Gc0VgJS/
 Kycjl3kVznqVMjr2205XksNg/XmTMBZ9wvMgsmrEs2JWZ4gblLNmq6peXBOqAHgBetqgUHKr
 69h++MYQaz9LjMKrKoTEYiB2KkIDhaJOARqRvVs/7gAG23GTzi01SKTMEC6es5LJPvi/FexD
 oplIccnfxO62SWVpzYXH5kQMqR0l/4k4tkFUr7zLGtAuLyaxhJlvZ/I6ij/wmoDR8lyioA2L
 Ya5XymJFXCMmnd8lGrErc0CMW29CfEOaQvU0fCy7OwPFo8G9uBrGWk307C0tnHTNxF18ha8t
 QbPIaTRyoRK259sko3EH7VEGwyyKM72EuWPmCi5qdlIYdrJMpyX7ysar1DmO0JdOr55c95qj
 6aEtNn721zMlLkzWmHd3ZKGEsFhxci0RvsRDcvxI1FThy7EU8jpiybv4Ei9IJ1N1dhav8+uQ
 lLhbNPqLIFPHdBA2HdSdi5SVQ4HDLj6ZbvhoiX7qOmQDh8a0krMK9bPGWLVUFy3vxQgY/XWY
 jIYcd73jjyEhOyg3CM5Osw=
IronPort-HdrOrdr: A9a23:09VWCqnSofTPSKZwbKA+mk+sribpDfOvimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7Sc+9qADnhOdICOgqTP6ftWzd1FdAQ7sSibcKrweAJ8SczJ8U6U
 4DSdkYNDSYNzET4qjHCWKDYrUdKay8gcWVbJDlvhVQpG9RC51I3kNcMEK2A0d2TA5JCd4SD5
 yH/PdKoDKmZDA+ctm7LmNtZZmIm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYZ93
 TfmQCR3NTvjxj78G6R64bg1eUZpDLT8KoDOCVKsLlUFtzYsHfmWG2mYczAgNl6mpDs1L9gqq
 i1n/5pBbUJ15qWRBD/nfKl4Xic7B8+r3Dl0lOWmn3lvIjwQy87EdNIgcZDfgLe8FdIhqAJ7E
 rat1jpzaa/ICmw7hgV3eK4Ii1Chw6xuz4vgOQTh3tQXc8Xb6JQt5UW+AdQHI0bFCz35Yg7GK
 02Zfusksp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIgUn2sG9pg6V55Yjt
 60RZhAhfVLVIsbfKh9DOAOTY++DXHMWwvFNCaILVHuBMg8SgHwQl7MkcUIDc2RCeI1JcEJ6e
 j8uXtjxBEPUlOrD9GS15tW9R2ISHmhXF3Wu7Bj26Q=
X-IronPort-AV: E=Sophos;i="5.93,365,1654574400"; 
   d="asc'?scan'208";a="80969980"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WwgBGdAPwG7Zt83B+3wh4YYd2dWC8KihDStNRSApYUYLWCv4rg4v3QIIVF3OcAFyfplbMiJ8pJgHkO8fKNX1dGYI6FfBKHSUfVBt+hYBYPVZJvscCPwgO3YTvohnAeSXuQ1bwbtur5Q/L2I3L1/p0sY6yPvJQlSa3LlcFoub4Wo1xc34lHYHVCnPs/XgNiGkx+eYkVPXOy2be2fDlOqloaFtyuUhqY4dJFfsC4fgjzu9A+kIBUPjJZg44lNv9javljJf7IvITov+9CTItsDHeNNrkuClDs5j7/LJCK+qgciEMtNFONBJQIK8pAJFm3CHA0/MThoLD+2pSsr2b8sFoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gsVSkuwTG9V9qos4Ct05n15GcxBPPEPXMnZvF5Q1zww=;
 b=cIVgyjaMGok/wI5XuoJfJ2GLE9IQECun2XBdaiCI/QkfZ5U5HG0/zd4klQ3x2HI/9aWchAQmVFYwtdceU440664tt4+Juw22ySMZQQgdd3pOkFwRLxGC5UKmPpZmF6K2hTdYrwvbilEKfywV8MZf6OSNES/YEgOvrZ+ebrefvz44Ayu8gt9m4NjfDLMHdqsIRrW6rONK5NiXLreQoY+QWxpNJcS7LwHhoEcnPNPT6o65EvLHqMD3C8fsFF+/4JsN8H89K4NDYxn2tY3TsznKbaCqGen1BAOMMSCEFKStos6bkR6+RhMM9yo7ruqXU271oXVE0YiVG47N9JDWAN5oNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gsVSkuwTG9V9qos4Ct05n15GcxBPPEPXMnZvF5Q1zww=;
 b=TkCWalCJao4jPRtwyICOme563fpR9MyoVF+fFugTwDNNGNa33Z/Xk0TTG9g5pB8Y05O7P7MoTwEzZ2dIHsGSET3kf0FWTWi5KGE8JeOr3SER7vKfLF41r2K5a0r9HEJpsQKACKW9RXNQ7DvY5DTjZkPc32zpCcf4kW2lv79bNI4=
From: George Dunlap <George.Dunlap@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>, Tamas K Lengyel
	<tamas.k.lengyel@gmail.com>, "intel-xen@intel.com" <intel-xen@intel.com>,
	"daniel.kiper@oracle.com" <daniel.kiper@oracle.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Sergey Dyasli <sergey.dyasli@citrix.com>, Christopher
 Clark <christopher.w.clark@gmail.com>, Rich Persaud <persaur@gmail.com>,
	Kevin Pearson <kevin.pearson@ortmanconsulting.com>, Juergen Gross
	<jgross@suse.com>, =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= <pdurrant@amazon.com>,
	"Ji, John" <john.ji@intel.com>, "edgar.iglesias@xilinx.com"
	<edgar.iglesias@xilinx.com>, "robin.randhawa@arm.com"
	<robin.randhawa@arm.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>, Matt
 Spencer <Matt.Spencer@arm.com>, Stewart Hildebrand
	<Stewart.Hildebrand@dornerworks.com>, Volodymyr Babchuk
	<volodymyr_babchuk@epam.com>, Jeff Kubascik <Jeff.Kubascik@dornerworks.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
	Rian Quinn <rianquinn@gmail.com>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?=
	<cardoe@cardoe.com>, George Dunlap <George.Dunlap@citrix.com>, David
 Woodhouse <dwmw@amazon.co.uk>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= <amit@infradead.org>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?=
	<varadgautam@gmail.com>, Brian Woods <brian.woods@xilinx.com>, Robert Townley
	<rob.townley@gmail.com>, Bobby Eshleman <bobby.eshleman@gmail.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?=
	<cminyard@mvista.com>, Olivier Lambert <olivier.lambert@vates.fr>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, Ash Wilding <ash.j.wilding@gmail.com>,
	Rahul Singh <Rahul.Singh@arm.com>, =?utf-8?B?UGlvdHIgS3LDs2w=?=
	<piotr.krol@3mdeb.com>, Brendan Kerrigan <brendank310@gmail.com>, "Thierry
 Laurion (Insurgo)" <insurgo@riseup.net>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>, Deepthi <deepthi.m@ltts.com>, Scott Davis
	<scottwd@gmail.com>, Ben Boyd <ben@exotanium.io>, Anthony Perard
	<anthony.perard@citrix.com>, Michal Orzel <michal.orzel@amd.com>, Zhiming
 Shen <zshen@exotanium.io>, Xenia Ragiadakou <burzalodowa@gmail.com>, Henry
 Wang <Henry.Wang@arm.com>
Subject: [ANNOUNCE] Call for agenda items for 6 October Community Call @ 1500
 UTC
Thread-Topic: [ANNOUNCE] Call for agenda items for 6 October Community Call @
 1500 UTC
Thread-Index: AQHY1yLNNm1KBLLYsk6cKKHNRLx+9g==
Date: Mon, 3 Oct 2022 12:22:29 +0000
Message-ID: <75450DE8-EE95-4ECB-B931-8C820D124EF3@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|BY5PR03MB5014:EE_
x-ms-office365-filtering-correlation-id: d3735be4-f5b7-4a3f-ac96-08daa539f086
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 0jdfHel0uSYPHJO4WxnaxplEwGe0u8zxhr3sJ1qyuUIXkNH3Stz6LiqCGFkjqP7/fsbMS+rmXRgYpECW+Lm2FetjPaoCyqxwmTutHN3wwd8BzzmDMrsN3irSYR6KNlAsj5GLSd32XXTaF0pgxODdxEqDGG8QcwCHejn1yyWfSCn1PEkhVrwKTwqhqJllq6FvyyLyA3DREtUQP9WxBnkVcDSwQ1+/4OBNerWE7rwIX2aptEqWR6HRSFqWVIHV7ibYoUXcxRpM+M3AYmoe2/TP0c/gGVS0yA4B9lRczXS+jLmh7PHT69vHoxiNLVA2RwRO8JPf5L6DFV4sDs13iLzQJ3999lzT7OhCvJvLENIy7tmjWyRMVVFuGndKmZhzpXo3db0++jLcygvoqAtjBrf4TXR3qbUK/z9U/8oYQWrNqlZeJ1Y/on59Ueb9MdBEdGsU73vjxFYzwuW1OcSdAl+QI1TW7vGUmYKtob1KMFILxeRLR0VvbXj/wb+4FVtdTpqk7VDqWHgiiHoXlvYavAZrsny5DD7zYXz0UahMtij/agVmob4a+voTUmea51NQPwbjvEHUkmXQMnk7rX687o0ovKB+nyMramM/YTeBf3Q5LfAKYWX04iTiUqnxabWzufe71qgj2FESiw8nFalJKE/NpFaptPXxu/s9WB59u5UjYAUe2baDuMygdqvx6Uqpwsb73c508bJwNJCXnQqpZ6Zz7Dy49XCH5LFkKATAey3KscYuS7cltwQH1fWKqXDNrhjfcMmIyxM9s1wrA9vwXSSA9Xqbx22Fm2kTyGuHoGxjeMBwQBTgtEzW66+gG7WYjhBIv6EyEND4S6HFqK+g2q81GarMdxtgp5xUb0mbEfITmxpP9U4SEcWnzxI26GBoYmpkumBV/OnmIrvJyLWryyszJWbXYG4SB2+ps7UT7bAb0QU=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(396003)(136003)(366004)(376002)(346002)(451199015)(478600001)(36756003)(33656002)(110136005)(86362001)(38070700005)(122000001)(921005)(99936003)(7406005)(7416002)(186003)(83380400001)(38100700002)(2616005)(82960400001)(66946007)(26005)(2906002)(41300700001)(71200400001)(5660300002)(966005)(316002)(76116006)(66446008)(6486002)(91956017)(6506007)(8676002)(66476007)(64756008)(66556008)(8936002)(6512007)(221023002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?S1VyZjFQYm1UcUpsUzkzazRsYU5qTjNxQzl0RENoRDhnZTdVOUxFWUpqN2xl?=
 =?utf-8?B?ZWpMQy9zaEpnZkdaeVdQN2pSMG5aWmMySi9Uay9sMlhJSzUwNWgrcjBSQXR4?=
 =?utf-8?B?enRWRTN6aDAvdjdsbGxMU2t2dWM1UlhldW1FaEtqbngyclZGVXBCL0syV1kz?=
 =?utf-8?B?ODRacWRhcHdMdWNRUGN3WFhlQ1FmNUtZdEZ0cTA1M1BsL2RCbFJTc1U2Q3VW?=
 =?utf-8?B?Z2d0MDQvaUEweWZLRi91bkEwTitaRTdvclFOdHBMN296eUVrUnIrWHFSQWVm?=
 =?utf-8?B?NWl5bHQ4QUJpK3k3b1IzNFB1WU0yc1ZZMjJKMXUrMWk0b0h2c2tYekptZDZ1?=
 =?utf-8?B?U2UwUUlBZ1FHczdaeEdPeDlmbXZBQ3FoN1dFU3FmRkhLYlN6S0Q5TjQ5SDlP?=
 =?utf-8?B?WXhPeFdPcG5OcG83SW1yOE1SbnA2STZtSkRKZHVNQWlnbXFkczRPL1poRU05?=
 =?utf-8?B?aERsTGIrT2dZRDAyd012WUdpRGczODh0ZElBcnVzQU9jdFU0cDMwRWFrZjJJ?=
 =?utf-8?B?OVpIVlJPbEZjQ3BMZGx2Q1V5VUEwdVQ0NFl0cmVrcStCTGZrL2xRYm5DYmNl?=
 =?utf-8?B?MG45ZjZZTXpZMUdITzd1YmdDSzA5Q3BEYkFvNHBmZUk3WUVDL0Z4RC9wQkYx?=
 =?utf-8?B?T281c3BOTXdCbStVTmhtNVE4K1JhdHd1b241Q0YrMDJpOFhJT2N1NklIdzRL?=
 =?utf-8?B?OGdZS0VWSFFOU1A5SzF3WkxaWlErVEhLLzhkODVvU0RtQWlzTXBDdjJMVVpU?=
 =?utf-8?B?c2ZkcnF6UFQyNm1jWm1sVHFxK2lQTk9xNUNsWTZGbk9VUFY0dnlxRHZqaGZr?=
 =?utf-8?B?UHdnR0lzNnRmaDlETW9mbkNHcXVyME9pRzBPc2ExbUtBSmZjTytWa1ZoNndt?=
 =?utf-8?B?MGd0YTFpZnJjbkdJbDFFR1FJcVMyWjRjY3NpZHhVVjNTMExKN1A5cWNucXZn?=
 =?utf-8?B?bDJBYlFXL2kyQ2VydFR1eXRKVklrbVZycHQxQ0NqU3VRVGNHYnlvTjNtZXE2?=
 =?utf-8?B?U2NGS2FoWHZXdEJWZ2FrZzlkaDQwaFNtbEl3UG9jTFp6OXFRUExIYmVpdVQx?=
 =?utf-8?B?ZmpzU0hUcWxwb09VeHRncmJhN2sweS9ENk1qejVyaEFjMEF6NVR2TmNkaXJM?=
 =?utf-8?B?ckhCTllsV3Z6b3RvMEtkV2IzWHdJWEdjNC9hNy9MLy9tTEs5MlViWmtvQ1JO?=
 =?utf-8?B?U3lVMDlJUXBOaHg4eFRCamwrZVpvbTF5SGV6cWVVZlNlK3ovQnN5SFBuWS95?=
 =?utf-8?B?aGJ1ejZCN2VETDNZSVA5VFRObmlHTDZFNGw5NFR3ZjNjcVBIM1lweGp3MDJB?=
 =?utf-8?B?L3A1ZkxNNEhBclZXUnR5VzdxejJpaGlkUkYrV2RWRk4xbXAzTEN6Z3RRMkYw?=
 =?utf-8?B?S2lFeDNSRWhZcEVFZlEzRmRZdk1BYTEyY3VKS2ZJOHZoTDVVVXRMMlRoemh4?=
 =?utf-8?B?T3RxR1JwRzdvWC9NZ0ljUzlZT09sQkVIazdzbzUzWWhmQmtvcHV0VEpJVnF2?=
 =?utf-8?B?R1lzK214YW1YcFF6U0tBOXRDOHN3dmIrakNxRktkZDRnbUo0S3hKRnJJMUVF?=
 =?utf-8?B?eUliZW00Skk5NEpJZ0VxVjB1YWJOTHlLWGFycGlWbmtaSzMzVjA3RDFYc2w0?=
 =?utf-8?B?VU5vb1Y5K2xmektvMFZkb0R6djhaMlA4SmtWMlNBVWZyRE1KYzQxQ2FPam81?=
 =?utf-8?B?Mll3MnlKMklwZm16UkI2NE1oSlNPVG54TXBORHZsL2JKUjYwRHRuVEkwNWho?=
 =?utf-8?B?WEpHMVFXdXo5MHZFSXhWNGlsMFJNcGg0MWVpcUJnakMrcXEzS29sVmg4Z3ZF?=
 =?utf-8?B?K0RsUjhhU1dZUGlHUk1vRjdtcWhCRHFGVXpqcENnZFVmNDRJNmxmbmdtV2R3?=
 =?utf-8?B?MXpaQ3J1YTkrNUJwOUdiOEg1T1BiQ0xmZjMxYmxpUGFWVkU0YzVBVjFlck1P?=
 =?utf-8?B?QlVsb0ZJU01SMy9iMFYvRlBaTnFNbXZtVDJjcVlBY0R2TnJETUNzbFQyU3VP?=
 =?utf-8?B?T3B3UHI3ck1OVmhYemQ4aVIydHdZSVl1ZUxKUkt5VHhOTUpNNnpOd3V5WlM0?=
 =?utf-8?B?UkszYnRhSDZSZGYzSFdDd2hqM20xUWhpS1NPbmRYL2NBb3pmZUpRRURIeXRk?=
 =?utf-8?B?anVBVEVSSEszZnJSQUFKb0VhVDNKbU8zckptV2pjeXVNcmQwUFQwUHN2VlI3?=
 =?utf-8?B?Vnc9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_66FC531F-93A2-4753-99A0-B45DF9E58451";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3735be4-f5b7-4a3f-ac96-08daa539f086
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 12:22:29.3109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uM2/h3So+lEfp0KVcqvfnUGAybdvC/6U0pKMeOxXPLf/k9uIXY4IqxFTs2sYAB9fq4R275+NBWy9jBpNnURTKfO71YqyA9Evsb4cZ1vMxQg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5014

--Apple-Mail=_66FC531F-93A2-4753-99A0-B45DF9E58451
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hi all,

The proposed agenda is in =
https://cryptpad.fr/pad/#/2/pad/edit/aNcW2L+HFp6WK9eJRssbsPLu/ and you =
can edit to add items.  Alternatively, you can reply to this mail =
directly.

Agenda items appreciated a few days before the call: please put your =
name besides items if you edit the document.

Note the following administrative conventions for the call:
* Unless, agreed in the pervious meeting otherwise, the call is on the =
1st Thursday of each month at 1600 British Time (either GMT or BST)
* I usually send out a meeting reminder a few days before with a =
provisional agenda

* To allow time to switch between meetings, we'll plan on starting the =
agenda at 16:05 sharp.  Aim to join by 16:03 if possible to allocate =
time to sort out technical difficulties &c

* If you want to be CC'ed please add or remove yourself from the =
sign-up-sheet at =
https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Best Regards
George



=3D=3D Dial-in Information =3D=3D
## Meeting time
15:00 - 16:00 UTC
Further International meeting times: =
https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2022&mon=
th=3D10&day=3D6&hour=3D15&min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D=
179


## Dial in details
Web: https://meet.jit.si/XenProjectCommunityCall

Dial-in info and pin can be found here:

https://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall


--Apple-Mail=_66FC531F-93A2-4753-99A0-B45DF9E58451
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmM61AQACgkQshXHp8eE
G+2VhggAn0QmNBOVGrSM3SoildIqbyw2Z9173EfJBX+TXYE6Rl7hbITq02wY2GpR
dyc8NJDklNjcgNLK+BWhYedbCXOP1RX+wR4Q68RD0B1NQBFrsHU6OPSmD39drGe6
SIz9hcqmUmbiAGGSwzfKLIp/mHa3J4PHIARADksdc6SxGZW+uxyDxewW4MKRQigt
CrkF3usnojMUeQxYtAuHeedXTFVd4y6pc5ifW1eIYo/qYG8TskZ1bFkW4LuN+TEW
2bdNaL6qSqUkpWwlLyqenl9eRju3WpfBXuzy+5J/YuTXUZJnizHvMjbyHLvLB9Jv
A0A8dbiCzNeZlY/FC7451JqECX08sg==
=un5v
-----END PGP SIGNATURE-----

--Apple-Mail=_66FC531F-93A2-4753-99A0-B45DF9E58451--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 12:58:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 12:58:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414882.659301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofL1c-0000XV-3W; Mon, 03 Oct 2022 12:58:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414882.659301; Mon, 03 Oct 2022 12:58:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofL1c-0000XO-0u; Mon, 03 Oct 2022 12:58:24 +0000
Received: by outflank-mailman (input) for mailman id 414882;
 Mon, 03 Oct 2022 12:58:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofL1b-0000XE-Gs; Mon, 03 Oct 2022 12:58:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofL1b-0005OH-ER; Mon, 03 Oct 2022 12:58:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofL1a-00043D-Uz; Mon, 03 Oct 2022 12:58:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofL1a-00063z-UX; Mon, 03 Oct 2022 12:58:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xJZw1GUw26Ki4ds8svaWynzw7bXMFOzVxGBZIFq1ju0=; b=nR9jsrIPqSgeoiTRsc1SbKkPpm
	bCxW00ssiyjkjUqYnaPRX8ftfBmEnd9DveD8cphmmn71bZaegUtyLfkLc5xea4UQ8aejWiC9cDqJa
	ekjiPB3i9l3AUwTgVXTCQgNmIAtS1Uexy8ZqJY7suZYJwPBGAKGAF7e9YtAuWxo4PPTA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173404-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xtf test] 173404: all pass - PUSHED
X-Osstest-Versions-This:
    xtf=5e770502e81e6bde08f55db6b0f66fbc1013850d
X-Osstest-Versions-That:
    xtf=37ea4e513a2ce0cd22f9c9a32b18d5c022e38e12
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 03 Oct 2022 12:58:22 +0000

flight 173404 xtf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173404/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xtf                  5e770502e81e6bde08f55db6b0f66fbc1013850d
baseline version:
 xtf                  37ea4e513a2ce0cd22f9c9a32b18d5c022e38e12

Last test of basis   170789  2022-05-31 17:41:55 Z  124 days
Testing same since   173404  2022-10-03 12:13:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-amd64-pvops                                            pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xtf.git
   37ea4e5..5e77050  5e770502e81e6bde08f55db6b0f66fbc1013850d -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 13:44:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 13:44:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414891.659313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofLkB-0005Zs-DR; Mon, 03 Oct 2022 13:44:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414891.659313; Mon, 03 Oct 2022 13:44:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofLkB-0005Zl-Ag; Mon, 03 Oct 2022 13:44:27 +0000
Received: by outflank-mailman (input) for mailman id 414891;
 Mon, 03 Oct 2022 13:44:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tjbh=2E=citrix.com=prvs=268c0e076=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ofLkA-0005Zf-HB
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 13:44:26 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 75961eea-4321-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 15:44:12 +0200 (CEST)
Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 03 Oct 2022 09:44:15 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SN4PR03MB6719.namprd03.prod.outlook.com (2603:10b6:806:1ee::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 3 Oct
 2022 13:44:13 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Mon, 3 Oct 2022
 13:44:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75961eea-4321-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664804662;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=phPklzWJl2iCNTCo+wf0KloNacXhGY7U2fvnwZKbKvg=;
  b=BjkM6rdc4tFaqECGo1ihe3SPahZ+ErjTUmp7oxzkdbV1zK9kejb2XYHf
   G3fj/yqd4W37K+noAWcu/kMtUlQAMMXUfS1g9cdbR7MCzjMAcuLAkDRSr
   dDyll0tbOd7jJSjoxVB4eMGgNjgDp2Av7vxpRPIoL4p6ZCak0j1ETj1E4
   A=;
X-IronPort-RemoteIP: 104.47.55.173
X-IronPort-MID: 80976897
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:N29kh6oKVPljcc6ZUe014CJ+9cleBmIKZBIvgKrLsJaIsI4StFCzt
 garIBmBPqneamT8L4ojbtuyo0IPuZfQz4JiTlRo+SsyH3kR9JuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+55wehBtC5gZkPKgT5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6
 v0/cxssU0q/2N2cnpukUcdrvpggM5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+OF3Nn9I7RmQe18mEqCq
 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJKReLmpq816LGV7jUCFwcNeXqVnfWSih+EVMtmc
 HUOpBN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62
 1mRhdTrCDdz9rqPRhqgGqy8qDqzPW0fKz8EbCpdFw8duYC8+8c0kw7FSctlHOitlNrpFDrsw
 jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNtGuVuKbNi1SU1GXm
IronPort-HdrOrdr: A9a23:mCPwgawGIXdErYYHElJsKrPxj+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD
 AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo
 SOBK4=
X-IronPort-AV: E=Sophos;i="5.93,365,1654574400"; 
   d="scan'208";a="80976897"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ay0OVj44V+2V26UdcqmJ9qx0C5JwmrgSMWdB97pnrvuhU2I4yeV2D+zjJ7H7T6C1fIRwdVR6PvADjVcZvIa5Su4t7eX9Hd3n1sRed6cZxiy1qDIOfKfZP/azfWJ3M8kKVw2DRUJGn/RhlMZpJ5x5v5h/aEa2IukbL/4oi6p1E6n0B+IKw2AXtqMY9eAe/ZeiSg0JxlDgBVbVxtHtWZMGy580UqVEjuMp+H74v51n8Pr59xyMkpFXJthc7k0fry8B1CPd9ho2Ps1joXWCcvH59ALPNaj8m9RbbYxm2U4W9O8kvhNjFsUB1bFT8Q2itE1is0Zh7uOk89vf4YNilIKrgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=phPklzWJl2iCNTCo+wf0KloNacXhGY7U2fvnwZKbKvg=;
 b=RDfSvm2gdZPysGm3WHmgPxZmGbi7p2j1/1kxc7zN6ZmZhtwEbmkIRbqhOKQtbU1HYlbo8LWADlNT9nauDDsZQrlwOcyQ7Z15nGdwN8HnBcebYjsXD62ZXLRvkHf/GdTuvFFu1nPkD4QHNlKy40aax3FkY3zUxszcpAibm/hSWZmBw1h3WdX6rFKFTe2mggq0PeE8OYR4lW1MyaDwAOrroOEi8KNbjwEeiGBmc2+QwyqIflA7KQ7IiaLRJ8AibQZJgs8CAq5jtci7+DNtV9wJvGQczOpbyOj6X/cV4UOxOpFW1OgG211oA1WH73nnPmtYL7iZeJ8GlaienR92vjkCmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=phPklzWJl2iCNTCo+wf0KloNacXhGY7U2fvnwZKbKvg=;
 b=fZpYLWV5Vcqu0FnGr7Lls7AvaAlkSB/uh+lfg4ABSk250SvG393IiXjZgM+PEMfQEOQsMJuqKhuq3Nk8A7CgPdlUR9REMQBzkHuh9sx4CWLB06tSqD2Cc7pxkTdcWThP1YnwqdJjDbNsobtmh21KyRh2IunQdlguB5sy8jdfSzw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 0/2][XTF] build: suppress GNU ld 2.39 warnings
Thread-Topic: [PATCH 0/2][XTF] build: suppress GNU ld 2.39 warnings
Thread-Index: AQHY0+qyShr3jKepJEmQ1kbzugJHQ638tJsA
Date: Mon, 3 Oct 2022 13:44:13 +0000
Message-ID: <bd57773b-77d0-8e69-69ad-d17b272996de@citrix.com>
References: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com>
In-Reply-To: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SN4PR03MB6719:EE_
x-ms-office365-filtering-correlation-id: 4e073dec-df95-4d81-874e-08daa5455b8d
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 1WUCc2O8eNGpKS7N5gIg/FTaWrYLBra3FXlAeT3UDdOgC5Y3E2IetKI7KuxSpcHBEDJI1IvWLrr0zm09Op3elN4aZgK0GRoNg/bg31Yh27xEf4Y/drZKCnUPv5mHLY0X+UGGq7iD2vpuDMFe6UKiFqFBN+y9QcDTSQdVsKx5SSGX5VAb8B7S8pQUuByaAbul7L8/CN58W0h5xCz4DpZxTjZj5OqBqCfaaqVOgFm6GS+QqLJZu1RI8DcMeZ+tJb5sCvTOnv4Oh4iep/sAF9O6b0eALODyEu7udKuEg8fH6XxgNOR7UnDPf30ArEhwPDReFfF/JjxqzFrZCqK1sSOLOa9qWlD+SoHMDTt0JcbcyL3zE/p5MWOuImehD4qW8SqLnITpsYZpB3FKcFzctEY1w1WSZKkboZTL8trJ/7lazOVP9GE03IM21DVCG5Pvo8PG7+Z2gaFlrnt5uziu20SGZFlbEjQaS6P1ybNzPw2tO0ATlMYJJBXaOvFdif6Ntn6d3zpBoc3T4w6xntg9nHWM0YN2Hzaq/x9saLrQUUhToL84pXZXAhiM8PxrnE9PlTccmzl1kgEiIZXMrvzzYPK92oJsyKfioVJae0fUKjimPBu/9co+XTahucBmJmDlv5iWKYEqhxFisvJrgWAuyMCjcsbks4oN8ZO3R+e6UtgVHC4S+q+d7+hUKcV0nI37dvSYcSo8ZQRafkv0zt72ahh75vViG+rkN3aYQBdcZraSFrjkRO66E693tmHngRxyHD1Kky5e/q2rDk0G6pJrG9lUWPc7rvHSdjkDMkROf7KfqRoLGPfwpiHuqSYvgzkKQi2eRgGLIAWhd8DQvP/3d6Cy9Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199015)(2616005)(82960400001)(122000001)(316002)(186003)(38100700002)(64756008)(8676002)(6512007)(66446008)(4326008)(76116006)(66946007)(26005)(38070700005)(6506007)(91956017)(66476007)(53546011)(66556008)(6486002)(478600001)(36756003)(86362001)(31696002)(83380400001)(6916009)(31686004)(71200400001)(8936002)(5660300002)(41300700001)(4744005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Vjd5VVRnYkUrRTNGU1ZOYVRJbkJmdHhZTm9QMmFFY2w2UWJMMXNDUkszU0t6?=
 =?utf-8?B?bkRrSC90bWFHeUtyVEMrRVQ1UnBydG1JazNSeFc4Vmw4ZDUzdy9hMlJkU2FM?=
 =?utf-8?B?UTJSOTlpU1FPNEJ4MnAvc0hoYW1jV3NFS1l6K2ZBcFlXa1J1aWNZdEVrajVP?=
 =?utf-8?B?VEppemY2YWN3Y0NvVkF0a1FidzRKYlZCSWhTYlAvQTIzdTVqZlM1aU5ic2c0?=
 =?utf-8?B?L0FTZFZWOVhZQU1NSWI1aCthcWFhMm1nTWJWNzdGOGJpMVVNNlhsTU13WHR5?=
 =?utf-8?B?b3lMVjVGSHUwYmpydTZnUWpldERuaGpWVGZYRmY0OWJQeFdBRTFPU3F0YWty?=
 =?utf-8?B?Qy9BeVhQOUZ1c1lpWEY0ZGpJMW5sbmZjRTBFRDExbFlxdjRJN0prZDFSNWxw?=
 =?utf-8?B?YVFyRzVqSDJLZ1l4RXZWUDFMRzdzQVFIUW51bGZzUTFXenpHdElDVGxZRUla?=
 =?utf-8?B?UXNQc2NUdDNiaDAxTWNqNnFVWG8rQnppQkpyQmltMkJ5WE82cENHeVQ3aSt1?=
 =?utf-8?B?MVIwa3FFRE83VGpNWk90M2dKUlVjdmlpcXdsa25QV0pNbzRLUm1mMU9vQXVD?=
 =?utf-8?B?QTA3SmxvekNscFlCWUU3KzB2aUlYRG93WmFOTGhhQlhqdGJUZEY4WlNVdlho?=
 =?utf-8?B?S3RQeHA0VVNIcmZhVFFPR2I4REQyUERhTTBUZE5QYVBWZFhRMnJXRmJ5WDFQ?=
 =?utf-8?B?MUtjZnNJdjBFL21IdEt3bUhxRUdOOWF4L1p4SzZvUXpreHNyek5uYUkxalIz?=
 =?utf-8?B?MDgvbXZzby96S0VrblFmUTZHS3RaaFlWN0tkSFhwdDZ6Z3dqWnhEdEpSU0hk?=
 =?utf-8?B?aGRCT0tXQjBKdHpCUGJ0RjhqWVk1SmU1TUErS0M4OFFTU29HQmRsTGZTdThJ?=
 =?utf-8?B?M0RzZ2ExUlZPUjRYU2R2YnpielhtakluVlV3aVlWa2RvR3gvVGpRZ0dPdnNv?=
 =?utf-8?B?Si9ZeHdFQjlpbkxrY09OUTNJdE94UE5UNTVYL1lSMXg1L0kwYzFrdFcrN0Zx?=
 =?utf-8?B?SlNIVXQ3UVJ6MGZ6UDEremNMYnZEaHczdFVhc21sZkQrQ1VGTWY1ek1wdUVJ?=
 =?utf-8?B?SVRSTTRJOXM3VU8yOGk5a240WW1CNllraFdtaWNDemc1Y2N1dHBNYlhiQ3Vy?=
 =?utf-8?B?WXJ3WVZUQmE5L3FMUkc3L1hGQVZDaklPM2F2cmJkRzI3SEV2S2NRRmlETEJl?=
 =?utf-8?B?L1ZlaCtIQXU3VTRKbFNoalZwTnArL3UwRDRXQlZPQWhhWk1hMFhDVlBKK3I0?=
 =?utf-8?B?elJUdndjVXEwbjU4ZlVpaWF2Q2FrMktwZ0ZDdTlFenpNQ1F4L3hMUjJTd1da?=
 =?utf-8?B?K3NhakFLbStRcExKNWM2MHloVDFsc2c4YXZ5eHovTGFJQk5HSlcySHo5cUtL?=
 =?utf-8?B?S3JLMW96N1ZRaWtSOHl5R3U2aTNVV3QybjU3ejBhUm5SR1J1bUMrZjlkL3hj?=
 =?utf-8?B?aFg3cmR4WGk4T2VjVlcyT0tzeXRTVE5XdTdocWFXMGN3cEcvcjRReFZQWTVC?=
 =?utf-8?B?SW1kcEdjdjZZYjlOR0ZZR05nSWpxeDRuL2h4V2NCbjFLNEgvSEpKRWsxSmsw?=
 =?utf-8?B?UkNUUTBXVkR5WnR4czB2YXN1T1JUUUJ3MnNvck9TUW1UOTUwRnIwZkV2amZ3?=
 =?utf-8?B?ei9zdUxhb2wxY0FZQnRRUGdkZVlocmE4RXdVUXJ6cUhDV2oxVC9WdDU0dzJT?=
 =?utf-8?B?c1FIUVQ4RlJUcVhBWjFYcFZZWEhDaVhSRXg5eG9uaDJleUYwMWQ4OU5XRWFR?=
 =?utf-8?B?YTNTMjNoNDBlaVJPYzRkUWEyeXIzTXJLcGh6cEhpMjNnNnBrcEk5TmtmNVFx?=
 =?utf-8?B?cmJiZEpVcWpNTXRUSC9UY01qY1AxZ3FpcDdWdUQ2V3hMY1YrMzJxR0tZajlj?=
 =?utf-8?B?QzczRk44SjBzZHM0NHhPVFR1QjBzZklKdHFvUERBbzZjcUpPam5yZ092WFV4?=
 =?utf-8?B?UGx0Y2JqK2RGa0d4SCtPMXdSd0pxWWpEYVFHVHlndlNSNkR0VkFSQlBTZzFj?=
 =?utf-8?B?MldnYWV4T1RnWFl5STNockN2d2NRTHdmd20ydmNKZThKTVRFZFJ5RmoyN1BB?=
 =?utf-8?B?S0hJMjVRRnVBTmNuNlhqRFVBczArTVVncU9kS2F6ekd1eksyYSt6UXd1U25j?=
 =?utf-8?Q?hkwP2Lq9295IumJuYLcrgxEgY?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9CE40603688BDE43BE93E50B430BC70B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e073dec-df95-4d81-874e-08daa5455b8d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 13:44:13.3206
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VuCKPKrsLLFdsWC0p+Q+VlREN+P9ANyae+fRR2QG3xb5puruLKaBXufRfKQbmRpIDwywSI9zgu/DsCr2EtnMYZKiw6eEpCjKHA0ZoDkm8Lk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6719

T24gMjkvMDkvMjAyMiAxMTowMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IExpa2UgZG9uZSBwcmV2
aW91c2x5IGZvciB0aGUgaHlwZXJ2aXNvciBhbmQgZWxzZXdoZXJlLg0KPg0KPiAxOiBzdXBwcmVz
cyBHTlUgbGQgMi4zOSB3YXJuaW5nIGFib3V0IFJXWCBsb2FkIHNlZ21lbnRzDQo+IDI6IHNpbGVu
Y2UgR05VIGxkIDIuMzkgd2FybmluZyBhYm91dCBleGVjdXRhYmxlIHN0YWNrcw0KDQpJJ3ZlIHRh
a2VuIHRoZXNlLCBhbmQgZHJvcHBlZCB0aGUgYC1uby1waWVgLCBidXQgdGhlcmUncyBzb21ldGhp
bmcgZWxzZSB0b28uDQoNCiRyZWFkZWxmIC1XYSB0ZXN0cy9leGFtcGxlL3Rlc3QtaHZtNjQtZXhh
bXBsZQ0KLi4uDQoNCk5vIHZlcnNpb24gaW5mb3JtYXRpb24gZm91bmQgaW4gdGhpcyBmaWxlLg0K
DQpEaXNwbGF5aW5nIG5vdGVzIGZvdW5kIGluOiAubm90ZQ0KwqAgT3duZXLCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgRGF0YSBzaXplIMKgwqDCoCBEZXNjcmlwdGlvbg0KwqAgR05VwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAweDAwMDAwMDIwwqDCoMKgIE5UX0dOVV9Q
Uk9QRVJUWV9UWVBFXzDCoMKgwqAgwqDCoMKgwqDCoA0KUHJvcGVydGllczogeDg2IGZlYXR1cmUg
dXNlZDogeDg2LCA8Y29ycnVwdCB0eXBlICgwKSBkYXRhc3o6IDB4YzAwMTAwMDI+DQoNCnJlYWRl
bGY6IFdhcm5pbmc6IG5vdGUgd2l0aCBpbnZhbGlkIG5hbWVzeiBhbmQvb3IgZGVzY3N6IGZvdW5k
IGF0IG9mZnNldA0KMHgzMA0KcmVhZGVsZjogV2FybmluZzrCoCB0eXBlOiAweDEyLCBuYW1lc2l6
ZTogMHgwMDAwMDAwNCwgZGVzY3NpemU6DQoweDAwMDAwMDA0LCBhbGlnbm1lbnQ6IDgNCg0KDQpJ
dCdzIG9ubHkgaHZtNjQgd2hpY2ggcmVhZHMgYXMgY29ycnVwdCwgc28gSSB0aGluayB0aGVyZSdz
IHNvbWUNCmNvbGxhdGVyYWwgZGFtYWdlIHdpdGggdGhlIGNvbnZlcnNpb24gYmV0d2VlbiBFTEY2
NCBhbmQgRUxGMzIuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 14:42:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 14:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414901.659324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofMdr-0003DH-QJ; Mon, 03 Oct 2022 14:41:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414901.659324; Mon, 03 Oct 2022 14:41:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofMdr-0003DA-NR; Mon, 03 Oct 2022 14:41:59 +0000
Received: by outflank-mailman (input) for mailman id 414901;
 Mon, 03 Oct 2022 14:41:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9qkJ=2E=arm.com=peter.hoyes@srs-se1.protection.inumbo.net>)
 id 1ofMdq-0003D4-Nx
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 14:41:58 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 8683f197-4329-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 16:41:56 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33F50176B;
 Mon,  3 Oct 2022 07:42:01 -0700 (PDT)
Received: from e125920.arm.com (unknown [10.57.80.219])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 38DCC3F73B;
 Mon,  3 Oct 2022 07:41:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8683f197-4329-11ed-964a-05401a9f4f97
From: Peter Hoyes <peter.hoyes@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	diego.sueiro@arm.com,
	Peter Hoyes <Peter.Hoyes@arm.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Date: Mon,  3 Oct 2022 15:42:16 +0100
Message-Id: <20221003144216.2297632-1-peter.hoyes@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Peter Hoyes <Peter.Hoyes@arm.com>

The xendomains script uses the output of `xl list -l` to collect the
id and name of each domain, which is used in the shutdown logic, amongst
other purposes.

The linked commit added a "domid" field to libxl_domain_create_info.
This causes the output of `xl list -l` to contain two "domid"s per
domain, which may not be equal. This in turn causes `xendomains stop` to
issue two shutdown commands per domain, one of which is to a duplicate
and/or invalid domid.

To work around this, make the LIST_GREP pattern more restrictive for
domid, so it only detects the domid at the top level and not the domid
inside c_info.

Fixes: 4a3a25678d92 ("libxl: allow creation of domains with a specified
or random domid")
Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
---
 tools/hotplug/Linux/xendomains.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hotplug/Linux/xendomains.in b/tools/hotplug/Linux/xendomains.in
index 334d244882..70f4129ef4 100644
--- a/tools/hotplug/Linux/xendomains.in
+++ b/tools/hotplug/Linux/xendomains.in
@@ -211,7 +211,7 @@ get_xsdomid()
     fi
 }
 
-LIST_GREP='(domain\|(domid\|(name\|^    {$\|"name":\|"domid":'
+LIST_GREP='(domain\|(domid\|(name\|^    {$\|"name":\|^        "domid":'
 parseln()
 {
     if [[ "$1" =~ '(domain' ]] || [[ "$1" = "{" ]]; then
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 15:04:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 15:04:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414909.659335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofMz2-0005iR-Ie; Mon, 03 Oct 2022 15:03:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414909.659335; Mon, 03 Oct 2022 15:03:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofMz2-0005iK-Fb; Mon, 03 Oct 2022 15:03:52 +0000
Received: by outflank-mailman (input) for mailman id 414909;
 Mon, 03 Oct 2022 15:03:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=g5U8=2E=redhat.com=vkuznets@srs-se1.protection.inumbo.net>)
 id 1ofMz0-0005iE-Tj
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 15:03:51 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95acdf2f-432c-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 17:03:49 +0200 (CEST)
Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com
 [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-217-VFdEnWKYMFCP8kgOCb-3NA-1; Mon, 03 Oct 2022 11:03:46 -0400
Received: by mail-wm1-f72.google.com with SMTP id
 f25-20020a7bc8d9000000b003b4768dcd9cso2985971wml.9
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 08:03:44 -0700 (PDT)
Received: from fedora (nat-2.ign.cz. [91.219.240.2])
 by smtp.gmail.com with ESMTPSA id
 r18-20020a05600c35d200b003a84375d0d1sm17657403wmq.44.2022.10.03.08.03.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 03 Oct 2022 08:03:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95acdf2f-432c-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1664809428;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Jcy8kZYpXeDbLsYPjZ2qO+Lh7p/Rgt7Xact/w0g7X3E=;
	b=ZNTFGaW5wK0paW+y1ILVjF0YVbycZy3t1+xGtB3zHa8DiobqBqjB71BPlEl/H61zKo19cc
	NUW0Zsd+2N8XoOJuvqQxoHKYP/VFcmU2fDKUuvMoSnqhQA6cASPjLdkH++qdV3EJLKFpxY
	z7WOCUenaINzUdKetLWdTGTUhH0gYgs=
X-MC-Unique: VFdEnWKYMFCP8kgOCb-3NA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:references
         :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date;
        bh=zlSyGCvWo5iRyh04tGy8TsPBqO2ZA147cE0Y4mnczLc=;
        b=Zz9RUqzuMd0VwWA9xNN4cFTqlCEkgIXYjj45/VWwru7OdkFMsbquYWPuuKizJuICfd
         y+uabZxSv6hd7xkd+uvKIfaVg0e6t1NGsQhdwCRYactNp6PP//cH5hLw1jM1oGpycs19
         y8UJGLAUv+MnHpl9k0csO72fAkuEaHHmBrit3hh+V+GmmYZznDgwXvqc8LPV9do1Nji/
         0anMCtSPz0cukztuUZVAoQ1CZZ63IOxAJThlUaiz/6qEVwyDM0+vZJ5PvEoyeEKgJ0ij
         jabdbU3T4DK7EewcnU6UbW4RkpFlCeUc5Z300EJagCbaZ5YKEt2plsRyyEH/1W6H8OSt
         goew==
X-Gm-Message-State: ACrzQf1BBsovIoxP+pqRoan/I9Xz6Gp/UEA/YyNFD/sfXsHDj8K1SvXE
	HZYxovD/OLK3q57TNJ2RzInv41zyVj1GrHeOBfPMLYv2VF/vaqhAJ8Ij8oQ7lHJuTA4zP3hEoMR
	RZr+ce/B7UhquyXr3FrNLLF3i4bg=
X-Received: by 2002:a05:600c:4e8b:b0:3b4:c8ce:be87 with SMTP id f11-20020a05600c4e8b00b003b4c8cebe87mr7593506wmq.157.1664809423568;
        Mon, 03 Oct 2022 08:03:43 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4sxlC5XJOgl9QDu564seFf1Ssz0/+BFurAjD66iPYPfhV1hEDgomWrdFD2cOYxCQVBT8cYyA==
X-Received: by 2002:a05:600c:4e8b:b0:3b4:c8ce:be87 with SMTP id f11-20020a05600c4e8b00b003b4c8cebe87mr7593479wmq.157.1664809423275;
        Mon, 03 Oct 2022 08:03:43 -0700 (PDT)
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Ajay Kaher <akaher@vmware.com>
Cc: "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
 "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "rostedt@goodmis.org" <rostedt@goodmis.org>, Srivatsa Bhat
 <srivatsab@vmware.com>, "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
 Alexey Makhalov <amakhalov@vmware.com>, Vasavi Sirnapalli
 <vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
 <er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
 Nadav Amit <namit@vmware.com>, "linux-hyperv@vger.kernel.org"
 <linux-hyperv@vger.kernel.org>, "kvm@vger.kernel.org"
 <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
 <jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
 <xen-devel@lists.xenproject.org>, "acrn-dev@lists.projectacrn.org"
 <acrn-dev@lists.projectacrn.org>, "helgaas@kernel.org"
 <helgaas@kernel.org>, "bhelgaas@google.com" <bhelgaas@google.com>,
 "tglx@linutronix.de" <tglx@linutronix.de>, "mingo@redhat.com"
 <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, Alexander
 Graf <graf@amazon.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
In-Reply-To: <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com>
 <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
Date: Mon, 03 Oct 2022 17:03:41 +0200
Message-ID: <87tu4l9cfm.fsf@redhat.com>
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ajay Kaher <akaher@vmware.com> writes:

>> =EF=BB=BFOn 13/09/22, 7:05 PM, "Vitaly Kuznetsov" <vkuznets@redhat.com> =
wrote:
>>>
>>> Thanks Vitaly for your response.
>>>
>>> 1. we have multiple objects of struct pci_raw_ops, 2. adding 'priority'=
 field to struct pci_raw_ops
>>> doesn't seems to be appropriate as need to take decision which object o=
f struct pci_raw_ops has
>>> to be used, not something with-in struct pci_raw_ops.
>>
>> I'm not sure I follow, you have two instances of 'struct pci_raw_ops'
>> which are called 'raw_pci_ops' and 'raw_pci_ext_ops'. What if you do
>> something like (completely untested):
>>
>> diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x=
86.h
>> index 70533fdcbf02..fb8270fa6c78 100644
>> --- a/arch/x86/include/asm/pci_x86.h
>> +++ b/arch/x86/include/asm/pci_x86.h
>> @@ -116,6 +116,7 @@ extern void (*pcibios_disable_irq)(struct pci_dev *d=
ev);
>> extern bool mp_should_keep_irq(struct device *dev);
>>
>> struct pci_raw_ops {
>> +       int rating;
>>          int (*read)(unsigned int domain, unsigned int bus, unsigned int=
 devfn,
>>                                                int reg, int len, u32 *va=
l);
>>          int (*write)(unsigned int domain, unsigned int bus, unsigned in=
t devfn,
>> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
>> index ddb798603201..e9965fd11576 100644
>> --- a/arch/x86/pci/common.c
>> +++ b/arch/x86/pci/common.c
>> @@ -40,7 +40,8 @@ const struct pci_raw_ops *__read_mostly raw_pci_ext_op=
s;
>>  int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int de=
vfn,
>>                                                 int reg, int len, u32 *v=
al)
>> {
>> -       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>> +       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>> +           (!raw_pci_ext_ops || raw_pci_ext_ops->rating <=3D raw_pci_op=
s->rating))
>>                 return raw_pci_ops->read(domain, bus, devfn, reg, len, v=
al);
>>         if (raw_pci_ext_ops)
>>                 return raw_pci_ext_ops->read(domain, bus, devfn, reg, le=
n, val);
>> @@ -50,7 +51,8 @@ int raw_pci_read(unsigned int domain, unsigned int bus=
, unsigned int devfn,
>>  int raw_pci_write(unsigned int domain, unsigned int bus, unsigned int d=
evfn,
>>                                                 int reg, int len, u32 va=
l)
>> {
>> -       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>> +       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>> +           (!raw_pci_ext_ops || raw_pci_ext_ops->rating <=3D raw_pci_op=
s->rating))
>>                 return raw_pci_ops->write(domain, bus, devfn, reg, len, =
val);
>>          if (raw_pci_ext_ops)
>>                 return raw_pci_ext_ops->write(domain, bus, devfn, reg, l=
en, val);
>>
>> and then somewhere in Vmware hypervisor initialization code
>> (arch/x86/kernel/cpu/vmware.c) you do
>>
>>  raw_pci_ext_ops->rating =3D 100;
>
> Thanks Vitaly, for your review and helping us to improve the code.
>
> I was working to make changes as you suggested, but before sending v3 wou=
ld like to
> discuss on following:
>
> If we add rating with-in struct pci_raw_ops then we can't have pci_mmcfg =
as const,
> and following change is must in arch/x86/pci/mmconfig_64.c:
>
> -const struct pci_raw_ops pci_mmcfg =3D {
> +struct pci_raw_ops pci_mmcfg =3D {
>  =09.read =3D=09=09pci_mmcfg_read,
>  =09.write =3D=09pci_mmcfg_write,
> };
>
> So to avoid this change, is it fine to have global bool prefer_raw_pci_ex=
t_ops?
>
> And raw_pci_read() will have following change:
>
> -=09if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
> +=09if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
> +=09     (!prefer_raw_pci_ext_ops ||  !raw_pci_ext_ops)
>

Not my but rather PCI maintainer's call but IMHO dropping 'const' is
better, introducing a new global var is our 'last resort' and should be
avoided whenever possible. Alternatively, you can add a
raw_pci_ext_ops_preferred() function checking somethin within 'struct
hypervisor_x86' but I'm unsure if it's better.

Also, please check Alex' question/suggestion.

...

--=20
Vitaly



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 15:18:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 15:18:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414915.659345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNDO-0007EY-Ox; Mon, 03 Oct 2022 15:18:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414915.659345; Mon, 03 Oct 2022 15:18:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNDO-0007ER-MH; Mon, 03 Oct 2022 15:18:42 +0000
Received: by outflank-mailman (input) for mailman id 414915;
 Mon, 03 Oct 2022 15:18:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TmDc=2E=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofNDN-0007EL-Px
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 15:18:42 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a1075b0c-432e-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 17:18:29 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id E34D032003D3;
 Mon,  3 Oct 2022 11:18:34 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Mon, 03 Oct 2022 11:18:35 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 11:18:33 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1075b0c-432e-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664810314; x=
	1664896714; bh=Py0ty9ifkS6fLvi4hjmq1ycGUuwx6IScsmBddMLzPWU=; b=V
	rRF51RMI8oANz1XxQNAcGR/QlH50xQL5scFfPG00HlS89olSMC7BQ6Gr3jOlpmKs
	FT+PS6ompEhwru8DZaWhG3zftnDu7Lref69Ub5aa5BErFy2OtKwC3xbMQewfSTbO
	puW4WkD7+B3hWl5BphOLcXdz600hdW+leMW54eycyIC307I14IUH4M+bahaImoTy
	nNUKzvQkj+aLATv7/P5he1KF3JlechvlFqRzhahCZb4CtYdZmWsMhbGnzeHmY2BF
	27olmYby5sNriGwPdFGDf9SpLZG4UoM31ZVdHqS6o+PYBBYhkmEd90xb0T/e3T8Z
	pfmrSrpcuqgKa04RkXx7A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664810314; x=1664896714; bh=Py0ty9ifkS6fLvi4hjmq1ycGUuwx
	6IScsmBddMLzPWU=; b=z2zesEfRcXGt+xEOhQZLsbOeanVP/lIoTLZGeEhTvRWA
	4d21aV9sgFc44Zni03Il5HQqILUpflH6xlvKoyED9iklewILcn5LWHkJTBpLw0Nz
	JCoSMKO/KjcJihgT/3Hp1NUFRCjARCM4Qf19T+FT/O8P9vxag+js8YhiPI1St8YH
	fFhncL8lhD0QZcW6AVWaTrlOwNE/SAXPeCgnBWu1IQLlZ1eOfRK9DiPJgLpxwP5M
	VjsmiqNcoYSDxY43x8soK4WY6YlF73MFep2WUHvkcRVSKQCYH8SZaO0VJkhnO0eC
	VGICMBB2SfGfRaVQ7ey07IIsbYO2btgqPYazJU9wXg==
X-ME-Sender: <xms:Sv06Y1RKu8ncaBd9MazYHjbTM3_DHt_U8gaKAi5ht8luH38eQkUzRw>
    <xme:Sv06Y-w57M7d-SvXhIZvux0KwVzIFOLXdv9aTJw6sJR5ewOGDbkFS_VTvoHatSEJX
    mLjww2uq54A8dQ>
X-ME-Received: <xmr:Sv06Y60Jj1vV7HExBJadrZi3kh0ZtbgRtUi6vG0ZubwcrhxVtYzdxnrP4vtI>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledgkeeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg
    jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:Sv06Y9D497QzQtkaSCYzou14tIDSRMs2EKDb2guxpBThN1-Rci430w>
    <xmx:Sv06Y-iUI9PoQkgQsiGM_m6mlbX9q4dcD9pku1YWvAhH9GmbLQFGsg>
    <xmx:Sv06YxpztdSl9eHfVqYVcZAi42OR3JVdTtBoVbpYMO00YuZKr2mwcw>
    <xmx:Sv06Y5PtPL4vlffVJ7Z3PHuA0h0lEyvweVheNCyaPCJz0VQlTq9yKQ>
Feedback-ID: iac594737:Fastmail
Date: Mon, 3 Oct 2022 11:18:06 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 4/6] efi: memmap: Disregard bogus entries instead of
 returning them
Message-ID: <Yzr9R2ziBAJgzAqR@itl-email>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-5-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="M+fOFbwZi3N7oSNW"
Content-Disposition: inline
In-Reply-To: <20221003112625.972646-5-ardb@kernel.org>


--M+fOFbwZi3N7oSNW
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 11:18:06 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 4/6] efi: memmap: Disregard bogus entries instead of
 returning them

On Mon, Oct 03, 2022 at 01:26:23PM +0200, Ard Biesheuvel wrote:
> The ESRT code currently contains some sanity checks on the memory
> descriptor it obtains, but these can only trigger when the descriptor is
> invalid (if at all).
>=20
> So let's drop these checks, and instead, disregard descriptors entirely
> if the start address is misaligned, or the number of pages reaches
> beyond the end of the address space. Note that the memory map as a whole
> could still be inconsistent, i.e., multiple entries might cover the same
> area, or the address could be outside of the addressable VA space, but
> validating that goes beyond the scope of these helpers.
>=20
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  drivers/firmware/efi/efi.c  | 13 +++++++------
>  drivers/firmware/efi/esrt.c | 18 +-----------------
>  2 files changed, 8 insertions(+), 23 deletions(-)
>=20
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 11857af72859..55bd3f4aab28 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -461,19 +461,20 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_d=
esc_t *out_md)
>  	efi_memory_desc_t *md;
> =20
>  	if (!efi_enabled(EFI_MEMMAP)) {
> -		pr_err_once("EFI_MEMMAP is not enabled.\n");
> +		pr_warn_once("EFI_MEMMAP is not enabled.\n");
>  		return -EINVAL;
>  	}
> =20
> -	if (!out_md) {
> -		pr_err_once("out_md is null.\n");
> -		return -EINVAL;
> -        }
> -

Nit: this seems unrelated.

>  	for_each_efi_memory_desc(md) {
>  		u64 size;
>  		u64 end;
> =20
> +		/* skip bogus entries */
> +		if ((md->phys_addr & (EFI_PAGE_SIZE - 1)) ||
> +		    (md->phys_addr > 0 &&
> +		     (md->num_pages > (U64_MAX - md->phys_addr + 1) >> EFI_PAGE_SHIFT)=
))
> +			continue;

Should this also check if md->num_pages is 0?  Also, should this check
be part of for_each_efi_memory_desc()?

> +
>  		size =3D md->num_pages << EFI_PAGE_SHIFT;
>  		end =3D md->phys_addr + size;
>  		if (phys_addr >=3D md->phys_addr && phys_addr < end) {
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index 2a2f52b017e7..8f86f2b0734b 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -247,9 +247,6 @@ void __init efi_esrt_init(void)
>  	int rc;
>  	phys_addr_t end;
> =20
> -	if (!efi_enabled(EFI_MEMMAP))
> -		return;
> -
>  	pr_debug("esrt-init: loading.\n");
>  	if (!esrt_table_exists())
>  		return;
> @@ -263,21 +260,8 @@ void __init efi_esrt_init(void)
>  		return;
>  	}
> =20
> -	max =3D efi_mem_desc_end(&md);
> -	if (max < efi.esrt) {
> -		pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n",
> -		       (void *)efi.esrt, (void *)max);
> -		return;
> -	}
> -
> +	max =3D efi_mem_desc_end(&md) - efi.esrt;
>  	size =3D sizeof(*esrt);
> -	max -=3D efi.esrt;
> -
> -	if (max < size) {
> -		pr_err("ESRT header doesn't fit on single memory map entry. (size: %zu=
 max: %zu)\n",
> -		       size, max);
> -		return;
> -	}

This can still happen if the ESRT pointer is very very close to the end
of a memory map entry, unless there is another check that handles
such cases.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--M+fOFbwZi3N7oSNW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM6/UcACgkQsoi1X/+c
IsFK/BAA3eyncFILFOM4XIr//iy+YArKCUuZ1/AgikhNXeDrV/ydg2N3BSdsutHi
VZDGtuofMKthtmInOu57DQCbb/K+6FT79KVaRLtOdejEr7I77W/XmDe/gf5ijbxe
y9wTYBGXTBltM4jgd0xPtamE/bRZcK0Jad5h0R7BQOf0mmK7GQRe7Iw+ld8xR5gC
SHZ+J8D780wwrOXeIcq77IWy/YPelNtzPS23IRn7uSJkoEXFwAoUUH7FFebILE4F
VOCI3uLLKOUVrMyiRYE9K4F/uJUOt2XXzlX1ppPN+VHxRhveukWr+JfnqdAknwRT
TaxnlcF9MfeQoxZaAzImTN84z3ooAX2VpG0cNfwmZcvoKcnHFpxNhrWLlmQQXAPh
FGb/PNrwHrB8uo+AN4zATQOwE+4Hymf5MNGW0+QjXVy5kKSb0/jZ0T3sXYBTyYz9
2Jw+vw7JHTna+6x26IC6XdOk/n+lfeG/BBYXz5ii2B96DmVN6yoODQzQULMaDn3h
qjSVVdgd2hwlKylY63ENrpDUOqT1GPfvNkpTj/Knm9pP2G97z30Ru0vkNRgiglsf
Nq9THQNpxw2X17yckR7c4JQj5Y4IyKCCqYIXjwd7qykdQkPGGDSn2nCytolTU3ya
+QBQ36Jtk2+pVcQGYoTR8GESXuBWJp6KRf+nOXYTaNHBdvgDQyk=
=R1Pm
-----END PGP SIGNATURE-----

--M+fOFbwZi3N7oSNW--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 15:29:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 15:29:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414922.659357 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNNw-0000GT-Pk; Mon, 03 Oct 2022 15:29:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414922.659357; Mon, 03 Oct 2022 15:29:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNNw-0000GM-MO; Mon, 03 Oct 2022 15:29:36 +0000
Received: by outflank-mailman (input) for mailman id 414922;
 Mon, 03 Oct 2022 15:29:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TmDc=2E=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofNNv-0000GG-A0
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 15:29:35 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d421f48-4330-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 17:29:33 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 8F667320093C;
 Mon,  3 Oct 2022 11:29:29 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Mon, 03 Oct 2022 11:29:30 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 11:29:28 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d421f48-4330-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664810969; x=
	1664897369; bh=wG2UKFKUqQSuw+UKGoNFakaJTVCzILWNxG1VAloni50=; b=R
	vkhz5Z4OWL2o1RQheGBXMSCgIKsLpV/sIeJE7oVs70pGN7HvbooHhrW76evaeOwm
	BOBs1S8JwFGhbFDZIUwYgLQ7u1J5+yhva2r0TdzVlXODf4J2NZqd0GQ+YyikEQ4H
	aZfRjSN+UJvVSdAwDsSYxvlf4oSrf4vMGfRKhTMoRsAGM0wojLqMwlg2pp6p1oZX
	LRUW5DAqo9rjPvThZuRY4Dyju//fcB5IMYTCqDtGBxlXZfYydt4e7CXxQ19JXmGG
	XFhNcKzNjIXtrNcYdxdytDRSZQ+257t0nfj8NeE4h4AYZswRtTWfq10XFQ1uEfvd
	VfWvWC0g+EZlNbpJ45i8A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664810969; x=1664897369; bh=wG2UKFKUqQSuw+UKGoNFakaJTVCz
	ILWNxG1VAloni50=; b=hCro7hdOVhZFbKkbMuLxf2veLrel6GzkmLgJDtfpnowE
	Vfq6wpZAvxpC0hGzmnWl33ELsf8/Bsr0J1UnhePN+4GlTlbsIxFYKxrd0Ov1hjCG
	GlKEd28TZWjnpTer4mJSL0IhKXNrp/+JC73bcPtVBtvsOxJmkzbZFApqHaN790cy
	k70lbyp/zhO90puuSjkGIeXJsYMf4oh6p1ZeIjhe7qsriThezWR1z8EU/572rbbj
	+QBUZraJlKelf/AZPLyIK79j35t9zgi1AQ++uuvOqY7WXbKPHsu5u6Vp5wDVtqzk
	GnJpZrcyj3couu2alRgG3n3HbpyIH0/0LnPLkEjAdQ==
X-ME-Sender: <xms:2P86Y9mikPGuNdC5YzGQSE0SgnQjW2-JzXiksOpbEQw1SyfBz31ccw>
    <xme:2P86Y41o5mKQ7aEmD8-0SCI3D6_2x3v61_rt_JXkLQrIoiCqsTiY_iiPAh0b4cqA3
    icrualvUymqb_k>
X-ME-Received: <xmr:2P86YzqKZb3wW3PyEgcrDkbRyIZsXJGVo2xud296gByrPTIKDCrIUcLCkVAz>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledgkeekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg
    jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:2P86Y9lix9xFS71wtW7P_Nm9Qk2RgLybs_fkjrtg8BepCrfyLU68jA>
    <xmx:2P86Y73QA64X64NYjuaRBc_HfzZDz5bA79myIKq4hv64jWaNXZlr1A>
    <xmx:2P86Y8tKTFrzW7apbeuIrclxjqjvu4pQEeuGzpOmm4gXG3PjttiEYQ>
    <xmx:2f86Y0sMpDzZVSvj9ZLf2H6wVcnLMO4Z7kESFOjws_Zh9QScMDOllg>
Feedback-ID: iac594737:Fastmail
Date: Mon, 3 Oct 2022 11:29:22 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall
Message-ID: <Yzr/1s9CbA0CClmt@itl-email>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-6-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="zLmjlM2QchXxvY8s"
Content-Disposition: inline
In-Reply-To: <20221003112625.972646-6-ardb@kernel.org>


--zLmjlM2QchXxvY8s
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 11:29:22 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: xen-devel@lists.xenproject.org, Peter Jones <pjones@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall

On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> Xen on x86 boots dom0 in EFI mode but without providing a memory map.
> This means that some sanity checks we would like to perform on
> configuration tables or other data structures in memory are not
> currently possible. Xen does, however, expose EFI memory descriptor info
> via a Xen hypercall, so let's wire that up instead.
>=20
> Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  drivers/firmware/efi/efi.c |  5 ++-
>  drivers/xen/efi.c          | 34 ++++++++++++++++++++
>  include/linux/efi.h        |  1 +
>  3 files changed, 39 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 55bd3f4aab28..2c12b1a06481 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
>   * and if so, populate the supplied memory descriptor with the appropria=
te
>   * data.
>   */
> -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
>  {
>  	efi_memory_desc_t *md;
> =20
> @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_des=
c_t *out_md)
>  	return -ENOENT;
>  }
> =20
> +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> +	 __weak __alias(__efi_mem_desc_lookup);
> +
>  /*
>   * Calculate the highest address of an efi memory descriptor.
>   */
> diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> index d1ff2186ebb4..74f3f6d8cdc8 100644
> --- a/drivers/xen/efi.c
> +++ b/drivers/xen/efi.c
> @@ -26,6 +26,7 @@
> =20
>  #include <xen/interface/xen.h>
>  #include <xen/interface/platform.h>
> +#include <xen/page.h>
>  #include <xen/xen.h>
>  #include <xen/xen-ops.h>
> =20
> @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
>  	efi.get_next_high_mono_count	=3D xen_efi_get_next_high_mono_count;
>  	efi.reset_system		=3D xen_efi_reset_system;
>  }
> +
> +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> +{
> +	static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT,
> +		      "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT");
> +	struct xen_platform_op op =3D {
> +		.cmd =3D XENPF_firmware_info,
> +		.u.firmware_info =3D {
> +			.type =3D XEN_FW_EFI_INFO,
> +			.index =3D XEN_FW_EFI_MEM_INFO,
> +			.u.efi_info.mem.addr =3D phys_addr,
> +			.u.efi_info.mem.size =3D U64_MAX - phys_addr,
> +		}
> +	};
> +	union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_info;
> +	int rc;
> +
> +	if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
> +		return __efi_mem_desc_lookup(phys_addr, out_md);
> +
> +	rc =3D HYPERVISOR_platform_op(&op);
> +	if (rc) {
> +		pr_warn("Failed to lookup header 0x%llx in Xen memory map: error %d\n",
> +			phys_addr, rc);
> +	}
> +
> +	out_md->phys_addr	=3D info->mem.addr;

This will be equal to phys_addr, not the actual start of the memory
region.

> +	out_md->num_pages	=3D info->mem.size >> EFI_PAGE_SHIFT;

Similarly, this will be the number of bytes in the memory region
after phys_addr, not the total number of bytes in the region.  These two
differences mean that this function is not strictly equivalent to the
original efi_mem_desc_lookup().

I am not sure if this matters in practice, but I thought you would want
to be aware of it.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--zLmjlM2QchXxvY8s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM6/9UACgkQsoi1X/+c
IsHMOhAA333zIIHGob9IRTKkPT5IATDtd4wbALXjdQHsN3w7QV6STKKKkFY814ox
IvP7PMuPnRRZqHryNQLEtEYma41/clUZrBGxBcormyIUe2MJS9ZhZ0CZeUfWIlBA
V9yoKbmix0lfTxJaVuKtqc7BV20hARD0Uc5kxqZqJJ9WBJKtgxijBuaMkqXXYL1q
zRKFfyME35rcTYbBrjXFuiyJxfcSIIF9SWusd683vRLyUVaQafs8SpClc7A+zhCW
tRVnZ8jkPoKYVyBcalq+lxisCQiVuxio5HweNGqpEAM7gfhiqnfUw1orMEGzd1JK
LAza+q/6RbFL1q10zlvm7aL7xypiRgATef2wKY5jK0MqbYOGCBf2G5g9GDWOWZCL
a5r3rqmUXNIYaDYFm7myL9L5/+jtaORUDxzTexNa/7T1su9WCoXLe4eHZwl5zuYK
PTqn2bO5tUrRnCDBNSM2BAFkkUPX/9P3umM/iRauUuRGZER48mmwbImLx4H0lQ3v
IUARS3Jy8eliuI0fPxAUhY1RguxnhSUgxlAol+hcrE+92fFzKXSFRWb9iBz0xlAk
nD1uwI+geDIVE2NDm3IO3j4RqOSGl6BZnpmTxQrMBx7Vy9SFCMVYr3c0VU3zlsFw
/UJnOIEZhGlEdEucnYq8uNZbx8adJxD/9E8s0wLWZaKgRYUt60s=
=O4Xp
-----END PGP SIGNATURE-----

--zLmjlM2QchXxvY8s--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 15:36:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 15:36:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414931.659368 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNUl-0001mq-KA; Mon, 03 Oct 2022 15:36:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414931.659368; Mon, 03 Oct 2022 15:36:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNUl-0001mj-HM; Mon, 03 Oct 2022 15:36:39 +0000
Received: by outflank-mailman (input) for mailman id 414931;
 Mon, 03 Oct 2022 15:36:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bYUz=2E=citrix.com=prvs=2680ed0a5=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ofNUk-0001md-Ah
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 15:36:38 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 25a7f957-4331-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 17:36:32 +0200 (CEST)
Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 03 Oct 2022 11:36:25 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by DM4PR03MB6999.namprd03.prod.outlook.com (2603:10b6:8:45::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.30; Mon, 3 Oct
 2022 15:36:22 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%7]) with mapi id 15.20.5676.030; Mon, 3 Oct 2022
 15:36:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25a7f957-4331-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664811392;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=LdOKGX8bJmrJEhyC3iL/fLVfztRgHIFPJ4QQ/cJd2Os=;
  b=ay9GZ0qh2VRIMq84tkFSV3Svt/A7n6AZDIzBjwdvFO9MMX45fvZmrWe6
   GEHlV5LXowvSJR+5iLrlxkp6ynrmyXvVyeAOMqUQEcm6pLBDvT+uDzXD9
   8QPvzNWaic0JPC2PMLAdjD+rhn2W4uLknh2bx8quFuVSMSTF/e91k5KI3
   0=;
X-IronPort-RemoteIP: 104.47.66.49
X-IronPort-MID: 81514597
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:8TggBqok8sQGwLxmZOgZT6yjC4BeBmKkZBIvgKrLsJaIsI4StFGz/
 9cnaN20SrzTNTykP5w0PZPnthk2DaWlyodkGgdo/n03FHwR8ZGdC93IJ02pM3mZfsHPEhI/4
 8sUZNXOJcxkQ3GArU6nO+C8oHItjPnZGev3BLDIY3EpG2eIJMtZZTdLwobV1aY00YjR73qxh
 O7PT+3j1H6N0DIqYjJMu/rb+Bph4/6t5DlC51Y0OqBHt1XUmyRKB5lOea3pI3XGGYQFReTSq
 8Qvbl2a1jiAo0pyUIPNfpLTKBBirmv6ZFDW4pZuc/H+xEIE/kTe645jXNIEc0Bblj6VqN54z
 dRJpPSYRBwge6bBg4zxaTEBe81FFfAAqeSvzUSX65TJlRSeKyC0mZ2CMWltVWEm0rcvaY1x3
 aRwxAAlNnirm++wybSnfehg7uxLwB7DZd53VtlIlFk1PN5+KXzxa/yiCexwhV/csvtmD/fGD
 /f1XBI0BPj2j7+jDX9MYH42tL/AanAS6FS0onrNzUY8yzC7IACcTNEBmTcaEzCHbZw9o6qWm
 o7J10v8WkpBH9qc9QbGoyj1gcGQvQmnYatHQdVU9tYy6LGS7ko6LURMEH6E+7y+gEP4XM9DI
 UsJ/CZotbI16EGgUtj6WVu/vWKAuRkfHdFXFoXW6inUkvaSv1nfWDZCEm8phN8O7afaQRQF2
 1iTkN6vKSFptLSNYXmc6q2VvXW5Pi19wWoqNXZZFFdYsoaLTIcbry/WV+psC7WJhcDXQx2t5
 2uhiDcxiOBG5SIM/+DhlbzduBq8q56MQgMr6wH/WmO+8hg/dIOjf5av61XQ8bBHNonxZkODp
 2QDncW25eUHH5aL0ieKBvgOdJmk5/+fNTraqVpuGYQx+TOw/XKqYYFX5nd5PkgBGswDZSPgZ
 En7sAZY9phVenCtaMdKj5mZDs0rye3lCo7jX/WNNN5WOMAtJUmA4T1kYlOW0yb1ik8wnKojO
 JCdN8GxEXIdDqchxz2zLwsA7YIWKukF7Tu7bfjGI96PiNJyuFb9pW85DWaz
IronPort-HdrOrdr: A9a23:w6HFNqkeutTGHBxKjwWBroUg7i7pDfOWimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdC9qXO1z+8X3WBjB8bbYOCGghrhEGgG1+ffKlLbakrDH4JmtJ
 uIEJIOQ+EYb2IK6/oSiTPQe7lP/DDtytHLuQ6q9QYIcegcUdAE0+4WMGamO3wzYDMDKYsyFZ
 Ka6MYCjSGnY24rYsOyAWRAd/TfpvXQ/aiWLCIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C
 zsjxH53KO+qPu2oyWsm1M7rq4m1+cJ+OEzRfBkufJlagkETTzYJ7iJbofy8gzdZtvfqmrC3u
 O85ivIdP4DkE85NlvF2ycFnTOQmgrGokWStWOwkD/tp9f0Syk9DNcEjYVFcgHB405lp91k1r
 lXtljpwKa+nXv77VnADvXzJmRXf3CP0A4fuP9Wi2YaXZoVabdXo4Ba9ERJEI0YFCa/7Iw8Cu
 FhAMzV+f4TKDqhHjnkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4QZhZ4O
 bPNLhuidh1P7krRLM4AP1ETdq8C2TLTx6JOGWOIU7/HKVCIH7Jo46f2sRG2AhrQu168HIfou
 WxbLoDjx9MR6vHM7zx4LRbthbQXW66QTPhjslD+pkRgMyNeIbW
X-IronPort-AV: E=Sophos;i="5.93,365,1654574400"; 
   d="asc'?scan'208";a="81514597"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SYPiIVU0AE6JD3lWryyBt4Rj8aPl3ZwuGmoGpT9AApIsz66hMUNUsq7mdMuR+jUhln1QocmrsA0sEnYCPXixh8RcPtt89qi8edzJsFosZskd45gBYxJBLKcyk4Ulp67MrEr7lmSLSDxDcgcKICnRdn+oG3HlQmiJKAcnf+QLhBhLjog+zAEMqR5mBbss0G6lWvKef9cL0+a0F5edtvw23zPI+I3NOl0ezgcp5tVVvIf8+t70aXDSUxwbw/QxxVv96PE6jtkKGIQmVomPr+vk2maT44gecz2I1OETpSPogxWtXNpIvlRpoZUfjiKE3bEDxaZe93ELg0U3eDc9Wtljtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+v7Lt6xppYz2C1L+zl5aH+VAWqvbi8V9iqYxWZOcFz4=;
 b=PSLF4svmSKlSrsLvC8918XK77sskr2eFhvfxBf8y4SfFhh13k8aQd13xAea13CDR5X00zEE7mgk9gSHFqyKzKtUGqT0eQRi9MRtjmvbWHIOSRKhC4imy9i25JJGO1M7tsexUQLI9P60VF2IK0sEuPJyImieftqzd8tyzSH/KNzHbdYIAyoL2Gqn2JBYxFqUbPAT217FAnSllKAQBMRmKGmboz2njz74bWr0ZQbdGfISQM/eubJT8An+OmGlUMz9o5geQLJ/jTk9s9sMmaxES0qpL2pYfSys9euzjL5SYdNyuO9h7dS2ezQHgyxbS+nVX0mQkXksvHMbsvSwg5jPQ1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+v7Lt6xppYz2C1L+zl5aH+VAWqvbi8V9iqYxWZOcFz4=;
 b=tP4SHzhGRCsT53l567EKcyffi3rmGloly6BaEcQr2Mw4HvndxXL8yk6Ynp2rEsGomi/gVwemb5z3NMWSlB0W9SantWixj5yAIaSecA4vmDc3YwMbta7EnEG22N/YF2OGS0dBSpl4KjL2lieW3wjqiSyK8Eycu37FwQczPfG7mMQ=
From: George Dunlap <George.Dunlap@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: "Stonehouse, Robert" <rjstone@amazon.co.uk>, Evi Harmon
	<eharmon@linuxfoundation.org>, "Bottali, Natalia [C]" <bottaln@amazon.com>
Subject: Thank you for a great Xen Summit!
Thread-Topic: Thank you for a great Xen Summit!
Thread-Index: AQHY1z3j7Maw5qM4qkm8TD66C9ir8A==
Date: Mon, 3 Oct 2022 15:36:22 +0000
Message-ID: <C9D69BDB-CC87-4173-97CD-22850631EEB7@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|DM4PR03MB6999:EE_
x-ms-office365-filtering-correlation-id: e28624df-f27c-4327-2362-08daa5550669
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 9x3509kvLj06bLZHdtR+B25wWb4ryORG2puRXLno0MoZnUfqnox2rutwrPRknp9ZXbi93JOXypk7TSo/rErEi6PW8MFBEJjS7UghzL1hLnbYhCnsTc6v3b9yE2kTSffrDfh6YBlEqFEngX/Cy+rz9+n9K5bJ5R68xFKouZ3pU8koso29jHB6i1is554+80zcdxDWoG3fRVwHF3rbgbc0Cj3iEV4WpfYFmFaPtvL6h7czBtJcK3JDBKFWv5WPIvsc70fem18lXy9YXIvUD4kwKhAKRHf5N0Lwf7APkx+b8qQOwm/y95vCDCaFiz6rDHDHzUBfOcGigzdZhAulhttUmxtE2lYsf+OM904bXS8bXo75Pp4Wi8TFHjPxCvkN7xv1UASR/caXGHU3kj/W/L5tilqikLF1ZTBBexSBi/p3K54vP2C7X3fRje4cXNhbm6Muc0sg/jJf7IP6No+G3jW+DDFRvs5VaXR9CKdABjWgpM5Jwis2Zc+VjCFJfqlJQ7NMF2/bfAfOun5hdW0IRPLFAUmDAs8Dd1/YRHUN7hFeIkElGZht4FHzOFqpM/oL7G6+wR3a06ZKlXkKPzPW0o83hOGLoo9E0nE8+AjmekvV79Ok974+7xuIwnNCckpeTQl/bAWhG6nnQMIhN6vSh3Kfmv5llF0ROyrbmGvmCdgOa/2XFCKH2aXTRbmYHBg2YFhRQ6DXL+6WEUZ7RvrLwLZE48xBmSj2PTkDptasGUBjjhFkgHR3Zla13Ew/2NIbHAQyC3NJsz7t1zPEJZTW6rKofR2ImedHTqYPwtE0/SAhVxfnoUzIuSNuG7Ha2NKJ1Rcs
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199015)(26005)(38100700002)(41300700001)(122000001)(99936003)(4326008)(64756008)(66446008)(66476007)(8676002)(66556008)(91956017)(66946007)(76116006)(186003)(2906002)(2616005)(33656002)(8936002)(6506007)(4744005)(6512007)(36756003)(86362001)(5660300002)(38070700005)(71200400001)(6916009)(54906003)(478600001)(6486002)(82960400001)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?d2FyWVpacVppN0IxbDVoRkxrQUJtYWs1TUJPbmJpTWJFQitmUE5uNCtBQWJo?=
 =?utf-8?B?MWR5dzlqTys0anJudXo1UTRTdThaYUhkTTlhbU1waGwrbS9sVzVZUm56RVhV?=
 =?utf-8?B?VDlNV1AwcGJyVkJLdnVoUHE4KzlqUU1LZXhwT1pLVHNRdXVRQlBjRkFJSUJv?=
 =?utf-8?B?VEdGRGhFNnJzYWpIaHBUV0U0MHlJSHpqdld5eWd1VEJOdm04Zit0Z2crY2p5?=
 =?utf-8?B?aWgzaklKTjNwaG85OExhckx6MDNudURLUWZPRE5qU0EyLzYycVJTRWU2STV2?=
 =?utf-8?B?eFAxYUpvYzk1N1JpaC9BKzNkbmxadFdHLzJIeFowZ2Rxa0dtdVY2L2ljU1lp?=
 =?utf-8?B?WjNZZkI5RmF3YzlmVVJTTS9YeWpqZ3Q4SU5POGJNVEN1TGgxMUFMbHYvbTFN?=
 =?utf-8?B?VW9yV0VIbWRLUWM0YndBekQ2eFZBeEZoU1QxM2JHbEtONDluNnREYkc0Qkgw?=
 =?utf-8?B?Wk9Ka2JWSjRxU2FpbVprSC9EVVdQRjArUE04U1F6WW1iQlh4OUdXcnBGY29Z?=
 =?utf-8?B?TC9VTysyU05GU0xOWU4yajFvL2hieHgzVzQ0VGdXTGwwRXRaczBoa3JRQTlO?=
 =?utf-8?B?Z2RKZUVreUppWVRVMjBkeDNabDVJNW1VbWNHVG40U0tlV0Yyd0ozMFVrWkUz?=
 =?utf-8?B?NXBYQ3huL1BWa1VSL1ZST2syYVZJRy9yQVEwN3VON3dpSkprVXB1WGhjWXpE?=
 =?utf-8?B?YnB4NUZJRjh0V25VU2xsbEY5SDNrZVRwTnp6SjBwNHJ3V0lNcUlpUE8yUFJh?=
 =?utf-8?B?ZGhsMVlrSkhHc2hQVVZPWko0SlVYaXdCOEJMeVhYV1pJd1RQdmdqUk91UmZE?=
 =?utf-8?B?VDVZdnhTcng0RGpwZDJhTWVValFOOTQvTjRzQXlaR0Z3OTZTMmozV1VUaTJI?=
 =?utf-8?B?YmR5YWw1a0pKaGlqWUx1WWsycHBYU2FXSUVrWklnbnpma0s1TnBINnhMclAx?=
 =?utf-8?B?cnRWNGtPTzZJT0RKRmFxNnVoaDdGSDVQUFRCR3AwZWlJbklSSFNPQWtEN0Np?=
 =?utf-8?B?QXByb1liNWtyczA4RlRBZlZGbGMzZ2F5S2QxU0liaXF0cVZjNVhuQzlGeUJk?=
 =?utf-8?B?Kyt3WWZKNU0zUU5ONnd1bHdRa2c2bHJXZWpHNzJza056RWF2d2FPd1dnZjl6?=
 =?utf-8?B?ZWpiNFFxbW54VzNSYmJLVk1qTEpQZ1UwcVZESDhick85UnBYNFNOYXA4ZHUz?=
 =?utf-8?B?cU4wVDdwOEFiQU5aUGJkbmMxdU5FZ0laeFh3WEdJRkhrMWxNc2o1Q3dCNU5i?=
 =?utf-8?B?STIzaVRxd05RWERTelp2VEt5bS9XMzdTWmxNRnlyWmd0NDA3c1haeFpkcDU3?=
 =?utf-8?B?QWllSFkyT3FaazV1WlN0ZENOU1FLcXgxWHA2WmdGS25XOEdTZlRENUNYV2hM?=
 =?utf-8?B?NlFqdEpaanhJYzBPNnZwbUpqSmlXL0hyelU2bTBQdmNhMkpSM0Z6RlM1RWFP?=
 =?utf-8?B?Q1o4OGhsZFNUbjdKUFM2MU15RW5LOFhleGJBbGtPZ0E3TXRHWkpyNm1aeEdZ?=
 =?utf-8?B?QzBtRDhpUnVaN1hYMnBuMnA1VzZrcXZBYTRKVkZ3QU1pZm5XUDFOM1ZqRjRh?=
 =?utf-8?B?RlFpeVNJNVdWcW5kbXkybmFGckxYNkRhS1lVMmF3MFhwdTZnQTduVWE5VWp4?=
 =?utf-8?B?djRienk0bmc5azN5U3lhVkVtTnI5aHVBeVpLU2RlK3drbTNCSmRQSEJJa1Ji?=
 =?utf-8?B?S2c2eVVDellxK1AwcGFHazVhRWFYajlrNzNOaCtwTS9GVDJlbng2ZnJ2SUww?=
 =?utf-8?B?dHhvOEtlUnpYd2xjN1ZGOXVNd3JOSHVVMmpiRmtTOHdBaVJZaS91S0tvV1pm?=
 =?utf-8?B?aitBY00yNXltZVEwQ2F4eGhMd1dhSE1QblUxYnQySkcyQUFRSE9wVXcxd2pC?=
 =?utf-8?B?ZHNSWWdDM3RTLzkzbUIvWWlSU0I0TzBzY3ZEOXEwdUprb2hBaDI0aWpXR1Zp?=
 =?utf-8?B?a0o4UUgwUmVpaEl3VUFMRFp4L253aDZBaFFzZVd6TFRTN0k5UDdtNHhuWThn?=
 =?utf-8?B?bUJkL2JTN0NUZUVHbUlCRitESnNjdWU5U1hldzdVdWNicjNxL2srUUEwSjA5?=
 =?utf-8?B?SGJTc1JpTXR0cTZqOEh2K0ZrK1E4Mk1uRS8veVNIZUlLY0hLMGZ5dnZFWkFK?=
 =?utf-8?B?S3habnZVTnl4ek9rVmhZQVhtNDdzc2RKa0RNWmdkdW56bzhJT1ZvK2RkNDln?=
 =?utf-8?B?RFE9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_FE743CA3-BD9A-4215-8027-AEC4244BEA57";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e28624df-f27c-4327-2362-08daa5550669
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 15:36:22.4390
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: svgyGJap7NRZcDlKCoc3T6NpXVHMUVw1iQwJERVXWxSMix6gWzd3JtYGDrbZ9vnOPOVLw8WFXRhE+xii6Rq1PE7yH5BWXuc5iR+nEWuyyZU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6999

--Apple-Mail=_FE743CA3-BD9A-4215-8027-AEC4244BEA57
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hello all,

I just wanted to say think you to everyone who participated, both =
physically and virtually, in this years Xen Summit, for making it such a =
success.  Those of us putting on the event can put up the stage, but =
it=E2=80=99s the presenters and attendees who =E2=80=9Cmake the =
music=E2=80=9D, so to speak;  it=E2=80=99s very gratifying to see =
everyone engaged and participating.

I want to also thank the rest of the events team, who did so much =
=E2=80=9Cbehind-the-scenes=E2=80=9D work to make things happen: Evi, =
Natalia, and Robert.  There are so many things that =E2=80=9Cjust =
happened=E2=80=9D, and so many problems which they researched and =
presented me with a few simple options; the event would not have nearly =
been the same (nor me nearly as sane by the end of it) without them.

Hope to see you all next year!

Peace,
 -George Dunlap

--Apple-Mail=_FE743CA3-BD9A-4215-8027-AEC4244BEA57
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmM7AXIACgkQshXHp8eE
G+24ZAgAop7R/Ope4VLYI/GD0J110hyhSbd7UQ7zjdvdC6+JoyZVerxbQWERqY7A
ods5+48SGlfXC8kiA1cwQ1PC604MxnUqM8HtMAwXlREuAanWGDHhGoy5pFDPoAiF
p9udITkMjE+HgWuw0YEZJqw8OqLf4zvjcsfiVgeIgJnilVTQH3prZFzQc5ghpg8+
Mtn4UdwvPA7BKtJNSlO+5vclWmE1F+89dfyzd9RV6WNk68nU6p2M6CCc1QMmomJL
Ih9JDPmX6n7zV1AfH71zP8MwHUfl3RhUoxqd1iJeJ5AsHp4l97eg6FVU5MQ42BVo
oc5c4Obrtuou1sOXw3EvPUFMyLkYPg==
=EkQ7
-----END PGP SIGNATURE-----

--Apple-Mail=_FE743CA3-BD9A-4215-8027-AEC4244BEA57--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 15:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 15:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414939.659379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNpL-00048v-DH; Mon, 03 Oct 2022 15:57:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414939.659379; Mon, 03 Oct 2022 15:57:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNpL-00048o-9O; Mon, 03 Oct 2022 15:57:55 +0000
Received: by outflank-mailman (input) for mailman id 414939;
 Mon, 03 Oct 2022 15:57:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofNpK-00048i-0a
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 15:57:54 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 22d0fcab-4334-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 17:57:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 8E464B8118C
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 15:57:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA104C43142
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 15:57:49 +0000 (UTC)
Received: by mail-lf1-f46.google.com with SMTP id z4so17246682lft.2
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 08:57:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22d0fcab-4334-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664812669;
	bh=HK0PyG2JOynGOGBkEbuAK3OGKXVMbzzRaU3W5vyNt+4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=AQMIy+gZU0FZvbsFZaA/iufqEOae9NC0wo+dRflAhYnC6jnM8qSAMMBMY+3W28QKZ
	 kRwJYifri5QB9yfwmbwltmeQRWrijo0neN4OzKpExGNS60zUst3JDaOz9Nkjln/KTo
	 SoYQcATvD+6B3JC7uJA5ZWuFhPXPGwjdlWyFmV7TdIprBNkBfsC21GZ50M9btExCZa
	 TCJV52bpxRJTRoU/N+YlX8Lo02hgoxge/+vYcEnQo7jAUcPJr407xs5RjvWJoAtIT2
	 dZseqkmkGvasBrxYV6hUGHAj2Vgo+N6nhSFfen709qiFlb9Gxs3jCwjNIyibuhvO34
	 IXEA13xKVue3A==
X-Gm-Message-State: ACrzQf0l5VVDuLzwNVZUqki+/jlaMho4eP8F8hBl1Mbu+D3xdzXCXQyi
	XO1Q71ZNv/+vy+z5kMiBPVyGKJzNq+G28FMKIrA=
X-Google-Smtp-Source: AMsMyM5zBei2ibLZSe5zBohqN76AF5p5VnNKqtesYDF5KeePFuwB202Vk4nYzh88dwPErgPxMR/ChrhAsD0uBYHKM5o=
X-Received: by 2002:a05:6512:261b:b0:4a1:abd7:3129 with SMTP id
 bt27-20020a056512261b00b004a1abd73129mr7960216lfb.637.1664812667660; Mon, 03
 Oct 2022 08:57:47 -0700 (PDT)
MIME-Version: 1.0
References: <20221003112625.972646-1-ardb@kernel.org> <20221003112625.972646-5-ardb@kernel.org>
 <Yzr9R2ziBAJgzAqR@itl-email>
In-Reply-To: <Yzr9R2ziBAJgzAqR@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Mon, 3 Oct 2022 17:57:36 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHjZRdhNdBjCJkmY16a005+wSemceWWLStDWEBywUp7uA@mail.gmail.com>
Message-ID: <CAMj1kXHjZRdhNdBjCJkmY16a005+wSemceWWLStDWEBywUp7uA@mail.gmail.com>
Subject: Re: [PATCH v2 4/6] efi: memmap: Disregard bogus entries instead of
 returning them
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, 
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 3 Oct 2022 at 17:18, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Mon, Oct 03, 2022 at 01:26:23PM +0200, Ard Biesheuvel wrote:
> > The ESRT code currently contains some sanity checks on the memory
> > descriptor it obtains, but these can only trigger when the descriptor is
> > invalid (if at all).
> >
> > So let's drop these checks, and instead, disregard descriptors entirely
> > if the start address is misaligned, or the number of pages reaches
> > beyond the end of the address space. Note that the memory map as a whole
> > could still be inconsistent, i.e., multiple entries might cover the same
> > area, or the address could be outside of the addressable VA space, but
> > validating that goes beyond the scope of these helpers.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  drivers/firmware/efi/efi.c  | 13 +++++++------
> >  drivers/firmware/efi/esrt.c | 18 +-----------------
> >  2 files changed, 8 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > index 11857af72859..55bd3f4aab28 100644
> > --- a/drivers/firmware/efi/efi.c
> > +++ b/drivers/firmware/efi/efi.c
> > @@ -461,19 +461,20 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> >       efi_memory_desc_t *md;
> >
> >       if (!efi_enabled(EFI_MEMMAP)) {
> > -             pr_err_once("EFI_MEMMAP is not enabled.\n");
> > +             pr_warn_once("EFI_MEMMAP is not enabled.\n");
> >               return -EINVAL;
> >       }
> >
> > -     if (!out_md) {
> > -             pr_err_once("out_md is null.\n");
> > -             return -EINVAL;
> > -        }
> > -
>
> Nit: this seems unrelated.
>
> >       for_each_efi_memory_desc(md) {
> >               u64 size;
> >               u64 end;
> >
> > +             /* skip bogus entries */
> > +             if ((md->phys_addr & (EFI_PAGE_SIZE - 1)) ||
> > +                 (md->phys_addr > 0 &&
> > +                  (md->num_pages > (U64_MAX - md->phys_addr + 1) >> EFI_PAGE_SHIFT)))
> > +                     continue;
>
> Should this also check if md->num_pages is 0?

Yes, probably.

>  Also, should this check
> be part of for_each_efi_memory_desc()?
>

No, I don't think so. The for_each_xxx() helpers we have throughout
the kernel usually don't incorporate such checks, and I'd prefer to
adhere to the principle of least surprise here.

> > +
> >               size = md->num_pages << EFI_PAGE_SHIFT;
> >               end = md->phys_addr + size;
> >               if (phys_addr >= md->phys_addr && phys_addr < end) {
> > diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> > index 2a2f52b017e7..8f86f2b0734b 100644
> > --- a/drivers/firmware/efi/esrt.c
> > +++ b/drivers/firmware/efi/esrt.c
> > @@ -247,9 +247,6 @@ void __init efi_esrt_init(void)
> >       int rc;
> >       phys_addr_t end;
> >
> > -     if (!efi_enabled(EFI_MEMMAP))
> > -             return;
> > -
> >       pr_debug("esrt-init: loading.\n");
> >       if (!esrt_table_exists())
> >               return;
> > @@ -263,21 +260,8 @@ void __init efi_esrt_init(void)
> >               return;
> >       }
> >
> > -     max = efi_mem_desc_end(&md);
> > -     if (max < efi.esrt) {
> > -             pr_err("EFI memory descriptor is invalid. (esrt: %p max: %p)\n",
> > -                    (void *)efi.esrt, (void *)max);
> > -             return;
> > -     }
> > -
> > +     max = efi_mem_desc_end(&md) - efi.esrt;
> >       size = sizeof(*esrt);
> > -     max -= efi.esrt;
> > -
> > -     if (max < size) {
> > -             pr_err("ESRT header doesn't fit on single memory map entry. (size: %zu max: %zu)\n",
> > -                    size, max);
> > -             return;
> > -     }
>
> This can still happen if the ESRT pointer is very very close to the end
> of a memory map entry, unless there is another check that handles
> such cases.

You're right - I missed that.


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 16:00:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 16:00:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414946.659390 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNrV-0005u5-Qd; Mon, 03 Oct 2022 16:00:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414946.659390; Mon, 03 Oct 2022 16:00:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNrV-0005ty-MJ; Mon, 03 Oct 2022 16:00:09 +0000
Received: by outflank-mailman (input) for mailman id 414946;
 Mon, 03 Oct 2022 16:00:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofNrU-0005tp-I1
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 16:00:08 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73958607-4334-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 18:00:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2DBE3B81189
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 16:00:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA6E7C43140
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 16:00:05 +0000 (UTC)
Received: by mail-lj1-f179.google.com with SMTP id s17so1984455ljs.12
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 09:00:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73958607-4334-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664812806;
	bh=B3UehTQ0iZXIQsaNP2ErI1eh7d2NC3uBWlqaRsGMZ7w=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=BXw7OlQOcO+Lx8ciDJvK2GtnPEJ0AZpgO283Cm2fktlMO2+6BvB2OuTxEl3xaZH2C
	 c9mNceRiW8qc4C4dNHDsdGwPZ0pG7Rn9hGJpp6T+usgF7Eyu5KW0OG04cI1nZaBUet
	 xtw2zxZ7idk/4zlf7yyhBGB9YVTMFuzcQK3cV7C1AGeKKd/XMsm0kOPUtDQbKJejQa
	 Mxrepr6uSvsudW/Rc7Kaypr/3+ej1kPNeG5aIVVvGnxFy43GbYn1pfNbjPVBDEvcry
	 5cn5eTvhHXStZXlxk0tkZUkYPLd988wkCfKuy8LejPlfkq8PJgOrzlyH613E8R58J2
	 z2AgqrQWaPiRA==
X-Gm-Message-State: ACrzQf1qLt2+QpeSMV3Y4mnP3tQlMDMPNFv9mmn6LjYacAMVEnewrkE/
	65xxIHIDCDO2gTDAGBAJr/E5BYR7WKAqYADEy24=
X-Google-Smtp-Source: AMsMyM76GdGG/AcxOxDqgV1MySSXcIQv5dlPIEhnRlae1lqaUkXnKMnbHbJddFJUo49QeKlaz0aBbFDJwBkdXRP+vlk=
X-Received: by 2002:a05:651c:1590:b0:26c:4311:9b84 with SMTP id
 h16-20020a05651c159000b0026c43119b84mr5010050ljq.152.1664812803907; Mon, 03
 Oct 2022 09:00:03 -0700 (PDT)
MIME-Version: 1.0
References: <20221003112625.972646-1-ardb@kernel.org> <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email>
In-Reply-To: <Yzr/1s9CbA0CClmt@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Mon, 3 Oct 2022 17:59:52 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
Message-ID: <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup based
 on hypercall
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: linux-efi@vger.kernel.org, 
	Xen developer discussion <xen-devel@lists.xenproject.org>, Peter Jones <pjones@redhat.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > Xen on x86 boots dom0 in EFI mode but without providing a memory map.
> > This means that some sanity checks we would like to perform on
> > configuration tables or other data structures in memory are not
> > currently possible. Xen does, however, expose EFI memory descriptor info
> > via a Xen hypercall, so let's wire that up instead.
> >
> > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> >  drivers/firmware/efi/efi.c |  5 ++-
> >  drivers/xen/efi.c          | 34 ++++++++++++++++++++
> >  include/linux/efi.h        |  1 +
> >  3 files changed, 39 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > index 55bd3f4aab28..2c12b1a06481 100644
> > --- a/drivers/firmware/efi/efi.c
> > +++ b/drivers/firmware/efi/efi.c
> > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
> >   * and if so, populate the supplied memory descriptor with the appropriate
> >   * data.
> >   */
> > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> >  {
> >       efi_memory_desc_t *md;
> >
> > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> >       return -ENOENT;
> >  }
> >
> > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > +      __weak __alias(__efi_mem_desc_lookup);
> > +
> >  /*
> >   * Calculate the highest address of an efi memory descriptor.
> >   */
> > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > index d1ff2186ebb4..74f3f6d8cdc8 100644
> > --- a/drivers/xen/efi.c
> > +++ b/drivers/xen/efi.c
> > @@ -26,6 +26,7 @@
> >
> >  #include <xen/interface/xen.h>
> >  #include <xen/interface/platform.h>
> > +#include <xen/page.h>
> >  #include <xen/xen.h>
> >  #include <xen/xen-ops.h>
> >
> > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
> >       efi.get_next_high_mono_count    = xen_efi_get_next_high_mono_count;
> >       efi.reset_system                = xen_efi_reset_system;
> >  }
> > +
> > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > +{
> > +     static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT,
> > +                   "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT");
> > +     struct xen_platform_op op = {
> > +             .cmd = XENPF_firmware_info,
> > +             .u.firmware_info = {
> > +                     .type = XEN_FW_EFI_INFO,
> > +                     .index = XEN_FW_EFI_MEM_INFO,
> > +                     .u.efi_info.mem.addr = phys_addr,
> > +                     .u.efi_info.mem.size = U64_MAX - phys_addr,
> > +             }
> > +     };
> > +     union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info;
> > +     int rc;
> > +
> > +     if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
> > +             return __efi_mem_desc_lookup(phys_addr, out_md);
> > +
> > +     rc = HYPERVISOR_platform_op(&op);
> > +     if (rc) {
> > +             pr_warn("Failed to lookup header 0x%llx in Xen memory map: error %d\n",
> > +                     phys_addr, rc);
> > +     }
> > +
> > +     out_md->phys_addr       = info->mem.addr;
>
> This will be equal to phys_addr, not the actual start of the memory
> region.
>
> > +     out_md->num_pages       = info->mem.size >> EFI_PAGE_SHIFT;
>
> Similarly, this will be the number of bytes in the memory region
> after phys_addr, not the total number of bytes in the region.  These two
> differences mean that this function is not strictly equivalent to the
> original efi_mem_desc_lookup().
>
> I am not sure if this matters in practice, but I thought you would want
> to be aware of it.

This is a bit disappointing. Is there no way to obtain this
information via a Xen hypercall?

In any case, it means we'll need to round down phys_addr to page size
at the very least.


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 16:04:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 16:04:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414953.659400 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNvz-0006gB-AU; Mon, 03 Oct 2022 16:04:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414953.659400; Mon, 03 Oct 2022 16:04:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofNvz-0006g4-7u; Mon, 03 Oct 2022 16:04:47 +0000
Received: by outflank-mailman (input) for mailman id 414953;
 Mon, 03 Oct 2022 16:04:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7JV9=2E=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ofNvy-0006fy-BN
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 16:04:46 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18223dc1-4335-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 18:04:44 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id BFEF832008FB;
 Mon,  3 Oct 2022 12:04:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Mon, 03 Oct 2022 12:04:42 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 12:04:38 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18223dc1-4335-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664813081; x=
	1664899481; bh=hPHwu5Dbn/ufBf96HVOzRpEY5YT9lHBBtz4R/zB3JH8=; b=t
	lotJ1zD+SzDDJvsFW7ghMNYgZ4CEmu23sc2KgNYLTNlLMsw4Db3OCcEyT33xC2xr
	uZvr2ulFndsbgLg+6Re7cbt2YpXH7rTb7hJ+wSI+m4xscvGtVxHlup+Tonh9jTfF
	K5OIQlErLv0NVqpEDo4/ZWBLjX0MAr55AbAsSF5HooxjMujEMwqkc8oyF/kWCHYX
	jd1VHiexqI6b1lxbyI7ZfUsrve0o0L87zzVhsMAegdrrMPkJlY3QYMKSmG9TNwLz
	tJJ4upkj78k7ts3D7lrmW9hmlbmeaTHE9ZBHHlulTAUoaHywsrnfVeNxLKv2jCLN
	iV3yoQUdrTlngFf9c8x4g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664813081; x=1664899481; bh=hPHwu5Dbn/ufBf96HVOzRpEY5YT9
	lHBBtz4R/zB3JH8=; b=l7io6zaJc401brzklTjwNQBd/t4lXo/EqDyQErWN7u7n
	VNAX4sATa4xynnul+l5jBbmCmohQUSF4U8s4Wv4jfUDebu9+MTVj08NMrl+mcZ53
	BBzX40nIAZ0VFaiSp7fjU4KJrxzgKtEESda7EhHzPDXRs+AF/pliPfp7VxzB0wsb
	X8IJAwJDsS6zYRGYcE/PqAZCMh4LA6rFd2geyYF7uS+SHYM/CG+7LWuTGCUHoElz
	Tc4K0t97YzeaoXrLNtMQFitpGcNRiGwFTd1/cMPRl1RUu1QHVRH4+JKDvGiZGlS0
	tOUxk3A5i2Xda2Qh4Y6X5tfkpfQIdbauMnuWi7DXjQ==
X-ME-Sender: <xms:GAg7Y2GQ8aVayfQKEz1FEsFUoJojB9DnfFTi2z1mv-u0zGT9-AS57A>
    <xme:GAg7Y3W78y7E1oJTlPUS_pdp4Zh4rzPD05E0E5yMTmACdsMj-yrgnbOWaJPVPKhCD
    nc0VJkYDNcNnA>
X-ME-Received: <xmr:GAg7YwJHbjXs-Rk43ZsjWPgjyXjlAZHthTWnRqDbStSS85Bc66yDO_Aj8S_DeVY6TiJZxIYcSXtivWTKTZ3XcwHxMnRXXYk3qIBQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledgleehucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:GAg7YwF0e0o-voGPeZ6ncBaa4S3smMQ4iY2FQW2Vs3BmRn_cTA3qxg>
    <xmx:GAg7Y8UO-avxl-CjtWN2cJk1CmHJrHkqJQ1QIo1NUJ29hIBpLtBN6Q>
    <xmx:GAg7YzPk0vDSFk6EV-biIXUSD2HW-q6wvqpmn2kvnLKbwLbv-Vv4iw>
    <xmx:GQg7YwSXye17eMkGqPpupMim98leJk_w6zx0zjIniREgO68EAZya1w>
Feedback-ID: i1568416f:Fastmail
Date: Mon, 3 Oct 2022 18:04:32 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall
Message-ID: <YzsIETwb0J5LI/6y@mail-itl>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email>
 <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9ODiTydC+G+MHh2u"
Content-Disposition: inline
In-Reply-To: <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>


--9ODiTydC+G+MHh2u
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 18:04:32 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall

On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote:
> On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > > +     out_md->phys_addr       =3D info->mem.addr;
> >
> > This will be equal to phys_addr, not the actual start of the memory
> > region.
> >
> > > +     out_md->num_pages       =3D info->mem.size >> EFI_PAGE_SHIFT;
> >
> > Similarly, this will be the number of bytes in the memory region
> > after phys_addr, not the total number of bytes in the region.  These two
> > differences mean that this function is not strictly equivalent to the
> > original efi_mem_desc_lookup().
> >
> > I am not sure if this matters in practice, but I thought you would want
> > to be aware of it.
>=20
> This is a bit disappointing. Is there no way to obtain this
> information via a Xen hypercall?

I don't think so, unfortunately. That said, with the below adjustment, I
think that's okay for the _current_ users of efi_mem_desc_lookup().

> In any case, it means we'll need to round down phys_addr to page size
> at the very least.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--9ODiTydC+G+MHh2u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM7CBEACgkQ24/THMrX
1yzd3gf+Mr3VN3b4/zRc61OLrM64hiVHAtOrHmidG80iN1l5JGVhjO/5i4H/8ZFT
GnfuEXC9vtCuwsJa3k2tKAlUPFxvIFQskN7aZvgVRexgB05zNB3MexEh5AwEbi6U
vjt8AZKFjuvnouYe/2hLXLb5taMyRk2h9jnVn/FkcYeGgcC7/76fsdi53bfjtYmP
GeBCzMfR9YxmhJvRK2JAjlftrb9wJSqO4weQaormHre3nxi5Hep2752BOcFCBcXK
3Kct9AKRO/ozPfRzUtkUHt2bzA9HUAqLqKPvmXGmLV4jFyiwFd3onAlnCdeTonz2
xGdDfEFEyhzlTlMTu0TwHV1yvH0+LQ==
=9EcE
-----END PGP SIGNATURE-----

--9ODiTydC+G+MHh2u--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 16:22:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 16:22:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414962.659411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofODF-0000fa-TJ; Mon, 03 Oct 2022 16:22:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414962.659411; Mon, 03 Oct 2022 16:22:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofODF-0000fT-Pp; Mon, 03 Oct 2022 16:22:37 +0000
Received: by outflank-mailman (input) for mailman id 414962;
 Mon, 03 Oct 2022 16:22:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7JV9=2E=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ofODE-0000fN-6Q
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 16:22:36 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9564fcfb-4337-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 18:22:33 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 086BD32007E8;
 Mon,  3 Oct 2022 12:22:30 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Mon, 03 Oct 2022 12:22:31 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 12:22:28 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9564fcfb-4337-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=
	1664814150; x=1664900550; bh=VUR8i+Yav/xwTfqV32RAVYeUwSbqqG2W50q
	eOLKdIuI=; b=VOxoQHX2n8Yru8vF7Qzuuqmnmfi6FgC96MP/CMtUVZJFfjAY/++
	X0CmK+00HoOgS2aYtLIFL7kL1GvzqDAN696v1j96Yqqaxcj2jNDBo5n0KZeuDhc3
	YeYIql7qp/rs3mwHnS7jr1B9l/rsd5/KZc8fwGm/vvXHbZqABfueRfqyGS1PuC4B
	auL2FupIsXjK95NzxS72Z8A7W7oHqvH8QYkc6nD51yNjEa3+ZNjfnjtUluY6VXXu
	cNPXJH1FWUmiZYlBOWaQ70BGvyT3qyaaPCHCY/ukPX83qwAcskagLK1du1dRosJu
	0pR4zA+l02MV4SIm6XQEX9fyDHG/hC8NW2g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:feedback-id:feedback-id:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm2; t=1664814150; x=1664900550; bh=VUR8i+Yav/xwT
	fqV32RAVYeUwSbqqG2W50qeOLKdIuI=; b=zcUt0P+cAcKtYlSyB/HANsgr9YUNN
	TTD9IIQdUpykiuiRDW6/VE3pKiDSsz2nJ5io2lssNa8MG3TO1/+I5ZpTd8Zy5G2+
	bq2H7nbPjldyCo3lzqFd8v9E9lxnPbD0U0hwzjK9R4cfnWMcboi+gGDrxMeoxfl3
	o1jyKtR1qqgjosMnbO7iANY4m3fAxaCZOxSlpbsHyBjOfnr2hnPBL8I110ZVnYwI
	0ReJrHPhCAZtFnMSbpblpUexeaLWqq7w8tWkMk2Wbb/oYJCNX9vpSw0RmhfpvJ7J
	lAEERaGT4l0ccd5kqOZW0Vxkeje9sPXAEd2TMF8beu+KElXOuQtFHnL/A==
X-ME-Sender: <xms:Rgw7Y1Byut7S31aikuIYgUArcXUo4EGhqVQJEvOf4dnnXJIckkcqTQ>
    <xme:Rgw7YziozGHj8H7WHvctFxKLoVawPL_t2X5sc5_U8c4fLPuarmw1R8jw4_l1OHr2x
    xXFeAD7skc96w>
X-ME-Received: <xmr:Rgw7YwlIRh6MS6vD8eI0l9DyDrvOD9_5z4gFMbhCTc5jfquvzzZz-OjMCAyLrS2qF2BmWXNfC4ybfBpfeKfCnbW27goDplwBxUZt5-O7GIngP5YvCtNqJg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledgleelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh
    udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:Rgw7Y_wt1INIsgrKVhvzbfHEJDkD9Y72CAWJedm4psGZMogJIvJYmA>
    <xmx:Rgw7Y6TAO-vh3wCoRiE-3LRyELoqhrwgXIS9LGwEYo-ECAG2INFEAg>
    <xmx:Rgw7Yyb6middlHBvDYhxf2nhzFjjrEMzcRYEwaqXB2kHR68BToAIpA>
    <xmx:Rgw7Y3SwEJrEQwYknpj_K_ae0b1jds1Z1kOUn7nFtBOrJCvtAThX0g>
Feedback-ID: i1568416f:Fastmail
From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH v2] xen: credit2: respect credit2_runqueue=all when arranging runqueues
Date: Mon,  3 Oct 2022 18:21:58 +0200
Message-Id: <20221003162158.2042-1-marmarek@invisiblethingslab.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Documentation for credit2_runqueue=all says it should create one queue
for all pCPUs on the host. But since introduction
sched_credit2_max_cpus_runqueue, it actually created separate runqueue
per socket, even if the CPUs count is below
sched_credit2_max_cpus_runqueue.

Adjust the condition to skip syblink check in case of
credit2_runqueue=all.

Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a runqueue")
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Changes in v2:
 - fix indentation
 - adjust doc

The whole thing is under cpu_runqueue_match() already, so maybe
cpu_runqueue_siblings_match() isn't needed at all?
---
 docs/misc/xen-command-line.pandoc | 5 +++++
 xen/common/sched/credit2.c        | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 74b519f0c5bd..057cdb903042 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -724,6 +724,11 @@ Available alternatives, with their meaning, are:
 * `all`: just one runqueue shared by all the logical pCPUs of
          the host
 
+Regardless of the above choice, Xen attempts to respect
+`sched_credit2_max_cpus_runqueue` limit, which may mean more than one runqueue
+for the `all` value. If that isn't intended, raise
+the `sched_credit2_max_cpus_runqueue` value.
+
 ### dbgp
 > `= ehci[ <integer> | @pci<bus>:<slot>.<func> ]`
 > `= xhci[ <integer> | @pci<bus>:<slot>.<func> ][,share=<bool>|hwdom]`
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 0e3f89e5378e..afff23b56238 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -996,9 +996,14 @@ cpu_add_to_runqueue(const struct scheduler *ops, unsigned int cpu)
              *
              * Otherwise, let's try to make sure that siblings stay in the
              * same runqueue, pretty much under any cinrcumnstances.
+             *
+             * Furthermore, try to respect credit2_runqueue=all, as long as
+             * max_cpus_runq isn't violated.
              */
-            if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran != SCHED_GRAN_cpu ||
-                  cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) )
+            if ( rqd->refcnt < max_cpus_runq &&
+                    (ops->cpupool->gran != SCHED_GRAN_cpu ||
+                     cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) ||
+                     opt_runqueue == OPT_RUNQUEUE_ALL) )
             {
                 /*
                  * This runqueue is ok, but as we said, we also want an even
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Mon Oct 03 16:23:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 16:23:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414965.659423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofODi-00017G-5O; Mon, 03 Oct 2022 16:23:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414965.659423; Mon, 03 Oct 2022 16:23:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofODi-000179-2X; Mon, 03 Oct 2022 16:23:06 +0000
Received: by outflank-mailman (input) for mailman id 414965;
 Mon, 03 Oct 2022 16:23:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TmDc=2E=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofODg-0000xu-C4
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 16:23:04 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6f34cc4-4337-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 18:23:03 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id D9D98320027A;
 Mon,  3 Oct 2022 12:23:00 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Mon, 03 Oct 2022 12:23:01 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 12:22:59 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6f34cc4-4337-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664814180; x=
	1664900580; bh=V76H3KZNlariQygngrqJIM3h4UgJ80sdU4g8vuPLVuA=; b=S
	0hd6yjQ0oDO6vM5Hf7U9npNc1moydAPRPN+jNQuc3Q8xKo00KvlgrLfQg+Yyc+QO
	kVRSPuZK/2ZFBNKjtTL7vVT8vgD5Ssavfuh8C6SP6uzbWA70VI4yEPbkdnJSbg/l
	qdG74SVdpuKhtIyGbSoZWaI1yN+93ety21aX0WtTn5hQVlCcXXqvz3TdrW88Og0W
	hyGgh/0JQVh4tmwWgXApzhxm2mwig+HiOgg6ayjcNIPdn9mjCQx/GCrld3VeKS5w
	7qlud+vb2JhRVNh1Yz29fxQQnaYlRiLL3dAurrq8Dp2BF6e6Bc17YYX0rk0HYCam
	fHCkjUWeZf+ZuMPSy55Dg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664814180; x=1664900580; bh=V76H3KZNlariQygngrqJIM3h4UgJ
	80sdU4g8vuPLVuA=; b=ny0oHhOpzHgUvmsM3YC3NJTeIOUtYySFs08Ps0hs/z10
	qM+BSX8q9v+d/mxtGoC7t1dcwPQ8XAOxylXGfqL2kJVSxRD9l6znxbiHFwKcdRN5
	VqPsQPvTtMoIv2IknBTxLq2QiK1ACa3X1e/VV/0+2bwD68vM515KOASvelOVXByh
	sN8182anyV6NFpF/2FONjYAuVhTIQf/At0zHzAp9LBs7tVQ8AmIbP6DJzvVT49vN
	VoMBXIQYJX6GP8a+RCxRuLU8uyPYqy8KgmnUuq6caKIat678XlX1DwRvlewwDy7e
	ham0tHqBlTtUisabQ2bE0EBBs8F/liIx7wId2CN3Uw==
X-ME-Sender: <xms:ZAw7Y7QxtctgMcoRA23wMZ-2hO6872gwPdQ56b8NjKLWygmOu1gXSw>
    <xme:ZAw7Y8z9s7iQiZPy1RDpuNH2wz_UYg40sJaf6TLQ_PcQoA6-4_lt5pzutaETztb_V
    ShE5NTFKEyTWs0>
X-ME-Received: <xmr:ZAw7Yw2wGDLGomVUOnxlQ5Ub2Z3MbrqIxwGW0gwIKyTI7coDfTr6lSxK6j6O>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledgleelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepiefgudefjedujeelvddtgfegueei
    hfeugfdtgfevkedtkefgledvtddvvdekheeknecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:ZAw7Y7APjlnzuKslphWG-2L2uSADN9SfBFSiyjiEQvvQyYXrSIcEHw>
    <xmx:ZAw7Y0iSGBbV5ehzgHgPN6KoJebfUr0DoocULDy9KdOra4OXtupXGw>
    <xmx:ZAw7Y_qUKUfJWUqvCMOGIo8XYIKvWaCvLCqPzjFKHiax-LpzeMkQHQ>
    <xmx:ZAw7Y3N8BhLNjrddhZp5VlV8HOOYZB0jLHp9xduXCaqUrrhm6tPkfQ>
Feedback-ID: iac594737:Fastmail
Date: Mon, 3 Oct 2022 12:22:54 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall
Message-ID: <YzsMYfEwmjHwVheb@itl-email>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email>
 <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="t6nMBPUwd7mkm4Ai"
Content-Disposition: inline
In-Reply-To: <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>


--t6nMBPUwd7mkm4Ai
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 12:22:54 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall

On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote:
> On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > > Xen on x86 boots dom0 in EFI mode but without providing a memory map.
> > > This means that some sanity checks we would like to perform on
> > > configuration tables or other data structures in memory are not
> > > currently possible. Xen does, however, expose EFI memory descriptor i=
nfo
> > > via a Xen hypercall, so let's wire that up instead.
> > >
> > > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > ---
> > >  drivers/firmware/efi/efi.c |  5 ++-
> > >  drivers/xen/efi.c          | 34 ++++++++++++++++++++
> > >  include/linux/efi.h        |  1 +
> > >  3 files changed, 39 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > > index 55bd3f4aab28..2c12b1a06481 100644
> > > --- a/drivers/firmware/efi/efi.c
> > > +++ b/drivers/firmware/efi/efi.c
> > > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
> > >   * and if so, populate the supplied memory descriptor with the appro=
priate
> > >   * data.
> > >   */
> > > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > >  {
> > >       efi_memory_desc_t *md;
> > >
> > > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory=
_desc_t *out_md)
> > >       return -ENOENT;
> > >  }
> > >
> > > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out=
_md)
> > > +      __weak __alias(__efi_mem_desc_lookup);
> > > +
> > >  /*
> > >   * Calculate the highest address of an efi memory descriptor.
> > >   */
> > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > > index d1ff2186ebb4..74f3f6d8cdc8 100644
> > > --- a/drivers/xen/efi.c
> > > +++ b/drivers/xen/efi.c
> > > @@ -26,6 +26,7 @@
> > >
> > >  #include <xen/interface/xen.h>
> > >  #include <xen/interface/platform.h>
> > > +#include <xen/page.h>
> > >  #include <xen/xen.h>
> > >  #include <xen/xen-ops.h>
> > >
> > > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
> > >       efi.get_next_high_mono_count    =3D xen_efi_get_next_high_mono_=
count;
> > >       efi.reset_system                =3D xen_efi_reset_system;
> > >  }
> > > +
> > > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > +{
> > > +     static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT,
> > > +                   "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHI=
FT");
> > > +     struct xen_platform_op op =3D {
> > > +             .cmd =3D XENPF_firmware_info,
> > > +             .u.firmware_info =3D {
> > > +                     .type =3D XEN_FW_EFI_INFO,
> > > +                     .index =3D XEN_FW_EFI_MEM_INFO,
> > > +                     .u.efi_info.mem.addr =3D phys_addr,
> > > +                     .u.efi_info.mem.size =3D U64_MAX - phys_addr,
> > > +             }
> > > +     };
> > > +     union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_info;
> > > +     int rc;
> > > +
> > > +     if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
> > > +             return __efi_mem_desc_lookup(phys_addr, out_md);
> > > +
> > > +     rc =3D HYPERVISOR_platform_op(&op);
> > > +     if (rc) {
> > > +             pr_warn("Failed to lookup header 0x%llx in Xen memory m=
ap: error %d\n",
> > > +                     phys_addr, rc);
> > > +     }
> > > +
> > > +     out_md->phys_addr       =3D info->mem.addr;
> >
> > This will be equal to phys_addr, not the actual start of the memory
> > region.
> >
> > > +     out_md->num_pages       =3D info->mem.size >> EFI_PAGE_SHIFT;
> >
> > Similarly, this will be the number of bytes in the memory region
> > after phys_addr, not the total number of bytes in the region.  These two
> > differences mean that this function is not strictly equivalent to the
> > original efi_mem_desc_lookup().
> >
> > I am not sure if this matters in practice, but I thought you would want
> > to be aware of it.
>=20
> This is a bit disappointing. Is there no way to obtain this
> information via a Xen hypercall?

It is possible, but doing so is very complex (it essentially requires a
binary search).  This really should be fixed on the Xen side.

> In any case, it means we'll need to round down phys_addr to page size
> at the very least.

That makes sense.  Are there any callers that will be broken even with
this rounding?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--t6nMBPUwd7mkm4Ai
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM7DGEACgkQsoi1X/+c
IsHWbQ//bOkG2n0pJ/Y4g3ew+zBRIs12g+FI06XjMN9ih4aTF4ljax/VVJYwCv6N
064YbyhY0a4aUs/90iT2ZSliTo14dxMvCuCYgJ6Md7wkvgEbTb69Ga7bw9Yq2IRM
xEBDAf3h1djM7yG56A0ZOeD3A9XI6hYeAQv7we/4/tm5HLlQM+mdijycNOYNT4o8
o2SM6Or+f/veMAz95oFTX8uwd9MWWFOZL2pzFbEjI/yxzIzD0m8x7dFZOijXK3RD
zGbu4r3RVQdm3w4pxY/pGXNxUL9fadPln57ZVs13jpe1v0hyAQQpefBL6kOUoB1T
8uoRjtYpSOFkZEBYx8Dd+MwNcEtsE1lYUa8OlQTDL98qJROAc6k0wvHscm0B9ghO
yJXV7IMdWSSKebhYAuBi7d7nG9PzimqsuxRQEry2uLfP95dSjFpQ2dIh8I9qpKoh
SPQ4JNvoY5aJbU+tsmA/4+7l4Wc5GWeExgfn31CAz5nvy/512TCpBGLDu0O8wT9W
E8YqSACeLP/2SUI3UnWqihRCOti0cypN64EiWk3rKfSGPkG1KFIXa/Ywxk0Gg4lL
Z8DlvjONFbppE33cwzOixG7RC+ItmbHiJ0TnSzqhzdhB3IUf6NBmdJ60aNwA6c88
Y3frOLDCRXdpJDI6BAKKjH8xVVp2qkNf/DVMoNHDbMfohjhbE7I=
=YbWg
-----END PGP SIGNATURE-----

--t6nMBPUwd7mkm4Ai--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 16:37:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 16:37:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414977.659434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofORm-0002mk-G3; Mon, 03 Oct 2022 16:37:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414977.659434; Mon, 03 Oct 2022 16:37:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofORm-0002md-DJ; Mon, 03 Oct 2022 16:37:38 +0000
Received: by outflank-mailman (input) for mailman id 414977;
 Mon, 03 Oct 2022 16:37:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=1PaK=2E=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ofORl-0002mX-Jl
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 16:37:37 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af5422da-4339-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 18:37:35 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0534FB811B1
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 16:37:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E4CFC43143
 for <xen-devel@lists.xenproject.org>; Mon,  3 Oct 2022 16:37:33 +0000 (UTC)
Received: by mail-lf1-f49.google.com with SMTP id z4so17412284lft.2
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 09:37:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af5422da-4339-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664815053;
	bh=SwOOl/GQEKKR5VLMEWFYuNALBz3486Y2crgztQdS0M4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=aS+XHOSk78BoST/tF3yiLd11KWnxUQQV6gWJ2IgD1NJfd6mDeqA0FuKJADsrHfG61
	 6WFwKYqevnjY8y4Q22XNQGz62LUdPGrgqEfbK2/F/0Nr6+XkFPLXOxSQXJ8RapvLqk
	 c28+gJwTPc94HNDw5tOvSenb6RTtiSxG4WEoMJwG5usSs1eH/pvU2BVdKhYZoNo574
	 hVZ6z8lOrmQwoZtbQkXbts3sGiwbr6R04NOKwkbvy7I7S3o1IW+OEMGlUHdt0Cg9RK
	 14YN4faQPZ9NwIiuS+3mMRRm0M7yC+sGkvep6SF8e5sU7mR5SMQxIuWNphBpIIR6PF
	 n3w1YKRL8jMug==
X-Gm-Message-State: ACrzQf28dGLIbTwbgLjNuVZ0CE6HH+uwZz4gU4CszwUAe+LePb4VmchB
	nTSjPC4O7jcZ2Vg9iJeq/bZ3HGZk0i0H1Dg/RXg=
X-Google-Smtp-Source: AMsMyM4++k3liVITL0oeYHvbLXxUBDS6Zi3r5RUAZI8RvjR+zPLOB01pG6Tc5J6rPPOP61hBXJXtp2tt06wpwZ549bA=
X-Received: by 2002:a05:6512:261b:b0:4a1:abd7:3129 with SMTP id
 bt27-20020a056512261b00b004a1abd73129mr8018624lfb.637.1664815050992; Mon, 03
 Oct 2022 09:37:30 -0700 (PDT)
MIME-Version: 1.0
References: <20221003112625.972646-1-ardb@kernel.org> <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email> <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
 <YzsMYfEwmjHwVheb@itl-email>
In-Reply-To: <YzsMYfEwmjHwVheb@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Mon, 3 Oct 2022 18:37:19 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHR1FfD+ipG4RtbOezx+s_Jo6JwG4fpT5XUmvoqHTctLA@mail.gmail.com>
Message-ID: <CAMj1kXHR1FfD+ipG4RtbOezx+s_Jo6JwG4fpT5XUmvoqHTctLA@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup based
 on hypercall
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: linux-efi@vger.kernel.org, 
	Xen developer discussion <xen-devel@lists.xenproject.org>, Peter Jones <pjones@redhat.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 3 Oct 2022 at 18:23, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote:
> > On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
> > <demi@invisiblethingslab.com> wrote:
> > >
> > > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > > > Xen on x86 boots dom0 in EFI mode but without providing a memory map.
> > > > This means that some sanity checks we would like to perform on
> > > > configuration tables or other data structures in memory are not
> > > > currently possible. Xen does, however, expose EFI memory descriptor info
> > > > via a Xen hypercall, so let's wire that up instead.
> > > >
> > > > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > > ---
> > > >  drivers/firmware/efi/efi.c |  5 ++-
> > > >  drivers/xen/efi.c          | 34 ++++++++++++++++++++
> > > >  include/linux/efi.h        |  1 +
> > > >  3 files changed, 39 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > > > index 55bd3f4aab28..2c12b1a06481 100644
> > > > --- a/drivers/firmware/efi/efi.c
> > > > +++ b/drivers/firmware/efi/efi.c
> > > > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
> > > >   * and if so, populate the supplied memory descriptor with the appropriate
> > > >   * data.
> > > >   */
> > > > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > >  {
> > > >       efi_memory_desc_t *md;
> > > >
> > > > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > >       return -ENOENT;
> > > >  }
> > > >
> > > > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > > +      __weak __alias(__efi_mem_desc_lookup);
> > > > +
> > > >  /*
> > > >   * Calculate the highest address of an efi memory descriptor.
> > > >   */
> > > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > > > index d1ff2186ebb4..74f3f6d8cdc8 100644
> > > > --- a/drivers/xen/efi.c
> > > > +++ b/drivers/xen/efi.c
> > > > @@ -26,6 +26,7 @@
> > > >
> > > >  #include <xen/interface/xen.h>
> > > >  #include <xen/interface/platform.h>
> > > > +#include <xen/page.h>
> > > >  #include <xen/xen.h>
> > > >  #include <xen/xen-ops.h>
> > > >
> > > > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
> > > >       efi.get_next_high_mono_count    = xen_efi_get_next_high_mono_count;
> > > >       efi.reset_system                = xen_efi_reset_system;
> > > >  }
> > > > +
> > > > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > > +{
> > > > +     static_assert(XEN_PAGE_SHIFT == EFI_PAGE_SHIFT,
> > > > +                   "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE_SHIFT");
> > > > +     struct xen_platform_op op = {
> > > > +             .cmd = XENPF_firmware_info,
> > > > +             .u.firmware_info = {
> > > > +                     .type = XEN_FW_EFI_INFO,
> > > > +                     .index = XEN_FW_EFI_MEM_INFO,
> > > > +                     .u.efi_info.mem.addr = phys_addr,
> > > > +                     .u.efi_info.mem.size = U64_MAX - phys_addr,
> > > > +             }
> > > > +     };
> > > > +     union xenpf_efi_info *info = &op.u.firmware_info.u.efi_info;
> > > > +     int rc;
> > > > +
> > > > +     if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
> > > > +             return __efi_mem_desc_lookup(phys_addr, out_md);
> > > > +
> > > > +     rc = HYPERVISOR_platform_op(&op);
> > > > +     if (rc) {
> > > > +             pr_warn("Failed to lookup header 0x%llx in Xen memory map: error %d\n",
> > > > +                     phys_addr, rc);
> > > > +     }
> > > > +
> > > > +     out_md->phys_addr       = info->mem.addr;
> > >
> > > This will be equal to phys_addr, not the actual start of the memory
> > > region.
> > >
> > > > +     out_md->num_pages       = info->mem.size >> EFI_PAGE_SHIFT;
> > >
> > > Similarly, this will be the number of bytes in the memory region
> > > after phys_addr, not the total number of bytes in the region.  These two
> > > differences mean that this function is not strictly equivalent to the
> > > original efi_mem_desc_lookup().
> > >
> > > I am not sure if this matters in practice, but I thought you would want
> > > to be aware of it.
> >
> > This is a bit disappointing. Is there no way to obtain this
> > information via a Xen hypercall?
>
> It is possible, but doing so is very complex (it essentially requires a
> binary search).  This really should be fixed on the Xen side.
>
> > In any case, it means we'll need to round down phys_addr to page size
> > at the very least.
>
> That makes sense.  Are there any callers that will be broken even with
> this rounding?

As far as I can tell, it should work fine. The only thing to double
check is whether we are not creating spurious error messages from
efi_arch_mem_reserve() this way, but as far as I can tell, that should
be fine too.

Is there anyone at your end that can give this a spin on an actual
Xen/x86 system?


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 17:04:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 17:04:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414984.659445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofOrW-00060y-L8; Mon, 03 Oct 2022 17:04:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414984.659445; Mon, 03 Oct 2022 17:04:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofOrW-00060r-HT; Mon, 03 Oct 2022 17:04:14 +0000
Received: by outflank-mailman (input) for mailman id 414984;
 Mon, 03 Oct 2022 17:04:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7JV9=2E=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ofOrV-00060l-32
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 17:04:13 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 65f81e02-433d-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 19:04:11 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 4A3D432006F5;
 Mon,  3 Oct 2022 13:04:08 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Mon, 03 Oct 2022 13:04:09 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 13:04:05 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65f81e02-433d-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to; s=fm2; t=1664816647; x=
	1664903047; bh=MAFMhD2KIuhZj+ekr6ZwRi1IRfnbwdYWkjAH4mXarN4=; b=I
	9HH7zwtOEtR769BBI9P8o6ERsTCw/K3D0NA0bEWTOChot2Uax/fGDLfNvM0/2ta3
	Dm+dQjJvwpH/LscwVTXrVGPW4/3Su88EvowZdSDinorwmizGRSxF0RakuAIbQs2X
	mY6tfZUBSYkDoGH+c+1mEcgZGpn5b+fykmSqeL2TYnlTwx27lfqsiCAMRt+ZMooz
	EFeU/fC+6q0NhWFoLIcMjBvkWRuhp61HtI72nS2Up4yL3ok2Gi8rc23dOCvtfM2C
	SsGI+lCMjrqxPIV7fzpouJx+SiHm/NWYrQ/bBQH+5VZQcV22q6YgJNgpkK9VfMko
	oAcEj9Hz+o5lJNO1Kh0GA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664816647; x=1664903047; bh=MAFMhD2KIuhZj+ekr6ZwRi1IRfnb
	wdYWkjAH4mXarN4=; b=GxOBXw6F3QN0HLIFXMlbQfU4HVAlQk0R94urTRZm5x/T
	jVx1AjodfIOKvJRxMb4XqUmJba1/DUToRz8KRRsecC8W+ps6JMP2y5jC3f8YJMEO
	uPR9m9KPjhwOewxDgvPRcfbitXvio52H2pPpMaqHtfM6Ba7LqJT+TDBjWrt1gGBZ
	v6cQ9Qscah94qXhfRUlqIJQMVjaUdwM1CUcP+K1maXh9Gx6SZIGjeVjPI1Qks5Fu
	cJgfZTBOSC4VTfgWaKSgCjg7RwS0hhcv/SJcUQu6O+mH7smG+qTFDtanSVb2FSKA
	NtkY39DCm7vs3UiQzL14+3kgGiXrxPOW1Z0G6EalOA==
X-ME-Sender: <xms:BxY7Y_LeMJe50C-fVxwsRxwWFuxuIPzjou9gWuaE1DL1MmlvfBQKYQ>
    <xme:BxY7YzJ1KvNjoQ6Snn7f8V0eUTMa6Qp_QBJxrBt1P_XTBedFxPvR7Wp-DSNBi3vtc
    yPxc4PRo68C7w>
X-ME-Received: <xmr:BxY7Y3sq1wvliPRp5KonqcpOl4WN2_DD5tQCMrqZQDtaN7Iv4XkzaFf96_eYZekN8jS7F-dtUSK3qkf-q31lBs-5ej0Tdh1ooD6R>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledguddtjecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enmhhishhsihhnghcuvffquchfihgvlhguucdlfedtmdenucfjughrpeffhfevuffkfhgg
    tggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskh
    hiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepkeekjeffieehhfeggffhieffvdevie
    etveejjeeghfetvdfggffhfedtgfeiuedunecuffhomhgrihhnpehgihhthhhusgdrtgho
    mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg
    hrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:BxY7Y4YED3M3nIFWWquj4ThXbT3b4RXIZxEUd6p47X0bqfQKpW1ygw>
    <xmx:BxY7Y2YVQRfTOaG001nJe_dOM-nYNaI9c8bS8YD2I0rrAw5h6xigbA>
    <xmx:BxY7Y8Bc3g5bkAiB9cJLM__NnmKuCn_qmRVeJD-P-7WVdLnm-VS8WQ>
    <xmx:BxY7Y8lSpr4UWYwyOk2vU49icRJd4UXQqyFbz9T1sMt9X1aRhpdA6Q>
Feedback-ID: i1568416f:Fastmail
Date: Mon, 3 Oct 2022 19:04:02 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall
Message-ID: <YzsWAnD7q9qeBoBn@mail-itl>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email>
 <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
 <YzsMYfEwmjHwVheb@itl-email>
 <CAMj1kXHR1FfD+ipG4RtbOezx+s_Jo6JwG4fpT5XUmvoqHTctLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="+89X2RyWPSxXneQK"
Content-Disposition: inline
In-Reply-To: <CAMj1kXHR1FfD+ipG4RtbOezx+s_Jo6JwG4fpT5XUmvoqHTctLA@mail.gmail.com>


--+89X2RyWPSxXneQK
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 19:04:02 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall

On Mon, Oct 03, 2022 at 06:37:19PM +0200, Ard Biesheuvel wrote:
> On Mon, 3 Oct 2022 at 18:23, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote:
> > > On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
> > > <demi@invisiblethingslab.com> wrote:
> > > >
> > > > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > > > > Xen on x86 boots dom0 in EFI mode but without providing a memory =
map.
> > > > > This means that some sanity checks we would like to perform on
> > > > > configuration tables or other data structures in memory are not
> > > > > currently possible. Xen does, however, expose EFI memory descript=
or info
> > > > > via a Xen hypercall, so let's wire that up instead.
> > > > >
> > > > > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > > > ---
> > > > >  drivers/firmware/efi/efi.c |  5 ++-
> > > > >  drivers/xen/efi.c          | 34 ++++++++++++++++++++
> > > > >  include/linux/efi.h        |  1 +
> > > > >  3 files changed, 39 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/ef=
i.c
> > > > > index 55bd3f4aab28..2c12b1a06481 100644
> > > > > --- a/drivers/firmware/efi/efi.c
> > > > > +++ b/drivers/firmware/efi/efi.c
> > > > > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
> > > > >   * and if so, populate the supplied memory descriptor with the a=
ppropriate
> > > > >   * data.
> > > > >   */
> > > > > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > > > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_=
md)
> > > > >  {
> > > > >       efi_memory_desc_t *md;
> > > > >
> > > > > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_me=
mory_desc_t *out_md)
> > > > >       return -ENOENT;
> > > > >  }
> > > > >
> > > > > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t =
*out_md)
> > > > > +      __weak __alias(__efi_mem_desc_lookup);
> > > > > +
> > > > >  /*
> > > > >   * Calculate the highest address of an efi memory descriptor.
> > > > >   */
> > > > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > > > > index d1ff2186ebb4..74f3f6d8cdc8 100644
> > > > > --- a/drivers/xen/efi.c
> > > > > +++ b/drivers/xen/efi.c
> > > > > @@ -26,6 +26,7 @@
> > > > >
> > > > >  #include <xen/interface/xen.h>
> > > > >  #include <xen/interface/platform.h>
> > > > > +#include <xen/page.h>
> > > > >  #include <xen/xen.h>
> > > > >  #include <xen/xen-ops.h>
> > > > >
> > > > > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
> > > > >       efi.get_next_high_mono_count    =3D xen_efi_get_next_high_m=
ono_count;
> > > > >       efi.reset_system                =3D xen_efi_reset_system;
> > > > >  }
> > > > > +
> > > > > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
> > > > > +{
> > > > > +     static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT,
> > > > > +                   "Mismatch between EFI_PAGE_SHIFT and XEN_PAGE=
_SHIFT");
> > > > > +     struct xen_platform_op op =3D {
> > > > > +             .cmd =3D XENPF_firmware_info,
> > > > > +             .u.firmware_info =3D {
> > > > > +                     .type =3D XEN_FW_EFI_INFO,
> > > > > +                     .index =3D XEN_FW_EFI_MEM_INFO,
> > > > > +                     .u.efi_info.mem.addr =3D phys_addr,
> > > > > +                     .u.efi_info.mem.size =3D U64_MAX - phys_add=
r,
> > > > > +             }
> > > > > +     };
> > > > > +     union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_in=
fo;
> > > > > +     int rc;
> > > > > +
> > > > > +     if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
> > > > > +             return __efi_mem_desc_lookup(phys_addr, out_md);
> > > > > +
> > > > > +     rc =3D HYPERVISOR_platform_op(&op);
> > > > > +     if (rc) {
> > > > > +             pr_warn("Failed to lookup header 0x%llx in Xen memo=
ry map: error %d\n",
> > > > > +                     phys_addr, rc);
> > > > > +     }
> > > > > +
> > > > > +     out_md->phys_addr       =3D info->mem.addr;
> > > >
> > > > This will be equal to phys_addr, not the actual start of the memory
> > > > region.
> > > >
> > > > > +     out_md->num_pages       =3D info->mem.size >> EFI_PAGE_SHIF=
T;
> > > >
> > > > Similarly, this will be the number of bytes in the memory region
> > > > after phys_addr, not the total number of bytes in the region.  Thes=
e two
> > > > differences mean that this function is not strictly equivalent to t=
he
> > > > original efi_mem_desc_lookup().
> > > >
> > > > I am not sure if this matters in practice, but I thought you would =
want
> > > > to be aware of it.
> > >
> > > This is a bit disappointing. Is there no way to obtain this
> > > information via a Xen hypercall?
> >
> > It is possible, but doing so is very complex (it essentially requires a
> > binary search).  This really should be fixed on the Xen side.
> >
> > > In any case, it means we'll need to round down phys_addr to page size
> > > at the very least.
> >
> > That makes sense.  Are there any callers that will be broken even with
> > this rounding?
>=20
> As far as I can tell, it should work fine. The only thing to double
> check is whether we are not creating spurious error messages from
> efi_arch_mem_reserve() this way, but as far as I can tell, that should
> be fine too.
>=20
> Is there anyone at your end that can give this a spin on an actual
> Xen/x86 system?

Demi, if you open a PR with this at
https://github.com/QubesOS/qubes-linux-kernel/pulls, I can run it
through our CI - (at least) one of the machines has ESRT table. AFAIR
your test laptop has it too.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--+89X2RyWPSxXneQK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM7FgMACgkQ24/THMrX
1yxKHQf+JJ2JkZcF4WgR42arxR3sevcAuSW2j7nKWkMyLMp4St7Aa4hOBpdFyATU
2W0z0NzwalajmAbNXPM2u2LEMMP1EdFoqFrEGsocWsMH2qWTwkttLv7ARnltQy9K
qVcX+78nDAeB+/D+S5dvoYwWk5sWot1lIKnmu1pieEguldbZbVctvx6Sfdn2rlGb
BpZ0LKXEtXQ8LKuTGQDDdkpBg8yKQ8MGDEoslJTio8yEYmGKhp/gARHx9OaB18am
XeECcXlnCcddgaKn7E9BQ02Doql4YbZdhZY8NZKAevEvjZ9RtZ9hEkM1x4L7Pllu
p1FURsSerZvxAfOck8JVoaGob0KYpA==
=6KGB
-----END PGP SIGNATURE-----

--+89X2RyWPSxXneQK--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 17:34:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 17:34:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.414995.659456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofPKl-0000uj-2w; Mon, 03 Oct 2022 17:34:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 414995.659456; Mon, 03 Oct 2022 17:34:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofPKk-0000uc-W8; Mon, 03 Oct 2022 17:34:26 +0000
Received: by outflank-mailman (input) for mailman id 414995;
 Mon, 03 Oct 2022 17:34:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bweH=2E=vmware.com=namit@srs-se1.protection.inumbo.net>)
 id 1ofPKj-0000uP-90
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 17:34:25 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-eastusazlp170110004.outbound.protection.outlook.com
 [2a01:111:f403:c100::4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9e0097c5-4341-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 19:34:23 +0200 (CEST)
Received: from BY3PR05MB8531.namprd05.prod.outlook.com (2603:10b6:a03:3ce::6)
 by SN6PR05MB4909.namprd05.prod.outlook.com (2603:10b6:805:8f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.14; Mon, 3 Oct
 2022 17:34:16 +0000
Received: from BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6]) by BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6%7]) with mapi id 15.20.5709.008; Mon, 3 Oct 2022
 17:34:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e0097c5-4341-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S6TBiDjzsKsM1MY3Cs6s/4tE58DAF+CPepSFV3fymCSqgHk11e0ze8qqgPmbqAo4QALAGSDJXV6L4PpLL9aK5AIJ38iTrSfjjyHIRrjb5RcbYLOIZtaJETjqgj5rlWJpsgHrCwOvk60SizhZC4AQkNOIvh573f34F4+gHhTGD89OMU+qa34k/AIZf5fwRkVCPpSg9lVsSsWOyGvt+dgte9Gg54NBsbAULii2sox0ncX5lF9K8oVMlxPxwy3OYTLNuDiy89BfsF4UzLhXBi3CpUNMBNVFz0oru+gNFs42OOYsLXp+9lxSYy9Ub9Y/A+FgyLNBGBm+Dupz5kCZ7bO6/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gbnE7MrDWW5nQM+t2yG5rjk3HSDbCgVczShqlOfEIoc=;
 b=j0vxyCIqv3m7KPwBFomzpo6DxT27uiwOhk+lMJJq+r9tOyDT33xRxPvA414hbbpsN2DYpVrZAA9Pmp79fne/Ywf3blZW90NU2FGXRXoKq5WfoLyX9ORscA2SJ0MSFwFWBcc5yahvW6rv9YDGhKr3QA0ao5l+Ibo40QX9TsmZmUhA3IHsO3jVzkwAIVd8W7LEgCjgTK+plT3LyzIKgWF+kU3yl4GwrKDnwIlG0Kyedgo0qV7mS+o0ppr2s2EwFBN5aTaqz+51Ug077zrU7HuWK2QkHBaypdWAsvtFGZLjsmJNeErsqvgEwFNm2diTsegfUu/uJogOCj1+OxpxENERVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com;
 dkim=pass header.d=vmware.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gbnE7MrDWW5nQM+t2yG5rjk3HSDbCgVczShqlOfEIoc=;
 b=CUBLXxK1xIKpqS7IQi0reDc/3Ow9Z/9EuyWxxSRjfs3rgFjrlOwhl366ZZogpbrAtBYJLHOW/iGtVTuSDWAzrtTYvAcyf5+EyIv95xgu3f7visxqw1Y6VC7MHv0uIliVYjcWfPacZcZZagqSC2RbeBUW7KghvzgAFgeUefqqlYQ=
From: Nadav Amit <namit@vmware.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, Alexander Graf <graf@amazon.com>
CC: Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>,
	Srivatsa Bhat <srivatsab@vmware.com>, "srivatsa@csail.mit.edu"
	<srivatsa@csail.mit.edu>, Alexey Makhalov <amakhalov@vmware.com>, Vasavi
 Sirnapalli <vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
	<er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
	<jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "acrn-dev@lists.projectacrn.org"
	<acrn-dev@lists.projectacrn.org>, "helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Index: AQHYx28G+J2WSwxm3kmFzqoOhSDYUK3dXFQAgBj77YCABouGgIAAKhGA
Date: Mon, 3 Oct 2022 17:34:15 +0000
Message-ID: <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com>
In-Reply-To: <87tu4l9cfm.fsf@redhat.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vmware.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BY3PR05MB8531:EE_|SN6PR05MB4909:EE_
x-ms-office365-filtering-correlation-id: f067f375-a994-4f7d-f56f-08daa5657e8e
x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 IaLUdvWXEsR+zuBn4vVC5O6D2aYNnOJE1YfeoCPPy/2WQ65EDfBOC5kCLgRnYVqBSyr9lfyXrxb4R14kqV/57YCijAHSuUOwokBRVa+GK3n3g2EtHU+y/G68oJQaXGA/fDnCAGVsqaNHjgIN9ON6FdDLiggoIztOyzznnccnSsaeh1cSajSQPo5SWTwEJJF8KZd2hpfqj45M9z1bvD8f/VyItjIaAL2I5T0rqiMSje4CJBBQBzZGsoDRvmFj5VdSDLowFHWnDnB3cA6oR4GfLtLiXXNvwekw8lxIn45oNkvLd6XePYVK2bUeywI66lb95zaCTM8KknTuFLH67bclG2aYVpZ0nIQVIlPseDTirUWwdiJzXN0qdhjdnV4sCMgrt0pE9Sc4noU5eT0E6bBifqma1kZuHzmWbDEl4LN04PDraWbg6MAbNdyHi72foKiPNiucmZcFvc3URmbpfNrd+NOFy1EEY11+nASkiG9ooCff/XitFaEwzakpNFwFU5Ch/w/b0vyRb+NIqrCwp9dt1B3DRMbbYkiKcaBh3y0Pnwn4qcx1Ebi/jgmTkB47obsQDk3k/IZUSrgd9/2kNmzxJ2QVn0u8fApc0S0qQpqDMdWdUqR1sWJEudqviLIEjaJ1wtTpdCr+gjzOAuf3Zz3NoLDRLbHNsSG5bQQLGya91xXFjNTD+mLx+zBvfr8EK1dVS7yiCam9MSKIsqpE/oHIdiCBTrsitNbKIAp5vK/eqUd6EbjkCyFhVoBXDVF618Dn3u8p9yLRRt+4gtCw/O4h8o5/euzeukUR22Wth3gas0c=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR05MB8531.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199015)(2906002)(5660300002)(7416002)(8936002)(41300700001)(71200400001)(36756003)(478600001)(76116006)(316002)(38100700002)(86362001)(122000001)(4326008)(64756008)(6512007)(8676002)(26005)(66556008)(66446008)(6506007)(110136005)(53546011)(2616005)(66476007)(54906003)(66946007)(6486002)(38070700005)(33656002)(186003)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SS9ZRWRva3lXQmpRcW9ZeE8rT3VZSlpRS2U0UmFMSGRBYVVoSjhSWUZVVFlW?=
 =?utf-8?B?YUpjQmZkRExYL0UwL1FOeFNvai90SmxVL3k3ZVBuWXRxK0kzZ1ZMK01sZFRi?=
 =?utf-8?B?cE9kcUw0RlRtRXQ1WmZoQmZDUlFtVGxWdDYycFJqcU9DSE1jRisrZzVIaGhK?=
 =?utf-8?B?ZEhLU3IxdHJHQ3FDRXhwUjhvMExZSWlpS0M5aXg5bVdLQXl4SWVDKytSdnZH?=
 =?utf-8?B?cWZERVVpVXdwYmJGdnlmbG1qbUZSZkwySXdZV0d6L1BSSEdZdjJ6UThpZ0pN?=
 =?utf-8?B?a0VITSt4NmJmSHJQUzFEekxaczZmclBpaFRreTFoSDFiR28zc1RlNlFOckhF?=
 =?utf-8?B?bTNUY2xBVTZBVk5Sdld1SkhYSmxOdmZQeGs5RGNMNHl0MldjeUE1dXgzd3Bz?=
 =?utf-8?B?b0lLOU1OWkpsNUdpVDgybkZvZ2pyNGlBUnUrdWpUTFBsblZhejJ6MFU0dE1o?=
 =?utf-8?B?RTBqaytjbUUybDZ3Z3Robkd5LzkvTkhlTGliREprOUxGbXVZUlFtWUZYNGpQ?=
 =?utf-8?B?T1UzR1QvZ2Y4TFZqNWZpNW5Fb3k1cDkzR0U2M1JvRUJDUkZlZDZsMUNMWjlC?=
 =?utf-8?B?SU9DdTJLdG42TStyUEQ4MUdBNFQwZmltNEVwVHBDZGNJYXg1QVM0eTRraTZB?=
 =?utf-8?B?WWIrYTZkMzlGT3NBeTlJcVRYWnZlZFBHcDBuOTgxVlBxSHdHRDMrREFzMlZL?=
 =?utf-8?B?WENuaUMvckYxOEF3ZjE5cjdidXRYdTljeGZvTlU2eUc0OG9VSytwVHVjNWZO?=
 =?utf-8?B?dVVFVnRVRWIya0xaQzJRM3pQM2k3M1Nxay9DRG56RW01cEJzZDRkQVMydG9p?=
 =?utf-8?B?ek1iRlFXenNaVHd1cXprc1VoQ2dLbHJEVjNHMktuVngwdzZOQy9TRFFLejNk?=
 =?utf-8?B?RWpFVGhYLzlhVXBoQTVRZU5CRDRIcUNIRDJoNjFxT1VjckNmRXpiTG9oR0lR?=
 =?utf-8?B?Y092MC9LL1VHa0NBVDcrNmhXNkxpVVJFTElZNll3WjRhU1Y5d2ZhMFJ3OG9o?=
 =?utf-8?B?VXh3aUZ6bkVHMXFuTDM5MmxOeHc1RkhVdWl5dnhJSThNNFd1N1JKUzZUOFZN?=
 =?utf-8?B?RzJzL25GWFJLRnNqVE9LakJOSFhEaHdZUVV4MTFXSWpSRDlGWWpHUDE2N1Ar?=
 =?utf-8?B?MERhbFB2SkRYeXRyR2pZQ3dHaE5UNVB4azFMMnJMQ1prM0dDM1BWcnFHOXl3?=
 =?utf-8?B?SHZQczU2N3Z1SlpFWFZxZGdHQUdKNTIvS0k1YWorRkx4QWsvUFBvU1dmOEor?=
 =?utf-8?B?RUk4NHMwanQ0bFpkRjhtdW1QcEtJWVJXYzNLUzdxWG42WHN2Z1p2Yk1YclNi?=
 =?utf-8?B?QVU1UDVYV1R1Q0l6eFZBR2NHcllVODNCSDdPMWdZZ3RNS0FSWXFKUEV0RmFG?=
 =?utf-8?B?R21mWGVoUGVIem5DWk95ZlNpNmJ6M285VlAyRXVHWkxGblg5MWNIaHE2dWJv?=
 =?utf-8?B?bEl2WXFkcjZKNHlJMkttQXh5YkJYd0JhU1V4bkpGaTR4VlVuNm00QVhMNThX?=
 =?utf-8?B?aU1YTmJhNUVkT3FFaG82TDQ1cTdNclcxQmFJRXByelR4MzFMZkEveCtaR2hL?=
 =?utf-8?B?eVhiSjBqOHVoU3FPTVRQM0JmM1RZZFhaTHFRbkNqWk9yWDAyUkIxMm5CRDRI?=
 =?utf-8?B?MFNLMCs4c3B1M1VMVmpsc0NwNk5GaUFtZCtqOUkrUU1BMjlLMHRkTEE4bFhD?=
 =?utf-8?B?MklNRDdlRUJwdVJjWi8yRnkvRVBObGp1YUcrSW43OUQwcngwM0g0WmsyVW1i?=
 =?utf-8?B?YjROVXpzSTRMa1poM3l2bzZFU2EzUkNVZEJkdTlzUU40b2JsUEdwRHF0bndO?=
 =?utf-8?B?TFppeFM2OVp3T055dDBWekxnVVdSZEFwS3I4NzVmUnNoTXdTbGZJakxnTTFC?=
 =?utf-8?B?eUx3dkErS0VHeGMxenpMVkdHTUZjM0tRSGJ5N0xpbXJrYkd6cE9hRWZBSjg5?=
 =?utf-8?B?bndPQ0lrMS9vak9IWVordnR4bHIrYkYyM0cwR0R5andKdmx1YnptT0pqeWxX?=
 =?utf-8?B?d3RYcmpjY3lCdlQvMjdnRmE4cGxYNEZoZlNSSGRYeUdDc0NyVE5YZE04d2pk?=
 =?utf-8?B?R3h0ZERDOVhMNFdGMWI2aDJ5V2RGVnFJTGZ4RGc4Nk5pZDNIZ1dqU2xTRmtn?=
 =?utf-8?Q?+a66uWCSsmVNdFG28Hq0rHmSH?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7D0FA40BBFF97F47A797D05CA1FD21C7@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f067f375-a994-4f7d-f56f-08daa5657e8e
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 17:34:15.9768
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H7e6BrAlIbbPlhbwP3L1c1bni96047Ws6DuPb4ylCyO6F0J+GOacZaA0S6L4OAtbt+jZK+Hi+TbxT7kETvK/yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB4909

T24gT2N0IDMsIDIwMjIsIGF0IDg6MDMgQU0sIFZpdGFseSBLdXpuZXRzb3YgPHZrdXpuZXRzQHJl
ZGhhdC5jb20+IHdyb3RlOg0KDQo+IE5vdCBteSBidXQgcmF0aGVyIFBDSSBtYWludGFpbmVyJ3Mg
Y2FsbCBidXQgSU1ITyBkcm9wcGluZyAnY29uc3QnIGlzDQo+IGJldHRlciwgaW50cm9kdWNpbmcg
YSBuZXcgZ2xvYmFsIHZhciBpcyBvdXIgJ2xhc3QgcmVzb3J0JyBhbmQgc2hvdWxkIGJlDQo+IGF2
b2lkZWQgd2hlbmV2ZXIgcG9zc2libGUuIEFsdGVybmF0aXZlbHksIHlvdSBjYW4gYWRkIGENCj4g
cmF3X3BjaV9leHRfb3BzX3ByZWZlcnJlZCgpIGZ1bmN0aW9uIGNoZWNraW5nIHNvbWV0aGluIHdp
dGhpbiAnc3RydWN0DQo+IGh5cGVydmlzb3JfeDg2JyBidXQgSSdtIHVuc3VyZSBpZiBpdCdzIGJl
dHRlci4NCj4gDQo+IEFsc28sIHBsZWFzZSBjaGVjayBBbGV4JyBxdWVzdGlvbi9zdWdnZXN0aW9u
Lg0KDQpIZXJlIGlzIG15IHRha2UgKGFuZCBBamF5IGtub3dzIHByb2JhYmx5IG1vcmUgdGhhbiBt
ZSk6DQoNCkxvb2tpbmcgYnJpZWZseSBvbiBNQ0ZHLCBJIGRvIG5vdCBzZWUgYSBjbGVhbiB3YXkg
b2YgdXNpbmcgdGhlIEFDUEkgdGFibGUuDQpUaGUgdHdvIG9wdGlvbnMgYXJlIGVpdGhlciB0byB1
c2UgYSByZXNlcnZlZCBmaWVsZCAod2hpY2ggd2hvIGtub3dzLCBtaWdodA0KYmUgdXNlZCBvbmUg
ZGF5KSBvciBzb21lIE9FTSBJRC4gSSBhbSBhbHNvIG5vdCBmYW1pbGlhciB3aXRoDQpQQ0lfQ09N
TUFORC5NRU1PUlk9MCwgc28gQWpheSBjYW4gaG9wZWZ1bGx5IGdpdmUgc29tZSBhbnN3ZXIgYWJv
dXQgdGhhdC4NCg0KQW55aG93LCBJIHVuZGVyc3RhbmQgKGFsdGhvdWdoIG5vdCByZWxhdGUpIHRv
IHRoZSBvYmplY3Rpb24gZm9yIGEgbmV3IGdsb2JhbA0KdmFyaWFibGUuIEhvdyBhYm91dCBleHBs
aWNpdGx5IGNhbGxpbmcgdGhpcyBoYXJkd2FyZSBidWcgYSDigJxidWfigJ0gYW5kIHVzaW5nDQp0
aGUgcHJvcGVyIGluZnJhc3RydWN0dXJlPyBDYWxsaW5nIGl0IGV4cGxpY2l0bHkgYSBidWcgbWF5
IGV2ZW4gcHVzaCB3aG9ldmVyDQpjYW4gdG8gcmVzb2x2ZSBpdC4NCg0KSU9XLCBob3cgYWJvdXQg
ZG9pbmcgc29tZXRoaW5nIGFsb25nIHRoZSBsaW5lcyBvZiAobm90IHRlc3RlZCk6DQoNCg0KLS0g
PjggLS0NCg0KU3ViamVjdDogW1BBVENIXSB4ODYvUENJOiBQcmVmZXIgTU1JTyBvdmVyIFBJTyBv
biBWTXdhcmUgaHlwZXJ2aXNvcg0KDQotLS0NCiBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVmZWF0
dXJlcy5oIHwgMSArDQogYXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYyAgICAgICB8IDIgKysN
CiBhcmNoL3g4Ni9rZXJuZWwvY3B1L3Ztd2FyZS5jICAgICAgIHwgMiArKw0KIGFyY2gveDg2L3Bj
aS9jb21tb24uYyAgICAgICAgICAgICAgfCA2ICsrKystLQ0KIDQgZmlsZXMgY2hhbmdlZCwgOSBp
bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvYXJjaC94ODYvaW5j
bHVkZS9hc20vY3B1ZmVhdHVyZXMuaCBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmVz
LmgNCmluZGV4IGVmNDc3NWM2ZGIwMS4uMjE2YjZmMzU3YjZkIDEwMDY0NA0KLS0tIGEvYXJjaC94
ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZXMuaA0KKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20v
Y3B1ZmVhdHVyZXMuaA0KQEAgLTQ2MCw1ICs0NjAsNiBAQA0KICNkZWZpbmUgWDg2X0JVR19NTUlP
X1VOS05PV04JCVg4Nl9CVUcoMjYpIC8qIENQVSBpcyB0b28gb2xkIGFuZCBpdHMgTU1JTyBTdGFs
ZSBEYXRhIHN0YXR1cyBpcyB1bmtub3duICovDQogI2RlZmluZSBYODZfQlVHX1JFVEJMRUVECQlY
ODZfQlVHKDI3KSAvKiBDUFUgaXMgYWZmZWN0ZWQgYnkgUkVUQmxlZWQgKi8NCiAjZGVmaW5lIFg4
Nl9CVUdfRUlCUlNfUEJSU0IJCVg4Nl9CVUcoMjgpIC8qIEVJQlJTIGlzIHZ1bG5lcmFibGUgdG8g
UG9zdCBCYXJyaWVyIFJTQiBQcmVkaWN0aW9ucyAqLw0KKyNkZWZpbmUgWDg2X0JVR19FQ0FNX01N
SU8JCVg4Nl9CVUcoMjkpIC8qIEVDQU0gTU1JTyBpcyBidWdneSBhbmQgUElPIGlzIHByZWZlcmFi
bGUgKi8NCiANCiAjZW5kaWYgLyogX0FTTV9YODZfQ1BVRkVBVFVSRVNfSCAqLw0KZGlmZiAtLWdp
dCBhL2FyY2gveDg2L2tlcm5lbC9jcHUvY29tbW9uLmMgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L2Nv
bW1vbi5jDQppbmRleCAzZTUwOGYyMzkwOTguLmM5NDE3NWZhMzA0YiAxMDA2NDQNCi0tLSBhL2Fy
Y2gveDg2L2tlcm5lbC9jcHUvY29tbW9uLmMNCisrKyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvY29t
bW9uLmMNCkBAIC0xMjk5LDYgKzEyOTksOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQgY3B1X3NldF9i
dWdfYml0cyhzdHJ1Y3QgY3B1aW5mb194ODYgKmMpDQogew0KIAl1NjQgaWEzMl9jYXAgPSB4ODZf
cmVhZF9hcmNoX2NhcF9tc3IoKTsNCiANCisJc2V0dXBfZm9yY2VfY3B1X2J1ZyhYODZfQlVHX0VD
QU1fTU1JTyk7DQorDQogCS8qIFNldCBJVExCX01VTFRJSElUIGJ1ZyBpZiBjcHUgaXMgbm90IGlu
IHRoZSB3aGl0ZWxpc3QgYW5kIG5vdCBtaXRpZ2F0ZWQgKi8NCiAJaWYgKCFjcHVfbWF0Y2hlcyhj
cHVfdnVsbl93aGl0ZWxpc3QsIE5PX0lUTEJfTVVMVElISVQpICYmDQogCSAgICAhKGlhMzJfY2Fw
ICYgQVJDSF9DQVBfUFNDSEFOR0VfTUNfTk8pKQ0KZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5l
bC9jcHUvdm13YXJlLmMgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1L3Ztd2FyZS5jDQppbmRleCAwMjAz
OWVjMzU5N2QuLjg5MDM3NzYyODRhNiAxMDA2NDQNCi0tLSBhL2FyY2gveDg2L2tlcm5lbC9jcHUv
dm13YXJlLmMNCisrKyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvdm13YXJlLmMNCkBAIC0zODUsNiAr
Mzg1LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHZtd2FyZV9zZXRfY2FwYWJpbGl0aWVzKHZvaWQp
DQogCQlzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1ZNQ0FMTCk7DQogCWVsc2UgaWYg
KHZtd2FyZV9oeXBlcmNhbGxfbW9kZSA9PSBDUFVJRF9WTVdBUkVfRkVBVFVSRVNfRUNYX1ZNTUNB
TEwpDQogCQlzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1ZNV19WTU1DQUxMKTsNCisN
CisJc2V0dXBfY2xlYXJfY3B1X2NhcChYODZfQlVHX0VDQU1fTU1JTyk7DQogfQ0KIA0KIHN0YXRp
YyB2b2lkIF9faW5pdCB2bXdhcmVfcGxhdGZvcm1fc2V0dXAodm9pZCkNCmRpZmYgLS1naXQgYS9h
cmNoL3g4Ni9wY2kvY29tbW9uLmMgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMNCmluZGV4IGRkYjc5
ODYwMzIwMS4uYmM4MWNmNGMxMDE0IDEwMDY0NA0KLS0tIGEvYXJjaC94ODYvcGNpL2NvbW1vbi5j
DQorKysgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMNCkBAIC00MCw3ICs0MCw4IEBAIGNvbnN0IHN0
cnVjdCBwY2lfcmF3X29wcyAqX19yZWFkX21vc3RseSByYXdfcGNpX2V4dF9vcHM7DQogaW50IHJh
d19wY2lfcmVhZCh1bnNpZ25lZCBpbnQgZG9tYWluLCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNpZ25l
ZCBpbnQgZGV2Zm4sDQogCQkJCQkJaW50IHJlZywgaW50IGxlbiwgdTMyICp2YWwpDQogew0KLQlp
ZiAoZG9tYWluID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzKQ0KKwlpZiAoZG9tYWlu
ID09IDAgJiYgcmVnIDwgMjU2ICYmIHJhd19wY2lfb3BzICYmDQorCSAgICAoYm9vdF9jcHVfaGFz
X2J1ZyhYODZfQlVHX0VDQU1fTU1JTykgfHwgIXJhd19wY2lfZXh0X29wcykpDQogCQlyZXR1cm4g
cmF3X3BjaV9vcHMtPnJlYWQoZG9tYWluLCBidXMsIGRldmZuLCByZWcsIGxlbiwgdmFsKTsNCiAJ
aWYgKHJhd19wY2lfZXh0X29wcykNCiAJCXJldHVybiByYXdfcGNpX2V4dF9vcHMtPnJlYWQoZG9t
YWluLCBidXMsIGRldmZuLCByZWcsIGxlbiwgdmFsKTsNCkBAIC01MCw3ICs1MSw4IEBAIGludCBy
YXdfcGNpX3JlYWQodW5zaWduZWQgaW50IGRvbWFpbiwgdW5zaWduZWQgaW50IGJ1cywgdW5zaWdu
ZWQgaW50IGRldmZuLA0KIGludCByYXdfcGNpX3dyaXRlKHVuc2lnbmVkIGludCBkb21haW4sIHVu
c2lnbmVkIGludCBidXMsIHVuc2lnbmVkIGludCBkZXZmbiwNCiAJCQkJCQlpbnQgcmVnLCBpbnQg
bGVuLCB1MzIgdmFsKQ0KIHsNCi0JaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdf
cGNpX29wcykNCisJaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNpX29wcyAm
Jg0KKwkgICAgKGJvb3RfY3B1X2hhc19idWcoWDg2X0JVR19FQ0FNX01NSU8pIHx8ICFyYXdfcGNp
X2V4dF9vcHMpKQ0KIAkJcmV0dXJuIHJhd19wY2lfb3BzLT53cml0ZShkb21haW4sIGJ1cywgZGV2
Zm4sIHJlZywgbGVuLCB2YWwpOw0KIAlpZiAocmF3X3BjaV9leHRfb3BzKQ0KIAkJcmV0dXJuIHJh
d19wY2lfZXh0X29wcy0+d3JpdGUoZG9tYWluLCBidXMsIGRldmZuLCByZWcsIGxlbiwgdmFsKTsN
Ci0tIA0KMi4zNC4xDQoNCg0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 17:57:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 17:57:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415002.659466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofPhF-0003JP-TT; Mon, 03 Oct 2022 17:57:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415002.659466; Mon, 03 Oct 2022 17:57:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofPhF-0003JI-QI; Mon, 03 Oct 2022 17:57:41 +0000
Received: by outflank-mailman (input) for mailman id 415002;
 Mon, 03 Oct 2022 17:57:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TmDc=2E=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofPhD-0003J9-L8
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 17:57:39 +0000
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dcf3232d-4344-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 19:57:37 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 5D6E8320046E;
 Mon,  3 Oct 2022 13:57:34 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Mon, 03 Oct 2022 13:57:35 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 13:57:32 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcf3232d-4344-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664819853; x=
	1664906253; bh=Uk/JRNKVFvl3lheGUgcaqE6S3hAEYs1iJ28X3bgK3n8=; b=v
	VsZ6jp3VA92awIcdhJ9PTNw6fvL/hCQrz+zKihzZNiT4f8b6d/9sqLjZGF3hTwVP
	hJ6jESee2bTlVQIZ0qC3KNP+WZXQ7yBFqamZTgzOchuO6m6M5TBmvIMlSBr6JECb
	MiKKbvljhRIMO/btz9fsyAkTbTmUqnOAHpmWNaVJDg+l8ADCZ/RcGCC2uFP9jzW0
	/UuORFj8FA9wkuSuinH4ybMP5QLeBpQQyo2zQKe1X6zMvQHfhGOOW4LttDoHa/nC
	fQur4BNYkbr2YahBQFg9IrJE0mD6yHXk9wQ24Cbz45zaFaFiNjGxCq4OR0jUC2dx
	ycK35EQXEjNDss7ZKUbAg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664819853; x=1664906253; bh=Uk/JRNKVFvl3lheGUgcaqE6S3hAE
	Ys1iJ28X3bgK3n8=; b=yoYyCvHKkCJV189oBA43bvso1jF8GXKr+6BcpSfL3VRG
	EN7Jxq4Hm4HUyeJhL/g3mkp8Xs6BK5zv4ZNN/tTFF18t++QS7D2Q4MOvpI/QkVwq
	u8h+TPRGab9rpYLnyivPAX1NFibDfVk7zwvVY2F3uL7dpR20wbwpOwdXesg6Oc1q
	FPSI2xNaWnK6ryITWNgjQT5mxfPoMS6iiRjKX+aG+uCHaTUnASDLI52p9FOZOVCX
	G26li60U/V8zI7QrVUtXh6SBVV2fkfHIUIlo2VxqIYIAF2Lj6aALDXosKViuXZ+l
	0CL6/L+knMFTS2bjIJcyrDiZpqM4QbLSuEXvCa5ekA==
X-ME-Sender: <xms:jSI7YyEmEDcduJE7-9NopEmf5dzANTzdQxgKLk9P-x1NMxd9Ll4enQ>
    <xme:jSI7YzX-gwDz4kPrk6CB-waMdBbCFvoCPI9onw7QionLHzYadPVlyLZjWawG2ME8y
    1l6II-JtYerpP4>
X-ME-Received: <xmr:jSI7Y8Iy0xQrJ_XVcrzP69dOktL_hAGnHoEZeZ_XL8os8yylvpdUvIsdC5Xm>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledguddukecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeutdehhfdtvdfffeejjedvhedv
    jeeiheffheekkeehgeelueelveeludetheetteenucffohhmrghinhepghhithhhuhgsrd
    gtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep
    uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:jSI7Y8FUQumGyg9Xl3-mR1nd3rORIRdob-LgZt0P9ehCK8RL-cAHxg>
    <xmx:jSI7Y4VAk6UnmVXDl-InNEqHvxlJrJFQ3IHGpQA8eZqVQwl0o1nMZQ>
    <xmx:jSI7Y_OSLB1qmANyx3az7cqcdhhHX0tgCe-y252bD65gAcU9gir6uA>
    <xmx:jSI7Y8QnCqPqIP1n-gCnwpDXwhuwo8Wuu7UdCaT5_Epj08T5OLs36Q>
Feedback-ID: iac594737:Fastmail
Date: Mon, 3 Oct 2022 13:57:14 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall
Message-ID: <Yzsii72GWWvc5tRD@itl-email>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email>
 <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
 <YzsMYfEwmjHwVheb@itl-email>
 <CAMj1kXHR1FfD+ipG4RtbOezx+s_Jo6JwG4fpT5XUmvoqHTctLA@mail.gmail.com>
 <YzsWAnD7q9qeBoBn@mail-itl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="D2tRnVa6ooTGAsFd"
Content-Disposition: inline
In-Reply-To: <YzsWAnD7q9qeBoBn@mail-itl>


--D2tRnVa6ooTGAsFd
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 13:57:14 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall

On Mon, Oct 03, 2022 at 07:04:02PM +0200, Marek Marczykowski-G=C3=B3recki w=
rote:
> On Mon, Oct 03, 2022 at 06:37:19PM +0200, Ard Biesheuvel wrote:
> > On Mon, 3 Oct 2022 at 18:23, Demi Marie Obenour
> > <demi@invisiblethingslab.com> wrote:
> > >
> > > On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote:
> > > > On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
> > > > <demi@invisiblethingslab.com> wrote:
> > > > >
> > > > > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > > > > > Xen on x86 boots dom0 in EFI mode but without providing a memor=
y map.
> > > > > > This means that some sanity checks we would like to perform on
> > > > > > configuration tables or other data structures in memory are not
> > > > > > currently possible. Xen does, however, expose EFI memory descri=
ptor info
> > > > > > via a Xen hypercall, so let's wire that up instead.
> > > > > >
> > > > > > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.co=
m>
> > > > > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
> > > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > > > > ---
> > > > > >  drivers/firmware/efi/efi.c |  5 ++-
> > > > > >  drivers/xen/efi.c          | 34 ++++++++++++++++++++
> > > > > >  include/linux/efi.h        |  1 +
> > > > > >  3 files changed, 39 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/=
efi.c
> > > > > > index 55bd3f4aab28..2c12b1a06481 100644
> > > > > > --- a/drivers/firmware/efi/efi.c
> > > > > > +++ b/drivers/firmware/efi/efi.c
> > > > > > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
> > > > > >   * and if so, populate the supplied memory descriptor with the=
 appropriate
> > > > > >   * data.
> > > > > >   */
> > > > > > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_=
md)
> > > > > > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *ou=
t_md)
> > > > > >  {
> > > > > >       efi_memory_desc_t *md;
> > > > > >
> > > > > > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, efi_=
memory_desc_t *out_md)
> > > > > >       return -ENOENT;
> > > > > >  }
> > > > > >
> > > > > > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_=
t *out_md)
> > > > > > +      __weak __alias(__efi_mem_desc_lookup);
> > > > > > +
> > > > > >  /*
> > > > > >   * Calculate the highest address of an efi memory descriptor.
> > > > > >   */
> > > > > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > > > > > index d1ff2186ebb4..74f3f6d8cdc8 100644
> > > > > > --- a/drivers/xen/efi.c
> > > > > > +++ b/drivers/xen/efi.c
> > > > > > @@ -26,6 +26,7 @@
> > > > > >
> > > > > >  #include <xen/interface/xen.h>
> > > > > >  #include <xen/interface/platform.h>
> > > > > > +#include <xen/page.h>
> > > > > >  #include <xen/xen.h>
> > > > > >  #include <xen/xen-ops.h>
> > > > > >
> > > > > > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
> > > > > >       efi.get_next_high_mono_count    =3D xen_efi_get_next_high=
_mono_count;
> > > > > >       efi.reset_system                =3D xen_efi_reset_system;
> > > > > >  }
> > > > > > +
> > > > > > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_=
md)
> > > > > > +{
> > > > > > +     static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT,
> > > > > > +                   "Mismatch between EFI_PAGE_SHIFT and XEN_PA=
GE_SHIFT");
> > > > > > +     struct xen_platform_op op =3D {
> > > > > > +             .cmd =3D XENPF_firmware_info,
> > > > > > +             .u.firmware_info =3D {
> > > > > > +                     .type =3D XEN_FW_EFI_INFO,
> > > > > > +                     .index =3D XEN_FW_EFI_MEM_INFO,
> > > > > > +                     .u.efi_info.mem.addr =3D phys_addr,
> > > > > > +                     .u.efi_info.mem.size =3D U64_MAX - phys_a=
ddr,
> > > > > > +             }
> > > > > > +     };
> > > > > > +     union xenpf_efi_info *info =3D &op.u.firmware_info.u.efi_=
info;
> > > > > > +     int rc;
> > > > > > +
> > > > > > +     if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMAP))
> > > > > > +             return __efi_mem_desc_lookup(phys_addr, out_md);
> > > > > > +
> > > > > > +     rc =3D HYPERVISOR_platform_op(&op);
> > > > > > +     if (rc) {
> > > > > > +             pr_warn("Failed to lookup header 0x%llx in Xen me=
mory map: error %d\n",
> > > > > > +                     phys_addr, rc);
> > > > > > +     }
> > > > > > +
> > > > > > +     out_md->phys_addr       =3D info->mem.addr;
> > > > >
> > > > > This will be equal to phys_addr, not the actual start of the memo=
ry
> > > > > region.
> > > > >
> > > > > > +     out_md->num_pages       =3D info->mem.size >> EFI_PAGE_SH=
IFT;
> > > > >
> > > > > Similarly, this will be the number of bytes in the memory region
> > > > > after phys_addr, not the total number of bytes in the region.  Th=
ese two
> > > > > differences mean that this function is not strictly equivalent to=
 the
> > > > > original efi_mem_desc_lookup().
> > > > >
> > > > > I am not sure if this matters in practice, but I thought you woul=
d want
> > > > > to be aware of it.
> > > >
> > > > This is a bit disappointing. Is there no way to obtain this
> > > > information via a Xen hypercall?
> > >
> > > It is possible, but doing so is very complex (it essentially requires=
 a
> > > binary search).  This really should be fixed on the Xen side.
> > >
> > > > In any case, it means we'll need to round down phys_addr to page si=
ze
> > > > at the very least.
> > >
> > > That makes sense.  Are there any callers that will be broken even with
> > > this rounding?
> >=20
> > As far as I can tell, it should work fine. The only thing to double
> > check is whether we are not creating spurious error messages from
> > efi_arch_mem_reserve() this way, but as far as I can tell, that should
> > be fine too.
> >=20
> > Is there anyone at your end that can give this a spin on an actual
> > Xen/x86 system?
>=20
> Demi, if you open a PR with this at
> https://github.com/QubesOS/qubes-linux-kernel/pulls, I can run it
> through our CI - (at least) one of the machines has ESRT table. AFAIR
> your test laptop has it too.

Just this patch or the whole series?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--D2tRnVa6ooTGAsFd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM7IosACgkQsoi1X/+c
IsHF8g//dTIfIpadNIEXyA0aIp/PCyaEEQFoYaRj8IWhdimW3HpqcRPY0jxHTZUo
qAvAvWcKMluErnJG/DO+yVHaeGEV05kWlpG0tJXRN752l5pM8KVHLgIyXMVSEB3S
vMeBmXNAi+1mn/sgJ2dOIwWtkcdSumz8LZJc9t9gyP8cHkxmP/EKwstEuJvFZ9zA
ni8NM3H+wuOx5DDJia/3x4QSQrTrm4hG3Mea0owkgigs4RdjVzgYwnpEpeQjCyvQ
JUGh9IrdyXkvQxlRyblCY7NIRvAgYmilZZb2WP6wFB4AkGx5LqVxjmTEHUUurSe1
/gT7tNQz8ExioWIGgJyojoAXMtrazPKoUaPTWwQuZ9vIXsiWJYlaSOcXqFJlWUG1
R7HyZq05VR9iwKcqdofpv3UmMt0MPpQ4AXO9Tu7vFc3wrCv1K2FkXk1AXX09y4xd
ptV4Afr1eIdHlfZ3/YsPW6JNIyS1/DiTGywd4fkw2lIXOGP8O/BljbrSq/ZNwA/P
rgi8ABA2yr7iMUGbxP4RTJTLVZa9eL0xBRcF5400UxP77gLteC+wywqyvbvUqw9p
5v0Cn35/A37KMsm59mF4cMjr9NH5Zbj1fX3yYAkyrW7/G6bR4IaC6lacmLDurTKQ
SSJIexQAZMBxnsYpkq8T3PRAE2gDfPmPZ4tFEuDmHkxAdVilN+w=
=sgHR
-----END PGP SIGNATURE-----

--D2tRnVa6ooTGAsFd--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 18:01:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 18:01:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415009.659478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofPki-0004mU-Ca; Mon, 03 Oct 2022 18:01:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415009.659478; Mon, 03 Oct 2022 18:01:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofPki-0004mN-9v; Mon, 03 Oct 2022 18:01:16 +0000
Received: by outflank-mailman (input) for mailman id 415009;
 Mon, 03 Oct 2022 18:01:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7JV9=2E=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ofPkh-0004mF-C8
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 18:01:15 +0000
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c2f12c0-4345-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 20:01:11 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 5C0B75C00CC;
 Mon,  3 Oct 2022 14:01:09 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Mon, 03 Oct 2022 14:01:09 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 14:01:07 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c2f12c0-4345-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664820069; x=
	1664906469; bh=2VSQgyZMh4OrLebIIZol71KsbLOTruVueA8S4D6AtAM=; b=x
	ITHDnPmTc3sXy1/YEGBc0/zMMWHkn+C2RfVLlnqBmWieGW3G5ecdHMEp+XKQbeFV
	ePt3gcKnXLJ4ZfbANYSFgLisrrQB0NETOaV9DkkZ6EhNGj3yuoTmQZ7rit6k4rZy
	6TRfptJwXO3VuAs8olu2S8im+Y55N9v7TNHxGJsmpz5Fp9tZkGl9OiVvJr0JopkY
	TRwdsKxV4UAUe3SJ0tO3woADAwsyygMjATKauinIqGHALdsMnAZqVJF37bYXMpx0
	lg/sUeT+Qg+YVib40Byv1DfjODewcd+tNvkPke7LXBNyIFyjKiW3rwLSdqR/V16K
	+jjFhIpMpNQB8geWk2zXQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664820069; x=1664906469; bh=2VSQgyZMh4OrLebIIZol71KsbLOT
	ruVueA8S4D6AtAM=; b=SdsXrNzPkeO1eknmVarRpbhC8j5X7JDsrmu/7W15ARDm
	Db2vyLq4jN/1SJtjWk6pA3IUAnBTEfqyKS15Qf+g6VyDvJ+fP7EY1iwanbxORGSt
	JPiAK6tuOlqDhxdRY0577EW149/QMX8aQ3hb/oShIH3GQkTdrh113L1e4gkY2CTX
	hdvQ346KEbvws5/51NncAVIWc6RGlkhWivv+m5mCPL78fWn5vV+A+ro/lNVAl/64
	42lOvw3s0kUyt53YmjSDRs0y+zyRl9qtrj1rmEgAIWCxYqoWyD2tOxt9PHy8xby8
	lWYOtMfuZXdzaXFHeAOqR2h5rOqOtiPCB3mo0I1NGw==
X-ME-Sender: <xms:ZCM7Y5QFe5xFLeF13L0geUYgNtEc3x6m1BkNghhmwM09luuY5GGshw>
    <xme:ZCM7Yyx0yutZ05N8-CktogFeRCanL3-UPEHiwlQ25SmlPqz7pPFN4PQJsH7JSwxJw
    hgBal4pHnam-Q>
X-ME-Received: <xmr:ZCM7Y-1Wg4HLu-l5bhAZZqjwdtnhXz9J7gGNj5jrVcAOM0nj8_jhzdRkKN6RUw4XWbIgznEcfYpcZBWAkC208Ptwip0IyjPhgFWC>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledguddukecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghr
    vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih
    hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeu
    keetteeggffgkeduheetgeeileejjeeiiefhjeegvefhtefggfetueetteeuteenucffoh
    hmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr
    rghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomh
X-ME-Proxy: <xmx:ZCM7YxBdZBIgrfXxapZ1K3ZTr9-ynle6zpQZRHb8SeOR52Awjvx8Sw>
    <xmx:ZCM7YyjEW-dkd8KkJD8_u5mF1usamyCAQNFVUDaapFAtus3IobuYrQ>
    <xmx:ZCM7Y1oRFfpCKEyzzfirXGaHhc2UN_7PfIK4S4Ut6Dfv1SKqYnp7YA>
    <xmx:ZSM7Y9PhirwJuAPtKJPLrIZSk2vN-jZANn0vDbtIFODJ3iFUsXQnHw>
Feedback-ID: i1568416f:Fastmail
Date: Mon, 3 Oct 2022 20:01:03 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall
Message-ID: <YzsjYHirK+SXUjGl@mail-itl>
References: <20221003112625.972646-1-ardb@kernel.org>
 <20221003112625.972646-6-ardb@kernel.org>
 <Yzr/1s9CbA0CClmt@itl-email>
 <CAMj1kXEXhDXRSnBp8P=urFj8UzzeRtYS9V8Tdt9GSrZTnGRFhA@mail.gmail.com>
 <YzsMYfEwmjHwVheb@itl-email>
 <CAMj1kXHR1FfD+ipG4RtbOezx+s_Jo6JwG4fpT5XUmvoqHTctLA@mail.gmail.com>
 <YzsWAnD7q9qeBoBn@mail-itl>
 <Yzsii72GWWvc5tRD@itl-email>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="on5cRYSDowX0FpPJ"
Content-Disposition: inline
In-Reply-To: <Yzsii72GWWvc5tRD@itl-email>


--on5cRYSDowX0FpPJ
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 20:01:03 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org,
	Xen developer discussion <xen-devel@lists.xenproject.org>,
	Peter Jones <pjones@redhat.com>, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2 5/6] efi: xen: Implement memory descriptor lookup
 based on hypercall

On Mon, Oct 03, 2022 at 01:57:14PM -0400, Demi Marie Obenour wrote:
> On Mon, Oct 03, 2022 at 07:04:02PM +0200, Marek Marczykowski-G=C3=B3recki=
 wrote:
> > On Mon, Oct 03, 2022 at 06:37:19PM +0200, Ard Biesheuvel wrote:
> > > On Mon, 3 Oct 2022 at 18:23, Demi Marie Obenour
> > > <demi@invisiblethingslab.com> wrote:
> > > >
> > > > On Mon, Oct 03, 2022 at 05:59:52PM +0200, Ard Biesheuvel wrote:
> > > > > On Mon, 3 Oct 2022 at 17:29, Demi Marie Obenour
> > > > > <demi@invisiblethingslab.com> wrote:
> > > > > >
> > > > > > On Mon, Oct 03, 2022 at 01:26:24PM +0200, Ard Biesheuvel wrote:
> > > > > > > Xen on x86 boots dom0 in EFI mode but without providing a mem=
ory map.
> > > > > > > This means that some sanity checks we would like to perform on
> > > > > > > configuration tables or other data structures in memory are n=
ot
> > > > > > > currently possible. Xen does, however, expose EFI memory desc=
riptor info
> > > > > > > via a Xen hypercall, so let's wire that up instead.
> > > > > > >
> > > > > > > Co-developed-by: Demi Marie Obenour <demi@invisiblethingslab.=
com>
> > > > > > > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.co=
m>
> > > > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > > > > > ---
> > > > > > >  drivers/firmware/efi/efi.c |  5 ++-
> > > > > > >  drivers/xen/efi.c          | 34 ++++++++++++++++++++
> > > > > > >  include/linux/efi.h        |  1 +
> > > > > > >  3 files changed, 39 insertions(+), 1 deletion(-)
> > > > > > >
> > > > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/ef=
i/efi.c
> > > > > > > index 55bd3f4aab28..2c12b1a06481 100644
> > > > > > > --- a/drivers/firmware/efi/efi.c
> > > > > > > +++ b/drivers/firmware/efi/efi.c
> > > > > > > @@ -456,7 +456,7 @@ void __init efi_find_mirror(void)
> > > > > > >   * and if so, populate the supplied memory descriptor with t=
he appropriate
> > > > > > >   * data.
> > > > > > >   */
> > > > > > > -int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *ou=
t_md)
> > > > > > > +int __efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *=
out_md)
> > > > > > >  {
> > > > > > >       efi_memory_desc_t *md;
> > > > > > >
> > > > > > > @@ -485,6 +485,9 @@ int efi_mem_desc_lookup(u64 phys_addr, ef=
i_memory_desc_t *out_md)
> > > > > > >       return -ENOENT;
> > > > > > >  }
> > > > > > >
> > > > > > > +extern int efi_mem_desc_lookup(u64 phys_addr, efi_memory_des=
c_t *out_md)
> > > > > > > +      __weak __alias(__efi_mem_desc_lookup);
> > > > > > > +
> > > > > > >  /*
> > > > > > >   * Calculate the highest address of an efi memory descriptor.
> > > > > > >   */
> > > > > > > diff --git a/drivers/xen/efi.c b/drivers/xen/efi.c
> > > > > > > index d1ff2186ebb4..74f3f6d8cdc8 100644
> > > > > > > --- a/drivers/xen/efi.c
> > > > > > > +++ b/drivers/xen/efi.c
> > > > > > > @@ -26,6 +26,7 @@
> > > > > > >
> > > > > > >  #include <xen/interface/xen.h>
> > > > > > >  #include <xen/interface/platform.h>
> > > > > > > +#include <xen/page.h>
> > > > > > >  #include <xen/xen.h>
> > > > > > >  #include <xen/xen-ops.h>
> > > > > > >
> > > > > > > @@ -292,3 +293,36 @@ void __init xen_efi_runtime_setup(void)
> > > > > > >       efi.get_next_high_mono_count    =3D xen_efi_get_next_hi=
gh_mono_count;
> > > > > > >       efi.reset_system                =3D xen_efi_reset_syste=
m;
> > > > > > >  }
> > > > > > > +
> > > > > > > +int efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *ou=
t_md)
> > > > > > > +{
> > > > > > > +     static_assert(XEN_PAGE_SHIFT =3D=3D EFI_PAGE_SHIFT,
> > > > > > > +                   "Mismatch between EFI_PAGE_SHIFT and XEN_=
PAGE_SHIFT");
> > > > > > > +     struct xen_platform_op op =3D {
> > > > > > > +             .cmd =3D XENPF_firmware_info,
> > > > > > > +             .u.firmware_info =3D {
> > > > > > > +                     .type =3D XEN_FW_EFI_INFO,
> > > > > > > +                     .index =3D XEN_FW_EFI_MEM_INFO,
> > > > > > > +                     .u.efi_info.mem.addr =3D phys_addr,
> > > > > > > +                     .u.efi_info.mem.size =3D U64_MAX - phys=
_addr,
> > > > > > > +             }
> > > > > > > +     };
> > > > > > > +     union xenpf_efi_info *info =3D &op.u.firmware_info.u.ef=
i_info;
> > > > > > > +     int rc;
> > > > > > > +
> > > > > > > +     if (!efi_enabled(EFI_PARAVIRT) || efi_enabled(EFI_MEMMA=
P))
> > > > > > > +             return __efi_mem_desc_lookup(phys_addr, out_md);
> > > > > > > +
> > > > > > > +     rc =3D HYPERVISOR_platform_op(&op);
> > > > > > > +     if (rc) {
> > > > > > > +             pr_warn("Failed to lookup header 0x%llx in Xen =
memory map: error %d\n",
> > > > > > > +                     phys_addr, rc);
> > > > > > > +     }
> > > > > > > +
> > > > > > > +     out_md->phys_addr       =3D info->mem.addr;
> > > > > >
> > > > > > This will be equal to phys_addr, not the actual start of the me=
mory
> > > > > > region.
> > > > > >
> > > > > > > +     out_md->num_pages       =3D info->mem.size >> EFI_PAGE_=
SHIFT;
> > > > > >
> > > > > > Similarly, this will be the number of bytes in the memory region
> > > > > > after phys_addr, not the total number of bytes in the region.  =
These two
> > > > > > differences mean that this function is not strictly equivalent =
to the
> > > > > > original efi_mem_desc_lookup().
> > > > > >
> > > > > > I am not sure if this matters in practice, but I thought you wo=
uld want
> > > > > > to be aware of it.
> > > > >
> > > > > This is a bit disappointing. Is there no way to obtain this
> > > > > information via a Xen hypercall?
> > > >
> > > > It is possible, but doing so is very complex (it essentially requir=
es a
> > > > binary search).  This really should be fixed on the Xen side.
> > > >
> > > > > In any case, it means we'll need to round down phys_addr to page =
size
> > > > > at the very least.
> > > >
> > > > That makes sense.  Are there any callers that will be broken even w=
ith
> > > > this rounding?
> > >=20
> > > As far as I can tell, it should work fine. The only thing to double
> > > check is whether we are not creating spurious error messages from
> > > efi_arch_mem_reserve() this way, but as far as I can tell, that should
> > > be fine too.
> > >=20
> > > Is there anyone at your end that can give this a spin on an actual
> > > Xen/x86 system?
> >=20
> > Demi, if you open a PR with this at
> > https://github.com/QubesOS/qubes-linux-kernel/pulls, I can run it
> > through our CI - (at least) one of the machines has ESRT table. AFAIR
> > your test laptop has it too.
>=20
> Just this patch or the whole series?

Whole series.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--on5cRYSDowX0FpPJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM7I2AACgkQ24/THMrX
1yzg/wf+LDFTPPUw1J/CQtZxhhVNBN8dSU3exFs5qVg5GCNO4KPA1pyN1SnRbmOY
ofZvTP4SqCqnS+la1l4Afk4DS1DyV5jxAFbfmhIiSuh8283W3U1yUQ3JvBQVZWAf
Zj2Rsh8la2rIzx6vg3cMNPp7JgOc7AP0EC9xuU6MWpro20WE1TXgP1NTem2Z5h35
k4a0YQtiJj5RL0rXfg7Wnh8O1IVdvVwy4iov32zIJpBFeX/2o9YtQyeRY+S5nJwU
/i84JaQHvgqXXktgkZK/AiJvQ3YooH4oE/rHSL3YNI9TgFRZAQTcG3Zkqh59bj2Q
EuPbN4UMkuOF29tgFSIGrTEMoKehPA==
=C5Oy
-----END PGP SIGNATURE-----

--on5cRYSDowX0FpPJ--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 21:02:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 21:02:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415021.659489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSZw-0004tf-Gd; Mon, 03 Oct 2022 21:02:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415021.659489; Mon, 03 Oct 2022 21:02:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSZw-0004tY-Ds; Mon, 03 Oct 2022 21:02:20 +0000
Received: by outflank-mailman (input) for mailman id 415021;
 Mon, 03 Oct 2022 21:02:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=UGPN=2E=zytor.com=hpa@srs-se1.protection.inumbo.net>)
 id 1ofSZt-0004tS-Vx
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 21:02:18 +0000
Received: from mail.zytor.com (unknown [2607:7c80:54:3::138])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a6f24fa8-435e-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 23:02:14 +0200 (CEST)
Received: from [127.0.0.1] ([73.223.250.219]) (authenticated bits=0)
 by mail.zytor.com (8.17.1/8.17.1) with ESMTPSA id 293L1MEs3109337
 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO);
 Mon, 3 Oct 2022 14:01:22 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6f24fa8-435e-11ed-964a-05401a9f4f97
DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 293L1MEs3109337
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com;
	s=2022090501; t=1664830885;
	bh=5zHAz69mkxip2bzOLRJ4yt3No7BYKjAs2m4UMY86+jU=;
	h=Date:From:To:CC:Subject:In-Reply-To:References:From;
	b=oykLJvyx1Q7ObEI2DH5ERO/25eTiZzFZJgvAbC877waEJ3rI15d4aEdEhxqbJeO9A
	 9mAtYzKq8KzgRaHdsZgLzcZ2FyOyJwtGOC7Mz+CWLiAoLfbb5WWY5pApSxlkZqx2kg
	 +jdO0xgF1Zn08mAVfDnpAfBMkCcXHyW5VxanswAVTHLqQKoZ+Zkpg3OXttXf7gowum
	 15bO9ANhBUQRzE2ffGGoHuLuA3pDNZDMyqSFToe9GidZCxmVEF1Y4Vhvw77jGJ5haa
	 Ryz+0xxNJVgfA4mrSDmKj9XJmZNlHN+9On7utZ6oZSi0H5AyXYqm2nhWCl+Q2Kqooh
	 0qiZDnZqQsadQ==
Date: Mon, 03 Oct 2022 14:01:20 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, Ajay Kaher <akaher@vmware.com>
CC: "x86@kernel.org" <x86@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        Srivatsa Bhat <srivatsab@vmware.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Vasavi Sirnapalli <vsirnapalli@vmware.com>,
        "er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>,
        "willy@infradead.org" <willy@infradead.org>,
        Nadav Amit <namit@vmware.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "jailhouse-dev@googlegroups.com" <jailhouse-dev@googlegroups.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "acrn-dev@lists.projectacrn.org" <acrn-dev@lists.projectacrn.org>,
        "helgaas@kernel.org" <helgaas@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        Alexander Graf <graf@amazon.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
User-Agent: K-9 Mail for Android
In-Reply-To: <87tu4l9cfm.fsf@redhat.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com> <87tu4l9cfm.fsf@redhat.com>
Message-ID: <E522EECC-D20D-4A69-8A44-9CF2B36E2A29@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On October 3, 2022 8:03:41 AM PDT, Vitaly Kuznetsov <vkuznets@redhat=2Ecom>=
 wrote:
>Ajay Kaher <akaher@vmware=2Ecom> writes:
>
>>> =EF=BB=BFOn 13/09/22, 7:05 PM, "Vitaly Kuznetsov" <vkuznets@redhat=2Ec=
om> wrote:
>>>>
>>>> Thanks Vitaly for your response=2E
>>>>
>>>> 1=2E we have multiple objects of struct pci_raw_ops, 2=2E adding 'pri=
ority' field to struct pci_raw_ops
>>>> doesn't seems to be appropriate as need to take decision which object=
 of struct pci_raw_ops has
>>>> to be used, not something with-in struct pci_raw_ops=2E
>>>
>>> I'm not sure I follow, you have two instances of 'struct pci_raw_ops'
>>> which are called 'raw_pci_ops' and 'raw_pci_ext_ops'=2E What if you do
>>> something like (completely untested):
>>>
>>> diff --git a/arch/x86/include/asm/pci_x86=2Eh b/arch/x86/include/asm/p=
ci_x86=2Eh
>>> index 70533fdcbf02=2E=2Efb8270fa6c78 100644
>>> --- a/arch/x86/include/asm/pci_x86=2Eh
>>> +++ b/arch/x86/include/asm/pci_x86=2Eh
>>> @@ -116,6 +116,7 @@ extern void (*pcibios_disable_irq)(struct pci_dev =
*dev);
>>> extern bool mp_should_keep_irq(struct device *dev);
>>>
>>> struct pci_raw_ops {
>>> +       int rating;
>>>          int (*read)(unsigned int domain, unsigned int bus, unsigned i=
nt devfn,
>>>                                                int reg, int len, u32 *=
val);
>>>          int (*write)(unsigned int domain, unsigned int bus, unsigned =
int devfn,
>>> diff --git a/arch/x86/pci/common=2Ec b/arch/x86/pci/common=2Ec
>>> index ddb798603201=2E=2Ee9965fd11576 100644
>>> --- a/arch/x86/pci/common=2Ec
>>> +++ b/arch/x86/pci/common=2Ec
>>> @@ -40,7 +40,8 @@ const struct pci_raw_ops *__read_mostly raw_pci_ext_=
ops;
>>>  int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int =
devfn,
>>>                                                 int reg, int len, u32 =
*val)
>>> {
>>> -       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>>> +       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>>> +           (!raw_pci_ext_ops || raw_pci_ext_ops->rating <=3D raw_pci_=
ops->rating))
>>>                 return raw_pci_ops->read(domain, bus, devfn, reg, len,=
 val);
>>>         if (raw_pci_ext_ops)
>>>                 return raw_pci_ext_ops->read(domain, bus, devfn, reg, =
len, val);
>>> @@ -50,7 +51,8 @@ int raw_pci_read(unsigned int domain, unsigned int b=
us, unsigned int devfn,
>>>  int raw_pci_write(unsigned int domain, unsigned int bus, unsigned int=
 devfn,
>>>                                                 int reg, int len, u32 =
val)
>>> {
>>> -       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>>> +       if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>>> +           (!raw_pci_ext_ops || raw_pci_ext_ops->rating <=3D raw_pci_=
ops->rating))
>>>                 return raw_pci_ops->write(domain, bus, devfn, reg, len=
, val);
>>>          if (raw_pci_ext_ops)
>>>                 return raw_pci_ext_ops->write(domain, bus, devfn, reg,=
 len, val);
>>>
>>> and then somewhere in Vmware hypervisor initialization code
>>> (arch/x86/kernel/cpu/vmware=2Ec) you do
>>>
>>>  raw_pci_ext_ops->rating =3D 100;
>>
>> Thanks Vitaly, for your review and helping us to improve the code=2E
>>
>> I was working to make changes as you suggested, but before sending v3 w=
ould like to
>> discuss on following:
>>
>> If we add rating with-in struct pci_raw_ops then we can't have pci_mmcf=
g as const,
>> and following change is must in arch/x86/pci/mmconfig_64=2Ec:
>>
>> -const struct pci_raw_ops pci_mmcfg =3D {
>> +struct pci_raw_ops pci_mmcfg =3D {
>>  	=2Eread =3D		pci_mmcfg_read,
>>  	=2Ewrite =3D	pci_mmcfg_write,
>> };
>>
>> So to avoid this change, is it fine to have global bool prefer_raw_pci_=
ext_ops?
>>
>> And raw_pci_read() will have following change:
>>
>> -	if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>> +	if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>> +	     (!prefer_raw_pci_ext_ops ||  !raw_pci_ext_ops)
>>
>
>Not my but rather PCI maintainer's call but IMHO dropping 'const' is
>better, introducing a new global var is our 'last resort' and should be
>avoided whenever possible=2E Alternatively, you can add a
>raw_pci_ext_ops_preferred() function checking somethin within 'struct
>hypervisor_x86' but I'm unsure if it's better=2E
>
>Also, please check Alex' question/suggestion=2E
>
>=2E=2E=2E
>

Could this be ro_after_init?


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 21:07:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 21:07:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415029.659500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSeq-0005XQ-48; Mon, 03 Oct 2022 21:07:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415029.659500; Mon, 03 Oct 2022 21:07:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSeq-0005XJ-0i; Mon, 03 Oct 2022 21:07:24 +0000
Received: by outflank-mailman (input) for mailman id 415029;
 Mon, 03 Oct 2022 21:07:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=UGPN=2E=zytor.com=hpa@srs-se1.protection.inumbo.net>)
 id 1ofSep-0005XB-12
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 21:07:23 +0000
Received: from mail.zytor.com (unknown [2607:7c80:54:3::138])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5dc83b03-435f-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 23:07:21 +0200 (CEST)
Received: from [127.0.0.1] ([73.223.250.219]) (authenticated bits=0)
 by mail.zytor.com (8.17.1/8.17.1) with ESMTPSA id 293L6Wqg3110779
 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO);
 Mon, 3 Oct 2022 14:06:32 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dc83b03-435f-11ed-9377-c1cf23e5d27e
DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 293L6Wqg3110779
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com;
	s=2022090501; t=1664831194;
	bh=/JSxe+u/I+83ths9qOEPL2v7hS1kkD9Op8hnO2pWF/o=;
	h=Date:From:To:CC:Subject:In-Reply-To:References:From;
	b=YMkSnoz2p6qaxRZRVV/rarRM/7dMWPEmTHpXZqhrZJdCyWYQCzslmnrSoJpGJWSlK
	 AaVeyGdJiLJSdtH2wOsJodSqAiD2m4eTNG7CXuVQ0K11OPRU4iqSDfdnybIJX+gGIE
	 BeJ45mLJF/zDJTf2JuB87+OIKc6JD+RPZTghSpLRM/txMKBqZrxWuXZ7C9XG3SZ3mn
	 2j7KuTb1xVD4f/3I4EFs06imInAgGfgeYKpH382p6UO+zKrkDmbYcDZcKRDClaZRdZ
	 T1f8dop7bRAYYpbsG4VXCiNXW5zizZOCjg15VlAcuoBgXisNXXM79/6oFYQ8IDzuzo
	 oGgtncUrzhN/g==
Date: Mon, 03 Oct 2022 14:06:30 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: Nadav Amit <namit@vmware.com>, Vitaly Kuznetsov <vkuznets@redhat.com>,
        Alexander Graf <graf@amazon.com>
CC: Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        Srivatsa Bhat <srivatsab@vmware.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Vasavi Sirnapalli <vsirnapalli@vmware.com>,
        "er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "jailhouse-dev@googlegroups.com" <jailhouse-dev@googlegroups.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "acrn-dev@lists.projectacrn.org" <acrn-dev@lists.projectacrn.org>,
        "helgaas@kernel.org" <helgaas@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
User-Agent: K-9 Mail for Android
In-Reply-To: <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com> <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
Message-ID: <42CFC548-F8FE-4BD9-89AB-198B2B3F1091@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On October 3, 2022 10:34:15 AM PDT, Nadav Amit <namit@vmware=2Ecom> wrote:
>On Oct 3, 2022, at 8:03 AM, Vitaly Kuznetsov <vkuznets@redhat=2Ecom> wrot=
e:
>
>> Not my but rather PCI maintainer's call but IMHO dropping 'const' is
>> better, introducing a new global var is our 'last resort' and should be
>> avoided whenever possible=2E Alternatively, you can add a
>> raw_pci_ext_ops_preferred() function checking somethin within 'struct
>> hypervisor_x86' but I'm unsure if it's better=2E
>>=20
>> Also, please check Alex' question/suggestion=2E
>
>Here is my take (and Ajay knows probably more than me):
>
>Looking briefly on MCFG, I do not see a clean way of using the ACPI table=
=2E
>The two options are either to use a reserved field (which who knows, migh=
t
>be used one day) or some OEM ID=2E I am also not familiar with
>PCI_COMMAND=2EMEMORY=3D0, so Ajay can hopefully give some answer about th=
at=2E
>
>Anyhow, I understand (although not relate) to the objection for a new glo=
bal
>variable=2E How about explicitly calling this hardware bug a =E2=80=9Cbug=
=E2=80=9D and using
>the proper infrastructure? Calling it explicitly a bug may even push whoe=
ver
>can to resolve it=2E
>
>IOW, how about doing something along the lines of (not tested):
>
>
>-- >8 --
>
>Subject: [PATCH] x86/PCI: Prefer MMIO over PIO on VMware hypervisor
>
>---
> arch/x86/include/asm/cpufeatures=2Eh | 1 +
> arch/x86/kernel/cpu/common=2Ec       | 2 ++
> arch/x86/kernel/cpu/vmware=2Ec       | 2 ++
> arch/x86/pci/common=2Ec              | 6 ++++--
> 4 files changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/include/asm/cpufeatures=2Eh b/arch/x86/include/asm/=
cpufeatures=2Eh
>index ef4775c6db01=2E=2E216b6f357b6d 100644
>--- a/arch/x86/include/asm/cpufeatures=2Eh
>+++ b/arch/x86/include/asm/cpufeatures=2Eh
>@@ -460,5 +460,6 @@
> #define X86_BUG_MMIO_UNKNOWN		X86_BUG(26) /* CPU is too old and its MMIO=
 Stale Data status is unknown */
> #define X86_BUG_RETBLEED		X86_BUG(27) /* CPU is affected by RETBleed */
> #define X86_BUG_EIBRS_PBRSB		X86_BUG(28) /* EIBRS is vulnerable to Post =
Barrier RSB Predictions */
>+#define X86_BUG_ECAM_MMIO		X86_BUG(29) /* ECAM MMIO is buggy and PIO is =
preferable */
>=20
> #endif /* _ASM_X86_CPUFEATURES_H */
>diff --git a/arch/x86/kernel/cpu/common=2Ec b/arch/x86/kernel/cpu/common=
=2Ec
>index 3e508f239098=2E=2Ec94175fa304b 100644
>--- a/arch/x86/kernel/cpu/common=2Ec
>+++ b/arch/x86/kernel/cpu/common=2Ec
>@@ -1299,6 +1299,8 @@ static void __init cpu_set_bug_bits(struct cpuinfo_=
x86 *c)
> {
> 	u64 ia32_cap =3D x86_read_arch_cap_msr();
>=20
>+	setup_force_cpu_bug(X86_BUG_ECAM_MMIO);
>+
> 	/* Set ITLB_MULTIHIT bug if cpu is not in the whitelist and not mitigat=
ed */
> 	if (!cpu_matches(cpu_vuln_whitelist, NO_ITLB_MULTIHIT) &&
> 	    !(ia32_cap & ARCH_CAP_PSCHANGE_MC_NO))
>diff --git a/arch/x86/kernel/cpu/vmware=2Ec b/arch/x86/kernel/cpu/vmware=
=2Ec
>index 02039ec3597d=2E=2E8903776284a6 100644
>--- a/arch/x86/kernel/cpu/vmware=2Ec
>+++ b/arch/x86/kernel/cpu/vmware=2Ec
>@@ -385,6 +385,8 @@ static void __init vmware_set_capabilities(void)
> 		setup_force_cpu_cap(X86_FEATURE_VMCALL);
> 	else if (vmware_hypercall_mode =3D=3D CPUID_VMWARE_FEATURES_ECX_VMMCALL=
)
> 		setup_force_cpu_cap(X86_FEATURE_VMW_VMMCALL);
>+
>+	setup_clear_cpu_cap(X86_BUG_ECAM_MMIO);
> }
>=20
> static void __init vmware_platform_setup(void)
>diff --git a/arch/x86/pci/common=2Ec b/arch/x86/pci/common=2Ec
>index ddb798603201=2E=2Ebc81cf4c1014 100644
>--- a/arch/x86/pci/common=2Ec
>+++ b/arch/x86/pci/common=2Ec
>@@ -40,7 +40,8 @@ const struct pci_raw_ops *__read_mostly raw_pci_ext_ops=
;
> int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int dev=
fn,
> 						int reg, int len, u32 *val)
> {
>-	if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>+	if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>+	    (boot_cpu_has_bug(X86_BUG_ECAM_MMIO) || !raw_pci_ext_ops))
> 		return raw_pci_ops->read(domain, bus, devfn, reg, len, val);
> 	if (raw_pci_ext_ops)
> 		return raw_pci_ext_ops->read(domain, bus, devfn, reg, len, val);
>@@ -50,7 +51,8 @@ int raw_pci_read(unsigned int domain, unsigned int bus,=
 unsigned int devfn,
> int raw_pci_write(unsigned int domain, unsigned int bus, unsigned int de=
vfn,
> 						int reg, int len, u32 val)
> {
>-	if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>+	if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>+	    (boot_cpu_has_bug(X86_BUG_ECAM_MMIO) || !raw_pci_ext_ops))
> 		return raw_pci_ops->write(domain, bus, devfn, reg, len, val);
> 	if (raw_pci_ext_ops)
> 		return raw_pci_ext_ops->write(domain, bus, devfn, reg, len, val);

Also=2E=2E=2E any reason we can't just set raw_pci_ops =3D=3D raw_ext_pci_=
ops for the case when the latter is preferred, and dispense with the condit=
ionals in the use path? Similarly, raw_ext_pci_ops could be pointed to erro=
r routines instead of left at NULL=2E


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 21:12:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 21:12:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415036.659511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSk9-0006yd-NT; Mon, 03 Oct 2022 21:12:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415036.659511; Mon, 03 Oct 2022 21:12:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSk9-0006yW-KF; Mon, 03 Oct 2022 21:12:53 +0000
Received: by outflank-mailman (input) for mailman id 415036;
 Mon, 03 Oct 2022 21:12:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7JV9=2E=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ofSk8-0006yQ-KM
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 21:12:52 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2293ea2f-4360-11ed-9377-c1cf23e5d27e;
 Mon, 03 Oct 2022 23:12:50 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 1CFC85C00D4;
 Mon,  3 Oct 2022 17:12:49 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Mon, 03 Oct 2022 17:12:49 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 17:12:47 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2293ea2f-4360-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664831569; x=
	1664917969; bh=QO7yJWuFeZolTAR5MHq79CYUXiEgOR1Wdx6u+iK1f8Y=; b=M
	MMHCgrUAF7GrdNZvrCX2HUm/GrZC1wKMWedUrH0ztn06idvDpqKye8oSANx42BCe
	riHcq1gTmKSAtJY8xiepPvceqb0HQvClEd0T6UJOaCuYrADq/PEytD9C4vnUFeQx
	zVFTZT2qndJUNHg/aj4+NwKOvSf7hX+BHyQu3D5nOmnv1BVlp4vSjbcmzepWRpO5
	DyVuU3xWT9UtjLOfOTpTUz5x1JV+hRzZOiiJOaGUP7pXESZ7orywmorORMYJ6IB9
	slM3TGzlqywdwV8+1G8dfNPk3EYDSn0w0DAsd+n4/N4X6nlvt9Uu/8cK76gyFa2r
	pm94mMOtFnCUBZaJN7WNw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664831569; x=1664917969; bh=QO7yJWuFeZolTAR5MHq79CYUXiEg
	OR1Wdx6u+iK1f8Y=; b=LG7PIkMobnl3I+165aQUjUX4KyUtZanRMHElfaDD5iLH
	9p1rYe+6N6Xs12IZCO/rzFcloJFacWkGpNM5dzjP13C0vrRdEkGXU/YHigzZQKZi
	x3mro2VOC0zm6ZS7GHIC8EcvS34mLA+RC3xpLrnFBWRNS/pqXPrvg1ywpBWPhuca
	hQ7uMWoKUpSDLajyIGG7PMW8MthAfwDGT0mJJ5LeUfEieuuBJEMo0bps8fWYqh3v
	rPijVgoDvTTu4vQVzhFcsJ1uECoLuoSrQFkQ+s1ryBBTSdhAreRRi48LqA03vuPO
	gJ7h6tlX2rREFMYWonOT+oMPFSXV7mVuyauNRuqeDw==
X-ME-Sender: <xms:UFA7Y7LWzmU1RhqwrVLey0EeSnBJgBq2GqMud8zvZHx-1n4qmsny_w>
    <xme:UFA7Y_JxA75tRPNH33EzEj4Wh9JfxwndQgYfTyvnQRl2bFVMlZQu0-G3RRke56TVd
    E8Q3On266MqUQ>
X-ME-Received: <xmr:UFA7YztIT976G5orv7LtN3qAysAlvbcK_2JbK8ZA9cbHBG92R6xwhEv6c9Ufwd392S6irTN4tx8PWo6hgcWSrSs2ZbQOHkAh6UAe>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehledgudehjecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpeforghr
    vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih
    hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedt
    tedvhfekudetvdelffeguedtkeethfethfffhfefteeghfeigeelvddttdektdenucevlh
    hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv
    khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:UFA7Y0Yv7ud4RNUvgtfPPpuwxIqfnuGzkPMVXH6gOU9G4GOqVhb6-A>
    <xmx:UFA7YybJrkNyZJLELSFMPKnxJ3OatpgS3D0qsbHg29N-heJl1GlWuQ>
    <xmx:UFA7Y4BlEr72vMt0fnJhRWeJqjn_IZ-mpOX4dSKMD6BuPzMonHzYSg>
    <xmx:UVA7Y65c1ZnfQZgXj1qj3Wv82UXjIjmTqTWDarsixm8ysRFI8HqBcg>
Feedback-ID: i1568416f:Fastmail
Date: Mon, 3 Oct 2022 23:12:45 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Roger Pau Monne <roger.pau@citrix.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing
 mode
Message-ID: <YztQTaXUHKTlskrV@mail-itl>
References: <f793ef22-54d4-a74e-b01b-4ebca58b2abd@suse.com>
 <8f07c532-e742-fa02-27ee-b08c56299d09@citrix.com>
 <YzcOOlv1zqzWlH9e@mail-itl>
 <04f7de01-4e8e-b964-d676-d756265c2776@citrix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="BsZF/oQAoJ1MBBda"
Content-Disposition: inline
In-Reply-To: <04f7de01-4e8e-b964-d676-d756265c2776@citrix.com>


--BsZF/oQAoJ1MBBda
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 23:12:45 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Roger Pau Monne <roger.pau@citrix.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH for-4.17?] x86: support data operand independent timing
 mode

On Fri, Sep 30, 2022 at 05:24:21PM +0000, Andrew Cooper wrote:
> Hmm.  So yes, lets approach the problem from the other side, as "this bit=
 needs setting to unbreak crypto code".
>=20
> On hardware supporting DOITM, where we do not advertise the feature to gu=
ests (all guests right now), the guest kernel would conclude that it is saf=
e, when in fact it is not.
>=20
> So Xen should set the bit behind the back of a guest which doesn't have t=
he DOITM enumeration presented (which is all guests right now).

Yes, makes sense.

> But I don't think we want any Kconfig about this, or a dedicated cmdline =
option.  So how about this for a plan which avoids painting ourselves into =
a corner.
>=20
> 1) Extend cpuid=3D with a no-doitm option.  I know it's not actually a CP=
UID enumeration, but MSR_ARCH_CAPS should have been CPUID data, and this is=
 the mechanism we have meaning "pretend this feature isn't enumerated".

Sounds fine. But I wonder if there is any plan for [virtualizing] other
MSR_ARCH_CAPS - will they be treated as cpuid too?

> 2) On boot, and S3 resume, if DOITM and availble, set invariant mode.

+1

> That should do as a stopgap for now that keeps software safe.
>=20
>=20
> Then, when we've got MSR_ARCH_CAPS working for guests, the internals of M=
SR_UARCH_MISC_CTL change to being a context switched thing which, like MSR_=
SPEC_CTRL, we have options for bits set behind the guest's back.  Then we s=
et DOITM behind the guests back if levelling causes the feature to be hidde=
n.  We do this for some bits already, and need to do so for more controls t=
oo.
>=20
> ~Andrew

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--BsZF/oQAoJ1MBBda
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM7UEwACgkQ24/THMrX
1yzJ0gf/ZbBGBatB8/MiwA2YrJikFyLisDIt4ZNsiXow5Fljjzoj6T1qBCSx+TBx
8GnFWHorumNd9wySgH/XqrEn+k8CT7rTpBRJq/lEDTosIjcDEPy2WjYT9M37n7bS
phB2O7/+O6+UETIBS1OwXIgEBRnTrqu0X2I4y0Nd2H9gPROGSoS/WcJj+hy2ssxt
OsOqu2md/TK2nzZOLvuRrvLJ8COPwoFWbn0V+ShVTQTymoHtY6AVM2hBus5ONz/Z
c0fpXyonZQSLyCQuw79zCshFSh//bk+aWRYWt8icuZfam3GRIILeJf8wqD4VXel0
OKbDMpc9grQbuvksOQYGVBaP6ubQPw==
=dvlG
-----END PGP SIGNATURE-----

--BsZF/oQAoJ1MBBda--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 21:21:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 21:21:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415046.659522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSsk-0008RQ-If; Mon, 03 Oct 2022 21:21:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415046.659522; Mon, 03 Oct 2022 21:21:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSsk-0008RJ-Fw; Mon, 03 Oct 2022 21:21:46 +0000
Received: by outflank-mailman (input) for mailman id 415046;
 Mon, 03 Oct 2022 21:21:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tjbh=2E=citrix.com=prvs=268c0e076=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ofSsj-0008RD-9M
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 21:21:45 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5fa1dfc1-4361-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 23:21:43 +0200 (CEST)
Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 03 Oct 2022 17:21:39 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN9PR03MB6201.namprd03.prod.outlook.com (2603:10b6:408:11e::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 3 Oct
 2022 21:21:38 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Mon, 3 Oct 2022
 21:21:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fa1dfc1-4361-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664832103;
  h=from:to:cc:subject:date:message-id:content-id:
   content-transfer-encoding:mime-version;
  bh=tiHU+bIXklVqxNLUEra5VirIyiweR3h6T6rLIb9iM9k=;
  b=Sd55VbrWHwdH5dj76oxRB0VPPNJKjP0gfhsXrvjhRXpel5WHeRM+5znR
   K0q+FntoVpj48FHkVx4i5inaPElyRi4QYaHOWgqKd4uMg77T2R6y2BOGk
   35a8TD3EAT1q77AyHtkj7xSlJ8aBhDh3CylPZw9nkgKOeFj5rAr4epH+b
   c=;
X-IronPort-RemoteIP: 104.47.57.170
X-IronPort-MID: 81016703
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:GlYKvaKdkUexlrjGFE+R45QlxSXFcZb7ZxGr2PjKsXjdYENSgTMDn
 zFLD2qAPfaONjHzetlwat+18EJV6paAyNdrG1FlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYzl8B56r8ks15q2q4GhA5TTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FaYCpvl8MW1Nz
 NoFdhEzZCDfncnsm4vuH4GAhux7RCXqFKU2nyg5iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T/PVvi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv
 Dnu9GXlGBAKcteYzFJp91r837eWw3yjA+r+EpWWythyon+x/VZQUhkaaHHiqtukg3CXDoc3x
 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsTDRMddgnv88eXiEx2
 xmCmNaBLSNrmK2YTzSa7Lj8hRO/PzIEa1ALYyAsRBEApdLkpekOYgnnS99iFOu5i4PzEDSpm
 jSS9nFh3/MUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U
 LIswqByMMhm4UmxqRGw
IronPort-HdrOrdr: A9a23:Cdwgo66XFqFkF8vjlQPXwX+BI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhIU3Jmbi7Scq9qeu1z+8/3WBjB8bbYOCAghrjEGgC1/qr/9SEIUHDH4FmpM
 BdmsRFaeEYbmIKwPoSgjPIderIqePvmM/HuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK
 DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561
 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu
 O85yvIcf4DrE85NVvF2icFkzOQqgrGrUWShWNwyEGT3fAQDlgBerd8rJMcfR3D50U6utZglK
 pNwmKCrpJSSQjNhSLn+rHzJmZXf2eP0A8feNQo/ghieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO
 0rCM3H/v5ZfV6Tcnic5wBUsZWRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u
 yBOKV1k7NFSNMQcMtGdZE8aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu178HLzou
 WzbLp1jx9CR6u1M7zw4HRiyGGyfEytGTLw18pZ+591/rXhWbuDC1zydGwT
X-IronPort-AV: E=Sophos;i="5.93,366,1654574400"; 
   d="scan'208";a="81016703"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aY7o3/5A0giTK2p70LBMco+oMwR5L25R9WwB5tRqWTmlW6hUa/p5Ag/kWNVMYyb6sILmX2JG2L3yHtV5vQOo9JyjeOG1mO+oOaPR/gPRKCmP2SOupW+CEN2z8X3jP/9Uq8j7WISfLMJO/sVW/2hc1KVAlX1ZljOBQNKfIwCY6UHfXxk0hWIvGJlNKNWxQ8xvktT1UvaFpn9IUqE5+84UyHcoswSKGqLrcY6S5iugON9xy7V7bScWKA660TZaW+RkDf1nmSnplvAyOK6w2r7DRBJ5AgrFDTwfLXOBkyAX46Q6bOAw0bPrJthfZCO1PJec3aQicj2uwgHdlYtATPZtzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tiHU+bIXklVqxNLUEra5VirIyiweR3h6T6rLIb9iM9k=;
 b=BGkeo/GgM0fc9m9oOOXThND0p1uqlcI3H3JHEoFDKLp2G9SAYKz5eLk2cTaf46XWLxcAMkS2VgbpRAhu+szANbgYW7Hz3DTIfB6I9Jy8YKaiw3ZOwdmvhr+vex72Rp/hPmJDLfsB+s7ZVLDA1a/qopSPDeB2YnD/t+U7AzAW2kNBgarHO9iuLRX7Nhsl3SdnbsRE4RHtnrVhtndiiZAha9r9j9eEciEDfnL5kdepCpH+EHnztXqr4f0SNfgjMTmhc63VBWxrW8ARXag2QeScyxVfXlBh7hAGm0LjQODWVdD+er1Ebn/sTLqZ+MbGi95wmEnqEBmh1hJAvGzUdU7xdQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tiHU+bIXklVqxNLUEra5VirIyiweR3h6T6rLIb9iM9k=;
 b=K4oFzfwAD0ZGVReir9qRyujE9sGiOXd0pulgilYm/uzfKUvd/ffmS7A4nqtxoxsM8bONJw54oMTgoI6m9Eo6mrmHwlgHftQqqkJEqiPBru5MYhRxbKoxvCdXYS0kgvkjk5EGCjBZhJQJdC8xcYSCO9bxsTZDcM1lVyOfRmyUNkQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
CC: Henry Wang <Henry.Wang@arm.com>
Subject: x86 NUMA error on OSSTest box
Thread-Topic: x86 NUMA error on OSSTest box
Thread-Index: AQHY124ffCJyPjQjLEmHNxgebZjhFA==
Date: Mon, 3 Oct 2022 21:21:37 +0000
Message-ID: <5dba58e7-491c-d396-ea1c-de03dc0053bd@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN9PR03MB6201:EE_
x-ms-office365-filtering-correlation-id: 351b61bd-2711-43f9-d819-08daa58541ae
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4Qg9xfXXloT31ZxWbY5C2Nx+Cplm0rn1yb/87RI6/HGnFc/rQoWdWg/s8DeX/ANSsR65QX0t8ddA1XEkDGWvK0mXyEi4dDFzCHBT0DhI4hC354rw1GswoT6erKY/HhbDoabwgH9ArGzdBzusLMOWrefbqF/X7m0GUsjQlfzvvPhAgu+XUDUzkTCaEZ6GQs1M+D6SGPdRXRvOlpHILLFFTupPrA7JFmhCUgQqtHibK5rvXbRyr76GeIrlf7NR27McRx2OfVaZbWU3Uz2a6EmPF7poWdc9KIz+sAclF8W67V7ySNcmQx94l2N9N0KmwMafcvCtfxiulpJiur0NKS81JNxWMxWlFz+23u5cUQH/xHYBQ/dj8wUZ0UVnYjCkjtKru88Ph+yJvYawV9n9mbvtCGickJlik3f1EILHDccbd3wMs9aHiFN/cmt/08yWCVdDMjXsej8+EQFxjm/1GLgHEgOH2PbyRA5mYkHsjcbp3k0LRbnfz+BbMUvocKe99WaUEQnR3nGbnbacx8jKcvsQhyQAirpW4RWPWP/D9l0Q9SyBNtNTksSBiSr8m56vfj5BBZk0FcDs3iysTuXgNrGeJv9glQw3bBOxyyxX9aUQeF1qr8f9Tpw5uEcjocO6lq7Sp5LbtMEKgW430H8rPPD0yDejjPeHQ7pK86rbMphnev7SLIuNy3ZH/eG4C9/i4u7BtWTAF9LmPPV1EN+tHDdlV60sSkYcolJNEP68bMNfQjA4TsIIN/Hv02dkIA11/tvt/XU3WRlgiX8tucObvfzKLlOK6WdywVRF/73z68qspdROjpskceOzvqSbtF30wGIuadKY7CynPkyNnvXRBkAaMA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(4744005)(5660300002)(31686004)(71200400001)(122000001)(478600001)(8936002)(26005)(2906002)(31696002)(6512007)(316002)(110136005)(38100700002)(86362001)(41300700001)(82960400001)(6486002)(76116006)(2616005)(66946007)(66556008)(66446008)(186003)(66476007)(38070700005)(6506007)(4326008)(36756003)(8676002)(64756008)(91956017)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?emZVakJ2TXpUdEM1enl5OE93UGRJSnN5NDIwNXR3bHZiS3VvZkFBUVhQLzl0?=
 =?utf-8?B?d1J6UXIzZy9OQjAzczhrSW5rTUwzanBEZmM5YnAyWVhvNU9EbVNNb2tqSmh2?=
 =?utf-8?B?ZkV3TWVUR2M1M2wxb1dnSUJWY0FFR0JTQkwrcXFGOXNxdjdnQTJvclpJZS9N?=
 =?utf-8?B?Zk5tS0xtcXBnYlFRZGJNaU50ZUZNNUFHTzFkd3hmM3VaYXBtTEI3MTVXallU?=
 =?utf-8?B?MDZqanRIb2xRN0ZjdWMyRVlUODJ2SkJOamlwUjh5SzBxSHFrSGFiSWUxTm1N?=
 =?utf-8?B?dWo4ZTRyQ3JXajAvZ0hvbVNJM05BK3JaS2txMkx0c3ZoSjBnZkx3SXRzV253?=
 =?utf-8?B?RytrQTZLVU14Wk1zTWVpMHgxS1pBZFBhV2VPTkxiRjFEdXRzcHdzRFZqSGdr?=
 =?utf-8?B?ZmMxdWNEdDdwRVRtTzBKalBJNHh6QU5oUW1SZEtLN0crT3I5dm9SckhhT0Fj?=
 =?utf-8?B?Vjd4VzVqTllFUzJZeUlFOTZXWlBHYjdKaEVNVmI4MU1WQnVpS3R2Ti8vWWlo?=
 =?utf-8?B?dk5rcU01VkQ3ckwrMjk1WEZDd25wSU5hZitpQTlBOVdncjJSTWd0bzc1RHV4?=
 =?utf-8?B?QStmRTBYUHNQNEg5ZEpzM2VDMXhyN2QxTUJBeWM1T2x0czJhZG1uamdUcS96?=
 =?utf-8?B?RW55eFhONmNabVg1R2pWRm14ZW5vSTJNaHpkY2Z2VUFncjFDOUg3ZGVwTkgx?=
 =?utf-8?B?RGMzY0FqcGFwbEZ1cTEydzdRc3dBbElNbExFRGhJaUpWY1VTZEpFcDQxV2h5?=
 =?utf-8?B?WUhPNHlIbW0yeWsrL2xlMGtXZ294SHpKdVlnZnRKMUQ3OEVBOXA2ZjhxT0Fl?=
 =?utf-8?B?N0xqMVk4dFBUUThoNlpPeGY1TGNQOWRCTnB3SGhGQ1p1YnR5ZHMxdUhpWStx?=
 =?utf-8?B?Z3BTUzlwMHAvSG1FMUJkYUlSaGlYOXBwV3pPRlI3SnZNKzM2M3RvTjRJRzcx?=
 =?utf-8?B?SjhYbkh3Yy85NVhlUWhORTJ0MlJQMVB5QXp0SC9uOWhOK2kwT2Y4SGpsUVVT?=
 =?utf-8?B?UGZoNDZFdHVYUGNydXlYd3RaaXd5dnRrelY2emgxdWl2RS9mRzFDTGc5T20x?=
 =?utf-8?B?RVUwMjhibTNOTFBnd2Znbk1IbTZ2anJ2MUNLTlhyQUZqemJvZTFaVjVxU1FE?=
 =?utf-8?B?cnR2cVNmdmtvUzJDT3lFUFpZVlRicDFOWXEwTG1TODRkVCtnYjhEV3h1a2dp?=
 =?utf-8?B?cjY3OHE1eHNSeWVWRzU4Sm9nODh3RzFRUXArRTUrNks4S2FNdWdUeUFXa1Fp?=
 =?utf-8?B?SkZJOVBoNmZ6a3ZuQjFQMzVoWmtkNTVTQi85c3hzNUtIQXJNclJrQjljZXRq?=
 =?utf-8?B?TUd4QmswbGRBdDdDNENIT2hHcTBqR3VQSWF5em9mSElIUmF5M25SQXU1UzlS?=
 =?utf-8?B?dlRtVzNNcDQ3YlJKQ2xrRjREQUpwdjVDSHJLeHpoS2FPNFcwYXVRWWFiem1t?=
 =?utf-8?B?cy9PY2hzVzBzbURBMHZwRnh2MEVJKzVoNlNxTVR6d3hXTzlFVjdFenNRd2ZC?=
 =?utf-8?B?WEwxWkxUSjFNOEQxeFNaU01IaldGYTJxODlXNHRyaFFid1Bqek1uS2tUQkly?=
 =?utf-8?B?NTRId01lemNubFhlTUJZMnJqSFZGK0h3cFUydS9tZ2pSeHo5TVdGUncyYWdG?=
 =?utf-8?B?bWMwbjVaTGliZ0JpRkJpZDNuVmpUN2lNVHlEWVhweW04YzJzWENCWTZyZlll?=
 =?utf-8?B?akVzODNFUEtOeTlEaVduNmdSNmxwdUpGN0RHa2ZraGJQb1ZBWEo3OFVQbDZB?=
 =?utf-8?B?MzVMSTBwNWxzYWEyaGw3NTFaWjVEdkRBV3F4aktCMVJ4UWU3MklnSGU4cHEw?=
 =?utf-8?B?V3pjRmpGMlNqZ2xtYi9seVRnSGEvQ0JuYTRIYlpJL2tQc09sTXlYMkpyb2FR?=
 =?utf-8?B?TStmb3NiNTZVVTRqQ0JwelEyQUhqMG1oNGdtNnlvcFFJZ0t2MFR2THYwZmR6?=
 =?utf-8?B?NVh5ZTcreE9NbFVkVkJTd2RWTU1YZCszMVkzZ3dZcDlBZTNGNERqaDhlVm5l?=
 =?utf-8?B?Q1NFYWJhSUFLT3RnR3c2VlFiREdMc0hBZTl5UkNNdFR3RUdad3MzL2dBTGJV?=
 =?utf-8?B?MmEzWjA1QzZKeXY4bXVIRng0Q2sxWWZJMUpaVXpnbjdJYjNhWXZGalN2SmRJ?=
 =?utf-8?Q?tw9aKdohWyF0EdDvnt+rjRime?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <78C3AC9FD83B4049909AC6C71B22C86B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 351b61bd-2711-43f9-d819-08daa58541ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 21:21:37.7401
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vGgITgJFHPKhr/4ECyf/T0Sm1ZNVTitZ6YqczaTZ7MNiZTAfoFqksYnxPRO8C3Q7HSR2V4twGo7TTUbvCA+fd1uZS/udarr7bEFNBa6pDnE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6201

V2hpbGUgd29ya2luZyBvbiBhbm90aGVyIGlzc3VlLCBJIHNwb3R0ZWQgdGhpczoNCg0KKFhFTikg
QUNQSTogRUlOSiA2Q0I5RDYzOCwgMDE1MCAocjEgT1JBQ0xFwqDCoMKgwqAgWDctMiA0MTA2MDMw
MCBJTlRMwqDCoMKgwqDCoMKgwqAgMSkNCihYRU4pIFN5c3RlbSBSQU06IDMyNDI5TUIgKDMzMjA4
MjA0a0IpDQooWEVOKSBTUkFUOiBOb2RlIDAgUFhNIDAgWzAwMDAwMDAwMDAwMDAwMDAsIDAwMDAw
MDAwN2ZmZmZmZmZdDQooWEVOKSBTUkFUOiBOb2RlIDAgUFhNIDAgWzAwMDAwMDAxMDAwMDAwMDAs
IDAwMDAwMDA0N2ZmZmZmZmZdDQooWEVOKSBTUkFUOiBOb2RlIDEgUFhNIDEgWzAwMDAwMDA0ODAw
MDAwMDAsIDAwMDAwMDA4N2ZmZmZmZmZdDQooWEVOKSBOVU1BOiBVc2luZyAxOSBmb3IgdGhlIGhh
c2ggc2hpZnQuDQooWEVOKSBZb3VyIG1lbW9yeSBpcyBub3QgYWxpZ25lZCB5b3UgbmVlZCB0byBy
ZWJ1aWxkIHlvdXIgaHlwZXJ2aXNvcg0Kd2l0aCBhIGJpZ2dlciBOT0RFTUFQU0laRSBzaGlmdD0x
OQ0KKFhFTikgU1JBVDogTm8gTlVNQSBub2RlIGhhc2ggZnVuY3Rpb24gZm91bmQuIENvbnRhY3Qg
bWFpbnRhaW5lcg0KKFhFTikgU1JBVDogU1JBVCBub3QgdXNlZC4NCihYRU4pIE5vIE5VTUEgY29u
ZmlndXJhdGlvbiBmb3VuZA0KKFhFTikgRmFraW5nIGEgbm9kZSBhdCAwMDAwMDAwMDAwMDAwMDAw
LTAwMDAwMDA4ODAwMDAwMDANCihYRU4pIERvbWFpbiBoZWFwIGluaXRpYWxpc2VkDQoNCm9uIHNh
YnJvMCBpbiBPU1NUZXN0IG9uIGN1cnJlbnQgc3RhZ2luZy7CoCBJIGRvIG5vdCBrbm93IGlmIGl0
J3MgYSByZWNlbnQNCnJlZ3Jlc3Npb24gb3Igbm90Lg0KDQpUaGUgU1JBVCBsb29rcyByZWFzb25h
YmxlIChpbiBmYWN0LCBmYXIgYmV0dGVyIHRoYW4gbW9zdCBJJ3ZlIHNlZW4pLsKgDQpHaXZlbiBu
byBsZWdpdGltYXRlIHJlcXVpcmVtZW50IGZvciBhbGlnbmVkIG1lbW9yeSB0aGF0IEknbSBhd2Fy
ZSBvZiwgSQ0KdGhpbmsgWGVuJ3MgYmVoYXZpb3VyIGhlcmUgaXMgYnVnZ3kgYW5kIHdhbnRzIHJl
c29sdmluZy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 21:25:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 21:25:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415055.659533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSwQ-0000fy-6m; Mon, 03 Oct 2022 21:25:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415055.659533; Mon, 03 Oct 2022 21:25:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSwQ-0000fr-34; Mon, 03 Oct 2022 21:25:34 +0000
Received: by outflank-mailman (input) for mailman id 415055;
 Mon, 03 Oct 2022 21:25:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofSwO-0000ff-4u; Mon, 03 Oct 2022 21:25:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofSwO-0006mV-37; Mon, 03 Oct 2022 21:25:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofSwN-0002SI-NB; Mon, 03 Oct 2022 21:25:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofSwN-0000Id-Mn; Mon, 03 Oct 2022 21:25:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LFhvTYvb1yyEUxOBsnII7uMDJBOM3J4cWxq7H0uJYx8=; b=03DTfo+yqdBIJ0i8Mm74K5lNai
	BEXN9qU6ILHTxYRhM2s7mpLjiC03ss0V7j4WgTxe6/Qq1zElVTdK8VBGuqoAIQMislnUcyU8roS0E
	m8xJ2OzdZ13hEq3JWEAVTRcj1Y1CqPGmFuljypiuDWjSPXAAxNOX7ZfUxCX4zNY5+uZg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173406-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173406: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=12973359d02d59c0f856b1c1dd6d0ad2f85cdab9
X-Osstest-Versions-That:
    ovmf=f01d3ee12caf5eae4ece4fc5b85c57c56fb06cc0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 03 Oct 2022 21:25:31 +0000

flight 173406 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173406/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 12973359d02d59c0f856b1c1dd6d0ad2f85cdab9
baseline version:
 ovmf                 f01d3ee12caf5eae4ece4fc5b85c57c56fb06cc0

Last test of basis   173399  2022-10-02 05:41:55 Z    1 days
Testing same since   173406  2022-10-03 18:40:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Michael Kubacki <michael.kubacki@microsoft.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f01d3ee12c..12973359d0  12973359d02d59c0f856b1c1dd6d0ad2f85cdab9 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 21:28:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 21:28:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415066.659544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSzY-0001Jp-Li; Mon, 03 Oct 2022 21:28:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415066.659544; Mon, 03 Oct 2022 21:28:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofSzY-0001Ji-Ir; Mon, 03 Oct 2022 21:28:48 +0000
Received: by outflank-mailman (input) for mailman id 415066;
 Mon, 03 Oct 2022 21:28:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=bweH=2E=vmware.com=namit@srs-se1.protection.inumbo.net>)
 id 1ofSzW-0001Jb-Hr
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 21:28:46 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-eastusazlp170110004.outbound.protection.outlook.com
 [2a01:111:f403:c100::4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b066462-4362-11ed-964a-05401a9f4f97;
 Mon, 03 Oct 2022 23:28:44 +0200 (CEST)
Received: from BY3PR05MB8531.namprd05.prod.outlook.com (2603:10b6:a03:3ce::6)
 by DM6PR05MB5098.namprd05.prod.outlook.com (2603:10b6:5:75::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.7; Mon, 3 Oct
 2022 21:28:40 +0000
Received: from BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6]) by BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6%7]) with mapi id 15.20.5709.008; Mon, 3 Oct 2022
 21:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b066462-4362-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TStowMQnvKQ0EB/QqIYKa6JYYaWMCCNXeX8X6wU4ZcaXq1XS1wLjSrgrh8ystH22teajwo7u91348AUdTvwSO0c2hIUk0dEVfnp0Rnf0QT+oXd5OzJ+cx1AbECNUCDxL5cUn9GDUb6GK2JT/hdzJMQrDtJ0rs2ZQzV3cVTJINS2RhrWe2bgpjuxqZLSmAp7s9uXfZPD7EPhsXVKdrH1odIWL0yLDzjaKF2XmdvPmzsjUerwTmxVq1YDt8VaZYvLT4JYG4S8dqMOIHonndUia4FYLbdxAYnH/k9R6xYmJgYwe4gd1b56+HFe1rZQlP93gMeNlrMmkd9KLeQVKShlkCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zw9fEnOoZeFAV82VlAHROfs2DhT1mAznnEugB9t75Rc=;
 b=SMtkNkrmfq9w6qVsf8B+F3oGVpl9Ui8pL+Zu6Opavv50m6iaRQCLYsBvn6bQtHJJhkVqVOIDtgJkrmv3Mky5iL1KBSpxvoaQilFiMcxzSKPSTFvPW9Gc2kiTUz4YqerCAM8NI0Htq26Bn5bVKs1IJ83ROSEE5fyBZrX4h8lbS7TJWQbrYeV3wjnNVOmpuOjPN3Bwmfa2iFl2G3xmy/iQeFfFRYfqKt69SRPpgdv7EnxFX0rl+UnpyjvyzEbBldov6IFIflRwJ8wd8C0N1ucFNbg/pZjtlrAr7wZDPDHMO1X6g8UysGVTVuSCg5zBK+gycDVUpeDQtkeMdDlC4A0IxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com;
 dkim=pass header.d=vmware.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Zw9fEnOoZeFAV82VlAHROfs2DhT1mAznnEugB9t75Rc=;
 b=CiVfhXyjNh0mg3nkJPsrTJ5fUgQTtweRQrEGZLu/+B8Cn2guuGolXcELjLIx5qFSlIzrx5GOhZyHicJifSv7maovlP2cg4OpYJDPd9rvNOrlDUJc5MjuP8IRCJWdvHssVoVgnbEdEOXBt1+05byZZVVNrkVbpzSlaWWt0ZJd9hY=
From: Nadav Amit <namit@vmware.com>
To: "H. Peter Anvin" <hpa@zytor.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>, Alexander Graf <graf@amazon.com>,
	Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, Srivatsa Bhat
	<srivatsab@vmware.com>, "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
	Alexey Makhalov <amakhalov@vmware.com>, Vasavi Sirnapalli
	<vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
	<er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
	<jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "acrn-dev@lists.projectacrn.org"
	<acrn-dev@lists.projectacrn.org>, "helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Index:
 AQHYx28G+J2WSwxm3kmFzqoOhSDYUK3dXFQAgBj77YCABouGgIAAKhGAgAA7TgCAAAYigA==
Date: Mon, 3 Oct 2022 21:28:40 +0000
Message-ID: <AD04C0EF-E3E0-4DE2-A812-B05382D6F7C2@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
 <42CFC548-F8FE-4BD9-89AB-198B2B3F1091@zytor.com>
In-Reply-To: <42CFC548-F8FE-4BD9-89AB-198B2B3F1091@zytor.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vmware.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BY3PR05MB8531:EE_|DM6PR05MB5098:EE_
x-ms-office365-filtering-correlation-id: 72cd9929-8a82-4b42-8be7-08daa5863d7a
x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 tnFanJPohSoePytddyFCICLAU5UCXtmRioLvACI55Lor7zciBPZ9/1NdW+XWDO7RHDh3qnYRn0RYr8QS3xUXOaDwjYI9pDeM/rBMNNl4ZeJ9A+jrSil8I4aMYuw6iran/lL/9tvHThmPf/qSrklTIf6iuOfHSK9p5AeEKMXICgDfSyx3wBualqXqAXuRfjTU1xpJQAMCT2rfaxKewhz87JzLyYazvaAIybB0Gdqa6MxCsOnNhCvjT7aI86zjbPJTYrFd80Trb7vliWXSV5r8OsBye7piAJcrbFEvfhuUUC15EstMTrtY/rubTpeHzZrpRMDd+7W2rIogl67ZuzpKO0xvcPllUW/6UhdQIi533FJ0whRR1XRyhBihnVftZHIlpBB7vb15EYIt668N3E/wBDzgJFPta7HpJHai09JhhUEQ43HtBExbGrJhHLCk8x8wtDpflr+89VA6PiBMn7XHEYveEgZICm7d3ebtpIjCsoIxRJPnmVBRStgKgcBfuzUaNuokOBZN64d2HfHZqvogZiRppe63PQSLAbxPFyLYOMn5cG3DzDe7uDgqAo34CoHMlkm+ExknubRx1NUptdM6CzYozLG3CyK/KSrZ2ehGx702jRoHfSOC3YvwsI/AVQzgIKRvRxUOAj3OsnE4ZuVHdR7PqKhNnqwLozsSrmdr8KgWwlek3wVF+fFJ7ri1FBwqibp+4sdlz1cjUw40QZnusZ/+0lZu22TRznok/UtlnWWeYvh3hld3op4InwCS7PDudYYT3MunSmprSDaszO4uUKWNt+bjp/gHTh8xJmNk3mwRKs9Ei/fXTC9T8paFQtNhI23LKa7y8AHut4wXmgAgG8o/jN4SUdYpBYunjLVN8eA=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR05MB8531.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199015)(38100700002)(122000001)(33656002)(38070700005)(36756003)(86362001)(6506007)(71200400001)(41300700001)(26005)(5660300002)(4326008)(8676002)(6512007)(53546011)(8936002)(64756008)(7416002)(6916009)(316002)(66556008)(66476007)(76116006)(54906003)(66946007)(66446008)(478600001)(83380400001)(6486002)(2906002)(186003)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?N0FQZ3VJeDBnaHVWV0MwTUlFZ3BGUHRJcUdGTHNpQ3U1eE5kQjQ0a1pyMEcz?=
 =?utf-8?B?SElTNWZTQW9xdzBpWG0zVS9TYUpXTlZCRWFaaU54c2orOTRyOStTUE5ZSkw3?=
 =?utf-8?B?NmY5ZklyL0E5MG4wWGxuMmlIMDhSSGNyQmRjV2NVWnhpaXB4ZVN2RGhhWmtm?=
 =?utf-8?B?OFZha3hzbkZFeUpFb0JnVXBVSS9XdFp1eGtGWEVWNFZxWnNXU1hQWFpFY1Qx?=
 =?utf-8?B?VEU3ZytkdGZSbnJnN2x0SFhtS1pvYnNxcnVnS3dKcHBMUjJLWktlRmszN3J6?=
 =?utf-8?B?Ty9IeUtvWC9tanBrdHZDSW9KUmg2Y2FQYThxRytYN1FweWZzUk9YTjR2VVlx?=
 =?utf-8?B?WjF6cmNTS0x0Wk9KNFQ4QXZjTzdWek9HQ3pBODZkZG1nMmNWK3dmc3hIRENq?=
 =?utf-8?B?alJMZ1JsNXBmempzWTFhVldvdklxR3Vhd1RyTE0wdVRaZUpDWU5Xa1RBTmxW?=
 =?utf-8?B?V3NrQStsNERwdmJKdGNKSFdmaWw0QW03T0NyVlkvblpCQzNPR1Z4THBrSlVo?=
 =?utf-8?B?ZXJVamloR29VTzlNRVlBTG1jZGlrK2NuODJsRUorbGVUOGx4NW04bkNKQXNR?=
 =?utf-8?B?U1RPS1pTWXB2RVNUbkVST2RZVkpYQW5WLzNLYTZQZzBJMnQ3RHpkcFloZmJV?=
 =?utf-8?B?c0E2alpsell3WWxJMG5nU1NGbTNLZ3g4bVRBVkxDWWY2RkRNaVY3MUpabmNT?=
 =?utf-8?B?R3lTZ3NRM1MrMjFvaEVVcXRiN3gwVUpsa0sxWGtyRHEwK3U3MDJyR1hwUTJI?=
 =?utf-8?B?QkxLb1ozb2NtY2RRWEtLeEViNHdKTjhXWC9XYjNXa2w0NU5hWmJqNHdnWEdE?=
 =?utf-8?B?YmkrNXBuRVZON1hqeENrbnkzbEFqb3RuY0NENGVJNEZMS09BNTRldk1GeDdP?=
 =?utf-8?B?dWp3M3ZwdUphMDEydVZlQlZIVnRydWJ5VmdvL3VuWFB2cHBTNWZZcDlMb0Fw?=
 =?utf-8?B?VS96UTV6T0dXbTlwc3Jua0VhTlNMTzZka0VHTnVPb0tYMjVPNlFMMTJkWklO?=
 =?utf-8?B?ek1zdmRmZVJsN1VrQ08rRGhPOE1UNG1FUytET2dtYk9TTk5rZTFzQU1SUE5w?=
 =?utf-8?B?UlVGN0VxeFhYOSsyejVOdUNvcnJSc0UzbDdzVEJOYjJ4R3pPaDR1blIrdzZI?=
 =?utf-8?B?MmlOM3pBa1RYckt4bzY0KzF0a3o2UVIzT0hQRDFvdzFuVGF3Sk9iWW1QR01N?=
 =?utf-8?B?WnIvdVhkR1NYcFl0RHFLZEMrTGs2MW9JLytscWtIdmR0ZnhvRTdRcWtHYm5Q?=
 =?utf-8?B?Z3BjL2FvNkxNOHpQZTYwaFRmM0tveW4zT0Q4aU5VN2VWNm4rRzN4WUVBaHFa?=
 =?utf-8?B?VnBYOW81akpFZzZBK3J4WERjcnhqbGQ1aXFlTVVCU2hob2tzbHNWVXhXb094?=
 =?utf-8?B?NlVTV2VYQkErcWxaYmNsQ0lSSWVJNkZPdTNqTk9EOVgreEpuQXZzUlhLYy81?=
 =?utf-8?B?OEp1UTlKZUZCU0FOOVVHOEpRQnVYZm1mV29hOHhXQk9haHlEN2tTOEtZRnZB?=
 =?utf-8?B?SHYxMlptemJFclUwb3M2ZzIrTkVvc0FlVlUwekdRS3k3Q3JUZjdqYlZiMTdK?=
 =?utf-8?B?ZTJEakkzelNoem1wcXBDbVMxcnUvRGhOT081YzBCd1ZpYm40VDE3UUVmaHJi?=
 =?utf-8?B?SWRnTlNhRm9XRzdrUzVGUDJvWDNiUUdKV0pMSEF0aVNYbzg5L0o2RGZxdE0x?=
 =?utf-8?B?dkVZN25aOFhpSitXK2d4dWJOVGkrSkNFN01HUnRsbi8zOUdWRCtSWUlvQTVB?=
 =?utf-8?B?dXVrRHFjSjVpckYzQ1BaWU5jcXFvRlhVelhBT3c0V0hGSXA1WG5haDRiN3c0?=
 =?utf-8?B?SUI3WkVIU2FnZXJXNHZ2UVJBM0hBbFJjeTJyTU40cFlqMDVQVkpHK2c1VXor?=
 =?utf-8?B?OUlZenE2Yytlb0pPZGxiMDJvcTgxQVpSemVLQzJiNXFUUUViK3R2ZWt5ZWE4?=
 =?utf-8?B?YUlnTE1KNnR0NUMrWjFDckcvYkU0WTRpRXRZWHE2M0VneHUwU1dIZ2RCaTBK?=
 =?utf-8?B?SVo5OG9GR2lBSXZHTngvVVJkWHZOQTdscWtERU5HcUEyZVdzUnl3V3UyNmUy?=
 =?utf-8?B?SXllWmlpRVFkUWlqVHJqKzBZcCsxMW5JYmluS1ZJQ3haV1pnU1Q2K01jTFNH?=
 =?utf-8?Q?bWfe7MwPlORs4W3hise5UaANb?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <10DBB0F4E3015E4FADD93889218F2547@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72cd9929-8a82-4b42-8be7-08daa5863d7a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 21:28:40.1676
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: v8YAGeIDx3nMpzt8RA+oD/cKtQXqSKyjJ7koJdre6pIQTblAHZgmuE5rpBGkhTzYRTO5VpWnIx7pTk5AbBwRIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB5098

T24gT2N0IDMsIDIwMjIsIGF0IDI6MDYgUE0sIEguIFBldGVyIEFudmluIDxocGFAenl0b3IuY29t
PiB3cm90ZToNCg0KPiDimqAgRXh0ZXJuYWwgRW1haWwNCj4gDQo+IE9uIE9jdG9iZXIgMywgMjAy
MiAxMDozNDoxNSBBTSBQRFQsIE5hZGF2IEFtaXQgPG5hbWl0QHZtd2FyZS5jb20+IHdyb3RlOg0K
Pj4gT24gT2N0IDMsIDIwMjIsIGF0IDg6MDMgQU0sIFZpdGFseSBLdXpuZXRzb3YgPHZrdXpuZXRz
QHJlZGhhdC5jb20+IHdyb3RlOg0KPj4gDQo+Pj4gTm90IG15IGJ1dCByYXRoZXIgUENJIG1haW50
YWluZXIncyBjYWxsIGJ1dCBJTUhPIGRyb3BwaW5nICdjb25zdCcgaXMNCj4+PiBiZXR0ZXIsIGlu
dHJvZHVjaW5nIGEgbmV3IGdsb2JhbCB2YXIgaXMgb3VyICdsYXN0IHJlc29ydCcgYW5kIHNob3Vs
ZCBiZQ0KPj4+IGF2b2lkZWQgd2hlbmV2ZXIgcG9zc2libGUuIEFsdGVybmF0aXZlbHksIHlvdSBj
YW4gYWRkIGENCj4+PiByYXdfcGNpX2V4dF9vcHNfcHJlZmVycmVkKCkgZnVuY3Rpb24gY2hlY2tp
bmcgc29tZXRoaW4gd2l0aGluICdzdHJ1Y3QNCj4+PiBoeXBlcnZpc29yX3g4NicgYnV0IEknbSB1
bnN1cmUgaWYgaXQncyBiZXR0ZXIuDQo+Pj4gDQo+Pj4gQWxzbywgcGxlYXNlIGNoZWNrIEFsZXgn
IHF1ZXN0aW9uL3N1Z2dlc3Rpb24uDQo+PiANCj4+IEhlcmUgaXMgbXkgdGFrZSAoYW5kIEFqYXkg
a25vd3MgcHJvYmFibHkgbW9yZSB0aGFuIG1lKToNCj4+IA0KPj4gTG9va2luZyBicmllZmx5IG9u
IE1DRkcsIEkgZG8gbm90IHNlZSBhIGNsZWFuIHdheSBvZiB1c2luZyB0aGUgQUNQSSB0YWJsZS4N
Cj4+IFRoZSB0d28gb3B0aW9ucyBhcmUgZWl0aGVyIHRvIHVzZSBhIHJlc2VydmVkIGZpZWxkICh3
aGljaCB3aG8ga25vd3MsIG1pZ2h0DQo+PiBiZSB1c2VkIG9uZSBkYXkpIG9yIHNvbWUgT0VNIElE
LiBJIGFtIGFsc28gbm90IGZhbWlsaWFyIHdpdGgNCj4+IFBDSV9DT01NQU5ELk1FTU9SWT0wLCBz
byBBamF5IGNhbiBob3BlZnVsbHkgZ2l2ZSBzb21lIGFuc3dlciBhYm91dCB0aGF0Lg0KPj4gDQo+
PiBBbnlob3csIEkgdW5kZXJzdGFuZCAoYWx0aG91Z2ggbm90IHJlbGF0ZSkgdG8gdGhlIG9iamVj
dGlvbiBmb3IgYSBuZXcgZ2xvYmFsDQo+PiB2YXJpYWJsZS4gSG93IGFib3V0IGV4cGxpY2l0bHkg
Y2FsbGluZyB0aGlzIGhhcmR3YXJlIGJ1ZyBhIOKAnGJ1Z+KAnSBhbmQgdXNpbmcNCj4+IHRoZSBw
cm9wZXIgaW5mcmFzdHJ1Y3R1cmU/IENhbGxpbmcgaXQgZXhwbGljaXRseSBhIGJ1ZyBtYXkgZXZl
biBwdXNoIHdob2V2ZXINCj4+IGNhbiB0byByZXNvbHZlIGl0Lg0KPj4gDQo+PiBJT1csIGhvdyBh
Ym91dCBkb2luZyBzb21ldGhpbmcgYWxvbmcgdGhlIGxpbmVzIG9mIChub3QgdGVzdGVkKToNCj4+
IA0KPj4gDQo+PiAtLSA+OCAtLQ0KPj4gDQo+PiBTdWJqZWN0OiBbUEFUQ0hdIHg4Ni9QQ0k6IFBy
ZWZlciBNTUlPIG92ZXIgUElPIG9uIFZNd2FyZSBoeXBlcnZpc29yDQo+PiANCj4+IC0tLQ0KPj4g
YXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZXMuaCB8IDEgKw0KPj4gYXJjaC94ODYva2Vy
bmVsL2NwdS9jb21tb24uYyAgICAgICB8IDIgKysNCj4+IGFyY2gveDg2L2tlcm5lbC9jcHUvdm13
YXJlLmMgICAgICAgfCAyICsrDQo+PiBhcmNoL3g4Ni9wY2kvY29tbW9uLmMgICAgICAgICAgICAg
IHwgNiArKysrLS0NCj4+IDQgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAyIGRlbGV0
aW9ucygtKQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVh
dHVyZXMuaCBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmVzLmgNCj4+IGluZGV4IGVm
NDc3NWM2ZGIwMS4uMjE2YjZmMzU3YjZkIDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYvaW5jbHVk
ZS9hc20vY3B1ZmVhdHVyZXMuaA0KPj4gKysrIGIvYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVh
dHVyZXMuaA0KPj4gQEAgLTQ2MCw1ICs0NjAsNiBAQA0KPj4gI2RlZmluZSBYODZfQlVHX01NSU9f
VU5LTk9XTiAgICAgICAgICBYODZfQlVHKDI2KSAvKiBDUFUgaXMgdG9vIG9sZCBhbmQgaXRzIE1N
SU8gU3RhbGUgRGF0YSBzdGF0dXMgaXMgdW5rbm93biAqLw0KPj4gI2RlZmluZSBYODZfQlVHX1JF
VEJMRUVEICAgICAgICAgICAgICBYODZfQlVHKDI3KSAvKiBDUFUgaXMgYWZmZWN0ZWQgYnkgUkVU
QmxlZWQgKi8NCj4+ICNkZWZpbmUgWDg2X0JVR19FSUJSU19QQlJTQiAgICAgICAgICAgWDg2X0JV
RygyOCkgLyogRUlCUlMgaXMgdnVsbmVyYWJsZSB0byBQb3N0IEJhcnJpZXIgUlNCIFByZWRpY3Rp
b25zICovDQo+PiArI2RlZmluZSBYODZfQlVHX0VDQU1fTU1JTyAgICAgICAgICAgICBYODZfQlVH
KDI5KSAvKiBFQ0FNIE1NSU8gaXMgYnVnZ3kgYW5kIFBJTyBpcyBwcmVmZXJhYmxlICovDQo+PiAN
Cj4+ICNlbmRpZiAvKiBfQVNNX1g4Nl9DUFVGRUFUVVJFU19IICovDQo+PiBkaWZmIC0tZ2l0IGEv
YXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvY29tbW9u
LmMNCj4+IGluZGV4IDNlNTA4ZjIzOTA5OC4uYzk0MTc1ZmEzMDRiIDEwMDY0NA0KPj4gLS0tIGEv
YXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYw0KPj4gKysrIGIvYXJjaC94ODYva2VybmVsL2Nw
dS9jb21tb24uYw0KPj4gQEAgLTEyOTksNiArMTI5OSw4IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBj
cHVfc2V0X2J1Z19iaXRzKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykNCj4+IHsNCj4+ICAgICAgdTY0
IGlhMzJfY2FwID0geDg2X3JlYWRfYXJjaF9jYXBfbXNyKCk7DQo+PiANCj4+ICsgICAgICBzZXR1
cF9mb3JjZV9jcHVfYnVnKFg4Nl9CVUdfRUNBTV9NTUlPKTsNCj4+ICsNCj4+ICAgICAgLyogU2V0
IElUTEJfTVVMVElISVQgYnVnIGlmIGNwdSBpcyBub3QgaW4gdGhlIHdoaXRlbGlzdCBhbmQgbm90
IG1pdGlnYXRlZCAqLw0KPj4gICAgICBpZiAoIWNwdV9tYXRjaGVzKGNwdV92dWxuX3doaXRlbGlz
dCwgTk9fSVRMQl9NVUxUSUhJVCkgJiYNCj4+ICAgICAgICAgICEoaWEzMl9jYXAgJiBBUkNIX0NB
UF9QU0NIQU5HRV9NQ19OTykpDQo+PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYva2VybmVsL2NwdS92
bXdhcmUuYyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvdm13YXJlLmMNCj4+IGluZGV4IDAyMDM5ZWMz
NTk3ZC4uODkwMzc3NjI4NGE2IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYva2VybmVsL2NwdS92
bXdhcmUuYw0KPj4gKysrIGIvYXJjaC94ODYva2VybmVsL2NwdS92bXdhcmUuYw0KPj4gQEAgLTM4
NSw2ICszODUsOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQgdm13YXJlX3NldF9jYXBhYmlsaXRpZXMo
dm9pZCkNCj4+ICAgICAgICAgICAgICBzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1ZN
Q0FMTCk7DQo+PiAgICAgIGVsc2UgaWYgKHZtd2FyZV9oeXBlcmNhbGxfbW9kZSA9PSBDUFVJRF9W
TVdBUkVfRkVBVFVSRVNfRUNYX1ZNTUNBTEwpDQo+PiAgICAgICAgICAgICAgc2V0dXBfZm9yY2Vf
Y3B1X2NhcChYODZfRkVBVFVSRV9WTVdfVk1NQ0FMTCk7DQo+PiArDQo+PiArICAgICAgc2V0dXBf
Y2xlYXJfY3B1X2NhcChYODZfQlVHX0VDQU1fTU1JTyk7DQo+PiB9DQo+PiANCj4+IHN0YXRpYyB2
b2lkIF9faW5pdCB2bXdhcmVfcGxhdGZvcm1fc2V0dXAodm9pZCkNCj4+IGRpZmYgLS1naXQgYS9h
cmNoL3g4Ni9wY2kvY29tbW9uLmMgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMNCj4+IGluZGV4IGRk
Yjc5ODYwMzIwMS4uYmM4MWNmNGMxMDE0IDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYvcGNpL2Nv
bW1vbi5jDQo+PiArKysgYi9hcmNoL3g4Ni9wY2kvY29tbW9uLmMNCj4+IEBAIC00MCw3ICs0MCw4
IEBAIGNvbnN0IHN0cnVjdCBwY2lfcmF3X29wcyAqX19yZWFkX21vc3RseSByYXdfcGNpX2V4dF9v
cHM7DQo+PiBpbnQgcmF3X3BjaV9yZWFkKHVuc2lnbmVkIGludCBkb21haW4sIHVuc2lnbmVkIGlu
dCBidXMsIHVuc2lnbmVkIGludCBkZXZmbiwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGludCByZWcsIGludCBsZW4sIHUzMiAqdmFsKQ0KPj4gew0KPj4g
LSAgICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcgPCAyNTYgJiYgcmF3X3BjaV9vcHMpDQo+PiAr
ICAgICAgaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNpX29wcyAmJg0KPj4g
KyAgICAgICAgICAoYm9vdF9jcHVfaGFzX2J1ZyhYODZfQlVHX0VDQU1fTU1JTykgfHwgIXJhd19w
Y2lfZXh0X29wcykpDQo+PiAgICAgICAgICAgICAgcmV0dXJuIHJhd19wY2lfb3BzLT5yZWFkKGRv
bWFpbiwgYnVzLCBkZXZmbiwgcmVnLCBsZW4sIHZhbCk7DQo+PiAgICAgIGlmIChyYXdfcGNpX2V4
dF9vcHMpDQo+PiAgICAgICAgICAgICAgcmV0dXJuIHJhd19wY2lfZXh0X29wcy0+cmVhZChkb21h
aW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVuLCB2YWwpOw0KPj4gQEAgLTUwLDcgKzUxLDggQEAgaW50
IHJhd19wY2lfcmVhZCh1bnNpZ25lZCBpbnQgZG9tYWluLCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNp
Z25lZCBpbnQgZGV2Zm4sDQo+PiBpbnQgcmF3X3BjaV93cml0ZSh1bnNpZ25lZCBpbnQgZG9tYWlu
LCB1bnNpZ25lZCBpbnQgYnVzLCB1bnNpZ25lZCBpbnQgZGV2Zm4sDQo+PiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgcmVnLCBpbnQgbGVuLCB1MzIgdmFs
KQ0KPj4gew0KPj4gLSAgICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcgPCAyNTYgJiYgcmF3X3Bj
aV9vcHMpDQo+PiArICAgICAgaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNp
X29wcyAmJg0KPj4gKyAgICAgICAgICAoYm9vdF9jcHVfaGFzX2J1ZyhYODZfQlVHX0VDQU1fTU1J
TykgfHwgIXJhd19wY2lfZXh0X29wcykpDQo+PiAgICAgICAgICAgICAgcmV0dXJuIHJhd19wY2lf
b3BzLT53cml0ZShkb21haW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVuLCB2YWwpOw0KPj4gICAgICBp
ZiAocmF3X3BjaV9leHRfb3BzKQ0KPj4gICAgICAgICAgICAgIHJldHVybiByYXdfcGNpX2V4dF9v
cHMtPndyaXRlKGRvbWFpbiwgYnVzLCBkZXZmbiwgcmVnLCBsZW4sIHZhbCk7DQo+IA0KPiBBbHNv
Li4uIGFueSByZWFzb24gd2UgY2FuJ3QganVzdCBzZXQgcmF3X3BjaV9vcHMgPT0gcmF3X2V4dF9w
Y2lfb3BzIGZvciB0aGUgY2FzZSB3aGVuIHRoZSBsYXR0ZXIgaXMgcHJlZmVycmVkLCBhbmQgZGlz
cGVuc2Ugd2l0aCB0aGUgY29uZGl0aW9uYWxzIGluIHRoZSB1c2UgcGF0aD8gU2ltaWxhcmx5LCBy
YXdfZXh0X3BjaV9vcHMgY291bGQgYmUgcG9pbnRlZCB0byBlcnJvciByb3V0aW5lcyBpbnN0ZWFk
IG9mIGxlZnQgYXQgTlVMTC4NCg0KSSB1bmRlcnN0b29kIGZyb20gQWpheSB0aGF0IHRoZSBpbml0
aWFsaXphdGlvbiBvZiByYXdfZXh0X3BjaV9vcHMgY2FuIGJlDQpkb25lIGFmdGVyIHRoZSBoeXBl
cnZpc29yIGluaXRpYWxpemF0aW9uIHRha2VzIHBsYWNlLCBzbyBkb2luZyB3aGF0IGV4YWN0bHkN
CndoYXQgeW91IHByb3Bvc2VkIGJ5IGlzIG5vdCBwb3NzaWJsZS4gSXQgY2FuIHByb2JhYmx5IGJl
IHJlc29sdmVkLCBidXQgSSBkbw0Kbm90IHRoaW5rIHRoZSBlbmQgcmVzdWx0IHdvdWxkIGJlIHNp
bXBsZXIgb3IgY2xlYW5lci4gSSB0aGluayB0aGF0IHRoZSDigJxidWfigJ0NCnNvbHV0aW9uIHJl
YWxseSBjb252ZXlzIHRoZSBiZWhhdmlvci4NCg0KSUlVQyBwZXJmb3JtYW5jZSB3b3VsZCBub3Qg
YmUgbm90aWNlYWJsZSBhZmZlY3RlZCBieSAyIG1vcmUgY29uZGl0aW9uYWwNCmJyYW5jaGVzLg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 23:27:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 23:27:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415073.659554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofUqH-0004E8-Bf; Mon, 03 Oct 2022 23:27:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415073.659554; Mon, 03 Oct 2022 23:27:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofUqH-0004E1-8P; Mon, 03 Oct 2022 23:27:21 +0000
Received: by outflank-mailman (input) for mailman id 415073;
 Mon, 03 Oct 2022 23:27:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KKGU=2E=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ofUqF-0004Dv-Gh
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 23:27:19 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb683119-4372-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 01:27:17 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id B6983B8167B;
 Mon,  3 Oct 2022 23:27:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86C24C433D6;
 Mon,  3 Oct 2022 23:27:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb683119-4372-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664839635;
	bh=n1G1gKmijZk8mLRTr/oFoNUHjS+2c8WH/ZowSIQldAE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DxT5XRQ0+JH4SpAzRDJlvB7LwsQEudN+zn41Y5N+M5KSlwMxt9+Ro4+XH8r5zl3H7
	 69pfVCGIgSsWl/yiIo1c2Fuyp0Zk7KZW/esRQoP+DNLQM63fL7AKfVM0JEyfEetbix
	 XdTQA+l3/k4EKMHXxIuP+043DofwgDujBYGm78tfu0MQdoV7uwdUdtDz3L8HPYv0fy
	 Qfthbr/BVSG0DXj7G6oeaI5BVm5Ea+2o3QLtdCLnGCA1lUWtPt6ozEJnVMnW8mcyJ7
	 B9HHrek4LMhHEDDE5HsepxAirc2Jp37sAnK7z/ngGh10GUo9QFV9Z4CMy32lrEKX0X
	 m3OVV5OEHA8pg==
Date: Mon, 3 Oct 2022 16:27:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: sarath chandu <ksc2093@gmail.com>
cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, 
    Artem_Mygaiev@epam.com, Bertrand.Marquis@arm.com
Subject: Re:Xen compatability and performance for imx8qm target with Andriod
 Auto as Guest Os
In-Reply-To: <CAFWs62=ZPLF6RTQawKH=5ofEtBsXf-hmUq+TPEX=b2Uwj1P=0g@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210031624531.3073309@ubuntu-linux-20-04-desktop>
References: <CAFWs62=ZPLF6RTQawKH=5ofEtBsXf-hmUq+TPEX=b2Uwj1P=0g@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-2057666157-1664839503=:3073309"
Content-ID: <alpine.DEB.2.22.394.2210031625090.3073309@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2057666157-1664839503=:3073309
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210031625091.3073309@ubuntu-linux-20-04-desktop>

Hi Sarath,

I am CCing Artem who might have more info on how to get Android to boot
on Xen.

>From a Linux kernel perspective, you only need to enable CONFIG_XEN and
CONFIG_HVC_XEN in the kernel config and it should be able to boot.

Cheers,

Stefano


On Mon, 3 Oct 2022, sarath chandu wrote:
> Hi Team,
> I am trying to port xen hypervisor on i.MX8QM EVK. Planning to port xen-image as DOM0,
> Automotive Grade Linux as guest1 & Automotive Android as guest2.
> Can you please guide me with the steps for porting android as a guest?
> What are the drivers & packages that need to be included to achieve this?
> Looking forward to hearing from you.
--8323329-2057666157-1664839503=:3073309--


From xen-devel-bounces@lists.xenproject.org Mon Oct 03 23:52:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 03 Oct 2022 23:52:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415082.659566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofVEI-0007Qi-Bg; Mon, 03 Oct 2022 23:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415082.659566; Mon, 03 Oct 2022 23:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofVEI-0007Qb-8n; Mon, 03 Oct 2022 23:52:10 +0000
Received: by outflank-mailman (input) for mailman id 415082;
 Mon, 03 Oct 2022 23:52:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=UGPN=2E=zytor.com=hpa@srs-se1.protection.inumbo.net>)
 id 1ofVEF-0007QV-UA
 for xen-devel@lists.xenproject.org; Mon, 03 Oct 2022 23:52:08 +0000
Received: from mail.zytor.com (unknown [2607:7c80:54:3::138])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 619a3986-4376-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 01:52:05 +0200 (CEST)
Received: from [127.0.0.1] ([73.223.250.219]) (authenticated bits=0)
 by mail.zytor.com (8.17.1/8.17.1) with ESMTPSA id 293NpL7D3165639
 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO);
 Mon, 3 Oct 2022 16:51:22 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 619a3986-4376-11ed-964a-05401a9f4f97
DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 293NpL7D3165639
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com;
	s=2022090501; t=1664841085;
	bh=D7TBwA2zb1cncUrYgDx3mpO7N7pu2xIjAZUrkR2oYU0=;
	h=Date:From:To:CC:Subject:In-Reply-To:References:From;
	b=ri09LYJhWw+XUVmunFECVvFBv2cbu17I4CHiPPoY780m03moh1Zcs4+xKaJFcQS18
	 wwd7/ACWI8tEuYciN/wJADJfBOBllszaOMmKEqA52D3vRy3vGtpyx0WGgKbUdq4DOT
	 QQjx8OSyiQF0mItLegj0Kpp8zJPUhOXhCzhSQNrOpNiyLbO0KNRz1ch4kxn2AR8RxT
	 ay9OajbDqR5dKtBn+Olm9N0LZGcRWSxaUYjy05CaH7nB8ek2Hf1FNFwcYgWHG6Cz9B
	 DiX35oOWAp7iIPBzOR2FRCcmM5zfzs2t4x4evs4Q/7nBU8MLSSqmTjuF0y2TyRXjsw
	 k+cj4162/YAGQ==
Date: Mon, 03 Oct 2022 16:51:19 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
To: Nadav Amit <namit@vmware.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>, Alexander Graf <graf@amazon.com>,
        Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        Srivatsa Bhat <srivatsab@vmware.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Vasavi Sirnapalli <vsirnapalli@vmware.com>,
        "er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "jailhouse-dev@googlegroups.com" <jailhouse-dev@googlegroups.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "acrn-dev@lists.projectacrn.org" <acrn-dev@lists.projectacrn.org>,
        "helgaas@kernel.org" <helgaas@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
User-Agent: K-9 Mail for Android
In-Reply-To: <AD04C0EF-E3E0-4DE2-A812-B05382D6F7C2@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com> <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com> <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com> <42CFC548-F8FE-4BD9-89AB-198B2B3F1091@zytor.com> <AD04C0EF-E3E0-4DE2-A812-B05382D6F7C2@vmware.com>
Message-ID: <8859A371-E810-4720-AAFD-06603816AA53@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On October 3, 2022 2:28:40 PM PDT, Nadav Amit <namit@vmware=2Ecom> wrote:
>On Oct 3, 2022, at 2:06 PM, H=2E Peter Anvin <hpa@zytor=2Ecom> wrote:
>
>> =E2=9A=A0 External Email
>>=20
>> On October 3, 2022 10:34:15 AM PDT, Nadav Amit <namit@vmware=2Ecom> wro=
te:
>>> On Oct 3, 2022, at 8:03 AM, Vitaly Kuznetsov <vkuznets@redhat=2Ecom> w=
rote:
>>>=20
>>>> Not my but rather PCI maintainer's call but IMHO dropping 'const' is
>>>> better, introducing a new global var is our 'last resort' and should =
be
>>>> avoided whenever possible=2E Alternatively, you can add a
>>>> raw_pci_ext_ops_preferred() function checking somethin within 'struct
>>>> hypervisor_x86' but I'm unsure if it's better=2E
>>>>=20
>>>> Also, please check Alex' question/suggestion=2E
>>>=20
>>> Here is my take (and Ajay knows probably more than me):
>>>=20
>>> Looking briefly on MCFG, I do not see a clean way of using the ACPI ta=
ble=2E
>>> The two options are either to use a reserved field (which who knows, m=
ight
>>> be used one day) or some OEM ID=2E I am also not familiar with
>>> PCI_COMMAND=2EMEMORY=3D0, so Ajay can hopefully give some answer about=
 that=2E
>>>=20
>>> Anyhow, I understand (although not relate) to the objection for a new =
global
>>> variable=2E How about explicitly calling this hardware bug a =E2=80=9C=
bug=E2=80=9D and using
>>> the proper infrastructure? Calling it explicitly a bug may even push w=
hoever
>>> can to resolve it=2E
>>>=20
>>> IOW, how about doing something along the lines of (not tested):
>>>=20
>>>=20
>>> -- >8 --
>>>=20
>>> Subject: [PATCH] x86/PCI: Prefer MMIO over PIO on VMware hypervisor
>>>=20
>>> ---
>>> arch/x86/include/asm/cpufeatures=2Eh | 1 +
>>> arch/x86/kernel/cpu/common=2Ec       | 2 ++
>>> arch/x86/kernel/cpu/vmware=2Ec       | 2 ++
>>> arch/x86/pci/common=2Ec              | 6 ++++--
>>> 4 files changed, 9 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/arch/x86/include/asm/cpufeatures=2Eh b/arch/x86/include/a=
sm/cpufeatures=2Eh
>>> index ef4775c6db01=2E=2E216b6f357b6d 100644
>>> --- a/arch/x86/include/asm/cpufeatures=2Eh
>>> +++ b/arch/x86/include/asm/cpufeatures=2Eh
>>> @@ -460,5 +460,6 @@
>>> #define X86_BUG_MMIO_UNKNOWN          X86_BUG(26) /* CPU is too old an=
d its MMIO Stale Data status is unknown */
>>> #define X86_BUG_RETBLEED              X86_BUG(27) /* CPU is affected b=
y RETBleed */
>>> #define X86_BUG_EIBRS_PBRSB           X86_BUG(28) /* EIBRS is vulnerab=
le to Post Barrier RSB Predictions */
>>> +#define X86_BUG_ECAM_MMIO             X86_BUG(29) /* ECAM MMIO is bug=
gy and PIO is preferable */
>>>=20
>>> #endif /* _ASM_X86_CPUFEATURES_H */
>>> diff --git a/arch/x86/kernel/cpu/common=2Ec b/arch/x86/kernel/cpu/comm=
on=2Ec
>>> index 3e508f239098=2E=2Ec94175fa304b 100644
>>> --- a/arch/x86/kernel/cpu/common=2Ec
>>> +++ b/arch/x86/kernel/cpu/common=2Ec
>>> @@ -1299,6 +1299,8 @@ static void __init cpu_set_bug_bits(struct cpuin=
fo_x86 *c)
>>> {
>>>      u64 ia32_cap =3D x86_read_arch_cap_msr();
>>>=20
>>> +      setup_force_cpu_bug(X86_BUG_ECAM_MMIO);
>>> +
>>>      /* Set ITLB_MULTIHIT bug if cpu is not in the whitelist and not m=
itigated */
>>>      if (!cpu_matches(cpu_vuln_whitelist, NO_ITLB_MULTIHIT) &&
>>>          !(ia32_cap & ARCH_CAP_PSCHANGE_MC_NO))
>>> diff --git a/arch/x86/kernel/cpu/vmware=2Ec b/arch/x86/kernel/cpu/vmwa=
re=2Ec
>>> index 02039ec3597d=2E=2E8903776284a6 100644
>>> --- a/arch/x86/kernel/cpu/vmware=2Ec
>>> +++ b/arch/x86/kernel/cpu/vmware=2Ec
>>> @@ -385,6 +385,8 @@ static void __init vmware_set_capabilities(void)
>>>              setup_force_cpu_cap(X86_FEATURE_VMCALL);
>>>      else if (vmware_hypercall_mode =3D=3D CPUID_VMWARE_FEATURES_ECX_V=
MMCALL)
>>>              setup_force_cpu_cap(X86_FEATURE_VMW_VMMCALL);
>>> +
>>> +      setup_clear_cpu_cap(X86_BUG_ECAM_MMIO);
>>> }
>>>=20
>>> static void __init vmware_platform_setup(void)
>>> diff --git a/arch/x86/pci/common=2Ec b/arch/x86/pci/common=2Ec
>>> index ddb798603201=2E=2Ebc81cf4c1014 100644
>>> --- a/arch/x86/pci/common=2Ec
>>> +++ b/arch/x86/pci/common=2Ec
>>> @@ -40,7 +40,8 @@ const struct pci_raw_ops *__read_mostly raw_pci_ext_=
ops;
>>> int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int d=
evfn,
>>>                                              int reg, int len, u32 *va=
l)
>>> {
>>> -      if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>>> +      if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>>> +          (boot_cpu_has_bug(X86_BUG_ECAM_MMIO) || !raw_pci_ext_ops))
>>>              return raw_pci_ops->read(domain, bus, devfn, reg, len, va=
l);
>>>      if (raw_pci_ext_ops)
>>>              return raw_pci_ext_ops->read(domain, bus, devfn, reg, len=
, val);
>>> @@ -50,7 +51,8 @@ int raw_pci_read(unsigned int domain, unsigned int b=
us, unsigned int devfn,
>>> int raw_pci_write(unsigned int domain, unsigned int bus, unsigned int =
devfn,
>>>                                              int reg, int len, u32 val=
)
>>> {
>>> -      if (domain =3D=3D 0 && reg < 256 && raw_pci_ops)
>>> +      if (domain =3D=3D 0 && reg < 256 && raw_pci_ops &&
>>> +          (boot_cpu_has_bug(X86_BUG_ECAM_MMIO) || !raw_pci_ext_ops))
>>>              return raw_pci_ops->write(domain, bus, devfn, reg, len, v=
al);
>>>      if (raw_pci_ext_ops)
>>>              return raw_pci_ext_ops->write(domain, bus, devfn, reg, le=
n, val);
>>=20
>> Also=2E=2E=2E any reason we can't just set raw_pci_ops =3D=3D raw_ext_p=
ci_ops for the case when the latter is preferred, and dispense with the con=
ditionals in the use path? Similarly, raw_ext_pci_ops could be pointed to e=
rror routines instead of left at NULL=2E
>
>I understood from Ajay that the initialization of raw_ext_pci_ops can be
>done after the hypervisor initialization takes place, so doing what exact=
ly
>what you proposed by is not possible=2E It can probably be resolved, but =
I do
>not think the end result would be simpler or cleaner=2E I think that the =
=E2=80=9Cbug=E2=80=9D
>solution really conveys the behavior=2E
>
>IIUC performance would not be noticeable affected by 2 more conditional
>branches=2E
>
>

Isn't that exactly what you would want?!?


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 00:20:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 00:20:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415092.659576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofVfp-0002uH-I4; Tue, 04 Oct 2022 00:20:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415092.659576; Tue, 04 Oct 2022 00:20:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofVfp-0002uA-FH; Tue, 04 Oct 2022 00:20:37 +0000
Received: by outflank-mailman (input) for mailman id 415092;
 Tue, 04 Oct 2022 00:20:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L4OA=2F=vmware.com=namit@srs-se1.protection.inumbo.net>)
 id 1ofVfo-0002u4-07
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 00:20:36 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-eastusazon11010006.outbound.protection.outlook.com [52.101.51.6])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5be2e151-437a-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 02:20:33 +0200 (CEST)
Received: from BY3PR05MB8531.namprd05.prod.outlook.com (2603:10b6:a03:3ce::6)
 by MWHPR05MB2797.namprd05.prod.outlook.com (2603:10b6:300:60::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.8; Tue, 4 Oct
 2022 00:19:47 +0000
Received: from BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6]) by BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6%7]) with mapi id 15.20.5709.008; Tue, 4 Oct 2022
 00:19:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5be2e151-437a-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nQiZCd/Uh5bRd+4d7oXqpdQVGiBfC7DDhOKJ/yK7aN88euOb0L+8+/ZZZhkrVttgcjRXRDKwWRqH3lPO/fxwkR9EZGixPsd2SbAe0N3IIYLCmg1pCo55TU+r+mQJ9Zr0GDAexqf8ELodJM+6Q7fv48tp6i/5160NFc9cMbtZbhllS1juQyQv1fIEabLp2+xUyCVjEw4lJRghf3ZsjE7GYyC3z2ATe3R3e2r5U7au/c4XY6ifnvtDocWjJeXU6vBtGWq5Xq10uoqXpBFruTS6auz3Kvk57SuUXOUqvGGopWtGtG1Qo5F6sEjHp1QhEToNb4eznt6ij9BSJvhvfViTHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v0UkDABw6ohtJ22tdaxOAXwyPxZuELnjvmHTTEte5wQ=;
 b=QD5Q4msO1l7Wsb36AnPhMkKI2+Ll7pCrk083nLSScpqaC5zF4+YSFsJxSRRNb1bM8Z12QWAWuhuTHr7X080OIcQfYy/nvcErlWguPqqDnCc7deUEGIChZPOzZwf38xiOeDrU2sw5WubWIhDpSl8YI7sj3pgknu452n5FyNQFbVdVw91v96plYtI3E7jXqeY529S2huS+PsKGuJwwa/VLPIk3jobbIUrcIcG0grtG0q/RqcWruJQG6MQ4CzkNA0Nb9o54Mw692ixL0v4wyByhOkKZ19Hu5lIGv0JU3zN8UfEgV0/+/b42mNru9PmdenAmZzllAEFuxKb6ywose2fw8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com;
 dkim=pass header.d=vmware.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v0UkDABw6ohtJ22tdaxOAXwyPxZuELnjvmHTTEte5wQ=;
 b=VxG3iK/QXShXAm1LUbrhUbNOb+/YLgZt9QtTI4E/g1l7RSlsmwbJuorXmxPVkt+ClM5p8x0Pt26Puy9zaFBnnXcrP45OOixpAMy4A/FpLG+/ILz7jD+QjLuTYe6yU0fu48SlS94hTBrOl3S42SBIk/hDONBSvEApafk5xl9TmEs=
From: Nadav Amit <namit@vmware.com>
To: "H. Peter Anvin" <hpa@zytor.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>, Alexander Graf <graf@amazon.com>,
	Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, Srivatsa Bhat
	<srivatsab@vmware.com>, "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
	Alexey Makhalov <amakhalov@vmware.com>, Vasavi Sirnapalli
	<vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
	<er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
	<jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "acrn-dev@lists.projectacrn.org"
	<acrn-dev@lists.projectacrn.org>, "helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Index:
 AQHYx28G+J2WSwxm3kmFzqoOhSDYUK3dXFQAgBj77YCABouGgIAAKhGAgAA7TgCAAAYigIAAJ+qAgAAH8wA=
Date: Tue, 4 Oct 2022 00:19:46 +0000
Message-ID: <CD4F5AD2-AEC6-47B6-AFA0-98DCE2AE1A84@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
 <42CFC548-F8FE-4BD9-89AB-198B2B3F1091@zytor.com>
 <AD04C0EF-E3E0-4DE2-A812-B05382D6F7C2@vmware.com>
 <8859A371-E810-4720-AAFD-06603816AA53@zytor.com>
In-Reply-To: <8859A371-E810-4720-AAFD-06603816AA53@zytor.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vmware.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BY3PR05MB8531:EE_|MWHPR05MB2797:EE_
x-ms-office365-filtering-correlation-id: 86993544-9e91-40af-e4bd-08daa59e24e9
x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 7N80bXbU2EmPnlovtiK8XuGaqXR93zh9Zg48ngcf6BB3WjKehE9ucL1exMPTFrEJDw3EgmbfxTKKsc7CwjOR6b5qdPF1UsX+1wpBsj2/xedB+2AgkCVHl6yl+LWeCHwT3H4p1Q3OFOCMaDCmJI49kJf+YnwVQclaTd19IF6ceNsrZjAG1fmT+4YsJohKJvpL/MXBmL5EOCrZiOoOiwh+2XnluvrGRvWBezzz/cKHuf7eYsO6D5XyQdG1kAUHkDPbS7AJMBQhrbQFkgnlx4A3KCA9yOYE7268unahm1wphyp5jcJUUWPcFcl4WaGGLGcLracIr0ifKnTmQHwEOOdZtdLnVrWNOvOTnu6zmVW2rNe1dstbPeFvUmhz9H4v46Oh/5KH9Pt5dizLmJgy4pKW6OXD+xGvlxqiVH3FoT7UuX8ikyV5s9jOHSMR4e9Kx2FXXIR06pYTRxfaiTCE0ofCdWQjs2prEkfiGbaSJfeAbePLEgQq0CZEOmgnanWGQGVVutRrc73/ZGB1AT8yLw1+5bE71myKv2GjsmYkSfWFiGISqxB2jmXTpu/VPsQnOQM1dZACsC4kG2n5oKj40Obe8O0wBaqkPOGO9/73pqn46jjUOv28X6usFTQCvvgYQqYPT9qPq8Dqulm7iUrrK/fAymohvS73/6tzJDupQArmScpCPUAytNy6MjbB6gc0CV5ExD2FzH6gbhJzBiDOnRXfIUiTKcaY5dbl8eWHNVvCqdLhczwBgqBT5YrUVMdIHwKt2LLOwHYXR/0NvpY1daxIBP/vgLVLZh3goBIMG7bvOCI=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR05MB8531.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(451199015)(83380400001)(2616005)(186003)(38070700005)(38100700002)(122000001)(7416002)(8936002)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(5660300002)(41300700001)(2906002)(478600001)(71200400001)(26005)(6506007)(6512007)(6916009)(53546011)(54906003)(316002)(6486002)(36756003)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SUhoRUEzeGdRdy9xTi9MNXNHbEF2bEJpZjJWdmg3ZWU4QW5OdFJaK01DelRG?=
 =?utf-8?B?UTJYTTFYQmk3eldoYlpwbjhiQjVIeEhyYjl2SFluZFBFaHhueDBtck83b0xU?=
 =?utf-8?B?Y01wRG9tVVRwcGFNS2EweGJGZTZJR2graDVKeEdub1o1dHM0MXFDYTBFSTZp?=
 =?utf-8?B?cytaVHdJZnRBYmZhN2tUdDhIdlQvbllGWU1VZmZ1c282RkYrNHVpdmJDSEx6?=
 =?utf-8?B?NHlDbTZzVzR0SWhkUE9rc1BlTGo3Z1VkbFdLUXNGQlc3RG4xWVhyU3Y0Q1lS?=
 =?utf-8?B?U2RIdUtVdWNhVzRFV2hUNG9PbGd0QXgrU3NVbXdnWDhjbERhOUpxcmx0cjk2?=
 =?utf-8?B?Tmh3aDdZRExhK3htS2xCSmVHNjlNTk9wY2xaQXo5elN1bzBTSzIyK2kxN29i?=
 =?utf-8?B?dU9DUklsUE0rRFgvY3c5UlJpWkcyb2VqUURpTkMwekRXZmZ1eVVpWlFneWJF?=
 =?utf-8?B?N3hua2ZReHF3ME94VTJ0TnVCdFoxYTl4WGZWRk9QK2RwWDUwa3BmbUlSZzZs?=
 =?utf-8?B?NFdIeUlKNFZPdWZLR01YOENUWHBNNG11WW54cGoydWdpemtFbzZyR0Ruam9Y?=
 =?utf-8?B?VGV1ZnR0MVVzTG03YlFtb2FSSnNzb1MwSGNqZEJLUkNnUnVWTFpXUkR4SUVZ?=
 =?utf-8?B?eGRtK1l2cThyZ3c2MUZDNERlTXVkbUtmRHl3ajF0bHFpZ0o2N2lDODUzSVlG?=
 =?utf-8?B?cWpCeXpxa1lNVVNISTlBd2dMb040SldLT0N0L3lPWHZReHc3aDc4bW85L0VO?=
 =?utf-8?B?NkJvNnRKcmwxTGlGUHNVaEJzTm9ZajR5eWV0SWdxNXBuNG9ZZkRQK3dRam51?=
 =?utf-8?B?UWp6RGRDY1pBMnluTnNpV3cwNmVrWnphajBOWjdEK1UzRWcvZmNxRUhHZ2Nw?=
 =?utf-8?B?RjVibXdFMmw2VHRnVTNvSlpJNUNORk1QaWNaWTNvY1A1OFhmZFhUWmlaSHFL?=
 =?utf-8?B?QVNBSjNzMjFKU2hOdU5pa1pYd3phVHNoZXZ1L1IrNmtDekQ2Z2xuVDBNOVpt?=
 =?utf-8?B?cVZkRnA0TDRzUkZMLzlPNW1SY0VXWlVBaWJOREtkTEdDN1MvY1IzQ0Eza3c4?=
 =?utf-8?B?ejJTRXJVV3kvMEdYaEkwZW1Oc3hScFpkN0NoSlN6eFI3R3J0cmZyeXpTanBJ?=
 =?utf-8?B?Z1VLSWZpdHdxWXVzaFBsVnA5TDZHTFloakpVQ2NBVUZkODkrNEJIdW53TEpw?=
 =?utf-8?B?N29yYzYxVGs3Yi9wOEF3SUloZWRvNjJwNHA1RC9pMFpQNm12bnFVZFZGQmtV?=
 =?utf-8?B?ak1mbVE3ckRzekhlWXBzYUprQnZQM0NlUHU4bm8vV1NzMG1nakYwM3RqUWhR?=
 =?utf-8?B?NE1EN3haOEtEZk9nUmk3RmxMd2NzN1E2R3dldU9oNlhOVDRhZm1VK056QmRL?=
 =?utf-8?B?bkRiNEN3V0FHOHAxSlppVEFlZG5ISnZNRVpiZnZMWnpuWWcrWFFMZWkxSmQ5?=
 =?utf-8?B?V2pBVWRpd1NKcWtaTzBYc2s2YWk1U2N0ZEN3T2pyR0JRczZlRkVGWTNFYzdB?=
 =?utf-8?B?dkc1MzVXTzV5OGtmWk9naGdFQk00dE43SzF1ZGFFeGJPaXYrNlk4WCtiTk92?=
 =?utf-8?B?Sm1iamVxWUpLcDRxWVVlL3lEYjdOUS8wZnlseE9UY2h5SDRRamJpOXk1bmxr?=
 =?utf-8?B?a21YSHN3N2pQUElMSHRNMXZvK3g1OVdVSTZWSUp1TklUVWtDaHRpK3hLbGox?=
 =?utf-8?B?dS9rZmJBa1Q1ZHltRFhRMm41bk0rblZGa1lJSzV0dlFXYWJkWVlVRTY3U2E2?=
 =?utf-8?B?MUFIblZ3bWpXbXZwVVlSMmNxY2RjSmhHcDBFZlBtTnJTczJCZGEvNVJCanRk?=
 =?utf-8?B?dUVaTm82TTRrMzdBRkZrdjJyRTBWZFBuaUxKVkI3b3BFd08wbXE1UFJXQlM0?=
 =?utf-8?B?a1Q1T0Z1RGdyeEY2MkV0eXdOUlQ0WEhXSWVIV1FhYnM0N2k3T0JNdUI2U2NH?=
 =?utf-8?B?aW1ZV2FHZTcwODdSMlNQWHJ0N09oY2RPNEpoQmpReG1JSXpGT1JuY3loOVoz?=
 =?utf-8?B?eElRU3JpRUdiZjVyVEc1T2syZTUzNDVJdHB5UGxBSTA4cG13ZC9sTUIwb1Zv?=
 =?utf-8?B?SXdZZ3k4dnJXK25kOW1kbnVoMFVob0ZLV0M5S1BXMGhKS1BQemNyRldnWGtp?=
 =?utf-8?Q?BcZyoJ3RGEu3sHL91TgjwcoUJ?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <D2B1F25462B88D4794E529D8DBDA59C6@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86993544-9e91-40af-e4bd-08daa59e24e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 00:19:46.8445
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Csdm8jE2Q4IDVUn8fk5GivlsK2y6kcs/AII07MLZtqoTtkZlDHo4RlL5iyR1FH7c11pin3Acq+hQBB+J/oIbaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR05MB2797

T24gT2N0IDMsIDIwMjIsIGF0IDQ6NTEgUE0sIEguIFBldGVyIEFudmluIDxocGFAenl0b3IuY29t
PiB3cm90ZToNCg0KPiDimqAgRXh0ZXJuYWwgRW1haWwNCj4gDQo+IE9uIE9jdG9iZXIgMywgMjAy
MiAyOjI4OjQwIFBNIFBEVCwgTmFkYXYgQW1pdCA8bmFtaXRAdm13YXJlLmNvbT4gd3JvdGU6DQo+
PiBPbiBPY3QgMywgMjAyMiwgYXQgMjowNiBQTSwgSC4gUGV0ZXIgQW52aW4gPGhwYUB6eXRvci5j
b20+IHdyb3RlOg0KPj4gDQo+Pj4g4pqgIEV4dGVybmFsIEVtYWlsDQo+Pj4gDQo+Pj4gT24gT2N0
b2JlciAzLCAyMDIyIDEwOjM0OjE1IEFNIFBEVCwgTmFkYXYgQW1pdCA8bmFtaXRAdm13YXJlLmNv
bT4gd3JvdGU6DQo+Pj4+IE9uIE9jdCAzLCAyMDIyLCBhdCA4OjAzIEFNLCBWaXRhbHkgS3V6bmV0
c292IDx2a3V6bmV0c0ByZWRoYXQuY29tPiB3cm90ZToNCj4+Pj4gDQo+Pj4+PiBOb3QgbXkgYnV0
IHJhdGhlciBQQ0kgbWFpbnRhaW5lcidzIGNhbGwgYnV0IElNSE8gZHJvcHBpbmcgJ2NvbnN0JyBp
cw0KPj4+Pj4gYmV0dGVyLCBpbnRyb2R1Y2luZyBhIG5ldyBnbG9iYWwgdmFyIGlzIG91ciAnbGFz
dCByZXNvcnQnIGFuZCBzaG91bGQgYmUNCj4+Pj4+IGF2b2lkZWQgd2hlbmV2ZXIgcG9zc2libGUu
IEFsdGVybmF0aXZlbHksIHlvdSBjYW4gYWRkIGENCj4+Pj4+IHJhd19wY2lfZXh0X29wc19wcmVm
ZXJyZWQoKSBmdW5jdGlvbiBjaGVja2luZyBzb21ldGhpbiB3aXRoaW4gJ3N0cnVjdA0KPj4+Pj4g
aHlwZXJ2aXNvcl94ODYnIGJ1dCBJJ20gdW5zdXJlIGlmIGl0J3MgYmV0dGVyLg0KPj4+Pj4gDQo+
Pj4+PiBBbHNvLCBwbGVhc2UgY2hlY2sgQWxleCcgcXVlc3Rpb24vc3VnZ2VzdGlvbi4NCj4+Pj4g
DQo+Pj4+IEhlcmUgaXMgbXkgdGFrZSAoYW5kIEFqYXkga25vd3MgcHJvYmFibHkgbW9yZSB0aGFu
IG1lKToNCj4+Pj4gDQo+Pj4+IExvb2tpbmcgYnJpZWZseSBvbiBNQ0ZHLCBJIGRvIG5vdCBzZWUg
YSBjbGVhbiB3YXkgb2YgdXNpbmcgdGhlIEFDUEkgdGFibGUuDQo+Pj4+IFRoZSB0d28gb3B0aW9u
cyBhcmUgZWl0aGVyIHRvIHVzZSBhIHJlc2VydmVkIGZpZWxkICh3aGljaCB3aG8ga25vd3MsIG1p
Z2h0DQo+Pj4+IGJlIHVzZWQgb25lIGRheSkgb3Igc29tZSBPRU0gSUQuIEkgYW0gYWxzbyBub3Qg
ZmFtaWxpYXIgd2l0aA0KPj4+PiBQQ0lfQ09NTUFORC5NRU1PUlk9MCwgc28gQWpheSBjYW4gaG9w
ZWZ1bGx5IGdpdmUgc29tZSBhbnN3ZXIgYWJvdXQgdGhhdC4NCj4+Pj4gDQo+Pj4+IEFueWhvdywg
SSB1bmRlcnN0YW5kIChhbHRob3VnaCBub3QgcmVsYXRlKSB0byB0aGUgb2JqZWN0aW9uIGZvciBh
IG5ldyBnbG9iYWwNCj4+Pj4gdmFyaWFibGUuIEhvdyBhYm91dCBleHBsaWNpdGx5IGNhbGxpbmcg
dGhpcyBoYXJkd2FyZSBidWcgYSDigJxidWfigJ0gYW5kIHVzaW5nDQo+Pj4+IHRoZSBwcm9wZXIg
aW5mcmFzdHJ1Y3R1cmU/IENhbGxpbmcgaXQgZXhwbGljaXRseSBhIGJ1ZyBtYXkgZXZlbiBwdXNo
IHdob2V2ZXINCj4+Pj4gY2FuIHRvIHJlc29sdmUgaXQuDQo+Pj4+IA0KPj4+PiBJT1csIGhvdyBh
Ym91dCBkb2luZyBzb21ldGhpbmcgYWxvbmcgdGhlIGxpbmVzIG9mIChub3QgdGVzdGVkKToNCj4+
Pj4gDQo+Pj4+IA0KPj4+PiAtLSA+OCAtLQ0KPj4+PiANCj4+Pj4gU3ViamVjdDogW1BBVENIXSB4
ODYvUENJOiBQcmVmZXIgTU1JTyBvdmVyIFBJTyBvbiBWTXdhcmUgaHlwZXJ2aXNvcg0KPj4+PiAN
Cj4+Pj4gLS0tDQo+Pj4+IGFyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmVzLmggfCAxICsN
Cj4+Pj4gYXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYyAgICAgICB8IDIgKysNCj4+Pj4gYXJj
aC94ODYva2VybmVsL2NwdS92bXdhcmUuYyAgICAgICB8IDIgKysNCj4+Pj4gYXJjaC94ODYvcGNp
L2NvbW1vbi5jICAgICAgICAgICAgICB8IDYgKysrKy0tDQo+Pj4+IDQgZmlsZXMgY2hhbmdlZCwg
OSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBh
L2FyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmVzLmggYi9hcmNoL3g4Ni9pbmNsdWRlL2Fz
bS9jcHVmZWF0dXJlcy5oDQo+Pj4+IGluZGV4IGVmNDc3NWM2ZGIwMS4uMjE2YjZmMzU3YjZkIDEw
MDY0NA0KPj4+PiAtLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVmZWF0dXJlcy5oDQo+Pj4+
ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NwdWZlYXR1cmVzLmgNCj4+Pj4gQEAgLTQ2MCw1
ICs0NjAsNiBAQA0KPj4+PiAjZGVmaW5lIFg4Nl9CVUdfTU1JT19VTktOT1dOICAgICAgICAgIFg4
Nl9CVUcoMjYpIC8qIENQVSBpcyB0b28gb2xkIGFuZCBpdHMgTU1JTyBTdGFsZSBEYXRhIHN0YXR1
cyBpcyB1bmtub3duICovDQo+Pj4+ICNkZWZpbmUgWDg2X0JVR19SRVRCTEVFRCAgICAgICAgICAg
ICAgWDg2X0JVRygyNykgLyogQ1BVIGlzIGFmZmVjdGVkIGJ5IFJFVEJsZWVkICovDQo+Pj4+ICNk
ZWZpbmUgWDg2X0JVR19FSUJSU19QQlJTQiAgICAgICAgICAgWDg2X0JVRygyOCkgLyogRUlCUlMg
aXMgdnVsbmVyYWJsZSB0byBQb3N0IEJhcnJpZXIgUlNCIFByZWRpY3Rpb25zICovDQo+Pj4+ICsj
ZGVmaW5lIFg4Nl9CVUdfRUNBTV9NTUlPICAgICAgICAgICAgIFg4Nl9CVUcoMjkpIC8qIEVDQU0g
TU1JTyBpcyBidWdneSBhbmQgUElPIGlzIHByZWZlcmFibGUgKi8NCj4+Pj4gDQo+Pj4+ICNlbmRp
ZiAvKiBfQVNNX1g4Nl9DUFVGRUFUVVJFU19IICovDQo+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4
Ni9rZXJuZWwvY3B1L2NvbW1vbi5jIGIvYXJjaC94ODYva2VybmVsL2NwdS9jb21tb24uYw0KPj4+
PiBpbmRleCAzZTUwOGYyMzkwOTguLmM5NDE3NWZhMzA0YiAxMDA2NDQNCj4+Pj4gLS0tIGEvYXJj
aC94ODYva2VybmVsL2NwdS9jb21tb24uYw0KPj4+PiArKysgYi9hcmNoL3g4Ni9rZXJuZWwvY3B1
L2NvbW1vbi5jDQo+Pj4+IEBAIC0xMjk5LDYgKzEyOTksOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQg
Y3B1X3NldF9idWdfYml0cyhzdHJ1Y3QgY3B1aW5mb194ODYgKmMpDQo+Pj4+IHsNCj4+Pj4gICAg
IHU2NCBpYTMyX2NhcCA9IHg4Nl9yZWFkX2FyY2hfY2FwX21zcigpOw0KPj4+PiANCj4+Pj4gKyAg
ICAgIHNldHVwX2ZvcmNlX2NwdV9idWcoWDg2X0JVR19FQ0FNX01NSU8pOw0KPj4+PiArDQo+Pj4+
ICAgICAvKiBTZXQgSVRMQl9NVUxUSUhJVCBidWcgaWYgY3B1IGlzIG5vdCBpbiB0aGUgd2hpdGVs
aXN0IGFuZCBub3QgbWl0aWdhdGVkICovDQo+Pj4+ICAgICBpZiAoIWNwdV9tYXRjaGVzKGNwdV92
dWxuX3doaXRlbGlzdCwgTk9fSVRMQl9NVUxUSUhJVCkgJiYNCj4+Pj4gICAgICAgICAhKGlhMzJf
Y2FwICYgQVJDSF9DQVBfUFNDSEFOR0VfTUNfTk8pKQ0KPj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC94
ODYva2VybmVsL2NwdS92bXdhcmUuYyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvdm13YXJlLmMNCj4+
Pj4gaW5kZXggMDIwMzllYzM1OTdkLi44OTAzNzc2Mjg0YTYgMTAwNjQ0DQo+Pj4+IC0tLSBhL2Fy
Y2gveDg2L2tlcm5lbC9jcHUvdm13YXJlLmMNCj4+Pj4gKysrIGIvYXJjaC94ODYva2VybmVsL2Nw
dS92bXdhcmUuYw0KPj4+PiBAQCAtMzg1LDYgKzM4NSw4IEBAIHN0YXRpYyB2b2lkIF9faW5pdCB2
bXdhcmVfc2V0X2NhcGFiaWxpdGllcyh2b2lkKQ0KPj4+PiAgICAgICAgICAgICBzZXR1cF9mb3Jj
ZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1ZNQ0FMTCk7DQo+Pj4+ICAgICBlbHNlIGlmICh2bXdhcmVf
aHlwZXJjYWxsX21vZGUgPT0gQ1BVSURfVk1XQVJFX0ZFQVRVUkVTX0VDWF9WTU1DQUxMKQ0KPj4+
PiAgICAgICAgICAgICBzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1ZNV19WTU1DQUxM
KTsNCj4+Pj4gKw0KPj4+PiArICAgICAgc2V0dXBfY2xlYXJfY3B1X2NhcChYODZfQlVHX0VDQU1f
TU1JTyk7DQo+Pj4+IH0NCj4+Pj4gDQo+Pj4+IHN0YXRpYyB2b2lkIF9faW5pdCB2bXdhcmVfcGxh
dGZvcm1fc2V0dXAodm9pZCkNCj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3BjaS9jb21tb24u
YyBiL2FyY2gveDg2L3BjaS9jb21tb24uYw0KPj4+PiBpbmRleCBkZGI3OTg2MDMyMDEuLmJjODFj
ZjRjMTAxNCAxMDA2NDQNCj4+Pj4gLS0tIGEvYXJjaC94ODYvcGNpL2NvbW1vbi5jDQo+Pj4+ICsr
KyBiL2FyY2gveDg2L3BjaS9jb21tb24uYw0KPj4+PiBAQCAtNDAsNyArNDAsOCBAQCBjb25zdCBz
dHJ1Y3QgcGNpX3Jhd19vcHMgKl9fcmVhZF9tb3N0bHkgcmF3X3BjaV9leHRfb3BzOw0KPj4+PiBp
bnQgcmF3X3BjaV9yZWFkKHVuc2lnbmVkIGludCBkb21haW4sIHVuc2lnbmVkIGludCBidXMsIHVu
c2lnbmVkIGludCBkZXZmbiwNCj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBpbnQgcmVnLCBpbnQgbGVuLCB1MzIgKnZhbCkNCj4+Pj4gew0KPj4+PiAtICAg
ICAgaWYgKGRvbWFpbiA9PSAwICYmIHJlZyA8IDI1NiAmJiByYXdfcGNpX29wcykNCj4+Pj4gKyAg
ICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcgPCAyNTYgJiYgcmF3X3BjaV9vcHMgJiYNCj4+Pj4g
KyAgICAgICAgICAoYm9vdF9jcHVfaGFzX2J1ZyhYODZfQlVHX0VDQU1fTU1JTykgfHwgIXJhd19w
Y2lfZXh0X29wcykpDQo+Pj4+ICAgICAgICAgICAgIHJldHVybiByYXdfcGNpX29wcy0+cmVhZChk
b21haW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVuLCB2YWwpOw0KPj4+PiAgICAgaWYgKHJhd19wY2lf
ZXh0X29wcykNCj4+Pj4gICAgICAgICAgICAgcmV0dXJuIHJhd19wY2lfZXh0X29wcy0+cmVhZChk
b21haW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVuLCB2YWwpOw0KPj4+PiBAQCAtNTAsNyArNTEsOCBA
QCBpbnQgcmF3X3BjaV9yZWFkKHVuc2lnbmVkIGludCBkb21haW4sIHVuc2lnbmVkIGludCBidXMs
IHVuc2lnbmVkIGludCBkZXZmbiwNCj4+Pj4gaW50IHJhd19wY2lfd3JpdGUodW5zaWduZWQgaW50
IGRvbWFpbiwgdW5zaWduZWQgaW50IGJ1cywgdW5zaWduZWQgaW50IGRldmZuLA0KPj4+PiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCByZWcsIGludCBsZW4s
IHUzMiB2YWwpDQo+Pj4+IHsNCj4+Pj4gLSAgICAgIGlmIChkb21haW4gPT0gMCAmJiByZWcgPCAy
NTYgJiYgcmF3X3BjaV9vcHMpDQo+Pj4+ICsgICAgICBpZiAoZG9tYWluID09IDAgJiYgcmVnIDwg
MjU2ICYmIHJhd19wY2lfb3BzICYmDQo+Pj4+ICsgICAgICAgICAgKGJvb3RfY3B1X2hhc19idWco
WDg2X0JVR19FQ0FNX01NSU8pIHx8ICFyYXdfcGNpX2V4dF9vcHMpKQ0KPj4+PiAgICAgICAgICAg
ICByZXR1cm4gcmF3X3BjaV9vcHMtPndyaXRlKGRvbWFpbiwgYnVzLCBkZXZmbiwgcmVnLCBsZW4s
IHZhbCk7DQo+Pj4+ICAgICBpZiAocmF3X3BjaV9leHRfb3BzKQ0KPj4+PiAgICAgICAgICAgICBy
ZXR1cm4gcmF3X3BjaV9leHRfb3BzLT53cml0ZShkb21haW4sIGJ1cywgZGV2Zm4sIHJlZywgbGVu
LCB2YWwpOw0KPj4+IA0KPj4+IEFsc28uLi4gYW55IHJlYXNvbiB3ZSBjYW4ndCBqdXN0IHNldCBy
YXdfcGNpX29wcyA9PSByYXdfZXh0X3BjaV9vcHMgZm9yIHRoZSBjYXNlIHdoZW4gdGhlIGxhdHRl
ciBpcyBwcmVmZXJyZWQsIGFuZCBkaXNwZW5zZSB3aXRoIHRoZSBjb25kaXRpb25hbHMgaW4gdGhl
IHVzZSBwYXRoPyBTaW1pbGFybHksIHJhd19leHRfcGNpX29wcyBjb3VsZCBiZSBwb2ludGVkIHRv
IGVycm9yIHJvdXRpbmVzIGluc3RlYWQgb2YgbGVmdCBhdCBOVUxMLg0KPj4gDQo+PiBJIHVuZGVy
c3Rvb2QgZnJvbSBBamF5IHRoYXQgdGhlIGluaXRpYWxpemF0aW9uIG9mIHJhd19leHRfcGNpX29w
cyBjYW4gYmUNCj4+IGRvbmUgYWZ0ZXIgdGhlIGh5cGVydmlzb3IgaW5pdGlhbGl6YXRpb24gdGFr
ZXMgcGxhY2UsIHNvIGRvaW5nIHdoYXQgZXhhY3RseQ0KPj4gd2hhdCB5b3UgcHJvcG9zZWQgYnkg
aXMgbm90IHBvc3NpYmxlLiBJdCBjYW4gcHJvYmFibHkgYmUgcmVzb2x2ZWQsIGJ1dCBJIGRvDQo+
PiBub3QgdGhpbmsgdGhlIGVuZCByZXN1bHQgd291bGQgYmUgc2ltcGxlciBvciBjbGVhbmVyLiBJ
IHRoaW5rIHRoYXQgdGhlIOKAnGJ1Z+KAnQ0KPj4gc29sdXRpb24gcmVhbGx5IGNvbnZleXMgdGhl
IGJlaGF2aW9yLg0KPj4gDQo+PiBJSVVDIHBlcmZvcm1hbmNlIHdvdWxkIG5vdCBiZSBub3RpY2Vh
YmxlIGFmZmVjdGVkIGJ5IDIgbW9yZSBjb25kaXRpb25hbA0KPj4gYnJhbmNoZXMuDQo+IA0KPiBJ
c24ndCB0aGF0IGV4YWN0bHkgd2hhdCB5b3Ugd291bGQgd2FudD8hPw0KDQpUd28gYnJhbmNoZXMg
KHdoaWNoIGFyZSBwcm9iYWJseSBtb3N0bHkgcHJlZGljdGVkIGNvcnJlY3RseSkgYXJlDQppbmV4
cGVuc2l2ZSAobmFub3NlY29uZHM/KQ0KDQpDYXVzaW5nIGEgVk0tZXhpdCwgYW5kIHRoZSB3aG9s
ZSBtZXNzIG9mIGhhbmRsaW5nIGl0IGluIHRoZSBoeXBlcnZpc29yDQoocG90ZW50aWFsbHkgdGhl
IHVzZXJzcGFjZSBwYXJ0IG9mIHRoZSBoeXBlcnZpc29yKSBpcyBleHBlbnNpdmUNCihtaWNyb3Nl
Y29uZHMpLiBJSVVDLCBBamF5IHdhbnRzIHRvIGxldCByZWFkcyB0byBwYXNzIHRocm91Z2ggdG8g
bWVtb3J5LA0KYXZvaWRpbmcgdGhlc2UgVk0tZXhpdHMuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 00:25:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 00:25:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415100.659588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofVkb-0003Yj-5F; Tue, 04 Oct 2022 00:25:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415100.659588; Tue, 04 Oct 2022 00:25:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofVkb-0003Yc-2V; Tue, 04 Oct 2022 00:25:33 +0000
Received: by outflank-mailman (input) for mailman id 415100;
 Tue, 04 Oct 2022 00:25:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+z6g=2F=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ofVka-0003YW-5e
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 00:25:32 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0caef3c7-437b-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 02:25:30 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2E83F61211;
 Tue,  4 Oct 2022 00:25:29 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E35DC433C1;
 Tue,  4 Oct 2022 00:25:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0caef3c7-437b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664843128;
	bh=DEbMt8IN9I+S0o6tUQvtHz8KO39e8we/0IMehRfC8uA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=hsqd9sCjtpcvaRyRuBYxPZo8FyqLsFjAJKV75w1Ay1Ap6uJVNKhMvNX5skWuTuXLR
	 g2oaALH7xZE+zaBGMCs3HiGuDx69V5BbyNSdazx83dKRUBnFC4ZvR7vGY5kWVmxZkG
	 NWBLefzM9rHXdZnUuar+9AlAU0R90b5qFvYEjpEw96ngML6UUfT1/u5z6tL62bzbWp
	 RHRWgPsVJKFNrcwTdXui+54iPcM84IZZ+NlEr5uX3zbACRrZgiMQwcuRR3lwm5hNBQ
	 tHThvoc9sZn4AR17jw3wMFJnEM/03TE0pjGF+YBKCBytyqAZlnUFUnkIFyFp1RQSYO
	 qr7WD3zvXDLLA==
Date: Mon, 3 Oct 2022 17:25:25 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: Anthony PERARD <anthony.perard@citrix.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <volodymyr_babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <amc96@srcf.net>, 
    osstest service owner <osstest-admin@xenproject.org>, 
    xen-devel@lists.xenproject.org, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Henry Wang <Henry.Wang@arm.com>
Subject: Re: [xen-unstable-smoke test] 173362: regressions - FAIL
In-Reply-To: <cd7b7622-273e-5662-8dc4-826ff9c4c331@suse.com>
Message-ID: <alpine.DEB.2.22.394.2210031719530.3073309@ubuntu-linux-20-04-desktop>
References: <osstest-173362-mainreport@xen.org> <200b2ad7-8cf9-4ca5-cb54-6e72ced7d7d9@srcf.net> <b3242791-3d30-ce72-010c-c31db05b175e@suse.com> <YzbDWSAiRBhnqKOF@perard.uk.xensource.com> <cd7b7622-273e-5662-8dc4-826ff9c4c331@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-160457610-1664843128=:3073309"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-160457610-1664843128=:3073309
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 30 Sep 2022, Jan Beulich wrote:
> On 30.09.2022 12:22, Anthony PERARD wrote:
> > On Fri, Sep 30, 2022 at 08:31:20AM +0200, Jan Beulich wrote:
> >> On 29.09.2022 18:25, Andrew Cooper wrote:
> >>> On 29/09/2022 17:22, osstest service owner wrote:
> >>>> flight 173362 xen-unstable-smoke real [real]
> >>>> http://logs.test-lab.xenproject.org/osstest/logs/173362/
> >>>>
> >>>> Regressions :-(
> >>>>
> >>>> Tests which did not succeed and are blocking,
> >>>> including tests which could not be run:
> >>>>  build-arm64-xsm               6 xen-build                fail REGR. vs. 173347
> >>>
> >>> arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access':
> >>> arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of
> >>> 'iomem_deny_access' discards 'const' qualifier from pointer target type
> >>> [-Werror=discarded-qualifiers]
> >>>          rc = iomem_deny_access(d, mfn, mfn + nr);
> >>>                                 ^
> >>> In file included from arch/arm/gic-v3-its.c:24:
> >>> ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but
> >>> argument is of type 'const struct domain *'
> >>>  static inline int iomem_deny_access(struct domain *d, unsigned long s,
> >>>                                      ~~~~~~~~~~~~~~~^
> >>> cc1: all warnings being treated as errors
> >>
> >> I've sent a patch, but this raises another question: Why does the smoke
> >> test (try to) build an unsupported configuration? HAS_ITS (which is
> >> necessary to be set for the issue to surface) has its prompt depend on
> >> UNSUPPORTED, and (implicitly) defaults to N.
> > 
> > According to osstest sources:
> >     # ITS driver is required to boot the Hardware Domain
> >     # on Xen. For now (Xen 4.10/4.11 at at least),
> >     # will be not built by default and gated by expert mode
> >     echo >>xen/.config CONFIG_HAS_ITS=y
> 
> Hmm, that's been quite a number of revisions back, without things having
> changed. Arm maintainers - what's the plan here? What use is it to test
> an unsupported configuration (for years)?

This issue is non-trivial. On my side, I still don't have easy access to
hardware with ITS in it. This will change in the future, but we are not
there yet. So as of now I couldn't "support" ITS.


> But there's a more general aspect here: EXPERT is forced to Y here as
> well, which is fine by itself. But it implies UNSUPPORTED also getting
> enabled. That latter aspect is what I consider wrong for smoke flights
> at least. Yet (as said) HAS_ITS depends on it (and its setting to Y by
> the script would have no effect if UNSUPPORTED was off).

I agree with you, but I don't have a solution to offer due to the above.
--8323329-160457610-1664843128=:3073309--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 00:46:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 00:46:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415109.659599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofW4o-0005ww-T4; Tue, 04 Oct 2022 00:46:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415109.659599; Tue, 04 Oct 2022 00:46:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofW4o-0005wp-Py; Tue, 04 Oct 2022 00:46:26 +0000
Received: by outflank-mailman (input) for mailman id 415109;
 Tue, 04 Oct 2022 00:46:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofW4n-0005wf-E5; Tue, 04 Oct 2022 00:46:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofW4n-0002WR-AH; Tue, 04 Oct 2022 00:46:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofW4m-0000mX-M8; Tue, 04 Oct 2022 00:46:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofW4m-0001nL-Le; Tue, 04 Oct 2022 00:46:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0tsmWS5kyT7OvgL0dexWANFq2b7LpRem+7DNTf3ZCGg=; b=oprkjN09Nwiq5tl4ONVCnPNfEt
	ygODtmclYneXuwyWoeMi2xE8KCZwkiMhrNLX5+HL260iejGr0amHFH9JiBxojw17szs6N4k/8jLGi
	+FpBg4WRBOUNyuJD3iS53cpMobg2L2YviaqYWN9qYqzAyjL7B5U9eUcS2w4YtoufjNB8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173405-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173405: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f3dfe925f9548a4337883926db542ccf4ca55fe1
X-Osstest-Versions-That:
    linux=4fe89d07dcc2804c8b562f6c7896a45643d34b2f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 00:46:24 +0000

flight 173405 linux-linus real [real]
flight 173409 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173405/
http://logs.test-lab.xenproject.org/osstest/logs/173409/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 173409-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173401

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173401
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173401
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173401
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173401
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173401
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173401
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173401
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173401
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                f3dfe925f9548a4337883926db542ccf4ca55fe1
baseline version:
 linux                4fe89d07dcc2804c8b562f6c7896a45643d34b2f

Last test of basis   173401  2022-10-02 23:12:09 Z    1 days
Testing same since   173405  2022-10-03 17:40:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akhil Raj <lf32.dev@gmail.com>
  Akira Yokosawa <akiyks@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Aleksander Jan Bajkowski <olek2@wp.pl>
  Bart Van Assche <bvanassche@acm.org>
  Binbin Zhou <zhoubinbin@loongson.cn>
  David Hildenbrand <david@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Eric Lin <dslin1010@gmail.com>
  Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Greg Ungerer <gerg@linux-m68k.org>
  Hoi Pok Wu <wuhoipok@gmail.com>
  Jani Nikula <jani.nikula@intel.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <wangborong@cdjrlc.com>
  Joel Fernandes (Google) <joel@joelfernandes.org>
  Jonathan Corbet <corbet@lwn.net>
  JunChao Sun <sunjunchao2870@gmail.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Konstantin Ryabitsev <konstantin@linuxfoundation.org>
  Kristen Carlson Accardi <kristen@linux.intel.com>
  Lin Yujun <linyujun809@huawei.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Shixin <liushixin2@huawei.com>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Lukasz Luba <lukasz.luba@arm.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Michal Hocko <mhocko@suse.com>
  Paul E. McKenney <paulmck@kernel.org>
  Paul Heidekrüger <paul.heidekrueger@in.tum.de>
  Peter Chen <peter.chen@kernel.org>
  Rafał Miłecki <rafal@milecki.pl>
  Randy Dunlap <rdunlap@infradead.org>
  Robert Elliott <elliott@hpe.com>
  Rong Tao <rtoax@foxmail.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Salvatore Bonaccorso <carnil@debian.org>
  Sergey Ryazanov <ryazanov.s.a@gmail.com>
  Shao-Tse Hung <ccs100203@gmail.com>
  Shaomin Deng <dengshaomin@cdjrlc.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thorsten Leemhuis <linux@leemhuis.info>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Tuo Cao <91tuocao@gmail.com>
  Uladzislau Rezki (Sony) <urezki@gmail.com>
  Vernon Yang <vernon2gm@gmail.com>
  Wang Kefeng <wangkefeng.wang@huawei.com>
  Willy Tarreau <w@1wt.eu>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Wu XiangCheng <bobwxc@email.cn>
  Yang Yingliang <yangyingliang@huawei.com>
  Yanteng Si <siyanteng@loongson.cn>
  Zhao Mengmeng <zhaomengmeng@kylinos.cn>
  Zhen Lei <thunder.leizhen@huawei.com>
  Zqiang <qiang1.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   4fe89d07dcc2..f3dfe925f954  f3dfe925f9548a4337883926db542ccf4ca55fe1 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 01:31:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 01:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415123.659617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofWmX-0004h1-Gg; Tue, 04 Oct 2022 01:31:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415123.659617; Tue, 04 Oct 2022 01:31:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofWmX-0004gu-DW; Tue, 04 Oct 2022 01:31:37 +0000
Received: by outflank-mailman (input) for mailman id 415123;
 Tue, 04 Oct 2022 01:31:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cE49=2F=runbox.com=m.v.b@srs-se1.protection.inumbo.net>)
 id 1ofWmU-0004go-RK
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 01:31:35 +0000
Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com
 [2a0c:5a00:149::26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4737f8a1-4384-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 03:31:33 +0200 (CEST)
Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com)
 by mailtransmit05.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <m.v.b@runbox.com>)
 id 1ofWmR-00CqyC-5D; Tue, 04 Oct 2022 03:31:31 +0200
Received: from [10.9.9.72] (helo=submission01.runbox)
 by mailtransmit02.runbox with esmtp (Exim 4.86_2)
 (envelope-from <m.v.b@runbox.com>)
 id 1ofWmQ-0000M8-74; Tue, 04 Oct 2022 03:31:30 +0200
Received: by submission01.runbox with esmtpsa [Authenticated ID (536975)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1ofWmO-0000kW-Bs; Tue, 04 Oct 2022 03:31:28 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4737f8a1-4384-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com;
	 s=selector2; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=D12fPQ5j3j3zSJ/Nfz7wHUZeYeIAFD/CgfUoI8BE3ZA=; b=KWm+bB2tlzfdk2RsQd5XOvV6l2
	n3XwWNFf6zH1vpPYFqUjRI2G8lehv4j1L9ZQeEXvaUZkK4TVcCVBYCOS3DaK3z7IRKPqq2/p7rayd
	/vFucL90mtoJjFcsX34rvh3gMoUgQHb+MiCBqUINNi7DeqTg0Y0OhztjvyF2UlYUHqvENRy995cv1
	nQpHrBQaizuYfDX3BIGfrYce6XZwbA5q0M/vL80pvfzTnL5uNQcgcLmWcL9kwsnG3nTPmJuAdPcxB
	Em+o0AytxrTGw93rCB3EllmKCVTVQlc2gE8QquiGmHnLYmEfY3CcMZ/Ktr4NfL3uh7jRiDI6+9m16
	54nimbAA==;
Message-ID: <41d15ac1-7977-db49-f8e9-df642616c745@runbox.com>
Date: Mon, 3 Oct 2022 21:31:25 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
Content-Language: en-CA
To: Demi Marie Obenour <demi@invisiblethingslab.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Gerd Hoffmann <kraxel@redhat.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-2-m.v.b@runbox.com> <YzotDube4gTn7r9b@itl-email>
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
In-Reply-To: <YzotDube4gTn7r9b@itl-email>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2022-10-02 20:29, Demi Marie Obenour wrote:
> On Sun, Oct 02, 2022 at 06:20:05PM -0400, M. Vefa Bicakci wrote:
>> Prior to this commit, if a grant mapping operation failed partially,
>> some of the entries in the map_ops array would be invalid, whereas all
>> of the entries in the kmap_ops array would be valid. This in turn would
>> cause the following logic in gntdev_map_grant_pages to become invalid:
>>
>>    for (i = 0; i < map->count; i++) {
>>      if (map->map_ops[i].status == GNTST_okay) {
>>        map->unmap_ops[i].handle = map->map_ops[i].handle;
>>        if (!use_ptemod)
>>          alloced++;
>>      }
>>      if (use_ptemod) {
>>        if (map->kmap_ops[i].status == GNTST_okay) {
>>          if (map->map_ops[i].status == GNTST_okay)
>>            alloced++;
>>          map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
>>        }
>>      }
>>    }
>>    ...
>>    atomic_add(alloced, &map->live_grants);
>>
>> Assume that use_ptemod is true (i.e., the domain mapping the granted
>> pages is a paravirtualized domain). In the code excerpt above, note that
>> the "alloced" variable is only incremented when both kmap_ops[i].status
>> and map_ops[i].status are set to GNTST_okay (i.e., both mapping
>> operations are successful).  However, as also noted above, there are
>> cases where a grant mapping operation fails partially, breaking the
>> assumption of the code excerpt above.
>>
>> The aforementioned causes map->live_grants to be incorrectly set. In
>> some cases, all of the map_ops mappings fail, but all of the kmap_ops
>> mappings succeed, meaning that live_grants may remain zero. This in turn
>> makes it impossible to unmap the successfully grant-mapped pages pointed
>> to by kmap_ops, because unmap_grant_pages has the following snippet of
>> code at its beginning:
>>
>>    if (atomic_read(&map->live_grants) == 0)
>>      return; /* Nothing to do */
>>
>> In other cases where only some of the map_ops mappings fail but all
>> kmap_ops mappings succeed, live_grants is made positive, but when the
>> user requests unmapping the grant-mapped pages, __unmap_grant_pages_done
>> will then make map->live_grants negative, because the latter function
>> does not check if all of the pages that were requested to be unmapped
>> were actually unmapped, and the same function unconditionally subtracts
>> "data->count" (i.e., a value that can be greater than map->live_grants)
>> from map->live_grants. The side effects of a negative live_grants value
>> have not been studied.
>>
>> The net effect of all of this is that grant references are leaked in one
>> of the above conditions. In Qubes OS v4.1 (which uses Xen's grant
>> mechanism extensively for X11 GUI isolation), this issue manifests
>> itself with warning messages like the following to be printed out by the
>> Linux kernel in the VM that had granted pages (that contain X11 GUI
>> window data) to dom0: "g.e. 0x1234 still pending", especially after the
>> user rapidly resizes GUI VM windows (causing some grant-mapping
>> operations to partially or completely fail, due to the fact that the VM
>> unshares some of the pages as part of the window resizing, making the
>> pages impossible to grant-map from dom0).
>>
>> The fix for this issue involves counting all successful map_ops and
>> kmap_ops mappings separately, and then adding the sum to live_grants.
>> During unmapping, only the number of successfully unmapped grants is
>> subtracted from live_grants. The code is also modified to check for
>> negative live_grants values after the subtraction and warn the user.
>>
>> Link: https://github.com/QubesOS/qubes-issues/issues/7631
>> Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")
> 
> Looks like this patch has been pretty buggy, sorry.  This is the second
> time there has been a problem with it.  Thanks for the fix.

Hi,

No problem! :-) Debugging this issue and coming up with a fix was a
nice challenge for me.

> 
>> Cc: stable@vger.kernel.org
>> Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
>> ---
>>
>> Changes since v1:
>> - To determine which unmap operations were successful, the previous
>>    version of this patch set the "unmap_ops[i].status" and
>>    "kunmap_ops[i].status" fields to the value "1" prior to passing these
>>    data structures to the hypervisor. Instead of doing that, the code now
>>    checks whether the "handle" fields in the same data structures were
>>    *not* set to "INVALID_GRANT_HANDLE". (Suggested by Juergen Gross.)
>> ---
>>   drivers/xen/gntdev.c | 22 +++++++++++++++++-----
>>   1 file changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
>> index 84b143eef395..eb0586b9767d 100644
>> --- a/drivers/xen/gntdev.c
>> +++ b/drivers/xen/gntdev.c
>> @@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
>>   	for (i = 0; i < map->count; i++) {
>>   		if (map->map_ops[i].status == GNTST_okay) {
>>   			map->unmap_ops[i].handle = map->map_ops[i].handle;
>> -			if (!use_ptemod)
>> -				alloced++;
>> +			alloced++;
>>   		} else if (!err)
>>   			err = -EINVAL;
>>   
>> @@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
>>   
>>   		if (use_ptemod) {
>>   			if (map->kmap_ops[i].status == GNTST_okay) {
>> -				if (map->map_ops[i].status == GNTST_okay)
>> -					alloced++;
>> +				alloced++;
>>   				map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
>>   			} else if (!err)
>>   				err = -EINVAL;
>> @@ -394,8 +392,14 @@ static void __unmap_grant_pages_done(int result,
>>   	unsigned int i;
>>   	struct gntdev_grant_map *map = data->data;
>>   	unsigned int offset = data->unmap_ops - map->unmap_ops;
>> +	int successful_unmaps = 0;
>> +	int live_grants;
>>   
>>   	for (i = 0; i < data->count; i++) {
>> +		if (map->unmap_ops[offset + i].status == GNTST_okay &&
>> +		    map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE)
>> +			successful_unmaps++;
>> +
>>   		WARN_ON(map->unmap_ops[offset + i].status != GNTST_okay &&
>>   			map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE);
>>   		pr_debug("unmap handle=%d st=%d\n",
>> @@ -403,6 +407,10 @@ static void __unmap_grant_pages_done(int result,
>>   			map->unmap_ops[offset+i].status);
>>   		map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
>>   		if (use_ptemod) {
>> +			if (map->kunmap_ops[offset + i].status == GNTST_okay &&
>> +			    map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE)
>> +				successful_unmaps++;
>> +
>>   			WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay &&
>>   				map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE);
>>   			pr_debug("kunmap handle=%u st=%d\n",
>> @@ -411,11 +419,15 @@ static void __unmap_grant_pages_done(int result,
>>   			map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
>>   		}
>>   	}
>> +
>>   	/*
>>   	 * Decrease the live-grant counter.  This must happen after the loop to
>>   	 * prevent premature reuse of the grants by gnttab_mmap().
>>   	 */
>> -	atomic_sub(data->count, &map->live_grants);
>> +	live_grants = atomic_sub_return(successful_unmaps, &map->live_grants);
>> +	if (WARN_ON(live_grants < 0))
>> +		pr_err("%s: live_grants became negative (%d) after unmapping %d pages!\n",
>> +		       __func__, live_grants, successful_unmaps);
>>   
>>   	/* Release reference taken by __unmap_grant_pages */
>>   	gntdev_put_map(NULL, map);
>> -- 
>> 2.37.3
> 
> Is there a possibility that live_grants could overflow, as it is now
> set to a value twice as large as what it had been previously?

Good point! My answer in summary: I think that the code could be improved,
but with reasonable values for the "limit" module parameter, there should
not be issues.

Grant mappings are set up via ioctl calls, and the structure field that
holds the number of grant references has u32 type:

(Quoting from kernel v5.15.71 for convenience)
include/uapi/xen/gntdev.h
=== 8< ===
struct ioctl_gntdev_map_grant_ref {
	/* IN parameters */
	/* The number of grants to be mapped. */
	__u32 count;
=== >8 ===

However, the number of grant references is further limited in the actual
ioctl handler function gntdev_ioctl_map_grant_ref(), which calls
gntdev_test_page_count() to ensure that the number of granted pages
requested to be mapped does not exceed "limit". "limit" defaults to 64K,
which should be okay to use with an atomic_t type (i.e., a 32-bit signed
integer type) like "live_grants", assuming that the system administrator
does not go overboard and set "limit" to a very large value:

drivers/xen/gntdev.c
=== 8< ===
static unsigned int limit = 64*1024;
module_param(limit, uint, 0644);
MODULE_PARM_DESC(limit,
	"Maximum number of grants that may be mapped by one mapping request");

/* trimmed */

bool gntdev_test_page_count(unsigned int count)
{
	return !count || count > limit;
}

/* trimmed */

static long gntdev_ioctl_map_grant_ref(struct gntdev_priv *priv,
				       struct ioctl_gntdev_map_grant_ref __user *u)
{
	/* trimmed */

	pr_debug("priv %p, add %d\n", priv, op.count);
	if (unlikely(gntdev_test_page_count(op.count)))
		return -EINVAL;

	/* trimmed */
}
=== >8 ===

To be fair, the "count" field of the gndev_grant_map structure is a signed
integer, so very large values of count could overflow live_grants, as
live_grants needs to accommodate values up to and including 2*count.

drivers/xen/gntdev-common.h
=== 8< ===
struct gntdev_grant_map {
	atomic_t in_use;
	struct mmu_interval_notifier notifier;
	bool notifier_init;
	struct list_head next;
	int index;
	int count;
	/* trimmed */
}
=== >8 ===

> If not, you can add:
> 
> Acked-by: Demi Marie Obenour <demi@invisiblethingslab.com>

Thank you! I hope that the explanation and rationale above are satisfactory.
Please let me know what you think.

Vefa


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 01:52:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 01:52:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415130.659629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofX6M-00072d-77; Tue, 04 Oct 2022 01:52:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415130.659629; Tue, 04 Oct 2022 01:52:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofX6M-00072W-3m; Tue, 04 Oct 2022 01:52:06 +0000
Received: by outflank-mailman (input) for mailman id 415130;
 Tue, 04 Oct 2022 01:52:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IgJy=2F=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofX6K-00072Q-PX
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 01:52:05 +0000
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2232f5b7-4387-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 03:52:02 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 791B53200708;
 Mon,  3 Oct 2022 21:51:57 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Mon, 03 Oct 2022 21:51:58 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 3 Oct 2022 21:51:55 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2232f5b7-4387-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664848317; x=
	1664934717; bh=GeaBgt1FdrtLxvNF0Ehd+VorrUGsrwKbCOiCcyr1fnI=; b=i
	0xOhOpFy/C3v6ETYKs3JYt1YJsiWqYeZtp2zjFUFvvOPw1OhuiIsq6CAHvA5ip6t
	ld77BfcyuG272NGznXylqJj6t4J6Xl4MQp07gmY2Oqv6Ri6PGr8xHdSVjeFIQdRg
	pf9jAJck8QbzPIOhO2TLaSTZLHfZxSP6l3qCdRtAqu5QYxI8Zi6xGrhlM4W9GQTS
	EBTrsiPNuYCbVpvewdNFP7LjledZsk4AR4yCw00I9r7nv9o6nuFP8IJQM06TtTkU
	uJq2HsJu6SFiWm2rCLKblhxoawqjQ5GWQe6DdN77MCud3KGZyul3y1Nlnc5LEpJ+
	4nWIJjMUvdXIUZ6Xl2Umg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664848317; x=1664934717; bh=GeaBgt1FdrtLxvNF0Ehd+VorrUGs
	rwKbCOiCcyr1fnI=; b=uIu2KMV41dDGLynaUJMGVZAtKH7f5eVvWTlH/slxhFZ7
	e8NO/qozbebm1PdzPKt+AT1+zKcLzh9KvTVBEHq3M08xGPP9mKgk4I7SSe1GIcxB
	KN81mKacs6gqnDg1ovSBVK9vtth3th60GvDlBQ2jJb+dGvymsTw9AcDI5iLXL2gE
	SHz/wUzNluiFcnn9aCdceQ0jvuSTsnkzXik+1rhX6ETFWiw8dYq/arb44KSterH4
	rHSaUJ3HvuBiV44/BqLPCuzSfnTWdxe4l/fIFi5ntOI2wQep4jYDi+VydvTkqpSa
	F5sq2PtFdCsR7vxNQnxECmVh+cg7b2+cuKXN+tE7JA==
X-ME-Sender: <xms:vJE7Y42ne24GtELM2wV0-3ZhZuWMmMHDsRZHWOkCdhAoY3b5tJtj_A>
    <xme:vJE7YzEhIScTtRFRHKPrpiBIq1_7IQt7O71YLhyECHgk0ohfwcJ6wC8e5k-49U_PT
    BFa8_n9jaRHNK8>
X-ME-Received: <xmr:vJE7Yw6AeXtjat4vPWchAAI5g8to4RXN0s7Z6tneW4c8xDtz8bhHfmIIRubj>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeitddgheduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuedthefhtddvffefjeejvdehvdej
    ieehffehkeekheegleeuleevleduteehteetnecuffhomhgrihhnpehgihhthhhusgdrtg
    homhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu
    vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:vJE7Yx2GkzEckhDH4-K9cvq-7RBjeS5P00MdPBoPGGyFVrSYVaz4Og>
    <xmx:vJE7Y7HsTauqqEpoKh3BvbRogDJCCvCin8EKJVdwZWY2m7IDiuakow>
    <xmx:vJE7Y69p5yT00JEJDiP4FV3iO_vm6vHNQ_Kt2wL0ZjdryxvR9pBrlg>
    <xmx:vZE7Y_hRX0WjuJ-OIwsqKcLOIAUgkQYg215tG5fL3LH33IrMwo0QVQ>
Feedback-ID: iac594737:Fastmail
Date: Mon, 3 Oct 2022 21:51:11 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
Message-ID: <YzuRuD/t4/rZAkGG@itl-email>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-2-m.v.b@runbox.com>
 <YzotDube4gTn7r9b@itl-email>
 <41d15ac1-7977-db49-f8e9-df642616c745@runbox.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cyzhu7rkdfkdzg5W"
Content-Disposition: inline
In-Reply-To: <41d15ac1-7977-db49-f8e9-df642616c745@runbox.com>


--cyzhu7rkdfkdzg5W
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 3 Oct 2022 21:51:11 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants

On Mon, Oct 03, 2022 at 09:31:25PM -0400, M. Vefa Bicakci wrote:
> On 2022-10-02 20:29, Demi Marie Obenour wrote:
> > On Sun, Oct 02, 2022 at 06:20:05PM -0400, M. Vefa Bicakci wrote:
> > > Prior to this commit, if a grant mapping operation failed partially,
> > > some of the entries in the map_ops array would be invalid, whereas all
> > > of the entries in the kmap_ops array would be valid. This in turn wou=
ld
> > > cause the following logic in gntdev_map_grant_pages to become invalid:
> > >=20
> > >    for (i =3D 0; i < map->count; i++) {
> > >      if (map->map_ops[i].status =3D=3D GNTST_okay) {
> > >        map->unmap_ops[i].handle =3D map->map_ops[i].handle;
> > >        if (!use_ptemod)
> > >          alloced++;
> > >      }
> > >      if (use_ptemod) {
> > >        if (map->kmap_ops[i].status =3D=3D GNTST_okay) {
> > >          if (map->map_ops[i].status =3D=3D GNTST_okay)
> > >            alloced++;
> > >          map->kunmap_ops[i].handle =3D map->kmap_ops[i].handle;
> > >        }
> > >      }
> > >    }
> > >    ...
> > >    atomic_add(alloced, &map->live_grants);
> > >=20
> > > Assume that use_ptemod is true (i.e., the domain mapping the granted
> > > pages is a paravirtualized domain). In the code excerpt above, note t=
hat
> > > the "alloced" variable is only incremented when both kmap_ops[i].stat=
us
> > > and map_ops[i].status are set to GNTST_okay (i.e., both mapping
> > > operations are successful).  However, as also noted above, there are
> > > cases where a grant mapping operation fails partially, breaking the
> > > assumption of the code excerpt above.
> > >=20
> > > The aforementioned causes map->live_grants to be incorrectly set. In
> > > some cases, all of the map_ops mappings fail, but all of the kmap_ops
> > > mappings succeed, meaning that live_grants may remain zero. This in t=
urn
> > > makes it impossible to unmap the successfully grant-mapped pages poin=
ted
> > > to by kmap_ops, because unmap_grant_pages has the following snippet of
> > > code at its beginning:
> > >=20
> > >    if (atomic_read(&map->live_grants) =3D=3D 0)
> > >      return; /* Nothing to do */
> > >=20
> > > In other cases where only some of the map_ops mappings fail but all
> > > kmap_ops mappings succeed, live_grants is made positive, but when the
> > > user requests unmapping the grant-mapped pages, __unmap_grant_pages_d=
one
> > > will then make map->live_grants negative, because the latter function
> > > does not check if all of the pages that were requested to be unmapped
> > > were actually unmapped, and the same function unconditionally subtrac=
ts
> > > "data->count" (i.e., a value that can be greater than map->live_grant=
s)
> > > from map->live_grants. The side effects of a negative live_grants val=
ue
> > > have not been studied.
> > >=20
> > > The net effect of all of this is that grant references are leaked in =
one
> > > of the above conditions. In Qubes OS v4.1 (which uses Xen's grant
> > > mechanism extensively for X11 GUI isolation), this issue manifests
> > > itself with warning messages like the following to be printed out by =
the
> > > Linux kernel in the VM that had granted pages (that contain X11 GUI
> > > window data) to dom0: "g.e. 0x1234 still pending", especially after t=
he
> > > user rapidly resizes GUI VM windows (causing some grant-mapping
> > > operations to partially or completely fail, due to the fact that the =
VM
> > > unshares some of the pages as part of the window resizing, making the
> > > pages impossible to grant-map from dom0).
> > >=20
> > > The fix for this issue involves counting all successful map_ops and
> > > kmap_ops mappings separately, and then adding the sum to live_grants.
> > > During unmapping, only the number of successfully unmapped grants is
> > > subtracted from live_grants. The code is also modified to check for
> > > negative live_grants values after the subtraction and warn the user.
> > >=20
> > > Link: https://github.com/QubesOS/qubes-issues/issues/7631
> > > Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages=
()")
> >=20
> > Looks like this patch has been pretty buggy, sorry.  This is the second
> > time there has been a problem with it.  Thanks for the fix.
>=20
> Hi,
>=20
> No problem! :-) Debugging this issue and coming up with a fix was a
> nice challenge for me.

You=E2=80=99re welcome!  I=E2=80=99m glad you were able to do this.

> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
> > > ---
> > >=20
> > > Changes since v1:
> > > - To determine which unmap operations were successful, the previous
> > >    version of this patch set the "unmap_ops[i].status" and
> > >    "kunmap_ops[i].status" fields to the value "1" prior to passing th=
ese
> > >    data structures to the hypervisor. Instead of doing that, the code=
 now
> > >    checks whether the "handle" fields in the same data structures were
> > >    *not* set to "INVALID_GRANT_HANDLE". (Suggested by Juergen Gross.)
> > > ---
> > >   drivers/xen/gntdev.c | 22 +++++++++++++++++-----
> > >   1 file changed, 17 insertions(+), 5 deletions(-)
> > >=20
> > > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> > > index 84b143eef395..eb0586b9767d 100644
> > > --- a/drivers/xen/gntdev.c
> > > +++ b/drivers/xen/gntdev.c
> > > @@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_ma=
p *map)
> > >   	for (i =3D 0; i < map->count; i++) {
> > >   		if (map->map_ops[i].status =3D=3D GNTST_okay) {
> > >   			map->unmap_ops[i].handle =3D map->map_ops[i].handle;
> > > -			if (!use_ptemod)
> > > -				alloced++;
> > > +			alloced++;
> > >   		} else if (!err)
> > >   			err =3D -EINVAL;
> > > @@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_ma=
p *map)
> > >   		if (use_ptemod) {
> > >   			if (map->kmap_ops[i].status =3D=3D GNTST_okay) {
> > > -				if (map->map_ops[i].status =3D=3D GNTST_okay)
> > > -					alloced++;
> > > +				alloced++;
> > >   				map->kunmap_ops[i].handle =3D map->kmap_ops[i].handle;
> > >   			} else if (!err)
> > >   				err =3D -EINVAL;
> > > @@ -394,8 +392,14 @@ static void __unmap_grant_pages_done(int result,
> > >   	unsigned int i;
> > >   	struct gntdev_grant_map *map =3D data->data;
> > >   	unsigned int offset =3D data->unmap_ops - map->unmap_ops;
> > > +	int successful_unmaps =3D 0;
> > > +	int live_grants;
> > >   	for (i =3D 0; i < data->count; i++) {
> > > +		if (map->unmap_ops[offset + i].status =3D=3D GNTST_okay &&
> > > +		    map->unmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE)
> > > +			successful_unmaps++;
> > > +
> > >   		WARN_ON(map->unmap_ops[offset + i].status !=3D GNTST_okay &&
> > >   			map->unmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE);
> > >   		pr_debug("unmap handle=3D%d st=3D%d\n",
> > > @@ -403,6 +407,10 @@ static void __unmap_grant_pages_done(int result,
> > >   			map->unmap_ops[offset+i].status);
> > >   		map->unmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE;
> > >   		if (use_ptemod) {
> > > +			if (map->kunmap_ops[offset + i].status =3D=3D GNTST_okay &&
> > > +			    map->kunmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE)
> > > +				successful_unmaps++;
> > > +
> > >   			WARN_ON(map->kunmap_ops[offset + i].status !=3D GNTST_okay &&
> > >   				map->kunmap_ops[offset + i].handle !=3D INVALID_GRANT_HANDLE);
> > >   			pr_debug("kunmap handle=3D%u st=3D%d\n",
> > > @@ -411,11 +419,15 @@ static void __unmap_grant_pages_done(int result,
> > >   			map->kunmap_ops[offset+i].handle =3D INVALID_GRANT_HANDLE;
> > >   		}
> > >   	}
> > > +
> > >   	/*
> > >   	 * Decrease the live-grant counter.  This must happen after the lo=
op to
> > >   	 * prevent premature reuse of the grants by gnttab_mmap().
> > >   	 */
> > > -	atomic_sub(data->count, &map->live_grants);
> > > +	live_grants =3D atomic_sub_return(successful_unmaps, &map->live_gra=
nts);
> > > +	if (WARN_ON(live_grants < 0))
> > > +		pr_err("%s: live_grants became negative (%d) after unmapping %d pa=
ges!\n",
> > > +		       __func__, live_grants, successful_unmaps);
> > >   	/* Release reference taken by __unmap_grant_pages */
> > >   	gntdev_put_map(NULL, map);
> > > --=20
> > > 2.37.3
> >=20
> > Is there a possibility that live_grants could overflow, as it is now
> > set to a value twice as large as what it had been previously?
>=20
> Good point! My answer in summary: I think that the code could be improved,
> but with reasonable values for the "limit" module parameter, there should
> not be issues.
>=20
> Grant mappings are set up via ioctl calls, and the structure field that
> holds the number of grant references has u32 type:
>=20
> (Quoting from kernel v5.15.71 for convenience)
> include/uapi/xen/gntdev.h
> =3D=3D=3D 8< =3D=3D=3D
> struct ioctl_gntdev_map_grant_ref {
> 	/* IN parameters */
> 	/* The number of grants to be mapped. */
> 	__u32 count;
> =3D=3D=3D >8 =3D=3D=3D
>=20
> However, the number of grant references is further limited in the actual
> ioctl handler function gntdev_ioctl_map_grant_ref(), which calls
> gntdev_test_page_count() to ensure that the number of granted pages
> requested to be mapped does not exceed "limit". "limit" defaults to 64K,
> which should be okay to use with an atomic_t type (i.e., a 32-bit signed
> integer type) like "live_grants", assuming that the system administrator
> does not go overboard and set "limit" to a very large value:
>=20
> drivers/xen/gntdev.c
> =3D=3D=3D 8< =3D=3D=3D
> static unsigned int limit =3D 64*1024;
> module_param(limit, uint, 0644);
> MODULE_PARM_DESC(limit,
> 	"Maximum number of grants that may be mapped by one mapping request");
>=20
> /* trimmed */
>=20
> bool gntdev_test_page_count(unsigned int count)
> {
> 	return !count || count > limit;
> }
>=20
> /* trimmed */
>=20
> static long gntdev_ioctl_map_grant_ref(struct gntdev_priv *priv,
> 				       struct ioctl_gntdev_map_grant_ref __user *u)
> {
> 	/* trimmed */
>=20
> 	pr_debug("priv %p, add %d\n", priv, op.count);
> 	if (unlikely(gntdev_test_page_count(op.count)))
> 		return -EINVAL;
>=20
> 	/* trimmed */
> }
> =3D=3D=3D >8 =3D=3D=3D
>=20
> To be fair, the "count" field of the gndev_grant_map structure is a signed
> integer, so very large values of count could overflow live_grants, as
> live_grants needs to accommodate values up to and including 2*count.

Could this be replaced by an unsigned and/or 64-bit integer?
Alternatively, one could use module_param_cb and param_set_uint_minmax
to enforce that the limit is something reasonable.  That said, one needs
almost 8TiB to trigger this problem, so while it ought to be fixed it
isn=E2=80=99t a huge deal.  Certainly should not block getting this merged.

> drivers/xen/gntdev-common.h
> =3D=3D=3D 8< =3D=3D=3D
> struct gntdev_grant_map {
> 	atomic_t in_use;
> 	struct mmu_interval_notifier notifier;
> 	bool notifier_init;
> 	struct list_head next;
> 	int index;
> 	int count;
> 	/* trimmed */
> }
> =3D=3D=3D >8 =3D=3D=3D
>=20
> > If not, you can add:
> >=20
> > Acked-by: Demi Marie Obenour <demi@invisiblethingslab.com>
>=20
> Thank you! I hope that the explanation and rationale above are satisfacto=
ry.
> Please let me know what you think.

They are indeed.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--cyzhu7rkdfkdzg5W
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM7kbkACgkQsoi1X/+c
IsEGVw//QnqEuYP0GFBlmXL0SIvtd1fK6TGdEUcdBmAuYKt82XvCiL6zfoGrF9Uo
VDY9CQLI9mUx5lWZeRo9sYLjU9cKNW6vzVn9nvsGEddB8LGuTeLSGKknU7T6Q2RM
oYYWyiyWZUFLoqC3iMpUx7TXBs/cpB2Q1K8B7PdHOdwfLhnZniKDIKArHjIQb/2q
UjzbltfulaDEZwKBSCbxfWq0nS5a7tT5p3+5kL4fpAc9mzcgCofZhLBz4UcH4IJl
U91Th2N/UD7dL5rA4FqRbt46VQI/5Ud81q87k7MRXH0eOe5m51LPGdaVTEwHWeUX
omDDj9uzNjrS+CfVyebaQA0L/mYmxw3gP3NkcDMKlGQhSC+6IiXolYXwXta/ppRq
MtTjA2XDbi0BigDLsTUNhuy4h/eQjdve6jm0Frl3K3uNf0GoSTfgGoY0FwP3EPUd
mOjEHM9XLA6VahQc/Hz6lDvUJgLIgCxn/T2GOs4thVVIGRhuwAaQ7hkiLsaiPSp2
rpYaTwb8TwTf9eiBya5aCWEV63nQC8C7aXIKgwtLNxyPxeZ/GcycY0UJRn8mZeEN
6nunp6anKWTqcT5A0v+CPuPbMF5GzxIKx8248PjOckj73C+XAEAYzfImkxfxaMY/
yWV4pS8Ybvvhh49GZFpSnLMDKtdMjXofd3rAbiY4pwkriAoL29U=
=GO41
-----END PGP SIGNATURE-----

--cyzhu7rkdfkdzg5W--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 03:29:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 03:29:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415141.659641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofYcS-0007oU-AK; Tue, 04 Oct 2022 03:29:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415141.659641; Tue, 04 Oct 2022 03:29:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofYcS-0007oN-5O; Tue, 04 Oct 2022 03:29:20 +0000
Received: by outflank-mailman (input) for mailman id 415141;
 Tue, 04 Oct 2022 03:29:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofYcQ-0007oD-Up; Tue, 04 Oct 2022 03:29:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofYcQ-0007rW-RR; Tue, 04 Oct 2022 03:29:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofYcQ-0002ST-Bq; Tue, 04 Oct 2022 03:29:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofYcQ-0003gC-98; Tue, 04 Oct 2022 03:29:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KdkY6FMD1AZjUxmjRQBAy7n+8qJY5OgJp7+tkvu/fjQ=; b=Wa8ohPTFMhL4WJdFUFpX5jII86
	M6SKaVwA/SZUTLxVh429EusuXeWVtE+cDPevTkLjGRIQ1EGAv3VrLWf415Ej0XcypugAkbr+j590y
	IXZMUaDG0T+4Da5P+Kxus+z3Uov7cxABIfQLpg/b9MdZnWfdSAN1tzcUlmhdOPUFfuPc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173410-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173410: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3161231abcb461314b205337fbd0530c7ead1696
X-Osstest-Versions-That:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 03:29:18 +0000

flight 173410 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173410/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3161231abcb461314b205337fbd0530c7ead1696
baseline version:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124

Last test of basis   173387  2022-09-30 14:01:51 Z    3 days
Testing same since   173410  2022-10-04 01:01:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <stefano.stabellini@amd.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1666086b00..3161231abc  3161231abcb461314b205337fbd0530c7ead1696 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 04:22:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 04:22:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415153.659651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofZRf-0005Ub-WB; Tue, 04 Oct 2022 04:22:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415153.659651; Tue, 04 Oct 2022 04:22:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofZRf-0005UU-T5; Tue, 04 Oct 2022 04:22:15 +0000
Received: by outflank-mailman (input) for mailman id 415153;
 Tue, 04 Oct 2022 04:22:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofZRf-0005UK-GH; Tue, 04 Oct 2022 04:22:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofZRf-0000Rx-Df; Tue, 04 Oct 2022 04:22:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofZRe-0005a3-TC; Tue, 04 Oct 2022 04:22:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofZRe-0000He-Se; Tue, 04 Oct 2022 04:22:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RajXK04nQ9ZUunkCGo6I4EVvf2qgddvfHDGjVxaH3wY=; b=GCvhtzo9Yv6qHy84rdnCwrDcRe
	hIbyz2cLGC6UPAsAuxlJFCd0Ud7VUxb0dLgO3o/g//fXkNV89tYbSa2tews70rRyjBiRBeI0Ovkbd
	0D/iTbe6TOli6mQorT2vkMLTrQzxXgIhgMrmYF0b8J7xAse20CatPhU2RoGjokxesvek=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173408-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173408: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745
X-Osstest-Versions-That:
    qemuu=c8de6ec63d766ca1998c5af468483ce912fdc0c2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 04:22:14 +0000

flight 173408 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173408/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173363

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173363
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173363
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173363
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173363
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173363
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173363
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173363
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173363
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745
baseline version:
 qemuu                c8de6ec63d766ca1998c5af468483ce912fdc0c2

Last test of basis   173363  2022-09-29 15:08:31 Z    4 days
Testing same since   173408  2022-10-03 22:08:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Arwed Meyer <arwed.meyer@gmx.de>
  Denis V. Lunev <den@openvz.org>
  Francisco Iglesias <francisco.iglesias@amd.com>
  Guoyi Tu <tugy@chinatelecom.cn>
  Hanna Reitz <hreitz@redhat.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Jens Axboe <axboe@kernel.dk>
  Jerome Forissier <jerome.forissier@linaro.org>
  Keith Busch <kbusch@kernel.org>
  Kevin Wolf <kwolf@redhat.com>
  Lev Kujawski <lkujaw@member.fsf.org>
  lu zhipeng <luzhipeng@cestc.cn>
  Maksim Davydov <davydov-max@yandex-team.ru>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   c8de6ec63d..efbf38d73e  efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 04:25:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 04:25:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415151.659662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofZVG-000679-H4; Tue, 04 Oct 2022 04:25:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415151.659662; Tue, 04 Oct 2022 04:25:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofZVG-000672-D6; Tue, 04 Oct 2022 04:25:58 +0000
Received: by outflank-mailman (input) for mailman id 415151;
 Tue, 04 Oct 2022 04:18:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gpva=2F=gmail.com=degakiran05@srs-se1.protection.inumbo.net>)
 id 1ofZOV-0004ba-2I
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 04:18:59 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aa5a90cf-439b-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 06:18:57 +0200 (CEST)
Received: by mail-wr1-x431.google.com with SMTP id w18so10701483wro.7
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 21:18:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa5a90cf-439b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject
         :date;
        bh=fNzeIGDDvx4Pqf/DNH0EYVFOQSwH+vSq1bIJXQJp+CQ=;
        b=liHQoh04KiwpktNtNBwfFQz4yCrpbysYCYltvvhk5AhE4hX+w4+fq7lvCmTHMClzbM
         FGATds0L9hquxXM98gE3N7dihSVAXjompEvx7zKTW7uUtHOThlT5TWuheEBObUeHR3zH
         WPFtJiHV7+RtD3hk/QStO8bJAmElpcmXyaNEod5RomAyR+TDVh/3mehmTk6M62vFGfOz
         dJwVIeB13uAkvMWfaNVRSE/JGnJstrS3U+kTQ7OhoeIGr9muaN9aUnFSagvj00bDl9k0
         MegRyW6afKw3OvbY1srm0PltOpV9NfkCWiOcmV+qfi1INl1wBGg8PmnERfFVT32Ggz6q
         E0Hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state
         :from:to:cc:subject:date;
        bh=fNzeIGDDvx4Pqf/DNH0EYVFOQSwH+vSq1bIJXQJp+CQ=;
        b=NA/kmevFfu/f3PqYPt52Qserp7doOQNYxA8RGgdGOZo4esgOXo9TsaqYk/uYT/1QN5
         prT7mRaxRGUK8aA6V3OxIlkLffDOrcG1JdP7d4yqdKUlxDj60erzpA1AVZFaRc6M2GDQ
         cEaAZpuPF7g2hraukGT/KqN9RNVA86SszUxZ399irZ+VxnczJhQ6ekzQC+OQPAaZN9xO
         lLdqRLYYHtux2HD7Ez8/O5Chy8oteudkxK6TQWQh4xRRUbuA+EtD/zVcOF+ehQY5Z/WT
         lzOtm8HiBBFeHr7IfPen9Evwla3bVmuOdKt8BvhvSowSy0sdbT7gMYySfOQ1RspHSivH
         gcqw==
X-Gm-Message-State: ACrzQf1H+5JhDBCa/0338SRb9cibg+1pth695+3Xn+fxcYnlHXAlfUQD
	yqzahZRnbvJfypI3VF1/48TbS2vWUKhMXkPVDB+CslwQWYM=
X-Google-Smtp-Source: AMsMyM6/vPXDKnheG1uZPDp6CCpVxGc1YD6dnjUoGJ9MjS8QzjQ7emygwysVmW4a+oLqrqVHCyQPkypuEOjmOaArAKo=
X-Received: by 2002:a05:6000:1c18:b0:22b:13e3:19d3 with SMTP id
 ba24-20020a0560001c1800b0022b13e319d3mr15178468wrb.699.1664857136725; Mon, 03
 Oct 2022 21:18:56 -0700 (PDT)
MIME-Version: 1.0
From: dega kiran <degakiran05@gmail.com>
Date: Tue, 4 Oct 2022 09:48:20 +0530
Message-ID: <CADY+DPLf10UtUWE7Y9zZvN0NRFkGtV7ah3dg8t4wYWrF=8R2LQ@mail.gmail.com>
Subject: Free Rtos porting on XEN
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, ulien Grall <julien@xen.org>
Content-Type: multipart/alternative; boundary="0000000000003c84b105ea2dc2d1"

--0000000000003c84b105ea2dc2d1
Content-Type: text/plain; charset="UTF-8"

Hi ,

I am trying to port FREERtos on XEN . But not getting any
concrete information for porting.

I am following https://github.com/GaloisInc/FreeRTOS-Xen

but getting a lot of errors.

Please Let me know how to follow the porting process.


Thank you,
Dega.

--0000000000003c84b105ea2dc2d1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi ,<div><br></div><div>I am trying to port FREERtos=C2=A0=
on XEN . But not getting any concrete=C2=A0information for porting.</div><d=
iv><br></div><div>I am following=C2=A0<a href=3D"https://github.com/GaloisI=
nc/FreeRTOS-Xen" target=3D"_blank" dir=3D"ltr" rel=3D"noopener nofollow nor=
eferrer" class=3D"gmail-oiM5sf" style=3D"text-decoration-line:none;backgrou=
nd:rgba(32,33,36,0.04);font-size:14px;margin:0px;padding:0px;vertical-align=
:baseline;font-family:Roboto,sans-serif;white-space:pre-wrap">https://githu=
b.com/GaloisInc/FreeRTOS-Xen</a></div><div><br></div><div>but getting a lot=
 of errors.</div><div><br></div><div>Please Let me know how to follow the p=
orting process.</div><div><br></div><div><br></div><div>Thank you,</div><di=
v>Dega.</div><div><br></div></div>

--0000000000003c84b105ea2dc2d1--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 05:02:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 05:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415170.659673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofa4Q-0002Kp-2X; Tue, 04 Oct 2022 05:02:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415170.659673; Tue, 04 Oct 2022 05:02:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofa4P-0002Ki-WE; Tue, 04 Oct 2022 05:02:18 +0000
Received: by outflank-mailman (input) for mailman id 415170;
 Tue, 04 Oct 2022 05:02:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Pza=2F=gmail.com=vsuneja63@srs-se1.protection.inumbo.net>)
 id 1ofa4P-0002Kc-3B
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 05:02:17 +0000
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com
 [2a00:1450:4864:20::62c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b6ef63fc-43a1-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 07:02:15 +0200 (CEST)
Received: by mail-ej1-x62c.google.com with SMTP id a26so26385755ejc.4
 for <xen-devel@lists.xenproject.org>; Mon, 03 Oct 2022 22:02:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6ef63fc-43a1-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=2if1KikwOZaKaAn2mub0ua210XEJB3mmN6ELIxdVr38=;
        b=IuxoB3qdqS/oKHcLZXuuvqD/DipHgsMMxkgVykHLcxXEvRC+w+CIzpDwBVbvp4xf++
         UIQ8D6k3idkfcbi2NN/wxJUpxjB1C60RBkOHgCj4l3ue+vEu9EiJX2Few1Y+aTM289ks
         fNzJyteUAWOGZ83GujJWa4CXm7hg8OEYCyCQ2Ro8F0VzQnKXquDT7JHUPHjtyctj1F6U
         VWkpxR4ZdHRgoc7ZYhiVK/WLSpveCNv2/+Q9J+etQ0v3Ikyh8xCGdjkPspFKMgLmJkgK
         pyiN/tjKwi2aBLyi7mSzxoSxuy25lcG0UmpHpzDu6s1K2RMwqIGpd2HIoJiReYypu1Df
         jTJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=2if1KikwOZaKaAn2mub0ua210XEJB3mmN6ELIxdVr38=;
        b=ALVyTC9DUlfolVWPDEdYAtD9sJktjAyvXnZ2mKE+o7Fu/QUGA9zmSuYgnqIb+6lOkw
         OjgTPHQkTCkykJkwl6SNDv5yfmEiSbhAMex+t49zkKfuB/UD4YCdIrWgYiGjepfGs4wo
         crcjsoa998234s/snlFQNLZ+tFXHYkltz07iA9wtChnP/YSppkHxKLc0n8t8X24JOxiF
         zzsak71qWwdx6D7RpvLomnUukIyshEg9YMwnBouxmOHWnCrUA6Y59FMNdEasceylSsTX
         d9R8z8GPstumSJqC37CGUvRFWC4MURlIyIFW9E9XtcJBWnhLFjqXj6qmfLTjsmWXmNWS
         2OVQ==
X-Gm-Message-State: ACrzQf3qgR4eNDqY+FOB4kypxpEckB89HvQzx0EIUcGvqH19PmqgWKTc
	FWT6NVFUT32EgUBRs9jX9U6JJwFmEZVIIhBLf3U=
X-Google-Smtp-Source: AMsMyM4zbgtd3FjSAc8BTyR9WEh1EzzLfUUxhMjkYDls/l5zDIM3I9y9S/+x1YFZAc/nigaRILM823iYw2NzDLWe9is=
X-Received: by 2002:a17:907:749:b0:78d:1d85:feba with SMTP id
 xc9-20020a170907074900b0078d1d85febamr113477ejb.241.1664859735259; Mon, 03
 Oct 2022 22:02:15 -0700 (PDT)
MIME-Version: 1.0
References: <CALAP8f91s0h0gjd_qsmJDz01SKdC8Rmut5KPiG-CKaov740m_Q@mail.gmail.com>
 <YytYuAcMh8WGDQTF@mattapan.m5p.com> <CALAP8f9+N4+Jk_hWh8XCc70g7xxbr7PTffE0By56TROOyS9rSg@mail.gmail.com>
 <CALAP8f8_TiDa4t9WbXtCf2erKwSv04y3HVv6ohKoU=geJwrp5Q@mail.gmail.com>
In-Reply-To: <CALAP8f8_TiDa4t9WbXtCf2erKwSv04y3HVv6ohKoU=geJwrp5Q@mail.gmail.com>
From: Vipul Suneja <vsuneja63@gmail.com>
Date: Tue, 4 Oct 2022 10:32:03 +0530
Message-ID: <CALAP8f9nM08m0GS5WTqrGjFcR3Ap7UfsqRc1CyUaVrChnmmdJQ@mail.gmail.com>
Subject: Re: How to do display sharing between guests or bring up guests display
To: Elliott Mitchell <ehem+xen@m5p.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Content-Type: multipart/alternative; boundary="0000000000001f015005ea2e5d53"

--0000000000001f015005ea2e5d53
Content-Type: text/plain; charset="UTF-8"

Hi All,

Any input on this issue or any pointers on SDL to enable display?
Looking forward to hearing from you.

Regards,
Vipul Kumar

On Thu, Sep 29, 2022 at 9:43 PM Vipul Suneja <vsuneja63@gmail.com> wrote:

> Hi Elliott,
>
> Thanks!
>
> Any input from your side on this issue will be really helpful.
> Looking forward to hearing from you asap.
>
> Regards,
> Vipul Kumar
>
> On Tue, Sep 27, 2022 at 11:47 PM Vipul Suneja <vsuneja63@gmail.com> wrote:
>
>> Hi Elliott,
>>
>> Thanks!
>>
>> As per the link you shared, VNC & SDL are two ways to get GUI display up
>> for guests. I am going through VNC & tried SDL, added below line in
>> guest1.cfg file.
>> *vfb = [ 'sdl=1' ]*
>> when creating guest machine by running command "*xl create -c
>> guest1.cfg" *then its throwing errors:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> *root@raspberrypi4-64:~/guest1# xl create -c guest1.cfgParsing config
>> from guest1.cfglibxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain
>> 3:error on QMP socket: Connection reset by peerlibxl: error:
>> libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP
>> connection to QEMUlibxl: error:
>> libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup
>> configs failed, rc=-26libxl: error:
>> libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did
>> not start: -26libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device
>> Model already exitedlibxl: error: libxl_domain.c:1183:libxl__destroy_domid:
>> Domain 3:Non-existant domainlibxl: error:
>> libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy
>> guestlibxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain
>> 3:Destruction of domain failed*
>>
>> It works absolutely fine & guest1 comes up if *vfb = [ 'sdl=1' ]* is not
>> included in the configuration file. Anything wrong with the statement
>> added or any other steps need to be followed for this? Looking after your
>> response asap.
>>
>> Regards,
>> Vipul Kumar
>>
>> On Thu, Sep 22, 2022 at 12:03 AM Elliott Mitchell <ehem+xen@m5p.com>
>> wrote:
>>
>>> On Wed, Sep 21, 2022 at 10:54:55PM +0530, Vipul Suneja wrote:
>>> > Now I have built a custom image with GUI & ported it as a
>>> guest2(DOMU2),
>>> > guest2 came up as a console & couldn't see the GUI screen(Display
>>> screen
>>> > connected to rpi4 via HDMI) coming up.
>>> >
>>> > Can you please guide me on display sharing or how to bring up guests
>>> > display?
>>>
>>> This has already been answered in several locations.  The first place to
>>> ask for help with the RP4 is their own forums.  Turns out the topic is
>>> well known:
>>>
>>> https://forums.raspberrypi.com/viewtopic.php?t=232323#p1775083
>>>
>>> (huh, their forum moved to the raspberrypi.com domain; they really need
>>> an entry for Xen in their other OSes area)
>>>
>>>
>>> --
>>> (\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
>>>  \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
>>>   \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
>>> 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
>>>
>>>
>>>

--0000000000001f015005ea2e5d53
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi All,<div><br></div><div>Any input on this issue or any =
pointers on SDL to enable display? Looking=C2=A0forward to hearing from you=
.=C2=A0</div><div><br></div><div>Regards,</div><div>Vipul Kumar</div></div>=
<br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu=
, Sep 29, 2022 at 9:43 PM Vipul Suneja &lt;<a href=3D"mailto:vsuneja63@gmai=
l.com">vsuneja63@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr">Hi Elliott,<div><br></div><div>T=
hanks!</div><div><br></div><div>Any input from your side on this issue will=
 be really helpful. Looking=C2=A0forward to hearing from you asap.</div><di=
v><br></div><div>Regards,</div><div>Vipul Kumar</div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep 27, 2022=
 at 11:47 PM Vipul Suneja &lt;<a href=3D"mailto:vsuneja63@gmail.com" target=
=3D"_blank">vsuneja63@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Elliott,<div><br></div=
><div>Thanks!</div><div><br></div><div>As per the link you shared, VNC &amp=
; SDL are two ways to get GUI display up for guests. I am going through VNC=
 &amp; tried SDL, added below line in guest1.cfg file.</div><div><b>vfb =3D=
 [ &#39;sdl=3D1&#39; ]</b></div><div>when creating guest machine by running=
 command &quot;<b>xl create -c guest1.cfg&quot;=C2=A0</b>then its throwing =
errors:</div><div><br></div><div><b><i>root@raspberrypi4-64:~/guest1# xl cr=
eate -c guest1.cfg<br>Parsing config from guest1.cfg<br>libxl: error: libxl=
_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection re=
set by peer<br>libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:=
Error happened with the QMP connection to QEMU<br>libxl: error: libxl_dm.c:=
3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed,=
 rc=3D-26<br>libxl: error: libxl_create.c:1867:domcreate_devmodel_started: =
Domain 3:device model did not start: -26<br>libxl: error: libxl_aoutils.c:6=
46:libxl__kill_xs_path: Device Model already exited<br>libxl: error: libxl_=
domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain<br>libxl: =
error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to dest=
roy guest<br>libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:=
Destruction of domain failed</i></b><br></div><div><b><i><br></i></b></div>=
<div>It works absolutely fine &amp; guest1 comes up if=C2=A0<b>vfb =3D [ &#=
39;sdl=3D1&#39; ]</b>=C2=A0is not included in the configuration file. Anyth=
ing wrong with the statement=C2=A0</div><div>added or any other steps need =
to be followed for this? Looking after your response asap.</div><div><br></=
div><div>Regards,</div><div>Vipul Kumar</div></div><br><div class=3D"gmail_=
quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Sep 22, 2022 at 12:03 =
AM Elliott Mitchell &lt;<a href=3D"mailto:ehem%2Bxen@m5p.com" target=3D"_bl=
ank">ehem+xen@m5p.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex">On Wed, Sep 21, 2022 at 10:54:55PM +0530, Vipul Suneja=
 wrote:<br>
&gt; Now I have built a custom image with GUI &amp; ported it as a guest2(D=
OMU2),<br>
&gt; guest2 came up as a console &amp; couldn&#39;t see the GUI screen(Disp=
lay screen<br>
&gt; connected to rpi4 via HDMI) coming up.<br>
&gt; <br>
&gt; Can you please guide me on display sharing or how to bring up guests<b=
r>
&gt; display?<br>
<br>
This has already been answered in several locations.=C2=A0 The first place =
to<br>
ask for help with the RP4 is their own forums.=C2=A0 Turns out the topic is=
<br>
well known:<br>
<br>
<a href=3D"https://forums.raspberrypi.com/viewtopic.php?t=3D232323#p1775083=
" rel=3D"noreferrer" target=3D"_blank">https://forums.raspberrypi.com/viewt=
opic.php?t=3D232323#p1775083</a><br>
<br>
(huh, their forum moved to the <a href=3D"http://raspberrypi.com" rel=3D"no=
referrer" target=3D"_blank">raspberrypi.com</a> domain; they really need<br=
>
an entry for Xen in their other OSes area)<br>
<br>
<br>
-- <br>
(\___(\___(\______=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --=3D&gt; 8-) EHM &lt;=
=3D--=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ______/)___/)___/)<br>
=C2=A0\BS (=C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"mail=
to:ehem%2Bsigmsg@m5p.com" target=3D"_blank">ehem+sigmsg@m5p.com</a>=C2=A0 P=
GP 87145445=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 )=C2=A0 =C2=A0/=
<br>
=C2=A0 \_CS\=C2=A0 =C2=A0|=C2=A0 _____=C2=A0 -O #include &lt;stddisclaimer.=
h&gt; O-=C2=A0 =C2=A0_____=C2=A0 |=C2=A0 =C2=A0/=C2=A0 _/<br>
8A19\___\_|_/58D2 7E3D DDF4 7BA6 &lt;-PGP-&gt; 41D1 B375 37D0 8714\_|_/___/=
5445<br>
<br>
<br>
</blockquote></div>
</blockquote></div>
</blockquote></div>

--0000000000001f015005ea2e5d53--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 05:28:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 05:28:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415180.659684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofaTR-0004px-8I; Tue, 04 Oct 2022 05:28:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415180.659684; Tue, 04 Oct 2022 05:28:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofaTR-0004pq-5B; Tue, 04 Oct 2022 05:28:09 +0000
Received: by outflank-mailman (input) for mailman id 415180;
 Tue, 04 Oct 2022 05:28:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zFdy=2F=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1ofaTP-0004pk-E6
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 05:28:07 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 511fe64c-43a5-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 07:28:04 +0200 (CEST)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 2945RcoD063500
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 4 Oct 2022 01:27:44 -0400 (EDT) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 2945RcJE063499;
 Mon, 3 Oct 2022 22:27:38 -0700 (PDT) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 511fe64c-43a5-11ed-964a-05401a9f4f97
Date: Mon, 3 Oct 2022 22:27:38 -0700
From: Elliott Mitchell <ehem+xen@m5p.com>
To: Vipul Suneja <vsuneja63@gmail.com>
Cc: xen-devel@lists.xenproject.org,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: How to do display sharing between guests or bring up guests
 display
Message-ID: <YzvESmY9xBKaKq0W@mattapan.m5p.com>
References: <CALAP8f91s0h0gjd_qsmJDz01SKdC8Rmut5KPiG-CKaov740m_Q@mail.gmail.com>
 <YytYuAcMh8WGDQTF@mattapan.m5p.com>
 <CALAP8f9+N4+Jk_hWh8XCc70g7xxbr7PTffE0By56TROOyS9rSg@mail.gmail.com>
 <CALAP8f8_TiDa4t9WbXtCf2erKwSv04y3HVv6ohKoU=geJwrp5Q@mail.gmail.com>
 <CALAP8f9nM08m0GS5WTqrGjFcR3Ap7UfsqRc1CyUaVrChnmmdJQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALAP8f9nM08m0GS5WTqrGjFcR3Ap7UfsqRc1CyUaVrChnmmdJQ@mail.gmail.com>
X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.5
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

On Tue, Oct 04, 2022 at 10:32:03AM +0530, Vipul Suneja wrote:
> Any input on this issue or any pointers on SDL to enable display?
> Looking forward to hearing from you.

I suspect you want xen-users@lists.xenproject.org.
https://lists.xenproject.org/cgi-bin/mailman/listinfo/xen-users

xen-devel@ is when you need developer attention, whereas what you're
asking sounds like basic user setup questions.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445




From xen-devel-bounces@lists.xenproject.org Tue Oct 04 07:02:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 07:02:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415188.659695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofbwB-0005zV-Qf; Tue, 04 Oct 2022 07:01:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415188.659695; Tue, 04 Oct 2022 07:01:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofbwB-0005zO-Np; Tue, 04 Oct 2022 07:01:55 +0000
Received: by outflank-mailman (input) for mailman id 415188;
 Tue, 04 Oct 2022 07:01:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofbw9-0005zI-Ea
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 07:01:53 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60041.outbound.protection.outlook.com [40.107.6.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c034db9-43b2-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 09:01:51 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7837.eurprd04.prod.outlook.com (2603:10a6:102:ca::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 07:01:49 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 07:01:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c034db9-43b2-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NMsbFcHFPll3oO6QKDyF7G6VaTCzeoFhprvgaxNFBF0ADqisIwJ6N3GUV7UtNUERpIZ9j+7a3Aq6CbvjfEbKgQoGEzYYTp+058ZLoXWFBQ9IWOoGe0JAB0RN1Nhw5+87oFFzLtkQVo6clRQMs+ZDMnis7KlxHJXk/erLBXvlkkaFlBBXulxWO7NkSUEvphwxvtUWsa5s/sg+BIlIVosMXAUkFMw2EvBGen29Mv7Vc6cvNYv7Mi+mXszo3X7NykqgVNDaY/K5KnBBleLhTe+15yvgktDUp9D1K+Hx3WLunrTdIPJwI/1uvT09N+cYsAQ3laNyxOQUazHoKJW/W+y/OQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9rMCXh5lcyI/4KD223irbp/iwJHL0sSbEzfWQQ1Rnuo=;
 b=KvV8ErwcYrtF4VZi+EqelnmiHYoMyvQwaxXWxsFPUyP8mO+jJ9NQg8Ahf1dhHvT3IV6KlodjR6RaoL4u2SC7nAAwPqDPOq42gXDxYo9m4MJkTA7/Rd5DsadwKCQnnowIxoslS3PHC9omUq3P+OU6C2zc+fMUf7FDs6DNzGaEmsvf0SdQ8/vgY5frTelme650acauHBwinOh4GbzeGczzmLuGCDYtBPS0DLtvGZtd5+BPSU35RNhTOs+SDYdlw7/SJ7GNUFIASdzcfD0UxaKspXXUHnKAEFyYKyfrirUCEDl/o1JlH8L9QTJzkMxHNpRWAeJ5BO+WJGa7tWFeXfITng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9rMCXh5lcyI/4KD223irbp/iwJHL0sSbEzfWQQ1Rnuo=;
 b=hEGmAYRmu/kjlla3yG1MqXOHB6wY1zYhl0Nnf7dO858qarrfqiR0CYT8IyiunPbn9O/OOMhSRLFK/76AQiUy+zbc6h+8QOBGPKYQnu61XW9yVIm/7nUnun1IjKWZltLwH2wlTU2fML1lr0bGcF+MMN4H3ngh4D7HmNMaWiv/V5N+Rv0V16rpuw1tlMvTuh+WuWWkYBSezZZx29SwyOmcotIt9OpDy7aMm2wpVSM4/Ugh8FfS2sWOi8DGcEfVHlYAh7JtcPk+VKgKdepvEWr1xUvWD7nMTtxchAFl9jpubEA02L3hXLRrQUaPMyif6YAd4Jo/mqHkb9ywTpHWqTS75Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a8ee8082-5ee9-1073-987a-388ee2c10bc8@suse.com>
Date: Tue, 4 Oct 2022 09:01:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 0/2][XTF] build: suppress GNU ld 2.39 warnings
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f4f8dd4-cfbc-e2c2-4a5c-ef31acc4162b@suse.com>
 <bd57773b-77d0-8e69-69ad-d17b272996de@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bd57773b-77d0-8e69-69ad-d17b272996de@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7837:EE_
X-MS-Office365-Filtering-Correlation-Id: e00fa5b0-cc0a-4044-a588-08daa5d64f07
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1VAPhwzWWCHO3RPovIgiIQKT9RgKqVmm85uFlf/2TKgQXvXSh9Hu1CoK7mY2/PuJw9OGAkiIVC8uy/E3rnYVWOie7UniY4OjkXIx9Db3kw4JhuxYx298ESoxMNlqxq4xYVzH7DwNrO2AcgXU0nvhkPJijAD4tevelP0ddcnTlkRDT3wrH9gjxAl9hsKCnwg5GjsAGk+HJyhI/xBIFLa6SmDMfZ/PVqGBEZG3agEW2R7b08la3DgfQ/rt1kuk557J10keIE8jMzz5NfdxuBOYAXQgmvPJoEFT9JEGnEENLLdLethSP91GkEr64fagqHedAUXJTjhRWvlg8G0r8wvvbhtWQpGYgaD6Hv9ZT0K19VgXxEzv2I89ulUoe6cpaIhd30/xerbn3imay3ZdDh5j5CNURdnQ5cSw6801WNlnthK0A1XvNDbw3Cc92k6WQFxGRExddHp6b62oHfT0mgnfDE+b3/cUH3ol+JTl9GU6uRT+28Tu8v02m2zM9TzIwP2OQj9uLZGTdImVSDlDKfxlIzUMmyXQ3W3kIgfsNz8ulV8fo5HAtU2t67PM6MPCuQioPVNNaXr45zGjxBXHG+I3a2r8O7nRhJiy3wQTJsqylSzEa7VuP8iqh/8wsvKHOsVoJfiNp6O2JFwA5u69IYANMU1Jbzv9lHokSNvaD30GT2ZaHJXa7YLp/kj6CBShsUzpGoijSLAPRyvZIXnCZR8A6RslPZjb2WznOu+s+TvZ5ANsTsL/DV7/wJXYMyT+0iPlXGhdbRfZc0A1TVluhgzvULonV4XgAHmSFTL+VNJ1Mmk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199015)(6666004)(6506007)(53546011)(478600001)(6486002)(66946007)(66556008)(66476007)(8676002)(4326008)(36756003)(316002)(6916009)(38100700002)(31696002)(186003)(2616005)(26005)(6512007)(86362001)(83380400001)(41300700001)(5660300002)(2906002)(31686004)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWU2L3ZDZlhSREwzS2hpUWk3cjZDOXRndEVCWi9KbitNZmg1VU9xK1REZFNh?=
 =?utf-8?B?cHViUE5rRWVUalNsSzYrM2RvN0Y0d1JtVTdYUjFwTURFTmE3djVsWWVJcXNv?=
 =?utf-8?B?b1JCVTFZUEtqZmVWaW9IRzczZVRpZXZWeENwOWRidHQ5a1FtZUJYNjRrZ1dO?=
 =?utf-8?B?SzlMbE5KVWNjNlF1TW0zZWVhNnprNVgrQUJrU1JwWFdKWlBZYW5ONVdxdW5X?=
 =?utf-8?B?Q0kwM3JDSU8wSjdRSTJaNmJtSzJqZDZ1OWtEQ0o2LyszYnhhUEl0RWRxTkhN?=
 =?utf-8?B?ZGZ2Sk5YcUFwcXZoSEZFNmFmWUFpc04vTXVsc0hWM0ZPNWo4bnhSeW0xeEVm?=
 =?utf-8?B?Ykc0T2FhckpRdUtoM0tROGtTZ1NKMkFFeTh2WUYxak1lZzIxZUZnZGkzSThE?=
 =?utf-8?B?UmpmeldJK3ViK3BmMkFPK25iZ0hMVVVRc0tMQjV1bWJsZFR0dmFLc3R2ZDJO?=
 =?utf-8?B?V3ZyTkU0bXdJNlhNeEE4RkxRNHoyLzdRRWFoU2g0eGlCVGNzY3pBZWNkeFMy?=
 =?utf-8?B?aGVORHBETExOblFaMU9sL2t6N1Q1OFlJSzVyZ3BKaXJIdlpGdEFWUjdocUZa?=
 =?utf-8?B?Mk5IZ3RPZjRvK1duSmtHLzAxekZKQm01U1YxdzBhSnB5TG1yWmdpUHlCMGFq?=
 =?utf-8?B?MnBlZi9QQ3JrMDNycFRjNGlpRFE4cG9RNDc0TForKzM2dUdsWk9uc0lhZ2tH?=
 =?utf-8?B?Q28vbG5LNkZxSzcwdzZmRWp5eGhac1Zkdko0bXk2azE1dnB6ZkIxV0VZM3di?=
 =?utf-8?B?MzcyUUFDUFBjbVZXTThPVU8yY3FOZFBrN0pVdTZGcjlZT2R0VmcyRW5YNVpD?=
 =?utf-8?B?cmpwSmZNSEpDWmVnNlkzM2k3bU5vRkRzK2tCT3kvK1NRajhUNjJWRkk2UDc4?=
 =?utf-8?B?WExFUDN0TkREUW8xcFBWRGNtd29oUDAxUk0xUmVqUmtVTGZwNWViTkNiZTZS?=
 =?utf-8?B?eHdrRmUxZTN5WTkvT1Y3WUFicDcrWUdyUmZMN2tORTRiajRiSlpxKzFycm5E?=
 =?utf-8?B?WFdBMnhNYUdXVWt4YVRUQmp0WWNBSlhFRzVzK0FMV2tWV1RrMWFnQlpNaStn?=
 =?utf-8?B?Umo5TFJabEhoclZtUmxtcHVmelBRdkgvcjhwVVA1bEFhcStRS0JTV2lTVmtI?=
 =?utf-8?B?RFBwSlEycVpveUtwS1ZWMlVsTGtkNGlIM04wR3MzaStoc2dtdExiWkNpNGJF?=
 =?utf-8?B?ZkNzclZrV2hsUU5na2pKeXlOQk9sOVJaVklhRlFpdWJxSDR6SkJlczhxSnNz?=
 =?utf-8?B?Q0RNaWJJQ0NVbHhjQVJ1ZndZZyt3SmgvZWNHbHBjS1VITkx3dVlUeVhNSjF2?=
 =?utf-8?B?aWRIcXVGSTBFek9GR1B1bk9EMGRhVmNtWlpTMlRxbjRiaWdUcDVWbGI3MVhz?=
 =?utf-8?B?aG5tdkNUV0xKRGJzY1IwU0U1MVZZaDYva0QyODdJMFVGQThIcXZHRVNSbDNk?=
 =?utf-8?B?ZXJWRVNFY0JEMFZaSnRzVGFLWHlPNHp1cVpUSVFRREpFcjhGTU1EQ0wvcXg1?=
 =?utf-8?B?dk04WjRTN2FEZUh3SjgzemlsSnhGQW8zTXZ0UlRiQVVWNXlNWDl4cm9jY3la?=
 =?utf-8?B?aThtL1hvUnhnaGx2NFZndTJmTGFtaEhveExDbEFqMDFRTDd5bDg1TVIyK3VY?=
 =?utf-8?B?MVBSMXllR1c0THBQbnpYZW0xbDhCMEg4RGxVZHJWVkxzU1V5b2NYL1d4dFVQ?=
 =?utf-8?B?MXYwTFpEVnltd3Z3S1gzWDJ6aGR4eW1GazREUGF0MHJjcGZCQkcxYzhnRUdS?=
 =?utf-8?B?T01nKzZXQlNBWHJTazdzRnQyUG9aMnRrZ1UrWFZUaG9Dak9ZcjAvWFkrbFFp?=
 =?utf-8?B?TzVJR2xXQlI1REw3Q1pkNUFsc0htbW5PMElPaWkxUElRNWpiSDZzcTVWNE1u?=
 =?utf-8?B?UGwrTTc0Z2k0UjdtVjVLNENyQUxEaUtVckJ1TFY4cE5yQ3NnV0xjcTg4Mnk1?=
 =?utf-8?B?Y3dhdmljZVBtZ1lSS2FKdnN2UlBITE40c1hDWTRCK015ZkdVS2l3UEpPNzB4?=
 =?utf-8?B?clU5N0tkRkpzVXM0RGNlRlZ1L2hLblRNK1hiWDZ3STU5NDBwMzZlc0dFUHhu?=
 =?utf-8?B?S05WbEU4SnVKRmJtbkxrMjB2TVVpN1F1N21lSjR1RnZ2bzdsM3dTaEhSVGNN?=
 =?utf-8?Q?N2KWVroBa9zgtnUo4xX2y7s+m?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e00fa5b0-cc0a-4044-a588-08daa5d64f07
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 07:01:49.5238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6C5ujYEu1kSUkXVbxWQFKXYnc5V5724lYUFVNenGbiZjpP/yqiScw0P5bkdw/YTNKQOojqDFg7sHCXCSGymWsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7837

On 03.10.2022 15:44, Andrew Cooper wrote:
> On 29/09/2022 11:03, Jan Beulich wrote:
>> Like done previously for the hypervisor and elsewhere.
>>
>> 1: suppress GNU ld 2.39 warning about RWX load segments
>> 2: silence GNU ld 2.39 warning about executable stacks
> 
> I've taken these, and dropped the `-no-pie`, but there's something else too.
> 
> $readelf -Wa tests/example/test-hvm64-example
> ...
> 
> No version information found in this file.
> 
> Displaying notes found in: .note
>   Owner                Data size     Description
>   GNU                  0x00000020    NT_GNU_PROPERTY_TYPE_0         
> Properties: x86 feature used: x86, <corrupt type (0) datasz: 0xc0010002>
> 
> readelf: Warning: note with invalid namesz and/or descsz found at offset
> 0x30
> readelf: Warning:  type: 0x12, namesize: 0x00000004, descsize:
> 0x00000004, alignment: 8
> 
> 
> It's only hvm64 which reads as corrupt, so I think there's some
> collateral damage with the conversion between ELF64 and ELF32.

Iirc there was a binary-incompatible change (accompanying an
incompatible change to the ELF spec) to how notes are generated /
processed for 64-bit objects (some hand waving involved here, as
this did happen quite a while back). I assume the .note section(s)
will need converting (to insert / remove padding) in the course of
converting between ELF32 and ELF64.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:05:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:05:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415199.659706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofcvA-00048n-OD; Tue, 04 Oct 2022 08:04:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415199.659706; Tue, 04 Oct 2022 08:04:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofcvA-00048g-Lf; Tue, 04 Oct 2022 08:04:56 +0000
Received: by outflank-mailman (input) for mailman id 415199;
 Tue, 04 Oct 2022 08:04:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofcv8-00048a-QE
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:04:55 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3a364d80-43bb-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 10:04:53 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 08:04:51 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 08:04:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a364d80-43bb-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oftjpAYp+Q9GuUVgn4tsj4293hGyomNfHKGiVgNxzZE/MO07T4ulEXqt3s+YlTYQ1aS/svRM/enPTSqhd40w0pWkin5tuAed3EbY4qNk4HULH52SXXnK5OzIOZhOOFSthbXhTUSilf4Nr0BlTGdQJOj4JKSkMYyktuhZmR4WMfFNVdz/amTOdAL7ijxVZGfnDx3f+jYRCrLDekxGXrLlyHHqL0OCgt3OS3SijsELn0jCCtqicyg+sCQoI2WfHrYu904FpIhhEoC5Scb00NpFY0YiPctmSVcJNZ080NjDQl7ak3i/ad2cvfe4cU27K1s8IAmua3ZQAeGGPw6C8O5k8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PJfDgo1stwc+B/8QrVp+aOsZxzWQCQsFoyG42hsukcs=;
 b=TYwEOAV77smVgQgkr4jVszNlcjvZ76KzQM5wmF0MhH8eV82ChsJ6p/9lI/xhrI/jRaTdABy5hkhmIy3Cs9pw5Qod0yqGlvRk8TcnACtzzYPmhwhdxENKijii5Co754uinKI34AHtdAjYLHK0P7GYG+++rZcqDQPRhZMDuDYhn0+sRROUH4AKtg8b16KL68Fkl2FJkWKcE3VHT+mRsa6LRMg0SwN4XpNYcUF3H9Ivtzv9EJug8BSi9+cIhpRFNwENA6na+veByyA/xPF6g/AM2Uf3MYvJGqqjot5vXVmiwqHQI7n26IhM5gEyrM8BjJ1sFLPjnJnSPcwx/KkwEFV+TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PJfDgo1stwc+B/8QrVp+aOsZxzWQCQsFoyG42hsukcs=;
 b=ZKAEmVksfq2HhrTRkgHzpyVfq67FhoEozPbILAGAXshLxCBwfD9THeSg5gRB2vgOz0Qixb7iowNgaQzudaLctiYLQMtIaydO9SJHKvEZcKwZ2Lt+rexCRK1bDtpFiI/dX4nMNRwzwmhyFp/1j/DQ9IRfARF0akow76GclcOqkW6Ut+fHjEAA8hTF6ymGT9vJiju+lKENqsSfVqwotB2VgQlQvFMXkZjbONlbJjPiZXLz0yRtofAiwbGsrfpsVnOKg8Ns7+TUhO8q1g74axbmF50TX30TAsocha1A4WXHevlHtfvRgrU0tnXfhmz2Zzfi72P102OroU63XWYkjfFAYw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7752d091-bdcc-88a3-6bd8-5fb5d830e33a@suse.com>
Date: Tue, 4 Oct 2022 10:04:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: x86 NUMA error on OSSTest box
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Henry Wang <Henry.Wang@arm.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <5dba58e7-491c-d396-ea1c-de03dc0053bd@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5dba58e7-491c-d396-ea1c-de03dc0053bd@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9319:EE_
X-MS-Office365-Filtering-Correlation-Id: 4a40040a-b02e-47fd-61ba-08daa5df1cd1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aaXdsK1aNq8En8N/THorALU6R4CRE29CmdvPbK8jiWi8Om4PJsxgepxHlgSke2mYeUJE6YrNa+1NdQit7cJJZtakKHtpmVeT1AThSpO8Dns1MmpbtnGJpeqfj1dMtvOFmNWVgdtKwuiLJxb7JvTqWjP6iMzG9cejXi5cGToryywjoz6qa0afErqFRf5+MqLJz+BzqY3l2sv2MkXOOCQPGu4NIaS4xURUi3lRoA5+WZ5x+p9bbcHYL7tWlIoIOEoxcq+hfaT/8SCYUG3FAw4LvO2V+nvA71gJso9We6SRipTSHNbEkXmw6awSb3U2+Ej4ZNoSmT195mz/5qZ7QKcgwRas+RKFBS9KcJ3pmZH9V6C0K8pcocNcMJmj5tCe3u1C3L0p44R1r6olBKCWbpYLgaObgDDVfjDL9/fN9JkE1y6sZ4DsG2pyIjsCXJ5pc78wv7WO3P0GLxOjuyOU6QdYR/uaz5eAB6C5mZzv1kwjLr/ZmhkXpybdXmpr5tfh6JKBRH2APqhy0sPXe1ny09HgInE4bynhuhHlknP3TOkdGKWCgf+WTrA4/0FRslSpE3djSopJIFf6gT7NWEgZgSgoY5eeAMmnlM+GA8OTj+p3MvVnICrrrjBCtwwQMGQoHw5JVnss/9mrc/bCT9ur4VdLeqAbX1So+G5rzeHYD/0Qfqbp/PUw0fCoHBrqR1ymItqP1XcgxUpR6BhAc3U/wEqYUoCaV81EnwzY956kWKhe2Bw3KAdBd+bp473ru0iHNxdvHCx/GH54PAdPKbQGBJ1lBwLFYwU6TR0fT2Jd9M5t2fs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(66946007)(4326008)(6916009)(38100700002)(478600001)(316002)(2906002)(31696002)(8676002)(66476007)(6486002)(66556008)(54906003)(86362001)(83380400001)(41300700001)(53546011)(186003)(5660300002)(2616005)(8936002)(31686004)(6506007)(36756003)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bmlSNjU2MjB3WlBmek1hRFk2eUYxQmJuUzl5akkrdDFyczN5MldMZ1ZQWW05?=
 =?utf-8?B?QWRxMjNkVi9leE1LNlQwYVVMVWozaFVPbnMzeWMwL29ld0dsejFYQnROT2Er?=
 =?utf-8?B?VGMyMU5vbXhwQ2w2eWJCVDJxRWwydlhQZmtUc1ZyaW9JK0VWcnNxWGlBNmVm?=
 =?utf-8?B?ZU9TQmRJMGdEc0R0aHdQSFUvOHZLclpHc1NCdDkrdithZVhObUt5Y2p4OU9w?=
 =?utf-8?B?d0RNOU5EWmV6Zm52N2lSYnh3Vk5uZWpOMGd1NE1mMXNRQkdCRVY0Y3ZZNjdO?=
 =?utf-8?B?WThvY29iQU5FMW1rMFU2R2pxcGZkQTNDaThpTjZ6MVJRRmhzRGRyVzVwZklT?=
 =?utf-8?B?ZkVqT1hFMkZBdkhaaFhpTGhHQkdXVUR4RHBaU1Vib3doWXhZdWcwZ2FIVTdY?=
 =?utf-8?B?ZzlhdWs4NWJBdHkzNHBoeVpHTS90YU1MMGFXN3dvck9HeDVuMFpKb1E5b3Fu?=
 =?utf-8?B?ZUZVSUVXTGVjRVZOT3V3endFeFU5TlQ5T05LdGJJNUcrejE3c3UyWFFidU5k?=
 =?utf-8?B?MUVMR1h5cGhXV0ozZXg1S3BXZ2JGdE1DbFQ5TVd3RnJzaUFoaDZ5TEl3NWRO?=
 =?utf-8?B?Yjd6SkZucUF0ZXFyYVBtVXRsSlFoaURXUFNUdmVqVzdadUZyaUg3YUw5bnhW?=
 =?utf-8?B?TVhXUnZhRDl2akd2VlV2bVN6alFTeURGMTNOU1c3Vk41czJFK3FnL1l5dTVs?=
 =?utf-8?B?VUhzaitJWFRDUXpvNmdPNjN2aWVYWE5lZzhiNURMTlR3U1RwekU2eFY5SXBn?=
 =?utf-8?B?Zm8zRndKamNFQjI5Z0tVd3M3T3VXSDVSb0hCWk5EcEVvNndxU2NpK28rUVVG?=
 =?utf-8?B?Rnh5eTZrdkh3cGNZWU4zREtFRzg4dnZ1STJlREs1VngyS0VWdis1ZmF0cTl6?=
 =?utf-8?B?UmVYTU0wTHU2WVc4SWozZUdPQkNqdDMyYXMwWEYvTDMzQUsyUTJsWlNRQy9i?=
 =?utf-8?B?SjFLSStlcktpbFFWMHQydFZKYVpmU0xMZ1d6L0VRZHZKR2c3SEo1VDZtbGs1?=
 =?utf-8?B?dytxSlZQaTVmWlVMRXZmVHBhcTlqZnJGNGd4cWtXejNvWjZPL0dMNm5idVdr?=
 =?utf-8?B?V2Q0TDBrOUhoQ2xzSDFKQ0FWVmlGT3NBd04xYmpRVkovVVVKTlpPMjVmVTll?=
 =?utf-8?B?VVZGS1Z0SXRBbE1RQWNVMnRJdFJ0azBGTDVFWkpwQ0lSTmlmWnFsUXBSU1Zp?=
 =?utf-8?B?Z0hBdGNCdDN3ZVBrN0E2WEZhbnE2SElOZlI5a21ER3JUOHNMZzdiRy92QzFk?=
 =?utf-8?B?dXZJUFd5a2JiR0tkM2U0UUJPN2tNOU9aR3I3Y2VETHR5eXowT2V5RDMxUTU4?=
 =?utf-8?B?S3FGSk5rdWRmdWNha0NocENPZ09PVjZqU3F3a0FCZmdMa0pKS2phczhRWE1u?=
 =?utf-8?B?THpBWlFXSmZEb2VycTJxSzlMUjNqRXUwMjEzT2VUMnJ0NERGZWJPY29mU2dE?=
 =?utf-8?B?MzF3bFU2dGdJRmxoNDdyMXFKeGJSV09RUC9OeHloRmZzZWtVOExQMWZlL1JU?=
 =?utf-8?B?b0hGNlhSWDFLaU10MUgvVVBsMzZod3VTcW15eUNyazJOZUdTYllneHNxUVl5?=
 =?utf-8?B?YUM3SFZqaVBOemV3aFp5UHZSZkFZUEZaeXhqRG5kdzR0TnM0cXhNenlYSTg2?=
 =?utf-8?B?aDVqd0Zub2IrVmF1TXdmTTRPVU9tUS9McmRMSUJPV3pvbFZldEE2KzRzSDEx?=
 =?utf-8?B?NTBjYmt4ZDhpVTYrcnNTOWs1MHcxRzFOMkpUQzBYcWxZVUNEQ3pXS2V4akdn?=
 =?utf-8?B?aXNFY0hYNVpQMUtuUjVnR01FZ0doaGx0QWFRTTVhVWVFMStqRWJmRUtBaVNK?=
 =?utf-8?B?QlFzRlliT0llRUdSeHN0YktuSVFoUTdhT1VpSjJ4RVpzYncwUzRUNExRMm1p?=
 =?utf-8?B?RzJMelFFc0lMN29zc2pqSWQ2eElDS0I1WkJiRkRvSWlNaFlnWkkzTWhXYmw1?=
 =?utf-8?B?ODJIbHIxSGlRbGw4dG5icnZROHNETnpnaVA3OFJsZ0RvYWVGQmxYemQvelU2?=
 =?utf-8?B?MS9JS0FZL2Zwc0YxaStuTTZEWitQdFdFWmZ1ZHlLRUhSbS8xQlhGT0dmN01W?=
 =?utf-8?B?dXhtMVRtMWhMYkxjSFN5a01NK09jOGJyMExDa0l5SHMwS3FNWnpwVnZRSGZx?=
 =?utf-8?Q?PIguaHnfWfn6sbs354f2M6mF1?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a40040a-b02e-47fd-61ba-08daa5df1cd1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 08:04:50.8308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nW6ZJ0HMZg6O9hdvD0AGZymamrMrwbe9P6/5Je/MtoSZljcDvoqRIpidwHn4hQwd7ftDE1vCGWFv8tfH6DtBVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319

On 03.10.2022 23:21, Andrew Cooper wrote:
> While working on another issue, I spotted this:
> 
> (XEN) ACPI: EINJ 6CB9D638, 0150 (r1 ORACLE     X7-2 41060300 INTL        1)
> (XEN) System RAM: 32429MB (33208204kB)
> (XEN) SRAT: Node 0 PXM 0 [0000000000000000, 000000007fffffff]
> (XEN) SRAT: Node 0 PXM 0 [0000000100000000, 000000047fffffff]
> (XEN) SRAT: Node 1 PXM 1 [0000000480000000, 000000087fffffff]
> (XEN) NUMA: Using 19 for the hash shift.
> (XEN) Your memory is not aligned you need to rebuild your hypervisor
> with a bigger NODEMAPSIZE shift=19
> (XEN) SRAT: No NUMA node hash function found. Contact maintainer
> (XEN) SRAT: SRAT not used.
> (XEN) No NUMA configuration found
> (XEN) Faking a node at 0000000000000000-0000000880000000
> (XEN) Domain heap initialised
> 
> on sabro0 in OSSTest on current staging.  I do not know if it's a recent
> regression or not.
> 
> The SRAT looks reasonable (in fact, far better than most I've seen). 
> Given no legitimate requirement for aligned memory that I'm aware of, I
> think Xen's behaviour here is buggy and wants resolving.

Judging from flight 173273's logs (on sabro1) this is a recent issue,
which then must result from one of my changes. There we simply have

Sep 22 01:54:39.843438 (XEN) SRAT: Node 0 PXM 0 [0000000000000000, 000000007fffffff]
Sep 22 01:54:39.915465 (XEN) SRAT: Node 0 PXM 0 [0000000100000000, 000000047fffffff]
Sep 22 01:54:39.927478 (XEN) SRAT: Node 1 PXM 1 [0000000480000000, 000000087fffffff]
Sep 22 01:54:39.927500 (XEN) NUMA: Using 19 for the hash shift.

For the moment I can't make the connection, as we still pick 19 for the
shift value. I'll take a closer look.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:06:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:06:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415206.659716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofcwI-0004gj-2Q; Tue, 04 Oct 2022 08:06:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415206.659716; Tue, 04 Oct 2022 08:06:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofcwH-0004gc-W7; Tue, 04 Oct 2022 08:06:05 +0000
Received: by outflank-mailman (input) for mailman id 415206;
 Tue, 04 Oct 2022 08:06:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofcwG-0004gQ-3l; Tue, 04 Oct 2022 08:06:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofcwF-0005Vo-VS; Tue, 04 Oct 2022 08:06:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofcwF-0000Sp-HG; Tue, 04 Oct 2022 08:06:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofcwF-0007ze-Gr; Tue, 04 Oct 2022 08:06:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yn2f63O0goeyZLSR5MS0cRkuJyfnPSEZkjRIfbTVqVE=; b=EQ/Ob/ZCDJmwpprNHQErCV1Nmo
	HUG8MI32xeQCsSJOcaQdKhwT6Aq+/xWnB82mBaXAKaeKtOv7XVtGpVzbHAf3OzhsmAy+HvAa/nghS
	7BgF7GbdKlqve/yKnC3znWAmGJs0f8zY3aQuoeGSVYOEQ5WjHK2QShhXp2aa5Iy2rpZI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173411-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173411: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=26b84401da8458c5cbd6818d5732f7bbb84124a2
X-Osstest-Versions-That:
    linux=f3dfe925f9548a4337883926db542ccf4ca55fe1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 08:06:03 +0000

flight 173411 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173411/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173405
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173405
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173405
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173405
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173405
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173405
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173405
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173405
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                26b84401da8458c5cbd6818d5732f7bbb84124a2
baseline version:
 linux                f3dfe925f9548a4337883926db542ccf4ca55fe1

Last test of basis   173405  2022-10-03 17:40:10 Z    0 days
Testing same since   173411  2022-10-04 01:09:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Adam Bratschi-Kaye <ark.email@gmail.com>
  Adam Skladowski <a39.skl@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Alex Gaynor <alex.gaynor@gmail.com>
  Alexei Starovoitov <ast@kernel.org>
  Andreas Larsson <andreas@gaisler.com>
  Android Treehugger Robot
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Antonio Terceiro <antonio.terceiro@linaro.org>
  Arnd Bergmann <arnd@arndb.de> # arm defconfigs
  Arvid Norlander <lkml@vorpal.se>
  Bart Van Assche <bvanassche@acm.org>
  Bill Wendling <morbo@google.com>
  Björn Roy Baron <bjorn3_gh@protonmail.com>
  Boqun Feng <boqun.feng@gmail.com>
  Boris-Chengbiao Zhou <bobo1239@web.de>
  Casey Schaufler <casey@schaufler-ca.com>
  catalin@antebit.com
  Chanwoo Choi <cw00.choi@samsung.com>
  Chao Qin <chao.qin@intel.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christian Göttsche <cgzones@googlemail.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Latypov <dlatypov@google.com>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Lezcano <daniel.lezcano@linexp.org>
  Daniel Scally <djrscally@gmail.com>
  Daniel Xu <dxu@dxuuu.xyz>
  Dariusz Sosnowski <dsosnowski@dsosnowski.pl>
  David Gow <davidgow@google.com>
  Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Doug Smythies <dsmythies@telus.net>
  Douglas Su <d0u9.su@outlook.com>
  Eric W. Biederman <ebiederm@xmission.com>
  Finn Behrens <me@kloenk.de>
  Florian Fainelli <f.fainelli@gmail.com>
  Fox Chen <foxhlchen@gmail.com>
  Frederick Lawler <fred@cloudflare.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Gary Guo <gary@garyguo.net>
  Geoffrey Thomas <geofft@ldpreload.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
  Hanjun Guo <guohanjun@huawei.com>
  Hans de Goede <hdegoede@redhat.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Huacai Chen <chenhuacai@loongson.cn>
  Huang Rui <ray.huang@amd.com>
  Huisong Li <lihuisong@huawei.com>
  Isabella Basso <isabbasso@riseup.net>
  Jakub Kicinski <kuba@kernel.org>
  Jason Wang <wangborong@cdjrlc.com>
  Jean Delvare <jdelvare@suse.de>
  Jeremy Linton <jeremy.linton@arm.com>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jianmin Lv <lvjianmin@loongson.cn>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jilin Yuan <yuanjilin@cdjrlc.com>
  Joe Perches <joe@perches.com>
  John Baublitz <john.m.baublitz@gmail.com>
  John Garry <john.garry@huawei.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Julian Merkle <me@jvmerkle.de>
  Keerthy <j-keerthy@ti.com>
  Kees Cook <keescook@chromium.org>
  Kellen Renshaw <kellen.renshaw@canonical.com>
  KP Singh <kpsingh@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Shixin <liushixin2@huawei.com>
  Lontke Michael <michael.lontke@elektrobit.com>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Lukas Wunner <lukas@wunner.de>
  Lukasz Luba <lukasz.luba@arm.com>
  Léo Lanteri Thauvin <leseulartichaut@gmail.com>
  Maciej Falkowski <m.falkowski@samsung.com>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Marko Cekrlic <marko.cekrlic.26@gmail.com>
  Martin Rodriguez Reboredo <yakoyoku@gmail.com>
  Matthew Anderson <ruinairas1992@gmail.com>
  Matthew Bakhtiari <dev@mtbk.me>
  Matthew Wilcox <willy@infradead.org>
  Matthias Kaehlcke <mka@chromium.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Walle <michael@walle.cc>
  Miguel Cano <macanroj@gmail.com>
  Miguel Ojeda <ojeda@kernel.org>
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Milan Landaverde <milan@mdaverde.com>
  Mimi Zohar <zohar@linux.ibm.com>
  Morgan Bartlett <mjmouse9999@gmail.com>
  Nathan Chancellor <nathan@kernel.org>
  Nathan Lynch <nathanl@linux.ibm.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Niklas Mohrin <dev@niklasmohrin.de>
  Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
  Nándor István Krácser <bonifaido@gmail.com>
  Ondrej Mosnacek <omosnace@redhat.com>
  Orlando Chamberlain <redecorating@protonmail.com>
  Paul Moore <paul@paul-moore.com>
  Perry Yuan <Perry.Yuan@amd.com>
  Peter Xu <peterx@redhat.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Petr Mladek <pmladek@suse.com>
  Philipp Zabel <philipp.zabel@gmail.com>
  Philipp Zabel <philipp.zabel@gmail.com> # GA402RJ
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Rafael Mendonca <rafaelmendsr@gmail.com>
  Rasmus Villemoes <linux@rasmusvillemoes.dk>
  Rich Felker <dalias@libc.org>
  Sakari Ailus <sakari.ailus@linux.intel.com>
  Sami Tolvanen <samitolvanen@google.com>
  Samuel Jiang <chyishian.jiang@gmail.com>
  Sedat Dilek <sedat.dilek@gmail.com>
  Shang XiaoJing <shangxiaojing@huawei.com>
  Shi junming <junming@nfschina.com>
  short-circuit <davidedp91@gmail.com>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stephen Boyd <sboyd@kernel.org>
  Su Jinzhou <jinzhou.su@amd.com>
  Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
  Sumera Priyadarsini <sylphrenadin@gmail.com>
  Sumit Gupta <sumitg@nvidia.com>
  Sunand <sunandchakradhar@gmail.com>
  Sven Van Asbroeck <thesven73@gmail.com>
  Tamim Khan <tamim@fusetak.com>
  Thierry Reding <treding@nvidia.com>
  Tiago Lam <tiagolam@gmail.com>
  Tony Luck <tony.luck@intel.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vadim Pasternak <vadimp@nvidia.com>
  Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
  Viktor Garske <viktor@v-gar.de>
  Viresh Kumar <viresh.kumar@linaro.org>
  Wang Wendy <wendy.wang@intel.com>
  Wedson Almeida Filho <wedsonaf@google.com>
  Wei Liu <wei.liu@kernel.org>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Wolfram Sang <wsa@kernel.org>
  Wu XiangCheng <bobwxc@email.cn>
  Xiu Jianfeng <xiujianfeng@huawei.com>
  Xu Panda <xu.panda@zte.com.cn>
  Xuewen Yan <xuewen.yan@unisoc.com>
  Yang Yingliang <yangyingliang@huawei.com>
  ye xingchen <ye.xingchen@zte.com.cn>
  Yu Liao <liaoyu15@huawei.com>
  Yuki Okushi <jtitor@2k36.org>
  Zhang Jianhua <chris.zjh@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  zhaoxiao <zhaoxiao@uniontech.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f3dfe925f954..26b84401da84  26b84401da8458c5cbd6818d5732f7bbb84124a2 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:06:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:06:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415214.659728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofcwr-0005DG-Ik; Tue, 04 Oct 2022 08:06:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415214.659728; Tue, 04 Oct 2022 08:06:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofcwr-0005D9-EL; Tue, 04 Oct 2022 08:06:41 +0000
Received: by outflank-mailman (input) for mailman id 415214;
 Tue, 04 Oct 2022 08:06:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofcwq-00054y-19
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:06:40 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2076.outbound.protection.outlook.com [40.107.20.76])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 78edb5e3-43bb-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 10:06:38 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Tue, 4 Oct
 2022 08:06:37 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 08:06:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78edb5e3-43bb-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S4Tz6oIQjKEkXa8EFpEYNvOkaBrkZeuv6QV13+tQvaa+HbL6blEDGC7/j3IiNmSLZ5CePZ6fG2eG+huSSQLRUNnJW4tl4LgmBjKySUFNE3n7vDIdMQGqaMxGUiuQpyEn2lErArgmTwUh9ulfCc2dH1NuRJAfMoccVJN7xuM3Lqx5v5oov1+INAxywjqzsw8eoLc05YkcBosd7QzBD/J8zfx2VnfUlC3j6Gb4ESn6J8iifluh0j9u5DVtXUVx2c2+YFNjDlMfUy/jdHSspO8sFoLkH8gnEYpEMV31rLU70M2FhMvhcekSc43P04XV3bsDmEX5YDHwJcae3NIJY63XDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pg14Yl7CperX8f+G+08CTIJV6PIA0BhTtfeWM2Vvrao=;
 b=chz0vfRgkxKB1Y74XpCwyCaiYi2bm9E0djoLd0wW4xm5a8jJRTSb4aLhlW8XS5MHabNPUHgjmzZmHQ1Qu5s+eBMKKQ9jzHIEPvsd7F5n/ZGMvtAZhOQtbSkOS4OvauMomMDmv8LAlqy/3VqjoTIUgTzF0Ot1Evr7lQi0RRRMWIUFXPhP3LKe32KHanfWXGf1vlNc/WdLctuXh9beMMKmzT5lybZ+3t5rNAYMV8k83wE5IW1btgZQS/LME0NV0Tgb0GrTUeuFUZBuaQuP/BNiub7iuxCNMdmnJYAkBep9ZUTSYqDeErv7OdOiTDYW/D/C9PXUjkIGv9BSH24j9xw5Sw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pg14Yl7CperX8f+G+08CTIJV6PIA0BhTtfeWM2Vvrao=;
 b=s9N4bQ6vTu78EVI7D4Hl5yvX2qCyLtwuEOImPRcEsdjwu/sNOPPXUspxdlVR5uAgU61B/cFH4dseIoNRxDPKH9n3/UYojSpaUfb9Be/u2xxwth9yTXPTqkHXhQ4EjqeG/zgNH13OFRSi9lbOoo8kOzDbFlbT0yoWDx2iVQARB044ETSgw32KSMpLOTdWMXyXGoehEj8C6sfRYhBXO7tjehUKi83csEJOem6d50t2V6sHIPCxgoSjHK0lLqbXKsjt2Z47Be6o0HCDDtCIYs4125zMLESvBOZ4teG3N2FS/hcPDPNd1o+3uhfjOj1sxnZmeKGSLFYiKeOo5AdQ8luh9w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
Date: Tue, 4 Oct 2022 10:06:36 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS8PR04CA0187.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9626:EE_
X-MS-Office365-Filtering-Correlation-Id: 81b5575a-85f3-4ce8-544c-08daa5df5b04
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A+Yo8CpHbjFzffRBpbvzyfuM/KI38eCFLtORczl3QnIG5BnqGp7VMrr9dhqErhhbHIsBZQE9h4tz0qxxPHC5M6bfKXDGZg9X3D/uq9KUgY7MdTr3Tx9+rNSf1sV6+tv4GO+augwfR1hgQ3w/6MuBJFTFuJplBQPSzOhwZWWNhabYvmSJMpssmqF9QHX7u9B80ZXIJwBhUNMPl9pC4QLkTzsWYIabXPoN08q7E0r1HcHu/x45Fkqxo2+YnRPJkIOUrK4bW4lgKZ/qfPBSjAlz47OS/E6j/YYJrzrA+I/kodzNfmpmui8sr9Npt0AW5JK0dTvAugd9zWURLDVotB+eUSVZUE7K07MhSeyOhF8257DbsU/poT6ucWMcZ0rkiXM7DiTkpx0ELL0kJZRoPZi2GQE6WPyAskivDw+pM6qBqLqZESxMSuGUeVNxMqxlmHXtPjPvIkSs++n243+kLGFsuHaIwsmkbUhr17sjb/pFYIHPLx2IcFB3OjDOr81t87vVRQ0QpRK59sm/4XuM6I+ozg7n6jE5NcUChOtJOqUFREzc22D2UcDU52l3o9pRRc9ve15zKOqxP4fDJD1b2Cqi5Izg0V4yc1pFHdLNfn2FX3qGX9h2g5TsRCDCWXPyQuOqXUkIZhi59Ki8H5IODRo4wg2qCmm4titVEG/aP3EwlQfEHzjPvpMLJYKWo9KpccE8Mqu9CK3FtmYF11qiRcaXomnaokPiZDzoOenhrrH0t+eLMMle7iuBWLSFFoLuS4UvczrsImi+dVxPP/gjTi2njbrKTYsxar6IHzRVBatJKm4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(39860400002)(396003)(136003)(451199015)(38100700002)(66556008)(83380400001)(6512007)(26005)(4326008)(316002)(54906003)(36756003)(2616005)(2906002)(31696002)(6916009)(5660300002)(186003)(4744005)(66476007)(66946007)(8676002)(41300700001)(86362001)(31686004)(6486002)(478600001)(8936002)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Rkc1RktUbmE3RUllUEpxbTVMY0wwc0dYYStFQVVoVUprb3NJLytBRnpCMkQw?=
 =?utf-8?B?RG84Z1hQWGI0SFAzOHdNZ0p2VGt2TDVtY21EQnluL3hBU3ZSUUp0dEJVSUNH?=
 =?utf-8?B?ZGlleFo5eklFMkxFUzYyNmFmODZWSnhYNzAvSTZQK0VWSGZjSFJNeTZOYyta?=
 =?utf-8?B?MDNzUEl3RTlYcDdNdS84V0JranNsWkR4RDBDQXRZWTFLbzdlSzFGOVBJWXFT?=
 =?utf-8?B?b0g4ODBrNzJveVZOdlNLUmJmK0VTeUxONGdkL2tEZC83TDBiYWgzWmx2N0VL?=
 =?utf-8?B?OUVUSzU2elZFcnpaZy9sSjlPazVCQzVMN256YWJ3d0VDdGM5R1dnNmhpcXI4?=
 =?utf-8?B?eGp6VEJobHloZE52TEFOZXprK2RNRmg5YklhZXJGWGIvWTVYYXZiaGw3SzNU?=
 =?utf-8?B?cURoVFpaTkdsbGtUWmpuZ1FOQXZkNmZ0M0ZQL1ZOVklxNHVqbVdYcHU2N2dQ?=
 =?utf-8?B?RCthUEplMi9RQWVJb0kwTldWMzgxTXJ6MjErMTZLbzJRS0F0bGduY1pXYktO?=
 =?utf-8?B?TEpmODZVcmNqVCtnLzVrSndaTW1rZ1JpZHgzczAwbmt3S3c0NjRnU3ZrcDIr?=
 =?utf-8?B?ODJxK3VJM2ZjT0w5OE5jblpnMkhlUFp4Qm0xT3A1ZmtzQ1cvNWJLVCtLMEhQ?=
 =?utf-8?B?bThoUE9qK2RHWDNvZ09LaERCajFBWEJEZ1JPTll2NHkwTGptZS8vc0g1VzRw?=
 =?utf-8?B?WkMzSE1KYWVyTjdGbDkyWGVVU2xrZ3hZeFhJbjZHTXp4R1c1a3Mvbk9oSEZm?=
 =?utf-8?B?c0NMbjhsb3RCdGJTRHN0SHJEYnZxTExSTS9RWG1ocWtXdjlVVi80UzhRVFZK?=
 =?utf-8?B?S0c2T1ZTQnhsbHZwVWVLdW9Hd1JBRlhwdEJzbk9EUlRIejNHazdqQWVIejUz?=
 =?utf-8?B?T1NXMEtzMlN6YXUraVdtYkhTZmQ1M2ZmakhXMWJjY3V6aERmY1B0Y2FlZlRj?=
 =?utf-8?B?NU1QRWxteVdMRUxUU2JVa2tiQTVaK3hUYXRGb3JwWTd0UmlQazRrakVDK1hU?=
 =?utf-8?B?RnVobUZWMUVaU2RzUWJKQ214bWE4NVlBNEs1WU5CQ24xa0x2dFM3Y3ExNU1n?=
 =?utf-8?B?bWNwYkRpVXJtczN2eE8wMlJBUTFZdk8rS0JkdVhkalBwMjJHYWU0c2pLSXd0?=
 =?utf-8?B?NVhTQko1dmJQb2psQzBoazJZbzlJdlBWS0JBNENjQ1ljWnlGWTBoRWM4SElE?=
 =?utf-8?B?VHU1U0FSdXVRMlo4MjBhTkxkTHZhcUNFSGsxeklYdXVaekcwUmpsM2NhNGtR?=
 =?utf-8?B?S3JQZXlJZEdUbHFtSVdVTDZvek1SZW5RdngxVkF5aEtqMG1FdmNxV0pXQ3cx?=
 =?utf-8?B?ZXhOUHQrOFdLYm1oK2g5K2lZSzRTcWp4alAxdVR3SXVDcnNqWnRKcm82cXdL?=
 =?utf-8?B?ZTdxdEtMNy8yK29SUzk5NG1aWHlWZ1VVN3Rhb28vakJYR1VUWVo5dW9TM3ZR?=
 =?utf-8?B?N3NJTTFLaHBURUtvYmlGK3ZWYmlUTjYxdjFKWnZCclF2Mm83N1RzbWdkRWRt?=
 =?utf-8?B?cm1oOEtjQXVGbHpiNHJxeHgxTkxZZEw5RC9rV1pUOGZiNCtuYUdpVWFrblFq?=
 =?utf-8?B?V1ZIWXFaUVVQdDRGSlY5OHJpaGFWclBaaHJmSHdhR0NXSVhBWWlibzdNWXow?=
 =?utf-8?B?MUhkSEdCMVl6d0NzUlpBbXhzMFVhejcreTRZaEhZdjdzVVdpMUZ0Uk9MWG9n?=
 =?utf-8?B?WEhzRkMxVWREYzhuZFFIYVF5cEI2SFNIRWg3eDFiUGFNaFVKSVo4dHZFbmF5?=
 =?utf-8?B?a3Z3d1M4a2pjMmI3ODFLOXBjWm9PMWswQUo5ZDM3UGlKdGlBT1Jyb3Z0b1Ns?=
 =?utf-8?B?UFBiL1dXYWdrMTdoQjJzVGowN0QxNFd5SDJPdklzbWR6ZE1tQ1p2RFBIdnRG?=
 =?utf-8?B?emdIREtlRDdXdEVheStMYWY1ejIrYTZ5WkVodkFZSW9Qd01sbDI4SEFzOHM1?=
 =?utf-8?B?SURrSkNiMHNPT0JtZnM0UEVRcmEzajNpN0hBS3BNemY3WUZCTHBvQ3RmelRL?=
 =?utf-8?B?SFRwSWczU3haSFlQMW1QbCt6UE1GSE1wWXp0M21QaVlwdVBPWWI2bWpaSm03?=
 =?utf-8?B?TkJYbWlKcHRHNjBCeVZ2dS96R3YyT2VqWHZiSkR3YzNoa0dGTTBsRVBwYWh0?=
 =?utf-8?Q?3EMowpwmqmP5R787ULYsyrdCr?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81b5575a-85f3-4ce8-544c-08daa5df5b04
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 08:06:37.3864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: coMwW3dEdc1Z7hfrbJiA4FYjdUGMuIdDjsNKZERtwS+1ZfGw99J+xyZAM4gDgSviJ+FDd5BjV/SnycNw70BvDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9626

On 30.09.2022 16:28, Roger Pau Monné wrote:
> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>> higher priority than the type of the range. To avoid accessing memory at
>> runtime which was re-used for other purposes, make
>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there and hence that type's handling can be left alone.
> 
> What about dom0?  Should it be translated to E820_RESERVED so that
> dom0 doesn't try to use it either?

I'm afraid I don't understand the questions. Not the least because I
think "it" can't really mean "dom0" from the earlier sentence.

Jan

>  I guess using E820_RESERVED
> could also confuse dom0 about ACPI data placement.
> 
> Thanks, Roger.



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:22:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:22:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415227.659739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdC4-0007hT-V3; Tue, 04 Oct 2022 08:22:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415227.659739; Tue, 04 Oct 2022 08:22:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdC4-0007hM-Qm; Tue, 04 Oct 2022 08:22:24 +0000
Received: by outflank-mailman (input) for mailman id 415227;
 Tue, 04 Oct 2022 08:22:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofdC3-0007hF-GK
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:22:23 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50073.outbound.protection.outlook.com [40.107.5.73])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab3958e4-43bd-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 10:22:22 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB8041.eurprd04.prod.outlook.com (2603:10a6:10:1e2::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Tue, 4 Oct
 2022 08:22:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 08:22:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab3958e4-43bd-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OXwvcpjo/NjIyMSMmu85wQoh0TLp6gu8j1yRhbJyGqoZZ0Wi0nzNBQv5ixcPO3HsweSnY7N2owI9hKFWnae3bcB3qHrK8FKPYLWaV7RdskYNDdxFctD+Yj0HBDQACYsxOH6XlJa9xD087e66e/8w5NW+uMmnByjm73q4PlaBCUjH0WhY/Nj2OYS1Ns5HvjxYrci3hny8ndKs8nqu4mOS5GAwr63VZA8lq9sDHW6Ze5dUhSrtTjg5hNjdLp3Bs/PMJqwLuDkacdDdWTsWmwytYr0UziQbX+nx6KDLu/dbnzoRWjjbc64dHprkYTaoaKCrvYO3UsXDp7ObhubHNIzpxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zXCEL2OOljVJd5th58mpGBa3qzLxxQW0isLk0zRsQpA=;
 b=j7sHQqyLGRHfHMMjRvpCz7atVWN66ydeyzqDAfUCNC+B46WxeHuYXwvjKXr9hwzjD63sfjvx/PxFfPBN4Xy9dFOKIvKerwlOdZ6cR/a9mUhw5KKyiActgirIbAezL2I+RQAz/hyrdErXgk0EmP7f8T1qxQBfykVBfbsDJ909a97e+2U8EM45zYWa0jBQec0hJVGk1dX7QpXoSzE9Rf74ogLWrraxr0VtKKkueKK/cI5M8FP8w/fzkXNbdPGiLLMc+9Dkrzc2LMXvBjNRxSUk/vQjo2SOll0JTAwEWMZCy6QRfFbF3vBneMM4LkCfkhNaTeYx3TAGXELuK4BYKixMQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zXCEL2OOljVJd5th58mpGBa3qzLxxQW0isLk0zRsQpA=;
 b=MAwJw9JzjUsQht4RVlnEK88GA91c1wppYpeocdHoVt9NlW3M9bACL4XFE2170oJ2H2wwTmqwlzAQT3Em7Q+vwq2KcqtfONHKUX5rxHWWSJO+FPSXBLlN/C8HHS3SNsuluvJzngZc3JQ+pRuGOOL0ii8vKdB8kRwMm3i5A2RIKkpQME4Rpm0Js4L+NE3a7WZbNLNNrvnDk9JltGbbFUi98Iy2xz3HGxP/3gtH0zFFoGIk7inpAIYfeaQKrwIQ9bppuYhWAHoCnGivW1fTOxRBUpK+MlDbQ69A+M3GJHi6gIvyNP7qFQ8a9nQk1PZs2+Uc7v0n7BsTI0QEnwcSYRwWKg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
Date: Tue, 4 Oct 2022 10:22:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Kees Cook <keescook@chromium.org>, Anton Vorontsov <anton@enomsg.org>,
 Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Ard Biesheuvel <ardb@kernel.org>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzeaKjmls1YI/3ox@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR06CA0001.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::31) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8041:EE_
X-MS-Office365-Filtering-Correlation-Id: e0471394-7a2e-460a-9192-08daa5e18a1e
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qEePcn+wdtoK0UYcVog9PB3sbwkkz6Epw650HHmmvKn9huBwRc2LBNz0c3ScDxzqL8u10OywxsjhssQk/vlOcNxVnA4eJ/Hxx6zz75Fq86Tq8Yu7/YqIsCNihVTlpttt1RZqmpo2KTV8sydbERwEB8/OKrliApqp2w1YsJy02vtIb3BScl8YjcFiRMwKcgzkFiQa1DRanxtsi+T02nruBdCE/12QcqwaPhWvD/83IlIN5MLnVDSOrzwzv4KzlUDUx2N0LBeKNhbMuLkDsyPu4IYBkCLtP5Acvq8kUMSLHJZRMLzvnViTgAoD8jUaXFyE/CyTdlI2OsMqqVURgiIzcwqGdJ0U/61SxjckFHuHnefEzcrg00LxMnRMxyWSVD7/xy5w/UtgAg77uNQVjrT/qLWw10RS4/p2pg8/if7fohoxDKHsRX4kC4NNH9uMWUSNvzd3BPv2dfzKyEHx+agBA2UGTKH/nE/x93pKP0KWPHYT8QOybjIm1PvvxtMdBnOPhL1XDjCwtA/ioM1Iu/DZ4rDXiioG5c3SD4TYqvHplraL5GtrvSxZZZKya2KrpaiXbIneZ6IQYK5kpzs9sUTpEyCS+pc0Mwt0v+ly2PCZF1S7SL2p6OhfGPMxsRCiLZIy08lp96J1maMPdOeNJqTbhlfC+gVcWnMlJS938yTJchzQVEn8k/yn2eEam4aALld4twVFImt99zMfsHFT+sLHIMSI35EGfQzRtKSmZuHBlo4TQPcvS9lCwVlDaKBhXcMthVJINBZcQmco8xen0hsx3LZfH/JioZa96uaH0Y8mwXU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(376002)(366004)(451199015)(186003)(38100700002)(31696002)(86362001)(31686004)(36756003)(26005)(2616005)(7416002)(2906002)(53546011)(6486002)(6512007)(6506007)(478600001)(6916009)(5660300002)(316002)(8676002)(41300700001)(8936002)(66946007)(66476007)(4326008)(66556008)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UjUzTkxXOUlMcUdtZzdtdHF3a3Y1eTdRR1RHeXRpQ1NWbXNZZXJyY2FmekMy?=
 =?utf-8?B?S2RSTW0rcnpINzRxR28zRE5LOXBFdG85cXdOaXRoUjl5RUVYYkJjNFZGM3hK?=
 =?utf-8?B?Tmp3QzZHYkRGdmMrUDlOUnBhaFFXVldGVE85cWhrZXdzb3RkZUhGWG5PU1RJ?=
 =?utf-8?B?clN5RUlyeElLVFJTYUd5S2ozamJlM3Y1MkZ0OEh2NlV5SzRIVjQ4UnJtV0lH?=
 =?utf-8?B?SDhYZFRPRUIrVW0wRFFFNVhNQ2NUVUJ1Tk1pSWt3RzlzazFqZ2h4MXVlajRU?=
 =?utf-8?B?NUxEd3hCMlRFeVFZNldBdVE3K25reXdqUzBFZzQ4eTRYWE9WUWV6R2E2WnB5?=
 =?utf-8?B?b3NoNlZsSUE4Nmh5S2tCNDZRVVIxWHlnanJ6WUVrak1hMEx6cERBRzU0NTZT?=
 =?utf-8?B?a0N0cWo2Y1FKaWNCRGlMbncraS9rTFNJS09FUWMyWE9xajA3ODk4aE9ibjl1?=
 =?utf-8?B?cndtbFhvemtMYVEwQlFPa29UOUQxSUZqcHVIUDRORjBLL1lzdGt1SCs4QStt?=
 =?utf-8?B?Y2RNejlQWXVFV0pjSmtWamNQc0VXM01tY2pzdHo5aGsxWnl1RFBseHVGVWRy?=
 =?utf-8?B?ZHBRbExDOTIyNExxeVZjZGUrVUh3Rkd2ZFUxMFdsa1YxTC80LzUzdUdSaEhs?=
 =?utf-8?B?TGY5YURrODNrZWJ1c0NNWEhhVVhzZmdkaEt6dnI5aHQwUWxQQXBDQnAxVFZy?=
 =?utf-8?B?Y0pMdWhFVVNEYlJONllRTGFpY0R5WWlpNTQyYmNzeTUrcWpiSm5PYms0QVlC?=
 =?utf-8?B?bHgxQUo4QmpNL1ZONUl0NHpaRzA0TjBFMCtpVkpVTlRZK3l3bURSNVVoNzhj?=
 =?utf-8?B?dittbmhxbHJsZnVPaGRGeVF3Sy9IZ0Q4WE5rZHdwMW5mSFNJQk1TYm53WXVy?=
 =?utf-8?B?MHRzVm9KWWEzYVZsSENJWWcrbitUSkFDQVhtYXA0WHZpZ3NHMjFnaG5RT1RP?=
 =?utf-8?B?d1k0bGxwTk5DbTlrVUNySS8vRkVvalQwdW5vdzZ0aE9RUHVvS0NoVmVOMmZz?=
 =?utf-8?B?UzVtYlB5T1ExM1NMSUZpNi9LUXpEQjR6OWxVL20vSkRna3U1SFBINnBwVm1L?=
 =?utf-8?B?V2kybXlLVi9pNTJRdkYvaFMydDE2dG5CR0VTTlVHblhpbjdqa2VRQmY3MHFk?=
 =?utf-8?B?QWlpblU1bE1sTkVBekZUM255K0doYlYvejN3M2ZSeEphbjlqYXE0VTVCZ3NI?=
 =?utf-8?B?THpublIzSW1uQmNZVXlvdUNZUW9scWFKeVp4NHNuVEgzYmpHdlE3VC9OZ2ts?=
 =?utf-8?B?d1doSDBtejNxZHg1ckdNUkhJekFUanZKRTltaFJqa1VLWUlVbCtwZy9QMTI4?=
 =?utf-8?B?OVQ2Z0ZNaFUyZkdjTjBiSGQ5T0xRM1AyVnhQUm9kLzZFdkhNSmhuK0xBL25a?=
 =?utf-8?B?Zkk0UEk4RDdIR1RKRUZLbFFGRHdSbjFlbmhBVkh6L3pHRlNmdnQrRy9ibEUv?=
 =?utf-8?B?dkhxTzBtQWxYYzc0SXVrbnJnRnZDRGx4OUlaZGw2cTdtWTZxWGZKOEhua2tt?=
 =?utf-8?B?VnEwSlNibzloQTRMVnJuYVVkUGtDdVkxSGhKaU1MWndaNjRvYmVDeEhmQXpr?=
 =?utf-8?B?bmhqa1Ztb013VjM0UjVkb1IvQ3k2QnVoTy9tSTErN0NkcXd3YnQwK3pwMTJJ?=
 =?utf-8?B?T3NZaWtSb1lRV1dCaGVtdVhNUlQyVVY2cG91U1dzWHc5eENJWHk3bi8wQ2xL?=
 =?utf-8?B?d2g2V1VoZXp4RUVMNVF5MC80aFJHZmlUUkNmdzVzclp6dkhIa0pXekYwZ0Fw?=
 =?utf-8?B?TTdQZUdFclFhblFZb3dVWFJQajR1bkhmMXlFbHhKZ0pQRjRlcDRLMFNOVytm?=
 =?utf-8?B?MzMrcDY0WmRVRjYvT3owRGlWZGZoMzFpNUdZM3JqUlpDUHNqSm5wa3daOHFk?=
 =?utf-8?B?NnhBNnJEdStIR1dOMy9CUGN1blJEakViL3JsVElCRnVkYVpSNFZNajVCWHBs?=
 =?utf-8?B?TTFIWC9ENFJlNHVBS3JaaE8xSG5zQ0tqVkFPeUpkS1U3d3pSaDN4dzBQaEla?=
 =?utf-8?B?UzhLNUhSQ1poL3lheEFNamF1K3NHVmszdnprU1IrQnRnaUtOc0Q4by9TTTZp?=
 =?utf-8?B?TGxlcmVwMEhOc25HOGZtZTIyZ01lZTNmRjI0ay9lVnp0bklVUVZ5bG1HSFhI?=
 =?utf-8?Q?cSV8KjNPpxbLKjy4eM80r3Mgx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0471394-7a2e-460a-9192-08daa5e18a1e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 08:22:13.1705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BUay21qJ0+s9DOLP4PFCWY3lK7HuzTPKi0e64xdRlmo77t8C8EGJWuTITIGNB7r/wXN1lraVFNTVT4PU3zERtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8041

On 01.10.2022 02:30, Demi Marie Obenour wrote:
> On Fri, Sep 30, 2022 at 08:27:09PM +0200, Ard Biesheuvel wrote:
>> On Fri, 30 Sept 2022 at 19:12, Demi Marie Obenour wrote:
>>> On Fri, Sep 30, 2022 at 06:30:57PM +0200, Ard Biesheuvel wrote:
>>>> I know very little about Xen, but based on the context you provided in
>>>> this thread, I'd say that the best approach from the Xen side is to
>>>> convert all EfiBootServicesData regions that have configuration tables
>>>> pointing into them into EfiAcpiReclaimMemory.
>>>
>>> Should Xen convert the entire region, or should it try to reserve only
>>> the memory it needs?  The latter would require it to parse the
>>> configuration tables.  Is there a list of configuration tables that can
>>> legitimately be in EfiBootServicesData regions?
>>>
>>
>> Not really, no. So you would have to convert the entire region
>> /unless/ Xen knows the GUID, and therefore knows how to derive the
>> size of the table, allowing it to reserve memory more conservatively.
>> However, I doubt whether this is worth it: splitting entries implies
>> rewriting the memory map, which is a thing I'd rather avoid if I were
>> in your shoes.
> 
> I actually wonder if Xen needs to reserve *all* of EfiBootServicesData.
> The reason is that some (probably buggy) firmware may store ACPI tables
> there, and Xen does not have an ACPI implementation.

We already have the -mapbs option as a workaround in such situations.

>  From my
> perspective, a much safer approach would be to pass all of
> EfiBootServicesData memory directly to dom0, and have dom0 give Xen back
> what it doesn’t wind up using.  That allows dom0’s memory reservation
> code to work properly, which it currently does not.

As said already on a different thread: Giving memory to domains (incl
Dom0) isn't related to their original memory type (neither EFI's nor
E820's); the needed memory is taken from the general page allocator
(with one exception for initrd, to avoid unnecessary copying around of
data). Hence what you propose would end up as an (imo) awful hack in
Xen. I also don't see how this relates to "dom0’s memory reservation
code", but I'm sure you can clarify that for me.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:23:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:23:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415233.659750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdCy-0008Dr-8O; Tue, 04 Oct 2022 08:23:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415233.659750; Tue, 04 Oct 2022 08:23:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdCy-0008Dk-4o; Tue, 04 Oct 2022 08:23:20 +0000
Received: by outflank-mailman (input) for mailman id 415233;
 Tue, 04 Oct 2022 08:23:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LCCr=2F=amazon.de=prvs=26955097f=graf@srs-se1.protection.inumbo.net>)
 id 1ofdCw-0008BG-OE
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:23:18 +0000
Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com
 [99.78.197.218]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb41431d-43bd-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 10:23:17 +0200 (CEST)
Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO
 email-inbound-relay-pdx-2c-5c4a15b1.us-west-2.amazon.com) ([10.25.36.214])
 by smtp-border-fw-80007.pdx80.corp.amazon.com with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 08:22:27 +0000
Received: from EX13MTAUWC001.ant.amazon.com
 (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194])
 by email-inbound-relay-pdx-2c-5c4a15b1.us-west-2.amazon.com (Postfix) with
 ESMTPS id A219D44FBC; Tue,  4 Oct 2022 08:22:22 +0000 (UTC)
Received: from EX19D020UWC004.ant.amazon.com (10.13.138.149) by
 EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS)
 id 15.0.1497.38; Tue, 4 Oct 2022 08:22:22 +0000
Received: from [10.95.66.18] (10.43.160.124) by EX19D020UWC004.ant.amazon.com
 (10.13.138.149) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.12; Tue, 4 Oct
 2022 08:22:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb41431d-43bd-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;
  t=1664871798; x=1696407798;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=LJNqYgt9+EkQuB9NNZOVvoJbSMyT9Vb0J5NzwhljRLA=;
  b=NfSXmVFPOKGY/PbHLQzceucw6CBHuMbgPYbuu7d3WGNKlaUYmilpuYGH
   FthoVDdvFilZlnVcb2wZvPDEisUUQwiIICvXnf8eRLya/eKkWVaTn31wb
   3yD4lW0ZMsuQDV5uoADT7VwruzBbTm/aPDPfz1veC1hGtmm7wtiIhbkqI
   A=;
X-IronPort-AV: E=Sophos;i="5.93,367,1654560000"; 
   d="scan'208";a="136675810"
Message-ID: <f1a7e603-2e64-fd2a-1100-f2898060e3f7@amazon.com>
Date: Tue, 4 Oct 2022 10:22:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Content-Language: en-US
To: Nadav Amit <namit@vmware.com>, Vitaly Kuznetsov <vkuznets@redhat.com>
CC: Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>,
	Srivatsa Bhat <srivatsab@vmware.com>, "srivatsa@csail.mit.edu"
	<srivatsa@csail.mit.edu>, Alexey Makhalov <amakhalov@vmware.com>, "Vasavi
 Sirnapalli" <vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
	<er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
	<jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "acrn-dev@lists.projectacrn.org"
	<acrn-dev@lists.projectacrn.org>, "helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
From: Alexander Graf <graf@amazon.com>
In-Reply-To: <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
X-Originating-IP: [10.43.160.124]
X-ClientProxiedBy: EX13D06UWC004.ant.amazon.com (10.43.162.97) To
 EX19D020UWC004.ant.amazon.com (10.13.138.149)
Precedence: Bulk
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: base64

SGV5IE5hZGF2LAoKT24gMDMuMTAuMjIgMTk6MzQsIE5hZGF2IEFtaXQgd3JvdGU6Cj4gT24gT2N0
IDMsIDIwMjIsIGF0IDg6MDMgQU0sIFZpdGFseSBLdXpuZXRzb3YgPHZrdXpuZXRzQHJlZGhhdC5j
b20+IHdyb3RlOgo+Cj4+IE5vdCBteSBidXQgcmF0aGVyIFBDSSBtYWludGFpbmVyJ3MgY2FsbCBi
dXQgSU1ITyBkcm9wcGluZyAnY29uc3QnIGlzCj4+IGJldHRlciwgaW50cm9kdWNpbmcgYSBuZXcg
Z2xvYmFsIHZhciBpcyBvdXIgJ2xhc3QgcmVzb3J0JyBhbmQgc2hvdWxkIGJlCj4+IGF2b2lkZWQg
d2hlbmV2ZXIgcG9zc2libGUuIEFsdGVybmF0aXZlbHksIHlvdSBjYW4gYWRkIGEKPj4gcmF3X3Bj
aV9leHRfb3BzX3ByZWZlcnJlZCgpIGZ1bmN0aW9uIGNoZWNraW5nIHNvbWV0aGluIHdpdGhpbiAn
c3RydWN0Cj4+IGh5cGVydmlzb3JfeDg2JyBidXQgSSdtIHVuc3VyZSBpZiBpdCdzIGJldHRlci4K
Pj4KPj4gQWxzbywgcGxlYXNlIGNoZWNrIEFsZXgnIHF1ZXN0aW9uL3N1Z2dlc3Rpb24uCj4gSGVy
ZSBpcyBteSB0YWtlIChhbmQgQWpheSBrbm93cyBwcm9iYWJseSBtb3JlIHRoYW4gbWUpOgo+Cj4g
TG9va2luZyBicmllZmx5IG9uIE1DRkcsIEkgZG8gbm90IHNlZSBhIGNsZWFuIHdheSBvZiB1c2lu
ZyB0aGUgQUNQSSB0YWJsZS4KPiBUaGUgdHdvIG9wdGlvbnMgYXJlIGVpdGhlciB0byB1c2UgYSBy
ZXNlcnZlZCBmaWVsZCAod2hpY2ggd2hvIGtub3dzLCBtaWdodAo+IGJlIHVzZWQgb25lIGRheSkg
b3Igc29tZSBPRU0gSUQuIEkgYW0gYWxzbyBub3QgZmFtaWxpYXIgd2l0aAo+IFBDSV9DT01NQU5E
Lk1FTU9SWT0wLCBzbyBBamF5IGNhbiBob3BlZnVsbHkgZ2l2ZSBzb21lIGFuc3dlciBhYm91dCB0
aGF0Lgo+Cj4gQW55aG93LCBJIHVuZGVyc3RhbmQgKGFsdGhvdWdoIG5vdCByZWxhdGUpIHRvIHRo
ZSBvYmplY3Rpb24gZm9yIGEgbmV3IGdsb2JhbAo+IHZhcmlhYmxlLiBIb3cgYWJvdXQgZXhwbGlj
aXRseSBjYWxsaW5nIHRoaXMgaGFyZHdhcmUgYnVnIGEg4oCcYnVn4oCdIGFuZCB1c2luZwo+IHRo
ZSBwcm9wZXIgaW5mcmFzdHJ1Y3R1cmU/IENhbGxpbmcgaXQgZXhwbGljaXRseSBhIGJ1ZyBtYXkg
ZXZlbiBwdXNoIHdob2V2ZXIKPiBjYW4gdG8gcmVzb2x2ZSBpdC4KCgpJIGFtIGEgbG90IG1vcmUg
Y29uY2VybmVkIHdpdGggaG93IHdlIHByb3BhZ2F0ZSBpdCBleHRlcm5hbGx5IHRoYW4gCndpdGhp
biBMaW51eC4gSWYgd2UgaGFyZCBjb2RlIHRoYXQgYWxsIExpbnV4IGtlcm5lbHMgNi4yKyB0aGF0
IGFyZSAKcnVubmluZyBpbiBWTXdhcmUgcHJlZmVyIEVDQU0gb3ZlciBQSU8sIHdlIGxvY2sgb3Vy
c2VsdmVzIGludG8gdGhhdCAKc3RhbmNlIGZvciBiZXR0ZXIgb3Igd29yc2UsIHdoaWNoIG1lYW5z
OgoKKiBBbGwgcGFzdCBhbmQgZnV0dXJlIHZlcnNpb25zIG9mIGFueSBWTXdhcmUgaHlwZXJ2aXNv
ciBwcm9kdWN0IGhhdmUgdG8gCmFsd2F5cyBhbGxvdyBFQ0FNIGFjY2VzcyBmb3IgYW55IFBDSWUg
Y29uZmlnIHNwYWNlIHdyaXRlCiogTm8gb3RoZXIgaHlwZXJ2aXNvciBiZW5lZml0cyBmcm9tIGFu
eSBvZiB0aGlzIHdpdGhvdXQgdXBzdHJlYW0gY29kZSBjaGFuZ2UKKiBObyByZWFsIGhhcmR3YXJl
IHBsYXRmb3JtIGJlbmVmaXRzIGZyb20gdGhpcyB3aXRob3V0IHVwc3RyZWFtIGNvZGUgY2hhbmdl
CgpCeSBtb3ZpbmcgaXQgaW50byBNQ0ZHLCB3ZSBjYW4gY3JlYXRlIGEgcGF0aCBmb3IgdGhlIG91
dHNpZGUgZW52aXJvbm1lbnQgCnRvIHRlbGwgdGhlIE9TIHdoZXRoZXIgaXQncyBzYWZlIHRvIHVz
ZSBFQ0FNIGFsd2F5cy4gVGhpcyBvYnZpb3VzbHkgCmRvZXNuJ3Qgd29yayB3aXRoIE1DRkcgYXMg
aXQgc3RhbmRzIHRvZGF5LCB3ZSdkIGhhdmUgdG8gcHJvcG9zZSBhbiBNQ0ZHIApzcGVjIGNoYW5n
ZSB0byB0aGUgUENJIFNJRydzICJQQ0kgRmlybXdhcmUgU3BlY2lmaWNhdGlvbiIgdG8gYWRkIHRo
ZSAKcmVzcGVjdGl2ZSBmaWVsZC4gRnV0dXJlIFZNd2FyZSB2ZXJzaW9ucyBjb3VsZCB0aGVuIGFs
d2F5cyBleHBvc2UgdGhlIApmbGFnIC0gYW5kIGlmIHlvdSBmaW5kIGl0IGJyb2tlbiwgcmVtb3Zl
IGl0IGFnYWluLgoKUHV0dGluZyBhbGwgb2YgdGhlIGxvZ2ljIG9uIHdoaWNoIHN5c3RlbSBwb3Rl
bnRpYWxseSBwcmVmZXJzIEVDQU0gb3ZlciAKUElPIGNvbmZpZyBzcGFjZSBhY2Nlc3MgaW50byBM
aW51eCBpcyBqdXN0IGEgYmlnIGhhY2sgdGhhdCB3ZSBzaG91bGQgCmF2b2lkIGFzIG11Y2ggYXMg
cG9zc2libGUuCgoKQWxleAoKCgoKQW1hem9uIERldmVsb3BtZW50IENlbnRlciBHZXJtYW55IEdt
YkgKS3JhdXNlbnN0ci4gMzgKMTAxMTcgQmVybGluCkdlc2NoYWVmdHNmdWVocnVuZzogQ2hyaXN0
aWFuIFNjaGxhZWdlciwgSm9uYXRoYW4gV2Vpc3MKRWluZ2V0cmFnZW4gYW0gQW10c2dlcmljaHQg
Q2hhcmxvdHRlbmJ1cmcgdW50ZXIgSFJCIDE0OTE3MyBCClNpdHo6IEJlcmxpbgpVc3QtSUQ6IERF
IDI4OSAyMzcgODc5CgoK



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:30:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:30:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415244.659761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdJk-0001Ly-6R; Tue, 04 Oct 2022 08:30:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415244.659761; Tue, 04 Oct 2022 08:30:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdJk-0001Lr-3j; Tue, 04 Oct 2022 08:30:20 +0000
Received: by outflank-mailman (input) for mailman id 415244;
 Tue, 04 Oct 2022 08:30:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HeQf=2F=redhat.com=vkuznets@srs-se1.protection.inumbo.net>)
 id 1ofdJh-0001Ll-Nj
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:30:18 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c575a995-43be-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 10:30:16 +0200 (CEST)
Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com
 [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-277-0FQCOVoKOxWHnmH3pVS-5Q-1; Tue, 04 Oct 2022 04:30:13 -0400
Received: by mail-ej1-f72.google.com with SMTP id
 xc12-20020a170907074c00b007416699ea14so4439058ejb.19
 for <xen-devel@lists.xenproject.org>; Tue, 04 Oct 2022 01:30:13 -0700 (PDT)
Received: from fedora (nat-2.ign.cz. [91.219.240.2])
 by smtp.gmail.com with ESMTPSA id
 by30-20020a0564021b1e00b004590d4e35cdsm1198745edb.54.2022.10.04.01.30.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 04 Oct 2022 01:30:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c575a995-43be-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1664872215;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mx+TIb5N4ENHhgvLtFzyQ3iRnSCgSSPj/Ny8vTXS3Nk=;
	b=KP2JLvGNM9DEp57l3qOrg3MuFaXe8J2+k8hOgOvtpa3mj+c3YmC41r33zDJf8btV0Kh7+S
	PvbfIoQAsltkhwnPuI5DA0gLOcclZKPtGVR12sc3dCJyjPQzyKh6KyqHtMVhC7FnnJX8mn
	yYWUhbWr0ER3bDWXwwSS5J5u9uu3Hu8=
X-MC-Unique: 0FQCOVoKOxWHnmH3pVS-5Q-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:references
         :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date;
        bh=kChJ5YXyR55NqzsspcQL6vhugqTTUyXdwpS+PG+Hins=;
        b=FyLduXF3wltYnWa3pY9qIM+6F8fRYXGbZmW92BahoK4eUCrUQWLFrstQVZ3bHD3ngp
         hcJ4BGMJHsuQwJC7wmIPpvYbYfhajwPJcGIkmZXngKllkbOFsA4bv9ClSWX5d3vfgwYv
         tUlqseJV1dA2qPBaJ4ENA9wjw3vF06EiSK/B4HKnayg3l4aj/cNgu6Rp0xHpG9+h88YM
         ul1B/eeLwH8KJKnv4FIfNsjssFfQR2o95F/8MarG8HfPd4JI60fSbuVOLtg2hPifTqlL
         DsG54rgklDndCOsVXbnyg02M2/VO8PJOHhRI9zhfMGvgJnJ7gHSSskjKB6BMfTKlW0qu
         8rFA==
X-Gm-Message-State: ACrzQf2/D9+Db1NcQUuIKlWGkXipif5lrRuvuXfiUaTOT2vkFjSBQWd4
	HPzd3qFu73nUJK9c89Bjvw2wkVmqnG8f2FQdz7s4Y11/OQbq60Mr8I69hpqFWpF3elvGcCeJ5WM
	7RTV/MBz0QBk+Lp0T4jDq+wJeFxo=
X-Received: by 2002:a17:907:1626:b0:782:e490:4f4 with SMTP id hb38-20020a170907162600b00782e49004f4mr18347585ejc.464.1664872212799;
        Tue, 04 Oct 2022 01:30:12 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4V1XegvfHQqtOdwuF9hkqqgOAv0Ct2ylqgG/E0UdTe0kkF9v3n5AapSW1/X/ZGX1Jj9DACkw==
X-Received: by 2002:a17:907:1626:b0:782:e490:4f4 with SMTP id hb38-20020a170907162600b00782e49004f4mr18347564ejc.464.1664872212563;
        Tue, 04 Oct 2022 01:30:12 -0700 (PDT)
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Nadav Amit <namit@vmware.com>, Alexander Graf <graf@amazon.com>, Ajay
 Kaher <akaher@vmware.com>
Cc: "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
 "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "rostedt@goodmis.org" <rostedt@goodmis.org>, Srivatsa Bhat
 <srivatsab@vmware.com>, "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
 Alexey Makhalov <amakhalov@vmware.com>, Vasavi Sirnapalli
 <vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
 <er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
 "jailhouse-dev@googlegroups.com" <jailhouse-dev@googlegroups.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "acrn-dev@lists.projectacrn.org" <acrn-dev@lists.projectacrn.org>,
 "helgaas@kernel.org" <helgaas@kernel.org>, "bhelgaas@google.com"
 <bhelgaas@google.com>, Thomas Gleixner <tglx@linutronix.de>,
 "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
In-Reply-To: <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com>
 <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com>
 <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
Date: Tue, 04 Oct 2022 10:30:10 +0200
Message-ID: <87lepw9ejx.fsf@redhat.com>
MIME-Version: 1.0
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Nadav Amit <namit@vmware.com> writes:

> On Oct 3, 2022, at 8:03 AM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
>> Not my but rather PCI maintainer's call but IMHO dropping 'const' is
>> better, introducing a new global var is our 'last resort' and should be
>> avoided whenever possible. Alternatively, you can add a
>> raw_pci_ext_ops_preferred() function checking somethin within 'struct
>> hypervisor_x86' but I'm unsure if it's better.
>>=20
>> Also, please check Alex' question/suggestion.
>
> Here is my take (and Ajay knows probably more than me):
>
> Looking briefly on MCFG, I do not see a clean way of using the ACPI table=
.
> The two options are either to use a reserved field (which who knows, migh=
t
> be used one day) or some OEM ID. I am also not familiar with
> PCI_COMMAND.MEMORY=3D0, so Ajay can hopefully give some answer about that=
.
>
> Anyhow, I understand (although not relate) to the objection for a new glo=
bal
> variable. How about explicitly calling this hardware bug a =E2=80=9Cbug=
=E2=80=9D and using
> the proper infrastructure? Calling it explicitly a bug may even push whoe=
ver
> can to resolve it.
>
> IOW, how about doing something along the lines of (not tested):
>

Works for me. Going forward, the intention shoud be to also clear the
bug on other x86 hypervisors, e.g. we test modern Hyper-V versions and
if MMIO works well we clear it, we test modern QEMU/KVM setups and if
MMIO works introduce a feature bit somewhere and also clear the bug in
the guest when the bit is set.

--=20
Vitaly



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:31:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:31:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415250.659772 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdKq-0001v5-GF; Tue, 04 Oct 2022 08:31:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415250.659772; Tue, 04 Oct 2022 08:31:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdKq-0001uy-DU; Tue, 04 Oct 2022 08:31:28 +0000
Received: by outflank-mailman (input) for mailman id 415250;
 Tue, 04 Oct 2022 08:31:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofdKp-0001uI-1X
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:31:27 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60042.outbound.protection.outlook.com [40.107.6.42])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef6d0071-43be-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 10:31:26 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8206.eurprd04.prod.outlook.com (2603:10a6:102:1cb::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 08:31:24 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 08:31:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef6d0071-43be-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ngoAp4Iy9k4+5EKft1lzmJ2oDYl9W6MgP64XykLi60zdILPcH+kzHYNZdgjhPcbmAhe7ekRGd5wBoH59K/80bYsZlGPg0HAiFe7+xhXc2m9A+RTo3tXpgUk8fIWgAr58g62olJ/+1vjLkY/VWLGgZ9Ggkgvcw2J2eZZBHLTMeLQCAYDWYgztvJ4LFluKhuiSubRq923ILJX3kN9cGbP3D8yhcmEJkJzMNq5JvUKXVk5C/f9+jYsHCco+gn3GdaVDreyG0N3F6nmoxEIsegTzs+nz7qfjumbFqOt/VZiGC3WduGLlIiej+ZRN/0uNJ/Zy5g1y7lysJxyw9ojG0QS0ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=67hzZqxB4QTGLBeIr51HNNernqc0uOlWH5XYOthjQQA=;
 b=Mx89XbPAmPqycHCh9CthBlZVz6rj7t+tcn70YfBz1MGj6lBRq5T/ec3Lsy1kW4/RoNoqyEDNjU/q3YvJ7Myjh4YHubNoqY/ZPpPkaI7ExcqoAn2HK7wV8LCf0BhSu/CCtphoyhwPY1F5H4fRiEZqU3bHvBJRUgHokRoUK1u23qa0T/TS0mj/q95OyLo15/+zT7MvmKgef7MJqi3o7jF+++SGfV1dlzzefvvHXx6IRukoC1TZGatFOQsP/xT/1nNneaA8cKGabnWsk4Of17utARyPVVQUXMKTPWJEIsQpTJAvr8gNQMKV80gdXEJcKebOLJeAqbQ6OxJzks/96fEwPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=67hzZqxB4QTGLBeIr51HNNernqc0uOlWH5XYOthjQQA=;
 b=wGqUCuA91QL+9foN2LDKK4j1PEE1G38o0fx8jfx5KPWepeA/uPyaH/tWtuKubWq1Wr2KGtGUC7PHFQLLfEcgw7XSEgFyks6xiZIYWNrjS4FdVjlp2VDk9NzyIjxK/jIhtwufRpkWT0S7BRBMZx3JMDuO+vHBIkEpelg4rB80Tz8JyoAo4BcMZqLRmDIMJzTtory9uj5waCGuV4m9f0z7Ejha1GBt0Y4gZFIw+8LvX6SH23ksf+NxL8HOnRf/VNX/JnJrDxYDGaexgIbGQ4Lt3d33oAk9gFXEaHopa9O4HekRm2MYD1A7U60Q0ErLReJRf3iRLGBlcdh3M1PxiwRDhQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e42a2312-10e8-87f3-10c4-bb8e0bd765b0@suse.com>
Date: Tue, 4 Oct 2022 10:31:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] Use EfiACPIReclaimMemory for ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org
References: <2561c7fc38d9b4d17cb0205fec49b941894cfcc0.1664570575.git.demi@invisiblethingslab.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2561c7fc38d9b4d17cb0205fec49b941894cfcc0.1664570575.git.demi@invisiblethingslab.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0003.eurprd04.prod.outlook.com
 (2603:10a6:203:90::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8206:EE_
X-MS-Office365-Filtering-Correlation-Id: 0aed417e-caba-4b9c-450b-08daa5e2d293
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ushUk5PHCYcWrsFSdB7GkyL80+x1ZE98ymtmioChczqVR5zYU5E5HkYZeP7FM54ZbtCzBT3mSNmOdoRgwfe6RYQH0vE/uxYiNQK0RP/s/t9OlYoGjaEPUMdhIRhAAAqfDyYm4NEG/cGYscCul1S++RmlBvYD28iSjAIT4jfmXlqvOcRB3LZLe9Sc/9gwcEcivceqJeIZRRmtZkkO1OreE44fqZLItLDHyMTVxiova5WUBv64lBarMivuUAq4gbW4tt6Vx1QjS4nAk15sXupdJsPR+QNB0PF3cC6ZYfCQjESlEUS1qRutHI4Q3G7qXNtjpMk5txCHnQuadPRE+mrQYvOtBEq8iGCTUKgIdX0UHO5leylyzhFUT8kZieoF7rjylDZmthEe+bgKpj/eB1pLSyVwAhUQ8YXFmC6T27jueZWw9oTctrhzJ8Wr8uh86Ii07bxyZwxWUesxQ8JSdMiXWw7LwnC0N8KcZJCVioC/8MdvqSjLNv7kzm4VQhlj7zSBX46wO+2fhjgCceyDYrGwhp440fV7rUdWPYaEV5kijd6eP5iXYuP8ZmkVubas/JL11qJWBC+eLEasfu9LrGncz7286bYcSsrO87uILYxbn/JAgj+taU0E3cfy9YQk5uUWgamRD2Dq2mvwtCw1GW/d342AlpAYqsJGogCLUMbnHuGHr+W6Mh1RknKNrRh7180x8mq6doX70yRH1pbp/D4ZeRvEZgHKdn7yy2VZcndCpjwsk+YmdXcIdxRXDumZfHx/MJc5H5X4R4v8ZyRWK559NiHtRk2zEy4ZKhINs9LSdGw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(396003)(136003)(39860400002)(451199015)(31686004)(2906002)(38100700002)(478600001)(31696002)(36756003)(86362001)(66556008)(83380400001)(6506007)(2616005)(26005)(6512007)(53546011)(186003)(8676002)(4326008)(5660300002)(41300700001)(6486002)(8936002)(66946007)(66476007)(6916009)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ME1UZzNQM2U1dTNsU1BNV2lWczFLV0N3NlJXUkgwSVE2M3hNb2crSHJyVWxR?=
 =?utf-8?B?aU5HWnBzQ2VOY0tGdm01QkcyTWJJV3Y4OE5tTytLRFFKb294OWNrZERIYUww?=
 =?utf-8?B?OGNJelY4d2x1SmcveEY0OU5GWTFEOEpNTUM5SGJoVGYvTitoSTFTZFFCZ0Zx?=
 =?utf-8?B?K29EWk5iVlI3cUMyc0gvY2tKVWNRcjFmaXhUWEE5QlAyV0ptT0thZVdqbFY1?=
 =?utf-8?B?S1dqYU9mdkIvcCtBNnRCZStnejNFQnNDYi8zWEZiTDBIdXZBK0dDckFBS3dj?=
 =?utf-8?B?bkhlc0svcDloZjRWL0lzUHFzVy9uTE8rajhMeE5jK05rMWdERCtlYktXSmJO?=
 =?utf-8?B?R0hiV0U2Ymlvc3I4MmlHZkU0TXpwbFlnKzhDZWJyQnZ2RVEybllvcENGZG1M?=
 =?utf-8?B?a3NqdHR0WjJIaVJPS1FzNFVhRWhiNlZGZVJSUDUvUStDZWVPU2d0RzFsOS9v?=
 =?utf-8?B?L01GekJwTjFJNG5TN1FzV3l6a3c1YU9wUVgvbHp1YWdsZGY2Zk04aDBkbUkw?=
 =?utf-8?B?cU1WT1ZqdWpNNjdvTUlTRWIydmFjQ0VPakVuWkd3L0JuVVZRZXVsd0xQNWhJ?=
 =?utf-8?B?aVZ2U1hKYWNhdUtOcXNMKzFLL25kVlQ5WU9OZTBOWjM3azZ4U0hTRFBPQkNR?=
 =?utf-8?B?eEVEZ3E1V2VNOFlGbEpLMjZ5UWJvMHU4aU9lN0ZWcW14d09LeUdTM1N5ZVI4?=
 =?utf-8?B?YThRbHIyenh1WTBhTjRhM0h4NFFncC9KWXkyblZrQUJId3MrREZBeFZxY0p6?=
 =?utf-8?B?VEk4cmlHNGthRGVJNll5WG5jTnIyMjdWN0tEU1ovcmx4TnpJYlJTWEw2YVd4?=
 =?utf-8?B?TjJYdktmSWliNDZWb0FmNzF4WTF2Wk1RRGtDbVpLeWdBYzdFOTNCYjRzekJH?=
 =?utf-8?B?NWZWYUhnL2phOGd3SmhkSWY1WGdtRjkwYlhqQ0JYTXZRR1FteVhxWEdSQVZi?=
 =?utf-8?B?aUxVb0MzdXJ4M1p1YXRra3VVMTYybkZUeWp3R3FXZEcvWkRSNnhraEhwNjR1?=
 =?utf-8?B?VCtEdGx2VjNLUTlwbTFPSVJaWmZvRU94cXhuSkZrMzlFNTR4UlZzV3M2NDRW?=
 =?utf-8?B?Q3BQRlRPT3BKSlJ1UTFXaENheG1tSkN6QVBubTdvRzRWYlo5N3Fsc2FJNmQr?=
 =?utf-8?B?dDYzTUc2QnNHRElhUWFyMUZYeURvVEZsUVJ3WkVNR1ljQTFaa0dkSmZMTHln?=
 =?utf-8?B?b2s5bUhhL2x1a0tHTWdqRUhZT0cwUWg4azBOSWI5d0E0MUpkbEQ3T3ZWYi9y?=
 =?utf-8?B?WnBsR01OQllrNDBORWU2VWRFL3VWdUZRcXdPUmNWZDRoRzFFd0JIdzFqRCt5?=
 =?utf-8?B?U243TW0wallxcitiWXg2NHNRaGVIdG1SeFQxeC9FRW1BbDhzUEF6RFpmSmhh?=
 =?utf-8?B?c2kwRDJuZkVZZXg4dE4rQmVHK0VMMWpXb1Rza3V1RFNpRFlrYVRNeXNXL25a?=
 =?utf-8?B?S2YwUityVjJTd0l1Wk5YTXdUcEZzK1RlTERuNHdNUEJRWDB4ZXA3V1RROFhL?=
 =?utf-8?B?bnZtWGhURVUyOW1iNytscTBLcC9EMGRhTkY3VTJPMCs0YUVXN2swMDZnR0Np?=
 =?utf-8?B?SHpFYUp6a29pNzhUOFN2WTBvYlkyVU9MQUlmZVNUbTFUbXBqK2UzNEFzczU4?=
 =?utf-8?B?VENnc2tkdC9oaVF6RG1FSUpiSVE5Q0ptQ3dESmRoa1J0a1pOSzcxMW1PbUFi?=
 =?utf-8?B?Y2JEN1FNZFg1MFpuSCtRbUJ6ZEQyMFgxdk9QUWMzNWgzU0cxVHZPbzZSai9U?=
 =?utf-8?B?M2dudUFYL296WTl4dUwzanVKUUd1Tlh3WDNyLzFMSHl5d2liWjRNci9uU3JN?=
 =?utf-8?B?K0c1Zkw3Y0w5WDY2TEtubjJaS2VZWDlaU2pkSkc1NURaY0taZ2NiazkwVVRG?=
 =?utf-8?B?KzBDVTdQR0VPNU1lWndhNG55RVZ5d041QThhanBONytQOER4emZ0OExBaysr?=
 =?utf-8?B?Yk9WZElyOXlvdjVPV3JHTi9UUkNyRUlEZFdTTkZ1dHpyZDdYUnA4cUNsbU5R?=
 =?utf-8?B?Ly9ma21jUldTZVpPaEJMTjg0SlJQdFd2T0djVDhKdW1XYWZicUdFNzBHSDBn?=
 =?utf-8?B?ajF2STQ0T3A5OGlQRmlENGZ5VldGTks5VmJoeU1NeTg1RDI1VVFRNm1uY1NX?=
 =?utf-8?Q?Ni8UnAmqSfLEm2N3a8QrpueuG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aed417e-caba-4b9c-450b-08daa5e2d293
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 08:31:24.1655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TVk83NQV6xGr4kRhjCKdIriO8KHWSrN++43M17sqadTNGT+R33DtOZcoC0ZWspS8yAF9hjpyGfIy0BAwIhoBKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8206

On 30.09.2022 23:02, Demi Marie Obenour wrote:
> As discussed on xen-devel, using EfiRuntimeServicesData for more than is
> absolutely necessary is a bad idea.
> ---
>  xen/common/efi/boot.c | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index db0340c8e2628314226c618dda11ede4c62fdf3b..dba23439758d1e842d267dcd19448e0f9113b115 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -601,11 +601,13 @@ static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc)
>      if ( physical_start > esrt || esrt - physical_start >= len )
>          return 0;
>      /*
> -     * The specification requires EfiBootServicesData, but accept
> -     * EfiRuntimeServicesData, which is a more logical choice.
> +     * The specification requires EfiBootServicesData, but also accept
> +     * EfiRuntimeServicesData (for compatibility) and EfiACPIReclaimMemory
> +     * (which will contain the tables after successful kexec).

What's the compatibility concern here? We haven't released any Xen
version yet where the table would be moved to EfiRuntimeServicesData.

Jan

>       */
>      if ( (desc->Type != EfiRuntimeServicesData) &&
> -         (desc->Type != EfiBootServicesData) )
> +         (desc->Type != EfiBootServicesData) &&
> +         (desc->Type != EfiACPIReclaimMemory) )
>          return 0;
>      available_len = len - (esrt - physical_start);
>      if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) )
> @@ -1144,18 +1146,19 @@ static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable)
>      for ( i = 0; i < info_size; i += mdesc_size )
>      {
>          /*
> -         * ESRT needs to be moved to memory of type EfiRuntimeServicesData
> +         * ESRT needs to be moved to memory of type EfiACPIReclaimMemory
>           * so that the memory it is in will not be used for other purposes.
>           */
>          void *new_esrt = NULL;
> -        size_t esrt_size = get_esrt_size(memory_map + i);
> +        const EFI_MEMORY_DESCRIPTOR *desc = memory_map + i;
> +        size_t esrt_size = get_esrt_size(desc);
>  
>          if ( !esrt_size )
>              continue;
> -        if ( ((EFI_MEMORY_DESCRIPTOR *)(memory_map + i))->Type ==
> -             EfiRuntimeServicesData )
> +        if ( desc->Type == EfiRuntimeServicesData ||
> +             desc->Type == EfiACPIReclaimMemory )
>              break; /* ESRT already safe from reuse */
> -        status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size,
> +        status = efi_bs->AllocatePool(EfiACPIReclaimMemory, esrt_size,
>                                        &new_esrt);
>          if ( status == EFI_SUCCESS && new_esrt )
>          {



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:44:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:44:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415260.659783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXE-0003RG-Lv; Tue, 04 Oct 2022 08:44:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415260.659783; Tue, 04 Oct 2022 08:44:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXE-0003R9-J8; Tue, 04 Oct 2022 08:44:16 +0000
Received: by outflank-mailman (input) for mailman id 415260;
 Tue, 04 Oct 2022 08:44:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofdXD-0003R3-SV
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:44:15 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9888635-43c0-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 10:44:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EE5721F906;
 Tue,  4 Oct 2022 08:44:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A4D3139D2;
 Tue,  4 Oct 2022 08:44:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id m9ZEJF3yO2OjVwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 08:44:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9888635-43c0-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664873053; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=pkvZorSqwy2f71DPO/+7+BS5jmcswx42HigCezR1J2c=;
	b=htAnD9jVfSLDJkzaPxT31pjcyxBQjj+t59V8w6XLyz8YrjMUa8Vy2EzU84Kq52RaRo6d5n
	aa0YhuQ/1q9iaLI+0ULaX/7o/9+88FXRcgFgk15Hewr1mj3Kk21JhfWOpbTj2nGhGu/won
	PXqtACp/oAEAq1Gx8lVJ7ky+TV3sg4A=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	linux-doc@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH v2 0/3] xen/pv: sanitize xen pv guest msr accesses
Date: Tue,  4 Oct 2022 10:43:32 +0200
Message-Id: <20221004084335.2838-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Historically when running as Xen PV guest all MSR accesses have been
silently swallowing any GP faults, even when the kernel was using not
the *msr_safe() access functions.

Change that by making the behavior controllable via kernel config and
via a boot parameter.

This will help finding paths where MSRs are being accessed under Xen
which are not emulated by the hypervisor.

Juergen Gross (3):
  xen/pv: allow pmu msr accesses to cause GP
  xen/pv: refactor msr access functions to support safe and unsafe
    accesses
  xen/pv: support selecting safe/unsafe msr accesses

 .../admin-guide/kernel-parameters.txt         |  6 ++
 arch/x86/xen/Kconfig                          |  9 ++
 arch/x86/xen/enlighten_pv.c                   | 99 +++++++++++++------
 arch/x86/xen/pmu.c                            | 61 ++++++------
 4 files changed, 118 insertions(+), 57 deletions(-)

-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:44:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:44:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415261.659793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXK-0003i3-Tg; Tue, 04 Oct 2022 08:44:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415261.659793; Tue, 04 Oct 2022 08:44:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXK-0003hr-Qu; Tue, 04 Oct 2022 08:44:22 +0000
Received: by outflank-mailman (input) for mailman id 415261;
 Tue, 04 Oct 2022 08:44:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofdXJ-0003h7-Oc
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:44:21 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bcb924e1-43c0-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 10:44:20 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id AD48F1F909;
 Tue,  4 Oct 2022 08:44:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 66731139D2;
 Tue,  4 Oct 2022 08:44:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 3f3BF2PyO2OpVwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 08:44:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bcb924e1-43c0-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664873059; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NnOBG7dPJJxOFbSXECzEyNs/pZFtg7J3uSYUDX0hJuc=;
	b=DVk72WoqFGUhkClh0eikyDJjWI1vrwOAqEGWlI6G7eiI8jfg0qNJyRN+eacKsCWbQbv6G4
	bkzMEiTdxHzdA++LqakKAWU8Nd8qVtje9HF5nf/uMJtJLiPN4I5rWRQd2WZzoVeG+xr7WS
	+hmgaRSunDvSY21mr96NQwNnMLa17S0=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 1/3] xen/pv: allow pmu msr accesses to cause GP
Date: Tue,  4 Oct 2022 10:43:33 +0200
Message-Id: <20221004084335.2838-2-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221004084335.2838-1-jgross@suse.com>
References: <20221004084335.2838-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants
of read/write MSR in case the MSR access isn't emulated via Xen. Allow
the caller to select the potentially faulting variant by passing NULL
for the error pointer.

Restructure the code to make it more readable.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- do some restructuring (Jan Beulich, Boris Ostrovsky)
---
 arch/x86/xen/pmu.c | 61 +++++++++++++++++++++++++---------------------
 1 file changed, 33 insertions(+), 28 deletions(-)

diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 21ecbe754cb2..501b6f872d96 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -131,6 +131,9 @@ static inline uint32_t get_fam15h_addr(u32 addr)
 
 static inline bool is_amd_pmu_msr(unsigned int msr)
 {
+	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
+		return false;
+
 	if ((msr >= MSR_F15H_PERF_CTL &&
 	     msr < MSR_F15H_PERF_CTR + (amd_num_counters * 2)) ||
 	    (msr >= MSR_K7_EVNTSEL0 &&
@@ -144,6 +147,9 @@ static int is_intel_pmu_msr(u32 msr_index, int *type, int *index)
 {
 	u32 msr_index_pmc;
 
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
+		return false;
+
 	switch (msr_index) {
 	case MSR_CORE_PERF_FIXED_CTR_CTRL:
 	case MSR_IA32_DS_AREA:
@@ -292,46 +298,45 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read)
 
 bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err)
 {
-	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
-		if (is_amd_pmu_msr(msr)) {
-			if (!xen_amd_pmu_emulate(msr, val, 1))
-				*val = native_read_msr_safe(msr, err);
-			return true;
-		}
-	} else {
-		int type, index;
+	int type, index;
+	bool emulated;
 
-		if (is_intel_pmu_msr(msr, &type, &index)) {
-			if (!xen_intel_pmu_emulate(msr, val, type, index, 1))
-				*val = native_read_msr_safe(msr, err);
-			return true;
-		}
+	if (is_amd_pmu_msr(msr))
+		emulated = xen_amd_pmu_emulate(msr, val, 1);
+	else if (is_intel_pmu_msr(msr, &type, &index))
+		emulated = xen_intel_pmu_emulate(msr, val, type, index, 1);
+	else
+		return false;
+
+	if (!emulated) {
+		*val = err ? native_read_msr_safe(msr, err)
+			   : native_read_msr(msr);
 	}
 
-	return false;
+	return true;
 }
 
 bool pmu_msr_write(unsigned int msr, uint32_t low, uint32_t high, int *err)
 {
 	uint64_t val = ((uint64_t)high << 32) | low;
+	int type, index;
+	bool emulated;
 
-	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
-		if (is_amd_pmu_msr(msr)) {
-			if (!xen_amd_pmu_emulate(msr, &val, 0))
-				*err = native_write_msr_safe(msr, low, high);
-			return true;
-		}
-	} else {
-		int type, index;
+	if (is_amd_pmu_msr(msr))
+		emulated = xen_amd_pmu_emulate(msr, &val, 0);
+	else if (is_intel_pmu_msr(msr, &type, &index))
+		emulated = xen_intel_pmu_emulate(msr, &val, type, index, 0);
+	else
+		return false;
 
-		if (is_intel_pmu_msr(msr, &type, &index)) {
-			if (!xen_intel_pmu_emulate(msr, &val, type, index, 0))
-				*err = native_write_msr_safe(msr, low, high);
-			return true;
-		}
+	if (!emulated) {
+		if (err)
+			*err = native_write_msr_safe(msr, low, high);
+		else
+			native_write_msr(msr, low, high);
 	}
 
-	return false;
+	return true;
 }
 
 static unsigned long long xen_amd_read_pmc(int counter)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:44:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:44:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415262.659805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXQ-00042B-AW; Tue, 04 Oct 2022 08:44:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415262.659805; Tue, 04 Oct 2022 08:44:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXQ-000424-7M; Tue, 04 Oct 2022 08:44:28 +0000
Received: by outflank-mailman (input) for mailman id 415262;
 Tue, 04 Oct 2022 08:44:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofdXO-0003R3-EF
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:44:26 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c0296207-43c0-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 10:44:25 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5E8B41F8FC;
 Tue,  4 Oct 2022 08:44:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 17BC0139D2;
 Tue,  4 Oct 2022 08:44:25 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1/l0BGnyO2O4VwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 08:44:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0296207-43c0-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664873065; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rg7G2sE/xwQjZFXkh5AfLZ6BOzaSFVCwXC3avs7dOhM=;
	b=A+NxQexafoTYnVQ/mf4TVXN0GkLKIg2mP5sKyx1Gz2V3ktHdatz1HlJqgWcQIRhl5hOeoT
	3Q0+qKFhx2Ufd9teMM1JVfivPQD8aszyNe/LecnT3KZRw2nHdoey3kERS7LrsUGl99ZLcS
	S5gceBOro6LRxBH1JdWTsKpWGfKCeuU=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 2/3] xen/pv: refactor msr access functions to support safe and unsafe accesses
Date: Tue,  4 Oct 2022 10:43:34 +0200
Message-Id: <20221004084335.2838-3-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221004084335.2838-1-jgross@suse.com>
References: <20221004084335.2838-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Refactor and rename xen_read_msr_safe() and xen_write_msr_safe() to
support both cases of MSR accesses, safe ones and potentially GP-fault
generating ones.

This will prepare to no longer swallow GPs silently in xen_read_msr()
and xen_write_msr().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- init val in xen_do_read_msr() to 0 (Jan Beulich)
---
 arch/x86/xen/enlighten_pv.c | 75 +++++++++++++++++++++++++++----------
 1 file changed, 56 insertions(+), 19 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 9b1a58dda935..d5b0844a1b7c 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -917,14 +917,18 @@ static void xen_write_cr4(unsigned long cr4)
 	native_write_cr4(cr4);
 }
 
-static u64 xen_read_msr_safe(unsigned int msr, int *err)
+static u64 xen_do_read_msr(unsigned int msr, int *err)
 {
-	u64 val;
+	u64 val = 0;	/* Avoid uninitialized value for safe variant. */
 
 	if (pmu_msr_read(msr, &val, err))
 		return val;
 
-	val = native_read_msr_safe(msr, err);
+	if (err)
+		val = native_read_msr_safe(msr, err);
+	else
+		val = native_read_msr(msr);
+
 	switch (msr) {
 	case MSR_IA32_APICBASE:
 		val &= ~X2APIC_ENABLE;
@@ -933,23 +937,39 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err)
 	return val;
 }
 
-static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
+static void set_seg(unsigned int which, unsigned int low, unsigned int high,
+		    int *err)
 {
-	int ret;
-	unsigned int which;
-	u64 base;
+	u64 base = ((u64)high << 32) | low;
+
+	if (HYPERVISOR_set_segment_base(which, base) == 0)
+		return;
 
-	ret = 0;
+	if (err)
+		*err = -EIO;
+	else
+		WARN(1, "Xen set_segment_base(%u, %llx) failed\n", which, base);
+}
 
+/*
+ * Support write_msr_safe() and write_msr() semantics.
+ * With err == NULL write_msr() semantics are selected.
+ * Supplying an err pointer requires err to be pre-initialized with 0.
+ */
+static void xen_do_write_msr(unsigned int msr, unsigned int low,
+			     unsigned int high, int *err)
+{
 	switch (msr) {
-	case MSR_FS_BASE:		which = SEGBASE_FS; goto set;
-	case MSR_KERNEL_GS_BASE:	which = SEGBASE_GS_USER; goto set;
-	case MSR_GS_BASE:		which = SEGBASE_GS_KERNEL; goto set;
-
-	set:
-		base = ((u64)high << 32) | low;
-		if (HYPERVISOR_set_segment_base(which, base) != 0)
-			ret = -EIO;
+	case MSR_FS_BASE:
+		set_seg(SEGBASE_FS, low, high, err);
+		break;
+
+	case MSR_KERNEL_GS_BASE:
+		set_seg(SEGBASE_GS_USER, low, high, err);
+		break;
+
+	case MSR_GS_BASE:
+		set_seg(SEGBASE_GS_KERNEL, low, high, err);
 		break;
 
 	case MSR_STAR:
@@ -965,11 +985,28 @@ static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
 		break;
 
 	default:
-		if (!pmu_msr_write(msr, low, high, &ret))
-			ret = native_write_msr_safe(msr, low, high);
+		if (!pmu_msr_write(msr, low, high, err)) {
+			if (err)
+				*err = native_write_msr_safe(msr, low, high);
+			else
+				native_write_msr(msr, low, high);
+		}
 	}
+}
+
+static u64 xen_read_msr_safe(unsigned int msr, int *err)
+{
+	return xen_do_read_msr(msr, err);
+}
+
+static int xen_write_msr_safe(unsigned int msr, unsigned int low,
+			      unsigned int high)
+{
+	int err = 0;
+
+	xen_do_write_msr(msr, low, high, &err);
 
-	return ret;
+	return err;
 }
 
 static u64 xen_read_msr(unsigned int msr)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 08:44:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 08:44:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415263.659816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXU-0004MQ-JN; Tue, 04 Oct 2022 08:44:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415263.659816; Tue, 04 Oct 2022 08:44:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdXU-0004MH-GY; Tue, 04 Oct 2022 08:44:32 +0000
Received: by outflank-mailman (input) for mailman id 415263;
 Tue, 04 Oct 2022 08:44:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofdXU-0003h7-1Q
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 08:44:32 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c37e190f-43c0-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 10:44:31 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 11EBB1F906;
 Tue,  4 Oct 2022 08:44:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9E1D139D2;
 Tue,  4 Oct 2022 08:44:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OoYyLG7yO2PGVwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 08:44:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c37e190f-43c0-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664873071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=j+lb+y1NjPOXtKvMZH/DFSB4E2HI7Wk27OuXyDj7Pes=;
	b=V5kYOfYG/kj7NXn15dK5dXFgizcJc0Xl1WjROjliBeu1yo+TIE6Sr3gVqM+UWRTYj9Tfil
	ASTZ7BUd2XV0WR39svbS+pg2w8Egm8ZAxheUGff0g9ixjcUtg+oeLNAbxtIhGaTZ+qv1Ug
	qKGMIb1hvqpeMW5WsqqTFd+LstFgDrE=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	linux-doc@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 3/3] xen/pv: support selecting safe/unsafe msr accesses
Date: Tue,  4 Oct 2022 10:43:35 +0200
Message-Id: <20221004084335.2838-4-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221004084335.2838-1-jgross@suse.com>
References: <20221004084335.2838-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of always doing the safe variants for reading and writing MSRs
in Xen PV guests, make the behavior controllable via Kconfig option
and a boot parameter.

The default will be the current behavior, which is to always use the
safe variant.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 .../admin-guide/kernel-parameters.txt         |  6 +++++
 arch/x86/xen/Kconfig                          |  9 +++++++
 arch/x86/xen/enlighten_pv.c                   | 24 +++++++++++--------
 3 files changed, 29 insertions(+), 10 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 426fa892d311..1bda9cf18fae 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -6836,6 +6836,12 @@
 			Crash from Xen panic notifier, without executing late
 			panic() code such as dumping handler.
 
+	xen_msr_safe=	[X86,XEN]
+			Format: <bool>
+			Select whether to always use non-faulting (safe) MSR
+			access functions when running as Xen PV guest. The
+			default value is controlled by CONFIG_XEN_PV_MSR_SAFE.
+
 	xen_nopvspin	[X86,XEN]
 			Disables the qspinlock slowpath using Xen PV optimizations.
 			This parameter is obsoleted by "nopvspin" parameter, which
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 85246dd9faa1..9b1ec5d8c99c 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -92,3 +92,12 @@ config XEN_DOM0
 	select X86_X2APIC if XEN_PVH && X86_64
 	help
 	  Support running as a Xen Dom0 guest.
+
+config XEN_PV_MSR_SAFE
+	bool "Always use safe MSR accesses in PV guests"
+	default y
+	depends on XEN_PV
+	help
+	  Use safe (not faulting) MSR access functions even if the MSR access
+	  should not fault anyway.
+	  The default can be changed by using the "xen_msr_safe" boot parameter.
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index d5b0844a1b7c..daae454191f2 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -108,6 +108,16 @@ struct tls_descs {
  */
 static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc);
 
+static __read_mostly bool xen_msr_safe = IS_ENABLED(CONFIG_XEN_PV_MSR_SAFE);
+
+static int __init parse_xen_msr_safe(char *str)
+{
+	if (str)
+		return strtobool(str, &xen_msr_safe);
+	return -EINVAL;
+}
+early_param("xen_msr_safe", parse_xen_msr_safe);
+
 static void __init xen_pv_init_platform(void)
 {
 	/* PV guests can't operate virtio devices without grants. */
@@ -1011,22 +1021,16 @@ static int xen_write_msr_safe(unsigned int msr, unsigned int low,
 
 static u64 xen_read_msr(unsigned int msr)
 {
-	/*
-	 * This will silently swallow a #GP from RDMSR.  It may be worth
-	 * changing that.
-	 */
 	int err;
 
-	return xen_read_msr_safe(msr, &err);
+	return xen_do_read_msr(msr, xen_msr_safe ? &err : NULL);
 }
 
 static void xen_write_msr(unsigned int msr, unsigned low, unsigned high)
 {
-	/*
-	 * This will silently swallow a #GP from WRMSR.  It may be worth
-	 * changing that.
-	 */
-	xen_write_msr_safe(msr, low, high);
+	int err;
+
+	xen_do_write_msr(msr, low, high, xen_msr_safe ? &err : NULL);
 }
 
 /* This is called once we have the cpu_possible_mask */
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:01:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:01:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415292.659827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdnk-0007ah-W3; Tue, 04 Oct 2022 09:01:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415292.659827; Tue, 04 Oct 2022 09:01:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofdnk-0007aa-TH; Tue, 04 Oct 2022 09:01:20 +0000
Received: by outflank-mailman (input) for mailman id 415292;
 Tue, 04 Oct 2022 09:01:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofdnk-0007aU-65
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 09:01:20 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70052.outbound.protection.outlook.com [40.107.7.52])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1bfa96ee-43c3-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 11:01:18 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7331.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 09:01:17 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 09:01:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bfa96ee-43c3-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LwxhwiaQO1T8phbWfZI4pCx+xYuOJzPCVJSXrDimaBQH40xeSM816EbIY31qcAC3XXR1PBluyZvtvLwtEUxEu+xSsFglymb3KeEGJp87O3+zjvcAyOegXs9YgpBCG17fA7/eZC3fgpd8+JMsR9a/s0T/myTkwl2vDrws3PWrVDp4plwAWfSjkT80g0kRQrTcqoP14CTX6Hv1lIPp7p6ILAeyTJZB9fHwFIPkbAt4Q5y81ZGy6NElkfRhxO050OFuPU+U32JXSvjfq50WU0H4vLEOY9HD5eI83fqj5o5xX0CHRYOw09uFZLbsJiHHCttfuAIZfb5Ts86LCnKckksftA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YoUS/O8YApbCBPHVh4q9PYlIAPnSZtyR0i4hIScy2rM=;
 b=jBYInax4ecJnVE3jcFfy9iRQXEIANHTmtXlO5HSrerPTc+qlgnRPojjxCFjuGj5wVoTlUI4ikSnC2rpavFGAfNqWnhGGojGM+zgmVeGYkSy/UFTZFf6nbhLRQXnT6kd0uNT5i5nUWuUYuuVrib1MsglBqzgHcjb0QK3KqMbwSuiJEmxMWcu5+g4CYPRz20EtVLhIad41uoXFxkfZs9fYhV49G5kx43JoON5EM3Jx/CXC/iukz9XebDrGGXoxXjXiSlSATj5ZBbs35r0ukRbTrLlQ6amYY31tfd84InOK23ITYxqaZFGjpPjsC0yby1QD9WadnqOMmmrw6LOUbqFYag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YoUS/O8YApbCBPHVh4q9PYlIAPnSZtyR0i4hIScy2rM=;
 b=tE4ZB8dsVWSBH0dM7M9DtwmjEenQ9uFuuHPuNca49AMtCOaHvXAHB8Ytvw6oifYjel8KzUEIcQzMMFaL7vDVoKNhxkc6S3pCFTTttvK24dLX36wc1/KPYz8bA4i1rVU2cICoW93YIinFxWdVQzpMbeO++hGZo8d5zBEVuaB9rXZ3gFd9C8bCzmtH6+D+qGGrN3uKtFj1ezjh/kbM5AfYWRr0WrRKoNRnijp4lCHsHAgc0GuJlC73Gd0Xw+0m37KFXdHerGD1RHK10+/Cybj3acKJXfWE1W/Hco4oeMqeABLTzmt8adxiHXnglQRzuSWbTIAKSZQSRTBLyvAPFIB9IA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
Date: Tue, 4 Oct 2022 11:01:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220930141737.67574-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220930141737.67574-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7331:EE_
X-MS-Office365-Filtering-Correlation-Id: 92759e34-ee2c-48f1-9ea5-08daa5e6ff54
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3Ix7CZaghRm2R9ZDMmln6ydRjpd4iGCcX1tJ4xmTAkZrtD/sV1XekI03kfSbbVNDESDEhr0YtKfA+GTVz+uCOK9fx5t3YSQHeYeJSdigeMJY/woUk96zkDk6PUWj7Gh/MS4ANuso+MXpOz4VZlOhHtsTd7SEOZcwrvG1DwUJLsFyr2fj1ER+8/M6miw1wTyFmto+eUZ7OAoO71JxCk6S+dEAmS6qJP620QID+bGu0WoHjrntnOFUw+9dA51YyyHVGDVvNJ4dxvsqFBcbUj6PRkb+BH0pVr7e1+ikYcmeqRfmwgRP/yswcKy+tmWWn3FmKp/y3VJWSDtydggz5SpHwLIdQpRD0zFM9FdscgKC6kb/aMGtdA/zsI06LlO4uIdWJT1dL/ISuRBM8s7r4u5PXWHHCSPRCJxArFpnEkA7OCg2E5RmepNKisKK0MZVp3cDioJCKmO6+K4sRznq7rWdXAbvek1542s6deNMYNDdOWogXCs+va2DypThrxC3SvpWFre6bvqyRb54teJM2WClLOqAJe0Bl7Rf3nv3HrG+fjQwp38QytPPhOS6zopWfDWveyZ/q68StNPPuQNZkYU6dCXN39qQsf/5JX/m1BehdsbevFJHgXDCCZyU5GRtQM5punLD2YQf1cg7I2C9Ban4DpYecGYecEUGTRHpur5Sv/H3mGBK4BbYepQifY7OymDUwcyg6ncz2yq2I+GYWnLxYqDmwLUAkmyGCGYdYxDe8+LdfTr1cX7etrnbu0S2+SmGNWe+tMTIFBUlj1gOQMvgIXGrDjHYPR+gH1iR/B7hldU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199015)(5660300002)(41300700001)(2906002)(66556008)(66946007)(2616005)(6512007)(26005)(186003)(8676002)(4326008)(66476007)(38100700002)(36756003)(31686004)(6506007)(8936002)(83380400001)(6916009)(54906003)(6486002)(53546011)(478600001)(31696002)(316002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHljeHR4T2VzbEUwdnUxSUtRUWZHMGVUWE5QTUNBRXlMRHZkbHhsNWl3c3VI?=
 =?utf-8?B?bE0yTGo4S0tIejdvTU1pZG1PYWF1aTU5bnBlSDZJcEZ1R3dmbjY2TVVKQXA5?=
 =?utf-8?B?dXlFYzNha2NPUHlPdWg0T3VnNkRIdFcwNk1DdlFud0p0RWhrY3lYQ3h6UC9J?=
 =?utf-8?B?VDE4N2Mxc1ZVT3RZZlVUZjBKVk14UURLS3U2U0ZwSjAxZmg1eU83QTgzMnlS?=
 =?utf-8?B?aVVveWJFUDhxQWl6clA5RlFMTlNESk5jd2FjM0tlTy96K0UxY1QzYmJPTm1V?=
 =?utf-8?B?T01XSW1rYkdaWUdrMlZVRUdzQWIzU0hyMnQrR0M3WFcyc1hPVVRRaGxHQXkx?=
 =?utf-8?B?aVFYZENxbld1R3ZCUUdkN0RaaDBBMStOVG8ranRCT0V5aG55VzJhVUZQM0dk?=
 =?utf-8?B?YTEyd2VNUFd1NXpwN3Z6SFY5R2lkUTdYclU0WGIyWGtTa2U2cXhjbkdFUHNG?=
 =?utf-8?B?c0U5OUVFdEgxZFJGZHFrcDROMjlKOTNJNkUwYnhPZFFERUZxM3AzZ1p6Y1E3?=
 =?utf-8?B?d3lwRFRqeW9iamRrMzFqRnB0OGwrUDJqeEx3ZE8yYXd6cVU3VktLOUNxaHF0?=
 =?utf-8?B?VEVkZlFTNjRQcVdiZEtPR05ZMGpvZ0NWVzJEeFplSUo5cU12alZtL0w4ZnZ6?=
 =?utf-8?B?OWNjMFFwdDZUemNCYWxIeVlnWkdHRG45cGtaWERDdGUxT3E1bUs3RGp4Ti9q?=
 =?utf-8?B?aTNxTzZEZ3dvc3orTTkxTW5mcXVWQlVtQW04NkJmNTNWTzVabmhlRWUvb3FJ?=
 =?utf-8?B?ZEJxZFdLTFd5MHV3bDJYNS9ycEpObmFTN1VVQlpFcTRKNmdrdVVnaWc3eTlq?=
 =?utf-8?B?YXNnUytVcUloL3J2dnZjWEMwbVQvRUFISHNMbldjU0I4Z1RrUjVGSTkxbUNN?=
 =?utf-8?B?MERWb21lcFo0MlMyK1MrRFIycFM5VktQWWl5ZS8xMXhKTUErOGppdjY5RTVD?=
 =?utf-8?B?bVl3K0hZT3dPbWVGVW5KQmI5ajNpTFptNHFzNUduK3BtY0dVNHZJNzRmdzZ2?=
 =?utf-8?B?WFpBeVF5c3lTTnUrMWs5aG5rWnhvK0lrREVWMUlCTk1IZFN6RjNQT05KdE5E?=
 =?utf-8?B?SFJSMThnTmZBRklkVnJPZTdudFRwcGdwWFJIWW13Q2kwdEg2YUI3K3llUS9n?=
 =?utf-8?B?c0lleC9kQm5uVkcwSkFHanRhc0pURlZoVWpVTk5XVHJCeXpvRGdlSEVUNXA2?=
 =?utf-8?B?elRzV1lIaXkyZzA3MnYyQTVJeFZSMEk4QTdnQUZIcERzbzBqbmV2ZzRrMVdx?=
 =?utf-8?B?MnBtRk1oaS9WYUNPSXY4RGczQ2k1ZFhBMzJid1ozcG1JWjJoU2J5RTVOQTlz?=
 =?utf-8?B?VkNTdC9PSW9vbTI3b2Q1SnBub3pPYkxqUG5uOURvcm03TmZTNlZCYkJQU2Nl?=
 =?utf-8?B?ZmE0Z2d6VWhtVnYzbHZsOEpyZkltTEp3SmJJWW1jcXdSU1VyTjNlQ3RMT01T?=
 =?utf-8?B?bXFsRCt4bmlZZUp5Vi9UUCtlY2RILzJHVE5mUVVRdG1kRU9Ibisxd2NvZWNZ?=
 =?utf-8?B?d2tSNlJidjcvandiK0ZjTHYyNUphNWk2enV0SmZqZnlTMklJOXFUT0hnSDdu?=
 =?utf-8?B?WXk5OEpZaTI2MzVVTnFLWFlKclRjclUrMlA4VWFMWEJ2MVFvZ0Y2R0NBZWdI?=
 =?utf-8?B?dzFEcVZYTG1Td3E4M3g4K205Wkk2UzZJVEhRT2pUR292c2tjdFBHa2paTDU5?=
 =?utf-8?B?ZHZvUTE3M1ZOTFQ5eXUwcHdvcmVhMVhEWGZmci8zQ1JLbGtwQnNPYkZIaXFO?=
 =?utf-8?B?KzFjMDU4Zk5Da0JuYnVtdW53c2ZJaHgzUlE3Y2xpTlUwVG4vVkFraTFDVEUr?=
 =?utf-8?B?NzYrNmdmSkFTclJJSGlkOGFFUUdtQzBubEhhVlFRa0RreThFLzhYck5nTHMw?=
 =?utf-8?B?NWtFRE5DVDkrQXpIUmI4Y1l1ZmQxTHNCNHQwVlppdzFpRWMyNzE1UDNPYkJE?=
 =?utf-8?B?ZUlxV0VaSVZWOE5ybDFDemkwSWRLTzBFOWc5dzdYUXpvcDdTTDYrcEV0ZytQ?=
 =?utf-8?B?K1hZMFhXbnBOemQ0elJBNmVBOVUxOEs2SjRUR1FHZnEvME9ScmRtZis2cVZx?=
 =?utf-8?B?SGc3aDFyc1luVG1oUi9jY3BQL0F0VWtUTDFvM01wekc3RSt0THNobnVOWS9r?=
 =?utf-8?Q?WBeEbT9CS1SeskJVXr31xhHJD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92759e34-ee2c-48f1-9ea5-08daa5e6ff54
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:01:17.2236
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uSnMEeITy3v2QsHKUTY1Oxp5ED/y+2JL4ZrGvD4r/0YrNHxC3KZ5Yh6i/+8oHym6uq0fYNwLawoabvlPzkss1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7331

On 30.09.2022 16:17, Roger Pau Monne wrote:
> The EFI memory map contains two memory types (EfiMemoryMappedIO and
> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
> devices used by EFI.
> 
> The current parsing of the EFI memory map was translating
> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
> x86.  This is an issue because device MMIO regions (BARs) should not
> be positioned on reserved regions.  Any BARs positioned on non-hole
> areas of the memory map will cause is_memory_hole() to return false,
> which would then cause memory decoding to be disabled for such device.
> This leads to EFI firmware malfunctions when using runtime services.
> 
> The system under which this was observed has:
> 
> EFI memory map:
> [...]
>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> [...]
> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> 
> The device behind this BAR is:
> 
> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> 	Subsystem: Super Micro Computer Inc Device 091c
> 	Flags: fast devsel
> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> 
> For the record, the symptom observed in that machine was a hard freeze
> when attempting to set an EFI variable (XEN_EFI_set_variable).
> 
> Fix by not adding regions with type EfiMemoryMappedIO or
> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
> be positioned there.
> 
> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

In the best case this is moving us from one way of being wrong to another:
So far we wrongly include BARs in E820_RESERVED (_if_ they can be
legitimately covered by a EfiMemoryMappedIO region in the first place,
which I'm not sure is actually permitted - iirc just like E820_RESERVED
may not be used for BARs, this memory type also may not be), whereas with
your change we would no longer report non-BAR MMIO space (chipset specific
ranges for example) as reserved. In fact I think the example you provide
is at least partly due to bogus firmware behavior: The BAR is put in space
normally used for firmware specific memory (MMIO) ranges. I think firmware
should either assign the BAR differently or exclude the range from the
memory map.

I guess instead we want to handle the example you give by a firmware quirk
workaround.

> ---
> I don't understand the definition of EfiMemoryMappedIOPortSpace:
> 
> "System memory-mapped IO region that is used to translate memory
> cycles to IO cycles by the processor."

That's something (only?) IA-64 used, where kind of as a "replacement" for
x86 I/O port accesses equivalents thereof were provided (iirc 4 ports
per page) via MMIO accesses. It is this compatibility MMIO space which is
marked this way. Such ranges should never be seen on (current) x86.

> But given its name I would assume it's also likely used to mark ranges
> in use by PCI device BARs.
> 
> It would also be interesting to forward this information to dom0, so
> it doesn't attempt to move the BARs of this device(s) around, or else
> issues will arise.

None of this is device specific. There's simply (typically) one MMIO
range covering the entire 64k or I/O port space.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:25:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:25:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415300.659838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeBH-0001d2-Ub; Tue, 04 Oct 2022 09:25:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415300.659838; Tue, 04 Oct 2022 09:25:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeBH-0001cv-Rq; Tue, 04 Oct 2022 09:25:39 +0000
Received: by outflank-mailman (input) for mailman id 415300;
 Tue, 04 Oct 2022 09:25:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofeBG-0001cp-Co
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 09:25:38 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80271bff-43c6-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 11:25:35 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7312.eurprd04.prod.outlook.com (2603:10a6:800:1a5::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 09:25:33 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 09:25:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80271bff-43c6-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aF7ZegPnidQPftQ4D3frcHluTmkzNFklfLBRNDoz4r0l1+T10X8NX2m+ZQaIWUGUWZmeua5iewSLrd+qYuYVWxWM9pKDJ8+7OZCZ3DrpCjxjfAoRrWb3mx7C9tk8ug5XCViTC+oYbr3Hqmni5yyqLj4AeqmlnUvEIftjtVB+X27tejxd+s3B5EarSpySteEqd/2wCyV8OsYxXHLFtywi+2dYB6saCzCx6ylckye49thSLJGpcSEVF+WVvE2w1mEn2I8bLeIqRdciVyk+pBr8Iee1SYVHul7hPhrmsO6F0nlpZAeJbOPnOgynhHPDK0Rxj0fGhz/Rmt5fFx2PztFY/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1FSt/D5sfWyuRU/uxuitTFK9A0wqUJfFx/hH7DhOg6c=;
 b=SKWTuig4tl/0zXW3+xfuguN3iZZv+N+hgoXDj+vrpKXI7faAO3nlpE7N/EWGQFIC8Qzv8mWYnlTJpzqvqsmH8/bT6yRiYODYDxeEd20byo7kTsPLSdC4uFRLbVvOXdgbcHHQL/Jf2rQn5AJdD2rTF+8RWhDxuCuj0JMkd3yTKva5nCPtFWX790ctWBFhk66jSV/1nIXZLW96MAyOku1ma1bYiHFCkOV/gqnjLPYtG3mSVF5MnRV5vRGZs3sjXFO/lT0zy1Ji06uZLNiy9s/l+mSlk9GfrNVTIBN1ZH5oN0vrz35kz8K4ftqY3ML1m+RDL8kr1tv+3xdHGurSoNUgHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1FSt/D5sfWyuRU/uxuitTFK9A0wqUJfFx/hH7DhOg6c=;
 b=aU+pkUHYhr73tv2XgFAA+yB62RSYvYgJ60bAxpGrKgCm0i/O4l6qVSqwzXwxQwfGjkAsLlNMU4AT3k2KylXKEBckFj087q+WuNkWqYqEs6KGdVRJWv+aTjr6A2TTtXSYUQBQF4tTM8soJG16t1E0n6kCqOUiJO2c0fNv0379kKXF5OGd5jd3o0xlnw5wmRANzjFVBzWbhCRFSdbkuxS7haCfzwOmmtx6SIPGzfDOvD1wDzcsdZLqnMDHkOtm4q6qx9iToesQ7+iKqqGT1H36x/MXQ5TDgsRNRtOxSFDswVytmDDwqH8t8fibiTOQ+ty2nORvyxt5Jk+vJEGC3VBYLA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c84a70cc-ce2a-8cc4-dbcc-058cb4a9669d@suse.com>
Date: Tue, 4 Oct 2022 11:25:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: x86 NUMA error on OSSTest box
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Henry Wang <Henry.Wang@arm.com>,
 xen-devel <xen-devel@lists.xenproject.org>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <5dba58e7-491c-d396-ea1c-de03dc0053bd@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5dba58e7-491c-d396-ea1c-de03dc0053bd@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::23) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7312:EE_
X-MS-Office365-Filtering-Correlation-Id: 780650c5-14a3-4c1e-e3b6-08daa5ea6371
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Mfabfg55x+QIQXfquaKuLhOfH53tYLa9zeRNlP4KOu1gryCQ70gIyvt8KbK8iBUAv8fx/zDLTo9u0sI9uwYrBw2Wde/TNPybT9ZaQo/D3xSvkvlRvUFNCVrIvtYz6HXINwxzYzWKW4MbM/1h/mqZWAdgjYc4I/TDPPQFBOWzamnhQdEG1qn1RbwCWvPQESo663x6YS/T0mIPOL9A4TFcAXjUCo6JY5pj8LVR6ptpdCQJFkgH610rWU4+QMXycVCZGR65MtpQ4inQxf0eBaKmSUU97UB0xNY/QLsx0MjOEleDO54HLQwXHLONbJbVKOWbM5g26g33q8uWYYG1BuHiv4sZKauAbskUV+kGRsuUicqIAszQIONCrK+1w7PKbKXCkaxPWgoDWTiZ5wGYwzgx/0F3SwOOlRTUsWxpymZ3pqP+FeMRS5WLsXSP2BQw6Pk7+OIUj/jHo8xlrFisfuoNLXlJVvnATbZq9I+Qe+07+3BX6doUMlpz1qMofgEarOb6G7LzzpY7wvHv20H0ilbdKTKMBOHdTu4x87aenXhUzGENCUymqLMbg+n3pAD7YWHwQdcLSzG+UAnYlc899buesVUH2fqBDUJa7nUlZuXfCzRM0PMWL8i3t0c7XMxaMmYY9Gz/3n9cDYAn9T4JNQaHhRI1eql5XmKokfl6dZoVWVvQH4AxJL83yUxM3izvpN/i2NH6khD1NRWMWqpdcm+hyI0yQWj1z/MU2+fhO+DsqpE7g6oYuF+4L6iips65g2WrXSZZPY/0y3w2G+96qX5oWB0oba3pmzLC3IXbeMCaClU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(366004)(376002)(39850400004)(136003)(451199015)(4326008)(66556008)(66476007)(66946007)(8676002)(38100700002)(186003)(41300700001)(2616005)(2906002)(53546011)(6506007)(36756003)(8936002)(31696002)(26005)(86362001)(5660300002)(31686004)(6512007)(54906003)(6916009)(6486002)(316002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nmdpa3VBNDBwUDU4NjBZNE85TU5VRG5uT1JUSjdjTVZuWWdzeWc2MjJOemtI?=
 =?utf-8?B?MlRMNmlFMmFUdTBhY2t6d0w3R2k2TGIxM1dNVGI4NjBuRWVGZUs5MDN0dURZ?=
 =?utf-8?B?amcxSU82U2NoTEJhQlhjRnhlQXVHZVpyRTZINlZpT2hUUVNEZ1h1UnJzcWI2?=
 =?utf-8?B?T0RCczBtaXpJc2p0SDlxbXFnOC9qcG16TWtTVnlzYnpXN3Vmdkk0ZzkwV1lk?=
 =?utf-8?B?NDVPSkpMUWVtQXhVUFYwLzd0cm9PazVodmEzWjdXVENzY2s2c0hSeDRRZ0xF?=
 =?utf-8?B?RXVEY3BGWjQ3T29DYnJ1OEJ1NndJTGhmN3c0ek5xdGY2dDN1OUpvVFpLcU9s?=
 =?utf-8?B?TVU4dGk0aFlTSnBjSkdNRHFxN0QzZVJLZ0czZHR1ODBGWXdMYmtiNDRLWkQ0?=
 =?utf-8?B?T0Nhc2dwRHFMYjFab0VyNmRlYXIxU3E0RUxGNms5ZEFhNEttNVQyTGQzM1Q1?=
 =?utf-8?B?TE5JRjFtRCtOOVhBbDJOQzlnOC9IZ0pFYjNGc0Jhcm5kbFVPQnhVcWU3NE9x?=
 =?utf-8?B?b2xPdC9uS2VoSHh4U2pEb1M1NGl3VkdMa0pFd0VRTkloMGFHUDRsdzFxMVB3?=
 =?utf-8?B?bHBFN2ZvcEJuZlp2Vm8wazdCWDl0ZXpIM2VNcWpDelFYMWJEN1RGZXIwcUNM?=
 =?utf-8?B?NURvazVHRXB3Tm4xSkZsZUZZc1dncUNjL0YyUEhHZG5zUUEyT0tyWDA4WEs3?=
 =?utf-8?B?ZDR5eDMzU0Qrd0g2dkppOVk2eVk5aXJiWVBXbFRsMTZ2RFBrZmpjZS9Da2hN?=
 =?utf-8?B?Nkh1Y1A0TFBteGczV01ld05keldPKzVLbWM2UGFNcGZVNVBlbUtwRkRNTTlK?=
 =?utf-8?B?NTJ4QXJrNnZDRkVaY2hoVi95V1laQ2s0QnhMSFduSWFUT1hVZWNWazJ6eENB?=
 =?utf-8?B?YzFzbGlGQmFlam9sdml1TndVTWpEOEJZeGRYTk1GSnVRQ09JSGgxYVZJVDIw?=
 =?utf-8?B?SnVDeFBtcnBlR0F5TmVGcTdXTW1CSmJrdVc5d0M4MDV2M28zczliYkNrL1Ax?=
 =?utf-8?B?YUlUcmljVHR0WWtBb01meFd5SDJwQ2Eybk9VeDR3ZTU4Mjh6cWFoU1hGdnN2?=
 =?utf-8?B?czFudmlZT1ZXMkl0WWloNUY5cEc0MW9Pb0tNdEliSlRYWHlMTHJPTzFxSnZK?=
 =?utf-8?B?c0VKRE9manh4cEdOTVBUZlJkUDN2Z3dmQ3A0VkpwWFpMTXV2S2VheGtJbSt4?=
 =?utf-8?B?eStIMTdsSjBreVAvcjNOTVg4SmJrcmp6aDVJVkM1WFZ4M2trMkExMUtJclk1?=
 =?utf-8?B?QWgwYzQ4U2dWL0krQUVGbjdDM0Q0V1crcWhoZENyWWs4K0Evb0VOMG1WUEg0?=
 =?utf-8?B?VC85aHRIYUJhb2hzdkkxYlNQZmJORmZ1YWZIMEFBZUdjNGU1UE9YVTNTNlZL?=
 =?utf-8?B?WlZlTGFMQkJaU24wK1pmNlAyVXJtQzh6MDcyUUszWWdkSnRNWmVaOENrQkMv?=
 =?utf-8?B?YStsUGROeHROS01CTzlDWlFFaTl5VFpBbWdlVzZMdy90aDl3cnVuaHhBd2ZE?=
 =?utf-8?B?M2JUSE04YUU0Skl2YWQ2R2lzTDVDbllBU09IOEt0QUxsZ1RNVExyMmlGZmZm?=
 =?utf-8?B?RTRRN0YvUDJROFUvbkdSRndKR253RS81NUFNWFVOeExXUjd6L1ZZb1ovNjVC?=
 =?utf-8?B?QmR1R1prcXBhU05aQkEra21XcDB3bCs0RWsyWENwTDJxWTJ2U1FSZGlOaXdQ?=
 =?utf-8?B?S1Nub1FLYkRnU0xjM3B4Uk9tMkFHTExJUnR4MUMwMk1qdDFjRTFhRjkzMVc2?=
 =?utf-8?B?VjFNM0FpcWhHb0pGVEcyRmN0cEVtOTRJZHJMUHNxcGNGZ1NWa0Zoam1FVGlv?=
 =?utf-8?B?dzg2a3MwTjJGTWo3UmhUWncvdjhBeGVGUnNGMWpKbjdwY3pZN3hVWThWeHJv?=
 =?utf-8?B?MWNyL0g4Vzg3czUvOElQcmVDZzZrWTF2VGtZM2JkaVJRZU1rOXlJSE9ncDA5?=
 =?utf-8?B?VkhTbEJ6RGNTOE0xMmxFU2FraHkxUXl0VWIzN3VEQ0tiNFRLVkVzY0Vzd0xT?=
 =?utf-8?B?Qm96dkxUbW5TYlN1VDk2SXlyYjNBdGFlSmJwWVV1K2psVVZIb2NvMmxqUnJX?=
 =?utf-8?B?a04yUVkvbC9KTXM1RUlPNWZod0sxcjhTY2M4ZnArdmN4NFdxc05BRFFHQm55?=
 =?utf-8?Q?reYRRCk8dJABDxHfyOIGP5Jwf?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 780650c5-14a3-4c1e-e3b6-08daa5ea6371
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:25:33.6622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fHUnHSkVxhIYDqiWam10ldm49Kjs+LfTxtpAQF+gRXg97ykJ3pS6VPhR9UwA4E7IBYyt8Lb8cHeJ39nWC+btYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7312

On 03.10.2022 23:21, Andrew Cooper wrote:
> While working on another issue, I spotted this:
> 
> (XEN) ACPI: EINJ 6CB9D638, 0150 (r1 ORACLE     X7-2 41060300 INTL        1)
> (XEN) System RAM: 32429MB (33208204kB)
> (XEN) SRAT: Node 0 PXM 0 [0000000000000000, 000000007fffffff]
> (XEN) SRAT: Node 0 PXM 0 [0000000100000000, 000000047fffffff]
> (XEN) SRAT: Node 1 PXM 1 [0000000480000000, 000000087fffffff]
> (XEN) NUMA: Using 19 for the hash shift.
> (XEN) Your memory is not aligned you need to rebuild your hypervisor
> with a bigger NODEMAPSIZE shift=19
> (XEN) SRAT: No NUMA node hash function found. Contact maintainer
> (XEN) SRAT: SRAT not used.
> (XEN) No NUMA configuration found
> (XEN) Faking a node at 0000000000000000-0000000880000000
> (XEN) Domain heap initialised
> 
> on sabro0 in OSSTest on current staging.  I do not know if it's a recent
> regression or not.
> 
> The SRAT looks reasonable (in fact, far better than most I've seen). 
> Given no legitimate requirement for aligned memory that I'm aware of, I
> think Xen's behaviour here is buggy and wants resolving.

That's yet another off-by-1 afaics, which was not mattering until the
first off-by-1 was eliminated. I'll make a(nother) patch, but I first
want to figure out why I didn't see this issue myself (of whether I
merely overlooked it).

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:28:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:28:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415309.659849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeDd-0002HQ-Fi; Tue, 04 Oct 2022 09:28:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415309.659849; Tue, 04 Oct 2022 09:28:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeDd-0002HJ-CC; Tue, 04 Oct 2022 09:28:05 +0000
Received: by outflank-mailman (input) for mailman id 415309;
 Tue, 04 Oct 2022 09:28:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofeDb-0002HD-MW
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 09:28:03 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d64414d4-43c6-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 11:28:01 +0200 (CEST)
Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 05:27:57 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6795.namprd03.prod.outlook.com (2603:10b6:a03:40e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 09:27:55 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 09:27:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d64414d4-43c6-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664875681;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=rvB3iHjOVVN6VxzgLzO4tYMh9gN2XwbqdS5lXhIlMxQ=;
  b=YIDQqciFdG4imE9YdHQTzXnKhCCXu1XxClPj8jPGIg9fVSkJ0oEgDfNb
   Z8KG5y289x0bFIbYc43aVrr/su3SoDYskMILM4TjGvNM4Scfkex7qPq47
   iWg/64+15CCdPJW2bxL0yGw3lvZIJXxNakJrpwssKiCYRukmHh/qY+M3z
   A=;
X-IronPort-RemoteIP: 104.47.55.174
X-IronPort-MID: 81937031
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ALnCJFa9orFjFQnDtDnxqDrVtTnXEuO9mBUUsX?=
 =?us-ascii?q?f3CRtIx9vdXhiku+b6FwMMm01cbdD4nL4WkTyrq7CIW0Lia/gCEpxFf6gdzj?=
 =?us-ascii?q?OyjA48YN1ttKIZdiutTTevj5JCBkghgV2aCNbdIgO0glQHaKmmcqCaJuxeMy?=
 =?us-ascii?q?GvwrgP7KjQnWG3t7bMytgbFGiEu1Vn3Tmww9NrOrYw9pYXchlFBrDJ3wCsXi?=
 =?us-ascii?q?JyObUcMnYHllmda/o3uZe7pYF/tSQRqY2078NBETISUXA8z2Cq9exV+BmAo3?=
 =?us-ascii?q?eG4ffIb21oOxTka+S0y+Y0sSCQ1qEHjNKTwS2PtwTD1gKcyFWo4gpUOX3JbG?=
 =?us-ascii?q?ytwCTt8/a6ududX/Z56lC4XgmNsaUKtYLBHylvCLDW5WAU0Y1InbIjRB3A0r?=
 =?us-ascii?q?QQBH2QTeJ5e9amLBFr6Ekwe73IJsWYEHGhAJaB5rg3c9RfsP7oDxIUXEcSYL?=
 =?us-ascii?q?5rabC6ZduYrIKrRs0Iou949Ur5FD1ZCZJ65q8/mYRTdHC2wkk1FeSfz6NfXK?=
 =?us-ascii?q?lo+JilULNvYi4p6EyWhU6BaQYpEscXjZwEDIDpXjP84+6dNilUZba9wFs/vg?=
 =?us-ascii?q?/BIKLh1jIBkBWxMIKveSaPmWpPqGTjDN266B9/wLmaCeeQt2EqG0rlkQW65+?=
 =?us-ascii?q?hrPEUQeMxvmtATNNQVlmhvQSsL0YBE3rTQBIBd9HEGuVF0Tn399KL2xlczUE?=
 =?us-ascii?q?AY7qs7ZDZx6e2VJnrDOQjD7AeCqc7b/9pM9KLnGx7+7xzbotC8tA96tPs1Ux?=
 =?us-ascii?q?WmkqFuWeHw3QUOR7zwnwmDI6Xgrg0xmVEq019e5AKNZBzWlz60Q0Zy2HLl2a?=
 =?us-ascii?q?gvWYGTqh6Sx+xCk9Di7rYITXyLbTzK5QW2Yj09KD9+wCp0l94R/x8wMK/gQ7?=
 =?us-ascii?q?xfCZAreR5/pusu2ca340s3oz+7NVz6oLFKB+PgemeiFLhWlJfCFZyjSvMhTu?=
 =?us-ascii?q?K8IqhdzDrWjB9JjdFmEiDAkoj3EBy0XujN/sa3bVSrRVL+yEBK1fCK3WpD4e?=
 =?us-ascii?q?YGtxwL8Uy8h03IUQs18meenqnW09qdYcl0aE58pweAocDDClo9r06KfL/4VY?=
 =?us-ascii?q?LsG2ZWu4RQ59IBj3yTZ8jYM5NhEWcd8U0UZlDiNnVUVwCO+DjFUSoxnLnl79?=
 =?us-ascii?q?51tHkcsUj2jeag1uE7bXqAXy/cAXFvsniRTNL8a7E55RR02EP/DhpZE2l8hu?=
 =?us-ascii?q?uGpZxoQGYHch1UWb/uNNM7W7TEoysg1jdS6PBmcFES084twAO947SAplENz6?=
 =?us-ascii?q?RKkiPKo5OCnBflQ2KR2NX4WAldZbUuXupbeIxlegBb+167x5kuvcIP5QRp6e?=
 =?us-ascii?q?hH46BlMjq7P1noFvTP8PrhHOWTxQgC5QfuzM2tovwB0no0b/boUdVFyfcSQ/?=
 =?us-ascii?q?rYbMoE8qawR8niflGO71SNLP5KNuShDAsAmp8J3CbngcdkYSoRd4h0APPSJk?=
 =?us-ascii?q?XL5ArTN4Hkv8szHXnxlzlXoOKxJNnLhfiuMMBrwQKu9jTSXUFWRbbIQiR6Yo?=
 =?us-ascii?q?E5Giaw3s5APy5tJY60SjxKDM8Yt64LhBng+V1sEDm5Ko9uU7UM/+YSlt0vb8?=
 =?us-ascii?q?Jb0VrUvZw5lt3C7roRiURionYy4l9V06FbZSOFmHoCSjC07gclG1gPYz+LUe?=
 =?us-ascii?q?fN570m3JXbHej3ghGvKJsU7l4yrPAhGRLSaJvVFMA+B8S4tE5yr/nsRnCztI?=
 =?us-ascii?q?yG6ADI6m4OAfrhNaHDtNQ/NAz4A4f8sqII2IPG47J7+3A0GFoflo+9SkLXFM?=
 =?us-ascii?q?Y0ZJdp+SnCIyc/wyr+e54+rPAhHAObik9PnCMr/oBsztH9pfpqdhswGIrjBa?=
 =?us-ascii?q?0zCyyyQwQNgALvhaYKi2TAtH2DwL+07X8T+xDo4rUrSmta2eDntz4vlu1gzh?=
 =?us-ascii?q?SWUhY5jlwKiQ9u6vVDeQlU+t79ANjgsiooFrBJ6IkrOvhSgNzqlyuRJ/7hcK?=
 =?us-ascii?q?sfxfwJldLwhEFyh6/6y9sieu7j9KHLgiV300HPLrz48d+dlCm2pBGoiEHmS1?=
 =?us-ascii?q?ebH4pRdP4z0SlggSZ+uNYFaaTkpM7mbUDHAOmE/ExnmlEeACGRjgOx9DunAE?=
 =?us-ascii?q?8OD5/FhgGWn9+Zpaole4vQSMUJkZ9seuSDNDLzJG0MGL4uA79ZI0HzCFbGLk?=
 =?us-ascii?q?Wl5S0UbeIYTFBvM4Ol3Xhrs3ANrqywank58esSSAosGm3px/cQkyAeBGgzCT?=
 =?us-ascii?q?iIj8MMCM0xv3ez8rCewXZ9b8OajXvysr0SEpveykRqJy88cUo2mSObXXwt1A?=
 =?us-ascii?q?VFgirGOnOpLTZqK9yVSxtuMwvh/fhXsDqzf6M69+C6q96AkcM2TQCdSgfr5p?=
 =?us-ascii?q?NflEbSf9gGkoSV3rLKPhBAsQF/86AlqjIMWsHUaeCFAAexYeG+rqABCLyAyJ?=
 =?us-ascii?q?ZnlDG2+2Auq7bdbF9Wv/f0l5InuQvsdeRSaehLvzTnI/8UeP4Ldh0VttKw62?=
 =?us-ascii?q?+Q=3D?=
X-IronPort-AV: E=Sophos;i="5.93,367,1654574400"; 
   d="scan'208";a="81937031"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vc+Gfv3tTnnWWyXuhnH9MCtWZ4J7GA/brrkA6lMLxpqV469rJUQ6DvZg12cqIIIVpbTOCl49l8/gM+e91r/rPMQaGFXp7sGxv6mqY5SaF1CScbhy2agTxPxNfLwKR/LfKFsx9P+7sxZq5omh4BgEaOYEl/619IYWKRKzDGMUUa1Y5k/byNIlemcEJmwi88aQczPMuOzCRTW5cPXUsy7i0tTJfn3bI+yCIj7F2FQmjxlp728Xt6Qr2BxT3LyH+uOa7lcgwUP2Bc+53/67cjbeHwodzX/huonUHwzCd4sVIo8T2VmP1d+JGPo4uHaZmZyRLI9EZEFGVeHNea834ASFig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n3uBSVoH60hyNSYLt3+BFe7B7dZcfaz0za/QaNp2PLA=;
 b=ASxLIHVANZ8Hj3uVLzjnQjIls8Nh5LgBfOZy1mHmoxCfVth1fRBT7VGpi7TJTLqw/+4Tlw6BsEkCVtl4EXpMffDlAGrXsBj7TGgx3f2igGtdzVGOj9Xgfd8wR5fSQpwZ1tOxOtY4pQAMc2/AavWiV+QxtJhsFG17WaJCpnYhTYY/GIJmcxmL4dF2D78e9D+tEH5MgkgDplP2E3pajga+Yo9O2gicCjY5HVPPq529mE/41g1q3+Pb2DtBjU3JZM0Yz6ILYCT7dEW983twvJChVMeQLDc4vT1+o1csYbUqZeXqMKs4qHmScdeymjT4Cq0S25kED6dPrjYBknsbWuxNEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n3uBSVoH60hyNSYLt3+BFe7B7dZcfaz0za/QaNp2PLA=;
 b=lem++7rWAPj/F0nw1M6DH+W2WrkWdayhWeA8PdEa0rFV8a2DwtXIN4i7bWxTA3iLF53FTPY9wdz1F7xEeIZSu2hkRVMZCyKwh04M3LHf5dNtP/zBZLK4bMmBFwbJ5W8XDQVnTLfEif/+P15ScSkpSk2cigU58uC0KwuEFN2Mr6g=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 11:27:50 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Message-ID: <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
X-ClientProxiedBy: LO4P123CA0190.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::15) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6795:EE_
X-MS-Office365-Filtering-Correlation-Id: b1fef4cc-d5bf-4308-4a34-08daa5eab801
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3/gxxdjE/9SJyngZw5/rGaaLx2FFcVgmbCOnGimeeuD+VzwHAivLq1mStiu/DAcByvy2zcE7rwNy++3UqDERWKHuIHKtqsQjOWlmk8q8mxBDtq0+2oJWyRMgLqyrFwK3n2PiFeUTbZJoSqT4O0S/AjTnXfLvo23ixypFVOvbuv+ZHTpffPkg0H0f//v4gJfivu7HNpyrrZnvSC22ZiJ6XUpnOVhqWlzqkL0LsKNXSmndREl+XQQ4mCBATJB70SDVQ+WM+pgoqPTnov9BwsKGY53mW8+eGa84ggX88J5CDvE1+FoKI1BQVwSR2uV/9YJ9KgldOACFj775mfOHCdqCpW2pRdeD5PztvchTbmbpBKU2TQol9WSGU27ZosuKjAbuXqqOi4ku0Z4AgmXyVE7tireT9mpZuo7IMBoxNnIPjCT7npTtvCLBcwMAVNYnDy2eNuzTSWTujpQ3IQZQfmcpWJc+1aObjncQ4RiO+V/8xz510HDfPA+zoPWfLG0iSX5+Src3nESZa0/rgPxfAokq22UFdaqFHMHURjAsKBtuGO70vefXmAlJBhsolcIY3spOzfJCKiwWwLe5jBwYk8kXegsUvGIFux8svjOhkcctRl+rwFo6Uy0YZjb7+X5JIUECJeLSIq1ZGOLjiTgil37yriM50i8xx38DUcZAlsEWMFliEGx8eWYkoyR4b3i8svRIfiIOOxyh2Mco6aljmFhXNQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199015)(478600001)(6486002)(83380400001)(82960400001)(38100700002)(6512007)(26005)(85182001)(8936002)(2906002)(6666004)(66476007)(5660300002)(186003)(316002)(4326008)(8676002)(53546011)(66946007)(9686003)(41300700001)(86362001)(6506007)(6916009)(54906003)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dk5hQUVtdEdqdzFXR3VacjVtK0Q4bFNGaVlaZFFwcXBUTU9XVXVhUnhuVVdL?=
 =?utf-8?B?RG12dVE4OWZyVmladUpHVklpU2NXWDljblpPRlNacDFXMDJLS29KQm02TmlE?=
 =?utf-8?B?MTBFVUl4ZkxZYzJ3eWpHV3hCcHdIeE1Jb0dYazZsd3dyVWRXYkhxZnRDSUtp?=
 =?utf-8?B?TFBuZis3WmZ4QzRjTjNWR1MwdW1LMVdSOXFWMWc4a1l0VUFHNkw4dlBZdWpU?=
 =?utf-8?B?MFI3Q0VjVzZId2VoWi9hRmJoaFRZWDVaeDYxVm1vSmxoa1VRNEMwWFFlVVJV?=
 =?utf-8?B?WnU5YlpsN2JGRXE5YW53eStyUFZhd25CMFB6UmtmOVJRN2hCa3lucVdsbDFT?=
 =?utf-8?B?MWpyV0NCK1NaOWVZcVZhNjB1RHZUS0FjZThYYVM1ZVc3dTFIWFBqVzQwT25L?=
 =?utf-8?B?cEJYTGNMcUtKcmlsMUJyYmhHT3BaK3lLNVppdDJrRHZtU3dYRnpxUEVvVi8y?=
 =?utf-8?B?SUIwa1J2dHJMaEZkenZzSC9rR3dYUzFoV1JCbDY5aU8yTDFzc2twV0t5SzRp?=
 =?utf-8?B?eGdWVHI2VytkdWpJa0ZFNFZyTXh2M2huQTZVN0xYVVhDRFhPd2s3eXlkczk0?=
 =?utf-8?B?cnZHRitYTGtZQnVFQjRCL0NYUXVhUmVrTGl5aE93WHZuMkIzb3c1QjErUTNq?=
 =?utf-8?B?ZkU4OGpFN1MxTkI5bE52RnoxY2ZycEtyWDQvQXNueWtnVWtRQ2tDM2dFTnRJ?=
 =?utf-8?B?MVZNbHdldXh4V2VubmpNSG84YWhTWDlNTVlpcUhUVENsQ3NUTkxNcGVHVGh1?=
 =?utf-8?B?Si8wY3d3R3NQSmlOVmdSWjJJN0JtQjhUcWlCTE9xQjlQenplQmtFaDJwMGtn?=
 =?utf-8?B?MXlreEh4OXVFaDNaR1dQOWx0VjBFWkRyejdlek1KVVUvTk1kUTJIK3MycUFN?=
 =?utf-8?B?a2VBYU5MQ0RVODBtSGtpcmVhKzR1aTZhN2ZWODgyd1h2ZDFzOEpJb2drekp2?=
 =?utf-8?B?ekkzRXVZdWpDUjdZUWhwOFB4OXdJTXp4NnVNZXV1c25hNjRORk04YXhnK2xV?=
 =?utf-8?B?V1NNeERwUDB3YlhDVzVxMUppOHdLczdBZ1VBaFNwdHNKMWljMElJU200Y0hx?=
 =?utf-8?B?VGlvM01pbGVNUG0zKy9POUhEaVFQOGNGYk9ydmtTOS9XQkRKdHFoYnROSy9G?=
 =?utf-8?B?cytyeHFNTnZPNTRneDFubUFGM2JzTnFzZkVwZ2RXbzlxTTFBTjE5ODVFWXhw?=
 =?utf-8?B?YWtEZEJzVEowTGRqVWh3cHIvZk11bHpPaWo5VzBqMVpueVlRVE1nZUY4dnRD?=
 =?utf-8?B?UVlvNFJOVmkwRldoa3pobkIwMlRJeGd0WXRNRG9wS1dhbHhiL2JlUjQrTEhy?=
 =?utf-8?B?T0k1bXlsdUlnNm45emEyOGh2VDFjVEpLWXZqY1BUVzdZWHhldGgrc2hBTmJq?=
 =?utf-8?B?ZlFpOXkrWmpQRU1OTUVhZEdMSXVJaXQ1WEY4VUhtVVI0dW5PNnpkaVMrZ1Fy?=
 =?utf-8?B?dUVJeE1RZTVMc1hkcjBwbHovUHAwV1hyN0VhRXVHeVZ5WDlhSER4OTc5czhM?=
 =?utf-8?B?VW11M2ZVYTJ1ZnpjNG1HSGZuaWlEcE1TUmkvTHVYRzVQTFlNWSt4aGZ1QlJL?=
 =?utf-8?B?QW1uczlGSkpVT05Zc3BYcnZOeTUzSkxJT09UVmxzdHp2ZElQLyt6amo3Tzdr?=
 =?utf-8?B?SFFRVko5T25YdXlqQnJaT2RtVDZaWDliem44QXVhZDNPU3ZmTzVEekxmTWtF?=
 =?utf-8?B?ZkJXRitCZHJSMUs5dEtYMW9kR1k5UGRtamZQbHYvWmw5aTJRM3NWQytOZU1I?=
 =?utf-8?B?ellyNjhIdzJ3WDlFUysxeWpFTERqNlB5eUVtUUVlNXNreGdTN0JrbVFPeDdm?=
 =?utf-8?B?SHJDblFqTG5BWjNva0tUcWF2emQ3VGxYNWYzZ2hwL3NUaXVxOEVBOWpJYnhY?=
 =?utf-8?B?ajd4WUNzOER1d25NZnl2UTBXWGtDTFpMTmVUanZYYnVpUFFHWjFKR0pLakZK?=
 =?utf-8?B?R1ZGa1paWWl3NWI3VTh5KzdGb1BwUTZwM29NR284dE1YMmw0Lzl4eWdxbkh3?=
 =?utf-8?B?S1B4cXhibjd6OGhVZkNERVQ0SFQrWlY4KzJSb1BoNjl2YTJGU3dualFmT0NF?=
 =?utf-8?B?WkNkWmV0akc1SUhZQWJVUEtyalpKcGc0Q1dtR1g5SWo1R1NxMFovU2F3ZTJ3?=
 =?utf-8?B?TFhGS0oxLytWVThaZVZjOUJYYjlCaStTbUVWWG1NbUtYaDhIQko4SnJYQ0Z4?=
 =?utf-8?B?WUE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1fef4cc-d5bf-4308-4a34-08daa5eab801
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:27:55.5774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zq6M/y+A3x82rrvlPzwFiG58VFYoQVo66wu8tOYVil9B8oGVXF2fgBqJkRbSPPlcQDH/o5E39wXLpBdq2xZXHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6795

On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
> On 30.09.2022 16:17, Roger Pau Monne wrote:
> > The EFI memory map contains two memory types (EfiMemoryMappedIO and
> > EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
> > devices used by EFI.
> > 
> > The current parsing of the EFI memory map was translating
> > EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
> > x86.  This is an issue because device MMIO regions (BARs) should not
> > be positioned on reserved regions.  Any BARs positioned on non-hole
> > areas of the memory map will cause is_memory_hole() to return false,
> > which would then cause memory decoding to be disabled for such device.
> > This leads to EFI firmware malfunctions when using runtime services.
> > 
> > The system under which this was observed has:
> > 
> > EFI memory map:
> > [...]
> >  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> > [...]
> > 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> > 
> > The device behind this BAR is:
> > 
> > 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> > 	Subsystem: Super Micro Computer Inc Device 091c
> > 	Flags: fast devsel
> > 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> > 
> > For the record, the symptom observed in that machine was a hard freeze
> > when attempting to set an EFI variable (XEN_EFI_set_variable).
> > 
> > Fix by not adding regions with type EfiMemoryMappedIO or
> > EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
> > be positioned there.
> > 
> > Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> In the best case this is moving us from one way of being wrong to another:
> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
> legitimately covered by a EfiMemoryMappedIO region in the first place,
> which I'm not sure is actually permitted - iirc just like E820_RESERVED
> may not be used for BARs, this memory type also may not be), whereas with
> your change we would no longer report non-BAR MMIO space (chipset specific
> ranges for example) as reserved. In fact I think the example you provide
> is at least partly due to bogus firmware behavior: The BAR is put in space
> normally used for firmware specific memory (MMIO) ranges. I think firmware
> should either assign the BAR differently or exclude the range from the
> memory map.

Hm, I'm not sure the example is bogus, how would firmware request a BAR
to be mapped for run time services to access it otherwise if it's not
using EfiMemoryMappedIO?

Not adding the BAR to the memory map in any way would mean the OS is
free to not map it for runtime services to access.

> I guess instead we want to handle the example you give by a firmware quirk
> workaround.

I'm unconvinced we need a quirk for this. AFAICT such usage of
EfiMemoryMappedIO doesn't go against the UEFI spec, and hence we need
to handle it without requiring specific firmware quirks.

> > ---
> > I don't understand the definition of EfiMemoryMappedIOPortSpace:
> > 
> > "System memory-mapped IO region that is used to translate memory
> > cycles to IO cycles by the processor."
> 
> That's something (only?) IA-64 used, where kind of as a "replacement" for
> x86 I/O port accesses equivalents thereof were provided (iirc 4 ports
> per page) via MMIO accesses. It is this compatibility MMIO space which is
> marked this way. Such ranges should never be seen on (current) x86.

I've heard the Arm guys speak about something similar.

There's a clarification note in newer versions of the UEFI spec:

"Note: There is only one region of type EfiMemoryMappedIoPortSpace
defined in the architecture for Itanium-based platforms. As a result,
there should be one and only one region of type
EfiMemoryMappedIoPortSpace in the EFI memory map of an Itanium-based
platform."

> > But given its name I would assume it's also likely used to mark ranges
> > in use by PCI device BARs.
> > 
> > It would also be interesting to forward this information to dom0, so
> > it doesn't attempt to move the BARs of this device(s) around, or else
> > issues will arise.
> 
> None of this is device specific. There's simply (typically) one MMIO
> range covering the entire 64k or I/O port space.

So this translation region won't be in a BAR of a host bridge for
example?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:33:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:33:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415318.659860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeIw-0003hr-2m; Tue, 04 Oct 2022 09:33:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415318.659860; Tue, 04 Oct 2022 09:33:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeIv-0003hk-WF; Tue, 04 Oct 2022 09:33:34 +0000
Received: by outflank-mailman (input) for mailman id 415318;
 Tue, 04 Oct 2022 09:33:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofeIu-0003he-H7
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 09:33:32 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9acfa221-43c7-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 11:33:30 +0200 (CEST)
Received: from mail-bn8nam04lp2043.outbound.protection.outlook.com (HELO
 NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.43])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 05:33:23 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM4PR03MB5997.namprd03.prod.outlook.com (2603:10b6:5:388::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 09:33:20 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 09:33:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9acfa221-43c7-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664876010;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=uXxAR4d5RGgsAetfaqQl8UkyuYpSZkSffydkuv8LCvY=;
  b=aHvbi8KlHHsAzpIcHr3tJk90ZP//IHXApDZUYDGtLUTLZoaFEA2Y4khW
   QnIvUlZgHFBEo0N1sD3WYxOPtjFpShaqWcCavTQH4OKG1QEnfp2cXEQkW
   4GaFje1/sv07HLXloMluCVQztHgNSxR91cULMR+Ce//yJIG2yRKR4eOt+
   Q=;
X-IronPort-RemoteIP: 104.47.74.43
X-IronPort-MID: 84441364
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:K8eQR6zJe5kubkMXy3F6t+e9xyrEfRIJ4+MujC+fZmUNrF6WrkVVz
 TdLDz2AOPaCa2CnfIgladi+/U9TuZHTmtM2T1ZuryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFsMpvlDs15K6o4WtA4gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwp91oLkwQ5
 6UicRNKQR6np8Htn63mRbw57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exruAA/zyQouFTpGMDSddGQA91cg26Tp
 37c/nS/CRYfXDCa4WrZri713bGT9c/9cKsrLPqf1O9OuX209GdNDjs6TEa9ptDs3yZSXPoac
 ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 TehgNfBFTFp9rqPRhq19KqQrD60ETgYKykFfyBsZRAe/9DprYU3jxTOZtVuCqi4ipvyAz6Y6
 y6NqC8ylrACl/kB3q+w/U3Eqz+0r52PRQkwji3dU3i59Ap/aMigbpax9FnAxf9aKcCSSVzpl
 FgJndKPqt8HC56lnTaIBu4KGdmUC+2tNTTdhRtlGckn/jH1p3q7J9gMu3d5OVtjNdsCdXnxe
 kjPtAhN5ZhVeny3catwZIH3AMMvpUT9KenYujnvRoImSvBMmMWvpkmCuWb4M7jRrXUR
IronPort-HdrOrdr: A9a23:W3mhjq6GHDfDA7eAyQPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN
 MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9
 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.93,367,1654574400"; 
   d="scan'208";a="84441364"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gs2yAQaJP4lS4eNGaOLYxaCXEkOo0TaYExwSLFEWFoYbbXnakppwgn9RdMigIsZ4bD+WAw1J0raYxCaYnRz1AyxJlZ5yf1u+/3f2g9uIFpwIoV5fWifKA7eMpNPaYpYIKrYt+WVYSXugi9rLNMxIq5d+/qvORQNLCTmokL/CCQRF/M6aCTdbO7RfV1/PXWb8/M5Y2533gH+lqIrZq29kOJd9I95t+6e/0GY6CSya3Y7NBHaX6NPb+4JQXQBvW6z/7jDue7uzwQadqqZ/jLGuSfd6QvrHk8htj+8wLkd32kLMLKUUuDDhyKIJaztfZzn7PhGgfc7sU+koUmI2quzA0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZPMVPlzMhqoLpJn5DKgly0KDoFNYA1yWPczeSKxEU8w=;
 b=IfEw+ztksjumj30O5HUCNJWgECxvnKtHCs2sHcdLmt7tgzgx1BriZ1TFo/SySyAqfGOgO2TZdWzDZQJE9NV+HOVhKujWDQ/LPF0EpcWb67f4LX8m4QbalMAgjWBMdhCAKuLX9eG09mWsu7E/P5I8rWxIQR8iHuBSJqIzCIj9jgrLsu8o1Ke1wsgjfEnYy/+idOgh4X/0QF9vOMk7VufOabaa27DOdNHfCsABQiPcoqLjlo2B59/jSy4+edsRdHlgIPOLF5Bg91BOrWnZt0JhgxAsTssuhHHqjALqyFmGA3eopYrnU9tpO5+nml9vGorRc7c93LYeveehQgc837OuFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZPMVPlzMhqoLpJn5DKgly0KDoFNYA1yWPczeSKxEU8w=;
 b=Pw5FqpDpU9jt5qDUpvJZsyS5mC4aKST3mzm77Fw/i4/bU3IkAhI+p9hC6JqzigSP18ZfBDWKqhi/tLtvoo9fvlkIRQBgEeGp+Gg3GGMIQJXw4871PgFc7mE7v8Xj/v5OmnPm1Yewtq10Kt3oVbZgWx6xHyu/qWeQqxJLwashQVA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 11:33:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Message-ID: <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
X-ClientProxiedBy: LNXP265CA0044.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5c::32) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB5997:EE_
X-MS-Office365-Filtering-Correlation-Id: 4c2f625a-daf9-464a-1476-08daa5eb79a9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TORiEpmgYK6iekZaJXeugr8SGhLRIJUPYuqGS1ey5GwZEdN7kN3tKTfbentiL/GoyLMp/XtrwmkUlgCXU7ffYt5dHRKoZar1m4hkELoF1rdFCS3Zb/0lKh18E1Lv2KTpuEaBkRXRnIOB+hBhqzrunhcWdtlUHbMSVitrPfUnysWKzVCHu3ECqonrUEOyg2/dZVLFz1wh3yofa8T4rmBGpvWTPd6pjHY9sisbSaUB9WMDHhGv0DXoxuKoWR3i3h65UO/e+fAAnq55fgBJHuxHvX7PI62z0ocUAYMw5fppAItvJq4xccB1+QjK+DwwPJEVXR3v6Rm+6mov6jAuOYr2LX9gL/ucknOr69cR1V6RKRqvWe+z7wZargREUNV+dJMg5MDd4ft406V7u69lR9iYUnGI6D6lA15DY8lhAB5CYRbNlFu2OtkryyKw9Jpa9TOUOaOb3Ud8Ao8lXSbCwLpqVrq7XnUNP2zvjuenoL+ecwukcWokZ9skB4EM/dO/gcK0Cg7nRuyWwZQShWAlB5UzJBskGiXtISK7x26ow1pMJbcVyJfvIX8nQMgJvXPftVTqnLgSLoe0pkfSsMPZ3XrTFFEUj6oCms0lN9sEB/yVaqyvDzJMAms9p8NyUrupWZe01vTlK6+6sLfY1e/IjeZ9vH2sOje10uNRHkyaHymOZ5VhornTLTEFxd4ATz/fw3slHedwERCV3MXTL+/C+EhjYQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(186003)(2906002)(85182001)(316002)(6666004)(6916009)(54906003)(6486002)(478600001)(66946007)(41300700001)(8676002)(66556008)(66476007)(4326008)(53546011)(6512007)(9686003)(86362001)(6506007)(8936002)(26005)(5660300002)(82960400001)(38100700002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGlxSHZXbEZFazdmcUlybVcyYXlWbSt0VHpLenUrNjdNUEZJdlNMMFdmZDd4?=
 =?utf-8?B?M1I3VDk0emJEai9zLzZqUHhrN0MxWW9ac0djbndicFpETFBUeXhMbnAyNXN3?=
 =?utf-8?B?bHJTOXEyUnZoTWlDRFNKc3lpUS81RmRsNEJZVWRmSlNod1NrZlVGL240enM5?=
 =?utf-8?B?RHE4YU9qT0txNGhEckdyMzZXZ0xDcXpOOHNPVWtKRDZ1cWJoWm1yRml3Qjcw?=
 =?utf-8?B?T0JnNkxCM1BnelNGd1RaQ1N3ZFJIZDY5SUd2KzZXaVA3YmpQc2puT0dhUGky?=
 =?utf-8?B?bVhsOWpPcmhRWGFxaUR6KzJua1Bqd243VEhOMEQ4L3duNlZ0dUNnSmZreWls?=
 =?utf-8?B?Wm94QzRWZE81ajkzNFFYTEtGaFRsWTdGeG5TSWRzc0Qra0FRWnZUM0hPckt4?=
 =?utf-8?B?aElsamsxWnduZjBGTjZweFA2MXFjM1lmdXVtOENpQlNCZlY4cVN0Q1Axa0Fo?=
 =?utf-8?B?aUphZW55aHJQR1kvbERZRDB1bG12YnBlNHpuU1dTME9ySGFqSTllZmhSdkYw?=
 =?utf-8?B?N1VMQXZrZENRRE11MTV0TmZtMFlCUys2ZWQ2dHhzVDFVUWxzbTR0cHZxeVJK?=
 =?utf-8?B?YnlSb1paSlFseXp5eHBJOHkzZUltQzNuaURDdjVSTFl1RjBURGRjbEpack9v?=
 =?utf-8?B?cmFPQ0sydm1vR1FEU2ZLUXRwMmFXNmZDOTI4NVhzQXpJWG9KRmJEa2YzQTc0?=
 =?utf-8?B?MDVldlMraDJQSSttb04xYkppcWYyQzdpNk5XOU5WU2htbFRyNUhKUHRTbzRw?=
 =?utf-8?B?d1BkbFlkUGUyVWNmbGNGNmFYM3F2NlVyVTJsZEdleEMvS0o0UVVneGM2Vy9O?=
 =?utf-8?B?YWROQWlCd2N3Q1oyRkJBN1dRa3JVbktmR3NmdzJKWUc4T1h3N1pVZkJUVzhH?=
 =?utf-8?B?UmpMSTRNeUhMdjVDR3BSSEh3ZElRVjFIY3hIOVpySW9tOExsTjJmSFdCOXQv?=
 =?utf-8?B?b1dBTU40MGxyNnREM2YvdDEzeUdkVGlRVG9henV2cHZVaEpMRmI2UG5uRDUw?=
 =?utf-8?B?S3ltRGorbVpnVWMxSUJCaXArTFkrT1poVU1DL2I1NWt1VVlCOUsxRy9pUFJL?=
 =?utf-8?B?SENZRXVOQm1jeUpzV3BBYnI0ZFdCZWJLZXlHSTZWZkJ5ZzBnQWZWdTAxRWgz?=
 =?utf-8?B?aWcvd1lsSWgzblpLTkF1R0ZaKzl0R2Fqb0pvc3hsTEsrdWtGTDV6dnlBT0JO?=
 =?utf-8?B?T2pMMzVteWlCNXJabHY5UU5uRGpEejl1YU9mUUVBR0hzV01LaDRrU3hmZVVl?=
 =?utf-8?B?ajdXTFdrS1hOQVZNdlV2dkhXTzJPZFlZQ2F4TTBVOXJFbGpsMG8xWlFQUjdB?=
 =?utf-8?B?QVBibHpGTmZEUGdVNlIzTlRyckJtZHp3VGFDQU5rUjRib1hGOEkyOVFFcW5x?=
 =?utf-8?B?U2xYUWNwTE9Gdjd1TW8wL09yVEUwRk1NWjJ4L05na244Yk5mM1JyMTBOcWJl?=
 =?utf-8?B?bmNCVnFGRnN6cXNIV0xoYzhCUVpZVjVOSHFCMGFtK011MWtZN0JzVm1QY1FL?=
 =?utf-8?B?Qk1wY09MbEZ3Tjk3S2FZQTJkRWQ5WGVoMDlobnh6SzJBZ0g1U1ZhZk9PRjVw?=
 =?utf-8?B?KzREOThIbTdNZEZDbXRoNWc5WFpJQUNTTitIVEtOYU1xZ3ZBY1MrVlR4UXRU?=
 =?utf-8?B?TUdrOGxMOHBGN1BOTHRKdTNucUVzcitPMEpWQnVwS0NDekpjSzBIcGp2cWhT?=
 =?utf-8?B?b29oQVNqZjhFcklFODlPUWxzTmZiZm9TU3hoR295VC8xWlNvUTVkN2poZG1H?=
 =?utf-8?B?KzZwaDNiTUdpekovbis5V3ovSkdTdHlGOS9VWlJUeVdiZDlMV1c3OUtCUGF4?=
 =?utf-8?B?NDlLS2wwcUZYTzVqdUtsT2pCWHNwc01NYXpFamVKTTVWdWRaSWEyUis0K0hZ?=
 =?utf-8?B?K0lSUU1DVkV5RHNVaFppcmE3S0F5amNoUnhkU29uYWFnMFhLL0ZJc2ZUTHFR?=
 =?utf-8?B?aVlQRmV1MnViQ201Qmk4SjlBRkZmTjByR3BTREdqd1lFRGQ2VktRcUp4SUty?=
 =?utf-8?B?d1E4N3ZiY3piRlVSa0pRZktuRWJjb0IxTXZtaFlHZ1cyTEdlR1dGVlpmZmJi?=
 =?utf-8?B?VjFUTFJWaHBQNDcxOVk2OFlQaVRMZlVBNHlFck9DeW53aTNMOExQZnQvOGdX?=
 =?utf-8?B?UUZWajFxSmo0Uk1jeFM2YVZ5MWR2WnBHZTBaVkNGMExGMWtra1hJL3lGd1l3?=
 =?utf-8?B?VFE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c2f625a-daf9-464a-1476-08daa5eb79a9
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:33:20.6180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oVv7bHnylQDOJNGvgthHLAkaWjJHgNIY68UHrmKzZ6EfMC7gRv6h85WT77NZ+C4sLeRX4OcqFXeRlrm/6QobQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5997

On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
> On 30.09.2022 16:28, Roger Pau Monné wrote:
> > On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
> >> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >> higher priority than the type of the range. To avoid accessing memory at
> >> runtime which was re-used for other purposes, make
> >> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >> E820_ACPI memory there and hence that type's handling can be left alone.
> > 
> > What about dom0?  Should it be translated to E820_RESERVED so that
> > dom0 doesn't try to use it either?
> 
> I'm afraid I don't understand the questions. Not the least because I
> think "it" can't really mean "dom0" from the earlier sentence.

Sorry, let me try again:

The memory map provided to dom0 will contain E820_ACPI entries for
memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
overwriting the data needed for runtime services?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:39:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:39:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415329.659871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeO9-0004Pg-Q7; Tue, 04 Oct 2022 09:38:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415329.659871; Tue, 04 Oct 2022 09:38:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeO9-0004PZ-N8; Tue, 04 Oct 2022 09:38:57 +0000
Received: by outflank-mailman (input) for mailman id 415329;
 Tue, 04 Oct 2022 09:38:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ofeO8-0004PT-Iu
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 09:38:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ofeO8-0007Fz-EW; Tue, 04 Oct 2022 09:38:56 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225]
 helo=[10.95.104.225]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ofeO8-0004fP-8O; Tue, 04 Oct 2022 09:38:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=JyHkCzSF9dxv6ZDNJB6qZmBM9mc+7MOjYLzlBYcG7Uw=; b=csQJkCK3zN4nfrUSnkIucT+f2x
	XBM1iH77aNXE2MukTHSahG0/M46dR7WVw+Heo4wIWtqcJQo8WHY0SaTLOUG3tj/uAk6uhSngAy6J+
	WCPeWfJRUUM4Kuc0PywCv6FyzqJJfm7t+rinbe72YE2CHDjt7XS15535wEjhSFMhOouA=;
Message-ID: <639ca2ef-5529-a9cb-df31-7968d7f23a2d@xen.org>
Date: Tue, 4 Oct 2022 10:38:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: Proposal for physical address based hypercalls
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jan,

On 28/09/2022 11:38, Jan Beulich wrote:
> For quite some time we've been talking about replacing the present virtual
> address based hypercall interface with one using physical addresses.  This is in
> particular a prerequisite to being able to support guests with encrypted
> memory, as for such guests we cannot perform the page table walks necessary to
> translate virtual to (guest-)physical addresses.  But using (guest) physical
> addresses is also expected to help performance of non-PV guests (i.e. all Arm
> ones plus HVM/PVH on x86), because of the no longer necessary address
> translation.

I am not sure this is going to be a gain in performance on Arm. In most 
of the cases we are using the HW to translate the guest virtual address 
to a host physical address. But there are no instruction to translate a 
guest physical address to a host physical address. So we will have to do
the translation in software.

That said, there are other reasons on Arm (and possibly x86) to get rid 
of the virtual address. At the moment, we are requiring the VA to be 
always valid. This is quite fragile as we can't fully control how the 
kernel is touching its page-table (remember that on Arm we need to use 
break-before-make to do any shattering).

I have actually seen in the past some failure during the translation on 
Arm32. But I never fully investigated it because they were hard to repro 
as they rarely happen.

> 
> Clearly to be able to run existing guests, we need to continue to support the
> present virtual address based interface.  Previously it was suggested to change
> the model on a per-domain basis, perhaps by a domain creation control.  This
> has two major shortcomings:
>   - Entire guest OSes would need to switch over to the new model all in one go.
>     This could be particularly problematic for in-guest interfaces like Linux'es
>     privcmd driver, which is passed hypercall argument from user space.  Such
>     necessarily use virtual addresses, and hence the kernel would need to learn
>     of all hypercalls legitimately coming in, in order to translate the buffer
>     addresses.  Reaching sufficient coverage there might take some time.
>   - All base components within an individual guest instance which might run in
>     succession (firmware, boot loader, kernel, kexec) would need to agree on the
>     hypercall ABI to use.
> 
> As an alternative I'd like to propose the introduction of a bit (or multiple
> ones, see below) augmenting the hypercall number, to control the flavor of the
> buffers used for every individual hypercall.  This would likely involve the
> introduction of a new hypercall page (or multiple ones if more than one bit is
> to be used), to retain the present abstraction where it is the hypervisor which
> actually fills these pages.  For multicalls the wrapping multicall itself would
> be controlled independently of the constituent hypercalls.
> 
> A model involving just a single bit to indicate "flat" buffers has limitations
> when it comes to large buffers passed to a hypercall.  Since in many cases
> hypercalls (currently) allowing for rather large buffers wouldn't normally be
> used with buffers significantly larger than a single page (several of the
> mem-ops for example), special casing the (presumably) few hypercalls which have
> an actual need for large buffers might be an option.
> 
> Another approach would be to build in a scatter/gather model for buffers right
> away.  Jürgen suggests that the low two address bits could be used as a
> "descriptor" here.

IIUC, with this approach we would still need to have a bit in the 
hypercall number to indicate this is not a virtual address. Is that correct?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:46:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:46:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415336.659882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeVb-0005rT-JZ; Tue, 04 Oct 2022 09:46:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415336.659882; Tue, 04 Oct 2022 09:46:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofeVb-0005rM-Fh; Tue, 04 Oct 2022 09:46:39 +0000
Received: by outflank-mailman (input) for mailman id 415336;
 Tue, 04 Oct 2022 09:46:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofeVa-0005rG-Ld
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 09:46:38 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70613eea-43c9-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 11:46:37 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM0PR04MB7011.eurprd04.prod.outlook.com (2603:10a6:208:193::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 09:46:35 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 09:46:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70613eea-43c9-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I/1Suy7jHtSk8ZYRGs/FnLEvjF9fujxoXg6g+wFLxa/WAfue+uTFmS6cxZejslLv1WH6E0zzd6o5FMJedn19KRVgVD8m4NDmQBbCWay0cbkhQ7sfKvOOUAKnPpAwSYASKcmMHqaErRnCBLe/bhDAWWbv08uzmyprRZlsS1HGxCBOBb+L9EzqJGF9qjjIR4h5qcU1isQeLcmW8P5lPK8CCrVmCjiQiH9nu8DLVQW9AFIH3Alk+sOYElPu1CfGIMKvjU9JXa69cmgCs12OP1o8z/nRNHvY8Z4z+DNv5gW7t+NY5wd3ffIAYPGFu4NFHZZbLsz87zO21lOt32AST8WnDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hu+XXVnldcVSYE/oko+f0oYUaDiRWGRWLd3oirZvlg4=;
 b=TwGdFArBW+U6oxTllNLPU6tteNGVH7UsLfr6pjIrLz7dtppd1b43AQ4cGA+Eljm7c1FpiVkNbg7w3l76GtyYLCd2ooIRmUNR7wZ8zzjuVrx4DDjyU9nlQ/yZ+GPh0EcSGD7pcG26y1OVADHwr4DxKG3mcwCzcZoEYq/o54iHHfyGRxCZYDqucO8G7e3VEURjtn8Wkmh/ACXEom3Ghnjn195zkP4FA6/AeCpPDz1FkMnfcK+6BoZcnthhIkfmi4aTqSjRTKXqK/49vZLcfYnZpKOf1rXQwVD0zJBeSIsZ9esw34EVnBPSn45t9IZDwywd+/1tal0/X/RYU0hs5eS4ig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hu+XXVnldcVSYE/oko+f0oYUaDiRWGRWLd3oirZvlg4=;
 b=bmlWy9YqxTo/gAhpqmfqbEMAsxZluTgrz7M9YPh1CERS8UhzZJ9/cTPxCx8sqH5S9/Yzq89nfyy6txEjvemd/hqtzr/ssp8eDZuenEGfYYv/EaMynkVS16sVwma7RvL3JPTWxPCeR02jseDCyDKdF9FCxIgujADNkYB44wsN5oHIHj90yhF0+77jdb6H+q/5oCFEGv68EIkDVODYMs7sLnakGG5JN02Oz3OGHbzuDLGAwPvt/c9c9TFrSOxeRgAyn6KRc2JRCCUb33r7uNXgiQoLF7clTXGYTP9HJQd2T5HfEU4MfTH1dJYkrgFzaTxTwHRdh3DfRTuVvN6xzZCD3Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4cf15704-12df-c43e-c683-15e9a8ab1d05@suse.com>
Date: Tue, 4 Oct 2022 11:46:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: Proposal for physical address based hypercalls
Content-Language: en-US
To: Julien Grall <julien@xen.org>
References: <98b857b8-f36a-e935-8318-f17dfc3457ab@suse.com>
 <639ca2ef-5529-a9cb-df31-7968d7f23a2d@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <639ca2ef-5529-a9cb-df31-7968d7f23a2d@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0026.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7011:EE_
X-MS-Office365-Filtering-Correlation-Id: b650342c-d820-47cf-adbf-08daa5ed5370
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jSpgKHpSJ8B8kKAb+8TOJBCIHePsf2nxLTEVW/N3+mz1Tur8F6tX5SDQ7o29G6uFrC/KXOkgr9zZu1YY+ZDC1xKJnmnzhVI0BesSVqc0hzg4FdygxCB0HD9Slk2hmLxsADSy0vWyejwMB0KtCuva9UIy/GHeE6KEHiepNuHONmBI4P75ol3ZLaTMYfwDGpt88aBBJkTV5N+cXkFH7hBqAuJ3M49VG3sQsXv3LtrOQPlKpIMdTdMrbPNUdr6Cn79XitJ45X67Xv0DfmUBNrHYtG6IQGJGOhAbO+1BcKCgTC6oqNSUYMWfZWU2/LQ1OsNphbMTI1zlEArnSPMM7Xin7FdS6CtjVefUkElqX85gc5XQORpRZ0XQWaBkQ9rfZDnVMCl945RaFVuyrUILH/IC4VSvurAGNjoz47Xs69C3qnWMaYxzu3QBZoRGetIdYU142FALDO1dW3lEdW1AxbuM4FEanaQ3TKfgObhnmvpT6BA0Lp3zZ7hz4h3//98tZIVOnlYyAtqjyI4Agjxk2OIYLsGkmW6xxwDlHwrDD6MbGi1+Fg9xYonB22kHolrXb78ypDaJcd8fjY9ImcurX8PMMskcGuBGhwsLEAlLr7AW/LzNyilgAxBOVQbWBKIYhgNCQX8Ch0DRUrHyS7M70BV13yfDYUSna8hITxMMxwvBbO8Ds3nRW6dzoPuIEb68t/DBbgvuvpZyBmZKU14ecFpcmDGIFkq7zu5s+ZAm+I4A4u66ipWkNX0WOCZteXhfz6VPuXSNLcHEcuyxNgjk7zfyBAp/9P3etawZsDemI/IVD2w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199015)(4744005)(8936002)(41300700001)(5660300002)(86362001)(31696002)(26005)(36756003)(6486002)(6512007)(6506007)(2616005)(66574015)(186003)(2906002)(478600001)(53546011)(8676002)(66556008)(66476007)(66946007)(4326008)(316002)(38100700002)(6916009)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0NJa0UvLzh1dnByR1Boc2tZU3RHVkp2RzhNcjFYWDdDMUVSajJJYlJLT0hz?=
 =?utf-8?B?T1VzZlhmdkxZVnlPZ1QyV0thN1gwZlphTWg4S2k4cTR0YUl5c05kekhtYkVl?=
 =?utf-8?B?ODZ4Z01RN0tYVHh1RGFMMWxselFHRTBNK3FpelNIUWh6YnYrNjlBYzJMc2Fh?=
 =?utf-8?B?cWRKeXVLdkRZMWZZcWsvU3dSclk1S2l3RUp1SDlxelg1NFlwTnJnZnVMQjZG?=
 =?utf-8?B?UWpzVjdSaSswMVJxeUh2RG9wdnhlT2RmYytSbFVCaDZxd3BibEplSGtWS0NE?=
 =?utf-8?B?NlZSQnhoTDFuVUFVVnZSRkx3TXMrVnhrRlR4dnU3d05KcDJhaXF6Ry9zZndE?=
 =?utf-8?B?WEhYVnplN0FuQVEvcWRNbktpaHN3bTAwaEdJT1JGL0xTSThtVkJpN1QyeDNO?=
 =?utf-8?B?N3lpUXRsRElKdkRhaUJoVDFIVHIzTWlDYnRsTmRQeDRuTlgxUHFINjJPc3oz?=
 =?utf-8?B?WTI4eWtHVFRDKzYzVVRiaFczU0JBYzBZNGpRUG9EVGZaWTlXdkp3RVhoQ1Zx?=
 =?utf-8?B?N3ZtNEFuUWZzZUFGQWZHbFd3cmIwaGtuaG1mVUpodk5laTJ2UkhKVTduOTU0?=
 =?utf-8?B?M01LaFVtdnN5UlhqaWpmdkF5NDZLTVNUWTR3QUVtcDdLMmdFUGFORTNwT1p4?=
 =?utf-8?B?c25hNjdhM1JCeUNTdjlaczlJL0RacmtwanUxTlVMNnNrckhjTkFubjhxU1dl?=
 =?utf-8?B?b3lGZ01oVG5ZQTBRSjFOLzNHak0zTUZVdkFrclM5WE5XZVR3SWxWZlc4QkxW?=
 =?utf-8?B?UjQ3dlMxanFHMmo1Q0h0UzJxYnZaYnRZR3FKZ3F4QnZWVUorKzJjUkpqekRM?=
 =?utf-8?B?WVZrbEpjbXd4T2U0MnNvbkUzUTFWZ1hNak9ZK3A5QUxERGlCWFNSak5IcU5Q?=
 =?utf-8?B?cEJkWitEbnlLSGgxeGJ0aWdpUFd2bXhYTlc0bVUxWTNWU3d5NldSTXRTeGo4?=
 =?utf-8?B?UjIwdytsV3hXam9LdHFJNUR3ejErSFA3Qkx6VVgrTzh1Zjg1YmY4bVNiTjVh?=
 =?utf-8?B?N1c1MGpJUURvV3JlUzlYT1c1Y0p5d0NselQ0aGxQUmNQQkcwYUo2K3JzcnMr?=
 =?utf-8?B?U0tPYTBHZlBnSGMvUm05RHNLM1ZLNndDdTJEamRuNEw2dFlWRDk2VGdmZGdE?=
 =?utf-8?B?cmlBZXdFREU5TUE0bURwZUF3M1JlWFUraTRiQ0x1TlpNNnZEeEdhRERLY1Ft?=
 =?utf-8?B?blRqZWo5bjlsTklQNXRKWm9SK2w1R21QRXF1T3BEV3k5elRQS0ZIVGFrOFRr?=
 =?utf-8?B?dmdaaURlL1RDVUhXRXFrM2dzQXJQTUpuMSs3dVVaMnRQdFRTQWhrYVRTZFJO?=
 =?utf-8?B?RHBJbzBpazk2cXMrY2toT1Y3NFhhcUMyWmE2MmlkRldZdnpsOEF1cHlKRjVU?=
 =?utf-8?B?MG5JUERFMGZBWEtwU1B4Q0N0MlNRU1NBeEhKOWd4d2Y3RGI2K3plZTZiNnRi?=
 =?utf-8?B?Qk9tU3pVMGF2QjMwOXltdnFJYy9CTHg2aTBrWUMvUkFqTWNwSTM3ZVZlZVNn?=
 =?utf-8?B?R0NQWkt1K0I5Zjl0SVJiVld4MFJxYk5ZQmlQUnZEbkFrcm40QTNQbFJMSGJ0?=
 =?utf-8?B?V2hTOW5vZE9FZit3RHMxRk8xd0pvYm5BYVdjRU94SUUvcmtDUnN4KzZYQmlM?=
 =?utf-8?B?cWt4STV2VXdqTUx0eXBuYjMzZFc4L0hncEo0Y2NsZXd1WWQ5WEJDVHVlUUho?=
 =?utf-8?B?cEdJNHF4RGNlcnI2QzV2UmRkcG9pUUo3aVR2aHcvQzZZMzNyMVd5akJOVWs5?=
 =?utf-8?B?T0x0bWdnek9uQUhEOElIQnBuR1dPenRqM2dsVTdWUzdBOXl1RjcwTTltVUFU?=
 =?utf-8?B?c2FHL1NWRGIyUGhqMW9CVmJ4anFXblVkK1VHUU1KeXU1MTM0ZVdRM0FRYzFY?=
 =?utf-8?B?OEFTaEMyeWpwV285U1ZXZlRzaGNiQW5HMkpBOVVmVXN2cG1ULzFSemo4YXl6?=
 =?utf-8?B?aDFQNURxb1RKcysvVCtIUzhHdDJmK29xckRiWjYyMWJSYU9KSVQ0eEhQU0R4?=
 =?utf-8?B?dEcybm1uR1dlQXNMNEFBQnJVSHdHYzhSSGxRR29yV01LVG1GYVRrZlJGWkJr?=
 =?utf-8?B?ZW9HMnJKeWprWWF5Q1dpem9sNG9OU3dsbDRRektBcHNsY1hEc3JLc3ovc1Bh?=
 =?utf-8?Q?VgVMSnJXHQ/5NVCZvJo1h5nKF?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b650342c-d820-47cf-adbf-08daa5ed5370
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 09:46:35.4571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E8lQDVq4ZVfc+s5Z+o3tmn8MTZM+KJxPsbtHwrHf3KwgfSknZ0F2kezKiS2jBztsDJD5cWLjrZBy3R+a8OuaKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7011

On 04.10.2022 11:38, Julien Grall wrote:
> On 28/09/2022 11:38, Jan Beulich wrote:
>> Another approach would be to build in a scatter/gather model for buffers right
>> away.  Jürgen suggests that the low two address bits could be used as a
>> "descriptor" here.
> 
> IIUC, with this approach we would still need to have a bit in the 
> hypercall number to indicate this is not a virtual address. Is that correct?

Yes.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 09:59:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 09:59:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415344.659893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofehy-0007MI-OA; Tue, 04 Oct 2022 09:59:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415344.659893; Tue, 04 Oct 2022 09:59:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofehy-0007MB-Kp; Tue, 04 Oct 2022 09:59:26 +0000
Received: by outflank-mailman (input) for mailman id 415344;
 Tue, 04 Oct 2022 09:59:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=d4Mf=2F=xen.org=julien@srs-se1.protection.inumbo.net>)
 id 1ofehw-0007M5-R3
 for xen-devel@lists.xen.org; Tue, 04 Oct 2022 09:59:24 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38a0a349-43cb-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 11:59:23 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ofeht-0007cU-6x; Tue, 04 Oct 2022 09:59:21 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225]
 helo=[10.95.104.225]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ofeht-0005W1-03; Tue, 04 Oct 2022 09:59:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38a0a349-43cb-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=5FN6rAoecXFWW8Wg641o9lU2sQND2cUBDx4uyNk4M0I=; b=oHyvXJa0QbvtRRUwfdBOnj704j
	3Ubs9OOC5Hr6t1xG2I8BPpUO+c9SXzYZsQYSbwaPhyXfNMfa2JxulpdL8/HILXrfcl0rJlabeTpS3
	Jo2Dl9uEPyLG6ZC/H/rrClLp3rtY5/sfKVgwRGhplLT44/ZCwrXkfaXIpVdPHazSzTD4=;
Message-ID: <a4907928-d3a2-f555-c30d-66aee18b2a62@xen.org>
Date: Tue, 4 Oct 2022 10:59:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH V6.1 3/3] libxl: arm: make creation of iommu node
 independent of disk device
Content-Language: en-US
To: Viresh Kumar <viresh.kumar@linaro.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xen.org, Vincent Guittot <vincent.guittot@linaro.org>,
 stratos-dev@op-lists.linaro.org, =?UTF-8?Q?Alex_Benn=c3=a9e?=
 <alex.bennee@linaro.org>, Stefano Stabellini
 <stefano.stabellini@xilinx.com>, Mathieu Poirier
 <mathieu.poirier@linaro.com>, Mike Holmes <mike.holmes@linaro.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>
References: <099616e1092409fceea4eb30590215310f8c091c.1662626550.git.viresh.kumar@linaro.org>
 <ebcf40f0d5dfe6bfa27c11dc2fe3e65df48772fe.1662734469.git.viresh.kumar@linaro.org>
 <YxtVjpDU1HOrhiAE@perard.uk.xensource.com>
 <20220920102915.p55lt4ee5hbxiun2@vireshk-i7>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220920102915.p55lt4ee5hbxiun2@vireshk-i7>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Viresh,

Apologies for the late reply. I was away for the past 2 weeks.

On 20/09/2022 11:29, Viresh Kumar wrote:
> On 09-09-22, 16:02, Anthony PERARD wrote:
>> On Fri, Sep 09, 2022 at 08:13:28PM +0530, Viresh Kumar wrote:
>>> The iommu node will be required for other virtio device types too, not
>>> just disk device.
>>>
>>> Move the call to make_xen_iommu_node(), out of the disk device specific
>>> block and rename "iommu_created" variable to "iommu_needed", and set it
>>> to true for virtio disk device.
>>>
>>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>>
>> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> I don't see these patches being applied yet, do I need to ping someone
> for that ?

We are currently preparing to release Xen 4.17 (plan for November) and 
have stopped accepting new code (other than bug fix) since the beginning 
of September.

Your series will be committed once the tree is re-opened (hopefully by 
the beginning of November). Please ping me mid-november if this is still 
not applied.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:14:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:14:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415352.659904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofew2-0001Jt-Ut; Tue, 04 Oct 2022 10:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415352.659904; Tue, 04 Oct 2022 10:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofew2-0001Jm-RD; Tue, 04 Oct 2022 10:13:58 +0000
Received: by outflank-mailman (input) for mailman id 415352;
 Tue, 04 Oct 2022 10:13:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofew1-0001Jg-68
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:13:57 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80075.outbound.protection.outlook.com [40.107.8.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40e48b8b-43cd-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 12:13:55 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7214.eurprd04.prod.outlook.com (2603:10a6:800:1a6::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 10:13:53 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:13:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40e48b8b-43cd-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mjflINUVDFitznvAQD23KnY6sS2pM6DUq7TY0TVZKeqF53+aGkIJNLtUvbqlu3Cc56QQq16NUNw16z5IjQSaQQtfNenaHkcW5pbxcOFIUyCTui4burJydzMbJkxUJtJSvVD8O6Aoxs/N+Hd74UB/sOFyzEZFU96aJs4vb/19lunkPaI6Lm+05MFWN9QvqS2lT0maBWGENYOBBEI/L0lpQBhxYsY9nwke7r/aP730G19VX2ZKAy0yb6pRxhtYv5iScGpuvzKWFKNYhrA3ZvTxIkMpqu7u/SViXr0iUqSFigG0JYos2NMe00s2qcpnItaWWAVS6FOfFQyB/8gFnI2PQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cW3dUW2PhLY9fHD9lB+xnYzINvkpKb/gaU4i2IiPwHY=;
 b=TY/lJuYkwgejo5p0OX1TVRh6FCD/dZtKokRRcT8i3QP/t8KMr+a0BiOtAIj2Ab/f/sySFag7s7leX/uWhFuuqoFASYCcIzVeHDPCXk3cmWdEdSlIrTP7xEo0eaB1liW5BYneuE7Fv9wwO2nYjbSqhk84F1hax0cokO84NLvZrCmixMwMjp4lqpAKjVO5YvUW7M698ry20xk3D8A5oWPVQc3zpQIzSyc+tum9/pY8xZXMtSC4TYOOUlUzMHqUOifGfhow/Tn7SMxPsbKAh/PEkMPJ1m+lQcbHme1p/19vfyk1ir4oSIzho46T+NZjn9U4jf03EUXPLTuolGB/LaROUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cW3dUW2PhLY9fHD9lB+xnYzINvkpKb/gaU4i2IiPwHY=;
 b=G8D/c5vJsLsmXOC00E7seoEPCOc5N5qjg5+vLFupBi73JZToCkKDwLLFvKb5Dag6XEkgFcCjpsU6wCbx+J3q53D5mJosZJsMAr6fmEBUrY8aK8EuZocj3oLH0KilsVjEdae0yWpZXIGlnjOC0jHvo4Wr+heZ04o5lXnoCAN6/EwT/uDc0VaqLoqZYpeE9GnYy0P/TJm7z0P+FDmgiPU4XX4wzrum9E8NIclkrlDk+CKOafhFSbCzk17mXKDTKDlH9ziExHQMu/vqKCCi5s1BSllBESTpAOBKFSf/ty/jJ9h33y37ZhbQfFBx22Bb0e76gsoAFuHZYlfbA10V/aldOA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
Date: Tue, 4 Oct 2022 12:13:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7214:EE_
X-MS-Office365-Filtering-Correlation-Id: aaac695d-8e3c-4db9-bb43-08daa5f12214
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XtAA9fGK4ormyZILJM0DXvg1x3WgUBmqG9vSnCwUQ4aVK3FP2Syi1uLVlh8yBYzAZeALXFKVY4dEo05C1wIPf53lKW/AXggU3xjCt/R72GcSsqyo1tWOp1ggC3GMBaTP664ZByNTcdneJTvZZ2sISwWwnICy/VscSI3/4orNTAWogZgo/9QQJQFuw83FH0I+XhcGKe9dZHuPH6d4Nzn2lsmZdJCTYO71Z3ktwKCgXBPT6bEUze9wgJh6HwiYS8wf7PGKIkaCDdfJSi5M53AEDT7VCfYYplYu9ICR01Dt2FhRsthcygSRjkc1orTXS8VkC2cJtPWPaWCgOZfPlDsjJ1H6q/EF7MLQnoGJsUUzlaUPi4H0M8BkorTJ6u5t3xuGtgPOLo0WsWRndd3spY0ABDl2rPpg1+RbuAq7at7n1n8Fiy4QnQXsWYoe6/ZqjFNdOwm14P/q4IJsj+MO/VuvqwhIw32FkKIWmONjzpXy5bIlFaWjBRZLcLgO6rs+x9CIUD76qaLRWhKCp5RAkYIemx9ldCbFkEON/231w15Uxk8kymupF3lDLGZiw2B0hFrba6Z3D31Oa3RSn8K5pTlnQ9M+13kyrfDM4Xw4mvLQ4BYHwrR+T4wESQGFd5YsZcaz+duWIebNYRj25sgTrb/Bgp2whQEWqHtNJePUvvFUTzIyFkLcgFSnegU2S8b2pcXGZlBhTwmj4P4l63eBCvTcfH8c8TFniibU6jkrKeV/VtoYLFLtvsfEbneG9yD+N627doD+RfQSoDjAvRAiUN+zkp489pBz1lHLNpR4ESlz7Wg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39850400004)(136003)(346002)(396003)(451199015)(6916009)(6486002)(316002)(31686004)(478600001)(54906003)(38100700002)(66476007)(186003)(4326008)(41300700001)(66946007)(66556008)(8676002)(8936002)(36756003)(6506007)(31696002)(5660300002)(86362001)(26005)(2616005)(6512007)(2906002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RkZSajZDUmUyK2Q5SG1BcnRPYW9PSDRvOGtGa1Z0ZlRFU3phbWp0ZHZjaE5C?=
 =?utf-8?B?WnpaTTRJVTZVcVBRVFJRd3pGN29JMWtOOC9hQllZRm1SRWYzbk5xdVJvK2Np?=
 =?utf-8?B?andSOVRab2RzUlVyblRvYStsMzl0dk8yTkhGSFNuQVpyelBjb04xWGJXSlhW?=
 =?utf-8?B?YlAzeFVkSlhPOUJZVWFBcnpsV0J5cVd5eU0zT0NvcU5LREllV3ZRTXFzTXdI?=
 =?utf-8?B?VFp5dmdZdHRRaEVDR3gxeFdQTkdrL3ZrNThEaXVVRDhBdEN6dnVXbjh0LzNZ?=
 =?utf-8?B?aEthWnplaStkclgyajgybHNlZjJKbk5zUmwvSVBTNVp2dVRFRG1uRTBZZXJ3?=
 =?utf-8?B?amkwb2Rta09YVEQyWGZ2STBNQW1LZm51aWdSaWZiV05uNFZyQXJOczRLcXFF?=
 =?utf-8?B?Zk9EMVEvOE8rL3dSQ3R6QmxPdHBwVnlmU3BjRzhvU3c5L1pPWjRhYUFsQW9T?=
 =?utf-8?B?ZWk3VjRIZCt0SG9RTlI5eVAvQlZkRXhXOHlrbE85UVNvSGlXMWJTSXlIekN5?=
 =?utf-8?B?eXJHaGZjMHFTdm5RVkJpajdMTXVMNTRXZ056VWE0VHd5aFZIRyttNHliNHh5?=
 =?utf-8?B?UXRMUWw2U0NqOG5saWRXeXlERitxSHpVWWF4dytNYmsrWFB0Y2VxaFJsR1g4?=
 =?utf-8?B?NXExMERNTTRBY2ovZTlkc2FoTENIMk9iZ2F5cFFiZE51QmpLVll6YkFTRGVW?=
 =?utf-8?B?Wm9MR2JMdDlPWGZMZzBDaFY1ZWp3Q29EVktMSW13ekc0eWF4OTVmaml6RmZG?=
 =?utf-8?B?RjZ2R0lWNlhaNWQrdklxdzV1WjRZdEhqemdic1JRQkhKSDJxd053MzRpNDZP?=
 =?utf-8?B?R3BGVFpJUkl5bGJ0R2Zna0MzOU5xdWl6REZBMnZaNEV4LzVQUWIrTzRwOTNZ?=
 =?utf-8?B?YVFqR2VZaUYzWjdnWjJReTloVndrcjRqbnNqWWVqenN3ZnFxVXVlQlM1L2x0?=
 =?utf-8?B?QXJxbUZWN3RoREFPWS9aakFpMVVpMm92UXNQVFZTMDRZUGFjUWR1ODNTOEFT?=
 =?utf-8?B?cU1xekhZSmdaM1JJNHgzUGErb0VObFc1RzVpRjNvNnYrRzNtanNuem9IV285?=
 =?utf-8?B?UmxUb1JGMUx6OUo0Z2NZSWVWelNaZGo1c1VGWlF5d2ZHSzdZbU54TmkxbHpr?=
 =?utf-8?B?cUZBN1V3cU9NWnNRZnJlWVl2SWgyM0VvZVpyWDlXeHpHaFpjRzBCOXhVNmRi?=
 =?utf-8?B?U1d4TVRVdHVhZVFzOVBIZnJveGtsMUl1RHhPS3dTMThjMHB4Vks3WGk1bnBW?=
 =?utf-8?B?eXZnM2thK0xIY0IwOXpaZGpKZ1RibnN1d0k5eDRKRVBvK2JZM0JGcEh0SktM?=
 =?utf-8?B?VmozekQzckYzaEUvZk50anFLOXRXYTNCWmphb1MvdTBkY3doRTl3bkh2ZUp5?=
 =?utf-8?B?djdHbzVnMktEZTJUcmhEYUFOZHlNalZ1UDJ1MkRiRnZnRVNOZUtCdzdVdDlM?=
 =?utf-8?B?WTZCKzlqc290djZXVHNyd3ZxZ2swb0ZjK3ZPSkJkbUgrZUswTklqRUZRaFF2?=
 =?utf-8?B?Znp0aDY3S3d6cC92Y28zRE9pci9pdlFKZ0d4VGdPemc3a3E1TkkydzdOdEdJ?=
 =?utf-8?B?cDlrVU5pWTRKeHhBYjFRL1pZd1ZlL3UxclRzaCtJMzhlSUhOL0x2c3lLcFJ3?=
 =?utf-8?B?MGRINWZBNEIydWhsZG1RL3QwMzJ5aE1XYVhBNGliL1dWNVllam9jREtCTXVu?=
 =?utf-8?B?SjU2M2Z0emtNaU1KblJPaVhWT1RIR1hMUldqVU5GcGQ4cDI4NHVkeElablVX?=
 =?utf-8?B?cDl2YmNrMXVHRDZ1V0xId0doRnVZRHBaWXRzcVUzd3M1V1FLUTl2TFhScndU?=
 =?utf-8?B?MWVRYit4RVI2aDJLbE1zakdURUpxK2U4MnU1RWFKTUE3NkhxTmtBdmNDN3ZM?=
 =?utf-8?B?bEFhbXllV1FvSVNsaEdoKzlhMnJBSGxuamNvc1FPZERZTEcyR1ZXdUxXYVVJ?=
 =?utf-8?B?OGp5bWJUcTFnVW5CVExYMWNCbHg1S2F0MStBUksvL3ZDU0JwVXJ6eXFtK1Vu?=
 =?utf-8?B?VEdFODZrU1o5K0RMeFBTVFAzQndpNDBoMlBwc0FGNGFFOGhQeXo0WTAyRTlw?=
 =?utf-8?B?U0ZXeDg1emU0K3BEN2NJYmtlTGlPbENiVWN3ZHozaXd6dkRGREhTUWdOQ3Fr?=
 =?utf-8?Q?MaWRbV0QM1j7u2uAWv1SgGsWd?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aaac695d-8e3c-4db9-bb43-08daa5f12214
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:13:50.5081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TVsLdljVVbAfJee74ZipLNEqr5Ok4CyW/1BOX6eBPzdnblktTzyGVlobYU18BhR8ocoSA4q5CEubQtOFK+D76g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7214

As it turns out populate_memnodemap() so far "relied" on
extract_lsb_from_nodes() setting memnodemapsize one too high in edge
cases. Correct the issue there as well, by changing "epdx" to be an
inclusive PDX and adjusting the respective relational operators.

While there also limit the scope of both related variables.

Fixes: b1f4b45d02ca ("x86/NUMA: correct off-by-1 in node map size calculation")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
For symmetry it might be helpful to change "epdx" to be inclusive in
extract_lsb_from_nodes() as well. I actually had it that way first in
the earlier change, but then thought the smaller diff would be better.

--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -65,15 +65,15 @@ int srat_disabled(void)
 static int __init populate_memnodemap(const struct node *nodes,
                                       int numnodes, int shift, nodeid_t *nodeids)
 {
-    unsigned long spdx, epdx;
     int i, res = -1;
 
     memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap));
     for ( i = 0; i < numnodes; i++ )
     {
-        spdx = paddr_to_pdx(nodes[i].start);
-        epdx = paddr_to_pdx(nodes[i].end - 1) + 1;
-        if ( spdx >= epdx )
+        unsigned long spdx = paddr_to_pdx(nodes[i].start);
+        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1);
+
+        if ( spdx > epdx )
             continue;
         if ( (epdx >> shift) >= memnodemapsize )
             return 0;
@@ -88,7 +88,7 @@ static int __init populate_memnodemap(co
                 memnodemap[spdx >> shift] = nodeids[i];
 
             spdx += (1UL << shift);
-        } while ( spdx < epdx );
+        } while ( spdx <= epdx );
         res = 1;
     }
 


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:23:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:23:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415362.659915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1off5F-0002q7-VH; Tue, 04 Oct 2022 10:23:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415362.659915; Tue, 04 Oct 2022 10:23:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1off5F-0002q0-SX; Tue, 04 Oct 2022 10:23:29 +0000
Received: by outflank-mailman (input) for mailman id 415362;
 Tue, 04 Oct 2022 10:23:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1off5E-0002pu-Ii
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:23:28 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95aab835-43ce-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 12:23:27 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8664.eurprd04.prod.outlook.com (2603:10a6:10:2df::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 10:23:25 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:23:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95aab835-43ce-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iKia2ESymRHCJ2YbiONAccijoMAofr1Zg8hjH6crBcac2mL2W6a7mvR1asZ+MDekOVLXo11mhSMy5Gf9S/vPDODjSx8kd2Qv1Vsid1RdaNHrDVfUDQS4kjJGe6GhF4+eHNVE67QgKlfTfwLaueStfWd7w7D+Kv1aHVZ7krA/TVDRaZFvZaWWnMixBgeshBkKuSLY8KcA2feNKMRJMjbCNreEvAKcNeWHPTJNWwOgq3N+UUK+aZH+6sBIwM/vMfhtcFp07o3M19SIHlEeq0AbX8ARszGwsWDjHWr08OHgEnqw8VZDz2nQtUh322n7l0DNqHqisLnID5eTdXdQ+aeQ8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cAlwGqefZuBiR8QpS89lDHhkc9FFi0V4EjZysqqlx/8=;
 b=YBue28xVPwQtRjjPAHiEbfOFEywZrQVXuttWE1mn7Fg/vG+MI8GSPigH5yyGkBP9bEGpTPXBWOLanF5+agG5UgGtqhuqo8gAl13plWmy8Qc/AJfpRV3q8NabWjv3LJ9Ak+mz1TkM0Wif1UIT7Ad4nrTvDUX2FYqaFb6jpp2IH09NfGifgorcelCo3k1GFVVIeQE3Ptow9nhXiOfXQE+VV3irzlZ+bZAgbBSubTVuafPTfeIyekenlLhti7hJbGu1KMZiVcYg90Jt9goW5buag7TasIEkz98kSKJlf+xI/7CbDqM4sthxwCHzMMY2ZrL4GiB8CrJYLZw3zswiUsEfkw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cAlwGqefZuBiR8QpS89lDHhkc9FFi0V4EjZysqqlx/8=;
 b=gs+CZXiBqIrcpkQUj7G4tUbMhEfk6EyOxqM+F4Y/yadY+ozYoYcjZgwZC/gq83hURqUVwZxsXMtMDMPo4D9R2RME8mISL7l+2w/HrpJVcMZ1xzoNOJvV2W4BNeJFfS2A28C0RjqgbsE63Xz8gdWdldysJU2TkUfgE8hPQrdtQfLKtpQH/DxEydyM7AOKXK+G2TfVk/aOusu1SoWle1C/3JH4pb9dQg9hUk4LeyGuB8BW87RbL/PMj0LWoQCVz0tkMimmMK+aP137AgGnizLpavIWP47NxuOFdsDkGBkw1Wc7T7HIKg0gw4WN2jtq8lz1WzvABEcSB5t42PbaZH68QA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
Date: Tue, 4 Oct 2022 12:23:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P195CA0029.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::42) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8664:EE_
X-MS-Office365-Filtering-Correlation-Id: fa3d3019-7b6b-4a72-5483-08daa5f278aa
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6i30KGPNeVNvwznfoWLKEKNCbYJCv+q1qScH6YAukRyAIo2YhOkAcOCiGXpF2UKIsLi4+joSF7aElVd3BUwrGF6LHD3z2qtMrBV/DnXQq53ww0yAcmR3Akw0KfpK/9oTA77Caa7tWgtOsuHgYr1A8b7vJpHtOxvaB97PrrMZpqdbRyn53+ZTTEh+bkGM2oanIfYf0QcOQ9E7Xe3RnoTNPBVRWMEC7bKzmW8an8sgacKD/5f+MbWgGwBrPuWopXQSj11uUSs2jJUriXeWuO4XFrhxVcHoTm+yT20Srwk5LwIHcxx9N9jEeDr3RjNB9ppLcuWv3DZhPHI31M5cOG6GakwXY+wh736NziFHwIBMNdhpGcWKSqZTGy4jaNKOq1Zmc4bKdZqGCUydYWS2PRQptOJ9FYuQ6J5ZBgSPi/y9nfrVgVM5KQFRasJXTQ4S0t3pSGaLXK8u7ApXhw4bLyQEGkuIaHXuj8eSZJbgizsfgp7vaZyRQbYe1p62JWjMw2OE7BciS0giOo+Tn+SSPQrmCXOXazlieFPMRee5ylWCXd5hTOtwNdv+IhRSvmt9YMlPXmXvhXptb7k389JeV1paXEuvplVfDdnnv8y2Rq2oL6XOMYnvJBefTpLgj8kEfZdEj8p06PZPOxY65+hPEp2Nsr6Y0haM2qwVeIhxM5z5HaX9pp2XmKTAra/BQeovh60yJA4umZwHZe4utGIy9A2dZRz4GYKnVULuXeWbntxb+xN0yruUaAAjmJ4Kwq7L8fbFnGliB9UOIDu/gNE4AipMlfz/P4Yp6oZoBybVpXRgYHA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(366004)(396003)(39860400002)(136003)(451199015)(5660300002)(31696002)(2906002)(4326008)(8676002)(66946007)(6916009)(54906003)(316002)(8936002)(41300700001)(86362001)(66476007)(66556008)(36756003)(38100700002)(31686004)(186003)(83380400001)(6486002)(478600001)(53546011)(6506007)(26005)(6512007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UG5yTnd3cVB5VG1qMDBrOGxNMnkwQU9ab0ZzQTY4THBIb2RwaW1GUGh2bFB4?=
 =?utf-8?B?N1NWZFgvWG9tTWc1YkQrRXl3US9XRWNxdndxdU1mbWc4Wkp0ZkNLRXNXUllq?=
 =?utf-8?B?OGg2Rk1pMDRNa1Bvelk4VXMwYVB5Q2Z4NlBNdjl2VTZ3ZjJIRHk0UUlOZWc3?=
 =?utf-8?B?NmtlVmViaCt0WDRLM3MwSEFsQkRoMmJsMGNaRit3VWUrR2lqYnZ0eGM4WW1y?=
 =?utf-8?B?d2crYlducVpCenJseXNsQ3RDVklzOHU3aFAwTmxnd3k0VTFWNy9nVHJLS014?=
 =?utf-8?B?ajR6UlRxZkExLzBhS045elEweTVxcS82bWJxdVkwd0FhRm1yYWRNS0tBMDNy?=
 =?utf-8?B?OXRoZkVlNjgrV04zVG0zS3QyRnl4S0U2NkN6c0JXOUJndWNtaVRnSDRyREg2?=
 =?utf-8?B?UnowcTFqRVlIY0IvZGNOVHFNS3FETzJqWFVncFgxTmgrMlpzaUxVeWZDNTd0?=
 =?utf-8?B?MFpGV3d0eUJaV3dwN2V0YjZBekgzTFFKV0h3YWhFdDBVeDJNbGhzWDdGcThN?=
 =?utf-8?B?UkVyZVdYNVhnWFpYbU9BNjR4bVRCY2ZBNkREM0wxYUw4U0JVU0xwazkvRzhn?=
 =?utf-8?B?LzFaVUt4RThDWGNQdjJLN1FPd1VpK1V1VHhSL2lPR1dPbm1CRXlxa1dQb2JK?=
 =?utf-8?B?VmZmaC9yMkNxUjAvNEpJczY3YzBLaW15eFlDY2lVZlkvbVZXZEVkQWlEcGtj?=
 =?utf-8?B?Vlh2UFRZWkd6czQ3WEorZkZXTVBXZGI1dms0OTB2TStZc242cWhmajNyLy90?=
 =?utf-8?B?aFlQREpHUjRUV0t6UXVOZHNXZDNMRHFjUklGZisxYVN6RTZqdkZiTUl1U0po?=
 =?utf-8?B?c1o2OE8reUwwYlJJYU1XaUhMQjFteDdlZUt3NzVGdDNRNGx2bkExMEoxWmQ4?=
 =?utf-8?B?a2UrOFZBUFVRMlcyQ05kenY5REgrYUg5ckN1QW5ieGtjYU5BQndNWkpRSzNX?=
 =?utf-8?B?eDAvUS9wUGRmS0ptQzEyT2dUVjI5VmI0OTlHdzNNckErMDFMMUNiRGQyb3M3?=
 =?utf-8?B?YVhIdStpZGQ3Rk4xaytFZ0ovY0UwSXZhajdib2dyZFpSTnNYWHd5UVFYR2pv?=
 =?utf-8?B?eFNCOGMyVjdIdmVPSmpzTHVZS1hQTkR3dzBTMFJyeGJaMzFYanBQd0QvcDFj?=
 =?utf-8?B?aFhlemxxWENIZzl0amxWUXBVNVRnNkpaTzhmaDI4cURZVXhyYmovQ3BFNVc3?=
 =?utf-8?B?MGg4R1lBZ3NSdDZFQjh2Ky9ZNUZiV3ZRTXZGYk0rLzhIemREN3l1WEduVzE3?=
 =?utf-8?B?THlMbU1CcituY1ZvaEpNZ21DTzl6QktXK3I3amdOOFN6cloxRlk2VGo2WU43?=
 =?utf-8?B?anl5QXo3L28vdHB3WVYwODZITTNmcnREUXU1aU5qQUl3ZmN3UmpoNHk2a2Jx?=
 =?utf-8?B?ZmErK2hWaWNHWFZxU0RHNjZobzdyNjVjeFExOGJoOC9iaHBxNE5yWkJuOTY4?=
 =?utf-8?B?NU9WZVNOZWg2anRvUWlUQm9TUWhlR1JQZ3RnbW1RYm1MMEpJdi8weGxOeHFP?=
 =?utf-8?B?eHQ4em1xQVlic0hVaXo0MHVhRXB3aWV0K3M4aW1yMll5ZGtQc1VQNXhhdEJY?=
 =?utf-8?B?VndRdUtiR1Q3amxtaEZaazRPZ1lpWlFsMHlBV00reEdSeTJESndoejRKdFRK?=
 =?utf-8?B?OU4zQ2RHcDNidkJIS3VLNnNJcDlvL2tTU250QVRob2hQbXJyU0VhSS8yT3FE?=
 =?utf-8?B?VXJoN3orVlNDWW84bGMxZk1PcTh2QWhGQk8wWmdwM05rN3ZHY1JMcWllQ09x?=
 =?utf-8?B?TndkYjkrRVVXdVRLanV0ejVXVEpCNnUzVDFtcklyZEw2S3dGcVJlTGt3V1Y3?=
 =?utf-8?B?TFR1TXlOYnNtS2NqQmdnTGVNbEhZWktDK3A1c2RyR1dQNW9zZTZUNStvalB1?=
 =?utf-8?B?TFl0Z1Z1TjNJUWtpWDV5eDFEdi9MbTU5NDlNdXREYkU3V2ZqUDdjTC9aeFpO?=
 =?utf-8?B?eUNvNnhUTVAyYlhVcXJqMUFZNkNlcGk3RVk3OTBSWVNmSnVTZzRlclFqdHI4?=
 =?utf-8?B?MDJSY0hPcm1aL0I3cThoTXNDRlhnc2JvbytTdlBmcllPVE83VldxSDgyR3V4?=
 =?utf-8?B?NTZUdEdBTTFHQ3ZwalI2MHQ1U0Nrc0FFVzRkTUcwd0ZHUjVSVzN3cTFZUHlX?=
 =?utf-8?Q?UhrS8+iT7kLrU+Xr4u3E4hp25?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa3d3019-7b6b-4a72-5483-08daa5f278aa
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:23:25.2850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V/WBiAnfJIN630svkPdEJAG5+S0Wrmv2cdWnV2EzRh9mcoCFMnLSls5Ao4iMQh0+2mNZFbawGLzw9Y5BUNTjnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8664

On 04.10.2022 11:33, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>> higher priority than the type of the range. To avoid accessing memory at
>>>> runtime which was re-used for other purposes, make
>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>
>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>> dom0 doesn't try to use it either?
>>
>> I'm afraid I don't understand the questions. Not the least because I
>> think "it" can't really mean "dom0" from the earlier sentence.
> 
> Sorry, let me try again:
> 
> The memory map provided to dom0 will contain E820_ACPI entries for
> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
> overwriting the data needed for runtime services?

How would Dom0 go about doing so? It has no control over what we hand
to the page allocator - it can only free pages which were actually
allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
DomIO - Dom0 can map and access them, but it cannot free them.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:27:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:27:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415370.659926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1off8q-0003Si-F3; Tue, 04 Oct 2022 10:27:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415370.659926; Tue, 04 Oct 2022 10:27:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1off8q-0003Sb-CH; Tue, 04 Oct 2022 10:27:12 +0000
Received: by outflank-mailman (input) for mailman id 415370;
 Tue, 04 Oct 2022 10:27:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1off8o-0003SR-Kn
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:27:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 18beec16-43cf-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 12:27:08 +0200 (CEST)
Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 06:26:59 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DS7PR03MB5448.namprd03.prod.outlook.com (2603:10b6:5:2c9::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 10:26:57 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:26:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18beec16-43cf-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664879228;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=x+wp1zcD9twzsz0I/8jNc6kSwFcanIHSqtAksoTxnfM=;
  b=Z9AgPIjPCV3ybVkGaBEqRScA090ZkhGNocQjxWaJARvFUNvkjfyLquPn
   F33KAoSGsJSmpvKhoMs5AnZv6CJ8rHGsuk9ymhgJvAVua4fF903LqwjJG
   fbwmy+3w6TdHDf7r/vCypaZO+yO6wLWIx018YBXeglXUOQVRir3Cj3c7U
   8=;
X-IronPort-RemoteIP: 104.47.59.169
X-IronPort-MID: 81940470
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3Ak5JKEaLxAym6EYKnFE//H55yvHf4RhNe4xP0q?=
 =?us-ascii?q?kmnJc0pyRJZ0RWMlPhd8sEGEan5YGQtjswdUusWqfUZCV8fw9TjAerbME2vT?=
 =?us-ascii?q?7P3+0XZ2uczS8WyRM/++sjSsjFWMyDg0ZGDz6fpM8T0ZtKpAB+CfeWy1D8Bf?=
 =?us-ascii?q?QUP2PpWY90qHIb0azKmwjeyHI8WlqKuHW1F0epPqSjqevL6CcCEIKc+M941q?=
 =?us-ascii?q?SAT80mmRg4pW7q3Evzw7MNaokc/yIisfxPljSekplkqcNZ1U215kCy47f5Sw?=
 =?us-ascii?q?VE7acC+psrpUke+VdPQRILjGWMEb/vmwsMZAyZzlk5k5J6G+XrGN9bfpbSf4?=
 =?us-ascii?q?XCfL4/8PYD7yytXahD22O4UDBSl7ETA42++RxfxeQks9z2n0BDBwVeNYApUh?=
 =?us-ascii?q?NlCd2xjppsoIJ/t8TMsCYTWW+1mhV+AgsWDyvipBzYBIgyGs+w6iX8xp/OdD?=
 =?us-ascii?q?CbnnTp+pTkhmw86z9JLfjMmgY3rmRnfSwhiYKUdgTkLLYQuq9C3lIPU2dAp5?=
 =?us-ascii?q?xVahBjdTSSvJhFVFrisnUx5mYq+N+L9RmdeUBW7eNvA514E9nS5h+J0rSfre?=
 =?us-ascii?q?SUtUmFc54gHcpeO6+Y04jCUPwlDuR+/OqndU5VNhHAlUFp+ZpGwd48DxZn6U?=
 =?us-ascii?q?3zn3FFtFp8+aORYrzUx0vHAdetuscB8+HyZWTQRvrtGxUL1cKY2N9H4n41RH?=
 =?us-ascii?q?0kUAYWO5hiyZ8+easUN2Khn83j4gMS2raeRAhzXXL0gG4bu000TLjK0Odscd?=
 =?us-ascii?q?pxaPZDHwqUMRLYZc1OQbQs5/fGUu65+gnOf0l2FLBKblIYkPsVvVZ6yQMfr/?=
 =?us-ascii?q?ucZGDvOtmwjDI1q/XynjTq2jGR6iB9iqpSqbWzF40b2KKGz/m7vA25Y5fWY7?=
 =?us-ascii?q?DRoKR6mGXmmpoIJeXVR+H3wFmSriIieoAOVcgYccmiMIt4D8AgFWdm4jmVMq?=
 =?us-ascii?q?MtyNo959E76tLnXf5tofEagGO604hn30WLk9xJwe9sLRf37SDz9HgRI2mVfg?=
 =?us-ascii?q?qJOj3aYY+kzRHsnBpFYUpc70sasVp7nZKIEVHlV00lguvm/0xvLkOwCqPTfa?=
 =?us-ascii?q?3jG9AiYuQqo4OK///dtePuEZQqUTn4nanIC5dpkp2G1LBzQ06vFpIx0PIavB?=
 =?us-ascii?q?6EPsHkFeFbw6YHM0d2eH8GhwZN43YniqGcUwHTXqLyh2q2NUtoAp7TMLW/7S?=
 =?us-ascii?q?4uducxlqKmwM69K2YxW2t3MZmo4xS2lz8hh34JRtw1Pok/4ffVkv/oJU5RUk?=
 =?us-ascii?q?XTfa34KC4ZK54MkcfYt1CguVl8QpYE5AyOBL5Z9s+25cJokkoZlAh3UhuFdl?=
 =?us-ascii?q?dTq+GjILecs+KQ8MB3m0tAObjpkz9AhPQcG5GYUWh/+7FJXbcYU2BIb/BDKc?=
 =?us-ascii?q?zY9PV9SQPQ44LLCZ7KPCzxfX9K1ZPFG/lXhKFYC62LfvZ3Himz+6U+xwEW+h?=
 =?us-ascii?q?A11D1J4YtrJPPM6/PUd/6UCPEOOYpeuIFzqscupOaAEuf8JYF3Hz7sfm58rH?=
 =?us-ascii?q?Shfq93dtjeufjlCXRNqpu5RjrhRlSKATkRrX6YOOwg7gr1mC3lbegeamXQ9v?=
 =?us-ascii?q?9gB49+TuCpGUnC7fYmiUkzIo4u4uU+GNlHbZvNRVOzuZElG8f4rbmbDTPCrC?=
 =?us-ascii?q?xkiipyDYhzINmZAXCXRMcvrIFyB8h0HKLtZ+qaXnZaBJM1e5mmBlcrJ8Aeg1?=
 =?us-ascii?q?hZTa1z6MPme3YFK9VhPwBtEX71FlY+xu/CUfp6t5RVNv5c0Rylxgi8naTrNc?=
 =?us-ascii?q?qJGyMaZrV8ovCcxnsuXin56ZURss9jEKc5LKNwDXVWouUfUdsibcyMqRI016?=
 =?us-ascii?q?RU8io8g/l687ek07wxUyXWyVt3MKbUXbskw4OvdQE+iSowSch/zoP8Sn6Mzr?=
 =?us-ascii?q?hXdtjUAPzSKbKJJe78oeFVmOsluEO2KGeqdOt6pMj7IYUU3ts+Gl+qiy7/Ry?=
 =?us-ascii?q?JV6h4MEtK8IvNTgKKLYJGenhEufwCOqUwjx77MVQaVJOrhIme1Z2ugrRREu2?=
 =?us-ascii?q?PbK1/z89b2PvXKyuv437EVzQqhSMiHcAsj4AUdlpitIYENVGu8fALzMejta5?=
 =?us-ascii?q?Fr4nqg3zpKaXOr+xlBxOzZsqhrMZTbIa7bkweAAIjM/f+SyrIwHI9UKcUhhS?=
 =?us-ascii?q?k/xfG3W92C4zX4EjBuozYv4zWyJkNYw99CN8SbTcDJOOOzBp9pqPn81qM83x?=
 =?us-ascii?q?V7+A9iUKIflGTXyH/Ma81n5Dq4Pqo6sUhwtQhX5FVd5MCgtyz7gJMh+8sYYL?=
 =?us-ascii?q?smXSFQs8hbItf+Z18OG8sL4ISXuk3EfkCT0L7h6Htkg9RN9q+wPrK/RgMVo5?=
 =?us-ascii?q?qw+xM/6l42sRY/+mpFMfUt9HyoV3KJGs0LC/eHkOdTCqYH6uF+IcylI+veve?=
 =?us-ascii?q?2n4gSX43d90/xcc+pHBWOJzgtGdP6CpXuu4HQktGQykCwZcOBvX5a8Wt2GG0?=
 =?us-ascii?q?YJ/VQzhmPBxzhQ/kYsIv1RONFZ4XwdwED5jc5Z1pmjD+l06ZUr+B1ml?=
X-IronPort-AV: E=Sophos;i="5.93,367,1654574400"; 
   d="scan'208";a="81940470"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dpj3hj812ExuI3BD6cv9yuCILuhG9GspE6xNyyzKs/SLZH9z50JjWRJhZ9+v86OfAgX727HDP+rH89eZlKk7t2ou5Y99Xb8StayxWu5DNq/JdCkNUyfBunerN4vAv08NkZWagvJw4cslPXNtT5h9alPA4kZ6B1WGvuxP9GvmCplMJOm8UvQMXp/G1JtJrjwOA7tmevY9eJ4PzwVSpgLVIdUGW0cFGQAaauB8QwvrQxGUWBnkWGx10vJ4jCNEu/peIau0/5oDNMM1LEDIsf3kNiLYDEnLcREp6m0dhDK2CdB2HVBexwpsUbCiWVRba4JtrPsyr/opJ0LsBJC9XHtXLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XD1vnsET9GCzUIm+dVy3YUvbCvc18cl3H4qHAJcprc0=;
 b=Rd+XcpEL7SN7KDxohmXk4lTctWNEdy3CBgMiYOuMGhQpnvNZdmeA7zbZdT8efo1OQ5IbEew+nJHlnDWv11+zvzXZztAH7xayqfMwWyYkoVlAnNRDhdxXOvjBfp3s5SZlpJrlNTBbL+VMkJb+hHk3Tfj4ScF0WIh1y6PdvhudqUkz8sIQkO/AJtg6dDcCKUawBhlD5c8I6eWAoH8I1jU+yQkidjUdWZCiJtata+RU05klmFPqgl64/hozXmsQiDUaD5z9GG7AWhoBtWeSgzTWAiJ3JKVtNxRWVkhvbxD1zKFRlDQBLQjCzTMGB0Ob7BRDisUVqZXVmwZP6Rc9B65fuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XD1vnsET9GCzUIm+dVy3YUvbCvc18cl3H4qHAJcprc0=;
 b=pwSD8Fv1+aiveTCjIonXp2F47jUcbIZHY3bTwmrOvewRJsVkvMZKOL4O7yODx2gF2GyhW2ztPrnSdu5vlTh6BRWT911YS8GQYl219dj6oier0JpcylQJDUi23I4L9k5yJtBARdekcRPGnuPSz+cQLv2ze8GWB3qXSfEt5lnFB4s=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 12:26:52 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
Message-ID: <YzwKbAIJzOdDhS+N@MacBook-Air-de-Roger.local>
References: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
X-ClientProxiedBy: FR0P281CA0146.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::20) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DS7PR03MB5448:EE_
X-MS-Office365-Filtering-Correlation-Id: f2263941-41ea-4d27-b362-08daa5f2f6fb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	R2oIa0ne8pcJfXLoEE83j+qIiVntUKU9elYues3SG84I8nq1oDJm/Su6Nlxjm4AJwo1jpVwCDRr2P4Opbqe3+d8m9fA8CkqEznmphVpAhzwVNcsRNWb0ewZa2K78Jbwxy+3nhOB3APEID75Wb1h6vOfUMEXfs4RF7aJJ052z0fIJ/mUlnW6datvr+8ug6/VtZxmo6PoGvBgDS21/dpSAcecwaj/N8dZwDqZ3VHnJ4Egevcd74ciLmhOdukNYmhdG5YIIUhEdGDJNf7i38RsYkVLBop6DCpxtgF9b+lDfkE+9ufS2fdthYfVCCx4XtR7Z2u+taOorDvLqoN/y/dPvQXvK2yIIGYpXH4ZJkAJuZZknC+rCTXEpJI1DY9Y4WH3YqouODzCR3VH4N3ivMCh429cFbcq8s5qCb07NDEsY41zerL17ecgtBlZs9f/46yNjd0bBY+u+QB/EpVW86JJXWC0orklFTNktxFhhjEciM02ccxtEhC2vlkCdwJxg0yDr8Ly02LlAe53P+oVaV/JSv4q30ySNQe6uLTJWEQuk1tC1eJANfIGKe7AnKLWi7wPzD7XzkqQXvb7trD7RUYg4FILQGzhdc69CUzpyp9sbm7VSkU253TdHmVaYcIl1gBW5y4Gi24NTDUa5KCXpI+JgyYsqxyEkrRzEvy/94NDOhBN8/CXEKh+ZKgPS6eba7WUooCEKsBJWv5vvLtQosLZTfdCaIHqG62+AHDgy5X7MITh49hs4ieLTRCWQg/YfFJEni9GO48zE2hYKhCUgtopb0A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199015)(6486002)(478600001)(6666004)(6506007)(66556008)(66476007)(8676002)(4326008)(66946007)(85182001)(6916009)(316002)(54906003)(82960400001)(38100700002)(186003)(6512007)(26005)(9686003)(83380400001)(86362001)(5660300002)(41300700001)(2906002)(8936002)(4744005)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NHhIMEhlbmZudmZ2R1VCdzdwc3RVekZHdWdweG1nb2hseTU5Zm02RGliMkd1?=
 =?utf-8?B?M3ZKcFVYaWJuVHVZR0pNblA0c1ZiWDJQNlhsUVpwUkgrbFdTbmRXekhiRDRI?=
 =?utf-8?B?UEdZaE55bU5mVXVDVGVwU0VqY1RwVFoxanpNWU1RVjVXMnlzUzgzNTVkRnE3?=
 =?utf-8?B?QWpEbTRiOFFQOE1aN0hQOWcwc2lMcmUvYnR0N242eHNqRVFmVGtRRzJTS2xn?=
 =?utf-8?B?czVSc3M0QXJoWHB6d2lFakpuMXNQdHBNOThYaURUNjg0UHJKVE9HYXNDZGRM?=
 =?utf-8?B?OHFuK0UzWll0REVWU2dWN01tdlc3NVFGUTh4RHlza2RvWSs4OThoczU1TUY3?=
 =?utf-8?B?ZmRmTk0rVExwS3MxSW93dkloQTFxaXI2Q1FQZ3ZOQmtaMkVZY2tPeTdDVnE5?=
 =?utf-8?B?dmNuL0xVckVoM2pLWG01aUpDN2RqUTUzVlc0TVl6dHBrdG12RXBaNGFqNkVB?=
 =?utf-8?B?THBENU9LUnVUdWMvK1dJTzlSRlc2ais4azNkNGlBMFc5dXBzaXRaYWVPMGg2?=
 =?utf-8?B?bTNnbU5OaDZBWkNJVWIwWU1uVFhVYTJaZ0l4SjZXWUs2Zkg0TDBoVGx5OU5B?=
 =?utf-8?B?Z2QzQUM1RUZ6NW1zenVVZmd6YnpJN3YrcGRFZnBJWVVHV2JHeXpML0sxbDQ3?=
 =?utf-8?B?ZjVlTHZHdWkxbEoyRTBzT253L2VMM3JSK0tkVm5DMUhVTWROK1E5VVFEUmNt?=
 =?utf-8?B?YWMrZ3N6ZW1xdWZHV0NWVEd4RzdaYURlbjlxcVZZcm5VUTEwdm9PcjMrRFZF?=
 =?utf-8?B?clYwU0pvMCtxdGRiWERrVHdoNTR0Q2wrdzBQNGlEcnpJamlNempibDZyNDRV?=
 =?utf-8?B?SlQxTEZlc3hhM0Mzb3oyK3cvUHgxRm43UnJ4TFVtR0thQjd6bmdSRXA2VnlB?=
 =?utf-8?B?QWZNOWVPaWtRNVVlcGZINENVYkFObHJ2KzZkSE5ZdHZJZzFiUERjMGtYWmh4?=
 =?utf-8?B?WUM3VHBPRlJmQjVQMVRySlBJakJ5d3BjSzFEL0JGclF2QnJ2WTNFdkFVY1BJ?=
 =?utf-8?B?eitOaTFqSW91TnY2NmxTN3JLRmxaZE5RMlA0b3U4cjlXdi9SWld6VE5qWWFJ?=
 =?utf-8?B?TFJzczcrNkd1TWowbzRZTnNGTUFhcDNWajZHTGR1TlVvV2JIbXp1aExLZGZB?=
 =?utf-8?B?U3ppdVVPNVpDRkFRbzZocklCa2pyM1dTelgwejBYMENnZ1dVZ2JBMDNRd2Q3?=
 =?utf-8?B?a05GR2Fsa3ZNdmpUTzZVV2lhU2cwNU5IdnY2eG92Vks4NlBtNGo3UllFN0h2?=
 =?utf-8?B?NmMrbjNpZ1hVcERuVDgzL0ZueWRZa1FVdkVDdGwyeGZ3RU9ST0puYXVyR3NK?=
 =?utf-8?B?U3p5RXhiMjUrdHZNRzIrc1dEaWgySENwcFFFZEgzNm5paXRFMHJNNExweXhm?=
 =?utf-8?B?SXphNlFoekJyM01ObXk4VXNQU0FsMHZ3d1JVNHNTRlFpS0o3bi82UUNFeEpJ?=
 =?utf-8?B?SmdTQXFqeHNHcnF4U2had0oyTlJZUFJzNzdvaG9saThhc3pycmtyRmhXS1ZK?=
 =?utf-8?B?dTd1OS8yaUlmRFdZbC9TcmFtc1N0NWFIVXRrVElpNHBnbCtIeis0M3IwNVFm?=
 =?utf-8?B?bEErWEEvTVl1WTBpcktWaXlpVTJVTEtqK0RJcCtGbUJpTHB3QzFBUUpUYVRZ?=
 =?utf-8?B?c0RLejYyMXNLNkZwTklOL1pzYmpkRlRBbzhQSDJQdm1na3Q5OGFnejFsUHg2?=
 =?utf-8?B?a3FmdUsvbXpwcGFDVnNCeGtHRTNZT3dTaTM2dWtGY1picE91RXZIK3o0MHFY?=
 =?utf-8?B?UFRDUmo2Rmk2ZmlFMkRicGlVaThVRUlwUjFoVFJNMml1alV2dHZRUTBlVWxB?=
 =?utf-8?B?OEhEK1VvVXFodDVhNjFROWVWVFc0OC9JM25JWVU3bnhPcWtPTmo0ZkhHWVBC?=
 =?utf-8?B?Nm9XdXVIYks1WFZjZjVKNDkrZXhseVBoSENRajg5cGRma21lTmpneHNjMk1v?=
 =?utf-8?B?M1pacW45aW10MW5rS3QrMDJRQzVHV2w5bnZQcXJXWlFsU2hpSkV0THRRMkp1?=
 =?utf-8?B?YzFJOHhzdHJTVXhNTUkyaFAyQS9vV3JaRjBqYzNKQXM4UHo3OGRNd1lxVzBJ?=
 =?utf-8?B?RGluVGQ1MlUzNHkyODMyZk9GZ1UzL1lQbVBXN2pyMzR5UlpuSGlSSHVNaDhX?=
 =?utf-8?B?V1V0TXVWZUNUVVZTcE42WFE1RzZmeE1INEpiYWxqUU1kSlEwTWhYaGJYbTJZ?=
 =?utf-8?B?elE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2263941-41ea-4d27-b362-08daa5f2f6fb
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:26:57.2126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OoEh69yZ4xHl+qAHXZPkagREM7CHRT8HEu5sjq8ivUCi/F2KdSjpLY5IGiZane8XpxxtFNDIaS8Hg6LNBy8cXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5448

On Tue, Oct 04, 2022 at 12:13:49PM +0200, Jan Beulich wrote:
> As it turns out populate_memnodemap() so far "relied" on
> extract_lsb_from_nodes() setting memnodemapsize one too high in edge
> cases. Correct the issue there as well, by changing "epdx" to be an
> inclusive PDX and adjusting the respective relational operators.
> 
> While there also limit the scope of both related variables.
> 
> Fixes: b1f4b45d02ca ("x86/NUMA: correct off-by-1 in node map size calculation")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:38:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:38:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415378.659936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offJn-0004vq-Fz; Tue, 04 Oct 2022 10:38:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415378.659936; Tue, 04 Oct 2022 10:38:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offJn-0004vj-DD; Tue, 04 Oct 2022 10:38:31 +0000
Received: by outflank-mailman (input) for mailman id 415378;
 Tue, 04 Oct 2022 10:38:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1offJl-0004vc-Uf
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:38:30 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id add9523b-43d0-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 12:38:28 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 06:38:23 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6091.namprd03.prod.outlook.com (2603:10b6:408:11c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 10:38:23 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:38:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: add9523b-43d0-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664879906;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Y8fvgDeeqM22JGqYI8DrMQ0QztqjRYjUuYOc8w7oh78=;
  b=Jgjv6xtl+785EEPovx6/rC5WCX5CcnPHHsgUhCbSLj19n+M6boP/3LT8
   3Fzq3A2gm45whoW4kFaTiCNrNbvVpT9gyzVrkmGuay9MdoqprsPJrnT4x
   OpI/FHDkhB3lRZzRRCnyz46EiCFGSm5469M0zCyUfU95E5a7nleIkdlbP
   g=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 81940977
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ALqBL2KPXOWFJ4J3vrXNrnJZSyEGnJRDYMC5Ae?=
 =?us-ascii?q?xGJyHHeKWpRNYcDrMm2QDDCkKbTWXua21jbuHuAQz0ke00KzI+dpJEvOOBVE?=
 =?us-ascii?q?mRPbh97t9r6cUfyeUPzHnKaejJW8QDgsTH/oe4x4zukpFQelCOLjCbDSROX0?=
 =?us-ascii?q?i7yRpo+PX5d4x/iMG0RDxQ3LJXfMiKuHW1N0epPiCCrevLahTuUeA+F7+BYl?=
 =?us-ascii?q?r8Xq0miRg5pxpj+T6U7xi7RaPaTIeXnurLgSb80cL08RZWnozRrw9nfjjClS?=
 =?us-ascii?q?p7m9YeyWMrRcwpfjEAZ82IQfwfnEzRK0ThLAwWN4mjfh5ADaweceLhSewybT?=
 =?us-ascii?q?7Z9axOdsYViNCJnHVPP2ZjEi6qaVeMAJp57WpzPZoiZpTO3iI40rk4iL1CRN?=
 =?us-ascii?q?smuScf5gToqWhAJuUtZF0qSOtZAuf+0h0/cCnU4OVomadjklRI2CUy05Rl01?=
 =?us-ascii?q?gjXc9P3xoWdZTebAIhg7xEv5eAQpMim1gugiNBSReSOn+BRVEiY7L3GZIr3R?=
 =?us-ascii?q?DgQTfL5xRJT8Bs/X/j3A9oepMPNFP7OEtsVeXIH+NP4LM3Yv4sIwGqBu5u9/?=
 =?us-ascii?q?QY4pUksK9SifM+uGi3s3Vhl8kwqb/lnQ8RwyptIUPb0fluYLKDiinUaZ7Uqk?=
 =?us-ascii?q?vTI6buTu7oZ+KwPWZ6L9atwtA65Vu63wmKzpZ0C94e9k+WuNoEj+5MjGdDO3?=
 =?us-ascii?q?3Sxz8FWDa2wR/ezEoFY4YQqPbMn7hpnsZubaL01s1nPUvXSE3K1tpOvgaEIe?=
 =?us-ascii?q?X+wKOSOwxqRdR38Zl7CMsIUBRfg4w3Y+I98iyvVvr+2zAlTjEmYiqNT+D0Vv?=
 =?us-ascii?q?0DhCPflpeOeoL6EdDAP9zc11ZFdvqOnSvGyRxyoU/RTxwW2RehW3YC+RMs68?=
 =?us-ascii?q?PY5CzBBfoQK41PvzpXVxoYX8Y0pxBU85lAUyIceR0wCPeBLNEzArmbUUQoJl?=
 =?us-ascii?q?bmOwAQ3jrvZIKkfN8w+gDbNoech5E2Vbj8TSsIiRopdJM+WbjAc63F1ZRb/W?=
 =?us-ascii?q?aAKry/4+a0m0uGOpeh1YbltU+UNQnN2mUl19I1d4aVefkDwwwUwzbB+0y9Rl?=
 =?us-ascii?q?BDNOOvNhc19bgCqv7uH1epSeg+VtUv60jlG7rDa6m7HPavI0LDMka/hEYBa7?=
 =?us-ascii?q?J+bI/5f7SN5hltJ9PC13q9UBfe123xHekQs5CzJeLJZ6IZfiCu34ezE8lwho?=
 =?us-ascii?q?uGpZzKovlzhLr7M4RmMNMjWbTIoysg1j+m6/kB6d8S0o/JMAO+mEWxNDAOj5?=
 =?us-ascii?q?JpiKYfbuZOVZMpo8mX+DZGn1Ap7vQuiFRHYJchI3cCTGU64jjxS0QadS26bz?=
 =?us-ascii?q?sE73ikwCfYemgjnNCwxwZi7Pwgt0fv+bdXGf42uQFXwySIiHoAbRV0BWa2cQ?=
 =?us-ascii?q?S4fL3zyf6dy8z/tfEc5s2QEqjc2gJovh6HmGP9M9vMsR/VLJ5blEIeOYsUNb?=
 =?us-ascii?q?1/qsh41omnTkOI2R261B6axyyeEQVJw/txk/sDJcR+n+35W5norVnKPfp2FI?=
 =?us-ascii?q?/3hPFWjK9YvHD8up7rpdaqJfx3ulowRVQc/MGAwp5MuWrFoyA75JjilzdDn4?=
 =?us-ascii?q?ofw7tuRrv19Wwi2iFonz8zhWZRV/hMrbC5wSxvY31nzwlEePbKVmjN+afJuB?=
 =?us-ascii?q?UsA/ds+3AQK7Z/yvH9tpbfLgsYR+X/vc3XN8ha6WFMFu76bHTlsEA6VOaalj?=
 =?us-ascii?q?6G7OH4+JqseZJ/VKG1UbEwKheqSYml2VXLZ0k+DKZGtrYWvBYMnxcSZ8uIsP?=
 =?us-ascii?q?0PoLqrjNR8txvYS5PTYEZ9KTpVc3+d2Ai32G6pzQVcPu3RqTnPRI8OnFHH/A?=
 =?us-ascii?q?XtkPFjk2hmgyb++fs8kjJqmCN4dSxvxlUNsojn8kxQKqzKaMc8RWLExJzi+o?=
 =?us-ascii?q?910PTrUgjQlGNplE/Zg93NyWooGmH2KqDTfklGUTHymcw9C1KlFc4UlgiBWj?=
 =?us-ascii?q?cK0S9ImXQ1Q3dZt7Tzg0GsMJnRKizWpklgi0CcoQiHYzdMECDN5hSJjQGqCc?=
 =?us-ascii?q?/elvgTrKvXdPCjGGLBOKahTEbZ6q4Z729pUoVFLLpeH7TXXKRSeGsjAPX3TO?=
 =?us-ascii?q?/JD1XUEvkR3U73uAPIZe/SJjFNcMkj2oJ8icuNi8MsC0ZbMfR4je5qWUjj3a?=
 =?us-ascii?q?F6WVFgcFvxA/orQXlIkymBgUHCwoMvEKiLh5DZYO0FdWHQ276PsqiKJjnTJZ?=
 =?us-ascii?q?VUle3uzDUVdCqbCKeWrgK8+3RXvgKJdpsXmCF7wUVutG/RGL4y03sk03dWAF?=
 =?us-ascii?q?JZXthAYpG5NQco2QplBU0TnIvmQxXK4pgSD+s/piuXbg02o+WBf0sySu0bMb?=
 =?us-ascii?q?6CKrdLKpHex7LhRn6l8ck7e1JxOt563Ou9X8EBmsDrAg/68YHh6REndBxuaS?=
 =?us-ascii?q?QfR9FpWCEcUcHkAbIQmYUyRQj0XOgQ9vh4D32FhaAeqJB0JYyAcVbdnx3fkD?=
 =?us-ascii?q?2jT84p/GjOyqEIzYsyRqU7WhvfHS2i/Z0aEehNqJaBi8/0NRq87ujKCHKAnm?=
 =?us-ascii?q?Q1OBZ3rAzBfyWPpWHOPr8MJiSNaSsYvTKUZUexxOFzTsUdbEUS+Ss12vp5bw?=
 =?us-ascii?q?LAEOGiZ/DCmuxMmS/y4QTT9L9fiRXbaBW0km/lyi7UQ1z/7+c4EEkR+J0tQ1?=
 =?us-ascii?q?iXt1+o26RiQRR+kFzIehaaFy1Csy1/1SvCqCEGIHbL1YOYqf3TTmBo1wBgrE?=
 =?us-ascii?q?9tiTOdylM9O/NdtUpUGn87ZNMqMlkrICENSoBNfysNZXz9uudlaxMARYZo=3?=
 =?us-ascii?q?D?=
X-IronPort-AV: E=Sophos;i="5.93,367,1654574400"; 
   d="scan'208";a="81940977"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KmMJI82xP7svNC12G/xbAgpPv+yvsG5ZBHPcY25Qlj7WsNmI+9vfsUujkYkAd3XSy6hWv9hcbufuAngqS+MhlhhEn9Vq1DY5fPkSpAFO6AayQjIr7DJMgjx2coazWsWtqR8SGaRUtHWIX29l2LaGRoQjCFx0J5J+ET3uL54ePyjYMCXYIDRymQW4BF7GEZvll7VQWUjdPmnW/w1nJKGRVvLsVPpJAVbw88siIXHe1vIk5VaXxb3NwFMuGxglGCb9gUxo1lPIaztA0BWF0W7P7gaXgKautMsojzlHGqM0Keubc4ftuILi+S23ha8uJfJB7pprVZ1hTQgncckgWhHLjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pTIzh/cGfSG7Jmx5cM7EaLBMIQDJ9e6y/xf0WHT4DwM=;
 b=ftOVBiqOd0ZmWTYwVgC79V+jtSF7IgVEjYJ07fcjkIwy4/mdJSI/nsEaBwhuevv6bFoDHU2dKFkX3Ptvkd7/gfpmhF/cOqT1Bt6M/R/OGFpdVYYviNR60RdaF8HEY7IJc6gkh9wzBJ4sLRAw/16gL84aUT5EdDHk1TZgsEB16/KOUZhhXu1Hgv4bU0VQiDhUfcf9u/D8MrfMKzUL/OKGg+vtIshbEyg15CmnIARUTtG7M3a1rzYe2hnMgF1cfXK+bIbDcXenNB68vX7o9G2i480l7ILU7VkSJ80nXd1UjwmZy/xnIrCvW70AST7LwPrIgNPf0yJMgMqQtvEmaGXRnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pTIzh/cGfSG7Jmx5cM7EaLBMIQDJ9e6y/xf0WHT4DwM=;
 b=kE8+AUW0kDgTwwjUE1ngTRW+M8te0aGBuVFaLgqMEWKsVI5YAs8dPL92AWIzyUypJ+L6FmYS/DlDjIvGWOVE0PNdNmJNFc6fSQy2lUzeILvoixJpduGWxdTZoyKS0/abq+tUO/YeBL1zhlr87Tr2/NDBu8O0Hvca3/32EOgR1iE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 12:38:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Message-ID: <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
X-ClientProxiedBy: LO4P123CA0561.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:33b::10) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6091:EE_
X-MS-Office365-Filtering-Correlation-Id: afa0a8d8-1838-48ef-0c3b-08daa5f48fc4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	M/InS5t0FLI3EC6+dIJ3SOJFW6h5sUEYGQk4v2Eu+RTRyyrf4x+XtsZ5LtkR6tsGFX/nabsTXtNtvyrJdZI6Na1ed24VOVZbWthQn0gwDM4WkA5N9ZllC2543PiIgd/yygCdwliXBG8FkX3s/naHHFfbvhnJ5vaUdcT7hh7nVNjvQ2JBF/E2iuQu2kaJ7QFYu86hfwgvz9l86a/FODfaH7zGt3fYCiabrSQ2feIj+bBPJie/oa0MJ0xHKpNj8cq7O2TVW0oPM64dCSuwwWrkZAbAzXI9CdUoKpj2SyDhg/RQw0TI2m719mI+1QRprFy8vWmHUxwHfN6tgV5xwq3XN2EcV3/CETjnKYO7N5/gliV0qN0FFofUKkZJ7vRNXsKBJA9b3EhP2EaMG3jBdDGsbQSh7hp00K29KgRRvgM3jntgnIChks3t4lR8uapGgeifIvfo53grbcNV97/8OCcoi4oAHFWcIwxF1j12NAafxn/+AEQzYjPRev0+sdSPKRWl04CoWCCzKWIBhVnTJlEEpPQXlC7KFc/FGGH+8An+APoti9TpmR+yBgGuYoUIN1FIfBqWVHBfXCBsEoVx/TZUZ0WSopk/8vh6bAIU+xWokIGxCUw6IkMrh/iA0avCskHSNbTDUhZFE5b+sDDZ100O+xpFE/MfpgnqYkL/3lOyUrK0a9GjMopJWGQzEqcmmgsyIN6WfmFOO9T85YJhrOFcyw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(451199015)(316002)(66476007)(82960400001)(478600001)(8676002)(66556008)(4326008)(38100700002)(186003)(6486002)(66946007)(6506007)(53546011)(6666004)(6512007)(9686003)(6916009)(54906003)(26005)(85182001)(83380400001)(86362001)(8936002)(5660300002)(2906002)(41300700001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHJFZk9kZ0pJVlpiQzl0NHYxamZGWkZHMnR1ZTVQaE10QktJd2t3ZHo3ZDFD?=
 =?utf-8?B?cGVSRVZsSU1Yb3BoOFcvMU1Pdis3RlRPOTR5ektONkJaUFJHNzJLcXJnQllN?=
 =?utf-8?B?Wnk5YnYrWWF3U05SRE9mUzd3bmptalRVNExsNmFnTHJwOU8yWXB4N2FnMFFX?=
 =?utf-8?B?S2VlQWhnUlRxR1gvT1pIZURFaGp4SlhRb3VaVUdUVyt6UTIwOGVPeEY4clJy?=
 =?utf-8?B?aU1ISUFBVjZhRzBOa2VJLzdpOXhlU2NuQ3g0blZZbjljRllaZ1NjRnpOS3BP?=
 =?utf-8?B?U0FsNVBUSWJxMlBpV0xQMjhXYWllV0wxdnJsK0JwVzV3SklhSWdVQUloQ0NX?=
 =?utf-8?B?WFBQM2lzK0hGay9kazE3N01uclozKzdOVHZYVWlxaXRicmNtVUpLMTFzblZG?=
 =?utf-8?B?UURFclpoVWZGcXRHSmFrVUVtL3NZNUhhOXc2dDlBNzA1Z0YvNTBEclgrcHkx?=
 =?utf-8?B?ZHkwMWlvVnUzdzVZL2lIMmNiK3hNWVJCSkJHY0RtOWFEeHFqK1YrYytMOFV4?=
 =?utf-8?B?KzhDL1ljdTJnMFY2OWFFdFpPSWlCTXdIVkswby9uVzZTZkxHYld0Uk1yak5k?=
 =?utf-8?B?Zm9YSFJGRDBsWjB1VnQrUkZQcitOcHZhVkxKNEhDUGZuVitjd01QNThhUjNQ?=
 =?utf-8?B?TE1EdjE5RmRhc3hoTDVmeGc5aExqV05mZWlqTUVlVGY0VE5jV1V5bHduYzdY?=
 =?utf-8?B?KzZyT1I2d0Q2d2FhRFUxb0pKbkhYQ0REb0liSVZJalJwTlhpQi9XZVNQdlFj?=
 =?utf-8?B?cmJtYkJiOG9uRWF0YS9HeUdOQTBLbnlqZDV2V294SUhTY1J4ZUVaTkFsSjZZ?=
 =?utf-8?B?NmxqN0tuUjFLSzgyWjNtUjk1WWk1bDgrZHZTUzFwbUt0K0UxTFBpMStHTEIw?=
 =?utf-8?B?WE5DMnZDMFVXb0ZWKzNUZkY2aG9tMjZaZ1N4ZUN1ODJPTUx6SS9kdG1WMDRC?=
 =?utf-8?B?UUQ2V285ajFsSGhCaE5lR0JxdjZOYmRpWHp4NkxBNnlGWjVRcHZCZ3huWHZE?=
 =?utf-8?B?LzRoc1dZWUdza2pvZm5QQjh1NlN4VlRtVmlYTTlRVEJqL2NJa2hGVjRyTjhj?=
 =?utf-8?B?dHo3dWd5bG5ycjhkOHBBcVJFcjgwT2RkWGRzc0NtTDBUN2Zsa0lUQWtRYWZx?=
 =?utf-8?B?SHYzWWY4ZjA1MlhHN1VtR1B4R2NpNTNxcXQwRk1kZmQrTG5ERnZGWm8wQ2Ro?=
 =?utf-8?B?aWxWMi9BckdSc0NEMzZjaUkzWDZad3czSGdjS0JCK1BwWTdNeDAyTnU4OEdi?=
 =?utf-8?B?YkRYR2wvUVEvVEJWY2FnTkw5d0tqRC9EM0xXQXU2TVNkRzhUTzk5V2xMNnVm?=
 =?utf-8?B?c2hkaFdaZi9jU09Wbk0ybVFOb0hTQlZkMXVRL2ZhWTVJMmJFTWRtRk02QzFx?=
 =?utf-8?B?elRKdDhrWkxFaFE2NDc5ZTlOWkdNaHRURVhNWkhJSDBHRm4zNU8vVVowbFhW?=
 =?utf-8?B?N2NTL0xOTWNvRFF4d05vUFFYbkZqV21CNURPR0JwcnFrQVNLb2h5Q1RZRzVR?=
 =?utf-8?B?Vk5qMjQrWE9iSnZYZjRHcUFYbzBWbzJIZVJXcTdDS25MK0E2YVVuQno0M2hG?=
 =?utf-8?B?MmJYNXNXV2c2d2ZtNS9NQllhN3FQb3ZCRXRycG4zZFp4eXBCZ3VMdGU3bm5J?=
 =?utf-8?B?TmVEL1k1VHI5Vmt4aEkxUUJOcjlHZzZLWFg4Q0pkS05Hd2NRQlJiR3BMc2hs?=
 =?utf-8?B?ZlZ1akZzc2R1NktqR1RuenllL0FhYUc2eTUwbVRkUG1ucmxTWGJRYVRPWFps?=
 =?utf-8?B?aExSeVRLUHVkVFV2VGJML3ZONE10eTNSNHB4b0N1dytwajVhdXVDenRMcFRC?=
 =?utf-8?B?cE9QdzhPZG9xL1laU0w3MlNhV0xrNUNiQStudURGa0ZoajRXaURna0JIbXFs?=
 =?utf-8?B?OTJ1WnBQRGRKQVZpbkxGdkZBVDBYWFlaQ0I0YnQ1aFAvakJtL0ExVVVNR01H?=
 =?utf-8?B?VDhmdVpXaVNEWlBSQkt5ZndkVlNMZjNUTGx5ZVJWK0NmaXNEZWp5dDU4OHlw?=
 =?utf-8?B?NkRiL0lrL3A3NFozbjdIZFdVUHpGWVJZWHRpVjR6Vzk0WHZsb1Z5ZUQ2bXVZ?=
 =?utf-8?B?NHlQUER4MitZeVZiU1R2V0wxRXd1RkFqZ2xUc09ZdmpaMUZaM05xRE02UkRB?=
 =?utf-8?B?SjJRelkxbnI3WmpJUWlJTkxPcUdVZDFsTFdnR2w5c0phM3lLUTUxMHJTcnBL?=
 =?utf-8?B?R3c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afa0a8d8-1838-48ef-0c3b-08daa5f48fc4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:38:23.1283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wAWAdDo9S2+zh6UoQ+PHcvjoVpNyf7Dm6TXMWsEmwpzwVHmmpATNYI0FZPISMX1H4JdiPgGAgQHzfYeFVha3lg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6091

On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
> On 04.10.2022 11:33, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
> >> On 30.09.2022 16:28, Roger Pau Monné wrote:
> >>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
> >>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >>>> higher priority than the type of the range. To avoid accessing memory at
> >>>> runtime which was re-used for other purposes, make
> >>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >>>> E820_ACPI memory there and hence that type's handling can be left alone.
> >>>
> >>> What about dom0?  Should it be translated to E820_RESERVED so that
> >>> dom0 doesn't try to use it either?
> >>
> >> I'm afraid I don't understand the questions. Not the least because I
> >> think "it" can't really mean "dom0" from the earlier sentence.
> > 
> > Sorry, let me try again:
> > 
> > The memory map provided to dom0 will contain E820_ACPI entries for
> > memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
> > map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
> > overwriting the data needed for runtime services?
> 
> How would Dom0 go about doing so? It has no control over what we hand
> to the page allocator - it can only free pages which were actually
> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
> DomIO - Dom0 can map and access them, but it cannot free them.

Maybe I'm very confused, but what about dom0 overwriting the data
there, won't it cause issues to runtime services?

If the memory is reported in the memory map provided to dom0 as
E820_ACPI dom0 is free to reclaim the region for it's own usage.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:40:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:40:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415387.659948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offLW-0006Lm-01; Tue, 04 Oct 2022 10:40:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415387.659948; Tue, 04 Oct 2022 10:40:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offLV-0006Lf-TQ; Tue, 04 Oct 2022 10:40:17 +0000
Received: by outflank-mailman (input) for mailman id 415387;
 Tue, 04 Oct 2022 10:40:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1offLU-0006LZ-12
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:40:16 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20069.outbound.protection.outlook.com [40.107.2.69])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id edefd1ba-43d0-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 12:40:14 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8649.eurprd04.prod.outlook.com (2603:10a6:20b:43c::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 10:40:12 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:40:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edefd1ba-43d0-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B6v1xTPhIOBE4+aHCinAvbNInNYfx5DhEz/IxlzakKYX9H89aG6xgRGztNfsMXIFtgY+NA7naJYWRbvMUYs3/9ZUQM0sE6CntksAiWsqemQlXgazWKarFqXNAu3x5UGZHgZOMf4qNBn5lgBQBP35J5P+X7F/dgdK9dqmsaeW7O8emu29ztKEtjh4Wh1HUBuIdPGxB09Sv0JFLcvhhIOG0LvGyzaiO7kxIUCSzISS2bv0fIv6svDg/Dr3Cx1GRtBa5FfrqYm0//2ROCXodO6/0O9DYUU6/oXyg89Adcz1bm36hn3VwsHBg0+UPZT3UTKJF/rGdEmoEa13SFPA0ndyZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GUMUb4rDVIPGGhMJuXs1xXw3TYdDQJYRwxQy55Zh8MM=;
 b=Xt4qafiKxuhBvaa4TCH84HOP2kPulE0NDb/Wskoh0uVtd/pVDpo0A5njh82LLeVDWSc2MuaAnRwqWNpwSN34nI/BhWGZ67W67ASefsPGpJxPPa78c+bdsbx7D7Np0PUYmK2nFg7B8Wn47x/UTYh2crZRwkR6mumdSCp9IfU074Jon7KsXNxViPaKLw9b901XVxWYbtzl2f0+tLB6cU9hFUPzk0M3+LBzbnTZk70jZI4xRz8HsbfGUm2yuFYAqEWfZDAMZc8qLOLl1wpbTD4bkVDnVQInxYB7Ys7OGPuZMk0Ol9exHrg6bYrwWnI3vO2ITk4rqW72FaqeC8NAXsv2fA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GUMUb4rDVIPGGhMJuXs1xXw3TYdDQJYRwxQy55Zh8MM=;
 b=cABjS7F4u+uGhfGFl5Q+pqwX+HnquwaCjsPkmRU95fN/R5mAhZyeWVZA3hb7zcXQIfItgAltbxKL77+FFc6D1lZJUychUMOPG5e6NNe1QNw/+Nn1SXE1j8U43m87feyvykKtGVICeVCnFanMAdOUh3NEp2jQkaUsmA3Tn3uKrsYAbBnR2FgmxapifnOaP1Bjj0QkKnMHNOmR7DfbuEWXfJ3E/cSavroSf/aJXqAjOajo+kmgvWbFj3nuTjVjaJcs4EwV+30BRLE8UYAlkONqPnnwPx75IkZZdJZuS4GMzc2jix1tahRkw4g7WO7/ykYoFTxh6rPH5rtwprNYNZUmKg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
Date: Tue, 4 Oct 2022 12:40:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P191CA0051.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:7f::28) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8649:EE_
X-MS-Office365-Filtering-Correlation-Id: dfe18a0e-886c-49e4-4b7e-08daa5f4d11b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lgIlyLBmzl3TLsxfTXWSAE81VtfihUctRTxDqNRtEHeS3rD97eDKW9K7jzC9VP3sqfX5LTWPz7AnJOPzQB+2mNpCAmKavlM+MtENSs1BvzF+iL46A0Wrfrj/aco5hivTj3Q1j4BLGMZEtSGWmMvtTlOins+xygMAq0+teRT86iQOcooGbZre4TZzxEYNei+JNEHzCKYNDoZOrA9FNHzf619kA4t2nnWsVl1ZrNr3+LaCAgZacWL6EfKaBjT0UNpN/eMtM6nCwAivtuH/8XwEcnV/Wzs9S8q0/YrB1bnIpS2zgQSOvtdVV6rKSIGjDtMtzfdMQf+v1CyMuzUFeyq0p0Bm/BO/5CcWEFHIGHaK1MO/8kisNPEOwiLlYKJ2Q5mKdhJFjkCLwQXxYu+xl9LKeMfVrQz2fMIAXtDHVRFsJPt/388OE7j51Ya9qq9obhowJF6HWBkuony2zPTzg4VzunIs+t2YKAkob8dSILuQt22Ma64e6fIo8ET8KAz0feHmBZdFbNmksH+GDqmp2gJiphGId0Gxvcdw8BKQZDkzDjsbH6OEw8eRUfHkE35YBswULt7hm2CVHOUwRxGGasj3hll4eqXNLNqhsFH7NqnBEpaCyUo9aIO1uF9yJ0uH4MU2tcxG0ybWiQOKbNm3rFkkComNza/lsAemUvynL3bjosorKJd01h6RnYXi3ORd9UqtGV6gPyS0AamctVmlZN9B0bsa53c79YBOr067Xyuo/1/E44l4oGiDwBMpHaztOJvKwJWatWyN+iD+j/T9TcD5F+7TZhUS/BFk2e/JhvoByLE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(346002)(39860400002)(136003)(451199015)(66476007)(66556008)(66946007)(26005)(4326008)(8676002)(6512007)(83380400001)(186003)(86362001)(478600001)(6916009)(6486002)(54906003)(38100700002)(316002)(2616005)(31696002)(36756003)(8936002)(31686004)(5660300002)(41300700001)(2906002)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d0owcnV3d3dOV0NmY1VSaWpwWDJrK1dyc0o1cEo3b1BJZzJ2eGQyamh1cy9y?=
 =?utf-8?B?Z0ZvN215QVlpVXBjRlowSlY1bTJjTEtwRjVvOFdLSk1MR0ZYUTQ5YkQ4dDZJ?=
 =?utf-8?B?TTdKZ1g3aXE4Q2x3SmhDK0oxaXpCSTFHdWVBQTQ0dGRuSExHUWFvQU9xWDBn?=
 =?utf-8?B?dm5rVysweWl0djN3QUFmZ2xJcDlVUlgrT3ZsTExZZ0ExMlJSVkxJcVVZdTFy?=
 =?utf-8?B?aDVBZ3J5cWJmMERaeFcyQTBLNksrOUVzUm1Zc042V2V5N0R0cld5UnIreFRk?=
 =?utf-8?B?RnM4bXVRZVE0clB0S0dCbEtob1I3T2lSSW9GNVJqTEZXUk1iQTJ3eHBkZVRJ?=
 =?utf-8?B?a0tZaC84ZDVYSkN3aFIvTndNb1lFamhZTExPVTNIUWxjL1ZSMVViRFp6cGtE?=
 =?utf-8?B?ZjJmZ2FUc2dCNWgraFJkOHJYTS9mdlpITzVlaTYrMFRoeEk2bGs2eWxEWGJM?=
 =?utf-8?B?QkRxSGF3TXBGVTdmaGhFcTl1aGFSMTVIbTBQT05yQTltVUFseVVMT3B4UmRQ?=
 =?utf-8?B?NmdsWFhwWmxIanlqOEwvaHFQWDBKNVRKTS9rUGg2Nm5TRU5wYU1uT2lUekZ3?=
 =?utf-8?B?QkZMVTEwcFNEbDR6YmcrczVRT1E4cVBrZnI2d05FVjBocCtodTV6cUs4N3oy?=
 =?utf-8?B?b0RUOVIxYkorVEQyWmFhYkVzdnp1Ykh3c1VXMnhXb3hIeXUvb2pkc2Ezdm9S?=
 =?utf-8?B?WVk5LzZ6T2h2VkhUei9pQ0hPdTF0eUxsU0F0MG9XNDd0MVNHVjB0SUpnKzNh?=
 =?utf-8?B?ODlaQXFDVFdPakJyakljRlFQVTl2ZngxV0FkSFRsT2JIQ29pRkZ2dUx4dTRa?=
 =?utf-8?B?RUtFMDV1V1VBU1FETkk2bzVTdHhEbzgydXhMUGxVbTFoSm0xRkpzc1k2ZUlK?=
 =?utf-8?B?TG5hYjA2TjZiaUFBTFpmRnlmTUNlUjMvMnFjeVhISXBZbjQxZVlhbklsRkVw?=
 =?utf-8?B?T0owb2dnY2w5cnBHcnE0RmI2eTRFMDlhYTZGbkNnei9kL3NMTUVFaDBMR2RX?=
 =?utf-8?B?WisxaFFDeGdVenQrLzZJb1JGdy9zWkJNVWlkUzVmVFJwQ3FZM1pVa0ZzUGx5?=
 =?utf-8?B?QjJFcnVGWXhHa3pZUFFaT2lueU1aTDlGRnd3RitRMXZLM1JpSStudnF4c1lJ?=
 =?utf-8?B?aHV2V0diL0JJWDZnUHB0NE9JNlQ0a0xXTnFQQWF5SUpVSUQ3U0lCa0RFaHMx?=
 =?utf-8?B?bUs4UWFYR09PM1ZnS2VhZ01iQ3dNdjJ6MU1FOUJxb1l5d09LTnVnT2ozMDYy?=
 =?utf-8?B?MjhXQlhIS2hWbXFscGhmRFBzZ2xLZm55TDVoU3FvdHprVkVDRU0zRkFRRkZl?=
 =?utf-8?B?eUlVQ0NiNytiS3RuOTAvSU9TQTI1Zk1KWHFtTVAxcEpUc2NCblh3RnJib0Ra?=
 =?utf-8?B?Rk1TRkh3VVhJTm9TZFc4S3RHOEhjTlBGbUhDdmk0MlBjYk01bzMvbjBxcktK?=
 =?utf-8?B?dWkvQk1IaU5YVElockJoVDVCMTFYb09udDBqTVJsbnFBam1vME8xYkh4ektj?=
 =?utf-8?B?Z2hEaHdUbFdFVjV5dFkxd01LbzBvZHlHenh0V3dGSXB3cXFNYWJOQnJ1YTQr?=
 =?utf-8?B?Y21tL04wNngyZGFLSzh6MXI3ZmNiWFNKZmV0bkVrQ3MwTWZkQy9aMnh6YzNh?=
 =?utf-8?B?TCszMkJxOUV4bmN1TWhxSjB4Y2FOcko3WnR0NkFRR1E4RWMzYWtvcWhvajFW?=
 =?utf-8?B?RDhvRE5aWUh5dW9JY0NTSlM1Y0hWNC9LcjEyeUp0OXA4c0FBTWZ4YWQyMysz?=
 =?utf-8?B?enc0RE9BWDlEWHEybUgwMjdFS1hDekJkdTdML2IyQlV1OXpMeE0wbVhMelFy?=
 =?utf-8?B?d0FrdjhaRDJ4a3h3Mm0rL2tNQ2JhREVHMGxHSUNYOXlYSFIrREhGeUc0TFEw?=
 =?utf-8?B?WmdxRDg1NXA4Y294OUlGOVo3czlsVDgvbzBsUTN2eVhCcnpFMkdCU0VqRFlE?=
 =?utf-8?B?Z1ZkZURVdXdkaDM0bERjbUh2SGxpOVZHL0dXZXpnNWk4dkVOMzhoQ3FGalZl?=
 =?utf-8?B?NWwwUHhjcFBUT0VoSkpmSWs4OWdlS1RJOXFobUR3OWRCaXdGTEhva0pFaWhx?=
 =?utf-8?B?TGRGUWo4Z3NZazVCL21jZGlEdjdnb0VLS3pGajJlc3lTbHV2dDRoTklwVGM4?=
 =?utf-8?Q?O3mLX5De4fJXh8ZIqMUGJtW9Y?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfe18a0e-886c-49e4-4b7e-08daa5f4d11b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:40:12.6582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vmXtiPBGQ7rg/tYfQr5qRhgpofhymHvjLI3+Ckh0hURLBtFBJc0EReyfY0yg59N1lVIcwdS5f+61yCeeYVfaOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8649

On 04.10.2022 11:27, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
>> On 30.09.2022 16:17, Roger Pau Monne wrote:
>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
>>> devices used by EFI.
>>>
>>> The current parsing of the EFI memory map was translating
>>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
>>> x86.  This is an issue because device MMIO regions (BARs) should not
>>> be positioned on reserved regions.  Any BARs positioned on non-hole
>>> areas of the memory map will cause is_memory_hole() to return false,
>>> which would then cause memory decoding to be disabled for such device.
>>> This leads to EFI firmware malfunctions when using runtime services.
>>>
>>> The system under which this was observed has:
>>>
>>> EFI memory map:
>>> [...]
>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
>>> [...]
>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
>>>
>>> The device behind this BAR is:
>>>
>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
>>> 	Subsystem: Super Micro Computer Inc Device 091c
>>> 	Flags: fast devsel
>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
>>>
>>> For the record, the symptom observed in that machine was a hard freeze
>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
>>>
>>> Fix by not adding regions with type EfiMemoryMappedIO or
>>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
>>> be positioned there.
>>>
>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> In the best case this is moving us from one way of being wrong to another:
>> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
>> legitimately covered by a EfiMemoryMappedIO region in the first place,
>> which I'm not sure is actually permitted - iirc just like E820_RESERVED
>> may not be used for BARs, this memory type also may not be), whereas with
>> your change we would no longer report non-BAR MMIO space (chipset specific
>> ranges for example) as reserved. In fact I think the example you provide
>> is at least partly due to bogus firmware behavior: The BAR is put in space
>> normally used for firmware specific memory (MMIO) ranges. I think firmware
>> should either assign the BAR differently or exclude the range from the
>> memory map.
> 
> Hm, I'm not sure the example is bogus, how would firmware request a BAR
> to be mapped for run time services to access it otherwise if it's not
> using EfiMemoryMappedIO?
> 
> Not adding the BAR to the memory map in any way would mean the OS is
> free to not map it for runtime services to access.

My view is that BARs should not be marked for runtime services use. Doing
so requires awareness of the driver inside the OS, which I don't think
one can expect. If firmware needs to make use of a device in a system, it
ought to properly hide it from the OS. Note how the potential sharing of
an RTC requires special provisions in the spec, mandating driver awareness.

Having a BAR expressed in the memory map also contradicts the ability of
an OS to relocate all BARs of all devices, if necessary.

>> I guess instead we want to handle the example you give by a firmware quirk
>> workaround.
> 
> I'm unconvinced we need a quirk for this. AFAICT such usage of
> EfiMemoryMappedIO doesn't go against the UEFI spec, and hence we need
> to handle it without requiring specific firmware quirks.
> 
>>> ---
>>> I don't understand the definition of EfiMemoryMappedIOPortSpace:
>>>
>>> "System memory-mapped IO region that is used to translate memory
>>> cycles to IO cycles by the processor."
>>
>> That's something (only?) IA-64 used, where kind of as a "replacement" for
>> x86 I/O port accesses equivalents thereof were provided (iirc 4 ports
>> per page) via MMIO accesses. It is this compatibility MMIO space which is
>> marked this way. Such ranges should never be seen on (current) x86.
> 
> I've heard the Arm guys speak about something similar.
> 
> There's a clarification note in newer versions of the UEFI spec:
> 
> "Note: There is only one region of type EfiMemoryMappedIoPortSpace
> defined in the architecture for Itanium-based platforms. As a result,
> there should be one and only one region of type
> EfiMemoryMappedIoPortSpace in the EFI memory map of an Itanium-based
> platform."
> 
>>> But given its name I would assume it's also likely used to mark ranges
>>> in use by PCI device BARs.
>>>
>>> It would also be interesting to forward this information to dom0, so
>>> it doesn't attempt to move the BARs of this device(s) around, or else
>>> issues will arise.
>>
>> None of this is device specific. There's simply (typically) one MMIO
>> range covering the entire 64k or I/O port space.
> 
> So this translation region won't be in a BAR of a host bridge for
> example?

I have to admit that I don't recall at which layer the conversion happens.
I also didn't think (host) bridges would typically have BARs. Bridges (but
iirc not host bridges) have bridge windows, but that's different.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:44:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:44:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415396.659958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offPS-0006yR-Gr; Tue, 04 Oct 2022 10:44:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415396.659958; Tue, 04 Oct 2022 10:44:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offPS-0006yK-E5; Tue, 04 Oct 2022 10:44:22 +0000
Received: by outflank-mailman (input) for mailman id 415396;
 Tue, 04 Oct 2022 10:44:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1offPR-0006yE-Lw
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:44:21 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150089.outbound.protection.outlook.com [40.107.15.89])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8089e659-43d1-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 12:44:20 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7707.eurprd04.prod.outlook.com (2603:10a6:10:1f4::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 10:44:18 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:44:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8089e659-43d1-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Mewwoihf5zDBteWoJ9g0jYcuULYKfr/fdmQNB/fPc4Xua5f8dWZS8zPZj7FkW6FDvYAu/HqCBnwdvJ6r9jFZI7Ob5hxl+MsDMUMwJrIgjIj1U84DFjOMO0xUIFORtHayjmfQh6+clsthQ1kZPvSgIhB0IhQ9hDcWHTN8+DFpUjXLzxXF154FVMJYIwGxBTviuqztbxhrrrZkg3Ehmusawb5vjvbb8E52sCus52ka8XlwjhRoRbkpQkmRuDp69b1LuZyK9qrPV8cqzVJjjKjOobNhP23GCtydCq6RoYlBnIp964CbKqofbyEvxkdND//nnengWINHiIl0m8iGjpu0qA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t4YBV0PSm3u2tu9a6DxVobOOdTzsoMYWl/RRPvnN0sI=;
 b=RQWBaYLybo6OZtc7VT/oIC35nxdL7cap+fGN6yVnhJHNAoFNOKklEshlkuhVtt1WtwU1t1ZMGF9GTvGg0vT8QlgnIEzeghTDXsrmBbrc8AImDzc3K6L7yevl51+zOAToxsWHt0ycgGCpa9Vtu44vVIT6BC5Bb0xe00ZSq5CbHy7bD0k5u3EcR5sG3L5SW3Fc2aIkOshXQr52ITc4gs4dnxN5Gpz7kWqLCzOFx9PNysT2J+voi17T+IchitOvOnEWS2dY06/VOFE8sb5/CyVo8uXQaqR9tHxzxAgBHGUVa98FSMfGCe1RFTNH73Xl0ocFUXDXVD6bUAQIiVOjAKqkeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t4YBV0PSm3u2tu9a6DxVobOOdTzsoMYWl/RRPvnN0sI=;
 b=hVRIPJl1tZatmswVtxhtmGpqu4RAA1t8FyRtxnusEap90d94W9O9qEQ0n0/7imsusI5G2Rv7xyT1hH4s27iPWRWEHvDvtxv/XxBSZZn5c+VFo65orZzX7DtNnpOCML2zuY7pAbmPYdrx7XSF8BQhS5rqUODI+1XPBeEsbOLnCJH/iTfya3QYzQfCZd2Y25ErJO/zL7EVFfH9N0XpZiRIa0f/sCvJENEqQUvDU0g0BbEO/KeJvp6UIP2Dv8W/LJtrtaN0CISrtdoJN+YRh62HBQnW8R/XzcFm3A+427HF54UfHP37NukhtinvUteNws6EoYrCySnxjUT7SueDlLepPQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
Date: Tue, 4 Oct 2022 12:44:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR06CA0333.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7707:EE_
X-MS-Office365-Filtering-Correlation-Id: fc781da6-23ce-4d55-ff09-08daa5f563c2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bJyrXp+4vcjF00zlbMQUm7OT6lf/SKNEcszB9AP08YjvplmZLet+HxkhvxXU7SqJjXB4DiyX3o1hxc/RkKcYF7csbHIIbuX0BnM/rLMfmejCwGeuOR/VQOHB/Q4IiNDf/rtoKAcjw2w4rdXkFOo+GOX+odeCGE6lZMpeeYiOQ7jMseDlAobKM0QdT2aOMj3D133w9mmLDPT75NZ6o2NqlXTHbXplpNs1yps9IbiFHo0KO7NL+awg3MxKaNQWDH1Usz5h42eSHPKMuthJgmp0UTtk/hLwc5grK6PKQd/Td/oSnKfr8SrstsQXR+ASLLQ+BBSVhxvEc3CI42bqom7YkxoDurl2rtq8lKnnu/MFeiGFipqdu70nOl6HWn44sOqXjTZ5lLHb0hbW1dx0yfZNtyNl06NwgeIQVZvRaxC+GUq9YDFJ/V8XchkwKLhDfLfWO2YeIR4Fk8kMpZNUaVou30/bBU1Rhae/LpN68C5Y9QROSaUiEasXLhTGWI6C9cLROemQrgkAOcTEOevFYuVyVhhQhEaLwBSy5mt1XM4Gq2FYRGc4uNO5gwlBKmf1FfyMfJB7yjYjho7XXZrCkG+drYvGd1KJwFSYdIiTZzSZXg1e9p5EL1zSSYkcqN2XTp7SMuRFWGj2IrM4ZVS47NZZi7CKVqsFRXAyfLhZf66meO22ut2CklN0nqnmukLenJNGtVAvw/Etn58QvvEHOid5VCe2wIdzgwwtkyoGzyZENPQ+7pGEVVvXghwK1tnTN6Mf2/R4YzGdgeXMQ57n8MqB8UiQF8LwfV6dpMVd/ETS/0s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199015)(31686004)(6486002)(478600001)(36756003)(316002)(2616005)(186003)(8936002)(2906002)(5660300002)(4326008)(8676002)(66476007)(66946007)(66556008)(53546011)(54906003)(6916009)(26005)(38100700002)(6506007)(83380400001)(6512007)(86362001)(41300700001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z09TMVQwaVNsMWxmVDkySEVlaGpCSG5aVW9scno4WVltMm4xMmdhc2VkMC9p?=
 =?utf-8?B?UVZoOFJjZHBxK1gzazlPLzUveEJmT3kwZ3hTL2xONy9KOVF2ZW1mUThML3U2?=
 =?utf-8?B?VDlDU2xwUjN4dVpvai9CQ2dGRG8yK1Nsa1Y0WldiREMzVkxURUl0NWFmdXhE?=
 =?utf-8?B?MFk3WmVqZC9aQ3Arbmt3YjBVOTN4bjNFdi8xMkVkbi9qM0ZkeVlPUVQ2TFg4?=
 =?utf-8?B?ZTQ4QUU0VXpnSkZ6ZkF5MGxCU2Y4UFdWTmNnTG8zYXdiK0RoVG5Ra3crNVNZ?=
 =?utf-8?B?MFZLM0gzRkxRR1lvSTRmU0NONld6WkJFOHFPRXJhclkvOEFaRHJIUWlWRHpa?=
 =?utf-8?B?N3o5ZjM2UHRRM0hNdWRkMlZyZjEvcVBCclZ3YlFGV0pOZ016RG5KNDljK3Qr?=
 =?utf-8?B?MHQydVNLZVlMM0ZFVVBCaTJvWWxwdlhHVURPRndtcDhSYnZIaGRrcUQ5d0FS?=
 =?utf-8?B?KzBDVHZDOXJ0SDdwMXZoRDZYUzBjVTNsMkJHcDlrWjFWTkM5NURJanIzVmN0?=
 =?utf-8?B?SEVQd004dlFlSnhIRmlXcy8rSjNjN0pIQ3BURW1aRGZXMk42TkxnekZTSFkz?=
 =?utf-8?B?YXMxeTd5eDFSMEd0d3llVTBwbkRkM0hzOTl4MDdBdHdGc2NrV2p1N1lCdmRm?=
 =?utf-8?B?ZFh1TjI3NHhOWWdjU25rUnBhdjhkRksyajdGdmFVOHVDRTBONmhESENCL2tn?=
 =?utf-8?B?TEFsNEZrWndWY3pRWEJpWDVBK2pvNE4yOFhLaHVxWEdaODlzNHd2NnVhWlAw?=
 =?utf-8?B?R1MvUG9DS01tVDRQVUk2MUNDa1JlWGFXdyt4TkxicWJUY3ozM29qNDhGOG5D?=
 =?utf-8?B?Z3l2S3RjRWlXaHF6a1htTVlMTnViMXpkZzdSdHBzRkZwWk40WjNLR1luUFBE?=
 =?utf-8?B?Ui9DL1hYdmEySmNBSUMzUjA0ZUdFTDBidUNQbkZLZHdEeTJMeFdDLzgyVUwy?=
 =?utf-8?B?alBYTnVzUG93blhxcXFqMkNHVHMxSW9sWkhEdmtVSm8rNmdYam1sMTlhcE4z?=
 =?utf-8?B?S2IyVzFpVXltUER3NXc3U1ZYTzJtS3lrL3NjK0FKOTdQUlpoQndKcWVPcHZJ?=
 =?utf-8?B?ejBHWWxMWHZqUU5INkpFMmdsdEl5VVdvN2EzMzlBMUFEeFRjRXRYVExCbU1l?=
 =?utf-8?B?b3J3ZjY4aS9NSDA5cmx0dGV0MnNBRjNQelVNYjBzR2FTQnZSS0hvb2VUd3lx?=
 =?utf-8?B?VmtxaGVJeDJUN3d2aFZOR0VkTWoxTTljNWhMYVRMWFJhT3FvR251N1lBRDRW?=
 =?utf-8?B?SHlzN2pXOE55S1hna3YvWUZOUTZ5eWdweHhyK0dNUGFscG5qbkEralAyelpS?=
 =?utf-8?B?RHZsWW1XYmsweWVYdEF2N2RCek1MY0x6cWtoWGhhbnVPbzdxOVZwMTRnMEdn?=
 =?utf-8?B?MEMzQWNqa1h3WkdvOUg4Y3M3U2dlQ1A4ZFk3WjE1cTU3QVByVU9GMSt2ZGxS?=
 =?utf-8?B?dWpnbXpJcDJTQzFFc2Z3N3F0QjNHS0VQREFHbCsyR2kzOUVUcTZGaGtyYmp2?=
 =?utf-8?B?TmtwOXgxM0puSUpOL3ZVS0pLd3hLellGZXA2YjgwK3VWeForY0Q3dkkrZHRm?=
 =?utf-8?B?WlZrUml0ZjNST1pyY0dIWjlzVWhVdmFRS2p3RGlGSXpzbWJxT3FNL09yaDFP?=
 =?utf-8?B?SHUyTnE5Z0p1blBmM3BxeVl3TXE3U1VhTDVEMFFnZTNBaGFqblFpTUZMQjVj?=
 =?utf-8?B?ZVI4OVlaNEcrYlplbUpta1Iwc002amlzWDlMMU0ybFpJY0NDWUdwZ0xacnFa?=
 =?utf-8?B?eEo0V2dYa3BDcWZ5WksyYXZmbUIxeUdob1R0UU1vYzNLc3UweFBXdzZNSU9o?=
 =?utf-8?B?bU81bTdBMVA3SEdPOE5INm1jZmR1ZFA2bDdFOE9pNnV5Z3BMdkRIRTAvdStM?=
 =?utf-8?B?Z0xJUVNPOUpaNk1mU0JmanZwdUVtcGdJZGxWTzg5L25oVEJZajNLMWRwNzUw?=
 =?utf-8?B?OGVBVjI0TTlsWkVNRHVsb0diQ0hCMExNdkZtd3kxRzZmZEt3Ym5YN3Baa290?=
 =?utf-8?B?TVkwT3ZZejFUMm83TDhhTHlXU0t6UjRSV2cxM0ZaUlppQXplSmFtNjJjZWYx?=
 =?utf-8?B?SWR6OVBxdFE5N2E1QzFvMUg4L09ha1d5aXhWVlNndVdNT3VlRWJOcXowVno3?=
 =?utf-8?Q?x+kkLynoiupe/t3EZAPIYunDs?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc781da6-23ce-4d55-ff09-08daa5f563c2
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:44:18.7359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s4qwCjzumPU7Ou0N6DFQ9E2UsGXXmTVYF03JkwZqlAA9NugpgSgvGQf2QARuRWgN9f8q+IJRr6INGIVTchf8Yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7707

On 04.10.2022 12:38, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
>> On 04.10.2022 11:33, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>> runtime which was re-used for other purposes, make
>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>
>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>>> dom0 doesn't try to use it either?
>>>>
>>>> I'm afraid I don't understand the questions. Not the least because I
>>>> think "it" can't really mean "dom0" from the earlier sentence.
>>>
>>> Sorry, let me try again:
>>>
>>> The memory map provided to dom0 will contain E820_ACPI entries for
>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>>> overwriting the data needed for runtime services?
>>
>> How would Dom0 go about doing so? It has no control over what we hand
>> to the page allocator - it can only free pages which were actually
>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
>> DomIO - Dom0 can map and access them, but it cannot free them.
> 
> Maybe I'm very confused, but what about dom0 overwriting the data
> there, won't it cause issues to runtime services?

If it overwrites it, of course there are going to be issues. Just like
there are going to be problems from anything else Dom0 does wrong.

> If the memory is reported in the memory map provided to dom0 as
> E820_ACPI dom0 is free to reclaim the region for it's own usage.

Could you outline to me how such a "reclaim" process would look like?
For the range to become ordinary RAM, Xen needs to be involved. But
there's no hypercall allowing Dom0 to free a page which wasn't
allocated to it. And the Dom0 kernel simply re-using the range as if
it was RAM is flawed - it would break the latest once Dom0 would try
to balloon out such a page.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:49:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:49:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415403.659969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offUe-0007dU-35; Tue, 04 Oct 2022 10:49:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415403.659969; Tue, 04 Oct 2022 10:49:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offUe-0007dN-0T; Tue, 04 Oct 2022 10:49:44 +0000
Received: by outflank-mailman (input) for mailman id 415403;
 Tue, 04 Oct 2022 10:49:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=02wi=2F=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1offUd-0007dH-3y
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:49:43 +0000
Received: from ppsw-30.srv.uis.cam.ac.uk (ppsw-30.srv.uis.cam.ac.uk
 [131.111.8.130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3f83ac6d-43d2-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 12:49:41 +0200 (CEST)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:38408)
 by ppsw-30.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1offUV-000oi0-J2 (Exim 4.96) (return-path <amc96@srcf.net>);
 Tue, 04 Oct 2022 11:49:35 +0100
Received: from [10.80.2.8] (default-46-102-197-194.interdsl.co.uk
 [46.102.197.194]) (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 9DF331FC0D;
 Tue,  4 Oct 2022 11:49:35 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f83ac6d-43d2-11ed-9377-c1cf23e5d27e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <4f55fc1b-30b0-c5bf-bfec-bb237b8c9379@srcf.net>
Date: Tue, 4 Oct 2022 11:49:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
In-Reply-To: <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 04/10/2022 11:23, Jan Beulich wrote:
> On 04.10.2022 11:33, Roger Pau Monné wrote:
>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>> runtime which was re-used for other purposes, make
>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>> dom0 doesn't try to use it either?
>>> I'm afraid I don't understand the questions. Not the least because I
>>> think "it" can't really mean "dom0" from the earlier sentence.
>> Sorry, let me try again:
>>
>> The memory map provided to dom0 will contain E820_ACPI entries for
>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>> overwriting the data needed for runtime services?
> How would Dom0 go about doing so?

Zeroing the memory and putting it into its own heap.

You seem to be presuming that some unwritten and unenforced rules exist.

Once dom0 has booted, Xen cannot safety touch any ACPI reclaimable
range.  It doesn't go wrong in practice because OSes don't actually
reclaim the reclaimable ranges (which is also why Xen HVM guests don't
explode either.)

~Andrew


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:54:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:54:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415414.659981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offZA-0000hy-QF; Tue, 04 Oct 2022 10:54:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415414.659981; Tue, 04 Oct 2022 10:54:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offZA-0000hr-M1; Tue, 04 Oct 2022 10:54:24 +0000
Received: by outflank-mailman (input) for mailman id 415414;
 Tue, 04 Oct 2022 10:54:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1offZ9-0000he-Oe
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:54:23 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e6a64730-43d2-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 12:54:22 +0200 (CEST)
Received: from mail-bn1nam07lp2042.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 06:54:10 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6428.namprd03.prod.outlook.com (2603:10b6:303:123::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Tue, 4 Oct
 2022 10:54:08 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:54:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e6a64730-43d2-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664880862;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Ylt5OtFnLWdrLLv8DhqDaCJzVv/746TlSl1qmvWampU=;
  b=WGkPDpr/yO4GgvYUQ7gsRgaB2ZMFF76h1gFcQwPwZt3RlgCZFedU+dMy
   Gp3CuYybxh8lQ3Rf2LT0We3nJDq5YYANv8roLuQUaifbRUFT5kCy4ZetJ
   1HnluTRk8EppNLFpWTMDG66Lw0m9QC2RKz6MjanioNCNxmM+tCtLHmS2R
   I=;
X-IronPort-RemoteIP: 104.47.51.42
X-IronPort-MID: 81052410
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:PwISlqB8aP4CghVW/6Piw5YqxClBgxIJ4kV8jS/XYbTApGwhhTYEn
 zYZXmqBPqvZY2X8LdFyaNngp05U7cDcz9RrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8vWo4ow/jb8kk25Kyu4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2lvMtMkxu10XlhX/
 NM5DxosahO+rcGplefTpulE3qzPLeHNFaZH4DRK62icCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAB7g7PzUY0yzG7IAhZyr/iPcCTYtWXbc5UglyZt
 iTN+GGR7hQyZIXHlGDZqyrEaunnhib4QIw0LbKD6e92pwC19FI4JDJMSg7uyRW+ogvkMz5FE
 GQW8Cczqak59GSwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQ10
 neZktWvAiZg2JWXVHac+7G8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdBzb0x
 DybqTkksL8ah8ULyqaT8EjOhnSnoZ2hZgQ4/BnNV2SpqAZwfpe4ZpeA4ELeq/1HKe6xblSHp
 mlCpMGY48gHF5TLnyuIKNjhB5ms7veBdTfa2FhmGsF+8yz3oyL5O4dN/Dt5OUFldN4efiPka
 1PSvgUX44JPOHytbul8ZIfZ59kW8JUM3O/NDpj8BueiqLArHONb1EmCvXKt4l0=
IronPort-HdrOrdr: A9a23:ly0GUqmShBB+3on9RBdqlx0sM6DpDfO3imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM
 tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq
 Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 D4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR8Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqXneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3GlpT1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYzhDc5tAB2nhk3izyhSKITGZAVyIv7GeDlJhiWt6UkYoJgjpHFoh/D2nR87heAAotd/lq
 b5259T5cFzp/8tHNxA7dg6MLqK40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd
 L6IRhliVI=
X-IronPort-AV: E=Sophos;i="5.93,367,1654574400"; 
   d="scan'208";a="81052410"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VqN/Q2c/vvH1tVF8xg/81UhuK3NX1RkyCmfRam19UDANLciyhcadT7MoPwuAcS8RUfsa4aTVzBN7gMtSE4b5+Trwtwn1hq4yUrjMIyXprNoNnuqrS5hdwd2kI+dIGgMXzE+FwUG+qumj1V7BkoRa30YBHmy1v5KqffBEHHWbWHC35gokJe3EeGzBXipgodhz0xibgnkeqe++YKMYAS2Y6AklMZA/mJJlIoAdumQwqyPWeMqtZhRu1bcFlUqaqGpQLfmHzv5uxDKANbZrbCf34L6M90A7+6bkb0edkoVgFH9Dyl3sSvo/Qb268KVlOOxDoIrn69t7gLwOKmDr0JeZvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=myCsOPLLwvskPzUEyXFnb7Ryw7+J9JKMiPDJIwkI0tE=;
 b=QREvQib2I3DRbmKvh/U9KtXt7CVM6g69xf/HkpDEuixvcao+wdAStZYFskIBx9hl1pr8EnZ3BOFfR+bjoF39OU+TB20yXi6Gs3I86dr1jl2Ydf3oUT3W8igxIxINPJdGRXKzWB1a/Y2xtRLah37lCGKYhtXlPJ9/Seno5yB1PxOAVFNRvVMFVyhi2oehzmZbdankYNIeYlVo641ZRckCgBX9gu1X0H19MjbCRxV76JMJ3l3/FEV6UOKmYhFwFS5bhnqrLMH+kpwpD2991pemonTAi7Yv1UjezjlUNe12uHPC5n7g6tVjXYdk7pjZd3zLxvPwzDYEZ6jW5h04RLq0Kw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=myCsOPLLwvskPzUEyXFnb7Ryw7+J9JKMiPDJIwkI0tE=;
 b=iObj3qVF0DUEmrsbB7NGixADsVLgP4gAk9Qs4vXoYXrmSyPVb9YPwj28kvLvdL6T6ceTvEBVLiiOhQVo2sNBr1IZIlXnCy5SrPGOarx84v++xthc9ewcGnrtiyfGysJ0B+m7LaTPRr0EFszpCDteol11wbSesXq7Es9n2jKLMVo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 12:54:02 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Message-ID: <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
X-ClientProxiedBy: LO4P123CA0655.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:316::9) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6428:EE_
X-MS-Office365-Filtering-Correlation-Id: 2020de7e-9dad-4a0e-06dc-08daa5f6c2f9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bL2xfndXbytpPrBpSvqgNUy3I+/gRvyjUO45JFYwBMu+kc8kUefwQ/xJKta1nTx4JmtQuWJB0v3XPO8sWlW4rLiWNroSI5pDMXhkCb1lap7pDjovDb+mwaeBwGuD86g+tn/V1erFYdMdwvqjltPj1NhSIGhV2HsmbVD5Mxlb8r8k/73B7kjPTDWRUu6Hy/Hg0nuoczB0chu6LIghTFGUFUc2oLEG47f4VMWEZ/7B0n2VR/AKFw5WW5J0B2efcHZtnXjpGQknTPs1KyoJ821w+jJSRylrYgg0629eACzkQf+Wk0OpC/br9z6Y7CS+J2Dl3e6OazsVbixzzdRGh8RgIZwDSdvbqv//vEu3+ELtwGdgLjilH9qvxG4pCAYHiaJvn7NxhgJYd1E8Clk52RAUJXtYV5NhzRyX2dIL24Uujglb5si3O17hM3/Yl7Fr17TtWDr+1UZqGCad9sStfEv0F4H39qpWcwkzCDLdnDbOpeXIeTlNFBd1ivSw0wina4CkRJgW3MClnAc4SldAek4hEH8oPA53jkDaF4DTLfoxtw41YS4dVQBjzqFBzxn3ERiZoo74MbCnv0sOK9JI7ui07FM9XbljZ4laO82DCORq2WvnZVBwCDyI/mbFogPFIx+lNyPakVDMp2Mn1rgTWXkY8ETPCn4bSaAyV4I8SXvs9TFV83UYPxypE3v2pNLgrKhVbS/dv3NgDqPzxXRw6cIrCQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(2906002)(4326008)(66556008)(66946007)(8676002)(66476007)(316002)(6916009)(8936002)(82960400001)(6666004)(478600001)(26005)(53546011)(5660300002)(6506007)(9686003)(41300700001)(6512007)(6486002)(38100700002)(186003)(54906003)(83380400001)(86362001)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzIyRTFqa25rR2JmWC8rZm9wcWJuRXZ0a2JtVk5mV3VZQjdHcGQwNXJmckYy?=
 =?utf-8?B?aXZLYUJ5MnFrWXBnWG1TZjJWd2hvNHZ2WWdnRFE0cW9UWjRuM21UbHM3S3B4?=
 =?utf-8?B?a2p6VEY4dW51UHhJQnFCcWpzVmFycDZwdExibFU0eFgrV2pyenhHRE05V3pL?=
 =?utf-8?B?aVFXdUMyU3I4WEdjK2NkNWJselBUSGI3V1I0ckhWZVpzZm4vOTZGaEVMaUli?=
 =?utf-8?B?WXdkYVRDZUFBYURTcDZ3NVBGVkRoaGVYaGNYY2FiZTMrT3EwT1hPb1B6bG1w?=
 =?utf-8?B?NXN5OXVkbHpQYVlDVU50M2swVWZyYjRHQ1lWZnRkbUZwL3pnWTRnQ0lCYTA2?=
 =?utf-8?B?cGJ5QWt2c0hoZ0F1eWZYTW5ZTDNlMlY2MmlnZ213UmY5MmE2NnYxT0VLaWlt?=
 =?utf-8?B?ajNMM0poVVhMVXFVUlhtOFpOY1RJazhWZTEyTGFYU1orLzBLNDV2eHluMzJ2?=
 =?utf-8?B?VUV6cXZJZysrNWdrclkwZmlwcmFKbDNjcmtvU3lDTElzNlpNRlhZWlRRZmRY?=
 =?utf-8?B?SUtnUHhUWml2R0JBaVdxRnoxY2pDRUx6b2VyZ09vSERNYXFpTEYwQTlVMTZx?=
 =?utf-8?B?b01NTnA1Z01rNEF4R2tMclpWdkUyemJIUFRScHd1bTNWZnZITHZGZGpnbFpL?=
 =?utf-8?B?VUY1cVE0cVpSNDBRb0J1cnViSG5mMFgrRXNGei96MDhpb2c4MXRKWTN5VGZI?=
 =?utf-8?B?U1ZzTHIzWVJsWTJBTkgrOEJoTUg4Rm0yMWFFSStXbTA2dUNzdG5qQTBnYmhG?=
 =?utf-8?B?VjFxZWF4STFqZTJ1TytRbjg5V1Zpenh1SDNNd3RCdUJaTEZLbWFNRXRQR2NL?=
 =?utf-8?B?MncvdG43eDMyWkc3RDR2Yi84cmlGTjJ1UE5PaHdUV1NwSEpmcUdCKy84aG92?=
 =?utf-8?B?Q1kwU3BjWGMwSEpqZ0NhNHNjRHpUUjdKWnpvNTEwRHMzYVBSU0FsWFNweXdl?=
 =?utf-8?B?Tm5rUm1kbVRab3FwSURNbElWaTN2K0hudVgvb3JvSWUvSTFXQ1FxeW9LMFkv?=
 =?utf-8?B?ZWdnRmt5SzBhN0JIdWJoSmI2ZmtNcWhickhNN0RXMzRtV0p4VDBobW1GZzlo?=
 =?utf-8?B?TlFkZDVncVpNMW5nVmtpNGlMaGg5Sjl5djBiM1NZNkRrSHJRUzNuUlJHa2V0?=
 =?utf-8?B?RzNlODNqaEYvMkFnRW0yR2hJbElNN0pTVXZocmdEVUJrb0I2aDFMNGtRNjNx?=
 =?utf-8?B?MTB0RE9nekVtdHNReVZrdGh3RzF0eWkzdU9oNUg3R0dtSGNoTmtldjVMVlVn?=
 =?utf-8?B?djkyaTFVcWN2QmZRTU5xMVJySlk5a0RCRXBHUXhzaHA0NG5qWUpVTTZUNUtk?=
 =?utf-8?B?cVpYbzRremxUcGlXL1lCenhOblNwMjczcGNDNTNOKzNibklVOVJmVEppSjFZ?=
 =?utf-8?B?eUNleDRsNzBmU0JlRldFbUZCZWhCOW56bzBrS3lzVDQvTVZLOXgrS05JOHpB?=
 =?utf-8?B?cUltK2FyYjZidU5XajdyWVh3c0hzQjNBVGRDSmxZbGpDTkI2clhhTURtMjdF?=
 =?utf-8?B?OWZqcmRFYWd2RGdKT1pNODcyTG9lMHhGdU1nZUZuMGkvN0swOWErN2I1OFo3?=
 =?utf-8?B?cEE4SVlPV3ptNHFmWFJVL0NXRE1qMFV6bngvTnRhUER4djFpZThZQ3gvdEZ4?=
 =?utf-8?B?TFBBOENuWjhuSjVDM3p6UWZ0R2M1MjVFcm80UW40U2FYWi9wODk0RW1ZanEv?=
 =?utf-8?B?VnJmL0p5S1EyQlhXVVBzWUJQME9oVUdvUEEweHlOZjduVDJxQlAxUTVqUHI5?=
 =?utf-8?B?bXVyeDlsZHh6UFFmSmtJbXp5QnpEU3paQzJOTjhIOEp0NmVTSHY2SWJpNFZq?=
 =?utf-8?B?UkRaWTlGRkdBc3dwa0tLUHp2RFcyTjEvODVMWDZWbGlhWnRSR0F0TUNJZ0oz?=
 =?utf-8?B?aHAyNVdmbWJDOGxzdm1CZlQwb0cxNkRRbXpIQktXcm54c2RVbFdjU0t0eU5P?=
 =?utf-8?B?dkdVWXoxZG1XYjFzWmdhcDJ3SDBKK050RXUrMVJheS96a3FVbzJMYnY3SzJW?=
 =?utf-8?B?bVVIbmNUbFBiMmVaK3V5L1U2N0F5ajhwT0wwWDRSdURIdHl0Q1hqUFpqWkNI?=
 =?utf-8?B?SzNIdmo0UlpzSkYrcWFhaGFEa1ByTi9DbWR5aWVqaUpUS09sU3hrQm96aUtl?=
 =?utf-8?B?YVZNV0ZBS29ZdGgzWVFWbjJ3dmhvVTFFQXQvRGswUkZyWlYydGhRWThDYzl0?=
 =?utf-8?B?bXc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2020de7e-9dad-4a0e-06dc-08daa5f6c2f9
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:54:07.9390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 89hsky6PaUL83Wxg4bUpHbMx2Vskt87suXf1bEnckAAHRyBYEcTMM0P8TiFt6RJ/LGQQ+Ptbx9Jbzos14uNhIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6428

On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
> On 04.10.2022 12:38, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 11:33, Roger Pau Monné wrote:
> >>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
> >>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
> >>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
> >>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >>>>>> higher priority than the type of the range. To avoid accessing memory at
> >>>>>> runtime which was re-used for other purposes, make
> >>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
> >>>>>
> >>>>> What about dom0?  Should it be translated to E820_RESERVED so that
> >>>>> dom0 doesn't try to use it either?
> >>>>
> >>>> I'm afraid I don't understand the questions. Not the least because I
> >>>> think "it" can't really mean "dom0" from the earlier sentence.
> >>>
> >>> Sorry, let me try again:
> >>>
> >>> The memory map provided to dom0 will contain E820_ACPI entries for
> >>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
> >>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
> >>> overwriting the data needed for runtime services?
> >>
> >> How would Dom0 go about doing so? It has no control over what we hand
> >> to the page allocator - it can only free pages which were actually
> >> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
> >> DomIO - Dom0 can map and access them, but it cannot free them.
> > 
> > Maybe I'm very confused, but what about dom0 overwriting the data
> > there, won't it cause issues to runtime services?
> 
> If it overwrites it, of course there are going to be issues. Just like
> there are going to be problems from anything else Dom0 does wrong.

But would dom0 know it's doing something wrong?

The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
know it's required by EFI runtime services, and dom0 could
legitimately overwrite the region once it considers all ACPI parsing
done from it's side.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 10:59:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 10:59:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415422.659991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offdm-0001Jh-C7; Tue, 04 Oct 2022 10:59:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415422.659991; Tue, 04 Oct 2022 10:59:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offdm-0001Ja-9U; Tue, 04 Oct 2022 10:59:10 +0000
Received: by outflank-mailman (input) for mailman id 415422;
 Tue, 04 Oct 2022 10:59:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1offdk-0001JU-OV
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 10:59:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 91609160-43d3-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 12:59:07 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by GV1PR04MB9215.eurprd04.prod.outlook.com (2603:10a6:150:2a::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 10:58:59 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 10:58:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91609160-43d3-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lm7UEi5AOV0xNu1d1eHUbkgN2p5sYUsNZ5D3hGf+138eQ8vKeARfJBu8OWygoOP1QDU7Qrdkf0Cjvt0yXJvSxUj/FYI/eJXvI3QqiYvMR1H7GEiJdkHpDmwDdc2YsWV2pYnEyu+4kehp2v1y+1h/tMGyPWl8jW3g/2sT1Em+D0xnewInRDzGRnCDQ+zyhos7XSx4EyJzsa4/whBAuD1YyZPR86boH+q9QRn7TtDn+eqQDXYfkqKInOBUgQ7x0lMA+to9pHGnWX092rZmzk+UZzFO1yGqHfWeK8d1pV6vPQM8eM0Ma8w6XvRqUahTpbCleJJ/JiHyORFWRq0mgMmeZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C5U+h09P+uAMkkShW0Lxk3PudcKWH0c//pqKniczqKU=;
 b=DBH8DRnENdJzsyPn4wHG3aZumvTX8KiSjiDnD3C0hbBvB4+e9xfEScxBJR5pfjeTT6frQQH/clFO8K5DZhWVqHhQ1GfP0jBUKo4LDMB/2EfBDGoZxPtr8bSuaqZeDi2y1xw1TjHcHdIAy7WOK+PZBsqFeUCN9sNiby+TGLTvollQoDtV3asJSeGnlHk3jueuYJbyoi5prPYABYdtbXqaLbinW28LD9lfWf5DKx8xZYEPYaySWoZ5yOGmFR5brCKnwTUWAunZyb71VUoiIw+ORqHFajfmkLl/xQDhkSh6YobnPoUjQmoMSFklnh1QSLbIFTfYLG4XjbFy1D71Iz6vsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C5U+h09P+uAMkkShW0Lxk3PudcKWH0c//pqKniczqKU=;
 b=Nn7wtYSkMxsgiQ3YwwxnU7kXI29rE6XnUmj5NjIsgtv0LpaFWjlRT067d5HSHAn1keLPYT3WdY+OKNRul9ZMosNQa2AowCdL0MzPvP0UWjmxUqg3L40UQHvC/JR3ifVyO6shqB95zYDILwRrD5ZtRVQqN9dOdgDviqo5o3llQSbk/JLovMYkd7eYx5X55BEFzxE0Cx3gf7mUAmth9nMfnfFAp80cGRnFeIBuTMJjHd83SxgOtYkbpHAsmnBFvLbqJBfUv3Nuj0beacncgPGEX6sXLjC2CJ4Xt4N3QywFvCio6vAtr5TdZLOljHUxZxnBQ9xL2hZToVXM6qgCIDTE4Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a070485a-1eed-420c-552f-16688e89d65f@suse.com>
Date: Tue, 4 Oct 2022 12:58:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2 1/3] xen/pv: allow pmu msr accesses to cause GP
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-2-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221004084335.2838-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0358.eurprd06.prod.outlook.com
 (2603:10a6:20b:466::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9215:EE_
X-MS-Office365-Filtering-Correlation-Id: 4885cf63-47f4-4698-ad58-08daa5f77076
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	24bvkOy2hU/EttfkxavwMpzv71uvGQjC9AcPF2u5BeWeG55JKtKr728v9bYb9h0tw9lGRWXfEtJmYCYJKqKc3c5YU2Ql0h6xzmpsHzL5x0kefWr0/SLd3LoMtmOPi/B3hA2TKy20oNnU+CDLM6AMl2V8AtJP/VbYgpCblpxPIiSvjuXsKnqA+8/+XMEBugS19tCbUoxuruAhLYRzT4C8u5FTyoVsG74q0TudPQ8FiWhQQlbkH6vwZ/v3Ggrxkr5Ek6wMDNoj6c3twX8vef4qCyhyeL5A80+4kBYr837ZZjZnZ6aXjJKDhLInBqI5oi54sXCYyKnEcC5c98GwuFmdyY4fWH2JDdowUTTuJh8Mz05BiYyT0Rua6VcAbnAz/75NcgFg+nkC//NBtQSFvQfRhjfSy+/TMNlqKLUb28AiPGnn6hfaZCSAVxKK3UPn+zY6FnWu4kcK/8fTEWljiSKV9fVGQ1ZE2ZA1m/4yx0YXkRURsL/vE+zecqqd4Y9wORiL6ne8NZyTD9C4WP70wgo5llCvfqbMaAgpfV2trhy21sh2ipWGAKHXjjY5nECU4F9QPHyq4Wqcc7fleKH9VI5h8m3scJradgUZpyuAAyw04+KIRK43lrUJZ9qmq1ewBZPQ3jqnqebmywE5n0/ACQJVNUhEpHH8Ur4ZfuDXHRc5p8YgjfgEvfJ9FqPsUBNQVbY9fmnnA/TiHKzBAuwhnJwfXbYSnkj0gDOK3YYnln1R7pkk0Yr0EcEeLNYfAoMUd1wtNi1km+REpFzuhJbJYuBZaq10VZ3V+/VwkMkqtAdcZxk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199015)(2616005)(6486002)(478600001)(5660300002)(31686004)(66556008)(6512007)(4326008)(26005)(6506007)(2906002)(8936002)(86362001)(37006003)(54906003)(316002)(41300700001)(38100700002)(6862004)(8676002)(31696002)(186003)(66946007)(66476007)(6636002)(53546011)(83380400001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QndGUGFnWjl0MUFEK1F4MGlSRXBGQm1QTXNsdmtieWhmRnoyQXhpY1BzK2Iw?=
 =?utf-8?B?ZXZHZjBldStzTFlEbzlraGpudzNXeWxlQi9iZ09YQ2JwWkwvWVpoSUZWVkxP?=
 =?utf-8?B?MDljZ1pFMXVjalJVVnBONks5TDFiMk1EVktuSUk0QjZCNUZRQjJGY0phZlVl?=
 =?utf-8?B?d0p6YWlqV2hzMVZsVUc3VEpPREZETFB1ckcrVmIyVkM0SU5PMEpwRlJIQVlD?=
 =?utf-8?B?VXU3bjNpNytReXdDYXZGSXN6RmgrQm4vdXJhb0Rleng1QlU5YWNHa3NxSHk2?=
 =?utf-8?B?RkRGWUI4QVNjb2dsRWdqVUNPOExLekUrUkJWMEJPOVpwWXdGYmRSTzZoZkh2?=
 =?utf-8?B?UUlVL2lqL3lBRW5oa0ltelhJd3lCeEJPZXl0eCtibllPZmhUeXM5RE1mOCtS?=
 =?utf-8?B?RkMwT0RBMWd4ZW1lcnpJUEN4Mzd1SzFRNm9LK1RNV3RaQU1DM0VneVBMQXVn?=
 =?utf-8?B?SWplb2hDd3NwSGZjZEU3NHNieXRQMEtqZ2RWekJrMndxNXozNWtoV0MxUm1p?=
 =?utf-8?B?eXNhVktLVUw2K2dZbGMyMkd5emFQdzRHNFVwZmpLcDNyd2trblBPUFJEL0Vz?=
 =?utf-8?B?Y2FHZlkxZHQ0R1ZYRW9GbnYwTHZBeDFQaHNvbUM3Mjh3c1A3SkNZNTJDY3ls?=
 =?utf-8?B?UmNWYlJsRjFqODE3MnhIWEwweGJnZWczNDJqNVd1ZytySWZ6R1RGNFZ2bXZv?=
 =?utf-8?B?NVQrd0pDdmxNdFQvYTRYMTNMVTVYTWlrVmozVkNZQVN1ejlsU1RCS0pETlI2?=
 =?utf-8?B?MHBCM2hMajlhZHBZVHJkaWZ1ZGJXZjM3UzQzbURpNTRIaVVIbEpISzQrRGFL?=
 =?utf-8?B?THgxRmtFTUxvdkt2Tkd1OWtZNmwxM2loc1FSNXN0TWVucW84VklvaVk3VjZ0?=
 =?utf-8?B?MWd0cDRtUUhYNFdSMW5TR2d6K2xEMVpCZXdnY1FxcDhTMUxvVmFnNVB1QVl2?=
 =?utf-8?B?MVBlYUYyTG9nbjd0UFRmd2llVGc3UlZZRWJ6cW8yK2tSeEluREJwM21aeGJO?=
 =?utf-8?B?ZUtqQUUyZERGanNmcWw3LzN4bVU0V0ErZytHZFR1dmJxMUc3M0YrQXdpMkR3?=
 =?utf-8?B?TVp1a29wb01TM3R2RFpYeENjZ0RSbkdqTmM5S005MzBCVGZmTS9ycmhwUXcx?=
 =?utf-8?B?TEk2eDZLeDdidUViY3JJM09vUm1uOXNFZDZEZVIrWHp1TndTNnB5US8zYnlr?=
 =?utf-8?B?UjZPeUtNT3U2aXdNRjFQNWtHWkdsZnNCK0thUUFFbXluZ2ZGTnN2ZVJMbS9x?=
 =?utf-8?B?bjIzMTBFNnp2MFJ0MmFhdWYrNENKcVkrV0Y5dnZSRTMzbmZIYTIvN2VyVWlx?=
 =?utf-8?B?Mkp3WEZjNVNwQ1M2THF5OEg0amU2Y2JKYms2bHRmZzhhVGNJWW83bTJ2cFRI?=
 =?utf-8?B?MlVhZ1VYa1lZa2M5dURDdWxNWmZVZDY0b0dKVFY3bnZjcWVDUHlUbVBzVHBD?=
 =?utf-8?B?dXljTWlnSVcyVWNBOW5QTlorT3p2aFFuMHJYdElJMU1yMStoWkdZYVdvdnJL?=
 =?utf-8?B?VVlSM1dwenBoTmhIOFltMk1WN0pGT1lwRGZ6clJtRlpIdkdMaFdtOW5TL1Bm?=
 =?utf-8?B?NEtJVzFwYkg4U0RRTDdnd0dqWDdjVk5JYmoxbHl6M1JGNStLK0g1blRUVjZh?=
 =?utf-8?B?UkdNaXJVdzYybDlUVzhlYStqRWZpOWJHOVFJK01QSHhIR05UcjRlTDNkYkdu?=
 =?utf-8?B?WmZyN1NlMTdhbzJzcDgzNXRBZEdJbDkxOWg0c1FRbEhZTkRxc2F1b3JUdEJM?=
 =?utf-8?B?S0ZtcEphWlo1MldsSmJCTTVsV2drRDVndWlCb3hxamd0VjBxdXBabjBjWnRQ?=
 =?utf-8?B?SkEwdjdqMlFndS9lYzV0ajJFQ2hpbmVjVjBDeUFKZmJxUlRvcENhUDIzZ2tK?=
 =?utf-8?B?YnRRR2lVbks1ek5leVRxR2JWelhyaXdkYXRvNXNwdHpKT3FCNjhVdXpuc0VX?=
 =?utf-8?B?c3RDRS9pU0VMSjVrVlkycy9meXh6RjFpOU4yTUR2dWhnUi8rdjlhTkFsbXh3?=
 =?utf-8?B?VStwamtpK3F4YXdPWXg4RkYwMFlDZitEaXlRVGtScHJSdmRIQlpqZ04yUzhV?=
 =?utf-8?B?NU5Xbm1JYnhOeUZSTjV5dURuSjAxLzlIbG5MVk93ZitKSlcyU0ViSjdEWWlE?=
 =?utf-8?Q?WzLaIyIUzLEkTLsNVHMPQpLid?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4885cf63-47f4-4698-ad58-08daa5f77076
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 10:58:59.0396
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3lbh+tVIqEXwygOZg5jVKm8Pl7MY4jE3naKFvrCWQwK6IgBgRiFnowf1OvLU22KS4pq2IuJ1e6ezYD83Yv+nog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9215

On 04.10.2022 10:43, Juergen Gross wrote:
> Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants
> of read/write MSR in case the MSR access isn't emulated via Xen. Allow
> the caller to select the potentially faulting variant by passing NULL
> for the error pointer.
> 
> Restructure the code to make it more readable.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

I think the title (and to some degree also the description) is misleading:
The property we care about here isn't whether an MSR access would raise
#GP (we can't control that), but whether that #GP would be recovered from.

> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -131,6 +131,9 @@ static inline uint32_t get_fam15h_addr(u32 addr)
>  
>  static inline bool is_amd_pmu_msr(unsigned int msr)
>  {
> +	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
> +		return false;

I understand this and ...

> @@ -144,6 +147,9 @@ static int is_intel_pmu_msr(u32 msr_index, int *type, int *index)
>  {
>  	u32 msr_index_pmc;
>  
> +	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> +		return false;

... this matches prior behavior, but may I suggest that while moving
these here you at least accompany them by a comment clarifying that
these aren't really correct? We'd come closer if is_amd_pmu_msr()
accepted AMD and Hygon, while is_intel_pmu_msr() may want to accept
Intel and Centaur (but I understand this would be largely orthogonal,
hence the suggestion towards comments). In the hypervisor we kind of
also support Shanghai, but I wonder whether we wouldn't better rip
out that code as unmaintained.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 11:03:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 11:03:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415430.660002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offhd-0002jt-UV; Tue, 04 Oct 2022 11:03:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415430.660002; Tue, 04 Oct 2022 11:03:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offhd-0002jm-RS; Tue, 04 Oct 2022 11:03:09 +0000
Received: by outflank-mailman (input) for mailman id 415430;
 Tue, 04 Oct 2022 11:03:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1offhc-0002jg-TK
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 11:03:08 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2083.outbound.protection.outlook.com [40.107.104.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2063ad44-43d4-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 13:03:07 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8691.eurprd04.prod.outlook.com (2603:10a6:20b:42a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 11:03:05 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 11:03:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2063ad44-43d4-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bC+7OlPu12qai4+pmkhDTqVckIhUvBHBQx8h7ZQvyaje7nflrQi7xRQbbEBMfGR88i6vkR1/QNaTYuISoKI3kZCGyAgrDBQsGTvJZ77pJeVagEb4ahlnYtXn8WJ7PJuKMBQvJMcrFIIDTVo0XEpTXTtuYFLSZnLyDa1eIb7incpMG1vLT06TS4nYQpTCFbOpcUmFAzSqeUnSI9uMzoZ4b9e9Q7zMu7ASEVw5aJU5waqxhAD2VDFE9VCc+4MdFVUzBktuT+TbRVojnsWMeQeA4W0qCDY6cBvYovRCL+WS+rnN+zfEb+aV4/Al3AZE1mpNHt88DcNRPgGSfCz+jtL7vA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IokFddPdV7HIrzpIUoByLj6n+3o3hsSxVbuMkS/m+g4=;
 b=HfqDQeoCpl8AbFX8rWV/W9HRHx036dV7Xl889BXTYp1M9MFPTH9YK+x7YWSt9bMmrYax5H9avYwfGH1UzUeY/nGhPciNjscwG87Len5c2tKlfd0Y43hnK7H9iWht31lNjud/v+9Uv1HJUN93ufTGutYkLZ7Jqo7DJQ2mJaJNmXDsmQhF4+RKnOizEtcHZ8rEdHVQ3yPU9ElxTRDBpVFA3a4X3HacESdZD60xkjVmuGcXuUiA/90oI/9z83s7EkPWIamFB1QPnnB+bICS5bvhkv8eyjiMDIzbABZuhFpnIhcMx1XV0eG6X4MMrrmvoD/eEyroz/rv2o19AJuaezRUIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=IokFddPdV7HIrzpIUoByLj6n+3o3hsSxVbuMkS/m+g4=;
 b=qklSvkonYtZ6GCu9CnNlxwk66GMUmcUVT5zSU7o4S3/zKRbSCKyaudz3zRpuEKSmEQz6jfRm2wYNC1rCvn9SpI1gcuHcLukRxrpHK319c8GrWeJpnL01E7wnd5B6+O3pENZ2WQX+ROFi76za0+/tZRLOyX2wgdwrwbPdRKAJ/YinwddN6SmDp/Aq4NvwOIn1qHzymGAdAgV1VBtUVrJII087FqCTmBNarezgs5Mvv84PuHHD9kl7GYsZq3YQy30LxPxTm/R8pHDRhHUnZUN18Kbdn8M7r4TKwKVkWkH9iTJlIbZoDU3syK0eg2mr5rqMwppQjv5VRISAqXFNK3N17g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <623a323c-943b-8c69-f877-a0669b9672dc@suse.com>
Date: Tue, 4 Oct 2022 13:03:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2 2/3] xen/pv: refactor msr access functions to support
 safe and unsafe accesses
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-3-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221004084335.2838-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0006.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8691:EE_
X-MS-Office365-Filtering-Correlation-Id: a3811be0-1166-44c8-c4f9-08daa5f802e2
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bmdfDVlhLgyv8R3Y788IlQDu9xRxyY9Nt+kyzLtg36Hb5onDE4j/D0TloXJMOL8wBKH3xV0af8YLWti6Y5WwUQzuZ0KpDfJG+EKSikvV6r7+MHKfMoMkoONbC9jfjBMGtMtAlDsJzIw8onYShYdQ33RNgMZjuFH8Wb5x9lcgkDmiEayEiJ26NsefA8rrS/cG8eszFkamhwdfn4DuA14rYgFjW0EdS2Tqg0fWTkfubRIBw6slzH3Xv6DwMP+MqqHZgfrOdI2jSz/QAOZ1UG+wW9RQjmMdfJf3GBll/tjWOvpY6wB7jVSaomQxAeCxPfpAeg0hojHfc3KfFd9Dl5S7izZcxYp9UWq6ZKwmr/fb2cm15YQDfnJ7BcCpNNVwvVQpkcVY+b4EGsvaSrMKNgkhRrC52OPfIYydsOMttsKt48NYK3yKxmCM4LvK3tIp/MzFDBWMkGJgh3+Tsh+AzZWgXU4V1aPqlO+EHfStUiTgecePqQpj5oS3IYX6UfMR3gY2fa7ALduc+iXUvdkV71z2+ACvyHYp1MCzxE67na6zZTr6YN+FKyu3k8XFsT2WHgCO4/NeKWmVSsn+7IElA3piSWDLty5YMgjYEUrV3yoZpTZEEPENRzfR11sI65AeWkfODbAJc0cFI14MHa/lMtatJ+WExGm+4/Lg7Jb0YKritAHpvDBifrzAFma9t/4hmJosLU3EJK0f1HA0VzbD2QEdQENI0YZpwYTPG6MkhUrmMZhAlEh5bq990HEdmBuC+v1UPrQyPAj4WI4Vb6oy35M9DuXhc8AyUv7ovUoh0JDzuxE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199015)(5660300002)(41300700001)(2906002)(8936002)(6862004)(31686004)(6506007)(53546011)(26005)(83380400001)(86362001)(478600001)(186003)(66556008)(66476007)(6512007)(8676002)(4326008)(66946007)(54906003)(36756003)(2616005)(31696002)(37006003)(6486002)(6636002)(38100700002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YjZKZnlnVnlqVEM0TTc1dGxGdW5VWm4xRHI3cHJYTHplcnZDaDNUaFc3QWZa?=
 =?utf-8?B?aXRVVlo0Y2V4OFNTS0E0R0s5V25zbUNIc3BvRkxqOVU1dTNEaFF5cG5LSG5G?=
 =?utf-8?B?V0NVdmNkRCtVcU90NmRoOUpBc3ZIUUsrN1pZM0Y3OUlrU1pSa0RwSlJ1cVBK?=
 =?utf-8?B?STlhMUNOMEpNSSsweWY2WEM5SXVDNVZqbExVTWJjMENINDdLckpXZlN4N1pG?=
 =?utf-8?B?RkoxYnpxQm5VS0dGQ0s5VldjK21Ga1lscGE2RG81MmtSZElPR2IxcWl5WW1l?=
 =?utf-8?B?elVucUZSR0syazFRTzV5dTU5MzZUWFlabFVoUjgvTHFMR2Q4YXd0NDRKc0VN?=
 =?utf-8?B?bU5tbThwYkxrbHJSWWN5VFh3MDhEY3pLaHBhbEJQTjdZY3JGQ0JmTHpPTXpN?=
 =?utf-8?B?NzVGMkpmeTNhaDdyRGZBWU5HaGUrbkVNUTQrdGxhaUZpaEtLYWdndnBVbVk2?=
 =?utf-8?B?MC9GZWlrdnVIN0dSWUZZeklaTnJyQUkvbzNiNGtkNFJ0WENvZ3dkMThkdFBO?=
 =?utf-8?B?RFZnN0NvN3VHTGZBVSsrYnFHdDdPc3dNdzJjbkVUaU9vOWVSUnkwNnlscElG?=
 =?utf-8?B?N3ZOcWJpTnNYYTkxSXN4V1pzSlpLZmE2ZGVSVXhjTWJaTVU1UUd1WUlWSXh0?=
 =?utf-8?B?cmJuaTNwSHJWY2hhcmUwd05qOUdGcVVHZjQxWll3NFNvQnluSTArNE5hQjRl?=
 =?utf-8?B?RFVwUFBJQWlrYTl0Z1M0VWxEMkRYb2lhdVU1RU5qYVNjcExvVmNsckNjeXVK?=
 =?utf-8?B?eEorRTRLNVVIbGR3VE1JbzV4bUYwa3l2cS92NFRVejhZa0Jvb3ErZG5KaUxq?=
 =?utf-8?B?S1FTL0tDZFFwNTFLdG9FcU1tTWtyK00wazI2cFgxNEpFMnN5SklzVVFKRGFv?=
 =?utf-8?B?ZG1ZbWUvRFU0RDVHelYvc2RDZ0d6N2x3UlRldlFtN3hzT3J3NDNOa1RPdklx?=
 =?utf-8?B?ZU9mQXZIZUZOS2hjWjdMV3R5a000R0hvcm5sZmN4ODhqUE5YbTd2OXZEVDBn?=
 =?utf-8?B?Q3dqdUtvWGJVUUhhUjFRTi9VaGxXVWZ6aFNGS3NPUWtDUXVUSTlUaXVMN0ZN?=
 =?utf-8?B?Y05LYzE4SXkzREZWQURzVDJuTmtjRC9WcFpkYjQ5OThaRUJCNkw1L0pZK1dI?=
 =?utf-8?B?RldBTFk4UExaMDFSU2Z1TFNTbW1Yd1JBS2twV1I5cUs3eDVhM1BrbGVid2Nn?=
 =?utf-8?B?OHB0cU9nME8vU3kxSzZXOXozMnA2M0kzenRjRVNWck16dDlkU1drbjl3SlVh?=
 =?utf-8?B?Ynh3QXVuZUpxQitqcWJvL0NmWU5pQ1hITU8vdHhka3UvdEF0ZnFPeW1HNEwz?=
 =?utf-8?B?cmFGWkdGM1JySW5BY21mU3ovM3l3cWdFbGkyQlp5QlF0Y0d2RUliSUJhMm5X?=
 =?utf-8?B?cVQ0dktNUVdxVmFQM3BkL3ZXcG5FTjl2YjJCWFgzcFVzRVFkaGkvVDArR0Jp?=
 =?utf-8?B?TDI5QmJqNXYxc3FSYzhxemZzdDZTRVAyTnpZL2g4aUJiWDg0RWFZQUg0Mk56?=
 =?utf-8?B?U2lBYzlrVGF3VHU2eEJjdFNpNlcyQi9PYU03S0V1RXFWU2RyeGZtazR0QlRS?=
 =?utf-8?B?OFRzdDY3dFV0R3A5NE1tZ0lpV0FmbldpYVlzaTZFNmVHZ1UvcjNXa1l2aWpX?=
 =?utf-8?B?MXlFTS9mZFY3MnY1WU1MUXhZdEszYmFWU1RZaFR6cTRhNTNMZEF0dnBKNXU0?=
 =?utf-8?B?cHBnZ3RMdFltbVl2bE9vaFJ3Y3VIR0xxT3hFekU1VFovRk9OQUxMUDFnRjhP?=
 =?utf-8?B?MEozclRLT3hiQ20zWW5vN0RDdHA0V1ZOWVR6ZVlkWU83M1BQemR5dkRFaEx1?=
 =?utf-8?B?TjRyMnFpL0tKZGU1ZGorRVVrQmJYRHBxUWVZY1lkWFJVTStWb3RaU3h6Y3Er?=
 =?utf-8?B?NVVHWk9wQnovNEJyZGk0R2s0UllFbG9LMVVnQ2J1YmszNWpwM3o1aTNjRHd4?=
 =?utf-8?B?U09WVUludlpaU0crWEFDVGlDMkFxYWRwckZOK3dNKzNOcW9rRndjY25zSjlI?=
 =?utf-8?B?QUtsT3kxNXdwbUd2cFlLSERJeUtKQjF5WGhVMUU1Rmh6a2xueTVRMXlBeFhJ?=
 =?utf-8?B?UUh3UVZxMVlYbWoxNVNFMWtwbTNSZEozOW54dVIyWE9aRUdiaWptQitxOUVU?=
 =?utf-8?Q?M17EpFif5ogZFM0Sw+MM+3fCI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3811be0-1166-44c8-c4f9-08daa5f802e2
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 11:03:04.7109
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1WNFMzrcc5FhF2Ph7miUS1i1pArGObud6UOUG+lsho6znCKO4Ktx6KGP/FF+NqpWSNT3Vw8mccZuIqeFMRMwfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8691

On 04.10.2022 10:43, Juergen Gross wrote:
> Refactor and rename xen_read_msr_safe() and xen_write_msr_safe() to
> support both cases of MSR accesses, safe ones and potentially GP-fault
> generating ones.
> 
> This will prepare to no longer swallow GPs silently in xen_read_msr()
> and xen_write_msr().
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Albeit ...

> @@ -933,23 +937,39 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err)
>  	return val;
>  }
>  
> -static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
> +static void set_seg(unsigned int which, unsigned int low, unsigned int high,
> +		    int *err)
>  {
> -	int ret;
> -	unsigned int which;
> -	u64 base;
> +	u64 base = ((u64)high << 32) | low;
> +
> +	if (HYPERVISOR_set_segment_base(which, base) == 0)
> +		return;
>  
> -	ret = 0;
> +	if (err)
> +		*err = -EIO;

... I don't see a good reason to override the error code handed to us
by the hypervisor here; I do realize though that this ...

> +	else
> +		WARN(1, "Xen set_segment_base(%u, %llx) failed\n", which, base);
> +}
>  
> +/*
> + * Support write_msr_safe() and write_msr() semantics.
> + * With err == NULL write_msr() semantics are selected.
> + * Supplying an err pointer requires err to be pre-initialized with 0.
> + */
> +static void xen_do_write_msr(unsigned int msr, unsigned int low,
> +			     unsigned int high, int *err)
> +{
>  	switch (msr) {
> -	case MSR_FS_BASE:		which = SEGBASE_FS; goto set;
> -	case MSR_KERNEL_GS_BASE:	which = SEGBASE_GS_USER; goto set;
> -	case MSR_GS_BASE:		which = SEGBASE_GS_KERNEL; goto set;
> -
> -	set:
> -		base = ((u64)high << 32) | low;
> -		if (HYPERVISOR_set_segment_base(which, base) != 0)
> -			ret = -EIO;

... was this way before.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 11:09:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 11:09:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415439.660014 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offnX-0003RV-NY; Tue, 04 Oct 2022 11:09:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415439.660014; Tue, 04 Oct 2022 11:09:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offnX-0003RO-Kq; Tue, 04 Oct 2022 11:09:15 +0000
Received: by outflank-mailman (input) for mailman id 415439;
 Tue, 04 Oct 2022 11:09:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1offnW-0003RI-Tv
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 11:09:14 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80083.outbound.protection.outlook.com [40.107.8.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id faa92008-43d4-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 13:09:13 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8716.eurprd04.prod.outlook.com (2603:10a6:20b:43f::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 11:09:12 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 11:09:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: faa92008-43d4-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IToqcuQ9TCdtqWDWj983g1LQcIf3gOVdy241HtcbMwe4uQ8G1KcK92SqN4ncqvwUwSZvgItNJOGCoALLHafhM28ZkKqINHxWaMaGCw/ILWSYwhLGmgI9LI/TLIUU9mEAQlIG1Yhtw0tYiZPXMkne7L51sRVTUULrK7x7xL47hEzLQl4bvy8WiwHZKFaG7m87+vUc2NljiGNlR/NgKzh09K8Gr58xPGGalvTzXtN0hSTTi761X5dRKf7SGTpIps+t6Y/woHPJEPrkJl+04gGfcp0b2GAYJ0sfTb6EYBq/fCUsUXgXqv3VxcdCS4BVi20BkJJliUJwEDDl0C2mycUkJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0G2iTgslzTmppFWNurxZ4gsNJab+1yPUREtAJRT7cR0=;
 b=gipaB13t1E1xAj9CUegb7Ef3cVTFO4oyd8DOtcsElmY0XcRHHUh+fLwQrUY7F38BpSwUq6jlTHa4/2s8Ps4ATywSMxllCvNpxZ+3es0y0xb+sgggzS8ZO0qvykZ8xACHpHsF4Ijgi5LdekRu4K7LiyYckucj48D764VvOxA1HCRWpUj4ToBAejruL4y3ZacIJyFbDxZfLmiSZFV0P38YWKr0GpdBWIS+lSBws43J5TuXTU7aHpM33nvnDxwbHxTxYegVm1bKhMl3wx9yKiT5gL5MD9P6K/Dwj1X9LdUZW6FTaMkYQxN9VupgQ25B2UTCdSeFRY05ZqnsMLWXul+5YQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0G2iTgslzTmppFWNurxZ4gsNJab+1yPUREtAJRT7cR0=;
 b=gwjkPMTP92xLt1kA2h7mPJduP+U3MSMeQLqdJeM9pxv3HpzoFyZf46MJJwzLixiZwNIL6DKX1TcgBo7BCrfVr6VxYINb1pTBxF+Y7AKzIy/iqqTAL3orxfVYgM5ggI+dAtTFI34S+370VPT+F2lLrj7SCHwa15mCi1gH+FmTq2cr4Oc6Klg3rS13TFOQr5YKBEqeZ/vGRHQjNf0Whv93u0jZlCDj5LOOELy4q76I+Wes13UZmjIeH2da6Vwh0h884w8IOiUQig8o1a4WMZ0I3BDffYxv+GJn+utwPIzca5Qeo6WC9k7iPbrFqQejMx+sxmlMkbTjUp6mAu0BeZodKw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de45bc4e-888d-6bf8-4371-1adf46b91210@suse.com>
Date: Tue, 4 Oct 2022 13:09:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang
 <Henry.Wang@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <4f55fc1b-30b0-c5bf-bfec-bb237b8c9379@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4f55fc1b-30b0-c5bf-bfec-bb237b8c9379@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0147.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:95::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8716:EE_
X-MS-Office365-Filtering-Correlation-Id: 0f135ccb-dfa0-4889-91e2-08daa5f8ddc7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cnuoNexMU80zoJ/flhMPEfJaYzhJwFBupPU1qFFGltsrJJC/+a+jamH9EEgcM+NX94zw79ZpEcqT0DNCY+XmBVzkA+EBZyJOlgxLcjtBC/xDklRGxfImE8HjqliOwzW/f29ExF2FLMoeCGAk14knxh1btRpyFB0HO9Wn37GDYcNRjNmDR90ZXbdKaZTcrW01XuFAKTDwKdVfV2tLkvLMcm4a1UzUJKd11xg3HhfTOHAWPNHCImIdLzM9q3t8rg2omKnG3sSwofStcW07lZQOxVIOf80KGBUUHCQlej50WFYdQL4zKYFFTDZ0WRhzGiKWbUgI32Rz5rX6hKMBThaS35hdrEAuq2o0dVq15MCPxJFMvQN5j6H42cnNKl92l/Yxjbd8GXyRHaYcJ7yf0PrDc4yVdA5+dP+LDru+ycs7fTIXcxrAR+wWCRjwkENcgnRi7oFR4Fwa8bL21ZNT+BzGvZBUQJY6Rqv2UAXdTooqQ9SyeH+dBwLQcHSfW/UpZIbbSADRUPk6pl9URCx0SuH3vAaxysxcdMFI6g4K1tffrHKgPxnnDbaJnH9vgkrUaG3ScGlhNxu5CQKDzo+fTPzHoSwYkWj2Xiuzbe6ZmQ/rYktS6RE8ywIvd4KiuXKyK/Tn8Qf8a5+ntjjkFiNQe6b9lH15FL9zwMXLMYUi1cv/a9O3+my3X4RD6gdRBqSKmRCdt2N30PfDg+yWAgR90dw36TGHb83W0+M15ASgE8zsnVafgVof+pktjOQy477vEcWsoZW7bhS+vKpKwT05Ee73+26CJbWYKgL2pRfYxtLMwL8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(38100700002)(31696002)(86362001)(36756003)(6506007)(41300700001)(53546011)(66476007)(66556008)(66946007)(8936002)(4326008)(7416002)(5660300002)(6512007)(26005)(478600001)(186003)(6486002)(54906003)(8676002)(316002)(6916009)(2616005)(2906002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZkN6ZjRiSXNGOUtSVkNqQVNhNEplNHhQZ1h0UkY1UWxRVmhMY01PRkpZU1dx?=
 =?utf-8?B?N1hHK1BOWVlUNUllOElIcDdSVDhBdGFaQ1RHTVNTcUVXMExNMHdQRitFalJ0?=
 =?utf-8?B?YUpFRFdOcCs2NXcxdDQ0OVByR0t6bjd6eUtidkVNanR4Njd2cUR2cVJzRU5h?=
 =?utf-8?B?OXBYOWtDL05TSHlMTXovZHBjUlJKMWFaSlJvd09rcTc1c2Vad0toNDliNEJo?=
 =?utf-8?B?STRLL1h0YzdidlZ6UFNMZ3NERGtGTFlOajdzdkpFS2dCTDVrUjRZZjB1ZFVJ?=
 =?utf-8?B?S0lUZWN4eEltOEJoQXZnUFR5VU9rZzBCcVlYUk0xQU0za1VTemtWVEEwMnNx?=
 =?utf-8?B?SzBhenlJU0RrUEszdkZNcS9TbDNwYm5pK3FIQlZ3aThteHFmU2pjTDg0L0s3?=
 =?utf-8?B?UldCMWpBWEt2OXY2cnN0clJIYXNvSlJXczIyR2taVFpRSUovZlZlRHBYRUkv?=
 =?utf-8?B?NHF2a05oWmgwTnFWWmFjYm0zaHY1akJaU1p5dUIyZzV5VThSMnlZY1BleGRT?=
 =?utf-8?B?Z0lueFVvWW5FM3JSSWZ5VTg5cWZkb1ZGUk4rcXB4ZkVWdjZmMzlFS3gyemNQ?=
 =?utf-8?B?WWN2c01SM3JUeHdzbjZESXdvZGtTSTZGNzZKVkhqNWVZN21uVkpqNTRHQ2xY?=
 =?utf-8?B?d2ZoZ3d5ZkI0TUF6bWMxWHgza2l4TXFoSkx3TW1JNEJnUUZGdTgwVzlHS0wx?=
 =?utf-8?B?Rkg1cnc0dElLWFFlMWV5bXNpMnBwZjdRdFgyMEYrbGZ3SGJPV1dQSXEyb0dR?=
 =?utf-8?B?RVpVckErRDFJNW5aQVlGeWFta2ttRGkyTktmWm1jejRRSFNka1ZaaUpUNlZ6?=
 =?utf-8?B?cEN6OUtpVE1BcHlYMXFDcXpUTkk1dlYzYkhoQURMMkhFcFNGekhJU2hxaVZY?=
 =?utf-8?B?eSs1aVN2QXVlTXRMVHFUWFhYYWZ5YzJ5VDVJZGdxMnZvYVhQRCtzZWY4azFY?=
 =?utf-8?B?QkxHM0E4OXJ2ZjJGLzZSbi8rMnJzT3dSelo3c3NOdkNvc0RUZWIvcVZjY1hi?=
 =?utf-8?B?M1FkN2s4NTVZL0ptdi9FSi9CcFZ4OHNDS3JtVjMraGg5cUlvdUZxd0F4SXRP?=
 =?utf-8?B?czFsSG1sc0tFU1Z2Y3NMeUhGRnlIenhXQlMxMGR0c3lEZ1hrNlRISGpjT01O?=
 =?utf-8?B?MzVwUmxmQmJ1dTkzdGY1RkRaZDRtUmoxTWpzMmNjMnNSNlhkdERFNzVwcHdP?=
 =?utf-8?B?WVlucnoyckNXeXBhY2tLWFBScEx5RFgxdWMzdDc3c3NocEdNN2t6N2w0U3JF?=
 =?utf-8?B?QUF4NWliVFUxUHEwQjlKaVhvME5NcDhVWTFxcGQwd0EwTnp1TlYzT0FPeWVU?=
 =?utf-8?B?eE9LdVF4S3R3c2pLUDJZVFd3UGxkWk5wWkErY1pFMlk2RVFVZE43blZ2OWNJ?=
 =?utf-8?B?N0JXQk5ncHQrS25HbXoyLzZ1QjJ1bGlLem1QcnlISXNtb1pEa0tyRUg0K3ZF?=
 =?utf-8?B?OXF3VnBUZ21nbS9zZjZ0eGJXTzl4QmF5UWl1dXRubGdmemtZTk9NbmVJaThP?=
 =?utf-8?B?WDdrcSt1TEV4SCtzNC9HNERPMVJKalhoWlpiWTdrZHpwWFVIODRlNGZ0ZGM1?=
 =?utf-8?B?Y0FMZHhpdHlYYXFYeldxWjNNbkMrVFVacnNLNEVHRTJLeE11YTRzc2s5ZnN4?=
 =?utf-8?B?aTZDbXdsR0lqSThCN1FlRXF5bC9kR3h4SjgwTWppdDlHOFZFUTdQQUxxMEpy?=
 =?utf-8?B?cHhtck1tNzlBcDBkdUIyVzJEVlpCTXJsWTFSL3FvMjRNUjVlbzlDeTFzVldn?=
 =?utf-8?B?eFRxeE1xUGpvYWVZS2FJNk1XVjU2cFozWStUZTdZTlhuMEIyY0FDMlEvSmI0?=
 =?utf-8?B?NFNsd2d1THozY1JNTU9SMEwvREVKaVJrdWNOUjdtd2l0a0c5Q29YcjlKLzY1?=
 =?utf-8?B?SFo4bnQwdWVuU2lIdTJvcFQ0T1I2TmpTdU16RnNUYXQ2b2svTGU4RjlQbHEy?=
 =?utf-8?B?Q3NjSU5KNE4yWWZRK1JhNEl0YmZ2bFBGdG1lWlI0OUc2K3pWdFloVHRNN1p4?=
 =?utf-8?B?ZEk5YmlMemhHZC9QdlVmZEhpREJob2YvL04xdUszRUJxYlMvMGtEaHpscm80?=
 =?utf-8?B?UDU4RHJGOXQrM3NQK09UUlZORENlUlBiMTA5SzB3a3JiNlJuZ3dqUTNWMWYx?=
 =?utf-8?Q?VxjSFqsVdTE7tnf5y6iP7QQXk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f135ccb-dfa0-4889-91e2-08daa5f8ddc7
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 11:09:11.9068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i6LCh1k1YX4qWoG+wvk6bpAmiSiP4CPLcLMo+uu5e1F84IGYLG9Njd90aRqcdg2exayYQ+QBTbLhRPKz8GR5kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8716

On 04.10.2022 12:49, Andrew Cooper wrote:
> On 04/10/2022 11:23, Jan Beulich wrote:
>> On 04.10.2022 11:33, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>> runtime which was re-used for other purposes, make
>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>>> dom0 doesn't try to use it either?
>>>> I'm afraid I don't understand the questions. Not the least because I
>>>> think "it" can't really mean "dom0" from the earlier sentence.
>>> Sorry, let me try again:
>>>
>>> The memory map provided to dom0 will contain E820_ACPI entries for
>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>>> overwriting the data needed for runtime services?
>> How would Dom0 go about doing so?
> 
> Zeroing the memory and putting it into its own heap.

This makes no sense.

> You seem to be presuming that some unwritten and unenforced rules exist.

There's the PV interface. All memory management related functionality
has to be based on the E820 map handed to the domain (irrespective of
it being Dom0 or DomU). That map has no E820_ACPI entries for PV (and
PVH Dom0 is as of yet unsupported). Dom0 is also handed the host E820,
but it is supposed to use it only for resource management (e.g. to
determine where BARs may be placed, or how to arrange its PFN space).

> Once dom0 has booted, Xen cannot safety touch any ACPI reclaimable
> range.

I clearly disagree, and I expect existing behavior also disagrees with
you.

Jan

>  It doesn't go wrong in practice because OSes don't actually
> reclaim the reclaimable ranges (which is also why Xen HVM guests don't
> explode either.)
> 
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 11:21:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 11:21:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415446.660025 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offzT-0005iI-TL; Tue, 04 Oct 2022 11:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415446.660025; Tue, 04 Oct 2022 11:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1offzT-0005iB-PL; Tue, 04 Oct 2022 11:21:35 +0000
Received: by outflank-mailman (input) for mailman id 415446;
 Tue, 04 Oct 2022 11:21:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5ZM=2F=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1offzR-0005i5-T4
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 11:21:34 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b2389f06-43d6-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 13:21:31 +0200 (CEST)
Received: from AS9PR07CA0051.eurprd07.prod.outlook.com (2603:10a6:20b:46b::16)
 by DB9PR08MB6410.eurprd08.prod.outlook.com (2603:10a6:10:262::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 11:21:27 +0000
Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46b:cafe::ba) by AS9PR07CA0051.outlook.office365.com
 (2603:10a6:20b:46b::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.9 via Frontend
 Transport; Tue, 4 Oct 2022 11:21:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5676.17 via Frontend Transport; Tue, 4 Oct 2022 11:21:26 +0000
Received: ("Tessian outbound c2c2da38ad67:v128");
 Tue, 04 Oct 2022 11:21:26 +0000
Received: from b29ab3dc4f6d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 11B7005B-7285-40B7-9C35-3276C7398D09.1; 
 Tue, 04 Oct 2022 11:21:19 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b29ab3dc4f6d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 04 Oct 2022 11:21:19 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PAVPR08MB9697.eurprd08.prod.outlook.com (2603:10a6:102:31c::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 11:21:18 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%4]) with mapi id 15.20.5676.028; Tue, 4 Oct 2022
 11:21:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2389f06-43d6-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=CPoytFmEjaUiOucyUp+OEpwIZZdrtzDCsQP5HyNb19kSGui0qWLdPYQuPrKuRfNh1dTMfYMFYYw5O1YRqRjdDttk42uXDB/WAi1PJVOKksaA9MpE4w7Pn+TmgKn9UxhZHl4xcx8l56HuHMim6BvZun3P9L5Lh4h1XEH9uNj0+EQr2PkTpEtRoFaX1w76Ntxi1z4YAKbJsyl+ci3237pflSG+S1YH8zKrbCkAEa1A+GrWa7mffbbo6Lj13Kf+PC7uRIzQVHzIOD8J6+yYEPZjwDI9a1bBg6XNE80/mhpkBSBqbwAaPl8I5mx2KdFixdJENeU/3PoPwNYCXDjpLUL6NA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ReAYRI367OZFIFxwfeqxT0fiQMMtJKjlN9MiUmcB1Hg=;
 b=V/YtJYk0qMghMbPO72ZB2PSve6mT+lii/IsTt+GEKeWZ7ddmo5glaU85VTC5GvbLEsqypyyIhx/67/M5Jyn9Oy3BPEmizvlyzijsBeKHQM2eftJKH0LI/DAUUWpWz6/sbDR91BQxlzFhV8y5gZamUcyOkrGbTpuupTWR1PgfXy3Ac4E4DKbT/gbE+QCxjL7iJnyoRaJ92SXbJxR81LiNXbi2B+ETAhOWa/0JB77FDZrwEmZifSm50KF2LISn49NsuuxvE/KWGHdGOTgAiJOIJuG4SGkyyEFjFbMj1rjxpEqEuM3pzV0e/5lGNqBSU4CzoI6XNZ3GthRwKq3GMTFpJg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ReAYRI367OZFIFxwfeqxT0fiQMMtJKjlN9MiUmcB1Hg=;
 b=hpp129JGpS6T1Nj/907HG2ZgeCJQS02Q3N24COHt1g+qyVPua5k2/457gv0irOjkYCqGzM0ezC9FT0t0UQk/973JRLKnGwfnGD8H3m0KsoPAX1Ds+gTnWmNed+TWDnhp1L8jrTxnbtVgL2n/GzLvfRbMijArEp6IVLjk8oKfR18=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bm5JHXNluK0oaEpiV53SXbJrxlCOoGGYC7UvJdPTqENNjxgW2qH4Oxrcpq1M+Z7jG0u7wSqHjEw1uQNnCi7yPjChMzlTWzivvbbIqiYgwq3UdkXi2tTdFxspUU8BVI6F0z0BB2n/Dl0KfUj5eEB/4FHW2KyYHTch0qSPKESpKn5eFb+kCA7Erc3dHOdmbr3uqjfbCs4UEg8WltNSaHyZgN4UdIgdFRp0kv/qbv+nVuBPoXGATJG0R0EcWWNMEtxKyhx+Ik87JYYWrhI9BlsiECv4JcBM1paw+AinOg9DRfBmVWWJJhnPn0DbWIz6TKIi+i8I9Kb1IMB/txQAPg3Smw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ReAYRI367OZFIFxwfeqxT0fiQMMtJKjlN9MiUmcB1Hg=;
 b=ZPlzsAf+9tkw8ZpJW9oNu6sbMHu8E+Lp/TMVs79JIs6vTITl96VTN6HYQ5Azj7Agm2wLyAKLGDT9wIdCGcXdOykqc6C1QkmLDp7EcHNxEptV7uzU3cunUb5xFLIS+ucki/DeZIuuuDONfj4GZeiDO/RcCRGY3L4MqdUoxVWZo/F6GM6Ba9IdKwQ3vA2gyfJlsoSvPXAOmfUqxPP7xZGihkiVtnDr1bRG3m5BkKdAh4cxvmoqUcaL92qX2jHlQZarUYvcyh5ySLSkJ8vBewPIm1kAkLUA18x/jJUHbIh1JJ0k7LK8NWqS1OSa9MnSBVohILzXkrsO9H+S717dN1fHLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ReAYRI367OZFIFxwfeqxT0fiQMMtJKjlN9MiUmcB1Hg=;
 b=hpp129JGpS6T1Nj/907HG2ZgeCJQS02Q3N24COHt1g+qyVPua5k2/457gv0irOjkYCqGzM0ezC9FT0t0UQk/973JRLKnGwfnGD8H3m0KsoPAX1Ds+gTnWmNed+TWDnhp1L8jrTxnbtVgL2n/GzLvfRbMijArEp6IVLjk8oKfR18=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: RE: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
Thread-Topic: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
Thread-Index: AQHY19oJEykiG6eG0keCV/KH8DJyVa3+FqTQ
Date: Tue, 4 Oct 2022 11:21:17 +0000
Message-ID:
 <AS8PR08MB7991AB911245819731377747925A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
In-Reply-To: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: EE017414D3BB2C459D74E9E19C88493A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PAVPR08MB9697:EE_|VE1EUR03FT042:EE_|DB9PR08MB6410:EE_
X-MS-Office365-Filtering-Correlation-Id: 17eb89bb-2c76-4196-17d4-08daa5fa93d6
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 326xwsiczKSzkf5PcHFJBT7Lem1h6bAR94oYZ2ww7nTFYmwJCgKnTJT4mN0/mFIv6af6BD1IeWnp8J8KMyDu4Ruu4ddXvNia5VId57ig70uxJK9OSAPrh/LZQ0DYEnAnmJSM7p6MVIcVKv5jLwRy1DYIJ6xQJgwhAbrL93plBlU7iJRpnFvCu/rY+LamYS/aQ72rON94/me6MefMWAZm7Ynp4SEP8maflE5RBLpHFcNg/wiNSH2XkGl8tUHmxbLxHsdbeGqfsoubXNpmkbqbtJ6YyK3YsPFbG4YlTRrJLasXIZT57xsuvaSSRGNrYg8VksFfP6GaXiV6s0+BS0YOw5X6o54JhPSQKq6LM8Aykf8zB105nPsqsDO3TsHeo4Vt3l0y1Sb7PVZtejn7R6xKF2zHOVjboeoDM+plpWtnV7FdRP/48hzSZVmW4jzsHz+JKBwh1hguCyvKM7WRZdLp4MDeAT1n3jMm6i23S0g8uA/Wxic+SV57QI3nOAVw2GBbjlKFHqJBAIc/LdUmXGuEL7+8ojKfrC174R22lL+09C0MCqLKZWQg3Y73oBYxcIimKC2dZugr0tLpSHNOkwADJlxHcSNpkdiZ2OEk9YDFbctMnO7326KICXRVJKF2TfoaA7Tq1G3ajiFWCCU2XK+DP627OgUd1Kw4O5KAyOht2Sib3G2SC5dC2hheiSL1claFTOhHLaWK5gNDbUiEezzGwLXl4Qgg00RRIi6sluTrz+Kuhm6aYTCIKfk1FfWGPhbVYaB8YXCsT54RrBJSGKOmdg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(396003)(376002)(39860400002)(451199015)(41300700001)(71200400001)(478600001)(54906003)(86362001)(52536014)(8936002)(4744005)(5660300002)(8676002)(110136005)(316002)(4326008)(66446008)(33656002)(64756008)(66946007)(66476007)(66556008)(76116006)(38100700002)(26005)(55016003)(122000001)(83380400001)(9686003)(6506007)(186003)(38070700005)(7696005)(2906002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9697
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d0a19dc3-e087-4f60-5dea-08daa5fa8e26
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DPXc3EoXF0Bxee8mBGcuDkBrfrGwdskcwlvdgMa9kR+4ZhGFpkTy65ct/3h3n4Dq5Jx6/H2TGTKFuNY2dnw738lnMoa/GeQAO/4miYzjb8AKbdOOuXI+9TVKer7orz+SqwjydBBZr2QSb30vCU8g0BwGrDvs/SnJ2xqX7gEFgXerNpJ7T9fiWVGYrXeezmBDqM3E4VKRqASfJVLfnNFjxUUtePd52cRjb9/dhcBCCWbHT/TeFxHswisJ6Ji5p1AfMYFRbMnXiubillCPR/dBhy7GmF2JGzwYgTTwP1yIyJ9a6d2BFkRjrTNHmnYlE2xOJrCP1KE8qZYSgwbaBGxf04agvd4eIUvsSVrbkXQk1OCeom/OEUOOqIvEPPVQkGORrCBhjkTu5ouNJux0u0Jiu15wn4cav76KPZfFUmP6tOqwo5czx320V6wLS5338JCaamWaBqYHhXN6TZN+FYC0UYCK/sRgXGnDhnHE7xlrFIw2MWiY5ox5aDsa3bpBylEWZIl+3yJ5tMnDaThTekmPaFQEZ6TJROfWhRXk0BHVFGRy1SPYben6weKivcFMKxXB65r6XQEEin5nL9xA2rsGwvBRqWdULAHGDrnm6ktKleeXzdXkl/6+wb55bFMtIGnpr5xk7JzbaBJ9DzGIGfJUGGBORPoJmOJ/kuVZ1Y5TQDx9YqMUWHdMLan54A3Y88EbpqoPhlZMKBS8XuUIuhrKkWbF4luz4/tfah3OdkDNiqR6XntZsYkM7Mdosk9GMnRAOoc94fvlyLG4E8JDUxdHPyZFI0W40lB/6QxSL1BYRGwETzS9VmHMy4r5tZaZaRG1
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(356005)(82310400005)(81166007)(110136005)(82740400003)(54906003)(478600001)(316002)(70206006)(70586007)(186003)(41300700001)(4326008)(8676002)(107886003)(55016003)(8936002)(6506007)(7696005)(5660300002)(26005)(9686003)(4744005)(40480700001)(86362001)(52536014)(40460700003)(47076005)(336012)(2906002)(36860700001)(33656002)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 11:21:26.5867
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 17eb89bb-2c76-4196-17d4-08daa5fa93d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6410

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIXVs0LjE3XSB4ODYvTlVN
QTogY29ycmVjdCBvZmYtYnktMSBpbiBub2RlIG1hcCBwb3B1bGF0aW9uDQo+IA0KPiBBcyBpdCB0
dXJucyBvdXQgcG9wdWxhdGVfbWVtbm9kZW1hcCgpIHNvIGZhciAicmVsaWVkIiBvbg0KPiBleHRy
YWN0X2xzYl9mcm9tX25vZGVzKCkgc2V0dGluZyBtZW1ub2RlbWFwc2l6ZSBvbmUgdG9vIGhpZ2gg
aW4gZWRnZQ0KPiBjYXNlcy4gQ29ycmVjdCB0aGUgaXNzdWUgdGhlcmUgYXMgd2VsbCwgYnkgY2hh
bmdpbmcgImVwZHgiIHRvIGJlIGFuDQo+IGluY2x1c2l2ZSBQRFggYW5kIGFkanVzdGluZyB0aGUg
cmVzcGVjdGl2ZSByZWxhdGlvbmFsIG9wZXJhdG9ycy4NCj4gDQo+IFdoaWxlIHRoZXJlIGFsc28g
bGltaXQgdGhlIHNjb3BlIG9mIGJvdGggcmVsYXRlZCB2YXJpYWJsZXMuDQo+IA0KPiBGaXhlczog
YjFmNGI0NWQwMmNhICgieDg2L05VTUE6IGNvcnJlY3Qgb2ZmLWJ5LTEgaW4gbm9kZSBtYXAgc2l6
ZQ0KPiBjYWxjdWxhdGlvbiIpDQo+IFJlcG9ydGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu
Y29vcGVyM0BjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQoNClRoYW5rcyBmb3IgdGhlIHBhdGNoLg0KDQpJSVVDIHRoaXMgcGF0Y2gg
aXMgZm9yIGEgcmVncmVzc2lvbiB0aGF0IHdlIG11c3QgZml4IGZvciB0aGUgNC4xNywgc286DQoN
ClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2lu
ZCByZWdhcmRzLA0KSGVucnkNCiANCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 11:33:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 11:33:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415454.660036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgBE-0007Bu-VN; Tue, 04 Oct 2022 11:33:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415454.660036; Tue, 04 Oct 2022 11:33:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgBE-0007Bn-Si; Tue, 04 Oct 2022 11:33:44 +0000
Received: by outflank-mailman (input) for mailman id 415454;
 Tue, 04 Oct 2022 11:33:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgBD-0007Bd-Ls; Tue, 04 Oct 2022 11:33:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgBD-00013i-Ge; Tue, 04 Oct 2022 11:33:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgBD-0000tH-2G; Tue, 04 Oct 2022 11:33:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgBD-0003wT-1n; Tue, 04 Oct 2022 11:33:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zQYciAuSAKbLntERru6GEKewOLnyHObu+fnmv46Mju8=; b=ZTHE7mX2lNSdVGFSryxBug50IG
	gUiqs2WlWm82zZNZBlFnaEhb1pzmUSdT6RF1Tg0g37PToCF9dX+Dl4naH7TKDEGS1FOvrYtF9ztmY
	1Fyr2tkNWHZZaCd36NDn096Zh8Xdh+qc3feBEDs94BGJ6oixprEQrXXGNBFiZmKWDwLU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173413-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173413: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=d6245e36c24969efcaa835ce6e9a9c953f47cc87
X-Osstest-Versions-That:
    libvirt=30899c65a2c6860c714be14f14d97e7e2dcf9c4e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 11:33:43 +0000

flight 173413 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173413/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173392
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173392
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173392
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              d6245e36c24969efcaa835ce6e9a9c953f47cc87
baseline version:
 libvirt              30899c65a2c6860c714be14f14d97e7e2dcf9c4e

Last test of basis   173392  2022-10-01 04:18:51 Z    3 days
Testing same since   173413  2022-10-04 04:25:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Göran Uddeborg <goeran@uddeborg.se>
  jiangjiacheng <jiangjiacheng@huawei.com>
  Jiri Denemark <jdenemar@redhat.com>
  Ján Tomko <jtomko@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peter Krempa <pkrempa@redhat.com>
  Sergey A <sw@atrus.ru>
  Sergey A. <sw@atrus.ru>
  Yuri Chornoivan <yurchor@ukr.net>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   30899c65a2..d6245e36c2  d6245e36c24969efcaa835ce6e9a9c953f47cc87 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 11:57:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 11:57:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415465.660046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgYP-0001I6-Ut; Tue, 04 Oct 2022 11:57:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415465.660046; Tue, 04 Oct 2022 11:57:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgYP-0001Hz-Rx; Tue, 04 Oct 2022 11:57:41 +0000
Received: by outflank-mailman (input) for mailman id 415465;
 Tue, 04 Oct 2022 11:57:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgYO-0001Hp-BP; Tue, 04 Oct 2022 11:57:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgYO-0001UM-7G; Tue, 04 Oct 2022 11:57:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgYN-0001c1-Re; Tue, 04 Oct 2022 11:57:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofgYN-0004Cf-RA; Tue, 04 Oct 2022 11:57:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G+MSp7+2VnbPW2uF0xYzw6rUNVPDJs7WT3ii8LZZDQs=; b=w5bukcW649h6sJHoNoAffXfdAs
	IqWCrXnAxpzeKdIxuw01UFHuodAJ7YUiTdpoYtbNPYoH6TowFHFHv15Duy2/pspjSOA73Bx1pEURo
	NVVRD2hKFxnJoePtANYPpPweR0yMXwYr6nyHmW0gIFukO4T8Fr77h9sCZxbmlL2Hx4Zg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173412-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173412: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-xsm:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-i386-livepatch:xen-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
X-Osstest-Versions-That:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 11:57:39 +0000

flight 173412 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173412/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-xsm 20 guest-localmigrate/x10 fail in 173402 pass in 173412
 test-amd64-i386-livepatch     7 xen-install                fail pass in 173402
 test-armhf-armhf-xl-credit2   8 xen-boot                   fail pass in 173402
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 173402
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 173402

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173402 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173402 never pass
 test-amd64-i386-xl-shadow     7 xen-install                  fail  like 173402
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173402
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173402
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173402
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173402
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173402
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173402
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173402
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173402
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173402
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173402
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173402
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173402
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124
baseline version:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124

Last test of basis   173412  2022-10-04 01:55:40 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:07:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:07:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415477.660058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgha-0002qu-4t; Tue, 04 Oct 2022 12:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415477.660058; Tue, 04 Oct 2022 12:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgha-0002qn-0Q; Tue, 04 Oct 2022 12:07:10 +0000
Received: by outflank-mailman (input) for mailman id 415477;
 Tue, 04 Oct 2022 12:07:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofghY-0002qh-Jr
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:07:08 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ccd52d9-43dd-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 14:07:06 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 08:06:53 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA0PR03MB5593.namprd03.prod.outlook.com (2603:10b6:806:b9::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 12:06:50 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:06:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ccd52d9-43dd-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664885225;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Uc9nxCDazcXQT9eB7t1L6/2bXfrac5yeEEi2OyTHOeI=;
  b=Qhz2M/NQIxaVWgks6MjAOH1mp9S6JOlqpe1lSxcqRODxHCfv8bU8M70r
   mbuRcfu8F44T0mU9q47+HKwE0hwUDfM7mLUd8qPzgCd+JV/NjiMEtYqtk
   Te7pPBDf8H8DmdJYfMEGeCXmu31m25UI1oGciyRs2Sc+VamGaYqfIMTCr
   s=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 81925127
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:eIwL7Ks8jGNaUPu0gaH6gCClxOfnVGBfMUV32f8akzHdYApBsoF/q
 tZmKWvSbv6DMDP9c91/aYWw/E4A65LVzt5mHlFt+XowRSsX+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kI01BjOkGlA5AZnPagX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklO8
 PYbeT8iPivdnsmsyuulUvQ9n8oKeZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgNABM/KMEjCObd9SkUuC4
 HrP4kzyAw0ANczZwj2Amp6prr+WzHmmAdhNfFG+3sNPj0C9+2JDMhBVTWSBuMK0tmyead0Kf
 iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2
 1SV2dTzClRHr7m9WX+bsLCOoluaGSUTN35EWiYCQiMM+dylq4Y25i8jVf5mGa+xy9fzSTf5x
 mnTqDBk3utDy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1
 EXoUeDHs4ji0bnlePSxfdgw
IronPort-HdrOrdr: A9a23:GaxI+aMCINTtSsBcTyT155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ
 uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2cqYRJd
 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S
 zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8
 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ
 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt
 WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv70voxKhNNKWs2N
 60TJiAtIs+O/P+PpgNcNspcI+QNlHnZy7qHSa7HWnHfZt3S04l7aSHqIkI2A==
X-IronPort-AV: E=Sophos;i="5.93,157,1654574400"; 
   d="scan'208";a="81925127"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F6rwlMLp/kbN8OWP9SCX8+0Go+OrPwmLE5fryBH7eo3KQkFxqtMc4AUiL6h2IAbtbCJytTwNdNbAScwWTZKSJf9XuePcv34lYOOJo4wbpKkYxClb1H9r4LjqtEVJjqu4ZR0wI+Wde0fn/vHTig4+YUitQZ3rvFTVliPpC3p+IaSEJTm9rIHC8wEMLFGTMcvk813RAP9TOzgWGDZb5cWR+8Z3diblM06EZoGcbde2ZWRch39yT/YXhEd3JMJCPWvc91+6+nBT8s9KTIA6V4ZBKDfK1VAFFBGhcj9wKED5kTZI4Hj7XS+1mw0p8Po/vR3t5v5p3uiwF+5KcQSuI/5tjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m4iIA9BwVLc9QXtOKtR22v1ZaR9jnj1A2ju7nql2yZs=;
 b=l4ApXTXskdKROFPLSkNnQuNJSuyRBChiJuEoYHZICzOi//PSeb92Ivz+mOBb7nhzci1FIbqd7sUpb2ld16CVXzc2iUPWN76ki7k1vHyPP8RyfrXaUx1AKlRjRBYtNAfY1a8+ufVt/VQi1mZnOhHEIKgTWO2pXCnw1z/4XQjACMyGexLjot36Vo8cbjeJ0heLI/qxmMyBd+GU9dqGdCJ7GBS9gaix9/nDyOxLoACO+W+UtqI4aB64DXyP4CydmXVfjtFwhwNtGLFitjcaj7NgWhbXzjn8tgpRk1a+9k99W9P1g8YGWnc6mKX7XRSXbyKaQhefEfRtlg+aa1DJc44tQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m4iIA9BwVLc9QXtOKtR22v1ZaR9jnj1A2ju7nql2yZs=;
 b=tF0ADMxjBsT+YOXhwB4bSsYY2H49fBeOubtK6PuMaNMlfTEuTarT3sNJqRbTuh4tqnFqO4x/gOQr5Jh8v1IxnYobNHEurPalkumoXvIgJomjMM7U0HHQscrgCJFlluZ7+L5n/tGwZKm56TpW6WnliRWS6D7x9YKwVETAGPykXY4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 14:06:44 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] x86/NUMA: correct off-by-1 in node map population
Message-ID: <Yzwh1OxOTZrSypbV@MacBook-Air-de-Roger.local>
References: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b810cdce-00aa-6cf5-05a9-acc7f3dbb8b6@suse.com>
X-ClientProxiedBy: LO4P265CA0262.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:37c::10) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5593:EE_
X-MS-Office365-Filtering-Correlation-Id: f2569e3b-fbe6-484c-15cc-08daa600eace
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FyKFkKPHAXGC3zfi09Zkx8LyKa2ePXc9CV08FSdaxbTnTagcVcUn+F9uEr7wZto1JtAfT/3qY4aCfHiKVtvFB8mvuptXVZIkesJaeWd+f6n8zMU6d+zyQS5UoWSad3qcl0NtSQ4GI2EdHgKU0veLncXJeKs48AcOFb8WRyRXCO+7HV+u6MykHXlTdaxHvYWarl9614VQ0y+FKomEjw1Fy1X+77PuJ89zGUZBvtBVmh306uwNzoMO3+Clh9Ssh5Xsi2f8VvyRZtiRMUagY4Qf6IyND0Jx6UQ2LKVhsimazkVxxsJDADhK7j1bhW8eCTzFnjbY+XtvXoS57JUZYcBp8H2zZ8CS97bh2a1+q+NXZl/pOgMN/fG24vbYz7vmh1EGAAA9gyjT2b0E/tcL2lHFI8mHEt+8QuedEJ1EAF8YGE61T06zozSzI9cYzReJuRkU7jY5QrNQkgvWcV65ZbsK9J+zVQtfLIPp50orfVJGMbD7EQB7Kc4AnQRg7WCoFUJ758Zxm4UF5ylYOD305dzZ5TEFmSWg/UloeHqcb4QHXAxZ1brbCFXEiLemprwGlbBWusR7Z5Iq6+n1wrmjwsu4NhIvIY/SynPZDQUBpGWbh35EStUiGkhFyS1Q2fY4VkqAXo2xUYMgzLdTiqf3keuCoWsMgAQUtYHo2czug2tm5W/CjuvPcV24YzNh4/EpmrjSs2v7JXokjfoa8YFjg1MC7w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(366004)(39860400002)(376002)(396003)(451199015)(6486002)(478600001)(186003)(2906002)(85182001)(8936002)(5660300002)(54906003)(4326008)(8676002)(66556008)(66476007)(6666004)(66946007)(26005)(6506007)(6512007)(6916009)(9686003)(316002)(82960400001)(86362001)(83380400001)(38100700002)(41300700001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UTFJMkZDR3ZGVjVIZWN0bzM3SzJ4Z1A3cXROSk5MdXlMZGxLTlZtUWc0N2pz?=
 =?utf-8?B?YjA4QkYwYmdRQms5N2FkMDlIeERYZXNtUytldWFtbkVkY20ya1ROS3VSMU9T?=
 =?utf-8?B?NFAvWTN5ZGMwbXFMcXhIYzZkb3Y4WTgyb0I3UHVKazFrMXoyM0hkaVc2ZUhY?=
 =?utf-8?B?RHJ6dm1OTDdpeWgxNFhocFNTb3E4bGFqOGFyZ3dJU0U2LzltZFpxZ1REQTlH?=
 =?utf-8?B?dzRzc0xVaEdSUGQ0dFBpNzZJTmhQU3ZsZmtMc2NJR0M0RENuN2JmM2lpcUNt?=
 =?utf-8?B?aUt1V1J6SjdvWlBlNXAvZzlVRW51NWNmYzdhaGxvYmhXd0ZvOWJReVQyMTFQ?=
 =?utf-8?B?UnM4bjhuR3dIeEhMaG9rZWFlbkd6eEVyUi9QNWFNNlNDaEFsak1wU3ZHbXJU?=
 =?utf-8?B?MmRkcG5tT2RlaGo4S2p1dVpkVGxnbGtIOWNneUNmSkVubFo1c3JNRGtpN3Zp?=
 =?utf-8?B?K0ZZb0V6QWdJTWdleXJOK1VnSEpEVW5RZVNiczA1a0MrZTlwSGhDejk2Z2tO?=
 =?utf-8?B?R2FjKzc5ODhBN2YydVhoOFFFc1RiejNFUGdHaUxJanlKZzQvVGk0ajV2QUVM?=
 =?utf-8?B?Rkw0c1lUeUl2aVEyZnZhTFFlUXpEamx1UldzbGh4TzZRYmx1QndvU2FneGNF?=
 =?utf-8?B?Mk81bE11RVFwZVViajJZek9RdVFGUldQVWtoRkNrQjdidEFYbTNTL2JSQm44?=
 =?utf-8?B?bU5xWWdORHVYTm5vMkxmdW5sdDRLSDFQUFRlc2I2S2lBKzZWV0MrbXZWOVB3?=
 =?utf-8?B?REltMmdpWTNlekdTWTJ3ZkFmQ09iWTZYWFdncjlESnQ4YVg0OGljT0dSL3l6?=
 =?utf-8?B?SE5WT2NqNDRjMEhQYjZYM2gzWTRLMXQvK3dMQ0NQMW9EcGlKeXcveDhobzFi?=
 =?utf-8?B?N0VTSE8zWUNjVzU0NkJteGRqU3J3eFNxSjJhZHZkeC9rVXc1cDFNa2N0L3Qx?=
 =?utf-8?B?TDZtdkVteUprVUZVZXlEVkZMait2Um56QXFkNWw5dlk4cmNhK0x4WDcwNFFh?=
 =?utf-8?B?bE9DUGhBUklSakJHekZDYnAwdVU5UHp1di9KaUxoMkhSbkhsVzJDSU0yY0hn?=
 =?utf-8?B?c09xYzJBU0hRdDEwRzhLdms0V1AyakdLZ1lBV1RMTnJZNkNsZ1BFeGhJRlZ4?=
 =?utf-8?B?SEYrM1pLaFRsMHFqNHhPeTRaKzRuejRLNE1aQ1dEQWwrbWJzMkg2Mk1vckZl?=
 =?utf-8?B?YTZjYmhtMDlPY05NNTJZRHRZSXhQYnhLMUhpcEQ4UFVPYitLd2JrUkNIRTJC?=
 =?utf-8?B?RkZEUVJOQ0pzUThETjJFem8vQ2ZYSlJTdzViRVc4RTNlMUZISm51YXZ2RmpM?=
 =?utf-8?B?NVNvWDhZcUVJK3ZvY0xpNHZQM3VBYmRpcHg1elUvK2w3NWxXblFqVzZMNEo2?=
 =?utf-8?B?b2VRd1QxQjgxWitlalU4ME9XVDhOY0FyaDZ2MVljalZCcGFka1F2Zm5iem54?=
 =?utf-8?B?aThUekwyNXR4Z1YzU3dXNkZ5R1NiQXFsRHk1Tk5rRkJ3S0RiTVp1Tlpxdlpx?=
 =?utf-8?B?c0ZNWGtHVWdpOElTMDZEbjJQdzFHMUdlR1NDNm9HM0ZpMUZ2ZjlJUlUxQmhG?=
 =?utf-8?B?WUEyeTBPNDkvUTBRaTNaOXlhZUozY2VDT3l4L3hQemN1Z2RlSENYUzR2d0dv?=
 =?utf-8?B?OW9FLzJMVWl1WFV4ZXYvdzJyTU1MUkE2YVB1L1Fld0krVnc0SGdxYWh6UlY1?=
 =?utf-8?B?K3NtRzhmV0hEbzBLWm41UkVhTTZEeEVtMUZLMHFOZnRnaThieG8wMjdNb2Va?=
 =?utf-8?B?eldrQWR3M2tBSVRvcFZVWko4U216TzZPdzhRSTlNNVhuQlVrOE9pM3BJd0gw?=
 =?utf-8?B?enQ5aSs5OGR3djBTOG0rTnczcVB0RGNWK3VUWkNaTDN0TE1XKzdZZzQ0K0FP?=
 =?utf-8?B?WWI2cDA4c3RMY0xtcWxWSVMwZ0xEVmk5MGdpazB5QUFONFp5ZS9pUkZ2QUZG?=
 =?utf-8?B?OThnMkZVL1l6WlVFQVdQT3NkQVc3cWZQQjM4RUdsTGhhSkxQSDQvVkJTbDli?=
 =?utf-8?B?REFrWGszbndGZXpkL2Z0NVZrOHI0bTF2bWcvMkRKWmRsWTBZM2g4MmRXL3Er?=
 =?utf-8?B?dThVeTlmalQ5S2VhVHppankyWFRMV0JMUFdEUEs3N2Z5RHkrUk16cDVwMjBU?=
 =?utf-8?B?akcyYmh2aGlpdUcrMFZHOEpzRnNsbTRKY3RiUUZQNTdEQm4rVFhqWWlzODhh?=
 =?utf-8?B?dUE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2569e3b-fbe6-484c-15cc-08daa600eace
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:06:49.7337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yaJEylFHygfnGqNtEKXgW8zZV1kKmb/twC39thZz1nXGq5T4VPoOorcc5Dh+O6KKT6l/pVmS3sNl9XblONtzvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5593

On Tue, Oct 04, 2022 at 12:13:49PM +0200, Jan Beulich wrote:
> As it turns out populate_memnodemap() so far "relied" on
> extract_lsb_from_nodes() setting memnodemapsize one too high in edge
> cases. Correct the issue there as well, by changing "epdx" to be an
> inclusive PDX and adjusting the respective relational operators.
> 
> While there also limit the scope of both related variables.
> 
> Fixes: b1f4b45d02ca ("x86/NUMA: correct off-by-1 in node map size calculation")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

With this fix sabro boxes now report:

Oct  4 12:05:25.087462 (XEN) System RAM: 32429MB (33208204kB)
Oct  4 12:05:25.087482 (XEN) SRAT: Node 0 PXM 0 [0000000000000000, 000000007fffffff]
Oct  4 12:05:25.171468 (XEN) SRAT: Node 0 PXM 0 [0000000100000000, 000000047fffffff]
Oct  4 12:05:25.171489 (XEN) SRAT: Node 1 PXM 1 [0000000480000000, 000000087fffffff]
Oct  4 12:05:25.183432 (XEN) NUMA: Using 19 for the hash shift.
Oct  4 12:05:25.183453 (XEN) Domain heap initialised DMA width 32 bits

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:18:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:18:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415485.660068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgry-0004K3-3t; Tue, 04 Oct 2022 12:17:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415485.660068; Tue, 04 Oct 2022 12:17:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgry-0004Jw-16; Tue, 04 Oct 2022 12:17:54 +0000
Received: by outflank-mailman (input) for mailman id 415485;
 Tue, 04 Oct 2022 12:17:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofgrw-0004Jq-Ur
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:17:53 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8fee6971-43de-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 14:17:51 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 08:17:42 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6673.namprd03.prod.outlook.com (2603:10b6:a03:398::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 12:17:39 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:17:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fee6971-43de-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664885870;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=C67pux6E9DH50pywKQQFU7AKr8zmVN0Gsf/T3qfFnNU=;
  b=ewtmi+r4gac0RAsrnvx313cfUqOskgohOhaBihuokJoSy11T9RzApdAf
   Rvu+QFfTZ4INPN2FyMlupsvCKb0S5MkdrOuP5DXSyOODWiIGu1JVhCRc5
   iHAcZpUsKwYl81Z6uau42IB+lYLv5EsSYtzWlQac5/nWrJH7dn+Xf1dp2
   g=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 84451045
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:WPJ9uazNd67sh8SPV/J6t+csxyrEfRIJ4+MujC+fZmUNrF6WrkUAn
 2ROC2+CMv/fYzf8KdAnbtngoR4Cu5TdmIc2TlZpqiAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFsMpvlDs15K6o4WtA4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwx+9cEWNx+
 /MhMw8SaB+T2vOR/rKgVbw57igjBJGD0II3nFhFlGicJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuvTi7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVri7x37eTwEsXXqoQPqeU9fxh2WfN7W44VSYoVxyEhemQ3xvWt9V3b
 hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU331y1uPhTa7OCxQJ2lSYyYBFFIB+4O6/tF1iQ/TRNF+FqLzlsfyBTz73
 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A==
IronPort-HdrOrdr: A9a23:KkhHFKirKWo26l+GNRN/hnNgF3BQX0F13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7EZnichILIFvAa0WKG+VHd8kLFltK1uZ
 0QEJSWTeeAd2SS7vyKnzVQcexQp+VvmZrA7Ym+854ud3ANV0gJ1XYENu/xKDwTeOApP+taKH
 LKjfA32gZINE5nGPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SuV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A7eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1whq7VBaM0pd
 gsCZ4Y5I2mfvVmE56VO91xMPdfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q
 6xG29liQ==
X-IronPort-AV: E=Sophos;i="5.93,157,1654574400"; 
   d="scan'208";a="84451045"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D6/TgnnZ1E1AoizlrJNMnvhPAIfdBqd83wBq8klm5eWJ3woQVTiJdp1Vtif6FVWTJ8Azn/HayJwPYOKCzmhz7kzc5RryTuWvNHv+01NYhLyAdA5J7yP9/++lERwXLvDIaWxUeo5BrCHnyatz7SJ+3hzkJ6OAx/Loqpsx1wEVGCIiYu2Xk2EWzZybjTrSKLCcT08/5euUf7k4+VvpWj/3iDOd4YmUb1DjYKvP5Mux1mHIGhn7ma+twvBuVH7Z2uedtpC0CYOMhajsIFNnIAeNeqp7EjER400pWYQkaNpW/PLYMAhQqJ/u60IMd30B1DpIAfHdP5U/oqIZPTLVMZIS4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MzJtNBInalBbzFlgsONfFl9I1w4GX2Atzw8fcSu4wYc=;
 b=H33dJAj2pAjN/+7iZ8/RJK46H8C/yMNczbK+LXHf9qdvWCT5QqWK18xRDvUsQqOVdBeuuVKYLXE43NPJz50rjVaHZ+/FbeeNQmLwt0oRu3BNCu+/bst6Dl8jgwg7YhM6RtydqEMngE9wEVoF1UL06a4y2NZmUx/M8psltJZ1KIaASYGal8R2t59/xMz/1YhJrvqDxMeqmeOkmuBBZ1Py1goDkVegbtPGMV/I9Us4XPJwp1XY4VNH1ALpjPOycfteMk1BDGKNtVEC0s5RVQK3I8JCEbzSA229owynGdQWWGir6j3SsK09X5yZQBKqL23k8XyxKpZxF5YHOXnPVXkUAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MzJtNBInalBbzFlgsONfFl9I1w4GX2Atzw8fcSu4wYc=;
 b=IZtwb8BMF56YdJCHGXa456fmD+Y4/Mmc7yQ1vYUBoFObHymzNQnW5YnegNAHr9oYnyVfa1m3XQAmwjnKMbjp2P9ifmNiMJUTXbbAkPIErrLmFIzIIXX39yEzP3qH1xyOeH8FGIKH5Qmk7iSas91vvE3s9I+8cQ1+xDKmQVukfw4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 14:17:34 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Message-ID: <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
 <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
X-ClientProxiedBy: LO6P123CA0050.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:310::6) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6673:EE_
X-MS-Office365-Filtering-Correlation-Id: dc249d05-2e09-4604-04e0-08daa6026df0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9mD92CtjDMiwJBR6k9LQcjOVJwr+9hq0uUZxd6y303koAfJzZAGJYmTGyZQXJQZsP+nMnAPtxTyItdf7j1iy3tLxo+eZnqq4uXiowng3zMwqd7FXgubdWEGeWepLs6QXl/1DdepUMl28HYguX6VBdY+5haU2F6COxeeZbrUouFmPQK+LCnE7NRzmPIeovF3YD8YcvRKsl4EndRoJeOjL6bDpPF6uerzyCS/4g8uS+jHHs3OSPltplSGTKfRrmHSiymHZyymx9HJBEhhY3BH0xCLmpGwiCl9PFsMJqg4VqzAb1vXbgDkQ0Em+yuOyPsjISDdMrV+F7Y6ioYbPQLTcwHtwLDYNKuEoW6eHZ4XJYk6fdsCLbveRReG56wgu6B+3ZL9bqm9QKkQvQ/f328LZJAlmVx9Xo8sQmzVWKdTWPCyWL9eLkzkpBN6o4DRdTWCixrddKOytBfEca9xlM3hK5MigFRLdb1xpnqdLSVfx1mG2zdfV/gmhnXBLzur4hAki5YJhDHtXOWHSxCt6s0IQVQd4xzor2kM7zCEUVJcYmqZmwpXXtc9br1WewpPYvhsCZ/lBNmQ5qiimXI68fLQEK4S2NDuhoj745JaAXOe9ngovJi0w/dM+8rfcgPGCAAx3fV2KloIIziBkQ98yplNN7plIPevQDhNPwkZ/oHdZqRBGqiSF+hJqsWxUDBH44iCP2/ZpQM1jzEiQOzoQgpl7hvKqrYmI5WuFLQqBvBIuZf2w4BN5GzxYJOHulzFY79RocBS6Z/OgJgMVqzsgSYweXw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(366004)(346002)(451199015)(2906002)(6506007)(53546011)(26005)(5660300002)(6512007)(38100700002)(41300700001)(9686003)(86362001)(478600001)(66556008)(66946007)(82960400001)(66476007)(83380400001)(186003)(85182001)(8936002)(8676002)(6666004)(4326008)(6486002)(6916009)(54906003)(316002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V0RlMmNJVGF1VHBMS3duVE9kK2VrNk4vdmlKZlhlaGJDakZ0cEFFbzNnS3lK?=
 =?utf-8?B?c3NnTEVJNTd6MlZCS3ZIVTNMR08raE43eWk5Sy9tSlZGMXEzTDZFZmxGKzJs?=
 =?utf-8?B?Z0ZES3MwazlPYjBma3ZXODZuekxRRmNmTjRUUFdRYUh5WnJZZzkvSm1HNE9U?=
 =?utf-8?B?YzRzSjhMK3YwQ0NKWXlGSHFRUVorUFZrTERsOHdtOXVidWNXQ0dUMFYybi9M?=
 =?utf-8?B?dTVvVUllOGpkWjBObm5wNWZkOVhDOThsZVVseGUrWXRRODUvQ1VxMUt6TkFx?=
 =?utf-8?B?NkRCK0s3c3lnSy9sdzY1RXp5L2cwZGhuRGd0NGNPRlF5alpkRU5oZnNscXps?=
 =?utf-8?B?bStub3lHcWkvcjRIV1VvWHQwcnZ3NXcwNWIyQ2ErR1MrZXNhWmc1WnhLM3pI?=
 =?utf-8?B?V2p6OGFYcVhxSXpVVVpMSFk2V21uUTNiSWJkbmtPempvQVY3SEVNbkx6b0tB?=
 =?utf-8?B?VlZUNWRYZ3FjeGFueGlqRTJhMmdla3ZaR0hJUGhwaDFvK1ljZkNtQmZNOWtj?=
 =?utf-8?B?TWhtbzlLeG1WQTNKUTJyWENiZWprUXZOYTYydjZScFIyalFNUDk3TkNZMXY3?=
 =?utf-8?B?ZDRQQ1h6Y3lvMlVyRmh1bWVMbzRTQ0dUYlJkZ0Q0QXEzSVlUdnpQaFNyNS9I?=
 =?utf-8?B?SXJ3aFQ5ZGtUMzlESG1qTmNreTZzcklWaHg4VVM2dU5OOU1sYzNqdE9ESFNr?=
 =?utf-8?B?TUpud3hpdnlOZGRJY2tDVlFCU3lIZ0J2UzFIL0N2bjJzdEpaekZGaXlLdGVF?=
 =?utf-8?B?YldYbG1sbERpSlVRY2tsOExQOTZQZnUzVFNMWjBsL3NsSVFqOVZJZGl1YzVh?=
 =?utf-8?B?MXRkRHY1ZVozcEpVQ1JaNUVhY2ZiNVYxU2VROGpRdzhWU21PUWR4ZUZKY3U2?=
 =?utf-8?B?aE5mZEtBdEZqaXlTYkNGVm56eS8vVkZBNG1oaEp3ZndBdkYxMmhDcmcwaG1u?=
 =?utf-8?B?MkcvL05DcHhnNXBHUi9xaHY3QUNPN293SjY5WTFRZGx2Wm05RmxmUGR2bHBD?=
 =?utf-8?B?MHBGYlhPOG4zRms0NDV3byttbzVGYXZPbjFMaWtVeDlVcklLL0V1ckhUK2hG?=
 =?utf-8?B?Z1VPdnJ4cDg0MjRCcUpqbFFkVE1BK0YrWFl5bHNoampHSk43QTdCY3VTcnFC?=
 =?utf-8?B?MmVrS2pWWXgxczU1NGtNVVRJcGhtREZrUHJ1TFMwZFlQWU1rc0Zma2o2V29V?=
 =?utf-8?B?aW1lVHZ5cGJWWmY4NUhDN290YSt0M2dpZnphVDFMeEZmekhuZFM2UjdYL0JG?=
 =?utf-8?B?cnZ6dzVOZysrbzZFMEptWG9lUHAxdCsxbTdZNnp0UXhXYndpNEpEUDNBTUhC?=
 =?utf-8?B?MDY0QUlhZElJRktOVjM2eE1xcEhvS0cralpyUWxhOS9rQlArdmtIMU9veW52?=
 =?utf-8?B?U3dhdlZtVzJ5OWVqM0ZJQzYyQW4zUG1wVTFiZ00vK1BxUU5vL2hhUlU0QXU1?=
 =?utf-8?B?dHZVTW5mLzF1cGlOanNrVWVTbkY4UG5mL0pMYVRNRnNLNmhyVjFjWmRpdmlm?=
 =?utf-8?B?RW0rUkRuTjVCR1pkQzlzOTlVRy9vL3g3a2pMZncrelhQVmIzYnpiLzJxcjgy?=
 =?utf-8?B?aFh5dXM0bU1vNHBOMjFIdE9EVUpTNTc1SUxvR3AxYVA3dXRTekFZZUpFTE1X?=
 =?utf-8?B?VEV1QWxDMEsyZWdMK0VtY0JtdUVVWDRoNmRmdytZV1Z2RjRhSXUyRU1DdGx1?=
 =?utf-8?B?bHp4a1ZHM2pkT0ZmOThRcy85TzdXTFBBNWl4YWc5bm1oUlNJMGNHVGJjUlli?=
 =?utf-8?B?SUpiUFg5N1l6enpSUm82V0NYa0hiWTVhQ3RVWFN0eldsZWFIMXlIVnpPd3Aw?=
 =?utf-8?B?Q2hsMm1KSm5LVnkwNmtud0I3YXhvbW5BTkl6Ny8zK0tUT2dVOFZVdUFaK25X?=
 =?utf-8?B?TXZtRDhnL2wvWjUyc0dZb0tPTk10NHF0Tndnbm1NV0dQZjdVYU1FQTlHSTV3?=
 =?utf-8?B?TzBsd0RiM0Y1VmZZWHVESDlTSER4UHE4aU5vVFpnVTlxNzNST0FpdjdzeWs1?=
 =?utf-8?B?WTBaakN0MGM2NklUSzBadWkzZTB2WG5iMmpLc1BwVGRzZmdycGNVSk5rdktq?=
 =?utf-8?B?UGJ0aXJVZ0dqOWNaTlQwdVdRaHU0RGUrbVhnMlJNYWZGWU44b25tV0RKRjRK?=
 =?utf-8?B?eFROKzhsTm1JMldOVlpCRFFSbTFrQndBWUFTbGhWWUtHclRkeUNWNFY3aEZi?=
 =?utf-8?B?Z3c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc249d05-2e09-4604-04e0-08daa6026df0
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:17:39.4370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W2Cuwamy2ntq3SGv+5ZFgwDmSqVcMnfeDekdI7MFsDeT53VLKs7UYnRb6ruRYx9ufEgPeH7k9SSMv1aBmF4TKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6673

On Tue, Oct 04, 2022 at 12:40:10PM +0200, Jan Beulich wrote:
> On 04.10.2022 11:27, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
> >> On 30.09.2022 16:17, Roger Pau Monne wrote:
> >>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
> >>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
> >>> devices used by EFI.
> >>>
> >>> The current parsing of the EFI memory map was translating
> >>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
> >>> x86.  This is an issue because device MMIO regions (BARs) should not
> >>> be positioned on reserved regions.  Any BARs positioned on non-hole
> >>> areas of the memory map will cause is_memory_hole() to return false,
> >>> which would then cause memory decoding to be disabled for such device.
> >>> This leads to EFI firmware malfunctions when using runtime services.
> >>>
> >>> The system under which this was observed has:
> >>>
> >>> EFI memory map:
> >>> [...]
> >>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> >>> [...]
> >>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> >>>
> >>> The device behind this BAR is:
> >>>
> >>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> >>> 	Subsystem: Super Micro Computer Inc Device 091c
> >>> 	Flags: fast devsel
> >>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> >>>
> >>> For the record, the symptom observed in that machine was a hard freeze
> >>> when attempting to set an EFI variable (XEN_EFI_set_variable).
> >>>
> >>> Fix by not adding regions with type EfiMemoryMappedIO or
> >>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
> >>> be positioned there.
> >>>
> >>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>
> >> In the best case this is moving us from one way of being wrong to another:
> >> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
> >> legitimately covered by a EfiMemoryMappedIO region in the first place,
> >> which I'm not sure is actually permitted - iirc just like E820_RESERVED
> >> may not be used for BARs, this memory type also may not be), whereas with
> >> your change we would no longer report non-BAR MMIO space (chipset specific
> >> ranges for example) as reserved. In fact I think the example you provide
> >> is at least partly due to bogus firmware behavior: The BAR is put in space
> >> normally used for firmware specific memory (MMIO) ranges. I think firmware
> >> should either assign the BAR differently or exclude the range from the
> >> memory map.
> > 
> > Hm, I'm not sure the example is bogus, how would firmware request a BAR
> > to be mapped for run time services to access it otherwise if it's not
> > using EfiMemoryMappedIO?
> > 
> > Not adding the BAR to the memory map in any way would mean the OS is
> > free to not map it for runtime services to access.
> 
> My view is that BARs should not be marked for runtime services use. Doing
> so requires awareness of the driver inside the OS, which I don't think
> one can expect. If firmware needs to make use of a device in a system, it
> ought to properly hide it from the OS. Note how the potential sharing of
> an RTC requires special provisions in the spec, mandating driver awareness.
> 
> Having a BAR expressed in the memory map also contradicts the ability of
> an OS to relocate all BARs of all devices, if necessary.

I've failed to figure out if there's a way in UEFI to report a device
is in use by the firmware.  I've already looked before sending the
patch (see also the post commit notes about for example not passing
through the device to any guest for obvious reason).

I've got no idea if Linux has any checks to avoid trying to move BARs
residing in EfiMemoryMappedIO ranges, we have now observed this
behavior in two systems already.

Maybe we could do a special check for PCI devices and allow them
having BARs in EfiMemoryMappedIO, together with printing a warning
message.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:18:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:18:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415491.660080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgsh-0004qR-FE; Tue, 04 Oct 2022 12:18:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415491.660080; Tue, 04 Oct 2022 12:18:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgsh-0004qK-CY; Tue, 04 Oct 2022 12:18:39 +0000
Received: by outflank-mailman (input) for mailman id 415491;
 Tue, 04 Oct 2022 12:18:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofgsf-0004dy-EN
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:18:37 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id abc477ba-43de-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 14:18:36 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7874.eurprd04.prod.outlook.com (2603:10a6:20b:24d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 12:18:34 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:18:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abc477ba-43de-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KB5nko91p9b+POCA/nBO/BwJhXrVn50vI+ZBrtoEUk+yMmdFv7VJgT+pLComn0tcMB9O1AdaCVTXO2c4U1d3J1NpefEQuTmWVvIcFBJnKVkcDO5weCLLnCGDaGvi1E0n54eGE8nOdLFRLvd1or89tmkWIrnxn+wKcDKFbJj40LnjAen/dYaB9IOXI/VCEymxIknUAaePxZuTIW8fGETnYn9kLgfrkXVdbj8waBxhsO2Zu9p5Gro5rWU0LWGnfBa/nXjTmubZDgPYeefbgz0+lcvYGaKum+kINtx+1VyHeF/Mn38uvlmfQJq2x1/tTEnH3uRlc7da6XKWonVS1/iGXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yVbNDry6PEnyQE/A23dPIxuY1Ivnj4hf+RYO4PksW9w=;
 b=PC+VSSqdv/3/0EYuGZlD78rp8HnLu7v7ZTnICRHwMAwR44UYqbwXWMU3UX5I6pQjpwGcr9Qr1roIrIth2LnuOkbvy0T8WNmSq5CecTthJLNCmcb68liHNv/1n81fIi1oPMMAFxAfo4QqDJEnlPH4AwFAeVf65QYleHXZauLOjBL73c8MW57Zd3rZlgB80/E0uVofNeVGRXgwrQbcLA4rNEO0mjvSHKJDmbhHmeW61XeTTQeft/IhlmqTST+mRgHu1RExKul5flGjqKLT1ImYwyKvvY9j9NGUDfXuwL/rOLVd8sgvxU/GQhkAP4MNE9PV8nJSxbiu0wVL2RPpyVyLMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yVbNDry6PEnyQE/A23dPIxuY1Ivnj4hf+RYO4PksW9w=;
 b=I+ibPiRQwJXxr+I65GVAIQ5MyQxYNaHo/DpU5Rhy4qlmGEiqcQ0qmM7J9vswJfHi8IL1YHL8v5Rlb3YA4EnGJRAIXzqupj4ImWXZ6IgR7blUsaQj81HJ12wwqc6J75gR5BzyJZHcjMA2dn3gosMefCqC7AsKP9bCYuyg8RwRfVeZL/boHE1OiRWF5gUKXx9m6JfEvZxymygh6hKDa3H9g/ZuBEa4E6TSgfck0dnVz28Skq4cmTv5JQLDa3UzflhpLXSYTj88PAj2qISUI6J3HVx8ZtVw68MaEkKJnLaAqIeI7z40y+p0ZLzpAXtd8W3y5L7cCiCLytxCWQsUXnAT6w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
Date: Tue, 4 Oct 2022 14:18:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6PR02CA0020.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::33) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7874:EE_
X-MS-Office365-Filtering-Correlation-Id: 608632a6-94da-4dbb-29a1-08daa6028e8b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gSoHqGXsxN0Co9ioLSnTKezwTgprbxyGytigQ4VQiZHblEpdAddPKVUHwAMAPicQdh0GDL8h3Ozy9y5tUN9MVLZQ9Fv8SLt2zsjcvLc54eI4N2yyt1XRFBN436SdoROTwz3M2VQuStg3/MjNvoWo6r5y3Iplcnbbykp5PbV5fW9FmnbeNYVEDWaqe4D4r+EZU9Rywt8kREuD28g7GuMtsi+NIYjZgX1buyhpYZQc/M2ILhtFQS8uiG/Zhmz/NLxFHN2TNtD+B+YZIC9Nguilx+Cp8lIsX+mt544Au+BYtm9nkBeiqIKP5kGmMTXzqbKtMHQWU64KyhcKYcE5nYS38c5hM0YFZ0A2L9tSvf1vq9HLvyB+sO0etGzekuz0c7b2Cy9qsF0YTuY3ntPhvg+TRlfFiN4akM9Sw2LzAe0xChxvPl4AV38Wu9cT1JwpVXJ9a41tn6K9mEk9f7U71UAHXMpsbMLHTnGh+UJ6ASMSdH0EnPfdpVafRaVWFMihUX6DZ7AQdwLCpaW0YJsfMljuh+12ZKRW2PQTxfYWZqh0+4KrC0yBmW/H30W4cUExHHgxzPod7ibKujBzNwtQvjs65t/LK04vdkcqnxFFtszjPr/DZjebTHbGBlbkLFfa4GU0WEOWAw/B0NX0ZCXKddPxY1qZSGEhEfLH188WsTggUKw97+GQqEL433TIB5vDtywf6DEf7VtyZNJUMU4p/192hXidBcYk08tp+rNjpcl+gkPVFk6h6g7f37xjGKDcPPQc4TP/gKgbOKscD+RXblvfEQ/6+qdKeLBwq2B5nW2yVdw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199015)(31686004)(2906002)(5660300002)(316002)(4326008)(8676002)(66556008)(66476007)(66946007)(54906003)(6666004)(6486002)(6916009)(86362001)(36756003)(8936002)(41300700001)(31696002)(478600001)(53546011)(26005)(83380400001)(2616005)(6506007)(38100700002)(6512007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVdEVU05ZmVUdDhlK2lSa1lWNXdubm14a3U1TlRTV05pZ1RmZHBJOGxWLzM5?=
 =?utf-8?B?a3ZPOXFKU3RSUXQ2OHRwOE81bmo3bjFSSkNSVXo1amZySURtTlM4ek4yQXRI?=
 =?utf-8?B?UndEUWoxRGFGTWQrQ1BLdHpXdDduNFRKYVBkWHJpWUpSTUVkOUVEaFhZZ09Z?=
 =?utf-8?B?b1dEMGltei9GT1J2VGI2NFhoRmdkOHB5NWJIcTM0NW43bTVOcWdicDV4NjBX?=
 =?utf-8?B?N0V4RXczV3BjSTFJZytQMWxxRFF0Z0duUGhZL2x5Z2wzbFlDeFE1U092TU5p?=
 =?utf-8?B?OUtTbTdVZ20xcm9IeWdjR2RTUlQvNUovdjlCQ21oZFV1WEZoOWswUW1XYlRz?=
 =?utf-8?B?VDdkOXZ5NzlnVWZiNlY0YmRwVjZlQndlaFZza3VlUFZRL1ZtT091YjI1Rm5H?=
 =?utf-8?B?Y1hxOUxkNkp1ZTVSV1dRQXpTTmd6aDA3dG81aUJ2MkJwNkw1dTlOTDBOcUZF?=
 =?utf-8?B?KytjaEJNN3N0NG1SMW9vWkx5N2drQU4wZmMyenROMWZtV25lVDNWUzF2UFZ3?=
 =?utf-8?B?VG5tNGp2ejlQemxTTndpU283WDcrMEJJa2gzNUFQS0J0aW92Z05iZjMwUnYz?=
 =?utf-8?B?eG1FL1ArWWloczhvell4U0Yzcko1NnBublh3dnBlZFo3ZzVXem14cmdYNEZm?=
 =?utf-8?B?Uk8vdW1mNFpadUg3Ymd2YzcvUFBMRkloQTlLUjFPazhybWVmTVFTckJHa2tq?=
 =?utf-8?B?b21XRXF5Q0N6TWJITjNpU2ZJdDUzUDloYzFMT2RKUDhNZTBoZXZNRE1hYkZF?=
 =?utf-8?B?RFduUWJCMFl5VlJpTVZMd016bzNkdlRqWkxpZUlQSy9BUjcxSlg4SFhFMVgw?=
 =?utf-8?B?MGhQQlVoUEJFMEpuTTA1RFJISURGSkoyZHk3TEl0UUVwNkpHSGlsY1pvdUZL?=
 =?utf-8?B?WlZ5U1poL09aQktWTXh5OTA1aGp1OHdkVkdMRS8wa29UaHNPMEFrcnh6UXZl?=
 =?utf-8?B?cjIwOERyakNZakZjQ1poYVJwaDdGYTRvQ3l4VHliUmUxUGkxbElFN3IvQmZn?=
 =?utf-8?B?RXovckRXaHF1NXlsM3IrQ2V4Q1ZGbWNHSWZ1REcrRFhGOFVEOUJITkxiY05O?=
 =?utf-8?B?MTF0c3VYZXAxVGNWeWxMTEkvazlEYkx3UzhHc2g1ZFM0WVNpUjI5ZmNCd0c3?=
 =?utf-8?B?YTU5TmZhekpkM0lMU1MvdllIYnNORzk5TjM0VjQvYzBzbnFGSkppRVR2UVZJ?=
 =?utf-8?B?UVZWM0lvRE1mMTdpa09QQnlPbXhQUG5TbnV3aWMwL0pnQTRKNWxJYk9PVEVp?=
 =?utf-8?B?aEg3MmZHekdqaDJIekdqV3lFQlZEQThNN3NZUVNTaEI5QmtzdzZzb29HNStt?=
 =?utf-8?B?RVhsTjhmcDQxWmtqY2RlWDJvd1U3a3lnOFhUdUlpamRzYll5a09RUW1IYWt2?=
 =?utf-8?B?RWZ0bFZKTENFZ3RBazR0WjBuWXkzd3FScDUvUXZad2x1WW0rT0doUmRmTmZr?=
 =?utf-8?B?UG1QRmRLcnJ0YTFkQVFCK2JhTUZLUE5LVC9KN3hIejNyK0x5V29yV2hsdU1E?=
 =?utf-8?B?VWc3NEhZZVo0RlFRSGJSYkg4MXJ6RHdGUVg5YjRRT1pTVWJjeGk0YU9kd1dI?=
 =?utf-8?B?cUovN3JyZkI5SjhldS9NbmU0Y3BVTS9MZGVtZ1FRRkFNbjk4Ump4Qmd5c0NV?=
 =?utf-8?B?VXpPblY4MzQraWs1M3psdFV3dXg2TWc1Yk0rTTRZRWxqdEowbitpZUN6cU1k?=
 =?utf-8?B?RkdjL1hwSGJ1NUNMbTlPZEJHcHUzOGlCOGFMQ2k5bjgyai9UTldLMFJCTzZt?=
 =?utf-8?B?dkdzVU1rK3ltQXNOVmxxZGx4cTJGM21VTFJOV2EwTXowNm9GbHJ0ZHNzVEF4?=
 =?utf-8?B?bEJNVyt0U1BXMDZCL3JyNFhyQk5LbXBsUFY5RWEveUo3WWllQjdlc3VPZ1c3?=
 =?utf-8?B?MWRGNitIWDRwYVFQOU16bE51Y2JDa1dDT3pBR090VVhHYTNGOTQvdXVEaTFT?=
 =?utf-8?B?bmM5Tko2U0J0UGlFU0huYk5hb3BJdFdBKy8xTmhjcXlEUmI2R00rRjBDdTFo?=
 =?utf-8?B?SmN4ckxlcGluOXYwUlg4SFpuc1kvN0drOUxMSEJMVmFSSkh1R2xPRGlIcloy?=
 =?utf-8?B?VnFLWGs4UWxFQm4yN3Q3UTltUDVoaloyS3hyTFJxVXkxeTNkVnhMT0lJSktE?=
 =?utf-8?Q?inuJJLC/BjzR/HAq+NEtLOJQ1?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 608632a6-94da-4dbb-29a1-08daa6028e8b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:18:34.0007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iqGMCOyGAGyVSZbET037j7wX/oCPOIV9MEXx0etG7hsxR0v3HTdV2eE1iVoYAwEOt/73WnK/HP6VPNIajnCOcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7874

On 04.10.2022 12:54, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
>> On 04.10.2022 12:38, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
>>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
>>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>>>> runtime which was re-used for other purposes, make
>>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>>>
>>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>>>>> dom0 doesn't try to use it either?
>>>>>>
>>>>>> I'm afraid I don't understand the questions. Not the least because I
>>>>>> think "it" can't really mean "dom0" from the earlier sentence.
>>>>>
>>>>> Sorry, let me try again:
>>>>>
>>>>> The memory map provided to dom0 will contain E820_ACPI entries for
>>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>>>>> overwriting the data needed for runtime services?
>>>>
>>>> How would Dom0 go about doing so? It has no control over what we hand
>>>> to the page allocator - it can only free pages which were actually
>>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
>>>> DomIO - Dom0 can map and access them, but it cannot free them.
>>>
>>> Maybe I'm very confused, but what about dom0 overwriting the data
>>> there, won't it cause issues to runtime services?
>>
>> If it overwrites it, of course there are going to be issues. Just like
>> there are going to be problems from anything else Dom0 does wrong.
> 
> But would dom0 know it's doing something wrong?

Yes. Please also see my reply to Andrew.

> The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
> know it's required by EFI runtime services, and dom0 could
> legitimately overwrite the region once it considers all ACPI parsing
> done from it's side.

PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
only appear in the machine E820. In how far PVH Dom0 might need to take
special care I can't tell right now (but at least for kexec purposes I
expect Linux isn't going to recycle E820_ACPI regions even going forward).

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:21:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:21:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415501.660090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgvP-0006KL-25; Tue, 04 Oct 2022 12:21:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415501.660090; Tue, 04 Oct 2022 12:21:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofgvO-0006KE-Ve; Tue, 04 Oct 2022 12:21:26 +0000
Received: by outflank-mailman (input) for mailman id 415501;
 Tue, 04 Oct 2022 12:21:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofgvN-0006K8-OI
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:21:25 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2044.outbound.protection.outlook.com [40.107.104.44])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0fe69889-43df-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 14:21:24 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7568.eurprd04.prod.outlook.com (2603:10a6:102:f1::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 12:21:23 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:21:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fe69889-43df-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H48gpEaDsPkdQeW0e0fU8o2QWz5c8MbkIO5FzgdDpiWigi6RwugpraH4n+W8AadLfZ5kLQdKF4kEywCU+u8ProAptrGtkccT1ZiuH3H6AAFcCKxlhG+RijekG0RDr3q6iwEYSM5vcDJF3L0Y+3mA85n2gPzgxbAdoXivlrzC7kPm0y97hV/6dE78S1kcyFko528mHUwBL7eslHCiDV+TgBkI6uyEhj+Iu1O/dOLhshaZuidEi54QRzqg6GVIdh3tPAFT/dLIOoyiZ2sM5G/5fVMuWFeyW2PO++kqqwAWMiYeTkVjC52zxMMVluaHyrz1CSzva/RPMpQcx/jXSwBE+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4RqG2AficvjTS7M/Y+CFu0Pl9MnXF/3D+TPoZaRxqlo=;
 b=RLV83uMaMDq81U/L5Yv8NvWmWiwd0lT/j0HMg/qdE7wH8nP+5UnyLdcB1x7MXtKwFDOho/V36xZTkOJJc/yBnDVm1DtYTPWYacPuTWSxcaGSBbDAa9p+f9XSELXVF6ZFCa+pwoy/76MPa/EdriBTWPqfYzexBSVOyWpXwvGiRLsxQQbTPjfbciuHLIU1C4veuUuUeQ+mvxsFvVGuYU7IkUfimCH7sI3mf80hFK48W7Hhv+Asd7cWEcc+7zTqZ8Of22iE7fzQVIZHkORrc0kDOIjVq9f0LzKrT71/i4WlB9xaX99n3UsHsgiKZ18BKyQGAx89AVJjVVwVcZb+WRlNRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4RqG2AficvjTS7M/Y+CFu0Pl9MnXF/3D+TPoZaRxqlo=;
 b=PAi4t99TPTt47rzelcXGgG3n1Bhl0D2lkUEJUE2saGMjDYCEDE1d4XvgwrKAU7m4EwKNWpIlNXTBZfBpLpXSu4sXM+dlkjvuux11sN63BFXrY/INUb8dXH3mygLs3tLk0OqM8VhgKBpPdXCLRr3+NLMy16IqEFt7rSScw5h0EjS5+08cKsFSXS9CS+px+fS1d2NSsasKJlBgJZ+1OIxWHXmAM7ruXD49F5FmWah8aICfn1BIqikGcE2a4cFnaMys8jPL+GDagwAuruYJfPFkHOys/1OUGTCc29mMpASvBFztpor/K5zQiICy2Q7Cq/3cRQ47zYXBuzZs8CPE+MGVkA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2d49fdfa-bd76-0469-0840-6260c5a8ff48@suse.com>
Date: Tue, 4 Oct 2022 14:21:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
 <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
 <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9P250CA0003.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:532::9) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7568:EE_
X-MS-Office365-Filtering-Correlation-Id: 5489dce7-7134-4a66-5333-08daa602f35a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	G0h8OoIu/efws06f6IqrmcYGP95um2wYcmTYrW9ddsibv6cuj+g3Nnx66DQLUrORfmSfLDlMzCmR84iZsNL+E72SOc9ZrR2JLQvQBJ75YrciB+yA0O5RsXMMhdjVnt3X3ZlnzfnUzrkHLrOag2FGqN57NJJqAMmHK4kqR6+HKheyUFh9OMroGDIymy3PE1SrThlbokqbohfGalLRXk4v1SXDWS50v2W4It4rLYlrBg6d90dn9CDN/Ub8yrR2j+JEEfTAy2lPX0F67pEIy16QnkkRN/F0B3OpoTxL9RmSar8aifxJrpH/Rgc9/meohOf02IG1v13ZvAFdlazaqTQyxxXGD0PNGnwBKvmVwYtqPSKz3BDcAc8IhHv53p/URQpJQ1Xu9iK8dKs3LEdEziTJMOZdBiljleKWMXnSViSuGSobSVK67oGgSY0Yo4A6NXh8JNznBtd2A+hgHMWq8E5hsIG+WMZTBu6OppqTx4RYVglUHBcHZWxc+tw0CcvAtNJt9sS8nEgnydKvgh+1XsbHYjvw9PcDRjWvBTDiPlM9C59pFaArnQAUCwpfzIw9oWU6WhQVcDdWnUbr65nKiGul+v221qutuzX1buqA7TND2QEHRPOIar7wfwA2BMCLq1TfeHBgYNsZa66QY5AoNvdsdKmkdP8k9O1L/urX2fosFZIX1x+aU2Si3PzFHEAryF7648L4JNdFdjTCbTRbbOvS61gfWiFDh4OpVeepxWN7ogAoV1DZxtPs5Y2qSF9s68CDqbPHEXJTBL4qlP7NaC91RDFmYzNDnukAvejZYdSB1+E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(31686004)(83380400001)(6506007)(26005)(186003)(6512007)(31696002)(6486002)(2616005)(478600001)(38100700002)(53546011)(6916009)(316002)(54906003)(5660300002)(66476007)(41300700001)(8676002)(66556008)(86362001)(8936002)(66946007)(2906002)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SW1ZdUpaQ2t0MEpHK3JSUkt2TWtINWQzQWhkMjZaaUVTMzJ2Q3g5WXlLWTlq?=
 =?utf-8?B?cUxMeUg4SGJvd2pUanFiV2ZhYjZXMDF0b0Q0WUh3YjliaTA4VWNyR2s1Rkky?=
 =?utf-8?B?N2Y5aDJSYUIzcDZ4eHk3bTA1Tkp5QktzUjVqK2NIUENMVFU4L1FFdjA5NFkw?=
 =?utf-8?B?REJxRjNRRXZNd0R3cVErSWxjcGFPRUdrSjdFQ2s2bGpwUVhDTzhzNUpEZVZ3?=
 =?utf-8?B?TWpoaDRwWmhWK3Y2ZlBVL0NQRm1TVm5FZU5hVUVtVTNTQkZKb2NCbHBZbS9X?=
 =?utf-8?B?VHJWVzFHQ3E2UEdldUJqR0lBQ1RiQzRyT3JaNHM0MmNjSXd6VE91RksrZmhp?=
 =?utf-8?B?cXBNK0psTGE5NmFvV2hXdGZxUXdCWkxSZ2RteWczZDNkR3ErRU9iazBXV0hR?=
 =?utf-8?B?YVp0TUtzZEx2bU1ZZ3JmQk9GM1h4ZldqMDVBaENCT09jbUg0WWx2UTFNTURn?=
 =?utf-8?B?TkI1NVBmdnZCd2VrRUllaGg5THRJbzFKTXdaTDhmRk1JMzFYWU5za1k4SXhk?=
 =?utf-8?B?cXhYYnU0YVRYekNuM1U4aUJsMy85dkJaWTl0NFVQcHpEdHJKSHhRZ1N3dE95?=
 =?utf-8?B?OUVPVnM0K3VDeG82cG1KNU5TNHA2YVgwN0V1SnlyL1lzd1oycFVGUEppR3pv?=
 =?utf-8?B?aEY2amlyRkRmZXdBZlF1ZG9pcFNqalFORzFGR0VadXVBUFlpT2lpNmp3aXNW?=
 =?utf-8?B?OXpGR3VKVWFBZTVNb2tKd01LSURXOTRUSkxyTG81c2FoOVZpall2Rk5uMEhs?=
 =?utf-8?B?MzlqNlFXeEFLNklmQXovVllmdDVXZ1VkNHJPeG9LMFVMRytWN25wQ1V5ck1U?=
 =?utf-8?B?V29WcWF0K3M2dmZodHVYbVFFUm1Sa1pEVEcwdWZ2U2dTTHFROFhOV3JhM3RU?=
 =?utf-8?B?bTNDVXY2ellSdE9vR0lTLzNhUWtTNXZJVWRuV0g4clpKVGVEOElvOEpMNjdH?=
 =?utf-8?B?VjhrQVBuMHBLbjNJMGJqbm9qTXFteUZlTnJBOHNhWlphOUtPYXkwczB5TkZv?=
 =?utf-8?B?eEZjODh3NnI3b2NwMWM2aVYyMXltNmJ6SncxR1NJazlNd295K0J2NlZ0b25i?=
 =?utf-8?B?VFppK3ZjNmlINUpSeGpOSUZ3TVVPN2dNL0tqWFU4M3VwWHVlUElQUzJja3hV?=
 =?utf-8?B?Sm8xMXVQSklEa0syS1A1WUhROVllMGNvSkdncm1UOXpsUDhZU0dBd1JzbHJ4?=
 =?utf-8?B?QzV0ZW5RVk1ZZGczYXVSTGh2dkorQ1hxYy9vRGJtdGNLYXZWcS9YazN1dHhM?=
 =?utf-8?B?SDRGWUFZQVlmWHg4Slhud0tNTjcwU3dXRkJmUHkzVTdKNGF4QjRjYi9zWm5h?=
 =?utf-8?B?UXJjU1hXWFd3Sjc0VktWdFY4OFMyY241UVFIY1laTlcxWU03a1REYVNoZVV2?=
 =?utf-8?B?blhFL25aQ1FwTUZHWHRRY0hzZnl5b2ZxOGJzNVVuVUpKbGdMZGFIQVRvb1Iw?=
 =?utf-8?B?RXBFVE14RHpMelR0MlRwME04VmFua0oyZ280YWd1Yk93MXpDZTNUUkltZXV1?=
 =?utf-8?B?NlBhRU9LNUUvRG5YeE1EeXdRTmtLY09nd0J0Z2tFdkY0Zy9DbW92ZVkxZWU4?=
 =?utf-8?B?S3dBRmFUU0NPdmI3dS9YVjRXSmNUbXFnOVhMN0hadUhuZlYrVktkMTlMWVVN?=
 =?utf-8?B?Sll6STVRekNjZk5KazBjVU42TlVSbnNzd0c4SFdGUit3Tkx0ZDZQYW5NbXBS?=
 =?utf-8?B?OXp0ZkNTYWtmbWl2bFF5V1pOUm5YQ2RNYVMxTVB6d1FrbnppdDd6M0wrRGFQ?=
 =?utf-8?B?cWRyRzU4YnlXNy9ycE9GalA3SWNIZjdkUXJ2bXBRbWRtb1BRUkkwZ3lLNElh?=
 =?utf-8?B?N1hlSGdaRW9NUWN4ZEpDRVp5d2xzc092YjQweTRDMWtGTDhmNWlMTHRYQlE0?=
 =?utf-8?B?bVlGOE15QlY2MEhwTy9PN2ZLaEtFTGwvYW1CaWdueHIxUXpYc0hmMGc0Tmhw?=
 =?utf-8?B?MW5jRkEySm1COFpRbzNWMjdlYWVxdkdFQXpNaitpT3lGUjJCcnloMktibURV?=
 =?utf-8?B?V29kYXo3QVFmYVJXRTVDR2o3UStxNUpsNTgyUEVGSkdLVTFsZW1rdG5CTEsy?=
 =?utf-8?B?RHBaNU4zcWkyckJJUk5pWnROUG1VYlprRmN1OTMzMWhKMGFOZWtZTjZob0x3?=
 =?utf-8?Q?wb/W9o6/kBCRIEBw5XuwKEAfg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5489dce7-7134-4a66-5333-08daa602f35a
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:21:23.0837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S7jvHYcNx6fhbs/B5H1XxdHMIvx3lEjtlKNgQ07u8vtulQdlzdx7h4y6Uf24Q/WR9LsB8Hnqvw6cXk03jWhRGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7568

On 04.10.2022 14:17, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 12:40:10PM +0200, Jan Beulich wrote:
>> On 04.10.2022 11:27, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
>>>> On 30.09.2022 16:17, Roger Pau Monne wrote:
>>>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
>>>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
>>>>> devices used by EFI.
>>>>>
>>>>> The current parsing of the EFI memory map was translating
>>>>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
>>>>> x86.  This is an issue because device MMIO regions (BARs) should not
>>>>> be positioned on reserved regions.  Any BARs positioned on non-hole
>>>>> areas of the memory map will cause is_memory_hole() to return false,
>>>>> which would then cause memory decoding to be disabled for such device.
>>>>> This leads to EFI firmware malfunctions when using runtime services.
>>>>>
>>>>> The system under which this was observed has:
>>>>>
>>>>> EFI memory map:
>>>>> [...]
>>>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
>>>>> [...]
>>>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
>>>>>
>>>>> The device behind this BAR is:
>>>>>
>>>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
>>>>> 	Subsystem: Super Micro Computer Inc Device 091c
>>>>> 	Flags: fast devsel
>>>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
>>>>>
>>>>> For the record, the symptom observed in that machine was a hard freeze
>>>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
>>>>>
>>>>> Fix by not adding regions with type EfiMemoryMappedIO or
>>>>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
>>>>> be positioned there.
>>>>>
>>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>
>>>> In the best case this is moving us from one way of being wrong to another:
>>>> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
>>>> legitimately covered by a EfiMemoryMappedIO region in the first place,
>>>> which I'm not sure is actually permitted - iirc just like E820_RESERVED
>>>> may not be used for BARs, this memory type also may not be), whereas with
>>>> your change we would no longer report non-BAR MMIO space (chipset specific
>>>> ranges for example) as reserved. In fact I think the example you provide
>>>> is at least partly due to bogus firmware behavior: The BAR is put in space
>>>> normally used for firmware specific memory (MMIO) ranges. I think firmware
>>>> should either assign the BAR differently or exclude the range from the
>>>> memory map.
>>>
>>> Hm, I'm not sure the example is bogus, how would firmware request a BAR
>>> to be mapped for run time services to access it otherwise if it's not
>>> using EfiMemoryMappedIO?
>>>
>>> Not adding the BAR to the memory map in any way would mean the OS is
>>> free to not map it for runtime services to access.
>>
>> My view is that BARs should not be marked for runtime services use. Doing
>> so requires awareness of the driver inside the OS, which I don't think
>> one can expect. If firmware needs to make use of a device in a system, it
>> ought to properly hide it from the OS. Note how the potential sharing of
>> an RTC requires special provisions in the spec, mandating driver awareness.
>>
>> Having a BAR expressed in the memory map also contradicts the ability of
>> an OS to relocate all BARs of all devices, if necessary.
> 
> I've failed to figure out if there's a way in UEFI to report a device
> is in use by the firmware.  I've already looked before sending the
> patch (see also the post commit notes about for example not passing
> through the device to any guest for obvious reason).
> 
> I've got no idea if Linux has any checks to avoid trying to move BARs
> residing in EfiMemoryMappedIO ranges, we have now observed this
> behavior in two systems already.
> 
> Maybe we could do a special check for PCI devices and allow them
> having BARs in EfiMemoryMappedIO, together with printing a warning
> message.

Right, that's one of the possible quirk workarounds I was thinking of.
At the risk of stating the obvious - the same would presumably apply to
E820_RESERVED on non-EFI systems then.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:28:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:28:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415510.660103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofh2M-000703-Tn; Tue, 04 Oct 2022 12:28:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415510.660103; Tue, 04 Oct 2022 12:28:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofh2M-0006zw-OX; Tue, 04 Oct 2022 12:28:38 +0000
Received: by outflank-mailman (input) for mailman id 415510;
 Tue, 04 Oct 2022 12:28:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofh2L-0006zX-84
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:28:37 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2087.outbound.protection.outlook.com [40.107.21.87])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 112c0c85-43e0-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 14:28:36 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB9519.eurprd04.prod.outlook.com (2603:10a6:102:22e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 12:28:34 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:28:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 112c0c85-43e0-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IinflnMNCNUZY0HFtoIsAbIOkGNmkH9VB9a19vFHHo2e8LM3SRjliNRDpoyr7seMsfzsGob+31NubGvFc/B/+PzkYTZEAKC6YFJRvXyN5kE2DuYTzd1aYm3KOSfXxnGO5+B2uF5F/KbOKFG0whhF4ZsR/IMUqWU2PFTmmlH0JEoKdgA0qd1GaHZcnmMJccC5VZ+nPefZxZCZ1viBN7hofYxgTsJO17eT4qlz4UQAS8aW2c8IA8ipOkjXI0QfJwq4FOzKRX6ztbwjdrZrm+0sBtyUKKPq13YrlP0Q2amoiR/ETf9GhnFPBCkZl3nx5n4GFim0Xj+jksB9lex7jxccQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tpGeEeVraeJSWAt2zRJbWgXPtx6MwofautsqUtDuqMg=;
 b=lIXcYhIVWzpha0HLBrmJb4MCYPYpfIIigf05Z5wTyMywjFTeO8Qv7XkZgayhN1HbDPv0FdKR0dmxZgDPFYz2Oh1uVEInI+uIE3CQCqSJRLMgy8MVkWRnY73c+bw1Y+gkSQ84aVv9PD+7CEy4VkVWa0kXQDR8aX+ZrX8/p5FT5/PMvnGOhoQ+JJCOzUiJnSEAa6Q1aUY2wl7cg3UykF7AU6NII+/FIrk5KFGM8dSJCSpjHDrvBD5ezlLSem/Fc3Z0f4B4V6Ze9XulouMSdw31LyDuT7QbXP0Z7I7EjOBwIiaElEYEMsWx2earRmJAOuSdhGcpM+plhrekcDik9+bEaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tpGeEeVraeJSWAt2zRJbWgXPtx6MwofautsqUtDuqMg=;
 b=HXUp9dHsQbLWbymUXEqMwRxZRWImqKG/NJvlX99E0c5M72ilnUKSxjo+RpsI6i7j5z1XhCNjGktRrKLY31YJGkmgvr0AdB9lc6krmv78VfJf3VsVynYHu4q74Ssbcp3LM/v1eWNsY471RIrd7RTCW49Yflw0MUVD3c/ErOib2WuQNPtnV7jcs/pEsO9v5NSC0LJ2J7HQv9GJXl3xyk5e9rvd2wqdbBczYww6umvAP0RLFcGJ38IWy8iRelcGBbR60c6tInFqZUz2/9qCDVdA4/z02/zBQtgAMctKFQyg1W2Kgj1IKDI2YVZFlH61/6RAp2+wFKx2ZTh9hp7gO9NfNw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <77fa836a-421e-f1a8-7009-663f97f764b0@suse.com>
Date: Tue, 4 Oct 2022 14:28:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20220927154708.15787-1-andrew.cooper3@citrix.com>
 <77d1bd6f-fce6-bcd2-96f1-a672aedaa7f6@suse.com>
 <764f281d-fd97-7413-02d9-f856c0a5771b@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <764f281d-fd97-7413-02d9-f856c0a5771b@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9519:EE_
X-MS-Office365-Filtering-Correlation-Id: 0cfa1608-f3ad-4fd8-0f6b-08daa603f274
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FsUh/XltfUl00vlEUYJtZ248vXYAtDU0Jsm6kaw2GXrJl+hENHqbm7oOJhHkl60e2q3KK8VVr1zZnY2Pun/vISwvArbAcGebGInwulFK3m/PUjki+XVWvQCA0LZb4gPzrcuUE6rPGq/42s2iDbjALOpxbjktJK7M99Oh0BZRUNQL/NjJ2IkmfwcBp7WKC8tROgjnp4jd/HiQZi+19F7RNcgkvwPjcjTWjStCvKsHKYa8x0e572Og9nLCkQWcoWUILgn4bu5OIFn3SOL5LDrlzpxKw8LVNfhzHUO+/Nx27EVGS2zUxw6SyW7DfqjlvJlMCZJsq6k7bvDeBOgXlMp0QFN7yx6X7FUn9sRthBYTTCJJDTEx5dWqBaKAnJFOXKbCl4l9S4SR3jqVewHfh9KQLtGsRV6UzjI/jbyor+nqGt/pTd5f7ILMT4v5Rm0z8CbtxaBVeisQJi/bgxeVlhN1pb5CiJcq5IsxJ6ragDt6UTldNWSnfV/FycU2iWUnSt9zgtlQ8x1Pqq9iDZucAw8p8gpM7Y9hi7TMDYwvwdRrfIplTfxAmROjb0WkEpnBvYU2Cz1zTmKj/VBVFMJPnQj7vkCIUC07XEEt7yrs0wzVkBOy/YbWIqFuadw5w8sYmSJIZjDsgSI4ffLtsqnQbcZhBUtKhYrBc2OMYf60LMFJM5XdiSQu7SY/1Xdwx0E9YzjidCvCXQB+upOAqUUbz6NGzjLiGLlL9cfuQ932oMYot3+nBmU+VnGotOX3mjX2Maoo4flaXqgdIH0v5cQk0QNSIV7LuVaR5TbdH0ypMMMaUuE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(366004)(376002)(39860400002)(346002)(451199015)(54906003)(26005)(53546011)(2616005)(6506007)(6512007)(6916009)(66946007)(316002)(8676002)(36756003)(66556008)(478600001)(66476007)(4326008)(38100700002)(31696002)(86362001)(6486002)(83380400001)(186003)(31686004)(4744005)(5660300002)(8936002)(41300700001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHE0UXkyRlVkUzJpaHVYRkhJYm1yYnk3VEQ4K1VmTWt2Tmhjc3Q3eXpYeEsr?=
 =?utf-8?B?dVRXM0NXNWhRYk5JVmtaSlBrb1d1SlhIZFhnemN4b0hoNU1ndGxuN3IzVzNT?=
 =?utf-8?B?Y3FLckJUOXY1OVVYT0tNMndadU9obVFjUU12TVl6WTNlTXIwRHlTZlZYME9l?=
 =?utf-8?B?ZXNjcERsSDlOSUUzVkRFYk5uN212Z2lzcmVoNmphbUFoL1JrQUo2R0NMeHJ0?=
 =?utf-8?B?SVhtZm1pUTJvdTVGZTVrVzE0S0VJNmVUTFJXWDh3b01MMXNDVHVFRWNobUJO?=
 =?utf-8?B?REk4Qk1Cc1NoWWNtZjFUUHd4Qng0N3R1VHBFM0NlSW1Nb3RuUFFVQVNxTXZN?=
 =?utf-8?B?bEVQdm1JZDV4U1JTOXlZQUM3bGVFRHZKdzkyeEoxcTJvQjQ0NTBML1BrbWJI?=
 =?utf-8?B?bVhDQ1pMY0F5QXp1bE9NZ1Z3Z0cwSTZkZ0VjNEdOTXlFRWhYTitQSDM1ZWYr?=
 =?utf-8?B?bWZuaGlyOWxic29tZlExL240QUI3dGltK01qSWZGUmVVU2Y1UXJSSENPSU1Z?=
 =?utf-8?B?YlkwUjZBRmUvRmF4d3ZMOVc1K1RQZDlaWXl2QlgzUCt2S3RtR29PMjN1UGxT?=
 =?utf-8?B?WE9rZDFIZXU5Mmo3cW9tRGtRZnRBbzFXK1VqNVprZWdKZTQvQ3dkMm1YOEZM?=
 =?utf-8?B?amc5VnpmakQ2aG5rNHU3M2lKVmZwR2tOSHhBN3c2eWtyTXBDTXRsN3JzcFpn?=
 =?utf-8?B?SjZzeCtEVC9tRitTZllOL3dFdDlrdU84Ymd4S3lieER3ZGVBd3dadDVuM3Vl?=
 =?utf-8?B?dU1GYWlHV2Zrd0o2Z05BRG9ySUwyaTFwTXBqR2FHQmhMWnJydmd0Y1RObHNa?=
 =?utf-8?B?aUFrV1gxSFhhd2tzMlVUZmVtTHFDajEraE5IcXFQK1JQbk4xTXZRRjQreVYz?=
 =?utf-8?B?STB0SmxPMzE0UTNESWwveSt3TG0yVkd2VXhmQlNjUUwyU2podkRVTHVJNncz?=
 =?utf-8?B?RjZJRmlSZkpQSGJvejVGYkU0U0pybEpTa09vNjNzVHJRdE5mbUw4aG1heGZN?=
 =?utf-8?B?NGVFZkpEaVF6OVdwbjkwQkg3Tm9KMUdPWkxnc1Jlb2d3ZmVHdnN3VzAxZ1RS?=
 =?utf-8?B?YWZSaU9OYXloKzVQOFBNTmxIY2ZTajM1QVhGNXBVZDJ2UWZYSFY0bHNicjli?=
 =?utf-8?B?N2J0eGdNV1A2ZWpJTTBKSkdsUWtTb0JNdXQvZXZzWkpTbDc5ZkZWS2U0UERn?=
 =?utf-8?B?YmJlV1poNVJ1dXRPYS9ENWhZakxwcEZ4SHltaCszUVJheUlmRy8zMnFaL016?=
 =?utf-8?B?MDMxbEFVeHh3RDBKUzVUcDc3WFpuRmVhaHVORkF4TGNGT0cyRTNURUljUzlO?=
 =?utf-8?B?dVpROFlzMlduTzFZdmFDKzI4bU44b1F2NHdRVmdtSWtQOTVHbm5IbHNoR2ZB?=
 =?utf-8?B?QXJxelRpdnRwbEZGNUhLQ21nR3ZaekpFczJOZjBGbHFYWmtoUGY0cDB3WHR4?=
 =?utf-8?B?d1JZeTJsb2lvbk9tRlpDRUZjdzN3cmZPcjE3UUZnenJ5aU5VbE5pSVNaWTZ5?=
 =?utf-8?B?K1FEaWVpV3hQRitNSVBnT3BnS2tUTkl0a0lXRUU2eDRPVXA5eGFac3U5ZGc2?=
 =?utf-8?B?dGFOMjZ3NmRsL3Q3ZW81ck0xWHRRZnlLekxxNHlnamo1a2hpTElZRWdOcDZY?=
 =?utf-8?B?R2lyTUR2Nzg5UnVyNXMya0hERFlXRVdSelYzUm0xZjdvaHFBMllhbFN5YjhY?=
 =?utf-8?B?b25MOGdEb1hmaWRpUUVFckU3T3RzcmhYR0dVRWJMRGdwWStMc1hlSzNNRFZI?=
 =?utf-8?B?Qkl4NEdRVzYwUFNzWjlUblltWWZNVGFnSHo3WSsvS3crNW5kQ0p4NVZtcFRj?=
 =?utf-8?B?Z2QrZHBQNDB5N0FIWW1TUmV0Skh6bUVBRTRZeEcxTWcwNXg0T3lXUUlqMlls?=
 =?utf-8?B?UFh2cjErUk1SYk1wYk8vM1FhNlhpUG9FSy8zTVhIS283a09aY0xiZStYb201?=
 =?utf-8?B?eTZENzBTRllFbGJadXpTbEkvajVaT084UUY2UXBJZ3EyckxqNWFoVldHVEdX?=
 =?utf-8?B?ZFJRL3hZRit6REgrQ2dFWFdoNnBCQnZwSExYb0JDQlZqQnJzNzJOSG9xMkIv?=
 =?utf-8?B?Y3UrdzRldEtFUW4zQzJDRTBqcG0wbUNMT2VraGRXSzhUekJVMEwrUHRiWS9o?=
 =?utf-8?Q?hJYUMJ7OugKcDshHc1scmt3ib?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cfa1608-f3ad-4fd8-0f6b-08daa603f274
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:28:31.1182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X5IYeWRmQZfU6511XfDhzQH8iVg/X3LBQvtCTaBBx//kC4N7xuFdgBl6mdj0em6rxhhz8ElsmmDM1OpBug5JDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9519

On 03.10.2022 13:20, Andrew Cooper wrote:
> On 29/09/2022 11:07, Jan Beulich wrote:
>> On 27.09.2022 17:47, Andrew Cooper wrote:
>>> This breaks all Clang builds, as demostrated by Gitlab CI.
>>>
>>> Contrary to the description in ecd6b9759919, -no-pie is not even an option
>>> passed to the linker.  GCC's actual behaviour is to inhibit the passing of
>>> -pie to the linker, as well as selecting different cr0 artefacts to be linked.
>>>
>>> EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to
>>> gain such a usecase.
>> Since it was largely unavoidable for me to notice this while putting
>> together the two XTF patches just sent - isn't the current way of using
>> -no-pie there bogus then as well?
> 
> Hmm, it is now.  In the past, XTF did use $(CC) for linking, but that is
> not the case now.  I'll drop it.

I notice you've dropped it without replacement - don't you want -fno-pie in
its place?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:54:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:54:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415519.660113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhRS-0001p6-0J; Tue, 04 Oct 2022 12:54:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415519.660113; Tue, 04 Oct 2022 12:54:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhRR-0001oz-SN; Tue, 04 Oct 2022 12:54:33 +0000
Received: by outflank-mailman (input) for mailman id 415519;
 Tue, 04 Oct 2022 12:54:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofhRQ-0001ot-F4
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:54:32 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aea03a1a-43e3-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 14:54:30 +0200 (CEST)
Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 08:53:10 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by PH0PR03MB6267.namprd03.prod.outlook.com (2603:10b6:510:e9::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 12:53:06 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:53:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aea03a1a-43e3-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664888070;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=1Mz5ZMkqxeOY7LWmeUUf+jITWQ9tHF2CeVbA8zgO9IE=;
  b=XCtVSJwO3eoKF49KHJjn1N3hM0RcZnpUy/rFggQ2lReOC+1RbvI5MOCz
   fre9nqEbSVKk62eNcc5sw+LhfM+DRXZB8tWS15HOcrf4UPWFXOg8xKIwD
   BfewDwK0Wctv0CUv8psjn7QyyLXjUExMxJ615H7aZYC7nEMG0Bw6itxna
   4=;
X-IronPort-RemoteIP: 104.47.56.175
X-IronPort-MID: 81059908
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Ra0FZq0e/iUWWS9GrPbD5UZwkn2cJEfYwER7XKvMYLTBsI5bp2dVz
 zAbD23UM/uJNmKjLot1aYi3/R4HsJOHn4BiHgZvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNPg06/gEk35q6r4GtE5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU8+elaImIf6
 cY6IWgSVQKHiOG5maO0H7wEasQLdKEHPas5k1Q5lHTyKq9jRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/L4/NovgA/zyQouFTpGMDSddGQA91cg26Tp
 37c/nS/CRYfXDCa4Wrcqi/917ef9c/9cL9DT/7h3M5jvEWOmVIdVUYWX37iisDs3yZSXPoac
 ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 TehgNfBFTFp9rqPRhq19KqQrD60ETgYKykFfyBsZRAe/9DprYU3jxTOZtVuCqi4ipvyAz6Y6
 y6NqC8ylrACl/kB3q+w/U3Eqz+0r52PRQkwji3dU3i59Ap/aMigbpax9FnAxf9aKcCSSVzpl
 FgJndKPqt8HC56lnTaIBu4KGdmUC+2tNTTdhRtkGMAn/jH0onq7J9kPvXd5OVtjNdsCdXnxe
 kjPtAhN5ZhVeny3catwZIH3AMMvpUT9KenYujnvRoImSvBMmMWvpkmCuWb4M7jRrXUR
IronPort-HdrOrdr: A9a23:Ua+8lKsNObR0dBy2x4IZ1hjr7skC7YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79
 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M
 323Ls7m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w
 3+CNUZqFh/dL5pUUtDPpZxfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou
 WLbG9l
X-IronPort-AV: E=Sophos;i="5.93,157,1654574400"; 
   d="scan'208";a="81059908"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AumjX0i71oO/B4LPHbLugLzrJ3m6JuMOguqfjtkxiN++op9ls5f1wpzVqFj5979KlLq0g+1lG7/esio1/HtIPW962gJkxIXRF5meWMFTOfwhcve3gVkZUy3unsHuzcUhub3Tqx+sKlwDJwLX8/my77+ZmIqSAO9aTFAf6r6xsBaHWVvYGU8uj8wahPjstRuNRHe19GNfMc0jrQmrj9VTpGpyV7DjHwyN1FBGicCNV7b1mRS3fYmWf0V9ioAjhaKmLrLqzvp7Q9CF6s0pfr9e7vyVDcdgpCua+7r+WuaOAdmRO6VkMcEbfKPrvxRtmZb1uNu/VxaZ8LSGxfX1pF5SCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k/TcYOnQB+B4LfX/EKZFFhVW8q230A8TlPcO8afUaj0=;
 b=ewK6Zk5wwRbYcU0XHyvSyATkIfxh2YfvLTkGsHUwuO7rvPeM2xCct2DIVIcQdixmcxyY56nxPjHj3DVIBUo9kwaalOFxPEzmq/9FRJ1iMwi+emnlRD5Be4F2wcRUtQRQ1RdtQxi00+WQ+4h2BzNhZHu4WbE6IKayrpKvdScicrfmTfDHzyb1Yz9QgsYbMcj0FVFCQdEuwPmKSU/ezBACClnH/j8gLiICLvK/nvz4TDAykd/abZUsPfOIavZwJAZcm4dRp6WdrHu/nHVB4YL2CDzkyOzivDjNPmpYWeB82Tl/zG6lroNcZzn6RTapvIJE6/ni1q+AjALisZSQmUqBNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k/TcYOnQB+B4LfX/EKZFFhVW8q230A8TlPcO8afUaj0=;
 b=myvdrgFjeyoEScReqPd8Y9RYHY2L4XC9RvTWUCDwud6TAur6GINZJmCFOD/S6b+RVRkLcDjgWOjrNu6WdIZItt7ifpHqv3EnPp0jiaDmezzk5RtLIpQGPI6/AxYTe4mYQpZoapaopE96xUwfAWtzCBBVpvNpFvsZ+OoVXMP7Gc4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 14:52:59 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Message-ID: <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
 <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
X-ClientProxiedBy: LO4P123CA0457.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6267:EE_
X-MS-Office365-Filtering-Correlation-Id: 88d219bc-c470-4db0-1a3f-08daa607618a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RXi8ad90e1fN1YJq93B4b3M44De32Jt26XBXIqoM3FvEjgAbjnWDDCCFXONNajfXHiuP7z/nl0jThJ0XgBUgJPYZY3T0eAAAFoEcbmMb84bhhxFmXs8qw6JjkutVdcHjZHjrjb6l5pX9AH4XqJJh7YLVZgAabv6QEF3QwKyvq+w1qnTQ7wwA6sgT863BjABlXnmDrH4Bxu2I8eCRh6CEeU3WQkVdH44pA9QWFBISC0QJhsEJsJhDxz0F92/ydsafDpabasfFoD55PB47yNR2+iOh3As1OmgyMRiL9lxhNQRN1cE47QrzoZR84eyMItqH+/lMNbxPQAYj787vv8oWvJD0pzGb17oxtBCMHX98iyjhRVNeTSZXO2vNtifITFOAODLTdRD9xV9w751Pl08oy4sUweSPc/v5TZUbnbHm3f00Irb2XYSvrbaHSUYowTbjmXdg18a5YKuciyggSPk9NG36K6EuvUtUel0fMN/mMpItXSOqNm07qOHtjfKWjmr2TGgb9b7z8Sz9+Qn13n7w2JUI25gRkd9Uc5uTbxgqwPKOI6zsyo5Uuqa4CogmJmIqetMGsMIVFuigZ1f2ldIAxMJrEPxaRiDNO9zTGlGcuQ6PYADGEjysjNUM16e39pIoqSUjea566VUlPaxTfUu+m2g9n/m7q2bldH7GxhH9rqkXl/NZy9BC6kp/iaUtg3sGCTKitBYzHdy5kEl4FCQiMw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(8676002)(4326008)(66476007)(66946007)(6666004)(66556008)(316002)(6506007)(53546011)(26005)(54906003)(6916009)(6512007)(9686003)(186003)(33716001)(5660300002)(2906002)(8936002)(85182001)(82960400001)(38100700002)(41300700001)(86362001)(83380400001)(6486002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3M3NXlRVm8zNlJaTmhtSCtCVU1KTDFreURRVU80dTdQSE1hRUU1MXBxN2Ri?=
 =?utf-8?B?RTViS3pyTHFoK24vZW0vNEQ0L3U2ZVNHTHZad2drbHZKS1AwNFAxMnd5SXBY?=
 =?utf-8?B?c1FaY0IzTDFuMzRVYWRBMkRsWnJXUVdqR0F5azJYUU5OSXd4T3prWkd6ZldY?=
 =?utf-8?B?NVdLSlR4RG9sRmlJWnJSbFczeU5Ydys3YXlLNENrOCtIOWdMN0hTRHlZaDhn?=
 =?utf-8?B?VzRjRHVaWFVteE53NWsyc3crZldEcFZTM1hFZm4wZU1UQmNzcTFiNUtISTNK?=
 =?utf-8?B?cFgyVmxYVVg0MmZEYnU0ZXdzUUJiMnA1NWRjTzlFVEZKQzBNYWU3WGpVcXJv?=
 =?utf-8?B?Zlp2anJsdzNyaUtzZVg2NXVRaUJ4ai84T0VMZm00WHZsenRaTG1OcGNLblZt?=
 =?utf-8?B?RHZ6OUV5V0pPRlFhVmI2SGlSMWVyaHJJU3BTSVZ6azJiUG50Z3Nab1B2eVBl?=
 =?utf-8?B?bFVmejF4RkZmVFdTL2JrbXREaFp0L1d2NFZIbUttSitpRUVNN1lOUFZYZkZi?=
 =?utf-8?B?VzV6eDZEQ2xTRUZ3Yllqdlp3WklxazBmbFlzZ2lvRzNGNGJBbUNJcWtZRE9k?=
 =?utf-8?B?OUJheTcwcUs1TjVaR3lSYXJiaDRhWXk0ZlYyRm4vTzZFMk5IZW9jblBud01k?=
 =?utf-8?B?R3Z3b2VmNXluOFFIcUxxa21YV0VJMnNkd3QyMWVOZTVOS0FlRnMyMStRZ1dn?=
 =?utf-8?B?bHJzMTA1MTY4bGpyT2dYbzdxTTZMcEliL0RyQUNHam5ZTnR3YUN1ZVlOOGMx?=
 =?utf-8?B?ajFJQ2NMRDdhUEMrUzJzMmVmNG1sRHJYNm5pWUVLcVV5a0dLTS9xaEJrOEhC?=
 =?utf-8?B?VDR0Nm9Qb3RzRy9CajRZdzBZRndlZCtlZTNZYkZ3aUl2Umc3SUREdVo4VXEw?=
 =?utf-8?B?TXVPQVBQNHZiTU5VNmhBdnZ4NVhnU0ZQamMzV0dWRGo4VEw2YjlVRko5RDNi?=
 =?utf-8?B?Wkl2UmZjMlYzaXIzZWNSRzNwVDRham1qTTZRdDhiaVBXVDMyMVJFSWpqdXRs?=
 =?utf-8?B?UjZNZ25oSkZQZWFsL2V3R2VKU1JyMWJoQllLK3pEdVRycmJJczJNQUlNNjhw?=
 =?utf-8?B?aGt5bStGNTFScE5Zem9LVFFNUkMxVTQvd0QvbnF4WlhPTFlzY0h2Ym1MR2ZN?=
 =?utf-8?B?MERJT0xETVVSb3d0dXhWSE5aMDVPTmZDdE1PWWo3TzlTS0NrUEhDTFNhK3V6?=
 =?utf-8?B?T2tLL2xQcHFoQVl6RkJIRENTZkozQlVkbVQydWxVaUpOTXhTNzQ5YmFmTnp4?=
 =?utf-8?B?UUQxR0tGMmJaOHB3UkRYQjljeGI2L3dCNFBFTksxVjNZM0RaekZrMlU2QVhr?=
 =?utf-8?B?MzV3VDZ2bFpMbURGWkNMcXhIMTBlZVhDdEwrQUIzcmtwTUxyUmc4YjFMV1Np?=
 =?utf-8?B?amp2L3VNQlR5QXhQcmttd1RnR0VrSjdpUjVDbzhaR1oyNjhUbi9sMVc5YTZp?=
 =?utf-8?B?bjZwbGdGaDdlS2grSkpYUWNnb3BlN0FFa21zcVdxclVXZGhuamxEMi93dENQ?=
 =?utf-8?B?N2JQalkrakQrZ1YxRWxpaW5PSERrcGZnSVh3eGlLTlQzYmM2K3hLWjRkYkRN?=
 =?utf-8?B?WFgyQjBVQjEvOE5lTkVJWTRiTGtxWkhMSkkrb1VWWitzbDcvTTlUZjhPK2to?=
 =?utf-8?B?MTVsVmJ4eTNlSVRRVWM4SWV1YW40eFpUZEVWSGRDdzNOSGNseTY5dXNac0pV?=
 =?utf-8?B?SzdJUlhyejhJNU1CWmFIaW95djhqQVBKeFM0WXBTRW1KVmRKUUZPZUljdzZV?=
 =?utf-8?B?SFU5S3NtdVM2bmx3a21Md1JqMUpNTFBhNDZ4bklnNXJrMGRUNVdGTEc2byt1?=
 =?utf-8?B?RWhYQ0NOanQzdThQWmkzWHMyVm9KcStjbU9tYnYyUFBHRy9MWU51S09hRG1h?=
 =?utf-8?B?S2wvQzVweEVENUFUSGVhalUxSWtuRFZuNi9rUmx3SUp5YWJmSFVXZW5GOE9T?=
 =?utf-8?B?NzdXelJ5VnNVVXBHbnlZamJpTWtQVUh2UjQ1bVFCZVU4dVU4U0hyNGxwZHBi?=
 =?utf-8?B?eWxDZ2pmWFdpTm5oUTFsMFVIZ3BQR0EyZVcyOWpjT21mTEt4MTM1Z252NjJN?=
 =?utf-8?B?WTdNUlRraXRIYUpuUi94ZFBJSnhBRFU0OGdFdFYxdkN5ZTBHcFk4SGI3ZE0r?=
 =?utf-8?B?c0pWMVIyOEhaOWlRVnRyWHIwRnZPWTRDSGgrSjlTL0tQY1VkazZjOXFObGlh?=
 =?utf-8?B?T2c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88d219bc-c470-4db0-1a3f-08daa607618a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:53:06.0737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7guYKuDA4J6LaGDnoLRy7/n/Aur0kyTWhQMOWSKi9zUWAs8bjqRqCQlvjSYX+pFalu6tigYWE657XDsIj1GyMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6267

On Tue, Oct 04, 2022 at 02:18:31PM +0200, Jan Beulich wrote:
> On 04.10.2022 12:54, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 12:38, Roger Pau Monné wrote:
> >>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
> >>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
> >>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
> >>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
> >>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
> >>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >>>>>>>> higher priority than the type of the range. To avoid accessing memory at
> >>>>>>>> runtime which was re-used for other purposes, make
> >>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
> >>>>>>>
> >>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
> >>>>>>> dom0 doesn't try to use it either?
> >>>>>>
> >>>>>> I'm afraid I don't understand the questions. Not the least because I
> >>>>>> think "it" can't really mean "dom0" from the earlier sentence.
> >>>>>
> >>>>> Sorry, let me try again:
> >>>>>
> >>>>> The memory map provided to dom0 will contain E820_ACPI entries for
> >>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
> >>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
> >>>>> overwriting the data needed for runtime services?
> >>>>
> >>>> How would Dom0 go about doing so? It has no control over what we hand
> >>>> to the page allocator - it can only free pages which were actually
> >>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
> >>>> DomIO - Dom0 can map and access them, but it cannot free them.
> >>>
> >>> Maybe I'm very confused, but what about dom0 overwriting the data
> >>> there, won't it cause issues to runtime services?
> >>
> >> If it overwrites it, of course there are going to be issues. Just like
> >> there are going to be problems from anything else Dom0 does wrong.
> > 
> > But would dom0 know it's doing something wrong?
> 
> Yes. Please also see my reply to Andrew.
> 
> > The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
> > know it's required by EFI runtime services, and dom0 could
> > legitimately overwrite the region once it considers all ACPI parsing
> > done from it's side.
> 
> PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
> only appear in the machine E820. In how far PVH Dom0 might need to take
> special care I can't tell right now (but at least for kexec purposes I
> expect Linux isn't going to recycle E820_ACPI regions even going forward).

Even if unlikely, couldn't some dom0 OS look at the machine map after
processing ACPI and just decide to overwrite the ACPI regions?

Not that it's useful from an OS PoV, but also we have no statement
saying that E820_ACPI in the machine memory map shouldn't be
overwritten.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 12:59:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 12:59:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415530.660124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhWG-0002Wd-Ln; Tue, 04 Oct 2022 12:59:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415530.660124; Tue, 04 Oct 2022 12:59:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhWG-0002WW-J1; Tue, 04 Oct 2022 12:59:32 +0000
Received: by outflank-mailman (input) for mailman id 415530;
 Tue, 04 Oct 2022 12:59:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofhWF-0002WQ-JJ
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 12:59:31 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6180d713-43e4-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 14:59:30 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 08:59:24 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB4941.namprd03.prod.outlook.com (2603:10b6:208:1a6::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 12:59:22 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 12:59:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6180d713-43e4-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664888370;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=61JzA7D30egICvJcKWfhbSNuYIE9MdK+1IDhrWjxMrQ=;
  b=cAN+JEyREhcHEnnobCZ8F7Vxht/pjiK7Jzyy+4JfGc+vQnTnESha89RL
   j/1DhMg1fC7Uya3KS62f1cNtEsu2lXNxTvlHuD4Uo0cw6iieTmTEd6QX6
   okE2LBtn9vfQlotD18phNHkgaqm7AD8YgBLLr/OcRJnM26cL7n8UB2zP3
   Y=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 81060429
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:iEwpSay5HNTVRIp0/2t6t+ctxyrEfRIJ4+MujC+fZmUNrF6WrkVVz
 zMXWz+Aa/uLYjekLo8kb4q180oF6pfTy9JmGQRs/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtA4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwyON3L2J+s
 uwjdRMxTQiKhe+U+66cY7w57igjBJGD0II3nFhFlGicJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuvTi7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVqyry3rOVzEsXXqoCJb/o/aJg3GbM/UgDTy07Flu7ruCm3xvWt9V3b
 hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU331y1uPhTa7OCxQJ2lSYyYBFFIB+4O6/tF1iQ/TRNF+FqLzlsfyBTz73
 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxlohDGJ5T+REMWTm0Ms=
IronPort-HdrOrdr: A9a23:htUIJKxOn3btlmwmIkr/KrPxt+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U
 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu
 vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIG/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF9nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvGOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA
 BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1sop5PzuN+d3B+3Z
 W1Dk1ZrsAxciYoV9MNOA4ge7rCNoWfe2O6DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK
 j8
X-IronPort-AV: E=Sophos;i="5.95,157,1661832000"; 
   d="scan'208";a="81060429"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QS7AEi54ObmODJ7ufodLA7Rx2V80tejm3ERSoaa+bI/exywH6hTvqkGonMeMn0zgDYHLzVyVopUG0zZtKw7hUCAAIQOA+cuE4jbWn4kqYa1PiCIFvrmc67aFtG11uvfS+NFRH/4p7Lla9vS/k/ZjbfaFpw5EyR1b8FVFQUQZk5HiwuxVSxCbmQEeLKwX/2b4/OYMa3RMpGIDrqbuqEoG1G6SO4/dBE4dp0nrJ0AAYxj4ufwvCDQ7ZZqI2AV0s/cIHbJehrnDW+jYbFwnWOfFRLC5eGOrB5Ye0VoXUUh4wEzobeGtYCOIdpAMxoVe/QzsnHL2CR9X+Rlxqpi9AhUHgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=waDwAaiXiRRXDcBI8kJO/v0XUalPOoo5kuxE445hk1M=;
 b=b6zPHxJMYA3JYhh4F1VYNnjHXM2fQd8r4jkYt6jA42+p3ghF14P2qrUOKVWss/QLAT/yUZ6R3ZK6s6peXlwAVtTXbBGYr4rbw7dLThF/bZEdYfRSWx+v2KawRBsPnW9ZPtTFXDGYCnwdjEnP6HQVF09Ifz9b/7voZyurtz9Xz2PB0j3krmh+feQlFrPT5eP/9g6PhSwuY+ORz6OUvUvWqOYI9ZkCiwkdUP7kT00VQvUvMW4tCO3p86SAxNCKfSAF6xC7/73q2edfK4GZyJsoLEZ/q77SkDFWTkg6ipGrzaySH70dNf3IhPwRR+xbsKFvXlUokdeJAYm8xwpvsKaqPQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=waDwAaiXiRRXDcBI8kJO/v0XUalPOoo5kuxE445hk1M=;
 b=ahIdEjM/syYZEExEvsUBsG2F/nwEHzz1pXVoOwet6L+bWsfpmPxLphHHix05iqbzQEUnIXRX66vY8GDo9eDGitOdmfId/Mz1XKrW1/efemTE5xNlZLt3G2w/3Lvyj1jvXXSUshl2kstDY1o4g5u8gL4lPszltPjhpUyTSooV8Fw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 14:59:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Message-ID: <YzwuJTOtcIopeOlm@Air-de-Roger>
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
 <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
 <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
 <2d49fdfa-bd76-0469-0840-6260c5a8ff48@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2d49fdfa-bd76-0469-0840-6260c5a8ff48@suse.com>
X-ClientProxiedBy: BN8PR16CA0033.namprd16.prod.outlook.com
 (2603:10b6:408:4c::46) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB4941:EE_
X-MS-Office365-Filtering-Correlation-Id: 0d577618-3d1d-4281-159b-08daa60841be
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	g5kFhaAnWbhpjMchApWa+AdcN4iSgeEWaiVhJ9OvUCmk7cPGtCjWAzarlQxSwM+KHPhCGWGfJN3QQ3hoqevRf8iSRBOtZz8LMRTVS6GzjvgKCpMfzH5WUC7bMyxbTeShorK6FQT7FamzAB8tF/OxxM66rtUrZ+l2RP0fiKYGVXnz2yc8l+wdMStyCvf5awWiaAXfPA3bJF8RzhHC+3d01TCbcY3TkuZl32Jl/EeYoklnmKhmA18++LSA5idy3Rk/Iy1LysSDshU+i13HF+8mUgGoih9TqOr8SGePpWKS2sEa1uSJztNtCrKlKkfAJREVQw5bhiFGh3C2YEB27nSv1nPWgDIQB14uPAhOORAM4pxzxsxz6PWFH/wQQBk8ZP4YxWeNQFVP7tVuIcdwwlLXQ7Q8fcATwFI0tw/DIzuiZp++BNR/T0qAtXoItQYcuqKn6a5CuetJb/U7n+zIovDz2Io3i7/3SYLYUt4ZcH1MZY9YfFEhBAMjNSanCQa8JROIB9CVZf1T46SSfobgs1m2mVuPaMr2egsG0J1yNK3ZEaPyPUJJkD0caH5o4KoqjG/4loXHaY1zqZPkTuJJEYEg6SQaEveWzMC+CjdIdMm0wCPkHc+/gSYW2XBpPb2t+GyfKSiwgUVEa9DeGs8lAaKQv4ApsxIzymcZLOxw99AHuwi/n1bg7JpmLBjGdcP3MMrmugvtgozIOmNjDIGUbI+1/A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(366004)(376002)(39860400002)(346002)(396003)(451199015)(186003)(2906002)(6506007)(85182001)(316002)(6666004)(33716001)(54906003)(6486002)(478600001)(41300700001)(66946007)(8676002)(66476007)(66556008)(4326008)(6916009)(53546011)(6512007)(9686003)(86362001)(8936002)(26005)(5660300002)(82960400001)(38100700002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aG9zL2lnZTRHeVBZWHZ6R2JmSUpIVDYxSU84Tm5aMk1ldytkZUhTWFpaSGN4?=
 =?utf-8?B?dUlYZmhOdW91NHdhWVRjRkN5cVVBWi8yaVFQbkdVOXp4TnU2bGJEQjRuK3lP?=
 =?utf-8?B?RFRWTnVVdkx5S1hRMkh1WEhQL21CdVk4ek53ZTAvbDV5cGxodlBEWlFwSmt6?=
 =?utf-8?B?Y2JaQ1FrK21nanVhSENHd0k3bWRwVERZbUMweXpJL1pTZlNIYmdwTGQvYUd3?=
 =?utf-8?B?VVdzbEliOWx0SW5RR0thT0hkVkQrRkhoSEVZU2YyK3k0U1FNR2dyTEx5N0VJ?=
 =?utf-8?B?SEwzNm44Y1piYy9tOW93N2VQNWc1YXdadEhYYkpXSmFxYkdadUpXSVBKcUU0?=
 =?utf-8?B?MVl5aVdDcGJ0RTRxaHhqZldsaVBOY05Pd3BDL1NxVE1UYjVRUFRtcGN5VTRY?=
 =?utf-8?B?RnZhM0IzNGNoWXMvMlMwdXZtSFVPUCsyWTJCUXRYQ2JsWC9GTTZoMGx3MDNL?=
 =?utf-8?B?WTN4Rm00aC9qMXpWZkZjdEVvTWd5SXV2SmNNRXIrYXNLSXVneHhlTndyNmV4?=
 =?utf-8?B?c05RKzhKTko5VU9PQVU1Tml3L096ZzgxbGFGZlI1MCtMY2hpbHluV0diVjdS?=
 =?utf-8?B?eHFkMHdKWlF2NjBBL05Wam9SeVVuRnJpcDUzeDZ2YVE4eEkySUVKZDM1Sm05?=
 =?utf-8?B?WXNBSXR3NWZkTjIrd1VoOUdWdE51b3pkejJCSjVCVUtFUzJuL3h1d1FSenFs?=
 =?utf-8?B?NEFuc2xXU0xiUHNJNlRhZVVUTlNUQlhvTHBhYVprcmJOT3YrVFBZTEdXV0tH?=
 =?utf-8?B?UjJRWDNDcm9qVVg1ZmZUTUNNT1BXVUZiRFBCU0Q0Q0x2cnlMWU4rNTZFVUlL?=
 =?utf-8?B?WWRHM3RmTS9iZWdvS2dOWUE1TEErMmFlMjNHODJtREtSMGZsNzFTQUcvdVEr?=
 =?utf-8?B?ODRRSWlFZG1EeFQ2YnBLbTFSVnVIZnNBUkNnVDVRd21zTjdHWEpsWkcwWVBi?=
 =?utf-8?B?VVBmc0p1RVNBRWtyaDVKQTlVWjdmV05lSnhSRGoyMlFEeGVMckpQa25lZXB3?=
 =?utf-8?B?emFYY1NYY3N6eCtiYmdWZHNkc3RRVkRXK2R3MjlFcW9WMlEyN0I4OHhwOVhP?=
 =?utf-8?B?WVZpdUxucU1uZHN2eDkrZDloOGNnUDBlRGVGNkV1V2dBN2dNNHYzb3JhVzF5?=
 =?utf-8?B?M3NuTHczdWVOVHY0VldsaVhUcjBtb2hEYlJhMlRXM0N4R1BCRjFncmY3Q2xM?=
 =?utf-8?B?bzFLODROQzlGSnVYSXJEVmNuUnZhQ3J2anFzeGsrcmEwRmN1RENHd3EyOHB0?=
 =?utf-8?B?L3Vvd2IzRHlvdUZ5QVlaM1RMeHV1NjdtOGVTS2ZNb3lUQUFhYUxaU29WV29F?=
 =?utf-8?B?ZkdGL0o4MjZ1bktkeUJtTytsb3BpM0hlblRRdC9KbmJESWJjdGp2d1JBK3NS?=
 =?utf-8?B?UWRFWHJhMExsYnUwQ1h1cGVhNmE0eTc4WGY4VzVsMGFZcWJvbFN6TnpEZnFQ?=
 =?utf-8?B?V0EzUzduSzk5djJib1FXWHNzN1VvWmRPcjdOYmFQNy9OMU1VdWZrMCtRNGxx?=
 =?utf-8?B?WjNDS0huT2V5TWkvUTBOc3VCa1E1RG1Mem80NlhTS1FRRkxFZUpiYVFSdU1y?=
 =?utf-8?B?UmdHT3V1ZXRhaVZWTWJhWHkvdGxjVytkdTFWT05jMWY4UXZQR09SRCs0L3Nw?=
 =?utf-8?B?cFcrZ3pnQndtZnBNY2NISE5KRkJrTWZySHVhMzJxQnVTK3h2c2w3TlFmc3ZY?=
 =?utf-8?B?eGRjdHpMNVNoM3NsRHRNczcvT3hPZFYyQjJybzdlMzA0NllHV1J0U1EwYjB5?=
 =?utf-8?B?dXp0aFl0TzJDSnljVmdIeTVOdEx2VFhVbEl4VnoycFFRTTc2Ymd6cDhwM1N2?=
 =?utf-8?B?b01mUFZYeXUydUsxRGhDZ1hDODRTQ3loRnRRaFN4emJpOXFHUGEyVHc1dHY0?=
 =?utf-8?B?S0VHVlBBZnZIVmtxdTcyTEhjVzNuT0d6eFcrN1VWYUNtVDFhZXRCTUM4eFhE?=
 =?utf-8?B?SUIramlWK0NyK1B1SkFuU3d4WHlBRUNUWS9UekY1RWIvLzdmRit0bmxlZksv?=
 =?utf-8?B?czJQbStIOFZEMjRaWWhlOGVBOUdxWWE2Q04yYmM4alArbnl3L29xTTFnZEMz?=
 =?utf-8?B?Z0RqZmJUUmtEMUIwSDVBcTBJeFN2UDlMbHRvV0xXRUpsVnBaU1NRd1FOZ3VI?=
 =?utf-8?B?MlBvMnlCcGN4eFdtM0twWkJKL1pwYS9WdnNQaTlBWTlqWFZwUWozUndBWDZI?=
 =?utf-8?B?dkE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d577618-3d1d-4281-159b-08daa60841be
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:59:22.1459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g0LN37vXR71gku+oKc7oO86b5gx49exug2WCnfLVR/IV6eRYVdjaMU6v7bCSQYB67BagWxoTUHNYtDtft2gFZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4941

On Tue, Oct 04, 2022 at 02:21:20PM +0200, Jan Beulich wrote:
> On 04.10.2022 14:17, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 12:40:10PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 11:27, Roger Pau Monné wrote:
> >>> On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
> >>>> On 30.09.2022 16:17, Roger Pau Monne wrote:
> >>>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
> >>>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
> >>>>> devices used by EFI.
> >>>>>
> >>>>> The current parsing of the EFI memory map was translating
> >>>>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
> >>>>> x86.  This is an issue because device MMIO regions (BARs) should not
> >>>>> be positioned on reserved regions.  Any BARs positioned on non-hole
> >>>>> areas of the memory map will cause is_memory_hole() to return false,
> >>>>> which would then cause memory decoding to be disabled for such device.
> >>>>> This leads to EFI firmware malfunctions when using runtime services.
> >>>>>
> >>>>> The system under which this was observed has:
> >>>>>
> >>>>> EFI memory map:
> >>>>> [...]
> >>>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> >>>>> [...]
> >>>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> >>>>>
> >>>>> The device behind this BAR is:
> >>>>>
> >>>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> >>>>> 	Subsystem: Super Micro Computer Inc Device 091c
> >>>>> 	Flags: fast devsel
> >>>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> >>>>>
> >>>>> For the record, the symptom observed in that machine was a hard freeze
> >>>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
> >>>>>
> >>>>> Fix by not adding regions with type EfiMemoryMappedIO or
> >>>>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
> >>>>> be positioned there.
> >>>>>
> >>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> >>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>>>
> >>>> In the best case this is moving us from one way of being wrong to another:
> >>>> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
> >>>> legitimately covered by a EfiMemoryMappedIO region in the first place,
> >>>> which I'm not sure is actually permitted - iirc just like E820_RESERVED
> >>>> may not be used for BARs, this memory type also may not be), whereas with
> >>>> your change we would no longer report non-BAR MMIO space (chipset specific
> >>>> ranges for example) as reserved. In fact I think the example you provide
> >>>> is at least partly due to bogus firmware behavior: The BAR is put in space
> >>>> normally used for firmware specific memory (MMIO) ranges. I think firmware
> >>>> should either assign the BAR differently or exclude the range from the
> >>>> memory map.
> >>>
> >>> Hm, I'm not sure the example is bogus, how would firmware request a BAR
> >>> to be mapped for run time services to access it otherwise if it's not
> >>> using EfiMemoryMappedIO?
> >>>
> >>> Not adding the BAR to the memory map in any way would mean the OS is
> >>> free to not map it for runtime services to access.
> >>
> >> My view is that BARs should not be marked for runtime services use. Doing
> >> so requires awareness of the driver inside the OS, which I don't think
> >> one can expect. If firmware needs to make use of a device in a system, it
> >> ought to properly hide it from the OS. Note how the potential sharing of
> >> an RTC requires special provisions in the spec, mandating driver awareness.
> >>
> >> Having a BAR expressed in the memory map also contradicts the ability of
> >> an OS to relocate all BARs of all devices, if necessary.
> > 
> > I've failed to figure out if there's a way in UEFI to report a device
> > is in use by the firmware.  I've already looked before sending the
> > patch (see also the post commit notes about for example not passing
> > through the device to any guest for obvious reason).
> > 
> > I've got no idea if Linux has any checks to avoid trying to move BARs
> > residing in EfiMemoryMappedIO ranges, we have now observed this
> > behavior in two systems already.
> > 
> > Maybe we could do a special check for PCI devices and allow them
> > having BARs in EfiMemoryMappedIO, together with printing a warning
> > message.
> 
> Right, that's one of the possible quirk workarounds I was thinking of.
> At the risk of stating the obvious - the same would presumably apply to
> E820_RESERVED on non-EFI systems then.

One option would be to strictly limit to EfiMemoryMappedIO, by taking
the EFI memory map into account also if present.

Another maybe simpler option is to allow BARs to be placed in
E820_RESERVED regions, and translate EfiMemoryMappedIO into
E820_RESERVED like we have been doing.

I will attempt the later if you are OK with the approach.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 13:11:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 13:11:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415539.660135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhhP-0004nx-Nl; Tue, 04 Oct 2022 13:11:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415539.660135; Tue, 04 Oct 2022 13:11:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhhP-0004nq-Ks; Tue, 04 Oct 2022 13:11:03 +0000
Received: by outflank-mailman (input) for mailman id 415539;
 Tue, 04 Oct 2022 13:11:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofhhO-0004nk-BG
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 13:11:02 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe0f2cbf-43e5-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 15:11:01 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB7925.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 13:10:59 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 13:10:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe0f2cbf-43e5-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L1foz828fUT1zsvaLP44FetUcxNUHXtgkwRsnWZKRfUkj9ebQ7xP/J5qS7DeXes6OcqdBJ+LgXfMLwTamHKXYuo7oq5stRZMaMidrlRQ+j2iHTpxEySj+k4m3T2dKpaO0DHY21PbUpLjjkjpYMswiPeEyg+Ctu/pg2CxbJcEiWg9ng48Ys1l704li4+vPI4HD+6fPVp2Xn7LK6Big5uDpFWg7EldRbUXzNXHiyquq4GtKGf4he0s/RRLhgy0kerV02l/Ly6fA23CYPaLBWgYsSJStHMph4UALrg23Y9/mWRFKIyG61XvfvHUk0G1GPegK9qU/RPa05qr6J7Ko2vjHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aeroNwdPfID6ObM/qORVsJlYmc80Fon0mC8/OrHoBCI=;
 b=iSnoVuDQmafcCoFGpBmMb7KCMdQdHOaDbmmTEEzuZHBAXaMouGvMpC24Ymgr7wWI3/kw12RfkFtqdNFcrYK6B4hW61Qy83NzBpffmGMqhhm6EYDa2S4+UsONhsMBWDeEc0uWdsikbZ9x+3WTbwlV3LEP22oAmDYSe4SUnkmeKv/Q44czgRQJ/zPnaLQVVwWK/FefcosKbTPeKGxB9Jsf0MDG3fXNX6byghY5T2XRQCI9d8N1JoD5n1Syxac9RA3FC5R01I5uOcR9sk91TvPbpDPyLQDgmx/sHYuusWdh6vKrI+d8QiGNqTi75xuecCdcMEqvi21Hp3Y5yMqP9kTByg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aeroNwdPfID6ObM/qORVsJlYmc80Fon0mC8/OrHoBCI=;
 b=AS4H3DLZDjsiUSqmF0UxidTtynOp2WafEYPHGApyr6uOZ6x5rFFNW71vGEDrCJ3BWliB4DA7aUoDlFLuNt1WvfbDJVhq4SGQPizueO8gVBI7E42LzIWNGFFixVfwuIB9yJTSiARr5H1Mm9+l/7J4swtGtYkeRYHhmsjKN1JAllhVzk7wso/GZNTF0KesY8lXAvd2n4XGq2Usie10YhUkEi9XgJ3f3HGINgGqpm1rprvZ8qfgeaaxDnhggK2oa/g8he17xWv2IeJYppQ8atLUqS4JuEW9AL+xf/5vP5Gl0asCZ7lR7DE9ZAEXBnbgkHGU4PETjlmEeHGwvvtqQ35ZWw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8fcb15bf-4477-78f4-f8ee-33603ef20995@suse.com>
Date: Tue, 4 Oct 2022 15:10:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
 <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
 <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0026.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7925:EE_
X-MS-Office365-Filtering-Correlation-Id: f264ba5d-c537-49ae-d11e-08daa609e11e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tO02Kr7dJAah9bWyr5ABt4XG1FyrAJlDflHCwQ6PWAGZGrZl3ES6NqUbbULXhNk1QgRSWulWqGEL2yBBSIWiMnrHbU4oYZhmmqR8EYZZfMfICHmM8nZJ+sBxbG2PMSM6qI1UTi0MfTp8JuhLcWBYsaJXONQgIW2qJZ3uhx+gX/6S4z0923atHnjB24GLA8EZskjwuokDwLIpO/g1KpBgQDZGMYW778v+gAxXvzx84IG6DdcwjJGAQzHf2qG+b6bhy6rqbiGaeAb66s91AsmEeDY8JfG23ozmgkpS1Oa1FfnPaIdOC5ouPE5ZMGKSYizOmJjr23PkwV9IPLPQRZBk1hlm7HwosOY45ghIK259dUu7KdtHebxeJoIaR4cfI08qfDnor3uiyEKWOnIS8RqVbOETqJCX9pz4JCDt9+mHahGhdqcf218g2+PHA2M5Ch7pnpShavTbJcgauNRPs5qdF4IctZGBUe8aOM1r/LRObc34jbGtAkVBfkeQaEIGNUrp4HwB0jHo0GRBqvry0CbXL4wgHiLuVINf/pkRWsFWxQOkFqbLI6t1c8lbtYeAO9Y00NA9OLg2hxMlmPjpDRugfeQHlblqYg7rDRVgu4RZztnJUH2ocJUsKv6gMnkcRP3SWLhRbkbungaOHWG5vYhQeUo5T+aSYPCZzaNl+uKLlz8p4uhTa0W9qWFkMoK+aSPcyb3H2D2WQD9oVpirkgpTrK/6QOADU9pD5A9qXsPFN1E0GDhqSj4eetGnVsSR/kfuwemp/9yuTHX5cKF3EWwZm/WZyPiZzaTNMLpHqFBk/L0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199015)(31686004)(26005)(6512007)(66476007)(316002)(6916009)(54906003)(31696002)(38100700002)(6486002)(8676002)(86362001)(36756003)(2616005)(6506007)(53546011)(66556008)(4326008)(5660300002)(66946007)(8936002)(186003)(2906002)(478600001)(83380400001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGRxdmtwc0R4Z3lvdmZWb3IzM0h6NUZSMFV0TERzYVZVbXMzb1pjMldkWHpK?=
 =?utf-8?B?U3VEaUxGQUI1MjFjU2tJbGxPcTRVaWlMNThnTmJDWjIwV2t2UVhFL2U5eG1j?=
 =?utf-8?B?UUt2QUt0SGVVeVM4NTFXSkpmZHNzYUdMMkpOSVJ0SEtXay9jUi9RZlFIRU94?=
 =?utf-8?B?dnFtRE5OeFVncEp1L1pVOVF4Y0gvS1Y3L05aV2RGWW5ScUttUjV6b0ZCei9B?=
 =?utf-8?B?MkFNSHo4clJqd0I5bmU5VG9EaUFlVDBsVml0UlhQTkhwdEtnSVRTNm5ka0pv?=
 =?utf-8?B?S3d0Nzk3TGxWWTVGdFNSaWhnOTFJQ3M3V0p2QWtVSEV6R3NyVXRhaGU4clpI?=
 =?utf-8?B?MDlKQUtDbVVzZjBaS1JEaFpFTFFUVHFlUVhlVDhzNWp6WDQ3dmRPbGs5czl2?=
 =?utf-8?B?Z2lhdXBpNkQ4dnJ3VHdGNWIraXdWay95NkdlcTR1d2NEa1BJaHVDOGZXM0tQ?=
 =?utf-8?B?L3c1ZlFRODlCRnVnb21JTmNTdXl3MkZMUXhWYkFPenBHUmhHbzRteTN5QzU0?=
 =?utf-8?B?K1l2M3JSTDJtZzlPRmpTYWFNL2NyOGxkcnM5b2RXZ1pLQWcxSVhjTkJwOG1Q?=
 =?utf-8?B?akZ3dHNVNFErNHJVVDZhZjNLbjVZR01hNmkra3hnZnlldGx4ZGtCTXBFck4y?=
 =?utf-8?B?UXFwNm53dURFblAxd0djZWtmVTViMzVGR1pKRmVVdnVkUEdrS0IxSXFkWVBG?=
 =?utf-8?B?aGRoQU40TDZ3eTh4alE3SnVzK1JsdlloYWRZRkF4VXpXWUpvZXk4RE94UkJ6?=
 =?utf-8?B?YzgvaEVCb2RnT0I5TGlWUVBsZ3RuY3lSNnpqS3JTWmtQdFVkR2lSN25YZ3pU?=
 =?utf-8?B?UlNIcytOVDJ1MmhMRWdQdXpVVU1zUHNRVmw2cWVtOWVuWUNKUjFNSUNPTncw?=
 =?utf-8?B?YkVQYk5zQ1I3c1lLWk9RYzFRdjFucitOdkhoREtkRXp3cTdRS1JsU3VNc0tI?=
 =?utf-8?B?RnNZQnViellHR1V3YXU3bm5wZ0xHcmc4U2ptc0s3ZGNENmxYcDVmYzRaVG1t?=
 =?utf-8?B?VUJveFhrdFBxTklVSXZzRGVvS2xDQlE5ZlRvbEJJb2ZjMFNSRzhxVFhabGdr?=
 =?utf-8?B?TlA3TEpmbHZGbVl2RUJRU3FFWk90YTQyN2o0cDA3UElUYkhJWEhucVlBbTAw?=
 =?utf-8?B?Wm1JRnI2ZnFEakxDU3U0S01leWNrMU0vZlhIYklqVzdqV1kyK2dscVRRSmNU?=
 =?utf-8?B?aXBwZFJVZ09MV0xCbVlENHdZbldSVGNpQ3FzalBmcjNiOXRrNDAreS9aRHMx?=
 =?utf-8?B?aEQ0RmdvUTNIZlNrcXdHY015UjJUSmU1YVpWWWhJMjUwLzBweWlOYTJFWi8r?=
 =?utf-8?B?OURXelZPbS9oblFlVXllVHdDbmUzZzBnekdZYWpoUjN6MlR0RndMemhJOXlO?=
 =?utf-8?B?a3hYbW5nYkJNL0IyZDk2N2Fzdlg3ak1aNWRzNFUyVGhEQnlwSnlTejJvNURq?=
 =?utf-8?B?cXRwWm5JRmNGemZwZWh6NHROZDJ0N3M0Qm5ITVBpWkdPTXpWWTB4d1gzRy8x?=
 =?utf-8?B?NS9yVU9rVTFvZnIwdjNRenlQOGhaNlBmbWtMMkVrT0pYZG1Fc0d4elVCOEhq?=
 =?utf-8?B?WGVCeWpacm9SOU9JS0t2TlFmNW83bmtTekg5MzdPUmhxbW9hTHBsTC9iM2Ux?=
 =?utf-8?B?SjhtaWFKNnBiT2dTTnlvSTlnUTIzWTdMMkxjYzZObnl4L2x0UWhxdG1GMFRP?=
 =?utf-8?B?NHNZaW5LRzJ4MWZwR2NUQVRoRzhSenhmOGRnU050dHV2LzNIWGFkSllkOWJu?=
 =?utf-8?B?V3ZZZGJQeGpPU0Q4TWRHTG9IY3BNV2ZLL0JJZ21oeVY4MHFTS2RnSXFhYVl0?=
 =?utf-8?B?aWtFZlVPbXZXVGRreEQwdVJRVUl2bzQ0MDd3UUN5U2NRd3R1VmczSWE1U0JO?=
 =?utf-8?B?cWUzZkpUbGhUUkNKNnpzTXFCSFU0a0RoMzQ2VGtHckZ3Z2RyV3hCcnk4bHEy?=
 =?utf-8?B?V284RHpTMUxYQTlGdGh1a0lxendFV1lYY3gyZTQ0ajhoUVdVSE5Idys2cnA5?=
 =?utf-8?B?Rnl1eG1NbVRvQVZEVzFtYUxiYnlLQ1dFM3R4enQzMFJadmxUMTBVU0dZSzJY?=
 =?utf-8?B?eHhjbzRta3BhV1JxYVhiZ0RXTmZUbm1HSzBIMVc5V3EraW5LbU43cjN4czh2?=
 =?utf-8?Q?0YHmZllszjeHUaOTJsnCLkrVm?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f264ba5d-c537-49ae-d11e-08daa609e11e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 13:10:58.9562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mfMgm8ZHwaGQNP1O13kTUiQhvhCKPIz68KwB30Ft+JkRzOJA0jsBx2UwOqx0oyDLZ/eWgC6wGUSsgYwseWPpTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7925

On 04.10.2022 14:52, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 02:18:31PM +0200, Jan Beulich wrote:
>> On 04.10.2022 12:54, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
>>>> On 04.10.2022 12:38, Roger Pau Monné wrote:
>>>>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
>>>>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
>>>>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>>>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>>>>>> runtime which was re-used for other purposes, make
>>>>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>>>>>
>>>>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>>>>>>> dom0 doesn't try to use it either?
>>>>>>>>
>>>>>>>> I'm afraid I don't understand the questions. Not the least because I
>>>>>>>> think "it" can't really mean "dom0" from the earlier sentence.
>>>>>>>
>>>>>>> Sorry, let me try again:
>>>>>>>
>>>>>>> The memory map provided to dom0 will contain E820_ACPI entries for
>>>>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>>>>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>>>>>>> overwriting the data needed for runtime services?
>>>>>>
>>>>>> How would Dom0 go about doing so? It has no control over what we hand
>>>>>> to the page allocator - it can only free pages which were actually
>>>>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
>>>>>> DomIO - Dom0 can map and access them, but it cannot free them.
>>>>>
>>>>> Maybe I'm very confused, but what about dom0 overwriting the data
>>>>> there, won't it cause issues to runtime services?
>>>>
>>>> If it overwrites it, of course there are going to be issues. Just like
>>>> there are going to be problems from anything else Dom0 does wrong.
>>>
>>> But would dom0 know it's doing something wrong?
>>
>> Yes. Please also see my reply to Andrew.
>>
>>> The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
>>> know it's required by EFI runtime services, and dom0 could
>>> legitimately overwrite the region once it considers all ACPI parsing
>>> done from it's side.
>>
>> PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
>> only appear in the machine E820. In how far PVH Dom0 might need to take
>> special care I can't tell right now (but at least for kexec purposes I
>> expect Linux isn't going to recycle E820_ACPI regions even going forward).
> 
> Even if unlikely, couldn't some dom0 OS look at the machine map after
> processing ACPI and just decide to overwrite the ACPI regions?
> 
> Not that it's useful from an OS PoV, but also we have no statement
> saying that E820_ACPI in the machine memory map shouldn't be
> overwritten.

There are many things we have no statements for, yet we imply certain
behavior or restrictions. The machine memory map, imo, clearly isn't
intended for this kind of use.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 13:15:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 13:15:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415548.660145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhlM-0005UW-Fq; Tue, 04 Oct 2022 13:15:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415548.660145; Tue, 04 Oct 2022 13:15:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofhlM-0005UP-D3; Tue, 04 Oct 2022 13:15:08 +0000
Received: by outflank-mailman (input) for mailman id 415548;
 Tue, 04 Oct 2022 13:15:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofhlK-0005UJ-JM
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 13:15:06 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8fc8c7c9-43e6-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 15:15:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7865.eurprd04.prod.outlook.com (2603:10a6:10:1e2::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 13:15:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 13:15:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fc8c7c9-43e6-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Eb3MQ/w8ptHweIjKkwuiD5oaEOT50/oIyUrKQP++OShUTclJEkcII92I/hzVwzQSDPveZeRsjZyY5j6nboatAMk1tUnFAhYzPjfGqsfpqRmU+95UXFKwyfXVLEMvzFFHLpwnpp4alB0c1GSeo4zVEjqY6ZqZ7ZjrEeGvZRLPtIP7DP9rsywxQ1odQ7dAhx31OWXfYilhuC8c0tx0W1AmMp9qrRd6PQTv01imdMdgHtCp/ScMkMNAV1e7TNVZ03Z5grFN/XFKp3ocEAgHHFygDYTVIQ5vD4WUF9F0gfCuXmGmcDt0pGkb/7l2JPj0xY1uwv1cWLElgymgcOX3QrpRiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WY28JleGgm14bR/Hoq9wXLhD9K8eFTzfudYbdELTh2U=;
 b=ENv1VkAA6L/aafP4KmMVnfzgkpo8UbRoePDEK0mnkDzuIuNOI0Rs4esYL6q0/3Ulqehh/g8IZABvnIlnKuLg7hc1q1FNpaURVmR/PbTQCUe82pqnresJ9uA7hqfq1tMSrEdfmjDj9OFaCGGQ+ulhImfj29vAUkE/XNL93B5XQsfNxxUtBUnJkzYgpF+BItxkMj+Lz3DHjKMvcEqw/2A8use0R4mNQ66ik5CAl4c/VYmMXDmu66WXmX0hBYoZYl1TCFNhwkwHWzJcEl3JST1r5Z17W2q/lu8HCOKNbruMlxGSc2Mn4BGPVhmMMh001KWLaqMlA74Y5LNM6QqX2L1llQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WY28JleGgm14bR/Hoq9wXLhD9K8eFTzfudYbdELTh2U=;
 b=Z7lG3ob8O4yG61JFnUyx1c+VHpmF+1yVApZ/HZ/3K1Oy+6gqUE/sb/7Tg0uMhkPSTDykafilM2i5gj/xpYGqD7yIZ6N+MRhS/D3Fz9w9ZNkQ82qMvyWlOmqdzBC0myY4uoY1+BK1lVJxtWvSSCtVuiZkxn5HVMzGRnQ/G5olLLmQ9jwHuUt7vQiiSAZcXUmrTdNUoPZ2TxCYHRtdKfXL3nNMxik+0YnRXGbSC9e6M1BqvCtqolyhE3aqdb9TrMkXEYzyzZ9u01qRum0eSNF9YM/AUC4B6P2br9Tl+zr9QYCrT7tkOAekM4MxVdiN7kOcpoNOLks+TxkBFHdO6hVfvg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5c0f68e5-145a-1616-a128-a2b1a602c1bc@suse.com>
Date: Tue, 4 Oct 2022 15:15:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
 <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
 <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
 <2d49fdfa-bd76-0469-0840-6260c5a8ff48@suse.com>
 <YzwuJTOtcIopeOlm@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzwuJTOtcIopeOlm@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0066.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7865:EE_
X-MS-Office365-Filtering-Correlation-Id: d5f66f00-ba43-4420-4bdd-08daa60a72fe
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	36/iQytJByrDeMEZ6T6AOWADHbeZEWx3ISWYf6c4llxJNqxhDf9sBI1sCTdNi3RfWj9sfBsmnvgASDHZwHob+Lv7sC5pwrKOcxIdFPSIfzkAI/zBJnzBRlvycCxdOsI00QIYGawBdIfttLI9gzfy2NzRzfivKpQdSqDPh5D1NWw+D6MIi/Sy+NsGqQNCmGKQ5/fG9RjJ5qUsw1hJDQ8+JSDqWNQ0cEgVvOEMlXtj7OBjSE7uq+9n7yVOcQdkZwz6YOZZqdoZSUx1wel4i1lOso1p9N1/rnhK6NqLonNImbidBrvSJafK0CZM2GMtmdpNjgyTxj4poUvQC3jYgNGJc32ct+kx0btxBmECWu+jcLMp19smleYvbIu8Ru7GpWESUHUXVhV8cN8IkWmKv0jUwHcz4Z1uk/ljiw/Jq/T/aL4YibHJgM5gW96MhJbPWMRU/c1WvOGGo2cmej9NNeZGs3JJUFalhRLQxs6+T1BOIn5do8PPIOFpSmlJ4qEi3pRK9Rh8N+V9XeTpQMquUW9tvRFnKlaQFuJw81b4/8M2NK8mXXxR1gNB3OMYSk9MnprgV92mU7J18Zdsf6oxO1zAzUMRbCoxsGSFRuSS7s2HlqLNHB/l42Wr38W4dnQGtdRMECrtKN+xLyZdOSuX4wMrVBK0oSubB/hSIrpVlgnqa4v94sHtYTcHs9LpLIJWViq3KUlsL04y0eeQI2ma4OQINhZp7riQ4oMH/WsZ6xnunTpdWOaMrGYx2ecmm6/12yvbxRupcvndIPCS4eAGqPPzMSOBZnVgVR8M2s/zDlEtEas=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(376002)(396003)(136003)(346002)(451199015)(2616005)(83380400001)(186003)(38100700002)(5660300002)(2906002)(8936002)(6486002)(6506007)(26005)(6512007)(478600001)(6916009)(53546011)(66556008)(316002)(66946007)(4326008)(8676002)(66476007)(41300700001)(36756003)(31696002)(54906003)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y055TnE4VWxZVjdDVk9BZWpkYXdTQWJqUThXUC9lYzlqMTF0eDI4ODNOdGVa?=
 =?utf-8?B?L0VWRjNiaTNEOGtrR0EwVk9PVnhuTXh0Nzk5RTVDYkpxWHQwUW5QZFVpcTJt?=
 =?utf-8?B?OFYwWi9abHF1akJmMkduczhua3cvSm93QTcveVd2WURYbER0REJRZ2V5dTVy?=
 =?utf-8?B?YmhsUU5Wd2srNXAvcWxOU3h6TVhzblNTdHl2Q001MEZTVmhzbkJIZzJzc0Yv?=
 =?utf-8?B?aGdSQ0hmYksyL2x5S0NtR0pNZTViS0NUWHhsRFE0UnVzbkR1My9VZ2lzT2Y0?=
 =?utf-8?B?TEFTc1NKMXd5Qk9vTFhzOTVGNDRtNldneklZS05TSW5QRWtGdy9iQ2VRM2xB?=
 =?utf-8?B?MHR5RUloT3duUk0rcG1QNFJJRFRUMWtzbHdSb05lb0NOclpTSjJaRERTNFd0?=
 =?utf-8?B?Y0crYVJtWmVneGNyY0hDQkh5UWtkSWM1KzhZaGNBSkIyL1VMVHNiVEpyQXpF?=
 =?utf-8?B?KysxUG91U3Jnd3lDQU5KbVlLcHhGa1dKbTF0d0QzaThpV3BnZ1dmSUVLZTlP?=
 =?utf-8?B?TUttRUQ2bFpXWnFxY3F6TE8xMHFWWTBTaW03eWsyTmNXb1Z5RmthTEZtSVJN?=
 =?utf-8?B?TXJ6ZGhLZkdXTWRnMHJvamkvRW9LdTdjdkZYZktjUSs2WWh5cGh6RlNiNjc2?=
 =?utf-8?B?dzFtc0ZGSnRIYm9uZFdWelJXYWo0bFVQOUwrYkFhODk3clZsZnI4YW9sWHM2?=
 =?utf-8?B?dU00UytxSEdoTDYyNWxIS1dWTHBndStITmcxZkNIcG8raUM2WmNyZ2E4ZlpE?=
 =?utf-8?B?SkdGQ0owMndHNGQ4ZG1WVGd5akdCWmplR2ZkeTEwK3NYVENQbzAxL2VubXVz?=
 =?utf-8?B?a01JQk9zY2VwTmtNK3dvYkk2WHF2dlgrVWpjRWd5NUdRalZzVkwzRHYyQmRU?=
 =?utf-8?B?bitmMld3dHFKM3J0d3ZleFRPN2RQaU50d21nNDNtUGlUa1VUaVo5S1FDMXFo?=
 =?utf-8?B?c1RaUTBKVUpCc3B0ZFpRaXE1VnhLZ2RmKy9HVjJVRVV1Rkx1SC9Gb2pwajVo?=
 =?utf-8?B?MzUxbnBEQXFwbFgwNXlhTHM2Uy8xOEY2WEtPMVlIY0N5Y1ZxVGFIcXFCK2Z0?=
 =?utf-8?B?N0taL09hUXd5cWw1ZXd0aXZidkZPaVJTK2YrU1NVUEEzc2doL3B4aEJ5bHBk?=
 =?utf-8?B?OUd0alNHK3VUc0N1Qjc4NnRORHlLYklUZ2gxYXFadHZMMjEyZE4wOVRscmYx?=
 =?utf-8?B?N3haYVNnTDR1U0Z1OTBRSUhHZStDb3YyRlJLZndkOUJibkpQRjRKV0xvakpt?=
 =?utf-8?B?b0J0eU1TQ0xJZDRnek42MXVHNmpsNEgxcnd4NFFyZjJDclBEUkNvNmxNc0tH?=
 =?utf-8?B?WG5SYkIzVUxJQlBPek8wOG01cHdaTUJDSXRqTEg4U0tVeXd2OUxsVG41cmJa?=
 =?utf-8?B?L1pReDM5ZzRjRzg1RUhiVlJuVksyQUZhMkNMdC9QUWM3WXIvUGZTZWpHN1Uv?=
 =?utf-8?B?TkxKY1ZMZW55U2IraUZGVVdtMG1mazhkcVVWT1BBNGxhTENSZGUyNTFpY0Ux?=
 =?utf-8?B?RTVrUDdmM1pUUlpYd0JITVo4MG5uZldCbmlZNzVlMnNPUHZXVHhpbTY4ZHZy?=
 =?utf-8?B?aXFaV0FtR0Nmc1JNR3R4Zzc0bW1FSnlDcmx5TklGK0Q0STRQSkVkTHlERkhi?=
 =?utf-8?B?UFZ0dHBGVHFwK2F5bzhlWEdTOFBDQlp0R0tKTVBHeUxvbzR5blJwK1VMcm5H?=
 =?utf-8?B?Vzh2cXlreGd3RFExVkI0bVpUWnY0WE13WGJ0WDBBdHN5a1VVaVd1bmtMSTVN?=
 =?utf-8?B?bHJZNEpEcXBSRC90d2ZOTXVWMXhVRW5HR2E0eEtoSUNMK0tjUmJQemFnMkNv?=
 =?utf-8?B?Zm5DaksrdlBuRVRFaCtIa2JRQVQyY2F0YUpJRXlpdG9XdDAyTjRKVFoyTXJR?=
 =?utf-8?B?ZXVSbGVqWTNxejUvZlJETk1UNVVZaFFoQ0E1VVRyZUxQQkdJY1E0c2xIczFS?=
 =?utf-8?B?ZEpxUkRsTXlBTE5mNjcydm90K2I4bERPY005Yk5pMFpHUFBIOVpzNVBjNFNr?=
 =?utf-8?B?ZXUrL2JVejlOYzZBVUxidlhyOUNDdVhmTmNCMWJXY2dyK240UGxaeHhSYnZO?=
 =?utf-8?B?VlZ6T0d4L0pyRW55azRHd09vOWFSZFh5aWd6aXRzWisxVVMvSjRReDE0QkVT?=
 =?utf-8?Q?M0LggRyftUIpPRHAqdLKwEfa1?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5f66f00-ba43-4420-4bdd-08daa60a72fe
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 13:15:03.6592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0O7CgoAbiUisN16+oiAtjV3OQbR7cw4Mhp47DS9G1FvXQAbYdARDjN+CXWzMpg2jBN/fQ1suJy0rDm9uaiJVWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7865

On 04.10.2022 14:59, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 02:21:20PM +0200, Jan Beulich wrote:
>> On 04.10.2022 14:17, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 12:40:10PM +0200, Jan Beulich wrote:
>>>> On 04.10.2022 11:27, Roger Pau Monné wrote:
>>>>> On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
>>>>>> On 30.09.2022 16:17, Roger Pau Monne wrote:
>>>>>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
>>>>>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
>>>>>>> devices used by EFI.
>>>>>>>
>>>>>>> The current parsing of the EFI memory map was translating
>>>>>>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
>>>>>>> x86.  This is an issue because device MMIO regions (BARs) should not
>>>>>>> be positioned on reserved regions.  Any BARs positioned on non-hole
>>>>>>> areas of the memory map will cause is_memory_hole() to return false,
>>>>>>> which would then cause memory decoding to be disabled for such device.
>>>>>>> This leads to EFI firmware malfunctions when using runtime services.
>>>>>>>
>>>>>>> The system under which this was observed has:
>>>>>>>
>>>>>>> EFI memory map:
>>>>>>> [...]
>>>>>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
>>>>>>> [...]
>>>>>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
>>>>>>>
>>>>>>> The device behind this BAR is:
>>>>>>>
>>>>>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
>>>>>>> 	Subsystem: Super Micro Computer Inc Device 091c
>>>>>>> 	Flags: fast devsel
>>>>>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
>>>>>>>
>>>>>>> For the record, the symptom observed in that machine was a hard freeze
>>>>>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
>>>>>>>
>>>>>>> Fix by not adding regions with type EfiMemoryMappedIO or
>>>>>>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
>>>>>>> be positioned there.
>>>>>>>
>>>>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>>>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>>>
>>>>>> In the best case this is moving us from one way of being wrong to another:
>>>>>> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
>>>>>> legitimately covered by a EfiMemoryMappedIO region in the first place,
>>>>>> which I'm not sure is actually permitted - iirc just like E820_RESERVED
>>>>>> may not be used for BARs, this memory type also may not be), whereas with
>>>>>> your change we would no longer report non-BAR MMIO space (chipset specific
>>>>>> ranges for example) as reserved. In fact I think the example you provide
>>>>>> is at least partly due to bogus firmware behavior: The BAR is put in space
>>>>>> normally used for firmware specific memory (MMIO) ranges. I think firmware
>>>>>> should either assign the BAR differently or exclude the range from the
>>>>>> memory map.
>>>>>
>>>>> Hm, I'm not sure the example is bogus, how would firmware request a BAR
>>>>> to be mapped for run time services to access it otherwise if it's not
>>>>> using EfiMemoryMappedIO?
>>>>>
>>>>> Not adding the BAR to the memory map in any way would mean the OS is
>>>>> free to not map it for runtime services to access.
>>>>
>>>> My view is that BARs should not be marked for runtime services use. Doing
>>>> so requires awareness of the driver inside the OS, which I don't think
>>>> one can expect. If firmware needs to make use of a device in a system, it
>>>> ought to properly hide it from the OS. Note how the potential sharing of
>>>> an RTC requires special provisions in the spec, mandating driver awareness.
>>>>
>>>> Having a BAR expressed in the memory map also contradicts the ability of
>>>> an OS to relocate all BARs of all devices, if necessary.
>>>
>>> I've failed to figure out if there's a way in UEFI to report a device
>>> is in use by the firmware.  I've already looked before sending the
>>> patch (see also the post commit notes about for example not passing
>>> through the device to any guest for obvious reason).
>>>
>>> I've got no idea if Linux has any checks to avoid trying to move BARs
>>> residing in EfiMemoryMappedIO ranges, we have now observed this
>>> behavior in two systems already.
>>>
>>> Maybe we could do a special check for PCI devices and allow them
>>> having BARs in EfiMemoryMappedIO, together with printing a warning
>>> message.
>>
>> Right, that's one of the possible quirk workarounds I was thinking of.
>> At the risk of stating the obvious - the same would presumably apply to
>> E820_RESERVED on non-EFI systems then.
> 
> One option would be to strictly limit to EfiMemoryMappedIO, by taking
> the EFI memory map into account also if present.
> 
> Another maybe simpler option is to allow BARs to be placed in
> E820_RESERVED regions, and translate EfiMemoryMappedIO into
> E820_RESERVED like we have been doing.
> 
> I will attempt the later if you are OK with the approach.

I might be okay with the approach, but first of all I continue to be
worried of us violating specifications if we make this the default
behavior.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 13:56:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 13:56:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415558.660157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofiP6-0001Xa-Mg; Tue, 04 Oct 2022 13:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415558.660157; Tue, 04 Oct 2022 13:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofiP6-0001XT-Ib; Tue, 04 Oct 2022 13:56:12 +0000
Received: by outflank-mailman (input) for mailman id 415558;
 Tue, 04 Oct 2022 13:56:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofiP5-0001XM-Bq
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 13:56:11 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 48590a00-43ec-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 15:56:05 +0200 (CEST)
Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 09:55:49 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM6PR03MB5289.namprd03.prod.outlook.com (2603:10b6:5:24c::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 13:55:45 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 13:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48590a00-43ec-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664891765;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=dfdStoyO+h5MNLXSV7IWhaBB7yGjFbW519k6WdhACk8=;
  b=VKe+jUMNmA7EktCHhAhsZp+ya88riNIuaesSSWwtk4/0V+A/+RSmAx6w
   DddbG0+JPrVyh1ypBir4+61T4biUI8PGVP2dc+jL0SjVh/Duh9Dv9QDlM
   7Jb+qb7TGjonRXHYsY9pbJn2i02wnx7i/30c9jXT+4dEZttUS2ITGszRm
   Q=;
X-IronPort-RemoteIP: 104.47.55.103
X-IronPort-MID: 81590465
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:qhZuma4T+l5yuck74BjcSQxRtCLGchMFZxGqfqrLsTDasY5as4F+v
 jFMDW2GPa7fM2Dzed5+Otjj/EpXupeHzdRlTwQ5+yFnHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gRiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5HC111y
 ewqdQwUYxal2sfmzJGfbrJF05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLl2Sd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL1276XwX2mMG4UPJvmrKdHhVSw/Wc4FU0ycEK5i9yk1mfrDrqzL
 GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/I+wBGAzOzT+QnxLngJSHtNZcIrsOcyRCc2z
 RmZktXxHzttvbaJD3WH+d+pQSiaPCEUKSoHenUCRA5cu937+thr1VTIU8ppF7OzgpvtAzbsz
 juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPdLNi1CAgbQD0ct9EQ==
IronPort-HdrOrdr: A9a23:NecAOK6plCC0IhbR9wPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN
 MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9
 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="81590465"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FKxmS9myChunW0/pdmuytCF0nzPs9VVvxOArGSieF5R4clYAqMoWjHis6lALYrEDL+iKpBcl7zaTWYnveNlDTE+DCh27BtEuMK+9KUqwix1A5hObSRFQAarFj6AbDvkG6FLgbq2l8JAwsGfMxpC4ROfnEudjJ/CFq2jppOYYrBV6x6x1VS52UrWFnq/p7yYvKiClXEsBVueKX4yEh7CAtiuBMEixVItdNyQw/decdGulK6Ut4AnZulfDTvc387TOW3nT5Gc7DbIDcXUYcxA9QSTtFw4f3rXBkOeqEyCX8da9I6uRlJMgBaOMjzh7B95kbZ1DEm0bbiwa1lD6QVNB7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FYSnlllqaL3Sw6jUTiMk8Dpoap57tZWhKEnvmSz0SGU=;
 b=C04Vg3SFPo4qtY276Ydkh0VCMF4dn3j7Rg60rGeuycjKmgDwyelW6NYauJOcC7q/QCnU1O4U38HiyfTIQrnnslZspXAnCzzId/2BvZnbAFj82ezaQX67fXK8NeBT7Dsp1npF7PF+d6iUN2qJ2aaOXMUGPuh8FXzv3QwsSrk9mNyZh6IEH+I0TqT9vzmfyHy3Uch0InQ2ID84JzvMl11doaC0/KJGcQriFPP9utoR3NPkWnsIWKKi9Kp/M6bFsOLHbEVXH0/DiFgeXtPrITXii2hrTvVeH/3jwWKHaeJxY+RF29S6K7MLQLOjfVTPsuu+w2yL1ndTB1NTD2EQX6TXTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FYSnlllqaL3Sw6jUTiMk8Dpoap57tZWhKEnvmSz0SGU=;
 b=BDwTvw7NKV4AreLrpQv9BeIFbQdM8ZnENAeY8EAuLwPxkPDb8+r4AQK9y81Ym0tkOq5Q8PK2t9JEoqAqkKG+4ByjwtCpmpv+1DHH2mELHQHiBwe40itZ2rjOSZjtyEuXIOAkSBwR07FliqVHn4R3b901o3ex6sUInEFgxZ37RDw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 15:55:39 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Message-ID: <Yzw7Ww1s+Ru6qXZf@Air-de-Roger>
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
 <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
 <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
 <2d49fdfa-bd76-0469-0840-6260c5a8ff48@suse.com>
 <YzwuJTOtcIopeOlm@Air-de-Roger>
 <5c0f68e5-145a-1616-a128-a2b1a602c1bc@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5c0f68e5-145a-1616-a128-a2b1a602c1bc@suse.com>
X-ClientProxiedBy: LO4P123CA0372.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18e::17) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5289:EE_
X-MS-Office365-Filtering-Correlation-Id: 45feafde-de58-4a9b-f481-08daa610222e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t/atnNW/Z5HZ24jtK+qwjOgNBu3ou2+zN1LwuRXhL/P/54wjAEz6CkxVtfyPyRHyiFT9cBQZvSWQPMOCpUEbLtNabN+BTNQJWg4v16eZpp/O8mpdkq0nuNj9KLA7uvdI14Fp8pWMPFAtAesB7/LwOWu8Y6lGv22QSztlehrmWDN+UmSrqEUM5RYxaa3nBpp3exUIpttqEYojbEnBi2rWSDne0M/f9inUStHGOzwujQLfG1eYaGvmr2xvVhO1YiklLPNSfy+7dJtbuBvl/pd4mZQdcA62vtsrP0QxyRC1l1xFe89rfaFHcmim8HugYWmtmnaJqKcLaJIjHtqw9DIhE1Z2luwkIkW5ovy8ag76T1nqQPN+T/xbjPa9Q9qcgTBSJcLW/m4f+Xt3d21X2A3hS3XxGl6jGi2Lp3jCi3bq1RKf37GRho1GyIpxAF3Uu6jC9H+mi+Gs2MlX46WsZL9u5vcxhqgfSwjrRz6MxtjfwtmUvMUmFPcPKzVNnRfgEv7LT1swvkl/Oof0LFej8AB+G09qzEBB4mxXS9jK8de16bLH7hOyXUOJdoOv1T6yKP+JtSZx3Arm8qIHFo4sAIseB/enE/xMLYkb4G5si2mV5F8qr59566QAqFix9g2/3FTJ6i8z71wZakHn7NoYQrbMdF+t1xayZ5d3tyCylsy1kKYzCgJBwlTKNUJhHxhP6BxO0cjTxQ0MYKe5KwUpmHh0Fwd2aMCcJK+xvizt8i1nuH/yGY6AcISCPkNl2vBzk9BT73lvelkWvJOmmmjsinCkQg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(8936002)(41300700001)(2906002)(38100700002)(478600001)(83380400001)(6916009)(85182001)(66946007)(6486002)(6666004)(66556008)(66476007)(186003)(5660300002)(54906003)(6512007)(9686003)(26005)(8676002)(33716001)(86362001)(53546011)(316002)(4326008)(6506007)(82960400001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YXNLOFp4UWpVZHRUSDZZTVhrOUFmVlVlMnQ0QkJSTU1yZXQzcU04NFpaYzBW?=
 =?utf-8?B?cVZNNXRaaDQ2eUNyRnJzR0JQdEcrVHJCRmo3ZGFPODRmMkFSRU1BcmNORDZt?=
 =?utf-8?B?QkcxU2RheTZxcXd5UTIxcVJRbG9YRzlxQzUzVUJzWlVBLy9Jcmptc1Y5aUpo?=
 =?utf-8?B?NjA4SkpiaEdVeGxjRU1nNWpMREUvSzAzU0ZvUXZ2ejVXS3N5ZHFSVWZ0OHZK?=
 =?utf-8?B?VVZVWFJIQmw1YmpEc252S20vNnBRdkFMM0NqYUVzMFVUODdvNTN5S3Q0NGs1?=
 =?utf-8?B?M1VQbU9rV2tDUm9QQjgydE1IVnp0VndWdWw1Y1QrOExRMHdETWpCWC9TTW9O?=
 =?utf-8?B?Y241Ty9vRExicENmUktFNkg5WHAxaDJOcHo3Q1JJRjltdU01SmpTNUpmSnk1?=
 =?utf-8?B?N2ZmaGVtWjl1Qkdta2o2ZzV2MEU5SkFsdWxPbVBJamJwWGFIK0xSR09DU3dZ?=
 =?utf-8?B?NFFqK0ZWeWQ4LzlhVFdrR2FaWGZueStpNlYvS3A2MWt0WGdGclZXVFBHeURh?=
 =?utf-8?B?bVR5WWdVcWJnbTZhaCsxU2xkTFFkRjNsaHMvNzliWVhVUVlTSU5xcEw4NWRR?=
 =?utf-8?B?andxTDJwSTdZNG5OYkVqaHNxUk15Tm5VV3dvL0wyQ09CUlErTlUrL21jSEJ1?=
 =?utf-8?B?OExUcUJrWlU3RXc3NThHNWl4NGtKT3o5eVBQcjB3Q2tQS2hITHZUWWdiL29m?=
 =?utf-8?B?b1RCQlF2eHFhaURpeVdTQmZ3Z3RFbEZaR3ZST1daUzRoU0I4aUlRbDBCaUJp?=
 =?utf-8?B?RGxvMGJrMk9RZkh2ZGd0RWVDT0h5ZUIwVkZGUUh1cHF0aXJMcE9DbldOMURk?=
 =?utf-8?B?aXE3TS9NQXI1dms0UURqTkJRTTNXUzl4SUxHbjBLQ0IxYUtiTDBZQllzcHh0?=
 =?utf-8?B?blRjRlQ5TmZOcERINjZTQlcvUHhQemxlNTZZZGFHaUh4bGVFMWZndmxRZ0w1?=
 =?utf-8?B?S1ordG15YjI5dkl2Z1RoU1VjSjZXUDZNY01GZFFITGt6c2JPbUZ5bStKaFpo?=
 =?utf-8?B?SXExZ3pFcGc4L2Rkc0E4L2hPNjQ0VDU0SmZqbmgwQmtCc0NRL3lHMXkvbW1P?=
 =?utf-8?B?b3Z4anVQL3hMT3lEUWNXYTU2bEM1VkxTVVZjMXBXVjZEUUl6YVE5VnN4TnZO?=
 =?utf-8?B?M1Arcm1Qei91Q1RQTWNvNHRRRGxZQ0VyS052eE15SWt1ZEc2VE4yTGY5Yzda?=
 =?utf-8?B?bTdSbUtPZTRsZ0l2RGttTlg2OHhOY2JxOVBFZ2daTGJTVTErVXB2ekJLeE9I?=
 =?utf-8?B?akZ6Rm5PY1BIZEtzUHdnaElic0M5OHVEWUI1QzdpZjk5RlpGOGRBRmRyVXla?=
 =?utf-8?B?bnFPL3pSNU0rTnVQVm52d290RGliR29samp4T1FNYTNjeE91NjhKem5ESnhG?=
 =?utf-8?B?akdFbzd0cGZjNFV2QnpXV0tNb0w1aThtU2JBeDlrQ0J0U3R3a1VyR0ZWSm1S?=
 =?utf-8?B?bitsMGwydVMwVHNKWGNvZU1UL0ZiVTh3Q0VXOUxhOTJJU2czdGxaOVQrVzRv?=
 =?utf-8?B?YmtpaDdOSVM5Q3RVd05JY1JCVTJ6K0N2bGZOMVpMbkM5TDdsR2NnVG1UVVNO?=
 =?utf-8?B?TmJ2K1hHdSt0RkYyWlJhKzlmeEhxQUZIL1FMc0lYZ21yRDV4K3hBaDdiZXA0?=
 =?utf-8?B?SWpJRzNSRVlWRFBFdFJzdWJWOU5IYlBWWFBYQnFsNWR6NXpiNlBLVm9HczRN?=
 =?utf-8?B?MlJDUC9BRnIrd0Q0NjJNcmNxZHgvSVhRaVI1TGJKK016ck41ZzJyTStTTUR2?=
 =?utf-8?B?VThaL0FtODA4RmJPaEJFSEFWSysvekVyTVE4cmJsRERzS2dPSHlrakptcnJR?=
 =?utf-8?B?UFE1dU9PR0EyNFpBTVVNdkRVMU00SVd1MnEyL1pJSjB1NjVCWnpwelFqSEZa?=
 =?utf-8?B?QTA2THcvdENDdloyZFdybUxsZm5Kb2NMdkJJRXhhV0UvbGhTS05tZm04bjVO?=
 =?utf-8?B?QVVlbEVYUjJPelozdlV5bUlETXJFT2haUUk4NlBBZThoZzhuWU1UWCtDN3Js?=
 =?utf-8?B?eW9JVGtzbjJuTitnSytqcWxxaEQvSFdxUGlqWDhzcmFpQU9nekxnSHBwL1Fh?=
 =?utf-8?B?MkxNOGUwN3Y4NXJscDc5SEZKbTlvbFpmWWJFMlFjazZCN2tyazFzTDRNQTVy?=
 =?utf-8?B?UkVVN0VBaDBJcmNCQitTNG9kaUZLTEc3QzhKTVpzT3QxSFFwem1BMFpGT1ls?=
 =?utf-8?B?Z2c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45feafde-de58-4a9b-f481-08daa610222e
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 13:55:45.2504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sI93bCXDBLNNlQ1cKZt6/8venp++sEETQcDwP62Ch16y5x83t+k9k5hKorYf39jgM8PVChzbF639iLgEyKSCug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5289

On Tue, Oct 04, 2022 at 03:15:02PM +0200, Jan Beulich wrote:
> On 04.10.2022 14:59, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 02:21:20PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 14:17, Roger Pau Monné wrote:
> >>> On Tue, Oct 04, 2022 at 12:40:10PM +0200, Jan Beulich wrote:
> >>>> On 04.10.2022 11:27, Roger Pau Monné wrote:
> >>>>> On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
> >>>>>> On 30.09.2022 16:17, Roger Pau Monne wrote:
> >>>>>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
> >>>>>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
> >>>>>>> devices used by EFI.
> >>>>>>>
> >>>>>>> The current parsing of the EFI memory map was translating
> >>>>>>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
> >>>>>>> x86.  This is an issue because device MMIO regions (BARs) should not
> >>>>>>> be positioned on reserved regions.  Any BARs positioned on non-hole
> >>>>>>> areas of the memory map will cause is_memory_hole() to return false,
> >>>>>>> which would then cause memory decoding to be disabled for such device.
> >>>>>>> This leads to EFI firmware malfunctions when using runtime services.
> >>>>>>>
> >>>>>>> The system under which this was observed has:
> >>>>>>>
> >>>>>>> EFI memory map:
> >>>>>>> [...]
> >>>>>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> >>>>>>> [...]
> >>>>>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> >>>>>>>
> >>>>>>> The device behind this BAR is:
> >>>>>>>
> >>>>>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> >>>>>>> 	Subsystem: Super Micro Computer Inc Device 091c
> >>>>>>> 	Flags: fast devsel
> >>>>>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> >>>>>>>
> >>>>>>> For the record, the symptom observed in that machine was a hard freeze
> >>>>>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
> >>>>>>>
> >>>>>>> Fix by not adding regions with type EfiMemoryMappedIO or
> >>>>>>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
> >>>>>>> be positioned there.
> >>>>>>>
> >>>>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> >>>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>>>>>
> >>>>>> In the best case this is moving us from one way of being wrong to another:
> >>>>>> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
> >>>>>> legitimately covered by a EfiMemoryMappedIO region in the first place,
> >>>>>> which I'm not sure is actually permitted - iirc just like E820_RESERVED
> >>>>>> may not be used for BARs, this memory type also may not be), whereas with
> >>>>>> your change we would no longer report non-BAR MMIO space (chipset specific
> >>>>>> ranges for example) as reserved. In fact I think the example you provide
> >>>>>> is at least partly due to bogus firmware behavior: The BAR is put in space
> >>>>>> normally used for firmware specific memory (MMIO) ranges. I think firmware
> >>>>>> should either assign the BAR differently or exclude the range from the
> >>>>>> memory map.
> >>>>>
> >>>>> Hm, I'm not sure the example is bogus, how would firmware request a BAR
> >>>>> to be mapped for run time services to access it otherwise if it's not
> >>>>> using EfiMemoryMappedIO?
> >>>>>
> >>>>> Not adding the BAR to the memory map in any way would mean the OS is
> >>>>> free to not map it for runtime services to access.
> >>>>
> >>>> My view is that BARs should not be marked for runtime services use. Doing
> >>>> so requires awareness of the driver inside the OS, which I don't think
> >>>> one can expect. If firmware needs to make use of a device in a system, it
> >>>> ought to properly hide it from the OS. Note how the potential sharing of
> >>>> an RTC requires special provisions in the spec, mandating driver awareness.
> >>>>
> >>>> Having a BAR expressed in the memory map also contradicts the ability of
> >>>> an OS to relocate all BARs of all devices, if necessary.
> >>>
> >>> I've failed to figure out if there's a way in UEFI to report a device
> >>> is in use by the firmware.  I've already looked before sending the
> >>> patch (see also the post commit notes about for example not passing
> >>> through the device to any guest for obvious reason).
> >>>
> >>> I've got no idea if Linux has any checks to avoid trying to move BARs
> >>> residing in EfiMemoryMappedIO ranges, we have now observed this
> >>> behavior in two systems already.
> >>>
> >>> Maybe we could do a special check for PCI devices and allow them
> >>> having BARs in EfiMemoryMappedIO, together with printing a warning
> >>> message.
> >>
> >> Right, that's one of the possible quirk workarounds I was thinking of.
> >> At the risk of stating the obvious - the same would presumably apply to
> >> E820_RESERVED on non-EFI systems then.
> > 
> > One option would be to strictly limit to EfiMemoryMappedIO, by taking
> > the EFI memory map into account also if present.
> > 
> > Another maybe simpler option is to allow BARs to be placed in
> > E820_RESERVED regions, and translate EfiMemoryMappedIO into
> > E820_RESERVED like we have been doing.
> > 
> > I will attempt the later if you are OK with the approach.
> 
> I might be okay with the approach, but first of all I continue to be
> worried of us violating specifications if we make this the default
> behavior.

In any case it would be the firmware violating the specification by
not hiding those PCI devices, Xen is just trying to cope.

Xen went from not checking the position of the BARs at all to
enforcing them to not be placed over any regions on the memory map. I
think we need to relax the checks a bit to match reality.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 13:58:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 13:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415567.660167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofiRc-0002Bd-65; Tue, 04 Oct 2022 13:58:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415567.660167; Tue, 04 Oct 2022 13:58:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofiRc-0002BW-3A; Tue, 04 Oct 2022 13:58:48 +0000
Received: by outflank-mailman (input) for mailman id 415567;
 Tue, 04 Oct 2022 13:58:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofiRa-0002BQ-8Z
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 13:58:46 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a8e48625-43ec-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 15:58:44 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB8108.eurprd04.prod.outlook.com (2603:10a6:10:25e::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 13:58:42 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 13:58:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8e48625-43ec-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e+YAbk6FF+1IX4pP01bEmLqlQmSJ6CjEJc0gov98Q7CKFPeMi0yoNMtudd1MsnNiyEYpX5fADzaBLVCztoNiYHJVFHQZEq+g9fnY4HMyQhcZZFtp+BoYTs73hKszwyaq6F8RV4PArOcGS0PDHt+Yok8uIZh1O91bB/9z9ItB6m7U11B1pbOT8gc0BWbBis4+U2nCc/2n+LXA6Q6wN7oevWOn7A7jLI7+kgNAlhalyKX1JXRtvNgcfUtoUDxa+nqWTM//RCsWk8r2ZA3hncasMIXhydjfDT+aKRLdjE3qMmHSfgDGxnEu5bTj9jebkQpVfAjUSfzl6VpnQF6zJ1MO1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AgVmzK68D2Jyq4zTvV5t3uOOLG3wVAeXmYV9fky4Krc=;
 b=VuqHzJd84Dd8KFAj++25nCvfQwKAz6If2CM5i4Be428KDwpZ6C0aPVrZKLNz9e2Ofn7PsaMH4bG7r6cKq70eT3JpveMcWa2FqmwcXSirQuHFDs5hlFvRNk3uQJdBAfWlP88lysGgtazbWrUt1b7L8tRVh7tEQb4/3l4x3h3FL5LNYSRAlvhwAJT50KG9R6OYEsyWyEtinbxO72W1AnVsUl4ex5+kJ/bfu1LpzSC7vCfcANarsN01N/AFmPiJEw/KBvgPXZfE44cl7Ta4Czy8SnCK6heIR76xpiSVT1D9ghQEyOyu5EEBsld+WmvfV72DvVEmhh9QzND/nPkVZs+kaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AgVmzK68D2Jyq4zTvV5t3uOOLG3wVAeXmYV9fky4Krc=;
 b=gK6GJp5tVUY3w442juV3x/YP5gaXSeZo+AgJKswnLvDqhZNDR3RgPXv5I+A7IAuQdsB+xgIYDwRXjvdb5pO65YsDI0HM8EdcZDfuRM8d4f6rXiuEraCWcZO/JRo74Nt7loEBIT2w988HxWlkNb3kPvkNy/Mn/yyqtutptTODT5Qwkn0khFYs2M6/XE1vS8Pdr/7OuAmxMizN+Yrq4LeeMxEaKFsxt5/moQj/cjNgursXimzUdsA14L7UmsZFq4SVZC5XMn7U8TRClVOVXCzVB2GZpClzVgBycJsjXVUNSCmK/bkmMP4QxjQviqWJmJn6L952yPql9XaHjMo3QwpL+g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <000a9090-df13-6f43-1ee8-0e637714356c@suse.com>
Date: Tue, 4 Oct 2022 15:58:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/efi: don't translate EFI memory map MMIO
 regions to e820 RESERVED
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20220930141737.67574-1-roger.pau@citrix.com>
 <e3235c0f-5964-0f95-fcc0-bcc44bf9d784@suse.com>
 <Yzv8lpnf28aXgQQM@MacBook-Air-de-Roger.local>
 <ea544e76-0dfd-4f24-89ef-25265f7b049a@suse.com>
 <YzwkXh+8xzbCZdkO@MacBook-Air-de-Roger.local>
 <2d49fdfa-bd76-0469-0840-6260c5a8ff48@suse.com>
 <YzwuJTOtcIopeOlm@Air-de-Roger>
 <5c0f68e5-145a-1616-a128-a2b1a602c1bc@suse.com>
 <Yzw7Ww1s+Ru6qXZf@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yzw7Ww1s+Ru6qXZf@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR06CA0395.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::30) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8108:EE_
X-MS-Office365-Filtering-Correlation-Id: 6d1d3b22-d925-4c8b-8348-08daa6108bc0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lxivd0/WvsJ5i32SBcZev/+nhvk3LnkavYQymWllRWwUQDmsYWHb1sV3RVUwOs/u9ZLo+WlAuHQMKU2hYTq4Tte5ugCvfUnVhe+wGWK3cduFfdxU3vLLc839LLpzBvnKwUdHcoY16Vyfc5YmdcuirUFEO3vOAJv2LA/DZpll1/5lwah3MJyfj6QLK3NeWBh1SbbZ/jAVuZR0ts1GF8F+E/ZuyqLzuS7wd9+wlWU+nkzSdpiSyV2CWQsyg5nWmCWDXUyDos4xCMv/EdcK2gXTbl8KCQ9y1RiWPS7OJFwX+oU3oTTuTzmLJz1yAsUXLcd4asF+t3XSUk4V0q5IhIn/6DmERnkuth+zbtn9XHAxVoGfqbVQvxTxmFBN/g5OVBzQcxDmiG/raP8ENgEUch/PR07nHSW8Jan14xwAKB02qo7Ycixn3vVkikcGJzMwGG1S/RfwVHJ+MxmPiS6Yew1JzaIGULXF3pqdhOBe2TWxzd/V2Oj4Dlh7MVxkPDTD8Uj0ttEgs/f5xSeqlzHmvz7I+8SZzfCTArYbfoEvCCoACzaFAUYVjDyuuiwNAw7X5tMjbYPAGVsl4BlFM9ggQM+iG1Ul1jCCCyQdZtaiTrgf7s0zpQNWoExby3FLBYJQFBz2jpQJ4Vol/qxVeKmx9SsbJ4xAFpeTMY4F22AOyoYPZw6Gx2BJeWKHyK2gDRGgH/kFQWpvS6EU6uEyzCNXw7VWOCo+AKuhqS2nxP7WTjfQXBzN/oZ/yK5elcsp2p0Rh+XMu9Ee0ZPW475vkLBgccYDOEUPJjKcGyCf/9d8V9S+HZE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199015)(41300700001)(66556008)(66946007)(8676002)(4326008)(38100700002)(186003)(66476007)(2616005)(2906002)(6512007)(83380400001)(36756003)(6506007)(31696002)(8936002)(53546011)(26005)(86362001)(5660300002)(54906003)(316002)(31686004)(6916009)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OS9Qd3Uxbm82cFNIN205REQzaFRiQlNCNThsdTlYSE5RVFdmU25kRXJzVFNS?=
 =?utf-8?B?REhua1BUSnpZTC82dkwzRndWbU95QTVHbkVKbFJtbk15bWFOQk5scnIvQ3p6?=
 =?utf-8?B?WkdiYXdJazZjenN3b2k2YWpuMTRMb2E4Q2VSM2dvMXFiTEtQc2crTG9XVFpE?=
 =?utf-8?B?S0VGNG90cFUwTWV2SnI0SjdnK2R3NzdXc2VkbjZSZnIvMWJJYmNLc0ovdEhq?=
 =?utf-8?B?SkZyc2NHSEdWVmRBb0Z1dGszT3NxQ2RCNzN1ZDVGdEVWbm9sRU4xeHJlYjZh?=
 =?utf-8?B?aWFSa0tLVmtXTFMwendhTFdITFRJM1BZa1ZpNWgrUjhVc0FpdFJPSFVLZkdP?=
 =?utf-8?B?Uno0dzdmUlZVTjVxSVVYcExCVU80Qk5FY2pBNEplZDdueDU3WmR0dDgyYVRi?=
 =?utf-8?B?aGJrdEJBZlBmVmJOUk1xT3EweWluS2EyRHoydTJsTEEvNEFkek8wYmdzVmFY?=
 =?utf-8?B?WFIrdi9FZ3VIbks1YTk5M3Nyb1FBd1Zzb09MZG9qSFBDYUplcExzKytIdkZq?=
 =?utf-8?B?cWZJbmVSUnR5TGcza3B5Q1dtdHM4enlCSFhMbzB0b0hiSm9uMHpZc0h1M1lL?=
 =?utf-8?B?ajQvVFhqLzNvRkVDVVdGVHBhSTNyTVJ6R0FCd055aW9LdGRHekp6OVJCc08r?=
 =?utf-8?B?cXYyYVRXTitVQXN0c2NPZm1KTWtOMnowKzlmWmhMMGNsVXFOZWhMdTZ2eHYz?=
 =?utf-8?B?SUJwaWNLSXIrSG53SjFBck9ZTVpaVWFSbG5vbUtEUHVmZDAyeDdUcW1MN3lD?=
 =?utf-8?B?UGVNbHVPa1E3UDJTYm0rVWVZYnQwWi95UnNCa1BLZkxOSUUwVi9uS0JqeUI4?=
 =?utf-8?B?RWpOVUFxdTZUMVB5UXByLzFBVXQzQ2tYNitiSU9yQVF5UkdiRUxPcVZqN0VO?=
 =?utf-8?B?RDIxUEkwQmxMcmN1QTZjZVFiSlh3Zm1RRzVXOENmdkI5M05PZXZUbG1HZkRU?=
 =?utf-8?B?czgxbHU1eUlLODdaOTFiSXRJY1VTdEhudjlORnFrRzNtUlVYVGlydklHaXUx?=
 =?utf-8?B?MWt5V3Q5NzV3L2JYZ3V4bGZZY3ZjMmdwQXZmU0dTc3gwbDFxYlNwWmp2M25O?=
 =?utf-8?B?bFQ2SVZPUlk5UDRLdS9uVHZ4a0lGSXB4SlcyMHVNaFN1UDR2ZTdXN3lIYVEx?=
 =?utf-8?B?SG9kbTZmMUoxWHU3MnZXT1VzVi96S0ttRXZHSUoxQ01jVDdJdWQyUjNtbXp3?=
 =?utf-8?B?NytPOXF4S3BJam9RcEJjczkzV2h6YVFsQTFOTjBQRmlDYU1TWHdpd0dBNzhV?=
 =?utf-8?B?aXc3VGhINTc0U00wbzZpdURWdS8xMVd2SlRMWm9JTFd5UjY1S25nakxsdnBO?=
 =?utf-8?B?OG05cVgvNDduUnFDM3RvbTdsSXR5OUZaZlhDcWY3Qm9Xcnk4Y0IxZ1Fjdm02?=
 =?utf-8?B?QWx1UlYwWXhvMUR6WmFVS05md3JyenJyRmpHemZwN3Y2MERRY1duUHRFU0hi?=
 =?utf-8?B?bmYxSEFPODVrcFBNZmtUTkFYZElKK3huRTI0M3JhWmVVaFphWWx3MU4vYXFO?=
 =?utf-8?B?WnZOdThEZ3owdWd4amNQWWhnMG8vOUFsMlp6Tm5iNFQraVJVS2lOK0FqRzds?=
 =?utf-8?B?UU5kb2dhMk5vVGhPblM2ZXpRQm5LalZXdFVHTXVQb1VGdjkrQmtOR1pXZERj?=
 =?utf-8?B?UElISTFvL1ZkdjR2bGNHcklBV1BKcWRUTVpiQTlSRzcrR3lrdm9QZURVVllE?=
 =?utf-8?B?QVh5aFo0V0ExZW1kaDh3Z2lFUTd4dlpRR0dLWmY0ZHNkU21DMkRpL0RGSnpz?=
 =?utf-8?B?cXdNMHVxL01ubWFxU0VNblQxZ2hPV3lSb1RMelQ1R1FCSmdzMm9jRFJydnY4?=
 =?utf-8?B?azEwbnpRQldtblBTRFpjNHlweXBZMkE0M2VpZC84Mms4V1BkaUpmclcxVDVm?=
 =?utf-8?B?YVh5Y2RDWW9PTUE1ZjB1NFdFSmk4STFDb0ZNKzhUUzB4QnNDaUdMNjRzSVRM?=
 =?utf-8?B?WUdSdkxaRTVDazJ0SFJlYUtmNVdMTmRTVE1NR0xTOVVUOU1saU5Oa3VVTWVm?=
 =?utf-8?B?RFhIcjJ0MFMwZnU3V2xmNlhick9VMGd5MktaRlhDQ3FLVks0cHRBVml5UTVz?=
 =?utf-8?B?b1hnbzVDdlF0T3diTHZ2bkU0QnRmMGlMaE1ucnQ0dXh3NHVxeVdvNjljc2xO?=
 =?utf-8?Q?xfY6tCcK4rtyqg3Mhz5l2B1vZ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d1d3b22-d925-4c8b-8348-08daa6108bc0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 13:58:42.2714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I845XtGhXsedS5Wz9tNQSFEvCTt7+00KVYsUr0F4gjX5/VCPoPKP/KW7noqE/ItASYKBbB14Mj/8yq36/oMibw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8108

On 04.10.2022 15:55, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 03:15:02PM +0200, Jan Beulich wrote:
>> On 04.10.2022 14:59, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 02:21:20PM +0200, Jan Beulich wrote:
>>>> On 04.10.2022 14:17, Roger Pau Monné wrote:
>>>>> On Tue, Oct 04, 2022 at 12:40:10PM +0200, Jan Beulich wrote:
>>>>>> On 04.10.2022 11:27, Roger Pau Monné wrote:
>>>>>>> On Tue, Oct 04, 2022 at 11:01:18AM +0200, Jan Beulich wrote:
>>>>>>>> On 30.09.2022 16:17, Roger Pau Monne wrote:
>>>>>>>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
>>>>>>>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas of
>>>>>>>>> devices used by EFI.
>>>>>>>>>
>>>>>>>>> The current parsing of the EFI memory map was translating
>>>>>>>>> EfiMemoryMappedIO and EfiMemoryMappedIOPortSpace to E820_RESERVED on
>>>>>>>>> x86.  This is an issue because device MMIO regions (BARs) should not
>>>>>>>>> be positioned on reserved regions.  Any BARs positioned on non-hole
>>>>>>>>> areas of the memory map will cause is_memory_hole() to return false,
>>>>>>>>> which would then cause memory decoding to be disabled for such device.
>>>>>>>>> This leads to EFI firmware malfunctions when using runtime services.
>>>>>>>>>
>>>>>>>>> The system under which this was observed has:
>>>>>>>>>
>>>>>>>>> EFI memory map:
>>>>>>>>> [...]
>>>>>>>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
>>>>>>>>> [...]
>>>>>>>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
>>>>>>>>>
>>>>>>>>> The device behind this BAR is:
>>>>>>>>>
>>>>>>>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
>>>>>>>>> 	Subsystem: Super Micro Computer Inc Device 091c
>>>>>>>>> 	Flags: fast devsel
>>>>>>>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
>>>>>>>>>
>>>>>>>>> For the record, the symptom observed in that machine was a hard freeze
>>>>>>>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
>>>>>>>>>
>>>>>>>>> Fix by not adding regions with type EfiMemoryMappedIO or
>>>>>>>>> EfiMemoryMappedIOPortSpace to the e820 memory map, that allows BARs to
>>>>>>>>> be positioned there.
>>>>>>>>>
>>>>>>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>>>>>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>>>>>
>>>>>>>> In the best case this is moving us from one way of being wrong to another:
>>>>>>>> So far we wrongly include BARs in E820_RESERVED (_if_ they can be
>>>>>>>> legitimately covered by a EfiMemoryMappedIO region in the first place,
>>>>>>>> which I'm not sure is actually permitted - iirc just like E820_RESERVED
>>>>>>>> may not be used for BARs, this memory type also may not be), whereas with
>>>>>>>> your change we would no longer report non-BAR MMIO space (chipset specific
>>>>>>>> ranges for example) as reserved. In fact I think the example you provide
>>>>>>>> is at least partly due to bogus firmware behavior: The BAR is put in space
>>>>>>>> normally used for firmware specific memory (MMIO) ranges. I think firmware
>>>>>>>> should either assign the BAR differently or exclude the range from the
>>>>>>>> memory map.
>>>>>>>
>>>>>>> Hm, I'm not sure the example is bogus, how would firmware request a BAR
>>>>>>> to be mapped for run time services to access it otherwise if it's not
>>>>>>> using EfiMemoryMappedIO?
>>>>>>>
>>>>>>> Not adding the BAR to the memory map in any way would mean the OS is
>>>>>>> free to not map it for runtime services to access.
>>>>>>
>>>>>> My view is that BARs should not be marked for runtime services use. Doing
>>>>>> so requires awareness of the driver inside the OS, which I don't think
>>>>>> one can expect. If firmware needs to make use of a device in a system, it
>>>>>> ought to properly hide it from the OS. Note how the potential sharing of
>>>>>> an RTC requires special provisions in the spec, mandating driver awareness.
>>>>>>
>>>>>> Having a BAR expressed in the memory map also contradicts the ability of
>>>>>> an OS to relocate all BARs of all devices, if necessary.
>>>>>
>>>>> I've failed to figure out if there's a way in UEFI to report a device
>>>>> is in use by the firmware.  I've already looked before sending the
>>>>> patch (see also the post commit notes about for example not passing
>>>>> through the device to any guest for obvious reason).
>>>>>
>>>>> I've got no idea if Linux has any checks to avoid trying to move BARs
>>>>> residing in EfiMemoryMappedIO ranges, we have now observed this
>>>>> behavior in two systems already.
>>>>>
>>>>> Maybe we could do a special check for PCI devices and allow them
>>>>> having BARs in EfiMemoryMappedIO, together with printing a warning
>>>>> message.
>>>>
>>>> Right, that's one of the possible quirk workarounds I was thinking of.
>>>> At the risk of stating the obvious - the same would presumably apply to
>>>> E820_RESERVED on non-EFI systems then.
>>>
>>> One option would be to strictly limit to EfiMemoryMappedIO, by taking
>>> the EFI memory map into account also if present.
>>>
>>> Another maybe simpler option is to allow BARs to be placed in
>>> E820_RESERVED regions, and translate EfiMemoryMappedIO into
>>> E820_RESERVED like we have been doing.
>>>
>>> I will attempt the later if you are OK with the approach.
>>
>> I might be okay with the approach, but first of all I continue to be
>> worried of us violating specifications if we make this the default
>> behavior.
> 
> In any case it would be the firmware violating the specification by
> not hiding those PCI devices, Xen is just trying to cope.
> 
> Xen went from not checking the position of the BARs at all to
> enforcing them to not be placed over any regions on the memory map. I
> think we need to relax the checks a bit to match reality.

Sure, as a workaround. Yet we don't want to relax too much, or else a
primary purpose of the check will be lost.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 14:01:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 14:01:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415574.660179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofiUP-0003er-KK; Tue, 04 Oct 2022 14:01:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415574.660179; Tue, 04 Oct 2022 14:01:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofiUP-0003ek-Hd; Tue, 04 Oct 2022 14:01:41 +0000
Received: by outflank-mailman (input) for mailman id 415574;
 Tue, 04 Oct 2022 14:01:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofiUN-0003ee-IK
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 14:01:39 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f3ffe7c-43ed-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 16:01:37 +0200 (CEST)
Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 10:01:34 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM6PR03MB5289.namprd03.prod.outlook.com (2603:10b6:5:24c::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 14:01:31 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 14:01:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f3ffe7c-43ed-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664892098;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=FwXzeRBo4t59rYqAMNeKiXB2TA2uuiSyBomlytkxYMw=;
  b=e1QeToAOUzeE2vjOnSugqhV7h0fQk99gWnzwSMwq1THgu1KIz7uryqbL
   WMiOp7HK4SlwrMNT2B4Cq4ZwonCPtKeHF+bGXXfj4xDSzdKKyrGoeTFNf
   PKRZf7pZwHSYQRObzBTWmsS+ZDX/lAt2d+A82hAyGjjdIyO/kgm16j65B
   8=;
X-IronPort-RemoteIP: 104.47.73.168
X-IronPort-MID: 81956677
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AyGzR86OsT4LtZsrvrXNrnJbM+UGnJRDYMC5AM?=
 =?us-ascii?q?hGNyHUsbckhNZNtJIGfuHABrxKzqlm3KX5etJlLxnKJdwjsjhDGtqeqGrOJG?=
 =?us-ascii?q?gSNmMmLc1UII77QgL6/Gy6PkQCkrA7wfCPPG9J3oalglSoQp2622bilpUdc/?=
 =?us-ascii?q?+IK6CkDrJ9pEX+80R9g1w6OGMqrOHdfSBf3NafZjqw4Ea3OgGKTBc02S9PaU?=
 =?us-ascii?q?a1OWUgebZ88SCABZ9bivDKJEGHr4y3KW+LG/DuF2OXuyTsI0y/kqqTEWkPcg?=
 =?us-ascii?q?hDFyQ5rucQiQVAwir+/oBv7wPUoUbPRxbtmDTxWFdwAqeJewywrlZZTcScS0?=
 =?us-ascii?q?hQvTXVySEyTdeqSw+mT2p/EaiOLf/Lc3vGBIGF60KrSN194eUFOFX0/7cnzI?=
 =?us-ascii?q?mKUwtSQerWBGxSZtxCtZPEv8GJdmDtVFAhmHKk577g9HQoZ/rs+n/ku2wxWL?=
 =?us-ascii?q?BTOEyH/6dvkbt13+aNCVpqcs29rvi2FNnTI8zEZosByK2wUF7qvJ8lpZJzX3?=
 =?us-ascii?q?fuyJxsCT/YtqEE7tZQ0qT4/hGaEjpJ/XKzX5BGUZFnMjUYnWOcNijHt1Jk2Q?=
 =?us-ascii?q?DrdCPNhSq8v2Zf3HaZ5IUzp8cKJCFBMfcnVsPe5FTIWIRifCwYZXG8hOQwgO?=
 =?us-ascii?q?A8wAbKJ8uY9+XgWveOb8sE7onTGSqsDFuwTAkeUd5UKldp60WGvEhevAwysS?=
 =?us-ascii?q?VtrMR0PocQqItzWwczUsn3noGBRCO0Lw7UA8F+2csng2L8qRGhithSoLwd6S?=
 =?us-ascii?q?8H3eCmPLThT44Xa6xzUZkW0UUJRdlFkQS8iQNFwVhwo4H/0KZSY9/52KCB+O?=
 =?us-ascii?q?LdRZ8K9APXYOzfHPNCXk/EEYG8myZ5NRg7AMwv776+NT73PyWKdEWeU6jH9l?=
 =?us-ascii?q?RYWAmSYX32uxHEwS4vHkyspkoWhmdmXEt3C8oAWH9KC3TUmp9g16+zw6iggd?=
 =?us-ascii?q?eYk33DgTTTV2tbcl95acRs0GF15HA2aY8gUs31GitUAs1egdTSH7xMK3lpHy?=
 =?us-ascii?q?ogfvfIR+20k4WSGB64+0JToKqReVkBVeJ85br6I7MCp3eyy5ggA9VVI02p1T?=
 =?us-ascii?q?xwL62nuPTS6AIRQjfghJQSj1bqC2Vc9ip+UkkxNT5fm1M6NeGl5TFJ7rcWeG?=
 =?us-ascii?q?LJXaFRqvFs6NRkT5jZWocaDGTFMfMRtiTSKeyh6OBVBWfdsq80NjTbf4w+Lw?=
 =?us-ascii?q?PCCTJ6FOH+Z454ybMd9gnVYt7ovybxAdBH5K+axc8aKTX6yX/oujPz6xP2C0?=
 =?us-ascii?q?X0XDFPMR2Ce0tp8axQolRv39gj/KDF1cKy7W9tIvFV39umHPtn1pgzqOEyR9?=
 =?us-ascii?q?mvL+9nlNJ/WVQMzaHgYut6oEJRcjBi6iGm2F6wcNbDTs2ZXytttdM7IFQq98?=
 =?us-ascii?q?tm/uibKR0Msupsusy+8u63l0sFBee/hkikFxUDNpkJ1OnHY/1D841ytGQhDa?=
 =?us-ascii?q?+lRL3KELGVaagWvS3qcKKAQXZXvl1nC8FMZt8MEsiN0hELuTiNElpKkfi3E7?=
 =?us-ascii?q?7+jARnnYBUMXi8Xkc9WWXYwrrG4s9egIF69RplTgaEkASrdu7WYm3Z8SNIT5?=
 =?us-ascii?q?+dYmi2AKKgt6V8dVPyej8RlyEQ5OCAAtq28xBjIa31LpsLYK2GDp6yeZGrOk?=
 =?us-ascii?q?9ox/gfKb9pvxoUva6tCgAmxCMWd94OnPllW7CF1Wadtzp1zHt8KJn2t7FNEj?=
 =?us-ascii?q?QO9B5nFrgnsLR0nX3edRFNvDoiQhEMEmtd416leWOMP/N+xnl9oFPniY9H5K?=
 =?us-ascii?q?e4ZJ0/Ei0C5Kej73ql28q1/bQcWDcaMXbvXVOO7GjpBLkQpwPEyqwrj3t0bG?=
 =?us-ascii?q?igRfOJr83OSAqLVKu3JNjiTVXHSRWL494vwZsbU0JZrBAHCWt+jhyYTAMY8a?=
 =?us-ascii?q?rrnBiewwjuhj3IRgENMUEGhwgbB98l6MBE8pE9N5E0n271VvEPfARZiQPi0K?=
 =?us-ascii?q?ktI3tFlQRhbX+fPlEWnMGeF5qYoUU7o8VKUj5Qutkh7eCxMmjgLdTCyq0cCx?=
 =?us-ascii?q?WS/ETLaOPth169C7v38Sj2hW3trxRmowRzlwqoCK+b1z0gbHRCHo+9vPgXKi?=
 =?us-ascii?q?VAlvfOC1k43MxZgR5qn10T2i8r8KzW586REHynW3lJgLJ7w1aXXfmxDFuWhR?=
 =?us-ascii?q?U/3MnLsKq3LuIXe/L4reFVpn3Z6L3VFpAIhy1NAkl1WKcA1oQzytccuCf6Lr?=
 =?us-ascii?q?HO4EmnohWJL+teY6Y0zxWWmdAlaQJtH/lGtC+C5xH9Ms+TYIrXZqpP1OKzVQ?=
 =?us-ascii?q?jMSgwLOlCH/0XLSkWp9WM5DKC2pXAQ/2zih9ipfpUBqijuRM69W89fGGT/77?=
 =?us-ascii?q?oltOzY1X6mOUvmc4xo/ldLrZGSRF+bXSAbLQneXcOr1iwJIolZuG2dfWAoZy?=
 =?us-ascii?q?VPxCHp2JEf18qPJMYQHKfc8bvQ3V6KbGHg7n0VraZ+K/4hn8hp9tkSv3hs2z?=
 =?us-ascii?q?alAaTD0ZpFESB9erbJMsIPuKPwSHOjgudHZQ179lvhPWK6Ezj6vpbXrroB4b?=
 =?us-ascii?q?gvCQImvlKT1D2UqsWjs/U+3bt88fa6/OYql5PleyEBCfmI7hmH9SEGLi2FWo?=
 =?us-ascii?q?sSWR2rD/97VepL9xw8OJ0EAuRAnFNea27KCCEIx7x8vgbT/3PsfDnvQDvlMV?=
 =?us-ascii?q?rn7K/+mI8w97xvmEA6BQzSVm25FKM1tNG841+pUgNj46JjPCVbayOtFqelZZ?=
 =?us-ascii?q?jCv8LewCIkIdcDXiMDNqWEV78zD6i81/ytqyEUjW/6DyboU+s8Tvk+/n5EU0?=
 =?us-ascii?q?eL/SMqLLQ=3D=3D?=
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="81956677"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XgzgGVvZazqY80Gm7DN/kwrVv1bSOjHOnsO52L18dszXbc7jOarZP8SHhUCfAjH6B/9JqmhhNJU15cVUDFZh9/QzlKD14K13Q86M4By1HLUgkdaiiAz1w3njBBZJZ0FP/w8zvGZlRU2zZ+teexVdIpd+Ki7Wq2p7kpAGh9QO+aAciGK0lhPdgquzTLe7+WZSsuYrLe4lcT2CJLJA9NEbzJNLMqbpdxM0tnZoV/Sne6pGLdxrQ0dZ2QkVokp9PMm7ubVJ3/uCyrm0GIfIgIu0mK99hzKRN3OHo19+IhgsICKcrsRuNBHdoSGzvOuGdFVKm+sJ4+/CvLYA37xk1m5rkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iGgqx1lqiO12eGMjUZ8a3OBh//MxmppzY7+ROgOLLFI=;
 b=jGmBfQ/t+y8xnqahcBercMYBIXr/+QW5m60CKmXHEjEoakon6uFJdxSQxZnMA5ZMDiCDgmoq6QR4CxvkTrK1zCRTJJkxuYdisLEyeA58nh+m6+2py73QfMEdfTCnx4As0rF2Jlt2beR2AFuJaxw7O6JaImdxXfwX5JCZvhwvPLKmOnA+CIMpW1F4lpB3Ji2yRQlwhj5Ekp25CbPVIVgGWEdgeOhx88b377MCuPTJZcEBIxzWf8EyO3lFbcutZvh2CwJOoyZsjkFIyOTCMGXR1WM0lfSg9I6iBxH+K4E1BlwoANhrgES8TZ9OoCJ6mdKzPj5aIIwYBSM23/i7svaCVg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iGgqx1lqiO12eGMjUZ8a3OBh//MxmppzY7+ROgOLLFI=;
 b=IcPrZPhlbWRz7ZpS8B1cM1aINDiaJyxWptIU2cMsJIkJjg6Gp/60Nc64YqTu/pQIImX17zU7kRSAzV4zsGkGvorx4ipotJBM+FKRB9wdrM9ntpaT9FZe859yANOV3iDKSYawjFSkDheGfIG2d2lYoHMJoQmAeuJeQlu88EBHU0E=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 16:01:27 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Message-ID: <Yzw8t4oECUL6tzNB@Air-de-Roger>
References: <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
 <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
 <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
 <8fcb15bf-4477-78f4-f8ee-33603ef20995@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8fcb15bf-4477-78f4-f8ee-33603ef20995@suse.com>
X-ClientProxiedBy: LO4P123CA0003.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:150::8) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5289:EE_
X-MS-Office365-Filtering-Correlation-Id: 625f66dd-1033-420c-c54b-08daa610f0af
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QIHDqrNJYehnkp8eyxNoRjiqh9rOFhiVSaSJNinzIHnar+xvzDv6SbqyfPVqkBoVx1s4ZocCvOGU4ST7ZO7r2JU33uBpmDnmqrm/I+IvhC54OgGnTA/A4mrz1IhGN2Xm3FjEz/aTTUxlMSDCQWTswWIS38sELJH2q5O1ToMaw5BnpTpZ1Tj380InDNC/WKBwOEwK83ohCs4LZdxuxYX+Qa46qhczzlyYH2TJBWEe3Af8QQW7Lhq4pAwY7/W4nZ6ixUfGs7GCLLK3RftjzbRr0Ngb1eMEVGjFBvLzLQXPzX058tmmemipjKUokDRudoZrCngB2VOuoxJ/bF+70WdaAzF06Ezjt5y222mg6Xcdbr4QKQvNhHK0PkcAndHn5TNjh56Z9IqakHBI8Xb7ra6ALzbwtgvzOOJUs4XOi9fZujp+sYtwNWBbVDy4KuMfeDjEK8jeccON5mOMADfMOspXgI5UAcCmrof0ZJ19vcKLqSjpQV4MdJqzahiBhbwo8gQgR5ZQVDVZOz/sT+r4FzLs5gan2KgZBswzY3gOA480mK/ISmj1hACpasS65m+sRDNDjqBfaWSyy1LU0hScX4ymoDjZk4dRqwZYhFpGqAjTD7YnWyl6HDb2Odw1y1ogT0o3CCKTBPpch2kGxdfjeahztqDdZl/ag8fsIdZBD52Dvr0KyQu+DbavBTODOhPkkLKtRVH1oKTphmNLKv2OonFOFg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(8936002)(41300700001)(2906002)(38100700002)(478600001)(83380400001)(6916009)(85182001)(66946007)(6486002)(6666004)(66556008)(66476007)(186003)(5660300002)(54906003)(6512007)(9686003)(26005)(8676002)(33716001)(86362001)(53546011)(316002)(4326008)(6506007)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dmV6S09OWGM3Q01BTWJwbnljVEt3blIrWVM3dnpZWGVmb05ieEl2Y29NTWkz?=
 =?utf-8?B?eGdBTmRWcS9YRVQ4cUtSMVRFem9yS05SUU1SVzdvNzFNODBnVmljRGw1QjU4?=
 =?utf-8?B?M2RYQkkwOEFIOXFuYlBhVjVYVUdxWm1vbWpmMEt1TE5QSnVVbWgvL3F4YWY1?=
 =?utf-8?B?YTAzNU9MVmF5bGFmWGhobEFZMG04RGJLQnl6cXVxOE1oSG13TytyVFF2RDJP?=
 =?utf-8?B?ZUJvTytVcGdodGwrdXN5aS90ektvNnlDRi9CUlllVGM4VWtqdm1wOWMwdXJB?=
 =?utf-8?B?dGpKWEhjYXh3aWx0Yk1OSXloTktYcTA2NXlScmNEalhMeGtJSmZ3cTRIVVhS?=
 =?utf-8?B?NmZlTmIzV1d3NXF6aEVMUDlpQTk5OGxVQ002RTVJU29KTE52b3hrU2NZZCtR?=
 =?utf-8?B?ZGM4OS9DRTlRdjl2bk5OSnhldTdMZEJUNFBPQVY0WkdSeFBoUlJsbDhvbTIr?=
 =?utf-8?B?TjhKL1UzWmNvUEUvMG5na1Jyd0M5M3hqOXI4aHBRcWxlSWZqUHFWS2dqZTgr?=
 =?utf-8?B?ck10VTA3QlFGMERiMUluMmU3ajdtMXRUU3lZN0VqdEpVRVRVRno1bitJMURx?=
 =?utf-8?B?Y1FoclJXbEIwRjJaQTQwelZlQVdyUkpKSXljN0I5VDBxQXovajI5MEFFbVlm?=
 =?utf-8?B?VUVsOG1uUHZONDB3dzNDb1pHNThPSW1jWUUxL3dSL29lNkRoSzJ0OUhoajVu?=
 =?utf-8?B?TnlQVXR3d094SUpVNmgwU2EvQkM5akgxK0NvUGt3NGIydVFya0tONmYxSWdF?=
 =?utf-8?B?b2V6THN4aDd2eEU3Z1d3cnpxUXhzYXFvRXpsdytXNUlVSC9rZnh5UUl3MHoy?=
 =?utf-8?B?RmdRdXdUZDROZ2txekxidHJ5elpwWWEwL1hiZ2JqSUF2SmNqQTB3QURNdkl2?=
 =?utf-8?B?TU54SndBcGttODRObU1vYUJZUEtESnVBNU5nR1ZBWWNYNElPSUMyZzdFZSsz?=
 =?utf-8?B?UHcvYnM0eE1TMlNVMFY2dDA0dzJtL3VpeHRQc2dsVnRabkdvczNMUjVTbkZn?=
 =?utf-8?B?blFWeE9hN01LRnptY1lsL2ZvTitCTzVYS3JncEpGK0xNWDJ0cnV5aGg1Y0c2?=
 =?utf-8?B?N2xteFlLNFo5YytPUTEwZWVEVmdqQUNBRy9OdTVoVmplVEpZUU9reWFjTGI4?=
 =?utf-8?B?RzFBNkRNZ3hyc3ovQWxIbi9TSGowcXljbTBQUWpTOTBBeXJJdC9kdU9CdE5J?=
 =?utf-8?B?U25LQUx5WW44SHZiVE5NZk9nL3JYOUR2a3Noeml4WFhSS3NhSHVudVgrMFFL?=
 =?utf-8?B?VEl3MHprQllpZGRTb24xVlhSVHdPTGNwTk9PWjc5QUJHeU1aSkQ1MWxYMzNu?=
 =?utf-8?B?THpPai8xVVhGdVVYbXpaRkFCa2w2MmcvR09sVjU1WmN1WVhMcmJUdEJZQ1Nj?=
 =?utf-8?B?akRrYUoxWmtab2ZYVUhDbFoyWU9rUUZaanF5R01VRkY0eGtrRDhnT1JudGlz?=
 =?utf-8?B?TVRsU0FWT2Ruc3RJRG1yeWxPVjQ2QmdLWVVuNWJuZnNTLzhaRW9zREhVWXh4?=
 =?utf-8?B?bmsxUjlDTmZwamtyYVdyQmg1cU5DQXdza2ZteTllS0dkdE1TTTRNRmFYZC9F?=
 =?utf-8?B?Q21Ncy9Sakk0YU56bmd2ZlVCcVUzSlQvcWwydDVEbGZCY29NV1M5MXJRaGdD?=
 =?utf-8?B?MU5Ea0I5T0ttL0RRQUZocHdINjk3YVFoVGV6VUpudkFSRnM1TFZkWmdGQTdO?=
 =?utf-8?B?dFcyWjRlaGZyZlpSLzVXcjVTNDI5MXFEbzVqUzR5MHdXbitNK3pLLzA0eFZB?=
 =?utf-8?B?NHh0VGhNdUViSi85cm9UcVJ5cTE0NForK1EwYW5ia1dNVmszV21IZEIyRTVu?=
 =?utf-8?B?ZHUrdk15djg4UnRMU3lVZmV4WHVoL1ErMHBQWEo5VCtUR2xwV1hOc2x5VnpC?=
 =?utf-8?B?TnVOdE5CeWVYaTZybkFEbTNJNUlzZmcvUmFFMWh2b2wybWJaSlhFQk9zU1o0?=
 =?utf-8?B?RFAxSUZEVlo1UkNZWFVnNEVjQjZpNTNIbFM5TmdSdU8wM3dsUGRFY2toSjA3?=
 =?utf-8?B?ZlRPUDByK1h2aUxJTHlscFhaaklOTUY1OERzb0p1Q00rYlliOUFCaHdrTWhi?=
 =?utf-8?B?M0xjVjdhazJhZUtJZmRYbFhDQVEvdFpWa1dlVlVxMWM5S2VVMWNOQVUxelkw?=
 =?utf-8?B?ekZmcFZUT3o5MkJBUFZOa2RKUU14NWNwakxyRU9iaUlXaWZGUFZDekplNkQr?=
 =?utf-8?B?Qmc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 625f66dd-1033-420c-c54b-08daa610f0af
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 14:01:31.6428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9mdt/o2n14xvyed4tpJdYgc6bRckbjl4k3kW/CihyJ3w8h9+BUxG27bKo6ms5Y1jK8GfCUJGOPh4d3gVga86/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5289

On Tue, Oct 04, 2022 at 03:10:57PM +0200, Jan Beulich wrote:
> On 04.10.2022 14:52, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 02:18:31PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 12:54, Roger Pau Monné wrote:
> >>> On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
> >>>> On 04.10.2022 12:38, Roger Pau Monné wrote:
> >>>>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
> >>>>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
> >>>>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
> >>>>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
> >>>>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
> >>>>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >>>>>>>>>> higher priority than the type of the range. To avoid accessing memory at
> >>>>>>>>>> runtime which was re-used for other purposes, make
> >>>>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >>>>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >>>>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
> >>>>>>>>>
> >>>>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
> >>>>>>>>> dom0 doesn't try to use it either?
> >>>>>>>>
> >>>>>>>> I'm afraid I don't understand the questions. Not the least because I
> >>>>>>>> think "it" can't really mean "dom0" from the earlier sentence.
> >>>>>>>
> >>>>>>> Sorry, let me try again:
> >>>>>>>
> >>>>>>> The memory map provided to dom0 will contain E820_ACPI entries for
> >>>>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
> >>>>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
> >>>>>>> overwriting the data needed for runtime services?
> >>>>>>
> >>>>>> How would Dom0 go about doing so? It has no control over what we hand
> >>>>>> to the page allocator - it can only free pages which were actually
> >>>>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
> >>>>>> DomIO - Dom0 can map and access them, but it cannot free them.
> >>>>>
> >>>>> Maybe I'm very confused, but what about dom0 overwriting the data
> >>>>> there, won't it cause issues to runtime services?
> >>>>
> >>>> If it overwrites it, of course there are going to be issues. Just like
> >>>> there are going to be problems from anything else Dom0 does wrong.
> >>>
> >>> But would dom0 know it's doing something wrong?
> >>
> >> Yes. Please also see my reply to Andrew.
> >>
> >>> The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
> >>> know it's required by EFI runtime services, and dom0 could
> >>> legitimately overwrite the region once it considers all ACPI parsing
> >>> done from it's side.
> >>
> >> PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
> >> only appear in the machine E820. In how far PVH Dom0 might need to take
> >> special care I can't tell right now (but at least for kexec purposes I
> >> expect Linux isn't going to recycle E820_ACPI regions even going forward).
> > 
> > Even if unlikely, couldn't some dom0 OS look at the machine map after
> > processing ACPI and just decide to overwrite the ACPI regions?
> > 
> > Not that it's useful from an OS PoV, but also we have no statement
> > saying that E820_ACPI in the machine memory map shouldn't be
> > overwritten.
> 
> There are many things we have no statements for, yet we imply certain
> behavior or restrictions. The machine memory map, imo, clearly isn't
> intended for this kind of use.

There isn't much I can say then.  I do feel we are creating rules out
of thin air.

I do think the commit message should mention that we rely on dom0 not
overwriting the data in the E820_ACPI regions on the machine memory
map.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 14:22:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 14:22:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415587.660190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofio7-00065a-Hq; Tue, 04 Oct 2022 14:22:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415587.660190; Tue, 04 Oct 2022 14:22:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofio7-00065T-DW; Tue, 04 Oct 2022 14:22:03 +0000
Received: by outflank-mailman (input) for mailman id 415587;
 Tue, 04 Oct 2022 14:22:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofio7-00065N-1H
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 14:22:03 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e9b3c236-43ef-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 16:22:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 504711F8F5;
 Tue,  4 Oct 2022 14:22:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A976139EF;
 Tue,  4 Oct 2022 14:22:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IFEaBYlBPGOBdAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 14:22:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9b3c236-43ef-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664893321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=42bi1unQGYn1lsInsXMBa9R0CHgF5/C+iVUDGtawBmc=;
	b=sM4+w5wm4qmhUoUgajvx327zzug1G05RuXW+Ozve2KcaXk1nG48nyFRITpRc7uKKExxbco
	FI7MZ/1TAXQpoVh9XfM1axCF+Aeh7ItQxUASGNIlBOGv7n+rnKeMZYIzrMFFpU+9De7iOK
	/YFILCftFlrLicVz5P9qm9l38Yjn4SE=
Message-ID: <5aae9e7f-e2b4-f9b1-5357-eb648a9a9e0e@suse.com>
Date: Tue, 4 Oct 2022 16:22:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Bjorn Helgaas <bhelgaas@google.com>
Cc: xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20220829151536.8578-1-jandryuk@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220829151536.8578-1-jandryuk@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------T110oCLNUe9jPKZIVpvY2h0i"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------T110oCLNUe9jPKZIVpvY2h0i
Content-Type: multipart/mixed; boundary="------------0Tg5yDesGhz24HIrkQaYeHGk";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Bjorn Helgaas <bhelgaas@google.com>
Cc: xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org,
 linux-kernel@vger.kernel.org
Message-ID: <5aae9e7f-e2b4-f9b1-5357-eb648a9a9e0e@suse.com>
Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state
References: <20220829151536.8578-1-jandryuk@gmail.com>
In-Reply-To: <20220829151536.8578-1-jandryuk@gmail.com>

--------------0Tg5yDesGhz24HIrkQaYeHGk
Content-Type: multipart/mixed; boundary="------------s0SqXfzRTGnu0nAxhdf0bXGd"

--------------s0SqXfzRTGnu0nAxhdf0bXGd
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjkuMDguMjIgMTc6MTUsIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+IEFuIEhWTSBndWVz
dCB3aXRoIGxpbnV4IHN0dWJkb20gYW5kIDIgUENJIGRldmljZXMgZmFpbGVkIHRvIHN0YXJ0
IGFzDQo+IGxpYnhsIHRpbWVkIG91dCB3YWl0aW5nIGZvciB0aGUgUENJIGRldmljZXMgdG8g
YmUgYWRkZWQuICBJdCBoYXBwZW5zDQo+IGludGVybWl0dGVudGx5IGJ1dCB3aXRoIHNvbWUg
cmVndWxhcml0eS4gIGxpYnhsIHdyb3RlIHRoZSB0d28geGVuc3RvcmUNCj4gZW50cmllcyBm
b3IgdGhlIGRldmljZXMsIGJ1dCB0aGVuIHRpbWVkIG91dCB3YWl0aW5nIGZvciBiYWNrZW5k
IHN0YXRlIDQNCj4gKENvbm5lY3RlZCkgLSB0aGUgc3RhdGUgc3RheWVkIGF0IDcgKFJlY29u
ZmlndXJpbmcpLiAgKFBDSSBwYXNzdGhyb3VnaA0KPiB0byBhbiBIVk0gd2l0aCBzdHViZG9t
YWluIGlzIFBWIHBhc3N0aHJvdWdoIHRvIHRoZSBzdHViZG9tYWluIGFuZCB0aGVuDQo+IEhW
TSBwYXNzdGhyb3VnaCB3aXRoIHRoZSBRRU1VIGluc2lkZSB0aGUgc3R1YmRvbWFpbi4pDQo+
IA0KPiBUaGUgc3R1YmRvbSBrZXJuZWwgbmV2ZXIgcHJpbnRlZCAicGNpZnJvbnQgcGNpLTA6
IEluc3RhbGxpbmcgUENJDQo+IGZyb250ZW5kIiwgc28gaXQgc2VlbXMgdG8gaGF2ZSBtaXNz
ZWQgc3RhdGUgNCB3aGljaCB3b3VsZCBoYXZlDQo+IGNhbGxlZCBwY2lmcm9udF90cnlfY29u
bmVjdCAtPiBwY2lmcm9udF9jb25uZWN0X2FuZF9pbml0X2RtYQ0KPiANCj4gSGF2ZSBwY2lm
cm9udF9kZXRhY2hfZGV2aWNlcyBzcGVjaWFsLWNhc2Ugc3RhdGUgSW5pdGlhbGlzZWQgYW5k
IGNhbGwNCj4gcGNpZnJvbnRfY29ubmVjdF9hbmRfaW5pdF9kbWEuICBEb24ndCB1c2UgcGNp
ZnJvbnRfdHJ5X2Nvbm5lY3QgYmVjYXVzZQ0KPiB0aGF0IHNldHMgdGhlIHhlbmJ1cyBzdGF0
ZSB3aGljaCBtYXkgdGhyb3cgb2ZmIHRoZSBiYWNrZW5kLiAgQWZ0ZXINCj4gY29ubmVjdGlu
Zywgc2tpcCB0aGUgcmVtYWluZGVyIG9mIGRldGFjaF9kZXZpY2VzIHNpbmNlIG5vbmUgaGF2
ZSBiZWVuDQo+IGluaXRpYWxpemVkIHlldC4gIFdoZW4gdGhlIGJhY2tlbmQgc3dpdGNoZXMg
dG8gUmVjb25maWd1cmVkLA0KPiBwY2lmcm9udF9hdHRhY2hfZGV2aWNlcyB3aWxsIHBpY2sg
dGhlbSB1cCBhZ2Fpbi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEFuZHJ5dWsgPGph
bmRyeXVrQGdtYWlsLmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z
c0BzdXNlLmNvbT4NCg0KVGhlIG1vZGlmaWNhdGlvbnMgb2YgdGhlIGNvbW1pdCBtZXNzYWdl
IHJlcXVlc3RlZCBieSBCam9ybiBjYW4gYmUgZG9uZQ0Kd2hpbGUgY29tbWl0dGluZy4NCg0K
DQpKdWVyZ2VuDQoNCg==
--------------s0SqXfzRTGnu0nAxhdf0bXGd
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------s0SqXfzRTGnu0nAxhdf0bXGd--

--------------0Tg5yDesGhz24HIrkQaYeHGk--

--------------T110oCLNUe9jPKZIVpvY2h0i
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM8QYgFAwAAAAAACgkQsN6d1ii/Ey/o
yQf9ErjOFLhQE8b16zbrUJQVyiHzAMtNdoDmjSqLu0wb32KeMI+QvbXJwKSBa2EZqFJ3vMF6LMTO
i5kBCMmyd84LD7Jk7X8aZkWbj1QyYjcwNikyDGM1unGjS2ivdDJmEW+hGpJfJHwYHEJqljrzyYI0
0+tzXXMfhG81yFY75AWcyzgB/DEsDxuqyv/IVWfvUvjjM2XWd2O72HGrK5eMWql9tRDyQ+c5lcs9
zKi1WEc91kq7xRpTi5rjeOrKV9qs1QJN/EYhAFfiAeGD7Aom6uMScPQGi0D2adCZk4KOctpT1x9X
0Tmnx4tyXcyEkqOyy98BxafW/v7l1RR6TmUAtzrwyw==
=pPlS
-----END PGP SIGNATURE-----

--------------T110oCLNUe9jPKZIVpvY2h0i--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 14:39:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 14:39:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415595.660200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofj53-0007hI-0K; Tue, 04 Oct 2022 14:39:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415595.660200; Tue, 04 Oct 2022 14:39:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofj52-0007hB-Ty; Tue, 04 Oct 2022 14:39:32 +0000
Received: by outflank-mailman (input) for mailman id 415595;
 Tue, 04 Oct 2022 14:39:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofj51-0007h5-Dp
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 14:39:31 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a5483db-43f2-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 16:39:30 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8248.eurprd04.prod.outlook.com (2603:10a6:20b:3fd::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 14:39:27 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 14:39:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a5483db-43f2-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YgPVYGXYQ5bzRRNqubA81mA/amzpGhWndJIt+7hNrFO0WvwfJEX1BlS5GoigTpvA5daP2DvN9TSA8VR03UE+zqcochTMU19ea0hrTBT8geqL8NvPLStakwl71EKXHdsWxdn5kQ0ZCPqGVB3UhnMiw+VUp5mJFbhnSTmmdH8Fy/bdI2BG5sIBkK1BVYV+Di/5JW5WnEadjsXHNVnAZkHVGCjAfDtTLbdL5FiypDFR1tZeyqj1W68v6iIPNoVtcIxDGq1Y+JGlx5g6Xiko7g4OsE+36NzcwUCqMIcVK3YqxkWEO5jJFYi4wLqnvv56QeMyU1xb9vGdTXy4yztdRhTrXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+Sm/x/xTQ7b1Bl2Pc8zQBk89dP8JJhzZeAjgh6EVbhY=;
 b=EQtALlS9rbUHE5qN24by2oAg3hrhWeRKH6sT02ortuDD9CRBaPL/lcE5M24tsAZqqKROEOSfMKhMCp0OXby3DB9j1h6SyMPbfjRI+oEKFNqRL7Dy0brTeL5YXgJJz5f5XmrJU8K7hCO6exVPJkMxIUzgmXHwin82nhAvIiz9xSlUuiyPSDgPgygRy0NHklIeyLNy//qDkUAFXWeyRomLj+yyP4WaW642whAXg0XbexBGVO9pH8htFExpm/cLnXKX0TrSyI3NyP0GCLLOmMOT9opfR7JJw0C3bspsYeygst3izzZUSH32Xi5sD9w7M2HnxuJ41kW3LDVCO+ut4S4NCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+Sm/x/xTQ7b1Bl2Pc8zQBk89dP8JJhzZeAjgh6EVbhY=;
 b=AJjvonxxDkBPVFmWYfrKGdVZduWDJ033GOuxhIjRe8H8TXSu70j1jqTVXf7fVigFXlW0ML/0GHQ3zcX9AEBoejiii/WV9O0xHwM7U+F7jIddDi3sjvUok8EDt+EadE/b+/kPcMOnreCPJjhbVijrQrTe3qikjsDCunLAlbfTTjwXqS085z+MaOFt4PRfhCRtG+xLzY4ZD/fDa6VmYvUlVwiuPXLVrtfMZMJ+j3Gc5nmWycZikygwvLvgiWTlAfNxdM5s3ou8P+xZBe6t59z4uYN42AFVhBReveqQ74MwdsSV9h+CQ5yLPQpQocSdSAdLBjfMTMeqjNNHreW53CXfag==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0f3d61a9-aeac-0aba-e930-cee80c9232fe@suse.com>
Date: Tue, 4 Oct 2022 16:39:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <Yzb9BDGc45OshRZN@MacBook-Air-de-Roger.local>
 <df0dc3e1-da12-9d42-b652-e33419134d38@suse.com>
 <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
 <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
 <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
 <8fcb15bf-4477-78f4-f8ee-33603ef20995@suse.com>
 <Yzw8t4oECUL6tzNB@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yzw8t4oECUL6tzNB@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0102.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a9::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8248:EE_
X-MS-Office365-Filtering-Correlation-Id: cf12c051-55eb-4269-0474-08daa6163d60
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ulduJyK5vFasNxqNLR+mdxhU4cTS8P9tFwcEyPjH9ZRJbcL1OZFFSEKRKiaSMPsgx83N+iTUcmKrF4L2tjYeYDCAP/qksWCqFhfbXSB20iy8ua5EKnLH50jXo3T5u6egsrC78DOoKeNf5a8Adrs65PReBRm4t7Nmjp+MM5r8RZYE3a4lG4dww92Bb5NdcGpfI+PuFC3JHzwIL2UDdqnW2VzzvDvfsgKGSz3CgPE9bOotwOVYRZq4UTf2TfORRN+YprF2dnHCi4677evgaYRnNDM25Wu8LE4eSB4pSd9aC/T8ZO802BVk4h4k53QREMbYHWP0BrQQ+SP4zUfjWQhaDyz6wWP90nP2tto4fEyRwlLv98fjDhbESsPRFbNSf48uy+vxsgbjf4dMXs1wIdD+E2n1uKBy2KaYjfLOcvFbPzj5dAH7Nm1mxcQu/PoP3d8u57QiOWSWA8iqAF3AGaNM6izN7pZcImC5bWldoEhsAqlhbgEfiD/wRrnQCZYeBIROSsV+nqzv7MrQwEgWwVqAJpF3soovS1u8xyZgmjBvT2IdCn1U6AQTNnqe4FHTPrdSMBQ+lpDtlF404sWzwdKnlfErlT9tcNhhJhBxPWZq7lrRbvAz5j+GESAoKbPPrpeSFj9aD/Hmn1cxGvnWxiVI+whOpwer3qjrTpQcMHEZ5w1AcmLV0NV3sLReOmNv7DJxfO5gdOi3GaHRbnzQJJRzkpMoqcgEFNceEj3cxFV1/K36WbVBCcw4BTQpmMiaGLQo+xLbo2A02fhsxHWq3lZprCQuz4ERhs+HRT98Y3d13jg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(5660300002)(478600001)(8676002)(6486002)(41300700001)(4326008)(66946007)(66476007)(66556008)(6916009)(8936002)(6512007)(26005)(6506007)(53546011)(83380400001)(186003)(2616005)(31696002)(316002)(2906002)(86362001)(38100700002)(54906003)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZXNHQzhUcFBpdHVYZCtudnBDT0RuYVVtM1VGaHhKSzhwczhCZ1ZWbENTYzBR?=
 =?utf-8?B?a0FHV0pDRTNwaExWQjRXdHpWNWtvbHRMQTlQNDhFaSsrc1ExeWozYUx5Y0k0?=
 =?utf-8?B?cDlWRG5GUkd2SzczZkNsRU4zWWJXei9VMXhJWjh5UUlGWGk4cUs5SlVWeUZG?=
 =?utf-8?B?dTVia0JFN09idnlrMlUrUkViVFU1ZWNVOXhFOUU4Vlg3ZDRNeFNpQzJaRldP?=
 =?utf-8?B?YVVoR1hzWFpNY1NGYXhMTVdHRnllbjJGaTZNNzVheWdhZFY5aDFsUlkrTDJw?=
 =?utf-8?B?U2FMVEtoWFY5clY4SW5ZKzlOVXpIVW1zb3FyaFhIcnhYRDBlY1MxTmMrM0ZK?=
 =?utf-8?B?QkpnMGF3WlQzVUQzNFBZTU5UQzBSK09GRERTSUdmMEVVdllkU0VMc2dnZlVS?=
 =?utf-8?B?ZjJCRU4wc3p6bHNXbFgxTktZcGN4Z2R5eXUrMHl4eVVPZ2FvZkhIR0ZYbXA2?=
 =?utf-8?B?NjRFbnozUnM1WVNnV3pnNWRaRGtXWVUzWDhidFFSa3BjOXVuMXNTR0pKUkxi?=
 =?utf-8?B?djhvVkNVVWlnQWsxMmhnaHBVd1lOM3BQUDhqcFYyS3VkOXJoUHQySUVDMEVu?=
 =?utf-8?B?UEY0V3Q0NkZKRktJaWRsMXVkeGlQM2ZuUU1oZkRxOXVWeUpMREx6ZEx5bU9L?=
 =?utf-8?B?TGU2SFlpTEZ6K0tKMWNMdG0xYUFRaFRheHBEbExwczJ3cHJzNlhPT3Q2RlNz?=
 =?utf-8?B?eHN4eU43dGQ0Z2czNE5OZTJYZDFUZnJvZFk4cE81TFR6RUJxRTRYcUtPZFU3?=
 =?utf-8?B?aUpxbjY5SWVLLy9nUXNZSk9LU201UmhSS1JLeUhobndhc21oSm1sRXlDQmZ6?=
 =?utf-8?B?SjI3N1A4dzltYTVkYk0wWUQzVHJCTnF1NFhKSEI4WXEvMlUvaG9vWTJXNXVa?=
 =?utf-8?B?WEUyck52R1JGVHAxVGdGWDdWcFRXVUNzMnJLRlNocTQ4bjhvZFFxY1lGN0xn?=
 =?utf-8?B?eWhoNHBWcG56bmlOanJtL200Y2drSUJUYlliRmplN1RoYU5BQ1pTdThPSHIv?=
 =?utf-8?B?enZIREJ2V2FPd0ZpUkdZa042Rlc2V3MyVi83c0pTMXlWcDFsVW93WkJqKzJk?=
 =?utf-8?B?RG1JSm5wZmR0RGZTekY0Y1BCb3VyaWJIaFh0VEkyMUM3STFQTTd5OFJwMnNY?=
 =?utf-8?B?cyt3VUM4VEViQVcwMnRRdVUwc01pdWhycjdRZmVUYWkxOVFjZkR6UW9PbktU?=
 =?utf-8?B?VkZuTHQ2VUJZcXl6QmxMVWQzSlFRUXMzc0x5Zkd5RmpyNlJYSlRnczlJZ1Bk?=
 =?utf-8?B?SE1ZUEw5Q3dXQTZ5cVcrOUVEeGdDT0JhcVAvVnByVmxRdTVmSnBBbUFpU2dt?=
 =?utf-8?B?QWdnc2p2VHZOWlJycEJUSTVLT0JJTlBKbkpGN0FCL2lhTzFCeDFVVjVLMEFp?=
 =?utf-8?B?WDdxenJMREE5dk1YVkYyTjFXWGFxRlJPKzVQeW1UYXVlaE5teFFPekNubkJD?=
 =?utf-8?B?bkluYjdjTVoyWVVvNlBIUnl3THk1OXNwaGVEMU1uQlBSRXIreDZGYzg1SmNv?=
 =?utf-8?B?RXR2K3dMNUwwK1F1akxad1RPbnFrYWI1M3BHSk9nOGRBZDlsVDVqckx5cUgy?=
 =?utf-8?B?cEhIN3dCekQ1MzBFRllVSE5hRktrWVJUejNGbnpuaEF0Unc1dGNLaXNtdk9L?=
 =?utf-8?B?WEhBalg1aS9sNGlXRG8vdytiMDFLM21la2padGJ2MGRjSDZvWjRwQm5aazl0?=
 =?utf-8?B?Y2JvNlpFYVExbjA1emZvaHZFTUVqOE9BNnhzM25tWHg5QktsYXl3U2d2cWJC?=
 =?utf-8?B?YkRBdnNMbzhYUXVWVThEbHU0amF6cFVqVXdDcVAvS2R6d05aL05xdTlacjV4?=
 =?utf-8?B?T2dCZ0dFbXRKSWFjN1BObjMwUVFkd0FoK2ptaUkzR0h0MENYc2JEeXNLdkcr?=
 =?utf-8?B?ZTF0M0xEeWZYbmloRThFVFRpbkRaVFhUSVRjQk9WaUVFd3lUYVNhWnd5a2Nr?=
 =?utf-8?B?OHZEWlRsWGVzOGFJYngvK0dCMSt5SmVmNnlwUkNHaTFiMTVwNDQraVdaMlEy?=
 =?utf-8?B?NFlPQkkvQkdkVTM2ekNTMnZkdVp0eEFGRUZ2cUd5QTZkOGNDbjN1aHRrTE04?=
 =?utf-8?B?Q096SVZNRW84cXRINFg5VkE2K1ZhWHJmYXBlRTZpS3RRaGRpT3hrV3RNN2Na?=
 =?utf-8?Q?XYgS2RE1VEKQ93vUK9PKjVACU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf12c051-55eb-4269-0474-08daa6163d60
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 14:39:27.6946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XCbE1qrln6gkLDcwlir0SckvzqI7CThNZIm99LB+KVCA+r33O9SJV4TR2BTwyTQAS/YNZYcK3palGH+Dp2YRAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8248

On 04.10.2022 16:01, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 03:10:57PM +0200, Jan Beulich wrote:
>> On 04.10.2022 14:52, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 02:18:31PM +0200, Jan Beulich wrote:
>>>> On 04.10.2022 12:54, Roger Pau Monné wrote:
>>>>> On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
>>>>>> On 04.10.2022 12:38, Roger Pau Monné wrote:
>>>>>>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
>>>>>>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
>>>>>>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>>>>>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>>>>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>>>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>>>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>>>>>>>> runtime which was re-used for other purposes, make
>>>>>>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>>>>>>>
>>>>>>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>>>>>>>>> dom0 doesn't try to use it either?
>>>>>>>>>>
>>>>>>>>>> I'm afraid I don't understand the questions. Not the least because I
>>>>>>>>>> think "it" can't really mean "dom0" from the earlier sentence.
>>>>>>>>>
>>>>>>>>> Sorry, let me try again:
>>>>>>>>>
>>>>>>>>> The memory map provided to dom0 will contain E820_ACPI entries for
>>>>>>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>>>>>>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>>>>>>>>> overwriting the data needed for runtime services?
>>>>>>>>
>>>>>>>> How would Dom0 go about doing so? It has no control over what we hand
>>>>>>>> to the page allocator - it can only free pages which were actually
>>>>>>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
>>>>>>>> DomIO - Dom0 can map and access them, but it cannot free them.
>>>>>>>
>>>>>>> Maybe I'm very confused, but what about dom0 overwriting the data
>>>>>>> there, won't it cause issues to runtime services?
>>>>>>
>>>>>> If it overwrites it, of course there are going to be issues. Just like
>>>>>> there are going to be problems from anything else Dom0 does wrong.
>>>>>
>>>>> But would dom0 know it's doing something wrong?
>>>>
>>>> Yes. Please also see my reply to Andrew.
>>>>
>>>>> The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
>>>>> know it's required by EFI runtime services, and dom0 could
>>>>> legitimately overwrite the region once it considers all ACPI parsing
>>>>> done from it's side.
>>>>
>>>> PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
>>>> only appear in the machine E820. In how far PVH Dom0 might need to take
>>>> special care I can't tell right now (but at least for kexec purposes I
>>>> expect Linux isn't going to recycle E820_ACPI regions even going forward).
>>>
>>> Even if unlikely, couldn't some dom0 OS look at the machine map after
>>> processing ACPI and just decide to overwrite the ACPI regions?
>>>
>>> Not that it's useful from an OS PoV, but also we have no statement
>>> saying that E820_ACPI in the machine memory map shouldn't be
>>> overwritten.
>>
>> There are many things we have no statements for, yet we imply certain
>> behavior or restrictions. The machine memory map, imo, clearly isn't
>> intended for this kind of use.
> 
> There isn't much I can say then.  I do feel we are creating rules out
> of thin air.
> 
> I do think the commit message should mention that we rely on dom0 not
> overwriting the data in the E820_ACPI regions on the machine memory
> map.

Hmm, am I getting it right that you think I need to add further
justification for a change I'm _not_ making? And which, if we wanted
to change our behavior, would require a similar change (or perhaps a
change elsewhere) in E820 (i.e. non-EFI) handling? The modification
I'm making is solely towards Xen's internal memory management. I'm
really having a hard time seeing how commenting on expected Dom0
behavior would fit here (leaving aside that I'm still puzzled by both
you and Andrew thinking that there's any whatsoever remote indication
anywhere that Dom0 recycling E820_ACPI could be an okay thing in a PV
Dom0 kernel). The more that marking EfiACPIReclaimMemory anything
other than E820_ACPI might, as iirc you did say yourself, also confuse
e.g. the ACPI subsystem of Dom0's kernel.

But well, would extending that sentence to "While on x86 in theory the
same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
to do so, bypassing Xen's memory management), hence that type's
handling can be left alone" satisfy your request?

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:00:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:00:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415602.660212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjOi-0001fZ-MV; Tue, 04 Oct 2022 14:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415602.660212; Tue, 04 Oct 2022 14:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjOi-0001fS-JX; Tue, 04 Oct 2022 14:59:52 +0000
Received: by outflank-mailman (input) for mailman id 415602;
 Tue, 04 Oct 2022 14:59:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IgJy=2F=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofjOg-0001fM-D7
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 14:59:50 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2f16ce4f-43f5-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 16:59:47 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 19CAB5C0236;
 Tue,  4 Oct 2022 10:59:45 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Tue, 04 Oct 2022 10:59:45 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 4 Oct 2022 10:59:44 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f16ce4f-43f5-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664895585; x=
	1664981985; bh=E1lsaIoPoHHZzWdFQKCG0AlCnJ1l1lFD4lk42NTTkGE=; b=N
	QQU4sx5lseJWZlp5c6iZbpApk0bFQr7zQ/ubJlamNn4goRA+Gr7uYT7p3fPVlQJU
	MXFEkmoDVqZv0wx/eT9KnRSk0FVVOHinqf5737Sa4OzQUWRtq1uqa/JsFb2jBvJ/
	LVEzaQHee7QA80hDdxfMDm38e5FqWuW0lpwK/qtqloemwTWKYZYZSATif7FolHr3
	uuIOa23tALIA0xn8mXV8TgSoUmuD4hn86YxdpyIbdeYxPLXfJH7A26pwalhNDPdJ
	i4O/apS6JH6clMeco8ft0U3MY/XnLa3T9/JqRSTE1qXwZNAW+adw4wc7y5HoSwAS
	Eo5EfZJGAjiyJds1tWFBg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664895585; x=1664981985; bh=E1lsaIoPoHHZzWdFQKCG0AlCnJ1l
	1lFD4lk42NTTkGE=; b=ydRrVdOm79rPZwxySLcwRSIewN6kPWn67Ds0G5csSlZ2
	ffwHagOT7/y3/Uzo0CfeNLmnwrb0nxXFdqdSKTVQV6DaED79tg51yKpF5gpoWgL9
	wWAuRA/PejmSYCJy1lJOG9sOys+WMpycV05gmZIwpgF21mh+8pPHqEuJweVcym2h
	XB165c/opX513UTPP0fxsyiBuuBJI4U07QvYMk1htc+PWD1uq/+MC2GSqCQMUtc/
	rdvkYHYi+dMPjj0YtTtH7dXaYe2wFQSnH2odLkVy6GnYZeIkOCnH4Mj2KNxuR5gD
	lJTXw40A3yrkv942ON7qwFtaD2R/DzeedaiTTZ3aLg==
X-ME-Sender: <xms:YEo8Yy6JJuzRFWvg40e7FjD5w38Arp3BuVqVmMvAh7pnX-ylJ7M_qA>
    <xme:YEo8Y77YBc7D74-2rbKPwjP_KoMA-pYUEuV_sWjgKX9vReuV5K-2RueD8ks5SqMG9
    5D3HAUGB5EjNZ4>
X-ME-Received: <xmr:YEo8YxdVwINENChF8XYHhyKoplGQr4tw6EBcCH9AL-IZizU0QbEz400ggwyl>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiuddgkeegucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg
    jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:YEo8Y_JQbo0wKh5TK76KfbR94zfw_jacq8HiucNY9Y1kp37z4jNd5A>
    <xmx:YEo8Y2KnDQwpvWuhv3sNATOU9nl13SXSW-NqU_ITpK-U5UEK2wU89Q>
    <xmx:YEo8YwztcDGEXAh6ip2iOggVz2X0BPLfqA3XQ0ZEiLvZn89CuYvZZw>
    <xmx:YUo8YwxeRC6MXkTm3_IgWKo1YawchgUZQSguyIAfEJ6G6vmzXHdgHA>
Feedback-ID: iac594737:Fastmail
Date: Tue, 4 Oct 2022 10:59:13 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH] Use EfiACPIReclaimMemory for ESRT
Message-ID: <YzxKXi8vPHNHKTt/@itl-email>
References: <2561c7fc38d9b4d17cb0205fec49b941894cfcc0.1664570575.git.demi@invisiblethingslab.com>
 <e42a2312-10e8-87f3-10c4-bb8e0bd765b0@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SU0GZRwYuE+QVsWi"
Content-Disposition: inline
In-Reply-To: <e42a2312-10e8-87f3-10c4-bb8e0bd765b0@suse.com>


--SU0GZRwYuE+QVsWi
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 4 Oct 2022 10:59:13 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH] Use EfiACPIReclaimMemory for ESRT

On Tue, Oct 04, 2022 at 10:31:25AM +0200, Jan Beulich wrote:
> On 30.09.2022 23:02, Demi Marie Obenour wrote:
> > As discussed on xen-devel, using EfiRuntimeServicesData for more than is
> > absolutely necessary is a bad idea.
> > ---
> >  xen/common/efi/boot.c | 19 +++++++++++--------
> >  1 file changed, 11 insertions(+), 8 deletions(-)
> >=20
> > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> > index db0340c8e2628314226c618dda11ede4c62fdf3b..dba23439758d1e842d267dc=
d19448e0f9113b115 100644
> > --- a/xen/common/efi/boot.c
> > +++ b/xen/common/efi/boot.c
> > @@ -601,11 +601,13 @@ static size_t __init get_esrt_size(const EFI_MEMO=
RY_DESCRIPTOR *desc)
> >      if ( physical_start > esrt || esrt - physical_start >=3D len )
> >          return 0;
> >      /*
> > -     * The specification requires EfiBootServicesData, but accept
> > -     * EfiRuntimeServicesData, which is a more logical choice.
> > +     * The specification requires EfiBootServicesData, but also accept
> > +     * EfiRuntimeServicesData (for compatibility) and EfiACPIReclaimMe=
mory
> > +     * (which will contain the tables after successful kexec).
>=20
> What's the compatibility concern here? We haven't released any Xen
> version yet where the table would be moved to EfiRuntimeServicesData.

Old buggy firmware.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--SU0GZRwYuE+QVsWi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM8Sl4ACgkQsoi1X/+c
IsEICw/9FOFQ44DJnzFY2RSCLvj28touruNMgQnD0DexQJhlr/OMfn7P+xdyz1iP
idLkv5nsSUcDBLnj4aaZknvs9cpsZHwNqhFlbf2AgZZBgS/U1g6Gt982u9yFN3Km
j4t2q+dQWN8rvkyvyOwnh/zmYzhnNzqqX2COwXlWQj3GT+a4AUMLLj/vGRGj/OIt
z3uBvS6z25qMW7v6iLNcWvWuFL0aFoFq6sS/juwoQiwIWG0bJcnKbNjtkt3RpbEQ
kq119JlBNusJlKXC/1O9og1bcVUt4dUtUaxbMhPrE8MmqGPy7Upfbqw9u1VzrKvh
8njYVf6EJaJmZwr4uaN2xOAllsj412zqZ9xYSa8rW3YQhTmUVEUUwJCNyRNckmy0
xqNhss9on84AapJfmdgf/4Jn6kRIUVhy5kbqT5YPcztNNtx1imm7o+uUEZ5PKOss
0DxTaymWBG0g/MgT391FpmkY/jCQSNL+OK0JK8vA2RQhfeX3yXYfXporAkND9SOQ
AV640EjK9zdkY8NVxci8zyUcqaiqvsXVFRMCYLKv5Y67Z/5AgbqXEzWar6NxFHgu
ldnH5w3b853OglDZK3G1F2Abi6rxenUZm7KKCK2D47EtiGwa73wsPLsQMuQHx/Wt
CZtx6/MHBCr+nQuqvIEu4J7S+hm6rm6lyUdsDQxdjO7cMVNSi34=
=XR3f
-----END PGP SIGNATURE-----

--SU0GZRwYuE+QVsWi--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:21:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:21:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415615.660223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjj8-00050o-Ho; Tue, 04 Oct 2022 15:20:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415615.660223; Tue, 04 Oct 2022 15:20:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjj8-00050h-Dp; Tue, 04 Oct 2022 15:20:58 +0000
Received: by outflank-mailman (input) for mailman id 415615;
 Tue, 04 Oct 2022 15:20:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofjj6-00050b-OZ
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:20:56 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2289fc16-43f8-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 17:20:54 +0200 (CEST)
Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 11:20:51 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BY5PR03MB5281.namprd03.prod.outlook.com (2603:10b6:a03:226::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 15:20:46 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 15:20:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2289fc16-43f8-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664896854;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=bSX34VhiFTZx92HxkjMB5r2sgl4jWRWBXKW4GQV3CBQ=;
  b=A22xp2vD/ArkG+7PZrBGSiSXqa8gzgNM5QATqt1r9oMPaL6UrSAlLbU0
   oG6tSf7IvqCfYOnuyc4ogkxTcYMOjvlT/MLhKfkQvhwHO3tnYvKreRACx
   JTDkMi6bhVAE3TLCQRT5q0qvRWayqD5WZSeIXTXdGmDrIbCRc5wrglN5m
   s=;
X-IronPort-RemoteIP: 104.47.73.168
X-IronPort-MID: 81966163
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ArdfUsqvna67ZOdpgzLwpRSetz+fnOphVZhZg5?=
 =?us-ascii?q?MifNrXfuXnw3RfKv+XtsWuyehrud3beeAXCVfNA4wCX7e0k/D8hhDNkImdKP?=
 =?us-ascii?q?KKRlNUGi53kHEUtGdQpKxBf2IBDIkaMoNjs3k32Tn0XoIIRTM/z7n5pFH5KQ?=
 =?us-ascii?q?FTXH2Jls3CE57NdUn0f/ln3g1ulqWunx9NCih/NzEKLss9ddfs+xn/215p73?=
 =?us-ascii?q?hFBG6+u/KovLgnq7+fnNvqpbVAho41L3VAc/Jy+QNyNpCdQ1LoFiDN0HO+88?=
 =?us-ascii?q?+H8PtXu3d3uP5guTUcH3RnHgkFunKwrqENggB2hlZtHtBaTxWgNajVyU2mdc?=
 =?us-ascii?q?cZA+WSDEBKbxbU1NZpxEqogDj/nyZO+F+Fo2Tq9pcpBQAlKEfAroRWClB7vr?=
 =?us-ascii?q?DQDImjYCQOJ/SZFXaUEfL1feCVhkxm4gge4+l/dwMHmX9zTLuFfPqVeEiwYt?=
 =?us-ascii?q?xiOZAURmqQkDY3tYH13Y27z+wRMAtJkdd/kv2+34hqr58TJvM5sozmtWio15?=
 =?us-ascii?q?zyTkt+77aEISvPbm0SUZJiVOLbBOTBZARqwc/1E+cTuyu4WJgw4Ef8+d5QeJ?=
 =?us-ascii?q?W5tKHpVQ3rbttPHjdrpMexditGtRIuVErNDopoHnJY+gAVnNU3fisnstv776?=
 =?us-ascii?q?d9xQYydQExiXeaFgiL7frhh9dfNDKElyPjDXPMV2/hUmKDpDqtG3wp7pV6z5?=
 =?us-ascii?q?wQoisvmQvZ2/aavSqsIluBxhkKtVWlswbCEKGrcoNEAzajydO+37aTrVAWa2?=
 =?us-ascii?q?8XO5z+slM3HDKaWdf103x3y2Vr7bconuAmQqmtp5R06PA54P7hhSYF5EGDNf?=
 =?us-ascii?q?3nKGpRNxYgOtuCpjKJoQGgfJ2xH5wxgNCNHs/gJQmm/K98O6dOgKLFydjYNt?=
 =?us-ascii?q?60hNJxtJ3u/sYmINlnf0xtLpazS0fHf4Bly6Z5q5RIqmJfS/z75Oma9Pr3jQ?=
 =?us-ascii?q?EVTU9Y+nb53A1dWVBMe1YWboJW0Rg6ApmwiV+f4Y/Jj7QU46ndrjbtSItjiG?=
 =?us-ascii?q?4pNjDXkSMdx7KGcV1iMAQuxVHpkE8dNyCseymd80ueKniJYBy+eaOKv4nzHD?=
 =?us-ascii?q?9EQB/cqxuZ2tzbAhd142J3XZ7AUEsEx3BQAOsZELlfo43fUl87uPH979RKVC?=
 =?us-ascii?q?8ZmUSJUEWhEmJyvYCWhSzdGPHfs9Imj3kL+2paHl51JlmIQlp2wOYYGjbU8b?=
 =?us-ascii?q?ptxl4maRv18I6VbMhXEBlo0yuRCYx2q7znuC12aErsjJH69u5UJ0U29qCQoj?=
 =?us-ascii?q?f3PVNyxbECYUgpG66Sy3hoUUe2PUrDmE02j8CzBpR9qI0ej5hFl3/tj9PcP5?=
 =?us-ascii?q?h/P4fXgK2LqPEs/+TBebr92UtRiPev9bUkJrQleVN4dj1ZXgMOtfh0HYAF6C?=
 =?us-ascii?q?TaXo6u/xUOur+siPwP0pOcrVW41qwZfV3jjwkrCAbtzlqgwyInD8WNYNDT+U?=
 =?us-ascii?q?VPIrund3AaCa3HQhK/9TO4wi1nL0pvcT6fu0cGgVGPQZ5IAkd7KbSXjU/gNJ?=
 =?us-ascii?q?Z9O8MiqZVk2AEQRUz02DHaUs6yZvFhEY95uelqSDpryDF/CNTBxqkKGmAnkn?=
 =?us-ascii?q?UjqhFIQ+RjqlLMbs4Dk3XxuZvajQ3xMzkJV3oC8MIvQqq8xoap/nTN7iTiNr?=
 =?us-ascii?q?MkbkT29ZBJB7aZcVZltN0Eo52sTyxXIUq44opJBoJY2FdB2ox1zKF7P1B2jX?=
 =?us-ascii?q?W64aYVILbMGGBbjq+JBuf/7BDND+UldTYBDrfRoDY6sA4cvBM0C1ahkFtBBH?=
 =?us-ascii?q?bPemGI5NWgUHQ01atGNa40++NT+cI+GA81SbFy7lqtcxvVL2IFcyjouf9XDm?=
 =?us-ascii?q?dhWTS77o5CVw5CVQHZeqLzfPjeZI8q5/GOuPxjhCg/yCHjis3YmJ6coL/4Yn?=
 =?us-ascii?q?Mwz/jNwa1zpaM/I0JB9eEyvSBwapb+SOnXfiUI2gymjkZeDGt5hlqFuamN/k?=
 =?us-ascii?q?Pip5RUvJkJZMMr2KPkKaGcHOJwwvFrPEYqZs4ctc7DK7CPN75fLZArTSWnaQ?=
 =?us-ascii?q?+W1vTMi+e6FWidbPawG3kTmyNfoXU4C2vN5c2mvOANAkZq/rATrWVfAysL61?=
 =?us-ascii?q?F544cILWc2ud1lDQ3cLV4+cY7iEwXCWB88mJKTLasxeDDwedhMuapQ057z7U?=
 =?us-ascii?q?oQ3gghHi1r7qN6WtIaVWRLlEPF/C1bkcRNj0lheotRGUxRBR7YYCAmovQp6b?=
 =?us-ascii?q?Pv/l7Wa5Ciha9hlkZOz/7fXrKVyQDLErNTBukFd21VxL9PiRjlcSvh7Uc2uQ?=
 =?us-ascii?q?D65ti82gvxtWlzjSfosNXg5hmb0xglIy8bbZhfV1duG3cJSzRS1MJV0wVAvy?=
 =?us-ascii?q?QO3wpAydaSMzVHyRiPbx/qhL3f30xFt9Wxmp8lZX1y1lYb8Wrn0gMqGrnC7C?=
 =?us-ascii?q?wtJl6vSoZmng+IKhGqqy0k6BuvnJxCdD+i3y+FwLhRQxQKoZKaT5LcSH2Ooo?=
 =?us-ascii?q?iMd66DceFPPVUWTBKUkOqhYWNzrBzOc7jixIRPgn6SeoOdJUPfjrrO6dsR1y?=
 =?us-ascii?q?K/Tn98ebjtDxYELu7aW6V0H0riK3Z+QS0pRNMkgwk6xj2mJOqSympYsCn1+e?=
 =?us-ascii?q?deaxIuLlFjBUKOsdKyaaaoSWHo8/RH40JOrVJPKC2L1t23fnqeck5M2QQKv6?=
 =?us-ascii?q?dsPlyq/8MveocGELVU9Y9C4ZRyh2td9X5G6UfLzoO19l5cYoULazURrTAQTC?=
 =?us-ascii?q?qHZvvXN/nIM4MOdqUCI14jrBXCgma5mQ1ZORUvSP+ZDBfX8fTTOeJBJMz2u+?=
 =?us-ascii?q?5g4+0G4lvB2+snY?=
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="81966163"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VLfvJlza1eZ6a/wg9LFpEsuClxcCtctgkqNp8zir5iETFcSNyg6u2vSHtQg7kHy86G9VKI0EfsLCWn09p+6/NK0NwIVDaZoMCFPfCKQO+eF4pQolXBWpEJ5A4tGeajiE9AC7bG8wLY6339wmYtyE7kK1ttOmywdoQ8UDc7ROzoNDDpWuSIvM1z0p88uj30mKTEo5J1QZkoDVO2nDvdFVDHlrZ7RygotXBdRKj/bMlut5JVC2+LRMkJCv+RpfA5NsoFxWZaW68m7ao2tQ1bkjnQsKKeUnVBCWwwoGfGQv1lcwirbGZtpqHnWd83u2vSX553XQN/jz/c8/xOcBClCtKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hW4Gsv37wKLzAqGRy9sFaXOAGzcfWGa1ZwMH6uEUSxw=;
 b=QbY8YTbqc0ggQMt8vjp3ZwoCnfWruIhkyrpIr0s1LjJalEfYHCUJO4E5K+QlkhqB4MO86JC1y2/zH+tk0hr6ET9vng8q1XJbghzZGW7TL8kOU1X32k4c5C56lmqyMupx+QmXBcxoAd/U/N4ggWQhuDNJyMvUuYe7qVgu3oO3820sqnngNAVnvWxp2zwatQJS5BJYGn9VAZsUT40B4y2+g2z8XRt9VkWRtuD5SpQVG2dMBr+2AOBF2gwROuVqPbcNmRMEJDKa4lLyjKOxeRDzvMdAj/FlRnVdUMscDUDdcTrGzPmXFPYQ/8A5TadcJwMdmemkeqJZzcxK4uiGo6cnYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hW4Gsv37wKLzAqGRy9sFaXOAGzcfWGa1ZwMH6uEUSxw=;
 b=h3FNrhc+Ivb0U46LwVp94ucCv63281qaP6DdnJrp1JDW86oEVZTnMPKRujkMChQFFwHfSfa51ypvjseQ080XxkESJEEgaQK6fRRreUDJaBP81cSgB67qlNcygBpsEOk2lr0pYX8dcwlZlEnJop8h8UJfakpNYoP33npy7gQCGuI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 4 Oct 2022 17:20:40 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Message-ID: <YzxPSCXpzjcUmPAO@Air-de-Roger>
References: <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
 <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
 <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
 <8fcb15bf-4477-78f4-f8ee-33603ef20995@suse.com>
 <Yzw8t4oECUL6tzNB@Air-de-Roger>
 <0f3d61a9-aeac-0aba-e930-cee80c9232fe@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0f3d61a9-aeac-0aba-e930-cee80c9232fe@suse.com>
X-ClientProxiedBy: LO2P265CA0303.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::27) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5281:EE_
X-MS-Office365-Filtering-Correlation-Id: e1be2e2a-35aa-4d28-48b1-08daa61c02a2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CYGuiCTvqTw8ZQIin7qjal63vAxpCdr3shKaiApi6PT+sULVKz+sY+3jLqivD3K2hmiWaqh5Vso7cdvTa916OPYnMXVhpiIyDa+Py0C2VDUT+eFFR3oJkaxWLhTaib40XjFrqQ3Ji0qpNhgUuMmN0jbKmRr/r/5RpJuR+4XNy2tzvdkvwBA3IREc/08CmGbEbvDT9+L/5nHaeIym2o1wd+yYxdp+Tl+HP1QJYIvqUM0UyX1n+Y4lpjtmGXJxjlhlRLk70sHVdRMctOILRirFHnCKqMwy+jWYtMsUTqvARPMcBLyuezbHIINWZMOwJTTCDJj7DkSP74zkP62obGdVV/hkrWHyyebWkCKfio7wl8R+PhMWRum1BqJ9ryq2HKQ178ZG+77yvD664rWtLN0Ta1YRChri0IxRnzejnvFQCY3TjYYUpfsQbF80uqPcE8PHt27jPR4y7+l9j0BbHyMZa1xbmMD8Y5ioiv1ikIilH1A4QoWQBh6A9V3jbaLi5CijGUnECrXb+MZzFyTCfX8X4jqdkMyCWUSjl0NSrWe3pgemzAVK4KjYGX9u6dVPLzTf5XhKrb8YH6mlSO4L2xxDx0fhQDaMXzA296vtbFf1KHNXOgbrpuMFOxdWHqbIIbEfHlt0ndob/a8GUQqDa9cElvh24kRoyvqfm8KyrUOIAqe7pi0TX2Ws272nI5lTXd97sgLg7Rl46KgACCsdH8o/YQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(451199015)(6486002)(478600001)(316002)(33716001)(186003)(2906002)(5660300002)(66946007)(4326008)(66476007)(8676002)(66556008)(6666004)(54906003)(9686003)(53546011)(8936002)(6512007)(6916009)(26005)(6506007)(85182001)(38100700002)(82960400001)(86362001)(83380400001)(41300700001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFNsQWY1eGdzY0NOeENOSnVmTWg3VytXZkk3TFpQcklKTmdNVnFCOVQ4OGVn?=
 =?utf-8?B?TnNGVzFvRjYzL2l1Q2dJcERMMG1hN1ZxQnE3aHVTRUxKVWs4NmRhaURrUzV0?=
 =?utf-8?B?cmZJalE3MVpNM012WVRnMStLSGJMUDBJVnAzTTNoZXh5a1owNit5bVRUNE5S?=
 =?utf-8?B?YmZPYjRkS1lxYklUMVZ4QUpEY0JzVFFxZ29VNkxiRnpzSGF6R3diUXBGY3ZS?=
 =?utf-8?B?bXVDRVFCRWc3N0kybXllZHlxZnZwdTVpUGQ2ZjlBYnhMbjgzdXd1MW5hQ2Zw?=
 =?utf-8?B?citPNmhLalMyRWYwNitmOVZadk1WV3kxNDE1YnB2SHRxZGt0SlB4WXYrbGFE?=
 =?utf-8?B?QUlKNW1GeHhmTXA2TjB3S2Z2RzZxL2hTRVlhWXVkMDNDSlMyWVJUM3Qxc01F?=
 =?utf-8?B?Y1VaemRVU2taMUU1S0svdG5ld3FiZjl2Y1g1aGdmVjZBZ1dtODQxZk4yR1p6?=
 =?utf-8?B?SWdvcFVYbTBMQ0tSK1R5RTZ4Vkk3WDVOZndzeTEyeW81bjg3TUJJWVRRdXVN?=
 =?utf-8?B?K0JzN2FMVUszK29qTDhkSUNuQTBIZUJSb3ZzY1lBeDJuZm03TS9EU0h2RG9S?=
 =?utf-8?B?SFJPT1orV0xZOVMxbUsxVDhtQU9iWFR2SFVYdXdjVTZ2R0Fzajc1R2dsemNu?=
 =?utf-8?B?Z1UxN1YrRmVoYWhWeHk1YS9pRmN1eXFWY3p0Q0xWKzlsSWtUd0VMd2hXd3p6?=
 =?utf-8?B?T2gxSEVOYmdGNlBvVlJYV1dBM0FLLzVkdVN0YjNxK05NeGlxUVZWbVAzbmky?=
 =?utf-8?B?aDU1NW9CZHhBejF4dlMrV0YyZmhEMGNHU1lyelg2WmpzSjFuQ2pveUJhalMx?=
 =?utf-8?B?TlZuOWx1dUJDS3Yyd3gvbm52MWdLcTRqaENRSmEvMHNUUXVlWDFxdjdOQUdw?=
 =?utf-8?B?ZHp2eXdLVG1tbnJNNUg3S2FHR2RpamFKMHRVWisvOGJjVHNvMzRBNXNITEJC?=
 =?utf-8?B?ZHJNSDFrR1huVTdGWmEvcDN0Sm5NL2VFekdZRU9KamI0ekxMSHhqNDZacnRB?=
 =?utf-8?B?UDY0d01iNGZsclZEM29JSjN5eFVRcDlsRm0vbUl5YU5pZTRlSzZWSkZqZVRn?=
 =?utf-8?B?cjBGSXExWU0xTGZJUUpXTm13cUh0MmxQWFdiRUtyL05rclI1Mm5kYlVscnl0?=
 =?utf-8?B?Rnlyckx1NWVjTTVDdVdYZkFMK0R4Y0l0S0JxNVRTb3lEV3VoT1pBT1JhUVhW?=
 =?utf-8?B?M1dKUlJuUFYyOW1JZWQ1M0RkVHYxQktRTjA1R3hZaGg4VTRVakgwYVF6eFNS?=
 =?utf-8?B?ZUhyMTY3RXV0bjFzVHJTbTlTeEdIeFJMNmtubDNlVmxGcGE1TTdPY1hHeThw?=
 =?utf-8?B?SVV0eVhsYU5vNEZLY0gzZEk4eWFGQnFOZU1GN2FrZ0c5ME5VeUtZNXZycVZw?=
 =?utf-8?B?RkdsYmZpa0NDR2htQUxnYXdxZFJWbTA3K291YTlOdHhlc0Nheit1Z21iT210?=
 =?utf-8?B?SXRXRGJwWWowMFgzQzlGOGZNNTVQNk5YMlRXdDFIdnlxNkRaVXBQcktwQkNy?=
 =?utf-8?B?UFRtbHczbnFobVkzN04wb1p6b3ZpMWhKY2lKbXMrMjFCNFZqMmtMaE1hZURa?=
 =?utf-8?B?ZktpVzB4ZzJNL01ldkNHQ25maElFRWZZNXRPcVk0Qjh0NGVlamh2UUJBUmhS?=
 =?utf-8?B?Z0ZOZVJhMk9HbFlodWpMa3NWRVI0MWJueHpTMmpnV25oc3RFSmo3QnRzRnJX?=
 =?utf-8?B?UitVTElLK1dudE1JVVF0azRXV3MwK1J2UTUrbHZERUlZbkJGa1JrTFBDaGhE?=
 =?utf-8?B?aG9sMTU1Z2gxa2xqL0JnWDZvTmoyRXF3QnJObW9kQXZIWW5sNmRLM1k4YWV4?=
 =?utf-8?B?dU9qdHNZS29qT3ZQbnM1ckR2Y2x3V3QzMEt5Wlh2UUFobVl1NU1icXdhMHFE?=
 =?utf-8?B?UXFNcmlWd25qRG5jVmd0Zm9FYWFXa09ONUY0NWZPN1FGTHFBamR0ZHlDUFlm?=
 =?utf-8?B?R3gzbEExc3NJekhnc015OGIxRWFkazhWVjJwT0FRUUo2TFpacVV5TVNSYlJh?=
 =?utf-8?B?eEJZeE9XcFF0dzVpVzVaelBwaldEdlc3MHUzVTZLVURGOVlhWGhHdmsrcVN6?=
 =?utf-8?B?WnlUa0FlWlZSNkEwbzM4S3VzQWZlVjg1UUZXVnU0bDlJUXlUZkVia1BvZTJv?=
 =?utf-8?B?OUFNcENsMjVLTzd0bmxhNzBnUDM2RzQ1SS93WDJoSjBsUUE3UnNHT01zejJX?=
 =?utf-8?B?WlE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1be2e2a-35aa-4d28-48b1-08daa61c02a2
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 15:20:46.3112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sd2mrhhquiGFpZ2+iIn7Quh6LJT/h8ZqjXvrDi6sThuOmwsPk+4VjS7G6gNcWAaZBddekLxIz1Zg0QkDYVVwPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5281

On Tue, Oct 04, 2022 at 04:39:26PM +0200, Jan Beulich wrote:
> On 04.10.2022 16:01, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 03:10:57PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 14:52, Roger Pau Monné wrote:
> >>> On Tue, Oct 04, 2022 at 02:18:31PM +0200, Jan Beulich wrote:
> >>>> On 04.10.2022 12:54, Roger Pau Monné wrote:
> >>>>> On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
> >>>>>> On 04.10.2022 12:38, Roger Pau Monné wrote:
> >>>>>>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
> >>>>>>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
> >>>>>>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
> >>>>>>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
> >>>>>>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
> >>>>>>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >>>>>>>>>>>> higher priority than the type of the range. To avoid accessing memory at
> >>>>>>>>>>>> runtime which was re-used for other purposes, make
> >>>>>>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >>>>>>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >>>>>>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
> >>>>>>>>>>>
> >>>>>>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
> >>>>>>>>>>> dom0 doesn't try to use it either?
> >>>>>>>>>>
> >>>>>>>>>> I'm afraid I don't understand the questions. Not the least because I
> >>>>>>>>>> think "it" can't really mean "dom0" from the earlier sentence.
> >>>>>>>>>
> >>>>>>>>> Sorry, let me try again:
> >>>>>>>>>
> >>>>>>>>> The memory map provided to dom0 will contain E820_ACPI entries for
> >>>>>>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
> >>>>>>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
> >>>>>>>>> overwriting the data needed for runtime services?
> >>>>>>>>
> >>>>>>>> How would Dom0 go about doing so? It has no control over what we hand
> >>>>>>>> to the page allocator - it can only free pages which were actually
> >>>>>>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
> >>>>>>>> DomIO - Dom0 can map and access them, but it cannot free them.
> >>>>>>>
> >>>>>>> Maybe I'm very confused, but what about dom0 overwriting the data
> >>>>>>> there, won't it cause issues to runtime services?
> >>>>>>
> >>>>>> If it overwrites it, of course there are going to be issues. Just like
> >>>>>> there are going to be problems from anything else Dom0 does wrong.
> >>>>>
> >>>>> But would dom0 know it's doing something wrong?
> >>>>
> >>>> Yes. Please also see my reply to Andrew.
> >>>>
> >>>>> The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
> >>>>> know it's required by EFI runtime services, and dom0 could
> >>>>> legitimately overwrite the region once it considers all ACPI parsing
> >>>>> done from it's side.
> >>>>
> >>>> PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
> >>>> only appear in the machine E820. In how far PVH Dom0 might need to take
> >>>> special care I can't tell right now (but at least for kexec purposes I
> >>>> expect Linux isn't going to recycle E820_ACPI regions even going forward).
> >>>
> >>> Even if unlikely, couldn't some dom0 OS look at the machine map after
> >>> processing ACPI and just decide to overwrite the ACPI regions?
> >>>
> >>> Not that it's useful from an OS PoV, but also we have no statement
> >>> saying that E820_ACPI in the machine memory map shouldn't be
> >>> overwritten.
> >>
> >> There are many things we have no statements for, yet we imply certain
> >> behavior or restrictions. The machine memory map, imo, clearly isn't
> >> intended for this kind of use.
> > 
> > There isn't much I can say then.  I do feel we are creating rules out
> > of thin air.
> > 
> > I do think the commit message should mention that we rely on dom0 not
> > overwriting the data in the E820_ACPI regions on the machine memory
> > map.
> 
> Hmm, am I getting it right that you think I need to add further
> justification for a change I'm _not_ making?

In the commit message you explicitly mentioned 'we don't actually
"reclaim" E820_ACPI memory' and I assumed that "we" in the sentence to
only include Xen.  Now I see that the "we" there seems to include both
Xen and the dom0 kernel.  This wasn't clear to me at first sight.

> And which, if we wanted
> to change our behavior, would require a similar change (or perhaps a
> change elsewhere) in E820 (i.e. non-EFI) handling?

Why would that be required?

Without EFI dom0 should be fine in overwriting (some?) of the data in
E820_ACPI regions once it's finished with all ACPI processing, as a
region of type E820_ACPI is reclaimable and Xen won't try to access it
once handled to dom0.

> The modification
> I'm making is solely towards Xen's internal memory management. I'm
> really having a hard time seeing how commenting on expected Dom0
> behavior would fit here

The type in the e820 memory map also gets propagated to dom0 in the
machine memory map hypercall, so it can have effect outside of Xen
itself.

> (leaving aside that I'm still puzzled by both
> you and Andrew thinking that there's any whatsoever remote indication
> anywhere that Dom0 recycling E820_ACPI could be an okay thing in a PV
> Dom0 kernel). The more that marking EfiACPIReclaimMemory anything
> other than E820_ACPI might, as iirc you did say yourself, also confuse
> e.g. the ACPI subsystem of Dom0's kernel.

Indeed.  There's no good way to convert a region of type
EfiACPIReclaimMemory that has the EFI_MEMORY_RUNTIME attribute set, as
there's no mapping to an e820 type.

One of the quirks of trying to retrofit an EFI memory map into e820
format.

> But well, would extending that sentence to "While on x86 in theory the
> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
> to do so, bypassing Xen's memory management), hence that type's
> handling can be left alone" satisfy your request?

I think that would indeed make it clearer.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:22:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:22:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415621.660234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjkj-0005Yp-SU; Tue, 04 Oct 2022 15:22:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415621.660234; Tue, 04 Oct 2022 15:22:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjkj-0005Yi-Pg; Tue, 04 Oct 2022 15:22:37 +0000
Received: by outflank-mailman (input) for mailman id 415621;
 Tue, 04 Oct 2022 15:22:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofjki-0005Ya-J0
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:22:36 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5fa89a03-43f8-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 17:22:35 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 234AC1F946;
 Tue,  4 Oct 2022 15:22:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D29E7139D2;
 Tue,  4 Oct 2022 15:22:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id jSc5MrpPPGPaDwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 15:22:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fa89a03-43f8-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664896955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ztO8EC+dr3f2nMhi3IFt0zPBk4xyQJswjPDPygoUBFY=;
	b=FAI5ynOJEkMoD9sKCmKcMm1JYpp+HlCVAmbSm5bLkbUSZkyc3pTmlB1oaXkRJrP+SctDQJ
	YqIlA5tTgTpsNFraMFEqw47z/j8uLFebdGeV0fWAXNeRhQp0yi0VxEXstLYo3QuR1I7inf
	HXFdl6RuHgUcpCH17n1le/z2MXW1UI0=
Message-ID: <e5d0e772-ec9e-049a-da85-960c14520f8c@suse.com>
Date: Tue, 4 Oct 2022 17:22:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-2-jgross@suse.com>
 <a070485a-1eed-420c-552f-16688e89d65f@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 1/3] xen/pv: allow pmu msr accesses to cause GP
In-Reply-To: <a070485a-1eed-420c-552f-16688e89d65f@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ylOBkMi3KrIFlhK6qITfHmms"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ylOBkMi3KrIFlhK6qITfHmms
Content-Type: multipart/mixed; boundary="------------OHgQ8PYiZ0c5e82bKznoBttG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
Message-ID: <e5d0e772-ec9e-049a-da85-960c14520f8c@suse.com>
Subject: Re: [PATCH v2 1/3] xen/pv: allow pmu msr accesses to cause GP
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-2-jgross@suse.com>
 <a070485a-1eed-420c-552f-16688e89d65f@suse.com>
In-Reply-To: <a070485a-1eed-420c-552f-16688e89d65f@suse.com>

--------------OHgQ8PYiZ0c5e82bKznoBttG
Content-Type: multipart/mixed; boundary="------------rHvXbeQpZOqfBNJlLZAFH0yZ"

--------------rHvXbeQpZOqfBNJlLZAFH0yZ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDQuMTAuMjIgMTI6NTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNC4xMC4yMDIy
IDEwOjQzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgcG11X21zcl9yZWFkKCkg
YW5kIHBtdV9tc3Jfd3JpdGUoKSBmYWxsIGJhY2sgdG8gdGhlIHNhZmUgdmFyaWFudHMNCj4+
IG9mIHJlYWQvd3JpdGUgTVNSIGluIGNhc2UgdGhlIE1TUiBhY2Nlc3MgaXNuJ3QgZW11bGF0
ZWQgdmlhIFhlbi4gQWxsb3cNCj4+IHRoZSBjYWxsZXIgdG8gc2VsZWN0IHRoZSBwb3RlbnRp
YWxseSBmYXVsdGluZyB2YXJpYW50IGJ5IHBhc3NpbmcgTlVMTA0KPj4gZm9yIHRoZSBlcnJv
ciBwb2ludGVyLg0KPj4NCj4+IFJlc3RydWN0dXJlIHRoZSBjb2RlIHRvIG1ha2UgaXQgbW9y
ZSByZWFkYWJsZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv
c3NAc3VzZS5jb20+DQo+IA0KPiBJIHRoaW5rIHRoZSB0aXRsZSAoYW5kIHRvIHNvbWUgZGVn
cmVlIGFsc28gdGhlIGRlc2NyaXB0aW9uKSBpcyBtaXNsZWFkaW5nOg0KPiBUaGUgcHJvcGVy
dHkgd2UgY2FyZSBhYm91dCBoZXJlIGlzbid0IHdoZXRoZXIgYW4gTVNSIGFjY2VzcyB3b3Vs
ZCByYWlzZQ0KPiAjR1AgKHdlIGNhbid0IGNvbnRyb2wgdGhhdCksIGJ1dCB3aGV0aGVyIHRo
YXQgI0dQIHdvdWxkIGJlIHJlY292ZXJlZCBmcm9tLg0KDQpXb3VsZCB5b3UgYmUgZmluZSB3
aXRoIGFkZGluZyAiZmF0YWwiIG9yICJ2aXNpYmxlIj8NCg0KPiANCj4+IC0tLSBhL2FyY2gv
eDg2L3hlbi9wbXUuYw0KPj4gKysrIGIvYXJjaC94ODYveGVuL3BtdS5jDQo+PiBAQCAtMTMx
LDYgKzEzMSw5IEBAIHN0YXRpYyBpbmxpbmUgdWludDMyX3QgZ2V0X2ZhbTE1aF9hZGRyKHUz
MiBhZGRyKQ0KPj4gICANCj4+ICAgc3RhdGljIGlubGluZSBib29sIGlzX2FtZF9wbXVfbXNy
KHVuc2lnbmVkIGludCBtc3IpDQo+PiAgIHsNCj4+ICsJaWYgKGJvb3RfY3B1X2RhdGEueDg2
X3ZlbmRvciA9PSBYODZfVkVORE9SX0lOVEVMKQ0KPj4gKwkJcmV0dXJuIGZhbHNlOw0KPiAN
Cj4gSSB1bmRlcnN0YW5kIHRoaXMgYW5kIC4uLg0KPiANCj4+IEBAIC0xNDQsNiArMTQ3LDkg
QEAgc3RhdGljIGludCBpc19pbnRlbF9wbXVfbXNyKHUzMiBtc3JfaW5kZXgsIGludCAqdHlw
ZSwgaW50ICppbmRleCkNCj4+ICAgew0KPj4gICAJdTMyIG1zcl9pbmRleF9wbWM7DQo+PiAg
IA0KPj4gKwlpZiAoYm9vdF9jcHVfZGF0YS54ODZfdmVuZG9yICE9IFg4Nl9WRU5ET1JfSU5U
RUwpDQo+PiArCQlyZXR1cm4gZmFsc2U7DQo+IA0KPiAuLi4gdGhpcyBtYXRjaGVzIHByaW9y
IGJlaGF2aW9yLCBidXQgbWF5IEkgc3VnZ2VzdCB0aGF0IHdoaWxlIG1vdmluZw0KPiB0aGVz
ZSBoZXJlIHlvdSBhdCBsZWFzdCBhY2NvbXBhbnkgdGhlbSBieSBhIGNvbW1lbnQgY2xhcmlm
eWluZyB0aGF0DQo+IHRoZXNlIGFyZW4ndCByZWFsbHkgY29ycmVjdD8gV2UnZCBjb21lIGNs
b3NlciBpZiBpc19hbWRfcG11X21zcigpDQo+IGFjY2VwdGVkIEFNRCBhbmQgSHlnb24sIHdo
aWxlIGlzX2ludGVsX3BtdV9tc3IoKSBtYXkgd2FudCB0byBhY2NlcHQNCj4gSW50ZWwgYW5k
IENlbnRhdXIgKGJ1dCBJIHVuZGVyc3RhbmQgdGhpcyB3b3VsZCBiZSBsYXJnZWx5IG9ydGhv
Z29uYWwsDQo+IGhlbmNlIHRoZSBzdWdnZXN0aW9uIHRvd2FyZHMgY29tbWVudHMpLiBJbiB0
aGUgaHlwZXJ2aXNvciB3ZSBraW5kIG9mDQo+IGFsc28gc3VwcG9ydCBTaGFuZ2hhaSwgYnV0
IEkgd29uZGVyIHdoZXRoZXIgd2Ugd291bGRuJ3QgYmV0dGVyIHJpcA0KPiBvdXQgdGhhdCBj
b2RlIGFzIHVubWFpbnRhaW5lZC4NCg0KTWF5YmUgdGhlIGNvcnJlY3QgdGhpbmcgdG8gZG8g
d291bGQgYmUgdG8gYWRkIGFub3RoZXIgcGF0Y2ggdG8gZml4DQppc18qX3BtdV9tc3IoKSBh
bG9uZyB0aGUgbGluZXMgeW91IGFyZSBzdWdnZXN0aW5nLg0KDQoNCkp1ZXJnZW4NCg==
--------------rHvXbeQpZOqfBNJlLZAFH0yZ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------rHvXbeQpZOqfBNJlLZAFH0yZ--

--------------OHgQ8PYiZ0c5e82bKznoBttG--

--------------ylOBkMi3KrIFlhK6qITfHmms
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM8T7oFAwAAAAAACgkQsN6d1ii/Ey+q
wQgAjZm7tGCX48b2teXUYLXun4s3xNovmtBtNBgh/oD7sN15PaA+XbJERuFIqtjPLfxeii3QKXqu
BNorT6uhYhCOQEOmQF/Zi8UTn/R9mcrSXFTHMm9UP7SabIsxCVTVd7/iRFBZK4J4HaNu1uppqNKz
Da5aou+Kihm3YeEIHj98A3RkOqJkvXRH/Nov+VZ+/ooXHKVK63sN4XRUm3dc4a/9AcjUI1km7hM/
6JkIiSzGwNrWzofSVz6uyAAEewOsNHpa/iGZN0muq6nlGJoPTo3DDKD+SVqY8RSLbBGOGnY2ngK7
KWWyVGCB1P+Giw7wFNhHEBudEmrzb2LJ8CjpzVcKRg==
=+WhU
-----END PGP SIGNATURE-----

--------------ylOBkMi3KrIFlhK6qITfHmms--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:34:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:34:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415633.660245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjvn-00079L-1g; Tue, 04 Oct 2022 15:34:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415633.660245; Tue, 04 Oct 2022 15:34:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofjvm-00079E-Uw; Tue, 04 Oct 2022 15:34:02 +0000
Received: by outflank-mailman (input) for mailman id 415633;
 Tue, 04 Oct 2022 15:34:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofjvl-000798-HS
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:34:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f784325d-43f9-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 17:34:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 71314219D0;
 Tue,  4 Oct 2022 15:33:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 287E4139D2;
 Tue,  4 Oct 2022 15:33:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id nQ6BCGdSPGOcFAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 15:33:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f784325d-43f9-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664897639; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KeymIVaGafrJIHZyo5++21QSxp0G9zyZeB6JP1kkd+o=;
	b=nAR7+6qiqh57XwuW/8vSCHb92+p9IqULp7uw66/oQc/ofwVCOjtLcR083OjsJmd3WTzIwh
	AQlmbO+fUZAWA/f/v9uwff83fg+BoofayGVwHzYXLtjT8CWito06xWDbBGxt3h7oAIxcDb
	od5MFgIolI8UlQkumbQLn0NxIyd5gS4=
Message-ID: <ee01b8d6-ee0c-b17d-1969-4aed41fa8666@suse.com>
Date: Tue, 4 Oct 2022 17:33:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 2/3] xen/pv: refactor msr access functions to support
 safe and unsafe accesses
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-3-jgross@suse.com>
 <623a323c-943b-8c69-f877-a0669b9672dc@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <623a323c-943b-8c69-f877-a0669b9672dc@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------8VLduLm00hOTbdgspvNT7QtY"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------8VLduLm00hOTbdgspvNT7QtY
Content-Type: multipart/mixed; boundary="------------5W5T68iAuXvtxEbEyzgWaqVc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
Message-ID: <ee01b8d6-ee0c-b17d-1969-4aed41fa8666@suse.com>
Subject: Re: [PATCH v2 2/3] xen/pv: refactor msr access functions to support
 safe and unsafe accesses
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-3-jgross@suse.com>
 <623a323c-943b-8c69-f877-a0669b9672dc@suse.com>
In-Reply-To: <623a323c-943b-8c69-f877-a0669b9672dc@suse.com>

--------------5W5T68iAuXvtxEbEyzgWaqVc
Content-Type: multipart/mixed; boundary="------------L5DKmkRAuf0Cox0zaXser4Az"

--------------L5DKmkRAuf0Cox0zaXser4Az
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDQuMTAuMjIgMTM6MDMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwNC4xMC4yMDIy
IDEwOjQzLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gUmVmYWN0b3IgYW5kIHJlbmFtZSB4
ZW5fcmVhZF9tc3Jfc2FmZSgpIGFuZCB4ZW5fd3JpdGVfbXNyX3NhZmUoKSB0bw0KPj4gc3Vw
cG9ydCBib3RoIGNhc2VzIG9mIE1TUiBhY2Nlc3Nlcywgc2FmZSBvbmVzIGFuZCBwb3RlbnRp
YWxseSBHUC1mYXVsdA0KPj4gZ2VuZXJhdGluZyBvbmVzLg0KPj4NCj4+IFRoaXMgd2lsbCBw
cmVwYXJlIHRvIG5vIGxvbmdlciBzd2FsbG93IEdQcyBzaWxlbnRseSBpbiB4ZW5fcmVhZF9t
c3IoKQ0KPj4gYW5kIHhlbl93cml0ZV9tc3IoKS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBK
dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IA0KPiBSZXZpZXdlZC1ieTogSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiANCj4gQWxiZWl0IC4uLg0KPiANCj4+
IEBAIC05MzMsMjMgKzkzNywzOSBAQCBzdGF0aWMgdTY0IHhlbl9yZWFkX21zcl9zYWZlKHVu
c2lnbmVkIGludCBtc3IsIGludCAqZXJyKQ0KPj4gICAJcmV0dXJuIHZhbDsNCj4+ICAgfQ0K
Pj4gICANCj4+IC1zdGF0aWMgaW50IHhlbl93cml0ZV9tc3Jfc2FmZSh1bnNpZ25lZCBpbnQg
bXNyLCB1bnNpZ25lZCBsb3csIHVuc2lnbmVkIGhpZ2gpDQo+PiArc3RhdGljIHZvaWQgc2V0
X3NlZyh1bnNpZ25lZCBpbnQgd2hpY2gsIHVuc2lnbmVkIGludCBsb3csIHVuc2lnbmVkIGlu
dCBoaWdoLA0KPj4gKwkJICAgIGludCAqZXJyKQ0KPj4gICB7DQo+PiAtCWludCByZXQ7DQo+
PiAtCXVuc2lnbmVkIGludCB3aGljaDsNCj4+IC0JdTY0IGJhc2U7DQo+PiArCXU2NCBiYXNl
ID0gKCh1NjQpaGlnaCA8PCAzMikgfCBsb3c7DQo+PiArDQo+PiArCWlmIChIWVBFUlZJU09S
X3NldF9zZWdtZW50X2Jhc2Uod2hpY2gsIGJhc2UpID09IDApDQo+PiArCQlyZXR1cm47DQo+
PiAgIA0KPj4gLQlyZXQgPSAwOw0KPj4gKwlpZiAoZXJyKQ0KPj4gKwkJKmVyciA9IC1FSU87
DQo+IA0KPiAuLi4gSSBkb24ndCBzZWUgYSBnb29kIHJlYXNvbiB0byBvdmVycmlkZSB0aGUg
ZXJyb3IgY29kZSBoYW5kZWQgdG8gdXMNCj4gYnkgdGhlIGh5cGVydmlzb3IgaGVyZTsgSSBk
byByZWFsaXplIHRob3VnaCB0aGF0IHRoaXMgLi4uDQo+IA0KPj4gKwllbHNlDQo+PiArCQlX
QVJOKDEsICJYZW4gc2V0X3NlZ21lbnRfYmFzZSgldSwgJWxseCkgZmFpbGVkXG4iLCB3aGlj
aCwgYmFzZSk7DQo+PiArfQ0KPj4gICANCj4+ICsvKg0KPj4gKyAqIFN1cHBvcnQgd3JpdGVf
bXNyX3NhZmUoKSBhbmQgd3JpdGVfbXNyKCkgc2VtYW50aWNzLg0KPj4gKyAqIFdpdGggZXJy
ID09IE5VTEwgd3JpdGVfbXNyKCkgc2VtYW50aWNzIGFyZSBzZWxlY3RlZC4NCj4+ICsgKiBT
dXBwbHlpbmcgYW4gZXJyIHBvaW50ZXIgcmVxdWlyZXMgZXJyIHRvIGJlIHByZS1pbml0aWFs
aXplZCB3aXRoIDAuDQo+PiArICovDQo+PiArc3RhdGljIHZvaWQgeGVuX2RvX3dyaXRlX21z
cih1bnNpZ25lZCBpbnQgbXNyLCB1bnNpZ25lZCBpbnQgbG93LA0KPj4gKwkJCSAgICAgdW5z
aWduZWQgaW50IGhpZ2gsIGludCAqZXJyKQ0KPj4gK3sNCj4+ICAgCXN3aXRjaCAobXNyKSB7
DQo+PiAtCWNhc2UgTVNSX0ZTX0JBU0U6CQl3aGljaCA9IFNFR0JBU0VfRlM7IGdvdG8gc2V0
Ow0KPj4gLQljYXNlIE1TUl9LRVJORUxfR1NfQkFTRToJd2hpY2ggPSBTRUdCQVNFX0dTX1VT
RVI7IGdvdG8gc2V0Ow0KPj4gLQljYXNlIE1TUl9HU19CQVNFOgkJd2hpY2ggPSBTRUdCQVNF
X0dTX0tFUk5FTDsgZ290byBzZXQ7DQo+PiAtDQo+PiAtCXNldDoNCj4+IC0JCWJhc2UgPSAo
KHU2NCloaWdoIDw8IDMyKSB8IGxvdzsNCj4+IC0JCWlmIChIWVBFUlZJU09SX3NldF9zZWdt
ZW50X2Jhc2Uod2hpY2gsIGJhc2UpICE9IDApDQo+PiAtCQkJcmV0ID0gLUVJTzsNCj4gDQo+
IC4uLiB3YXMgdGhpcyB3YXkgYmVmb3JlLg0KDQpBbmQgb24gYmFyZSBtZXRhbCB3cml0ZV9t
c3Jfc2FmZSgpIHdpbGwgcmV0dXJuIC1FSU8sIHRvby4NCg0KDQpKdWVyZ2VuDQo=
--------------L5DKmkRAuf0Cox0zaXser4Az
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------L5DKmkRAuf0Cox0zaXser4Az--

--------------5W5T68iAuXvtxEbEyzgWaqVc--

--------------8VLduLm00hOTbdgspvNT7QtY
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM8UmYFAwAAAAAACgkQsN6d1ii/Ey/M
sAf9Gcrj/DfNrlLk96AprHuUi7ZmLAl179OybZUv2dezchHykmmDFVw67IoYuYZznQfhr7zMSWjT
VMYnVJa0HVnLT8gvnwdHJNq1pQHUE9v8UfIgECyvBhLoF8iy1vb3zkz8zpaVuSEL8rrPdA7QHffa
1aAxJ/PwuJQH1Lkk+a5sSVjiF9EukKycOyQ3y0b8oJeGtL1ZIU/OWRY02MvgYtOwvxPe+y6XGfW6
d6SlCQ+8ShZRCVaCoR50OZENp9yAHpRbu8DHRdPCfyD6vgRc70pTbvfoG4jWVm+fqMO9aOS8K/Jg
6Dc+aaMsldr+wsncr13gsovzk1NlU95foqHlh+zlOg==
=m+RX
-----END PGP SIGNATURE-----

--------------8VLduLm00hOTbdgspvNT7QtY--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:45:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:45:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415641.660256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofk6J-0000Ey-1V; Tue, 04 Oct 2022 15:44:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415641.660256; Tue, 04 Oct 2022 15:44:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofk6I-0000Er-UJ; Tue, 04 Oct 2022 15:44:54 +0000
Received: by outflank-mailman (input) for mailman id 415641;
 Tue, 04 Oct 2022 15:44:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=AV+7=2F=citrix.com=prvs=269045312=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofk6G-0000El-VR
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:44:53 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7add891c-43fb-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 17:44:51 +0200 (CEST)
Received: from mail-sn1anam02lp2043.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 04 Oct 2022 11:44:46 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB5069.namprd03.prod.outlook.com (2603:10b6:208:1a2::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct
 2022 15:44:42 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 15:44:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7add891c-43fb-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664898291;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=GxM3JauTJ5kpdlfkv1k63x6Ab+AQz1agpnsqWVvPhSM=;
  b=aLad+PJ0yQkdfaLUF7nbwK7VlU3ORH/1Wog8d7Xy5idfEVODZu+s9Mti
   BOhu8MT3Jz8JZFvtB/YNj6Mbr7VR2OxAklh6Zlf+2GLHtrphmA7bNpNU/
   YN/7J2ZtP9y+tHvDDJOlM9awBJ+7qv3LcVlH/VCex5ZJo6JENFP1ViOS9
   k=;
X-IronPort-RemoteIP: 104.47.57.43
X-IronPort-MID: 84475543
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ICD5UKLu/yT+BhBrFE+RKJQlxSXFcZb7ZxGr2PjKsXjdYENS1WAGy
 WcfUG+HPf2MZGCkKIh1Oo+//BwG6JfRxoc2TVFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4G9A5TTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FdA1o7ZXDk5rz
 ONGAh0kPiq7hOSRnb3uH4GAhux7RCXqFKU2nyk6iAr/VLMhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T+fFfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPlWbary/w3YcjmwvccoApSoaCp8c7jX+a4G1QBRkcEneS9KzRZkmWHog3x
 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8+B2FD2IJSjpAbt0Ot8IsQzEuk
 FiTkLvBByFrsbCTYWKQ8PGTtzzaESIYN3MYbCkICw4M+cD+oZobhwjKCN1kFcadsNrxHj3hx
 iGQmwI3jb4TkM0j2r2y+BbMhDfEjprDQxMx5w7Xdnm49Q4/b4mgD6S37XDL4PAGK5yWJmRtp
 1ABksmaqfsIVJiLnSnVGuEVRun1vLCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC
 KPOhT5sCFZoFCPCRcdKj0iZUqzGEYCI+QzZa83p
IronPort-HdrOrdr: A9a23:/u+RcaoUr4vb539m2+aheWEaV5vEL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssREb9uxo9pPwI080kqQFmbX5XI3SJTUO3VHFEGgM1/qH/9SNIU3DH41mpN
 pdmtZFebrN5DFB5K6VgTVQe+xQuuVvm5rY4Ns2oU0dLj2DPMpbnnxE40ugYzlLbTgDIaB8OI
 uX58JBqTblUXMLbv6jDn1Ae+TYvdXEmL/vfBZDXnccmX+zpALtzIS/PwmT3x8YXT8K6bA+8V
 Ldmwi8wqm4qfm0xjLVymeWxZVLn9nKzMdFGaW3+78oAwSprjztSJVqWrWEsjxwiOaz6GwymN
 2JmBskN9Qb0QKjQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimgAdleA59J
 gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGfRsRLQkjQ9o+ao7bW3HANhNKp
 ghMCic3ocfTbqiVQGVgoE1q+bcH0jaHX+9Mzg/U4KuonhrdUtCvjUlLfwk7ws9Ha0GOuZ5Dp
 z/Q8JVfZF1P70rhPFGdZI8aPryLFDxajTxF0/XCWjbNcg8SgPwQtjMkfwI2N0=
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="84475543"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f7ofW9gwG8Xfe9FztL+AFwhG0lZwrphGSme1sQA02FwASE1Cns/4uwyDv+XQLhejbVW6ZAGVmdX6qXdf3okYEo/mpte8rbQtv+PXBKV8IMaPpJ/ktfp5n82bGp+OiY2yfzjlDA9adBeQbwdj5+rbLTh5NCMEhSTGZBFBB2HqAOnQxJ8b8mrtlQzQTcU52Uz2DXvPxKZpVhmGbZDtb06nAmLcQcjDU/4irEHN7Yk9P3LU18qcNxlhX8vIgxeUswt5hSJ1LzwZhxHX9zjnx8Bf1m1R6N5VCoLWreUuFniEdw6/uB3zhQ8lYl2nrnMIBwtR2uNKiMvY3KZ3A9OiylelPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FzHhUgUodl6F+UjPZ8S3zyC2KJRK1vQbJC/liYezVJw=;
 b=JtDaUjoHwKJB8siMXaQW3dcxu8z9CC3WXG1+elbOIoJaFAQZgLvn3TmgYMWmbjKYBsQgR1HdOc1DfJC9OBYIKZDbhwRGwcT2/QXr0Y4iY0zv6B+Gd7PxMX+5t5fzOPBIJCxHULIiTn8hIaOmL+A9GZAT5/UPuQ1L2lnDQNeZ9+MoCoIApn5SezPtQA7QsCG6H1hW8l3hfH+kaKXE76O7KbreFHC0gkLkBTjUi6G7jrKivZW0pQ+SG+T7N9v64ipSz0i3zMtzOrV/O0mDJK8rs/8bUz6YNyY///pV4KLW8E5TuBIooZupb+njUy4syPnRsHmMK+a1MmqJFucgOavQgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FzHhUgUodl6F+UjPZ8S3zyC2KJRK1vQbJC/liYezVJw=;
 b=ZV+c+d6puHp2Nc+sMUM9PluYcOTn2OWXgYGAUgJF4iOMRX4DLjk/qPEbe7utb8sqJ9QrwwNbsXnXlIqAW01+qvFP2ZN1eiU6uwQVsvQkkmm315VMzHoyRPhLMcRGYP6FQT6/K/83ode08LXdaFRvq4/1xbzoLwW/FfuiNr34KXM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820 reserved regions
Date: Tue,  4 Oct 2022 17:36:45 +0200
Message-Id: <20221004153645.3686-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0173.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::17) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5069:EE_
X-MS-Office365-Filtering-Correlation-Id: 91d90215-96df-4a21-2ec5-08daa61f5ab2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iI89q8pOOJ+ROKqvTi5MtcMpVh7gmHeYCHrKL25R0SRGKhhMQxWXKc/QKgzJmBUaEh7V0qNyCIHf8344FeQtJVVJI943l4cSXfNx94bhrISJjLvhrXBoipOfaJTYiWCLYqu0ahQMV4B/rwThAAOELuNbdRLijrPMjECaS6gcNHmf8J5J/a67oIOf4W8N/Z0Ib7ybmBiMGNh6eQjYqTXqkIoDMD9YYMDMbKnBqhC4DWvoE8DpFHRx4qqaoQ8t5zZ+5Hlqsk4Xsx8Q4rFPVhsVbKx0MTBq/+smjtcuu58dbTN/cVKzNjfOlOU5o7byiUzWzrV+7GYiXpzwP7j5v3P+Mzt2UP+pRFmUg48/3m5AkaLeT9oRaypJ6cOqJLJJK1zyJ4qeDcPQNVpVKidGffJI+L9x3vvX/Q+cqlvl3ZUIPpvdQUhVLHPm/T4kUd4Ihy5AE6v8couuTMiKf6Yx2e3jmde8Rh8cyMmiwoSuwCzZ018BRs5sT1A2O9rEmPQDfRxR/T7xusmXibAbsVV1voFN8zYZcHP1pboIrf/Y+P4V2cRxd+0mZ49OiQZfzgj9rOjSGXciGwFnfQ2IbT6sz3XYNPSsCdVrtSDNvm2PIJemD6hxssRC7q67hjUB/o2imjGtKHg66xWhW3hkAV5XAhl7BP0+dSqTjKqzsTmu3EFGB3pWgg8z6EdFHbIws2PQ1SYSsjtXZ9RGCWNIEtnASe3X7Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199015)(6486002)(5660300002)(38100700002)(2906002)(478600001)(83380400001)(4326008)(86362001)(8676002)(66946007)(66556008)(66476007)(6512007)(54906003)(26005)(6916009)(41300700001)(6506007)(8936002)(82960400001)(316002)(36756003)(1076003)(2616005)(66899015)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WEk5UnhmWW4rcTRsMmd0RXVHY0lWbVQ3b0RtUWhmZU42SmZCUG1FYnVQUGtM?=
 =?utf-8?B?amxWQmNYQi9JV1NaYS9zVFd0YWR2SmJGY1ZTZmpTcnJUZlVmUzMwemN2VTlC?=
 =?utf-8?B?U2JqMi9sYjhEVXV5NG01STRxNzdzUkE1eGVxZzRwdHBnUHdrTDFRdXp1ZGk1?=
 =?utf-8?B?amd3S1YyZ3BlQjcxOTNOSDQvWmhOTzU3TVprbVkzb3VTVXFMMnFNcGZGWGc4?=
 =?utf-8?B?Vzdoa3JEZjFKMndrTHFrdnpmWVlRbUJLZjJNa0UzSWtrWllOZ0E4dlVCY1Jy?=
 =?utf-8?B?Q3B1ZVh5Y2ZFa2JhaHJWQitBOHJtVWI4b3NIN0E1dm1OUTAxYTFHQUFwSUVv?=
 =?utf-8?B?MmEyRVZ0dHgzODY3d1NsUGllalZmbE1uUzRDZXlBcFJ5MjhiaFVsRGxTeEZl?=
 =?utf-8?B?QnFUa0NsRnNTeXNGTkJPczNacW56anhSdHRtdHRiQThiZVNxZGpKUkRHU0da?=
 =?utf-8?B?NHZkbTVMVUYzTFdaZjVYYXRBQWRCU3gvT1VyQzExUTdDbHVPc0xvVHNxSFA3?=
 =?utf-8?B?bDM4SUlKeG9oQldXc0FiT0xNU29IcVc3VXpkczFaK0lCZ0YzTnljOGhIRnRa?=
 =?utf-8?B?bC9NS2JJZXJLVUFwSnprVGdiWG5Ja3lsYUkraTJGc1crTVY5MG85VTdDZC83?=
 =?utf-8?B?RS9mTTJNSEl2WlM1SWRpd2o2YTFQY3hmalF3R1BiRVpyak9ScUdldEJRTEkx?=
 =?utf-8?B?TnNqbThPWmRVTEk3Z0RrNXBod2dGQmFQemxuVUEzcytnd1ZtaU4xRVBVVzhD?=
 =?utf-8?B?ZktheklBOCtycXVDckVLd2NiRklMTjlkZnhib3hWMjV0L205R1JDcXFHZDBZ?=
 =?utf-8?B?NmZmaE5HZFFMT2pFOEU2L2s3RXUxUTZKOHdoeDJIdjN2K2FTSmxMRmxLMzVC?=
 =?utf-8?B?aDNCVThraXR4dzVFS2F4SnBEd0EydVNrNTRDWStWUVpwb1l6Nzl6SFFuVzRI?=
 =?utf-8?B?TzUxQmlPMlNkUjdoUWZWYlgxTWxmVlV5SzhlRVhMaGwyaUJ0M1RFUk5qTGdm?=
 =?utf-8?B?OHlZSkc4TGpmUk04eURKVVk4RHJTeUV0U1U2cml4bnp3MlJoVUY4bXF2eDdi?=
 =?utf-8?B?MzRIQXVDWmwzdnlTSlkxTkt5a2VzVVd1V3BXSFpNZ0p6SjJ0UitMd1B3V05F?=
 =?utf-8?B?Vm5rVE5zS3NFUThydWRrTlFvckEzZ1JxdmJ1NmVLN0ZMR1JUSFJaVnNMSi9I?=
 =?utf-8?B?WTAzeUNEckJuN3czMjN1MjNsR1M2K2ZJZjdHem9ZMHdLdWJrWGhqMVM5OGRt?=
 =?utf-8?B?UHc5SjJtZHR1NmdZN2FXb0pMSUFwY3FqRXRKMmpZekR0UFVDcmtWZ0x3dDhL?=
 =?utf-8?B?NEhjb3RCV2FBUmpWQUR2Zks5MWhNa2ljVHFtWHZid201OEwxOGc0UVcxWktK?=
 =?utf-8?B?S2FrL0tJVEZTVDNoTGJmOUpHdDJCNFg4ajlVR2ZTR1RkaHkrN041bDNiUE0y?=
 =?utf-8?B?YjR4cUhOVndwdVhYcFBUVnVZTXk4c0YwOHlBUVJHVFJxK3E0S09neXhweHpt?=
 =?utf-8?B?a0lNV09pdzlhcERLd1B0enFzMnkzdVFmYk1qZEIrVzA4NHZ1UGZtWGRNRGNP?=
 =?utf-8?B?SlZGbXN4dlBzRWlldlFQL3Qvc2x3QkI5bC9nbitBeld4MmF0eWpUbWxrWThy?=
 =?utf-8?B?dG81QStNUHYwK0h6M2tCbGhiMzA0REZENTVKNktqb01JNXl0djZDUlZxU1o5?=
 =?utf-8?B?c3VQZEtKajIrQmVONE41aTROekxUdVN4UTR1YjlUM2dvNWNrRjAyaEUxbmpx?=
 =?utf-8?B?Q0s5Q3EzK1gwbkRTRnlSNHlPMkJqeWkyd0gxRisvQVQzRks0bzdUaUtPdG5y?=
 =?utf-8?B?Ymd2TUtTeU8wOHdieGUzYkZzclplNVJObDJMZHRHQy9zbWlvcGZsNW85ZDRx?=
 =?utf-8?B?ZmhzSVpmRFZUaE5JTkpBeW1pN1dVUGV4MmxwdTR2L1YzTWl1bjNuTUc2MHFa?=
 =?utf-8?B?NlNpK3ZxOXNvTXJKVVF4QjNHWGJINXlkL3ZIb3FOd2Z4bytDYXh4UTJoSzcy?=
 =?utf-8?B?N3pTNDR4R3lyVE5qTU94b09RYWZFQXVsanZ4cVRsZURqTnpRVC9jRUdkUXJz?=
 =?utf-8?B?YzVRQlBTd3l0OVRsNUVhdUJHVEl6WC9Ga25FUFZYN2thOEJlSWFkV1hlbFVl?=
 =?utf-8?B?ckxjMWRiem1XeVMzSXppWjgxSXo2a1h1RVF0aXhUamUzakV5dHhhTm96c2hX?=
 =?utf-8?B?UUE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91d90215-96df-4a21-2ec5-08daa61f5ab2
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 15:44:42.4826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fb7t8+62SdOMWZ7QJmvAZ4VulFXcWwFycnxTSLYigjFA3ezGIOJkFIKQ2EenOUv/BWf6n+QDpdEfFhq7WyTuIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5069

The EFI memory map contains two memory types (EfiMemoryMappedIO and
EfiMemoryMappedIOPortSpace) used to describe IO memory areas used by
EFI firmware.

The current parsing of the EFI memory map is translating
EfiMemoryMappedIO to E820_RESERVED on x86.  This causes issues on some
boxes as the firmware is relying on using those regions to position
the BARs of devices being used (possibly during runtime) for the
firmware.

Xen will disable memory decoding on any device that has BARs
positioned over any regions on the e820 memory map, hence the firmware
will malfunction after Xen turning off memory decoding for the
device(s) that have BARs mapped in EfiMemoryMappedIO regions.

The system under which this was observed has:

EFI memory map:
[...]
 00000fd000000-00000fe7fffff type=11 attr=800000000000100d
[...]
0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map

The device behind this BAR is:

00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
	Subsystem: Super Micro Computer Inc Device 091c
	Flags: fast devsel
	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well

For the record, the symptom observed in that machine was a hard freeze
when attempting to set an EFI variable (XEN_EFI_set_variable).

Fix by allowing BARs of PCI devices to be positioned over reserved
memory regions, but print a warning message about such overlap.

Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/arm/include/asm/pci.h |  2 --
 xen/arch/x86/include/asm/pci.h | 10 ----------
 xen/arch/x86/pci.c             | 27 +++++++++++++++++++++++++++
 xen/include/xen/pci.h          |  1 +
 4 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h
index 8cb46f6b71..80a2431804 100644
--- a/xen/arch/arm/include/asm/pci.h
+++ b/xen/arch/arm/include/asm/pci.h
@@ -126,8 +126,6 @@ int pci_host_iterate_bridges_and_count(struct domain *d,
 
 int pci_host_bridge_mappings(struct domain *d);
 
-bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end);
-
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h
index f4a58c8acf..c8e1a9ecdb 100644
--- a/xen/arch/x86/include/asm/pci.h
+++ b/xen/arch/x86/include/asm/pci.h
@@ -57,14 +57,4 @@ static always_inline bool is_pci_passthrough_enabled(void)
 
 void arch_pci_init_pdev(struct pci_dev *pdev);
 
-static inline bool pci_check_bar(const struct pci_dev *pdev,
-                                 mfn_t start, mfn_t end)
-{
-    /*
-     * Check if BAR is not overlapping with any memory region defined
-     * in the memory map.
-     */
-    return is_memory_hole(start, end);
-}
-
 #endif /* __X86_PCI_H__ */
diff --git a/xen/arch/x86/pci.c b/xen/arch/x86/pci.c
index 97b792e578..6920bf2168 100644
--- a/xen/arch/x86/pci.c
+++ b/xen/arch/x86/pci.c
@@ -98,3 +98,30 @@ int pci_conf_write_intercept(unsigned int seg, unsigned int bdf,
 
     return rc;
 }
+
+bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end)
+{
+    unsigned long mfn;
+
+    /*
+     * Check if BAR is not overlapping with any memory region defined
+     * in the memory map.
+     */
+    if ( is_memory_hole(start, end) )
+        return true;
+
+    /*
+     * Also allow BARs placed on reserved regions in order to deal with EFI
+     * firmware using EfiMemoryMappedIO regions to place the BARs of devices
+     * that can be used during runtime.  But print a warning when doing so.
+     */
+    for ( mfn = mfn_x(start); mfn <= mfn_x(end); mfn++ )
+        if ( !page_is_ram_type(mfn, RAM_TYPE_RESERVED) )
+            return false;
+
+    printk(XENLOG_WARNING
+           "%pp: BAR [%#" PRI_mfn ", %#" PRI_mfn "] overlaps reserved region\n",
+           &pdev->sbdf, mfn_x(start), mfn_x(end));
+
+    return true;
+}
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 5975ca2f30..64995fc68d 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -211,6 +211,7 @@ unsigned int pci_size_mem_bar(pci_sbdf_t sbdf, unsigned int pos,
 
 void pci_intx(const struct pci_dev *, bool enable);
 bool_t pcie_aer_get_firmware_first(const struct pci_dev *);
+bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end);
 
 struct pirq;
 int msixtbl_pt_register(struct domain *, struct pirq *, uint64_t gtable);
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:50:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:50:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415650.660267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkC3-0001fE-MD; Tue, 04 Oct 2022 15:50:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415650.660267; Tue, 04 Oct 2022 15:50:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkC3-0001f7-Il; Tue, 04 Oct 2022 15:50:51 +0000
Received: by outflank-mailman (input) for mailman id 415650;
 Tue, 04 Oct 2022 15:50:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofkC1-0001eu-RO
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:50:50 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50b14b65-43fc-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 17:50:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB7125.eurprd04.prod.outlook.com (2603:10a6:20b:121::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 15:50:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 15:50:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50b14b65-43fc-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RVSYCirkyubzwkrXD56H8Knlr3ivNVnGmXnnOgvaPXKxEOL/cCDRXdIlN8pTMdoI7orfvAvg59Jvhf6reiYwypGW+FstJ2VsKBn9LyEUr7ThuaWr+NPoScibdBVJVZEztrPoBcaid8D9o2aTvnKgbs+9cHAnm2MztXoNCG///818dk6XMegL090e2uINhCOHx60TEiKHDqhmQ4d6rnwmAQh5tYGmW2STMiJKaCqUXphvW8KW+cIv5aDQ2+Cy3DfJiCYpp/45rIVljWKhokHRv4lMWu5zk6z/4qwmo5ub20JCFkdJu48Hf6tKhAl7WAtLAM3aiyHpmL24NUsJilZQ+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hcaHuErX/8Kpvan/3rJElGiQjGhjgRW18NtgU3kxAdU=;
 b=ActI+yBDM5aSyVz/y7tINBafs/TxEwEedImjje/OvSNZmSYeStzyXwDkg7M8+yLDPB6p/ugsWHNw5RzOFKpBDwZmZNzl+STh+5yGGpfHoxWMXNr2LjGv21HOIkKLCr80NEwPWVRUUazQU547HCdD3S9yz+O4bpbjQoFMeA2EoUUfsTF3j8ivsIbuoJZr9GoPX2J0zheU24dh7Pzp/62uShArwXblZTusUJmpThHxNHDWX0epCVVbelenn0YZ3JSgTYeNOtNXajp11CtwgSOtdHfqRu7pugJH7lj6DDYqaYqMxB2c23VsPk7YTkPbBg+5mq5PE2nm7p0t3cs/L5MsBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hcaHuErX/8Kpvan/3rJElGiQjGhjgRW18NtgU3kxAdU=;
 b=Yb+UqJSWqXsJeqxeqB6+e1d5GIxwPZRw5dHiymZw/kNGbDVuh9/LZsMw/7FKrTfQ5vz234yciK5iqPazrQLDZrJpDhQAbRta9L7qUjra5/9ERX6BuA+0YT5KAeFlP9iYwa6iDf/pAeutkTfsVM0xH4k2aCE8OWhYgGpQVn6YZA9z6jGv2RcOuHB47ClMReHBoyzTQZKx+uCgcEyWJpq5Q4JDVkTy593OkDlCqqSN2fNFA92ZKptSqZq+G5MYtendi1XViXTBQE9vyB3C01CtXwbbD3P1dW7+PDDVdEbPL9eq0eTVtFVn5iRglLnfiMZ7p55nPK4e3t7Ry8oBoKBwyg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7a453c41-37ca-6fdf-90e6-333c35fe9489@suse.com>
Date: Tue, 4 Oct 2022 17:50:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2 1/3] xen/pv: allow pmu msr accesses to cause GP
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-2-jgross@suse.com>
 <a070485a-1eed-420c-552f-16688e89d65f@suse.com>
 <e5d0e772-ec9e-049a-da85-960c14520f8c@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e5d0e772-ec9e-049a-da85-960c14520f8c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0099.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7125:EE_
X-MS-Office365-Filtering-Correlation-Id: 907fcfaf-531a-4496-20f7-08daa6203385
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0gmhZKA01N8xHF1NSI9ICbQcO1BJcW4TLL8O3b49m7EdZ4Is6de9ZP2GggtEzI/di0ybvO5CNcg1+VWylOGkce3KZMiA1RYytckLoiTGW5PMqYSEO4pLYrvCmm9VWOMP7B3v1Us72cQ1sHxRfpWDervyXZVtBFgMP3wwnJiS2Y/lqiu9GUAtINc0AQ2u48FNfD+KcsCWbDnUvURea29z23RFbWvzf9p2p/3JmEMFxdFb2hrC71RyT9GFdfx6vcEYqJZ/RBvSgBu5DG7+HHSjAWa3CFlPQiqKWK2sZgn8d7WwpcGNZj0iG//zJzgFMSKgVPUQQu6GPm9z1kt0sk/uXzRU7qMeFzWQU2jywUVIZFY/FufEv5RAWs5OWJKignrU4E5FJ6GWCyFPEPMy7fw8M79rcgNZ52/kh8gjqdIOIRrGXDA5EH+WVaY4DdQ0J1EKTinxEv4EVs126HzXXaCbaZ5aDw93n5E7rNyFR1meEwq/5QX+NSQX5CJlZORW75AR2QUDGHYWAYijRKls2QmVdS9tm2PEh4PyJDoWU2nyG1vewdpkHUXPP298mHk1/tYAdwdyaf1CWBuOfp7sCKO5Mb1f/DVvzJfnqby/YwzI7rzYHKMFZePI6klyOhfPT7baDs9DZzydkQqPZXSChO8bBlaYpbycJA3oOngkrVp02F9C7GlEpT3ath6ScI+8xnAZnONE7h/4YM+jmm3gLXKaVt28VNAyz5vswnJy2zu2p6y9L0XiEy2o/wNnYbDi+m1yfI1yiJ0+UuhCEbWcPqDTqXaAmqcUC0ce4yHPENqw6B8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(366004)(396003)(346002)(376002)(136003)(451199015)(86362001)(36756003)(31696002)(478600001)(38100700002)(2906002)(6636002)(4744005)(41300700001)(5660300002)(8676002)(4326008)(37006003)(54906003)(66946007)(8936002)(316002)(6862004)(66476007)(6506007)(83380400001)(2616005)(66556008)(53546011)(6512007)(26005)(186003)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SFE0YzRDNEMxTEJlOUc0aFEwZkFFUWo2WUlPTnRWKzNHNjljaTRuWEIzdWtY?=
 =?utf-8?B?cEJrZ0l5VFZVZkxJVGJxeUNXK0dxVGF2REN4KzkzQUJyY01RWEdPL0lYcHNJ?=
 =?utf-8?B?cVdTaGIzdnJmaUw2dk5zbm1YWGorbC9iT0pEV2p4cFJzeFBPWXgvQThoVW5l?=
 =?utf-8?B?bW9TcEc2U21vTXJlYm4zWTVjTWRQSFVMYmlraGtDMGxsejZMNTdYME5sOGZM?=
 =?utf-8?B?K1dPT2lZNGZZMW1MbnFzRVZlOXZZYThjNkY3bXhhdmZDQ0hHczVVZXJRQzAy?=
 =?utf-8?B?eDk1MmEzbFBUV2hEU1JkaEF3NmhNU0o2eTM1bGJrVTdzKzRvRERJaXVSMUpI?=
 =?utf-8?B?UzlMSEZlYmtEa05DOC9SS0x5M3pNdUZadEJGVkFsUmxFUW5qbWtKaVBiRjBF?=
 =?utf-8?B?RklDWWp1R1N3QUdjTWMxKzNDNnZmcDRPOEhrbWpmQlgzYXh2cDRnZzFCRUtB?=
 =?utf-8?B?Wkh2NGxRTVRnMW8ySkY2WkZ3b2thd1N6d0hmOWQ3MVh5bkZWejdEMy8wYXpS?=
 =?utf-8?B?YzZrcEM2NmFac1ZxbHdCMlU2a28rQ0FZMTNVR1B3YWtxRkVpdW84Vzg4UWZF?=
 =?utf-8?B?V2ZmSDBWQ2VuR0NpSnZ2UEsvbDIzb05NdUtLaUZYbWNRN2NsNTk0akFJSXF1?=
 =?utf-8?B?ME1SanZyb3dhVitKRy9WRWdkSHlxd2RERE5rTm9JTURRMFd4WXRSU2UxZSt2?=
 =?utf-8?B?UENCekRBN0ZhN1Q4WHVMMFg1TDhEQTRZU2xTVjh1WWhLNUpBcVVsV1NuZmdl?=
 =?utf-8?B?NzByVU9uTS9aNjM4R3lJVUhZYlBKV0g1dEYyeHJJYXBaU0ExOVVWZmg3eFdZ?=
 =?utf-8?B?Z1Y0LzVXc3JmQ2kxSFF0K1piUDd2dVRPR1JacjZLeU8xenVFZzdVV0paaUpn?=
 =?utf-8?B?NmRXeGJHRWxKaVUxdDg2UHVKdTdObEwxckpuWnIrU3dpOTJ3UlZRUVF1Qy9E?=
 =?utf-8?B?RU92bTdjaFlWbGQ2SEdVQVRqeDFRMWhhVFZzM0hTZGhkank1enN3cE1yand5?=
 =?utf-8?B?UEFjMDFwR1lwNGg3SVEzejFiOGJabUUxOXlSZnhJSWdjZ1V0R1dIaUs3ZEVH?=
 =?utf-8?B?L2w0UDkwUE13ZW4vdlE1d1JGbU9XWVdFbUtoakFLOUFUUTdHTitDcUExSlBM?=
 =?utf-8?B?OGFacStyOEhoMGFjUnJiM3VnaFlUYXlCMWt5Y1NqZ1RRK2xOSGVsUUJjQXg0?=
 =?utf-8?B?L3lsbzkvekI2a2xiNFhtb0xOR1F4OC83UTh5cFh3aGVCWjd1YUtIVmxIWXBI?=
 =?utf-8?B?Vkp6dFVmWW5xSll2bmNlS2JNakhPTTk2YkFwcHFYTmxmYm1KazRMZEljd0FI?=
 =?utf-8?B?ejl1ZTFHMEwvVEZpUWEweUZCRkFjTHErUzNDSDliWWpmaW1qNjdLdE9ITDQv?=
 =?utf-8?B?T2dkOGtxYmQzLy84OG5NUTNnTjg5MFY2eFJNa2FlMngrYWhyeUR1YmZLQjVR?=
 =?utf-8?B?b1lPSEJHRlRCTTdmRkJSQWdNRDI0ZlpraUF4ajZzRGVSOS8wbFplUDA3ZGNs?=
 =?utf-8?B?Rk1TOUE5L0tFaWdpVVo4c2drK2wvQklMaVFkd0h5K3NVcFdCc3VCQnN6cCtX?=
 =?utf-8?B?bEhmb2w2TU1PdC82ZlFsLzNjL3dKT3BrS1loU3NUaDZaUDduYUZxWUFJdGhT?=
 =?utf-8?B?Q3gyaXQ0bFlTd1BaWnlZa2F1R2xHS2Zld0FVRzdqQkY3dG5lVzlNV2hFc0Vi?=
 =?utf-8?B?WTdNWHNuSXFyWFhvZkQzNjRpQWZEM1lneUR1cWRsMHEremVTQ2VaamVFdTVX?=
 =?utf-8?B?T3Jzdnd4aW4xTTB3RURNTnlPZitjcERLS1JaTzlIbG5LcXBJK3Fmc203aVNW?=
 =?utf-8?B?MThnRlJJckQ4ZDYxa20wTkc1OHExU2JzV2NSZmM3cXpXd2hjUnZacmF4Ym1M?=
 =?utf-8?B?VjY2R0JXc1BadmVtd0dYcWdMYjFRU2p5MFVGQWRnT2JrR2pYYWd2MFZmbjlz?=
 =?utf-8?B?aGh1RTU3VUFEYVFOemxVb3BjSnZwWEVMeUkzTWkvQ1FOaWc4ZG0rSEY2TG9K?=
 =?utf-8?B?OEFSWFluK3VpcW5OeXY2NUxpZUpxbWFLRG5ibDg3KzNpaDQyM25rYXhjNURM?=
 =?utf-8?B?bWNiSGp4aE9PY3lLK1NsK0RXc0FCL0pHeFk2WC9rN3JkcmFXeWJ6RjhaTmZw?=
 =?utf-8?Q?wMXaJSfBFwi11ZMlqlswy/zlk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 907fcfaf-531a-4496-20f7-08daa6203385
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 15:50:46.1435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k5PUKfyXsI4hmrn+dzhs/LqJLhbZD7HN8ySFIA7AF4wjfjDm4eN918pDsHHZ1g0uIIlw+YcfFYLbiTRowpzmOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7125

On 04.10.2022 17:22, Juergen Gross wrote:
> On 04.10.22 12:58, Jan Beulich wrote:
>> On 04.10.2022 10:43, Juergen Gross wrote:
>>> Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants
>>> of read/write MSR in case the MSR access isn't emulated via Xen. Allow
>>> the caller to select the potentially faulting variant by passing NULL
>>> for the error pointer.
>>>
>>> Restructure the code to make it more readable.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> I think the title (and to some degree also the description) is misleading:
>> The property we care about here isn't whether an MSR access would raise
>> #GP (we can't control that), but whether that #GP would be recovered from.
> 
> Would you be fine with adding "fatal" or "visible"?

That would help, but "allow" also is a little odd when it comes to
(likely) crashing the system.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:55:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:55:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415660.660277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkGE-0002Lx-BH; Tue, 04 Oct 2022 15:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415660.660277; Tue, 04 Oct 2022 15:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkGE-0002Lq-8e; Tue, 04 Oct 2022 15:55:10 +0000
Received: by outflank-mailman (input) for mailman id 415660;
 Tue, 04 Oct 2022 15:55:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofkGD-0002Lk-2b
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:55:09 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2086.outbound.protection.outlook.com [40.107.104.86])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb25922b-43fc-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 17:55:07 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PR3PR04MB7339.eurprd04.prod.outlook.com (2603:10a6:102:8b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct
 2022 15:55:04 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 15:55:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb25922b-43fc-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VKX4YI9J0bd1BK9uJaids4Uirzhcl/Qur/DRNhHSb+OgvQBAFTq9jXDV4UGD8wepQ7A1CjLgC6b4UY7c6e047sVJSIdyEWkVtTfIsr+Ibj6cuZEBxNiAQCSLr7qcPNZveQ40ytJi+ahE4XbpJweN6xWDOqySLh+A+zp1mZvYycTIww/nN4WtIjX0Oua15IeBIA5ytfJqLDj3mFbh/RwjANXQseaZyhnRzGSEuumHp5vr7ji9Z1lwtLKow2jrXRCnB6oKzfmU+TJ6kDl3jodly/k3pZql6Y9RkF2KWfx+jVG04j1nuMAWQiyjmfJ8BiUU1qdp62THEIAViO3s3Qe4SA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z0iQhFWJdNyZVsqfBQK6cwL4a7rFakcHBlmdpz5cRQk=;
 b=n3tIkdJjV3WUxofyrmB2Kapl34dg/oc8m0q1yR7ZO4WWIVliVAETqpH7DJnnrfs8JmEAyhB5OCMon4iD+bAxE8l36e06g2694snlOl2mdAOwbcCXHeh3QJXO5tMMgrWR0tyuD8drSR6AOyb8yPLdqHutlv6TOtKQ+vtUdkakpK+krN6bLtyKFZzztJlT8rnqyxf1nyHPMNSuWymQhraMDxHNvdqEohZVstLt4oL6e/aDHaUvv3m+3/jQYHXL7UHR01AXM1xV0zy3GNlLWJ1ikjBgE+NF3RZKQ9/gTIKfdCKPjIGL8SzqhQXOoKCgOV3FGfBd1OcvobwSVu9PpT52zg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z0iQhFWJdNyZVsqfBQK6cwL4a7rFakcHBlmdpz5cRQk=;
 b=zxyUepKPL16ZdSyiMa3Yv0P0rXEIGuTD1kBt/AT+pP0vPCpTs/MKX1ukRdE4ceffKG/R166+7PwUXrtEeBf+D0Wr/5NImi1xK3zYftenHLN5o1P+Cxpprnj1BS42KadzSia1uAAWtTGokMu838h8KkeiffwJyp2WJsJxnumoBxpx+2wdHzZO5i5CUBRPdh6WSXlDuE6gcEh2s5VtGFqaEhylAijNkgVxHSlLnuWuQelPhXOHOs5SCKBIwevLh1EYNo/Ir34VqeiGFRlafCaoowmHtYDqHT9TZ61TZOBuvR4UKNfphhuP3HVHnPE7aLwrJpC15JjrMI9Syw7sh93oOw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e1116596-f204-1b30-615a-cc7e84836661@suse.com>
Date: Tue, 4 Oct 2022 17:55:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <Yzv92zTdfG748MXO@MacBook-Air-de-Roger.local>
 <19befbce-ac16-19fe-25a0-73678ce440c0@suse.com>
 <YzwNGd0wiAbhDR9e@MacBook-Air-de-Roger.local>
 <db9856f9-1777-8fe5-5b5a-ef3f132193dc@suse.com>
 <YzwQymW3jkfzUQrI@MacBook-Air-de-Roger.local>
 <9aa0569a-bc18-9480-c86a-817222d4fea1@suse.com>
 <Yzwsq/LL/i9ARxiJ@Air-de-Roger>
 <8fcb15bf-4477-78f4-f8ee-33603ef20995@suse.com>
 <Yzw8t4oECUL6tzNB@Air-de-Roger>
 <0f3d61a9-aeac-0aba-e930-cee80c9232fe@suse.com>
 <YzxPSCXpzjcUmPAO@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzxPSCXpzjcUmPAO@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0099.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7339:EE_
X-MS-Office365-Filtering-Correlation-Id: 95e5592f-6bd0-4b58-10d1-08daa620cd81
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	67DtY2FLtpEtSlWvYANoKX9duJ4M+ibOktKQ50qLtcvZbeKFLUCLWm97HTRP7YkUs6FipxA481VuhnhppxOsIcD9v8Z0ViUWzc5vCDoKcpS3yBZRXUyAdYsmYRIbwuA/sZEmvU0wSrfmz6KfN3etkZte2lGZ3N7OcRJXMk78EwUK6NxWLY9Iwuj1yXjE1ddqWPuiPecXX+/NsSwdx2Kf0QNyp7p64q3gb8a1ioblSCDwNqUfep8wvYL6OQM59mOXkCDWTS7oEx2exspb9s3RX83xiU1kyovNZWV6APOhZMrWdLPPiD3YhwFO6Cr53chH6ykTV/fg/2JMavzAAx/IvSOYmF9mf5aVTvMwOuCSE63JmVRGoHPfrer2VAEDWg9HprAvXGpPlaVvPKGlhtSepsq2R8XBp+eRjbZC/GfXofxJ6/7+W1Hn5nSmxiFjkpsxl5oASg2Fl6y3qyAD+47c5na76ziEPR15eMNytiBieoaaPYleqR0RI9a3L9W3KUYe8+F5PbnNqThnmGJY80/kEgh3ByMUfH6qoHrEWpi/0Q1unMbtW0OcFeHYTPS7XdlQM2yQtSwNP8U4IZNryJ67RAh6A4bjA97t/WEYTEueh6kJ+1jc2flKwpTlDG1fv6dwWb5xZexHdrLwWNb2J0hlUNdkqw1lUF/jK+8R8Tn5RC3TgsdrNWVATLaqgdH/fHR633393EqXSPpz4k+sAU2hSkM+i1VT/HY5lXZDzWImms1LVDRbzUFgB2G7nqUCyqGUkWiHy4k6WugT3BLcWB9HFiICt/6Xvd4cuSDyT3C7o9U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(41300700001)(53546011)(86362001)(38100700002)(6512007)(316002)(31696002)(2906002)(83380400001)(6916009)(186003)(26005)(54906003)(6506007)(66556008)(4326008)(36756003)(8676002)(2616005)(66946007)(6486002)(66476007)(5660300002)(31686004)(478600001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OXFENGpmTHdEQ0RnZW9na2d3emwyOEhrNDY2dlBJRVV6LzJURDdUUGwrcDlV?=
 =?utf-8?B?L1Q4M0dyeGloVDVhcHF3TVoyempxSDRWdDB1bTV5Zm01cjFOd1hmcXBqb3Bp?=
 =?utf-8?B?YmcvQ0cwaE9CQldyQWZ6L2V3b0pKdEhickh0RlN6d3huMDF6aW83N1lzbEE4?=
 =?utf-8?B?THFJVHJlTzkyUmxDZTJtNzZ6L2syc2haYU1vQ2x5SXM1NGswUEdJM2lBYVlC?=
 =?utf-8?B?bTMvcGZYaDVwR2pUU0lJVFVlWnJhVUJicFNFSXJEa2d0Z3NIcVo3dkgvc0hj?=
 =?utf-8?B?c3I5NXl3bTk1Y2RuZHRJaS9seUdKUTJnaTVMdndIQzRlVVc4Tlg5WGx3TkdU?=
 =?utf-8?B?ajZlOWtDZU9tZEp1ZDh6OFR6NTFOYmczSGRWYlZremsrc2YyN2JCMmhOV0RT?=
 =?utf-8?B?NE9mUmQ0d3VzTmFuWWpDUVZuWmtSRExkZW81TEhhc21ISW1PM1BHS2RBT3c5?=
 =?utf-8?B?SEJ0V1MzMGFsOW82SHhybHRUMFBqdGpXSUtOajJhQjFnaFJiM2RzbjVvQTk5?=
 =?utf-8?B?ZHc0SXN1M05wNWhQZTVlM01tQ2ZndjlFdXhsTzMvckcwRW1xYk1ybmpPZjQv?=
 =?utf-8?B?ZzNYNnI5NDBPK1FQQ0N3dFZOT0tESDU4VFRxUk1zdlNBcHVxV01vbUhTREZ6?=
 =?utf-8?B?MUZYUVJDUjNlMForTk5GV2p4TTFrRnpVOFZvb2Z3QVdVMHlObW9KejAvd0dM?=
 =?utf-8?B?d3UwaDMwVDNOYnp1Sm5ZNEZFMFUycXRpVzdRR3loNm94ZWlpZjh4enRtc0tt?=
 =?utf-8?B?TXNNaXFrTDJtcjJHbEladWNzK1UyR09qNVFLVXVqcHhEbHR6dnhyNDY2REVT?=
 =?utf-8?B?VkZCTUZsZjJCUEpLRG1rNzlZM3pidG0zcVZwdWozYUFPbFEzTWM3SmVwU2Fi?=
 =?utf-8?B?YitqQk5NSkUvUVZtU0sydk41aGpMckxmSlhUY3NOR1J1UThFS0lYbm9WbG5H?=
 =?utf-8?B?eFkzdm8zTmd6ZU5QYkd5Mk5IT0ZJM3hCTjk3YVBnRVpVdzJPSFcyckx2Q3Fu?=
 =?utf-8?B?Y2VkWUoyZG5ETStocDUrRzhnNlFqMGg5anE4Y1F3aTdkSFBwZWJsdVVVRXBB?=
 =?utf-8?B?SmpiWjJNdElyTnNvL0FKdEJiQmhleVduUERGaDhFOTJ3dmpqMWZRSEVBVXBs?=
 =?utf-8?B?ZjR2KzVpeDFCV1o5b2srdHF0NloyZWdpaUo5OHFmRzlId3Vrc1ViME5Lcklq?=
 =?utf-8?B?eXFJUUtYdmNCQys1RlF3UktIVkZzNHFUL0t2YXFuT0F2NmZKYnFIQTVNRTVz?=
 =?utf-8?B?amR3Z3ZCRUtaazNRNTk0WWVEcUVWckl0VUI0RFFTRVRFNS9rSUh6SXU5TUh0?=
 =?utf-8?B?Sno4WFhFVkhNYnRGRmUyWXlsNmhkQmV1NFo2dWNNY1lhdnpyZWJSczhnUk5R?=
 =?utf-8?B?SUJwMnhnc0hudHc3cFdvVGNVOUZGTnBvK1BvbmpCNm1salpwVS9CQTZObkZw?=
 =?utf-8?B?eEpNeTQ4a0VEekpqL0VVR3hvRTZaWmp5am9JYXd4TXVlRk16V3liOEZhVmJr?=
 =?utf-8?B?allsNXFBU25iUy96Q1dRNnJiNFdqM1NXQVNPbURxS0lKSXBuK2Q2V0NhQ2lJ?=
 =?utf-8?B?cUpJQlZHNGpIb2F1bkFwOFRLQnZiUTZoV044R043ZU43R010bDVnM3hHdXl0?=
 =?utf-8?B?SnVDUXlObjV1aS9VYkpUTmd1ODRaNUZHTHpFTFBYaWUrTDB0aEtwZUoyM1Fr?=
 =?utf-8?B?UmdkbmJlUnp2eEdhVjYrcXlpL3FiaEJwZVZqM1FrOHVac2svMXpaeXI3UGlL?=
 =?utf-8?B?WWFuTkJkNks4RTZ2QWdMUElkOUxnWUxCSzBFcTQxSUVtSE1ER2g0UzcySkRu?=
 =?utf-8?B?dENyRnoyOW9sUXNlbXNRYm9kcldVN29DSWVML084Z01qQXFwOVR6RTVzdXFD?=
 =?utf-8?B?UC84NXJkVy9JZ08ySWJDWWY4eEJybDRMeS81ZU1KMlNkTlhGcTMvYXRWVzd2?=
 =?utf-8?B?WTIwSVpuNVBTMFVNZzFkcXV0Y1JlNSttSDhyMjhjdmtGWUNadGhVZUVEV3JU?=
 =?utf-8?B?VytYVjVIeFAwK1pvaTFHeTgwYWdlb0JFR2V0UlQvcVJYUjJwZjE3Mk44YmtQ?=
 =?utf-8?B?cEVRaFRyeGVzdS9ZckRaMVBhRFRiUVlZZjFYTkd2MXNDZUZFbzJnT3ltNk13?=
 =?utf-8?Q?WWBzghXUlBahpPcuuYQ4pWxSU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95e5592f-6bd0-4b58-10d1-08daa620cd81
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 15:55:04.5017
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dWfkPFIDeBqu2b2DzviE4juwHbZ1JoWCxGlgkGpdLbsAZYS4tkUk5k8virFXBt/fkOXfhvbxE+GGkaOoKxrv3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7339

On 04.10.2022 17:20, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 04:39:26PM +0200, Jan Beulich wrote:
>> On 04.10.2022 16:01, Roger Pau Monné wrote:
>>> On Tue, Oct 04, 2022 at 03:10:57PM +0200, Jan Beulich wrote:
>>>> On 04.10.2022 14:52, Roger Pau Monné wrote:
>>>>> On Tue, Oct 04, 2022 at 02:18:31PM +0200, Jan Beulich wrote:
>>>>>> On 04.10.2022 12:54, Roger Pau Monné wrote:
>>>>>>> On Tue, Oct 04, 2022 at 12:44:16PM +0200, Jan Beulich wrote:
>>>>>>>> On 04.10.2022 12:38, Roger Pau Monné wrote:
>>>>>>>>> On Tue, Oct 04, 2022 at 12:23:23PM +0200, Jan Beulich wrote:
>>>>>>>>>> On 04.10.2022 11:33, Roger Pau Monné wrote:
>>>>>>>>>>> On Tue, Oct 04, 2022 at 10:06:36AM +0200, Jan Beulich wrote:
>>>>>>>>>>>> On 30.09.2022 16:28, Roger Pau Monné wrote:
>>>>>>>>>>>>> On Fri, Sep 30, 2022 at 09:50:40AM +0200, Jan Beulich wrote:
>>>>>>>>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>>>>>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>>>>>>>>>> runtime which was re-used for other purposes, make
>>>>>>>>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>>>>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>>>>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>>>>>>>>>
>>>>>>>>>>>>> What about dom0?  Should it be translated to E820_RESERVED so that
>>>>>>>>>>>>> dom0 doesn't try to use it either?
>>>>>>>>>>>>
>>>>>>>>>>>> I'm afraid I don't understand the questions. Not the least because I
>>>>>>>>>>>> think "it" can't really mean "dom0" from the earlier sentence.
>>>>>>>>>>>
>>>>>>>>>>> Sorry, let me try again:
>>>>>>>>>>>
>>>>>>>>>>> The memory map provided to dom0 will contain E820_ACPI entries for
>>>>>>>>>>> memory ranges with the EFI_MEMORY_RUNTIME attributes in the EFI memory
>>>>>>>>>>> map.  Is there a risk from dom0 reclaiming such E820_ACPI ranges,
>>>>>>>>>>> overwriting the data needed for runtime services?
>>>>>>>>>>
>>>>>>>>>> How would Dom0 go about doing so? It has no control over what we hand
>>>>>>>>>> to the page allocator - it can only free pages which were actually
>>>>>>>>>> allocated to it. E820_ACPI and E820_RESERVED pages are assigned to
>>>>>>>>>> DomIO - Dom0 can map and access them, but it cannot free them.
>>>>>>>>>
>>>>>>>>> Maybe I'm very confused, but what about dom0 overwriting the data
>>>>>>>>> there, won't it cause issues to runtime services?
>>>>>>>>
>>>>>>>> If it overwrites it, of course there are going to be issues. Just like
>>>>>>>> there are going to be problems from anything else Dom0 does wrong.
>>>>>>>
>>>>>>> But would dom0 know it's doing something wrong?
>>>>>>
>>>>>> Yes. Please also see my reply to Andrew.
>>>>>>
>>>>>>> The region is just marked as E820_ACPI from dom0 PoV, so it doesn't
>>>>>>> know it's required by EFI runtime services, and dom0 could
>>>>>>> legitimately overwrite the region once it considers all ACPI parsing
>>>>>>> done from it's side.
>>>>>>
>>>>>> PV Dom0 won't ever see E820_ACPI in the relevant E820 map; this type can
>>>>>> only appear in the machine E820. In how far PVH Dom0 might need to take
>>>>>> special care I can't tell right now (but at least for kexec purposes I
>>>>>> expect Linux isn't going to recycle E820_ACPI regions even going forward).
>>>>>
>>>>> Even if unlikely, couldn't some dom0 OS look at the machine map after
>>>>> processing ACPI and just decide to overwrite the ACPI regions?
>>>>>
>>>>> Not that it's useful from an OS PoV, but also we have no statement
>>>>> saying that E820_ACPI in the machine memory map shouldn't be
>>>>> overwritten.
>>>>
>>>> There are many things we have no statements for, yet we imply certain
>>>> behavior or restrictions. The machine memory map, imo, clearly isn't
>>>> intended for this kind of use.
>>>
>>> There isn't much I can say then.  I do feel we are creating rules out
>>> of thin air.
>>>
>>> I do think the commit message should mention that we rely on dom0 not
>>> overwriting the data in the E820_ACPI regions on the machine memory
>>> map.
>>
>> Hmm, am I getting it right that you think I need to add further
>> justification for a change I'm _not_ making?
> 
> In the commit message you explicitly mentioned 'we don't actually
> "reclaim" E820_ACPI memory' and I assumed that "we" in the sentence to
> only include Xen.  Now I see that the "we" there seems to include both
> Xen and the dom0 kernel.  This wasn't clear to me at first sight.

It was clear, actually, as I did mean Xen alone. It didn't even occur to
me that one could consider Dom0 potentially trying to do so.

>> And which, if we wanted
>> to change our behavior, would require a similar change (or perhaps a
>> change elsewhere) in E820 (i.e. non-EFI) handling?
> 
> Why would that be required?

Because if EFI can (ab)use that type for other purposes, why couldn't
legacy firmware, too?

> Without EFI dom0 should be fine in overwriting (some?) of the data in
> E820_ACPI regions once it's finished with all ACPI processing, as a
> region of type E820_ACPI is reclaimable and Xen won't try to access it
> once handled to dom0.
> 
>> The modification
>> I'm making is solely towards Xen's internal memory management. I'm
>> really having a hard time seeing how commenting on expected Dom0
>> behavior would fit here
> 
> The type in the e820 memory map also gets propagated to dom0 in the
> machine memory map hypercall, so it can have effect outside of Xen
> itself.

If used beyond the very limited intended purposes, yes.

>> (leaving aside that I'm still puzzled by both
>> you and Andrew thinking that there's any whatsoever remote indication
>> anywhere that Dom0 recycling E820_ACPI could be an okay thing in a PV
>> Dom0 kernel). The more that marking EfiACPIReclaimMemory anything
>> other than E820_ACPI might, as iirc you did say yourself, also confuse
>> e.g. the ACPI subsystem of Dom0's kernel.
> 
> Indeed.  There's no good way to convert a region of type
> EfiACPIReclaimMemory that has the EFI_MEMORY_RUNTIME attribute set, as
> there's no mapping to an e820 type.
> 
> One of the quirks of trying to retrofit an EFI memory map into e820
> format.
> 
>> But well, would extending that sentence to "While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
>> to do so, bypassing Xen's memory management), hence that type's
>> handling can be left alone" satisfy your request?
> 
> I think that would indeed make it clearer.

Okay, I'll make the adjustment then and submit a v2. This will now need
an ack also by Henry anyway.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 15:58:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 15:58:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415667.660289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkJs-0002wu-Rn; Tue, 04 Oct 2022 15:58:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415667.660289; Tue, 04 Oct 2022 15:58:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkJs-0002wn-P7; Tue, 04 Oct 2022 15:58:56 +0000
Received: by outflank-mailman (input) for mailman id 415667;
 Tue, 04 Oct 2022 15:58:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofkJs-0002wh-16
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 15:58:56 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2044.outbound.protection.outlook.com [40.107.22.44])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 72a243a3-43fd-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 17:58:55 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB8445.eurprd04.prod.outlook.com (2603:10a6:10:2cf::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Tue, 4 Oct
 2022 15:58:52 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 15:58:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72a243a3-43fd-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZpTt5voV+nALZm0Exe8CT+CzAQFaQf4sxrCuQBoccQD+qK/VKJ87eqLaUPmQ9cnXQZn1nx31gC99TWcRCeX+8Mo7Saobo6dONc8+dIRGJo/sF1lithCdpguNWxi8W515kvhe9JsRztHyv3CITwtz4uEixdsqz6UUEret+7CxoE+RVCmTwWdviBuX4L8EW0KcD30SbdcjkqtU5n4e6BTW0d0Lpr5h2RpeV352Y7Z0z8squlUhyrExKUrqaos0MTDoSpCbIGxP0PdxgBJALqE/FBP7Trsi+2s9X1D+v3yPbeTILZF0L0Xe/hlvLXHxMRFOpyDBXJMXiAYAwA4nsaYh/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o/hKQCZfc6IPdqQX0GfU4K8iCst/ETj/mfZO+u4QQkI=;
 b=gRUGyBZDDPYbL4QIz7ZTPhjhMv9NentxgAN3TOtSBL1vSFBKQb0tr9QpU+gUdoFoOg0M/Jiazjv/NSET/S9vg9wTIV9ZFAM6oNUxtV/THBa46LmUCtqn/U9s93uUOq7z3+zc7lFJFl4hE4wyv5oTqIXdZFnA57xEjVxQszfedGkrwKjEPhB+Xfsf+YvaunjaITV7SegKrksSFpadp4mRKBIhkCLV35oliOy2+b2V0UjLVxey69WZ8TDhPyi8dE512DgkgOKqP4Whl5UXrbZdJAqICFBPhuNoi8jpHHaB5MJ4Gkrv9gbwO0BfA+o2r0M+4MP7O7hBgP/zJem3I7syvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o/hKQCZfc6IPdqQX0GfU4K8iCst/ETj/mfZO+u4QQkI=;
 b=F6dRbW3kE9lQa9Hns486JO/6LwB6VshSNKbxTmgkiH7M0Kf4ciYOy/Cuw0sy52fHlYxV5OM1VQvJe4eFa2jADUQ//2MvwvZddQ9Bf5nWiqyF4OyEMTFcCU6GH7d4htcoRX33xOXwv6yHx+9IWIsog7a0LCgDR3FjO4fYLMaZ9D3voO+QCjcZhhn5rcuGyRua08GTZJcM0EssHzepZ43MSACIIy5GHLyUsza7D+J9l6peeo7zInLH4OPFde+INjw4p1RwwOPT0s9BkrJWnmIu+PC3Uimiss0yWzVeymT6LyedA1bM3WnKwuaWpzI9Bsq2MBwRzrn7/XOdc4VB6bLhtQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
Date: Tue, 4 Oct 2022 17:58:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall
 <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8445:EE_
X-MS-Office365-Filtering-Correlation-Id: 6ab91742-78ba-4d6b-3964-08daa621557f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UFqOfDudodZfTaMTb2gXNgAD80hgV9Sjf9xUv7cX4vROe1DLJqNJANvrGAicDmLcQxNcyfuQUOgadPv5neCvNSuX/egodFouiANyBQALqVhvP3hhvVJoqyxTCZ3M7b97QZumtPKrY8CV4/vGdzqLKWZVpsaxLoA7oACAA1d2Q39X/NCHdWdCYaLRZ5qTJveRAdGPCBdsHF90O9rI+rLQmZstUgRh2Csf4V3+I1yvrPXnMYrTGwOqxgcVyFPwQdYtVJT0XUQI218Gj3G9J6vEUIEYVZ4tDgo0WTRFvUJ5Y0ZciYUwBCoEAmqOGXu7sXcgv8KEHCQ8yYOeSOO7SumI+ijTHAJXm+QZd6ahUC6tDlndR4I4O+lBjrz/Lrb4nsX+wATB7v9AlPj6/K3sqsR/C9xIR2T+sQ+PV39h/7OvC+yRJSSv5PQklqmfp5XbzxWIa5OHsuVcm9AUyJ+7zJs86qGYbrND1JlUt/YSM1qYKuIju4h/PgFH5vnB5XeVBM+0Ny5z6e04MR/5vdInRAsvP4JXExw1lqjz7/DPQyKJgJtP55zLttlmG8HH7QRmRE1BNAqwNgkQ9gbkg9f0ZKX0D8DcJ0eFtCwa1AqQj8IVyMDz5L7+FXcTOvk0RDjwjcJE+2s2l61fqSEarBp6pbD5ovM4O0AuARfD/0KrthHHjdvLiFscphky91TTDTJ+AdTY9C7YorFbJmn1au6B+oyAQXq58jEteE3JN6l3sz7lXKGCkGJ1fNAyVEJO9csVGcZwG3wTw+XYRLo5DJAp9yiT6vkvWy90yBj3++faL26P4ZU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(31686004)(26005)(36756003)(8676002)(41300700001)(5660300002)(4326008)(6506007)(86362001)(31696002)(38100700002)(2906002)(2616005)(186003)(83380400001)(8936002)(478600001)(66476007)(6486002)(6512007)(110136005)(53546011)(316002)(54906003)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RVNVUTE0MnFUb1BlQkNjT1kxaVRqSkZsRzlQeDFRbHJDeVZadVNKTGdPWWxy?=
 =?utf-8?B?dHhlZzJ0b1NhWUhXS1lKUk9BNGVSbEV3dmM4UXkxbnVCNVFCS1VvYXJGS1Bk?=
 =?utf-8?B?UVFVY1V6aDU2RWk2UkE5dUpxZytmUUd2bTZlVldWdlB2aDhkbEFpMHRxZ0VZ?=
 =?utf-8?B?OFhKU2JUelNvUGdDd0VLZWtJbmNxcnVkejNybVZLSUNWWkE1eDNkNEl0Nm5p?=
 =?utf-8?B?R0N2cmUrQVpvMmFMWlZtVmxIWGU1YUtQY1pHV3N2WFA2YWt2TGlhSHFza0Rv?=
 =?utf-8?B?VVNQS25TWk1BWFJpbUwrazVUU054ZER5c1NVZmR0VWhtWGZsbkhRTWd5L0pD?=
 =?utf-8?B?TFZ0aW9PSk9ydFk3QkRya2xtWTducjAzdm5mRVFUck9ZVFlLTjdtaGc4c1Y5?=
 =?utf-8?B?MVVCYnR0THZGMjNIZTIrTC9kNnJPb01DQS8vSG1BM3ZZcm1SeDBSRXRRcm1l?=
 =?utf-8?B?ZXZSQkJpalR1djU1a3JmeGVvUzRDVHNJRkVhbU5qTWNNckF0VXFvbWtmVjg2?=
 =?utf-8?B?cXpFVi9rWlNvVXlkRWFjdGdPYUhDYlZ2eisrdUxMNjQyblNOeC9COUJNWWxI?=
 =?utf-8?B?UVdEb3lSdDdJbUpvWUR1TC9RWkJFbCtCalJWREZIeGxOT2FPRnVETFJUR1Uz?=
 =?utf-8?B?RnZFcENoMVY2ZzJjTm5LZDdqZXhWT25Rc3JlUWRUbEkrUHUveDUyTHRqNUNk?=
 =?utf-8?B?ek5PUjIvbks4MjZmR2tnNE1NSlE0Z2lYQllQMjVqNHhHcXJnWkVFOHhVbnNG?=
 =?utf-8?B?VXZ3Nk9rM1RsVmZqVkhoMlhQejhLamlFSG1QR251b0g4cFBFUHlqWnF6aytp?=
 =?utf-8?B?SzZxZEF2ZFRsVUZxRVZERkZBNDQ2K25MREdMbnNDV0dHUUhNSDBoL0tpS2ln?=
 =?utf-8?B?bnFtOU43SkdXRkh0Z2E1TytubXZMY2I4a21LSGFlajI2bm9HdTU0eS91NGpw?=
 =?utf-8?B?cGhhbmF4blQ3bnFjdmVyTWZuTEt0eSt0RnpmZWNGYzRNUFUzaGJ6WG10aVBB?=
 =?utf-8?B?NmhWbWJJUG1EaVU1MWMxL1kyUStEVjA2a1pQVjFIMnh3ak1zRGZ2SkZiV0NJ?=
 =?utf-8?B?a1FOOW1RcGl5OStWODd2MWEwM0NtUG9kcnJnWlpDcGI4ejFtbVdKakZPNk9W?=
 =?utf-8?B?VjBBbHRPOTFTQ2JNRnN1TVNPMW1jUGdhV2RDTnVCaThsVGc0NklFV1lWMWVk?=
 =?utf-8?B?MGlpZUpneVMrNU5EVDJ2TEdTc0ZtdWVmaks2UWlPYXFaL3gydlZKbjVXcDI3?=
 =?utf-8?B?cWJlSUt1UkpMOHZ4WG5FcnN5MEx0WGd2Z2lVK1JZM25UbHk4YkdpbU1WdW9k?=
 =?utf-8?B?VDNSNVAvRWRlZlJ1K0dhNG5KZUljdkNsNXNNSWk5U1ZNUTlsOXBlV0UrTVNQ?=
 =?utf-8?B?QjI5c200TTlSYk1DUUlGRFZOQkhIWUFBb2F6aTIyeUxmUFljOXV5cUdWWHI2?=
 =?utf-8?B?VVo0d3BEQUFHOXc1cERsVjUwTUhmM0N1cTdFODdwL01YTy9FTE13aEYycEVD?=
 =?utf-8?B?VXkxMkZPcm03Sk1JU01jLzg5L3Uwb3UyNVhlK0lHQkhiZk1hZ00yOHBaZjRm?=
 =?utf-8?B?ZWhkTWpaa3ZsYVh2RFU0UkNqWU84NjN6d1NQamxtS2RhZGt3NnRtc2NBOFpH?=
 =?utf-8?B?UnlFRys0WHVHQlV3TTRZWXJVb2MzRUl5STh0eTREVSt6ZGdtY3A5QjRhZi84?=
 =?utf-8?B?MHB2Nm1qUUVqMFJsMUpOQmRDT0NpSmcvOGkrTFZ0N0dSdlU3MStWdGVZbWV6?=
 =?utf-8?B?NjJNLzMxZGhiRWFlVlVGM0VQcE83bk9MN3cxcnBXL3pRT2NnNVdDYVJCNy9o?=
 =?utf-8?B?OWtRMEpPd2hzTW5adklvTUZSUUZvWFFnYVNWcFJyN3IvaXo0WGpJRnZWK2dy?=
 =?utf-8?B?b3Y3NUlldTZqbFBjdXpaNWZ5QzRsVU96VjJNcW1MNE1oc0o2MUN2N0lqL2pT?=
 =?utf-8?B?VEFvOW41aEJ2MWpuK3BBUzdjRFFFd1dKVy80a0NRYkR2NjhDL1l6bG5BS3dj?=
 =?utf-8?B?SnhjdDJBTk1hOUd5T1FBRzYxS2x0eWsweU5ncFp6ZTdBZWhmL2JIem81aFZ3?=
 =?utf-8?B?bmdzZzV4SXg4MXFCWGtwWGlKcWdjeGhFL0FnU2RBWGROeFRkcUhZdlhGQm8z?=
 =?utf-8?Q?h70Dfot/TVwxZu7OSfbW+sECR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab91742-78ba-4d6b-3964-08daa621557f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 15:58:52.6129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GRCq+kD7v22RMQY2hNHOyj92TOyrqidMuR61Zc5s2ahRZZVGFAEJX21qEkasoV8qZK91kxat25HLhe+XSPxROA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8445

On 30.09.2022 14:51, Bertrand Marquis wrote:
>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>> higher priority than the type of the range. To avoid accessing memory at
>> runtime which was re-used for other purposes, make
>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there and hence that type's handling can be left alone.
>>
>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm

Thanks. However ...

>> ---
>> Partly RFC for Arm, for two reasons:
>>
>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>> For one like on x86 such ranges would likely better be retained, as Dom0
>> may (will?) have a need to look at tables placed there. Plus converting
>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>> me as well. I'd be inclined to make the latter adjustment right here
>> (while the other change probably would better be separate, if there
>> aren't actually reasons for the present behavior).

... any views on this WB aspect at least (also Stefano or Julien)? Would be
good to know before I send v2.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:00:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:00:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415675.660300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkLQ-0004qe-8W; Tue, 04 Oct 2022 16:00:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415675.660300; Tue, 04 Oct 2022 16:00:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkLQ-0004qX-5J; Tue, 04 Oct 2022 16:00:32 +0000
Received: by outflank-mailman (input) for mailman id 415675;
 Tue, 04 Oct 2022 16:00:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofkLO-0004qJ-MU; Tue, 04 Oct 2022 16:00:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofkLO-0006cy-Ic; Tue, 04 Oct 2022 16:00:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofkLN-00054Q-RG; Tue, 04 Oct 2022 16:00:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofkLN-0004EV-P5; Tue, 04 Oct 2022 16:00:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=i6rOsANI5CHG7gY7ottSufXMzYyQyg0bWqNcjdCYhrM=; b=gMrFPoF9D7KGUsXM1OrX7aUT/v
	npdy+1AijkgxnOB+9ZE9iNdNLMx2IV10PW7xM5n3Qoe7v1igRdK/Mlnw00GT82M4wr9R9iCJccb4L
	RnFcBonQ4F1jWKEsKiKSgYGqUx6eKJOV9oBZUF7he3PjPTK/9NBDvHFkdpA1uyOYYgUI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173414-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173414: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=725737e7c21d2d25a4312c2aaa82a52bd03e3126
X-Osstest-Versions-That:
    linux=26b84401da8458c5cbd6818d5732f7bbb84124a2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 16:00:29 +0000

flight 173414 linux-linus real [real]
flight 173417 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173414/
http://logs.test-lab.xenproject.org/osstest/logs/173417/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 173417-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173411
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173411
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173411
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173411
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173411
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173411
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173411
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173411
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                725737e7c21d2d25a4312c2aaa82a52bd03e3126
baseline version:
 linux                26b84401da8458c5cbd6818d5732f7bbb84124a2

Last test of basis   173411  2022-10-04 01:09:43 Z    0 days
Testing same since   173414  2022-10-04 08:14:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "J. R. Okajima" <hooanon05g@gmail.com>
  Al Viro <viro@zeniv.linux.org.uk>
  Alexander Aring <aahringo@redhat.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christian Brauner <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Chuck Lever <chuck.lever@oracle.com>
  Dai Ngo <dai.ngo@oracle.com>
  David Teigland <teigland@redhat.com>
  Deming Wang <wangdeming@inspur.com>
  Eric Biggers <ebiggers@google.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Igor Mammedov <imammedo@redhat.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jeff Layton <jlayton@kernel.org>
  Jia Zhu <zhujia.zj@bytedance.com>
  Jingbo Xu <jefflexu@linux.alibaba.com>
  Jinpeng Cui <cui.jinpeng2@zte.com.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  NeilBrown <neilb@suse.de>
  OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
  Olga Kornievskaia <kolga@netapp.com>
  Theodore Ts'o <tytso@mit.edu>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Yue Hu <huyue2@coolpad.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   26b84401da84..725737e7c21d  725737e7c21d2d25a4312c2aaa82a52bd03e3126 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:06:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:06:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415688.660311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkRQ-0005aL-2K; Tue, 04 Oct 2022 16:06:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415688.660311; Tue, 04 Oct 2022 16:06:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkRP-0005aE-VW; Tue, 04 Oct 2022 16:06:43 +0000
Received: by outflank-mailman (input) for mailman id 415688;
 Tue, 04 Oct 2022 16:06:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hw9g=2F=gmail.com=colin.i.king@srs-se1.protection.inumbo.net>)
 id 1ofkRO-0005a8-AF
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:06:42 +0000
Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com
 [2a00:1450:4864:20::329])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88927368-43fe-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 18:06:41 +0200 (CEST)
Received: by mail-wm1-x329.google.com with SMTP id ay36so9222231wmb.0
 for <xen-devel@lists.xenproject.org>; Tue, 04 Oct 2022 09:06:41 -0700 (PDT)
Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net.
 [80.193.200.194]) by smtp.gmail.com with ESMTPSA id
 j14-20020a5d464e000000b0022e38c93195sm6420254wrs.34.2022.10.04.09.06.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 04 Oct 2022 09:06:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88927368-43fe-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date;
        bh=JzOBFqoHQk5sbb88IXGYAWyLYnuSbnvMiffX2ln7ZwY=;
        b=Rj+l6U3nNSIFywr93jeVy56CN03wRC/7817IVultzoSms9L4uKB4b9B3NUnPUdvHNc
         TAG6ZDXEbSAui9n/gh8ZI28TiiieT5QyzZVc8StuRCmy/LkNZ7NrGxGhc8i0G7BtGWB0
         CdOet/pA8zkgMSUZEPq8GL9aaN5873fNruP3i1cTkZemSNUn8kLZJB60Zc+LgQcbHxqe
         5oAyQeHqyQ9Pz3Ujnw6+14hSRXfo9auNVrnjUOtFr6BbwwcPTeTS8zZgkXjcx4r67zoz
         9DvuNUA4JVHiAKgutltgWA0zE/0lXbQrN2ayZ7/xjc2/Wr8wTkdRzhU4QMg5+FJjr4ZD
         +7Hw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date;
        bh=JzOBFqoHQk5sbb88IXGYAWyLYnuSbnvMiffX2ln7ZwY=;
        b=tdQHEUhLTobRDgPlGL1vAgP4hzI4nx+aXKOU9y9zZiASs3J9MnTr4ViU6Ej2f/N/Os
         k0EKpQ8Ip6xSUunGxpdFlINr5WyhFLna3T4ljgufTdNxqIYgKAcUwh6RzrqSnfcmMyPD
         blJDZUDXfKYatfMle8CLB+Y7KFyRrW17CfSDUxm8EcRi58DVmizHFuAm7ia0os3x8B65
         DxGTpj29AW9WAxQRdTafgJM68WQ4UkfehbnNqwW76yzeFb5R/jvONmmuJfWjA4+phOKc
         UVLhG8uAbHL42cJ3gGUpVMDp68Un+rvG26oQ6LssPaDa5558Yg7Givy71qf7EFKF3k3l
         InJQ==
X-Gm-Message-State: ACrzQf0dmnxehS7NoUAkxygQzXh7/3yf9RW0S5eNM4nDLyoLTZ2r/3i1
	qBD6UvO2O13yWpYTRsaskZU=
X-Google-Smtp-Source: AMsMyM6gRgaGAOCdkIrXOwLoGfT92j7KLM0C3wI+tKqR71EzYZ/Ko/ncz8DXmsZlQVl7c3hMCAbu3g==
X-Received: by 2002:a7b:c4c2:0:b0:3b4:fdc4:6df9 with SMTP id g2-20020a7bc4c2000000b003b4fdc46df9mr332508wmk.123.1664899600743;
        Tue, 04 Oct 2022 09:06:40 -0700 (PDT)
From: Colin Ian King <colin.i.king@gmail.com>
To: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] xen/xenbus: Fix spelling mistake "hardward" -> "hardware"
Date: Tue,  4 Oct 2022 17:06:39 +0100
Message-Id: <20221004160639.154421-1-colin.i.king@gmail.com>
X-Mailer: git-send-email 2.37.1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

There is a spelling mistake in the module description. Fix it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/xen/xen-pciback/xenbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index bde63ef677b8..d171091eec12 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -31,7 +31,7 @@ MODULE_PARM_DESC(passthrough,
 	"   frontend (for example, a device at 06:01.b will still appear at\n"\
 	"   06:01.b to the frontend). This is similar to how Xen 2.0.x\n"\
 	"   exposed PCI devices to its driver domains. This may be required\n"\
-	"   for drivers which depend on finding their hardward in certain\n"\
+	"   for drivers which depend on finding their hardware in certain\n"\
 	"   bus/slot locations.");
 
 static struct xen_pcibk_device *alloc_pdev(struct xenbus_device *xdev)
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:08:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:08:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415694.660322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkT3-00067x-CU; Tue, 04 Oct 2022 16:08:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415694.660322; Tue, 04 Oct 2022 16:08:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkT3-00067q-9h; Tue, 04 Oct 2022 16:08:25 +0000
Received: by outflank-mailman (input) for mailman id 415694;
 Tue, 04 Oct 2022 16:08:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+z6g=2F=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ofkT1-00067g-8m
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:08:23 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c403796d-43fe-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 18:08:22 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id BDD62CE10EC;
 Tue,  4 Oct 2022 16:08:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 799C9C433C1;
 Tue,  4 Oct 2022 16:08:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c403796d-43fe-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1664899695;
	bh=Q9+9JGpyxi1fLq3uWb5W7vWerwlabA2Ce6TBCNzr9nY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=GxZAPorQjmt6cdaELQcGvGGyNTW7uS6da91pp4YrMAbEx6qlR85yHy8NC8N0xm0pm
	 r3KoAIIBQPDYI9o/BeVGoKIdRqoKURJMprl5P1CrzyVfa3JLPWih+Ab7sTVGmlvnaI
	 CIQc3yrGnpZYDVIyNm7cMsh/ZfOaxxBOwDQaScjz2CQOOn7/a13AyTuTUOZnDjJHkY
	 o1traqO5+x1DYDzxQe4DGsyv9dk+TArNvtIbdnt7CAgp1kGM+LlQ6n6dDyhL/b6G2X
	 YAqEuzAbf0Z3tKY67QZHalRogaRiaX5MfUzEBlq8ZcuFzAa9yrksq/TSzAzp6KRp9v
	 XWwbL0F2S06Lg==
Date: Tue, 4 Oct 2022 09:08:12 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: dega kiran <degakiran05@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, ulien Grall <julien@xen.org>
Subject: Re: Free Rtos porting on XEN
In-Reply-To: <CADY+DPLf10UtUWE7Y9zZvN0NRFkGtV7ah3dg8t4wYWrF=8R2LQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210040908020.3073309@ubuntu-linux-20-04-desktop>
References: <CADY+DPLf10UtUWE7Y9zZvN0NRFkGtV7ah3dg8t4wYWrF=8R2LQ@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1271568247-1664899429=:3073309"
Content-ID: <alpine.DEB.2.22.394.2210040903570.3073309@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1271568247-1664899429=:3073309
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210040903571.3073309@ubuntu-linux-20-04-desktop>

Hi Dega,

AMD/Xilinx has a FreeRTOS port that works on Xen (at least on Xilinx
boards). The code is public and open source although typically to build
it you'd need the Vitis SDK.

The code itself is available here:
https://github.com/Xilinx/embeddedsw
https://github.com/Xilinx/embeddedsw/tree/master/ThirdParty/bsp/freertos10_xilinx

Also see:
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842141/FreeRTOS

I hope this helps.

Cheers,

Stefano

On Tue, 4 Oct 2022, dega kiran wrote:
> Hi ,
> I am trying to port FREERtos on XEN . But not getting any concrete information for porting.
> 
> I am following https://github.com/GaloisInc/FreeRTOS-Xen
> 
> but getting a lot of errors.
> 
> Please Let me know how to follow the porting process.
> 
> 
> Thank you,
> Dega.
> 
> 
> 
--8323329-1271568247-1664899429=:3073309--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:08:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:08:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415696.660333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkTJ-0006VM-Jc; Tue, 04 Oct 2022 16:08:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415696.660333; Tue, 04 Oct 2022 16:08:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkTJ-0006VF-Go; Tue, 04 Oct 2022 16:08:41 +0000
Received: by outflank-mailman (input) for mailman id 415696;
 Tue, 04 Oct 2022 16:08:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YyPd=2F=citrix.com=prvs=269269faf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ofkTI-0006Sk-5J
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:08:40 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cdb6241d-43fe-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 18:08:38 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdb6241d-43fe-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664899718;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=Hrn5m8BVzCYhqL7ggmk787e3RGFAR22H9oUe1OsxCeU=;
  b=e2WWaBpQ2seCo45SpT7z+aQzB7YrugPMRtweLCBOk5+Yix2CPCt/4WVp
   nCsowqYQ6bW9Ale4X459drXvSggV8CRVhv5xsD2pKQlVJSb9EOklwcKQb
   cefMCnS3lU7pP4ZROcN4zZBgpcW9gxty6GtAoGXQj5zgaq0BiEb/o0nBh
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 84478270
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3PMpLKpekRzX/TJEjGBpCM5qM9heBmLPZRIvgKrLsJaIsI4StFCzt
 garIBnVbKqJYmqhfYh0OdyyoE5Q65+Ey99gSgZtrC1kFnwU9puZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgT4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz
 dcEdRQXSBO6o82V66K+F9hJpucJFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP
 YxDM2MpNUmeJU0UUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0FwhrH9
 jiZpwwVBDkTD+G/+AjGq0nrj8HFuTvlfsENHZGno6sCbFq7mTVIVUx+uUGAidm0jFSvHe1WL
 UM88zAr66M18SSDS9DnWhSirX2svxgCWsFRGek39AGMzKXP5w+TQGMDS1ZpZNEjtec3QyIrz
 V6Dm971BT1pv6aRQHjb/bCRxRuiNC5QIWIcaCssSQoe/8KlsIw1lgjITNtoDOiylNKdMRPaz
 i2OrSM+r64OlsNN3KK+lXjYhxq8q56PSRQ6jjg7RUr8sFk/PtT8IdX1tx6Ltp6sMbp1UHG5l
 2RZv9K479kqIrKmhCnQccAtP5uQsqPt3CLnvXZjGJwo9jKI8nGlfJxN7DwWGHqFIvroaheyP
 haN5Fo5CIt7eSLzMPQpO97Z59ECl/CIKDjzahzDgjOiiLBVfRTPwixhbFX4M4vFwBl1yvFX1
 Xt2nK+R4Zcm5UZPlmPeqwQ1i+VDKsUCKYT7GvjGI+yPi+b2WZJsYe5t3KGyRu449riYhw7e7
 sxSMcCHoz0GDrOiMnONqt5Dcw5VRZTeOXwRg5M/SwJ+ClA+RDFJ5wH5mNvNhLCJb4wKz7yVr
 xlRq2dTyUblhG2vFDhmnktLMeq3NauTWFphYkTAy370hCV4CWtuhY9DH6YKkU4PrbcylaEuH
 6RaEyhCa9wWIgn6F/0mRcGVhORfmN6D2Wpi4wLNjOADQqNd
IronPort-HdrOrdr: A9a23:Q/iyV6jWy7bGyOqhjXJnfMWbrXBQXtYji2hC6mlwRA09TySZ//
 rBoB19726StN9xYgBFpTnuAsm9qB/nmaKdgrNhWItKPjOW21dARbsKheCJrgEIcxeOkNK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="84478270"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Henry Wang
	<Henry.Wang@arm.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>
Subject: [PATCH for-4.17 0/2] x86: Activate DOITM
Date: Tue, 4 Oct 2022 17:08:08 +0100
Message-ID: <20221004160810.25364-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Slightly RFC.  I'm a little uncertain about putting doitm into cpuid= but it's
the least bad option I can think of.

Andrew Cooper (2):
  x86/cpuid: Infrastructure to support pseudo feature identifiers
  x86: Activate Data Operand Invariant Timing Mode by default

 xen/arch/x86/cpu/common.c            | 29 +++++++++++++++++++++++++++++
 xen/arch/x86/cpuid.c                 | 22 ++++++++++++++++++----
 xen/arch/x86/include/asm/processor.h |  2 ++
 xen/tools/gen-cpuid.py               | 15 +++++++++++++++
 4 files changed, 64 insertions(+), 4 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:08:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:08:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415697.660339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkTK-0006Yv-00; Tue, 04 Oct 2022 16:08:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415697.660339; Tue, 04 Oct 2022 16:08:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkTJ-0006YC-P5; Tue, 04 Oct 2022 16:08:41 +0000
Received: by outflank-mailman (input) for mailman id 415697;
 Tue, 04 Oct 2022 16:08:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YyPd=2F=citrix.com=prvs=269269faf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ofkTJ-0006Sk-1t
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:08:41 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf0838a7-43fe-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 18:08:39 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf0838a7-43fe-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664899719;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=JzNhcqciVpnoKEV6ma2MCgYp+/vDnI0tLk69rJMGEXk=;
  b=O++ivkWVztbeKBFM3g57wUigkZeEcKss7yF+qlpPzYw8442LQjBXzIx9
   S1L80Tv1sUt4GHLeSVSBqOQSuxmDsPba8s+6iPpl0k+OJ0aFQXV7qSgb6
   dAjqTnEvPT11k2T1vpDMhGq43HzCXCON+z5+FQkctjEQYpvs9m6pRe1hx
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 84478271
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Q+wl+qvUysOPWi3eBaCGPFMz/efnVIFeMUV32f8akzHdYApBsoF/q
 tZmKWnSaPiPNjf9KdBxOoXlphgBvJHcy9RhT1NkqCk9EixD+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPagX5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkl23
 uBFDCorbSmnqMGd0Lfme8xMpe4aeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI
 ZBDMHw2MUqGM0Yn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZUJwhnI/
 D2fl4j/KgwbZdOV7jqkzimlgbLuniDqd68dKrLto5aGh3XMnzdOWXX6T2CTgfS/kF/4ZNtZJ
 GQd4C9opq83nGSuR8P4Vge1o1aFuAAdQNtaF+Am6ACLxbHQ6gzfDW8BJhZNZdknnM4wWz0x1
 1WNks/pBDpgq7mcQzSW8bL8hSO/P20ZIHEPYQcATBAZ+J/zrYcrlBXNQ91/VqmvgbXdOxv93
 jSLpygWnKgIgIgA0KDT1U/DqyKhoN7OVAFd2+nMdjv7tEUjPtfjPtH2rwiAhRpdEGqHZmGqo
 CUgge6d1cQhLrqdkXG8ZcUuNoj8sp5pLwbgqVJoGpAg8RGk9HiiYZ1c7VlCGat5DioXUWS3O
 RGO4Gu98LcWZSL3NvEvP+pdHuxwlcDd+cLZuuc4hzakSrx4b0e58S5nfiZ8NEi9wRF3wcnT1
 Xp2GPtA7Er264w9lVJapM9Hi9fHIxzSIkuMLa0XNzz9jdKjiIe9EN/pymemYOEj97+jqw7I6
 dtZPMbi40wBDrGuOHOMod5Ncw9iwZ0H6Xfe9KRqmhOreFI6SAnN9deIqV/eR2CVt/sMzbqZl
 p1MckRZ1ED+lRX6FOl+UVg6MeuHYHqKhShkVcDaFQr3hiNLjEfGxPt3SqbbipF+r707kqQkE
 qZtlgfpKq0ndwkrMg81NfHVxLGOvjzw7e5SF0JJuAQCQqM=
IronPort-HdrOrdr: A9a23:2VHCt6uEgNy0BHGMmJ8lGVl77skDTNV00zEX/kB9WHVpmszxra
 GTdZMgpGfJYVcqKQgdcL+7Scq9qB/nmqKdpLNhWYtKPzOW3ldATrsSj7cKqgeIc0aVm4JgPO
 VbAs9D4bXLfCNHZK3BgDVQfexP/DD+ytHMudvj
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="84478271"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Henry Wang
	<Henry.Wang@arm.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>
Subject: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature identifiers
Date: Tue, 4 Oct 2022 17:08:09 +0100
Message-ID: <20221004160810.25364-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221004160810.25364-1-andrew.cooper3@citrix.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

A future change will want a cpuid-like identifier which doesn't have a mapping
to a feature bit.

 * Pass the feature name into the parse callback.
 * Exclude a feature value of ~0u from falling into the general set/clear bit
   paths.
 * In gen-cpuid.py, insert a placeholder to collect all the pseudo feature
   names.

No practical change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Henry Wang <Henry.Wang@arm.com>
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
CC: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 xen/arch/x86/cpuid.c   | 17 +++++++++++++----
 xen/tools/gen-cpuid.py | 13 +++++++++++++
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 822f9ace1087..112ee63a9449 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -39,7 +39,8 @@ static const struct feature_name {
  * function pointer call in the middle of the loop.
  */
 static int __init always_inline parse_cpuid(
-    const char *s, void (*callback)(unsigned int feat, bool val))
+    const char *s, void (*callback)(const char *name,
+                                    unsigned int feat, bool val))
 {
     const char *ss;
     int val, rc = 0;
@@ -81,7 +82,7 @@ static int __init always_inline parse_cpuid(
 
             if ( (val = parse_boolean(mid->name, s, ss)) >= 0 )
             {
-                callback(mid->bit, val);
+                callback(mid->name, mid->bit, val);
                 mid = NULL;
             }
 
@@ -101,8 +102,12 @@ static int __init always_inline parse_cpuid(
     return rc;
 }
 
-static void __init cf_check _parse_xen_cpuid(unsigned int feat, bool val)
+static void __init cf_check _parse_xen_cpuid(
+    const char *name, unsigned int feat, bool val)
 {
+    if ( unlikely(feat == ~0u) )
+        return;
+
     if ( !val )
         setup_clear_cpu_cap(feat);
     else if ( feat == X86_FEATURE_RDRAND &&
@@ -120,8 +125,12 @@ static bool __initdata dom0_cpuid_cmdline;
 static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
 static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
 
-static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val)
+static void __init cf_check _parse_dom0_cpuid(
+    const char *name, unsigned int feat, bool val)
 {
+    if ( unlikely(feat == ~0u) )
+        return;
+
     __set_bit  (feat, val ? dom0_enable_feat  : dom0_disable_feat);
     __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat );
 }
diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py
index 4f7c8d78cce7..f3045b3bfd36 100755
--- a/xen/tools/gen-cpuid.py
+++ b/xen/tools/gen-cpuid.py
@@ -297,6 +297,19 @@ def crunch_numbers(state):
         RTM: [TSXLDTRK],
     }
 
+    #
+    # Pseudo feature names.  These don't map to a feature bit, but are
+    # inserted into the values dictionary so they can be parsed and handled
+    # specially
+    #
+    pseduo_names = (
+    )
+
+    for n in pseduo_names:
+        if n in state.values:
+            raise Fail("Pseduo feature name %s aliases real feature" % (n, ))
+        state.values[n] = 0xffffffff
+
     deep_features = tuple(sorted(deps.keys()))
     state.deep_deps = {}
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:08:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:08:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415702.660355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkTU-0007EH-3S; Tue, 04 Oct 2022 16:08:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415702.660355; Tue, 04 Oct 2022 16:08:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkTU-0007E6-0Z; Tue, 04 Oct 2022 16:08:52 +0000
Received: by outflank-mailman (input) for mailman id 415702;
 Tue, 04 Oct 2022 16:08:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YyPd=2F=citrix.com=prvs=269269faf=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ofkTS-00067g-8I
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:08:50 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3de8937-43fe-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 18:08:48 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3de8937-43fe-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664899728;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=JBROCaFJ+EpzPToOVVp3gIBCu4A3D791xZNcgjLwDS4=;
  b=IrPP8bLbJxnpqgEDOPzqh+ZTdrezlccb9QB3182MoC55RRmn0miofHNl
   iIsReyvSE2lY8kBgSmmRv8RfYjkP3/wClAzrMQcBYixVizVbUc0mNhScx
   KKtK4oVPqxE7Ehu5X1K6IucS8KwNHh5+Tyquw/mwSKECVfDiiS36Zo8+i
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81081088
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1Li0NqmOm0B0AHdQVZ2OwLLo5gxWJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKUGiAOqmDNjSke9wkOdy1p0oFup7Wn9dhSwU4pCkxHyMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRmOagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfCzBK1
 PAaGS03RQnSpvOc+pWja+NLr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP
 ZNfMGcxKkSbC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TaHJ0Fxx7I9
 goq+UzSRTQQLdCE8QO842qBid3rwAT4RogNQejQGvlC3wTImz175ActfXu2p+OozHG3Xd13I
 lYRvCEpqMAa8UWxS9DnUh6QoXiavwUdUd5dD+077g6WzqPepQ2eAwAsQjNEafQnstE3Xj0g0
 lKVn9LvCidrubfTQnWYnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdpv/fFCz0w
 juKhDMjnLhVhskOv42k+XjXjjTqoYLGJjPZ/S2OADjjtFkgItf4Ocr4sjA38MqsMq6TH12gs
 Ho1hvK19bEvHLu3szSsSsIkSeTBC+m+DBXQhltmHp8E/jur+mK+cY043AySNHuFIe5fJ2a3P
 Ra7VRd5ocYKYSD0NfMfj5eZUZxC8ET2KTjyuhk4hPJqa4M5SgKI9ToGiaW4jzG0yxhEfU3S1
 P6mnSeQ4ZQyU/0PINmeHb11PVoXKscWmgvuqWjTlUjP7FZnTCf9pU05GFWPdPsly6iPvR/Y9
 d1SX+PTlUsDALekOXmHr9BMRbzvEZTcLc+eliCqXrTbfloO9J8JUpc9Po/Ni6Q6xv8Ix48kD
 1m2W1NCyUqXuEAr3T6iMyk7AI4DqL4l8hrXywRwYgvzs5XiCK7zhJoim2wfJOJ2rLM5naMrJ
 xTHEu3Zaslypv3802x1RfHAQEZKL3xHWSrm0/KZXQUC
IronPort-HdrOrdr: A9a23:vZ/Yj6Hy/eQKcB+2pLqE0seALOsnbusQ8zAXP0AYc31om6uj5r
 iTdZUgpGbJYVkqKRIdcLy7V5VoBEmskaKdgrNhW4tKPjOW2ldARbsKheCJrlHd8m/Fh4lgPM
 9bAtND4bbLbWSS4/yV3ODBKadE/OW6
X-IronPort-AV: E=Sophos;i="5.95,158,1661832000"; 
   d="scan'208";a="81081088"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Henry Wang
	<Henry.Wang@arm.com>, =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>
Subject: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by default
Date: Tue, 4 Oct 2022 17:08:10 +0100
Message-ID: <20221004160810.25364-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221004160810.25364-1-andrew.cooper3@citrix.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Intel IceLake and later CPUs have microarchitectural behaviours which cause
data-dependent timing behaviour.  This is not an issue for 99% of software,
but it is a problem for cryptography routines.  On these CPUs, a new
architectural feature, DOITM, was retrofitted in microcode.

For now, Xen can't enumerate DOITM to guest kernels; getting this working is
still in progress.  The consequence is that guest kernels will incorrectly
conclude that they are safe.

To maintain the safety of current software, activate DOITM unilaterally.  This
will be relaxed in the future when we can enumerate the feature properly to
guests.

As an emergency stopgap, this behaviour can be disabled by specifying
`cpuid=no-doitm` on Xen's command line, but is not guaranteed ABI moving
forward.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Henry Wang <Henry.Wang@arm.com>
CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
CC: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 xen/arch/x86/cpu/common.c            | 29 +++++++++++++++++++++++++++++
 xen/arch/x86/cpuid.c                 |  5 +++++
 xen/arch/x86/include/asm/processor.h |  2 ++
 xen/tools/gen-cpuid.py               |  2 ++
 4 files changed, 38 insertions(+)

diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 0412dbc915e5..8c46a4db430a 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -209,6 +209,34 @@ void ctxt_switch_levelling(const struct vcpu *next)
 		alternative_vcall(ctxt_switch_masking, next);
 }
 
+bool __ro_after_init opt_doitm = true;
+
+static void doitm_init(void)
+{
+    uint64_t val;
+
+    if ( !opt_doitm || !cpu_has_arch_caps )
+        return;
+
+    rdmsrl(MSR_ARCH_CAPABILITIES, val);
+    if ( !(val & ARCH_CAPS_DOITM) )
+        return;
+
+    /*
+     * We are currently unable to enumerate MSR_ARCH_CAPS to guest.  As a
+     * consequence, guest kernels will believe they're safe even when they are
+     * not.
+     *
+     * Until we can enumerate DOITM properly for guests, set it unilaterally.
+     * This prevents otherwise-correct crypto from becoming vulnerable to
+     * timing sidechannels.
+     */
+
+    rdmsrl(MSR_UARCH_MISC_CTRL, val);
+    val |= UARCH_CTRL_DOITM;
+    wrmsrl(MSR_UARCH_MISC_CTRL, val);
+}
+
 bool_t opt_cpu_info;
 boolean_param("cpuinfo", opt_cpu_info);
 
@@ -532,6 +560,7 @@ void identify_cpu(struct cpuinfo_x86 *c)
 	/* Now the feature flags better reflect actual CPU features! */
 
 	xstate_init(c);
+	doitm_init();
 
 #ifdef NOISY_CAPS
 	printk(KERN_DEBUG "CPU: After all inits, caps:");
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 112ee63a9449..09c1ee18fd95 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -106,7 +106,12 @@ static void __init cf_check _parse_xen_cpuid(
     const char *name, unsigned int feat, bool val)
 {
     if ( unlikely(feat == ~0u) )
+    {
+        if ( strcmp(name, "doitm") == 0 )
+            opt_doitm = val;
+
         return;
+    }
 
     if ( !val )
         setup_clear_cpu_cap(feat);
diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h
index 8e2816fae9b9..2978416e6c5b 100644
--- a/xen/arch/x86/include/asm/processor.h
+++ b/xen/arch/x86/include/asm/processor.h
@@ -637,6 +637,8 @@ enum ap_boot_method {
 };
 extern enum ap_boot_method ap_boot_method;
 
+extern bool opt_doitm;
+
 #endif /* !__ASSEMBLY__ */
 
 #endif /* __ASM_X86_PROCESSOR_H */
diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py
index f3045b3bfd36..78a3a5c1941f 100755
--- a/xen/tools/gen-cpuid.py
+++ b/xen/tools/gen-cpuid.py
@@ -303,6 +303,8 @@ def crunch_numbers(state):
     # specially
     #
     pseduo_names = (
+        # Data Operand Invariant Timing Mode.  Lives in MSR_ARCH_CAPS
+        "doitm",
     )
 
     for n in pseduo_names:
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:12:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:12:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415727.660366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkWT-0000rO-JV; Tue, 04 Oct 2022 16:11:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415727.660366; Tue, 04 Oct 2022 16:11:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkWT-0000rH-En; Tue, 04 Oct 2022 16:11:57 +0000
Received: by outflank-mailman (input) for mailman id 415727;
 Tue, 04 Oct 2022 16:11:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P0IF=2F=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofkWR-0000rA-SH
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:11:55 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130041.outbound.protection.outlook.com [40.107.13.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4365535f-43ff-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 18:11:54 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM0PR04MB6819.eurprd04.prod.outlook.com (2603:10a6:208:17f::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct
 2022 16:11:53 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022
 16:11:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4365535f-43ff-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oLmqLkfk+MapJ/Vj+Zi4bkmvL25su9BdVGXYio+CA92EkE7AnZKHMms9geUnuEA/OGjvbbIsYd4qS8yY+nL6CoiqtYAY5bo5tDXVCrFExK9cmsc5+nm61yUm00VcU25Aoc4sosjasLwssHCce2OLqq+mQkXb/qSvpnsuZKoI1RYKGdyTrGW5Xmtv+QkJbc8wsVq0A4lvjnOCuw28gY81se3A+C/zNtvLgxe6FqEY/GBf/uKlT3Uen4oO+emPZGQCYziEhKLMWrK+YdhFkmgkpToubctchtoGQqy8S2XuKlaBZG1OfVecDdm1qaquYz7EmDaEVi1QW00qn7YKmyaKJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AvDyXkdzxCHMIcssQk9076u0oKSMQyTWQCeWMhfe2ec=;
 b=SeuwvB/21iGCx6Dnqe3FdgPrfCEU1kfyvLeKVfGvPlKfh3asQq+Fka4Tew9ajX7gspuo5LV23NDFhzPHjPH/AfMGs4T2+at3yrPPFldj2Q8Va9aeu+R9DLwjCxRhuSfI0d5RWmoDIyDkZ9Igwm0DK5v6o0u6ozbeAO1Tp1+tOLCnjdleVrxhM4JEmrV9l1xhaKbpShoyjYc5K8hWFjyC38w3PYHWJ4aQz7SGOo1O13g64LBg+3ukqu0c4ZQYYInzfYTZmMebkJR0NiZ3YMy23gn75n5Cl3ZTddXfh+hysNLZO2da/R9esOW+cejQ6SNt4jXZbyBOWTLSZUoLQLLJiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AvDyXkdzxCHMIcssQk9076u0oKSMQyTWQCeWMhfe2ec=;
 b=eo8MmtCgBFkuaCNxmEFdQPkEYtop+VU/hI8JfIk2Ebl5n7F7h2TwxBSlCUgt54lR/S7tcw86AUcuft8DYF6TE8yWguvXSlwplolQFCq+XEBbQiv/JcqVqqi6rig710gx/s/7YqFMhws99sU2ZgrspCnCJBr4xqXzOEM5PN2urH4hpOpuTeD5Cey+bzEvYYed1wNAB/Kdo1Qg2tsnm2kgKxvuPUzdTJXiTcapaoK09yc7Hpi13tKVDokgshYgxA35tQdpwZ83a64g6Be3pFKP98EvCZIkwe07kyljXtE8S7Q7VPZMnpQvJhn12sxrZZD02KjGLAcudIRoTLvhu2D5NA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
Date: Tue, 4 Oct 2022 18:11:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221004153645.3686-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221004153645.3686-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::22) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6819:EE_
X-MS-Office365-Filtering-Correlation-Id: d43b0dbf-1859-4444-f5f1-08daa6232698
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	coMOT3DFSgxrSbALMxB+V7/Q/h624RQgAaEL1xZW4yfUtYLUpZtWY+We4C0On6mGbKn4s94UpTUybJTD3WkI/nCFI+Wo56eS5wgjWooMu2V2HpxmF7M0VML7z6oSL+ppU/ny79r5s7m9iAvgfD2yzg34WNIoEn2gIS0SPGk18jFVdGvoRM8X+5umjIMIK8e0FumTm69t2n9mCqvySwC4YpCyOXe8zRfgp9kyFzOy2U9bmnseWhfPeN/ZajNV4jLhCQyWa/Lc0FEHQaRt5R2cNSPLj+OLW1nuzLDlpGx5nzfZcrBLATRPPKgHbUn2aIFRFUVcLt0/pXvmKdFHRb+ToFY0sfnGt9R6jah3OeIEzFpBfUl28lsB07wIjwlU7cylLz9w2GA7lOfecQVcJELCZLGB4B7x5KFa20Ts6m1OZGDmbC72RJwplvYP3VjpIcIuTafVi/LkLU5qhACb2Obe/T8pGdHW7zNzNCvvB8BjcTwmgp+az8Dhiuhm0mS4SN+9sjxiIMz1ULAqBsHq40ESZH9H1/1NPNfjB7uePdVtABcnsYAn5kLwhIykR2t0ofhAXGrjPUWpwzFTP+7qzHJIfoh4+Pbi5x1CX62AWAxQ2OnxjJh+psvvpN9E1zZUNnaGkDKaZ6R7lOWKVxJqmZcc7aFnqkvVqH8vqOwjqWauBm4yyFyoGP3pBAhGINsDMOaEkRcTUe6A0h7GVGFiNadqR69meQlyqCnx6tMwexaSGem/ajPvY0caK4s4GcEoenTZIsHRyofvhpNJEGuENgZAsRlfnyCk8+fL4nCDU2+5VgU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(376002)(366004)(451199015)(6916009)(316002)(54906003)(66946007)(6486002)(66476007)(66556008)(5660300002)(8936002)(36756003)(478600001)(8676002)(38100700002)(41300700001)(4326008)(83380400001)(6506007)(53546011)(86362001)(186003)(31696002)(6512007)(2616005)(26005)(31686004)(2906002)(66899015)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N1lybCtIcGJSdm9JNnFWL1IrWEwzaGN1dlYvN1lHd0NyY28xM0N2cUJpeVdk?=
 =?utf-8?B?cDNrUExRTFNnVG5LTnY0eG5vNmhTMi9OZGlPNjBTeVk1d3dGNlFUeUwxTmhI?=
 =?utf-8?B?d2tSM0NQL3VGdEZ3Y2RJU3pvK1JlQmZnNnliR0tUTStTWUlRWWd2UHc2Sy82?=
 =?utf-8?B?Qk80dzhMdHExSDNhTVk3ZGNJMnI2ZnJ3dGUvUzZHQlcrdVBNSTR6VUtwWUx5?=
 =?utf-8?B?a2V5ZlFZcDJBbnZ3b3QxWTg5M3B4R3lDSHpzQVQwWkxaVFovN1EwbjhjNEZa?=
 =?utf-8?B?Y1RpSEp5eGNlejFXck9XdWNsVnFtcXIxaGlTWVoxVWxhSEFMUDR5RThzdGRa?=
 =?utf-8?B?SklaWm0rU1pWY1lwT2l2QmlaczNUeGc0Vk1KdlZNUkJDdFZQd1M3SzZ3WEZt?=
 =?utf-8?B?SitzV3Z2cm9sRzJ6Z01VVXVMSmEyRzFaRW5VUVE3MU4zclJFTmdXZC9IcmpO?=
 =?utf-8?B?T05tcUFHSVB5SnhkZkt4N2Z6UGFMclMydnRHenYyWHl5aVVpcjRvZ1drdzdO?=
 =?utf-8?B?Znh3aUtmTSthWmNRbGZvS1l3ZlgrWUhmYWxhRkVMYXhuRjM0SVZJOG5WeDB6?=
 =?utf-8?B?SmZ6RElCejlWN3lsaWJiQmtHUnI2cW9QS0h1Mlk1dWtVMllMSXpqemhtSGVx?=
 =?utf-8?B?bHVWTTA2VXltOFVzRUF2SC9RNCswUFNQY2RiL01LbXZhZHRiNFdHN0lpM0hk?=
 =?utf-8?B?WnJVeVJrZTBNNCtUOVArVkxndlBRWTg3ZklGRmhwalZlTlVUQXFiRTZzenNL?=
 =?utf-8?B?ckVFTDkrQTB6aXFpazlqckgzYlZTTGNxRHhHaDlVNVR6Q3dOUFR3ZWlUd2Rx?=
 =?utf-8?B?d3hqSWNiQXFhMDZNSzh3WFZJcnJodkpQMFEzS1JON1dSOGVPNjJ5eUhhdlpS?=
 =?utf-8?B?bEFNU1ZXejRDREVUOGI4b0tWU1FBSjN1MWllSlhzYThHQklGNFJUVTUwRjFo?=
 =?utf-8?B?Mi9uQWllb0p1UXkxaTZFQlh4RWRwSGU4U1BhZW4vTmVtNk1Ndkovc2k3dFJS?=
 =?utf-8?B?N0M4akoybkt0TzJmeTVid21tLzNycDd4UjY5cTVscCtFQXg1S2g2ak9pMUpO?=
 =?utf-8?B?SWFxSzV3eDRaMEtJTnkvMXQ2ZHhramR1Ymw2dGlPQ0hYWGRSZTlOY1g3SFVH?=
 =?utf-8?B?b0dhdUxla1VwZHh6OUM0SFZDcUE1VGkvcTdobXMxT2JoME9XRFVNUkRabVlE?=
 =?utf-8?B?cHNYelAvdk1WQkg4RmJRVWZVYTBCem5BcmREZUtTUEtRbERlY3ZydWIzZWlR?=
 =?utf-8?B?ZFo0NTJIR3NVZU1zNXVaRDhqVkRLTmc3Q3pEOE81K29SN2Z4bmpnL21XcWZQ?=
 =?utf-8?B?VFcxWktzU2YzVmRlOGVoZjlKMjhLdTh5ZlBiYk1kS2JjSmVTWDFQZWt0RVlL?=
 =?utf-8?B?aG5ibzB6cmd6b3VrMm1jdm5oVHFKMWxwTWhSQmhBSms4RnViSUNibW8zM2pG?=
 =?utf-8?B?U1Q3SDlORW05aFdMTWtRVUJjR1Y3Y08yeUdCYjhqS2RCY0FCWnZCYi9tYndY?=
 =?utf-8?B?NHZQSTcwdzJoWUp2M2NhWDdVZ3Uvcnpqc3IyVkRYclRlS2FqNTZOaHVIem81?=
 =?utf-8?B?Y1l2cHZMaWFUd3k0N1AwSFQvelJBRHlEYTJJYlBMdmRnazdLbXlUSUV4UVlu?=
 =?utf-8?B?Vmg5eWpRTXZMZnp5QkJPbTJMdCtRQlM3V3NIZ0lCdGhHVWNsK3dvS2R1YW94?=
 =?utf-8?B?V0pkRUZwOUZqcWZOQlE3SFI4UStQYXR6VFhEMTlmdGZCeEU0OHdFVWxTM3cx?=
 =?utf-8?B?STI3b2xDR0l3Y0xNam1tS0ZXMnpiSHJqa09rbDNyUjgvUlJKTzNJTklYNHBr?=
 =?utf-8?B?OC9paDExZGR5RmFrUDBSbW43RWFCUUpRekhJKzlMckZYY3llaUEvL0NUcDM0?=
 =?utf-8?B?aDAxRE8vYk1HR1BOaUdLVXhRZk5Wd1VJUDBOSjRiU3F1SExkemVhZ3U1R1ls?=
 =?utf-8?B?V2JMUnRYV2QyY3hZY1ZmYlNUcDl1U3owNkdKZFBDbTJDNFVBWklXSksxQW1Q?=
 =?utf-8?B?Z0cxN3FTUDlsU3l1Z3NLM3lwcTZDSE0vWUJjU2Z6Q2ZSVzhmdXNTVEtySDVS?=
 =?utf-8?B?cDgrR2tuNjFreTJZcmFvQ0RFaXZROWt6dTdVN0JOenpSUWt2M0JVei9pY3N0?=
 =?utf-8?Q?4fFNzU1+iB7IVpQLmOFfUQKX9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d43b0dbf-1859-4444-f5f1-08daa6232698
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 16:11:52.9064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wx3PwDqmGHz2/XuMiUm2A+Mn70BAwdA8Ko6iDVLddKdbI2taMknrw2WpZ+tW1cUYtY1ViEWlSmf3rNGHj5a10g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6819

On 04.10.2022 17:36, Roger Pau Monne wrote:
> The EFI memory map contains two memory types (EfiMemoryMappedIO and
> EfiMemoryMappedIOPortSpace) used to describe IO memory areas used by
> EFI firmware.
> 
> The current parsing of the EFI memory map is translating
> EfiMemoryMappedIO to E820_RESERVED on x86.  This causes issues on some
> boxes as the firmware is relying on using those regions to position
> the BARs of devices being used (possibly during runtime) for the
> firmware.
> 
> Xen will disable memory decoding on any device that has BARs
> positioned over any regions on the e820 memory map, hence the firmware
> will malfunction after Xen turning off memory decoding for the
> device(s) that have BARs mapped in EfiMemoryMappedIO regions.
> 
> The system under which this was observed has:
> 
> EFI memory map:
> [...]
>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> [...]
> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> 
> The device behind this BAR is:
> 
> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> 	Subsystem: Super Micro Computer Inc Device 091c
> 	Flags: fast devsel
> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> 
> For the record, the symptom observed in that machine was a hard freeze
> when attempting to set an EFI variable (XEN_EFI_set_variable).
> 
> Fix by allowing BARs of PCI devices to be positioned over reserved
> memory regions, but print a warning message about such overlap.

Somewhat hesitantly I might ack this change, but I'd like to give
others (Andrew in particular) some time to voice their views. As
said during the earlier discussion - I think we're relaxing things
too much by going this route.

> --- a/xen/arch/x86/pci.c
> +++ b/xen/arch/x86/pci.c
> @@ -98,3 +98,30 @@ int pci_conf_write_intercept(unsigned int seg, unsigned int bdf,
>  
>      return rc;
>  }
> +
> +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end)
> +{
> +    unsigned long mfn;
> +
> +    /*
> +     * Check if BAR is not overlapping with any memory region defined
> +     * in the memory map.
> +     */
> +    if ( is_memory_hole(start, end) )
> +        return true;
> +
> +    /*
> +     * Also allow BARs placed on reserved regions in order to deal with EFI
> +     * firmware using EfiMemoryMappedIO regions to place the BARs of devices
> +     * that can be used during runtime.  But print a warning when doing so.
> +     */
> +    for ( mfn = mfn_x(start); mfn <= mfn_x(end); mfn++ )
> +        if ( !page_is_ram_type(mfn, RAM_TYPE_RESERVED) )
> +            return false;

We don't need to be arch-independent here and hence instead of this
(potentially long) loop can't we use a single call to e820_all_mapped()?

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 16:15:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 16:15:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415738.660376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkaD-0001Y7-5H; Tue, 04 Oct 2022 16:15:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415738.660376; Tue, 04 Oct 2022 16:15:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofkaD-0001Y0-22; Tue, 04 Oct 2022 16:15:49 +0000
Received: by outflank-mailman (input) for mailman id 415738;
 Tue, 04 Oct 2022 16:15:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=l35h=2F=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ofkaC-0001Xu-Lo
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 16:15:48 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce47653f-43ff-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 18:15:47 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4CC6F1F918;
 Tue,  4 Oct 2022 16:15:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 194A6139D2;
 Tue,  4 Oct 2022 16:15:47 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YvPEBDNcPGPgJQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 04 Oct 2022 16:15:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce47653f-43ff-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664900147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CrBJS4XP3AwPDQq+A1IRFhkBFBC6WOYuz+r/s+kICmw=;
	b=t5BUu0gsu6u+3zcTztf8xAQ6AoLqyPNSv0e53unobKOMp8sLJXACioN2N9H+Y89SnzTLfh
	pIpn3DUdzpurt24n4iYxkc4+dQvzPQepVFMe3jV5CqqZl7C9xJ3/MQQiaOr1F1HPON/VcH
	KsMDUpUOHeneWYNQt15E49YGUK73iLk=
Message-ID: <037ae081-49ba-490e-48ac-fd035241e05b@suse.com>
Date: Tue, 4 Oct 2022 18:15:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen/xenbus: Fix spelling mistake "hardward" -> "hardware"
Content-Language: en-US
To: Colin Ian King <colin.i.king@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221004160639.154421-1-colin.i.king@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221004160639.154421-1-colin.i.king@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------zmUusmk3r0kty7NjGFaM9BZ6"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------zmUusmk3r0kty7NjGFaM9BZ6
Content-Type: multipart/mixed; boundary="------------IevJcMCWpZud0t33ynfvv0Be";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Colin Ian King <colin.i.king@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <037ae081-49ba-490e-48ac-fd035241e05b@suse.com>
Subject: Re: [PATCH] xen/xenbus: Fix spelling mistake "hardward" -> "hardware"
References: <20221004160639.154421-1-colin.i.king@gmail.com>
In-Reply-To: <20221004160639.154421-1-colin.i.king@gmail.com>

--------------IevJcMCWpZud0t33ynfvv0Be
Content-Type: multipart/mixed; boundary="------------rZHHk3SUptnPXXpjkkxcurWX"

--------------rZHHk3SUptnPXXpjkkxcurWX
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDQuMTAuMjIgMTg6MDYsIENvbGluIElhbiBLaW5nIHdyb3RlOg0KPiBUaGVyZSBpcyBh
IHNwZWxsaW5nIG1pc3Rha2UgaW4gdGhlIG1vZHVsZSBkZXNjcmlwdGlvbi4gRml4IGl0Lg0K
PiANCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmkua2luZ0BnbWFp
bC5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+
DQoNCg0KSnVlcmdlbg0KDQo=
--------------rZHHk3SUptnPXXpjkkxcurWX
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------rZHHk3SUptnPXXpjkkxcurWX--

--------------IevJcMCWpZud0t33ynfvv0Be--

--------------zmUusmk3r0kty7NjGFaM9BZ6
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM8XDIFAwAAAAAACgkQsN6d1ii/Ey+o
lwf8DiNW4nFClpAtfeN6ycztb/ZhNXF75WNv2MmQg16qhPlseujTU22nejuUwDLOVXD7/fcF+RnE
1ldsrAwNCx+BbcHoQ1KMZw5MQ8n06mW1mkMetKea09qk2y3lRvC9D6uQR6onNixF/oiAlkQx2kui
wYb+Jbpjl5ySpRxXD8fCcMdqICsszlRCJ+jQ1H69oP0AkDMldNrIJLX0TY4UJIqrw6nTWnffL3OL
A4B9nvNFk45fqWc34ePFqNVTg8Cq44KQLby1b3Ih1S/4CxIu9dK3DV+Ar6Mbi1zxhn3yUEpxW/lz
I/3kmSNNYUe2BJfeIb0ctir+mjGHYmV3t62E8HCePg==
=xMJY
-----END PGP SIGNATURE-----

--------------zmUusmk3r0kty7NjGFaM9BZ6--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 17:46:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 17:46:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415746.660388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oflzl-0001lS-KE; Tue, 04 Oct 2022 17:46:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415746.660388; Tue, 04 Oct 2022 17:46:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oflzl-0001lL-H7; Tue, 04 Oct 2022 17:46:17 +0000
Received: by outflank-mailman (input) for mailman id 415746;
 Tue, 04 Oct 2022 17:46:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IgJy=2F=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1oflzj-0001lF-Pj
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 17:46:16 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6e7ebc26-440c-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 19:46:12 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id E91E85C0061;
 Tue,  4 Oct 2022 13:46:09 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 04 Oct 2022 13:46:09 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 4 Oct 2022 13:46:08 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e7ebc26-440c-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664905569; x=
	1664991969; bh=j1co2OtJjD7/vRKiHmQIV5tJWRkOaG0PZ91t7wBXB08=; b=b
	uVrn8e+X1yqcOFjSdZ2m0JtalxHee6ojtu6uxKe2dDP+PxZK0d4EdjiwOzV1qD4P
	DRVAYGUMQ46TQC79a8IgLyHmrHkLVd2QC5Vh5U1sE6FSxORGTmm75y1OZPH4v3Vd
	YOLDu2vqHupepX7WrjQlIbP64gbNo74NPBaE9ptLsTN4N/H6wPSoX22bYYkocbQQ
	eBJdolRQRQ+gKVKXvoWTloGYDF96rStVcIi3tu6nLwCY7+e5cYf9AS6ic37tTWwB
	OPGG3OG53Cp8Uk+VotAEbArlv+FOPRBZJyJbmdwdz7CeQ3B8je1pPvah42Ro7xAq
	mdOcG7DJ4DYF4qSZTmcaA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664905569; x=1664991969; bh=j1co2OtJjD7/vRKiHmQIV5tJWRkO
	aG0PZ91t7wBXB08=; b=r4NdtuS3BOGr1usAHz1Iam2a95O9RnYq7uMZgqz6NPeC
	nmMgdbtqLBMJnydm3qRndZlnAI3JbV9SfcpY8aOYVwUJAkvZ9kc6sVQzglGI2yhO
	QmeBnPcU9NGkjl0yaJYbbzUTK490oMT9O3dRHta7GTJaJIAk4e6Kjse5jHVJUY/n
	fPlp2xHEHi2pVd/ti0qIJSASo78Tq4DoB2X6G9Wk9/t6e2S7Asj84T4bUfXXxHmS
	KhReL40qlqq/E5fWtontKTbYRpX42iVuQxjz3SikwRfvGUmaTgpduEcpwdsD2eoY
	KuSYRzIidx4UXsGyaNuTZeBYOGE3wIjELfzfOpmR5A==
X-ME-Sender: <xms:YXE8Y0_4RjLdTf4ZcV3fxbvSMSn51U_1XUAaIwoevXDni-ON5oKuIg>
    <xme:YXE8Y8vPGN5s4wWa0od220jNPMKCiaoBRECXsL7M9GsxjZlKf6ebq3m8iy0TgcCec
    0EqTyUiCBEXdAY>
X-ME-Received: <xmr:YXE8Y6AzxWvyrFtxe7TD7bo8JZ4ZV9K8qRldsUwxoQmS5X1lUQ9yc7B5yusd>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiuddguddujecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg
    fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne
    curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg
    shhlrggsrdgtohhm
X-ME-Proxy: <xmx:YXE8Y0cnvKuzY9DZ5FXWtpTEg2aicizrW0DVgeZ68EWorWDULA0Amg>
    <xmx:YXE8Y5NHHi7xxVk1ilJLeztFNySAVGgT99HRbkiFBWa3Gi84A9QyFg>
    <xmx:YXE8Y-knnc0OzmocImv-2pqZrzV2gA0TwN6wY7aPiktQ8QgGVy01Pw>
    <xmx:YXE8Y6HkQRHwNpRt3pYXDU_S_MQHBaR7CF7e4NSV-pAhw9LOJGDbog>
Feedback-ID: iac594737:Fastmail
Date: Tue, 4 Oct 2022 11:46:59 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Message-ID: <YzxxXuovwQt3NskE@itl-email>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email>
 <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lgxbz4vBgheHS+D8"
Content-Disposition: inline
In-Reply-To: <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>


--lgxbz4vBgheHS+D8
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 4 Oct 2022 11:46:59 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered

On Tue, Oct 04, 2022 at 10:22:13AM +0200, Jan Beulich wrote:
> On 01.10.2022 02:30, Demi Marie Obenour wrote:
> > On Fri, Sep 30, 2022 at 08:27:09PM +0200, Ard Biesheuvel wrote:
> >> On Fri, 30 Sept 2022 at 19:12, Demi Marie Obenour wrote:
> >>> On Fri, Sep 30, 2022 at 06:30:57PM +0200, Ard Biesheuvel wrote:
> >>>> I know very little about Xen, but based on the context you provided =
in
> >>>> this thread, I'd say that the best approach from the Xen side is to
> >>>> convert all EfiBootServicesData regions that have configuration tabl=
es
> >>>> pointing into them into EfiAcpiReclaimMemory.
> >>>
> >>> Should Xen convert the entire region, or should it try to reserve only
> >>> the memory it needs?  The latter would require it to parse the
> >>> configuration tables.  Is there a list of configuration tables that c=
an
> >>> legitimately be in EfiBootServicesData regions?
> >>>
> >>
> >> Not really, no. So you would have to convert the entire region
> >> /unless/ Xen knows the GUID, and therefore knows how to derive the
> >> size of the table, allowing it to reserve memory more conservatively.
> >> However, I doubt whether this is worth it: splitting entries implies
> >> rewriting the memory map, which is a thing I'd rather avoid if I were
> >> in your shoes.
> >=20
> > I actually wonder if Xen needs to reserve *all* of EfiBootServicesData.
> > The reason is that some (probably buggy) firmware may store ACPI tables
> > there, and Xen does not have an ACPI implementation.
>=20
> We already have the -mapbs option as a workaround in such situations.

The problem is that there is no way for the user to know when it is
needed.  One option would be for dom0 to print a warning in the kernel
log if it needs to ignore a table due to it being in EfiBootServicesData.

> >  From my
> > perspective, a much safer approach would be to pass all of
> > EfiBootServicesData memory directly to dom0, and have dom0 give Xen back
> > what it doesn=E2=80=99t wind up using.  That allows dom0=E2=80=99s memo=
ry reservation
> > code to work properly, which it currently does not.
>=20
> As said already on a different thread: Giving memory to domains (incl
> Dom0) isn't related to their original memory type (neither EFI's nor
> E820's); the needed memory is taken from the general page allocator
> (with one exception for initrd, to avoid unnecessary copying around of
> data). Hence what you propose would end up as an (imo) awful hack in
> Xen. I also don't see how this relates to "dom0=E2=80=99s memory reservat=
ion
> code", but I'm sure you can clarify that for me.

Linux has a function called efi_mem_reserve() that is used to reserve
EfiBootServicesData memory that contains e.g. EFI configuration tables.
This function does not work under Xen because Xen could have already
clobbered the memory.  efi_mem_reserve() not working is the whole reason
for this thread, as it prevents EFI tables that are in
EfiBootServicesData from being used under Xen.

A much nicer approach would be for Xen to reserve boot services memory
unconditionally, but provide a hypercall that dom0 could used to free
the parts of EfiBootServicesData memory that are no longer needed.  This
would allow efi_mem_reserve() to work normally.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--lgxbz4vBgheHS+D8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM8VY8ACgkQsoi1X/+c
IsHLdA/+LM4HOMK+UqW8ug41g4/DBfgbjzO9EIOgBAXcDsotBsE2hgv+29Nd8k2/
x08K8YAFtt6tgef77/ZH2pFmtCbY3v9AbO+Y0AUn6TD8ownHkXRvQZcH4f+/q1qu
I/eMEvBHn2+Tcl5NLk8JbIj+iufNcZsgvuPxO5Bn6L6cs3uLKey68T+iBN1djFNc
LrhecxdhCSa1096qkvxAn6d7RRQcplv1//S4LXrCjt3q77T4Dg7y8sPcqDQw98W1
QW+6l9GDwVr0EDWse00UkigGhQK+GP3bEv3ucJoxiDFYCAQy24sOTBL/m4wfcZmv
t/43wgXv9010fUACW0Fl0kgKPWMKCMfUM1d7VLEj4GkWLaN41C8eZc5EBj5p37Df
AR1xqfFhR3X50gACUUyoUVfLw2LbohUdzmqncPIAhFOYnrZ4/EfaQjHEq1EMHsPi
X0ocJZhndjM12OXOgLpYdijTZ/1fl6LtYmEULzGdDP1ANinE85ihHsBmLOfUMF+R
MOsy9XDSKzYpi1naZ0Pt+hJzEsEmzoxV7JytqBSxCKihGlnsFf6PPF+eKa3UnFyp
ji4rdgWVtUqhrPa8SWHaxiNhTnNJSZ7VDYbj7hkwejS6dk08ZXmcfHmKDRo3FflR
Y4PVJCITmoxzY63hLDFPN5bDwiEYqRAVlHpsix40rjxGDMDq7EM=
=u0CQ
-----END PGP SIGNATURE-----

--lgxbz4vBgheHS+D8--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 17:53:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 17:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415756.660399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofm76-0003D3-CU; Tue, 04 Oct 2022 17:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415756.660399; Tue, 04 Oct 2022 17:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofm76-0003Cv-9b; Tue, 04 Oct 2022 17:53:52 +0000
Received: by outflank-mailman (input) for mailman id 415756;
 Tue, 04 Oct 2022 17:53:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IgJy=2F=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ofm75-0003Cp-8E
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 17:53:51 +0000
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7fccbb88-440d-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 19:53:50 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 77C7A5C0113;
 Tue,  4 Oct 2022 13:53:48 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Tue, 04 Oct 2022 13:53:48 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 4 Oct 2022 13:53:47 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fccbb88-440d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664906028; x=
	1664992428; bh=crMLwkYrYFWOA1+VA0BUO688RPGUWzKTzdzfbu3JkkE=; b=2
	MMOhyZHbORWatMaYrJCtVSYg0r0XHyaW0eNJY0z8ZTzVricK2fwqD2PeAIh/Cdo5
	mP/c4bd/7fnTeRCN5GdvXpsugzgtKtIiUSamUPS3JZpKTMhVxq/XhFo6d38Udru1
	+UxjarFIUmASO+6IZSWuQgAPs5lhwUquKHksNP9lklxcDpGkSdrDad34m5ep1J7t
	zhi29mw3H1b2W0HtF2QVo50Dm9BYR62zqne0OHvaeEkycXfkvPLWcC0cx9r8YDwS
	wf9PIHYoubtVbD1g8X5YqfYedJGV6YL2tKrRh9Y3NpuyaSxlNP5wknxD1gKIKdlh
	fBahCbY24fY4tAGY60mSA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664906028; x=1664992428; bh=crMLwkYrYFWOA1+VA0BUO688RPGU
	WzKTzdzfbu3JkkE=; b=AkTt3B8pmj7Ml2nZSgvgOsy/oWj/1LypjtTvL1IJhMwM
	WZVackhTEinZ3ojHW1IhRqczLN1gUakhP0GeWj1WjnGSG1bHVdBZ4MT9JxtD8U6P
	9+a/xvBpoJmF/4KGx/hJOkpoZECJOZjgpGlXAY5BOGlceJtcPyFfTz+dxRqLvlKV
	6mxnsnBba50ERm43a5oVj19YcbcQ6xg6TLVKEXjngEKu59wFrkkMWFMOu3vnZlOy
	yh+IERoWKg8OdGQ+Ko6EeHfzRosPvcCJPH8w4TJyKcg5/YHTWqKckz1HBqxdutht
	em4qSGDuBhDXGDLOMCgYCUhZCDbv+6sD9Y8IzOLtnQ==
X-ME-Sender: <xms:LHM8Y4GBfgG_KA7tDJUFRrGo8uH8hbrLXd-oE_10qTXae9gBBQW4QQ>
    <xme:LHM8YxUmGdTS-D4eX4ZoSG6b-t4YUt1Ts33jQjSXVXYW5JN1sgZxp2Ewbvpw_4qjT
    NMCJ_Z1w9hJ3yU>
X-ME-Received: <xmr:LHM8YyJtqC_Q3f45_myOFkQ7-KeoZOE4Z-sAeUqigATWrQH9p_1RWqocHFGX>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiuddguddukecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg
    fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne
    curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg
    shhlrggsrdgtohhm
X-ME-Proxy: <xmx:LHM8Y6Fv_vgu392bpTx3N2pvr4OUP49VNCFut6gXn9MfUTToEcjk8g>
    <xmx:LHM8Y-XxT18-IBZrtJOgfq5CYL2-CYGbFo2YLZVjvJP3qnMMAGM8rA>
    <xmx:LHM8Y9NYYH66k3QJzrwbhU1BHX98AE_rcHwMuiwb_fhxeaCcwtSNDw>
    <xmx:LHM8Y8zyWh_71Li2Tp9EYHRe5teOPFg3wn_ZCDucMMSjbTSPNtJ9kA>
Feedback-ID: iac594737:Fastmail
Date: Tue, 4 Oct 2022 13:53:31 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>,
	Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by
 default
Message-ID: <YzxzKY01r12OPyiR@itl-email>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-3-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SHDQr5c8XtikZYTS"
Content-Disposition: inline
In-Reply-To: <20221004160810.25364-3-andrew.cooper3@citrix.com>


--SHDQr5c8XtikZYTS
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 4 Oct 2022 13:53:31 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>,
	Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by
 default

On Tue, Oct 04, 2022 at 05:08:10PM +0100, Andrew Cooper wrote:
> Intel IceLake and later CPUs have microarchitectural behaviours which cau=
se
> data-dependent timing behaviour.  This is not an issue for 99% of softwar=
e,
> but it is a problem for cryptography routines.  On these CPUs, a new
> architectural feature, DOITM, was retrofitted in microcode.
>=20
> For now, Xen can't enumerate DOITM to guest kernels; getting this working=
 is
> still in progress.  The consequence is that guest kernels will incorrectly
> conclude that they are safe.
>=20
> To maintain the safety of current software, activate DOITM unilaterally. =
 This
> will be relaxed in the future when we can enumerate the feature properly =
to
> guests.
>=20
> As an emergency stopgap, this behaviour can be disabled by specifying
> `cpuid=3Dno-doitm` on Xen's command line, but is not guaranteed ABI moving
> forward.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Henry Wang <Henry.Wang@arm.com>
> CC: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>
> CC: Demi Marie Obenour <demi@invisiblethingslab.com>
> ---
>  xen/arch/x86/cpu/common.c            | 29 +++++++++++++++++++++++++++++
>  xen/arch/x86/cpuid.c                 |  5 +++++
>  xen/arch/x86/include/asm/processor.h |  2 ++
>  xen/tools/gen-cpuid.py               |  2 ++
>  4 files changed, 38 insertions(+)
>=20
> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
> index 0412dbc915e5..8c46a4db430a 100644
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -209,6 +209,34 @@ void ctxt_switch_levelling(const struct vcpu *next)
>  		alternative_vcall(ctxt_switch_masking, next);
>  }
> =20
> +bool __ro_after_init opt_doitm =3D true;
> +
> +static void doitm_init(void)
> +{
> +    uint64_t val;
> +
> +    if ( !opt_doitm || !cpu_has_arch_caps )
> +        return;
> +
> +    rdmsrl(MSR_ARCH_CAPABILITIES, val);
> +    if ( !(val & ARCH_CAPS_DOITM) )
> +        return;
> +
> +    /*
> +     * We are currently unable to enumerate MSR_ARCH_CAPS to guest.  As a
> +     * consequence, guest kernels will believe they're safe even when th=
ey are
> +     * not.
> +     *
> +     * Until we can enumerate DOITM properly for guests, set it unilater=
ally.
> +     * This prevents otherwise-correct crypto from becoming vulnerable to
> +     * timing sidechannels.
> +     */
> +
> +    rdmsrl(MSR_UARCH_MISC_CTRL, val);
> +    val |=3D UARCH_CTRL_DOITM;
> +    wrmsrl(MSR_UARCH_MISC_CTRL, val);
> +}
> +
>  bool_t opt_cpu_info;
>  boolean_param("cpuinfo", opt_cpu_info);
> =20
> @@ -532,6 +560,7 @@ void identify_cpu(struct cpuinfo_x86 *c)
>  	/* Now the feature flags better reflect actual CPU features! */
> =20
>  	xstate_init(c);
> +	doitm_init();
> =20
>  #ifdef NOISY_CAPS
>  	printk(KERN_DEBUG "CPU: After all inits, caps:");
> diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
> index 112ee63a9449..09c1ee18fd95 100644
> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -106,7 +106,12 @@ static void __init cf_check _parse_xen_cpuid(
>      const char *name, unsigned int feat, bool val)
>  {
>      if ( unlikely(feat =3D=3D ~0u) )
> +    {
> +        if ( strcmp(name, "doitm") =3D=3D 0 )
> +            opt_doitm =3D val;
> +
>          return;
> +    }
> =20
>      if ( !val )
>          setup_clear_cpu_cap(feat);
> diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/=
asm/processor.h
> index 8e2816fae9b9..2978416e6c5b 100644
> --- a/xen/arch/x86/include/asm/processor.h
> +++ b/xen/arch/x86/include/asm/processor.h
> @@ -637,6 +637,8 @@ enum ap_boot_method {
>  };
>  extern enum ap_boot_method ap_boot_method;
> =20
> +extern bool opt_doitm;
> +
>  #endif /* !__ASSEMBLY__ */
> =20
>  #endif /* __ASM_X86_PROCESSOR_H */
> diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py
> index f3045b3bfd36..78a3a5c1941f 100755
> --- a/xen/tools/gen-cpuid.py
> +++ b/xen/tools/gen-cpuid.py
> @@ -303,6 +303,8 @@ def crunch_numbers(state):
>      # specially
>      #
>      pseduo_names =3D (
> +        # Data Operand Invariant Timing Mode.  Lives in MSR_ARCH_CAPS
> +        "doitm",
>      )
> =20
>      for n in pseduo_names:
> --=20
> 2.11.0

I can=E2=80=99t review the actual implementation, but the idea looks good t=
o me.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--SHDQr5c8XtikZYTS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM8cykACgkQsoi1X/+c
IsHbUhAAv4Rbj8vaccBO8kZW5hLFXlpTm3aY9wkKZsNV+CHHV6aXQCYWirYJfuSo
r3PZnVSu7qZI46b8PHG7oYIObtAy1HNXcF93qA4y4MazrRKdf8UyJD35sIvCZ4iz
Q0+BdZB+y+uvNeulfevKCss7bzn8YBFn8EW9g2AzouiEjG+mrtUzxMZ0UyQfDWdr
GeSMgy30bJmCwQljOQzQ3Zflv9m8oajwaOFYTyLHJujeowwfJG3KjCSOMBN6g5ga
hFtmYCdJ+0VVZ+6mNLB0hpvEJWsxN2nUW9HgZhLVgYSTT/2wZv2exKiE9vFsg1Bc
GUisQkG6Wxa40RZzfcOSNp3s08jjzPB4dNWkiqFk33wserlqIhGkppvaDEaLvuCA
9+bviE5QsrmkrVqkJ/+fI4H2vo4zmM7t9GKBTnuVlTEnc71CYtxTr+pCh3eXFRzn
FKpgvTAX/KZyJ0xy9/E9eXO2gYJO8jLu85crXHImInDTffMrLliRhysAyf1pVDV3
K//1+2GPu7fCoySer4dSSt/PDNb4uOUBIzXHNGzqq45CsNFsxJeogeCFU6BtxrvC
qFdVBiplmVGyqAn949iYnjVs6XElTu5HH61HAaHbYiudsd5T1OKVE7nSnqrt2vtU
y2mzJz6GNM/6g01rwMYItmCtNOOhw7dmL+nqmIRKyZP5daha8QQ=
=oJP8
-----END PGP SIGNATURE-----

--SHDQr5c8XtikZYTS--


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 18:30:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 18:30:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415767.660409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofmgi-0007T3-DS; Tue, 04 Oct 2022 18:30:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415767.660409; Tue, 04 Oct 2022 18:30:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofmgi-0007Sw-AW; Tue, 04 Oct 2022 18:30:40 +0000
Received: by outflank-mailman (input) for mailman id 415767;
 Tue, 04 Oct 2022 18:30:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofmgg-0007Sm-Hv; Tue, 04 Oct 2022 18:30:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofmgg-0000xL-D3; Tue, 04 Oct 2022 18:30:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofmgg-00026C-0M; Tue, 04 Oct 2022 18:30:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofmgf-0003U8-Vs; Tue, 04 Oct 2022 18:30:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WD0rr0lGiXF+ownmF73O973p/2bp32K3YeyUIlPpRJc=; b=4fcPvuKFZr5Rky/pJiZkexbfxe
	CLACH9Zh/+Y2xVbNXVnCCl5X8JQ2iWkWbxlqZ8KnE2r4fDr6xiYeRwAM7TX3ukyA+4icyyBJuKqOd
	DxL65fwAv/lG1svfz9JdzH77Q/ec0as5BUOLg+sEO/DM+XesfRQrlun4NUzShEDNWJFw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173416-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173416: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3161231abcb461314b205337fbd0530c7ead1696
X-Osstest-Versions-That:
    xen=1666086b00442b23e4fd70f4971e3bcf1a16b124
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 18:30:37 +0000

flight 173416 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173416/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173412
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173412
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173412
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173412
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173412
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173412
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173412
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173412
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173412
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173412
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173412
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173412
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3161231abcb461314b205337fbd0530c7ead1696
baseline version:
 xen                  1666086b00442b23e4fd70f4971e3bcf1a16b124

Last test of basis   173412  2022-10-04 01:55:40 Z    0 days
Testing same since   173416  2022-10-04 12:10:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <stefano.stabellini@amd.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1666086b00..3161231abc  3161231abcb461314b205337fbd0530c7ead1696 -> master


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 18:48:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 18:48:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415779.660428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofmxp-0000ht-Ue; Tue, 04 Oct 2022 18:48:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415779.660428; Tue, 04 Oct 2022 18:48:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofmxp-0000hm-Rl; Tue, 04 Oct 2022 18:48:21 +0000
Received: by outflank-mailman (input) for mailman id 415779;
 Tue, 04 Oct 2022 18:48:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L4OA=2F=vmware.com=namit@srs-se1.protection.inumbo.net>)
 id 1ofmxo-0000hg-OU
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 18:48:21 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-westcentralusazlp170100000.outbound.protection.outlook.com
 [2a01:111:f403:c112::])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b6229d9-4415-11ed-964a-05401a9f4f97;
 Tue, 04 Oct 2022 20:48:18 +0200 (CEST)
Received: from BY3PR05MB8531.namprd05.prod.outlook.com (2603:10b6:a03:3ce::6)
 by DM6PR05MB6506.namprd05.prod.outlook.com (2603:10b6:5:126::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.3; Tue, 4 Oct
 2022 18:48:11 +0000
Received: from BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6]) by BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6%7]) with mapi id 15.20.5709.009; Tue, 4 Oct 2022
 18:48:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b6229d9-4415-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=faXLpyR817QtBcFMKI0+xw3BvO3d9Ve+n3TqY+weBJyLPNH9dd8+4UFDqqmnEL7a/59jXuNGQV67t6uucgJcs/2reRrEiY/KNuNI5i7eXQ16q2g2IMPDI1QL5+45qZSKUzu1GWfn4TX+tQCBvEG4XwwLni7dbh4Vk++DeOIgScdGjBEea9sTExGIAEXUEOaXuepqdCaQ3TDq8voo5A456BBDoQKmjtnigrZqKCsfx6DzYk4cVVt+eaYcsEzy25xeO9fSCJwK2Fex3NX6AclOVfo5TxODuRwtMmZUAVYMX1cAknqS2aDJpuJwzL2nn2OjTxlt3xCqWhJM9G017JggHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5LryRDm8y+65OMvtow/u/52xXaCbdUb7ljWmYRrN11k=;
 b=OfaIQ5nFc6q2MHkmmYyc11nktToLIW+x3EkYoXIwzsj2S6lyz8VZrqXssXhFnF5mv04nSJ+W7nXUHYiCPGlveA5E62E7GKWTCRqy93Y1G8NPgEQEoeEgf6I5SbQJQKO/S99liw48Nns5IBwvYX+rasI8wxZbbV/jTkQ4a+1ntCmC09GZVtgFXfQ0+v3d7F+aYkA0qDFZCVdtBluHI6kTXQ9J3Ujim8/jwY5eG7KLfw3XOIqwknYRclh0oF7OkwdNaCglSYehwO6TuMIaC0QK1IJ75NA3zH4Jf5pArjxcIMPfFYzJTFKE6YEFIV4jh1PE+/H/SEjCiNCVmA57PqX31Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com;
 dkim=pass header.d=vmware.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5LryRDm8y+65OMvtow/u/52xXaCbdUb7ljWmYRrN11k=;
 b=1xYA4yuEn+8487A2sKcqXVys35B9SeN95Ikl7uefkclUxF7R03rRPB623HEtKGzhlHabyPw2KDc6aDF6V00WlZwmtcFiqHUEmkBIq0cu8ARP0P2k2eMMJzM3+xqMfvCaE4HGeEf3t3scDMIPOqHZ8d8lw5TExUek6Pgb21EnjvU=
From: Nadav Amit <namit@vmware.com>
To: Alexander Graf <graf@amazon.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>, Ajay Kaher <akaher@vmware.com>,
	"x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>, Srivatsa Bhat
	<srivatsab@vmware.com>, "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
	Alexey Makhalov <amakhalov@vmware.com>, Vasavi Sirnapalli
	<vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
	<er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
	<jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Index:
 AQHYx28G+J2WSwxm3kmFzqoOhSDYUK3dXFQAgBj77YCABouGgIAAKhGAgAD4GgCAAK7iAA==
Date: Tue, 4 Oct 2022 18:48:11 +0000
Message-ID: <DF8775A4-5332-412C-9359-749E96E83907@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
 <f1a7e603-2e64-fd2a-1100-f2898060e3f7@amazon.com>
In-Reply-To: <f1a7e603-2e64-fd2a-1100-f2898060e3f7@amazon.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vmware.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BY3PR05MB8531:EE_|DM6PR05MB6506:EE_
x-ms-office365-filtering-correlation-id: d5d88cfd-0020-437b-20fb-08daa638fcb5
x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 yUkOPRZfOWa7TMe9u6E+zE8eWAgB2mNeP+wgcJ+/Yw9ueVfZK6haCABVNj/vlWESgQ4eUqw+gBq4/D3I0ECl3/9kPwrE/R8ubaNv0JiuN2XYndjJy65g9+3VptWD9iwh3zmgwOVoJYysoYXfdOLautz23qldH4Elu7+4raxobFBGQVVk/F71luw3XS8hAlaxfLaF8sn3ZAzb3MVxk0mBQVP+ojLI9FPovukpVSnMYyggXxFDHOhof8y2t0w12dmzRkGkBzfaInec/YW3e1HqN6B7wqeH3a6/tXYxW0GUuDOmhAfCWMK3ZLeRHKS/cW7EEUsnwpQWvGzzwtA6xrS+nZNLpOKpUrEepWOLB+ldYeWfp/bv6qBiOHFAjV2JQGOoeZH1cymF+T1GaUJxvzJ/MecexlUnoXjREwnIVQR0TK/76j/Gj+E8Mq+4OdYjDURF+xf9Ho4vXi3b2j82Xohu7KOWG33WBl70ThFfLXfdDNervkygUW68CDgaSDfKpL/ku3mtSkzxuDZm7nlsK3RSbXKvExPDs6nDo0X5joFgsAgxknPuHfwWwR05pSkoEdDX3twISc9yATqLn/8KJiXRV7k8T78I4PfwWTtCt3hGXRId9dEM0hUtPI0MeSbYmFG90mrTfDvaXJxoy36YR7FoA/Zb15prxv3Rg3Vh1GgtakcgP2kuu7OSWCNOu0SyD1YHdKPMNUbNsJ3L/+9hNJVwjmRSdICwh9Mj6y54Z3jDwvrctPKIsl7s4dAA7X/AKDSodGik0IHcOQ3u0OQEuLZwuX+ONuHm5TRWKWRZNhc1uqRuQZ5+gX4wE3xLo2PfpmJfC46sZ9UHTZLpB9KHRvz6EJyh3HEWw5TGKK3K6D0xpI/MYwYbMTx3+J4UlaaFJlkoDFlIuiBS8mCQmD8mtcCv8x/uW1O3bqqbnoHXaDMk+iUqqNwa8mRCx2AfmtyYsZ78
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR05MB8531.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199015)(2616005)(86362001)(186003)(66476007)(76116006)(66946007)(83380400001)(66446008)(64756008)(38100700002)(66556008)(38070700005)(71200400001)(54906003)(966005)(5660300002)(122000001)(478600001)(4326008)(7416002)(8676002)(41300700001)(8936002)(6916009)(26005)(53546011)(316002)(6512007)(36756003)(2906002)(6506007)(6486002)(33656002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?UkRBVzVtb2cwWFN3ZXp2dnFYaWw2Qmw0L00zaDZFZDBHbjB5T0d1MStnZ1Nj?=
 =?utf-8?B?WkZKM3VqTDNrYW9wR3VGakFKNzhqejNNYmc1TmZ0NEwvRFlGTVpoUHp2UHJj?=
 =?utf-8?B?V3k0b2MyNEV3MXFBMGpJak5INnBjZzJFaTBvZWdOb2tGS3o5SjEyRmQ4cGtk?=
 =?utf-8?B?emF0TmlJSTVxam81VkVXbzdzbnJzV1VaS1FwSWFiNmdydHYwZ1ZvR2U2UXla?=
 =?utf-8?B?eTU2S0JCRTRTNkczRE1QamdhY0VGZWQ0T0p4U0dqUFBaemJQbWN4eXh3RmVB?=
 =?utf-8?B?TWR6Wis3QWJ6KzM3a1JTVFIvTUk4WGV2L0k2bTZYQXBtc1NBcHdQM2VaRFQy?=
 =?utf-8?B?VCszcks5dlpObmNDSXdrVXdiM2RNK2dud1BQZzZhd2NXZElLc2dSN201Rjgw?=
 =?utf-8?B?YWMyTHpQQ0c2RENBWFpodVVXODZYMUhhVkJqdmhpSnBqRUJsRWdCd3JZU1hH?=
 =?utf-8?B?ZTJUN2syZG1wbGhlYnQ1cXZTS3ZDOG5yQXFkTW9VcUd6WHUxbks3bTAzNHB1?=
 =?utf-8?B?SWJ3NlFEcU81KzJMb1J4b0J1bHo4SVh0N0dNNHIveVVmdU9KYTZMUXA2dTUv?=
 =?utf-8?B?QW1MWmY2d3dxOUcvanFWNUpUcXZRbFQwZi9SUExVZ09vN1VRTGQ4S091Z0dn?=
 =?utf-8?B?SllxVmlWRXJSKzErQjRCajRJMXFIRG5TcURGaGQ2dnZ3bUdpZmMvakVZeEJS?=
 =?utf-8?B?S1dIblNyR2RsQXN4TUZpb2xVRERtS0kxaGJOanJUaXJQaVJkT3VCaDExa0xa?=
 =?utf-8?B?TDgvTW9qZ0ZGditLcUpWd3hjQlR1QXRLKy9xMGJsMWNpK3NQL1lmMU5HektW?=
 =?utf-8?B?bDJYOFRhUXNEUWhxaisreGFtZk95bmNJelpyVnpIN2JzYnVlNDg1SFJ2d2lU?=
 =?utf-8?B?dmhYaDg3M0IxQ3drSXdXTU0zbFA0cjR2Y0wzem84S0tRYmZ0anF6YmlRSzB0?=
 =?utf-8?B?RXZ0YnNsVmQySnBzMU9WMXB5RzRQenAydVpTS2ZsWEIyNmovMUpIMVZiWnZK?=
 =?utf-8?B?dVBUOVgyUk5iTi9EejRTR0I3UzQxbGZTdVUybmNGUW9kMHorTFhWMEt5YUNL?=
 =?utf-8?B?eXdvbXhITC9GbDh2QVJOOXBiUXowSi8yM1cxYmdZSjV1cDFMM0V1Slc5M0d2?=
 =?utf-8?B?ekROVDF0MlRpcm03eTdVRThMTlAweUZSczN0TU5nNEpHUjVtNmNwZllWWVhR?=
 =?utf-8?B?a3JYZ3NJQzZ4Tml6TkFuYmhCZmJBV0hrelpIMUJWcm1uRWcrNjhqUmZNNFR1?=
 =?utf-8?B?Zzhhd0ZlUUhEbHlsVEcwanNVTVBZK0h0U1UxSFErS1dpQXhabVIzcTI1Tnkw?=
 =?utf-8?B?ZWd4VW1Bc21tbi9kdjN3dTRpcjZweFB6MXdSNC9oaU8zUFBzYVlmRDNVRS9o?=
 =?utf-8?B?NEtOR1lURThDRG1pMWZpS1gvMmRoYjJ2Uk9HcUluNnl3UkFZeDE4TCtqcHlM?=
 =?utf-8?B?NFR6TVZkczl6T0FmTnY4bWJQeTdUb1dUZW9ucTIwc21PTkppcDJ5emFWa1B2?=
 =?utf-8?B?M3piZExEM2g4b0dwUnRQR2hMc2pvU0FqQ3p3TW8zSC9LeFhla0RDZE1IbGt2?=
 =?utf-8?B?OHBmZ1F2My9Yem9pNFIwc1U3SlgwT1VuUGtqY3NXbGdBUTNhNG1FQmIyYkRX?=
 =?utf-8?B?RnJjYkRJang0QjJEYzJBTzBBdVo5Ky92eDJYRitwTVhxYkhVUGI3ZnhnVlJE?=
 =?utf-8?B?em81MDN3bGRyTWVUbUIyazF2dHB0N1ZqZy9pSytLeHRDWndNOEVwTGJGZlMr?=
 =?utf-8?B?V2p1VjVTdnEzMkJsOWl6K0ZpM0xvVlJpOWtFTTJxdUVhV1FDMjJHTlZSeXlU?=
 =?utf-8?B?K0tBZ1ptREJYVURRaXIrdG1PTFBSd0pQcWcxcTVXczR4K3FqcXlteHNsZk5E?=
 =?utf-8?B?V2JYOUxCSlJjeFhlaTBoOFpENTdLMXZkTjk5UHZINy80QVFCYzIxR2NIZE1K?=
 =?utf-8?B?YmJpRVMrRlNTWE5qVTh4S3U5VzI5TXZ3VHF1Vit2eUNIUFdDTTVoZkFYRTlY?=
 =?utf-8?B?MEhDQTVvY3d2Y2h4d3BBUXRzWXh2UDl4ak1BRVdCQk93UjZYNjRERmR1Z1VS?=
 =?utf-8?B?T04vL2hseHl5NS9JQVFYN0UvRmVwaDVyL3E0UURiWDdYa0FwbVduajc5NHFz?=
 =?utf-8?Q?304/N3MbaDAjuFkXfuYs4BRy/?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4170C95495E7224CB50BF35570867FBA@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5d88cfd-0020-437b-20fb-08daa638fcb5
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 18:48:11.3829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nQd9N0EHsEM5bd9MDUlqtEYo78OtJmXmyR3tvUaz61ImDGbTaqnPAv3ScHoCX7bPjEdaH6cWyMLxtcK1MqjfJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB6506

T24gT2N0IDQsIDIwMjIsIGF0IDE6MjIgQU0sIEFsZXhhbmRlciBHcmFmIDxncmFmQGFtYXpvbi5j
b20+IHdyb3RlOg0KDQo+IOKaoCBFeHRlcm5hbCBFbWFpbA0KPiANCj4gSGV5IE5hZGF2LA0KPiAN
Cj4gT24gMDMuMTAuMjIgMTk6MzQsIE5hZGF2IEFtaXQgd3JvdGU6DQo+PiBPbiBPY3QgMywgMjAy
MiwgYXQgODowMyBBTSwgVml0YWx5IEt1em5ldHNvdiA8dmt1em5ldHNAcmVkaGF0LmNvbT4gd3Jv
dGU6DQo+PiANCj4+PiBOb3QgbXkgYnV0IHJhdGhlciBQQ0kgbWFpbnRhaW5lcidzIGNhbGwgYnV0
IElNSE8gZHJvcHBpbmcgJ2NvbnN0JyBpcw0KPj4+IGJldHRlciwgaW50cm9kdWNpbmcgYSBuZXcg
Z2xvYmFsIHZhciBpcyBvdXIgJ2xhc3QgcmVzb3J0JyBhbmQgc2hvdWxkIGJlDQo+Pj4gYXZvaWRl
ZCB3aGVuZXZlciBwb3NzaWJsZS4gQWx0ZXJuYXRpdmVseSwgeW91IGNhbiBhZGQgYQ0KPj4+IHJh
d19wY2lfZXh0X29wc19wcmVmZXJyZWQoKSBmdW5jdGlvbiBjaGVja2luZyBzb21ldGhpbiB3aXRo
aW4gJ3N0cnVjdA0KPj4+IGh5cGVydmlzb3JfeDg2JyBidXQgSSdtIHVuc3VyZSBpZiBpdCdzIGJl
dHRlci4NCj4+PiANCj4+PiBBbHNvLCBwbGVhc2UgY2hlY2sgQWxleCcgcXVlc3Rpb24vc3VnZ2Vz
dGlvbi4NCj4+IEhlcmUgaXMgbXkgdGFrZSAoYW5kIEFqYXkga25vd3MgcHJvYmFibHkgbW9yZSB0
aGFuIG1lKToNCj4+IA0KPj4gTG9va2luZyBicmllZmx5IG9uIE1DRkcsIEkgZG8gbm90IHNlZSBh
IGNsZWFuIHdheSBvZiB1c2luZyB0aGUgQUNQSSB0YWJsZS4NCj4+IFRoZSB0d28gb3B0aW9ucyBh
cmUgZWl0aGVyIHRvIHVzZSBhIHJlc2VydmVkIGZpZWxkICh3aGljaCB3aG8ga25vd3MsIG1pZ2h0
DQo+PiBiZSB1c2VkIG9uZSBkYXkpIG9yIHNvbWUgT0VNIElELiBJIGFtIGFsc28gbm90IGZhbWls
aWFyIHdpdGgNCj4+IFBDSV9DT01NQU5ELk1FTU9SWT0wLCBzbyBBamF5IGNhbiBob3BlZnVsbHkg
Z2l2ZSBzb21lIGFuc3dlciBhYm91dCB0aGF0Lg0KPj4gDQo+PiBBbnlob3csIEkgdW5kZXJzdGFu
ZCAoYWx0aG91Z2ggbm90IHJlbGF0ZSkgdG8gdGhlIG9iamVjdGlvbiBmb3IgYSBuZXcgZ2xvYmFs
DQo+PiB2YXJpYWJsZS4gSG93IGFib3V0IGV4cGxpY2l0bHkgY2FsbGluZyB0aGlzIGhhcmR3YXJl
IGJ1ZyBhIOKAnGJ1Z+KAnSBhbmQgdXNpbmcNCj4+IHRoZSBwcm9wZXIgaW5mcmFzdHJ1Y3R1cmU/
IENhbGxpbmcgaXQgZXhwbGljaXRseSBhIGJ1ZyBtYXkgZXZlbiBwdXNoIHdob2V2ZXINCj4+IGNh
biB0byByZXNvbHZlIGl0Lg0KPiANCj4gDQo+IEkgYW0gYSBsb3QgbW9yZSBjb25jZXJuZWQgd2l0
aCBob3cgd2UgcHJvcGFnYXRlIGl0IGV4dGVybmFsbHkgdGhhbg0KPiB3aXRoaW4gTGludXguIElm
IHdlIGhhcmQgY29kZSB0aGF0IGFsbCBMaW51eCBrZXJuZWxzIDYuMisgdGhhdCBhcmUNCj4gcnVu
bmluZyBpbiBWTXdhcmUgcHJlZmVyIEVDQU0gb3ZlciBQSU8sIHdlIGxvY2sgb3Vyc2VsdmVzIGlu
dG8gdGhhdA0KPiBzdGFuY2UgZm9yIGJldHRlciBvciB3b3JzZSwgd2hpY2ggbWVhbnM6DQo+IA0K
PiAqIEFsbCBwYXN0IGFuZCBmdXR1cmUgdmVyc2lvbnMgb2YgYW55IFZNd2FyZSBoeXBlcnZpc29y
IHByb2R1Y3QgaGF2ZSB0bw0KPiBhbHdheXMgYWxsb3cgRUNBTSBhY2Nlc3MgZm9yIGFueSBQQ0ll
IGNvbmZpZyBzcGFjZSB3cml0ZQ0KPiAqIE5vIG90aGVyIGh5cGVydmlzb3IgYmVuZWZpdHMgZnJv
bSBhbnkgb2YgdGhpcyB3aXRob3V0IHVwc3RyZWFtIGNvZGUgY2hhbmdlDQo+ICogTm8gcmVhbCBo
YXJkd2FyZSBwbGF0Zm9ybSBiZW5lZml0cyBmcm9tIHRoaXMgd2l0aG91dCB1cHN0cmVhbSBjb2Rl
IGNoYW5nZQ0KPiANCj4gQnkgbW92aW5nIGl0IGludG8gTUNGRywgd2UgY2FuIGNyZWF0ZSBhIHBh
dGggZm9yIHRoZSBvdXRzaWRlIGVudmlyb25tZW50DQo+IHRvIHRlbGwgdGhlIE9TIHdoZXRoZXIg
aXQncyBzYWZlIHRvIHVzZSBFQ0FNIGFsd2F5cy4gVGhpcyBvYnZpb3VzbHkNCj4gZG9lc24ndCB3
b3JrIHdpdGggTUNGRyBhcyBpdCBzdGFuZHMgdG9kYXksIHdlJ2QgaGF2ZSB0byBwcm9wb3NlIGFu
IE1DRkcNCj4gc3BlYyBjaGFuZ2UgdG8gdGhlIFBDSSBTSUcncyAiUENJIEZpcm13YXJlIFNwZWNp
ZmljYXRpb24iIHRvIGFkZCB0aGUNCj4gcmVzcGVjdGl2ZSBmaWVsZC4gRnV0dXJlIFZNd2FyZSB2
ZXJzaW9ucyBjb3VsZCB0aGVuIGFsd2F5cyBleHBvc2UgdGhlDQo+IGZsYWcgLSBhbmQgaWYgeW91
IGZpbmQgaXQgYnJva2VuLCByZW1vdmUgaXQgYWdhaW4uDQo+IA0KPiBQdXR0aW5nIGFsbCBvZiB0
aGUgbG9naWMgb24gd2hpY2ggc3lzdGVtIHBvdGVudGlhbGx5IHByZWZlcnMgRUNBTSBvdmVyDQo+
IFBJTyBjb25maWcgc3BhY2UgYWNjZXNzIGludG8gTGludXggaXMganVzdCBhIGJpZyBoYWNrIHRo
YXQgd2Ugc2hvdWxkDQo+IGF2b2lkIGFzIG11Y2ggYXMgcG9zc2libGUuDQoNClRoYW5rcyBBbGV4
LiBZb3UgcmFpc2UgaW1wb3J0YW50IHBvaW50cy4gTGV0IG1lIHRyeSB0byBicmVhayBkb3duIHlv
dXINCmNvbmNlcm5zIHNsaWdodGx5IGRpZmZlcmVudGx5Og0KDQoxLiBFbmFibGluZyBNTUlPIGFj
Y2VzcyBzaG91bGQgYmUgc2VsZWN0aXZlLCBhbmQgcG90ZW50aWFsbHkgY29udHJvbGxlZCBieQ0K
dGhlIGh5cGVydmlzb3IuIFRoZSB2ZXJ5IGxlYXN0IGEgImNoaWNrZW4tYml04oCdIGlzIG5lZWRl
ZC4NCg0KMi4gUENJIFNJRyB3b3VsZCBjaGFuZ2UgaXRzIHNwZWNpZmljYXRpb25zIHRvIGFkZHJl
c3MgdW5jbGVhciBoYXJkd2FyZSBidWcuDQoNCkkgdGhpbmsgKDEpIG1ha2VzIHNlbnNlIGFuZCB3
ZSBjYW4gZGlzY3VzcyBkaWZmZXJlbnQgd2F5cyBvZiBhZGRyZXNzaW5nIGl0Lg0KQnV0ICgyKSB3
b3VsZCBub3QgaGFwcGVuIGluIGEgcmVhc29uYWJsZSB0aW1lbGluZSBhbmQgc2VlbXMgdG8gbWUg
YXMgYW4NCnVubmVjZXNzYXJ5IGNvbXBsaWNhdGlvbi4NCg0KQnV0IGJlZm9yZSB3ZSBkaXNjdXNz
IGhvdyB0byBhZGRyZXNzIHRoZSBpc3N1ZSwgcGVyaGFwcyB3ZSBuZWVkIHRvIGZpcnN0DQp1bmRl
cnN0YW5kIGl0IGJldHRlci4gSSBhbSBub3Qgc3VyZSB0aGF0IEkgdW5kZXJzdGFuZCB0aGlzIE1N
SU8gYnVnLCBhbmQgc28NCmZhciBub2JvZHkgd2FzIGFibGUgdG8gcHJvdmlkZSBleGFjdCBkZXRh
aWxzLg0KDQpTbyBJIHdlbnQgdG8gaGF2ZSBhIGxvb2suIEl0IG1pZ2h0IG5vdCBiZSBzdXBlciBo
ZWxwZnVsLCBidXQgZm9yIHRoZSByZWNvcmQsDQpoZXJlIGlzIHdoYXQgSSBjb2xsZWN0ZWQuDQoN
CkZpcnN0LCB3ZSBoYXZlIGNvbW1pdCBkNmVjZTU0OTFhZTcxZCAoImkzODYveDg2LTY0IENvcnJl
Y3QgZm9yIGJyb2tlbiBNQ0ZHDQp0YWJsZXMgb24gSzggc3lzdGVtc+KAnSkuIEl0IHRyaWVkIHRv
ICJ0cnkgdG8gZGlzY292ZXIgYWxsIGRldmljZXMgb24gYnVzIDANCnRoYXQgYXJlIHVucmVhY2hh
YmxlIHVzaW5nIE1NIGFuZCBmYWxsYmFjayBmb3IgdGhlbS7igJ0gSW50ZXJlc3RpbmdseSwgaXQN
CnNlZW1zIHNpbWlsYXIgdG8gRnJlZUJTRCBjb2RlIChjb21taXQgMmQxMDU3MGFmZTJiM2UpIHRo
YXQgYWxzbyBtZW50aW9ucyBLOA0KYW5kIGhhcyBzaW1pbGFyIGRldGVjdGlvbiBsb2dpYyBpbiBG
cmVlQlNE4oCZcyBwY2llX2NmZ3JlZ29wZW4oKS4NCg0KVGhlbiBjb21taXQgYTBjYTk5MDk2MDk0
NzAgKCJQQ0kgeDg2OiBhbHdheXMgdXNlIGNvbmYxIHRvIGFjY2VzcyBjb25maWcNCnNwYWNlIGJl
bG93IDI1NiBieXRlc+KAnSkuIFRoZSBjb3JyZXNwb25kZW5jZSBbMV0gbWVudGlvbnMgc29tZSBi
dWdzOiBBVEkNCmNoaXBzZXQsIFZJQSBjaGlwc2V0LCBJbnRlbCAzIFNlcmllcyBFeHByZXNzIGNo
aXBzZXQgZmFtaWx5IGFuZCBzb21lIHJlcG9ydHMNCm9uIE52aWRpYS4gSXQgdHVybmVkIG91dCBz
b21lIGRldmljZXMgaGFkIHByb2JsZW0gcHJvYmluZyAtIHRvIGZpZ3VyZSBvdXQgaWYNCk1NSU8g
aXMgYnJva2VuIC0gdGhlIHdheSB0aGUgcHJldmlvdXMgcGF0Y2ggZGlkLg0KDQpBbGwgb2YgdGhl
c2UgYnVncyBhcmUgY2lyY2EgMjAwOCwgb2YgY291cnNlLiBBbmQgbm90ZSB0aGF0IEZyZWVCU0Qg
ZGlkIG5vdA0KdGFrZSBhIHNpbWlsYXIgcGF0aC4gVGhlIGNvcnJlc3BvbmRlbmNlIGFyb3VuZCBM
aW51eCBwYXRjaCBpcyBlbmRsZXNzLiBJDQphZG1pdCB0aGF0IEkgZGlkIG5vdCB1bmRlcnN0YW5k
IHdoZXRoZXIgZXZlbnR1YWxseSB0aGUgaXNzdWVzIHdlcmUgZm91bmQgdG8NCmJlIHBlci1idXMg
b3IgcGVyLWRldmljZS4NCg0KDQpCYWNrIHRvIHRoZSBtYXR0ZXIgYXQgaGFuZC4gVGhlIGJlbmVm
aXQgb2YgdXNpbmcgdGhlIE1DRkcgYXBwcm9hY2ggdGhhdCB5b3UNCnByb3Bvc2UgaXMgdGhhdCBp
dCBjYW4gZW5hYmxlIG5hdGl2ZSBzeXN0ZW1zIHRvIHVzZSBNTUlPIGFzIHdlbGwuIEhvd2V2ZXIs
DQpzaW5jZSB0aGUgbGlzdCBvZiBidWdzIGlzIHVuY2xlYXIgYW5kIHRoZSBwcm9ibGVtcyBtaWdo
dCBiZSBkZXZpY2Utc3BlY2lmaWMsDQppdCBpcyBub3QgY2xlYXIgd2hhdCBpbmZvcm1hdGlvbiBC
SU9TZXMgaGF2ZSB0aGF0IExpbnV4IGRvZXNu4oCZdC4gSW4gb3RoZXINCndvcmRzLCB0aGUgYmVu
ZWZpdCBvZiBnZXR0aW5nIGl0IGludG8gdGhlIHNwZWNpZmljYXRpb25zIGlzIHF1ZXN0aW9uYWJs
ZSwNCmFuZCB0aGUgY29tcGxleGl0eSt0aW1lIGlzIGhpZ2guDQoNCkNhbiB3ZSBhZ3JlZSB0aGF0
IHRoZSBmZWF0dXJlIHdvdWxkIGJlIGVuYWJsZWQgZXhwbGljaXRseSBieSB0aGUgaHlwZXJ2aXNv
cg0KYW5kIExpbnV4IHdvdWxkIGVuYWJsZSBpdCBiYXNlZCBvbiB0aGUgaHlwZXJ2aXNvciBpbnB1
dCAodGhyb3VnaCBzb21lDQpjaGFubmVsPykNCg0KVGhhbmtzLA0KTmFkYXYNCg0KWzFdIGh0dHBz
Oi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDA4MDExMjE0NDAzMC5HQTE5Mjc5QGp1cmFzc2ljLnBh
cmsubXN1LnJ1L1QvI3U=


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 19:27:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 19:27:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415789.660440 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofnZp-0004wY-2e; Tue, 04 Oct 2022 19:27:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415789.660440; Tue, 04 Oct 2022 19:27:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofnZo-0004wR-VS; Tue, 04 Oct 2022 19:27:36 +0000
Received: by outflank-mailman (input) for mailman id 415789;
 Tue, 04 Oct 2022 19:27:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofnZn-0004wH-Rv; Tue, 04 Oct 2022 19:27:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofnZn-0001yQ-OZ; Tue, 04 Oct 2022 19:27:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofnZn-0004ru-9J; Tue, 04 Oct 2022 19:27:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofnZn-0003mN-8o; Tue, 04 Oct 2022 19:27:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bXS62iZdPrYxBl2ENt+5ldZaQZSEULuN1gYpyf3/cQ0=; b=0FOzMiFmvG82qQXCM5uYuXNaoY
	BSs0BGHWzrojtwC45AhR735P75SSDHsPqao2hU9NE5gFWJEYtdLVYE9FfXb1685H8NWIIO/z0fhPB
	OmeaCSt8EKMvLH48PZF8Wgq+9m+v+qW4wbqIjTaITBWncIYv6cCNPZ6rA2ICydpye37k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173418-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173418: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=769879e2a6761277b8099014ad8bc426d23dc50b
X-Osstest-Versions-That:
    ovmf=12973359d02d59c0f856b1c1dd6d0ad2f85cdab9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 19:27:35 +0000

flight 173418 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173418/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 769879e2a6761277b8099014ad8bc426d23dc50b
baseline version:
 ovmf                 12973359d02d59c0f856b1c1dd6d0ad2f85cdab9

Last test of basis   173406  2022-10-03 18:40:36 Z    1 days
Testing same since   173418  2022-10-04 17:13:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michael Kubacki <michael.kubacki@microsoft.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   12973359d0..769879e2a6  769879e2a6761277b8099014ad8bc426d23dc50b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 19:47:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 19:47:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415798.660450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofnsp-0007Lh-Mx; Tue, 04 Oct 2022 19:47:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415798.660450; Tue, 04 Oct 2022 19:47:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofnsp-0007La-KC; Tue, 04 Oct 2022 19:47:15 +0000
Received: by outflank-mailman (input) for mailman id 415798;
 Tue, 04 Oct 2022 19:47:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=clK+=2F=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1ofnsn-0007LU-Jg
 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2022 19:47:13 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 55fb2754-441d-11ed-9377-c1cf23e5d27e;
 Tue, 04 Oct 2022 21:47:11 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 294JK5UC029090;
 Tue, 4 Oct 2022 19:46:45 GMT
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jxbyn78ud-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 04 Oct 2022 19:46:45 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5)
 with ESMTP id 294IQePV001021; Tue, 4 Oct 2022 19:46:44 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id
 3jxc04rp7g-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 04 Oct 2022 19:46:44 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by CO1PR10MB4659.namprd10.prod.outlook.com (2603:10b6:303:6c::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 4 Oct
 2022 19:46:41 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::2b18:d3d0:c806:401f]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::2b18:d3d0:c806:401f%9]) with mapi id 15.20.5676.030; Tue, 4 Oct 2022
 19:46:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55fb2754-441d-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 to : cc : references : from : subject : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2022-7-12;
 bh=wHBTo+ambuPpT2lbGLdnXGa6zDb6J6Fzm8H0eKJTR/M=;
 b=vSq3NLWZkE/7orIbiydQkiK3hl7OlWZekkkurJHhn7vLpyMsFrXCoj8QuTZ+xSHQtXK5
 xSCHRkQ9vwcOY396Fekq61rhPRNtoOhEZ2edM5rFC9x/hbqYAYxlJXK3MHcUWRXV0gjN
 mR0LRmr7+rMlRTqb/SBf9fyUx1RbkOiQxs3azFYyfPoO9zQB84PKw+9nTuu8k1Bh2tTD
 Yc57wfkG5NHMdfXISpoIZAcNoOVjkB1VFpBHiEg/icJ6gySSUUTU5D2ndATzPOPgwi7P
 cQUlfEEUquAV0A8KiPT/NTO3AdCHx1uDLABwCwYN4XG7AnpKsZB9VUA055fda1KPFi9D FQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PQrVdZAZSAri+Losi/0Pvw3GlqF/bI28fd4J1V3lg2eiGqWPba8h8L+Fdtecu4Lbrc+Q9yblmDdBuLyHM/bhyjO2J7SyeZiKmBerx4i/TtwFy5Ga0mdNGBZGiywaeHa2sX1B8Pom3i0QoAw3FxnQkTunzMI+THEMit6oG9Wug5SPBXngsyHJTrWX3hfLccoOWS+TAs+ZXTsmhO7ce0W8kyoMWeFm+jwr6Q97hw/e2ce9wl5UY6aiQ77/yeFyHN0Rrwi/w55pW46mbhO/0QXqMmeHHbu5vqHV9IhdUP1Cpc+nEmOxKK4NRFYTrkldVK0m6IGrAGrpMEit08VrpsT+og==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wHBTo+ambuPpT2lbGLdnXGa6zDb6J6Fzm8H0eKJTR/M=;
 b=DsBXvW1AYhUzSCARo6WRaDn1wIpHJj1KhKARrU7bRwFUXSOKPSXd2FPt0gq/AOsJaMCs/y/da6kCFK9AzSfLzNKUu8l4gIIRGpdIUasavnzPh1VNUhmjmHxuD/zst5nZDlpzxjmM3FlqhPcqH3hxPhukClH0HZz8FqW0IJWV+5r11XRCaDkM178okB0F1pyhG++aEezoEpDxFAnwTQ2fHIo+JRSUWRcqEJGB4ka2KLlOZFJzJjoOnoW53wx9D3N3wzOipEZQGOuZaI/IfGm4nx8bTGHSUKlIyY/WdhPfjmaPqyQ7zBflcmVoTPvHqFHcNyCqeAJUZJ2LXJTiTdQZrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wHBTo+ambuPpT2lbGLdnXGa6zDb6J6Fzm8H0eKJTR/M=;
 b=g8ZCymw26mAl64tV4RATtcs8vS42rnObOkY54zPXaiZNP9L3BSOldl5vIyf9d5rj4IV6GeffCcGNPplb4F+7NrgOAMDUMAT2ZhA5LzAsiYxgJ8Zu7lnxG1dqtBkCq6bzii/rZXg7ClzV0rnZG+RIGXb6kES15VL38Ctelu6Np5c=
Message-ID: <25d4aa73-ee2c-9890-164a-89fddcbe133e@oracle.com>
Date: Tue, 4 Oct 2022 15:46:36 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org
References: <20221004084335.2838-1-jgross@suse.com>
 <20221004084335.2838-2-jgross@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 1/3] xen/pv: allow pmu msr accesses to cause GP
In-Reply-To: <20221004084335.2838-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DS7PR06CA0035.namprd06.prod.outlook.com (2603:10b6:8:54::9)
 To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|CO1PR10MB4659:EE_
X-MS-Office365-Filtering-Correlation-Id: 3fcf1b1c-3b35-4fea-4548-08daa64127f7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	q8xJAOLRsM7R51NTF223+aaiSXZvPUDUyGnMy0DDa6q1smiCjVigSYNKtqGydMuKLBk6C/L1vnWgIBx5QySEWRC2tIFO/jN/JuNTLrUtibmLxx/LZdN53j24JJ9+hOXGLfAn5qFVsECFaJKojdtVanlD7Ta/Wr8URybbDoRpOV9ZmiyfJb748/Ji/3Ocwvo3nQJQexAzM2ZrxxxhIRS/G0eCMnUru110tAGzy17siGoAIebOnE9hWx1FVtZ9/9EWNA2Wz20xsUk3qtHDXPJhQDCBnbCJ49yUNBePJsU++/Rdx/ZYGblzjoDuRxIPpmvbZvFhgaDHXR5nC3tgT71T17Q/b49R/oY8TkpvAoVO/UvqzinuiVAzu+SQ1xGAGBEI3Az+RRNUxe7tQMtZrT2TB62IuAX71R4U1kcaN90DSR1aPqzSh9D5U1/pM2PDUz6z+UNDm3HKAi7F9BgLKtpQJ7+cS8CET8kYE8KibuCXW7nCF1ecljd0pmPRBTSrx7Nk/8Zpx/8U/0Frfdx4wHKcge5dgtyVNo516m6xhYrr0VKN5oPLNnboKnRYysX7Vs+R5C7iPiwV5AQuvV6NaY2HRrB2bwEKCSPZkOysPHSJ7lLqatAIs076IMuFZuJrvUh43gNXnRgP65DNrZZXPBxF6dNbVCe82U+GniPp+oPGZkBvZ1KVF89p+fbH7PusWNtfFo47joYCrmjiJ/d4LXae2WMiKHpxoGIk9Stz4RFs+6smmFvf3ScvKkrwEWPo6mjhP5c0gdS4rSkD4Tb8VWFHCzGyFVw4TYdBdU+93y02Xw4=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(39860400002)(136003)(376002)(451199015)(26005)(44832011)(2616005)(186003)(2906002)(41300700001)(6512007)(4326008)(6666004)(36756003)(8936002)(6506007)(53546011)(5660300002)(8676002)(66476007)(66946007)(66556008)(38100700002)(4744005)(31696002)(86362001)(478600001)(6486002)(31686004)(316002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?N25IaSt4cU5IY3U3N1liUDdpbjZ0SGVaWlN6RkY0dTVtcGlXNTBvdEVqK2VZ?=
 =?utf-8?B?alBRNC9LZ3NnZmErdE1xMUtwenIwT2syVi9Qdm9RTDk5L3dzZUFGbFlGMEtj?=
 =?utf-8?B?bGtLQ0p5djJvRGpwdENyb3M0ZmNXdUhaeDcwV0QzRGNtdHZCL0FnL0ZhRHpm?=
 =?utf-8?B?SUJsSmdGVmtKRjVYWHFYZVh4RFZaRjV0bzRRR21JY2ZjYzZnUTRoNjFVUlFh?=
 =?utf-8?B?N0ppaWd6eFFkRXhjdGxlS3pudTMwcitiYS9kemdqREppa1MxVW5EOTFkcHdk?=
 =?utf-8?B?ZWcvTXA5YnIwRnhpNXorTDBwWFJhUXR2MnJlSmpTcFluR2ZyTXgzTWFWZTBO?=
 =?utf-8?B?OG44clp1M3plTVg5a3k1aGpCMVI1QVVOWCtyeWdmMld0cEZvbEJKWmdQN1V4?=
 =?utf-8?B?eGdnSGlpdTVFT2s1VWZudGFJV2JCUE9JbVM2STl0U29RcGdUWmNYOU9xWE5P?=
 =?utf-8?B?VUd1dDQvVFNTWDNTcUxEVmhzTkNteVV5UkZCeUFGYVBUbTVsRjc3bkdjTno2?=
 =?utf-8?B?VS9UaGdYd3JiNEpwY3BWNFlJN0dtM3FMYkhDK1p4U2tsdjE3WHpEQzdtUWhj?=
 =?utf-8?B?bWg1MWd4ajdibTVWWjF4ZWhURmUza0N2M0czTkQvVE1DMklMeUpKOXRrbUh0?=
 =?utf-8?B?UUJJY1E3Rzc0OC9odEM4d0xCRWJhWmJjb3k3bkk0ZGxzcFp4Y3RzRU1HUDRp?=
 =?utf-8?B?T1pLSmxpdnlWeTc2ZGh3Z2lkMzN2cmRSS2NXdVZZdzJNUU9mTnhMcXBTdDZo?=
 =?utf-8?B?T2RvcWg3Z3NVSldWZ2lMU0hBWnFITWJtYmx2ZmJoaTdDa2xHbHVkUlN1cWp6?=
 =?utf-8?B?SFlrMjVIanN6SUZ5bVVKZlVMSjB6MVZXNWZyZnBwd2N3c2xLZWlkOXp6aWM3?=
 =?utf-8?B?N0NaT0ZuR0Uzblg3QU42YXhCd1ZLYWJMVjBoZ3FDZ3MySmJSdHBuaXpKTFpV?=
 =?utf-8?B?L2Y3UE5sYWVodTc1aGRZNFNudTNMTWhRZVdHNlBDZ0w4MDFGOU1pUlQ1bE1E?=
 =?utf-8?B?SHB1bE9YdHFwZEFEelhLU3VmTGVCNHdrZWZDWjFUQXVBekFaU3RoUFVucjFm?=
 =?utf-8?B?VnNXZjk4S1BJc2pyUll5VDJ3TnpUWXI2RjJycnpQMjR1S3JVL256YXlZYnJ6?=
 =?utf-8?B?WHZscGp3MUJwaThSVUFiZ0E2MUZvdGo1a0FVV29KVWtDS2NJazEvWGluYWV4?=
 =?utf-8?B?aHhWWWIzUzB3Sjh3QzBtQmRRbmpPRWd2emx2YXFnQkhLTU10Q1dzeGJHTVMx?=
 =?utf-8?B?a0tHaFFjMXl3MFIwem1qTlg2YkpyQWNHbUIxOGNzZjllcTZCYVhkVVFESmYr?=
 =?utf-8?B?SThGbHBuVUlGMVZwRGw5ZDFoY0xibUtaNXY3eXNLdGlVeWlrbU5PU1dQNC9L?=
 =?utf-8?B?VkhBNmR3L0lVc2VFWUpMcnF0NkRNU0p6MUZBWUVIOWtCNk5JNjd6UC9EOFE0?=
 =?utf-8?B?UVBwdWFhVFJWQkI1OXRUd3RLS2crN2xOZ2pkTG43bEwybEJlMk5NZThCK2NK?=
 =?utf-8?B?RjdZWXI4M0pCWG02eWY4M3lYSEtPU0NBVXJPdm9EQUxzaUREMTA4SWZKUG1j?=
 =?utf-8?B?NGYzVDhlMXpobTVDd2xSTDJiVTNGQU5kVDhySStlSlRJVmZzYmE4MEZnamE5?=
 =?utf-8?B?eWJPcG1GVHNKM2lnbFN1elM0RGdVdk91RDlhZGh2MHpVZHhYZm5KMnM0MHpt?=
 =?utf-8?B?QWJDNDg1TjZQbFVnbTI1M1hwVjJoMUVlVHdYTzVlNGtYbGdXU2ZJdmtJUkRy?=
 =?utf-8?B?STZMV25nc1FqdWU3NGNDK3d4OTVkNlNsTXJpREZTSnVyWjRJWHJzYmhOS0Zr?=
 =?utf-8?B?RFBjKzBndThRelhXVVdFNVMxaGpCd0dMeWV0akYrSkRxSU5DaTBqakc1RFdF?=
 =?utf-8?B?ejRRYzNnSWF1bm03bjh2MS9uL3p4VHgyTU1KU1I2MjdTRjRDQnRNeG9IWGRQ?=
 =?utf-8?B?VVFhS1hqUzB4b3lzenAwZ1p1ZHFiS21ocVIrMit3dXdSSUw0WGhZMU5YOU1D?=
 =?utf-8?B?VTA4ZWlxM0wvUEhCSE92ajg2UXdkcWlZTWJUVDZXbnFnSUtRWFpjbnduNThB?=
 =?utf-8?B?aVpScXFWNUFuRlRIdFBTQkpJeGJZRjlnRStVeFE3UzFCRGI5NDRUbmlERDF6?=
 =?utf-8?B?M3A0M1AxckNPN3N1VExhYjlubzhJN0FPT2UyODYwcjlnc1liSHIyek9adzNY?=
 =?utf-8?B?Z3c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	=?utf-8?B?d2xyNjdxRFhsc291b0xOMzdPRDJUcCtQU1dtc2kvM3dSTHFweEpENEsvcDZM?=
 =?utf-8?B?bnl2WGNDd0h0dlVRMnUxSDV2eWRnL0t3RUlsRVczSUpib3hWeEdpRE1mN1dF?=
 =?utf-8?B?QUM5QVdyM29ITExhYWRNQVhpSjdIVTVMeEVTN01rRCtkVVNUNm5keHExN1p6?=
 =?utf-8?B?cnJuNFhLWDNOcDZialhxTTBRcXJjTDJqQ0l5L0MyaVFQQmpPK05tQjRRMytZ?=
 =?utf-8?B?UkhvYTIvbDhNaUNGN2Q4bkt5d1pLYjNLdFdvUXQ4ZFhxL2VLRWpBSkM1VGlN?=
 =?utf-8?B?VHZQNXZSbFhuRzl2Z3hwU2ZhZDh3eG9wanJzOC92L1dYTkpvZXlla0FnSGlU?=
 =?utf-8?B?VG01M2NHNFBZV2kyRTZPaDFXSnlWVGdaTHhsWm1RNzRoME80bjBpSXo5TmhF?=
 =?utf-8?B?aU00elV4L1ZzelpRT1pnQkFaNWhHUU14aUFBQ0ZCRmt6WUNzVU9JODZPb01l?=
 =?utf-8?B?RGRNSjc1cEhBMEROcmlBaUhCMTRET0ZqOWZmZFplajUyOTVnTmFWK1oxL25x?=
 =?utf-8?B?dHlDRmxkQUhCaUY4ZWUxeVJ5bG5BNU94VkJpYUwxSE0xdkEvTEVLc1lTeHN6?=
 =?utf-8?B?SnBDZk14Sk5TNXZYUlRIZFJieHhaYjIwMHoySk5oUFRBd0xpcE14ZVBsNnFm?=
 =?utf-8?B?UkFtQ1l5bUY2MFE0WU5SU0FMSVhiSGpkV3p1Wm5Ld1N6cVM4bFE3TkNtcURH?=
 =?utf-8?B?RnVMMCtMMW01dngzV3lqTGZvVWVZWXhDR3o2ZGJyTzZnUFRXbDYzeUZqT3RX?=
 =?utf-8?B?QmgvNW9aQjZYZVhmMXdRNTNRNklMdGF0R0hnNHExZFFBdWIvcitYSklxbjYw?=
 =?utf-8?B?eFhiSU5iU1l4VGpvMXRScDJzOUZJdHM2ai9kRmlMWUtodldYNncvN1FXOGpZ?=
 =?utf-8?B?N0JMS1JJeXFkQmhpRTFxdTBSSm5VSGtiQ1IvQ2FuclF1S3VWNUZpYWlKb3hu?=
 =?utf-8?B?M0krWVFicEtFMUU5WDczaEpueExsOWpOQlZrTmpYMExidWx5YXpOSjc3a0tw?=
 =?utf-8?B?Y3NBNklNLzN2QXdVK2R4dEVGankvdmF2ZmdWVVlaRmRiQnhlNmdFOGRqVW4z?=
 =?utf-8?B?SHRBbGtkcVQ4dE41WXhWcEpoNmVaWmZhQ2JickZxUXdFMVlDMk1wdjlVNWVp?=
 =?utf-8?B?b3M1UytTTWpGKzNBcFB1NGpORmRQdy8xTjVzeUZrZjNxWHRucFltczlYNGRN?=
 =?utf-8?B?QjBPSmxiUjBGbmtoa2hVR0IrVzQ2ajAyNisraHY5NXdsWkVGUitMS2U4a0Ux?=
 =?utf-8?B?ZUs3TFFWYWhJN1U4UWhkYlloRGFDcDl3azdGMHJxeEFFU3d5UDE2TXNzYlJ2?=
 =?utf-8?B?aS90YVZDSkMwdG1CS1lYZmcydVUxUnI5cEYrNytEQkdNRGFSNWRIVC9PektS?=
 =?utf-8?B?a1o1L3pPWms4OFE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fcf1b1c-3b35-4fea-4548-08daa64127f7
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 19:46:40.1041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vrxHo5LWr0J8kXXf4b6MTf3qMV29lYEmMsMRhwfNKtv0txmvmIEqOjGVZ1ZMulDpusEoiJcFQWFEPxpx6dqGtdbHfXoDii++ncul4kN1GbM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4659
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-04_09,2022-09-29_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999
 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210040128
X-Proofpoint-GUID: AXT1R_4cVe_UAdcfACBE2fsro7jX7t37
X-Proofpoint-ORIG-GUID: AXT1R_4cVe_UAdcfACBE2fsro7jX7t37


On 10/4/22 4:43 AM, Juergen Gross wrote:
>   
>   bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err)
>   {
> -	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
> -		if (is_amd_pmu_msr(msr)) {
> -			if (!xen_amd_pmu_emulate(msr, val, 1))
> -				*val = native_read_msr_safe(msr, err);
> -			return true;
> -		}
> -	} else {
> -		int type, index;
> +	int type, index;
> +	bool emulated;
>   
> -		if (is_intel_pmu_msr(msr, &type, &index)) {
> -			if (!xen_intel_pmu_emulate(msr, val, type, index, 1))
> -				*val = native_read_msr_safe(msr, err);
> -			return true;
> -		}
> +	if (is_amd_pmu_msr(msr))
> +		emulated = xen_amd_pmu_emulate(msr, val, 1);
> +	else if (is_intel_pmu_msr(msr, &type, &index))
> +		emulated = xen_intel_pmu_emulate(msr, val, type, index, 1);
> +	else
> +		return false;
> +
> +	if (!emulated) {


You can factor this out even further I think by moving if/elseif/esle into a separate routine and then have 'if (!xen_emulate_pmu_msr(msr, val, 1))' (and pass zero from pmu_msr_write())


-boris





From xen-devel-bounces@lists.xenproject.org Tue Oct 04 21:38:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 21:38:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415806.660462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofpcX-00015H-K9; Tue, 04 Oct 2022 21:38:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415806.660462; Tue, 04 Oct 2022 21:38:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofpcX-00015A-HV; Tue, 04 Oct 2022 21:38:33 +0000
Received: by outflank-mailman (input) for mailman id 415806;
 Tue, 04 Oct 2022 21:38:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofpcV-000150-Pr; Tue, 04 Oct 2022 21:38:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofpcV-0004Lm-LX; Tue, 04 Oct 2022 21:38:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofpcV-0001dD-4Y; Tue, 04 Oct 2022 21:38:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofpcV-0007jA-46; Tue, 04 Oct 2022 21:38:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RHHpTLSds7CdbxBYuwjTBUWtU2BxwayjsCnGWsA5G1k=; b=KrzlYtJ4lt16riamZm5PvLYbCQ
	IGxKznhSpv/alUin41MMBtaLcrf65Ob2MzuFvVDG91I8e8VDJ5jErTfLxzKhKVio7euwnHL0TNfhC
	hKl5+byvYwEIwOD/Tod57MgYsD+t9o65WTuIKXKiE9LIRh7oZ1yU/bhoeFGs9ITuL7Ts=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173420-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173420: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f931506815548cee5a3929856bfc98266c39999c
X-Osstest-Versions-That:
    ovmf=769879e2a6761277b8099014ad8bc426d23dc50b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 21:38:31 +0000

flight 173420 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173420/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f931506815548cee5a3929856bfc98266c39999c
baseline version:
 ovmf                 769879e2a6761277b8099014ad8bc426d23dc50b

Last test of basis   173418  2022-10-04 17:13:19 Z    0 days
Testing same since   173420  2022-10-04 19:41:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michael Kubacki <michael.kubacki@microsoft.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   769879e2a6..f931506815  f931506815548cee5a3929856bfc98266c39999c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 04 23:50:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 04 Oct 2022 23:50:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415815.660473 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofrfm-0005Ca-52; Tue, 04 Oct 2022 23:50:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415815.660473; Tue, 04 Oct 2022 23:50:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofrfm-0005C6-1L; Tue, 04 Oct 2022 23:50:02 +0000
Received: by outflank-mailman (input) for mailman id 415815;
 Tue, 04 Oct 2022 23:50:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofrfk-00052h-K5; Tue, 04 Oct 2022 23:50:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofrfk-0006pv-EJ; Tue, 04 Oct 2022 23:50:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofrfj-0005Md-Q4; Tue, 04 Oct 2022 23:49:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofrfj-0007uI-Pf; Tue, 04 Oct 2022 23:49:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=w8vEELi/ev5gbdmSpNeMrGA8JvKxzTUQw0BHGqZOijU=; b=MsyodiIaM6j04kZ97MJMCOpMfc
	2bjejHmdGvkIYNrxqrqy1CmW2hZ/4ncPom4WDbY0hBHJlntR7HoEISoHWffl65fnpyQYPJWCQfuS/
	pZHKChSrYfz5a888pnRubGUFyPIShYVjrDkTJj9w5FxWOLEdkKOSVXaNdNJhZPEo5ApQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173419-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173419: trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:<job status>:broken:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3eba620e7bd772a0c7dc91966cb107872b54a910
X-Osstest-Versions-That:
    linux=725737e7c21d2d25a4312c2aaa82a52bd03e3126
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 04 Oct 2022 23:49:59 +0000

flight 173419 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173419/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-amd64    <job status>               broken
 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken REGR. vs. 173414

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173414
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173414
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173414
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173414
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                3eba620e7bd772a0c7dc91966cb107872b54a910
baseline version:
 linux                725737e7c21d2d25a4312c2aaa82a52bd03e3126

Last test of basis   173414  2022-10-04 08:14:24 Z    0 days
Testing same since   173419  2022-10-04 17:40:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexandre Belloni <alexandre.belloni@bootlin.com>
  Alexei Starovoitov <alexei.starovoitov@gmail.com>
  Ashok Raj <ashok.raj@intel.com>
  Bjorn Helgaas <bhelgaas@google.com>   # pci_ids.h
  Borislav Petkov <bp@suse.de>
  Colin Ian King <colin.i.king@gmail.com>
  Cristian Marussi <cristian.marussi@arm.com>
  Daniel Sneddon <daniel.sneddon@linux.intel.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  Fei Li <fei1.li@intel.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Ingo Molnar <mingo@kernel.org>
  James Morse <james.morse@arm.com>
  Jane Chu <jane.chu@oracle.com>
  Jason Baron <jbaron@akamai.com>
  Jason Wang <wangborong@cdjrlc.com>
  Jiri Slaby <jslaby@suse.cz>
  Josh Hant <joshuahant@gmail.com>
  Kees Cook <keescook@chromium.org>
  Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
  Kristen Carlson Accardi <kristen.c.accardi@intel.com>
  Li kunyu <kunyu@nfschina.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Luciano Leão <lucianorsleao@gmail.com>
  Mateusz Jończyk <mat.jonczyk@o2.pl>
  Neelima Krishnan <neelima.krishnan@intel.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Qiuxu Zhuo <qiuxu.zhuo@intel.com>
  ran jianping <ran.jianping@zte.com.cn>
  Reinette Chatre <reinette.chatre@intel.com>
  Rik van Riel <riel@surriel.com>
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Shaopeng Tan <tan.shaopeng@fujitsu.com>
  Stephen Kitt <steve@sk2.org>
  Thomas Gleixner <tglx@linutronix.de>
  Tony Luck <tony.luck@intel.com>
  Uros Bizjak <ubizjak@gmail.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vincent Mailhol <mailhol.vincent@wanadoo.fr>
  Xin Hao <xhao@linux.alibaba.com>
  Youquan Song <youquan.song@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    broken  
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken
broken-step test-amd64-amd64-xl-qemut-debianhvm-amd64 host-install(5)

Not pushing.

(No revision log; it would be 1955 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 01:37:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 01:37:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415827.660484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oftLr-0001FC-AM; Wed, 05 Oct 2022 01:37:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415827.660484; Wed, 05 Oct 2022 01:37:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oftLr-0001F5-6h; Wed, 05 Oct 2022 01:37:35 +0000
Received: by outflank-mailman (input) for mailman id 415827;
 Wed, 05 Oct 2022 01:37:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=QrJL=2G=runbox.com=m.v.b@srs-se1.protection.inumbo.net>)
 id 1oftLo-0001Ez-Kq
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 01:37:33 +0000
Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com
 [2a0c:5a00:149::26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 465ffc8f-444e-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 03:37:30 +0200 (CEST)
Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com)
 by mailtransmit05.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <m.v.b@runbox.com>)
 id 1oftLj-00FUOw-M0; Wed, 05 Oct 2022 03:37:27 +0200
Received: from [10.9.9.74] (helo=submission03.runbox)
 by mailtransmit03.runbox with esmtp (Exim 4.86_2)
 (envelope-from <m.v.b@runbox.com>)
 id 1oftLi-0003QS-O0; Wed, 05 Oct 2022 03:37:26 +0200
Received: by submission03.runbox with esmtpsa [Authenticated ID (536975)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1oftLg-0004oN-CR; Wed, 05 Oct 2022 03:37:24 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 465ffc8f-444e-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com;
	 s=selector2; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=O9KbrdN6Sv+jKKGOZ8bbe4wvldYZw53ghGEW82CqbRY=; b=DsvfWcJYzTkSWMnZCNR8TC9gG1
	GjqnEO+Z9mre5oLVpHhzb514dVMUZk8oYJVFLZxL/M5fbJkpSC3j2rMoh02rSF2TbYyfn2pbo59kd
	M7YwgZHDf4bWt2xZpJwZkOwAq3B/aHAft1TLf1ZGnLosZKIGX4GMGQPAam6go2gpYy7EmAwJNJC/d
	oLpLHAzvXZQnvvY7IoYcQDJ0vsg4p3rFBY+Gq/eq0eo+tOlauSp8bn4c4xLclRB69USOKuY7i4prP
	K0vuBYz42wpYyEFUmAAVs+Ivijgf9+1niVZzwUzhbBxxUb8XyPshkHtAgECoGaCj6FyCGP4NjmNvw
	Gtvu2jsw==;
Message-ID: <fdc85c53-4025-bbf9-5ec6-f767f7521217@runbox.com>
Date: Tue, 4 Oct 2022 21:37:22 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
Content-Language: en-CA
To: Demi Marie Obenour <demi@invisiblethingslab.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Gerd Hoffmann <kraxel@redhat.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-2-m.v.b@runbox.com> <YzotDube4gTn7r9b@itl-email>
 <41d15ac1-7977-db49-f8e9-df642616c745@runbox.com>
 <YzuRuD/t4/rZAkGG@itl-email>
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
In-Reply-To: <YzuRuD/t4/rZAkGG@itl-email>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2022-10-03 21:51, Demi Marie Obenour wrote:
> On Mon, Oct 03, 2022 at 09:31:25PM -0400, M. Vefa Bicakci wrote:
>> On 2022-10-02 20:29, Demi Marie Obenour wrote:
>>> On Sun, Oct 02, 2022 at 06:20:05PM -0400, M. Vefa Bicakci wrote:
>>>> Prior to this commit, if a grant mapping operation failed partially,
>>>> some of the entries in the map_ops array would be invalid, whereas all
>>>> of the entries in the kmap_ops array would be valid. This in turn would
>>>> cause the following logic in gntdev_map_grant_pages to become invalid:
>>>>
>>>>     for (i = 0; i < map->count; i++) {
>>>>       if (map->map_ops[i].status == GNTST_okay) {
>>>>         map->unmap_ops[i].handle = map->map_ops[i].handle;
>>>>         if (!use_ptemod)
>>>>           alloced++;
>>>>       }
>>>>       if (use_ptemod) {
>>>>         if (map->kmap_ops[i].status == GNTST_okay) {
>>>>           if (map->map_ops[i].status == GNTST_okay)
>>>>             alloced++;
>>>>           map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
>>>>         }
>>>>       }
>>>>     }
>>>>     ...
>>>>     atomic_add(alloced, &map->live_grants);
>>>>
>>>> Assume that use_ptemod is true (i.e., the domain mapping the granted
>>>> pages is a paravirtualized domain). In the code excerpt above, note that
>>>> the "alloced" variable is only incremented when both kmap_ops[i].status
>>>> and map_ops[i].status are set to GNTST_okay (i.e., both mapping
>>>> operations are successful).  However, as also noted above, there are
>>>> cases where a grant mapping operation fails partially, breaking the
>>>> assumption of the code excerpt above.
>>>>
>>>> The aforementioned causes map->live_grants to be incorrectly set. In
>>>> some cases, all of the map_ops mappings fail, but all of the kmap_ops
>>>> mappings succeed, meaning that live_grants may remain zero. This in turn
>>>> makes it impossible to unmap the successfully grant-mapped pages pointed
>>>> to by kmap_ops, because unmap_grant_pages has the following snippet of
>>>> code at its beginning:
>>>>
>>>>     if (atomic_read(&map->live_grants) == 0)
>>>>       return; /* Nothing to do */
>>>>
>>>> In other cases where only some of the map_ops mappings fail but all
>>>> kmap_ops mappings succeed, live_grants is made positive, but when the
>>>> user requests unmapping the grant-mapped pages, __unmap_grant_pages_done
>>>> will then make map->live_grants negative, because the latter function
>>>> does not check if all of the pages that were requested to be unmapped
>>>> were actually unmapped, and the same function unconditionally subtracts
>>>> "data->count" (i.e., a value that can be greater than map->live_grants)
>>>> from map->live_grants. The side effects of a negative live_grants value
>>>> have not been studied.
>>>>
>>>> The net effect of all of this is that grant references are leaked in one
>>>> of the above conditions. In Qubes OS v4.1 (which uses Xen's grant
>>>> mechanism extensively for X11 GUI isolation), this issue manifests
>>>> itself with warning messages like the following to be printed out by the
>>>> Linux kernel in the VM that had granted pages (that contain X11 GUI
>>>> window data) to dom0: "g.e. 0x1234 still pending", especially after the
>>>> user rapidly resizes GUI VM windows (causing some grant-mapping
>>>> operations to partially or completely fail, due to the fact that the VM
>>>> unshares some of the pages as part of the window resizing, making the
>>>> pages impossible to grant-map from dom0).
>>>>
>>>> The fix for this issue involves counting all successful map_ops and
>>>> kmap_ops mappings separately, and then adding the sum to live_grants.
>>>> During unmapping, only the number of successfully unmapped grants is
>>>> subtracted from live_grants. The code is also modified to check for
>>>> negative live_grants values after the subtraction and warn the user.
>>>>
>>>> Link: https://github.com/QubesOS/qubes-issues/issues/7631
>>>> Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")
>>>
>>> Looks like this patch has been pretty buggy, sorry.  This is the second
>>> time there has been a problem with it.  Thanks for the fix.
>>
>> Hi,
>>
>> No problem! :-) Debugging this issue and coming up with a fix was a
>> nice challenge for me.
> 
> You’re welcome!  I’m glad you were able to do this.
> 
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
>>>> ---
>>>>
>>>> Changes since v1:
>>>> - To determine which unmap operations were successful, the previous
>>>>     version of this patch set the "unmap_ops[i].status" and
>>>>     "kunmap_ops[i].status" fields to the value "1" prior to passing these
>>>>     data structures to the hypervisor. Instead of doing that, the code now
>>>>     checks whether the "handle" fields in the same data structures were
>>>>     *not* set to "INVALID_GRANT_HANDLE". (Suggested by Juergen Gross.)
>>>> ---
>>>>    drivers/xen/gntdev.c | 22 +++++++++++++++++-----
>>>>    1 file changed, 17 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
>>>> index 84b143eef395..eb0586b9767d 100644
>>>> --- a/drivers/xen/gntdev.c
>>>> +++ b/drivers/xen/gntdev.c
>>>> @@ -367,8 +367,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
>>>>    	for (i = 0; i < map->count; i++) {
>>>>    		if (map->map_ops[i].status == GNTST_okay) {
>>>>    			map->unmap_ops[i].handle = map->map_ops[i].handle;
>>>> -			if (!use_ptemod)
>>>> -				alloced++;
>>>> +			alloced++;
>>>>    		} else if (!err)
>>>>    			err = -EINVAL;
>>>> @@ -377,8 +376,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
>>>>    		if (use_ptemod) {
>>>>    			if (map->kmap_ops[i].status == GNTST_okay) {
>>>> -				if (map->map_ops[i].status == GNTST_okay)
>>>> -					alloced++;
>>>> +				alloced++;
>>>>    				map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
>>>>    			} else if (!err)
>>>>    				err = -EINVAL;
>>>> @@ -394,8 +392,14 @@ static void __unmap_grant_pages_done(int result,
>>>>    	unsigned int i;
>>>>    	struct gntdev_grant_map *map = data->data;
>>>>    	unsigned int offset = data->unmap_ops - map->unmap_ops;
>>>> +	int successful_unmaps = 0;
>>>> +	int live_grants;
>>>>    	for (i = 0; i < data->count; i++) {
>>>> +		if (map->unmap_ops[offset + i].status == GNTST_okay &&
>>>> +		    map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE)
>>>> +			successful_unmaps++;
>>>> +
>>>>    		WARN_ON(map->unmap_ops[offset + i].status != GNTST_okay &&
>>>>    			map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE);
>>>>    		pr_debug("unmap handle=%d st=%d\n",
>>>> @@ -403,6 +407,10 @@ static void __unmap_grant_pages_done(int result,
>>>>    			map->unmap_ops[offset+i].status);
>>>>    		map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
>>>>    		if (use_ptemod) {
>>>> +			if (map->kunmap_ops[offset + i].status == GNTST_okay &&
>>>> +			    map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE)
>>>> +				successful_unmaps++;
>>>> +
>>>>    			WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay &&
>>>>    				map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE);
>>>>    			pr_debug("kunmap handle=%u st=%d\n",
>>>> @@ -411,11 +419,15 @@ static void __unmap_grant_pages_done(int result,
>>>>    			map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
>>>>    		}
>>>>    	}
>>>> +
>>>>    	/*
>>>>    	 * Decrease the live-grant counter.  This must happen after the loop to
>>>>    	 * prevent premature reuse of the grants by gnttab_mmap().
>>>>    	 */
>>>> -	atomic_sub(data->count, &map->live_grants);
>>>> +	live_grants = atomic_sub_return(successful_unmaps, &map->live_grants);
>>>> +	if (WARN_ON(live_grants < 0))
>>>> +		pr_err("%s: live_grants became negative (%d) after unmapping %d pages!\n",
>>>> +		       __func__, live_grants, successful_unmaps);
>>>>    	/* Release reference taken by __unmap_grant_pages */
>>>>    	gntdev_put_map(NULL, map);
>>>> -- 
>>>> 2.37.3
>>>
>>> Is there a possibility that live_grants could overflow, as it is now
>>> set to a value twice as large as what it had been previously?
>>
>> Good point! My answer in summary: I think that the code could be improved,
>> but with reasonable values for the "limit" module parameter, there should
>> not be issues.
>>
>> Grant mappings are set up via ioctl calls, and the structure field that
>> holds the number of grant references has u32 type:
>>
>> (Quoting from kernel v5.15.71 for convenience)
>> include/uapi/xen/gntdev.h
>> === 8< ===
>> struct ioctl_gntdev_map_grant_ref {
>> 	/* IN parameters */
>> 	/* The number of grants to be mapped. */
>> 	__u32 count;
>> === >8 ===
>>
>> However, the number of grant references is further limited in the actual
>> ioctl handler function gntdev_ioctl_map_grant_ref(), which calls
>> gntdev_test_page_count() to ensure that the number of granted pages
>> requested to be mapped does not exceed "limit". "limit" defaults to 64K,
>> which should be okay to use with an atomic_t type (i.e., a 32-bit signed
>> integer type) like "live_grants", assuming that the system administrator
>> does not go overboard and set "limit" to a very large value:
>>
>> drivers/xen/gntdev.c
>> === 8< ===
>> static unsigned int limit = 64*1024;
>> module_param(limit, uint, 0644);
>> MODULE_PARM_DESC(limit,
>> 	"Maximum number of grants that may be mapped by one mapping request");
>>
>> /* trimmed */
>>
>> bool gntdev_test_page_count(unsigned int count)
>> {
>> 	return !count || count > limit;
>> }
>>
>> /* trimmed */
>>
>> static long gntdev_ioctl_map_grant_ref(struct gntdev_priv *priv,
>> 				       struct ioctl_gntdev_map_grant_ref __user *u)
>> {
>> 	/* trimmed */
>>
>> 	pr_debug("priv %p, add %d\n", priv, op.count);
>> 	if (unlikely(gntdev_test_page_count(op.count)))
>> 		return -EINVAL;
>>
>> 	/* trimmed */
>> }
>> === >8 ===
>>
>> To be fair, the "count" field of the gndev_grant_map structure is a signed
>> integer, so very large values of count could overflow live_grants, as
>> live_grants needs to accommodate values up to and including 2*count.
> 
> Could this be replaced by an unsigned and/or 64-bit integer?
> Alternatively, one could use module_param_cb and param_set_uint_minmax
> to enforce that the limit is something reasonable.  That said, one needs
> almost 8TiB to trigger this problem, so while it ought to be fixed it
> isn’t a huge deal.  Certainly should not block getting this merged.

Thank you for the continued feedback.

I agree that these can be implemented to prevent overflowing "live_grants".
"live_grants" could be made an atomic64_t, and/or a to-be-chosen maximum
value less than or equal to INT_MAX/2 can be imposed on "limit" using the
approach you suggested.

I think that the latter option could be better, as the driver uses signed
integers in a number of places (including the gntdev_grant_map structure),
but the requested number of mappings (i.e., "count" in
ioctl_gntdev_map_grant_ref, provided by user-space) and "limit" are
unsigned integers.

> 
>> drivers/xen/gntdev-common.h
>> === 8< ===
>> struct gntdev_grant_map {
>> 	atomic_t in_use;
>> 	struct mmu_interval_notifier notifier;
>> 	bool notifier_init;
>> 	struct list_head next;
>> 	int index;
>> 	int count;
>> 	/* trimmed */
>> }
>> === >8 ===
>>
>>> If not, you can add:
>>>
>>> Acked-by: Demi Marie Obenour <demi@invisiblethingslab.com>
>>
>> Thank you! I hope that the explanation and rationale above are satisfactory.
>> Please let me know what you think.
> 
> They are indeed.

Thanks!

Vefa


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 06:15:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 06:15:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415834.660495 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofxgb-0003Ad-2D; Wed, 05 Oct 2022 06:15:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415834.660495; Wed, 05 Oct 2022 06:15:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofxga-0003AW-U4; Wed, 05 Oct 2022 06:15:16 +0000
Received: by outflank-mailman (input) for mailman id 415834;
 Wed, 05 Oct 2022 06:15:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofxgZ-0003AQ-HF
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 06:15:15 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80080.outbound.protection.outlook.com [40.107.8.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12888416-4475-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 08:15:13 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU0PR04MB9393.eurprd04.prod.outlook.com (2603:10a6:10:358::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct
 2022 06:15:09 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 06:15:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12888416-4475-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KXP9lYxsmpdTgO3rr/vm4vGzNyUAddXFrZyUejpfne0Zu8buOZkr5uDg48bt0kfSjTaCazWnBzPd76vjqwoqqD3t5f1coTGmUTuGyJjs13mGNnVA0xjq2jrp7QccKnONhzW9tHlIScy6/JZJ27mr9I68+QXQ3cWrMcVnpfrHeYnJWfzNVvxAEcmJhJpFCPKBmrdQlxhetOcr0LAcrsoXNXTr7l9d5kNET7Yp9cFo/BjJcqjP6Jpqp/WCPucL5MwMXWADkD8sBPv9NMn0BP0rVocjnXj5W7XoEDzPQiOC/WJiAAG3hZYtBDJ3dTkpZLsTIA1MEF7yEpumR09HQPmXog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/SXlFQl4ElpS1x8Q77iosu7H/vrhFX98uDhyfXvAEh8=;
 b=WWpbK2bCGpaPfEQGBL7HZWLEuGr4TgHQG8MVDHUFX6zxJll2wde/Civlb4nQsZ8jd84nSgxnCGxBL4GmoSMB+MZPCrfkRbxIcfRgQPWcFl0KAnuTuHKichJEJZYupTiyWbThjFbdvA6/kkR8Y/ERthXSUHmji6oWe4RlAD9f5/W//P8Xs25CGfQZvTQEMfQ1MjqqLx+yFKc13D4oou4mswhPGSuS4JKSrdFZS3r3h2X2CdDR7Dk60EIKucTqA+Gz7NuvCbjU+sZVPJU4hEhE9M8KZykStRfSzwV9f+aITh+g/r6Ib0vnHK2lW0JSmVYju0EOwb/vJ46Wvg/xcidWmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/SXlFQl4ElpS1x8Q77iosu7H/vrhFX98uDhyfXvAEh8=;
 b=FaJ3Oqr8E2l3LARB18Kd9WKGRP4bktG83QxCSDe5oM0M3MRRxok8KbIV/KI8CclYO65TNM8X91yxuwTsAR8UBjg7tPrDGoSgvWzSZNNmlBKuNXEYVsbucvF/CjGWVeQvykzALdhJlpmAgGCNy1wBq0RIeapFB1TqmEzH04SPG0uyNzfKzblpcIOzxjWIlsplRjV/kNKO9l3Q5UDidDW52DN48/nWK0YRy3z01GvOKh2+6Z2kamMDrW5HBDTiDXqOBN4zMpfONWrd9b+Fw+fd0Kx9v8D28kuAPcbQVOXMQ0RH4lcjFbOKsWmh5Fy687IezCBYSBPB8urOgu4aGfiRUA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
Date: Wed, 5 Oct 2022 08:15:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Kees Cook <keescook@chromium.org>, Anton Vorontsov <anton@enomsg.org>,
 Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Ard Biesheuvel <ardb@kernel.org>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email> <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YzxxXuovwQt3NskE@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0068.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::45) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9393:EE_
X-MS-Office365-Filtering-Correlation-Id: 0835cd15-f700-4106-9e1c-08daa698f466
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4vo1HzMyv/qinf7IyNE/3yk9T9AlOH22Rq+caV4MfitWCvdf+WIYxEmLIvB2c1TSwEQhZpyP5T3SM8vHKPZ9nTPfGCGk3qpToWNixO+9cKVwFRCrSsvSZW3Xz1TmV5zZt7IurwGb/qVAS19Qn+y139OhcozyhxKnhyV9lQxTzTyO0n4sbvdSDLcQyYk1Bb9rXbyC7LNx0BCtOq/TGMZT8jCgk2oMHn9mZ0nrOPgy9o8Ai18rojxU29dEh5XjSqBh/M0rf6/UspSVAr2ECWcPCqx8/LkyKchvPFg6hwOqPEtog4qaTgGfRxdXno/JM6LdFCSCT8i3xYjjxurxfdEiZ7sgex4KyIRJLQAr2dmdxaMatoB8uB7/DaUtXX3Ecft07ne4ELZohRQDOwShftO6yDbTPMNyNMZLjI4V7y/d736mZHUQ69Dxj2ybR8ZJy0BtTr7hnelpO+3s801KdjSut2Ekm/5DY4cfKJKfuSW3+dreIHKV/lSIEOdxcgseNpNO91VNiVYAVQ8TvxvMiDN7/0IEtrhtojORhNZ7Jb+UfffApUMQDZiG8ra6TSRSj4M3+2XbZ9qGxZWXvnePm/2Pm2CdecILrIn/YI+WqDdIhVm6CYuZnieAzd4hn2eL8EpCBzcigjjLbWuec50MzRtUzVGEH5iYyPv1Gmr7HA0hAd4h34groecgl6LIdEOw6XUkdUEKYJcKyVMm/nqfHSAeCJOhTQ++VquTn3BO6/zHqiOPcjjO+aJut0Bl3ZTzEEMVBu5to+90XV4IEJZnxcRhpU72suLaHU7w0uyR2xoUgi4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(6486002)(66946007)(66556008)(8676002)(66476007)(4326008)(2616005)(38100700002)(2906002)(36756003)(41300700001)(478600001)(186003)(53546011)(6506007)(26005)(6512007)(31696002)(86362001)(316002)(6916009)(54906003)(31686004)(5660300002)(8936002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bU9oUktpZFJ4enkvZy96MmZ1ZlBHTE5YYlFWa3l3MXJOb01YdnM0aGFyTE5y?=
 =?utf-8?B?TVhndmlMM3lOK1VqTlBqck1CR2prMkRqRWphU0VWU0c0TU41czlwS1FJV1k2?=
 =?utf-8?B?NUhRMEk0a0czWjJxSWxrTzY2YklKZVJqR0RpMW9iSm9wMmN0NDl6cCt1NHlT?=
 =?utf-8?B?THBqaWRaQnlTUkIyM3VnOE04YndxRVdwekp2Y3Y2aWk0ZGpuQlc5aWJZelZW?=
 =?utf-8?B?eW5EMHFnNmNLSVQwTEtoNXpKR3lQTVFyNzhxa0pDcHppZFZsRjYrTEtMNGl2?=
 =?utf-8?B?QXdFeDRUeHZwd1NLY0R6TmdxdmFFWlllTnhEaVpDZ3JwbHpncGlDWXFUMTlB?=
 =?utf-8?B?SVpVeWlHQlp5SkZXOG9GdTRPakc4YjVGaC9ZdE50T3BmSlRUUUZ4aUdOWXVj?=
 =?utf-8?B?SUJXYnVBTGZwd1U5Y1RiWDBIQkYveWQ0V1h0c055akpxdUJSa2xrdldvV3Qz?=
 =?utf-8?B?YWNXRkZ2WXFtNkhiN3hPazRZaE9uVkFzdFA1VW1sYzNnc3NzdFNEVkV1NWJr?=
 =?utf-8?B?WlBFVlFoaU4zZzdseE9HT0E2MXRTR0UwQ2RTL3FOb2xGTVR2Z214L3ZZRXps?=
 =?utf-8?B?UHhKSHc0b1dXdEZ0bHVsYWNlY0wvWTFtSlB3Q2hlSkRPd3VyYmFKV29iWlFD?=
 =?utf-8?B?RzNoZmp4WEpCTGZjdHFlRkluSkVZYXpxOWZtWjdJenZEL3VJclR6Wk5xbmY5?=
 =?utf-8?B?bkY1T09aZC9rWm0wdk9Nc1BtYnhQcU5xdGdXTzBDRmFvV0RHeVRqeUNrd3BD?=
 =?utf-8?B?bUx4eU9wSUVqZzIwU05HUVBVbExlcVhpU2FGMlBhRUlVTDdoY2ROM2lSWG5H?=
 =?utf-8?B?c2pXcjdnZ1F6K2o3c3djRVpiMHY4dDhYcFlnSW9HUXp5Z1BWV09HRHBEbllk?=
 =?utf-8?B?WklEbDcrN25Zb0E5Y0JhcnZ2SUJEb3k2YnBGRzJUYzhCZkJSeTZSM3o4a3Rx?=
 =?utf-8?B?alZtckVZQ3dBb25VaXNHYXl6blRqS2JBOFVWQ2tDNEh1NGdab243bm9VdENs?=
 =?utf-8?B?WWRkeWd0U2NXT1E5WE41cDZrZ25OWUlvdkRMTFFMTUMvVXdmbWpBdVh5VnVs?=
 =?utf-8?B?OHRxczQvVVFoL1dycTRRcHNqRHpUOVczODBMWHUveXpPSmxycHpYRFNxb1RN?=
 =?utf-8?B?TjBrS1BtUGd5amlFQWtpRERXRGFJdGJEd1dzWEpSZzErSXlCaHBLM2Fqb09J?=
 =?utf-8?B?RVVWU0ZUM3RReXVvb0RnUTUvcGJqaFhNRnJmZHRJNUpWVUFzWUVZZGVRQm1H?=
 =?utf-8?B?ZXBtWElWZ00raEdvdkNJc0tOZzVERm1WdG5oeVRlMU9GZGZmaHJHSlVQNDJO?=
 =?utf-8?B?dHE3RTFNeGV4NkxqWTFpZFU3K0FrSkgyTXVDYkM1eVh3QXJnQmNRTWhyeUtE?=
 =?utf-8?B?RUEzbERndGVtRWNZWGo5WXZiQk1rUjF5ZkJEREdzVnkrWDBXRG1OeGRCMGxp?=
 =?utf-8?B?bWNTa0EzSkVSQXY5VTdtTkU1TFowa2Q2Q2ZzTkhlNVlKVGFTb2YrVzgrK0Ni?=
 =?utf-8?B?ODhsUjBoNlNqclFYajFJL0dGODE0c2Z1ZnR1UTdWVElNMENrTld2Y0NMQWVh?=
 =?utf-8?B?RXBTNFVnY05pRHBXTU9UMXZkZ3FQNVFSWmhoK3hrcUUrZ2ZIMVFRbXAzWmg1?=
 =?utf-8?B?dURHejd5b2xWNGJ0bGNMRXBCcVZMWHVYTHUvLzVvQjlCT2wxWDJwNWZYdUwy?=
 =?utf-8?B?M0Ird29hU3FzNDVpUExHSlk3OWI5VnR5WUFrdjRtbWJhM2JuYmRrZlVucFI1?=
 =?utf-8?B?MGJRSW9DYW1TcFMwaGpITHF5elJWeDNha2ZBTktBMkppVWdPNFdCTGwrUVkw?=
 =?utf-8?B?RlU0VVFWQ0psMGljcW95SVNDN29seXppU0Qxc1VJUlhYc1J5Y0tLTCs4R1dm?=
 =?utf-8?B?ZHBmeEZNQTNKSEpjMmw5MWx5cm9pbHNTczB6R242a0FCMW54YUlxWFd6bXlW?=
 =?utf-8?B?cjZzeG1jeTVDWEoxMWVZa1FrRE81cUtKS2Y4aWpYZEpPbzdXbVE5eDRXMHRK?=
 =?utf-8?B?N3N4SEtmKzQ5ZXo2eWxXQTBTZUVuamxxeUplRXFaSW5mNUxwUE5wWG5IakJ6?=
 =?utf-8?B?VCtvSEE1U1BFV0FRaWVGVHJlV3IzbFNwekVjUVNRV29XMVdDYUtZVjNWQmoy?=
 =?utf-8?Q?lKA8O7K3Kww7ox7bTlQvDh6dS?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0835cd15-f700-4106-9e1c-08daa698f466
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 06:15:09.3514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IycCBMlSWHwIZdo4FkcDpL/9Pn+pIEa2L1+B74Crwop13yJWp4OQ+V/di6mRQGEwyh42oVNZSehp7ln5R+vZng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9393

On 04.10.2022 17:46, Demi Marie Obenour wrote:
> Linux has a function called efi_mem_reserve() that is used to reserve
> EfiBootServicesData memory that contains e.g. EFI configuration tables.
> This function does not work under Xen because Xen could have already
> clobbered the memory.  efi_mem_reserve() not working is the whole reason
> for this thread, as it prevents EFI tables that are in
> EfiBootServicesData from being used under Xen.
> 
> A much nicer approach would be for Xen to reserve boot services memory
> unconditionally, but provide a hypercall that dom0 could used to free
> the parts of EfiBootServicesData memory that are no longer needed.  This
> would allow efi_mem_reserve() to work normally.

efi_mem_reserve() actually working would be a layering violation;
controlling the EFI memory map is entirely Xen's job.

As to the hypercall you suggest - I wouldn't mind its addition, but only
for the case when -mapbs is used. As I've indicated before, I'm of the
opinion that default behavior should be matching the intentions of the
spec, and the intention of EfiBootServices* is for the space to be
reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
that hypercall: It might use it for regions where data lives which it
wouldn't care about itself, but which an eventual kexec-ed (or alike)
entity would later want to consume. Code/data potentially usable by
_anyone_ between two resets of the system cannot legitimately be freed
(and hence imo is wrong to live in EfiBootServices* regions). In a way
one could view the Dom0 kernel as an "or alike" entity ...

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 06:59:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 06:59:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415841.660505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofyNV-0007W9-CN; Wed, 05 Oct 2022 06:59:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415841.660505; Wed, 05 Oct 2022 06:59:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofyNV-0007W2-9i; Wed, 05 Oct 2022 06:59:37 +0000
Received: by outflank-mailman (input) for mailman id 415841;
 Wed, 05 Oct 2022 06:59:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ofyNU-0007Vw-OZ
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 06:59:36 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80079.outbound.protection.outlook.com [40.107.8.79])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4520cf7b-447b-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 08:59:35 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7310.eurprd04.prod.outlook.com (2603:10a6:800:1a2::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct
 2022 06:59:32 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 06:59:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4520cf7b-447b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LraRoAvs/dQDK9qQIgiEgE1F72ZIQ/hWLhUKM0GZCNyyFPOkExoMV/ectFvNyCzfqFMEhLtUNXk3vik4G3hXVMspKJ6QLaiD+dG5sxhucmI012r18IbxWZKsh0gZqMVcBgfMyaUmKXIGNUX2cXjEg3HBakY7fONm+2lTB6tqqrrWEGDkkFPklJvzCuKARLXhXCrx/8LgkY0Q5W5sxv05H1pF8KHpBcKIP1ysB/+/BJ6vDrXPzj81oUtDRwLtYpGhrxS1c0pxYFR1vkG8bGZoeBXWJ56XZ+JRMf3y4u/JhkxBuGqdSc6rstjTziEwKQtAKq6+lFDuqqMdjOEMAd5OMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+lWY4fn9XkISJ5SD1K0i8GPSX23z5iFJTd7AaHj66C0=;
 b=DEkyZIPOqF4VVKEX8Ib6zCAmLi7UD+/dgokOxwZx0EYMr6bR4s2AcurdSTijakItEknthrTnDGw3KXoHIYD0NmN2PIdgIBRHaVO2JgsAa25WII47Ms+dmTor7a1jNRlW8lp5PZmpaj2XnwdlwKaaT7Fvw0mlbR2kN5is30UjzAW9LIEbZkF3FyrS1Ib0mlA4sBdKBEz5QFSwaQYSiEQeue2RyIY9Nj1tVXtq8Yst55tcrCg3sOV8rkBOA18G63/qnLP2X8LGXm0bCFQA5/eVaUeMigtsG8ZWORs/+5Wp6RVnDSKEsRRHrBuYQebxGKPBDczeNe+Uydi6O+El9wEb/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+lWY4fn9XkISJ5SD1K0i8GPSX23z5iFJTd7AaHj66C0=;
 b=y87DshhmZfjHtDryJSy/oyEoXr5EcOtM5eoF02FJ7DlQiY52I7MBaRjDeDp19pWRlctTDuG/X5vFmwl9vGHutLXCSmp8aC+m1b28b0WtdX7RqTc8VgxWz9bAY4LtYT+BvX39XTx8ln4nG8aBZk8AScxqo3VzIUfeTnIwsdb+ttKEkFdbfZXHa8NeK4CUvwQmUu/Yy0kwH7FnTZlnmHsz8jUC1qwHiZ+GsrGOT5PsNmsepm5ZLZUcSaKs+G7CYNks0UbuSaZ0d4Xqn7e34MAmSPeEm7Qi01cGOoAEzH+xhYPV6DegfSAKmkDoGq4mCcGOjMBvmzdAn0FesiAahEZk8g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <50324b35-5b75-18b6-6ee7-fbe9b5f5d662@suse.com>
Date: Wed, 5 Oct 2022 08:59:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221004160810.25364-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0064.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::34) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7310:EE_
X-MS-Office365-Filtering-Correlation-Id: 0daee8d3-3831-43e6-6475-08daa69f27ac
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BpKBxxcb0vmGvKxgGpRqPMdLwrd2/mwNQoYsX2pPUyp9O7G0SNwoLzTFf9rdJ044x83xjZ1PYVZswWF0XOkcLmJDoLPdu7fkDPkWPaVITZ3KBU8RgxI+1gMwHO608lQwvfuWtltHKXlDMYxHntrdBsDhW1ofrj7jsbv7nFPNua2wxLsNufJT+Zvh24h0OZGOlZG+BuvyP+3X8/1bbCmEE1CVXXvuTVplZczAIRI/BsBThUyilDCK8SsuX/rH884s8sCILn9742rPqhh4JmoLxmWu2Ty7JVCz+Q6W7CMhtQCjjS0iBwKhlW5gP7+vGZJfAm/am6eScVkxHaMki03inF4akhPCXt1184HYJwrTeOvsQyyNk1zNSMjVf8bHcl97znxUWo05KxoZgH3jB+8YFI5JPiPBUle2jgarz8wAv1KbtHtidZkNkixPilS7+715VExdxynkqzk9WWPqRdYP5WZaMH1URyFX55yMb6lQbqq87yokIdnVhjckS4/Lqa8bWb7QMnufmgaOZPm65pJ8TmpZKVuFyEBeeceGb5Gk7QeC88WWY0+oQrhCz4j4Dz53Oy6yD1J0i3LOvXXeBdkENhmi0AxLGFI/5iC8GDC+CpkvZjiU0+hbyxAH+hCH6hzELZ9X++mBr9b8VNMQNpVuuWZ/qu4aJQb2aolZAkD3GFxllxndiJJs0OAvcbfK0aObGmhZqZzbhxDEeXfNNCcHP8LyGJjD+FWUnpxVMpsuhdTY4kqDikNDSXJg+KUhSO7fCqAphz0zhQn+QYNjyqETNDXdYoOJmH0jmLjWKlSTshQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(366004)(396003)(39850400004)(451199015)(8676002)(41300700001)(54906003)(6916009)(6486002)(478600001)(36756003)(66946007)(66556008)(66476007)(4326008)(8936002)(316002)(5660300002)(38100700002)(6512007)(31696002)(26005)(2616005)(6666004)(53546011)(86362001)(6506007)(83380400001)(186003)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RC9TUGFlNTl5YU1KNy9td0pEY2dvLzd1bzdtSEVydXFUM1ZOTmFKV2NOeUUr?=
 =?utf-8?B?Vi9pYnJFdTg1ZmxpZjVsekswOGREV2RhRHd6Z1lhd3BadlJyMXdkWDdWV042?=
 =?utf-8?B?clhSdk12ZDM4cnc2TXhzV2ZEZjlIL2VycEVaZ2RxVGVNWTlCYWtzR05Xb0F4?=
 =?utf-8?B?Y3U1dVQxdUlMQmlVeWxjOGNDOENueTI0U1dsRm9IU0g3a0pLcVVEaFlRZ2Z5?=
 =?utf-8?B?NlAvMTA5Z0l0T3NLYUZYTG5rQUFiT1ErOTg1UFFqNDJDc3dYMzJzY2U2YVdF?=
 =?utf-8?B?SDg5aml1Z08rSWdJOXdZYVk5UmNISFBSMmg5aDFPdTNPaGxoYTZya20yUzla?=
 =?utf-8?B?K1duUzdQZzBoNG1lTWdnY2NYVzVSRitnNVRqUjNHbUNZM1Q5VWpLVGNMN0JB?=
 =?utf-8?B?R3ZOYmpaNEVVMXlMSjFBQzFNbU9HMDVaL1ZQNWZDbmFtY2laTlFNd0RMOHYy?=
 =?utf-8?B?ZUgyZlNYcGxYK3AxMlFiaXNwc2NHSFpSSTVId25jKzRySEZaOUNkbXdWRVFM?=
 =?utf-8?B?VkpEMXJ5YVZqbE5JS1FiU1NIM0dMSlh1TW9uRUVPVmhFRUhUQy8vVzJlb3ZC?=
 =?utf-8?B?VHNzZTFXLytRek1FdTV1V2tVVFlQYkZMc20xc3JzUWhOVWdZM3BCVGpVQUhK?=
 =?utf-8?B?cWhtRWpxdHltUkVNdjM2K2lWQ3B2aHA2aGlEK1NyNnRTemVCZXBsN1pmUUJG?=
 =?utf-8?B?bWhnOTNwRE1CcmJLcUpYWnBZbnNidDBuUUYyZE5lZCtJbDdPU1FGV3UxT0h1?=
 =?utf-8?B?OVVZamhrM0U3d2ZCcm1lbk5rZG5wbTJwSVpEMzlEcDNlUmZjNTJDR2xzazY1?=
 =?utf-8?B?MHkzMGxuaFdCK0J3NnFabEhRWWRvd3RrQ1VjNXh4cm5tZmZDNWtPVENuSzRa?=
 =?utf-8?B?Z29OQU9pQ2dONzREY0xHdUxnNzErV0RlUDloRXFKMXltV1ZlRzJPSXc4SXAw?=
 =?utf-8?B?MHFDbFpsdkNYdHluZXNBajBBT2VZdnlSTytaNXpNVGpRcGJFanVFckg0bnpa?=
 =?utf-8?B?ZFo4N0dBSzdlbFVaS2Eva1htamhYV0V2UUR0RVNKUzBrd21ZWWsvZWIrZEVm?=
 =?utf-8?B?UEVUYnVXNlpqZHpzeDlDRVNzam9tTTlKSlFiVnkrRVYrUFNFUStaWncxM3I0?=
 =?utf-8?B?dWxMQ2d2c0Vla2puaXpzNldYWFZ0anc3dGZPbU42N1REVzczZy91MkxCTktm?=
 =?utf-8?B?NzJyQXdLK2psVXFUTEhNTFVpTmQ0TDQzLzRhMlhVbHBxaXdVdWxibVVtSVha?=
 =?utf-8?B?THV0QWRGVURPOEFadnZQWjB1enFveXJZV3VJZGd3djVGaXRSREVJcTVBdngz?=
 =?utf-8?B?QjlRMTNhM1l5OXB1OUNnS21QVU5pbmh1ZlpYcWlRMWhOWUF5SkpFQmY1NzBU?=
 =?utf-8?B?QmxzU3UyNWdMemEraE9sRXVDZkoyb3pZYjZtMXV4RlY1NGFnVE9CQm9GWUZX?=
 =?utf-8?B?dXIvejBEbE5JNGdUR01vRUt5SlkrOU5zZVEvQ3NHNWJseGt2UTdWdFo1WVlX?=
 =?utf-8?B?N0lEdWovaUthelRmcUlUaGJ3bzdRR3FpbURnMmJoNDN3STcxczZnb3oxalBk?=
 =?utf-8?B?eWpwWnNrOHlTU09xV1pWQXZsZFdPdHRxdVJwTDA2QU4rTWpJVVJvYjdDTnM4?=
 =?utf-8?B?Wlc5cFZxVXREaGtBQ2Y1UkN2c2tqOUw3VVRmcHJxVE5wRVJzQTMwTWR4L0J6?=
 =?utf-8?B?aURBVisrVXlsN2UvVW1BTCthZWo1dnZLUFNWNm9Bdnl2akE4cC81TGJzMTRl?=
 =?utf-8?B?OVVXWHNWY3ZJWWw2b1h5UEM5djduaitlWDN5WWhxU1o0SnpGamlldjE1c241?=
 =?utf-8?B?bm1GQlhYdTBjb1FqK0N6MTF6c3psQlg0OWlNQ29ybTcwenZxK0lEWjVLajRS?=
 =?utf-8?B?WlZ1YjFQTVRHZGpHNGlXd0QvZVZkcnd0M0dEZUlGTjRlblpwakdVbU1IZU5h?=
 =?utf-8?B?alRLZXl4TitTNGhVYlU5QlV1d2FMVlFtOS9vYnBIT0hPVE9MSUNiT3VsRzh2?=
 =?utf-8?B?bG1NK1V5Tm4rUTM2bGdNeVJTZU9ZWE9CZHJqYnh0NDU3SmEyUEFXZ1crcC9o?=
 =?utf-8?B?blYzN0UwSCt6T3RpNVdtcE1sYnY4Rkk3ejF3b09hNWZnNXVGZ0o4a0pFbElX?=
 =?utf-8?Q?bhDPGJ73GUlgPT6IU4rkSWEhG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0daee8d3-3831-43e6-6475-08daa69f27ac
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 06:59:32.3060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qf7UR986bX7yL6JwkdMyzRAQX9hBIAPDy1dmvYYr6f2TQEp8GJ/CyuVs+oF0OGnIZjbTPHARgeUbWK+of+7bHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7310

On 04.10.2022 18:08, Andrew Cooper wrote:
> A future change will want a cpuid-like identifier which doesn't have a mapping
> to a feature bit.
> 
>  * Pass the feature name into the parse callback.
>  * Exclude a feature value of ~0u from falling into the general set/clear bit
>    paths.
>  * In gen-cpuid.py, insert a placeholder to collect all the pseudo feature
>    names.

Hmm, I was envisioning this to be fitted into the existing model in a
less adhoc way: (parts of) MSRs holding feature bits aren't very different
from individual (pairs of) registers of CPUID output (in the case of
ARCH_CAPS there would be a perhaps just abstract mask limiting things to
the subset of bits which actually act as feature indicators). Hence I'd
have expected them to gain proper entries in the public interface
(cpufeatureset.h) and then be represented / processed the same way in
featuresets and policies. All that would be left out at this point would
be the exposing of the bit to guests (in patch 2, assuming the split into
two patches is then actually still warranted), integration into
guest_rdmsr(), and at least some of the tool stack side (xen-cpuid, for
example, could easily learn of such right away).

However, since I'm pretty sure you've considered such an approach, I guess
I might be overlooking some caveat?

> --- a/xen/tools/gen-cpuid.py
> +++ b/xen/tools/gen-cpuid.py
> @@ -297,6 +297,19 @@ def crunch_numbers(state):
>          RTM: [TSXLDTRK],
>      }
>  
> +    #
> +    # Pseudo feature names.  These don't map to a feature bit, but are
> +    # inserted into the values dictionary so they can be parsed and handled
> +    # specially
> +    #
> +    pseduo_names = (
> +    )
> +
> +    for n in pseduo_names:
> +        if n in state.values:
> +            raise Fail("Pseduo feature name %s aliases real feature" % (n, ))
> +        state.values[n] = 0xffffffff

Throughout this hunk: s/pseduo/pseudo/g.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 07:17:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 07:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415851.660517 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofyeC-0001WY-1R; Wed, 05 Oct 2022 07:16:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415851.660517; Wed, 05 Oct 2022 07:16:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofyeB-0001WR-V3; Wed, 05 Oct 2022 07:16:51 +0000
Received: by outflank-mailman (input) for mailman id 415851;
 Wed, 05 Oct 2022 07:16:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofyeA-0001WH-PD; Wed, 05 Oct 2022 07:16:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofyeA-0001pj-O4; Wed, 05 Oct 2022 07:16:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofyeA-0002zH-B9; Wed, 05 Oct 2022 07:16:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofyeA-0002Ub-Af; Wed, 05 Oct 2022 07:16:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RqYGZgtpMePSsKNPW0vucrIPCcFXIRv6u+HlSE4sMqE=; b=NI7MnvWLyGVBrmvour1DlqB49l
	wEmsbkdrn2JTkkeezdWLAy0pYsnkkrw6aOryQTPrnPDkgv9d2PvV2GByzC8NoXkAz9D7xfwUTgxAy
	g0SniTO8gmQ+QZ0I1kSKallJOGtDOMw27PP4wtw9o+6oyR0B9Ptoaae2pcuFmvvPZg3E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173424-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173424: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=1bd2ff18664b9564a5802d0ac153b5023f2fa41e
X-Osstest-Versions-That:
    ovmf=f931506815548cee5a3929856bfc98266c39999c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 07:16:50 +0000

flight 173424 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173424/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 1bd2ff18664b9564a5802d0ac153b5023f2fa41e
baseline version:
 ovmf                 f931506815548cee5a3929856bfc98266c39999c

Last test of basis   173420  2022-10-04 19:41:57 Z    0 days
Testing same since   173424  2022-10-05 04:40:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chasel Chiu <chasel.chiu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f931506815..1bd2ff1866  1bd2ff18664b9564a5802d0ac153b5023f2fa41e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 08:37:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 08:37:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415941.660564 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofzti-0003X0-Um; Wed, 05 Oct 2022 08:36:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415941.660564; Wed, 05 Oct 2022 08:36:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofzti-0003Wt-Rr; Wed, 05 Oct 2022 08:36:58 +0000
Received: by outflank-mailman (input) for mailman id 415941;
 Wed, 05 Oct 2022 08:36:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofzth-0003Wj-EY; Wed, 05 Oct 2022 08:36:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofzth-0003ir-Bw; Wed, 05 Oct 2022 08:36:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ofztg-0005CX-PM; Wed, 05 Oct 2022 08:36:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ofztg-0004dB-Ot; Wed, 05 Oct 2022 08:36:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=M/VQB9dILuaHg0Y9olAP+fdxsq8GSCcAXGtvSPKN1H0=; b=CDIrjHECnYp2NWeEvc1c46JrUF
	c+k/26+NrXqMvRrIMWJ4QYKyJIH9gn3iZSevWGGnSsBFlnY3deAM0UQVh3wCeYgZEBEWi/N2XJVL5
	AvukMZqS40HLhy5mm6v6l1kJc++uursRvHfZu9ET0fok5JbBd4UWcnUHn2YZUujkgLKg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173421-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173421: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=0326074ff4652329f2a1a9c8685104576bd8d131
X-Osstest-Versions-That:
    linux=725737e7c21d2d25a4312c2aaa82a52bd03e3126
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 08:36:56 +0000

flight 173421 linux-linus real [real]
flight 173425 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173421/
http://logs.test-lab.xenproject.org/osstest/logs/173425/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl           8 xen-boot            fail pass in 173425-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl         15 migrate-support-check fail in 173425 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 173425 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173414
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173414
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173414
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173414
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173414
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                0326074ff4652329f2a1a9c8685104576bd8d131
baseline version:
 linux                725737e7c21d2d25a4312c2aaa82a52bd03e3126

Last test of basis   173414  2022-10-04 08:14:24 Z    1 days
Failing since        173419  2022-10-04 17:40:01 Z    0 days    2 attempts
Testing same since   173421  2022-10-05 00:13:01 Z    0 days    1 attempts

------------------------------------------------------------
535 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   725737e7c21d..0326074ff465  0326074ff4652329f2a1a9c8685104576bd8d131 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 08:37:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 08:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415949.660575 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofzuN-00042U-8g; Wed, 05 Oct 2022 08:37:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415949.660575; Wed, 05 Oct 2022 08:37:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ofzuN-00042N-4q; Wed, 05 Oct 2022 08:37:39 +0000
Received: by outflank-mailman (input) for mailman id 415949;
 Wed, 05 Oct 2022 08:37:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NzUo=2G=citrix.com=prvs=27000a6ca=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ofzuL-0003z9-IM
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 08:37:37 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f52d8399-4488-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 10:37:35 +0200 (CEST)
Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 04:37:30 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BLAPR03MB5459.namprd03.prod.outlook.com (2603:10b6:208:296::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct
 2022 08:37:28 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 08:37:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f52d8399-4488-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664959055;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=RLA6cx/EZ9WUyNlhNDNnAskdG0wZnbGIduNypb1wTaU=;
  b=HjbiHRdoA7pmS6fEerrd2xj4zBU5ua41CXiZyNtc8kzXHezOkzPi/YCC
   5e4bOnb+Sg7hoLhKjfQuWh6aVlg4peBFP2UGObTFVb6L6Vej/cI6geMy7
   iegyN4hbYVcXikOkq0wxMsMZMW5HFugttuwA0JezVYGGsoM5gFUbSXfFt
   o=;
X-IronPort-RemoteIP: 104.47.55.109
X-IronPort-MID: 84526562
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ug4fv6PHpVuQyy/vrR1clsFynXyQoLVcMsEvi/4bfWQNrUok02MFz
 mEZXG3QbKyDNGOgeYh+bdu19BsAv5DTmtQxTgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayq5WtB1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eEKMox/tmPn13r
 vU1Lg4SLQHY2emb6efuIgVsrpxLwMjDGqo64ykl6A6DSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9RTM/ftfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPlWffrC/y3IcjmwuiSrg0SrqA9ccw3kaS7UpCDBQKXnuC9KzRZkmWHog3x
 1Yv0igkoLU29UerZsLgRBD+q3mB1jYHQMZZGeA+7ACLy4LX7hyfC2xCSSROAPQkqcs3SDoCx
 lKP2dTzClRHurCPVWiU8LvSqDqoIDUUNkcLfypCRgwAi/Hdp4U0ggPKX8xUOqe/hd3oGhn92
 zmP6iM5gt07ksojx6i9u1fdjFqEtpXPCwI4+AjTdmak9R9iIp6oYZSy7lrW5uoGK5yWJmRtp
 1ABksmaqeURV5eEkXXVRP1XRen4ofGYLDfbnFhjWYE78Cig8GKieoYW5yxiIEBuMYAPfjqBj
 FLvhD69LaR7ZBOCBZKbqaroYyj25cAMzejYa80=
IronPort-HdrOrdr: A9a23:wy28XKw0hJN+srjxt3OrKrPxRugkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICOgqTM6ftWzd1FdAQ7sD0WKP+UyCJ8S6zJ8n6U
 4CSdkDNDSTNykcsS+S2mDRfbcdKZu8gcaVbI/lvgpQpGpRGsVdBmlCe2Sm+hocfng9OXN1Lu
 vq2uN34x6bPVgHZMWyAXcIG8DFut3wjZrjJTIWGhI97wGKrDWwrJr3CQKR0BsyWy5Ghe5Kyx
 mPryXJooGY992rwB7V0GHeq7xQhdva09NGQOCcl8QPLT3oqwCwIKBsQaeLsjwZqPymrHwqjN
 7PiRE9ONkb0QKYQkiF5T/WnyXw2jcn7HHvjXeenHvYuMT8ABY3EdBIi451egbQrxNIhqA07I
 t7m0ai87ZHBxLJmyrwo/DOShFRj0Kx5V4vi/QagXBzWZYXLJVRsYsc1kVIF4poJlON1KkXVM
 1VSO3M7vdfdl2XK1jfo2lU2dSpGk8+Gx+XK3JyyPC94nxzpjRU3kEYzMsQkjMr75QmUaRJ4O
 zCL+BBiKxOZtV+V9MzOM4xBe+MTkDdSxPFN2yfZX79ErscBn7Lo5nrpJ0o+eCRfoASxpdaou
 WMbLphjx9yR6vSM7zP4HUSmSq9A1lVHA6dh/223qIJ9IEVH9HQQG++oFNHqbrSnxxQOLyfZx
 +JAuMmPxbSFxqQJW935XyBZ3BzEwhqbCRHgKdOZ3u+5uT2F6bNisv3NN7uGZuFK0dVZoq4OA
 pIYATO
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="84526562"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qi1bGwFL9vx81jHoz3EQyEvtGR6+n2Ff/+F9+Du4/KctuesxtIERF893bUtGg//9IsAqilaPeeu+Id3OBVI4QDLBjmXeXN6uNsRLvu5AqdJxkRCfSLYYrKJuL4t0za4AGM2E11TVkNhfe8xSJ6zOqRmjaN9aR0CGUrlpZC9WGEYnXCwGgmWbEyEJ/VgETQlWcbxUHuUGJutL+hMAiJap2WjPj23CkmGaD3P4byas/8LPc9PKPOPYrycn2uok5HqnDOg46upUYcbcdH6YsxxZatqg3bf3iMXGNCWisDMnJtWRYG5zqbY2/KcGQSMs9lJjUU7F58EyCMu4iMvHo2PkFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5qjRENa9XEdFpSHmz8m7rWW4in8xI1o0DhPHr6aPK+E=;
 b=OmIRPI+wLF9JrL+w9jfa+oNZvb2SrKzGkaEuhJLI1AKAJ1RFypkyLXndM9sYZZhz33uFS7fUUw4SSAm6l8Mk2VWrXkVLIanPsXgZLwiATcg2WKCsCj4/1JVQD7G88gSrFaPJO9LbHEZEH+tolUf6A5OwvhxH3MdBcbPFmYyT0CbdZeqavzzWSG7Ds3MfAWlpjw1rpKhY9gGDy35sbnEYipLU69/KM0HYxV8ZGz3SpSKh6tGdYxd3ttZCNYg0agLMzo7yEMhIFnSSbhwB/g6nG+1z/4pqX5Zahf6s/HU+40ALKJsXOstTg4z26Qxog4ttjfRgx733ggl/MdcPXb6Kxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5qjRENa9XEdFpSHmz8m7rWW4in8xI1o0DhPHr6aPK+E=;
 b=Q2y8uj+msskSklQaYjbZEPyV46JqHjG3ctnZeiUUwfi2A/cUiJQXzYFtAhKlUPgNVdplaQFhmeBMYx7lxzGq5NPz8RVqf8FLXWS2v5CswszwkvvYRH2nEFvmjSPMRlLWXRAqAEte6ZnnGBISxtAh9mFw4T0VA3QKoE5bW8a/n/8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 5 Oct 2022 10:37:16 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Message-ID: <Yz1CPNwo1hiWZTw2@Air-de-Roger>
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
X-ClientProxiedBy: LO4P123CA0054.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:152::23) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5459:EE_
X-MS-Office365-Filtering-Correlation-Id: 8eb60144-3e47-4090-7ce0-08daa6acd5a2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JJ1bkSzmdhggQdQYL4JRSDiUhglDxMCEWa4/jbQwzAV8L3zJz+zo7nae8aqs0SrmBUygahtBE2CmSnSp+esiGTdBmXIWs/1TPqFkDPRWySm93QGOwXQaS5yA1onqtmtZ64E52Dw1QWUdglx63vA6hSIG8V7U93RfceKQz23vEwmqRmTu7NaiotLGun2WIXOEPvNI/bczkn8m+abRVklOe/jWw8oCjqikegX9Sq6RGvUJTTjbuKSPp+o1+xWdxQ7c+Q+Sg1CNd7DWqLY+EdPyH10odGOXao4ygTHk6dU2Q6FrFUagkX/jgOACBPltxSjZz9R+ccytoFwFUSh7qLd3HuoBUwXBRDhGqXq9oKrsrq/XdnZ4D+pwowBm6lOOtsDMqePsHVXZk6/XIZgwdfExzF8bA83MAxwyXh+AK7XV6UFER7HYXIqKoBbc2l0PdMvaxeUKk9J8Onz0NX/VColUY/BBQisBx8YxwQZQZFNa9lIwmu0Q5zyhzB1cM6SbQe9WGc02/izHR31dr6telMlW5j/4ZrAZbB+6L27wuZTukfqwBC3LAByF99b2M9nw4ib5cKajLgu5NJc1tEw7/vCZWUZRqfJZZf/oqCItg1DjZ/7dOPoKr1gqKFwR/66QDLZYdXzI0b63LEXi7DERBEGG6M2ogtNkYwOerHYGMI/U/jNA+gOUgMVp4GjWCBVpWVgZ9QgZvGpuPGQcYi6K9ub4uQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(451199015)(316002)(186003)(83380400001)(38100700002)(82960400001)(2906002)(5660300002)(4326008)(41300700001)(8936002)(33716001)(9686003)(6486002)(478600001)(26005)(6512007)(6506007)(6666004)(86362001)(8676002)(66556008)(66946007)(53546011)(66476007)(54906003)(6916009)(66899015)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bUJtRUxaSnl6NDlSb1llY01NWEk5WjQxb3haZzBMR1N4K3haNTdibWdPVmZ5?=
 =?utf-8?B?WG5DU0ZTd3RjOGcwWXl4N05ER0x0WG9Semt5RnhHMjhTTlV4QkJpUzdhaWtk?=
 =?utf-8?B?alBodjR0Z1B0YWV0d1Z5dVlncTNEek1wdFE0NGlUTVE2c3BXRVJFbkhhc2dY?=
 =?utf-8?B?amNnd2tQbHBqVzg5STJHRTZndjBVRlFRaExmdm5KK0IrMXlhZHVzK3c5SXNq?=
 =?utf-8?B?UllIVEJ6UjdtV3Z6eW1yNjBKOFZnekVwbDkzOVdXK1BYNUtVdnREekFpbHlV?=
 =?utf-8?B?ODZyQW5mKzRWazNmTTdHRTRrbTRhdFkxYkJudHVES2ppRVk2SW5QdXhhVnQx?=
 =?utf-8?B?S1hyNFJSYklCTEhITmUySEZKYzd3RFNYUTF1MlRWSnV1UXp5KzFPeEFMK3Uv?=
 =?utf-8?B?YVdxSVZYYzN2K3JaNFlXYlA3bFkreDloWll5S0NSWWVTdnNwTllNZlZyVll2?=
 =?utf-8?B?MWU0YnRiMlk4SkVUSmZsTWVHRDVTSUdmQkJqQ3RBL0FrOVdrOUV6bXZ5elIw?=
 =?utf-8?B?UzdTNi9YMVNDazcwZWpLQVNoWWpvbjFyOVJPNnQ4Y3l2TVlES3NPRnlkSlhH?=
 =?utf-8?B?L0wveGNQV3Y0eHlrWTJ3NHZyV29sQ1BIaTBCRWpRY0ZFRXkwaVBOMk5wOEE4?=
 =?utf-8?B?dzZ4UmZRd2tDNHp2S3hUajFDMk91YitQRW9UMGIyY0tRbm13aW40VDUrMXN0?=
 =?utf-8?B?TDAxNzhlcTJ4U1cvWmdGNzcxV2V2M0t3SkxrWjJqNzc5cFIwWUdreHEvVEJp?=
 =?utf-8?B?ZlJ4OHZHNXdRR2NrR25GaFNoMFUzY1hyMlNNQTZzK20rQkNBV3RNeXNxWkJL?=
 =?utf-8?B?VysvU0VGZDFvcFF0QlJjbVF5Z25BMmtnZmtudmQxZHl2ZURGaHJHb3BXQkQ3?=
 =?utf-8?B?OFJZQzFRMGpqaWhyQTQvc3FDVFh6K3BtMHBRbURMRzBMQk5Gc0I1dkNxWnFR?=
 =?utf-8?B?VE56WGllVkJMVVVCU2dsK29uc1U2UncyQnJFeWMzTmNMaXpKdk8yT2ZuL3lW?=
 =?utf-8?B?MDB4NWNIQlYvTkJXTXh3Y2I2QUJXNER2WTFYYnNLUFNLOXljSmR5SzVVZEFQ?=
 =?utf-8?B?N2xoRHJEb0ZnQ2pjVE9BbkZka1crcW9EcHp2S2haU3lGcmlxbnZ5UGw3Q0RT?=
 =?utf-8?B?T2phQWxsL3pQUEllVTZvd3U1dTl5b0FkSmR1cElIaEs3TXV6RGtvaVlraVY5?=
 =?utf-8?B?K1FqN2V0YXlUVVdSMERmQ0ZDRCtxbFlCbFI0WTVaeTNTRXR4UE40bXVFa2J1?=
 =?utf-8?B?aUVhWUxia0JnZWhPcEJzYllTT2JIblJXQjdwMkh0VU9tMDdPdGlvU3hsb1RM?=
 =?utf-8?B?bjdIQWFBZWN3MVZXS2ZGeHR6Y29Ed1dPTzVjanptdE9BdGpPTTJjT3Z2UWZu?=
 =?utf-8?B?MXprMERtUzl1Z1Bhajk2U1lxWHJ1ZUdrNW9tWExyK0w0SlFXakdtZ29yMVE4?=
 =?utf-8?B?V21kRzBiSGVpYmsvNmF2clpYWXJVeW54MmljTGxteDA1U3F1NHo2bkZnUnh3?=
 =?utf-8?B?Ni9FTVhtZ1lOUmZUQlBaTDY1cWw0WmlVaW52YldWRFl4cFRzL2xDNWxOL1ht?=
 =?utf-8?B?Sjk3MDZTei9PdXZ3bjZBcWF6ZFJ0UFg3TlRiL1lwb0JYTkZiUmJRSDMvV0t4?=
 =?utf-8?B?UzdWZjZTYmJjUVBDWmY4QzJvcXk4Rm9zQTZXUzFkLzJETVgwczA1VHNaaVNX?=
 =?utf-8?B?bzNicVpHT0w0T0lGaEJZeHlYUUVxUnpHckI2L3VGWGU2bmNDZ0FMb2tWdmsr?=
 =?utf-8?B?bFluK2xFQnRSaEY3WWE5WFlKd2ZBQ0ZDUHZjYVI1emVweVBWc0xBZXVoSWFa?=
 =?utf-8?B?MHRhbUg3Yjd5dWhRRElGeTJzYnZ0ZHZ3cjBiRERHV2Jyd2dGZFVRbTBlQi80?=
 =?utf-8?B?R0VaWXNKcVZpQ1FURnpZSVNRczVFN042TGRwOXh6N1d1ajdBMS9kRjRwMjAv?=
 =?utf-8?B?Rm9vcGFvWG9jSDljOGhxeXhJeVVvci9tWGFPMkNJbTdDbDZPRkhkWklvQTFs?=
 =?utf-8?B?RzZTaTYrbFUweWVDS05Ta1ZXdFdsckIzeWplamlvcW4rQTZPc044UFN1ajFB?=
 =?utf-8?B?S3pqVnEyY2lHNDJxS2xLTDdyYmNtRmdXQXZsWkhSR3RoV1NxcDBiZGpRR2JJ?=
 =?utf-8?B?c0tDbDgvMGw0cjBwMXFzbUNHNEZEWDN6Q05tT09BZkhta1hDVHFVbTRhWk1U?=
 =?utf-8?B?d0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	cfxkKUh1D93qUZNyJNgSifL4qnDzWZMUsxI5DfKII1XVvGFKCduK1NAjyGysNbgqY7pkBuFYb0DtD7tL5jkEJrbJf82pXaKGWWQ4/Rve9Uks0047Y3wctJpZjuwrUdR/5vsgiHKgGQWdtvlcS7Ie0IUwdaBHbrCCVRAPMr3tpsDx7VpC2RCL3g3zZ9Owm77ebDZ5V7N90lIqmi2MM9EPcm7Tlufqa6zRGRrPrP/e85gRP2hsNiKsfF3QFmlbI98F4VT6YoSHYTHU5ww58hGQLYl0iEROSUV3VdPrG0CkZPUCfSJUENqga+f/Mjh9daN5UZMsSE4P/6NXpOqIYFgV4W7cHVF+R3LT3xRLlBJ89INz2XMueZuofDQ5FoYCxJTYJQ2zP53emPxMJvextG1FffaEIsFHC13ASHsT/6f6QHoVHS05Jw64Uro9/2zvMQeTWsU6/prLRDdBXpJpX5qjVTdSRAkP1RL4vAVzqCSCITgCozbdWAwhad5Ve7/Q8a5+g4NENaSkK3yNffwJ4qvKVAmR7KbyE8hZAHRBhpuizu5MZBDJ4Yh60blqPdfZVAQLDFNC7HN1zlJDNyNpyXA9lycPVLkrjUxWeHx05W/5kctitm/6vQPsnTlTnGOGANmVhkitrLyTQYfUDkpuzFHKmTjOft2iTCXZwSq6AJJd9oH3fWAhwpgNqOKMBIwhqNS+Z5QSpHvXKpAO6lsszVBOhCVaLc7jYn1wH30LnG0MJVQkRNkSay0w9TRJu+hZay69eu3BWa57IQj+74mI0amH0GmxDszKFc+oxcV8/1j/ZtP8k9lgRxC7q3S+/YfuUTCnbYoAp6R+6Kit91OrNZyaa6DXjgPJPcw4KYKm/A4q3eP5fe5hp+ieLbFb5UTNdWQQbrpk6jdYjz3oj9F+DW2FntfkksjPuyuPzWlldC2YF1g=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb60144-3e47-4090-7ce0-08daa6acd5a2
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 08:37:27.8096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7hRlOQbQsK6MGjXYVrYzNEDPlUeV0mLMc+uEY9EodPxpnZ1eKX/F9fkYXiwjLO6Pqv0lzEyLX3C6oz9n/zNeQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5459

On Tue, Oct 04, 2022 at 06:11:50PM +0200, Jan Beulich wrote:
> On 04.10.2022 17:36, Roger Pau Monne wrote:
> > The EFI memory map contains two memory types (EfiMemoryMappedIO and
> > EfiMemoryMappedIOPortSpace) used to describe IO memory areas used by
> > EFI firmware.
> > 
> > The current parsing of the EFI memory map is translating
> > EfiMemoryMappedIO to E820_RESERVED on x86.  This causes issues on some
> > boxes as the firmware is relying on using those regions to position
> > the BARs of devices being used (possibly during runtime) for the
> > firmware.
> > 
> > Xen will disable memory decoding on any device that has BARs
> > positioned over any regions on the e820 memory map, hence the firmware
> > will malfunction after Xen turning off memory decoding for the
> > device(s) that have BARs mapped in EfiMemoryMappedIO regions.
> > 
> > The system under which this was observed has:
> > 
> > EFI memory map:
> > [...]
> >  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> > [...]
> > 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> > 
> > The device behind this BAR is:
> > 
> > 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> > 	Subsystem: Super Micro Computer Inc Device 091c
> > 	Flags: fast devsel
> > 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> > 
> > For the record, the symptom observed in that machine was a hard freeze
> > when attempting to set an EFI variable (XEN_EFI_set_variable).
> > 
> > Fix by allowing BARs of PCI devices to be positioned over reserved
> > memory regions, but print a warning message about such overlap.
> 
> Somewhat hesitantly I might ack this change, but I'd like to give
> others (Andrew in particular) some time to voice their views. As
> said during the earlier discussion - I think we're relaxing things
> too much by going this route.

Another option would be to explicitly check in efi_memmap for
EfiMemoryMappedIO regions and BAR overlap and only allow those.  That
would be more cumbersome code wise AFAICT.

> > --- a/xen/arch/x86/pci.c
> > +++ b/xen/arch/x86/pci.c
> > @@ -98,3 +98,30 @@ int pci_conf_write_intercept(unsigned int seg, unsigned int bdf,
> >  
> >      return rc;
> >  }
> > +
> > +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end)
> > +{
> > +    unsigned long mfn;
> > +
> > +    /*
> > +     * Check if BAR is not overlapping with any memory region defined
> > +     * in the memory map.
> > +     */
> > +    if ( is_memory_hole(start, end) )
> > +        return true;
> > +
> > +    /*
> > +     * Also allow BARs placed on reserved regions in order to deal with EFI
> > +     * firmware using EfiMemoryMappedIO regions to place the BARs of devices
> > +     * that can be used during runtime.  But print a warning when doing so.
> > +     */
> > +    for ( mfn = mfn_x(start); mfn <= mfn_x(end); mfn++ )
> > +        if ( !page_is_ram_type(mfn, RAM_TYPE_RESERVED) )
> > +            return false;
> 
> We don't need to be arch-independent here and hence instead of this
> (potentially long) loop can't we use a single call to e820_all_mapped()?

Sure, was searching for a range checking functions but wrongly looked
into mm.c instead of e820.  I would have to make the function
non-init, but I think that's fine.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 08:53:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 08:53:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415961.660585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og09w-0006Wt-N9; Wed, 05 Oct 2022 08:53:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415961.660585; Wed, 05 Oct 2022 08:53:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og09w-0006Wm-KZ; Wed, 05 Oct 2022 08:53:44 +0000
Received: by outflank-mailman (input) for mailman id 415961;
 Wed, 05 Oct 2022 08:53:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og09v-0006Wg-Hb
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 08:53:43 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 364edab4-448b-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 10:53:42 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8962.eurprd04.prod.outlook.com (2603:10a6:20b:42d::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.35; Wed, 5 Oct
 2022 08:53:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 08:53:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 364edab4-448b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kTb93ZhSWo2krb/PemS+aXGm8KmWpI6BJ8WxTWnhaeFNchcsQKU6L9nyRiZa+21JPMMWBKeRIa/SHK7F6UKNorSRwFtR+lKN7L7Ix/CMEbWwjeTEeNnbjLzjluW8HB5kzH6m76PjhxaIAr1+W62Z+6lX2SNRGqrgqeIIuugYl7sPhp/NgSucUTGzAO/rQlOYATfHLYMl0RuVlJameOKyCVFrxGgAsQEqUvTztWgQA4lhY9ngGDjx0zLXauPMb1exmOom7rS8TYKdBUfB+DDzfTL5uo4wkvEdGYZeU1DF2Alek2AzGgvv2n5UFR+PA3b4zlSb4SL4aVb1YH5LHucp/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H2Zetr1xY0K9Qb+N4KGnzbTM303y6IKMboQSifrvcUg=;
 b=XNYtymIAagca71BFQv7E7C2uaTlRlM2HfoL8ieCHSfT7RsTFimvDWTro4StRkU5Vdj7NVdf0Ko9bMRPmr7rY9gin6zRVIvIFSF6wwgLbb+U6pBkMQp3LlNqWJE1KZ2gVhSHxCTh9r0ywfMpeMldPILppvqHROcdx/XIp99M00KubtZa5KAzaF2BwiBRO6ZJmdsjw1fFSUTeUfcrbP6mivglxRfuHVq8TTdGjPC3F5kiKgRBkh1uAwAKpBsP7Pa08OPESPLIL/WBrTc5IWcAPRyrbeOfb38/sN88bQxOSij6ZWXk0dEtog/8bD+5446A0uceT+dcMD2o34bJAabluOw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=H2Zetr1xY0K9Qb+N4KGnzbTM303y6IKMboQSifrvcUg=;
 b=soULI51Z8xHXcUiCKA6anui76pnxXXPUivuFmE9wKjWv8BDaOEjzFQxuXNei1iLg5dOHooB9kcw4uvtVTDlhXwYTQ9VVe0DHZbymjUt3VAJmFqrA2N+2ie12Eh25cOR++4lwDnpbjBbZeU3C5bVkJ2QfYyvxZkFtNf2bJfxgrR87EXT3xKIgmpqMBsWusWK5yt2FF9FZOrUfmC8p2FIwqI8j+wcsZkx1hMp9Rcjxgnb9H9tJ+DaXO3ytoRGMrROKYpklsJJTyFfMhxNXm5EdkP/eI615MUAAW+OODTr99yWHISHKjtJUcPlD2lXK4QqYzEDwHlh7N6oZwoEXMXzi6w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
Date: Wed, 5 Oct 2022 10:53:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
 <Yz1CPNwo1hiWZTw2@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yz1CPNwo1hiWZTw2@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::9) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8962:EE_
X-MS-Office365-Filtering-Correlation-Id: 30031198-f34c-4c5e-87ba-08daa6af1915
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	j4YCIE8i2t0SrLXTTxIoM4lkEQiWfaNK8T6SHYRydlEMu3kY2fDq57jyr6cyk8CeFBS4zzJRVZgBlj1YGd+mTYwkgimpCXABmWC+dkHfkMUesL9SnJtyXxKIySDMhzC6LqxjKpQq+ZJRl25wvQdwFPSdE0FspXLboGJ4VL5IG4zqyv0IAREpXMvuFohb9U9ZibbtmPOsPbZ03qHKNUWebVr0wcWfvBPB3WDMuJQHcNAtJw4WI37uU6gLR7rdXqZ9VoyqiBs7XUSc4dW9hZ5UDDij1xkVSJGWYeJ1FDatHLnCHOA396lIno1q9MC1Njnu5zLmCvvEf8WkProil/KlG0aJR38Bprp/f0piNLqoZYKdN10yCOk01oIoe1nf2i351HiYWCSPPATaHRePimj078aWsSAJmMf55udTXpkQFmu6LuKvZ/3RrThRXlM/Crs6fvW0fR0odc3qn1vpROw0Rf9SxJWXX4utvmm9p3jPDS1zfp1E6EFa3QYQoOpsGgbjYQdcz/WO9XJEHWkS5ay+RWyaWM4ONlrFuwnUdd4R/1UvXOgApB5TUDMhA//FX/ma5pR3qGFtlJwrcj/1547FBf1GP+fY/CiJH5ujr+JmOi3CydJ4kKSarJQ7AlVd8f3yEslCa4hcilnzhORVVty7LAfFEn5uWCYdOrmuqPL66/5WxiXZUNJ/8KgjkwlQe/9glMJ36BCFVP1g9lmuR9WnAnF9RqVAtyZlHaQLQe3xdOJm6hz0C3alA/vXkM+ZqdKoCfhpQu0d40LMuCPuoUt5Js6F8XjGyriUXbVyasedJM0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(31686004)(316002)(8676002)(4326008)(66476007)(66556008)(6916009)(54906003)(66946007)(5660300002)(6486002)(478600001)(36756003)(31696002)(38100700002)(41300700001)(53546011)(6506007)(2906002)(26005)(6512007)(83380400001)(8936002)(86362001)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qk90bHRjNUVkTW90THl4dXlKTk1jNStFWjVCZllpbWxHMUF1UG52NzFZUWZH?=
 =?utf-8?B?bnVNRnVab3BVMkJnTmdsRHVScHNsb0RuNjlRV25JdnYwOHlkNkhMN05vaXRF?=
 =?utf-8?B?bU40eEkraENrYXBQSGhwOE5ZNHZwdVlFZFlVU2tHdVRhbzBjVFlKa0xyVFNV?=
 =?utf-8?B?MkhEL0NTMHhlakdGSklCSzBJQ0VOTE1VMHFOdDNLL09jMGhvQTB5bjRaVjYr?=
 =?utf-8?B?SVNpejNQR1RSdEFRMEpkSFZwaUhMTnlucmxtckkvMHJqZzVjSThrZGlqZDVG?=
 =?utf-8?B?UXV6emltV3pNTmc5bFl3ZUVHRnpIR2x1MGRpWU9iR0JoM0xnY0d3V2hiNGMy?=
 =?utf-8?B?K0ZYTjFHZmhaM0ZtU3FGRHRjQjg0RnQ4NjFoT1F5NG0vZkdBYUladzRja0dS?=
 =?utf-8?B?V0xrVm1nT0JSanZodEF0a1daMWJDLzJ5M2hZNExzVGd1ajRlbys3dXBraE52?=
 =?utf-8?B?Q290VHd0clY1bFFSVlY0QjlJVFkvbWhjdUFDc2p3MXI3ZFhVaE52SDZKY3Rn?=
 =?utf-8?B?aUsyOTlzMi9nTmZCL1E0L0tiYndPTE1tK2syem0vT2NManZ4WGdNWVk3Zm9h?=
 =?utf-8?B?SHkwNWN0NmQyc3ZmTi9acE9MdFVIZzQ2aFlDTTJCUi80SXMwKzFudmFFVGRJ?=
 =?utf-8?B?VzU2WUVvTEQ5cXJYdk11T1VpTkhZU29ta0tCclpCQXozMUt3TWo5cDBlZUlk?=
 =?utf-8?B?V3ZFdVpXcG0rM211bnljdGlmak1Qd0RQLzB5dmVRWStwK3dsRTZnL0lDRmdl?=
 =?utf-8?B?UlUybEp1dS9BMVNzaW5waFdtQzZGZUYrdjd5OGFxaGIxNEVxQWdWMWYrS3Mw?=
 =?utf-8?B?bkI2UEtwdXJYcHNyNU9tY21xNk5FSG9ybC9PZjBybjVzS0lPNytoNGRRWDdu?=
 =?utf-8?B?b084Zkl6VlkzMm9LZUswK2dyN3g4a0wxbk1wVm1pZDhGckp3L0dVVTdZcGRK?=
 =?utf-8?B?cGVjTFhXUlN3OVNYc3V3WE8zRzdTOFVoV1FRY29OVGVFcDFtWjd3N09EUWJD?=
 =?utf-8?B?ZVlDV3RpcXZlTkRRbXl2bStuTDRRZ2tkc2phYVh6bmo0dUlRdWpxRUNjcGM2?=
 =?utf-8?B?a0ZDNy92MkpSNyt6SUxZQzFqb2szTTNFTGN6dWNscy9rcWRkZUlEZ2ZGcGg0?=
 =?utf-8?B?OXVZbjV6d1JRTEJCRW54bFlQcXAwTStEdEtNa2JWZlZMMytoN1RLbVNmRW9q?=
 =?utf-8?B?VW1lOGtEbEZrcmlKR1Jqd1ZDL2dRNVpycmtJNUFVdzd6bDFLOUF0Q2hpZVZ2?=
 =?utf-8?B?WlZiWjVMVS9KQy84ckxpNXRnRWc5a2owVU92eDhiU2hqaHRYTFVGaUNHU1Az?=
 =?utf-8?B?SlZEZEVWZHZ0dGVMbFhCc29za0M2d1pYWHloT3A4V3pLVFRSVUtXT2VYaFNl?=
 =?utf-8?B?a2NCM0VPWjJGaWdGMDgxeDcrUkRFSHUvOUVkRkhIamZZcldGQVZtdG5LZThK?=
 =?utf-8?B?aXV6MktTbU9GbVlCclBzQWlGOTliU05FMHBFbnhzSjBCVUgzMFAzSHNkWldx?=
 =?utf-8?B?QmUybEtLaWhSOUNJVVVQL3pqeVVRU0FwYWdCK251YUVHMiswbk54Qit0VGVr?=
 =?utf-8?B?RitHWXlBUk5wOXpjaVU2MTd2TG9lTEc2T3RpRjlxZFRpcTJwbVBwcE9qMDVF?=
 =?utf-8?B?Y04xcm5wL0Z2V2hrMTNueXVibHdkaUxJU0JSKzlDT0ZReitGZTJ3S3VxWC9o?=
 =?utf-8?B?S3NUS1FSVGxqd2R6dUtvb0lzeWNEVFVjanI4WlZKNHd4UVRwZHBVSTR1eU9D?=
 =?utf-8?B?UW9INnp5UnlndkI3WkMzU2IwNTAxV0RiUnJmYzl4SWFFVzZaRlV4a05vVWM2?=
 =?utf-8?B?UUp5cU9vMC90MVJIa2wxbXlKZjd2NkUyZ2ZRZXdDdFoySnVyeEZxOEE5R1o1?=
 =?utf-8?B?a3kwMkpHcEprNjZhS0lTSndtbE50YnhIME1oQ0h1akNnbnVsUGpvQnc5ZjZ3?=
 =?utf-8?B?WklPNkt6VG5aYkdrZmM5dGZIeDlvNVc1bGNNVGdOVXFlQ0FNOERtaHpMc3Zr?=
 =?utf-8?B?bUFYc2FiNXpLQldpaTFuWVB6YVBJVWNkdDhwYmI0SXMwR3ZlZU14YUFVSGRP?=
 =?utf-8?B?cWtHalUzQXI4NERCWk5rcGx4Yk4yb3NEWGRGRnJ5RlRwaWM5R09iSUVvTUs1?=
 =?utf-8?Q?39W70quG6J8NcLeSj/8fFnhXy?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30031198-f34c-4c5e-87ba-08daa6af1915
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 08:53:39.9487
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WYUF3yUnC296rjuPib8FYF2eGOonIpf1aiYuDD43E1DjYjOZ/wMJWcMYlG8jqB4WdIKjrJGJGjkvdmWzslw6Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8962

On 05.10.2022 10:37, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 06:11:50PM +0200, Jan Beulich wrote:
>> On 04.10.2022 17:36, Roger Pau Monne wrote:
>>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
>>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas used by
>>> EFI firmware.
>>>
>>> The current parsing of the EFI memory map is translating
>>> EfiMemoryMappedIO to E820_RESERVED on x86.  This causes issues on some
>>> boxes as the firmware is relying on using those regions to position
>>> the BARs of devices being used (possibly during runtime) for the
>>> firmware.
>>>
>>> Xen will disable memory decoding on any device that has BARs
>>> positioned over any regions on the e820 memory map, hence the firmware
>>> will malfunction after Xen turning off memory decoding for the
>>> device(s) that have BARs mapped in EfiMemoryMappedIO regions.
>>>
>>> The system under which this was observed has:
>>>
>>> EFI memory map:
>>> [...]
>>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
>>> [...]
>>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
>>>
>>> The device behind this BAR is:
>>>
>>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
>>> 	Subsystem: Super Micro Computer Inc Device 091c
>>> 	Flags: fast devsel
>>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
>>>
>>> For the record, the symptom observed in that machine was a hard freeze
>>> when attempting to set an EFI variable (XEN_EFI_set_variable).
>>>
>>> Fix by allowing BARs of PCI devices to be positioned over reserved
>>> memory regions, but print a warning message about such overlap.
>>
>> Somewhat hesitantly I might ack this change, but I'd like to give
>> others (Andrew in particular) some time to voice their views. As
>> said during the earlier discussion - I think we're relaxing things
>> too much by going this route.
> 
> Another option would be to explicitly check in efi_memmap for
> EfiMemoryMappedIO regions and BAR overlap and only allow those.  That
> would be more cumbersome code wise AFAICT.

Indeed there's a question of balancing well here, between two outcomes
neither of which is really desirable.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 09:04:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 09:04:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415969.660600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og0KJ-00087m-OI; Wed, 05 Oct 2022 09:04:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415969.660600; Wed, 05 Oct 2022 09:04:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og0KJ-00087f-LH; Wed, 05 Oct 2022 09:04:27 +0000
Received: by outflank-mailman (input) for mailman id 415969;
 Wed, 05 Oct 2022 09:04:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DGwH=2G=virtuozzo.com=alexander.atanasov@srs-se1.protection.inumbo.net>)
 id 1og0KH-00087Z-Ui
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 09:04:26 +0000
Received: from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b429a095-448c-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 11:04:23 +0200 (CEST)
Received: from dev011.ch-qa.sw.ru ([172.29.1.16])
 by relay.virtuozzo.com with esmtp (Exim 4.95)
 (envelope-from <alexander.atanasov@virtuozzo.com>)
 id 1og0GH-007ckN-N9; Wed, 05 Oct 2022 11:02:42 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b429a095-448c-11ed-9377-c1cf23e5d27e
From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
To: 
Cc: kernel@openvz.org,
	Alexander Atanasov <alexander.atanasov@virtuozzo.com>,
	kernel test robot <lkp@intel.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Wei Liu <wei.liu@kernel.org>,
	Nadav Amit <namit@vmware.com>,
	pv-drivers@vmware.com,
	Jason Wang <jasowang@redhat.com>,
	virtualization@lists.linux-foundation.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Dexuan Cui <decui@microsoft.com>,
	linux-hyperv@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v4 0/7] Make balloon drivers memory changes known to the rest of the kernel
Date: Wed,  5 Oct 2022 12:01:50 +0300
Message-Id: <20221005090158.2801592-1-alexander.atanasov@virtuozzo.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
inflate and deflate the guest memory size but there is no
way to know how much the memory size is changed by them.

A common use of the ballooning is to emulate [1]
hot plug and hot unplug - due to the complexity of the later.
Hotplug has a notifier and one can also check the updated
memory size.

To improve this add InflatedTotal and InflatedFree
to /proc/meminfo and implement a balloon notifier.

Amount of inflated memory can be used:
 - si_meminfo(..) users can improve calculations
 - adjust cache/buffer sizes
 - adjust object/connection limits
 - as a hint for the oom a killer
 - by user space software that monitors memory pressure

Alexander Atanasov (7):
  Make place for common balloon code
  Enable balloon drivers to report inflated memory
  Display inflated memory to users
  drivers: virtio: balloon - update inflated memory
  Display inflated memory in logs
  drivers: vmware: balloon - report inflated memory
  drivers: hyperv: balloon - report inflated memory

 Documentation/filesystems/proc.rst            |  6 +++
 MAINTAINERS                                   |  4 +-
 arch/powerpc/platforms/pseries/cmm.c          |  2 +-
 drivers/hv/hv_balloon.c                       | 11 +++++
 drivers/misc/vmw_balloon.c                    |  6 ++-
 drivers/virtio/virtio_balloon.c               |  7 +++-
 fs/proc/meminfo.c                             | 10 +++++
 .../linux/{balloon_compaction.h => balloon.h} | 30 ++++++++++----
 lib/show_mem.c                                |  8 ++++
 mm/Makefile                                   |  2 +-
 mm/{balloon_compaction.c => balloon.c}        | 40 +++++++++++++++++--
 mm/migrate.c                                  |  1 -
 mm/vmscan.c                                   |  1 -
 13 files changed, 110 insertions(+), 18 deletions(-)
 rename include/linux/{balloon_compaction.h => balloon.h} (86%)
 rename mm/{balloon_compaction.c => balloon.c} (88%)

v4:
 - add support in hyperV and vmware balloon drivers
 - display balloon memory in show_mem so it is logged on OOM and on sysrq
v3:
 - added missed EXPORT_SYMBOLS
Reported-by: kernel test robot <lkp@intel.com>
 - instead of balloon_common.h just use balloon.h (yes, naming is hard)
 - cleaned up balloon.h - remove from files that do not use it and
   remove externs from function declarations
v2:
 - reworked from simple /proc/meminfo addition

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Nadav Amit <namit@vmware.com>
Cc: pv-drivers@vmware.com
Cc: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: linux-hyperv@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: xen-devel@lists.xenproject.org

1. https://lore.kernel.org/lkml/f0f12c84-a62e-5f8b-46ab-a651fe8f8589@redhat.com/

base-commit: 2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 09:06:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 09:06:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.415977.660612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og0MD-0000Gk-50; Wed, 05 Oct 2022 09:06:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 415977.660612; Wed, 05 Oct 2022 09:06:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og0MD-0000Gd-1k; Wed, 05 Oct 2022 09:06:25 +0000
Received: by outflank-mailman (input) for mailman id 415977;
 Wed, 05 Oct 2022 09:06:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og0MC-0000GM-1L; Wed, 05 Oct 2022 09:06:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og0MB-0004Gp-Qu; Wed, 05 Oct 2022 09:06:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og0MB-0005x0-A8; Wed, 05 Oct 2022 09:06:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1og0MB-0004y5-9g; Wed, 05 Oct 2022 09:06:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VpFoynYOtFANCinxOlUH6N7e91QfAIiDXtXnMXCRZcI=; b=RbCEHhrnbO1hwt8v8ipc8xGkBb
	ESJSOW9mONTxzvXWq1KEUsBHPQwvBmhpDEPXqyv1ogu+9cUWXG0IMtFr0lMhq8o3WMCumtJw2CWGv
	zAF/frNuVr0nzq7kUDEguxvGws9F5mamywfXqiIB1luWtJFMWE+WWrQN1+ZtN4PxnH2w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173422-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173422: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=3161231abcb461314b205337fbd0530c7ead1696
X-Osstest-Versions-That:
    xen=3161231abcb461314b205337fbd0530c7ead1696
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 09:06:23 +0000

flight 173422 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173422/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm   7 xen-install                fail pass in 173416

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 173416 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173416
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173416
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173416
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173416
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173416
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173416
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173416
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173416
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173416
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173416
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173416
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173416
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  3161231abcb461314b205337fbd0530c7ead1696
baseline version:
 xen                  3161231abcb461314b205337fbd0530c7ead1696

Last test of basis   173422  2022-10-05 01:52:12 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 09:56:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 09:56:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416030.660641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og18P-0006X8-H7; Wed, 05 Oct 2022 09:56:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416030.660641; Wed, 05 Oct 2022 09:56:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og18P-0006X1-EE; Wed, 05 Oct 2022 09:56:13 +0000
Received: by outflank-mailman (input) for mailman id 416030;
 Wed, 05 Oct 2022 09:56:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NzUo=2G=citrix.com=prvs=27000a6ca=roger.pau@srs-se1.protection.inumbo.net>)
 id 1og18N-0006Wv-MA
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 09:56:12 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8b825c0-4493-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 11:55:58 +0200 (CEST)
Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 05:55:56 -0400
Received: from MW4PR03MB6362.namprd03.prod.outlook.com (2603:10b6:303:11d::12)
 by PH7PR03MB6861.namprd03.prod.outlook.com (2603:10b6:510:15e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Wed, 5 Oct
 2022 09:55:54 +0000
Received: from MW4PR03MB6362.namprd03.prod.outlook.com
 ([fe80::4121:3e98:1f6:c59a]) by MW4PR03MB6362.namprd03.prod.outlook.com
 ([fe80::4121:3e98:1f6:c59a%4]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 09:55:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8b825c0-4493-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664963767;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=ar9NPnoC23ew1hEMvExe1Sinjx2iQ8qrC8iY8h0lTuM=;
  b=JJh+a8nNUNWwN2+JJaK/OAQElba/iW7+JDoOd7STTXZrEBolJsbX98oz
   JiAUDmoV0pfH/kiB9c7ffb+YHa2UfhU0qWvyJN4tLo9vyuMBaZ2F/pHO+
   ohOYjXcE+DVIfnPbWlJGSN09wkBJRY+qvKCL/9QmE97hLcQPe/3bDBthf
   g=;
X-IronPort-RemoteIP: 104.47.59.177
X-IronPort-MID: 84530409
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:3wS9YKAOG4yQ0BVW/93iw5YqxClBgxIJ4kV8jS/XYbTApD4jhjFWz
 jdJX2mFb6qMMWH3KY0nao22/U1SsZeDm9JhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25Kyv4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kLZI0p8ekpKlhy1
 vEkCDMsMBCvovi5lefTpulE3qzPLeHNFaZG4DRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAJ7gvK+sLb4ECKpOB1+KLqP9fPPMSDWO1en1qCp
 3KA9GP8av0fHIzDlGHdrir97gPJtXPGdaw2FZKpzaJVvwyhnjZJCTY/bUTu9JFVjWb7AbqzM
 Xc86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooL2yQuEAmkPThZadccr8sQxQFQCy
 Vuhj97vQzt1v9W9aX+b7KbSkjq0NgAcN2pEbigBJSMA6sPmqZs+jTrOSMhiC6+/itDpGTD2z
 CuOpSJ4jLIW5eYH2qC61VHBnTO3p5LNQxI15wPYRWas5EVyY4vNWmCzwV3S7PIFIIPHSFCE5
 SIAg5LHs79ICoyRniuQRulLBKuu+/uOLDzbhxhoAoUl8DOuvXWkeOi8/Q1DGaugCe5cEReBX
 aMZkVoMjHOPFBNGtZNKXr8=
IronPort-HdrOrdr: A9a23:MvHc6qFCOa7k+eztpLqFgpLXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79
 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tPKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZozU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput
 /RpApIBbU611rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ej0XigzBcZtjZ9QNkKx0TtogPhMlI
 Zwm06JvZteCh3N2Az7+tjzThlv0m65u2Arn+I/h2FWFaEedLhSh4oC+149KuZ3IAvKrKQcVM
 V+BsDV4/hbNXuccnDip2FqhOehW3widy32MHQqi4iw6Xx7jXp5x0wXyIg0hXEb7q8wTJFC+q
 DtLrlovKsmdL5YUYtNQMM6BeenAG3ERhzBdEiIJ078Ka0BM3XR77bq/bQO4v2wcpBg9up/pH
 34aiIYiYcOQTOvNSXXt6c7sSwlAV/NEAgF8/suqaSQ4dbHNfjW2S7qciFcryLvmYRbPiThYY
 fDBHtnOY6dEYLQI/c24+TfYegmFZBMarxghv8LH3Szn+nsFqrG8sTmTde7HsucLd9jYBK0Pk
 c+
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="84530409"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ChMYIqYtAwjpA5YmYxvlqVI/xOh3Ntmik466mcOOGj+mhBUjyNqUYRaVDU48jA1E6G+dkC5za1O1Tf0c6bINrmvQ6XOY9srVtv0/cwLOsAwT+gmaO1Gj8m/vNIqDF7ZIrfVC8cVQVr360eOksQbg77N1OUBoe6w/jjASQSovnfp1PqRNmS+UOSZo8nKZBMatGKg6g1dWIPUQSW1gWIJl6MG69fbyPSKqH0gK10XXiBXeXyLissb/Nl9c9G68EqiWZQZionGXisQskJOUq6hhsaipKFEnifeBHuIj4bX2lYvkr+W2UzO6Fs4W/T9mBG++hAAAXZO541xQUhL+h7S2eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ar9NPnoC23ew1hEMvExe1Sinjx2iQ8qrC8iY8h0lTuM=;
 b=NELONjALflPjLXgC00HnZWqCpGJsnsM72gmLb557afrNl6qY04439odZl8UOYfDw+BaPPW4moh0RiWEP/far+r3llswXxBx8wqkafMHPMw5fGp2UAY98hlBcxxJwfZA6hxV7dAFFg54NjDdAB+scoHsmjFOMxdveUbkqhn75dBtXyqE1acquPy6l362ruV1I3w6gwjQb7dMg6bhf7pWBYAKX832GL3BYcjlbNsBKp5kwcZ1A/lmvld886fDtl4CUDv1hhPCrTlepZnOmvqi1HUcQBsJiHZp8k17spEKirGOlv/ehWJ4z1w4hWpFdpNjcOjr7ROvxFC1+QUZn4HPfJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ar9NPnoC23ew1hEMvExe1Sinjx2iQ8qrC8iY8h0lTuM=;
 b=JTMhtBm5+C3L4HmaMZPA+ugk9L3NfEJ3XNQCpqN7KnLa3I0GX6jqudB9Yv7Sb11nvz1IwF8E84jx5GZGPfK0pfSw8xywd7xXAlc8E4bODWtwc2S3q1mNER/KRLAlskrx9XUH+GySa0Kt0wwD2wtIkz+fHzEHrIPqCO9QM3jZdEA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 5 Oct 2022 11:55:46 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Message-ID: <Yz1Uoma3S4Wgmr4F@Air-de-Roger>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221004160810.25364-2-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO4P123CA0192.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a4::17) To MW4PR03MB6362.namprd03.prod.outlook.com
 (2603:10b6:303:11d::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MW4PR03MB6362:EE_|PH7PR03MB6861:EE_
X-MS-Office365-Filtering-Correlation-Id: f7407691-26fd-474b-9399-08daa6b7ca46
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mz6yk3zoSIMyo4A4Ft6PwKcVdY7gg5kBox06pUgyqqKsYNyM10/2janHQJKuxgIafzPDNFxGpHCFxwTu20KXbaihvWpaBlcIGvAsELyc7G2XE3xBXTkEQpUt6Xke05AuQECXby6GL/0qJBTf88esIoYP0RwT2WLtghyD9SczV+ceOYmnML7fn+KQT1Gmcgd9BihaZYxkwp3rvcaiRiqirhE5uwlAkqqdu51Ycf4qHdE+6DqtKtns305e9moNYlQM7YLpuflQwWDbU0UB8u3XYDjb85E0VWJl9cO1DXzYddi0sS+8DkfLXitz+3Ngt3MATjYMFikAV1mYXNgSOCa6iCOlyOYthiIJn75V9ioZu4yjt6oDdlBSgGrL44AY8NK5Xni6Kzhq1iszJmgXJhlOZIECJd72VilTUBipJYNdQBwH9zUW/1EBxHz9ymeBsKzz0yyAm6p4G9rm21kHu8UcrLkYd9VwItfHSBKSGOvSSE8qpgXN8MhYrUKhiDTjmhHe4GM/PXdgcKTQkUJXSwBAAd1TEn+plNYmhrW+NDgHfoSY020OZYeriDZ1tRj9vsTmfKQiDEoKm9NPyI4+87IpJ035y7Eww4i2Rl6A8KSAA1MkdqyoLFObfpTxxFP8YEwek8S40/lx2hLq0sjzYA/H5rO2TtRloDTjhxgltTLK4D0IVmrurmMctwmOLOaDEFLqyElGFwh4W06uZMBmb9sORA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6362.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(451199015)(85182001)(6666004)(186003)(9686003)(86362001)(6512007)(4744005)(41300700001)(6862004)(2906002)(26005)(6506007)(38100700002)(8936002)(82960400001)(33716001)(5660300002)(478600001)(316002)(54906003)(6636002)(6486002)(8676002)(66476007)(66556008)(4326008)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K2dYRmRKRmFraUR4dUg1d3VGWEtzazFxTFNGdld3K21sNXNIQTgraCtEL0tV?=
 =?utf-8?B?cmEvdW1KcEFNR3p1YlFBN2c0SXV0YkhtMXByREVKYUFkY09lc2RlNnhkRW5O?=
 =?utf-8?B?MnN6dUMzZEFTRE5mZmRhdzZ6NzJnaHdUUjJQTnV2bkxzSS9VU21UNlBtc2xS?=
 =?utf-8?B?Lyt1TGx0bnBuVW9wQlhjZTNKQmRWc3ZCSms1d0JkdXUrdGpwRGdQVUwyQzBj?=
 =?utf-8?B?SWF6VWF6Z2VGOHl5SWlPcnVjRGxHcmtXQ1I0UC9IT2lRZ2FjUEhLTnBuWitz?=
 =?utf-8?B?N1NQdnBJRDROSWkyV1IwNFNzZm5DSXBucGRnRlNFTDE1Y0JKbDlzbmZLa0ZX?=
 =?utf-8?B?U0pteStxWnlwU0xOL0hYb0lraXptNHRNSWwrbXp0VUJLMEM5SVBucXJmTWV1?=
 =?utf-8?B?YjhWWjdoUFRPYmVVTnhnWElqVERieXVqOGJWdEt2OERFVHdVVlJBcUNBcmJm?=
 =?utf-8?B?Z1NvalRYY0tmOHdBajNTQ3BmOWpXZzBCTm1ZQVFoNisxWDM1S21FNDVXa2lP?=
 =?utf-8?B?U0lOU3VTeDZsYllRUWRJUnpxQ0F5RDV2WVhzOUdmM0RndEVJNFZpTzR2UEdG?=
 =?utf-8?B?bUJRNTk1cmZzRlRFVGZDaFRFdXJvVTZyUWUyeU9NczA2RmdNNmlRemluSWdH?=
 =?utf-8?B?d3EyZW9rMk9VMkJ1V2tJSUNxU2taOXpIbHZ0V1RHSGlsazZ5KzFiYjVKUmc0?=
 =?utf-8?B?Ti9OcFZPbWFsSmh2L2RCTzBCSjU0TmxPUGErYVY0NkRjWllJSGRmaTdyUnVL?=
 =?utf-8?B?S3AvZlExengwS3FwRCtSdktxVE10NFc1OS9ZeVl0dlBnY29yL1pJcWtTeTFN?=
 =?utf-8?B?bHllTlRGLzExbUNvVjdFKys5NGozSm0vMDI3Ykl0VmRtL3JvWVJPTFFPQ2F2?=
 =?utf-8?B?bzgrdkVOdjdBc2JmalBFSUNoeWM0dUZwbi9LMk1tS2tNQWFTRjlTcDVGMFk5?=
 =?utf-8?B?NGx1WjUzbkVnRklSakJRVEdQVjRDMUJrRDFXVmswdjNURWpHTENJdkYxTlkz?=
 =?utf-8?B?NFJ4cE40dHU4ZW8venU2TXJRemQ3aDdZSWZIZGo0RlM4WkJ2QzFTdmpKc0hm?=
 =?utf-8?B?VGhlY1krL2VWSHljdVdLY1BnakVJTURTaWFzZXlmdzhPaUJXcDFCak83dmda?=
 =?utf-8?B?K3ZERlhzaSszdTBVMHV3VVZ0elJrWEFMTnBCR3p2SHlBZFlYU0JOTmYwT2dT?=
 =?utf-8?B?ZnFnOUdxUzZ1Mmp6OXY0ZklON0VEbVpqTTd4REQwNVBVeFc1SGxPTjdQL3do?=
 =?utf-8?B?UkllUnRSQ0p2cS9jTDZmdTNBaTNxSXVCVTR1TnhRbG01YjZhMjNjWnZqckpH?=
 =?utf-8?B?bytrUjY3UzZId2owa1ZGaDJ5TGNXWkdFV0twZEF0a2lhWm9jODNaSUx3V0lv?=
 =?utf-8?B?RUxrNDNNZGcybEJSb2lycTBWWTcwZGpiTFk0cDB5dnBrTElBQk4wKzZPSWd6?=
 =?utf-8?B?aVlCS0EzWUlNZFkrVU4zNVJ3U2dKbC9GUlhnZnJtb2toUlM4NmxuK3czTjFS?=
 =?utf-8?B?K09tcVFMM2hjWStRTnMxdUZlV01udURoVGwwenlJdXVEOGZLejg4VFpGMGVl?=
 =?utf-8?B?VldvVnd0VVl2T1oyMmtTUGJRdVBBdzJOM21iMHVQR2l6WnJCZmN0SGtCaUhr?=
 =?utf-8?B?VGtjZGlJY2dycVBITkVsUGVrSzZnT0VzUjEwT2NsYktpZVUvUjA5ZUJ3d1dH?=
 =?utf-8?B?cWlsZXlIYXhjZnEwTGlhMDJhSHRhOWdoZUtqUzU0RXlYSDE5SkxncXc1Umt1?=
 =?utf-8?B?cEJjWkU1VTE0a1BEa05xa1FhMnNRMFJ6YlU0TmY3WmZCKzZxOWRxbCttMEJV?=
 =?utf-8?B?bkhmTUFaekFybm9XRnpSK1d2NHlXUVZrZlJzMTdpOGVDMkhPSFRJUnJhQVpH?=
 =?utf-8?B?NExrN3hZcWdEQUJtdG9VMmpPNzk5NENNLytFTXp0UEVjZndCRzhpVG1CUGN6?=
 =?utf-8?B?bGRGMTczNFdUdHJCdzBHbDlRRWtxSTZTbk0reklTc2RDNyszVTJ3YkVwRmJC?=
 =?utf-8?B?NDBHNXVYQ2RBNDZIZ3JYSVBXNnY4T0lUMzNWYXYrcE9aZ1VrWE1WSGtvdWd2?=
 =?utf-8?B?bnFyRzdNSjFnbjhrZ1JyZXE3ZzNIYmhHaHVGTHA2VVN2OWk5TE55SHVCWEd2?=
 =?utf-8?B?SHMrNHRIYlFHYmpyZ0VmWGhlcXBRcHFKRktaTWVZV1JrejYrL3FZdDg5VjZJ?=
 =?utf-8?B?a1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?RW1CMmhNUGV0M0tVdWpQWFpzV0M5WnRoWmtGR3Z1dXRjL0x6cDFoUDdkSG5Y?=
 =?utf-8?B?Vmg3UnhTNUtmcWhiRGNsSnFVeFJMUDhUQWJUcFRuTnN5T2xTUE5SUllpb1kv?=
 =?utf-8?B?OXJQR1d4Mk84S0FuN1FOZmY4R1RDL3oxVkszRjFuNlpFQm9FcUdQcFB4VjVh?=
 =?utf-8?B?am1Lanc4YVBtUEJMeHc1c1V2TlBYdlRsT2FwWVlUZWIwS25oNTEraEZUL2pU?=
 =?utf-8?B?NjIzRzZFVmowNjkwY3RXNWY5SFFPd0lRaUNJVEhFaW12UlY5cDdpRFo5N0FJ?=
 =?utf-8?B?ZEZWd0JJNnZseUZ5VFBvWEJ0c1lPc2R0am84WndyOFo5c2ZCOFYvQWNYUnhi?=
 =?utf-8?B?UnVxd2MvWmhTSE90OWNnelc0TzRxUjIrdnRqMWRWdkN4R29OQ2NYU1FFeitP?=
 =?utf-8?B?NHZxcTY0NUo3ckFkTWRrYkFoOTduSFI0Y2wrQlNieHFyQVl2bEtVUDhaQ0o1?=
 =?utf-8?B?S2ZMNkJyQ3I4Yitzb1NrWi8xMUJocnRUTk54TXo1SVNRUExZcWNUNlc1Q1N5?=
 =?utf-8?B?OVJaZGZDcG9mRmQ0Z0VMNlAzZy9jK2ZKSk45TEtGa0RhUTl4TWlZSkxUN3NK?=
 =?utf-8?B?MkNTM2UraUF5V1BodWN1OTVMbi9hNVpoUG9IK21BUWNpS1FRQnM2MUVDUlBs?=
 =?utf-8?B?ZzRxaTBsQ2JwbkJldU9ja3htUlF0SlhtOFRqYkxkWGFzUEZsbE9iTjdzemVP?=
 =?utf-8?B?Zk9MYlhWZDFCem9XUU9MOUNQUjQ1UWZBWS9yaVBrYkVqZG1CUTNqL2N4cHNC?=
 =?utf-8?B?UlJWRi9PUkhWOWpSMUk0aTZ1bWVhZlRQeGgwVGl2L1VLTzBSbG9zc3dFU2RP?=
 =?utf-8?B?S0luS24rWjN1Y3psdEpKQ0pCRGZ0TSttL001c0p6ZGpucXlMUmU2TlRrS1Z1?=
 =?utf-8?B?WElGdTFLM3NMUDlQUHhCN2pZREI3ZCtWaTVYdWZzQzVlTmRVYlJhak5RTUJv?=
 =?utf-8?B?TGh6VnpyVmdCSWlrMVFRakFCbTZaS1Y2WlJ5SVpCakNZdENtMGRoZDhXcWEz?=
 =?utf-8?B?RlFNSFBIb2RHeEIrSUVrbHNRRUV0V1pabzRtV2d0cjZoM0lSWGZaZ1YrR0Fx?=
 =?utf-8?B?OGpmQU5lL0cxdjNGcjZwRS8zM0lWemlrV2g3VTBpY2FWWm5NaXdWbFQxV3Zx?=
 =?utf-8?B?OWZaTkhvSkc2WlJnUXJLWDFrMWtnc2pUVnBEcXRnaW9CR3pqcDI4anMxbllh?=
 =?utf-8?B?bzBiV2NGUWR1bW9nY1RUZUQvVUZwcXJGcFRvNU1iTld3aFYzWTNWTG5tM2hC?=
 =?utf-8?B?MW9ySzV4NG1lZmJRZnQvSW1RR0Jjdjh5NCtRYjh3VWpJeTR4dz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7407691-26fd-474b-9399-08daa6b7ca46
X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6362.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 09:55:54.5768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W8TQaQZFYWpY8+jp/c/CpKFKbcxLydizhL2WHk40Sch/584hHaviRAGXf7YHINWzHM/xdbiALD1/nSHqbcNWAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6861

On Tue, Oct 04, 2022 at 05:08:09PM +0100, Andrew Cooper wrote:
> A future change will want a cpuid-like identifier which doesn't have a mapping
> to a feature bit.

Why we prefer this logic over just giving such pseudo features a
synthetic bit or akin?

Could we have a bit more of a description about what would be
considered a pseudo feature?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 10:20:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 10:20:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416038.660652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og1W5-0001Q8-Ei; Wed, 05 Oct 2022 10:20:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416038.660652; Wed, 05 Oct 2022 10:20:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og1W5-0001Q1-Bt; Wed, 05 Oct 2022 10:20:41 +0000
Received: by outflank-mailman (input) for mailman id 416038;
 Wed, 05 Oct 2022 10:20:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NzUo=2G=citrix.com=prvs=27000a6ca=roger.pau@srs-se1.protection.inumbo.net>)
 id 1og1W3-0001Pv-VF
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 10:20:40 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 548cf85a-4497-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 12:20:28 +0200 (CEST)
Received: from mail-sn1anam02lp2041.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 06:20:30 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM8PR03MB6214.namprd03.prod.outlook.com (2603:10b6:8:3d::5) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5676.24; Wed, 5 Oct 2022 10:20:27 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022
 10:20:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 548cf85a-4497-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664965236;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=oNRKdwI6uo6H3H+B9FQ4Pws6Sngmm0FTJHlhwatJmVs=;
  b=fufRr5e7yAJ57/IY94IBFB7j/zPm19Fu/MNBj/J4+yF7v1DIRknfLIoO
   gZc1iOvcRZujtg/FQvY1uS4bluQWpPYPtTAMWBtkT4P9BGdKXHV4SGJPI
   2BAtkWeedxBczJ5yCyR8k8bphj63xX/Pn+yFIMgzM7cbFizZcmwqFHt9Y
   Y=;
X-IronPort-RemoteIP: 104.47.57.41
X-IronPort-MID: 81134260
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:QLOMPK9iXOTiKbOxBUk5DrUDdX+TJUtcMsCJ2f8bNWPcYEJGY0x3y
 WoeXjyGP62KM2TxfdB1Po2y9hxQu5DTm9dgHlM4qns8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5gFmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tpIJ3NL9
 6MJEhpXMQzciL2EzqC/SuY506zPLOGzVG8ekldJ6GmDSM0AGNXESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxvzG7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVqyv32rWRxUsXXqoCGoTmy8Axn2HQ5WYjEzdKfAuch7623xvWt9V3b
 hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xJEIJUzpAY9wOr9ItSHoh0
 Vrht8ztLSxitvuSU3313peZqymjfxccK2AqbDUBCwAC5rHLpYgpixvVQ9VLEairj8b0EzX93
 zCLqiclg7wZy8UM0s2T8V3CghqtoIbIVQ8/4gjLXmOj4Rh9bYTjbIutgWU39t5FJYedC0KH5
 XECks3GtuQWV8nRzWqKXfkHG6yv67CdKjrAjFVzHp4nsTOw53qkeoMW6zZ7TKt0Dvs5lfbSS
 Be7kWtsCFV7ZRNGsYcfj1qNNvkX
IronPort-HdrOrdr: A9a23:L5OWWKCQJ7NWS8TlHejMsseALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN
 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d
 enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA
 H+4kbEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut
 jRpBULOdh19hrqDyqIiCqo/zOl/Ccl6nfkx1PdqXz/ofbhTDZ/L8Zan4pWfjbQ9kJl5bhHoe
 p29lPck6ASIQLLnSz76dSNfxZ2lnCsqX5nteIIlXRQXaYXdbcUh40C+0F+FosGAUvBmckaOd
 grKPuZyOddcFucYXyclm5zwOa0VnB2JRuCSlhqgL3h7xFm2FRCi2cIzs0WmXkNsLgnTYNf2u
 jCOqN00JlTU84/d8tGdak8aPryLlaIbQPHMWqUL1iiProAIWjxp5n+56hwzP22eaYP0IA5lP
 36IRxlXFYJCgLT4PC1rd52GkinehT+Yd2t8LAT23FBgMy8eFKxWhfzDWzHkKOb0oci64PgKr
 KO0altco/exFvVaPh0NjLFKuhvwFklIbkoU4UAKiWzi/OODLHWncrmV9uWDIbRMF8fKxDC6z
 04LXXOGPk=
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="81134260"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ak1s+zygFGg9jAXsm8NAhPXsBpqHU5ve20HVBalcGHTT/2urm4RWpRUx4Orz89L1LBF+5vHD5jePBKUcPbsssx5cV/ogtNRuyHHWSjr9thqurKItw1wqmNk++gtDCsIne2Ez7NuLEZc3EKVpUBEF1jSpbbps17KTqguyyLbMFKNPH0WDydyz8BJo4Q4vra6aCUkJ93QST+AKQDrlcMs4qHflwEZhDV1/KeR8UsgCBPiMp5eO2Tz/f+8J3JfMaGETKPyRAisOfjq+Oxmu5GN4tucRQBXKYb7YHhqQKCD9bnt0cX/vElTgDLx7+0z5qiVt/Cf50NjpzS8cvP3fqXNOvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tqfDtY1zyJirZeBvXhIJQBhuWBd58J1TjVocdM9ECA0=;
 b=cuoklVYa/2utu7GvFyGayFDdow6QKiJIHAHny5qY8wojzklf6/iPFKbpZhnhvQGHp6HXax1olS+0gIDx529fYg2gEq/18NFRjaYC1AjX8OjFIX9jQOjuVC0AKhhLofsKKrSuJXOQ+3yCpZJqB0zrZz229enLNvFkurmZMVgvu2Kw1qyKmut91nkJ8aoKY/jWxVrZKsny859ufpBZGNMVQ4QhJkCe2Yws8f45CW77NwjyWTUlHyi/kSAAKD+SyGLkH8RXbGRX/se/oyNlB+doyqMqclSZPuNh84vaZ1DFB8WK7zDzHA4xmXsql9AkVhwQUm2QG2jUNM2wO5rG657UlA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tqfDtY1zyJirZeBvXhIJQBhuWBd58J1TjVocdM9ECA0=;
 b=DbyYRndVG7YgYxtO1iOp96QQKg8gbw74UtxRtBbxaoLVVSPEy8x00UUi5fCm/iPK0Ih/RQsqb8HNR4/RxkzayTDYbYOqpUILys0mlo97bFK4BSqYsYSwwqv8Xylse39VwPxdtXxihUv6WMdG89Zdq1QNNywpiqV34Cg5JJDpmHM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 5 Oct 2022 12:20:20 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>
Subject: Re: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by
 default
Message-ID: <Yz1aZJx5AZae/2U5@Air-de-Roger>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221004160810.25364-3-andrew.cooper3@citrix.com>
X-ClientProxiedBy: LO2P123CA0047.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::35)
 To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM8PR03MB6214:EE_
X-MS-Office365-Filtering-Correlation-Id: fa2118ad-1627-49fa-1483-08daa6bb37c4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3pTZ6MkL3xfGaYkW4KhdkH9WjNFXbDdaYZKSYNcdCQ7SCjRArXtoLpCw68ZlkoN0qy2gPH3JEEt68FjUFbAspUoppF/+rFXshH/9cfd7TLb2KIlmS4F8SGQhZIn1xDHpXvz3Kkucpf+pO9Z+Iy4rS+t+FRJhqIzkVdtsIRBtlx0H1OOM6t30PrIvaHzgSLJ/FOjcTeAvn6ileEBQs+AwzemqyN5v1UA0hiBL7S9HdB2xxM5q70azZ9oEwOV04iqOQqf7TIsSqt6eEks2WpvB6Tt+RjCRQeN14U7kLSEGmpB85G4pPj7z4hTTvhIaDfEsp3D73pKdsel8g/ojPeZpplM2fTmRDbGxXRbu4aT4XbCRHfi5zQMMPkxYFUmF+GRPHlVC/8NC+Z/O3ad4aQa5HHWU9Payf1WPzEg1uaGFM6DbXOnHK/O3eUYvyeN+mRQRCgnVKMEYZbW49ROJd6jJPtOOhvV099Tmodpx1yEAOzuTaPy+N1xDB3qFUwWCIHK5YiP69Wh6FtgMoW1x80zKSvAbLWKVj7TikCGc+1eql0dz7+bKsM2xhtMLSkJHXICTKwIjzCpwvgNz7NTavN4WgrAZiqwXS78XeP9wHSAFyImK1t41w86U5DBEAg7hBeeDmr0vgYBKg6jPD5B+tQpKm9F2W5+7YLxpwuN7P+FbLw2o8MJ3FIpsatVpS+B83F+cg93/1f+W6dDw6/lry/WR7w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(33716001)(9686003)(2906002)(6512007)(26005)(41300700001)(6506007)(6666004)(85182001)(5660300002)(478600001)(6486002)(38100700002)(82960400001)(86362001)(6862004)(8936002)(66574015)(186003)(83380400001)(316002)(66556008)(6636002)(66476007)(66946007)(54906003)(8676002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QnZtM0N6OWRYVitYejhoaHcybE1OTDAwT1ZKbUtteVJDSzFQWUUyQW9xamtM?=
 =?utf-8?B?eGx6M05oWFd0dFN4N20xcURLeDM0NjR3VXcxVmdoWkQ3UjlaYzBOaWo3a0Zu?=
 =?utf-8?B?RndTa1gzRVRZZ2RIeDBnbE5aZHlwRTc2czN6SXkrV0ErL0lLZkxKUStaMnpE?=
 =?utf-8?B?N3dWZTBOWUJzby9ISzllL2lKWGRja1NMcXVtZmdwL3lPeVpneHNzSjNoT0xB?=
 =?utf-8?B?SnN6aHFRT1FuOU45bW5TcElCWDNxS2Nja1Z0UGFlMDM1N1RpMEFDc1ppSTZY?=
 =?utf-8?B?VVgxRjlWc01VczJlWDVVM0xYekkrVnQxYVl0a21FUW8xTElhb2tvcDRwTkJF?=
 =?utf-8?B?eGlHcjRHWVpIZHJUTnhhOXc3Qy9BQVFXYnBsN1FzcGs1UjZia1dnUlVJZU9I?=
 =?utf-8?B?U1Vsd0xZc3FPUUcrV0kvSWV0K3BlcHFLRHJia010Wm1GNjBxV0xoaFVTSTMz?=
 =?utf-8?B?RU13M1RVZENQaFRxWmd3VlBPTFRkYTFLdUxWKy9GNU5SNDd0dVVRTVRaSkR2?=
 =?utf-8?B?Tm9aQzIwNXVENkw4Qk4rdjR3NlZiR2VDbEYxRWd2ZFU5U2JQeXJZbWtudUJp?=
 =?utf-8?B?TkVndit0dXNqbk0rVkpWTiswVnhndVVmU29wVnhBMHRVa0JxMnlSa2J3VlRm?=
 =?utf-8?B?ZnRlWjN1azhEbDZGR282NnBjWVlKaURBdCtaU3B2WlZXWG9tK05FWVlFdFdP?=
 =?utf-8?B?L0FGTFFTY1l6ckxmYzNjT3lNVkgvbmdBZUxtRng0cWNVamNwVllsMUlmN3U5?=
 =?utf-8?B?ODFWZXpDWExkM3JxK2RaR0dxRzgzcjhBNm56cnFuSzhIWHlLTzlYcTJwOUI2?=
 =?utf-8?B?d01CSHJyVnBNNzN6T21ZQkVDek81ZlNtRkNJclFxU21SS2lZaXpVSWsvdFA3?=
 =?utf-8?B?eWk0OXNJSXUvQ0Fza3NPZ0FqQzBqSVpZNWdNbUVCNEN0V1FkNzk1aDY3OFBM?=
 =?utf-8?B?dkVEcGxqZGJoNzVnYlpOb1orSWwwOGtCdUlBQSt4ZnhLS3ZrTkdwYzk5cWFX?=
 =?utf-8?B?UmN0NHN0RWUvcFBOS1dDU2RiTTVCQ1pjSTB5Q0lJTXNOUzZURzdRQUVzcWJ4?=
 =?utf-8?B?S3M4ZmwyREdZT2F1K0F4SXpLWW96Ukd1aS8vZVFkVUJkYXFUK05LbHM3Wjli?=
 =?utf-8?B?OEJJTEx4ODhPVFZKblQyY0NuaXV4eStqQXBkWDlOZnBYaHBEQzJUTk0xYU51?=
 =?utf-8?B?WHNrS2ZPMXBTSkN3eSt1U3RDRGUrY0xWMHAySk4vQjE5M09XMS9GTnBaRWRa?=
 =?utf-8?B?WVY2SDVnSHl1cXlZSEJEQWdJTHY2Q0dRRENZZnJJa0ZzeEZMendZeCt4L3hL?=
 =?utf-8?B?RUJqVG9WS1dPbFJndmltdk5wUzF6c2Q3RzR0QyswUDBoQ1k1SENBN0JmMWFi?=
 =?utf-8?B?bEVFZzM5TkxTV2xIYXBYSWo2QUdqMlZyTDRrRkFYdCtvTkkwckZ5ME1QZ2w0?=
 =?utf-8?B?Ri9NS3M2T3BwTEQrdG9sT2xnVThqQkQyWWhCN1ZuRTZ1YU5UbXVzTGhjNmY1?=
 =?utf-8?B?a2Exem44WVFaMDB2eEZjWWRFRnZzZVNIYm9XeTlEdHdicWlZNS8xOWNvUXRm?=
 =?utf-8?B?bkZ6NklSam1zODVuQ21ncTNIaEtVYW92OWpNRHZ6K1AveXMvb3JNNWJoditH?=
 =?utf-8?B?QjVhNXY3ODUwQm5GSzh5TXZreW9LbWZWVkRBN3BmVFRZQXlNb3FCTEJvdmxt?=
 =?utf-8?B?V0h0b0JWTjdCeXdwRUtIZzc0S2liNjVlcHBVOXN3NU1XOFRhRGxDOTJncTRp?=
 =?utf-8?B?SWkreHNPZUl5dm9YZ1pJYjVLdzdqYXJwQjdkUnZCODkvOFZVZzhOSkxqR1FJ?=
 =?utf-8?B?RU9ld3Q4TldTMDhjQ3hORHFTbE9JWk5YTGpKQVNLem5MQ3dvOVdUS3hOenpD?=
 =?utf-8?B?WHNXQ3Y3R1BDZXUxMFpJaXM5akNJQzZldi9jSGNqY1Q1Z0RlNFAyd0xTa1V5?=
 =?utf-8?B?R1RGdlM2YzNIY0REU3JRUGhpdHBWTExOUjgzTmZNRnVtNitNR2ZQbGx5dXdx?=
 =?utf-8?B?dGpGRktUWndoc3JTVDZiekUybTI3bm1zTlNxUEU0dHNPZDBBWmEvYmYrOXRi?=
 =?utf-8?B?UjhZYUZPVGd0d0tROVBXSHF5VExOTThYdnhJYkpBbWROQzFPNzNWbEFqeTF3?=
 =?utf-8?B?dEo4VWJYaHlwYjRlN1FVQmZkMlJja3dieWpURDV1NktoQ09kNWJ1TE1ZdlZT?=
 =?utf-8?B?ZlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?MGp0S0RWNStvVGE3emx1QUg1TVhpcnRicDEzaVpzTk9KVkw2WlRqUnkwOHpI?=
 =?utf-8?B?a2ZsM3QzMnpkRVkzMy84Zko4MFQ5a0oyc1RwYUxrdUxXYVplelUzK1A5dVU1?=
 =?utf-8?B?UnRXZFM4dC9ieGoxc0RDL2ZLa3d6akhEc0J3ZG1LVlFqM01TSGw5WThkblVL?=
 =?utf-8?B?dnF4VzN6WjhUM3cvcmtsQm9NUUI4UEZkUUM5Um9lMVAzUm9OYysrRVl0cGc0?=
 =?utf-8?B?emtuZmlrMERNR2QvRDZHWG9QSzd1SitRdjh0QXdkZElieUdjamRZbzl3TlVO?=
 =?utf-8?B?ajdDVE83a0xQNlBkY0laMWgrUy82cU5BS2hQdXR0VUQyY1NVR2ZvUXZYYlZU?=
 =?utf-8?B?OHlOeFFHMG9TdWdlYmF2eXdHQkVFaHV4STl3NnVRcUFXSkNDV01yejAvT0hl?=
 =?utf-8?B?V3g1UGtrOGM3a0o4SDhqLzBpb0w3MXpmcTMwTWhCK2pvUklDV3JGNU4rMSsy?=
 =?utf-8?B?QlBYWCtGM2pSNGIxdnZrbXVKNTkyMGhKQ1I5RzdBcjRpTGIxUTJQQnFXbzgr?=
 =?utf-8?B?b2ZGNkdQejJieCtGam9uT1VsdTdyRCtoQm9pbHZWU3d6bm0wbXExQVptdloz?=
 =?utf-8?B?Sy9PVlpNdVVDM1NBM2NVdU9qZUord1pnTmxuZVBwN3R1QUY2cjFONTFoYWdm?=
 =?utf-8?B?Mzh4SWZlMGhCZWhDR1hyVzNESFg2R3JCZjFyUFZycHB2MHJjTkhvb0tLZjE0?=
 =?utf-8?B?VTdXMElQUE5ybzZpOHBJT0xqc05jdGFYcUxzSTFwTXhuQzdydkxvUStTd2dM?=
 =?utf-8?B?OXF4SS8wWUxhbDhWelI0ZjAxLzhZTWlKSEY1R2RNallGdlNsRnczSHNaTmR6?=
 =?utf-8?B?cXJZT3ZIY2hiUnB6d3ZGSUJMQWxsWkxtQW1Fc1lkeWNmZWhaV3c4VE83YmU1?=
 =?utf-8?B?NHNnVmpQSnhWc0FRSlRrQ0Q5VXZyeitWbmsyNTFQeUVTVFphVjVwaTl2ODdw?=
 =?utf-8?B?RVZNemxKRThoOEJTVnAvVC8vV2I4WXBCUWIzSGVlbUJqZ2dhQXFqMVo5Z0Zh?=
 =?utf-8?B?ZFdLMUdOUVdncUg3RXpsdU9sSzNvR1FBclBtb2VMRHdySFdHblpuWHVOT0N4?=
 =?utf-8?B?bDdQSFJndnI0VDRlSmdwU2xBZFF5VWlmTWFyZXNSeUcwWlVodlh4d0ZEdnFj?=
 =?utf-8?B?VXVRU0pRdVJ1YTdYMXFuUXZtRkRmWkFiS1lrbkllbm9KS0RmcU9GdXJ2ZXNh?=
 =?utf-8?B?VUlEMDNsSHFUclhqNVN4ZGNPSC9WVUREZ2gvOGFGTHpOMkxyVkFFNGJhYkJO?=
 =?utf-8?B?RFpxK3RZeURoWHJYbEhxVElWVGlXaStVTXVrWGhyVHlsdHU5QT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa2118ad-1627-49fa-1483-08daa6bb37c4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 10:20:27.0884
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VsO8l64kNHm3hWiCpzNanxAlfabg/+oCZH9HyhEyP3tAjtTIagBpxRGW1B2KGgEvmo/RMSLxk0ZN8ggH70fy0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6214

On Tue, Oct 04, 2022 at 05:08:10PM +0100, Andrew Cooper wrote:
> Intel IceLake and later CPUs have microarchitectural behaviours which cause
> data-dependent timing behaviour.  This is not an issue for 99% of software,
> but it is a problem for cryptography routines.  On these CPUs, a new
> architectural feature, DOITM, was retrofitted in microcode.
> 
> For now, Xen can't enumerate DOITM to guest kernels; getting this working is
> still in progress.  The consequence is that guest kernels will incorrectly
> conclude that they are safe.
> 
> To maintain the safety of current software, activate DOITM unilaterally.  This
> will be relaxed in the future when we can enumerate the feature properly to
> guests.
> 
> As an emergency stopgap, this behaviour can be disabled by specifying
> `cpuid=no-doitm` on Xen's command line, but is not guaranteed ABI moving
> forward.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Henry Wang <Henry.Wang@arm.com>
> CC: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> CC: Demi Marie Obenour <demi@invisiblethingslab.com>
> ---
>  xen/arch/x86/cpu/common.c            | 29 +++++++++++++++++++++++++++++
>  xen/arch/x86/cpuid.c                 |  5 +++++
>  xen/arch/x86/include/asm/processor.h |  2 ++
>  xen/tools/gen-cpuid.py               |  2 ++
>  4 files changed, 38 insertions(+)
> 
> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
> index 0412dbc915e5..8c46a4db430a 100644
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -209,6 +209,34 @@ void ctxt_switch_levelling(const struct vcpu *next)
>  		alternative_vcall(ctxt_switch_masking, next);
>  }
>  
> +bool __ro_after_init opt_doitm = true;
> +
> +static void doitm_init(void)
> +{
> +    uint64_t val;
> +
> +    if ( !opt_doitm || !cpu_has_arch_caps )
> +        return;
> +
> +    rdmsrl(MSR_ARCH_CAPABILITIES, val);
> +    if ( !(val & ARCH_CAPS_DOITM) )
> +        return;
> +
> +    /*
> +     * We are currently unable to enumerate MSR_ARCH_CAPS to guest.  As a
> +     * consequence, guest kernels will believe they're safe even when they are
> +     * not.
> +     *
> +     * Until we can enumerate DOITM properly for guests, set it unilaterally.
> +     * This prevents otherwise-correct crypto from becoming vulnerable to
> +     * timing sidechannels.
> +     */
> +
> +    rdmsrl(MSR_UARCH_MISC_CTRL, val);
> +    val |= UARCH_CTRL_DOITM;
> +    wrmsrl(MSR_UARCH_MISC_CTRL, val);

Is it possible for the firmware to have enabled DOITM and Xen needing to
clear it if !opt_doitm?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 10:45:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 10:45:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416047.660662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og1tN-0003va-FU; Wed, 05 Oct 2022 10:44:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416047.660662; Wed, 05 Oct 2022 10:44:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og1tN-0003vT-Ct; Wed, 05 Oct 2022 10:44:45 +0000
Received: by outflank-mailman (input) for mailman id 416047;
 Wed, 05 Oct 2022 10:44:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1og1tM-0003vN-Kn
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 10:44:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1og1tK-00061W-IR; Wed, 05 Oct 2022 10:44:42 +0000
Received: from [15.248.2.148] (helo=[10.24.67.30])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1og1tK-0003NP-AD; Wed, 05 Oct 2022 10:44:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=CYMuxihqC4AfAG0cHSQDhpXhlHLgEa1zHmWlXfgXLT8=; b=m1GfsfQ6S+5HdP9fsKGdXrH8I6
	JVj4DbEDRjZkFAjjwOolv7adeNnFXyOwNkDqdj/zy680K6TfEWMbyDrtLQFn7stJ2EsOow+0UfKVr
	X09L0wE4Qg2YeFF9yf/cVYoUrSz7vCndHpxJar496pLzY7H7TxtK8f8DB4L6DH0CkjS4=;
Message-ID: <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
Date: Wed, 5 Oct 2022 11:44:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 04/10/2022 16:58, Jan Beulich wrote:
> On 30.09.2022 14:51, Bertrand Marquis wrote:
>>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>
>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>> higher priority than the type of the range. To avoid accessing memory at
>>> runtime which was re-used for other purposes, make
>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>
>>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
> 
> Thanks. However ...
> 
>>> ---
>>> Partly RFC for Arm, for two reasons:
>>>
>>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>>> For one like on x86 such ranges would likely better be retained, as Dom0
>>> may (will?) have a need to look at tables placed there. Plus converting
>>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>>> me as well. I'd be inclined to make the latter adjustment right here
>>> (while the other change probably would better be separate, if there
>>> aren't actually reasons for the present behavior).
> 
> ... any views on this WB aspect at least (also Stefano or Julien)? Would be
> good to know before I send v2.

I don't quite understand what you are questioning here. Looking at the 
code, EfiACPIReclaimMemory will not be converted to RAM but added in a 
separate array.

Furthermore, all the EfiACPIReclaimMemory regions will be passed to dom0 
(see acpi_create_efi_mmap_table()).

So to me the code looks correct.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 10:45:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 10:45:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416054.660674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og1uD-0004T3-Or; Wed, 05 Oct 2022 10:45:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416054.660674; Wed, 05 Oct 2022 10:45:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og1uD-0004Sv-Lh; Wed, 05 Oct 2022 10:45:37 +0000
Received: by outflank-mailman (input) for mailman id 416054;
 Wed, 05 Oct 2022 10:45:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og1uD-0004Sh-0x; Wed, 05 Oct 2022 10:45:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og1uC-00065r-VL; Wed, 05 Oct 2022 10:45:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og1uC-0001pF-IF; Wed, 05 Oct 2022 10:45:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1og1uC-0007Y5-Hk; Wed, 05 Oct 2022 10:45:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xsxUSUaQrc0j5eQNJVLaaAAic929H6PnoWeleRjxOdQ=; b=LkLNREwv7t48JalGj/EHTvr3q7
	ovsFjIlPy3sXDGYjDtFY5EfAX1+S5HZ4y+tsmVsh/RnCggkrUIXgqzpNTWzGTV1DEFaZmKz0VwLrl
	imdoCJSkKmVWejTnY9Ec3M/0BC+WI4EcHXTR8WSLDhddivLeMBbxS+/CDjl0txlpFhX8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173423-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173423: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=92f7aafced8d354cead03e50e1e7d57a99d29435
X-Osstest-Versions-That:
    libvirt=d6245e36c24969efcaa835ce6e9a9c953f47cc87
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 10:45:36 +0000

flight 173423 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173423/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173413
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173413
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173413
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              92f7aafced8d354cead03e50e1e7d57a99d29435
baseline version:
 libvirt              d6245e36c24969efcaa835ce6e9a9c953f47cc87

Last test of basis   173413  2022-10-04 04:25:20 Z    1 days
Testing same since   173423  2022-10-05 04:20:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Michal Privoznik <mprivozn@redhat.com>
  Peter Krempa <pkrempa@redhat.com>
  Stefan Berger <stefanb@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   d6245e36c2..92f7aafced  92f7aafced8d354cead03e50e1e7d57a99d29435 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:03:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:03:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416065.660684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BA-0006sh-8D; Wed, 05 Oct 2022 11:03:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416065.660684; Wed, 05 Oct 2022 11:03:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BA-0006sa-5Z; Wed, 05 Oct 2022 11:03:08 +0000
Received: by outflank-mailman (input) for mailman id 416065;
 Wed, 05 Oct 2022 11:03:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og2B8-0006sU-Sj
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:03:06 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4998a7f4-449d-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 13:03:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0FDCB218FE;
 Wed,  5 Oct 2022 11:03:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B03A313345;
 Wed,  5 Oct 2022 11:03:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id dt+zKWhkPWPbQgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 11:03:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4998a7f4-449d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664967785; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Mn2ERzJt4xEctpaemvG4sO9hC3a9tpeTQ3BtEW76vKI=;
	b=PfVG4z/1OzaVpXpTB/EtYtDvm0Clx6Ojw24ScC8wkwrg3FX8MZ8CHsTfH1GXTTEqfOLljI
	152mpZVrMGozo3d/l+uCpTkGfqL//JcoKMWw2bvXKyPv1mgILh/FNFjVO1X1o+Cwc253iA
	3zrdguoCBHG1ytezJtEmFNBAJURdWzg=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	linux-doc@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH v3 0/4] xen/pv: sanitize xen pv guest msr accesses
Date: Wed,  5 Oct 2022 13:02:58 +0200
Message-Id: <20221005110302.13455-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Historically when running as Xen PV guest all MSR accesses have been
silently swallowing any GP faults, even when the kernel was using not
the *msr_safe() access functions.

Change that by making the behavior controllable via kernel config and
via a boot parameter.

This will help finding paths where MSRs are being accessed under Xen
which are not emulated by the hypervisor.

Changes in V3:
- new patch 2
- addressed comments

Juergen Gross (4):
  xen/pv: add fault recovery control to pmu msr accesses
  xen/pv: fix vendor checks for pmu emulation
  xen/pv: refactor msr access functions to support safe and unsafe
    accesses
  xen/pv: support selecting safe/unsafe msr accesses

 .../admin-guide/kernel-parameters.txt         |  6 ++
 arch/x86/xen/Kconfig                          |  9 ++
 arch/x86/xen/enlighten_pv.c                   | 99 +++++++++++++------
 arch/x86/xen/pmu.c                            | 71 +++++++------
 4 files changed, 127 insertions(+), 58 deletions(-)

-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:03:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:03:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416066.660696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BF-000799-G2; Wed, 05 Oct 2022 11:03:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416066.660696; Wed, 05 Oct 2022 11:03:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BF-000792-D0; Wed, 05 Oct 2022 11:03:13 +0000
Received: by outflank-mailman (input) for mailman id 416066;
 Wed, 05 Oct 2022 11:03:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og2BD-0006sU-P6
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:03:11 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4cd77590-449d-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 13:03:11 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B584C1F8A3;
 Wed,  5 Oct 2022 11:03:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6FD9713345;
 Wed,  5 Oct 2022 11:03:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id tT8WGm5kPWPmQgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 11:03:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4cd77590-449d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664967790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZjfiyOlyqF25zTBDZULVk0UdTR16lW+0ZSJokbWtjEI=;
	b=mybiJLJXqY902Vp/rd3sqvMwiEKnCTgtRLXgK5oq+rrLSTp2pFMmn6YH/hWAdU//eFxwAp
	cdVcSzknEyIofxPePN/tqIyJAEP6E22WM5xXlKVfwA0Q8zmPaXg0b3Wv1hPWQl8M5Methq
	bflyIfbkTWugKokBYTizibEOrCLw1Jo=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v3 1/4] xen/pv: add fault recovery control to pmu msr accesses
Date: Wed,  5 Oct 2022 13:02:59 +0200
Message-Id: <20221005110302.13455-2-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221005110302.13455-1-jgross@suse.com>
References: <20221005110302.13455-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants
of read/write MSR in case the MSR access isn't emulated via Xen. Allow
the caller to select that faults should not be recovered from by passing
NULL for the error pointer.

Restructure the code to make it more readable.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- do some restructuring (Jan Beulich, Boris Ostrovsky)
V3:
- commit message rephrasing (Jan Beulich)
- more restructuring (Boris Ostrovsky)
---
 arch/x86/xen/pmu.c | 66 ++++++++++++++++++++++++++--------------------
 1 file changed, 38 insertions(+), 28 deletions(-)

diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 21ecbe754cb2..0f98cb1077e3 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -131,6 +131,9 @@ static inline uint32_t get_fam15h_addr(u32 addr)
 
 static inline bool is_amd_pmu_msr(unsigned int msr)
 {
+	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
+		return false;
+
 	if ((msr >= MSR_F15H_PERF_CTL &&
 	     msr < MSR_F15H_PERF_CTR + (amd_num_counters * 2)) ||
 	    (msr >= MSR_K7_EVNTSEL0 &&
@@ -144,6 +147,9 @@ static int is_intel_pmu_msr(u32 msr_index, int *type, int *index)
 {
 	u32 msr_index_pmc;
 
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
+		return false;
+
 	switch (msr_index) {
 	case MSR_CORE_PERF_FIXED_CTR_CTRL:
 	case MSR_IA32_DS_AREA:
@@ -290,48 +296,52 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read)
 	return false;
 }
 
+static bool pmu_msr_chk_emulated(unsigned int msr, uint64_t *val, bool is_read,
+				 bool *emul)
+{
+	int type, index;
+
+	if (is_amd_pmu_msr(msr))
+		*emul = xen_amd_pmu_emulate(msr, val, is_read);
+	else if (is_intel_pmu_msr(msr, &type, &index))
+		*emul = xen_intel_pmu_emulate(msr, val, type, index, is_read);
+	else
+		return false;
+
+	return true;
+}
+
 bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err)
 {
-	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
-		if (is_amd_pmu_msr(msr)) {
-			if (!xen_amd_pmu_emulate(msr, val, 1))
-				*val = native_read_msr_safe(msr, err);
-			return true;
-		}
-	} else {
-		int type, index;
+	bool emulated;
 
-		if (is_intel_pmu_msr(msr, &type, &index)) {
-			if (!xen_intel_pmu_emulate(msr, val, type, index, 1))
-				*val = native_read_msr_safe(msr, err);
-			return true;
-		}
+	if (!pmu_msr_chk_emulated(msr, val, true, &emulated))
+		return false;
+
+	if (!emulated) {
+		*val = err ? native_read_msr_safe(msr, err)
+			   : native_read_msr(msr);
 	}
 
-	return false;
+	return true;
 }
 
 bool pmu_msr_write(unsigned int msr, uint32_t low, uint32_t high, int *err)
 {
 	uint64_t val = ((uint64_t)high << 32) | low;
+	bool emulated;
 
-	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
-		if (is_amd_pmu_msr(msr)) {
-			if (!xen_amd_pmu_emulate(msr, &val, 0))
-				*err = native_write_msr_safe(msr, low, high);
-			return true;
-		}
-	} else {
-		int type, index;
+	if (!pmu_msr_chk_emulated(msr, &val, false, &emulated))
+		return false;
 
-		if (is_intel_pmu_msr(msr, &type, &index)) {
-			if (!xen_intel_pmu_emulate(msr, &val, type, index, 0))
-				*err = native_write_msr_safe(msr, low, high);
-			return true;
-		}
+	if (!emulated) {
+		if (err)
+			*err = native_write_msr_safe(msr, low, high);
+		else
+			native_write_msr(msr, low, high);
 	}
 
-	return false;
+	return true;
 }
 
 static unsigned long long xen_amd_read_pmc(int counter)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:03:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:03:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416067.660707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BL-0007TM-OY; Wed, 05 Oct 2022 11:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416067.660707; Wed, 05 Oct 2022 11:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BL-0007TF-LN; Wed, 05 Oct 2022 11:03:19 +0000
Received: by outflank-mailman (input) for mailman id 416067;
 Wed, 05 Oct 2022 11:03:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og2BK-0006sU-7o
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:03:18 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50cf3168-449d-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 13:03:17 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 80DCF1F8AB;
 Wed,  5 Oct 2022 11:03:16 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3070713345;
 Wed,  5 Oct 2022 11:03:16 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id d+WECnRkPWPuQgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 11:03:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50cf3168-449d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664967796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NgtM+cfFBEjh9AiQx5LN2dKosLbrkZH1H9ph//hZGgs=;
	b=XqHIoGAWRFHVdku3EPpUHfUMz4kPcAG//ZNU/RgZ8UGEc0lXY4f4KuiUN58CNeQ28xRRj2
	yE+jiMVJjcy27h6BEoB2gHLncmekAggN/qUczrNNTTi4JT9K77SkKU57gy2XB7ej85tEKa
	sfiuzAlrj9Jmht9AWUG8RvUqUyVFZLc=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 2/4] xen/pv: fix vendor checks for pmu emulation
Date: Wed,  5 Oct 2022 13:03:00 +0200
Message-Id: <20221005110302.13455-3-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221005110302.13455-1-jgross@suse.com>
References: <20221005110302.13455-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The CPU vendor checks for pmu emulation are rather limited today, as
the assumption seems to be that only Intel and AMD are existing and/or
supported vendors.

Fix that by handling Centaur and Zhaoxin CPUs the same way as Intel,
and Hygon the same way as AMD.

While at it fix the return type of is_intel_pmu_msr().

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V3:
- new patch
---
 arch/x86/xen/pmu.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 0f98cb1077e3..68aff1382872 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -131,7 +131,8 @@ static inline uint32_t get_fam15h_addr(u32 addr)
 
 static inline bool is_amd_pmu_msr(unsigned int msr)
 {
-	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD &&
+	    boot_cpu_data.x86_vendor != X86_VENDOR_HYGON)
 		return false;
 
 	if ((msr >= MSR_F15H_PERF_CTL &&
@@ -143,11 +144,13 @@ static inline bool is_amd_pmu_msr(unsigned int msr)
 	return false;
 }
 
-static int is_intel_pmu_msr(u32 msr_index, int *type, int *index)
+static bool is_intel_pmu_msr(u32 msr_index, int *type, int *index)
 {
 	u32 msr_index_pmc;
 
-	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL &&
+	    boot_cpu_data.x86_vendor != X86_VENDOR_CENTAUR &&
+	    boot_cpu_data.x86_vendor != X86_VENDOR_ZHAOXIN)
 		return false;
 
 	switch (msr_index) {
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:03:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416068.660717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BR-0007os-7h; Wed, 05 Oct 2022 11:03:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416068.660717; Wed, 05 Oct 2022 11:03:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BR-0007oh-4E; Wed, 05 Oct 2022 11:03:25 +0000
Received: by outflank-mailman (input) for mailman id 416068;
 Wed, 05 Oct 2022 11:03:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og2BP-0007mt-Sj
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:03:23 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4e8be010-449d-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 13:03:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3C810218FA;
 Wed,  5 Oct 2022 11:03:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E225B13345;
 Wed,  5 Oct 2022 11:03:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id bAv1NXlkPWP9QgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 11:03:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e8be010-449d-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664967802; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BOKz5nEhUv9hbN0dMlTKN7tDv2LiEndbpY8j9esotMI=;
	b=ZNE2YXNFRD9sG12P8pUw+NoUe3PFpWe/7qNalsGr7Q4gOUklUhjzssZikAoVr+j13p2i53
	JsuyaXYG/l/sjwE4ig7IqIiPEG1TNNqH+VfmTymakAX7KdjRQ841KCgyIN+8apcB6+cqGy
	EBPpVFAOPr3doh+S81iaW88/mpjsPW4=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 3/4] xen/pv: refactor msr access functions to support safe and unsafe accesses
Date: Wed,  5 Oct 2022 13:03:01 +0200
Message-Id: <20221005110302.13455-4-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221005110302.13455-1-jgross@suse.com>
References: <20221005110302.13455-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Refactor and rename xen_read_msr_safe() and xen_write_msr_safe() to
support both cases of MSR accesses, safe ones and potentially GP-fault
generating ones.

This will prepare to no longer swallow GPs silently in xen_read_msr()
and xen_write_msr().

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- init val in xen_do_read_msr() to 0 (Jan Beulich)
---
 arch/x86/xen/enlighten_pv.c | 75 +++++++++++++++++++++++++++----------
 1 file changed, 56 insertions(+), 19 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 9b1a58dda935..d5b0844a1b7c 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -917,14 +917,18 @@ static void xen_write_cr4(unsigned long cr4)
 	native_write_cr4(cr4);
 }
 
-static u64 xen_read_msr_safe(unsigned int msr, int *err)
+static u64 xen_do_read_msr(unsigned int msr, int *err)
 {
-	u64 val;
+	u64 val = 0;	/* Avoid uninitialized value for safe variant. */
 
 	if (pmu_msr_read(msr, &val, err))
 		return val;
 
-	val = native_read_msr_safe(msr, err);
+	if (err)
+		val = native_read_msr_safe(msr, err);
+	else
+		val = native_read_msr(msr);
+
 	switch (msr) {
 	case MSR_IA32_APICBASE:
 		val &= ~X2APIC_ENABLE;
@@ -933,23 +937,39 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err)
 	return val;
 }
 
-static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
+static void set_seg(unsigned int which, unsigned int low, unsigned int high,
+		    int *err)
 {
-	int ret;
-	unsigned int which;
-	u64 base;
+	u64 base = ((u64)high << 32) | low;
+
+	if (HYPERVISOR_set_segment_base(which, base) == 0)
+		return;
 
-	ret = 0;
+	if (err)
+		*err = -EIO;
+	else
+		WARN(1, "Xen set_segment_base(%u, %llx) failed\n", which, base);
+}
 
+/*
+ * Support write_msr_safe() and write_msr() semantics.
+ * With err == NULL write_msr() semantics are selected.
+ * Supplying an err pointer requires err to be pre-initialized with 0.
+ */
+static void xen_do_write_msr(unsigned int msr, unsigned int low,
+			     unsigned int high, int *err)
+{
 	switch (msr) {
-	case MSR_FS_BASE:		which = SEGBASE_FS; goto set;
-	case MSR_KERNEL_GS_BASE:	which = SEGBASE_GS_USER; goto set;
-	case MSR_GS_BASE:		which = SEGBASE_GS_KERNEL; goto set;
-
-	set:
-		base = ((u64)high << 32) | low;
-		if (HYPERVISOR_set_segment_base(which, base) != 0)
-			ret = -EIO;
+	case MSR_FS_BASE:
+		set_seg(SEGBASE_FS, low, high, err);
+		break;
+
+	case MSR_KERNEL_GS_BASE:
+		set_seg(SEGBASE_GS_USER, low, high, err);
+		break;
+
+	case MSR_GS_BASE:
+		set_seg(SEGBASE_GS_KERNEL, low, high, err);
 		break;
 
 	case MSR_STAR:
@@ -965,11 +985,28 @@ static int xen_write_msr_safe(unsigned int msr, unsigned low, unsigned high)
 		break;
 
 	default:
-		if (!pmu_msr_write(msr, low, high, &ret))
-			ret = native_write_msr_safe(msr, low, high);
+		if (!pmu_msr_write(msr, low, high, err)) {
+			if (err)
+				*err = native_write_msr_safe(msr, low, high);
+			else
+				native_write_msr(msr, low, high);
+		}
 	}
+}
+
+static u64 xen_read_msr_safe(unsigned int msr, int *err)
+{
+	return xen_do_read_msr(msr, err);
+}
+
+static int xen_write_msr_safe(unsigned int msr, unsigned int low,
+			      unsigned int high)
+{
+	int err = 0;
+
+	xen_do_write_msr(msr, low, high, &err);
 
-	return ret;
+	return err;
 }
 
 static u64 xen_read_msr(unsigned int msr)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:03:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:03:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416069.660729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BW-0008EP-Gn; Wed, 05 Oct 2022 11:03:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416069.660729; Wed, 05 Oct 2022 11:03:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2BW-0008EG-Co; Wed, 05 Oct 2022 11:03:30 +0000
Received: by outflank-mailman (input) for mailman id 416069;
 Wed, 05 Oct 2022 11:03:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og2BU-0006sU-Tu
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:03:29 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 571f7c6e-449d-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 13:03:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id F0EB21F388;
 Wed,  5 Oct 2022 11:03:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A31B613345;
 Wed,  5 Oct 2022 11:03:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WZ6SJn9kPWMEQwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 11:03:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 571f7c6e-449d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664967808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=j+lb+y1NjPOXtKvMZH/DFSB4E2HI7Wk27OuXyDj7Pes=;
	b=NeSTlqtefVIhVrpE2j7hWcZujiU0XdWdbPT/yrn5c6+g7S+PnJHPeS8tQSPNLA2J/lIEPJ
	uUSitahwGL9qaxr4ykGiI9/9i1mis5j9Lmc3xdFGTwSBrzf5TYPd+8y7QNMgkd3Ywx0E5r
	GzTvyNBQpG77W1on4cRgnKomoFOqbYo=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	linux-doc@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v3 4/4] xen/pv: support selecting safe/unsafe msr accesses
Date: Wed,  5 Oct 2022 13:03:02 +0200
Message-Id: <20221005110302.13455-5-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221005110302.13455-1-jgross@suse.com>
References: <20221005110302.13455-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of always doing the safe variants for reading and writing MSRs
in Xen PV guests, make the behavior controllable via Kconfig option
and a boot parameter.

The default will be the current behavior, which is to always use the
safe variant.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 .../admin-guide/kernel-parameters.txt         |  6 +++++
 arch/x86/xen/Kconfig                          |  9 +++++++
 arch/x86/xen/enlighten_pv.c                   | 24 +++++++++++--------
 3 files changed, 29 insertions(+), 10 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 426fa892d311..1bda9cf18fae 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -6836,6 +6836,12 @@
 			Crash from Xen panic notifier, without executing late
 			panic() code such as dumping handler.
 
+	xen_msr_safe=	[X86,XEN]
+			Format: <bool>
+			Select whether to always use non-faulting (safe) MSR
+			access functions when running as Xen PV guest. The
+			default value is controlled by CONFIG_XEN_PV_MSR_SAFE.
+
 	xen_nopvspin	[X86,XEN]
 			Disables the qspinlock slowpath using Xen PV optimizations.
 			This parameter is obsoleted by "nopvspin" parameter, which
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 85246dd9faa1..9b1ec5d8c99c 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -92,3 +92,12 @@ config XEN_DOM0
 	select X86_X2APIC if XEN_PVH && X86_64
 	help
 	  Support running as a Xen Dom0 guest.
+
+config XEN_PV_MSR_SAFE
+	bool "Always use safe MSR accesses in PV guests"
+	default y
+	depends on XEN_PV
+	help
+	  Use safe (not faulting) MSR access functions even if the MSR access
+	  should not fault anyway.
+	  The default can be changed by using the "xen_msr_safe" boot parameter.
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index d5b0844a1b7c..daae454191f2 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -108,6 +108,16 @@ struct tls_descs {
  */
 static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc);
 
+static __read_mostly bool xen_msr_safe = IS_ENABLED(CONFIG_XEN_PV_MSR_SAFE);
+
+static int __init parse_xen_msr_safe(char *str)
+{
+	if (str)
+		return strtobool(str, &xen_msr_safe);
+	return -EINVAL;
+}
+early_param("xen_msr_safe", parse_xen_msr_safe);
+
 static void __init xen_pv_init_platform(void)
 {
 	/* PV guests can't operate virtio devices without grants. */
@@ -1011,22 +1021,16 @@ static int xen_write_msr_safe(unsigned int msr, unsigned int low,
 
 static u64 xen_read_msr(unsigned int msr)
 {
-	/*
-	 * This will silently swallow a #GP from RDMSR.  It may be worth
-	 * changing that.
-	 */
 	int err;
 
-	return xen_read_msr_safe(msr, &err);
+	return xen_do_read_msr(msr, xen_msr_safe ? &err : NULL);
 }
 
 static void xen_write_msr(unsigned int msr, unsigned low, unsigned high)
 {
-	/*
-	 * This will silently swallow a #GP from WRMSR.  It may be worth
-	 * changing that.
-	 */
-	xen_write_msr_safe(msr, low, high);
+	int err;
+
+	xen_do_write_msr(msr, low, high, xen_msr_safe ? &err : NULL);
 }
 
 /* This is called once we have the cpu_possible_mask */
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:55:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:55:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416105.660740 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2zi-0005y8-DZ; Wed, 05 Oct 2022 11:55:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416105.660740; Wed, 05 Oct 2022 11:55:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og2zi-0005y1-Aq; Wed, 05 Oct 2022 11:55:22 +0000
Received: by outflank-mailman (input) for mailman id 416105;
 Wed, 05 Oct 2022 11:55:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og2zg-0005xv-Qc
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:55:21 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2071.outbound.protection.outlook.com [40.107.105.71])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94d5825e-44a4-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 13:55:18 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM0PR04MB6835.eurprd04.prod.outlook.com (2603:10a6:208:180::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct
 2022 11:55:16 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 11:55:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94d5825e-44a4-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k2l4XnuQA0SPnwAcydE0j1vZE8P/1uZOJYE5U2HWbS6/QMhp3u6NsHPi5XUZq7WsTSCXZv8r5QZ31h61woJ9wpKE39CbnGEBPbN1iroGbG9zGxPlOGbVSsL6PTmBoLtTc5ttYKthosDXKWkMpEaonvvDkGo9//33JbkQdxlwUsZpBbgzMqey+Y6uxMuyihwH/u/YNwC8K5kNJzbJfNkgcWipk63YROI+DSP9wsCskbDpetVfbqQg4run2ZSA+3VYRO1wnWrfgI0lN8Guz+JvOd/7mp5mhZL8kAC3EtaAuefiOODX5FqIbNZYHUT3yFviKEatDX3BtBwP9TmV8d1JNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r7HUhkRC5uQAglFLYV1QaXlcHr1rewmUst5byxrL4J0=;
 b=TA8ZF7sU1bxy+XRjXUVnx1AgoMmy75ql8/AA+Iuh9I4shM6Wj9nl0Dje9lyicVUjQnGJljvzHlFQ+YZ3qigHK3lXDZmCgh1JPljtYpPa3ulnW3p8ac4KXQ4KsWcCymNfWvY9rnQMIJzY2aSKOjyIdy604nawP+O3apX+nj12ZdSX9byME0Oyasqnzc0wkAO6IdsAFeFSQy8P+vo5tyvwko94H87sd6VxF3MLVARqaGtyoVESkQarMj/L4z0J+ZxlmNGivhIJSb74eO6SjM+iZQYFfmIW90m9P9wjlgQMCOMC5g7qp0NU/GPuc8f04xNTElv3R/P7p8qG5uibAdO62Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r7HUhkRC5uQAglFLYV1QaXlcHr1rewmUst5byxrL4J0=;
 b=QzC8jE1SG/bPH0l0gWaLZVD6XLMulLMppMhnshGZSuj/9ezAhSsSFZu1SainSpABg8frjZ4juZ1iaxCPkhm6HK8hE2OYePFjS7pGbMyh5Jo7n+b3su8hj2vtoFE56zYpw3CbWtsCStt67zOOInxhribGzgc1kS3tJlfGxH/NQO9thGlPILor80w1MQ5eLzdXdwbwR2pCUBvIshKDDkM2eMbCmeAtIjI3i2P7J5XuNw+LkAK3PjmNtTc6RM4s4rGFo2GDkex4tlvrg5G/hC1M2P+oM7uJglG1CKt140Ntz5b3HAraNNOztUNqenMga7ed23ynAuhqK2Yn6Ldsuk0JcQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
Date: Wed, 5 Oct 2022 13:55:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0127.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6835:EE_
X-MS-Office365-Filtering-Correlation-Id: ac719aeb-8af5-4d75-0ace-08daa6c877a7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ASvu/1ZVfJHAvXucMCgjIytSfsFKe3ysRTU9XFtDTmmcHUWFesytsf+oIj0OwEkay0K7iFOJNO1eWA5qoo6YwQv7HXbec5WW5gljxV37gxDEjGn96HdBlLL6U+//+1zdGtaXqd9350sMDzBpKkqV061P2Un5sNCgXxa3RqJn7XMBnB2/qoWs6mqIMaZpfMNMdMkQatObBjxnLzjTpGCjcmwcxGEJue1687a3QU7N9u+274+vDIDyfEeq6crvthTp7Hpzw/vpZZi77zEz26KfArpYxlzsj6LPc9nVJPkrdxB/V3IsNAdxYDktBYHbWr7sKFqoY+/Qcw6NmYGTEKkZPpEoHpQ2rJs/FZQ0qHRvfUi+geMkp76rtIkKwMc1LVG0ij33Fm/vr8ly+1e4kk6hrmq8rvQEN2qb65Wg/mBsxTW+p5xGmwQsck+uD6Pd1H21W6kuDPZ5LrU9c83CqGvKzujPfUEhjGreu8TjWi3Ssxi3xY1xo8ZyzMF5O5zYJyPrSarB90LpH/SuF9yPa3oFfUpiTuDMIQ+kK23rrCCjba8n+6wgSjnDEzcdYpnuZNmtrU9hOmTD5vzKqLnHlCvyAszjS61j7q8zMxhm9dWu+IcqYKWSaeA3dXj2o8mjERzZFnb0kIRyIQTeaamfaj8Pq023P9sM7eGesyZosk5hnRMdLgWsqO2SRDIxxERBSgT0FQEYKW2ctqk/XaPo2dGrqfzq2zTl39kCozOFQRBVDY53qyDedT0yYNj3Lo9Jd531OzyfPJ3KzECwdv2oBYnLsuVMj900l46SpzKlGBeng4Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199015)(8676002)(6512007)(186003)(26005)(36756003)(8936002)(5660300002)(2616005)(2906002)(4326008)(66476007)(66556008)(66946007)(41300700001)(83380400001)(6506007)(53546011)(6486002)(38100700002)(31686004)(86362001)(31696002)(54906003)(316002)(6916009)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MkdSb3pSOFh1Sms3WFQ3VGVNcXdEU25xRVhic3p1S3JPZmYwKzYzWjViRGRx?=
 =?utf-8?B?c3VlNnhjd2t5b3h6ZXhKZnpnUFlpamlNOEduSXpkZWNJWXBFTVVnQjJFM0hP?=
 =?utf-8?B?THVyNHFKaWs2MUZnNnN1QWNYbTYyQTRCaSs5Z3ErTHZ5QWlOWnZ2N1J2d0Rj?=
 =?utf-8?B?Z0JiaWFiNk9NeVhnL3dvNjV6aG53ZVBocFZKQU5sMTViUjBUdWo2OWRvb3pp?=
 =?utf-8?B?YUVJK01pR3pXZHRqYkdETFZkVE8rOTc4UDVmb0h0MTZ4NHdZOUd5U0F6S2F2?=
 =?utf-8?B?TjR2ZUFHa0NLaVdORHZqNCtqczlFSXZ2dnRlYkw4aDk2anoyOVdpOWVpRXI1?=
 =?utf-8?B?UVRRSnhNRDZlYjY0YVlVcUdmMFJYOUdhNCtBWStWRUZJY05DZ1htRSs2TXlH?=
 =?utf-8?B?bytBdG5Da2dPMFlSdS8vbUk3L0hhV3dIUlE1Y2dyRVdSaSs0TzFnemRQN2Yx?=
 =?utf-8?B?bzl6d0tZZERaVFNvcnNtU0dVcFRyMTloR2ttUVV2U21rUFhvRTN4dnRhcDU3?=
 =?utf-8?B?SVhlbUFzYndadGtkaWJIYjdhV3oySUVWdWs4WUlTdGJsenBPVHFTMmdTSG9z?=
 =?utf-8?B?Z3hkYmFZUEh2bVlITUlCZE50UENianFWWXBwRUhBNGVhWWloL2REOExGVmo0?=
 =?utf-8?B?TDd0M0ptQ08rRmMvV1daR25PUlpUN3FXZzdFdUszbExXbzIra0h3SkNJbXJV?=
 =?utf-8?B?TnpsMDl2RTcvQ2hFVVVXTFJKUUhIK2VuTTcycGJ4eWd6N2lqR0lSdyt1eHll?=
 =?utf-8?B?NVRWN1ZVMHhJVmE5MmJFdHM2RnFVT0Q2SFNRWThYOWExdHQ2WG1YakErd3VZ?=
 =?utf-8?B?dVpnZGp3QXlYOWlUWks0bHJLL0RZcDhIQkV4ZUxjbGRLQjE2R3VjcGo0YU1j?=
 =?utf-8?B?TVV1M0xSVzVGWHdqbEhBQlZ3V0orS3A5aW50bjNvSmpjVWpLYXdyK1pYTlFo?=
 =?utf-8?B?NXE0UW9YQmVPU3BLVHgvL0tRd0JNVHVWNTdjRWVxVE11ZUlvL1lQMERKOVVT?=
 =?utf-8?B?NHkzSWIzbitDeW9iOUtjeTJ2a2lxQ1NKbEEwWFRJQ0Rjay9VWDVkbm9PMzdM?=
 =?utf-8?B?TlNqQ0RUYlJmRU5hMFBQcnp2bkRJdW9BcTBRN1FmTEljTU5UV2xXMjJISzRU?=
 =?utf-8?B?TWpxRTIwZnRYc053c0JPSWJTcndFWUY0SG9laEp0ZGNRVXJ6YkJjUDFocHkx?=
 =?utf-8?B?bWJxdE5wVUxpdFR6aFZFdklvRG5MSXQ0dzEvTGhXQ1JZYUswUXl3Rk1SZ2g3?=
 =?utf-8?B?cGZPWUFabVVpUzFndEtSMWxJODFmcjZJSW4yaGw3K3VQWkxMMVgwVjJIVnpT?=
 =?utf-8?B?N0JacFgrOVVxVmZQZFB5eEtLNjYvWm9uY2FIKzJ2RGhnc051VUZtUVlQZkpz?=
 =?utf-8?B?UEc4cTJ1UFFIK0xQS3B3alB0Wk1pb3pab2x4MjJ4MUZlaEZYN3BDQmNZWWZq?=
 =?utf-8?B?K2tueHhYTmNveXZyY0xmV2svTUpPMVM4Z0IwejhVdG14QjlkSFJyVVBhbjd0?=
 =?utf-8?B?U1JyZlFoTjAvYUswQUpmVlFmZ0ZBVElkU0wrT0JsYytyd09XTUFLZ2hUajd5?=
 =?utf-8?B?S0dQNFZ6T2s4YkphMDhXcXFpQWxxU0RhaXVTSEJNKys0bFcvdEtkYTVVNFdF?=
 =?utf-8?B?bnZSR25CcVFMR0FMbm93VHN3dm5Ra1RlUWQ3Q3l0b3g4bGh3b3lteHB1MlZ2?=
 =?utf-8?B?VkFPNmtPM2Z2U0VXOUNkZ01RR0hlRnJDNVpLVEhWZTRVQ3F1UEkvVyswZUVn?=
 =?utf-8?B?QkRBWmtOY1MxeGUvWlhyZC9DWWRScnU3OUFHYnhnZmRITWV4UWZSS1hjY3hE?=
 =?utf-8?B?THhVZU9LV2Eza0RzZnA4K1ZadHdNaVF3S2RCVkhDRHdkeWZhU1NZMmdFVDFN?=
 =?utf-8?B?NzRIWnZJTGdlY0dsVEk5b3VxTDgrcjdsQ0IvWWNvd1ZoTldpci9LSE9ZalBo?=
 =?utf-8?B?Y2VNY0RJY25YRE54c1JBRzJLVEdMUG9WOGl0dzlLSGt3VW1JRDVQRG1KaFVU?=
 =?utf-8?B?Z3RCdmVaYXVxcHUzM2JyQUZaL0FoNmQrVmg4bHJxQVF6QVdFU3E2L0pWdGN6?=
 =?utf-8?B?Z1U1cHVEamJIaEszS00wTUd6cEFVNG9pQUZ4dG1Bb1lpQnZydzVndUxZNlRX?=
 =?utf-8?Q?MMBZK6nyX4S+dGA0AAV/zt3ra?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac719aeb-8af5-4d75-0ace-08daa6c877a7
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 11:55:15.8702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: trTLofwTg/LpLPPr2BdSZqucTs49VHICF0fQlt04nJSAKKrHWe1tSUxAGq+Dsx0jvYemRbxAQvFo8ITDA9kj6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6835

On 05.10.2022 12:44, Julien Grall wrote:
> On 04/10/2022 16:58, Jan Beulich wrote:
>> On 30.09.2022 14:51, Bertrand Marquis wrote:
>>>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>> higher priority than the type of the range. To avoid accessing memory at
>>>> runtime which was re-used for other purposes, make
>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>
>>>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>>>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>>>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
>>
>> Thanks. However ...
>>
>>>> ---
>>>> Partly RFC for Arm, for two reasons:
>>>>
>>>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>>>> For one like on x86 such ranges would likely better be retained, as Dom0
>>>> may (will?) have a need to look at tables placed there. Plus converting
>>>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>>>> me as well. I'd be inclined to make the latter adjustment right here
>>>> (while the other change probably would better be separate, if there
>>>> aren't actually reasons for the present behavior).
>>
>> ... any views on this WB aspect at least (also Stefano or Julien)? Would be
>> good to know before I send v2.
> 
> I don't quite understand what you are questioning here. Looking at the 
> code, EfiACPIReclaimMemory will not be converted to RAM but added in a 
> separate array.
> 
> Furthermore, all the EfiACPIReclaimMemory regions will be passed to dom0 
> (see acpi_create_efi_mmap_table()).
> 
> So to me the code looks correct.

Oh, I've indeed not paid enough attention to the first argument passed
to meminfo_add_bank(). I'm sorry for the extra noise. However, the
question I wanted to have addressed before sending out v3 was that
regarding the present using of memory when EFI_MEMORY_WB is not set.
Is that correct for the EfiACPIReclaimMemory case, i.e. is the
consumer (Dom0) aware that there might be a restriction? And would
this memory then be guaranteed to never be freed into the general pool
of RAM pages?

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:58:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416113.660751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og332-0006Y4-UH; Wed, 05 Oct 2022 11:58:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416113.660751; Wed, 05 Oct 2022 11:58:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og332-0006Xx-RR; Wed, 05 Oct 2022 11:58:48 +0000
Received: by outflank-mailman (input) for mailman id 416113;
 Wed, 05 Oct 2022 11:58:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og331-0006Xr-Cb
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:58:47 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10dcbba1-44a5-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 13:58:46 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8990.eurprd04.prod.outlook.com (2603:10a6:102:20d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct
 2022 11:58:44 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 11:58:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10dcbba1-44a5-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D+MlmnGiF2wcyDAhfrw9RZgLhkIpz3NX7GxyAi4VKtKcj+N0BzU8BlugqPtUjlCW4OUZMad7O12+xYxyFURAaAjyTXQoygIvdu8k4Svw9+rQ3q7ELbBdi9ah9NeQlwo5sWR9WorGNMYdyHEsTrR4fJhWJDWJM5jjYgZSohOXLm8pXBYs4BvAQtvjQUOSmBMHOUHyxWdE2xh9JUJXCqqVk60g7W91R9ekiEN/KTAgQZtGyobtZ9gLht1OASbnwrDk+h+wQJmup8Nva4MU0CuaHaSFmKXwul9AxckT1lw3U8KEWEf0NN7jpFkyZ+2o9nM/3/Pa0Cdc42ZdNJ6pLHO51Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=92gEudYViPSoFHFVbUAJYNnmR360+JuOA2pl7iiDTfo=;
 b=X7As866p+RvaX8SEvJudBqHVnjaIBSNIz94mhLx6h6yxi4ppkmcvy0vzHWCqDsoGBOidDjvpQ90nGMTBzstjkWokSCZywSGDk94vOmj2oSAGzkPfOs0jmyjoKNi4fhK+thNRcT1X6tzZWCDHGedhAJgRXnJp2uodo7jpOwxv/OXUizncEM1FnYkaEF2Ewafnngrt2EShtptgMOluaSQZfzgX1VnW745u7t/HJDX3TAhOQERkSoKuCtzf1iWjKcQtQTyrfqyqG/7lGe+0xLrLAQ/xZHXetVI7LI4CWRL8QYkhrbsSkFkTAsgIzU9nUrSK6RM/V0FZiGEJxG45+uNLUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=92gEudYViPSoFHFVbUAJYNnmR360+JuOA2pl7iiDTfo=;
 b=XHFrUX68ijXvKfhQbe6xAgSeCbqEoSaPybgujOybuEyg1AJyd3w0gYA60s5h1sXCVU3HvGMDcJDsuwg86NQ6LrK4v6OMqWlVDVEVpAvqpmBb7uhbdc00q9gg5TC2LGM7zLFBWXkStIZo286tVMWHlh1rKoh1FHEN0Qt/xB+A0BbBro+u9VRfqOoFeJGIhQiAUVYMRleosG2CryE9nBiwkNRxB2HL9jl+OtkvBct63Ui8FwhWKXqgHW5E/9HOh4TXuaYoSxNH34Xg3UXUN8bK++Ts5GSKY//0+dTN+MyIYl9pV60GHlFWhG3bkpFlNZ8S1bj2frh8GiPVo+w6Zkqbkw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1ed567ab-6f1d-996e-66d1-da1e6b7ab8d2@suse.com>
Date: Wed, 5 Oct 2022 13:58:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 1/4] xen/pv: add fault recovery control to pmu msr
 accesses
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221005110302.13455-1-jgross@suse.com>
 <20221005110302.13455-2-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221005110302.13455-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0026.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::31) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8990:EE_
X-MS-Office365-Filtering-Correlation-Id: 50e61fa7-7a02-47e1-78ca-08daa6c8f3a6
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NdtB6Q6P0ye7zgiYIN84AHG6S63c6YNfhQNXc/RYuqB1CvLeWHQ1iirjEtmN9VC9I8v8c0/es31CYHKk7lL50KoeFOWi/mZIPoe3+30IiP+Mai6yfBx+FGQuuEHnQnsqYyx7qCE9pjj/6YplSYalTYJxoLoYNzMe/xKxwVIHJVP2zecrvlBxMTSAGIk8vhwO0PcMEVOKLhL1mRs1a0Rdl21U6UV2rkOvPdDKt3WqzxEEgGu6qzl8TNplH8rclBak3GCOd8v85TjfH00xWdrDZtjWHhVxAnpgMsOQP+o2M+1CLzqfVLHlmlesTkmgpsns9nZfuATuxVAQqdTSPcBpRIvP/Gej4qiBry15c41ewN/Eg+CHlT5QPQqAYeBzPMkSrKWMqNtnk04utT0QAs8OOQn8a6A76YW+0V8uWymyAok4kTCv/v+GxDKEqvc3hVSBiv3m3ZE1ke6AhZDSXUKrbq7/GuZnXgUW8rkTinOeitEjEkEwhoVk1+ONB2EnG+6oykvV7jWQHmRkPGxPNs2N4DqWB0hAMa6DWlAydqxkCAy8Dam4UbsUDnTgKCn0OF2xw9ftJTxOYiJhh4OEcDYsjwB3uMF40VIIlo3qu44AhMUdjNi9Vz3n6UZjBJrZFHZvT6b1319t08SzP6qIzvpOuqQ64Z4ImW6FB+TOpBFl8t3Yp0e52kZfowFasRfPr+H5EfnwWSI08ClU9zInWsi3uYBj0qYnP7CHnmv7tCFeK68le/o5m1JPNzx2xp6lA8Ncw0d07dp/HUf3MLLovyZ8xj+bqhzqWzmNti8wg5GNbsY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(346002)(136003)(451199015)(54906003)(83380400001)(186003)(2616005)(4744005)(38100700002)(5660300002)(6862004)(41300700001)(2906002)(8936002)(6486002)(53546011)(478600001)(26005)(6512007)(6506007)(6666004)(8676002)(66476007)(4326008)(316002)(66946007)(66556008)(37006003)(6636002)(31686004)(36756003)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aFRBU2xmcUxxQTRUczY5Q2ZlSEIwR1RyMFZUMm5oZ3NUejBnU0M5Q0ZIaWlG?=
 =?utf-8?B?bHArLy9EQzBPM25PRjd4NzVzMXZpVjVTak1aNDFLVSswQ3EyVTM2OTZvaUJC?=
 =?utf-8?B?OE1rOGV6dU4wRVExM2I3NHlCZHVNS1AxNWtmc0lyRXZod2hxaHVFYWJTbitu?=
 =?utf-8?B?SGIyeEtKQ3A2Tk5uNjAxeEpyM3lpVnlLMVlaR0pKbEhML0Y0REhMUFVCY0Zs?=
 =?utf-8?B?N092TlUyWmhadkR1cit5NFRCTklVUFdDY3VQQ3hNTEk1c25qSnQwbkJTV1o2?=
 =?utf-8?B?ZXY1VVgrcTlDQ2RBMnlzSXY5MEJrRWd1RWorQk1scysxTGZ2NXZudEJGQUNr?=
 =?utf-8?B?TUVDa1JGR2syZUVvUkpyVG40NkI3SVJ0Zy9BbHNkVG92Z2s0TkpKQ2pMNWJh?=
 =?utf-8?B?UStucXY2TzhzZW92bkRVVXFtMklTYmhtRW1IamFjQVFEM0p1UW1GY0JTYzV0?=
 =?utf-8?B?VElhS2ExcGRlY2NYN081cVBGRG1xcDZvQWFCQm91dTdELzFpNTQzVi9jUjNp?=
 =?utf-8?B?clJYUHE0VitDZ3JCTVFwUkRYa3N3eXdDYTJldFRJNm9UTUFpK2gxNEtFa3BY?=
 =?utf-8?B?VjBsNlRrUmtHL3BOcHFhb3NoMW9YYkpRZW9GVzF4Y1did0h5S0xEN0plUk9U?=
 =?utf-8?B?Skg4YTluZGRqZi9sakgyYi8xNUttQWZLdk95SU1hYUlaZ2hnd0J4RThlTUlo?=
 =?utf-8?B?eXBhV0djNHJNQWFaeWwzK1FVd0dRVjJEcktiQzVkLzUyWlI4SUtKelF4Tk9I?=
 =?utf-8?B?QjNGTTdoWnRsM2JmbkVSYVNvUzM1QjY1QzFqK0oveW9ScEJNaGVYa1RtV3lW?=
 =?utf-8?B?bHVETUtlN0lZMjd1U25NNzVvbGlMZk91aExvVGRPMjJPMUhHTzZ2S3lOVWRQ?=
 =?utf-8?B?aFdXcHFuWkR0ZzVnaXM5cFB2VTU2U0VCR2pybUhXcmVRd1pFaUNQOTdqQWVS?=
 =?utf-8?B?VDd0N1ltMWQ1THlVRFh1Y044WTdtM0pwVmFodnhtd1BScmNaREJaalAxanMv?=
 =?utf-8?B?ZzVJUW9GalpOVHpTaXdIQzRoNXhidXZIUWZzcXNVbkxDajFwRi93a2lDVDVZ?=
 =?utf-8?B?aFJ3bVcyMzRBSzRBeU5xc2x5b1VZUmlSckZ6c1BTYXViWUIrblJGd2NlbDB0?=
 =?utf-8?B?YjNpQUJYSnNBSExYZ0FldFhSTlBwb1NDVlIvT0xGU2UyVjRJek1sL1gvVFZs?=
 =?utf-8?B?WUI1am9iSWgrSTk1djRoRkhCc0tPQUVoUUk5Ym1VaXcxVEdlOHpIZEtuc3pW?=
 =?utf-8?B?QUxpK09QWGZkQTBleDV3WmlEb3VmZnM5RFJha1h2V0hvVzgrbEJzN0pZdkNM?=
 =?utf-8?B?Z2RFZkUvRVR2alpDOXd0OXFlek9FRUYvK1R2SzlmeVJlbmpKZTJuU0RETjVx?=
 =?utf-8?B?dTRKZFBvS0RqTnRNdzcwK3VRUThYN2tmQXVROUtUM0czZXNLSm9WWGVmMFRw?=
 =?utf-8?B?UXJsUXdMMlJudGdWOXg3VC9hUDk3K2EzaXhUSk13QUxVWkhYc0xLZGJyNnZG?=
 =?utf-8?B?NDlPMUVkQkRnTTNJK3BPWkdGcHFMNldqcFhjR3hKYm42a2F4aC9qOG5lVlov?=
 =?utf-8?B?bW96Z3FwWXY0QllNVlkxdHIzUUMvUzFTZDFzTWxadEIrNDRmcDNVSlh1T1Vz?=
 =?utf-8?B?QStlSmdsNU14NGhETmNrNmJ4citrVEZ6bnFVQm5ubE5JQWdHWEpRcjdUNkJD?=
 =?utf-8?B?anZSYXZpeC9OODhBMEZzY01GTHhQL3hzWC9ER2hzR3lmd0dXcGUwd3BtUmJ1?=
 =?utf-8?B?cGZmaGkvSVpJZGZBU2lwS0lxUmxnY3gvWnRCZ3RTcE5UajNaRDJZM2pONFpt?=
 =?utf-8?B?S2l6c0V3Vm9rTm1RZzY2aWZVOEtsbllLQ1hHY3J5TENVYkgwNTRXQWplUHZ4?=
 =?utf-8?B?MEc3MlhGMWRBVGpCblVkUjJiZFlacHNwaU43TExpY0NLcjF4ZEFzclExRHFu?=
 =?utf-8?B?dU9LTU1kMkhOdHNYNzZ4R0dUNXVvNkVwbmRNaGlCL05lQW5lVjRqYjQ0dDZI?=
 =?utf-8?B?cVFFcTZuZmRxM0d1blUyMXA2cSsxMys4cWVkQTIyaTR4ekgzZTVuV3NDL2Fu?=
 =?utf-8?B?a0ZobU56bkN2UkhoUzBvaHZBb3d1MXgvOWZGOFhGMlA3ejdVdjgzTjdicjRp?=
 =?utf-8?Q?ZFyqYifuGgvvl8O+rYfoSAskf?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50e61fa7-7a02-47e1-78ca-08daa6c8f3a6
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 11:58:43.9664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZvMw+u1YU6ueMJhXqnCrvVHZujnINUH3CiUhAw21AisbqUUn15M248WkyNbedhrlaWw5mq4N3PHL1Nhy3a5Pcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8990

On 05.10.2022 13:02, Juergen Gross wrote:
> Today pmu_msr_read() and pmu_msr_write() fall back to the safe variants
> of read/write MSR in case the MSR access isn't emulated via Xen. Allow
> the caller to select that faults should not be recovered from by passing
> NULL for the error pointer.
> 
> Restructure the code to make it more readable.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Wed Oct 05 11:59:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 11:59:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416122.660762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og33R-00078g-A2; Wed, 05 Oct 2022 11:59:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416122.660762; Wed, 05 Oct 2022 11:59:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og33R-00078Z-6r; Wed, 05 Oct 2022 11:59:13 +0000
Received: by outflank-mailman (input) for mailman id 416122;
 Wed, 05 Oct 2022 11:59:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og33Q-0006tI-AD
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 11:59:12 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2067.outbound.protection.outlook.com [40.107.21.67])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1fcd7636-44a5-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 13:59:11 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8990.eurprd04.prod.outlook.com (2603:10a6:102:20d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct
 2022 11:59:10 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 11:59:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fcd7636-44a5-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V+s+MOfUo4oAXg+5q/naR3ZX4oTRr14HDLTaRRzzcD1LKcwkDUpZNsrSJ7Zd5OByDw8MsUQzsfUXNj1gxP7YnDZONarFF/4cC2bNflZmEI6a3uDoDNI0Hc+pt+P0Y3FZyA/Tc//HyzQLZ/v16G/N7uAnoB07KXH203RolSQn1An+dX4bQUIXiecvUVTT+vWO1FE7TO+x7MN3iyIkIK4JiStM2gXijkxI0ThutDQdpmpjm1K5FmGTbMERn+j0qYmmGfFxFwsgdm3FA8dr8/xHIDngOQk+vMbdVwLH4ILLFGjQ+0gqYy+sJg60XjMjD+6TlvCVBrtEWMcf4oAC5+dN2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m34VbD0LfO236+78Hchg+01tMv+UJ+fRLDcHaGlqoP4=;
 b=FZXzu6rA9RltgMAiXbAoC1DYHIUZRQpWilMz8e6j5LpTzFNQ13g/ZA0oF9pqzB2j14AlQIv+nEupu+SwRbBy0d1351a2rkfVkqvFbLHp9t+RqGiPrm3vPKvnx0YrSGa473tx4otEHz//7/vYnsZRr8RZKE7LsPcRAx5Wi9y5D+C8OPtCHA3/XdcEgeahQz2/yZcfLwEO1ST6NQX2cLBu39/5Sokdw2vDL7ug0rakCYSVoXp3/GSi11WhtnYy3waKxrsA18qb6HBFVyHyMZ4qFkL816UQxGQslP9fouzlv7oPrQ+4BfZfCDGcse9cSJqL0+WtRmUXQBCAtq6QF81X4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m34VbD0LfO236+78Hchg+01tMv+UJ+fRLDcHaGlqoP4=;
 b=sMFCefN378vzg6o7U68bmrbtEZRafc11MONQwPbhCLH4IHzGDu+2MPOoxwuDDHWEokJ2SWW5mpnV4B5LmcbA4tLWhyVOC7Vg4+1z8VP4fsu3VEU6L6xr+Jn5557aV10fPRGUIx40jb2sUjv+CFO240GYjIFx1uPid8ApEtAKT2uvkfhj1MWMmVJt0w4yt3fGNSRuIlrRzPU07ETYesSkrgg4D9Q5m1PXSPnNIBOk9lz5SVLTatNttBn2K9gCdvfXB9zzW9DPXMrbckwGIh6YAR7HLJOpB78vn6QoSfDZ84SiD4hzMTsR2fkKU+P4wow166BRzsLGzoM8vBsFt0/sCQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ed377c8c-95c3-8386-cfa2-51ae9b8add67@suse.com>
Date: Wed, 5 Oct 2022 13:59:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 2/4] xen/pv: fix vendor checks for pmu emulation
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org, x86@kernel.org
References: <20221005110302.13455-1-jgross@suse.com>
 <20221005110302.13455-3-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221005110302.13455-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0015.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8990:EE_
X-MS-Office365-Filtering-Correlation-Id: fdbc3d14-30c1-42f1-0a7e-08daa6c9032f
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UVEz3quXCOrB/ToFVMO4435Zl0VY47lRmERLNThZeyJcVvDFc7dXwBrkYS1TbkPS+gxbcF56w8OYGtmz585lL+aeUm5dH4By0agw5BMooF8ejEN3MC9aMUrQeHId1wgbhr0xElyJBgBbgfwEcB8ogUWJyEUYFbKI5Aig23Qgr+uscinQJU/kT7itx5GJfeEC+zySsU1oAJV+a6kGHJH2MB2LS6zgPp5HvL/XAjwF0hbPR6hFQCWp0o1GqPwCqKrQVf32/vZaY7qChqMJheK83JQOV695A+kGHYmopy65O5y7sQ8oipwaZ74Mouq38ENl3bgXdy7bE0tM2l826hfpaSN5HagbMX1dQ924tnBCchjbpu8TjT7H/AbWeH6R8feERG6jVaeM3KedMYUdYyrsitadS1IME0vQGQrp3w+xzgLO9OQXnIEUb7z2aIVHoy1+zHQTrf5UBjcv92kxq3AC4lccpZeEA4jCjsCYBRwAJcGGnuHVWEKuE0+vQszRn3qEczuW9Q4AJhMnUv3oCKofEqYwWQh+ZT2nEs5wmTRRvCPjfh7jbngqNXAVSawsSwz3qYkBiCynr/dr/l/O/XHQGygd3Pvg+H6dRReYI1IbuQgMelfDa8xvXtyy3hJbgytgWI0bfXpHTBdQ3zCyOlj5s17pEnYBtWvQRcVI6A6gN45vwWCoZOx19w60HE9VLcRuUrJTit508A85r4h8JA6CjzPMdunXKgjBwQq/90Efc2ugzL1pcpbLqvrH4+LLgWWfvseKjn/3fVRAmHytyuxWrqXZfA3xy120RNZqC+mNpVY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(366004)(346002)(136003)(451199015)(54906003)(83380400001)(186003)(2616005)(4744005)(38100700002)(5660300002)(6862004)(41300700001)(2906002)(8936002)(6486002)(53546011)(478600001)(26005)(6512007)(6506007)(6666004)(8676002)(66476007)(4326008)(316002)(66946007)(66556008)(37006003)(6636002)(31686004)(36756003)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SittcHFTdjNrTzN4NWM2SzRCdVpQU0paTVZlbGpNT3BBb3EwSnVtYUxhM1Ew?=
 =?utf-8?B?NFRkZkorM256MDdCVThSVzhwSHZpTVJKUmpveFRhNEozd2VuMG5qN25xUXZH?=
 =?utf-8?B?ajBBbHc0Q0c1dmliSnlRcXJDUFVGOHplMy9PbDNYeDRSYUJZWC9kUmxSdllj?=
 =?utf-8?B?d21UVWNVU2N5RkdWeGRVNy81VXVXeHpQbTdBZ2Vwa2ovWTQzTmtrZGpaU0tx?=
 =?utf-8?B?dHV3QVMzMWZlbHU5a1BJbWNYUmYzNlROYjRybU9kcnJPUjd4d3F4aTJidnBs?=
 =?utf-8?B?NEdpb0VCUy93N0dmbjNFK09Nb3NoMUhKUVRWZE9vVm1YM3NocExiNXpxUzBz?=
 =?utf-8?B?ZGRyY3dCazh6dmQ0OHhubytuWHVidExwNU9JeEYzUkZVTFhwZlk5SGgwdmdn?=
 =?utf-8?B?c082clBFakFoVUIzVmxrVndPRHh3ai9TM1kyTUN5bzhaM2pWYnRqQWVsbnNh?=
 =?utf-8?B?UjJZc1hjejg3bk53ZnE3RGFmcThISGNBbWFLSnhFWEZCNWdqb1k3b1JqQkts?=
 =?utf-8?B?U0hqUmdteEFiNHhsb3M4MGxPcS9iY2ZaSTJ3a0UyYVpzWGd2RTkwbnVFR2Vl?=
 =?utf-8?B?OC9hQk4yOFBiYUpGMDdac0pVbjYvSEtUbnd6ZkpFU3RkV0Y0REZGUFg0aXBo?=
 =?utf-8?B?OVEvdFFKbjNZdzBqcGVoVWhmeWVMRmVOQ0VhOHRhRmMveTFhQ3JHc1ZCY0hr?=
 =?utf-8?B?TlNDVUJHVldSNnBndTFXNmpweEtQanBhOWplUGhsVTVYZlh4RXYvcFNKOTJv?=
 =?utf-8?B?VVNySElLeHR4QW9aVnBLa3NMU2pCY0p6b0F3QVlpeVFXVU9wMThXSjMzcFJt?=
 =?utf-8?B?RWYzWHlOUDl5czVvT1ZVcVM0cFdYZGJtN25BTlRkODRpQnBTSzRxUFlnRkhQ?=
 =?utf-8?B?S29oRVU0UFJVV245KzJIMzdHVkZrYlQ4L1VqdWxqTW1aTjhTSGJCZUlsb2xq?=
 =?utf-8?B?dlkwWlUwRDlsMCtSWjdqeXZ1RGJpZHhTeitxRTRHVUdZbTVaTVF6UUFjREVI?=
 =?utf-8?B?aFFqd0tRdHZjZkhob0YxMUtiSmxUUVI1b21hMkpnb053TS8raHRVYTI3V3NC?=
 =?utf-8?B?VHFvR3hWVlBrakRpZ2NNcGZudEl3dFhoVmdMb2g2bGwrRThiVEIzTkd6U1V6?=
 =?utf-8?B?Snh6YU5tancrMWFTVVNaVVZFQk5Ra0haZHNsaTZxRE96V09sRFBkelVTVDA5?=
 =?utf-8?B?dkNVeWVYd3JwanFhOEVVejh3aE1pUENVR3B6Wk9JUmIwcmxXckJUNHhWeE1i?=
 =?utf-8?B?eVpZWTVGOWRGK1pDUVp3OU5JTVE0SzJsVkhuMjhYZS81YTE1RzVXYzZXcjFr?=
 =?utf-8?B?dFpZT25aQ3FCRWpaaXpoMnExWld4ZkQ5SXVlTDhMOXBTMFVGWFBrdjM5d1VH?=
 =?utf-8?B?OXN4cE0ybXlSanFDWFpHVVZFa3FoRGtCeUwrTWhYVjZqakt4cEVRWmlaMXdr?=
 =?utf-8?B?bS83ZlAzMmRvdGRzOGNZd3NGSWdVQ3JIRnFSejdzVnYxYkd4aEp6NFhTRHR3?=
 =?utf-8?B?dlVUYWUvR2pwU2U5VHFSNVp1RGY4SnU3WUE1V1l3ZkpKQzcyck41Qyt5Sk0x?=
 =?utf-8?B?NjlsTnlDUmk3VlJFNjVIb3VtY3lEZWVURXVNVG1uNDBSVkg5dEpDU0pRMUM1?=
 =?utf-8?B?VXF6MkRNUUJZZU5aN3I4M0xVTi83L3NHS0dJU0JWMEZiSnBpeWlBbW5TRHVY?=
 =?utf-8?B?VXRTMGdtYXlqdHFFVmRDdzIxUDJ3dmdpZHR3T0hRWkI0QytMV0dycHNkQ25O?=
 =?utf-8?B?amluMVR5Ry9BZDJGalRhcTBac2JzS0taZEtNTGU0MnArN01NckY1M3FCUHFH?=
 =?utf-8?B?TGJVeFo1T01IZkZPS1ZHeG5mblRJM2lLdzZ1NnRtWTlFSU90SGZucGcwRkdK?=
 =?utf-8?B?M3orNjg3S08rZ25CRWlKZFdTUkhVRXlxSmdqclYySyt1dVltaDdDb0NxRjhO?=
 =?utf-8?B?d1lpdnpFL21wOWhFRGtXdHc1TkJjeEUxMkQzMm1SWURDRTlEeXMzSzhGSHBZ?=
 =?utf-8?B?U3NCb3hUaW55ZkM4MjFaYzJEZUl0VFpPZHNNemx2WmU5Q0ZJU0d2RFZKbFp3?=
 =?utf-8?B?WVVtQytnSzFqTE1aVmZEY2dPUTBwOEFzc2Q5a2F1bWoyUXl5b2ZmVWtnZzV4?=
 =?utf-8?Q?KzweMSAkR2S0wRroAxpVSi6Fp?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdbc3d14-30c1-42f1-0a7e-08daa6c9032f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 11:59:09.9492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 43WgoQXW1umiXh5+TY33DZyu6FF8pS7hjHervpf35+eYLsK5l/hCz2FnMsQ9mwAlqBsAwIyasBqxB3HiM2LBjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8990

On 05.10.2022 13:03, Juergen Gross wrote:
> The CPU vendor checks for pmu emulation are rather limited today, as
> the assumption seems to be that only Intel and AMD are existing and/or
> supported vendors.
> 
> Fix that by handling Centaur and Zhaoxin CPUs the same way as Intel,
> and Hygon the same way as AMD.
> 
> While at it fix the return type of is_intel_pmu_msr().
> 
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Wed Oct 05 12:09:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 12:09:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416139.660773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3Dd-0000Xp-LM; Wed, 05 Oct 2022 12:09:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416139.660773; Wed, 05 Oct 2022 12:09:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3Dd-0000Xi-Hd; Wed, 05 Oct 2022 12:09:45 +0000
Received: by outflank-mailman (input) for mailman id 416139;
 Wed, 05 Oct 2022 12:09:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og3Db-0000Xc-Ua
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 12:09:43 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 982e42ec-44a6-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 14:09:43 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB7016.eurprd04.prod.outlook.com (2603:10a6:20b:11e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct
 2022 12:09:41 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 12:09:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 982e42ec-44a6-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cJykIicEqWhK3yTXVQAO6b3ykIV+g5uzTm2NR663zrOjmKMI52DGbiNkGQuYgKkh3s4cGfDGzIWAANX5Fr3WoyhDL6yL9mOL9VWqiSL25j2eYT8tqhtMfVpJIiBhT4D69wpS/6VZEa0uocOpQZXRuKhvkal6GdWhm7UQ4S6IqpfMeV9DWlijhMBcmXIncuXFd5swgwF59t7602uQ44AW1l+rQWltxhMBnbpbvWfqRTWHVTKkeYapgujH8caGoEn4YMcIKt1TC3sn5FTpPbDylKf6Elv56Hk3NX0orqsTw2MsHBEeB7YRgnFtqb4j3dyoeffvRpx0UvyOktH7yhpHSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x4+mzrlVX96OoGOGi2TAHnEtmXGsumBw7qZGGLWRoRw=;
 b=TL3mzHZ9teNuUQzbf65Cxbj82D8jversZVXVYVXo4sLn9VEGHQezPuAPRlWt2MqBQ5BNE/ummshtpUxlzjACKJBUe2POxKuLf58D/Lwoe374Gso4GnsUY6p87H0yyg5/uFmpzvscat1xGX0BJmLvmgLouJ0/C4+JnIiWCrRrwQ60Tsg5cTLbiUNqIAcX/fMJS5Jm3e4IGzZI3yhWx6CKW2mK9CafzxD9I5JcrPdnejZM5MPbWUz6m6QH72p64MG+0G0CXUBWcNxj/Cydpyx+YTwMMOgtOvF8ilbuHXEKfH2I/qfD0LqCy0LZ15Z8M4YcEcC4mBvL2etOgEd7QDjMkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x4+mzrlVX96OoGOGi2TAHnEtmXGsumBw7qZGGLWRoRw=;
 b=2uGR3rNQOh7au8P6Srq0Ov5l1JJ97alHhyTCpCaphZFTM9yF3fZJKQWeAH5uBdqE8PTJy8W3QWkcXvxA5t7CsrvaK8yoS1hlao6xHAjKDMuwBOZMhheZv3E0uv25lumkq4Vv1rDTUXa0gSxpN3RUkDnd0QbioX5/QcSvgDat5mnKnoquo2EnKmNVFzOxaBcUrPEE3Z/mZXws9ni1eYJoNSbzDKVPEI5s+n4JcfkxuFGSrifWcpdYX96J5YvEkfY/UNjmFv7DceyNaStYhQjDlLQ+HG1euvuA7xNJU22wjk8mcMiFBSaIdJf3XD057GOaQx0mGJzHNFC+RJve7gTw2A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <272c62a7-798b-1b00-0a4a-1eb18f480798@suse.com>
Date: Wed, 5 Oct 2022 14:09:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by
 default
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-3-andrew.cooper3@citrix.com>
 <Yz1aZJx5AZae/2U5@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yz1aZJx5AZae/2U5@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR06CA0573.eurprd06.prod.outlook.com
 (2603:10a6:20b:486::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7016:EE_
X-MS-Office365-Filtering-Correlation-Id: 09fe18fe-66bd-4827-babd-08daa6ca7b99
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hRDsH4GSWas4ohsxgmP3tYCJB36nJkXiVcXjJ/2xMhL1Xh/lGeXiUs4Ih1upqapWQLsmRY6rWh9Ra9phszcllXtvWyQRZtHL2DVjeMQWn0gOOeAOKLSjMa3BXOkMQDC6OUfMZwPa/gSjwn+uBGpkfIrQ5oa9gf30xGMflJnR2W4HFouGJp1TmBbWjuJj4B18I1N+Rc1dga5eKjLwdSzGtEgKkrY1KDZJ6I584bLVo78Ti+3IdTDgKpaSrzsLC6ztY6ME9Wk6pgYhxhMyXj5eGF8Gv3/muzjyI9jK2GL8S1WqJhD4YAuKIFRF1BavYvH7C22R1g6ExU0xPSwp03U9FdmS+QSwGnUALx0Ejks8l9vm1G/DKo2PzGJG+/AUziCxA1L66LPHEqfHZqce6/xoHjPyMsh7pWGVvbmND2YEOuekm+1FukRPxGiozTdgglZWOO8+g9FhOPVw2xJwBfLGdZnwBfHZCCQ4jNr2ggneFTsw6FNYTVLhtevjxRiB8+wrvt16tpK9WbQUYvE2m77wEDkO1c9eKpmnrEKWrcSlmKvK4rHP5BWCzCKb+0gAfhgk2Hip7nsKaS8ASN3uINfmYyj25C1WDMRMR59c+M0tlGyZnLgdoNfK5sZ2YdzKSukMa1r0fRnwBhuhi9JlsJszjO+nHPc3N+aBy6wJe9I0atT9TtpP8/PtCBiZswPxgaINExKkqXDBYAqYcNO+/J3GEdL/RXi8ROKX9AUjEUmHFtYet5VgNl0K+SjEBsr2XWDv81XRGBOjiuYgKb1RFxAODiS2Ogso5t97NA/kf3BRCQg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(376002)(39850400004)(396003)(451199015)(86362001)(5660300002)(4326008)(186003)(2616005)(8676002)(66946007)(36756003)(38100700002)(8936002)(2906002)(31696002)(31686004)(41300700001)(66556008)(66476007)(478600001)(54906003)(110136005)(316002)(6506007)(6512007)(26005)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WEUyTkh3M2dpc29aOXc0cHQ2UUZQOS9YaUpGQXRjeU5sbGlsdXMyL0thTVNG?=
 =?utf-8?B?NEk1UGx2WHVJVUw2cjZNbjdnTzI4S1RrZ05maTJwR0U2WG5KendvdGVRR09k?=
 =?utf-8?B?OXVKRnBCbTd3djRiUkpuSVVzNVhGV3R3eGgzdXZvMU1zVmN1aEx1QUZPcTFv?=
 =?utf-8?B?amxCZG45TGNHMGEvcGpVUlJSMHdWVEQyTXRFbnBCTVk3RnAxaHF1QnNpVnZI?=
 =?utf-8?B?Z1N4WXRwUlE5TW9zKzkzclNOTlBHSDF3NjFJa1BtczBaNlpNM3NvT082d3FQ?=
 =?utf-8?B?L3VjSnBtcFBtUDBmS3N0VUNKK3BmZUNlSGNEVDVtYnZSaTdDTnE2Tk9waTQ4?=
 =?utf-8?B?UEZrYVdFMnBlMkgwTEVmK2RoWU15TXNpZnJhZ1BOczFScThMWitCUnk2b0VC?=
 =?utf-8?B?Q21KQWhSWHBvc3lKM21naFB4SURkbWQ2QUcwTk1pbytBeXlmdmF2RTVEbTds?=
 =?utf-8?B?Y1JqdUVKQmJkbEpKWnFnVitwdlRIbGJEb2hwNm5EWXpxSmdJTVFTN3NaM3Zu?=
 =?utf-8?B?SFFlOElSaXJJZXNoQUFoU2lDTmorczlqK0ZMWE41YktwNTVNcTJ2M2tQdUZw?=
 =?utf-8?B?eXE4b0Y5Um1vTGhlQkpjWFBvZ1EwUnJHR2VvRGtsRHBnbENuWHlOdWNuQUhD?=
 =?utf-8?B?WXI3d1hWTmVnT2JOWi9Bd1N4bDdDaThOUTQvcjU2U3dpalR5ZktTanBqblQ1?=
 =?utf-8?B?clM2eHovTEUyNmFlZXhmeHFqdTdZa2hNSjY4MXllRDIySnlDaVZVS0xCTFNi?=
 =?utf-8?B?UFFvdWxHL2M3S1RCVGczbmRVaUYyY2ZWZ1czM3crdzkwVDRrVVlnT0xkL08w?=
 =?utf-8?B?L2tnUVFvN0t1SU5ZUmpSdXFialUwajh2RU85U2RZUnJCdFZXQW9JYnFiUm1P?=
 =?utf-8?B?MEdtaHlpUUJieXQ3S3FOQk9tbkFreVhqZW9GT3l4bE1XVy96RTFSWFZtc1pz?=
 =?utf-8?B?eWdGMTBpYWhPR25LUUYwZWhWSWFSaWlVWXJyc3I0MUhSb2RaSmY4QUwvblVr?=
 =?utf-8?B?YUt0YlVaUjh3RFNxMWdCalhmaEdrR2dDNE92QjNIaFZzUWpFejBpeVYvSkdK?=
 =?utf-8?B?ZmRaRFFoeU1aM2lNaTRDTlFUL0I0SG1rbVNBNFhma3hncXZqNzAvZzVtR0Vv?=
 =?utf-8?B?S3B6b3BrVXdpb2VvYkV3eWVUZUdVdzFsNUhQaHpnUjVHK2wzUE14ZmJhaWEx?=
 =?utf-8?B?WC84UGN1c1BlZTBrZFZrWWtyb3lLNTFHL3gxS29SSkhCVVZNZkN6ajd1WDRH?=
 =?utf-8?B?ODBBQVhVVDE0Mmo2alBRMS9LZTVQSVZodTNUbnJSYTNZRndNcC9MT25qaGFm?=
 =?utf-8?B?S21menMzeVdINCt6cjZYbHZkRWxVWTFjYmFlc3J6VVNqdjlad1BKM3hZVitl?=
 =?utf-8?B?Q0lPazJGY2dCNnI1cXArQW1ETHRPT0hhYm1aektSVVZHQUlzVk4xWHRMNVRU?=
 =?utf-8?B?ZmlzOENXR3dhMUJscHpxRndxYmVxeFI0WjBxRExleWtUclp0MXhFaFVJcWtH?=
 =?utf-8?B?OXAwR1hhbE1aZnBUMHkwMGYvYUVNV2pwblZUSlhJaGpoenh6RjZWbGtzWEZR?=
 =?utf-8?B?RWxWYUtKUEJBbCtCRmp2Z3lvdTZKQmR6a0NJMXNXWWJndXJVOWhSNVhLY255?=
 =?utf-8?B?SlJFN3Z6UnV0YXdDMWkyaUV1cXZ0aldtYnloMWZoaHpQenpmNWxLSnNNanJV?=
 =?utf-8?B?ejNYbnc5Zi83OHFlcFJhUk5ZNXJ6ODVBSDBXV0dMRmdEM2xUVW80N1dTTllZ?=
 =?utf-8?B?U2RZYUNPMkxLWTJvL1FuUDJXSWFLNHpqRzBTUkkxb2dOaDJLOEpLd0dBODU2?=
 =?utf-8?B?eE5iamhWMWdJdVpMNTRleWh5VHlSOXc3eGlNQlhDSHI2cE1wSGoweU1CbHVL?=
 =?utf-8?B?VWhXb1lMUzF6OXBhUU52c3pEMjVkTHlVQlducXVUbjlzQmZxOHUydlNnN0My?=
 =?utf-8?B?anF2R2N2c1lIVXBlS3FoRFU4cTFZNTRwSG1OQkpMcEJaZUhCdHV3ZTQ3QmU2?=
 =?utf-8?B?UW0zWWltWmNpWjQ0eTRwU3dycE8rMkljYk9YV0FseVRXZ2o3cnFWYXRrbm95?=
 =?utf-8?B?bExPS05PKzZLWWR5U0tRT2FFOW9hbVRXNlFSUXY1MUVOaDhmaEo1MFpoZU5m?=
 =?utf-8?Q?SKyBEPwkkZVFh0GlZxCk7khhT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09fe18fe-66bd-4827-babd-08daa6ca7b99
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 12:09:41.5029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +RTFsF9ERBjwRpTHO+EFwmcdIAAExbwAcg9iXJ644Sdzw/6/W6DmdIYqUuHPtQUfXzKEa1lRlh/gqrdVQna5Cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7016

On 05.10.2022 12:20, Roger Pau Monné wrote:
> On Tue, Oct 04, 2022 at 05:08:10PM +0100, Andrew Cooper wrote:
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -209,6 +209,34 @@ void ctxt_switch_levelling(const struct vcpu *next)
>>  		alternative_vcall(ctxt_switch_masking, next);
>>  }
>>  
>> +bool __ro_after_init opt_doitm = true;
>> +
>> +static void doitm_init(void)
>> +{
>> +    uint64_t val;
>> +
>> +    if ( !opt_doitm || !cpu_has_arch_caps )
>> +        return;
>> +
>> +    rdmsrl(MSR_ARCH_CAPABILITIES, val);
>> +    if ( !(val & ARCH_CAPS_DOITM) )
>> +        return;
>> +
>> +    /*
>> +     * We are currently unable to enumerate MSR_ARCH_CAPS to guest.  As a
>> +     * consequence, guest kernels will believe they're safe even when they are
>> +     * not.
>> +     *
>> +     * Until we can enumerate DOITM properly for guests, set it unilaterally.
>> +     * This prevents otherwise-correct crypto from becoming vulnerable to
>> +     * timing sidechannels.
>> +     */
>> +
>> +    rdmsrl(MSR_UARCH_MISC_CTRL, val);
>> +    val |= UARCH_CTRL_DOITM;
>> +    wrmsrl(MSR_UARCH_MISC_CTRL, val);
> 
> Is it possible for the firmware to have enabled DOITM and Xen needing to
> clear it if !opt_doitm?

I think a firmware setup option is quite plausible to expect, such that
safety can also be achieved underneath an unaware OS. Note how in my
earlier patch I did specifically set the bit both ways, for this very
reason.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 12:41:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 12:41:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416146.660784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3iP-0004cH-4N; Wed, 05 Oct 2022 12:41:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416146.660784; Wed, 05 Oct 2022 12:41:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3iP-0004cA-0Y; Wed, 05 Oct 2022 12:41:33 +0000
Received: by outflank-mailman (input) for mailman id 416146;
 Wed, 05 Oct 2022 12:41:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xhym=2G=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1og3iN-0004c3-U9
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 12:41:32 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 075d95db-44ab-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 14:41:30 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id CA44B32002D8;
 Wed,  5 Oct 2022 08:41:25 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 05 Oct 2022 08:41:26 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 08:41:24 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 075d95db-44ab-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to; s=fm2; t=1664973685; x=1665060085; bh=55yh53ucbT
	+2cHtxUmKPDXZeiinNra+b83TyTfWjhBc=; b=Ux4knCyCLCvWoGy7EMfNB67WYd
	+n5bI7l96FOOhfywN0zkyo/dYHQfqK1t96HnD1ZVNjaT3lKVyMeSw0l42sMdCTum
	wfZ11pi2LkokzaGO6oFK0eW+n7XJjbaSHh7BSWSN46/qaJb+cLY7sMWao4bDd+pX
	cuAc4+IdjdzTb3+enOrLYuvLsu1DeBv5XEkXpRQQUn7dxKG1TtX0U+zirXiIWTAH
	pYuH915t+X7rzPK0PeBvkzwRxq91ZvfKneN0oUAXm11ly/bhkSAg4YAN+OpD2g0R
	zazj5XY5s4nnofm1lKJlpnro8wdN7grASFVpTlBVvgF3wNNAyRPtU0j2pRqA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:message-id:mime-version
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664973685; x=
	1665060085; bh=55yh53ucbT+2cHtxUmKPDXZeiinNra+b83TyTfWjhBc=; b=C
	1OeZzNqBZF/kjUZznFQy91afvq1dc0VuvXVqO56l2/UgtGIsxaXw1EBN1hyTgt5O
	7e43ccH6izzKT3Lf/EJepwgsWGO0WeYmWlc9QNpJt6zzCHKPkZAtod5SnzVpGwys
	iuBA65BW8mZ6JPXOHmk2jmncapxkAkfIvvNMeamfzl+e+v/fYXbtU8R2uarKzIaL
	PaSPBroj9i1jpDfqxsmXWFXFTSI66k0o7A2vK4PWXnt1nezXNxpAWsOw4kk6EPTM
	areYq2+I3fGPCeaUSgBmkPcwL61b65jj4AkLrmpqHOJLm3AfNcTKLcsMhH62base
	y2DZcxNMAzB43836+9yWQ==
X-ME-Sender: <xms:dXs9Y5QPaXcPrxKeS---p3C5sdBEmPu4sJeK27CMpvyTKkMjxB6tUw>
    <xme:dXs9Yyy2IDibS6ikMFGlBCOEN3Y2Em2Q52DpUwIsj5fxpSBkoosZO8-x4EGeOQ_W8
    DOM2gNXfxJr7g>
X-ME-Received: <xmr:dXs9Y-1wiVmc06-FJmU8_FHPrQkQPXejDLeBMHoByviV9WD9_VYrKmsiiIC8-EhkAEhZqu2ZIxcnroqBKePgWvtAhzzd-ld21uKU>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgheefucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfggtggusehgtderre
    dttdejnecuhfhrohhmpeforghrvghkucforghrtgiihihkohifshhkihdqifpkrhgvtghk
    ihcuoehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqe
    enucggtffrrghtthgvrhhnpedugffgieelueeukedthfffledvhfejfeefheeuieekhfel
    udeljeejleegjeduffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih
    hlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgt
    ohhm
X-ME-Proxy: <xmx:dXs9YxBvWYBIGonGdjUK83yjN8C7LdIhNGxaVuhJflJ_EdJVFrvglQ>
    <xmx:dXs9Yyhu4H4WQNM97qehbYwYRAYWc4yUiiD5WMQ67AUN3XrG_XQK6Q>
    <xmx:dXs9Y1pzTWacG8521T5CWcVyXwM1fskxpB_5Gh2zmoRElG_GQMAorQ>
    <xmx:dXs9Y4cCfaUbA1_u4ENyjqPH4otYnBgSQp6LJC9G2ioeI5gCaOgopg>
Feedback-ID: i1568416f:Fastmail
Date: Wed, 5 Oct 2022 14:41:20 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Subject: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
Message-ID: <Yz17cLIb1V0zjEjK@mail-itl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="0WYvwZgrg7kDSouA"
Content-Disposition: inline


--0WYvwZgrg7kDSouA
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 14:41:20 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Subject: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt

Hi,

When booting Xen with Linux dom0 nested under KVM,
CONFIG_XEN_VIRTIO_FORCE_GRANT=3Dy makes it unable to use virtio devices
provided by L0 hypervisor (KVM with qemu). With PV dom0, grants are
required for virtio even if just CONFIG_XEN_VIRTIO is enabled.

This is probably uncommon corner case, but one that has bitten me in my
CI setup... I think Xen should set smarter
virtio_require_restricted_mem_acc(), that enforces it only for devices
really provided by another Xen VM (not by the "outer host"), but I'm not
sure how that could be done. Any ideas?=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--0WYvwZgrg7kDSouA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM9e3EACgkQ24/THMrX
1yw9mAf+OEUcSzTVovlh3xQmC+meU7OII7kNOA31xjKSV4RaNdNyryh85j1hDf1C
zAwmHUi9mikLUWXa9cWU3nYcN2pETmwKrua2lIsQa6O9vdhzdbj28sOyNONqu2sl
eSL83M1+NqBDQOtLXkuDcJr2FEbvEpq86wlHdvvmx+7PuiHwCBlcb2SvkhvzCrEe
pcn4bRxQ/bbqO+wOABVGgRi5ufUaCvTrJ9/eDxmqMYA2NPb16qrRMonJws1UG9c7
96tFKG/xjeoar9BS3UmMFMFwzxd55uI29giQZCejrAXQG5bgTO4bbGllideep2mM
wEtGfnVqfMQVn1V3rRMevLNTHPnU0Q==
=NNOP
-----END PGP SIGNATURE-----

--0WYvwZgrg7kDSouA--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 12:58:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 12:58:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416155.660794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3yy-0006CR-Cl; Wed, 05 Oct 2022 12:58:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416155.660794; Wed, 05 Oct 2022 12:58:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3yy-0006CK-9x; Wed, 05 Oct 2022 12:58:40 +0000
Received: by outflank-mailman (input) for mailman id 416155;
 Wed, 05 Oct 2022 12:58:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iqu=2G=citrix.com=prvs=270658c04=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1og3yx-0006CE-FU
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 12:58:39 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bd332fd-44ad-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 14:58:36 +0200 (CEST)
Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 08:58:28 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB6583.namprd03.prod.outlook.com (2603:10b6:a03:388::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct
 2022 12:58:26 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Wed, 5 Oct 2022
 12:58:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bd332fd-44ad-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664974716;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=nqX9Li74g/uSXMzsbhfgGPlCUOXaCz498NvQNGl/plI=;
  b=BfQ8gH9y3LGHnee5MAijIOeklYhxon8O/wglXH1jMXUYItaps7YPjAEu
   7a9plzAIbZdJPaMrauPRw5eRvCEE0P/jP239I5ZXBX8Aq4azafJ8/dgV1
   8paWaZoieDvk/4otKYutTBze7/Q60UzbW5Zx3pIM2cCqawVGbIT39rL0C
   w=;
X-IronPort-RemoteIP: 104.47.59.170
X-IronPort-MID: 81142661
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:GJ9N4qtYgePDxUBD3UlJp2A/f+fnVKZfMUV32f8akzHdYApBsoF/q
 tZmKWjTM6vZNGCjf95xaI2y80MCuZfcyoBgTVNlpCBkHi4b+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPagW5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklAz
 OEcFg8HcSykhvzn0YjlFLJlq+gaeZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUuiNABM/KMEjCObexTklyVu
 STt+GPhDwtBHNee1SCE4jSngeqncSbTCNtLSOfmqKcCbFu7x0hIJAwxD0KC8aOSqkyGUZEFM
 nUSw397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOlMIwXy1s6
 VaPkPvgHzkpu7qQIVqY/62RpCm/OgAUK3EDfi4OSQYZ49jlr5o3hxiJRdFmeIa5g9j0MTD23
 TGRrSI6iqkTjMgEzKGy9xbMhDfEjojESEs56xvaWkqh7xhlf8i1aoqw81/Z4P1caoGDQTG8U
 GMsnsGf6KUCCM+LnSnUGuEVRuj2v7CCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC
 KPOhT5sCFZoFCPCRcdKj0iZUqzGEYCI+QzZa83p
IronPort-HdrOrdr: A9a23:h8MEKanKKJLF1FPfnNoWAGTRcwHpDfMEiWdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63
 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis
 PFrRsMN9l6r1nRYma2ix3w3BSI6kdh11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtlqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWDHAcEcYa
 xT5fPnlbFrmGChHjbkV65UsYWRt0EIb1O7q445y5SoOnZt7StEJgAjtbEidz87he4Aot9/lq
 T52+1T5c9zpoV9V9MDOM4RBcSwEWDDWhTKLSabJknmDrgOPzbXp4fw+6hd3pDiRHUk9upEpH
 36aiIviUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrqn9wPRsnAH/
 qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeaGJP9VTI/Hm/vCH
 oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPia6Y0JKqitT75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF
 Z0Jq/hn+eyuXS2lFy4nVlUBg==
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="81142661"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bmGdpDr/1Yd+p/AH8YS4nriBEaEmSAM12kZrv1DeDcmlybiS4uPWfsObpocu0VZf9eJJxVKN8QR7af3h8fPQ2JLBc4+FFT2fW3bwcwNoJbWeeznqwFX7EW9wCTf1WOgYSfap0LCKy5dxIocOx5+EszNPtltmrBerPpDgYXPhFz6j3NzbiesMR12668siGxwQiFueo0pElTrsBIG34irwNaiaKl5lEqjcjXQkEFMNLJe/CTVqZT66EyH733hGObxpnXNTcY126bf9XesKc59n0/vS0lQZiOJYyAgP7WN6Ns4nI4HMV1dzs2pyBGNAoC5Ao8GgQ213b8d8kQKjtYoPzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nqX9Li74g/uSXMzsbhfgGPlCUOXaCz498NvQNGl/plI=;
 b=eIrUOzQLu/es6+wC9VoB58zJ3OP547UmPt5wL+RJTaQYA2OikKsTwCHmmAsltXI8p38l5OB6YmkeoDSUEOP4+KKh+/3AdGBqLBtQI60GALPTgmEKWB1lhYfh+/WVmG3z28Iq/uYPB3cS9/lxuszZzwEMqs10aGrovEJuNamOtl+z0AzjQy3Oqmqo0+WUJZqZ0OinOfX24+sYn+5B68l6bgij1VJ0J2XOvamZlE4LdVtTlD1Ak4LKE8fOzUVPc3pEjvPDELafCds9YCtf1GJtrucBI1conlXA21Y8KYh05Fw0gTtoJziXtIyngOnDv14uNpWj1qdolsPcjQXs45m9FA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nqX9Li74g/uSXMzsbhfgGPlCUOXaCz498NvQNGl/plI=;
 b=aFJgZvOWpauSxSaWM4hCmXaX5667frzGszPg2NpRTT4mmumDFW4OIx6+fQdysT43onEBsSSAwTLbnhNWRY5jNhO0/C/HiRFJeA3lSykvGmONJV0uhFQ8Bjui6UmW5tBSf1HXC6wg1kzTEUwb3GeAZtph1LVebAFH+Zq5gwGQxbA=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Henry Wang
	<Henry.Wang@arm.com>, =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Thread-Topic: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Thread-Index: AQHY2AuYxJImxml8GUGenwgOwsThN63/X+4AgABkSoA=
Date: Wed, 5 Oct 2022 12:58:26 +0000
Message-ID: <ccd05cfe-1f77-5bd3-996b-bfcaf2ae30f8@citrix.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
 <50324b35-5b75-18b6-6ee7-fbe9b5f5d662@suse.com>
In-Reply-To: <50324b35-5b75-18b6-6ee7-fbe9b5f5d662@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6583:EE_
x-ms-office365-filtering-correlation-id: be78607e-76fc-4ae6-982d-08daa6d14ae2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 5Vk4kp3EIFtOFEXtzm3twdAJY9UkfJJtPHqiI0H6OJbNfDm6f+/Wy7t0mJNEmjxTOtzafd9JeEkQ7LKWLIwWI48XVfctlT1ODCyVTpE6vfs06v4zJjzvwZxYOLk7zDHG5T5If/DDHvJg3/7m53Okdsu/9ZDSej8zARmG9bIRRQWHkrVswWC+90eTGpzViL917fR7C2Eyh3UzpCSQaLO/aiU6bgp6MwElrs8wprMltWBbNA37jY38TjJcG6PqrFmHMLzewdZHJoobttmOXtK1v+AJ1PpIirmc7ovNgEZzH9eq8p3SElAe9xyGO5DIeklamfQjJZIoQHjhgUV/xLp71ErCUyR6qSJA3PSPmWVCv3tjArIFZP9J8apGTaFEbFcU+5IvGZV1QPsyztD3ovNvTHYWhEne87/K0p+6jBIR32hAhhdt9B4QtRCEuIKeWKT2rOUdUuGr+z/TBbnQYlzstjbheYqjE8fZFs9JR6Je2N0f7wEpkMbXLbGOQOgInvaceJiTu1HyQg4kPwCk4aLQijC7ZIB8CuhkBV/KAMf+DrhZvnZ1BRv4oZCWTDSMzM4jHVwy5WLV7ilSJSh2c8jHqe23OocYFHPLcaRd0syld278Um/SoC4MFj0Nj98VZD+toxEKkh2jQfVquJ2ucKxGlJx7tu2rxvBxvvgEayLBl88f+t7fKFu912rwqVZ8j2PHT5sbXua996QqD/Pqljhp5yipzdp91in7sfn4/VYiMDYwXCN40F6vxqviS6ggSEqraMGLH07HhAGEhWiMFGST1rBRHBZP3vV/elm7kerliBNuoN/Pb4S7shI6DfB4LCtEJFKVRErNhcHwCKW1/xfLnw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199015)(76116006)(54906003)(6916009)(478600001)(316002)(31686004)(6486002)(71200400001)(91956017)(66446008)(66946007)(8676002)(4326008)(66556008)(66476007)(64756008)(8936002)(6512007)(26005)(41300700001)(5660300002)(82960400001)(53546011)(2616005)(186003)(2906002)(6506007)(36756003)(38070700005)(31696002)(122000001)(38100700002)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?YTFvMXdpYUVTQmt2ZzU0b1lpckZlYzZsTWVWcFdVYnRuN0tJeTNhclU2dmxQ?=
 =?utf-8?B?L3FqNTF0OW9tdnRKUHdXdVRNdHdCTjh4OWY3YWtqWUhpSzdFd2phSkp1a0Jv?=
 =?utf-8?B?ODVmZVlndk9mbEVuR1lkQ1NhN1A0bEszbHdjMm1tZlAyTGlMOFpoNUJlY3kz?=
 =?utf-8?B?OXFHckVpVGZnQ1NvQlR5K04zNWt2bFp0RnNabWdEcFEwRGV0dmhCUjE5MWNB?=
 =?utf-8?B?bW1zSG5wYUR5ZHUrazEwazBSOWZLc2N6RkZkdjZMMWQ1NG1KcGw0MmdCNnpF?=
 =?utf-8?B?L3JiWWpPUXV6TkNqVER4L3FmSFJVRE1RN0tDQXVndE9hc2N3QTU0WFQxcWtC?=
 =?utf-8?B?OHIxcmphSXZyb3AyUzhrSTlSbkdFVzVVbklXb2kwRk90VkVJV3h5cXU5Tmlj?=
 =?utf-8?B?clpZcUpjU0xOMXlDaFRHV2hsOU5pMEhSMEZkSFBTbjMrcjlOa2xhV2VDSmFO?=
 =?utf-8?B?cURrQzJpYzFwMituK2NsRlFna3JiWndBSXhTOUJ6dG1nZnRjLzBGa1ZTNnhu?=
 =?utf-8?B?SEsxR25DelNOUkluNWs0ejlPMFkzd0RhU1JRN056Y3lVSDJLZlh3L1cySHZM?=
 =?utf-8?B?dW9DVUR2bHBVaVBGMVhjTnhnOUtiaDdSMU42TThHWDZabytjVW5WeXM1WGt6?=
 =?utf-8?B?U3I4cUVUSmNMR1FtNVZ4SWRhVmg4Y3RET0lucjFpYmdRekNCNzdsZW9qY2tS?=
 =?utf-8?B?a0k3ZHdJR0F3aDdpSktUMzBRZUpMSURyN2NNUkVwQmFNVUFkSlJiaVRkdVhF?=
 =?utf-8?B?NE80NmpVSmZDVHNGWE9ka2tGelhObEcyVThHMjZZMjdjVU9JMVUzOFlqZkN1?=
 =?utf-8?B?bVpmVklpNEw4a3dKWExraUdkbjAzV09nclcvU1haSjUrSTZQdm9PREQxN1Jq?=
 =?utf-8?B?NlA1UmZpYzBjNG5iMGhQS2g5Nm8xcnMwaXdReXdkVHJNaHNnR05uVHhSTWly?=
 =?utf-8?B?dUx2eFBKME45YUM2c1puUy9hWW5IclhJZTExUXNTYXpTcE53Y2tNTkNjOWNF?=
 =?utf-8?B?bWxmU0RPbTZnd1Fpb0Z4VXdKZTdOeEk4M0dVTjd3QjNscERubEgyb1BNdTlp?=
 =?utf-8?B?cEVPcnpUYjlvMlV0MFk4ZlBlR3YwNElkN0REcTZtMWg4Qms5Q3hoRmhvejlj?=
 =?utf-8?B?aVl5dTN5cEhUVnRXTG81d1dXZnl0S2lkUHNaTXZ1SmVxZTdmakhKWlAzNGFw?=
 =?utf-8?B?RDZyNWI1NHpGbDJhQit2N0llRWJscnhwaEo1YU1wT3FJeTZBN1VWNVdxVUlQ?=
 =?utf-8?B?S0FseVZ4R3dialhlRnNqL1ZpeWJVSEZqakFXeU0xdEpJOVQzdzdmZ0NCMUpt?=
 =?utf-8?B?cjhYZjlMR3llTWhmT0t2d0lwVjRTR09GdUlEMkdDVlFWV215aGlwblkvNjF2?=
 =?utf-8?B?TlhITTZUeGxDRWM0dm5OekI5RFlBQmZjc2JkaE1xYnhHQUFhVE4wWHFMS1dr?=
 =?utf-8?B?ek93TlhZL2FCdUVPY21Za0hMNUx5dndsOXpWbnlWakQ3aGhPbmM4bGVxTEU4?=
 =?utf-8?B?T3BHZ2JtUTAySER2S09VKzhYREd6SWhBQmZnYVVmc0xFREVNRWtuWE5WNzJn?=
 =?utf-8?B?bFBzWDErM3RyczZrT1FoOWlVT3VOMlczUnpnTlB2OWlUOU1HZ3g2Uk1qRGpN?=
 =?utf-8?B?L1hUUGJxRE1yVElUQUdXTFRRcHNXY0V0UUVuYzVEd3d1ajdHZjQwTVNNSWVM?=
 =?utf-8?B?dzFuNlB5bEczT3FjMyt0eFBtVlF0NDZxZnladTlQTFZ0UVE3cDFaNzVQUTRL?=
 =?utf-8?B?bTcreTdxenA2NGZ0UWpxOHVHc2RleHNiNUUvazlXZWcrdGNER1VPRzhnS3VX?=
 =?utf-8?B?RjNKVUJET3NIUWlSOXYycWlsTE91MUhVWGp5cEI2QkFQYUtoa281SW85dUFu?=
 =?utf-8?B?VDFqajh3WUc5REtqd1NQc05JaUtRNzF2bmZWUUhKWHVnNERDVE9LeGJyNUNl?=
 =?utf-8?B?S3NOK3A0cTl2NzRIRnl5NHQ5Qk5WbW5XNFN3cjRnNjYxRHVYS3NZdWVwR1Zp?=
 =?utf-8?B?N21VV0NFREJkcEZ2ZFNMNFV5Vy9WbVBCRVdoRXNlVk5NNkxuQTdueWcrM2dp?=
 =?utf-8?B?UkFUQllTQWtiY2pvRUtYeUdya0RvZUJmeGMyWXFNUm1BOGswand4ajZDQ2NG?=
 =?utf-8?B?QmZNZCtWeTBOOGxFTU1lbWpHZHd2Y1lFVFdpVld1L2FTWlFMYjZCVHE0NTVv?=
 =?utf-8?B?c2c9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6D22DCD350F98F419783473F16500B6A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?L3VlTGJTK21JcUZqQytyZG8yVDNSWXc3djl1cmVZSFNRYXAwZjdRaWt0dzVU?=
 =?utf-8?B?Qk45dEhTUmI2Nmo0S1AyOFNnNTFXMDdXS2g4RjRkQ2tVUGY1WmlsMGVpOEJ0?=
 =?utf-8?B?TE5FSm5VWGpzaENKdEtqVzBUSTdQRG9EazVjSFdHb3hKcHFjM2NrcnU0MGQx?=
 =?utf-8?B?WURZa05Rd0w4WEU5U0xPVlJDUld5cmtCdzBZUEZ6bEZNdE9Tdnkyb2t6UVhE?=
 =?utf-8?B?bkExNDUwMlExdGtyQzBwVVdmQS84NURYcEtoZEpmRUthYnhiM2pQTWhVSC9H?=
 =?utf-8?B?SnNQaC9Ic1Q2OHpaRS9JME15MnRSNG0wWlIwWEVzUXNoRmZXQlhXOEhsM1Qr?=
 =?utf-8?B?enZFQ3ZGdmJkQkJnRU4weFZENzdsWjl6UlduS0hqT2MxTnloMUJRY0k1NDVS?=
 =?utf-8?B?UDQzM05LSGh3MEpSdkdrdldwZmRWc04vVnUrNzU4dEZINlFQeXd6aE82cTJB?=
 =?utf-8?B?eEVVSCtIU0h5SjVoazdWWDVTUzNyNHRheEF1NjFQN1Z3WDh3NlE1TkQrekJU?=
 =?utf-8?B?Szk0Uld5a2VXcW9QWk43NlZTa015NUNtblBld0hrSE5MWE5PN0tvalZLb0d4?=
 =?utf-8?B?NDVoNEc3NGRFaHcwUytGSzNUd3hZUFljbU9ZMy9mbWZ5OHQyTDZJOXRDcWp2?=
 =?utf-8?B?MHFhWWFIVnVFM244SnFzdFJFT2dTZkY3M25NaFRlK1VEUGE3OWJrTTlYSGdP?=
 =?utf-8?B?clJ1bFl0UnBGWHl1VURIRFB0U2J3eTg0bWs2dTBkTTJwYjVJRzF6TmhuMmZC?=
 =?utf-8?B?Ti9aK3FNaU43eXRTSElxNCt3YU41SEVYT2FQUGhCbHMxVjcycytUTUc2b1ln?=
 =?utf-8?B?Y0FkdVUvNE5KYjN2b3BlMFhxcW1WM3NIcUVmUG1QSEVtQWtxSG51bTFZRzNK?=
 =?utf-8?B?RFhwQzBqUHJrb0U2ci9TZ21sRm11czYwTis3NkxVWk01VFNyT09PbkE3cjBS?=
 =?utf-8?B?L3Y0Y1BQNThWRVkvMjRVMG9BQ2ZoZUhkN2d6SWM4MDgrOW5WQ3dPMU5LZUJS?=
 =?utf-8?B?elZIaEdmN1N2MHdCckZWbnIvSGhXZ1ppM1dwclJwYmNGMFBGYVl3ZWtXeGxQ?=
 =?utf-8?B?QlBMTTZHY0laRDJveEE1TzJRUWlsS1gybXZGS3JOdEVjYUV0bU9WT1dpbUly?=
 =?utf-8?B?b0UycG8za0YvV2lSMUhoaXo3RXVnWUpLSDZNVDJ1ZXY4ZFhFZUZSdjdXcG9W?=
 =?utf-8?B?cFNkSmU1VHNTZWF6NStiU3BHUkNNbDdFOUZCOGpRd2NlZFlacFFCU3hPOFhW?=
 =?utf-8?B?L0Q4MW5zYThMSlRCS0t6aXo5ZE1FYWUzR0FjMHBXaWRLdit0dz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be78607e-76fc-4ae6-982d-08daa6d14ae2
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2022 12:58:26.0617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JWIj55borJYhp/zdmnOAOHA1kc7QF4KW8W78ZrMYwNMOf4kFv0wCZhFA9L0vYERllA7ffJAyAG2auNvPv3KTZRzZhZPMPNi2LasMVdv2pgU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6583

T24gMDUvMTAvMjAyMiAwNzo1OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA0LjEwLjIwMjIg
MTg6MDgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBBIGZ1dHVyZSBjaGFuZ2Ugd2lsbCB3YW50
IGEgY3B1aWQtbGlrZSBpZGVudGlmaWVyIHdoaWNoIGRvZXNuJ3QgaGF2ZSBhIG1hcHBpbmcNCj4+
IHRvIGEgZmVhdHVyZSBiaXQuDQo+Pg0KPj4gICogUGFzcyB0aGUgZmVhdHVyZSBuYW1lIGludG8g
dGhlIHBhcnNlIGNhbGxiYWNrLg0KPj4gICogRXhjbHVkZSBhIGZlYXR1cmUgdmFsdWUgb2YgfjB1
IGZyb20gZmFsbGluZyBpbnRvIHRoZSBnZW5lcmFsIHNldC9jbGVhciBiaXQNCj4+ICAgIHBhdGhz
Lg0KPj4gICogSW4gZ2VuLWNwdWlkLnB5LCBpbnNlcnQgYSBwbGFjZWhvbGRlciB0byBjb2xsZWN0
IGFsbCB0aGUgcHNldWRvIGZlYXR1cmUNCj4+ICAgIG5hbWVzLg0KPiBIbW0sIEkgd2FzIGVudmlz
aW9uaW5nIHRoaXMgdG8gYmUgZml0dGVkIGludG8gdGhlIGV4aXN0aW5nIG1vZGVsIGluIGENCj4g
bGVzcyBhZGhvYyB3YXk6IChwYXJ0cyBvZikgTVNScyBob2xkaW5nIGZlYXR1cmUgYml0cyBhcmVu
J3QgdmVyeSBkaWZmZXJlbnQNCj4gZnJvbSBpbmRpdmlkdWFsIChwYWlycyBvZikgcmVnaXN0ZXJz
IG9mIENQVUlEIG91dHB1dCAoaW4gdGhlIGNhc2Ugb2YNCj4gQVJDSF9DQVBTIHRoZXJlIHdvdWxk
IGJlIGEgcGVyaGFwcyBqdXN0IGFic3RyYWN0IG1hc2sgbGltaXRpbmcgdGhpbmdzIHRvDQo+IHRo
ZSBzdWJzZXQgb2YgYml0cyB3aGljaCBhY3R1YWxseSBhY3QgYXMgZmVhdHVyZSBpbmRpY2F0b3Jz
KS4gSGVuY2UgSSdkDQo+IGhhdmUgZXhwZWN0ZWQgdGhlbSB0byBnYWluIHByb3BlciBlbnRyaWVz
IGluIHRoZSBwdWJsaWMgaW50ZXJmYWNlDQo+IChjcHVmZWF0dXJlc2V0LmgpIGFuZCB0aGVuIGJl
IHJlcHJlc2VudGVkIC8gcHJvY2Vzc2VkIHRoZSBzYW1lIHdheSBpbg0KPiBmZWF0dXJlc2V0cyBh
bmQgcG9saWNpZXMuIEFsbCB0aGF0IHdvdWxkIGJlIGxlZnQgb3V0IGF0IHRoaXMgcG9pbnQgd291
bGQNCj4gYmUgdGhlIGV4cG9zaW5nIG9mIHRoZSBiaXQgdG8gZ3Vlc3RzIChpbiBwYXRjaCAyLCBh
c3N1bWluZyB0aGUgc3BsaXQgaW50bw0KPiB0d28gcGF0Y2hlcyBpcyB0aGVuIGFjdHVhbGx5IHN0
aWxsIHdhcnJhbnRlZCksIGludGVncmF0aW9uIGludG8NCj4gZ3Vlc3RfcmRtc3IoKSwgYW5kIGF0
IGxlYXN0IHNvbWUgb2YgdGhlIHRvb2wgc3RhY2sgc2lkZSAoeGVuLWNwdWlkLCBmb3INCj4gZXhh
bXBsZSwgY291bGQgZWFzaWx5IGxlYXJuIG9mIHN1Y2ggcmlnaHQgYXdheSkuDQo+DQo+IEhvd2V2
ZXIsIHNpbmNlIEknbSBwcmV0dHkgc3VyZSB5b3UndmUgY29uc2lkZXJlZCBzdWNoIGFuIGFwcHJv
YWNoLCBJIGd1ZXNzDQo+IEkgbWlnaHQgYmUgb3Zlcmxvb2tpbmcgc29tZSBjYXZlYXQ/DQoNCkkg
aGF2ZSBvbiBtdWx0aXBsZSBvY2Nhc2lvbnMgY29uc2lkZXJlZCBwdXR0aW5nIE1TUl9BUkNIX0NB
UFMgaW50byB0aGUNCmV4aXN0aW5nIFg4Nl9GRUFUVVJFXyogaW5mcmFzdHJ1Y3R1cmUuwqAgSW4g
dGhlIGZ1dHVyZSwgaXQncyBsaWtlbHkgdGhlDQpyaWdodCBjb3Vyc2Ugb2YgYWN0aW9uIHRvIHRh
a2UuDQoNCkhvd2V2ZXIsIGRvaW5nIHNvIG5vdyB3aWxsIGJyZWFrIHNwZWN1bGF0aW9uIHNhZmV0
eSBmb3IgZ3Vlc3RzIGluIHNvbWUNCmNhc2VzLsKgIFRoZSBmZWF0dXJlc2V0IEFQSSBpbnRlbmRl
ZCB0byBiZSBzYWZlIHRvIHRyZWF0IGFzIGEgcmVndWxhcg0KYml0bWFwLCBhbmQgdGhpcyBpcyBo
b3cgaXQgaXMgdXNlZCBpbiBwcmFjdGljZS4NCg0KSG9uZXN0bHksIEkgZGlkbid0IGltYWdpbmUg
dGhhdCB3ZSdkIGdldCBiaXRzIGxpa2UgUlNCQSBhbmQgUlJTQkEgdGhhdA0KbmVlZCB0byBiZSB0
cmVhdGVkIHdpdGggb3Bwb3NpdGUgcG9sYXJpdHkgdG8gYmUgbGV2ZWxsZWQgc2FmZWx5Lg0KDQpF
dmVuIGlmIHdlIGRvIGVuZCB1cCBwdXR0aW5nIE1TUl9BUkNIX0NBUFMgaW4gWDg2X0ZFQVRVUkVf
Kiwgd2Ugc3RpbGwNCm5lZWQgdG8gcmVtb3ZlIHRoZSBmZWF0dXJlc2V0IGFwaSAocmVwbGFjZWQg
YnkgdGhlIGNwdSBwb2xpY3kNCmluZnJhc3RydWN0dXJlIGFuZCBsaWJ4ODYpIHRvIHJldGFpbiBt
aWdyYXRpb24gc2FmZXR5Lg0KDQo+DQo+PiAtLS0gYS94ZW4vdG9vbHMvZ2VuLWNwdWlkLnB5DQo+
PiArKysgYi94ZW4vdG9vbHMvZ2VuLWNwdWlkLnB5DQo+PiBAQCAtMjk3LDYgKzI5NywxOSBAQCBk
ZWYgY3J1bmNoX251bWJlcnMoc3RhdGUpOg0KPj4gICAgICAgICAgUlRNOiBbVFNYTERUUktdLA0K
Pj4gICAgICB9DQo+PiAgDQo+PiArICAgICMNCj4+ICsgICAgIyBQc2V1ZG8gZmVhdHVyZSBuYW1l
cy4gIFRoZXNlIGRvbid0IG1hcCB0byBhIGZlYXR1cmUgYml0LCBidXQgYXJlDQo+PiArICAgICMg
aW5zZXJ0ZWQgaW50byB0aGUgdmFsdWVzIGRpY3Rpb25hcnkgc28gdGhleSBjYW4gYmUgcGFyc2Vk
IGFuZCBoYW5kbGVkDQo+PiArICAgICMgc3BlY2lhbGx5DQo+PiArICAgICMNCj4+ICsgICAgcHNl
ZHVvX25hbWVzID0gKA0KPj4gKyAgICApDQo+PiArDQo+PiArICAgIGZvciBuIGluIHBzZWR1b19u
YW1lczoNCj4+ICsgICAgICAgIGlmIG4gaW4gc3RhdGUudmFsdWVzOg0KPj4gKyAgICAgICAgICAg
IHJhaXNlIEZhaWwoIlBzZWR1byBmZWF0dXJlIG5hbWUgJXMgYWxpYXNlcyByZWFsIGZlYXR1cmUi
ICUgKG4sICkpDQo+PiArICAgICAgICBzdGF0ZS52YWx1ZXNbbl0gPSAweGZmZmZmZmZmDQo+IFRo
cm91Z2hvdXQgdGhpcyBodW5rOiBzL3BzZWR1by9wc2V1ZG8vZy4NCg0KT29wcywgeWVzLsKgIFdp
bGwgZml4Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 12:59:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 12:59:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416164.660806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3zl-0006nz-Qx; Wed, 05 Oct 2022 12:59:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416164.660806; Wed, 05 Oct 2022 12:59:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og3zl-0006ns-Mx; Wed, 05 Oct 2022 12:59:29 +0000
Received: by outflank-mailman (input) for mailman id 416164;
 Wed, 05 Oct 2022 12:59:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og3zk-0006CE-2T
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 12:59:28 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8aebb626-44ad-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 14:59:27 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A62791F88E;
 Wed,  5 Oct 2022 12:59:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8DF6113ABD;
 Wed,  5 Oct 2022 12:59:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8Z9TIa5/PWN0eQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 12:59:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8aebb626-44ad-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664974766; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=IH8KcuhuxOFWK8XhK7MbuIPgRbsAZ/vs6n+Ey0LATz0=;
	b=k/Ss1srB0873V8alY1t41iFq5uXEsMzixiGbAZnM9TYQAriEOVrtoNhGqyuX256fSZ8lfl
	lNC1nTYXWvGnbOh+8VpSGOiOck+gbsOPWpxWC8KA+AL8JhQAmz2Jn4lUiD5GNh+hCQgFXi
	N9lDuN9VgC5ZWnfNjSETzjBGzc5U3js=
Message-ID: <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>
Date: Wed, 5 Oct 2022 14:57:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel <xen-devel@lists.xenproject.org>
References: <Yz17cLIb1V0zjEjK@mail-itl>
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <Yz17cLIb1V0zjEjK@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------khWIfZoQsuKs7zDfK8H7B6NR"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------khWIfZoQsuKs7zDfK8H7B6NR
Content-Type: multipart/mixed; boundary="------------FCe4f0wCep9o8c8i6vL5xHaZ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
References: <Yz17cLIb1V0zjEjK@mail-itl>
In-Reply-To: <Yz17cLIb1V0zjEjK@mail-itl>

--------------FCe4f0wCep9o8c8i6vL5xHaZ
Content-Type: multipart/mixed; boundary="------------HQ71QzRpj7eYhrQRM9R10n8i"

--------------HQ71QzRpj7eYhrQRM9R10n8i
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTQ6NDEsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gSGksDQo+IA0KPiBXaGVuIGJvb3RpbmcgWGVuIHdpdGggTGludXggZG9tMCBuZXN0ZWQg
dW5kZXIgS1ZNLA0KPiBDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVD15IG1ha2VzIGl0
IHVuYWJsZSB0byB1c2UgdmlydGlvIGRldmljZXMNCj4gcHJvdmlkZWQgYnkgTDAgaHlwZXJ2
aXNvciAoS1ZNIHdpdGggcWVtdSkuIFdpdGggUFYgZG9tMCwgZ3JhbnRzIGFyZQ0KPiByZXF1
aXJlZCBmb3IgdmlydGlvIGV2ZW4gaWYganVzdCBDT05GSUdfWEVOX1ZJUlRJTyBpcyBlbmFi
bGVkLg0KPiANCj4gVGhpcyBpcyBwcm9iYWJseSB1bmNvbW1vbiBjb3JuZXIgY2FzZSwgYnV0
IG9uZSB0aGF0IGhhcyBiaXR0ZW4gbWUgaW4gbXkNCj4gQ0kgc2V0dXAuLi4gSSB0aGluayBY
ZW4gc2hvdWxkIHNldCBzbWFydGVyDQo+IHZpcnRpb19yZXF1aXJlX3Jlc3RyaWN0ZWRfbWVt
X2FjYygpLCB0aGF0IGVuZm9yY2VzIGl0IG9ubHkgZm9yIGRldmljZXMNCj4gcmVhbGx5IHBy
b3ZpZGVkIGJ5IGFub3RoZXIgWGVuIFZNIChub3QgYnkgdGhlICJvdXRlciBob3N0IiksIGJ1
dCBJJ20gbm90DQo+IHN1cmUgaG93IHRoYXQgY291bGQgYmUgZG9uZS4gQW55IGlkZWFzPw0K
PiANCg0KSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGFkZCBhIGJvb3QgcGFyYW1ldGVyIGZv
ciB0aGF0IHB1cnBvc2UuIFVzaW5nIGl0DQp3b3VsZCBvcGVuIGEgc2VjdXJpdHkgaG9sZSwg
dGhvdWdoIChiYXNpY2FsbHkgbGlrZSBhbGwgUENJIHBhc3N0aHJvdWdoIHRvDQpQViBndWVz
dHMpLg0KDQoNCkp1ZXJnZW4NCg==
--------------HQ71QzRpj7eYhrQRM9R10n8i
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------HQ71QzRpj7eYhrQRM9R10n8i--

--------------FCe4f0wCep9o8c8i6vL5xHaZ--

--------------khWIfZoQsuKs7zDfK8H7B6NR
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM9fx0FAwAAAAAACgkQsN6d1ii/Ey9u
Ugf/TCR4t4JC14gNFymIvLp6gq41CclVPvtHxgT0RUYFitOYjOvURxRNjYSIhT9lrkIF1wric5Fr
biAoV21Z18f9R6nwNaV3p4nLW3/aKcK93UBTQUmLds1nyj4QKrubG9RNMQ5fbnoIe3nq21ogGfRv
Baax+sPjKShWgxJtI4v71LGG+vQwnoXZg26bGN0Ifl1uQh3EV9eechypDSwg9n6WuSOJR2bK9km/
skNhF23kAwTXtoAjNsjI0KvwrkudZRCFNvROFcQtol8QwRoWVJmewHqI9ek84CIuFtrT5EJnWev/
SHqPlmdzhU8tcCdq501G32PRek6gc/Qm5mD99qp35w==
=DIDJ
-----END PGP SIGNATURE-----

--------------khWIfZoQsuKs7zDfK8H7B6NR--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:11:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:11:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416174.660817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4BA-0000kL-R4; Wed, 05 Oct 2022 13:11:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416174.660817; Wed, 05 Oct 2022 13:11:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4BA-0000kE-OQ; Wed, 05 Oct 2022 13:11:16 +0000
Received: by outflank-mailman (input) for mailman id 416174;
 Wed, 05 Oct 2022 13:11:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og4B9-0000k8-52
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:11:15 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70052.outbound.protection.outlook.com [40.107.7.52])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 302a64b9-44af-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 15:11:13 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7396.eurprd04.prod.outlook.com (2603:10a6:20b:1da::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Wed, 5 Oct
 2022 13:11:12 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 13:11:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 302a64b9-44af-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aUpW5/boUP9FgkrlT8fuQMcrTLqpEtorOCMjMXK7UiZBfEZwkOTOjD/KoHhRqP70y9iF+AP1oBh1eZPjCvfwNKAfpFYEl+8tDwTDUolTmlTjQjgLD7ZegDEkOD64QDuUrJunpKgvCk8YZWiRCyw4U5lqcp5HoVULZZa/Jf9Nw2CYspcxFq1ivHQqcJj208Y6tOTURfEfKbA8zmd9+ysaKOYFDfPKMASMLr4GWt563UqK2XvWSmkgmDXAWzPx1jiw5GHIQU6gMZ/Mjus9WGimOzIJYpRQs321R6oL61hDzJoosU1MYM7pXOK7glYAu0pwbvDcCZnTB/3osWN5PGmU7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9S3L1ME6oQ7xAf2QeMd4hnxdZC/PG4RsY/PeNf2WK8A=;
 b=nd3VLgGlcEq631XqDruGJAwNFZnTqSfoYGK1yLvWhCbQ/PjQ36znMzbrogqHXWHXzby3AFO/aOvAPOMFlWDbs7nXJ72ULh1QQYGam+bA2Dah5J1WtIXcgxJrPEhV7MAfpT+1tbhny6rXpOIBdULnW16du7gP2dg0UeEa0RiN3p1ytQhHApr4RvE8+6ml9fK3TE0IGx4UBBYYIOM5XLlugPY9fF1dJkOdMY/1p8J4N7tzz0WHIGyj80XP+72ce5Sw6QkSAPmz8gfVsqiroKtaN+zr2yDaVyDiamLNlJssgJxuydYWuJY1kDL5Gh6RFbtYN0Jn0Xpj0G9cP7QDLkrTXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9S3L1ME6oQ7xAf2QeMd4hnxdZC/PG4RsY/PeNf2WK8A=;
 b=v9xFMOVZ7dBDn59EUxTa+sFHJ5J/HGKvtUw2XA8NX9yJrts82GsJp9KfXvzVjT1Zv69E5DCw5tnENHov4VqQL9b821OGdYXsfcpn6jOVoPhvmMoXs6KAu/UnE6o1wSM2qxm8OipM0Oxyy+mVOsn7Vjh0kfM+V+XZm/uY4Dc9LT45up4XgOwQypZ8suPW/Up+9qU4HZ8QqjjxN3tFOUlQwFzYyJmihiJ73rKo0WjHfwr678yeryCvwggEwxWad3Tm7Rqdfh5F7MTO666zouHJNrhVe/Y03bnjsjCm7JrHVjWU3YN7CYfHsvLymTwXsrBxsUAKruYilfLoDRAFHpa5WA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e8142d80-217d-7053-1bae-cd7abff17b78@suse.com>
Date: Wed, 5 Oct 2022 15:11:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
 <50324b35-5b75-18b6-6ee7-fbe9b5f5d662@suse.com>
 <ccd05cfe-1f77-5bd3-996b-bfcaf2ae30f8@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ccd05cfe-1f77-5bd3-996b-bfcaf2ae30f8@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0015.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7396:EE_
X-MS-Office365-Filtering-Correlation-Id: eab3c5cd-3d95-4c05-a9be-08daa6d3134a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lXKNL0Gcq5TN8l0axZp7uJ3+yvBShatp6BoeRJkuSjvyfmjR8SI96tERcjg7xEDqoK5EHlKo4p7m7wWg5F4jseoLrsscesfoZ2Zbrdrwe5pmf7eSjjptYDI/Y4aEgMd90/W/p6Rx8DgL1Xut6khEZugEl1Xk6qpukbfzMOngqwO6nK18NRSNgeUCcnRCp43AUUBPABPeA5c1JQIFEYMZzTHC1KmXlVbPMYwVurhOmz/Aq/bNbNWo+0rohsG8yBXb8Lko+csjsIKEmJ3QPLytRJIvkpFWhBRR55j6vvXWkL1y1kDbqS3/KLry5obVnkaGtvTRuawcp1lNsdgXFMtQyA7suOA5GR8wu2Q6Vl8YsQAjtxBydfMWZV0L99YfaAT9Pizve2CuDuwdYv+AWXYizaEYKdlxHdV2tFfC6YJEu3VqDpAJ4M7I/gdMg2b0yV8VoZwlR2ePUUb31k4ZXkv/Gn9vYh9swJj7kmXRUAgSUzA3h3YYHnGdoqMmF4FQc70UDUsfywm+8yZLjCsawn6SViOu3FIbMKtvkqBzHG5MvMj3135bk0zPUMBJpHUpwuLXqRJ8giwSqdxfemu3R6rBrzbFj/MDX9SGiKwoJdN1pQtdJKKDlxM+9JgOuUC9MJHXY9VjG5MbfTAIrH2BL3q50B4G1E54Dt+OtATnSpfGNFbJ9czZKk+0bH5t257WN3n8fXCY/mf9btgnISPZUXN346vlNEH15IvhhkT0JMgZS0KACzmcMhIpdGLYE1+YMNin1DY9Se5rVEKhWzR4eJkBb2oJ9dg52Zrnskqhh1GrTqA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199015)(4326008)(6512007)(6506007)(26005)(2616005)(186003)(478600001)(53546011)(6486002)(2906002)(5660300002)(316002)(36756003)(54906003)(8676002)(6916009)(8936002)(66556008)(66476007)(41300700001)(38100700002)(66946007)(31686004)(83380400001)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cWY0M0trMEwrVE05ZCswTFpxVmlQdkJIa2V6U1p6d1VhMnZQdXNlV2NwQnRQ?=
 =?utf-8?B?ZVZPd3hpRGNUcEt0UHZ1bmZ2OG9TY0pKTVVRSTFFTnNMODI2MHZQNzFBOTE2?=
 =?utf-8?B?c2RqbUNNQ09lelFaVTlFL3YzZ3ZXWng3TzJsYXNlUEFNTlRobU1SZmRLWTBx?=
 =?utf-8?B?a3hpN0lJMEc2L1hiZjNYKzhqT2kvVnFkdHZtRkZkUytmQzFvOUw2dUd5d2dB?=
 =?utf-8?B?ZnRGaEhXc1FJVjNVeml2VWJQT0loNWR3WmxtYzJ4TlpZWjlDaGJJWUpVZnV5?=
 =?utf-8?B?OE5MOGpjSkFaY2ppd3FLRTZuZE5ydDJFRm9FdVpKbjhBVmJaYThodmdKa1dv?=
 =?utf-8?B?VC9Kblp5bEl3aStJWmpUZkdlYXRIMTRDSTdkbkZyK2Q5L0dQWUN2c21qbDVx?=
 =?utf-8?B?VkQrK1d4R3ZDVDZkOUwxR282M0k0Mzk5RVFpNWQ1emNlbjc3V1RlS1ZwN2R6?=
 =?utf-8?B?eUUvSEQvYlMvRkhaMjJMMUJPOUdxc3MxcTNUcmNLRWJnTmJmb2RXRURQSndP?=
 =?utf-8?B?b2Ivb2R2VUl4UEpPYVRNWFd6eTBkS282RWRQWGs0L2V5K01FZGpib3lrVWJa?=
 =?utf-8?B?VEFOalBKam9PWWFPb2JHYUs5MGg5emc2OEhZUHUrSmZoLzlLbjN3TEdNNjlt?=
 =?utf-8?B?Vm1iQ25Zak92YmNTOWF0NUJ1TEo1aTZ6aktXTFJQRWNxbHFSQnBzZzBoaUpH?=
 =?utf-8?B?ZEdoazQvN2tub1ltb1NDOC8xa2NEYThCWHgyOFczZDZQQncrK2RXYkM2djdr?=
 =?utf-8?B?cmU1OVpPVXIwZ2s0KzVHa3luQW83RS9USzdaYzhWazk4bU1mbDIzNDRxS3FO?=
 =?utf-8?B?bmRpc1BmdS9NNElCZTdPSUIwNmJwVGZmYk1tdllHV2xxMVh6Nm1zcTJkbW1D?=
 =?utf-8?B?SVlNUVJJSEptdWpMVjhQVEZFYkxYZTV1K3FOMGp5cTJSa0xWcW5vZnV1Rlhq?=
 =?utf-8?B?ZVl0Y1NYZDRZM1lEVk1JTW1sN3N0aFQvODlGcTJ0cllWRUVBYnZucThGV2k3?=
 =?utf-8?B?eWVMdjVuSkVhVlFybG5icGFOZ29NdGllb1RuS1VZUmUrTTY0Uk9ZQTFGTkly?=
 =?utf-8?B?N1NhSGgxb2RQVlQvVnFSZDVtVERzYTJrSlJVV2llTU1CU0JJQzQ5Zlp5dE9N?=
 =?utf-8?B?NEhCM2d2YXJhWlZ2OGpKaUZmblcyS1VYUXhjczFYTUZ0VTFYZ3dqWkIzbXhw?=
 =?utf-8?B?WTR4ZE4zZkpMVnE3TDhtKzIrY2tMZzJWSlU3b2doeThheExGMUtFa2ZTNFdZ?=
 =?utf-8?B?Ymp1TEtWU00xNFUrQnF1cUZGQVVnSEJLU2ZrUnU3b0JTTGV2cHdRWXRMQVlR?=
 =?utf-8?B?UWZOODlvVDQzdncwczVHWHYyU2t3aU9iajNGdjdNdlRwVUpVSHROcVJ0T0Fa?=
 =?utf-8?B?ekUrVGtXSmgvazU0blFTY21pR2tpTzgwaGo4SExQR3BoazIvVkljZ2NlMkFG?=
 =?utf-8?B?UnFIWUIwcUxLTjlmSXBPRC9HZXBRQm1JS08zMXMvbWtoMjlqVGJSR1ptL09C?=
 =?utf-8?B?bHZQWTNRTGY1eHl5czZpZXJ5WWlYMVRtZUNaMDRsV2cwOGpndzRqSkhyMWow?=
 =?utf-8?B?dHNPK0dWRHdubnVuTFBYdDM2cmlEUm9GZFFtR3Q5S1RObS9wWC9qZ2kwaG1r?=
 =?utf-8?B?SktsaVVMb2Jqa0hJeEYzWjRYRWhnd2ZrYkhCQTIza1dlR2FXNHRJdEd2VlFt?=
 =?utf-8?B?Y25GYXl6b3dQVDRONFlYZU1sZ1pIR29QZFRvc09weFp5b1BFUysrOE5JR2Uw?=
 =?utf-8?B?S2kwTCs2czJmNEtxTS9PSVA3VytWemplVnIwaklNbi9hMGRIMi9mYUFnWThF?=
 =?utf-8?B?Wm93cm05Qy9Nb1I3Z1JQbDZqT3Q4NkNlMG9SbG9ObHRHWDg1WXMzMmNwbVFV?=
 =?utf-8?B?WFJYZkRkTmxXUkdnYVVZVUpSbG9XaUhjVFVEL1JrQjNJTkM3SlNTSFZrQzM1?=
 =?utf-8?B?ZGNUQ2ExZ2YzTUhwaExvWDJDeTd6VFVXU2FaRFAxbThEQ0xxRkNQajhhLzY3?=
 =?utf-8?B?bjA1eHA1ZlhGODM1L0pJa0UxZ202Rm5JMGJqNUNFNitHRnh5VGplYnJ6d3Mr?=
 =?utf-8?B?ZVhLN2hORE1wRXVUelgyRUROZ0Zhck52cWdFOTZXVVkxU2EvT216ZHpGR3dQ?=
 =?utf-8?Q?SnGSlYoaLBhPnFSY2nSUiq3s6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eab3c5cd-3d95-4c05-a9be-08daa6d3134a
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 13:11:11.9566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IN/Zvfutm66nsvZRbcL2hH6JHbWvpMnG+dTeVpUBrZ5eQO3lk+N87UvkLfxJCJZgjCC5kMv0Y0g89XIwPUR5WQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7396

On 05.10.2022 14:58, Andrew Cooper wrote:
> On 05/10/2022 07:59, Jan Beulich wrote:
>> On 04.10.2022 18:08, Andrew Cooper wrote:
>>> A future change will want a cpuid-like identifier which doesn't have a mapping
>>> to a feature bit.
>>>
>>>  * Pass the feature name into the parse callback.
>>>  * Exclude a feature value of ~0u from falling into the general set/clear bit
>>>    paths.
>>>  * In gen-cpuid.py, insert a placeholder to collect all the pseudo feature
>>>    names.
>> Hmm, I was envisioning this to be fitted into the existing model in a
>> less adhoc way: (parts of) MSRs holding feature bits aren't very different
>> from individual (pairs of) registers of CPUID output (in the case of
>> ARCH_CAPS there would be a perhaps just abstract mask limiting things to
>> the subset of bits which actually act as feature indicators). Hence I'd
>> have expected them to gain proper entries in the public interface
>> (cpufeatureset.h) and then be represented / processed the same way in
>> featuresets and policies. All that would be left out at this point would
>> be the exposing of the bit to guests (in patch 2, assuming the split into
>> two patches is then actually still warranted), integration into
>> guest_rdmsr(), and at least some of the tool stack side (xen-cpuid, for
>> example, could easily learn of such right away).
>>
>> However, since I'm pretty sure you've considered such an approach, I guess
>> I might be overlooking some caveat?
> 
> I have on multiple occasions considered putting MSR_ARCH_CAPS into the
> existing X86_FEATURE_* infrastructure.  In the future, it's likely the
> right course of action to take.
> 
> However, doing so now will break speculation safety for guests in some

Considering further text - s/speculation/migration/, I guess?

> cases.  The featureset API intended to be safe to treat as a regular
> bitmap, and this is how it is used in practice.
> 
> Honestly, I didn't imagine that we'd get bits like RSBA and RRSBA that
> need to be treated with opposite polarity to be levelled safely.
> 
> Even if we do end up putting MSR_ARCH_CAPS in X86_FEATURE_*, we still
> need to remove the featureset api (replaced by the cpu policy
> infrastructure and libx86) to retain migration safety.

Well, I didn't mean to suggest to put all of the feature-like bits there
right away. Just the one bit we're after would do for now. Afaict that
wouldn't affect migration safety, while it would allow doing things in
Xen in a more "natural" way.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:25:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:25:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416197.660836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4P7-0002QO-6S; Wed, 05 Oct 2022 13:25:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416197.660836; Wed, 05 Oct 2022 13:25:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4P7-0002QH-3E; Wed, 05 Oct 2022 13:25:41 +0000
Received: by outflank-mailman (input) for mailman id 416197;
 Wed, 05 Oct 2022 13:25:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og4P5-0002Q7-FG; Wed, 05 Oct 2022 13:25:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og4P5-0000UU-DP; Wed, 05 Oct 2022 13:25:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og4P5-0003xK-3x; Wed, 05 Oct 2022 13:25:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1og4P5-0008V4-2q; Wed, 05 Oct 2022 13:25:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YBY3cRT5UH3/iHHPTPXb9P0Kyrf0g+pbwRL13+4ynzE=; b=DoEd3ddFTGK0X4qvR+UOG4MW5O
	uwhuHkphj8vwZubFd4QBO9x2uKi3PE/oIizz0G4+xa9iUUurU6Jvg4FFBYMHLa30rJ0NKvRCJiUuY
	w1QSCTsyj8jgLsV/cp7Ins9yZ5TsYvn+VLxVrsnI2fYRZqXXKZJh9p/KbQAeFg62A2ls=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173428-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173428: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=66a5633aa038f4abb4455463755974febac69034
X-Osstest-Versions-That:
    xen=3161231abcb461314b205337fbd0530c7ead1696
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 13:25:39 +0000

flight 173428 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173428/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  66a5633aa038f4abb4455463755974febac69034
baseline version:
 xen                  3161231abcb461314b205337fbd0530c7ead1696

Last test of basis   173410  2022-10-04 01:01:52 Z    1 days
Testing same since   173428  2022-10-05 09:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   3161231abc..66a5633aa0  66a5633aa038f4abb4455463755974febac69034 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:25:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:25:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416201.660847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4PP-0002pT-H4; Wed, 05 Oct 2022 13:25:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416201.660847; Wed, 05 Oct 2022 13:25:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4PP-0002pJ-D8; Wed, 05 Oct 2022 13:25:59 +0000
Received: by outflank-mailman (input) for mailman id 416201;
 Wed, 05 Oct 2022 13:25:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xhym=2G=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1og4PN-0002mG-Th
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:25:57 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d60c191-44b1-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 15:25:56 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 3A19032007CF;
 Wed,  5 Oct 2022 09:25:53 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 05 Oct 2022 09:25:53 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 09:25:51 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d60c191-44b1-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664976352; x=
	1665062752; bh=fkD7L0kZuKdkAcCLODdB9q5NBC/87MZVa88KNbOhNTM=; b=V
	iZ0QH8BKhaAz33EqIZq+/q6UFVzWi3j9MgJ0uevkEhvs3Om1WePNaFyDaR4qNR91
	TvkGij9Mi28vg8Cd92qtZKgxhNJrECUEoAGuSWigK59ile99mgOlL62VXZtefcED
	VZfhNie563hhG8e052ZMiFm7KHPQR0/bwdhZaehZepzStUiIgUz+4Ze95QJ81YvK
	0EnFLq27TKTfTySKBnyxs7wCwXzX2BkCbKW7crdaNTR4FVAcEcda+0M/n9azmP5Q
	MrXeCAbtxydqD99s0JUnBYRBu0oeu5IgpHPMRszzesaVb0Y4NpWd9sRzGYsDnh/E
	7n4dzjnnCPxC466dyfUmA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664976352; x=1665062752; bh=fkD7L0kZuKdkAcCLODdB9q5NBC/8
	7MZVa88KNbOhNTM=; b=igvNpLelUKWwXm1cd+Sy+fq4UqAsUcCUDSnzRqXP9LyN
	2RRo0OtxHDG7gYzcpiv9Nwf3IMXCkmRqP3rWzsYTvpEF+flAb/kn9RBskTe2eZIg
	mTihOb8+oVkD25yhVsQfIF7D/Ch/+vWabp4XGM7/tlB4iSup3q+X2OCGzn+v8Oc4
	lYQpUSxRAxa3lOEu+1nZJiiwTLK98vUR+lnuH94r8rM/7XHjWHgPjSIqziHcHfay
	ZaWVMTEYmSA5SuynXs7caUFpUhha3HE4RZ36yoJVCn01Pt04P4dCVnzg58hZyhO0
	cV8cCL2klQZXtSX7SbTMIURCFWO42V5XVnGiSv5ciA==
X-ME-Sender: <xms:4IU9Y4ZdOB-JLKzCkbLx7i5SE8O_PShtgTv6O3kXn0qD7ja170ezmg>
    <xme:4IU9YzZShKK6LePaK3y7xm3Soua0N-hZ9fDPt-Aw1v1r2P_EIJjoKIYatW1bcv0OZ
    KBbleTc1lnP6g>
X-ME-Received: <xmr:4IU9Yy_dW6kybO-HOUFz5GCzLZ-c4-mS393mZ3t8TgMIWSvl-osPExu1spKzRZaoYOBmMEtpLr21SjNsbCRTfPsrIjifSa88h8o1>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgieefucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:4IU9YyrTDJOF-C9mH3JghfyaE-vKqIzEdDMnydKZfXxk7gjA_AQntQ>
    <xmx:4IU9YzppKXVTC8qkuCKT9pKUMEBeFyPgyPyo7HIKYO1nUNFfxg2GjA>
    <xmx:4IU9YwSGiuWv_4gVNdJmt98zH_uv0L36Ku2Pvkgjc0tOWeEADsmJFw>
    <xmx:4IU9Y9FVsP2WnnS7M1RJ5mdBQPdHkTY7lnMDcgBiqCPCWGdq6nKrEA>
Feedback-ID: i1568416f:Fastmail
Date: Wed, 5 Oct 2022 15:25:48 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
Message-ID: <Yz2Fvp9Q9aeYKnDY@mail-itl>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="TTSDjBJgOWtr2mfJ"
Content-Disposition: inline
In-Reply-To: <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>


--TTSDjBJgOWtr2mfJ
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 15:25:48 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt

On Wed, Oct 05, 2022 at 02:57:01PM +0200, Juergen Gross wrote:
> On 05.10.22 14:41, Marek Marczykowski-G=C3=B3recki wrote:
> > Hi,
> >=20
> > When booting Xen with Linux dom0 nested under KVM,
> > CONFIG_XEN_VIRTIO_FORCE_GRANT=3Dy makes it unable to use virtio devices
> > provided by L0 hypervisor (KVM with qemu). With PV dom0, grants are
> > required for virtio even if just CONFIG_XEN_VIRTIO is enabled.
> >=20
> > This is probably uncommon corner case, but one that has bitten me in my
> > CI setup... I think Xen should set smarter
> > virtio_require_restricted_mem_acc(), that enforces it only for devices
> > really provided by another Xen VM (not by the "outer host"), but I'm not
> > sure how that could be done. Any ideas?
> >=20
>=20
> It should be possible to add a boot parameter for that purpose. Using it
> would open a security hole, though (basically like all PCI passthrough to
> PV guests).

What about excluding just dom0? At least currently, there is no way for
dom0 to see virtio devices provided by another Xen domU.

Something like this:
---8<---
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 9b1a58dda935..6ac32b0b3720 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -111,7 +111,7 @@ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc=
);
 static void __init xen_pv_init_platform(void)
 {
        /* PV guests can't operate virtio devices without grants. */
-       if (IS_ENABLED(CONFIG_XEN_VIRTIO))
+       if (IS_ENABLED(CONFIG_XEN_VIRTIO) && !xen_initial_domain())
                virtio_set_mem_acc_cb(virtio_require_restricted_mem_acc);
=20
        populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));
---8<---

This BTW raises also a question what will happen on Xen nested inside
Xen, when L0 will provide virtio devices to L1. Grants set by L1 dom0
wouldn't work on L0, no? Or maybe this is solved already for pv-shim
case?


--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--TTSDjBJgOWtr2mfJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM9hd0ACgkQ24/THMrX
1ywtRAf/SkYFs/nkrcu+PPDYVvlIqfH8L+wgGk5jehvMVHkMAPE+N02o0/xRiPwD
cy/+w+fFg/P2CF86KM5VUHFd/RIIxaasiQgh9JW8N438uKxgo2xnG3hQFeZHFnE6
rV3ezEaDldCktEVFHQ5v64N5anfSsRjxnicDHBJdFgnYIt1JwQqERIF3GPZbp8tX
vYEMSawShjtoluCwKSUyf9la7u4Ec6WA8yNlmuLGIuoJ9hKkqIQ9brbDwE8/dyoB
OgI60255Zkut0xR3tcv16DwIxGLAxjLoHavQt9UvWQ3da3qv88+FLB/RT82pxT96
i9BnKvpFedCqaGwbJ7E8dYs4xHaxZw==
=WiQN
-----END PGP SIGNATURE-----

--TTSDjBJgOWtr2mfJ--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:31:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:31:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416217.660857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4V0-0004Tr-8I; Wed, 05 Oct 2022 13:31:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416217.660857; Wed, 05 Oct 2022 13:31:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4V0-0004Tk-5i; Wed, 05 Oct 2022 13:31:46 +0000
Received: by outflank-mailman (input) for mailman id 416217;
 Wed, 05 Oct 2022 13:31:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iqu=2G=citrix.com=prvs=270658c04=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1og4Uy-0004Td-Kc
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:31:44 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0bc5e64a-44b2-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 15:31:42 +0200 (CEST)
Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 09:31:39 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5312.namprd03.prod.outlook.com (2603:10b6:208:1e9::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct
 2022 13:31:37 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Wed, 5 Oct 2022
 13:31:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0bc5e64a-44b2-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664976703;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=86JnqBAzAn4eW6aJyozuZfmFs4Yl2qTIJGdbe44vE9k=;
  b=gzHBNCzAWYdsCjljhf6FLrOAuDsupZT2g3HKGQnGrRPXiyl3UHhqikqE
   n70o6pz/kDcF6C0UtDAY67ALMCO1BYVSZWEJVFr5y3mS+b0rRzxr+gwQb
   0OFAxrQOtIL8bSAqM4mcGrWH0xXIQwR59UYJ9DuDkFcQCiSgR4yTImSww
   8=;
X-IronPort-RemoteIP: 104.47.57.170
X-IronPort-MID: 82014715
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:D8p1kqvwlddzdSpOJHASf630BOfnVKZfMUV32f8akzHdYApBsoF/q
 tZmKWyHOP6DZTbzKI13a4+08EpSuZXcmNNlHAdkpSBgRSpG+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPagW5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkl21
 twJdj1Sciqjnt+t6piWV9lyhMk8eZyD0IM34hmMzBn/JNN/GNXvZvuP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWMilUuiNABM/KMEjCObexTklyVu
 STt+GPhDwtBHNee1SCE4jSngeqncSbTCNhKTeHnr6MCbFu7ykkJWUYyBFGHu6O3kEm1f/1GL
 UE59X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRUciaCkeXE066t/siIgpi1TESdMLOKu8lNj8Azzz6
 zGMsiklhr8XgNIL1qO05lTOiXSnoZ2hZgI44wT/X2S77xh4boqoe4yp71fA6f9Kao2eSzG8U
 GMsnsGf6KUCCM+LnSnUGeEVRuj2v7CCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC
 KPOhT5sCFZoFCPCRcdKj0iZUqzGEYCI+QzZa83p
IronPort-HdrOrdr: A9a23:2nN5XK6yFVifFTtGJwPXwDLXdLJyesId70hD6qkQc3FomwKj9/
 xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5
 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd
 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU=
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="82014715"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZdkLL3eoupd+JjPUgGvBKDH9+1H5/xkfXd9Oor2NIBZZcR7SWo3JDcwyiLE0x+jDtgWsCbVHkqf3Izx/jvQSsf/o87/huQNEJEQpZt5h4XxsRawArBacYBnb8Nf/GRRZodjelANVFpIBOHfQwV8MC+v+Lvn8FvSvm3VYXEBWG+P7QcFviIbH50Azp5RIHk9ijahHr4vbHo75dZNTMTx7AjvI8Vfl2Suf75hm3p+u+/6hvwOcFe5k69Krswv9jD3v9cDIr2K/ioxS4KhzQa7lx1HvrKoOuDZVcOFe7LnuDpkWBSvkt80Qf9E9V7m4KmFr2ZhrBf0He6mBBDcuskXAJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=86JnqBAzAn4eW6aJyozuZfmFs4Yl2qTIJGdbe44vE9k=;
 b=n8LZytumBRhZCO9CT/z2f3bFc7bZnyCuM6KDkQIYNHzkGhAaLsuOliM+E+iLDxL80T7d0kMSGkBgYf7TvwtJ/vMls55RyPlZJv/ducwF+f/XV33h09kHMNWxXIeGASy2WTf9XiR1GdogoYblfHWbJQfgaCwiZC9lLvH5kdGaJNj7LdY9zu+y05tDuulFZKjLdUjcVtHN/7TDYOeZ7c57hzm0JTc48W2Jn3khwKM45Wf/KtyLC5AAKTNqVrVA+QOP0pIS3nqvO/e825hQY4bDZalJumyi6bqLCLcwbV6V9eeMnisUJS3s4gfTMp3ACH4Dk6X3tYiZHcfSSjukRXuSgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=86JnqBAzAn4eW6aJyozuZfmFs4Yl2qTIJGdbe44vE9k=;
 b=UepISAQTiH5lfgo7oYAPKpFah8AxbAha407v3kQum0ZJb6F4Uh8Zyrb+eNpWZ4XhhmdBwnvLO0hOt70IHHn7aj0rZb7MnWM62e0SLbLIv/oWC9QRtTA1lj3QaaDDU4Np98Ox3rkhfpr6vyXjtqjyxVQ+ItxnbiimWbZ3HwK2ooM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Henry
 Wang <Henry.Wang@arm.com>, =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>
Subject: Re: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by
 default
Thread-Topic: [PATCH 2/2] x86: Activate Data Operand Invariant Timing Mode by
 default
Thread-Index: AQHY2AuYv4kI/POqCU+FUM3MxB3Uxa3/mA0AgAAei4CAABbmgA==
Date: Wed, 5 Oct 2022 13:31:37 +0000
Message-ID: <d986df42-f50d-2ab6-14b7-3ab17dc6e774@citrix.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-3-andrew.cooper3@citrix.com>
 <Yz1aZJx5AZae/2U5@Air-de-Roger>
 <272c62a7-798b-1b00-0a4a-1eb18f480798@suse.com>
In-Reply-To: <272c62a7-798b-1b00-0a4a-1eb18f480798@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5312:EE_
x-ms-office365-filtering-correlation-id: 4b613e98-d941-420e-4f1b-08daa6d5edcc
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 7KIciIkEJRogemEZDIVOvg4C1u8NX/+iGSRy/FFvf3NrXfgmM5sOD08+60mqEmIciR6XfooGPS24wnwo0+wb0JBVvee9AO+IsVmWVtKZu9O9a6I5Vel2JfONUU2B8j0Tf65Dlge+Pf8YWMIdLJp67MEB0N2s1cSUjp77s3y7uCp/itiLXlXCX81kjKfMEw5uQQ7mVbyVbuaLhL9jmIhvfTsP8BxrEInfM6SR6Bcr71fjtWj94M7n9V8+nHrOLcz80i9JN1ohw0rMfvrszHixfHw5hsCKAKgQu93i4l+A0xJtevuo57nZOnQdTfofIJLm0Yx51ugSCX3o3+2cDTKcNY1HRkN4SSm/u1zNb7VJv/Mc6ta3W4rvs5Hs5CwgPFN1NAjIJhLpKkZGnwCncLFGUK6Atm5Jg3zMVfcNr1cQSWULW7fQgsq0ZMVYmoFD9VBzMM+2aoR+RMeA6ilRHTsJtLR8VSNtrKXk7UeYr2X+tDwqm0AiPvcZvfDMFI2Hndcr04qtBMR8wHdSxVQeiQ4Aew4elBTtwbtEyfSdBJFtRfgUgRxdaZVVZfwT4J3wv0A/sRysdiTSA2YAPaCd/xjLP2bchR57e+6En3JL3es0X8izJFyW4mES4len0rskzTwPfuFHxZ5mQwr8gGUV2+YmfcM2xHxK66IViRi++EVy39eEXVorTi4bKAdd8FQMh0Udrne2Pi0B+ucFq8KIVXuw59OxXMBfNZtmxCNcL3+YL/FuL1OWT3DX9886z0ABI2vurSZkiavFWB58rtZsQXa/ehimrHlB1jef5NJYTbBkh2caHJJY8O8LJA7rb0jV0sUGlhSiugvQZs2PL6emJ2pyVQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199015)(6486002)(478600001)(8936002)(71200400001)(38070700005)(5660300002)(186003)(86362001)(82960400001)(6506007)(53546011)(36756003)(122000001)(2906002)(2616005)(31696002)(41300700001)(38100700002)(26005)(6512007)(31686004)(4326008)(66476007)(66556008)(8676002)(64756008)(66446008)(66946007)(6636002)(76116006)(91956017)(54906003)(316002)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?OFFuK21GbWJ2cElyejk3bDZDc2lKYkJiRHNIZ1MwRlRKSGZHNXhMRGd3Uzda?=
 =?utf-8?B?Z0IyMEwxeDEwaWJoMHU3dnNIZUhFS0ZSMEUwNDJMVHJhVXJLZWQ2ME1nYnhS?=
 =?utf-8?B?ZUhvUGpOQWVrejFEMmt2bUpheDJCWFFDUWt1Ny9kRy9VdWlkMW9ISm1Oc3N6?=
 =?utf-8?B?dGpDT0dEMUV4OWliSm9lclNSbzdWWkFzV2xEbUZZdXB1bU5WYXliT3NsbUE0?=
 =?utf-8?B?QlNFOHBRUWZaWkRTU3NiT051ZGpSRXlKOEt4cHBEZ2tTYXFUNEtvZXdKaGwx?=
 =?utf-8?B?S1o1YURONE5VQ0gya1RhbUJ5cTRabnNKOUFad0QrRy9BaDBJVGhiQjJFNitZ?=
 =?utf-8?B?czRMUXRoZ3BkT1VpVlNmSkdGSDFueVVKbldjTVdtd2ZITGhrdWVjSyt5OGVO?=
 =?utf-8?B?VE1kcEhKUTFmRHk1WHZxWTdneGtRMFhuM2tseWdjWHhNQTZQL3BlUTN2QWlU?=
 =?utf-8?B?YTNXWWRDZlJCbDg4YlI0emdxejJrU3NKaEx4WW1VNFFOVUlML1NsUytuUVJp?=
 =?utf-8?B?cXF1and0Uy9zOXUxVSt5VGMrKzhKUUtPUGQyenhkSnlPQWxjdC9QV3BaSlR4?=
 =?utf-8?B?MDFtTndUbU9PZFNidDhSd1JyTmFTeGprZlg1YXVRY1hrOWhna2hvbGNOWXYy?=
 =?utf-8?B?QVpNdkZrWXMvd2tPOUNRZ2xWRkZ1N0VSNUV5QXRUSzR6RlFXVExLc2R4MCta?=
 =?utf-8?B?TUdSbUp5VDQ1WE9KbGtRWm4rSnY0NEpZNjFOQjRueWFjai9PWlhBQ24rVFJH?=
 =?utf-8?B?TXlvWUlkTHByamFKaU42SUFza3ZBS1FRdEFlWVpJKzJUWmpMOG5TNk5UeWll?=
 =?utf-8?B?YktNY083WDJ1RzJRVWtDa0lZR2tzZXcwVFZYaUVtMzY4WnlPaGRVcm5iS2Ro?=
 =?utf-8?B?RUZOY1d3ZnFDajRMak02QkE3RmN1R1hMMVRRMTV6bXhNYlBlNzFsL0ROb2di?=
 =?utf-8?B?VmJEVWVEd3lJVWtyTHAvamtZM0ZjZGtVa096aVRHMTZYSk5sbURZTDNwSUFs?=
 =?utf-8?B?R1lrMzlsdXhBL09ETFl0TS92S2VoVmVQWjNMKy91R3l2dk4wL0RGSUpXaUZl?=
 =?utf-8?B?UnBXbkVMWW1vaHBFNFJORmM0TmEveUFjSC9keE05OS84QzcrMkt5SGdSSXZI?=
 =?utf-8?B?YXFTenVUV0RJd2tEdGVzS1NSMWswUHBsYXZ5eFRUVy8vNlBNSHpjVGYyR0Ru?=
 =?utf-8?B?VlNCMHVPSmk3ZmxzMWFyb21IbEpUdXp5eGxlNFY5L2cvWmRGRDBnWXBNM0p4?=
 =?utf-8?B?VjdmMWFmVXpJc1VSZW12eTh1MVlSNU5zaUQwc1RtQnBXbXYzU1pJSjRwTGxt?=
 =?utf-8?B?eUsyNnlVOFlDaXAxbG1RTmFBRzg3NEVlekN6MnJhYUkzZGVQRlppMkorNENV?=
 =?utf-8?B?UTlOWHVJSndQUXo1VUQwTlZ5VjZSMnJaNkNZa1Zna0NNZGpOY0ZvdTdqUXBS?=
 =?utf-8?B?ZTlFOStWV1cxeWtmZ0dsUVJRdVRnT1J2a1o3S1l0MmpEcnhIblRBUzNlNnVu?=
 =?utf-8?B?eCs5RE1rRGNFK3luNGNndzZjR1NrWk1YNTd6Y2pjNEJoZnVyY1hGNHA4dnZN?=
 =?utf-8?B?Z1pGcUt3b3ltNHZCUmZQUU16T0s2RUxsN3VWTTJMTVZhM1hqYkVsR3BKOFRF?=
 =?utf-8?B?cTB3K04wM08yOEl4bm9QYmh2N3JUaWNIQzhuaXRSdjlhMDFwYzAwRHgvQTVm?=
 =?utf-8?B?b2RXbWlGVlFoZU15SU1hNU1vclhHSFFveURVdEx1N1RVRzJ3UFVWZEJqNXZB?=
 =?utf-8?B?QkM5MjRIOWxHdi9ha29YcTAwTm14REsvMENZT2d3UThsNmZSUTVRdFU5emZM?=
 =?utf-8?B?WmxhTEZBcXk5S05HckN3ZFh0RXV3VWN2cXgranh4S3drNEF3b2R3dDNRTUNt?=
 =?utf-8?B?N0tBT1FQMi9VNXlhUzF4Z1c4WDJrSXVpV0JnMEtKQzdBMHFUdnpwcnFMYTE1?=
 =?utf-8?B?ZG9XcXo3MVJ2TVFCRW11c3d2TVNRY0lTekF2WHZhdENBZEcvTk1WMGhPKzEz?=
 =?utf-8?B?MWluZ1lmNS9zcGlqLzM4L0g0eU5idnhzZktIalRqTFNNWnhYckVsa0M2VDd5?=
 =?utf-8?B?ajh1NkY5MzFTNHpIaU9uWFBtUkFnVU5YLzRTMCtGQ01tSVRRUE50QkFNbUdO?=
 =?utf-8?B?bHM1UTFVd0pZL25NMkI5TE51U3RISmlzbVdkNDRYaGY1K1crdEJyL2pwQmxp?=
 =?utf-8?B?aFE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C22BA4B80373EE478235BFD10CCCA4B3@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?d3Z5L3hKSzE0dy9PellWeEhMQXpISngrYnAxRUZCc2FIWFBoeVNDQzBxYmVD?=
 =?utf-8?B?OWVsVXhlQXRJVnUzVXlZLzNHRGRFbVlTT2x5WU9VdU5STFlLVlBya2w1UjNU?=
 =?utf-8?B?dEUzWTNXcHlDTE1tMVVHUW9pd1dxbFk5VnhsWUJaU1JWeEF2d3pta1FuQlZ0?=
 =?utf-8?B?Q0FpMGtocmZoaXVEcFBOQ0FDR0N0bzhRb3h3RkcyOWhiR1B6SkY3SE1xdTNY?=
 =?utf-8?B?Q1JWTmt2WS9udDFmeHlsTTkxZldwK01yb1FjT3dCbEVjUXEyMklUdmIyYTIy?=
 =?utf-8?B?UEZNR25zSnhtamRPcUNQUDFBeS9rWmU0MzNpbTRZcGpGa1g4TkJtZ3FCcmNE?=
 =?utf-8?B?c1ZHQUVncmpGb2tSQm9ROVVxcm9zRXdHU0hxUG0rODYrczl5SGtDTGZQNFY2?=
 =?utf-8?B?N0NWTmVpMnYyMm9tTUMwSWJlVkwra1Q5dU54WHowSWw2MnFka1JTTTlVQVB1?=
 =?utf-8?B?WFIycVdtZDY5RDJQeXVIT0w0aWNlR0ZWelNYUXgrMmMvU3pvaWluNktvM3ds?=
 =?utf-8?B?OVZ5RHMveHpvN1djcHJaeUFxQ0NucW94anhzdTBNN1JibVB1NGtVRWFqRFF5?=
 =?utf-8?B?d3lXMTVQSmF3Ly8wRVpZVnVhTVVKTXEyNnk2SzRDWUloVWFhWWFMeDdXYXFD?=
 =?utf-8?B?ZGRWdnZvQ1NlTXNvVU5TbDBLNWM0QzB5bmRtWWhqLzJYT2tlTmZoSU9FeDkx?=
 =?utf-8?B?RlBTOGw0UHgrYW4zazdIUUpkTXV2aDRjQ1JydFFlakVqQ2RxZDViZHAzekRm?=
 =?utf-8?B?RUFIYlBXZXl4cDBGcittNEM4V05HUDlZVzRKUHBOdzBEc2t3U05YUy9qanV2?=
 =?utf-8?B?K1lPSFptODd2aS9UQ1ZjRU0yQXJxdTNCRVdSU3N0d3JGdU5Zak4vcjRTTFpk?=
 =?utf-8?B?MWNpQXZwN0JWcXVOSVpSd0U2RkZtVjIwUTl3SnVJMTQ2MDRUQWMvRHdSMEFN?=
 =?utf-8?B?TGtLOTUvN3E0TFdzVjJhV20wd1Z3RHViQzVxbU5TZVNndlNvdEQ0UTNEbW9i?=
 =?utf-8?B?dUlqY1VoZXJUcVBhbmdiZUdVZ0xOZDdEN0IwcVdtQVl0SkdZZGg5QnpuU2M1?=
 =?utf-8?B?MGR4ZU1CUElZODFWc3ExN1RWNkEzNWd1L3c1N2U1NWRvY3o4YUpmQnNhUVdh?=
 =?utf-8?B?ekwyWmR0TFhxWGhVVWtUTmhRTGRTVjJ3bzhHWjdaWU00VklPZmo2REg5aVVR?=
 =?utf-8?B?dC93WWx2Y1BudlZwdXVaaDhvbUl3UzRKNlJvdnZGYlN6MU1WU3FqQ3M5SDhT?=
 =?utf-8?B?eFVlM1RqTEVNMFpEWU8yV0MzZUthUm9ucXhLWURLWlFwSzByZz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b613e98-d941-420e-4f1b-08daa6d5edcc
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2022 13:31:37.3712
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kQdLldDeLjlnWWxW7l58zz7yyEBDAPxvrH691p6se8ZPwzxEgosAZm/fclRACjWhMUg9CKwQ5CnEDlQoH09MhQSQSbveoJi1HpwaXwU660I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5312

T24gMDUvMTAvMjAyMiAxMzowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA1LjEwLjIwMjIg
MTI6MjAsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+PiBPbiBUdWUsIE9jdCAwNCwgMjAyMiBh
dCAwNTowODoxMFBNICswMTAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4+IC0tLSBhL3hlbi9h
cmNoL3g4Ni9jcHUvY29tbW9uLmMNCj4+PiArKysgYi94ZW4vYXJjaC94ODYvY3B1L2NvbW1vbi5j
DQo+Pj4gQEAgLTIwOSw2ICsyMDksMzQgQEAgdm9pZCBjdHh0X3N3aXRjaF9sZXZlbGxpbmcoY29u
c3Qgc3RydWN0IHZjcHUgKm5leHQpDQo+Pj4gIAkJYWx0ZXJuYXRpdmVfdmNhbGwoY3R4dF9zd2l0
Y2hfbWFza2luZywgbmV4dCk7DQo+Pj4gIH0NCj4+PiAgDQo+Pj4gK2Jvb2wgX19yb19hZnRlcl9p
bml0IG9wdF9kb2l0bSA9IHRydWU7DQo+Pj4gKw0KPj4+ICtzdGF0aWMgdm9pZCBkb2l0bV9pbml0
KHZvaWQpDQo+Pj4gK3sNCj4+PiArICAgIHVpbnQ2NF90IHZhbDsNCj4+PiArDQo+Pj4gKyAgICBp
ZiAoICFvcHRfZG9pdG0gfHwgIWNwdV9oYXNfYXJjaF9jYXBzICkNCj4+PiArICAgICAgICByZXR1
cm47DQo+Pj4gKw0KPj4+ICsgICAgcmRtc3JsKE1TUl9BUkNIX0NBUEFCSUxJVElFUywgdmFsKTsN
Cj4+PiArICAgIGlmICggISh2YWwgJiBBUkNIX0NBUFNfRE9JVE0pICkNCj4+PiArICAgICAgICBy
ZXR1cm47DQo+Pj4gKw0KPj4+ICsgICAgLyoNCj4+PiArICAgICAqIFdlIGFyZSBjdXJyZW50bHkg
dW5hYmxlIHRvIGVudW1lcmF0ZSBNU1JfQVJDSF9DQVBTIHRvIGd1ZXN0LiAgQXMgYQ0KPj4+ICsg
ICAgICogY29uc2VxdWVuY2UsIGd1ZXN0IGtlcm5lbHMgd2lsbCBiZWxpZXZlIHRoZXkncmUgc2Fm
ZSBldmVuIHdoZW4gdGhleSBhcmUNCj4+PiArICAgICAqIG5vdC4NCj4+PiArICAgICAqDQo+Pj4g
KyAgICAgKiBVbnRpbCB3ZSBjYW4gZW51bWVyYXRlIERPSVRNIHByb3Blcmx5IGZvciBndWVzdHMs
IHNldCBpdCB1bmlsYXRlcmFsbHkuDQo+Pj4gKyAgICAgKiBUaGlzIHByZXZlbnRzIG90aGVyd2lz
ZS1jb3JyZWN0IGNyeXB0byBmcm9tIGJlY29taW5nIHZ1bG5lcmFibGUgdG8NCj4+PiArICAgICAq
IHRpbWluZyBzaWRlY2hhbm5lbHMuDQo+Pj4gKyAgICAgKi8NCj4+PiArDQo+Pj4gKyAgICByZG1z
cmwoTVNSX1VBUkNIX01JU0NfQ1RSTCwgdmFsKTsNCj4+PiArICAgIHZhbCB8PSBVQVJDSF9DVFJM
X0RPSVRNOw0KPj4+ICsgICAgd3Jtc3JsKE1TUl9VQVJDSF9NSVNDX0NUUkwsIHZhbCk7DQo+PiBJ
cyBpdCBwb3NzaWJsZSBmb3IgdGhlIGZpcm13YXJlIHRvIGhhdmUgZW5hYmxlZCBET0lUTSBhbmQg
WGVuIG5lZWRpbmcgdG8NCj4+IGNsZWFyIGl0IGlmICFvcHRfZG9pdG0/DQo+IEkgdGhpbmsgYSBm
aXJtd2FyZSBzZXR1cCBvcHRpb24gaXMgcXVpdGUgcGxhdXNpYmxlIHRvIGV4cGVjdCwgc3VjaCB0
aGF0DQo+IHNhZmV0eSBjYW4gYWxzbyBiZSBhY2hpZXZlZCB1bmRlcm5lYXRoIGFuIHVuYXdhcmUg
T1MuIE5vdGUgaG93IGluIG15DQo+IGVhcmxpZXIgcGF0Y2ggSSBkaWQgc3BlY2lmaWNhbGx5IHNl
dCB0aGUgYml0IGJvdGggd2F5cywgZm9yIHRoaXMgdmVyeQ0KPiByZWFzb24uDQoNCkZpcm13YXJl
IGlzIG5vdCBsaWtlbHkgdG8gc2V0IGl0LCBidXQgd2Ugc2hvdWxkIGNvcGUgd2l0aCB0aGUgY2Fz
ZSB3aGVuDQp3ZSdyZSBzb21ld2hlcmUgYWxvbmcgYSBrZXhlYyBjaGFpbi4NCg0KSSdsbCBhZGp1
c3QuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:34:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:34:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416225.660869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4Xg-00055V-NB; Wed, 05 Oct 2022 13:34:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416225.660869; Wed, 05 Oct 2022 13:34:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4Xg-00055O-JL; Wed, 05 Oct 2022 13:34:32 +0000
Received: by outflank-mailman (input) for mailman id 416225;
 Wed, 05 Oct 2022 13:34:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iqu=2G=citrix.com=prvs=270658c04=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1og4Xe-00055I-VL
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:34:31 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f0809ba-44b2-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 15:34:29 +0200 (CEST)
Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 09:34:08 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5007.namprd03.prod.outlook.com (2603:10b6:208:1b1::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct
 2022 13:34:06 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Wed, 5 Oct 2022
 13:34:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f0809ba-44b2-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664976869;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=se3in2uAW3D9ETT34Y+RU+Il35p9iH0up3DLcLAmODo=;
  b=DJTFoJVOq1ZUOggm+40Y5O5qKmzNM7tyWXW2cW6R5aIGh1Rfm1PcBlXQ
   EfCZpHQCoE+UFe1LUkB0jnJIXcpODE9DmY8BU5meD9f1RLhA/NEahmNve
   VZt+/cLoWZnUZTG/iBaWHylBr13qr/J1b4kV/sz6721qf+EOFASQSR8tQ
   w=;
X-IronPort-RemoteIP: 104.47.55.176
X-IronPort-MID: 82014983
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:WdaCtq/OVYRTryJ4AgekDrUDcH+TJUtcMsCJ2f8bNWPcYEJGY0x3x
 mobDzzSaP2CM2HyKt0jPIqx/EMFvZ/Qm94wGlc5rXs8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5gFmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0stHMHt89
 fBFEWgMZyndub71+ZfrdsA506zPLOGzVG8ekldJ6GiDSNwAEdXESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujeNpOBy+OGF3N79U9qGX8hK2G2fo
 XrL5T/RCRAGLt2PjzGC9xpAg8efx3uiBNNCT9VU8NZn2AKU6UwoLCc4ckP84sSGrBOZUc12f
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSvYrqcs3TjwCz
 UKSkpXiAjkHmKKRYWKQ8PGTtzzaEQgYK3UTIxANSwQt6sPm5oo0i3rnS995Faevg97dGDfuw
 iuLpiwzm7USi8EQ06yxu1vAhlqEqpXMTyY04BvWRWOv6g5lZI+jaJes4FKd5vFFRLt1VXGEt
 XkA3sKYvOYHCMjXkDTXGbpTWra0+/yCLTvQx0Z1GIUs/Cis/Hjlep1M5DZ5JwFiNcNslSLVX
 XI/cDh5vPd7VEZGp4cnC25tI6zGFZTdKOk=
IronPort-HdrOrdr: A9a23:nf/O0Kxil5Kp9KhNR178KrPxBOgkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G
 DZm0ihj5/T8s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd
 HQq1MLPth16VnWYmapyCGdlTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MJ40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIWLH5AJlO+1GkUKp
 goMCju3ocRTbpcVQGBgoBb+q3pYp30JGbffqFNgL3P79EcpgEF86JR/r1iop5HzuN8d3AM3Z
 W7Dkwj/os+MfM+fOZzAvwMTtCwDXGISRXQMHiKKVCiD60fPWnRwqSHqYndydvaD6Dg9qFC7q
 jpQRddryo/akjuAcqB0NlC9Q3MWny0WXDoxttF75Z0t7XgTP6zWBfzA2wGgo+lubESE8fbU/
 G8NNZfBOLiN3LnHcJM0xflU5dfJHECWIkeu8o9WViJvsXXQ7ea/tDzYbLWPv7gADwkUmTwDj
 8KWyXyPtxJ6gSxVnrxkHHqKgfQk4zEjOdN+YThjpsuIdI2R/xxWyAu+CSEz9DOLyFeuaore0
 Y7KK/7k8qA1BuLwVo=
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="82014983"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L82OP4XbzQSDtQp/iN0wxiT2iF+O+NK9IFgsa15qVVeiVZR4jlYx8CmFIBWST4imp+CNRs32MipG/r266ZJo1vrJ/TxgDdIfnzh2O8f6CMMyp46PfxAsyAgZ2pKfTbG/PecVirKteCr+uKTMjc33dBgcP5QLGbXh8eetpq+5++m4TFDb1oykyraApXm5yJzPl0mV50F4P1AlubHKVJJbGevP7Q57mBoH20ZhpNGQ5HngneOnEqcTSW6h9CHxcfI2LvpwQwfvpFPvjsZX3FVWeqWimFL++7g3sWmokIxitHfaWni/633GLlyprDnk63Qr7Vkbz5GvBcksdfxldu9rvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=se3in2uAW3D9ETT34Y+RU+Il35p9iH0up3DLcLAmODo=;
 b=IEo2DbUP5nJuBNplI6Hbo4aN+252BE8PJB4Xd+upJ+PexupJHbA0JUe3P4EiF1lcL4nqEh8+NU8Bgwce+QJMfi/cUOETAwZT56mLIAtaGOaM+Mw5Y76Ty4dpehANcU/O30bhsLYZwWpov8cKgy3uGXJQEGnzyEYe0C4g07XKR9x3XQl2eid8pSmemIrcd7+NGUGbYYbXwpf6OKFdFHrIbMUL/UhY/43u68DvuHFf39YZrM78mFSk8RE9YqnmbvScl9Y37m+wS4f3ia2j+4GhWm2Je7fu2fegjsh617y5Mobi3x2uVMRleWj6A138xZzVMoNvALBfENgmv3j1KZ+J3Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=se3in2uAW3D9ETT34Y+RU+Il35p9iH0up3DLcLAmODo=;
 b=Ycqp9ZUH7QEY9onw/FDxTYStN8dZegNcYZWnHLfyNjBIpxnynu6YY0UI3zLyfOn7XyhkuQ93eCnrcDHcY0Q0Fz1d8+F+W1ngP7LDmR5+kft/ZjExIBbPFLaFSRJG2pnS4fFYcxDw2i/vkIXrmepORl2T8zzn3uIeDmy92IAaGRo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Wei Liu <wl@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Thread-Topic: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Thread-Index: AQHY2AuYxJImxml8GUGenwgOwsThN63/kTAAgAA9AAA=
Date: Wed, 5 Oct 2022 13:34:06 +0000
Message-ID: <0ff7672e-46b8-d74c-ec66-75a1bec8b557@citrix.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
 <Yz1Uoma3S4Wgmr4F@Air-de-Roger>
In-Reply-To: <Yz1Uoma3S4Wgmr4F@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5007:EE_
x-ms-office365-filtering-correlation-id: 665de7fd-4e2d-4d62-8bfd-08daa6d646a8
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 2pXNMaNTKNHFaROx73MIP/56Etv4SC/tAMU/cocNlcFO66IwfBsfRBTIVA76falxA+zj22XzufXeHCkO4s0uHQTvMnhDk39gLvZ+JfZxAyxZnET9yvIyVy811jLX/OBBTNMoQAkqEIgpI+SbQuGU1x92/LarxSwTeAx8P/i3ygEUDubeN+Qlzx8NKcHRvOUzf25DBq8f3tFdQI5pwNIqXUIJ21gCh2I4SE8WypttugULuJ/b+xrFG05QYNiFiNSjPxVyZ4+ie36Mto4MOaaWdD16yIIFdwV5DA/HTqi/Q5dIGNAJ74FFwKyQVvRfWcvx+48PcNeuSZHniOUIrpy/Lzguy9e3dibCZuwWwMrPhgIjLOACCu0M1AEAJqv98txhiNa5ESEaKP/Q3ZiHkOu3MgGsH6LW9tsClGk6Mo9b/dZNo9kDi6VeKATkWIkjnYw6KsGqd51o+chiFmdJwWfQAh/UqnTXzmgyWNUweHZP4KwD3/JrQbZQCKAmUHbDYNW0ewE6/m9nF5WNgj4953gmu3ANye1U+VjKPwWUjcvXOYBHWgpe+jq29lEfQ1wpa9GNZvsay+BobqAnL4A67zcpCvANhhCMHeR6Mywao44+DdEjKUGEFYFdhIFn0N5V7OU249gztne3b+8Z/b+5BZIxN2Q8OtmOK2jqtjjUI+fCjdzygKAd50csSq2JYm5TonH4Smp/sgcGfJBAMse6QSSHSKhe7H/cyXE67HL5+NWGub9qToBYH3obDQdi/bAU2Y2GDaPDKUe0v+TudpnqQKgLBnJHs5EM6w91e+phjINMjz9fBzD4aHI5t22RL9MMv++J3G9G6k0qPS+SFxJIAINZJQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(2906002)(186003)(38070700005)(122000001)(82960400001)(38100700002)(66946007)(76116006)(91956017)(66476007)(66556008)(66446008)(4326008)(8676002)(64756008)(316002)(6636002)(54906003)(37006003)(4744005)(41300700001)(8936002)(5660300002)(6862004)(53546011)(6506007)(6512007)(26005)(71200400001)(6486002)(478600001)(2616005)(31686004)(31696002)(36756003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?OXpHOWYzbkgrWTlSOGRHQW0vRVh4TEtaWHpoZG5IMzdqUU05cmpjSnA3TGE0?=
 =?utf-8?B?OXUrQThqMkhsQW45SjcwZFU2RkV6eDZSTXBrWWZ2UWczSzZDdjhXZnlmaXhn?=
 =?utf-8?B?Q2hDTzRYdEVTMElYV0l6SThSVTYzNzVOSEZNbE5oLzZFR2RvVWlZc3VNSDA3?=
 =?utf-8?B?aXozMFJka3hiYVBybWRvL1E1Q3hUTUUrdHQ4RjAwcGFsdmpGdVVWRVFTeVBr?=
 =?utf-8?B?RWcvWGtoZXlDeUdTZk5vQVA0RGNCczJDV3QxeTRrbGxCUU4ybFRWdWNJek9O?=
 =?utf-8?B?Yk5QbVEyQ3B2WFl3eGlQUmVZWjZ5bHdDTDAwTys2dnFTcWg1ODM2SUl6eTRG?=
 =?utf-8?B?emFaY1JCaUZLWHEwWTlFQzh1SVkrY3lIOGFRakJwUG52cVpXK2ZlYzZkRjNy?=
 =?utf-8?B?aDZJY0V4bUN6TDVVbWFCK3BxUFJVdmhQa3VvR0hDVlBsSTlWcG85b0dZSkFX?=
 =?utf-8?B?VmpRSWVTcXN4NzNCVDJuZjBPUk05OHJyaG1XK1pNTk9LNStMaERqK3pXc1Jl?=
 =?utf-8?B?WngxTXo5VG1aMHd2N25walhsWG5QTDJGdHpVamswS1lIMkcyRWlCbEJVQ0k3?=
 =?utf-8?B?N2NzWUhxSkhXam9YYjVueVdLS1ZSWnBibTB4R1pzbnIyZmN1R0plaThJejJz?=
 =?utf-8?B?Vy96V1kzOUNwRzIrU2FOVWlRZjk4bWxCUmN1UzdhVFNZUW1zVWRlc01yZ1NS?=
 =?utf-8?B?eTY1b0hYRVRuaiswNmR5TlJRQUdGNDJFY0JvZ3F2aHZHQll5ZzZqNU42UGcx?=
 =?utf-8?B?bWFBbVpOMVBDYjYyb3ZQWTN6eklmQ0RCTVdMWnVhb25RVUI3RGt0UUREOCtC?=
 =?utf-8?B?LzVzclZFZUw2Q2lYdCtTd1FCai9ndEFvSy9wQ3ZZeVp2TzZ3QXBYd1cwejg4?=
 =?utf-8?B?VkorMmFHeWg2c2sxSGFJclVmU1RQTFNIMzVWNE0yK0J3KytKWklkS0lmcGJB?=
 =?utf-8?B?dUd6MmJqS0dGZlJuR0tKaFExVG1YK1A2YWVQbXVaNTZNUnZjZW9VL05TZHB0?=
 =?utf-8?B?T3M5djlZRnJuUDN2UTdqOThlODlaSHdBTkNobWs4QzNocWZiaDRCTEdMcU9q?=
 =?utf-8?B?T3c2c0FLTWJTdTVuRkRhUHB1dzZDYVd6cG1sMS81S0xMVnRuNDNqU1lKLzZO?=
 =?utf-8?B?MU9GQll3K2tFRUZSL0x5T1NQbkZHMjBmTlFmSDBGZUZKSHBkU2tHYk4vMzFF?=
 =?utf-8?B?NlV3enE1QjFUT0hFaC9HVFNZZGVhOVIxTDI2MHhydDdVUWpHdlE5cG0vdjBN?=
 =?utf-8?B?Q3pGdjdoaGJRMnUrTGFyaEtCTk5TL05CYjZMOXRINXIvTW9uQTUrV1RBOFFZ?=
 =?utf-8?B?YXpxc3VHT0lXODJ0cVJnSFhHTVVnZTg1YmtJelRvNWVlcW9uWCs4T0xiRlZs?=
 =?utf-8?B?amk0RGlhMHdyOXAzeGVZOFo0NGpqUUhhQ2k2b09CS2xBQmFlRnNXb1RCWHBh?=
 =?utf-8?B?LzFWTnhWWTNUY3hTemtVWjR2UG9LZDNLWVVyYVR1eUxPbjk3Z3pueVdVcUIv?=
 =?utf-8?B?TllFV2NkSU1EN1d0eWRQNjVVeTNxWWh4b1hidUowNGtTUVdXSkROQTFZQ2E3?=
 =?utf-8?B?SmZnZEdEL1dXYTNBMnFpaFpXbEM5aU1HRUZmbEszU0EzTW9qcDNnR0V6Y2hT?=
 =?utf-8?B?MUF2Y1ErTU4vQ3ZvTWtxSDF1Z0YzTklpM0NqVGUwU1hhdGtNQzY4alhIc29I?=
 =?utf-8?B?eHhlaVE4MGRiWVZlU2hsWXdpaTFUOTJST3BOZEk0R1RMYmxJNE5WYkd1eHRq?=
 =?utf-8?B?ZHlGZzVUU1dVVFNCSmMvekprWStUNm5EK21ZNkNhNUFwMy82NFFyUm9EREl1?=
 =?utf-8?B?VFVRck5XaFBOdDNKRTEwNzliTUhsREJBK3U2TS9DRmtQa2VkdkttRWsvcm1F?=
 =?utf-8?B?Sk5jemNES09GMGpnK3ZscmxvUVNCMU1WdEtuc2lNeVlodVpEc3lqdG56NVV6?=
 =?utf-8?B?MFh5dEtKVVF4ZktvVTloMlZxb3BFZ2xOdXFpelptajg5aVV3NFd6MVJGcHp2?=
 =?utf-8?B?dDJ1NGxMMXZLRGZ6NkxqcXV0SzBQOURwTmVHcTlQY2J0Z2Z5WGVrZi9LeEFj?=
 =?utf-8?B?eHNMNk9EYldtSnpBV25HZ3hDTDhXM0pmSGpRaDBFejN6UThrYUh2VUFvZi9s?=
 =?utf-8?B?cGtBOGdQR3V0S1M0YlE0WC9vd3pBL1lCalljalBZbDhFWnMwekdTRFJBNHh4?=
 =?utf-8?B?OXc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9C064B73FC80DC488D47EE8CDE6D3EE6@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?WG96OHRxd0g0WDduWDd0TTF6MXZLYWE1MThBMVJDeGlXUzA4VWZDSE90cUt1?=
 =?utf-8?B?TjduNk5QN1g2Y2NZUkhGeWYwM2JlMlVxa3UxVXdLdDZod05YUkk1aEM2SmxE?=
 =?utf-8?B?bER4eXpORjFyRHFSdW0ydHY2dUw3RWVtRnlyWlU2bmdIY2dFMndCR28vMlQr?=
 =?utf-8?B?cDJ1ZXhZTVZONVZJb3Fzb2Q1aG85Ym85VDQ1bEhOMCtqWmM4Mm5DNkxFZEVy?=
 =?utf-8?B?RHlQVk5HWDBnOWh4YlJmb05NNksvUUVTTlB6cUF6ejc0SzlYdXdRQ2xEUytI?=
 =?utf-8?B?QUYrM0xqczkvVlZ0emJvdkZYNDNCa0xkd0FJdk9YZmJWT1NhTlhOT1pBOVc0?=
 =?utf-8?B?SWVMN3Z5c2VJZHdhMm9yMlAvK0VaMFNaT3hSbldSQUVrbUltbmZ1dlNMRVRs?=
 =?utf-8?B?c1dTam5WOGh2VGZ0NjdMYS9SR3VYZU8wN1RTY0RBQjNWdmFjZFUrQ2NwcEVu?=
 =?utf-8?B?QTA4NFVCY1NLQ25pMk9jREVkZHI5MDVJSkxOMm9PaCtVRHdLc1lOVVd5MGo5?=
 =?utf-8?B?aFZOMFI5MnFpZWd2S2JGdlZNUHQ0M29rMzhwaVNRSDJLOUl4RU9LVU56SUh6?=
 =?utf-8?B?OHNUSXQ2L1BrSUNvRUdFbWgrcGZ3NkQ2OTRwYXJLYVp2enh6a0JiUXBxaHdp?=
 =?utf-8?B?T0FvT09qZUVSZ040cExnRlNGeHp2aURRaytzdkh3U3phc2lNRUtMOFE4dnFa?=
 =?utf-8?B?NTBoN1NFVS9GRWdPMENiaHFyR0FrMENrWjdnUkh6aUliVVdxU1lnY3BtT2pK?=
 =?utf-8?B?Q2RZclJCaER2cUhBbkRmSWZYbVJxZXg2Y0phN2JIQzBTMjFZS1R0UDhmUW93?=
 =?utf-8?B?VTNsU3VoMFdkSmNTNUk5Y0ZFSC9zbnc5UkIvcW9paVNIVnEzeGZGczdFVjhX?=
 =?utf-8?B?Q0NaS1pBZUo5SDQ3SG85T0hSeGxtajhnck5qSkpOUzFSY2pmcmEwNDZTWEdC?=
 =?utf-8?B?MThuR0t6MUVJQTNKdHRJTmVNOU9XNHJiUDVnRUpzS2wwVHpGeHpCWS9HM3Bn?=
 =?utf-8?B?SWRrcEROWVRpSWpMeDUvYm81YVdaZ0lOdW54NENoSWI4SDVsQUFCdmhoY1VZ?=
 =?utf-8?B?WUI4OW44M0hmbWJmRFJRVGhZemxmNFROdk9lWDhrc1gvYWFmQU9uejZ4YVhi?=
 =?utf-8?B?bmFieWVveXdIc0lOYWRKd1FJbUxnUFZ5aFRtUTBPQ0l5dkhjSm8xRVpwUG1a?=
 =?utf-8?B?anFuNFJURU5pNWdpYXNOVi9zVXp6MFkxYzhHNE1mM3VQZTRwRlFBOUg2SjIy?=
 =?utf-8?B?TzFqVDV5cnlMd1k1dC9DMEZZU3ZBUnFrZzdzWlpITitpSzR3dz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 665de7fd-4e2d-4d62-8bfd-08daa6d646a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2022 13:34:06.4697
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c0mxucM/6Is+83fhCPY3OJZ1viDGMHDVCwqAj+ldj6vB7Jm7Jod62eW7J7DSXqQzHDAGXIY8KRL1iJHUZiS8I9rO7vxsHECZbgNZNTH2eoA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5007

T24gMDUvMTAvMjAyMiAxMDo1NSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gT24gVHVlLCBP
Y3QgMDQsIDIwMjIgYXQgMDU6MDg6MDlQTSArMDEwMCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+
IEEgZnV0dXJlIGNoYW5nZSB3aWxsIHdhbnQgYSBjcHVpZC1saWtlIGlkZW50aWZpZXIgd2hpY2gg
ZG9lc24ndCBoYXZlIGEgbWFwcGluZw0KPj4gdG8gYSBmZWF0dXJlIGJpdC4NCj4gV2h5IHdlIHBy
ZWZlciB0aGlzIGxvZ2ljIG92ZXIganVzdCBnaXZpbmcgc3VjaCBwc2V1ZG8gZmVhdHVyZXMgYQ0K
PiBzeW50aGV0aWMgYml0IG9yIGFraW4/DQoNClN5bnRoZXRpYyBiaXRzIGFyZSAoaW50ZW50aW9u
YWxseSkgbm90IGF2YWlsYWJsZSB0byBjbWRsaW5lIHBhcnNpbmcuwqAgV2UNCm5lZWQgc29tZXRo
aW5nIHRoYXQgaXMgYXZhaWxhYmxlIGZvciBwYXJzaW5nLg0KDQo+IENvdWxkIHdlIGhhdmUgYSBi
aXQgbW9yZSBvZiBhIGRlc2NyaXB0aW9uIGFib3V0IHdoYXQgd291bGQgYmUNCj4gY29uc2lkZXJl
ZCBhIHBzZXVkbyBmZWF0dXJlPw0KDQpJIGRvbid0IHJlYWxseSBoYXZlIGFueXRoaW5nIGZ1cnRo
ZXIgdG8gYWRkIGJleW9uZCB0aGUgY29tbWVudCBpbg0KZ2VuLWNwdWlkLnB5DQoNCkl0J3MgYSBt
aXNjIGNvbGxlY3Rpb24gb2YgdGhpbmdzIHJlcXVpcmluZyBzcGVjaWFsIGhhbmRsaW5nLg0KDQp+
QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416230.660880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4Y9-0005dw-2s; Wed, 05 Oct 2022 13:35:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416230.660880; Wed, 05 Oct 2022 13:35:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4Y8-0005dk-WA; Wed, 05 Oct 2022 13:35:01 +0000
Received: by outflank-mailman (input) for mailman id 416230;
 Wed, 05 Oct 2022 13:34:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og4Y7-0005dX-Bc
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:34:59 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 813ae665-44b2-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 15:34:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id CA89621908;
 Wed,  5 Oct 2022 13:34:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ACD7C13345;
 Wed,  5 Oct 2022 13:34:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Pu5eJAGIPWPRDQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 13:34:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 813ae665-44b2-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664976897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=El4JLMS24llyAZuKoBuUB2pklIvHUj7HOuT1FjTbuIw=;
	b=Ew2jY0UaBNTiHT8NJA6+zAzHvt41ltzubVv74zfFg1VRhGkLoRFGBCuF7cIvQ/6CGlWpNR
	qmiSucvvB0kmu916dVtOY8OqDgSa3+ZW+jlU9sB0/IPMbdkBKtIF4asjN4yKy8SRqeMWTY
	99npnS5NSffKlygOBqvszo7hhTDPwPo=
Message-ID: <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com>
Date: Wed, 5 Oct 2022 15:34:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
In-Reply-To: <Yz2Fvp9Q9aeYKnDY@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------idwQYzvS76ONej6N4uG0rw0v"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------idwQYzvS76ONej6N4uG0rw0v
Content-Type: multipart/mixed; boundary="------------L0Jox5dlCfIBqkZqf1rgmdvL";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
In-Reply-To: <Yz2Fvp9Q9aeYKnDY@mail-itl>

--------------L0Jox5dlCfIBqkZqf1rgmdvL
Content-Type: multipart/mixed; boundary="------------S0Ui21f7UEv7odRer5m6tL16"

--------------S0Ui21f7UEv7odRer5m6tL16
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTU6MjUsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDI6NTc6MDFQTSArMDIwMCwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IE9uIDA1LjEwLjIyIDE0OjQxLCBNYXJlayBNYXJjenlrb3dza2kt
R8OzcmVja2kgd3JvdGU6DQo+Pj4gSGksDQo+Pj4NCj4+PiBXaGVuIGJvb3RpbmcgWGVuIHdp
dGggTGludXggZG9tMCBuZXN0ZWQgdW5kZXIgS1ZNLA0KPj4+IENPTkZJR19YRU5fVklSVElP
X0ZPUkNFX0dSQU5UPXkgbWFrZXMgaXQgdW5hYmxlIHRvIHVzZSB2aXJ0aW8gZGV2aWNlcw0K
Pj4+IHByb3ZpZGVkIGJ5IEwwIGh5cGVydmlzb3IgKEtWTSB3aXRoIHFlbXUpLiBXaXRoIFBW
IGRvbTAsIGdyYW50cyBhcmUNCj4+PiByZXF1aXJlZCBmb3IgdmlydGlvIGV2ZW4gaWYganVz
dCBDT05GSUdfWEVOX1ZJUlRJTyBpcyBlbmFibGVkLg0KPj4+DQo+Pj4gVGhpcyBpcyBwcm9i
YWJseSB1bmNvbW1vbiBjb3JuZXIgY2FzZSwgYnV0IG9uZSB0aGF0IGhhcyBiaXR0ZW4gbWUg
aW4gbXkNCj4+PiBDSSBzZXR1cC4uLiBJIHRoaW5rIFhlbiBzaG91bGQgc2V0IHNtYXJ0ZXIN
Cj4+PiB2aXJ0aW9fcmVxdWlyZV9yZXN0cmljdGVkX21lbV9hY2MoKSwgdGhhdCBlbmZvcmNl
cyBpdCBvbmx5IGZvciBkZXZpY2VzDQo+Pj4gcmVhbGx5IHByb3ZpZGVkIGJ5IGFub3RoZXIg
WGVuIFZNIChub3QgYnkgdGhlICJvdXRlciBob3N0IiksIGJ1dCBJJ20gbm90DQo+Pj4gc3Vy
ZSBob3cgdGhhdCBjb3VsZCBiZSBkb25lLiBBbnkgaWRlYXM/DQo+Pj4NCj4+DQo+PiBJdCBz
aG91bGQgYmUgcG9zc2libGUgdG8gYWRkIGEgYm9vdCBwYXJhbWV0ZXIgZm9yIHRoYXQgcHVy
cG9zZS4gVXNpbmcgaXQNCj4+IHdvdWxkIG9wZW4gYSBzZWN1cml0eSBob2xlLCB0aG91Z2gg
KGJhc2ljYWxseSBsaWtlIGFsbCBQQ0kgcGFzc3Rocm91Z2ggdG8NCj4+IFBWIGd1ZXN0cyku
DQo+IA0KPiBXaGF0IGFib3V0IGV4Y2x1ZGluZyBqdXN0IGRvbTA/IEF0IGxlYXN0IGN1cnJl
bnRseSwgdGhlcmUgaXMgbm8gd2F5IGZvcg0KPiBkb20wIHRvIHNlZSB2aXJ0aW8gZGV2aWNl
cyBwcm92aWRlZCBieSBhbm90aGVyIFhlbiBkb21VLg0KDQpFdmVuIG5vdCB2aWEgaG90cGx1
Zz8NCg0KPiANCj4gU29tZXRoaW5nIGxpa2UgdGhpczoNCj4gLS0tODwtLS0NCj4gZGlmZiAt
LWdpdCBhL2FyY2gveDg2L3hlbi9lbmxpZ2h0ZW5fcHYuYyBiL2FyY2gveDg2L3hlbi9lbmxp
Z2h0ZW5fcHYuYw0KPiBpbmRleCA5YjFhNThkZGE5MzUuLjZhYzMyYjBiMzcyMCAxMDA2NDQN
Cj4gLS0tIGEvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jDQo+ICsrKyBiL2FyY2gveDg2
L3hlbi9lbmxpZ2h0ZW5fcHYuYw0KPiBAQCAtMTExLDcgKzExMSw3IEBAIHN0YXRpYyBERUZJ
TkVfUEVSX0NQVShzdHJ1Y3QgdGxzX2Rlc2NzLCBzaGFkb3dfdGxzX2Rlc2MpOw0KPiAgIHN0
YXRpYyB2b2lkIF9faW5pdCB4ZW5fcHZfaW5pdF9wbGF0Zm9ybSh2b2lkKQ0KPiAgIHsNCj4g
ICAgICAgICAgLyogUFYgZ3Vlc3RzIGNhbid0IG9wZXJhdGUgdmlydGlvIGRldmljZXMgd2l0
aG91dCBncmFudHMuICovDQo+IC0gICAgICAgaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9W
SVJUSU8pKQ0KPiArICAgICAgIGlmIChJU19FTkFCTEVEKENPTkZJR19YRU5fVklSVElPKSAm
JiAheGVuX2luaXRpYWxfZG9tYWluKCkpDQo+ICAgICAgICAgICAgICAgICAgdmlydGlvX3Nl
dF9tZW1fYWNjX2NiKHZpcnRpb19yZXF1aXJlX3Jlc3RyaWN0ZWRfbWVtX2FjYyk7DQo+ICAg
DQo+ICAgICAgICAgIHBvcHVsYXRlX2V4dHJhX3B0ZShmaXhfdG9fdmlydChGSVhfUEFSQVZJ
UlRfQk9PVE1BUCkpOw0KPiAtLS04PC0tLQ0KPiANCj4gVGhpcyBCVFcgcmFpc2VzIGFsc28g
YSBxdWVzdGlvbiB3aGF0IHdpbGwgaGFwcGVuIG9uIFhlbiBuZXN0ZWQgaW5zaWRlDQo+IFhl
biwgd2hlbiBMMCB3aWxsIHByb3ZpZGUgdmlydGlvIGRldmljZXMgdG8gTDEuIEdyYW50cyBz
ZXQgYnkgTDEgZG9tMA0KPiB3b3VsZG4ndCB3b3JrIG9uIEwwLCBubz8gT3IgbWF5YmUgdGhp
cyBpcyBzb2x2ZWQgYWxyZWFkeSBmb3IgcHYtc2hpbQ0KPiBjYXNlPw0KDQpUaGlzIGlzIGEg
c2ltaWxhciBwcm9ibGVtIGFzIHdpdGggbm9ybWFsIFhlbiBQViBkZXZpY2VzLg0KDQpZb3Ug
d2lsbCBuZWVkIGVpdGhlciBhIHNpbXBsZSBncmFudCBwYXNzdGhyb3VnaCBsaWtlIHdpdGgg
cHYtc2hpbSAoZW5hYmxpbmcNCnN1Y2ggZGV2aWNlcyBmb3Igb25lIGd1ZXN0IGluIEwxIG9u
bHkpLCBvciB5b3UgbmVlZCBhIGdyYW50IG11bHRpcGxleGVyIGluIEwxIA0KWGVuIGluIGNh
c2UgeW91IHdhbnQgdG8gYmUgYWJsZSB0byBoYXZlIG11bHRpcGxlIGd1ZXN0cyBpbiBMMSBi
ZWluZyBhYmxlIHRvDQp1c2UgTDAgUFYgZGV2aWNlcy4NCg0KDQpKdWVyZ2VuDQo=
--------------S0Ui21f7UEv7odRer5m6tL16
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------S0Ui21f7UEv7odRer5m6tL16--

--------------L0Jox5dlCfIBqkZqf1rgmdvL--

--------------idwQYzvS76ONej6N4uG0rw0v
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM9iAEFAwAAAAAACgkQsN6d1ii/Ey9C
gggAiWLErCG6HxC+qiLR8RFGLDDHFM2MVFQiHNkrlNV7xzfVOevDMUT31dy1R0IlZUEqObfFQ8dh
gOnSsA7w9JFo4YrKMkVddkfleSmtkn6GrNh3y3tM5EYDsNGkOguLd9Dp6l6avCuHST8es0DplINI
k2P4jxkAbpvArJ9u5mTP+pbbZ38M9ghCR31IJ3oYKlM8nwnvDlVSZiIL/abwbAcW6KREGNAkvtV/
Jl0i+PR/3g4+x2phy74MVOJvKFy/a0C/OjJUcE/3dgLXAmNZjwHrZJ1lULGe0cvhfNZtD3dUKfK7
WS40/0ljaIwRKSK5j+M2kJM+Fflv7AkD7EyorerlTA==
=UFwT
-----END PGP SIGNATURE-----

--------------idwQYzvS76ONej6N4uG0rw0v--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:45:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:45:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416244.660890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4iQ-0007Gk-2z; Wed, 05 Oct 2022 13:45:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416244.660890; Wed, 05 Oct 2022 13:45:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4iQ-0007Gd-03; Wed, 05 Oct 2022 13:45:38 +0000
Received: by outflank-mailman (input) for mailman id 416244;
 Wed, 05 Oct 2022 13:45:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8iqu=2G=citrix.com=prvs=270658c04=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1og4iP-0007GX-3K
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:45:37 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fbe4544a-44b3-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 15:45:35 +0200 (CEST)
Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 09:45:27 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5230.namprd03.prod.outlook.com (2603:10b6:208:1f1::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct
 2022 13:45:25 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::988c:c9e4:ce0d:b37c%4]) with mapi id 15.20.5676.023; Wed, 5 Oct 2022
 13:45:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbe4544a-44b3-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664977535;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ZlQgQWd75HENPekjn1rV+kEHsr27SCsmfFJcgCfzhG4=;
  b=GHv4czevJ8T4akWbb3axKoRfzd0mTM+/Uyb0XW75osOmBTrVLbhje30X
   eRHYEYo/gTrZ2Me8PLXLYG0qPzeF5dKC+vqxesRoAcIqLgNRja0lex7H4
   1OHvb97U+6VqoFya+s+JBapf1p0SEGPNBLIQ88iz+qmACKB/JP4KCIUYk
   8=;
X-IronPort-RemoteIP: 104.47.56.172
X-IronPort-MID: 84545140
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:oz6Xx6mc0r3OcLo+b2/OLkno5gxxJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXXGrUaKmLZGOnLd9+Pt6wo0sH756BxtdhSARk/i88EiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRmOKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfI0BH5
 dpDNQk3cj+m3/Ps0rj8VcRnv5F2RCXrFNt3VnBI6xj8VK9jareaBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6Kk1YZPLvFabI5fvSjQ8lPk1nej
 WXB52njWTkRNcCFyCrD+XWp7gPKtXOnBd5PTeHgnhJsqF3P6FAyLgEtb0O2nsSdjWi6Zo0Fa
 GVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQPwrstUnAwMj0
 FChlsnsQzdotdW9THuH876OoDCaOC4LLHQDbysJUQsE5db4pIg5yBnIS75LHKOwj/X0Hy/x2
 DGAqCUih7QVgtUP3q/99lfC6xq8q56MQgMr6wH/WmO+8hg/dIOjf5av61XQ8bBHNonxc7Wal
 H0Nmszb5+dXC5iIzXWJWL9UQ+vv4OuZOjrBh1IpB4Mm6zmm53+ke8ZX/S16I0BqdM0DfFcFf
 XPuhO+Y37cLVFPCUEO9S9jZ5xgCpUQ4KenYaw==
IronPort-HdrOrdr: A9a23:e+Tyy6+gj03eQHt6UlNuk+Hwdr1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79
 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6
 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X
 XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM
 TF5z0gI8NwwXXMeXzdm2qi5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 F29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQFo+dY7bWfHAbIcYa
 5T5fLnlbBrmJShHinkV1xUsZiRt7IIb0+7qwY5y5eoOnNt7Q1EJgMjtbAidzE7hdIAotB/lp
 r52u4DrsAwcuYGKa16H+sPWs2xFyjERg/NKnubJRD9GLgAIG+lke+/3FwZ3pDcRHUz9upFpL
 3RFFdD8WIicUPnDsODmJVN7xDWWW24GTDg0NtX6ZR1sqD1AOODC1zJdHk+18+75/kPCMzSXP
 i+fJpQHv/4NGPrXYJExRf3VZVeIWQXFMcVptE4UVSTpd+jEPyjisXLNPLIYLb9GzctXW3yRn
 MFQTjoPc1FqlumX3fp6SKhL08FunaPiK6YPJKqjNT7krJ9R7GkmjJl+WiR94WMNSBItLAwcQ
 93PK7n+5nL11WLwQ==
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="84545140"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VBhoUa1NXa96DvW/AF5E75LY2vA16QUFIlsRs7LtquOmkMCnEwE4EyrJBYT22ozEtkFwA0/0MkBOtGqqAr/5TLuzm1H6PuSA7fj8zDTljkVr7013FI4phqY5ftS7/to7CwcX1b7vLsWM42iQGpBOjckf+VMTX6KgyhiuuUTHwm0z19+5c64uMzus/Hy+ngtlxNssklpiuDLB1FYxGCQeCTu4NpAeUn9Ks88C48LboqDEsHc+RhHQH+48wR6yUy3Mq7ruSEbmDGL48lhISb5nGQBpHfFp0wak1prxGRXxbUCXulNCWLg31P+uy3CafiETGP0u3OFKahdEi55tcEFJZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZlQgQWd75HENPekjn1rV+kEHsr27SCsmfFJcgCfzhG4=;
 b=mKSPtBIuqgWhN44Z+y+et/1nbBb4cxW8oU0EqKaYLLG75GxrwhffD1FcMJmxwBkBhxiQNZ9lUFtV2KkdfDox1A2gIR43cJ/iLpp42BtPW3WVp0Vb+8zNB2C5ew1oDLwao5rJ6Ga4t15alCgHC5f84nj7axTuCugfbKY3YUFIt2vBPbMdv3BJk3+W9mmCgABA64hmFJWemyUz/9QKQeEBW5DiHkvxHH5RdczZtQ6GSDnvIA4O/l8Fu89+WiS3+DNzJx7/wS3/DvlKtYg07Q5ZO9E24l0RxdSiL3i12Ga5xjyFgjgivpXfXqwQ+W3r0k+I+bUZnSLWXJYmCDy/BoSdEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZlQgQWd75HENPekjn1rV+kEHsr27SCsmfFJcgCfzhG4=;
 b=R9gMi/jiCucBoZm359XFlFsYYh5NOa2f+2BTAm8wdjQ1OhR3b8limyqU3McvNx4saFNOjphraEj5+rqJJxb6dCbU+RZVrJ57IPrug/4v4FsOMRbZKqTDHl4LTPp+X0pqXOg7IT8bn8v6O3kWiUGka8oy2s9KjtLyXVYnSUnhzXo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Henry Wang
	<Henry.Wang@arm.com>, =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, Demi Marie Obenour
	<demi@invisiblethingslab.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Thread-Topic: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Thread-Index: AQHY2AuYxJImxml8GUGenwgOwsThN63/X+4AgABkSoCAAAOQAIAACZAA
Date: Wed, 5 Oct 2022 13:45:24 +0000
Message-ID: <478761b2-a47c-147d-b6ae-05c3596dfabf@citrix.com>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
 <50324b35-5b75-18b6-6ee7-fbe9b5f5d662@suse.com>
 <ccd05cfe-1f77-5bd3-996b-bfcaf2ae30f8@citrix.com>
 <e8142d80-217d-7053-1bae-cd7abff17b78@suse.com>
In-Reply-To: <e8142d80-217d-7053-1bae-cd7abff17b78@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5230:EE_
x-ms-office365-filtering-correlation-id: 51b4ab8a-3b4f-42c4-189d-08daa6d7db13
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 WffGVkY/L1r+yfj7ethDFZBMxcwfoXii4RXfsx3UD/oQSX15UUyiMeFJURkqo8DrX60BqynEbFsLLGfHNoh4ZNnNIoCGrqs566HAKENbm6m03AQ6LtiYMS4NMWT39Ho//mM2pBHxcQY0Giv9dp1tl8erCyCGet1yQR97g43PDjZGsMAvf7US+MNoCFb2n4eAMNJ2I1EQwc3NoSMR7/26WOk9thYIA+Ef6JS+6HfZgEbGI8DVNPT67KuA8QjUb4EIetXQ+fKQFQcL+uUFXbCxDrCqkpSVnfCdkO9hk9Dfvk9IEhWyl8KaCjFR/LXsTvckXHPvi1kP6ySus8ZrWaMYytYikfzD6jlGjfdF1UJ5cTNGG9H9yywJ44/yheqb0vvHOI84sf9+0VOcdow+offhO86Ag6AODYmoSLDhti7NBx9/4x8TR9nFwQp8T/LqjQ5mSL4pYCoZk27RX46qIgWOBAI0KCgs9zm3GFS70v4/P6DUI+yXU00phyQHNezlKeOgyeKpc8twR2iiEjVs7iNgOiMMc3PNy0ulgEBH6VIkMFyfzLflp2g2x7cXICEv3Va5HwFhikPJVJR3YYZJ4iKwqCRF/RM4pBZcxwx33F5myVybxLG8qRL/QX2r21hoFBujC0jzUzBWokEHjJwzi7srWAwaOGQDiyu5oFtaQJUrxsuV2k5SkAoRws5A6bwWAnFA2yG15NRKyFhVPdAEs2qbvCCTt+YbaUzJsaJmPXhULIaIQL8iYr94XBsNKw/LvJiwaBMpvEJXqbrJNaUrB8zV1V2LO4RqUinzbUVcajArRcNtkUSAxDejCxo/V7hAuo7gXQ7eRu2PKbyhA7Si9jK9yg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199015)(36756003)(31686004)(82960400001)(38100700002)(38070700005)(83380400001)(86362001)(122000001)(186003)(31696002)(2616005)(6506007)(6512007)(26005)(478600001)(2906002)(6486002)(5660300002)(6916009)(316002)(41300700001)(53546011)(71200400001)(8936002)(66556008)(4326008)(64756008)(66446008)(66476007)(91956017)(54906003)(66946007)(76116006)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ekdHUVAxakI1VXdUOFV5bExxQ1VlSmFDVVppUk5UZHpwM1BRYzA0aFFlV1pG?=
 =?utf-8?B?ajVwaU1RclJOTGdqT2hsbytNMERXYk96SnRWN1JxcFgzczhyS1lSbVRKbHhI?=
 =?utf-8?B?U21Ya1NHdVo1SHBweE03N3JHNVJ1azJjTEpHR2xJWmZRY1drdVRKUXJ6M29t?=
 =?utf-8?B?V3hacUdyQzhNLzN6UDZqN3BuYjNLbjZmK3lQZG9LZUtMWFA1cGRqSC9zdytn?=
 =?utf-8?B?VERCUG5aMVBjSWRJdyttQUNLMVNnQzdjM3d6S1lSUm9WZlRkZkhoWU44a004?=
 =?utf-8?B?cGlTWmZHdnFTd2wyZEIzSDBZMlI3a1dlUEFjT1ErekpqWTkzTlNOMFF2VUkr?=
 =?utf-8?B?OVVCOUdCZ2lySXRFUVIvM1RjZmVKSk1oRy9uVUw2Ym9CNzk5bFplcit6VWdC?=
 =?utf-8?B?YmVQVkxUcVluczNUNm9SYVdEUFlHdytwRnpjblQxK2hhSzZYSHovV0NRckt0?=
 =?utf-8?B?WTRyOEw1UGpHaEkvYnZUVGFFZ2hkaG12OFBpbXZBS2E3emNJTEJMbTltZFdX?=
 =?utf-8?B?bTE4dWQzbEMzRlhoNWEzSnhHd2hXNWNJRW1mWXpZYnRRV0tQRFJ4R2Mxdjgv?=
 =?utf-8?B?MjdMZEtFbFB2SkttQlVYS0U3RDhqb2NaTDdHMjlWWkRGTkFTNkN4bWkrTXQ3?=
 =?utf-8?B?MGJERVhrV1FFRDRyU2NHb0lCNXVyLzBnOVVlSmVjSXNVZVU4bVB1Mk40RU00?=
 =?utf-8?B?bTVtZ2ZwaHllYzd5STh3Zlc0MllzSHppa2lGd08xRFVGUUJ0L3U3RE9sdXR3?=
 =?utf-8?B?dGVERUtZMXhESzdKRVcrRWJlZTMrVVRFUWpQK2JXV2N1S2Q2RE1BYnNXclpJ?=
 =?utf-8?B?L1J6ZHZmVUpDWVhqRkhuYWYrZ1NkcU03WmRUckFsY1J6SlJGNHhPdlVXaEVv?=
 =?utf-8?B?ZzZlUmZtVkJYMHhCMmZHYTZZc1NtbGJvYUw3MDdueHc4Y2VzYkdHQTBHeDNL?=
 =?utf-8?B?MzFvemxYODFZb0ZwcjlRTVkwWGR1cEl6OVNtMzZTRjcyRVoyaEdXWWdxNkNE?=
 =?utf-8?B?T3JvWE1hN2h3WjVpR3NPUnJIemdpNmgyTDdHWnNZcnVKdm5DTWZjVDA3aEFV?=
 =?utf-8?B?NE1FdWJXbXg2SHJzZFlnQnNCNTV4d3hBb1BxOWhHSGt3OUEzQkNBZnY1ZjBR?=
 =?utf-8?B?eWtLRGZUTmx4OUdhcDNwTEI3YTJLZFVFa0h5QWJaeGVJK2dEdWp6UXZlSGdC?=
 =?utf-8?B?c2VBOWtyMmFGUEF0YUFUUG0yYVFBR1owQU5WejVjT3JLVWl3bjdJNm1obW94?=
 =?utf-8?B?cnlzOFRPME01dFAxQ3NoOFZXVG5zcVZpZGNYL0tTYXdTcGIvOUxzSHVGTmM5?=
 =?utf-8?B?KzZ5SUdLcmlSa285Z2grUHlHVEJwWVhpVjAycUZKVGg3RmpucjJQM3RlMTlm?=
 =?utf-8?B?R1hkQVltTDV3SVpOcDV5NVQxY3hMN2lJZ2p5dk4rc3p0L3pWVFVoek13L3ZG?=
 =?utf-8?B?UFVNblVMSEJWTnljOEU5Tmc5ZDBNRlJ4bUZ5WHYzcjgzS2VHcGFPSDFSeU9O?=
 =?utf-8?B?Znhyak9hZkNxb2c3cUwwZGJ6Q2QrTFduR2FOV3MrOEYvZC9ITWhhbFd3Q1lF?=
 =?utf-8?B?MlIzVkgzUWlEUzJtSzRNVW1GMys0bHBBMkxvcmJ2cTV2MXdVQzQ4OFk1dXVL?=
 =?utf-8?B?QS82d3orU3M1NmN3SmI0UmlmalFHK09XRHNrS29Rc3h5THgzOHdmTmpaRGNa?=
 =?utf-8?B?UTRFTnhjUXFjNjFCMHQ3cjBQNDRTdG82TUF2NHVRT2pueFZvZHdQVHRkM29t?=
 =?utf-8?B?bklvMEozQkRBQUtDc0d6Z0ZISGg4Z1BEZTRReE1uOERlSXdKMXkwZUx2ZXo2?=
 =?utf-8?B?NmhiQjJsSElOdkxRRXBlcEJSWERoK2pCcGxtOUlsaFFzMjdYZ3RHTzFFMkhE?=
 =?utf-8?B?anAyY3d5WFdKbzByeUw5aEh3V05kalBVUjJVeGlqeXlWQ0JURktRYk5IdjFE?=
 =?utf-8?B?MDdZZXFaYUtNcjk5MTFQWlE4eFM5TVROVEQ5dGthNXMxTllTNXdIZ2xYUU1j?=
 =?utf-8?B?cnNLS2l5bFVsR0NsRDQ2S1RRL2xVQWVrRHk5YkYwU0dCNE1yZzdHMU9hUVFT?=
 =?utf-8?B?UlVLTmpDVjl1WElQYjhlbndFeXd0UjdqbFJFQ3pzb1ZYbVZyZXc5OUhFOGZR?=
 =?utf-8?B?Uk1CT3ArQlFVM1NWZ2R3RzhLblA3WEhUK2hET25QVWZDQXJzMkh0Z2RRM0NL?=
 =?utf-8?B?Q0E9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2A74BA47AC484246B3C9AE344EB6AE4C@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?U3RkdjBXQzh2LzU1MGNTRmF6Rlc4aERjYlFGbUZna3M4V2xhRXpqS01jQWRo?=
 =?utf-8?B?UHM0L2htR0FXNU1sNVREK1hXQkRCNnJTN3lxUnFrc2hGUUl3QTVLdjVvODVs?=
 =?utf-8?B?ck9WOVBJWjd3ZkpWOGwySHFFYzF0UWxDSkM0MUMwS0pRUzJzNGhJaUlPc0ZW?=
 =?utf-8?B?TXNYR1BIT0ZNS2RyZ2hTbmdlZ1hEZ1VqMGRUQkRpMDIzcXI4V0hJQnp0N1VD?=
 =?utf-8?B?VzJlWGFrWFRCY0diVkUrbmMzbmZDZVZLZ3VyNC9ZYjB2VEU0dENjdmV0dVdq?=
 =?utf-8?B?S0M0bjlGVDd2THE0anFHTTcrT3FWOU5RcTNpbHB1aHJnVzNJNzdQOGZnL09Q?=
 =?utf-8?B?dytBNTdxSFFBZ3NKOVl5dS91ajY5d3pBK1dHZStybEZvUUI1TjN6VHpQZDNK?=
 =?utf-8?B?dWpXbzRnZ0VEYUwvWDZ3RHhCN2sxbXFpK1hHbENScUFsS2NBOWt0VThkZmdp?=
 =?utf-8?B?T2o2VldyYnhHa0c1QVZpNlVKVmQxZzAveXUxY2ZZbStDT05NSG5tc1R3Rlc5?=
 =?utf-8?B?YkREeDJVRkZWTHhvNUZwakw2SlhxR2xBTXArcllkelA4RnhEMmZZclNtNG9s?=
 =?utf-8?B?OXdCN3AwcUludHZveFJvZk1JLzMzR2E1Q0VkMG1SdzBEYXN5Yng5Rzk1MENL?=
 =?utf-8?B?aTdObm9qa2RtZ3IzUG9raUF2OGFxMStkdFVqbE92WW5aVFlwRHhIb29lWWti?=
 =?utf-8?B?Und3ajE2Yzd6MnlPdkViNC9HSUNFempzQmNjWEQ4OWcwVGsxZmVERkh6WE13?=
 =?utf-8?B?SFZLb1hkQ1I3VnFHY200TEZDNm94bXUxUmRhSzRnVHhVOFg3eUQvMkozekdv?=
 =?utf-8?B?dHl5ODJOekFkRjRIQmRsYzNxSDkwSVBVQUc1a3RuekpiYjh0L0JVNm9xUW5u?=
 =?utf-8?B?UXJMcXdBaE9zUzZYaDhqUng0Z1YzcWlFZDdnSDcvSUlHUVVJeUtVUzZ0N29y?=
 =?utf-8?B?aTd2WjBPcmFtdno0eEFFMVJWY1Z2RmYxSHlHbFM0WTExaHQ0MTZoYysxUjky?=
 =?utf-8?B?Qk1NTi9jcGwyS1ZCV01zWEZWSnZ4K0hOZ0VHbEcrQ2JpTlozQnNxWjBLUmdk?=
 =?utf-8?B?ZlFlemoyc0hCWlZDN0JRRWhXZGVRY2VSWnc3TGp4S1RGc1hmM1BReEJBcHlo?=
 =?utf-8?B?bzQ0bjRtV0xLOGpweStyNjc2M0w0bmVma0wxbCtDUHUrVE5PdFpsU1ltcERG?=
 =?utf-8?B?RlV0V0ZvaGwzbVE3ZEgrejlSU2Y0OFpWNEZCT3VzNXJsMDhqYXUzbFEvTm83?=
 =?utf-8?B?UCs3S0hsckxpZ0FQbmU1Uk5hd2JWMUtRUitHYWZac1NuMno4Zz09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51b4ab8a-3b4f-42c4-189d-08daa6d7db13
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2022 13:45:24.9831
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wfn/JhvR1IxUILXrcuITbnTZYYTKocsvm75pJHZjUOWF7vJpDOwJGei7WBlVoPUd8mbcF8Cl0jUZiri2i8LZpcHvsq6rlnKHaAuiRpbNITs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5230

T24gMDUvMTAvMjAyMiAxNDoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA1LjEwLjIwMjIg
MTQ6NTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAwNS8xMC8yMDIyIDA3OjU5LCBKYW4g
QmV1bGljaCB3cm90ZToNCj4+PiBPbiAwNC4xMC4yMDIyIDE4OjA4LCBBbmRyZXcgQ29vcGVyIHdy
b3RlOg0KPj4+PiBBIGZ1dHVyZSBjaGFuZ2Ugd2lsbCB3YW50IGEgY3B1aWQtbGlrZSBpZGVudGlm
aWVyIHdoaWNoIGRvZXNuJ3QgaGF2ZSBhIG1hcHBpbmcNCj4+Pj4gdG8gYSBmZWF0dXJlIGJpdC4N
Cj4+Pj4NCj4+Pj4gICogUGFzcyB0aGUgZmVhdHVyZSBuYW1lIGludG8gdGhlIHBhcnNlIGNhbGxi
YWNrLg0KPj4+PiAgKiBFeGNsdWRlIGEgZmVhdHVyZSB2YWx1ZSBvZiB+MHUgZnJvbSBmYWxsaW5n
IGludG8gdGhlIGdlbmVyYWwgc2V0L2NsZWFyIGJpdA0KPj4+PiAgICBwYXRocy4NCj4+Pj4gICog
SW4gZ2VuLWNwdWlkLnB5LCBpbnNlcnQgYSBwbGFjZWhvbGRlciB0byBjb2xsZWN0IGFsbCB0aGUg
cHNldWRvIGZlYXR1cmUNCj4+Pj4gICAgbmFtZXMuDQo+Pj4gSG1tLCBJIHdhcyBlbnZpc2lvbmlu
ZyB0aGlzIHRvIGJlIGZpdHRlZCBpbnRvIHRoZSBleGlzdGluZyBtb2RlbCBpbiBhDQo+Pj4gbGVz
cyBhZGhvYyB3YXk6IChwYXJ0cyBvZikgTVNScyBob2xkaW5nIGZlYXR1cmUgYml0cyBhcmVuJ3Qg
dmVyeSBkaWZmZXJlbnQNCj4+PiBmcm9tIGluZGl2aWR1YWwgKHBhaXJzIG9mKSByZWdpc3RlcnMg
b2YgQ1BVSUQgb3V0cHV0IChpbiB0aGUgY2FzZSBvZg0KPj4+IEFSQ0hfQ0FQUyB0aGVyZSB3b3Vs
ZCBiZSBhIHBlcmhhcHMganVzdCBhYnN0cmFjdCBtYXNrIGxpbWl0aW5nIHRoaW5ncyB0bw0KPj4+
IHRoZSBzdWJzZXQgb2YgYml0cyB3aGljaCBhY3R1YWxseSBhY3QgYXMgZmVhdHVyZSBpbmRpY2F0
b3JzKS4gSGVuY2UgSSdkDQo+Pj4gaGF2ZSBleHBlY3RlZCB0aGVtIHRvIGdhaW4gcHJvcGVyIGVu
dHJpZXMgaW4gdGhlIHB1YmxpYyBpbnRlcmZhY2UNCj4+PiAoY3B1ZmVhdHVyZXNldC5oKSBhbmQg
dGhlbiBiZSByZXByZXNlbnRlZCAvIHByb2Nlc3NlZCB0aGUgc2FtZSB3YXkgaW4NCj4+PiBmZWF0
dXJlc2V0cyBhbmQgcG9saWNpZXMuIEFsbCB0aGF0IHdvdWxkIGJlIGxlZnQgb3V0IGF0IHRoaXMg
cG9pbnQgd291bGQNCj4+PiBiZSB0aGUgZXhwb3Npbmcgb2YgdGhlIGJpdCB0byBndWVzdHMgKGlu
IHBhdGNoIDIsIGFzc3VtaW5nIHRoZSBzcGxpdCBpbnRvDQo+Pj4gdHdvIHBhdGNoZXMgaXMgdGhl
biBhY3R1YWxseSBzdGlsbCB3YXJyYW50ZWQpLCBpbnRlZ3JhdGlvbiBpbnRvDQo+Pj4gZ3Vlc3Rf
cmRtc3IoKSwgYW5kIGF0IGxlYXN0IHNvbWUgb2YgdGhlIHRvb2wgc3RhY2sgc2lkZSAoeGVuLWNw
dWlkLCBmb3INCj4+PiBleGFtcGxlLCBjb3VsZCBlYXNpbHkgbGVhcm4gb2Ygc3VjaCByaWdodCBh
d2F5KS4NCj4+Pg0KPj4+IEhvd2V2ZXIsIHNpbmNlIEknbSBwcmV0dHkgc3VyZSB5b3UndmUgY29u
c2lkZXJlZCBzdWNoIGFuIGFwcHJvYWNoLCBJIGd1ZXNzDQo+Pj4gSSBtaWdodCBiZSBvdmVybG9v
a2luZyBzb21lIGNhdmVhdD8NCj4+IEkgaGF2ZSBvbiBtdWx0aXBsZSBvY2Nhc2lvbnMgY29uc2lk
ZXJlZCBwdXR0aW5nIE1TUl9BUkNIX0NBUFMgaW50byB0aGUNCj4+IGV4aXN0aW5nIFg4Nl9GRUFU
VVJFXyogaW5mcmFzdHJ1Y3R1cmUuwqAgSW4gdGhlIGZ1dHVyZSwgaXQncyBsaWtlbHkgdGhlDQo+
PiByaWdodCBjb3Vyc2Ugb2YgYWN0aW9uIHRvIHRha2UuDQo+Pg0KPj4gSG93ZXZlciwgZG9pbmcg
c28gbm93IHdpbGwgYnJlYWsgc3BlY3VsYXRpb24gc2FmZXR5IGZvciBndWVzdHMgaW4gc29tZQ0K
PiBDb25zaWRlcmluZyBmdXJ0aGVyIHRleHQgLSBzL3NwZWN1bGF0aW9uL21pZ3JhdGlvbi8sIEkg
Z3Vlc3M/DQoNCk1vcmUgInNwZWN1bGF0aW9uIHNhZmV0eSBvbiBtaWdyYXRlIi4NCg0KRXhjZXB0
IGl0cyBub3QganVzdCBvbiBtaWdyYXRlLsKgIEl0IGNhbiBnbyB3cm9uZyBmb3Igc3VzcGVuZC9y
ZXN1bWUgb24NCnRoZSBzYW1lIGhvc3QgYWNyb3NzIGEgcmVib290IHdoaWNoIGNoYW5nZXMgdGhl
IG1pY3JvY29kZSB2ZXJzaW9uLg0KDQo+PiBjYXNlcy7CoCBUaGUgZmVhdHVyZXNldCBBUEkgaW50
ZW5kZWQgdG8gYmUgc2FmZSB0byB0cmVhdCBhcyBhIHJlZ3VsYXINCj4+IGJpdG1hcCwgYW5kIHRo
aXMgaXMgaG93IGl0IGlzIHVzZWQgaW4gcHJhY3RpY2UuDQo+Pg0KPj4gSG9uZXN0bHksIEkgZGlk
bid0IGltYWdpbmUgdGhhdCB3ZSdkIGdldCBiaXRzIGxpa2UgUlNCQSBhbmQgUlJTQkEgdGhhdA0K
Pj4gbmVlZCB0byBiZSB0cmVhdGVkIHdpdGggb3Bwb3NpdGUgcG9sYXJpdHkgdG8gYmUgbGV2ZWxs
ZWQgc2FmZWx5Lg0KPj4NCj4+IEV2ZW4gaWYgd2UgZG8gZW5kIHVwIHB1dHRpbmcgTVNSX0FSQ0hf
Q0FQUyBpbiBYODZfRkVBVFVSRV8qLCB3ZSBzdGlsbA0KPj4gbmVlZCB0byByZW1vdmUgdGhlIGZl
YXR1cmVzZXQgYXBpIChyZXBsYWNlZCBieSB0aGUgY3B1IHBvbGljeQ0KPj4gaW5mcmFzdHJ1Y3R1
cmUgYW5kIGxpYng4NikgdG8gcmV0YWluIG1pZ3JhdGlvbiBzYWZldHkuDQo+IFdlbGwsIEkgZGlk
bid0IG1lYW4gdG8gc3VnZ2VzdCB0byBwdXQgYWxsIG9mIHRoZSBmZWF0dXJlLWxpa2UgYml0cyB0
aGVyZQ0KPiByaWdodCBhd2F5LiBKdXN0IHRoZSBvbmUgYml0IHdlJ3JlIGFmdGVyIHdvdWxkIGRv
IGZvciBub3cuIEFmYWljdCB0aGF0DQo+IHdvdWxkbid0IGFmZmVjdCBtaWdyYXRpb24gc2FmZXR5
LCB3aGlsZSBpdCB3b3VsZCBhbGxvdyBkb2luZyB0aGluZ3MgaW4NCj4gWGVuIGluIGEgbW9yZSAi
bmF0dXJhbCIgd2F5Lg0KDQpUaGF0IHJlcXVpcmVzIHJld29ya2luZyBob3cgdGhlIE1TUiBwb2xp
Y2llcyBnZXQgc2V0IHVwLCBwYXRjaGVzIGZvcg0Kd2hpY2ggaGF2ZSBiZWVuIHN0YWduZW50IG9u
IHhlbi1kZXZlbCwgYXMgd2VsbCBhcyBhIHJlYXNvbmFibGUgYW1vdW50IG9mDQpwbHVtYmluZyBi
ZWNhdXNlIHRoZSBmZWF0dXJlc2V0PC0+cG9saWN5IGNvbnZlcnNpb25zIHdoaWNoIG9ubHkgaGF2
ZQ0KQ1BVSUQgZGF0YSByaWdodCBub3cuDQoNCklmIEkgZ28gZG93biB0aGlzIHJvdXRlLCByZWFs
aXNlIGl0IGlzIGdvaW5nIHRvIGhhdmUgdG8gZ28gb3V0IGluIGFuIFhTQQ0Kc28gd2lsbCBiZSBi
YWNrcG9ydGVkLCBhbmQgdGhhdCB5b3UncmUgYWxzbyBjb21taXR0aW5nIHRvIHRha2luZyB0aGUg
Vk1YDQpNU1JzIGluIGR1ZSBjb3Vyc2UuwqAgKHdoaWNoIGlzIGFsbCBvbiBteSBwbGFuLCBidXQg
SSBkb24ndCB3YW50IHRvIHN0YXJ0DQp0aGUgd29yayBub3cgYW5kIGhhdmUgYW4gYXJndW1lbnQg
ZG93biB0aGUgbGluZS4pDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:52:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:52:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416255.660902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4oZ-0000KN-ST; Wed, 05 Oct 2022 13:51:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416255.660902; Wed, 05 Oct 2022 13:51:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4oZ-0000KG-Pe; Wed, 05 Oct 2022 13:51:59 +0000
Received: by outflank-mailman (input) for mailman id 416255;
 Wed, 05 Oct 2022 13:51:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xhym=2G=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1og4oY-0000KA-Sc
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:51:59 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfd3d467-44b4-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 15:51:57 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 45833320093E;
 Wed,  5 Oct 2022 09:51:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 05 Oct 2022 09:51:54 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 09:51:52 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfd3d467-44b4-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664977913; x=
	1665064313; bh=7zNKsxib9beHGDHPELkCeUD0PEqHdjwG9OqgD/jvckY=; b=m
	0FEJumNrvbcjU9AYckbnihxE/qS0BPyx7w8GtqAB6VHhtE/K5zjwwPEDz42EVpWN
	J6icD0AfAV4oAb4VCM3jlPn+OdkHaF3KuDCNrUh6/7piz3f+71O3ayQ23mceWmIx
	+M0A5BYGX4uNw7v75ZP3xNVTFWQIDIizfhxyaIumxKdBQjRIW6r7IfNcKd2DxTAx
	Sx+FbqIcaMBoYRROpWE1wCIUdrFSEe9b/8oaMvSqHXey5HQGM7MypfAkYNSwlC6t
	k4mxTwzwior/eQFpBDOxJWumRlCzEaFW46YBB7dsR5tKmYFyb893sxT1Rd0GeEPt
	zYkrqvRAg/rVFm1KCRZwg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664977913; x=1665064313; bh=7zNKsxib9beHGDHPELkCeUD0PEqH
	djwG9OqgD/jvckY=; b=dvUueFk+ud0dLI35Au5W4QsiyKcEOcZwxkFd2tRmiqWL
	C6WULuL6Vl3i0W/MY9NhNY1JL1LcGKLQFRDwUa2veaj51edhfwnEmFVtKxO279Nd
	lI03g945fGyGkq3NGlQ7l0iETW93R8iLyfvIFQE30acEvrKKEbYhkGyedUrol/Vx
	R4V96IugG0aSO4B0rTz4IzOYAg2fEzXWhEBQ4kvPOXRzs2ecYGO1Vk4jSK/s9tkG
	NCITyHYz1NxGQgDUIYf+LL51S0AR7TfQ4Q2z41Nj8L3szquFfDLXJSc9dCpXVxc2
	S2U2ZMZJj9V5QvhzSCfMOdnnnclGY/iUoshnIObkTg==
X-ME-Sender: <xms:-Ys9YxrFn0jlg2Ew49AUoQEiRLmVjo0PrhDg4vs263O61gaCqApwCw>
    <xme:-Ys9YzpkCv9RvrbkpeUNclMga1mLFNVS8H_5ajKoIONVI6GF5X1YffPx9EGYkpU_p
    hiGVDumNJbdcQ>
X-ME-Received: <xmr:-Ys9Y-MgUZbGry_oxOcEz0PaiVpS1ikXX8662HPakNqcsjPyQYFF84mQMd0bYk-I61z7q8JBX4eAnlHWEIc05XpGYqEh4EykeJ33>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgieekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:-Ys9Y85ePlRAfY6c2PnRxtLW92tJqPaEGrgUYWF9u-dBrmJAJNWSIg>
    <xmx:-Ys9Yw425y0p_F-afIdLo-KQyWpay9tkf32HPv-B4_VXEc-8xGbPQw>
    <xmx:-Ys9Y0g00b_z0lfDMeg9gGeBpBQ_4i2wmXfSe3uzZJPSF_36EPS0nw>
    <xmx:-Ys9Y1UkvUZ6QQ3WDhcVG_zAdVAeqCBfRPNHrvR121eDaatvBRE1Pg>
Feedback-ID: i1568416f:Fastmail
Date: Wed, 5 Oct 2022 15:51:49 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
Message-ID: <Yz2L9eTdbA3vS43g@mail-itl>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>
 <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="HofWzEIQsP1FKqvm"
Content-Disposition: inline
In-Reply-To: <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com>


--HofWzEIQsP1FKqvm
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 15:51:49 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt

On Wed, Oct 05, 2022 at 03:34:56PM +0200, Juergen Gross wrote:
> On 05.10.22 15:25, Marek Marczykowski-G=C3=B3recki wrote:
> > On Wed, Oct 05, 2022 at 02:57:01PM +0200, Juergen Gross wrote:
> > > On 05.10.22 14:41, Marek Marczykowski-G=C3=B3recki wrote:
> > > > Hi,
> > > >=20
> > > > When booting Xen with Linux dom0 nested under KVM,
> > > > CONFIG_XEN_VIRTIO_FORCE_GRANT=3Dy makes it unable to use virtio dev=
ices
> > > > provided by L0 hypervisor (KVM with qemu). With PV dom0, grants are
> > > > required for virtio even if just CONFIG_XEN_VIRTIO is enabled.
> > > >=20
> > > > This is probably uncommon corner case, but one that has bitten me i=
n my
> > > > CI setup... I think Xen should set smarter
> > > > virtio_require_restricted_mem_acc(), that enforces it only for devi=
ces
> > > > really provided by another Xen VM (not by the "outer host"), but I'=
m not
> > > > sure how that could be done. Any ideas?
> > > >=20
> > >=20
> > > It should be possible to add a boot parameter for that purpose. Using=
 it
> > > would open a security hole, though (basically like all PCI passthroug=
h to
> > > PV guests).
> >=20
> > What about excluding just dom0? At least currently, there is no way for
> > dom0 to see virtio devices provided by another Xen domU.
>=20
> Even not via hotplug?

That's why I said "currently", IIUC hotplug of virtio devices under Xen
doesn't work yet, no?
With hotplug working, it would need to be a proper detection where the
backend lives, and probably with some extra considerations re Xen on
Xen (based on below, pv-shim could use grants).

For me specifically, a command line option would work (because I don't
use Xen-based virtio devices when nested under KVM, or anywhere at all,
at least not yet), but I can see future cases where you have virtio
devices from both L0 and L1 in the same guest, and then it wouldn't be
that simple.

> > Something like this:
> > ---8<---
> > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
> > index 9b1a58dda935..6ac32b0b3720 100644
> > --- a/arch/x86/xen/enlighten_pv.c
> > +++ b/arch/x86/xen/enlighten_pv.c
> > @@ -111,7 +111,7 @@ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_=
desc);
> >   static void __init xen_pv_init_platform(void)
> >   {
> >          /* PV guests can't operate virtio devices without grants. */
> > -       if (IS_ENABLED(CONFIG_XEN_VIRTIO))
> > +       if (IS_ENABLED(CONFIG_XEN_VIRTIO) && !xen_initial_domain())
> >                  virtio_set_mem_acc_cb(virtio_require_restricted_mem_ac=
c);
> >          populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));
> > ---8<---
> >=20
> > This BTW raises also a question what will happen on Xen nested inside
> > Xen, when L0 will provide virtio devices to L1. Grants set by L1 dom0
> > wouldn't work on L0, no? Or maybe this is solved already for pv-shim
> > case?
>=20
> This is a similar problem as with normal Xen PV devices.
>=20
> You will need either a simple grant passthrough like with pv-shim (enabli=
ng
> such devices for one guest in L1 only), or you need a grant multiplexer in
> L1 Xen in case you want to be able to have multiple guests in L1 being ab=
le
> to
> use L0 PV devices.

This will be tricky, at least with the current frontend drivers.
Frontend kernel is in charge of assigning grant refs, _and_
communicating them to the backend. Such multiplexer would need to
intercept one or the other (either translate, or ensure they are
allocated from distinct ranges to begin with). I don't see how that
could be done with the current domU kernels. That might be better with
your idea of multiple grant v3 trees, where the hypervisor might dictate
grant ranges.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--HofWzEIQsP1FKqvm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM9i/YACgkQ24/THMrX
1yzgVggAkBzHdP1F6YkUsHYjS9rMObic/RPHL61m5NrAc+/J8qsVlVCbkWdkk3OZ
f4uLe2m94gLrgfXW9E2MjB6SjW+SJrlgvQFb0F/0KSzNxJ4+jLvlcSzIX042xfc4
4BKp1mr4LPezQcis0o0VM5TqrJYziF6VcjCSnGYwSb/r3S94W+Ot1CTOmm1us1hN
u0v0U/9qYpH443B+6VKXQfz/cof4uxhE024SQeqLBf/iR70d0gWIJp6hSIm2k3Y4
loMHspmfoY/2Uk4jkvQB/enn+XMvhksHzr0Bpa6JL3+WN4whTrRyZAa9xgfuA/Zi
Qcx5JwHzSsIRDX56PKJjK62Au7RgbA==
=l5Cf
-----END PGP SIGNATURE-----

--HofWzEIQsP1FKqvm--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 13:53:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 13:53:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416262.660912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4qC-0000tQ-6b; Wed, 05 Oct 2022 13:53:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416262.660912; Wed, 05 Oct 2022 13:53:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og4qC-0000tJ-3z; Wed, 05 Oct 2022 13:53:40 +0000
Received: by outflank-mailman (input) for mailman id 416262;
 Wed, 05 Oct 2022 13:53:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NzUo=2G=citrix.com=prvs=27000a6ca=roger.pau@srs-se1.protection.inumbo.net>)
 id 1og4qA-0000tD-Kz
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 13:53:38 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b377bc8-44b5-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 15:53:37 +0200 (CEST)
Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 09:53:34 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BL1PR03MB5990.namprd03.prod.outlook.com (2603:10b6:208:313::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 5 Oct
 2022 13:53:29 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022
 13:53:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b377bc8-44b5-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664978017;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=9wsRYVWxaHyD76ELy4H1JP8yf3tq4MK3mJc/65W1nDk=;
  b=Xhzu7LPiAlIGfQz8gFfBCr7lohctndU1rbW8x4BkmGEIko8g2suWkflG
   8QD0BfyE+J/W33sE7a55aSptxx09USqXPuAOcD4hbTO2bh1diGtXSGkbg
   z8UZb38pSOMHFFrZCxk7f8Hbre+628RPjTtKO5ZTo3F81EzAoC8q1Flph
   c=;
X-IronPort-RemoteIP: 104.47.66.47
X-IronPort-MID: 82016701
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:aXdY2qiWUQBSpWl1tSSKyM3jX161ihEKZh0ujC45NGQN5FlHY01je
 htvCjvQMqnfZzP3KIpyO4SwpEhUv5HTytY3TgVo/i9hQS8b9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmPa0T5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUdM7
 NYiJB1XVyGeiNmO8oi9afRz3f12eaEHPKtH0p1h5RfwKK98BLX8GeDN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvTaVkFMZPLvFabI5fvSQQspYhACAr
 3/u9GXlGBAKcteYzFJp91r83LeWw3yjAer+EpWfp9xOvVG27FcMIw85BUu/uf6YoVWXDoc3x
 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbBRMddgnv88eXiEx2
 xmCmNaBLSNrmK2YTzSa7Lj8hRO/PzIEa1ALYyAsRBEApdLkpekbixvVS995Ha2dj9vrGCrxy
 TSHsCg/gboIiccBka68+Djvjz+pp7DISBA0/QTdWm+57gJ/a5Whbobu4l/ehcusN66cR1iF+
 X0bwc6X6blUCYnXzHDSBuIQALuu+vCJdiXGhkJiFIUg8DLr/GO/eYdX43d1I0IB3ts4RAIFq
 XT74Wt5jKK/9lPwBUOrS+pd0/gX8JU=
IronPort-HdrOrdr: A9a23:t/DmeK1xp3m1a6QivB2A9AqjBdJxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp
 uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6
 Dsm/av6gDQD0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G
 DZm0ihj5/T+c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd
 HQq1MLPth16VnWYmapyCGdkDXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZ8fgHC40Qtkdlg2O
 YTtljp/6Z/PFflpmDQ9tLIXxZlmg6dpmcjq/caizh6XZEFYLFcgIQD9Ad+EYsGHgj99Ic7ed
 MeRf301bJzSxe3fnrZtm5gzJiFWWkyJA6PRgw4tsmcw1Ft7QVE5npd4PZasmYL9Zo7RZUBzf
 /DKL5UmLZHSdJTRb5hBc8aKPHHRFDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop
 LcS1lV3FRCNH4GMff+nKGjzyq9A1lUBV/Wu4NjDtlCy/HBrYPQQGy+oAtEqbrknx0daverKc
 pbdqgmR8MLFlGeabqh7zeOJaW6FkNuIfH9muxLL25m8fi7XbHCh6j8TMv5AobLPHINZl7fa0
 FzLwQbYv8wo3yWZg==
X-IronPort-AV: E=Sophos;i="5.95,159,1661832000"; 
   d="scan'208";a="82016701"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n4CsF6bYBWZ6u9L7SRiIeNVfTA5u5ZyxgBTNHf2AyXe2t0TJyTkFG2VQ3dS4Mfmx7DrsdddNSWB1S8bl/TPprFGiS1kGOKTt0U4Zpsyc52zOUyUttnrcJdEkScdo9kbfhv7LewV3Nnt9J3nMP6eFlLLn87f+AfqmUJlglVi5bbupi1nZo69EkrAC30jM+5uqxavaQ/f0FRv55TcYvxVbnKyGCuowzw5usojBhdyjb7UKK54s/FzKyiDlK5ZQk7EckHSgpJQsjIXFp3EBtgqBHiXFLQUSBFNoUOW/wzoeiYsGHu3oEsAmbVh6vmL6Wi6lDKnNfLa/502anCWagyqy2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=inVV5Ie3QYghmXNDUIr67TzbUUcoGvEHtnoUDnuNlpo=;
 b=R1hHuQ3VjO75RiOFb2SJG2VPoEaRGyEcyDbxk6R1WEqvKesO4CD92hgWgZB7f5zW0TNhV47TZZV18pdsVQMs/gselZtrj15W8nhd8bcsRIlc1HFNQi9OQ0i3AndLa28EY9ROM/OfQ1QzGiMCdh278uCf/ARycBd6kXnCOukXMlvYtAmbTsZ41yROPxiJ0mdUzhLAcBeW7JSM2mMhbOgUrJPyPLl+9JKYkACuEY8tuT0Ar2aY97NVmqZWA+OT90ohyCOIRcUCnycn24cH6ryKk4S6FusLtaBwaEVws4+qKQEF2IjhKqLQS1E+pvb42vLRnYUvPVuX1Hfcp7HsK0IQ7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=inVV5Ie3QYghmXNDUIr67TzbUUcoGvEHtnoUDnuNlpo=;
 b=ge0e3/GQfiVCUA5aCcdy99v3xTLOqiqmU8tbQNrW2/jcftgJFPbdeFtvwgSZmPdoo8UkhNxcohteTUTLKOwwEV6F8LkLBbUHSR/ZR0qU5aHYfcKRbeleU6KRcguZgfMPXTgbi5GqiUwCN0js2l/PTHaMGSuR1PIdOYjsZzqRO/0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 5 Oct 2022 15:53:19 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Demi Marie Obenour <demi@invisiblethingslab.com>
Subject: Re: [PATCH 1/2] x86/cpuid: Infrastructure to support pseudo feature
 identifiers
Message-ID: <Yz2MT9oIH/ofJmQ9@Air-de-Roger>
References: <20221004160810.25364-1-andrew.cooper3@citrix.com>
 <20221004160810.25364-2-andrew.cooper3@citrix.com>
 <Yz1Uoma3S4Wgmr4F@Air-de-Roger>
 <0ff7672e-46b8-d74c-ec66-75a1bec8b557@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0ff7672e-46b8-d74c-ec66-75a1bec8b557@citrix.com>
X-ClientProxiedBy: LO4P265CA0211.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:33a::7) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB5990:EE_
X-MS-Office365-Filtering-Correlation-Id: 3959822f-a5cf-4db0-6a4c-08daa6d8f975
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	udAEEkOSh2lzpCAN9i7EgqZMOlpIQIzDIWBgH0ZZcC0uYtdnXlV7u5t6y6VYjF0yf6mVnvXSJ/oegS+l+L3d8KU295M5y5vGD7zcnJDbJbTeMbvqAYtYoG6tmkIbvmjnFqThEXt5Sy+WP8QGiF0bkInMwsJv/sfQv+OVB0+ffMKgTzCj2+z7Soipvb2s44rDOMB1xnXKBeXi8v4WYparAuEB3cUbl771mflqF6bL6z6BFjOPN+kEVoJ5fSzQcv66iDtvZ/iz8alzv/VDIbthz++9tPPIWvAyMBBOkQPpDLVvTKnLPwoLHRV8xS8uPaHPfHwVvSySKoD5ysq9bXicaBVcRVxIUrO9xYWFXQifcqw4ixRNMi1bZ0Pr8Az/MZoI51CdGfBWGbztBjGuuduVS52pkwKwO5bLGusdL7cJOlRf8xfEYHuLaDFYA4ZMGxTfo9UEil7qJLvPr5H2YKWw4KWLHAI6InLZMYxu9mYRp9Y1I3//W9NgjO1FL2sGA0QxApBbI8aQ0j3eZtONsYloe6iuBDxq9ECU7J7hQN3DCxK8McIYDhAr2gr+VXAIzSXed476H2aG6a7Zvk0Hd6bsDlfQiVj3rNsQq7V9OiiXbMTl3gb0Wg8D1sh5pkud2o0Wyk/JKLiD+iCYb1yH50CHu3uwcLYj0UGDfWT/EYS7JeGk70f+8AL93pej0gR+yZAEpnZVEU0D+umAGPh4QYS5Kw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(346002)(39860400002)(376002)(366004)(396003)(451199015)(66946007)(8676002)(6506007)(6512007)(54906003)(4326008)(26005)(2906002)(6666004)(66476007)(33716001)(9686003)(85182001)(316002)(8936002)(186003)(38100700002)(5660300002)(66556008)(6862004)(82960400001)(4744005)(53546011)(41300700001)(86362001)(6636002)(6486002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TDA0V2pDS3RWL0JSaE5uOWZrYlk1cWMwSjM3OGFBZWR3S2lPYnJzOVVZdTFj?=
 =?utf-8?B?aXVvclJqWHVBZEZwRVZrWUVCVFFodVQrT0JGLyt4OWY1dEoyNzluS09jdkw3?=
 =?utf-8?B?MlJRdzlValZESndhdTdMcFJqRTlaTnJwdHBxc2F1UGQ3UWJZZlhMeU1YMUNp?=
 =?utf-8?B?U3FLendBZklaYUxLM3JZTE04TmxsRXNXSFd6Q3p3TEJIVEhQQTQwTzJhdkx0?=
 =?utf-8?B?dkNrVElNN2I4NS80K0h4STJMSXY1d2hQVGtPeEZrNXRNaUJnSTFmbFMycmxh?=
 =?utf-8?B?Wis1Y0FFUzZXS3kyTDVURDEvSWtRUUhNNGRHZWNtbmdaT0FjaTROMi9EazYv?=
 =?utf-8?B?OXg5MFlYZkRVT3A5Ky9QUklPSW1TSmRWYVFXbnhERUsyLy9XUS9zSDdheURE?=
 =?utf-8?B?WHFidERmdVJGa1IyRkhxbFVkKzIxREdDUUlYZnlZWkZscHV2T04rd3VjK0l6?=
 =?utf-8?B?cDVRNldyWUZvOVIwRmU4RStkSHRHenRCTGphL0tuVGVia3c4aHVEQ1k2VUd1?=
 =?utf-8?B?dmdLMmt6SW1rZjRocHhFbE0rb3RjOWVCcGxnaHgxMWUrMUl2TWROZzlPVWha?=
 =?utf-8?B?RC9hTkF3Qml4aDJoTE01ajU0OFA5dmtaWlFacW5yd1NTMUdjakFBQkhUL0J0?=
 =?utf-8?B?Y2p6NzRaSzRMUjNZVG9hR2RRNGs0ME9lU2tDbldKRzVwZ0s2VjcxK1M5TGU3?=
 =?utf-8?B?WVNseGs0OVJ6R1l6bWhPTEkycWRCYW9hVjA5ODNzT2JMRzZkU3dsZ0ZuVHdw?=
 =?utf-8?B?a1VOdTVaNWhpSE1yUUhXQWErNEpyUVljMGdGdUdUcDUrcWFzTDEwVG9aRCtS?=
 =?utf-8?B?SFZEVzVJenZSV01BcWxyajk2SkU2L2F6MGVIdElIamhvazNSblYzeDkzYkRV?=
 =?utf-8?B?Q0J2RHZUbzd5SWVYV3R0blZ3R0xaMlY4aittN1U0cTlzdWJxOWt2Zmtpam9I?=
 =?utf-8?B?V0lqdjVnU2Zvd1RHYUpSZVVXZ3dXSzEvRWhnZHNxWHRiOHZSTkt6V3liaGlM?=
 =?utf-8?B?ZUVWSkRabEVNditmcURqSE10RUliakNTdSt1YUtRWVk1elRsOXhQZDBWaXhl?=
 =?utf-8?B?RXcwMmJ3MGc0ZzdEMENUaEIzbnM4aERyNzVJM1JCQkYyNUpMS2Y0dDdyNkxV?=
 =?utf-8?B?ZnQ2K2dGMW1NNkFFU2QwWEswL0RkU3BBL2dKTndLVXdDY3gvNlhEeHNXaExN?=
 =?utf-8?B?ZEZKc3VsdFVjVEVZbFhTT3ZEb0k4OGlmaG0vS3hCOHVLWlBGUnpiWVdUTjha?=
 =?utf-8?B?VC91NEFxQnJvcFQrZWRKaSsvS0FZR0VDbUdpeUNVSkxqRDNzMnN6UXhET1hR?=
 =?utf-8?B?SEdNNTBzR2g5ZzlhcGFCRTR3K3ppT21MZkR4M29ud1B1eWdXRGhrUDMyNkVD?=
 =?utf-8?B?bE5RVktQY0grdTNUVnlmWkdWMTZrTG1McnQ4NmY4ZTRra21Lb2ZEZEx0QzRn?=
 =?utf-8?B?dmJCVzE3V1VPOUdsbkp6NkpMS245YXovVVZBZE1pYUdSZ1c2MmJ1cVA1WlBu?=
 =?utf-8?B?SGduQStYeHEyTHJ0c3lRNFlWOW5QSmFBZDVibEVTMUI0ZmdJejE5V2NiSTNo?=
 =?utf-8?B?VWJPYVZBSHV6NHBYbEVLYldDQWI3dVFOSVhEUGlSb1ZQaWswSndjK1FJY3U2?=
 =?utf-8?B?UWFkVTRqc2NUZ1NYeVQxVUVxdVE0YmdURDZOVEdlOUFUN0xydEVSeXBLVmll?=
 =?utf-8?B?SEVnT1JzT0FPL0MxZmw0TGNvRHpEQjRlT2ZzakNSLytBemUzcGdxcnV5Sm14?=
 =?utf-8?B?N3E0anhjaHdOWkVaeUh0cnhHbVY0Mkh6ekdMQ0ZLMlROdzBpa2poNm9sZHhF?=
 =?utf-8?B?UWQ0L1FWTGFuMTlCaGhkTGZ0cnFWOWltdnRmRXFOWEgwOUlhaW1SdGJEOWVj?=
 =?utf-8?B?RjdLNzRJN2dJUExwampWTDRtWi9maFVrQ0gzbEcweERlSWxhWDg5a1orY0M0?=
 =?utf-8?B?c0JCQnZlbUtxWndpRXhCRmVyOWFPbTBKNDZ6WW9qUWd2dlQ3L05KRWd4QXE5?=
 =?utf-8?B?d1hJZkJncGxtek1NN2ttRDZtTExVa0NaUGJIcDdMUkRSWm1BQ3ZVOVdXekUv?=
 =?utf-8?B?cXZoL1orZjM3SzFtNEFoYlVtQllIVFJzMXRSSlRRQmNwT084OUVGZWNUV0Zm?=
 =?utf-8?Q?6fKtI3DEbPZU2558AwpfxnkIF?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?UHh6UEFtTjArY1RsdkVsYTVmcHNWd2pVR01vbloxOXZVRWllbzYxVC8yd1My?=
 =?utf-8?B?R1RXWktGazFyanhtbHdWSVk5REk4QWo5OWtSYS9xYlMza2tMaG5TeFdBblFu?=
 =?utf-8?B?b2l5QzcrM0xieU9MTzhxeWxKdGNUSm54RE5sVEJmMVlqODRTTENSQVh4Z3Nv?=
 =?utf-8?B?OEFpNWpCNFZDVnVNWHA0M1I2REJsRDl5OG9WejdJS2xrZjJyT1pYdU4rNTJX?=
 =?utf-8?B?NGwyUmUwMEhRNjJyWmt0T2l1TExaZ1ZvNVpvTHVtK1NCRGs0emNjMmovUWl5?=
 =?utf-8?B?bTcyeldNQ29ha2lFSTZWdE8rSWNxL3lwQXZnUEJsTjBMZXdlQUd5MDdaalhv?=
 =?utf-8?B?WlFYN2lpL0FaRkVBYStCbnhNYlZyeHRVdkkrQ3ljZHhzRWUwS0ZNZWVveFFV?=
 =?utf-8?B?V1hyV1orOElqeDI2NjZlNnhDNFFyLy83ZWQ5NkJRZldXTlloSUp4NVVER3VU?=
 =?utf-8?B?bVU4WFdObGdubUVJanJvSEZ1aWxCZVdQa0todFFTS3ZXUzJ5SE5UcklXWENL?=
 =?utf-8?B?Nll1aGpzYXNpWW9ZZmE0aVFoWjFkQWVxTFdvLzhUeklQcVRJQVo0aGtCMU4z?=
 =?utf-8?B?QllFcmtDbnF5aFFncTRNVlhHNGZvVjlGcHUvcHp6S3RwS0JUNEFIV1RUcURB?=
 =?utf-8?B?N3pSTjVtNGRWNzdMeG1XaTkyeDExdVlvU0NNK3RRNXVQMEMvRVl2Wk9ZQ0pK?=
 =?utf-8?B?elRBVzhiMFlkenZNM05YZTBpdXp3ZWZrNXByN0t5S0U2OThoelpFcTdhSFpH?=
 =?utf-8?B?ditoNUhFUU1qZ1VFUzFQSE5TSDBiU2pLd3hyQ0lzQUxFN1llMTFoTTBoMTlk?=
 =?utf-8?B?blJXWnVETW53VG80eDUxYTVPUHdFNGZpYXZGUVBnRmw4TzlKSnZjZlFpbmxv?=
 =?utf-8?B?b3RrdkltOFVoR1ZXa1RpNURqMkErMG05YWxCQ2pna05JNUxQangxLzdSRWNK?=
 =?utf-8?B?MStxbFpPZEFiM0JHdnhFc2FOWTJPRlJLYmMvRnlybHZ2MStkQVhvMzJHVlFn?=
 =?utf-8?B?NXM1WlFKeFZFVXEyOWthaEdWbkhFelRPVGR2Vzhyb0twY1Q0TEUrRWo3UGhT?=
 =?utf-8?B?bndxclVTM3VjSW5UclZTVktDVFdUYjF0MU9vOW9CdHNES1FkVFZpeXFRU0tz?=
 =?utf-8?B?eGJiSzc3Mi9ZRzNTdi9MNWQ1MnNBekFodlZSQ1RKaE5ldzVPZldvK1JEazNS?=
 =?utf-8?B?eTZaSVcremhFMlU2U0xLck10OEZJdFRxTy9COFRWSWt1M1VXR1NZYTU1OHla?=
 =?utf-8?B?cjRkMFlBM2JUQUpWZWJuS1JLT1Zzd2kwQkw0RzdqYzhuV0JwUT09?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3959822f-a5cf-4db0-6a4c-08daa6d8f975
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 13:53:25.7058
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: liSD2HJgqwMNLlIylRruKRiVKhChXAosvSYnMNtNf8wnfglYQRhQ7t5Q2/DfQ3+hj8QODS83TZ5x9UZ+7kB+yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5990

On Wed, Oct 05, 2022 at 01:34:06PM +0000, Andrew Cooper wrote:
> On 05/10/2022 10:55, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 05:08:09PM +0100, Andrew Cooper wrote:
> >> A future change will want a cpuid-like identifier which doesn't have a mapping
> >> to a feature bit.
> > Why we prefer this logic over just giving such pseudo features a
> > synthetic bit or akin?
> 
> Synthetic bits are (intentionally) not available to cmdline parsing.  We
> need something that is available for parsing.

I think Jan expressed my view better, in that it would be nicer to
just have the MSR_ARCH_CAPS bits in the featureset, and listed in
cpufeatureset.h like we handle CPUID features.

Maybe we want to go your proposed route now if that's easier however.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 14:13:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 14:13:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416272.660924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og58s-0003OX-QK; Wed, 05 Oct 2022 14:12:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416272.660924; Wed, 05 Oct 2022 14:12:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og58s-0003OQ-NX; Wed, 05 Oct 2022 14:12:58 +0000
Received: by outflank-mailman (input) for mailman id 416272;
 Wed, 05 Oct 2022 14:12:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NzUo=2G=citrix.com=prvs=27000a6ca=roger.pau@srs-se1.protection.inumbo.net>)
 id 1og58q-0003OK-IH
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 14:12:56 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cced22b3-44b7-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 16:12:54 +0200 (CEST)
Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 05 Oct 2022 10:12:51 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by PH7PR03MB7001.namprd03.prod.outlook.com (2603:10b6:510:12c::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Wed, 5 Oct
 2022 14:12:47 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022
 14:12:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cced22b3-44b7-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1664979174;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=vfWwYC1WNHz3U+5VkC746WjcrAf5w5+04Q2llwdwDkw=;
  b=OffW8NNy5iAum0cMorNCX7sS9uFwHhVpiMTvkSSgQi5YrXKTimbSGGW5
   wExP2qh8IlhNPOvRRaE2xxzyb/U+o3dtAhP8EH6CPu+XMSXpqHEbCRiYo
   Er3YC0B1sIYD3Sq+JAifaKH0f+RUzXDItO2coVnphfcg9B+2fLBCiibW+
   4=;
X-IronPort-RemoteIP: 104.47.66.42
X-IronPort-MID: 82019272
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:UtRkFK3e9KnGfPyjvvbD5S1wkn2cJEfYwER7XKvMYLTBsI5bpzMPy
 mIbDGrSOf7YZmb8f9lzPou3oEtQ6JXUn9VrQQJrpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GtF5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUAprdoK3Flq
 sYyLRUIbCiE28SR8ZikH7wEasQLdKEHPas5k1Q5l3T8MqxjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7gzL4/Zti4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWDdqyP22bWncSXTYp1KU5ub2OFThFST7UoBISA4C3+Wvqzs4qK5c5cFQ
 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0QMFMGuc37AWMzKv84AuDAGUACDlbZ7QOttIyRDEs/
 k+EmZXuHzMHmLeYU26H/7GY6za7IzEILHQqbDUBCwAC5rHLnoY3iR7eS8d5J4S8hNb1BDLYz
 iiDqW41gLB7pdEP/7W2+xbAmT3EjojESEs56xvaWkqh7xhlf8i1aoqw81/Z4P1caoGDQTG8U
 GMsnsGf6KULEsuLnSnUGuEVRun1vbCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC
 KPOhT5sCFZoFCPCRcdKj0iZUKzGEYCI+QzZa83p
IronPort-HdrOrdr: A9a23:sX9qw62lyOuu9OKKsUy50AqjBdJxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp
 uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6
 Dsm/av6gDQD0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G
 DZm0ihj5/T+c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd
 HQq1MLPth16VnWYmapyCGdkDXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZ8fgHC40Qtkdlg2O
 YTtljp/6Z/PFflpmDQ9tLIXxZlmg6dpmcjq/caizh6XZEFYLFcgIQD9Ad+EYsGHgj99Ic7ed
 MeRf301bJzSxe3fnrZtm5gzJiFWWkyJA6PRgw4tsmcw1Ft7QVE5npd4PZasmYL9Zo7RZUBzf
 /DKL5UmLZHSdJTRb5hBc8aKPHHRFDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop
 LcS1lV3FRCNH4GMff+nKGjzyq9A1lUBV/Wu4NjDtlCy/HBrYPQQGy+oAtEqbrknx0daverKc
 pbdqgmR8MLFlGeabqh7zeOJaW6FkNuIfH9muxLL25m8fi7XbHCh6j8TMv5AobLPHINZl7fa0
 FzLwQbYv8wo3yWZg==
X-IronPort-AV: E=Sophos;i="5.95,161,1661832000"; 
   d="scan'208";a="82019272"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B9Qr2zPsKwuoev+VH2zbTe6MFgsHDfqDohmtqPZ234XWNp3PcWRfxjgXps7e0cbLUS+fFEHavjKeOiSt2oxe7uOZGmDg6e88XDT/ffQxyWy0nYeRo8OLMRudGlnEYHU1Aovng03TOTVdDoofwVtMemuzBVh5UC/cJO00BcAKUSI5gMdQVCqfoW1tg4T9zufYMXr/AfIOrvcwHwRLhJKyzEAXKJCAxr/V3FKuLW/jgD5wj2zeps+5D0TIIsW/TvesTAor6lO+950VeYwAQ6gaiv8/p2YrOLLzjBd86WqOIUbtcRYDmzE7jVpTWjjpU+RjV2YgltHhMyJKHfVgZQHCBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=N/SCgAJIsuTkXWojpM5hjMG9JK3fFZSdJ7zRovlTxbs=;
 b=QcD36i8TNZ/f6E5j6NsXh+kICHZ/3iQuqXZhc4+/oC8od5VLBmUQVcoz9sDL39+5P8YRBFZYExPI85Xz4Vrkm+VfrtnvyFeXr68+cexAptQLRiLdX1MZ+uOd7q6nU1kxV/1Xz1i1hAmg51NUVOX8lIzBZZWjRRubsQZd9nQMbUIT6pkfSUDhwfgLv1UNvzXRWqPKXGJU39Iei2vgTxPuMtBoUCPN+VQxKESCJYjIKOYKNp5QGYvYFMZ510KDTUA7fDLSgD+5IpWgPt0Vv1zlnemwnQ6vDzINczFmGmIkY/Ja9H12TmLMsMZwdUp4fX4v1MWc/nwDDIgtXCeqok5X6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=N/SCgAJIsuTkXWojpM5hjMG9JK3fFZSdJ7zRovlTxbs=;
 b=trrIDMLiJqwvhqt2EfJ33BSAp+MDRnAJK3dyGTKrLlgrVtFtgRA/fXEnNrgvqrTAaQLBUkJoLI/G6jXzXKYk+5KQ9HOrKGxIx15OqpxcDN68H2Fzy3LqahWWuzhXBK2boDntV0K6q3Pzbj7neRZ/ZEkwWjY5tQJIU1Z/j+9n0kY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 5 Oct 2022 16:12:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Message-ID: <Yz2Q1C7Z2zolHAvK@Air-de-Roger>
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
 <Yz1CPNwo1hiWZTw2@Air-de-Roger>
 <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
X-ClientProxiedBy: LO4P123CA0403.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH7PR03MB7001:EE_
X-MS-Office365-Filtering-Correlation-Id: ced12520-dc86-42cf-3f8a-08daa6dbad83
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CMUY+KN8Q4rSrx7NunwPE0JfyxknKntqEpw8cyhMzNWzd/uFV5E9p2tvYGGMW6bAgnET7s0BcwYLpOS/wEf/6bIhedy9T5gJdYjHqRS8DivVMhqdWKUxhwz5VtsBVHmLJIf29G+7Xkg8rEv6Uj1cFUGVc31CbSs5Lwia75Ihzu4Gti0RtiAwwhzvjBPkn7QVLmlKyb3+gNXCXHf/VGj8e51QI/KOO9YWvwg0maddTBciLhBnLLHT2d9XnRseJuSq1/wgFcVoVJKV98veZMSYQ6x9arcfFdfx+Rrn7w0NLjuFYGrfMCX1N8ue+G7slotTyA9xpUAUb31eORVew/V0KD7vpzJVSFlcaSG50NibCNMZFGhI6jrx8pRYDWvUfdivpIUhlLe2jd/kGuSHNrfx/mTJIoIfxix3EsIkSuUVo+KVRuG4rE0Z3BHdeSMfePXTdVjSrfC5hhz0jJtDUTKAStsroG9F27sPFdqHeiGrv6f8fmjzMuORxtWlibzvuVcWRpGLmw/QiuHWadQMZPafKH1AsqV7SMY8Ojw4KdeChCHMoHlIreYyUqcc1bNZ9xpJnCuH7xK6hZVI/eWe0xwvALb1J6HW/EPwgMOTqzWWJQ/oFFRhCZgLOW8J7CGJunMPvi/NBHzlQKiRQF9xdyLkPcXFrUOhMnCqWrPfEbbQrGIkuhNgtEa3nshkFrUcWRVHxeQAcx4BIiiPBVn2YH6KYg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199015)(6506007)(82960400001)(38100700002)(85182001)(86362001)(9686003)(6512007)(53546011)(26005)(5660300002)(4326008)(6666004)(33716001)(8676002)(66556008)(478600001)(316002)(6916009)(54906003)(66946007)(66476007)(2906002)(6486002)(83380400001)(8936002)(66899015)(186003)(41300700001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SFRRUld2dkdKbG1MOENScjh2aE9DdTJyUGRPT1ZyaUdFdlVmWjZNM2J5TlJ2?=
 =?utf-8?B?N3UwOTlRelJsQkhPdnc3KzZKai8zWng2VjRuL3hhVmV4cUIxdEYrM2ROVGRN?=
 =?utf-8?B?VTBBakU4NHQ1eU9hajAwMkZqVjc2WTF0ZFFneVk0cUhBdXVOZ1BQQWpZeklI?=
 =?utf-8?B?TmpsVVBiaElRM3V5YUIrUVE2anZxR21XR09NMC9hNWhudHRPUGx2V3dIZzBR?=
 =?utf-8?B?UzVJLzJlcWl1TXVFQm16cGdBV0NWeXA0SE9BZ09NcDkvN0V4Zk5ydmVFRkht?=
 =?utf-8?B?eWZFNUFza3l5eWtJL3g0SWRIQ0puZ2xJQ0ltWmRldmZXRzVaNXptb3BZenVS?=
 =?utf-8?B?T1RkbGN0cVRKZndDbEdBYU1ZNXJEMjAyQTI1MU41QnhsejVybm1mUFNJR0s5?=
 =?utf-8?B?MUx4WmFiWTVXUUZHT1cvL3VuemtZaDYrOWFDM0d0SExTUlFrRlBCcHg2eCta?=
 =?utf-8?B?T293YjNBdnJUWWFNam9FWFo1ZzlEbTFFQUJYK3o5WHV3b1J5NWV6bkJvZFRR?=
 =?utf-8?B?aFlSallKV3duWFZjeTkra3VFdTRXcTlpNnFaUUVIYkxHL3pCbk1BNnJEOG1h?=
 =?utf-8?B?VkpvcDNVUVU4cURsZHdmYndEWTV0SXRBT09OMDhBSlVKMnBYY0sybjRySzdi?=
 =?utf-8?B?aTloWjViQnk2NFZFSUpOR2QrV2lUQlRFcGdneGlHempLV2xHMzJhbW1xd0cr?=
 =?utf-8?B?ODJ0UkpnUXZhYURtc2xtZkpLTlI3c0Y1Z2pOS091UGladXZxTW45WXpaNDFK?=
 =?utf-8?B?WThlZjFTMHQ1bUFGOGtXVS9sSUtOcnR5VFJsdUkwMmRQc1pZZUcxL1lRU2Jh?=
 =?utf-8?B?TUFQblh4c0NqNSs2T2syV3NHWS9paFdBM0xVUlZ4djFqSlpJcEpUeFJGZUdO?=
 =?utf-8?B?MTNrTDY1WWkwTjB1bGFuTkxwYUNkRzNTSEdvMmxBTm52ajlRZTdQcXZJOWNT?=
 =?utf-8?B?S1ZXVHNNUDRoTnp5a3ZtS3lFZlgxb1R3UUE4a0s2eE9aeFFyQlovaHpHY1dv?=
 =?utf-8?B?ekJESHJKSzNzcTB3QVBYZkFvYWRrR0FUZkliMEpJcmRHc0tOaEplUnNqejcv?=
 =?utf-8?B?d25BVmxoSGgrRnoxMUxUeDdhSUZiZWNwZEZuTW5HSnVxYXBVa2tIN1B2YVo5?=
 =?utf-8?B?bzg5TW0yYVNXaVVEZVlkU01iRkRRZ3RyRXoyUzZiTVEyeGF1Rlh3Q21TMTZh?=
 =?utf-8?B?N1ZmTHR2b3FzOFJWNFNGSzdGODQzdDNQaGxReGRMb1laSG5zSE1tRVNOUWli?=
 =?utf-8?B?eGZtNzhiWllQL014NlBqWHhiY3BBbVJVVTZkNTdXR1FCaTE2cWV1UlNHSUds?=
 =?utf-8?B?MnVvcnVkR0s0VittcmdvQkVNZm5sUVdhdWJ0eVZCeit3a2szUUdaTldjeXY4?=
 =?utf-8?B?VUltVkxvQ3dwbWpGcTQxZ2IwcWFpU2lOMnc4TVIzR2lSQ0tJN2tnK0c5OS91?=
 =?utf-8?B?TDR2STF5ZisxaU9yOXFVYVlJYXNaZnR0YjZ1WU9SeFpnTDRXWlV0R1hqc3B4?=
 =?utf-8?B?OXNaWjdObzdRVkhWUTBIczlnZHp2RDM0dktHejZoOFVFS2trQndkMzBONFlr?=
 =?utf-8?B?Kys0Um41ZTl5bGJwTDdEeGE5WjFUc2FDTVNObHpuelRlZDMvNGJjWElYTmZG?=
 =?utf-8?B?TW1vRkNXVFZ5YUxmWlY1TGxnZUpUYzVidi95NmxmTUxVVmNZdVNCcEpTc2c1?=
 =?utf-8?B?SUNNdVVFdEgrWlJDTUNKL0kyRzhwRVgrbGNqR0Uzd0xPM1ByNDZUNXVJTmZs?=
 =?utf-8?B?QmRMaVJMUHFiaEs3cGhhLzFINFExQ2xOcUM3NlZYMUcwcW5DS1R4QStNdjdC?=
 =?utf-8?B?SFlrdkVUMGtzckpVeGR4N2Ztc2NIcmErclg0QWQ0NVRxbnk4c3k3eUtaaGFE?=
 =?utf-8?B?WUtybXJhdlBKT2EyZ3JVUGZYMEtjQ00xM0ZweHJiTWNSQlpKWU9RUHR1amo1?=
 =?utf-8?B?QlZNTWRxbmZHZHM5OXM3dllPTnJ5ek42aUJSMGhaTTVGMm9hejlhejQyNFJm?=
 =?utf-8?B?N1hzbzRBejhaWFRwR3BqdjFOUE5FWi9ZZDlVVVp2R1U3bVQ4YnNFL3FZeUxk?=
 =?utf-8?B?b1N5SUluQzRLbjY2d0V0OVBDS1VISUZiRllFZ2p0NlVhQmpKRlowU0RXV2pD?=
 =?utf-8?B?bkw5cmRHUS9YQWU5VDhxblVTa3BBM1RpNzYzMmt3c25hNlZsM1Nkb2JMT0Fj?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	8IiYtlJufmyH56DuY/SWNzExdZzrqMVB1kM1XbyGzpbQtOet24w8gjxSGi4QMgaO39929TxL2EvEZEvadCE3MwROPpOmhhZjCHuybn0b6YKqdgq6loErsvsz2RWE2uELbgrFfLTwSVnXs/2LuyeYNZi7ag2sF1sIJyxZEvwqL+D6AitiP2ROSmJFCLMKf9J/nss6tsihXWzHSkSVo025C8q4gEI9CE048kBOh37j8f+5j1RcJiPdiRdaZQMx+kPdV+/Ctvs8LvhqefXw8iYbVshnEZawLNcWIJm+/jcuAiB3PphMAN2y2501YFFYc+bOrVIolhIbJKRIeEtvN3K85Uh/HoGxz2p1LVCRYL8LSq0L9Jf02tvHBaVT38vlIaSVw+o00NiO4KBQYQ2rsOTp6PCzFZetPfCKk3/uQeOA0GqkCDnnKOPV0/0I9S+sXVT/0OPJgGyz4U4CeBcGxNgJzkgGzJ748L8PcSpFbRjFYQ08oa6L05MT42kdcRgnyryUFcRN8Vaa0Gh1yVuXW4v5U917YbBNiMK5dGmZgUtInbhlVVDMFc/Jq+LWyG+lfLMFW1ys6IZ0lpAK5P1cn+W1ri+MPWnSyMVb+8eueyUoga7JBDhv1uQ7Yvm210CohYvAaMHIJ/83uM+Wn7mG5Cbd9KevGo4Z7EbeFZR7GyivrXr7SAtzeUou/wNeAkd3juGYhZchjTmDL1wWpP6T3R2yXrEy2gWcxNdJYCvEnn1ptu3jKlcZrNmqk6F3lxiCWKEoEZPG7/X8H/j18xoY88L3sXYdjNgtIqlzVXwFpdgF9Zm0BzJKGh9ISKQpRH00ztlvwswmsKQwvolDUyBPxoXEoqMkf5hDEuoV8wYlZPW9UlWgV6xYHyrwXNyDDYHCTIMkxT9iYbJfy1yDFOIt0YFAS42Ami/mr/G+jKQy+O5AgeY=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ced12520-dc86-42cf-3f8a-08daa6dbad83
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 14:12:46.9197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xow+R5kSSNsV53MUlxQ4rgI8iCdj2hgXpe8TxSCI69EqTNoQjRdkjU5vC4JEKGzH1iyi6GrMoJWSo5w2jUw/6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7001

On Wed, Oct 05, 2022 at 10:53:38AM +0200, Jan Beulich wrote:
> On 05.10.2022 10:37, Roger Pau Monné wrote:
> > On Tue, Oct 04, 2022 at 06:11:50PM +0200, Jan Beulich wrote:
> >> On 04.10.2022 17:36, Roger Pau Monne wrote:
> >>> The EFI memory map contains two memory types (EfiMemoryMappedIO and
> >>> EfiMemoryMappedIOPortSpace) used to describe IO memory areas used by
> >>> EFI firmware.
> >>>
> >>> The current parsing of the EFI memory map is translating
> >>> EfiMemoryMappedIO to E820_RESERVED on x86.  This causes issues on some
> >>> boxes as the firmware is relying on using those regions to position
> >>> the BARs of devices being used (possibly during runtime) for the
> >>> firmware.
> >>>
> >>> Xen will disable memory decoding on any device that has BARs
> >>> positioned over any regions on the e820 memory map, hence the firmware
> >>> will malfunction after Xen turning off memory decoding for the
> >>> device(s) that have BARs mapped in EfiMemoryMappedIO regions.
> >>>
> >>> The system under which this was observed has:
> >>>
> >>> EFI memory map:
> >>> [...]
> >>>  00000fd000000-00000fe7fffff type=11 attr=800000000000100d
> >>> [...]
> >>> 0000:00:1f.5 disabled: BAR [0xfe010, 0xfe010] overlaps with memory map
> >>>
> >>> The device behind this BAR is:
> >>>
> >>> 00:1f.5 Serial bus controller [0c80]: Intel Corporation Lewisburg SPI Controller (rev 09)
> >>> 	Subsystem: Super Micro Computer Inc Device 091c
> >>> 	Flags: fast devsel
> >>> 	Memory at fe010000 (32-bit, non-prefetchable) [size=4K]well
> >>>
> >>> For the record, the symptom observed in that machine was a hard freeze
> >>> when attempting to set an EFI variable (XEN_EFI_set_variable).
> >>>
> >>> Fix by allowing BARs of PCI devices to be positioned over reserved
> >>> memory regions, but print a warning message about such overlap.
> >>
> >> Somewhat hesitantly I might ack this change, but I'd like to give
> >> others (Andrew in particular) some time to voice their views. As
> >> said during the earlier discussion - I think we're relaxing things
> >> too much by going this route.
> > 
> > Another option would be to explicitly check in efi_memmap for
> > EfiMemoryMappedIO regions and BAR overlap and only allow those.  That
> > would be more cumbersome code wise AFAICT.
> 
> Indeed there's a question of balancing well here, between two outcomes
> neither of which is really desirable.

Hm, I have the following diff attached below which is more limited,
and not so bad I think.  Initially I wanted to introduce an
efi_all_mapped() helper, but that would require exposing EFI_MEMORY_TYPE
which is quite intrusive.

Let me know if you think the proposal below is better and I will
formally send a patch with it.

Thanks, Roger.
---
diff --git a/xen/arch/x86/include/asm/pci.h b/xen/arch/x86/include/asm/pci.h
index f4a58c8acf..c8e1a9ecdb 100644
--- a/xen/arch/x86/include/asm/pci.h
+++ b/xen/arch/x86/include/asm/pci.h
@@ -57,14 +57,4 @@ static always_inline bool is_pci_passthrough_enabled(void)
 
 void arch_pci_init_pdev(struct pci_dev *pdev);
 
-static inline bool pci_check_bar(const struct pci_dev *pdev,
-                                 mfn_t start, mfn_t end)
-{
-    /*
-     * Check if BAR is not overlapping with any memory region defined
-     * in the memory map.
-     */
-    return is_memory_hole(start, end);
-}
-
 #endif /* __X86_PCI_H__ */
diff --git a/xen/arch/x86/pci.c b/xen/arch/x86/pci.c
index 97b792e578..c3737e226d 100644
--- a/xen/arch/x86/pci.c
+++ b/xen/arch/x86/pci.c
@@ -4,6 +4,7 @@
  * Architecture-dependent PCI access functions.
  */
 
+#include <xen/efi.h>
 #include <xen/spinlock.h>
 #include <xen/pci.h>
 #include <asm/io.h>
@@ -98,3 +99,28 @@ int pci_conf_write_intercept(unsigned int seg, unsigned int bdf,
 
     return rc;
 }
+
+bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end)
+{
+    /*
+     * Check if BAR is not overlapping with any memory region defined
+     * in the memory map.
+     */
+    if ( is_memory_hole(start, end) )
+        return true;
+
+    /*
+     * Also allow BARs placed on EfiMemoryMappedIO regions in order to deal
+     * with EFI firmware using those regions to place the BARs of devices that
+     * can be used during runtime.  But print a warning when doing so.
+     */
+    if ( !efi_all_runtime_mmio(mfn_to_maddr(start),
+                               mfn_to_maddr(mfn_add(end, 1))) )
+        return false;
+
+    printk(XENLOG_WARNING
+           "%pp: BAR [%#" PRI_mfn ", %#" PRI_mfn "] overlaps reserved region\n",
+           &pdev->sbdf, mfn_x(start), mfn_x(end));
+
+    return true;
+}
diff --git a/xen/common/efi/runtime.c b/xen/common/efi/runtime.c
index 13b0975866..b69c710ce3 100644
--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -78,6 +78,30 @@ bool efi_enabled(unsigned int feature)
     return test_bit(feature, &efi_flags);
 }
 
+/*
+ * This function checks if the entire range [start,end) is contained inside of
+ * a single EfiMemoryMappedIO descriptor with the runtime attribute set.
+ */
+bool efi_all_runtime_mmio(uint64_t start, uint64_t end)
+{
+    unsigned int i;
+
+    for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
+    {
+        EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;
+        uint64_t len = desc->NumberOfPages << EFI_PAGE_SHIFT;
+
+        if ( desc->Type != EfiMemoryMappedIO ||
+             !(desc->Attribute & EFI_MEMORY_RUNTIME) )
+            continue;
+
+        if ( start >= desc->PhysicalStart && end <= desc->PhysicalStart + len )
+            return true;
+    }
+
+    return false;
+}
+
 #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */
 
 struct efi_rs_state efi_rs_enter(void)
diff --git a/xen/include/xen/efi.h b/xen/include/xen/efi.h
index 94a7e547f9..f29ea1a320 100644
--- a/xen/include/xen/efi.h
+++ b/xen/include/xen/efi.h
@@ -45,6 +45,8 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *);
 int efi_compat_get_info(uint32_t idx, union compat_pf_efi_info *);
 int efi_compat_runtime_call(struct compat_pf_efi_runtime_call *);
 
+bool efi_all_runtime_mmio(uint64_t start, uint64_t end);
+
 #endif /* !__ASSEMBLY__ */
 
 #endif /* __XEN_EFI_H__ */
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 5975ca2f30..64995fc68d 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -211,6 +211,7 @@ unsigned int pci_size_mem_bar(pci_sbdf_t sbdf, unsigned int pos,
 
 void pci_intx(const struct pci_dev *, bool enable);
 bool_t pcie_aer_get_firmware_first(const struct pci_dev *);
+bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end);
 
 struct pirq;
 int msixtbl_pt_register(struct domain *, struct pirq *, uint64_t gtable);



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 15:04:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 15:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416282.660936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og5wn-0000Ck-Jy; Wed, 05 Oct 2022 15:04:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416282.660936; Wed, 05 Oct 2022 15:04:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og5wn-0000Cd-FJ; Wed, 05 Oct 2022 15:04:33 +0000
Received: by outflank-mailman (input) for mailman id 416282;
 Wed, 05 Oct 2022 15:04:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og5wl-0000CX-W3
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 15:04:31 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0353cd54-44bf-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 17:04:30 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 194631F7AB;
 Wed,  5 Oct 2022 15:04:30 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 026D313ABD;
 Wed,  5 Oct 2022 15:04:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WjHHOv2cPWOSNQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 15:04:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0353cd54-44bf-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664982270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=orayW6DC0+1L5z3MTedZf9i3NlZmmFYcFa1Za3O/A/w=;
	b=fgtX/m0PjMydPNd0x/XyAsUjY6xjpMhY8Ee/2YrtqGIs4ib7TG2I6NLis3l8Upd+kxm1Qv
	8cU7l0nrhojsSMvBRaghKjH7YKUPRIVieL86yYxQ/0HMaP5PnoxK6mAiNRy3upjmNUOusb
	P5ToT64fajFQJZMn482I8x8/Mp9TH14=
Message-ID: <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com>
Date: Wed, 5 Oct 2022 17:04:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com> <Yz2L9eTdbA3vS43g@mail-itl>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <Yz2L9eTdbA3vS43g@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jXOYyrPS0JxKApJ0juxhNY0I"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jXOYyrPS0JxKApJ0juxhNY0I
Content-Type: multipart/mixed; boundary="------------wCWm6l6XonyWJt5XkP5zz5Yq";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com> <Yz2L9eTdbA3vS43g@mail-itl>
In-Reply-To: <Yz2L9eTdbA3vS43g@mail-itl>

--------------wCWm6l6XonyWJt5XkP5zz5Yq
Content-Type: multipart/mixed; boundary="------------fjSUt0fe7kaG94bxGExAt5A0"

--------------fjSUt0fe7kaG94bxGExAt5A0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTU6NTEsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDM6MzQ6NTZQTSArMDIwMCwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IE9uIDA1LjEwLjIyIDE1OjI1LCBNYXJlayBNYXJjenlrb3dza2kt
R8OzcmVja2kgd3JvdGU6DQo+Pj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDI6NTc6MDFQ
TSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gT24gMDUuMTAuMjIgMTQ6NDEs
IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToNCj4+Pj4+IEhpLA0KPj4+Pj4N
Cj4+Pj4+IFdoZW4gYm9vdGluZyBYZW4gd2l0aCBMaW51eCBkb20wIG5lc3RlZCB1bmRlciBL
Vk0sDQo+Pj4+PiBDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVD15IG1ha2VzIGl0IHVu
YWJsZSB0byB1c2UgdmlydGlvIGRldmljZXMNCj4+Pj4+IHByb3ZpZGVkIGJ5IEwwIGh5cGVy
dmlzb3IgKEtWTSB3aXRoIHFlbXUpLiBXaXRoIFBWIGRvbTAsIGdyYW50cyBhcmUNCj4+Pj4+
IHJlcXVpcmVkIGZvciB2aXJ0aW8gZXZlbiBpZiBqdXN0IENPTkZJR19YRU5fVklSVElPIGlz
IGVuYWJsZWQuDQo+Pj4+Pg0KPj4+Pj4gVGhpcyBpcyBwcm9iYWJseSB1bmNvbW1vbiBjb3Ju
ZXIgY2FzZSwgYnV0IG9uZSB0aGF0IGhhcyBiaXR0ZW4gbWUgaW4gbXkNCj4+Pj4+IENJIHNl
dHVwLi4uIEkgdGhpbmsgWGVuIHNob3VsZCBzZXQgc21hcnRlcg0KPj4+Pj4gdmlydGlvX3Jl
cXVpcmVfcmVzdHJpY3RlZF9tZW1fYWNjKCksIHRoYXQgZW5mb3JjZXMgaXQgb25seSBmb3Ig
ZGV2aWNlcw0KPj4+Pj4gcmVhbGx5IHByb3ZpZGVkIGJ5IGFub3RoZXIgWGVuIFZNIChub3Qg
YnkgdGhlICJvdXRlciBob3N0IiksIGJ1dCBJJ20gbm90DQo+Pj4+PiBzdXJlIGhvdyB0aGF0
IGNvdWxkIGJlIGRvbmUuIEFueSBpZGVhcz8NCj4+Pj4+DQo+Pj4+DQo+Pj4+IEl0IHNob3Vs
ZCBiZSBwb3NzaWJsZSB0byBhZGQgYSBib290IHBhcmFtZXRlciBmb3IgdGhhdCBwdXJwb3Nl
LiBVc2luZyBpdA0KPj4+PiB3b3VsZCBvcGVuIGEgc2VjdXJpdHkgaG9sZSwgdGhvdWdoIChi
YXNpY2FsbHkgbGlrZSBhbGwgUENJIHBhc3N0aHJvdWdoIHRvDQo+Pj4+IFBWIGd1ZXN0cyku
DQo+Pj4NCj4+PiBXaGF0IGFib3V0IGV4Y2x1ZGluZyBqdXN0IGRvbTA/IEF0IGxlYXN0IGN1
cnJlbnRseSwgdGhlcmUgaXMgbm8gd2F5IGZvcg0KPj4+IGRvbTAgdG8gc2VlIHZpcnRpbyBk
ZXZpY2VzIHByb3ZpZGVkIGJ5IGFub3RoZXIgWGVuIGRvbVUuDQo+Pg0KPj4gRXZlbiBub3Qg
dmlhIGhvdHBsdWc/DQo+IA0KPiBUaGF0J3Mgd2h5IEkgc2FpZCAiY3VycmVudGx5IiwgSUlV
QyBob3RwbHVnIG9mIHZpcnRpbyBkZXZpY2VzIHVuZGVyIFhlbg0KPiBkb2Vzbid0IHdvcmsg
eWV0LCBubz8NCj4gV2l0aCBob3RwbHVnIHdvcmtpbmcsIGl0IHdvdWxkIG5lZWQgdG8gYmUg
YSBwcm9wZXIgZGV0ZWN0aW9uIHdoZXJlIHRoZQ0KPiBiYWNrZW5kIGxpdmVzLCBhbmQgcHJv
YmFibHkgd2l0aCBzb21lIGV4dHJhIGNvbnNpZGVyYXRpb25zIHJlIFhlbiBvbg0KPiBYZW4g
KGJhc2VkIG9uIGJlbG93LCBwdi1zaGltIGNvdWxkIHVzZSBncmFudHMpLg0KDQpBcyBzdGF0
ZWQgYmVmb3JlLCB0aGlzIGlzbid0IGEgcHJvYmxlbSBzcGVjaWZpYyB0byB2aXJ0aW8gZGV2
aWNlcy4gVGhlIHNhbWUNCmFwcGxpZXMgdG8gWGVuIFBWIGRldmljZXMuDQoNCj4gDQo+IEZv
ciBtZSBzcGVjaWZpY2FsbHksIGEgY29tbWFuZCBsaW5lIG9wdGlvbiB3b3VsZCB3b3JrIChi
ZWNhdXNlIEkgZG9uJ3QNCj4gdXNlIFhlbi1iYXNlZCB2aXJ0aW8gZGV2aWNlcyB3aGVuIG5l
c3RlZCB1bmRlciBLVk0sIG9yIGFueXdoZXJlIGF0IGFsbCwNCj4gYXQgbGVhc3Qgbm90IHll
dCksIGJ1dCBJIGNhbiBzZWUgZnV0dXJlIGNhc2VzIHdoZXJlIHlvdSBoYXZlIHZpcnRpbw0K
PiBkZXZpY2VzIGZyb20gYm90aCBMMCBhbmQgTDEgaW4gdGhlIHNhbWUgZ3Vlc3QsIGFuZCB0
aGVuIGl0IHdvdWxkbid0IGJlDQo+IHRoYXQgc2ltcGxlLg0KDQpMZXRzIHRoaW5rIG9mIGEg
Z2VuZXJhbCBzb2x1dGlvbiBjb3ZlcmluZyBhbGwgUFYgZGV2aWNlcyAoWGVuIGFuZCB2aXJ0
aW8pLg0KDQo+IA0KPj4+IFNvbWV0aGluZyBsaWtlIHRoaXM6DQo+Pj4gLS0tODwtLS0NCj4+
PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jIGIvYXJjaC94ODYv
eGVuL2VubGlnaHRlbl9wdi5jDQo+Pj4gaW5kZXggOWIxYTU4ZGRhOTM1Li42YWMzMmIwYjM3
MjAgMTAwNjQ0DQo+Pj4gLS0tIGEvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jDQo+Pj4g
KysrIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jDQo+Pj4gQEAgLTExMSw3ICsxMTEs
NyBAQCBzdGF0aWMgREVGSU5FX1BFUl9DUFUoc3RydWN0IHRsc19kZXNjcywgc2hhZG93X3Rs
c19kZXNjKTsNCj4+PiAgICBzdGF0aWMgdm9pZCBfX2luaXQgeGVuX3B2X2luaXRfcGxhdGZv
cm0odm9pZCkNCj4+PiAgICB7DQo+Pj4gICAgICAgICAgIC8qIFBWIGd1ZXN0cyBjYW4ndCBv
cGVyYXRlIHZpcnRpbyBkZXZpY2VzIHdpdGhvdXQgZ3JhbnRzLiAqLw0KPj4+IC0gICAgICAg
aWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU8pKQ0KPj4+ICsgICAgICAgaWYgKElT
X0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU8pICYmICF4ZW5faW5pdGlhbF9kb21haW4oKSkN
Cj4+PiAgICAgICAgICAgICAgICAgICB2aXJ0aW9fc2V0X21lbV9hY2NfY2IodmlydGlvX3Jl
cXVpcmVfcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4+PiAgICAgICAgICAgcG9wdWxhdGVfZXh0
cmFfcHRlKGZpeF90b192aXJ0KEZJWF9QQVJBVklSVF9CT09UTUFQKSk7DQo+Pj4gLS0tODwt
LS0NCj4+Pg0KPj4+IFRoaXMgQlRXIHJhaXNlcyBhbHNvIGEgcXVlc3Rpb24gd2hhdCB3aWxs
IGhhcHBlbiBvbiBYZW4gbmVzdGVkIGluc2lkZQ0KPj4+IFhlbiwgd2hlbiBMMCB3aWxsIHBy
b3ZpZGUgdmlydGlvIGRldmljZXMgdG8gTDEuIEdyYW50cyBzZXQgYnkgTDEgZG9tMA0KPj4+
IHdvdWxkbid0IHdvcmsgb24gTDAsIG5vPyBPciBtYXliZSB0aGlzIGlzIHNvbHZlZCBhbHJl
YWR5IGZvciBwdi1zaGltDQo+Pj4gY2FzZT8NCj4+DQo+PiBUaGlzIGlzIGEgc2ltaWxhciBw
cm9ibGVtIGFzIHdpdGggbm9ybWFsIFhlbiBQViBkZXZpY2VzLg0KPj4NCj4+IFlvdSB3aWxs
IG5lZWQgZWl0aGVyIGEgc2ltcGxlIGdyYW50IHBhc3N0aHJvdWdoIGxpa2Ugd2l0aCBwdi1z
aGltIChlbmFibGluZw0KPj4gc3VjaCBkZXZpY2VzIGZvciBvbmUgZ3Vlc3QgaW4gTDEgb25s
eSksIG9yIHlvdSBuZWVkIGEgZ3JhbnQgbXVsdGlwbGV4ZXIgaW4NCj4+IEwxIFhlbiBpbiBj
YXNlIHlvdSB3YW50IHRvIGJlIGFibGUgdG8gaGF2ZSBtdWx0aXBsZSBndWVzdHMgaW4gTDEg
YmVpbmcgYWJsZQ0KPj4gdG8NCj4+IHVzZSBMMCBQViBkZXZpY2VzLg0KPiANCj4gVGhpcyB3
aWxsIGJlIHRyaWNreSwgYXQgbGVhc3Qgd2l0aCB0aGUgY3VycmVudCBmcm9udGVuZCBkcml2
ZXJzLg0KPiBGcm9udGVuZCBrZXJuZWwgaXMgaW4gY2hhcmdlIG9mIGFzc2lnbmluZyBncmFu
dCByZWZzLCBfYW5kXw0KPiBjb21tdW5pY2F0aW5nIHRoZW0gdG8gdGhlIGJhY2tlbmQuIFN1
Y2ggbXVsdGlwbGV4ZXIgd291bGQgbmVlZCB0bw0KPiBpbnRlcmNlcHQgb25lIG9yIHRoZSBv
dGhlciAoZWl0aGVyIHRyYW5zbGF0ZSwgb3IgZW5zdXJlIHRoZXkgYXJlDQo+IGFsbG9jYXRl
ZCBmcm9tIGRpc3RpbmN0IHJhbmdlcyB0byBiZWdpbiB3aXRoKS4gSSBkb24ndCBzZWUgaG93
IHRoYXQNCj4gY291bGQgYmUgZG9uZSB3aXRoIHRoZSBjdXJyZW50IGRvbVUga2VybmVscy4g
VGhhdCBtaWdodCBiZSBiZXR0ZXIgd2l0aA0KPiB5b3VyIGlkZWEgb2YgbXVsdGlwbGUgZ3Jh
bnQgdjMgdHJlZXMsIHdoZXJlIHRoZSBoeXBlcnZpc29yIG1pZ2h0IGRpY3RhdGUNCj4gZ3Jh
bnQgcmFuZ2VzLg0KDQpZZXMsIHRoaXMgaXMgYW5vdGhlciBhZHZhbnRhZ2Ugb2YgdGhlIFYz
IGFwcHJvYWNoIEkgaGF2ZW4ndCB0aG91Z2h0IG9mDQpiZWZvcmUuDQoNCg0KSnVlcmdlbg0K

--------------fjSUt0fe7kaG94bxGExAt5A0
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------fjSUt0fe7kaG94bxGExAt5A0--

--------------wCWm6l6XonyWJt5XkP5zz5Yq--

--------------jXOYyrPS0JxKApJ0juxhNY0I
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM9nP0FAwAAAAAACgkQsN6d1ii/Ey/W
uQf7Bb1uwVE6RkAMdWx0uqHvKFf+EF+9qasbcDBZaDhEnxeVygWvXqgtIMArwrpntmF7G3o5/3un
gmywTj1+3t4RLb0lUHYCTVfW4fTYTndEu5H1E1TeyAfAXis/D5Y6ZazIN1dwEOVNXc7D31uaeE3p
JLRZVYB9QMnPPEfPs7Whz435B/coG/SykkP+uBCbaIeUyNKFt+8sFWN8RWri1KGiGomwoLhWr8b7
VHH+c1ZnXy5wW6ZKWX5sU9bjEZ/O6LFsbpHCeNVTTPkaMsYZwYyUaKHrfS6K+9qMnsFaEI0tpKJL
+1u2eJHpjBjw8yIJWBT/mwaiDSAGuxPWO+awx1uK8w==
=HR6U
-----END PGP SIGNATURE-----

--------------jXOYyrPS0JxKApJ0juxhNY0I--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 15:35:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 15:35:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416289.660946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og6QZ-0003VZ-Ue; Wed, 05 Oct 2022 15:35:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416289.660946; Wed, 05 Oct 2022 15:35:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og6QZ-0003VS-Rl; Wed, 05 Oct 2022 15:35:19 +0000
Received: by outflank-mailman (input) for mailman id 416289;
 Wed, 05 Oct 2022 15:35:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xhym=2G=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1og6QY-0003VL-B6
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 15:35:18 +0000
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
 [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4cede8f3-44c3-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 17:35:14 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 8AD253200488;
 Wed,  5 Oct 2022 11:35:10 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 05 Oct 2022 11:35:10 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 11:35:09 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4cede8f3-44c3-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664984110; x=
	1665070510; bh=lTcbQqqeWc2OmCvINha5oPtLh8mV297W9YFO64soRUs=; b=J
	989BNhT+w/draC5p+5ZBRrrJH75HqVNoRE7cmBkaSlpHl/JQ4UFX195hfwInwSlS
	bCzscooZPQJ66zQa7modNl+wTaRU+GbMNvkDfQfjobqEEKFlWM1PMvmk3eziuGX7
	yiQkEv2rT5ssOwp/KpCBrW89GFWbXTU4MEefYgbU/kgOtGAguoZ+WLSztfLdNHvN
	42+44UWb8htesoir5BTSTWjd6c2d+onQcK1sTg09HlxUoA0ERheckPu7QUkb131j
	rmlx5QHUsix5cClKqGO8X6Q5qpJlrvUyVhRn9JWWvfKUvd8/huWdXVusdCQPcNRG
	cjvpzsQ7WgwfFORvHUL2w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664984110; x=1665070510; bh=lTcbQqqeWc2OmCvINha5oPtLh8mV
	297W9YFO64soRUs=; b=ehpJ582SL0YYy0Eg/KvAOPWsZe9++Du814dI+msCCi2Q
	EkUIzQW036QaE7Zs+4moufwGIzXfQsDrgnSASQujGExYirnaxSyOYuaKETrcJo0Q
	GcLufFNrV+kiHJmfrxUmsFkw8HzNW6wRRIHCAYSPYGMXBhjIR6rUlzV7ioYEjCDA
	0NZ7RkxmCNtgJc9AUTxcQThqsPwYpMVdTGv+mrUl0tPk8ZWh2538DeTA7wO7rvTl
	pcBRom6vsEGpKtuzOiRvEoSCgKF7p5ft7snLo8ZuZfNi69BP8IpecZvoTnaueWHu
	/QMdmtM0j5VK4pomKK9E/5eISQhbHe8UzIGRm35Frg==
X-ME-Sender: <xms:LaQ9Y8tWVQ15UjtdGxCryudMXHcWj9CqdltiGMriyy7DiYBf-v20Iw>
    <xme:LaQ9Y5dyaq43kKKYvM1MnOBykeLgemR9BZvege6HlMXBiuYQQvFDwYLj3emK-pjAF
    UhHyHOkwYgCiA>
X-ME-Received: <xmr:LaQ9Y3zM2nJsP-LLLCwV9JtKoAhuEgiv2zyMF8kPAeaPDyER3NOopPLMDQZJPTHasWhwWQLwNrnuubWWNI50zyyr1tQcS4I5h2Q->
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedgledtucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:LaQ9Y_PkE8oS2U-bAGLe_yuxHrbtjgexi68krUPe9hV9nlBxnEYnDg>
    <xmx:LaQ9Y8-RcvBZpxPcoTlAIZRRJZ3b_lKywCaRt7KoC1Wzijzmfna2FQ>
    <xmx:LaQ9Y3Wrgr34eNm3F0_rU9JsJhd_qETYWIlr8DTfX2J_FzmiqHoTBA>
    <xmx:LqQ9Y1LBe2FHny8cNrAoVH8V0DesZott2t13pTRQLzWAWadAU9t2ig>
Feedback-ID: i1568416f:Fastmail
Date: Wed, 5 Oct 2022 17:35:05 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
Message-ID: <Yz2kKU5qEvD25iJX@mail-itl>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>
 <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com>
 <Yz2L9eTdbA3vS43g@mail-itl>
 <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="QvVVrjpr6f5GNPbq"
Content-Disposition: inline
In-Reply-To: <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com>


--QvVVrjpr6f5GNPbq
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 17:35:05 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt

On Wed, Oct 05, 2022 at 05:04:29PM +0200, Juergen Gross wrote:
> On 05.10.22 15:51, Marek Marczykowski-G=C3=B3recki wrote:
> > On Wed, Oct 05, 2022 at 03:34:56PM +0200, Juergen Gross wrote:
> > > On 05.10.22 15:25, Marek Marczykowski-G=C3=B3recki wrote:
> > > > On Wed, Oct 05, 2022 at 02:57:01PM +0200, Juergen Gross wrote:
> > > > > On 05.10.22 14:41, Marek Marczykowski-G=C3=B3recki wrote:
> > > > > > Hi,
> > > > > >=20
> > > > > > When booting Xen with Linux dom0 nested under KVM,
> > > > > > CONFIG_XEN_VIRTIO_FORCE_GRANT=3Dy makes it unable to use virtio=
 devices
> > > > > > provided by L0 hypervisor (KVM with qemu). With PV dom0, grants=
 are
> > > > > > required for virtio even if just CONFIG_XEN_VIRTIO is enabled.
> > > > > >=20
> > > > > > This is probably uncommon corner case, but one that has bitten =
me in my
> > > > > > CI setup... I think Xen should set smarter
> > > > > > virtio_require_restricted_mem_acc(), that enforces it only for =
devices
> > > > > > really provided by another Xen VM (not by the "outer host"), bu=
t I'm not
> > > > > > sure how that could be done. Any ideas?
> > > > > >=20
> > > > >=20
> > > > > It should be possible to add a boot parameter for that purpose. U=
sing it
> > > > > would open a security hole, though (basically like all PCI passth=
rough to
> > > > > PV guests).
> > > >=20
> > > > What about excluding just dom0? At least currently, there is no way=
 for
> > > > dom0 to see virtio devices provided by another Xen domU.
> > >=20
> > > Even not via hotplug?
> >=20
> > That's why I said "currently", IIUC hotplug of virtio devices under Xen
> > doesn't work yet, no?
> > With hotplug working, it would need to be a proper detection where the
> > backend lives, and probably with some extra considerations re Xen on
> > Xen (based on below, pv-shim could use grants).
>=20
> As stated before, this isn't a problem specific to virtio devices. The sa=
me
> applies to Xen PV devices.

Why is that an issue for Xen PV devices? They always use grants, so no need
for exception. But more relevant here, there is no protocol for L0
hypervisor (that would need to be Xen) to provide PV device to nested L1
guest (besides pv-shim case, which is already handled), so L1 guest
cannot confuse PV device provided by L0 and L1.

> > For me specifically, a command line option would work (because I don't
> > use Xen-based virtio devices when nested under KVM, or anywhere at all,
> > at least not yet), but I can see future cases where you have virtio
> > devices from both L0 and L1 in the same guest, and then it wouldn't be
> > that simple.
>=20
> Lets think of a general solution covering all PV devices (Xen and virtio).

In fact, I wonder what's the security benefit of
CONFIG_XEN_VIRTIO_FORCE_GRANT. If the backend lives in dom0 (or
stubdomain), it can access whole guest memory anyway, whether frontend
likes it or not. But if the backend is elsewhere (or guest is protected
with AMD SEV-SNP, XSM or similar), then the backend won't be able to access
memory outside of what frontend shares explicitly. So, in the non-dom0 case,
backend trying to provide non-grant-based virtio device will simply not
function (because of inability to access guest's memory), instead of
gaining unintended access. Am I missing some implicit memory sharing
here?

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--QvVVrjpr6f5GNPbq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM9pCkACgkQ24/THMrX
1ywGXQf/XDwhrncXUZl9w1kxEZJoQfmJylbOrKU90oOtW1kKB172iFbMfYz/6Ry7
L3YQuGI2Tui+wXTjlIn0uC1c2TlXyII8WJwomK11Sq1mEQAAv673vSzmjq57hxj/
XKMvNeXZGQ0WYOefmKZJHwycLjza1iQ5VMu+LnOMtG/3t+NQ4BTh1QhQhu7CJ4Qi
9efKZDtH6pGLVrF1vpo2Ihqn/c0cLLp3IDwSPfvtBlmHei7vFjfHOtzb8eAdm6Ha
XygnzjUqsa9yKBcw80JsiYcyPl5U9XhaAhKLF8DqYzQc5btwErujeD3plkEn9tEW
aSBkdIYTo894Ot2gwpJosRdU8yEB+w==
=dmqI
-----END PGP SIGNATURE-----

--QvVVrjpr6f5GNPbq--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 15:42:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 15:42:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416298.660957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og6XI-0004vO-Mo; Wed, 05 Oct 2022 15:42:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416298.660957; Wed, 05 Oct 2022 15:42:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og6XI-0004vH-IV; Wed, 05 Oct 2022 15:42:16 +0000
Received: by outflank-mailman (input) for mailman id 416298;
 Wed, 05 Oct 2022 15:42:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=L813=2G=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1og6XH-0004vB-1s
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 15:42:15 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2045.outbound.protection.outlook.com [40.107.247.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 47c4fc4e-44c4-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 17:42:13 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB9398.eurprd04.prod.outlook.com (2603:10a6:102:2b4::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Wed, 5 Oct
 2022 15:42:11 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Wed, 5 Oct 2022
 15:42:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47c4fc4e-44c4-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B6iX8YyYgLBVdFA0qrOF+hj3jc4F9NpSxzPYkD/hnHjF96FSNskCgU3CZTO3AFF2hBQW/Vf63RA+jAkP1Kn26WO8ecEHj1+NTvF0f28G+/vKkn2dywQQlfJDJf1ezvDBbXMUHMs03c1DeVZ+VWIN25uwSCmeDWTYmzcl2n3UfBkEUNOtnsHassgEIK1pERgcQyZ/91LfdJlan6t6VlHK/cgFWWzNc2Hu4cztbQLJ3PIcs9X2uKGl2/0V4oMEKNimJtGBk/zv4oX/cFOCq8c8p+/fBboB4YhSojhNmy12Bev98cfTyur5bbH6BROydQvsFtw7F1iohKoGpknaHHHUlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R45kvSpgNo41zQgGYhyvN7VqsNv2ZbBp46TZEtB2fDM=;
 b=QcwE6ZEy8nlixcWmmT2DE1LVYMDo16nmA6zoOCIz4ZWnXUuU+JPAFxjHWih7AZ1f0wOngYAIgyj+sranFoK5MjsZz8BlbLzp6yXSBpqhxc75+5AmOkWJQMq0VyLWzUFqVTRyshEmldiSx6dmUwdBroVXYhKyPzT13QYVHL7Mhv8/yY/kC44aVyESIcMmHvtxGIUW3gO2PUYziNQg57DZ1VB3NNzr1ya+nsiXdy4cU/GhuxEI+j2Bg5a9SZHR5a1XJatd6ykTvpm2iBEKv120UPsJQCSCPKslu4F9DQpuoILI8oRTdr7o2rjMocwxlyENZs87oRd2eI0/kZTlfIKc1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R45kvSpgNo41zQgGYhyvN7VqsNv2ZbBp46TZEtB2fDM=;
 b=yccSPJdcLWdrB3V5LMbSFJxKQBmYJEeMwIDp1EzbXPgXyivk3513NLBh8Uxbc5I5pic9CdKXSMvLVyGw2JbbM6VU7UxvRRv9PAHbei9O4hDoo3yfMr1rh+WofUH4a+pSdBvUvv5QeQ5AxYdarMno6fZpW6wsXVIm2mM2ROLjRkTa8JQ6ULijbwykhXbyot+FRHWHrV/p1deU2/D6g4hoFHmOuqs6tJdJJW2+FJqG47yroYHM4nRJL/UT+T9nzH9lzIoTXLz8Xu1JiZqKATK75mSdO6izIQ003Tixnhr3DQJalfZSx3j64CCU8wVdHZupbi8Nym5H0Am/4EGF5i0SjA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <544a7408-ea02-db17-39d7-82b7a1f56622@suse.com>
Date: Wed, 5 Oct 2022 17:42:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
 <Yz1CPNwo1hiWZTw2@Air-de-Roger>
 <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
 <Yz2Q1C7Z2zolHAvK@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yz2Q1C7Z2zolHAvK@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9398:EE_
X-MS-Office365-Filtering-Correlation-Id: 8d8bcc14-011b-4d4f-9e2c-08daa6e82a88
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4PQnSJA31XuB3lsP4cs39KPPFBOGUwGKjkStL7JLhYseIFWRx84YB8d1yEx/CC/cI2PL8ILk/eN5rpvEGrAOxFKd0PhmRPuvC4I694IVFBzsu2KN+DVwR/8j4z1lZQ+3yMvIWq0plgDWuFgA5d6UQeXag3uZqBwpeogByCpsTIOPxlIhVDSp8JQhV0FFV3tCGhZofGLIk7uljGkD/voFqeS9TDTu4x4ZcTM1cKA7xF1YoOnghNXLVJ16QZHfIhSiDd8d7hTYCSVxfBaRfpE7D+SGwLyQF8VU3FHKBT192nmff/sNirP0xJboqFuwzLEK1HTiYxc3QBHc7JXnYEt+KukvjNkGeejZn1dfpIje37/1H6BAvuzygmCncvFOEkV6cIFaTlPKYETJDpDy+1vlJhM8FrHuCzX8V9qXWUV7UasAFseQKWdAyJFbAmh+XJPTYk1iEINAPfACxFqM6E53UW6o6coKIDuLK4ymdzRfDAvi/SYbKVBSfiqmQgELGVKESVGvHpOy9gZt3n/aRTBmmjn/J7hzF2ObnAd8OLcTcpa6weO1KjE0hXy979QBSTbk8JB7QyZH25GeR/xUM8NZo/7zmLTuWq17MhAc04pTVC43v8ItG2p/QL3DiURn6ALZBIaeyi0omr1rSDyUM2g5lm50CA60tsoD5FrHkZZg4sswF44GYd/mEKNkFJSWjn8rQ4fQRrphshAaSdXLaiMRMEMACmkDNhsw6uH+EomMJvzs1ay3ikqFHJRiiQXBlJfOABOUunHYW5/LmaHmx+7cKGW+f3txOE0ck2hNWBy2IIw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199015)(31686004)(36756003)(66899015)(86362001)(31696002)(53546011)(6512007)(38100700002)(26005)(2906002)(66556008)(6916009)(83380400001)(5660300002)(8676002)(8936002)(4326008)(186003)(2616005)(41300700001)(66476007)(316002)(6486002)(66946007)(478600001)(6506007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2xBQW9GL09pWks4bjRpWUtUUTUwKzBxUmRsQVova3c0OStCNzBvekdvT202?=
 =?utf-8?B?d25qMEdNSHp6NnpQVG5pa0xWVEQ2ZHhNbUJSNWh4Q05oelpCVHNscEZicGhD?=
 =?utf-8?B?eERkNXRHbDRVVzA1SGhMZGF5VzBuL0RyWnk5V0tvM2Rlbjc1M3p0aG4vRksx?=
 =?utf-8?B?NUp1Z2d0RlNXNk5jb0pycDhaSDdjTW1wUDh4S1B1NU1kN0VaNkJpWWRONVpY?=
 =?utf-8?B?K1pqRmlYN2RDZC9ETlJySVNRa3B5L0dwZUVOUmw4VHIrVzRreVI0TUtmbEVO?=
 =?utf-8?B?cllrdmZORGxwWFJSdC9ReGJRWDZhZDhsV29iRGpUTHM1QXVXZEo1N3R4bEJX?=
 =?utf-8?B?YzZzdTY2OFN4M1FscElmS1ZnaGNvclowVmJLOUdjVGRVTzFPK2JoU1RJUDhu?=
 =?utf-8?B?Q2RIelk4NFVXSThvb0NzbFJTUnRTenNBZTdJSFFQTDdJWTdCTkg3ODBIU1Ix?=
 =?utf-8?B?Qk1aOFd0Mk1zUS9yc240MG5vU3FzbG45R09sSlpmQW45WU1LamZCZUNrV1d4?=
 =?utf-8?B?UGRBUkZ4dFpHMUExNlBWWTZsYWhEbHdaLy9OWWRVV2RyeVY5ZDA5dXB3aWNM?=
 =?utf-8?B?TGplckRZanRXV1ZqQWlQKytkWEhsTlVGOUUvTWlCL3ZRVzZ5RWcxMDMrZkpN?=
 =?utf-8?B?dm9zWGgvVm5uZkc3a21kcFE4TERzZkU3aEhKT1BwZExPU0VuK292MlQydmoz?=
 =?utf-8?B?dWcrSW8xcTJEdVRyM29BTDZWd3ZnMzRuVnVDWnQwR3ErWWFYNXhFMFAySS8w?=
 =?utf-8?B?a3laUklSOXBoNEZ2dFBad3BZczBJVkFlT2lpR3JEUDg2VDdGcVBLd2IxaU1u?=
 =?utf-8?B?WlE1L1Uxb0E4R1R2YlVMckFVR2FEdmx6ZXdvb1dRZ2d0VDYxQ1phWVF3RFFu?=
 =?utf-8?B?aGcyVVo4ZXUrc3l5Sm0xblI3Qi9EVE92bFpWUlRKV21sMkptbDVEcHIwWmJx?=
 =?utf-8?B?SzRHdFlOSUNkcEY0eUsrcFNqMWRDWllybWZ0SWJoNEZ0c1FYalY4cElNZVBI?=
 =?utf-8?B?dnBzT28wT1AySys3TTJnalkxdzNkNW1rbGllS1J5THZIVldRcW96N08xMnZL?=
 =?utf-8?B?OTlaa1hiTXpVYXo5K0t0M2wyMDJ1cyszTW9mRXRjSHRrVGMzT2NZR1dtWGNo?=
 =?utf-8?B?TWN4Y0lNYjk2SXRXLzhCNDhrMVlUekpLMGVkNU5Vb3F1di9uZmtUZUlna3l1?=
 =?utf-8?B?TnlHRTZ1RVVmSlUxUUk4alQxVExkZmEwRWQxSTZUZzFnSHgydmNHeFFITmdr?=
 =?utf-8?B?bGYwUkJ0b3o4RmtRL0F2dEZIVGtJdFViOTBSVmJIY1REQkFzY2ZzTUJnZnhM?=
 =?utf-8?B?L3F3bVM4WkgyTElpZHpITGhha3VMejBPck4vZndDcHhVYzdjQzgzYzF3d09B?=
 =?utf-8?B?Z0kzU3NaU0NnQ1BTTFp5L3pZMnVPYXRnOHBDaVRNcUh2YkRiTWFzWVROMVEw?=
 =?utf-8?B?YWlycldHbHdoeWxYemlMRlpldU5pR2NhTE1kKzBjOTZTYi9IQ0pVNnUvQ2tC?=
 =?utf-8?B?SUZhcXVhZStqQUNqNVYwM2g2NWd0alVZVEE0U2ZKVGFMZW52Vmc0elhCUkFz?=
 =?utf-8?B?VXVmWlgzSG9iLzNHSlpJemwrWUI2MTFKZmo4QjM4YnVYNmR5Y3dTVjgzcEl5?=
 =?utf-8?B?c3pjWlJMa2pxSTZ2eDV3ZTR2L0xoRFExSGliOGQzZ1doQjE1RUlTd0FwYURY?=
 =?utf-8?B?M3B3Y1I2VmI0WHYxbStObnRZSVhSUk91ajRTN2NSeElkYmhuMDVEdHJBL0Rr?=
 =?utf-8?B?U2NJQUk1ZzVJTi9iMHROc014TUxMOURxSGdWalh4T2tLWDlXTElQTldkc3Vu?=
 =?utf-8?B?WG1CT3dhRTdyOWdQN3dpSndjRHdRVDBQTURiem5oQ3lLeDNra2NiNGpOa2lx?=
 =?utf-8?B?QzZnVzBjYUJHTmVBYzNpUmYxTzZRbUFXSWdHS3kxc0VvUzRTcnZncXVudEFG?=
 =?utf-8?B?UUNWNW9CQldyQ1Jydyt2R0lNc1Z0cDdmdEEwWTRkK2h6WDFXSzhYZ2QzalB1?=
 =?utf-8?B?RlJscjNYUlpTWEVoOWtUbDA1M096U1lGSldUUUpTR2s2R1lOSnlENHRQYlVM?=
 =?utf-8?B?UjhoUmwzcGlweS9VaVdxeVVvVDhmWDhFRzRWTjZickdTK0VnamUvSUMrSnN1?=
 =?utf-8?Q?7/Ij4xaaNgwrf4tzQEBLlqDM9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d8bcc14-011b-4d4f-9e2c-08daa6e82a88
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 15:42:10.3816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i5aMUsrexRmZ/IdtkGF+O+WFF0WomtEDtXaSfclGtSucITK+emOBol+3qMdVNstu9D3G6yZdJmK3gwo3OLzLrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9398

On 05.10.2022 16:12, Roger Pau Monné wrote:
> Hm, I have the following diff attached below which is more limited,
> and not so bad I think.  Initially I wanted to introduce an
> efi_all_mapped() helper, but that would require exposing EFI_MEMORY_TYPE
> which is quite intrusive.
> 
> Let me know if you think the proposal below is better and I will
> formally send a patch with it.

Hmm, personally I like this slightly better for, as you say, its more
limited effect. Objectively, however, I'm still unconvinced of making
this an EFI special case. How would non-EFI firmware go about
communicating that it is going to access a device at runtime (which,
as said before, I consider a no-go in the first place)? Likely by
putting its BAR range(s) in an E820_RESERVED region.

Plus the MMIO range covered on the system in question is pretty large.
That way we're still allowing pretty wide an abuse by the firmware.
Furthermore the MCFG range would also be covered by an
EfiMemoryMappedIO descriptor (in fact that's the only use of the type
I had been aware of so far). IOW the change specifically permits an
overlap of a BAR with an MCFG range.

Who's the manufacturer of the system? Or put in different words - how
likely is it that we could first gain understanding on their
intentions with this region? You did say the system hangs hard without
some kind of workaround, but that doesn't clarify to me in how far a
use of the device by the firmware was actually involved there.

Have you considered other routes towards dealing with the issue? One
approach coming to mind would build on top of what you've been doing
so far (either variant): Besides avoiding the turning off of memory
decode, also invoke pci_ro_device(), thus protecting it from having
its BARs relocated, and also preventing any driver in Dom0 to gain
control of it, thus avoiding two parties competing for the device.

Relocating the BAR outside of the reserved region would be nice, but
will likely not resolve the hang.

In any event I'm still hoping to have a 3rd view on the situation as a
whole, irrespective of specific ideas towards possible workarounds ...

Independent of the above a couple of purely cosmetic comments:

> @@ -98,3 +99,28 @@ int pci_conf_write_intercept(unsigned int seg, unsigned int bdf,
>  
>      return rc;
>  }
> +
> +bool pci_check_bar(const struct pci_dev *pdev, mfn_t start, mfn_t end)
> +{
> +    /*
> +     * Check if BAR is not overlapping with any memory region defined
> +     * in the memory map.
> +     */
> +    if ( is_memory_hole(start, end) )
> +        return true;
> +
> +    /*
> +     * Also allow BARs placed on EfiMemoryMappedIO regions in order to deal
> +     * with EFI firmware using those regions to place the BARs of devices that
> +     * can be used during runtime.  But print a warning when doing so.
> +     */
> +    if ( !efi_all_runtime_mmio(mfn_to_maddr(start),
> +                               mfn_to_maddr(mfn_add(end, 1))) )
> +        return false;
> +
> +    printk(XENLOG_WARNING
> +           "%pp: BAR [%#" PRI_mfn ", %#" PRI_mfn "] overlaps reserved region\n",
> +           &pdev->sbdf, mfn_x(start), mfn_x(end));

Perhaps re-word the message now that the check is a different one?

> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -78,6 +78,30 @@ bool efi_enabled(unsigned int feature)
>      return test_bit(feature, &efi_flags);
>  }
>  
> +/*
> + * This function checks if the entire range [start,end) is contained inside of
> + * a single EfiMemoryMappedIO descriptor with the runtime attribute set.
> + */
> +bool efi_all_runtime_mmio(uint64_t start, uint64_t end)
> +{
> +    unsigned int i;
> +
> +    for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
> +    {
> +        EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;

const?

> +        uint64_t len = desc->NumberOfPages << EFI_PAGE_SHIFT;
> +
> +        if ( desc->Type != EfiMemoryMappedIO ||
> +             !(desc->Attribute & EFI_MEMORY_RUNTIME) )
> +            continue;
> +
> +        if ( start >= desc->PhysicalStart && end <= desc->PhysicalStart + len )
> +            return true;
> +    }
> +
> +    return false;
> +}
> +
>  #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */

Perhaps put the function inside this #ifdef?

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 15:46:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 15:46:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416308.660968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og6at-0005eh-9f; Wed, 05 Oct 2022 15:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416308.660968; Wed, 05 Oct 2022 15:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og6at-0005ea-6v; Wed, 05 Oct 2022 15:45:59 +0000
Received: by outflank-mailman (input) for mailman id 416308;
 Wed, 05 Oct 2022 15:45:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ugva=2G=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1og6as-0005eS-AL
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 15:45:58 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd7d3ce9-44c4-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 17:45:57 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 956451F8D1;
 Wed,  5 Oct 2022 15:45:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E27713345;
 Wed,  5 Oct 2022 15:45:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id v0JrHbSmPWM1SgAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 05 Oct 2022 15:45:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd7d3ce9-44c4-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1664984756; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TpBzPmJIAtSaRs0h+cceiJA73uDEVV38dIoDlYGqkkY=;
	b=DEUYwLdO/aZtiyevuj0C8xA3+5G+T2BGQEXpct4gEhA33mHVkJ7mM4+qnFL760+Yh3ImwK
	9bKNELcLInZSxmsFUAywuaBIqcUl+1b8sMXig3nhCFIaA1yXXqqcuJnBcTLgWiwWaHEWvh
	5TSeMt49qAeF944/CVc3BDdCQB+Un9A=
Message-ID: <a8366482-ba75-19e7-4e82-ba968ec9ddcb@suse.com>
Date: Wed, 5 Oct 2022 17:45:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com> <Yz2L9eTdbA3vS43g@mail-itl>
 <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com> <Yz2kKU5qEvD25iJX@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
In-Reply-To: <Yz2kKU5qEvD25iJX@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jyYE0pN4nrQoCl0FhJJ8GDww"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jyYE0pN4nrQoCl0FhJJ8GDww
Content-Type: multipart/mixed; boundary="------------eAR0Jx87y5n7uwgxmMqiFs00";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <a8366482-ba75-19e7-4e82-ba968ec9ddcb@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com> <Yz2L9eTdbA3vS43g@mail-itl>
 <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com> <Yz2kKU5qEvD25iJX@mail-itl>
In-Reply-To: <Yz2kKU5qEvD25iJX@mail-itl>

--------------eAR0Jx87y5n7uwgxmMqiFs00
Content-Type: multipart/mixed; boundary="------------MjS4cVdE20cqdY2SxR1kgPXJ"

--------------MjS4cVdE20cqdY2SxR1kgPXJ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTc6MzUsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDU6MDQ6MjlQTSArMDIwMCwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IE9uIDA1LjEwLjIyIDE1OjUxLCBNYXJlayBNYXJjenlrb3dza2kt
R8OzcmVja2kgd3JvdGU6DQo+Pj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDM6MzQ6NTZQ
TSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gT24gMDUuMTAuMjIgMTU6MjUs
IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToNCj4+Pj4+IE9uIFdlZCwgT2N0
IDA1LCAyMDIyIGF0IDAyOjU3OjAxUE0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+
Pj4+Pj4gT24gMDUuMTAuMjIgMTQ6NDEsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3
cm90ZToNCj4+Pj4+Pj4gSGksDQo+Pj4+Pj4+DQo+Pj4+Pj4+IFdoZW4gYm9vdGluZyBYZW4g
d2l0aCBMaW51eCBkb20wIG5lc3RlZCB1bmRlciBLVk0sDQo+Pj4+Pj4+IENPTkZJR19YRU5f
VklSVElPX0ZPUkNFX0dSQU5UPXkgbWFrZXMgaXQgdW5hYmxlIHRvIHVzZSB2aXJ0aW8gZGV2
aWNlcw0KPj4+Pj4+PiBwcm92aWRlZCBieSBMMCBoeXBlcnZpc29yIChLVk0gd2l0aCBxZW11
KS4gV2l0aCBQViBkb20wLCBncmFudHMgYXJlDQo+Pj4+Pj4+IHJlcXVpcmVkIGZvciB2aXJ0
aW8gZXZlbiBpZiBqdXN0IENPTkZJR19YRU5fVklSVElPIGlzIGVuYWJsZWQuDQo+Pj4+Pj4+
DQo+Pj4+Pj4+IFRoaXMgaXMgcHJvYmFibHkgdW5jb21tb24gY29ybmVyIGNhc2UsIGJ1dCBv
bmUgdGhhdCBoYXMgYml0dGVuIG1lIGluIG15DQo+Pj4+Pj4+IENJIHNldHVwLi4uIEkgdGhp
bmsgWGVuIHNob3VsZCBzZXQgc21hcnRlcg0KPj4+Pj4+PiB2aXJ0aW9fcmVxdWlyZV9yZXN0
cmljdGVkX21lbV9hY2MoKSwgdGhhdCBlbmZvcmNlcyBpdCBvbmx5IGZvciBkZXZpY2VzDQo+
Pj4+Pj4+IHJlYWxseSBwcm92aWRlZCBieSBhbm90aGVyIFhlbiBWTSAobm90IGJ5IHRoZSAi
b3V0ZXIgaG9zdCIpLCBidXQgSSdtIG5vdA0KPj4+Pj4+PiBzdXJlIGhvdyB0aGF0IGNvdWxk
IGJlIGRvbmUuIEFueSBpZGVhcz8NCj4+Pj4+Pj4NCj4+Pj4+Pg0KPj4+Pj4+IEl0IHNob3Vs
ZCBiZSBwb3NzaWJsZSB0byBhZGQgYSBib290IHBhcmFtZXRlciBmb3IgdGhhdCBwdXJwb3Nl
LiBVc2luZyBpdA0KPj4+Pj4+IHdvdWxkIG9wZW4gYSBzZWN1cml0eSBob2xlLCB0aG91Z2gg
KGJhc2ljYWxseSBsaWtlIGFsbCBQQ0kgcGFzc3Rocm91Z2ggdG8NCj4+Pj4+PiBQViBndWVz
dHMpLg0KPj4+Pj4NCj4+Pj4+IFdoYXQgYWJvdXQgZXhjbHVkaW5nIGp1c3QgZG9tMD8gQXQg
bGVhc3QgY3VycmVudGx5LCB0aGVyZSBpcyBubyB3YXkgZm9yDQo+Pj4+PiBkb20wIHRvIHNl
ZSB2aXJ0aW8gZGV2aWNlcyBwcm92aWRlZCBieSBhbm90aGVyIFhlbiBkb21VLg0KPj4+Pg0K
Pj4+PiBFdmVuIG5vdCB2aWEgaG90cGx1Zz8NCj4+Pg0KPj4+IFRoYXQncyB3aHkgSSBzYWlk
ICJjdXJyZW50bHkiLCBJSVVDIGhvdHBsdWcgb2YgdmlydGlvIGRldmljZXMgdW5kZXIgWGVu
DQo+Pj4gZG9lc24ndCB3b3JrIHlldCwgbm8/DQo+Pj4gV2l0aCBob3RwbHVnIHdvcmtpbmcs
IGl0IHdvdWxkIG5lZWQgdG8gYmUgYSBwcm9wZXIgZGV0ZWN0aW9uIHdoZXJlIHRoZQ0KPj4+
IGJhY2tlbmQgbGl2ZXMsIGFuZCBwcm9iYWJseSB3aXRoIHNvbWUgZXh0cmEgY29uc2lkZXJh
dGlvbnMgcmUgWGVuIG9uDQo+Pj4gWGVuIChiYXNlZCBvbiBiZWxvdywgcHYtc2hpbSBjb3Vs
ZCB1c2UgZ3JhbnRzKS4NCj4+DQo+PiBBcyBzdGF0ZWQgYmVmb3JlLCB0aGlzIGlzbid0IGEg
cHJvYmxlbSBzcGVjaWZpYyB0byB2aXJ0aW8gZGV2aWNlcy4gVGhlIHNhbWUNCj4+IGFwcGxp
ZXMgdG8gWGVuIFBWIGRldmljZXMuDQo+IA0KPiBXaHkgaXMgdGhhdCBhbiBpc3N1ZSBmb3Ig
WGVuIFBWIGRldmljZXM/IFRoZXkgYWx3YXlzIHVzZSBncmFudHMsIHNvIG5vIG5lZWQNCj4g
Zm9yIGV4Y2VwdGlvbi4gQnV0IG1vcmUgcmVsZXZhbnQgaGVyZSwgdGhlcmUgaXMgbm8gcHJv
dG9jb2wgZm9yIEwwDQo+IGh5cGVydmlzb3IgKHRoYXQgd291bGQgbmVlZCB0byBiZSBYZW4p
IHRvIHByb3ZpZGUgUFYgZGV2aWNlIHRvIG5lc3RlZCBMMQ0KPiBndWVzdCAoYmVzaWRlcyBw
di1zaGltIGNhc2UsIHdoaWNoIGlzIGFscmVhZHkgaGFuZGxlZCksIHNvIEwxIGd1ZXN0DQo+
IGNhbm5vdCBjb25mdXNlIFBWIGRldmljZSBwcm92aWRlZCBieSBMMCBhbmQgTDEuDQoNClRo
YXQncyB0aGUgcG9pbnQuIFRvZGF5IHVzaW5nIHZpcnRpbyB0aGUgd2F5IHlvdSBhcmUgdXNp
bmcgaXQgaXMgcG9zc2libGUNCm9ubHkgYmVjYXVzZSB2aXJ0aW8gZGV2aWNlcyBkb24ndCBo
YXZlIHRoZSBzZWN1cml0eSBmZWF0dXJlcyBvZiBYZW4gUFYNCmRldmljZXMuIFdpdGggYWRk
aW5nIGdyYW50IHN1cHBvcnQgZm9yIHZpcnRpbyBkZXZpY2VzIHRoaXMgaGFzIGNoYW5nZWQu
DQoNCkJUVywgeW91IGNhbiBoYXZlIHRoZSBvbGQgdmlydGlvIGJlaGF2aW9yIGJhY2sgYnkg
bm90IGVuYWJsaW5nDQpDT05GSUdfWEVOX1ZJUlRJTy4NCg0KPiANCj4+PiBGb3IgbWUgc3Bl
Y2lmaWNhbGx5LCBhIGNvbW1hbmQgbGluZSBvcHRpb24gd291bGQgd29yayAoYmVjYXVzZSBJ
IGRvbid0DQo+Pj4gdXNlIFhlbi1iYXNlZCB2aXJ0aW8gZGV2aWNlcyB3aGVuIG5lc3RlZCB1
bmRlciBLVk0sIG9yIGFueXdoZXJlIGF0IGFsbCwNCj4+PiBhdCBsZWFzdCBub3QgeWV0KSwg
YnV0IEkgY2FuIHNlZSBmdXR1cmUgY2FzZXMgd2hlcmUgeW91IGhhdmUgdmlydGlvDQo+Pj4g
ZGV2aWNlcyBmcm9tIGJvdGggTDAgYW5kIEwxIGluIHRoZSBzYW1lIGd1ZXN0LCBhbmQgdGhl
biBpdCB3b3VsZG4ndCBiZQ0KPj4+IHRoYXQgc2ltcGxlLg0KPj4NCj4+IExldHMgdGhpbmsg
b2YgYSBnZW5lcmFsIHNvbHV0aW9uIGNvdmVyaW5nIGFsbCBQViBkZXZpY2VzIChYZW4gYW5k
IHZpcnRpbykuDQo+IA0KPiBJbiBmYWN0LCBJIHdvbmRlciB3aGF0J3MgdGhlIHNlY3VyaXR5
IGJlbmVmaXQgb2YNCj4gQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQuIElmIHRoZSBi
YWNrZW5kIGxpdmVzIGluIGRvbTAgKG9yDQo+IHN0dWJkb21haW4pLCBpdCBjYW4gYWNjZXNz
IHdob2xlIGd1ZXN0IG1lbW9yeSBhbnl3YXksIHdoZXRoZXIgZnJvbnRlbmQNCj4gbGlrZXMg
aXQgb3Igbm90LiBCdXQgaWYgdGhlIGJhY2tlbmQgaXMgZWxzZXdoZXJlIChvciBndWVzdCBp
cyBwcm90ZWN0ZWQNCj4gd2l0aCBBTUQgU0VWLVNOUCwgWFNNIG9yIHNpbWlsYXIpLCB0aGVu
IHRoZSBiYWNrZW5kIHdvbid0IGJlIGFibGUgdG8gYWNjZXNzDQo+IG1lbW9yeSBvdXRzaWRl
IG9mIHdoYXQgZnJvbnRlbmQgc2hhcmVzIGV4cGxpY2l0bHkuIFNvLCBpbiB0aGUgbm9uLWRv
bTAgY2FzZSwNCj4gYmFja2VuZCB0cnlpbmcgdG8gcHJvdmlkZSBub24tZ3JhbnQtYmFzZWQg
dmlydGlvIGRldmljZSB3aWxsIHNpbXBseSBub3QNCj4gZnVuY3Rpb24gKGJlY2F1c2Ugb2Yg
aW5hYmlsaXR5IHRvIGFjY2VzcyBndWVzdCdzIG1lbW9yeSksIGluc3RlYWQgb2YNCj4gZ2Fp
bmluZyB1bmludGVuZGVkIGFjY2Vzcy4gQW0gSSBtaXNzaW5nIHNvbWUgaW1wbGljaXQgbWVt
b3J5IHNoYXJpbmcNCj4gaGVyZT8NCg0KWW91IGFyZSBtaXNzaW5nIHRoZSBwb3NzaWJpbGl0
eSB0byBoYXZlIGEgZGVwcml2aWxlZ2VkIHVzZXIgbGFuZCB2aXJ0aW8NCmJhY2tlbmQuDQoN
CkFuZCBCVFcsIFNFViB3b24ndCBkaXNhYmxlIGd1ZXN0IG1lbW9yeSBhY2Nlc3MsIGl0IHdp
bGwganVzdCBtYWtlIGl0DQppbXBvc3NpYmxlIHRvIGludGVycHJldGUgbWVtb3J5IGNvbnRl
bnRzIGZyb20gb3V0c2lkZS4gQSBtYWxpY2lvdXMNCmJhY2tlbmQgY2FuIHN0aWxsIGVhc2ls
eSBjcmFzaCBhIFNFViBndWVzdCBieSBjbG9iYmVyaW5nIGl0cyBtZW1vcnkuDQoNCg0KSnVl
cmdlbg0K
--------------MjS4cVdE20cqdY2SxR1kgPXJ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------MjS4cVdE20cqdY2SxR1kgPXJ--

--------------eAR0Jx87y5n7uwgxmMqiFs00--

--------------jyYE0pN4nrQoCl0FhJJ8GDww
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM9prQFAwAAAAAACgkQsN6d1ii/Ey/v
wQf8DYQ+OvhzkYSYeVdl3r5iOMNy8nFRgJG84fdQTNNBdGnEsNrGRB8V8E2V4mFugpou/jMWsIT2
NfXVB8S3M0cl0bflt6cfHah1ovej5S927FhjsslMm+vKoRYjJWaBLEZ3Iu0ajObRf7xdocx3oEXt
Bm+6vfzE+wrCfehP8bdDxJIXzq8HCuwrEXcLxFSM//Owd1vOz8oKm0B2pMwaRrKgo5MD23VwgfyX
2SkqHlhrL2Y4SnBkbhK6IGlDAMBVlw5lqN2EnBYqr6uwhaZTKoBhN/aUSHEL7lrgNswbg/pDYd+E
xADtgSlrPKSn4nUJiAazNSNYQxc7wafmFwsGmSF7uA==
=amos
-----END PGP SIGNATURE-----

--------------jyYE0pN4nrQoCl0FhJJ8GDww--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 16:48:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 16:48:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416315.660979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og7ZD-0003oA-PM; Wed, 05 Oct 2022 16:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416315.660979; Wed, 05 Oct 2022 16:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og7ZD-0003o3-Mc; Wed, 05 Oct 2022 16:48:19 +0000
Received: by outflank-mailman (input) for mailman id 416315;
 Wed, 05 Oct 2022 16:48:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xhym=2G=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1og7ZB-0003nx-J1
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 16:48:18 +0000
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8013709f-44cd-11ed-9377-c1cf23e5d27e;
 Wed, 05 Oct 2022 18:48:14 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id 78C7532009A0;
 Wed,  5 Oct 2022 12:48:11 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Wed, 05 Oct 2022 12:48:11 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 12:48:10 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8013709f-44cd-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664988491; x=
	1665074891; bh=Wz79Y4QspfEe6xO7znUVT3XLtocL4VjnzI0m/nYf2tU=; b=0
	MSdH3B9/uLN4p8fpR6yYaYJiErne9bLH+kz12ZxfOFxP73m8Z2LFBIZPGmwcEj3O
	+w01s8fcZG2UtDiDDQrqnp0gxuoRRyguqbKkOKgx9kBJwgcnMglRPnwarADmOQrw
	GL66eTlIl3KmWmsgCMkRPqDrZq3Qu/nAJZHj28mTUZqtYXfg+77PcrpxySk1d4Fj
	VkSkxWbSUpWxbANkcT6lpmsFvhCI8hg5JFSy/W4WkOU43N6R4gfuQnoRAWtVx4NG
	WyKXrZgpJwo6G1BGBz2cWvUlLgqiz7xhhdcYpXuM2WHqS6fkGCMAZz6CCVSHdwLE
	ISefBChC/TRWcmlptRkRQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664988491; x=1665074891; bh=Wz79Y4QspfEe6xO7znUVT3XLtocL
	4VjnzI0m/nYf2tU=; b=YX4kAzE7AE+Z+QRvAr8gEZdqY4tkcjzYPpD5/r4Mwt7g
	JLc6SV18cSJCUEmRfvi26G3rMAmKSeW5cWe0UdXYHUNGTKOUEBrDQEBkb14atWZt
	/2dnlajtp7jOA8OBHo+zjAZakoZgNtQ17IP0EyZZ1WpdfZyIXSoRDOr0tbQ9Evex
	TUa9NF591QC0c8d6PSDgoZAvWobXcAapBRjnB6rcMxm4Z/T5TiM1KUCcW7qlBnfG
	i2kCkicsX0n3n/VZRAGxUDqFJPxpgyUz+9a7uBuX2uUFqFcpzbGh988uyL+WQfsj
	FRNg9aeStSeqODrAMSB3zsoXZHQ4fYNdzgleax/XMw==
X-ME-Sender: <xms:SrU9Y-_jOXgMmKM8m1pbV6HahL1ooJ7jhO-LW3RXAiP5wLamIKiV2g>
    <xme:SrU9Y-viuN1GWSk4L_OJMXQz6EJHPg_B8V3PSXkXLAaF8iiKz1SIxSWTIqmMau-tm
    PM1rgKquoquDw>
X-ME-Received: <xmr:SrU9Y0AYnHVOykcyymN2bzOVtxGxG_EfoeKuPOJabTqBjLRYaEeSg2ES5GenMBboCOAxnRZDUE9nLdTumYJII90s7f1rlI5wHXet>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedguddtgecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghr
    vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih
    hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg
    udelteefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlh
    hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv
    khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:SrU9Y2c_I3GG_SRWnW8S3VwPxn6UZCiUAjhbVhjWBJ9U7ny8jbYNCA>
    <xmx:SrU9YzNNMNiCEoQLFQtu9hZA8k0SyoGbSH-gocBmfxs-Icdj1xoKXQ>
    <xmx:SrU9YwlN11docgzOZXI-5OrI2JB1Le9_ZKTb6ljTBExcnEu55aPmtQ>
    <xmx:S7U9YyZogJrCdJHSOXREjv-2rU98y1rYHb64DKLOZ-X0JKUOBOSEwQ>
Feedback-ID: i1568416f:Fastmail
Date: Wed, 5 Oct 2022 18:48:07 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
Message-ID: <Yz21RxJ9xXP8ODb0@mail-itl>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com>
 <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com>
 <Yz2L9eTdbA3vS43g@mail-itl>
 <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com>
 <Yz2kKU5qEvD25iJX@mail-itl>
 <a8366482-ba75-19e7-4e82-ba968ec9ddcb@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="5Wzz3ezRb+3DS3xP"
Content-Disposition: inline
In-Reply-To: <a8366482-ba75-19e7-4e82-ba968ec9ddcb@suse.com>


--5Wzz3ezRb+3DS3xP
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 18:48:07 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt

On Wed, Oct 05, 2022 at 05:45:56PM +0200, Juergen Gross wrote:
> On 05.10.22 17:35, Marek Marczykowski-G=C3=B3recki wrote:
> > On Wed, Oct 05, 2022 at 05:04:29PM +0200, Juergen Gross wrote:
> > > On 05.10.22 15:51, Marek Marczykowski-G=C3=B3recki wrote:
> > > > On Wed, Oct 05, 2022 at 03:34:56PM +0200, Juergen Gross wrote:
> > > > > On 05.10.22 15:25, Marek Marczykowski-G=C3=B3recki wrote:
> > > > > > On Wed, Oct 05, 2022 at 02:57:01PM +0200, Juergen Gross wrote:
> > > > > > > On 05.10.22 14:41, Marek Marczykowski-G=C3=B3recki wrote:
> > > > > > > > Hi,
> > > > > > > >=20
> > > > > > > > When booting Xen with Linux dom0 nested under KVM,
> > > > > > > > CONFIG_XEN_VIRTIO_FORCE_GRANT=3Dy makes it unable to use vi=
rtio devices
> > > > > > > > provided by L0 hypervisor (KVM with qemu). With PV dom0, gr=
ants are
> > > > > > > > required for virtio even if just CONFIG_XEN_VIRTIO is enabl=
ed.
> > > > > > > >=20
> > > > > > > > This is probably uncommon corner case, but one that has bit=
ten me in my
> > > > > > > > CI setup... I think Xen should set smarter
> > > > > > > > virtio_require_restricted_mem_acc(), that enforces it only =
for devices
> > > > > > > > really provided by another Xen VM (not by the "outer host")=
, but I'm not
> > > > > > > > sure how that could be done. Any ideas?
> > > > > > > >=20
> > > > > > >=20
> > > > > > > It should be possible to add a boot parameter for that purpos=
e. Using it
> > > > > > > would open a security hole, though (basically like all PCI pa=
ssthrough to
> > > > > > > PV guests).
> > > > > >=20
> > > > > > What about excluding just dom0? At least currently, there is no=
 way for
> > > > > > dom0 to see virtio devices provided by another Xen domU.
> > > > >=20
> > > > > Even not via hotplug?
> > > >=20
> > > > That's why I said "currently", IIUC hotplug of virtio devices under=
 Xen
> > > > doesn't work yet, no?
> > > > With hotplug working, it would need to be a proper detection where =
the
> > > > backend lives, and probably with some extra considerations re Xen on
> > > > Xen (based on below, pv-shim could use grants).
> > >=20
> > > As stated before, this isn't a problem specific to virtio devices. Th=
e same
> > > applies to Xen PV devices.
> >=20
> > Why is that an issue for Xen PV devices? They always use grants, so no =
need
> > for exception. But more relevant here, there is no protocol for L0
> > hypervisor (that would need to be Xen) to provide PV device to nested L1
> > guest (besides pv-shim case, which is already handled), so L1 guest
> > cannot confuse PV device provided by L0 and L1.
>=20
> That's the point. Today using virtio the way you are using it is possible
> only because virtio devices don't have the security features of Xen PV
> devices. With adding grant support for virtio devices this has changed.
>=20
> BTW, you can have the old virtio behavior back by not enabling
> CONFIG_XEN_VIRTIO.

Yes, I know, and currently I'm doing it. But at some point I'd like to
be able to enable CONFIG_XEN_VIRTIO without breaking the nested virt
case. Ideally KVM virtio devices would use something like grants, and
that thing would work even through nested virt, but I don't think that's
strictly necessary for ensuring new security properties of virtio
devices where they can be enforced.

> > > > For me specifically, a command line option would work (because I do=
n't
> > > > use Xen-based virtio devices when nested under KVM, or anywhere at =
all,
> > > > at least not yet), but I can see future cases where you have virtio
> > > > devices from both L0 and L1 in the same guest, and then it wouldn't=
 be
> > > > that simple.
> > >=20
> > > Lets think of a general solution covering all PV devices (Xen and vir=
tio).
> >=20
> > In fact, I wonder what's the security benefit of
> > CONFIG_XEN_VIRTIO_FORCE_GRANT. If the backend lives in dom0 (or
> > stubdomain), it can access whole guest memory anyway, whether frontend
> > likes it or not. But if the backend is elsewhere (or guest is protected
> > with AMD SEV-SNP, XSM or similar), then the backend won't be able to ac=
cess
> > memory outside of what frontend shares explicitly. So, in the non-dom0 =
case,
> > backend trying to provide non-grant-based virtio device will simply not
> > function (because of inability to access guest's memory), instead of
> > gaining unintended access. Am I missing some implicit memory sharing
> > here?
>=20
> You are missing the possibility to have a deprivileged user land virtio
> backend.

Ok, but that backend either can xenforeignmemory_map() arbitrary guest's
page (in which case it doesn't matter if the frontend driver likes
non-grant-based device or not), or it cannot (in which case,
non-grant-based device will simply not work, backend still won't have
access to the guest memory).

Sure, the error reporting might be different, but I don't think it
changes the outcome security-wise.

> And BTW, SEV won't disable guest memory access, it will just make it
> impossible to interprete memory contents from outside. A malicious
> backend can still easily crash a SEV guest by clobbering its memory.

Right.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--5Wzz3ezRb+3DS3xP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmM9tUcACgkQ24/THMrX
1ywYIgf/YrI9enxWgrm58SnJGhwYzSPY0j1rXFwnxi+OpOuxAuQycNT55Lka9k26
30nQ8V1+mOQ7OZwT/Tx+kAhnqjr8A+gWFMwCUu+jK5GWf+KRwSeKUyw4a/OS7Gsj
UewoFF3doEHD8NmfpOxHqVW48j/pTtl9xTLsacNc3uTL2L87mZe543b1WaH1Ds56
sY8fb3t5a/ghGZLEkIN/OUyZndyiuDLg5cK/ZnhRUO8RD+v46Gd+HGp8f7zp77Mu
hZap1u9Yu5sCxm7pPMIjP3dMrWZvsKljKquY4o8dGcnzLN9bE0B8/jI2MaJsjDj0
jvo7DOBxSPsLzjv7dUdlOL1ITkUEJw==
=mHfg
-----END PGP SIGNATURE-----

--5Wzz3ezRb+3DS3xP--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 16:56:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 16:56:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416323.660990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og7hD-0005Gu-Hv; Wed, 05 Oct 2022 16:56:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416323.660990; Wed, 05 Oct 2022 16:56:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og7hD-0005Gn-Ej; Wed, 05 Oct 2022 16:56:35 +0000
Received: by outflank-mailman (input) for mailman id 416323;
 Wed, 05 Oct 2022 16:56:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og7hC-0005Gd-5z; Wed, 05 Oct 2022 16:56:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og7hB-0004o0-Tr; Wed, 05 Oct 2022 16:56:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og7hB-0003jY-CD; Wed, 05 Oct 2022 16:56:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1og7hB-0003uv-9I; Wed, 05 Oct 2022 16:56:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kDSu8vLvH/ng1F7zSxLl8eWFQ6JC3pbfBrBX/2jzBRo=; b=Gpmko8UiLwzojs5qeA9RK4aMiI
	xTt3hEz/Om086ah7Lp6OIfDCwbRYUaymOQSytFMt1REhpdGZ33Vev28noa5UEUj5an216tCCrXSFR
	mz8MQPTym74jDcGpOLG+cggRFi4h6iWDEwmYfu21ldGTGdbLqIFaisFSZFmSnpJTJj7A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173426-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173426: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-saverestore.2:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
X-Osstest-Versions-That:
    linux=0326074ff4652329f2a1a9c8685104576bd8d131
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 16:56:33 +0000

flight 173426 linux-linus real [real]
flight 173432 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173426/
http://logs.test-lab.xenproject.org/osstest/logs/173432/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 18 guest-saverestore.2 fail pass in 173432-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173421
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173421
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173421
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173421
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173421
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173421
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173421
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173421
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
baseline version:
 linux                0326074ff4652329f2a1a9c8685104576bd8d131

Last test of basis   173421  2022-10-05 00:13:01 Z    0 days
Testing same since   173426  2022-10-05 08:41:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adam Skladowski <a39.skl@gmail.com>
  Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b
  Akhil R <akhilrajeev@nvidia.com>
  Aleksa Savic <savicaleksa83@gmail.com>
  Aleksandr Mezin <mezin.alexander@gmail.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexandru Gagniuc <mr.nuke.me@gmail.com>
  Andrew Halaney <ahalaney@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Armin Wolf <W_Armin@gmx.de>
  Asmaa Mnebhi <asmaa@nvidia.com>
  Axel Lin <axel.lin@ingics.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Chanho Park <chanho61.park@samsung.com>
  Christian Kohlschütter <christian@kohlschutter.com>
  Christian Kohlschütter <christian@kohlschutter.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Colin Ian King <colin.i.king@gmail.com>
  Conor Dooley <conor.dooley@microchip.com>
  Corey Minyard <cminyard@mvista.com> # for IPMI
  Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  David Wu <david.wu@rock-chips.com>
  Dmitry Rokosov <ddrokosov@sberdevices.ru>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Duke Du <dukedu83@gmail.com>
  Eliav Farber <farbere@amazon.com>
  Eugene Shalygin <eugene.shalygin@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Gustavo A. R. Silva <gustavoars@kernel.org>
  Heiko Stuebner <heiko@sntech.de>
  Ibrahim Tilki <Ibrahim.Tilki@analog.com>
  Iskren Chernev <iskren.chernev@gmail.com>
  Jagan Teki <jagan@edgeble.ai>
  Jan Dabros <jsd@semihalf.com>
  Jarkko Nikula <jarkko.nikula@linux.intel.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jean Delvare <jdelvare@suse.de>
  Jerome Neanne <jneanne@baylibre.com>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Johan Jonker <jbx6244@gmail.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio
  Josef Johansson <josef@oderland.se>
  Juerg Haefliger <juergh@proton.me>
  Justin Ledford <justinledford@google.com>
  Krzysztof Hałasa <khalasa@piap.pl>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
  Li Yang <leoyang.li@nxp.com>
  Li Zhong <floridsleeves@gmail.com>
  Liang He <windhl@126.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Lucas Tanure <tanureal@opensource.cirrus.com>
  Mani Milani <mani@chromium.org>
  Marek Behún <kabel@kernel.org> # for leds-turris-omnia
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Markus Schneider-Pargmann <msp@baylibre.com>
  Matti Vaittinen <mazziesaccount@gmail.com>
  Max Filippov <jcmvbkbc@gmail.com>
  Mengda Chen <chenmengda2009@163.com>
  Michael Ellerman <mpe@ellerman.id.au> (powerpc)
  Michael Shych <michaelsh@nvidia.com>
  Michal Simek <michal.simek@amd.com>
  Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s
  Mika Westerberg <mika.westerberg@linux.intel.com>
  Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>
  Neil Armstrong <narmstrong@baylibre.com>
  Oleksandr Shamray <oleksandrs@nvidia.com>
  Patrice Chotard <patrice.chotard@foss.st.com>
  Patrick Rudolph <patrick.rudolph@9elements.com>
  Pavel Machek <pavel@ucw.cz>
  Peng Fan <peng.fan@nxp.com>
  Peter Robinson <pbrobinson@gmail.com>
  Peter Rosin <peda@axentia.se>
  Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860
  Quan Nguyen <quan@os.amperecomputing.com>
  Richard Acayan <mailingradian@gmail.com>
  Rob Herring <robh@kernel.org>
  Robert Marko <robert.marko@sartura.hr>
  Samuel Holland <samuel@sholland.org>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Sergio Paracuellos <sergio.paracuellos@gmail.com>
  Shang XiaoJing <shangxiaojing@huawei.com>
  Shreeya Patel <shreeya.patel@collabora.com>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013
  Sudarshan Ravula <sudarshan.ravula@intel.com>
  Sudip Mukherjee <sudipm.mukherjee@gmail.com>
  Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>
  Tomer Maimon <tmaimon77@gmail.com>
  Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wilken Gottwalt <wilken.gottwalt@posteo.net>
  William Breathitt Gray <william.gray@linaro.org>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Wolfram Sang <wsa@kernel.org>
  Xu Qiang <xuqiang36@huawei.com>
  Yang Li <yang.lee@linux.alibaba.com>
  Yang Yingliang <yangyingliang@huawei.com>
  ye xingchen <ye.xingchen@zte.com.cn>
  Zeng Heng <zengheng4@huawei.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  zhichao.liu <zhichao.liu@mediatek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   0326074ff465..2bca25eaeba6  2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 17:34:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 17:34:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416334.661001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8I4-00018I-KH; Wed, 05 Oct 2022 17:34:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416334.661001; Wed, 05 Oct 2022 17:34:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8I4-00018B-HJ; Wed, 05 Oct 2022 17:34:40 +0000
Received: by outflank-mailman (input) for mailman id 416334;
 Wed, 05 Oct 2022 17:34:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og8I4-000181-3h; Wed, 05 Oct 2022 17:34:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og8I3-0005SG-TX; Wed, 05 Oct 2022 17:34:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1og8I3-0007Fn-DD; Wed, 05 Oct 2022 17:34:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1og8I3-0001Kq-BH; Wed, 05 Oct 2022 17:34:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hofVQqiRva7bmpX234ZXeGYZSgSb8nSXdgJIVoj/eDE=; b=53bbwN/BqtqFxToEzMOyIsUfdi
	e78oI4NSITb2NNT3GtdQOQQQWZJbqmFp0YMpPQ0hvwMsLgvynqgX7ZzisDpBIRYWlRsrr05AOogcj
	ydNasqezkyI6+IyRnJ4vm/s8eEReOtrtszeq1CxGMkS+MUIttgaOuZMICIkYqL5Fu78g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173427-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173427: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-examine:host-install:broken:regression
    linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f28b7414ab715e6069e72a7bbe2f1354b2524beb
X-Osstest-Versions-That:
    linux=6215647d9699cb8f1bf7333ec849242c4a9cf9a6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 17:34:39 +0000

flight 173427 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173427/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-examine      5 host-install           broken REGR. vs. 173353
 test-amd64-i386-qemut-rhel6hvm-amd  7 xen-install        fail REGR. vs. 173353
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 173353
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 173353
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 173353

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds      8 xen-boot                 fail REGR. vs. 173353

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173353
 test-amd64-i386-libvirt-pair 10 xen-install/src_host         fail  like 173353
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173353
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173353
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173353
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f28b7414ab715e6069e72a7bbe2f1354b2524beb
baseline version:
 linux                6215647d9699cb8f1bf7333ec849242c4a9cf9a6

Last test of basis   173353  2022-09-28 09:15:02 Z    7 days
Testing same since   173427  2022-10-05 08:44:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Alistair Popple <apopple@nvidia.com>
  Andrew Morton <akpm@linux-foundation.org>
  Arnd Bergmann <arnd@arndb.de>
  Bjørn Mork <bjorn@mork.no>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <caihuoqing@baidu.com>
  Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christoph Hellwig <hch@lst.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Hildenbrand <david@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Fabio Estevam <festevam@denx.de>
  Faiz Abbas <faiz_abbas@ti.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Han Xu <han.xu@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heiko Stuebner <heiko@sntech.de>
  Hongling Zeng <zenghongling@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Michael Kelley <mikelley@microsoft.com>
  Michal Hocko <mhocko@suse.com>
  Minchan Kim <minchan@kernel.org>
  Niklas Cassel <niklas.cassel@wdc.com>
  Paolo Abeni <pabeni@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Xu <peterx@redhat.com>
  Rafał Miłecki <rafal@milecki.pl>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sergei Antonov <saproj@gmail.com>
  Stephen Boyd <sboyd@kernel.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Tony Lindgren <tony@atomide.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Wang Yufen <wangyufen@huawei.com>
  Yang Shi <shy828301@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  YuTong Chang <mtwget@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     fail    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-step test-amd64-amd64-examine host-install

Not pushing.

(No revision log; it would be 919 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 17:48:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 17:48:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416378.661030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8VX-0003fW-61; Wed, 05 Oct 2022 17:48:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416378.661030; Wed, 05 Oct 2022 17:48:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8VX-0003fN-3F; Wed, 05 Oct 2022 17:48:35 +0000
Received: by outflank-mailman (input) for mailman id 416378;
 Wed, 05 Oct 2022 17:48:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QTo3=2G=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1og8VV-0003fH-Tr
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 17:48:33 +0000
Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com
 [2a00:1450:4864:20::62b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id edf09bb1-44d5-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 19:48:33 +0200 (CEST)
Received: by mail-ej1-x62b.google.com with SMTP id nb11so37079026ejc.5
 for <xen-devel@lists.xenproject.org>; Wed, 05 Oct 2022 10:48:33 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 ee32-20020a056402292000b0044e7862ab3fsm4320697edb.7.2022.10.05.10.48.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 05 Oct 2022 10:48:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edf09bb1-44d5-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=T7vmkKrcbukpzojz/C0yPU7kDNmejVOGQprU/+VGjPg=;
        b=dVi25dvodr8t/gBegAqLu+rK8KzgAh4keTp2/KK7+Fje72aOUSQprjCW9gEVTRPyjx
         tAR/dx3QTfQXRA6VPY4wpM3my7uLryBptIJgQEwf488NAfjAoP8LVPe8RNH3JH2nF7sx
         aSCqpz5VQahY6uVL7dwnQMyPVmiXdxxw0KbZxftvRhnAbhmWO/tMzRIJy/UhRt5/60f2
         DCQUCakAm6HPmMzYpnTSZVSIwee3DWyUMQHfzVhPsxXN3b2Nl7nX2LF2JoXdLaGHNfxB
         H+UxR4u7ojJZ444EYA93u8Pv20FyYp56cTV856Mn9ZVwPFmHgjPuzwjeAMe7GKYfUEZZ
         da9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=T7vmkKrcbukpzojz/C0yPU7kDNmejVOGQprU/+VGjPg=;
        b=x1RFQMx3GNkcezm9QjXQ4mq6JoaNgZUMJVivzY31TYsN7YR2bhxipwmvL4s/e3+V3m
         H0xbT6n/jOt3faKWofCtlyaz5Yt4pDGOYKu7FpaswOoELfbN6l5J5EjFbwwQUKDevY96
         EiJOWzQCZ/oMbL1mSbxaomn1xdGUbj9v2MHe+xdHrciGMl17LN/zX4aTMWIL9P5e7O7e
         QLYBjMrJYu8wObhVs9Px64HQy2ltLu3xBmY3bVDaRceHrvDBaZSiGo7PgzG8tzbxv+3Z
         cHSeVX55U7IyvUel6uDmlDe4S1HhFEhp30gFLIAOq5I70U0vk20SKjZvUDnx2F53kvpk
         BM8A==
X-Gm-Message-State: ACrzQf2g/EYv1SDXOpMzotPtKvuGzctMobyy1bwRO6k4NjwzeN2YU3Fs
	x6Z79851GmUavPHN6DcWjTbUk3DOS20=
X-Google-Smtp-Source: AMsMyM743WLaut2TEDuu9Otx1L5edbBgqf2bI1BtlwsFJAYPKcXauwkgwejLZrQib1lNS1Y2SACG3w==
X-Received: by 2002:a17:907:5c2:b0:77e:def7:65d8 with SMTP id wg2-20020a17090705c200b0077edef765d8mr596533ejb.487.1664992111996;
        Wed, 05 Oct 2022 10:48:31 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 0/2] Misc fixes for Xen grant DMA-mapping layer
Date: Wed,  5 Oct 2022 20:48:21 +0300
Message-Id: <20221005174823.1800761-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

These are several fixes I collected when playing with virtio-net device
using Xen grant mappings.

Tested with both virtio-blk and virtio-net devices.

Oleksandr Tyshchenko (2):
  xen/virtio: Fix n_pages calculation in xen_grant_dma_map(unmap)_page()
  xen/virtio: Fix potential deadlock when accessing
    xen_grant_dma_devices

 drivers/xen/grant-dma-ops.c | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 17:48:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 17:48:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416381.661052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8VZ-0004BN-RJ; Wed, 05 Oct 2022 17:48:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416381.661052; Wed, 05 Oct 2022 17:48:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8VZ-0004B7-OK; Wed, 05 Oct 2022 17:48:37 +0000
Received: by outflank-mailman (input) for mailman id 416381;
 Wed, 05 Oct 2022 17:48:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QTo3=2G=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1og8VY-0003fH-Af
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 17:48:36 +0000
Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com
 [2a00:1450:4864:20::636])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ef7b0aa5-44d5-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 19:48:35 +0200 (CEST)
Received: by mail-ej1-x636.google.com with SMTP id o21so744309ejm.11
 for <xen-devel@lists.xenproject.org>; Wed, 05 Oct 2022 10:48:35 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 ee32-20020a056402292000b0044e7862ab3fsm4320697edb.7.2022.10.05.10.48.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 05 Oct 2022 10:48:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef7b0aa5-44d5-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=2ygXgrMvwI83oTWciRbWlrh/kQps7FfPG+yghSVi9/U=;
        b=NDy/TvK3L7DC7SkJDhT99xIPSRmwqUPUnB9VOPISmgU4v7mI2YvcoR1ddz/qLrnw+0
         JtBz1FcFB8Hh4CpZJIL5Q+9dR1Kvk7FSPZ0QY57RKem+vG3zMyPQvs2nEtW3eP9DlSte
         Q4Q00ZX8taSGQ9FGTZwSmDEE/CU7q3Waw2GQgwV/QleXYiFIkD1QBokMpLj5yTgyFGg3
         H2LNVp4TR3NuYpy0KYQENae1x6fej8VH6Je2Fa2B8fJCHhTADIKgj4isSF/rvP0nhV5E
         3bMD3Rl83GS3q/aaSd70GK9gqKLw7jMxWByorqPO22D1SN2zgBz4kAvKbkZBYcwxBZDh
         KA0A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=2ygXgrMvwI83oTWciRbWlrh/kQps7FfPG+yghSVi9/U=;
        b=C+zR+qAQUNDA/CDhPkDrXXZDFlTPIYt7TSB7J4ImKmKcs3C4nrW3EUkmtfyoRVmNjR
         c6XZk4h7BmO/dQujdUHFHrUXnlIcfdB/jCTn/GLZfxe8dO+GnU1plmMvcXReJoPgk4Ph
         D5lyxxq14z1jyfyV4HQC3o2P+3a7C96lzfYNuxP7mXYOKP0g77wq9iST2EVyW/HcQVGM
         RLqYlRgRPJskYxy8HlWpPs30Q8lCIULDHszmvoJyGyh9zbpL6e5pQ4oNXYkSk0zOUrob
         5rW0/YPvLs8SOwjkiodv3eCUwSthMAAB+BSK7yeMrdTsDW4K3csOCstDbEmWm9OihaMB
         zbgg==
X-Gm-Message-State: ACrzQf2N0d0k7r4rqb22vO0LKsqQMyHeoyYBfC4EBbR5Fx4w0ewkob5S
	a6EzfYUMMKHB9obDrhOifVLSTtbhCDM=
X-Google-Smtp-Source: AMsMyM4gLayulwBKZ3oV/w4C4GfrZsOmtMMi5W8Of0+00e76+GDcK9bgiaaGE+JcXnb5caWk4vJrHg==
X-Received: by 2002:a17:906:cc14:b0:78d:2267:3a57 with SMTP id ml20-20020a170906cc1400b0078d22673a57mr596908ejb.241.1664992114759;
        Wed, 05 Oct 2022 10:48:34 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 2/2] xen/virtio: Fix potential deadlock when accessing xen_grant_dma_devices
Date: Wed,  5 Oct 2022 20:48:23 +0300
Message-Id: <20221005174823.1800761-3-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221005174823.1800761-1-olekstysh@gmail.com>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

As find_xen_grant_dma_data() is called from both interrupt and process
contexts, the access to xen_grant_dma_devices XArray must be protected
by xa_lock_irqsave to avoid deadlock scenario.
As XArray API doesn't provide xa_store_irqsave helper, call lockless
__xa_store directly and guard it externally.

Also move the storage of the XArray's entry to a separate helper.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict memory access under Xen")
---
 drivers/xen/grant-dma-ops.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 1998d0e8ce82..c66f56d24013 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -25,7 +25,7 @@ struct xen_grant_dma_data {
 	bool broken;
 };
 
-static DEFINE_XARRAY(xen_grant_dma_devices);
+static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
 
 #define XEN_GRANT_DMA_ADDR_OFF	(1ULL << 63)
 
@@ -42,14 +42,29 @@ static inline grant_ref_t dma_to_grant(dma_addr_t dma)
 static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
 {
 	struct xen_grant_dma_data *data;
+	unsigned long flags;
 
-	xa_lock(&xen_grant_dma_devices);
+	xa_lock_irqsave(&xen_grant_dma_devices, flags);
 	data = xa_load(&xen_grant_dma_devices, (unsigned long)dev);
-	xa_unlock(&xen_grant_dma_devices);
+	xa_unlock_irqrestore(&xen_grant_dma_devices, flags);
 
 	return data;
 }
 
+static int store_xen_grant_dma_data(struct device *dev,
+				    struct xen_grant_dma_data *data)
+{
+	unsigned long flags;
+	int ret;
+
+	xa_lock_irqsave(&xen_grant_dma_devices, flags);
+	ret = xa_err(__xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,
+			GFP_ATOMIC));
+	xa_unlock_irqrestore(&xen_grant_dma_devices, flags);
+
+	return ret;
+}
+
 /*
  * DMA ops for Xen frontends (e.g. virtio).
  *
@@ -338,8 +353,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	 */
 	data->backend_domid = iommu_spec.args[0];
 
-	if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,
-			GFP_KERNEL))) {
+	if (store_xen_grant_dma_data(dev, data)) {
 		dev_err(dev, "Cannot store Xen grant DMA data\n");
 		goto err;
 	}
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 17:48:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 17:48:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416379.661040 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8VY-0003v0-Eh; Wed, 05 Oct 2022 17:48:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416379.661040; Wed, 05 Oct 2022 17:48:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8VY-0003ut-Be; Wed, 05 Oct 2022 17:48:36 +0000
Received: by outflank-mailman (input) for mailman id 416379;
 Wed, 05 Oct 2022 17:48:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QTo3=2G=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1og8VX-0003fH-6y
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 17:48:35 +0000
Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com
 [2a00:1450:4864:20::62e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eed704e3-44d5-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 19:48:34 +0200 (CEST)
Received: by mail-ej1-x62e.google.com with SMTP id k2so7121038ejr.2
 for <xen-devel@lists.xenproject.org>; Wed, 05 Oct 2022 10:48:34 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 ee32-20020a056402292000b0044e7862ab3fsm4320697edb.7.2022.10.05.10.48.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 05 Oct 2022 10:48:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eed704e3-44d5-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=lUqPpYv5HbJS3RJZgdTtH5zBJM8cF/Q/yQo70/LIPGg=;
        b=q2NAXUerg5Qq4svf9ZBclqSa7jhIsyyWtisVfdHoR09jVE9TUdLqPM4efflTILBJ2E
         1QzruERT96PZYju0r7C2ZaHvg30mr5WuMueOXGd/ZwvoZmmuOUN13WUjo0E1wd+IbDqs
         BHtddK4HNWj9DlWucI/LF6hcSCBL5vdIlYwIr7rf7LHwpwKw1u0JzBn48GS4yFmoiv+C
         BXfd99AdwgNOMIo8PqFDtYXynE8wj8nj18ErlAFmAjYKe4avYXwKc2MTtpfsUUJ0Hr+d
         nyJcbqw+4Yt20d6Zxo8CDJDZfh2dhLrWeY1cgcrGP5JOqbkMqzLlOTlOQlgFouD46h6r
         MMng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=lUqPpYv5HbJS3RJZgdTtH5zBJM8cF/Q/yQo70/LIPGg=;
        b=sNyYJOSRJzkOojEVEp8LqCP/WX03axbkZHiFGjvLuGQBm1DbOR7V9EQNCeybUnAGOT
         b+5OQRDOKjkxaXZ1f+Fy1LM8/Zxqb8fh7esFvTbFHgT/C18yjcQexk+nnFZEUSyavu86
         Wyb/Mi/tSIV0K5Kjf7Qa7aGFAivcn3QclcPhhe6OObJuKzYUUWPkEJTSXudpdRP9N14X
         29PuNYGC/blThAIDcDXCFJeB8VVU9iaMR+VlPMCsfy+I+Es/m36fl/Puadh8jKLfJUHm
         Mxw5ZGeDgx7KjdYrHTXHyszxUIDfOuYg8ubW6hPzbbUMANXbVqZ/JKVEI1kw5M63ja2C
         7vAg==
X-Gm-Message-State: ACrzQf1hjKoauVlUwcFmJRRIxVbkj7VbWOn1LoYMSXBWW35rg9+STCSu
	Ttic1Kf8dTGmESHOsHbCbQpN149dm7A=
X-Google-Smtp-Source: AMsMyM7qFxTtDClHub9HwGnUCHbj0K2B+uD3aLcbrl4tDcKrhmWQ/TdQGfyyThVB1O4Bfc/Y82Eqaw==
X-Received: by 2002:a17:906:4ac1:b0:780:3448:ff06 with SMTP id u1-20020a1709064ac100b007803448ff06mr587283ejt.403.1664992113581;
        Wed, 05 Oct 2022 10:48:33 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 1/2] xen/virtio: Fix n_pages calculation in xen_grant_dma_map(unmap)_page()
Date: Wed,  5 Oct 2022 20:48:22 +0300
Message-Id: <20221005174823.1800761-2-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221005174823.1800761-1-olekstysh@gmail.com>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Take page offset into the account when calculating the number of pages
to be granted.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict memory access under Xen")
---
 drivers/xen/grant-dma-ops.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 8973fc1e9ccc..1998d0e8ce82 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -153,7 +153,7 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 					 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(size);
+	unsigned int i, n_pages = PFN_UP(offset + size);
 	grant_ref_t grant;
 	dma_addr_t dma_handle;
 
@@ -185,7 +185,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
 				     unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(size);
+	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
+	unsigned int i, n_pages = PFN_UP(offset + size);
 	grant_ref_t grant;
 
 	if (WARN_ON(dir == DMA_NONE))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 05 18:09:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 18:09:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416415.661063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8pW-0007QN-Eh; Wed, 05 Oct 2022 18:09:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416415.661063; Wed, 05 Oct 2022 18:09:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8pW-0007QG-BP; Wed, 05 Oct 2022 18:09:14 +0000
Received: by outflank-mailman (input) for mailman id 416415;
 Wed, 05 Oct 2022 18:09:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1og8pV-0007QA-Aw
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 18:09:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1og8pU-00067l-8h; Wed, 05 Oct 2022 18:09:12 +0000
Received: from [15.248.2.156] (helo=[10.24.69.12])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1og8pU-0003Zu-29; Wed, 05 Oct 2022 18:09:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DDOWMiXl3ZYKn/6trM9iAQoXF675FzN0U26RxzHHwNY=; b=gNOzipcYLeUhUDieoC/+VAsrY8
	ZH1CuCNPqnTDNKXU2fv8x6ZtiaDuFwjmg8osBiRWm5REZ9WBKzbazJVEheEBH4xvUDQYyWk0MA7Bc
	yY7zyVej9HFQ4zA6aDvE/sl9RP2e/MnDsVX2bwkk7NyHy1U0sCpmpmQ4C29oFGfpChl4=;
Message-ID: <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
Date: Wed, 5 Oct 2022 19:09:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
 <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 05/10/2022 12:55, Jan Beulich wrote:
> On 05.10.2022 12:44, Julien Grall wrote:
>> On 04/10/2022 16:58, Jan Beulich wrote:
>>> On 30.09.2022 14:51, Bertrand Marquis wrote:
>>>>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>
>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>> runtime which was re-used for other purposes, make
>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>
>>>>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>>>>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>>>>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
>>>
>>> Thanks. However ...
>>>
>>>>> ---
>>>>> Partly RFC for Arm, for two reasons:
>>>>>
>>>>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>>>>> For one like on x86 such ranges would likely better be retained, as Dom0
>>>>> may (will?) have a need to look at tables placed there. Plus converting
>>>>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>>>>> me as well. I'd be inclined to make the latter adjustment right here
>>>>> (while the other change probably would better be separate, if there
>>>>> aren't actually reasons for the present behavior).
>>>
>>> ... any views on this WB aspect at least (also Stefano or Julien)? Would be
>>> good to know before I send v2.
>>
>> I don't quite understand what you are questioning here. Looking at the
>> code, EfiACPIReclaimMemory will not be converted to RAM but added in a
>> separate array.
>>
>> Furthermore, all the EfiACPIReclaimMemory regions will be passed to dom0
>> (see acpi_create_efi_mmap_table()).
>>
>> So to me the code looks correct.
> 
> Oh, I've indeed not paid enough attention to the first argument passed
> to meminfo_add_bank(). I'm sorry for the extra noise. However, the
> question I wanted to have addressed before sending out v3 was that
> regarding the present using of memory when EFI_MEMORY_WB is not set.
> Is that correct for the EfiACPIReclaimMemory case, i.e. is the
> consumer (Dom0) aware that there might be a restriction?

Looking at the code, we always set EFI_MEMORY_WB for the reclaimable 
region and the stage-2 mapping will be cachable.

So it looks like there would be a mismatch if EFI_MEMORY_WB is not set. 
However, given the region is reclaimable, shouldn't this imply that the 
flag is always set?

> And would
> this memory then be guaranteed to never be freed into the general pool
> of RAM pages?

The region is not treated as RAM by Xen and not owned by the dom0. 
Therefore, it should not be possible to free the page because 
get_page_from_gfn() would not be able to get a reference.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 18:11:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 18:11:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416422.661074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8s0-0000MM-SK; Wed, 05 Oct 2022 18:11:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416422.661074; Wed, 05 Oct 2022 18:11:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1og8s0-0000MF-Ph; Wed, 05 Oct 2022 18:11:48 +0000
Received: by outflank-mailman (input) for mailman id 416422;
 Wed, 05 Oct 2022 18:11:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mtJI=2G=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1og8rz-0000M9-Gt
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 18:11:47 +0000
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a977d69-44d9-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 20:11:45 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id A648B5C0066;
 Wed,  5 Oct 2022 14:11:42 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Wed, 05 Oct 2022 14:11:42 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 14:11:40 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a977d69-44d9-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1664993502; x=
	1665079902; bh=QbCwngRgoYYz/l1YN30XHGdNSPXH235wrNnuhXtSynU=; b=m
	dofbwBSXXpVc47Gw1UKfW0vy+ZwFa54+XYyP6WxQdDjvqxoBR5y6lizxIKXT9aH9
	LXYnXvrAx6VCW98nyL8n10sjKJfGEqr77IvgOvTKDTheQGrEKKgC3R05//KhQfpw
	Vz1iRtp2zR8cdqmLG7/XCXkos1F0cZE8PZKNrd9zP3Nss6GtCSrjUki7twc9To6V
	EbjrxeR5Cchvk+ZWfjP1ThTbhmm/qTrFM5ACx3CFWnrrHiVZjH26xeGx/kLx5GJT
	jp/wpXSXOTLtaxT5R07RCVuIZoFw1fsFPT7Nw7LA5buVGvOQIjsYZewAbLP5bZcU
	AFVX4XSw4JgZLhAr8x1Rg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1664993502; x=1665079902; bh=QbCwngRgoYYz/l1YN30XHGdNSPXH
	235wrNnuhXtSynU=; b=G340+HVxAL5emcB+vjDp5hw4bDA+v5WG1ZFCwRdgNZGB
	Is33jyKhwM5ZwlBW244da9wDkRroz1YoMn7kcgRKy5MPeWPQpCCD63CdtOXKBivs
	3M2bDK4bKjhTN7ajrAFNbjXoAeNxP/RiV321XVsAkTnLEuzFw9qlgZPBO/n2WjJZ
	OlJQSFxrILKELZy/0icUhenIfwTKegtMGc5XOxHtSPMfN4Tc9w6CJP87zdK11NQw
	PFHUa2S0M2JXFAPht8QpxDvxaOdbK2sgsNjRLHBzLuHFq97zkuX4cXharEcoVpnB
	nu5TINRyuxEDXXclOR19n3tvgwZnO9WuOFtuefBk1w==
X-ME-Sender: <xms:3cg9Y7lqjpZMxu-QxWl1OrPIlI4w-Wb46EPUu26JSfbRb3T1d0ZMPA>
    <xme:3cg9Y-3CBycGN4IY_3GxzOZEHP7PrmyNgy2APil8kg02MS7gJwtXY4uolb4ZImHCQ
    vv9b_cydzjV02I>
X-ME-Received: <xmr:3cg9YxpFS8ffE2bMi3LeAmtxeEKoFts6WEjpuT7dz4A8v_2oqjlurj9KDOb7>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeifedguddvtdcutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffej
    geejgeffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtne
    curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg
    shhlrggsrdgtohhm
X-ME-Proxy: <xmx:3cg9Yzk0_f9FDheCCp8-NE0pehcvboQOGQtsBViZGaLkuhmUaluhoQ>
    <xmx:3cg9Y502ikq_7tu_9kpRVAP2sWh4o9tM1o7HfPlsd_x5YuTLciU7TA>
    <xmx:3cg9YyvrjOlaQPguFvYnGfddah9HMMSE4vbpOjMgW0XRbo0nT8-U5g>
    <xmx:3sg9YyuqDzGmeCycYAl5Avr_jWlIbwHesCToCsPRFtkwgIAloXqnRA>
Feedback-ID: iac594737:Fastmail
Date: Wed, 5 Oct 2022 14:11:35 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Message-ID: <Yz3I2qwl243h9ZfZ@itl-email>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email>
 <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email>
 <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MP5CI1py1S/x6cIa"
Content-Disposition: inline
In-Reply-To: <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>


--MP5CI1py1S/x6cIa
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 14:11:35 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered

On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > Linux has a function called efi_mem_reserve() that is used to reserve
> > EfiBootServicesData memory that contains e.g. EFI configuration tables.
> > This function does not work under Xen because Xen could have already
> > clobbered the memory.  efi_mem_reserve() not working is the whole reason
> > for this thread, as it prevents EFI tables that are in
> > EfiBootServicesData from being used under Xen.
> >=20
> > A much nicer approach would be for Xen to reserve boot services memory
> > unconditionally, but provide a hypercall that dom0 could used to free
> > the parts of EfiBootServicesData memory that are no longer needed.  This
> > would allow efi_mem_reserve() to work normally.
>=20
> efi_mem_reserve() actually working would be a layering violation;
> controlling the EFI memory map is entirely Xen's job.

Doing this properly would require Xen to understand all of the EFI
tables that could validly be in EfiBootServices* and which could be of
interest to dom0.  It might (at least on some very buggy firmware)
require a partial ACPI and/or SMBIOS implementation too, if the firmware
decided to put an ACPI or SMBIOS table in EfiBootServices*.

> As to the hypercall you suggest - I wouldn't mind its addition, but only
> for the case when -mapbs is used. As I've indicated before, I'm of the
> opinion that default behavior should be matching the intentions of the
> spec, and the intention of EfiBootServices* is for the space to be
> reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
> that hypercall: It might use it for regions where data lives which it
> wouldn't care about itself, but which an eventual kexec-ed (or alike)
> entity would later want to consume. Code/data potentially usable by
> _anyone_ between two resets of the system cannot legitimately be freed
> (and hence imo is wrong to live in EfiBootServices* regions).

I agree, but currently some such data *is* in EfiBootServices* regions,
sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
configuration tables that point to EfiBootServicesData memory before
freeing that memory.

> In a way one could view the Dom0 kernel as an "or alike" entity ...

It is indeed such an entity.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--MP5CI1py1S/x6cIa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM9yNoACgkQsoi1X/+c
IsGIrRAAqlFxw4VhBVBYtbOHJoeLu1cjHKS/FF5d16yMLnb2yCt9fGSDRIb0L8dR
EG8AmPkMpyXINDJYGR4H4jvLqMF3a51W708ZkLKsT6uEFkVfsjB3VD4BYCzZ5ss7
O84Lfv4GXaxIQn0oXU+SGM47bgA9ahrhmWeDi2AthvrIkb6+1rd9lrd0oiGwfE90
IW5ojsRQaQl7sr1gnm97lg5/Pv9zDh4RMsPMqMOuOg9Pq7wkZVCUYmkjdsA4CRnB
3lNeJdK5IMlL1tmstWZxvWoHrLMWYeGtKslJKYJcWN5CGjgoXs3g8HakbIfOxnif
D5ikSG1A++CqpHTxieovQ8Q5yIQBFTHNTuncXoZp0iqjq6bMfx9qo2tNJda9Oay8
TEqzSDiSeruz4bS5iiILCqNME02ZtcQAXizR9PZ/wNmbfb2EEhu9R2L2aPLBrgNp
hs56nrJ9McRpJXlmqENxwrTgp81rMEgb2cZsxymNqsEzBhRHP/peWjoHby1BVHb0
Q5oNp+rn1lnPJDV1bGrLlUxDfU/ttucJEsEttGCp42GFgnzNihtni3mMFTCWQG1B
X335/qvdsVqBkm5775p+u1MoPNdrEtYAID3ubhp1rfhgp9peup1Ua9Fv2oZ5j90G
T2YYIkuLpo07nXGKRO/JffO0EdLAMvjz0DeSJRQwbQtsGqeLekE=
=C84z
-----END PGP SIGNATURE-----

--MP5CI1py1S/x6cIa--


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 21:29:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 21:29:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416469.661103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogBwg-0003EZ-8d; Wed, 05 Oct 2022 21:28:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416469.661103; Wed, 05 Oct 2022 21:28:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogBwg-0003ES-4s; Wed, 05 Oct 2022 21:28:50 +0000
Received: by outflank-mailman (input) for mailman id 416469;
 Wed, 05 Oct 2022 21:28:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Evou=2G=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ogBwe-0003EC-9W
 for xen-devel@lists.xenproject.org; Wed, 05 Oct 2022 21:28:48 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b060cf52-44f4-11ed-964a-05401a9f4f97;
 Wed, 05 Oct 2022 23:28:45 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 73103617B9
 for <xen-devel@lists.xenproject.org>; Wed,  5 Oct 2022 21:28:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D396FC433D7
 for <xen-devel@lists.xenproject.org>; Wed,  5 Oct 2022 21:28:42 +0000 (UTC)
Received: by mail-lf1-f43.google.com with SMTP id g1so27320057lfu.12
 for <xen-devel@lists.xenproject.org>; Wed, 05 Oct 2022 14:28:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b060cf52-44f4-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665005322;
	bh=muJbnrIp210gb7fqTfOmWC0eIYWfolnwyOXDDn4od4c=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=onC1wgsK10b0LnSICn+HrmdzrnxCEMSH9xhj/y3+IbllcnAGBvno4qaFXFBCRry25
	 UrJJrWXg9K3QdgB9eXnisqnIIJQPtQepqs0juwRz19jvZjikXxigCozNXd39rEorJv
	 6XPkUiV4UGf3vBFiZ9sSFqJcQcNjRkgu2ktS+j1pNchdV1N0MwSKPn/D0s/pNUDtCJ
	 3CrkAmu0zDJExS0jBdZ1F9DpPBvywQVE+N2UF13AeNeCiEg80vFg6Cpal7s4LZwXBB
	 iVIUuWZZUN7B5vAo25F+7A5lflU+r/3lgNX95TT2mMIdZB5mzGE1EBEbk/1mfRvItG
	 g1/kQ7TrTRyOw==
X-Gm-Message-State: ACrzQf3gmBR06C2i3Z3g83cYDkzcafyWvO4ABEnU5ylLxBxd3FRyYlgk
	78zOAW7uKu5izxRzcwp0bnEO9QllaD8jMTaitf8=
X-Google-Smtp-Source: AMsMyM5ENCqkTVBxrzmq8hfVrlBZGy4ldUcnDApXzpb2VxRM/05S1UkqQQqEZ2D+hH1YOqSqFKb8NTMRIjJTusgjT10=
X-Received: by 2002:a05:6512:261b:b0:4a1:abd7:3129 with SMTP id
 bt27-20020a056512261b00b004a1abd73129mr637352lfb.637.1665005320796; Wed, 05
 Oct 2022 14:28:40 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com> <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email> <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email> <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email> <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com> <Yz3I2qwl243h9ZfZ@itl-email>
In-Reply-To: <Yz3I2qwl243h9ZfZ@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Wed, 5 Oct 2022 23:28:29 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
Message-ID: <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, 
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > Linux has a function called efi_mem_reserve() that is used to reserve
> > > EfiBootServicesData memory that contains e.g. EFI configuration tables.
> > > This function does not work under Xen because Xen could have already
> > > clobbered the memory.  efi_mem_reserve() not working is the whole reason
> > > for this thread, as it prevents EFI tables that are in
> > > EfiBootServicesData from being used under Xen.
> > >
> > > A much nicer approach would be for Xen to reserve boot services memory
> > > unconditionally, but provide a hypercall that dom0 could used to free
> > > the parts of EfiBootServicesData memory that are no longer needed.  This
> > > would allow efi_mem_reserve() to work normally.
> >
> > efi_mem_reserve() actually working would be a layering violation;
> > controlling the EFI memory map is entirely Xen's job.
>
> Doing this properly would require Xen to understand all of the EFI
> tables that could validly be in EfiBootServices* and which could be of
> interest to dom0.  It might (at least on some very buggy firmware)
> require a partial ACPI and/or SMBIOS implementation too, if the firmware
> decided to put an ACPI or SMBIOS table in EfiBootServices*.
>
> > As to the hypercall you suggest - I wouldn't mind its addition, but only
> > for the case when -mapbs is used. As I've indicated before, I'm of the
> > opinion that default behavior should be matching the intentions of the
> > spec, and the intention of EfiBootServices* is for the space to be
> > reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
> > that hypercall: It might use it for regions where data lives which it
> > wouldn't care about itself, but which an eventual kexec-ed (or alike)
> > entity would later want to consume. Code/data potentially usable by
> > _anyone_ between two resets of the system cannot legitimately be freed
> > (and hence imo is wrong to live in EfiBootServices* regions).
>
> I agree, but currently some such data *is* in EfiBootServices* regions,
> sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
> configuration tables that point to EfiBootServicesData memory before
> freeing that memory.
>

That seems like a reasonable approach to me. Tables like MEMATTR or
RT_PROP are mostly relevant for bare metal where the host kernel maps
the runtime services, and in general, passing on these tables without
knowing what they do is kind of fishy anyway. You might even argue
that only known table types should be forwarded in the first place,
regardless of the memory type.


From xen-devel-bounces@lists.xenproject.org Wed Oct 05 21:40:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 05 Oct 2022 21:40:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416476.661114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogC7r-0006xf-8I; Wed, 05 Oct 2022 21:40:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416476.661114; Wed, 05 Oct 2022 21:40:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogC7r-0006xY-5Q; Wed, 05 Oct 2022 21:40:23 +0000
Received: by outflank-mailman (input) for mailman id 416476;
 Wed, 05 Oct 2022 21:40:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogC7p-0006xO-Pf; Wed, 05 Oct 2022 21:40:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogC7p-0001TN-LI; Wed, 05 Oct 2022 21:40:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogC7p-00062f-9p; Wed, 05 Oct 2022 21:40:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogC7p-0004s8-7X; Wed, 05 Oct 2022 21:40:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LmBuHuch1lrbSQw718gVsXQ66jdIp3NHPD9cFmYUGkA=; b=42njrCrqsUdMjpporNtK7mIb3M
	4dqRXX2XNjG7jHx6kFBpEP+awoS3TeUx38OxWjck996Qhdv0HpVmpSaJI3TKVqxCkn0hi8QS1kxIs
	qXzN1t7FXiiD91xUThrdowEewCFY4s6jxDAv9+HTdP/F6S74e3KfUQT4v5bbKo+FrCHc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173430-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173430: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=66a5633aa038f4abb4455463755974febac69034
X-Osstest-Versions-That:
    xen=3161231abcb461314b205337fbd0530c7ead1696
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 05 Oct 2022 21:40:21 +0000

flight 173430 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173430/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173422
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173422
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173422
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173422
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173422
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173422
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173422
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173422
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173422
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173422
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173422
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173422
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  66a5633aa038f4abb4455463755974febac69034
baseline version:
 xen                  3161231abcb461314b205337fbd0530c7ead1696

Last test of basis   173422  2022-10-05 01:52:12 Z    0 days
Testing same since   173430  2022-10-05 13:40:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   3161231abc..66a5633aa0  66a5633aa038f4abb4455463755974febac69034 -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 00:08:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 00:08:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416534.661147 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogEQk-0005VZ-Iw; Thu, 06 Oct 2022 00:08:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416534.661147; Thu, 06 Oct 2022 00:08:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogEQk-0005VS-F4; Thu, 06 Oct 2022 00:08:02 +0000
Received: by outflank-mailman (input) for mailman id 416534;
 Thu, 06 Oct 2022 00:08:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UgdD=2H=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogEQi-0005V6-Ml
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 00:08:00 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eed79cec-450a-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 02:07:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 57531617F1;
 Thu,  6 Oct 2022 00:07:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB950C433D6;
 Thu,  6 Oct 2022 00:07:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eed79cec-450a-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665014876;
	bh=EgI5M5TZ7BXqRvIKSX8CVCy28PNbu8v3l83emSft2nY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=O4ZbMxFbU6j4RmRFHUi23ZOJvwnBTO1TjieTJErvhUv7V94SIH4cmt/mCkLuw2vMI
	 sL0l6ODgVeWmczm584ssbe6JPJ1Yu9yl6++jLUbVcXHP3S5eplE2u9SpHzmDlbvt9A
	 eY3/0pTHSuSgBv/u3Us4DzIwLKm80l4m/0RydAXZI/UjJKsG81/jqTlzDbz6M4ikXp
	 c4WGSEuLRRCZHaTCe7DCwZ1fd9WVc+MqndCcz4FDM0th3OyLf42l7Whwwjvsv/FR3W
	 oM3SywnqeRJ+/WQYTt40Ki3DFWOT6E1tuCBXfib1jpi2cC38J4AiiGz3NbF44kQgKX
	 o0EF/aJv/Cz0g==
Date: Wed, 5 Oct 2022 17:07:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
In-Reply-To: <20221005174823.1800761-2-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210051707380.3690179@ubuntu-linux-20-04-desktop>
References: <20221005174823.1800761-1-olekstysh@gmail.com> <20221005174823.1800761-2-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 5 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Take page offset into the account when calculating the number of pages
> to be granted.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict memory access under Xen")

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  drivers/xen/grant-dma-ops.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 8973fc1e9ccc..1998d0e8ce82 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -153,7 +153,7 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>  					 unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = PFN_UP(offset + size);
>  	grant_ref_t grant;
>  	dma_addr_t dma_handle;
>  
> @@ -185,7 +185,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>  				     unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
> +	unsigned int i, n_pages = PFN_UP(offset + size);
>  	grant_ref_t grant;
>  
>  	if (WARN_ON(dir == DMA_NONE))
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 00:19:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 00:19:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416543.661158 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogEbd-00070U-Jp; Thu, 06 Oct 2022 00:19:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416543.661158; Thu, 06 Oct 2022 00:19:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogEbd-00070N-Gq; Thu, 06 Oct 2022 00:19:17 +0000
Received: by outflank-mailman (input) for mailman id 416543;
 Thu, 06 Oct 2022 00:19:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UgdD=2H=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogEbc-00070H-Fb
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 00:19:16 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 817e3496-450c-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 02:19:14 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 430E5CE13C6;
 Thu,  6 Oct 2022 00:19:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A161DC433D6;
 Thu,  6 Oct 2022 00:19:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 817e3496-450c-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665015550;
	bh=gNH9JFMRj4028X6vghjl+A/oKEsjEpj+6Qt/m1foJc4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sjA7iFR0DU+H8mqfrY4QeN/vh/sdujzUR/RI4Ja/fRy1jhEOxTS3JsxSkk/gm56Wg
	 LjOaaSVKwLbUrF0rwmNhrDuxAjRVWVHBPoFhFOy12E4OafGNJZgY3obwPjSQ7exUnb
	 HCJ035iqG1pPJIV/pJPnv1Wq/+6RM/hDsfB3rNcCk48TUU8nQ9bOXWqjqRsfSyJG+0
	 ICf6RpzSXUQvmS6Zg6b7+4Z07Ps08YYM/+i3vfePRwruzuSCN38SR6jSDTQQcSGE4U
	 Q5I+Ht1gsxadn6LZ9BkMJJJuesKzmT3X0FbNTqExf67hXN+7wvRyA+NyAEqYgtsCoj
	 AR/dGeOsNiksA==
Date: Wed, 5 Oct 2022 17:19:07 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 2/2] xen/virtio: Fix potential deadlock when accessing
 xen_grant_dma_devices
In-Reply-To: <20221005174823.1800761-3-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210051719000.3690179@ubuntu-linux-20-04-desktop>
References: <20221005174823.1800761-1-olekstysh@gmail.com> <20221005174823.1800761-3-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 5 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> As find_xen_grant_dma_data() is called from both interrupt and process
> contexts, the access to xen_grant_dma_devices XArray must be protected
> by xa_lock_irqsave to avoid deadlock scenario.
> As XArray API doesn't provide xa_store_irqsave helper, call lockless
> __xa_store directly and guard it externally.
> 
> Also move the storage of the XArray's entry to a separate helper.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict memory access under Xen")

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  drivers/xen/grant-dma-ops.c | 24 +++++++++++++++++++-----
>  1 file changed, 19 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 1998d0e8ce82..c66f56d24013 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -25,7 +25,7 @@ struct xen_grant_dma_data {
>  	bool broken;
>  };
>  
> -static DEFINE_XARRAY(xen_grant_dma_devices);
> +static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
>  
>  #define XEN_GRANT_DMA_ADDR_OFF	(1ULL << 63)
>  
> @@ -42,14 +42,29 @@ static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>  static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
>  {
>  	struct xen_grant_dma_data *data;
> +	unsigned long flags;
>  
> -	xa_lock(&xen_grant_dma_devices);
> +	xa_lock_irqsave(&xen_grant_dma_devices, flags);
>  	data = xa_load(&xen_grant_dma_devices, (unsigned long)dev);
> -	xa_unlock(&xen_grant_dma_devices);
> +	xa_unlock_irqrestore(&xen_grant_dma_devices, flags);
>  
>  	return data;
>  }
>  
> +static int store_xen_grant_dma_data(struct device *dev,
> +				    struct xen_grant_dma_data *data)
> +{
> +	unsigned long flags;
> +	int ret;
> +
> +	xa_lock_irqsave(&xen_grant_dma_devices, flags);
> +	ret = xa_err(__xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,
> +			GFP_ATOMIC));
> +	xa_unlock_irqrestore(&xen_grant_dma_devices, flags);
> +
> +	return ret;
> +}
> +
>  /*
>   * DMA ops for Xen frontends (e.g. virtio).
>   *
> @@ -338,8 +353,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  	 */
>  	data->backend_domid = iommu_spec.args[0];
>  
> -	if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,
> -			GFP_KERNEL))) {
> +	if (store_xen_grant_dma_data(dev, data)) {
>  		dev_err(dev, "Cannot store Xen grant DMA data\n");
>  		goto err;
>  	}
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 00:50:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 00:50:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416550.661168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogF5j-0002jj-UO; Thu, 06 Oct 2022 00:50:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416550.661168; Thu, 06 Oct 2022 00:50:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogF5j-0002jc-Rd; Thu, 06 Oct 2022 00:50:23 +0000
Received: by outflank-mailman (input) for mailman id 416550;
 Thu, 06 Oct 2022 00:50:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogF5i-0002jS-KH; Thu, 06 Oct 2022 00:50:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogF5i-0005RR-Gm; Thu, 06 Oct 2022 00:50:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogF5h-0001k8-Tz; Thu, 06 Oct 2022 00:50:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogF5h-0002l1-TZ; Thu, 06 Oct 2022 00:50:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=y9qCRkfvHQ1g5I6s3KS4ggYlSMFZc4NMxkqjIo4OQUU=; b=yQpKmlFA5OFVu1dKxNwHWx9MKY
	544rg7Be0DifmNSTwWV+s7uZj6Z0geInmBx31ZO0vKUtJ/y68I3sZSHzGGTSq9/9llaBDOpTIGq3v
	qvuaQXZs/AQ9zu5hftnqpCoxIDTFKfScoDR9OGaHZlUtWZS9I28Y5yYA2SUm7b4Z0hxs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173431-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173431: trouble: broken/fail/pass
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-shadow:<job status>:broken:regression
    qemu-mainline:test-amd64-amd64-xl-shadow:host-install(5):broken:regression
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=fafd35a6dab8e70a7c395aaa8e1273267cf9f3c8
X-Osstest-Versions-That:
    qemuu=efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 00:50:21 +0000

flight 173431 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173431/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-shadow      <job status>                 broken
 test-amd64-amd64-xl-shadow    5 host-install(5)        broken REGR. vs. 173408

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173408
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173408
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173408
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173408
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173408
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173408
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173408
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173408
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                fafd35a6dab8e70a7c395aaa8e1273267cf9f3c8
baseline version:
 qemuu                efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745

Last test of basis   173408  2022-10-03 22:08:40 Z    2 days
Testing same since   173431  2022-10-05 14:38:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bernhard Beschow <shentey@gmail.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Laurent Vivier <laurent@vivier.eu>
  Markus Armbruster <armbru@redhat.com>
  Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Ray Zhang <zhanglei002@gmail.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Tong Zhang <t.zhang2@samsung.com>
  Wang, Lei <lei4.wang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   broken  
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-shadow broken
broken-step test-amd64-amd64-xl-shadow host-install(5)

Not pushing.

(No revision log; it would be 536 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 01:41:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 01:41:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416559.661180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogFsw-0001WH-UW; Thu, 06 Oct 2022 01:41:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416559.661180; Thu, 06 Oct 2022 01:41:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogFsw-0001W9-N1; Thu, 06 Oct 2022 01:41:14 +0000
Received: by outflank-mailman (input) for mailman id 416559;
 Thu, 06 Oct 2022 01:41:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rxxd=2H=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ogFsu-0001W3-DX
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 01:41:12 +0000
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f2583c24-4517-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 03:41:08 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id B1BC35C0078;
 Wed,  5 Oct 2022 21:41:06 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Wed, 05 Oct 2022 21:41:06 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Oct 2022 21:41:05 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2583c24-4517-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1665020466; x=
	1665106866; bh=5JWGlL6qjpOxQyyZ9FB1dSYfeN4n/a+nsPGWR+zeiYc=; b=M
	6og2O85RYor/MEkEK9NUu3wiW+BhmIu4XsJu4ZWKsQ32+PtEx3auXlLV1Vxy7xCx
	SuI29dbENT/pW51oqx/kKeS6rYWGQwO2yuV9nwxF4IQXSPo69Mu4lgacDtNbCOYp
	bHksDrcsO7vbcW+uZ1/Wf70s/W4ScBIsqxe51/dUt0D+yD3h7t+H8qxRp7GF3K5E
	/4VgeIWd24J9IPhs25G7EMJNO8dRhNtn5Aw4zxmYm7gi0oUYz6pACaojGon7jAxF
	+2YE+Es//c6MkE71uARRgLeLOlBu5qv7NvSw5PXWeLh5vVEwKo8aaqVJknV37n4d
	cD2ft0lwigYokY8F72dQA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1665020466; x=1665106866; bh=5JWGlL6qjpOxQyyZ9FB1dSYfeN4n
	/a+nsPGWR+zeiYc=; b=IapvrxS+eu9CRM2Y2xpRmwAEBSC07HId3PKvuDlordFq
	FQn0PYGstKTIn1EWy6IVXIsBiQnr5wyq1G0GIAsX3XAUrn0lIOCLn2IK4K2n5OTC
	ELdOXmbc9wR+smndYtDC4+ix/FHk0EvYSjGccIhTRcKnP6o5EZkejB6+fuoIjyF4
	cviqYKjPJwuw3acPHvb+8nrJUcZxsPkMwg2mKliK9ztNYB7lKg405v7U8rqyLOmM
	ynm6gc+s3YcVooFIZYt+T9Rjf1Lrk3t8Txnc3y3JjHGhgJtSjXPA4r1wWPQqMxQm
	QgQXgsN2cI0VH/YhaXOP0pSdMkYwfIVVADA2+5TjWA==
X-ME-Sender: <xms:MjI-Y0MK-kjrVZXrycLY6OoQgV_MAbR9y9PIHIxuls04COsCSIiFmA>
    <xme:MjI-Y6-saI900FsdoMpNk91DHjxo-wuJSng511L3OZ9yMKioyJL633KFRTdz8nYqY
    kAuJNXUWhsQpHE>
X-ME-Received: <xmr:MjI-Y7QYawW0W1P_KkiHSTjB7-0xTVDxzwjuqk3SVwhvCxJ3epBqnVYRHCS4>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeigedghedtucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg
    jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:MjI-Y8uonqngOyQ1TDOcwx7-ZJi0gr1uWyVsWeVAwYOcNsdoEWXjlQ>
    <xmx:MjI-Y8cEnKUQHfG8rFoPIKgLBC-vABsCntJtptGD09gTSlEmvwrKoA>
    <xmx:MjI-Yw1vEyoZd-y5Ech6-96fX-3e4uyELk8VRXQSRiE1sCau-rYNJA>
    <xmx:MjI-Y9VWOZ-b012cWbwraT3IrzSYRvS_471wcRHzbXVqAH4KpMJ2xg>
Feedback-ID: iac594737:Fastmail
Date: Wed, 5 Oct 2022 21:40:58 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Message-ID: <Yz4yLyvX6un1rrqC@itl-email>
References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email>
 <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email>
 <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email>
 <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="O1bm1sqCXF+z9Gl5"
Content-Disposition: inline
In-Reply-To: <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>


--O1bm1sqCXF+z9Gl5
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 5 Oct 2022 21:40:58 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered

On Wed, Oct 05, 2022 at 11:28:29PM +0200, Ard Biesheuvel wrote:
> On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > > Linux has a function called efi_mem_reserve() that is used to reser=
ve
> > > > EfiBootServicesData memory that contains e.g. EFI configuration tab=
les.
> > > > This function does not work under Xen because Xen could have already
> > > > clobbered the memory.  efi_mem_reserve() not working is the whole r=
eason
> > > > for this thread, as it prevents EFI tables that are in
> > > > EfiBootServicesData from being used under Xen.
> > > >
> > > > A much nicer approach would be for Xen to reserve boot services mem=
ory
> > > > unconditionally, but provide a hypercall that dom0 could used to fr=
ee
> > > > the parts of EfiBootServicesData memory that are no longer needed. =
 This
> > > > would allow efi_mem_reserve() to work normally.
> > >
> > > efi_mem_reserve() actually working would be a layering violation;
> > > controlling the EFI memory map is entirely Xen's job.
> >
> > Doing this properly would require Xen to understand all of the EFI
> > tables that could validly be in EfiBootServices* and which could be of
> > interest to dom0.  It might (at least on some very buggy firmware)
> > require a partial ACPI and/or SMBIOS implementation too, if the firmware
> > decided to put an ACPI or SMBIOS table in EfiBootServices*.
> >
> > > As to the hypercall you suggest - I wouldn't mind its addition, but o=
nly
> > > for the case when -mapbs is used. As I've indicated before, I'm of the
> > > opinion that default behavior should be matching the intentions of the
> > > spec, and the intention of EfiBootServices* is for the space to be
> > > reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
> > > that hypercall: It might use it for regions where data lives which it
> > > wouldn't care about itself, but which an eventual kexec-ed (or alike)
> > > entity would later want to consume. Code/data potentially usable by
> > > _anyone_ between two resets of the system cannot legitimately be freed
> > > (and hence imo is wrong to live in EfiBootServices* regions).
> >
> > I agree, but currently some such data *is* in EfiBootServices* regions,
> > sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
> > configuration tables that point to EfiBootServicesData memory before
> > freeing that memory.
> >
>=20
> That seems like a reasonable approach to me. Tables like MEMATTR or
> RT_PROP are mostly relevant for bare metal where the host kernel maps
> the runtime services, and in general, passing on these tables without
> knowing what they do is kind of fishy anyway. You might even argue
> that only known table types should be forwarded in the first place,
> regardless of the memory type.

Which tables are worth handling in Xen?  I know about ACPI, SMBIOS, and
ESRT, but I am curious which others Xen should preserve.  Currently, Xen
does not know about RT_PROP or MEMATTR; could this be a cause of
problems?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--O1bm1sqCXF+z9Gl5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM+Mi8ACgkQsoi1X/+c
IsFC3Q/+LInS5fyLV5q0WDsphEUWJpSm3d2wDWvD98SyzEt/5YAunxvLkGFXYcLS
P8Q2FOVyDqmBG457YSSZSS8Qt0EPxbntfAIgJT6c81xrAYpAFFHfblt1uHnrnzBJ
5iGIkr1j184qHSf/iK8xlaxFe2eZDjZM3Y0RFGeII6+RdqmF8Wm1yd2+JlVEqGgO
GSHwnQtt+Ut5ahm7+XKh6CdyMOeP7A7Z8+AVk74mFvWrCrJQgDPvXCAxQYX2EXCw
TrMvLfhv4RBOOaMmCcLevbEs+3MbQ7owXtiMS0uydsezCedtWoyS9tcQdFzuJHfX
h68Aj+kiVe07m/9Gpx43Ed+C+k4aNXqja9skqUhqStUigzOzX0Q/tNsSZV7nlyhL
xYmlU+pdkPSNK8cXngU/OK1GjZLoNs5oc+pGT6oIq5ipWaZpO4eLriu1lMBWSS6s
iExS7Awf7owOnc6AjaaiIRIN0W7NJ7auK10lCXX9IjzlOp9WCfA9xNLXuMQHNxCr
gj0r+7UbcQAQP7bDRYIS/lddXF3jiubTiYeuQIdG2Y/+mIg1x1EZcNApa3rVsrSN
xM9ex0yrDJxj9EODFHvIF9K8meqbQKTbBKtLE86Kmz6LzU4B0qwq1eQHc1M/Mo/L
glmKRPDzx+ys9qrdIVnBCoMRNFpqK8+ybCzZ4TFHDLhht4N6iBE=
=+br+
-----END PGP SIGNATURE-----

--O1bm1sqCXF+z9Gl5--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 05:06:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 05:06:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416569.661191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJ5B-00058h-F8; Thu, 06 Oct 2022 05:06:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416569.661191; Thu, 06 Oct 2022 05:06:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJ5B-00058a-C4; Thu, 06 Oct 2022 05:06:05 +0000
Received: by outflank-mailman (input) for mailman id 416569;
 Thu, 06 Oct 2022 05:06:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogJ5A-00058E-2h
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 05:06:04 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9278806c-4534-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 07:06:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4884A21A11;
 Thu,  6 Oct 2022 05:06:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A4771376E;
 Thu,  6 Oct 2022 05:06:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LEtgBDliPmNuYgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 05:06:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9278806c-4534-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665032761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9OQTIjVFUC01bkI7WDIN0F1RArit60c4eKNRzzbaU1s=;
	b=kmretDP4zgjTmp9fNKYLXaBgLcYZB1zYClG9ql4w2TIaCdbZtz5IvmEhu/ymTvc85BvVUv
	LkCXqJvdda3HcX+UgmFnei0+xUQS2wXLsWwIkYpwQrxuc3M5lLjXDqo6+thLaJ6bZrF4Hy
	JqTClBc2m4TdUlJn3sUNwCqpSvORhfo=
Message-ID: <8abd9c77-286f-903c-d398-3d441bf830a6@suse.com>
Date: Thu, 6 Oct 2022 07:06:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221005174823.1800761-2-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------S0yywZOxdoyVl9IXTchDhhtW"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------S0yywZOxdoyVl9IXTchDhhtW
Content-Type: multipart/mixed; boundary="------------H5xTe0spdc0H7pc06G0WZsV3";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <8abd9c77-286f-903c-d398-3d441bf830a6@suse.com>
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
In-Reply-To: <20221005174823.1800761-2-olekstysh@gmail.com>

--------------H5xTe0spdc0H7pc06G0WZsV3
Content-Type: multipart/mixed; boundary="------------EIxqeP0Iw83Y0cKe9U0jeESa"

--------------EIxqeP0Iw83Y0cKe9U0jeESa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTk6NDgsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBUYWtlIHBhZ2Ugb2Zmc2V0IGludG8gdGhlIGFjY291bnQgd2hlbiBjYWxjdWxh
dGluZyB0aGUgbnVtYmVyIG9mIHBhZ2VzDQo+IHRvIGJlIGdyYW50ZWQuDQo+IA0KPiBTaWdu
ZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29A
ZXBhbS5jb20+DQo+IEZpeGVzOiBkNmFjYTM1MDRjN2QgKCJ4ZW4vZ3JhbnQtZG1hLW9wczog
QWRkIG9wdGlvbiB0byByZXN0cmljdCBtZW1vcnkgYWNjZXNzIHVuZGVyIFhlbiIpDQoNClJl
dmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdl
bg0KDQo=
--------------EIxqeP0Iw83Y0cKe9U0jeESa
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------EIxqeP0Iw83Y0cKe9U0jeESa--

--------------H5xTe0spdc0H7pc06G0WZsV3--

--------------S0yywZOxdoyVl9IXTchDhhtW
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+YjgFAwAAAAAACgkQsN6d1ii/Ey+W
TAgAlo+G+ByB4ukMNLrhiBvZj0DCG4cUOtEvSd1qQxDAiv7AxRqB48XE5d/ockZl0hF4tS0XUt9w
hTBSNbKA2heyXCqhrBX8H/+GP3y8M2En09eYp2NVWr2fQnJl6/oYzgRvSg4ehAwv6ikNY9dBqEa6
eIVQcSOoS+OgOBZQmD+c+yDiAv674DbM26PH68IlzghLpkM7w6MMNrWiolCznqPjwKapboLCASaR
SFQs7y4qPOnOK0klBZQkWsxFU9DvtASifsOkjdMDH2h57a/mxU+2xmsiGKFvMzBnBTQvKt1HNVZt
SUzgpSGcNB0AWn/cstkiWAleckRmt16QuxZ92Hsb0g==
=IHI8
-----END PGP SIGNATURE-----

--------------S0yywZOxdoyVl9IXTchDhhtW--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 05:08:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 05:08:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416576.661202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJ70-0005gr-RS; Thu, 06 Oct 2022 05:07:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416576.661202; Thu, 06 Oct 2022 05:07:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJ70-0005gk-N9; Thu, 06 Oct 2022 05:07:58 +0000
Received: by outflank-mailman (input) for mailman id 416576;
 Thu, 06 Oct 2022 05:07:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogJ6z-0005gW-FV; Thu, 06 Oct 2022 05:07:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogJ6z-0004lx-7K; Thu, 06 Oct 2022 05:07:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogJ6y-0005PY-Nh; Thu, 06 Oct 2022 05:07:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogJ6y-0001kj-FI; Thu, 06 Oct 2022 05:07:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1q7fWVKU22QB0Kv24lsqneMzMVbSP6IYiTS81adHRWE=; b=z4aZd5U+Lnc7lwj1JtruPePitb
	XeXloFC9Hy0MxRKlOQaQL7EBJqjp7h2ualZzLUVsz+5X5KvzfeR6ojpsujA/l1AIv4INfH2q2sgQJ
	7SgnCezn1rn9Fx4fAvd9jKwPxBwRO+pfYwdstAvXo9YV2CukDmSJvQahy/0qRq41BdKI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173433-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173433: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-examine:host-install:broken:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:xen-boot:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f28b7414ab715e6069e72a7bbe2f1354b2524beb
X-Osstest-Versions-That:
    linux=6215647d9699cb8f1bf7333ec849242c4a9cf9a6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 05:07:56 +0000

flight 173433 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173433/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-qemut-rhel6hvm-amd  7 xen-install        fail REGR. vs. 173353
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 173353
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 173353

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-examine      5 host-install   broken in 173427 pass in 173433
 test-amd64-amd64-xl-rtds      8 xen-boot         fail in 173427 pass in 173433
 test-armhf-armhf-xl-credit1  14 guest-start      fail in 173427 pass in 173433
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 173427 pass in 173433
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 173427
 test-armhf-armhf-xl-rtds     14 guest-start                fail pass in 173427

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173353
 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 173427 like 173353
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 173427 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173427 never pass
 test-armhf-armhf-xl-credit1  18 guest-start/debian.repeat    fail  like 173353
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173353
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173353
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173353
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f28b7414ab715e6069e72a7bbe2f1354b2524beb
baseline version:
 linux                6215647d9699cb8f1bf7333ec849242c4a9cf9a6

Last test of basis   173353  2022-09-28 09:15:02 Z    7 days
Testing same since   173427  2022-10-05 08:44:11 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Alistair Popple <apopple@nvidia.com>
  Andrew Morton <akpm@linux-foundation.org>
  Arnd Bergmann <arnd@arndb.de>
  Bjørn Mork <bjorn@mork.no>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <caihuoqing@baidu.com>
  Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christoph Hellwig <hch@lst.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Hildenbrand <david@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Fabio Estevam <festevam@denx.de>
  Faiz Abbas <faiz_abbas@ti.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Han Xu <han.xu@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heiko Stuebner <heiko@sntech.de>
  Hongling Zeng <zenghongling@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Michael Kelley <mikelley@microsoft.com>
  Michal Hocko <mhocko@suse.com>
  Minchan Kim <minchan@kernel.org>
  Niklas Cassel <niklas.cassel@wdc.com>
  Paolo Abeni <pabeni@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Xu <peterx@redhat.com>
  Rafał Miłecki <rafal@milecki.pl>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sergei Antonov <saproj@gmail.com>
  Stephen Boyd <sboyd@kernel.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Tony Lindgren <tony@atomide.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Wang Yufen <wangyufen@huawei.com>
  Yang Shi <shy828301@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  YuTong Chang <mtwget@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 919 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 05:08:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 05:08:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416584.661213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJ7a-0006EG-7d; Thu, 06 Oct 2022 05:08:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416584.661213; Thu, 06 Oct 2022 05:08:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJ7a-0006E9-4E; Thu, 06 Oct 2022 05:08:34 +0000
Received: by outflank-mailman (input) for mailman id 416584;
 Thu, 06 Oct 2022 05:08:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogJ7Y-000693-6g
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 05:08:32 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb9bee38-4534-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 07:08:31 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1D7E121A13;
 Thu,  6 Oct 2022 05:08:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E5C761376E;
 Thu,  6 Oct 2022 05:08:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GX2SNs5iPmMmYwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 05:08:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb9bee38-4534-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665032911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UtHwfo8Ti3LHLWISJ0bchZhWJ1S+x17mLDCbC2H7SSg=;
	b=quOtWuzDil+KA1fGnPub9ADouWjX80WqEyoGTBT6GV0HiB7om58I8O44B8XAZbPlepc640
	Cj6w9oDrMzu+MekSysh7Oh3g2TBXxFwlFywT3bXYxWuZjjgJO2xjfar7OvPJufd/krEwuj
	wrLqh55trdLUOTVMrYmVnRbjYs85JJw=
Message-ID: <d1f39ce3-fe09-d3b0-fa6d-01345d1d0429@suse.com>
Date: Thu, 6 Oct 2022 07:08:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 2/2] xen/virtio: Fix potential deadlock when accessing
 xen_grant_dma_devices
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-3-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221005174823.1800761-3-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------mbQdv0kQz0uSmT0oRkoQkJHb"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------mbQdv0kQz0uSmT0oRkoQkJHb
Content-Type: multipart/mixed; boundary="------------YjsZi846T4W4XxJfFfiDnH4b";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <d1f39ce3-fe09-d3b0-fa6d-01345d1d0429@suse.com>
Subject: Re: [PATCH 2/2] xen/virtio: Fix potential deadlock when accessing
 xen_grant_dma_devices
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-3-olekstysh@gmail.com>
In-Reply-To: <20221005174823.1800761-3-olekstysh@gmail.com>

--------------YjsZi846T4W4XxJfFfiDnH4b
Content-Type: multipart/mixed; boundary="------------VZerug55gyCMYD0oUDokualh"

--------------VZerug55gyCMYD0oUDokualh
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTk6NDgsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBBcyBmaW5kX3hlbl9ncmFudF9kbWFfZGF0YSgpIGlzIGNhbGxlZCBmcm9tIGJv
dGggaW50ZXJydXB0IGFuZCBwcm9jZXNzDQo+IGNvbnRleHRzLCB0aGUgYWNjZXNzIHRvIHhl
bl9ncmFudF9kbWFfZGV2aWNlcyBYQXJyYXkgbXVzdCBiZSBwcm90ZWN0ZWQNCj4gYnkgeGFf
bG9ja19pcnFzYXZlIHRvIGF2b2lkIGRlYWRsb2NrIHNjZW5hcmlvLg0KPiBBcyBYQXJyYXkg
QVBJIGRvZXNuJ3QgcHJvdmlkZSB4YV9zdG9yZV9pcnFzYXZlIGhlbHBlciwgY2FsbCBsb2Nr
bGVzcw0KPiBfX3hhX3N0b3JlIGRpcmVjdGx5IGFuZCBndWFyZCBpdCBleHRlcm5hbGx5Lg0K
PiANCj4gQWxzbyBtb3ZlIHRoZSBzdG9yYWdlIG9mIHRoZSBYQXJyYXkncyBlbnRyeSB0byBh
IHNlcGFyYXRlIGhlbHBlci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNo
Y2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4gRml4ZXM6IGQ2YWNh
MzUwNGM3ZCAoInhlbi9ncmFudC1kbWEtb3BzOiBBZGQgb3B0aW9uIHRvIHJlc3RyaWN0IG1l
bW9yeSBhY2Nlc3MgdW5kZXIgWGVuIikNCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3Mg
PGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo=
--------------VZerug55gyCMYD0oUDokualh
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------VZerug55gyCMYD0oUDokualh--

--------------YjsZi846T4W4XxJfFfiDnH4b--

--------------mbQdv0kQz0uSmT0oRkoQkJHb
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+Ys4FAwAAAAAACgkQsN6d1ii/Ey+u
7wgAhkg/ICzjGggW2a98n0rkGRZk2T0sFrVEJJJWWDGIYi3Z0NVVdd4VTwbVjqiYcDkyCYBE8G8y
EKueKfVQBC78Ma86iwewgBCzLbFUPswr+GQijrIIyAH1jarHefYB+W0SFfwVfgjdN8vP4tnAHjiq
LyWzpCvxG8GU2i7OuTQGj/NkrFb6J7soK4M8dAHTcAXfvhKD6woPMQgDsMOO1yqq5g/PbKlg7AqA
WKdz1jKyB6NKWa0Vi+n+SqF9H0CDY6JuP5gLYyOGv64hTcpX/y+ncGuEq7KTVzFiV+qcwRxLwgK7
EnnYaGK7mWdYnp5Fx8QssZJ2jyI+hKEFOpvlNR2Oqg==
=l33E
-----END PGP SIGNATURE-----

--------------mbQdv0kQz0uSmT0oRkoQkJHb--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 05:12:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 05:12:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416595.661224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJB5-0007lB-Ma; Thu, 06 Oct 2022 05:12:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416595.661224; Thu, 06 Oct 2022 05:12:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogJB5-0007l4-Jc; Thu, 06 Oct 2022 05:12:11 +0000
Received: by outflank-mailman (input) for mailman id 416595;
 Thu, 06 Oct 2022 05:12:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogJB4-0007ky-O1
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 05:12:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6dbeb3fd-4535-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 07:12:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 352211F85D;
 Thu,  6 Oct 2022 05:12:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F2192139D2;
 Thu,  6 Oct 2022 05:12:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Nv6iOahjPmM5ZAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 05:12:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6dbeb3fd-4535-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665033129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5iU3UBkPp5UeHx8TTGn1E43Xg/sRr9X8ndnUiDuaOio=;
	b=DU90G3KI9ALj1tLlzpzC9+wr8wwamnEjKp1YZE1Z8epwMXoabl+sE80Zhtt2NPY50Z2Ex0
	Sn/Dko7vGMrs7wDGv0MKDXCSaYAT/KNuUJaO6TJJ+zc9W+BW6wPFWJsJGNATx8tm4Ncnet
	334BR36GQ3IlNO2wDb1bWo40B3F6kIM=
Message-ID: <ee16518a-69a6-d3bc-2581-61b37b803af8@suse.com>
Date: Thu, 6 Oct 2022 07:12:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Bjorn Helgaas <bhelgaas@google.com>
Cc: xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20220829151536.8578-1-jandryuk@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20220829151536.8578-1-jandryuk@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------Yy9TwF3GPZx5SgNEqSTsuaZh"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------Yy9TwF3GPZx5SgNEqSTsuaZh
Content-Type: multipart/mixed; boundary="------------7hUe9JATxFCEuZthwY476fEZ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Bjorn Helgaas <bhelgaas@google.com>
Cc: xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org,
 linux-kernel@vger.kernel.org
Message-ID: <ee16518a-69a6-d3bc-2581-61b37b803af8@suse.com>
Subject: Re: [PATCH] xen-pcifront: Handle missed Connected state
References: <20220829151536.8578-1-jandryuk@gmail.com>
In-Reply-To: <20220829151536.8578-1-jandryuk@gmail.com>

--------------7hUe9JATxFCEuZthwY476fEZ
Content-Type: multipart/mixed; boundary="------------NlW0XA0x2EWjlbOjJvE07M3D"

--------------NlW0XA0x2EWjlbOjJvE07M3D
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjkuMDguMjIgMTc6MTUsIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+IEFuIEhWTSBndWVz
dCB3aXRoIGxpbnV4IHN0dWJkb20gYW5kIDIgUENJIGRldmljZXMgZmFpbGVkIHRvIHN0YXJ0
IGFzDQo+IGxpYnhsIHRpbWVkIG91dCB3YWl0aW5nIGZvciB0aGUgUENJIGRldmljZXMgdG8g
YmUgYWRkZWQuICBJdCBoYXBwZW5zDQo+IGludGVybWl0dGVudGx5IGJ1dCB3aXRoIHNvbWUg
cmVndWxhcml0eS4gIGxpYnhsIHdyb3RlIHRoZSB0d28geGVuc3RvcmUNCj4gZW50cmllcyBm
b3IgdGhlIGRldmljZXMsIGJ1dCB0aGVuIHRpbWVkIG91dCB3YWl0aW5nIGZvciBiYWNrZW5k
IHN0YXRlIDQNCj4gKENvbm5lY3RlZCkgLSB0aGUgc3RhdGUgc3RheWVkIGF0IDcgKFJlY29u
ZmlndXJpbmcpLiAgKFBDSSBwYXNzdGhyb3VnaA0KPiB0byBhbiBIVk0gd2l0aCBzdHViZG9t
YWluIGlzIFBWIHBhc3N0aHJvdWdoIHRvIHRoZSBzdHViZG9tYWluIGFuZCB0aGVuDQo+IEhW
TSBwYXNzdGhyb3VnaCB3aXRoIHRoZSBRRU1VIGluc2lkZSB0aGUgc3R1YmRvbWFpbi4pDQo+
IA0KPiBUaGUgc3R1YmRvbSBrZXJuZWwgbmV2ZXIgcHJpbnRlZCAicGNpZnJvbnQgcGNpLTA6
IEluc3RhbGxpbmcgUENJDQo+IGZyb250ZW5kIiwgc28gaXQgc2VlbXMgdG8gaGF2ZSBtaXNz
ZWQgc3RhdGUgNCB3aGljaCB3b3VsZCBoYXZlDQo+IGNhbGxlZCBwY2lmcm9udF90cnlfY29u
bmVjdCAtPiBwY2lmcm9udF9jb25uZWN0X2FuZF9pbml0X2RtYQ0KPiANCj4gSGF2ZSBwY2lm
cm9udF9kZXRhY2hfZGV2aWNlcyBzcGVjaWFsLWNhc2Ugc3RhdGUgSW5pdGlhbGlzZWQgYW5k
IGNhbGwNCj4gcGNpZnJvbnRfY29ubmVjdF9hbmRfaW5pdF9kbWEuICBEb24ndCB1c2UgcGNp
ZnJvbnRfdHJ5X2Nvbm5lY3QgYmVjYXVzZQ0KPiB0aGF0IHNldHMgdGhlIHhlbmJ1cyBzdGF0
ZSB3aGljaCBtYXkgdGhyb3cgb2ZmIHRoZSBiYWNrZW5kLiAgQWZ0ZXINCj4gY29ubmVjdGlu
Zywgc2tpcCB0aGUgcmVtYWluZGVyIG9mIGRldGFjaF9kZXZpY2VzIHNpbmNlIG5vbmUgaGF2
ZSBiZWVuDQo+IGluaXRpYWxpemVkIHlldC4gIFdoZW4gdGhlIGJhY2tlbmQgc3dpdGNoZXMg
dG8gUmVjb25maWd1cmVkLA0KPiBwY2lmcm9udF9hdHRhY2hfZGV2aWNlcyB3aWxsIHBpY2sg
dGhlbSB1cCBhZ2Fpbi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEFuZHJ5dWsgPGph
bmRyeXVrQGdtYWlsLmNvbT4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy02
LjENCg0KDQpKdWVyZ2VuDQoNCg==
--------------NlW0XA0x2EWjlbOjJvE07M3D
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------NlW0XA0x2EWjlbOjJvE07M3D--

--------------7hUe9JATxFCEuZthwY476fEZ--

--------------Yy9TwF3GPZx5SgNEqSTsuaZh
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+Y6gFAwAAAAAACgkQsN6d1ii/Ey82
Pgf/bd9LG5JBdmzy+b6OKaM00dpAMyzK/xdjune8yx9q13iXOLQ6sXcQCHCbD1i4whfcm5Nrqe0B
hHv+iorDX1mwnfsp1gx9qRhY0C1Yix89+9dmt4rc1ENfRlRfK3IVVzpJc8vdtk1IsGi6iiqA4/OZ
dEGkC6SAYeefaD2rHU0O1vsbvpsFag8oqBT6E9Dot4HRBmpvBTAF1X7GQXMtdGxjxI5k49zG6qRr
bqLJ2iDzkhW8yeCOQtCJIKtciJSs2sEvK11bG47FZQI/Li5GbVL+s8XKPFPZgCP/f9R58gtViR6m
G75GcJp5dDDDdwZYkVMZyzE/PruFaw0QlntcE2EywQ==
=/VrV
-----END PGP SIGNATURE-----

--------------Yy9TwF3GPZx5SgNEqSTsuaZh--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 06:19:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 06:19:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416605.661238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogKDi-0005df-Lv; Thu, 06 Oct 2022 06:18:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416605.661238; Thu, 06 Oct 2022 06:18:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogKDi-0005dY-JD; Thu, 06 Oct 2022 06:18:58 +0000
Received: by outflank-mailman (input) for mailman id 416605;
 Thu, 06 Oct 2022 06:18:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogKDh-0005dO-G5; Thu, 06 Oct 2022 06:18:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogKDh-00064V-DW; Thu, 06 Oct 2022 06:18:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogKDh-0002j9-1Z; Thu, 06 Oct 2022 06:18:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogKDh-0005nk-0u; Thu, 06 Oct 2022 06:18:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jzi9fiVZfcvSl2l2alIYYAjJFZ5wOIY0yrPpy0+6jvU=; b=nzp/e09Zg4E02vNxnkaPEPIDWV
	lbf+gvSOnNVtVZsvzLDpRqFJ8M+heCVDkUHhRxhN6CZd1KGltSFtbLIZUuh0CDzTRbDhYXYgbXvLO
	YJYrT+NEkDssoyoFJkpeoAM/O0lPfxOZ6f7ZdV3221LwW4G3bIcSakPPyMqH/UsrgHZ4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173437-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173437: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=710f83b79d6eab641401c054b2f40f6c630f8cd5
X-Osstest-Versions-That:
    ovmf=1bd2ff18664b9564a5802d0ac153b5023f2fa41e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 06:18:57 +0000

flight 173437 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173437/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 710f83b79d6eab641401c054b2f40f6c630f8cd5
baseline version:
 ovmf                 1bd2ff18664b9564a5802d0ac153b5023f2fa41e

Last test of basis   173424  2022-10-05 04:40:32 Z    1 days
Testing same since   173437  2022-10-06 02:10:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michael Kubacki <michael.kubacki@microsoft.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   1bd2ff1866..710f83b79d  710f83b79d6eab641401c054b2f40f6c630f8cd5 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 06:37:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 06:37:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416615.661249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogKVl-000826-7v; Thu, 06 Oct 2022 06:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416615.661249; Thu, 06 Oct 2022 06:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogKVl-00081z-56; Thu, 06 Oct 2022 06:37:37 +0000
Received: by outflank-mailman (input) for mailman id 416615;
 Thu, 06 Oct 2022 06:37:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogKVk-00081t-6s
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 06:37:36 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c731f31-4541-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 08:37:34 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3D10D219E5;
 Thu,  6 Oct 2022 06:37:34 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FD521376E;
 Thu,  6 Oct 2022 06:37:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zWdhBq53PmMuAwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 06:37:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c731f31-4541-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665038254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=l0N0EjVsoEiBxet6Ymx5PiI6kbwHet0IlX3Q1zJFWCc=;
	b=VoRPVClIdrXpXBr88Uc4EIetWgvvC9kuuh+u9Yp2k+CVSJOzl9s7MhSQKvW4A97ATwagN3
	gPSKZ3iVD7igwaPZb9pkeMxJQA4FZYCCto050SloLKurfKbkFn4k2/7RbCnDLL4sY+IqHc
	aLlC64VDc+OCu7OXjYYYiW3B2F7rCJc=
Message-ID: <15abd7fd-8fc6-5246-5c37-7e6423b025c5@suse.com>
Date: Thu, 6 Oct 2022 08:37:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com> <Yz2L9eTdbA3vS43g@mail-itl>
 <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com> <Yz2kKU5qEvD25iJX@mail-itl>
 <a8366482-ba75-19e7-4e82-ba968ec9ddcb@suse.com> <Yz21RxJ9xXP8ODb0@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
In-Reply-To: <Yz21RxJ9xXP8ODb0@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------d55YQkVR09uIb8CsSygj709H"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------d55YQkVR09uIb8CsSygj709H
Content-Type: multipart/mixed; boundary="------------BkOKCgskQkPAePMqf4ZCGFtU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <15abd7fd-8fc6-5246-5c37-7e6423b025c5@suse.com>
Subject: Re: CONFIG_XEN_VIRTIO{_FORCE_GRANT} interferes with nested virt
References: <Yz17cLIb1V0zjEjK@mail-itl>
 <4bd95b8b-dbdb-b5ce-fe18-ce6bbcf715fe@suse.com> <Yz2Fvp9Q9aeYKnDY@mail-itl>
 <ecdc11dc-6090-e050-bcba-aafbd8aaf3b6@suse.com> <Yz2L9eTdbA3vS43g@mail-itl>
 <e306ac5f-2ce8-944d-ed5d-5aae566c8a80@suse.com> <Yz2kKU5qEvD25iJX@mail-itl>
 <a8366482-ba75-19e7-4e82-ba968ec9ddcb@suse.com> <Yz21RxJ9xXP8ODb0@mail-itl>
In-Reply-To: <Yz21RxJ9xXP8ODb0@mail-itl>

--------------BkOKCgskQkPAePMqf4ZCGFtU
Content-Type: multipart/mixed; boundary="------------3Gr6CaA0yyRf4wh8dOqwqRoq"

--------------3Gr6CaA0yyRf4wh8dOqwqRoq
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTg6NDgsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDU6NDU6NTZQTSArMDIwMCwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IE9uIDA1LjEwLjIyIDE3OjM1LCBNYXJlayBNYXJjenlrb3dza2kt
R8OzcmVja2kgd3JvdGU6DQo+Pj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDU6MDQ6MjlQ
TSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gT24gMDUuMTAuMjIgMTU6NTEs
IE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToNCj4+Pj4+IE9uIFdlZCwgT2N0
IDA1LCAyMDIyIGF0IDAzOjM0OjU2UE0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+
Pj4+Pj4gT24gMDUuMTAuMjIgMTU6MjUsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3
cm90ZToNCj4+Pj4+Pj4gT24gV2VkLCBPY3QgMDUsIDIwMjIgYXQgMDI6NTc6MDFQTSArMDIw
MCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4+Pj4+IE9uIDA1LjEwLjIyIDE0OjQxLCBN
YXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+Pj4+Pj4+Pj4gSGksDQo+Pj4+
Pj4+Pj4NCj4+Pj4+Pj4+PiBXaGVuIGJvb3RpbmcgWGVuIHdpdGggTGludXggZG9tMCBuZXN0
ZWQgdW5kZXIgS1ZNLA0KPj4+Pj4+Pj4+IENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5U
PXkgbWFrZXMgaXQgdW5hYmxlIHRvIHVzZSB2aXJ0aW8gZGV2aWNlcw0KPj4+Pj4+Pj4+IHBy
b3ZpZGVkIGJ5IEwwIGh5cGVydmlzb3IgKEtWTSB3aXRoIHFlbXUpLiBXaXRoIFBWIGRvbTAs
IGdyYW50cyBhcmUNCj4+Pj4+Pj4+PiByZXF1aXJlZCBmb3IgdmlydGlvIGV2ZW4gaWYganVz
dCBDT05GSUdfWEVOX1ZJUlRJTyBpcyBlbmFibGVkLg0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4g
VGhpcyBpcyBwcm9iYWJseSB1bmNvbW1vbiBjb3JuZXIgY2FzZSwgYnV0IG9uZSB0aGF0IGhh
cyBiaXR0ZW4gbWUgaW4gbXkNCj4+Pj4+Pj4+PiBDSSBzZXR1cC4uLiBJIHRoaW5rIFhlbiBz
aG91bGQgc2V0IHNtYXJ0ZXINCj4+Pj4+Pj4+PiB2aXJ0aW9fcmVxdWlyZV9yZXN0cmljdGVk
X21lbV9hY2MoKSwgdGhhdCBlbmZvcmNlcyBpdCBvbmx5IGZvciBkZXZpY2VzDQo+Pj4+Pj4+
Pj4gcmVhbGx5IHByb3ZpZGVkIGJ5IGFub3RoZXIgWGVuIFZNIChub3QgYnkgdGhlICJvdXRl
ciBob3N0IiksIGJ1dCBJJ20gbm90DQo+Pj4+Pj4+Pj4gc3VyZSBob3cgdGhhdCBjb3VsZCBi
ZSBkb25lLiBBbnkgaWRlYXM/DQo+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBJdCBz
aG91bGQgYmUgcG9zc2libGUgdG8gYWRkIGEgYm9vdCBwYXJhbWV0ZXIgZm9yIHRoYXQgcHVy
cG9zZS4gVXNpbmcgaXQNCj4+Pj4+Pj4+IHdvdWxkIG9wZW4gYSBzZWN1cml0eSBob2xlLCB0
aG91Z2ggKGJhc2ljYWxseSBsaWtlIGFsbCBQQ0kgcGFzc3Rocm91Z2ggdG8NCj4+Pj4+Pj4+
IFBWIGd1ZXN0cykuDQo+Pj4+Pj4+DQo+Pj4+Pj4+IFdoYXQgYWJvdXQgZXhjbHVkaW5nIGp1
c3QgZG9tMD8gQXQgbGVhc3QgY3VycmVudGx5LCB0aGVyZSBpcyBubyB3YXkgZm9yDQo+Pj4+
Pj4+IGRvbTAgdG8gc2VlIHZpcnRpbyBkZXZpY2VzIHByb3ZpZGVkIGJ5IGFub3RoZXIgWGVu
IGRvbVUuDQo+Pj4+Pj4NCj4+Pj4+PiBFdmVuIG5vdCB2aWEgaG90cGx1Zz8NCj4+Pj4+DQo+
Pj4+PiBUaGF0J3Mgd2h5IEkgc2FpZCAiY3VycmVudGx5IiwgSUlVQyBob3RwbHVnIG9mIHZp
cnRpbyBkZXZpY2VzIHVuZGVyIFhlbg0KPj4+Pj4gZG9lc24ndCB3b3JrIHlldCwgbm8/DQo+
Pj4+PiBXaXRoIGhvdHBsdWcgd29ya2luZywgaXQgd291bGQgbmVlZCB0byBiZSBhIHByb3Bl
ciBkZXRlY3Rpb24gd2hlcmUgdGhlDQo+Pj4+PiBiYWNrZW5kIGxpdmVzLCBhbmQgcHJvYmFi
bHkgd2l0aCBzb21lIGV4dHJhIGNvbnNpZGVyYXRpb25zIHJlIFhlbiBvbg0KPj4+Pj4gWGVu
IChiYXNlZCBvbiBiZWxvdywgcHYtc2hpbSBjb3VsZCB1c2UgZ3JhbnRzKS4NCj4+Pj4NCj4+
Pj4gQXMgc3RhdGVkIGJlZm9yZSwgdGhpcyBpc24ndCBhIHByb2JsZW0gc3BlY2lmaWMgdG8g
dmlydGlvIGRldmljZXMuIFRoZSBzYW1lDQo+Pj4+IGFwcGxpZXMgdG8gWGVuIFBWIGRldmlj
ZXMuDQo+Pj4NCj4+PiBXaHkgaXMgdGhhdCBhbiBpc3N1ZSBmb3IgWGVuIFBWIGRldmljZXM/
IFRoZXkgYWx3YXlzIHVzZSBncmFudHMsIHNvIG5vIG5lZWQNCj4+PiBmb3IgZXhjZXB0aW9u
LiBCdXQgbW9yZSByZWxldmFudCBoZXJlLCB0aGVyZSBpcyBubyBwcm90b2NvbCBmb3IgTDAN
Cj4+PiBoeXBlcnZpc29yICh0aGF0IHdvdWxkIG5lZWQgdG8gYmUgWGVuKSB0byBwcm92aWRl
IFBWIGRldmljZSB0byBuZXN0ZWQgTDENCj4+PiBndWVzdCAoYmVzaWRlcyBwdi1zaGltIGNh
c2UsIHdoaWNoIGlzIGFscmVhZHkgaGFuZGxlZCksIHNvIEwxIGd1ZXN0DQo+Pj4gY2Fubm90
IGNvbmZ1c2UgUFYgZGV2aWNlIHByb3ZpZGVkIGJ5IEwwIGFuZCBMMS4NCj4+DQo+PiBUaGF0
J3MgdGhlIHBvaW50LiBUb2RheSB1c2luZyB2aXJ0aW8gdGhlIHdheSB5b3UgYXJlIHVzaW5n
IGl0IGlzIHBvc3NpYmxlDQo+PiBvbmx5IGJlY2F1c2UgdmlydGlvIGRldmljZXMgZG9uJ3Qg
aGF2ZSB0aGUgc2VjdXJpdHkgZmVhdHVyZXMgb2YgWGVuIFBWDQo+PiBkZXZpY2VzLiBXaXRo
IGFkZGluZyBncmFudCBzdXBwb3J0IGZvciB2aXJ0aW8gZGV2aWNlcyB0aGlzIGhhcyBjaGFu
Z2VkLg0KPj4NCj4+IEJUVywgeW91IGNhbiBoYXZlIHRoZSBvbGQgdmlydGlvIGJlaGF2aW9y
IGJhY2sgYnkgbm90IGVuYWJsaW5nDQo+PiBDT05GSUdfWEVOX1ZJUlRJTy4NCj4gDQo+IFll
cywgSSBrbm93LCBhbmQgY3VycmVudGx5IEknbSBkb2luZyBpdC4gQnV0IGF0IHNvbWUgcG9p
bnQgSSdkIGxpa2UgdG8NCj4gYmUgYWJsZSB0byBlbmFibGUgQ09ORklHX1hFTl9WSVJUSU8g
d2l0aG91dCBicmVha2luZyB0aGUgbmVzdGVkIHZpcnQNCj4gY2FzZS4gSWRlYWxseSBLVk0g
dmlydGlvIGRldmljZXMgd291bGQgdXNlIHNvbWV0aGluZyBsaWtlIGdyYW50cywgYW5kDQo+
IHRoYXQgdGhpbmcgd291bGQgd29yayBldmVuIHRocm91Z2ggbmVzdGVkIHZpcnQsIGJ1dCBJ
IGRvbid0IHRoaW5rIHRoYXQncw0KPiBzdHJpY3RseSBuZWNlc3NhcnkgZm9yIGVuc3VyaW5n
IG5ldyBzZWN1cml0eSBwcm9wZXJ0aWVzIG9mIHZpcnRpbw0KPiBkZXZpY2VzIHdoZXJlIHRo
ZXkgY2FuIGJlIGVuZm9yY2VkLg0KPiANCj4+Pj4+IEZvciBtZSBzcGVjaWZpY2FsbHksIGEg
Y29tbWFuZCBsaW5lIG9wdGlvbiB3b3VsZCB3b3JrIChiZWNhdXNlIEkgZG9uJ3QNCj4+Pj4+
IHVzZSBYZW4tYmFzZWQgdmlydGlvIGRldmljZXMgd2hlbiBuZXN0ZWQgdW5kZXIgS1ZNLCBv
ciBhbnl3aGVyZSBhdCBhbGwsDQo+Pj4+PiBhdCBsZWFzdCBub3QgeWV0KSwgYnV0IEkgY2Fu
IHNlZSBmdXR1cmUgY2FzZXMgd2hlcmUgeW91IGhhdmUgdmlydGlvDQo+Pj4+PiBkZXZpY2Vz
IGZyb20gYm90aCBMMCBhbmQgTDEgaW4gdGhlIHNhbWUgZ3Vlc3QsIGFuZCB0aGVuIGl0IHdv
dWxkbid0IGJlDQo+Pj4+PiB0aGF0IHNpbXBsZS4NCj4+Pj4NCj4+Pj4gTGV0cyB0aGluayBv
ZiBhIGdlbmVyYWwgc29sdXRpb24gY292ZXJpbmcgYWxsIFBWIGRldmljZXMgKFhlbiBhbmQg
dmlydGlvKS4NCj4+Pg0KPj4+IEluIGZhY3QsIEkgd29uZGVyIHdoYXQncyB0aGUgc2VjdXJp
dHkgYmVuZWZpdCBvZg0KPj4+IENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5ULiBJZiB0
aGUgYmFja2VuZCBsaXZlcyBpbiBkb20wIChvcg0KPj4+IHN0dWJkb21haW4pLCBpdCBjYW4g
YWNjZXNzIHdob2xlIGd1ZXN0IG1lbW9yeSBhbnl3YXksIHdoZXRoZXIgZnJvbnRlbmQNCj4+
PiBsaWtlcyBpdCBvciBub3QuIEJ1dCBpZiB0aGUgYmFja2VuZCBpcyBlbHNld2hlcmUgKG9y
IGd1ZXN0IGlzIHByb3RlY3RlZA0KPj4+IHdpdGggQU1EIFNFVi1TTlAsIFhTTSBvciBzaW1p
bGFyKSwgdGhlbiB0aGUgYmFja2VuZCB3b24ndCBiZSBhYmxlIHRvIGFjY2Vzcw0KPj4+IG1l
bW9yeSBvdXRzaWRlIG9mIHdoYXQgZnJvbnRlbmQgc2hhcmVzIGV4cGxpY2l0bHkuIFNvLCBp
biB0aGUgbm9uLWRvbTAgY2FzZSwNCj4+PiBiYWNrZW5kIHRyeWluZyB0byBwcm92aWRlIG5v
bi1ncmFudC1iYXNlZCB2aXJ0aW8gZGV2aWNlIHdpbGwgc2ltcGx5IG5vdA0KPj4+IGZ1bmN0
aW9uIChiZWNhdXNlIG9mIGluYWJpbGl0eSB0byBhY2Nlc3MgZ3Vlc3QncyBtZW1vcnkpLCBp
bnN0ZWFkIG9mDQo+Pj4gZ2FpbmluZyB1bmludGVuZGVkIGFjY2Vzcy4gQW0gSSBtaXNzaW5n
IHNvbWUgaW1wbGljaXQgbWVtb3J5IHNoYXJpbmcNCj4+PiBoZXJlPw0KPj4NCj4+IFlvdSBh
cmUgbWlzc2luZyB0aGUgcG9zc2liaWxpdHkgdG8gaGF2ZSBhIGRlcHJpdmlsZWdlZCB1c2Vy
IGxhbmQgdmlydGlvDQo+PiBiYWNrZW5kLg0KPiANCj4gT2ssIGJ1dCB0aGF0IGJhY2tlbmQg
ZWl0aGVyIGNhbiB4ZW5mb3JlaWdubWVtb3J5X21hcCgpIGFyYml0cmFyeSBndWVzdCdzDQo+
IHBhZ2UgKGluIHdoaWNoIGNhc2UgaXQgZG9lc24ndCBtYXR0ZXIgaWYgdGhlIGZyb250ZW5k
IGRyaXZlciBsaWtlcw0KPiBub24tZ3JhbnQtYmFzZWQgZGV2aWNlIG9yIG5vdCksIG9yIGl0
IGNhbm5vdCAoaW4gd2hpY2ggY2FzZSwNCj4gbm9uLWdyYW50LWJhc2VkIGRldmljZSB3aWxs
IHNpbXBseSBub3Qgd29yaywgYmFja2VuZCBzdGlsbCB3b24ndCBoYXZlDQo+IGFjY2VzcyB0
byB0aGUgZ3Vlc3QgbWVtb3J5KS4NCj4gDQo+IFN1cmUsIHRoZSBlcnJvciByZXBvcnRpbmcg
bWlnaHQgYmUgZGlmZmVyZW50LCBidXQgSSBkb24ndCB0aGluayBpdA0KPiBjaGFuZ2VzIHRo
ZSBvdXRjb21lIHNlY3VyaXR5LXdpc2UuDQoNClRoZSBtYWluIHByb2JsZW0gd2l0aCBQViBn
dWVzdHMgaXMgdGhhdCBpbiBub3JtYWwgY2FzZXMgKG5vdCBuZXN0ZWQgdmlydCkNCnRoZSBi
YWNrZW5kIG11c3QgYmUgYXdhcmUgdGhhdCB0aGUgZnJvbnRlbmQgaXMgdXNpbmcgTUZOcyBp
bnN0ZWFkIG9mIGd1ZXN0DQpQRk5zIGZvciB2aXJ0aW8uIFRoaXMgaXMgdGhlIG9ubHkgcmVh
c29uIHdoeSB5b3UgY2FuIHVzZSB2aXJ0aW8gaW4gYQ0KbmVzdGVkIGRvbTAgdG9kYXkuDQoN
Ck5vdCByZXF1aXJpbmcgZ3JhbnRzIGZvciBQViBkb21haW5zIG1lYW5zIHRoYXQgdGhlICJu
b3JtYWwiIGNhc2Ugb2YgYSBub3QNCm5lc3RlZCBzZXR1cCB3aWxsIGZhaWwgbWlzZXJhYmx5
LiBTbyB0aGUgcmFyZSBjYXNlIG9mIG5lc3RlZCBzZXR1cHMgc2hvdWxkDQpiZSBzcGVjaWFs
IGNhc2VkIChlLmcuIHZpYSBhIGJvb3QgcGFyYW1ldGVyIG9mIHRoZSBndWVzdCksIGluIG9y
ZGVyIHRvIG5vdA0KY2F1c2Ugd2VpcmQgY3Jhc2hlcyBmb3IgdGhlIG5vbi1uZXN0ZWQgc2V0
dXAuDQoNCg0KSnVlcmdlbg0K
--------------3Gr6CaA0yyRf4wh8dOqwqRoq
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3Gr6CaA0yyRf4wh8dOqwqRoq--

--------------BkOKCgskQkPAePMqf4ZCGFtU--

--------------d55YQkVR09uIb8CsSygj709H
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+d60FAwAAAAAACgkQsN6d1ii/Ey/t
Vwf+MSYQTCqnLIv73xZsU/oV2qmVmenRRCtPasiwKw2vVVNAnK3v/iNVwh0abM45S4sOunIQazDy
c6qjBY3KHIh4V4XjjuEp7rNIfnieBOhiBud/0HzgGVF+DlipI3mGoqRWAy2RP7yivePa4Oesm3u2
YiV3m7YdI3b9s0oszyau0/DUlgbLL3SMZvacWjyLap186XwylNmAmK/oyasbHAI3b/+jGsSW2hXv
fgOkDnTWgbtdHHS6vptqdO/9I7mNjrVz28CrC9t2hrGy8AleZc6AZns8BaPeRjM+1+wa/bpl1e8r
yfrmxuA+B4dJv0VPoYXQr1BOPhOlbaVc1Rxg7yx5sg==
=LtmR
-----END PGP SIGNATURE-----

--------------d55YQkVR09uIb8CsSygj709H--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:15:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:15:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416625.661262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL63-00042I-69; Thu, 06 Oct 2022 07:15:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416625.661262; Thu, 06 Oct 2022 07:15:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL63-00042B-3e; Thu, 06 Oct 2022 07:15:07 +0000
Received: by outflank-mailman (input) for mailman id 416625;
 Thu, 06 Oct 2022 07:15:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogL61-00041m-6C
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 07:15:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98ee0826-4546-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 09:15:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1C3081F893;
 Thu,  6 Oct 2022 07:15:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A893A1376E;
 Thu,  6 Oct 2022 07:15:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id jMLaJnaAPmMpEwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 07:15:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98ee0826-4546-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665040503; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=F4Hi4dJTyEkg0FruOU9TNRrOsyiLA+8nKk3nWX9VhZE=;
	b=ZhV6kFBaLi5TbOhS0qhdtyfiCwBaPWE8FdyiFl7JZTsGqjUjwktFVVsm7MfLtRf6z1qMs7
	gNEidOcTQv3IXG00aNrtlX3Sg3vluSmR3qCFdeoHIUikCbD1jRqdAicy+D879PW4QVHlzp
	/e4Nlyj5Uc7/GCpAOPtzW+zlk+tZBvc=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 0/3] xen/virtio: support grant based virtio on x86
Date: Thu,  6 Oct 2022 09:14:57 +0200
Message-Id: <20221006071500.15689-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add basic support for virtio with grants on x86 by defaulting the
backend to be in dom0 in the case the guest kernel was built with
CONFIG_XEN_VIRTIO_FORCE_GRANT.

Juergen Gross (3):
  xen/virtio: restructure xen grant dma setup
  xen/virtio: use dom0 as default backend for
    CONFIG_XEN_VIRTIO_FORCE_GRANT
  xen/virtio: enable grant based virtio on x86

 arch/x86/xen/enlighten_hvm.c |  2 +-
 arch/x86/xen/enlighten_pv.c  |  2 +-
 drivers/xen/grant-dma-ops.c  | 81 +++++++++++++++++++++++++-----------
 include/xen/xen-ops.h        |  1 +
 4 files changed, 59 insertions(+), 27 deletions(-)

-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:15:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:15:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416626.661274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL67-0004I5-DM; Thu, 06 Oct 2022 07:15:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416626.661274; Thu, 06 Oct 2022 07:15:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL67-0004Hy-AN; Thu, 06 Oct 2022 07:15:11 +0000
Received: by outflank-mailman (input) for mailman id 416626;
 Thu, 06 Oct 2022 07:15:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogL65-00041m-N8
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 07:15:09 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c1a63a5-4546-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 09:15:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id A3F671F8B4;
 Thu,  6 Oct 2022 07:15:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7644B1376E;
 Thu,  6 Oct 2022 07:15:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rbaVG3yAPmM2EwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 07:15:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c1a63a5-4546-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665040508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=blGlAxVjw5/6eJY5lj12Ctgxq+MWh1jybNrPJW65ItI=;
	b=hEHbAXRF22OPAX4YwHMgYgKd+iQAS3wV7mC+JrG0P8AVlfkPo0WePQjoqPsc5Nl7tiSieZ
	WxEBs9ooEwZN9U51qi3U3mm7BkCip8gDxHEeKdnfEEpPnI3MR8OhF9HS2HnYCz0uyTHvm4
	Oh+J6mcwl3G1+irYY+RAILlGW50XPss=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 1/3] xen/virtio: restructure xen grant dma setup
Date: Thu,  6 Oct 2022 09:14:58 +0200
Message-Id: <20221006071500.15689-2-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221006071500.15689-1-jgross@suse.com>
References: <20221006071500.15689-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In order to prepare supporting other means than device tree for
setting up virtio devices under Xen, restructure the functions
xen_is_grant_dma_device() and xen_grant_setup_dma_ops() a little bit.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/grant-dma-ops.c | 68 +++++++++++++++++++++++--------------
 1 file changed, 43 insertions(+), 25 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 8973fc1e9ccc..f29759d5301f 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -273,22 +273,28 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
-bool xen_is_grant_dma_device(struct device *dev)
+static bool xen_is_dt_grant_dma_device(struct device *dev)
 {
 	struct device_node *iommu_np;
 	bool has_iommu;
 
-	/* XXX Handle only DT devices for now */
-	if (!dev->of_node)
-		return false;
-
 	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
-	has_iommu = iommu_np && of_device_is_compatible(iommu_np, "xen,grant-dma");
+	has_iommu = iommu_np &&
+		    of_device_is_compatible(iommu_np, "xen,grant-dma");
 	of_node_put(iommu_np);
 
 	return has_iommu;
 }
 
+bool xen_is_grant_dma_device(struct device *dev)
+{
+	/* XXX Handle only DT devices for now */
+	if (dev->of_node)
+		return xen_is_dt_grant_dma_device(dev);
+
+	return false;
+}
+
 bool xen_virtio_mem_acc(struct virtio_device *dev)
 {
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT))
@@ -297,45 +303,56 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
 	return xen_is_grant_dma_device(dev->dev.parent);
 }
 
-void xen_grant_setup_dma_ops(struct device *dev)
+static int xen_dt_grant_setup_dma_ops(struct device *dev,
+				       struct xen_grant_dma_data *data)
 {
-	struct xen_grant_dma_data *data;
 	struct of_phandle_args iommu_spec;
 
-	data = find_xen_grant_dma_data(dev);
-	if (data) {
-		dev_err(dev, "Xen grant DMA data is already created\n");
-		return;
-	}
-
-	/* XXX ACPI device unsupported for now */
-	if (!dev->of_node)
-		goto err;
-
 	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
 			0, &iommu_spec)) {
 		dev_err(dev, "Cannot parse iommus property\n");
-		goto err;
+		return -ESRCH;
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
 			iommu_spec.args_count != 1) {
 		dev_err(dev, "Incompatible IOMMU node\n");
 		of_node_put(iommu_spec.np);
-		goto err;
+		return -ESRCH;
 	}
 
 	of_node_put(iommu_spec.np);
 
+	/*
+	 * The endpoint ID here means the ID of the domain where the
+	 * corresponding backend is running
+	 */
+	data->backend_domid = iommu_spec.args[0];
+
+	return 0;
+}
+
+void xen_grant_setup_dma_ops(struct device *dev)
+{
+	struct xen_grant_dma_data *data;
+
+	data = find_xen_grant_dma_data(dev);
+	if (data) {
+		dev_err(dev, "Xen grant DMA data is already created\n");
+		return;
+	}
+
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
 	if (!data)
 		goto err;
 
-	/*
-	 * The endpoint ID here means the ID of the domain where the corresponding
-	 * backend is running
-	 */
-	data->backend_domid = iommu_spec.args[0];
+	if (dev->of_node) {
+		if (xen_dt_grant_setup_dma_ops(dev, data))
+			goto err;
+	} else {
+		/* XXX ACPI device unsupported for now */
+		goto err;
+	}
 
 	if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,
 			GFP_KERNEL))) {
@@ -348,6 +365,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	return;
 
 err:
+	devm_kfree(dev, data);
 	dev_err(dev, "Cannot set up Xen grant DMA ops, retain platform DMA ops\n");
 }
 
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:15:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:15:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416627.661284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL6C-0004bc-L3; Thu, 06 Oct 2022 07:15:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416627.661284; Thu, 06 Oct 2022 07:15:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL6C-0004bN-IK; Thu, 06 Oct 2022 07:15:16 +0000
Received: by outflank-mailman (input) for mailman id 416627;
 Thu, 06 Oct 2022 07:15:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogL6B-0004aP-QI
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 07:15:15 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9f7e7a24-4546-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 09:15:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 547FD1F8C8;
 Thu,  6 Oct 2022 07:15:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 17F3B1376E;
 Thu,  6 Oct 2022 07:15:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 7+JTBIKAPmM+EwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 07:15:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f7e7a24-4546-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665040514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0CshijtaHr92stGSDZHMzCA/tn87geqWqdgj21TRuNc=;
	b=XcbUCD9o3PCb96W7Lx2pJ43DcJkjWoXykE9e7nTT/kS3m1zFb9YDxpuUVs2na45rQC+PCh
	sSh5iPuz1gLVgaZnLLoLdLvXZkXtz3YLIoZEYeZhhm6DGcwghEs1QYGawjNYkSah65JQsq
	EYuLVLQs3J+dFpZRCHv148T+yFFyXM4=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 2/3] xen/virtio: use dom0 as default backend for CONFIG_XEN_VIRTIO_FORCE_GRANT
Date: Thu,  6 Oct 2022 09:14:59 +0200
Message-Id: <20221006071500.15689-3-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221006071500.15689-1-jgross@suse.com>
References: <20221006071500.15689-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

With CONFIG_XEN_VIRTIO_FORCE_GRANT set the default backend domid to 0,
enabling to use xen_grant_dma_ops for those devices.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/grant-dma-ops.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index f29759d5301f..a00112235877 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -349,6 +349,9 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	if (dev->of_node) {
 		if (xen_dt_grant_setup_dma_ops(dev, data))
 			goto err;
+	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
+		dev_info(dev, "Using dom0 as backend\n");
+		data->backend_domid = 0;
 	} else {
 		/* XXX ACPI device unsupported for now */
 		goto err;
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:15:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:15:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416628.661296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL6H-0004xO-TN; Thu, 06 Oct 2022 07:15:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416628.661296; Thu, 06 Oct 2022 07:15:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogL6H-0004xF-Q2; Thu, 06 Oct 2022 07:15:21 +0000
Received: by outflank-mailman (input) for mailman id 416628;
 Thu, 06 Oct 2022 07:15:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogL6H-0004aP-4F
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 07:15:21 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2ef4024-4546-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 09:15:20 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1BC02219B0;
 Thu,  6 Oct 2022 07:15:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B51CE1376E;
 Thu,  6 Oct 2022 07:15:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MqLUKoeAPmNJEwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 07:15:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2ef4024-4546-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665040520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7Ps9KwyB3HzeWHTtk+TkXmbcFpLo/S34tHtBoU7GquI=;
	b=mqv/aQ0xhf3jHn27YkkjHI6JbMnzF0R/hfiYz+yvCI+4IpL/79Wa0CyW8t1leaae0aWx3m
	uHS7KHzrKvYdOxsxpiBr+vlF4gxQSdJ2xILjF6blKUTRNxvsgaQNfGLfyfkbRvGFjuUMEd
	4QKwMuqh9zjDVwgXZYgeQ0aTcivnjro=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 3/3] xen/virtio: enable grant based virtio on x86
Date: Thu,  6 Oct 2022 09:15:00 +0200
Message-Id: <20221006071500.15689-4-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221006071500.15689-1-jgross@suse.com>
References: <20221006071500.15689-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use an x86-specific virtio_check_mem_acc_cb() for Xen in order to setup
the correct DMA ops.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/enlighten_hvm.c |  2 +-
 arch/x86/xen/enlighten_pv.c  |  2 +-
 drivers/xen/grant-dma-ops.c  | 10 ++++++++++
 include/xen/xen-ops.h        |  1 +
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 1c1ac418484b..c1cd28e915a3 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -212,7 +212,7 @@ static void __init xen_hvm_guest_init(void)
 		return;
 
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT))
-		virtio_set_mem_acc_cb(virtio_require_restricted_mem_acc);
+		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
 
 	init_hvm_pv_info();
 
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 9b1a58dda935..45b24c1b646a 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -112,7 +112,7 @@ static void __init xen_pv_init_platform(void)
 {
 	/* PV guests can't operate virtio devices without grants. */
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO))
-		virtio_set_mem_acc_cb(virtio_require_restricted_mem_acc);
+		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
 
 	populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));
 
diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index a00112235877..60a7acc334ed 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -372,6 +372,16 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	dev_err(dev, "Cannot set up Xen grant DMA ops, retain platform DMA ops\n");
 }
 
+bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
+{
+	bool ret = xen_virtio_mem_acc(dev);
+
+	if (ret)
+		xen_grant_setup_dma_ops(dev->dev.parent);
+
+	return ret;
+}
+
 MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
 MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
 MODULE_LICENSE("GPL");
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index dae0f350c678..3dd5aa936f1d 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -219,6 +219,7 @@ static inline void xen_preemptible_hcall_end(void) { }
 void xen_grant_setup_dma_ops(struct device *dev);
 bool xen_is_grant_dma_device(struct device *dev);
 bool xen_virtio_mem_acc(struct virtio_device *dev);
+bool xen_virtio_restricted_mem_acc(struct virtio_device *dev);
 #else
 static inline void xen_grant_setup_dma_ops(struct device *dev)
 {
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:32:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:32:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416656.661309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLMU-0008E9-BD; Thu, 06 Oct 2022 07:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416656.661309; Thu, 06 Oct 2022 07:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLMU-0008E2-8W; Thu, 06 Oct 2022 07:32:06 +0000
Received: by outflank-mailman (input) for mailman id 416656;
 Thu, 06 Oct 2022 07:32:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hmTD=2H=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ogLMT-0008Dg-94
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 07:32:05 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f87ad460-4548-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 09:32:03 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 55A7261870
 for <xen-devel@lists.xenproject.org>; Thu,  6 Oct 2022 07:32:02 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEB98C43140
 for <xen-devel@lists.xenproject.org>; Thu,  6 Oct 2022 07:32:01 +0000 (UTC)
Received: by mail-lj1-f182.google.com with SMTP id x40so1214648ljq.9
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 00:32:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f87ad460-4548-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665041521;
	bh=VEE+qeskd4vr15hp0HONqTNmGFQc194J37xrvzeQFbA=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=p3GArwweEXG2MRPB0YiHgtfe31rDdrMAM3rqo8Hf4bD9zuKp1WCND2l8bPnSyWDAG
	 MyyD877aalEd0wimXnkH51ZDgsoHBd2S3FOBGER2clswRz1Wybejlo0MDmaVTi/RFV
	 jexIyjUV8kSIDLT4bTlO2RdX3upVdyItpIvgGIE8APijU1eKwCKWJN14+2/SiukeK8
	 GPi65RrikNAKqWDctAGvPEz7gbcmOk81NuyGWFyl9DaJGeZWpq40lDP0+V+nQxsvJd
	 WJ+YQ7k+LRFeF0k5Cow/CCQ2aaKb7hWXv/JE6ZqOUpH5zNco7mh3zrAFndcgz+ds+T
	 gITytupwMwt2g==
X-Gm-Message-State: ACrzQf3AmyAs3CAQUeimXSMzO0F7PadBnSacZM6EjFPYYVWZsYRLGLdF
	0kmRAfhGPQypbMr0HcUFfwzuY1CsrOaeVzPbwOs=
X-Google-Smtp-Source: AMsMyM4FY1O/rb/P8UUxDe34KFVoPInPMbW8nB/Pt6z7vbO72Tszv6qLckNvVf6ZyCal7E1hTuT+B0rpFotRK8/+HiM=
X-Received: by 2002:a2e:2d0a:0:b0:26c:a1c:cdf with SMTP id t10-20020a2e2d0a000000b0026c0a1c0cdfmr1335959ljt.352.1665041519591;
 Thu, 06 Oct 2022 00:31:59 -0700 (PDT)
MIME-Version: 1.0
References: <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email> <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email> <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email> <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email> <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
 <Yz4yLyvX6un1rrqC@itl-email>
In-Reply-To: <Yz4yLyvX6un1rrqC@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Thu, 6 Oct 2022 09:31:47 +0200
X-Gmail-Original-Message-ID: <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>
Message-ID: <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, 
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 6 Oct 2022 at 03:41, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Wed, Oct 05, 2022 at 11:28:29PM +0200, Ard Biesheuvel wrote:
> > On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
> > <demi@invisiblethingslab.com> wrote:
> > >
> > > On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > > > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > > > Linux has a function called efi_mem_reserve() that is used to reserve
> > > > > EfiBootServicesData memory that contains e.g. EFI configuration tables.
> > > > > This function does not work under Xen because Xen could have already
> > > > > clobbered the memory.  efi_mem_reserve() not working is the whole reason
> > > > > for this thread, as it prevents EFI tables that are in
> > > > > EfiBootServicesData from being used under Xen.
> > > > >
> > > > > A much nicer approach would be for Xen to reserve boot services memory
> > > > > unconditionally, but provide a hypercall that dom0 could used to free
> > > > > the parts of EfiBootServicesData memory that are no longer needed.  This
> > > > > would allow efi_mem_reserve() to work normally.
> > > >
> > > > efi_mem_reserve() actually working would be a layering violation;
> > > > controlling the EFI memory map is entirely Xen's job.
> > >
> > > Doing this properly would require Xen to understand all of the EFI
> > > tables that could validly be in EfiBootServices* and which could be of
> > > interest to dom0.  It might (at least on some very buggy firmware)
> > > require a partial ACPI and/or SMBIOS implementation too, if the firmware
> > > decided to put an ACPI or SMBIOS table in EfiBootServices*.
> > >
> > > > As to the hypercall you suggest - I wouldn't mind its addition, but only
> > > > for the case when -mapbs is used. As I've indicated before, I'm of the
> > > > opinion that default behavior should be matching the intentions of the
> > > > spec, and the intention of EfiBootServices* is for the space to be
> > > > reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
> > > > that hypercall: It might use it for regions where data lives which it
> > > > wouldn't care about itself, but which an eventual kexec-ed (or alike)
> > > > entity would later want to consume. Code/data potentially usable by
> > > > _anyone_ between two resets of the system cannot legitimately be freed
> > > > (and hence imo is wrong to live in EfiBootServices* regions).
> > >
> > > I agree, but currently some such data *is* in EfiBootServices* regions,
> > > sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
> > > configuration tables that point to EfiBootServicesData memory before
> > > freeing that memory.
> > >
> >
> > That seems like a reasonable approach to me. Tables like MEMATTR or
> > RT_PROP are mostly relevant for bare metal where the host kernel maps
> > the runtime services, and in general, passing on these tables without
> > knowing what they do is kind of fishy anyway. You might even argue
> > that only known table types should be forwarded in the first place,
> > regardless of the memory type.
>
> Which tables are worth handling in Xen?  I know about ACPI, SMBIOS, and
> ESRT, but I am curious which others Xen should preserve.  Currently, Xen
> does not know about RT_PROP or MEMATTR; could this be a cause of
> problems?

dom0 only has access to paravirtualized EFI runtime services, so
consuming RT_PROP or MEMATTR should be up to Xen (they describe which
runtime services remain available at runtime, and which permission
attributes to use for the runtime services memory regions,
respectively)

Looking through the kernel code, I don't think there are any that dom0
should care about beyond ACPI, SMBIOS and ESRT. But as you suggest,
that means Xen should just mask them in the view of the EFI system
table it exposes so dom0. Otherwise, the kernel may still try to map
and parse them.


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:35:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:35:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416663.661321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLQD-0000Qh-Uc; Thu, 06 Oct 2022 07:35:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416663.661321; Thu, 06 Oct 2022 07:35:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLQD-0000Qa-QK; Thu, 06 Oct 2022 07:35:57 +0000
Received: by outflank-mailman (input) for mailman id 416663;
 Thu, 06 Oct 2022 07:35:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v0w9=2H=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ogLQC-0000QS-I6
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 07:35:56 +0000
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com
 [2a00:1450:4864:20::52b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83387de1-4549-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 09:35:55 +0200 (CEST)
Received: by mail-ed1-x52b.google.com with SMTP id u21so1561690edi.9
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 00:35:55 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 w3-20020a1709062f8300b0072ed9efc9dfsm9879115eji.48.2022.10.06.00.35.53
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 06 Oct 2022 00:35:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83387de1-4549-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=0dtKZhkDgaoTTpO0pEO0vifhDrrgR+WBWj56fb3zUfQ=;
        b=W4RsQkzM7QFWf+K5p/TTKfFKwP/3vAkl3ikvYa4UUzVSCyQMmyAeRgkZ3zuyYZpFrb
         JUftfdmSzmLcggX6184vSHPvABJxE6t2J+YpnX6SsIFxwAwXEBZHJz1clQrA4TEcDNcp
         F/UP6XNrSQdF3jmwDZJIiY6jYzl1VG8YHYwSh7yMcsn8QpUDtktNKWLzOhO+g1b1gzji
         Tg6FCYROjaPOCYA/xMQR80QNQxx236f2KBJIjghQPZv2gcnCVr7SVO411apqJ6LQ9fgO
         NabZd8+h219Pw2vTF3RwlVmH/tLPkTLRXpj1zjUQyJLEL3s0hKi7Ed8DZP7hF1qJ73ei
         OWVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=0dtKZhkDgaoTTpO0pEO0vifhDrrgR+WBWj56fb3zUfQ=;
        b=lpRrWgk+obpptMMKez7JdLweYCN1BUTGJY/XD8XHY8owRT+peW/ArZH1aiTq8d6ryF
         htYo4XcKypUeZjBFf9uf4VxVU3h4DJBUSM946MQe6sQ5J0iqn1OfXFekMPueGJ8GjZz3
         Apy9W+oeWYmalA+j5U6nBA4Qce6jwlau9sQxObDJ3lMK3jBWSSFCR1gT1Nm50Ygi9nCk
         1BG2QHprt0IBTm/a4L+jx9YeUZ+l0KxAuyC/JEI73zIxrNwamEoB2u4NGZdgmnEcBobw
         8kRi7AJBsiZB7jaNqtxXt5A1j07GDrsNnEHyr0YH2zjZmz+u8hi+tPpXgt3Bw9iUHHd3
         b1ug==
X-Gm-Message-State: ACrzQf2rCGAnxA0hggmFzMUlvIbGHMiqe0kNrbQCPxrizEy/hjRehqjw
	uraUYPX9SzRuEQ2pANflam0=
X-Google-Smtp-Source: AMsMyM6QWzOQBtddsT3XuWD2bke2M6zHcURtDCNzNXrWLYhFV+Elgj1HIX09GNwNyVYdtaNyQ9Kc/Q==
X-Received: by 2002:a05:6402:3550:b0:451:473a:5ca3 with SMTP id f16-20020a056402355000b00451473a5ca3mr3365421edd.48.1665041755090;
        Thu, 06 Oct 2022 00:35:55 -0700 (PDT)
Message-ID: <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>
Date: Thu, 6 Oct 2022 10:35:53 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221005174823.1800761-2-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/5/22 20:48, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Take page offset into the account when calculating the number of pages
> to be granted.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict memory access under Xen")
> ---
>   drivers/xen/grant-dma-ops.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 8973fc1e9ccc..1998d0e8ce82 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -153,7 +153,7 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   					 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = PFN_UP(offset + size);

Here, why do we use PFN_UP and not XEN_PFN_UP?
Also, since the variable 'n_pages' seems to refer to the number of 
grants (unless I got it all entirely wrong ...), wouldn't it be more 
suitable to call explicitly gnttab_count_grant()?
If the above questions have been already answered in the past, please 
ignore.

>   	grant_ref_t grant;
>   	dma_addr_t dma_handle;
>   
> @@ -185,7 +185,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>   				     unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
> +	unsigned int i, n_pages = PFN_UP(offset + size);
>   	grant_ref_t grant;
>   
>   	if (WARN_ON(dir == DMA_NONE))

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 07:52:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 07:52:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416673.661332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLfx-0002rJ-Co; Thu, 06 Oct 2022 07:52:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416673.661332; Thu, 06 Oct 2022 07:52:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLfx-0002rC-9l; Thu, 06 Oct 2022 07:52:13 +0000
Received: by outflank-mailman (input) for mailman id 416673;
 Thu, 06 Oct 2022 07:52:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogLfw-0002r2-QF; Thu, 06 Oct 2022 07:52:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogLfw-0007m6-NK; Thu, 06 Oct 2022 07:52:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogLfw-0007In-DG; Thu, 06 Oct 2022 07:52:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogLfw-00012L-Ck; Thu, 06 Oct 2022 07:52:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o1rLzG44rpK+OeJtTKg+5tn2j2v4wKSXeggrpL4mHh4=; b=P96GUaXEqQxCmdSE/zaBsCvpK4
	fmshWLWBbcop9XJAeF0zy2q9KftAUlLneDoEV7L7jNyQDpnes4DkJnGUqcb040riH1Pm4sV6kaU5f
	zN/G7anOQikdlJbOdQp8B5O5whIuxYT6LAkdZarLPadCE/b/7dXwSPnCY4RTrdm18btI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173434-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173434: regressions - FAIL
X-Osstest-Failures:
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7e6739b9336e61fe23ca4e2c8d1fda8f19f979bf
X-Osstest-Versions-That:
    linux=2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 07:52:12 +0000

flight 173434 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173434/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 173426

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173426

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173426
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173426
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173426
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173426
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                7e6739b9336e61fe23ca4e2c8d1fda8f19f979bf
baseline version:
 linux                2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf

Last test of basis   173426  2022-10-05 08:41:36 Z    0 days
Testing same since   173434  2022-10-05 18:41:59 Z    0 days    1 attempts

------------------------------------------------------------
395 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 31640 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:05:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:05:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416686.661342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLsj-00050m-TT; Thu, 06 Oct 2022 08:05:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416686.661342; Thu, 06 Oct 2022 08:05:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogLsj-00050f-QL; Thu, 06 Oct 2022 08:05:25 +0000
Received: by outflank-mailman (input) for mailman id 416686;
 Thu, 06 Oct 2022 08:05:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogLsj-00050Z-78
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:05:25 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a0ca5f65-454d-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:05:23 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CEC281F8E3;
 Thu,  6 Oct 2022 08:05:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8458713AC8;
 Thu,  6 Oct 2022 08:05:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ginOHUKMPmM/KgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 08:05:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0ca5f65-454d-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665043522; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vUUR2UbJ0YzkcI6KzPhYHq2A2xLv/oqT/Dwhrd+tXOA=;
	b=c5v30QrN7NrllteZEVlz8Iu5Zj9ldNCx8agArvngoKQZdYl+Mcfb29JrwXKgV0/q2CuwhH
	s+xEW99p7tosSoOlI/nzf/tVbGfHnuMzG6H8bpE6Ertb7dMVSjiLKn7gAxqwyhR9MmTUyD
	+u7S34UP5Oq2QIlgwx43nBV3w0IKVww=
Message-ID: <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
Date: Thu, 6 Oct 2022 10:05:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
 <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ZJH7GOTQr00upljzwvPE4pWt"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ZJH7GOTQr00upljzwvPE4pWt
Content-Type: multipart/mixed; boundary="------------8kW5IUQoXA6saWh3aZAJ5lik";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
 <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>
In-Reply-To: <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>

--------------8kW5IUQoXA6saWh3aZAJ5lik
Content-Type: multipart/mixed; boundary="------------e5voAR9ahx30a4DjEYB2zzcZ"

--------------e5voAR9ahx30a4DjEYB2zzcZ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMDk6MzUsIFhlbmlhIFJhZ2lhZGFrb3Ugd3JvdGU6DQo+IA0KPiBPbiAx
MC81LzIyIDIwOjQ4LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9s
ZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+
DQo+PiBUYWtlIHBhZ2Ugb2Zmc2V0IGludG8gdGhlIGFjY291bnQgd2hlbiBjYWxjdWxhdGlu
ZyB0aGUgbnVtYmVyIG9mIHBhZ2VzDQo+PiB0byBiZSBncmFudGVkLg0KPj4NCj4+IFNpZ25l
ZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl
cGFtLmNvbT4NCj4+IEZpeGVzOiBkNmFjYTM1MDRjN2QgKCJ4ZW4vZ3JhbnQtZG1hLW9wczog
QWRkIG9wdGlvbiB0byByZXN0cmljdCBtZW1vcnkgYWNjZXNzIA0KPj4gdW5kZXIgWGVuIikN
Cj4+IC0tLQ0KPj4gwqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgNSArKystLQ0K
Pj4gwqAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkN
Cj4+DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJp
dmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBpbmRleCA4OTczZmMxZTljY2MuLjE5OThk
MGU4Y2U4MiAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0K
Pj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBAQCAtMTUzLDcgKzE1
Myw3IEBAIHN0YXRpYyBkbWFfYWRkcl90IHhlbl9ncmFudF9kbWFfbWFwX3BhZ2Uoc3RydWN0
IGRldmljZSANCj4+ICpkZXYsIHN0cnVjdCBwYWdlICpwYWdlLA0KPj4gwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBhdHRycykN
Cj4+IMKgIHsNCj4+IMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0
YTsNCj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBQRk5fVVAoc2l6ZSk7
DQo+PiArwqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gUEZOX1VQKG9mZnNldCAr
IHNpemUpOw0KPiANCj4gSGVyZSwgd2h5IGRvIHdlIHVzZSBQRk5fVVAgYW5kIG5vdCBYRU5f
UEZOX1VQPw0KPiBBbHNvLCBzaW5jZSB0aGUgdmFyaWFibGUgJ25fcGFnZXMnIHNlZW1zIHRv
IHJlZmVyIHRvIHRoZSBudW1iZXIgb2YgZ3JhbnRzIA0KPiAodW5sZXNzIEkgZ290IGl0IGFs
bCBlbnRpcmVseSB3cm9uZyAuLi4pLCB3b3VsZG4ndCBpdCBiZSBtb3JlIHN1aXRhYmxlIHRv
IGNhbGwgDQo+IGV4cGxpY2l0bHkgZ250dGFiX2NvdW50X2dyYW50KCk/DQoNCkdvb2QgcG9p
bnQuDQoNCkkgdGhpbmsgdGhpcyB3aWxsIG5lZWQgYW5vdGhlciBwYXRjaCBmb3Igc3dpdGNo
aW5nIGdyYW50LWRtYS1vcHMuYyB0bw0KdXNlIFhFTl9QQUdFX1NJWkUgYW5kIFhFTl9QQUdF
X1NISUZULg0KDQoNCkp1ZXJnZW4NCg0K
--------------e5voAR9ahx30a4DjEYB2zzcZ
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------e5voAR9ahx30a4DjEYB2zzcZ--

--------------8kW5IUQoXA6saWh3aZAJ5lik--

--------------ZJH7GOTQr00upljzwvPE4pWt
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+jEIFAwAAAAAACgkQsN6d1ii/Ey/Y
jggAlOBlnMSX/Eda/hfdrLDTn4dLywVeGEP7ryeHGrqA7NK+lr85SpyxaMGtk1xNXa2LniXutpV2
gpqk4Vxo/Cm+V1Kbd7ipnwrKLpEIeRNf5dEU1BoVtU5ig+U4M+9L9fAtWoVyf5ynEcnuzYu8B8Kp
8zTLxXckDShgSZVpRyKwYyIql3rlcx1BeBAfNSe5wJbpPbSX6uKMt+l5evPGWp19DikOpTsJZLr3
ZUXuYaoBe+LWX39WeYPuc6Hr2M+wzb9bAD9o9J6R4RILLxXDmMr91rVApG0C033O76Kk1Xzz8+vS
tCrQlYDATCa8ekzbOUTHOHczwuIHA5xtg39aFEXWpQ==
=9+jX
-----END PGP SIGNATURE-----

--------------ZJH7GOTQr00upljzwvPE4pWt--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:34:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:34:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416698.661354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMK1-0008Hl-8T; Thu, 06 Oct 2022 08:33:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416698.661354; Thu, 06 Oct 2022 08:33:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMK1-0008He-5e; Thu, 06 Oct 2022 08:33:37 +0000
Received: by outflank-mailman (input) for mailman id 416698;
 Thu, 06 Oct 2022 08:33:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogMJz-0008HY-HX
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:33:35 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f965277-4551-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:33:32 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id DE5EA211C5;
 Thu,  6 Oct 2022 08:33:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A621513AC8;
 Thu,  6 Oct 2022 08:33:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Qe6HJtuSPmMDNwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 08:33:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f965277-4551-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665045211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=f84fUu8FF2HoufHTZF+oszZ3+hFbpHGmxBI1iSGYNac=;
	b=dv3vLSFj2uXfjANnb5Bz7Sq4ROrYR7wj1BGnTc84d0WVFXXgPKH0FJa7VE03cQksrGoyl8
	NtAh0LMnVnHlGwggHDtbuFRkWVAx5tRpNh7qxRnHC4GgDyNnTkFVs0XknBO9KzEG1eEMWp
	9V7nhstZMPTbSZAAO8U1wU5KIkAKEOo=
Message-ID: <21daa651-2a2b-6784-9702-1df6280ecfba@suse.com>
Date: Thu, 6 Oct 2022 10:33:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
Content-Language: en-US
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-2-m.v.b@runbox.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221002222006.2077-2-m.v.b@runbox.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ObhQWZReGCG3CKnwa2Ynws2Z"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ObhQWZReGCG3CKnwa2Ynws2Z
Content-Type: multipart/mixed; boundary="------------53eJmbHYS2rLGzhhiPEmCEE2";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
Message-ID: <21daa651-2a2b-6784-9702-1df6280ecfba@suse.com>
Subject: Re: [PATCH v2 1/2] xen/gntdev: Prevent leaking grants
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-2-m.v.b@runbox.com>
In-Reply-To: <20221002222006.2077-2-m.v.b@runbox.com>

--------------53eJmbHYS2rLGzhhiPEmCEE2
Content-Type: multipart/mixed; boundary="------------0V00g0GOlj0nw1uaLkxh081c"

--------------0V00g0GOlj0nw1uaLkxh081c
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDMuMTAuMjIgMDA6MjAsIE0uIFZlZmEgQmljYWtjaSB3cm90ZToNCj4gUHJpb3IgdG8g
dGhpcyBjb21taXQsIGlmIGEgZ3JhbnQgbWFwcGluZyBvcGVyYXRpb24gZmFpbGVkIHBhcnRp
YWxseSwNCj4gc29tZSBvZiB0aGUgZW50cmllcyBpbiB0aGUgbWFwX29wcyBhcnJheSB3b3Vs
ZCBiZSBpbnZhbGlkLCB3aGVyZWFzIGFsbA0KPiBvZiB0aGUgZW50cmllcyBpbiB0aGUga21h
cF9vcHMgYXJyYXkgd291bGQgYmUgdmFsaWQuIFRoaXMgaW4gdHVybiB3b3VsZA0KPiBjYXVz
ZSB0aGUgZm9sbG93aW5nIGxvZ2ljIGluIGdudGRldl9tYXBfZ3JhbnRfcGFnZXMgdG8gYmVj
b21lIGludmFsaWQ6DQo+IA0KPiAgICBmb3IgKGkgPSAwOyBpIDwgbWFwLT5jb3VudDsgaSsr
KSB7DQo+ICAgICAgaWYgKG1hcC0+bWFwX29wc1tpXS5zdGF0dXMgPT0gR05UU1Rfb2theSkg
ew0KPiAgICAgICAgbWFwLT51bm1hcF9vcHNbaV0uaGFuZGxlID0gbWFwLT5tYXBfb3BzW2ld
LmhhbmRsZTsNCj4gICAgICAgIGlmICghdXNlX3B0ZW1vZCkNCj4gICAgICAgICAgYWxsb2Nl
ZCsrOw0KPiAgICAgIH0NCj4gICAgICBpZiAodXNlX3B0ZW1vZCkgew0KPiAgICAgICAgaWYg
KG1hcC0+a21hcF9vcHNbaV0uc3RhdHVzID09IEdOVFNUX29rYXkpIHsNCj4gICAgICAgICAg
aWYgKG1hcC0+bWFwX29wc1tpXS5zdGF0dXMgPT0gR05UU1Rfb2theSkNCj4gICAgICAgICAg
ICBhbGxvY2VkKys7DQo+ICAgICAgICAgIG1hcC0+a3VubWFwX29wc1tpXS5oYW5kbGUgPSBt
YXAtPmttYXBfb3BzW2ldLmhhbmRsZTsNCj4gICAgICAgIH0NCj4gICAgICB9DQo+ICAgIH0N
Cj4gICAgLi4uDQo+ICAgIGF0b21pY19hZGQoYWxsb2NlZCwgJm1hcC0+bGl2ZV9ncmFudHMp
Ow0KPiANCj4gQXNzdW1lIHRoYXQgdXNlX3B0ZW1vZCBpcyB0cnVlIChpLmUuLCB0aGUgZG9t
YWluIG1hcHBpbmcgdGhlIGdyYW50ZWQNCj4gcGFnZXMgaXMgYSBwYXJhdmlydHVhbGl6ZWQg
ZG9tYWluKS4gSW4gdGhlIGNvZGUgZXhjZXJwdCBhYm92ZSwgbm90ZSB0aGF0DQo+IHRoZSAi
YWxsb2NlZCIgdmFyaWFibGUgaXMgb25seSBpbmNyZW1lbnRlZCB3aGVuIGJvdGgga21hcF9v
cHNbaV0uc3RhdHVzDQo+IGFuZCBtYXBfb3BzW2ldLnN0YXR1cyBhcmUgc2V0IHRvIEdOVFNU
X29rYXkgKGkuZS4sIGJvdGggbWFwcGluZw0KPiBvcGVyYXRpb25zIGFyZSBzdWNjZXNzZnVs
KS4gIEhvd2V2ZXIsIGFzIGFsc28gbm90ZWQgYWJvdmUsIHRoZXJlIGFyZQ0KPiBjYXNlcyB3
aGVyZSBhIGdyYW50IG1hcHBpbmcgb3BlcmF0aW9uIGZhaWxzIHBhcnRpYWxseSwgYnJlYWtp
bmcgdGhlDQo+IGFzc3VtcHRpb24gb2YgdGhlIGNvZGUgZXhjZXJwdCBhYm92ZS4NCj4gDQo+
IFRoZSBhZm9yZW1lbnRpb25lZCBjYXVzZXMgbWFwLT5saXZlX2dyYW50cyB0byBiZSBpbmNv
cnJlY3RseSBzZXQuIEluDQo+IHNvbWUgY2FzZXMsIGFsbCBvZiB0aGUgbWFwX29wcyBtYXBw
aW5ncyBmYWlsLCBidXQgYWxsIG9mIHRoZSBrbWFwX29wcw0KPiBtYXBwaW5ncyBzdWNjZWVk
LCBtZWFuaW5nIHRoYXQgbGl2ZV9ncmFudHMgbWF5IHJlbWFpbiB6ZXJvLiBUaGlzIGluIHR1
cm4NCj4gbWFrZXMgaXQgaW1wb3NzaWJsZSB0byB1bm1hcCB0aGUgc3VjY2Vzc2Z1bGx5IGdy
YW50LW1hcHBlZCBwYWdlcyBwb2ludGVkDQo+IHRvIGJ5IGttYXBfb3BzLCBiZWNhdXNlIHVu
bWFwX2dyYW50X3BhZ2VzIGhhcyB0aGUgZm9sbG93aW5nIHNuaXBwZXQgb2YNCj4gY29kZSBh
dCBpdHMgYmVnaW5uaW5nOg0KPiANCj4gICAgaWYgKGF0b21pY19yZWFkKCZtYXAtPmxpdmVf
Z3JhbnRzKSA9PSAwKQ0KPiAgICAgIHJldHVybjsgLyogTm90aGluZyB0byBkbyAqLw0KPiAN
Cj4gSW4gb3RoZXIgY2FzZXMgd2hlcmUgb25seSBzb21lIG9mIHRoZSBtYXBfb3BzIG1hcHBp
bmdzIGZhaWwgYnV0IGFsbA0KPiBrbWFwX29wcyBtYXBwaW5ncyBzdWNjZWVkLCBsaXZlX2dy
YW50cyBpcyBtYWRlIHBvc2l0aXZlLCBidXQgd2hlbiB0aGUNCj4gdXNlciByZXF1ZXN0cyB1
bm1hcHBpbmcgdGhlIGdyYW50LW1hcHBlZCBwYWdlcywgX191bm1hcF9ncmFudF9wYWdlc19k
b25lDQo+IHdpbGwgdGhlbiBtYWtlIG1hcC0+bGl2ZV9ncmFudHMgbmVnYXRpdmUsIGJlY2F1
c2UgdGhlIGxhdHRlciBmdW5jdGlvbg0KPiBkb2VzIG5vdCBjaGVjayBpZiBhbGwgb2YgdGhl
IHBhZ2VzIHRoYXQgd2VyZSByZXF1ZXN0ZWQgdG8gYmUgdW5tYXBwZWQNCj4gd2VyZSBhY3R1
YWxseSB1bm1hcHBlZCwgYW5kIHRoZSBzYW1lIGZ1bmN0aW9uIHVuY29uZGl0aW9uYWxseSBz
dWJ0cmFjdHMNCj4gImRhdGEtPmNvdW50IiAoaS5lLiwgYSB2YWx1ZSB0aGF0IGNhbiBiZSBn
cmVhdGVyIHRoYW4gbWFwLT5saXZlX2dyYW50cykNCj4gZnJvbSBtYXAtPmxpdmVfZ3JhbnRz
LiBUaGUgc2lkZSBlZmZlY3RzIG9mIGEgbmVnYXRpdmUgbGl2ZV9ncmFudHMgdmFsdWUNCj4g
aGF2ZSBub3QgYmVlbiBzdHVkaWVkLg0KPiANCj4gVGhlIG5ldCBlZmZlY3Qgb2YgYWxsIG9m
IHRoaXMgaXMgdGhhdCBncmFudCByZWZlcmVuY2VzIGFyZSBsZWFrZWQgaW4gb25lDQo+IG9m
IHRoZSBhYm92ZSBjb25kaXRpb25zLiBJbiBRdWJlcyBPUyB2NC4xICh3aGljaCB1c2VzIFhl
bidzIGdyYW50DQo+IG1lY2hhbmlzbSBleHRlbnNpdmVseSBmb3IgWDExIEdVSSBpc29sYXRp
b24pLCB0aGlzIGlzc3VlIG1hbmlmZXN0cw0KPiBpdHNlbGYgd2l0aCB3YXJuaW5nIG1lc3Nh
Z2VzIGxpa2UgdGhlIGZvbGxvd2luZyB0byBiZSBwcmludGVkIG91dCBieSB0aGUNCj4gTGlu
dXgga2VybmVsIGluIHRoZSBWTSB0aGF0IGhhZCBncmFudGVkIHBhZ2VzICh0aGF0IGNvbnRh
aW4gWDExIEdVSQ0KPiB3aW5kb3cgZGF0YSkgdG8gZG9tMDogImcuZS4gMHgxMjM0IHN0aWxs
IHBlbmRpbmciLCBlc3BlY2lhbGx5IGFmdGVyIHRoZQ0KPiB1c2VyIHJhcGlkbHkgcmVzaXpl
cyBHVUkgVk0gd2luZG93cyAoY2F1c2luZyBzb21lIGdyYW50LW1hcHBpbmcNCj4gb3BlcmF0
aW9ucyB0byBwYXJ0aWFsbHkgb3IgY29tcGxldGVseSBmYWlsLCBkdWUgdG8gdGhlIGZhY3Qg
dGhhdCB0aGUgVk0NCj4gdW5zaGFyZXMgc29tZSBvZiB0aGUgcGFnZXMgYXMgcGFydCBvZiB0
aGUgd2luZG93IHJlc2l6aW5nLCBtYWtpbmcgdGhlDQo+IHBhZ2VzIGltcG9zc2libGUgdG8g
Z3JhbnQtbWFwIGZyb20gZG9tMCkuDQo+IA0KPiBUaGUgZml4IGZvciB0aGlzIGlzc3VlIGlu
dm9sdmVzIGNvdW50aW5nIGFsbCBzdWNjZXNzZnVsIG1hcF9vcHMgYW5kDQo+IGttYXBfb3Bz
IG1hcHBpbmdzIHNlcGFyYXRlbHksIGFuZCB0aGVuIGFkZGluZyB0aGUgc3VtIHRvIGxpdmVf
Z3JhbnRzLg0KPiBEdXJpbmcgdW5tYXBwaW5nLCBvbmx5IHRoZSBudW1iZXIgb2Ygc3VjY2Vz
c2Z1bGx5IHVubWFwcGVkIGdyYW50cyBpcw0KPiBzdWJ0cmFjdGVkIGZyb20gbGl2ZV9ncmFu
dHMuIFRoZSBjb2RlIGlzIGFsc28gbW9kaWZpZWQgdG8gY2hlY2sgZm9yDQo+IG5lZ2F0aXZl
IGxpdmVfZ3JhbnRzIHZhbHVlcyBhZnRlciB0aGUgc3VidHJhY3Rpb24gYW5kIHdhcm4gdGhl
IHVzZXIuDQo+IA0KPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vUXViZXNPUy9xdWJlcy1p
c3N1ZXMvaXNzdWVzLzc2MzENCj4gRml4ZXM6IGRiZTk3Y2ZmN2RkOSAoInhlbi9nbnRkZXY6
IEF2b2lkIGJsb2NraW5nIGluIHVubWFwX2dyYW50X3BhZ2VzKCkiKQ0KPiBDYzogc3RhYmxl
QHZnZXIua2VybmVsLm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBNLiBWZWZhIEJpY2FrY2kgPG0u
di5iQHJ1bmJveC5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA
c3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo=
--------------0V00g0GOlj0nw1uaLkxh081c
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0V00g0GOlj0nw1uaLkxh081c--

--------------53eJmbHYS2rLGzhhiPEmCEE2--

--------------ObhQWZReGCG3CKnwa2Ynws2Z
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+ktsFAwAAAAAACgkQsN6d1ii/Ey+o
sQgAhJiP7E3c9gOBneKlaQ6JE/Cj1XwZmds5Q9ZPeZMwuX79oBh+/dYSFjkJss2tji+dkDT/hqgz
c6OUYvDC2DNUB6eYX358dstqyv0d9I9KZmTCSKM6ZbflLGlwijCYJL3BHZcb/W40RWSpsneygSv8
hnCPThgXKjSlx75n5Ke9VQHvEhMuXZecRV3TIQtKqtcHaIcJMygf1clj/G9NVdTqN0WYAH4G1dPT
vI1l9FDddAs7F3k+ZZ2lgdYwAq3BCFRJoi6FHDn3PLgeYyoDQjUxeBUDXi/yuqeJ1dsP/1Ykx8HT
LCrywnJlfzwPFV0TwrPoHT3i9QH1v3c06746drocwA==
=zAam
-----END PGP SIGNATURE-----

--------------ObhQWZReGCG3CKnwa2Ynws2Z--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:36:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:36:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416708.661364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMMS-0000XZ-Pa; Thu, 06 Oct 2022 08:36:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416708.661364; Thu, 06 Oct 2022 08:36:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMMS-0000XS-Mo; Thu, 06 Oct 2022 08:36:08 +0000
Received: by outflank-mailman (input) for mailman id 416708;
 Thu, 06 Oct 2022 08:36:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogMMR-0000XM-03
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:36:07 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb1760d1-4551-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:36:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 9BA2E1F8DB;
 Thu,  6 Oct 2022 08:36:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6093213AC8;
 Thu,  6 Oct 2022 08:36:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 20tAFnWTPmP6OAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 08:36:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb1760d1-4551-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665045365; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=R8OpqC5umbKgqiaka26/pXGCBnRqENWb8B6kLTdT2dc=;
	b=sgHRA37TgmSq54o9uDZxlpNBCFSajYwxT9XBkt9rGdIHXhcBKRRoU2jfz4FX1kE5HOoVHj
	c5tukEKYp0bmQ81AcNw+aKrfaGMQwXjHne+8sXkgEEkkRHKKE3UCtHNd4GAIW2tduKrIdX
	Xcb//cPZrVozbQmVrJMZsswevoq512E=
Message-ID: <f75479fe-7435-0674-94b0-db15309c38ec@suse.com>
Date: Thu, 6 Oct 2022 10:36:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 2/2] xen/gntdev: Accommodate VMA splitting
Content-Language: en-US
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-3-m.v.b@runbox.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221002222006.2077-3-m.v.b@runbox.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------YUf2JIU0T5hI2YUDORbtxdoq"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------YUf2JIU0T5hI2YUDORbtxdoq
Content-Type: multipart/mixed; boundary="------------IjGgoXtuxp2V0zqgHSgK9e2I";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
Message-ID: <f75479fe-7435-0674-94b0-db15309c38ec@suse.com>
Subject: Re: [PATCH v2 2/2] xen/gntdev: Accommodate VMA splitting
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <20221002222006.2077-3-m.v.b@runbox.com>
In-Reply-To: <20221002222006.2077-3-m.v.b@runbox.com>

--------------IjGgoXtuxp2V0zqgHSgK9e2I
Content-Type: multipart/mixed; boundary="------------kjoMmuO0jETWZQqqeRFMErhi"

--------------kjoMmuO0jETWZQqqeRFMErhi
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDMuMTAuMjIgMDA6MjAsIE0uIFZlZmEgQmljYWtjaSB3cm90ZToNCj4gUHJpb3IgdG8g
dGhpcyBjb21taXQsIHRoZSBnbnRkZXYgZHJpdmVyIGNvZGUgZGlkIG5vdCBoYW5kbGUgdGhl
DQo+IGZvbGxvd2luZyBzY2VuYXJpbyBjb3JyZWN0bHkgd2l0aCBwYXJhdmlydHVhbGl6ZWQg
KFBWKSBYZW4gZG9tYWluczoNCj4gDQo+ICogVXNlciBwcm9jZXNzIHNldHMgdXAgYSBnbnRk
ZXYgbWFwcGluZyBjb21wb3NlZCBvZiB0d28gZ3JhbnQgbWFwcGluZ3MNCj4gICAgKGkuZS4s
IHR3byBwYWdlcyBzaGFyZWQgYnkgYW5vdGhlciBYZW4gZG9tYWluKS4NCj4gKiBVc2VyIHBy
b2Nlc3MgbXVubWFwKClzIG9uZSBvZiB0aGUgcGFnZXMuDQo+ICogVXNlciBwcm9jZXNzIG11
bm1hcCgpcyB0aGUgcmVtYWluaW5nIHBhZ2UuDQo+ICogVXNlciBwcm9jZXNzIGV4aXRzLg0K
PiANCj4gSW4gdGhlIHNjZW5hcmlvIGFib3ZlLCB0aGUgdXNlciBwcm9jZXNzIHdvdWxkIGNh
dXNlIHRoZSBrZXJuZWwgdG8gbG9nDQo+IHRoZSBmb2xsb3dpbmcgbWVzc2FnZXMgaW4gZG1l
c2cgZm9yIHRoZSBmaXJzdCBtdW5tYXAoKSwgYW5kIHRoZSBzZWNvbmQNCj4gbXVubWFwKCkg
Y2FsbCB3b3VsZCByZXN1bHQgaW4gc2ltaWxhciBsb2cgbWVzc2FnZXM6DQo+IA0KPiAgICBC
VUc6IEJhZCBwYWdlIG1hcCBpbiBwcm9jZXNzIGRvdWJsZW1hcC50ZXN0ICBwdGU6Li4uIHBt
ZDouLi4NCj4gICAgcGFnZTowMDAwMDAwMDU3Yzk3YmZmIHJlZmNvdW50OjEgbWFwY291bnQ6
LTEgXA0KPiAgICAgIG1hcHBpbmc6MDAwMDAwMDAwMDAwMDAwMCBpbmRleDoweDAgcGZuOi4u
Lg0KPiAgICAuLi4NCj4gICAgcGFnZSBkdW1wZWQgYmVjYXVzZTogYmFkIHB0ZQ0KPiAgICAu
Li4NCj4gICAgZmlsZTpnbnRkZXYgZmF1bHQ6MHgwIG1tYXA6Z250ZGV2X21tYXAgW3hlbl9n
bnRkZXZdIHJlYWRwYWdlOjB4MA0KPiAgICAuLi4NCj4gICAgQ2FsbCBUcmFjZToNCj4gICAg
IDxUQVNLPg0KPiAgICAgZHVtcF9zdGFja19sdmwrMHg0Ni8weDVlDQo+ICAgICBwcmludF9i
YWRfcHRlLmNvbGQrMHg2Ni8weGI2DQo+ICAgICB1bm1hcF9wYWdlX3JhbmdlKzB4N2U1LzB4
ZGMwDQo+ICAgICB1bm1hcF92bWFzKzB4NzgvMHhmMA0KPiAgICAgdW5tYXBfcmVnaW9uKzB4
YTgvMHgxMTANCj4gICAgIF9fZG9fbXVubWFwKzB4MWVhLzB4NGUwDQo+ICAgICBfX3ZtX211
bm1hcCsweDc1LzB4MTIwDQo+ICAgICBfX3g2NF9zeXNfbXVubWFwKzB4MjgvMHg0MA0KPiAg
ICAgZG9fc3lzY2FsbF82NCsweDM4LzB4OTANCj4gICAgIGVudHJ5X1NZU0NBTExfNjRfYWZ0
ZXJfaHdmcmFtZSsweDYxLzB4Y2INCj4gICAgIC4uLg0KPiANCj4gRm9yIGVhY2ggbXVubWFw
KCkgY2FsbCwgdGhlIFhlbiBoeXBlcnZpc29yIChpZiBidWlsdCB3aXRoIENPTkZJR19ERUJV
RykNCj4gd291bGQgcHJpbnQgb3V0IHRoZSBmb2xsb3dpbmcgYW5kIHRyaWdnZXIgYSBnZW5l
cmFsIHByb3RlY3Rpb24gZmF1bHQgaW4NCj4gdGhlIGFmZmVjdGVkIFhlbiBQViBkb21haW46
DQo+IA0KPiAgICAoWEVOKSBkMHYuLi4gQXR0ZW1wdCB0byBpbXBsaWNpdGx5IHVubWFwIGQw
J3MgZ3JhbnQgUFRFIC4uLg0KPiAgICAoWEVOKSBkMHYuLi4gQXR0ZW1wdCB0byBpbXBsaWNp
dGx5IHVubWFwIGQwJ3MgZ3JhbnQgUFRFIC4uLg0KPiANCj4gQXMgb2YgdGhpcyB3cml0aW5n
LCBnbnRkZXZfZ3JhbnRfbWFwIHN0cnVjdHVyZSdzIHZtYSBmaWVsZCAocmVmZXJyZWQgdG8N
Cj4gYXMgbWFwLT52bWEgYmVsb3cpIGlzIG1haW5seSB1c2VkIGZvciBjaGVja2luZyB0aGUg
c3RhcnQgYW5kIGVuZA0KPiBhZGRyZXNzZXMgb2YgbWFwcGluZ3MuIEhvd2V2ZXIsIHdpdGgg
c3BsaXQgVk1BcywgdGhlc2UgbWF5IGNoYW5nZSwgYW5kDQo+IHRoZXJlIGNvdWxkIGJlIG1v
cmUgdGhhbiBvbmUgVk1BIGFzc29jaWF0ZWQgd2l0aCBhIGdudGRldiBtYXBwaW5nLg0KPiBI
ZW5jZSwgcmVtb3ZlIHRoZSB1c2Ugb2YgbWFwLT52bWEgYW5kIHJlbHkgb24gbWFwLT5wYWdl
c192bV9zdGFydCBmb3INCj4gdGhlIG9yaWdpbmFsIHN0YXJ0IGFkZHJlc3MgYW5kIG9uICht
YXAtPmNvdW50IDw8IFBBR0VfU0hJRlQpIGZvciB0aGUNCj4gb3JpZ2luYWwgbWFwcGluZyBz
aXplLiBMZXQgdGhlIGludmFsaWRhdGUoKSBhbmQgZmluZF9zcGVjaWFsX3BhZ2UoKQ0KPiBo
b29rcyB1c2UgdGhlc2UuDQo+IA0KPiBBbHNvLCBnaXZlbiB0aGF0IHRoZXJlIGNhbiBiZSBt
dWx0aXBsZSBWTUFzIGFzc29jaWF0ZWQgd2l0aCBhIGdudGRldg0KPiBtYXBwaW5nLCBtb3Zl
IHRoZSAibW11X2ludGVydmFsX25vdGlmaWVyX3JlbW92ZSgmbWFwLT5ub3RpZmllcikiIGNh
bGwgdG8NCj4gdGhlIGVuZCBvZiBnbnRkZXZfcHV0X21hcCwgc28gdGhhdCB0aGUgTU1VIG5v
dGlmaWVyIGlzIG9ubHkgcmVtb3ZlZA0KPiBhZnRlciB0aGUgY2xvc2luZyBvZiB0aGUgbGFz
dCByZW1haW5pbmcgVk1BLg0KPiANCj4gRmluYWxseSwgdXNlIGFuIGF0b21pYyB0byBwcmV2
ZW50IGluYWR2ZXJ0ZW50IGdudGRldiBtYXBwaW5nIHJlLXVzZSwNCj4gaW5zdGVhZCBvZiB1
c2luZyB0aGUgbWFwLT5saXZlX2dyYW50cyBhdG9taWMgY291bnRlciBhbmQvb3IgdGhlIG1h
cC0+dm1hDQo+IHBvaW50ZXIgKHRoZSBsYXR0ZXIgb2Ygd2hpY2ggaXMgbm93IHJlbW92ZWQp
LiBUaGlzIHByZXZlbnRzIHRoZQ0KPiB1c2Vyc3BhY2UgZnJvbSBtbWFwKCknaW5nICh3aXRo
IE1BUF9GSVhFRCkgYSBnbnRkZXYgbWFwcGluZyBvdmVyIHRoZQ0KPiBzYW1lIGFkZHJlc3Mg
cmFuZ2UgYXMgYSBwcmV2aW91c2x5IHNldCB1cCBnbnRkZXYgbWFwcGluZy4gVGhpcyBzY2Vu
YXJpbw0KPiBjYW4gYmUgc3VtbWFyaXplZCB3aXRoIHRoZSBmb2xsb3dpbmcgY2FsbC10cmFj
ZSwgd2hpY2ggd2FzIHZhbGlkIHByaW9yDQo+IHRvIHRoaXMgY29tbWl0Og0KPiANCj4gICAg
bW1hcA0KPiAgICAgIGdudGRldl9tbWFwDQo+ICAgIG1tYXAgKHJlcGVhdCBtbWFwIHdpdGgg
TUFQX0ZJWEVEIG92ZXIgdGhlIHNhbWUgYWRkcmVzcyByYW5nZSkNCj4gICAgICBnbnRkZXZf
aW52YWxpZGF0ZQ0KPiAgICAgICAgdW5tYXBfZ3JhbnRfcGFnZXMgKHNldHMgJ2JlaW5nX3Jl
bW92ZWQnIGVudHJpZXMgdG8gdHJ1ZSkNCj4gICAgICAgICAgZ250dGFiX3VubWFwX3JlZnNf
YXN5bmMNCj4gICAgICB1bm1hcF9zaW5nbGVfdm1hDQo+ICAgICAgZ250ZGV2X21tYXAgKG1h
cHMgdGhlIHNoYXJlZCBwYWdlcyBhZ2FpbikNCj4gICAgbXVubWFwDQo+ICAgICAgZ250ZGV2
X2ludmFsaWRhdGUNCj4gICAgICAgIHVubWFwX2dyYW50X3BhZ2VzDQo+ICAgICAgICAgIChu
by1vcCBiZWNhdXNlICdiZWluZ19yZW1vdmVkJyBlbnRyaWVzIGFyZSB0cnVlKQ0KPiAgICAg
IHVubWFwX3NpbmdsZV92bWEgKEZvciBQViBkb21haW5zLCBYZW4gcmVwb3J0cyB0aGF0IGEg
Z3JhbnRlZCBwYWdlDQo+ICAgICAgICBpcyBiZWluZyB1bm1hcHBlZCBhbmQgdHJpZ2dlcnMg
YSBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQgaW4gdGhlDQo+ICAgICAgICBhZmZlY3RlZCBk
b21haW4sIGlmIFhlbiB3YXMgYnVpbHQgd2l0aCBDT05GSUdfREVCVUcpDQo+IA0KPiBUaGUg
Zml4IGZvciB0aGlzIGxhc3Qgc2NlbmFyaW8gY291bGQgYmUgd29ydGggaXRzIG93biBjb21t
aXQsIGJ1dCB3ZQ0KPiBvcHRlZCBmb3IgYSBzaW5nbGUgY29tbWl0LCBiZWNhdXNlIHJlbW92
aW5nIHRoZSBnbnRkZXZfZ3JhbnRfbWFwDQo+IHN0cnVjdHVyZSdzIHZtYSBmaWVsZCByZXF1
aXJlcyBndWFyZGluZyB0aGUgZW50cnkgdG8gZ250ZGV2X21tYXAoKSwgYW5kDQo+IHRoZSBs
aXZlX2dyYW50cyBhdG9taWMgY291bnRlciBpcyBub3Qgc3VmZmljaWVudCBvbiBpdHMgb3du
IHRvIHByZXZlbnQNCj4gdGhlIG1tYXAoKSBvdmVyIGEgcHJlLWV4aXN0aW5nIG1hcHBpbmcu
DQo+IA0KPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vUXViZXNPUy9xdWJlcy1pc3N1ZXMv
aXNzdWVzLzc2MzENCj4gRml4ZXM6IGFiMzE1MjNjMmZjYSAoInhlbi9nbnRkZXY6IGFsbG93
IHVzZXJtb2RlIHRvIG1hcCBncmFudGVkIHBhZ2VzIikNCj4gQ2M6IHN0YWJsZUB2Z2VyLmtl
cm5lbC5vcmcNCj4gU2lnbmVkLW9mZi1ieTogTS4gVmVmYSBCaWNha2NpIDxtLnYuYkBydW5i
b3guY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
Pg0KDQoNCkp1ZXJnZW4NCg==
--------------kjoMmuO0jETWZQqqeRFMErhi
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------kjoMmuO0jETWZQqqeRFMErhi--

--------------IjGgoXtuxp2V0zqgHSgK9e2I--

--------------YUf2JIU0T5hI2YUDORbtxdoq
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+k3UFAwAAAAAACgkQsN6d1ii/Ey9I
3wf/dobIWMjnzJ+7ZVzarL+TpoeVHIIZoipqIIxkjSbXjqaHNk+PbBC0hoPRUStK2cCwkjGrLNE4
QjQnoGoBOijwoLqudDoDO3zFlSV1OW9MBRSYgwsCfqwwjFdDa3S9rHbAPz5jhDbpKDCH0xgYxsTo
RpVyeLE1BylH15wZG1kKSGnhh50tsrwS65cxLZyF7aowrhuXx9NcsXNXeEwXCjqCWwGPPgC3Xtxr
pDYPsYYBX/cuaXKNo6fmauysAJqmnIxXKyhEzRNQ4ozTzXVgx9OnGtnsnFj3tcYbZuVVBZIA/uQ6
rmOUOpa+Z1m5ly7TpDVn7o2GjWbhORMnfbUPMJpWQg==
=SNzz
-----END PGP SIGNATURE-----

--------------YUf2JIU0T5hI2YUDORbtxdoq--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:39:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:39:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416716.661376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMPQ-00019k-7U; Thu, 06 Oct 2022 08:39:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416716.661376; Thu, 06 Oct 2022 08:39:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMPQ-00019d-3z; Thu, 06 Oct 2022 08:39:12 +0000
Received: by outflank-mailman (input) for mailman id 416716;
 Thu, 06 Oct 2022 08:39:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogMPP-00019X-MA
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:39:11 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 59022e2b-4552-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:39:10 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBAPR04MB7429.eurprd04.prod.outlook.com (2603:10a6:10:1a2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct
 2022 08:39:09 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 08:39:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59022e2b-4552-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BeVQTQRHyLzYIBgmMAc/g0EidRefepeeglbhj0se35pWyZmsWhGOPUmCW4nfog20znUZ11IIC9RxNHkHSl/1sFfdAoL20mFSOeON0te3EDWjWoVDS4eHOFf4Psv6jWmAB01tSQ8SXbJbVfQ3nBhWpvoCEzSOKSEZFs5u7A0u29oIvGlQtfrRz1SvCo0diDoj2Jk8R/zc3fHobteeVIutgscjg0GJes/xCCVaJk7ENewQeTnB9p9bnj9y7bG6ZaArV4hQgEnLFWA2IdnxMkmANRbDH+g0X7PUFS/jG2e7Q5Z8Ki4arB5g245Go/H9tiJTngBP4I6DBqRwp/esmWgWrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2D6BjJR1XSCo7F+SGErGgKQd6M3dfgKlllcFTmbq9TY=;
 b=n/75MNJeEtxYljayTMygXjy1J6blIXDiIl7o4k0LwaDlzf9sYE7SugTThnlAyHc4EO9RCPIVmgC1PFsGwUzCCiCv+ejdaKLRfpSAaBbZaS4O3ja/6huV03Pc4OK5gSF9D+ybdMDxD2SNH4K6qqXYrb8pwZUSLDf//RExvdaA74480LFJCULIPhkJJtktSt8ml9Therdf7hh1CZJjLXw/kAm+6dtwLKisKIXP4IJPRqweZFVkNz2ihuyNcR1DSHx9Qqb95Z/Ju9IMB4jABxB3jym3TRgvfocaLhNLeLWDg6Bz7UZL3K2jTRGCyrsq07BelyQvb3Nm+wrxtTXZkMyl8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2D6BjJR1XSCo7F+SGErGgKQd6M3dfgKlllcFTmbq9TY=;
 b=Kr6IEvBIKXKIzYyev6GaQVUDWIEQglhBuw6BDnCvE20Ybr2gcvo5tG8/gUh6xeoFi4lAzL0LhlEUUGb1m/4T6fye1K2x/2L1b89N9ynOPjLuIRHaHQz96SlNKw0TAkKQZZt0i0iBw/HnBtQ6HB7mcLneFqNCUuE8E8MFIlGX2+rngjcoA/02mTu0RJan+6fzYTnyoAgQ9wWrtHj7uHTs8u6rY1PPdLke1qxgn/1Tc6T8mX59jLv/tfGkKvoE+BYplhDYEJ2k6wJrrSwyIUwIS9MGJ/RiIJQJLiG+CUgoNTc+o1v1bX8EFS1Dh2uW0IrXmWTsfUx2jGK5PkYgnCdWyQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com>
Date: Thu, 6 Oct 2022 10:39:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
 <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
 <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P251CA0005.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:50f::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7429:EE_
X-MS-Office365-Filtering-Correlation-Id: 213c9216-d98e-4ba2-53bd-08daa7763c3c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hnUz9en6CAQ9C/qJj6Ut7h5Htp1Vu5p/DDU8CP+ydM0TJ78C+Cu4zMBSKnZ59qstCrhF41RuAewm4D23hyI3mZ0yUvHNqqtgAOYTyp1HvXzNs2Y+c8pXdeRL8m+EmOO6ZGWvnPpjQ2k2BYsXclHPtXU/CGICXzoHk6AQXuaXJ3OE8NAdVv1yDWDKFTycLFVsxtTzXA0RHHlMqsjBpLSIPh8eSfsYnXp8R2RAKofNTTBZMBlZpmrfp5ECGCQRKDbjV4nVX3fqJTfNG1CZAZEAZHkLY0CGIGheFPBohGnaPICRgQ+LJoo8xE2lshweThZJG0aP6nm6PO6A5XNEdYvIP65H43M2WGlcTb8hjK6FHYQiEfr7vJd2WpOdHrNwr9bD/2wZPAED7/wZ8B3MCyclTgc9aRfjfZHScxkHhdNcJH2ylt4Ua8tbfr5VafJdUqODXUpKgqbbv9p2wbF/HvDXrjZ1ZCZMi3SW2yf7kNaL9CeeyVN1PTIh4Oe9t6hWKsFuDk/baQzRTrap0Ho1EjzxW0m4gLCrsCEr22c/Uemeix5YninLVQxq1zoAQGcGWbSbXybgaZ6Np9+i9nqFUy1QBK/y2TkhNR3lLAlE2ohZLVDf8xhci/p+CFx5nc4rVQU02sRntgqYON3sPbuuX4N/v14bWbXBWVRG31zlP1+y2AWY8AIRL6yyNsaFI9imbh4paDRUx9Bc7VWWC8cRaHGbOCI+vIy2my3Wd49hmskP71K3NSDd8dK52yis2alkHAAe2G1gn8MbhIlGGh/RWowLw9MJcLxvSBhA5dmDBcCTueA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39850400004)(136003)(346002)(396003)(376002)(451199015)(2616005)(83380400001)(38100700002)(31696002)(36756003)(186003)(86362001)(5660300002)(8936002)(6512007)(66946007)(66556008)(66476007)(41300700001)(2906002)(26005)(54906003)(53546011)(478600001)(6486002)(31686004)(6506007)(316002)(4326008)(8676002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K2FCQktzVGpGc1l2d05JS1c3Z1B5QVQ3TGlENmZDV3UwbzdJYmVCVkJuaVhm?=
 =?utf-8?B?Q04vczhkUDJIL0kyOG56WVlVUmRXdDFoMkcxVnVNZWZMM2JWVG1TS3FTbkk0?=
 =?utf-8?B?ZkRGeGsvNWNDZTNSdkdJNW1kMFlJNHdwNmpFOXo4YVE0Zkl4NW8xeXRXQmpG?=
 =?utf-8?B?djdENkRHNlJyd1pIT0ZsZnRNNVR3dVlJQTYzM3E0dlpRbXo4MnNrNG5aUzE3?=
 =?utf-8?B?aWs4K1R6SjJyYXVTTGlTOEw4Rys0UEd1cGlNelVyRi9HVU1xNVRiUkFsYTBB?=
 =?utf-8?B?dVFsTHpKQW1PTTlQMURNMEU2NFZsNkYxZEo2SkZuTWRNTWJ0bW5sbGlHSWVk?=
 =?utf-8?B?Rk9wMFVQL3JlNG1KdVhXblhDTnBZQ21ULzhEd0x5WXhEWURVazUwYUE0aDJJ?=
 =?utf-8?B?d2d6cFhnS09YemdLOXdMRTB5dVU3aHRrSHRFQ3hodUtkbGRFNzR2dVEyTEN0?=
 =?utf-8?B?R05SRkp2cDZmMmhKTHJ5NmdvU2x5ckc2ai9JZmxWVU9WV25PVkc1V2xTUVR0?=
 =?utf-8?B?NnBGc043YklIMWZuVkticFpNN1E1NEx2NkoxWUgwRGhkNDdkam8zUThEV09W?=
 =?utf-8?B?MWtuTDFmSWxLTnV0dUJvVGpMM0xjTExwQmowcjE3bDA5aFZVQXN0Nmh2dTJB?=
 =?utf-8?B?QmNocnZFVzI0Zm1Ybk43SzU0bWdRWFc5RWtldzdRa3ZTRDJpejJZSE9Ld2xa?=
 =?utf-8?B?Tjhlalp5ZFVkZ05YTlAva1VGQjJmQ3lMZzdsb2hrL2Z5WlBVOGxHNGgwRytj?=
 =?utf-8?B?dWF2UzBBYzAzK3E0alVVc0hsaEExVm5PZUhSVUdJNzh3dVIyYkc3TGNzR01l?=
 =?utf-8?B?YlZqZ2xzbXNwRW9VYUtIbHUyM2xPRndsU2c1a1JSZnFuSEU5Yi9zVXNYSTJr?=
 =?utf-8?B?cU5sUllEMWJMZTRUeWNheGN1ekJadC9UK2Zobm92cE1HZ291T0ZadlYzZFVo?=
 =?utf-8?B?NWlHcjNjNlFVaFJyUVpYcWc5bFB3K05yMVp1KzM5WnR2akVRc05sY1FuZVpx?=
 =?utf-8?B?dTFjZXRCOHVuSFlDcDhGY3N1LzRPU2Z5K2NOK1JqVHJkbjNsWTFGYkZnS1JO?=
 =?utf-8?B?SnlUdUdWRGFURk5oODZlWEhGck91VWsyem56TGVkOEVDT1JYSkRvS0NnejI2?=
 =?utf-8?B?alVGMStMZjlHczE2emQxYlYxR3hiTEViZ3F5VHJ2TXdRczBtMDc3V3lBK0g2?=
 =?utf-8?B?am94U1Z2TlcrUkVZcytpdE4zS0VxNVdXYmlOSG8yanZGZWcyQk92YklNQjVG?=
 =?utf-8?B?WTVpU0dzUFVid0J3SUY2cGpuRDhYd1NwRHJZSmx3RHI5N0dlK0MxbS93N1ZQ?=
 =?utf-8?B?dklvd3FOb3lsNXFGcTdWMFppM1g5d1VvWXNPT0xodFFaZmhLU2JWMjZiRGZH?=
 =?utf-8?B?a0h2V0VSd3NEem9qTGpEcE5sNlVUYlErQm5SbDNTaU1WRUNmbldFMmxpZTZq?=
 =?utf-8?B?eGF1aHRRSkY5VkIzQm5lbElySm42ZGNjQ1I4d0xFRVdaTHRKamNtcGNJWVZt?=
 =?utf-8?B?bVJyYUNWQ2xxRVk2RlMxRHJhVzk1ZUx6ZVpHQkhwQ2Ewakw5WU80MWlrTkVu?=
 =?utf-8?B?eWRhZzBTMmJRQTlVSnRnN0ZXMnJzd3g3TzNNWUFvMG5DR05YU1JhR3VwQWRH?=
 =?utf-8?B?ZENRSkNzQ1ZYNHlwdjZ3eDR3VkYxaEhldUdHTE1XOGtuWGpSeHhhQ0FnNHN4?=
 =?utf-8?B?QkRtaXZLWUdFSXg4RmpkcSs3TkdXeHV4ckJvTzlSRktnMlZtY2dMTXE5NDg3?=
 =?utf-8?B?Z3Naa293MW4zRWFvRk1zajREdXh5U0xlaTZKVGpzOE8wV2lsbGx2V3lwT21F?=
 =?utf-8?B?U3pkbE9WYWcvcnFwUGxuSkRLcFpuOTdNYVMwdzlGNjZZL2lPTmhDaVNSVDZH?=
 =?utf-8?B?Z2hsVjZ0U21LZVJvV1NFVjJSK2I4YlhMWUVCL04yc3NNTzhrYjd2Y0k3MzI3?=
 =?utf-8?B?cVJDV3VNU2FwcUdqYVlhWlRvbkN2REg5b0QxSFFhVEsvSVVERzNzOTZvKy9D?=
 =?utf-8?B?SEZZdFlLVjQyM01HYWVadkxseW5XSG5IZWJJdVVFQjlSQzM3MVdxOXpYeTlS?=
 =?utf-8?B?M2J1bmo1OEtxMER5enBHTHZBOFZ2VkMvVTdMeHJaUGlyc3MvcngzaWVraFpO?=
 =?utf-8?Q?2qnmFd6dxPYKDj40O0XxzOp/y?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 213c9216-d98e-4ba2-53bd-08daa7763c3c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:39:08.7568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B9snuwcQ6F18WplFkSAozlvnpvMwXAM6F0kjyMRklRJyZBbbBQXkTiLc7hNhnv9ibTrSf1u1UOxHRkbnhxEzmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7429

On 05.10.2022 20:09, Julien Grall wrote:
> Hi Jan,
> 
> On 05/10/2022 12:55, Jan Beulich wrote:
>> On 05.10.2022 12:44, Julien Grall wrote:
>>> On 04/10/2022 16:58, Jan Beulich wrote:
>>>> On 30.09.2022 14:51, Bertrand Marquis wrote:
>>>>>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>>
>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>> runtime which was re-used for other purposes, make
>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>>
>>>>>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>>>>>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>>>>>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>
>>>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
>>>>
>>>> Thanks. However ...
>>>>
>>>>>> ---
>>>>>> Partly RFC for Arm, for two reasons:
>>>>>>
>>>>>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>>>>>> For one like on x86 such ranges would likely better be retained, as Dom0
>>>>>> may (will?) have a need to look at tables placed there. Plus converting
>>>>>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>>>>>> me as well. I'd be inclined to make the latter adjustment right here
>>>>>> (while the other change probably would better be separate, if there
>>>>>> aren't actually reasons for the present behavior).
>>>>
>>>> ... any views on this WB aspect at least (also Stefano or Julien)? Would be
>>>> good to know before I send v2.
>>>
>>> I don't quite understand what you are questioning here. Looking at the
>>> code, EfiACPIReclaimMemory will not be converted to RAM but added in a
>>> separate array.
>>>
>>> Furthermore, all the EfiACPIReclaimMemory regions will be passed to dom0
>>> (see acpi_create_efi_mmap_table()).
>>>
>>> So to me the code looks correct.
>>
>> Oh, I've indeed not paid enough attention to the first argument passed
>> to meminfo_add_bank(). I'm sorry for the extra noise. However, the
>> question I wanted to have addressed before sending out v3 was that
>> regarding the present using of memory when EFI_MEMORY_WB is not set.
>> Is that correct for the EfiACPIReclaimMemory case, i.e. is the
>> consumer (Dom0) aware that there might be a restriction?
> 
> Looking at the code, we always set EFI_MEMORY_WB for the reclaimable 
> region and the stage-2 mapping will be cachable.
> 
> So it looks like there would be a mismatch if EFI_MEMORY_WB is not set. 
> However, given the region is reclaimable, shouldn't this imply that the 
> flag is always set?

Possibly (but then again consider [perhaps hypothetical] systems with e.g.
just WT caches, where specifying WB simply wouldn't make sense). In any
event, even if that's the case, being on the safe side and doing

        if ( (desc_ptr->Attribute & EFI_MEMORY_RUNTIME) ||
             !(desc_ptr->Attribute & EFI_MEMORY_WB) )
            /* nothing */;
        else if ( ...

would seem better to me. However, if the mapping you mention above
would be adjusted and ...

>> And would
>> this memory then be guaranteed to never be freed into the general pool
>> of RAM pages?
> 
> The region is not treated as RAM by Xen and not owned by the dom0. 
> Therefore, it should not be possible to free the page because 
> get_page_from_gfn() would not be able to get a reference.

... the space cannot become ordinary RAM, then such a precaution
wouldn't be necessary. After all hiding EfiACPIReclaimMemory from
Dom0 just because it can't be mapped WB wouldn't be very nice
either. I guess I'll submit v2 with this part of the change left
as it was.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:41:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:41:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416723.661387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMRB-0002W3-Ic; Thu, 06 Oct 2022 08:41:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416723.661387; Thu, 06 Oct 2022 08:41:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMRB-0002Vw-FI; Thu, 06 Oct 2022 08:41:01 +0000
Received: by outflank-mailman (input) for mailman id 416723;
 Thu, 06 Oct 2022 08:41:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogMRA-0002Vq-Il
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:41:00 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60043.outbound.protection.outlook.com [40.107.6.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99e32e31-4552-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 10:40:59 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBAPR04MB7429.eurprd04.prod.outlook.com (2603:10a6:10:1a2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct
 2022 08:40:58 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 08:40:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99e32e31-4552-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hSQrbogoVk3ga0B/d42F/H87iBT10DMhFyudqRh1BHCJW94d3sPrSJyVyHa6dxLbu7nJSM4S5FyBk0bc+9c2TaTq9eg2yPWYjl475PDV6rN0fzfEHDx2h0AhCbUNt0YgoDCenlHLk9op6e0rnlhrrBwRdtRY7i+BW5N8BgxsUZ3xxVBLlmcl6Bxg6a+N+tVKGMz3lVXN18huTAy3N/iqJgYCVT6g+UiA16FHIKadpB39GUVRffQaB/n5AgYelEm6cIx0Yw+OvFLlIyk/2LZPNwoMCksIkRnUjXzhyJZV8DNEGbLlgebQWEEAhQ+nsfLn2touoQ51eV2E2aOEXblbdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KYJzW7pJsTsrG7cUmtwhu0ZLDOihzGR909f8ymBMUyw=;
 b=HNez0h8GEqh2P4s9sIkQlZmVJ6uCz5eTcd2DcnGvAr95oG22iUMF8vDKR+jzxmPbQRdj/DSyajof7V+l4kAirF4Ok/rJO7j35hRhaMTTk1tjGZiF2xwhEJZzDlNFaqc7IapOz02Kvr7kueh7xNRBXYwbhOaJcLs3nXKjn/GghydNGIxR/MfeDO29H3LJXimOi6RQlD6vB1AUZy0/BznsxrRky0Gsqv5JX/WNlA0UPQvDBiEuVGbJYacNCYV7wE7WU2B1jZKAPjO8x6pLXGiHRofpIAElIQ62PmE6MTFckUi4Uqj0GeyJ0klsK6oLluayatBF9WC0qgSrACKqI7/jeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KYJzW7pJsTsrG7cUmtwhu0ZLDOihzGR909f8ymBMUyw=;
 b=B1aZ94MoKoD0bk2QH1khEqQMkS0MiSHLGrd6Vf6ZtNXUDVV6J5vO337IfsoKEwJcVz97TIDOKZg+mgPWaaJ2XynvigHib9yr0kJ5Q9MkzJq0+wVKudUZnDpzlsKNm+M+/xMwuw3MyBGthZaAEj2ta8lnAIKk4HGD1QfXQ2tsbcK5H7afrFAzqqbEyg4GUGl7zZ5YPCIDyf77/udaZWHWxJ6OV/5BZtVJut+veFouM3gvdvQWqnKlQrBt2HX2x8YRVLCNiqZFOZ8l9+8mj4HBdQNbIvOOeVzNOlEl8z1HIdC5eQBJjgjzfWpbgrDI0dFl1YE6pGAY7fdg542PGcpwaQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
Date: Thu, 6 Oct 2022 10:40:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a2::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7429:EE_
X-MS-Office365-Filtering-Correlation-Id: 3d07e23e-6956-493b-042d-08daa7767d82
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CxVQ/fNHuW02DbY57+A8TPMt5uwbSOZl1fSQRtQPSVix0TbMfxH0DODuBKuZkaP9IQQLKcuMkvEqAwMjghhaWn22kwiSaaAQvWMyq8oZo6bWomCdTVrBhEH2hryVghXSK8BXUNR8PnMHjLdZ5raTSnOdRGQls7NHftbLOE1w3QIoRSgQ1PzfcF46/hqYYAmuFe8pES1O+0L+Zig+8za05iVlq6zVZhyKMeHla7FFQVWAHz1zBPQa/Iss6qcok5gvwaCQIyObPUZVPO56mTKJvbsbnUa2/ABvoPfGGG7Z/eiWyhvdOfLVyc+DG8rI3USMlsqEAgWKSz86x6kuItCHHPte25NvbZuU+niiQB/K/WLiT5Tx+7jxeV2zfeeEfYJ0AOXE7ljygu/Gi60hnzGOwG0F1CU9LCX9A1H9EgxHfSuXq3gTE2wTQOFdt0g5nOGUlOlz/MngxyyKGZAAkSsTPsa94UQKzu/kHxdCsayqU900seGZyp6+RLOcJlEN/h3nQKIJx5grPjFyjSpbDWnN88FX1IEVgJs3uMtBMl7X+TIzSAO8ojVeq0aBIcLjxI7PL1eewCfGru4gkQomWnaFAIfl12CfgYdSi4j0IPhAhEsELbe73Jz8erahCz8AVHVlRhDaCgtHWbrBBKLKequhfgGtcbG9pUuNuLax74w+BeE74RIkRQcaFiTuKyhaexWSjPKPv+PbrN6axUrgIUSRBTODlTTaDe4l8GEpbW0SNx+fdlIxg+T52ylMHd0n5tmyEx91Ld4G6byGPLAMehmr3iWehMFLbA52EctmejCd27U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39850400004)(136003)(346002)(396003)(376002)(451199015)(2616005)(83380400001)(38100700002)(31696002)(36756003)(186003)(86362001)(5660300002)(8936002)(6512007)(66946007)(66556008)(66476007)(41300700001)(2906002)(26005)(54906003)(478600001)(6486002)(31686004)(6506007)(316002)(4326008)(8676002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VGwxbDlBcWVXVUY1RGlacldPOHJRMjNYQjV3Tk9jOUE5UUpoMlBBR3MyRm0w?=
 =?utf-8?B?RWJ4dnJBVTVvOUswZHNpUmZCOXhBZTdZbk9GeUpKM3hxNzBDT2xoZEVpRjQ4?=
 =?utf-8?B?aXJvSlFGbnh2V0YyUmt3RDhGY1pQK2xEQ1hkQkJSQlpjdWs5RlIzVXNQVDZV?=
 =?utf-8?B?ejVlbmk4WUNnOUgwdTI5cE11THd3SHBZeFhNZmZjbyt6QWNBdkhWQWRtdFJ4?=
 =?utf-8?B?VGRHUlIrL0FXc3RpOGZLckorQ1hnVENWM1RWVVhHZFVBOGJuZ2xpWThSVDYx?=
 =?utf-8?B?cjNvU3hmUTN3ZUJEa2RhVlVGMGpwenRJOTN5T3REMnpFWE5xMy9SWU1FTHB4?=
 =?utf-8?B?RlRraGZMNWZxWFFhRkQ1dkNGZk02a1pGWlFkYkpQeUVzSzBtZkRCSlk2bnZU?=
 =?utf-8?B?QU90K25RSDE0c2hWREVGMG9iMjRnZGRyei9RK1h4U3ZqRFZBcXVRSDVTeDJv?=
 =?utf-8?B?djFRb2lTZ2U3dVJsTUpFZkVWK2JsMDBiSkIvUExwSlE1TktOTlNybmUydFN2?=
 =?utf-8?B?Ynh0VkZZMEFPVG1QeUdRT25GbXRudjl3Z2FjaEIzOXU2UmxhOUFZaElqNjZL?=
 =?utf-8?B?ZUVpV1NHKzNybk5BRmkwdVREakdXbDg2YkoxbzBzZlRMWHhwcXBFWHBYb0pF?=
 =?utf-8?B?NFNZZVZFWkhIWWJUMFphTDhFVVYwQWN2Z0lTb0sxcWc2MWQzS2ZMVXdOb3lv?=
 =?utf-8?B?bXFkSkhCQXRKUUY0cVpKdE84WlNWa3F2ZGY3NTVOaE5qUTE2QVR0Z0QvR2l0?=
 =?utf-8?B?Q1FzYS82amVpL3JjQW1IbzNVYjBqNVV6dWtyTUdMTUI5M2xnQURvam9oc0ZE?=
 =?utf-8?B?ZlQzK3hoTll4eW5kRVMzSFdPVW5aK2dtcjJVT3RTZGxIV1N1NTVOcUZtY2lp?=
 =?utf-8?B?SmVjK0k3dmp5T0QyMkxoY1d5aU01YnRITEZmWGo2N0w2NTRLWGxCV0JqRTVO?=
 =?utf-8?B?TnZwQlRBZGxOTHN3UUxwU0RzOHlmZjFLbVZCZG1GUHRpVkRGYUh1alhMMVlK?=
 =?utf-8?B?cndJYXQxWm9Dd3hKd1ZqWThTS0lrZWUxWDBUa280MHg4SnlDQmQ0b2Nzdzg5?=
 =?utf-8?B?Rjl2cG1zYTYrTHZKSURKakxYbjdNL3hSZERMc3pWTUl4V1dDUkpodUh5OUxG?=
 =?utf-8?B?QUZVbmJ6Vm1iWEk0SktxdVN4REFYQ2VLNktuSFZXZFVia3BmcjZpZHRxTGlS?=
 =?utf-8?B?djgwR0JwRDc0YXFiQjQvcXBmbEtJMnFOZXZEcmRTMTJ0RkFZNTh6U3lTbzU1?=
 =?utf-8?B?WlZiVzZ0dFJna0N6V2svV1NSOTlJeG9HSE9iR3pYWVNUcFdua0tDU0FNYTdj?=
 =?utf-8?B?ZnV5Q3VnUU0vaDBYYVdSQ0xUclBlYy9hOGhNOEI2ck0rYkdHdGlBbVFyRUg3?=
 =?utf-8?B?NjMwRUwvVFZCRFZRd0hsdmszVk0rMW1IUGgwMmJ6U05aeUgwTWdJY3hJOC91?=
 =?utf-8?B?NkxMdUlRSmlBaFRCaDlYT29EWjNpVVdrdWtMVGFmSlN2VGk2cmhrMTJ4RlNn?=
 =?utf-8?B?MzdoMXlTNjY0anB0ZEZsUjNLSEhBK1FCZllmeU40VDR0MHRCUWgxTkVIdi81?=
 =?utf-8?B?UGFpWEdPcEl2M3hTQ0Vhb0FrTStsOXlHbW5LeXJDK2VjNjlibVRFYzVHSFZo?=
 =?utf-8?B?bjFINUdpeVF4dWtMWStra2o2VWp2Tkl5aVk4d1liTG1HMTEzWE15QXJRZXQ2?=
 =?utf-8?B?bmx4UFdoOFJKa2hjN2MxZk4vR0FKRjJKVDBiNURRaG5NLzhzWEdlSXlZd01H?=
 =?utf-8?B?dTFlU2p0eWZHc0JZNTVBZVE4K0dLSjEvWWtVVGVQWkZQdGZNNU0rdGJURHF0?=
 =?utf-8?B?SHpCbzlIWW13ZTVscU5Uei9Ua1pNVmJuWW56WFpXYUkrNUZlUUdWL1dEYUlP?=
 =?utf-8?B?NDUzTTNhMmtOWXdnRXlmSzZCeTJjaDY5ZXNLY09FR24yRmlDMWZtdFQ3Z0Vw?=
 =?utf-8?B?MDZLUEtNeUxTdFZ5aktsNkdSKzlFTVhibEQzamNJZ3haQ1RweWUwc0FDQjhO?=
 =?utf-8?B?eEpLUWJ5eGRocElGWFJ6NEwwK1dtczBNTFhjSVpvSjM2ejNjZmh1ODRGdWdK?=
 =?utf-8?B?V3VRRGUzLzF6RGpxaVBIV0kxSXd1bVdqdGVhMzRHd3FibXN2dXRpQ2I2Nk1a?=
 =?utf-8?Q?QNTQUF27DasgmpxSsiyuB7TRT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d07e23e-6956-493b-042d-08daa7767d82
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:40:58.1092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gKZ7VbhggD7EILKc/qLDvHgLopJZpef1Y9NX4HGUWM7mu2xs6SBvW3axL1BBUGHmyC0Yd+tRiZPoSvVIobuzEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7429

efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
higher priority than the type of the range. To avoid accessing memory at
runtime which was re-used for other purposes, make
efi_arch_process_memory_map() follow suit. While on x86 in theory the
same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
to do so, bypassing Xen's memory management), hence that type's handling
can be left alone.

Fixes: bf6501a62e80 ("x86-64: EFI boot code")
Fixes: facac0af87ef ("x86-64: EFI runtime code")
Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> # Arm
Tested-By: Luca Fancellu <luca.fancellu@arm.com> # Arm
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
---
v2: Amend description.

--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -183,13 +183,15 @@ static EFI_STATUS __init efi_process_mem
 
     for ( Index = 0; Index < (mmap_size / desc_size); Index++ )
     {
-        if ( desc_ptr->Attribute & EFI_MEMORY_WB &&
-             (desc_ptr->Type == EfiConventionalMemory ||
-              desc_ptr->Type == EfiLoaderCode ||
-              desc_ptr->Type == EfiLoaderData ||
-              (!map_bs &&
-               (desc_ptr->Type == EfiBootServicesCode ||
-                desc_ptr->Type == EfiBootServicesData))) )
+        if ( desc_ptr->Attribute & EFI_MEMORY_RUNTIME )
+            /* nothing */;
+        else if ( (desc_ptr->Attribute & EFI_MEMORY_WB) &&
+                  (desc_ptr->Type == EfiConventionalMemory ||
+                   desc_ptr->Type == EfiLoaderCode ||
+                   desc_ptr->Type == EfiLoaderData ||
+                   (!map_bs &&
+                    (desc_ptr->Type == EfiBootServicesCode ||
+                     desc_ptr->Type == EfiBootServicesData))) )
         {
             if ( !meminfo_add_bank(&bootinfo.mem, desc_ptr) )
             {
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -185,7 +185,9 @@ static void __init efi_arch_process_memo
             /* fall through */
         case EfiLoaderCode:
         case EfiLoaderData:
-            if ( desc->Attribute & EFI_MEMORY_WB )
+            if ( desc->Attribute & EFI_MEMORY_RUNTIME )
+                type = E820_RESERVED;
+            else if ( desc->Attribute & EFI_MEMORY_WB )
                 type = E820_RAM;
             else
         case EfiUnusableMemory:


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:46:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416733.661398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMWb-0003G5-Ab; Thu, 06 Oct 2022 08:46:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416733.661398; Thu, 06 Oct 2022 08:46:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMWb-0003Fy-7o; Thu, 06 Oct 2022 08:46:37 +0000
Received: by outflank-mailman (input) for mailman id 416733;
 Thu, 06 Oct 2022 08:46:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=olH1=2H=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ogMWa-0003Fs-7D
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:46:36 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 612a2d66-4553-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:46:33 +0200 (CEST)
Received: from AM6P194CA0006.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::19)
 by AM7PR08MB5525.eurprd08.prod.outlook.com (2603:10a6:20b:107::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Thu, 6 Oct
 2022 08:46:27 +0000
Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::27) by AM6P194CA0006.outlook.office365.com
 (2603:10a6:209:90::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend
 Transport; Thu, 6 Oct 2022 08:46:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 6 Oct 2022 08:46:26 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Thu, 06 Oct 2022 08:46:26 +0000
Received: from 8cbf56838016.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4F514C12-8224-4435-98D4-9F45BA19AA5F.1; 
 Thu, 06 Oct 2022 08:46:15 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8cbf56838016.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 06 Oct 2022 08:46:15 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM9PR08MB5972.eurprd08.prod.outlook.com (2603:10a6:20b:280::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 6 Oct
 2022 08:46:14 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%4]) with mapi id 15.20.5676.028; Thu, 6 Oct 2022
 08:46:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 612a2d66-4553-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=H14UV8MEfawhCI3nLDO77Ij4Fpj7acnmrmjPYeTMp3lZDBd3HE+gHuSsmFI27CB91BaLOOrlnUmAhUZJfWzRzE5RxqNELqkr16lBfuZKcQ25lVRKUevLKZ2KEQgTPOpn3Mw8vKjuzSmDzoAN/ZJY07jE9+zlG44bFAq5M7kN0c1/Yeuttx/rjArk6ElsbZors+e2c2mtrD9eTMln26bjzPkEfZGr37RMTJZjKS2EXWQewqn/8jMroM7VZPaRUyjkD/P9rAMC5sNhswr0puU0zbqXkPx5bIjLHgO48iQvG4XXic5XvKDOO27kyN347i7QXVqvIjJPAK5xP64UT5XaIg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=52xC3eWi0jFfNxW1eJDDev8LqQZiW+lfEJt3l7ZI8HQ=;
 b=bZ0y2qPIltsOBK7tYh6nmCMhqJzADUcudYfsGZQ+z9mblY4tkCNSTgsWRnKIJmc74Li4NCOCSoU490MdRP0G2lhJm9Oh7xkSbd3sdK5C666SYZC3k9TdnwPIGB9BcKUF7VciNimvvwWMtD//F/QC/gnB/A67/eoI/eH2+g9TUwebfq8D6RjcIfQFD+g8NtTwCAErPOmuVs/9a/3TZZyBVc5CTbl+dOAU7pjYZQ7Q1MIqWPsMInn+PLOXaEg6Fgtd4rv8jErZ8lo9cmtX5n0eL4IHUnwGgWSOadyBlnSpch4fFi7CBQKLW17vZMs+KHNEWixhzo1Q9ZhJNRZpeSyN7A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=52xC3eWi0jFfNxW1eJDDev8LqQZiW+lfEJt3l7ZI8HQ=;
 b=KUISvdwdmMsx7HpLGmgGvEFEoH+0fA0NiJRVLMjGBozu1iuJGrilTwG0R4io/THhOfTvAjP1APe1OolPXlr+qNKXFeIWMY9JWosqi8+NgrJWHdM/S4gdFBNGhp/GAqzUTl1RL+wH0x2GoIzREfkNniyKPuC7kDzDGeLE5vlE1Kc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j6QYbXOdW8roGZ68shIQ8/E4D6zX8D7kRPSbdqSUOq6KQbQzGpbtaSFaVQZxBE8zIyuwbqd7a9q9LzzXSUG1V+j97yvmX+vaO/3jyRvq2VXJ5Gadg0XIKwvh21GclYaUL17nYilimYFKcQ6A/njUeK/wAVym3EO17fJ3doJmoHDCTGR0L+cLpyL5cmEimP7E5E/hDK33GS75rwo+gTHYeVhbyARGcUC2uOknuU+4JzptxIyf91lV3sCX+4jueup9e6Z1QbjwcuPSjkSiQEUUeHzlme6pf5oQ21m5PCPLFv3qz/kZO/PIJ9mySG4Jf4YKKrDpMZ+R2jRelAsbANMfCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=52xC3eWi0jFfNxW1eJDDev8LqQZiW+lfEJt3l7ZI8HQ=;
 b=XYfHBO1KNte5Qay6IKZrxPRF99l35z5TYsGCtskdlw5c/KyV9e1YxPkjVm1kDX1gknOARPDZ7oXHxwbXxQSP2VRASeY8nAUj7Xzzd5MDp1Qerf3f9mLGvoKx0iXkbq/XxTf50hd9aKDRra4xj05Btpqdz/K6KpgDdW0zodhKS0Ei5GzhNdh4lG+Ifb6S7LY72zn1MfUpb+ZcSqJPmSmRnxrm7UD9XKMr5pBJktP+GAvICF1/bwy1gvQHsqgCXM/LVpFvRMESGZ8IHyCdAccgANt8gAMKS9rlIGQPqcJ2XyAR6nmycfYZG5iS/6Iwt1G/mv/FAwpDgIK9ieoiaCFhFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=52xC3eWi0jFfNxW1eJDDev8LqQZiW+lfEJt3l7ZI8HQ=;
 b=KUISvdwdmMsx7HpLGmgGvEFEoH+0fA0NiJRVLMjGBozu1iuJGrilTwG0R4io/THhOfTvAjP1APe1OolPXlr+qNKXFeIWMY9JWosqi8+NgrJWHdM/S4gdFBNGhp/GAqzUTl1RL+wH0x2GoIzREfkNniyKPuC7kDzDGeLE5vlE1Kc=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr
 Babchuk <volodymyr_babchuk@epam.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
Subject: RE: [PATCH v2][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Thread-Topic: [PATCH v2][4.17] EFI: don't convert memory marked for runtime
 use to ordinary RAM
Thread-Index: AQHY2V9kZReqhAfkvEGGvlXoyp07JK4BDUEw
Date: Thu, 6 Oct 2022 08:46:13 +0000
Message-ID:
 <AS8PR08MB7991C4AB16708177EBB3BA11925C9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
In-Reply-To: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 9161D3D68E61514BB3608DCAA754A409.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM9PR08MB5972:EE_|VE1EUR03FT030:EE_|AM7PR08MB5525:EE_
X-MS-Office365-Filtering-Correlation-Id: c087eafe-7e64-4d0b-d0f8-08daa7774194
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VBub/505EZVDkvi/VjGSnjTTx2fot4TpUSxax/7vsCGWO9fmPZR7uqb9fzwFFjqQLpymMzXv0dbkfWccDLXcDdOoxGmnBSrmwZ3QTMz6Gk/WqGLJJ3JLdItRDZFk57MYW1o750peS7Ju/zmO5KagIMoarA1yj0Kr4Pg3SiVb9A63aw3xiFyG1lFl4L01vexxvqvOstg/wlUJkJ3yG6zKG9HBvGJnGSsNHBnkAdUi073V25lBpjVVHWXbvLIdqVr1puPT6X8WsgEaTAI+ORwmPRr+cutnffftxhnS3KxxOHxIrV4t109sKomPJ+0Yf1zYf/kLe4+JVygc1Ox/BEeu9B9/a1tlj8H+WP/M+yUR4Vwa03JWInWBrUKNWF0RTZ1MBIPTb/gAKza3RmULeLd6J5oXbOwP3o3duY9cNVtVxjtTp7nuyk6R+klPrqdj8Aw6PKWwmPbJYQyQnJCTTxzP8WZsWS1xBiN04ngObreclxZt97PpaxIf4oanSgC9JDhjoSLSWBZjNPeyujvsHA7WuAnYpNdC4hDUpVARNGKtL9fBRiRTx1udZK90v39E3cw6aDEO/ZCPIlAGNs8K020p6WYZy4bgOEA+cDgmrU/I+wH2Gcc3dkWETsa1IGey6tig1iBy0PiHlJ/W0DspqFPiI5wYKRLra/YA0znt6oruroGVvxVPDgU9wEr+AW1Zb4QmLusPSG3ykUniS3byp26B/wo9y45+oVbJNkuNgQmUQUYO05DlRUtCnfYG6lVMkTITzRANNGvBFw3GxBv9ZJwXEg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(136003)(39860400002)(396003)(376002)(451199015)(54906003)(316002)(38100700002)(41300700001)(71200400001)(86362001)(66946007)(8936002)(5660300002)(76116006)(110136005)(52536014)(66446008)(8676002)(64756008)(66476007)(33656002)(478600001)(66556008)(4326008)(38070700005)(26005)(122000001)(83380400001)(55016003)(9686003)(186003)(7696005)(6506007)(2906002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5972
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	848b355a-dde5-4df8-dcec-08daa77739d9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FhaiailrUPy2gfx2KZO92oSQARVuwJxuP14RpDCxGYzNIVl9e0sWrlKCJtbEINdQfyb1YUUL2/fsDMGMFq3ghLN6DiSgbXgMbzXY7RcFa8qZ8tyz/+2YjiQ4jznxLPcXtc1hv/VsDF0ZGv69UMu+gK02ZmdyYCteQ5l6fMfd5xH1d4vj59IpCO+n8ims9QmRH1CkO2gp7+p6aK/RfhUHKqvEjpQuSRwMMaoty2F2iayXW2np7uzXj8nkpbMM6jz9NV/G51Ck5SV2vqdmZJspSDHRYbxNX0koK0EZ+RluhkrZaMcSc+axZ2RfuCeT0Uy+5j2apAYNlGsalO13jpAr2CLsKZQ2MHmQ0yh3pK4IHyOHaCKg1b1nK9i+BsSX+sVwFpdgxMBRrTEaloqwJQ+0T3OUvKpKFo8QQtTcHaMBrHlkht1tEfyEiyRaa7nYwqClkFC1NsMaMJidOCyoOiH/bmYGwVN3B4Yho80ILvR0STGkF1wkb177GeNh2wjknxn+PT6hohWxLDMPfxhUpLntzHdjP24dlc2ErY7MsUuv/odEAyeSyyavwKk+8BsnGDy4B+DUBFJjaCTSBw7IILMtbYdoSpatodLfTQohhRYPmsYadnIYbmwP8SNXZ6EkqB0oED68ttQ/Sor65CEAVL3KThOGFVOscOWCsEjfc3jiDWXSWttYnvYnw3aiW0qObV+8/6hEBiRlicQW/r1im1PYUJt3TrUBOs84lROrxPI4XWU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(396003)(136003)(346002)(376002)(451199015)(46966006)(36840700001)(316002)(4326008)(8676002)(70586007)(110136005)(70206006)(54906003)(478600001)(336012)(26005)(82740400003)(7696005)(2906002)(9686003)(6506007)(33656002)(41300700001)(36860700001)(83380400001)(8936002)(5660300002)(55016003)(40480700001)(52536014)(86362001)(81166007)(82310400005)(186003)(356005)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:46:26.8327
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c087eafe-7e64-4d0b-d0f8-08daa7774194
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5525

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIHYyXVs0LjE3XSBFRkk6
IGRvbid0IGNvbnZlcnQgbWVtb3J5IG1hcmtlZCBmb3IgcnVudGltZSB1c2UNCj4gdG8gb3JkaW5h
cnkgUkFNDQo+IA0KPiBlZmlfaW5pdF9tZW1vcnkoKSBpbiBib3RoIHJlbGV2YW50IHBsYWNlcyBp
cyB0cmVhdGluZyBFRklfTUVNT1JZX1JVTlRJTUUNCj4gaGlnaGVyIHByaW9yaXR5IHRoYW4gdGhl
IHR5cGUgb2YgdGhlIHJhbmdlLiBUbyBhdm9pZCBhY2Nlc3NpbmcgbWVtb3J5IGF0DQo+IHJ1bnRp
bWUgd2hpY2ggd2FzIHJlLXVzZWQgZm9yIG90aGVyIHB1cnBvc2VzLCBtYWtlDQo+IGVmaV9hcmNo
X3Byb2Nlc3NfbWVtb3J5X21hcCgpIGZvbGxvdyBzdWl0LiBXaGlsZSBvbiB4ODYgaW4gdGhlb3J5
IHRoZQ0KPiBzYW1lIHdvdWxkIGFwcGx5IHRvIEVmaUFDUElSZWNsYWltTWVtb3J5LCB3ZSBkb24n
dCBhY3R1YWxseSAicmVjbGFpbSINCj4gRTgyMF9BQ1BJIG1lbW9yeSB0aGVyZSAoYW5kIGl0IHdv
dWxkIGJlIGEgYnVnIGlmIHRoZSBEb20wIGtlcm5lbCB0cmllZA0KPiB0byBkbyBzbywgYnlwYXNz
aW5nIFhlbidzIG1lbW9yeSBtYW5hZ2VtZW50KSwgaGVuY2UgdGhhdCB0eXBlJ3MgaGFuZGxpbmcN
Cj4gY2FuIGJlIGxlZnQgYWxvbmUuDQo+IA0KPiBGaXhlczogYmY2NTAxYTYyZTgwICgieDg2LTY0
OiBFRkkgYm9vdCBjb2RlIikNCj4gRml4ZXM6IGZhY2FjMGFmODdlZiAoIng4Ni02NDogRUZJIHJ1
bnRpbWUgY29kZSIpDQo+IEZpeGVzOiA2ZDcwZWExMGQ0OWYgKCJBZGQgQVJNIEVGSSBib290IHN1
cHBvcnQiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+
DQo+IFJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+ICMg
QXJtDQo+IFRlc3RlZC1CeTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPiAj
IEFybQ0KPiBSZXZpZXdlZC1ieTogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bh
cm0uY29tPiAjYXJtDQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdA
YXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAtLS0NCj4gdjI6IEFtZW5kIGRl
c2NyaXB0aW9uLg0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:48:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:48:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416741.661409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMYY-0003p3-NF; Thu, 06 Oct 2022 08:48:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416741.661409; Thu, 06 Oct 2022 08:48:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMYY-0003ow-K3; Thu, 06 Oct 2022 08:48:38 +0000
Received: by outflank-mailman (input) for mailman id 416741;
 Thu, 06 Oct 2022 08:48:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xibJ=2H=citrix.com=prvs=271cd1fce=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ogMYW-0003oq-Ku
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:48:36 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a84d39f3-4553-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:48:34 +0200 (CEST)
Received: from mail-dm6nam04lp2049.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 06 Oct 2022 04:48:30 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM8PR03MB6214.namprd03.prod.outlook.com (2603:10b6:8:3d::5) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5676.24; Thu, 6 Oct 2022 08:48:30 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 08:48:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a84d39f3-4553-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665046113;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fC5ZqGHbRR1q5qVyWWPtF+yGmC6Ql0eTZ30T62oxsO0=;
  b=C2pYUXlu8hns+McaV1vw5avonu/AAs7Xr01aOFmf13TyVNSdxS8BMhIg
   89SR1LqWTnFnB7apuV6YGwbjYZT25PNuwv5ncwRQB/TWAeP/zFoodbPuj
   wSmfzd7XgXFfo+ppTAswf9GHOVFT9Kyw6lQrXlFWYhzw7IgVwjz7eV/B1
   4=;
X-IronPort-RemoteIP: 104.47.73.49
X-IronPort-MID: 82086937
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:T0Nug6yMDu1Sd89rjJt6t+fJxyrEfRIJ4+MujC+fZmUNrF6WrkVRm
 2sWXGCFOvyNNDbyfI8lO96+pEsPsJTXydBhQVRorCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtA4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwoOUnWGJHz
 qEkJW4JZQKChNOWkK7nc7w57igjBJGD0II3nFhFlW2cIdN4BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/uxrsgA/zyQouFTpGMDSddGQA91cg26Tp
 37c/nS/CRYfXDCa4WrfqiLy17SQ9c/9cLpRG5aR1c5Ou1G4x0FUMUdVSQXiiNDs3yZSXPoac
 ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8FLD+Qw5QWJy6zVywWUHG4JSnhGctNOnM0rQT0n0
 HeZktWvAiZg2JWfRGiB7L6SoXW3MDIMMG4ZTSYeSE0O5NyLiL80ihXDX9NyCpmfh9f+GSzz6
 z2SpS14jLIW5eYU042r8FaBhCijzrDZQwhw6gjJU2aN6gJieJXjd4Gu8ULc7/tLMMCeVFbpg
 ZQfs82X7eRLAZTTkiWIGLkJBOvxu6fDNyDAi1lyGZVn7y6q53OoYYFX5nd5OVttNcEHPzTuZ
 Sc/pD9s2XOaB1PyBYcfXm57I51CIXTIfTg9as3pUw==
IronPort-HdrOrdr: A9a23:0hAEMKNkjX3JkMBcT6H255DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5
 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa
 DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVorFgMq8w6HiBKv8frfHwKD1hkTfjtTyfN6mF
 K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIihm9UYMTLljyevfcBEV6eZtD44jemz4BIBkc
 XKoT0nI8NvgkmhNV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYfB9BajYxUXxPF4w541esMmJ
 5j7ia8jd56HBnAlCPy65zhUAxrrFO9pT4HnfQIh3JSfIMCYPt6rJAZ/mlSDJAcdRiKobwPIa
 1LNoXx9fxWeVSVYzTwuXRu+sWlWjAJEhKPUiE5y7mo+gkTuEo841oTxcQZkHtF3ok6UYN46+
 PNNbktvK1ST+cNBJgNStspcI+SMCjgUBjMOGWdLRDMD6ccIU/ArJbx/fEc+PyqQpoV15E/8a
 6xH2+wjVRCO34GNPf+n6Giqnv2MSeAtHXWu41jDqFCy/zBrOGBC1zHdLgs+/HQ0cn3TPerH8
 pbA6gmc8MLHVGeZ7qh4DeOKqW6CUNuJPH96exLLG6mk4bsFrDAkND9XbL6GIfNeAxUKV8XRE
 FzEQTOGA==
X-IronPort-AV: E=Sophos;i="5.95,163,1661832000"; 
   d="scan'208";a="82086937"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DXLvo8vrmNqCO724IVSj87yqE3Ekmo7h4TsR5FbiHg7PuCiBpeHfmj1Z66Reeb+ryvI5enrhxWwA0s+vpuOSHUi2EZx8c4bSjnkkWic3jLhCxP/GZBxbKWwp+btjcibidKZkqeK8Zg+YDyfv6XHOGggziTjY9RgG+QRnTigU/gg6Q6yfh+ydA8+ibqWEXrCqVx6TnCmTWEJHdXdKXXs2CSlJTmyUKPGFvlidGrO2TkCejhYpZ3xabGzYGpxjf+6VzvYPW8niVZDl1yMRcg6ApKipJ2OMB17CD1uZqgoU+FKCkqLBagPu+AX1UlJc3E+Dacq+APAqLULbL5ubWuLjug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LvLprH3LWQGLyashJB9j68WE8Krzi6YlHNZiN93Xi6k=;
 b=kBdr23ipLDWCcb7MIdS6nssC9RVoaQHKV6/pzPQ66SVM3dLwXXBung4v8g8r5qdCup395HLG7xxBr2QIhVFDie7pV4SoPp9jlvT0rp7bbbRRXg/VIhyLgaxXI0W3PimlBuX4bAwUNCToY2XAZLXEf3fLDSCZxmFpvRjDji315KaeN8V1kc/OZ90h3PmKQFWgjVCEMMTx1vSh7JMpF+0EjisUzLWXjUYaI5HkCUDgaklXLHD+fcTv0iIhisY7akOvbH5MrehdHAtMCEX0NA/SBLjfTlZsJIQsjbfQaaVUtqeaPInudxu6m/Dcg81Zt3pm7iNxOVd9g+Up1LwBDkimKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LvLprH3LWQGLyashJB9j68WE8Krzi6YlHNZiN93Xi6k=;
 b=rpAGHZwkbCLN6Yo8xE7LFCVOYSuVjaesBUrYdP47BzkDy1MRjfOeB7CincjxBWvlBzy/eOILx9NTYQpczgciXwL3GxuBWVWV2USxQhXTj1aF7mJZMzMeDGngtdVv9l9RkxEkZgafdCQlNbKe/8+xLoKpWWozRqb3XKmrgm/z9fc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 6 Oct 2022 10:48:25 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Message-ID: <Yz6WWYn5uO4R3zNg@Air-de-Roger>
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
 <Yz1CPNwo1hiWZTw2@Air-de-Roger>
 <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
 <Yz2Q1C7Z2zolHAvK@Air-de-Roger>
 <544a7408-ea02-db17-39d7-82b7a1f56622@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <544a7408-ea02-db17-39d7-82b7a1f56622@suse.com>
X-ClientProxiedBy: LO6P123CA0019.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:313::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM8PR03MB6214:EE_
X-MS-Office365-Filtering-Correlation-Id: 4f73ac15-29e8-4c39-c86e-08daa7778a6d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q+k7oYsYeyY3MkodPYwWXWOk4aAzcirQuJSyjMeReqTcp+3tPNrTCiMOP1RLDLjU+RZEnhlCkGS56YKpGJQCwyJcd6jbtQFeJM4GZrOx9j4tgNaP96zCtR6PTA9JEIZPA9P2xIrCeAap5QghUvyuUPh/s5Z54w7my/7p5eBxfCMuZeGVDOzcBCGEXp6BFZrWycJm9C0zJB+ARrl+cV1kilvQO/h0D3SD9S/iWGiR9HD8fJIt0D+70LJ6CfhI3c/86yVmVxfmBUn5BJY4kC3g2ZnNQqcc2F472clmkqYAepDT3CkStNADsaVKaDStxEd3ctKyHypE6IecPAjH61jE5wEL7YNiVRAZrUx169lAKABMXYJMiXUbn4sRhDJorW9KIzFNogC1UbKZxAGAFyrfdC45EFfIuag2N6I76WmAHIjCSwWQELXoobbwCgCtMayAT7mWii3nCOJM7XJQGBV37ck1uaQnljEvuKMgK4N+La37uTGQxtKOk/j/+A0pNgL5W8F0SSUVbQM6gLimHwJv3rlTfTxmtX5bBI3CKh7vPQJZ2wsarMvJgmGn8PRAnzrmX7Hx1g8MFWEPZjOlf4S7iKfuACAxahTLHyMAeL8hEFXlE/GLNHryrHI0Mh4iVWpRV33+GDYWbKWoLKnXGMIh7r3mSJGtKOm7dgZ7ny8Gx2/epn32NaeU3ewFcDeVErZgmnPgpp2AeWjauG9y3V8TvA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(26005)(66899015)(85182001)(8676002)(4326008)(82960400001)(66556008)(38100700002)(66946007)(54906003)(6916009)(66476007)(316002)(86362001)(478600001)(6486002)(53546011)(6506007)(6512007)(6666004)(9686003)(41300700001)(8936002)(2906002)(83380400001)(33716001)(186003)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bWdDN2FBU0NZZUNoaFU2Y1F0SWdKUnM1MnAxVjBBaFp4Vjg4VEMyeGdWRXM0?=
 =?utf-8?B?RnFGTElJMjgvWXNyTCthZ2lNelJrSXhwcWl4Mk14RlI3N01ub2NzOE8wck5N?=
 =?utf-8?B?TjIrZy9ObWlERFdmOTk4ZTgvaS91amxyVjYyZkhlbzZNTWFWN0NKZ2s1ZERO?=
 =?utf-8?B?aC9oQXpFVk1kZ2dIY09FOXVWSVU5R25OcXRZTUtqbnJ2QUJYOFQ5Q2crMXA2?=
 =?utf-8?B?VFBDaUdTUEVIdGdJMkpqYmFtOHJyaVFENXdWZVp1bTZ1dndoUE4vWExTaTVP?=
 =?utf-8?B?MWhacXNJc1JWRHVIQlVWRS9Eb2NWTVBFbUlIUW5LMk9VY0xIaFZULzNldm5L?=
 =?utf-8?B?SWdEalNaT1JuMXRDalhZMTVzVlZYWGo2YUl6VmxtOXpYUGdzOENZMEJqaktO?=
 =?utf-8?B?cGhrVW9jT3UzQkhTTkhvODhYeDdVTXBPR0h0Y1RBZTZDd3lPb3cvTkxtaVJt?=
 =?utf-8?B?MEpPcmxWSStvU0xRMmh6aWMyUldENlJwK2ZDNndSY2RjODVydndzeUVyd1o2?=
 =?utf-8?B?MVRSa2tUTnExbXZUUFYxdDRDSG9JWGlqL1NlWGFPRzRiZzZqTFlGVWxmUk1W?=
 =?utf-8?B?QVE2aDZHeDZ5ZHdRb3JpdTk0Mmg0bzJOcHNYNXJ6RnBjUTMyQzFUTmFucUty?=
 =?utf-8?B?TkJPVllLNE5nOGlnS0VMa25MRUlmMklqZWlmd1dBb005ZTFhTk5QOVUwcU50?=
 =?utf-8?B?SjY1RkIwQk4vSHJIVnNrK2MrN0ViNEdFSHI2eFpwUldWQnNTdnhuUnd0bkJ0?=
 =?utf-8?B?UVNCY2JUNkMyMk94aHA4Q2lMRWcrSnBDV2VDUkFJQnB0VnVQVFNpNDRtUG1p?=
 =?utf-8?B?WXk3ZHJ2Y0Joem81cDFvR0tUZzZ1MkFSNDhaUEtIRU1UdDJtVk9zRFJST2pa?=
 =?utf-8?B?VkZrRmtFRWhOY2UwUEh2V21CS1AzZDY3akFldGY3bEd3YUZOVXJBRE9VanJm?=
 =?utf-8?B?V2tMeDRzTHFZdWFzQTc4ckxwN3dqWnhmS1poQnEwNytrUU5yQjh6RlZpRVFF?=
 =?utf-8?B?ZGk5Nk9lVmhrQngwTXpDQVhKb3FNU3lLWDN1amJ1YWd2a1R1WWFkWkF4V2FF?=
 =?utf-8?B?Zm9nVWdZbkN3cGFMM0h6VHlhSnBjakhHS2QvYW1PTmFDUzd5Z2xIZTFWSmd2?=
 =?utf-8?B?cDBXMzVUS3YwY2hrbDIwdGpucU5NMTJoOHZKQ3NVUnlLZHhwR09DZzhCNG1V?=
 =?utf-8?B?WEtoR2xHRDltNjZwWUNvNmlHS3JCSmg1Yk0xSHBVMTFlcGw4L3ZNNitYMlNt?=
 =?utf-8?B?Ry9wMzhoS0VnZndmTndiMUJzM2VtRm40VVRwOWJWeTJIczR3TEpPLzI0dVVh?=
 =?utf-8?B?S1cwZFg1RDliKzFuMUFWTkFLRDJMSzlMRXlOYnV0MnpQZ0MvbWZsaFp6bEE5?=
 =?utf-8?B?dVFtRmUxR1BaeUJHZUVZKy8wR1NRWC95L0Z1RXBqTWNsM3YvSTUvSTVrNEdI?=
 =?utf-8?B?YXYrUHgveFppYmFuUzhGSlBjVDdBUXorRko0VkdLWnpMZjlXTGw2Z0pIc1h3?=
 =?utf-8?B?TDZVMnJyMTI0UnF2NlV1d2dRb3A2Q3JzZlVuU0JXd1BKYmdoRlRla1dZRU4w?=
 =?utf-8?B?b3B6YUNNV1RvcXUrK1VVaDdWQ0hQaFNOQnNFelRrQUxMSVJBaXcyZi83WHdl?=
 =?utf-8?B?U0hoUU94ZjVHbXRHUy8weDRrNFBjeHRoa2FxLzVkL1QrWVpnMmV4UStUQ0R0?=
 =?utf-8?B?RFFsZE9kSnhGK3l2bnBLdFg5MzhMZUE5bkdZcmlHbHBKckN6Uk1yZ0U4MEZ6?=
 =?utf-8?B?ZlFWZWNmSnlTeTh3dURUd0g0VUphb2cwZ1RnMFF1R0hRQ3VOSDcvYW15d3NE?=
 =?utf-8?B?QjFoT0l0TkxYMEI2UDJUTmdJSDhNRUZwcHh0Rk8yM2ZBdHR5c01uNm01NC9O?=
 =?utf-8?B?TXVMNHZDanBvdnA0UndFekM0Z0lTZjFMWWcyUndFa1RaclRYeFM2dDZYMzdo?=
 =?utf-8?B?QnlRdEhadUtnNGJYOUhVTDFvbm5lZ3BQUjRLNkw2TmNxaUJLZFcvdTlZM0Va?=
 =?utf-8?B?OHhLa3J3dFowWVAxZ0NMemZQc3NEMDk2UjdiVzA0UktyMXhDUWFxSXU5VDN0?=
 =?utf-8?B?eWtPWHhmcXVydi9hZ3ZEdlRoTmE3cUN3R1NnZWhlakdPdzN5a0svZG9FUHZX?=
 =?utf-8?B?VEVCRFZ5SzNWRC9iNEpxTFhIQ2dhMkFBdkdUaHMyRE9xZ2F1bDhQelpvVldj?=
 =?utf-8?B?bnc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	tACSf5xxOAqQ9rbaNWzdc/Qt/RNXlzbw/FlujLxJSaatZi0t/RV2zP7Qpti9tQyqKpk2iE6+1J0P8irPadv2BHEytKyFSrgoKQP79fiPu3fO7ylB0wKbcXFIlC8bC3e+/cGqXKm6szMm6HRnNaHvtvrmxSV0B3R2929kvrGdetyX3C0Wjfj3eV8t5VdeVop36jDs5XjiRm5W5OSuSzIxeHYXb4PlzfGm6UhL2Ou8xktLU9pzi8JdHWvBsPLT3uGAbcgRZPynr4Dkb52cixfwzA4o8TRbi7bhBW7FG9rghq0PrmX07jNkktaX6vog0f/U4wHHTV8Li4pxo9L9kArHdqI0cOS3tDSZITTVDp1L7GI7GR5ljWIWwvIMay4OPJszEUWBkT8kIvRUaax5Artkx8hGeydTWwmjygH6UBK2B+J24TWeNBSpi66fwhjFwFLfymcpYzf1haKGEW2tI7cysByyOYV0xBTA9l+kV1m/R7CdKCDIvHSNUjVZROxizHBOoSad1iquxyZnLVil9CvxIGJcNW8WfxSfwpR3cj9XtuzMhIbzhPVXzhn+Irgd2yfCRm5pLbSJPiT2hE3yJG4d9LFmr3e1CXVrA0wfWdA61cBwMXKHeVft2mZir6Yxc/FluaLCbL0XqkVH/hyR5sER05/HC1EcToV3jr9c1njQasZ1tA5H1Gyir9bxiCrCETsUmoiis0Z1B3xJxw6JEwnt4QpVAYRKHYpe0f+GklFSCFOOpUlywuMChGSBW6MoIyNMv9w+kv2wCNKPLRYiexPVbJdQrczRZDr3dxY5+f9JnVLwyoXWBp/zpWeYkvNWAMtfDuiRLZDjLi4sOsGHAp/oYUDyj+YsjWJiR1k/IpD3FQPU0bQdDJ00LxtHEe9TLebBbAeU7CdkDBq/7u7R+nKY4hpGJ9HLxw7vx2mSRGXfBxE=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f73ac15-29e8-4c39-c86e-08daa7778a6d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:48:30.0505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XXZ5IwGetLbECp07syX9Yvze6ar2hbDK6XU1jJ1FEg2Q+kmttPA2aMsdtFVZIzpaK7inqFrf88KJw0KYRIP7QA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6214

On Wed, Oct 05, 2022 at 05:42:08PM +0200, Jan Beulich wrote:
> On 05.10.2022 16:12, Roger Pau Monné wrote:
> > Hm, I have the following diff attached below which is more limited,
> > and not so bad I think.  Initially I wanted to introduce an
> > efi_all_mapped() helper, but that would require exposing EFI_MEMORY_TYPE
> > which is quite intrusive.
> > 
> > Let me know if you think the proposal below is better and I will
> > formally send a patch with it.
> 
> Hmm, personally I like this slightly better for, as you say, its more
> limited effect. Objectively, however, I'm still unconvinced of making
> this an EFI special case. How would non-EFI firmware go about
> communicating that it is going to access a device at runtime (which,
> as said before, I consider a no-go in the first place)? Likely by
> putting its BAR range(s) in an E820_RESERVED region.

I've never encountered a non-EFI firmware that attempts to access the
BAR of a device so far (or at least none that caused problems with
Xen I should say), so I would worry about such use-case when we find
one.

> Plus the MMIO range covered on the system in question is pretty large.
> That way we're still allowing pretty wide an abuse by the firmware.
> Furthermore the MCFG range would also be covered by an
> EfiMemoryMappedIO descriptor (in fact that's the only use of the type
> I had been aware of so far). IOW the change specifically permits an
> overlap of a BAR with an MCFG range.

Additionally I could check if the device overlaps with any known MCFG
regions in pci_check_bar(), again not sure if that's more fine grained
than needed.

> 
> Who's the manufacturer of the system?

It's from Supermicro: "Supermicro X11DPU BIOS"

> Or put in different words - how
> likely is it that we could first gain understanding on their
> intentions with this region? You did say the system hangs hard without
> some kind of workaround, but that doesn't clarify to me in how far a
> use of the device by the firmware was actually involved there.

It's a black box to me, so I have no idea what the firmware attempts
to do.  It looks like that BAR is used to store some information
related to the boot sequence, the hang happened when trying to create
a new variable bootnum using efibootmgr (that's just a guess
really).

> Have you considered other routes towards dealing with the issue? One
> approach coming to mind would build on top of what you've been doing
> so far (either variant): Besides avoiding the turning off of memory
> decode, also invoke pci_ro_device(), thus protecting it from having
> its BARs relocated, and also preventing any driver in Dom0 to gain
> control of it, thus avoiding two parties competing for the device.

IMO using pci_ro_device() would be going too far here - it's not Xen
the entity using the device, so Xen doesn't really know whether
there's already some interface between the firmware and the OS driver
(or just OS) in order to signal that the device is being used by the
firmware.

> Relocating the BAR outside of the reserved region would be nice, but
> will likely not resolve the hang.

Not an option for Xen due to not having enough information about the
memory layout, and it's risky IMO anyway.

> In any event I'm still hoping to have a 3rd view on the situation as a
> whole, irrespective of specific ideas towards possible workarounds ...

Thanks for the detailed feedback.

Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:53:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:53:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416751.661420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMdK-0005KS-DS; Thu, 06 Oct 2022 08:53:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416751.661420; Thu, 06 Oct 2022 08:53:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMdK-0005KK-AS; Thu, 06 Oct 2022 08:53:34 +0000
Received: by outflank-mailman (input) for mailman id 416751;
 Thu, 06 Oct 2022 08:53:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xibJ=2H=citrix.com=prvs=271cd1fce=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ogMdJ-0005KE-Le
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:53:33 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a088bd5-4554-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 10:53:32 +0200 (CEST)
Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 06 Oct 2022 04:53:26 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6674.namprd03.prod.outlook.com (2603:10b6:a03:396::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 6 Oct
 2022 08:53:24 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 08:53:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a088bd5-4554-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665046412;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=w6yUruDbyoiQqSyi+h15/Gk2uluMuL54i0fQXnQNrzo=;
  b=VEZgYppLV/A26mJs2Vnecf3EnDszxcRx+/yVG6CP1mmJ3+Kx9KoaHkh5
   AvEbdvgDCh2WeVu+m5HC9SStMk5GKGb2b3ttNILTqtNtghsT5ppsy13O3
   cuPDVNalD1IRGWwNY20faLN69uAd1rVxLkoA4wsil35CYCjHYWo9HFzh7
   E=;
X-IronPort-RemoteIP: 104.47.57.172
X-IronPort-MID: 81218519
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:UgR9Yqg7AmLZxBudx/1YhqiXX1619REKZh0ujC45NGQN5FlHY01je
 htvDzqFaKmLY2Pze9p1bNyxoE1X78OAyodhHVE/+HtjQngb9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmPa4T5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVlE5
 d8ndGgrUhC41svunoipFLJRlMt2eaEHPKtH0p1h5RfwKK9/BLzmHeDN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVlVMruFTuGIO9ltiiX8Jak1zev
 mvb12/4HgsbJJqUzj/tHneE1raVxHOmAdN6+LuQ6KVVmF+V7FMvBzYZRUeU+tyLhk+YRIcKQ
 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3
 UPPmMnmbRRwtJWFRHTb8a2bxRuwJCwUIGkqdSICCwwf7LHLu5ovhxjCStJiFq+djdDvHzz0h
 TeQo0AWmbIXisIa0rShylrOiTmsu5vhQxY840PcWWfNxgl0fpK/boqkr13S9+9dLZ2xR0OE+
 nMDnqC2zO0IF4DLqyWLT80EBrTv7PGAWAAwmnZqFpglsjiopXiqeNkJ5CkkfRgzdMEZZTXuf
 Unf/xtL44NeN2eraqkxZJ+tD8Mtzu7rEtGNuu3oU+eiq6NZLGevlByCr2bJt4wxuCDASZ0CB
 Ko=
IronPort-HdrOrdr: A9a23:wv4qH6zD6gVbSpGuYeBKKrPxTOgkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U
 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu
 vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirCWekD+y77b+Mh6AmjMTSSlGz7sO+X
 XM11WR3NToj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhn8lwqyY4xlerua+BQ4uvum5loGmM
 TF5z0gI8NwwXXMeXzdm2qn5yDQlBIVr1Pyw16RhnXu5eT/WTIBEsJEwaZUaAHQ5UYMtMx1lP
 sj5RPQi7NnSTf72Ajt7dnBUB9n0mKyvHoZiOYWy1hSS5EXZrN9pZEWuGlVDJADNiTn751PKp
 gmMOjsoNJtNX+KZXHQuWdihPSqQ3QIBx+DBnMPv8SEugIm6UxR/g89/ogyj30A/JUyR91v/O
 LfKJllk7lIU4s/cb99LP1pe7r4NkX9BTb3dE6CK1XuE68Kf1jXrYTs3bkz7Oa2PLQV0ZoJno
 jbWl8wjx98R6vXM7zP4HR3yGGPfI3kNg6diP22pqIJ9oEUfYCbcBFqEzsV4o6dS/Z2OLyoZx
 /8AuMTPxbZFxqfJW945XyBZ3BsEwhubCQ0gKdOZ7vcmLO9FqTa8srmTd30GJ3BVR4ZZ0KXOA
 pxYNG0HrQM0nyW
X-IronPort-AV: E=Sophos;i="5.95,163,1661832000"; 
   d="scan'208";a="81218519"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cJ5XF0+kJNe1/HCBJFelN2tF8BjZgPOZocybNYD3AyV2L5FaN87/ADj8uEUHXV9UTUG8CDUtGDDGrP8e28we6QCZu1GkXF/6NHsI5C1igfBgYI5pE7+zC0ikoDJqYsE7ABYRA3waqcZDK044XuBxgssWNX4LC8zzCp98KVeIRMEhVU9mz7PoZtaskfYRu3k6W1hu7kyyQhr5rtqHPW3ePbsE14Io6z+wKy46Rgk8d7QXAiqBPd/kCtRN1NzSclBYNhxas7nB9kvwHtxFye6lw03OM/0iAGIMKbxg99pOLjYdeP9H4WdoYGp3/tS+NkE976kaBJ4aLrynMVIibMoNCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fCEX1HvU2Ga04RZAVyxcK1anltVFxueHrwIcEl/AZOw=;
 b=Rde8T69qpyEo0v5jRlxFalnY/I6A7LNY1667xrlIWQEUNmbarC/sVJTDPgDUihOHjFr9fbStavUWJ1/lS9uCM0vhmtAvr9I7rjefr8TUNpjxunv7nsC/YYeBYcF5FgHTw2eAf/f5SeWdcDoTeNV8PMm1zfv7w5LiN8aak+tPb56rZj3ycSzx3sm8MPzOcTR2AJJzM5w+79814eErKPivRyLZwDfOpTjz8WQ545M+p7eXLG2ACZoQDDXBazlNQ9zKc10tG8MK18+M061wbGyKptxo0cQUOmRWUhHE2qPjzQyvkHSjQQR2zWYD30SHqiqv2CKdtP25qZa8JHrW9QK6KA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fCEX1HvU2Ga04RZAVyxcK1anltVFxueHrwIcEl/AZOw=;
 b=xI3SsdCFkbQ+PFzxP506nDvVNCz7yRhd91K8TNwYov3iqZIEUsB4qA+SCgV70707Eb76O/GWO6M0Avpx+oHoCH304zvp4AAJloQnnymb9LtQWAIsoRrCdzDaFhRYrE9FtkRngv82KsqjIEtc/teZD2JF3Dh+UwoUuO27ITBrTOA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 6 Oct 2022 10:53:21 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH v2][4.17] EFI: don't convert memory marked for runtime
 use to ordinary RAM
Message-ID: <Yz6XgVMd/a/XU7jr@Air-de-Roger>
References: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
X-ClientProxiedBy: BN0PR04CA0061.namprd04.prod.outlook.com
 (2603:10b6:408:ea::6) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6674:EE_
X-MS-Office365-Filtering-Correlation-Id: b9f47a92-a89d-48fd-8ab8-08daa7783a57
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eobTxmIZYhMxySdBLkf/PLY6Plle4AbX0ARjP99V37tgoHAFDGQZrCsLZ9aayKHfjYuTJ2X1rkq/0p3KnEu/bveB2zWdNRRuZdEzDOR5L6Y722iDmyNJ7LwU9CEH0ck67COXRIFdTuqoKnlZ057lgsAtulrA29ZgniuGGZBpTjLyn2UfDYSlgyV4oqBubeJ/o9cAXWRW+Tz5CaEin7m70lOdUPodRSsizLNoZIZKxNJXP+Ocs+rQarrzESLzCVZwVQdYrlwxEx1UGgjfj3M1bObF8Adqq6RwIsPp1K8tuR27X0FA1vEO1u31x8OR09d6dWqthfXo6lMPJygTedqfXoecgtrQRBRoHJYXmFLwlgK+hcc+koYEVcsn11R7KPJCyytDteAxZHxIWcuT7sBr5d+LvHNCzR913pSIx7UkmXfRUi/vFWPLXRbEU+FpFa8UODPqd2srHEAO4x7H9pJU5JxUZzy8k69w5u1qcotXMYXqjQA+JKq/hVMLDwLawAVCt+uzdZ5bD6SGOPPu10Qt+42HkjaIUcdz8FWlJBNTNIqgl+zTMau8BwuJ3k+dQZji3RcNqE++Go9viVyRCyfwnmyk1aDNcwapHkmcxA6+2+I7o7o7HKf1NauXC2I3xIzQo7bH1j9x7wUU1haz7FJQ1XJxT9Z7ySEK5digXGVmNImhezs2beDduwvHM9/Cdk00xKhe8a4/Puv/5PfXeYDnTw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199015)(4326008)(41300700001)(85182001)(478600001)(8676002)(66476007)(2906002)(66556008)(66946007)(316002)(6916009)(6486002)(38100700002)(83380400001)(86362001)(82960400001)(54906003)(26005)(6512007)(9686003)(33716001)(6666004)(6506007)(186003)(5660300002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dXdUZWZZME85QjY3N3FZSzd0ZjBUZWtmbWh2ZnY2RDBWTjNxUUdOeVY3QjBq?=
 =?utf-8?B?eXhTMGplZFN3S3ZuTjNaeXpYVy9RbFZPU1BtNnczNVBKRzFmTHdwbG5GNXpG?=
 =?utf-8?B?T2ZCdlhyYW9tOW9JYXZYOHhNU29RRFBsNmNzeTlUSFR3ZVlvaXhIQlI2NzRU?=
 =?utf-8?B?ZGZMZHp4NGowNnEzWHhDMmxQMmRxMlh6TUpyb3ppbVB5YU5TY1NUS1pFbkY2?=
 =?utf-8?B?OHo5MWNUNkRENHF0ejREYnpMaW05UGFYWFVqZVltb1hMUXFGTVJqNWtSVFBG?=
 =?utf-8?B?VkpsdmpCTnE5L3RqMVhhcEdpMElpVG1UYkV3dzBzR1JIS2w4K3hLRzRKQW5Y?=
 =?utf-8?B?ZW1mdUtvTUxCcE9UV0xWVU1Jc3JuNkxsZ0dBckdiRkM2UUNpWDlEamNOQUxZ?=
 =?utf-8?B?ejFxNkptM2NpV2ZGNEl5MkZQMlhDWExqLzBleUhpcWl0cTVQVUgvRDYwOFV1?=
 =?utf-8?B?UTVPbWFZRTk0OHRBbWNQeFR5QlhJT3REQUpNYWlWM2VXL0JPSm4rZ21adTBL?=
 =?utf-8?B?QjFRejVxM2FENDd4cEJPWWdNT2tkRUU0RGl5alpCV2g5ditqV1FrT0lIaE8r?=
 =?utf-8?B?TlpEZXNCKzMrTFA4SW93c0IvOTVTVWRQVStCVnRsTzNUbjdUaDd3aVRuMmdw?=
 =?utf-8?B?YlFoeWwrc2tRK1laOC9sY3VlN2tEbnFJOW14TkExUEdWY3grUkJhTVZWUTNV?=
 =?utf-8?B?ekU5RHo2SXJrWEgxQm95Mk0yRWxnNVBEQmJEMGZKVnZwdkZhbUNhMDRPSXFY?=
 =?utf-8?B?clNHbmdlRUg0c1VmellKL2p3bDFLejJURVVQeUF5VzQwU2VEQi9pdkMvME1w?=
 =?utf-8?B?ZFNQSzl1THZXVlhBQ2ZpTXZMSVJXdWNhYVRhNjlsYkVtWGhKcW9tT0l6dVp1?=
 =?utf-8?B?TTFQdzE3Q0RGOUh1LzVnaTNGcWsxYnNWeVhWSXBGMzV5bklaaHlma1pTdnFq?=
 =?utf-8?B?TVdwOUtCYjBlVkc0bmZkeXhXclJtSlJMUUFYaXZpVGQxc1ZjUitGdVVFRFlW?=
 =?utf-8?B?QmluKzhldkE2dWdtc2RaZTlBQ0x5Tmp6M1Fsbm5wUUhqNE5hSVlLbzl0UnZn?=
 =?utf-8?B?V0FjckpBcHl6MXNuQ2ZqRXQ5a1ZIODZLVGVjOGlNMXIwRGJ2ZW1PazcrTWQ0?=
 =?utf-8?B?QUdiN2tDbndKWTBGOGxzNm43UDhKSVA1SEJYNzlHOFc5YjFQN1V1cy9jYXJr?=
 =?utf-8?B?VjBaUllQcXFha2Y1bUhvVUxtMkhZTUxPR2hGNWlHeERXWENKcDBqd1BXTXMv?=
 =?utf-8?B?WlluUGR6MWRaRjhpM1l3TlltcEJWL1d3SnlJWmtWZmxVOVBrbEtsZDMrOUJQ?=
 =?utf-8?B?cXhSM3BuU1hzUkZFdEpUODhtTWw4a1BlU096MDhrRkdSQzh6cjR1NkJucXZt?=
 =?utf-8?B?QzYwb1cvbnR2RWFsM2ZicFZKK2pKVlg4ZGdYNjQ1OG54TVVhWWJDam42d1Uw?=
 =?utf-8?B?VkdLakhPUnNIemlkU0F2bGM0ZHVIRUQ4TS9tSXhkazZQVmY2UEVyNkVwWG94?=
 =?utf-8?B?VjlVL3hSclliM1hPRW8zNUwrdEUyYlFyeEhBV1VMWFQ1Z1dqdERUV3JOeFFi?=
 =?utf-8?B?SGE2L3JML0FVWFVoZzhPUlVJMmk1VVhoaUU2TFU5RnVNOGxuSGRWOUpHQnpp?=
 =?utf-8?B?L2kvMWwxRjRVajRQR21OVUQzQis0dTZxRzFodDRiNGhDN1FiQURpUlVxS0dm?=
 =?utf-8?B?ZDhMN1R1ODkrcXVvWm5QOWxhZ3JJRlB6RlhscXJGY25wZGFETlo5MHk2NzhR?=
 =?utf-8?B?Y3lEbHM3dWcxVlU1YitaZitZZk5RUldaZnhyOXkrb3NQS3lIZUlNcy9ZVk51?=
 =?utf-8?B?TGlZd1RKK3NOS0RPUUlEa3JtOUJZQzVvckVPMDNMWkVIVVhkNjNUUW9VWjA3?=
 =?utf-8?B?S0drUTFNejl5UFRyaEZUbDVFZU10M0Raa20vU1hqS0RlQ3FmMENCNGJJQWJH?=
 =?utf-8?B?Y2U1KzBmNkJVVUgxUlp0UkdYcHAvakI4TzRCL3RxRlJaWW4yeDFkQVMyb0Zs?=
 =?utf-8?B?dDQ2Nys3Z3JlUE4zc0hGSlpicU9Td0Qzd3pUNHRIZm1jcmYzcTk0dk9WUHFq?=
 =?utf-8?B?d0RLU0d0VnYwVisvc2dCUXZYcTZKaGlKSXNLUVo0cGFvbWVUNytOZmhaYU9a?=
 =?utf-8?B?eEVjOUo1RVlEM25uZGE0cFBzdjZzQ3JNZlRTTC95RDZ0TmFXSDh0WTRQU29v?=
 =?utf-8?B?eFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?UW9WaXlrN09XdGpJdEZqOWt1Mk54bW1waCt1K0l0c3VPREhLYyt4RHIvMUhI?=
 =?utf-8?B?TndyZFdwNkFPYkhVQkpIL3RVQkhNV0c2NHNBQlNXQW9UeHhERE9uZ3FCeThI?=
 =?utf-8?B?U08yQ1Z1TlRqRkVzZFl6dmhCeUc3SGd3SS9XVk1PWlRjRGV4bEVaeVlPZzQz?=
 =?utf-8?B?WEUrQ0pOck9TcUwzNVVKd1phMTRNOW94MFVVaU42UDZDb0w4TEE3cW1RTk56?=
 =?utf-8?B?aVgvaDgzdjVWZGVZbU9mUWNUeUg5WWFPcTlEeUJLK1IvN1BDRkFVSzU1Y2tG?=
 =?utf-8?B?d3k4aWpmUGxHb1lMWU5HMk1rTUc3VnExNVpkSmpTNHFaY1ZuTzBlcG4reFRs?=
 =?utf-8?B?U2hyZUdHajB6Z256N2ZFaGdocjBGUXBnaXU5dGlqQTI0ZzdNaDFPbU1HNlBv?=
 =?utf-8?B?RitXWlBleHdFQVphbHA3Y0Zlalg1QldUZktKb0ZURzdMMnhiejlxMkRCRWV2?=
 =?utf-8?B?aUxEcHlhcmRNVFFqSURWQjN0ejJjbW1yS3BiZkVpTzRXUDdiQmg3OVQxV3VU?=
 =?utf-8?B?d2NQQzVHRDlsckdtMHlmRS9ZS1V5WEVRRXFhY1Y3SFQyM2pvNDdMSXpWZXBy?=
 =?utf-8?B?WEpMR1E2ZDF2emRoUkdmSDlOZFBqa2dVaVFBYUU5eXBYcEZSalp4TG00TTlQ?=
 =?utf-8?B?bUNrOURsL2xCMUhRcmVnbnR1TFhBOGUzV3psenlPcllyS2Y4THBhVnhhSHlX?=
 =?utf-8?B?ejZoRmtVNUZWZEtBbWFSTEFlR00zYlo5MDRORVEwYXMxayt1WUNkdlZER1hT?=
 =?utf-8?B?NUpOUGRZNTdmNGpqZnB2U0hqcDZuTkVnQUY0K2FXV2s2cFZHL1BXR3VVWnFC?=
 =?utf-8?B?U3lGTlpmWXVXTkVIWWJZMS9tR3NiY2liZ1RLbEpmK2VJSTFtK2xVSlpNSk4v?=
 =?utf-8?B?KzlmVGdTMlVPY3pMSlFxOFErMFVNdU9OelV4SnBrVzhiT2NKSGsxdDJNMTVH?=
 =?utf-8?B?K1Q2WlV2NHRBcVZnSjJtOGpUMW1mbUhzcVJNRnNWNXJBMFFPRHp6ZU9YbWps?=
 =?utf-8?B?c2dHMHE2dHE0WGQyQTk5MGcrUG1OR0I4SUxCZFVQdFVQbGwxWWxPcHM2L2J1?=
 =?utf-8?B?dlpzUXNWdFhHZ0h0YkVjK2dIS1AraU5OZ2tmdmlEYnpYd0Y3dTdSSXEzVVZy?=
 =?utf-8?B?c3ZlSlpXZThQMVRaeEpIeXMxL29wbGZ5L3JRck0rZzB1QUFSYTdKeHQ5NGlM?=
 =?utf-8?B?aWk2ZXNQVTVuTUl5SVVYcXFSZG1OZjFpcmo1ai9JMnh5WFdreXp2VkhwQ1Uy?=
 =?utf-8?Q?Xt45sgh7csJnRSj?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f47a92-a89d-48fd-8ab8-08daa7783a57
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:53:24.6371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wg1L9fCgz+tHKIPTgnBn2Ls9+5qzVk98LohliR4132rTuU0KeVn5F/ZGXQ5oamhepbQ5dg5ZY3CZ0dK/hOigIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6674

On Thu, Oct 06, 2022 at 10:40:56AM +0200, Jan Beulich wrote:
> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> higher priority than the type of the range. To avoid accessing memory at
> runtime which was re-used for other purposes, make
> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
> to do so, bypassing Xen's memory management), hence that type's handling

Strictly speaking I don't think dom0 needs to bypass Xen's memory
management, just overwriting the page would be bad enough for runtime
services to not work correctly I would think.

> can be left alone.
> 
> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
> Fixes: facac0af87ef ("x86-64: EFI runtime code")
> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> # Arm
> Tested-By: Luca Fancellu <luca.fancellu@arm.com> # Arm
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 08:58:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 08:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416761.661433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMiR-000602-1J; Thu, 06 Oct 2022 08:58:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416761.661433; Thu, 06 Oct 2022 08:58:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMiQ-0005zv-Ut; Thu, 06 Oct 2022 08:58:50 +0000
Received: by outflank-mailman (input) for mailman id 416761;
 Thu, 06 Oct 2022 08:58:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogMiP-0005zp-Fb
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 08:58:49 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1732ac96-4555-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 10:58:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB9100.eurprd04.prod.outlook.com (2603:10a6:10:2f3::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 6 Oct
 2022 08:58:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 08:58:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1732ac96-4555-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WBhTYfzdGLKL9kdBx6PRRrEBQTzxwkRgNb3jUFI9e2hA6xeGoSSObBEVGxfvD05g7YSh2UsNlTkePIqHddn51q/9JeBTqB4P7agA1Mg8q9xY0bSUdGhjhyj7D2/0C3kTD0uXr3qNP7Oqf/MAir29Ky5u7XeCAyvnGnVLDXrfwetMPsmLcpBOekMxXOhTh2FX6wrSKjqvOpv9jeT5JOFxcOmkRQ4dF6oIOAnvKVQmXcKhMQZKbrjLGnhJ68YAPfeFZ5h/jonssdYAF5giTmtwfqi4Bg335WSq+rpc6qdepb64bp73unGeYPbrcoI+u/dnetUCZCkMBqYn46GEXHWF6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+g9Z81TrUgStBViTUU7+fdK5QF94vDa5G8ADkRzwww0=;
 b=AhUZyi1zOGC7Llu0uH+3Poz+tbEhAjpK/+vwLv7soqEJAZVYaawnkdVTcsWernN55ig/4gSmxfq0iO1DL/lDttI9ipY9niedCCXqIChbp5YQjjZmFShzeDbnDLA6aNlRCpZk0jrANHzID3WNsdaguRvf1qG/qc6rCKv1Nh4uOQEp2bJnPvFVfJiok6wNa2GRUdYwYgK8mC9jEW65cu+t5ExSsm10KXa47sUnpnyv5iCm2SSeaW7L8kQTr8tU5hbI7SJneYBlNINrIE04na8ZzvtXPISScyAq8NUUONbC51/1whQWzR04M4BmlJ+if9ENpvgA7EUKTgprttSs+409Sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+g9Z81TrUgStBViTUU7+fdK5QF94vDa5G8ADkRzwww0=;
 b=KB3F7G4xbQyJjBBBU9rWJ+AuWgWWIrQX7kg5lejs02jITmTuluNXyAwdJFP4CRkHQh7GKIiAtZl7vRujS5miAqlfjJOcE/pGAZRx8MpuwoOABd3zLyGOjWX+fOShkT0iL/zOmm1mYVxaKfPe0h3GunERlcXtmXOSYGicb0jD1k/x9JQ5ZuAFbs63aB7oz2hNTQrlanQrqFq9RpVnnBYDcUXxwymp+MR5d8s+JqdRcpa+alMCrv9hHTtahB6zsxM6swI5LeKlmZvGCe4kzTIlznURfj9LO+gHQOeFC76wJeG8W9z/SX1njCJCBh2MkUNxUoYZWkSd8YJkF/I/zacrFw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <187834a6-6fcb-6e84-1247-ed7f4e23d417@suse.com>
Date: Thu, 6 Oct 2022 10:58:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
 <Yz6XgVMd/a/XU7jr@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yz6XgVMd/a/XU7jr@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0082.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9100:EE_
X-MS-Office365-Filtering-Correlation-Id: ffd1eeeb-0e64-48f1-235f-08daa778f98d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6c1Rx1k9citkD9y6WKo6w6njt2WHLkfJxOpnJ0F8kZPJyk5oykvpRsaqwjWkyKAuFn6B2nEa481BARYvrQ58YvcbE8tBQtq4GrD631DAoi8F5Fql1p0a/TggmePc2GoCMdDVTISA6LKseUtUmfiKhQA3N+OYEBxO2aLOjaqDOY4zYXQqB3N5nyDFuHce29aNFFgpVhjNb80wAHw54GSxZir8u/607xEYM1YJsO7DJu/mYt2hFNVjR9/64m14syWGfDqErRK/0nnkQ69YIFGKn60OlyXv1UNwVQdBvPUnHkeg4YUX+R3wWxLG9DbohogoUI+Wk06Z0rGepgUdoDCPuu8rr5KdL4xCi++ht7eL9wPBemWO6Zz4tuYSx0dR71D9SDqd6jBarzLJGL7PUQdySv86b6gUbp5dt8yj/JD+JT5UAQqJ+ubbsVu9ZHB/6OLdBsq/qPl8fsQVTxhZUmRIOEXDo0l4Ze4NQKKc/kPuIqn8mjoJ990aROJDwnu7X9mxN6N2Vx9OWwWLWakcB5Io8u57Ly824MtEDZIoJvhoxrLTeBXKf+wrBXY0amxtXD9bWPnKVLo3d8zDARwKuy3gW6Mnymvh2Xly4DaTp5Bnartcspr5Y2kE7RecKCnQa9T3ReXlgHA6ZLvzwQ0PEOvU09dCP1zNeDVCh5fvayRR0ETgFD5VurG2enkJMvGkwB26sJXRQ8iQjWltQUpSgw9yNheG/InxfmdalOg0CetpihGXUo9YEBOY1I6/f/6F8tOdd344pkuk2dM72IzXPCjR6OvQezmBNNDJVGLGnL9trK4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199015)(6486002)(478600001)(2616005)(6916009)(8936002)(186003)(2906002)(5660300002)(4326008)(54906003)(26005)(66556008)(8676002)(66946007)(53546011)(316002)(6506007)(36756003)(6512007)(66476007)(31696002)(31686004)(83380400001)(38100700002)(86362001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cm5kbnoxdUNQYjJGVzZLRFZLWm56eXFMaHdIR1JOcDZCQ1ErZ0x2d09ML1hU?=
 =?utf-8?B?cHp5bnNKMk1uOTc1TWNyRHB2M3AxN2VHanhWRk1xSVRRcDBuNXNFT3drdnBr?=
 =?utf-8?B?N0hjV0VPa2NJdHFTU2JEOTR3NUpGYnhKZ2V3bUM4SVlVdnBrYiswVTVYaGpB?=
 =?utf-8?B?WXY1emdSc24ybU10eGRYR1NEc0hJMmdkTWRPdlJ3SnpZbEtBOHBkSmJqVGVD?=
 =?utf-8?B?VlVuWVRDdkU0M3E0SXFLM0FiQXJOWnRySHJMSXFmMjJNMzRrRi9GWTlMcUhm?=
 =?utf-8?B?Q2ovUTlsMnFFbkE5U2VML0srYUxESzJsbWh2TTdMWjJ1eGlVek0xL3VqKy9a?=
 =?utf-8?B?dlh1aEpHbTB2a0JzMnJaUlVQdFlNOUdFNkZXV0RZcFF6UXBxd0R5V0VhTnp5?=
 =?utf-8?B?WXZxVEZWUkNudWtsckVNcklIUVZIL1lPYzdpelBCR090dEttcjhPRHgzRSto?=
 =?utf-8?B?Vlk2eFpSVk8rVVhobFBWaElSa3BrTlErVjBPNjFKUERabGI1YUZkOGVoRk1G?=
 =?utf-8?B?dUdNb3JwT0VJZ2QzaUFPajhzUStkYVRoNnE3K1BpdHcrNzI4Tkc4L3ZlMXlh?=
 =?utf-8?B?WEc2VWhPelNJYW5idE5Oam1MYUtxY3A5MGk4Y0hFWWw2YUx4WkZGc3JrMGhv?=
 =?utf-8?B?TEJNNExDaE5SNUEzVDEzV1RIT0RDd3Q4TU8xU2lNKy9odlFkUVJsMjlQU29k?=
 =?utf-8?B?TWl3WEdBbGtYcGozcnNHQ3ZRMURYVVJCTnJUcEFtVHU5Wmd6UCsvN2hieXMy?=
 =?utf-8?B?UTZCRC9TcmwzWDVuakJXTWt3Nklzb0dUN3l3WENQaHNDRW1yQm1FdWpWVUp3?=
 =?utf-8?B?WUhRTnRkc1JrN1UveCtXakVSU3dBaGJXaTFhQ08wYTRSa1Q0d0dMYXE1ZWRr?=
 =?utf-8?B?Ly9wR1Rhd1NNemg4N3AwWVRRYU5hQmxzdnhIcEJ1RjVCY2Y3TStqc1JCc2pW?=
 =?utf-8?B?bzhqYjBCdTQ2eXRpNytFNXFQYlp2dm0xY1VncDA4MTc4bU8xRUxnNi9neitW?=
 =?utf-8?B?OEptenRhKzZhMURENno1RWw2Tk5BeEhrb2huczFNbnhDKzFJTlRCUHMwOVVo?=
 =?utf-8?B?MENLS1BiM3dXMjJlWmsvbGdTalFickJlQlZVL0RKQnVpa2toOWJJbW9Lcmps?=
 =?utf-8?B?VVZyK0JtVU9CdngxTDRMdEc3Sld0aFlTbHhqWU1weWZ1U3BUcE54dGNyR3Q1?=
 =?utf-8?B?MVZZOGkxTitYNnhHUzMyWDZ3RVdvZ1FIWWwvZnBqUlFSRDBxZFBCV0YxNmdw?=
 =?utf-8?B?UEg5cGtFUE1ZMC9MZ2lZc3R3QmJ2OGdQS3JhV25GcVVtaDJFNTdUQTBDREFW?=
 =?utf-8?B?WDl1ejhvYi9nYW5XRWFuKzFFaG0vWFA2aGU5bFRrdkI2N0hMVnBqYVIzT2hp?=
 =?utf-8?B?TUdoMnhUdHBrbE0yN3JOaU1jeWhaT0RPVFVMdWNkN3hkbkJaM1Q1eFB1VlRE?=
 =?utf-8?B?L1JITnU5dnNIR0Rtaks5bTlzTG5LRjZtSW1mQjRUZDZxeWRuQXMxcDV0N1JS?=
 =?utf-8?B?M0lhSkRGckhUSFFFdHh6ZVh0SUdUeUplNHQwbWZWZ1hqNGZlVVR4M2hsVkd6?=
 =?utf-8?B?TGloalVBUzFrTnpiR2dBa1NnYlVIVVlhQ2JkV0p5QThrT3A4MFhUY0MwOGNF?=
 =?utf-8?B?R3BMUVFjdllnckFoVFF5L2oxYkw2Y2hCWnRTVFZzRlkzZVRGNGpUclRyYjd1?=
 =?utf-8?B?TUVzekdMcWZCekhtTytaVlhNSkd0bitxTFl2VjMvRHVhWnFzd3hyZlJsNjBD?=
 =?utf-8?B?ZWtCb0wwbUFFOTBmeHhZODlIdTV0MUJsVy9hYmtJNmJYcGNBRmhhVUdiOWlN?=
 =?utf-8?B?Y2t6UlRLbVhqQkFzM0RRR2U1WXd6UnZxQzgyd0lsbzVzcWF6WXk5VDQ5M3RC?=
 =?utf-8?B?NFBwcURiemR4UWpZRm5wSEpHbzVrUkx1Q1ovQ2psdVpJell0YityZndDRWNP?=
 =?utf-8?B?S3RVUVhLVXhlQ0pheEhjbFhia3VlbVl2dlZadmhIMlN1eHRsM1hZMUg2Tkw0?=
 =?utf-8?B?UkkvWDNpN2xGWkdBZllOdHppbnI4WW9Mc1lGZzJBdHFHWDd2azhHMHpvTHZo?=
 =?utf-8?B?Zy95bFJzWEZjRVNEcDBLUFBKV3hqdWFHVjgwWDVrVnN1bDA1MnlXcnBxajFU?=
 =?utf-8?Q?7To2b6hAZsma1iE9MI88W94fD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffd1eeeb-0e64-48f1-235f-08daa778f98d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:58:45.2286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 20ytIvYTnFg4qjHhRX4eSyGp/e5G2D4bsPMqn0H6QAvdUWMNy2nZWPSBtFCA11mXIPeet/GxUmNZpD++tnMJlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9100

On 06.10.2022 10:53, Roger Pau Monné wrote:
> On Thu, Oct 06, 2022 at 10:40:56AM +0200, Jan Beulich wrote:
>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>> higher priority than the type of the range. To avoid accessing memory at
>> runtime which was re-used for other purposes, make
>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
>> to do so, bypassing Xen's memory management), hence that type's handling
> 
> Strictly speaking I don't think dom0 needs to bypass Xen's memory
> management, just overwriting the page would be bad enough for runtime
> services to not work correctly I would think.

Then how about:

"While on x86 in theory the same would apply to EfiACPIReclaimMemory, we don't
 actually "reclaim" or clobber E820_ACPI memory there (and it would be a bug if
 the Dom0 kernel tried to reclaim the range, bypassing Xen's memory management,
 plus it would be at least bogus if it clobbered that space), hence that type's
 handling can be left alone."

I didn't think the clobbering aspect needed pointing out, as the same applies
to all other memory which Dom0 is able to access beyond its actual allocation.

>> can be left alone.
>>
>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> # Arm
>> Tested-By: Luca Fancellu <luca.fancellu@arm.com> # Arm
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 09:02:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 09:02:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416767.661444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMm6-0007QK-IE; Thu, 06 Oct 2022 09:02:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416767.661444; Thu, 06 Oct 2022 09:02:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogMm6-0007QD-FT; Thu, 06 Oct 2022 09:02:38 +0000
Received: by outflank-mailman (input) for mailman id 416767;
 Thu, 06 Oct 2022 09:02:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogMm4-0007Q0-Sl
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 09:02:36 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ea1cffc-4555-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 11:02:35 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7839.eurprd04.prod.outlook.com (2603:10a6:102:c9::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct
 2022 09:02:34 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 09:02:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ea1cffc-4555-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fqSJ8cB8zT1aw4SOJkZEXjJLOruDn6bOZcKf3YPoIT2Y45K3AxRqrLeNsmRkGlvUSItwTYTY+YDwJBD3nlZX9Y9mH/Sxx9+8Mg/GqCv+RuToHSXScoQpiANOIDnUZkO8ifc25PMvgL8pO88OJ4Ncy+brr/7Dlc8AkV9eaXBtTgesiPkG//7gDIEpgO1vGFt4qQ40uFw1y9W29/DBRmObVZ3NbgCGdvooQ1sFL5PUkWPb5HjLSBVJAdpUMv5fnTyC0bN/phhlh95urT3VPKvwxSmPMCkyPpiZ35BhA6Qaq8KcU5e/ANAn6lGfgqW4VNbM6I1cFJ4yUAuW5OJNl1olDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1N/oetchr9EAiJHbhtg/0EHZ25bitIjIo2cbe/JMQBk=;
 b=RbxLCbqxrpWmiysM2tfKFN6nr8auPhzJco+wMQ2qDktsG/H7ouCIYJBxdfqfeOXTxN4gtFQxUflf8E9EFWTauLtKHaTxuRcyi+kTuZObdKJv1+k5Hx0VV6LfEI9igsEsOacw84juicwFfeDVbkbf0ZVmDnZdV8xATk2lvb9o6jKf1eC8GRePeTqsHE6tomZJT2hKhJh6HX5ivUl1Xt0PiHdcgCrg3he4krWvzwsWqCT2SND8Xhuv05MQcBA8brRnmw8Ckua1SFgwe1hNVQ6q8MjPqM5pAZ0PV1Mkj/djpbz4lRPu5ni94BosI5rjCokyHUoFdGwg4kHfqlrRoedYxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1N/oetchr9EAiJHbhtg/0EHZ25bitIjIo2cbe/JMQBk=;
 b=pV3HN6st8VUdAnOHiU+VTs4HeZXjnIGRNPBIBFLaR8fNn3+EA7lMp/x1HiYq5Sd7aZWS5kDeRf3mNUAmeecLH6yXwLLh7d9rGr2aZgzSai8qGTSsVvz0YUTuhXgEJGTg0w3G2Lm2pHTKhyuB/d9OQ3tl6bTpMNvvv2TpeCrAB+N/3RGNwILXe/XsmwvvZw2wwwu3EvRfUD4EC1dMTQnOLwhlFfKGCReASyBXT8wvDzzZm35DVrVeeE36YDiRHnYoD2iPEwtr+d6N3fR0CJBHYlUD61xp5QxQ4yzFumoGGtXuIhB0KQt+Tuy4lvKNmKoOSpLEqkPennddyvYjGbK5bw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c041b9b8-6354-53ce-ea6f-d19ee328e346@suse.com>
Date: Thu, 6 Oct 2022 11:02:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
 <Yz1CPNwo1hiWZTw2@Air-de-Roger>
 <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
 <Yz2Q1C7Z2zolHAvK@Air-de-Roger>
 <544a7408-ea02-db17-39d7-82b7a1f56622@suse.com>
 <Yz6WWYn5uO4R3zNg@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yz6WWYn5uO4R3zNg@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0069.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::22) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7839:EE_
X-MS-Office365-Filtering-Correlation-Id: b08bfb70-08a6-4f17-1763-08daa77981d5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	frNDlv/n+0EW1m0GcBzchtvudNFRGXUwY32GpWn7gZzlW4EYBAFV/LfSN79Rn5Lfd2dNKTJcbcoGbXh45Or4xF96049tG9c2wygijzJIqKbBSbYC1Us3IvUVOULmtHH5SLxFj/7GlC7MG3TByJTMtMPV3aRIpOM9DdC2RvaXH6MzWF8vuV1hA81c687KSYoFefYbzuoKaNNjFucWjOvyDECeEzRuRaeJF7WtSs44sV9yir2UN6V2o2TiDw7Bg5SlvZ42KcPhBLu7gipymZ92kATYNTyw3u2ACy3gKAMdXHBk/IQTtM+4Fb2ZIUSqbw2Bt2znX+1SFzRAPM7+pTFW33hcbYigVqkZ+mnCXnItuIWEdQQa4nEU37IUXe2Q7pE/prtOAT+c36ApxfGLhUBrwsQc/Q+FRHO8/jQpGztzLJXa4d0yYLkIY5SzM6Eqrum+BbyubvERJQJ8Bh49/E+JTm5Sc4e1Xksy7c5ytnZbasixrgDhwkTxZwo3KYekRFLfRX2l1OX1zHTNCJsCsUdRBm8L0syLmOfp44DJetrViTaXuVpfJpMBwPTZcEltGoW8819CO6NzGumpwhu34AEGUCtcV9vYk8oTBObdg3RWmsXHtrVoMiUB2gbvGDE+pUuo/SscM8v5kbBpR8b5gzOIGj18kVWJioElYhIPRvJlLBSIcI8YculmGQfL83Truul3TvT5XLFar9AT9eLPaMTQ96txiP95GKj0swAcrC7DvfdJ/fbOIimLeTxFCq4lLTdyW1yLBDLDGu4s3p0H/cqdsRxBmf9nEIqWhdXu1hkXuRk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199015)(66899015)(54906003)(478600001)(31686004)(6916009)(316002)(66476007)(4326008)(66946007)(66556008)(8676002)(6486002)(2906002)(6512007)(26005)(6506007)(38100700002)(186003)(5660300002)(8936002)(41300700001)(53546011)(86362001)(2616005)(31696002)(36756003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V09iWHNpUHYxaHFDNXFjckYwUVIxMlh2Q1pDTVJXY2pQekNJQ1VEYUwyNWhM?=
 =?utf-8?B?N3Zyam5sT2JKekUxSGtZa2hWSHNORUNhMVZWTGMyd2ZzaGcyMGNFTC9KTEZj?=
 =?utf-8?B?L1dQSWdaaUJNcmVnQTY3MmZjSzBJQUVUTjFER1F3MXBOaUMwQ0dKcDJiVVVv?=
 =?utf-8?B?RjcyU3FZRUplSytibnE0U1REaFl2RlNtK0RTd0dwQlBuZXZtNUp2RW1oSWxY?=
 =?utf-8?B?dHRROWpReWNDY3ArSUZWQlRieXVWcm54NEhLQmdmY05XcjFVUEVuSTRRS0tV?=
 =?utf-8?B?SmpQYVlYUjM4TGVsQlQwVUh2bGpNMWdYR3hoaW1pbmZpOUZ4ZEhVUkE2eUVR?=
 =?utf-8?B?Q1BQdXAzOGFVWDlDeWxQS2ZHcURLM3JjK0xoRXlZbk1WNkZkQ3ZQWXBlbGRv?=
 =?utf-8?B?d0hWa2I2d1hneDJwUmZJSHRVY0hrbjVRdnJ0NTJBTTB3dnB2cGpoWWlzVHRn?=
 =?utf-8?B?WjhsWEtHejZGUXlDL24zQVl1S290TGpHN0tYa2lUVHlyQ2NHeUFXNHlEYWJy?=
 =?utf-8?B?dDJmSUdXRExtd2JsOUxTSHdkUHRsWjNFaHIyaDBzMHBxaVhTOTlIZnJzVzlz?=
 =?utf-8?B?V0ptZ25GcUhTbzNFbjFXVnNCNkxaT25wQlVEQ3hNRG13NFN3WnNkdk80Tlkv?=
 =?utf-8?B?eUQ5SG9CalA3a2ZsV1VQRzMrVGJMaFpnUlJ3eG9LRGxoNXBFbE1pYnZGeDF2?=
 =?utf-8?B?RER2dXBqY3VTTHlFVm13dENpS2lBSWJRamh0dlBVVlhmN1F1SHlpWlZVcW9H?=
 =?utf-8?B?b2NQdDl5bG04S2VZemVQVmlpYmpRdUIxWDlGV3lyM1E1bEY1OFVyWEVkV3Jv?=
 =?utf-8?B?ekpRMkhiTG1uUXk0eC9HZjJDbVlIaXVIVWhSWENDZ1NmUmNtQWtJNDZLeXVW?=
 =?utf-8?B?Qm5qUUpuTzNMeWhUTDF5TmFMcjk4MzZkZDV1OUduTTNQRzVHVDMvRkJIenNK?=
 =?utf-8?B?eFVFeVg5TGF3NTJLRE0yOWVmUWUzQmU5aVFuZytDUWQzbkZEaWJLR3A5NUZN?=
 =?utf-8?B?YUFiMHZkUHVONHZVaWdYWnFzYjZ4Q3UvRzliNkZjSWxuMXdULys5bXZTSkY2?=
 =?utf-8?B?QUsrMHRnc2JKTGVNNkJHM24wdlhVZ09EbTJiYS9YcXhOS0l2a1hncExUSlpO?=
 =?utf-8?B?L0JVY2dqb2tuRmk5ZThKRjUyM2ZTUFlBbkhBYjVpcVZJMC9iMTE5ZmJXNUF2?=
 =?utf-8?B?WGM1NjJaL3JNQm5zUlFwUUFCTG8wMHk1d2xVV0FRWjZMV01OTnBHenZyemdR?=
 =?utf-8?B?UGcwVU04MEtabjZiWDNDQ3ZnTEQrWkNMLzRtcGVQcFg5NVpkSHQ3ZENlRW5Q?=
 =?utf-8?B?aGpCVDV0ZUdYRlFCZGZoek1KYU0xUlZwejc2YURuZmE2eW5rRnczOGJXOTdn?=
 =?utf-8?B?SHdCbDdYeEo2RnpEZ3g3UzNEalRpb0FudE1FemtEN1BQTTZZRC9NbmxleWJP?=
 =?utf-8?B?TFd1aVVlNHQrdi9NWXBsUGRRRUhwNEdGL29KamtvWlhKSUNqcCtHczZCbWM5?=
 =?utf-8?B?dEh3Nkk4YWZZK2NtbHdRWEs3UUtZaWc0VDdQMU1UL3ZLTk1LNmRzQ0N6VER1?=
 =?utf-8?B?cDdDYkY5Nnd3anpMNklzMzdqL1dYc3RSWEQvSjRZZ214SHgzWklUVW9Fa01w?=
 =?utf-8?B?QkFmczRZc2k2SUJFSDNDbkhLT0F2UnExcXZjMnpSWHZoQ2VwTFBOckFQOHdj?=
 =?utf-8?B?NmkwcFhOc1ZJaDJVL0QyUXQ4VFltaXR6a1drTkplZXpBemVnZTJyV2dpMXZJ?=
 =?utf-8?B?WjVHV25pRzFvbmd2a1lybDhOWUZoTm9SUms2WGpqWU9RWGd2L2tZWitKU0VE?=
 =?utf-8?B?S3N5anM0d0JRK2djOUNwbDBodjdmNHQ1cEttMHErbUVrTUNPYkFyaTVmOVEv?=
 =?utf-8?B?VGZ0amdiYjVkcyt1cGd1MXBqRzM2L1JkVVdoL2NjQ2RkQjE3ZlNRMFpCdm0w?=
 =?utf-8?B?VlFIYjlYMGcwK2R3Z0gyNFBrb21XNVFKRzh1V3NtRHJGa3c4OVdEWGlrbEZo?=
 =?utf-8?B?bTN6NWkzWDlhbHBVRDVXVWJ2NTNGclZndmczTXk4elpwbU9pWDc2Y1dHTUtB?=
 =?utf-8?B?dVpaNXNTRjI2RlFYUWlNbVVsT05SOWhJYm1jUGhqRnlDd1dwb0NIelZGb1M5?=
 =?utf-8?Q?RIMwJOQfQW/LFSS7t9ds44Oi+?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b08bfb70-08a6-4f17-1763-08daa77981d5
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 09:02:33.8703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N57VTo76hKWwWm+37SiLD4nIDeHYk/chm9ZQxompoO9atHI1SczqZ4ip1Q0C26I/bK5+c+DPJ0fSIDcQ7et2ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7839

On 06.10.2022 10:48, Roger Pau Monné wrote:
> On Wed, Oct 05, 2022 at 05:42:08PM +0200, Jan Beulich wrote:
>> On 05.10.2022 16:12, Roger Pau Monné wrote:
>>> Hm, I have the following diff attached below which is more limited,
>>> and not so bad I think.  Initially I wanted to introduce an
>>> efi_all_mapped() helper, but that would require exposing EFI_MEMORY_TYPE
>>> which is quite intrusive.
>>>
>>> Let me know if you think the proposal below is better and I will
>>> formally send a patch with it.
>>
>> Hmm, personally I like this slightly better for, as you say, its more
>> limited effect. Objectively, however, I'm still unconvinced of making
>> this an EFI special case. How would non-EFI firmware go about
>> communicating that it is going to access a device at runtime (which,
>> as said before, I consider a no-go in the first place)? Likely by
>> putting its BAR range(s) in an E820_RESERVED region.
> 
> I've never encountered a non-EFI firmware that attempts to access the
> BAR of a device so far (or at least none that caused problems with
> Xen I should say), so I would worry about such use-case when we find
> one.
> 
>> Plus the MMIO range covered on the system in question is pretty large.
>> That way we're still allowing pretty wide an abuse by the firmware.
>> Furthermore the MCFG range would also be covered by an
>> EfiMemoryMappedIO descriptor (in fact that's the only use of the type
>> I had been aware of so far). IOW the change specifically permits an
>> overlap of a BAR with an MCFG range.
> 
> Additionally I could check if the device overlaps with any known MCFG
> regions in pci_check_bar(), again not sure if that's more fine grained
> than needed.
> 
>>
>> Who's the manufacturer of the system?
> 
> It's from Supermicro: "Supermicro X11DPU BIOS"
> 
>> Or put in different words - how
>> likely is it that we could first gain understanding on their
>> intentions with this region? You did say the system hangs hard without
>> some kind of workaround, but that doesn't clarify to me in how far a
>> use of the device by the firmware was actually involved there.
> 
> It's a black box to me, so I have no idea what the firmware attempts
> to do.

Right - I don't expect there's a realistic chance of getting hold of a
firmware person of theirs.

>  It looks like that BAR is used to store some information
> related to the boot sequence, the hang happened when trying to create
> a new variable bootnum using efibootmgr (that's just a guess
> really).
> 
>> Have you considered other routes towards dealing with the issue? One
>> approach coming to mind would build on top of what you've been doing
>> so far (either variant): Besides avoiding the turning off of memory
>> decode, also invoke pci_ro_device(), thus protecting it from having
>> its BARs relocated, and also preventing any driver in Dom0 to gain
>> control of it, thus avoiding two parties competing for the device.
> 
> IMO using pci_ro_device() would be going too far here - it's not Xen
> the entity using the device, so Xen doesn't really know whether
> there's already some interface between the firmware and the OS driver
> (or just OS) in order to signal that the device is being used by the
> firmware.

Fair point (I did think of that, but ended up not spelling it out).

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 09:22:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 09:22:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416779.661459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogN4y-0001TZ-C7; Thu, 06 Oct 2022 09:22:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416779.661459; Thu, 06 Oct 2022 09:22:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogN4y-0001TS-94; Thu, 06 Oct 2022 09:22:08 +0000
Received: by outflank-mailman (input) for mailman id 416779;
 Thu, 06 Oct 2022 09:22:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogN4x-0001TM-Lt
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 09:22:07 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr10064.outbound.protection.outlook.com [40.107.1.64])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 57e0e3f4-4558-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 11:22:06 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB7143.eurprd04.prod.outlook.com (2603:10a6:20b:112::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct
 2022 09:22:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 09:22:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57e0e3f4-4558-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cCKNTWx7A7Pk/PnJNvTbQj6zeHlWJXcxO+jzO4eisAual3gLFa4B5cA257xG4NqZP9g0lVy5UDfBnqWOQG+xG5rPKAsuxcZkiGZQ5wpbWhWAaYpaFxsok0Z0PFfctZnzphmyya1LkWbU5GEt8CpBItCLZt6ivhi/XOG11O/CrYk/1PB3g5yqJ84cTz2jNzU7Xmf32/ey1Af9fUNY0ydNj3ToYPhk5PmOKwbmzNA/eajru5J5h2iplz6OC0j8YEI/u8wLd7DVwIjfXl3fZr8PLbaPcN7y1Omk7eF66b3WK0YDSfRCCbmUgyy2kmdAtkWdXHZ9fs2TSNSkg08NnpqaOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0OZkKAHORdzT1HwfMcAmHm7TE/vpkKv9U2RN4iYwsD8=;
 b=ZNzcHalwIWnKcl55n4lzK+n4OfcCPUacCDgcXoTMIZlTJAzxbZZ7EINHSgI/e6/4LU2DMV0asnM0iGnp7bn/97Vy+tAU0fjhkjXDJPEtnREQSY7GtB7QuTAsw5+CSC3ItNxZAlcJll99b50xQW1oh26V3Uyp/J0ZMOE8zE8teROAagaOSOgGDppYWH4kyUeG6l4X/f0epLoHvke99mw9MGSY3QcXzY45P1PgHth5pbi0flGqmJ2+e7FyHNlXnJJ0ZpKP+Jluh9v0arJYE0ej7Vr1ujdfMN68WlZRBfAgacbcRpg8n4ZI+DSx7fn9gmDxYvucl37Y7ClEkOJHWPlbrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0OZkKAHORdzT1HwfMcAmHm7TE/vpkKv9U2RN4iYwsD8=;
 b=2JPybmyPuaR/MzhOA0fqc7FGtBu43zazD1RBVrGLiQPvXPUnYVN4HQKGBgUJoZPjUtt1MDzlgsL9dM8a1nijUiSV1imsAjMbP/jmcXqlz1InIy21S5UoA2isD35sMjBRcLSuw1/3nVUIgDGLZACjGx4knF+ANiWlECq9bW1q/7QotkzPXat1fj4jRpTLozBd1fKoUo5frJZTsy4MEfOT9TJrTGjVucMvvL8w4/JBTnIFnuP25bYNyOcmNvs3MlIwOpmH3b0IddDC/tpBwfCBK2slKKhEqe2ykC9Mrk4ZYB64G9F+Mfwlsamf/CdfHmXFDbYNYGZU59zKj7yJxezr6A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ba28a45c-166e-7b9a-3af9-40d249d7cf0e@suse.com>
Date: Thu, 6 Oct 2022 11:22:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-efi@vger.kernel.org, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Kees Cook <keescook@chromium.org>, Anton Vorontsov <anton@enomsg.org>,
 Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Ard Biesheuvel <ardb@kernel.org>
References: <cover.1664298147.git.demi@invisiblethingslab.com>
 <f3b624e99adfdbbfc1976a60a73a6b5950e1840d.1664298147.git.demi@invisiblethingslab.com>
 <282a225d-8782-0321-6f0e-19dd4510dc42@suse.com>
 <CAMj1kXFQNqsW5RfHGac-eGbosJHBybu6+-Fap_bi_kVxWNpGeg@mail.gmail.com>
 <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email> <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email> <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yz3I2qwl243h9ZfZ@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7143:EE_
X-MS-Office365-Filtering-Correlation-Id: e0ba2ea8-3ae7-49c5-b379-08daa77c3af2
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gjYiv1uPP8KiNLv3qJ/fFlyCpRYPagm+iGa4e/cRpDuQS+yQ22lWOw5lOEk64FDbiImtY6gh/EhCSxS11rO1ywc459Ub+C3NSf5qeblLJin+VCI3SGDvjqw/cPXwxfmLjJrwtnRnTjpVgMwp1et9ygWxBUOpUrPglI9JSqL/c6sJ/d1SElyMPzEY1y3a3jikgWHC+pEqduXJDTRjqbaK+V2J+1f4JMHT/vp654ZmdqFziUDxOTvZnS6kByc+Ee7wUMHghvZD+21GXy1IzqzHDtsre46dIRgpY4xCSDAbgacY3J+6s1LqtO4TK9zZLbk+itpLCxfqMJgcCRytuSauXs55+3YpnMgdaj3waTR5LH8I5QxbuYCsaXvJCtvO1wzeQCM8UOJaszSRs3x1OLbfYwVqQk7tNoQs1yKfLpRiO0P0HHSPPpc65IR3ZRj8omQDSAHmx+AqA6rmJ42UL12Rd03J3aHEqbfJKAB8vCL2azsTmwtPDHyxLz4hoxL4w6T6TYRmEmBd7hSNXcrrMWL0WZyhVweIsKvEy8aNwA/zL+EYkWywppqOwXKIXqJKE5t+k/vFQgSgKFpLWggLPCe8DBFNGr2yifxzB5HQaqdqTeQhayxgm3388QBbNragWckdHsng6K7/4YN23uqxM1KKhTuothzcnWiYm+5GO/ZmzPGISeT8zI3LnHFGt+u4C29XgFB8iwavPh7aZpw38LIP9mhhZdjkLyh5m/RM4FbI7ehwVCLwG7I3ibkbDjNgHzPNtxr8fiiil5rDp0gZvyjLc9Kh3mLWy7Sdj7V+x6VNSF8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39850400004)(136003)(396003)(376002)(451199015)(7416002)(6512007)(8936002)(26005)(36756003)(5660300002)(316002)(6506007)(53546011)(186003)(41300700001)(2616005)(83380400001)(2906002)(8676002)(66556008)(66946007)(4326008)(66476007)(31686004)(478600001)(38100700002)(6916009)(86362001)(31696002)(54906003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWNMSjZxVVVZaktMKzlBU3JGa1lLaE8vTkpHcDBReUlFeExmYkhueXV2UEc5?=
 =?utf-8?B?TktDRE9tdE5YNkZpUVYvZlFma2RmZ29vRWlESldMdzRIZ1JLV2V3ZXQrbmRX?=
 =?utf-8?B?UjAxWGpoekhQcmNhWVh1UWRNUXFPOVk0MDNmZWRKejZpZjJzK1lWNzV3TStM?=
 =?utf-8?B?Qlg2NWdxaVVaTlcyZ1g1TFhJNjlQYU1ITFdOMjJLT1hSQ2E4NWRkUjMyOHor?=
 =?utf-8?B?eUVnSVFCbzZWajdVaFNBQ3JiMWV2VUV3bUVEb2wvSnJRUlN1S2FObnpZRTMy?=
 =?utf-8?B?Nm1FRkZQMkxsLzNIWWZJWU9OOGRLQ3RIMkdvQkljYTc1bm1SOURlM2EzRWpR?=
 =?utf-8?B?NGhlQVJwOUR4S04wVDJ0dkloTGRoWWdWWFp0UXAveXZ0Wk5BbkQxL20zOFV5?=
 =?utf-8?B?dWZqMFBJS1ROd3VrcmpidGpOeHdmU2d6cGFuNGY3TVRSTk1rcTBEQno3MGsx?=
 =?utf-8?B?Mzd0WVovcWRnUVo0RXNsNnBLS0ZkcTNjZUVWdDk5bTl6ZkN4aG5GMXROUHBy?=
 =?utf-8?B?SkZEbXFybHJRbkR6ZStvNWNrSyt3dkNQREZwckxndElDdVdTOEh3OXowbzNa?=
 =?utf-8?B?SWRGRUQ3NmtZZWdEZnNOQzY4RXFOVXpHWDFiZHpKZ09JNjZ4YVJsOW5nWERm?=
 =?utf-8?B?WkxwaGtmYjFkL1krWkdvcTk2VkMyS1g4VFkyWVZkakI2dVhyVXV5cng1YnBz?=
 =?utf-8?B?TmJRV2pEUjdmM3hZTjR0KzBydk9xbmNZQzRTYjB2MnZvYllWQTFib0RmQkg5?=
 =?utf-8?B?a1F0eU56ellWcHlRVDFQdWlUMmY3bWd2c094TjdBbFhXYWdoeHpKR1hEUXZM?=
 =?utf-8?B?T1hLcGlvWUNSblhOeWM5VHRlbHowYUxyM0NBN29nVDlneEp4UGlmM0NDeTFp?=
 =?utf-8?B?TVR2TWhrZ3pQK3N1TnlCT3BZTkFLQ04xSEQ5REo0MGJDZVdWVXpzRms4YUJl?=
 =?utf-8?B?RlRqdGYzclo4azhtSUVkSTZXa1E2TjVFelJoQURkeVFxaVhJYkdONEtwUFR6?=
 =?utf-8?B?UE91cytNNHl4b0NkaUhxMHhhZUpyRldtRnJkOEtLdHQyT1JNUHRudFhOVUJi?=
 =?utf-8?B?OS9iVGpJSW5LWkN3NFZzTjA2WmJnNWZXZlduNGFlVkd6S3Bob0FxdXBNU29P?=
 =?utf-8?B?YnkrYVRmeFpBRTlZUVF1OVhJRFUxeHUzYjRlamdXR2NYZjBYdFpaajZYSWFz?=
 =?utf-8?B?T0xsVTYzQnZ4Tk1hYXJadWtyK01BRiswQW93K3ZtalFVTzJuRFhkc25BVUdP?=
 =?utf-8?B?TFhKRDVrT3dhZTUrWDMvazhNa1NmekpFaUNzeHMvVXU1UEZnYThXVnNlWEFy?=
 =?utf-8?B?RWdZL2dwQTRIejFBb2NzMFR2dk5LaEx4YWxET25vWWlSVjhlNzVWS0VFU2VM?=
 =?utf-8?B?S0E0eEUrK1d1RWpmZVljdXNWaStMekVpTXZQM3JFR25zM0JjRW5lR2Q5b0dk?=
 =?utf-8?B?WGFwcGU4cjByWHRjd09SWld4TFNJR3M5bjFQd3ViL3I4aEpxK0dSSHNxb3Fp?=
 =?utf-8?B?NS8vcEJTUmlka3IxU1lwZm95c0xzR2FTVjZqTVhnbW5BWjBsMjBtNzRpc0cy?=
 =?utf-8?B?Y3gwRURUVGkxQzdkbTc5d05iaDZGbDRLeTVnekM3L2ZtMDI4Y20xaGZETjFM?=
 =?utf-8?B?akdtNkQvdFNHeldHOGJ6bzRNU2l1YW9WNHNLT3g4R0tYOFl4elNmd21kdTlQ?=
 =?utf-8?B?dmc0cFJTc1BtOFVGQ3ZtSU5uMXY0VENaVlEzZU5XVUROMyszSjQvUVFNWXVp?=
 =?utf-8?B?ZzZJaEpRQmdMUzRMWVN5ODJlL1BzNjhRRzZHajh5TW13a1FwcjBiTVhvWXFa?=
 =?utf-8?B?aUNEa21hSENJMGhXeFRyeXM1Q0dJeXlSUEE1ejViL3p1c3VUYlVYTUQ0QjF0?=
 =?utf-8?B?aWtOZU9yalVTWnNMSXdBWHI3RjBOcllNTG1jcUU5TlhUalp6b0ltU3FLbUF0?=
 =?utf-8?B?T3NSd0p0bUJ5SmtiSEZMT2hsalE4eUFDNnVFaVU0MUxKUGM1MEFObFNUNDda?=
 =?utf-8?B?RDFEK0VMaWVkTUx2RlBGQ29mYm5SM0V5NkJBbFZ6ejFLUE9ud1JoYmlaMzFL?=
 =?utf-8?B?ZHlDMnpXR0t5dm1CVnQ5dldiQXF6cENQNHZmc0x1TDY3YW1BT0lkZzlqeTE2?=
 =?utf-8?Q?DP74yOdibiaeoIzpA/YuIEAGY?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0ba2ea8-3ae7-49c5-b379-08daa77c3af2
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 09:22:03.4363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d9+cBNaUxOzRPBQQIh9I5hGkO+iPB5ie28Ar6A/OoH45NNsQlnj+/UBEBXTt44VFIPirQZxQodvQoDAMu3YWFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7143

On 05.10.2022 20:11, Demi Marie Obenour wrote:
> On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
>> On 04.10.2022 17:46, Demi Marie Obenour wrote:
>>> Linux has a function called efi_mem_reserve() that is used to reserve
>>> EfiBootServicesData memory that contains e.g. EFI configuration tables.
>>> This function does not work under Xen because Xen could have already
>>> clobbered the memory.  efi_mem_reserve() not working is the whole reason
>>> for this thread, as it prevents EFI tables that are in
>>> EfiBootServicesData from being used under Xen.
>>>
>>> A much nicer approach would be for Xen to reserve boot services memory
>>> unconditionally, but provide a hypercall that dom0 could used to free
>>> the parts of EfiBootServicesData memory that are no longer needed.  This
>>> would allow efi_mem_reserve() to work normally.
>>
>> efi_mem_reserve() actually working would be a layering violation;
>> controlling the EFI memory map is entirely Xen's job.
> 
> Doing this properly would require Xen to understand all of the EFI
> tables that could validly be in EfiBootServices* and which could be of
> interest to dom0.

We don't need to understand the tables as long as none crosses memory
map descriptor boundaries, and as long as they don't contain further
pointers.

>  It might (at least on some very buggy firmware)
> require a partial ACPI and/or SMBIOS implementation too, if the firmware
> decided to put an ACPI or SMBIOS table in EfiBootServices*.

I hope we won't need to go that far; on such systems -mapbs will continue
to be needed.

>> As to the hypercall you suggest - I wouldn't mind its addition, but only
>> for the case when -mapbs is used. As I've indicated before, I'm of the
>> opinion that default behavior should be matching the intentions of the
>> spec, and the intention of EfiBootServices* is for the space to be
>> reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
>> that hypercall: It might use it for regions where data lives which it
>> wouldn't care about itself, but which an eventual kexec-ed (or alike)
>> entity would later want to consume. Code/data potentially usable by
>> _anyone_ between two resets of the system cannot legitimately be freed
>> (and hence imo is wrong to live in EfiBootServices* regions).
> 
> I agree, but currently some such data *is* in EfiBootServices* regions,
> sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
> configuration tables that point to EfiBootServicesData memory before
> freeing that memory.

Hmm, uninstalling isn't nice, as it may limit functionality. Instead we
might go through all tables and fiddle with memap descriptors in case
a pointer references an EfiBootServices* region (regardless of size, as
per the first restriction mentioned above). (A more brute force approach
might be to simply behave as if -mapbs was specified in such a case,
provided we can reliably determine this early enough, i.e. before first
checking the "map_bs" variable.) Tables actually known to us could also
be relocated (like you've done for ESRT).

Such checking could be extended to the runtime services function
pointers. While that wouldn't cover cases where a function entry point
is in runtime services space but the function then wrongly calls into
or references boot services space, it would cover a few more (broken)
systems.

This, unlike behaving by default as if -mapbs was given, would be a
workaround I'd accept to be enabled unconditionally, as it wouldn't
affect well behaved systems (beyond the time it takes to carry out the
checks, and provided the checking logic isn't buggy).

There's one further caveat towards uninstalling (in a way also for your
ESRT relocation code): The final memory map is known to us only when we
can't call boot services functions anymore (i.e. in particular
InstallConfigurationTable()).

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 09:29:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 09:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416787.661469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNCA-0002Ab-4G; Thu, 06 Oct 2022 09:29:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416787.661469; Thu, 06 Oct 2022 09:29:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNCA-0002AU-1V; Thu, 06 Oct 2022 09:29:34 +0000
Received: by outflank-mailman (input) for mailman id 416787;
 Thu, 06 Oct 2022 09:29:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogNC9-0002AO-Gh
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 09:29:33 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 62165700-4559-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 11:29:32 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 772132197F;
 Thu,  6 Oct 2022 09:29:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D0A51376E;
 Thu,  6 Oct 2022 09:29:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Plt5DfufPmNIVAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 09:29:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62165700-4559-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665048571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=L7RZFM5d4dnIi1GRTKhMwES2/uyXuvfgoPRuTe96ogM=;
	b=Ci/J0VnfozSfW1tn8VrgOAeBJ0GslTmfAaoB/QDoi2AQB8js+3KZ7nxA6MxMpRSmow6xVi
	j2hmf+j+RbkQkmXnOztnb/pndUnWf44vQX6nrfx02GbaRGavkRcfPmN3RY6FOYJjL0o+cN
	1YtXQlXJfn1PeYjiWilheBlS/EyqdzM=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH] xen/pcifront: move xenstore config scanning into sub-function
Date: Thu,  6 Oct 2022 11:29:29 +0200
Message-Id: <20221006092929.30041-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

pcifront_try_connect() and pcifront_attach_devices() share a large
chunk of duplicated code for reading the config information from
Xenstore, which only differs regarding a function call.

Put that code into a new sub-function. While at it fix the error
reporting in case the root-xx node had the wrong format.

As the return value of pcifront_try_connect() and
pcifront_attach_devices() are not used anywhere make those functions
return void. As an additional bonus this removes the dubious return
of -EFAULT in case of an unexpected driver state.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/pci/xen-pcifront.c | 133 +++++++++++--------------------------
 1 file changed, 40 insertions(+), 93 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 689271c4245c..a68e47dcdd7e 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -819,76 +819,79 @@ static int pcifront_publish_info(struct pcifront_device *pdev)
 	return err;
 }
 
-static int pcifront_try_connect(struct pcifront_device *pdev)
+static void pcifront_connect(struct pcifront_device *pdev, bool rescan)
 {
-	int err = -EFAULT;
+	int err;
 	int i, num_roots, len;
 	char str[64];
 	unsigned int domain, bus;
 
-
-	/* Only connect once */
-	if (xenbus_read_driver_state(pdev->xdev->nodename) !=
-	    XenbusStateInitialised)
-		goto out;
-
-	err = pcifront_connect_and_init_dma(pdev);
-	if (err && err != -EEXIST) {
-		xenbus_dev_fatal(pdev->xdev, err,
-				 "Error setting up PCI Frontend");
-		goto out;
-	}
-
 	err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend,
 			   "root_num", "%d", &num_roots);
 	if (err == -ENOENT) {
 		xenbus_dev_error(pdev->xdev, err,
 				 "No PCI Roots found, trying 0000:00");
-		err = pcifront_scan_root(pdev, 0, 0);
+		if (rescan)
+			err = pcifront_rescan_root(pdev, 0, 0);
+		else
+			err = pcifront_scan_root(pdev, 0, 0);
 		if (err) {
 			xenbus_dev_fatal(pdev->xdev, err,
 					 "Error scanning PCI root 0000:00");
-			goto out;
+			return;
 		}
 		num_roots = 0;
 	} else if (err != 1) {
-		if (err == 0)
-			err = -EINVAL;
-		xenbus_dev_fatal(pdev->xdev, err,
+		xenbus_dev_fatal(pdev->xdev, err >= 0 ? -EINVAL : err,
 				 "Error reading number of PCI roots");
-		goto out;
+		return;
 	}
 
 	for (i = 0; i < num_roots; i++) {
 		len = snprintf(str, sizeof(str), "root-%d", i);
-		if (unlikely(len >= (sizeof(str) - 1))) {
-			err = -ENOMEM;
-			goto out;
-		}
+		if (unlikely(len >= (sizeof(str) - 1)))
+			return;
 
 		err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str,
 				   "%x:%x", &domain, &bus);
 		if (err != 2) {
-			if (err >= 0)
-				err = -EINVAL;
-			xenbus_dev_fatal(pdev->xdev, err,
+			xenbus_dev_fatal(pdev->xdev, err >= 0 ? -EINVAL : err,
 					 "Error reading PCI root %d", i);
-			goto out;
+			return;
 		}
 
-		err = pcifront_scan_root(pdev, domain, bus);
+		if (rescan)
+			err = pcifront_rescan_root(pdev, domain, bus);
+		else
+			err = pcifront_scan_root(pdev, domain, bus);
 		if (err) {
 			xenbus_dev_fatal(pdev->xdev, err,
 					 "Error scanning PCI root %04x:%02x",
 					 domain, bus);
-			goto out;
+			return;
 		}
 	}
 
-	err = xenbus_switch_state(pdev->xdev, XenbusStateConnected);
+	xenbus_switch_state(pdev->xdev, XenbusStateConnected);
+}
 
-out:
-	return err;
+static void pcifront_try_connect(struct pcifront_device *pdev)
+{
+	int err;
+
+	/* Only connect once */
+	if (xenbus_read_driver_state(pdev->xdev->nodename) !=
+	    XenbusStateInitialised)
+		return;
+
+	err = pcifront_connect_and_init_dma(pdev);
+	if (err && err != -EEXIST) {
+		xenbus_dev_fatal(pdev->xdev, err,
+				 "Error setting up PCI Frontend");
+		return;
+	}
+
+	pcifront_connect(pdev, false);
 }
 
 static int pcifront_try_disconnect(struct pcifront_device *pdev)
@@ -914,67 +917,11 @@ static int pcifront_try_disconnect(struct pcifront_device *pdev)
 	return err;
 }
 
-static int pcifront_attach_devices(struct pcifront_device *pdev)
+static void pcifront_attach_devices(struct pcifront_device *pdev)
 {
-	int err = -EFAULT;
-	int i, num_roots, len;
-	unsigned int domain, bus;
-	char str[64];
-
-	if (xenbus_read_driver_state(pdev->xdev->nodename) !=
+	if (xenbus_read_driver_state(pdev->xdev->nodename) ==
 	    XenbusStateReconfiguring)
-		goto out;
-
-	err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend,
-			   "root_num", "%d", &num_roots);
-	if (err == -ENOENT) {
-		xenbus_dev_error(pdev->xdev, err,
-				 "No PCI Roots found, trying 0000:00");
-		err = pcifront_rescan_root(pdev, 0, 0);
-		if (err) {
-			xenbus_dev_fatal(pdev->xdev, err,
-					 "Error scanning PCI root 0000:00");
-			goto out;
-		}
-		num_roots = 0;
-	} else if (err != 1) {
-		if (err == 0)
-			err = -EINVAL;
-		xenbus_dev_fatal(pdev->xdev, err,
-				 "Error reading number of PCI roots");
-		goto out;
-	}
-
-	for (i = 0; i < num_roots; i++) {
-		len = snprintf(str, sizeof(str), "root-%d", i);
-		if (unlikely(len >= (sizeof(str) - 1))) {
-			err = -ENOMEM;
-			goto out;
-		}
-
-		err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str,
-				   "%x:%x", &domain, &bus);
-		if (err != 2) {
-			if (err >= 0)
-				err = -EINVAL;
-			xenbus_dev_fatal(pdev->xdev, err,
-					 "Error reading PCI root %d", i);
-			goto out;
-		}
-
-		err = pcifront_rescan_root(pdev, domain, bus);
-		if (err) {
-			xenbus_dev_fatal(pdev->xdev, err,
-					 "Error scanning PCI root %04x:%02x",
-					 domain, bus);
-			goto out;
-		}
-	}
-
-	xenbus_switch_state(pdev->xdev, XenbusStateConnected);
-
-out:
-	return err;
+		pcifront_connect(pdev, true);
 }
 
 static int pcifront_detach_devices(struct pcifront_device *pdev)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 09:44:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 09:44:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416794.661480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNPx-0004Sa-Co; Thu, 06 Oct 2022 09:43:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416794.661480; Thu, 06 Oct 2022 09:43:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNPx-0004ST-9k; Thu, 06 Oct 2022 09:43:49 +0000
Received: by outflank-mailman (input) for mailman id 416794;
 Thu, 06 Oct 2022 09:43:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xibJ=2H=citrix.com=prvs=271cd1fce=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ogNPv-0004SN-GX
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 09:43:47 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c916383-455b-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 11:43:43 +0200 (CEST)
Received: from mail-mw2nam04lp2172.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 06 Oct 2022 05:43:29 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by CO3PR03MB6806.namprd03.prod.outlook.com (2603:10b6:303:166::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 6 Oct
 2022 09:43:28 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 09:43:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c916383-455b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665049423;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=KsSOSNnnD9yJmsiRRR4fsWhHFlns4g8E00TDWhZCluw=;
  b=Y8HknyHu7FEhXntE7y4d9sBqIoLkIrOcWLOubmeg2kDzQSQ9TvjPmbs9
   +f1p8WTZvlBMybrHJBT9EjLQcXgQlM/UhW1fadlx7g+4VYrWiXoTlYziK
   vjy4bqts309vlMHlbvkHxqGAcaGZGdEm4Ht3lux86aWAsIhBUBj6TQAF5
   U=;
X-IronPort-RemoteIP: 104.47.73.172
X-IronPort-MID: 82525856
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:SvIq6ajaZkHAHO/0FGTrHfOkX161mREKZh0ujC45NGQN5FlHY01je
 htvWz+BOPuKNmfwfYp+PNvnpE1XuJ+Gn4RqTwE6qS40QSMb9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmPa4T5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXtf/
 8BBDSovVA2OoNLpwq7kcfRMwf12eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVMruFTuGIO9ltiiX8Jak1zev
 mvb12/4HgsbJJqUzj/tHneE1rWSx36rBdx6+LuQ0+42u0WX/VYoCQAaZH3mg+KX2wmsVIcKQ
 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS8xqRw6DZ5wKYAGksTTNbbtEi8sgsSlQC1
 EKNnt7vLSxitvuSU3313r2Zty+oMC4Za2oLfzYZTBAt6sPm5oo0i3rncNFnF6Kki8zvLhv5y
 TuKsSsWiq0aiIgA0KDT1U/DqyKhoN7OVAFdzhXaWCep4x10YKahZpe08h7L4PBYNoGbQ1Kd+
 n8elKCjAPsmCJiMkGmIX78LFbTxu/KdamSD2xhoAoUr8Cmr9zi7Z4dM7TpiJUBvdMEZZTvuZ
 0yVsgRUjHNOAEaXgWZMS9rZI6wXIWLISrwJiti8ggJyX6VM
IronPort-HdrOrdr: A9a23:dTH2V6+hn2b8zClZ4JRuk+G4dr1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe
 ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpixBiSgSiu4LvaFQHd+hsFSTtAzZor7G
 CAymXCl++emsD+7iWZ+37Y7pxQltek4txfBPaUgsxQBiTwhh2ubIFBXaTHmDwuuumg5Hsjjd
 GJiRY9OMZY7W/XYwiO0FDQ8jil9Axrx27pyFeej3emicvlRAgiA84EoY5CaBPW52cpodk5ic
 twriqknqsSKSmFsDX25tDOWR0vvk2ooUA6mepWq3BES4MRZJJYsIRa1kJIF5UrGj789ekcYa
 BTJfCZwMwTXUKRbnjfsGUq6NuwXk4rFhPDeUQGstz96UkioFlJi28jgOAPlHYJ85wwD7Ne4f
 7fD6hunLZSCucLcKNUHo46MIWKI12IZSiJHHOZIFzhGq1CEWnKsYTL7LI84/zvUIAUzaE1hI
 /KXDpjxCEPknrVeI2zNaBwg1PwqD3XZ0Wu9ige3ek0hlTEfsurDcXZI2pe1vdJoJ0kc7/msr
 iISdZr6sTYXBvT8LZyrnPDsqZpWAgjue0uy6IGsgG107X2A7yvkNDnW9DuA5eoOQoYewrEcw
 g+tX7IVYh90nw=
X-IronPort-AV: E=Sophos;i="5.95,163,1661832000"; 
   d="scan'208";a="82525856"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H59t+GoE4tfpp1dolKmVPf4sgRi3cNX6NQvnQCWEJOj3QiLR+znvp0FCxmqowrwg0hUT/sMZDaOYuoGSuVZh2cxVnD3ownKpgRlfWZO8JWNMCQevoRB0s+c/iTwG9ny1HuYp4KpaABZ+kOyo3U4VmjVfI3bq67g/Tiu7jTCZAvqQxvE8Bi4tX/ndtm+s0u1okNAQ64U05CVY+h1SwtLx7KWhVFDDBW9FaZ/RkIkJJozb/2QqKGkI7Hd61munJ+kq+UpBLv+ZDe2U32ZucauqjAk8/su+C4jgxiE1JjNBTVNLrNVoc/59IwXnGcRSdNHlTzRLcFgTk6/uQAVAaltTDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qlBIEbgRsMGfqFtBiCdkG1qpAhfAF88pKmiABeAVQn0=;
 b=I2lHhhd0EepPAork5N3iHVkMlHtA1K3l5d4OAjjRDk9POxdwD2svQRTieqmWbwtY2m5vwI6zxoYIbT3B01iG7Q7oK+zzPgJCpYr7liiVMQdsqs7DN/WBvv+QjFQZKvW0GgoMxHjk9Ea3aHj1jZ5rjLCSQTertwyZo4ozSlfbPT7EvIxckEuSa5VqyXUeKRPjmEY812Dh3rYlm0w/vYd7VcHs6FCryxdBOnvRxhAQKlJCj/2w5RDvEbOEiOGt0h9/NL79+FOCtadKkyHQC2OKj5WHJa+VgtSYw4dWLZ8nRKhFRv8veN3jgFTLGrr+fhS3NzB7e0mLmf8loKVuqFa2Dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qlBIEbgRsMGfqFtBiCdkG1qpAhfAF88pKmiABeAVQn0=;
 b=lMgutHk6Eq6pa2NQ48CEifsHkvGJJGWbQ2xm9oIoAnZEr1R5K0zD4+jLGdIR+AYJevkfObbEK+upgnhpzelfKdvMf/bMfmr+A/4bvhsDITfARqn1s/FgjaAkS4CrsqkB3SdLseNUQtvf0nvZNtV1yUwt1DjrWEcTbCzV7Yukdks=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 6 Oct 2022 11:43:21 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17] x86/pci: allow BARs to be positioned on e820
 reserved regions
Message-ID: <Yz6jOVAmkWX4ZGmW@Air-de-Roger>
References: <20221004153645.3686-1-roger.pau@citrix.com>
 <4c1ce9fc-7501-89c9-f66a-9b6671d98302@suse.com>
 <Yz1CPNwo1hiWZTw2@Air-de-Roger>
 <e38bae0c-c0ce-4953-2813-0d03bd3effbc@suse.com>
 <Yz2Q1C7Z2zolHAvK@Air-de-Roger>
 <544a7408-ea02-db17-39d7-82b7a1f56622@suse.com>
 <Yz6WWYn5uO4R3zNg@Air-de-Roger>
 <c041b9b8-6354-53ce-ea6f-d19ee328e346@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c041b9b8-6354-53ce-ea6f-d19ee328e346@suse.com>
X-ClientProxiedBy: LO4P123CA0502.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::21) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO3PR03MB6806:EE_
X-MS-Office365-Filtering-Correlation-Id: 82ae8bec-a376-46bd-93b2-08daa77f3864
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9fB7ptCD4LEYBy4Iur+IQy5EBOC5B3yCIctsnuJSuZ9WNzxhthp+ICs6PIqYlxzECGgMv3H5dR25JGoPRUrqYBFB1SBtscPppfmuLAh90h1OC0u42PJVneW2AS0k/UhO152Ykry8r9ZEhdba+PQM2nOZ55PT1Bc2YPur0CLqEqct2/Zp+Fs29F7uQTLf1frFyfiqyksP98KCgj5yZ10C2sk0Xs8e17GueD0P46DCiv6iSSUY3IaIaKb7CM3T4jor3EOAT1zD4MqbDQ03iRvas/1AU61mfEUKxrBN0J5a1+mhh/cEE+toGAygquzbjTsUAhAQjYmOIK4zRi+RMYF5IqnQNP2oiGCV9gDcH6llfFH9oI15HG3ZLlc8PIuDWtgzbKrWxfSYC1IX4YHZ28xf4AGqZ9fAfuw451HohNDgYm/X3aii+giOy3fZrgisIR/vidcABY3M/gfTqXFiK7SR+wc2pVyK6C0KIWymLQGp4O0J+tIJX1L8i5uNoJikFRTyIKjr+i3jm1lt0QwXznjoFFoSbo7Fjk1s+mUtgQwoImjXr0rg4GbTHWYsWbT2XyQQpoGQeAhZvOLZIAWH9JK+fXCueyCkNmfPwYMJ8YyQdMCJuUa2TxGHFDRnlW4N79jnmtEF7LqlQNkUN4sQzWJfNRdGryYQwInlnUEjvtNR4RpuB5E9UBLUxwtJBbQBOGlo/yiSCs2ZUyeJLP1cGnWJUg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(8676002)(6512007)(9686003)(186003)(26005)(8936002)(85182001)(4744005)(2906002)(5660300002)(4326008)(66476007)(66556008)(66946007)(6666004)(41300700001)(53546011)(6506007)(6486002)(33716001)(66899015)(38100700002)(82960400001)(86362001)(316002)(54906003)(478600001)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?LzZPSlExSE02Qyt5QTcyb1gwUDN0ZTMyZnV4WCtmYnBxWWRUbWRESWNuck9E?=
 =?utf-8?B?SWFJa1FIMEVzV0tBWmx0V0xCVSs3UXA2U1JaSGhUd1lqNkd0K2VYM2VwNGpo?=
 =?utf-8?B?Tm9rNnBaT28waGEvUVFPQ1RNTk5kVVpKSWFwVlVzRTFmV1kvbzA0OEpIMWh5?=
 =?utf-8?B?WnJJaDRWVmo0VGtNNlE0MmJFN0k0clhmSWY2dDRwaS9zaHd3OSt2MTd6Ynps?=
 =?utf-8?B?RXArcGdoZHVrUFQ5eUVlSGs2TWNqLytXQncwd29DTjJXNnpvdXlIMTQxS1Mw?=
 =?utf-8?B?aHdrajJsdVRETTd2N1VXSnZyOTBFMEdGbjMxbGdLZkNwMFpxV3phckdZQmw3?=
 =?utf-8?B?UDV6b2U2ZGV4QnJmN1dSMzhwcFBuRE1ubXg1d1VZandaUDZUb001Vks4UDZZ?=
 =?utf-8?B?c2VZWkFWRVAzaFVRWUROWkhuZ09UZXE0T1U1cWpyT1JCaU5Id2NWVXVmdkoy?=
 =?utf-8?B?NTBqNXczbzVYQjZFdnVnbmUzRnZxSjI4QTlaN05SSWo0eVppdUR1eGVMTUta?=
 =?utf-8?B?VTdGSUwvZ3dNbkRhdHFuczBXOWx4Z0t5VGFPQ1JTYmJlTy9oODBtVTRrbmc1?=
 =?utf-8?B?TFdRQ2Vhb3hJZ1NzNTcwaDM0bjBHOTlsVk9HQzJmbVd3ckp5YmFnRVpGMy9S?=
 =?utf-8?B?UUZSay9oWWloNGJkY3M4a0lGeVRFemp1YU5ZR3U4WWptamFKQ25ZbnRLY1Nk?=
 =?utf-8?B?SHVEV3U3cVlXRXdNRlNOK1RROEJWcXVWRjVtNkRIWlYycTJWTi8xRjRKMTVr?=
 =?utf-8?B?c3hBc3E1SW5MWVQ1WjRub3ZOV0FwNDF0L2gzbHFBOGliWWI1LzlUNGlxSlB5?=
 =?utf-8?B?SUdZRTZwMzh1NFJPSHhjMVVGdUtmbXdSdWFHTmwrRnFZRzlLS1hEOUIyZ3h1?=
 =?utf-8?B?UzhTZjJOdVgyZ3BYeTRqTXBoK3o1VmR6TjYzVVUvaUxlSWZoWHNITmZ0NzBT?=
 =?utf-8?B?NzRXV2lBdFRYVDE4UXI2UjUyY2tnTUkvTFRFOHFyUXZwWFVPNTVYN2hHa1VJ?=
 =?utf-8?B?N1c5QnV5ZHVIOWhpOHEvNzJUOTNEUzJRS1hXbnlCZ2ZvNUxnejJNV0JjUlBZ?=
 =?utf-8?B?ajhRSmxENkxHcENhdGpodWJIdjNCZ2JDK2h4THN3S3BQZzFjVmEvWXVnc1h1?=
 =?utf-8?B?am9rYTdlbFNxRFJxUndpb1ROeE9pd0VlTkhrdWRaN05wdGFBdk5pTTlGL3Nu?=
 =?utf-8?B?czloVFdvaUJoYUxLeS8ycGpwV2wxR25YRHBvbFNNWHBmb3hmazR3WWwwZUVF?=
 =?utf-8?B?ODA2bzJpeTM1bnVVdkJxTUdaZlB4THVhVzRsdXNKZjFyMnFaWVNWVW04bGFB?=
 =?utf-8?B?bmVnbVQyRGJnQVRIdC9iNXJFZ25ZUUQ4K2xwWHlXaEdCK09YMFEwRzJ2NWRE?=
 =?utf-8?B?UllJTTEyMjVXNDAzV3Mzb2VvSVBBNXNGaXZ4VzdNRlY4dmphaUZrT1I4Ujlx?=
 =?utf-8?B?Q1k4VmEzY3lJM2M2WUpIbVVnalF3RUlaUkhuU0VjTG41ajRkYUNjUmxWd0wz?=
 =?utf-8?B?YVRKeWx1VG55K21CdmV5VHNoVWtLUHdheFhpZU1MakxGck5sNmd1MDRiRTZE?=
 =?utf-8?B?WFg3N0xUNFpNWGRKdEJZbUs2WmJqekhKTnhZZkV2K2o0bm5NZEorSUI2UDc2?=
 =?utf-8?B?R0RCQjE5TENoemJyaEo0L0VkczJEaFZlOVYrdFFjamFpSXNEL2lsNnM4SGRa?=
 =?utf-8?B?dXlnQzg2a1JGd3lqbUxBZUVjQkVXS1RJT2lvMXVXU3NSWW05ajFoZXJUMDRN?=
 =?utf-8?B?dmEzUUhVdy9Rc0N5VnZ6YjF6QW9IZ25VcVQwWUEvTzNhajNEZ1dSTmVKd3RV?=
 =?utf-8?B?R3lENDJlZ0xlQ1YxdnhuUzFOZjVIRVJrNnhRT0JQWEdLL3NwNS9hTmdTcjdo?=
 =?utf-8?B?a0w5dHFDQjlQcWs3bXNHUWlWSUM3aUF4R3lzc1NjQjNWVWJoMXhxZGduT2t6?=
 =?utf-8?B?aUZJendPcnBqdUF3enBjbjY5MkhZS1JpQ2poZUlKTWJLckRya29OYkp1QlNw?=
 =?utf-8?B?eTJZcDFSZHJOUy94WFN3ZE5zQ2IvZ3doalNrc010bzNwb2NocDh6TENxQzZZ?=
 =?utf-8?B?dVZmcHZQTmh6RHFOVlhjRC9weGRJajVadEN0RXMzb0FRVmtGaU43d1pENlVl?=
 =?utf-8?B?TzZWVnhpMHVWMHd0MThwTFM5QUllTzEwdFNJYmJIaE15Z2h2YVhaVVhnTE9P?=
 =?utf-8?B?akE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	7kztdpbzeHURh67OR0XEWPh4JrI9tHruKB9NUd25im4rTuIqiFk8amYLtsAtALsfwzBvUy+MFXE/63mTz0il98+KVT91/QCQflXz1jgflj7kNeXs88Hbed7eiz4H6O4bzeVtFxdyigGuE/AJdZNJeY5geoM6FSCVZLPwf2PiqjksK23nRSkEy7kdoeo09tjPP/uqqCpLbhtMYlxj1zlzcYgXKfCT/NfsSYNS22c3a3D7iYmuGGVZqDbIzLm9vbHjo+a90vWHOJ0p9GbxriBk+V2peHzXRRvVxbhmVb7kQQ1ZYavQ2oDQNQzKZwQVOFEE42W9pDo+lA2qTV2bZdcE7q/SXSHDe7ctQwuOak0UGwVSS7wybjx7mKPgzAJgZbMtSBLq/idKg/jqsANAjHg8uLS5b4BQt+orITV4uVYSZm4m8IxH0fU+p2SSgP28RyXeJYHcMMHvDu+VzwER0uNCit7YgMu/2jm8bzv150gITBjHWT404WNWtidTsHp/sNYm9bF6DqGReJc2eRRYyRCd7ysPtgDibv8Z1Mh85xExJYeCImX9j71ZRnQwSipq45I1iaZmgO6o61ls69N/oOxRAcGD5bat8EV1dZc1dfMDnY9/Ujc+/iC0Da0PwBbX3pkmjr+3g6RmMzL2u4vy1/g0uPyZ8uG50LyqSJZ23LqIhbR9nzilf2lzHy6XrIheJgYnLkUErhwBJijqC9ZE/N24HGgfdAvSv3mPFcCKmJyTqyqbpecZpIqyAkb5gLymHR8U7yA+QIrhBD6GPD/YW5Yh83hm1sViIFfNeKRWBewTC8/NCykiIRK07//4dRxvE/NE4fBNnfvPJGBwXpH33wLyy0N4Mmi1m4zeLO+qbShw9G0iF/V7kYwcCg6FoNxwTIMiVczfWzZpSIIVvt2faNTQ7CtcEB+UeXkyO357mGrQLhs=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82ae8bec-a376-46bd-93b2-08daa77f3864
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 09:43:27.7817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mbIEN17UJ3h4dk8IaO9EpeACjPlMFOh0ZfCq3fkMp7fqdIMBxdDGcWEx8hDShK6wC2d9Ffek/8WBpRTydeSa8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6806

On Thu, Oct 06, 2022 at 11:02:32AM +0200, Jan Beulich wrote:
> On 06.10.2022 10:48, Roger Pau Monné wrote:
> > On Wed, Oct 05, 2022 at 05:42:08PM +0200, Jan Beulich wrote:
> >> Or put in different words - how
> >> likely is it that we could first gain understanding on their
> >> intentions with this region? You did say the system hangs hard without
> >> some kind of workaround, but that doesn't clarify to me in how far a
> >> use of the device by the firmware was actually involved there.
> > 
> > It's a black box to me, so I have no idea what the firmware attempts
> > to do.
> 
> Right - I don't expect there's a realistic chance of getting hold of a
> firmware person of theirs.

Even if somehow I could manage to do that (which I think it's
unlikely), it's not going to happen before the release, and there are
production boxes out there that have this behavior and we need to deal
with them.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 09:51:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 09:51:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416804.661492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNXJ-000610-A0; Thu, 06 Oct 2022 09:51:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416804.661492; Thu, 06 Oct 2022 09:51:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNXJ-00060t-6u; Thu, 06 Oct 2022 09:51:25 +0000
Received: by outflank-mailman (input) for mailman id 416804;
 Thu, 06 Oct 2022 09:51:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xibJ=2H=citrix.com=prvs=271cd1fce=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ogNXH-00060n-Oa
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 09:51:23 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e657e6b-455c-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 11:51:22 +0200 (CEST)
Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 06 Oct 2022 05:51:19 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA1PR03MB6386.namprd03.prod.outlook.com (2603:10b6:806:1c1::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Thu, 6 Oct
 2022 09:51:15 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 09:51:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e657e6b-455c-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665049882;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=m/VYlMSbCju6dBMqbt2mD95iGbvMd3E8cg9WkRMolnE=;
  b=CKeOjraQWWJyety7dXdo/kePFUSJtfwTXtmU15JJIHZLKSlu8YmBDOle
   2aKAVB05BUZ5wMvJFzvfXd1Se3aY/9f2ughA8PxwxLDvD3eHVEhj4l4A0
   qOyk6A49GYc7XbgGULjZSGSBb+Cgo6YApv8kVJ8uLfm2LrM5IGN8MZCu0
   g=;
X-IronPort-RemoteIP: 104.47.57.168
X-IronPort-MID: 82526224
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:8ZGI4ap1JKpo1IEp4bNNUbiGnEleBmKNZBIvgKrLsJaIsI4StFCzt
 garIBmBPfbZa2X8KI8nYYqxoRlXu8TXx9FnHQRvrysyFy4X8JuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgT4geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1
 tMnBAsDdwm6rbi6zbiHbutIvdUFFZy+VG8fkikIITDxK98DGMmGb4CUoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ok0oojuiF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efx36hBthISNVU8NZv3Ue0mGBOIicofmnhkP6AsHDueuNmf
 hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z
 jTMqzIx750NisoM27S+7ErwiTumrZjUTSY4/gzSGGmi62tRboO/e5ah71Sd6P9aNZuYVXGIp
 n1CkM+bhMguAJeXhWqySeMCNLiz4rCONzi0vLJ0N5wo9jDo93v9e4lVuWh6PB0wbJZCfiL1a
 kjOvw8X/IVUIHahca5wZcS2Ftguyq/jU9/iU5g4c+ZzX3S4TyfflAkGWKJa9zqFfJQE+U3nB
 aqmTA==
IronPort-HdrOrdr: A9a23:2mALQa0+6sbB2B2yhHGLJgqjBdJxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp
 uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6
 Dsm/av6gDQD0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G
 DZm0ihj5/T+c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd
 HQq1MLPth16VnWYmapyCGdkDXI4XIL0TvP2FWYiXzsrYjQQy87MdNIgcZ8fgHC40Qtkdlg2O
 YTtljp/6Z/PFflpmDQ9tLIXxZlmg6dpmcjq/caizh6XZEFYLFcgIQD9Ad+EYsGHgj99Ic7ed
 MeRf301bJzSxe3fnrZtm5gzJiFWWkyJA6PRgw4tsmcw1Ft7QVE5npd4PZasmYL9Zo7RZUBzf
 /DKL5UmLZHSdJTRb5hBc8aKPHHRFDlcFbpCia/MF7nHKYINzbmsJjs+og44+msZdgh0IYyop
 LcS1lV3FRCNH4GMff+nKGjzyq9A1lUBV/Wu4NjDtlCy/HBrYPQQGy+oAtEqbrknx0daverKc
 pbdqgmR8MLFlGeabqh7zeOJaW6FkNuIfH9muxLL25m8fi7XbHCh6j8TMv5AobLPHINZl7fa0
 FzLwQbYv8wo3yWZg==
X-IronPort-AV: E=Sophos;i="5.95,163,1661832000"; 
   d="scan'208";a="82526224"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=euSDPsdf/eRCb8vW4KtcMnt6pFEyEGBzrtym93wno6e/MiZsjSmL8nybtFl16MH7pXi+30ud2OtGzScFEuzBCa9aPLBPOmWIgIuDS56D6TyYKXnxSxmnmzpraE9ELMTQDu8CsJzjlbPNCVMnvMCqR7a24tr660lMbrDR3SUro1xDnhUnWx31UpY7bDNAOSN3YyO6aG1dnQTIlWc2DuQKSjqCjQps6KzeGcAQJajM+hF2KXpQnvrtrV7Wx+n+OrJNHx7IDOMSR6XUbkbSzYwu/wPTSxSG7ZtUQu0eGkt0e+UA/z3YnzGk0hOJpNf18pikM45x/0g2hZziJ8ymFQG+Gg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TqMqzPuCSglOGtU5MOkOsCLR9mksTpAyA5QPdJyClHs=;
 b=C5Toj/0HdL3fKMWJlW7W5sBrJCgU9KJSnADb9KuicBbGlTCaKLbNHqvpAh63lf3bC+5S+DjOgrW4B8PgBsQMx6hPwUwt2mYLXgX9+YAiZklBu45piAzrZNDgxZNwV6DHHxhzkiEctFYbwM3GiXGEpBuRK6BocUPJeF5Sf+hQdk7LRRPvFrmNw8c0gX2fBU0iAvI1urirrTdswpQqi0js9voyGTdQ1FNDHXIZpKzjVOKD5qo1q7jSBLIG5DnKEWFIvfX4i8nlDN6IL9Pu+zH1PZi3qolUO4X/s+OPwca0SXllzfTtMvq/Tb4t7XQ6jP3hd9E03jICbDOHocWpdKf6kA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TqMqzPuCSglOGtU5MOkOsCLR9mksTpAyA5QPdJyClHs=;
 b=iIw/4ZE9JZ7mXcUzNNMcptVuE+PzJMX2aF8sue2yiuolqFC3Qbv8ygyLjDv5TbDS2elc8uLaKRsIvF/0A4dZfBdEk0U3CNmLKxHFQ+HnkJCM1DS+2mxMKlvfwUHd4YMBfdFnYC5h1S9JQObc47UUZ2AH7kXXD7iSEAkbHHzk0QI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 6 Oct 2022 11:51:10 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH v2][4.17] EFI: don't convert memory marked for runtime
 use to ordinary RAM
Message-ID: <Yz6lDnBWcIVAe7o+@Air-de-Roger>
References: <ca557de7-88e9-bf2b-0f5e-6a42dca3f9f7@suse.com>
 <Yz6XgVMd/a/XU7jr@Air-de-Roger>
 <187834a6-6fcb-6e84-1247-ed7f4e23d417@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <187834a6-6fcb-6e84-1247-ed7f4e23d417@suse.com>
X-ClientProxiedBy: LO2P265CA0351.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:d::27) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6386:EE_
X-MS-Office365-Filtering-Correlation-Id: 3c5efaf8-3ed6-44da-f099-08daa7804f2f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AXErx0KS0wNmY86V8yDPTOjkDhcXDmvSNXJWiQmG5UVfFGatUVYeBUH5gJZAh9zumAZ9TlZ/8njnGgggAARF4eJ6TG9zsDSv90oKToUF6OCp+dOxgDec5uQlzcngHFtwCussxeWz5hSIbkD9fnFnivH8wnT+SPSs9PQK0eNTJf4vJArFrgn/YPc6J+bzMh8sA9+IuYerJTPVNDb8cPy9EgpI790TYZd/FsoldXO17xlEsdDzj541Ph5xc6jZIqcKOYZq5xNUqAK3q8SFliK7f3CbJzTZv54YM9JR9NoIaDGgP9LP5rmjAzi3oBuFIFZsg0rhbIArsTqoMichGbZbwr9xQkZJ+3Y4ZgeLoZNZWYQREtnTgmaWK7LRywaFe87UV6qs2frovsD+3T7i2DQ9hs0HmaKcZWZd5d2xs/a4R856hgg+PQtvTVTMKFomRN8L/w6mfmSmBOp0Mx/LJ11SL8bUtCpNBw6y9wpPWCwI44vfCWxMKQX7oWlyREV79r6PmEcmGeMO7YVdAp5CWNQkyNUbyrCEHhejp96ukAzSx30wOB89N1GbgDJ9W9U+B3BoH/Ox4Q8WnK4GoK8UGOfe8nt9m1b+2iQ7QKE+4qJMIa1337ZUXnsqVtBOFIAo5ilDs391cR32XMgDLj17ZgwJoAv6rq6m3UZutRPm/hRynJYZsrZBQW34kyb5nmLMlBpyLQUE6NFv1+tDntYCWjegIA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(376002)(366004)(346002)(136003)(39860400002)(451199015)(6916009)(33716001)(478600001)(85182001)(2906002)(8936002)(6666004)(66946007)(316002)(86362001)(8676002)(66476007)(26005)(38100700002)(4326008)(54906003)(5660300002)(66556008)(53546011)(82960400001)(6486002)(9686003)(6512007)(41300700001)(6506007)(186003)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?blpRK0g0UnBxVTduNis1UDVRZnFCRkh1ZVV3MHQxNzlzSW43QXpkVTcveTNX?=
 =?utf-8?B?dVFYRjdnclpZeURxT3NxV0ZoeS9BRk9QTmN3Mk55UXMyMnJzNytoVmFDR2w3?=
 =?utf-8?B?c2N0ajVOazFFYUZkbVJsVVJtNEZ6em5VWFg2aU84QVphSERxWFBDRXJjNzBi?=
 =?utf-8?B?Z0h1dDY5K3RPc0pPVjlCMzFpYmNpaENWekkzM1UzZ29lQkVVQzljRDFIb1pW?=
 =?utf-8?B?TW53eWdhMTdXYWhmamNiNVFveVdPL2owTlV5RXBOVVJuZ0U4Y2c4eXRLRGpu?=
 =?utf-8?B?U1Q2dzVOYjVwMjR5emhVcXk2RGQ5VVNyM0hrWkxSNktNTm1seFg0SW5pa0R5?=
 =?utf-8?B?aE1vNVBwLzRRYm9RbWcrT1ZwUmpsbGxUUVhVZWM1aEUrVDdaMTBsaTFyZ0F2?=
 =?utf-8?B?aHJJN0lEVWZGeDlRcG1nU3JFMnhWazZrSkJBWlRVZjJxUTFiUDd3ZGpJOEpr?=
 =?utf-8?B?OG5zc1grN0kydDlkMDFsYUhKdWRkcXZZMmJ3MmgvMXVmbmcxeGtRUnp1Z1Y2?=
 =?utf-8?B?T05PcjM0RmlFQWkyZFF6QzlwY2JvcjFNMXJRK3VUWUVRV3p5QkF5SmVyZUhv?=
 =?utf-8?B?MjE3V2h3K1NwTkNIWlJjeTk4ZFBFeGVuc2ZYQTdHenBtNmlmdXBKQmd3VHk2?=
 =?utf-8?B?K2hROVM2Z0NHZTF0TkgwZHBmUU1KYlVEMnB0eFR0ZWVBV3JvZ1hYTnZibkJU?=
 =?utf-8?B?aSttTlRlQ1d6K2lZU010VHl5WXZsdkZpbXEwZmhBS2hjVm5oVm5LZFV3Qndk?=
 =?utf-8?B?TjZ3Vk40aitHSDFnNHk4bGM0WGMyNTBqQ2JPOHNSVFZFL1A5NUFlOG5UQjFk?=
 =?utf-8?B?aGVVM3JiZGphdnZtTlpmSlZoSG5DaXBINCtNbkpERUszWlFHWEdhWUdlUkVK?=
 =?utf-8?B?dy8yT01pUmpFSis5R0ZPbXpWN0g2UVovbmgvNVlPTkw3b3c3a1AybzBzYUlh?=
 =?utf-8?B?eDlSbXcyVnhVa1UzRFBvQyt0ekZHNmtMMnZHeUcwYVF3TC9wSlhXR2hpdStT?=
 =?utf-8?B?TVVUSVBYTU1xMkJGclNTd2tsakJicHhhMkNtK2lwbWJZZWtQTjhhZ1MvKzVQ?=
 =?utf-8?B?UTlxSEJvVTJYUUpLMlJwYmZleTNLS2lLTmxsQ2cwZ0tHcVRRbWRLRURONVFE?=
 =?utf-8?B?dVJEMmVabnBwOHUyM0Q2Q3YvS0ZHRjNqd2orV0doMEJPQk5VUnNJcExlL1hL?=
 =?utf-8?B?aTJkMDZEOWFMMkM4UDV3RDFVR0dVQ1l6TWJZRWgrVFlWazhRcW5vUllFcjR0?=
 =?utf-8?B?Q2lDMlBUNndLOFZpUDFyNEg2QUFmOFphK2VuYkF0T0tuMTBWcFJaL1FjZWR0?=
 =?utf-8?B?NUppVlQ2dEtwY1NyajRDb1NrbitBWVBVUFhSRmpqang4cm1oM25hcVZ0NE9n?=
 =?utf-8?B?UzBObForZHlySkQ0YnMvTGJETytVcjB5WHByMTJqUEU0SXNxbElVM0h6WGg3?=
 =?utf-8?B?MC9nR1AvRWJHeGNmbjZrOHY3cVFqVTdTcmlzSDhIcitMaVc5MHdZaElKUWQ2?=
 =?utf-8?B?MWM1bW93RmF2UEhON1RvSGY5OVNwb2M4b3pHODJ1Q05MQloxZDdReFQyam14?=
 =?utf-8?B?ei8wdlJFZnlpNWExVkhQaUVBUDBJZWZmRml2OWVVU2JPTjhiWngwNmczb3Vi?=
 =?utf-8?B?d0tOVGNZNlRRanVIUXVJbmx5cHhTSEZjcVZkSWMyMFo3cmZiWEhKNURlZElp?=
 =?utf-8?B?em5sZjA3RDBWSHV3NHJHUGQ1MnB6eDY2cFBlRFR3TjZtNTVEVmxpYzlGQ082?=
 =?utf-8?B?eTErcjZUL1ZQbjdqa1c5SEtBM2xxakJjeElmZk5aWHJ5dE8yeEtKc2RiNVVO?=
 =?utf-8?B?UE94c2Q5UVcycHBEMXhpdWJidEwxbDFpaTVTQzFxdmVlUzl0VkVBcjV2bUFJ?=
 =?utf-8?B?TXhuU1d3RENsb3RtcGxUNGd5dmJkbm1rWHNMZG9HNDgvVCttNXVUbVc5QkIv?=
 =?utf-8?B?eTFzU0orY1NobytNMFE4d09qbExyTDdpQUlFcHkvMlBBVXZBV01wMmxFR2RV?=
 =?utf-8?B?bEFtL2N4NVlhQkhyZFUvTUZvbVpLNnlrU0p1QnFyalFPd2JwWTU3Vk5MNXNK?=
 =?utf-8?B?Z1FIaEJoSkpOdkprb21xejZXZUdtTEo0c2hBNEJoTk4xMlRjZEI5aTBJWDhZ?=
 =?utf-8?B?cjhtZ0xjQVZ2eGtCdCtxUHV1Nnl5bWpkUTl6VzhXVFAySDRibVkrSzNCS21L?=
 =?utf-8?B?M2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	=?utf-8?B?QzFMc3ZPMkNlaThlVTZDZXU1K1V5ek4wL3RKRlZrSCszdGRDRGkyMHUxWjl3?=
 =?utf-8?B?Y2hDaU8rSzJmTm8yUVZidzBqbnBSNjhjM0p0cWc4MHZZWlRxTnJoU00xdjFW?=
 =?utf-8?B?UWV3N3ZtU0c1NDJqSWxwWkYvZzhpZDlaeHVueFBiZUFaZ0tqL3JrU2cwS25R?=
 =?utf-8?B?UzNNV0ZjSFUrRXE1d1NLVHNyWElOcmF1a2k0VWRVLzk5T2xDcXlWUitTMDh0?=
 =?utf-8?B?M3Q4MDNuMnZzRDkyTEJUWmNSckdQSTl5MVZzOHhlVlJ1ejhaYXZnWGx0Zk8y?=
 =?utf-8?B?MHhmc3Z5YUtTOTNVdSs4OHFQTVltTEdsT0c3d1NnRk9wb214ckhnZ08wcWVG?=
 =?utf-8?B?QjJ0aWxUbE9kWnNKdGF6MnlzNWluZVArMlVXR2pwRExqeGRJRmcvb3RXUFRG?=
 =?utf-8?B?RG14dkNLK00zaklTZWh6VTNseU9YNDI1N1RKMExaZXdvWko5c0x6SWYwZjNR?=
 =?utf-8?B?ZXEyMjFWTHBhUzJqSkd2L2pRemh1YjVGQU9VNEJGTU13eHpRME5kOUpWZk9W?=
 =?utf-8?B?RDZydWUweE5iQWx6d3ZCTzdBWTNGKzJCRGJNT1Z2TVBaSnFrQ3FNWmMrdGcw?=
 =?utf-8?B?dTRaQi9PV2RRd3orMFVFY3pEQWFrMEJ4dkJVY3BsSU1QMnlnR3pvS1htL1Ez?=
 =?utf-8?B?cHBiZTZ5NUpvR0NGUVVrM1pyMUpDR2lJM2ZRMmtlcjNkMEhpNFYxUVR5SmZC?=
 =?utf-8?B?eG1hTDcrS0JPRGZlazRFc1A3bFovblQ1bkxtVkZES1o2ZlUzajJwZi8ydFd4?=
 =?utf-8?B?ekhIZ0h6UXByQ2lXbENlZmFIWWdaK1g2YkkxNlVPK0ZrTk1vRTkzN1FsVlc0?=
 =?utf-8?B?OXI5ZUI0d2JUL3UxbGJtUHdWWEluVHEyM212RWRQSHFQM1VYV1lzY2JZNnZw?=
 =?utf-8?B?eDlJVDRsem52M0ZmZTBIMTJ2eDk2VjJjeTJhOU9PbG9yK3RoQkRNY2hBb0pl?=
 =?utf-8?B?b3ZrY0dtVFp4a0pUVTRWajdQeUZrcTg4OUViN1Q3SzVTSGtZMkNNSEZEVGM2?=
 =?utf-8?B?N2lOM1VsSTBLY0RnSVBtQ2lBTDBkTStuQk5IYkFlY1hLUnNSdmRNeGlrVUd5?=
 =?utf-8?B?YlBzVDdqRE9MMjVnbGdGRDlvem96cTRjTTl4WERFTmhEbnJlYWJ6SmZ0c1Q4?=
 =?utf-8?B?N1NPN3RIQ05KUEtDR29JQmY3Zm80dHJzZDhueCswOXN1aWFpYXZhUDNxL3FH?=
 =?utf-8?B?Yy83WDhhRkw5QXFYU3V3Zmw2SHRIVmxxbU5XTG9EdmducGluYjZmTUJPZEww?=
 =?utf-8?B?U05IeDVxemRGUXJTNTJXTlZRYm9jRVI0OStQNGRnSzZTMGdFRXJ4YmpnUTkw?=
 =?utf-8?B?bEFnWkltbG82WDRxdHNTYjdkVU11YzdDUk5GRlcrZkREdTdYc3pJb3paTEdy?=
 =?utf-8?B?cHU0bklqY1J1UFRHNUlYQndvRXJ1YjJwUTR0OG92VktmUktXNm50Yk00K296?=
 =?utf-8?B?VUZJV0lCWmJndjMyRW5kcFVEL1ZIVlcvSWdBSGdxd0JCeGJJbklnSkFKQTBF?=
 =?utf-8?Q?zyVXyU=3D?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c5efaf8-3ed6-44da-f099-08daa7804f2f
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 09:51:15.5040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kc1luz7rD5lwPcEZZ8NXwcukWHaC3DosARPz4Hlyyvs27E/9uVulVPBlR/0wyui2LlBjVzYHCAOdt0inEAqIBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6386

On Thu, Oct 06, 2022 at 10:58:43AM +0200, Jan Beulich wrote:
> On 06.10.2022 10:53, Roger Pau Monné wrote:
> > On Thu, Oct 06, 2022 at 10:40:56AM +0200, Jan Beulich wrote:
> >> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> >> higher priority than the type of the range. To avoid accessing memory at
> >> runtime which was re-used for other purposes, make
> >> efi_arch_process_memory_map() follow suit. While on x86 in theory the
> >> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
> >> E820_ACPI memory there (and it would be a bug if the Dom0 kernel tried
> >> to do so, bypassing Xen's memory management), hence that type's handling
> > 
> > Strictly speaking I don't think dom0 needs to bypass Xen's memory
> > management, just overwriting the page would be bad enough for runtime
> > services to not work correctly I would think.
> 
> Then how about:
> 
> "While on x86 in theory the same would apply to EfiACPIReclaimMemory, we don't
>  actually "reclaim" or clobber E820_ACPI memory there (and it would be a bug if
>  the Dom0 kernel tried to reclaim the range, bypassing Xen's memory management,
>  plus it would be at least bogus if it clobbered that space), hence that type's
>  handling can be left alone."
> 
> I didn't think the clobbering aspect needed pointing out, as the same applies
> to all other memory which Dom0 is able to access beyond its actual allocation.

I think it makes it clear that just clobbering it from dom0 could
cause issues to runtime services.  I guess it can be extrapolated that
clobbering is also bad if reclaiming is.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 10:15:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 10:15:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416812.661503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNu3-00007L-6t; Thu, 06 Oct 2022 10:14:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416812.661503; Thu, 06 Oct 2022 10:14:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogNu3-00007E-4A; Thu, 06 Oct 2022 10:14:55 +0000
Received: by outflank-mailman (input) for mailman id 416812;
 Thu, 06 Oct 2022 10:14:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y3UN=2H=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ogNu2-000078-3Q
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 10:14:54 +0000
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com
 [2607:f8b0:4864:20::1035])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b73cbb14-455f-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 12:14:52 +0200 (CEST)
Received: by mail-pj1-x1035.google.com with SMTP id
 p3-20020a17090a284300b0020a85fa3ffcso3925172pjf.2
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 03:14:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b73cbb14-455f-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=cuxvjCmNdZPr7Sj2qPmwq+yZEk2qpO5b4TWiZE0kSQ8=;
        b=NIm738FSTJ44NTtMD51cMuunDkOjl+WuP2Qs05qapjajATeJwLJMe8JkFYhkBFDdUg
         oXwYovMuKljBFW7/fafxkB9oh04QxvQaQzBVCTn9WSpfwnGEVJqi0hD+5wGgPDKyxgZD
         HczV0Xd5O49JmsMF0GEzT9Xh5/o8JlCU3nbsdnbEvEJKO5Mcc0DAyn4WYi8AVw6OVr0M
         +/m0AaLnS8Jf1N4ffKIpl38FJkPrB60EK2kxYGDYvnCACiR+6OKF2wxC/zu5wxBq291F
         e5/tm2CBLoUFYVlZxNrhduGLAfOYppMO61x4WHyDmv0+G2vnAxgfJqCKhvROSenKM0Wu
         y5wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=cuxvjCmNdZPr7Sj2qPmwq+yZEk2qpO5b4TWiZE0kSQ8=;
        b=iEwejtpHvXDhYTMIeXtZWz4ITd/zKaVJfzvHYBKFk4zX7ekNF5ceF+DH5XNaPwDSnx
         DMwwe/igERqTMtE2qNYsIBc03vKs52xPguXTevg9sSxBDIQD3Vr9vO4+10Bn47a9mBmh
         A7WDkCbrep8vzFwmzY5CQZsUiHqILBbZGWLq1upg1g5lMRdU9ucXCbpKsRgmNwlhP2hT
         a/68f0EPnp/xbLqMvasFn8A7Weu2oakBxS3O+6ayz2qKH3VRs2abiWyvWg9xMNzI1uxv
         ipylgtf2iOA4F7MqH6vFB5mrbyvuJggxvv1QzzHyZCVBnwdC9mzg8CftQr7Xns8L6FWA
         Gs7w==
X-Gm-Message-State: ACrzQf1Fyhbn+EYdJmXlNZRc67UhtoE3dKHi382SyeCiLbILpx2wuWnC
	rhW+qL9Ld15iNqtf/lUqWa4dZ4DKoCAGObR6JoE=
X-Google-Smtp-Source: AMsMyM62ls2pHIzwEujT5MyEJtqf4OT9tpKQTXfY1B+lLRVwUzHIpu3TGlI4HrK1P5jd8k2V4i9RxFoiEFye4wIlSCM=
X-Received: by 2002:a17:90a:641:b0:202:8568:4180 with SMTP id
 q1-20020a17090a064100b0020285684180mr4543933pje.227.1665051291012; Thu, 06
 Oct 2022 03:14:51 -0700 (PDT)
MIME-Version: 1.0
References: <20221005174823.1800761-1-olekstysh@gmail.com> <20221005174823.1800761-2-olekstysh@gmail.com>
 <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com> <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
In-Reply-To: <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Thu, 6 Oct 2022 13:14:39 +0300
Message-ID: <CAPD2p-kuXfeQ8G63tSwi4H1Wz8ygwJnp3q1ZXFHi+k+knwT-EA@mail.gmail.com>
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in xen_grant_dma_map(unmap)_page()
To: Juergen Gross <jgross@suse.com>, Xenia Ragiadakou <burzalodowa@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini <sstabellini@kernel.org>
Content-Type: multipart/alternative; boundary="000000000000bbd13205ea5af696"

--000000000000bbd13205ea5af696
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 6, 2022 at 11:05 AM Juergen Gross <jgross@suse.com> wrote:

> On 06.10.22 09:35, Xenia Ragiadakou wrote:
>


Hello Xenia, Juergen

[sorry for the possible format issues]



> >
> > On 10/5/22 20:48, Oleksandr Tyshchenko wrote:
> >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>
> >> Take page offset into the account when calculating the number of pages
> >> to be granted.
> >>
> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict memory
> access
> >> under Xen")
> >> ---
> >>   drivers/xen/grant-dma-ops.c | 5 +++--
> >>   1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> >> index 8973fc1e9ccc..1998d0e8ce82 100644
> >> --- a/drivers/xen/grant-dma-ops.c
> >> +++ b/drivers/xen/grant-dma-ops.c
> >> @@ -153,7 +153,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
> device
> >> *dev, struct page *page,
> >>                        unsigned long attrs)
> >>   {
> >>       struct xen_grant_dma_data *data;
> >> -    unsigned int i, n_pages = PFN_UP(size);
> >> +    unsigned int i, n_pages = PFN_UP(offset + size);
> >
> > Here, why do we use PFN_UP and not XEN_PFN_UP?
> > Also, since the variable 'n_pages' seems to refer to the number of
> grants
> > (unless I got it all entirely wrong ...), wouldn't it be more suitable
> to call
> > explicitly gnttab_count_grant()?
>
> Good point.
>

+1


>
> I think this will need another patch for switching grant-dma-ops.c to
> use XEN_PAGE_SIZE and XEN_PAGE_SHIFT.
>

+1

I can create a separate patch for converting on top of this series, it
would be nice to clarify one point.

So I will convert PAGE_SIZE/PAGE_SHIFT to XEN_PAGE_SIZE/XEN_PAGE_SHIFT
respectively (where appropriate).

Should the PFN_UP be converted to XEN_PFN_UP *or* use
gnttab_count_grant() explicitly? Personally I would prefer the former, but
would also be ok with the latter.



>
>
> Juergen
>
>

-- 
Regards,

Oleksandr Tyshchenko

--000000000000bbd13205ea5af696
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Oct 6, 2022 at 11:05 AM Juerg=
en Gross &lt;<a href=3D"mailto:jgross@suse.com" target=3D"_blank">jgross@su=
se.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">On 06.10.22 09:35, Xenia Ragiadakou wrote:<br></blockquote><div><br><=
/div><div><br></div><div>Hello=C2=A0Xenia,=C2=A0Juergen</div><div><br></div=
><div>[sorry for the possible format issues]</div><div><br></div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; <br>
&gt; On 10/5/22 20:48, Oleksandr Tyshchenko wrote:<br>
&gt;&gt; From: Oleksandr Tyshchenko &lt;<a href=3D"mailto:oleksandr_tyshche=
nko@epam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&gt;<br>
&gt;&gt;<br>
&gt;&gt; Take page offset into the account when calculating the number of p=
ages<br>
&gt;&gt; to be granted.<br>
&gt;&gt;<br>
&gt;&gt; Signed-off-by: Oleksandr Tyshchenko &lt;<a href=3D"mailto:oleksand=
r_tyshchenko@epam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&=
gt;<br>
&gt;&gt; Fixes: d6aca3504c7d (&quot;xen/grant-dma-ops: Add option to restri=
ct memory access <br>
&gt;&gt; under Xen&quot;)<br>
&gt;&gt; ---<br>
&gt;&gt; =C2=A0 drivers/xen/grant-dma-ops.c | 5 +++--<br>
&gt;&gt; =C2=A0 1 file changed, 3 insertions(+), 2 deletions(-)<br>
&gt;&gt;<br>
&gt;&gt; diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-o=
ps.c<br>
&gt;&gt; index 8973fc1e9ccc..1998d0e8ce82 100644<br>
&gt;&gt; --- a/drivers/xen/grant-dma-ops.c<br>
&gt;&gt; +++ b/drivers/xen/grant-dma-ops.c<br>
&gt;&gt; @@ -153,7 +153,7 @@ static dma_addr_t xen_grant_dma_map_page(struc=
t device <br>
&gt;&gt; *dev, struct page *page,<br>
&gt;&gt; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned=
 long attrs)<br>
&gt;&gt; =C2=A0 {<br>
&gt;&gt; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct xen_grant_dma_data *data;<br=
>
&gt;&gt; -=C2=A0=C2=A0=C2=A0 unsigned int i, n_pages =3D PFN_UP(size);<br>
&gt;&gt; +=C2=A0=C2=A0=C2=A0 unsigned int i, n_pages =3D PFN_UP(offset + si=
ze);<br>
&gt; <br>
&gt; Here, why do we use PFN_UP and not XEN_PFN_UP?<br>
&gt; Also, since the variable &#39;n_pages&#39; seems to refer to the numbe=
r of grants <br>
&gt; (unless I got it all entirely wrong ...), wouldn&#39;t it be more suit=
able to call <br>
&gt; explicitly gnttab_count_grant()?<br>
<br>
Good point.<br></blockquote><div><br></div><div>+1<br></div><div>=C2=A0</di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I think this will need another patch for switching grant-dma-ops.c to<br>
use XEN_PAGE_SIZE and XEN_PAGE_SHIFT.<br></blockquote><div><br></div><div>+=
1<br></div><div><br></div><div>I can create a separate patch for converting=
 on top of this series, it would be nice to clarify one=C2=A0point.</div><d=
iv><br></div><div>So I will convert PAGE_SIZE/PAGE_SHIFT to XEN_PAGE_SIZE/X=
EN_PAGE_SHIFT respectively (where appropriate).</div><div><br></div><div>Sh=
ould the PFN_UP be=C2=A0converted to XEN_PFN_UP *or* use gnttab_count_grant=
()=C2=A0explicitly? Personally I would prefer the former, but would also be=
 ok with the latter.</div><div>=C2=A0</div><div>=C2=A0</div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">
<br>
<br>
Juergen<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><span style=
=3D"background-color:rgb(255,255,255)"><font size=3D"2"><span style=3D"colo=
r:rgb(51,51,51);font-family:Arial,sans-serif">Regards,</span></font></span>=
</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><div><span style=3D"backg=
round-color:rgb(255,255,255)"><font size=3D"2">Oleksandr Tyshchenko</font><=
/span></div></div></div></div></div></div></div></div>

--000000000000bbd13205ea5af696--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 10:24:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 10:24:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416819.661514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogO3E-0001d5-4z; Thu, 06 Oct 2022 10:24:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416819.661514; Thu, 06 Oct 2022 10:24:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogO3E-0001cy-1X; Thu, 06 Oct 2022 10:24:24 +0000
Received: by outflank-mailman (input) for mailman id 416819;
 Thu, 06 Oct 2022 10:24:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogO3D-0001cs-6D
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 10:24:23 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ae511b3-4561-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 12:24:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 50B121F8B0;
 Thu,  6 Oct 2022 10:24:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1E4BA13AC8;
 Thu,  6 Oct 2022 10:24:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id XhznBdWsPmPCbgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 10:24:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ae511b3-4561-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665051861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3fHVkVxTAWcYkVXviVrHSDtYowg1Eq007d+zP0+0r14=;
	b=apBWFh/dNkA2V7M7Cs0J40QYDiStbw1/fi9zRSQ7SePeJcAYQDFW6HyPapH4hdupuftUYc
	TUW3RF7RO9XeBvvVhXMReod9AbEIzSh+aLWScHLb9LEgVmm4EkiSYPZpcdtgFv/t+NxjWv
	TSd/iLQlqGAfAosCGipDZQa6jDIY84w=
Message-ID: <df17af24-632c-6087-43e0-9e4079959437@suse.com>
Date: Thu, 6 Oct 2022 12:24:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
 <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>
 <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
 <CAPD2p-kuXfeQ8G63tSwi4H1Wz8ygwJnp3q1ZXFHi+k+knwT-EA@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <CAPD2p-kuXfeQ8G63tSwi4H1Wz8ygwJnp3q1ZXFHi+k+knwT-EA@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------QJQ0BzZYEd7W3FpBoBrwyC4J"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------QJQ0BzZYEd7W3FpBoBrwyC4J
Content-Type: multipart/mixed; boundary="------------VBQYfDk6VWcgYtEKBXvgrLOD";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <df17af24-632c-6087-43e0-9e4079959437@suse.com>
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in
 xen_grant_dma_map(unmap)_page()
References: <20221005174823.1800761-1-olekstysh@gmail.com>
 <20221005174823.1800761-2-olekstysh@gmail.com>
 <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com>
 <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
 <CAPD2p-kuXfeQ8G63tSwi4H1Wz8ygwJnp3q1ZXFHi+k+knwT-EA@mail.gmail.com>
In-Reply-To: <CAPD2p-kuXfeQ8G63tSwi4H1Wz8ygwJnp3q1ZXFHi+k+knwT-EA@mail.gmail.com>

--------------VBQYfDk6VWcgYtEKBXvgrLOD
Content-Type: multipart/mixed; boundary="------------Bp8ijxsi8icv2zMYc0WPinxX"

--------------Bp8ijxsi8icv2zMYc0WPinxX
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMTI6MTQsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4g
DQo+IE9uIFRodSwgT2N0IDYsIDIwMjIgYXQgMTE6MDUgQU0gSnVlcmdlbiBHcm9zcyA8amdy
b3NzQHN1c2UuY29tIA0KPiA8bWFpbHRvOmpncm9zc0BzdXNlLmNvbT4+IHdyb3RlOg0KPiAN
Cj4gICAgIE9uIDA2LjEwLjIyIDA5OjM1LCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPiAN
Cj4gDQo+IA0KPiBIZWxsb8KgWGVuaWEswqBKdWVyZ2VuDQo+IA0KPiBbc29ycnkgZm9yIHRo
ZSBwb3NzaWJsZSBmb3JtYXQgaXNzdWVzXQ0KPiANCj4gICAgICA+DQo+ICAgICAgPiBPbiAx
MC81LzIyIDIwOjQ4LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4gICAgICA+PiBG
cm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5j
b20NCj4gICAgIDxtYWlsdG86b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+Pg0KPiAg
ICAgID4+DQo+ICAgICAgPj4gVGFrZSBwYWdlIG9mZnNldCBpbnRvIHRoZSBhY2NvdW50IHdo
ZW4gY2FsY3VsYXRpbmcgdGhlIG51bWJlciBvZiBwYWdlcw0KPiAgICAgID4+IHRvIGJlIGdy
YW50ZWQuDQo+ICAgICAgPj4NCj4gICAgICA+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIg
VHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20NCj4gICAgIDxtYWls
dG86b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+Pg0KPiAgICAgID4+IEZpeGVzOiBk
NmFjYTM1MDRjN2QgKCJ4ZW4vZ3JhbnQtZG1hLW9wczogQWRkIG9wdGlvbiB0byByZXN0cmlj
dCBtZW1vcnkNCj4gICAgIGFjY2Vzcw0KPiAgICAgID4+IHVuZGVyIFhlbiIpDQo+ICAgICAg
Pj4gLS0tDQo+ICAgICAgPj4gwqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgNSAr
KystLQ0KPiAgICAgID4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIg
ZGVsZXRpb25zKC0pDQo+ICAgICAgPj4NCj4gICAgICA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+
ICAgICAgPj4gaW5kZXggODk3M2ZjMWU5Y2NjLi4xOTk4ZDBlOGNlODIgMTAwNjQ0DQo+ICAg
ICAgPj4gLS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+ICAgICAgPj4gKysr
IGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+ICAgICAgPj4gQEAgLTE1Myw3ICsx
NTMsNyBAQCBzdGF0aWMgZG1hX2FkZHJfdCB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKHN0cnVj
dCBkZXZpY2UNCj4gICAgICA+PiAqZGV2LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCj4gICAgICA+
PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25l
ZCBsb25nIGF0dHJzKQ0KPiAgICAgID4+IMKgIHsNCj4gICAgICA+PiDCoMKgwqDCoMKgIHN0
cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+ICAgICAgPj4gLcKgwqDCoCB1bnNp
Z25lZCBpbnQgaSwgbl9wYWdlcyA9IFBGTl9VUChzaXplKTsNCj4gICAgICA+PiArwqDCoMKg
IHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gUEZOX1VQKG9mZnNldCArIHNpemUpOw0KPiAg
ICAgID4NCj4gICAgICA+IEhlcmUsIHdoeSBkbyB3ZSB1c2UgUEZOX1VQIGFuZCBub3QgWEVO
X1BGTl9VUD8NCj4gICAgICA+IEFsc28sIHNpbmNlIHRoZSB2YXJpYWJsZSAnbl9wYWdlcycg
c2VlbXMgdG8gcmVmZXIgdG8gdGhlIG51bWJlciBvZiBncmFudHMNCj4gICAgICA+ICh1bmxl
c3MgSSBnb3QgaXQgYWxsIGVudGlyZWx5IHdyb25nIC4uLiksIHdvdWxkbid0IGl0IGJlIG1v
cmUgc3VpdGFibGUgdG8NCj4gICAgIGNhbGwNCj4gICAgICA+IGV4cGxpY2l0bHkgZ250dGFi
X2NvdW50X2dyYW50KCk/DQo+IA0KPiAgICAgR29vZCBwb2ludC4NCj4gDQo+IA0KPiArMQ0K
PiANCj4gDQo+ICAgICBJIHRoaW5rIHRoaXMgd2lsbCBuZWVkIGFub3RoZXIgcGF0Y2ggZm9y
IHN3aXRjaGluZyBncmFudC1kbWEtb3BzLmMgdG8NCj4gICAgIHVzZSBYRU5fUEFHRV9TSVpF
IGFuZCBYRU5fUEFHRV9TSElGVC4NCj4gDQo+IA0KPiArMQ0KPiANCj4gSSBjYW4gY3JlYXRl
IGEgc2VwYXJhdGUgcGF0Y2ggZm9yIGNvbnZlcnRpbmcgb24gdG9wIG9mIHRoaXMgc2VyaWVz
LCBpdCB3b3VsZCBiZSANCj4gbmljZSB0byBjbGFyaWZ5IG9uZcKgcG9pbnQuDQo+IA0KPiBT
byBJIHdpbGwgY29udmVydCBQQUdFX1NJWkUvUEFHRV9TSElGVCB0byBYRU5fUEFHRV9TSVpF
L1hFTl9QQUdFX1NISUZUIA0KPiByZXNwZWN0aXZlbHkgKHdoZXJlIGFwcHJvcHJpYXRlKS4N
Cg0KWWVzLCB0aGF0IHdvdWxkIGJlIHRoZSBpZGVhLg0KDQo+IFNob3VsZCB0aGUgUEZOX1VQ
IGJlwqBjb252ZXJ0ZWQgdG8gWEVOX1BGTl9VUCAqb3IqIHVzZSANCj4gZ250dGFiX2NvdW50
X2dyYW50KCnCoGV4cGxpY2l0bHk/IFBlcnNvbmFsbHkgSSB3b3VsZCBwcmVmZXIgdGhlIGZv
cm1lciwgYnV0IHdvdWxkIA0KPiBhbHNvIGJlIG9rIHdpdGggdGhlIGxhdHRlci4NCg0KSSBh
Z3JlZSBYRU5fUEZOX1VQIHdvdWxkIGJlIGJldHRlciwgZXNwZWNpYWxseSBhcyBYRU5fUEFH
RV9TSVpFL1hFTl9QQUdFX1NISUZUDQp3aWxsIGJlIHVzZWQgaW4gdGhlIHNhbWUgZnVuY3Rp
b25zLg0KDQoNCkp1ZXJnZW4NCg==
--------------Bp8ijxsi8icv2zMYc0WPinxX
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Bp8ijxsi8icv2zMYc0WPinxX--

--------------VBQYfDk6VWcgYtEKBXvgrLOD--

--------------QJQ0BzZYEd7W3FpBoBrwyC4J
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+rNQFAwAAAAAACgkQsN6d1ii/Ey9W
1Af/XIsM2iwWM+ozYhxCwR01i0jqkLtvW3nB3Y01DLub/jopoGswxB4E/OpzF7dMmkI1X4LA8Zs6
Gtjr4kIndL/nHYLLkKQl5JG2Wf0EBr2T96c9L8e2l3Liv4HhofZn1AuU/5IYTVJq512xkFtLw4C5
NAnKgmPhvwSiBsTPlH1CgUGXsUA1GaMPDkyjpZOLCnQaIzAecUnyQdNgLprM4KmB7alOisPNil9e
zybQEcUAo+0mVvlx9GNGYoaadcOVGmGp+9hm+TwHaqOOw4aojG2vu3cHRVzeKiHv0CiHob7hSnHX
1WfG1Zxh6aPm52LbRPWPJ9VzqnC+1p0n2FiIVDNsTA==
=ZOVZ
-----END PGP SIGNATURE-----

--------------QJQ0BzZYEd7W3FpBoBrwyC4J--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 10:31:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 10:31:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416828.661524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogO9q-000391-0X; Thu, 06 Oct 2022 10:31:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416828.661524; Thu, 06 Oct 2022 10:31:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogO9p-00038u-U1; Thu, 06 Oct 2022 10:31:13 +0000
Received: by outflank-mailman (input) for mailman id 416828;
 Thu, 06 Oct 2022 10:31:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y3UN=2H=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ogO9o-00038o-9x
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 10:31:12 +0000
Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com
 [2607:f8b0:4864:20::435])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa1ec159-4561-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 12:31:03 +0200 (CEST)
Received: by mail-pf1-x435.google.com with SMTP id h13so223252pfr.7
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 03:31:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa1ec159-4561-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=1Ww3gjQttemMvIHddNRqftrl1gNSIGxQLuevdJrysL8=;
        b=HoIsPr/KBkYizk+hFXFzdwxnJlvI1M89/s8+FnuJkPVSQkAAv+FY8Ob/Cad3AeYWqj
         fCH+8GpdkSfYzMeTDz829E1JiupKJAi3Y2y18eGT17LcatoPN7GDcS9QQE43iTbCRKOq
         NTfizCD5eaeznd0J/KggGppR55BY3luq1u/7An+vu/Wg4p/SUBszfhsihl8lsC8fAs+J
         BNqKqxLDoTkEO9k4/Itqgsq7cgQbbUto486WFLXXhZZy+bA829Uq5IFj30kR12u9hmMK
         RXpNnlYwf20Bd8IXZRLr2UCuyzNkV09VQfvWCvRbDq94BSVer+qKKAbffwreOGgGs/Fc
         bmHw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=1Ww3gjQttemMvIHddNRqftrl1gNSIGxQLuevdJrysL8=;
        b=fSUeWGjBJM3zFxZaWJXnFfVsQdjpBMkbqsblyYjXFu5TW2l4ZbFRqlSKESvzglV7ol
         67dVWl/EZxAeuBya894WGetYQZI22azk4CTL/32/X7RlZx0qFB3IXNGxv+O6FSsIaoHK
         1cLrtLjdzYKrXjBX+kDwsDO1WvpGsIRWHthXcWMfZxi2axCq3G16RQUPCG4qENuaLNq2
         CJz5FxHXy0uRx4HSTJdMjxrgMAQpmXeBaZA2Vgq9Yyu5S4SUoC6ANwdVufJQXV1bJ1lr
         C8pyfHuIWMxNosldZL7SJBkoC+VRMbsaId3BCvG9NvP+0BqKaIstIrRR/mgNShEs6IBa
         P4Pw==
X-Gm-Message-State: ACrzQf1JPbpdU/Ip0Hl2Wvtns8c90GJriItAn1RiBseNmHjq9CX+XoeC
	2+1mYAs9CfL9jxc/pIcNVhbsfKQjsC/a9edl+rA=
X-Google-Smtp-Source: AMsMyM6L+DEpT48DS4gbf4t/3OiHw5sfQ2SvIdhlH+auuTw2ff8mBoWbGV6mdu6IIUFWaOHqTkXeU9RnFkT1tV6Mgyk=
X-Received: by 2002:a63:e806:0:b0:44b:d45b:b8a2 with SMTP id
 s6-20020a63e806000000b0044bd45bb8a2mr3893127pgh.14.1665052262206; Thu, 06 Oct
 2022 03:31:02 -0700 (PDT)
MIME-Version: 1.0
References: <20221005174823.1800761-1-olekstysh@gmail.com> <20221005174823.1800761-2-olekstysh@gmail.com>
 <55a22602-3ae8-b09b-61c9-1fc7c01235fc@gmail.com> <85471e4e-086a-6229-7fd1-e1d5556b94ed@suse.com>
 <CAPD2p-kuXfeQ8G63tSwi4H1Wz8ygwJnp3q1ZXFHi+k+knwT-EA@mail.gmail.com> <df17af24-632c-6087-43e0-9e4079959437@suse.com>
In-Reply-To: <df17af24-632c-6087-43e0-9e4079959437@suse.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Thu, 6 Oct 2022 13:30:50 +0300
Message-ID: <CAPD2p-mgxSw+yoYa9tnabWDo6uJCjBjJ-6DncvwvXqP3HkEx6g@mail.gmail.com>
Subject: Re: [PATCH 1/2] xen/virtio: Fix n_pages calculation in xen_grant_dma_map(unmap)_page()
To: Juergen Gross <jgross@suse.com>
Cc: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org, 
	linux-kernel@vger.kernel.org, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini <sstabellini@kernel.org>
Content-Type: multipart/alternative; boundary="0000000000009f0f4f05ea5b30c5"

--0000000000009f0f4f05ea5b30c5
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 6, 2022 at 1:24 PM Juergen Gross <jgross@suse.com> wrote:

Hello Juergen

[sorry for the possible format issues]

On 06.10.22 12:14, Oleksandr Tyshchenko wrote:
> >
> >
> > On Thu, Oct 6, 2022 at 11:05 AM Juergen Gross <jgross@suse.com
> > <mailto:jgross@suse.com>> wrote:
> >
> >     On 06.10.22 09:35, Xenia Ragiadakou wrote:
> >
> >
> >
> > Hello Xenia, Juergen
> >
> > [sorry for the possible format issues]
> >
> >      >
> >      > On 10/5/22 20:48, Oleksandr Tyshchenko wrote:
> >      >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
> >     <mailto:oleksandr_tyshchenko@epam.com>>
> >      >>
> >      >> Take page offset into the account when calculating the number of
> pages
> >      >> to be granted.
> >      >>
> >      >> Signed-off-by: Oleksandr Tyshchenko <
> oleksandr_tyshchenko@epam.com
> >     <mailto:oleksandr_tyshchenko@epam.com>>
> >      >> Fixes: d6aca3504c7d ("xen/grant-dma-ops: Add option to restrict
> memory
> >     access
> >      >> under Xen")
> >      >> ---
> >      >>   drivers/xen/grant-dma-ops.c | 5 +++--
> >      >>   1 file changed, 3 insertions(+), 2 deletions(-)
> >      >>
> >      >> diff --git a/drivers/xen/grant-dma-ops.c
> b/drivers/xen/grant-dma-ops.c
> >      >> index 8973fc1e9ccc..1998d0e8ce82 100644
> >      >> --- a/drivers/xen/grant-dma-ops.c
> >      >> +++ b/drivers/xen/grant-dma-ops.c
> >      >> @@ -153,7 +153,7 @@ static dma_addr_t
> xen_grant_dma_map_page(struct device
> >      >> *dev, struct page *page,
> >      >>                        unsigned long attrs)
> >      >>   {
> >      >>       struct xen_grant_dma_data *data;
> >      >> -    unsigned int i, n_pages = PFN_UP(size);
> >      >> +    unsigned int i, n_pages = PFN_UP(offset + size);
> >      >
> >      > Here, why do we use PFN_UP and not XEN_PFN_UP?
> >      > Also, since the variable 'n_pages' seems to refer to the number
> of grants
> >      > (unless I got it all entirely wrong ...), wouldn't it be more
> suitable to
> >     call
> >      > explicitly gnttab_count_grant()?
> >
> >     Good point.
> >
> >
> > +1
> >
> >
> >     I think this will need another patch for switching grant-dma-ops.c to
> >     use XEN_PAGE_SIZE and XEN_PAGE_SHIFT.
> >
> >
> > +1
> >
> > I can create a separate patch for converting on top of this series, it
> would be
> > nice to clarify one point.
> >
> > So I will convert PAGE_SIZE/PAGE_SHIFT to XEN_PAGE_SIZE/XEN_PAGE_SHIFT
> > respectively (where appropriate).
>
> Yes, that would be the idea.
>
> > Should the PFN_UP be converted to XEN_PFN_UP *or* use
> > gnttab_count_grant() explicitly? Personally I would prefer the former,
> but would
> > also be ok with the latter.
>
> I agree XEN_PFN_UP would be better, especially as
> XEN_PAGE_SIZE/XEN_PAGE_SHIFT
> will be used in the same functions.
>


Thanks for the clarification.



>
>
> Juergen
>


-- 
Regards,

Oleksandr Tyshchenko

--0000000000009f0f4f05ea5b30c5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Oct 6, 2022 at 1:24 PM Juerge=
n Gross &lt;<a href=3D"mailto:jgross@suse.com">jgross@suse.com</a>&gt; wrot=
e:<br></div><div dir=3D"ltr" class=3D"gmail_attr"><br></div><div dir=3D"ltr=
" class=3D"gmail_attr">Hello Juergen<br></div><div dir=3D"ltr" class=3D"gma=
il_attr"><br></div><div dir=3D"ltr" class=3D"gmail_attr">[sorry for the pos=
sible format issues]<br></div><div dir=3D"ltr" class=3D"gmail_attr"><br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">On 06.10.22 12:14, Ole=
ksandr Tyshchenko wrote:<br>
&gt; <br>
&gt; <br>
&gt; On Thu, Oct 6, 2022 at 11:05 AM Juergen Gross &lt;<a href=3D"mailto:jg=
ross@suse.com" target=3D"_blank">jgross@suse.com</a> <br>
&gt; &lt;mailto:<a href=3D"mailto:jgross@suse.com" target=3D"_blank">jgross=
@suse.com</a>&gt;&gt; wrote:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0On 06.10.22 09:35, Xenia Ragiadakou wrote:<br>
&gt; <br>
&gt; <br>
&gt; <br>
&gt; Hello=C2=A0Xenia,=C2=A0Juergen<br>
&gt; <br>
&gt; [sorry for the possible format issues]<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; On 10/5/22 20:48, Oleksandr Tyshchenko wrote:=
<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; From: Oleksandr Tyshchenko &lt;<a href=3D=
"mailto:oleksandr_tyshchenko@epam.com" target=3D"_blank">oleksandr_tyshchen=
ko@epam.com</a><br>
&gt;=C2=A0 =C2=A0 =C2=A0&lt;mailto:<a href=3D"mailto:oleksandr_tyshchenko@e=
pam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; Take page offset into the account when ca=
lculating the number of pages<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; to be granted.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; Signed-off-by: Oleksandr Tyshchenko &lt;<=
a href=3D"mailto:oleksandr_tyshchenko@epam.com" target=3D"_blank">oleksandr=
_tyshchenko@epam.com</a><br>
&gt;=C2=A0 =C2=A0 =C2=A0&lt;mailto:<a href=3D"mailto:oleksandr_tyshchenko@e=
pam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; Fixes: d6aca3504c7d (&quot;xen/grant-dma-=
ops: Add option to restrict memory<br>
&gt;=C2=A0 =C2=A0 =C2=A0access<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; under Xen&quot;)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; ---<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; =C2=A0 drivers/xen/grant-dma-ops.c | 5 ++=
+--<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; =C2=A0 1 file changed, 3 insertions(+), 2=
 deletions(-)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; diff --git a/drivers/xen/grant-dma-ops.c =
b/drivers/xen/grant-dma-ops.c<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; index 8973fc1e9ccc..1998d0e8ce82 100644<b=
r>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; --- a/drivers/xen/grant-dma-ops.c<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; +++ b/drivers/xen/grant-dma-ops.c<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; @@ -153,7 +153,7 @@ static dma_addr_t xen=
_grant_dma_map_page(struct device<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; *dev, struct page *page,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 unsigned long attrs)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; =C2=A0 {<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct xen=
_grant_dma_data *data;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; -=C2=A0=C2=A0=C2=A0 unsigned int i, n_pag=
es =3D PFN_UP(size);<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;&gt; +=C2=A0=C2=A0=C2=A0 unsigned int i, n_pag=
es =3D PFN_UP(offset + size);<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; Here, why do we use PFN_UP and not XEN_PFN_UP=
?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; Also, since the variable &#39;n_pages&#39; se=
ems to refer to the number of grants<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; (unless I got it all entirely wrong ...), wou=
ldn&#39;t it be more suitable to<br>
&gt;=C2=A0 =C2=A0 =C2=A0call<br>
&gt;=C2=A0 =C2=A0 =C2=A0 &gt; explicitly gnttab_count_grant()?<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0Good point.<br>
&gt; <br>
&gt; <br>
&gt; +1<br>
&gt; <br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0I think this will need another patch for switching =
grant-dma-ops.c to<br>
&gt;=C2=A0 =C2=A0 =C2=A0use XEN_PAGE_SIZE and XEN_PAGE_SHIFT.<br>
&gt; <br>
&gt; <br>
&gt; +1<br>
&gt; <br>
&gt; I can create a separate patch for converting on top of this series, it=
 would be <br>
&gt; nice to clarify one=C2=A0point.<br>
&gt; <br>
&gt; So I will convert PAGE_SIZE/PAGE_SHIFT to XEN_PAGE_SIZE/XEN_PAGE_SHIFT=
 <br>
&gt; respectively (where appropriate).<br>
<br>
Yes, that would be the idea.<br>
<br>
&gt; Should the PFN_UP be=C2=A0converted to XEN_PFN_UP *or* use <br>
&gt; gnttab_count_grant()=C2=A0explicitly? Personally I would prefer the fo=
rmer, but would <br>
&gt; also be ok with the latter.<br>
<br>
I agree XEN_PFN_UP would be better, especially as XEN_PAGE_SIZE/XEN_PAGE_SH=
IFT<br>
will be used in the same functions.<br></blockquote><div>=C2=A0</div><div><=
br></div><div>Thanks for the clarification.</div><div><br></div><div>=C2=A0=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
Juergen<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><span style=3D"background-color:rgb(255,255,255)"><font size=
=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif">Reg=
ards,</span></font></span></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"=
><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2">Ol=
eksandr Tyshchenko</font></span></div></div></div></div></div></div></div><=
/div>

--0000000000009f0f4f05ea5b30c5--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 12:09:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 12:09:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416846.661536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogPgt-0003zb-Et; Thu, 06 Oct 2022 12:09:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416846.661536; Thu, 06 Oct 2022 12:09:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogPgt-0003zU-Bc; Thu, 06 Oct 2022 12:09:27 +0000
Received: by outflank-mailman (input) for mailman id 416846;
 Thu, 06 Oct 2022 12:09:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y3UN=2H=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ogPgr-0003zN-Tu
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 12:09:25 +0000
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com
 [2a00:1450:4864:20::52f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b7e9c613-456f-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 14:09:24 +0200 (CEST)
Received: by mail-ed1-x52f.google.com with SMTP id g27so2463112edf.11
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 05:09:24 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 ky9-20020a170907778900b0073ddff7e432sm10353101ejc.14.2022.10.06.05.09.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 06 Oct 2022 05:09:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7e9c613-456f-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=oezV6p4Pg66UTbe9c4t+yatYSFzeOtShFiSFXQ54qSo=;
        b=MeQbriyUIPiZobQp0WSRTktwRu3/jvvxRk0i5QonnBoZz/pZhqwGuso5KHD2on7YKW
         Bv2+dvIzSMJ2SSzqOu5+kjQ9HxQwQ7winQxJFoCQkzJM8qs9ANi7b5sOH0t9hBeFLfdH
         pMHVSPkaE+q1TXxG4SuI3OC3E3Dp5gbVjMXUxHv8CBsobEXsQJuC5Io7/APoyyw+rJGW
         +kprM4KhMvt85TFiAoqIXjIECj/zvFOUDNY8VB2LSRLB6azOjUdTsYfRq6QLnFY3Itpt
         FZAFkZYAvb5Uoi1+DnAIfy7thdere2eOKT+ZSFmbuBEF5E9S5lOcTfc1vvMkMTqz2poC
         pP/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=oezV6p4Pg66UTbe9c4t+yatYSFzeOtShFiSFXQ54qSo=;
        b=rPLG0ffFKJ0zh799wZxK+XFu06INyMtCdrh/TfnIBosKUQO0IpNT4M+ojxe8KFNc06
         xnICidtaMXcr/Iqc55iks2vd/39EuNCuUEmPoji3QiMay/NLp5Theh0QIkkBv3W2a8ew
         3cVaSHqQYSv2Ta2MRnTuChS6jhvUtDmVMoLi16OLINXBql860eQibuAimrR+B/5mbewh
         zKfghdVDxywh52O42K73puUW6dVpD/bjDEQAjisUR53f7XJAtQqJOmk6UpVdR9fyma4H
         V+IPysyTieP0FZ5w4Du6N1G7SmWXyJIDuK5mmbeQGe0ImgIi8BV2hzdkCaW2m5iTn8nb
         VazQ==
X-Gm-Message-State: ACrzQf0Z6gj0MZ6ONluppDxIQ6+h2RUvy6ZBGMoC4oI9HdnONET75kvY
	qa1rZ1NdoLvliwKouGEEzcQIrVnq9KM=
X-Google-Smtp-Source: AMsMyM7aU33Z5R0VlNLsXaNenVyARndTDobGsMO0OEwiDyF02B/9haEMaDcT/T5Xqho8omvVAWaV7g==
X-Received: by 2002:aa7:d614:0:b0:458:f796:f86a with SMTP id c20-20020aa7d614000000b00458f796f86amr4256860edr.294.1665058163906;
        Thu, 06 Oct 2022 05:09:23 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen counterparts
Date: Thu,  6 Oct 2022 15:09:12 +0300
Message-Id: <20221006120912.1948459-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Although XEN_PAGE_SIZE is equal to PAGE_SIZE (4KB) for now, it would
be more correct to use Xen specific #define-s as XEN_PAGE_SIZE can
be changed at some point in the future.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Cc: Juergen Gross <jgross@suse.com>
Cc: Xenia Ragiadakou <burzalodowa@gmail.com>

As it was proposed at:
https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/

Should go in only after that series.
---
 drivers/xen/grant-dma-ops.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index c66f56d24013..5392fdc25dca 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
 
 static inline dma_addr_t grant_to_dma(grant_ref_t grant)
 {
-	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
+	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << XEN_PAGE_SHIFT);
 }
 
 static inline grant_ref_t dma_to_grant(dma_addr_t dma)
 {
-	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
+	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> XEN_PAGE_SHIFT);
 }
 
 static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
@@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
 				 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(size);
+	unsigned int i, n_pages = XEN_PFN_UP(size);
 	unsigned long pfn;
 	grant_ref_t grant;
 	void *ret;
@@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
 	if (unlikely(data->broken))
 		return NULL;
 
-	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
+	ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
 	if (!ret)
 		return NULL;
 
 	pfn = virt_to_pfn(ret);
 
 	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
-		free_pages_exact(ret, n_pages * PAGE_SIZE);
+		free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
 		return NULL;
 	}
 
@@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
 			       dma_addr_t dma_handle, unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(size);
+	unsigned int i, n_pages = XEN_PFN_UP(size);
 	grant_ref_t grant;
 
 	data = find_xen_grant_dma_data(dev);
@@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
 
 	gnttab_free_grant_reference_seq(grant, n_pages);
 
-	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
+	free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
 }
 
 static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
@@ -168,7 +168,7 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 					 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(offset + size);
+	unsigned int i, n_pages = XEN_PFN_UP(offset + size);
 	grant_ref_t grant;
 	dma_addr_t dma_handle;
 
@@ -200,8 +200,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
 				     unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
-	unsigned int i, n_pages = PFN_UP(offset + size);
+	unsigned long offset = dma_handle & ~XEN_PAGE_MASK;
+	unsigned int i, n_pages = XEN_PFN_UP(offset + size);
 	grant_ref_t grant;
 
 	if (WARN_ON(dir == DMA_NONE))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:10:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:10:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416894.661571 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQds-0003br-Cf; Thu, 06 Oct 2022 13:10:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416894.661571; Thu, 06 Oct 2022 13:10:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQds-0003bk-9x; Thu, 06 Oct 2022 13:10:24 +0000
Received: by outflank-mailman (input) for mailman id 416894;
 Thu, 06 Oct 2022 13:10:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogQdq-0003be-Rl
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 13:10:23 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50069.outbound.protection.outlook.com [40.107.5.69])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3aa70e3d-4578-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 15:10:20 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9560.eurprd04.prod.outlook.com (2603:10a6:20b:470::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Thu, 6 Oct
 2022 13:10:18 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 13:10:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3aa70e3d-4578-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UoqpIHIG3j0ZRc/ODX49pw2XEXFBApS28q+e5mOX8Q2k7kJYz+OG0DV7pUrDduJgIwQfQyoDwzxe50m82kVorJmyyNCw46wWmtLylXF80MMjd66wAxPkoF3ari/PyVRm6G4vsZhnFkmXJraU3udKSBUyHaB6Kp34h2eSeiAs3KpYNiBFl+83PaV+uCTAnxpjGHyLg6blsxc3ldfV1eAQUuv333FmI82FNhEHRShfveoRwhi1CwFcIpkX8bcybzD/mqiJ23OgidzV8XXpKNqne1ZogLAAR3JKKUsVOB8SeJGUqlqILrVdq0Ok02a+9xkn2feK9HIMX730Q8tHhE6ycw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WfG6jW6NwZFVigTSy0urFosnhX7NafSMfX606VrU1B8=;
 b=liEx22Y0SShvVwrVhPNK0RgJ4N5MYXJjJXDlfeQQOh4khiV6JLlnxM+u4vhUBdPwdJUg9WXccW2V1pA9RZbyzl1ajdk+mxERp7OvoxDdw+TV1rFGeKKqmKXlMaNuqqzUr2NtKadWwtGa9Q1wbjqbAgL4FGMavxC/8l+oHE5NuwNXXJJVzDuozxjYVRH7KqzKyLdXZ74Uz9RkufJVPynArcg5r2af8JQ37IywFKSflmNyKHmCt00w25Qf9sq84Uj+ecpyHeTpziEV9kqUVEmBsUrg+HkdosH38f+RJzzMhu0lce5xMCKj7+dYlNSmvAM7t5L8G5PxU7bPyLwqKqSIhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WfG6jW6NwZFVigTSy0urFosnhX7NafSMfX606VrU1B8=;
 b=UTqVFL8lP7N8yy1vmCfjeU0kSD85S0yvcbQlrl4/9ron+iPjqK/vUa9DPx0TaLGqxyhIXJPS2VSnI0CaWq30/gMarj9daJqIz2hxllzYxm3pTxm4O6uvB67Esy4eoAa9/zkcTx3mXL16UsbWoD5AfBeDayq7/59CQ1klqaKSH9CYUSByvwrMP3yndpu+txev+kvRiXFTQRVzX3L4S2F/sij68hB1ueaR/d1tQSXXxw1QLLJTnujevaSU7Yb2SoEchudDY8CdsaDAgI/Dq89Y4Pem/Q+EIZiXw0f/epCnKnB7HpWZgPRCu7mv+t7po+FOBfcCzQqu+C75FIot7o42TQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
Date: Thu, 6 Oct 2022 15:10:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2][4.17] x86emul: string insn corrections
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0137.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9560:EE_
X-MS-Office365-Filtering-Correlation-Id: 68313f1e-9fcd-412b-fe30-08daa79c1dd7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p6cxLtAML2vKXNZ4HLUmUoXoa8kK2IbSR6psQ3sSm4JTaFDi9q5SkZz58lKjLtgqmyGV6BIAWdXMhOIwBF27tbIZoLD8mJ2UlNO+CfvGnrzF+MMIgsvpZienLvxEQzTHmq97BD1aBdj0airM762XP7z94u34L99lT/Y3652lBdtFc+AoJH5O7A7pfxNSXHD1YBix3YGA+N+Y/qRfNud2Nkbie1Udt3lpSZkNeIp+0oFOXx6yv7HLJlTbRfzkZjSjwhrnMiSBEWCE79NZiXatWeR8Cf6zN8wA4Cqud/6Xy1QfJCuekcpnk6FFNz5eaMjKsjfgZxyh1tzh4/p5jf3yF3I1knzs3eTuZPOop4Oh8oaybHMe+MC0dMuySJ1zY51rrnL9eI4BnvRL9FLkk1F0HpYtbGIQbTEkybVt138txc8ixuieved3dUx7qIPE9urRJFnbs5ToTD5YJP9x9xSyE6M+90Q31wN1ItpTuuwm7amM5tkJA1Y/Cb0sTiWQ3gAlgMs/LM8a/uK6F4fFUe8p9dRjAe77dEU1YxsLYG7uq2Chg63dxhkHP3Cfwvvy5aYjJNGPFf8qxXhpfTbZa7fb7cq+/ehU5Ph+G7ZstdDLkCWKxBNHwaIY5dLVSvvsi2HUMs7eH7/z3Uqb9GjnQyW9xlarYNPxTk+Vgre0b77XTRbh7odL2lt924GOkLhmO6eqBTfYVYbSjcU9AHyzKHUvMsSyZX8YwEgkwwDHZ/ZAyT6If3YBKMeTxryj6/n0I1YmjYVTjKnwrZE7mnpCxlJgW+MeI5jcAMtCs6sw+pSfPzw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(31686004)(36756003)(558084003)(6506007)(26005)(8676002)(4326008)(31696002)(2616005)(478600001)(2906002)(186003)(41300700001)(316002)(86362001)(6512007)(6486002)(66476007)(66556008)(38100700002)(66946007)(8936002)(6916009)(54906003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dlFtOVUxVGxCdkJlN1F3MTJ1WVc3QnY2eDliMlErZ20vTEFYTWxRMDNtZVR6?=
 =?utf-8?B?VjFzOWpCVHpIWUczKzFXVWVkZyt3dDJBdTNDZExvaVlNYldzK0czempIL2FK?=
 =?utf-8?B?ZHd0aDBKdjJjRjJKTy9Fa3VuN203TXhuZHMyRnY5b0c0ZGlIeklKTGwzblpL?=
 =?utf-8?B?RHA1Wmg3T3BneXlYUkJwUFZoWlB3L0J4bVN0VHd0MEJRNVZ5OFNiMXMzUmtZ?=
 =?utf-8?B?MGtFbHpVenBwbWc1WWs2SnRHbjBPaXJCdE96eGlRN2FaVWNZb3ovUEZ2NVo3?=
 =?utf-8?B?VHh6aVhFMjhRWVVBRWZPTGExSkdwWGkxZW5PQm1xSThuSDlCbWhEVEYxaTNJ?=
 =?utf-8?B?RzRXMW5kZkYvTTY1TTFGbGlVcDkxSVFPVldTZC9IZnpXVGd4c05lam5LMS81?=
 =?utf-8?B?VXNLNytQQVljNVB0d2NENUtUMWRFeHpac2RucUhIVStKa0FTcnNGSFRwQVFZ?=
 =?utf-8?B?b004VHp0bWVVb1FvRklLRHRFcWpQM0hNZlBmbWdVMUVwNllDVTEwZHczbW51?=
 =?utf-8?B?NTFXcUlCeUt2R1h1ZERpMWJKK20rR2RZcXdMaEs2OUd6cUxNVWs2MDhYNGQ0?=
 =?utf-8?B?NEpnY3BkWWNKQW41L3R0WGRrN0JGVHFURGZQN3BHd2VWQzVLaTA1VnYrNkFx?=
 =?utf-8?B?M1Z6UmRWbVpXZ0c2UlFXWWt2TlZwMUZrMUJuOG5KaGY2Q0huRjR1ZGVyU0RQ?=
 =?utf-8?B?b01LcVBzSGkrajBTTWZWZUtqYkV3dDNCVHJHRlNqNFZTdzlmWGVFbmpuN1o2?=
 =?utf-8?B?Q3RvbVlUTU5SZ2VlNENKVlE2cTkyWkVGanNvWXY0bHBmM1hwOFhNRDJHUG0z?=
 =?utf-8?B?aXBlSXVpWUpvajFURW12SnZpZmE2ZE5WYm5EK3RCVitLQnRicFhPRXFTZlFY?=
 =?utf-8?B?K2xjV0VpNlhoRXFmaU1zOU8xalRZRzMwdDJXMjAwV2ppRXJETmlEb20wQVh3?=
 =?utf-8?B?K1Q1VlpFYVJWVTFiTGJzVnptTnJ3aDFSUlBYRE0vRytzSHNBU1BaL3N4cXh2?=
 =?utf-8?B?UDk2OURZb1Y5UzFGcndhcU5JSHpJRXhSakwzdGZuQ0dKRzRSbUNFYXBVVWU3?=
 =?utf-8?B?bHJWOCtZU0RoalN0aDhwaE0wTkJDbkIwQjY5VFJycTNVWkV5aWliTjdJS1J3?=
 =?utf-8?B?cTAzSy9lbCtsY3Z2NGY2bkl4S3RKTHZqZ2V3OXRkZkdBU1Z0SWNxeGlNb29D?=
 =?utf-8?B?Umkya1dvNjA3dU9kMEJQOFdvQ2xmLzFkbWZkMnE4RTY5dGlud0VRUmxRR2xw?=
 =?utf-8?B?NXB0RDdiY3dxVVE3Q0ZkYjl2bm1yQlZMRGJUS3Q5V3F4K0V0d3BBMSswUStz?=
 =?utf-8?B?K0lqTzQ0SXYwdklyTmtIRHNzenNBb0Y2UTB5SnJIeGJDemZobHNaZ2xaS1h6?=
 =?utf-8?B?ajFXNHBmTWRpeGZjQTU1SlRWRitGbHFxZjREMjl4c1BRTUNWMW94L0QxQUEr?=
 =?utf-8?B?bWtwYXczYm5oQjZVYlRkUlRZdERYNXVUeGV3UytyVHMyNW5zaGh6aXVkM0dp?=
 =?utf-8?B?ZzR0MDNaM3BIQTdEZVVnL1RXdTFacVR0RUhaOTdJdURpS3orYzRSeTNHbnNI?=
 =?utf-8?B?UjBwNjVsU0xTNGUxMWh0VWhkMjhlY2l1b3doTFUxakErZlMzQlFrQ2NzMVNN?=
 =?utf-8?B?TVo3eFUva3lOa280MzlQUCtVcTFpSVJleEdwdGpIdS9hVW8ycml6dm45bC9N?=
 =?utf-8?B?ZC9oLzNKbFlzMGNLcCs4R1gweXMycitsaTJ0UG1adVZVS0dJeVRicDlnTXRM?=
 =?utf-8?B?NFQyQUFuTUhVY0dkUVdKcWp6MXpLQ3N1SHhuRXVtckZPYUMyWjFxTXZvSkFn?=
 =?utf-8?B?enF3RXc0L0hmOFhqbFc0VTVpUXRJM2h4T2tFd1pXNGVtQXVSeVhGeEJUZEJX?=
 =?utf-8?B?bGNrOEt2eVN0VWR5RHpGb2U4a2dIYXNlWmpGVHYyTTFYNUhxRjNUS1JMOFRN?=
 =?utf-8?B?c0NKQlZjQm9EaGRGeU9nYWlHekVRTnc3ZXdEQ2Yyck9IK3Qydkt6bkdJVWNx?=
 =?utf-8?B?RkwyODZMSjdFMGlpY3ZoclZmMTRCVVVpN1A1UVlHYUt5bWFBeS9QN09tY296?=
 =?utf-8?B?V240bTNCY3dRZStwclBNemZnWS9MTWNMRXpvRTdzZzdrcTQzWmdqSG5JSEVz?=
 =?utf-8?Q?8zRnVnE2etXLPELJmCa49aGpx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68313f1e-9fcd-412b-fe30-08daa79c1dd7
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 13:10:18.5340
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0D9VDeFZ5HhsTE8Z7CSbgEnArruRJE4T2cZmjK3fLyKqV2YC3h2g3nX/H6iD2FVJuXx7gVo0+/bVl7klqrxpoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9560

Both partly RFC - see the remarks in the patches themselves.

1: further correct 64-bit mode zero count repeated string insn handling
2: pull permission check ahead for REP INS/OUTS

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:11:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:11:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416899.661582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQei-00047R-Mk; Thu, 06 Oct 2022 13:11:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416899.661582; Thu, 06 Oct 2022 13:11:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQei-00047K-Ja; Thu, 06 Oct 2022 13:11:16 +0000
Received: by outflank-mailman (input) for mailman id 416899;
 Thu, 06 Oct 2022 13:11:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogQeh-0003yu-CU
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 13:11:15 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50076.outbound.protection.outlook.com [40.107.5.76])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b135d48-4578-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 15:11:14 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9560.eurprd04.prod.outlook.com (2603:10a6:20b:470::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Thu, 6 Oct
 2022 13:11:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 13:11:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b135d48-4578-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WPaqT4rCOTuky1Zn/uyRRbxGEK9gE9DkLGh9sWPSrLk9+KeDr04oIUoNam2s9TlmvZkBYHV5UXCBqHgts3AizQRd2ELohfIhxz3VB29QPIymKubuE4J/KyGeonSiXhYNAsf+IRlB4oMEB9z1QW8FljDTWg+Y4Ejmdn3ZxfZkyJbkm1wLtEhHelu/eu63vLAwBC++X7mUrNLl+/jXqazJAKh5fTv8MalHXok47YAuITa7F75VNPKg7rnHAZRZJVizDi+m1Wd6cgpNd7I5AKztnh2laFj6ahXfHuc8azN0tWQpMkYk4/YbPhsoSSecAgoQVSTUJvFO7BxAlngCTIW38g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lsP25R/4gs4hqLJaINXdXJap1S3h0P4oZ+V3WVxiDK0=;
 b=mXQKEmQQraa3puiNwYnJNKTpm1b8o4YN2iVysIHkx/8DGCN4jmSuE5ATCunW/rB07S/EaWB8GmPLqzMkNmkNdkuxUQREo/K99xPVfH+eaUl/ph9iQgrciXlbwpfj7yX/UUaOaphq4eDw+VwRH4vxSzMtgLjBu4Y701wzV6gZ6A7AjBUi+Qe56pebzCy2Nt86kJtkT7DzdEKlq79I/Gp2+qtA97BHkv32r2QGEmfOQ6XcgwUvexsfkzW0nMtgdqBDaPQGGDjwxZO+Mln35Eicr9BUxeloQC9dFDXWCXEoZpub+fqADRvThBFihyA9/GuZ1tPt3+Cw1myiJLdSl9UjIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lsP25R/4gs4hqLJaINXdXJap1S3h0P4oZ+V3WVxiDK0=;
 b=TIwGfD1ThDWRYsL/JHNNc446FRkz8RsHpF1ELrZXwWIgihQaZJwA31xyISsBjEfUx56s7r9l8Mx7egXXMaF4O//Dgm0qmgX5WiiOlQAwSsAMiiIB98TT17wEwh0RfO5TAgGwmtJFIpFBrG6XHCq4QCUH7o21rky/p/fYydxayHFZU9bleszB0F1wLbQf6LHJrMwYxi+PmIv7v80TOdJPG/2ixJChCf/E9EO0THNgPuZmlUXCDFHqyYZvBoMRjhRUtK+qYTISg0qlzis8038DXO8AIiY9cPwaq/17c59kDnW8R59r0DDuMoUVsvXTvDiUfQOJNRBGoVwZRYQVQhSfww==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1dac86de-cb8c-d2b2-d0ab-bf76707d22d0@suse.com>
Date: Thu, 6 Oct 2022 15:11:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: [PATCH 1/2][4.17] x86emul: further correct 64-bit mode zero count
 repeated string insn handling
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
In-Reply-To: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9560:EE_
X-MS-Office365-Filtering-Correlation-Id: e2403c17-6fb3-48c4-bd6c-08daa79c3e4e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0oH+rauzweuTyqBEYFa7igbLj8xbV8m8zPWO8R6Xn1V/o8AyOF2MnN9t48W/SIfmHI1SsOVyZWY7jt/qLJz1LOdjUlYdo9r5886tjgA6w+lcdu4FdBkhzn9GX9ofjGNNN0AkDm3WtpHe2Qm/ZIEbCOG/xyZB8idrs/acA0eXbFQJHYjfH8HsrdIe9S2prhW5z+ycqfZX6i9V3/2S9UxhrCbPB/cphX8ddXf6OtPLMNYX450fT5nrqXeB8dJbeY+sYSU3tVNhQhVvEOXDykYtedBYP/EHmw/rh/LJlTUfNlPu+BqI/kgpoJ+pLb5+vavDqW+MDOyl5HC22kBvmzWXr5LaN5X40IMyHEQK0JTkthZbAFgflBMOEzBh+YWewwrpK4ineSGAoXVALkO/EDuP5lYd/GD1MYfCMLrcUv0BvC0SPOLNklK5wD8wtsMK37RLTIXeJyK+aQwxxU3ll6t7FoPnhJnfVh7gZE0nh5QE+c/oeA2Sz1dWQl/OYH4bEKWUs0QqSu9FnPTmk26yc47vWPVsv1oUjUmkQrZiKH8ATvw3SOLhWzGoI8wMb+tURc3rHG+EbXUYlDIL7GCN8/yTQ2NO1c/4lQ5EV87hkC1enrOYv+UMklKoIkdfmziDHnZo15hjCYr4f3C/kteGJQm0USKMMYtBFI4llNkyxmDAi5Y+WDWW/rDwQWBURz8O3gAJe+gRV/g2rNw2zMeHm+hak0O1s4r+WbPVV+fsnEi+vvqujygFeDd6FhhJDnjT8+Tyaf///gIncw+77UXTYjxC0ol2r+5Pb0Dh3Xo0nFLwCaA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(31686004)(36756003)(6506007)(26005)(8676002)(4326008)(83380400001)(31696002)(2616005)(478600001)(2906002)(186003)(41300700001)(316002)(86362001)(6512007)(6486002)(66476007)(66556008)(38100700002)(66946007)(8936002)(6916009)(54906003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0Z3VEgvSEhvM09uVFplLzlPNUFLS1k5K0pSZmRVTEVnVFJnclBHajRibzhx?=
 =?utf-8?B?cUE4UWVlUHpYem8ydUlmTkxRZ1Z1bUpmWEtDTE93NXJIMjN6YmtZWFVJOWg5?=
 =?utf-8?B?Zi95NGVHNmFFVnJ0TERydThkUXU0aE56cFQ2MXQxY0o0Q25sQ0dMV1dWRHNG?=
 =?utf-8?B?WVJldHRQT3ZTQjdKLzJZZkNaRHVUYnRYOVBoZ1JiWHoxVDVCa2xqZXFkM2VD?=
 =?utf-8?B?a3Q5ZzBvMzA4SUJOWFpoUERWVGxRdXQrN25GTEJpUklkWFFKU1RnZjJXYXpN?=
 =?utf-8?B?RTZtM1hma09RWTZqYmJIS1haVVphK3Bhc245OTdlNmFpTzdsbkNSVzdzeng1?=
 =?utf-8?B?Q2k4N2pnSldDZFNBZWd3amQwbGV2UmY3ZUp4cVhSZ2lRa2VFVWdyUVA4VE9J?=
 =?utf-8?B?YkJwL3VsMEM5U0Q5eUZ3aS9LYVA5TkJvbzI5WmZJcnhocW9DU0xxUUR4c1F0?=
 =?utf-8?B?MTdtcGVKK0ljUlpkVU5wZWZMK3lKNzFmWWpJTEhBZVVtZWUxN3NsVllWaHA2?=
 =?utf-8?B?YzEzU0Nxd0RhVnEvamEzQlJHdFQ5SHBKWlNBc09NYU40bEJsOHdqaEUrZDho?=
 =?utf-8?B?K0RiYXhRcCtEYTNqNGZuUkIzUkJBSTVZeUhsYTMvNGFOMW8xZVNub0ZCSTFj?=
 =?utf-8?B?eG93OXFmbktwdU5pT3IvYUg4NEVwV2JCUk4wMWZXUzNCVnFPQkw4NGU5V05B?=
 =?utf-8?B?SWhFV2Z5a1hOOGpTYml3eFhGV3RNTDlVR1ZLbmJzMVZmcXZUVlplYnNXc04z?=
 =?utf-8?B?dm8xM1ZEK3p1M0d5UUw3bXJ5VFNCL0dlOUE0ZUdyOXpMRG53QzdjNnJuS2c5?=
 =?utf-8?B?NURlcldSR2hYMkgrOURxakpVZ25FTHI3THNXbXAvRFBJSDB3enBIYlMxM200?=
 =?utf-8?B?R2hKVk5xbDlrNUsveFJoNXFvUHFCZ1FsZnZOaCtXOUJQZ3B0Kzhsa3FCWjlm?=
 =?utf-8?B?T2taRVI4eUxCUFpVdnh3dU5UenhlN3BmOUhWVjRwRzhpaWV5c1JmNkZoU1J5?=
 =?utf-8?B?S3B2OVFTT0lYbTZCTnpkMkJkb3VjM1E4enFSSlVqcXN1a3ZkNjAwU2tHVWRx?=
 =?utf-8?B?eE5qZTZ4NUJCZVFSdjRYYW4rd2V2TzhWQm9pSWxMZGEveXNVamZFRUZ2eHZ4?=
 =?utf-8?B?MWw4ejZtZkpLai9nSnZYSUNzakFvM3hZYzNJOSsxNEdmWnB5V2RhdkN4UkpW?=
 =?utf-8?B?L2gyc0hYd2RyU2RFT3RxOWVQNE1aSThOWW5YUXlhTnlDNVpGM2xKREt1Mi8y?=
 =?utf-8?B?TzZBcElnaUZ2SG5pZS8rcWVQckN2SUd6QU8rMEJvSE4rL3NQdkYrZjBDZ3p3?=
 =?utf-8?B?OHdjZ2s4ZWhkZzRhT1BtcmI0NFFWR1JIQVRldUxKb3FkSEU5L2RpZGJMS1NQ?=
 =?utf-8?B?clZRT3NhMXJPUjJ2QW5mSnlaM0ZwVGo1Q3B0Snlrd01MUmJnVmtZdmw1N3Vk?=
 =?utf-8?B?QVBaUzJVS1RwNkl2azNkNmk0Ylh6WTBEZ2Y3MlF5Q2pYaGxtaWVEcHVZQVFK?=
 =?utf-8?B?aXNWaXBqSkJNZWFlR3diZmRNcWZBNk15ZmVmSU5HcEFXdjRWdVkwUzlaTmw5?=
 =?utf-8?B?VlZWM09lK21lUllUSncxWWVEM05jWFJpV210VXJWUFdGMTM5cjJUSHFvdjFH?=
 =?utf-8?B?WkJUc0VHMnd4a0RHWjVyMFZQZjJRV1pUYm9SUjlpdm5ibFBWbWhjbFd5b051?=
 =?utf-8?B?VlhCQk84TXByNmQrbmZYMVVIeFdacDdBYmd4enlCR2s3OTJBWHhQeXNwQmQ0?=
 =?utf-8?B?TkwxZXdETUlxNFplK2oxTytKVzVxTmYxWG5BdWFPbTAzQXhOVjlOQWM5OUx2?=
 =?utf-8?B?M01qRFdPVndBS3JTbFVFUTdIUld0ZjhWd2FHTVRxNEE2MFZFUXgzK0oyNTQr?=
 =?utf-8?B?Q2FFcnRBK0p0T1BDUU15cmJTQ0sxMGsvK1BESXEzSVA0Y2Y1aTJPZ2IzSEYx?=
 =?utf-8?B?ak9qSkhtaU9JTmRFVllPYkF3MmltdmRCSTZ5YVdHTlBRdFZWbzdOMzA5a2U1?=
 =?utf-8?B?SmFoQTZ0MkxoazF5QTZpZ0k3K2F6TlNBR3FGSkpENTJoZzgweDQxYXZJTzVl?=
 =?utf-8?B?R3owL2NreWk3QkcrMmV1Kzg0YS9JbEJ4TEcraVJjc3F3SThONjJRYklIeVh6?=
 =?utf-8?Q?pJDged39t92y3OYMpJK6xoIOj?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2403c17-6fb3-48c4-bd6c-08daa79c3e4e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 13:11:12.9524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jl1SaxOlIke6NhBTuKNR6vjRjyYmqQpD27/SYVxVpf4tcN8R0ncWir9HclrT5/mfRFmc8OY6plYjI+eBNfHJ+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9560

In an entirely different context I came across Linux commit 428e3d08574b
("KVM: x86: Fix zero iterations REP-string"), which points out that
we're still doing things wrong: For one, there's no zero-extension at
all on AMD. And then while RCX is zero-extended from 32 bits uniformly
for all string instructions on newer hardware, RSI/RDI are only for MOVS
and STOS on the systems I have access to. (On an old family 0xf system
I've further found that for REP LODS even RCX is not zero-extended.)

Fixes: 79e996a89f69 ("x86emul: correct 64-bit mode repeated string insn handling with zero count")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Partly RFC for none of this being documented anywhere (and it partly
being model specific); inquiry pending.

If I was asked, I would have claimed to have tested all string insns and
for both vendors back at the time. But pretty clearly I didn't, and
instead I did derive uniform behavior from just the MOVS and STOS
observations on just Intel hardware; I'm sorry for that.

--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -1589,7 +1589,7 @@ static inline void put_loop_count(
         regs->r(cx) = ad_bytes == 4 ? (uint32_t)count : count;
 }
 
-#define get_rep_prefix(using_si, using_di) ({                           \
+#define get_rep_prefix(extend_si, extend_di) ({                         \
     unsigned long max_reps = 1;                                         \
     if ( rep_prefix() )                                                 \
         max_reps = get_loop_count(&_regs, ad_bytes);                    \
@@ -1597,14 +1597,14 @@ static inline void put_loop_count(
     {                                                                   \
         /*                                                              \
          * Skip the instruction if no repetitions are required, but     \
-         * zero extend involved registers first when using 32-bit       \
+         * zero extend relevant registers first when using 32-bit       \
          * addressing in 64-bit mode.                                   \
          */                                                             \
-        if ( mode_64bit() && ad_bytes == 4 )                            \
+        if ( !amd_like(ctxt) && mode_64bit() && ad_bytes == 4 )         \
         {                                                               \
             _regs.r(cx) = 0;                                            \
-            if ( using_si ) _regs.r(si) = _regs.esi;                    \
-            if ( using_di ) _regs.r(di) = _regs.edi;                    \
+            if ( extend_si ) _regs.r(si) = _regs.esi;                   \
+            if ( extend_di ) _regs.r(di) = _regs.edi;                   \
         }                                                               \
         goto complete_insn;                                             \
     }                                                                   \
@@ -4248,7 +4248,7 @@ x86_emulate(
         goto imul;
 
     case 0x6c ... 0x6d: /* ins %dx,%es:%edi */ {
-        unsigned long nr_reps = get_rep_prefix(false, true);
+        unsigned long nr_reps = get_rep_prefix(false, false);
         unsigned int port = _regs.dx;
 
         dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes;
@@ -4289,7 +4289,7 @@ x86_emulate(
     }
 
     case 0x6e ... 0x6f: /* outs %esi,%dx */ {
-        unsigned long nr_reps = get_rep_prefix(true, false);
+        unsigned long nr_reps = get_rep_prefix(false, false);
         unsigned int port = _regs.dx;
 
         dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes;
@@ -4630,7 +4630,7 @@ x86_emulate(
     case 0xa6 ... 0xa7: /* cmps */ {
         unsigned long next_eip = _regs.r(ip);
 
-        get_rep_prefix(true, true);
+        get_rep_prefix(false, false);
         src.bytes = dst.bytes = (d & ByteOp) ? 1 : op_bytes;
         if ( (rc = read_ulong(ea.mem.seg, truncate_ea(_regs.r(si)),
                               &dst.val, dst.bytes, ctxt, ops)) ||
@@ -4672,7 +4672,7 @@ x86_emulate(
     }
 
     case 0xac ... 0xad: /* lods */
-        get_rep_prefix(true, false);
+        get_rep_prefix(false, false);
         if ( (rc = read_ulong(ea.mem.seg, truncate_ea(_regs.r(si)),
                               &dst.val, dst.bytes, ctxt, ops)) != 0 )
             goto done;
@@ -4683,7 +4683,7 @@ x86_emulate(
     case 0xae ... 0xaf: /* scas */ {
         unsigned long next_eip = _regs.r(ip);
 
-        get_rep_prefix(false, true);
+        get_rep_prefix(false, false);
         if ( (rc = read_ulong(x86_seg_es, truncate_ea(_regs.r(di)),
                               &dst.val, src.bytes, ctxt, ops)) != 0 )
             goto done;



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:12:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:12:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416908.661593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQfR-0004ic-3R; Thu, 06 Oct 2022 13:12:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416908.661593; Thu, 06 Oct 2022 13:12:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQfR-0004iV-0c; Thu, 06 Oct 2022 13:12:01 +0000
Received: by outflank-mailman (input) for mailman id 416908;
 Thu, 06 Oct 2022 13:12:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogQfQ-0003yu-59
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 13:12:00 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50065.outbound.protection.outlook.com [40.107.5.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 75a987db-4578-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 15:11:59 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9560.eurprd04.prod.outlook.com (2603:10a6:20b:470::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Thu, 6 Oct
 2022 13:11:57 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 13:11:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75a987db-4578-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LNQ41SdZCEqKKSxinuUaOVllmAx7i/VNm42Jxx1O8f6i0nX4hZiQWAF6WiSEMmMMYItctoEWGmFWkAxcuAhpDA3QSJ9uGLjEDFJEePxAprXqQB1lWh4u5AlFO/t1Gmn8/DacU8U9xQpIJru2b6Ia1TKGWIihF/ifo1mtARfwvfS4RKNedyKvhTOEPYmReJOgf/JVEotacOruiPTaaRIlLRSKhcOTChNZEtdAX+BHWgcBAe7D6ZwFu+StFrfr7NLUeof5TkClHXVyEr5tk7A+/7doIAmzyl+xiwylZlCr46TrIckLyY+UaPPc2Nq/oI3k/dvImRcJywv5vxXGkcnTKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/YV479IgiGvaTL6Y7CPDE6Fb2IX1fXKLM+JWhWgYffg=;
 b=Xl+krlR7HBjNTPlQjXBIU3FopNH72PSGpyq8TOdUBFlkA8sTZuRCERw3TzjIRm05xZOXOnyujxkvneGJHVjcR+5hzUGjXCOcMaYr6/+EWztNnUP1kBb3TipDxuBBoO7RXiM+TgHrtKZLFr9M1Jo8cT4+jmyn8FgTEYgGRthF5JijZnNhemAT28CXAI7ysBsqTYhMbVmrr3wtzqp++71TTmzMqcdXAnujjzU1wKHWA54f7rDmNbdfZUuzt2JSlbhiurQSqqAaDECbC2ni0wcBvas0vmRp2/afYRHPYST3m4tRlD47Y+Sq1NwkF4anrM4DO6ugFlZS5p1Att3kjD7Rsg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/YV479IgiGvaTL6Y7CPDE6Fb2IX1fXKLM+JWhWgYffg=;
 b=JvsyoJq02kl5pZxHad7b0l/zxOAR11bZQdB9MqOSzJvYv65sr0yBXYR0hoEP6yci2yHtO2zfAAVfqq7hkbil1Lh8d/1rcsfExqKCbx1QhdXHlJHddlNpFyTEJtXFsL2Lt83NFpUX5mZa16sVLU6FDqG4GJVIF0ZgmMIXyNqTdecCqbTJInSLn0V5tGCU0UFlcp8zh4jFdFH+NQCMgbShtvuDwChreWyuQ3Wd7vb1C7W9ZfslpmQK1S6CdC0pmY8dPf7PikKI/RVKjcg3ZnkynDeVU34RDKdkg+bO3UGbEx6sLQeHBeiieD+LRvZJKanP4oQvbTJhj8gOEO/marnqLQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4d01771c-fd02-b607-c480-04bcb11fa7b3@suse.com>
Date: Thu, 6 Oct 2022 15:11:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
 INS/OUTS
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
In-Reply-To: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0120.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9560:EE_
X-MS-Office365-Filtering-Correlation-Id: ce2ad2b6-9baa-4ebf-6269-08daa79c58ff
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sBNnI96a6uK9wRrw21ER8UUtsZ3YHWMS0iKRoo9MYa8bnaQPA423Yo0BrUBM4gwxdFZdBmajyvbmkHKkU0ZlBSXc+BfbCHj1eKZ5urhHxgewdiGEIS4m034vTWJ3bpIqR0bmBxNYAJs4UPoHWszN77arLC2GgbAO9nQiWhS0P3g+t/n+2Lsh8H9kj7Jmjv8fgXT8/8RJLOB7lf9ImxN89DYrLHhCNC1V1F4bJjqV7a5DTH8FOYBPvPfWe0+3gGttcBsEtFqITLURUO47yfHL1wGINrkSbDSHp/85n4YbYK5GbdE81bmZnZtt03qsbsAfGYFV/0rs++uSWbMNveAEMnFcdpZ59k2SMKz6JrDs15kwtrnlEFhywYDbJP7wmVXgxxV3IzZYcWgYTS3SqhCtsyd98C0TucoMhDuFVFU8XXuEBztupHE0QLuamcvRJAQxJp+F+STVRrRwDalCiN4PO8SRUbZ0bP2g2cc4A7zsRAOkmJoy8xbX6l/sXvB42il2EwTexWiXri/Ug471jzAjuH2MB9eYhOXYdfsWkDIETkLtmReLVgt4wcFVL7OiOP9bYpnZkLEoJHIQPUgwdOJrfkoL13fQYV6izI9z2QbLu3uQDNlukUo6XJqio0WULkzGl9uXuiPywW41isxZnWHpHp7QxSfm0hTrlcWVnNA8xVLSimztD7QPo90SmH/UBOroQM1unik0Ah351CuaD9j9HTF1ffMSFn/jar7Ul6eeAn4EPB4eZJQi/s94Gt1iRWlsa1WtHZEn0QiUaF3bzW6I1XS3J5rGfL+kdky6ZTS6o6A=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(31686004)(36756003)(6506007)(26005)(8676002)(4326008)(83380400001)(31696002)(2616005)(478600001)(2906002)(186003)(41300700001)(316002)(86362001)(6512007)(6486002)(66476007)(66556008)(38100700002)(66946007)(8936002)(6916009)(54906003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTIvMkRoNGVxeEFXbmFaZ1BuSkZoZitibXc4ZXEyUkVCMHdXdUdJVnpzYzBO?=
 =?utf-8?B?YjNYLzdjTmk1MUxuNTlrVmc2SW5hVVdWbkJmdmJlMWpoUnBwZjRIdFZFR1Zn?=
 =?utf-8?B?WWxOaFN4VGNjdklKYld5bi9UNzVGNGdNU3gwRzJlSi9GOGR3Zk13VU83dXpm?=
 =?utf-8?B?SkVQUmhJNzg5ZHZEU3dneDlkOVV6dzluK0swZ3ZUbE02ZVJwUnFsREp2TTBE?=
 =?utf-8?B?bXlHaUdoM09UbURESitaMDIvb1RkbTc1dDZEV2lEUjZjZHdZdy8xekViZngv?=
 =?utf-8?B?NytsS0FXZi9OMXI1bElIaUY0YlNqWW54VnZ6QTl4RVF4RWtVWW5aYjJmQm9O?=
 =?utf-8?B?cEgvVS90R2t6VzZlK0pUS2RxSzFhNE1JamNyK1VDTWlVNUJqNTRMcmhjbEVF?=
 =?utf-8?B?ZHQ2bzdvd0xoUHJBQ0VocXFkdFhpMG9zNkFGdG5rWTZlWkx0UHh4S2RjMVdG?=
 =?utf-8?B?aXc0RzVIaEUyWHl5U2Jmdm9EejA2ZkZlOFkxclNrM0c3NW9NOTJOMnBwTXFq?=
 =?utf-8?B?R292bmJlQ25ueWJLQUNERUhHdm9aUWFXakliMGhrWkI5cTViZWdMNlBHakJL?=
 =?utf-8?B?ZElYMXVqY3ptMEZobHlOYkE1QUIyRVJ1dkt3RU4zSDVmMHVHNWFTcndoYW9p?=
 =?utf-8?B?S3dEYnpPbkpJVURTS3lnNm5sWWVTL0FRZkxWbTZUMXlucEhJMitQYmVheW1P?=
 =?utf-8?B?SVdCd2pZYk9NL3BONlJpREQ3Y3dMTkdDdlY0cDVKSGpjV1Q1VWE2dXRjS0VF?=
 =?utf-8?B?dExrRmtSUnFOcGpFUlhXOXU3bHQrRTcxMHpwN2owd3RsL1NMbXZTWEx5c1Zq?=
 =?utf-8?B?d1hyQW1Kc1lFZ0RHQnZmSnRLeHdzV1BaSnR6dlA5VTFUaUpYMzRRYm1EY2tM?=
 =?utf-8?B?OGQxYjV3MEFzVllScTZwVmJmS0M4dGlvcXNzdkF5WDVpSWhPTjFUU253SjQ2?=
 =?utf-8?B?NnNCVVhvaDZQYTlaY2poWmFQTklib3FqSDduZTJMTnhSN1Q0aWxjK3ZueGJp?=
 =?utf-8?B?Ry9vL2tyVFBDL05RUHBIRU9udmMwZ05UYUVhaHNnYUNBTU5SZXRIQTY4SjEv?=
 =?utf-8?B?bk1qaXJyeVdFYy9EQ29DYyt0QklEQm5HRFhJYUZHd2NjbEZWRVJ3TnBIalc5?=
 =?utf-8?B?WjdsYmFPZWlLcVNPck1DRmtBZ2lkZzdia1JYcldxUm1QWm0zUFp2Mk9MTmNp?=
 =?utf-8?B?dmxIeE1RVmg2LzFhejBWYlV0TzhRbkxKakEwNVJ1a2xoa1ZHaHJiRlVJOTBD?=
 =?utf-8?B?S01ZT2RST2NoRHpPSHRSWFB6Vnh4bE9QdTZwVUlZUXdDQ3l4bVpCL0JDRWR3?=
 =?utf-8?B?S013dDk4SGlsWC9rakl5MkVPSGZaaThMSVJFL3k5eEZOS3VDS0lGNGxVQThv?=
 =?utf-8?B?Qmc1Nk5PN0F3RVRaWWNaRStiQmdTRlNRcFdGWmNxYlpVU2RVTEE2anFhMFgw?=
 =?utf-8?B?UDN1MDBKUFZnaFpTbCt6TllzVkdWRG93eXdiNE5OWXpYUWY2WDY2bTN5YmVu?=
 =?utf-8?B?akZwc1kvb09EQjNPWGlMTmZHeEprMkdXd25oYjFwWFh4blJxdUswVVNTWis1?=
 =?utf-8?B?eVBER1JVT2ttZm5JckNyL0JvekFLeldsd1FUcHRSaEgxVUdYNzFCcldiRjlm?=
 =?utf-8?B?eTBVVGZvTXpQcnU4aFNoY2xGSTlXbkVBNXlPN01yc3k5VE9kRjZZRTQyNnlR?=
 =?utf-8?B?Wmd3SW9DWVo0R21BL00xTzFHNlRCZDAweWg3WitrUVdQQjFteEpEZmZiNDRr?=
 =?utf-8?B?Y3hmVFJSNFdMalBNUUxKdDBJTldDT3VVNk52RXZJaW11MUxXZ3Zab3hXZFJT?=
 =?utf-8?B?Rm44RzlnQUZWMnVQekhkeEZjSWpyT2JYdnFBbTl0NGtQNnFMWVJLeTVQY2g4?=
 =?utf-8?B?Zis2SjlvRW02T1haQ0JoWi9PNnlEMVFCYzJtOHBGYTVWNXg1YlVQbFFOdHVs?=
 =?utf-8?B?a09xMGc1bmNsaFM0RkJmZTdQZ3RxaG1SUnRTcjVabnhWQkJSMEpQUzdvbWZY?=
 =?utf-8?B?NGtGdHZDRXNDMVJZVm5RM0daWk9wS2I5MWljWXZPM2FXSnc4bGFVSWd3aFlC?=
 =?utf-8?B?akMvKzlpWmdSbG9QZU5GQU9qY205Z3M5bkNQa0xvSVhlNzZXb1pIVi9pYTRw?=
 =?utf-8?Q?9ZrHXEFlj6NlBi462azTsgKAa?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce2ad2b6-9baa-4ebf-6269-08daa79c58ff
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 13:11:57.8402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +LO9rUm1gBDl86IWToJEmW8W209U6ElBuvMSZZRwRpSmH1mRP0Ff6HoxMUGjUyHof5Uez9wZDAzKhvDSaa1hOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9560

Based on observations on a fair range of hardware from both primary
vendors even zero-iteration-count instances of these insns perform the
port related permission checking first.

Fixes: fe300600464c ("x86: Fix emulation of REP prefix")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Partly RFC for this not being documented anywhere; inquiry pending.

The referenced commit is still not really the one, but before it REP
handling was so broken that I didn't want to go hunt further.

--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -4248,14 +4248,15 @@ x86_emulate(
         goto imul;
 
     case 0x6c ... 0x6d: /* ins %dx,%es:%edi */ {
-        unsigned long nr_reps = get_rep_prefix(false, false);
+        unsigned long nr_reps;
         unsigned int port = _regs.dx;
 
         dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes;
-        dst.mem.seg = x86_seg_es;
-        dst.mem.off = truncate_ea_and_reps(_regs.r(di), nr_reps, dst.bytes);
         if ( (rc = ioport_access_check(port, dst.bytes, ctxt, ops)) != 0 )
             goto done;
+        nr_reps = get_rep_prefix(false, false);
+        dst.mem.off = truncate_ea_and_reps(_regs.r(di), nr_reps, dst.bytes);
+        dst.mem.seg = x86_seg_es;
         /* Try the presumably most efficient approach first. */
         if ( !ops->rep_ins )
             nr_reps = 1;
@@ -4289,13 +4290,14 @@ x86_emulate(
     }
 
     case 0x6e ... 0x6f: /* outs %esi,%dx */ {
-        unsigned long nr_reps = get_rep_prefix(false, false);
+        unsigned long nr_reps;
         unsigned int port = _regs.dx;
 
         dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes;
-        ea.mem.off = truncate_ea_and_reps(_regs.r(si), nr_reps, dst.bytes);
         if ( (rc = ioport_access_check(port, dst.bytes, ctxt, ops)) != 0 )
             goto done;
+        nr_reps = get_rep_prefix(false, false);
+        ea.mem.off = truncate_ea_and_reps(_regs.r(si), nr_reps, dst.bytes);
         /* Try the presumably most efficient approach first. */
         if ( !ops->rep_outs )
             nr_reps = 1;



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:29:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:29:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416918.661603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQvo-0006Sa-CX; Thu, 06 Oct 2022 13:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416918.661603; Thu, 06 Oct 2022 13:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQvo-0006ST-9z; Thu, 06 Oct 2022 13:28:56 +0000
Received: by outflank-mailman (input) for mailman id 416918;
 Thu, 06 Oct 2022 13:28:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogQvm-0006SN-Vl
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 13:28:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d251e9c2-457a-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 15:28:53 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 441001F944;
 Thu,  6 Oct 2022 13:28:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 069F61376E;
 Thu,  6 Oct 2022 13:28:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mLApABXYPmOiSgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 13:28:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d251e9c2-457a-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665062933; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Zw7QtKYhHUjslXa6hEnoSbEeMnIBJiWBqRPnHxGncbs=;
	b=ikoBEeftRR7TmVWwS4piGmAzNQqoxQuk/zyHCcqsdfHoDedHMn5lKfxwkADHU3GbF1qt4B
	OLRwaTXaCIxggDyyMkfKTRUhwbygRnN/wXg2Tk4wNj4E+nap1Pnz55vpT3ZyVrr8CnVtJe
	yrnVmvAd+gUPkQmitr6kQrvL4Zn5xf8=
Message-ID: <87ad3c36-dde8-40a9-48c5-8f5e38ff583b@suse.com>
Date: Thu, 6 Oct 2022 15:28:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
In-Reply-To: <20221006120912.1948459-1-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------COYPuJ0aVYQZUKZvn6WujwFM"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------COYPuJ0aVYQZUKZvn6WujwFM
Content-Type: multipart/mixed; boundary="------------KHvJsSqJ93ody3CVU19hTJGa";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
Message-ID: <87ad3c36-dde8-40a9-48c5-8f5e38ff583b@suse.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
References: <20221006120912.1948459-1-olekstysh@gmail.com>
In-Reply-To: <20221006120912.1948459-1-olekstysh@gmail.com>

--------------KHvJsSqJ93ody3CVU19hTJGa
Content-Type: multipart/mixed; boundary="------------rmIo1mWa0UyW0sTQOsQREdIs"

--------------rmIo1mWa0UyW0sTQOsQREdIs
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMTQ6MDksIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBBbHRob3VnaCBYRU5fUEFHRV9TSVpFIGlzIGVxdWFsIHRvIFBBR0VfU0laRSAo
NEtCKSBmb3Igbm93LCBpdCB3b3VsZA0KPiBiZSBtb3JlIGNvcnJlY3QgdG8gdXNlIFhlbiBz
cGVjaWZpYyAjZGVmaW5lLXMgYXMgWEVOX1BBR0VfU0laRSBjYW4NCj4gYmUgY2hhbmdlZCBh
dCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVr
c2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQoNClJl
dmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdl
bg0KDQo=
--------------rmIo1mWa0UyW0sTQOsQREdIs
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------rmIo1mWa0UyW0sTQOsQREdIs--

--------------KHvJsSqJ93ody3CVU19hTJGa--

--------------COYPuJ0aVYQZUKZvn6WujwFM
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+2BQFAwAAAAAACgkQsN6d1ii/Ey9Z
Kgf/YltbhejnIGlQdCRC4qFtt583thvkAOfdDdVUV42HS1V1S5og3hteafdNGOsJIfXxshr3C6xN
diu1BKRb9lhG83HG9PIHBNdXHUphhzuJOuyw8ezq5CfiY7yqxROkr51CX8SkNs4P4HL8nE6+hdaY
4Q2mlyqx/bRXTLpEvtfjI4QSs6jcquUQw+TBWUzJziuxVdj3X0xl6LXXTxw01srhTIP+Y2+uH7cv
3pWl94un7sqsV3nnFZ28ng1dfVL4LHBgnRxubw9ujXbcYjWa5vIiIy231UfZBFj3TrcvKLxQqOXQ
T3K0PHbTd0WTCuWjnVHgZOScMetwBCv8pMitWSkPWw==
=tMTN
-----END PGP SIGNATURE-----

--------------COYPuJ0aVYQZUKZvn6WujwFM--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:29:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:29:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416924.661614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQwm-00070e-LV; Thu, 06 Oct 2022 13:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416924.661614; Thu, 06 Oct 2022 13:29:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogQwm-00070X-It; Thu, 06 Oct 2022 13:29:56 +0000
Received: by outflank-mailman (input) for mailman id 416924;
 Thu, 06 Oct 2022 13:29:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G1sz=2H=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ogQwl-0006oe-8x
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 13:29:55 +0000
Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com
 [2a00:1450:4864:20::529])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6975b6e-457a-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 15:29:54 +0200 (CEST)
Received: by mail-ed1-x529.google.com with SMTP id w10so2825104edd.4
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 06:29:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6975b6e-457a-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=6ZdDTmo4+335EbBvlEmQjT8GDpny2W8EHJfskLeQgYU=;
        b=OM8dnY2tg5vevPKL7Mnvbt5ETiaM4d58uhREXqFxxKt0/V8KauGHkWTvb7x2Oqt0IQ
         aEejxhNdge0oFvaJY8CAdxgnWAgK4wSbysP8CQBrYZU3tVc/HUG18oqON1Qc4k0HyvmX
         xlO3nuv08QPmrsaC57vOL93rMqf5EgWpd8LoA0wI1km1qOGq2FaqvoFLcrHX61sGkweU
         UCD0Mp5xzvsFNg18sdEOvnJG0+cBg12+ROqA3DOYIVWuyz7cndaSK170EIJX7lh9BErx
         EWob7RD84FlsXzau9HMYQ7oaLWlnBSdFxt77whBg73BDOMcQkml0e3x8yR7IJXGg4cVc
         iYgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=6ZdDTmo4+335EbBvlEmQjT8GDpny2W8EHJfskLeQgYU=;
        b=H7ceR4NUZxjWo3DDZerOKqRXNK6fTAO1xiR4trJuEimoOvYB3jxkXfPIwQachTLZOb
         5aqar8TdorIN/+98+0yB9RvN2mmdKashMa1bLbyWxslvpeI0hf+8nw1Azp73zVnQr8hV
         E6RCR8bnYbEgsmW4L5jgfROh1nLQKMLtsLhwiJGz0da6h5uXqGuDNcfncuSMcAf3qUe6
         qGDu6mU7jEoaLjhjQ7DNVYrvmktM8o/VESVQ6Vt266aYKMyWHJLu2sDENPXteV2NSeZF
         iAOXKkj73YupKZcI50UgfuoRCuQanLvWJNjrF9dSyAwf/6pS1/cjn4DkvcVfYZYvb8+1
         ArQg==
X-Gm-Message-State: ACrzQf1pwJO28NDizSvR/ufHm9NpFzB/ET4dIqezkOWX9Jcz9+cfuWQv
	lyiUyIsp7XIXWKuwDkrhHuADtvaKaAwQXrq8AeY=
X-Google-Smtp-Source: AMsMyM5EPdeLuWOWDgXAOEFMd2VbWS3fbiofJOic5lMpfbYcw1O+Uxlkjte/6Xq5LeSybtdVQY6hogt1NJyXHeeymfo=
X-Received: by 2002:a05:6402:524d:b0:459:3619:9cfa with SMTP id
 t13-20020a056402524d00b0045936199cfamr4749148edd.227.1665062993966; Thu, 06
 Oct 2022 06:29:53 -0700 (PDT)
MIME-Version: 1.0
References: <20221006092929.30041-1-jgross@suse.com>
In-Reply-To: <20221006092929.30041-1-jgross@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 6 Oct 2022 09:29:41 -0400
Message-ID: <CAKf6xpvS20J0oz6vn+g47OBbKxEhAC8f2gyQ9otj+rOn+L9FOw@mail.gmail.com>
Subject: Re: [PATCH] xen/pcifront: move xenstore config scanning into sub-function
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Bjorn Helgaas <bhelgaas@google.com>, 
	xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 6, 2022 at 5:29 AM Juergen Gross <jgross@suse.com> wrote:
>
> pcifront_try_connect() and pcifront_attach_devices() share a large
> chunk of duplicated code for reading the config information from
> Xenstore, which only differs regarding a function call.
>
> Put that code into a new sub-function. While at it fix the error
> reporting in case the root-xx node had the wrong format.
>
> As the return value of pcifront_try_connect() and
> pcifront_attach_devices() are not used anywhere make those functions
> return void. As an additional bonus this removes the dubious return
> of -EFAULT in case of an unexpected driver state.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/pci/xen-pcifront.c | 133 +++++++++++--------------------------
>  1 file changed, 40 insertions(+), 93 deletions(-)
>
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
> index 689271c4245c..a68e47dcdd7e 100644
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -819,76 +819,79 @@ static int pcifront_publish_info(struct pcifront_device *pdev)

>         err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend,
>                            "root_num", "%d", &num_roots);
>         if (err == -ENOENT) {
>                 xenbus_dev_error(pdev->xdev, err,
>                                  "No PCI Roots found, trying 0000:00");
> -               err = pcifront_scan_root(pdev, 0, 0);
> +               if (rescan)
> +                       err = pcifront_rescan_root(pdev, 0, 0);
> +               else
> +                       err = pcifront_scan_root(pdev, 0, 0);

Early in pcifront_rescan_root(), we have:

        b = pci_find_bus(domain, bus);
        if (!b)
                /* If the bus is unknown, create it. */
                return pcifront_scan_root(pdev, domain, bus);

pcifront_scan_root() does some allocation, but the later scanning
matches that of pcifront_rescan_root().  So I think we can just always
call pcifront_rescan_root() and it should do the right thing.  That
drops the need for the rescan boolean.

Regardless of the above idea:

Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:33:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:33:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416933.661626 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogR0B-0008OO-5I; Thu, 06 Oct 2022 13:33:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416933.661626; Thu, 06 Oct 2022 13:33:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogR0B-0008OH-16; Thu, 06 Oct 2022 13:33:27 +0000
Received: by outflank-mailman (input) for mailman id 416933;
 Thu, 06 Oct 2022 13:33:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogR09-0008O5-3j; Thu, 06 Oct 2022 13:33:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogR09-0005zO-11; Thu, 06 Oct 2022 13:33:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogR08-0001Xg-K2; Thu, 06 Oct 2022 13:33:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogR08-0006J0-Jb; Thu, 06 Oct 2022 13:33:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LMZCxodjOKqIzjl+/C+ykHcjtJcVPpPwesMlfKckgxM=; b=tRx4v+bd02QclsRS03rWGUCJRd
	/ZT9AhMF91K+BlWPYplrk5wxMHJvl502XevXBD+DcqwPobnt8ckx8TsWpJ5bMopmNQ91XYV2sLUpE
	xgm3pSran/60oVKsQ9+7AGojs/r0tNHUXgQtFoIwVw5JuZTRNYst+FCijmOCWXoVBifo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173435-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173435: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=1dcdc92c72af5311666df64f5f04d6600af262ed
X-Osstest-Versions-That:
    qemuu=efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 13:33:24 +0000

flight 173435 qemu-mainline real [real]
flight 173445 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173435/
http://logs.test-lab.xenproject.org/osstest/logs/173445/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install       fail pass in 173445-retest
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 173445-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173408
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173408
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173408
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173408
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173408
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173408
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173408
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173408
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                1dcdc92c72af5311666df64f5f04d6600af262ed
baseline version:
 qemuu                efbf38d73e5dcc4d5f8b98c6e7a12be1f3b91745

Last test of basis   173408  2022-10-03 22:08:40 Z    2 days
Failing since        173431  2022-10-05 14:38:25 Z    0 days    2 attempts
Testing same since   173435  2022-10-06 01:10:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Bernhard Beschow <shentey@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Gerd Hoffmann <kraxel@redhat.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Laurent Vivier <laurent@vivier.eu>
  Leandro Lupori <leandro.lupori@eldorado.org.br>
  Markus Armbruster <armbru@redhat.com>
  Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Ray Zhang <zhanglei002@gmail.com>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Taylor Simpson <tsimpson@quicinc.com>
  Tong Zhang <t.zhang2@samsung.com>
  Wang, Lei <lei4.wang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   efbf38d73e..1dcdc92c72  1dcdc92c72af5311666df64f5f04d6600af262ed -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 13:50:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 13:50:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416944.661637 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogRGq-0002Tj-NI; Thu, 06 Oct 2022 13:50:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416944.661637; Thu, 06 Oct 2022 13:50:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogRGq-0002Tc-KT; Thu, 06 Oct 2022 13:50:40 +0000
Received: by outflank-mailman (input) for mailman id 416944;
 Thu, 06 Oct 2022 13:50:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogRGp-0002TS-9M; Thu, 06 Oct 2022 13:50:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogRGp-0006JU-5Y; Thu, 06 Oct 2022 13:50:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogRGo-00021Z-Ov; Thu, 06 Oct 2022 13:50:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogRGo-0001TI-OR; Thu, 06 Oct 2022 13:50:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JUTstxuuSa3Lp6635n2KcSN8o+NDLa2Fhq7RWNv2Fcg=; b=unMSvggSPa1GTy0LSxCOCd1zC8
	ZsVGIrxZRXrLlFwSyX0VAhsr0LW46SsVQqGNTYyVhmqZNwFWOuQHL6Y52npHVNkoWJpCkxU0KDjaH
	PR6IDnnxHGfLl4C4nwC/wBEzig7I+9dezFTFGV3CVfQrLGIs8SqjZeD8V7m56AC8jtok=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173436-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173436: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=66a5633aa038f4abb4455463755974febac69034
X-Osstest-Versions-That:
    xen=66a5633aa038f4abb4455463755974febac69034
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 13:50:38 +0000

flight 173436 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173436/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173430
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173430
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173430
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173430
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173430
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173430
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173430
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173430
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173430
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173430
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173430
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173430
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  66a5633aa038f4abb4455463755974febac69034
baseline version:
 xen                  66a5633aa038f4abb4455463755974febac69034

Last test of basis   173436  2022-10-06 01:51:54 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 14:11:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 14:11:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.416955.661648 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogRai-00051s-GP; Thu, 06 Oct 2022 14:11:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 416955.661648; Thu, 06 Oct 2022 14:11:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogRai-00051l-DL; Thu, 06 Oct 2022 14:11:12 +0000
Received: by outflank-mailman (input) for mailman id 416955;
 Thu, 06 Oct 2022 14:11:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fMX9=2H=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogRah-00051f-EB
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 14:11:11 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2045.outbound.protection.outlook.com [40.107.104.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4cf375c-4580-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 16:11:01 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB9095.eurprd04.prod.outlook.com (2603:10a6:20b:446::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.34; Thu, 6 Oct
 2022 14:11:06 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022
 14:11:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4cf375c-4580-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HQY8qQKXtwaxQfpFwl+gRIFUWFfUJbJNCyMbWuaeJxbQ2VzHFCM98acYw0Qdjz1Wr6fLFvTSFPc4kMuHUQYr2ec43NWBjMB8hwa86nTKBFV+4Dk+P7hHIRjRm7qNNo8BkRqZd3epAbrFeAxsEYcnR9h/fqkp3beZnMWINxyj/qXFlLFvJlYNzpBVn9817V99mXugz9hxTDigAaVtxgK1hsaUllvMQ1/2hwkBETMYt47xiAOPyrCmL/jdoNnIdPceGqh/KWHEhJ6SZWAimpFBquC2HNCKqwLNJqa0vtvkBtkebNeDdTcuTulwPHk18amQ9fBMC/4un9FV3S5qLFKE+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0pz1W/H2h5XtXFa0UQneZo4oi84KfpylOCNDTJXxQj0=;
 b=JWWUm/SxywWOSXINWyCJHgizQvC6ANrUdxNw2QKzsZsNRYkCmePXmg7sibGmVqrASclxWkZAQkf9sWAeYfVzqyyfirjzp1qjc/8TXuFMKfELpvgDszBhF81LyDr/Iz90EOQrxLAAC8viQHmt2o9UMkHYQ6fyDFev8zL9an+g62U21zUu+UJo48BylZRZNE4IPsvXDdwbVOTfY77Dg/Wqv2shAPdbDOw2iUSBgIBaOQ1DPeJ6DOwQLpDSx044fQxxbU7nLlbb6bviXMbg1bqrLwmd8FtE+R81ssmyovUTDnoWkA/fuTt+hP76sdX7cLrnRY7oIxNH2ZdMHT3XnjMH2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0pz1W/H2h5XtXFa0UQneZo4oi84KfpylOCNDTJXxQj0=;
 b=cqglidh98wiKSQHZ0IWCRSKb/BIdpxmh3L/8Vaid91Kawf0HRDVOBhITW0ydiR7tgk6viAPQxWH0DopIwVNU3rNtRy8p7o9YKcV5DWAxT7HmE5VphQb88kUektWx7jW2IVa/GnNdsaiRwfbxChsAJGZBYt2suYymR73S3fTOmUVakOWgmG/uYuhv7ID59puHBPWKajuTyxNgfAJvkLG/idGzN4+no6uFb3QGpuB4AAQQGDrFdrKzR4j93HJKI3E2+Bu+EKnLeL3WR4oJ+aPsO9gx/dEvGogtTiyo1/Wpmcn9uMG+QpABC2KLq+Ayc4OUzgNzyj0nC7XSdhDfdppgWg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <82963a1c-3301-72ff-e995-77c30ec5a64b@suse.com>
Date: Thu, 6 Oct 2022 16:11:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
 <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
 <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
 <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com>
In-Reply-To: <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9095:EE_
X-MS-Office365-Filtering-Correlation-Id: 52c421f1-6975-42af-03f3-08daa7a49c39
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aAyyJambzmouDSzht1N5r7nSlj0AUMbbDRgdld+OHnNNcEkU3oahBjTxeqGplCaYu1NcE61DFFKf1JxHkZtvXkLIOYLIE0FxSdOTnYVIqOsb0ZwpiAFl4Z+ym3AdisCEwOulPr0BpRJ6IdOBiDpsV/xnthcJUQjB1pI3io8RGsNOGzVtie+9NMngkYa2qomtg2u8hIQaipf5JY8uGV/nhwbBa4lPos5SxfMVP3DbbDOBbaP8Ow9l7G3I1CSz4u4ianh/+RoYY1v+2LMN7OXa75scOfTMus4aRCkfz3lvqsLcR1yPBiFpNdFCnIazLRzUOu8J8rOyqhGyLABI+U8YUVTeLlHSYeADpsuQY2SnvDwnYDdP0pTZoLYBYced6jSQI4nmLp6Oq7aDqPkTq8RtlwP5yXfMDRv4Dpev56QgjCU0o01imSW2McQPwrw0GOZFHeIk1GSkvjqCBB42gVbtRLiNuZQW0DxIyswN5cJVzZIO25tZcfZWmtdx67wi2qNgy/aO5SyB6NKnl0dH35tlqGfGafrLuCEwOEB3knEt/SYql2qWnItd1RiipQl7mn/KcLXVZJ2u+dWdZcloAoMXO4JHl8y8SKLWxigVbJBKDHhrl0pMsSOW3OK6UW3zKZ1PWZhYtOjS241YvvsPqqs8Qs6CkaIoHvlmk+yJy3HpQsHMH24PK2tu9sVgpJ5vn7Ep9x63+dISkakzVPmVyqK9/8mI6prLFtPZxBuUA02sgG7qUHak2VeXlU3kagkqeh9dioqfX4Z5gG8bHNrySjjCT6r3Ag2PB7/BSRiP48bu5Zk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(376002)(39860400002)(346002)(451199015)(5660300002)(31686004)(2906002)(8936002)(66556008)(4326008)(66946007)(8676002)(83380400001)(38100700002)(66476007)(6916009)(36756003)(316002)(41300700001)(54906003)(6512007)(26005)(186003)(31696002)(86362001)(2616005)(53546011)(6506007)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WlAzSEFIbGtwby96bU92Ump5U0I5QmRubkVTNU9IVVYrdUdJK3ZpYWZnNC93?=
 =?utf-8?B?bStOS29HQVY2Q2FlRDRKdHlpcjRSVVIzRDRCUnpaWVU5Z0IvQVZOZHc0OSti?=
 =?utf-8?B?ZXBOVlRBamNVWVliYzh5ZkRlQWh0ZklRZEE3eWEvS2FJVStVRUYxclE2eVJJ?=
 =?utf-8?B?YkVYbDhVOUV6TXNpeVNtaThOd0FUMjJNbUxyajFNTlRGUlRNYlR4RHdMSmFo?=
 =?utf-8?B?OGJUUVhWT2VrQ3hlZ3RxZVVTTm5obmVzakhEMWMyMmFieENtQUpzOHFDbTZX?=
 =?utf-8?B?QUtBbGtaUVRhbVRtTkpmNjFrUit6OUpERW9TUk9xZzUzTHVWTVptNUsvVmJI?=
 =?utf-8?B?OFlHZDVUMWwyeWdVT2tZaytJZXdtTGlWRXhiZzJNUC9ONTlLdExkVHdCeGRI?=
 =?utf-8?B?OGJ1TUhLaklDVnRsTnJDMURKN3UvR1pLSUNZMXA3V3JNZkRaWGNFUGFjcWhE?=
 =?utf-8?B?UzlqcDdaWit5aW5TY1RFbXdNOGtNeXk4a292UW5BM281U2ExUFczY2JuT2J1?=
 =?utf-8?B?MmFQMy9obFA4aVFqWmFlVG51aUNJVEVjWU4yZGliNm0raU5FUU1wTW5Vb1cw?=
 =?utf-8?B?Vzc0OGxGVFJkajRCR0JNK2VFMHdwZFJ2Yng0aEJOVFdlVEQwUDBqTkJNKzRj?=
 =?utf-8?B?eHJlNTdsaS9SS29sUjZNUUY0ZmlJalJTa2xoL0U5TTMvTzZWS1RwSmIyeldt?=
 =?utf-8?B?RVlZRWV0cWJEL2luWmVhbGJRSWNzWEhsTE5kaTBtaUJhRWJPZ283MklaVjM0?=
 =?utf-8?B?b3REWjhjeDZRVlhkd01MRlBwZFdqOGZ0eFFsRDJPQ09ONzhpaTBnUU9odHZQ?=
 =?utf-8?B?c0JkKzlPZjV4eXFha1ExTndCU1Z6anNsWVFyQm1tUFFhMmZMUWw1ZXJyTC9T?=
 =?utf-8?B?RFNINkZpTEpJeklKaTErZ04ySFpBZmNyelJHcWFsRlQwMUVBUHQ5MFFSdUpJ?=
 =?utf-8?B?YVcxbDF5TXd1SzJ1WGQ2US9sdTQxcG9YQ1kvM1Q1YXE3bEpueW9tZVRmdXBC?=
 =?utf-8?B?c3RtRGdKZVdPWjFpa2duMnhTK0tPdTJicWxOUUJnS1ROTkVwbm04NDNSVG9O?=
 =?utf-8?B?SHJkQUQ0bTIzWVZ5Mmx6cis3MjNBTFZnL1NKazhYMFROQXp4MnZvbTNnM1Fw?=
 =?utf-8?B?ZnlYOGRhMW0zQUxPRWFEb1E2ODJOVTV0eEE2K1dZZ1M5aUN4OGJ0eEdqa3RL?=
 =?utf-8?B?aHVYN3R1NGY3S3JwUkNscjFTei90L21jK2ZZZnBJSEswanVXS0IxSGNTM1BU?=
 =?utf-8?B?dGdENEhCRWcvUERnUlJYeTNyVVFVT3Mra2Q2UkFoOVRrVVVIY2tvTXJ4ZzRp?=
 =?utf-8?B?aTBwcWNTVWNPZjhJRXlucVlEcVBseVF6ZVVVQyttSm5LQXRKeW1CQ0hRaDg0?=
 =?utf-8?B?RlJrSSszYTU5YWx5SWs3d0tnYzZyeXViNXcySjNoYjdMMlkxckhjMmVibzR6?=
 =?utf-8?B?VjYyZlJkUFdDWEJUaTFDOHNHYUpZaEQyUzhLODQ4WU02aHZ4MmFlaVpCNGRw?=
 =?utf-8?B?ZFB6RTVDOGdSZHhiWCtlbVZiR2lvSDJxcmVWMG1USXZNREhIOHFvdGUzNjVT?=
 =?utf-8?B?UVpSeHBBZXVlNDAxTlNsemgyRXJndzVKd1NEVUNRa1ltcnJoUjhzUEdZa0Ri?=
 =?utf-8?B?cXN0a21jbkVZUXBYNC9BNTlGZnUzR2VETElCbk01ZkFLUWR6V2dKRlNsOE9m?=
 =?utf-8?B?VTBZRDI3ZDdMQmlrWGlwUldBR1VIUVRKS0xXWWZzdis3eDY4WUZWS0VZWXJu?=
 =?utf-8?B?RlBHWmN3a0U4bWRBNnFjcTdqWWc4QzZVUlJpaCs2TVVkNWtGeTBtVGlDcWU2?=
 =?utf-8?B?bFpuaGNYNGxpYVJ6RDhVWFdhSmQwSmEvZ212bTNvNGF6ck9iTmxxMmZEdUkz?=
 =?utf-8?B?VjlBaVBoZnYyNkZNejBxQVV5ckE4MHkrSm9JcVBUNHkxd01ZRVd0WmsrR3c2?=
 =?utf-8?B?Z2JXNlo1MFlkc2t3eEpOcmJycnRldnBtU2RTUEo0NC9jYStJR01OOVY0d011?=
 =?utf-8?B?S0k0QVRneERDYXBpSGNpOFBwZk9kMThBODZxOXR2THFhWWlueExQdmxkNm1S?=
 =?utf-8?B?S0lYUFg2anNvem4yc3pnL3Nrd1ZpWlhma3ZsOXVtY1p1WEMvTDFiTE4waUNL?=
 =?utf-8?Q?qlKOClfiOtal6TzzrDUdMH+K2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52c421f1-6975-42af-03f3-08daa7a49c39
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 14:11:06.6616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iexmPuzBQsj+a4B238QY6lGk5ZDqAYGxttdvt9xI0wMVTwN4dHO9HgW5PxeJA8E7XdJUMGxnaOYDv16Ji5bKKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9095

On 06.10.2022 10:39, Jan Beulich wrote:
> On 05.10.2022 20:09, Julien Grall wrote:
>> Hi Jan,
>>
>> On 05/10/2022 12:55, Jan Beulich wrote:
>>> On 05.10.2022 12:44, Julien Grall wrote:
>>>> On 04/10/2022 16:58, Jan Beulich wrote:
>>>>> On 30.09.2022 14:51, Bertrand Marquis wrote:
>>>>>>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>>>
>>>>>>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>>>>>>> higher priority than the type of the range. To avoid accessing memory at
>>>>>>> runtime which was re-used for other purposes, make
>>>>>>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>>>>>>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>>>>>>> E820_ACPI memory there and hence that type's handling can be left alone.
>>>>>>>
>>>>>>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>>>>>>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>>>>>>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>>
>>>>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm
>>>>>
>>>>> Thanks. However ...
>>>>>
>>>>>>> ---
>>>>>>> Partly RFC for Arm, for two reasons:
>>>>>>>
>>>>>>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>>>>>>> For one like on x86 such ranges would likely better be retained, as Dom0
>>>>>>> may (will?) have a need to look at tables placed there. Plus converting
>>>>>>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>>>>>>> me as well. I'd be inclined to make the latter adjustment right here
>>>>>>> (while the other change probably would better be separate, if there
>>>>>>> aren't actually reasons for the present behavior).
>>>>>
>>>>> ... any views on this WB aspect at least (also Stefano or Julien)? Would be
>>>>> good to know before I send v2.
>>>>
>>>> I don't quite understand what you are questioning here. Looking at the
>>>> code, EfiACPIReclaimMemory will not be converted to RAM but added in a
>>>> separate array.
>>>>
>>>> Furthermore, all the EfiACPIReclaimMemory regions will be passed to dom0
>>>> (see acpi_create_efi_mmap_table()).
>>>>
>>>> So to me the code looks correct.
>>>
>>> Oh, I've indeed not paid enough attention to the first argument passed
>>> to meminfo_add_bank(). I'm sorry for the extra noise. However, the
>>> question I wanted to have addressed before sending out v3 was that
>>> regarding the present using of memory when EFI_MEMORY_WB is not set.
>>> Is that correct for the EfiACPIReclaimMemory case, i.e. is the
>>> consumer (Dom0) aware that there might be a restriction?
>>
>> Looking at the code, we always set EFI_MEMORY_WB for the reclaimable 
>> region and the stage-2 mapping will be cachable.
>>
>> So it looks like there would be a mismatch if EFI_MEMORY_WB is not set. 
>> However, given the region is reclaimable, shouldn't this imply that the 
>> flag is always set?
> 
> Possibly (but then again consider [perhaps hypothetical] systems with e.g.
> just WT caches, where specifying WB simply wouldn't make sense). In any
> event, even if that's the case, being on the safe side and doing
> 
>         if ( (desc_ptr->Attribute & EFI_MEMORY_RUNTIME) ||
>              !(desc_ptr->Attribute & EFI_MEMORY_WB) )
>             /* nothing */;
>         else if ( ...
> 
> would seem better to me. However, if the mapping you mention above
> would be adjusted and ...
> 
>>> And would
>>> this memory then be guaranteed to never be freed into the general pool
>>> of RAM pages?
>>
>> The region is not treated as RAM by Xen and not owned by the dom0. 
>> Therefore, it should not be possible to free the page because 
>> get_page_from_gfn() would not be able to get a reference.
> 
> ... the space cannot become ordinary RAM, then such a precaution
> wouldn't be necessary. After all hiding EfiACPIReclaimMemory from
> Dom0 just because it can't be mapped WB wouldn't be very nice
> either. I guess I'll submit v2 with this part of the change left
> as it was.

And while already in the process of committing the patch I came to
realize that if the WB conditional isn't supposed to move, isn't
the change done for Arm then wrong as well? Shouldn't it then be

        if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
             (desc_ptr->Attribute & EFI_MEMORY_WB) &&
             (desc_ptr->Type == EfiConventionalMemory ||
             ...

leaving the EfiACPIReclaimMemory case entirely unaffected by the
change?

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 14:44:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 14:44:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417081.661712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogS6O-0003EY-Fv; Thu, 06 Oct 2022 14:43:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417081.661712; Thu, 06 Oct 2022 14:43:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogS6O-0003ER-DI; Thu, 06 Oct 2022 14:43:56 +0000
Received: by outflank-mailman (input) for mailman id 417081;
 Thu, 06 Oct 2022 14:43:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rxxd=2H=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ogS6M-0003EL-FS
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 14:43:55 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46eaa7f5-4585-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 16:43:45 +0200 (CEST)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 965935C0159;
 Thu,  6 Oct 2022 10:43:50 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Thu, 06 Oct 2022 10:43:50 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 6 Oct 2022 10:43:47 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46eaa7f5-4585-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1665067430; x=
	1665153830; bh=RIza5YEVq9kGHVwK/oXAKTC2G5qfFHbR5jwJnE/LvGw=; b=C
	jpqpAwYRLFwlef2LBQuo3eS2s8bXcvx+1/IziZsuDx8Vl8op9+rskQHaEc51kOqW
	Tq4M1/kHTCZJx3GLXcxnaP4VwiD7ZADzZwPT2AXOAh2ZfID+tgpSGaxu41k1PgNE
	zl8+gz42Xm1du7ERR3/i3/ch0tLQbt5kLQ/TsVl3o9woTUuLs8uPEk5Meob5gPIk
	oDMjnZd3F0BwwFMoXleO/s8AxS7c+DdH7oMWM437m6zipP0JLpg6+BvUQ6O/bs6s
	M+PBj4wC3dIBcsjuKafzNHK3Fx1+rDOQP/YGCfh8QI+eG7EAQFafXaL2tlbq8cmP
	d5bQYgE1CzCwDQintM7hA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1665067430; x=1665153830; bh=RIza5YEVq9kGHVwK/oXAKTC2G5qf
	FHbR5jwJnE/LvGw=; b=0hXUyPVrVcGDGumEK8ou1p8RxJdVW1wBRrK6sht0NZfQ
	51CbSsYGroAOJzC9yqc6BUNzvz7mpp9SiggJ81smG0DtjJ3YAYItkFQqDe1nUltW
	/EyWb5Zw3H+H3K7eso0EvyH9xhMCisGekBNZq9G7Qmx2BBiP4XStoBFzRRHhzlv2
	EMP1RytYurSl2MM29PFuTZZfzYN6V9BTfLSQv8rbAMKb5b7DeYEbDSMZJ96yCjPl
	ICjMPbLbZhn9sbgzE0s5xKCaK5kk1oWEcSMAkG6cP2E4blMToxbwwT3Xz30ZyAcy
	MKiEFMhmgTruOxBaKvBvOAzbMHs4tCHiDVrCTcI6ag==
X-ME-Sender: <xms:pOk-Y0KDgcCf_xmLcbk33w22a6ontLsPrexU2Z97eQx5DYVjvidhqw>
    <xme:pOk-Y0JL4NdbCAlqtMHoKcWNcYb-_qGp3yLqb7K7-vTx-aor0BlV2r5ANNQEuVisK
    7FPt6glt8IxpnU>
X-ME-Received: <xmr:pOk-Y0uvVQK_1fMoj3OStxcoSj7oZyjf_ZLPyWHFUZhMj55F7GNFDegVr3SP>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeihedgkedtucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg
    jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:pOk-YxZxAOLfRVAzEhzErTSRJBaCCqz-UkN2U8gXfW_4lbPsW2kw1w>
    <xmx:pOk-Y7auVTCZKDo5JRGnyH6DsT0TFs22rQWy3f44_7dbiVNPGBZi-Q>
    <xmx:pOk-Y9CDIfRzzTVt_AVgsviDafU2t2am1fmB85s4cXXWlKUdprMpZg>
    <xmx:puk-Y4Ra_esZgB9IXtDuUP47nhTJ8FmUXQeEIGWodj9aTzw2Hz2u2w>
Feedback-ID: iac594737:Fastmail
Date: Thu, 6 Oct 2022 10:43:43 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Message-ID: <Yz7polT2R2OlT1aT@itl-email>
References: <YzcjeiOW8+i2Zxsd@itl-email>
 <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email>
 <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email>
 <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email>
 <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
 <Yz4yLyvX6un1rrqC@itl-email>
 <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZVyM5aEaeTsHYcp0"
Content-Disposition: inline
In-Reply-To: <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>


--ZVyM5aEaeTsHYcp0
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 6 Oct 2022 10:43:43 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered

On Thu, Oct 06, 2022 at 09:31:47AM +0200, Ard Biesheuvel wrote:
> On Thu, 6 Oct 2022 at 03:41, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Wed, Oct 05, 2022 at 11:28:29PM +0200, Ard Biesheuvel wrote:
> > > On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
> > > <demi@invisiblethingslab.com> wrote:
> > > >
> > > > On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > > > > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > > > > Linux has a function called efi_mem_reserve() that is used to r=
eserve
> > > > > > EfiBootServicesData memory that contains e.g. EFI configuration=
 tables.
> > > > > > This function does not work under Xen because Xen could have al=
ready
> > > > > > clobbered the memory.  efi_mem_reserve() not working is the who=
le reason
> > > > > > for this thread, as it prevents EFI tables that are in
> > > > > > EfiBootServicesData from being used under Xen.
> > > > > >
> > > > > > A much nicer approach would be for Xen to reserve boot services=
 memory
> > > > > > unconditionally, but provide a hypercall that dom0 could used t=
o free
> > > > > > the parts of EfiBootServicesData memory that are no longer need=
ed.  This
> > > > > > would allow efi_mem_reserve() to work normally.
> > > > >
> > > > > efi_mem_reserve() actually working would be a layering violation;
> > > > > controlling the EFI memory map is entirely Xen's job.
> > > >
> > > > Doing this properly would require Xen to understand all of the EFI
> > > > tables that could validly be in EfiBootServices* and which could be=
 of
> > > > interest to dom0.  It might (at least on some very buggy firmware)
> > > > require a partial ACPI and/or SMBIOS implementation too, if the fir=
mware
> > > > decided to put an ACPI or SMBIOS table in EfiBootServices*.
> > > >
> > > > > As to the hypercall you suggest - I wouldn't mind its addition, b=
ut only
> > > > > for the case when -mapbs is used. As I've indicated before, I'm o=
f the
> > > > > opinion that default behavior should be matching the intentions o=
f the
> > > > > spec, and the intention of EfiBootServices* is for the space to be
> > > > > reclaimed. Plus I'm sure you realize there's a caveat with Dom0 u=
sing
> > > > > that hypercall: It might use it for regions where data lives whic=
h it
> > > > > wouldn't care about itself, but which an eventual kexec-ed (or al=
ike)
> > > > > entity would later want to consume. Code/data potentially usable =
by
> > > > > _anyone_ between two resets of the system cannot legitimately be =
freed
> > > > > (and hence imo is wrong to live in EfiBootServices* regions).
> > > >
> > > > I agree, but currently some such data *is* in EfiBootServices* regi=
ons,
> > > > sadly.  When -mapbs is *not* used, I recommend uninstalling all of =
the
> > > > configuration tables that point to EfiBootServicesData memory before
> > > > freeing that memory.
> > > >
> > >
> > > That seems like a reasonable approach to me. Tables like MEMATTR or
> > > RT_PROP are mostly relevant for bare metal where the host kernel maps
> > > the runtime services, and in general, passing on these tables without
> > > knowing what they do is kind of fishy anyway. You might even argue
> > > that only known table types should be forwarded in the first place,
> > > regardless of the memory type.
> >
> > Which tables are worth handling in Xen?  I know about ACPI, SMBIOS, and
> > ESRT, but I am curious which others Xen should preserve.  Currently, Xen
> > does not know about RT_PROP or MEMATTR; could this be a cause of
> > problems?
>=20
> dom0 only has access to paravirtualized EFI runtime services, so
> consuming RT_PROP or MEMATTR should be up to Xen (they describe which
> runtime services remain available at runtime, and which permission
> attributes to use for the runtime services memory regions,
> respectively)

Xen does not do this right now.  I wonder if this could be the cause of
compatibility issues with various firmware implementations.

> Looking through the kernel code, I don't think there are any that dom0
> should care about beyond ACPI, SMBIOS and ESRT. But as you suggest,
> that means Xen should just mask them in the view of the EFI system
> table it exposes so dom0. Otherwise, the kernel may still try to map
> and parse them.

What about the BGRT and MOKvar?  I agree that Xen should not expose the
others.  Should it just hide the tables, or should it actually uninstall
them?  My intuition is that the second would be technically more
correct, but also more likely to trigger bugs in various firmware
implementations.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--ZVyM5aEaeTsHYcp0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM+6aIACgkQsoi1X/+c
IsFo8RAAgjtyIjW/PLv2jyj2EWtPqAVxnZFx2DTiTcEkOF2+OIcp6PR0K8iOiy7z
017KND97RHNpvCFF1/4smfeo8GW7cx/8H6M+Bk7ZqjyKLb/lJfw66FkNFCF1xER9
ZI6vTxKEfr64htLd4KKNl3isP5DHXFV2ydOW56C+Ztv7TlbvTiO/ZrsnZQFTvTpj
YafEHAmdIUveoL6/rg6at0bjhqrDYwbeAIAN/6l/ZDDTuLyn3cV6nhUg3norGohg
1rsYs7mDWUM/m/1bDhSGN/AYGA39K9cMwTWcw5zEOPxHflvpA2SYWOymnZQYO0ot
cD3/WIkNKk2l5hwNfOSkfzlPrukJg4XBjyWCNSppwlyUAQBcoecypZe8RjR6Ba24
qmzbYk9KqnUWiS/BUthQhvDI5YfcaWu5wxXoGH3pbPtPwelF1sUZQ8Bx37rh97bv
XCPOu6dpuk9OQ/FRM01qI3u5QbiAJsl7Pzd1vHMNeYI2h4KgVhKnb3vkOdlcIX7P
r8Ig9cRUB9YJVFr7T3R4DRNY7+hZLxSG74WUZx8f4IM5pnLO/oMNyQzVYtleqlYf
ZN4sdRDA81V3khHPHwKI1F5sNyWDu94+56e8Qq279hKnZkt4QNp0MgzTNWjTaB/3
bN2EGes0RD22Vt6Bhji1Bk8GnEHdHoYvgwhu0PEhK3BSJaSWh90=
=RkJ/
-----END PGP SIGNATURE-----

--ZVyM5aEaeTsHYcp0--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 15:02:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 15:02:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417089.661724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogSNs-0005ix-WB; Thu, 06 Oct 2022 15:02:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417089.661724; Thu, 06 Oct 2022 15:02:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogSNs-0005iq-Se; Thu, 06 Oct 2022 15:02:00 +0000
Received: by outflank-mailman (input) for mailman id 417089;
 Thu, 06 Oct 2022 15:01:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogSNr-0005ik-BW
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 15:01:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce9a72f7-4587-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 17:01:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 90A711F85D;
 Thu,  6 Oct 2022 15:01:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A20A13AC8;
 Thu,  6 Oct 2022 15:01:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8sihCOXtPmP4eQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 15:01:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce9a72f7-4587-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665068517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SmAmDb37SISjauoN4xpdMA0CBkVXMUvyHWIb/ERmsEQ=;
	b=A1G3cp62M0BwkAiSJtOVQwYsyv0M63UMB5KUE0mHXdg0QNaFplo4nTe2TURanFcH3K2s85
	WPjvT2bZOwg1EpsiLXrX/pZQBi4heYTO1vIujlMcqkEB2TgeiJoJv16yKi9gXhC9jncGaS
	XWoT7yCE8bfwVObe8QyIvER4MOpjhp4=
Message-ID: <d5e199ae-5da8-a25e-ff76-c3a1b05e0a01@suse.com>
Date: Thu, 6 Oct 2022 17:01:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Bjorn Helgaas <bhelgaas@google.com>, xen-devel@lists.xenproject.org
References: <20221006092929.30041-1-jgross@suse.com>
 <CAKf6xpvS20J0oz6vn+g47OBbKxEhAC8f2gyQ9otj+rOn+L9FOw@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/pcifront: move xenstore config scanning into
 sub-function
In-Reply-To: <CAKf6xpvS20J0oz6vn+g47OBbKxEhAC8f2gyQ9otj+rOn+L9FOw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------YPi0Z3Xsawmw8vnE8qg0Q0OL"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------YPi0Z3Xsawmw8vnE8qg0Q0OL
Content-Type: multipart/mixed; boundary="------------qsS4Y1csmvwjP5GAoenBHod8";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Bjorn Helgaas <bhelgaas@google.com>, xen-devel@lists.xenproject.org
Message-ID: <d5e199ae-5da8-a25e-ff76-c3a1b05e0a01@suse.com>
Subject: Re: [PATCH] xen/pcifront: move xenstore config scanning into
 sub-function
References: <20221006092929.30041-1-jgross@suse.com>
 <CAKf6xpvS20J0oz6vn+g47OBbKxEhAC8f2gyQ9otj+rOn+L9FOw@mail.gmail.com>
In-Reply-To: <CAKf6xpvS20J0oz6vn+g47OBbKxEhAC8f2gyQ9otj+rOn+L9FOw@mail.gmail.com>

--------------qsS4Y1csmvwjP5GAoenBHod8
Content-Type: multipart/mixed; boundary="------------0GZcOvDTc8ncAvQxBYsj0s8B"

--------------0GZcOvDTc8ncAvQxBYsj0s8B
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMTU6MjksIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+IE9uIFRodSwgT2N0
IDYsIDIwMjIgYXQgNToyOSBBTSBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+IHdy
b3RlOg0KPj4NCj4+IHBjaWZyb250X3RyeV9jb25uZWN0KCkgYW5kIHBjaWZyb250X2F0dGFj
aF9kZXZpY2VzKCkgc2hhcmUgYSBsYXJnZQ0KPj4gY2h1bmsgb2YgZHVwbGljYXRlZCBjb2Rl
IGZvciByZWFkaW5nIHRoZSBjb25maWcgaW5mb3JtYXRpb24gZnJvbQ0KPj4gWGVuc3RvcmUs
IHdoaWNoIG9ubHkgZGlmZmVycyByZWdhcmRpbmcgYSBmdW5jdGlvbiBjYWxsLg0KPj4NCj4+
IFB1dCB0aGF0IGNvZGUgaW50byBhIG5ldyBzdWItZnVuY3Rpb24uIFdoaWxlIGF0IGl0IGZp
eCB0aGUgZXJyb3INCj4+IHJlcG9ydGluZyBpbiBjYXNlIHRoZSByb290LXh4IG5vZGUgaGFk
IHRoZSB3cm9uZyBmb3JtYXQuDQo+Pg0KPj4gQXMgdGhlIHJldHVybiB2YWx1ZSBvZiBwY2lm
cm9udF90cnlfY29ubmVjdCgpIGFuZA0KPj4gcGNpZnJvbnRfYXR0YWNoX2RldmljZXMoKSBh
cmUgbm90IHVzZWQgYW55d2hlcmUgbWFrZSB0aG9zZSBmdW5jdGlvbnMNCj4+IHJldHVybiB2
b2lkLiBBcyBhbiBhZGRpdGlvbmFsIGJvbnVzIHRoaXMgcmVtb3ZlcyB0aGUgZHViaW91cyBy
ZXR1cm4NCj4+IG9mIC1FRkFVTFQgaW4gY2FzZSBvZiBhbiB1bmV4cGVjdGVkIGRyaXZlciBz
dGF0ZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3Vz
ZS5jb20+DQo+PiAtLS0NCj4+ICAgZHJpdmVycy9wY2kveGVuLXBjaWZyb250LmMgfCAxMzMg
KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPj4gICAxIGZpbGUgY2hh
bmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgOTMgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvcGNpL3hlbi1wY2lmcm9udC5jIGIvZHJpdmVycy9wY2kveGVuLXBj
aWZyb250LmMNCj4+IGluZGV4IDY4OTI3MWM0MjQ1Yy4uYTY4ZTQ3ZGNkZDdlIDEwMDY0NA0K
Pj4gLS0tIGEvZHJpdmVycy9wY2kveGVuLXBjaWZyb250LmMNCj4+ICsrKyBiL2RyaXZlcnMv
cGNpL3hlbi1wY2lmcm9udC5jDQo+PiBAQCAtODE5LDc2ICs4MTksNzkgQEAgc3RhdGljIGlu
dCBwY2lmcm9udF9wdWJsaXNoX2luZm8oc3RydWN0IHBjaWZyb250X2RldmljZSAqcGRldikN
Cj4gDQo+PiAgICAgICAgICBlcnIgPSB4ZW5idXNfc2NhbmYoWEJUX05JTCwgcGRldi0+eGRl
di0+b3RoZXJlbmQsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInJvb3RfbnVt
IiwgIiVkIiwgJm51bV9yb290cyk7DQo+PiAgICAgICAgICBpZiAoZXJyID09IC1FTk9FTlQp
IHsNCj4+ICAgICAgICAgICAgICAgICAgeGVuYnVzX2Rldl9lcnJvcihwZGV2LT54ZGV2LCBl
cnIsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIk5vIFBDSSBSb290
cyBmb3VuZCwgdHJ5aW5nIDAwMDA6MDAiKTsNCj4+IC0gICAgICAgICAgICAgICBlcnIgPSBw
Y2lmcm9udF9zY2FuX3Jvb3QocGRldiwgMCwgMCk7DQo+PiArICAgICAgICAgICAgICAgaWYg
KHJlc2NhbikNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGVyciA9IHBjaWZyb250X3Jl
c2Nhbl9yb290KHBkZXYsIDAsIDApOw0KPj4gKyAgICAgICAgICAgICAgIGVsc2UNCj4+ICsg
ICAgICAgICAgICAgICAgICAgICAgIGVyciA9IHBjaWZyb250X3NjYW5fcm9vdChwZGV2LCAw
LCAwKTsNCj4gDQo+IEVhcmx5IGluIHBjaWZyb250X3Jlc2Nhbl9yb290KCksIHdlIGhhdmU6
DQo+IA0KPiAgICAgICAgICBiID0gcGNpX2ZpbmRfYnVzKGRvbWFpbiwgYnVzKTsNCj4gICAg
ICAgICAgaWYgKCFiKQ0KPiAgICAgICAgICAgICAgICAgIC8qIElmIHRoZSBidXMgaXMgdW5r
bm93biwgY3JlYXRlIGl0LiAqLw0KPiAgICAgICAgICAgICAgICAgIHJldHVybiBwY2lmcm9u
dF9zY2FuX3Jvb3QocGRldiwgZG9tYWluLCBidXMpOw0KPiANCj4gcGNpZnJvbnRfc2Nhbl9y
b290KCkgZG9lcyBzb21lIGFsbG9jYXRpb24sIGJ1dCB0aGUgbGF0ZXIgc2Nhbm5pbmcNCj4g
bWF0Y2hlcyB0aGF0IG9mIHBjaWZyb250X3Jlc2Nhbl9yb290KCkuICBTbyBJIHRoaW5rIHdl
IGNhbiBqdXN0IGFsd2F5cw0KPiBjYWxsIHBjaWZyb250X3Jlc2Nhbl9yb290KCkgYW5kIGl0
IHNob3VsZCBkbyB0aGUgcmlnaHQgdGhpbmcuICBUaGF0DQo+IGRyb3BzIHRoZSBuZWVkIGZv
ciB0aGUgcmVzY2FuIGJvb2xlYW4uDQoNCkhtbSwgd2l0aCBzb21lIG1vcmUgcGNpZnJvbnRf
cmVzY2FuX3Jvb3QoKSBhZGFwdGlvbiB0aGlzIHdpbGwgbWFrZSBpdA0KcG9zc2libGUgdG8g
ZHJvcCBldmVuIG1vcmUgY29kZSAoaS5lLiB0aGUgQ09ORklHX1BDSV9ET01BSU5TIGNoZWNr
IGluDQpwY2lmcm9udF9yZXNjYW5fcm9vdCgpLCBhcyB0aGUgb25lIGluIHBjaWZyb250X3Nj
YW5fcm9vdCgpIHdvdWxkIGJlDQplbm91Z2ggdGhlbikuDQoNCkknbGwgc2VuZCBvdXQgVjIg
c29vbi4NCg0KPiANCj4gUmVnYXJkbGVzcyBvZiB0aGUgYWJvdmUgaWRlYToNCj4gDQo+IFJl
dmlld2VkLWJ5OiBKYXNvbiBBbmRyeXVrIDxqYW5kcnl1a0BnbWFpbC5jb20+DQoNClRoYW5r
cy4gQXMgSSdtIGFib3V0IHRvIGNoYW5nZSB0aGUgcGF0Y2gsIEknbGwgZHJvcCB0aGUgUi1i
Lg0KDQoNCkp1ZXJnZW4NCg==
--------------0GZcOvDTc8ncAvQxBYsj0s8B
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0GZcOvDTc8ncAvQxBYsj0s8B--

--------------qsS4Y1csmvwjP5GAoenBHod8--

--------------YPi0Z3Xsawmw8vnE8qg0Q0OL
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM+7eQFAwAAAAAACgkQsN6d1ii/Ey+X
vQf7B4D1H8RrO9tYlsBJfV3G+8+r4cVAjjphzFF0aLQa7j82YAnjfU2Ge92pUzRq8BOzcagZaJwr
W5vWP9AOtS3ZLFMQO7igZcoxC/iAgd5UMjCU23hyEDQ7UipGc40y+2SiCKmPBnDdtURKWMrTLg3X
VRhOdnWw71aTJ75kD8p+jPbD/Rw0a7w4OvsaekSuV1j32DVtOkV/3fSkBrzQTMiEadV6K5jdIMM3
VsDU7/5zb8TxKz8f6Yt6jBft2I9gfmN1fpPzpoVlLt0rTQAjpmzC/Ebv9DkDQ4htFSjegTguxEWE
MRb0cBxkzAzgQ2V/kde6esmYXIOLOuNFdVx8CIDBUw==
=xL2k
-----END PGP SIGNATURE-----

--------------YPi0Z3Xsawmw8vnE8qg0Q0OL--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 15:24:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 15:24:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417099.661735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogSjg-0008Fk-Sk; Thu, 06 Oct 2022 15:24:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417099.661735; Thu, 06 Oct 2022 15:24:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogSjg-0008Fd-Oy; Thu, 06 Oct 2022 15:24:32 +0000
Received: by outflank-mailman (input) for mailman id 417099;
 Thu, 06 Oct 2022 15:24:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogSjf-0008FR-SY; Thu, 06 Oct 2022 15:24:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogSjf-00082S-OP; Thu, 06 Oct 2022 15:24:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogSjf-0004VX-Ab; Thu, 06 Oct 2022 15:24:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogSjf-00053E-A6; Thu, 06 Oct 2022 15:24:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=I/+V8L2M3T5pfv1zEBMVQHV65V8rljlovk/XVzHHHoA=; b=bsOZj7LQ1WDE6gbPRs5VIBEzM+
	/BIHy6kRzsSxcw2xFXTxjOkkkxIU7IKOC6xMO089UJjf5DAH8pK+OxsJKSpRyGIyeGSa7czBVEOf4
	igrQ92ObFPqOq79NREolX5RN5CUecsrDPeLr8mP5pztRPW/6GqWPJCRgeTQH62WFYHFM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173438-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173438: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=25c473348bc141a82f821a2701e18f9705346a1c
X-Osstest-Versions-That:
    libvirt=92f7aafced8d354cead03e50e1e7d57a99d29435
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 15:24:31 +0000

flight 173438 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173438/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173423
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173423
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173423
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              25c473348bc141a82f821a2701e18f9705346a1c
baseline version:
 libvirt              92f7aafced8d354cead03e50e1e7d57a99d29435

Last test of basis   173423  2022-10-05 04:20:23 Z    1 days
Testing same since   173438  2022-10-06 04:20:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Göran Uddeborg <goeran@uddeborg.se>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   92f7aafced..25c473348b  25c473348bc141a82f821a2701e18f9705346a1c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 15:34:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 15:34:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417110.661746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogStY-0001QT-VS; Thu, 06 Oct 2022 15:34:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417110.661746; Thu, 06 Oct 2022 15:34:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogStY-0001QM-Sd; Thu, 06 Oct 2022 15:34:44 +0000
Received: by outflank-mailman (input) for mailman id 417110;
 Thu, 06 Oct 2022 15:34:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=q1hL=2H=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogStX-0001QG-Fq
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 15:34:43 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 614f726c-458c-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 17:34:35 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BB72821A16;
 Thu,  6 Oct 2022 15:34:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 724B41376E;
 Thu,  6 Oct 2022 15:34:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 7nQUGZH1PmNGCwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 06 Oct 2022 15:34:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 614f726c-458c-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665070481; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=jPrMuJyteEIaUOmAxhKdlol+IAYiy0Vmj2454XJWMy8=;
	b=ufgn8i3nxA5/MEDL7VtUUswRfhdGfm6Au6MkuPeCGpldPf1wdEsKPw4y0C1xnal641rKAl
	4EnXbxIjU/HKfnwYcMycaVulG0IOgPD5v0Am7GH7SD4E+T57Bt9mwiNLRVM+xeA3C69+pE
	TFbMS5xFYhnczjE+pagxg/8fpMVioWg=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2] xen/pcifront: move xenstore config scanning into sub-function
Date: Thu,  6 Oct 2022 17:34:40 +0200
Message-Id: <20221006153440.18049-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

pcifront_try_connect() and pcifront_attach_devices() share a large
chunk of duplicated code for reading the config information from
Xenstore, which only differs regarding calling pcifront_rescan_root()
or pcifront_scan_root().

Put that code into a new sub-function. It is fine to always call
pcifront_rescan_root() from that common function, as it will fallback
to pcifront_scan_root() if the domain/bus combination isn't known
yet (and pcifront_scan_root() should never be called for an already
kneon domain/bus combination anyway). In order to avoid duplicate
messages for the fallback case move the check for domain/bus not knwon
to the beginning of pcifront_rescan_root().

While at it fix the error reporting in case the root-xx node had the
wrong format.

As the return value of pcifront_try_connect() and
pcifront_attach_devices() are not used anywhere make those functions
return void. As an additional bonus this removes the dubious return
of -EFAULT in case of an unexpected driver state.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- always call pcifront_rescan_root() (Jason Andryuk)
---
 drivers/pci/xen-pcifront.c | 143 ++++++++++---------------------------
 1 file changed, 37 insertions(+), 106 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index 689271c4245c..601efdceae63 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -521,24 +521,14 @@ static int pcifront_rescan_root(struct pcifront_device *pdev,
 	int err;
 	struct pci_bus *b;
 
-#ifndef CONFIG_PCI_DOMAINS
-	if (domain != 0) {
-		dev_err(&pdev->xdev->dev,
-			"PCI Root in non-zero PCI Domain! domain=%d\n", domain);
-		dev_err(&pdev->xdev->dev,
-			"Please compile with CONFIG_PCI_DOMAINS\n");
-		return -EINVAL;
-	}
-#endif
-
-	dev_info(&pdev->xdev->dev, "Rescanning PCI Frontend Bus %04x:%02x\n",
-		 domain, bus);
-
 	b = pci_find_bus(domain, bus);
 	if (!b)
 		/* If the bus is unknown, create it. */
 		return pcifront_scan_root(pdev, domain, bus);
 
+	dev_info(&pdev->xdev->dev, "Rescanning PCI Frontend Bus %04x:%02x\n",
+		 domain, bus);
+
 	err = pcifront_scan_bus(pdev, domain, bus, b);
 
 	/* Claim resources before going "live" with our devices */
@@ -819,76 +809,73 @@ static int pcifront_publish_info(struct pcifront_device *pdev)
 	return err;
 }
 
-static int pcifront_try_connect(struct pcifront_device *pdev)
+static void pcifront_connect(struct pcifront_device *pdev)
 {
-	int err = -EFAULT;
+	int err;
 	int i, num_roots, len;
 	char str[64];
 	unsigned int domain, bus;
 
-
-	/* Only connect once */
-	if (xenbus_read_driver_state(pdev->xdev->nodename) !=
-	    XenbusStateInitialised)
-		goto out;
-
-	err = pcifront_connect_and_init_dma(pdev);
-	if (err && err != -EEXIST) {
-		xenbus_dev_fatal(pdev->xdev, err,
-				 "Error setting up PCI Frontend");
-		goto out;
-	}
-
 	err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend,
 			   "root_num", "%d", &num_roots);
 	if (err == -ENOENT) {
 		xenbus_dev_error(pdev->xdev, err,
 				 "No PCI Roots found, trying 0000:00");
-		err = pcifront_scan_root(pdev, 0, 0);
+		err = pcifront_rescan_root(pdev, 0, 0);
 		if (err) {
 			xenbus_dev_fatal(pdev->xdev, err,
 					 "Error scanning PCI root 0000:00");
-			goto out;
+			return;
 		}
 		num_roots = 0;
 	} else if (err != 1) {
-		if (err == 0)
-			err = -EINVAL;
-		xenbus_dev_fatal(pdev->xdev, err,
+		xenbus_dev_fatal(pdev->xdev, err >= 0 ? -EINVAL : err,
 				 "Error reading number of PCI roots");
-		goto out;
+		return;
 	}
 
 	for (i = 0; i < num_roots; i++) {
 		len = snprintf(str, sizeof(str), "root-%d", i);
-		if (unlikely(len >= (sizeof(str) - 1))) {
-			err = -ENOMEM;
-			goto out;
-		}
+		if (unlikely(len >= (sizeof(str) - 1)))
+			return;
 
 		err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str,
 				   "%x:%x", &domain, &bus);
 		if (err != 2) {
-			if (err >= 0)
-				err = -EINVAL;
-			xenbus_dev_fatal(pdev->xdev, err,
+			xenbus_dev_fatal(pdev->xdev, err >= 0 ? -EINVAL : err,
 					 "Error reading PCI root %d", i);
-			goto out;
+			return;
 		}
 
-		err = pcifront_scan_root(pdev, domain, bus);
+		err = pcifront_rescan_root(pdev, domain, bus);
 		if (err) {
 			xenbus_dev_fatal(pdev->xdev, err,
 					 "Error scanning PCI root %04x:%02x",
 					 domain, bus);
-			goto out;
+			return;
 		}
 	}
 
-	err = xenbus_switch_state(pdev->xdev, XenbusStateConnected);
+	xenbus_switch_state(pdev->xdev, XenbusStateConnected);
+}
 
-out:
-	return err;
+static void pcifront_try_connect(struct pcifront_device *pdev)
+{
+	int err;
+
+	/* Only connect once */
+	if (xenbus_read_driver_state(pdev->xdev->nodename) !=
+	    XenbusStateInitialised)
+		return;
+
+	err = pcifront_connect_and_init_dma(pdev);
+	if (err && err != -EEXIST) {
+		xenbus_dev_fatal(pdev->xdev, err,
+				 "Error setting up PCI Frontend");
+		return;
+	}
+
+	pcifront_connect(pdev);
 }
 
 static int pcifront_try_disconnect(struct pcifront_device *pdev)
@@ -914,67 +901,11 @@ static int pcifront_try_disconnect(struct pcifront_device *pdev)
 	return err;
 }
 
-static int pcifront_attach_devices(struct pcifront_device *pdev)
+static void pcifront_attach_devices(struct pcifront_device *pdev)
 {
-	int err = -EFAULT;
-	int i, num_roots, len;
-	unsigned int domain, bus;
-	char str[64];
-
-	if (xenbus_read_driver_state(pdev->xdev->nodename) !=
+	if (xenbus_read_driver_state(pdev->xdev->nodename) ==
 	    XenbusStateReconfiguring)
-		goto out;
-
-	err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend,
-			   "root_num", "%d", &num_roots);
-	if (err == -ENOENT) {
-		xenbus_dev_error(pdev->xdev, err,
-				 "No PCI Roots found, trying 0000:00");
-		err = pcifront_rescan_root(pdev, 0, 0);
-		if (err) {
-			xenbus_dev_fatal(pdev->xdev, err,
-					 "Error scanning PCI root 0000:00");
-			goto out;
-		}
-		num_roots = 0;
-	} else if (err != 1) {
-		if (err == 0)
-			err = -EINVAL;
-		xenbus_dev_fatal(pdev->xdev, err,
-				 "Error reading number of PCI roots");
-		goto out;
-	}
-
-	for (i = 0; i < num_roots; i++) {
-		len = snprintf(str, sizeof(str), "root-%d", i);
-		if (unlikely(len >= (sizeof(str) - 1))) {
-			err = -ENOMEM;
-			goto out;
-		}
-
-		err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str,
-				   "%x:%x", &domain, &bus);
-		if (err != 2) {
-			if (err >= 0)
-				err = -EINVAL;
-			xenbus_dev_fatal(pdev->xdev, err,
-					 "Error reading PCI root %d", i);
-			goto out;
-		}
-
-		err = pcifront_rescan_root(pdev, domain, bus);
-		if (err) {
-			xenbus_dev_fatal(pdev->xdev, err,
-					 "Error scanning PCI root %04x:%02x",
-					 domain, bus);
-			goto out;
-		}
-	}
-
-	xenbus_switch_state(pdev->xdev, XenbusStateConnected);
-
-out:
-	return err;
+		pcifront_connect(pdev);
 }
 
 static int pcifront_detach_devices(struct pcifront_device *pdev)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 16:05:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 16:05:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417153.661775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTMs-0006Rp-Lu; Thu, 06 Oct 2022 16:05:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417153.661775; Thu, 06 Oct 2022 16:05:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTMs-0006Ri-Ix; Thu, 06 Oct 2022 16:05:02 +0000
Received: by outflank-mailman (input) for mailman id 417153;
 Thu, 06 Oct 2022 16:05:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M1JS=2H=epam.com=prvs=22784c7a74=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ogTMr-0006Rc-30
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 16:05:01 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f75c67d-4590-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 18:04:59 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296EHMrR028393;
 Thu, 6 Oct 2022 16:04:25 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb0mjr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 06 Oct 2022 16:04:25 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by GV2PR03MB8875.eurprd03.prod.outlook.com (2603:10a6:150:bb::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Thu, 6 Oct
 2022 16:04:21 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 16:04:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f75c67d-4590-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kq0yF/fq1wMmjxLljiGoirzo56NE5eAGvNXbPaex/1uCAEh1YeSjTE5S1kVAAMcYYmC8QZz4o+BCs3Ahf8wJmu0Si/WMn+MV1hePWmxS8iq+ER8VTm3O4EaP7UepOu+OTQ/qzS1TIWv0EJkEuXsiM7y29Vne3L2ERHFDfbetRxGi7EpVvfaaOStvd931Zaim0c7fHxWYbXyWztU6SR3WyShYeH3aMEiv+L5LQ8yBgr4bvDju6mFWrqFCUiaavJjaMsJjeXUYBe1OlB0P6HMNoO9SEiAbAa2hWBCfGbsS6leL8HglKKMfXLq8mgqmvJeW/6+wv4LzogFFlxBJwjsEpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YN9GdqSpyIcWpTpv0Hlo0Kb5r9g35AmeSIZc8LEYq7M=;
 b=a6kERcP2OESxntJ7MaT9LTGza4v7zbDZ90jIDYC5t9G+ZcowkEJYEChG6jsDUQ/s0T3QewGOpfnXqNCd95ylpCgYEGtnUwZW5X1n5+M4s08KEvOfls7LGHAJQd/2V2weesA2hsg65O2OP0WzoEF2DscD5sS9JGegTRuoIiUTc4PmuZFXUwx2weRiu2jJKQ7uHmYT26P33Z8pFuugz8itZj46Wa72qKZ3XVRyuNCzdszsWXnzTzgC7Z7bjBxzhwvbSDff7j0z0UYB+mUFb2ucE74A2c0ao5vxFvV32vL33/sVNOqwqBq0iYAS20+b+4aJCphbxReFIUv1EUHSo00TBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YN9GdqSpyIcWpTpv0Hlo0Kb5r9g35AmeSIZc8LEYq7M=;
 b=AYDHT7WzhhPUjEa+E3U6hIYRfFwt7G8AKbmRmtPCT18hZ4eFpWnRJL6aplobwbLolnPtAX/Jqaa9KoDB7HmJo1dNj+yGgmr1IBDl5oZDGKffkh81+ZLDq5JvrdPzucj2/AglEc+B1KUqh18+Qc8ucIzJEBuTpXsAHCfQlKyw64dUEDQOp7HZ1boP5EJaI88ELNwm1dZ4fvok9yKo+nKfTyP48fyeghNj6GM4Yz4/1F+H9jVfKwtxwogkt67oJAyKechQ8/cdD/ZeZ9XBo8eOm9iDg1v3PYeEfKdaDHFvC8ZF2OfXOB548DClymo6c001viCnJchOvvkvhYiMAATuNA==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov
	<bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin"
	<hpa@zytor.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] xen/virtio: enable grant based virtio on x86
Thread-Topic: [PATCH 3/3] xen/virtio: enable grant based virtio on x86
Thread-Index: AQHY2VNniYYD6wnM6kOJwr1p2x51Wq4Bh+oA
Date: Thu, 6 Oct 2022 16:04:21 +0000
Message-ID: <2e721170-6035-90e3-f929-79b0a07e1891@epam.com>
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-4-jgross@suse.com>
In-Reply-To: <20221006071500.15689-4-jgross@suse.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|GV2PR03MB8875:EE_
x-ms-office365-filtering-correlation-id: e20e52a5-0149-4e4a-75b2-08daa7b46e6e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 0uSrm5bsZrHeGAYl2l44T773hZaVrRnYeAvl+XLu3ZweTE2ble00iLtwnJurL5E1A8LfaxDwLhLN4x+nbrfjzxlT4pJuyg0KhtrNIoHcfFrWU/tqVjbtdBdW06j7rnhEuduYeYf4HIqDmeFSgD2Kyq5xYPJC/5VN/y5QIF2bFvWdWxkOHKt0y/w49BUthxq0Fr9OcRpIuHiO1FUz0jSmZdSGJDN1NLjc3Ml0aVv9aJWZBngYmtpW9ey5XIPECw3yKiVD2shFLRNrEbD05oAMssPdrwx+4kWmAex1/w68tthcuKb2rVEvtpBa1RJz7ENyLU7ehIoargvUu25u0/Mwa/tAomiqQk/qIczdu+EYWY5MbzZTMiJAxktNYnF1M2ZbNbT2gGkgJx+J4lD9CSOeX8FkvYNDHvZDiPn5Sl6h1bhaz2kj0cx7i5ABv460M0oKA6bECgdw0dcXBI0SxaxNWxdU4QztdpleZTFB/Sz9Ms/sMqpKLZCZ36x5Zj7/HmVmPagJIa3XOU3d1rapIPZUIA3Z+h9Urd2vgTySPgKSyKvwBBAvc2l4DhaTYM9iQsn1ays1iF2rl0lV2W8oVfO1mKlTuRsjZ0p7chb9zDQsQyCIkD4MvgUyOYgz9INjVhjHGLoBVftyOQ53yq882hGfIH9SLtnXy33jRStli59zyOWfR0lh7Arp1GsTqWJO9hRv4O+/7vNcvLI/OsdWq+rVxRJMYrnVE2LvUgZMH1NpKUpZUY5FG7L4BBWtUFhLQaSBXc5dAUSBpJnXIRtLGjG+RecrRlx9CLm6mBHqI2k7FkM=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(451199015)(7416002)(5660300002)(8936002)(83380400001)(2906002)(38100700002)(8676002)(2616005)(55236004)(53546011)(41300700001)(478600001)(36756003)(186003)(66946007)(76116006)(4326008)(66556008)(91956017)(110136005)(66446008)(6486002)(64756008)(122000001)(316002)(54906003)(31686004)(6512007)(66476007)(38070700005)(71200400001)(6506007)(26005)(31696002)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bWw5c0VDdy84R05ya3R5YkRHVlZWQkVNK1pWSWlsY0VZQXhmU2tnalFMc2Y0?=
 =?utf-8?B?dE9yemlnYjVsL0t3WkVqaStaaHlOT0xTR1JwaFBCaTNvQkQ4bjdTQTVrYjd3?=
 =?utf-8?B?dngzUTNteWdLekFiS0Q0Qno1dk5FOUdFeE9reUFwcjB5N3hCR3lBcEpDQS9D?=
 =?utf-8?B?SFJncmtta1VnVjN0SUpSOHZlb0lxa0ZYQS95WWp2Q1dwcTVVWW1iWU10TjNT?=
 =?utf-8?B?UXBhRTFuemsvT1JzQk14bHV4em5vb0NPT1AwTy9TdmRrUkZ6VkZHRWZhK3RN?=
 =?utf-8?B?M1dSa2NIdUxKRVpmb0UxSU1FTWlPbmwvY1VYRmRRb2xmN1JOVFpFbXN3WHpv?=
 =?utf-8?B?U0svdi9sbTlkdGF0Rm92WWJkT0pXMjgwbm5WdzkybWVkdmJ1bHk2a2R0ZFZN?=
 =?utf-8?B?dXVMZUJXMC9uZ2sycStxTStnWHhyQ0FNOVlDamoxSUdraFZCdnZ2NmtFK0Fz?=
 =?utf-8?B?UkEzOFhNeWFxTzRacWJjd0YwTDZCVlRZd25XdHBrVWtCN1NtMENlWVVmNlJ2?=
 =?utf-8?B?UWU1aXN0cGV1MWFHSUdKVzJ4S3gxWVpFbXhpKzc3NFRKWDlyMGtSV0x0dGlv?=
 =?utf-8?B?N1Eyd3QzUTBsK2pOT2czanZEbEpZWENrMURKREFKZjd5c200aTNBUVowN3A3?=
 =?utf-8?B?elZraDlLNWdlOUpvek9tYVpCbmRjSHdPVW9vWndPay9BRXpDckVIdDE1aHNv?=
 =?utf-8?B?aW1FNEpRVkY5a0VsM1VuNHAvV0lEMDc2MnZiT3NZY1k2dTlJK3JGQXBObzM1?=
 =?utf-8?B?c1I4WEdYcjBjQkZXRUwvMTdUL2syRU9udmtWSlNNVmFoVjZ3N0xVU0xOc3ZO?=
 =?utf-8?B?QzJjVXU0VmZ5NlNaTWo4MGxTRCtrWThBb2xZbnR3eko5NEZ5R0lEYVF1TzI4?=
 =?utf-8?B?aHpORlpZU1lDREFYNElPN1BTMUI1bThwWk55VnRidzR1UjdGWFkyd0JZT0dK?=
 =?utf-8?B?YWErLzlwVUdNcHlwMC8xMExJWXJCa0NrVkVxYW1UN2pxYnFVeVUvdEU1Z3BQ?=
 =?utf-8?B?RlYrS0I4djNVcGU2UVA2RTUzUVY0UHFkZWtjVEIyRnFrUVd6VnZBZGE1dVdG?=
 =?utf-8?B?YnAyeTZoRG5ueVlNcVhnRGFES3k1Qk5McXFlY24wVG1ybkVmVkhhRWFJWUxL?=
 =?utf-8?B?Z25pb1dJejU4bnAwSjhQNCtlQWdYU2VEUFN6YUcrM3JBQTJ3VmJLUUdxY0h5?=
 =?utf-8?B?UmdHWUtzem0rNVNLZ2FSTzNBdzJIaTZFb3lOTWk1dkpEenBoVkxtODdCenBt?=
 =?utf-8?B?VjNtWTRlWHZoRlJYZHQ4cmx3OGh3SEhmaUVwMHNLSTdmM25BNk50blk3MFNK?=
 =?utf-8?B?aFZ5ZGlmTEcxYW15VUtaK3JwbmcwdUhpbUc1QVk5ejhuczRkWnM4M2tJZ2Ry?=
 =?utf-8?B?a0Y2ZUhmM0JZR2R4cndHaDdRUUNRbTVIL2ZMNmlIT2lOejM2T0cvZk1qeVBV?=
 =?utf-8?B?Sk5UMktlQUlid01WWjVBd2IycWtRMVBOZ2RCVU1Jb254SldGVmF0ZjUzN3pH?=
 =?utf-8?B?UXJTK0RrUHkvRmRNL3FGV3gxLzduZlVvSFE2REZaMzBzM3ZLTExNM0dVRGdM?=
 =?utf-8?B?dEpHa3BxRlEveG84a0tJNk1tUjNodzh3aFg5VUxSVDI5dkQrL0dQTE5kUXdU?=
 =?utf-8?B?VVE1cUlCRU1hdGdxU0FsL0YrL0cxelQyb1RGeTdTK3Nrak5ZL3JidU1VS090?=
 =?utf-8?B?OWJFWEJocGxrdXQyK0VtcTNrWnorRmd4QWR5SjJFdWhySWNKTmhiUk5tcVpr?=
 =?utf-8?B?OWdGTmxtR3laRS9jcEJZL3NZZVlkR3FtajdWTVAzVzViYWxYdXdpcWpva3d3?=
 =?utf-8?B?SnFZaWFQZENPSEx5V2czMmtCajZ5NXNud3l4eTAxclFCc2pQUmNVZWZ3dmhQ?=
 =?utf-8?B?VjFlOW1zMDdnTUVYSTdUcjNrck5xTXIyd3RoSCtPejNiM3JuT1h0NWhOT0Q1?=
 =?utf-8?B?T2UyazUxOGJJREdud0V6dlNkSVAwWUJtTGdheWZZOE1PSTNSQTgzUTQvWThw?=
 =?utf-8?B?Tk9VRmI0cEJQRWV0Y3VHd2JRTjFkZlRyS2RYM08yUnUwZ0FCTmVXQVB1bG84?=
 =?utf-8?B?VStOMWM3dDlRZXJUVDAyY0hzQmxFNXd1RGFraWQ1cUxwcEpTMHdEWkdrbHhs?=
 =?utf-8?B?ckNaUDlzY0JwRWZmQjZnR0FnZ3VCTmUvQytpZmlLZ21wWS9pbzdlR1E1dXhV?=
 =?utf-8?Q?/+KOMW8jPsvXCNVRuF234PE=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <898A89F318143644A91134F73E8283F8@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e20e52a5-0149-4e4a-75b2-08daa7b46e6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 16:04:21.4718
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fpFMz549rx2bhlM8HmKVjpC+wvBTnZ2QOiygCXXxZjISUKVY0FVRtgnQ6EgTiKAQFpzOrEnlhGvRXZwLq/RfycQPGerLrC3hvl+VfKAAYYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR03MB8875
X-Proofpoint-ORIG-GUID: Z7CIxC1cqpqdPoj5pgTJG55FMgidRLMv
X-Proofpoint-GUID: Z7CIxC1cqpqdPoj5pgTJG55FMgidRLMv
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_04,2022-10-06_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1011 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210060093

DQpPbiAwNi4xMC4yMiAxMDoxNSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCg0KDQpIZWxsbyBKdWVy
Z2VuDQoNCj4gVXNlIGFuIHg4Ni1zcGVjaWZpYyB2aXJ0aW9fY2hlY2tfbWVtX2FjY19jYigpIGZv
ciBYZW4gaW4gb3JkZXIgdG8gc2V0dXANCj4gdGhlIGNvcnJlY3QgRE1BIG9wcy4NCj4NCj4gU2ln
bmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiAtLS0NCj4gICBh
cmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jIHwgIDIgKy0NCj4gICBhcmNoL3g4Ni94ZW4vZW5s
aWdodGVuX3B2LmMgIHwgIDIgKy0NCj4gICBkcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgIHwg
MTAgKysrKysrKysrKw0KPiAgIGluY2x1ZGUveGVuL3hlbi1vcHMuaCAgICAgICAgfCAgMSArDQo+
ICAgNCBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPg0K
PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL2VubGlnaHRlbl9odm0uYyBiL2FyY2gveDg2L3hl
bi9lbmxpZ2h0ZW5faHZtLmMNCj4gaW5kZXggMWMxYWM0MTg0ODRiLi5jMWNkMjhlOTE1YTMgMTAw
NjQ0DQo+IC0tLSBhL2FyY2gveDg2L3hlbi9lbmxpZ2h0ZW5faHZtLmMNCj4gKysrIGIvYXJjaC94
ODYveGVuL2VubGlnaHRlbl9odm0uYw0KPiBAQCAtMjEyLDcgKzIxMiw3IEBAIHN0YXRpYyB2b2lk
IF9faW5pdCB4ZW5faHZtX2d1ZXN0X2luaXQodm9pZCkNCj4gICAJCXJldHVybjsNCj4gICANCj4g
ICAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQpKQ0KPiAtCQl2
aXJ0aW9fc2V0X21lbV9hY2NfY2IodmlydGlvX3JlcXVpcmVfcmVzdHJpY3RlZF9tZW1fYWNjKTsN
Cj4gKwkJdmlydGlvX3NldF9tZW1fYWNjX2NiKHhlbl92aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNj
KTsNCj4gICANCj4gICAJaW5pdF9odm1fcHZfaW5mbygpOw0KPiAgIA0KPiBkaWZmIC0tZ2l0IGEv
YXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5j
DQo+IGluZGV4IDliMWE1OGRkYTkzNS4uNDViMjRjMWI2NDZhIDEwMDY0NA0KPiAtLS0gYS9hcmNo
L3g4Ni94ZW4vZW5saWdodGVuX3B2LmMNCj4gKysrIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9w
di5jDQo+IEBAIC0xMTIsNyArMTEyLDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHhlbl9wdl9pbml0
X3BsYXRmb3JtKHZvaWQpDQo+ICAgew0KPiAgIAkvKiBQViBndWVzdHMgY2FuJ3Qgb3BlcmF0ZSB2
aXJ0aW8gZGV2aWNlcyB3aXRob3V0IGdyYW50cy4gKi8NCj4gICAJaWYgKElTX0VOQUJMRUQoQ09O
RklHX1hFTl9WSVJUSU8pKQ0KPiAtCQl2aXJ0aW9fc2V0X21lbV9hY2NfY2IodmlydGlvX3JlcXVp
cmVfcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4gKwkJdmlydGlvX3NldF9tZW1fYWNjX2NiKHhlbl92
aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4gICANCj4gICAJcG9wdWxhdGVfZXh0cmFfcHRl
KGZpeF90b192aXJ0KEZJWF9QQVJBVklSVF9CT09UTUFQKSk7DQo+ICAgDQo+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMNCj4gaW5kZXggYTAwMTEyMjM1ODc3Li42MGE3YWNjMzM0ZWQgMTAwNjQ0DQo+IC0tLSBhL2Ry
aXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEt
b3BzLmMNCj4gQEAgLTM3Miw2ICszNzIsMTYgQEAgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29w
cyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ICAgCWRldl9lcnIoZGV2LCAiQ2Fubm90IHNldCB1cCBY
ZW4gZ3JhbnQgRE1BIG9wcywgcmV0YWluIHBsYXRmb3JtIERNQSBvcHNcbiIpOw0KPiAgIH0NCj4g
ICANCj4gK2Jvb2wgeGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2Moc3RydWN0IHZpcnRpb19k
ZXZpY2UgKmRldikNCj4gK3sNCj4gKwlib29sIHJldCA9IHhlbl92aXJ0aW9fbWVtX2FjYyhkZXYp
Ow0KDQoNClRoZSBncmFudCB1c2FnZSBpcyBtYW5kYXRvcnkgZm9yIFBWIGd1ZXN0cywgcmlnaHQ/
DQoNClRoZW4geGVuX3ZpcnRpb19tZW1fYWNjKCkgc2hvdWxkIGFsd2F5cyByZXR1cm4gdHJ1ZSBm
b3IgUFYgZ3Vlc3RzIChJIA0KbWVhbiBldmVuIGlmIENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dS
QU5UIGlzIG5vdCBzZXQpLg0KDQoNCg0KPiArDQo+ICsJaWYgKHJldCkNCj4gKwkJeGVuX2dyYW50
X3NldHVwX2RtYV9vcHMoZGV2LT5kZXYucGFyZW50KTsNCj4gKw0KPiArCXJldHVybiByZXQ7DQo+
ICt9DQo+ICsNCj4gICBNT0RVTEVfREVTQ1JJUFRJT04oIlhlbiBncmFudCBETUEtbWFwcGluZyBs
YXllciIpOw0KPiAgIE1PRFVMRV9BVVRIT1IoIkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv
bT4iKTsNCj4gICBNT0RVTEVfTElDRU5TRSgiR1BMIik7DQo+IGRpZmYgLS1naXQgYS9pbmNsdWRl
L3hlbi94ZW4tb3BzLmggYi9pbmNsdWRlL3hlbi94ZW4tb3BzLmgNCj4gaW5kZXggZGFlMGYzNTBj
Njc4Li4zZGQ1YWE5MzZmMWQgMTAwNjQ0DQo+IC0tLSBhL2luY2x1ZGUveGVuL3hlbi1vcHMuaA0K
PiArKysgYi9pbmNsdWRlL3hlbi94ZW4tb3BzLmgNCj4gQEAgLTIxOSw2ICsyMTksNyBAQCBzdGF0
aWMgaW5saW5lIHZvaWQgeGVuX3ByZWVtcHRpYmxlX2hjYWxsX2VuZCh2b2lkKSB7IH0NCj4gICB2
b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldik7DQo+ICAgYm9v
bCB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpOw0KPiAgIGJvb2wg
eGVuX3ZpcnRpb19tZW1fYWNjKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYpOw0KPiArYm9vbCB4
ZW5fdmlydGlvX3Jlc3RyaWN0ZWRfbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KTsN
Cj4gICAjZWxzZQ0KPiAgIHN0YXRpYyBpbmxpbmUgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29w
cyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ICAgew0KDQoNCkFuZCBwcm9iYWJseSBzdGF0aWMgaW5s
aW5lIHN0dWIgYWx3YXlzIHJldHVybmluZyBmYWxzZSBpZiANCkNPTkZJR19YRU5fR1JBTlRfRE1B
X09QUyBpcyBub3Qgc2V0Lg0KDQoNCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVu
a28NCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 16:20:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 16:20:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417161.661786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTbH-00083t-U7; Thu, 06 Oct 2022 16:19:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417161.661786; Thu, 06 Oct 2022 16:19:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTbH-00083m-R4; Thu, 06 Oct 2022 16:19:55 +0000
Received: by outflank-mailman (input) for mailman id 417161;
 Thu, 06 Oct 2022 16:19:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hmTD=2H=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ogTbF-00083g-Oz
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 16:19:53 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b44f9985-4592-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 18:19:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8F1E761A2A
 for <xen-devel@lists.xenproject.org>; Thu,  6 Oct 2022 16:19:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91EE7C43143
 for <xen-devel@lists.xenproject.org>; Thu,  6 Oct 2022 16:19:49 +0000 (UTC)
Received: by mail-lf1-f52.google.com with SMTP id bp15so3435240lfb.13
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 09:19:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b44f9985-4592-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665073189;
	bh=Pld45Z4CvZ++lrOaJAma6PphMOkb0rHF45RNmYeXg10=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=UldnsAG4GNAIf3bSaBgda3uTevViDMdSSwclyZxwkqmgQnRVyLusdJP9LFmQjQgPL
	 6dc2ARIw+4qhmVft10VEiQxS4WjjjpS7eEdNFITa2Y6weVWFQlwfltXCOjB5Kx/X2D
	 lNCiuw7/chMSMBwwCq+u8niyobby8oFZDrFVytzozRs2abSVgosb+OAmKyke28YcFF
	 S/hQ8y6GdVTIkkj9pEuuUsSbei47zrqjuab0cZohdZJyVU9QpAWJihH8FJXDc4z8+D
	 5YQLd5f8HOyxE8/tgmNcxoN8SeberFpSx9nWGH5SEg7UN+Rgca1fyH/dCzviVQ1nqd
	 Sc2XcdsSjVHjA==
X-Gm-Message-State: ACrzQf0JZeM611bqTIzzsZgegCWpralH+VUJnrCWrfrAr5baDOFe8dkf
	skNLcJ3pgrDTEwdRnl8G5Ma82niLghICiyjbnC8=
X-Google-Smtp-Source: AMsMyM45oIBVZ07KF4ltMC+pidQt3Gbgah5PxR0JOD8znHmV8tQ+3YrjKDTYs/dwhYptFQFjBeeEIiXK8BPuXFstRGo=
X-Received: by 2002:ac2:4d1c:0:b0:4a2:4119:f647 with SMTP id
 r28-20020ac24d1c000000b004a24119f647mr270568lfi.426.1665073187373; Thu, 06
 Oct 2022 09:19:47 -0700 (PDT)
MIME-Version: 1.0
References: <YzcjeiOW8+i2Zxsd@itl-email> <CAMj1kXHBBbCNV3CLesqZi7ttmmi8y4tZ1KO5vievy_CJrU2o3Q@mail.gmail.com>
 <YzeaKjmls1YI/3ox@itl-email> <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email> <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email> <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
 <Yz4yLyvX6un1rrqC@itl-email> <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>
 <Yz7polT2R2OlT1aT@itl-email>
In-Reply-To: <Yz7polT2R2OlT1aT@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Thu, 6 Oct 2022 18:19:35 +0200
X-Gmail-Original-Message-ID: <CAMj1kXGe77iwnYXWR=Hjn8eL8-1hMZbprjU8bnYaFWJnRZfdfw@mail.gmail.com>
Message-ID: <CAMj1kXGe77iwnYXWR=Hjn8eL8-1hMZbprjU8bnYaFWJnRZfdfw@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, 
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 6 Oct 2022 at 16:43, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Thu, Oct 06, 2022 at 09:31:47AM +0200, Ard Biesheuvel wrote:
> > On Thu, 6 Oct 2022 at 03:41, Demi Marie Obenour
> > <demi@invisiblethingslab.com> wrote:
> > >
> > > On Wed, Oct 05, 2022 at 11:28:29PM +0200, Ard Biesheuvel wrote:
> > > > On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
> > > > <demi@invisiblethingslab.com> wrote:
> > > > >
> > > > > On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > > > > > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > > > > > Linux has a function called efi_mem_reserve() that is used to reserve
> > > > > > > EfiBootServicesData memory that contains e.g. EFI configuration tables.
> > > > > > > This function does not work under Xen because Xen could have already
> > > > > > > clobbered the memory.  efi_mem_reserve() not working is the whole reason
> > > > > > > for this thread, as it prevents EFI tables that are in
> > > > > > > EfiBootServicesData from being used under Xen.
> > > > > > >
> > > > > > > A much nicer approach would be for Xen to reserve boot services memory
> > > > > > > unconditionally, but provide a hypercall that dom0 could used to free
> > > > > > > the parts of EfiBootServicesData memory that are no longer needed.  This
> > > > > > > would allow efi_mem_reserve() to work normally.
> > > > > >
> > > > > > efi_mem_reserve() actually working would be a layering violation;
> > > > > > controlling the EFI memory map is entirely Xen's job.
> > > > >
> > > > > Doing this properly would require Xen to understand all of the EFI
> > > > > tables that could validly be in EfiBootServices* and which could be of
> > > > > interest to dom0.  It might (at least on some very buggy firmware)
> > > > > require a partial ACPI and/or SMBIOS implementation too, if the firmware
> > > > > decided to put an ACPI or SMBIOS table in EfiBootServices*.
> > > > >
> > > > > > As to the hypercall you suggest - I wouldn't mind its addition, but only
> > > > > > for the case when -mapbs is used. As I've indicated before, I'm of the
> > > > > > opinion that default behavior should be matching the intentions of the
> > > > > > spec, and the intention of EfiBootServices* is for the space to be
> > > > > > reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
> > > > > > that hypercall: It might use it for regions where data lives which it
> > > > > > wouldn't care about itself, but which an eventual kexec-ed (or alike)
> > > > > > entity would later want to consume. Code/data potentially usable by
> > > > > > _anyone_ between two resets of the system cannot legitimately be freed
> > > > > > (and hence imo is wrong to live in EfiBootServices* regions).
> > > > >
> > > > > I agree, but currently some such data *is* in EfiBootServices* regions,
> > > > > sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
> > > > > configuration tables that point to EfiBootServicesData memory before
> > > > > freeing that memory.
> > > > >
> > > >
> > > > That seems like a reasonable approach to me. Tables like MEMATTR or
> > > > RT_PROP are mostly relevant for bare metal where the host kernel maps
> > > > the runtime services, and in general, passing on these tables without
> > > > knowing what they do is kind of fishy anyway. You might even argue
> > > > that only known table types should be forwarded in the first place,
> > > > regardless of the memory type.
> > >
> > > Which tables are worth handling in Xen?  I know about ACPI, SMBIOS, and
> > > ESRT, but I am curious which others Xen should preserve.  Currently, Xen
> > > does not know about RT_PROP or MEMATTR; could this be a cause of
> > > problems?
> >
> > dom0 only has access to paravirtualized EFI runtime services, so
> > consuming RT_PROP or MEMATTR should be up to Xen (they describe which
> > runtime services remain available at runtime, and which permission
> > attributes to use for the runtime services memory regions,
> > respectively)
>
> Xen does not do this right now.  I wonder if this could be the cause of
> compatibility issues with various firmware implementations.
>
> > Looking through the kernel code, I don't think there are any that dom0
> > should care about beyond ACPI, SMBIOS and ESRT. But as you suggest,
> > that means Xen should just mask them in the view of the EFI system
> > table it exposes so dom0. Otherwise, the kernel may still try to map
> > and parse them.
>
> What about the BGRT and MOKvar?  I agree that Xen should not expose the
> others.  Should it just hide the tables, or should it actually uninstall
> them?  My intuition is that the second would be technically more
> correct, but also more likely to trigger bugs in various firmware
> implementations.

BGRT is a ACPI table not a EFI configuration table, so I'd assume it
is treated the same way as other ACPI tables

MOKvar is a fallback for systems where it doesn't fit into a volatile
variable IIRC but I am not sure if it is actually implemented
anywhere, and what type of memory region it is expected to use.

However, I'm not sure if it even matters, given that Xen loads the
dom0 kernel not the firmware, right?


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 16:27:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 16:27:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417170.661796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTiW-0001A7-Pe; Thu, 06 Oct 2022 16:27:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417170.661796; Thu, 06 Oct 2022 16:27:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTiW-0001A0-Ms; Thu, 06 Oct 2022 16:27:24 +0000
Received: by outflank-mailman (input) for mailman id 417170;
 Thu, 06 Oct 2022 16:27:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G1sz=2H=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ogTiW-00019u-3t
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 16:27:24 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c1917dbd-4593-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 18:27:23 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id z23so5678575ejw.12
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 09:27:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1917dbd-4593-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=1kXYRJVvVuB6/yCg+mLXa+n2OpJV2ALpI5+bxh3cOos=;
        b=CyGVdpIRf0cbkRRlaQmlIM4GbYrItWETO4moUB0zABjHGn+1Bb5HHwCCrwYBQSdG1z
         YC0Mo0XlKB75VeUZ/tJLkKEazynqHAdt2RXqbZQ7RFv78GUf5L3UQVLsOU6zdZEwiZac
         SBrkH5q2D8PZcWVlYrSSPu5iu5DNoO+XHQPihtd1TbNlapY8sRyKQqe9zKr/w/PEqZHR
         x0rPhaaRYuIGeVx/OGinB2GIMhzjl+TxEqwMsa/r4HYIyXFoF3EMA4Tvj4SsNs8OmWK5
         eD4wxZUqXbkkCQdkaKwPpGze4+jRMB4c54N9Tg/zx6n75XD1KXS/NRKR8cw9YpZv9dVv
         sDXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=1kXYRJVvVuB6/yCg+mLXa+n2OpJV2ALpI5+bxh3cOos=;
        b=O7CHlJlBFbQGlFa7XEu/KQNE+FiQRc1qXgAfhCKb9E13zYs6rwf0yehNBE/zAfcmsr
         KSK+NehqiyiJbrwTlVd9Fw2UOEuvJS/G6KPHw9KC7eoCtZPCuonGIPGucxnBPjg9B865
         iolPu832L8t6uk7XAzL+SV0EIOTP1DwAmg6f7e0EbgfgcOTWN9HCwfQhVFM00R8b84Gm
         1i1+pjBgkuhZvtUrl9EsF6Yv7fDbJp9Drof++PcNnPjTdBtSuMqElEV5hHy3tj/gO1bk
         0Can9wOny3stvL9Jw7ew9pQ3C9bfYnxx4j2kTvLNC42Yx372ZDfymEkPrGIWHZ8QfGyf
         sKHQ==
X-Gm-Message-State: ACrzQf0g95tWp48PwBavLA57K9oEogUhlCdJnuOxC3vWPCDdxwKONwRH
	y887XIpw5wn9hQucR25K+eXhhrRDBLvZLWpIBoo=
X-Google-Smtp-Source: AMsMyM6gC7LkWalsDjJCsF+lKGjCe9nrQw7x15pqRpmn46ydjr2W6YgI0uNqMQX0BN+RkIlpHUqujS6nxpuUk5qDvvg=
X-Received: by 2002:a17:907:6087:b0:78d:2d1c:c050 with SMTP id
 ht7-20020a170907608700b0078d2d1cc050mr538377ejc.481.1665073642415; Thu, 06
 Oct 2022 09:27:22 -0700 (PDT)
MIME-Version: 1.0
References: <20221006153440.18049-1-jgross@suse.com>
In-Reply-To: <20221006153440.18049-1-jgross@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 6 Oct 2022 12:27:09 -0400
Message-ID: <CAKf6xpvUat2HP_WO=LSxLC46=KN2exSmqn+DWHTN74HK6H2HLQ@mail.gmail.com>
Subject: Re: [PATCH v2] xen/pcifront: move xenstore config scanning into sub-function
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Bjorn Helgaas <bhelgaas@google.com>, 
	xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 6, 2022 at 11:35 AM Juergen Gross <jgross@suse.com> wrote:
>
> pcifront_try_connect() and pcifront_attach_devices() share a large
> chunk of duplicated code for reading the config information from
> Xenstore, which only differs regarding calling pcifront_rescan_root()
> or pcifront_scan_root().
>
> Put that code into a new sub-function. It is fine to always call
> pcifront_rescan_root() from that common function, as it will fallback
> to pcifront_scan_root() if the domain/bus combination isn't known
> yet (and pcifront_scan_root() should never be called for an already
> kneon domain/bus combination anyway). In order to avoid duplicate

known

> messages for the fallback case move the check for domain/bus not knwon

known

> to the beginning of pcifront_rescan_root().
>
> While at it fix the error reporting in case the root-xx node had the
> wrong format.
>
> As the return value of pcifront_try_connect() and
> pcifront_attach_devices() are not used anywhere make those functions
> return void. As an additional bonus this removes the dubious return
> of -EFAULT in case of an unexpected driver state.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jason Andryuk <jandryuk@gmail.com>


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 16:35:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 16:35:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417177.661807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTqJ-0002f3-J6; Thu, 06 Oct 2022 16:35:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417177.661807; Thu, 06 Oct 2022 16:35:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogTqJ-0002ew-GQ; Thu, 06 Oct 2022 16:35:27 +0000
Received: by outflank-mailman (input) for mailman id 417177;
 Thu, 06 Oct 2022 16:35:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M1JS=2H=epam.com=prvs=22784c7a74=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ogTqI-0002eq-EJ
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 16:35:26 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df9d39bd-4594-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 18:35:24 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296EHK0K028344;
 Thu, 6 Oct 2022 16:35:20 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb0qn6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 06 Oct 2022 16:35:19 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM9PR03MB7679.eurprd03.prod.outlook.com (2603:10a6:20b:41c::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct
 2022 16:35:17 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 16:35:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df9d39bd-4594-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jdqaUOt7j9t1OMiGMsOjymfIDZM4elwyhKrSTbzquVcd0wG3vsxY4LY9GVN4bvLYUEH4821w6ZtGnze8Wy5j023LFMkSITMu9dsElBrtjt6SDI8b4oBuadOh0V8o5NNMkMs2aEL30FVAzzQ7AfDlSAUUvm8G3eHJ8h7Duk1UMe7A3OK1uf+655rdgieWfg894STVqmebo1jG5dngUXBooF8UzWe09toEtXi+kfTgnB4AhvB2NohHYHBuBG4+eDPMlwtdMd3snH45LLwagT7TA2PFPDo9YlyBo2OLzcrJI4JL95qKWv6l8L8Vn0xJ2XitscQM1Xu6/nyl9WxT4QR6Hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sA1xtS36+VdJSve6maCXgMPYvcCIt8LNfV0VwO7phAs=;
 b=OV3Mz3FQunDL50XfmzXr0yINHuGyYE0t/Ht49lZ3WWe5co4NJ3pyiHX6n3wsJE1LIfcsuvHOkYV0uwvfIxUJuYRpi/19M/XZg0QAdVR8mkCVUlDybsIvJRDTv4EPCPmCe/u7QjFGEuoA0Wx326KlhPDC7nU0Ozsye0DZzGG19R/G9mnBW6H5NFoIceUiyojc03AuMp+Ct4LqD9xmtTGQDYEGMbOEiJ+y/bZ849arcFEm1411v7lUdDRGLgA0CKHTA6HqByrO0c04GkwERluDUtQnk1Q/upsRQJbaLrYscArqpOgQTHSjDDvMYchpbFjPzhrzJE0AV2ciIxGnYFzgxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sA1xtS36+VdJSve6maCXgMPYvcCIt8LNfV0VwO7phAs=;
 b=fBOYkzlraN/lIxN3o+W5A6vKRBJ0S6Lcn2s1LWqCTEdUY7TBXg2gLEV+SRqtya0/4RFHmzLDwhBL1YXgyIrFTC1MSV01mef0X2+6CuRUrV+4xLRh+65KnmJcMw/BxfeD85KS7DxAVPnOMQrIjiwCKEd6zEnl+1GsHi85e/sjKx27nL8ddQAt90Qb4uRobW0MLb9bQg4E6p75AbQPy2SxVc1Asnk9E+WsdJ+aRvmEwpXTtf2KjH3JlTnJlevwnDzaccssFMr2KWf5WRzZgEQ5ZObtTyGVRqnoYNaAK7x40x/0vVhMMac/4zfdggWgfMs6Ro9NX2T48zxSgxWu/aLUDA==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup
Thread-Topic: [PATCH 1/3] xen/virtio: restructure xen grant dma setup
Thread-Index: AQHY2VNhekgc4whejkG37lRjhh7+/a4BkJMA
Date: Thu, 6 Oct 2022 16:35:16 +0000
Message-ID: <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-2-jgross@suse.com>
In-Reply-To: <20221006071500.15689-2-jgross@suse.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AM9PR03MB7679:EE_
x-ms-office365-filtering-correlation-id: da527780-a0bd-43d2-8a76-08daa7b8c06b
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6I+LZJCWwj5pq2PCiNK3ZTmmO7+vkwqkG5WkjwHdKneN5rqFehvdU/jv9xf3srQ3h/8sa58/vja8RJ1cn9H1TDtIEYJzeKNKqbRl9XhaB6KuwySChqXfOZ+Wbbvr58xObzVkyqPvQ4DAaGVmUsOEB43peES+8dMwtq5I+gX4mvEXW/bBroLdNTs9xJ4qYK3L7RX2AblE2D6hI0s7wjBk+EcYsOBaNXd89imkdNTHjJQ9npqf6msC7RqloyKEe04vQWfGz7CGzZjG0f96jiLJgn1nIKPlrVBXPsLUlPNTz8Q15c0tbFwZ5K7tXPPKsBB3K+WDA4HGAzAyesPlnvKmgrJOy33IdRdgSCT19GiLpRehyFFiz8RsoESyW4yv9nNgDjSTxlb8LpGgE0hNxiGK0UQSuvWU+Nu+U9Z/E0ou37k7Wkn3yYmycx1HXNoL2J4LwNk+g8z3EMo2pIYy1hWkcoGLt6Yy3/PL4G4i8/JFZUIFOcrXHCRk6lTWMq1IRchbMX+uBrBti3B4S/KbddV9IQufrw0ewVGfOEZ+428tzklvWp4xJewVIFJf0xW/vg/y0e+9HKb/ix2AUpJPENj7Sr3yhPWKK15Ccb2Sewpgvutvbpt4z2cbwRSopZ0o/90Atb9POiZ2SATxk5GA0nuy7QcGbq+lgr0xA/5Z7g/rdF4k5LxhVl9aG8Jq+1DWVMKnRUl4LM+uwAnrRFKVuxqHlw+qack9upEPS5aG1INgZboPArRacE/UOJlLYaByJz/3rJmOzzlgODMHBsU0s3rp5RclbQnetZSfCDHYGweQNdup/qLqKTnF5ALjIToJD5ocf/ST3pwZc/SbCwWFaG/dlg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(83380400001)(186003)(2616005)(38070700005)(110136005)(122000001)(38100700002)(41300700001)(2906002)(5660300002)(8936002)(71200400001)(6486002)(6506007)(478600001)(53546011)(55236004)(26005)(6512007)(76116006)(66556008)(91956017)(4326008)(8676002)(66446008)(66476007)(316002)(64756008)(54906003)(66946007)(31696002)(36756003)(86362001)(31686004)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UGtyV0ppcWdxblMxTWQ2UjdlOUxNVEJFVFZ3bGpjZDVZdXFtSG9lNnBNS000?=
 =?utf-8?B?VDFnMTVLRzNsNmEyMTgrU2Rlb29UdmFCSjNkamx5Z0hlWDFNT3NucHhvR1V6?=
 =?utf-8?B?VlNWMmJaSWZVZllhcTAxczluRjg4czZqeFJVaHBDVnJTNU5rVCtPREdMcDAw?=
 =?utf-8?B?ZVJBOU9pMWw4R0VjeXhWQlg2OStjRUZMdEEvdWx4OGNaeHN0aWNscXBlRm5C?=
 =?utf-8?B?UHFiYUZaRXhnblp0dFBtclZrbitJbDF0U0hQNzVkMGVOM3o0cjVnZ29VNmgy?=
 =?utf-8?B?QXMrNWdmdStkeDRlb2lYcXRXMVVBeVZpbnFIWWVvVUtXNEJVc3cvajJBY2RV?=
 =?utf-8?B?QXFCNUM5dFdKb1kxM3ZjSFRiSElvcUo3R01wVlcxajFBelBkQlVsM0kzVkJ6?=
 =?utf-8?B?RDFySnlHaFZlNnUzRXA1aU0zUG1jM2JBdm1NK3RGMjJxclZTZU5URlZpamR1?=
 =?utf-8?B?Y25XL3o5eW00aVpJeDd4cmNSaXZLRGxsV3pJRDZ4dUV2Q0p1WFVHZE5kb1g3?=
 =?utf-8?B?Y1VPV0NMNnUrL21QMUd3SjlaSitobVFqU3M5RnFpNGg5RjlxSUN0TzlXODZD?=
 =?utf-8?B?cm1GeEhmTVVnYmRyU2cvZXpVZnNlMTJsZ0JkSUQzaVpWT2Nrek9TSWNHak1l?=
 =?utf-8?B?aTFNMTRrYnY5bzErYThXcjQ0U2VaNjlXREpuZUg5Y0JVRUxBQXY5RmxrdWI4?=
 =?utf-8?B?anFJbzhJWTgyVG9NVVNQOHQ3VHpZMWMyOFp4N0R5QkdZNkx5VGp3akZCTHhw?=
 =?utf-8?B?SHV6R2Z3eGpqcTcySVdQVHB4ZEdBeHlJM2JGM0d2T0M2R3k3MFVtbUFITnVC?=
 =?utf-8?B?MmsweDM5MUUrMnBZSjl1VkJYaUk1TmdxT0JvVWZZbzZIeEk3ZGh3T0x4ZkI3?=
 =?utf-8?B?NHp3OFZwUnVTYkhvSGE1T1R0eU1uZ0MwMXZlUElSTVFBdlMzcDlWNlRvcEpQ?=
 =?utf-8?B?cE5qYVdzbXArZUVqSXJVRlJDWnpTM2MzaWw3MitOdVZvSUQxdENkWVk5SGYy?=
 =?utf-8?B?VVppV0VleERjcXNaR01jcU5maVVKMG0vY0oraWk1bjZXbzdDTHBnazZlN3pv?=
 =?utf-8?B?NHFYdVhnblRDaXpocmZzVTdxSXhWRzRzOVJpbkpDRVpHMmVPR1NlVDZwVE1V?=
 =?utf-8?B?MytYUGxBbUNOS3dpNEY3ck9PNUQwYi9hOHk2VTQvbVY4NHRmc3VieTdXV0RN?=
 =?utf-8?B?VzJKVEpaS3N4YktPb1FhSUV5ejZlK0xmR0psMVlQNjFJTkZUTEZGeHRNSGdu?=
 =?utf-8?B?d2JnTmxnNXM4aUY3cGdlSjJCY0YweEZqc3lhQlFDQmhGNytubkJKc3lvWXBm?=
 =?utf-8?B?SW5jYWVYaFRVSXNPamRweS9FaHZtMExSNSt3TjVEamRabEN2L0FtdEVacXdD?=
 =?utf-8?B?WnZHbWZLdVY2N2EyWkxWSUpIL1FBWkh4b2djNVhmUGxOV2ZTUHVHdTBEMTM3?=
 =?utf-8?B?SFpjbUo0SVkxUFpRMGFKc2IzTFBDZ3lZVnhHSUFWNjhOb1lQNTRNV0d1c2JE?=
 =?utf-8?B?ejNlT3hWNkhSVFNKOGVaZ1A4MFg5SkY5bkhpYVUxVUp0NUlScUZwa0NCdEFh?=
 =?utf-8?B?UnJzY2hYZ2ozQkxtOHA3WThaU05JZ0FyRHJtbjRqN3J0NVFPNzNHREs0aUZw?=
 =?utf-8?B?a3lhZUtWejB3ZDdSa1U2ZzF5MURKNWlYOVJuSFMxYVFGeWF1SFk3R1ZFRUNK?=
 =?utf-8?B?bVVGMGFRRGZIRVYxdVZ4WEZSODE5am1UcDBSNkpSRWZ1WjFmekRQVGNCd0U3?=
 =?utf-8?B?WHFRcC9FRm9VMVhrVGJzZS83UHhmQzFGYVlxU0kzazZZRjAzVWlhMXQvKzU4?=
 =?utf-8?B?WmRlRDZvcmk1Z0F2VnY5MGNITmZwVEp6emNVVDB0MHJNZTRpSEZSYjhiYzll?=
 =?utf-8?B?dm10NzMxdFhjcVN5R1NvS1BvWUk0enQ4cjJxMlF2KzZYaklVdGltV0Y1aklm?=
 =?utf-8?B?WE1kUEhtVEN5MDhVZGorVXdxM1lkeGhFSlFaRC8rK0xwOWdIaEdzQXRhUitB?=
 =?utf-8?B?YTdpZTJkaGppdTA4SVUrcUtmQU8rQUhwL0NaWkF0NXFsemtIcGVmNThLWitv?=
 =?utf-8?B?RG5tM21XNWJBVitWLzJWeWtXcDZWTlZLc044WnFuWWY1QW14bE9sSWpqSXNv?=
 =?utf-8?B?NHFodTRJOWw3Z3J2VTBRNjZFU3JkWHErSGFxUDh0VHR6ektSL25DMGpIWlVK?=
 =?utf-8?Q?D67CMMEVBs5WzwaJipsVqxc=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <8D8D2623AA610040A37D60A783E219F9@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da527780-a0bd-43d2-8a76-08daa7b8c06b
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 16:35:17.0284
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VKPFe4PBFxsiPhIwGLOWraERVHiJG9mU4Xr5pob866wWIKa2Q7g8H/YjEgnC5oIGRziS8sP/SLxnrLV9m9qJp9KwAy3toItA1USMf1lNeaA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7679
X-Proofpoint-ORIG-GUID: GIJDoHJxK8k9xNUUy4Wb5H7IcxHkkx0H
X-Proofpoint-GUID: GIJDoHJxK8k9xNUUy4Wb5H7IcxHkkx0H
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_04,2022-10-06_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1015 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210060096

DQpPbiAwNi4xMC4yMiAxMDoxNCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCg0KSGVsbG8gSnVlcmdl
bg0KDQo+IEluIG9yZGVyIHRvIHByZXBhcmUgc3VwcG9ydGluZyBvdGhlciBtZWFucyB0aGFuIGRl
dmljZSB0cmVlIGZvcg0KPiBzZXR0aW5nIHVwIHZpcnRpbyBkZXZpY2VzIHVuZGVyIFhlbiwgcmVz
dHJ1Y3R1cmUgdGhlIGZ1bmN0aW9ucw0KPiB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZSgpIGFuZCB4
ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcygpIGEgbGl0dGxlIGJpdC4NCj4NCj4gU2lnbmVkLW9mZi1i
eTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNClBhdGNoIGxvb2tzIGdvb2Qs
DQoNCm9uZSBOSVQsIHhlbl9kdF9ncmFudF9zZXR1cF9kbWFfb3BzKCkgZG93biB0aGUgY29kZSBk
b2Vzbid0IGFjdHVhbGx5IA0Kc2V0dXAgRE1BIE9QUywgaXQgcmV0cmlldmVzIHRoZSBiYWNrZW5k
IGRvbWlkIHZpYSBkZXZpY2UtdHJlZSBtZWFucyBhbmQgDQpzdG9yZXMgaXQsDQoNCnNvIEkgd291
bGQgcmVuYW1lIHRvIGl0LCBtYXliZSBzb21ldGhpbmcgbGlrZSANCnhlbl9kdF9ncmFudF9zZXR1
cF9iYWNrZW5kX2RvbWlkKCkgb3IgeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCgpLCAN
CmJ1dCBJIGFtIG5vdCBzdXJlIGl0IHdvdWxkIGJlIGdvb2QgYWx0ZXJuYXRpdmUuDQoNCg0KU28s
IHcvIG9yIHcvbyByZW5hbWluZzoNCg0KUmV2aWV3ZWQtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtv
IDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCg0KYWxzbw0KDQpUZXN0ZWQtYnk6IE9s
ZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4gIyBBcm02
NCANCm9ubHkNCg0KDQo+IC0tLQ0KPiAgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyB8IDY4
ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0NCj4gICAxIGZpbGUgY2hhbmdl
ZCwgNDMgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMN
Cj4gaW5kZXggODk3M2ZjMWU5Y2NjLi5mMjk3NTlkNTMwMWYgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl
cnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMNCj4gQEAgLTI3MywyMiArMjczLDI4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX21hcF9v
cHMgeGVuX2dyYW50X2RtYV9vcHMgPSB7DQo+ICAgCS5kbWFfc3VwcG9ydGVkID0geGVuX2dyYW50
X2RtYV9zdXBwb3J0ZWQsDQo+ICAgfTsNCj4gICANCj4gLWJvb2wgeGVuX2lzX2dyYW50X2RtYV9k
ZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPiArc3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50
X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPiAgIHsNCj4gICAJc3RydWN0IGRldmlj
ZV9ub2RlICppb21tdV9ucDsNCj4gICAJYm9vbCBoYXNfaW9tbXU7DQo+ICAgDQo+IC0JLyogWFhY
IEhhbmRsZSBvbmx5IERUIGRldmljZXMgZm9yIG5vdyAqLw0KPiAtCWlmICghZGV2LT5vZl9ub2Rl
KQ0KPiAtCQlyZXR1cm4gZmFsc2U7DQo+IC0NCj4gICAJaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFu
ZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPiAtCWhhc19pb21tdSA9IGlvbW11X25w
ICYmIG9mX2RldmljZV9pc19jb21wYXRpYmxlKGlvbW11X25wLCAieGVuLGdyYW50LWRtYSIpOw0K
PiArCWhhc19pb21tdSA9IGlvbW11X25wICYmDQo+ICsJCSAgICBvZl9kZXZpY2VfaXNfY29tcGF0
aWJsZShpb21tdV9ucCwgInhlbixncmFudC1kbWEiKTsNCj4gICAJb2Zfbm9kZV9wdXQoaW9tbXVf
bnApOw0KPiAgIA0KPiAgIAlyZXR1cm4gaGFzX2lvbW11Ow0KPiAgIH0NCj4gICANCj4gK2Jvb2wg
eGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPiArew0KPiArCS8q
IFhYWCBIYW5kbGUgb25seSBEVCBkZXZpY2VzIGZvciBub3cgKi8NCj4gKwlpZiAoZGV2LT5vZl9u
b2RlKQ0KPiArCQlyZXR1cm4geGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2UoZGV2KTsNCj4gKw0K
PiArCXJldHVybiBmYWxzZTsNCj4gK30NCj4gKw0KPiAgIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNj
KHN0cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYpDQo+ICAgew0KPiAgIAlpZiAoSVNfRU5BQkxFRChD
T05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVCkpDQo+IEBAIC0yOTcsNDUgKzMwMyw1NiBAQCBi
b29sIHhlbl92aXJ0aW9fbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KQ0KPiAgIAly
ZXR1cm4geGVuX2lzX2dyYW50X2RtYV9kZXZpY2UoZGV2LT5kZXYucGFyZW50KTsNCj4gICB9DQo+
ICAgDQo+IC12b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldikN
Cj4gK3N0YXRpYyBpbnQgeGVuX2R0X2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAq
ZGV2LA0KPiArCQkJCSAgICAgICBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhKQ0KPiAg
IHsNCj4gLQlzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPiAgIAlzdHJ1Y3Qgb2Zf
cGhhbmRsZV9hcmdzIGlvbW11X3NwZWM7DQo+ICAgDQo+IC0JZGF0YSA9IGZpbmRfeGVuX2dyYW50
X2RtYV9kYXRhKGRldik7DQo+IC0JaWYgKGRhdGEpIHsNCj4gLQkJZGV2X2VycihkZXYsICJYZW4g
Z3JhbnQgRE1BIGRhdGEgaXMgYWxyZWFkeSBjcmVhdGVkXG4iKTsNCj4gLQkJcmV0dXJuOw0KPiAt
CX0NCj4gLQ0KPiAtCS8qIFhYWCBBQ1BJIGRldmljZSB1bnN1cHBvcnRlZCBmb3Igbm93ICovDQo+
IC0JaWYgKCFkZXYtPm9mX25vZGUpDQo+IC0JCWdvdG8gZXJyOw0KPiAtDQo+ICAgCWlmIChvZl9w
YXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25vZGUsICJpb21tdXMiLCAiI2lvbW11LWNl
bGxzIiwNCj4gICAJCQkwLCAmaW9tbXVfc3BlYykpIHsNCj4gICAJCWRldl9lcnIoZGV2LCAiQ2Fu
bm90IHBhcnNlIGlvbW11cyBwcm9wZXJ0eVxuIik7DQo+IC0JCWdvdG8gZXJyOw0KPiArCQlyZXR1
cm4gLUVTUkNIOw0KPiAgIAl9DQo+ICAgDQo+ICAgCWlmICghb2ZfZGV2aWNlX2lzX2NvbXBhdGli
bGUoaW9tbXVfc3BlYy5ucCwgInhlbixncmFudC1kbWEiKSB8fA0KPiAgIAkJCWlvbW11X3NwZWMu
YXJnc19jb3VudCAhPSAxKSB7DQo+ICAgCQlkZXZfZXJyKGRldiwgIkluY29tcGF0aWJsZSBJT01N
VSBub2RlXG4iKTsNCj4gICAJCW9mX25vZGVfcHV0KGlvbW11X3NwZWMubnApOw0KPiAtCQlnb3Rv
IGVycjsNCj4gKwkJcmV0dXJuIC1FU1JDSDsNCj4gICAJfQ0KPiAgIA0KPiAgIAlvZl9ub2RlX3B1
dChpb21tdV9zcGVjLm5wKTsNCj4gICANCj4gKwkvKg0KPiArCSAqIFRoZSBlbmRwb2ludCBJRCBo
ZXJlIG1lYW5zIHRoZSBJRCBvZiB0aGUgZG9tYWluIHdoZXJlIHRoZQ0KPiArCSAqIGNvcnJlc3Bv
bmRpbmcgYmFja2VuZCBpcyBydW5uaW5nDQo+ICsJICovDQo+ICsJZGF0YS0+YmFja2VuZF9kb21p
ZCA9IGlvbW11X3NwZWMuYXJnc1swXTsNCj4gKw0KPiArCXJldHVybiAwOw0KPiArfQ0KPiArDQo+
ICt2b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldikNCj4gK3sN
Cj4gKwlzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPiArDQo+ICsJZGF0YSA9IGZp
bmRfeGVuX2dyYW50X2RtYV9kYXRhKGRldik7DQo+ICsJaWYgKGRhdGEpIHsNCj4gKwkJZGV2X2Vy
cihkZXYsICJYZW4gZ3JhbnQgRE1BIGRhdGEgaXMgYWxyZWFkeSBjcmVhdGVkXG4iKTsNCj4gKwkJ
cmV0dXJuOw0KPiArCX0NCj4gKw0KPiAgIAlkYXRhID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9m
KCpkYXRhKSwgR0ZQX0tFUk5FTCk7DQo+ICAgCWlmICghZGF0YSkNCj4gICAJCWdvdG8gZXJyOw0K
PiAgIA0KPiAtCS8qDQo+IC0JICogVGhlIGVuZHBvaW50IElEIGhlcmUgbWVhbnMgdGhlIElEIG9m
IHRoZSBkb21haW4gd2hlcmUgdGhlIGNvcnJlc3BvbmRpbmcNCj4gLQkgKiBiYWNrZW5kIGlzIHJ1
bm5pbmcNCj4gLQkgKi8NCj4gLQlkYXRhLT5iYWNrZW5kX2RvbWlkID0gaW9tbXVfc3BlYy5hcmdz
WzBdOw0KPiArCWlmIChkZXYtPm9mX25vZGUpIHsNCj4gKwkJaWYgKHhlbl9kdF9ncmFudF9zZXR1
cF9kbWFfb3BzKGRldiwgZGF0YSkpDQo+ICsJCQlnb3RvIGVycjsNCj4gKwl9IGVsc2Ugew0KPiAr
CQkvKiBYWFggQUNQSSBkZXZpY2UgdW5zdXBwb3J0ZWQgZm9yIG5vdyAqLw0KPiArCQlnb3RvIGVy
cjsNCj4gKwl9DQo+ICAgDQo+ICAgCWlmICh4YV9lcnIoeGFfc3RvcmUoJnhlbl9ncmFudF9kbWFf
ZGV2aWNlcywgKHVuc2lnbmVkIGxvbmcpZGV2LCBkYXRhLA0KPiAgIAkJCUdGUF9LRVJORUwpKSkg
ew0KPiBAQCAtMzQ4LDYgKzM2NSw3IEBAIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3Ry
dWN0IGRldmljZSAqZGV2KQ0KPiAgIAlyZXR1cm47DQo+ICAgDQo+ICAgZXJyOg0KPiArCWRldm1f
a2ZyZWUoZGV2LCBkYXRhKTsNCj4gICAJZGV2X2VycihkZXYsICJDYW5ub3Qgc2V0IHVwIFhlbiBn
cmFudCBETUEgb3BzLCByZXRhaW4gcGxhdGZvcm0gRE1BIG9wc1xuIik7DQo+ICAgfQ0KPiAgIA0K
DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 17:23:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 17:23:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417187.661824 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogUaF-0007uq-9b; Thu, 06 Oct 2022 17:22:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417187.661824; Thu, 06 Oct 2022 17:22:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogUaF-0007uj-6x; Thu, 06 Oct 2022 17:22:55 +0000
Received: by outflank-mailman (input) for mailman id 417187;
 Thu, 06 Oct 2022 17:22:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rxxd=2H=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ogUaD-0007ud-00
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 17:22:53 +0000
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f307320-459b-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 19:22:50 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 207A25C005E;
 Thu,  6 Oct 2022 13:22:47 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Thu, 06 Oct 2022 13:22:47 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 6 Oct 2022 13:22:45 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f307320-459b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1665076967; x=
	1665163367; bh=8STzOSUlkj6+X64xjiGkmXhKTE+cDl1b43feNbW+ow4=; b=P
	P0SeOx88SYliO9qfSiBweM6lM8ZuA0Dp9rNrUMGLxl6sW3Z2ppdr9IeN/FmgDk7h
	abairpOKE/TCuyls9fbHPOOj0fGqwqQBsDhl2mn94pXYoJfPpCW75+14UnyWGJKO
	/WosixC040rt1Ev117gZj2wbRfF1VZviP9zdaCvkmwBZq38Fvhj0bWXzxqnsF0p3
	OkgEj2ItYsRoN1msd2IsrkfVE9D4s7/3gurJcY3ZD/1iWLvkLOvSzGwwYzD3p+He
	Pfh5FrSFo4ESQEJm9eNNQflo51sgFpd21UeUrd9qFrmgHPdBy6tMkxoMGRXb8QBK
	zKcLuXHjAdR7rlfQxAUlA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm2; t=1665076967; x=1665163367; bh=8STzOSUlkj6+X64xjiGkmXhKTE+c
	Dl1b43feNbW+ow4=; b=NnuWc3iyJ6+mS9G7gOQugAsUNykR9W6a5kS0rRTaJFI5
	fgFGH9ljgqiwrCLu/S6TvUGz6KYdarT08EJyFsC6MN+CSaedmNOqo3tpBGwMOkEt
	8oE4PZkvBwhKmdR6IFOR+Urz4b3NbPGd4zTsuF9NlZxfZZctt0nSLb3svEu1uSQC
	8YSt3Xt12mvJvhMJr/gcZ3xJnn9jBvsWy6QFaOLRpFDhVIMoM7ho1ZNGtMoSbW+J
	WqJk7ERdwAbAhDs/+0Z5mPpeshFUZ9buKp8LfjkScTfDle63YLW17dUxCGhdXZoO
	Sg+xzFbm1SbEqekp2eYyWdSRVfgWL+RzvWbbAVZDAg==
X-ME-Sender: <xms:5g4_Y37xuOCNThVXgIWhdnSa28tJ7eGEjoJzHou1Hq7pb_cvWjS69g>
    <xme:5g4_Y84i1AMQAIJN4E-cV_BYOEPPwReTDeHSYZyMzoCWGu4tmz4ZqypW2oaHtX2NG
    NS7y9VWCZM-wa0>
X-ME-Received: <xmr:5g4_Y-c94Okpkjrnycf7JpgdVHCFG2zdvD2kFsq_F4k5F5hqGgHr-j_fxsEv>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeihedgudduudcutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffej
    geejgeffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtne
    curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg
    shhlrggsrdgtohhm
X-ME-Proxy: <xmx:5g4_Y4JR77NZVKoPXNgMlBk13-qo87qtGLf62bp0Lf0khH9hKzVAmw>
    <xmx:5g4_Y7JEPLwL4O94T2zRVocnCe7oKAntvaRAnlKHQEZnajKuMK1VDg>
    <xmx:5g4_YxzIX3waId_SH9vC0exSxoR1x-Zotw20SPYUN7BoCe7pizxMfA>
    <xmx:5w4_Y4Bn5bQJunbq0_ISedoNI0uqMpHumgv7KRBFsSH6s5Y6SNyyeg>
Feedback-ID: iac594737:Fastmail
Date: Thu, 6 Oct 2022 13:22:34 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
Message-ID: <Yz8O5ItPhtfpMfI2@itl-email>
References: <YzeaKjmls1YI/3ox@itl-email>
 <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email>
 <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email>
 <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
 <Yz4yLyvX6un1rrqC@itl-email>
 <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>
 <Yz7polT2R2OlT1aT@itl-email>
 <CAMj1kXGe77iwnYXWR=Hjn8eL8-1hMZbprjU8bnYaFWJnRZfdfw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="q3Pdd5Vm/dbedYyy"
Content-Disposition: inline
In-Reply-To: <CAMj1kXGe77iwnYXWR=Hjn8eL8-1hMZbprjU8bnYaFWJnRZfdfw@mail.gmail.com>


--q3Pdd5Vm/dbedYyy
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 6 Oct 2022 13:22:34 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered

On Thu, Oct 06, 2022 at 06:19:35PM +0200, Ard Biesheuvel wrote:
> On Thu, 6 Oct 2022 at 16:43, Demi Marie Obenour
> <demi@invisiblethingslab.com> wrote:
> >
> > On Thu, Oct 06, 2022 at 09:31:47AM +0200, Ard Biesheuvel wrote:
> > > On Thu, 6 Oct 2022 at 03:41, Demi Marie Obenour
> > > <demi@invisiblethingslab.com> wrote:
> > > >
> > > > On Wed, Oct 05, 2022 at 11:28:29PM +0200, Ard Biesheuvel wrote:
> > > > > On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
> > > > > <demi@invisiblethingslab.com> wrote:
> > > > > >
> > > > > > On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > > > > > > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > > > > > > Linux has a function called efi_mem_reserve() that is used =
to reserve
> > > > > > > > EfiBootServicesData memory that contains e.g. EFI configura=
tion tables.
> > > > > > > > This function does not work under Xen because Xen could hav=
e already
> > > > > > > > clobbered the memory.  efi_mem_reserve() not working is the=
 whole reason
> > > > > > > > for this thread, as it prevents EFI tables that are in
> > > > > > > > EfiBootServicesData from being used under Xen.
> > > > > > > >
> > > > > > > > A much nicer approach would be for Xen to reserve boot serv=
ices memory
> > > > > > > > unconditionally, but provide a hypercall that dom0 could us=
ed to free
> > > > > > > > the parts of EfiBootServicesData memory that are no longer =
needed.  This
> > > > > > > > would allow efi_mem_reserve() to work normally.
> > > > > > >
> > > > > > > efi_mem_reserve() actually working would be a layering violat=
ion;
> > > > > > > controlling the EFI memory map is entirely Xen's job.
> > > > > >
> > > > > > Doing this properly would require Xen to understand all of the =
EFI
> > > > > > tables that could validly be in EfiBootServices* and which coul=
d be of
> > > > > > interest to dom0.  It might (at least on some very buggy firmwa=
re)
> > > > > > require a partial ACPI and/or SMBIOS implementation too, if the=
 firmware
> > > > > > decided to put an ACPI or SMBIOS table in EfiBootServices*.
> > > > > >
> > > > > > > As to the hypercall you suggest - I wouldn't mind its additio=
n, but only
> > > > > > > for the case when -mapbs is used. As I've indicated before, I=
'm of the
> > > > > > > opinion that default behavior should be matching the intentio=
ns of the
> > > > > > > spec, and the intention of EfiBootServices* is for the space =
to be
> > > > > > > reclaimed. Plus I'm sure you realize there's a caveat with Do=
m0 using
> > > > > > > that hypercall: It might use it for regions where data lives =
which it
> > > > > > > wouldn't care about itself, but which an eventual kexec-ed (o=
r alike)
> > > > > > > entity would later want to consume. Code/data potentially usa=
ble by
> > > > > > > _anyone_ between two resets of the system cannot legitimately=
 be freed
> > > > > > > (and hence imo is wrong to live in EfiBootServices* regions).
> > > > > >
> > > > > > I agree, but currently some such data *is* in EfiBootServices* =
regions,
> > > > > > sadly.  When -mapbs is *not* used, I recommend uninstalling all=
 of the
> > > > > > configuration tables that point to EfiBootServicesData memory b=
efore
> > > > > > freeing that memory.
> > > > > >
> > > > >
> > > > > That seems like a reasonable approach to me. Tables like MEMATTR =
or
> > > > > RT_PROP are mostly relevant for bare metal where the host kernel =
maps
> > > > > the runtime services, and in general, passing on these tables wit=
hout
> > > > > knowing what they do is kind of fishy anyway. You might even argue
> > > > > that only known table types should be forwarded in the first plac=
e,
> > > > > regardless of the memory type.
> > > >
> > > > Which tables are worth handling in Xen?  I know about ACPI, SMBIOS,=
 and
> > > > ESRT, but I am curious which others Xen should preserve.  Currently=
, Xen
> > > > does not know about RT_PROP or MEMATTR; could this be a cause of
> > > > problems?
> > >
> > > dom0 only has access to paravirtualized EFI runtime services, so
> > > consuming RT_PROP or MEMATTR should be up to Xen (they describe which
> > > runtime services remain available at runtime, and which permission
> > > attributes to use for the runtime services memory regions,
> > > respectively)
> >
> > Xen does not do this right now.  I wonder if this could be the cause of
> > compatibility issues with various firmware implementations.
> >
> > > Looking through the kernel code, I don't think there are any that dom0
> > > should care about beyond ACPI, SMBIOS and ESRT. But as you suggest,
> > > that means Xen should just mask them in the view of the EFI system
> > > table it exposes so dom0. Otherwise, the kernel may still try to map
> > > and parse them.
> >
> > What about the BGRT and MOKvar?  I agree that Xen should not expose the
> > others.  Should it just hide the tables, or should it actually uninstall
> > them?  My intuition is that the second would be technically more
> > correct, but also more likely to trigger bugs in various firmware
> > implementations.
>=20
> BGRT is a ACPI table not a EFI configuration table, so I'd assume it
> is treated the same way as other ACPI tables

That actually surprises me.  Xen definitely needs to know about its
GUID, then.  Are there any other EFI configuration tables that Xen needs
to know about, or ACPI tables that might be outside of
EfiACPIReclaimMemory.

> MOKvar is a fallback for systems where it doesn't fit into a volatile
> variable IIRC but I am not sure if it is actually implemented
> anywhere, and what type of memory region it is expected to use.
>=20
> However, I'm not sure if it even matters, given that Xen loads the
> dom0 kernel not the firmware, right?

No idea.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--q3Pdd5Vm/dbedYyy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmM/DuQACgkQsoi1X/+c
IsEicxAA3lUz8SveZIU9v+BatOCM7Tuh3LE03CsRUtdBaA9JQKN3m8B3cHPJKVod
Bgtp5mcjVDJIQ34tJByBv/Pn3yvwc88kBeu9ePesE5Nz3rK5lCPhQy2KRGVtjB6j
LMvGiQlo4lpliXm+02+qCeYrvgtDTDG5zPdv69FQR/rP+gCRaEtQzCV2IC1kPpRK
6G4jpkcbsfj0KuSmrKduss/D29ji4lfbR7/kDFhmJGkXWnf5iSLCtTLlUgCPCQ09
q9ibVjp7/6kXspfzN6v70WsrPW426XGocEAtXw9QuIM6fnPptObxZa1ucnhfkJxY
HpRrqvip57raC6Kmpl8NLlpfbvGFpqOzimmAKVrN+4hWuE14Z1bOd7ETBU847vLb
FdAyI8nEuxD45fcAp01BqMfbQqP5Cf3uXVR1P+w9MLojxWrEkpeGr4eLBOuuThNz
NCuQ1EHBZAa25Phj9unbP8c5XtgghsqTNjF4TnySsUe+xCKxa1JQPreRwZwkDAWc
BQ5+vA2n9eC5X8lhUiIw67jet07cVW0IMnYowQKEMKt27L3UUI+FQ9w3GUZsfghr
dkwSdIrjvsi6yR8U/hBHvJ6CCgejaDPc4qYs78AX6EEPMB9KZaZtGlmQK2TXfitl
bxr5+KV67bxncdYeZrXTHn4rYRBkzw9HdzYJEE1Gk8Q+pNVrsVU=
=lYYE
-----END PGP SIGNATURE-----

--q3Pdd5Vm/dbedYyy--


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 17:24:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 17:24:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417195.661836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogUbJ-0008Vb-Mz; Thu, 06 Oct 2022 17:24:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417195.661836; Thu, 06 Oct 2022 17:24:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogUbJ-0008VU-Jy; Thu, 06 Oct 2022 17:24:01 +0000
Received: by outflank-mailman (input) for mailman id 417195;
 Thu, 06 Oct 2022 17:24:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M1JS=2H=epam.com=prvs=22784c7a74=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ogUbI-0008VF-4t
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 17:24:00 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a8d32bc1-459b-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 19:23:58 +0200 (CEST)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296G3XYw010824;
 Thu, 6 Oct 2022 17:23:47 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k1wfhsyfv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 06 Oct 2022 17:23:47 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB3PR0302MB8968.eurprd03.prod.outlook.com (2603:10a6:10:433::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct
 2022 17:23:45 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.032; Thu, 6 Oct 2022
 17:23:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8d32bc1-459b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LK2VwOCh0z6iOu7rRZ7wpTM8Y1AiAf7kgeyr7FjkDYJHkFCESyD62I09Fxu2eg4plzB/YnG9epyhQNMYzpzOe9TE2FDtY1J3DlnCjWYx+h0DOJvvcYX18+ImZPk3NYldhS1Zj/2Fd6fdlcUm1jCNP+KwsrEs8GVQmugy6wRu//1ztkpPKGyFcf0jLNRC59Pt0zDUWpIbjVpE/1Y245AddAX4gkrl7fqpIJyCAKtxpf/+HadSvXtsHmeo85gD+zIBC1oDxi/abmPTYCSQ4Z4kLVoYWHfiL2hP4aGfUo/MxobryW9I/1Eai1FWhRZcrtAi4X7Yyq3WXrMt9foeuX4vbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W8m1sKTh6VL5hm0H1sMOzX6k5cFfjhU+L4lTgUPJKlU=;
 b=EyYjQjKx/lNiJ9+9OgzT9gRXehKp/QTHQqeG3aMSFWJq8onNK3+5ee24eMJf1QC9zOlmnxocBrm0OMrgIxVEZ3NR2IqjRDcpGBuav/aIOvoaAeiidQZNcTn71FgL2Di2oJ5TO/uj9sEs4erT7X2Ph/Logj9cX/5TlDKwc8ODFnuJBXxuS6nLuANpNJtMGPphpWlIZo3nhPixl53WAf0DZhToKpkUzC2a8owMMs5owP4Ut3Giv2LgPWDBcYsy64vqU9i0QSSROsrbltBwPsWEaB6rQS+e80fYIYs7U9baJOYD5xOxfpHxTqUztvsyeK9f8qCnCFIwShSaBxaJTcQSQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=W8m1sKTh6VL5hm0H1sMOzX6k5cFfjhU+L4lTgUPJKlU=;
 b=o/LNcORAaI8wHJ2+SDMV0VopffGAt8TQB5UxUZ7sVHOv/kw+TMrdvU482saMhWGor27IpHN3SZjxySg7OweN8+p87ArKjI7pN5p0BaVbmk3/Vyo2KX2pMvgd0CeSI/zqVWRcWzIWZdQcLDFaXr5dOT5Z8RDRKY/YDtltKYWl3MrGm5TrkiUkJhHUo/57zNHUa1d7ue+6F5meoflgr0Stwx8qv+jIef/AhWNfCTaCUumJrOXDDRcIdqHKZd36KwylKrSwsJsDEoHpRJq+mAnQ+ba8gBy8x26fRq0Z+EpFsKMQ4U3yeZg4hw9AFTzBShNelcVuwmupPdmK5s+EzDiIIw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen/virtio: use dom0 as default backend for
 CONFIG_XEN_VIRTIO_FORCE_GRANT
Thread-Topic: [PATCH 2/3] xen/virtio: use dom0 as default backend for
 CONFIG_XEN_VIRTIO_FORCE_GRANT
Thread-Index: AQHY2VNlob0BWl5FK0K3rZia87E8oK4Bnh4A
Date: Thu, 6 Oct 2022 17:23:44 +0000
Message-ID: <36b69e76-a26e-f7e5-998a-8345034cec20@epam.com>
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-3-jgross@suse.com>
In-Reply-To: <20221006071500.15689-3-jgross@suse.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DB3PR0302MB8968:EE_
x-ms-office365-filtering-correlation-id: f7ae7e71-9dd3-45c9-957b-08daa7bf85a4
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 0RQvg92xO2KCzDYg5aGMazPN8zXTHEEyaWm00O+BRj0O1I2w6wuhUmJhzKrwyr0KSyKmeMrbeyNWYmRqtoqpl/XrAid1Zs2fv/6FA7z+MZRmnGxyU/j9k3jGz6vE0eVP5sWZcdWEL8/S+zIbJp+gUN0x1RNR96KswhFSmw+Eg5rIcCm8pd9lMzlxppW+Xy/vHmO/SQQVvGYwQ/IkKPMLrsYwWDhjB6MJ348vtCRs3VX2nMghZETMH4fGr4P4oYSPXhAbfUUgw7VgB2f8OUQCqkezijIozGDSyJQJ/jn2MfrxeUrnFVzt7xowB065BJ9K3lOg6G0RQBch6pNZzd24dQswwznyOeIS0ur7/fk86YAuFghgWxuDCGCygwdF/ciqEYpjPMkS4JdN/iDCntH2v2UfIvoTfxqlnAWALpRBDsr8J9OK4R5CN7nGi0j9VTbJ/A/jZCgmkOM2pJPO62tMCe+nU3FaI3BsVrTONb/szRjrha87BcsLaOzj0qVNqEGx4V+VyISNZpWC0xJj74jbMCMQF/bBUjI7K0dK22xLzUw30P27Mb76YTVePoyLdVEnqlPPI+Tf00U+OP/QsWmwd2j1WKTCevdTQu4u2HN+cvbU1+sR22YSGMYAyqtczKSk4Y/vrcl/+y7sA6w9OSbX3qDCRRaGR4iKgRy10FmvBJKxyW6Pgnd2ApZ6LvX8NwDupdyS8Hj5DZNGL8kNiYkFx6CL+uU8v6l1mknDo4QZv5jrQtgQutAPXKYi10iCnkkElXkUiIxTX2xNiOcHXiE4e85kcIbcV3VGGZ8etwp/I+TvMdmIIosYwUTtAkbiX4h9
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(366004)(136003)(346002)(39860400002)(451199015)(71200400001)(6512007)(26005)(8676002)(76116006)(91956017)(4326008)(4744005)(6506007)(122000001)(38100700002)(53546011)(31686004)(55236004)(110136005)(186003)(54906003)(316002)(86362001)(31696002)(2616005)(41300700001)(66476007)(2906002)(478600001)(66946007)(36756003)(66446008)(5660300002)(64756008)(38070700005)(66556008)(6486002)(8936002)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Ny8wV3dBYUY4cERkeGpuaWdrU2kwNis0eCtFSjNLTVNtNVdld3ZZTTE2RHY0?=
 =?utf-8?B?NGFtVDVMT2djRWFOejhYaDFnSVZDWlEvUlMxMDJ6b1Zvb2sxR2x5ZytsL2d3?=
 =?utf-8?B?MVVrUjgwemxMSTBYajEwMzgwb1dUQnpJSElsTXVlR1o3d1dZQXp5VVQ0cUV5?=
 =?utf-8?B?Kzd1akRUcTNjT0ZyQW9kWXlZZU9uYnpLUllDcWxWVVJGRnFhK1JQaGY4Z3ZL?=
 =?utf-8?B?UVhmenlEY2FOZjJhNFJCNWFiYVlWY2hGSFIwWVlUdXlVNjRiMi9pd3Fnalp0?=
 =?utf-8?B?Y0JHbEE1NHZRZHJwa2JJZG8wemJSZ0xJTTJld2QvNWZmYm9paEZYOEx1WDRK?=
 =?utf-8?B?aGZ6RkZWR082QWlJOWswRlloMHlOVndtclI0MHlhVlpPdkhYbTY5UGoxMjNN?=
 =?utf-8?B?ZXFacEhud25pMEpvWG8vd01NeFQrMEJFMmhNV20wYkwrVW8yb0kzMFZERzc1?=
 =?utf-8?B?WEVxQUxyU1FvcFN1clMyR0NjZTZKQTVzUTRTRjJkc1hJOUNQOGk0a1pJajY0?=
 =?utf-8?B?VXJDaU1SZ2R0ZXE4c3pCNEZVdktVcmtrR3JjMThiem0vRE45NkVqakpLWUdu?=
 =?utf-8?B?QjlSaEcyRnVGZXpzaHl1VVVVRkMwVCtyNmdQR2pVViszTHFnR0NtQS9TbmNB?=
 =?utf-8?B?eTh6RmJsc1h2V1hZeEJGY1VLTWM4Y2FFZ2ZIeEVuRGtxSXE5cHZJZ290MFpn?=
 =?utf-8?B?Nm8yQWxNWFhKZk9sZTJzMmZTRjhtcHJObkg4TkRzNzd2QWo0QzFjWklya09I?=
 =?utf-8?B?SHBOODd5RWpJYml0TE8zM25jNnhJSDlqYkNETXdIclZaOElJdjdManNSSEps?=
 =?utf-8?B?cG9mWlpaZ1cxajFxZjJ3UEVLMTl3UUxPQ2FZS0R6emhJaXptT2E4d0NEaith?=
 =?utf-8?B?aUliYnUzSXY3djl2WmNTK0NFWDAxMGRnaVNUM01PelE4a0ZNQmlSRjZ2UXh2?=
 =?utf-8?B?Tng2RE10ZTV4ZXRmbkdsUStNOU1zM2piWWhqbld0SmtDc09nYzdXM09kb0NM?=
 =?utf-8?B?QkVldWR1SHJXckowVFc4WTMxVVk5SnBtU2RoWk9yS2FtTVhuY3JtZWV3cTF5?=
 =?utf-8?B?R1NmZE5qeDBOUUhYWlI4VTBEcTM2cUVDWjJVVXorRExrMFo0MDRCUE16T3ZY?=
 =?utf-8?B?cUQvb0Zla2sydS96WkpSaU1FbmtqMTE5Ui9JQWErUXFvUkE0WkM3Y0VnZzQx?=
 =?utf-8?B?eE5vaExKYVowWWdpc0w1RjRKcWkrelRscVM3bndmbkxVRHNmdXhzQlgrVFMy?=
 =?utf-8?B?WGh0NEpIRmhOMHYyTFVRRTMyZHJXamc1dDZzQWZuQnUvTFhBWC85OXpVbWVV?=
 =?utf-8?B?Y1I2TmZMTGZnNWFsYmlYdzRvRnlOK0I5QmFGWTVYcHBNbm1TVTVia0diZVNX?=
 =?utf-8?B?SUNqZmNqWitpNVUzYWZrN0xIa0tCMnRpWGZLa1g4SmZldHJIei9XaGorTksr?=
 =?utf-8?B?UTZ3aG52MFl5Sjg3bnZQczgxbVVDaFZOMzR1aDJWZTBKU0c0YzNVdDJWSG8v?=
 =?utf-8?B?YzlCcHNyR1ljVmx4U0h2d2RCVDFDMEZoME5rb3NOWVF6Skp2WGxsSVBhb0lP?=
 =?utf-8?B?OGlqV2pTRkswenNOVHY2Uy8raVhRb2VITFpLT3N3bnY3RlpFT1VLMTI1NzNl?=
 =?utf-8?B?RlVsNkgxRGxKUVJnR1lDMDlGUjA1M09jbmhGRmU0NkpMQUdFdXg2MnZ6Q1hk?=
 =?utf-8?B?dUE0ZzhJU3FIRE9US1F0S242S010RGlJc3ZQcDIvUW5tQm9kaldwRDRtT2N2?=
 =?utf-8?B?Mng5eXZ5MjVjUmRCM29QeFExYWNCZEoxdExQcFlIanRITVFkNEVnVEp1NFdu?=
 =?utf-8?B?Mk43VUZHaURONDh1d3JVQXlnbE5HMkhOSlNJQzV2T0cyR3h0Zm9DMksxV0s1?=
 =?utf-8?B?UXNvdXpXZWZkUFhCeEFmeU55U3Eva1g0QzZ4czVKV3ZLend2NGJqQTJpV2dy?=
 =?utf-8?B?WTdlWmNRRVFqc3pyMWk3NXVuVWZaanI0Rll5bWRVUGNsdkdoSG5jeFczSUor?=
 =?utf-8?B?WGFqdzAvSWJaMkR4eGR5SUN5bVNBK2JaS1hxcWVRM1JDS29zSmRCZHpzUUVR?=
 =?utf-8?B?YnJsS1B5cHhBN2ovaFo0YmtJNFg0NVFuUzdSSFFscEt5NDhzaVY5R0VuZk9n?=
 =?utf-8?B?c1lxS0VOQ2N1RnZoZ2FQTEtBY3JnaklMaUFjSlNicll3aXdwazdUZFVLb0Nx?=
 =?utf-8?Q?893K2uO3ee3sujmpjisDO4w=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <99E076B011851849A5578A56BC301E9C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7ae7e71-9dd3-45c9-957b-08daa7bf85a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 17:23:44.8782
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XwwjcQvbmk71R7jer6BpHqrs7qHGGpDBHJiuRU7X+Fg2HWyUQIYV1NoM1s6mcQYCsIykWeCdEJMWEAUDJuyylg7FA4gbqtddid1e974YEx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0302MB8968
X-Proofpoint-GUID: DCzsmJJu0f1O__zN9nutnUUONdBU_m7C
X-Proofpoint-ORIG-GUID: DCzsmJJu0f1O__zN9nutnUUONdBU_m7C
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_04,2022-10-06_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 suspectscore=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0
 spamscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0
 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210060101

DQpPbiAwNi4xMC4yMiAxMDoxNCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCg0KSGVsbG8gSnVlcmdl
bg0KDQo+IFdpdGggQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQgc2V0IHRoZSBkZWZhdWx0
IGJhY2tlbmQgZG9taWQgdG8gMCwNCj4gZW5hYmxpbmcgdG8gdXNlIHhlbl9ncmFudF9kbWFfb3Bz
IGZvciB0aG9zZSBkZXZpY2VzLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq
Z3Jvc3NAc3VzZS5jb20+DQo+IC0tLQ0KPiAgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyB8
IDMgKysrDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KDQoNClJldmlld2Vk
LWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQoNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBiL2RyaXZl
cnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPiBpbmRleCBmMjk3NTlkNTMwMWYuLmEwMDExMjIzNTg3
NyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+ICsrKyBiL2Ry
aXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPiBAQCAtMzQ5LDYgKzM0OSw5IEBAIHZvaWQgeGVu
X2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2KQ0KPiAgIAlpZiAoZGV2LT5v
Zl9ub2RlKSB7DQo+ICAgCQlpZiAoeGVuX2R0X2dyYW50X3NldHVwX2RtYV9vcHMoZGV2LCBkYXRh
KSkNCj4gICAJCQlnb3RvIGVycjsNCj4gKwl9IGVsc2UgaWYgKElTX0VOQUJMRUQoQ09ORklHX1hF
Tl9WSVJUSU9fRk9SQ0VfR1JBTlQpKSB7DQo+ICsJCWRldl9pbmZvKGRldiwgIlVzaW5nIGRvbTAg
YXMgYmFja2VuZFxuIik7DQo+ICsJCWRhdGEtPmJhY2tlbmRfZG9taWQgPSAwOw0KPiAgIAl9IGVs
c2Ugew0KPiAgIAkJLyogWFhYIEFDUEkgZGV2aWNlIHVuc3VwcG9ydGVkIGZvciBub3cgKi8NCj4g
ICAJCWdvdG8gZXJyOw0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 17:48:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 17:48:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417202.661846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogUz2-0002gV-JR; Thu, 06 Oct 2022 17:48:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417202.661846; Thu, 06 Oct 2022 17:48:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogUz2-0002gO-Gh; Thu, 06 Oct 2022 17:48:32 +0000
Received: by outflank-mailman (input) for mailman id 417202;
 Thu, 06 Oct 2022 17:48:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Y3UN=2H=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ogUz1-0002gI-5s
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 17:48:31 +0000
Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com
 [2a00:1450:4864:20::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1663bb88-459f-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 19:48:29 +0200 (CEST)
Received: by mail-ej1-x62a.google.com with SMTP id ot12so6283166ejb.1
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 10:48:29 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 r9-20020a1709061ba900b00782cd82db09sm6083ejg.106.2022.10.06.10.48.27
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 06 Oct 2022 10:48:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1663bb88-459f-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=qCbcp558dSRzPWqfkd7610ukm4C9UgSFZEwAJSe+6ac=;
        b=PlGVFo1Bs1Xp0DNjnMDiKkz3PaSM8Z2sCoJynZKxhmHnzBAuL1n/pUlp/nneWY4zgo
         Y1ZHktK50+KOuBsev48HUYbK6+zLxV+mgndjbbiMPrUEADty8TuvnUPPYS03jC/h+hka
         9D821vE5hiB9bm65E/ugB+ZXexk0FuSAwX9zxdcqMkwVjkvVgnWlheb6V+m79eCodjWf
         QfATw2zBgP9cSXL1BAX0hdkZHkvsqvTqw6ifAhniKu5d98CxiOitg8qb1Bb57U7aq+1r
         ou36BUsFr0kSGxI5bvLqudv26uqWCD0Xcf44R+H3Ao6N3rTi9R/5TAUJxW8UJwv3bxky
         kEUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=qCbcp558dSRzPWqfkd7610ukm4C9UgSFZEwAJSe+6ac=;
        b=wyaxgLoCO2dvOeldoMRIRtnvAXNt0MdCCVwHrcrq6gd21PnFsliDfvRtEdycmjocHZ
         pPJuKsuJqLte/wVVDh7hptBLxRSO3EYcDGaQOxVU5yognszX0cIj3jWZdo+W1j18Iyi0
         d1oclg7VVyy5nR3IoP4eIQMhJz+Wd9aH5GAnATC9M7tnTP8CCXWHT5QQnkFTu9A9lTBJ
         moXydVfO8pJKpIVWo/3oXw4pg14kZLqjU1txoVwmdeZh1QotoN2kRRlvl6Y4ZH2fg+Pu
         U6MEUK1tw6XaldQc9elI4BdY7d4L7obaWh38oLR+Mvq/GQIUYXjtci3Edx4+vJYWd9kR
         CJBA==
X-Gm-Message-State: ACrzQf0PFfsZoxeQINFryEA1sfKLaWf7iUFrfWUcLhFTP4xJ7ft8qQB8
	R2LTsExXowNaklLz0TMojnFmSqQjCd8=
X-Google-Smtp-Source: AMsMyM5F06M8lOlSxwL1OrbBJ3wulHy+f3oIidmjgUWRbsgE9MfznLbymc6xLP0QaotXghpgfzmwyw==
X-Received: by 2002:a17:907:2672:b0:781:dc01:6c5a with SMTP id ci18-20020a170907267200b00781dc016c5amr883058ejc.191.1665078508746;
        Thu, 06 Oct 2022 10:48:28 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH] xen/virtio: Handle PCI devices which Host controller is described in DT
Date: Thu,  6 Oct 2022 20:48:04 +0300
Message-Id: <20221006174804.2003029-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Use the same "xen-grant-dma" device concept (based on generic IOMMU
device-tree bindings) for the PCI devices behind device-tree based
PCI Host controller.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
on Arm at some point in the future. The Xen toolstack side is not published yet.
Here, for PCI devices we use the same way to pass backend domid to the guest as for
platform devices.

Depends on Juergen's series:
https://lore.kernel.org/xen-devel/20221006071500.15689-1-jgross@suse.com/
---
 drivers/xen/grant-dma-ops.c | 51 +++++++++++++++++++++++++++++--------
 1 file changed, 41 insertions(+), 10 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index ff9be3aff87e..79d13122ec08 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/dma-map-ops.h>
 #include <linux/of.h>
+#include <linux/pci.h>
 #include <linux/pfn.h>
 #include <linux/xarray.h>
 #include <linux/virtio_anchor.h>
@@ -273,12 +274,28 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
-static bool xen_is_dt_grant_dma_device(struct device *dev)
+static struct device_node *xen_dt_get_node(struct device *dev)
+{
+	if (dev_is_pci(dev)) {
+		struct pci_dev *pdev = to_pci_dev(dev);
+		struct pci_bus *bus = pdev->bus;
+
+		/* Walk up to the root bus to look for PCI Host controller */
+		while (!pci_is_root_bus(bus))
+			bus = bus->parent;
+
+		return of_node_get(bus->bridge->parent->of_node);
+	}
+
+	return of_node_get(dev->of_node);
+}
+
+static bool xen_is_dt_grant_dma_device(struct device_node *np)
 {
 	struct device_node *iommu_np;
 	bool has_iommu;
 
-	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
+	iommu_np = of_parse_phandle(np, "iommus", 0);
 	has_iommu = iommu_np &&
 		    of_device_is_compatible(iommu_np, "xen,grant-dma");
 	of_node_put(iommu_np);
@@ -288,9 +305,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
 
 bool xen_is_grant_dma_device(struct device *dev)
 {
+	struct device_node *np;
+
 	/* XXX Handle only DT devices for now */
-	if (dev->of_node)
-		return xen_is_dt_grant_dma_device(dev);
+	np = xen_dt_get_node(dev);
+	if (np) {
+		bool ret;
+
+		ret = xen_is_dt_grant_dma_device(np);
+		of_node_put(np);
+		return ret;
+	}
 
 	return false;
 }
@@ -303,20 +328,20 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
 	return xen_is_grant_dma_device(dev->dev.parent);
 }
 
-static int xen_dt_grant_setup_dma_ops(struct device *dev,
+static int xen_dt_grant_setup_dma_ops(struct device_node *np,
 				       struct xen_grant_dma_data *data)
 {
 	struct of_phandle_args iommu_spec;
 
-	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
+	if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
 			0, &iommu_spec)) {
-		dev_err(dev, "Cannot parse iommus property\n");
+		pr_err("%s: Cannot parse iommus property\n", np->name);
 		return -ESRCH;
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
 			iommu_spec.args_count != 1) {
-		dev_err(dev, "Incompatible IOMMU node\n");
+		pr_err("%s: Incompatible IOMMU node\n", iommu_spec.np->name);
 		of_node_put(iommu_spec.np);
 		return -ESRCH;
 	}
@@ -335,6 +360,7 @@ static int xen_dt_grant_setup_dma_ops(struct device *dev,
 void xen_grant_setup_dma_ops(struct device *dev)
 {
 	struct xen_grant_dma_data *data;
+	struct device_node *np;
 
 	data = find_xen_grant_dma_data(dev);
 	if (data) {
@@ -346,8 +372,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	if (!data)
 		goto err;
 
-	if (dev->of_node) {
-		if (xen_dt_grant_setup_dma_ops(dev, data))
+	np = xen_dt_get_node(dev);
+	if (np) {
+		int ret;
+
+		ret = xen_dt_grant_setup_dma_ops(np, data);
+		of_node_put(np);
+		if (ret)
 			goto err;
 	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
 		dev_info(dev, "Using dom0 as backend\n");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 06 17:56:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 17:56:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417208.661858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogV6w-0004Ax-FK; Thu, 06 Oct 2022 17:56:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417208.661858; Thu, 06 Oct 2022 17:56:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogV6w-0004Aq-Ap; Thu, 06 Oct 2022 17:56:42 +0000
Received: by outflank-mailman (input) for mailman id 417208;
 Thu, 06 Oct 2022 17:56:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hmTD=2H=kernel.org=ardb@srs-se1.protection.inumbo.net>)
 id 1ogV6v-0004Ak-2k
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 17:56:41 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 396fc0f2-45a0-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 19:56:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 79A6661A40
 for <xen-devel@lists.xenproject.org>; Thu,  6 Oct 2022 17:56:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 688B3C43145
 for <xen-devel@lists.xenproject.org>; Thu,  6 Oct 2022 17:56:36 +0000 (UTC)
Received: by mail-lj1-f180.google.com with SMTP id q7so620603ljp.3
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 10:56:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 396fc0f2-45a0-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665078996;
	bh=sHwxh1eGzvk2lYApcwcjGMjmMWZScaLf7EYawNjiO/k=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=kFrXl9t/KAvZALVLVqv3E85Pv3nz17GV0+odgHkcdq8kCiVvbbrofkZuplOOhYpqb
	 o9kBl7mojxX4oJKO3I/aEaWtshbn6QeJx96TcLtauEBU/hJ8CBg9NtiMyby2ip02ZG
	 OEd7qisWNjaTpy71zskL8OHTODVpBP7F367Lt7JOeWrOJ83y2pFQHcxUK02/qFQ+5X
	 YT1itgrzaDHzUQAE04PfmBbEgOBRgoli+CR4FFPv/Un3UvlehUiwtAbtQ/lBEZGN5y
	 jy6dxvyt3E9IkIKJrnJqbETXKs7ox61TWi8mit8UectGcQTNGgTDr8A+1RNHgHGN0Y
	 NC3SX7SR9h7fg==
X-Gm-Message-State: ACrzQf3j1zBwHGrUqrUDk/e9kFJTUDGS/qP1tE7ety0aKjXoRr2Yz4qg
	LImJmqev3TlmZfVcC8gimLyNqsk4KZyAfWC0Fn0=
X-Google-Smtp-Source: AMsMyM7Rfb5BiZpSrs/H8RibUWN1eetAoyvnKWxSmrqSzjlTScPe0accUyDuLNkNnIBCx0suJONPV6khBmwy4s2Tj5M=
X-Received: by 2002:a2e:b7d5:0:b0:26d:e725:bd35 with SMTP id
 p21-20020a2eb7d5000000b0026de725bd35mr288437ljo.69.1665078994270; Thu, 06 Oct
 2022 10:56:34 -0700 (PDT)
MIME-Version: 1.0
References: <YzeaKjmls1YI/3ox@itl-email> <01d22092-8292-8ed7-ece7-9ca32d15bbce@suse.com>
 <YzxxXuovwQt3NskE@itl-email> <a0dc1158-01b1-4272-b86e-52f4996f0747@suse.com>
 <Yz3I2qwl243h9ZfZ@itl-email> <CAMj1kXHFi71SKQAQHEjZTLyp-YooRTYZ2-nqydRZA5hys7tkKw@mail.gmail.com>
 <Yz4yLyvX6un1rrqC@itl-email> <CAMj1kXFO9_yMw=_Fn2DBGgdYXgiK_OqafG5+TbJv1UKO1uQiJQ@mail.gmail.com>
 <Yz7polT2R2OlT1aT@itl-email> <CAMj1kXGe77iwnYXWR=Hjn8eL8-1hMZbprjU8bnYaFWJnRZfdfw@mail.gmail.com>
 <Yz8O5ItPhtfpMfI2@itl-email>
In-Reply-To: <Yz8O5ItPhtfpMfI2@itl-email>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Thu, 6 Oct 2022 19:56:22 +0200
X-Gmail-Original-Message-ID: <CAMj1kXG227gm=yrMqkvgNq_TtCymW_MuTgD9+POkB9_kyyDysQ@mail.gmail.com>
Message-ID: <CAMj1kXG227gm=yrMqkvgNq_TtCymW_MuTgD9+POkB9_kyyDysQ@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] Avoid using EFI tables Xen may have clobbered
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, 
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Kees Cook <keescook@chromium.org>, 
	Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>, 
	=?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 6 Oct 2022 at 19:22, Demi Marie Obenour
<demi@invisiblethingslab.com> wrote:
>
> On Thu, Oct 06, 2022 at 06:19:35PM +0200, Ard Biesheuvel wrote:
> > On Thu, 6 Oct 2022 at 16:43, Demi Marie Obenour
> > <demi@invisiblethingslab.com> wrote:
> > >
> > > On Thu, Oct 06, 2022 at 09:31:47AM +0200, Ard Biesheuvel wrote:
> > > > On Thu, 6 Oct 2022 at 03:41, Demi Marie Obenour
> > > > <demi@invisiblethingslab.com> wrote:
> > > > >
> > > > > On Wed, Oct 05, 2022 at 11:28:29PM +0200, Ard Biesheuvel wrote:
> > > > > > On Wed, 5 Oct 2022 at 20:11, Demi Marie Obenour
> > > > > > <demi@invisiblethingslab.com> wrote:
> > > > > > >
> > > > > > > On Wed, Oct 05, 2022 at 08:15:07AM +0200, Jan Beulich wrote:
> > > > > > > > On 04.10.2022 17:46, Demi Marie Obenour wrote:
> > > > > > > > > Linux has a function called efi_mem_reserve() that is used to reserve
> > > > > > > > > EfiBootServicesData memory that contains e.g. EFI configuration tables.
> > > > > > > > > This function does not work under Xen because Xen could have already
> > > > > > > > > clobbered the memory.  efi_mem_reserve() not working is the whole reason
> > > > > > > > > for this thread, as it prevents EFI tables that are in
> > > > > > > > > EfiBootServicesData from being used under Xen.
> > > > > > > > >
> > > > > > > > > A much nicer approach would be for Xen to reserve boot services memory
> > > > > > > > > unconditionally, but provide a hypercall that dom0 could used to free
> > > > > > > > > the parts of EfiBootServicesData memory that are no longer needed.  This
> > > > > > > > > would allow efi_mem_reserve() to work normally.
> > > > > > > >
> > > > > > > > efi_mem_reserve() actually working would be a layering violation;
> > > > > > > > controlling the EFI memory map is entirely Xen's job.
> > > > > > >
> > > > > > > Doing this properly would require Xen to understand all of the EFI
> > > > > > > tables that could validly be in EfiBootServices* and which could be of
> > > > > > > interest to dom0.  It might (at least on some very buggy firmware)
> > > > > > > require a partial ACPI and/or SMBIOS implementation too, if the firmware
> > > > > > > decided to put an ACPI or SMBIOS table in EfiBootServices*.
> > > > > > >
> > > > > > > > As to the hypercall you suggest - I wouldn't mind its addition, but only
> > > > > > > > for the case when -mapbs is used. As I've indicated before, I'm of the
> > > > > > > > opinion that default behavior should be matching the intentions of the
> > > > > > > > spec, and the intention of EfiBootServices* is for the space to be
> > > > > > > > reclaimed. Plus I'm sure you realize there's a caveat with Dom0 using
> > > > > > > > that hypercall: It might use it for regions where data lives which it
> > > > > > > > wouldn't care about itself, but which an eventual kexec-ed (or alike)
> > > > > > > > entity would later want to consume. Code/data potentially usable by
> > > > > > > > _anyone_ between two resets of the system cannot legitimately be freed
> > > > > > > > (and hence imo is wrong to live in EfiBootServices* regions).
> > > > > > >
> > > > > > > I agree, but currently some such data *is* in EfiBootServices* regions,
> > > > > > > sadly.  When -mapbs is *not* used, I recommend uninstalling all of the
> > > > > > > configuration tables that point to EfiBootServicesData memory before
> > > > > > > freeing that memory.
> > > > > > >
> > > > > >
> > > > > > That seems like a reasonable approach to me. Tables like MEMATTR or
> > > > > > RT_PROP are mostly relevant for bare metal where the host kernel maps
> > > > > > the runtime services, and in general, passing on these tables without
> > > > > > knowing what they do is kind of fishy anyway. You might even argue
> > > > > > that only known table types should be forwarded in the first place,
> > > > > > regardless of the memory type.
> > > > >
> > > > > Which tables are worth handling in Xen?  I know about ACPI, SMBIOS, and
> > > > > ESRT, but I am curious which others Xen should preserve.  Currently, Xen
> > > > > does not know about RT_PROP or MEMATTR; could this be a cause of
> > > > > problems?
> > > >
> > > > dom0 only has access to paravirtualized EFI runtime services, so
> > > > consuming RT_PROP or MEMATTR should be up to Xen (they describe which
> > > > runtime services remain available at runtime, and which permission
> > > > attributes to use for the runtime services memory regions,
> > > > respectively)
> > >
> > > Xen does not do this right now.  I wonder if this could be the cause of
> > > compatibility issues with various firmware implementations.
> > >
> > > > Looking through the kernel code, I don't think there are any that dom0
> > > > should care about beyond ACPI, SMBIOS and ESRT. But as you suggest,
> > > > that means Xen should just mask them in the view of the EFI system
> > > > table it exposes so dom0. Otherwise, the kernel may still try to map
> > > > and parse them.
> > >
> > > What about the BGRT and MOKvar?  I agree that Xen should not expose the
> > > others.  Should it just hide the tables, or should it actually uninstall
> > > them?  My intuition is that the second would be technically more
> > > correct, but also more likely to trigger bugs in various firmware
> > > implementations.
> >
> > BGRT is a ACPI table not a EFI configuration table, so I'd assume it
> > is treated the same way as other ACPI tables
>
> That actually surprises me.  Xen definitely needs to know about its
> GUID, then.

It doesn't have a GUID. The table itself is a ACPI table that is
enumerated in the usual ACPI way. The problem is that the BGRT
describes a region in memory (where the OEM boot logo is), and this is
usually in EfiBootServicesData memory.

This data is typically used during early boot, to keep the logo intact
while the OS loader draws a nice animation below it. Not the end of
the world if it gets corrupted or removed.


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 17:59:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 17:59:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417216.661869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogV9m-0004rM-24; Thu, 06 Oct 2022 17:59:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417216.661869; Thu, 06 Oct 2022 17:59:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogV9l-0004rF-VM; Thu, 06 Oct 2022 17:59:37 +0000
Received: by outflank-mailman (input) for mailman id 417216;
 Thu, 06 Oct 2022 17:59:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v0w9=2H=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ogV9k-0004r4-H4
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 17:59:36 +0000
Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com
 [2a00:1450:4864:20::632])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a30e0fb4-45a0-11ed-9377-c1cf23e5d27e;
 Thu, 06 Oct 2022 19:59:35 +0200 (CEST)
Received: by mail-ej1-x632.google.com with SMTP id a2so6228764ejx.10
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 10:59:35 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 b17-20020a17090630d100b0078b03d57fa7sm45931ejb.34.2022.10.06.10.59.33
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 06 Oct 2022 10:59:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a30e0fb4-45a0-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=9C7ByqeSaw8akdMJt6lEHhq8DB9Wv7neSKwYSa568Bc=;
        b=GBm0FgVhh/SmHkKRk0VR06xZUv2s5FfWzez1BIME/djcjD8cCDknzdtn1Fzhu5g/kg
         S0nic5/R50Bm/zdW792pnzivTdOkci4ZuJd6UtTqZkWQR+bgoIeaRseAhInbl5QEe0et
         8N9tZHW6xeR/VzU5/A/FgJuS8BCAfMW2jbFDvQk6P/9FFkXYFHolvelHSX0+cC3UQHsT
         sbTIVXvPoU0hKTnRuQIheFe9SkyQKUzCkxiQfgRPn5TKhablgXDgTJotMao2Y2fAanLQ
         K2x1hQrwtmzM/aRWdW6b7HIO9mMYR5nU8rLvbd3Nhsd4eWQlW3wVo7MOTKd5tTGzY/XV
         cC1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=9C7ByqeSaw8akdMJt6lEHhq8DB9Wv7neSKwYSa568Bc=;
        b=IkXBk0jnArje+IBeMoQ5gbLJ/ylnPXtsABif8SO1/obJ9I4M+n6xacqP+mT+MPRlGk
         W7/D3YI2bC/WUh+6EBQWySEW+6HyCVcfCqkCBZcCiYD5aDt2jfiIGOHXYM/0uIDN0juz
         OOm8vvBMCfEzxN2ibfe2DSd+FasUCt+DaLIWzcCh9ygoTT+R3ITgw8YjT/BZ64ONSSEI
         LubWGVX2PELvI0doYTX+kCIgW0S4OD39tIZEaA/z0dgVeEsM228Pk2ifN8u5MxZRxKmp
         ZO+ea8FwiCddjXsDxkrvGLiGY2grf/NQNL/VucaNyaV+kxYBByp9cyCyoVqHUfAQxY2T
         6NMg==
X-Gm-Message-State: ACrzQf18VRh+c6APsU36xAA6SB6EXHa0hA16y/4KBCbN1NsT/NxiijBg
	rmDBNUZrd8SaecIcfvAN2Ac=
X-Google-Smtp-Source: AMsMyM5kuaauO1vW4syhZvX2RO/dfucMb6YYgUT3lLJ4eHvtA3RTG8amKMunPAeu3qoE1ar1WyyYcA==
X-Received: by 2002:a17:907:8a0a:b0:78d:2ecb:63e6 with SMTP id sc10-20020a1709078a0a00b0078d2ecb63e6mr919611ejc.620.1665079174812;
        Thu, 06 Oct 2022 10:59:34 -0700 (PDT)
Message-ID: <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
Date: Thu, 6 Oct 2022 20:59:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221006120912.1948459-1-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/6/22 15:09, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Although XEN_PAGE_SIZE is equal to PAGE_SIZE (4KB) for now, it would
> be more correct to use Xen specific #define-s as XEN_PAGE_SIZE can
> be changed at some point in the future.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> As it was proposed at:
> https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/
> 
> Should go in only after that series.
> ---
>   drivers/xen/grant-dma-ops.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index c66f56d24013..5392fdc25dca 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
>   
>   static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>   {
> -	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
> +	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << XEN_PAGE_SHIFT);
>   }

With this change, can the offset added to the dma handle, generated by 
grant_to_dma(), be the offset in the page? Couldn't it corrupt the grant 
ref?

>   
>   static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>   {
> -	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
> +	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> XEN_PAGE_SHIFT);
>   }
>   
>   static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
> @@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>   				 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = XEN_PFN_UP(size);
>   	unsigned long pfn;
>   	grant_ref_t grant;
>   	void *ret;
> @@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>   	if (unlikely(data->broken))
>   		return NULL;
>   
> -	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
> +	ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
>   	if (!ret)
>   		return NULL;
>   
>   	pfn = virt_to_pfn(ret);
>   
>   	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
> -		free_pages_exact(ret, n_pages * PAGE_SIZE);
> +		free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
>   		return NULL;
>   	}
>   
> @@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
>   			       dma_addr_t dma_handle, unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = XEN_PFN_UP(size);
>   	grant_ref_t grant;
>   
>   	data = find_xen_grant_dma_data(dev);
> @@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
>   
>   	gnttab_free_grant_reference_seq(grant, n_pages);
>   
> -	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
> +	free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
>   }
>   
>   static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
> @@ -168,7 +168,7 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   					 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned int i, n_pages = XEN_PFN_UP(offset + size);

The offset, here, refers to the offset in the page ...

>   	grant_ref_t grant;
>   	dma_addr_t dma_handle;
>   
> @@ -200,8 +200,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>   				     unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned long offset = dma_handle & ~XEN_PAGE_MASK;

... while, here, it refers to the offset in the grant.
So, the calculated number of grants may differ.

> +	unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>   	grant_ref_t grant;
>   
>   	if (WARN_ON(dir == DMA_NONE))

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 18:49:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 18:49:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417224.661883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogVvW-0001oB-Oi; Thu, 06 Oct 2022 18:48:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417224.661883; Thu, 06 Oct 2022 18:48:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogVvW-0001o4-KF; Thu, 06 Oct 2022 18:48:58 +0000
Received: by outflank-mailman (input) for mailman id 417224;
 Thu, 06 Oct 2022 18:48:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogVvW-0001nu-7i; Thu, 06 Oct 2022 18:48:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogVvW-0003it-2X; Thu, 06 Oct 2022 18:48:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogVvV-0005p9-HO; Thu, 06 Oct 2022 18:48:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogVvV-0006op-Gv; Thu, 06 Oct 2022 18:48:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vy+RTcrMMx/txdfHO49up1ItK4445l4FQI7QPpJ9gxg=; b=EQp7fLA5Kea5jV7Zt5VqnepvKf
	Hlmy4/jAf6Fdmaqa9nDgRFNzR/LqJRfV31K+n4xFiWFOuY5r9p1hBb5ZLQ6QTvPiSGd8swu2GbhqI
	B9B+KLptI/DR1vFMBlhvStCfNJg0ow+LIHWw92mtyYlOXKCZBVdo2zt4dTJTD1T8o62w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173439-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173439: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f28b7414ab715e6069e72a7bbe2f1354b2524beb
X-Osstest-Versions-That:
    linux=6215647d9699cb8f1bf7333ec849242c4a9cf9a6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 18:48:57 +0000

flight 173439 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173439/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 173353
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173433 REGR. vs. 173353

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 173433 pass in 173439
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail in 173433 pass in 173439
 test-armhf-armhf-xl-rtds     14 guest-start      fail in 173433 pass in 173439
 test-armhf-armhf-xl-credit1  14 guest-start                fail pass in 173433
 test-armhf-armhf-xl-multivcpu 14 guest-start               fail pass in 173433
 test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10    fail pass in 173433
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173433

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173353
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 173433 like 173353
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173433 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173433 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173433 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173433 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173353
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173353
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173353
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173353
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f28b7414ab715e6069e72a7bbe2f1354b2524beb
baseline version:
 linux                6215647d9699cb8f1bf7333ec849242c4a9cf9a6

Last test of basis   173353  2022-09-28 09:15:02 Z    8 days
Testing same since   173427  2022-10-05 08:44:11 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Alistair Popple <apopple@nvidia.com>
  Andrew Morton <akpm@linux-foundation.org>
  Arnd Bergmann <arnd@arndb.de>
  Bjørn Mork <bjorn@mork.no>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <caihuoqing@baidu.com>
  Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christoph Hellwig <hch@lst.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Hildenbrand <david@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Fabio Estevam <festevam@denx.de>
  Faiz Abbas <faiz_abbas@ti.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Han Xu <han.xu@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heiko Stuebner <heiko@sntech.de>
  Hongling Zeng <zenghongling@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Michael Kelley <mikelley@microsoft.com>
  Michal Hocko <mhocko@suse.com>
  Minchan Kim <minchan@kernel.org>
  Niklas Cassel <niklas.cassel@wdc.com>
  Paolo Abeni <pabeni@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Xu <peterx@redhat.com>
  Rafał Miłecki <rafal@milecki.pl>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sergei Antonov <saproj@gmail.com>
  Stephen Boyd <sboyd@kernel.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Tony Lindgren <tony@atomide.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Wang Yufen <wangyufen@huawei.com>
  Yang Shi <shy828301@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  YuTong Chang <mtwget@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 919 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 19:49:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 19:49:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417274.661912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogWs1-0000uD-MO; Thu, 06 Oct 2022 19:49:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417274.661912; Thu, 06 Oct 2022 19:49:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogWs1-0000u6-Jm; Thu, 06 Oct 2022 19:49:25 +0000
Received: by outflank-mailman (input) for mailman id 417274;
 Thu, 06 Oct 2022 19:49:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogWs0-0000tw-3h; Thu, 06 Oct 2022 19:49:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogWs0-0004nJ-0a; Thu, 06 Oct 2022 19:49:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogWrz-0007Ym-Lw; Thu, 06 Oct 2022 19:49:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogWrz-0002k7-IL; Thu, 06 Oct 2022 19:49:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8AvseTXkShOmSmTKM0OHWd5B/9AkPoaYbE0DOaa0hOc=; b=Cmz+R83oKYLUuaSKNOnX9yFYiI
	Pdab1bTZPgvlgk3BQg8wAzfTQtHw8pBIcg4M6Vfh0xX7Ji7dji10ftjq7qY9dl2OW2b91TJX49U3A
	j3P9l4JgPwLHkKgZ7FgLXxhNHNx3Pm+hK8C5gaJ21e0t1j8lDUCGVFSrrGg4ziCwWOr0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173449-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173449: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=5ff7d712d489a4fba4e8b0f609218e33c1208e52
X-Osstest-Versions-That:
    ovmf=710f83b79d6eab641401c054b2f40f6c630f8cd5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 19:49:23 +0000

flight 173449 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173449/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 5ff7d712d489a4fba4e8b0f609218e33c1208e52
baseline version:
 ovmf                 710f83b79d6eab641401c054b2f40f6c630f8cd5

Last test of basis   173437  2022-10-06 02:10:29 Z    0 days
Testing same since   173449  2022-10-06 17:40:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jeff Brasen <jbrasen@nvidia.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   710f83b79d..5ff7d712d4  5ff7d712d489a4fba4e8b0f609218e33c1208e52 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 21:01:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 21:01:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417284.661923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogXzs-0000db-1q; Thu, 06 Oct 2022 21:01:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417284.661923; Thu, 06 Oct 2022 21:01:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogXzr-0000dU-US; Thu, 06 Oct 2022 21:01:35 +0000
Received: by outflank-mailman (input) for mailman id 417284;
 Thu, 06 Oct 2022 21:01:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogXzq-0000dK-MQ; Thu, 06 Oct 2022 21:01:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogXzq-0006AA-HT; Thu, 06 Oct 2022 21:01:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogXzp-0004Jt-VR; Thu, 06 Oct 2022 21:01:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogXzp-0002tW-Uz; Thu, 06 Oct 2022 21:01:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2BO4XL1AEd7Xf3YI6dKPrZFS1+Loq2sZs/o1TMIJGDU=; b=Oc6ePshR7iWeFpkYFBbHEP/EpZ
	Q/9i1bkYs5Ko3OXyKti8TMHhnlBXLxtyZ2Yi4zK49HEHZ7bQVLxXJ2AbiIv6iUtBALKO4m9SkUsVp
	VfYi1HZJhUE8NxDGR6nS1KdPgJCseQcrEFWAcSsFx2AL4XViKT3p5nVhApfpBHgk/FZw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173442-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173442: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=833477fce7a14d43ae4c07f8ddc32fa5119471a2
X-Osstest-Versions-That:
    linux=2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 06 Oct 2022 21:01:33 +0000

flight 173442 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173442/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173426

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173426
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173426
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173426
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173426
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173426
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                833477fce7a14d43ae4c07f8ddc32fa5119471a2
baseline version:
 linux                2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf

Last test of basis   173426  2022-10-05 08:41:36 Z    1 days
Failing since        173434  2022-10-05 18:41:59 Z    1 days    2 attempts
Testing same since   173442  2022-10-06 07:53:50 Z    0 days    1 attempts

------------------------------------------------------------
475 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2bca25eaeba6..833477fce7a1  833477fce7a14d43ae4c07f8ddc32fa5119471a2 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 21:13:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 21:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417293.661933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogYBS-0002AZ-47; Thu, 06 Oct 2022 21:13:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417293.661933; Thu, 06 Oct 2022 21:13:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogYBS-0002AS-1R; Thu, 06 Oct 2022 21:13:34 +0000
Received: by outflank-mailman (input) for mailman id 417293;
 Thu, 06 Oct 2022 21:13:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=M1JS=2H=epam.com=prvs=22784c7a74=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ogYBP-0002AM-QM
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 21:13:32 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8d95898-45bb-11ed-964a-05401a9f4f97;
 Thu, 06 Oct 2022 23:13:29 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296KQObi028393;
 Thu, 6 Oct 2022 21:13:24 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb1h54-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 06 Oct 2022 21:13:24 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS4PR03MB8674.eurprd03.prod.outlook.com (2603:10a6:20b:58a::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Thu, 6 Oct
 2022 21:13:20 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Thu, 6 Oct 2022
 21:13:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8d95898-45bb-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jokl+Lub3YypAa8pyocSibZ0aqychExVx+/9yxOX+QyDbkbwhPdEsjGNAXKkehQRmBOKEbUbvcHCKX5yAZtC8I/ISISay81ng9qBRD37dlMp3CE/id6DFYZ4ixnqc/ghnVzJTqVy+K98YEbxTvRKp9VV2Jbab7xjWMGnpd3szTPBO7JgdrnWQ+ppCKa9AxZlgG7pukSugFneGWIGUNhmwNkg09lmLFkXPoWl9TkR5rmEws3KLlAqpxmUsHIKZTEBg0gzywddP3k0WfL4fwXPbXfECrJhh3YgpnRiD0HnoE4S9us7UEoA72aoPGg0DyAWTBxFFToGSVlYsfUcch2Usg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oOAYTiF6yVTllsbBaDjAWpmZSozioT+tvv9trCPiaNY=;
 b=WBEXI93BX1kJYcZ4sult3Aw9S9H+N+xewqK5sNvfsZ66f+h3Fx6sDbaUpN6VhHg7yZYo7Sz7KVznYa86JvTn1aLbPYmic2XL6kpOnfaIh17htWgTdzyQCGMYFOGSX/LcpQ1atDXVXJfHW9aQBefc/OUlfroORAZocTgYojWE/d3Duv2s+aT6VKS/YLuPifXm480+TvkN3pyfx9TY+cCvbOX8Z1Dja2psTNm9KUwIvbkWtPzNS+flPJmmbUxx3F8z0McsPfEoT2Qpg5j8/uDe6qstYobsVDVaj9RDz53gpKhUa5CQt424cUGj4tF9sCIIrdOg6CXTlr5D4Z1PQEpXZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oOAYTiF6yVTllsbBaDjAWpmZSozioT+tvv9trCPiaNY=;
 b=VQpt6SFFWFXsQhB1vKEt+ojCoIcHdaZXPgZOfJGnlaJrDXtiJYcn7E7/GBI6vgHFIqo7cx+8qE1uQZJ6Q1Z3tutPMpkDOldl7tMolhmXQ+TBGAyCxFApN/eX1pEqO0b+fi0V2CyfCa8ziig6gdNDIYXmTdQwCjBoiin/Bn/SevjZXyU1ibKGdLVAqJw1b9gSXv/cUHZfv4qcRixpTnKqYSAyMiE8I3PsHUuKcPFTRg/UhFlVleMpdOyexQz3pbkBiZVow8k3a+vn1NnKfBVW0aQZiWmgC0MfxmZFaa8w32GeZOQjaYNGDhb9sLeVB8wDHTyOrsD6JW8cnXo1dipZgw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Topic: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Index: AQHY2Xx9ME9woenUJk6IqJF2QACToq4Bp86AgAA2I4A=
Date: Thu, 6 Oct 2022 21:13:20 +0000
Message-ID: <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
In-Reply-To: <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS4PR03MB8674:EE_
x-ms-office365-filtering-correlation-id: 42d88c83-0efd-4e76-afbb-08daa7df985e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 9mQ7CMP7pimJTHID0igefuMjXr2K76yCvNS/9fk4vYPLhUY5mBehIdI6TlErWiAotNiAbMYBbem+vXx/yrdjbvRp5YPu093co3+lJZGGuMjVS8UAWKpBFf6es1AIILf2d2ssfITvmW7dNq5+1bMlq1cz7rb9ZZrgeu+w4AweXpk+NYGDeCfxP72tZ3hqx1fiXlPuiHMgq5p3BCPqBoR+xguTiJaktstmxMLfMkBIyf4kh7xWXSj8cO24CmcEh/rhE5fcgDSrCkL9oU/dpSErsA/3TvhDTJKH4Dh95D0k91ICbfDdOxe3vkl1eZcXh1vSdqVBVLhvs56rvdW67csL0wZjhuyH/EFUzyAa0g4GQpsESbT3JVRKtDLa4WihCGpvZBcYVOkU9c0SQ7J0QmWNvzhKjAHcEIwoY43zrUJXARGXkT+hr55LA1ogYQ0hCjsYEPFI+a0o89zIn2x5hJVroPD3GdVD0+u8AeM9ISiUtqmT47TW8N9flGjOFHTSA870Le8mSv1QB37w4Wus1VclCN0pFFzf45EyBBKmh/b1Edft9hVIXcUrrrzPVnGIbb3BIqYkYTUtYE9V9rDE/Ur+92ewp/rIQsYrGwu4Rj/oP/hd/EEPzD4qyOqIbut0C+7NywjORHnDKTDAVzt8RFIYhBp0EO2868uvZEEqSgQ9BDV37ZC6U7lnd2Ob83gJZeOOGCD1HFacNjfUu7+n7ZWsqgcorDMcHfhSfsCm7JWnXjpUbfK6g+71ub4vhx2VA6xqbuQDkUrIx9JKyUpvovR4ydIAFQ7L10IjE9owqe9sKrzvpJI9O9WUswkRhQ3CRbNv0X530d+OiNWIvzEWWidKZQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(451199015)(41300700001)(38070700005)(53546011)(122000001)(5660300002)(8936002)(966005)(6486002)(186003)(478600001)(2616005)(31696002)(86362001)(26005)(55236004)(6506007)(6512007)(66476007)(71200400001)(76116006)(64756008)(4326008)(316002)(36756003)(8676002)(54906003)(66446008)(110136005)(83380400001)(66946007)(91956017)(31686004)(66556008)(2906002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?K1RML0QxUko1S0xyZzJsNWU1clFEM2JuMUswYng0V09Xc2Z4RUZ0RWJWUFR6?=
 =?utf-8?B?ZlBQTEozOHJDS1pBQk1naW9US2p5V1l4WHl6eVZSTTlWVERRejJxa3hjT3JO?=
 =?utf-8?B?RytpVGE0TE9HdENwRzJvWTQ4TS9PS1lJV3RFeWdqZ2xIdzVDVjlkZmNaTjB1?=
 =?utf-8?B?dXU3UDN5Z2dadDFqVWxZMVFkVmxPeE9hNzhkdDVmOEJHNHVyOWowb0ViMW9O?=
 =?utf-8?B?N3BUdmZqNWE0bnYwWXlsUjlibFZtRTZKbm5Qd3VQaEtvV2ZwWkI4Wm9QcWRK?=
 =?utf-8?B?MExCN2JZdXFhYkc1bW9jbER3ZnllZHVOVTVobGJ2NjlWZFNpUzZqd2I1c24x?=
 =?utf-8?B?WlM5MW1Wb2UrNWJlWVdLSjBJUVU3RFI3MkpZSFV1eXVEbGZIdCtzNHpOa1oy?=
 =?utf-8?B?OXkrTEh6MVZENVdlSFNzWUlPaWxXK2gzSjd4TFFHcUdoVlJ0cUdwNENNQW5T?=
 =?utf-8?B?U0llbGVrbWVWTzAyR1QyT3llaldoQkpJdDFjMzQvdWkrQVNiQS9lWC9lc0JS?=
 =?utf-8?B?QnVQd0dTaER4QU0vQzZ0cmQyNzFaNG13MTdiS3lSVmtjT3dla1BEZHBpdks1?=
 =?utf-8?B?dVFueWFFeW1RekNGN2dKVEN4VCtYSlFKUVYzQVRac1VsY1J3L2xycWNpSFVM?=
 =?utf-8?B?dFc2NHI4VzlrT0lIcEVqSzg4TEFlUHFvVDdhVUcxZ0hCN2laRTBQRnd3LzY0?=
 =?utf-8?B?SUVNdEd0MlhBT3ZSV21YUzBISjR4cTkybEo1VXA3MjFqeXcwckhpUGUxejFo?=
 =?utf-8?B?NWNweWZUUXhDTGdPbkRnYWMwRWNtMjZrSGpFSUVUTUgvWkdhVkRDdGg0MTl2?=
 =?utf-8?B?dFVYREJ6bXpHdVBOVHBvU0xpQ1pxSGp3SFhaaXlJVGc1aHRJblJqYm4yVUJL?=
 =?utf-8?B?a2l4eHZIRnpibWNPOTVDVTBqZnU3WDhDaWFrOUxsd1FSY0NIN3g4UWFoMHBj?=
 =?utf-8?B?QzdEcDAzUk82RUw2aWh4OSsyb1lXQmNjNXNzQXg2NEg5N2Y4VEdZY1ZXWlRk?=
 =?utf-8?B?SXpIQ1NKN3FoeEZsUU1MK0xteTljV0x5bzNYZ0pFQitlWXJ0U2hFeWJ4eWNU?=
 =?utf-8?B?Nm9iSGJ5ZFhTU01QUm0vbmg2K0g1eUhVZktDL0EzTkc0aFlSUDZ5TllteGRy?=
 =?utf-8?B?VDl2ZkVveVVvYnpSUUNqVjI5bkN2TWErMTU1RVFwNE9tQUJDS2prY1IyQTBN?=
 =?utf-8?B?SG5QTDRKTFoyMmxmZWNmQ0ZRajRTZlVZTktieVQ3MDZxOEtaa3RyWEtkMVdq?=
 =?utf-8?B?QmJ2ZjRBSEU1Uzh3YVNaMUFPR0NUdldPYlNWMEg1WDh2Sy9MNHRiVE52aEVu?=
 =?utf-8?B?VHU3SjcyZ2VQMGY0QjhTbEpMR3c4MlRoK1Y1YTN3N1RJR0ppSTNST0Roekpq?=
 =?utf-8?B?SGVHT1RuUlF3K05melpMZ0o0TjFKTFZXZUxTUzE5aDdpOVpzeWR5SmZVaW1I?=
 =?utf-8?B?UnpUKzJGUHVnRUoxdyt2YVgweWxJOXpjOHM0QzZ6dFBESFpjVUJsbjRMcGND?=
 =?utf-8?B?M3Aya1ltdGt1SWRTbkV5cWZFc0p5QlhIQmZacmZhZTZWVmlncFIvRGdJbUxI?=
 =?utf-8?B?T29kaSszMXJER2VIZWIxMGNmZ3JOVmIzMUdWYjlZRStKMlRmM2FvY0IwaEYr?=
 =?utf-8?B?bDNwU0MvcHhvam93TnVIUURud29wRE9YNWd2dDZIZWJZamJ2bnA0RlNJQVJi?=
 =?utf-8?B?Y0JFN21BNW1MMldkcUVEM3V5OEQvQTI2Z1J6dUhNN3VGR1dVVSs1OHc5TmZk?=
 =?utf-8?B?a0JFQW5QWUNHRWx0N3VrR3lhNmpaZUJYdlBtQWhVSkZRTG9vdUpSRkg3Y0Er?=
 =?utf-8?B?aHJGeEVBazJuUmI4VnVPZlVvNkJOMXgwdWR1OURyN2d2V2FFZldBRGNPRXVT?=
 =?utf-8?B?V2lwSW5QRDFHdHc3QnJWbi8wL0dXMUtsNVdzaXAycDF2MWRwRGFpQ2pCZmh3?=
 =?utf-8?B?UWhwUTlFc1pTalFNTlROTmZuTEJEVFdIOGZPUGQ1ZWtkZVBMZzNXUU5vSzNS?=
 =?utf-8?B?YjdwS2xqMDdaY2dmZ3crVk8yZFV4azF4WVN0Z0tvTTZEaG9hbTZxc3lZQnBV?=
 =?utf-8?B?VW52WWtkcU02UjluYTVBeXR0RXpHbnNWT002Rkk5b0c4SXpaVllEUmFOWksr?=
 =?utf-8?B?U1UvRjNHZHZ0U09FK3JSVjdkV25oV0hoN1JDT21FQkF1ZWFjaTByT2cxZC95?=
 =?utf-8?Q?mivthaEjtnX1RYLxYcLym0Q=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5B352496786BFB4B9CE701AD68570EB3@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42d88c83-0efd-4e76-afbb-08daa7df985e
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 21:13:20.2078
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XPy+OAxemuIyy9NAWSLwZMgXGgtv4X47BuTa9Tn/OWTkd04lAOiMbhSPZ5ha8Wol7UvnyK2dRd97XeGajjK2L8DMCbCjcrX0yCAqV48WKa8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR03MB8674
X-Proofpoint-ORIG-GUID: DqQ1h4eFnyrVLurkTH7uQZMGnmdzatT8
X-Proofpoint-GUID: DqQ1h4eFnyrVLurkTH7uQZMGnmdzatT8
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_04,2022-10-06_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1011 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210060126

DQpPbiAwNi4xMC4yMiAyMDo1OSwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KSGVsbG8gWGVu
aWENCg0KPg0KPiBPbiAxMC82LzIyIDE1OjA5LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFt
LmNvbT4NCj4+DQo+PiBBbHRob3VnaCBYRU5fUEFHRV9TSVpFIGlzIGVxdWFsIHRvIFBBR0VfU0la
RSAoNEtCKSBmb3Igbm93LCBpdCB3b3VsZA0KPj4gYmUgbW9yZSBjb3JyZWN0IHRvIHVzZSBYZW4g
c3BlY2lmaWMgI2RlZmluZS1zIGFzIFhFTl9QQUdFX1NJWkUgY2FuDQo+PiBiZSBjaGFuZ2VkIGF0
IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+
IENjOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiBDYzogWGVuaWEgUmFnaWFk
YWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29tPg0KPj4NCj4+IEFzIGl0IHdhcyBwcm9wb3NlZCBh
dDoNCj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2xvcmUua2VybmVsLm9y
Zy94ZW4tZGV2ZWwvMjAyMjEwMDUxNzQ4MjMuMTgwMDc2MS0xLW9sZWtzdHlzaEBnbWFpbC5jb20v
X187ISFHRl8yOWRiY1FJVUJQQSF6SHQteFpfN3RaY19FTTZ6dmEyMUVfWWd3SWlFZWltRldmc0pJ
cFB3QXUtVEJjbnpRaFhIcWxLem1YbXdJY0k2dUl4X2FySE5aaWFaZUh0XzQyOF84cC1EeU1wZCQg
DQo+PiBbbG9yZVsuXWtlcm5lbFsuXW9yZ10NCj4+DQo+PiBTaG91bGQgZ28gaW4gb25seSBhZnRl
ciB0aGF0IHNlcmllcy4NCj4+IC0tLQ0KPj4gwqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5j
IHwgMjAgKysrKysrKysrKy0tLS0tLS0tLS0NCj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNl
cnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94
ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBpbmRl
eCBjNjZmNTZkMjQwMTMuLjUzOTJmZGMyNWRjYSAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMveGVu
L2dyYW50LWRtYS1vcHMuYw0KPj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+
PiBAQCAtMzEsMTIgKzMxLDEyIEBAIHN0YXRpYyBERUZJTkVfWEFSUkFZX0ZMQUdTKHhlbl9ncmFu
dF9kbWFfZGV2aWNlcywgDQo+PiBYQV9GTEFHU19MT0NLX0lSUSk7DQo+PiDCoCDCoCBzdGF0aWMg
aW5saW5lIGRtYV9hZGRyX3QgZ3JhbnRfdG9fZG1hKGdyYW50X3JlZl90IGdyYW50KQ0KPj4gwqAg
ew0KPj4gLcKgwqDCoCByZXR1cm4gWEVOX0dSQU5UX0RNQV9BRERSX09GRiB8ICgoZG1hX2FkZHJf
dClncmFudCA8PCBQQUdFX1NISUZUKTsNCj4+ICvCoMKgwqAgcmV0dXJuIFhFTl9HUkFOVF9ETUFf
QUREUl9PRkYgfCAoKGRtYV9hZGRyX3QpZ3JhbnQgPDwgDQo+PiBYRU5fUEFHRV9TSElGVCk7DQo+
PiDCoCB9DQo+DQo+IFdpdGggdGhpcyBjaGFuZ2UsIGNhbiB0aGUgb2Zmc2V0IGFkZGVkIHRvIHRo
ZSBkbWEgaGFuZGxlLCBnZW5lcmF0ZWQgYnkgDQo+IGdyYW50X3RvX2RtYSgpLCBiZSB0aGUgb2Zm
c2V0IGluIHRoZSBwYWdlPyBDb3VsZG4ndCBpdCBjb3JydXB0IHRoZSANCj4gZ3JhbnQgcmVmPw0K
DQoNCkdvb2QgcG9pbnQsIGluZGVlZCwgSSB0aGluayBpdCBjb3VsZCBjb3JydXB0IGlmIGd1ZXN0
IHVzZXMgYSBkaWZmZXJlbnQgDQp0aGFuIFhlbiBwYWdlIGdyYW51bGFyaXR5IChpLmUgNjRLQiku
DQoNCg0KPg0KPj4gwqAgwqAgc3RhdGljIGlubGluZSBncmFudF9yZWZfdCBkbWFfdG9fZ3JhbnQo
ZG1hX2FkZHJfdCBkbWEpDQo+PiDCoCB7DQo+PiAtwqDCoMKgIHJldHVybiAoZ3JhbnRfcmVmX3Qp
KChkbWEgJiB+WEVOX0dSQU5UX0RNQV9BRERSX09GRikgPj4gDQo+PiBQQUdFX1NISUZUKTsNCj4+
ICvCoMKgwqAgcmV0dXJuIChncmFudF9yZWZfdCkoKGRtYSAmIH5YRU5fR1JBTlRfRE1BX0FERFJf
T0ZGKSA+PiANCj4+IFhFTl9QQUdFX1NISUZUKTsNCj4+IMKgIH0NCj4+IMKgIMKgIHN0YXRpYyBz
dHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShzdHJ1Y3Qg
DQo+PiBkZXZpY2UgKmRldikNCj4+IEBAIC03OSw3ICs3OSw3IEBAIHN0YXRpYyB2b2lkICp4ZW5f
Z3JhbnRfZG1hX2FsbG9jKHN0cnVjdCBkZXZpY2UgDQo+PiAqZGV2LCBzaXplX3Qgc2l6ZSwNCj4+
IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGF0dHJz
KQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRh
Ow0KPj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFBGTl9VUChzaXplKTsNCj4+
ICvCoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQKHNpemUpOw0KPj4g
wqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHBmbjsNCj4+IMKgwqDCoMKgwqAgZ3JhbnRfcmVmX3Qg
Z3JhbnQ7DQo+PiDCoMKgwqDCoMKgIHZvaWQgKnJldDsNCj4+IEBAIC05MSwxNCArOTEsMTQgQEAg
c3RhdGljIHZvaWQgKnhlbl9ncmFudF9kbWFfYWxsb2Moc3RydWN0IGRldmljZSANCj4+ICpkZXYs
IHNpemVfdCBzaXplLA0KPj4gwqDCoMKgwqDCoCBpZiAodW5saWtlbHkoZGF0YS0+YnJva2VuKSkN
Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gTlVMTDsNCj4+IMKgIC3CoMKgwqAgcmV0ID0g
YWxsb2NfcGFnZXNfZXhhY3Qobl9wYWdlcyAqIFBBR0VfU0laRSwgZ2ZwKTsNCj4+ICvCoMKgwqAg
cmV0ID0gYWxsb2NfcGFnZXNfZXhhY3Qobl9wYWdlcyAqIFhFTl9QQUdFX1NJWkUsIGdmcCk7DQo+
PiDCoMKgwqDCoMKgIGlmICghcmV0KQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxM
Ow0KPj4gwqAgwqDCoMKgwqDCoCBwZm4gPSB2aXJ0X3RvX3BmbihyZXQpOw0KPj4gwqAgwqDCoMKg
wqDCoCBpZiAoZ250dGFiX2FsbG9jX2dyYW50X3JlZmVyZW5jZV9zZXEobl9wYWdlcywgJmdyYW50
KSkgew0KPj4gLcKgwqDCoMKgwqDCoMKgIGZyZWVfcGFnZXNfZXhhY3QocmV0LCBuX3BhZ2VzICog
UEFHRV9TSVpFKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHJldCwgbl9w
YWdlcyAqIFhFTl9QQUdFX1NJWkUpOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxM
Ow0KPj4gwqDCoMKgwqDCoCB9DQo+PiDCoCBAQCAtMTE2LDcgKzExNiw3IEBAIHN0YXRpYyB2b2lk
IHhlbl9ncmFudF9kbWFfZnJlZShzdHJ1Y3QgZGV2aWNlIA0KPj4gKmRldiwgc2l6ZV90IHNpemUs
IHZvaWQgKnZhZGRyLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBkbWFfYWRkcl90IGRtYV9oYW5kbGUsIHVuc2lnbmVkIGxvbmcgYXR0cnMpDQo+PiDCoCB7DQo+
PiDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+PiAtwqDCoMKg
IHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gUEZOX1VQKHNpemUpOw0KPj4gK8KgwqDCoCB1bnNp
Z25lZCBpbnQgaSwgbl9wYWdlcyA9IFhFTl9QRk5fVVAoc2l6ZSk7DQo+PiDCoMKgwqDCoMKgIGdy
YW50X3JlZl90IGdyYW50Ow0KPj4gwqAgwqDCoMKgwqDCoCBkYXRhID0gZmluZF94ZW5fZ3JhbnRf
ZG1hX2RhdGEoZGV2KTsNCj4+IEBAIC0xMzgsNyArMTM4LDcgQEAgc3RhdGljIHZvaWQgeGVuX2dy
YW50X2RtYV9mcmVlKHN0cnVjdCBkZXZpY2UgDQo+PiAqZGV2LCBzaXplX3Qgc2l6ZSwgdm9pZCAq
dmFkZHIsDQo+PiDCoCDCoMKgwqDCoMKgIGdudHRhYl9mcmVlX2dyYW50X3JlZmVyZW5jZV9zZXEo
Z3JhbnQsIG5fcGFnZXMpOw0KPj4gwqAgLcKgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHZhZGRyLCBu
X3BhZ2VzICogUEFHRV9TSVpFKTsNCj4+ICvCoMKgwqAgZnJlZV9wYWdlc19leGFjdCh2YWRkciwg
bl9wYWdlcyAqIFhFTl9QQUdFX1NJWkUpOw0KPj4gwqAgfQ0KPj4gwqAgwqAgc3RhdGljIHN0cnVj
dCBwYWdlICp4ZW5fZ3JhbnRfZG1hX2FsbG9jX3BhZ2VzKHN0cnVjdCBkZXZpY2UgKmRldiwgDQo+
PiBzaXplX3Qgc2l6ZSwNCj4+IEBAIC0xNjgsNyArMTY4LDcgQEAgc3RhdGljIGRtYV9hZGRyX3Qg
eGVuX2dyYW50X2RtYV9tYXBfcGFnZShzdHJ1Y3QgDQo+PiBkZXZpY2UgKmRldiwgc3RydWN0IHBh
Z2UgKnBhZ2UsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCB1bnNpZ25lZCBsb25nIGF0dHJzKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgeGVu
X2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdl
cyA9IFBGTl9VUChvZmZzZXQgKyBzaXplKTsNCj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGksIG5f
cGFnZXMgPSBYRU5fUEZOX1VQKG9mZnNldCArIHNpemUpOw0KPg0KPiBUaGUgb2Zmc2V0LCBoZXJl
LCByZWZlcnMgdG8gdGhlIG9mZnNldCBpbiB0aGUgcGFnZSAuLi4NCj4NCj4+IMKgwqDCoMKgwqAg
Z3JhbnRfcmVmX3QgZ3JhbnQ7DQo+PiDCoMKgwqDCoMKgIGRtYV9hZGRyX3QgZG1hX2hhbmRsZTsN
Cj4+IMKgIEBAIC0yMDAsOCArMjAwLDggQEAgc3RhdGljIHZvaWQgeGVuX2dyYW50X2RtYV91bm1h
cF9wYWdlKHN0cnVjdCANCj4+IGRldmljZSAqZGV2LCBkbWFfYWRkcl90IGRtYV9oYW5kbGUsDQo+
PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBs
b25nIGF0dHJzKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9k
YXRhICpkYXRhOw0KPj4gLcKgwqDCoCB1bnNpZ25lZCBsb25nIG9mZnNldCA9IGRtYV9oYW5kbGUg
JiAoUEFHRV9TSVpFIC0gMSk7DQo+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0g
UEZOX1VQKG9mZnNldCArIHNpemUpOw0KPj4gK8KgwqDCoCB1bnNpZ25lZCBsb25nIG9mZnNldCA9
IGRtYV9oYW5kbGUgJiB+WEVOX1BBR0VfTUFTSzsNCj4NCj4gLi4uIHdoaWxlLCBoZXJlLCBpdCBy
ZWZlcnMgdG8gdGhlIG9mZnNldCBpbiB0aGUgZ3JhbnQuDQo+IFNvLCB0aGUgY2FsY3VsYXRlZCBu
dW1iZXIgb2YgZ3JhbnRzIG1heSBkaWZmZXIuDQoNCkdvb2QgcG9pbnQsIEkgdGhpbmsgeW91IGFy
ZSByaWdodCwgc28gd2UgbmVlZCB0byBhZGRpdGlvbmFsbHkgdXNlIA0KeGVuX29mZnNldF9pbl9w
YWdlKCkgbWFjcm8gaW4geGVuX2dyYW50X2RtYV9tYXBfcGFnZSgpLA0KDQpzb21ldGhpbmcgbGlr
ZSB0aGF0IHRvIGJlIHNxdWFzaGVkIHdpdGggY3VycmVudCBwYXRjaDoNCg0KDQpkaWZmIC0tZ2l0
IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9w
cy5jDQppbmRleCA5ZDVlY2E2ZDYzOGEuLmJiOTg0ZGMwNWRlYiAxMDA2NDQNCi0tLSBhL2RyaXZl
cnMveGVuL2dyYW50LWRtYS1vcHMuYw0KKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5j
DQpAQCAtMTY5LDcgKzE2OSw3IEBAIHN0YXRpYyBkbWFfYWRkcl90IHhlbl9ncmFudF9kbWFfbWFw
X3BhZ2Uoc3RydWN0IA0KZGV2aWNlICpkZXYsIHN0cnVjdCBwYWdlICpwYWdlLA0KIMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgYXR0cnMpDQogwqB7DQogwqDCoMKgwqDCoMKg
wqAgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YTsNCi3CoMKgwqDCoMKgwqAgdW5zaWdu
ZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQKG9mZnNldCArIHNpemUpOw0KK8KgwqDCoMKg
wqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFhFTl9QRk5fVVAoeGVuX29mZnNldF9pbl9w
YWdlKG9mZnNldCkgDQorIHNpemUpOw0KIMKgwqDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdyYW50
Ow0KIMKgwqDCoMKgwqDCoMKgIGRtYV9hZGRyX3QgZG1hX2hhbmRsZTsNCg0KQEAgLTE5MSw3ICsx
OTEsNyBAQCBzdGF0aWMgZG1hX2FkZHJfdCB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKHN0cnVjdCAN
CmRldmljZSAqZGV2LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fcGFnZV90b19nZm4o
cGFnZSkgKyBpLCBkaXIgPT0gDQpETUFfVE9fREVWSUNFKTsNCiDCoMKgwqDCoMKgwqDCoCB9DQoN
Ci3CoMKgwqDCoMKgwqAgZG1hX2hhbmRsZSA9IGdyYW50X3RvX2RtYShncmFudCkgKyBvZmZzZXQ7
DQorwqDCoMKgwqDCoMKgIGRtYV9oYW5kbGUgPSBncmFudF90b19kbWEoZ3JhbnQpICsgeGVuX29m
ZnNldF9pbl9wYWdlKG9mZnNldCk7DQoNCiDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZG1hX2hhbmRs
ZTsNCiDCoH0NCg0KRGlkIEkgZ2V0IHlvdXIgcG9pbnQgcmlnaHQ/DQoNCg0KPg0KPg0KPj4gK8Kg
wqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFhFTl9QRk5fVVAob2Zmc2V0ICsgc2l6ZSk7
DQo+PiDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdyYW50Ow0KPj4gwqAgwqDCoMKgwqDCoCBpZiAo
V0FSTl9PTihkaXIgPT0gRE1BX05PTkUpKQ0KPg0KDQpUaGFuayB5b3UuDQoNCg0KLS0gDQpSZWdh
cmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 06 22:35:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 06 Oct 2022 22:35:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417301.661945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogZS7-000245-0d; Thu, 06 Oct 2022 22:34:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417301.661945; Thu, 06 Oct 2022 22:34:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogZS6-00023y-U6; Thu, 06 Oct 2022 22:34:50 +0000
Received: by outflank-mailman (input) for mailman id 417301;
 Thu, 06 Oct 2022 22:34:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UgdD=2H=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogZS4-00023o-VO
 for xen-devel@lists.xenproject.org; Thu, 06 Oct 2022 22:34:49 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 145d5702-45c7-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 00:34:46 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 78A3AB81F8D;
 Thu,  6 Oct 2022 22:34:45 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5F4CC433C1;
 Thu,  6 Oct 2022 22:34:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 145d5702-45c7-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665095684;
	bh=Us9jKarHUrWZaZ07PLhLpOakqYYxovDLZSIjVDvgKG0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=hfyTPLBGqv+ZHIhTMa2Hsp+QGhSXSDPjFDyoZGZUAlrlxUpeE3T91/e5mDyHBQAib
	 +SFPbl4HEeh0QCaW4mNzgmzKDfW4A1I32o57XVxhWaJVYpAoRJe15R5DnzAyS1fms2
	 cO90vdB+wVM+c+GzabdK2uK4oN0rblovXtvYSC0mWs1WgRvCu21O7dPJLw8uz+SPW2
	 Jom+1WfBbSb8aJDQp20vGJK9J6MlmFoQfaHeLRDpIy1/zBUKDmpqxDKaq16bEVkf/C
	 rQQWrQJt4AVzM7wPht/EvTA1zUxLznjc3ELv0qYCCx/tc2zS0N/KUchGIhphW9C5ih
	 zNmJMX5v16E5A==
Date: Thu, 6 Oct 2022 15:34:41 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: stefano.stabellini@amd.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] ImageBuilder: Add support for 64-bit addresses
In-Reply-To: <20221006102035.16281-1-michal.orzel@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210061349110.3690179@ubuntu-linux-20-04-desktop>
References: <20221006102035.16281-1-michal.orzel@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

+xen-devel

On Thu, 6 Oct 2022, Michal Orzel wrote:
> At the moment, ImageBuilder assumes that all addresses/sizes are
> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
> value for the first cell. Because of that, we cannot specify MEMORY_START
> and MEMORY_END to be above 32-bits (e.g. to place the images in the
> upper memory bank).
> 
> Add support to properly handle 64-bit addresses:
>  - add function split_into_halves to split the value passed as a first
>    argument into upper and lower halves. These are then set as values for
>    variables passed respetively as the second and third argument,
>  - whenever there is a variable storing the full 64-bit number with
>    "addr" or "size" in name, introduce two additional variables with
>    "addr1,addr2"/"size1,size2" in name to store the halves. These are
>    then used to properly set cells.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>
> ---
>  scripts/uboot-script-gen | 60 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 53 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> index 16269f02f1e7..4c6525a910f3 100755
> --- a/scripts/uboot-script-gen
> +++ b/scripts/uboot-script-gen
> @@ -25,6 +25,14 @@ function dt_mknode()
>      fi
>  }
>  
> +# Usage:
> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
> +function split_into_halves()
> +{
> +    eval "$2=$(printf "0x%X\n" $(($1 >> 32)))"
> +    eval "$3=$(printf "0x%X\n" $(($1 & 0xFFFFFFFF)))"
> +}

I know it is the same thing, but I would prefer the following version
because it makes it easier to read:

# Usage:
# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
function split_into_halves()
{
    local value=$1
    local upper=$2
    local lower=$3

    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
}


> +
>  # data_type is either
>  #   int
>  #   hex
> @@ -41,10 +49,14 @@ function dt_set()
>  
>      if test $data_type = "var"
>      then
> -        eval data_addr_var="$data"_addr
> -        eval data_addr=\$"$data_addr_var"
> -        eval data_size_var="$data"_size
> -        eval data_size=\$"$data_size_var"
> +        eval data_addr1_var="$data"_addr1
> +        eval data_addr2_var="$data"_addr2
> +        eval data_addr1=\$"$data_addr1_var"
> +        eval data_addr2=\$"$data_addr2_var"
> +        eval data_size1_var="$data"_size1
> +        eval data_size2_var="$data"_size2
> +        eval data_size1=\$"$data_size1_var"
> +        eval data_size2=\$"$data_size2_var"

To avoid making the code more complex, is it possible to stick with just
a single data_addr variable in u-boot and calculate the upper and lower
32-bit using u-boot commands?

That way, we can keep the current scheme of address and size variable
storage, which I think is already complex enough, and just add the
calculation when needed.

So we could do for the dynamic case:

setexpr data_addr1 \${"$data_addr_var"} / 0x100000000
setexpr data_addr2 \${"$data_addr_var"} \& 0xffffffff

And it could be moved into split_into_halves, so that split_into_halves
can be called for both the dynamic case and the non-dynamic case maybe.

This should reduce the amount of changes significantly.


>      fi
>  
>      if test "$UBOOT_SOURCE" && test ! "$FIT"
> @@ -54,9 +66,9 @@ function dt_set()
>          then
>              if test $dynamic_loading_opt
>              then
> -                echo "fdt set $path $var <0x0 0x\${"$data_addr_var"} 0x0 0x\${"$data_size_var"}>" >> $UBOOT_SOURCE
> +                echo "fdt set $path $var <0x\${"$data_addr1_var"} 0x\${"$data_addr2_var"} 0x\${"$data_size1_var"} 0x\${"$data_size2_var"}>" >> $UBOOT_SOURCE
>              else
> -                echo "fdt set $path $var <0x0 $data_addr 0x0 $data_size>" >> $UBOOT_SOURCE
> +                echo "fdt set $path $var <$data_addr1 $data_addr2 $data_size1 $data_size2>" >> $UBOOT_SOURCE
>              fi
>          elif test $data_type = "hex" || test $data_type = "int"
>          then
> @@ -84,7 +96,7 @@ function dt_set()
>      then
>          if test $data_type = "var"
>          then
> -            fdtput $FDTEDIT -p -t x $path $var 0x0 "$data_addr" 0x0 "$data_size"
> +            fdtput $FDTEDIT -p -t x $path $var "$data_addr1" "$data_addr2" "$data_size1" "$data_size2"
>          elif test $data_type = "hex"
>          then
>              fdtput $FDTEDIT -p -t x $path $var $data
> @@ -396,18 +408,38 @@ function add_size()
>      local filename=$1
>      local fit_scr_name=$2
>      local binary_name_addr="${fit_scr_name}_addr"
> +    local binary_name_addr1="${fit_scr_name}_addr1"
> +    local binary_name_addr2="${fit_scr_name}_addr2"
>      local binary_name_size="${fit_scr_name}_size"
> +    local binary_name_size1="${fit_scr_name}_size1"
> +    local binary_name_size2="${fit_scr_name}_size2"
> +
> +    split_into_halves $memaddr memaddr1 memaddr2
>      eval "$fit_scr_name"_addr=$memaddr
> +    eval "$fit_scr_name"_addr1=$memaddr1
> +    eval "$fit_scr_name"_addr2=$memaddr2
>  
>      local size=`stat -L --printf="%s" $filename`
>      filesize=$size
> +    split_into_halves $size size1 size2
>      eval "$fit_scr_name"_size=`printf "0x%X\n" $size`
> +    eval "$fit_scr_name"_size1=$size1
> +    eval "$fit_scr_name"_size2=$size2
>      eval binary_name_size_value=\$"$binary_name_size"
> +    split_into_halves $binary_name_size_value binary_name_size_value1 binary_name_size_value2
>      
>      if test $dynamic_loading_opt
>      then
> +        echo "setexpr memaddr1 \${memaddr} \/ 0x100000000" >> $UBOOT_SOURCE
> +        echo "setexpr memaddr2 \${memaddr} \& 0xFFFFFFFF" >> $UBOOT_SOURCE
> +        echo "setexpr filesize1 \${filesize} \/ 0x100000000" >> $UBOOT_SOURCE
> +        echo "setexpr filesize2 \${filesize} \& 0xFFFFFFFF" >> $UBOOT_SOURCE
>          echo "setenv $binary_name_addr \${memaddr}" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_addr1 \${memaddr1}" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_addr2 \${memaddr2}" >> $UBOOT_SOURCE
>          echo "setenv $binary_name_size \${filesize}" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_size1 \${filesize1}" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_size2 \${filesize2}" >> $UBOOT_SOURCE
>          # Compute load addr for next binary dynamically
>          echo "setexpr memaddr \${memaddr} \+ \${filesize}" >> $UBOOT_SOURCE
>          echo "setexpr memaddr \${memaddr} \+ $padding_mask" >> $UBOOT_SOURCE
> @@ -415,7 +447,11 @@ function add_size()
>      else
>          # Store load addr and size as literals
>          echo "setenv $binary_name_addr $memaddr" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_addr1 $memaddr1" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_addr2 $memaddr2" >> $UBOOT_SOURCE
>          echo "setenv $binary_name_size $binary_name_size_value" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_size1 $binary_name_size_value1" >> $UBOOT_SOURCE
> +        echo "setenv $binary_name_size2 $binary_name_size_value2" >> $UBOOT_SOURCE
>      fi
>  
>      memaddr=$(( $memaddr + $size + $offset - 1))
> @@ -666,16 +702,20 @@ xen_file_loading()
>      then
>          check_compressed_file_type $DOM0_KERNEL "executable"
>          dom0_kernel_addr=$memaddr
> +        split_into_halves $dom0_kernel_addr dom0_kernel_addr1 dom0_kernel_addr2
>          load_file $DOM0_KERNEL "dom0_linux"
>          dom0_kernel_size=$filesize
> +        split_into_halves $dom0_kernel_size dom0_kernel_size1 dom0_kernel_size2
>      fi
>      if test "$DOM0_RAMDISK"
>      then
>          check_compressed_file_type $DOM0_RAMDISK "cpio archive"
>          ramdisk_addr=$memaddr
> +        split_into_halves $ramdisk_addr ramdisk_addr1 ramdisk_addr2
>          ramdisk_path=$DOM0_RAMDISK
>          load_file "$DOM0_RAMDISK" "dom0_ramdisk"
>          ramdisk_size=$filesize
> +        split_into_halves $ramdisk_size ramdisk_size1 ramdisk_size2
>      else
>          ramdisk_addr="-"
>      fi
> @@ -701,21 +741,27 @@ xen_file_loading()
>  
>          check_compressed_file_type ${DOMU_KERNEL[$i]} "executable"
>          domU_kernel_addr[$i]=$memaddr
> +        split_into_halves ${domU_kernel_addr[$i]} domU_kernel_addr1[$i] domU_kernel_addr2[$i]
>          load_file ${DOMU_KERNEL[$i]} "domU${i}_kernel"
>          domU_kernel_size[$i]=$filesize
> +        split_into_halves ${domU_kernel_size[$i]} domU_kernel_size1[$i] domU_kernel_size2[$i]
>          if test "${DOMU_RAMDISK[$i]}"
>          then
>              check_compressed_file_type ${DOMU_RAMDISK[$i]} "cpio archive"
>              domU_ramdisk_addr[$i]=$memaddr
> +            split_into_halves ${domU_ramdisk_addr[$i]} domU_ramdisk_addr1[$i] domU_ramdisk_addr2[$i]
>              load_file ${DOMU_RAMDISK[$i]} "domU${i}_ramdisk"
>              domU_ramdisk_size[$i]=$filesize
> +            split_into_halves ${domU_ramdisk_size[$i]} domU_ramdisk_size1[$i] domU_ramdisk_size2[$i]
>          fi
>          if test "${DOMU_PASSTHROUGH_DTB[$i]}"
>          then
>              check_compressed_file_type ${DOMU_PASSTHROUGH_DTB[$i]} "Device Tree Blob"
>              domU_passthrough_dtb_addr[$i]=$memaddr
> +            split_into_halves ${domU_passthrough_dtb_addr[$i]} domU_passthrough_dtb_addr1[$i] domU_passthrough_dtb_addr2[$i]
>              load_file ${DOMU_PASSTHROUGH_DTB[$i]} "domU${i}_fdt"
>              domU_passthrough_dtb_size[$i]=$filesize
> +            split_into_halves ${domU_passthrough_dtb_size[$i]} domU_passthrough_dtb_size1[$i] domU_passthrough_dtb_size2[$i]
>          fi
>          i=$(( $i + 1 ))
>      done
> -- 
> 2.25.1
> 
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 00:23:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 00:23:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417307.661955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogb9T-0005H2-Of; Fri, 07 Oct 2022 00:23:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417307.661955; Fri, 07 Oct 2022 00:23:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogb9T-0005Gv-Lq; Fri, 07 Oct 2022 00:23:43 +0000
Received: by outflank-mailman (input) for mailman id 417307;
 Fri, 07 Oct 2022 00:23:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogb9R-0005Gp-Vt
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 00:23:41 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4a28da7f-45d6-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 02:23:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 43350B821ED;
 Fri,  7 Oct 2022 00:23:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5011DC433C1;
 Fri,  7 Oct 2022 00:23:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a28da7f-45d6-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665102217;
	bh=Et26OS3EyRmy77qPfsgsF4rcn/zFt1wMAuvka68v87U=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HqwJ3XEQ4nYbxIa9HgoA/a7H7BKi8YZZgdoGyWU0p1t3yobUxFminM/Nmzhx7DtWE
	 g4/UdyCL2b9YXIq1ufshqRbgzCmpCujqe7CRjCh91WSJLx7henkuE10iQE7vtgo6dY
	 zXDO45zb0YclllssCxvKoeyufx+tocHyVs+cx5lHeQDZFeRQQemgF3IhCiEVamV9eb
	 30YVr2Fmf1Z5khqxrznRy+C9swz/2Uk6a+pB/9IU/kZEA5U0wrm3KfX3vE/FqKy2dN
	 m4Wu2Qgb5t2q7Loz10eQPfMmSYbNs4gVT67zOGi6UmnKvwcr1VkpAQAojRkD2jRt1o
	 qzNf6xBnqQqUg==
Date: Thu, 6 Oct 2022 17:23:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Juergen Gross <jgross@suse.com>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup
In-Reply-To: <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210061723240.3690179@ubuntu-linux-20-04-desktop>
References: <20221006071500.15689-1-jgross@suse.com> <20221006071500.15689-2-jgross@suse.com> <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 6 Oct 2022, Oleksandr Tyshchenko wrote:
> On 06.10.22 10:14, Juergen Gross wrote:
> 
> Hello Juergen
> 
> > In order to prepare supporting other means than device tree for
> > setting up virtio devices under Xen, restructure the functions
> > xen_is_grant_dma_device() and xen_grant_setup_dma_ops() a little bit.
> >
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> 
> Patch looks good,
> 
> one NIT, xen_dt_grant_setup_dma_ops() down the code doesn't actually 
> setup DMA OPS, it retrieves the backend domid via device-tree means and 
> stores it,
> 
> so I would rename to it, maybe something like 
> xen_dt_grant_setup_backend_domid() or xen_dt_grant_init_backend_domid(), 
> but I am not sure it would be good alternative.
> 
> 
> So, w/ or w/o renaming:
> 
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> also
> 
> Tested-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> # Arm64 
> only

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 00:24:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 00:24:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417309.661967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogb9m-0005bG-1I; Fri, 07 Oct 2022 00:24:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417309.661967; Fri, 07 Oct 2022 00:24:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogb9l-0005b7-UL; Fri, 07 Oct 2022 00:24:01 +0000
Received: by outflank-mailman (input) for mailman id 417309;
 Fri, 07 Oct 2022 00:24:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogb9l-0005a1-1d
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 00:24:01 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54fb0d29-45d6-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 02:23:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6D90D61921;
 Fri,  7 Oct 2022 00:23:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33C89C433D6;
 Fri,  7 Oct 2022 00:23:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54fb0d29-45d6-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665102235;
	bh=wNxxAaNgmv1Yy2qhYYPm61z1GMJgbu+XBvZGxaEoE4U=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kVleMf6zL6f1pwxe3/B2+3DcPTeU3X6a/wIGPDmirHr2H5djKLv8hAP3MT3r/KeNf
	 7Iu7krEgUK6RMUuh3oPWvGrQoXgT2rnlUWnpQAmGvFOxkLRwSVN/czsbTqpoRF0O8Z
	 EhEIImTKy/roVmqFiE6fJZ3RGfNgwaNLXYa5++bk1MZjcXL6OwB6vcyL9bgQ9OR1pb
	 jikOOGFNJiMQPE/gzN5LBfzAc3yW4s/F6xrNdBGknOVcyIGL7sELIUIkqRrD2ePMEO
	 21i9P/Q+7ae1hDCMjXB6nym3qwmuxGJYwmp8gX7d/2w0uCx0MaycdEKFVKwMoN3klc
	 qldIYJvaWDb5g==
Date: Thu, 6 Oct 2022 17:23:52 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Juergen Gross <jgross@suse.com>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen/virtio: use dom0 as default backend for
 CONFIG_XEN_VIRTIO_FORCE_GRANT
In-Reply-To: <36b69e76-a26e-f7e5-998a-8345034cec20@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210061723410.3690179@ubuntu-linux-20-04-desktop>
References: <20221006071500.15689-1-jgross@suse.com> <20221006071500.15689-3-jgross@suse.com> <36b69e76-a26e-f7e5-998a-8345034cec20@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 6 Oct 2022, Oleksandr Tyshchenko wrote:
> On 06.10.22 10:14, Juergen Gross wrote:
> 
> Hello Juergen
> 
> > With CONFIG_XEN_VIRTIO_FORCE_GRANT set the default backend domid to 0,
> > enabling to use xen_grant_dma_ops for those devices.
> >
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> > ---
> >   drivers/xen/grant-dma-ops.c | 3 +++
> >   1 file changed, 3 insertions(+)
> 
> 
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> > diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> > index f29759d5301f..a00112235877 100644
> > --- a/drivers/xen/grant-dma-ops.c
> > +++ b/drivers/xen/grant-dma-ops.c
> > @@ -349,6 +349,9 @@ void xen_grant_setup_dma_ops(struct device *dev)
> >   	if (dev->of_node) {
> >   		if (xen_dt_grant_setup_dma_ops(dev, data))
> >   			goto err;
> > +	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
> > +		dev_info(dev, "Using dom0 as backend\n");
> > +		data->backend_domid = 0;
> >   	} else {
> >   		/* XXX ACPI device unsupported for now */
> >   		goto err;
> 
> -- 
> Regards,
> 
> Oleksandr Tyshchenko
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 01:11:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 01:11:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417320.661979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogbts-0004ke-JU; Fri, 07 Oct 2022 01:11:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417320.661979; Fri, 07 Oct 2022 01:11:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogbts-0004kX-El; Fri, 07 Oct 2022 01:11:40 +0000
Received: by outflank-mailman (input) for mailman id 417320;
 Fri, 07 Oct 2022 01:11:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogbtr-0004kN-EJ; Fri, 07 Oct 2022 01:11:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogbtr-0004e3-8B; Fri, 07 Oct 2022 01:11:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogbtq-0008Kg-Mv; Fri, 07 Oct 2022 01:11:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogbtq-0003HD-MT; Fri, 07 Oct 2022 01:11:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kuoqoHSK8qmelNlnU2HYjkBiYcVwH2vUQuMGvqO2hFg=; b=w4ZIUp81WyitolVo/1kJR/2wcE
	Xv4C0CdlX4m6pXe2kE6c8ZTLNISDIfWD0X8EA1hEKdCJyQx1/3lfp1sEJaoy1ur8FNGbOZBOPF7Ov
	OS/9bdQhyZ3+pbXK52UIKV+T5u/EZx8yyttnmuw0bCrpsRL5r8vPw+8LDEQONNexg8e8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173447-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173447: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
X-Osstest-Versions-That:
    qemuu=1dcdc92c72af5311666df64f5f04d6600af262ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 01:11:38 +0000

flight 173447 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173447/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173435

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173435
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173435
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173435
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173435
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173435
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173435
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173435
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173435
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
baseline version:
 qemuu                1dcdc92c72af5311666df64f5f04d6600af262ed

Last test of basis   173435  2022-10-06 01:10:25 Z    0 days
Testing same since   173447  2022-10-06 14:38:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alessandro Di Federico <ale@rev.ng>
  Alex Bennée <alex.bennee@linaro.org>
  Anton Johansson <anjo@rev.ng>
  Daniel P. Berrangé <berrange@redhat.com>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
  Paolo Bonzini <pbonzini@redhat.com>
  Paolo Montesel <babush@rev.ng>
  Richard Henderson <richard.henderson@linaro.org>
  Song Gao <gaosong@loongson.cn>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   1dcdc92c72..f1d33f55c4  f1d33f55c47dfdaf8daacd618588ad3ae4c452d1 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 01:14:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 01:14:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417331.661989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogbwZ-0005Pw-3K; Fri, 07 Oct 2022 01:14:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417331.661989; Fri, 07 Oct 2022 01:14:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogbwZ-0005Pp-0U; Fri, 07 Oct 2022 01:14:27 +0000
Received: by outflank-mailman (input) for mailman id 417331;
 Fri, 07 Oct 2022 01:14:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogbwY-0005Pj-0R
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 01:14:26 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60f1c824-45dd-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 03:14:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D3D92B821EF;
 Fri,  7 Oct 2022 01:14:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C47A8C433C1;
 Fri,  7 Oct 2022 01:14:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60f1c824-45dd-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665105261;
	bh=8mLAnMeo3AtHBXXkzvL+vd14+0hlje4dHLK3eWyTIpw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=o7/rj/a7pGC7DHBC2CjftJB/z3X0tMtJekp5m2kKDpIHciFRIiYrCZbndME0PYKV/
	 CUh7OMeWfqTXY418PWfrGh3sbLavsoRGVCSaWVV9w7LcLHb5MG5BYZR0wA9pAW4f0m
	 foEzFOehsgylAElZiYpo28bvl9SMkw/IkNZRmZeLY4s5kBMdQWYUBPgLZ9WRAOZn1y
	 GTca8eCkXsFWuPSFaP5at9VL3vt0hoOqQ7x4IDYNCMxQA1jw6lF2K99HTu3dZ5SnUk
	 +Kk0SCeAc6GNzgt65KvXt4Ah9iQckGyuCBsjl9qanAjTtx7lSIsqB/xbcArFVQCk5D
	 /zXOw1yNBoKIg==
Date: Thu, 6 Oct 2022 18:14:19 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
In-Reply-To: <20221006174804.2003029-1-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop>
References: <20221006174804.2003029-1-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 6 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the same "xen-grant-dma" device concept (based on generic IOMMU
> device-tree bindings) for the PCI devices behind device-tree based
> PCI Host controller.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> on Arm at some point in the future. The Xen toolstack side is not published yet.
> Here, for PCI devices we use the same way to pass backend domid to the guest as for
> platform devices.
> 
> Depends on Juergen's series:
> https://lore.kernel.org/xen-devel/20221006071500.15689-1-jgross@suse.com/
> ---
>  drivers/xen/grant-dma-ops.c | 51 +++++++++++++++++++++++++++++--------
>  1 file changed, 41 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index ff9be3aff87e..79d13122ec08 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>  #include <linux/module.h>
>  #include <linux/dma-map-ops.h>
>  #include <linux/of.h>
> +#include <linux/pci.h>
>  #include <linux/pfn.h>
>  #include <linux/xarray.h>
>  #include <linux/virtio_anchor.h>
> @@ -273,12 +274,28 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> +static struct device_node *xen_dt_get_node(struct device *dev)
> +{
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		struct pci_bus *bus = pdev->bus;
> +
> +		/* Walk up to the root bus to look for PCI Host controller */
> +		while (!pci_is_root_bus(bus))
> +			bus = bus->parent;
> +
> +		return of_node_get(bus->bridge->parent->of_node);
> +	}

Is it possible to have multiple virtio devices under a single virtio-pci
root complex? What if virtio-net has the backend in dom0 and
virtio-block has the backend in dom1?

Or each virtio PCI device shows up under a different PCI root complex?

If we can have multiple virtio PCI devices under a single PCI root
complex, then I think it would be better to check for a per-device
property, rather than a single property at the PCI root complex level.

The first thing that comes to mind is to describe each PCI device under
the root complex in device tree. Although it is uncommon (usually only
the PCI root complex is described in device tree), it is possible to
also describe in device tree all the individual PCI devices under the
root complex.

Given that the domU device tree is generated by Xen and/or the Xen
toolstack, it would be easy to arrange for it to happen.

That would solve the issue as far as I can tell, but I worry it might
not be a good idea because if we rely on the per-device device tree node
to be present then it becomes harder to implement virtio hotplug
(Virtio hotplug is important to add dom0less support.)

Let's say that we create a dom0less domU with an emulated PCI root
complex without any devices under it, then after Dom0 is fully booted,
we add a virtio-net emulated device. How do we tell the guest what is
the backend domain id?

Device tree and other firmware tables are not relevant anymore.

We could reuse a PCI config space register to expose the backend id.
However this solution requires a backend change (QEMU) to expose the
backend id via an emulated register for each emulated device.

To avoid having to introduce a special config space register in all
emulated PCI devices (virtio-net, virtio-block, etc) I wonder if we
could add a special PCI config space register at the emulated PCI Root
Complex level.

Basically the workflow would be as follow:

- Linux recognizes the PCI Root Complex as a Xen PCI Root Complex
- Linux writes to special PCI config space register of the Xen PCI Root
  Complex the PCI device id (basically the BDF)
- The Xen PCI Root Complex emulated by Xen answers by writing back to
  the same location the backend id (domid of the backend)
- Linux reads back the same PCI config space register of the Xen PCI
  Root Complex and learn the relevant domid

What do you think?

Other ideas welcome!



> +	return of_node_get(dev->of_node);
> +}
> +
> +static bool xen_is_dt_grant_dma_device(struct device_node *np)
>  {
>  	struct device_node *iommu_np;
>  	bool has_iommu;
>  
> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +	iommu_np = of_parse_phandle(np, "iommus", 0);
>  	has_iommu = iommu_np &&
>  		    of_device_is_compatible(iommu_np, "xen,grant-dma");
>  	of_node_put(iommu_np);
> @@ -288,9 +305,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
>  
>  bool xen_is_grant_dma_device(struct device *dev)
>  {
> +	struct device_node *np;
> +
>  	/* XXX Handle only DT devices for now */
> -	if (dev->of_node)
> -		return xen_is_dt_grant_dma_device(dev);
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		bool ret;
> +
> +		ret = xen_is_dt_grant_dma_device(np);
> +		of_node_put(np);
> +		return ret;
> +	}
>  
>  	return false;
>  }
> @@ -303,20 +328,20 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
>  	return xen_is_grant_dma_device(dev->dev.parent);
>  }
>  
> -static int xen_dt_grant_setup_dma_ops(struct device *dev,
> +static int xen_dt_grant_setup_dma_ops(struct device_node *np,
>  				       struct xen_grant_dma_data *data)
>  {
>  	struct of_phandle_args iommu_spec;
>  
> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> +	if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
>  			0, &iommu_spec)) {
> -		dev_err(dev, "Cannot parse iommus property\n");
> +		pr_err("%s: Cannot parse iommus property\n", np->name);
>  		return -ESRCH;
>  	}
>  
>  	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
>  			iommu_spec.args_count != 1) {
> -		dev_err(dev, "Incompatible IOMMU node\n");
> +		pr_err("%s: Incompatible IOMMU node\n", iommu_spec.np->name);
>  		of_node_put(iommu_spec.np);
>  		return -ESRCH;
>  	}
> @@ -335,6 +360,7 @@ static int xen_dt_grant_setup_dma_ops(struct device *dev,
>  void xen_grant_setup_dma_ops(struct device *dev)
>  {
>  	struct xen_grant_dma_data *data;
> +	struct device_node *np;
>  
>  	data = find_xen_grant_dma_data(dev);
>  	if (data) {
> @@ -346,8 +372,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  	if (!data)
>  		goto err;
>  
> -	if (dev->of_node) {
> -		if (xen_dt_grant_setup_dma_ops(dev, data))
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		int ret;
> +
> +		ret = xen_dt_grant_setup_dma_ops(np, data);
> +		of_node_put(np);
> +		if (ret)
>  			goto err;
>  	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>  		dev_info(dev, "Using dom0 as backend\n");
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 04:31:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 04:31:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417341.662000 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogf1Q-0000DK-6E; Fri, 07 Oct 2022 04:31:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417341.662000; Fri, 07 Oct 2022 04:31:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogf1Q-0000DD-2O; Fri, 07 Oct 2022 04:31:40 +0000
Received: by outflank-mailman (input) for mailman id 417341;
 Fri, 07 Oct 2022 04:31:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogf1O-0000D7-MT
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 04:31:38 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id edbbf181-45f8-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 06:31:36 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C14AB21981;
 Fri,  7 Oct 2022 04:31:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 669F513A3D;
 Fri,  7 Oct 2022 04:31:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gpBlF6erP2MPHgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 04:31:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edbbf181-45f8-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665117095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=xB06VBd/Y49QFqBxqn3w68xF0j6t4V/2NhwVr0WnPi0=;
	b=bf4o3RKEk2QDKSV6hT3HIUe4YvyPgk1SvvSL7QhiGcoKdkbsTyvquMVKOUEsNR6kO9zEOO
	6I6cv44zn6yL3I9pALX4VWfQiarsc1CPR0TEwQIYZs2gnRobLOjeCxD9bhHSRliullxkn/
	hFhXGJKIGsdm9QYQsJhmOwVeoTCa33A=
Message-ID: <4d2af823-072c-8d08-8fa0-a223fd29b7d5@suse.com>
Date: Fri, 7 Oct 2022 06:31:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 3/3] xen/virtio: enable grant based virtio on x86
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-4-jgross@suse.com>
 <2e721170-6035-90e3-f929-79b0a07e1891@epam.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <2e721170-6035-90e3-f929-79b0a07e1891@epam.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------tJMgqarFki0k550caoVqfGBp"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------tJMgqarFki0k550caoVqfGBp
Content-Type: multipart/mixed; boundary="------------ZJJs5059ahbNeRfNxBy3DHk0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <4d2af823-072c-8d08-8fa0-a223fd29b7d5@suse.com>
Subject: Re: [PATCH 3/3] xen/virtio: enable grant based virtio on x86
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-4-jgross@suse.com>
 <2e721170-6035-90e3-f929-79b0a07e1891@epam.com>
In-Reply-To: <2e721170-6035-90e3-f929-79b0a07e1891@epam.com>

--------------ZJJs5059ahbNeRfNxBy3DHk0
Content-Type: multipart/mixed; boundary="------------HOQMds0X0nGhH6PWd608iNXu"

--------------HOQMds0X0nGhH6PWd608iNXu
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMTg6MDQsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4g
T24gMDYuMTAuMjIgMTA6MTUsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IA0KPiANCj4gSGVs
bG8gSnVlcmdlbg0KPiANCj4+IFVzZSBhbiB4ODYtc3BlY2lmaWMgdmlydGlvX2NoZWNrX21l
bV9hY2NfY2IoKSBmb3IgWGVuIGluIG9yZGVyIHRvIHNldHVwDQo+PiB0aGUgY29ycmVjdCBE
TUEgb3BzLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz
dXNlLmNvbT4NCj4+IC0tLQ0KPj4gICAgYXJjaC94ODYveGVuL2VubGlnaHRlbl9odm0uYyB8
ICAyICstDQo+PiAgICBhcmNoL3g4Ni94ZW4vZW5saWdodGVuX3B2LmMgIHwgIDIgKy0NCj4+
ICAgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyAgfCAxMCArKysrKysrKysrDQo+PiAg
ICBpbmNsdWRlL3hlbi94ZW4tb3BzLmggICAgICAgIHwgIDEgKw0KPj4gICAgNCBmaWxlcyBj
aGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYg
LS1naXQgYS9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jIGIvYXJjaC94ODYveGVuL2Vu
bGlnaHRlbl9odm0uYw0KPj4gaW5kZXggMWMxYWM0MTg0ODRiLi5jMWNkMjhlOTE1YTMgMTAw
NjQ0DQo+PiAtLS0gYS9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jDQo+PiArKysgYi9h
cmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jDQo+PiBAQCAtMjEyLDcgKzIxMiw3IEBAIHN0
YXRpYyB2b2lkIF9faW5pdCB4ZW5faHZtX2d1ZXN0X2luaXQodm9pZCkNCj4+ICAgIAkJcmV0
dXJuOw0KPj4gICAgDQo+PiAgICAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU9f
Rk9SQ0VfR1JBTlQpKQ0KPj4gLQkJdmlydGlvX3NldF9tZW1fYWNjX2NiKHZpcnRpb19yZXF1
aXJlX3Jlc3RyaWN0ZWRfbWVtX2FjYyk7DQo+PiArCQl2aXJ0aW9fc2V0X21lbV9hY2NfY2Io
eGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2MpOw0KPj4gICAgDQo+PiAgICAJaW5pdF9o
dm1fcHZfaW5mbygpOw0KPj4gICAgDQo+PiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL2Vu
bGlnaHRlbl9wdi5jIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jDQo+PiBpbmRleCA5
YjFhNThkZGE5MzUuLjQ1YjI0YzFiNjQ2YSAxMDA2NDQNCj4+IC0tLSBhL2FyY2gveDg2L3hl
bi9lbmxpZ2h0ZW5fcHYuYw0KPj4gKysrIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5j
DQo+PiBAQCAtMTEyLDcgKzExMiw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCB4ZW5fcHZfaW5p
dF9wbGF0Zm9ybSh2b2lkKQ0KPj4gICAgew0KPj4gICAgCS8qIFBWIGd1ZXN0cyBjYW4ndCBv
cGVyYXRlIHZpcnRpbyBkZXZpY2VzIHdpdGhvdXQgZ3JhbnRzLiAqLw0KPj4gICAgCWlmIChJ
U19FTkFCTEVEKENPTkZJR19YRU5fVklSVElPKSkNCj4+IC0JCXZpcnRpb19zZXRfbWVtX2Fj
Y19jYih2aXJ0aW9fcmVxdWlyZV9yZXN0cmljdGVkX21lbV9hY2MpOw0KPj4gKwkJdmlydGlv
X3NldF9tZW1fYWNjX2NiKHhlbl92aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4+ICAg
IA0KPj4gICAgCXBvcHVsYXRlX2V4dHJhX3B0ZShmaXhfdG9fdmlydChGSVhfUEFSQVZJUlRf
Qk9PVE1BUCkpOw0KPj4gICAgDQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQt
ZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBpbmRleCBhMDAx
MTIyMzU4NzcuLjYwYTdhY2MzMzRlZCAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMveGVuL2dy
YW50LWRtYS1vcHMuYw0KPj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+
PiBAQCAtMzcyLDYgKzM3MiwxNiBAQCB2b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKHN0
cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgIAlkZXZfZXJyKGRldiwgIkNhbm5vdCBzZXQgdXAg
WGVuIGdyYW50IERNQSBvcHMsIHJldGFpbiBwbGF0Zm9ybSBETUEgb3BzXG4iKTsNCj4+ICAg
IH0NCj4+ICAgIA0KPj4gK2Jvb2wgeGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2Moc3Ry
dWN0IHZpcnRpb19kZXZpY2UgKmRldikNCj4+ICt7DQo+PiArCWJvb2wgcmV0ID0geGVuX3Zp
cnRpb19tZW1fYWNjKGRldik7DQo+IA0KPiANCj4gVGhlIGdyYW50IHVzYWdlIGlzIG1hbmRh
dG9yeSBmb3IgUFYgZ3Vlc3RzLCByaWdodD8NCj4gDQo+IFRoZW4geGVuX3ZpcnRpb19tZW1f
YWNjKCkgc2hvdWxkIGFsd2F5cyByZXR1cm4gdHJ1ZSBmb3IgUFYgZ3Vlc3RzIChJDQo+IG1l
YW4gZXZlbiBpZiBDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVCBpcyBub3Qgc2V0KS4N
Cg0KWWVzLg0KDQo+IA0KPiANCj4gDQo+PiArDQo+PiArCWlmIChyZXQpDQo+PiArCQl4ZW5f
Z3JhbnRfc2V0dXBfZG1hX29wcyhkZXYtPmRldi5wYXJlbnQpOw0KPj4gKw0KPj4gKwlyZXR1
cm4gcmV0Ow0KPj4gK30NCj4+ICsNCj4+ICAgIE1PRFVMRV9ERVNDUklQVElPTigiWGVuIGdy
YW50IERNQS1tYXBwaW5nIGxheWVyIik7DQo+PiAgICBNT0RVTEVfQVVUSE9SKCJKdWVyZ2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Iik7DQo+PiAgICBNT0RVTEVfTElDRU5TRSgiR1BM
Iik7DQo+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS94ZW4veGVuLW9wcy5oIGIvaW5jbHVkZS94
ZW4veGVuLW9wcy5oDQo+PiBpbmRleCBkYWUwZjM1MGM2NzguLjNkZDVhYTkzNmYxZCAxMDA2
NDQNCj4+IC0tLSBhL2luY2x1ZGUveGVuL3hlbi1vcHMuaA0KPj4gKysrIGIvaW5jbHVkZS94
ZW4veGVuLW9wcy5oDQo+PiBAQCAtMjE5LDYgKzIxOSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9p
ZCB4ZW5fcHJlZW1wdGlibGVfaGNhbGxfZW5kKHZvaWQpIHsgfQ0KPj4gICAgdm9pZCB4ZW5f
Z3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpOw0KPj4gICAgYm9vbCB4
ZW5faXNfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpOw0KPj4gICAgYm9v
bCB4ZW5fdmlydGlvX21lbV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldik7DQo+PiAr
Ym9vbCB4ZW5fdmlydGlvX3Jlc3RyaWN0ZWRfbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2Rldmlj
ZSAqZGV2KTsNCj4+ICAgICNlbHNlDQo+PiAgICBzdGF0aWMgaW5saW5lIHZvaWQgeGVuX2dy
YW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICAgew0KPiANCj4g
DQo+IEFuZCBwcm9iYWJseSBzdGF0aWMgaW5saW5lIHN0dWIgYWx3YXlzIHJldHVybmluZyBm
YWxzZSBpZg0KPiBDT05GSUdfWEVOX0dSQU5UX0RNQV9PUFMgaXMgbm90IHNldC4NCg0KSW5k
ZWVkLg0KDQoNCkp1ZXJnZW4NCg0K
--------------HOQMds0X0nGhH6PWd608iNXu
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------HOQMds0X0nGhH6PWd608iNXu--

--------------ZJJs5059ahbNeRfNxBy3DHk0--

--------------tJMgqarFki0k550caoVqfGBp
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/q6cFAwAAAAAACgkQsN6d1ii/Ey+Y
nAf/SoXch7HC7ctLGm9005qho84hIsztfnUGRi1rm3oGKBgZ7tPI3nFMkojucbcbYBiBSRxOVuvI
I5YpcwnEJ8w9vC/dS+qBpZ849dQGsJ9TqQVaAFIP+46isbT680vdOQm9vUDjV/47SMyX0vOkpY43
Mp+hpfkZBilmsjNZ+aDUPkjTgCKggY/u6cC47OLfFL4YoYhKuoiIEJwdruCdTsN6F9jODOsqc5hr
sn6AwtVJb/SIFUYW1NtdQkB2YSvQ1B8VcRp/RsvxStDB1bgaDLYpmM+tv1/N4VROSjBL/PLqFy/t
0dB4fSM2dS+j4OvH6Wo+tCqpwQJemFwByUN7ixDqDQ==
=guuC
-----END PGP SIGNATURE-----

--------------tJMgqarFki0k550caoVqfGBp--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 04:35:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 04:35:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417346.662011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogf59-0000uq-Mk; Fri, 07 Oct 2022 04:35:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417346.662011; Fri, 07 Oct 2022 04:35:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogf59-0000uj-JS; Fri, 07 Oct 2022 04:35:31 +0000
Received: by outflank-mailman (input) for mailman id 417346;
 Fri, 07 Oct 2022 04:35:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogf58-0000ub-GW
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 04:35:30 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 78c5c7ca-45f9-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 06:35:29 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 339432198D;
 Fri,  7 Oct 2022 04:35:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 029EC13A3D;
 Fri,  7 Oct 2022 04:35:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id hE+POpCsP2NUHwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 04:35:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78c5c7ca-45f9-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665117329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rtqEG3TKbIp/Bs82eo5+QVL5Q6EWc2OkEwlbTV6CZsE=;
	b=V3Q5dVhUFQJAStG5f1ZeNxan0/w3FdMhcGo04aceuv2a4mXRAe/7IVsq7XcMpHUZmxWnVD
	ou4Ww9kCfHqvsPzKP4w2XeqDOYTwKWHWZXL2kOi7SBaWYKqcH9XkAIX0hEIKvcGVQHmlcd
	JGjylrj9KtXvVlfKHLQLJdHwIaHOpzw=
Message-ID: <127d2641-2f5d-893f-dc81-3c6d52bc78ce@suse.com>
Date: Fri, 7 Oct 2022 06:35:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-2-jgross@suse.com>
 <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------jbDsNvWt9tKelFdrMHX04e8u"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------jbDsNvWt9tKelFdrMHX04e8u
Content-Type: multipart/mixed; boundary="------------TM20SFjXLoPtbcqvvVPlhLC1";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <127d2641-2f5d-893f-dc81-3c6d52bc78ce@suse.com>
Subject: Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup
References: <20221006071500.15689-1-jgross@suse.com>
 <20221006071500.15689-2-jgross@suse.com>
 <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>
In-Reply-To: <a8482a7b-0d89-861d-bc87-632d3230c173@epam.com>

--------------TM20SFjXLoPtbcqvvVPlhLC1
Content-Type: multipart/mixed; boundary="------------ODY5ITicvDsW0a1wocMhxzRz"

--------------ODY5ITicvDsW0a1wocMhxzRz
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMTg6MzUsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4g
T24gMDYuMTAuMjIgMTA6MTQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IA0KPiBIZWxsbyBK
dWVyZ2VuDQo+IA0KPj4gSW4gb3JkZXIgdG8gcHJlcGFyZSBzdXBwb3J0aW5nIG90aGVyIG1l
YW5zIHRoYW4gZGV2aWNlIHRyZWUgZm9yDQo+PiBzZXR0aW5nIHVwIHZpcnRpbyBkZXZpY2Vz
IHVuZGVyIFhlbiwgcmVzdHJ1Y3R1cmUgdGhlIGZ1bmN0aW9ucw0KPj4geGVuX2lzX2dyYW50
X2RtYV9kZXZpY2UoKSBhbmQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoKSBhIGxpdHRsZSBi
aXQuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu
Y29tPg0KPiANCj4gDQo+IFBhdGNoIGxvb2tzIGdvb2QsDQo+IA0KPiBvbmUgTklULCB4ZW5f
ZHRfZ3JhbnRfc2V0dXBfZG1hX29wcygpIGRvd24gdGhlIGNvZGUgZG9lc24ndCBhY3R1YWxs
eQ0KPiBzZXR1cCBETUEgT1BTLCBpdCByZXRyaWV2ZXMgdGhlIGJhY2tlbmQgZG9taWQgdmlh
IGRldmljZS10cmVlIG1lYW5zIGFuZA0KPiBzdG9yZXMgaXQsDQo+IA0KPiBzbyBJIHdvdWxk
IHJlbmFtZSB0byBpdCwgbWF5YmUgc29tZXRoaW5nIGxpa2UNCj4geGVuX2R0X2dyYW50X3Nl
dHVwX2JhY2tlbmRfZG9taWQoKSBvciB4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlk
KCksDQo+IGJ1dCBJIGFtIG5vdCBzdXJlIGl0IHdvdWxkIGJlIGdvb2QgYWx0ZXJuYXRpdmUu
DQoNCkknbGwgZ28gd2l0aCB4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKCkuDQoN
Cj4gDQo+IA0KPiBTbywgdy8gb3Igdy9vIHJlbmFtaW5nOg0KPiANCj4gUmV2aWV3ZWQtYnk6
IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4N
Cj4gDQo+IGFsc28NCj4gDQo+IFRlc3RlZC1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9s
ZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPiAjIEFybTY0DQo+IG9ubHkNCg0KVGhhbmtz
LA0KDQoNCkp1ZXJnZW4NCg0K
--------------ODY5ITicvDsW0a1wocMhxzRz
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------ODY5ITicvDsW0a1wocMhxzRz--

--------------TM20SFjXLoPtbcqvvVPlhLC1--

--------------jbDsNvWt9tKelFdrMHX04e8u
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/rJAFAwAAAAAACgkQsN6d1ii/Ey+t
CAf/Ql9KJJz61Kp8N/3/0XNMnr9nOK+qySKjXEeMeWYeH4jxYwV6v5P9K3cXX8nXuYWhcbTbL+4G
QsvDPQP0Ctz/1qENeuvzFpu3hYC4d0MCcVsqsLPEfuaevPdKfwZCVblzyVrvGkEs03E+pRJDKCU5
XYW/ULpP5BQ4Ou5BZ4OX2bK1Pj/DSZpWXThWtmo7CKiWxUOalTF4DB8Eez7m/mittiFoog659mFt
lRVvvP2lN7YgVOixetegTKmouJgt77pIC8unhCQdeNqplnyZ7ny82fT3ejUUKpnew6KpeNBYmGV/
HZpmmX9eqt4vBooradqIbi3e3q1DzxohhjvIJP0jhA==
=3p5t
-----END PGP SIGNATURE-----

--------------jbDsNvWt9tKelFdrMHX04e8u--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 04:46:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 04:46:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417354.662021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfFo-0002Vc-QP; Fri, 07 Oct 2022 04:46:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417354.662021; Fri, 07 Oct 2022 04:46:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfFo-0002VV-Nj; Fri, 07 Oct 2022 04:46:32 +0000
Received: by outflank-mailman (input) for mailman id 417354;
 Fri, 07 Oct 2022 04:46:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogfFo-0002VO-2E
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 04:46:32 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 02cebdbf-45fb-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 06:46:31 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 34920218F2;
 Fri,  7 Oct 2022 04:46:30 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F1C6213A3D;
 Fri,  7 Oct 2022 04:46:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qj9EOSWvP2OoIgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 04:46:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02cebdbf-45fb-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665117990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=O5GmztskPSP9trLxr89A3zS7Fs4dtcvgwytq+j/McAg=;
	b=CpuMZ4ZUkvUrYkTrqEl3bnkg0d8fikhwjlSmGWY6BhR1hSIj5QIO08FtRXP0mUZp8QYlYk
	SMwunmxrRLe9SeG57W5Nhqf71gPH+ObpJMdMTc/te87wWgrawXIIAtNhRFqqE5uib+csfG
	p78+4/ZXYb5ajxYtXySXd57i28SPvf4=
Message-ID: <8c65d2dc-9901-5863-62a4-054f6fb7c1f3@suse.com>
Date: Fri, 7 Oct 2022 06:46:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Xenia Ragiadakou <burzalodowa@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------PGEokmL5m26k4CjCo2iaZBpW"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------PGEokmL5m26k4CjCo2iaZBpW
Content-Type: multipart/mixed; boundary="------------mTk9N4f3pIuOuR6J0791ynGM";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Xenia Ragiadakou <burzalodowa@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
Message-ID: <8c65d2dc-9901-5863-62a4-054f6fb7c1f3@suse.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
In-Reply-To: <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>

--------------mTk9N4f3pIuOuR6J0791ynGM
Content-Type: multipart/mixed; boundary="------------3L1m4uUGS1CEl6uVBf0RuMMF"

--------------3L1m4uUGS1CEl6uVBf0RuMMF
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMjM6MTMsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiANCj4g
T24gMDYuMTAuMjIgMjA6NTksIFhlbmlhIFJhZ2lhZGFrb3Ugd3JvdGU6DQo+IA0KPiBIZWxs
byBYZW5pYQ0KPiANCj4+DQo+PiBPbiAxMC82LzIyIDE1OjA5LCBPbGVrc2FuZHIgVHlzaGNo
ZW5rbyB3cm90ZToNCj4+PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRy
X3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4NCj4+PiBBbHRob3VnaCBYRU5fUEFHRV9TSVpF
IGlzIGVxdWFsIHRvIFBBR0VfU0laRSAoNEtCKSBmb3Igbm93LCBpdCB3b3VsZA0KPj4+IGJl
IG1vcmUgY29ycmVjdCB0byB1c2UgWGVuIHNwZWNpZmljICNkZWZpbmUtcyBhcyBYRU5fUEFH
RV9TSVpFIGNhbg0KPj4+IGJlIGNoYW5nZWQgYXQgc29tZSBwb2ludCBpbiB0aGUgZnV0dXJl
Lg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtz
YW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KDQouLi4NCg0KPj4gU28sIHRoZSBjYWxjdWxh
dGVkIG51bWJlciBvZiBncmFudHMgbWF5IGRpZmZlci4NCj4gDQo+IEdvb2QgcG9pbnQsIEkg
dGhpbmsgeW91IGFyZSByaWdodCwgc28gd2UgbmVlZCB0byBhZGRpdGlvbmFsbHkgdXNlDQo+
IHhlbl9vZmZzZXRfaW5fcGFnZSgpIG1hY3JvIGluIHhlbl9ncmFudF9kbWFfbWFwX3BhZ2Uo
KSwNCj4gDQo+IHNvbWV0aGluZyBsaWtlIHRoYXQgdG8gYmUgc3F1YXNoZWQgd2l0aCBjdXJy
ZW50IHBhdGNoOg0KPiANCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1k
bWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4gaW5kZXggOWQ1ZWNh
NmQ2MzhhLi5iYjk4NGRjMDVkZWIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50
LWRtYS1vcHMuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4gQEAg
LTE2OSw3ICsxNjksNyBAQCBzdGF0aWMgZG1hX2FkZHJfdCB4ZW5fZ3JhbnRfZG1hX21hcF9w
YWdlKHN0cnVjdA0KPiBkZXZpY2UgKmRldiwgc3RydWN0IHBhZ2UgKnBhZ2UsDQo+ICAgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBhdHRycykNCj4gICDCoHsN
Cj4gICDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0K
PiAtwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gWEVOX1BGTl9VUChv
ZmZzZXQgKyBzaXplKTsNCj4gK8KgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdl
cyA9IFhFTl9QRk5fVVAoeGVuX29mZnNldF9pbl9wYWdlKG9mZnNldCkNCj4gKyBzaXplKTsN
Cg0KSSdkIHJhdGhlciBpbnRyb2R1Y2UgYW5vdGhlciBsb2NhbCB2YXJpYWJsZSAieGVuX29m
ZnNldCIsIGFzIGl0IGlzIHVzZWQNCnR3aWNlLg0KDQoNCg==
--------------3L1m4uUGS1CEl6uVBf0RuMMF
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3L1m4uUGS1CEl6uVBf0RuMMF--

--------------mTk9N4f3pIuOuR6J0791ynGM--

--------------PGEokmL5m26k4CjCo2iaZBpW
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/ryUFAwAAAAAACgkQsN6d1ii/Ey+u
2Qf/ddqDOr0XbrZGjZKCCqOOTcahTi5rSCq0H9zjuWno7AGdf5UZec4WzuLy6wmQ2AGHtRvjBeOO
gMoUIGLVBhtPxhNp9RqNmUlWwzxFQ47ir046S6+/CJza1snGZkBDxWZGp+TGqes7uup/p0OR2Orh
u/DwfCVoD5sbE3FJSiV5kpdNTmsJc9YrHVOovshAxJa7d9EPPaG9zNKqFYEd4IHwHSta9DK29sTM
xhUZY8M/ZgyERI79RhktAD30+QYIPKGowtXE5bZAjm2fVHL5988eAYnP4fI0b3cKz2xztRT5L/QG
J25bESjoWpPpuDt4RlHbTq06Sb5svH+joHZyRCfHYg==
=YKkI
-----END PGP SIGNATURE-----

--------------PGEokmL5m26k4CjCo2iaZBpW--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 04:47:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 04:47:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417359.662033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfH0-000342-43; Fri, 07 Oct 2022 04:47:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417359.662033; Fri, 07 Oct 2022 04:47:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfH0-00033v-0x; Fri, 07 Oct 2022 04:47:46 +0000
Received: by outflank-mailman (input) for mailman id 417359;
 Fri, 07 Oct 2022 04:47:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogfGy-00033h-If; Fri, 07 Oct 2022 04:47:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogfGy-0000Su-Fi; Fri, 07 Oct 2022 04:47:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogfGx-000159-UK; Fri, 07 Oct 2022 04:47:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogfGx-0000yW-S9; Fri, 07 Oct 2022 04:47:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PxkXRB8wMYOEPrCJmhke4sYPEd5srwjXL1x7s8GaCKY=; b=NCIpfCQZJ3h0vtMxBDbyk41Ogw
	DZH+cvT6mnHd4UhSKuwYHsJvwhnM5H4LQS3XMEiV8M8zQqEBRNVTlSmOiCZbdZ2qjZ1nLz/wXT8Wg
	wAS2cXmOoKvjAlDuluXE+t2UGSE2v6cMiFJXt2wVEzxEi03Zj9pujzL3ECDlcu/K+4iA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173450-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173450: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f28b7414ab715e6069e72a7bbe2f1354b2524beb
X-Osstest-Versions-That:
    linux=6215647d9699cb8f1bf7333ec849242c4a9cf9a6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 04:47:43 +0000

flight 173450 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173450/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 173353

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 173433 pass in 173450
 test-armhf-armhf-xl-credit2  14 guest-start      fail in 173433 pass in 173450
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail in 173433 pass in 173450
 test-armhf-armhf-xl-rtds     14 guest-start      fail in 173433 pass in 173450
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173433

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173353
 test-armhf-armhf-xl-credit2  18 guest-start/debian.repeat    fail  like 173353
 test-armhf-armhf-xl-credit1  18 guest-start/debian.repeat    fail  like 173353
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173353
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173353
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173353
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173353
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f28b7414ab715e6069e72a7bbe2f1354b2524beb
baseline version:
 linux                6215647d9699cb8f1bf7333ec849242c4a9cf9a6

Last test of basis   173353  2022-09-28 09:15:02 Z    8 days
Testing same since   173427  2022-10-05 08:44:11 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Alistair Popple <apopple@nvidia.com>
  Andrew Morton <akpm@linux-foundation.org>
  Arnd Bergmann <arnd@arndb.de>
  Bjørn Mork <bjorn@mork.no>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <caihuoqing@baidu.com>
  Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christoph Hellwig <hch@lst.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Hildenbrand <david@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Fabio Estevam <festevam@denx.de>
  Faiz Abbas <faiz_abbas@ti.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Han Xu <han.xu@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heiko Stuebner <heiko@sntech.de>
  Hongling Zeng <zenghongling@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Michael Kelley <mikelley@microsoft.com>
  Michal Hocko <mhocko@suse.com>
  Minchan Kim <minchan@kernel.org>
  Niklas Cassel <niklas.cassel@wdc.com>
  Paolo Abeni <pabeni@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Xu <peterx@redhat.com>
  Rafał Miłecki <rafal@milecki.pl>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sergei Antonov <saproj@gmail.com>
  Stephen Boyd <sboyd@kernel.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Tony Lindgren <tony@atomide.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Wang Yufen <wangyufen@huawei.com>
  Yang Shi <shy828301@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  YuTong Chang <mtwget@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 919 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 04:51:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 04:51:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417370.662043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfKo-0004YQ-Pn; Fri, 07 Oct 2022 04:51:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417370.662043; Fri, 07 Oct 2022 04:51:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfKo-0004YJ-N4; Fri, 07 Oct 2022 04:51:42 +0000
Received: by outflank-mailman (input) for mailman id 417370;
 Fri, 07 Oct 2022 04:51:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=m9C0=2I=gmail.com=degakiran05@srs-se1.protection.inumbo.net>)
 id 1ogfKn-0004YD-9r
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 04:51:41 +0000
Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com
 [2a00:1450:4864:20::32d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb72fc47-45fb-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 06:51:40 +0200 (CEST)
Received: by mail-wm1-x32d.google.com with SMTP id
 fn7-20020a05600c688700b003b4fb113b86so1997290wmb.0
 for <xen-devel@lists.xenproject.org>; Thu, 06 Oct 2022 21:51:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb72fc47-45fb-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=Pli7JPWy8ENMv4xCC2VAJwXYayvmjH1hfUTpvqISj1s=;
        b=aB+ZXT1/YOkVuMDnJyh7VryDP0CjxHvKff5oOUqWwSj3awNVUV/6tdqm2oKUHCMGZJ
         Dh4e1AHop6Rtj3NYoHOdg4Xr+eRaF/fRJENNCfOdifUDWWRSY589Q4TOqcZ3PAOcASE3
         FuxNLYxry/xO5h66kkr43Sz5T5zS/V26CLjpjor7FHYKTfIpkcJzzscWSKInT233XwK8
         5EcYIXTBZhG8jS405a+7uYwc1DR/lfpBpUHF2Pw/Jd5z7apuKhbORMENOqSoibIwtYkl
         zEeSJsjR/f92s+apvZsirJCYm8zhvcHSqR6B2pFobKAuXrzVdRWopKQwlCnRwUkzVKEz
         EWnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=Pli7JPWy8ENMv4xCC2VAJwXYayvmjH1hfUTpvqISj1s=;
        b=aveSaGA9IOLJAf8g3I4ondJYANfvk6lfh7gS9WnWyuCqqoAjVErJ3X253AF2oR/VdQ
         HfjwZlvoRJqQWxq/utghEhrcqg5Xfs0jpe/APU24ylvtJ8kJ1DK9GEdAsbf81qqXxNZt
         S7mIJolTDTnncfWvAlkhhJY5jyippseECNePzSjYCC1qoguFd7XoLme1jEQ2WKMEY29s
         /r5XNoJR5znbRqz9WqSRKLupXod1YujM8+PTGLAy/zHi0BkcLbM6fadbps4BOHVcn8RA
         bQVrvq3JN3AHypVwWyg+bqYgTMhQLrrjD+Enq3a8eddHwSMV6uHhTQhsu+QODN5hIm/x
         yT9Q==
X-Gm-Message-State: ACrzQf3BrFwTRfblbFBokgI/N+hMzv78fkSWaOIWCwY+FGJXtnPM9W3O
	cVzq2ed61EmS6ozFRfVnM8B6u3IcWyOg9fG52hlYQwEn22E=
X-Google-Smtp-Source: AMsMyM74LrBussLZQo7ZCwsy6yJsFULNy4ok8+F3PqTPMr1InfF8dIbedUw36Mh4zOX720wz26KuPnnos1cQpzr29hk=
X-Received: by 2002:a05:600c:3781:b0:3a6:804a:afc with SMTP id
 o1-20020a05600c378100b003a6804a0afcmr8868349wmr.27.1665118299573; Thu, 06 Oct
 2022 21:51:39 -0700 (PDT)
MIME-Version: 1.0
References: <CADY+DPLf10UtUWE7Y9zZvN0NRFkGtV7ah3dg8t4wYWrF=8R2LQ@mail.gmail.com>
In-Reply-To: <CADY+DPLf10UtUWE7Y9zZvN0NRFkGtV7ah3dg8t4wYWrF=8R2LQ@mail.gmail.com>
From: dega kiran <degakiran05@gmail.com>
Date: Fri, 7 Oct 2022 10:21:00 +0530
Message-ID: <CADY+DPK7HQBYCPNoRf5KW6Zaqx6bF8fUrtywiR49zXiWkiC+zw@mail.gmail.com>
Subject: Re: Free Rtos porting on XEN
To: xen-devel@lists.xenproject.org, 
	Stefano Stabellini <sstabellini@kernel.org>
Cc: ulien Grall <julien@xen.org>
Content-Type: multipart/alternative; boundary="000000000000c1520005ea6a906a"

--000000000000c1520005ea6a906a
Content-Type: text/plain; charset="UTF-8"

Hi Stefano Stabellini ,

Thanks for the reply.

We are currently working on *Raspberry PI 4* can you help us how we can
port *Xen with FreeRtos *on Raspberry PI4.

Is there any reference I can go through for porting Xen with FreeRtos on
Raspberry PI4.?


Thanks and regards,
Dega.

On Tue, Oct 4, 2022 at 9:48 AM dega kiran <degakiran05@gmail.com> wrote:

> Hi ,
>
> I am trying to port FREERtos on XEN . But not getting any
> concrete information for porting.
>
> I am following https://github.com/GaloisInc/FreeRTOS-Xen
>
> but getting a lot of errors.
>
> Please Let me know how to follow the porting process.
>
>
> Thank you,
> Dega.
>
>

--000000000000c1520005ea6a906a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Stefano Stabellini ,<div><br></div><div>Thanks for=
 the reply.</div><div><br></div><div>We are currently working on <b>Raspber=
ry=C2=A0PI 4</b> can you help us how we can port <b>Xen with FreeRtos </b>o=
n Raspberry=C2=A0PI4.</div><div><br></div><div>Is there any reference I can=
 go through for porting Xen with FreeRtos on Raspberry=C2=A0PI4.?</div><div=
><br></div><div><br></div><div>Thanks and regards,</div><div>Dega.=C2=A0</d=
iv></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_att=
r">On Tue, Oct 4, 2022 at 9:48 AM dega kiran &lt;<a href=3D"mailto:degakira=
n05@gmail.com">degakiran05@gmail.com</a>&gt; wrote:<br></div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi ,<div><br></div><di=
v>I am trying to port FREERtos=C2=A0on XEN . But not getting any concrete=
=C2=A0information for porting.</div><div><br></div><div>I am following=C2=
=A0<a href=3D"https://github.com/GaloisInc/FreeRTOS-Xen" dir=3D"ltr" rel=3D=
"noopener nofollow noreferrer" style=3D"text-decoration-line:none;backgroun=
d:rgba(32,33,36,0.04);font-size:14px;margin:0px;padding:0px;vertical-align:=
baseline;font-family:Roboto,sans-serif;white-space:pre-wrap" target=3D"_bla=
nk">https://github.com/GaloisInc/FreeRTOS-Xen</a></div><div><br></div><div>=
but getting a lot of errors.</div><div><br></div><div>Please Let me know ho=
w to follow the porting process.</div><div><br></div><div><br></div><div>Th=
ank you,</div><div>Dega.</div><div><br></div></div>
</blockquote></div>

--000000000000c1520005ea6a906a--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 05:17:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 05:17:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417379.662055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfk1-0007RP-Rk; Fri, 07 Oct 2022 05:17:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417379.662055; Fri, 07 Oct 2022 05:17:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfk1-0007RI-O7; Fri, 07 Oct 2022 05:17:45 +0000
Received: by outflank-mailman (input) for mailman id 417379;
 Fri, 07 Oct 2022 05:17:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogfk0-0007RC-4U
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 05:17:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e95b6f7-45ff-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 07:17:42 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1CE761F8CA;
 Fri,  7 Oct 2022 05:17:42 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD9DA13345;
 Fri,  7 Oct 2022 05:17:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 5dRBMHW2P2PgLAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 05:17:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e95b6f7-45ff-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665119862; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Zrm6Wc+cYsGICXIrvOSQaUWN6L6oSr49mpVFNBqOZrg=;
	b=XA0ODdRJ+yVw3qcB6zwsGKKwVieknSmf0qC7HnLqfoEmS2wItOP0HWIsk79OyiB/HOUyU9
	jXbug179Mfkjxo3huHtS5FIlLX1kZxwnGr3fIArbnohoTvNjWqF81+5+vYiQLwN4NsK8rf
	e/Lskrmn/+lgL/2nn/yGdAZ0A8H8BAs=
Message-ID: <9aa1e6ba-a153-8dfa-ce28-3ab78b26c6e4@suse.com>
Date: Fri, 7 Oct 2022 07:17:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 0/2] xen/gntdev: Fixes for leaks and VMA splitting
Content-Language: en-US
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221002222006.2077-1-m.v.b@runbox.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------XVXLrARPWfnvGr02GkSvkKP9"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------XVXLrARPWfnvGr02GkSvkKP9
Content-Type: multipart/mixed; boundary="------------8CduX9LunJEd0aizjbOGzcP3";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
Message-ID: <9aa1e6ba-a153-8dfa-ce28-3ab78b26c6e4@suse.com>
Subject: Re: [PATCH v2 0/2] xen/gntdev: Fixes for leaks and VMA splitting
References: <20221002222006.2077-1-m.v.b@runbox.com>
In-Reply-To: <20221002222006.2077-1-m.v.b@runbox.com>

--------------8CduX9LunJEd0aizjbOGzcP3
Content-Type: multipart/mixed; boundary="------------MS0Hml100OrkEs5C7vmMaYEN"

--------------MS0Hml100OrkEs5C7vmMaYEN
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDMuMTAuMjIgMDA6MjAsIE0uIFZlZmEgQmljYWtjaSB3cm90ZToNCj4gSGkgYWxsLA0K
PiANCj4gRmlyc3Qgb2YgYWxsLCBzb3JyeSBmb3IgdGhlIGRlbGF5IQ0KPiANCj4gVGhlc2Ug
cGF0Y2hlcyBjb250aW51ZSB0aGUgY29kZSByZXZpZXcgZm9yIHRoZSBmb2xsb3dpbmcgcGF0
Y2hlczoNCj4gICAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIwOTEy
MDQwMDAyLjE5ODE5MS0xLW0udi5iQHJ1bmJveC5jb20vdC8jdQ0KPiANCj4gVGhlIG9yaWdp
bmFsIGRlc2NyaXB0aW9uIG9mIHRoZSBwYXRjaCBzZXQgaXMgYXMgZm9sbG93czoNCj4gDQo+
ICAgICJUaGUgY2hhbmdlcyBpbiB0aGlzIHBhdGNoIHNlcmllcyBpbnRlbmQgdG8gZml4IHRo
ZSBYZW4gZ3JhbnQgZGV2aWNlDQo+ICAgIGRyaXZlciwgc28gdGhhdCBncmFudCBtYXBwaW5n
IGxlYWtzIGNhdXNlZCBieSBwYXJ0aWFsbHkgZmFpbGVkIGdyYW50DQo+ICAgIG1hcHBpbmcg
b3BlcmF0aW9ucyBhcmUgYXZvaWRlZCB3aXRoIHRoZSBmaXJzdCBwYXRjaCwgYW5kIHNvIHRo
YXQgdGhlDQo+ICAgIHNwbGl0dGluZyBvZiBWTUFzIGRvZXMgbm90IHJlc3VsdCBpbiBpbmNv
cnJlY3RseSB1bm1hcHBlZCBncmFudCBwYWdlcw0KPiAgICB3aXRoIHRoZSBzZWNvbmQgcGF0
Y2guIFRoZSBzZWNvbmQgcGF0Y2ggYWxzbyBwcmV2ZW50cyBhIHNpbWlsYXIgaXNzdWUNCj4g
ICAgaW4gYSBkb3VibGUtbWFwcGluZyBzY2VuYXJpbywgd2hlcmUgbW1hcCgpIGlzIHVzZWQg
d2l0aCBNQVBfRklYRUQgdG8NCj4gICAgbWFwIGdyYW50cyBvdmVyIGFuIGV4aXN0aW5nIG1h
cHBpbmcgY3JlYXRlZCB3aXRoIHRoZSBzYW1lIGdyYW50cywgYW5kDQo+ICAgIHdoZXJlIGdy
YW50IHBhZ2VzIGFyZSB1bm1hcHBlZCBpbmNvcnJlY3RseSBhcyB3ZWxsLiINCj4gDQo+IEEg
c3VtbWFyeSBvZiB0aGUgY2hhbmdlcyBmcm9tIHYxIGlzIGFzIGZvbGxvd3M6DQo+IC0gQWRk
cmVzc2VkIEp1ZXJnZW4ncyBjb2RlIHJldmlldyBjb21tZW50IHJlZ2FyZGluZyB0aGUgZmly
c3QgcGF0Y2guDQo+IC0gQW1lbmRlZCB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIHNlY29uZCBw
YXRjaCB0byBub3RlIHRoYXQgdGhlIGRlc2NyaWJlZA0KPiAgICBpc3N1ZXMgYXJlIGVuY291
bnRlcmVkIHdpdGggUFYgZG9tYWlucy4NCj4gDQo+IFZlcmlmaWNhdGlvbiBub3RlczoNCj4g
DQo+IC0gSSBoYXZlIHRlc3RlZCB0aGVzZSBjb21taXRzIG9uIHRvcCBvZiBMaW51eCB2NS4x
NS43MCBhbmQgdjUuMTUuNzEsIGFuZA0KPiAgICBJIHZlcmlmaWVkIHRoYXQgdGhleSBjb21w
aWxlIHN1Y2Nlc3NmdWxseSBvbiB0b3Agb2YgdGhlIHRhZw0KPiAgICAibmV4dC0yMDIyMDkz
MCIsIHdoaWNoIGNvcnJlc3BvbmRzIHRvIHRoZSBiYXNlIGNvbW1pdCBJRCBpbmNsdWRlZCBh
dA0KPiAgICB0aGUgYm90dG9tIG9mIHRoaXMgZS1tYWlsLg0KPiANCj4gLSBNeSB0ZXN0cyBj
b25zaXN0IG9mIHVzaW5nIGEga2VybmVsIHdpdGggUXViZXMgT1MgdjQuMSdzIHBhdGNoZXMg
YW5kDQo+ICAgIHRoZXNlIHBhdGNoZXMgb24gbXkgbWFpbiBjb21wdXRlciBmb3IgZGF5LXRv
LWRheSB0YXNrcywgaW4gY29uanVuY3Rpb24NCj4gICAgd2l0aCBRdWJlcyBPUydzIHZlcnNp
b24gb2YgdGhlIFhlbiBoeXBlcnZpc29yIHY0LjE0LjUsIHdpdGggdGhlIGxhdHRlcg0KPiAg
ICBjdXN0b20tY29tcGlsZWQgd2l0aCBDT05GSUdfREVCVUcuDQo+IA0KPiAtIEkgdXNlZCBh
IHRlc3QgcHJvZ3JhbSB0aGF0IHZlcmlmaWVzIHRoZSBmb2xsb3dpbmcgc2NlbmFyaW9zIHdp
dGggYW4NCj4gICAgdW5wcml2aWxlZ2VkIHBhcmF2aXJ0dWFsaXplZCAoUFYpIFhlbiBkb21h
aW46DQo+IA0KPiAgICAtIEEgcHJvZ3JhbSBtbWFwKClzIHR3byBwYWdlcyBmcm9tIGFub3Ro
ZXIgWGVuIGRvbWFpbiBhbmQgbXVubWFwKClzDQo+ICAgICAgdGhlIHBhZ2VzIG9uZSBieSBv
bmUuIFRoaXMgdXNlZCB0byByZXN1bHQgaW4gaW1wbGljaXQgdW5tYXAgZXJyb3JzDQo+ICAg
ICAgdG8gYmUgcmVwb3J0ZWQgYnkgWGVuIGFuZCBhIGdlbmVyYWwgcHJvdGVjdGlvbiBmYXVs
dCB0byBiZSB0cmlnZ2VyZWQNCj4gICAgICBieSBYZW4gaW4gdGhlIGFmZmVjdGVkIGRvbWFp
biwgYnV0IG5vdyB3b3JrcyBhcyBleHBlY3RlZC4NCj4gICAgLSBBIHByb2dyYW0gbW1hcCgp
cyB0d28gcGFnZXMgZnJvbSBhbm90aGVyIFhlbiBkb21haW4gYW5kIHRoZW4NCj4gICAgICBh
dHRlbXB0cyB0byByZW1hcCAodmlhIE1BUF9GSVhFRCkgdGhlIHNhbWUgbWFwcGluZyBhZ2Fp
biBvdmVyIHRoZQ0KPiAgICAgIHNhbWUgdmlydHVhbCBhZGRyZXNzLiBUaGlzIHVzZWQgdG8g
cmVzdWx0IGluIHNpbWlsYXIgaXNzdWVzDQo+ICAgICAgKGltcGxpY2l0IHVubWFwIGVycm9y
cyBhbmQgZ2VuZXJhbCBwcm90ZWN0aW9uIGZhdWx0KSwgYnV0IG5vdyBpcw0KPiAgICAgIHJl
amVjdGVkIGJ5IHRoZSBrZXJuZWwuDQo+ICAgIC0gQSBwcm9ncmFtIG1tYXAoKXMgdHdvIHBh
Z2VzIGZyb20gYW5vdGhlciBYZW4gZG9tYWluIGFuZCB0aGVuDQo+ICAgICAgYXR0ZW1wdHMg
dG8gbW1hcCgpIHRoZSBzYW1lIG1hcHBpbmcgYWdhaW4gdG8gYSBkaWZmZXJlbnQgdmlydHVh
bA0KPiAgICAgIGFkZHJlc3MsIGJ5IHBhc3NpbmcgTlVMTCBhcyBtbWFwKCkncyBmaXJzdCBh
cmd1bWVudC4gVGhpcyB1c2VkIHRvIGJlDQo+ICAgICAgcmVqZWN0ZWQgYnkgdGhlIGtlcm5l
bCwgYW5kIGl0IGNvbnRpbnVlcyB0byBiZSByZWplY3RlZCBieSB0aGUNCj4gICAgICBrZXJu
ZWwuDQo+IA0KPiAtIFVucHJpdmlsZWdlZCBQVkggWGVuIGRvbWFpbnMgd2VyZSBhbHNvIHNh
bml0eSB0ZXN0ZWQgd2l0aCB0aGUgc2FtZQ0KPiAgICB0ZXN0IHByb2dyYW0uIEkgc2hvdWxk
IG5vdGUgdGhhdCBQVkggZG9tYWlucyB3b3JrZWQgYXMgZXhwZWN0ZWQNCj4gICAgd2l0aG91
dCB0aGVzZSBwYXRjaGVzIHRvby4NCj4gDQo+IC0gRmluYWxseSwgSSBoYXZlIHZlcmlmaWVk
IHRoYXQgdGhlIG9yaWdpbmFsICJnLmUuIDB4MTIzNCBzdGlsbCBwZW5kaW5nIg0KPiAgICBp
c3N1ZSBkb2VzIG5vdCBhcHBlYXIgYWZ0ZXIgcmFwaWRseSByZXNpemluZyBHVUkgd2luZG93
cyBpbiBRdWJlcyBPUw0KPiAgICB2NC4xLg0KDQpTZXJpZXMgcHVzaGVkIHRvIHhlbi90aXAu
Z2l0IGZvci1saW51cy02LjENCg0KDQpKdWVyZ2VuDQoNCg==
--------------MS0Hml100OrkEs5C7vmMaYEN
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------MS0Hml100OrkEs5C7vmMaYEN--

--------------8CduX9LunJEd0aizjbOGzcP3--

--------------XVXLrARPWfnvGr02GkSvkKP9
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/tnUFAwAAAAAACgkQsN6d1ii/Ey9s
9wf+PcgWSXtUZ0T6HsJ/UghG07f8HEcW11vT6tZ3+FjPs2GDMiIJfvpAnlys6Syh0DWST2MK4VC+
JJzLvwCkNkPfMEFdohWuRtLyju3LStD4NcVQ4vdFM/U9a36iBNpb/+H+1SrSgy2Lm47GQGCyV/fO
4T34mtZy5q4Cyx/2FswlK1eOb5hDjpEum6rgl1rWgz+zmEs+zki6dFHppWFLYzFvMKmyAkBGXtGc
t6kBq2ajBYS5C7zMTyHDHuE7OrB/HWu3PyYiERZOQ9P8WRXtLJ9rzL2/HHHKPPBKeJ+CUNlt6A6+
tOpDxnlqyjMNFgRe8c+l1k8Bk2hN0skCppcBeoOHlA==
=Eelx
-----END PGP SIGNATURE-----

--------------XVXLrARPWfnvGr02GkSvkKP9--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 05:18:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 05:18:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417382.662066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfkX-0007sJ-3c; Fri, 07 Oct 2022 05:18:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417382.662066; Fri, 07 Oct 2022 05:18:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogfkX-0007sC-0O; Fri, 07 Oct 2022 05:18:17 +0000
Received: by outflank-mailman (input) for mailman id 417382;
 Fri, 07 Oct 2022 05:18:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogfkV-0007RC-Fb
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 05:18:15 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 71b64ba8-45ff-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 07:18:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 614B61F8CC;
 Fri,  7 Oct 2022 05:18:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A60013345;
 Fri,  7 Oct 2022 05:18:14 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id p1oCCZa2P2MELQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 05:18:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71b64ba8-45ff-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665119894; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=oO32dF6LSGJv6QRy7bnLXN3JnA/dYMc641Lz3P1THdU=;
	b=tc1UQdTC+Mc6aFLukkGaKEYRP2HnXdqlRnQspoF9gnJopD+s2sIcFfHK1ZOkVcJ7TcgkMf
	soCKJGkBlhuC78IpOLqqYKct2+tDscKYxiKVl/7DOmedkFDekkxX3XnO6i/jS5q9ZHr84A
	I0VdzGz41w1FbrNumjeNdkhcf9Y+6js=
Message-ID: <c051bd08-cc4c-ec09-6c69-92797433fcf2@suse.com>
Date: Fri, 7 Oct 2022 07:18:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen/xenbus: Fix spelling mistake "hardward" -> "hardware"
Content-Language: en-US
To: Colin Ian King <colin.i.king@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221004160639.154421-1-colin.i.king@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221004160639.154421-1-colin.i.king@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------WpUMG8nIhzBhKfw1vtyVkMg0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------WpUMG8nIhzBhKfw1vtyVkMg0
Content-Type: multipart/mixed; boundary="------------A04Nxt4ZlfcWpTo61rjd4kIN";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Colin Ian King <colin.i.king@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <c051bd08-cc4c-ec09-6c69-92797433fcf2@suse.com>
Subject: Re: [PATCH] xen/xenbus: Fix spelling mistake "hardward" -> "hardware"
References: <20221004160639.154421-1-colin.i.king@gmail.com>
In-Reply-To: <20221004160639.154421-1-colin.i.king@gmail.com>

--------------A04Nxt4ZlfcWpTo61rjd4kIN
Content-Type: multipart/mixed; boundary="------------2uxkbQ2epXfomdpOphrV0889"

--------------2uxkbQ2epXfomdpOphrV0889
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDQuMTAuMjIgMTg6MDYsIENvbGluIElhbiBLaW5nIHdyb3RlOg0KPiBUaGVyZSBpcyBh
IHNwZWxsaW5nIG1pc3Rha2UgaW4gdGhlIG1vZHVsZSBkZXNjcmlwdGlvbi4gRml4IGl0Lg0K
PiANCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmkua2luZ0BnbWFp
bC5jb20+DQoNClB1c2hlZCB0byB4ZW4vdGlwLmdpdCBmb3ItbGludXMtNi4xDQoNCg0KSnVl
cmdlbg0KDQo=
--------------2uxkbQ2epXfomdpOphrV0889
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2uxkbQ2epXfomdpOphrV0889--

--------------A04Nxt4ZlfcWpTo61rjd4kIN--

--------------WpUMG8nIhzBhKfw1vtyVkMg0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/tpUFAwAAAAAACgkQsN6d1ii/Ey+T
rgf+JnzW+s3I5PCNTcTrCVZ+oWOcvQ+P4iEsjhyZKdAY407567wiKGiNkP84jXoSSFp5GieMIsVc
eoy1cBi/MAl9oWl7ATdK9UWn5ulK3VMpZrbzUg9AMHMV3bzIbJR9c98aoF4b4tHcXXbjNtn2TfiR
EbdrsV2WsMUMk9Z15TsFqtC4p+gK27IiP+6PpClPfM+P8iANHrVDQ51c/FGYHXiPZV6pnQCwmglr
35hVBXgKOGki+wRvqWwnOI56GIp99tPpIwxMX9nDaiQDDL+Bbl8JrzGMTIjxwI0PCooX4p3Mm2n3
S5t/28O4Cz0AjYWk8sunghu8x7L2fAdm5UqcsSTiKA==
=JOTh
-----END PGP SIGNATURE-----

--------------WpUMG8nIhzBhKfw1vtyVkMg0--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 05:19:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 05:19:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417390.662076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogflk-00007z-Ds; Fri, 07 Oct 2022 05:19:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417390.662076; Fri, 07 Oct 2022 05:19:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogflk-00007r-BC; Fri, 07 Oct 2022 05:19:32 +0000
Received: by outflank-mailman (input) for mailman id 417390;
 Fri, 07 Oct 2022 05:19:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogfli-00007d-8X
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 05:19:30 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e3cf07e-45ff-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 07:19:29 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 22AF22199F;
 Fri,  7 Oct 2022 05:19:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D8B9613345;
 Fri,  7 Oct 2022 05:19:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id P19aM+C2P2OBLQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 05:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e3cf07e-45ff-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665119969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Ejzy7TEHov+nIAMCI1XFyhDUZZW5+GOk87DJxP7CNaY=;
	b=Aqgt+IPCyj21zORa/HFyxvmEVfh8M63qWr5hDdHZfA9YZu5GgNckohRuFvk33/c/WC6KGg
	tdQSJXFMzL1Ux+lGa1/R9oyXpFsZZCOjccMDXR0wbL9Jj8IB883apnFhWfDo0NwyUPL4qP
	kitcvUTKNNWkAfX6ypDh6OjSZAJ6pwo=
Message-ID: <47853f65-0fce-6ee1-f6ab-115ab48df7a3@suse.com>
Date: Fri, 7 Oct 2022 07:19:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 0/2] Misc fixes for Xen grant DMA-mapping layer
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20221005174823.1800761-1-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221005174823.1800761-1-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------SOsSx1a3rFmS0YD7wzBcZ2on"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------SOsSx1a3rFmS0YD7wzBcZ2on
Content-Type: multipart/mixed; boundary="------------qtAE5mJL6H3HlkunW5gNx0pW";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <47853f65-0fce-6ee1-f6ab-115ab48df7a3@suse.com>
Subject: Re: [PATCH 0/2] Misc fixes for Xen grant DMA-mapping layer
References: <20221005174823.1800761-1-olekstysh@gmail.com>
In-Reply-To: <20221005174823.1800761-1-olekstysh@gmail.com>

--------------qtAE5mJL6H3HlkunW5gNx0pW
Content-Type: multipart/mixed; boundary="------------ifS0aZNKw8d0gSh2PMBv6ACs"

--------------ifS0aZNKw8d0gSh2PMBv6ACs
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDUuMTAuMjIgMTk6NDgsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBIZWxsbyBhbGwuDQo+IA0KPiBUaGVzZSBhcmUgc2V2ZXJhbCBmaXhlcyBJIGNv
bGxlY3RlZCB3aGVuIHBsYXlpbmcgd2l0aCB2aXJ0aW8tbmV0IGRldmljZQ0KPiB1c2luZyBY
ZW4gZ3JhbnQgbWFwcGluZ3MuDQo+IA0KPiBUZXN0ZWQgd2l0aCBib3RoIHZpcnRpby1ibGsg
YW5kIHZpcnRpby1uZXQgZGV2aWNlcy4NCj4gDQo+IE9sZWtzYW5kciBUeXNoY2hlbmtvICgy
KToNCj4gICAgeGVuL3ZpcnRpbzogRml4IG5fcGFnZXMgY2FsY3VsYXRpb24gaW4geGVuX2dy
YW50X2RtYV9tYXAodW5tYXApX3BhZ2UoKQ0KPiAgICB4ZW4vdmlydGlvOiBGaXggcG90ZW50
aWFsIGRlYWRsb2NrIHdoZW4gYWNjZXNzaW5nDQo+ICAgICAgeGVuX2dyYW50X2RtYV9kZXZp
Y2VzDQo+IA0KPiAgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyB8IDI5ICsrKysrKysr
KysrKysrKysrKysrKystLS0tLS0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlv
bnMoKyksIDcgZGVsZXRpb25zKC0pDQo+IA0KDQpTZXJpZXMgcHVzaGVkIHRvIHhlbi90aXAu
Z2l0IGZvci1saW51cy02LjENCg0KDQpKdWVyZ2VuDQo=
--------------ifS0aZNKw8d0gSh2PMBv6ACs
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------ifS0aZNKw8d0gSh2PMBv6ACs--

--------------qtAE5mJL6H3HlkunW5gNx0pW--

--------------SOsSx1a3rFmS0YD7wzBcZ2on
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/tuAFAwAAAAAACgkQsN6d1ii/Ey8G
bgf/du6WhlvN6TM8LUThjNHkx1yKlPgAth564txOMqLFAd+WVYglM6Gmgq+lqLsqlsU8jlyjv+Po
lKgmgYLQSXiiFAjxl1ktGP0jgNszMoCoaY2x7rNMwiC861uZ9T/WSxGfsW9Cfi4Z2tb6Phn5aK3o
Smi+6sW/QKNq82DLHDxlubXBZokB8ZtM8Z3t3Tgag6Mrw/3/Ok5slFDJmA+B0kKQ8xCHdRjSKQFN
yNGEErZyuJljV0g+wPLcTV0m9HVE4Swp3xz14PtS+xVyaOG34B3CpC4DsrbQLXLD6XxzIqMpeLR2
Po1PTRmD6c6/L1lE05O8yPhifFaVDLsVgebxuaXnqw==
=Pjss
-----END PGP SIGNATURE-----

--------------SOsSx1a3rFmS0YD7wzBcZ2on--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 05:57:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 05:57:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417399.662088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oggMI-0004Yv-EM; Fri, 07 Oct 2022 05:57:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417399.662088; Fri, 07 Oct 2022 05:57:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oggMI-0004Yo-BM; Fri, 07 Oct 2022 05:57:18 +0000
Received: by outflank-mailman (input) for mailman id 417399;
 Fri, 07 Oct 2022 05:57:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oggMG-0004Yi-VM
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 05:57:17 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e47ea4b0-4604-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 07:57:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 2A6B31F8C6;
 Fri,  7 Oct 2022 05:57:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E273E13A9A;
 Fri,  7 Oct 2022 05:57:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id TGbXNbm/P2N3OgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 05:57:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e47ea4b0-4604-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665122234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3Sk/Wai7OL6bCl05p5gxU/lW31/U1SnkzvU73Y4Wl1U=;
	b=fZ/soGn8d/ZTWVptwhYeZz8cqBRToxqb6C4hkyEJD6Fm6dcfdAMgNqM2Upt5R/rqQx7lVz
	XkhGt+1dEdwJ7Hz+iQyU4Ao5FHoAR/I+FyTclssAgFa9ceGuGSoKC6teDqqdoOhydHqjro
	zIh+0M4iKz7mPWbywWSjUIG1OiDKDPo=
Message-ID: <014e7036-5daf-6465-663c-b690d6f719ee@suse.com>
Date: Fri, 7 Oct 2022 07:57:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20221006174804.2003029-1-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
In-Reply-To: <20221006174804.2003029-1-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------vPlS10kX7W0yziMi5kKHRSH0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------vPlS10kX7W0yziMi5kKHRSH0
Content-Type: multipart/mixed; boundary="------------M20S0RLBbR0aQSj1w20tEhYl";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <014e7036-5daf-6465-663c-b690d6f719ee@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
References: <20221006174804.2003029-1-olekstysh@gmail.com>
In-Reply-To: <20221006174804.2003029-1-olekstysh@gmail.com>

--------------M20S0RLBbR0aQSj1w20tEhYl
Content-Type: multipart/mixed; boundary="------------wjbTJXDYWf4092hEeeVUGVdn"

--------------wjbTJXDYWf4092hEeeVUGVdn
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDYuMTAuMjIgMTk6NDgsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBVc2UgdGhlIHNhbWUgInhlbi1ncmFudC1kbWEiIGRldmljZSBjb25jZXB0IChi
YXNlZCBvbiBnZW5lcmljIElPTU1VDQo+IGRldmljZS10cmVlIGJpbmRpbmdzKSBmb3IgdGhl
IFBDSSBkZXZpY2VzIGJlaGluZCBkZXZpY2UtdHJlZSBiYXNlZA0KPiBQQ0kgSG9zdCBjb250
cm9sbGVyLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9s
ZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPiAtLS0NCj4gU2xpZ2h0bHkgUkZDLiBU
aGlzIGlzIG5lZWRlZCB0byBzdXBwb3J0IFhlbiBncmFudCBtYXBwaW5ncyBmb3IgdmlydGlv
LXBjaSBkZXZpY2VzDQo+IG9uIEFybSBhdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUuIFRo
ZSBYZW4gdG9vbHN0YWNrIHNpZGUgaXMgbm90IHB1Ymxpc2hlZCB5ZXQuDQo+IEhlcmUsIGZv
ciBQQ0kgZGV2aWNlcyB3ZSB1c2UgdGhlIHNhbWUgd2F5IHRvIHBhc3MgYmFja2VuZCBkb21p
ZCB0byB0aGUgZ3Vlc3QgYXMgZm9yDQo+IHBsYXRmb3JtIGRldmljZXMuDQoNCkkgc2hvdWxk
IG1lbnRpb24gd2UgZGVjaWRlZCBhdCB0aGUgWGVuIFN1bW1pdCwgdGhhdCBJIHdpbGwgc3Rh
cnQgYSB0cnkgdG8NCm1vZGlmeSB0aGUgdmlydGlvIHNwZWMgdG8gaW5jbHVkZSB0aGUgYmFj
a2VuZCBpZCAoZG9taWQgaW4gdGhlIFhlbiBjYXNlKQ0KaW4gdGhlIGRldmljZSBpbmRlcGVu
ZGVudCBjb25maWcgcGFydC4NCg0KQXMgdGhpcyB3aWxsIHRha2Ugc29tZSB0aW1lIHRvIGJl
IGFjY2VwdGVkIChpZiBldmVyKSwgb3RoZXIgbWVhbnMgdG8NCnNwZWNpZnkgdGhlIGJhY2tl
bmQgZG9taWQgYXJlIG5lZWRlZCB1bnRpbCB0aGVuLiBEVCBpcyBvbmUgcG9zc2liaWxpdHkN
CihhdCBsZWFzdCBvbiBBcm0pLCB3aGlsZSBYZW5zdG9yZSBpcyB0aGUgd2F5IHRvIGdvIGZv
ciBzZXR1cHMgd2l0aCBhDQpYZW4gdG9vbHN0YWNrLg0KDQoNCkp1ZXJnZW4NCg==
--------------wjbTJXDYWf4092hEeeVUGVdn
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------wjbTJXDYWf4092hEeeVUGVdn--

--------------M20S0RLBbR0aQSj1w20tEhYl--

--------------vPlS10kX7W0yziMi5kKHRSH0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/v7kFAwAAAAAACgkQsN6d1ii/Ey/a
oAf+M7BYmmsyCqqYqE/sUb5gWvcFBqjmeJJpq6IlyY3JTUc2Zew9h850V2ijUDdQ50bIa2hML+g9
jwxuoohx8JC2z7kI6E6/+zs+1hvn3C9hU6uxgr1p0kRZWq18TRITThO4frBIT1vp6OuGYLgUD8qp
Stlcqth2+veKUxYiF0d+dhOI2IkwSkRVVYD0Lm0Bga836ogRevgfQWWTFpPnIREPvOJ7DaqCEaNW
QiCWCT4bePhpAHxRyOzDGh9+sNCrqiPzpPfgeo0Akps0bw3y1Lr6UTGJwx5dbyZFk/z1j50e9ehE
MoyYquZiuqzJQbydkRTik0sUfFW5agQHdm0MNz9fOg==
=LQRo
-----END PGP SIGNATURE-----

--------------vPlS10kX7W0yziMi5kKHRSH0--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 06:41:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 06:41:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417406.662099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3M-0001OK-Md; Fri, 07 Oct 2022 06:41:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417406.662099; Fri, 07 Oct 2022 06:41:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3M-0001OD-Jr; Fri, 07 Oct 2022 06:41:48 +0000
Received: by outflank-mailman (input) for mailman id 417406;
 Fri, 07 Oct 2022 06:41:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogh3L-0001O7-M5
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 06:41:47 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d094e18-460b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 08:41:46 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1DB8C218FC;
 Fri,  7 Oct 2022 06:41:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A588B13A3D;
 Fri,  7 Oct 2022 06:41:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cy/WJinKP2PjSQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 06:41:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d094e18-460b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665124906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=fjnPZrMU8HQlRaEL1NbINikk37iX63+Ug6moJ46OZmk=;
	b=hYTSewCYiI+AB2wh7D9K8770bh/oZfm6y1fNcNhyF18xnoHpjxv9vyOEKHo/JgmjOEUkSr
	ejlzKkTwdN78gU9FbLy5mRYt+ERVN2a8+E9cpQeoTYHfRD2iIUWanZ7JciAtrBVkEUYRfZ
	t7xafpoAia1OgwgajW+TLytKRgpk9x0=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH v2 0/3] xen/virtio: support grant based virtio on x86
Date: Fri,  7 Oct 2022 08:41:40 +0200
Message-Id: <20221007064143.10049-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add basic support for virtio with grants on x86 by defaulting the
backend to be in dom0 in the case the guest kernel was built with
CONFIG_XEN_VIRTIO_FORCE_GRANT.

Juergen Gross (3):
  xen/virtio: restructure xen grant dma setup
  xen/virtio: use dom0 as default backend for
    CONFIG_XEN_VIRTIO_FORCE_GRANT
  xen/virtio: enable grant based virtio on x86

 arch/x86/xen/enlighten_hvm.c |  2 +-
 arch/x86/xen/enlighten_pv.c  |  2 +-
 drivers/xen/grant-dma-ops.c  | 83 +++++++++++++++++++++++++-----------
 include/xen/xen-ops.h        |  6 +++
 4 files changed, 65 insertions(+), 28 deletions(-)

-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 06:41:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 06:41:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417407.662110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3S-0001ek-Uj; Fri, 07 Oct 2022 06:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417407.662110; Fri, 07 Oct 2022 06:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3S-0001ed-RT; Fri, 07 Oct 2022 06:41:54 +0000
Received: by outflank-mailman (input) for mailman id 417407;
 Fri, 07 Oct 2022 06:41:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogh3R-0001dz-8V
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 06:41:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 201bbc5b-460b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 08:41:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id ADBB121921;
 Fri,  7 Oct 2022 06:41:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7F71013A3D;
 Fri,  7 Oct 2022 06:41:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UBd7HS/KP2PtSQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 06:41:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 201bbc5b-460b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665124911; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ATUfGhJjIWA/9t9RtmlJe59T23l1xwtAuvFy8Qdhysc=;
	b=VZymo9SzuTyuOSp5urlRfNSiEx4gXIMPflLBFlLvQfXmSFopNhLkTP+odm0/joyUQnp904
	9EZY/pXtbpjIezkZQxkJ4o1zbZJ5km0Cr9HMudqGeyXvffAByNWZ7rwUeWuZHJH66QhKc7
	4ua3fNZgDG/8O1CcuN9IA9q09m0+irw=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 1/3] xen/virtio: restructure xen grant dma setup
Date: Fri,  7 Oct 2022 08:41:41 +0200
Message-Id: <20221007064143.10049-2-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221007064143.10049-1-jgross@suse.com>
References: <20221007064143.10049-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In order to prepare supporting other means than device tree for
setting up virtio devices under Xen, restructure the functions
xen_is_grant_dma_device() and xen_grant_setup_dma_ops() a little bit.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Tested-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> # Arm64 only
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
---
V2:
- rename xen_dt_grant_setup_dma_ops() (Oleksandr Tyshchenko)
---
 drivers/xen/grant-dma-ops.c | 68 +++++++++++++++++++++++--------------
 1 file changed, 43 insertions(+), 25 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 8973fc1e9ccc..646ca913c05c 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -273,22 +273,28 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
-bool xen_is_grant_dma_device(struct device *dev)
+static bool xen_is_dt_grant_dma_device(struct device *dev)
 {
 	struct device_node *iommu_np;
 	bool has_iommu;
 
-	/* XXX Handle only DT devices for now */
-	if (!dev->of_node)
-		return false;
-
 	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
-	has_iommu = iommu_np && of_device_is_compatible(iommu_np, "xen,grant-dma");
+	has_iommu = iommu_np &&
+		    of_device_is_compatible(iommu_np, "xen,grant-dma");
 	of_node_put(iommu_np);
 
 	return has_iommu;
 }
 
+bool xen_is_grant_dma_device(struct device *dev)
+{
+	/* XXX Handle only DT devices for now */
+	if (dev->of_node)
+		return xen_is_dt_grant_dma_device(dev);
+
+	return false;
+}
+
 bool xen_virtio_mem_acc(struct virtio_device *dev)
 {
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT))
@@ -297,45 +303,56 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
 	return xen_is_grant_dma_device(dev->dev.parent);
 }
 
-void xen_grant_setup_dma_ops(struct device *dev)
+static int xen_dt_grant_init_backend_domid(struct device *dev,
+					   struct xen_grant_dma_data *data)
 {
-	struct xen_grant_dma_data *data;
 	struct of_phandle_args iommu_spec;
 
-	data = find_xen_grant_dma_data(dev);
-	if (data) {
-		dev_err(dev, "Xen grant DMA data is already created\n");
-		return;
-	}
-
-	/* XXX ACPI device unsupported for now */
-	if (!dev->of_node)
-		goto err;
-
 	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
 			0, &iommu_spec)) {
 		dev_err(dev, "Cannot parse iommus property\n");
-		goto err;
+		return -ESRCH;
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
 			iommu_spec.args_count != 1) {
 		dev_err(dev, "Incompatible IOMMU node\n");
 		of_node_put(iommu_spec.np);
-		goto err;
+		return -ESRCH;
 	}
 
 	of_node_put(iommu_spec.np);
 
+	/*
+	 * The endpoint ID here means the ID of the domain where the
+	 * corresponding backend is running
+	 */
+	data->backend_domid = iommu_spec.args[0];
+
+	return 0;
+}
+
+void xen_grant_setup_dma_ops(struct device *dev)
+{
+	struct xen_grant_dma_data *data;
+
+	data = find_xen_grant_dma_data(dev);
+	if (data) {
+		dev_err(dev, "Xen grant DMA data is already created\n");
+		return;
+	}
+
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
 	if (!data)
 		goto err;
 
-	/*
-	 * The endpoint ID here means the ID of the domain where the corresponding
-	 * backend is running
-	 */
-	data->backend_domid = iommu_spec.args[0];
+	if (dev->of_node) {
+		if (xen_dt_grant_init_backend_domid(dev, data))
+			goto err;
+	} else {
+		/* XXX ACPI device unsupported for now */
+		goto err;
+	}
 
 	if (xa_err(xa_store(&xen_grant_dma_devices, (unsigned long)dev, data,
 			GFP_KERNEL))) {
@@ -348,6 +365,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	return;
 
 err:
+	devm_kfree(dev, data);
 	dev_err(dev, "Cannot set up Xen grant DMA ops, retain platform DMA ops\n");
 }
 
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 06:42:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 06:42:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417408.662120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3Y-0001yC-5w; Fri, 07 Oct 2022 06:42:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417408.662120; Fri, 07 Oct 2022 06:42:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3Y-0001y5-37; Fri, 07 Oct 2022 06:42:00 +0000
Received: by outflank-mailman (input) for mailman id 417408;
 Fri, 07 Oct 2022 06:41:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogh3W-0001dz-6k
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 06:41:58 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 237b29e6-460b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 08:41:57 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5BC7C21921;
 Fri,  7 Oct 2022 06:41:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 26A1513A3D;
 Fri,  7 Oct 2022 06:41:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id VkUHCDXKP2P2SQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 06:41:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 237b29e6-460b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665124917; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ubZ+4Ck86Ph/G26SuwNF8h0CjJlNbh0F0U0WIgCgLNk=;
	b=u0B1gOZKRfVtDSiWXK3FHZ+7ZuhS2wNNXD2scXaLTkjdp0U2MWi81cz5CIcqR4f3bUYv8g
	jBnNrjXqx/FvjTozEfvlu2sla1YODh2H6SsLXM8Wx9NXvu+jcHK0gNago1wWy0qFR2qe/S
	z8XGz3kjUOzbP5zxy3/AUWO6neU04g0=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 2/3] xen/virtio: use dom0 as default backend for CONFIG_XEN_VIRTIO_FORCE_GRANT
Date: Fri,  7 Oct 2022 08:41:42 +0200
Message-Id: <20221007064143.10049-3-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221007064143.10049-1-jgross@suse.com>
References: <20221007064143.10049-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

With CONFIG_XEN_VIRTIO_FORCE_GRANT set the default backend domid to 0,
enabling to use xen_grant_dma_ops for those devices.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
---
 drivers/xen/grant-dma-ops.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 646ca913c05c..c703b77b33c9 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -349,6 +349,9 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	if (dev->of_node) {
 		if (xen_dt_grant_init_backend_domid(dev, data))
 			goto err;
+	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
+		dev_info(dev, "Using dom0 as backend\n");
+		data->backend_domid = 0;
 	} else {
 		/* XXX ACPI device unsupported for now */
 		goto err;
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 06:42:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 06:42:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417409.662132 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3d-0002JV-Gc; Fri, 07 Oct 2022 06:42:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417409.662132; Fri, 07 Oct 2022 06:42:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogh3d-0002JO-CO; Fri, 07 Oct 2022 06:42:05 +0000
Received: by outflank-mailman (input) for mailman id 417409;
 Fri, 07 Oct 2022 06:42:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogh3c-0001O7-8Q
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 06:42:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2729d57f-460b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 08:42:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 49B921F8A8;
 Fri,  7 Oct 2022 06:42:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BF47A13A3D;
 Fri,  7 Oct 2022 06:42:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rb3eLDrKP2P+SQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 06:42:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2729d57f-460b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665124923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=S7rX4NNfG5xbGtkfHQ3yryrnm26fT7MI5fpGm+XeZVo=;
	b=StxRIPs7AKtt4D0aOz64z0LpwokqK4ZWIDpbns1hmPaE3IuoSO6t7p30tXIYHDHYMDSIve
	eSdTcsGlR/qc2tGcmsUYg/Ya6wjb4gLkx9+rmMkxmAEKGMsR80426ZF+eyUYbCclA2gsKE
	b9KQmEMxe5EKcqEuSNSMSFbWYWlYwRg=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 3/3] xen/virtio: enable grant based virtio on x86
Date: Fri,  7 Oct 2022 08:41:43 +0200
Message-Id: <20221007064143.10049-4-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20221007064143.10049-1-jgross@suse.com>
References: <20221007064143.10049-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use an x86-specific virtio_check_mem_acc_cb() for Xen in order to setup
the correct DMA ops.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- add missing PV check in xen_virtio_mem_acc() (Oleksandr Tyshchenko)
- add xen_virtio_restricted_mem_acc() stub (Oleksandr Tyshchenko)
---
 arch/x86/xen/enlighten_hvm.c |  2 +-
 arch/x86/xen/enlighten_pv.c  |  2 +-
 drivers/xen/grant-dma-ops.c  | 12 +++++++++++-
 include/xen/xen-ops.h        |  6 ++++++
 4 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c
index 1c1ac418484b..c1cd28e915a3 100644
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -212,7 +212,7 @@ static void __init xen_hvm_guest_init(void)
 		return;
 
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT))
-		virtio_set_mem_acc_cb(virtio_require_restricted_mem_acc);
+		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
 
 	init_hvm_pv_info();
 
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 9b1a58dda935..45b24c1b646a 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -112,7 +112,7 @@ static void __init xen_pv_init_platform(void)
 {
 	/* PV guests can't operate virtio devices without grants. */
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO))
-		virtio_set_mem_acc_cb(virtio_require_restricted_mem_acc);
+		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
 
 	populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));
 
diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index c703b77b33c9..63c3f0dac066 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -297,7 +297,7 @@ bool xen_is_grant_dma_device(struct device *dev)
 
 bool xen_virtio_mem_acc(struct virtio_device *dev)
 {
-	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT))
+	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain())
 		return true;
 
 	return xen_is_grant_dma_device(dev->dev.parent);
@@ -372,6 +372,16 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	dev_err(dev, "Cannot set up Xen grant DMA ops, retain platform DMA ops\n");
 }
 
+bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
+{
+	bool ret = xen_virtio_mem_acc(dev);
+
+	if (ret)
+		xen_grant_setup_dma_ops(dev->dev.parent);
+
+	return ret;
+}
+
 MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
 MODULE_AUTHOR("Juergen Gross <jgross@suse.com>");
 MODULE_LICENSE("GPL");
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index dae0f350c678..a34f4271a2e9 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -219,6 +219,7 @@ static inline void xen_preemptible_hcall_end(void) { }
 void xen_grant_setup_dma_ops(struct device *dev);
 bool xen_is_grant_dma_device(struct device *dev);
 bool xen_virtio_mem_acc(struct virtio_device *dev);
+bool xen_virtio_restricted_mem_acc(struct virtio_device *dev);
 #else
 static inline void xen_grant_setup_dma_ops(struct device *dev)
 {
@@ -234,6 +235,11 @@ static inline bool xen_virtio_mem_acc(struct virtio_device *dev)
 {
 	return false;
 }
+
+static inline bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
+{
+	return false;
+}
 #endif /* CONFIG_XEN_GRANT_DMA_OPS */
 
 #endif /* INCLUDE_XEN_OPS_H */
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 07:15:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 07:15:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417433.662143 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oghZi-0006k0-8d; Fri, 07 Oct 2022 07:15:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417433.662143; Fri, 07 Oct 2022 07:15:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oghZi-0006jt-5g; Fri, 07 Oct 2022 07:15:14 +0000
Received: by outflank-mailman (input) for mailman id 417433;
 Fri, 07 Oct 2022 07:15:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hbjo=2I=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1oghZg-0006jn-LK
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 07:15:12 +0000
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com
 [2a00:1450:4864:20::52e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7265842-460f-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 09:15:10 +0200 (CEST)
Received: by mail-ed1-x52e.google.com with SMTP id w10so5816310edd.4
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 00:15:09 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 kx18-20020a170907775200b0073ae9ba9ba8sm792356ejc.3.2022.10.07.00.15.08
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 07 Oct 2022 00:15:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7265842-460f-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=VdPP7ZbynXA6QuugzlRWuE4AJslI1k9PX+cmlWKyz7c=;
        b=jyPS84BTRcfJudXidSokxeG1ZdD37ZyQXS0gnxY8B3oVOQT0BKEIbeFVYQF33lL80B
         sV+DQ66TiyHvEC+3V401219cQu3R5Q1p2oSS8eWe6Rb68NR9jDw5jdnkyyVuZToAV1tj
         U4bk7ayCpi0ARbeJPV7RxH72YIFEqY7DkjXUgbeD1omF35vP3Hg4lk938r28ATLG/ACi
         vPxgkN1TUV8k8BdcPFYSMD/FTSrCfwa1TW6L7mFQpYotWD90Z3FVCX7R9cRjFkMj7r+r
         n9PUVpkY7/CjRJfNXK/bbog0XTd/qGYoApiDn73Abwst/SWZWigsd7GyH+j6rdJP4g9T
         D5yw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=VdPP7ZbynXA6QuugzlRWuE4AJslI1k9PX+cmlWKyz7c=;
        b=BNLm51LDHzgs7CDesPfUSGGLRYgPPx5Own6PIp7eZEtbFZ0fW2E25wDukuI4dscbRf
         DhqY71cwTslGVoLKYTclzL4IlTCPIe5fUcr1HNErpuP6nkAZR7v3XlgfVC54llG9zG9S
         V54S4LGBpSrVAFLeFM/LA+bLJzAEhThnvugQs8rUQbRRiHrp2j5ajXUkiCYlPVV2XbOb
         2sXvHcnzTxs24Anf0RVGtrEct+9O1F/3A3iVYzXIxXwgaVXg8DgWYQ8noas6fIQkHFjl
         qv1NBrsGN35eVfaj6MqC9dLGJsM07QzAF9ZFHm6VZXTU/eFyCv7F+9605kP0tNY9bfPQ
         /WqQ==
X-Gm-Message-State: ACrzQf22Q6BDG6AY35BtfeGvjYpnGqvCjkkNSXZQmWGiQNiS7CdZ2t2m
	Ah0OULbJH9T5jdPeLGQ1lSE=
X-Google-Smtp-Source: AMsMyM7nE+3Y9YT3ZoUjnjechzTKdx8lPadALD1ODlJcHowSJch/AthJdJzGNUn/mHrKtMp3uWBksg==
X-Received: by 2002:a05:6402:1cc5:b0:453:ed3f:6a38 with SMTP id ds5-20020a0564021cc500b00453ed3f6a38mr3258525edb.346.1665126909391;
        Fri, 07 Oct 2022 00:15:09 -0700 (PDT)
Message-ID: <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
Date: Fri, 7 Oct 2022 10:15:07 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10/7/22 00:13, Oleksandr Tyshchenko wrote:

Hi Oleksandr

> 
> On 06.10.22 20:59, Xenia Ragiadakou wrote:
> 
> Hello Xenia
> 
>>
>> On 10/6/22 15:09, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> Although XEN_PAGE_SIZE is equal to PAGE_SIZE (4KB) for now, it would
>>> be more correct to use Xen specific #define-s as XEN_PAGE_SIZE can
>>> be changed at some point in the future.
>>>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> ---
>>> Cc: Juergen Gross <jgross@suse.com>
>>> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
>>>
>>> As it was proposed at:
>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!zHt-xZ_7tZc_EM6zva21E_YgwIiEeimFWfsJIpPwAu-TBcnzQhXHqlKzmXmwIcI6uIx_arHNZiaZeHt_428_8p-DyMpd$
>>> [lore[.]kernel[.]org]
>>>
>>> Should go in only after that series.
>>> ---
>>>    drivers/xen/grant-dma-ops.c | 20 ++++++++++----------
>>>    1 file changed, 10 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>>> index c66f56d24013..5392fdc25dca 100644
>>> --- a/drivers/xen/grant-dma-ops.c
>>> +++ b/drivers/xen/grant-dma-ops.c
>>> @@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices,
>>> XA_FLAGS_LOCK_IRQ);
>>>      static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>>>    {
>>> -    return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
>>> +    return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant <<
>>> XEN_PAGE_SHIFT);
>>>    }
>>
>> With this change, can the offset added to the dma handle, generated by
>> grant_to_dma(), be the offset in the page? Couldn't it corrupt the
>> grant ref?
> 
> 
> Good point, indeed, I think it could corrupt if guest uses a different
> than Xen page granularity (i.e 64KB).
> 
> 
>>
>>>      static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>>>    {
>>> -    return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >>
>>> PAGE_SHIFT);
>>> +    return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >>
>>> XEN_PAGE_SHIFT);
>>>    }
>>>      static struct xen_grant_dma_data *find_xen_grant_dma_data(struct
>>> device *dev)
>>> @@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device
>>> *dev, size_t size,
>>>                     unsigned long attrs)
>>>    {
>>>        struct xen_grant_dma_data *data;
>>> -    unsigned int i, n_pages = PFN_UP(size);
>>> +    unsigned int i, n_pages = XEN_PFN_UP(size);
>>>        unsigned long pfn;
>>>        grant_ref_t grant;
>>>        void *ret;
>>> @@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device
>>> *dev, size_t size,
>>>        if (unlikely(data->broken))
>>>            return NULL;
>>>    -    ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
>>> +    ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
>>>        if (!ret)
>>>            return NULL;
>>>          pfn = virt_to_pfn(ret);
>>>          if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>>> -        free_pages_exact(ret, n_pages * PAGE_SIZE);
>>> +        free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
>>>            return NULL;
>>>        }
>>>    @@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device
>>> *dev, size_t size, void *vaddr,
>>>                       dma_addr_t dma_handle, unsigned long attrs)
>>>    {
>>>        struct xen_grant_dma_data *data;
>>> -    unsigned int i, n_pages = PFN_UP(size);
>>> +    unsigned int i, n_pages = XEN_PFN_UP(size);
>>>        grant_ref_t grant;
>>>          data = find_xen_grant_dma_data(dev);
>>> @@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device
>>> *dev, size_t size, void *vaddr,
>>>          gnttab_free_grant_reference_seq(grant, n_pages);
>>>    -    free_pages_exact(vaddr, n_pages * PAGE_SIZE);
>>> +    free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
>>>    }
>>>      static struct page *xen_grant_dma_alloc_pages(struct device *dev,
>>> size_t size,
>>> @@ -168,7 +168,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>> device *dev, struct page *page,
>>>                         unsigned long attrs)
>>>    {
>>>        struct xen_grant_dma_data *data;
>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>> +    unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>
>> The offset, here, refers to the offset in the page ...
>>
>>>        grant_ref_t grant;
>>>        dma_addr_t dma_handle;
>>>    @@ -200,8 +200,8 @@ static void xen_grant_dma_unmap_page(struct
>>> device *dev, dma_addr_t dma_handle,
>>>                         unsigned long attrs)
>>>    {
>>>        struct xen_grant_dma_data *data;
>>> -    unsigned long offset = dma_handle & (PAGE_SIZE - 1);
>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>> +    unsigned long offset = dma_handle & ~XEN_PAGE_MASK;
>>
>> ... while, here, it refers to the offset in the grant.
>> So, the calculated number of grants may differ.
> 
> Good point, I think you are right, so we need to additionally use
> xen_offset_in_page() macro in xen_grant_dma_map_page(),
> 
> something like that to be squashed with current patch:
> 
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 9d5eca6d638a..bb984dc05deb 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -169,7 +169,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
> device *dev, struct page *page,
>                                            unsigned long attrs)
>    {
>           struct xen_grant_dma_data *data;
> -       unsigned int i, n_pages = XEN_PFN_UP(offset + size);
> +       unsigned int i, n_pages = XEN_PFN_UP(xen_offset_in_page(offset)
> + size);
>           grant_ref_t grant;
>           dma_addr_t dma_handle;
> 
> @@ -191,7 +191,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
> device *dev, struct page *page,
>                                   xen_page_to_gfn(page) + i, dir ==
> DMA_TO_DEVICE);
>           }
> 
> -       dma_handle = grant_to_dma(grant) + offset;
> +       dma_handle = grant_to_dma(grant) + xen_offset_in_page(offset);
> 
>           return dma_handle;
>    }
> 
> Did I get your point right?
> 

I think it 's more complicated than that.
Let's say that the offset in page is > XEN_PAGE_SIZE, then the 
calculation of the number of grants won't take into account the part of 
the offset that is multiple of the XEN_PAGE_SIZE i.e it will calculate 
only the strictly necessary number of grants.
But xen_grant_dma_map_page() grants access to the whole page because, as 
it can be observed in the code snippet below, it does not take into 
account the page offset.

for (i = 0; i < n_pages; i++) {
   gnttab_grant_foreign_access_ref(grant + i, data->backend_domid, 
xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
}

>>
>>
>>> +    unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>>        grant_ref_t grant;
>>>          if (WARN_ON(dir == DMA_NONE))
>>
> 
> Thank you.
> 
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 08:01:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 08:01:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417443.662154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogiIK-000454-0w; Fri, 07 Oct 2022 08:01:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417443.662154; Fri, 07 Oct 2022 08:01:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogiIJ-00044x-Th; Fri, 07 Oct 2022 08:01:19 +0000
Received: by outflank-mailman (input) for mailman id 417443;
 Fri, 07 Oct 2022 08:01:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lE99=2I=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ogiII-00044r-PN
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 08:01:18 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 34a56e08-4616-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 10:01:16 +0200 (CEST)
Received: from BN8PR15CA0059.namprd15.prod.outlook.com (2603:10b6:408:80::36)
 by MN0PR12MB5857.namprd12.prod.outlook.com (2603:10b6:208:378::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Fri, 7 Oct
 2022 08:01:05 +0000
Received: from BN8NAM11FT051.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:80:cafe::dd) by BN8PR15CA0059.outlook.office365.com
 (2603:10b6:408:80::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.39 via Frontend
 Transport; Fri, 7 Oct 2022 08:01:05 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT051.mail.protection.outlook.com (10.13.177.66) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 08:01:05 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct
 2022 03:00:43 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct
 2022 01:00:42 -0700
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Fri, 7 Oct 2022 03:00:41 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34a56e08-4616-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JOe4djQ77krgCI/6Vr3D6Jf7oyDKeNj0djea7DG/IuKLhN1NncKCROknvoDQJiq1qrG/FATL9mxTdbBHB750MGBHiDclyECmt4dLpyAlOffvouPApwUUccbTQzId5YaYBdVZqm7bPX6aFSERcDp4Bifkl2Q+IRDv1YieuUmBw80ZX4y6Pq8ja8zt4Lfn7r+zRLJnJ68p1PTfRBFWFw0dSdXvMKp2tD4BICylhEPWd3+UjfZREnMZ/09OxIk+28AXHxMQFhPtM9Ey3roDSCC8wv8pMHo6hCfXl6ahfXPmK/TlLvxzfNWwWbBudr86kaGELHOWvlgSAlUKI1f2Jyhrqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HJCPZ7ytrc5rQ2EA8F20/nl5g5C/rc9PD/Uty/N0zR4=;
 b=EYyk3XF+1dobY69nVJMTlF9slPFFxl9g9+N5a6smlp1RCndKFIRRnkWlEIWSSFlwuQLL+okqlj7c78Yca7bhmKO72yR5V68xePWYITI4K341J6z3PkXHkOBBj/cO545UzQ+sWhuINjC1fm7tPY+I2q6hKtQCBYZBJVLe/EzUHxIb1stBqHqMA9am6TuwFWzDppHRQT9H5FbcEGSK8tusNurx+nHEVs57lCxXIkYv8xjYdj+q9/dl7LOEydyFphfKpSF782yDBiBXm0S3bUU9RHdyA4jw+i/hjMcuNbwSNoG7WS0D8CGgRFrWpRBjc5r8Zys6jaNVeqeK/8tnkM9RhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HJCPZ7ytrc5rQ2EA8F20/nl5g5C/rc9PD/Uty/N0zR4=;
 b=BogzMkfhz7FJ0rzRUVeLutG9XFndRafAjX9DpUNgTT3M9upCecJ6A9bzhBJGdBzOkZGFOkrtboWmqxiHuDs7S3Qpaw0HThgT/YJ9jYB4z/v4CaqIOEdZj77fVZ/F7jZFQhK5iYNHtzSJ+V61mICXmriyvrfwYJSG9AEAFnvmgkM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <25626565-ba7d-265b-38f5-003b0b504d67@amd.com>
Date: Fri, 7 Oct 2022 10:00:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] ImageBuilder: Add support for 64-bit addresses
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <stefano.stabellini@amd.com>, <xen-devel@lists.xenproject.org>
References: <20221006102035.16281-1-michal.orzel@amd.com>
 <alpine.DEB.2.22.394.2210061349110.3690179@ubuntu-linux-20-04-desktop>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <alpine.DEB.2.22.394.2210061349110.3690179@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT051:EE_|MN0PR12MB5857:EE_
X-MS-Office365-Filtering-Correlation-Id: f0f0ec7f-8f04-462b-477c-08daa83a1600
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eDecsE7+ksF0/W197gLqihcrjYrW0EZuB4xG9UtZceN68xHL6wmeQnF51Xa0lGyLaKVLs25nRw9ld9/7Hdjr27EPDamBSdMG3CzJmB1Mlhsa/mduL66vOKMMjlDdPTBhFKKMoFEoVk//kfqQFGdGMYhoQRMSfb9pIEBLIcIPYHLLvE6INASQNyo3+lM05SxAsZ6EHApBHnkdwcpQwzkzIwol3h0TWuLMDqp78bDCTUxWuGoWpW9WMSye1QULGLpOsnDUWPWutZXMGWd4pDf+088aEWBQF37PbCykPeZ6OqAQv5Xh71D+DT0/f+rcutDQhEYvctOeD1SySMrkJDMWkcR/dOa09pJjtOSAfpn3lAJIg4zgxGWcRt44PogMYaVLaz9sFVKnUcHiNA6s3LNpeOM34Heglr8H5wN5+yZyvPBKpnzVp80sZmh/e6q9N4aX/uEfeyWQOr1TbceAYb5QUA/XXI81ohtHKPlmum+9BMDpsY3KwgjGBYto2Je6zVdVZmxrnKu+YkfRlhIv+TUZRXz6j9Dq7Gx8TtHc5LK4OqnAK4SzpUgBcWloCOC8FJ11gfLhz+4823sFRUZaPdPLAgN+a0nNfN17vTc0nOZH7Da/vZhWsYpSSHlKX6PTDQ9iW+AWL7rIfzIxdGlxA62TOD+bYw3dGqSsMltxNr0AxNN3mJzqI8eGb4DWoLGdhN0y0QlKa/ClD2tEWv7tt4Y0shHdJPhxz6lCawrQx1T8A9ao+DFKodySOrxdkHWE9Cy70WUaQInta/bxQInqItfLFIuGUnrYqDKzGy6f31zOMPkwin5vQ9Wpcxo32AKzOwqW1u5EdDrVowzq9AWxP+tNMQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(44832011)(31686004)(5660300002)(8936002)(40480700001)(41300700001)(2906002)(4326008)(70206006)(53546011)(40460700003)(356005)(478600001)(36756003)(81166007)(70586007)(8676002)(26005)(82740400003)(336012)(316002)(83380400001)(47076005)(86362001)(6916009)(426003)(16576012)(186003)(31696002)(36860700001)(54906003)(2616005)(82310400005)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 08:01:05.6251
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f0f0ec7f-8f04-462b-477c-08daa83a1600
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT051.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5857

Hi Stefano,

On 07/10/2022 00:34, Stefano Stabellini wrote:
> 
> 
> +xen-devel
> 
> On Thu, 6 Oct 2022, Michal Orzel wrote:
>> At the moment, ImageBuilder assumes that all addresses/sizes are
>> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
>> value for the first cell. Because of that, we cannot specify MEMORY_START
>> and MEMORY_END to be above 32-bits (e.g. to place the images in the
>> upper memory bank).
>>
>> Add support to properly handle 64-bit addresses:
>>  - add function split_into_halves to split the value passed as a first
>>    argument into upper and lower halves. These are then set as values for
>>    variables passed respetively as the second and third argument,
>>  - whenever there is a variable storing the full 64-bit number with
>>    "addr" or "size" in name, introduce two additional variables with
>>    "addr1,addr2"/"size1,size2" in name to store the halves. These are
>>    then used to properly set cells.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>
>> ---
>>  scripts/uboot-script-gen | 60 +++++++++++++++++++++++++++++++++++-----
>>  1 file changed, 53 insertions(+), 7 deletions(-)
>>
>> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
>> index 16269f02f1e7..4c6525a910f3 100755
>> --- a/scripts/uboot-script-gen
>> +++ b/scripts/uboot-script-gen
>> @@ -25,6 +25,14 @@ function dt_mknode()
>>      fi
>>  }
>>
>> +# Usage:
>> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
>> +function split_into_halves()
>> +{
>> +    eval "$2=$(printf "0x%X\n" $(($1 >> 32)))"
>> +    eval "$3=$(printf "0x%X\n" $(($1 & 0xFFFFFFFF)))"
>> +}
> 
> I know it is the same thing, but I would prefer the following version
> because it makes it easier to read:
> 
> # Usage:
> # split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
> function split_into_halves()
> {
>     local value=$1
>     local upper=$2
>     local lower=$3
> 
>     eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
>     eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
> }
That is ok for me.

> 
> 
>> +
>>  # data_type is either
>>  #   int
>>  #   hex
>> @@ -41,10 +49,14 @@ function dt_set()
>>
>>      if test $data_type = "var"
>>      then
>> -        eval data_addr_var="$data"_addr
>> -        eval data_addr=\$"$data_addr_var"
>> -        eval data_size_var="$data"_size
>> -        eval data_size=\$"$data_size_var"
>> +        eval data_addr1_var="$data"_addr1
>> +        eval data_addr2_var="$data"_addr2
>> +        eval data_addr1=\$"$data_addr1_var"
>> +        eval data_addr2=\$"$data_addr2_var"
>> +        eval data_size1_var="$data"_size1
>> +        eval data_size2_var="$data"_size2
>> +        eval data_size1=\$"$data_size1_var"
>> +        eval data_size2=\$"$data_size2_var"
> 
> To avoid making the code more complex, is it possible to stick with just
> a single data_addr variable in u-boot and calculate the upper and lower
> 32-bit using u-boot commands?
The reason why we need these extra variables is to add them into respective
cells under different nodes. In dt_set we need to put the variable names
for dynamic assignment and variable values for static assignment. We cannot
do this having a single pair data_addr_var,data_addr. These evals corresponds
to variables from xen_file_loading. dt_set and add_size are two different
functions. The former is used to create the nodes and the latter is used to
set values for the environment variables.

Example:
dt_set "/chosen/dom0" "reg" "var" "dom0_linux"
- this will create a reg property for dom0 kernel. We need to insert the upper
and lower halves into this property (so we need separate variables for that)
e.g.
reg <0x${dom0_linux_addr1} 0x${dom0_linux_addr2} 0x${dom0_linux_size1} 0x${dom0_linux_size2}>

load_file $DOM0_KERNEL "dom0_linux" calling add_size
- this will set values for upper and lower halves into u-boot env variables
that corresponds to variables we placed previously in reg property,
e.g.
setenv dom0_linux_addr1 ${memaddr1}
setenv dom0_linux_addr2 ${memaddr2}
setenv dom0_linux_size1 ${filesize1}
setenv dom0_linux_size2 ${filesize2}

FWICS, we cannot achieve this using a single pair.

~Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 08:22:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 08:22:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417449.662166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogicC-0006Xk-PM; Fri, 07 Oct 2022 08:21:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417449.662166; Fri, 07 Oct 2022 08:21:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogicC-0006Xd-Kv; Fri, 07 Oct 2022 08:21:52 +0000
Received: by outflank-mailman (input) for mailman id 417449;
 Fri, 07 Oct 2022 08:21:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogicB-0006XT-7q; Fri, 07 Oct 2022 08:21:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogicB-00050Q-5H; Fri, 07 Oct 2022 08:21:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogicA-0005yG-I1; Fri, 07 Oct 2022 08:21:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogicA-0002jt-HV; Fri, 07 Oct 2022 08:21:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kBV84ze8KlfmOvv9WSZkkOiaulyfCofNn8nfgzqm1ck=; b=z3UCOhZuVueqeP20burAutexbZ
	HZ7fArz4z01SX5b/lMBIaITZidTbmS0w6v1PW2xMKG2tI2cwO/2cWJNr4NcXeP24Ctm7+A8+IOr4m
	zN60tPQ2yqRVJ4XT6g4yhOJP+H5HBADlOOwiPEXXbn+Rhorcy138d5OtwgocQ2YOYubw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173451-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173451: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ffb39098bf87db327b2be4b5c6f1087bcba94ce9
X-Osstest-Versions-That:
    linux=833477fce7a14d43ae4c07f8ddc32fa5119471a2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 08:21:50 +0000

flight 173451 linux-linus real [real]
flight 173455 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173451/
http://logs.test-lab.xenproject.org/osstest/logs/173455/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw  8 xen-boot            fail pass in 173455-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 173442

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 173455 like 173442
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 173455 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173442
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173442
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173442
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173442
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173442
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173442
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173442
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                ffb39098bf87db327b2be4b5c6f1087bcba94ce9
baseline version:
 linux                833477fce7a14d43ae4c07f8ddc32fa5119471a2

Last test of basis   173442  2022-10-06 07:53:50 Z    1 days
Testing same since   173451  2022-10-06 21:13:17 Z    0 days    1 attempts

------------------------------------------------------------
321 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   833477fce7a1..ffb39098bf87  ffb39098bf87db327b2be4b5c6f1087bcba94ce9 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:13:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417499.662205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQS-0004pG-Ge; Fri, 07 Oct 2022 09:13:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417499.662205; Fri, 07 Oct 2022 09:13:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQS-0004p9-Ch; Fri, 07 Oct 2022 09:13:48 +0000
Received: by outflank-mailman (input) for mailman id 417499;
 Fri, 07 Oct 2022 09:13:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ogjQR-0004Zk-2n
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:13:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQQ-0005re-Re; Fri, 07 Oct 2022 09:13:46 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQQ-0000mx-JU; Fri, 07 Oct 2022 09:13:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=kUbx1LNjRCLFRujiYZrTjCoqmIZMshwFrfMaBNx9TDw=; b=BH5PiAE/5iCp3eklKH6vRgDzbp
	T7vC1nwsnqMqkTWAy4RtVSLLyu4GItJFUYDuc76eTaDuZxkLrDB7+onpx9EEC0EoftM3Uyvi2bQoV
	Q//WvrYoSzQ/9gk1b/FQ1otrbFj/QGAnq7ewo5mv/JCPosvwocEQkWRDYEyBgknuZKOs=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 1/3] process/release-technician-checklist: Explain how the banner in README is generated
Date: Fri,  7 Oct 2022 10:13:39 +0100
Message-Id: <20221007091341.58542-2-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221007091341.58542-1-julien@xen.org>
References: <20221007091341.58542-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 docs/process/release-technician-checklist.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/process/release-technician-checklist.txt b/docs/process/release-technician-checklist.txt
index 7515da202c92..914f31959ab0 100644
--- a/docs/process/release-technician-checklist.txt
+++ b/docs/process/release-technician-checklist.txt
@@ -49,6 +49,7 @@ t=RELEASE-$r
 * consider bumping sonames of shlibs
 
 * change xen-unstable README (should say "Xen 4.5" in releases and on stable branches, "Xen 4.5-unstable" on unstable)
+*   The banner is generated using figlet
 * change xen-unstable Config.mk
 #   QEMU_UPSTREAM_REVISION,
 #   QEMU_TRADITIONAL_REVISION
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:13:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417498.662194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQR-0004Zw-89; Fri, 07 Oct 2022 09:13:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417498.662194; Fri, 07 Oct 2022 09:13:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQR-0004Zp-5G; Fri, 07 Oct 2022 09:13:47 +0000
Received: by outflank-mailman (input) for mailman id 417498;
 Fri, 07 Oct 2022 09:13:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ogjQQ-0004Ze-14
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:13:46 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQP-0005rY-Ie; Fri, 07 Oct 2022 09:13:45 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQP-0000mx-9b; Fri, 07 Oct 2022 09:13:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=KcRoOxbT98pj7lSXnPDK2ZAxSR7ZC0weJkH3qQh8Ukk=; b=O1geAX
	x+AipJE0gNRc/4+HPkKSXq1lkHvoubOVeJKFPq8z2N3c4I+yFr1/Nzqh275aAUagMe0ZnYPVJ0SZ3
	jVYRCHWn11cUN1Rql8PRc8+a29BS9Jx3HKQboVPEC8rdv6PQb43R7F38jzSl/3Hk1b8kKPT6tkWwz
	Klmzdow+euc=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 0/3] Prepare the tree for 4.17 RC
Date: Fri,  7 Oct 2022 10:13:38 +0100
Message-Id: <20221007091341.58542-1-julien@xen.org>
X-Mailer: git-send-email 2.37.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Hi all,

This small series is to get the tree ready for cutting the first
4.17 release candidate.

I haven't prepared any RC in the past. So I mainly followed the
guideline in docs/process/release-technician-checklist.txt. Please
let me know if I missed anything.

Cheers,

Julien Grall (3):
  process/release-technician-checklist: Explain how the banner in README
    is generated
  Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen 4.17 RC1)
  Update Xen version to 4.17-rc

 Config.mk                                     |  2 +-
 README                                        | 16 ++++++++--------
 SUPPORT.md                                    |  2 +-
 docs/process/release-technician-checklist.txt |  1 +
 xen/Makefile                                  |  2 +-
 5 files changed, 12 insertions(+), 11 deletions(-)

-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:13:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417501.662227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQV-0005Lx-2w; Fri, 07 Oct 2022 09:13:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417501.662227; Fri, 07 Oct 2022 09:13:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQU-0005Lq-W0; Fri, 07 Oct 2022 09:13:50 +0000
Received: by outflank-mailman (input) for mailman id 417501;
 Fri, 07 Oct 2022 09:13:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ogjQT-000558-Mr
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:13:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQT-0005sG-Es; Fri, 07 Oct 2022 09:13:49 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQT-0000mx-6z; Fri, 07 Oct 2022 09:13:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=zhLXyn1eLPgxTWR3iixnzmV5WGnFG/Li12mmliMaC5s=; b=irH81NaMHgcHl4I6v2HMqcJnSq
	3eCOaBCm9xt4aFO/4aGy0b2RjFu8DsEd1HP+O4HV3pSHLbUcGZTBei017m5K7x988rWWo8g07wGI3
	6da6sumyk6EjQI+eAmSVLwWtfMSb1MN+mWMh7U/8s7UwC/4VSjWkxqx7y9fCFbfU0/kI=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 3/3] Update Xen version to 4.17-rc
Date: Fri,  7 Oct 2022 10:13:41 +0100
Message-Id: <20221007091341.58542-4-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221007091341.58542-1-julien@xen.org>
References: <20221007091341.58542-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 README       | 16 ++++++++--------
 SUPPORT.md   |  2 +-
 xen/Makefile |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/README b/README
index 89a1d0b43c4c..2fdca8861bef 100644
--- a/README
+++ b/README
@@ -1,11 +1,11 @@
-############################################################
-__  __                                _        _     _
-\ \/ /___ _ __        _   _ _ __  ___| |_ __ _| |__ | | ___
- \  // _ \ '_ \ _____| | | | '_ \/ __| __/ _` | '_ \| |/ _ \
- /  \  __/ | | |_____| |_| | | | \__ \ || (_| | |_) | |  __/
-/_/\_\___|_| |_|      \__,_|_| |_|___/\__\__,_|_.__/|_|\___|
-
-############################################################
+###############################################
+__  __            _  _    _ _____
+\ \/ /___ _ __   | || |  / |___  |    _ __ ___
+ \  // _ \ '_ \  | || |_ | |  / /____| '__/ __|
+ /  \  __/ | | | |__   _|| | / /_____| | | (__
+/_/\_\___|_| |_|    |_|(_)_|/_/      |_|  \___|
+
+###############################################
 
 https://www.xen.org/
 
diff --git a/SUPPORT.md b/SUPPORT.md
index 29f74ac5063e..cf2ddfacaf09 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -9,7 +9,7 @@ for the definitions of the support status levels etc.
 
 # Release Support
 
-    Xen-Version: unstable
+    Xen-Version: 4.17-rc
     Initial-Release: n/a
     Supported-Until: TBD
     Security-Support-Until: Unreleased - not yet security-supported
diff --git a/xen/Makefile b/xen/Makefile
index 4e6e661261ae..9d0df5e2c543 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -6,7 +6,7 @@ this-makefile := $(call lastword,$(MAKEFILE_LIST))
 # All other places this is stored (eg. compile.h) should be autogenerated.
 export XEN_VERSION       = 4
 export XEN_SUBVERSION    = 17
-export XEN_EXTRAVERSION ?= -unstable$(XEN_VENDORVERSION)
+export XEN_EXTRAVERSION ?= -rc$(XEN_VENDORVERSION)
 export XEN_FULLVERSION   = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
 -include xen-version
 
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:13:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:13:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417500.662216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQT-000556-PX; Fri, 07 Oct 2022 09:13:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417500.662216; Fri, 07 Oct 2022 09:13:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjQT-00054v-LZ; Fri, 07 Oct 2022 09:13:49 +0000
Received: by outflank-mailman (input) for mailman id 417500;
 Fri, 07 Oct 2022 09:13:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ogjQS-0004p4-A5
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:13:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQS-0005ry-5m; Fri, 07 Oct 2022 09:13:48 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogjQR-0000mx-TM; Fri, 07 Oct 2022 09:13:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=Y//ftCGsRAazMOB/1N8KrT/BfXkeqP9OSiLzG/bcZ64=; b=i8LhQgErLOockdUlXpgf0hSH9U
	uh+B5MGgAzRpl4Sd9LBEj0JTNAmHVWEwTG7Vw2BdNhIwXjPxaWbx31uqjE9ZbCjYWTppfxEg6gziD
	4pR43TiZJ2uTFIQFXk0/caiXpL+Pr5K5Oeb7ZQNtb3ZT8Ir/iVvM7DIEPbwdM9vA9se4=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 2/3] Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen 4.17 RC1)
Date: Fri,  7 Oct 2022 10:13:40 +0100
Message-Id: <20221007091341.58542-3-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221007091341.58542-1-julien@xen.org>
References: <20221007091341.58542-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 Config.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Config.mk b/Config.mk
index 69af1e60d4cc..e0ce59346896 100644
--- a/Config.mk
+++ b/Config.mk
@@ -229,7 +229,7 @@ SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git
 MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git
 endif
 OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5
-QEMU_UPSTREAM_REVISION ?= master
+QEMU_UPSTREAM_REVISION ?= b746458e1ce1bec85e58b458386f8b7a0bedfaa6
 MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3
 
 SEABIOS_UPSTREAM_REVISION ?= rel-1.16.0
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:42:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:42:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417525.662238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjsN-0001Gw-BL; Fri, 07 Oct 2022 09:42:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417525.662238; Fri, 07 Oct 2022 09:42:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjsN-0001Gp-7q; Fri, 07 Oct 2022 09:42:39 +0000
Received: by outflank-mailman (input) for mailman id 417525;
 Fri, 07 Oct 2022 09:42:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XcYz=2I=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ogjsL-0001Gg-Um
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:42:38 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2055.outbound.protection.outlook.com [40.107.249.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e95be1c-4624-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 11:42:35 +0200 (CEST)
Received: from AM6PR0502CA0059.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::36) by AS8PR08MB8182.eurprd08.prod.outlook.com
 (2603:10a6:20b:54f::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 09:42:32 +0000
Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:56:cafe::9a) by AM6PR0502CA0059.outlook.office365.com
 (2603:10a6:20b:56::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36 via Frontend
 Transport; Fri, 7 Oct 2022 09:42:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 09:42:31 +0000
Received: ("Tessian outbound 7e4a920b87c0:v128");
 Fri, 07 Oct 2022 09:42:30 +0000
Received: from 932391c6ceb5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1FF08CF9-2C01-4503-8508-24E4494CB6D8.1; 
 Fri, 07 Oct 2022 09:42:24 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 932391c6ceb5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 07 Oct 2022 09:42:24 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB9606.eurprd08.prod.outlook.com (2603:10a6:10:44a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 7 Oct
 2022 09:42:20 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 09:42:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e95be1c-4624-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=XdCRNqKSvjPB20hVaesLySiWmEyYtSnCfingOOQ8f293dltACHvFjYDkys2jmLNSvknLCPR9SyOMfYtBmZ/awY9CiSN7z3y33bNDEEsdZEEuP14+XYp3Uz7EFXHT22fP9jsYuyfkjArGvNcS7hD9IKkRjVLnxQWULzuKSK+uG+ZiTPvSl5n1ctk2RUmwlQYMev7ntJ3xq+OPTTmpww/M/sSHDQ0yRMBKotHadm6BztvzQc8d8djiFvtUaSa5mYWsPpJoHKxi9ag8coWlxWy7UEKerRvfwA60MksRr0DECDHWJJUSbg2vDbx6GfSs3pkESNZULPt0WA4aDY7dMd2tMg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P9UZ5GkaKMKwDiuD29pmC/BCaBkruEG+uGZG3skHUWM=;
 b=PE987zfPAM+v4MEDjF3huZhPDFX9jqdESlrE9HCiJHBFntYgQ4uLJFt9uRaluuOV9trfKpETxhryuPRmSlyoTvZIdvp6MVWkHvfaWPQuVDHaLF/UxRXvOg6T0lhwVf2qIDzSKbkCx/jeS5pUEXUa0mKk965OjxKXKGiai4B/nSce6kYcHMkm8hAaOm3I1NiZqA18trqPeh8/Tj1J/CwNcciHHosAgXC5ee6q2MBpJXdc3GS2yzB9DH2RczPQjBGx+7PcnEAH4LfG63+Z1AJZz+7bLkHrHYMDo+dRSn38XKCx7jN3PvZwb1ls6whwmSxi1C4JYlpq3WIPBrmpUgv5rQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P9UZ5GkaKMKwDiuD29pmC/BCaBkruEG+uGZG3skHUWM=;
 b=ftIQal2E/NeOchJ5aOEXCu+CkYYcy32fPs3AIv0wqf9RnDwKk6qPFaJXBmlzI4xCaewMoGL6k2uaez08soQ6GL3Galtl7h6wya4SCFGbLWQz9XaMUPOLewz5n5v/FjEUFuMidVSEG4uOM8ANfSgftuSwQJfuwHIvz8BL5tCCHMs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TfjOtLyhee2AMKQ1C0uYD8mZgt9Xi5gXSZTuXaJeSJOMkH4PhYtKeHWfD53OgO59U2Mo1AX/4IYWRHADKwiFBpdBWowCMeG0ShwqZZLsmnAU3zROt4umBaDE7fDGqypTLHx849giRTVi9ciSBwRn+OIdh/4520wfLRr7yeAV2ab1AcMNjDa5oDVYe1oS0+SB64XL9k4B0Ik3x7nqBrK2+0grtcsBKiLYKQ0TH+F/pA7OoW3mVNPTCGfNGUcTlgQxZ7IPZdBVJEGfxSvJJJR6FnhCQaiyRdQIzh97PdKARRmymv9+JW3Qt0uJ2jzVQLBedIJnqf6Y/c+tNV9mQfwLuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P9UZ5GkaKMKwDiuD29pmC/BCaBkruEG+uGZG3skHUWM=;
 b=mUREbw9byL3knNwtk8BzHL+fCCFINkBIKNxmDU8xPNRRlDMr6pyX0pJDY0zNoMLv0qK6BvecYYcWVrDOuUfQyNcL20mxCrYYdWRvZEzaoHi7KiAGTIW46vE6xHKXLAa0LMKzQ2ySwx0vVd+PINFxr61MwvEebhukw0wONc4uVoQ+Hs7+Nhrg7wd04labwyQZHbni0rsAVJFuXeryXyFo84BdjSHmE5jqIHWn/Xdu44t9Fc9yYQd9lvRiprjjABZ2hnZQ7I9/CBmMTBlU45qc22Lyp8IIVZss4sQif0oyWVqV6AkUgmM5VPPew8W0Mk45I9Cz81VadNcR9qDKp7KyDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P9UZ5GkaKMKwDiuD29pmC/BCaBkruEG+uGZG3skHUWM=;
 b=ftIQal2E/NeOchJ5aOEXCu+CkYYcy32fPs3AIv0wqf9RnDwKk6qPFaJXBmlzI4xCaewMoGL6k2uaez08soQ6GL3Galtl7h6wya4SCFGbLWQz9XaMUPOLewz5n5v/FjEUFuMidVSEG4uOM8ANfSgftuSwQJfuwHIvz8BL5tCCHMs=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <jgrall@amazon.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei
 Liu <wl@xen.org>
Subject: RE: [PATCH 1/3] process/release-technician-checklist: Explain how the
 banner in README is generated
Thread-Topic: [PATCH 1/3] process/release-technician-checklist: Explain how
 the banner in README is generated
Thread-Index: AQHY2i0gGhV+BlE4RkGVTxUJhCuKKq4Crayg
Date: Fri, 7 Oct 2022 09:42:19 +0000
Message-ID:
 <AS8PR08MB799156D43366686870951A3D925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-2-julien@xen.org>
In-Reply-To: <20221007091341.58542-2-julien@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: D3A78B58310C0446BD84D1CDED0DEF33.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB9606:EE_|AM7EUR03FT027:EE_|AS8PR08MB8182:EE_
X-MS-Office365-Filtering-Correlation-Id: 277ffbe0-aa5f-4354-84a6-08daa8484155
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2zITKZR3cNqeAR8MZ28oGMkTfOgjAyIz3E4OvOmVKS36ccb9Ic5gr8sSqA/+7xmanqA1wJv1J1FdbzNpA5MVI4OwsGQEAAVtB3tILDNzxN0N9eX05Po/AK+XVwIgt1tfZNnbVlD3sIAQ4OLla5pO/9iYsFQMtXq6tvfSTH41TEEpB3ZBWqkcbE11tmW1rysERnq5YznyNJFjFcqejZgVJfMgo1NOO6URx8V1KEiZdsCtDZ1UvQdIjBSvDf/h7I3GoY5XRJPflNRiynOeb9nCVInLUoUza2T4yZRigQIPqXzbIHCg40FFtVI2pWzdHHNUsnNHeNwA6vd1CF9lcyBned23BNyeYS5ARErtz0c1553cVx0MldRO2hUjf+G0EKxJiGWMY018BXJUNNsuqkbhoD5R5l1N8106v8jrrMh/FvsA9yhSrcE6DjXT24LICicaPMFv9TF3+jkqkFMFF8P5zuAZQ70XajhZl70PWCMzGUMX+ROYpGnHrYaNd1N1YFJQQHcvnwf7ccjc2W1LoDJiY3hTVDlQp2WDNDiiwvolBa9gRhnqYtHWsxzizLxXmley3HuRksv8/L/Ids1SHEay2rfASNK3USedcwQB7mHbejwDLDSPvk9NYSdb2iDMN5UlLRlxYZ14IOTnbjWCiQ6MwSOtH1dArsxBGNoYkCCKiPb5/G9QSTPNSIqVzRveo/MJGBxDK85Jeybj7WJDS2XAiQpVn8w55FvkQR7QjwNuc6F+EiqIjrYteSvWXH++D9nuIy8HEAkOrWwluj39Ip7u7Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(54906003)(64756008)(66946007)(66476007)(8676002)(4326008)(66556008)(66446008)(86362001)(38070700005)(558084003)(38100700002)(2906002)(186003)(71200400001)(110136005)(122000001)(6506007)(7696005)(5660300002)(33656002)(52536014)(9686003)(76116006)(26005)(83380400001)(55016003)(41300700001)(316002)(8936002)(478600001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9606
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d5e9284b-2569-4606-c099-08daa8483a29
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IUtdNOKSXK5NWGNsU6wL/79GmjD9+MCeOz19E6Q6W5M+hkutXuVrqfIo3nEESCSnguGBrGH05Gtw2YJ5scWBD54wxR5fKDM1rUC5Q6u7qfJFoTOzGDkt3i9BxnzRDNGZvMKGKHteFAvux96YAbWcVmsC33E8whNsJjgfn21wmhEFskOc55RXNPcVa8CIfUZfhPET7vOqtyaRtni5rNSXSLnnbE6HNLK1AXLzpu3CWpiihyQEuoQAOV2Xq5chW+97pjS2RRbePTDyuCvcSCnNBgfKbYAEj1i1qI3X0yKOEosd+Ef7BLQ+/5k8gOAkugP+tWHMLUntTeP5cM7qv1yD6w64e+RN0V5mge/v0PNnKj/9Uyzq2ccfVewpVuQ937Krtd0XTBzHxShKr4VCDA/cr0n+r3FMll7x7VGq/6lNDKYMS9/d5wSoXNreA4CjYkkPdQIf4n7Vb4oI3Eq20FKLXFU8pDGLbThlPkTYDXrPM5ZAxOpiZwAVbgWudqpIbazfMgYnhwMG7M9JmSOs/c7mXZQMLsZyzIvtkOYFmn/KWu8bCfm1ZNuwsHW1ZFVY5H/E2y2pOqIo3snGI4Ribs+bfY7vIxcVdNkSzpyN5/VCs495QaIrKxkfLz2yT5n4BcCv7rw+wo56zcPMWtoqS2HmPgXsrEY46/EyGblVXryjzZfL8oqcHLRGdk62U/N1Y217ckPYNSIFCXXtCW7PzhH1Lb6C8wWK09qLO5RhMhBUOKIZNmS3WAb2EN18gPX9VCpG6Hy9EPvBsGYWxnWWdqS+Ag==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(26005)(7696005)(6506007)(478600001)(9686003)(47076005)(83380400001)(336012)(186003)(40460700003)(4744005)(40480700001)(2906002)(55016003)(82310400005)(110136005)(54906003)(70206006)(316002)(8676002)(8936002)(52536014)(41300700001)(5660300002)(70586007)(4326008)(356005)(81166007)(33656002)(86362001)(36860700001)(82740400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 09:42:31.2956
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 277ffbe0-aa5f-4354-84a6-08daa8484155
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8182

Hi Julien,

> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Subject: [PATCH 1/3] process/release-technician-checklist: Explain how th=
e
> banner in README is generated
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:43:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:43:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417526.662249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjsj-0001eH-JP; Fri, 07 Oct 2022 09:43:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417526.662249; Fri, 07 Oct 2022 09:43:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjsj-0001eA-GP; Fri, 07 Oct 2022 09:43:01 +0000
Received: by outflank-mailman (input) for mailman id 417526;
 Fri, 07 Oct 2022 09:43:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogjsh-0001cC-SM
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:43:00 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ce33bd0-4624-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 11:42:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9009A21901;
 Fri,  7 Oct 2022 09:42:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 00BCA13A3D;
 Fri,  7 Oct 2022 09:42:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8P9eOaD0P2OCGAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 09:42:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ce33bd0-4624-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665135777; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qDcZutUPZr8jCmnqiCR+M45j5PrpfBXNQp3JMDYnUGQ=;
	b=FApgKhQZk743OYV5QQ++0JUFrPAexlwXeepH41etSOYVZPTgnxWhO5lIacabduHHEvUVBi
	HxlOi7CEuK6Nk6v/MhK+tubP4EI855ExHxw/sEhPzSupLSr1tc0KRsHaZJUNI7N4eKmV/N
	ujle2n8zv5+retXyNl7R+9zu/At5Prc=
Message-ID: <ebf1044f-00c4-b4f0-7f02-e9b1e9d3ee90@suse.com>
Date: Fri, 7 Oct 2022 11:42:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/3] process/release-technician-checklist: Explain how the
 banner in README is generated
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-2-julien@xen.org>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221007091341.58542-2-julien@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------PW136we1pw9Ce00r3fL8axZr"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------PW136we1pw9Ce00r3fL8axZr
Content-Type: multipart/mixed; boundary="------------6k5mpl03tB5AI3txpgQ8G8Iu";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <ebf1044f-00c4-b4f0-7f02-e9b1e9d3ee90@suse.com>
Subject: Re: [PATCH 1/3] process/release-technician-checklist: Explain how the
 banner in README is generated
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-2-julien@xen.org>
In-Reply-To: <20221007091341.58542-2-julien@xen.org>

--------------6k5mpl03tB5AI3txpgQ8G8Iu
Content-Type: multipart/mixed; boundary="------------RSXFtg7EVkFNypne8sHdToMl"

--------------RSXFtg7EVkFNypne8sHdToMl
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMTAuMjIgMTE6MTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gRnJvbTogSnVsaWVu
IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdy
b3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo=
--------------RSXFtg7EVkFNypne8sHdToMl
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------RSXFtg7EVkFNypne8sHdToMl--

--------------6k5mpl03tB5AI3txpgQ8G8Iu--

--------------PW136we1pw9Ce00r3fL8axZr
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmM/9KAFAwAAAAAACgkQsN6d1ii/Ey/O
9gf/ZzRXEc7gVA9YPrN5CA5noGxvQwBNmOmFzxCJ911LbRfZGl95ttUxPKnZ6lgq8f7A09QmCsFD
rWLVjkKe+ynOz0NsTl5ABeoc2/wzktk2/MN3a4gkAuX60ZyCP2y1Y885jtaqRUKFnLIiSsCHwlaC
6pzc3Io19oIAhRT4nCL0QLRdlzjQQvsFdgTC0e8VDnCvBm85acLASfIKvjTWzC7CM4EwJyeDxmZY
86ZmnA6YXlRiMAOcfmaGs0aSYCEo8GWcnsEfsu7dt/NCoL7juSvuxbxNxvbxy2qI5lbJiWiZipjB
eajVACt/Z4UCgKlX5tpI1Cakp0R0L4jWvNBDaYgiig==
=OmEv
-----END PGP SIGNATURE-----

--------------PW136we1pw9Ce00r3fL8axZr--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:46:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:46:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417540.662260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjvc-0002YT-62; Fri, 07 Oct 2022 09:46:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417540.662260; Fri, 07 Oct 2022 09:46:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogjvc-0002YM-2T; Fri, 07 Oct 2022 09:46:00 +0000
Received: by outflank-mailman (input) for mailman id 417540;
 Fri, 07 Oct 2022 09:45:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XcYz=2I=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ogjvb-0002YE-5a
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:45:59 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d815a249-4624-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 11:45:58 +0200 (CEST)
Received: from AM6P194CA0043.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::20)
 by AS4PR08MB7856.eurprd08.prod.outlook.com (2603:10a6:20b:51f::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 7 Oct
 2022 09:45:56 +0000
Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:84:cafe::d5) by AM6P194CA0043.outlook.office365.com
 (2603:10a6:209:84::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28 via Frontend
 Transport; Fri, 7 Oct 2022 09:45:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 09:45:55 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Fri, 07 Oct 2022 09:45:54 +0000
Received: from d67113b57749.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D7068B80-70FC-41FD-ACE5-4ACAF789F9D6.1; 
 Fri, 07 Oct 2022 09:45:47 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d67113b57749.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 07 Oct 2022 09:45:47 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM7PR08MB5462.eurprd08.prod.outlook.com (2603:10a6:20b:10b::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct
 2022 09:45:45 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 09:45:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d815a249-4624-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=goutojhQh/c1cVO5Uc3YkSF3NE1HvqpbQOtTKA10OeMiQSB3JLgeWV6Bg9ly5z/tFJmNb6y+hLvhrpkW8NVsW78bIB6y3eseneJ4NWtZBD5HkUUtPZD7Imh5wUhatiD6PEOsYvoDGRCdNkDKoPLyy0/3BzD+2V+X2NRfNBruDDnZMdHWl8wKCtvgh/aBI2ArDOgQtJMWXP42LsMr3uCuPwfOQi0KM1w/Pww4roHJGpuDtXfyDDEhtfyjQ5IITgtuiC6IR1+CCeeARnIHX1pVORdJLj4sWY1UWOOIUFHkhabaD1wGGFaRHtPi9emszyW8CuF5zzhq9MfAVX6GkI2/Ng==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E2dp/hkETdq+jEJEZrjsC5obl1er0iJiFvNVBDPQVLE=;
 b=ETKnlq5hmetOVuDdaygbFmsjJS5Bt9TKzApKuWzj1nLpOlvwKGmR0yuRDm3LhYn4cogYNpfkTtX2h7AUKyBV1Il8Auajy736b/rw8OxsdryTwBl+ji447YmTiWL68CPm+FSZVNm5v1qVrWHQ3K5nEnRn/yxDnAu205xUZTkpG1ANE+JjgVd00SZs1IfN4NYoTyPDbLUBVMDdZ7GNcyJEy14VGu5NDvQoB96WjRIZFkrkUJKqEE8MDihsQcFtylWjLOA/34e5kQ1U/j3SNMjGuWFgIfW1oa6ifLS0+JVV76jS4KZZ/vRGahDUtvo5SEi/afpAu5jcVaQue4Fdeljrrg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E2dp/hkETdq+jEJEZrjsC5obl1er0iJiFvNVBDPQVLE=;
 b=m6SxObc9R14gM1zhMWk7pQ64OI+8MN0lXOCANqRXx5j67WjGMpfrp8u3E1saADNCEAZmn8ZoBynPphLzw0BG3gIcmt9tBIT0t3m+jkrrGQA5ElWNCuHxdHJ7QOijuLdywwewYv8aAIdqmSeShXbXlKKaS/aS9/i7JgBXJBrS8uQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jub1P1W9aWqjaiMfXtJjh78b816ehRNsApMph+qtQSAyD9CCjKq4KBZv07JFF/cCuuo9RNlaUrHMKfXWDGcKPWsOdrWLd3ZDmD6zQTdTUVoHMa0SmeEz76jDKU1Ed4s6SGt5KBsRcm2eqA7QxjzLV8tXtc4LL9vkrGNeZ3Ywjo29ScVpEIjP5uv6cnFThKLdtAXPtz/P9r7todtq5+EZgGUQqPSRXLMdAdDSLSLRhcezzmorkOTVAMNfo905dNSO1EEkDdS5QkZD6I2JeAqHf289aa2R9f6t3bppJfxysLraj8MN910eyn1tBkz6MSS7CJ8rynkNgGx8Uogs++ZcqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E2dp/hkETdq+jEJEZrjsC5obl1er0iJiFvNVBDPQVLE=;
 b=X9G5I8SfdbOm9g9XnKz/dIMMxge8YjyVfC5AfVytg+M+Z3nTznaUN9+vBr5t+dc36InVwAlOLmAqCsvycoC1J8pkg2f7JtB0sPtx8HZ5MSpPU9KWIhpfCB6MXvXMySKeMJi0a/wzTikc7JrT9FdrSU/qJTxjuXt5BpMp4GGRiK5VuE/C/I99YnR4UI6mf+N/r7+sp7r6WaGUKY96Oi1m1pvPAh/IihtakWXzOl6TCHvcGPaDJf2hR5+0mHAgBKVtF4qkbCpcXN+EVNi2xlqBs+xE4t/LwtOQJ+2mHHRku1P1maDfjeHLHnT5VYC/qhm3DLYaJaiRTgfWyxU8Gqq89A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E2dp/hkETdq+jEJEZrjsC5obl1er0iJiFvNVBDPQVLE=;
 b=m6SxObc9R14gM1zhMWk7pQ64OI+8MN0lXOCANqRXx5j67WjGMpfrp8u3E1saADNCEAZmn8ZoBynPphLzw0BG3gIcmt9tBIT0t3m+jkrrGQA5ElWNCuHxdHJ7QOijuLdywwewYv8aAIdqmSeShXbXlKKaS/aS9/i7JgBXJBrS8uQ=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <jgrall@amazon.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei
 Liu <wl@xen.org>
Subject: RE: [PATCH 2/3] Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen
 4.17 RC1)
Thread-Topic: [PATCH 2/3] Config.mk pin QEMU_UPSTREAM_REVISION (prep for Xen
 4.17 RC1)
Thread-Index: AQHY2i0iNvIS4M4430ia2nWq7paZZq4CrrIw
Date: Fri, 7 Oct 2022 09:45:45 +0000
Message-ID:
 <AS8PR08MB7991B5B1F05DCB727BDA8203925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-3-julien@xen.org>
In-Reply-To: <20221007091341.58542-3-julien@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: CBADD725FA84B749A88083E5CB0841B2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM7PR08MB5462:EE_|VE1EUR03FT059:EE_|AS4PR08MB7856:EE_
X-MS-Office365-Filtering-Correlation-Id: 6e23a8ef-9081-427b-b1dc-08daa848baeb
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 W9iiXoim7OX9uQhr9Gjk+ZVm8aMTlXUE+j3XwLlLxJn+eG6fu0z+CMCEpVD7SC7gHo29tAWosGKTRgdc6QBBFH9FSzhJqgNJCQgqJKFBUENcZvXvmjICbsPjgSJFDvVgVKz05CsnffNcoLUx4jM/fz/dluhL7lA71WaOW67DoxepFo7IsajNmuXzgEhhFmh4v3lbeHxhbYG5HaVG3j3IDNE/kNVtDHr2A10F+EJrThZDVpTkYkEAhjggPHLmrJOhZEDe9KpIJUc4kW93VnfKKzt+MsKvfL9lFxW6vw3eLQ4x7gKvUPvxIFBUYIPSaqByTN+tpcxro8xJMjHw16fe9TO6WZVe3Jsv8U+tB/mo41TzgKGeQThXbH0jZkdZFENlCU25cjzPaVrk0RBs8SNvMDsmC3jrZ7LNTm76zJ7NZd6Z2jV90bCoPPcXFYZbF4Wp/FydSGwnZmzb/xQ2ldDJZQIDUPXyIi9eq4Ru7u9nDN0dwseMJ6nXuXZpDzrqr958DltEaRrrb1FBr0KHLa+n+MKMxY2CaT1U03cada1Lv2mBS6VO7J0W1ad39/sHhJr950sFDq06sngh9xO6eXuVUsRIGL/a/OxfNu+Zl7/2XdwpGNGtmQmvF8FJvDm/7A8o3dSPOyA2uIoxxB8YcHYxaonY4QMUnP8OjDBKTlWwRMPDg0edcDXmpxi0YATIU9jBRMfFgq8XTES2fpI/eiAEbPvwk487Hop+xseEFEFPkQ5r7VMi2ILKlQZXbebkWlurot8y/2NzocIPMan1SeVctA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(346002)(136003)(366004)(376002)(396003)(451199015)(122000001)(38100700002)(86362001)(558084003)(55016003)(316002)(71200400001)(110136005)(54906003)(38070700005)(52536014)(66476007)(8936002)(66446008)(5660300002)(8676002)(66946007)(76116006)(64756008)(2906002)(4326008)(41300700001)(186003)(83380400001)(66556008)(7696005)(6506007)(478600001)(33656002)(9686003)(26005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5462
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	52a532a8-3c2f-498f-98c1-08daa848b4d2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q79bGMsR+/4rCVazFv1y0zvd46x5JLVQESb3Oat8hITjfjOYVN5UCCLRFFY2Ur3NU3eJTPYRRraQ8zQR4ZCG5VpYNl48DZRCt5XHe4laCujUDS60iRPYH67mj4ln7ZIN5QjinnDAmglb4PfcPb+COaZ4EVofB1Yn9z+Z0Tle42mUyUfMJ1w9XHMuleEkFJkqQ7TjS/nnEP7FKDKFsCbDuqfRd6LGmz+rv5oeqluOKTFIo4SoEtk3UMvQR9x20feL0CiimV006awZNnkj5fzrgEE0F0dbiBIHd9byij5LRLeh9HieiUnNlDRmX5V+dIwYhUkCFxfwWqRD0q4+Q/caPuYVe5SxnlhlA38/Z+/I0wF4YEoRzvaBlQFdsCgMfdTmGJJtDCP8moN9R3FWVSpg+4GsIsnPb6oK37iSudj+RH3OeMCUBYT3zASqP8/6bq1vPof+Mo1wPVb6UmZ7CDOuKWNQbt6FotLOAIbPshY1bG5tx7NiFtMt04cXUS+bXJwxmqL+j051Q++oVGhlYL/H0Mk7vCsHpJmu9hKMCNAqr+UBqB1Ndpbh/Ugejz6YH9I26JzOpXPteyHiWIt0btcVaqek4fImRmmSTbHD1KSQCrfj996wpwO2E6gqoPY6mG0wxmOnL4m0ocRITq6DGwDC2cqApMkbg1qbNsUaEEatvxzNQzIHackXIOp5qQagv9LTSAxxnTfcfalpkQG7Fgu+M19DCIOPEDOdNxLkrMR6UTPGkSJNyJpRmNwgpAD66O92JO0KYvpGVZ2ntytQde5xsg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(9686003)(81166007)(83380400001)(33656002)(86362001)(36860700001)(356005)(82740400003)(4326008)(41300700001)(8676002)(70206006)(82310400005)(478600001)(110136005)(54906003)(186003)(2906002)(336012)(55016003)(70586007)(7696005)(40480700001)(40460700003)(52536014)(316002)(47076005)(6506007)(26005)(8936002)(5660300002)(4744005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 09:45:55.2318
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e23a8ef-9081-427b-b1dc-08daa848baeb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7856

Hi Julien,

> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Subject: [PATCH 2/3] Config.mk pin QEMU_UPSTREAM_REVISION (prep for
> Xen 4.17 RC1)
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:51:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:51:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417547.662289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogk0w-0004Tc-4I; Fri, 07 Oct 2022 09:51:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417547.662289; Fri, 07 Oct 2022 09:51:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogk0w-0004TT-1N; Fri, 07 Oct 2022 09:51:30 +0000
Received: by outflank-mailman (input) for mailman id 417547;
 Fri, 07 Oct 2022 09:51:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XcYz=2I=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ogk0v-0004St-5l
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:51:29 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2056.outbound.protection.outlook.com [40.107.247.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9cc56068-4625-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 11:51:28 +0200 (CEST)
Received: from AM5PR0301CA0018.eurprd03.prod.outlook.com
 (2603:10a6:206:14::31) by GVXPR08MB7725.eurprd08.prod.outlook.com
 (2603:10a6:150:6d::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Fri, 7 Oct
 2022 09:51:26 +0000
Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:14:cafe::8a) by AM5PR0301CA0018.outlook.office365.com
 (2603:10a6:206:14::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend
 Transport; Fri, 7 Oct 2022 09:51:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 09:51:25 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Fri, 07 Oct 2022 09:51:24 +0000
Received: from ac388e65b203.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4BA4B2E2-330E-4C53-BBC3-017A80A28507.1; 
 Fri, 07 Oct 2022 09:51:18 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ac388e65b203.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 07 Oct 2022 09:51:18 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM0PR08MB5409.eurprd08.prod.outlook.com (2603:10a6:208:183::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 7 Oct
 2022 09:51:17 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 09:51:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cc56068-4625-11ed-964a-05401a9f4f97
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=LOsMVBiIu5Gc7sF+/5AkF1HFHQPYfVhlaXonEw52UtjAB6aPuOnXZWYGzTBHYOphAQW88J9zAazwAfOgIor8D2ml8i5GhUbZf7ewCi1pQ+Al+7gGskkuyhzqccXQRIPWteOj2M5m5xbT0f6GQzIvm3vjoR3hAq7Dhn4jFls7yB7nQfhoB3kC3D8PuxRZZkSeM1qC3/4mvZIbaJ2jM5Z8a8+n26nFd9xOZdOMiLs2Pk7w4AA7wRhKEJ+1c7VUp74JpJTunZvF1X43St/yu3InpARclaOj5mKtxqlA5Rr8adOy+DG9QSQM1nkTEJA87uRo2lqVo5D+ggVYw3dZORrJVQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wnVnkyePrP+cVWMbAEaV9fneWzzWRCK1BkSotP3Vp24=;
 b=W82kKhirnkEB0VxeF6Ev7NUBJXE8miRxyFSaFt3TXxBgbK1fJUNcYKihiXdXBHOoaEsd4GrMKfywSAmUU6WJ4J/emuYjITrHeoRgwm6WlVBd0kIrNbFOhU41r1kinx7AW/tsb6Yiy5lv6KkzjLwm28skVj2TTIEKbmbcsrGwguQQLZmIE8utVOr9GG4cziN4ZrRRAKFJ05cFYPB1j0+0oYXJm2OuEhOx4URKPJFK7c/wwKcy3JyjNNCtTPbGgtWadvRNunVv03blgXivW73h2xR37zGRGmYd1UjGGaROqupvUuzBEZ+VGtYGXQghEgWw2bD01twPxgdquePWC//pNw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wnVnkyePrP+cVWMbAEaV9fneWzzWRCK1BkSotP3Vp24=;
 b=9qEOiPwyNaVDjT/Pw6SNgnpwTkSWC4/0Ku69ikca0u3JERrjb/+ldmmn7LHOWA4BA21QGWTXktmqlGtfW8Coi3OdG40j/cqYtBDCwV52jbTswzy3af2zBx+zpBcCZbxPOo66ERExrG0aYjfEqiK3ejENYQu1/XPDZd5TKodSaoE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=em9E3mULK6utSxbwYeB1tEdtnEPAXg8fBKXZU8qRHL3aiCqhLwk44/i1WswS1pP3XRYVcEvU9dYVwYvEuNMDlbxdLR/lmmHvDrTk9MxW5wxYLDADVtiYH+WAtGnCfMK+7C9axP89HI+hVl7crkAE5DiuEb/sw2wcMyGHLrLZq+cQ/a+CaRAPsg4CXrSeu2UG+cX3HM9JBwWsWzJrNeHhBsO2YEsnXbOLHjT9jIfILFJdqo657/Cl69DX2sDfOhLrykqTy5yTMfMS4u9SIGmtzOPlVooH1PPjSf4IUj3OYJSb4IOyC4m3so9W/aDMxAkRw9IxfaxUJpoUkMTOVpY+bA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wnVnkyePrP+cVWMbAEaV9fneWzzWRCK1BkSotP3Vp24=;
 b=RIG4dK3E2/qp7THjaGYQrJStPatIR0eup4E9dBF6oCHXhwSAMj0b8C2uabzKa4CLopahM5w9xzThgFsQX3rWeGGiLhpC+9UXFNpdVVSuzdJJrpaiGe8Xbd5a8s/zLBgEFMkv8m6Qxrz23eYUtyNk4TjfxWMB0QUkIodLhdqGjgNiYhrMHI1Uk+CiUjcvwkr1sup1Q8OGP6tkGzqdajzvlOiafAoBnZoHdXMYZkla7BPz7iA0LPkRGLoYT/6ZqEWpA2LepKUR+8s9suVmoHQ822zkXPd3C8nVO99Cqeim5xO99CwM6ZZbsrqqC/6/R7uPdNylDEx0dJD66V0H2fUP+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wnVnkyePrP+cVWMbAEaV9fneWzzWRCK1BkSotP3Vp24=;
 b=9qEOiPwyNaVDjT/Pw6SNgnpwTkSWC4/0Ku69ikca0u3JERrjb/+ldmmn7LHOWA4BA21QGWTXktmqlGtfW8Coi3OdG40j/cqYtBDCwV52jbTswzy3af2zBx+zpBcCZbxPOo66ERExrG0aYjfEqiK3ejENYQu1/XPDZd5TKodSaoE=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <jgrall@amazon.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei
 Liu <wl@xen.org>
Subject: RE: [PATCH 3/3] Update Xen version to 4.17-rc
Thread-Topic: [PATCH 3/3] Update Xen version to 4.17-rc
Thread-Index: AQHY2i0kbK3se4k2QkiZcyeFGqX6QK4Crs3A
Date: Fri, 7 Oct 2022 09:51:16 +0000
Message-ID:
 <AS8PR08MB7991D9B26480DCCDEA7DC755925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-4-julien@xen.org>
In-Reply-To: <20221007091341.58542-4-julien@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 8A75BC522F7E534AB3774E909643F43C.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM0PR08MB5409:EE_|VE1EUR03FT063:EE_|GVXPR08MB7725:EE_
X-MS-Office365-Filtering-Correlation-Id: a95a64d7-d4a1-4e94-2cd7-08daa8497fa1
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 c90fqCcfZi8iRAtXbpbQTphOH6CHR0nygjxM070tB6evP3TvFKC77ZjzJD8qSy0qc1akDDvcCz8LTS1ReOR1IA5qLwiCGfcRaSgMUj42J+V2zCM4fE5LfxilnL7Ekk4+nMJHBIem8GJ+3AT/vzLgTV48keZ2stibejr04iYOaQgm/lGLel4SfI7TT7Y8MHaSqIH5s9NaFnnfiDmosQI1Q/d1DMJsxLlSMy4mrClF3ufuCeDajwxH/f5Vubbe0x0EF1HrbiRqXJb/+pG6NkP60UgGtFc8HwBRrYjZqRV6uPRCyVbRRBoaVhlmtUBgh2rS/DUY1ZFKJe7GMOwM49XhQxrCe14Vc+57yK7Eiuajnnm29UP7fVf91Ig/VUKrL/veb62j55dRUvi3FcQQ7wD8nFhUX4PkXdpYY26yEVc7d9EKjHMmTrceKR0VDxLAkvfAKCzp+b9sGCaImEjE+IdSZrsmIQb8zvkJirhUI17+6e5hMsubmCZTzY6IMT3LvHV1W1ZW8lx2bNDPwMgBwGHcqHAJoNB2VEHxTz6VgGG4QTXw3zcELjkz4sBmpo/Xn/3XQ6bzGjFDgEYsoMPdk45/WILugud2TiFiaMijzARPbd6SIwfPlHQIaUlhkvqhcX6DcOo4UxqW5IJueXo3u420Oov/lXIXP8KoM9FsYywb547JVisrTxRbGFsQNzC79E1haChcb3EkDXIvnuA77Rt3+vPQc1oOONq3C4GPV8zrxDbY5mkt2nvmZeoVAPRC2lSf7cm3X+1Xb3yGewSppT3F5chVbwisIr1EtK9bJBg+Naw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199015)(86362001)(52536014)(122000001)(186003)(33656002)(83380400001)(38070700005)(38100700002)(7696005)(9686003)(6506007)(26005)(478600001)(54906003)(41300700001)(2906002)(966005)(71200400001)(110136005)(316002)(45080400002)(5660300002)(66476007)(64756008)(55016003)(8676002)(4326008)(66556008)(66946007)(66446008)(76116006)(8936002)(15650500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5409
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1209a301-0a74-408e-05f5-08daa8497a85
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QltLTGp/Kr+uziiKcF6sWJkQoJDOGQ/yxrkLpazeeN6i92Zt3RqIdj0bJC6uBzMJe+NC6bFi07bzlnhQhqY+hV+656xhkkHfh41MtVNBvMLkZkDcD/aDe+bJKbhKwElt31tq27dp/cqNMohT3KuRvoWd/3L8DWNcbCvxndNXwBhr9/ynv+3nsgJT+b8Wacboj6AK6rPgll6ucpL3pAG5pvkdrhh4Rq26eO2SuHf5TCX2nv33QuY7+vvEPmbn5oSyw3yEsmXJmL6j9p7Y5s27gL7tW9OjFZr/BRU1oKgU9zdsmOsuzZ6qvOCuFRJ+7i7iKSufD1oFNQLZq+cSjsKbKIx3Ky/B/BT2wnIKoukmBezI3pbrtzKoP2cN7vMCwsjKuJBZea1PhbN23kXLGBJjBC36SE4Lquq0RxXTWnGN5coSgk06hBklcwkTU28Ad2VK0sWNJ10uZEsP4qaqb9oJATm/STQxjP6bbOjcEQfthzNLIViott0511Xrj+b75Hu+x0cMK87eMFJU5xk6sUtUySJ39Fz9f+QavH7woWN6YWfC7CXNs36yls1hDTCSCSJRoRGyAHQ5qa65hCijgeGSdrgv2CTM7zsthkStCXWyeawuqy+vC5HrDM+eH9yCfB/MdpuUuzn0MKKc1gwEVOPnqqGRacIrTHEz9nw/B9DlHmBVtVtly6MhCwbKCpHUekexz7PhCz9xB5sTVufJ5ZxX0jehWy+a6Qs8uUd0in1pN6U6x4xL+yjiAR/jxKkuagLWcjx6vZ9ofnj90RUeOTg7rWmIR2+oSoz9cAJ7Kic03Z0=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(81166007)(8936002)(2906002)(110136005)(15650500001)(36860700001)(83380400001)(40460700003)(70586007)(356005)(316002)(86362001)(70206006)(478600001)(966005)(45080400002)(82310400005)(8676002)(52536014)(54906003)(26005)(40480700001)(7696005)(55016003)(4326008)(41300700001)(33656002)(9686003)(6506007)(47076005)(82740400003)(186003)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 09:51:25.2757
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a95a64d7-d4a1-4e94-2cd7-08daa8497fa1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7725

Hi Julien,

> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Subject: [PATCH 3/3] Update Xen version to 4.17-rc
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>

I am not very sure, but I think the name should be 4.17-rc1 since
we will likely to have rc2 to rc4 according to the previous plan in
xen-devel [1]?

[1] https://lore.kernel.org/xen-devel/AS8PR08MB7991DD9E3E7C966E9C6DCA03927B=
9@AS8PR08MB7991.eurprd08.prod.outlook.com/

Kind regards,
Henry

> ---
>  README       | 16 ++++++++--------
>  SUPPORT.md   |  2 +-
>  xen/Makefile |  2 +-
>  3 files changed, 10 insertions(+), 10 deletions(-)
>=20
> diff --git a/README b/README
> index 89a1d0b43c4c..2fdca8861bef 100644
> --- a/README
> +++ b/README
> @@ -1,11 +1,11 @@
> -############################################################
> -__  __                                _        _     _
> -\ \/ /___ _ __        _   _ _ __  ___| |_ __ _| |__ | | ___
> - \  // _ \ '_ \ _____| | | | '_ \/ __| __/ _` | '_ \| |/ _ \
> - /  \  __/ | | |_____| |_| | | | \__ \ || (_| | |_) | |  __/
> -/_/\_\___|_| |_|      \__,_|_| |_|___/\__\__,_|_.__/|_|\___|
> -
> -############################################################
> +###############################################
> +__  __            _  _    _ _____
> +\ \/ /___ _ __   | || |  / |___  |    _ __ ___
> + \  // _ \ '_ \  | || |_ | |  / /____| '__/ __|
> + /  \  __/ | | | |__   _|| | / /_____| | | (__
> +/_/\_\___|_| |_|    |_|(_)_|/_/      |_|  \___|
> +
> +###############################################
>=20
>  https://www.xen.org/
>=20
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 29f74ac5063e..cf2ddfacaf09 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -9,7 +9,7 @@ for the definitions of the support status levels etc.
>=20
>  # Release Support
>=20
> -    Xen-Version: unstable
> +    Xen-Version: 4.17-rc
>      Initial-Release: n/a
>      Supported-Until: TBD
>      Security-Support-Until: Unreleased - not yet security-supported
> diff --git a/xen/Makefile b/xen/Makefile
> index 4e6e661261ae..9d0df5e2c543 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -6,7 +6,7 @@ this-makefile :=3D $(call lastword,$(MAKEFILE_LIST))
>  # All other places this is stored (eg. compile.h) should be autogenerate=
d.
>  export XEN_VERSION       =3D 4
>  export XEN_SUBVERSION    =3D 17
> -export XEN_EXTRAVERSION ?=3D -unstable$(XEN_VENDORVERSION)
> +export XEN_EXTRAVERSION ?=3D -rc$(XEN_VENDORVERSION)
>  export XEN_FULLVERSION   =3D
> $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
>  -include xen-version
>=20
> --
> 2.37.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:56:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:56:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417590.662300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogk5k-0005jP-RI; Fri, 07 Oct 2022 09:56:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417590.662300; Fri, 07 Oct 2022 09:56:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogk5k-0005jI-Mw; Fri, 07 Oct 2022 09:56:28 +0000
Received: by outflank-mailman (input) for mailman id 417590;
 Fri, 07 Oct 2022 09:56:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ogk5j-0005jC-OV
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:56:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogk5i-0006fV-ST; Fri, 07 Oct 2022 09:56:26 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.20.83]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogk5i-0002eH-Lk; Fri, 07 Oct 2022 09:56:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=O871Yp72G9dcsWOFWbMCc0Qyt9pKblNV7o3dtQf4rL0=; b=f83LY8/gIcRbvgqxB0BMveP5vs
	ybF1a9bDy2sGkeRGWiqrQw8oTsovz2hFv1LbluXx33eUXeqt8MBUbrJhNSg1Gb0cG8cYFIVo0mTGa
	KQFuZ2ejSGsA+53bj2bQq1CepbTNSi5S27OUC4SXw4iKvHDzYGKj/OaSp5p05oyJxywc=;
Message-ID: <7fa3fe1e-a339-eee3-f3a2-2275d9add9be@xen.org>
Date: Fri, 7 Oct 2022 10:56:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH 3/3] Update Xen version to 4.17-rc
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-4-julien@xen.org>
 <AS8PR08MB7991D9B26480DCCDEA7DC755925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991D9B26480DCCDEA7DC755925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 07/10/2022 10:51, Henry Wang wrote:
> Hi Julien,

Hi Henry,

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: [PATCH 3/3] Update Xen version to 4.17-rc
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> I am not very sure, but I think the name should be 4.17-rc1 since
> we will likely to have rc2 to rc4 according to the previous plan in
> xen-devel [1]?

Looking at previous release, we are not updating the files for every RC. 
Instead, we only tag the commit with X-rc<N>.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 09:59:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 09:59:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417597.662311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogk87-0006N9-BF; Fri, 07 Oct 2022 09:58:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417597.662311; Fri, 07 Oct 2022 09:58:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogk87-0006N2-6x; Fri, 07 Oct 2022 09:58:55 +0000
Received: by outflank-mailman (input) for mailman id 417597;
 Fri, 07 Oct 2022 09:58:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XcYz=2I=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ogk85-0006Mw-P7
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 09:58:53 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2061.outbound.protection.outlook.com [40.107.105.61])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a59b0165-4626-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 11:58:52 +0200 (CEST)
Received: from AS9PR06CA0034.eurprd06.prod.outlook.com (2603:10a6:20b:463::18)
 by AM9PR08MB6178.eurprd08.prod.outlook.com (2603:10a6:20b:2db::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct
 2022 09:58:43 +0000
Received: from AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:463:cafe::bc) by AS9PR06CA0034.outlook.office365.com
 (2603:10a6:20b:463::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Fri, 7 Oct 2022 09:58:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT035.mail.protection.outlook.com (100.127.141.24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 09:58:42 +0000
Received: ("Tessian outbound 7e4a920b87c0:v128");
 Fri, 07 Oct 2022 09:58:42 +0000
Received: from d125c1403a3b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 99CF9B11-7906-4652-A197-50BF3C0084BA.1; 
 Fri, 07 Oct 2022 09:58:36 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d125c1403a3b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 07 Oct 2022 09:58:36 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM8PR08MB6339.eurprd08.prod.outlook.com (2603:10a6:20b:317::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct
 2022 09:58:28 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 09:58:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a59b0165-4626-11ed-964a-05401a9f4f97
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=dA98nOeLSSOBsLXJ8pJlz/VxJMaTeTOjw1T8Lc4fz1d/P//x/QNMti4Bp6O+zLdkCwlVMo74Kpy3yywjoskzzMYNRSR/wKeRHbgCp7RtbacdpG5MwP/KF9bfIVSdMzOB0VKI2vMfBQ4AAzFbUy5cDznW0RumMIA8ms3d0HWGUlJGD0NjTSCqxAO5r5sptlYD3Os3YaSBND7nOuBkCOc97C7WAUGVVQMqqEn6XXv9tPM/yIOMtrIBPQjDxMhhw2ruY+M4jRvJiyZ1/pU1arZIx5gFR4mH6BLv7hpRv+j6IIvmHZkuUXBRHM+fc+2wudbByU6qwRB62OikgczC33ZFZA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VUeQkQlnCZZsXM7MTZOoPtjGNFXH02kG+ZAB7YA2qes=;
 b=A49z10VMvMXE7oSLIB4R6LlFl+ULFW97++GuTrqW9xBEZkCcCWj9bl6qtEWlPIgk9ctQ2P0i0tp+vbZ4BWR91a4KqvLGbtOJnTTiEOaTsyZsjbQF0RFypHILmJHbsY9bS327/t2fvrtKWV9gVBCNp8OE5e4q6MN7zrE+11MmhpLnm9e2gOQ/rFIBv9l6j5bs9hsuEZHKTLrm93IRpVxox64CiGz2WiI6u3KQ10QVdbw/GxmptUogh9WC02+55luD8rUzzqmsbFhBOYIXql2A6JQWiN+2pzv9GUruqmAHf6N8J3S1iWWuO2O8BOZElwuPrVD4r+oVw2yrKdGkEEeSSQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VUeQkQlnCZZsXM7MTZOoPtjGNFXH02kG+ZAB7YA2qes=;
 b=N9URJO1ceUM38ePT78NuopP/R06FOc28r6eFctz3c+U87lcapnL9aUzvR2u0ItD6ZqrZbJ4ZHgZIgj9O1/no9+Tc7hZ/fzBhk+69PermPdz5I2Sm8cBU8AAyhv5zOwrnTdQNM0Ew9H62VA/RKTYAchDO4sZaIWix9PXu1L/BWe0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z0C9pXIbljzG5dNM+boXpTZgFFLVDmCJo0YCjTNhjKdCna3KvZV/dyqk1somL2/trCpUxOw/QhEsIvR+rvrYjffotXgjktW+hg4NuvF8LrGspnWlugrBN2G7yZYwRJipKgGW/20DfHDvs6hFx0nL9YroByC7pSDai3nxYqz2iefuT/XpLKz91K3RNUUbNs+45wiwiDHNEbt7OS8H6JXTGqJyWzr1+u6v06RUome5UUaFx+u1OCRTDwqjbbTbdKXyTFjuUljwog7OlaPhICRjhzrIEe6Wq3w7YmfN/GTZHCSc/wJt8sWpggmR13wrVRIZM2k5KHtpG51r9cG5oj+Dfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VUeQkQlnCZZsXM7MTZOoPtjGNFXH02kG+ZAB7YA2qes=;
 b=jlxgb3vXYRFR4yywt0zLuBuO9tnW4ckYCAyFpbohd3UsFIfs6PSDZFWItskuNRFcGLlIukJMwC3Bf9cKe/d68VKXn6+kv1Qwhxmhzfb8pXmI6cpDSW1JVudu0VRKNmxyJdxDCT1yt1S5+zpdPmqLG2TPxnBP6zk4/JLAQegNcOLszlVxNNCJF8QGcT0gzz2jip7QVjw9reNUr8CD5hAALmGRBmxkLG5wwUskuo2Dt3yikDUg/LInESXSDWqGWmYj9iYaJKe5/LL+3UixxcP9FkA4EkwvagvPgnoevSV3VrnW52n5vnV9idvdW3oTW4YEirfsEm/Vqr6p8ILEd4um2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VUeQkQlnCZZsXM7MTZOoPtjGNFXH02kG+ZAB7YA2qes=;
 b=N9URJO1ceUM38ePT78NuopP/R06FOc28r6eFctz3c+U87lcapnL9aUzvR2u0ItD6ZqrZbJ4ZHgZIgj9O1/no9+Tc7hZ/fzBhk+69PermPdz5I2Sm8cBU8AAyhv5zOwrnTdQNM0Ew9H62VA/RKTYAchDO4sZaIWix9PXu1L/BWe0=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <jgrall@amazon.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei
 Liu <wl@xen.org>
Subject: RE: [PATCH 3/3] Update Xen version to 4.17-rc
Thread-Topic: [PATCH 3/3] Update Xen version to 4.17-rc
Thread-Index: AQHY2i0kbK3se4k2QkiZcyeFGqX6QK4Crs3AgAAC9ACAAABb4A==
Date: Fri, 7 Oct 2022 09:58:28 +0000
Message-ID:
 <AS8PR08MB7991ADE04BDBDFB25D683953925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-4-julien@xen.org>
 <AS8PR08MB7991D9B26480DCCDEA7DC755925F9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <7fa3fe1e-a339-eee3-f3a2-2275d9add9be@xen.org>
In-Reply-To: <7fa3fe1e-a339-eee3-f3a2-2275d9add9be@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: ED165D1F58D592459A47A4F176443F7A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM8PR08MB6339:EE_|AM7EUR03FT035:EE_|AM9PR08MB6178:EE_
X-MS-Office365-Filtering-Correlation-Id: eccc49aa-92d3-4c81-390c-08daa84a8456
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 pumkomizexKaqYU+oQg3iz0GgjGn3XDjE2JwYL57DCGVVQ63b7VDFOJPjzrAbYnz496w7giIpgik/5WcpOPn22h6+H2RCZyIczo1kmCFieUuC2eBNRZx7BSkN/fUYmrQHMK+wtjnOmFT7U9mYT9K06EiUy7Vmc+mwIh9r0X8ehpoN+o/CQZqy32jUUgA3n879lfLcOV6188hVcIJSC0+SPsLfLiQL4rOu6ovtBvZJzqQvn21cIE5eCsbQtvdzTDmjTI93dDP4wiIzK4uIQXUHJnu5HUFnMJm2GnBCCcmecNh8/NLKkNo22PcHR6mX8ZEOl22aS4t/6aw1MHPPst/2T0T0SuaE8J5WdML/by9Oeee1LwGeJlXKQ+R0BYbZNzOyMSaJ667ywrQMBJql0wWv/9Hki7BEOPZj4nw2QJgzNhz5lbNoryrrAq20j9yjfJoLyHRb4uFAXqUdyjaUUch8VOf89fltFadpc9mgSpDfdRCSEE4SckaGbCPJA66FV2HRY00XRUkD3j8wpy57xr1wZzWRZjCD0rVyd02tNa16y5YCrW5B+hR6hcc8m2wfPaSPYBjKFaAHizfAYtt1CLxQrjrzesuIK6SjFcEncYsb4/GkUX/+DZ/quHDVxELZ6RorJy2Y7zl5UbJVeUZuP77JRxcOWpEpab2e7f64O+GJcWGOZG/B0Y3aFSb7L/lY2kOByD8ItcXOU2nw0egZBK8BlU82OhbrgR5wlK03bdPWLqc3BkE1VZGMAV1hw0UHvm8vvTr/Z4aH+bxJSanSsW8cg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(366004)(39860400002)(376002)(136003)(451199015)(6506007)(41300700001)(52536014)(5660300002)(9686003)(7696005)(26005)(8936002)(53546011)(83380400001)(38100700002)(15650500001)(38070700005)(4744005)(186003)(122000001)(33656002)(2906002)(54906003)(110136005)(71200400001)(478600001)(86362001)(8676002)(55016003)(316002)(66556008)(76116006)(66946007)(66446008)(66476007)(4326008)(64756008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6339
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9e39acbb-ce0c-4f58-083e-08daa84a7baf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pKSzgxSr2aw9VEgY/OxkcHfKzjWxxlRhAEutoE6fP9DSVWQVEFrcSnWi8L2fiJYCQi6nDATFOg0MI0ykkpgALGAA36umpVUg6OgQ6E5f6qSxvXqMzasMOXEBiOijy+7DcbUAsVcKTWkogZIWCzZS1+SCnY4QB3WGgxZKf09pJtNbGx1Yrvfn2xTaCYBrWUOKSn0dl2kZbx3/phtE63AE372qPSI6jTJN8N5qU1ABf+dE+cHXYsJGn8cVPWR7xvVV/eblqQacBPRzaW13CY0Ln1Ev+igFKkE4ezJMoxzEzrhz4jsG8I3gTHHmaOTg2XSXxCJP+R8E954AFODLAQkl/UnrdDcU9p66aHDp9c5Egit09Eur/Od91sF2SwcxgnulDtSdU9l/RR7e0oliAFQ2Xl0QZjDLcdy2XuayI0M5ZkFJtxogvcrgHDrdza299X3W0Pp2onJiAvGeXNRgJadPM1RjR9D+rxZGgffIw6gntbYEusxx9w+T3DMMqt0VOlw0cn0JRBLwSVwNP9WSDhyRTlHA8CM0NBAELppoRGrd3M6WqNh+pYAApa5iv6JUDZEoGAk/TB93sVV0bqdzzfNlgTTdq0/fUk/36MiDxgDDp7h2BOiItK9vCG3zh+HSyrbOlthSPnqzqft5zwQP2/LESAhVA6xLFMD7qctmpxFMp1/yudSEAMn8W5vE9CobVjenLsKGTypVqTJIp4ytQjZ1yBsM+pFZcyIuierga4xWpi0TCpOmJ4VGNAmQG+xiUmX45prY06eV9sU1cghK7pTKww==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199015)(40470700004)(46966006)(36840700001)(54906003)(9686003)(53546011)(26005)(2906002)(186003)(6506007)(7696005)(5660300002)(40480700001)(4744005)(55016003)(15650500001)(82310400005)(4326008)(40460700003)(70206006)(478600001)(8676002)(316002)(70586007)(8936002)(41300700001)(52536014)(82740400003)(36860700001)(83380400001)(356005)(81166007)(86362001)(110136005)(336012)(33656002)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 09:58:42.7011
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eccc49aa-92d3-4c81-390c-08daa84a8456
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6178

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMy8zXSBVcGRh
dGUgWGVuIHZlcnNpb24gdG8gNC4xNy1yYw0KPiBPbiAwNy8xMC8yMDIyIDEwOjUxLCBIZW5yeSBX
YW5nIHdyb3RlOg0KPiA+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEhlbnJ5LA0KPiANCj4gPj4gLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5A
eGVuLm9yZz4NCj4gPj4gU3ViamVjdDogW1BBVENIIDMvM10gVXBkYXRlIFhlbiB2ZXJzaW9uIHRv
IDQuMTctcmMNCj4gPj4NCj4gPj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv
bT4NCj4gPj4NCj4gPj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u
LmNvbT4NCj4gPg0KPiA+IEkgYW0gbm90IHZlcnkgc3VyZSwgYnV0IEkgdGhpbmsgdGhlIG5hbWUg
c2hvdWxkIGJlIDQuMTctcmMxIHNpbmNlDQo+ID4gd2Ugd2lsbCBsaWtlbHkgdG8gaGF2ZSByYzIg
dG8gcmM0IGFjY29yZGluZyB0byB0aGUgcHJldmlvdXMgcGxhbiBpbg0KPiA+IHhlbi1kZXZlbCBb
MV0/DQo+IA0KPiBMb29raW5nIGF0IHByZXZpb3VzIHJlbGVhc2UsIHdlIGFyZSBub3QgdXBkYXRp
bmcgdGhlIGZpbGVzIGZvciBldmVyeSBSQy4NCj4gSW5zdGVhZCwgd2Ugb25seSB0YWcgdGhlIGNv
bW1pdCB3aXRoIFgtcmM8Tj4uDQoNCkFoLCBteSBiYWQsIHNvcnJ5IGZvciB0aGUgbm9pc2UgdGhl
bi4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0K
DQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxp
ZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417682.662396 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf7-0005AA-Uq; Fri, 07 Oct 2022 10:33:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417682.662396; Fri, 07 Oct 2022 10:33:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf7-00058M-Hf; Fri, 07 Oct 2022 10:33:01 +0000
Received: by outflank-mailman (input) for mailman id 417682;
 Fri, 07 Oct 2022 10:32:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf5-0004P4-H4
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:32:59 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6812d72b-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:32:57 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978P174005817;
 Fri, 7 Oct 2022 10:32:54 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjk3-6
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:53 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:48 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6812d72b-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FOU5Aq74f7Et7kpU/iC+iUbECEoxq1J0mKXp8GRh6pLSp7b1+V9CBPx4JOEOE2iAyuOVenUN97eE2XUb3egMbdSgJhZTZ39xN9pyhzLJ64hFn7K42JN5aQSgvMIC2/PAcvx1OY+IGlehAghxr3VFRxsUEm9usk4Szih+zFjMrMI5ZLpitK/WLV47wCMMQAeqoOr27hxEsphqgiB9FBEE+IdZzL3CuessBDevMA9LHuIV72A/QF6q6MApxdCQZnU4pZXr7iZZAmabFpnFu79Z2Z0ccHImXjOScXfzzLyD1mj8ZQp+EIGP/PLqcucGu8SuMO/JN1zIOcNAD8A6ty5AXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P67wZi9wRvsTNIiKgd4NqFNYGAuUHcR/ii4CMj9fkQk=;
 b=Q5Fo1lUabUqeX6lcHX5+UnsbgaW83W/DHpvNoQxvzUqClJ8j4OSVOokuXf/QkVbcmn1510feey6EVjd7fdm07rWNyQVTsjLQ3GqTvk98jWcKFJDSfvYqN7j8OQJ5G5dexHXaIoZyv/wmv34s2c4gGEkoNSOUmbFiq2qJhygm6/zDeadQ1q7S+IpJYoGyIFurWDiw/wScrX7VKnVIr2Dv74qKKZXJ/CkvaA2B5+ZbUfUqaRcXw/RnA3kpPqvZEd1YGzW68taKziM/fT8rSpHTOU0ttPl4GIfuLxHnRNtMvCakW5+DumYRbx4OJGv5ky9+PDUU41knqy4QLClqTTIRuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P67wZi9wRvsTNIiKgd4NqFNYGAuUHcR/ii4CMj9fkQk=;
 b=lLqN+gs2XLVIMAqnZw5fDXVtLt4f3pLDiNdCoG53nIadtF49Yq4OH1sNHqDNFUnwTVBM2R+YWWpmH/poI7aOhd8kQ6uXRVvc8Ek/DILnugZuKSMI4iTeu5SdrLibwmVsTkjfyJKn37MEMmAnQV5+jrCwWSsI4AImoSrjAJduXkhzm/PnnASoYB6B2d+6Cbps74SxIgs8tjLnOkU0Bma8gMpxKR4dqvLirpah97HQNmQ56G+HFR3sJEzDn2RHPOKILXRvKN8RzNVaETmzrPSkFNrW+/hbJv8nr4lK8wPHbEKINKWlfLQYLT/d2PVpypfPMAbuGoMIU+qJce8TLPFuYA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 07/19] xen/arm: Disable/enable non-boot physical CPUs on
 suspend/resume
Thread-Topic: [PATCH 07/19] xen/arm: Disable/enable non-boot physical CPUs on
 suspend/resume
Thread-Index: AQHY2jglFRIa/47fQkyi/IjVCOcpsw==
Date: Fri, 7 Oct 2022 10:32:48 +0000
Message-ID: 
 <74bf02f1c6c5280f2d79b9cd60515895e8ba3319.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: dc1d985a-8b31-47c0-deae-08daa84f47ac
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 HLDbf3Sz9TBZJU3alLbtm3k8z+gy0Ix/JNcEAmzvHU/fbAASF+fz7Bzw4Bs0sI77K2wi9Aws0Rk0RDsa9wTtcJCP0nwUOBZdbyRHe0R72C1Nceee7S4EHuyRgXG0s/w3ci2UmNc9NyZSzY6mPWKT3GKFWV8cQp3OFHA52uptZIIG0vxwY6JgyTGxcoa25EyWkJM7zJtHemNXYo3MYG0+lXEeHxln8gEEHuSetIdx1lEJrCJuKDxkYUPMS3dLDdwviRNQZEqPxH5Xsme01IAqGZfhYhT+SDuqYXlBNXfUcyLdiCRrnAVeSxi6RP6mT1Ms09KWse0pPYC9k6MD/XalP/Y1IwhlE76PUtuKlQIE2qzxRJSAC8qbPG0Ig1CdkjbKI1genh5/iKmOHURjEo3SRTVQ8jhjYrjPrjalqxPayUyLzEEUSzBwpS4D7zWixe+ia34uDbcSpeynopC2f2WxLd/fpIEZuLScpT6HrmeTlLNQZCIJVJkJCMGPtOOm5y/haFAeBBSZgPyQvVUg1jGsrnBor2NY5f/PAoa0xEKeQdp+1jIonZSchu2Gn/l/Hmteea8x9iUi40KU6AQzkq/bnAtPLdOfWxnxyKvhOvW5ur6LUHpV/FbpD9nrBckx1LcVlD3szL2mgLCaMSEonAvRfvyMi/AYeQumcs+cGLuty78SnPYFxtTEgEMG+rHJCXZ+F1/JlcyQNam0ytDa0zTI7/0DH2JW3VB3IO2H0+etCLD6L4qxU8V/ndneK7A3+FlCOoRP8phgjBBPnKVw7EOdAw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(15650500001)(5660300002)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(38070700005)(122000001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?ekAGhs7Tw09gAl7jXa2f0W5XssVNYbexeFfiP3BgOYim37KCE8HK2dSeU2?=
 =?iso-8859-1?Q?CQ8R2LVJqVjIxICOk8tUyxGucCKLNhi6bzLUgoghjieRNdvLI9fZtRT+Pn?=
 =?iso-8859-1?Q?6dUA/BebEH4/iPWACf8ED7e8Akce20RVcFYboUEwAUDdj0PA07QWaDMMCT?=
 =?iso-8859-1?Q?ZQj4IwLVN9Rr+paclZTBNWmzFGF6SL3XfoQj52bhyTufwHtlbO/K0T+j9t?=
 =?iso-8859-1?Q?ADQF5yV9x+O8TqV5H+LOl95O2NJG7+OUky0w1ciZHWdlb4MseOwd+010go?=
 =?iso-8859-1?Q?ZEfw639kLtoZB5TLEWoztoQ/4vnG3d99adGRKBu6VQav798QU7uS5ZETRx?=
 =?iso-8859-1?Q?+V5klR5EyHhql8ibFxUb8riddMT5lqXFIAaXA7BRxhtakrUOHItA8wIMUy?=
 =?iso-8859-1?Q?AESGECBiEk8czgMLUOusnbsTL0LCiBqAjAnFpd8i1TrJr8SkWhvYjXrPDp?=
 =?iso-8859-1?Q?gRqZRvidD9xuJidmQRbXOG9tIs3Ln9B8Ik5BQlV0/eVQkUuCX6egcnJCiU?=
 =?iso-8859-1?Q?B1ShI22IeIP/uFlz08MkBJIDaV3sy/o+lC1mlDedNdYWlp6co69oUvEerP?=
 =?iso-8859-1?Q?tBnwUXClg/0O7yemw6fQQ5Z0Bw6S6sfnxoUE8K3kT4rsFR51pke21z+tY3?=
 =?iso-8859-1?Q?QFZRN8RxMe5Sdvp8cmxbjX6yc83ypgY7374xn3LkeGzxf+sYDgfiMbaSMA?=
 =?iso-8859-1?Q?2TH0/iUkazEcaGrlXt9TlHLfGRtfHz/y8KUx/ottt14rUSTeTSx3AYnQch?=
 =?iso-8859-1?Q?Fy7K357QDp2k2gb7dXZNdad9WIUcaFQm0l4TuTtCrEkHzVU+jYdEWtbqdQ?=
 =?iso-8859-1?Q?ltbMcs0sPzyLUrXoGZXJ+/EoeJl4pZlqdQ+nlsjQqXfdDPaoBwAvzJML11?=
 =?iso-8859-1?Q?iuHyYV52isOaEUPlQSUQLAnHNAnz8BhXdVctJV8R8xGXACObrb2g4reV4R?=
 =?iso-8859-1?Q?mpgG29Hh7MS9PDtnWi0KoD/xp0W0XLMlm4D1wcrR53pPHnWiJduy08Am5B?=
 =?iso-8859-1?Q?YBmatHKLQrzbTuzg/ChAP7BtuLejEv6iPafKiy1zONhbct6XMPtU7Rzd3N?=
 =?iso-8859-1?Q?yw8oi8n03Hc5OT3Um6BxqIeNLtdX8I4ZJ8j37gbvaTH/doWIDBVvarbxub?=
 =?iso-8859-1?Q?cd5OxO51oytLSjJbD2gxFpRjtSYsIG2RI/GzR/17nFityu3EZM89whn2bK?=
 =?iso-8859-1?Q?xPmvGBwpYUHCFb0uTNjJHt3vibmhaL6IIHm3mKA7HjKodFNCj5l9VfZ5lH?=
 =?iso-8859-1?Q?JPl0N4po22wEyxtD0h9HUv2dpf2eCkE37e+jM8yW9dejduIPvQlI17cpxJ?=
 =?iso-8859-1?Q?z918oOfABiXrxPOLb2la1jg9PGHMxbiNje2Y3LA7UJ+n62TQwPivTmht6X?=
 =?iso-8859-1?Q?fb9G0Q/B8vx++inxMKxHba/k7rW/X84aILF/Bttdec1TWFQFDCJ/vfcKrQ?=
 =?iso-8859-1?Q?plA7Qu/moS0AXdbt7/nomo+4JEyVBDuUCwlCTIi6HqkbIz9A+GKaCFbdGS?=
 =?iso-8859-1?Q?P8eQLlTDnY+fCQuh4VPSNsdcBYGc8npaJl71Pl+UTq576cgS9x3780jTnP?=
 =?iso-8859-1?Q?o5vkEQn81uHpuvi9FvepmLEDubBPsdQo7WcvconwTk1PjbS/DBzcunnWkd?=
 =?iso-8859-1?Q?tXP+W/OpSz1fqJrwREZib6VGYP18rePzkiUz6dYYOsGqKqJr+MdCyjmg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc1d985a-8b31-47c0-deae-08daa84f47ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:48.3490
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2bUT5wOJC/iQGxH5dBNbrTFzw45901mogBX1DGXOeGA2gSXY94G1MoIJ6W8zMv1L7mCvR6sheboqEhIUMN1QRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-GUID: yyx5z2NBX53xCa659FGs13DAOFgEbfZS
X-Proofpoint-ORIG-GUID: yyx5z2NBX53xCa659FGs13DAOFgEbfZS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=772 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

Non-boot CPUs have to be disabled on suspend and enabled on resume
(hotplug-based mechanism). Disabling non-boot CPUs will lead to PSCI
CPU_OFF to be called by each non-boot CPU. Depending on the underlying
platform capabilities, this may lead to the physical powering down of
CPUs. Tested on Xilinx Zynq Ultrascale+ MPSoC (including power down of
each non-boot CPU).

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/suspend.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 2b94816b63..0784979e4f 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -13,6 +13,7 @@
  */
=20
 #include <xen/sched.h>
+#include <xen/cpu.h>
 #include <asm/cpufeature.h>
 #include <asm/event.h>
 #include <asm/psci.h>
@@ -135,17 +136,29 @@ void vcpu_resume(struct vcpu *v)
 /* Xen suspend. Note: data is not used (suspend is the suspend to RAM) */
 static long system_suspend(void *data)
 {
+    int status;
+
     BUG_ON(system_state !=3D SYS_STATE_active);
=20
     system_state =3D SYS_STATE_suspend;
     freeze_domains();
=20
+    status =3D disable_nonboot_cpus();
+    if ( status )
+    {
+        system_state =3D SYS_STATE_resume;
+        goto resume_nonboot_cpus;
+    }
+
     system_state =3D SYS_STATE_resume;
=20
+resume_nonboot_cpus:
+    enable_nonboot_cpus();
     thaw_domains();
     system_state =3D SYS_STATE_active;
+    dsb(sy);
=20
-    return -ENOSYS;
+    return status;
 }
=20
 int32_t domain_suspend(register_t epoint, register_t cid)
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417677.662358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf4-0004PV-MZ; Fri, 07 Oct 2022 10:32:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417677.662358; Fri, 07 Oct 2022 10:32:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf4-0004PG-I3; Fri, 07 Oct 2022 10:32:58 +0000
Received: by outflank-mailman (input) for mailman id 417677;
 Fri, 07 Oct 2022 10:32:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf2-0004P4-PC
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:32:57 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66a6e553-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:32:54 +0200 (CEST)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2977riw9002988;
 Fri, 7 Oct 2022 10:32:49 GMT
Received: from eur02-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2054.outbound.protection.outlook.com [104.47.6.54])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k26unhxjy-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:49 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:45 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66a6e553-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KMC7JkhV+J/9z/lC7lqhRk023/VvOJ5u+PKGwAbAFLa+MDm9izEvqvTxPW3rfNya6xmAFh6X0JSeLEr6CYjzJD/p/8vKIDHpbDuX29k2NcxVVPoga/ip0N3vQWX+sNkeTPxmgphs7z1J4on6UFaCCROXQdSo6/NARiHX6vXIsMp2KbFc3KeGfK9vbNN7V46u8StXF1RYRnCC+n8g2y3dKG2ASfcWt8zX4jk0bkzh6JGG3CYdRQyQn/MkVZPXwnsVxRBCBCf2RhJhaTMNZhImXWKMhqP22uFi1Qn+L41tpNwH/R2v4jOi0ohkqzYg9hRVDGnMvd6s47NQTGJ7QJwprQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZmVWcxM9/DbUaCNEQfmMZgnERngyZjpgdvYuQaC2TtU=;
 b=m2lPa8IU3n6ZJtdmeYb2f9oqGHwA2nySshTvUbSWRIodJ2PXylYcHGZlIg5QxWqEkRKyUcTkaLrencPPRMpuUiF9GFp7QqzSu6+nwIdlaiS7iD+6gFhS15CnjRoGVxRg/obP57/D1HBwN/G8TWEQBFwPLqGvDuN2vPBigeTY0V0ZMnaAEsXAP9cMK8U5sg40Zm5R77GXXDXilnebBIiROyapn3bbMtiAM6DuN71PgoADbcJGfqKlbtOdHdjzROWoFe8iA5an5yHeZq8gEcCDUMLazYKs76XLxh1JhIpz7xAdkVF6h3ZaGRc+u277E3YyTP8QHm7H6ijze0VkY1LfjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZmVWcxM9/DbUaCNEQfmMZgnERngyZjpgdvYuQaC2TtU=;
 b=ech1twBvE+z+rQrx9vYjCHUyfuYHT3eZPEluAfsDE1gT5q9+/5ng02EctXp5GpeZSca17edF0Tco2ISYMgRqp9MU0V5NXsEB2h3CUVFHT9t910wCb8+0DJs1YsEjDBxfcujkCASveUU4pzcjY1EESVVF0MniPwubhYSTFFZKFx2U456X3uWRSLBV140hZ70LZ41ExlYqMLBYv1bYdRY53VUFu3QYnvoP1lFl8IhVdTr0aY+0QRMoqEC+pWwhsG49FskrksqkgLr5S5pHmNr83ujOOk9zEGyCFTJkSkXvB9seMN4PVf2ViNpwtFmIUmjYrls9cqWY8jAlisPFpNeM8Q==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mykyta Poturai <Mykyta_Poturai@epam.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
        Julien Grall
	<julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>,
        Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 02/19] watchdog: Introduce a separate struct for watchdog
 timers
Thread-Topic: [PATCH 02/19] watchdog: Introduce a separate struct for watchdog
 timers
Thread-Index: AQHY2jgj6wETIb7ouE6AlSobgU5oww==
Date: Fri, 7 Oct 2022 10:32:45 +0000
Message-ID: 
 <062b2502090c72fd229a0b9291e19fceaa339247.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: 6adace4a-1c39-43d1-2238-08daa84f4602
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 0GZMVuP5BWMEene5rsRWJjYfllXk21rzTRdLkfrPGKi+UcuvmIJ8hNg4womMiRUBEKiA5V7cUDx/uYzXTUbEC/fwQilNhq45JUufjciq71gVn3VfbY4g0h909vy70n5H4gQp/e2vWBoC14eeKR/T04sP+FS5WP1T8JxrCZGoAc9r0zuc9EA+zNlcVAxdDtzQ1hBzbSKFN25dpZJ8JuM/VjFi82U+rp6KsMjzh1jfLZtSG2hlEGDbtoxIOiHUFQDRdej6cVIWSH9gSRdbUZBpPEBPOt2/FU3jAjbwvJ2/0vMbi7OOz7AJj2/5XJmt9rC/8THqF/YizZVHZ9uViGPKaszrNf6TUe4NEy1S3VdtF7qWne8ymKHSDTXUdpLx0I6uiQC7tV+SHduSvOcb2sIEAxzA/Hm4X7V0IWdHttECrPwJzGKRr2Lz7k2G61aTO+Uf8ll7eb1Vu2ukWgEEs3199n9xBEsVhoml9iaicQS58ygU8sPGf9aTflQwMwL/j5/mmFPEf4xsAAJY9mSpttO6UYMRxdJD/HpE21hqTGXSBkA+crYipJ5tdrOdNNnrnGdl+qzczSTL/6U9HSuLwYHMCrUbFtVye1d6fHHfWiiOeOts34Cn+BO1x3Ie/5eKhtJRhunjzj9NJv8UVoo3el3lr4Hefp6XaldQErHuuQxwF2fwkcrD3yrNzN0wYtUxU5xLzcnL4fNPOpsMkM6jJ5b7eviZyDQ8aPHkDDFbheA5k11mtFzud/MV4XP6e8SqzGR2Kr4GhSk43t0d0EOxdP4orWxeCY2DW4iy+CGC1Sc6Xd0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(5660300002)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(38070700005)(122000001)(36756003)(171213001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?inOVtGzmDKcsnpiL4Crvm4Kt4AoJTEmnvGxJeerivqraLp7SBMAs7c1fF4?=
 =?iso-8859-1?Q?zPla/kKSEtio3NR9nBI4AXbPWoiPf7qJw04gpGXBe7JreQ2pA5yAx6b6kC?=
 =?iso-8859-1?Q?B3haIfwLt94pke7PiC1WYI7X1q+ScCuQEk5re86SyZB2UhlIF3W3wLKlTV?=
 =?iso-8859-1?Q?K1zYoCn83EVqUDI/YCknpiDIllZ1AjsCPC7EJqDF4mfR9K2EYOsLO4VpET?=
 =?iso-8859-1?Q?oMVVJ5X6BUfHxlK8lazTrryR0s5wjim9w7cfAjJx5KJxdkFmu9Wh31WIhM?=
 =?iso-8859-1?Q?qV4Aqx5ddpHi7f0NP4KjM7VyjnjAPWdFXBINOuFTRAC0ds+FYwmoa92ydM?=
 =?iso-8859-1?Q?PqVPBOSKxCGIj3FLGx8g1IHuneMRs8gbaF6TuSZ4iQBLsxJmrIZUDwp9iA?=
 =?iso-8859-1?Q?3eok16nSr5p3GpSgb6sA5Hb9nvd0tJR21AhOYXASEghF5Qec5aJBR3GuJt?=
 =?iso-8859-1?Q?n7IGAULzoMa4i9Gj9u5pBebIvZbbPkXu+1X9frFgGynsWyMT2G7yQGHT82?=
 =?iso-8859-1?Q?Zrf2d+d3vFgLnXgkQh5AE/dlh97osndYcN93DED9cmtfPw9LGkZrl8/Qna?=
 =?iso-8859-1?Q?OP9wXTbKqbeS+yxsBwtuS6uv+07lvbvNZu5Z1RZq0wulXeDv8/djQCFjNU?=
 =?iso-8859-1?Q?dV+JmVH3jIUHCwsKYI51TsNv2kEChCGaR4+aG310dSnibTSR4ODQrX0Vdz?=
 =?iso-8859-1?Q?YWrFj8Zsiy3iDUbCYm+pUcZ0MeM6HKl1xOeBtDehCYfLpqFwQnV6o1OeBz?=
 =?iso-8859-1?Q?V16vMK8/T8cxYK3FznCD0wKD/RfDBCQq3Q98O7cXXQW3wsVgadXoPgcDYh?=
 =?iso-8859-1?Q?py4bZJ3gKVfFUCakKztK2PxnaRibyZxySexT0wz3eVNh/RkmisdnydDXP+?=
 =?iso-8859-1?Q?OWu6x1FQXMJfE9oua2WiSPbLrdC/P+YbMiujOeSh0rI8Lp0fmgA6RLKcGp?=
 =?iso-8859-1?Q?j3c6/3R4WCsUTWsEQDIS5E8nt/3RnWVcGPcM6wSmxM9o+vu4CRiTPe2ADB?=
 =?iso-8859-1?Q?DCNUJrms9yRAIhxzJv+Qa1RvsHZlcR6xkvUQ4MmErpcRqCaPOfbHYiuyYa?=
 =?iso-8859-1?Q?IwlvKI5l/HAL614miVKXjuUIdApQ1vRR57TlG3jUejiS4MizSCXRnQfSB+?=
 =?iso-8859-1?Q?M+znCCorTfrJWr21o2j+7OER97n3BWUfmX+iYyJhg4cDJnmTui58j3qVd/?=
 =?iso-8859-1?Q?le63x2CjBuVus3IrHzkUhDtr+9kD2A/4L3oJ9aodu98OKunJniuS1ZhPJe?=
 =?iso-8859-1?Q?3vs+on0uL8g+dijlGZcfe4I6oHbLoH8MYFAV7IxOeZvS37Q7R8m5jOs3BE?=
 =?iso-8859-1?Q?+Ew5u+Q9VVPDfFzBJw25Mwd/uvrTO81oyP8EvgkOCoMJn4Ap2iY/fJi581?=
 =?iso-8859-1?Q?D9Yuzmc9Jf6ZTB1wLtg5IIjRTAQ7GN2FCgnr9tBW58/YeiFO7c+vCaaHkv?=
 =?iso-8859-1?Q?Y+tzF3uSJvbCsh+OoT+VXR8Q618OMkIJ663d5nV3CiKRLqvU3dcCa65Hj9?=
 =?iso-8859-1?Q?apXrnK6dgdxk5oMXJ1bFZBGRQUXGmdqJkWEOgt53sHpAJoVhxNut3RS1nx?=
 =?iso-8859-1?Q?8vmLS2WbJHcjD+uMO++h7B2zEwwEbGmHBEqlJeSZrCAbrgJ6DyXc9bZqah?=
 =?iso-8859-1?Q?W39nqoDBqCLSeI5J32l2gkn5SOdAllK4XiIByZwxuYD1K1mOrQe1wjDA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6adace4a-1c39-43d1-2238-08daa84f4602
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:45.4899
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6Swq2zPYJAJj+Z6Cq1Cu01JDMpMOcVekxgyV3oWehdsugoTkiU7Bye7wVWj4NXry77zn2KYZcvIpThc0IrP9OA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-ORIG-GUID: I5kCyhS7vqt4pmSpzpBleZz5K_T-YPLX
X-Proofpoint-GUID: I5kCyhS7vqt4pmSpzpBleZz5K_T-YPLX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 lowpriorityscore=0 mlxscore=0 impostorscore=0 phishscore=0 malwarescore=0
 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1011
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

This change is needed to properly implement the suspend/resume actions
for the watchdog timers. To be able to restart watchdog timer after
suspend we need to remember their frequency somewhere. To not bloat the
struct timer a new struct watchdog_timer is introduced, containing the
original timer and the last set timeout.

Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/common/keyhandler.c    |  2 +-
 xen/common/sched/core.c    | 11 ++++++-----
 xen/include/xen/sched.h    |  3 ++-
 xen/include/xen/watchdog.h |  6 ++++++
 4 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index 8b9f378371..e9bd48fa5b 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -289,7 +289,7 @@ static void dump_domains(unsigned char key)
         for ( i =3D 0 ; i < NR_DOMAIN_WATCHDOG_TIMERS; i++ )
             if ( test_bit(i, &d->watchdog_inuse_map) )
                 printk("    watchdog %d expires in %d seconds\n",
-                       i, (u32)((d->watchdog_timer[i].expires - NOW()) >> =
30));
+                       i, (u32)((d->watchdog_timer[i].timer.expires - NOW(=
)) >> 30));
=20
         arch_dump_domain_info(d);
=20
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 4e1ea62c44..0ecb41cfe1 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1567,7 +1567,8 @@ static long domain_watchdog(struct domain *d, uint32_=
t id, uint32_t timeout)
         {
             if ( test_and_set_bit(id, &d->watchdog_inuse_map) )
                 continue;
-            set_timer(&d->watchdog_timer[id], NOW() + SECONDS(timeout));
+            d->watchdog_timer[id].timeout =3D timeout;
+            set_timer(&d->watchdog_timer[id].timer, NOW() + SECONDS(timeou=
t));
             break;
         }
         spin_unlock(&d->watchdog_lock);
@@ -1583,12 +1584,12 @@ static long domain_watchdog(struct domain *d, uint3=
2_t id, uint32_t timeout)
=20
     if ( timeout =3D=3D 0 )
     {
-        stop_timer(&d->watchdog_timer[id]);
+        stop_timer(&d->watchdog_timer[id].timer);
         clear_bit(id, &d->watchdog_inuse_map);
     }
     else
     {
-        set_timer(&d->watchdog_timer[id], NOW() + SECONDS(timeout));
+        set_timer(&d->watchdog_timer[id].timer, NOW() + SECONDS(timeout));
     }
=20
     spin_unlock(&d->watchdog_lock);
@@ -1604,7 +1605,7 @@ void watchdog_domain_init(struct domain *d)
     d->watchdog_inuse_map =3D 0;
=20
     for ( i =3D 0; i < NR_DOMAIN_WATCHDOG_TIMERS; i++ )
-        init_timer(&d->watchdog_timer[i], domain_watchdog_timeout, d, 0);
+        init_timer(&d->watchdog_timer[i].timer, domain_watchdog_timeout, d=
, 0);
 }
=20
 void watchdog_domain_destroy(struct domain *d)
@@ -1612,7 +1613,7 @@ void watchdog_domain_destroy(struct domain *d)
     unsigned int i;
=20
     for ( i =3D 0; i < NR_DOMAIN_WATCHDOG_TIMERS; i++ )
-        kill_timer(&d->watchdog_timer[i]);
+        kill_timer(&d->watchdog_timer[i].timer);
 }
=20
 /*
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index b2f6d1af28..7a4aef4c17 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -24,6 +24,7 @@
 #include <asm/atomic.h>
 #include <xen/vpci.h>
 #include <xen/wait.h>
+#include <xen/watchdog.h>
 #include <public/xen.h>
 #include <public/domctl.h>
 #include <public/sysctl.h>
@@ -517,7 +518,7 @@ struct domain
 #define NR_DOMAIN_WATCHDOG_TIMERS 2
     spinlock_t watchdog_lock;
     uint32_t watchdog_inuse_map;
-    struct timer watchdog_timer[NR_DOMAIN_WATCHDOG_TIMERS];
+    struct watchdog_timer watchdog_timer[NR_DOMAIN_WATCHDOG_TIMERS];
=20
     struct rcu_head rcu;
=20
diff --git a/xen/include/xen/watchdog.h b/xen/include/xen/watchdog.h
index 86fde0884a..3398dcba37 100644
--- a/xen/include/xen/watchdog.h
+++ b/xen/include/xen/watchdog.h
@@ -8,6 +8,12 @@
 #define __XEN_WATCHDOG_H__
=20
 #include <xen/types.h>
+#include <xen/timer.h>
+
+struct watchdog_timer {
+    struct timer timer;
+    uint32_t timeout;
+};
=20
 #ifdef CONFIG_WATCHDOG
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417680.662380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf6-0004nz-JB; Fri, 07 Oct 2022 10:33:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417680.662380; Fri, 07 Oct 2022 10:33:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf6-0004ku-CB; Fri, 07 Oct 2022 10:33:00 +0000
Received: by outflank-mailman (input) for mailman id 417680;
 Fri, 07 Oct 2022 10:32:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf4-0004PE-IC
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:32:58 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 676f392e-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:32:56 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978P171005817;
 Fri, 7 Oct 2022 10:32:51 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjk3-3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:51 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:46 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 676f392e-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SsOAfmerj3Y9pJgGOdn59yTsXDQowD0l0B1Ita4V5ZEH05KODP4jIiJFMStDcUgWpNvRwCbCTEjNcR1t1rb2U3eMwQPnwM80G2TBfQEAK858dgidRPBW0S9+J3XouDAbSB3ZscJm5gBdQ8b+VvYLcRAaGXdVL3lwauqgYEKeF1qkl68/LEolLOLA1eeL+s3Xa8hGgQCiZy03k2jnuvFTFYEYThWNBWMw0vjMDQ32zPD9A7sxkLKJ3KIhJfnC9uw4Sd6d2mACKbpBvj3Ztbq1EC1ox1Zr2KgPdTXssP9+bgsSCLMPIfg+2/9DXuKWn8sMC/p7M3bDbs3ikhG/lchjZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6h6SHmTRfcgXQ7Yu2AK+J4nbsyl3YwHrisUBV1UF7MI=;
 b=EJ6Au0w0nhzf/SCyDC305K6Nr4eopsch3XkTN/d6Ol5l9f39LnvkWy7JGH4c7eQd2mEtAXs54nOXdOXyVC0YvdSGvgeRgsA2uSbsr41o4pCBLCWoxLJQmf68ltCLR50/1Z15k6fYHoExqT8zUYT5lNamfDC3IAbmJTwShjqCJqnLUEsE57qM4qTXca+rLu2CAXWBDpJ+dW6JSGLdhbvwfj8ultdaPv3MSyXk0u6FAQ/6GXMPO8WQz9oEAtHXgwPB9iJ9x77qoQjQ6/I2Ig1zFgiH8Q1FIQ5BpPQKQrIfhK5bnU5l36XRsLlCl7ce9E9rWlMOIiC4AQD2r7kfDLf9zA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6h6SHmTRfcgXQ7Yu2AK+J4nbsyl3YwHrisUBV1UF7MI=;
 b=i8n68Dbm0ESA5OKzQpsBU2DrvBd+XQKb9gf1SxBxOZdPD+hXFW7jQR91/yAd7lajMEOeTJab5mY9gnaQbV0v3hLMrCsQxWCzAk58qn1smdc7y/9Ng6I+sr+m5l7wwWby9IbtIhj8PVd/VSAxy8Ai0lrxM60pBcVTOuuFsNCMI3bliST93s63WgxzV9HXTZwUKd/ddUZp1+f5jbUWrKM4+QP3bYEQIX37+IZrjYQUsYgksrrgA0Ig4EoSF01Aw/J/BYYPTs3u4jt672f89foZYX67VYhxgwi3LfP+y+lVf7XrnFIzeuzjSzp2rNOnRGAONjBL2/Da2HlsXYJ+22Q7gA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
        Julien Grall
	<julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 05/19] xen/x86: Move freeze/thaw_domains into common files
Thread-Topic: [PATCH 05/19] xen/x86: Move freeze/thaw_domains into common
 files
Thread-Index: AQHY2jgjZkKcYQ550kmOPqD7DDutRA==
Date: Fri, 7 Oct 2022 10:32:46 +0000
Message-ID: 
 <931418d761e47eee7847e6bd559e02597cbab1b6.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: ee9e3a02-776b-4781-b3a1-08daa84f46b9
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 7I6ddO/gjyRoDQtiB9YQdE3yZkiIq9cJM1snMsvyPyUNnLj5y5wZQvOBSOSz0Mhox2gm7M51lZOzCT7b72YU5oDR6nQnco6ypdLlHkjrgmgmEV3++WKVqvZvFuBxs0r+HgvouBWlj6/HB1EuUnCCAKSAYh90htDtdPvIjFX0TZDKnf+Gqvy4nZ2ZLYpQFe5wrH33uOldmMMbk2+bajoEz9+1e5LptvEqyWwG3x6cGymDnDvFT/7Qz4wtwSycKLLWqScA73vff7IZXd/EHklb5oB92M1kW+h1N3dJoBGJbkDjD9zHBw8j8bf3SHHvYO3ixYpSyoNgvgRSP8DmT4PzR+9PI9cYjd4SFD/OhLvNplJep6WLee80R0sEgKKNVPRXP19S8ywcbeAZeoUmnz4EGce4rduMpoDJqAWMDVmxoT1zMw1aYBNDrf1tSImuQYDSBXb6O08/OAf38rwZOyKzhRqRXO+zif2688LcXc1E/NpfYq9Phqwg1w3q98h8p6elp/M7CWoDSA1T1H4KwzhQstY+S1ENwz6WKpnEzaH5Rc4Q+UoXRpdw4cGEP4jfFYsDi3DEvh7gwuynaANyFefQ5s7KK3IcejrzqCeRBoI+xBxcdya6aTlGdGDSFfEFDB36bUZiPYH3P+a4OBQ7zOpEWkIoVa4xz8zuls5U+ifqXDL/5w3oy4IP+OhblVb3MJzLKzHHdtJmpGFzqdEL6YyTddzoNd/7epGVcsa57NlvMFeruERZB07PRezE16KvbgO1cHgBosj/mUyugRB6DZUWvA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(5660300002)(7416002)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(38070700005)(122000001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?fMIiNPj5PFCgdwZH/6GURDeFZJWarGfhBM5hJVRX6g4Sa8e88Pmfbx3rvs?=
 =?iso-8859-1?Q?jYs7sDCl0CDI6j27nDvCUTwHkdTwJRbRc/edk3g0Oazjq+M90d1OR1f1Sk?=
 =?iso-8859-1?Q?GElQM3XAt5P6XAbcoNtzqgPfLGdmGlElxN5mt8lzxxtZoaobR3ZNwKxCCY?=
 =?iso-8859-1?Q?8U77YD2sbJYBRKwpdpn+nwWjf+xn+EIJWQWmldKkSSY9snS6shw9uRUFzU?=
 =?iso-8859-1?Q?aSVapdhR40WOmSbTkxTLHG8flensjZm1I83vruVx6qGaXPevYFXpkAHSCI?=
 =?iso-8859-1?Q?tmHS1EHE2uyjJku1Te/UP5pVqDHUMFt1mkL+L64EJUUthG/535SmrYnq84?=
 =?iso-8859-1?Q?m1nMCJFIUrBUmOyLLL4JONP75QThniVX4Ll1VHHT0S1oPkD3pabMHEdj0D?=
 =?iso-8859-1?Q?PyYzhDijJVa8UDuO/Ff2cPNYqLEzQBpALJKS9qINls7bR4fP09r5u4FdU8?=
 =?iso-8859-1?Q?RUNAVLoxY03mbqubcr+6B4pgC6qn96v1qjdMg9ZzFXMJTjS737ZUkJtU7o?=
 =?iso-8859-1?Q?zRjG9Vb4sYCOndLCPpCk2Bn5lOL5xQjIgCr3GUnK0eaBDnpv2DiMuj4H6A?=
 =?iso-8859-1?Q?2rbGj72TpmxZ7CI1i+ieuPph7y8DNuyFyCmN0Z4fz/7AtTuDEJDSG8sGwk?=
 =?iso-8859-1?Q?YPrTJLTFNFj6dsd9JyTo9z0ziXsiRRjAPCt7pJU1K3kKMd7AV7L0TKF3aH?=
 =?iso-8859-1?Q?oMpB+FF55XEJZaeVc++5YfvUgo4rsXfxjWuKKpYfJx6ZDcNhAYVxW0XTDY?=
 =?iso-8859-1?Q?h7Fb4tcSXmcOP6sWwxB0/QdyxBUAQ99s6qKTwnMH42GQi5LvkLjbhDjEsl?=
 =?iso-8859-1?Q?8BnG5Hbxx8d+1irJ89CyOF0C8brhdTDnjQxwO4PalfLCKF+QJbAQOKF3Mg?=
 =?iso-8859-1?Q?FPz5wnd9KtnCOCz1dDzYtdLdWEcFAFT+x6wlsGEKP56w4xYr6XLKITapnQ?=
 =?iso-8859-1?Q?Y+dw2BbEXuDnA+13Ctumi+wAQUc1Nj68sZJDYj0c6OM2P/myarsm/Bs1Im?=
 =?iso-8859-1?Q?dVktG9g1AgQYY4HsEHUFqbc05sPGi/JpPUsQ55IkL+cH+u2OHGzROu1Lj5?=
 =?iso-8859-1?Q?c795OJcz8hAJxhfzXMBykis3BBe+/vEwpTsOpzTiuOWWVeWkf2fDDb79Ll?=
 =?iso-8859-1?Q?ma/DJT6y9uEltNhEBaPo9PxDrO2pAfg1rOOvTrxdrPnRN1CiiIusNEFX/7?=
 =?iso-8859-1?Q?LDUjl8SbsNd7DHvTqXTLWWoB/tsvGFJKFEN0WCWc6egKP9mQFVVRpa7tK5?=
 =?iso-8859-1?Q?7v0q6mkB+Z+gCIIUIniW70lUzWaIk70sRqDO/lqdmQ1035dFlezyjUmp18?=
 =?iso-8859-1?Q?FCcY2Qv/wvlEcFwFtpt+xuT7NQnwqLj7fFWtLJgYHEHFYzkHmD+PVeCR1G?=
 =?iso-8859-1?Q?FxYCrWLY71V05jm1tvsy9uHcFc97cb6OG1WTFOBU6BRnv8Ha4vw5DUfHPg?=
 =?iso-8859-1?Q?l9gAfLlJMaOAYl3bv9wIYWWCPVNQlP0Abo67pRxfzQOcuHZ5xYyeNahdZF?=
 =?iso-8859-1?Q?UZV6FgASUI0F7SHkXGCBg8HNclNVJxh6Ykyz3VyESn/Gl8O87VOwzE5630?=
 =?iso-8859-1?Q?HxJObiFFX2vkIK56TCK3Rm+E3VUWGey7xxIWeMHfLRLgrNhbww6HNfgh6k?=
 =?iso-8859-1?Q?25BvGoo80QER0CWSxDCuisK3A6UlyGMWQVJXCX+hUfadsTaYWHPoFDoQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee9e3a02-776b-4781-b3a1-08daa84f46b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:46.4117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2lWP/oei1ghoYb36UEvrsNMdYzHRlzgt68FViXGwOjaYu6h2+y0L0Pmjd8yqI17Wyc2aoN3CZoHfpE3pKLoNhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-GUID: 1X5iEoW9QqqBZwh0CemHWffGAEpZwUOW
X-Proofpoint-ORIG-GUID: 1X5iEoW9QqqBZwh0CemHWffGAEpZwUOW
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=898 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

These functions will be reused by suspend/resume support for ARM.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/common/domain.c     | 29 +++++++++++++++++++++++++++++
 xen/include/xen/sched.h |  3 +++
 2 files changed, 32 insertions(+)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 56d47dd664..5e5894c468 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1884,6 +1884,35 @@ int continue_hypercall_on_cpu(
     return 0;
 }
=20
+
+void freeze_domains(void)
+{
+    struct domain *d;
+
+    rcu_read_lock(&domlist_read_lock);
+    /*
+     * Note that we iterate in order of domain-id. Hence we will pause dom=
0
+     * first which is required for correctness (as only dom0 can add domai=
ns to
+     * the domain list). Otherwise we could miss concurrently-created doma=
ins.
+     */
+    for_each_domain ( d )
+        domain_pause(d);
+    rcu_read_unlock(&domlist_read_lock);
+}
+
+void thaw_domains(void)
+{
+    struct domain *d;
+
+    rcu_read_lock(&domlist_read_lock);
+    for_each_domain ( d )
+    {
+        restore_vcpu_affinity(d);
+        domain_unpause(d);
+    }
+    rcu_read_unlock(&domlist_read_lock);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 00a939aa01..c8ddfdd51c 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -978,6 +978,9 @@ static inline struct vcpu *domain_vcpu(const struct dom=
ain *d,
     return vcpu_id >=3D d->max_vcpus ? NULL : d->vcpu[idx];
 }
=20
+void freeze_domains(void);
+void thaw_domains(void);
+
 void cpu_init(void);
=20
 /*
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417678.662369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf5-0004ew-Sn; Fri, 07 Oct 2022 10:32:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417678.662369; Fri, 07 Oct 2022 10:32:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf5-0004eo-Q5; Fri, 07 Oct 2022 10:32:59 +0000
Received: by outflank-mailman (input) for mailman id 417678;
 Fri, 07 Oct 2022 10:32:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf3-0004P4-R7
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:32:58 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 677e34ca-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:32:56 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978P170005817;
 Fri, 7 Oct 2022 10:32:51 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjk3-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:50 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:46 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 677e34ca-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GTNT+Ai2rm8uXBBVwwRXaYKdygnQ/iTmN1JZHN3y5N5WXxZUxSItPewHCZziIIy6bAH4J1vuKhnc0JAQGlPkC0qG3pNJW6OMVhR4NsO+xdqqcF/VHWKmZbfY4dwATPB0frfEZeulmYPEZZ2KB57ftYJuXMiX1+siTvkbAXaYYqlt47/O8CiaFHVWS1g/6s5hmdCtfLkt62ywds4GtCuG3vlMauaexsTNANdc4xrc9JdangEVBb1whn4EYG0WwXZ8jlpMWliy771F/zTkTBMIdguU9JQyrURtxdyc+vF8ZWqm4gXBmZPwqhGyeiT4+MN3v1RHu8Z97QJr03BNP/zKuQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vI8WYCk3EkX7EbqmfQgeu3vc77XT/c/fe+8/1HjADBA=;
 b=YtKBkwRhMlrnY+BK4X3vUMb3jZiNVtp0xKucJ9YDIjZBaHNNJJfXbSIlHX0KqwcqIsfM6USEqyucZpsEmx2mC4XykLrXq58ecj2sF5EPyTt/TQCCyUxBoeVFHUox9EDM/VpUFmBgE2kLGQdYGoK3VhQJUHjdNEfHOCDY1VFAvtyx83r7A87BEt26IKHgXu1q0VGWTtsRiEX7ya1X8n+qywbxS/NKlitTr2mEt5N+H+vse6fm4ieSZst9o6PXSWmHXm+62FaCYkLGMcI8zzsowGYXXXdcuRKAO9KlNC3rV1onWKeFxHcOR4l3Q69GJzAxyZAExMEa3JNMuI43JqbntA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vI8WYCk3EkX7EbqmfQgeu3vc77XT/c/fe+8/1HjADBA=;
 b=e65NZQC43Rgu0GY6zQ7z8WqqV7CSuVaaKIoeUcD+PScn4R9P/UOmU6mTMsyKmFD0hOkl9fZUmNl0005oRWawLdQZjfNnzx67Wy8xDiu0qZMLxw8LximuJYnj2dsoD5M6VOaRjKK8CKVQGNgJ0NhutPAZ7EUDxT6mcu8NAQQgUMOphvLI798QAQUOdv1Rr45XImMEfm50NElHbcv3p7ChpMmZtl1D72ZLVKveig3NpMF3pxJOJUv77A2ONCCW+AZLn5Fe0N94FC2G2B7k4rzLIlSv0XH164IJE1GCvIp8wcbor0s5l5dsDPURygmk+SPWv5rCpu1+FPAssRb2Xk5e7Q==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>,
        Wei Liu <wl@xen.org>, Dario Faggioli
	<dfaggioli@suse.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta
 Poturai <Mykyta_Poturai@epam.com>
Subject: [PATCH 03/19] xen/arm: While a domain is suspended put its watchdogs
 on pause
Thread-Topic: [PATCH 03/19] xen/arm: While a domain is suspended put its
 watchdogs on pause
Thread-Index: AQHY2jgj3tJ62NzvY0CshbpyuWlDtw==
Date: Fri, 7 Oct 2022 10:32:45 +0000
Message-ID: 
 <fffb1b6e07974cfa81fbcf8793c9d540a7fed00e.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: 6fac4072-27f9-485b-450d-08daa84f4647
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 PVdWxfHoqtcVrQBX/GYOLzIhnjjQ9yiGIzkn76KThW/FjZkaF2GVH7BQcRNIj76JyAnnbSMGMIFcNW3c20a9TVdgHVvH86P5gnp1YNQ6GR5QJUYxbc8y1LKIi6207ENGGCd55TgXe7WJYRZ45bBQnUHYzfnZOYDcmak88Z5E5+387Y+tbLR0B+AfTXgE9dG4pfaJXqXIDNNv9WTqJsC+f+kJdQyMeSckWKI91WUs0ZXV/U4xoqvkKWN9Fqh8QVGeslS245Sj/0ln2PPcW7aBXh9WnYcJC0lJ9k7//ZXRKzHFRnRzUZu9w83A/zoXI+gsjcrdi8kxWTcPHcmOY6D3kGNXhtVo3OSOFA2PqYjHROJL/bKTpHSU3Rfd142pr75EOLLkjRpgOhUzWjLoG2Z+c6rQPxOurfmrd5m40FHun+m12Rov8e5/QTNZcy+4wc02WREgeQo+ZccjmM6/EI2lFdqKWW8EIFcGkS6Ls3+9stSGmlYQxYZexbwMtgnmucgf7/RTwm+Hoz8p3MyX/9fmAR0yoTv2B9LRUEKDRVTqinFt1/oSE2SEc6l/fNGf67WH0YrNzqyGEHriHOhEO/yDFQR8p5OsNTRSuV8jmz+wX53fXaY8nK1P9LT9uz7rRf5bs2LxuZCzFxxhvSjMLaT5zSf3uv2kLqAbvHJqY1EmT1hJSXM4rn153ZOFbVQY0exd1BX8J3EaVcGQ6Jh/gijBm2O4PwU/6dIFexzYdaqiQIUAt1ea/MX5Jdzq6UXYdvQ4raK+IScDmyL5uqQ0LLdFlQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(15650500001)(5660300002)(7416002)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(107886003)(38070700005)(122000001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?P08bzKCFIiaSQRclxruTZnoyEvp5U88jb5wfaUY0yeG+Ll4oF4rOtIV8ea?=
 =?iso-8859-1?Q?jCjUQvwd6FKny7pPzKF+yRR7uEWL0JufLfdwfCxJA3EqnNVkqpMb1uS7QZ?=
 =?iso-8859-1?Q?G1zfuCMY1HchDWK0+8GmaRnOm6PFrPG066nAnhOFHxEPUN4dB5Zd+R8Bkg?=
 =?iso-8859-1?Q?cWvms5EcomUUPaZ9i2ZIVokLwzpEv84K83CnvZdo2Ng5e86jzMXG806f53?=
 =?iso-8859-1?Q?e2Wjgg8dR3FiQQu56sxnn5CxO52hy2vFDWiK6tYXfkoWYIyhO3KL1JUeyF?=
 =?iso-8859-1?Q?7n9SSezt7wDpU3n+F7kmDNVjy+b201+BAk6l9ZEQAmfTvOEkGq8RU9lVBl?=
 =?iso-8859-1?Q?3VkFuPPCzQ5AT+lUUuq4i8cmHTEy1Y+LVn9fCTzXsfwb3KpZC1LSPAXTcs?=
 =?iso-8859-1?Q?QrD2YYkBsfS3Y92fiVrz9ut2NkrZIV9CIjvEe3aRf84gd9Hw5wJPGrcQY8?=
 =?iso-8859-1?Q?36uMyFb+tSVvwyaxheLMUFatVA1TorLqlCDx7YfwP4LYhnKv6ulaYVBo5F?=
 =?iso-8859-1?Q?Wd7C5T5KMJYVGseTUJeTvslVpgmE4QnUvQWgOfAMsvX4wK0EUU0/E4GRvE?=
 =?iso-8859-1?Q?AGyXq51Xa3HrAM2OqZob8IF1MiKCipWIohckhxE2+RwrS54tf9yYja08Tt?=
 =?iso-8859-1?Q?KukVL01k3Ehyexc9e7kof0iuhmfFZrilh3mgU3N4+ErpAtuRexWdhXRIp1?=
 =?iso-8859-1?Q?8mNc99Ja1xUNZ9cJ+Xmj+Nq8lUQaip7/SW7hv4dktaLsMP/WnUAfml8/LJ?=
 =?iso-8859-1?Q?etU7GeHGTcuc8BHoF6PvUFMehfEGdN7fLGit65mM2H9ESZ193zblb/eAUy?=
 =?iso-8859-1?Q?7nJykdKHfEmMy+QxGmGjvs4Tl38/PCjKusoLQS6PtUwQ+s4sukH5o5MwZU?=
 =?iso-8859-1?Q?fxB68JXjlacfNAmECY3DZ9AeBpLfCGol698sk701G0S8DkrToNAbdKu9Zg?=
 =?iso-8859-1?Q?XMf/fOVjFvBLRGTkoxViocpURKr3yzi3Q0Fgc3A3eE7Z6UToMHBjlhO1Es?=
 =?iso-8859-1?Q?/yzlDdLcCmZJiwIYfQCx25umvnuwI2CE5P/qnCbTQ6izSDl3QJrFxv8wWA?=
 =?iso-8859-1?Q?B76o3JXbxrmfIx/4fOOOqafvK6doJF0iprTdhpEr3x06WMIvyAgyjmVJAQ?=
 =?iso-8859-1?Q?934A5jj14Z9TuehzuqcWp4ScMfi3r/LrpxOYqpG/eZyiisMuEt1EGI6QRD?=
 =?iso-8859-1?Q?Qe9sRgFOi/pwjas1+xAcrNIVvJx2IKvxI3pIy0/DhhOKOa5GPsPgkNxPaW?=
 =?iso-8859-1?Q?T3Q9fE92RAjBgQ4wlywTJPzWj6sXtlGzxPBhiDhB0VYOokfhNIl9NVK53z?=
 =?iso-8859-1?Q?Z9qDmEL2qdwgRJI0zvoDaijvuvGSSy5iJ+MPxxLNtAUAq3T3oBHzgvvUcQ?=
 =?iso-8859-1?Q?khCYOtoNVD30qFveQXCeNFnii8OFGPRL+Nuv5GyfDOHWg0TSYM7AGvf8HC?=
 =?iso-8859-1?Q?lRFgv6RuPTfhJDNW1+AWM/G+WkU0KnvwTOrrOz7KT7eMPMCqROjHZKW5aA?=
 =?iso-8859-1?Q?2QRWhbkPMexiHehd3v26FxZTcp7xDh+RUH0BdGjWEDl9jL92BxNodooR4/?=
 =?iso-8859-1?Q?nXO11vqPQWGbk4SudBAVt4I6vzG1YYYkXPNUFYJzfXx+I8vvHkYCekzab9?=
 =?iso-8859-1?Q?D/J5KKQ+aXicAgPoFjVLW/WAejSx2mV6W7FtMZKsxRLsqG251ooxIdeg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fac4072-27f9-485b-450d-08daa84f4647
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:45.8024
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gKv07nvPWAUChbuKX5EaogbLCenr8BaHj3Q5dBJMlUwBgnULZKL7qvYh0Ljx1eVBxjdg1fwn2j4mulXhVwCONA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-GUID: bp1UNnI6Y8_w1v_bQZo29CAGgcls6R9B
X-Proofpoint-ORIG-GUID: bp1UNnI6Y8_w1v_bQZo29CAGgcls6R9B
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=466 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

While a domain is suspended its watchdogs must be paused. Otherwise,
if the domain stays in the suspend state for a longer period of time
compared to the watchdog period, the domain would be shutdown on resume.
Proper solution to this problem is to stop (suspend) the watchdog timers
after the domain suspends and to restart (resume) the watchdog timers
before the domain resumes. The suspend/resume of watchdog timers is done
in Xen and is invisible to the guests.
Just before the domain starts resuming the watchdog timers are programmed
with a new expire value. The new expire value is set according to the
last offset provided by the last hypercall before suspend was triggered,
effectively restarting the timer.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/arch/arm/suspend.c  |  4 ++++
 xen/common/sched/core.c | 36 ++++++++++++++++++++++++++++++++++++
 xen/include/xen/sched.h |  7 +++++++
 3 files changed, 47 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 987ba6ac11..d19545744f 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -128,6 +128,7 @@ void vcpu_resume(struct vcpu *v)
=20
     /* Initialize VCPU registers */
     arch_set_info_guest(v, &ctxt);
+    watchdog_domain_resume(v->domain);
     clear_bit(_VPF_suspended, &v->pause_flags);
 }
=20
@@ -162,6 +163,9 @@ int32_t domain_suspend(register_t epoint, register_t ci=
d)
      */
     vcpu_suspend(epoint, cid);
=20
+    /* Disable watchdogs of this domain */
+    watchdog_domain_suspend(d);
+
     /*
      * The calling domain is suspended by blocking its last running VCPU. =
If an
      * event is pending the domain will resume right away (VCPU will not b=
lock,
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 0ecb41cfe1..ebed0ec49e 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1616,6 +1616,42 @@ void watchdog_domain_destroy(struct domain *d)
         kill_timer(&d->watchdog_timer[i].timer);
 }
=20
+void watchdog_domain_suspend(struct domain *d)
+{
+    unsigned int i;
+
+    spin_lock(&d->watchdog_lock);
+
+    for ( i =3D 0; i < NR_DOMAIN_WATCHDOG_TIMERS; i++ )
+    {
+        if ( test_bit(i, &d->watchdog_inuse_map) )
+        {
+            stop_timer(&d->watchdog_timer[i].timer);
+        }
+    }
+
+    spin_unlock(&d->watchdog_lock);
+}
+
+void watchdog_domain_resume(struct domain *d)
+{
+    unsigned int i;
+
+    spin_lock(&d->watchdog_lock);
+
+    for ( i =3D 0; i < NR_DOMAIN_WATCHDOG_TIMERS; i++ )
+    {
+        if ( test_bit(i, &d->watchdog_inuse_map) )
+        {
+            set_timer(&d->watchdog_timer[i].timer,
+                      NOW() + SECONDS(d->watchdog_timer[i].timeout));
+        }
+    }
+
+    spin_unlock(&d->watchdog_lock);
+}
+
+
 /*
  * Pin a vcpu temporarily to a specific CPU (or restore old pinning state =
if
  * cpu is NR_CPUS).
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 7a4aef4c17..00a939aa01 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1025,6 +1025,13 @@ void scheduler_disable(void);
 void watchdog_domain_init(struct domain *d);
 void watchdog_domain_destroy(struct domain *d);
=20
+/*
+ * Suspend/resume watchdogs of domain (while the domain is suspended its
+ * watchdogs should be on pause)
+ */
+void watchdog_domain_suspend(struct domain *d);
+void watchdog_domain_resume(struct domain *d);
+
 /*
  * Use this check when the following are both true:
  *  - Using this feature or interface requires full access to the hardware
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417681.662388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf7-00052Y-84; Fri, 07 Oct 2022 10:33:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417681.662388; Fri, 07 Oct 2022 10:33:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf7-00050I-1e; Fri, 07 Oct 2022 10:33:01 +0000
Received: by outflank-mailman (input) for mailman id 417681;
 Fri, 07 Oct 2022 10:32:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf5-0004PE-AW
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:32:59 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6821c197-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:32:57 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978PgUg009630;
 Fri, 7 Oct 2022 10:32:53 GMT
Received: from eur03-am7-obe.outbound.protection.outlook.com
 (mail-am7eur03lp2237.outbound.protection.outlook.com [104.47.51.237])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb3gbm-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:53 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DU0PR03MB8622.eurprd03.prod.outlook.com (2603:10a6:10:3e9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Fri, 7 Oct
 2022 10:32:49 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6821c197-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gbSvElxJ17FifaxdNXwj8TabeRhJLRm0CSMIbDlcyALJpgGBEMiZY2JES/RlXBLVd131VwIwFvXkP4lze0TQkOKLIpAvZauxg095VL1oVtTKPi45NAb4s1lMR2TzjYIg/7t6XWsJgbb1tZfGAB7/2Yt7HhaYymr3975XB/jpjXxslak0xdL3PEjvDVSTlaBnryKY2eZpTCW7nftZ/HNISpnN00j5fMLm97SH+x/0byCXR8sIK8/BMRecX8dtqy8JD3MuFNq7B11/nBAQzQdt1kQEgcb7WmvM1CkK75sEe296FQtCrHE8FuRWemwwrzHVkzFxLwkf6nHiDtutDRkh+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K6yJ0yDZf36EG3Um81KKQS4asysiZbHKT9YQCuxEkmg=;
 b=WNi/ztOMpM9SvReWp6Alo0zm/7bqijc6dhhpVxL+8dzqXtO4PSMLyKrcRiqIzCrI9gSFjODmEZD1mXhiCgYh9cFYqw9loKH/JzmFWmKIYsU6aEgdkNOsi4l+0H9MqxtMpEOMTZNMnWwqzVFjjPXzCn0dBwC8jPshwWbuakKX/PM0IpkVZN44mhFFOEGiAB92Z3grJN3HS3fgOOC4BR2V+uuIdbJ+CafDhUFXKCeN7Y5QsbmCLuVlk2yU0pX9i3XIulDh5diV8O8bEbRPThPt8z0EU5Rriyi7QsQGHdb3YzS6+9cDtufsx8XY8ZrK7N/ww+9AuDLXUrYqrYyipJ9obQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K6yJ0yDZf36EG3Um81KKQS4asysiZbHKT9YQCuxEkmg=;
 b=Q326g/s1s4KCV7K3TUmAl32nOItO0tZ6J0aElMbWZydcRFmMDb9ZUJ50M8/UUquEsZWCBM01QONNsMbGbj/smPH+1foLBsFH+otPIsGNZj3ONyi3FU/qCwnxB8qE/vtX9XqJPvz7K07n/CqTy2eY6L5u7XmGrX28uu9JQCIE+BYR/kOsj5trv/6MjPWskuDl5Mu9ICmOGSnQbnPK7bNBYma1UBuiMda305AsWMFRxoseRTuf8dRN/RxTk0bW7n+9mkUY2l3VW6nqX3q3j9siqxAbzWRkXYGDnPBDEfPDcy81XwCdsJAD5RQhMbc8tyQBZuNwsno6SQgQAroc1uiBdA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 09/19] xen/arm: Implement GIC suspend/resume functions (gicv2
 only)
Thread-Topic: [PATCH 09/19] xen/arm: Implement GIC suspend/resume functions
 (gicv2 only)
Thread-Index: AQHY2jglV560PC3YdU2+hS8j4FDcKA==
Date: Fri, 7 Oct 2022 10:32:48 +0000
Message-ID: 
 <0f1bebffe29c96c5b66c83b62b0c67752114c53a.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DU0PR03MB8622:EE_
x-ms-office365-filtering-correlation-id: c2199bc9-b017-4d33-fd7c-08daa84f482f
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lVOeAWQjbIEC/MIwv30KXusencYFaQzxibUSqY6V7IzErQ9zzHXvAgdvb6/tjOPU3THojvpht+j3Fw/gY/s7XeaVX+24DDp2Ho5cdxx+95/7dJpXE17V1BR3p0phBhQPv5slOBriO7GJ/HYW3LfztXBq45Ooc2+f/j4DmFk1Rctw8IOMPsaHqde7iCKT3e3WjI2ey40uduD6pr8nhJ/KDEsOoCt98kIvyuPjGRUvFN9KA35IQuRbK1T9PowRDg4v4IRzgFE0pVti77e1Kgwe2Ttd387G2KeggohNT54F2WJm9C69w3zz2+ghkzgnCDeRI/4S7S7FEW81OWT7u68xlj/ucPlu2QP4F2XDNklsNFAOs3h0ePe2okzVqjRrZ8uip0z6+1xLu39eGLGSHpGv6eZQAPpastgZBQg4vQSETSGj7kask4nbAs++TsdNxraPWYlbk6OBfIGx1cA7yLZKPVl7ClhRzWAT/Kbt1aP2Dhzx1/xrkUZdML9cRl2i5lpIotvCCefjtOFtwaKsqPgjDulEwrEk4UChsU5L1i9ohQhGi+C0AMUdP/xfTTtKaNVjgZWzPungnYOaPmAq9WDLX+5P579oW7AYcQaOKrc9v59Bc4WWorq4yoZlykxl31rCHPRuMucxZ1hULfLZkH7Fts2Iy2FPbnlCD16JrpNaLyFvJbrfrEZxLVNepdWeCcf+aNUTYePO5erlvRXsIGbDHO0uc8HRDRQWUmcJFjicqJMMb9QMwOfKXTjHLeeQPUShv/VuZzpBED2QzW2tQQWU0Q==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(36756003)(2616005)(6916009)(83380400001)(122000001)(38100700002)(86362001)(54906003)(8936002)(478600001)(8676002)(41300700001)(6486002)(66476007)(71200400001)(26005)(38070700005)(316002)(6506007)(186003)(55236004)(66946007)(76116006)(64756008)(91956017)(4326008)(5660300002)(2906002)(66446008)(66556008)(15650500001)(6512007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?EadNRHZotYtjNTQ622NHTWyGSMUo8vV69UO4GbtinKyagiT8exDRQphxRq?=
 =?iso-8859-1?Q?5jegh9KIiXQqsQUw7JtRhVBC7Q0He/yZVOD/Lr+uNc4KPrCKPK/hHPzYRc?=
 =?iso-8859-1?Q?PXIUIoVChuIRidElL8B5b7JfaMj4NDdzzOkw4t3UE8E/cOUEIUxH/Cp1Wy?=
 =?iso-8859-1?Q?22/GFJ0dTvnG8M2Oac7I6xIaF3O63VDjhpxdJ/74OSTPwRDEySwT8+J9NW?=
 =?iso-8859-1?Q?HV5tFFGsWMF7m7qXmHZdFu6I4vu3E6ISMjsyF8LVldQN8s5uaP7TPF/obD?=
 =?iso-8859-1?Q?ZFesf064aSUojgSyxzPlTWgFy2epMSVStiMqHHKX7c7hI6p59ebs0CTNIJ?=
 =?iso-8859-1?Q?zrs1wty1DpINtaeHWoTaOC9EsItZo+O8YoQ4bszgAEBkwYUaLzHsTFo0yw?=
 =?iso-8859-1?Q?7Agwoz+Lx02t0wq+wI0VbLQI1akcwIs18TKJ8eI5AOuG+vleWJ1Kq8FT8v?=
 =?iso-8859-1?Q?4/2pEyYUs4a4RAIuV1l8nkjz5GuiLYQLs4sLK/A3R45hrxtt+6J2r3jObL?=
 =?iso-8859-1?Q?9FfyczRHjuAWoLCXoYD68xK694kVSmXVRjEbbQVI2Mmb0VMbPTu3SH8VAi?=
 =?iso-8859-1?Q?DED6INpTD6ouzk7k4X7wKGZN3jRDCizbdnljzoMmn1Ywrzc2XT9mJS2tbE?=
 =?iso-8859-1?Q?nRihNwDzOeQVlEK0JYRoWhOnWkhbOX2g6hbw4Ke3XqF/ICfVnbacmEklZ0?=
 =?iso-8859-1?Q?2odDpDxvlDSYpSOCMeiOX//vtunSOvTtLnINVyy85t8yaZlKH9HI1X7odf?=
 =?iso-8859-1?Q?36nHsycDOoJrkMAB6NGjIDBzEgU5atu10LB+zeiUxMDnF2298IN7iGgCce?=
 =?iso-8859-1?Q?7ufWSX9PXyq6jkC7R2wuy6AwRxhh/Er+nnKYsNxFFUr3RlfA6v2CpIZZSG?=
 =?iso-8859-1?Q?tA1xspiRY4xeyzQAt51/zne8fgOLUMoUfAc6idwD4P4OFUIsHikAetJG3C?=
 =?iso-8859-1?Q?TDRwXArgciVE7uONrOQ27cJmXJ4BPSPvCQpMixlQIx4iSz5wQLIfcL2LBR?=
 =?iso-8859-1?Q?XbHgd9xmlBE75D0I+O2I7clhb9bz2Df7wgcfHKb70tYpk4HQgpcaxmNWgz?=
 =?iso-8859-1?Q?88ze7+HTktb9vs0MIuhc7KBzDd6a1I+S8quNZF6+SPW6vAzopIJS7ipaZ+?=
 =?iso-8859-1?Q?j90oQ9AW4egcXfaMlW7zx5ClLuh5KOserR28/yDuPwRuWVv5kBVgaYGBfO?=
 =?iso-8859-1?Q?1RmzXvoMok47I9clbqeZuyXtV/7fLOzqMKTDDhTmauY6g5Bs/777CzCaNz?=
 =?iso-8859-1?Q?BHSdi8Fdc/Y1JJ2WE5/bt+wgAoWHC33/I4+fz5il0yfd9Y+cVbQuR41A0l?=
 =?iso-8859-1?Q?3ivHwBeq9UcGz2R/WUhj1ZdITumjzsRrHiiFWvm2CL4wwxOL75dKCEK72L?=
 =?iso-8859-1?Q?+UNm/Naij5x0Vi1S6GfJnr3jQeegRFEK1xPJhX0rgMnEm8AHaELAwkD6o8?=
 =?iso-8859-1?Q?uy/J41oAGVKOMEFpxhmUaYD4rRSyXcTUpeEmMXmxi70cMASBBaRV5sspZz?=
 =?iso-8859-1?Q?VfCpAx8rQbUPk4VcXXAdWSJXs2mizvvmdR/Zx/6PVmD/WoIsGPTjGut2rc?=
 =?iso-8859-1?Q?oPQluWJf5J6VOV94yNEWKsM33B4/XgM1sBDz21DaN0GiJTQDqGbxo9jViq?=
 =?iso-8859-1?Q?2hCpO050hceWr/8+Dc17ZCMwHVOQiNmGcer/brnYk2hhTEOpe45a9HSA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2199bc9-b017-4d33-fd7c-08daa84f482f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:48.9427
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KnvkRYWgL8cssGVoO298A95zqV8020OZSLIKjJBDXJZBxnjyk5Q9oj5T+F+fVmK5UzVp4+haBElDwpXypJehCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8622
X-Proofpoint-ORIG-GUID: RuDHMRXrZFaca-OYX3A6AsXEwKalTYd6
X-Proofpoint-GUID: RuDHMRXrZFaca-OYX3A6AsXEwKalTYd6
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1015 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=552 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

System suspend may lead to a state where GIC would be powered down.
Therefore, Xen should save/restore the context of GIC on suspend/resume.
Note that the context consists of states of registers which are
controlled by the hypervisor. Other GIC registers which are accessible
by guests are saved/restored on context switch.
Tested on Xilinx Ultrascale+ MPSoC with (and without) powering down
the GIC.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/gic-v2.c     | 138 +++++++++++++++++++++++++++++++++++++-
 xen/arch/arm/gic.c        |  27 ++++++++
 xen/include/asm-arm/gic.h |   8 +++
 3 files changed, 172 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index b2adc8ec9a..b077b66d92 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -123,6 +123,23 @@ static DEFINE_PER_CPU(u8, gic_cpu_id);
 /* Maximum cpu interface per GIC */
 #define NR_GIC_CPU_IF 8
=20
+/* GICv2 registers to be saved/restored on system suspend/resume */
+struct gicv2_context {
+    /* GICC context */
+    uint32_t gicc_ctlr;
+    uint32_t gicc_pmr;
+    uint32_t gicc_bpr;
+    /* GICD context */
+    uint32_t gicd_ctlr;
+    uint32_t *gicd_isenabler;
+    uint32_t *gicd_isactiver;
+    uint32_t *gicd_ipriorityr;
+    uint32_t *gicd_itargetsr;
+    uint32_t *gicd_icfgr;
+};
+
+static struct gicv2_context gicv2_context;
+
 static inline void writeb_gicd(uint8_t val, unsigned int offset)
 {
     writeb_relaxed(val, gicv2.map_dbase + offset);
@@ -1251,6 +1268,40 @@ static void __init gicv2_acpi_init(void)
 static void __init gicv2_acpi_init(void) { }
 #endif
=20
+static int gicv2_alloc_context(struct gicv2_context *gc)
+{
+    uint32_t n =3D gicv2_info.nr_lines;
+
+    gc->gicd_isenabler =3D xzalloc_array(uint32_t, DIV_ROUND_UP(n, 32));
+    if ( !gc->gicd_isenabler )
+        goto err_free;
+
+    gc->gicd_isactiver =3D xzalloc_array(uint32_t, DIV_ROUND_UP(n, 32));
+    if ( !gc->gicd_isactiver )
+        goto err_free;
+
+    gc->gicd_itargetsr =3D xzalloc_array(uint32_t, DIV_ROUND_UP(n, 4));
+    if ( !gc->gicd_itargetsr )
+        goto err_free;
+
+    gc->gicd_ipriorityr =3D xzalloc_array(uint32_t, DIV_ROUND_UP(n, 4));
+    if ( !gc->gicd_ipriorityr )
+        goto err_free;
+
+    gc->gicd_icfgr =3D xzalloc_array(uint32_t, DIV_ROUND_UP(n, 16));
+    if ( !gc->gicd_icfgr )
+        goto err_free;
+
+    return 0;
+err_free:
+    xfree(gc->gicd_icfgr);
+    xfree(gc->gicd_ipriorityr);
+    xfree(gc->gicd_itargetsr);
+    xfree(gc->gicd_isactiver);
+    xfree(gc->gicd_isenabler);
+    return -ENOMEM;
+}
+
 static int __init gicv2_init(void)
 {
     uint32_t aliased_offset =3D 0;
@@ -1318,7 +1369,8 @@ static int __init gicv2_init(void)
=20
     spin_unlock(&gicv2.lock);
=20
-    return 0;
+    /* Allocate memory to be used for saving GIC context during the suspen=
d */
+    return gicv2_alloc_context(&gicv2_context);
 }
=20
 static void gicv2_do_LPI(unsigned int lpi)
@@ -1327,6 +1379,88 @@ static void gicv2_do_LPI(unsigned int lpi)
     BUG();
 }
=20
+static int gicv2_suspend(void)
+{
+    int i;
+
+    ASSERT(gicv2_context.gicd_isenabler);
+    ASSERT(gicv2_context.gicd_isactiver);
+    ASSERT(gicv2_context.gicd_ipriorityr);
+    ASSERT(gicv2_context.gicd_itargetsr);
+    ASSERT(gicv2_context.gicd_icfgr);
+
+    /* Save GICC configuration */
+    gicv2_context.gicc_ctlr =3D readl_gicc(GICC_CTLR);
+    gicv2_context.gicc_pmr =3D readl_gicc(GICC_PMR);
+    gicv2_context.gicc_bpr =3D readl_gicc(GICC_BPR);
+
+    /* Save GICD configuration */
+    gicv2_context.gicd_ctlr =3D readl_gicd(GICD_CTLR);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 32); i++ )
+        gicv2_context.gicd_isenabler[i] =3D readl_gicd(GICD_ISENABLER + i =
* 4);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 32); i++ )
+        gicv2_context.gicd_isactiver[i] =3D readl_gicd(GICD_ISACTIVER + i =
* 4);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 4); i++ )
+        gicv2_context.gicd_ipriorityr[i] =3D readl_gicd(GICD_IPRIORITYR + =
i * 4);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 4); i++ )
+        gicv2_context.gicd_itargetsr[i] =3D readl_gicd(GICD_ITARGETSR + i =
* 4);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 16); i++ )
+        gicv2_context.gicd_icfgr[i] =3D readl_gicd(GICD_ICFGR + i * 4);
+
+    return 0;
+}
+
+static void gicv2_resume(void)
+{
+    int i;
+
+    ASSERT(gicv2_context.gicd_isenabler);
+    ASSERT(gicv2_context.gicd_isactiver);
+    ASSERT(gicv2_context.gicd_ipriorityr);
+    ASSERT(gicv2_context.gicd_itargetsr);
+    ASSERT(gicv2_context.gicd_icfgr);
+
+    /* Disable CPU interface and distributor */
+    writel_gicc(0, GICC_CTLR);
+    writel_gicd(0, GICD_CTLR);
+
+    /* Restore GICD configuration */
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 32); i++ ) {
+        writel_gicd(0xffffffff, GICD_ICENABLER + i * 4);
+        writel_gicd(gicv2_context.gicd_isenabler[i], GICD_ISENABLER + i * =
4);
+    }
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 32); i++ ) {
+        writel_gicd(0xffffffff, GICD_ICACTIVER + i * 4);
+        writel_gicd(gicv2_context.gicd_isactiver[i], GICD_ISACTIVER + i * =
4);
+    }
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 4); i++ )
+        writel_gicd(gicv2_context.gicd_ipriorityr[i], GICD_IPRIORITYR + i =
* 4);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 4); i++ )
+        writel_gicd(gicv2_context.gicd_itargetsr[i], GICD_ITARGETSR + i * =
4);
+
+    for ( i =3D 0; i < DIV_ROUND_UP(gicv2_info.nr_lines, 16); i++ )
+        writel_gicd(gicv2_context.gicd_icfgr[i], GICD_ICFGR + i * 4);
+
+    /* Make sure all registers are restored and enable distributor */
+    writel_gicd(gicv2_context.gicd_ctlr | GICD_CTL_ENABLE, GICD_CTLR);
+
+    /* Restore GIC CPU interface configuration */
+    writel_gicc(gicv2_context.gicc_pmr, GICC_PMR);
+    writel_gicc(gicv2_context.gicc_bpr, GICC_BPR);
+
+    /* Enable GIC CPU interface */
+    writel_gicc(gicv2_context.gicc_ctlr | GICC_CTL_ENABLE | GICC_CTL_EOI,
+                GICC_CTLR);
+}
+
 const static struct gic_hw_operations gicv2_ops =3D {
     .info                =3D &gicv2_info,
     .init                =3D gicv2_init,
@@ -1361,6 +1495,8 @@ const static struct gic_hw_operations gicv2_ops =3D {
     .map_hwdom_extra_mappings =3D gicv2_map_hwdown_extra_mappings,
     .iomem_deny_access   =3D gicv2_iomem_deny_access,
     .do_LPI              =3D gicv2_do_LPI,
+    .suspend             =3D gicv2_suspend,
+    .resume              =3D gicv2_resume,
 };
=20
 /* Set up the GIC */
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 3b0331b538..e9feb1fd3b 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -467,6 +467,33 @@ int gic_iomem_deny_access(const struct domain *d)
     return gic_hw_ops->iomem_deny_access(d);
 }
=20
+int gic_suspend(void)
+{
+    /* Must be called by boot CPU#0 with interrupts disabled */
+    ASSERT(!local_irq_is_enabled());
+    ASSERT(!smp_processor_id());
+
+    if ( !gic_hw_ops->suspend || !gic_hw_ops->resume )
+        return -ENOSYS;
+
+    gic_hw_ops->suspend();
+
+    return 0;
+}
+
+void gic_resume(void)
+{
+    /*
+     * Must be called by boot CPU#0 with interrupts disabled after gic_sus=
pend
+     * has returned successfully.
+     */
+    ASSERT(!local_irq_is_enabled());
+    ASSERT(!smp_processor_id());
+    ASSERT(gic_hw_ops->resume);
+
+    gic_hw_ops->resume();
+}
+
 static int cpu_gic_callback(struct notifier_block *nfb,
                             unsigned long action,
                             void *hcpu)
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index c7f0c343d1..113e39460d 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -275,6 +275,10 @@ extern int gicv_setup(struct domain *d);
 extern void gic_save_state(struct vcpu *v);
 extern void gic_restore_state(struct vcpu *v);
=20
+/* Suspend/resume */
+extern int gic_suspend(void);
+extern void gic_resume(void);
+
 /* SGI (AKA IPIs) */
 enum gic_sgi {
     GIC_SGI_EVENT_CHECK,
@@ -390,6 +394,10 @@ struct gic_hw_operations {
     int (*iomem_deny_access)(const struct domain *d);
     /* Handle LPIs, which require special handling */
     void (*do_LPI)(unsigned int lpi);
+    /* Save GIC configuration due to the system suspend */
+    int (*suspend)(void);
+    /* Restore GIC configuration due to the system resume */
+    void (*resume)(void);
 };
=20
 extern const struct gic_hw_operations *gic_hw_ops;
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417683.662409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf9-0005PB-5f; Fri, 07 Oct 2022 10:33:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417683.662409; Fri, 07 Oct 2022 10:33:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf8-0005Iy-C5; Fri, 07 Oct 2022 10:33:02 +0000
Received: by outflank-mailman (input) for mailman id 417683;
 Fri, 07 Oct 2022 10:33:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf6-0004P4-H8
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:00 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 681f8a81-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:32:57 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978P173005817;
 Fri, 7 Oct 2022 10:32:53 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjk3-5
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:53 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:48 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 681f8a81-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AAWF34F6/1Z5NFhIU92EsNIuKvAHCkW0l1ZAL3J9XHQzNKRfa/+eXBlOItUEu1EuNuHhqgLyYYpZZ0OPwWVamACto75Odu7V5Snc8lRqch0MFgZisrtZ6/vTAebVIrW7Mct2ZOPeuduiUFDXIxmpCXNLsC2q18GiR6ggMcEeLbEDanhyOs3cC5sOUan5AiSovel6icOwDHUdWD6WmWPPeqdRei9s9pQpszojji9kFALNUjo/8iOoH9JnLqk5xXytRctwA5IHoWAxQWuZ4lzVHoWLc2GDhnhjw02jMu+FloO1BMe7yKJvneTkh0lFi2xYBkdLBtBBn035Ekf5T8FMNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6liqUes5WMbS739XSwLeXIGXWML/GuvqIhUsXx7+7IM=;
 b=fP4JoQPQA2FccAwNm1b7qcOB70DU262DZcuZdnv/99lIJJGzJnO4P1mxx5LVWG7k8eA+9XwIko8Qd3agM4Hcfa3W57rgfhpGNXbpdgU2KGzDX1uhaJ6Ciq9hNurpsnJPpWImgIM9BbU3ujgP+d4kWV9e5pQIDmhdu1eU1demyHhoiU2euf3IqtP+6AtpEnPoUNtH7LmkmvXYqEkHkW02N9g8NBbRvW0rk+mCTGPABC98VZcmKcdM1hTnpyx0gUBaraqzgpltI9hXHn19FnBRuBgY94V//U8OHRJM51hNmSsrshOY4sTraX18oaTplEf4xqjwWFbpWCHhc/JBvDWIMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6liqUes5WMbS739XSwLeXIGXWML/GuvqIhUsXx7+7IM=;
 b=nQhhycb2bTJVgqn9/BtPfUZBbRhsrTkvB4/4+i82Tgj0RJd6MjGalesKCqNNiP8f8Htz1hBFWc6x9/bZ5nuVAEEOKHRqM6lWTdyhmtr7d/vD4btpobSkbM3Ym2Yx7vzrFYpn6OXvlin7nxjgrgwiajONYAO+ZeNEjmgXKmIGkakUPL68ZRKUpbvn2bZ/mnRwJEm4YAuREtAi+oGngglqYL4RqSIArDEFIdU5KW7SOSeHbf326sIa9qfSbPdJyEnQlnwo4T0RGIJuhc3dvmzKug4TBLSufSHFe93TLj+TiBI0D6Q/ZDxil4EkrIWkRGMpolj9u8ezy4SD5cxNNBrrCg==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 06/19] xen/arm: Freeze domains on suspend and thaw them on
 resume
Thread-Topic: [PATCH 06/19] xen/arm: Freeze domains on suspend and thaw them
 on resume
Thread-Index: AQHY2jgk49iXxKVTXku3T5cqXu57kw==
Date: Fri, 7 Oct 2022 10:32:48 +0000
Message-ID: 
 <4cbdda3b5c6cce54724a505da14ce968010d0958.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: 2949a854-bf23-4b54-6bf3-08daa84f4778
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Yo4+mauDxamzVgxHBr+xLAWQ+aqsN5BKGsPYjH43zOREW92cyQsA/uCCRrgdW436NLBLDYVWcKEZQ0mWv+QPkrQR1tdJQParLFMQKcuGvT+XZZMvueGmWkvsmn1yfoc0b5srw659XlcMWdhcEjIKe+zQ5KJ5wK4tKRINh3JjIi/pZfamzjEQvAiNF4ueMoGccaE7MisU3txgDsIopu+7id0DbF45lCVgDSMeEcJ5s6VAOPAsTJ+yqLiS07EG+UPT/rQGYmn65+Le5UrwRHVtHcp2uh4lbrBRUt3hs5vIEYvS+FJJ0qyhpA4w0iQjZptrPvC/ED5GCR5jzUKV17/n1UEmcFJFqWKl1InQBgcgCfZ/fSZnKhjMNYPNNv0jlpjbdMZMoaj3CBGBE48ZuPs7SXw1Bne3qiBTqYTv8bRxumGU3i/2Q2saziKC2BEgSrb94c13JPTvQ28TDQ6WE9FfDNZxyE3srtUjUR5H/6uBdMPbsGCn5zupDQXj0yY2tCEY8XPrk2w+yoTp+zU3O8bapUWs/zUUSHqiMjJqLgcNJ3G1zbhJTMXB3Ejd06x1brMDusbghvC0QqSr9IaW55EpqM76kWqPWlvwghWcvyhIv+ZQlPUqT+IJKbU48KmuOa4mw0AySySieQvYIg0TTVCscqNwCJ6H3nOAPnE5v+EVQ6AhroDJmEdWs4Hy8U/ZADeJQfZoKBQQYtDyVlRg3bi4LcFEQaXhYwhQSbgnycPVabi5pVKm5lTK45I/9AjMulAA
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(15650500001)(5660300002)(4744005)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(38070700005)(122000001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?45GfHVC/PYY/mvjWRUBeoe1tOGqCFX5Eg/IM6POszdXHzXmDRiAbHMx+8N?=
 =?iso-8859-1?Q?UUULPaauVs6dOLFF1qYGCqi5bwgoAoRwCSR3qL1muiOthPWzr/r0cjJ6ax?=
 =?iso-8859-1?Q?pSWbPtFpakv8LIxB3ez8zWwAHXVehZVZSf5PSeDGbU4oqrDoMv9MYt7DdP?=
 =?iso-8859-1?Q?2Rr4+xQGJl1taN7OuXqfX8fU3pgxqzyrA0eNQGA30kEZahMhiH18WSdVgh?=
 =?iso-8859-1?Q?jFUnqeS1GPCvcSxNJJXX6MVq+XbaJ864I62x1vHwGmUVH6OaLCymi2eQDP?=
 =?iso-8859-1?Q?wZ+piQebZdPcaT6bLsWhg0rAwk10RE+rho2gI1XsAFTUof8DMAByCezSoL?=
 =?iso-8859-1?Q?iPt/5D5MWf4ge338KqYDTJsc2qSyzS6jHLWtElC0nWqtcZnBP11rLtu8RL?=
 =?iso-8859-1?Q?WhwGK+qYxcYeKIwTLXOMr9vv9iFc70RJIi9GP2CJVWpGF3NihLEgrFNsuj?=
 =?iso-8859-1?Q?Jzd7z7+lgdmu6cbF0Kmt8KYkXt4w2Mwim7ZUZtmsnCrDj2pzPAS5Vs9O3w?=
 =?iso-8859-1?Q?gXCuiyG1LtvCIQ4WCq+J+Xs/I4JJiqE4/Pbv6UvpUaJVtOW8ud5tktO0Et?=
 =?iso-8859-1?Q?Okr1PSIXjHSN51z9rbgjcFtqmB+PujGEhW3SmmTXmYF01hTson6f687cl4?=
 =?iso-8859-1?Q?+iczfNayWZ/P0rlc2u525DGvpgZLC5gfdd6ng560XDSkpHbhNxqJO0MH+e?=
 =?iso-8859-1?Q?d9LvFy+vk2CdP9L7ZkhptM/RAXLeT49php9CcLsGuHnFWQo7e+++PkcVqX?=
 =?iso-8859-1?Q?QoTvfY99h2U3n0wuBi4Dk4eiJD0/rkg4ZFE6MPSUzNw8zEElvj2RjwxHQj?=
 =?iso-8859-1?Q?S6+cRAmkUpFxgjjWqZmIxy5IujMXKePZGrSyYAXBkZ40viBCx3WkN08iay?=
 =?iso-8859-1?Q?vga4Vt9G0+GNnDtqd1kVSPnCnAl97G7c1Qulq2jFdtUDE9NRTTJ1DdsC1u?=
 =?iso-8859-1?Q?nR5OlDbeXxU/frdGAv2DPDkJ4poE0fwBYEd3SLiSeIPPWbNa57L1kVHv9a?=
 =?iso-8859-1?Q?Xa5ze1vdqXuPz5ceeg2MbOclzVw5m+s4JH1NrQBbWofYEuvexfw3wG9hRo?=
 =?iso-8859-1?Q?uq4d247bFN1fAuimHPSUbxeNeX2RXzU60GJe6lZNQScOUSnz3fVsMdNSwW?=
 =?iso-8859-1?Q?986opIVXi2WQDRvU013c+JBVcAXn1hy+9iqIATEgomLUQRPu902iuq4cc/?=
 =?iso-8859-1?Q?wlH5JNrXtO22cktfiQ+qAmfpPRmzLlUbL5HqFsdnaXZuwqvAV6byOhc7IW?=
 =?iso-8859-1?Q?7xW0pxb6KyGAFH4cig4kTF6pbJPh8MT7SJsHep0869d5YHWPJfpC2bi4qH?=
 =?iso-8859-1?Q?pVCjssPyox6F77qosBcoNrrJTvimxGP6DCXq/holNGRG6rYK7M5PwKoRwd?=
 =?iso-8859-1?Q?lZrgC1BV+sKqu2+jfA9Krmp4YQNsKn4FbGo6yZCt372AQcFz8AciqWK/ot?=
 =?iso-8859-1?Q?nrgW5Fu47YxssdCHR7tsBR10VNFuuVR6KCGq9OdsinQ+2PTXQLswCdk55j?=
 =?iso-8859-1?Q?dyrka1gTwgx/lQyDruFYcfV35a5r9QZp733b4OFk5TnH+u9S8uaZviQsEp?=
 =?iso-8859-1?Q?8IO2sGI/1VBGjYFaSQA1Lra/6zL/L8btqptpUMCAVzpLv4ftQM0Gzd7m67?=
 =?iso-8859-1?Q?JhvbwpSLH3AUqYEvB94YYHCcaaS372fVNiOkjgyx+D7oCBpE0w59V+NA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2949a854-bf23-4b54-6bf3-08daa84f4778
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:48.0991
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z94UDmqPX3jwR/Jr4Ki3HHWHbGzd7jAQPBoRiY60jCX33bweElqYZS/42MJcrAcrvGD80VnJUilbwRh8cmO0RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-GUID: UrE49jw6OF5XZapyap_6tXY19TgLRAad
X-Proofpoint-ORIG-GUID: UrE49jw6OF5XZapyap_6tXY19TgLRAad
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=632 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

Freeze and thaw of domains is reused as implemented for x86. In
addition, system_state variable is updated to represent the actual
state of the system.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/suspend.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index b09bf319d0..2b94816b63 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -137,6 +137,14 @@ static long system_suspend(void *data)
 {
     BUG_ON(system_state !=3D SYS_STATE_active);
=20
+    system_state =3D SYS_STATE_suspend;
+    freeze_domains();
+
+    system_state =3D SYS_STATE_resume;
+
+    thaw_domains();
+    system_state =3D SYS_STATE_active;
+
     return -ENOSYS;
 }
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417684.662417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf9-0005Wu-NU; Fri, 07 Oct 2022 10:33:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417684.662417; Fri, 07 Oct 2022 10:33:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf9-0005UC-2y; Fri, 07 Oct 2022 10:33:03 +0000
Received: by outflank-mailman (input) for mailman id 417684;
 Fri, 07 Oct 2022 10:33:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf6-0004PE-Ak
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:00 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 675f2b37-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:32:56 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978P16x005817;
 Fri, 7 Oct 2022 10:32:50 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjk3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:50 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:45 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 675f2b37-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M3dJFWSIy0IghCZdaSKzBddZ1Bv3uipDP7U0xgibMA569oDDlo9xl7NNMVNv8YbQKXfINOmgKm8cNyWsvWQVC6fGklvqMoy8XHL1vHsUxJCDWfK8ec+DarhqXSDely93EtXkvUyeMBIvZEMXgornHDDJ8fYW0YVv3nO0dGL7MsJ4tsPzH+lvV4q7YubUJQiucE1IbzN9Ysg1/QK1YnSiqhgFDkOR+PMXJ6Cn0YS56zFZss+MPAwTYdZ7733P2f7ywqH0QLoR0wDxeXM0pnJU2vlJkm6US7J7DheFSYNGeMhQqG9Bj18sx0f9YGAPj1EutiI/zduHt5C4h1S1jAJCYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uI/NqW/3wfj/Zw9sR+GCehbnO/hQ40IHuafpqfCflac=;
 b=PhXivvvF/HiF5bZivKIDdGMl6NAgnB6Ffc5rsw1v7QcrjpbNGwTqqC+pfYpjqTkD87o0c2guyruVKG/JdEeFgD74qEzb6k29dEEFropkTjEN+Cmfz8S8r8J8OQxwV7xV4lB2+i5GV5lEGinaMQ+MEi/x/kaKG/kzluoTzIPenqrIjT9+5PxbZOX6dVbqasZB1T3kzujlIMR9cv0He5e89HPqg0BQM9f4yGkbe7aS5VXiYTZjdbdAdMCQ1Y+R42bSOuEOVQZmPCejo34SIory2bU/QeKpde6wagtg0v0bHUybjess+FWy0N0JegRvMcvT/Qj4ozBFX1FS8NK4bgBRqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uI/NqW/3wfj/Zw9sR+GCehbnO/hQ40IHuafpqfCflac=;
 b=BkMcuhp55247Y3cJJuJbWsG78IXBL3f83guzYQhBNdS0i5Eb5h/uZJIB6NsIT0uts/P4Gvh1e1gcUUs92PjUC2VzYy/ALgTEpjz3/Cp1y+peVDWHZBUjM5AF9ZC/JarwIAV7EuwHpHnFnf26kLrcOX9KUo1h278oxjX4UKSDDuS45ysWvVx1wuL4/S62VMd46E5EAzJwXParqQ2CwYjxvh1Gi+tB2UyM5kT2Y8qB0xdW8EGfgW9biALql8rqLFEqTteTy9ASFCmPQ65+WY+KIu40jGZ75gJckHoQiL6eaFFMTiGOrMLlvWJs1sKGZXijjAAEy45cnrHFXyffpAc1KA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>,
        Wei Liu <wl@xen.org>, Dario Faggioli
	<dfaggioli@suse.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta
 Poturai <mykyta.poturai@epam.com>
Subject: [PATCH 01/19] xen/arm: Implement PSCI system suspend
Thread-Topic: [PATCH 01/19] xen/arm: Implement PSCI system suspend
Thread-Index: AQHY2jgjWfMPRPlYK0auWtHF0HPLyA==
Date: Fri, 7 Oct 2022 10:32:45 +0000
Message-ID: 
 <598de284f5f133a622eca3e120a1aabae0f2a1e2.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: 8342bc57-0c76-48c6-c400-08daa84f45c1
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 zuV0Yq2m0C6j5aBgFbfqJx84jSpWpnjSw0GbA0lkc9DjknEGZuaw5clHUpAfrrgzoA0QrylZ9CVMJ88DRqWjPQvFMsNOZsftQPgwW+tw+H2i7uVuqNkwPMwA001ZWBkd39ek/gQmNbD+hV7C5jfqSi+rgtCcm7S4pOjJKlUrt0jisaRNYzJEa4/QXa2HvjdbfWT7F1TxO7+zAka+tHX0qvpGGCoeMUQqhlzSpmJap+VtUNGbtAzrGn50fETM1iNvAkMnLJjqsXdily1jh+Yn+M95YdAejgA2K3InbqEKBsFBrW4I3flWyAw2qQXoufIwEW5Ofwpecnjg2ziK46GCgb8dhtBkhfEoNvPq3ShOnCfkCy6Wy7CuQh2VhSHYI4X9+FE+IRi3bsB0J79a95q2Wegac8jWvBI0w+Uc8a9EHfqaccDZR3/oiQcNaT6CBvAZwqYe2MMYPX4dErP7LyCUij1XBBjFNntS7CioUR5fUecEXHMWLhk1t8Oe1Y3rohiBwadwAG+Ok9EPSbfGRuZG3lLKu1vUjvbPqn2KaTBisjrTDNZk3qVzebMSl2xm5a28B6N6PaHZzy7DO42G2v07tnl143KMF5wKZ4H+C30SpBJeoE+j11ANTebJ/icEwN1MG0IScaeopB4wRfTTd097t9/0WOm0nU4C0T99g5mOsLmetim7kbImAmta1ybIRXZlxlvq7IiO0lnWhQoP/dgPqN+HSpdmTuhKH/tfbCEhhhEjLiTqr/CHtNk7NexnJrfV2bwIs+VibyIJOr/hHXh4iY1Md12BdF5nTqSwNOM3RUI=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(30864003)(86362001)(15650500001)(5660300002)(7416002)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(107886003)(38070700005)(122000001)(36756003)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?BDw1NkGgW0hE79NMHZQ3x9h8EcYoePTgh0mSPNcov8lIjh11H/88kfDHn0?=
 =?iso-8859-1?Q?uVdo66fC1RN9G+ir+NYw8hUTUlwvmzKXw6uGvCKOBZDQVWwx0xwWOvgHED?=
 =?iso-8859-1?Q?Lrk25mTmmEnCv5UQqG2hy5o+f8YjTpeDoLPQClqY6tpIOameR+f8krsoc3?=
 =?iso-8859-1?Q?UZvV4YmOEvSNtVg3cjsiYwxXWwGhp9HWPD7Rhi11gEKDgYCYsV64E1S/Nx?=
 =?iso-8859-1?Q?SubrXSpuK2QosuN2anWGwzhA45hxHpZeRgMWRhp+6YfqfLII7AbgeRpUBi?=
 =?iso-8859-1?Q?qvilK22NssL7bcFQgzDurp+KFfnaI0h8FrbwQ3mTFFMFV4nN2K2KYUWLvh?=
 =?iso-8859-1?Q?4C2lLfj/lHG1Lb3GGxSykX5ZsyAuzEOdvPYviNEO6dbJB7+zBgJbQVOaio?=
 =?iso-8859-1?Q?qkBZ45qatAUdI450BlW0QmnyH8CTm9taHiVwGZIZfjUgEt2r+2K+VTEqms?=
 =?iso-8859-1?Q?AAabQXe2ewXvgNCqHONL5EKVZGUYsO5IriH1xsAd1bP90fecjiVtQkPVjT?=
 =?iso-8859-1?Q?7gsj/OW7PjaTDpAXJfZBF0Dwo/7k5BMaVWEFakYhfkf7KxSCNIHkIxFTRc?=
 =?iso-8859-1?Q?EsGlmgWfROK7mnjBWC2uHKhZF+DzWOIP+TM0i+2dgMDYZ9G5ZqCeptOjGT?=
 =?iso-8859-1?Q?qWHPL4f+CoMW5tM9Zdy8o1PRisp4Ryqvhrjgs4/yIxYsqarYMV3EgA1Xis?=
 =?iso-8859-1?Q?Hr80wmM1S9Uu1h/mY4j2prPpXLnui2h3TsTMeBBGUvTi0AHZZct8gTw1Hr?=
 =?iso-8859-1?Q?UjoyRHlnzQMLKrO1kg462aLO9T6bBs2yYJubm2Y5YqWuICsexTnVZj5LGb?=
 =?iso-8859-1?Q?Kd518yE7Rh3TzQUMNe3ufvdZAjROQzJ8VXpg7oj1Z6DS7uYZNlms5s6vHE?=
 =?iso-8859-1?Q?Is2dM1M1pS4/AMC2Puq7MBP/A6IOce+D2vZCdcW/Nn6FPqNXdahAVqI04N?=
 =?iso-8859-1?Q?dMiPoz51TpGjp++OzI9NZU17WbF7STYvMqZMpctafOp87ojoLqjZjxAqz4?=
 =?iso-8859-1?Q?xDazmGkRDJmEfdBNs6Y0f37H9WwlUmQnRz2Z9iiLQxRbCwJXPuPOUibhHz?=
 =?iso-8859-1?Q?e0JK7odaO56bb3GoROreLVOV9NlqCK2SYpldMmtr3RQ1LXtbO66VhDsldr?=
 =?iso-8859-1?Q?62GtRz5sHFWaW0jFwdzlspLoc5mEucBqFBZSZUme5uoayj6L5MDowPWMTD?=
 =?iso-8859-1?Q?aWfZPIzPN8AE7zc1dssrptNQA0fFs0Upo78gWJbozdqh3TkqqpYcux8RXY?=
 =?iso-8859-1?Q?LQ4Ydi3ZiFao41a3oO0t9jCTfqVQVfhiuEOTK+rZEhE/d37D78SMEPKuDL?=
 =?iso-8859-1?Q?oef/2BjVSEog+Ta8zEW39ZWrldqEcZhhipMGLuabmjj/vQnxIryYXEYxBO?=
 =?iso-8859-1?Q?jXGg4t/XjmUbhMye4hp/kezGAfIp6Let1E4qf/T45WjxLzdlNN8NWC+mH6?=
 =?iso-8859-1?Q?S8rsyomQzPE+Z0XjvzOKMSJH3gTZwNCPScj0wDht5kWN7Me5XP7ZtCAThP?=
 =?iso-8859-1?Q?kUDyvdgCBbmv0UXfnCGvGSXWbNnhKZHhLUWRIiG+KAdmqp4c42gbLu9XvS?=
 =?iso-8859-1?Q?aWDmoti1jmx6NZTNuuvz1LDk4pbCj/cL982yeyhq6YC7ZvrXRIjxtmuaNx?=
 =?iso-8859-1?Q?MgV0COz/Q072ZUk9sakFsqo4zfqNMMfR/JRIiWK/9TfMiWMsgUQIWlLw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8342bc57-0c76-48c6-c400-08daa84f45c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:45.2399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9YQq0UBcYWBLY9YOz//j3kG/BoUXzXkmtaNvE+BYjH2MnGV53ZNGWtc/q9ZoynD5V2+LpA1yX7eFVgYoMl24Ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-GUID: HX4J_RYu_KNOMa4DwtvDbvD0iJpi3afV
X-Proofpoint-ORIG-GUID: HX4J_RYu_KNOMa4DwtvDbvD0iJpi3afV
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=965 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

The implementation consists of:
-Adding PSCI system suspend call as new PSCI function
-Trapping PSCI system_suspend HVC
-Implementing PSCI system suspend call (virtual interface that allows
 guests to suspend themselves)

The PSCI system suspend should be called by a guest from its boot
VCPU. Non-boot VCPUs of the guest should be hot-unplugged using PSCI
CPU_OFF call prior to issuing PSCI system suspend. Interrupts that
are left enabled by the guest are assumed to be its wake-up interrupts.
Therefore, a wake-up interrupt triggers the resume of the guest. Guest
should resume regardless of the state of Xen (suspended or not).

When a guest calls PSCI system suspend the respective domain will be
suspended if the following conditions are met:
1) Given resume entry point is not invalid
2) Other (if any) VCPUs of the calling guest are hot-unplugged

If the conditions above are met the calling domain is labeled as
suspended and the calling VCPU is blocked. If nothing else wouldn't
be done the suspended domain would resume from the place where it
called PSCI system suspend. This is expected if processing of the PSCI
system suspend call fails. However, in the case of success the calling
guest should resume (continue execution after the wake-up) from the entry
point which is given as the first argument of the PSCI system suspend
call. In addition to the entry point, the guest expects to start within
the environment whose state matches the state after reset. This means
that the guest should find reset register values, MMU disabled, etc.
Thereby, the context of VCPU should be 'reset' (as if the system is
comming out of reset), the program counter should contain entry point,
which is 1st argument, and r0/x0 should contain context ID which is 2nd
argument of PSCI system suspend call. The context of VCPU is set during
resume path, to prevent it being overwritten by ctxt_switch_from after
vcpu is blocked and scheduled out.

VCPU is marked as suspended with _VPF_suspended flag. A suspended domain
will resume after the Xen receives an interrupt which is targeted to the
domain, unblocks the domain's VCPU, and schedules it in. During the
vcpu_unblock execution the VCPU is checked for VPF_suspended flag. If
the flag is present, the context of that VCPU gets cleared and entry
point/cid are set.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Signed-off-by: Mykyta Poturai <mykyta.poturai@epam.com>
---
 xen/arch/arm/Makefile            |   1 +
 xen/arch/arm/domain.c            |   4 +
 xen/arch/arm/suspend.c           | 182 +++++++++++++++++++++++++++++++
 xen/arch/arm/vpsci.c             |  28 +++++
 xen/common/sched/core.c          |   8 ++
 xen/include/asm-arm/domain.h     |   3 +
 xen/include/asm-arm/perfc_defn.h |   1 +
 xen/include/asm-arm/psci.h       |   2 +
 xen/include/asm-arm/suspend.h    |  17 +++
 xen/include/xen/sched.h          |   3 +
 10 files changed, 249 insertions(+)
 create mode 100644 xen/arch/arm/suspend.c
 create mode 100644 xen/include/asm-arm/suspend.h

diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index b5913c9d39..07dbbd99a3 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -49,6 +49,7 @@ obj-y +=3D setup.o
 obj-y +=3D shutdown.o
 obj-y +=3D smp.o
 obj-y +=3D smpboot.o
+obj-y +=3D suspend.o
 obj-y +=3D sysctl.o
 obj-y +=3D time.o
 obj-y +=3D traps.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 23c8b345d4..4110154bda 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -40,6 +40,8 @@
 #include <asm/vtimer.h>
 #include <asm/vscmi.h>
=20
+#include <public/sched.h>
+
 #include "vpci.h"
 #include "vuart.h"
=20
@@ -101,6 +103,8 @@ static void ctxt_switch_from(struct vcpu *p)
     if ( is_idle_vcpu(p) )
         return;
=20
+    /* VCPU's context should not be saved if its domain is suspended */
+
     p2m_save_state(p);
=20
     /* CP 15 */
diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
new file mode 100644
index 0000000000..987ba6ac11
--- /dev/null
+++ b/xen/arch/arm/suspend.c
@@ -0,0 +1,182 @@
+/*
+ * Copyright (C) 2022 EPAM Systems Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as publishe=
d
+ * by the Free Software Foundation; version 2.1 only. with the special
+ * exception on linking described in file LICENSE.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ */
+
+#include <xen/sched.h>
+#include <asm/cpufeature.h>
+#include <asm/event.h>
+#include <asm/psci.h>
+#include <asm/suspend.h>
+#include <public/sched.h>
+
+struct cpu_context cpu_context;
+
+/* Reset values of VCPU architecture specific registers */
+static void vcpu_arch_reset(struct vcpu *v)
+{
+    v->arch.ttbr0 =3D 0;
+    v->arch.ttbr1 =3D 0;
+    v->arch.ttbcr =3D 0;
+
+    v->arch.csselr =3D 0;
+    v->arch.cpacr =3D 0;
+    v->arch.contextidr =3D 0;
+    v->arch.tpidr_el0 =3D 0;
+    v->arch.tpidrro_el0 =3D 0;
+    v->arch.tpidr_el1 =3D 0;
+    v->arch.vbar =3D 0;
+    v->arch.dacr =3D 0;
+    v->arch.par =3D 0;
+#if defined(CONFIG_ARM_32)
+    v->arch.mair0 =3D 0;
+    v->arch.mair1 =3D 0;
+    v->arch.amair0 =3D 0;
+    v->arch.amair1 =3D 0;
+#else
+    v->arch.mair =3D 0;
+    v->arch.amair =3D 0;
+#endif
+    /* Fault Status */
+#if defined(CONFIG_ARM_32)
+    v->arch.dfar =3D 0;
+    v->arch.ifar =3D 0;
+    v->arch.dfsr =3D 0;
+#elif defined(CONFIG_ARM_64)
+    v->arch.far =3D 0;
+    v->arch.esr =3D 0;
+#endif
+
+    v->arch.ifsr  =3D 0;
+    v->arch.afsr0 =3D 0;
+    v->arch.afsr1 =3D 0;
+
+#ifdef CONFIG_ARM_32
+    v->arch.joscr =3D 0;
+    v->arch.jmcr =3D 0;
+#endif
+
+    if ( is_32bit_domain(v->domain) && cpu_has_thumbee )
+    {
+        v->arch.teecr =3D 0;
+        v->arch.teehbr =3D 0;
+    }
+}
+
+
+static void vcpu_suspend(register_t epoint, register_t cid)
+{
+    struct vcpu *v =3D current;
+
+    v->arch.suspend_ep =3D epoint;
+    v->arch.suspend_cid =3D cid;
+    set_bit(_VPF_suspended, &v->pause_flags);
+    return;
+}
+
+/*
+ * This function sets the context of current VCPU to the state which is ex=
pected
+ * by the guest on resume. The expected VCPU state is:
+ * 1) pc to contain resume entry point (1st argument of PSCI SYSTEM_SUSPEN=
D)
+ * 2) r0/x0 to contain context ID (2nd argument of PSCI SYSTEM_SUSPEND)
+ * 3) All other general purpose and system registers should have reset val=
ues
+ */
+void vcpu_resume(struct vcpu *v)
+{
+
+    struct vcpu_guest_context ctxt;
+
+    /* Make sure that VCPU guest regs are zeroed */
+    memset(&ctxt, 0, sizeof(ctxt));
+
+    /* Set non-zero values to the registers prior to copying */
+    ctxt.user_regs.pc64 =3D (u64)v->arch.suspend_ep;
+
+    if ( is_32bit_domain(v->domain) )
+    {
+        ctxt.user_regs.r0_usr =3D v->arch.suspend_cid;
+        ctxt.user_regs.cpsr =3D PSR_GUEST32_INIT;
+
+        /* Thumb set is allowed only for 32-bit domain */
+        if ( v->arch.suspend_ep & 1 )
+        {
+            ctxt.user_regs.cpsr |=3D PSR_THUMB;
+            ctxt.user_regs.pc64 &=3D ~(u64)1;
+        }
+    }
+#ifdef CONFIG_ARM_64
+    else
+    {
+        ctxt.user_regs.x0 =3D v->arch.suspend_cid;
+        ctxt.user_regs.cpsr =3D PSR_GUEST64_INIT;
+    }
+#endif
+    ctxt.sctlr =3D SCTLR_GUEST_INIT;
+    ctxt.flags =3D VGCF_online;
+
+    /* Reset architecture specific registers */
+    vcpu_arch_reset(v);
+
+    /* Initialize VCPU registers */
+    arch_set_info_guest(v, &ctxt);
+    clear_bit(_VPF_suspended, &v->pause_flags);
+}
+
+int32_t domain_suspend(register_t epoint, register_t cid)
+{
+    struct vcpu *v;
+    struct domain *d =3D current->domain;
+    bool is_thumb =3D epoint & 1;
+
+    dprintk(XENLOG_DEBUG,
+            "Dom%d suspend: epoint=3D0x%"PRIregister", cid=3D0x%"PRIregist=
er"\n",
+            d->domain_id, epoint, cid);
+
+    /* THUMB set is not allowed with 64-bit domain */
+    if ( is_64bit_domain(d) && is_thumb )
+        return PSCI_INVALID_ADDRESS;
+
+    /* Ensure that all CPUs other than the calling one are offline */
+    for_each_vcpu ( d, v )
+    {
+        if ( v !=3D current && is_vcpu_online(v) )
+            return PSCI_DENIED;
+    }
+
+    //TODO: add support for suspending from any VCPU
+    if (current->vcpu_id !=3D 0)
+        return PSCI_DENIED;
+
+    /*
+     * Prepare the calling VCPU for suspend (reset its context, save entry=
 point
+     * into pc and context ID into r0/x0 as specified by PSCI SYSTEM_SUSPE=
ND)
+     */
+    vcpu_suspend(epoint, cid);
+
+    /*
+     * The calling domain is suspended by blocking its last running VCPU. =
If an
+     * event is pending the domain will resume right away (VCPU will not b=
lock,
+     * but when scheduled in it will resume from the given entry point).
+     */
+    vcpu_block_unless_event_pending(current);
+
+    return PSCI_SUCCESS;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
index c1e250be59..f4e6e92873 100644
--- a/xen/arch/arm/vpsci.c
+++ b/xen/arch/arm/vpsci.c
@@ -18,6 +18,7 @@
 #include <asm/vgic.h>
 #include <asm/vpsci.h>
 #include <asm/event.h>
+#include <asm/suspend.h>
=20
 #include <public/sched.h>
=20
@@ -208,6 +209,11 @@ static void do_psci_0_2_system_reset(void)
     domain_shutdown(d,SHUTDOWN_reboot);
 }
=20
+static int32_t do_psci_1_0_system_suspend(register_t epoint, register_t ci=
d)
+{
+    return domain_suspend(epoint, cid);
+}
+
 static int32_t do_psci_1_0_features(uint32_t psci_func_id)
 {
     /* /!\ Ordered by function ID and not name */
@@ -225,6 +231,8 @@ static int32_t do_psci_1_0_features(uint32_t psci_func_=
id)
     case PSCI_0_2_FN32_SYSTEM_OFF:
     case PSCI_0_2_FN32_SYSTEM_RESET:
     case PSCI_1_0_FN32_PSCI_FEATURES:
+    case PSCI_1_0_FN32_SYSTEM_SUSPEND:
+    case PSCI_1_0_FN64_SYSTEM_SUSPEND:
     case ARM_SMCCC_VERSION_FID:
         return 0;
     default:
@@ -355,6 +363,26 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uin=
t32_t fid)
         return true;
     }
=20
+    case PSCI_1_0_FN32_SYSTEM_SUSPEND:
+    case PSCI_1_0_FN64_SYSTEM_SUSPEND:
+    {
+        register_t epoint =3D PSCI_ARG(regs,1);
+        register_t cid =3D PSCI_ARG(regs,2);
+        register_t ret;
+
+        perfc_incr(vpsci_system_suspend);
+        /* Set the result to PSCI_SUCCESS if the call fails.
+         * Otherwise preserve the context_id in x0. For now=20
+         * we don't support the case where the system is suspended
+         * to a shallower level and PSCI_SUCCESS is returned to the=20
+         * caller.
+         */
+        ret =3D do_psci_1_0_system_suspend(epoint, cid);
+        if ( ret !=3D PSCI_SUCCESS )
+            PSCI_SET_RESULT(regs, ret);
+        return true;
+    }
+
     default:
         return false;
     }
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..4e1ea62c44 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -38,6 +38,10 @@
 #include <xsm/xsm.h>
 #include <xen/err.h>
=20
+#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
+#include <asm/suspend.h>
+#endif
+
 #include "private.h"
=20
 #ifdef CONFIG_XEN_GUEST
@@ -957,6 +961,10 @@ void vcpu_unblock(struct vcpu *v)
 {
     if ( !test_and_clear_bit(_VPF_blocked, &v->pause_flags) )
         return;
+#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
+    if ( test_bit(_VPF_suspended, &v->pause_flags) )
+        vcpu_resume(v);
+#endif
=20
     /* Polling period ends when a VCPU is unblocked. */
     if ( unlikely(v->poll_evtchn !=3D 0) )
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 413e5a2a18..715841e0b5 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -203,6 +203,9 @@ struct arch_vcpu
     struct vtimer virt_timer;
     bool   vtimer_initialized;
=20
+    register_t suspend_ep;
+    register_t suspend_cid;
+
     /*
      * The full P2M may require some cleaning (e.g when emulation
      * set/way). As the action can take a long time, it requires
diff --git a/xen/include/asm-arm/perfc_defn.h b/xen/include/asm-arm/perfc_d=
efn.h
index 31f071222b..d71e91a5e4 100644
--- a/xen/include/asm-arm/perfc_defn.h
+++ b/xen/include/asm-arm/perfc_defn.h
@@ -33,6 +33,7 @@ PERFCOUNTER(vpsci_system_reset,        "vpsci: system_res=
et")
 PERFCOUNTER(vpsci_cpu_suspend,         "vpsci: cpu_suspend")
 PERFCOUNTER(vpsci_cpu_affinity_info,   "vpsci: cpu_affinity_info")
 PERFCOUNTER(vpsci_features,            "vpsci: features")
+PERFCOUNTER(vpsci_system_suspend,      "vpsci: system_suspend")
=20
 PERFCOUNTER(vcpu_kick,                 "vcpu: notify other vcpu")
=20
diff --git a/xen/include/asm-arm/psci.h b/xen/include/asm-arm/psci.h
index 832f77afff..26462d0c47 100644
--- a/xen/include/asm-arm/psci.h
+++ b/xen/include/asm-arm/psci.h
@@ -43,10 +43,12 @@ void call_psci_system_reset(void);
 #define PSCI_0_2_FN32_SYSTEM_OFF          PSCI_0_2_FN32(8)
 #define PSCI_0_2_FN32_SYSTEM_RESET        PSCI_0_2_FN32(9)
 #define PSCI_1_0_FN32_PSCI_FEATURES       PSCI_0_2_FN32(10)
+#define PSCI_1_0_FN32_SYSTEM_SUSPEND      PSCI_0_2_FN32(14)
=20
 #define PSCI_0_2_FN64_CPU_SUSPEND         PSCI_0_2_FN64(1)
 #define PSCI_0_2_FN64_CPU_ON              PSCI_0_2_FN64(3)
 #define PSCI_0_2_FN64_AFFINITY_INFO       PSCI_0_2_FN64(4)
+#define PSCI_1_0_FN64_SYSTEM_SUSPEND      PSCI_0_2_FN64(14)
=20
 /* PSCI v0.2 affinity level state returned by AFFINITY_INFO */
 #define PSCI_0_2_AFFINITY_LEVEL_ON      0
diff --git a/xen/include/asm-arm/suspend.h b/xen/include/asm-arm/suspend.h
new file mode 100644
index 0000000000..fbaa414f0c
--- /dev/null
+++ b/xen/include/asm-arm/suspend.h
@@ -0,0 +1,17 @@
+#ifndef __ASM_ARM_SUSPEND_H__
+#define __ASM_ARM_SUSPEND_H__
+
+int32_t domain_suspend(register_t epoint, register_t cid);
+void vcpu_resume(struct vcpu *v);
+
+#endif
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 3b4ed3a2ab..b2f6d1af28 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -903,6 +903,9 @@ static inline struct domain *next_domain_in_cpupool(
 /* VCPU is parked. */
 #define _VPF_parked          8
 #define VPF_parked           (1UL<<_VPF_parked)
+/* VCPU is suspended */
+#define _VPF_suspended       9
+#define VPF_suspended        (1UL<<_VPF_suspended)
=20
 static inline bool vcpu_runnable(const struct vcpu *v)
 {
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417679.662374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf6-0004i9-8y; Fri, 07 Oct 2022 10:33:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417679.662374; Fri, 07 Oct 2022 10:33:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkf6-0004hF-26; Fri, 07 Oct 2022 10:33:00 +0000
Received: by outflank-mailman (input) for mailman id 417679;
 Fri, 07 Oct 2022 10:32:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf4-0004P4-H8
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:32:58 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 67b15eea-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:32:56 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978PmIP009910;
 Fri, 7 Oct 2022 10:32:52 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb3gbn-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:52 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:46 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67b15eea-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nji8sgQVDFoYdVS7D59XeJzOXytmaboxA/AQC//E6hJVYChU9wDrdLlze0lWmqvgf0M5WvnrGCK7qNMokKM2GIoS68sK6eCpHmcIVupOtLMCV1IsoiVt5pjJ/OmtirjQJL2lHKQLhQKzIvSm0spMG++SmkayWBLMNbNRAIjHoYVCgpO7ey2pkYb38zK/W7Zz27RNPmlqn6d6VUGFXhACG8qDqpwbbGGrPqHk8/uyrWDw+Nl/LCF5FnLSvvjacDztZQ0fQCGAdntGielk9s10DgZPZwtQl7meS+ctR4LJ6VlnXkhyha3uwvgiDPEVT94puN2DQCUpxHBgS4f7xPVVQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lWGWtk0pmfF7m0kgIArpsZXfKqkLRBi7vbupwpett5o=;
 b=UMEnI9afaOOtRp1+bBHZjTRI9RQj4BHTaMJff15HlINQwhrdQa7GQ1MhQaTmjcpxx6KOvul5aCH0u8PJmbD6rQMvQ2DWv5Ak+jf1Wvb26OfuEqgFLzbwujXeRBskJZnrHs9yPd5bMv7lPCexqWuTEn9iSS7qpYMh6avQweW7s12ijgkAdG+KbcUtshpS/dMhxRKqvrGUJMuEN90rK0tQWDjzN+UHNXAMsRl2TcxgwR+LL6mpObazAzywsFBeYCtttalDFginrqnwT8l43ZYdnkTSTq2Bpa07ugxyF/IbmDO0bdWPRUUcmFkAiyuDgZgWIQx8MsdC2tIOVFgVBfirCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lWGWtk0pmfF7m0kgIArpsZXfKqkLRBi7vbupwpett5o=;
 b=FEoEpqRXxBw7u8E/YC8ZK1oZ3E8Ir6OZFruTjrDsioOQs3Y+bpZJ0qsoOJQ7zlzBoPhzYmE2gD73tklIMPq0rwtZIVctV+OnMih6AqOEUGHewi/GM/+60VPDPW7DoGPXzZURQ/ykOhJZAvlusyOJmbzqQN8KxwfyrEcIs/7zLVPcdAbhsIMQPkgdaJ2tRgc9ojRLsYbJEnroRHwY6hhvM11RmL+eMV6g/Ftvew8w1tBaQG3Ba92J4ccZgnYPPycpZ8yJsE89p0rJTG1snTn9jmvggBaEldhFhC23vOg8CcHXPuAF31YUzLqIzXocczTDWF4IpJROPhdLSnguwZnAMQ==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta Poturai
	<Mykyta_Poturai@epam.com>
Subject: [PATCH 04/19] xen/arm: Trigger Xen suspend when Dom0 completes
 suspend
Thread-Topic: [PATCH 04/19] xen/arm: Trigger Xen suspend when Dom0 completes
 suspend
Thread-Index: AQHY2jgjmweWbQ547U+QMSraGkbOEg==
Date: Fri, 7 Oct 2022 10:32:46 +0000
Message-ID: 
 <91765b9f8442b51898ed38cb6964017322599110.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: 5130066e-054a-45eb-1a27-08daa84f467e
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 CJz+VB8mBUMPxYwezfGwMP8ce/A0uUr1UBhWmf3bQoU5OqaLGMMDXhLgh584GU3Tyo/7Z1oQQBKvYtU67vl6UPOwO8j5/tdJT1pSQ52bTXzfD4paGWuU/oG9c5/DA5ORm9bmi3n7L+63ULwnaA1kQ/uApLVKXPKJVrJEVfqTsi57isSUeTVr+rsh+qy/NGxZlCW3BW62g/x8z6ZKlXndgPiHpIG8RztRmAMgnqEZCVwmJXJMBV60onOWbmDzFcSlpPn51WpMUS9d6gNX0BFtyiHFZl7tK8Fc/6+o/c8z+u0iLIHgPPAkG42MJE4Pi7jtgZudLSBm2tD5gK70iiEA6hkPb/MPv6za9S82N2q4tq3D60nonOMcFLLXK6AgL6PztcLF9oRj6M4sNUAz0x/DjZ3y4mursWJ9lY40pn6vStO/V0AKOg+/KpvrBXUEUKOcT4WpMss5sLes5l563gtaVT93OaFezpb4TJhoQyUxwP8pf2KKQvUwdTUuT78iE6x0UgaVhRCPF3m9/slNdE1IBn8sAIm9EBQXSge7CD7kMcaiQqiXsIDXaRZTsH85pKg6C/dovdM/MgEWqkKklmZb8X3Ns0a1GTwB4qloCCS9OGZWTiVx1potgWyFqJhF2Uuhpl54KJPuUwi4g1oGNzp5RtZgVDskpHxtdRmr18dYFv2YmwNGGbZQ7athNsWD50fnyE93C9lRk114Mf1rhpBg+2vcw6DD2uMWP7N9AauTvBqWgu5NjimG/CQHbXU67rXbnDx08CQUSCnuWJp2HGRg2Q==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(15650500001)(5660300002)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(107886003)(38070700005)(122000001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?tFFzMaRT5sSFXTWOw9kb/1JB7pUls6eQLxU1PoAPIC5kSWaUZjiSgtsQ7y?=
 =?iso-8859-1?Q?ZaLf3TBgtO8S/yPwiElXuHhhab1QElQnUYvn7tIm25Rw+9AWyuQEMoipfS?=
 =?iso-8859-1?Q?Qz8Hk6tUtguiRTIPOeKxrOOao8HUQxJJm7k0kIvv5XsdJCtMxTJGSmyGFE?=
 =?iso-8859-1?Q?Yi60bTulu+BYlGztWJ3Zg9Pau/Smqp2d7k14HS5RVzREU5hmvi87F3lysM?=
 =?iso-8859-1?Q?D3mqOVGqNFBT5sRyNM5IIvJtw8uGFlkfFBysi71C9cWGYj6n/biY22rX1D?=
 =?iso-8859-1?Q?OqDSL8JHbWdqX1byspzrS8Wke7UFo66kTVxr2KJHbC9HqFyye/O3MMm1pM?=
 =?iso-8859-1?Q?oY/SrLG9e/SnowSyApo10rm9Y4OAPfF0121bfOGbjpvkLQ3qzC4USTJg+E?=
 =?iso-8859-1?Q?O6vQinJr6rppMqu5wVUiETKqjaGlO62/mKGRT7UZztMuSwgI8geTtdVP0j?=
 =?iso-8859-1?Q?MKhvaR8psOf0tTC/m3CCP0srt4a7fUQltfOYcd6whVfDcGRnPBNbgsqK+u?=
 =?iso-8859-1?Q?qeAkfuEJBwQAcC96V6Nda8uEHmS6MpIrHEM3g4TQkvXyWMgBf82Bqf0R56?=
 =?iso-8859-1?Q?phnfbZatzSJa5UjKlbmjcdm5TvriexMOZ+L/UVo+dWpgK+R1ZRTDkWuHKu?=
 =?iso-8859-1?Q?8jJgJ1NqhdttEeNkz6G9zYHmfbu8d41d6k5bqm9iA532ychmrK5ezuusSM?=
 =?iso-8859-1?Q?enm1uhJYP6tieRuuNzU+iO+e5NnbnEM9KJLxv2Rkuy6gBYi2pDdiJfANV+?=
 =?iso-8859-1?Q?JOxusLa5DqtJAOe+Q3m5yPcGFAVgjzYP2VrmTROPWv4ynr8XpU39ZW/TMR?=
 =?iso-8859-1?Q?LaSDkYWPNfa1/o0cagueDWAKO7iGlSZA/D+/oTedy+SwMWeDbCpFg621gX?=
 =?iso-8859-1?Q?B13yHL11Slw9AzJ+NVrWUyg/Xi58+dj1roitj7vhc0SofU4sF8BYpBtbtD?=
 =?iso-8859-1?Q?ZHa+wnnM+qdwQQMjDVlLEqK8rCP5AuuKyUtv5yzfZ4StkAcKLz2RfP5p67?=
 =?iso-8859-1?Q?Bq1k/acR61Y9iu+p0zno0xdCygcL0avf/B4e9+E0HOEGzxrhpdKwGEIkOX?=
 =?iso-8859-1?Q?rqXgmt3XiWHHd5yxIDIW7ekXpV/H9bCi22VLSrYMKEUsRrs1qCIsXtNZVZ?=
 =?iso-8859-1?Q?JRJ2+q2AmPmhGS5Rcia/qH/g6rGKQQj8Hvv9Ro72ilyHz6URV2oSKy6L7K?=
 =?iso-8859-1?Q?c+UcLP0UqnPLLPq410o/unUIfDiGBC77XqQCFvqKv6fe94Zf8UvsbK3/l2?=
 =?iso-8859-1?Q?vImMSdKl/usdhcc5jNOzeiUDhaQCdZyQWPcn++ry7TA82411XfdZMHzCfT?=
 =?iso-8859-1?Q?7Z5z2YVT6H48TLg1n5NbE1CsvdQLQqR3bkzTdq3zfPmn2VPah9TcQETLtD?=
 =?iso-8859-1?Q?dZgQFtrsmfRj6sslbhWFAnYotAdrghUe594CI8duNFLx74Pw1jJIK5oXJx?=
 =?iso-8859-1?Q?eLSJsSWGuWIXW/gubd+cYYUrUyFj6EudxFzWJprHdZcbjI2oY5mK8Hzp/E?=
 =?iso-8859-1?Q?65xqaHYXO1SGAdrLs9J3THO+O8RnLA5cQ9Q3aPmRwFA634kjxQxVdWv0YH?=
 =?iso-8859-1?Q?/VmyD4l9KxVptNHll+Hzp5bVSuicMyF3/WWPPDbrROP+gbfmr06GGo2NSZ?=
 =?iso-8859-1?Q?fD846Nst4VxTPCStthfMZMtp/Y6RMUh8Ua0YkipdTv/HcO9PEYILWwVA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5130066e-054a-45eb-1a27-08daa84f467e
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:46.0836
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A/R+JJWo/dNw+uXTE0DN7YxyYXuXo2qnIhlnCUgzQDt94NYWwRVhBRindbFWzIqgjgscpcI+ceLFYnDI6MAqVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-ORIG-GUID: FqDNsun8YiYvn6SP3Jw4LnqLHTHLy0XY
X-Proofpoint-GUID: FqDNsun8YiYvn6SP3Jw4LnqLHTHLy0XY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1015 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=979 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

When Dom0 finalizes its suspend procedure the suspend of Xen is
triggered by calling system_suspend(). Dom0 finalizes the suspend from
its boot core (VCPU#0), which could be mapped to any physical CPU,
i.e. the system_suspend() function could be executed by any physical
CPU. Since Xen suspend procedure has to be run by the boot CPU
(non-boot CPUs will be disabled at some point in suspend procedure),
system_suspend() execution has to continue on CPU#0.

Though it is not clearly stated that the PSCI suspend call should be
issued from cpu0, we assume that it is to simplify the process. This
assumption is based on a fact that most platforms call some form of
disable_nonboot_cpus routine before issuing the PSCI suspend call.

When the system_suspend() returns 0, it means that the system was
suspended and it is coming out of the resume procedure. Regardless
of the system_suspend() return value, after this function returns
Xen is fully functional, and its state, including all devices and data
structures, matches the state prior to calling system_suspend().
The status is returned by system_suspend() for debugging/logging
purposes and function prototype compatibility.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/arch/arm/suspend.c | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index d19545744f..b09bf319d0 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -132,11 +132,20 @@ void vcpu_resume(struct vcpu *v)
     clear_bit(_VPF_suspended, &v->pause_flags);
 }
=20
+/* Xen suspend. Note: data is not used (suspend is the suspend to RAM) */
+static long system_suspend(void *data)
+{
+    BUG_ON(system_state !=3D SYS_STATE_active);
+
+    return -ENOSYS;
+}
+
 int32_t domain_suspend(register_t epoint, register_t cid)
 {
     struct vcpu *v;
     struct domain *d =3D current->domain;
     bool is_thumb =3D epoint & 1;
+    int status;
=20
     dprintk(XENLOG_DEBUG,
             "Dom%d suspend: epoint=3D0x%"PRIregister", cid=3D0x%"PRIregist=
er"\n",
@@ -173,6 +182,31 @@ int32_t domain_suspend(register_t epoint, register_t c=
id)
      */
     vcpu_block_unless_event_pending(current);
=20
+    /* If this was dom0 the whole system should suspend: trigger Xen suspe=
nd */
+    if ( is_hardware_domain(d) )
+    {
+        /*
+         * system_suspend should be called when Dom0 finalizes the suspend
+         * procedure from its boot core (VCPU#0). However, Dom0's VCPU#0 c=
ould
+         * be mapped to any PCPU (this function could be executed by any P=
CPU).
+         * The suspend procedure has to be finalized by the PCPU#0 (non-bo=
ot
+         * PCPUs will be disabled during the suspend).
+         */
+        status =3D continue_hypercall_on_cpu(0, system_suspend, NULL);
+        /*
+         * If an error happened, there is nothing that needs to be done he=
re
+         * because the system_suspend always returns in fully functional s=
tate
+         * no matter what the outcome of suspend procedure is. If the syst=
em
+         * suspended successfully the function will return 0 after the res=
ume.
+         * Otherwise, if an error is returned it means Xen did not suspend=
ed,
+         * but it is still in the same state as if the system_suspend was =
never
+         * called. We dump a debug message in case of an error for debuggi=
ng/
+         * logging purpose.
+         */
+        if ( status )
+            dprintk(XENLOG_ERR, "Failed to suspend, errno=3D%d\n", status)=
;
+    }
+
     return PSCI_SUCCESS;
 }
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417685.662427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfB-0005tu-GU; Fri, 07 Oct 2022 10:33:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417685.662427; Fri, 07 Oct 2022 10:33:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfA-0005pI-Uf; Fri, 07 Oct 2022 10:33:04 +0000
Received: by outflank-mailman (input) for mailman id 417685;
 Fri, 07 Oct 2022 10:33:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf7-0004PE-Aw
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:01 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 684366d5-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:32:57 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978P176005817;
 Fri, 7 Oct 2022 10:32:54 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjk3-7
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:54 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 10:32:48 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 684366d5-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GFdeaqti3itEfcRNOl6e2Xxcxqwn8DhavTcQNLU9ztKarmPjEg1Yk9mGfwjPN7/Zi5Ft3MvizZuQH2f5Kq+F/P30yUQz39Yftr53LoMVPnkE4toYmctHqdM8y2uX2A/WuWHnGS3COD/K4pjuZ1YL8J1kDGVW1k+H+Uyt2QFc7y+eCN91Nko7h+YzOvk8BEV0DbORoJ2tqd2M7j9eaeP8d5NwDG0EqFovC5+XW8S0fqdI3Gr9gWAak8u8vjSeEpuD2j9jI+Hpr6VdQMmrt7HGnuhoqwiAxFdiJYFDGL5zCoABSlkU0ZDWQM0aUaAfDxNUhs8xIdvBpQfH8EFx8XA7sw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OuYmDBIoJgpH/JRiy2BHsIcRVjjzqDnzn/1O+5H48U0=;
 b=OSNDEGUQVPz1HG4nEXlGTSRs3xXX4fvL50TcYrBNTprUjNpt31kf0xP9E6yS5TIQzkWu/KMyiYF5HogrE42AViDmsRXGfaOf93i9c3AS9cAe4ZJeJDsC7r//Y9QemIpccrqBqBo4TTf8pdRmUFJgPn3fB4+uwx7Z5jjM5/MF3CBiM+uiocWilko76DGJGd10wvComcO3uO5k0yWt4hU8ixrFTmm6jffDoGRlMg2Ajvh+9TB2+j6QLqNDEfxzvFUXOS0aFP47/EF8me/eoQ9Jzdp9rsS6Qa8ufZHIwFhzahCUDNnDQkSodo2exuLefRSiWVeKGljxjCsDlTMYSC96Xg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OuYmDBIoJgpH/JRiy2BHsIcRVjjzqDnzn/1O+5H48U0=;
 b=WTFmHyrGr5jgTmtRS6mjUXIULunnRKZjUGweKfGlodGakkHMXwUXbDq8JT0hFdL9oUw/wnbNWz9pxiBsYOJeURjkeZxtlDp1oMQKbCt1UmvcfLxiBGRx5y/W0MBXiaHojwTAgeJQsoIExw28KwVHv5GmzihU3P0IU6WQoOX+EX6lvARYIsBd8Hnk3N9ka05YtGat9lTUv3QbXM4qXmDRFVz/G2Syf0Z1f9IEINUt+IukgKHX+bkQERuHVSRq0RNgDreBsH/zu6uxWy/TynH6fbqBhE+UB3SCieyPL+3r03WjhcDDSP9cK/qecwJs6iOnwUMhBJdR4GY/eQcHh6Vqlg==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 08/19] xen/arm: Add rcu_barrier() before enabling non-boot
 CPUs on resume
Thread-Topic: [PATCH 08/19] xen/arm: Add rcu_barrier() before enabling
 non-boot CPUs on resume
Thread-Index: AQHY2jglpD72HLvPXkazM/pUUGVcBQ==
Date: Fri, 7 Oct 2022 10:32:48 +0000
Message-ID: 
 <a90d2b9a33dbdc90f2548757bdd4173e1d711d36.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS8PR03MB7159:EE_
x-ms-office365-filtering-correlation-id: 4b355dce-514c-43b2-9f36-08daa84f47ef
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 2brLCYMPIDM6H7Si2jQH3EDNS7xRZ4iyWDElak0CIcJ0K+yaOzb7Tbfi0gLdkWfNf7czbaMmnUoSYOVLDYa/Ul66GDyfd8QCnSidUTDsjTx6EDxbCP5ZO6K3VFMQei17LcyG6ybi7Vqjptz/xYVslX9R0L11DQMP58+XD35TzAKXG1Cw30uGzIqPJ+EG3bvdqRSlkE1qlnP9GYmkizPEczhFMkNCGvztS6H1sGHalIOz7FXEjRK+Ce1wk4luiz3qbM5LHoyrYc5Nf8Q2sF5qtgdX+kA1zU5ILtoAATZiUaOEkCWUFJnPd/wF3TDalX2SQeiYTDB/KGz4orw9I9b1qtcrJDAkazM1M3+yz7gSsL5DF591vra6wkye7JfLJGA5z0vY9sRZ2HnGjQrgWuDDlX3b4ALJHUvHOVlyXItfmZO+bu6PTt5QziGyNSb2HZgY+ZlDci9ytmkqI9w1Qcx7xUbbB9D+8NFfKwXaYXkHLjmF1KtZvX0c97XU0Iq1DemHgIqa9uxoh5i0eU2f1A2q47rY3kTkdoK/7Ys/eD9ERe0sTg3GVD6+UCz6Mh/azHY9OYANjO2Nzy4BcoCuMuZW2QG5Gn9uX/MqisoscHIgjn4q6ESkjIEWwB6mZLVFPBkFglxN2G62nHwRfPDUazcxdZCDyGxbjrDTzewleFRIf5Q+P0K79uxJ/0GXhIrwuEH46x78lukgDYbw2UvFaGt7uN/8hE8p1WPIPtPbQ8MQmszilBSJsxfL8yEZNGvZE9SymdncllD8XHmVVTfz+7sKag==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199015)(2616005)(186003)(83380400001)(316002)(6916009)(2906002)(54906003)(86362001)(5660300002)(4744005)(8936002)(66446008)(41300700001)(66946007)(64756008)(76116006)(66556008)(91956017)(66476007)(8676002)(4326008)(71200400001)(478600001)(6486002)(6512007)(55236004)(6506007)(26005)(38100700002)(38070700005)(122000001)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?9G2X4luU5HNC1vdw42kR9wYXYmQ8w9PjgRRE0vFfCycjkqNAKWtp7o0VXr?=
 =?iso-8859-1?Q?GKgTM7FVpZykEz3pkswk21mQkqgMUEsoiR1IJxnnagbfRDEbFpd1Izdhwk?=
 =?iso-8859-1?Q?djYspja46AEu24mZxrp/wbmg2bYwczQMhECTrF1VgfDD3+l6W1MdcH/p/o?=
 =?iso-8859-1?Q?PIkdjsCqWR0zmWJ5xGYuTVMmNHuCV7/6UR+udZNG5bLwNY58LBUKvkoazo?=
 =?iso-8859-1?Q?zPcf2poqTgsre+Y4XZe0Ke858DqvtinXDkrov7aEIpybsoq9IcPWVKi4rB?=
 =?iso-8859-1?Q?Hv5J131+nXkc5SF4AodAx2uGuPrPgIqqCaL/3+aNvU2oPhETlGzbKvm9gZ?=
 =?iso-8859-1?Q?4PiSrUm8vyDQlkUQUkRrkN3vh0VeSYqit5Z4w/wPaicHPLif/wDPLEMupF?=
 =?iso-8859-1?Q?JzQZwObP6sDrfVqHwp3gbbMU5gFBZVN6X221U7rLPg8RORoQEJfd/PEU+P?=
 =?iso-8859-1?Q?2WaO+AaJ4WRgxGtaIV4XuJ5VhoYwsP3xQk524K8/fE2rvnnjO0vquuCIN9?=
 =?iso-8859-1?Q?3BUpjWUA60fy2y75stAjfhbCnex9FARbEp27PJCEZT66QZzqlMUoi9X4/W?=
 =?iso-8859-1?Q?09Rre7BMZQgPXOPgaYO00HqpdjSg8cbvf1PtjxPkLUxoQE8N7OyKaWrkCD?=
 =?iso-8859-1?Q?V7bQxVuVz8CY9UTBnNnOuN3PCJ8/2ye9P5U3tr2zXax9q8NYKTok5K1IO/?=
 =?iso-8859-1?Q?4OAxQtM72K3BsX0wFKqLxR4ElO+//Akvzj/5crfc0TDcaK7NuXEl2znOXw?=
 =?iso-8859-1?Q?vksZRi9CYpocAirpRhJeVIZZaq5FThD4PxNNUfJbOFHm5FiG00M70opyUw?=
 =?iso-8859-1?Q?JUI469ZgOJjH1s2H+4PLYh8GO3Jdncys/qs1PI3IgANGgsrmiP0j84QK5z?=
 =?iso-8859-1?Q?ahBZJA3LwFzgxQMj2aETaPlPOaM2EEc+WCS3HCpJViMFLZ9WiAMfMFNZlh?=
 =?iso-8859-1?Q?XICvbmAywfrQCpVbOdjj9aU0J3hOpsQgtggwbONKA8qJdP672YLo0PrWu+?=
 =?iso-8859-1?Q?fEJ3XOPTN1icfQNaMb4KHWgqAH7Xv0o74btBgmWD6bPWF3cvStFApTFiSg?=
 =?iso-8859-1?Q?f8ngrEnRAFn5nc6l+cwlsRai8pRMO2zizx0JD0ulEbelOv9DNG9pTkuUPI?=
 =?iso-8859-1?Q?DFGIXk8PRwWrSGf4bBhgcpVViYGnDNzatwZL9pTa3UgrKxdvtO8DzGVYhc?=
 =?iso-8859-1?Q?liGnuQ/Noz+8Rm5M0rpcj8wfk2i375QV8igV9HQ79bJ20bmK65pfrdU3LG?=
 =?iso-8859-1?Q?EhrOCPWVhOuPp13gYjuvOg6CXDCldsthsp10JTTyFU6jEUNhEuEICNVBfr?=
 =?iso-8859-1?Q?t1t9Eo6/nKxQNn2MfjQrns+mowbaFZ8D/BbZeROL1BknA2qzaO6VMAqHwe?=
 =?iso-8859-1?Q?VyJPRT/9Y8DM5C9O43Xmnx55OIxws5DhXdBe10LxYK2CxAy6XMg/Mwa2hr?=
 =?iso-8859-1?Q?PWpyoPAGCyPtYY2EArONXurJaGOBU+lYpRSgOaAfrAnsOrFBedZDG6I64j?=
 =?iso-8859-1?Q?6BArjhs8oIzdqxR+ORlTGTrpgG/MPva3vqfTYNVc/4olM9jNkKykKjDWn0?=
 =?iso-8859-1?Q?okZv3Kal2ejGZSE4tqYQ1z38hOFcb9BSBDFcv4gfeFEx9oCc4eJnrMIv3U?=
 =?iso-8859-1?Q?J1bNdyT1vyjWtkhVHnzKgkyBuSAv5bn9e9FLRP0LRlox64F78eZhn1BQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b355dce-514c-43b2-9f36-08daa84f47ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:48.6303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Iey6AEfOmgqXlHWoceGEilvvTS8LrkfRjqR45aCkJZPpuhZTwWAjyzjB/SbHI5bM95acf/aFS6xCkb3BIrTmcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159
X-Proofpoint-GUID: tUenzLSF9QuCFAX_e_2YfZi-e1nkPU4F
X-Proofpoint-ORIG-GUID: tUenzLSF9QuCFAX_e_2YfZi-e1nkPU4F
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=500 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

The rcu_barrier() has to be added to ensure that the per cpu area is
freed before a non-boot CPU tries to initialize it (_free_percpu_area()
has to be called before the init_percpu_area()). This scenario occurs
when non-boot CPUs are hot-unplugged on suspend and hotplugged on resume.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/suspend.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 0784979e4f..0c16cfc750 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -153,6 +153,7 @@ static long system_suspend(void *data)
     system_state =3D SYS_STATE_resume;
=20
 resume_nonboot_cpus:
+    rcu_barrier();
     enable_nonboot_cpus();
     thaw_domains();
     system_state =3D SYS_STATE_active;
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417686.662437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfC-00069e-Og; Fri, 07 Oct 2022 10:33:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417686.662437; Fri, 07 Oct 2022 10:33:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfC-00066s-3x; Fri, 07 Oct 2022 10:33:06 +0000
Received: by outflank-mailman (input) for mailman id 417686;
 Fri, 07 Oct 2022 10:33:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf7-0004P4-HA
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:01 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 68773500-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:32:57 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978PgUi009630;
 Fri, 7 Oct 2022 10:32:54 GMT
Received: from eur03-am7-obe.outbound.protection.outlook.com
 (mail-am7eur03lp2237.outbound.protection.outlook.com [104.47.51.237])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb3gbm-4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:54 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DU0PR03MB8622.eurprd03.prod.outlook.com (2603:10a6:10:3e9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Fri, 7 Oct
 2022 10:32:49 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68773500-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cyYO3xNfKXtQyyQ1hvtNWy40UigXKe4W15LmWYbkYoX8gpY7QYsSLB62+jBKBcmeagqizavkwv/egBUcywxL1ofB537iZ1n5+skS1K/YG0g5nbO0RMuH9eoppdrAeZPzEFka3nhvfsI/TylULeukMmcfcJOwsgJX0Jy7FtQ0crAm12Pd7cCJjQkUU06wO6ZqeEpSaAy1gq63avk6tQ5QR8T1i0Khb1WWKxR5iCujfqGT9iQ/mPF4ijmJZY8avPgswLrwZUwZ41xHShav/zMC9w+2jFyg6jIwM9bX5T6hXAXH2AV9Er1ivWlUbOQ186bgv68pgDm7TlaRASVNaX0wuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=y7tfKwxlMC2rm0Z//gUzhgGJuWbgTzwYs5gBCllkoFo=;
 b=DA0qZW1wyE6ceESPJhferFrl+e2K/cKcLyDZaDqR4iHUhgIV9UnMl/b7HOV4iUTMJkntDVPIYkypqFxcHBHfqdgNMqQbSfZCmBCPonvKGvVNo7hpjnvT0v7DGE411gDuDYAr8EhzjIZZhTJ296KlkZFE7qOc3D5M3Unbk+IC66ILKICAtmCpobj/7IsYkfT9hMpb0JCgCa/GNAFfbV8Id+Kq+K27NDesHsOGIlcs+ttijFACGRROckS8m/DjP+tryaI8n6ZlMA49hwfJ/nSWs8Te4mTitbCvhUANK7nkPtVQtBZ4vptFjhnSNoAqMl5JDE/Z6JkqSqybUDN8/7sv7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=y7tfKwxlMC2rm0Z//gUzhgGJuWbgTzwYs5gBCllkoFo=;
 b=ksGb5nIxIfuPBfV7pqMqUgDCSJow0lGvOgYRXJKl0J4WtB323jUHL380kEjvFd6iUij0rdDxKdQnzcLECgdjVdsJ5rCYscLHpnSLYfX9ORhmyQCja7Lz0j/Ui0tZa19mVElHXTW+pPbDGlRrI+LKb4wkxXw/w0KYVf+4nlrHvHpaba1oMLMiRye6C5RBAjNw4aK0eZHTfiTX/qTxpB8jzkIyT5/S/zF8EDMgzh8oKKeoC9HgnDPzEsSTn//7LQqRFD6AFLRlG/ofrC3kByZ7DWsMGGaWpkxMkfeoIC4xajf90f/IOexZ2H9xil4n3PK7yNLT00BgXLOfgvPMQ9M+Qw==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 10/19] xen/arm: Suspend/resume GIC on system suspend/resume
Thread-Topic: [PATCH 10/19] xen/arm: Suspend/resume GIC on system
 suspend/resume
Thread-Index: AQHY2jglc8rj8DiR5UCRaZVxNHMwnQ==
Date: Fri, 7 Oct 2022 10:32:49 +0000
Message-ID: 
 <99a4fc0ff6732482152389a0813769fcfbdb379c.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DU0PR03MB8622:EE_
x-ms-office365-filtering-correlation-id: 887a28b6-11c0-4962-e4cc-08daa84f4879
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 +NAtR5+B+4guNA03ippobsx1z4XaBR2BLEumnwCJCLmBwLYhMu57zz8er8n/pJKtkCEz34zuB/SVd/v7a2D92JRoUpEGNtKjFzYkDfVAecPnBtGr1ndbms9h6CzQvG1RnuB6CgioruXN2K1ey7e3hFWM6rL26nAH0RQryw+TsM0xurRRcfeR3hqPy95t/F2ok9Spinqm2FO8cL+6KrjUKS99SEWmRwJJepHW6JRJPw+n7wsykvURdjL6MbD9qLa4Ow8wbALt9PRWcgyuYH1ed+hX+Ah7puLzsl8ej6Nh/pqmX1CyKJZC0hRJP5TEXwTQxJ3HBA8Bgp4SHgmCdWlN0crkUwQ14vQXXJaBji9wGMwR0cEq2VW50Asgu5cw/s/zMBP45fl8WRxfRU1JUPi5RAl+Bj2LUe5WD3Jqm2bYYK+eaaV1zQkiT/h7mGlKt2ViaA5Km2wzMjSdJjV3vJVMBIz+gGuZ3FC3yJSZ5TVeOryLDeUqQSJveUr7NHh7NtaNJX6l06RYQoT21SVb4xoqvOziYkOYzx9pVawCzXIZhPab5p3Ub5015fjMNk7rk6wks/I8gI6WYqmnNlene26wETcjSnegzB/7pIDUECgNTzUCnBB3eWlcK72Xln99k482cQzT0RflGm1xWPhzo6qY3mvAX5+lwUuXhDCPzI0bfyJy8G2v8R54QT16NyelRI0tT8a3cfZPZMyaq4Y/MwSznIOWstV9toXuFL1xSwLPf3oB1j8S1ZzZ1h8hoDsnGCwE
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(36756003)(2616005)(6916009)(83380400001)(122000001)(38100700002)(86362001)(54906003)(8936002)(478600001)(8676002)(41300700001)(6486002)(66476007)(71200400001)(26005)(38070700005)(316002)(6506007)(186003)(55236004)(66946007)(76116006)(64756008)(91956017)(4326008)(5660300002)(2906002)(66446008)(66556008)(15650500001)(6512007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?MzDLeBRtzBph+JSKo1nYvOU28YE9Vk8UgxyX53A4AYwVp4QVB0sYCdVxEt?=
 =?iso-8859-1?Q?k11Mhm6kPCYbIHcfVgWdxYqipvu8aHV/YLYcK33iP0NgnrdDn1yiZtDeEI?=
 =?iso-8859-1?Q?FmejcyUNzc33Wu7/Va++UhCNYrbxK9eS4Mec6UbHWdTz9nadf+4ZkhoTV7?=
 =?iso-8859-1?Q?l3hi2Mv7W4A7/vlK8wHqqtmM16pE8Bb8iG3xsofJH7+MG0RleCzojz5fXj?=
 =?iso-8859-1?Q?mcz9sc/r5KRuFiF4775LICoeGeg57J1M8m1BtmMB+SrdSWYoClUrh7dBr+?=
 =?iso-8859-1?Q?IC7SgkZNTpiMe43WaE+8dqOEQNcJ+ulOkemBL92GwIy8XcCzX+E9lY/CHw?=
 =?iso-8859-1?Q?+r8dgqN7VPeEZaiw1Nh1R0Mns9+P4hqAwKOLZqvzmpEXgawIx+3eInTmRw?=
 =?iso-8859-1?Q?1EHLX+00mvUXHFwpP+wlCHlJF7nxZ9s55VxyKdfWf5NR2zFMpn2mO0fnvd?=
 =?iso-8859-1?Q?rfeuwzvYsl3BxBxKc33LfVhi632oKGY+HCzLcTNdDTABUsEakqp6LnxTN+?=
 =?iso-8859-1?Q?YNO6EmNl7u2AO85M2ewUbo8rpCIyQL/tWVOvgeuRQZ26c7IibJAGo65u9t?=
 =?iso-8859-1?Q?fjOp9rU+jjPPCu6ir5YuQqDKd12d2iXWjLILZqaDJ6zkWEkH9lGwD9FmVI?=
 =?iso-8859-1?Q?XNEmaqeGUA4nqIR4n3AgQ/Tl/yESeHqvL8iysbxRxnFQ6YGMi0CvJFV/IW?=
 =?iso-8859-1?Q?MxdteAbwTkt3Pb2QybcrtQrlRQnlUwdtqPLKu0oLc/f9WTSJDDcqnl45C/?=
 =?iso-8859-1?Q?c46ASHnMFtO+JubKBFpZ5DwcUJYcOG1YQa+BJEes/Az4W6coJrY/egkIpu?=
 =?iso-8859-1?Q?zwuupJkOizMpqHUqmv+FaTfl0TT9SDqrBQmvQ47hbsbZC2PmrzzdqN95hr?=
 =?iso-8859-1?Q?JvESQfboy+unPzwnazG39Xg4WiWBCmollR49lbCZBJw16t/P/59T/kDzoP?=
 =?iso-8859-1?Q?cY1AG+IGWyy3vtExXb3tZGBcewx/2tuP5xCHqB3m28uQz/FQcl7TPN2ozy?=
 =?iso-8859-1?Q?sb4To1Cnr06AXgTq1mxotRdHyJKGdYCn8O+NDB+ma+imfxJIdjjrJ1MjXy?=
 =?iso-8859-1?Q?1URujFl/p/Ubd8bHXx2E+akpQ7Jl/LHd4YkxJBY5lPQl3kTn3Xv+BxDhki?=
 =?iso-8859-1?Q?yD+CBXICFNfIdgTx1YAaJzocq566bBweI7ZgWMPbMuaDRxz5dOsSuieBcS?=
 =?iso-8859-1?Q?cx9u9bXB0DkRn4EEA7QIWqd78Nqit1lAG9Ya49++gip64g7dbpevfl5w32?=
 =?iso-8859-1?Q?RnGTiL1QG0H81FkEGIraePjOukeYslNmdDicjSWdBLiWkl5KyivVQtwG6O?=
 =?iso-8859-1?Q?CHZvDIMl8qDVdf/MApBgfvu5PxTKiz9lGaCvsp+gn+Xrvmgpf8jlFZyBp0?=
 =?iso-8859-1?Q?grlIndEP3O84gk6ixbcbfnR/B+iNezqokeYC9yWrSsg/4bQWjMkMrR8eRC?=
 =?iso-8859-1?Q?sJQwGiwIHHtwMP2HfaOW87pkBtZuTZvkZFbb+AAdQOp6duay3YZ+dxhSuv?=
 =?iso-8859-1?Q?tkl8fOfqi/PjxvVos7nnFS7ZTjj0t05ye9qqnVpb5Ezcc2Ty3B75ycXpu7?=
 =?iso-8859-1?Q?C0ynOa2o+ohB4e6M0/mHQGGt0z5LCxbV0qNrd+e8z3sdWjkBCzJ0J78VTI?=
 =?iso-8859-1?Q?RdBOR8LYfG9x3o4ZdTZjPvoOsovwv49otORApFthO77eWjl4JOuqTfYg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 887a28b6-11c0-4962-e4cc-08daa84f4879
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:49.1927
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ozOEr3IB+VtwHjTBHm2ka0QEAT4Tsdt9fEZWRWbC6fQoVNPXRHcm3PSMTejktIrqZFe2R1sjMeEVMiqW0trsvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8622
X-Proofpoint-ORIG-GUID: OhB0aGHc_-LlbuFSSUKSGYHWE7X_EaVE
X-Proofpoint-GUID: OhB0aGHc_-LlbuFSSUKSGYHWE7X_EaVE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1015 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=260 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

GIC state is saved on system suspend by calling gic_suspend
(this function does not change current state of the GIC but only
saves the values of configuration registers).
The state of GIC has to be restored by calling gic_resume, but only
if the gic_suspend has succeeded. If gic_suspend fails, we'll just
restore interrupts configuration and abort suspend.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/gic.c     |  4 +---
 xen/arch/arm/suspend.c | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index e9feb1fd3b..ef90664929 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -476,9 +476,7 @@ int gic_suspend(void)
     if ( !gic_hw_ops->suspend || !gic_hw_ops->resume )
         return -ENOSYS;
=20
-    gic_hw_ops->suspend();
-
-    return 0;
+    return gic_hw_ops->suspend();
 }
=20
 void gic_resume(void)
diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 0c16cfc750..b94a6df86d 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -137,6 +137,7 @@ void vcpu_resume(struct vcpu *v)
 static long system_suspend(void *data)
 {
     int status;
+    unsigned long flags;
=20
     BUG_ON(system_state !=3D SYS_STATE_active);
=20
@@ -150,8 +151,21 @@ static long system_suspend(void *data)
         goto resume_nonboot_cpus;
     }
=20
+    local_irq_save(flags);
+    status =3D gic_suspend();
+    if ( status )
+    {
+        system_state =3D SYS_STATE_resume;
+        goto resume_irqs;
+    }
+
     system_state =3D SYS_STATE_resume;
=20
+    gic_resume();
+
+resume_irqs:
+    local_irq_restore(flags);
+
 resume_nonboot_cpus:
     rcu_barrier();
     enable_nonboot_cpus();
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417687.662444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfD-0006PD-Ks; Fri, 07 Oct 2022 10:33:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417687.662444; Fri, 07 Oct 2022 10:33:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfD-0006LS-9C; Fri, 07 Oct 2022 10:33:07 +0000
Received: by outflank-mailman (input) for mailman id 417687;
 Fri, 07 Oct 2022 10:33:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf8-0004PE-BG
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:02 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68b94913-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:32:58 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2977q6QW027397;
 Fri, 7 Oct 2022 10:32:55 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyb-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:55 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:51 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68b94913-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NBzf5NC2lZI92DtwkCsZInhkjWY45tjbIfqEZ6I4vquP8pcO3rXf9cNS6YahHLjVWECTeO2n0Gg4tY8fQqoEa6M+Z0LmVJgizIBz+H3TYKwVzsNt6/BtFGXWR36DXdyM4FM2X4/NyGa9B7R30MCvQE+ImO8PrMHmPAuhxkU9mzigg7Olq+CAWq/D9Ogywo2rFrvKzDTT+rw7f+5K/wWmhpeaWn4MM40pbXHFR16wCDl9JTzeSkE2EJSWB/gqIPj3oL7/F8BZSGwOBzAub8nYKUpSshM5qzTdhqf7CLWbgnnRy5mYsGnIZzXAL7vp6z0Vha1PCAewulIjw3CMJuOPMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qxsl5gDF3/jSVy2BBSafg6Ww5MOd3+YkfDQ+9kQ0VuY=;
 b=XCNTFwrOA20JWVCexD6aEQgubr4JQ6Vq1N7SM9W9wR/LUNQmuX/pucmr9bFx9lgWjypoMHTVmm5uSBMLNAAdNtVnBgSTZW/iQHmiYf/6g3CbBeydNZzOVqbDSV6SDfzuQA7Mc1CZuFg6tcgc1AsmsvB6mOgdhFDqhNp1YXR5BrWvUtGbTfz0hQO5QN4GGZT2xDQh6ukZYJyoZq/IElFIAQUw/XQsnrcf1qHDnjK7km0rtQv4IwpYdz8aksShAN9GNHxwtTcWQUtkpcmXxRXgEPb9lsKuQBN6YXyav4eL2UPJGyC2+wPpJgjBHZatGrRxyOA0FouvkBZoUz9tn8A3DA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qxsl5gDF3/jSVy2BBSafg6Ww5MOd3+YkfDQ+9kQ0VuY=;
 b=D9GLVeBc5XEnG63BowEqyApqmjh1JZZG5d2xaGnL6IXwzp9p9zYO6SqnTQB4v/R2AInwz8ejjtt2nPkkg5P3C4APkphAGNXrGwRIbK7uTbS8ydvBGA36wXVhPoBjk8qVz7pb8Jtjf8Un5+mqpoBulmAwby9SX0i9e+KzTalZSOzFwtuYryd6v8pS3Yy2uY/b7PB8p1o2ZY2FljSRJvyz5+QSz5SVdFfn0upTU27IityhzypeahAIzLlNNUSkTwigw5eSjCfsk84Ez4NQNhdteAXaUFth1k+UhAc2Oc/w9NP9ZtxHNicW0fItvJt6uR3wtYcLIpAKBpWBccfJTDZs2Q==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 11/19] xen/arm: Suspend/resume timer interrupt generation
Thread-Topic: [PATCH 11/19] xen/arm: Suspend/resume timer interrupt generation
Thread-Index: AQHY2jgl07ov6FowcUeH35VPDOse0g==
Date: Fri, 7 Oct 2022 10:32:49 +0000
Message-ID: 
 <63e5551cc906d8603abfbe9596403fdd8107c849.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: fa5c25a4-6eb7-43d2-1a0f-08daa84f48d2
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 TFHN2zXtb+m98VGXMPTOah0qGzVgy9eFQpqujFSYIqMC/UC/zzk+KlUMp2vlPnspvhSARlYUgvb6DIHILGhA1K/WITnAbhGZimJbHH5eBoMdAey6i3Z0s3WPPGrFDqgtswyEVDRHS1t1KDHGf4jIJ6cWzU48onzRPYx8WuhS5xAz4TcW3Pxxme+rfZ8mnGHaEbCi2yVfC9BLW7GTxadzL0rTc62SBkR8lwo+FblCOfHIogEfWUuFALykgQOIu1rx0eO4kzcxYoPrrobVIKk/ScW6L8npm5k07JWjxDV4uLTW2c5uwGUEhUyVQMmtx1aNGxMfBCM42z1ylPBKbUAwyrsC/ALl4cdVpFRqYAeZ2ZaU/JISrZcsBq2Z6R73W2c1E/pzz9JqGGYBhOFhtWtmpqleF3s7L98gA8K2ASdiR3+aBZTstWfl8Ip86gqBCBoG1SZmURsOUp/gzYAvwTyEmyD//9gahUnFdNsmG5qnkiJaHHmJu4ct3V3Gg3w+qz/tvBPZLSmJznSVtbCznO04Juz6ckgq/gp3d+8ukQ65V3f97lX/Q4vnNVZjqPiJ8tUN9kHGXPW3i3whoxYLdyUrZ3SHdjzAcwOzfOPco+UBiumfSFm1tlH8+BTbUTy/Wk5gz6qNqj0MqvldQDSV4+lbbSuCAuA4OcVFyq1s5r88rwzL7uiV3Zq7aeqzJ8GZFnpvCCgtyDvtJME50MkEmmUj6HFrQSDTvpDtYv/EaDZ+vsKFbF588OY5+yForIdWLq/MFpZytyxM+DiYqhQyMVsXIQvsATBxR0p6bvRmxjF1Ub0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(38100700002)(38070700005)(122000001)(41300700001)(15650500001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001)(21314003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?qxLuF9n+m4HFbcJI/uMHaqp0eBHnJ/pXL/riOKhmaJx0xiD6jciIY/sSXf?=
 =?iso-8859-1?Q?1H+YmleQiiLDUGbOEg+e93Iw5lrJOKHbYDpI+wE9rnnZIyYzsIus/aDO6K?=
 =?iso-8859-1?Q?zkWl2C0M4KUwkT7uCzMaVU3prmAwUgQ+FfeMR1sYTag6rHl9ihQIh+Luuf?=
 =?iso-8859-1?Q?yS/nZHtWI6vXtWiUcB0Pro+aj9JztwBhMjDFPjWdu0OZngZPO/j7DqWLDl?=
 =?iso-8859-1?Q?n5JUFKGjI1DDtwfPnkKyesHVgzVG0A2GTnD3gQ7Yv3igjrZioywwmmCGYj?=
 =?iso-8859-1?Q?bCnHJ1MM14wuInin+I6rBkmXZ/qdnJjCpZArNunU0DTpNc+rhgsjEVJFea?=
 =?iso-8859-1?Q?j1XD+GBMzGIMTEVIXGZ5nEA5uM2REs0lqjjohEp4T4z81BLX1YuQ3AKv+1?=
 =?iso-8859-1?Q?yLsGNydxT+ac6bVZX1p3372szPZduUVHWw6RIrvKks/Ay4KR9q9FzHigrC?=
 =?iso-8859-1?Q?7x6eNKdU4SQ5fpNSHer1D42xLayqaWi+yB/KIqP/jKRKVovo8w9fZEB107?=
 =?iso-8859-1?Q?0DoWtijNc8nBzjyI2tRiR9gmcKL0dzfExGweM+lTkUrXFdBShvgi/8aIJD?=
 =?iso-8859-1?Q?1Sy8AbIW4OFudc0yWvDsp/Mvm/QKp74AgHL0fXXgySuS5P4euTV0GRcwVf?=
 =?iso-8859-1?Q?WKCG+ATl2ErYrbmD8LVebDdIHlMlh3GY+poBHE/d9UcbEGFBrL91KXwXMc?=
 =?iso-8859-1?Q?xs7w7/FC+dPP/Ew3rn9NngL4JWSYvtvo8xlKEJ37gSt/VZQMxAw9t7oQ4a?=
 =?iso-8859-1?Q?F1qF7dfiiaDrfhiURQ3K0rVrTBI0/gpuKq8t2kZc76XQfqaZM4dni/ufrD?=
 =?iso-8859-1?Q?pheyhfRNfHYA7U4TfetIzor+CahhUnF+RmkYuq487mAL8/wiO9BX79E1nq?=
 =?iso-8859-1?Q?T8LQtVa7J1QZkzFFlaPcFP4pTVnu34anZtuAjsSEFmuL/NZzx1kHOmjdRH?=
 =?iso-8859-1?Q?8f9cOX0+t6zIfFhgMuuGUfonzoev/0Tm4twqsPR9pix2lsYcnrmxJm21kg?=
 =?iso-8859-1?Q?5JFLQSfXxJp4oIp9ei1fNc7tjRgtNxkjCFyTwNafFZzPAKqZ2UxgzI1cOR?=
 =?iso-8859-1?Q?npg+jHjwoGOa6Q40QGOYgQ2YYxOOX+RWbXZ9ch8ij607oyGT5XLhzfzoB9?=
 =?iso-8859-1?Q?dtrZUQVLZZrrisrRVPWx0aoDJydDmRmBv0pic+zmJnnRV8fALcHu3wm2vy?=
 =?iso-8859-1?Q?9aoAqLi6OIJJcd3Ib1Sna4dXs1Cf1wu494sK8d1wwynSlO8HYEmCujrDOS?=
 =?iso-8859-1?Q?YkRvCGFOwu0GOnbNxc2mntdpj3/BVQ+5fmQmbx1WyiuFci65F759IW7yGf?=
 =?iso-8859-1?Q?l95GAZYfMedAXPf0Z3QlaOEiGFLrVv28KMTp1cA8QcsJzRUfkFpXXvfyrK?=
 =?iso-8859-1?Q?BEeJBDo0bw9yUNe0pJ5ud9GGZSGWsqAwnwhppq0xbXBgUoD9bcAEh5xtqO?=
 =?iso-8859-1?Q?FtNZQpsxhsOLSNnyv7RNoWzEchLgk2QDq3TeZxDG9PdX49MWKuCHIlXov+?=
 =?iso-8859-1?Q?V6ukmWgW87hScQIy879ocPybb0IjQl5UosfsM5ftJQwaAGe6xlzMIA1T7h?=
 =?iso-8859-1?Q?8lMb7ODUaDbepHdnRY3WrWsysnex5exRWDcmlSJs8YFnLxuLLYUvFKJFD+?=
 =?iso-8859-1?Q?MnMz0A+6ZBik49tND9zwnP45khTylIH/zkN0CE/h+EOap8akWhNS4PkQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa5c25a4-6eb7-43d2-1a0f-08daa84f48d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:49.4271
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zRO6Yn0Hru/urtffcRlZ32XXg93ORHvjXQSt0/91oJX0P2WAQZBNmV8QdUG1E10ckfaHV+foWxTh6NW4uS0HCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: ZPKhhP-P3GGVXecWUq-MSu4TrjNRB4zE
X-Proofpoint-ORIG-GUID: ZPKhhP-P3GGVXecWUq-MSu4TrjNRB4zE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=893 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

Timer interrupts have to be disabled while the system is in suspend.
Otherwise, a timer interrupt would fire and wake-up the system.
Suspending the timer interrupts consists of disabling physical EL1
and EL2 timers. The resume consists only of raising timer softirq,
which will trigger the generic timer code to reprogram the EL2 timer
as needed. Enabling of EL1 physical timer will be triggered by an
entity which uses it.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/suspend.c     |  4 ++++
 xen/arch/arm/time.c        | 22 ++++++++++++++++++++++
 xen/include/asm-arm/time.h |  3 +++
 3 files changed, 29 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index b94a6df86d..05c43ce502 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -151,6 +151,8 @@ static long system_suspend(void *data)
         goto resume_nonboot_cpus;
     }
=20
+    time_suspend();
+
     local_irq_save(flags);
     status =3D gic_suspend();
     if ( status )
@@ -166,6 +168,8 @@ static long system_suspend(void *data)
 resume_irqs:
     local_irq_restore(flags);
=20
+    time_resume();
+
 resume_nonboot_cpus:
     rcu_barrier();
     enable_nonboot_cpus();
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index dec53b5f7d..ca54bcfe68 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -363,6 +363,28 @@ void domain_set_time_offset(struct domain *d, int64_t =
time_offset_seconds)
     /* XXX update guest visible wallclock time */
 }
=20
+void time_suspend(void)
+{
+    /* Disable physical EL1 timer */
+    WRITE_SYSREG(0, CNTP_CTL_EL0);
+
+    /* Disable hypervisor's timer */
+    WRITE_SYSREG(0, CNTHP_CTL_EL2);
+    isb();
+}
+
+void time_resume(void)
+{
+    /*
+     * Raising timer softirq will trigger generic timer code to reprogram_=
timer
+     * with the correct timeout value (which is not known here). There is =
no
+     * need to do anything else in order to recover the time keeping from =
power
+     * down, because the system counter is not affected by the power down =
(it
+     * resides out of the ARM's cluster in an always-on part of the SoC).
+     */
+    raise_softirq(TIMER_SOFTIRQ);
+}
+
 static int cpu_time_callback(struct notifier_block *nfb,
                              unsigned long action,
                              void *hcpu)
diff --git a/xen/include/asm-arm/time.h b/xen/include/asm-arm/time.h
index 4b401c1110..ded93b490a 100644
--- a/xen/include/asm-arm/time.h
+++ b/xen/include/asm-arm/time.h
@@ -107,6 +107,9 @@ void preinit_xen_time(void);
=20
 void force_update_vcpu_system_time(struct vcpu *v);
=20
+void time_suspend(void);
+void time_resume(void);
+
 #endif /* __ARM_TIME_H__ */
 /*
  * Local variables:
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417688.662459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfE-0006jA-US; Fri, 07 Oct 2022 10:33:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417688.662459; Fri, 07 Oct 2022 10:33:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfE-0006cb-D0; Fri, 07 Oct 2022 10:33:08 +0000
Received: by outflank-mailman (input) for mailman id 417688;
 Fri, 07 Oct 2022 10:33:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf8-0004P4-HE
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:02 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a2595cc-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:33:00 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2977q6Qa027397;
 Fri, 7 Oct 2022 10:32:57 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyb-6
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:57 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:52 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a2595cc-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dR0/TwJm+ndEpUka78218ts99GPs90BfwY3cSG1mIwqscDCXnhjqCvJDJ13aJJt2zn82vLRlQ+A7LKtsChlgAvrjIbprgRFUu/wG5zRzqi/K9H5cRcpwOczVTbHUlYyeRLW9+aZX5VP7JusYCB4KyG9yw77p5ZTytDMeU7OBpDVyD8fFfbuU9SNmh/YWPu84JFBSghsSiRR4RTqiE6uF/nfWJaaYARoyZ+1W50T+fFotHE3Ljj321d3ApeSJu746WktCi1K275R5H+FtKaU6/5Z67y+zlcSs8dyU+wNnU//EV4F7ePPNxcilA5fxN9lMynRwFn95Pj/6ZrS3a6F+vA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iUPyVMiYcwnXeZDY3vZWTB0lut8ZUfKfufVeIsYI6/w=;
 b=dlibaf9YhA7eE1ZB9oSwTdZPxhytviaMFRPhQp7W0o2jHultqOnbiMi0T7ZeIiBSJ5zSJS+pr1RZJ3pQJ9bex95/+5rt4qaEt4OgS92kvg07a40i19sb4cIhEya7+Kis+7owS5T0ZMNdUfGMS9vVjgKw9sBuHlopB6ttakYIKFbrMCe83PCit5P4uxLi0AR0AO1illfJR3UlqeVQYSHHfF0GpDRTHOOggsmxfHyb/jZ8Td9WHDVpiXn/7umlF4seie/KpDGhuYfJcULX+WNEd2YqJCLOuJTlNBov+EiIzkl1W9hb4aSEUi83+g/+1GuuWehKZfF3W7Z7jd9QdFPZbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iUPyVMiYcwnXeZDY3vZWTB0lut8ZUfKfufVeIsYI6/w=;
 b=Fn0iDdX2TikXB3AyAi+pOR0+uLFccRM/CeJ9RnPNdxwHwICXrWMCE7pRhrM8+3bggmpQwHtkwRRDm3pGYh5Po0+vNBZe/61biYonN6Oqp/4JMQNwnIBYeoAWWbLaL//IHK6u8/HSOIS4ktJuZU6d/i2LsYCUkkocjgGv51Yrhv+hortWzI7DhQiHB7R3Ad+FKAr4Rf9KDGGOKgly33CRiex/L9g0ryW9J8u3XBgAMSvL41Md50B6ipus8hJbr2nj/Mp6Z+hAAlDu3yfm6urx7aiREWgfP+q1ctz3MPawpyrkP145TprDU+EDCS5UUzwLKLRROJha0eVdOs/PKi6XkA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta Poturai
	<Mykyta_Poturai@epam.com>
Subject: [PATCH 13/19] xen/arm: Resume memory management on Xen resume
Thread-Topic: [PATCH 13/19] xen/arm: Resume memory management on Xen resume
Thread-Index: AQHY2jgm3Yyy/xebRkCIsLQOXCUKiw==
Date: Fri, 7 Oct 2022 10:32:50 +0000
Message-ID: 
 <c4716207f7f269b8adf7ed1b1928558cfc1d3bc8.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: 122b4de9-69b9-4d93-3cf9-08daa84f4a41
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 WzColpCRZPKvEoVnX4wlJHpV8gVO/0wzHsWCJkXRkeW2I93xyhNNpB4pof3E737pFY51B3aX7h4T2WSQ7xVMqMCB9pv65AmhYt1OgwYjpXymwi030z0pE7k/XMm0blZGO4e4x921vE2wrsWDusf/K3I+L+XYIwnERJZqKNIrEZ/N7adubURg1JESZQPPXUXz01XlMRvFzowkv8Q1uy8p3FNQ3KUBKa/04/B2BX6f+SLYZ8ZkFWElNDg6mNQoThmFd1p90vg9wBfLQn6KanB4JPLKxPN+lckk2mz9sWSA3bpJUuRgFpAYRSmnqzaVSmrsikrhlQU+Ak6Knsewo4LFNHiVUZRISyiV1W4dYhiF/4hAfJWJtUwUapfT3G2HZcUUm38zCC7M97/6xQWSyC/5s3N5N/7GCZgR6QKQHaRA+EozIqI44vGnNBSMK1ZjjU1QAWZstVk0aASptnqRJ/SQVPuEp10eFOhV0fNyPsgxzEpj1kFq8kKBSS8HLlAZyebwghgn5DEvXwuj+Vlew/hxOfyL+Fijxtg6Sbp3njuH7wL/6uJ0y+kAUAzzgcpZWj4NLVtqceK/O/90tQAoSMAJtC3hb240UHyxJ6SYu8pCNnjuCNvqFp/mtkH8LRmWm080U6e1SOpJ0PI8V96p3Fza6wnzJEKV8lHbPztJ3M4NxphfqKniDy0980J87/Km/IZuDmOhufnlhcsP6YvaNwZPd0nK2FQ70G3n0SSGxaIIKUq8i8JCrDPecSjR8/k2npSnLzdwKitHJITkD9h2inkcjA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(107886003)(38100700002)(38070700005)(122000001)(41300700001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?Zjm/umPBq/YGOwxrp/GQ++meLKXym0CwDbwjsmcHeLLQizDXkC7pMTD6/X?=
 =?iso-8859-1?Q?0fPWwMgyW3ynRqnwP/ElHry3Wv2zqSomxFRJIhbsCqcdeX9j2d/n9U+WND?=
 =?iso-8859-1?Q?LbOuOX4UiBMy03Us1rZup8KnNhPadCU8JCcGKtnYT1GCi/PB/1bWGJKOg/?=
 =?iso-8859-1?Q?YFl+UPDgqpwckeNpTPy7Zd6lfWzenDY+NvcXrRP94HVLndLqJneR+ZeESC?=
 =?iso-8859-1?Q?bd4DUjCGhfWgBxi6MgxJh7gq73QZts/H8NUY6KAQ137XHhtu9ESFdBhUHr?=
 =?iso-8859-1?Q?8U5Fviq5m+wCVuy5nm3DOk9rqaF9mqnn2JnefMxMc8JmzpXc91j7vd6K+l?=
 =?iso-8859-1?Q?LhbIb+8vItbb3ZvVnb0EoHZq4rfOQ/uy3D3jVGqihxQRpL4xcFP+YwhUxR?=
 =?iso-8859-1?Q?TrFg19alzPKvmrbznMBRTgKY6RuiuOgmA/5q4OAoGH5IO9tS5B6EZh1kZ/?=
 =?iso-8859-1?Q?Extv/0XQDs9nA0Zd/dQet3mD+fmZjQXQoLQxbj0Dk9mbJbPe8buqDa8NFa?=
 =?iso-8859-1?Q?aoTc+chtLUdJyV+EsMnan5KwrN6zhOsHGAli+OgSuLrPB9uLj2gFv0M9v6?=
 =?iso-8859-1?Q?stdHvbrrVVk5AU3hFZ47GSw4VYLAOECWJxccc5+hBpjFGbC67rfnqqw582?=
 =?iso-8859-1?Q?biZOI9/zwj5hCCqXxCWvtyeTqAccDei8GjilwPm+5GygZOoxHy7dQeWtEv?=
 =?iso-8859-1?Q?ioJNoBiV9cwyquQbnf7FKpprd0KabNSkITKbug40+Gt3dPltANLHxxXfV1?=
 =?iso-8859-1?Q?59LWqOgkgNBDZA/mFphhz/ZUM5RL6uTCQaEQdw+/HXig5yPtO/wO1fMS/A?=
 =?iso-8859-1?Q?6gAHbDQPu94f0/EXHnT3gOUw55zHeKWyWkTarczp7lPA+AaadzVqbaIwV8?=
 =?iso-8859-1?Q?8D44BV1Y8InDYQfoDbrXMh40jCWOCbkmt7iwX9TEdx//xqiamkshYisF8i?=
 =?iso-8859-1?Q?vpKeMMw7uAAg5Ugs9baR2c2BmDYpDcj1YjUfWVUHdEXzPI0hvqoMNDa6ll?=
 =?iso-8859-1?Q?Uwx+WCfxRffCKlrUPLSVCyBYMekJDA066XGBlwDK1ckPsEUd81qZstYCZs?=
 =?iso-8859-1?Q?sD0RZ0vwI2f1KRHMI8Z6/rbfEIZk1w+ErjgXsxF9qzJ6cHH8EVjepyG/JK?=
 =?iso-8859-1?Q?0QjO3tgSIAr1wQd/yySZxhFCjBHe9PaWHJmM/leHSTiBKR9jnTPqvkGRPr?=
 =?iso-8859-1?Q?JqOKYoAmd2upkBtjl5drxiALu9rBtOt8eI5b7sBts8qpwdYN4zv2WdjLCV?=
 =?iso-8859-1?Q?fZFZFNM7R52uYPbQrRIqc2Md1WTPycn6QJBy/W6dMXdWdInt3HJoOXDGcZ?=
 =?iso-8859-1?Q?zYHNO74TblmPHnDn8KMWK15O6VekQS18JG3omkXC9NrkZzIEbvGb5MxCa6?=
 =?iso-8859-1?Q?15WPxM0W7sehpiAaJ19NogruGQKUG/1BmETGrBFTrWg58GgNXpGwkK4O2y?=
 =?iso-8859-1?Q?3uXSV73npl6L7XFAKinH5ZJIlBthg6TYVFE1lSJoOO8vJK6BgSBIs36hO4?=
 =?iso-8859-1?Q?DWm6LEGn3YWNOhZUfWKYptIVLXyQ6iOLXXMtAsJDZ6ZXF96p/AP6TSwZpg?=
 =?iso-8859-1?Q?ObQ9z+DA+kHBP52LcRrTp5G9Tv7kaG57dLkdBCw/rjxj9A89aataWSSX6g?=
 =?iso-8859-1?Q?wJp8tHay2MmOfhl8J7N2CNQUqUQya/K2JVzwrrQo1I4nvhxctp7j8IYw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 122b4de9-69b9-4d93-3cf9-08daa84f4a41
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:50.0677
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xYET/DSI/I6FVFtIM4AMvDy5Cd8hfmgqwNOJT8mCKQ/2M4x/8coZWwlX4bY0tODD7hYqGlbqVg7UASd2JwaJrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: 5tysNXNLOO9dVVVqJ4irDYcKjt4IIYyE
X-Proofpoint-ORIG-GUID: 5tysNXNLOO9dVVVqJ4irDYcKjt4IIYyE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=418 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

The MMU needs to be enabled in the resume flow before the context
can be restored (we need to be able to access the context data by
virtual address in order to restore it). The configuration of system
registers prior to branching to the routine that sets up the page
tables is copied from xen/arch/arm/arm64/head.S.
After the MMU is enabled, the content of TTBR0_EL2 is changed to
point to init_ttbr (page tables used at runtime).

At boot the init_ttbr variable is updated when a secondary CPU is
hotplugged. In the scenario where there is only one physical CPU in
the system, the init_ttbr would not be initialized for the use in
resume flow. To get the variable initialized in all scenarios in this
patch we add that the boot CPU updates init_ttbr after it sets the
page tables for runtime.

After the memory management is resumed, the SCTLR_WXN in SCTLR_EL2
has to be set in order to configure that a mapping cannot be both
writable and executable (this was configured prior to suspend).
This is done using an existing function (mmu_init_secondary_cpu).

Update: moved hyp_resume to head.S to place it near the rest of the
start code

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/arch/arm/arm64/entry.S      |  2 ++
 xen/arch/arm/arm64/head.S       | 30 ++++++++++++++++++++++++++++++
 xen/arch/arm/mm.c               |  1 +
 xen/arch/arm/suspend.c          |  6 ++++++
 xen/include/asm-arm/processor.h | 22 ++++++++++++++++++++++
 5 files changed, 61 insertions(+)

diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index fc3811ad0a..f49f1daf46 100644
--- a/xen/arch/arm/arm64/entry.S
+++ b/xen/arch/arm/arm64/entry.S
@@ -1,4 +1,6 @@
 #include <asm/current.h>
+#include <asm/macros.h>
+#include <asm/page.h>
 #include <asm/regs.h>
 #include <asm/alternative.h>
 #include <asm/smccc.h>
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 8857955699..82d83214dc 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -958,6 +958,36 @@ ENTRY(efi_xen_start)
 ENDPROC(efi_xen_start)
=20
 ENTRY(hyp_resume)
+        msr   DAIFSet, 0xf           /* Disable all interrupts */
+
+        tlbi  alle2
+        dsb   sy                     /* Ensure completion of TLB flush */
+        isb
+
+        ldr   x0, =3Dstart
+        adr   x19, start             /* x19 :=3D paddr (start) */
+        sub   x20, x19, x0           /* x20 :=3D phys-offset */
+
+        mov   x22, #0                /* x22 :=3D is_secondary_cpu */
+
+        bl    check_cpu_mode
+        bl    cpu_init
+        bl    create_page_tables
+        bl    enable_mmu
+
+        ldr   x0, =3Dmmu_resumed      /* Explicit vaddr, not RIP-relative =
*/
+        br    x0                    /* Get a proper vaddr into PC */
+
+mmu_resumed:
+        ldr   x4, =3Dinit_ttbr         /* VA of TTBR0_EL2 stashed by CPU 0=
 */
+        ldr   x4, [x4]               /* Actual value */
+        dsb   sy
+        msr   TTBR0_EL2, x4
+        dsb   sy
+        isb
+        tlbi  alle2
+        dsb   sy                     /* Ensure completion of TLB flush */
+        isb
         b .
=20
 /*
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index eea926d823..29cdaff3bf 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -708,6 +708,7 @@ void __init setup_pagetables(unsigned long boot_phys_of=
fset)
     switch_ttbr(ttbr);
=20
     xen_pt_enforce_wnx();
+    init_secondary_pagetables(0);
=20
 #ifdef CONFIG_ARM_32
     per_cpu(xen_pgtable, 0) =3D cpu0_pgtable;
diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index a0258befc9..aa5ee4714b 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -167,6 +167,12 @@ static long system_suspend(void *data)
=20
     system_state =3D SYS_STATE_resume;
=20
+    /*
+     * SCTLR_WXN needs to be set to configure that a mapping cannot be bot=
h
+     * writable and executable. This is done by mmu_init_secondary_cpu.
+     */
+    mmu_init_secondary_cpu();
+
     gic_resume();
=20
 resume_irqs:
diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processo=
r.h
index 8ab2940f68..ecf97f1ab4 100644
--- a/xen/include/asm-arm/processor.h
+++ b/xen/include/asm-arm/processor.h
@@ -133,6 +133,28 @@
 #define TTBCR_PD1       (_AC(1,U)<<5)
=20
 /* SCTLR System Control Register. */
+/* HSCTLR is a subset of this. */
+#define SCTLR_TE        (_AC(1,U)<<30)
+#define SCTLR_AFE       (_AC(1,U)<<29)
+#define SCTLR_TRE       (_AC(1,U)<<28)
+#define SCTLR_NMFI      (_AC(1,U)<<27)
+#define SCTLR_EE        (_AC(1,U)<<25)
+#define SCTLR_VE        (_AC(1,U)<<24)
+#define SCTLR_U         (_AC(1,U)<<22)
+#define SCTLR_FI        (_AC(1,U)<<21)
+#define SCTLR_WXN       (_AC(1,U)<<19)
+#define SCTLR_HA        (_AC(1,U)<<17)
+#define SCTLR_RR        (_AC(1,U)<<14)
+#define SCTLR_V         (_AC(1,U)<<13)
+#define SCTLR_I         (_AC(1,U)<<12)
+#define SCTLR_Z         (_AC(1,U)<<11)
+#define SCTLR_SW        (_AC(1,U)<<10)
+#define SCTLR_B         (_AC(1,U)<<7)
+#define SCTLR_C         (_AC(1,U)<<2)
+#define SCTLR_A         (_AC(1,U)<<1)
+#define SCTLR_M         (_AC(1,U)<<0)
+
+#define HSCTLR_BASE     _AC(0x30c51878,U)
=20
 /* Bits specific to SCTLR_EL1 for Arm32 */
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417689.662471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfG-00075J-If; Fri, 07 Oct 2022 10:33:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417689.662471; Fri, 07 Oct 2022 10:33:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfF-000727-N2; Fri, 07 Oct 2022 10:33:09 +0000
Received: by outflank-mailman (input) for mailman id 417689;
 Fri, 07 Oct 2022 10:33:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf9-0004P4-Hb
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:03 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b3e59be-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:33:02 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297AP2K1008629;
 Fri, 7 Oct 2022 10:32:59 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyg-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:59 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:53 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b3e59be-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b7eF3Ld0NgKbxkqyA393PPvl4rNXvZmR4Wc34k1/1SQqA5QZ9Sm0SnwZ89FibjqL5AJX9gW0qckPrk9qRNxZ8U/srUkt7EzSUlB9XhmTNH/U165i1A337H5cPZeKKI66hnDfaQNUDc3ZkyN8oTserNnLvURyGy//t1/YPlRNIKip/wc6GGIX9NDmJQGEVXITzKpf0g0PUJ29bCezjyypxrHn/2CmtqzjrkTatC2DmTYjQPXmgBkv6XSisSwIgm7jYDVDp2qLw2vuG6USDnn1Ndb+rwWPgUhB10OiDGEYaeqyjJaJ+dzVns8VyTdkT2QsG9ncJ5qY26Iy51phRpu6AQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QenTrU/w9T19tqKdM68BwBw1XM+QqDHCATxtF1s1i9Y=;
 b=WZhmAXvD6c3Pb0PB0PFK6MExeL+dn9yRn++BWuZYCs1LmcsupTyNx+uKCcqpK+jP3xJXX6/TPCpBLY4LDBRgkfF96Mft1pJQpTtLR8d/bDjR8oeaeUHN65WFFj0ts8T8sayYexKlioqhErrjCnpiHgykHsgJLkaW21PLFkL5sOMHN3ioHQSr3dLVIfT1aNCwN1XkkvU0HJ5M3j9CFGNRPgT+tuEoCcGcla8Mmx/96T5EMmTSGkYy/oOjwOH8lUKxGxdw2v8clkEEMLIHJEVllMl/OVdOgmVrFg67VsSxnPEZizDiIP7Kg/on/WvCkBquG3/yoj5pt3sFKtMWbhRXZw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QenTrU/w9T19tqKdM68BwBw1XM+QqDHCATxtF1s1i9Y=;
 b=NMVs8loIopNhdnBumKMSODAmFRsQidHT4XKj+DzM/cqlyAwIRameroK9NUnDzAdonBX+jMiYc7/AvYXYR9r68/FAU4rT0gBKa+UaANMovL9bCKqWqHwkz5sSknwTWMuNSe44g7K3QpkNYik7sDffWnmTXTpeBlWsq96A22TtusmtI6IzEOAcx04jhJXCEkdlcqZFgHh2izpx7tmerOA6v46c6a9Phhm5XObpDe+msH43AIVCvRlbVA9IEXJ8vH/YLjYSj67lsds2PecZzmXT6/jBsuLqF8kT1FMUcXuhM1LYj9JchcenM3VKjQY2VGoEdGb3X3xKvlRHSZ18IW0geA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 15/19] xen/arm: Resume Dom0 after Xen resumes
Thread-Topic: [PATCH 15/19] xen/arm: Resume Dom0 after Xen resumes
Thread-Index: AQHY2jgmyrQmtGIhpEijBSu3iT5A5w==
Date: Fri, 7 Oct 2022 10:32:50 +0000
Message-ID: 
 <500232faa5a520d5cda582de3ae7cf7735190a55.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: 9b2567a8-cf60-4676-a972-08daa84f4ad2
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 4DzNZSx92Qooy+5zqPvJkyyhIXsaWfZzironQsByzLZF0umzKX5FT4txJwJQuEZKImsxCwgQtshCQj0gk87UKAKib2Jci69G7CPp+w5L5tY7b2ie6G7U1aeoAC2T0I2a7ayv2IDQuJTRSWYKEoLukH4Nn/+H9FE+dUabuXMOl9L1sTuRw/Qo2UNmG77/DUqUqwwoQ/8DxPm1/HixSidM3NvVeRIKrBtFtrQ7q+tkzAVlCpb9Lk8ZqrhCDlO89E7wSj/04eCDWCggcmvnlBhyHhOYR+CbfCxVhTIuP75rE0IbjbxV7MJFXA8dBuJf6HJzqgu+RtZxrzuWO7zF8/KSCjJSjzNWmRZBssDNLPK0TRMAMDHjx6tOAetmqTPQuEPe9vnCv9Awdher/Jhm6xlKugWxeJO8Hf76R1ki4DTpW4RC1CPraPl+p3+JrfGOi84qU8gOcCpJhtOzmS4bxFf2GBEPNPCDYGelmvU0wY/LEKM3be7Bh2AmJJJoVQbAOSVLWkyC8sg8hIg44ZfyWZvLDUcIDSz2CqT59AccdonN/mZ6H6r5RUuxsNnRMUZxkq47wqg42xCA4Qfh6yb4JiI3HHzwqSm1vJ9k9T0FV5V66o9oLU8hyJ3lDPNaF8F2uYe+KppfsP4R3EaBmoeA1bxNiZpSb8cIAu56vvCn0+Ow0/NxardHkgYhOlb/CeAxSn7uReoHSln3Uk0ilyxXb/UpbL4wf5Lf8VWwEum1T+LTixKjA9RXyoOP8EeycrCp1EzaxdsIXzQsG7T9bH1xLnw2lQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(38100700002)(38070700005)(4744005)(122000001)(41300700001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?kzHyXZtW/Icrc85ffh2qf1iVA9MnEfXoxhBmFErvevfDgiHd9lTr172BRB?=
 =?iso-8859-1?Q?uefu9jDhVUgfodiSTojY+NqzfbfEYdUjRYcFyfVZv/3txUoKFYvsp9syaW?=
 =?iso-8859-1?Q?BpH40Hd79RSVz7QqCXylHNsbUCM4tPXyZFQ6fnNSHhZhaSIrfbWVrqNK9H?=
 =?iso-8859-1?Q?8cdSXN+SjKc+bG8Lhi++u9xMBO/95UeRtTjDAVjYL7BW3iP4sP3+UikObr?=
 =?iso-8859-1?Q?1R/Uo67Ziz3uH9hzNyJYPoYguEyFPXZp0ounD+AZXydJ+zBGhr0BvKeW99?=
 =?iso-8859-1?Q?m+ItQ21FO/cNTy0NQ7h+ljfFYVi7KFEeJLJ0L5ad5+nyxfr263UNNYo7gb?=
 =?iso-8859-1?Q?HTwyhqW2RZzz8Z1N3ZPsAShI2mmixyejHLupIENoVaO6mt56Rg+khJxxVn?=
 =?iso-8859-1?Q?aH3nb/YRd+IRmwcfuwYhymrRtML33nHcs2CAH3eyPJaYrxW3ygKFZgn019?=
 =?iso-8859-1?Q?hfBe61mGZNMnKgCl3o3FegjukGTHC3CSl70ot3FSycabVWL+Xh+X8OP+uZ?=
 =?iso-8859-1?Q?NVZ3E5U+k7RKpuqCeEZqRma7tu084iu4++8za69Zci1hJVPrw2L3vOIh2l?=
 =?iso-8859-1?Q?BiKf5MvabgDlUCyhMmPutQypUBjHGkxqT/ldi5t69iFDmL4Go3xTPNiEzs?=
 =?iso-8859-1?Q?c24+DUHYApWqc/z8QqKUAgsJz6rBl7Gh/4fFHKn4IdV5xHc0FCQbjqPQ30?=
 =?iso-8859-1?Q?GdiFnIYLyPd+zFQGmllCb5HgI/uFCn2kITJIAsRRVTZPBo5NVN+THPLvCd?=
 =?iso-8859-1?Q?fs1h9Zo977acmPvxEtIiGDZwoNdNTTQkfePhnYhR5p97vBXu4/jTW0mZId?=
 =?iso-8859-1?Q?hWbQuP5zU5JREcdR1DU7PHTmkQJxNgJ/psqzU3Q1cDZYMjFb9pSwHnKknu?=
 =?iso-8859-1?Q?7s3VzuPLV4bJ/iULQP9Gk1EY1m4AGx/xl+nE3R1A7R690eaKALwxbZby7N?=
 =?iso-8859-1?Q?i9nDHCFkPL1gmt17s7E6H1B7c8ho05god71c+oJiCTr2ISI5TIpGZkLoxa?=
 =?iso-8859-1?Q?d87DtYpUjMcbyRd3Wk6wrwnVK6HOEKJzxzxSevj89cefIGuoiy/hEvLolD?=
 =?iso-8859-1?Q?REfUBQryPd4QY2xNXTBcPTQi3tzMiUiIg+hNpiWxitjjoZ5sN6oeSwjov0?=
 =?iso-8859-1?Q?F+xAcC5fnfHKcCHMoKxB7T70Qt95BKZclHPrrCuA4EbjxHTOFLduaqxvM9?=
 =?iso-8859-1?Q?pFAeR/0QvgrmIUIBPH9cwa8BemhP2B5ScdHYc1uR6q36KsWrQNMjoQIm8e?=
 =?iso-8859-1?Q?8J111DQKxOWhnLEtoA75SN2aU9vSFHIYrHYHKISeOGc2ry02P2iMgdvzvI?=
 =?iso-8859-1?Q?IXYFEnqq7ZJenugyMZnmTGoQ/sDe7xxpV5ZKpYTtxuKxpoGzwkA8pmOFiM?=
 =?iso-8859-1?Q?mDbwXtTDrryt1N52dyHvbh36lR2pn+cOqIG/9VTbxw8imYIK/h3D36R/DJ?=
 =?iso-8859-1?Q?2nx94wzR7ZlHiaWNHy1lUzd/hd/WrAI34m43VRQit3p+ULg6zGC6+F/zK+?=
 =?iso-8859-1?Q?poiMA3Bcq5x+CpBM0cSzdBRK6dxbsletew3WQsAEWdOTsg6c0Z4VKZkn9H?=
 =?iso-8859-1?Q?m5DMcEduBeLseT+GwzuNed/yOIuWFUp5pi8jXzjxJ3m4n8nAtzZuH85gQ4?=
 =?iso-8859-1?Q?0cHORSj/zHeFlkuTYBRCpMk9Sgzb83v91tO0BV1aD1Zt3FvVEZXqKJKA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b2567a8-cf60-4676-a972-08daa84f4ad2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:50.5989
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jr9+kJnEJj09+oOLSOdsrXdLnsRMA0dgfwCJesglnugZVNclpTExRr29WEnHllRJvyRTTPYDn/U+I8zjD0DduQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: CrRIqK3XYkYeRBG8CLsP4qoJCbaWZxB1
X-Proofpoint-ORIG-GUID: CrRIqK3XYkYeRBG8CLsP4qoJCbaWZxB1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=393 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

The resume of Dom0 should always follow Xen's resume. This is
done by unblocking the first vCPU of Dom0.

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/suspend.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 13d1aba658..4a690eac3b 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -206,6 +206,9 @@ resume_nonboot_cpus:
     system_state =3D SYS_STATE_active;
     dsb(sy);
=20
+    /* Wake-up hardware domain (should always resume after Xen) */
+    vcpu_unblock(hardware_domain->vcpu[0]);
+
     return status;
 }
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417690.662479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfH-0007MB-On; Fri, 07 Oct 2022 10:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417690.662479; Fri, 07 Oct 2022 10:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfH-0007FY-4K; Fri, 07 Oct 2022 10:33:11 +0000
Received: by outflank-mailman (input) for mailman id 417690;
 Fri, 07 Oct 2022 10:33:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkf9-0004PE-BW
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:03 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 693c3526-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:32:59 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2977q6QY027397;
 Fri, 7 Oct 2022 10:32:56 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyb-4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:56 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:52 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 693c3526-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MfPdjuuE9j3LU/YVeOAlGdAUaRqOVYY/GLDpNjS2NoBTHaQM0HaOCqhBmq6gKeF6/LivQxnnLO9asZXPuK6KX3vQMRRgX0+EKh/dWj9/FfKApm4jo0i+uRifQcyl8DbkrLWA70LeQaNwLxCHHVh4yH4fXRQEHNpXT63TQEStJcCpm7wuiLyKNvH+9ZD6ht1Zk72LQwQcoY+hITrQdemcYIaw90XngCAidHv8WeuX7YZS+VxIjb/aXTGCvLYRZjc8bNqP1gM5peeOtEPcmS9OMdg5PzUX67O46HgBFj7bv99f+ZOVPFGISINp4jGkgX02DSUPM8EMRr5gH3sWQiRfJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=unz+jrtnrI+CjltUTU38KqHD4hMG6m3HsyrrTQHSbvw=;
 b=HR9uyYUA+pcvzG/g3WEelzFgquVGiXRBMDaEfNVdJ/uQv3HsGyYq1jNL5RdSqN/YY+hy5L3QmbTdOm9+TfglKRUfUNX7WGditEwn/SQJMokuIuwXncNfQV/YObzD8on8bSxUOZZjcexF5Q1U3qMwUK+vZeu7vxpNKFWhDGg4GXCSM4vG3KpB/nB+FornvJsBs0Ov9zO2y3D+WpDpZFQCqiZJhLjaJiiIoGvDELKsG6OMXdbE7ynzmYi95swOF7qyq7jBR1C41B49hhpRHRH8YfeovJ4mRbqU+rSKEqnCKXUe+BkmURRE7qNr85wHg0Dxq1HfFTuiHnggsghVZ0Cm3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=unz+jrtnrI+CjltUTU38KqHD4hMG6m3HsyrrTQHSbvw=;
 b=M9msj1BE3qxjEupp/yZZTPoAkipuOoxSeZeJiRug7Ud1Cj+KH88y2uSHAUUYvB02akWLfVRjWpL74+wX5z0bklSk8+ZIZnZBYfy+zZ+KmlXnh30sQYDUBPCT25NNZTrOyTKLtgXwthc74IMKR9TjiJhNMnBuE2lerX+roWzRgtbXXrXeYVAiExBwtS420TrL/A+QxwZqTBzSyVUI+CtqciudUpOdJ8amyT7K4TW4EPsSaXsswSe0D2EDDS9U5h0ja0QChy2MfrTV8YcxVEw/VEUF8O+6xE6BwCQ6JlbA8tMcnxPiIGcSWxLRntf5u8ag2shqXDBwosRqlhhcRqz7TA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta Poturai
	<Mykyta_Poturai@epam.com>
Subject: [PATCH 12/19] xen/arm: Implement PSCI SYSTEM_SUSPEND call (physical
 interface)
Thread-Topic: [PATCH 12/19] xen/arm: Implement PSCI SYSTEM_SUSPEND call
 (physical interface)
Thread-Index: AQHY2jglXt2WenDZ1Uub9jvAfdfdiQ==
Date: Fri, 7 Oct 2022 10:32:49 +0000
Message-ID: 
 <3c5ec1f22e9ae6bac7ee98f63a0a700d7c3ec11f.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: cadc161e-6439-4a3a-deb9-08daa84f4a00
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 W/RhVCMWheAiOuatjlYbhbK82rGRxdS4LnZPLGLf77Cr4X/PTh8XFVHGGHTFTcX95t3MaVaLU/BYQJurQ+0f8flhdHxrQlb45wWYoGSoWsiv7w1zFdUifoi8qjgIALMvyiC7zHM3HWwLTQpaUrzekyC452keDvQMBcpbEat8kFzsB/RdAl4hYF6tuzA4moRBqinkPykPO5gN1ju/wOUnqZSmn5QeQUBYr1ZEOcKIxLNZmy2JRAHmjS/Ed8LgMaHG+I3krY+PYpSc6dD7b8XFKADnxm3gImRX/aqHIiyssLS5uXw4kgT5VTwynQ8xvF2HUJua7TXEbqziQjcayJIL5ejZsq9XQsLoXqBPQfIyG/OkOnCZCZbyASZ4Zf0CsdLry7i4KDBiqVQFg9nre79Al86579DSx/AcN3Ym/XJVg3yQdhh/+ZCJh0ZTUnSWC2brBVKTAHxINTK97xFIShg2iy3RJHetWZahaMolxhlVU2mVtRMSC/1/LisG88iZ9a4cAyJX+2jTfT/Ql7hlCnGxCtm37QW1xHuALxxSwTNtsFi8eei8H16NX7s8osiRkjU4cn/xeOQIewKBHj8kEdOQ+64JJjvBEqrEXRfzWQOjaksCHWGTLNCU4lhQvXEYsWxHKvd6CFHkmQI57seJsjZukogGzjphfEVjB4rqq1RbuosFDyoKnnQr4eTWDImzuA2Lic9glkv3nYo4Wufqdc1b9gVcVDvLsHDewGO8Vfey+Zs6AmFVSKj0lnrjFZV3sInEKovCNIIaU0ExKt8rmC59pw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(107886003)(38100700002)(38070700005)(122000001)(41300700001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(6666004)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?oLF5zdZIwQ61uoiGz9x9VeL95J0qey94TadFHNnfGDsAZczeTHwTpFRYa9?=
 =?iso-8859-1?Q?YTxEne2gOD8s0/nRrRW1/Y15Tx6boUIbWVLL51OWqKDAM69iW29T9R0qMX?=
 =?iso-8859-1?Q?0HaDM6YECEwFirA+9BNXRMT5puVhacEFsxVyD1EK0wmFzJM5KMRapBczi6?=
 =?iso-8859-1?Q?+BV0aRJorfMVNuXhwymeIlvOKDmQLuAS8UJpyV+Pxh6v0caZvu3p3+iUL1?=
 =?iso-8859-1?Q?CQAZG3DLBzz2L1/ZwyIvODWYj7ABCBeyu7Mm5szMhj5LmhC3n5gQ12K3Tb?=
 =?iso-8859-1?Q?sSsehr+mDBC9E0BN1E6+rpNI24ubG1Kzrs+duQdYJhEcP0OnM/Thh9oMen?=
 =?iso-8859-1?Q?vbJu63Mq6zTEK6Z1NhlgnsrWa7ove2fmPxZL0c2tA+BGkZX3feZlxnzloD?=
 =?iso-8859-1?Q?sCoTyEn2Yn1Rsi4VrKPMYFzqUrDu56GNKQj3RJeu//VdolKpMM9Tyfvfw3?=
 =?iso-8859-1?Q?YK3tZ9z54E1eWm3KBZKKEbIXnLYYHGabHJhabamnfWGhYnpijoiZ8nLEHD?=
 =?iso-8859-1?Q?9LPKqo6cA5mbkS/v2NU+ghgZxngyP90Idy7f159Ntn/sYTKmD61CTxLEa1?=
 =?iso-8859-1?Q?MDsoR6CKJ/7olmYXav++5FQ5uEnu6YBLmGSdvm2QQz5tYiSf9MIfWLvFMD?=
 =?iso-8859-1?Q?Vgwz711zrGChLNx/k2oJxEZuMnbLb4F9teMvpHLSC60U2c+ngPe9aSmnur?=
 =?iso-8859-1?Q?xXcqulX5YOPm0afpsOF7MoLr6iOH0rz80xYDG8s4uLKND7oZ+CejEPXh0K?=
 =?iso-8859-1?Q?OVta+jlEiM8PcdNqiOQn4vVe7+4TYPyq1ThihBZ3+aRZM8ZlQhij8iHgXg?=
 =?iso-8859-1?Q?zge2GDM4FYnccnOxBZlope19qqgfDo/V9w2KiV0GIc6q+OvHGrMLY+zrDT?=
 =?iso-8859-1?Q?UNnPfOvlhrqMqGqlwGZgWA5Sf2W0lh8e5M+2w5WlhnOK0a79nxaCvu0FkG?=
 =?iso-8859-1?Q?RMhOTTm9He1GjGdVPzGtOdYGcGtL+2ADYEOaNirkI3TcniB3QMf8F8Z3NM?=
 =?iso-8859-1?Q?fs6VfQ2TMyequ6wtTrWG7ZLdobrxDk09NESZJu3NQhHFhR8E4WHRKRCmu+?=
 =?iso-8859-1?Q?ToujN6idxRzB+iZBMnRcBrt+j4CzZULtYQjHQcLO/F+9pVaXGWDqXIKVIb?=
 =?iso-8859-1?Q?Z94SSc5KeIrvmH7GQixEBM6nScyRzXVMzPPicitBweoTzfw872P8j7zTks?=
 =?iso-8859-1?Q?Gk/Up1qL36kaiIWRlwNAmsXz9lXT/rWm4S8SUj9OiY8fLrLJ1kgR13JIy8?=
 =?iso-8859-1?Q?ZNlgOmAPsrCiovtTmNILZGRwYudSEQIPsMW0pkd8WOHjEQThNbERw24xhh?=
 =?iso-8859-1?Q?Q34vQbftIxFZqA2Hge2TYcs8Jr9B7EN0hp0MFoXqTCd5PtYk04MhGHAMUQ?=
 =?iso-8859-1?Q?pxadtO97XNEw2y524o2R/m+gsafWSw020RlDhEDbLb9E7VFxC4ygpzB2zU?=
 =?iso-8859-1?Q?S0AfkE2CR6m2Jng7AEaIRi8jSGXZl4Ey3lOZb02LiIHJG/5+SMuZYlhi9+?=
 =?iso-8859-1?Q?Ge5DErpNprBvWJRmYgFo+VD4I0Aby8Ztu+8RyW583Nn+Q1DbCDel8FaOIi?=
 =?iso-8859-1?Q?IKemUMU+TrbKYP80yOeHsH+Tqb5jJ7goEl2eMyIDaMoTE44eYzBKuLUtw2?=
 =?iso-8859-1?Q?ZkZX3ApYw5kV06+sBLV1MewB/bVniEALDFnHGUgXWeQ6MhLUetvyamxg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cadc161e-6439-4a3a-deb9-08daa84f4a00
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:49.7083
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: haPwk+HeC6NjZhQbbI1qXuUU6DfMM6vmanzcnUy5/Fg72CeJXTonsb8+Ur09uU7PWrfjmyb7u4jjBwQjfRYxCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: lv8on0Bzs9Gnx-_bIOHkvxt5fn3yGKU0
X-Proofpoint-ORIG-GUID: lv8on0Bzs9Gnx-_bIOHkvxt5fn3yGKU0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=969 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

PSCI system suspend function shall be invoked to finalize Xen suspend
procedure. Resume entry point, which needs to be passed via 1st argument
of PSCI system suspend call to the EL3, is hyp_resume. For now, hyp_resume
is just a placeholder that will be implemented in assembly. Context ID,
which is 2nd argument of system suspend PSCI call, is unused, as in Linux.

Update: moved hyp_resume to head.S to place it near the rest of the
start code

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/arch/arm/arm64/head.S     |  3 +++
 xen/arch/arm/psci.c           | 16 ++++++++++++++++
 xen/arch/arm/suspend.c        |  4 ++++
 xen/include/asm-arm/psci.h    |  1 +
 xen/include/asm-arm/suspend.h |  1 +
 5 files changed, 25 insertions(+)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index aa1f88c764..8857955699 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -957,6 +957,9 @@ ENTRY(efi_xen_start)
         b     real_start_efi
 ENDPROC(efi_xen_start)
=20
+ENTRY(hyp_resume)
+        b .
+
 /*
  * Local variables:
  * mode: ASM
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 0c90c2305c..43a67eb345 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -25,6 +25,7 @@
 #include <asm/cpufeature.h>
 #include <asm/psci.h>
 #include <asm/acpi.h>
+#include <asm/suspend.h>
=20
 /*
  * While a 64-bit OS can make calls with SMC32 calling conventions, for
@@ -68,6 +69,21 @@ void call_psci_cpu_off(void)
     }
 }
=20
+int call_psci_system_suspend(void)
+{
+#ifdef CONFIG_ARM_64
+    struct arm_smccc_res res;
+
+    /* 2nd argument (context ID) is not used */
+    arm_smccc_smc(PSCI_1_0_FN64_SYSTEM_SUSPEND, __pa(hyp_resume), &res);
+
+    return PSCI_RET(res);
+#else
+    /* not supported */
+    return 1;
+#endif
+}
+
 void call_psci_system_off(void)
 {
     if ( psci_ver > PSCI_VERSION(0, 1) )
diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 05c43ce502..a0258befc9 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -161,6 +161,10 @@ static long system_suspend(void *data)
         goto resume_irqs;
     }
=20
+    status =3D call_psci_system_suspend();
+    if ( status )
+        dprintk(XENLOG_ERR, "PSCI system suspend failed, err=3D%d\n", stat=
us);
+
     system_state =3D SYS_STATE_resume;
=20
     gic_resume();
diff --git a/xen/include/asm-arm/psci.h b/xen/include/asm-arm/psci.h
index 26462d0c47..9f6116a224 100644
--- a/xen/include/asm-arm/psci.h
+++ b/xen/include/asm-arm/psci.h
@@ -20,6 +20,7 @@ extern uint32_t psci_ver;
=20
 int psci_init(void);
 int call_psci_cpu_on(int cpu);
+int call_psci_system_suspend(void);
 void call_psci_cpu_off(void);
 void call_psci_system_off(void);
 void call_psci_system_reset(void);
diff --git a/xen/include/asm-arm/suspend.h b/xen/include/asm-arm/suspend.h
index fbaa414f0c..29420e27fa 100644
--- a/xen/include/asm-arm/suspend.h
+++ b/xen/include/asm-arm/suspend.h
@@ -3,6 +3,7 @@
=20
 int32_t domain_suspend(register_t epoint, register_t cid);
 void vcpu_resume(struct vcpu *v);
+void hyp_resume(void);
=20
 #endif
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417691.662489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfJ-0007lF-FS; Fri, 07 Oct 2022 10:33:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417691.662489; Fri, 07 Oct 2022 10:33:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfI-0007hE-O7; Fri, 07 Oct 2022 10:33:12 +0000
Received: by outflank-mailman (input) for mailman id 417691;
 Fri, 07 Oct 2022 10:33:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkfA-0004PE-Bo
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:04 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b0945b6-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:33:02 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297AP2K0008629;
 Fri, 7 Oct 2022 10:32:59 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:32:58 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:53 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b0945b6-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ibfhsYYdwntXZQnBsEEZH07IVCGQutu+fulxcY03bRKtWq2k3/V5MhCMOCBJYuNF12P+8shynttQKmQC/CrR6Tv9l9IhLntQPJI0uw9cAb2TKEXyYnMQ2Ujd+BySNVUP2smaIVIQsZU2JTy71NyqE+wnHKuOQjnXkGA2RZSAk8lpuKmf13KUspRlxYY+nf/49x1alWp9JCGtXV7g60259flrbiEPA+Pu5i+UkBiviGXn8oQR9aCRePdJMoHW7IHs/0qW6dw+pPrxRdnYWS+4kjeLgpfcVPBoW6JB9d0l4yF4vMYS4wqdsL3Ra7zbpgynK4KgSia05q2HMOVN8jwqaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qtlCpwNec1h3byQgM+ugllxAri/F4tEk+BYv+hXGX2s=;
 b=TpH8Xi2K8ZBH52IqpYWiiK7mQo96o44SnTEm2dJr5lLzWAF9E50cL5BqPb08VWQm92eUpqrm8qlyyB9teer0aFniK9eCuABMsq7PqJyuB+t9loWGG4uOv+6sPtWVoE3lacUXcOmlZuT2FkkayV7fXPYpSjg5c4FIMTtrkbmKvzjjJ+/G2xdfpSkQbI42tQgdQRqGXTXhuto16eApBCfd0gBElx4hS6wnSxW29T7kOYqEqWhzJF5fJZR8PKEwHjka8mO55x220lIdd0YWQ7Iy4YNwHio0uPliympcAWaHXFQsMcyzgQhrkX0BQTvLrll2lZo7I0GCREBEJRIlPRVCsg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qtlCpwNec1h3byQgM+ugllxAri/F4tEk+BYv+hXGX2s=;
 b=ViHIOe5xUhnvm4UpUy+0zWkpDhc1VIdhwklb75v/cb3pZ46NBw/FRIC00pKVRsg9JCCjsNNW2+/N0jGzLAMIjK19l3gJ6SUqGntQH/L0rJmfIM0XiPFHa/oE/Sx+A2UR7lwA/2fWR9sW0qJixqjINCDZqdwxZtATTX+6jzRgRYo3q9aJfqAdhVe439fLGEROVQ1HyPvXwYUa5EN3he8ghl7Uc+8gxhY8Czfj5lp5V3R+HC5n9+VE8hjVZnAPv7vhMI/CKg/Upv2XFUrEXsYZsw6L0L2zObFMmeoPr4P4iOwN22a7OAm6Amk8+1qTdSq4jKSJrKN/XHFhyOBOhmj1Fg==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta Poturai
	<Mykyta_Poturai@epam.com>
Subject: [PATCH 14/19] xen/arm: Save/restore context on suspend/resume
Thread-Topic: [PATCH 14/19] xen/arm: Save/restore context on suspend/resume
Thread-Index: AQHY2jgmlOzu00YIlECkxJuKgOBIPA==
Date: Fri, 7 Oct 2022 10:32:50 +0000
Message-ID: 
 <dcd3e1ae475a478cd6f639c528565492b10e0f22.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: 862e9cc4-9561-4990-c20f-08daa84f4a88
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 0x502QPj0hMyDLvr1yo5DwQpWc7Q+PYgxW2WJ4Z5iKTZQSt8E+MoQvZS+Vp784cOTvowMl85DG6z48jD8iC4FVTTxZUFSgtwaeoiPs49uN9j1mvDdIYdtxBOjIOV6wxqg0PfOH6enHpGU2OaoWgxxUae3GahJeOMRPUFuG35Qr4Fto8eMJiruOgM2JRe0Qsgp9Zd120zFM4V7q2PaO9Bg26G2PZPEKA3u4qlt9prYZBv+xjoj0gVPHaIEwJUmBNkbeHcN2brF4wwOni8vDBlAaTkmmyMezbRPsUBkMsTiYMXBrmvUlfZrMXIgnJUasmLbbtIVEZwhaR7kNdV0FLx742z7yR1Tn7rlmAcU64qfPkcjy+mjjamnoLJEL/KAf+yCrP4HcELhErG5w59NzWI2jmUO7cFI+xAU1kj7cEafGIoeBz8UECuKkhezCa+fjIXsObESwo2hJy09+bqR2pCHEYPnH3x9Lo0v7+t7MRUw6jrh3xsJoGA9ZZqdIsT0Wgk+F6scwwo6BSUH9okfp/LcA8wnY9SoUcLAWAawYAM9JrcdIdk1zQjgautWBUECLkOJwHG2dJM+wHlMDQYxLxmKTwm7I/FRPauIYCJ6FOv97o1Gr/GjnRRrrc71oDdxzEq3Jn+KXxvLXKcUX0SrAAhxRHobWxsQxtjJ5+ItSs6Zh6eiwnx/D+RLhY5T74VkjxjJG2Tmmbi7gtZPHJMc2El496Vn1d0HvQQbsOEhhbv41FM/BoS78YqVPBxEh+eNrXRkuChuM5NhRPaT1FVF0f5Xw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(107886003)(38100700002)(38070700005)(122000001)(41300700001)(15650500001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?TUJJFM8iulQjEAxS1oZ8P/GTaPPO2SmGCysMVxPjsPDRjM8VAipjSzjr7f?=
 =?iso-8859-1?Q?/rCuWR+J7rP89No7prIojxJrKHjIBj+gC1pipStLtVYgTBUPQtbxpmTe8p?=
 =?iso-8859-1?Q?eBGTWmgn+l6mmfTfQkIhW6I15bzG6KcgSZdfv/hIYrAIBVp/1b5ZTy0q6G?=
 =?iso-8859-1?Q?Yh1vrkl1tcfCVQT0rNhZxyVziuAlX5pz16tDI4QZrFXbz6ACE29It3fYfM?=
 =?iso-8859-1?Q?gNBECvkveKXmsfWvBLPYENs3tu4PCqlXrb/e6mAt/VtSviQzU8a/KNip6w?=
 =?iso-8859-1?Q?G7Wovn4CoDbzT/RTtz4Y3dPJRrIAseU12TdmVNt7RGkVG3QDOpXdiudc0l?=
 =?iso-8859-1?Q?2so1d/Cpt0LWSY378SU1pNWuDAhpqoEcbWqlkpDX5sIXeeCW5BnSIT0NAE?=
 =?iso-8859-1?Q?qy/H2tOKmQhE2seiYi/5VudVUe6wNUNw7X8GBzzpCkqaCbyVspe1smew1m?=
 =?iso-8859-1?Q?txeMugSt7AxJ+ClnUvICgCVUAJtcdGc8OCaTbmuE0t8KUjcv+VHME0PnyT?=
 =?iso-8859-1?Q?5HnRtb1lQr+HY4JFRj2yg5mYOCSsxRGZ9l/zH/mzS2A/m/+gkKc+nt4haB?=
 =?iso-8859-1?Q?1RLg3PtNfvSvKGDiEh/wDYfkVdNp2AWJRtjahz4zw2i9VfbAggUBDrk/2C?=
 =?iso-8859-1?Q?VU+zpjltZJsO962IjNk0Zu74/KCr1QaaatgE0N/hZQzB3htYHo0fp+QMBo?=
 =?iso-8859-1?Q?bjTZMFMCkkZdeh9eQTkW2mcoG3lT/lATRGQsqEm3UG5Ynysc3g+tzNIBeF?=
 =?iso-8859-1?Q?aoV4u2hhac6mk+pGNF2Q9fuzEaQ7dV0VBbzos1OLO0+EA0S4TSO2f28s+F?=
 =?iso-8859-1?Q?goPv0sOS2E4ph+XXiJMMLJH50dqmRqleQGph2DX1oVHxyWz2Baf5NUs0ku?=
 =?iso-8859-1?Q?6k+iXjDJDDUbe/ZWUJyORctZN/ECtOWW/CBSjzItl9V8PGMfOw4bzC22QP?=
 =?iso-8859-1?Q?6aBnSPckBMylAXmcEJ4Vs8N4djCFAAj4mi4SVzn0VOLfMfEuf37OCI1o+p?=
 =?iso-8859-1?Q?2CcxhgAixxXV6sf4xUsvAGPS0uVLpQsPad04t0mwwsvTlyZJOGEBNzgAKy?=
 =?iso-8859-1?Q?+bCkJPpfjkIdaOrwG0YSEkCjO7AW+94ZwhvC0e8VnOl+miAVof5kN1WcFl?=
 =?iso-8859-1?Q?Rpou05xBzTo2EH8rtBLDHTtcbSRlGwvlhGqGIvkJRcCZzUQnXQgEY8Bzdq?=
 =?iso-8859-1?Q?KOkgntmi0PKFzc+Es4JU7u3B56B0gIzTetwhb4ZVVl9rlo0W0rKuwArBbb?=
 =?iso-8859-1?Q?+0ICGhAgbpPqjUHAED5bIVJrMEv5CYXVcroW0jgUhUSSmmJqBfZ/hH9j1q?=
 =?iso-8859-1?Q?PQ40MevpHCyq0K+yHpuamMtAh4nL35Zdn8Yb2V8gNYjaLxFAsFqUALT7ly?=
 =?iso-8859-1?Q?30/Hq5kuHllPx08EvW7sFGEVoM7Vqizh2sZagTxwUt4Wcjnl9wfWcCCHts?=
 =?iso-8859-1?Q?Pz5QmSKCiLpVI9NZS9VVzFIpJBkZX+Vw8uqo1u+K14EENGv/G7/gSrpt3E?=
 =?iso-8859-1?Q?NFuvSmtbtt9XfEvQKImU2zzL07adeh76qxPV+Dkz920b0s9otQQ45WG5FK?=
 =?iso-8859-1?Q?S8+IBHg0e9kNlwibcr65f1vGZXnj7g5PzOPzMUkOo0RVUByC4lUeXBkUcI?=
 =?iso-8859-1?Q?ONMJwZ5zuRoPlEO1m7oDsbnKHeAACR8jvrBVuFcW/KnYmNSnwC1co62Q?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 862e9cc4-9561-4990-c20f-08daa84f4a88
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:50.3176
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ChvD9ncS7t5VfK6E2svzSxDtxWU7d6voFF6fSLxCIJZwYg1wVjUks+dtXZL0Ulrw+zybJ04N4BEScUmKOmDhoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: E6J9nHyzx4eMTdd_FuS4TnqQ8wPF960w
X-Proofpoint-ORIG-GUID: E6J9nHyzx4eMTdd_FuS4TnqQ8wPF960w
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=641 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

The context of CPU general purpose and system control registers
has to be saved on suspend and restored on resume. This is
implemented in hyp_suspend and before the return from hyp_resume
function. The hyp_suspend is invoked just before the PSCI system
suspend call is issued to the ATF. The hyp_suspend has to return a
non-zero value so that the calling 'if' statement evaluates to true,
causing the system suspend to be invoked. Upon the resume, context
saved on suspend will be restored, including the link register.
Therefore, after restoring the context the control flow will
return to the address pointed by the saved link register, which
is the place from which the hyp_suspend was called. To ensure
that the calling 'if' statement doesn't again evaluate to true
and initiate system suspend, hyp_resume has to return a zero value
after restoring the context.
Note that the order of saving register context into cpu_context
structure has to match the order of restoring.
Since the suspend/resume is supported only for arm64, we define
a null cpu_context structure so arm32 could compile.

Update: moved hyp_resume to head.S to place it near the rest of the
start code

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/arch/arm/arm64/head.S     | 90 ++++++++++++++++++++++++++++++++++-
 xen/arch/arm/suspend.c        | 25 ++++++++--
 xen/include/asm-arm/suspend.h | 22 +++++++++
 3 files changed, 133 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 82d83214dc..e2c46a864c 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -957,6 +957,53 @@ ENTRY(efi_xen_start)
         b     real_start_efi
 ENDPROC(efi_xen_start)
=20
+/*
+ * void hyp_suspend(struct cpu_context *ptr)
+ *
+ * x0 - pointer to the storage where callee's context will be saved
+ *
+ * CPU context saved here will be restored on resume in hyp_resume functio=
n.
+ * hyp_suspend shall return a non-zero value. Upon restoring context
+ * hyp_resume shall return value zero instead. From C code that invokes
+ * hyp_suspend, the return value is interpreted to determine whether the c=
ontext
+ * is saved (hyp_suspend) or restored (hyp_resume).
+ */
+ENTRY(hyp_suspend)
+        /* Store callee-saved registers */
+        stp     x19, x20, [x0], #16
+        stp     x21, x22, [x0], #16
+        stp     x23, x24, [x0], #16
+        stp     x25, x26, [x0], #16
+        stp     x27, x28, [x0], #16
+        stp     x29, lr, [x0], #16
+
+        /* Store stack-pointer */
+        mov     x2, sp
+        str     x2, [x0], #8
+
+        /* Store system control registers */
+        mrs     x2, VBAR_EL2
+        str     x2, [x0], #8
+        mrs     x2, VTCR_EL2
+        str     x2, [x0], #8
+        mrs     x2, VTTBR_EL2
+        str     x2, [x0], #8
+        mrs     x2, TPIDR_EL2
+        str     x2, [x0], #8
+        mrs     x2, MDCR_EL2
+        str     x2, [x0], #8
+        mrs     x2, HSTR_EL2
+        str     x2, [x0], #8
+        mrs     x2, CPTR_EL2
+        str     x2, [x0], #8
+        mrs     x2, HCR_EL2
+        str     x2, [x0], #8
+
+        /* hyp_suspend must return a non-zero value */
+        mov     x0, #1
+        ret
+
+
 ENTRY(hyp_resume)
         msr   DAIFSet, 0xf           /* Disable all interrupts */
=20
@@ -988,7 +1035,48 @@ mmu_resumed:
         tlbi  alle2
         dsb   sy                     /* Ensure completion of TLB flush */
         isb
-        b .
+
+        /* Now we can access the cpu_context, so restore the context here =
*/
+        ldr     x0, =3Dcpu_context
+
+        /* Restore callee-saved registers */
+        ldp     x19, x20, [x0], #16
+        ldp     x21, x22, [x0], #16
+        ldp     x23, x24, [x0], #16
+        ldp     x25, x26, [x0], #16
+        ldp     x27, x28, [x0], #16
+        ldp     x29, lr, [x0], #16
+
+        /* Restore stack pointer */
+        ldr     x2, [x0], #8
+        mov     sp, x2
+
+        /* Restore system control registers */
+        ldr     x2, [x0], #8
+        msr     VBAR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     VTCR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     VTTBR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     TPIDR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     MDCR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     HSTR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     CPTR_EL2, x2
+        ldr     x2, [x0], #8
+        msr     HCR_EL2, x2
+        isb
+
+        /* Since context is restored return from this function will appear=
 as
+         * return from hyp_suspend. To distinguish a return from hyp_suspe=
nd
+         * which is called upon finalizing the suspend, as opposed to retu=
rn
+         * from this function which executes on resume, we need to return =
zero
+         * value here. */
+        mov x0, #0
+        ret
=20
 /*
  * Local variables:
diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index aa5ee4714b..13d1aba658 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -133,6 +133,11 @@ void vcpu_resume(struct vcpu *v)
     clear_bit(_VPF_suspended, &v->pause_flags);
 }
=20
+#ifndef CONFIG_ARM_64
+/* not supported on ARM_32 */
+int32_t hyp_suspend(struct cpu_context *ptr) { return 1; }
+#endif
+
 /* Xen suspend. Note: data is not used (suspend is the suspend to RAM) */
 static long system_suspend(void *data)
 {
@@ -161,9 +166,23 @@ static long system_suspend(void *data)
         goto resume_irqs;
     }
=20
-    status =3D call_psci_system_suspend();
-    if ( status )
-        dprintk(XENLOG_ERR, "PSCI system suspend failed, err=3D%d\n", stat=
us);
+    if ( hyp_suspend(&cpu_context) )
+    {
+        status =3D call_psci_system_suspend();
+        /*
+         * If suspend is finalized properly by above system suspend PSCI c=
all,
+         * the code below in this 'if' branch will never execute. Executio=
n
+         * will continue from hyp_resume which is the hypervisor's resume =
point.
+         * In hyp_resume CPU context will be restored and since link-regis=
ter is
+         * restored as well, it will appear to return from hyp_suspend. Th=
e
+         * difference in returning from hyp_suspend on system suspend vers=
us
+         * resume is in function's return value: on suspend, the return va=
lue is
+         * a non-zero value, on resume it is zero. That is why the control=
 flow
+         * will not re-enter this 'if' branch on resume.
+         */
+        if ( status )
+            dprintk(XENLOG_ERR, "PSCI system suspend failed, err=3D%d\n", =
status);
+    }
=20
     system_state =3D SYS_STATE_resume;
=20
diff --git a/xen/include/asm-arm/suspend.h b/xen/include/asm-arm/suspend.h
index 29420e27fa..70dbf4e208 100644
--- a/xen/include/asm-arm/suspend.h
+++ b/xen/include/asm-arm/suspend.h
@@ -1,9 +1,31 @@
 #ifndef __ASM_ARM_SUSPEND_H__
 #define __ASM_ARM_SUSPEND_H__
=20
+#ifdef CONFIG_ARM_64
+struct cpu_context {
+    uint64_t callee_regs[12];
+    uint64_t sp;
+    uint64_t vbar_el2;
+    uint64_t vtcr_el2;
+    uint64_t vttbr_el2;
+    uint64_t tpidr_el2;
+    uint64_t mdcr_el2;
+    uint64_t hstr_el2;
+    uint64_t cptr_el2;
+    uint64_t hcr_el2;
+} __aligned(16);
+#else
+struct cpu_context {
+    uint8_t pad;
+};
+#endif
+
+extern struct cpu_context cpu_context;
+
 int32_t domain_suspend(register_t epoint, register_t cid);
 void vcpu_resume(struct vcpu *v);
 void hyp_resume(void);
+int32_t hyp_suspend(struct cpu_context *ptr);
=20
 #endif
=20
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417692.662500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfL-00080V-PN; Fri, 07 Oct 2022 10:33:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417692.662500; Fri, 07 Oct 2022 10:33:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfJ-0007wl-Tx; Fri, 07 Oct 2022 10:33:13 +0000
Received: by outflank-mailman (input) for mailman id 417692;
 Fri, 07 Oct 2022 10:33:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkfA-0004P4-HN
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:04 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bc43563-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:33:03 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297AP2K3008629;
 Fri, 7 Oct 2022 10:33:00 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyg-4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:33:00 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:54 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bc43563-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=luFEI+qQMoIWiYFBrabotg1JzwDYEbP3HlDTqs0Bsfs3D3yPzeT88AmvMgejj+QjaVOGJHAJhe/jGHHgs4WD6S44VlmwHM3zMMJxB9kqUFCeQiOy5yT36rFvMNzXylr/KI23NhUak5dnowduj92vQqVsY6/dgTIQn/P4Xhw8d0ZFzFFNJlRXzUMKCRBi4jnilLoxaTNjzVUADUunImNBYBx90Q9BsLDX3lRt4GOpP44kAHLWS98cZh9ft84Zryhd+ODww+6vDbZQBHVkehd7a8phbCf1rMFhfQ+Y2RMii+uWIbYQkyMLYcXikhvR7bsFx6EjG9Q7A00WTZBrx9X5bQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l/O4J5C7W0TXxhhwyyXIZrFFLgHA9mzwFIl98tctyyM=;
 b=JAH1/Bf9hBO1EmYjWG96fVbWUs+nTMXc+529YFhxZGTvTgW0DMJuIXCg8MlsnO7TJnHXJP3VTDpGYm/dDzz0ph0xsmdLY7MCMP0qa0Kv0bwXeOpwoDL4uD6fqLauzl4vhrQ74iZCpNaPAMeZgX4Pj/FoFeyvf/iILe2BL3Fmg2nzZdJc0uNRR+Y9cUY4b1eeadln25T7m+aAzJS9jgj8sm4Oe+B+2BYzRCHwgiFizCcsNAirFVuGsfS2Eep/ol/CGBvGf459Q1YjvdrhYeeKzTeI8+Ai1Mfnz58Hzh9sGQ01uu9Lor24wRZDDJmnIFEXtw+EOFCJkyb0RWRZmjws3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=l/O4J5C7W0TXxhhwyyXIZrFFLgHA9mzwFIl98tctyyM=;
 b=YePPQsBvjVYnDInnG6sujRFYOc7LbmeNlyv1BaRqiv3nPYx7YK5gHJ2QKrGbAmlIia+lYgGr24upEW3OMhR4nrlJ5q5GP+BAF9bN9agEkTCGRtE3sp+WgwjuSzlrq4K+boS6u5Ap0bjBBu28wU6Tc+5Ie3/boLctreMjJiixyj/rLQsVA2j9QkVFykPQsfk32WKci3hqAjh1/FO8xVmOctGv+nbm4d8vd7nC/J7UwR7y5Zy4FrVc0u4hD4zZEPDqdn48EORtl+by/SrrVyCORVJ50dz583IJDf5ogGQoojiLvwYU1i5VIBapNyv6Ux8jzkrNMDGpW+sk2mKSiA9Quw==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mirela Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>
Subject: [PATCH 16/19] xen/arm: Suspend/resume console on Xen suspend/resume
Thread-Topic: [PATCH 16/19] xen/arm: Suspend/resume console on Xen
 suspend/resume
Thread-Index: AQHY2jgmltStcpUKEUSAkPaRlzuavQ==
Date: Fri, 7 Oct 2022 10:32:50 +0000
Message-ID: 
 <a3dc2fe24f8f474a3976f4b307a693e359e910d5.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: 7b8c9611-5c07-4ff5-cc51-08daa84f4b17
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 zwMCtSxttXwEff5MqwTdTSd7zmw6E5kEBzmGspGVpb4T7K/OTK3+/2dGPET/v8Bu701mRt/LypzvU4VyHjeQptFUz8MeiEAIdVULNpBCqsRBt2QU4Zs7x6s6QBl25zPWoi69k6AJa31JeeD2qZRFGU3gRaK9xJkns1QCfvH0U7tPA3Xg3y4mWOuCs3vw/getRcraUY1H23Uxrn778gQ8qaCpyJlNYtMhOvg1p3lI2XQIqDsPU/AeFAzvZGTTU7snsDx8AUI2pDPyAy/4HNY/mhZbIxiGTVJSAD/ENKGoIlk+wRQa+rgmpmSMZOqEAtlHHDXidrTQyuFXpT7QYzHEfptQDLiwtZAMmUYdJY4VjBq1Ox+c6v2q6OuEgM7Vr/G4GpQtLON1r6TkTQa5mf7+qUR1OA8Gg1Jhu2/ovqY+o4s3JqShvx4SLn/0mrvSKwilQtIA9Crngp4Ljm511unUmtE2uqXDY87LG6NJbAa6zgfz+au2CXCu8kILFB5QiBwojhWBENpi/BACa6wv7MxA9dk74sgXbs6kEwYntjgeCso/ywuQ57vq0Ie5aBp+Z1Vy3/KNXjXSCH2NUNhI7gV/ZVXWubedIe42AYgRtd7OHhx3cOutgn003hrxnLz74OW876MQ8KIXp8iijM+doVqSX7CxfKOIR3hW6hq942/1yQOGB4Np35R3B6s3kDyDUhgsYLa9ZUhuErpRpqbKBhVM7tgqyNI15twG40lnQuy73BG111+KVLlcBs/0PPJ2zn+Q0Ekvzbbb+NQUzTe93PBxNg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(38100700002)(38070700005)(122000001)(41300700001)(15650500001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(6666004)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?RLP+jj4iA39jVfIQJ9bTcMB+i/97uN9tZODvEdGAvt20/qVbnoknpKlI+Z?=
 =?iso-8859-1?Q?+YxjHAJNQ02PeX13rB0dojn2+rZod/ELVRoktoY3G4gxTSQpn8unitn+ic?=
 =?iso-8859-1?Q?HvrAISqjEeaMufsvWZr47tp3xrOKDPZq9Js9qcetJfFGOrRzrGM8jcwXEQ?=
 =?iso-8859-1?Q?Dp5+MmY99V1si/Y1o9O/mcZQTmy8iS5ohUvNxlmkTKOcAlGLTqz+4wqeq2?=
 =?iso-8859-1?Q?12RGJzGOK7VGd3HljA2kH9UiVxfZQJ63st+NMGwj11eZIMhM1CazOf6a6q?=
 =?iso-8859-1?Q?RiJJdG9h23N8T2nzJeZv6Vwnkd5h1ajg3ZMIB3EqSclB83c7UtQ4340avp?=
 =?iso-8859-1?Q?mj9jLB52NNTBK0uew5Cm66qB/ic+CoXFfb/O0pHgqjHe4xeo6la71H/CjT?=
 =?iso-8859-1?Q?pObWHWgXU/ic2fuiEm7ufcV6IlVpBlXOwJHD1zLxsKd8+wZKjuLI52ooFn?=
 =?iso-8859-1?Q?73OihRrVnPCCN1PSeZWmERrYqIaUvPfPiLANQyqkO+Q19jJQpzfZ2875Sg?=
 =?iso-8859-1?Q?VZimFqIaFu5dPKLyj8LyuZD+L5VEedAP9znHSSuINhk7ZEIrOtFN9Ni7KH?=
 =?iso-8859-1?Q?N24Fpsyha71faRrVHegJ9Dln+puLOtinqFFUyaL6JZaA27BXO7nv64BbF/?=
 =?iso-8859-1?Q?5McWq1Aji6jhjzienrN3M+FdWbddenwddZhseOF5wU1f6qjHyXJHjMAdhZ?=
 =?iso-8859-1?Q?eC5xBRP2S5CjLBynQuacDp34aSfVPrqx5XrjEoB1lFvp0p6oGOVjdk46U0?=
 =?iso-8859-1?Q?268UriiP3amZiA1gZET3okiM2nUWQPjWs1Clwzr4ypMG1JKz4BzdMxpwMv?=
 =?iso-8859-1?Q?RC+1krLHCNIoiwDvs8Wx4EQRcbcxGVNggKyZZIj8DwK8YJny/nHQEWiE4U?=
 =?iso-8859-1?Q?yOrk3OpsNpDtjproQvqCxTBkOzdUDiExPkVVYsjRD7iErxA2wSLKEDfd2i?=
 =?iso-8859-1?Q?6m0ON1UEYzKJDt1WWQ4r7BHuY+l7nKjqSfWr5Cer1bUkYS51UUc9cABx8h?=
 =?iso-8859-1?Q?ClInbQndvoShz6Ten2OIrMoRxIXMzUVppVY5KQQ0SbVEG+FA1Y84hCzr0j?=
 =?iso-8859-1?Q?e762K1m9vt8fJGUulK0UXxzkjWqiDLjSE2l46yO7vJIp5CWSMBr2KL66K0?=
 =?iso-8859-1?Q?lLRFqpwDGuZKSOZ/8uZVPfo40ju7jOTTb9sya0M2YMjNubiYs0jKA+Fzuu?=
 =?iso-8859-1?Q?26qNEoioWaQt4KSUOs4jK7F13G5T5KzeDsCqxUF0MvPK7ElXlHP5JWAqTL?=
 =?iso-8859-1?Q?RPDCbfDb0+7+yaiL3/x6fqFMwMzxbkNFalBqmypqhe572tCcrkH3vN+53A?=
 =?iso-8859-1?Q?0HLjnuuY2ZO0cRiYYGUXE9Rw4KJsEPF5FSys7KNTh5SsgLBTo7hsI+5+Qe?=
 =?iso-8859-1?Q?AIFd00jUM61xwJfOb0UD5C7fcmlN6j2+VxzYseyLUIEOlIzJc1EIcrkNRb?=
 =?iso-8859-1?Q?/KrpM2VSC7QoKBjeZOC/KKl6vV98Rc+FeTReVkwtHVKEB3SFHuOaRqUHSf?=
 =?iso-8859-1?Q?ZHXevN9J1j36lYPAuI1v3N9JNEB4B2oq/HOp8aUE4yGMjLSNxT8S2xl0Q1?=
 =?iso-8859-1?Q?g5fsuCjHG7QxXr+Eut2yOnkPS5trfRPE/bCWpFhm3/h5dzc+N94UBPQIvZ?=
 =?iso-8859-1?Q?0zC3ES8bDrzJIz0o/on9BsJWsz47YXB0DpXBw46HSYf4o31KBbTQZ3CA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b8c9611-5c07-4ff5-cc51-08daa84f4b17
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:50.7863
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: P9wDr/WWKnLegaxkz/yvxyESAyLGyoPKiLCIUKJeSXoAT0hwlv14aQWVjolQs/w8K1cz8tXybqcN7vEGZ1k3Gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: ooEga1gzhCCwLWDCb3ycrn8mnY-708Jy
X-Proofpoint-ORIG-GUID: ooEga1gzhCCwLWDCb3ycrn8mnY-708Jy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=718 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Mirela Simonovic <mirela.simonovic@aggios.com>

This is done using generic console_suspend/resume functions that cause
uart driver specific suspend/resume handlers to be called for each
initialized port (if the port has suspend/resume driver handlers
implemented).

Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
---
 xen/arch/arm/suspend.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
index 4a690eac3b..cf3aab0099 100644
--- a/xen/arch/arm/suspend.c
+++ b/xen/arch/arm/suspend.c
@@ -14,6 +14,7 @@
=20
 #include <xen/sched.h>
 #include <xen/cpu.h>
+#include <xen/console.h>
 #include <asm/cpufeature.h>
 #include <asm/event.h>
 #include <asm/psci.h>
@@ -166,6 +167,15 @@ static long system_suspend(void *data)
         goto resume_irqs;
     }
=20
+    dprintk(XENLOG_DEBUG, "Suspend\n");
+    status =3D console_suspend();
+    if ( status )
+    {
+        dprintk(XENLOG_ERR, "Failed to suspend the console, err=3D%d\n", s=
tatus);
+        system_state =3D SYS_STATE_resume;
+        goto resume_console;
+    }
+
     if ( hyp_suspend(&cpu_context) )
     {
         status =3D call_psci_system_suspend();
@@ -192,6 +202,10 @@ static long system_suspend(void *data)
      */
     mmu_init_secondary_cpu();
=20
+resume_console:
+    console_resume();
+    dprintk(XENLOG_DEBUG, "Resume\n");
+
     gic_resume();
=20
 resume_irqs:
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417693.662508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfM-0008Hz-Ja; Fri, 07 Oct 2022 10:33:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417693.662508; Fri, 07 Oct 2022 10:33:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfL-0008BO-B0; Fri, 07 Oct 2022 10:33:15 +0000
Received: by outflank-mailman (input) for mailman id 417693;
 Fri, 07 Oct 2022 10:33:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkfB-0004P4-Hm
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:05 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c133096-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:33:03 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297AP2K4008629;
 Fri, 7 Oct 2022 10:33:01 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k208bupyg-5
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:33:00 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:54 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c133096-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EkzCvlc+0u3GZIlM4U++d39+MIe3yuwa1arWJwKL+3AwyZjJz1HsX6FTU4rfDwW2DsXezKGGNCpjvCyV6UnjcWW6RTLSdMhz9iJu8TzD59muekLSTImpIf8K4rLQ9wbwwbr8E0BEyIFQutC37dG1pspzb811xdUJcsw5qbxP36ie81DYH/KUsPiMLQ26ORRJsIF66XmrA9qe298uM+RuVfZqVPwqIYUtkbZo6UPCWEz2QoJmhlf7H1SpOi2yHfsDqlxRa50xq6ggcS6Er/OMguXECcsWboJHdbiMo/qqfhTzKLMKqWBxRUzNzK8+/+Cp52KMCNrkQLZ568+77ayhzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1qf6AA5NEbLzd3qFM2Qjj9M0bqVZ+Q4ALQBxoGny/l0=;
 b=LXv/oSQ38HhL8GAMS9Acsrxdzq8iPJqeX238udgugmjX8Y2vsH8aOs5qAORBS9O3h6UbjKnRnqm4Fil2I5PhyPlQVXN2xTIna5MQWxw9XH93f9ZVUuQJpTbhZCUFyPdIQf74gp1NTbwXDYBSMlIMDHWkoyZ7HKNW+oni7Pv62ZncpLmEIrXD5M+msgCWc9+etwTaLG9d/fbiOaFo/+MFZ+csM/XvGW6thGV/KbzJO4yR8QuTy1gZY511c30uE2hQxQZTeqxW+tc0D5GYhOsKNhgGNkIPpwxZg4cYqrsIkqqAPsBWzk74Ot44bKQN5Ox70im1CuOZAVdwlV0PUnSI4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1qf6AA5NEbLzd3qFM2Qjj9M0bqVZ+Q4ALQBxoGny/l0=;
 b=GbI09yOSyvti6P1XF3wPuFtkpeJ71/dAsmkJ9bef2mNDHQdZ/Z/ElZzYt5W+atA9OyD2BvzBE+AjB0RrxBNoaISF45LXbE45txztezoaFmtmzlzXFXABH5tL09l2HLA6aLo1Ag2vT4OgA7A2pdzpWgSylj4eoGul2xhTealuzzOpAQiIMUCIZwVxO4FoUF2uCh4QG2tzNaA7Orfd9iwiQrm9fU6U1+yzb/UW0XD/SBhU0D5FWgEP+g5jESudjY9SYxUQ3VsYFf3wavNg2rfBkZjnoxW5g3h5zbum/LPdWedtMxy8fdd0CBKBEBxK+Lv3T8ZLsRx5jtoiBzJRnwPJ+A==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Juergen Gross <jgross@suse.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH 17/19] xen: don't free percpu areas during suspend
Thread-Topic: [PATCH 17/19] xen: don't free percpu areas during suspend
Thread-Index: AQHY2jgm2f/PHlobT0esfUs820FvAw==
Date: Fri, 7 Oct 2022 10:32:51 +0000
Message-ID: 
 <37f0f84cdaf47b1efda59f0368998183dff88a3b.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: 1a3b279d-d328-4aa1-0180-08daa84f4b70
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ecDtL/g2qwre5mJv9NB+s8+t/bQP6twC5yIdumgmkS8Veb/LS7u7ghQQVwIDHa8RgJO6WszmUfSOej7n6b2HCx9I6hVnsZHfD6Q3Vsv/+sn88sj5Imz2oACYwZrbuGkQXTZ+rZ4iJ65++Mzl0vfAtusQHdzZpH/ZPXSiv1t1cyRvmOPid64zIawhvVqpzpyftZCuJ+LF4XrPFdB2Gg2bWruP+C643FYTJcMTgZ2JXa2g2ysJo66O8kcnhAFFrNiU7k7cyNGcwi7oh0WBgTqqf2bG+MW1J0Ca0ZRyRBfp1P9zShbVvuZnx6JbXEqK+TJQj/+64YMr2vzqkMX1lRyozGJ7feSmTdF4QfgBA5N0NTARzpWdS5qQM75wC831fWN1KPqesIP249pdFYReEUiNldQIRUIecn5ZURv6tBRmAuFmZPSNg8kA7wQvOTBsvh9dcMIxzsK8uVE6WIZa1tA1agDqmkv+mARrDME8P64IwX/hp8mIvnKW9Dh+JDWXai+46O9Q9CKfmoo/7qYybA7kzRtg3Dorjs57TGQo3BKVy5UmpASUsa6YYOjYs9jlUafy6xEem/s7hNTju9peKc9CKk8K61QSKPFH5T3vzMOfHVZHE61tXXCzDd5ay5mzdaUBncK0kr3StsgYmt2xX9rAjTYip4S3uP3uf/P2QjVKJe2NgZt0UThzKmv6Hw+y4idxlloHUnw44Lw9uNmoo88hUdiGfy3q1c27jwdupUlH6fSWV4c/r7HwQtl3IdeX9F0rRvY9Ep1f3YN68dSLjkjmDg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(38100700002)(38070700005)(122000001)(41300700001)(15650500001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(6666004)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?4MbiXlJGER0tbGljFkS4pt1Fd/RmOH1dLF7UMyBPhGvuGHtbgEtR1xMnvG?=
 =?iso-8859-1?Q?HpWghb7BZfO/RnK7Hi/9RqdZV0P5Io3aiwnVgxc9Ob8XLabUFTJN0foAfC?=
 =?iso-8859-1?Q?PH83wRhkYUGjJNdqH9ylt+byjyNM7UvHpbEEOCy33dsV+GuUYPwA4Fln+9?=
 =?iso-8859-1?Q?+uGoWQDKN/0fSne1Hvb9wsJcbEjS+tn4TUopmz2B57wrP4vsDksUPcy56b?=
 =?iso-8859-1?Q?aSiP4i7Yi1id6XNnsagAwpsfzxciOoNYoRqndDWu2HsQmd57jMFg479KH8?=
 =?iso-8859-1?Q?6oL0qDHEGxhhUxpa/sCKa+kFTwhahU5uze1XG1enRtPkwzxrjmgVseRnsb?=
 =?iso-8859-1?Q?T07+9EQVkvCNZDAEKc7Ir5CDj6l4QXyzQF9eY06rRJnwm5iU9IV5CzzY+8?=
 =?iso-8859-1?Q?oCamRHhNvrPFh2AFSap4lrKEZSaELShrLmDqt7/D+CJIF3/nfuc5Yegdke?=
 =?iso-8859-1?Q?n++of3JKKdHvw5P0gVCWVPdqIcU9I2v4XSkPmDOoj96iBE6A8h1YdbV6LQ?=
 =?iso-8859-1?Q?poIbH/V/RjA0l8Zq2HtE5q+Bo5xgMqlCb1YVASoC2PKoNuVHJK4QpAEXDs?=
 =?iso-8859-1?Q?9p5ZyybZfeZ7SyTTIzseRiytqsCEQkqli4rxoOwheGGl/dlTjEbQMuwp0B?=
 =?iso-8859-1?Q?pRN05mhpWYxqn/+JrCc747BR/3X0zYU1L3NcipatvjDfRFgw2i0EFA8Mmi?=
 =?iso-8859-1?Q?LMSzHay5l46nah9oiipwBYQDIawd3QWwkeTN9+HqnyeMvIGpayZ12HgfE1?=
 =?iso-8859-1?Q?kKGNqiSyJXfkXm0x+PorCdNpipenabY4MS6o1J0GE5ZNi6dIDp/NNcMKr4?=
 =?iso-8859-1?Q?//Wx4brYbR7DoS6EnNdvYE3ftZSlUDFQgv4vgwH3o+W9eSuu3z5Bgp2Xw8?=
 =?iso-8859-1?Q?BCNJgnrv40+1UMYSNJU66NMBpBkRR+NrhsWhfR1roSBis9Nez50xvhuFOs?=
 =?iso-8859-1?Q?H2dTmWcHXmnAxHT7X2FiM0X7R4XQTNx1zWeXrjXyjnoz9tpquML69MtG4x?=
 =?iso-8859-1?Q?P/Z9uLS3HQLB4gPXP9NMGvR1Bru9nifyR6MxWRp5QRgGNYE4/6x96raGLu?=
 =?iso-8859-1?Q?ELhzK2AzVPCSoBxeeBDeyTwx1X9WA7//Mn7MgTdpAKcRCU/HeQtIYm7HzO?=
 =?iso-8859-1?Q?Wg1oGpIHkE3WEwb6Ta11io1uQGpwN9RjdKDHXOTwP+nlVOCWwRbtEU+Tis?=
 =?iso-8859-1?Q?YTf5SeAgIaYu3bEpsy5x5pPbF/VeXC9dOE3NNYEwkY8a8u0UEHUjmkyr2E?=
 =?iso-8859-1?Q?xu4w8uKBXtBf12QSgbWGvRugDePoVlZtUhPf9r4QF7Tb4zGID2qSszk6ux?=
 =?iso-8859-1?Q?UpOhOiuUnTTrBO5tiyb4zYJUR8Uuuf5MV0x2rhdOtEW5FYPFAdtErDdBJi?=
 =?iso-8859-1?Q?w0+UThKATf7NOiLTGxfCAecnADLj5NLeTSo+Ub6q8KsgzcW6QJlIsP7gH6?=
 =?iso-8859-1?Q?lGm6p+yMJMFFZf6lK6oLeGUavxzSA/kQv5Ml2Yl4nkBqsApzYEvJ87LSu7?=
 =?iso-8859-1?Q?v3/mPNWy/Hs5omAkSXt3iy/KoQViCXP3qYjCJoMsVGEb/L13avQZwFEWJx?=
 =?iso-8859-1?Q?KulrhoLXQiOzrXZV93hdt/gnNkq1i55kJ81C6gbm5kK+WYo2sJw6vhM26E?=
 =?iso-8859-1?Q?IY8SblL5elyzsU2IMScRLHK844LUcb5fA6ezerspU4miEAbmqiM42s4A?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a3b279d-d328-4aa1-0180-08daa84f4b70
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:51.1144
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dEb6R4VpY/RYY/cNvU3to79x337wq1wFh4C2hxm9rsaemQNH7fWwtVvG/uLgANyC9FfTtQn3/Z4LOJ3c8f94SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: UQIPysAdlfJtbKMRG4rWIHYIYuX7nz6j
X-Proofpoint-ORIG-GUID: UQIPysAdlfJtbKMRG4rWIHYIYuX7nz6j
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=814 adultscore=0 bulkscore=0 suspectscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070064

From: Juergen Gross <jgross@suse.com>

Instead of freeing percpu areas during suspend and allocating them
again when resuming keep them. Only free an area in case a cpu didn't
come up again when resuming.

It should be noted that there is a potential change in behaviour as
the percpu areas are no longer zeroed out during suspend/resume. While
I have checked the called cpu notifier hooks to cope with that there
might be some well hidden dependency on the previous behaviour. OTOH
a component not registering itself for cpu down/up and expecting to
see a zeroed percpu variable after suspend/resume is kind of broken
already. And the opposite case, where a component is not registered
to be called for cpu down/up and is not expecting a percpu variable
suddenly to be zero due to suspend/resume is much more probable,
especially as the suspend/resume functionality seems not to be tested
that often.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
---
 xen/arch/arm/percpu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/arm/percpu.c b/xen/arch/arm/percpu.c
index 25442c48fe..0642705544 100644
--- a/xen/arch/arm/percpu.c
+++ b/xen/arch/arm/percpu.c
@@ -58,10 +58,13 @@ static int cpu_percpu_callback(
     switch ( action )
     {
     case CPU_UP_PREPARE:
+      if ( system_state !=3D SYS_STATE_resume )
         rc =3D init_percpu_area(cpu);
         break;
     case CPU_UP_CANCELED:
     case CPU_DEAD:
+    case CPU_RESUME_FAILED:
+      if ( system_state !=3D SYS_STATE_suspend )
         free_percpu_area(cpu);
         break;
     default:
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:33:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:33:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417694.662516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfP-0000K5-Kk; Fri, 07 Oct 2022 10:33:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417694.662516; Fri, 07 Oct 2022 10:33:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkfN-00009B-Ii; Fri, 07 Oct 2022 10:33:17 +0000
Received: by outflank-mailman (input) for mailman id 417694;
 Fri, 07 Oct 2022 10:33:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkfC-0004PE-5X
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:06 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ca99de2-462b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 12:33:04 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978NNsj005811;
 Fri, 7 Oct 2022 10:33:01 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjkh-3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:33:01 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:55 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ca99de2-462b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T64OjVtm3V9WvNNZTS9emRi5y+HDGGsaqVUze/1lhYyxnJV/JoJXdkE4YXwcVA3B1B6Dilvgmn9GTycvLygx86ciLc12Sf92U5UAbOvgM/g6eqthlLMqvuuLE43zxanU6+0hixxRUBW4QmH3HwzrUb2JFvRd7cL3hxphchvJ7DA4cCXrTIOMJpE4TIyrVaBsH3ErtSfrcauifVOBsgwfVrwekJ6dBKOi4ZGpDa/RrArVFUT4Y7bVpPP73SmWKQHOIWsQXu8g4Nuu/u7tkL6EQxYUpyDFnaAOXJxhqXKRm+E+lM7PCc317e2jfRNXutVZ6WAxGE9Z6JIO5U1lUnVKxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KDUUqGmmMNAG4mTJPMtkYc8B5YGTFxvyMyBDVzdOMKI=;
 b=gq9WYCp/NbPM7Ly9nfE35SqGfK6BTRNTP4PVwQfMXrxly/UOMSUP+RqFtuLOXNChhE0ZjkEoQfaXNGjIsVGS14eNsKQ9MQjLCCOVPW83Je89tdX7bZ9c+W0mWrhHIufeL3hHM3SoMLNiWJyTNKN6S4mXkBH0VQqFPT8CK1kyYa16qt2Y1JOhUedlYqTtKUKM00kZsXo5aytc4qe/I6IZ0F5Cldp3FVI+jIOlxuwzNejQFX+8FnucdJyeO+bAchJYhLfBvPbHjjap7FD3Is3aw8BDDNW0hntSsOmCp7a5udeXIKtlA+a/t1ODFUJ/EcrzsBFh2YuAAJKLf9kM2e41DQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KDUUqGmmMNAG4mTJPMtkYc8B5YGTFxvyMyBDVzdOMKI=;
 b=gNSQRDAbomcm+RO+8dQM2qcZG24WpwwTMnYEa/G0lUVPeh9DfF1ef6F13BYgCmBv0/xdx5M0ILw9Nhq+fOrvSHDiZ0+glzDJoRrx/1m87DHfBO+vO7jDmNwHpCcutKgaYLKWD2gP/wK+2O9P5qxEemYY8RIwLyJop8M2RNELagHQCm9LWh6z1b9EeRtwfbYVBm+L17fOEgAG8zHf4ex8yCrP4NlHtXZbk2A+5/2URGF3Kf6p/o5IGYdhJAbs3B0uu7IinE3amsESsH+I/SGB4QwW/Pg1VLuhHNSBchIXz9QFtafpU3IJzb5S6vEab64tW8teb5QFdxGEPaNC2A67Nw==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mykyta Poturai <Mykyta_Poturai@epam.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Ian
 Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
        Julien Grall
	<julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: [PATCH 18/19] timers: Don't migrate timers during suspend
Thread-Topic: [PATCH 18/19] timers: Don't migrate timers during suspend
Thread-Index: AQHY2jgmyMa3fIhJ3kaXCccflKz0UA==
Date: Fri, 7 Oct 2022 10:32:51 +0000
Message-ID: 
 <babd4e0c615c7f61c10b53ad884c68c85641ce7c.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: d1a6733a-ddbc-4b13-7224-08daa84f4bc3
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 qhThAvot0hZ2qZOvfHDhLVPIZcs55UpfR8kXvT6x2ugvG7MVe1DM1jDG9wXeKC72NKVDWWFsIq+QS55HoUuNhd6E1bo8jzPv9naf0lVVg6mN+hffVmLlCC0s7ZePWEkbr8jKTeaXuvZdnIKdlp5Gkoux5FLnvj2OuET7kic9SAxO3fV+sMARiBCgpSNtI8xOQtClnE10KgD6FMIFmdZEncPPe6o2e/zRRY/sP9sCPGkPJodMs3NgJHkyu+MdO6NtJL17+/YD30AkzBHp1hdS9amo+kdSxLD3/voUkq1b7ZwrZhgNDuKGl8ZhQ799q86PE0GeMcY+i+OfC1456ntZF9Y6X9b7f71TBex8+D85tawWz2gmRc41Vh0csDFm9lW5LypSvTGBnm9HPVDUHQQfPyBGNYJveA3zjygAStLCgytgusOTlOjiFBVnB9zFWpzM3GV77gnixh7hn5mdEeGMIviPEqiVVl/q0Y/Ls0L1fBKNzZOkkAU7U503Re5u8W+ncKtqPdSIfo8+mieZs4JEu8qn3no/o7Pe/0Us9lUZELTPMUw14nMEZqxLA0zq2N4ul93EKGgXo2k9QM6i3vLLeiCvttldS8f0/16VYdvY9mXLVxzHQEVSbHJqU4o+axxxTjmqczOIlMDSxoQAmHGur+/tefZxFFuCKeMF0/sKCyhzbCQS4WXZiFtvBeBKM+iswlw9Z8mkbsqQdJGjkEX7+DzHRcCHmcDOlhDzG0z6Ir6vAywDIR5x6E4J+kNOWKTkrHcye0tzmI+95dypnDJbDA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(38100700002)(38070700005)(4744005)(122000001)(41300700001)(15650500001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(6666004)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?VhxYmrOehPdgFlfOgQitxyCTq7wQF8+7elGwEDiDr8USCbijgnPI1g5Fdv?=
 =?iso-8859-1?Q?aZdnhzaTXOsehlZJ+hp9UMYxEo4RnzgUifjoTJznKyzrqXVXXNyNHk9QpG?=
 =?iso-8859-1?Q?RXQnUwGtfvcvJmeMz3AeL2+llhTLQ5a30sqc4+0NojJJsDUa2kKp715OYI?=
 =?iso-8859-1?Q?Vz780N57HiVNB5+SM712ZNw4FWlz1ayGupVDhBpkx4vuwzu24Lemx+VYih?=
 =?iso-8859-1?Q?AwcuxaTZkmo1uXIX0delVu1FM1CGxFTYh8MM4nY7UlP4OjqIIUxqEInuPZ?=
 =?iso-8859-1?Q?DSyEqkq0dgCq9gWijuuVPz0aozzlHGoix1MYUg92QaeCPxUmx8SC1jqcbr?=
 =?iso-8859-1?Q?R7zE5AsxTSqVk6VEDLtlar4au3jCO/NRV7RSKm147y5kK+lT7sODzHxM6q?=
 =?iso-8859-1?Q?UYROMZF2ZlautDoNsIbU1BIHsBh1vofh581jPOchFEmfJX3zMJIniJFApO?=
 =?iso-8859-1?Q?liUsCfBGPuLlrXaHExtRAUDiGkSafUEEC9hfvaMWLaqD/IEFbv1fSeEV2l?=
 =?iso-8859-1?Q?7Rp955xlQXQ7tFs3NzyrScx2Ke28J8TMCM3Zak9VzEPhB4acxXrS59ze2F?=
 =?iso-8859-1?Q?7mb1x1f+ihj+J+d77QCsiNSaVTJ6mtSfqdbmSdZY1nFOex6RQzIPXvq3RN?=
 =?iso-8859-1?Q?F6JZ/V2Y95z8GL7ZFbL2OTUJKHHwZRDwC2VhkutAirEJeP+uqg9ZzAWupF?=
 =?iso-8859-1?Q?n5gJsfBVyb4IRWdEn+AxlmzfWViA1L6c2lDTfnGrLkbKwZ67CXwSXHXeWA?=
 =?iso-8859-1?Q?LE5IU/9FjvyCk3A9NyWJDsERJHjCLkqYGnPBXPwOtUCnETMsxWO6aDKL1M?=
 =?iso-8859-1?Q?+EWRAk8zNMgFINzlnY6dnxfma/lyzZREykseNOvkXx5VhrjlM8NYXsryQc?=
 =?iso-8859-1?Q?4jCW9Ds7P4cdMN5bG8/h84k7dlIuHOsD1rxdVJOTqbEKFuF+6KIX/zDU67?=
 =?iso-8859-1?Q?p4pCyKKmk9d7qaHIpbQ7zxujlptlN3YN+86O6k3k2Of4gRY8Z4X4uwhfci?=
 =?iso-8859-1?Q?V035AYmWCwO7PPTgcIH7jBBaXRp0M/So0iPle2BZ0vaNw+hd7Gr2lE8FGN?=
 =?iso-8859-1?Q?igKtdkZsAnvJoNpH0VlXwMUK0XU4IS9sKfZqO84MILS78AXRtueIb8tOLU?=
 =?iso-8859-1?Q?Rt4YFnXgXb+j6YVMed+4Y2m3IoISey85ISAEugSfDaSadnQaibVu11yQjg?=
 =?iso-8859-1?Q?O2neYL7LUmOKllVqYyPaBXLOARIQywf4AfLqJg8kuDC1e7DvPrCgiGTfOB?=
 =?iso-8859-1?Q?VNSfO7LXBZOwPpOBxKtha6D7I352qTIIeDdp+GwDsMzNVVWcUJexHGtXVJ?=
 =?iso-8859-1?Q?R79r0FPahjL5czPmB19rCFLA+iNIOaVKeXuZcR3JDCXqmPIBiLgYDOJNfA?=
 =?iso-8859-1?Q?9tB4uUXOBKdab0tNuq4zNq4prBp1mMCTAnLqyMKqIoewH1uq3iFVI5YTLB?=
 =?iso-8859-1?Q?5Gh8Yb3IvDuBccUKdGH/lAwK+rFXep9q3CxYQ/4aOZMbL8PsxQUJ3lGEzy?=
 =?iso-8859-1?Q?adSe+8RjsJbnFBPF393SIU3DvmAqrg26XI7UgdTyHZuCPy7AIvzPlH6heN?=
 =?iso-8859-1?Q?C7rDqYm9RqOXFvPUN8tRmeeSNMf0UlFVKy25CywpGpfsFFC+Mn5oyg2o2Q?=
 =?iso-8859-1?Q?18K8TJsSRY3QRD9IiBqfXgBLEk9pls//93ddOGwqqs4yOmhmpyhGpnxA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1a6733a-ddbc-4b13-7224-08daa84f4bc3
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:51.3488
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DG08n13QpatWoKkmwjJnmJQp43yRmV5trG+yhp9MxVbzLmln1CWYk4D0LwXmiCW4EnwhQACXVrSEFY9HNqSOGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: _cGNbPPqbK7KDTZSIkFIGcKBo-pypn5x
X-Proofpoint-ORIG-GUID: _cGNbPPqbK7KDTZSIkFIGcKBo-pypn5x
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=667 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

Migrating timers during suspend causes Dom0 to freeze after resume.

Signed-off-by: Mykyta Poturai <mykyta_poturai@epam.com>
---
 xen/common/timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/timer.c b/xen/common/timer.c
index 1bb265ceea..52d4f72a76 100644
--- a/xen/common/timer.c
+++ b/xen/common/timer.c
@@ -658,7 +658,8 @@ static int cpu_callback(
     case CPU_UP_CANCELED:
     case CPU_DEAD:
     case CPU_RESUME_FAILED:
-        migrate_timers_from_cpu(cpu);
+        if ( system_state !=3D SYS_STATE_suspend )
+            migrate_timers_from_cpu(cpu);
=20
         if ( !park_offline_cpus && system_state !=3D SYS_STATE_suspend )
             free_percpu_timers(cpu);
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417754.662556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkh6-0006K2-5w; Fri, 07 Oct 2022 10:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417754.662556; Fri, 07 Oct 2022 10:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogkh6-0006Jg-2i; Fri, 07 Oct 2022 10:35:04 +0000
Received: by outflank-mailman (input) for mailman id 417754;
 Fri, 07 Oct 2022 10:35:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogkfC-0004P4-Hs
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:33:06 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c6718e6-462b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 12:33:04 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2978NNsk005811;
 Fri, 7 Oct 2022 10:33:01 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45sjkh-4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 10:33:01 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by DBBPR03MB6716.eurprd03.prod.outlook.com (2603:10a6:10:207::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 10:32:55 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 10:32:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c6718e6-462b-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CWT3s26VSGqyXcms9St4R/XUityLrInIk5MZlN3XZz10iqoT3hVanldJP4gQ0GkLvXUuITPwyQUN/cHDgI9inhzLJmP+t5C4Wfrj7aqs4/ebJBrWfJjn5xtbr8M24BDyHiru4G+Yjub4fUx3NCj9boschDcZHCCjbSSDB5plbk7Ecc1N+dBmPezQHiZ1YklXhNTtkUG/M89idIN05HC7lBBptNHFPHzq9zMx3riv27ctdm7yzzXsyMH0REDY9H3/QQieGnLdwCtSNwl5jjdm0SgjL/E6oWNNcGmQF2oyN8ZB6dV7VZTMp0Q4K1XAhn/W4JEfspd4s8h/uw5qqXNNLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LofU4NA3DawFyk2dVbhjW4yKNwCVyZvZ66lYuYxwLoI=;
 b=JMtMioPJe1B03XUJOZNENMofJKf5wCl6jBnIabmeqEfolCiHOAmzUXc/AYhtWBndToQn0QjfVCbOewqczkDS+OcsVlRS+waKPDbKwJ5nbO1MBu0SdyjsyX6OLVFsmk4ogNIipOKooZkUzcMbTIaFseXKevGb19BYuTsNaB0MFbiSZFebDu8YEB/4VzqGBprdBdynYjiFRCFrhnHZmGuQSsDITuXSs+ykCO06mIh16uFirlhZOdRhH53JjxQsHyYWZojO+T3lwxZmPcRtJZo15P/4gdoRT0hiESs0kHmPpLrAJ02LRYkw1x5G20lsc/YKGf1UumLVcnil9VmvH+iu3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LofU4NA3DawFyk2dVbhjW4yKNwCVyZvZ66lYuYxwLoI=;
 b=IDNDG154Pz3sbtTSoRWFbYz/dgIdkQKogB3YolpiueP8557aH4IYstavK0JyhqdQD5QT20U49qCs8X51+V5UQ4t3vayFIC3WBTVHe0wDKbpMwQwKSdY1HGWa4GeeqUGALDQDamn120Wt3XQE7q2/DuKN+jW1R7BZa9ecnnIbmXZq8ggd1HyjrriehZxrzoOXQblLUpRN0/0egWTbp7WzxIaFEX91lGXck+b0KV8UUvmNMbUTpCYe6PZZ+8pJLU6fEj2fUUBWgkngzlP+aln0c+ky5aUY8YOvIuq39d5WfXgGyn3oZSxVXYJmjErR9uq4fMjN4Yb8uYLWD+pb/9FRrA==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: [PATCH 19/19] Fix misleading indentation gcc warning
Thread-Topic: [PATCH 19/19] Fix misleading indentation gcc warning
Thread-Index: AQHY2jgnAfaSu/bn4UuiKd5XD6+qwQ==
Date: Fri, 7 Oct 2022 10:32:51 +0000
Message-ID: 
 <3575d33c0520d3117e1d12af91f1b1e31a2571c2.1665137247.git.mykyta_poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <cover.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|DBBPR03MB6716:EE_
x-ms-office365-filtering-correlation-id: abec2b40-7fd8-4bb4-f751-08daa84f4c0a
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 tlH/fdOsmn4nYkjP3EK8R7ZZe5uPvAgO++zNArokAicUU4BZt3zoIbiRGytKF5UFffC5gSJrQnpD0VgtkVqs+v/MMJjdnG+bIlQ6vG9bA0UOyC4mRb0eqU7wbZ9UjElA4yWKR0A65J44GmPKfh8QxxdJtOvFhrnK4CnhL4lAStQFf0uAxaASbn8DeOdqEcAVlGKcoHEoGiPFklL7julPEX4f90iSeEfOMFsNh0R4aukitTkxf7bGY1ANm4jGq3rB6Ps7xOOUziwoikGMYegUYgVA6JK0qW6LZ2zU1d0RvFXhRUSgBOfz5RNhmksKpA5QvIuU/PJs/dJV9ofRvYpBpNcg3+Zai7zu2pO61EK82iEkhRy1ZoOYKIEkFVRaFPsKK5H4YYvf5HVSaQ6wyeokSWX6rwVIMj/Fe5hWzZhKL9JtPtIJ73qbq13xnXrZzsW3KSbH1u6HX7HW/5H/WN1giw37uspduAAH7heBL9i94ijcuMkytkVYzjSNgqSCwHQwPmA12y7nv2niT1Wh131skqzm1TSO0zOBKSFSV8ruDfTX2bkuYaQkOvu5HRkU1vmHaNb/Nyd4DD4cSgOFZs2k2SazeGTb3cml9fVBUGUrWNRSlM7h9TUonQ7pCY+VcLu/kR0Z5xu7UmzAQmVh065+ncKiLKXt0gV/fNVrYD2CR32IhVPQWCTrpZQ3Ba1CaG5D3wrGmCTx5HGICSUoStKMFjGBQUxHxrEywCCBcALdLFtOcptM5O+iUPvYpxVKBj3OU6lL/39j9Ci9KfWowlI3rw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(2616005)(186003)(83380400001)(38100700002)(38070700005)(122000001)(41300700001)(2906002)(5660300002)(8936002)(55236004)(6486002)(26005)(6666004)(71200400001)(6506007)(316002)(478600001)(8676002)(54906003)(76116006)(91956017)(4326008)(64756008)(66446008)(66476007)(66946007)(66556008)(6916009)(6512007)(36756003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?amxEiVVwlw/Tyw5cAwYXsb5SMzWB7tBddv1qLaYbpxej7hTsix3/T+zNfa?=
 =?iso-8859-1?Q?oMroMfUmdCDDjTI/oB0xMxPhf6VFLu2P2CoXtTd+WkHaE/5iKn/rPK12KM?=
 =?iso-8859-1?Q?UBUlNSuFr3eAJfNVnFlJqI0jMGg/1AALsNmowvrpdag6ZVJV5UTggmUxg/?=
 =?iso-8859-1?Q?nEUyYl2NSHNpWtVPjp9tePEhXkCAq7Vzf9GhDSoONNb45Kl7Y02k3gYPbR?=
 =?iso-8859-1?Q?Xx+5nm3Gol47oyF1aJ0BG4eER6PTRjc9nf4fp99LzJ38TdM7QFZmBefGA1?=
 =?iso-8859-1?Q?AAv/Dj+5FpS5SDRcXVGnU50aBNcdjtA24QTMncy7+J4Lu4nRCI7hIHmeAG?=
 =?iso-8859-1?Q?iSwJDoEp7XWBij2Mmspx4s6oyS0fmwTTj3DP960fJJcZpe30eJBfiP001T?=
 =?iso-8859-1?Q?kSk2Lf5xoSkGN+yueewBFFmAiPmEROnobNY52TaSQEvDmHDIMRvHRPn1S+?=
 =?iso-8859-1?Q?esF6UCCPZAgjwQqkV0CLLfpMoTV2lN91WpCcE78HScguhJINXiZC9glT7S?=
 =?iso-8859-1?Q?KME7qBD9dszZRxf3SObod+U8XVWUo3HJ7j6qta9BTgWwrgHE0B9MAJStOY?=
 =?iso-8859-1?Q?2KhOnkR4pqbNDU7pAheOkwJUCSXt+7Xvt332WSt0EGqDenCjoYd7r++VVM?=
 =?iso-8859-1?Q?hVZ5+2api8d9fYAQxHyebQpf8Nv1kYoagVoP6TIAXutELAU9Kc/pXD8PjG?=
 =?iso-8859-1?Q?ycbpcgrzVvI8iaJZlLfW/COMz6r57loMXCo0FDTA5d84hm5uOKKJf4XkPz?=
 =?iso-8859-1?Q?3hkJ/zdZWWP4AlQRDFa/F2JDuav6Ox8vG428E5B0VpHwktML34LYMCrypI?=
 =?iso-8859-1?Q?GIIL8u2R3bWTxT/zczGJhstQvfUs9QRrPzIF7Yp1BmpMfDliMywVUrSGxw?=
 =?iso-8859-1?Q?NcCWmK6CYBXFD8YkOOQQKYB8MA/PenCp8R/MILhisf+ZSTqP80hQd0t2NC?=
 =?iso-8859-1?Q?LgXopwUc/Lt/0ChIEaLTIajmo4oIOtKXer6al87L7NJMDw87mu6/W6Y6qs?=
 =?iso-8859-1?Q?277O6VHzNt8a8xZ9Oenfzt+zbAVUHESsdYCRqaAKYY2EjQRmgjqhiAT3P8?=
 =?iso-8859-1?Q?ed13qhJ4abNR9v+jVG+Si7Zz/qlJTGvLxUJl9PW9JLFSjY5Sb/XUfpnWF1?=
 =?iso-8859-1?Q?Pglbsjguuvsnel+lNz95QmjybtR+YmAvDMbbz5J2e+D58JD/gsLcwwCd2O?=
 =?iso-8859-1?Q?25pYei51neTBXaNKsv7byadBU8l+2CFHgM7qmJA/JJ1f9ApWxNcBwVEt8W?=
 =?iso-8859-1?Q?BPKwVLzZ7KYl+66TQNVveUkd+5+UtJ8wTQR9lS6ebmY/kXdDluFWjdPaXG?=
 =?iso-8859-1?Q?cwB/uKFmlEFagkLrG03ioeSd8K3jysQ7OdFXW3e4yinWkmlCFFDn0uBET0?=
 =?iso-8859-1?Q?TH1FwOk137iihoAwp/jdZdCebvzYmSjmakoV7iy5T0CG8nuWgEow4CdDg3?=
 =?iso-8859-1?Q?gTl5R2F4njwju5tKK8VDQvnARTebyvzPqqn55i1BWFmj/nC/2z8wjZX1a8?=
 =?iso-8859-1?Q?ikuKXzqVJ4jYNlFFl5TfU+F2w4vw25r/UbU+qzBOccqKsS60CxSg4+n01f?=
 =?iso-8859-1?Q?cEABlfWAme0F5OSrlFDdy+cPtY3MdZWtETAXR22s5eXCOgm/r5LPcVcSDh?=
 =?iso-8859-1?Q?kAudaHKWM3XElz1PQ9MbwzhvPZneEcIsbE251Lgob+g5qByL+6RCvTVA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abec2b40-7fd8-4bb4-f751-08daa84f4c0a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 10:32:51.6613
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bKlwnRLLwrbdglDBAt3Y4KSWZNoM2DI5omo9rP3RQGozzmuvlcMb2mh1P4SNTGratpdtwNOsjkyXwRY0mEEhjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB6716
X-Proofpoint-GUID: G-sUujTgl5FdH89U_W09UyYYZjLoIQUb
X-Proofpoint-ORIG-GUID: G-sUujTgl5FdH89U_W09UyYYZjLoIQUb
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=709 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070064

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

percpu.c: In function 'cpu_percpu_callback':
percpu.c:61:7: error: this 'if' clause does not guard... [-Werror=3Dmislead=
ing-indentation]
       if ( system_state !=3D SYS_STATE_resume )
       ^~
percpu.c:63:9: note: ...this statement, but the latter is misleadingly inde=
nted as if it were guarded by the 'if'
         break;
         ^~~~~
percpu.c:67:7: error: this 'if' clause does not guard... [-Werror=3Dmislead=
ing-indentation]
       if ( system_state !=3D SYS_STATE_suspend )
       ^~
percpu.c:69:9: note: ...this statement, but the latter is misleadingly inde=
nted as if it were guarded by the 'if'
         break;
         ^~~~~

Fixes: c3109b76d967 ("xen: don't free percpu areas during suspend")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/arch/arm/percpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/percpu.c b/xen/arch/arm/percpu.c
index 0642705544..9eab1e6d7c 100644
--- a/xen/arch/arm/percpu.c
+++ b/xen/arch/arm/percpu.c
@@ -60,13 +60,13 @@ static int cpu_percpu_callback(
     case CPU_UP_PREPARE:
       if ( system_state !=3D SYS_STATE_resume )
         rc =3D init_percpu_area(cpu);
-        break;
+      break;
     case CPU_UP_CANCELED:
     case CPU_DEAD:
     case CPU_RESUME_FAILED:
       if ( system_state !=3D SYS_STATE_suspend )
         free_percpu_area(cpu);
-        break;
+      break;
     default:
         break;
     }
--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 10:59:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 10:59:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417854.662584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogl4O-00027C-G4; Fri, 07 Oct 2022 10:59:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417854.662584; Fri, 07 Oct 2022 10:59:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogl4O-000275-DD; Fri, 07 Oct 2022 10:59:08 +0000
Received: by outflank-mailman (input) for mailman id 417854;
 Fri, 07 Oct 2022 10:59:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ogl4M-00026z-A1
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 10:59:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogl4L-00080M-15; Fri, 07 Oct 2022 10:59:05 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.20.83]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ogl4K-0005iJ-Ky; Fri, 07 Oct 2022 10:59:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zWi1CwmeiZ3088j4C62vU4t0ZJKlHSdHJSLoLfq07F4=; b=U+uCWfB1WGynQBLKR2zzTVews7
	gPCdo6WgZl4eNuXZ/Yr3IRejTo+f6/snhSSIEgcqp/1TiYyWzJaHF5MH6zWaSyz1Ibb6p3aMv6zMn
	dyW6oK5lVtE2jIv9BmguuacT2fVMAEHADpsyToHyn/jjVMXB9jjpbvTluE3zIwVwTn7Y=;
Message-ID: <a24447f1-4011-365a-24c6-cb448c2cb43e@xen.org>
Date: Fri, 7 Oct 2022 11:59:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH 01/19] xen/arm: Implement PSCI system suspend
Content-Language: en-US
To: Mykyta Poturai <Mykyta_Poturai@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Mirela Simonovic <mirela.simonovic@aggios.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
 Mykyta Poturai <mykyta.poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
 <598de284f5f133a622eca3e120a1aabae0f2a1e2.1665137247.git.mykyta_poturai@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <598de284f5f133a622eca3e120a1aabae0f2a1e2.1665137247.git.mykyta_poturai@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Mykyta,

I couldn't find any cover letter for this series in neither my inbox nor 
xen-devel. Can you provide one explain the goal of this series (you seem 
to have a mix of domain suspend and host suspend)? If it is also based 
on an existing series, then it would be nice to mention it (this would 
be helpful to look at the existings and check if they were addressed).

Also, we are currently in the middle of the code freeze. So the review 
will likely be quite slow until 4.17 is out and I caught up with the 
rest of my backlog.

That said from a brief look, I see you included a patch that was merged 
around 4.12. So is this series actually based on staging?

If not, then the first step would be to rebase this series to the latest 
staging.

Cheers,

On 07/10/2022 11:32, Mykyta Poturai wrote:
> From: Mirela Simonovic <mirela.simonovic@aggios.com>
> 
> The implementation consists of:
> -Adding PSCI system suspend call as new PSCI function
> -Trapping PSCI system_suspend HVC
> -Implementing PSCI system suspend call (virtual interface that allows
>   guests to suspend themselves)
> 
> The PSCI system suspend should be called by a guest from its boot
> VCPU. Non-boot VCPUs of the guest should be hot-unplugged using PSCI
> CPU_OFF call prior to issuing PSCI system suspend. Interrupts that
> are left enabled by the guest are assumed to be its wake-up interrupts.
> Therefore, a wake-up interrupt triggers the resume of the guest. Guest
> should resume regardless of the state of Xen (suspended or not).
> 
> When a guest calls PSCI system suspend the respective domain will be
> suspended if the following conditions are met:
> 1) Given resume entry point is not invalid
> 2) Other (if any) VCPUs of the calling guest are hot-unplugged
> 
> If the conditions above are met the calling domain is labeled as
> suspended and the calling VCPU is blocked. If nothing else wouldn't
> be done the suspended domain would resume from the place where it
> called PSCI system suspend. This is expected if processing of the PSCI
> system suspend call fails. However, in the case of success the calling
> guest should resume (continue execution after the wake-up) from the entry
> point which is given as the first argument of the PSCI system suspend
> call. In addition to the entry point, the guest expects to start within
> the environment whose state matches the state after reset. This means
> that the guest should find reset register values, MMU disabled, etc.
> Thereby, the context of VCPU should be 'reset' (as if the system is
> comming out of reset), the program counter should contain entry point,
> which is 1st argument, and r0/x0 should contain context ID which is 2nd
> argument of PSCI system suspend call. The context of VCPU is set during
> resume path, to prevent it being overwritten by ctxt_switch_from after
> vcpu is blocked and scheduled out.
> 
> VCPU is marked as suspended with _VPF_suspended flag. A suspended domain
> will resume after the Xen receives an interrupt which is targeted to the
> domain, unblocks the domain's VCPU, and schedules it in. During the
> vcpu_unblock execution the VCPU is checked for VPF_suspended flag. If
> the flag is present, the context of that VCPU gets cleared and entry
> point/cid are set.
> 
> Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
> Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
> Signed-off-by: Mykyta Poturai <mykyta.poturai@epam.com>
> ---
>   xen/arch/arm/Makefile            |   1 +
>   xen/arch/arm/domain.c            |   4 +
>   xen/arch/arm/suspend.c           | 182 +++++++++++++++++++++++++++++++
>   xen/arch/arm/vpsci.c             |  28 +++++
>   xen/common/sched/core.c          |   8 ++
>   xen/include/asm-arm/domain.h     |   3 +
>   xen/include/asm-arm/perfc_defn.h |   1 +
>   xen/include/asm-arm/psci.h       |   2 +
>   xen/include/asm-arm/suspend.h    |  17 +++
>   xen/include/xen/sched.h          |   3 +
>   10 files changed, 249 insertions(+)
>   create mode 100644 xen/arch/arm/suspend.c
>   create mode 100644 xen/include/asm-arm/suspend.h
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index b5913c9d39..07dbbd99a3 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -49,6 +49,7 @@ obj-y += setup.o
>   obj-y += shutdown.o
>   obj-y += smp.o
>   obj-y += smpboot.o
> +obj-y += suspend.o
>   obj-y += sysctl.o
>   obj-y += time.o
>   obj-y += traps.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 23c8b345d4..4110154bda 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -40,6 +40,8 @@
>   #include <asm/vtimer.h>
>   #include <asm/vscmi.h>
>   
> +#include <public/sched.h>
> +
>   #include "vpci.h"
>   #include "vuart.h"
>   
> @@ -101,6 +103,8 @@ static void ctxt_switch_from(struct vcpu *p)
>       if ( is_idle_vcpu(p) )
>           return;
>   
> +    /* VCPU's context should not be saved if its domain is suspended */
> +
>       p2m_save_state(p);
>   
>       /* CP 15 */
> diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
> new file mode 100644
> index 0000000000..987ba6ac11
> --- /dev/null
> +++ b/xen/arch/arm/suspend.c
> @@ -0,0 +1,182 @@
> +/*
> + * Copyright (C) 2022 EPAM Systems Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU Lesser General Public License as published
> + * by the Free Software Foundation; version 2.1 only. with the special
> + * exception on linking described in file LICENSE.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU Lesser General Public License for more details.
> + */
> +
> +#include <xen/sched.h>
> +#include <asm/cpufeature.h>
> +#include <asm/event.h>
> +#include <asm/psci.h>
> +#include <asm/suspend.h>
> +#include <public/sched.h>
> +
> +struct cpu_context cpu_context;
> +
> +/* Reset values of VCPU architecture specific registers */
> +static void vcpu_arch_reset(struct vcpu *v)
> +{
> +    v->arch.ttbr0 = 0;
> +    v->arch.ttbr1 = 0;
> +    v->arch.ttbcr = 0;
> +
> +    v->arch.csselr = 0;
> +    v->arch.cpacr = 0;
> +    v->arch.contextidr = 0;
> +    v->arch.tpidr_el0 = 0;
> +    v->arch.tpidrro_el0 = 0;
> +    v->arch.tpidr_el1 = 0;
> +    v->arch.vbar = 0;
> +    v->arch.dacr = 0;
> +    v->arch.par = 0;
> +#if defined(CONFIG_ARM_32)
> +    v->arch.mair0 = 0;
> +    v->arch.mair1 = 0;
> +    v->arch.amair0 = 0;
> +    v->arch.amair1 = 0;
> +#else
> +    v->arch.mair = 0;
> +    v->arch.amair = 0;
> +#endif
> +    /* Fault Status */
> +#if defined(CONFIG_ARM_32)
> +    v->arch.dfar = 0;
> +    v->arch.ifar = 0;
> +    v->arch.dfsr = 0;
> +#elif defined(CONFIG_ARM_64)
> +    v->arch.far = 0;
> +    v->arch.esr = 0;
> +#endif
> +
> +    v->arch.ifsr  = 0;
> +    v->arch.afsr0 = 0;
> +    v->arch.afsr1 = 0;
> +
> +#ifdef CONFIG_ARM_32
> +    v->arch.joscr = 0;
> +    v->arch.jmcr = 0;
> +#endif
> +
> +    if ( is_32bit_domain(v->domain) && cpu_has_thumbee )
> +    {
> +        v->arch.teecr = 0;
> +        v->arch.teehbr = 0;
> +    }
> +}
> +
> +
> +static void vcpu_suspend(register_t epoint, register_t cid)
> +{
> +    struct vcpu *v = current;
> +
> +    v->arch.suspend_ep = epoint;
> +    v->arch.suspend_cid = cid;
> +    set_bit(_VPF_suspended, &v->pause_flags);
> +    return;
> +}
> +
> +/*
> + * This function sets the context of current VCPU to the state which is expected
> + * by the guest on resume. The expected VCPU state is:
> + * 1) pc to contain resume entry point (1st argument of PSCI SYSTEM_SUSPEND)
> + * 2) r0/x0 to contain context ID (2nd argument of PSCI SYSTEM_SUSPEND)
> + * 3) All other general purpose and system registers should have reset values
> + */
> +void vcpu_resume(struct vcpu *v)
> +{
> +
> +    struct vcpu_guest_context ctxt;
> +
> +    /* Make sure that VCPU guest regs are zeroed */
> +    memset(&ctxt, 0, sizeof(ctxt));
> +
> +    /* Set non-zero values to the registers prior to copying */
> +    ctxt.user_regs.pc64 = (u64)v->arch.suspend_ep;
> +
> +    if ( is_32bit_domain(v->domain) )
> +    {
> +        ctxt.user_regs.r0_usr = v->arch.suspend_cid;
> +        ctxt.user_regs.cpsr = PSR_GUEST32_INIT;
> +
> +        /* Thumb set is allowed only for 32-bit domain */
> +        if ( v->arch.suspend_ep & 1 )
> +        {
> +            ctxt.user_regs.cpsr |= PSR_THUMB;
> +            ctxt.user_regs.pc64 &= ~(u64)1;
> +        }
> +    }
> +#ifdef CONFIG_ARM_64
> +    else
> +    {
> +        ctxt.user_regs.x0 = v->arch.suspend_cid;
> +        ctxt.user_regs.cpsr = PSR_GUEST64_INIT;
> +    }
> +#endif
> +    ctxt.sctlr = SCTLR_GUEST_INIT;
> +    ctxt.flags = VGCF_online;
> +
> +    /* Reset architecture specific registers */
> +    vcpu_arch_reset(v);
> +
> +    /* Initialize VCPU registers */
> +    arch_set_info_guest(v, &ctxt);
> +    clear_bit(_VPF_suspended, &v->pause_flags);
> +}
> +
> +int32_t domain_suspend(register_t epoint, register_t cid)
> +{
> +    struct vcpu *v;
> +    struct domain *d = current->domain;
> +    bool is_thumb = epoint & 1;
> +
> +    dprintk(XENLOG_DEBUG,
> +            "Dom%d suspend: epoint=0x%"PRIregister", cid=0x%"PRIregister"\n",
> +            d->domain_id, epoint, cid);
> +
> +    /* THUMB set is not allowed with 64-bit domain */
> +    if ( is_64bit_domain(d) && is_thumb )
> +        return PSCI_INVALID_ADDRESS;
> +
> +    /* Ensure that all CPUs other than the calling one are offline */
> +    for_each_vcpu ( d, v )
> +    {
> +        if ( v != current && is_vcpu_online(v) )
> +            return PSCI_DENIED;
> +    }
> +
> +    //TODO: add support for suspending from any VCPU
> +    if (current->vcpu_id != 0)
> +        return PSCI_DENIED;
> +
> +    /*
> +     * Prepare the calling VCPU for suspend (reset its context, save entry point
> +     * into pc and context ID into r0/x0 as specified by PSCI SYSTEM_SUSPEND)
> +     */
> +    vcpu_suspend(epoint, cid);
> +
> +    /*
> +     * The calling domain is suspended by blocking its last running VCPU. If an
> +     * event is pending the domain will resume right away (VCPU will not block,
> +     * but when scheduled in it will resume from the given entry point).
> +     */
> +    vcpu_block_unless_event_pending(current);
> +
> +    return PSCI_SUCCESS;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
> index c1e250be59..f4e6e92873 100644
> --- a/xen/arch/arm/vpsci.c
> +++ b/xen/arch/arm/vpsci.c
> @@ -18,6 +18,7 @@
>   #include <asm/vgic.h>
>   #include <asm/vpsci.h>
>   #include <asm/event.h>
> +#include <asm/suspend.h>
>   
>   #include <public/sched.h>
>   
> @@ -208,6 +209,11 @@ static void do_psci_0_2_system_reset(void)
>       domain_shutdown(d,SHUTDOWN_reboot);
>   }
>   
> +static int32_t do_psci_1_0_system_suspend(register_t epoint, register_t cid)
> +{
> +    return domain_suspend(epoint, cid);
> +}
> +
>   static int32_t do_psci_1_0_features(uint32_t psci_func_id)
>   {
>       /* /!\ Ordered by function ID and not name */
> @@ -225,6 +231,8 @@ static int32_t do_psci_1_0_features(uint32_t psci_func_id)
>       case PSCI_0_2_FN32_SYSTEM_OFF:
>       case PSCI_0_2_FN32_SYSTEM_RESET:
>       case PSCI_1_0_FN32_PSCI_FEATURES:
> +    case PSCI_1_0_FN32_SYSTEM_SUSPEND:
> +    case PSCI_1_0_FN64_SYSTEM_SUSPEND:
>       case ARM_SMCCC_VERSION_FID:
>           return 0;
>       default:
> @@ -355,6 +363,26 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, uint32_t fid)
>           return true;
>       }
>   
> +    case PSCI_1_0_FN32_SYSTEM_SUSPEND:
> +    case PSCI_1_0_FN64_SYSTEM_SUSPEND:
> +    {
> +        register_t epoint = PSCI_ARG(regs,1);
> +        register_t cid = PSCI_ARG(regs,2);
> +        register_t ret;
> +
> +        perfc_incr(vpsci_system_suspend);
> +        /* Set the result to PSCI_SUCCESS if the call fails.
> +         * Otherwise preserve the context_id in x0. For now
> +         * we don't support the case where the system is suspended
> +         * to a shallower level and PSCI_SUCCESS is returned to the
> +         * caller.
> +         */
> +        ret = do_psci_1_0_system_suspend(epoint, cid);
> +        if ( ret != PSCI_SUCCESS )
> +            PSCI_SET_RESULT(regs, ret);
> +        return true;
> +    }
> +
>       default:
>           return false;
>       }
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 8f4b1ca10d..4e1ea62c44 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -38,6 +38,10 @@
>   #include <xsm/xsm.h>
>   #include <xen/err.h>
>   
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> +#include <asm/suspend.h>
> +#endif
> +
>   #include "private.h"
>   
>   #ifdef CONFIG_XEN_GUEST
> @@ -957,6 +961,10 @@ void vcpu_unblock(struct vcpu *v)
>   {
>       if ( !test_and_clear_bit(_VPF_blocked, &v->pause_flags) )
>           return;
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> +    if ( test_bit(_VPF_suspended, &v->pause_flags) )
> +        vcpu_resume(v);
> +#endif
>   
>       /* Polling period ends when a VCPU is unblocked. */
>       if ( unlikely(v->poll_evtchn != 0) )
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 413e5a2a18..715841e0b5 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -203,6 +203,9 @@ struct arch_vcpu
>       struct vtimer virt_timer;
>       bool   vtimer_initialized;
>   
> +    register_t suspend_ep;
> +    register_t suspend_cid;
> +
>       /*
>        * The full P2M may require some cleaning (e.g when emulation
>        * set/way). As the action can take a long time, it requires
> diff --git a/xen/include/asm-arm/perfc_defn.h b/xen/include/asm-arm/perfc_defn.h
> index 31f071222b..d71e91a5e4 100644
> --- a/xen/include/asm-arm/perfc_defn.h
> +++ b/xen/include/asm-arm/perfc_defn.h
> @@ -33,6 +33,7 @@ PERFCOUNTER(vpsci_system_reset,        "vpsci: system_reset")
>   PERFCOUNTER(vpsci_cpu_suspend,         "vpsci: cpu_suspend")
>   PERFCOUNTER(vpsci_cpu_affinity_info,   "vpsci: cpu_affinity_info")
>   PERFCOUNTER(vpsci_features,            "vpsci: features")
> +PERFCOUNTER(vpsci_system_suspend,      "vpsci: system_suspend")
>   
>   PERFCOUNTER(vcpu_kick,                 "vcpu: notify other vcpu")
>   
> diff --git a/xen/include/asm-arm/psci.h b/xen/include/asm-arm/psci.h
> index 832f77afff..26462d0c47 100644
> --- a/xen/include/asm-arm/psci.h
> +++ b/xen/include/asm-arm/psci.h
> @@ -43,10 +43,12 @@ void call_psci_system_reset(void);
>   #define PSCI_0_2_FN32_SYSTEM_OFF          PSCI_0_2_FN32(8)
>   #define PSCI_0_2_FN32_SYSTEM_RESET        PSCI_0_2_FN32(9)
>   #define PSCI_1_0_FN32_PSCI_FEATURES       PSCI_0_2_FN32(10)
> +#define PSCI_1_0_FN32_SYSTEM_SUSPEND      PSCI_0_2_FN32(14)
>   
>   #define PSCI_0_2_FN64_CPU_SUSPEND         PSCI_0_2_FN64(1)
>   #define PSCI_0_2_FN64_CPU_ON              PSCI_0_2_FN64(3)
>   #define PSCI_0_2_FN64_AFFINITY_INFO       PSCI_0_2_FN64(4)
> +#define PSCI_1_0_FN64_SYSTEM_SUSPEND      PSCI_0_2_FN64(14)
>   
>   /* PSCI v0.2 affinity level state returned by AFFINITY_INFO */
>   #define PSCI_0_2_AFFINITY_LEVEL_ON      0
> diff --git a/xen/include/asm-arm/suspend.h b/xen/include/asm-arm/suspend.h
> new file mode 100644
> index 0000000000..fbaa414f0c
> --- /dev/null
> +++ b/xen/include/asm-arm/suspend.h
> @@ -0,0 +1,17 @@
> +#ifndef __ASM_ARM_SUSPEND_H__
> +#define __ASM_ARM_SUSPEND_H__
> +
> +int32_t domain_suspend(register_t epoint, register_t cid);
> +void vcpu_resume(struct vcpu *v);
> +
> +#endif
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 3b4ed3a2ab..b2f6d1af28 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -903,6 +903,9 @@ static inline struct domain *next_domain_in_cpupool(
>   /* VCPU is parked. */
>   #define _VPF_parked          8
>   #define VPF_parked           (1UL<<_VPF_parked)
> +/* VCPU is suspended */
> +#define _VPF_suspended       9
> +#define VPF_suspended        (1UL<<_VPF_suspended)
>   
>   static inline bool vcpu_runnable(const struct vcpu *v)
>   {

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 11:02:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 11:02:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417862.662596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogl7b-0003ar-3W; Fri, 07 Oct 2022 11:02:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417862.662596; Fri, 07 Oct 2022 11:02:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogl7a-0003ak-W1; Fri, 07 Oct 2022 11:02:26 +0000
Received: by outflank-mailman (input) for mailman id 417862;
 Fri, 07 Oct 2022 11:02:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nDAh=2I=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ogl7a-0003ac-2k
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 11:02:26 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2082.outbound.protection.outlook.com [40.107.105.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 860f91bd-462f-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 13:02:24 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7678.eurprd04.prod.outlook.com (2603:10a6:102:ec::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Fri, 7 Oct
 2022 11:02:22 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Fri, 7 Oct 2022
 11:02:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 860f91bd-462f-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AAOVrewdzdkXpMBFcGvfU+cTkF6f3gwa26/28RwTDS84JAUhAvmqikcU8yYwMwuo6+trJojnHsGnsIZ42xDHooEVjR9RTy0xa7S2/ouo0hA3+vnAMXL93Jnha0tyHiBFcZRb6K3/TgGpxSH92SmH2eygbBja8YkGEEPxCx5XNLItCBok0BoAK/Elw9EHh8Y9EQi1c9S3d3ZFG1Z+82hrCIWGF4b/Zbr7VPlQWlmCiIaDCAnvwIiEKCvRx02QT9C2Ba9hJ1NkjAxX8W4YO+wPisDsB0AOwDFMdid2ceCVUH7XnrzWo3w9PvTYI4pifTL6vjLVPSNd7dTjOdRn0fd2sA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jiBuyn4NPUAs1BQ1Eg2cbHLTCNedQAJJsympjtC/a04=;
 b=TdwxdxSu/+5i4jBZOM20vro3sqdPEqtNpNOHsR42KHI/NmvWXxuYAzy6/vzE3OEta1bcbHGVinBioOsPwYeIvtfNFNgA+Ga4+IDDGdqLhrae3zSsuiNUxv8/EnILJpE5ZvW04QJlBdxPUkkLXUQ2DsA0H6P9IbR3DUwb3dYTe9rdBzwGspO4O6jTw2HQxY0sGAiATVa8OCY3xU1uQ/Khy3DVywezvoNbvu9IXyPvT6KoGK01Mfy/2xlNnzTM+nVauc9AXE5C/e6g5YQDAb5oPN/fWaArzLpjPwsUdvVvTsjaB0BaqRltd6bzgAe1GHbqTWjTSiNwCOFOm0kN+C+nCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jiBuyn4NPUAs1BQ1Eg2cbHLTCNedQAJJsympjtC/a04=;
 b=Yx8C6F9OKLEzRKcQIRSLJRX7RlgJv9JNpmM/iI+XRpcYOoCy/lm8duO3iNNzBniwFeSZ9t9JdpNnL+x6OGYx1yubB/fIruUcUIbAE81xs48pllshIP29T8vUMuW8/FnvPUvw0oOZjpf2zSVnxlJjxFM7Nf5qRa7XCJL4Z0od1UTc2AlGQ/1yGc92oiKiZNNx3XuyqqcQ8m+CzI1K48ToF+daArupW7xjboYevOksa5HptQ3n4tXEkse97xxoeHRK9NDBciiWdn05Bkj7vN3dkUuSjtysn2Nvnvd09CBcfW8VcdePDVrPs6oGPxOXL+aj1w+XDmnRgsi+MJ7YKaWt/w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <60eda03c-9e40-2a99-dfe5-7ba1407961ad@suse.com>
Date: Fri, 7 Oct 2022 13:02:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 1/3] process/release-technician-checklist: Explain how the
 banner in README is generated
To: Julien Grall <julien@xen.org>
Cc: Henry.Wang@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-2-julien@xen.org>
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221007091341.58542-2-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7678:EE_
X-MS-Office365-Filtering-Correlation-Id: aad0379f-7a09-4a91-70ee-08daa85368b9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IQnMSFiqWh1Uc7NSuMZeOtEqxKR+CNznQuxM9h8Da1PPkWT/OweI+KVDLw55cvQ+A7Ht7dOCclIdwj9xkEiXjSYJVYAxv+i8nJH2zJF5+vUs6yRQfPKWNfaMEvJ/jEJxNOEQZyqxytuB4VHyWrNaO3Yi8+VG9+Iylzpm+X5DzeenSjRN1jDtaHCGrpV5nruT9D0Z9lEDkz5xd33bg+74ke+Xl/oxsdnfVpdEVXN/CDhLFXqVH5eVoWsE0e2LP/EMXauNeB6EvSkWtUIKkfyM5Zzz+MyrK2b90ex6pj9EUjJkr87e0KB4iSDum2xku2WmHKgzMCLIwdURahBoRseHPAN533lUy9cxVlCdUn487HluJmvt6iaOI30Hxs890iroLGtwnuL8WEp2gpbJps4Tlk3VDreezyaPyKB9aFbKtQra+aFAltW7rQdjMIg8/rZL7iEWgfn7q7LDbBdfKpET0zRuYrYp8ZMzNKK+X3VS5OzU1ajPCzwfCg1yYubUJECpOM4s5/x4bqfJ/nB1g59K6mOaMTR0HHar8WiGi9ZJWQdWwxb1hQnT/Cipibd7XT+rQLyWzJOVxkNTd/slOmDELDP89SnxgDporQQgAMy6J4/o3zqCp1cxyLjJ54TJY5ulKeqDslbqx0aTFJJ5o9A3Eb4941dJ6g9G+I4rsKItn8SERAg2q4do3Xu2fe7Oc2l9r+jix7a7tQQ10kAW7TC6Bdv/lhd7XkeZj0CIzW1dOvowjeKMoF7nLV+g0LpgKrNqOpL4+hDjsHX0onKrKVYCAVEYzMD/M12Sv0/EAgRZJlU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(136003)(39860400002)(346002)(396003)(451199015)(6916009)(478600001)(54906003)(31686004)(316002)(66476007)(66556008)(4326008)(66946007)(8676002)(2616005)(6512007)(26005)(8936002)(6506007)(4744005)(186003)(2906002)(41300700001)(53546011)(38100700002)(5660300002)(6486002)(31696002)(36756003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bkhGa3NFRjBWK0cybjBQOXNobWpReXhReU9QbDVrUHdWYW9TNUZmYnc5LzJE?=
 =?utf-8?B?L2xDTkhNamY1d1IvM1NlbGxJclp2dkdkQ0EyNy9idjNBL3N1UXIxc0U3Y3hX?=
 =?utf-8?B?VTUvdkw2MzZObkFuK04wd3N3ZnoycCttcERwUFhROHY0SFhqalVVYS9lUExF?=
 =?utf-8?B?NzJqZko0ZSsxRGp2UTAvVmNOakhmQ29pbVkrMGgwZU5uUG9HeVBMYWhnYjhl?=
 =?utf-8?B?ckxYWHBubzYzaEQwZDF0VUk1dWFwYzBlS3NvYTlpbWdUeGtqL05NYnhodGRG?=
 =?utf-8?B?TEx0Y0ZibFNuTG9Ic2lYaThBTFRaeXdzNGJUNzI2cDlLc0I3elBrTlBTNlpj?=
 =?utf-8?B?a2wxQVJwUEhtL2grbGJ3RzhydE94Y2Z1M3ZmbnJmUWtzYnYyczJINjJXWWlk?=
 =?utf-8?B?MXhTbUlKL0dDTzJ6YllSdUJlYkhKTnFCR05qem1DK1NjZVFkM28xOUdZVHNw?=
 =?utf-8?B?OWFOaEdSQU96UHMzRjh1VGlIdkFkaDVnZmtEdmY4ZnB5RE5uYVl3SEQwWWVo?=
 =?utf-8?B?anJQdTM3RlcwbGRkOVRGNmQzaG1BZjBqVVlTd3VrVjVHVC9pd3liRUNuZGRv?=
 =?utf-8?B?TUVzc2hhYWZUaVVIT0ZZNldpdGVTM1hremhzaE9IVXJLdzlnYi94dVQzWFlj?=
 =?utf-8?B?UVlqd2VidWpSQzVYNklndGhVTXg1T2N3dDlTQ0c1UW1aWXA5OURjZk9YTE4x?=
 =?utf-8?B?eTdhbHN2S3VZSGt1U3pwUW0wa2JKeG95Y1UvcjFRZWgvQ203d1cwaVBTZ0Ru?=
 =?utf-8?B?OVBIcmZiL3Vad0tXamRxMmEvZzVPdzBKYzdCUGI1UUhlRlE5MGF4S0lOejVk?=
 =?utf-8?B?T1J0Nm9jdDZ0ZnF5T2NPai9obW5OUmdnZ054YUVkZEI3aHROb3dlVGlnVnBT?=
 =?utf-8?B?Tnk1ZXFnMlVXR2tsZWQraTRlTGRDaDIzRjlhdXZFU1NwZWtyaWdJaHFmTTMx?=
 =?utf-8?B?Qk85T2hkc0tZYjMrdXM5MWkrc01YZUM3SFJCNEtKM2RETlBPYmRsdXJOTU5W?=
 =?utf-8?B?UGxKVEFtNXhldkdWVWZNZ1crTExBeWp0b3loMjVPMWtlNmRhdVdZaC9ZbG1E?=
 =?utf-8?B?UUhCcElnR21Kblcyb3hWU1NBdVc3TE96cndLb05JM2NYeXJKN0pialN1dzlZ?=
 =?utf-8?B?d0RzSzFoQmRxQ3NWeWh5aVBRNUhWWkJ4azBXREhHa0xVT1V3eGEvMlkyQ2FM?=
 =?utf-8?B?YWZvckw4VE81NEhaT3VBamM4UkRTWGFKNFk1SUlFb1VXbHNpVE1OYWJUNFVH?=
 =?utf-8?B?WWJMazJXQjA1L2lSdkp0dmFzSzVOMjVrUktuTE13YkVxRjYxbUhWNjJ2L1JT?=
 =?utf-8?B?U0QyZ2kyeXZta3QzN3k3bU1NVnd0OHM3YWVrWjlrUDhhNGxtaFkrZldGdVNp?=
 =?utf-8?B?RGNtbkZ3OVFrZ0dNMkFLRnpkTlZHM3RwNmRjelB2Ky9GOFhINnVjc05iT1h1?=
 =?utf-8?B?L251YmtaR1FHcmdCbG9TbndJclIzSFU3TjIvT0JKdWFSeEp0MTQwUW1IUTZQ?=
 =?utf-8?B?R2RXaDVCOVN5YnRXVkFvZUQ4QUxzRkF1UWxLNmZEdDFiOHFSRjUyOTNLMnh5?=
 =?utf-8?B?c0Z3bzhIRkJjd09qTDYremtZY2JlNGdiSFNkcVg1c0tTUmNtV2ZKcTB6bXlU?=
 =?utf-8?B?Y3NDdHgrdVhEZXFMeTBNNzBnaDAveUV5djNualBqTEUzSnM2QjFTUzRxQVJB?=
 =?utf-8?B?ejA1UVBJL09QWldOYUVFc3lIcnJuaXJqUVplRDZNSWdNQXZrN3c3dmhQL2ty?=
 =?utf-8?B?UXh2emdzaEFiU3FFY3VldkZOQmZpZEJJWVgzb1pCUEhrSUR3V2o2aThpc1dY?=
 =?utf-8?B?dldGanFNQWpTejd1b3ppNzNhaWZnc1RTcWl5bWhTZmJxQks1MktQMDhEOWxm?=
 =?utf-8?B?UXF6RWZYSDBhZ2lGMytDRGVKRlp5QUZEYWluYm13N1MyS1VpNEcyeDBrR3NI?=
 =?utf-8?B?MHZvVDg2THZrK3orZWZ4R2V0WDYzOXBnd3E2U2tIdkg1Z1BGNkRwZFEwWHN1?=
 =?utf-8?B?czJOSzJhRzZ4cmcyTkdSaTB3MGR6K01VS0VialVJZGZnYklSU0tGczZFM3JZ?=
 =?utf-8?B?VzYxSlRaS2h3ZXBMcHRGUHNYODhqczdBem5oZzJ3N1NKdzYybDFUcU1RNzJH?=
 =?utf-8?Q?iLHZ3S9gMRLkktDTmGaIX7Dth?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aad0379f-7a09-4a91-70ee-08daa85368b9
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 11:02:22.2206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +nFToRy2t07WTN+rpf6S78vvu56qPurrNdtt+rrWpEz3fwt9+ifbaf7q7ncVd4yFpGA1WwikdBprJKFbdOD1Xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7678

On 07.10.2022 11:13, Julien Grall wrote:
> --- a/docs/process/release-technician-checklist.txt
> +++ b/docs/process/release-technician-checklist.txt
> @@ -49,6 +49,7 @@ t=RELEASE-$r
>  * consider bumping sonames of shlibs
>  
>  * change xen-unstable README (should say "Xen 4.5" in releases and on stable branches, "Xen 4.5-unstable" on unstable)

This line may also want updating, to include the 4.5-rc case as well.

Jan

> +*   The banner is generated using figlet
>  * change xen-unstable Config.mk
>  #   QEMU_UPSTREAM_REVISION,
>  #   QEMU_TRADITIONAL_REVISION



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 11:06:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 11:06:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417869.662607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oglBX-0004JW-K0; Fri, 07 Oct 2022 11:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417869.662607; Fri, 07 Oct 2022 11:06:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oglBX-0004JP-Fl; Fri, 07 Oct 2022 11:06:31 +0000
Received: by outflank-mailman (input) for mailman id 417869;
 Fri, 07 Oct 2022 11:06:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nDAh=2I=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oglBW-0004JI-A7
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 11:06:30 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17bd581e-4630-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 13:06:29 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB9057.eurprd04.prod.outlook.com (2603:10a6:102:230::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct
 2022 11:06:26 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Fri, 7 Oct 2022
 11:06:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17bd581e-4630-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SLiSCoufCjTh6Zpu9OTTjQvFcucHuJ7zQBlyFiSZtL8WDwUq7fyLxoJTCJD6vYTHtbTdAAbkjUVPLJodOC49rHPTW0/VUlsMReTZEz6UkReQ3/I6TP4K4JBygCrq5jbeUhCAxUpfy35Rx2B2T/ZznA5NVY3ixVHr7q1/TvwYiDFjAKk2/MHqOJT2rh2rfFNpH6SUhXlbbuf5O0mZ9XaO9Qhpn1UZQSIzv8sbR6afCDqBroXBEsWB5VMPTi/gvNa8cT/YEmiD4qKPi/7nFhTI9oeQc1/qbsNFK2Nn6V2ammmXucA/IUg4+54bTMn+Uo3LdQ6c8NDKaRC13bfc8ztSuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ffhbbvy+ilneO2Pgt0qQWWL+Aq5K3/876vSX0P+N3Pg=;
 b=nqlFluMZUhG38P05m2f5u4SEXT/9fWW0r91sel0674pURBI09uPgwX/2onFX2/kR4fbVY5YftNrjbBH838T7uX7zdKezXv10jY94RV0yLZZGDYyovcvieLvWSczBEHFKz0GYktqpnYBbHIzumN7dRNPDDCLSYnHaDubUo9vnVu1wmhtIh095c+H4b83bUhoHjDRrkGI6gNL8kbLIAlD35jELqRd/CU4QkjrfYDs2ZMuf5aJpesRsvdSWsVDyJhb7tD38lMinTUJpS7XB+Y7fGtFRH74EvpHHs1IELB9wYRaCJ78QQKPx121mQCvMJ5ClSs0bIOUzMxlVqdxmTm3iWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ffhbbvy+ilneO2Pgt0qQWWL+Aq5K3/876vSX0P+N3Pg=;
 b=hL8JRud4Ngpm99TcdIuacClcKluTkI8wPWK4hp5BVIk+V4JRbZ3Z+EajJXVFOCNgieeBf0BbJZ8paDVNUspDOYMDg+JMAprQlt68yXnlQeXOVWYuEeoOXyY5bKXCNs8xPkM3lc8ebBQ21nFV3TRmAU/JCz0vUAKL7kho8y7cGUjPXo2ETXMELZsHqeXGkGTE5GYEj61FkI04CUXF9x3rPa8owfKbLAl3SIz5SR0YO5wH15QJzx1CWeVZKaKlrr4UQZzuHEC6+LHmGmGrQZCmimlODIiXVRlRLnJmztsiF/fYIyNHamrO6YegMoTLc1sVYkSYbtprGz14J0ferFsoSg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <304f4bbf-3598-2f42-5cee-83e58c1909cc@suse.com>
Date: Fri, 7 Oct 2022 13:06:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 3/3] Update Xen version to 4.17-rc
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Henry.Wang@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-4-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221007091341.58542-4-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0590.eurprd06.prod.outlook.com
 (2603:10a6:20b:486::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9057:EE_
X-MS-Office365-Filtering-Correlation-Id: b065bd26-8c46-4591-2732-08daa853fa94
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t2PxTUkf4LNcFJMhMY+1v+bQIAS4dhUng8MvEdEp1avs4oZWUgqQfYBg12WFpAgQiRsdjamMYMmLn+rT5rsfMRIXOXK2GcBHDNlNzqdjwIjDoULwacwXSOGILLSQB+9Z6nrca/D1S7ve5iHdZDMAROaRXln5TYWfjCx9m5wjuLtvOhnaKlBcLOXzjpVO3ROR0juVnIbxgW10tKtFUB3hvXT+fe0TmMC0rE2/2tyb1FSIAZCVicw4CpWdS846QBI0MuLdgmtrfdaLxxzqdWZJEBhk/8TySNT7oEqwtLcZTnK2gOW1eM9m+qZ07re3oicUfa46qmhkl8dmoF3TUYKLiBCCtOTqDU2jxCjZe2BaHjGrfDdx/g/IchLJ7awpnFyVdC8dGd6dTveMVnEZorKvmfHutHUXWuKDqZEvFxclQX3FkUiQ6UjKqiElI5Ale9DxwfoP3YJSd1P/hDZFPypgGJzlf7dVaeEPIUro0xNPN7eyimkbiaEijhLrnLgr02eeoUN14CGugkPsErGKhtD3EsJrjZCI1lqWzOiH22cqV7t7VuiT0R9H0dbprWZ9VexDNnDN9EV+P1e9peDDhosr8keaPxq/RJA+z+1wHuCbWelE1ftzXvbTWsOsOFbryIC9iaeVnNyo2OV61iJ+LgouDibstMWtiE1L9ZNGWfI+7Zkuo2foq0xk/lOYfzpNpvqUq/ZGfggaSrbULBuskYoxJK5tLaTaqOlHEaszDvP5z4/bvyAuPfeaGbya17+iTuJH0JBaZcu/rmKVXMO5JhWX3n5YBpHKJViMgAewm36/iLY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(39860400002)(136003)(376002)(451199015)(8936002)(5660300002)(38100700002)(41300700001)(4326008)(66946007)(8676002)(66476007)(66556008)(2616005)(36756003)(86362001)(31696002)(2906002)(15650500001)(6512007)(4744005)(53546011)(26005)(478600001)(186003)(6916009)(54906003)(6506007)(83380400001)(6486002)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c0JkazJHOWNRQzJobVRkVjNmamIrR1FvN3UxVFFEb3dkQmJFdTlDbGNLVDk2?=
 =?utf-8?B?T29tdHNhMm1xbXpjeG1OWmtIem9mTWRFVVhCak1pU08xZWJPdFh3ajJDMklX?=
 =?utf-8?B?MDNYekN6RmRibDRoQ2JvU1NQbitSUW41aVpTOGcvZHZqdGFHV3VxWUtWbS8r?=
 =?utf-8?B?aDZoRDAzTW81QlFIc3ZraVBzT0V6d2JHK0k0WFRselA5L1ZWV2F5bDd4dG80?=
 =?utf-8?B?QUdCOXNPK1dUTDgzTUxHOGRHNE9ucmU1ajNhUnliWkhlNVJ5Wk54TUtSV1lD?=
 =?utf-8?B?dGpVZ0hoNit2bjF2SHR2MlNvQ2labGplMmdWUnVqUklldE00QVd5NkdLM21T?=
 =?utf-8?B?YTlXdExJTm1yN1ZkVGt5bWo4TzVtODNLVWF4TCs4REFCbTRLY2R6RFpVSlVB?=
 =?utf-8?B?M1ZvV1JuVndWTGpvQkFEVUVCM1p5dEFIcGlNVTdtWXU2eUF3d1ZSZ3Z4QU9T?=
 =?utf-8?B?OW5pbjcwSkdKQ1A0cHN6RUVReVp4dGJpRUVvRFExcmFBMEJSR2owM1J3cUVS?=
 =?utf-8?B?eStFTTFUeHU5QkFDSVZuME1KUkpjU00zemdOZ1pQNFJ4TUtxY3AzZUtlYUpa?=
 =?utf-8?B?TnBRQzh0ZnJZbHMvZjJrU1FsSFFjd2swOHlVRWlqazBVSU0vUXBZZHJaR2Rx?=
 =?utf-8?B?K1RLS3dJRjA0SHYxSS9hejBwd0dHbGpuQytHWDdHd0FwOE9OclpiUzMvRTlJ?=
 =?utf-8?B?OUlOQzNEa0FOTDFHNTBFeXpVNEhBNzlXVTlaOHFMMHF3SGN0RFlndTFzeWkr?=
 =?utf-8?B?T2JSNWVhenlGSmE0RE5xUU5QSFhFSWdsQ1NCTUcxNzJFMEtoVGhQQmVpR3Y3?=
 =?utf-8?B?Yk03RkdQY0V2d05xazM0L3Ava3pzZ2VlaTNZLzFnK0gxcWVXdkRwSW1ROU92?=
 =?utf-8?B?L2ZNMGlsY0RtNWV3bHFjekcrYnlCSUh3eEJST0tFc1B2U3F1NHRNc08zQTA4?=
 =?utf-8?B?aW51U3MvZGE1dW93UlRpbGQ5WXhSaU1Wd29pZ0MwMlkxWTFKQ2pRS0ZQbG44?=
 =?utf-8?B?eUhianBwZVRXT3c5WjZRWWpDRTRCRDdGNEllL0EvZmM5RXBxUE4weWtNOFE5?=
 =?utf-8?B?LzkrRTE3KzkxaFlJbERMWUQxb3grR3loZjZJTVRCT1ljV011ajlsUnkrRUxU?=
 =?utf-8?B?L1pRS3gwQzJZUTE0R05TTTg0bkloL210RnJZQTRUZ1Boa21nNFRpRVN2a21S?=
 =?utf-8?B?cVR3RUNWZGp0dlJsQ255VUJWTFpSWU1CQzdrc0JlSjF3NjhrVldMbnRuV2NR?=
 =?utf-8?B?MWxOaUhWQllVQlBDcXFSN3M0ZHJPZC9uUEljNnczRjhBT2JYdFJ4b1pkc0JW?=
 =?utf-8?B?U0RKNWZ5MEZoQVBtSE1mcFdkTEtIdHp5aFlJVWxiaFRONlg1Lzd1dVY0MkNZ?=
 =?utf-8?B?QTNJTWpQV094ZW8rMzBOcG9LWDYrY0ZkcUJOMWt2bUFhem14RlF3Q3dmVDVH?=
 =?utf-8?B?TmQwcHFBdGQ5N3VDSzFaeTRDb1pVVTNzWnpiOWExV3dMQkNqdDhVVDUwNW42?=
 =?utf-8?B?QVJCaEVxdGhCanpnM1VLcHFEem9ra1gzZ0kydDZYdXJFMmNPWVdkaUNYQWVC?=
 =?utf-8?B?T2hEbHpJbVBZSDc2TW9DclhaeTI1R0JJRHpPYllWUmFhZjdWenZnUG9rWXc1?=
 =?utf-8?B?SHYrNWJnV0ZyNzdpQ2dOL0FMUXQvOUQvQ3BYV0MyeDZHZFhCZUg3ZG5XRmtZ?=
 =?utf-8?B?UFBNZG11WVd3dGsrNXNPUnduazFzUm04N0ZGOVFVRG1TM3g4Uzc4U3ZKWlFx?=
 =?utf-8?B?RXRVbHZTSUhxUWdtTWI4b0dSRmFHaDBYRXJYcGN2TUdHbEwweWZzTGNZYUdL?=
 =?utf-8?B?d1N6T2VCbHJaaFlRUVhnSVNQaHpsbXh5Qk1xSy9jTE5vZERIbkN6dEFaU2dJ?=
 =?utf-8?B?WkQzYng5VzZ3bGo2K2ozbDIzQUxLRjkvOUZ0c2F4Wjg3bXRWemdvaEhmZmdQ?=
 =?utf-8?B?Nko4Q0xXbTdvWkpOZWdqSmh2dng4K002bVBrazgyQnV6cEZQQzZPNi9QU2xo?=
 =?utf-8?B?WkY3a24vOWQ1WWhFMjdDSERtR1dyckZSYkpGckVvNlRRN2VxekxUb3NPci9l?=
 =?utf-8?B?NXJZRkFYdy9oKzVTblQzQ1F6L2lzdkp5SUVnbXg1UzRlMCtWTXh4amxmMCtQ?=
 =?utf-8?Q?SodNr6RFaABPU4TOPOmkakXUU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b065bd26-8c46-4591-2732-08daa853fa94
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 11:06:26.7517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2I6jiMcoHoggsRjBsFGuUQU4t6Ioj3B6FTdeHYuITFWO/SLIzmXt6pBSc7XrO9Sltsm7QCVhjVVhvPQ9dJsD9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9057

On 07.10.2022 11:13, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
>  README       | 16 ++++++++--------
>  SUPPORT.md   |  2 +-
>  xen/Makefile |  2 +-
>  3 files changed, 10 insertions(+), 10 deletions(-)

I assume CHANGELOG.md is then going to be updated only once for the actual
release? (Not that I think that the -rc is relevant to have there, but the
version could as well be changed to 4.17.0 already now.)

Jan



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 11:17:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 11:17:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417877.662617 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oglMA-0005r9-J1; Fri, 07 Oct 2022 11:17:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417877.662617; Fri, 07 Oct 2022 11:17:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oglMA-0005r2-GM; Fri, 07 Oct 2022 11:17:30 +0000
Received: by outflank-mailman (input) for mailman id 417877;
 Fri, 07 Oct 2022 11:17:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oglM9-0005qw-Bh
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 11:17:29 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a077f930-4631-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 13:17:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B619621901;
 Fri,  7 Oct 2022 11:17:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 779CA13A9A;
 Fri,  7 Oct 2022 11:17:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4HCtG8cKQGPYQAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 11:17:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a077f930-4631-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665141447; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rodz+ksVyPQ7OBPQytc3YNBLWrd23nCfdbAfpYfKunU=;
	b=sLN0cIRhC6FuvbtcEZ4NNM4QGOuAfywIk9zbHszNCD6yRDs9gHDPJkMcwqBya1FLpmu6T5
	jWVi7xWNCVT6eVzgZjYPu5owK9sBmbY0y/BWJMsCFHd8U4mDI3XE2lOIiEDyW/SRbLb8U3
	ePYkFZJXyleK2MX0WK3NwP7R0mN1ig8=
Message-ID: <87437234-02ce-b18e-8442-c081de259ed9@suse.com>
Date: Fri, 7 Oct 2022 13:17:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Mykyta Poturai <Mykyta_Poturai@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
 <37f0f84cdaf47b1efda59f0368998183dff88a3b.1665137247.git.mykyta_poturai@epam.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 17/19] xen: don't free percpu areas during suspend
In-Reply-To: <37f0f84cdaf47b1efda59f0368998183dff88a3b.1665137247.git.mykyta_poturai@epam.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------2cq8xhqiTNmgi1TspXAg68f7"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------2cq8xhqiTNmgi1TspXAg68f7
Content-Type: multipart/mixed; boundary="------------YX3h6mU6fGSWJb0Dr69DtP7L";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Mykyta Poturai <Mykyta_Poturai@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Dario Faggioli <dfaggioli@suse.com>
Message-ID: <87437234-02ce-b18e-8442-c081de259ed9@suse.com>
Subject: Re: [PATCH 17/19] xen: don't free percpu areas during suspend
References: <cover.1665137247.git.mykyta_poturai@epam.com>
 <37f0f84cdaf47b1efda59f0368998183dff88a3b.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: <37f0f84cdaf47b1efda59f0368998183dff88a3b.1665137247.git.mykyta_poturai@epam.com>

--------------YX3h6mU6fGSWJb0Dr69DtP7L
Content-Type: multipart/mixed; boundary="------------TmYiVmpKfPSedR4CIJJuaYkL"

--------------TmYiVmpKfPSedR4CIJJuaYkL
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMTAuMjIgMTI6MzIsIE15a3l0YSBQb3R1cmFpIHdyb3RlOg0KPiBGcm9tOiBKdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IA0KPiBJbnN0ZWFkIG9mIGZyZWVpbmcg
cGVyY3B1IGFyZWFzIGR1cmluZyBzdXNwZW5kIGFuZCBhbGxvY2F0aW5nIHRoZW0NCj4gYWdh
aW4gd2hlbiByZXN1bWluZyBrZWVwIHRoZW0uIE9ubHkgZnJlZSBhbiBhcmVhIGluIGNhc2Ug
YSBjcHUgZGlkbid0DQo+IGNvbWUgdXAgYWdhaW4gd2hlbiByZXN1bWluZy4NCj4gDQo+IEl0
IHNob3VsZCBiZSBub3RlZCB0aGF0IHRoZXJlIGlzIGEgcG90ZW50aWFsIGNoYW5nZSBpbiBi
ZWhhdmlvdXIgYXMNCj4gdGhlIHBlcmNwdSBhcmVhcyBhcmUgbm8gbG9uZ2VyIHplcm9lZCBv
dXQgZHVyaW5nIHN1c3BlbmQvcmVzdW1lLiBXaGlsZQ0KPiBJIGhhdmUgY2hlY2tlZCB0aGUg
Y2FsbGVkIGNwdSBub3RpZmllciBob29rcyB0byBjb3BlIHdpdGggdGhhdCB0aGVyZQ0KPiBt
aWdodCBiZSBzb21lIHdlbGwgaGlkZGVuIGRlcGVuZGVuY3kgb24gdGhlIHByZXZpb3VzIGJl
aGF2aW91ci4gT1RPSA0KPiBhIGNvbXBvbmVudCBub3QgcmVnaXN0ZXJpbmcgaXRzZWxmIGZv
ciBjcHUgZG93bi91cCBhbmQgZXhwZWN0aW5nIHRvDQo+IHNlZSBhIHplcm9lZCBwZXJjcHUg
dmFyaWFibGUgYWZ0ZXIgc3VzcGVuZC9yZXN1bWUgaXMga2luZCBvZiBicm9rZW4NCj4gYWxy
ZWFkeS4gQW5kIHRoZSBvcHBvc2l0ZSBjYXNlLCB3aGVyZSBhIGNvbXBvbmVudCBpcyBub3Qg
cmVnaXN0ZXJlZA0KPiB0byBiZSBjYWxsZWQgZm9yIGNwdSBkb3duL3VwIGFuZCBpcyBub3Qg
ZXhwZWN0aW5nIGEgcGVyY3B1IHZhcmlhYmxlDQo+IHN1ZGRlbmx5IHRvIGJlIHplcm8gZHVl
IHRvIHN1c3BlbmQvcmVzdW1lIGlzIG11Y2ggbW9yZSBwcm9iYWJsZSwNCj4gZXNwZWNpYWxs
eSBhcyB0aGUgc3VzcGVuZC9yZXN1bWUgZnVuY3Rpb25hbGl0eSBzZWVtcyBub3QgdG8gYmUg
dGVzdGVkDQo+IHRoYXQgb2Z0ZW4uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdy
b3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCkkgY2FuJ3QgcmVtZW1iZXIgaGF2aW5nIHdyaXR0
ZW4gdGhpcyBwYXRjaC4gVGhlIG9uZSBJIHJlbWVtYmVyIHdhcyBmb3INCng4Ni4NCg0KPiBS
ZXZpZXdlZC1ieTogRGFyaW8gRmFnZ2lvbGkgPGRmYWdnaW9saUBzdXNlLmNvbT4NCg0KSSBk
b3VidCB0aGF0LCByZWFzb25pbmcgc2VlIGFib3ZlLg0KDQoNCkp1ZXJnZW4NCg0KPiAtLS0N
Cj4gICB4ZW4vYXJjaC9hcm0vcGVyY3B1LmMgfCAzICsrKw0KPiAgIDEgZmlsZSBjaGFuZ2Vk
LCAzIGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcGVy
Y3B1LmMgYi94ZW4vYXJjaC9hcm0vcGVyY3B1LmMNCj4gaW5kZXggMjU0NDJjNDhmZS4uMDY0
MjcwNTU0NCAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL3BlcmNwdS5jDQo+ICsrKyBi
L3hlbi9hcmNoL2FybS9wZXJjcHUuYw0KPiBAQCAtNTgsMTAgKzU4LDEzIEBAIHN0YXRpYyBp
bnQgY3B1X3BlcmNwdV9jYWxsYmFjaygNCj4gICAgICAgc3dpdGNoICggYWN0aW9uICkNCj4g
ICAgICAgew0KPiAgICAgICBjYXNlIENQVV9VUF9QUkVQQVJFOg0KPiArICAgICAgaWYgKCBz
eXN0ZW1fc3RhdGUgIT0gU1lTX1NUQVRFX3Jlc3VtZSApDQo+ICAgICAgICAgICByYyA9IGlu
aXRfcGVyY3B1X2FyZWEoY3B1KTsNCj4gICAgICAgICAgIGJyZWFrOw0KPiAgICAgICBjYXNl
IENQVV9VUF9DQU5DRUxFRDoNCj4gICAgICAgY2FzZSBDUFVfREVBRDoNCj4gKyAgICBjYXNl
IENQVV9SRVNVTUVfRkFJTEVEOg0KPiArICAgICAgaWYgKCBzeXN0ZW1fc3RhdGUgIT0gU1lT
X1NUQVRFX3N1c3BlbmQgKQ0KPiAgICAgICAgICAgZnJlZV9wZXJjcHVfYXJlYShjcHUpOw0K
PiAgICAgICAgICAgYnJlYWs7DQo+ICAgICAgIGRlZmF1bHQ6DQoNCg==
--------------TmYiVmpKfPSedR4CIJJuaYkL
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------TmYiVmpKfPSedR4CIJJuaYkL--

--------------YX3h6mU6fGSWJb0Dr69DtP7L--

--------------2cq8xhqiTNmgi1TspXAg68f7
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNACsYFAwAAAAAACgkQsN6d1ii/Ey8n
zgf/U4EzIP7JAXO2wi9A932Zwa6WQE6W/rnqbwaM01xoxbyEXvVYMR4asTeGx98S8UoiiozD+ets
lOfFeKvYhno2q0Pk64xH3JiKbBBy/U+8ifHrwq/wRF3ws0TuuS6rK7t2PrQdB/n39yDsp34XSyF7
7WRJjDLufKrXxKwZKMGhDIUrx4E5DvloDZuVw6RwB0Qk68NvKF5b/MbkYTcDRLY7Petl+i0Nys9Z
HLoe24APQOqSCNBf9vPCzhRvBUOmOwJuhLusl0nxmG3si8HkJ8KWqpwM8JAJPHfPRUL6qDWphuEK
DzM509UTbSirqdRDr+tF9La1NeJwMjcO76TJmmdt3w==
=SLyh
-----END PGP SIGNATURE-----

--------------2cq8xhqiTNmgi1TspXAg68f7--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 11:57:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 11:57:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417886.662628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oglyT-0001vP-O4; Fri, 07 Oct 2022 11:57:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417886.662628; Fri, 07 Oct 2022 11:57:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oglyT-0001vI-LC; Fri, 07 Oct 2022 11:57:05 +0000
Received: by outflank-mailman (input) for mailman id 417886;
 Fri, 07 Oct 2022 11:57:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oglyS-0001v8-8w; Fri, 07 Oct 2022 11:57:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oglyS-0000ie-5M; Fri, 07 Oct 2022 11:57:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oglyR-00081T-Ge; Fri, 07 Oct 2022 11:57:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oglyR-00037K-G8; Fri, 07 Oct 2022 11:57:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=R/VMcISlG2bzOdNd15Ihj9wPTGEIFM67jOpjpz6/fiw=; b=U+o4YOV8NECUsSDYbQtKN2sqke
	lqtpk0y1u4rn06mnRU/wBIrPdTgsKaYWeOnh/WNZR5ETqqxGgRCu3E8PdHJr8fxPRELGinHexKIGI
	Eri1LrBEUKk1IttOkeI5d7b97pQaPFAT6yWJ9vbKLVmJQjfwORPkPyrea4j0sr1H8y54=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173453-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173453: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=491d918502e50bf15c75d183bb41e3c0de5a0e1b
X-Osstest-Versions-That:
    libvirt=25c473348bc141a82f821a2701e18f9705346a1c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 11:57:03 +0000

flight 173453 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173453/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173438
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173438
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173438
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              491d918502e50bf15c75d183bb41e3c0de5a0e1b
baseline version:
 libvirt              25c473348bc141a82f821a2701e18f9705346a1c

Last test of basis   173438  2022-10-06 04:20:29 Z    1 days
Testing same since   173453  2022-10-07 04:20:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel P. Berrangé <berrange@redhat.com>
  Erik Skultety <eskultet@redhat.com>
  Peter Krempa <pkrempa@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   25c473348b..491d918502  491d918502e50bf15c75d183bb41e3c0de5a0e1b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 12:02:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 12:02:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417903.662658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogm3n-000410-4T; Fri, 07 Oct 2022 12:02:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417903.662658; Fri, 07 Oct 2022 12:02:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogm3n-00040r-1Z; Fri, 07 Oct 2022 12:02:35 +0000
Received: by outflank-mailman (input) for mailman id 417903;
 Fri, 07 Oct 2022 12:02:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4A9H=2I=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1ogm3l-0003ad-Ad
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 12:02:33 +0000
Received: from sonic313-19.consmr.mail.gq1.yahoo.com
 (sonic313-19.consmr.mail.gq1.yahoo.com [98.137.65.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9db2266-4637-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 14:02:29 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic313.consmr.mail.gq1.yahoo.com with HTTP; Fri, 7 Oct 2022 12:02:27 +0000
Received: by hermes--production-bf1-5fb9f4c8b8-vstzd (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 1814f366ff002f5ae1c77cd5f5a8908b; 
 Fri, 07 Oct 2022 12:02:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9db2266-4637-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1665144147; bh=BaQVWS/lf5ppT0XBzHXr8peU0CSPHk6KcpftB9KDuco=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From:Subject:Reply-To; b=e45Znb/baVsQOpVKGHVSSURztZzzvPevdDJ+KBsBf88pF0bxP+GqWBJ0FsjamLcKIoFXZE/YDJNtBLa9s4crBIBn/9rCwHeC05zN6N7uC61vrq/HyeWkckENtiYj0Kfx8PMFSkvTqm6RmPNboZ6MFjQswVZ2XDyQj/itOwqI9wESBKneHKjQwTJkdgGObFj87EhuyBdo9G6Lv3tL0nIsYYWx6xvzBx0blk+Xkka8Hrb/rXukq67s3baWu/RkyXYjBHSg12ohRjOk1cfKZvjZVqoA6nfLFTp0vdgu+TzM7tqPatPjoM4SfTYoD2kuIEocUTGSnVlc1j9H0fLioWSjSg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665144147; bh=8CNL3oWyvkWpK+R9IcJC829+0YKX9dUViPD/v0Rn/H5=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=R1ykvspUvOtsWzxvOSA7mHpo3Aj+vmFAFXqkGkURyw3vHW9hSuPm+U5AYOcFaTfQp2v2s/4UQOF7w5swkeLliZE1LElcexq2nYRM/19fw29O/ChRu46RhOsOBJFIn7dhF/K2ONo733au7f2DsZVnqz1vgMJY7jDlIcQvv7uJBnjM4bU/S/ZSQh+kYA5JhxzQnCky5wkcK5AsrayMAXVJLMVCPMi7yI15rSBgY7m8kamCJhI/Fp+QYkoh1rjWTxJ7xIbnFahh3/jaKViOy06DaYKtm+baaSgHX03W1GtOdqwQ/6SuonOxyzxCb9rA4jVpty6Lh6J5B1ZCMQ0xwyTv4g==
X-YMail-OSG: mvrcGyAVM1kZ8qTLfHRikMX2W5jKMI4Lkq3HvkH.btG2yVVHHsd4b9nCmJYX7FD
 4byaWFIenBeIDFLoN4S6D5pj2h46rhDYok8066pAZaZroqS.Z56F4rMFUN0BDTLgCpiy3D_iHEhL
 RTVy9AibH7A0jXdDKwNtcj4PkJ4hDcFTBoviulGd4GrEuORP6Qs1R7ChuNHmHYA2HEf4zi0FdGbb
 TQDr41onVw8Ogr5xjBo2RbmSVDUvn4f3SA9tb5vgRjz1dGdzR2OfkOpE7vvuFAd.gSLmPxe7RukZ
 4ag6Aiv68M6BHYJMNVqTvlfbFft1v4V3QoCoAE7U0Ml4gCu6T2mMpo1UFH_lTWZ3g4MNx6Pwmhnv
 DOPHbf4.geOibdt_W6Q49p3z6dFbhaI9vJ5XhBzSS_vV14zzFvSnmKsXquLjzsyWSgHgfTOIV20M
 8RvSWKWlsLAYc1hGUAnljmzPb5guWkC_yeQT_DrHoIUvlN5bKoUwN9bE7ADjV0nozh1latr9H72U
 nEmUZ2DZ3oE_3M4XRvaB_ro.Aoo6fLEoehQo738hz_7ptpUo80kOr0em3PSJaQfNYgcE4cKRBqaY
 LA0VG_wJbWXKOkg.nzyVW5crAjq8a4dpO3TKXHMoo5K9V11s0jrdTunqc.s6a1t0x2PTbsWl7Y0f
 sIta9W.rQtKav1begHGF6v88wGkwUXz7DsiM7di2XdJn7YetI.5lmKQwXBdKxspGGw3GaOKvE_QT
 FStbRqmGoIzBMfyFpb.nv1yI_Hsz_B2VqBBIsRv_LjXQWXREHMS9GwnRxs9lpyf2K4sWi1RzgVrd
 Q3JajU08IgBJ5gN73ILttjoaTahOH1Tacc9bRKfgKllH9kGpUaWMaAorHZ.cpPfJZSgDm50mJGn5
 D7ajnNH41CPuCF.Btzh_7FwJHrnJoNvz.R2ifnJHJPDnqLVNNvUB23qlpLNudQCXtcqIkYo1MDeX
 xJ3AidUD5M5dcy9gQs.AgO7tpRbMJaEB7knlCgq87HFvFBbsmHpYxXcNubHomd1QrAcSTEgtnfTs
 KB84dlaMgTfPaYzRwlzOeyqf4dghpPVX5MxOq95InU4WOqdVNVanuOIO2mZsnET0y_aCDQLyb1ot
 oBJ_MjHTc4JeFM.nQNVpmA2I_HHiRgdVhn3vg087Q_58PhTmtes.zkM28ogcrqBz6DOlY12NBsJ2
 qb1uqHrOJ0TVW6.1VwmQDFvOctgBLXKiimA_wt.GTlP5.iZ1jJyYFVeINgoM_uaMMpavH.89uuMS
 _rfWlt3keszvZxOL3p8g4zRAI68k9TiMdIMqxEPWthA10D11uZGLKsbzdCQvw0XTzki7tHg0PKol
 xsMsfwnQCLLEwE8ZBw1iwG6rOXr1YuYnQAc0qI8FhYw9MvOmUTbOYGJYcaLaB8xIlRKhZ.M3yhsV
 k.zrSmIVsOA1XsSK216htiyl2QRhfkr_.qEBd5nPlvYA41epOADdNU8.bSxiuIdTmKMw8SHCbTAw
 Oy6TwI.g34tqLZU6jb_YatdBhC5urK1RbeH4Sxc8Hn3FEP2zfMfvz7Kv_G5WF45qTXGPF82aUWCu
 OVlEPDauW4PX1D4Zv8vTo79q.U4NhgAveIF29BOoDQDr3UWn0SLHmv6wrL2ViTTefmQCF5mq.z81
 gbcJRxC7RzfhYmtEMcHblY8M9tMGlBIfs7UaLW8Z7C5EwKmDtxvZey_P8voicCgytZBcBr6T0KU5
 ASnX_NAInVHtjzcn0Jb1.fxGEZd4bs352i3m3MWS.ekUzBLdp.E3WwrvoKQzyOIh0lbzYhA1FHx.
 .oGn2zohQQIifvsBbCTcTcNUTc15S5BKBRFL9t4Gqbj5_3VfwldlvyItm8bHUAaAdbgotMEXwmYs
 5KtX1y4pSWprekGnZNZtUWGDCm1pfJMvfXVWZ.CLScJtqAWfm.UZEsHVXCo3BE3NiDbRWCevYR7_
 ooWE4ajapGtgnrMdo8qi8qrBddsPVoPEjlQW_cuV0tbKHCk8fQtNKWBxT.QSHgtRfsCbBH112BOz
 Qkz3264f4ZiZQLh9U6_R59c28iI0FMehVsmLsEGuTe3egC3oK6MTOMyXBQbkdLzIEQLTOvqwxCz1
 eT7rD_28lM1nZigaVG7qtzxnCmLuqqGNfuZLt9f4cHqzUNq4fbYoLgjHnn8FjxSUDOXMQgJK7gcc
 Nlmquo058u5R7jp3TfVazUeW5AIklP7Rc4XxFRIsStomqioafsgKEUew1W4Pgqm5tfrn4MY8GLmD
 sH53g
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <9639a6cb-8e9b-6c67-4ed7-7df2e84d6f25@netscape.net>
Date: Fri, 7 Oct 2022 08:02:21 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: xen ovmf/uefi firmware does not save screen resolution
Content-Language: en-US
To: xen-users@lists.xenproject.org
References: <mailman.3.1663934401.4493.xen-users@lists.xenproject.org>
 <423215ee-fac0-06c5-1156-3c74e98cff12@liberaliatempus.com>
From: Chuck Zmudzinski <brchuckz@netscape.net>
Cc: xen-devel <xen-devel@lists.xenproject.org>
In-Reply-To: <423215ee-fac0-06c5-1156-3c74e98cff12@liberaliatempus.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 7285

On 10/6/2022 9:38 AM, Liberalia Tempus, S.L. wrote:
> Thank you very much for your answers.
>
> Finally, after trying some of the solutions proposed by Chuck, I have 
> made the decision to delete the UEFI partition and move it to a normal 
> MBR system.

Did you know you can keep the GPT partitions and the EFI partition and boot HVM guests
using MBR (seabios) with a GPT BIOS Boot partition present in the guest's virtual boot disk?
I implemented that by stealing the last 1 MB of the EFI GPT partition and assigned that 1 MB
to be a BIOS boot GPT partition, and grub2 is smart enough to install its own MBR bootcode
into that partition and it works fine in Xen HVMs by using seabios instead of ovmf as the
firmware/bios for the guest in the xl.cfg guest configuration file. But that's not necessary if
you are going to give up on using the EFI partition and GPT partitions and go back to the
legacy MBR partitioning scheme. What you are doing is a sensible option also given Xen's
current lack of support for UEFI booting of Xen HVM guests that actually works.

> I think it's too cumbersome all this xen and UEFI booting stuff and 
> there's no point in spending more time on it. At the end of the day what 
> matters in a virtual environment is that the machine works, regardless 
> of the system used to boot.
> As of today, UEFI booting does not work properly in xen/qemu, at least 
> not for people who are not experts in xen code.
> Best regards.
>
> PS: Chuck, what you say about version 4.14 I have not been able to apply 
> in a vm with windows 10. It seems to work with a hvm vm with linux, but 
> not with a windows vm.

That may be true, because I have only tried UEFI booting of a Linux HVM guest. I have always
used MBR booting of Windows HVM guests with either the stdvga Qemu emulated graphics
device as the Windows HVM guest's primary graphics device or VGA passthrough of the Intel
IGD graphics device to the HVM Windows guest as the guest's primary graphics device.

I will in the meantime try to get UEFI booting working for both Windows and Linux HVM guests
for the future and at the same time use the BIOS boot GPT partition hack to give me the option to
use MBR booting with seabios instead of ovmf as the firmware/bios for the HVM guest until
Xen works well enough with UEFI booting of HVM guests. Obviously the MBR technology is legacy
tech and Xen needs to eventually be updated to support the UEFI booting method of HVM guests
going forward. I am not aware of much work in this area being done by the Xen developers, but
I am not subscribed to xen-devel so I could be wrong about that and I would welcome any
Xen developer who could explain to Xen users what work is being done to support UEFI booting
of Xen HVM guests in the future.

Best regards,

Chuck

>
> -------------------------
> MhBeyle __
> > Date: Thu, 22 Sep 2022 11:25:41 -0400
> > From: Chuck Zmudzinski <brchuckz@netscape.net>
> >
> >
> > On 9/22/2022 4:37 AM, mhbeyle@yahoo.es wrote:
> >> Thanks for the answers.
> >>
> >> Chuck, I tried at the time to apply suggested patches to the software
> >> with no results. It is not clear that any of the current patches solve
> >> the problem.
> >>
> >> I think there are two problems here: One, the virtual machine that
> >> creates xen uses QEMU and the UEFI bios is not able to communicate the
> >> resolution data to the system. Two, this kind of problem would be easily
> >> solved by virtualizing a more modern vga instead of the current cards
> >> (cirrus etc.)
> > Actually, this might be a bug in Xen 4.16 that was not in Xen 4.14.
> >
> > On Debian 11 (bullseye/stable for Dom0) booting HVM with Tiano Core
> > UEFI works for me using vga = stdvga and videoram = 16:
> >
> > With Debian 11.x stable for dom0, the Xen version is 4.14 and the Qemu
> > version is a bit old, 5.2, but booting with ovmf/uefi works:
> >
> > I boot Debian 11.x (stable) in a Xen HVM using ovmf using vga = stdvga in the
> > xl.cfg and it seems to work in a VNC window. I can get 1920x1080 resolution
> > (with videoram = 16 in the xl.cfg), but this only works on Debian stable dom0
> > with Xen version 4.14.x and Qemu version 5.1 (haven't checked if Debian
> > backported Qemu version 7.0 for Debian 11 also works).
> >
> > After login, use the gnome display settings and it gives the option of up
> > to 1920x1080 resolution with videoram = 16. I presume KDE, XFCE, MATE, etc.
> > also would allow this.
> >
> > It is true the Tiano Core UEFI boot configuration setup screen and the grub
> > screen resolution is low (I think only 800x600) at the beginning of booting.
> >
> > Here is my xl config for ovmf (UEFI booting with vga = stdvga, videoram = 16)
> > and a VNC display and Debian stable with Xen 4.14.x dom0 and Qemu 5.2 in
> > dom0 on Debian stable:
> >
> > --- domain configuration file ---
> > builder = 'hvm'
> > bios = 'ovmf'
> > memory = '6144'
> > vcpus = '4'
> > disk = ['/dev/linux/bullseye,,xvda,w']
> > name = 'bullseye-hvm'
> > vif = [ 'mac=<redacted>,type=vif,script=vif-route,ip=<redacted>' ]
> > on_poweroff = 'destroy'
> > on_reboot = 'restart'
> > on_crash = 'restart'
> > boot = 'c'
> > acpi = '1'
> > apic = '1'
> > viridian = '1'
> > xen_platform_pci = '1'
> > serial = 'pty'
> > vga = 'stdvga'
> > videoram = '16'
> > sdl = '0'
> > vnc = '1'
> > vnclisten = '0.0.0.0'
> > vncdisplay = '1'
> > usb = '1'
> > usbdevice = 'tablet'
> > --- End of domain configuration file ---
> >
> > But the same configuration with Xen 4.16 and Qemu 7.1 in dom0 that is in Debian
> > unstable, and also in Fedora 36 with Xen 4.16 and Qemu 6.2 I think, I get a crash at
> > boot - it does show the Tiano Core configuration screen and grub screen at 800x600
> > resolution but crashes soon after. When trying to boot Fedora 36 in a Xen HVM with
> > ovmf, I got this in the journal of the guest:
> >
> > xen-qemu-system-i386: relocate_memory 4096 pages from GFN bf000 to GFN c1000 failed: Invalid argument
> >
> > Also, with a good boot (using seabios) I get this in the journal of the guest,
> > but is missing from the boot that crashes:
> >
> > fedora kernel: BIOS-e820: [mem 0x00000000fc000000-0x00000000fcffffff] reserved
> >
> > The size of this missing entry is 4096 pages, which is probably what Qemu is trying to
> > relocate but cannot with ovmf/uefi boot because it is missing. 4096 pages is 16 MB,
> > which is probably the video shared memory.
> >
> > This is probably a bug/regression in Xen somewhere between Xen 4.14 and 4.16
> > and I will try to bisect it when I have time.
> >
> > Best regards,
> >
> > Chuck
> >
> >> that are not recognized by the operating system when using
> >> UEFI and do not load specific drivers. For example, the problem is
> >> solved using qxl and a driver in Windows, but the qxl development is not
> >> complete and fails.
> >>
> >> With limitations, it seems that the problem in QEMU is solved by
> >> changing the parameters in the BIOS and doing a warm/soft reboot. I
> >> don't know why, this can't be done in xen. The settings are never saved
> >> and the reboot, at least in windows 10, is always a cold one (xen
> >> destroys the virtual machine and recreates it. The soft reboot parameter
> >> hangs the vm).
> >>
> >> Regards.
> >>
> >> __________
> >> MhBeyle ___
> >>
> >>
> >>
> >
>
>



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 12:06:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 12:06:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417943.662669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogm7p-0005LK-NW; Fri, 07 Oct 2022 12:06:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417943.662669; Fri, 07 Oct 2022 12:06:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogm7p-0005LD-Js; Fri, 07 Oct 2022 12:06:45 +0000
Received: by outflank-mailman (input) for mailman id 417943;
 Fri, 07 Oct 2022 12:06:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogm7o-0005L3-T6; Fri, 07 Oct 2022 12:06:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogm7o-0000vD-KK; Fri, 07 Oct 2022 12:06:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogm7o-0008Ja-3h; Fri, 07 Oct 2022 12:06:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogm7o-0000bG-3D; Fri, 07 Oct 2022 12:06:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Y1d80fUsYfe676qrPWtMRBvMrkIU9FC9RJcx9moM1OE=; b=BSJfT0ll3hDPLUxKHQmjgbNiCj
	RLcf7AA6fg3vlndSf+INVjEXt0FXTWOWkY7nPMHHbuMrgcSUG40otDi2FqHMWTuzQyVG70VWUoKL/
	xql54lKqrgKdAlyD/QXxfrTxUpKlZeWPHACsEAV8K30i6arq9gr6jB7IADCo9Bgi33YU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173452-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173452: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=66a5633aa038f4abb4455463755974febac69034
X-Osstest-Versions-That:
    xen=66a5633aa038f4abb4455463755974febac69034
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 12:06:44 +0000

flight 173452 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173452/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  7 xen-install fail pass in 173436
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat  fail pass in 173436

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173436
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173436
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173436
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173436
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173436
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173436
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173436
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173436
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173436
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173436
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173436
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173436
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  66a5633aa038f4abb4455463755974febac69034
baseline version:
 xen                  66a5633aa038f4abb4455463755974febac69034

Last test of basis   173452  2022-10-07 01:54:41 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 12:40:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 12:40:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417959.662680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmeO-0001MF-Cw; Fri, 07 Oct 2022 12:40:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417959.662680; Fri, 07 Oct 2022 12:40:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmeO-0001M8-9Q; Fri, 07 Oct 2022 12:40:24 +0000
Received: by outflank-mailman (input) for mailman id 417959;
 Fri, 07 Oct 2022 12:40:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4NbG=2I=gmail.com=matiasevara@srs-se1.protection.inumbo.net>)
 id 1ogmeM-0001M2-Ln
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 12:40:22 +0000
Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com
 [2a00:1450:4864:20::331])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33032f2f-463d-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 14:40:18 +0200 (CEST)
Received: by mail-wm1-x331.google.com with SMTP id
 fn7-20020a05600c688700b003b4fb113b86so2540736wmb.0
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 05:40:21 -0700 (PDT)
Received: from localhost.localdomain ([2a01:e0a:19f:35f0:dde5:d55a:20f5:7ef5])
 by smtp.gmail.com with ESMTPSA id
 o19-20020a05600c511300b003b95ed78275sm2237208wms.20.2022.10.07.05.40.19
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 07 Oct 2022 05:40:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33032f2f-463d-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=cgcFCITeu4HKAZxbFbtR7mI32hhOQAdbLcr9dKWtwcA=;
        b=YYi0KEyjP2tJXFjAELVgng47wKhF4qMeSoZGIpv7BNeRGdAJ6xsPpN/zx5uty6zQR6
         i8fQhg26lG42Jok9XfcWjWygxf2lUykKnA1hGJeOQa7ODxCyNldzu52BKvdlIGn0uuMd
         8lyE7EmQjDYi2347mooqZkiE7NC82UrdncaB5SFDGuVmRT8d3o4eMI5/Unww9LpB4ezz
         Uo+RKrUMYvru9rBuDm6OV24c9iQaiKPXL7Yn5jhggyZrknk8vFGrsQFK1ahH0PlSgePv
         IZ7AezmCIjKtfW0wbprB3u0dqQYr4uMXv+7q/S/my0nzytwqv0sKVnQsdH6k/8om6nuv
         KKHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=cgcFCITeu4HKAZxbFbtR7mI32hhOQAdbLcr9dKWtwcA=;
        b=lPMZFTD1l3R4pAHjgHBeTZLN/0jPWbzoMe2QMrPAGUfuuOBpt6O2b2zL6mLbVD8CQL
         709l9gn9jo1UFfHxYFeSU2GV9y+a1HVcnPLFxl3qzVsJErVF+O98y1pYjmVRm5bE/VF9
         QSE+5s5o2Ki2g/1ym/5anPFV/B+6kw1OKKvIFmHnrgyCgFjll8XtKcLbFJ7ZiJUJn+k4
         6RGUTlWpaKJzHvbhyzu/YmN5kvXXbLUjp/YFbg4ICsUwCESWUFuwuFj4oN/kePmxgOGi
         r1qS8nX2LWP6zKN/2nl5agF2uZCSZ7HaaAJwa/cDEBJAoRPCDqZ70hiAsutys09sgzgO
         EirQ==
X-Gm-Message-State: ACrzQf0USTBauezviA2Uhvlw0BM5IxBXwpclNKThPFlI5DIjsXR4TSC1
	LyBb1YoH1LIyIv5mapYc2jWli8ixcckZqQ==
X-Google-Smtp-Source: AMsMyM6JmfzfMWZSshH3hNDBr6rqDutJGMinObXg5Xmy5/HunJIhEcusYByL2jMtapaPcMZZQx/IWw==
X-Received: by 2002:a05:600c:154a:b0:3b4:c9ec:41df with SMTP id f10-20020a05600c154a00b003b4c9ec41dfmr9783583wmg.109.1665146420547;
        Fri, 07 Oct 2022 05:40:20 -0700 (PDT)
From: Matias Ezequiel Vara Larsen <matiasevara@gmail.com>
X-Google-Original-From: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [RFC PATCH v2 0/2] Add a new acquire resource to query vcpu statistics
Date: Fri,  7 Oct 2022 14:39:52 +0200
Message-Id: <cover.1665138677.git.matias.vara@vates.fr>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hello all,

The purpose of this RFC is to get feedback about a new acquire resource that
exposes vcpu statistics for a given domain. The current mechanism to get those
statistics is by querying the hypervisor. This mechanism relies on a hypercall
and holds the domctl spinlock during its execution. When a pv tool like xcp-rrdd
periodically samples these counters, it ends up affecting other paths that share
that spinlock. By using acquire resources, the pv tool only requires a few
hypercalls to set the shared memory region and samples are got without issuing
any other hypercall. The original idea has been suggested by Andrew Cooper to
which I have been discussing about how to implement the current PoC. You can
find the RFC patch series at [1]. The series is rebased on top of stable-4.15.

I am currently a bit blocked on 1) what to expose and 2) how to expose it. For
1), I decided to expose what xcp-rrdd is querying, e.g., XEN_DOMCTL_getvcpuinfo.
More precisely, xcp-rrd gets runstate.time[RUNSTATE_running]. This is a uint64_t
counter. However, the time spent in other states may be interesting too.
Regarding 2), I am not sure if simply using an array of uint64_t is enough or if
a different interface should be exposed. The remaining question is when to get
new values. For the moment, I am updating this counter during
vcpu_runstate_change().

The current series includes a simple pv tool that shows how this new interface is
used. This tool maps the counter and periodically samples it.

Any feedback/help would be appreciated.

Thanks, Matias.

[1] https://github.com/MatiasVara/xen/tree/feature_stats

Changes in v2:
- rework to ensure that consumer fetches consistent data

Changes in v1:
- rework how the resource is allocated and released
- rework when the resource is allocated that happens only when the resource is
  requested 
- rework the structure shared between the tool and Xen to make it extensible to
  new counters and declare it in a public header

There are still the following questions:
   - resource shall be released when there are no more readers otherwise we keep
     updating it during a hot path
   - one frame can host up to 512 vcpus. Should I check to this limit when
     updating? Should it be possible to allocate more than one frame for vcpu
     counters? 

Matias Ezequiel Vara Larsen (2):
  xen/memory : Add a stats_table resource type
  tools/misc: Add xen-vcpus-stats tool

 tools/misc/Makefile          |  6 +++
 tools/misc/xen-vcpus-stats.c | 87 +++++++++++++++++++++++++++++++++
 xen/arch/x86/hvm/hvm.c       |  2 +
 xen/common/memory.c          | 94 ++++++++++++++++++++++++++++++++++++
 xen/common/sched/core.c      | 16 ++++++
 xen/include/public/memory.h  |  3 ++
 xen/include/public/vcpu.h    | 16 ++++++
 xen/include/xen/mm.h         |  2 +
 xen/include/xen/sched.h      |  5 ++
 9 files changed, 231 insertions(+)
 create mode 100644 tools/misc/xen-vcpus-stats.c

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 12:40:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 12:40:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417961.662702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmeS-0001sH-RV; Fri, 07 Oct 2022 12:40:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417961.662702; Fri, 07 Oct 2022 12:40:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmeS-0001s2-OM; Fri, 07 Oct 2022 12:40:28 +0000
Received: by outflank-mailman (input) for mailman id 417961;
 Fri, 07 Oct 2022 12:40:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4NbG=2I=gmail.com=matiasevara@srs-se1.protection.inumbo.net>)
 id 1ogmeR-0001bd-6n
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 12:40:27 +0000
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [2a00:1450:4864:20::42b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37b9ad0a-463d-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 14:40:26 +0200 (CEST)
Received: by mail-wr1-x42b.google.com with SMTP id bk15so7078385wrb.13
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 05:40:26 -0700 (PDT)
Received: from localhost.localdomain ([2a01:e0a:19f:35f0:dde5:d55a:20f5:7ef5])
 by smtp.gmail.com with ESMTPSA id
 o19-20020a05600c511300b003b95ed78275sm2237208wms.20.2022.10.07.05.40.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 07 Oct 2022 05:40:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37b9ad0a-463d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=kdQ1ywQBPJum0BhihWVir9mOqof1BeIfrkRzabeE3Hc=;
        b=E0ADwO8//FyPWDkI1qNXQzo+uMNfFFvYXI9dyWDDOHF7UAhnVcYd4b7bcSQv+JzMfW
         2LGrMjIdEJEWedb3EaxCpq98+jzle/oiUHg2nw4vbyrLGWiSuXcgUKVDVcNh/jBZnlno
         9TzUhcX+zZtA3YeRCfVY70mIWtTUjzvRSgMmzbxvZmr8RvDDyTRAG+zMEVPrDxflH4Py
         uNc93Mt+qho0vWhGM5gOu1exoWkjFFAwAVAk2v7fqoRHUXxtd+K/saxwkXIiVM7WB9xR
         9RQSivs6MxVqouYl74zmHRSn6JUpHsv/wMusIqp+NhKZb9Cs/+Nsw/19WouDQFTgF7Zd
         xylA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=kdQ1ywQBPJum0BhihWVir9mOqof1BeIfrkRzabeE3Hc=;
        b=TVvfmt3wLmPxHTSnRJgDZ18sthZSrfy1LmA7jjcJyX3TWV+vm092sdmXoKdJrDS3vy
         PYY3ptVwIbFzsRxnrYb2P366R3c42pilhjdb1YOfPxOMAUAPpSAwF4UX+bc52SX+azq3
         /nTBs24s3Exw1u+sMqg1+o/bpeVzYFp1PCrpmACXDv07gEP6cSmjwR30EGF9Gzg9Px37
         NJi2IoOi+fDVjklVhui1We3GGx2G7BiVJRg4C2+ojvPo+BC3K9/jQpfxSSaVsk3WaVSj
         kkjuINtbenj19YWm+21kQIb3hnvHaI8Hv+rsF2/Y/hq8IeLCe+YOLN0J/tyj8FDm6CoR
         qfyg==
X-Gm-Message-State: ACrzQf3pH2hTIeqptWPHV/NMSh3DLrMrU3VVFwdhLBXAQbS9E5P91CTp
	eQduOJgKWwui+xQocm6b+PTQlxHcl7+gSQ==
X-Google-Smtp-Source: AMsMyM6OCUBQH3Pu7RIknEpoknCMQbVu/GUlRpRvhhk9hW2I+5N2SYNC5lpnXJTbba7O5yVG2vWJ5A==
X-Received: by 2002:a5d:674f:0:b0:22e:3d59:cf0f with SMTP id l15-20020a5d674f000000b0022e3d59cf0fmr3172589wrw.304.1665146425560;
        Fri, 07 Oct 2022 05:40:25 -0700 (PDT)
From: Matias Ezequiel Vara Larsen <matiasevara@gmail.com>
X-Google-Original-From: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool
Date: Fri,  7 Oct 2022 14:39:54 +0200
Message-Id: <df706d6dcfba965909d776dda163fdb261d1a0ea.1665138677.git.matias.vara@vates.fr>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1665138677.git.matias.vara@vates.fr>
References: <cover.1665138677.git.matias.vara@vates.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a demonstration tool that uses the stats_table resource to
query vcpus' RUNSTATE_running counter for a DomU.

Signed-off-by: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>
---
Changes in v2:
- use period instead of frec
- rely on version to ensure reading is coherent 

Changes in v1:
- change the name of the tool to xen-vcpus-stats
- set command line parameters in the same order that are passed
- remove header libs.h
- build by default
- remove errno, strerrno, "\n", and identation
- use errx when errno is not needed
- address better the number of pages requested and error msgs
- use the shared_vcpustatspage_t structure
- use the correct frame id when requesting the resource
---
 tools/misc/Makefile          |  6 +++
 tools/misc/xen-vcpus-stats.c | 87 ++++++++++++++++++++++++++++++++++++
 2 files changed, 93 insertions(+)
 create mode 100644 tools/misc/xen-vcpus-stats.c

diff --git a/tools/misc/Makefile b/tools/misc/Makefile
index 2b683819d4..837e4b50da 100644
--- a/tools/misc/Makefile
+++ b/tools/misc/Makefile
@@ -49,6 +49,7 @@ TARGETS_COPY += xenpvnetboot
 
 # Everything which needs to be built
 TARGETS_BUILD := $(filter-out $(TARGETS_COPY),$(TARGETS_ALL))
+TARGETS_BUILD += xen-vcpus-stats
 
 # ... including build-only targets
 TARGETS_BUILD-$(CONFIG_X86)    += xen-vmtrace
@@ -135,4 +136,9 @@ xencov: xencov.o
 xen-ucode: xen-ucode.o
 	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS)
 
+xen-vcpus-stats.o: CFLAGS += $(CFLAGS_libxenforeginmemory)
+
+xen-vcpus-stats: xen-vcpus-stats.o
+	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS)
+
 -include $(DEPS_INCLUDE)
diff --git a/tools/misc/xen-vcpus-stats.c b/tools/misc/xen-vcpus-stats.c
new file mode 100644
index 0000000000..29d0efb124
--- /dev/null
+++ b/tools/misc/xen-vcpus-stats.c
@@ -0,0 +1,87 @@
+#include <err.h>
+#include <errno.h>
+#include <error.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/mman.h>
+#include <signal.h>
+
+#include <xenctrl.h>
+#include <xenforeignmemory.h>
+#include <xen/vcpu.h>
+
+#define rmb()   asm volatile("lfence":::"memory")
+
+static sig_atomic_t interrupted;
+static void close_handler(int signum)
+{
+    interrupted = 1;
+}
+
+int main(int argc, char **argv)
+{
+    xenforeignmemory_handle *fh;
+    xenforeignmemory_resource_handle *res;
+    size_t size;
+    int rc, domid, period, vcpu;
+    shared_vcpustatspage_t * info;
+    struct sigaction act;
+    uint32_t version;
+    uint64_t value;
+
+    if (argc != 4 ) {
+        fprintf(stderr, "Usage: %s <domid> <vcpu> <period>\n", argv[0]);
+        return 1;
+    }
+
+    domid = atoi(argv[1]);
+    vcpu = atoi(argv[2]);
+    period = atoi(argv[3]);
+
+    act.sa_handler = close_handler;
+    act.sa_flags = 0;
+    sigemptyset(&act.sa_mask);
+    sigaction(SIGHUP,  &act, NULL);
+    sigaction(SIGTERM, &act, NULL);
+    sigaction(SIGINT,  &act, NULL);
+    sigaction(SIGALRM, &act, NULL);
+
+    fh = xenforeignmemory_open(NULL, 0);
+
+    if ( !fh )
+        err(1, "xenforeignmemory_open");
+
+    rc = xenforeignmemory_resource_size(
+        fh, domid, XENMEM_resource_stats_table,
+        0, &size);
+
+    if ( rc )
+        err(1, "Fail: Get size");
+
+    res = xenforeignmemory_map_resource(
+        fh, domid, XENMEM_resource_stats_table,
+        0, XENMEM_resource_stats_frame_vcpustats, size >> XC_PAGE_SHIFT,
+        (void **)&info, PROT_READ, 0);
+
+    if ( !res )
+        err(1, "Fail: Map");
+
+    while ( !interrupted ) {
+        sleep(period);
+        do {
+            version = info->vcpu_info[vcpu].version;
+            rmb();
+            value = info->vcpu_info[vcpu].runstate_running_time;
+            rmb();
+        } while ((info->vcpu_info[vcpu].version & 1) ||
+                (version != info->vcpu_info[vcpu].version));
+        printf("running_vcpu_time[%d]: %ld\n", vcpu, value);
+    }
+
+    rc = xenforeignmemory_unmap_resource(fh, res);
+    if ( rc )
+        err(1, "Fail: Unmap");
+
+    return 0;
+}
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 12:40:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 12:40:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417960.662691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmeR-0001c9-Iz; Fri, 07 Oct 2022 12:40:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417960.662691; Fri, 07 Oct 2022 12:40:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmeR-0001c2-Fx; Fri, 07 Oct 2022 12:40:27 +0000
Received: by outflank-mailman (input) for mailman id 417960;
 Fri, 07 Oct 2022 12:40:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4NbG=2I=gmail.com=matiasevara@srs-se1.protection.inumbo.net>)
 id 1ogmeQ-0001bd-0U
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 12:40:26 +0000
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com
 [2a00:1450:4864:20::433])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3690c7cf-463d-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 14:40:24 +0200 (CEST)
Received: by mail-wr1-x433.google.com with SMTP id bu30so7104905wrb.8
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 05:40:24 -0700 (PDT)
Received: from localhost.localdomain ([2a01:e0a:19f:35f0:dde5:d55a:20f5:7ef5])
 by smtp.gmail.com with ESMTPSA id
 o19-20020a05600c511300b003b95ed78275sm2237208wms.20.2022.10.07.05.40.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 07 Oct 2022 05:40:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3690c7cf-463d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=l7DXPQ0Ol36lIEkiwQv5EhGYaewpw0fwd3bSvTaydbA=;
        b=fV/GOpuAgJXrH4iQ3IWDCQF8tX2Ucrof///Y8UO3GkK93NPM5Kiy9AJm7jw1ZAFYIT
         b2lDR0xdwJRenO/2tWSXQI3b/vyoNEXxF3aSZBW6VJghAGWLJOXUY35VVM5W03mYhtAc
         LIA1le30btJG9jklZGvwVELdQlErgX7UXDnncYpHVQnOeVFTCDC7dxe4+Se1/SEcYeqo
         +w2F0nIgWjhFRJtFXbvFkH4lz0wM4GMSNx7kxqgQoGo4JwMZU1COmN0qAFEV7dcMqfKL
         aFs/TTJjopK1jWQy9BdoCaDLD/X0jq1xRuGKXMgMbVkKcWBBUGvQMtazXQCK2rrZnwON
         LqoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=l7DXPQ0Ol36lIEkiwQv5EhGYaewpw0fwd3bSvTaydbA=;
        b=rNPLJXGHkWItBmemLSlcYKBFFIzy/FXQOVgPNQshkNXdqbWQynSQgQycIqBxBJ+IqJ
         wDIphhJkvo1doJraav23PppuI2ghKG3z2M+Y5HM+6UKggl6leG+F/uMqOAy8Ro3yEz6c
         s7jGKj8T+66+DWrHCRjqwwkawR2dWG6QPFwU+q4l4iV/urOkW9ePEG3vdKGrvkkfQEEA
         6efGymF0nbJU9lF0IdPlWRJzNf9pcdVgvFdK78oHlrhQYFw6XHlaXmk+AXaY+I5e8pKz
         lmYShgEVNeu6yVCAExsvE/IBnEBB+TzC9XBQXUcdP+Fdg1hVKjmlnxNFXM7/BoyrhOD5
         xxlw==
X-Gm-Message-State: ACrzQf3KzuQhLxBYxvAvE5slob2r69UEwRp2lH6zVx7gQPACOHNQ880r
	OXkx8d9Ej3UtamTaAKrKP4+goU8/7p2ZDQ==
X-Google-Smtp-Source: AMsMyM6/tKYPAIgdd8Ezu6OCrYePPn73oQ9O/uBjnx8rjsgZ23ETzMfJagM+j/3+1lXwi1GO5FlGMA==
X-Received: by 2002:a5d:5a9d:0:b0:225:2783:d6f1 with SMTP id bp29-20020a5d5a9d000000b002252783d6f1mr3167811wrb.385.1665146423511;
        Fri, 07 Oct 2022 05:40:23 -0700 (PDT)
From: Matias Ezequiel Vara Larsen <matiasevara@gmail.com>
X-Google-Original-From: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>
To: xen-devel@lists.xenproject.org
Cc: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type
Date: Fri,  7 Oct 2022 14:39:53 +0200
Message-Id: <af6032c9f5863b7e6fb183a0a197407ec92bb067.1665138677.git.matias.vara@vates.fr>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1665138677.git.matias.vara@vates.fr>
References: <cover.1665138677.git.matias.vara@vates.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This commit proposes a new mechanism to query the RUNSTATE_running counter for
a given vcpu from a dom0 userspace application. This commit proposes to expose
that counter by using the acquire_resource interface. The current mechanism
relies on the XEN_DOMCTL_getvcpuinfo and holds a single global domctl_lock for
the entire hypercall; and iterate over every vcpu in the system for every
update thus impacting operations that share that lock.

This commit proposes to expose vcpu RUNSTATE_running via the
xenforeignmemory interface thus preventing to issue the hypercall and holding
the lock. For that purpose, a new resource type named stats_table is added. The
first frame of this resource stores per-vcpu counters. The frame has one entry
of type struct vcpu_stats per vcpu. The allocation of this frame only happens
if the resource is requested. The frame is released after the domain is
destroyed.

Note that the updating of this counter is in a hot path, thus, in this commit,
copying only happens if it is specifically required.

Note that the exposed structure is extensible in two ways. First, the structure
vcpu_stats can be extended with new per-vcpu counters while it fits in a frame.
Second, new frames can be added in case new counters are required.

Signed-off-by: Matias Ezequiel Vara Larsen <matias.vara@vates.fr>
---
Changes in v2:
- rework to ensure that guest reads a coherent value by using a version
  number in the vcpu_stats structure
- add version to the vcpu_stats structure

Changes in v1:
- rework the allocation and releasing of the frames
- use the zero frame for per-vcpu counters that are listed as an array
- allocate vcpu stats frames only when the resource is requested
- rewrite commit message
- add the vcpu_stats structure to keep per-vcpu counters
- add the shared_vcpustatspage to keep an array of per-vcpu counters for a
  given domain
- declare the structures in a public header 
- define the vcpustats_page in the domain structure
---
 xen/arch/x86/hvm/hvm.c      |  2 +
 xen/common/memory.c         | 94 +++++++++++++++++++++++++++++++++++++
 xen/common/sched/core.c     | 16 +++++++
 xen/include/public/memory.h |  3 ++
 xen/include/public/vcpu.h   | 16 +++++++
 xen/include/xen/mm.h        |  2 +
 xen/include/xen/sched.h     |  5 ++
 7 files changed, 138 insertions(+)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index ddd001a6ad..1ef6cb5ff0 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -741,6 +741,8 @@ void hvm_domain_relinquish_resources(struct domain *d)
 
     ioreq_server_destroy_all(d);
 
+    stats_free_vcpu_mfn(d);
+
     msixtbl_pt_cleanup(d);
 
     /* Stop all asynchronous timer actions. */
diff --git a/xen/common/memory.c b/xen/common/memory.c
index 297b98a562..749486d5d4 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1078,6 +1078,12 @@ unsigned int ioreq_server_max_frames(const struct domain *d)
     return nr;
 }
 
+unsigned int stats_table_max_frames(const struct domain *d)
+{
+    /* One frame per 512 vcpus. */
+    return 1;
+}
+
 /*
  * Return 0 on any kind of error.  Caller converts to -EINVAL.
  *
@@ -1099,6 +1105,9 @@ static unsigned int resource_max_frames(const struct domain *d,
     case XENMEM_resource_vmtrace_buf:
         return d->vmtrace_size >> PAGE_SHIFT;
 
+    case XENMEM_resource_stats_table:
+        return stats_table_max_frames(d);
+
     default:
         return -EOPNOTSUPP;
     }
@@ -1162,6 +1171,88 @@ static int acquire_vmtrace_buf(
     return nr_frames;
 }
 
+void stats_free_vcpu_mfn(struct domain * d)
+{
+    struct page_info *pg = d->vcpustats_page.pg;
+
+    if ( !pg )
+        return;
+
+    d->vcpustats_page.pg = NULL;
+
+    if ( d->vcpustats_page.va )
+        unmap_domain_page_global(d->vcpustats_page.va);
+
+    d->vcpustats_page.va = NULL;
+
+    put_page_alloc_ref(pg);
+    put_page_and_type(pg);
+}
+
+static int stats_vcpu_alloc_mfn(struct domain *d)
+{
+    struct page_info *pg;
+
+    pg = alloc_domheap_page(d, MEMF_no_refcount);
+
+    if ( !pg )
+        return -ENOMEM;
+
+    if ( !get_page_and_type(pg, d, PGT_writable_page) ) {
+        put_page_alloc_ref(pg);
+        return -ENODATA;
+    }
+
+    d->vcpustats_page.va = __map_domain_page_global(pg);
+    if ( !d->vcpustats_page.va )
+        goto fail;
+
+    d->vcpustats_page.pg = pg;
+    clear_page(d->vcpustats_page.va);
+    return 1;
+
+fail:
+    put_page_alloc_ref(pg);
+    put_page_and_type(pg);
+
+    return -ENOMEM;
+}
+
+static int acquire_stats_table(struct domain *d,
+                                unsigned int id,
+                                unsigned int frame,
+                                unsigned int nr_frames,
+                                xen_pfn_t mfn_list[])
+{
+    mfn_t mfn;
+    int rc;
+    unsigned int i;
+
+    if ( !d )
+        return -ENOENT;
+
+    for ( i = 0; i < nr_frames; i++ )
+    {
+        switch ( i )
+        {
+        case XENMEM_resource_stats_frame_vcpustats:
+            if ( !d->vcpustats_page.pg ) {
+                rc = stats_vcpu_alloc_mfn(d);
+                if ( rc < 1 )
+                    return rc;
+            }
+            mfn = page_to_mfn(d->vcpustats_page.pg);
+            mfn_list[i] = mfn_x(mfn);
+            break;
+
+        default:
+            return -EINVAL;
+        }
+    }
+
+    return nr_frames;
+}
+
 /*
  * Returns -errno on error, or positive in the range [1, nr_frames] on
  * success.  Returning less than nr_frames contitutes a request for a
@@ -1182,6 +1273,9 @@ static int _acquire_resource(
     case XENMEM_resource_vmtrace_buf:
         return acquire_vmtrace_buf(d, id, frame, nr_frames, mfn_list);
 
+    case XENMEM_resource_stats_table:
+        return acquire_stats_table(d, id, frame, nr_frames, mfn_list);
+
     default:
         return -EOPNOTSUPP;
     }
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..3543a531a1 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -264,6 +264,8 @@ static inline void vcpu_runstate_change(
 {
     s_time_t delta;
     struct sched_unit *unit = v->sched_unit;
+    shared_vcpustatspage_t * vcpustats_va;
+    struct domain *d = v->domain;
 
     ASSERT(spin_is_locked(get_sched_res(v->processor)->schedule_lock));
     if ( v->runstate.state == new_state )
@@ -287,6 +289,20 @@ static inline void vcpu_runstate_change(
     }
 
     v->runstate.state = new_state;
+
+    vcpustats_va = (shared_vcpustatspage_t*)d->vcpustats_page.va;
+    if ( vcpustats_va )
+    {
+	vcpustats_va->vcpu_info[v->vcpu_id].version =
+	    version_update_begin(vcpustats_va->vcpu_info[v->vcpu_id].version);
+        smp_wmb();
+        memcpy(&vcpustats_va->vcpu_info[v->vcpu_id].runstate_running_time,
+               &v->runstate.time[RUNSTATE_running],
+               sizeof(v->runstate.time[RUNSTATE_running]));
+        smp_wmb();
+        vcpustats_va->vcpu_info[v->vcpu_id].version =
+            version_update_end(vcpustats_va->vcpu_info[v->vcpu_id].version);
+    }
 }
 
 void sched_guest_idle(void (*idle) (void), unsigned int cpu)
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 50e73eef98..e1a10b8b97 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -626,6 +626,7 @@ struct xen_mem_acquire_resource {
 #define XENMEM_resource_ioreq_server 0
 #define XENMEM_resource_grant_table 1
 #define XENMEM_resource_vmtrace_buf 2
+#define XENMEM_resource_stats_table 3
 
     /*
      * IN - a type-specific resource identifier, which must be zero
@@ -683,6 +684,8 @@ struct xen_mem_acquire_resource {
 typedef struct xen_mem_acquire_resource xen_mem_acquire_resource_t;
 DEFINE_XEN_GUEST_HANDLE(xen_mem_acquire_resource_t);
 
+#define XENMEM_resource_stats_frame_vcpustats 0
+
 /*
  * XENMEM_get_vnumainfo used by guest to get
  * vNUMA topology from hypervisor.
diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h
index 3623af932f..5c1812dfd2 100644
--- a/xen/include/public/vcpu.h
+++ b/xen/include/public/vcpu.h
@@ -235,6 +235,22 @@ struct vcpu_register_time_memory_area {
 typedef struct vcpu_register_time_memory_area vcpu_register_time_memory_area_t;
 DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t);
 
+struct vcpu_stats{
+    /* If the least-significant bit of the version number is set then an update
+     * is in progress and the guest must wait to read a consistent set of values
+     * This mechanism is similar to Linux's seqlock.
+     */
+    uint32_t version;
+    uint32_t pad0;
+    uint64_t runstate_running_time;
+};
+
+struct shared_vcpustatspage {
+    struct vcpu_stats vcpu_info[1];
+};
+
+typedef struct shared_vcpustatspage shared_vcpustatspage_t;
+
 #endif /* __XEN_PUBLIC_VCPU_H__ */
 
 /*
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index 667f9dac83..d1ca8b9aa8 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -134,6 +134,8 @@ int assign_pages(
 /* Dump info to serial console */
 void arch_dump_shared_mem_info(void);
 
+void stats_free_vcpu_mfn(struct domain * d);
+
 /*
  * Extra fault info types which are used to further describe
  * the source of an access violation.
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 5485d08afb..d9551ce35f 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -577,6 +577,11 @@ struct domain
         struct ioreq_server     *server[MAX_NR_IOREQ_SERVERS];
     } ioreq_server;
 #endif
+    /* Page that hosts vcpu stats */
+    struct {
+        struct page_info *pg;
+        void *va;
+    } vcpustats_page;
 };
 
 static inline struct page_list_head *page_to_list(
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 12:51:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 12:51:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417978.662713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmor-00043e-RR; Fri, 07 Oct 2022 12:51:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417978.662713; Fri, 07 Oct 2022 12:51:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogmor-00043X-OC; Fri, 07 Oct 2022 12:51:13 +0000
Received: by outflank-mailman (input) for mailman id 417978;
 Fri, 07 Oct 2022 12:51:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SCdg=2I=citrix.com=prvs=2723a6b7f=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ogmop-00043R-Q8
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 12:51:11 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b30111bb-463e-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 14:51:04 +0200 (CEST)
Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 07 Oct 2022 08:51:01 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by DM8PR03MB6245.namprd03.prod.outlook.com (2603:10b6:8:32::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 7 Oct
 2022 12:50:59 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%7]) with mapi id 15.20.5676.032; Fri, 7 Oct 2022
 12:50:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b30111bb-463e-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665147067;
  h=from:to:subject:date:message-id:mime-version;
  bh=4niM8e1iZ9AOUUXfai6ODxFRpXhS9pTHqAUwctG0yyw=;
  b=T5wSoYCwj/IftK5shBAstnujpq+qhk6k6h1cj0gLXqQG6+d6/+1ZTg2F
   X5o+tmTT6v94vMkYkaI3C5pu8MP+WMa34UgNAmLMcjkpUCo9pepmhHtN6
   UCnJw5tlI3tkdbTtFAzDnJImWBqe7sndyCT/RXFa9VuQle7vEyof+puCu
   8=;
X-IronPort-RemoteIP: 104.47.70.107
X-IronPort-MID: 81840090
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:53Ym7a0UsV0UGJHne/bD5SVwkn2cJEfYwER7XKvMYbSIYQITYwd3j
 TtIBzjCf73ffDO2KOnCW/2+pEIDsMWBzd9lG1Btqn08QS4VpJeeC9/IcRatNXObf5bIHElpt
 ZROMtedc55oQyKArE3zOLHt8HIkiq3WHeWsYAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm
 Put8sfSZgKvhjd4bWxLsayKpU8wta37tT5A5QU1bKBAtg6CmyEZAqxEKPDqJRMUYGX28s2SH
 L+fke7jrgs12z93V7tJR56iKhVirob6ZFTI0DwOM0SbqkAqjjQo1aomP+YrZ05SijGY9/h80
 9wIvpGrIesTFvSkdN81Dl8JTkmSAYUcoOWdeCDn7pTKp6H7WyCEL8tGXRle0bIwoo6bMUkWn
 dQEJTYEaAy0hu7e6NpXncE126zPhOGyVG8ukikIIQPxVJ7KcriaK0n+3vdK3S9Yuyx7Na22i
 /z1y9ZYRE+ojxVnYj/7AX+l9QuiriGXnzZw8Dp5qUerioR6IcMYPLXFabLoltK2qcp9uRmKv
 GLquHbDKRwjKfif8hW082Oombqa9c/7cNp6+LyQ0NdP2QXW7EpMTRocWB28vOWzjVO4V5RHM
 UsI9yEyrK80sku2Ut36WB7+q3mB1vIec4MIT6tmt0fSkuyNu1nx6mssF1atbPQJucgsSjFs+
 kKPm9rxLTdurKeUWTSW8bL8QTaaaXFFcTdaNHdsoQ0toP3Yg48DsTb1EfkkEIOrvszWGjWgz
 GXfxMQ5r/BJ5SIR7I2r8FaCjz+yq5zhSg8u+h6RTm+j9hl+ZoOue8qv81ez0BpbBIOQT13Et
 n5bncGbtbgKFcvUzHPLR/gRFra04frDKCfbnVNkA5gm8XKq5mKneodTpjp5IS+FL/o5RNMgW
 2eL0Ss52XOZFCLCgXNfC25pN/kX8A==
IronPort-HdrOrdr: A9a23:tvXbf6kWdO4/zR50L67UMry2kFvpDfOvimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7Sc+9qADnhOdICOgqTP6ftWzd1FdAQ7sSibcKrweAJ8SczJ8U6U
 4DSdkYNDSYNzET4qjHCWKDYrUdKay8gcWVbJDlvhVQpG9RC51I3kNcMEK2A0d2TA5JCd4SD5
 yH/PdKoDKmZDA+ctm7LmNtZZmIm/T70LbdJTIWDR8u7weDyRmy7qThLhSe1hACFxtS3LYZ93
 TfmQCR3NTvjxj78G6R64bg1eUZpDLT8KoDOCVKsLlUFtzYsHfmWG2mYczAgNl6mpDs1L9gqq
 i1n/5pBbUJ15qWRBD/nfKl4Xic7B8+r3Dl0lOWmn3lvIjwQy87EdNIgcZDfgLe8FdIhqAJ7E
 rat1jpzaa/ICmw7hgV3eK4Ii1Chw6xuz4vgOQTh3tQXc8Xb6JQt5UW+AdQHI0bFCz35Yg7GK
 02Zfusksp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIgUn2sG9pg6V55Yjt
 60RZhAhfVLVIsbfKh9DOAOTY++DXHMWwvFNCaILVHuBMg8SgHwQl7MkcUIDc2RCeI1JcEJ6e
 j8uXtjxBEPUlOrD9GS15tW9R2ISHmhXF3Wu7Bj26Q=
X-IronPort-AV: E=Sophos;i="5.95,166,1661832000"; 
   d="asc'?scan'208";a="81840090"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JbE35edOF3dgPfXOrywh0vCTBDq/mJkWC/QmWmelupVOQetLHGOdvrxjgO10cuaYr/gVXhHCDWcDH6RpfDAEo+fakBJSTTQWoo7G6JLTV+ccMrtoDy0kDEyJnD1Dcwd3NgQ6dP7kwDHmoqXdJX/p7caq+MLhKedYFgIMTkjRgjt8MJCyuoGR3EGlGqRe0sq/0JRupe7DKVb4WZM8WP48uou/UH1i8T6fvXcZizHLUlTpD7mV4tkccN6GH/zdVti1chz6hfiDqyd0PagLkECYPf1Liol94a4nniaQvCAqsVhnYswtMSyt2/6dSDNzeBTAP0k0SN6yC/RCBAfclP6zZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YuA8KWFhzq67ORrJrlMBqopD8OAJKPj6HyPtO9fF1Qc=;
 b=oQnLEV2wItJfgk6uUHaeMmf0cB/67FLB7xGMtzsv/dT0CEiutunS5iXXimkXrtQQ1L0MQ4uQmjJAC3odOHqTGPzjATMaG9qq1pW+mBFOUm6C+ivcCCXCQtuE3KoR9LUPPE0EPceC9hdpB5cyxWhOiNACvYfrbClNlwJzMYnl9rwcTQCneP+krY6RUOGkJwjvooGTQvRfW4QcVybXWtzndCer+R+Dwcuc2y7uGTr7/kBu40VfSHA0siK2lOuQpLLpu5o5CWxBnJZ6jTtFFkx87sA3LXNNYqDwVU2lq3oPsDxzF6ATIbAydJccLJzd3KT3PD2EByhwu/h+DAsku3KONQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YuA8KWFhzq67ORrJrlMBqopD8OAJKPj6HyPtO9fF1Qc=;
 b=AY0kjCAplN8uOJq34dc/LHpI0Z0PzV/Rri9Syz3jgljDzUjB2FidU3LuQLi15k7BmUfBUaw0L2CeHpk0jNoHMIOW0U2RvdIGEEWmvy++ep8Fy4oLBZKwc/a1coJ4XO4wtTBm+FuegDFiSryKGuxr/k/3OzoY+Hg/Tf0zMyfD41c=
From: George Dunlap <George.Dunlap@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Subject: xenbits disk space "garbage collection"
Thread-Topic: xenbits disk space "garbage collection"
Thread-Index: AQHY2kty5yg/FDgjgE6XFBAR+Da7aw==
Date: Fri, 7 Oct 2022 12:50:59 +0000
Message-ID: <4ABCA839-C1CD-4132-9DEA-2FB01CA4476E@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|DM8PR03MB6245:EE_
x-ms-office365-filtering-correlation-id: 7f0a2be3-d4c8-4ad4-96fc-08daa862956b
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Dq/pw/4jJ+rUe5yU6VfTx1zwnnrpmjAuTCjPgFw9d3/XYWzioyewS1J5N875LWjXfLQHMhQYwFPC33Deuz/kVSeYn4Peqy5khbgXZlUr7FC5IXvEDOI1HXLhjYDsw+Vz7mZsw+akg9hH1CsQzdDqSkUkLUGLosFmcGKyfIz7GwwgJVYJIcr8xH9v58mgQfJ9yGCN8+xtYWmbMnkmQrFNScdtle/7dOUQwMoWIu4E4NwQ2EsdZrNi9ipbCy0ICzPDPI/oFX1HOTXmnWZ4YjjlaN7cJIQik8gJD9gDZYGUYLT8KcrXyN7l5Qt7aRR7OyKgW5W2VHZ3oqRHCNpQQJP/ReoPcfesE82skvxtlPybb3hjIoEr/TXUpo+jknPx6HlAYzh16EDLrzWugnVODXyqtGgzFXIJ7dHmGYooNbO6b8si+IONQgY4hJ1LVaL+pc7HNdoPvZt8HpeVUuBZKpuQjLZh+btnSCk6JHGzpy15oiYXhZTGlas1NbQttIaWMwWUnw6B1AyoAYzDi7lChpJ+dBc5cKkxuEn0HXMhHLsyFewlrXpmozfzZmo7b61vhATmguIDM4mkjIZVqDuvL0IiwSd0eKEpMWuZwhQ/hfUwkJWgVixAKHvtpM7VYcnCCPcX2KSG4rRQzNduEMdPNPK8Gjfu/2nbrnTO4gRxd9VP2bnLzaaIisE8jCpaPBhA+oJVVZGriFm5NnUAZ8K9YhMrVaUYCNZCmBaH0mOGlbzyDPwiiibnEnZS89dydDcqjc2Zo1yabLke2WTWo7VASo905f0Q7ZZetCQrGpunTLfAsscpctFs29QMrN4I+Blim2sa
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(5660300002)(2616005)(186003)(6512007)(2906002)(38100700002)(91956017)(26005)(6486002)(8676002)(478600001)(41300700001)(6506007)(71200400001)(66556008)(83380400001)(6916009)(66446008)(122000001)(316002)(66946007)(64756008)(4744005)(86362001)(8936002)(76116006)(82960400001)(99936003)(36756003)(66476007)(38070700005)(33656002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MXR6WmtHMU5IK1FTMXdmcjJHdG9OZVNOZHRPdGJPTnd0UVlFdkRKU0NqU05n?=
 =?utf-8?B?bkQ0WmRpalhOZy8vNS9ZYmpxZStWUFJ3OHY4TkxIYkZIMWxNakhXUXRVU0wx?=
 =?utf-8?B?a3NCcFBpS2ozd3FTTEh0OXFOenFWckVKTUJnQlFPbkQ2eVFDbFYxbjRBNyt1?=
 =?utf-8?B?d3IvSW9mbWw3UjZGVWFDZmpCTkd2elI3V0Vyei9nYklIOWNMdDJFWHNwQ0ht?=
 =?utf-8?B?RktSUGd6VmVzLzdJZGw4T2toRVJUQmhBeXVOelBVTTRnZHVXQWtxamhFdE91?=
 =?utf-8?B?TzZ0VDJLMUx2QzViWG9DWHpZNldYcEhvMkI1b2pqVjZ0UkJ0aVp3ZkcvampE?=
 =?utf-8?B?eE1DQkVNR1h3UkZRTlgydmhPYktDK0xlODlBUFZTZituMW14UDg5N2M0TG5o?=
 =?utf-8?B?Y0ZrL2hGaDhpVXVZaUxpTGdYS2tlbUVMRi96SlhRb2pHZlllVUFBZUFrK2Ur?=
 =?utf-8?B?SUNvU1ZhamdtdUJoQVhNYXNhQUhqWTJiSEgwNyt5bzFxVXJSV3M3Q2FxN3hQ?=
 =?utf-8?B?Y0x6cEo1QnlqRDdGUEM5ZG5Id2NVWlFYbVhRY0tpVUVtQTFlMkU4d1BUWmVr?=
 =?utf-8?B?L3paRG4xSWhwRWJEYjRKN3hRSk1wZVhHdmFuckZrWUFjb3JoOXpVRm43VW8y?=
 =?utf-8?B?dkxCRGUzWGNVYXlFMmgyUnpsSGcrcFlKekFtWHZLMVY0NExkMmFqOTR3RktK?=
 =?utf-8?B?V0lHSk5zWTFaci82SHBQWDQvOWl1V3FSR01PMTFkYlYxdFJoaVduWWFZSEtX?=
 =?utf-8?B?aWM0amRsV2VyNTlGUTJLNGVWTUs1YTJjbWpud2wzMEd0K1BIU2hSQ1ZyVEJD?=
 =?utf-8?B?T2NTek83QVFQSXlYVnNWcGVaL0dpYm9MUlN0WVZHbTZUMEJPWEFhNlh1clp5?=
 =?utf-8?B?Vmg3Q0N5M3Zody82SW5oS0IwUkxLdjRFa1UrN21Db1AwcDRMcnZmdEZSdGtm?=
 =?utf-8?B?QTY4MERzbGlMRE8vMWNHcUNQdHlRSmhXc1M4TWJZOEt6WTVYYmFMLzBGNE0w?=
 =?utf-8?B?ZlA5YjlFblNFSXlKdVIzN3hBREx3TDZHNXkrMGU4bU55VWRRbDE1ZnZUZSs4?=
 =?utf-8?B?QzBvYS9vdHM0Q2FwYklzbU9CM2poaXo5dWFuNXhUL1ZOaU5oZlBabDhrNDd0?=
 =?utf-8?B?WDB5UlhaQitmK3FQM0oyMU9LTFl6U1lRcjFNcTJKcnBKVm1tbTBmbVhnVllk?=
 =?utf-8?B?QWZreWsvQzNWRzRsZklpK0JYMExqV2RGL2NyQlI5dnZPTUdwUEhJd0VOTFBn?=
 =?utf-8?B?TlEvT1Nmd1A1TzFxYXEyNE94SWVmR1B4R1UwanBrb2V1RXpwSzBRYVNJUjho?=
 =?utf-8?B?cldNVC8rWUN5dms0WnlkZDdvU1JWSmcrYnpMdCt0c3FQeXNnNzREL2xxcXp6?=
 =?utf-8?B?YWNtU25TcHhRWk04NTZRSjMvU3RNTHJjbXZiRURySTZWSWIzOGpmUzFqbXBX?=
 =?utf-8?B?MnhsY3h2d1dEWHVnY2FsV1RrNDFyNDM1UTlFQVVKL08zS1ZJZFRxUDhpdmJq?=
 =?utf-8?B?T1UybXlRYmZuTUlldGRtMHMrblI1SWhLR1ZRUXFDZjgwM1FYbkViRWVIdUtq?=
 =?utf-8?B?aitXNEFRN0p1L2M0UzNnc1A2TTE0K0xlQWc2N01zdVkwN2JRcjE0T1NlV3Vh?=
 =?utf-8?B?dDUvdkYrNThxVGRiZ0gzVGNqZ0ZHbUMyM21henJUK3lVMktPU2Jqa0dFeHNC?=
 =?utf-8?B?cG1WTjJEa3I5QXFUNEx2c05DM2tGdGhOQ0QrZ2hHZDc1T2JlQjhLTFZ6ZXk2?=
 =?utf-8?B?cUdHb28vUkJQbDYrYUN6dGxENTlCNGlBUmpkYVFyanFGaUtsYXpWYkR1dUdt?=
 =?utf-8?B?VjhtZlF1VjNMR3Vmc0ZqSnVqbmw2VWtFdmdFM0ppNXVMc0xEMWVxZVFmUkFy?=
 =?utf-8?B?azc5Nit3VkkzWGswY3JkSjRHQy9CZExVOUFsYXhJQTQ4RVhaR0JOdDVPbGdr?=
 =?utf-8?B?WXJjT2tXUG9OUzdkeWovTXB2dkZoanVNK0xWZThxVTZZR1NrM28vcVREd2hn?=
 =?utf-8?B?SDRPblZkdHNXVVFRYnpnYVVHbkQwQzdLNDNoVFd4dzhiSDJOOUU5S1d2c3I3?=
 =?utf-8?B?bGRwQldrd0lWcGZwc1F4NFJJMWRQcmNOUWY1NWhkeVdXQ1pPNmg2ZUVma1pr?=
 =?utf-8?B?WGl5R0pPdVEwbElVWHBoVVBtWkFlOHgyY2RJQ0gra0gyOXVvMm1YK1RRMndO?=
 =?utf-8?B?VlE9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_1F09FA5B-E886-48D3-BC6A-5D939EFC0FAC";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f0a2be3-d4c8-4ad4-96fc-08daa862956b
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 12:50:59.2995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1ADqI7j3WNebxASkSRs7ihNog+N25r3OgQTNvTs2ZThsktQ+nNGSKGiY/qJsNQ6WdIwoECBAHH8501Vb/+1GqY7Ral9EcKLLE2Q5vk1XRI0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6245

--Apple-Mail=_1F09FA5B-E886-48D3-BC6A-5D939EFC0FAC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hello all,

The xenbits disk is getting somewhat full.  If everyone could take a =
minute or two to take a look in your own home directory and space on =
/people/, and delete anything you don=E2=80=99t need, that would be =
helpful.

`du -k -x | sort -n -r -k 1` is my normal rune for this sort of thing, =
if it helps; feel free to suggest your own if you think you have a =
better one. :-)

We=E2=80=99ll also be looking at archiving old home directories and =
other content, but it=E2=80=99s good for active users to do some =
=E2=80=9Cgarbage collection=E2=80=9D of their own occasionally as well.

Thanks!
 -George

--Apple-Mail=_1F09FA5B-E886-48D3-BC6A-5D939EFC0FAC
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNAILIACgkQshXHp8eE
G+3S4gf7BF7OrH7g36Q3fHw9qGoQMT6bF7QR7JkiD+dXVueMdxAc0gnczZtXryQD
wLGamP4P2bUZOtcaH/CdoalupGo1DRXv7Fm+OG5ZKOTsBZiRu/720yZ+R2yp8KDB
cW4SjFJBprzIku5wu+0YF/pp3f8fLQ72MnfGzGH1Wz0at+r4fWDwD9+mu5juMzOt
PqyJ1wWj8cHzKS94pE838qeJ/d+X7nDTdf+NIenyauNeQ25WgfexG3u5Kofxdu4X
VhtALEf76/RWfdkJp169OcOeeoaLHFWOeCCS7+YURhQpjQXi3qh237mlV5WevQAC
6LOk8mInFiqnGZvIHigi489L/rIvmA==
=oWEn
-----END PGP SIGNATURE-----

--Apple-Mail=_1F09FA5B-E886-48D3-BC6A-5D939EFC0FAC--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 13:09:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 13:09:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417986.662724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogn5y-0005q5-G0; Fri, 07 Oct 2022 13:08:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417986.662724; Fri, 07 Oct 2022 13:08:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogn5y-0005py-Bv; Fri, 07 Oct 2022 13:08:54 +0000
Received: by outflank-mailman (input) for mailman id 417986;
 Fri, 07 Oct 2022 13:08:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uvLM=2I=epam.com=prvs=22797713c5=mykyta_poturai@srs-se1.protection.inumbo.net>)
 id 1ogn5w-0005ps-Qu
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 13:08:53 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2eff056e-4641-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 15:08:50 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297C3WmA020386;
 Fri, 7 Oct 2022 13:08:44 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45t4br-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 13:08:44 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com (2603:10a6:803:33::29)
 by AS1PR03MB8150.eurprd03.prod.outlook.com (2603:10a6:20b:4c6::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct
 2022 13:08:40 +0000
Received: from VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273]) by VI1PR03MB3758.eurprd03.prod.outlook.com
 ([fe80::77e8:5cf6:210:7273%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 13:08:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2eff056e-4641-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aLT5BPypL+dlfWryd1U1LeeYkmTsFquCiLaKNJYy4Nav6QvYuj6UebYwvYfwprW+82Nlli9Hmk6hxKSp2TN1xxyBmXHZQr0sACKZzoa+EYiCTkFlOHSQqIT6XVMShg0svNZ58Vb0DQ3T6pMelBXnexkwrT/dW2LxmZHsHCdUHIR5seChjXI5cxrSyb60p6pqCK36YEUmEDMJxsH4AgClPj5qiIdvMnPN62AelMXdV66KeEDSiEY1FJ0qnlpjSytWTGOik2Xhpgdqk25it1pBGWEMCk1O7yhhI1Btwc5WI+CirXn0U9gl2v/uiBePGjOcNiao6ZXS4IpohBUE30Izhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4UbPdP4bVWAsM7T1sTAb1wibKL0UUmpwrjmjsEazapo=;
 b=hU99NTzVRMGbHSBvxN4SouiQvmzj1OVqqUFNe+nIQVcZZlnedjXGNScESGKc+OMS52LHxgtb7l9Iu4QdcQDU4PW1gqAjSc9R9FI63rdLg6LGgmv9eTRQDstFwIFIGG22WzLHdUqOVZC3LBTOn7RoISXc3riLOolKvQIqV/0CsbIkZ15smypP29wo1iMk3VOiC3BazvDpYCNB6kFWXmspRo/dAmHLcmiZntBTdfoFlqJwmRYognV3kIyuQf+Kj5WoVZSjJS3DwQ+30K0Kw4WKzWYq3NnQK1yIwo4kL/SXupz90gtb/V5em9Mm2h58RdRyo0T2ZjFV4PS5FTOxGFM+qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4UbPdP4bVWAsM7T1sTAb1wibKL0UUmpwrjmjsEazapo=;
 b=O7j4NjSpjjAx8Nqs+Z5ZVYvrDJdqXRybqxxYp0X0FA+IgsxTSW1Hp70ZdpjhXtLdzc1y81jkq5JJf2V60bPKxrDe91061RrSQOghYhB6FtcTL7qmBDJKXmdEhpoo3aKMVNHq4m/nIOudEmWbaoylr4HI1KG0+DaXEiF6ajZivq45mJzpJqmAPqm9Lx1EIO2OCcS/s/KGNdq3bgQytMj/C4PWQ0o4ZfRvY+75T3nllBQRx+Zf8OfcDdCD95XsZ/V4BTbpY2+19KDdpsFPRGpTdgLKKq/5342aaF53uOZ9jj0Uk/r62iRZWRc7vgYLiN/Mmq+MCRRK4QCGUqZh9ksrFw==
From: Mykyta Poturai <Mykyta_Poturai@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Mykyta Poturai <Mykyta_Poturai@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>,
        Wei Liu <wl@xen.org>, Dario Faggioli
	<dfaggioli@suse.com>
Subject: [PATCH 00/19] xen/arm64: Suspend to RAM support for Xen
Thread-Topic: [PATCH 00/19] xen/arm64: Suspend to RAM support for Xen
Thread-Index: AQHY2k3rsZJ6XuL2JUet06jBlxWLjg==
Date: Fri, 7 Oct 2022 13:08:40 +0000
Message-ID: <cover.1665128335.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3758:EE_|AS1PR03MB8150:EE_
x-ms-office365-filtering-correlation-id: 422d6da5-4efd-4e6b-748e-08daa8650dbe
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MNaAyEMXYm5HqSciyq+r8GIJY5mU/sTN/C8HaEB5A7REcKseq43c6qGgTRtx+jFoop4HEyMrhJac1ES2O91da4lpMVwmeqnMK3jZd7YW6tGr3kZYVcxq5WCzV0RqkObPThuep2h/+7y7yP/2ozzq5nGI39haeVKpBVhg3QdpIskrtUdsEBgdQg/Q7z1UPHIvx6rd+PzgG2SJ/4u2c4geMn1NFYOtVS9ISI49moFYc57VxbWvIGw+5WpUTjFxEwiQTPujyf8tCQQv7/hCWYicXMCzXk4U6APK2erW4bUk90D1sjgO2MlvYXnxu9wO/edKpbgkajndmgrcyJ9y0rEmrfe1/AsYCYEmkB1i0lIfbnRsnvAQRcu2ESENOleP/fDLq/cFcGYdMI6Xo1U05o36v3I27+8AaHmrzMhOXI+PxgQQDYHk+rjZstbCR3yysTLesdSCev+yP7VoweTG/KPkst2gCWufS+LjnIrUyvpHcYzwu32+9pjs66fbOAlaT3DktOZYxwn8vRKfq7cl2bUcFpxM+wXT4DKNmhoXtNQZCGZnWJqBR0+pN0A6gz1ECx1IvAwHb7pj8qI4mQ4z6aQTOL18VT6yWpwRsNHBWNWrbdl10/RFIN6Q6PbTV/djh8QK9c/lg4swFon6hm4aODsMOLd7FQkg1+e1q69nFYO1vN5q93h8Iz1m9wprPZHseomdCFievkS/jy0p2x4jUX+uQTRtGko6zb+gYbqUneToYwqies5tuLsGjFKQKtiaF4KHVJpWFYcwc5h87LyKCmBctcwp1iWRm53Vjl75EMte0Po=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3758.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(451199015)(6506007)(6486002)(38070700005)(6916009)(54906003)(966005)(316002)(478600001)(71200400001)(2906002)(122000001)(38100700002)(186003)(66476007)(66556008)(15650500001)(64756008)(41300700001)(7416002)(66946007)(36756003)(8676002)(76116006)(4326008)(66446008)(91956017)(55236004)(26005)(86362001)(5660300002)(2616005)(8936002)(6512007)(83380400001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?ZpG1wxYbI6o+cg14DuPiCWQaNot5Tm5zanh4bCWZaLQgtFFLoof5tSwd/t?=
 =?iso-8859-1?Q?+SHLN6d7v3+Nk0C2WBDNGVyDAkiibPhllnrMGTnLpe0PMaowRDGbpqWSxT?=
 =?iso-8859-1?Q?vrpELA83YNWqUDFmPFI8jZe/BktcIOav/98RC9mk51wizIaTnmoGWDNezo?=
 =?iso-8859-1?Q?cea4gWHWI3l40v9gzZSPBzFfJOWQADbNmExbrTxLP7bTNTl8lYfWuKK7ib?=
 =?iso-8859-1?Q?Dpuq2Ix4N5vLt+dIbrtiwKhSAvpBt9Kmb5nzu1Fw4xjFgSg6cYkUUy5KGg?=
 =?iso-8859-1?Q?6N73j3pwAaUE+hahPZUWCEAOk+Tu3MSf3g5scmgaPsfpLLPuqXZITUQxlE?=
 =?iso-8859-1?Q?fHSMdnoJaD/4yKM+uCLB0FqRrKEZeKFMIo7k5Nk8GSPbFzWF2KRXUihcZ2?=
 =?iso-8859-1?Q?8cm/QZ2QrNrGHs6O3Aai9kvWHRLDsy3HA5KDLZYB4iQb+2RYsG+x+pS0yf?=
 =?iso-8859-1?Q?E7OvrBSGBlwNo0vmqybXa8/G5BANlkQTGtIKJSlN5lmsHcUkwHaLnPfAKT?=
 =?iso-8859-1?Q?EnVw002mDXUCIy0bc3L4OuMdolaMu08/l+SCSeSuSb/s9rgNKR4kCCVuDB?=
 =?iso-8859-1?Q?Qz3SsSHWS7vuitTp8pKVC2cdVL3buwO69PkAerW0hK8bu7jqe2+9tSc2XF?=
 =?iso-8859-1?Q?A3JwZoEN2IY3KcIjptSQ5DAlYqaCgpWyUwvB7lAeW3TpzdlSfICnDcSom6?=
 =?iso-8859-1?Q?t8Q3jxenrLC1e5hoFG54raIA57c3//b1uEUMjkhXnAoQOeHIgOEI7hClad?=
 =?iso-8859-1?Q?qfDSGVUoja4z+T2t0co2YSAmJ1lfnPOjfWl51XdmdDtQyl6XhPgDSirsTI?=
 =?iso-8859-1?Q?VpAh57UN6U7vxhOHQLWFz9eRBhGRksOpAxmxcp5VHt7JKFRYSSLx1HRcAg?=
 =?iso-8859-1?Q?PAWYcmbtZbsSP5PHlfrVlDK3a3wJx2Ra9i6jEbbKQpGb5ibFRXxvr1dIlN?=
 =?iso-8859-1?Q?7CTsu3BauMK9zKLp/VRYDTmNwgJNKVnig+zfn0zN/PaXDSs3PAaL+yyoa3?=
 =?iso-8859-1?Q?NYG6HW+mAQfxHykehr6/w83GjeFv7U7vdCtCs0XBzDGELpkPy+sFjpsYKN?=
 =?iso-8859-1?Q?Gio5JqAnDXnJJJRPkssJmNgGAWRmInlpBgJUl0yNBonSSmk4ByshypT2u3?=
 =?iso-8859-1?Q?L5/peS46OI93kwYEYwyEvwvEljkyQ9IpGvLLnMs1dYt4Iw+vnRRM3JjqCK?=
 =?iso-8859-1?Q?EtXMg1CrgGdEqhcpQ7S5Ant3L8FhNTdWwB8I3x90MCM/QHSfUq03Ei3K/N?=
 =?iso-8859-1?Q?//xJQCfI5heuD0lCVqoEUn6rZ/4nNT4swQmIe5f8eqv8QZvlX3DXobTkPa?=
 =?iso-8859-1?Q?DCC4GNwAuXbzFUG6lBO37xe9Qc2Gv5BEV1emVLDdHI0K8y7qDsWxJQ7QS1?=
 =?iso-8859-1?Q?olQDxh84qklIqdrj84Pi3XJA65IFvHWEKNxDdjzb48VfRbQia97HWa7WtW?=
 =?iso-8859-1?Q?yGaWCnrOD9/gnfI6LBgUIgkMK46a5J584H3zZS3UTWl0nY2TpQ890s6nzb?=
 =?iso-8859-1?Q?yqCu73372ah5PFYojnNejzKEhzXlUNtUsaxP1wgplK7EsVItopvvJ+ot/W?=
 =?iso-8859-1?Q?rcsBeJP7z8eyAM7Ka1t8ydji6loda/5OfDPEVuvZTxsl1JYfhgcnrYVtZW?=
 =?iso-8859-1?Q?OGPm+bCOxWHIizA6HY+q4p8giNPSOFbS6WdSyHb8/wtGCY09F4Y09E8A?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3758.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 422d6da5-4efd-4e6b-748e-08daa8650dbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 13:08:40.1470
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ynQqJEd9UUAis4QfPGVF6AtT+oD5Slskrzg0N0xc+yF0haYQA48j/pnJAppZyC6CNcBvTWVXyN6b2jmuUY297w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR03MB8150
X-Proofpoint-GUID: jBncKgJDaDydLMu5ka6Gw1AUXIsB3IX4
X-Proofpoint-ORIG-GUID: jBncKgJDaDydLMu5ka6Gw1AUXIsB3IX4
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070079

This is a series from Mirela Simonovic. Ported to 4.16 and with
added changes suggested here=20
https://lore.kernel.org/all/CAKPH-NjmaZENb8gT=3D+FobrAycRF01_--6GuRA2ck9Di5=
wiudhA@mail.gmail.com

This series contains support for suspend to RAM (in the following text just
'suspend') for Xen on arm64. The implementation is aligned with the design
specification that has been proposed on xen-devel list:
https://lists.xenproject.org/archives/html/xen-devel/2017-12/msg01574.html

At a high-level the series contains:
1) Support for suspending guests via virtual PSCI SYSTEM_SUSPEND call
2) Support for resuming a guest on an interrupt targeted to that guest
3) Support for suspending Xen after dom0 finalizes the suspend
4) Support for resuming Xen on an interrupt that is targeted to a guest


---------------------------------------------------------------------------=
-----
In more details:

*** About suspending/resuming guests

The patches included in this series allow PSCI compliant guests that have
support for suspend to RAM (e.g. echo mem > /sys/power/state in Linux) to
suspend and resume on top of Xen without any EL1 code changes.

During their suspend procedure guests will hot-unplug their secondary CPUs,
triggering Xen's virtual CPU_OFF PSCI implementation, and then finalize the
suspend from their boot CPU, triggering Xen's virtual SYSTEM_SUSPEND PSCI.
Guests will save/restore their own EL1 context on suspend/resume.

A guest is expected to leave enabled interrupts that are considered to be i=
ts
wake-up sources. Those interrupts will be able to wake up the guest. This h=
olds
regardless of the state of the underlying software layers, i.e. whether Xen=
 gets
suspended or not doesn't affect the ability of the guest to wake up.

First argument of SYSTEM_SUSPEND PSCI call is a resume entry point, from wh=
ich
the guest assumes to start on resume. On resume, guests assume to be runnin=
g in
an environment whose state matches the CPU state after reset, e.g. with res=
et
register values, MMU disabled, etc. To ensure this, Xen has to 'reset' the
VCPU context and save the resume entry point into program counter before th=
e
guest's VCPU gets scheduled in on resume. This is done when the guest resum=
es.
Xen also needs to take care that the guest's view of GIC and timer gets sav=
ed.
Also, while a guest is suspended its watchdogs are paused, in order to avoi=
d
watchdog triggered shutdown of a guest that has been asleep for a period of=
 time
that is longer than the watchdog period.

After this point, from Xen's point of view a suspended guest has one VCPU
blocked, waiting for an interrupt. When such an interrupt comes, Xen will
unblock the VCPU of the suspended domain, which results in the guest
resuming.

*** About suspending/resuming Xen

Xen starts its own suspend procedure once dom0 is suspended. Dom0 is
considered to be the decision maker for EL1 and EL2.
On suspend, Xen will first freeze all domains. Then, Xen disables physical
secondary CPUs, which leads to physical CPU_OFF to be called by each second=
ary
CPU. After that Xen finalizes the suspend from the boot CPU.

This consists of suspending the timer, i.e. suppressing its interrupts (we =
don't
want to be woken up by a timer, there is no VCPU ready to be scheduled). Th=
en
the state of GIC is saved, console is suspended, and CPU context is saved. =
The
saved context tells where Xen needs to continue execution on resume.
Since Xen will resume with MMU disabled, the first thing to do in resume is=
 to
resume memory management in order to be able to access the context that nee=
ds to
be restored (we know virtual address of the context data). Finally Xen call=
s
SYSTEM_SUSPEND PSCI to the EL3.

When resuming, all the steps done in suspend need to be reverted. This is
completed by unblocking dom0's VCPU, because we always want the dom0 to
resume,
regardless of the target domain whose interrupt woke up Xen.

*** Handling of unprivileged guests during Xen suspend/resume

Any domU that is not suspended when dom0 suspends will be frozen, domUs tha=
t are
already suspended remain suspended. On resume the suspended domUs still rem=
ain
suspended (unless their wake interrupt caused Xen to wake) while the
others will be thawed.

For more details please refer to patches or the design specification:
https://lists.xenproject.org/archives/html/xen-devel/2017-12/msg01574.html

Juergen Gross (1):
  xen: don't free percpu areas during suspend

Mirela Simonovic (15):
  xen/arm: Implement PSCI system suspend
  xen/arm: While a domain is suspended put its watchdogs on pause
  xen/arm: Trigger Xen suspend when Dom0 completes suspend
  xen/x86: Move freeze/thaw_domains into common files
  xen/arm: Freeze domains on suspend and thaw them on resume
  xen/arm: Disable/enable non-boot physical CPUs on suspend/resume
  xen/arm: Add rcu_barrier() before enabling non-boot CPUs on resume
  xen/arm: Implement GIC suspend/resume functions (gicv2 only)
  xen/arm: Suspend/resume GIC on system suspend/resume
  xen/arm: Suspend/resume timer interrupt generation
  xen/arm: Implement PSCI SYSTEM_SUSPEND call (physical interface)
  xen/arm: Resume memory management on Xen resume
  xen/arm: Save/restore context on suspend/resume
  xen/arm: Resume Dom0 after Xen resumes
  xen/arm: Suspend/resume console on Xen suspend/resume

Mykyta Poturai (2):
  watchdog: Introduce a separate struct for watchdog timers
  timers: Don't migrate timers during suspend

Oleksandr Andrushchenko (1):
  Fix misleading indentation gcc warning

 xen/arch/arm/Makefile            |   1 +
 xen/arch/arm/arm64/entry.S       |   2 +
 xen/arch/arm/arm64/head.S        | 121 +++++++++++++
 xen/arch/arm/domain.c            |   4 +
 xen/arch/arm/gic-v2.c            | 138 ++++++++++++++-
 xen/arch/arm/gic.c               |  25 +++
 xen/arch/arm/mm.c                |   1 +
 xen/arch/arm/percpu.c            |   7 +-
 xen/arch/arm/psci.c              |  16 ++
 xen/arch/arm/suspend.c           | 292 +++++++++++++++++++++++++++++++
 xen/arch/arm/time.c              |  22 +++
 xen/arch/arm/vpsci.c             |  28 +++
 xen/common/domain.c              |  29 +++
 xen/common/keyhandler.c          |   2 +-
 xen/common/sched/core.c          |  55 +++++-
 xen/common/timer.c               |   3 +-
 xen/include/asm-arm/domain.h     |   3 +
 xen/include/asm-arm/gic.h        |   8 +
 xen/include/asm-arm/perfc_defn.h |   1 +
 xen/include/asm-arm/processor.h  |  22 +++
 xen/include/asm-arm/psci.h       |   3 +
 xen/include/asm-arm/suspend.h    |  40 +++++
 xen/include/asm-arm/time.h       |   3 +
 xen/include/xen/sched.h          |  16 +-
 xen/include/xen/watchdog.h       |   6 +
 25 files changed, 837 insertions(+), 11 deletions(-)
 create mode 100644 xen/arch/arm/suspend.c
 create mode 100644 xen/include/asm-arm/suspend.h

--=20
2.37.1


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 13:20:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 13:20:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417992.662734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognHH-0008CW-G4; Fri, 07 Oct 2022 13:20:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417992.662734; Fri, 07 Oct 2022 13:20:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognHH-0008CP-DN; Fri, 07 Oct 2022 13:20:35 +0000
Received: by outflank-mailman (input) for mailman id 417992;
 Fri, 07 Oct 2022 13:20:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ognHF-0008CJ-Nv
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 13:20:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ognHB-0002M5-N3; Fri, 07 Oct 2022 13:20:29 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.20.83]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ognHB-0003wQ-G6; Fri, 07 Oct 2022 13:20:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Y6Wy04WMTYYKn5t5tiiQfG7z4acdned1ldL9zc9bi04=; b=SBdmihUr8VyPtW/E7Qs/Yqa0CA
	fII7QTA+jNrJUHxsySFys1WCyr41B6n1lLZ8Bk2P4RSIrYA9tqJ2cIhBDpCyA4Z9NqkeYvogdwkDb
	Uu0c5TMVWMRcZCevmikbC53dm/o/DaM4dk9LbAI23cofzrLiztg+jfmcPz7yOHQ+Gkjc=;
Message-ID: <e5314094-862e-9022-3707-7e308e9f2e67@xen.org>
Date: Fri, 7 Oct 2022 14:20:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH 1/3] process/release-technician-checklist: Explain how the
 banner in README is generated
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-2-julien@xen.org>
 <60eda03c-9e40-2a99-dfe5-7ba1407961ad@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <60eda03c-9e40-2a99-dfe5-7ba1407961ad@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 07/10/2022 12:02, Jan Beulich wrote:
> On 07.10.2022 11:13, Julien Grall wrote:
>> --- a/docs/process/release-technician-checklist.txt
>> +++ b/docs/process/release-technician-checklist.txt
>> @@ -49,6 +49,7 @@ t=RELEASE-$r
>>   * consider bumping sonames of shlibs
>>   
>>   * change xen-unstable README (should say "Xen 4.5" in releases and on stable branches, "Xen 4.5-unstable" on unstable)
> 
> This line may also want updating, to include the 4.5-rc case as well.

Good point. I will respin this patch.

Cheers,

> 
> Jan
> 
>> +*   The banner is generated using figlet
>>   * change xen-unstable Config.mk
>>   #   QEMU_UPSTREAM_REVISION,
>>   #   QEMU_TRADITIONAL_REVISION
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 13:26:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 13:26:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.417998.662745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognMu-0000V6-4c; Fri, 07 Oct 2022 13:26:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 417998.662745; Fri, 07 Oct 2022 13:26:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognMu-0000Uz-1q; Fri, 07 Oct 2022 13:26:24 +0000
Received: by outflank-mailman (input) for mailman id 417998;
 Fri, 07 Oct 2022 13:26:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ognMs-0000Ut-E7
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 13:26:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ognMn-0002Rt-2k; Fri, 07 Oct 2022 13:26:17 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.20.83]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ognMm-0004XD-SD; Fri, 07 Oct 2022 13:26:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=IugBXtSL5iOmReNBqMdYlDqxxMplhQSbtLeEQmZUcRs=; b=hJWQdwfsAhwmzF7R61MDDHa7ol
	WM9Nale6iZi+ihf1IvkbcIjO/5l/TNNuR47iZKwg6CQucoDmlQi+vsrXZ/HxSt8sVIlw6qQjpMRn3
	ZyMk3Ly1dxAVFQXiI8gB25+uAl3Q5w4uOgjGFE0ZwP9VncQKYJkJ/TKOEE1+JOPL0Fhc=;
Message-ID: <53a2e52f-05f9-da86-218a-3046d1b1ca71@xen.org>
Date: Fri, 7 Oct 2022 14:26:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH 3/3] Update Xen version to 4.17-rc
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221007091341.58542-1-julien@xen.org>
 <20221007091341.58542-4-julien@xen.org>
 <304f4bbf-3598-2f42-5cee-83e58c1909cc@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <304f4bbf-3598-2f42-5cee-83e58c1909cc@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 07/10/2022 12:06, Jan Beulich wrote:
> On 07.10.2022 11:13, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   README       | 16 ++++++++--------
>>   SUPPORT.md   |  2 +-
>>   xen/Makefile |  2 +-
>>   3 files changed, 10 insertions(+), 10 deletions(-)
> 
> I assume CHANGELOG.md is then going to be updated only once for the actual
> release? (Not that I think that the -rc is relevant to have there, but the
> version could as well be changed to 4.17.0 already now.)

In the past, this was updated once we are ready to release 4.17. I would 
prefer if we follow the same approach as it will be less error-prone and 
work.

I would otherwise have to temporarily remove the section "unstable" (to 
avoid someone mistakenly updating the changelog) and then re-introduce it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 13:27:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 13:27:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418004.662756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognOO-00014Q-Ea; Fri, 07 Oct 2022 13:27:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418004.662756; Fri, 07 Oct 2022 13:27:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognOO-00014J-Bu; Fri, 07 Oct 2022 13:27:56 +0000
Received: by outflank-mailman (input) for mailman id 418004;
 Fri, 07 Oct 2022 13:27:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sO4L=2I=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ognON-00014D-Kn
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 13:27:55 +0000
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com
 [2a00:1450:4864:20::52a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d79eaec4-4643-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 15:27:51 +0200 (CEST)
Received: by mail-ed1-x52a.google.com with SMTP id a13so7084047edj.0
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 06:27:54 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 cn22-20020a0564020cb600b00459012e5145sm1438183edb.70.2022.10.07.06.27.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 07 Oct 2022 06:27:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d79eaec4-4643-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=PORH37wl02w5zim2PpJcX5b14ycsNmFAFsoV/wDCQVg=;
        b=U8zIpLC9vkt1BxrKzxjy6Cz9Wfr50dEgERMUW7D3MmIk3M/GAnxJb0zX6CzjP1tWVm
         sh2qvWo/lWg/5UYdKf3IW9vu+3q5HyCpHAJzHMF8Y0so/+inIAUn7rHPiwOY2tNxDGMc
         mPARgY289vvOo0g1re36cTnA5sXHjurm0HQcJlEystO7CBW4Lxfsma8/vmjCJXAEOznS
         2PBgX3kVoYBFo3rSe+mtq97swC9VN3P/7LeLbEWtjI7/PiuDN3mH5G/rknAXEZ4TgNbv
         mn9+Q9n74kZdOKaBq0wbOoY8trlau9Wr0kwO0811xNWR9RCaIbQkALXA88J1xoukgH5O
         yb3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=PORH37wl02w5zim2PpJcX5b14ycsNmFAFsoV/wDCQVg=;
        b=bmvwRSVfzVnIE+WPNv3WydoYJjIlA6OQS/sSBtXH9mYVRuA70vRtWgCUCfMjUO0yVP
         ZhHpZtGMtpyoy27otob4hOGMMVTVEEgbuA6XS32233yuZ2uYg2K9bwUtne+9AE8KgcN6
         T58ALvLaKW2vK2uP3WCWkAM2gyrG8lWlXmQv8K1ApJMMIHAiYA18S/WsTIO3mFjVwUG2
         1OAf2pBuFGCaOLyguiAOpS/diaNlT4D4tfYaVDtvv8koKTolAdTnH+T6IqiTQdATKCQe
         VFkIRVed4jEIjyxZvIsB7uPTWLql8+QcxgDuaPDYWmKpQkzZdY6DBEW8HXB2qmsv+6r/
         WvSg==
X-Gm-Message-State: ACrzQf3bqJBZTTcPKqihrzvpUkStyVHbulbLJC0BbVg/fn8o2mqjxRNs
	KeANbzyYbPYeY0yjKEogH8UUcYC5ebY=
X-Google-Smtp-Source: AMsMyM6dRcRpow+v9ntj3SdSgn+856xu57eMalm4LP36SOxY1H2aCoZRDpopoA4CB96QCMhTyUgivg==
X-Received: by 2002:a05:6402:2489:b0:454:11de:7698 with SMTP id q9-20020a056402248900b0045411de7698mr4712240eda.214.1665149273742;
        Fri, 07 Oct 2022 06:27:53 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE properly
Date: Fri,  7 Oct 2022 16:27:36 +0300
Message-Id: <20221007132736.2275574-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Passed to xen_grant_dma_map_page() offset in the page
can be > PAGE_SIZE even if the guest uses the same page granularity
as Xen (4KB).

Before current patch, if such case happened we ended up providing
grants for the whole region in xen_grant_dma_map_page() which
was really unnecessary. The more, we ended up not releasing all
grants which represented that region in xen_grant_dma_unmap_page().

Current patch updates the code to be able to deal with such cases.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Cc: Juergen Gross <jgross@suse.com>
Cc: Xenia Ragiadakou <burzalodowa@gmail.com>

Depens on:
https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/

Should go in only after that series.
---
 drivers/xen/grant-dma-ops.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index c66f56d24013..1385f0e686fe 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -168,7 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 					 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(offset + size);
+	unsigned long dma_offset = offset_in_page(offset),
+			gfn_offset = PFN_DOWN(offset);
+	unsigned int i, n_pages = PFN_UP(dma_offset + size);
 	grant_ref_t grant;
 	dma_addr_t dma_handle;
 
@@ -187,10 +189,10 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 
 	for (i = 0; i < n_pages; i++) {
 		gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
-				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
+				xen_page_to_gfn(page) + i + gfn_offset, dir == DMA_TO_DEVICE);
 	}
 
-	dma_handle = grant_to_dma(grant) + offset;
+	dma_handle = grant_to_dma(grant) + dma_offset;
 
 	return dma_handle;
 }
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 13:44:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 13:44:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418014.662776 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogndt-0003a3-VJ; Fri, 07 Oct 2022 13:43:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418014.662776; Fri, 07 Oct 2022 13:43:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogndt-0003Zw-RD; Fri, 07 Oct 2022 13:43:57 +0000
Received: by outflank-mailman (input) for mailman id 418014;
 Fri, 07 Oct 2022 13:43:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7mFU=2I=epam.com=prvs=2279168535=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ognds-0003Zp-DX
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 13:43:56 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14ecc8ac-4646-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 15:43:54 +0200 (CEST)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297C3Ctd026667;
 Fri, 7 Oct 2022 13:43:49 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k25xujtg0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 13:43:49 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by PAXPR03MB7665.eurprd03.prod.outlook.com (2603:10a6:102:200::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct
 2022 13:43:45 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 13:43:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14ecc8ac-4646-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dHgYzhxgM9JFR738bbFdoLHdspKOqdBZtbUGkRQ44V08mNVA62c9tT7uaVdLVkjO9cfAOss9xnnKIe2U2f93VzcR2ZvrFjmHuqfvq2wGLVb01EFm0X9pdsFGjWFSseCHHK0nnvOivdASzxJkjIjrODpgXQ2AKn4ACX2assPa4svZq6SqiTBY/XnIwtdobmkKCmEEbvY76Y6XBQG1B0t6BbwrhQrI0KpJ5URP6Lm/iWXw0RCQmwH3tiZtOlsxw6FRX1Dt3KEveD/3+PhQtCa7RMkkjs8J4j+0LM3IseHTBCqLfJcc0T9V26Q6y8Y0cd68jAGaqeOHClrEeBIbXmg0VQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ageGqafa2WfV5KWzPOBPd1p7qRBtGi7E0NIei/wk7e4=;
 b=eMuyOYcB93e2pQg+f7QzG/qRCUeegVT49W+8QIG339+x2uzZqeq9NVr6GiaMWeoFQPYNknvRJncA7rhBODa+6CiH/r2mVHHQ+XSKpSYm71kXRtBSnGmnYAtjilixHKJK8b07HKILVHkFmA4LAYiRTJ3FOa27egWQ+7VgW4/lT+FVxgdldUTpNTygK0L3v/yA0b1VuP0p4bNA1TvIJvsq7mc8OzT7taEmrM9PKUpDmNzsziw+MU2fSioCInIwp9Byf48SYmcmRlKolF7MV9+dGDfJTAmcjqFUI/xKFIePwQJP+TAnJi5Cc+kwprmrm004VY6MrWBWgcgeDlbuEWvSPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ageGqafa2WfV5KWzPOBPd1p7qRBtGi7E0NIei/wk7e4=;
 b=CKbeiYnQenb8UVjerRHczp8/GNLx+YzCd0To3k03m3obP27Vmi0CQmZ60fRVD72zcubpYAPfrrFNaUqnX5gYwTxnAx0m2oVDaNmevFsiNe8VcJk2xsUTzgQGya5Xk8LlgQHbuoKAyFQjs2T/DuVNV69W5fp1Qedajk+n1VZAIRl4AY48ICegYesHNYFfvY9fG4hgP1sAnwnKn5lKeERulVoAztJLqnl/FxeIHnVy7x6srt3C2RSN4bNpStBOL513TmCNIllGRSDdG9FUhmWo6tutciLyQvPb9nTvzsAnGoktwmko2vCCaudgrahXKmfLZQaLHipl8pzLDuhNcSk/Zw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Topic: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Index: AQHY2Xx9ME9woenUJk6IqJF2QACToq4Bp86AgAA2I4CAAKgkgIAAbJWA
Date: Fri, 7 Oct 2022 13:43:45 +0000
Message-ID: <816da52a-f646-c114-fa6d-9320152a0e79@epam.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
 <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
In-Reply-To: <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|PAXPR03MB7665:EE_
x-ms-office365-filtering-correlation-id: b187242e-f9a0-480d-9051-08daa869f4c0
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 jlwQKT5UaCRqtrz86xToFAsjtG+GWxXGEdfLzurWJtXHTeItKDHdWWh35ofqElXpSJDbu//61R+BVO/VlXj6ovGz9O/SP0ajeKh2OXgTbXLSwbuTErB3AfObNYaryK00MF+hbaBx8LC8KVT8q5JaeudAiPMio2qjk8ilK1V3e12tTLr/xs8OiNGqcZCg+zl/glWjH12LyEjl7A/zb7ZiVdYRhGv9R2ERDOJhUvjWGqTFpEiCxaOAqBBO7P6NhLs0tVW1Nb2i8k9HR+u/zd0BYuIpftJXPwL4Z9Srg4GhH/oHhGaOyM0WZPmh0vWN/rNhGsq4CHJyF1PNIgeWhe2uQraz0ISYCSvojAj4gItrG+P2Ko8mr7QKOECkGQjp1qqmfDyztKAxixJG/Zrowp7kIdZ3rRFvKMUx4qaCOyocBu+uAWN9OL3IF025YEpsx3Dl1cOp0ACRpzsGZ1WO/kakHEyF7TKs5LYuSb9VlwuKTZ3dqldnl1O62MQvjNFV8hG9Z9B+IQd6+D6Yvj5lVYH0jEL/Msoy9qZ0dBZ4kMNxrymW9yyffVu3+EqKZqbjoAEUKHZTlqNRHqa5tk8FWbkN58CDkVDALJSalinQVYOAUdHS4E2bWtMvLtZdDx99x3jzxgIAS8r5JBHxeuz8mbavyagBL/pPbJX2Ou9aYJCI/LHRMb7qPCMUW6vLpjhWZCeZYi94s+T3XJHoXvuq6ZMY4yfBNh5i8HaczO+X/w4MJngLgySNrg62xE6CHHmgNFhpUbfHy5Mnjq0x/YwSVCjsZc74ITpg23uxl+noZk5fTKMefMOPkxxr7ITweeCTcF4aPnf5YSWl7UYnKSibNyXIOA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199015)(5660300002)(66476007)(8936002)(36756003)(2906002)(66556008)(66946007)(66446008)(4326008)(8676002)(41300700001)(122000001)(76116006)(64756008)(31696002)(38070700005)(6512007)(38100700002)(6506007)(26005)(86362001)(53546011)(110136005)(186003)(55236004)(2616005)(6486002)(966005)(71200400001)(478600001)(54906003)(91956017)(316002)(83380400001)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?eUhmcUZnMXY3a1VIM0V3bHZQbVhCV3BZTm4yRW1Cb3NjV2VtSEZnMVlJVlN4?=
 =?utf-8?B?KzlKQWVWOUNrcjkzRW5HUXFmYUtWSHNLelhUdDNTOVpaZ1EwOG1VMFY2b0RO?=
 =?utf-8?B?MWUxY1I3ZVYvVFM5MjdlRFllb3Z2ejQ3QlFGd0VxSmQ2MklISzJpWXViQXRr?=
 =?utf-8?B?MThxYzJTaTBnU1JxdnBDZTdsd2lTL2JsbFVsbGwwMlM5ZmVzRTRsSlcwMVZB?=
 =?utf-8?B?UnN6MlJLZHhPZ1REOGswY0g2U2ZuclpYeURBTCtEVW9tUEZjbi9QOGlGM3Z3?=
 =?utf-8?B?Z1F2a0NHaXVkTWdaODc3Rk9jS3p5ZTNxYmhtUjQzeG9rN3d0QTBLZVVnYVB4?=
 =?utf-8?B?eGQxQUdxRldaVnZWL29VOVdvUmg1Q1hyeFNQRFQ3MmcySUdwbDQyb2QxQUdR?=
 =?utf-8?B?K0NJR0JkZnIrdHlROTlEN1Z1SGtXaUtRckVKQmlPUjcvQVRjUGdKaG1MOWp2?=
 =?utf-8?B?UThPQWZuekl6YUx6RWE3RXZuNHd3aEsyYUlsSFQ1NzdEazRPK01BZnh3NHpX?=
 =?utf-8?B?eVZ3aTBsL1B3dXh2RVVXcll1dzhHazN1eUdDVmFLRW82U0Mva01OQWYyUGpU?=
 =?utf-8?B?blpMbXNxTkU1RFBCUUpMZGlDZkZPRXk2QlZCMGFyVVd1VGhiOHA4Y3NUUStJ?=
 =?utf-8?B?SkRJN1pkVU1xVGx1REZjb09GdUx0OEZSaTVhcXlvODljZlE4R3JuaDN4REZO?=
 =?utf-8?B?bGxvazF4SDl6VXpWTldFanBzWDRlYU5QZk04WVc2dVV6RTRvWGhnUmhZaERv?=
 =?utf-8?B?KzF6dWpJMGo2TElKNytPUFN3SmU1RndadWhRSjdvNGllMXhqKzFoMmEwb3pK?=
 =?utf-8?B?bTdEL0lMWUpFcTBjTXJFQjdIN1dUbHlQL2xpMFJ0VHJJd05mRG9UVXdpUC9G?=
 =?utf-8?B?aEFFVnM5WDlRZnJ1K1B3SlUxbXN1Ti92aU9QdHlGak4rN1pqTGNVRkxSaS8v?=
 =?utf-8?B?R2l4WWRqWGNLd1ZOcVlheGJHR2V0TnJzb1pNcE5LdXVpVk1qai9mTmNQblhV?=
 =?utf-8?B?NXBLNElqckNLZStBZEY1YTRML3V3V05qRURzN3NDeGUvUmp4S0NWNyt0cnR5?=
 =?utf-8?B?Q0tzYU4ybXdIOUsvS2NrZ3BHRmJQVy82aEJaTzVPNEorYjlFRS8wSmRnYTBq?=
 =?utf-8?B?NjQ3ZllrM0tjeFQ3dHd5aW9OUXBOWU5Vais2U2ZKdDZyQ1YwRi94VFRxSzN3?=
 =?utf-8?B?clpNOHY1WUgrUnJiUE8vcGFTblBtc2UxNmJXcjRTZzkweUpleEF5Sk1pZU9Q?=
 =?utf-8?B?UFFpd3ozMGdwakRwUkVDN0tCYTNsaWtQQmxxSi9PSDJLQTIrMVpEeStFTUsw?=
 =?utf-8?B?clN2Z094a2JHQlFmODNzRXp0R3JSRUFZRm1ucDc2OFlEaUh0VERnYlZXV0Rv?=
 =?utf-8?B?Snh5RTNtTmN6bmRlMDR5OHAvS0FXQzB2Zmc2clpZUFVEWi9uTTRJaU52a2VP?=
 =?utf-8?B?WmMzNFRvUS9BVU1lbU1nZmRFYW1tUmZOQXM3YytYOUoxOWwvODQ4ajN6bHhF?=
 =?utf-8?B?bXRFUmpsUW5rc1RTZitWODdBaWZZQVUzbnQ2WjZTUG41TmVqVmZ0NEFsUUtH?=
 =?utf-8?B?NCtOZDBROSs0bkZsdUtjeXVzb2VnWVg5NnB6VUgyWlkvNDFZTWdOdWgzTXhn?=
 =?utf-8?B?elBiUTQzMDVUdVp4RlFzenlaZG5paTBxamlpQzhlU0pKS0hzQjhNZWJHeWti?=
 =?utf-8?B?SlA2MHNlZnQzaytEUEhNVFZqcUlZUEhseHBoWEprS3YrQmlDaGRrQTkybTRX?=
 =?utf-8?B?aFFxNDBMMEcyUzY1dS94c2s4U2VDOVNyVVF1OXJKNkhtcnExUWx3ZTNzSU1R?=
 =?utf-8?B?Yko1NThmaHJ3WG13aEpjbmJDMFM1Q1YrVDdWaWNkMnFncG55WTJtR3RvTXo1?=
 =?utf-8?B?Z09sZDBxS1ltWHJoVnl1ak5pZVV0RjM3MzMxMHdmNlIwTFM1akRhS3U4N3V6?=
 =?utf-8?B?c0N1b2VHbkZIMHNMZEFwaGh2eWNxNDh4RUpodVNESGhLVG00Z3ZzVWtxT1dt?=
 =?utf-8?B?QTVvaktBSFlCVlZaOThFY3gwa29LdU4rYko2Uk85d2hscUxqaHZSODdxNmxj?=
 =?utf-8?B?bnA3VEZ1b0NSNzZiV3NwVmJDOXFjZ2JOWmlnTHh4bm5XQVF3OGNlOFExVC9F?=
 =?utf-8?B?LzZCYzhHdjBBd3lhSUovZzJqb0ptZFR3UDNERnRpUEJxd0E5LzI4MTdBM3c2?=
 =?utf-8?Q?O5DGyhy//ZdVfdd2JRsGojI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6DDCF0E2747369479AA8C31F2EBA0B63@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b187242e-f9a0-480d-9051-08daa869f4c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 13:43:45.7170
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4CcHGLOMN1PCUmsK1Qy/pqDHcrQ+pxNtZiZNFWvxvnAjGgMgR3MDfrmfOyTxuCDTjW0hMiQ8B8WYVgrQ4lPhoBzXSFQ2khMy6UGbgxC3zuI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7665
X-Proofpoint-GUID: -GWXMvlHkov0-YrL2Wli5m05ssVUlkpa
X-Proofpoint-ORIG-GUID: -GWXMvlHkov0-YrL2Wli5m05ssVUlkpa
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 impostorscore=0
 mlxlogscore=999 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070083

DQpPbiAwNy4xMC4yMiAxMDoxNSwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCj4NCj4gT24gMTAv
Ny8yMiAwMDoxMywgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+DQo+IEhpIE9sZWtzYW5k
cg0KDQoNCkhlbGxvIFhlbmlhDQoNCg0KPg0KPj4NCj4+IE9uIDA2LjEwLjIyIDIwOjU5LCBYZW5p
YSBSYWdpYWRha291IHdyb3RlOg0KPj4NCj4+IEhlbGxvIFhlbmlhDQo+Pg0KPj4+DQo+Pj4gT24g
MTAvNi8yMiAxNTowOSwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4+IEZyb206IE9s
ZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4N
Cj4+Pj4gQWx0aG91Z2ggWEVOX1BBR0VfU0laRSBpcyBlcXVhbCB0byBQQUdFX1NJWkUgKDRLQikg
Zm9yIG5vdywgaXQgd291bGQNCj4+Pj4gYmUgbW9yZSBjb3JyZWN0IHRvIHVzZSBYZW4gc3BlY2lm
aWMgI2RlZmluZS1zIGFzIFhFTl9QQUdFX1NJWkUgY2FuDQo+Pj4+IGJlIGNoYW5nZWQgYXQgc29t
ZSBwb2ludCBpbiB0aGUgZnV0dXJlLg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+IC0tLQ0K
Pj4+PiBDYzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+PiBDYzogWGVuaWEg
UmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29tPg0KPj4+Pg0KPj4+PiBBcyBpdCB3YXMg
cHJvcG9zZWQgYXQ6DQo+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2xv
cmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDUxNzQ4MjMuMTgwMDc2MS0xLW9sZWtzdHlz
aEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSF6SHQteFpfN3RaY19FTTZ6dmEyMUVfWWd3
SWlFZWltRldmc0pJcFB3QXUtVEJjbnpRaFhIcWxLem1YbXdJY0k2dUl4X2FySE5aaWFaZUh0XzQy
OF84cC1EeU1wZCQgDQo+Pj4+DQo+Pj4+IFtsb3JlWy5da2VybmVsWy5db3JnXQ0KPj4+Pg0KPj4+
PiBTaG91bGQgZ28gaW4gb25seSBhZnRlciB0aGF0IHNlcmllcy4NCj4+Pj4gLS0tDQo+Pj4+IMKg
wqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgMjAgKysrKysrKysrKy0tLS0tLS0tLS0N
Cj4+Pj4gwqDCoCAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25z
KC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMg
Yi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4gaW5kZXggYzY2ZjU2ZDI0MDEzLi41
MzkyZmRjMjVkY2EgMTAwNjQ0DQo+Pj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMu
Yw0KPj4+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4gQEAgLTMxLDEy
ICszMSwxMiBAQCBzdGF0aWMgREVGSU5FX1hBUlJBWV9GTEFHUyh4ZW5fZ3JhbnRfZG1hX2Rldmlj
ZXMsDQo+Pj4+IFhBX0ZMQUdTX0xPQ0tfSVJRKTsNCj4+Pj4gwqDCoCDCoCBzdGF0aWMgaW5saW5l
IGRtYV9hZGRyX3QgZ3JhbnRfdG9fZG1hKGdyYW50X3JlZl90IGdyYW50KQ0KPj4+PiDCoMKgIHsN
Cj4+Pj4gLcKgwqDCoCByZXR1cm4gWEVOX0dSQU5UX0RNQV9BRERSX09GRiB8ICgoZG1hX2FkZHJf
dClncmFudCA8PCANCj4+Pj4gUEFHRV9TSElGVCk7DQo+Pj4+ICvCoMKgwqAgcmV0dXJuIFhFTl9H
UkFOVF9ETUFfQUREUl9PRkYgfCAoKGRtYV9hZGRyX3QpZ3JhbnQgPDwNCj4+Pj4gWEVOX1BBR0Vf
U0hJRlQpOw0KPj4+PiDCoMKgIH0NCj4+Pg0KPj4+IFdpdGggdGhpcyBjaGFuZ2UsIGNhbiB0aGUg
b2Zmc2V0IGFkZGVkIHRvIHRoZSBkbWEgaGFuZGxlLCBnZW5lcmF0ZWQgYnkNCj4+PiBncmFudF90
b19kbWEoKSwgYmUgdGhlIG9mZnNldCBpbiB0aGUgcGFnZT8gQ291bGRuJ3QgaXQgY29ycnVwdCB0
aGUNCj4+PiBncmFudCByZWY/DQo+Pg0KPj4NCj4+IEdvb2QgcG9pbnQsIGluZGVlZCwgSSB0aGlu
ayBpdCBjb3VsZCBjb3JydXB0IGlmIGd1ZXN0IHVzZXMgYSBkaWZmZXJlbnQNCj4+IHRoYW4gWGVu
IHBhZ2UgZ3JhbnVsYXJpdHkgKGkuZSA2NEtCKS4NCj4+DQo+Pg0KPj4+DQo+Pj4+IMKgwqAgwqAg
c3RhdGljIGlubGluZSBncmFudF9yZWZfdCBkbWFfdG9fZ3JhbnQoZG1hX2FkZHJfdCBkbWEpDQo+
Pj4+IMKgwqAgew0KPj4+PiAtwqDCoMKgIHJldHVybiAoZ3JhbnRfcmVmX3QpKChkbWEgJiB+WEVO
X0dSQU5UX0RNQV9BRERSX09GRikgPj4NCj4+Pj4gUEFHRV9TSElGVCk7DQo+Pj4+ICvCoMKgwqAg
cmV0dXJuIChncmFudF9yZWZfdCkoKGRtYSAmIH5YRU5fR1JBTlRfRE1BX0FERFJfT0ZGKSA+Pg0K
Pj4+PiBYRU5fUEFHRV9TSElGVCk7DQo+Pj4+IMKgwqAgfQ0KPj4+PiDCoMKgIMKgIHN0YXRpYyBz
dHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShzdHJ1Y3QN
Cj4+Pj4gZGV2aWNlICpkZXYpDQo+Pj4+IEBAIC03OSw3ICs3OSw3IEBAIHN0YXRpYyB2b2lkICp4
ZW5fZ3JhbnRfZG1hX2FsbG9jKHN0cnVjdCBkZXZpY2UNCj4+Pj4gKmRldiwgc2l6ZV90IHNpemUs
DQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxv
bmcgYXR0cnMpDQo+Pj4+IMKgwqAgew0KPj4+PiDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFu
dF9kbWFfZGF0YSAqZGF0YTsNCj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9
IFBGTl9VUChzaXplKTsNCj4+Pj4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFhF
Tl9QRk5fVVAoc2l6ZSk7DQo+Pj4+IMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHBmbjsNCj4+
Pj4gwqDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdyYW50Ow0KPj4+PiDCoMKgwqDCoMKgwqAgdm9p
ZCAqcmV0Ow0KPj4+PiBAQCAtOTEsMTQgKzkxLDE0IEBAIHN0YXRpYyB2b2lkICp4ZW5fZ3JhbnRf
ZG1hX2FsbG9jKHN0cnVjdCBkZXZpY2UNCj4+Pj4gKmRldiwgc2l6ZV90IHNpemUsDQo+Pj4+IMKg
wqDCoMKgwqDCoCBpZiAodW5saWtlbHkoZGF0YS0+YnJva2VuKSkNCj4+Pj4gwqDCoMKgwqDCoMKg
wqDCoMKgwqAgcmV0dXJuIE5VTEw7DQo+Pj4+IMKgwqAgLcKgwqDCoCByZXQgPSBhbGxvY19wYWdl
c19leGFjdChuX3BhZ2VzICogUEFHRV9TSVpFLCBnZnApOw0KPj4+PiArwqDCoMKgIHJldCA9IGFs
bG9jX3BhZ2VzX2V4YWN0KG5fcGFnZXMgKiBYRU5fUEFHRV9TSVpFLCBnZnApOw0KPj4+PiDCoMKg
wqDCoMKgwqAgaWYgKCFyZXQpDQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxM
Ow0KPj4+PiDCoMKgIMKgwqDCoMKgwqAgcGZuID0gdmlydF90b19wZm4ocmV0KTsNCj4+Pj4gwqDC
oCDCoMKgwqDCoMKgIGlmIChnbnR0YWJfYWxsb2NfZ3JhbnRfcmVmZXJlbmNlX3NlcShuX3BhZ2Vz
LCAmZ3JhbnQpKSB7DQo+Pj4+IC3CoMKgwqDCoMKgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHJldCwg
bl9wYWdlcyAqIFBBR0VfU0laRSk7DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBmcmVlX3BhZ2VzX2V4
YWN0KHJldCwgbl9wYWdlcyAqIFhFTl9QQUdFX1NJWkUpOw0KPj4+PiDCoMKgwqDCoMKgwqDCoMKg
wqDCoCByZXR1cm4gTlVMTDsNCj4+Pj4gwqDCoMKgwqDCoMKgIH0NCj4+Pj4gwqDCoCBAQCAtMTE2
LDcgKzExNiw3IEBAIHN0YXRpYyB2b2lkIHhlbl9ncmFudF9kbWFfZnJlZShzdHJ1Y3QgZGV2aWNl
DQo+Pj4+ICpkZXYsIHNpemVfdCBzaXplLCB2b2lkICp2YWRkciwNCj4+Pj4gwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRtYV9hZGRyX3QgZG1hX2hhbmRsZSwgdW5z
aWduZWQgbG9uZyBhdHRycykNCj4+Pj4gwqDCoCB7DQo+Pj4+IMKgwqDCoMKgwqDCoCBzdHJ1Y3Qg
eGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBpLCBu
X3BhZ2VzID0gUEZOX1VQKHNpemUpOw0KPj4+PiArwqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3Bh
Z2VzID0gWEVOX1BGTl9VUChzaXplKTsNCj4+Pj4gwqDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdy
YW50Ow0KPj4+PiDCoMKgIMKgwqDCoMKgwqAgZGF0YSA9IGZpbmRfeGVuX2dyYW50X2RtYV9kYXRh
KGRldik7DQo+Pj4+IEBAIC0xMzgsNyArMTM4LDcgQEAgc3RhdGljIHZvaWQgeGVuX2dyYW50X2Rt
YV9mcmVlKHN0cnVjdCBkZXZpY2UNCj4+Pj4gKmRldiwgc2l6ZV90IHNpemUsIHZvaWQgKnZhZGRy
LA0KPj4+PiDCoMKgIMKgwqDCoMKgwqAgZ250dGFiX2ZyZWVfZ3JhbnRfcmVmZXJlbmNlX3NlcShn
cmFudCwgbl9wYWdlcyk7DQo+Pj4+IMKgwqAgLcKgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHZhZGRy
LCBuX3BhZ2VzICogUEFHRV9TSVpFKTsNCj4+Pj4gK8KgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHZh
ZGRyLCBuX3BhZ2VzICogWEVOX1BBR0VfU0laRSk7DQo+Pj4+IMKgwqAgfQ0KPj4+PiDCoMKgIMKg
IHN0YXRpYyBzdHJ1Y3QgcGFnZSAqeGVuX2dyYW50X2RtYV9hbGxvY19wYWdlcyhzdHJ1Y3QgZGV2
aWNlICpkZXYsDQo+Pj4+IHNpemVfdCBzaXplLA0KPj4+PiBAQCAtMTY4LDcgKzE2OCw3IEBAIHN0
YXRpYyBkbWFfYWRkcl90IHhlbl9ncmFudF9kbWFfbWFwX3BhZ2Uoc3RydWN0DQo+Pj4+IGRldmlj
ZSAqZGV2LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGF0dHJzKQ0KPj4+PiDCoMKgIHsN
Cj4+Pj4gwqDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+Pj4+
IC3CoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBQRk5fVVAob2Zmc2V0ICsgc2l6ZSk7
DQo+Pj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQKG9mZnNl
dCArIHNpemUpOw0KPj4+DQo+Pj4gVGhlIG9mZnNldCwgaGVyZSwgcmVmZXJzIHRvIHRoZSBvZmZz
ZXQgaW4gdGhlIHBhZ2UgLi4uDQo+Pj4NCj4+Pj4gwqDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdy
YW50Ow0KPj4+PiDCoMKgwqDCoMKgwqAgZG1hX2FkZHJfdCBkbWFfaGFuZGxlOw0KPj4+PiDCoMKg
IEBAIC0yMDAsOCArMjAwLDggQEAgc3RhdGljIHZvaWQgeGVuX2dyYW50X2RtYV91bm1hcF9wYWdl
KHN0cnVjdA0KPj4+PiBkZXZpY2UgKmRldiwgZG1hX2FkZHJfdCBkbWFfaGFuZGxlLA0KPj4+PiDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxv
bmcgYXR0cnMpDQo+Pj4+IMKgwqAgew0KPj4+PiDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFu
dF9kbWFfZGF0YSAqZGF0YTsNCj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBsb25nIG9mZnNldCA9IGRt
YV9oYW5kbGUgJiAoUEFHRV9TSVpFIC0gMSk7DQo+Pj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGks
IG5fcGFnZXMgPSBQRk5fVVAob2Zmc2V0ICsgc2l6ZSk7DQo+Pj4+ICvCoMKgwqAgdW5zaWduZWQg
bG9uZyBvZmZzZXQgPSBkbWFfaGFuZGxlICYgflhFTl9QQUdFX01BU0s7DQo+Pj4NCj4+PiAuLi4g
d2hpbGUsIGhlcmUsIGl0IHJlZmVycyB0byB0aGUgb2Zmc2V0IGluIHRoZSBncmFudC4NCj4+PiBT
bywgdGhlIGNhbGN1bGF0ZWQgbnVtYmVyIG9mIGdyYW50cyBtYXkgZGlmZmVyLg0KPj4NCj4+IEdv
b2QgcG9pbnQsIEkgdGhpbmsgeW91IGFyZSByaWdodCwgc28gd2UgbmVlZCB0byBhZGRpdGlvbmFs
bHkgdXNlDQo+PiB4ZW5fb2Zmc2V0X2luX3BhZ2UoKSBtYWNybyBpbiB4ZW5fZ3JhbnRfZG1hX21h
cF9wYWdlKCksDQo+Pg0KPj4gc29tZXRoaW5nIGxpa2UgdGhhdCB0byBiZSBzcXVhc2hlZCB3aXRo
IGN1cnJlbnQgcGF0Y2g6DQo+Pg0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFu
dC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+IGluZGV4IDlkNWVj
YTZkNjM4YS4uYmI5ODRkYzA1ZGViIDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQt
ZG1hLW9wcy5jDQo+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+IEBAIC0x
NjksNyArMTY5LDcgQEAgc3RhdGljIGRtYV9hZGRyX3QgeGVuX2dyYW50X2RtYV9tYXBfcGFnZShz
dHJ1Y3QNCj4+IGRldmljZSAqZGV2LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCj4+IMKgIMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgYXR0cnMpDQo+PiDCoCDCoHsNCj4+IMKgIMKg
wqDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+PiAtwqDCoMKg
wqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gWEVOX1BGTl9VUChvZmZzZXQgKyBzaXpl
KTsNCj4+ICvCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQ
KHhlbl9vZmZzZXRfaW5fcGFnZShvZmZzZXQpDQo+PiArIHNpemUpOw0KPj4gwqAgwqDCoMKgwqDC
oMKgwqAgZ3JhbnRfcmVmX3QgZ3JhbnQ7DQo+PiDCoCDCoMKgwqDCoMKgwqDCoCBkbWFfYWRkcl90
IGRtYV9oYW5kbGU7DQo+Pg0KPj4gQEAgLTE5MSw3ICsxOTEsNyBAQCBzdGF0aWMgZG1hX2FkZHJf
dCB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKHN0cnVjdA0KPj4gZGV2aWNlICpkZXYsIHN0cnVjdCBw
YWdlICpwYWdlLA0KPj4gwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuX3BhZ2VfdG9fZ2ZuKHBhZ2UpICsgaSwgZGlyID09
DQo+PiBETUFfVE9fREVWSUNFKTsNCj4+IMKgIMKgwqDCoMKgwqDCoMKgIH0NCj4+DQo+PiAtwqDC
oMKgwqDCoMKgIGRtYV9oYW5kbGUgPSBncmFudF90b19kbWEoZ3JhbnQpICsgb2Zmc2V0Ow0KPj4g
K8KgwqDCoMKgwqDCoCBkbWFfaGFuZGxlID0gZ3JhbnRfdG9fZG1hKGdyYW50KSArIHhlbl9vZmZz
ZXRfaW5fcGFnZShvZmZzZXQpOw0KPj4NCj4+IMKgIMKgwqDCoMKgwqDCoMKgIHJldHVybiBkbWFf
aGFuZGxlOw0KPj4gwqAgwqB9DQo+Pg0KPj4gRGlkIEkgZ2V0IHlvdXIgcG9pbnQgcmlnaHQ/DQo+
Pg0KPg0KPiBJIHRoaW5rIGl0ICdzIG1vcmUgY29tcGxpY2F0ZWQgdGhhbiB0aGF0Lg0KPiBMZXQn
cyBzYXkgdGhhdCB0aGUgb2Zmc2V0IGluIHBhZ2UgaXMgPiBYRU5fUEFHRV9TSVpFLCB0aGVuIHRo
ZSANCj4gY2FsY3VsYXRpb24gb2YgdGhlIG51bWJlciBvZiBncmFudHMgd29uJ3QgdGFrZSBpbnRv
IGFjY291bnQgdGhlIHBhcnQgDQo+IG9mIHRoZSBvZmZzZXQgdGhhdCBpcyBtdWx0aXBsZSBvZiB0
aGUgWEVOX1BBR0VfU0laRSBpLmUgaXQgd2lsbCANCj4gY2FsY3VsYXRlIG9ubHkgdGhlIHN0cmlj
dGx5IG5lY2Vzc2FyeSBudW1iZXIgb2YgZ3JhbnRzLg0KPiBCdXQgeGVuX2dyYW50X2RtYV9tYXBf
cGFnZSgpIGdyYW50cyBhY2Nlc3MgdG8gdGhlIHdob2xlIHBhZ2UgYmVjYXVzZSwgDQo+IGFzIGl0
IGNhbiBiZSBvYnNlcnZlZCBpbiB0aGUgY29kZSBzbmlwcGV0IGJlbG93LCBpdCBkb2VzIG5vdCB0
YWtlIGludG8gDQo+IGFjY291bnQgdGhlIHBhZ2Ugb2Zmc2V0Lg0KPg0KPiBmb3IgKGkgPSAwOyBp
IDwgbl9wYWdlczsgaSsrKSB7DQo+IMKgIGdudHRhYl9ncmFudF9mb3JlaWduX2FjY2Vzc19yZWYo
Z3JhbnQgKyBpLCBkYXRhLT5iYWNrZW5kX2RvbWlkLCANCj4geGVuX3BhZ2VfdG9fZ2ZuKHBhZ2Up
ICsgaSwgZGlyID09IERNQV9UT19ERVZJQ0UpOw0KPiB9DQoNCg0KVGhhbmtzLCB2YWxpZCBwb2lu
dC4gQWdyZWUgaXQncyBpbmRlZWQgbW9yZSBjb21wbGljYXRlZC4gSSB3aWxsIGNvbW1lbnQgDQpv
biB0aGF0IGxhdGVyLiBJIGhhdmUganVzdCBwdXNoZWQgYW5vdGhlciBmaXgsIGl0IGlzIG5vdCBy
ZWxhdGVkIHRvIA0KWEVOX1BBR0VfU0laRSBkaXJlY3RseSwgYnV0IGFsc28gYWJvdXQgcGFnZSBv
ZmZzZXQgPiBQQUdFX1NJWkUNCg0Kc28gdG91Y2hlcyB0aGUgc2FtZSBjb2RlIGFuZCBzaG91bGQg
YmUgcHJlcmVxOg0KDQpodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMjEwMDcxMzI3MzYu
MjI3NTU3NC0xLW9sZWtzdHlzaEBnbWFpbC5jb20vDQoNCg0KPg0KPj4+DQo+Pj4NCj4+Pj4gK8Kg
wqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFhFTl9QRk5fVVAob2Zmc2V0ICsgc2l6ZSk7
DQo+Pj4+IMKgwqDCoMKgwqDCoCBncmFudF9yZWZfdCBncmFudDsNCj4+Pj4gwqDCoCDCoMKgwqDC
oMKgIGlmIChXQVJOX09OKGRpciA9PSBETUFfTk9ORSkpDQo+Pj4NCj4+DQo+PiBUaGFuayB5b3Uu
DQo+Pg0KPj4NCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 13:50:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 13:50:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418022.662787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognjh-0004NG-OI; Fri, 07 Oct 2022 13:49:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418022.662787; Fri, 07 Oct 2022 13:49:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognjh-0004N9-Kc; Fri, 07 Oct 2022 13:49:57 +0000
Received: by outflank-mailman (input) for mailman id 418022;
 Fri, 07 Oct 2022 13:49:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=nDAh=2I=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ognjf-0004N3-Pj
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 13:49:55 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80089.outbound.protection.outlook.com [40.107.8.89])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ebc1f680-4646-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 15:49:53 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBAPR04MB7381.eurprd04.prod.outlook.com (2603:10a6:10:1a2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 13:49:52 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Fri, 7 Oct 2022
 13:49:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebc1f680-4646-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U/7uQhADUEaCqTGDclxtDpKfQSG9bu/Klxe9LUV8B/m4J09+FqVbm9Ho1iCRWItiVO246Sj+smZab1lOlE8pCUH4lpNeWbIugBwu3COfpbq3AvvxlGCnNr42HSDykbsdKwTMIBHyLGLmRUChAhWuEvUZ+klw1iBX1REGfWEiw3OMLZX4a7+nRNi4wCz4QoOSMN8SHnJHskMshtifZx7+81pCyM7v3zh/MmbcPv5ugQUJ35dJnh4u4zM5F0GOht1HiQjHUtpRGCwk233CI59qqAzgBMnrXP0sJCZG3G14ud2z3RBxnJbZAN6rQk70j2S/TXyxaBjMkBYzHFQKcGwLvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n1geE7tFZULpCd4gG2I2wIrr0GVOAo3LXIf39DALJ1Q=;
 b=OSqN8/n/boBVwG+T17xHnYSxpVwG3HoGvk1oaADfhVdGVgGk+VNuelPmUCTQ/NDzYz2mTbWDHsw/wsSpCj0B8E4GudA/NyE+Z09tjzrEIf3vTor2xv9h7kr86K7J6BDmstLXuBTeOCjV4s661BjfpiTz1xDUtMwEg996rwAay6Yjznpft7krP3lAoR/gsd6/oiOSFHA1WsGrMZ+vWS6ERfRkzJl4OJbW6A7OIFipd2b4AhzWmeS2j2pfrBTJWcaQ85zAN+v6pzgSP5jHyI362XuGb8elM9CfbCxDZaLfINkWFIop88I/J/T3qBLSisxzw2RecGGvlhzMo5nFG6fzIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n1geE7tFZULpCd4gG2I2wIrr0GVOAo3LXIf39DALJ1Q=;
 b=TGqvwOlUpY7IJtJZ11olXxV1u1ROZ5IWpdJWDXxE0LfQZ99qVFQPbLXDCn3VGn1ui/rkjuAKOFBwKMljzK8jvSfLqab7MkUHaU559jyO0kfIhC5GI8HMGyJ4iNub09Ce4BWd+WH43qO3NtrYm68H8iRHTRJNC8Y4vVJ28HB3cRyZx7+sNlXBpfrhXPQi09aYpwx+ySeEK3lgx+X2jZb6t9laaHQx/yAEpFQu76atS1wb7zVsOerE4Ta9zJOqkO2Uny8z5UvytB47uvLWlGpgYdmvmxV3KxWpb+qDfmqqUdhzfkkPCPmuoT2kqliYMqhPdxd3CUhzPtSVmLNZhsXEJQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <806fa06b-adee-caa5-0b6d-aaf1282fca11@suse.com>
Date: Fri, 7 Oct 2022 15:49:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 0/9] gnttab: further work from XSA-380 / -382 context
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
In-Reply-To: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0106.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::7) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7381:EE_
X-MS-Office365-Filtering-Correlation-Id: 23e96c1e-4afc-498b-2380-08daa86acf1f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eC3SvXj4yL9LgZK/KEaC/OACDPiv2+QcDehSIFYadMIo7eSlWLQ8nyTX4lzVVxi3C3CWJS9xdyPIx+xjKJ4wB/6/k+jXODnWoHwEuamWCb2uBFUwKM8rnrNH0aep7PdaFXGjxA0Dc6oGxIVboeRarZnnirBROri22fhsqecSfQCJEgxC2WlYmqpebCB8GgOm0HTeA4SrynlUsH2uuPHx7XbaTiXhcyAdcMcxfzi+/ZPE4ERvySMf3SIPNipNS5z0E+XaeVf4qqmtUyQmXKVqr4BDDxONvmrQEmC/iKQAds/ZxNisF76zxYbgGNV3Y1XAm3mXJbju+/HxEgnQ6060Jzv6ArE9ZMgF3dSfwUhkuk7FAmhAPzCuWu4Fj1fk9l6IiqnHwUyZKyzItHYwt2KxHuvbM4crPIWlrWWsZ3ekKSZf6q30gH9g7vwnzE+XDIo52sNDAsABXZXEvtkTS5GRMK7aHBEl8EeIyhC5jmnKK9pz2+rYAt7VJJ72G3VXAGf4RBoMUalJb9Qr7XkwbMFYb8dSBNLOgg3bIA1CfOWL8As4xQ/bC1h6Q5JLbeB3h5KMNj71RrGaQyAky2IjC8s1Ipeq2HWsjVerDAZMNXralHT8BZRNvuAoeBoiJkWihhCWzNQQjgnnBlwE9yBHOF5P306coXfWDIuhkUTOJ74gLKvUVTzdtKAywUUQPnwTXgQYNM+1NowMJcnc22QnWs4HzRofmT8HCFd9f1O+oy2FdAnH7qhNfJccdIYiVXNE+2KfVXaXyecRWWrLvqtnnLb375WGqk3jYR9M6dkDySl0q7M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(366004)(376002)(39850400004)(396003)(451199015)(66556008)(66946007)(316002)(86362001)(54906003)(31696002)(6916009)(66476007)(5660300002)(36756003)(2906002)(8936002)(4326008)(41300700001)(186003)(2616005)(38100700002)(83380400001)(478600001)(8676002)(6486002)(6512007)(53546011)(6506007)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkJxVXFwMmY0MzZVUVVDckx4ZEhKWGR3R1hnSm1PNHVMdStHUU1kKzhkdS9U?=
 =?utf-8?B?SllaMEpZZWtRNy9uVitXNjNGemVkbTNCZ0JjUFFpMWl2OW9abXRCbzVuS2JM?=
 =?utf-8?B?dDd5MS82ZEROZ1YyQkdYSnBCUkE5dzI1TzFTR0FGZVV4U2dxbjNVMWp0bmFx?=
 =?utf-8?B?dWYwbmdNNVB4dlhjUHlWSGYyTnY4TkdYZTljRmdZQnVtLzZwLzI0UkFaMTh2?=
 =?utf-8?B?bFoxYVFyUDNqOVYrTkhFajJwWHAyelZBY1lFanA1aURNa0k3RjhRWjF3Z0l2?=
 =?utf-8?B?VldPMnFQUUdteU5ZcDZoOTUxWm1PenFrUFE4WUJqK0FNT1pHczk4SDJQVEsx?=
 =?utf-8?B?RzQ3cjdROEJqVitpZlhHSkIxRWxGNHNYWldwTHRKV0I3eE1wdGlZTFZFakNZ?=
 =?utf-8?B?TXN3SHZhRk13Qm1yUmlJcGZYeG9od25qaS9pUlJ4TjJuQVpuekZrQVAzbFRw?=
 =?utf-8?B?TEJuMXZiS3p1Ky8rZldKWldLTGtlMy81dEpxZzlHUTRVL1k3bXMrM25QdE1Z?=
 =?utf-8?B?VVlBOVFRVTdNNG0zK2dqOXhFYTFzNStqTnBXa2NrOTBhOG0vSzJ5TVAwQkRK?=
 =?utf-8?B?NTdDSDNMc1NQR2szZ3hzMmtuN1gvRUkyWm9POGFRVXZUREJZaXRINExHWFdk?=
 =?utf-8?B?d1JKWVdaWWo4dHRQd3N2V2JUbkQ5VWNOd3QreU56Q3M0RHR3YjZVSU5zaVo3?=
 =?utf-8?B?dG1pVUpwQnVVUjJUbGdEOW5UL3BBU1BmNXV4T05hN0R4WXhFd21JUGpFbEtl?=
 =?utf-8?B?RVYwNUFSV013NndKcEhMSjhZSUd3SjdEZ3VrbEh5Y0NEQm5hMk95SEZ5dDhS?=
 =?utf-8?B?OUUzSkNTYXZiTENoS3k4cWhBNmVhVzZQaCtJOVBZUXNMYVA5eHhnYU03MjAz?=
 =?utf-8?B?NFBUWXBNK0J5Y2RrZDh3R1N6cmlJQ3hnQ0szenBLbWRoVE1DanFFQkhmTWRn?=
 =?utf-8?B?TGdiTkNhTnRiSEI0VFdYUWEwS3BBYWg4b3BucEhoNnVYT2IwT05lN2Q4N1cy?=
 =?utf-8?B?dnlySWNFYVZqVk1uQ3FEY0VpaXZYQlFRT2p2aDE2cGxnekkyV3J5bmdWbmRw?=
 =?utf-8?B?a0RoRFQ0MDc4VlVLSHhZMUdjSkFGN1pVd2dLcjd1MHBlanFReWcySmdDTCsx?=
 =?utf-8?B?bEp2cEI2RVlsWDQwY2VUcWI2NThqYzRvYkhVYmtPcExRcm40OWVybTh4MHQ2?=
 =?utf-8?B?SnR1L09Yb2RSdTUxOFo3RERXd0Z3WitPSktZV1UxbzFDZWFpb0F5YWRiM3E2?=
 =?utf-8?B?cEtGZCthVFJJMTR0NVdpRldXaHFTVCs1ZnU4VGtkWkc5ZHpyUTYxN3krbEdm?=
 =?utf-8?B?Yis1RG9ZMXpvZGllYy9NUFRiYUJLeVFVVzdESndEMVhnMGtiSVB0WXFmV2Y4?=
 =?utf-8?B?ZkJTMDI2UVp5UjJxVmdVaXN6cUlJcW1TakpLRlozcVdlbkJMWmJ1UnhUODVW?=
 =?utf-8?B?ZFovclRiN3lFTTVuN3pZTmpsMFZiYmVSeHYrb2FQcFQveVRBME93M2FVQTU0?=
 =?utf-8?B?eDdjS1VuMHdkMzFXbjlLNnhzbE93ejNvQmZHdXFyUHErUGpXV0lhYmd1aU9M?=
 =?utf-8?B?SW5DSDFzL3V1czFQZFhYVVYrYS9RNUJxTGZ6WitjeXVZT1FTNE1TQ2FTZ0NS?=
 =?utf-8?B?Zk94eUk0NjdiaDUxdnlEQzhETmlMY0xRRkdrL1d6eE5Sd2pBd0o1YTVkUXFj?=
 =?utf-8?B?LzhhVEZNMjNWc2pkYjVVblNKS08rMnRkVHhZZ3hrRXV2RUNkYlR2V2kwempo?=
 =?utf-8?B?WWFWRStMejR5VUVMN3VwekxuWDBxVHg4aXB4clhVelh0ZUtvejh6Q0x5S1FY?=
 =?utf-8?B?V05CZzFaR2VuZzJlNXRmTTJmQjlMWldnRW9hMDZOVGhqa3U5bVl3Wm05OUNl?=
 =?utf-8?B?RXhtMkgya1RIYW5UQmx4LzR1ejVHVDRCZE04OWhTYkw2aWFxdTJoenVEOEZh?=
 =?utf-8?B?WFJIYWZ2UXhuTmJIRUJTdzBUWFdTQ0g3SjV2Y3h3QlNNZm1nSEsyUmVJaTBn?=
 =?utf-8?B?UGFtZ2p6VkY0YjRjKzE5dXUxV0dzRGpYWldLaG1YaExKNCt0RGF6cjVwYVZG?=
 =?utf-8?B?NHYxc0ViQTVsMy9RV1NkYklpMEd6RHRXdjhBRXR5Qm1MK1ZmKzJBZzBZZkdG?=
 =?utf-8?Q?myN+GD2P+BDGoZsdzJ9AavRiP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23e96c1e-4afc-498b-2380-08daa86acf1f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 13:49:52.2833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fd/BgG+E9aXSWN5VN9Kcr+OiEoda6f1p//MyGDfEQgYLxq9zo5o3mmaZacjM39P8pJ/ORcdb0QWwJWMIFdQLeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7381

On 26.08.2021 12:06, Jan Beulich wrote:
> The first four patches can be attributed to the former, the last four
> patches to the latter. The middle patch had been submitted standalone
> before, has a suitable Reviewed-by tag, but also has an objection by
> Andrew pending, which unfortunately has lead to this patch now being
> stuck. Short of Andrew being willing to settle the disagreement more
> with Julien than with me (although I'm on Julien's side), I have no
> idea what to do here.
> 
> There's probably not much interrelation between the patches, so they
> can perhaps go in about any order.
> 
> 1: defer allocation of maptrack frames table
> 2: drop a redundant expression from gnttab_release_mappings()
> 3: fold recurring is_iomem_page()
> 4: drop GNTMAP_can_fail
> 5: defer allocation of status frame tracking array

Just to make "official" what I've said in the course of the resource
management discussion at the event in Cambridge: I'm withdrawing 1
and 5, in the expectation that eager/lazy allocation of resources
will become a property to be honored uniformly for a guest. With 2,
3, 4, and 6 already having gone in, it would still be nice to
(finally) have feedback on ...

> 6: check handle early in gnttab_get_status_frames()
> 7: no need to translate handle for gnttab_get_status_frames()
> 8: bail from GFN-storing loops early in case of error
> 9: don't silently truncate GFNs in compat setup-table handling

... the remaining three - even if these aren't really 4.17 candidates
anymore at this point.

Thanks, Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 14:01:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 14:01:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418028.662798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognuU-0006mM-ON; Fri, 07 Oct 2022 14:01:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418028.662798; Fri, 07 Oct 2022 14:01:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognuU-0006mF-LK; Fri, 07 Oct 2022 14:01:06 +0000
Received: by outflank-mailman (input) for mailman id 418028;
 Fri, 07 Oct 2022 14:01:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7mFU=2I=epam.com=prvs=2279168535=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ognuS-0006m9-Pm
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 14:01:04 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 79293f3d-4648-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 16:01:01 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297C3MBd025463;
 Fri, 7 Oct 2022 14:00:39 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2058.outbound.protection.outlook.com [104.47.9.58])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k20nb4anx-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 14:00:38 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB9PR03MB7386.eurprd03.prod.outlook.com (2603:10a6:10:22e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Fri, 7 Oct
 2022 14:00:35 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 14:00:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79293f3d-4648-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eFivTvUKWHqpavf7j1zPUPqkhbO0qX+rqnB/JUy6Wh8qNgZOd0TP0Aj4DfXNsHYEvqdf49Mbm6S1tt5qTzAOMrzcvWPv4VW6SQxBPpTHeB49T3MAzA+0RpHykbxDhdtjZYZLdb1ThLbcfPdzwm6DCxSd/xVlQntLcpwIE/9blSNazQNDzOa95744Fv0rOXXgBkySdiUAr1LEUq9K3mwt4GwNk+N561Lz6665nM709BOFs4BKGWMmWiZk1rvX01/qlpIn2XtTBmJ5mUBAaCROrvTgnKwdsHw1kRNbIElQ/GlQHK3Ec0aCrr2UrTFpLmsvEzS36fqQqLQwokDvza6TIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ags55PeKbSsqNlzYypdKeg9SP0GNzJO8cTuoFQ5Jz3E=;
 b=T7lrcQqshKqsbhXEtG4nE8u8H6V8OeaJ3bKJasUPa5wuXliYHcu7vBaTRmNkCEU5otr36+MTzn2s7KmPgQG7ao7+mS9MRCvWFKZU97noQ9V4IxMudQPMwXfA9MjsUfPsh5SBBdgrM9f1C0vC/9yXGQLtBnSM98hM1cz9ceWgHHlWpLdliMuJW1vXoFcMCzQWXaba+U/gcZ6f610U7pvl6XMVoPgYX4i1ekhhES9aox+nWRbJ58uRqHLseRiStR4FUjE700Lt7m44c2UJbSxiRCrG7A9pbHiK2pxTHdy5slyzJZpx464xLmg03Rw8PMrRd0uKUn1AuotcB6LxDXfrfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ags55PeKbSsqNlzYypdKeg9SP0GNzJO8cTuoFQ5Jz3E=;
 b=KgeAQ0FAy2KQC/AdCNQT3tRnyTbl3y9T+EgG4KXuSTfkrG4zMavReVQaW1The9/OYKubhZvMqNCpmFNS4wdS5Co/vIwSnsLAHfJpv/dWmEALubeTjkkYsvKwLom+h/xeOHcYdkD9w4homEyW2gq7yCYCqcPHqGFLIfr3qBjrff9ZwRGguftCDABhZBVchCqenG9EL/UAjkL56VymkCAQL738Kk/XmO0IJsLfhuCMSvJfZZZ4OMunqjgFeOiYPmhJAkcI7DELHZQ4nsI5EAvfFgDm+UjtlXutdbbscaPuAvq49iRU8iQQrX4oo1hufmrmDI3hW5xzPx96bbw72Y8jfA==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Juergen Gross <jgross@suse.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov
	<bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin"
	<hpa@zytor.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 3/3] xen/virtio: enable grant based virtio on x86
Thread-Topic: [PATCH v2 3/3] xen/virtio: enable grant based virtio on x86
Thread-Index: AQHY2hfsYkIZ8bm8YEiah662d3CFb64C9ieA
Date: Fri, 7 Oct 2022 14:00:35 +0000
Message-ID: <67c9ec7d-a67d-ca28-4354-68e38aa27e13@epam.com>
References: <20221007064143.10049-1-jgross@suse.com>
 <20221007064143.10049-4-jgross@suse.com>
In-Reply-To: <20221007064143.10049-4-jgross@suse.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DB9PR03MB7386:EE_
x-ms-office365-filtering-correlation-id: fd3cf473-7856-4072-15dc-08daa86c4e9c
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 VOmahMLWpEB/f3fv1bgVVZhnrk2/ZNPjbkTZmKmmEJSULFq0rQoOA6sJ414inwYRhoRxDEkzEbiYUJGHmHjf/WmYpMvAq2tRh0kqDQffTjfZW+boVXrIS9kwf4Bz0CRhGzcl4klZK73z6Gp2V92fdogEqqiSniHw5YANAQzoNlp0x2m3Sx+3VMaHwetdjvvz2X+8JvNVLzvdHnGrVHFiHKIceOURX/FA8AG5yapgfnk0MMTlcXua6uaKCESPcc0yZ7uvST1ziXTGx63Y6xJTuqaU80ihooP0gIw8ZbdS9j8w1Lo2SZeqCV7dmgPsdUA76ZJskoeAazDp42BpdJJOIue2wFCoYzatYwktkg6vV5El0x2Pltih2S01kVFeggKkrseg0ZSAztEEXzA3IoCJ9TXOg3LDhZSYFDKPhI1gGtz+JCoSNjttdJ/ujrjMM0Mxf3Dv4oNRrWVlU/QCxbhVzMHHD4MKt8CX9IQyjp3aMGselbDSNuC9hX9zexGGoZ8IQ7l9FAz7bT4oXjNtLjoysq4iorD7d8qtYGPoUFU2OcmPMF6GYJLnV4RDsXqrPS429WJ0vp+pslQCS8Ya4vkBBfVMVAcW+tDF44Wg8zOwqZlK6r4CSrnKpXcUkFr3zBoDjRbLb8UGkKEneD8yqJE9mQE80qkmkOtoZZGmuuCA8qgzyH+AcNKFqr0f0gEyvs+inGIeahYDUE4xNmINFLm/G3hNlI16eG6LIIWKKXX2yMLEZZiofyUNlAmnpPiJc2SoYanQqM05JGuvP2Wh4Etjb73X7bJwO9Bd5k9lDNM/eiA=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(38070700005)(4326008)(478600001)(122000001)(66446008)(91956017)(316002)(186003)(8676002)(38100700002)(76116006)(6486002)(64756008)(6506007)(66556008)(66476007)(66946007)(53546011)(55236004)(31696002)(36756003)(6512007)(2616005)(110136005)(86362001)(71200400001)(83380400001)(31686004)(8936002)(54906003)(5660300002)(26005)(41300700001)(7416002)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?QjY4VWR1M2J2ek1IMUtRa0lpUkxjdDBTK3hhUnB1aWRCYlBXUVFCVWg2RHJU?=
 =?utf-8?B?NFVxSGthaEtkeWJkcnRqUXJ6MkZBKzJ5dVNLdEYwdCtuMlA0eDR1amV4bitH?=
 =?utf-8?B?MndCbEZJbkZRV1JiQ1M4cFprQVFjVlROcHNYUUloYzBBdHpxL05DZVNuTFda?=
 =?utf-8?B?QzgxdnNkQnMzbi84NitNMXRGdWRmWFdEdER1ZDZMMmtzZ0tIcVVnL1lRd0ZL?=
 =?utf-8?B?L3ExanRzV0c5YnlqNk52K3hFYjliYjV2NW53OHlGZjErNXdabnBsNU9UWjhS?=
 =?utf-8?B?elMwM2Q5ZG1mZm9zYzVTMThuOTRkU3k0WnhneWw0NGcrSDU2aVRmSWNja3lz?=
 =?utf-8?B?emppKzZxWS91cEdNWWl4QXRyaWdaaTJDdkZlTkZsOE5tVFJKRmpLS05aTjUx?=
 =?utf-8?B?UFo4TXd0dnJCUFk0SlpDelJVVklQazV2dm9Dek12Mmwzb2hYOXNMQk9GQnNZ?=
 =?utf-8?B?M3EyYVRhRzFLdHZVS2hHaGx6Sld2alY4U2p1eEk1aWRKQlZlU2w1Tk5vWElC?=
 =?utf-8?B?dG13SmtFSGd3VHNYQ1lHUiswNEN2ZytDYmlVbzAvVENGRzg1OXUwVXAvS2o0?=
 =?utf-8?B?RzF1UVBKclBYcFc0SklRdjVDV0Q1MklPOXdlbURHSDJtZVB2eXRGYkZYeEZP?=
 =?utf-8?B?dzZVNGQrQ0VXMnZZZHRCY0F5OWVUbzVyQW1WenVPNFc2eHZ2NkRjMTJ5ekFU?=
 =?utf-8?B?aTFWUjNsSXlLQUM3Um00aTdqeFZuTEZacWw4SU1tdVFGcTIyNmlzazRQam8v?=
 =?utf-8?B?dmpZSXZVSzB3bXU5M0lwNXAwSUVKY1dRbk9wV3N0VE9iTTEvQ3hXaytNZnZL?=
 =?utf-8?B?cTRoc0VicENzb2JpR1RNN0o0WEtDb2kvR29jbHgycVkzTWkyUFMwVjlpQll3?=
 =?utf-8?B?SGpOSklZWVpYdEhISklZL3E4MnFPbkQwWEV3Rzc3Z2dBUG1aMW5iU05mM0NE?=
 =?utf-8?B?YkhhTjB2cjl4ajZHLytNcnF0Q0cwc0pDMjg3S0RxcWNJaWRZbWpMaU8zZmRT?=
 =?utf-8?B?UUNoY2RCN29vQW5FV0h3dkdHcisxNTZZSHRJK2FwZUUva250ZkNHTWlpTmp2?=
 =?utf-8?B?RVRCN210Ylk2YkdDQkVKcmpiMENsVzk2STJyVUIzUGJ5eU9reHdOTHA2NTJF?=
 =?utf-8?B?SlJJUXFoTjdjSVU3QlZWMUpudzJ1THpmdFRDTUtYYXY0ZmZaZ2ZUb1AxL0ZH?=
 =?utf-8?B?d2VKN21FQXZLYUhOVnRxdUZnNWZ3Zm5xUmhoTFhPZkw2ZlRqT2UxYjQ2Tndi?=
 =?utf-8?B?dVdTdWhjY3hpRkh4aDNWOE84REEwL2VHUkE3L1FZZTRFYzlvd2NWV1VoOE94?=
 =?utf-8?B?NEU4eG03WXU1Tkc5K2FBbzhnVDhKY2thOU9ZYzlKT1Q1T3JPYWF3M3BVWUhw?=
 =?utf-8?B?SlpqSDZVVkhXdVM0UG82aURGWmZsYUpWaE1QODFMTWpkMllhUkFIa3MrOTVq?=
 =?utf-8?B?MkQ0UFlrcnR6UTI0RXY4SE9lMmU4OGtFbWx1N1VmMkFaMU9GSFVqc2s0U3NQ?=
 =?utf-8?B?UzRjdkRFWGl5dk1KU3dPVWRSTHJPR3JCT3NnRVZzeFNXdzJXelBYTG5xQ0w0?=
 =?utf-8?B?VXJRVEE2MlNLeVJ2VCtZZ1BRbTJ4aExGamJsdFV3NExiM3lpOGJ3YjVxNVZa?=
 =?utf-8?B?TVNFUXZSVG9nYVE1Y0xsOVJ5ZXN1S05MTFVxZjU4VkFDUVRQN3hXRy9iZHhB?=
 =?utf-8?B?SFpkbjNqS3Jtc3VwRHVETzJWWXNicVA0b2NFemdXYWpuRUhuOHhDU0oxSk0r?=
 =?utf-8?B?dy94VElsOUpSSUVKZDNyUEJLa1JoTWY4VTJMVnkwdVNFTkdMSmpnTTlhM3Zw?=
 =?utf-8?B?K2dmZmhvRWF1MDJ2K1RSQ0NQK3FZNmFJQUZQSkdCNE9MNkFNcWxBME9sUVdj?=
 =?utf-8?B?bEMySHhQS1dkRlVvdVdoSS8vWk5uYmp4M2wrZEIrcVlQTTNJUzcvOWZOM0tn?=
 =?utf-8?B?RlhYZ1EwbVQ4RStpL1c5S0JhSlA1MlBqT256TkY2cFVKVmovWlRVTUx4YVZC?=
 =?utf-8?B?Y2xxTjdaR1phanBGUEN6NmxRYTZZN3prZ2YvVTRVdkZzZjdvK2s4MWh5REdE?=
 =?utf-8?B?bkhDbllHMXg0WmlEYjUwZ0JSRFlqd2pQMTVXU0xEa0VSODd4c21Samh4Y3Za?=
 =?utf-8?B?RDdHWHJKWUNSUXhvMmFXdCtsbnc0R29uVFc2L2pIdWlRWXZvT2ZZMmNqQUdS?=
 =?utf-8?Q?VScg2nC91d485m0db2Vim1w=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <179546D82EEDFE43A30ADD7CEF10892C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd3cf473-7856-4072-15dc-08daa86c4e9c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 14:00:35.4820
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lXuw4QY6RBOcJrykcB4bMI9R6O5xCxotnGXkfGUPzYKt592BlO9B8oamTMlKEoOSjxxxEFlMANyS6LK/PRojeyrTvcDKvJKnqHQJLYQ+LOY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7386
X-Proofpoint-ORIG-GUID: FdgSj0ecZl9EDy2LzbyinQOvrftmdvjm
X-Proofpoint-GUID: FdgSj0ecZl9EDy2LzbyinQOvrftmdvjm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-06_05,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 clxscore=1015 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0
 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210070084

DQpPbiAwNy4xMC4yMiAwOTo0MSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCg0KSGVsbG8gSnVlcmdl
bg0KDQo+IFVzZSBhbiB4ODYtc3BlY2lmaWMgdmlydGlvX2NoZWNrX21lbV9hY2NfY2IoKSBmb3Ig
WGVuIGluIG9yZGVyIHRvIHNldHVwDQo+IHRoZSBjb3JyZWN0IERNQSBvcHMuDQo+DQo+IFNpZ25l
ZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4gLS0tDQo+IFYyOg0K
PiAtIGFkZCBtaXNzaW5nIFBWIGNoZWNrIGluIHhlbl92aXJ0aW9fbWVtX2FjYygpIChPbGVrc2Fu
ZHIgVHlzaGNoZW5rbykNCj4gLSBhZGQgeGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2MoKSBz
dHViIChPbGVrc2FuZHIgVHlzaGNoZW5rbykNCg0KDQpSZXZpZXdlZC1ieTogT2xla3NhbmRyIFR5
c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPiAjIA0KY29tbW9uIGNvZGUN
Cg0KDQo+IC0tLQ0KPiAgIGFyY2gveDg2L3hlbi9lbmxpZ2h0ZW5faHZtLmMgfCAgMiArLQ0KPiAg
IGFyY2gveDg2L3hlbi9lbmxpZ2h0ZW5fcHYuYyAgfCAgMiArLQ0KPiAgIGRyaXZlcnMveGVuL2dy
YW50LWRtYS1vcHMuYyAgfCAxMiArKysrKysrKysrKy0NCj4gICBpbmNsdWRlL3hlbi94ZW4tb3Bz
LmggICAgICAgIHwgIDYgKysrKysrDQo+ICAgNCBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25z
KCspLCAzIGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL2VubGln
aHRlbl9odm0uYyBiL2FyY2gveDg2L3hlbi9lbmxpZ2h0ZW5faHZtLmMNCj4gaW5kZXggMWMxYWM0
MTg0ODRiLi5jMWNkMjhlOTE1YTMgMTAwNjQ0DQo+IC0tLSBhL2FyY2gveDg2L3hlbi9lbmxpZ2h0
ZW5faHZtLmMNCj4gKysrIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9odm0uYw0KPiBAQCAtMjEy
LDcgKzIxMiw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCB4ZW5faHZtX2d1ZXN0X2luaXQodm9pZCkN
Cj4gICAJCXJldHVybjsNCj4gICANCj4gICAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJU
SU9fRk9SQ0VfR1JBTlQpKQ0KPiAtCQl2aXJ0aW9fc2V0X21lbV9hY2NfY2IodmlydGlvX3JlcXVp
cmVfcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4gKwkJdmlydGlvX3NldF9tZW1fYWNjX2NiKHhlbl92
aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4gICANCj4gICAJaW5pdF9odm1fcHZfaW5mbygp
Ow0KPiAgIA0KPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jIGIvYXJj
aC94ODYveGVuL2VubGlnaHRlbl9wdi5jDQo+IGluZGV4IDliMWE1OGRkYTkzNS4uNDViMjRjMWI2
NDZhIDEwMDY0NA0KPiAtLS0gYS9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX3B2LmMNCj4gKysrIGIv
YXJjaC94ODYveGVuL2VubGlnaHRlbl9wdi5jDQo+IEBAIC0xMTIsNyArMTEyLDcgQEAgc3RhdGlj
IHZvaWQgX19pbml0IHhlbl9wdl9pbml0X3BsYXRmb3JtKHZvaWQpDQo+ICAgew0KPiAgIAkvKiBQ
ViBndWVzdHMgY2FuJ3Qgb3BlcmF0ZSB2aXJ0aW8gZGV2aWNlcyB3aXRob3V0IGdyYW50cy4gKi8N
Cj4gICAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU8pKQ0KPiAtCQl2aXJ0aW9fc2V0
X21lbV9hY2NfY2IodmlydGlvX3JlcXVpcmVfcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4gKwkJdmly
dGlvX3NldF9tZW1fYWNjX2NiKHhlbl92aXJ0aW9fcmVzdHJpY3RlZF9tZW1fYWNjKTsNCj4gICAN
Cj4gICAJcG9wdWxhdGVfZXh0cmFfcHRlKGZpeF90b192aXJ0KEZJWF9QQVJBVklSVF9CT09UTUFQ
KSk7DQo+ICAgDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9k
cml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4gaW5kZXggYzcwM2I3N2IzM2M5Li42M2MzZjBk
YWMwNjYgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPiArKysg
Yi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4gQEAgLTI5Nyw3ICsyOTcsNyBAQCBib29s
IHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4gICANCj4gICBi
b29sIHhlbl92aXJ0aW9fbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KQ0KPiAgIHsN
Cj4gLQlpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVCkpDQo+ICsJ
aWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQpIHx8IHhlbl9wdl9k
b21haW4oKSkNCj4gICAJCXJldHVybiB0cnVlOw0KPiAgIA0KPiAgIAlyZXR1cm4geGVuX2lzX2dy
YW50X2RtYV9kZXZpY2UoZGV2LT5kZXYucGFyZW50KTsNCj4gQEAgLTM3Miw2ICszNzIsMTYgQEAg
dm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ICAgCWRl
dl9lcnIoZGV2LCAiQ2Fubm90IHNldCB1cCBYZW4gZ3JhbnQgRE1BIG9wcywgcmV0YWluIHBsYXRm
b3JtIERNQSBvcHNcbiIpOw0KPiAgIH0NCj4gICANCj4gK2Jvb2wgeGVuX3ZpcnRpb19yZXN0cmlj
dGVkX21lbV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikNCj4gK3sNCj4gKwlib29sIHJl
dCA9IHhlbl92aXJ0aW9fbWVtX2FjYyhkZXYpOw0KPiArDQo+ICsJaWYgKHJldCkNCj4gKwkJeGVu
X2dyYW50X3NldHVwX2RtYV9vcHMoZGV2LT5kZXYucGFyZW50KTsNCj4gKw0KPiArCXJldHVybiBy
ZXQ7DQo+ICt9DQo+ICsNCj4gICBNT0RVTEVfREVTQ1JJUFRJT04oIlhlbiBncmFudCBETUEtbWFw
cGluZyBsYXllciIpOw0KPiAgIE1PRFVMRV9BVVRIT1IoIkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz
dXNlLmNvbT4iKTsNCj4gICBNT0RVTEVfTElDRU5TRSgiR1BMIik7DQo+IGRpZmYgLS1naXQgYS9p
bmNsdWRlL3hlbi94ZW4tb3BzLmggYi9pbmNsdWRlL3hlbi94ZW4tb3BzLmgNCj4gaW5kZXggZGFl
MGYzNTBjNjc4Li5hMzRmNDI3MWEyZTkgMTAwNjQ0DQo+IC0tLSBhL2luY2x1ZGUveGVuL3hlbi1v
cHMuaA0KPiArKysgYi9pbmNsdWRlL3hlbi94ZW4tb3BzLmgNCj4gQEAgLTIxOSw2ICsyMTksNyBA
QCBzdGF0aWMgaW5saW5lIHZvaWQgeGVuX3ByZWVtcHRpYmxlX2hjYWxsX2VuZCh2b2lkKSB7IH0N
Cj4gICB2b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldik7DQo+
ICAgYm9vbCB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpOw0KPiAg
IGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYpOw0KPiAr
Ym9vbCB4ZW5fdmlydGlvX3Jlc3RyaWN0ZWRfbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2RldmljZSAq
ZGV2KTsNCj4gICAjZWxzZQ0KPiAgIHN0YXRpYyBpbmxpbmUgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBf
ZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ICAgew0KPiBAQCAtMjM0LDYgKzIzNSwxMSBA
QCBzdGF0aWMgaW5saW5lIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0cnVjdCB2aXJ0aW9fZGV2
aWNlICpkZXYpDQo+ICAgew0KPiAgIAlyZXR1cm4gZmFsc2U7DQo+ICAgfQ0KPiArDQo+ICtzdGF0
aWMgaW5saW5lIGJvb2wgeGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2Moc3RydWN0IHZpcnRp
b19kZXZpY2UgKmRldikNCj4gK3sNCj4gKwlyZXR1cm4gZmFsc2U7DQo+ICt9DQo+ICAgI2VuZGlm
IC8qIENPTkZJR19YRU5fR1JBTlRfRE1BX09QUyAqLw0KPiAgIA0KPiAgICNlbmRpZiAvKiBJTkNM
VURFX1hFTl9PUFNfSCAqLw0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtv
DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 14:03:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 14:03:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418034.662808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognwx-0007Mg-4r; Fri, 07 Oct 2022 14:03:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418034.662808; Fri, 07 Oct 2022 14:03:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ognwx-0007MZ-2A; Fri, 07 Oct 2022 14:03:39 +0000
Received: by outflank-mailman (input) for mailman id 418034;
 Fri, 07 Oct 2022 14:03:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4A9H=2I=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1ognwv-0007MT-PE
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 14:03:38 +0000
Received: from sonic316-54.consmr.mail.gq1.yahoo.com
 (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d4d2d36e-4648-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 16:03:35 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.gq1.yahoo.com with HTTP; Fri, 7 Oct 2022 14:03:33 +0000
Received: by hermes--production-ne1-6944b4579f-8xbfz (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 6c531180527f65d2a4b3d734797c933b; 
 Fri, 07 Oct 2022 14:03:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4d2d36e-4648-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1665151413; bh=T9kVCstbl5ELaapgtMaHCSmWDUTJT+1+RInIVz8Z/Vw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=ptbu+gpXbie762iHNGuc2mCBhF/ILqbAXeoRC/ZbxM9FBPBox38UbjNkmhU0TnCp3hgbL0F/AdRvh6XrxMFODqOXQPcvwn1yGpI75pFd6IK+8tdaYt6EXn+q+AZ1A084NF9SEkfU8xyV3u8RD0NWoybSnCNOZNLwXT6NTKZrcjunU5srRme0fZ4VOq7zL72byL38ryrkLSOQ7zHurs3PEz5FJzU5KRfgVWiWlw/1CqamfoVe49E86jYoCNaqG7ZOJAwRD3SyeRwq13BqFvu3N/OFRFl/rh5Dw3xUrmViH8OKVW4+sMgGflmBpa1nIzLt8zZ2THn1iDwCJiXSL6Z8Aw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665151413; bh=fpHJhdJ2Jl0cn4d/t/rIO0lfB4X0ZVQsFaOkMTozNIm=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=M1UMMrHacvoO/XmmX4k0TMvZBpcXCfb2aDLTHVmoJ9KHGCLZb0UFjIpDODRRVxCZ4zkCcD0m6WMZIAVexRw0A6ev+wqNrohkutGwiC7nZ3WktlbYnKol1LwqLiTWd1Pj8gF61UYXwEslTXxCRxcPGq4FCCh06sT8CGCMhvH0ciWh5fuyDR9VBUhZVmLPeLMq4UDR4Cy15INf58YdioKMI9L619FpQJUDwbvsDn4sQHLZmEtMufnG1jaXTOdBJxFKRzDHZONSiwr+huRCadpXpSNS8P57vWSJIVnhhdNHGOB6CV+OjjJjamOlZFxaQ89BJ5zcmKm8CE/p7AJbm6gIWg==
X-YMail-OSG: 562pW9sVM1mBDkIbeVFt7wj0_DvsTm0Iiv8pBLZjH6eKtDhgu9XP7.d6STN3KO5
 sAcPOpQNsXmUYCkMzgwvfkqH3U8otpwVgDdeUjWYsxe403zv9iNuTuk1IzvdVg_GkSGh0FZxVQyR
 mrKB.j2iFdmbEj.j7BMbLL27ayIxK0pAkYTHEW4IM4p2HrYhVVJ1OPpz4GxQ5JX9HpTsKAq1iocP
 kxKuELWj7EQz3BY4XiNPnjnrX87W.Dguool3qrjYzglEvskx3pxUt94J4ck7o_gsUEH32IRUPGIK
 Lu_TPBMAelfebUpdSECZBsSmiprsLQXBmFLQmSEGi.CaqpaaTVQu2.gMBe5giv_qoTeiPXy2W.5D
 cRePK6mlBrRp3sFBRn6R30rEruve0Zy_x5zWGNuP9BVibKa8N47EalbVJ2o93655b.db8qTl528i
 _AkI4tTNspv5V8N2o_zZ14pf03JlarADtHdgNrn.fccCPKvm1Zp.wfAhP7RD8wvKWRZcHrP89N8M
 z1QE78_NjNvBYwaSMP3uDCGdzCbZWnWf8mQ5QR773fzOKs2S7Aqg33qtR29pGbSSQiTgNSsuEeDa
 Vq0CNq5cc5.nKPhG.y7ckhTiZFqy4uLIqiXhhyt1.njhuFj.LG_Xpy288XGW9t8SgbEWCMpKjECC
 4ke_LKVmExJvLm8ejJp7p3Qdh4_VDYG7T3GtHd7IDxyxl8UgPFkMesJdVn4K2wIZeVHvo.9yLZi5
 GkMKYY8n_KE5zqsqVb3_dl3qY7tXivp60B8mQJSfde_UE93fGf96EULKzwsHg3uDuvYsjFELAift
 JlixFV70ZndO4uG4DZJGi8ozFCFgo7SyVcImYn9AgDbxb7rVVCG_RhKg.CurKu9cGXdlwrnxLKPd
 Bjq3IqEQRHSdBjnLyUGUNjh2ejlMXNshf_5QWdJDoh.FL4bdTXFWcVUoLs4zPpJ1eTRYoocWqsto
 _Hrvh1.HzriKDLfA7o0TrXU0aWhqk3Fad.8Fv7Zc4y.cVvtJUD4dLkr637MPk8Ni63AkPIpatyp_
 oXJw3JFdgkS0tHynjfIouekaugqwA2KX8e5bcbH1SrSAQpRwWPMKMjmFW9N4cQQsbasTxtKQpKrv
 fOXpzE6AxCKwVsRy84AvF7.DZlC0WekD2ihFn70nWLS87kqA.McwSB24GYQb6hS4uXkJpeQjX_wx
 UqygF48jYuNcPrpnQll2ue6CEnUTrFIry9f20sWL_cRFa9ITQU.Sb_y6Njx5XfyH.Vy10PiBl3_6
 pOAM24ux_0IHMq9LJOWN.chBzBEywXNc2anIGGJhHa2mfu.PDOLvMlCKaT8iJweIPnz2JaAbpTPe
 R0aHwJuK6MepWpQFh7qWQIOBouW5JQ7iO.PIK7YRJOQ03QYF8gO3mffNuZdqhHIn4UBZA9YTHchs
 Qw1EQp_g2822zNdzgBFO9T._I0H1vYuQGZfHQrdYWqX9xsePdR1tm4aUyasNfhAA3qsMN.dJ297n
 nwQRpISQmCGI2FP1jbx.U2hBq9N4dA9_EYCr9xCp85pXcOuonC5lhrc3oTORDmsiXRQ3Hz8x_6dx
 rdC_aY2RCHtVhnRW82HDHJqEesTrPqBEa8fCtGPWeeIRuEETvJunC7hNmr5hfCMANcMp3EiAxMi2
 2GTFeqB6RirPZICebIMWc_Ei41m44VS6GZnmqPmYim0YHg9Yesbs8aDfGoCVP_hmRLEjcJcvt8zy
 _VWrYXhipjMGaUdqk224aoPx_mx3y01.ZMLamwgmzVW97tRpFql5NI5oJ5qb76_s4PT.goHygm9B
 3gyHIK22ccqwyJ_oMPNv.P9INvPX51b5oG9AJJRsQ9juh_TaQcx51p9nI5J1dbP_fUqTIpkMS4x3
 pQoxyPAr7jgIboZ.Si4wVaPOZdkDDANgOXcorwoMlBRq.kgm_HAiOAbt6gpWKaXd.46L657fjvso
 6beWS8Xvz.ntt5Oh7ffPtPoXBWDRdNBoM9rwwXoyrDqf_hNZi_BRaQBtwXNfkQDr0ESkeGu9P74H
 z7PC2rjl7pZ1Fg1V4k0EO9Bt63HDH1pxo0h.bc1UgBDjGGQV2s06y2TUS5JDHIDgja1SIvMih9aS
 Jv3L92gYrEZcx06.yQLAxrmXYehlbBdU6iDSArtJpS1mb95m8PpS42q3dZZ7q0XNfuc772.qq0OB
 pieEuj2d2iL70A1Wyi6qyeHMidItAcMcOSQsmP9Tyw46xRYLia507yFbckbWj9iqqnRvH_A9hNZi
 nYR9EvGfB01tY
X-Sonic-MF: <brchuckz@aim.com>
Message-ID: <93c05893-6058-4e5e-9d5a-d127ceb52f2e@netscape.net>
Date: Fri, 7 Oct 2022 10:03:26 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Support for UEFI guest booting on Xen x86 (Was: Re: xen ovmf/uefi
 firmware does not save screen resolution)
From: Chuck Zmudzinski <brchuckz@netscape.net>
To: xen-users@lists.xenproject.org
Cc: xen-devel <xen-devel@lists.xenproject.org>
References: <mailman.3.1663934401.4493.xen-users@lists.xenproject.org>
 <423215ee-fac0-06c5-1156-3c74e98cff12@liberaliatempus.com>
 <9639a6cb-8e9b-6c67-4ed7-7df2e84d6f25@netscape.net>
Content-Language: en-US
In-Reply-To: <9639a6cb-8e9b-6c67-4ed7-7df2e84d6f25@netscape.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 8026

On 10/7/2022 8:02 AM, Chuck Zmudzinski wrote:
> On 10/6/2022 9:38 AM, Liberalia Tempus, S.L. wrote:
> > Thank you very much for your answers.
> >
> > Finally, after trying some of the solutions proposed by Chuck, I have 
> > made the decision to delete the UEFI partition and move it to a normal 
> > MBR system.
>
> Did you know you can keep the GPT partitions and the EFI partition and boot HVM guests
> using MBR (seabios) with a GPT BIOS Boot partition present in the guest's virtual boot disk?
> I implemented that by stealing the last 1 MB of the EFI GPT partition and assigned that 1 MB
> to be a BIOS boot GPT partition, and grub2 is smart enough to install its own MBR bootcode
> into that partition and it works fine in Xen HVMs by using seabios instead of ovmf as the
> firmware/bios for the guest in the xl.cfg guest configuration file. But that's not necessary if
> you are going to give up on using the EFI partition and GPT partitions and go back to the
> legacy MBR partitioning scheme. What you are doing is a sensible option also given Xen's
> current lack of support for UEFI booting of Xen HVM guests that actually works.
>
> > I think it's too cumbersome all this xen and UEFI booting stuff and 
> > there's no point in spending more time on it. At the end of the day what 
> > matters in a virtual environment is that the machine works, regardless 
> > of the system used to boot.
> > As of today, UEFI booting does not work properly in xen/qemu, at least 
> > not for people who are not experts in xen code.
> > Best regards.
> >
> > PS: Chuck, what you say about version 4.14 I have not been able to apply 
> > in a vm with windows 10. It seems to work with a hvm vm with linux, but 
> > not with a windows vm.
>
> That may be true, because I have only tried UEFI booting of a Linux HVM guest. I have always
> used MBR booting of Windows HVM guests with either the stdvga Qemu emulated graphics
> device as the Windows HVM guest's primary graphics device or VGA passthrough of the Intel
> IGD graphics device to the HVM Windows guest as the guest's primary graphics device.
>
> I will in the meantime try to get UEFI booting working for both Windows and Linux HVM guests
> for the future and at the same time use the BIOS boot GPT partition hack to give me the option to
> use MBR booting with seabios instead of ovmf as the firmware/bios for the HVM guest until
> Xen works well enough with UEFI booting of HVM guests. Obviously the MBR technology is legacy
> tech and Xen needs to eventually be updated to support the UEFI booting method of HVM guests
> going forward. I am not aware of much work in this area being done by the Xen developers, but
> I am not subscribed to xen-devel so I could be wrong about that and I would welcome any
> Xen developer who could explain to Xen users what work is being done to support UEFI booting
> of Xen HVM guests in the future.

Specifically, what is Xen's current strategy for supporting UEFI booting of guests (Windows, Linux, etc.)
on the x86 Xen hypervisor?

For example, is using HVM guests with the upstream Qemu device model considered legacy tech and
the work to develop support for UEFI booting in the future should be done using PVH guests instead
of HVM guests?

Kind regards,

Chuck

>
> Best regards,
>
> Chuck
>
> >
> > -------------------------
> > MhBeyle __
> > > Date: Thu, 22 Sep 2022 11:25:41 -0400
> > > From: Chuck Zmudzinski <brchuckz@netscape.net>
> > >
> > >
> > > On 9/22/2022 4:37 AM, mhbeyle@yahoo.es wrote:
> > >> Thanks for the answers.
> > >>
> > >> Chuck, I tried at the time to apply suggested patches to the software
> > >> with no results. It is not clear that any of the current patches solve
> > >> the problem.
> > >>
> > >> I think there are two problems here: One, the virtual machine that
> > >> creates xen uses QEMU and the UEFI bios is not able to communicate the
> > >> resolution data to the system. Two, this kind of problem would be easily
> > >> solved by virtualizing a more modern vga instead of the current cards
> > >> (cirrus etc.)
> > > Actually, this might be a bug in Xen 4.16 that was not in Xen 4.14.
> > >
> > > On Debian 11 (bullseye/stable for Dom0) booting HVM with Tiano Core
> > > UEFI works for me using vga = stdvga and videoram = 16:
> > >
> > > With Debian 11.x stable for dom0, the Xen version is 4.14 and the Qemu
> > > version is a bit old, 5.2, but booting with ovmf/uefi works:
> > >
> > > I boot Debian 11.x (stable) in a Xen HVM using ovmf using vga = stdvga in the
> > > xl.cfg and it seems to work in a VNC window. I can get 1920x1080 resolution
> > > (with videoram = 16 in the xl.cfg), but this only works on Debian stable dom0
> > > with Xen version 4.14.x and Qemu version 5.1 (haven't checked if Debian
> > > backported Qemu version 7.0 for Debian 11 also works).
> > >
> > > After login, use the gnome display settings and it gives the option of up
> > > to 1920x1080 resolution with videoram = 16. I presume KDE, XFCE, MATE, etc.
> > > also would allow this.
> > >
> > > It is true the Tiano Core UEFI boot configuration setup screen and the grub
> > > screen resolution is low (I think only 800x600) at the beginning of booting.
> > >
> > > Here is my xl config for ovmf (UEFI booting with vga = stdvga, videoram = 16)
> > > and a VNC display and Debian stable with Xen 4.14.x dom0 and Qemu 5.2 in
> > > dom0 on Debian stable:
> > >
> > > --- domain configuration file ---
> > > builder = 'hvm'
> > > bios = 'ovmf'
> > > memory = '6144'
> > > vcpus = '4'
> > > disk = ['/dev/linux/bullseye,,xvda,w']
> > > name = 'bullseye-hvm'
> > > vif = [ 'mac=<redacted>,type=vif,script=vif-route,ip=<redacted>' ]
> > > on_poweroff = 'destroy'
> > > on_reboot = 'restart'
> > > on_crash = 'restart'
> > > boot = 'c'
> > > acpi = '1'
> > > apic = '1'
> > > viridian = '1'
> > > xen_platform_pci = '1'
> > > serial = 'pty'
> > > vga = 'stdvga'
> > > videoram = '16'
> > > sdl = '0'
> > > vnc = '1'
> > > vnclisten = '0.0.0.0'
> > > vncdisplay = '1'
> > > usb = '1'
> > > usbdevice = 'tablet'
> > > --- End of domain configuration file ---
> > >
> > > But the same configuration with Xen 4.16 and Qemu 7.1 in dom0 that is in Debian
> > > unstable, and also in Fedora 36 with Xen 4.16 and Qemu 6.2 I think, I get a crash at
> > > boot - it does show the Tiano Core configuration screen and grub screen at 800x600
> > > resolution but crashes soon after. When trying to boot Fedora 36 in a Xen HVM with
> > > ovmf, I got this in the journal of the guest:
> > >
> > > xen-qemu-system-i386: relocate_memory 4096 pages from GFN bf000 to GFN c1000 failed: Invalid argument
> > >
> > > Also, with a good boot (using seabios) I get this in the journal of the guest,
> > > but is missing from the boot that crashes:
> > >
> > > fedora kernel: BIOS-e820: [mem 0x00000000fc000000-0x00000000fcffffff] reserved
> > >
> > > The size of this missing entry is 4096 pages, which is probably what Qemu is trying to
> > > relocate but cannot with ovmf/uefi boot because it is missing. 4096 pages is 16 MB,
> > > which is probably the video shared memory.
> > >
> > > This is probably a bug/regression in Xen somewhere between Xen 4.14 and 4.16
> > > and I will try to bisect it when I have time.
> > >
> > > Best regards,
> > >
> > > Chuck
> > >
> > >> that are not recognized by the operating system when using
> > >> UEFI and do not load specific drivers. For example, the problem is
> > >> solved using qxl and a driver in Windows, but the qxl development is not
> > >> complete and fails.
> > >>
> > >> With limitations, it seems that the problem in QEMU is solved by
> > >> changing the parameters in the BIOS and doing a warm/soft reboot. I
> > >> don't know why, this can't be done in xen. The settings are never saved
> > >> and the reboot, at least in windows 10, is always a cold one (xen
> > >> destroys the virtual machine and recreates it. The soft reboot parameter
> > >> hangs the vm).
> > >>
> > >> Regards.
> > >>
> > >> __________
> > >> MhBeyle ___
> > >>
> > >>
> > >>
> > >
> >
> >
>
>



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 15:10:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 15:10:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418082.662837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogozl-0007SM-Jw; Fri, 07 Oct 2022 15:10:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418082.662837; Fri, 07 Oct 2022 15:10:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogozl-0007SF-HG; Fri, 07 Oct 2022 15:10:37 +0000
Received: by outflank-mailman (input) for mailman id 418082;
 Fri, 07 Oct 2022 15:10:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NgR6=2I=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ogozk-0007S9-8I
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 15:10:36 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 310bad83-4652-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 17:10:34 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id E0889211C3;
 Fri,  7 Oct 2022 15:10:33 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AA80913A9A;
 Fri,  7 Oct 2022 15:10:33 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id fEN9J2lBQGO7JgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 07 Oct 2022 15:10:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 310bad83-4652-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665155433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/9NyaT9kc7y2hABIl2Ej5DgC0r071ytcPJuf8xermk8=;
	b=CaOHIGOZFZt9dj2LYvEYX4OkngiTbpUmGdHrW+ZMcHT9pA9H+vMyZRHxrSSBKMyzKalxZR
	a6t42FtdPnm5L46/ZL3c88gDmYkjUirA56uFTOAgjRTqWxGNpEbrw8Js4YLsGTGQUfK78G
	T4Q3CNh/ybOQEhubChhdndqgf4zIAMI=
Message-ID: <090c9202-68ed-a62b-c10a-350e1531bd90@suse.com>
Date: Fri, 7 Oct 2022 17:10:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
References: <20221007132736.2275574-1-olekstysh@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221007132736.2275574-1-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------eG0Azqfrz4Pl3dZ20BiE4UjI"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------eG0Azqfrz4Pl3dZ20BiE4UjI
Content-Type: multipart/mixed; boundary="------------zrU2QzhXpGsV8GuX8utfpQG4";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
Message-ID: <090c9202-68ed-a62b-c10a-350e1531bd90@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
References: <20221007132736.2275574-1-olekstysh@gmail.com>
In-Reply-To: <20221007132736.2275574-1-olekstysh@gmail.com>

--------------zrU2QzhXpGsV8GuX8utfpQG4
Content-Type: multipart/mixed; boundary="------------wFlYredAldefDdUApsew02Gt"

--------------wFlYredAldefDdUApsew02Gt
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMTAuMjIgMTU6MjcsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBQYXNzZWQgdG8geGVuX2dyYW50X2RtYV9tYXBfcGFnZSgpIG9mZnNldCBpbiB0
aGUgcGFnZQ0KPiBjYW4gYmUgPiBQQUdFX1NJWkUgZXZlbiBpZiB0aGUgZ3Vlc3QgdXNlcyB0
aGUgc2FtZSBwYWdlIGdyYW51bGFyaXR5DQo+IGFzIFhlbiAoNEtCKS4NCj4gDQo+IEJlZm9y
ZSBjdXJyZW50IHBhdGNoLCBpZiBzdWNoIGNhc2UgaGFwcGVuZWQgd2UgZW5kZWQgdXAgcHJv
dmlkaW5nDQo+IGdyYW50cyBmb3IgdGhlIHdob2xlIHJlZ2lvbiBpbiB4ZW5fZ3JhbnRfZG1h
X21hcF9wYWdlKCkgd2hpY2gNCj4gd2FzIHJlYWxseSB1bm5lY2Vzc2FyeS4gVGhlIG1vcmUs
IHdlIGVuZGVkIHVwIG5vdCByZWxlYXNpbmcgYWxsDQo+IGdyYW50cyB3aGljaCByZXByZXNl
bnRlZCB0aGF0IHJlZ2lvbiBpbiB4ZW5fZ3JhbnRfZG1hX3VubWFwX3BhZ2UoKS4NCj4gDQo+
IEN1cnJlbnQgcGF0Y2ggdXBkYXRlcyB0aGUgY29kZSB0byBiZSBhYmxlIHRvIGRlYWwgd2l0
aCBzdWNoIGNhc2VzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVu
a28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KDQpSZXZpZXdlZC1ieTogSnVl
cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K
--------------wFlYredAldefDdUApsew02Gt
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------wFlYredAldefDdUApsew02Gt--

--------------zrU2QzhXpGsV8GuX8utfpQG4--

--------------eG0Azqfrz4Pl3dZ20BiE4UjI
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNAQWkFAwAAAAAACgkQsN6d1ii/Ey9w
cwf5AVa4s11Y5TevJXo/7Xv6prUoX8Mb6XJ9VNtq6sVZ2QkeRLYsl1YIfP5kKZCJGnZd+Dmz6LR4
J28x7tykCI6ETL3xkZugQ8N6N4wUFX/jFeldfGqJ88E9szfsH+AXun+IKFIP5ERenZeZrHsc3l9u
uY5JFKB638pauo0ZAqWKwyOw0c2D83ODznUTLAiTGDmAun3ududV93gveG4JZshcrvIDad5qMvis
hCJBd8U13qOlseyAN8f8hXknaW2Av07OZ0lVizdWN8bJJwWOl9Dkn1bI5sAmqdZ8arOKd5HelF2S
k9lxdI/asCTVbpYgMPpJVTkqPcZVGNTyIVAHGeZmYg==
=Au6E
-----END PGP SIGNATURE-----

--------------eG0Azqfrz4Pl3dZ20BiE4UjI--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 15:50:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 15:50:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418127.662866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogpca-0004YT-07; Fri, 07 Oct 2022 15:50:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418127.662866; Fri, 07 Oct 2022 15:50:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogpcZ-0004YM-Tb; Fri, 07 Oct 2022 15:50:43 +0000
Received: by outflank-mailman (input) for mailman id 418127;
 Fri, 07 Oct 2022 15:50:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hbjo=2I=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ogpcY-0004YG-Cv
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 15:50:42 +0000
Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com
 [2a00:1450:4864:20::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb853515-4657-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 17:50:41 +0200 (CEST)
Received: by mail-ej1-x62a.google.com with SMTP id ot12so12266594ejb.1
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 08:50:41 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 r9-20020a1709061ba900b00782cd82db09sm1395373ejg.106.2022.10.07.08.50.39
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 07 Oct 2022 08:50:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb853515-4657-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=fNTmuNCWLOBt7Dn0WJ9AWpiVdld1LXssI0yIAz367cA=;
        b=epIDQ6A1NNQAad6uG5hDVw65y+OS+Gi7r1NkL6k7hU1W/gPZkSZiyNbfyA0m4OrKJm
         cTosb3yx0utfeygMpBS7Flbe00GJQoiNG6p9H+qj7AysMK77myuofqRcnU+LG/eutpD+
         uMd/EYLzhOPPCW4x01BjMJUqSR2lS5UlXEYQ7PSp0MXWOGw8XWX8LYCMLEUkFEvhz/SD
         FJD0CGHm2PKwIBO7oDsO+y10ko8spzKUhV9D2BMcwJi7182EGQp8PyWD6hFxFa9kgIP9
         7QkRRP9UkyncU0vPYiPS2IFymQcQ8T00hoP8p6TbvBWY/fdj6SWQqN7+JWt9z45KV05J
         Y96A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=fNTmuNCWLOBt7Dn0WJ9AWpiVdld1LXssI0yIAz367cA=;
        b=tyxpqZWNpL9rk0sGaEs4GJb1tA7X/x2fllWe4oOKUNkVC3MHVPWgjFzxadBg0TsXXa
         bY0OeCoHWvB/tMjcNa+mnRW5JU+bxebYuUdd6vAuxcakyy714ya/K2niyYC6mWj8yPw9
         2uJJOKKFkG5wGOplW2nzk0oV98bUKvKS50N1Tsnx/ATrWYe4c1icI1oydGtLG0cfkkd0
         PdK7pV2l9D/DqoBZaiqu4yfX/ZKRsPDZQHnmd78I7F4x9ztjD4damJ4PrJPeqUt7ccNz
         q7bpqvCLoPgXXx64FmVTtRwyiWlOXLE9ZGjP6of2iHtB+XShlvN2kblAGF/kjGVNW2WF
         +2hA==
X-Gm-Message-State: ACrzQf1+XWkpdShG+LV22biOquW11Cr9BaP4I/dEPLGc4ORrmWlMNpVd
	3dL2vRkRLoGavcX0T5B5794=
X-Google-Smtp-Source: AMsMyM6Df+6E0+r6CgIGkIXFZqhXP/GHw9Pf0It4zNF+xakRMXSZw9LtRpRSeR3bhbNF8kZlo/hI1g==
X-Received: by 2002:a17:907:62a1:b0:781:b320:90c0 with SMTP id nd33-20020a17090762a100b00781b32090c0mr4432995ejc.255.1665157840495;
        Fri, 07 Oct 2022 08:50:40 -0700 (PDT)
Message-ID: <677bc264-c507-3bed-6d51-0d010a0dd449@gmail.com>
Date: Fri, 7 Oct 2022 18:50:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
 <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
 <816da52a-f646-c114-fa6d-9320152a0e79@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <816da52a-f646-c114-fa6d-9320152a0e79@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10/7/22 16:43, Oleksandr Tyshchenko wrote:
> 
> On 07.10.22 10:15, Xenia Ragiadakou wrote:
>>
>> On 10/7/22 00:13, Oleksandr Tyshchenko wrote:
>>
>> Hi Oleksandr
> 
> 
> Hello Xenia
> 
> 
>>
>>>
>>> On 06.10.22 20:59, Xenia Ragiadakou wrote:
>>>
>>> Hello Xenia
>>>
>>>>
>>>> On 10/6/22 15:09, Oleksandr Tyshchenko wrote:
>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> Although XEN_PAGE_SIZE is equal to PAGE_SIZE (4KB) for now, it would
>>>>> be more correct to use Xen specific #define-s as XEN_PAGE_SIZE can
>>>>> be changed at some point in the future.
>>>>>
>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>> ---
>>>>> Cc: Juergen Gross <jgross@suse.com>
>>>>> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
>>>>>
>>>>> As it was proposed at:
>>>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!zHt-xZ_7tZc_EM6zva21E_YgwIiEeimFWfsJIpPwAu-TBcnzQhXHqlKzmXmwIcI6uIx_arHNZiaZeHt_428_8p-DyMpd$
>>>>>
>>>>> [lore[.]kernel[.]org]
>>>>>
>>>>> Should go in only after that series.
>>>>> ---
>>>>>     drivers/xen/grant-dma-ops.c | 20 ++++++++++----------
>>>>>     1 file changed, 10 insertions(+), 10 deletions(-)
>>>>>
>>>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>>>>> index c66f56d24013..5392fdc25dca 100644
>>>>> --- a/drivers/xen/grant-dma-ops.c
>>>>> +++ b/drivers/xen/grant-dma-ops.c
>>>>> @@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices,
>>>>> XA_FLAGS_LOCK_IRQ);
>>>>>       static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>>>>>     {
>>>>> -    return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant <<
>>>>> PAGE_SHIFT);
>>>>> +    return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant <<
>>>>> XEN_PAGE_SHIFT);
>>>>>     }
>>>>
>>>> With this change, can the offset added to the dma handle, generated by
>>>> grant_to_dma(), be the offset in the page? Couldn't it corrupt the
>>>> grant ref?
>>>
>>>
>>> Good point, indeed, I think it could corrupt if guest uses a different
>>> than Xen page granularity (i.e 64KB).
>>>
>>>
>>>>
>>>>>       static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>>>>>     {
>>>>> -    return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >>
>>>>> PAGE_SHIFT);
>>>>> +    return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >>
>>>>> XEN_PAGE_SHIFT);
>>>>>     }
>>>>>       static struct xen_grant_dma_data *find_xen_grant_dma_data(struct
>>>>> device *dev)
>>>>> @@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device
>>>>> *dev, size_t size,
>>>>>                      unsigned long attrs)
>>>>>     {
>>>>>         struct xen_grant_dma_data *data;
>>>>> -    unsigned int i, n_pages = PFN_UP(size);
>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(size);
>>>>>         unsigned long pfn;
>>>>>         grant_ref_t grant;
>>>>>         void *ret;
>>>>> @@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device
>>>>> *dev, size_t size,
>>>>>         if (unlikely(data->broken))
>>>>>             return NULL;
>>>>>     -    ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
>>>>> +    ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
>>>>>         if (!ret)
>>>>>             return NULL;
>>>>>           pfn = virt_to_pfn(ret);
>>>>>           if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>>>>> -        free_pages_exact(ret, n_pages * PAGE_SIZE);
>>>>> +        free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
>>>>>             return NULL;
>>>>>         }
>>>>>     @@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device
>>>>> *dev, size_t size, void *vaddr,
>>>>>                        dma_addr_t dma_handle, unsigned long attrs)
>>>>>     {
>>>>>         struct xen_grant_dma_data *data;
>>>>> -    unsigned int i, n_pages = PFN_UP(size);
>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(size);
>>>>>         grant_ref_t grant;
>>>>>           data = find_xen_grant_dma_data(dev);
>>>>> @@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device
>>>>> *dev, size_t size, void *vaddr,
>>>>>           gnttab_free_grant_reference_seq(grant, n_pages);
>>>>>     -    free_pages_exact(vaddr, n_pages * PAGE_SIZE);
>>>>> +    free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
>>>>>     }
>>>>>       static struct page *xen_grant_dma_alloc_pages(struct device *dev,
>>>>> size_t size,
>>>>> @@ -168,7 +168,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>>>> device *dev, struct page *page,
>>>>>                          unsigned long attrs)
>>>>>     {
>>>>>         struct xen_grant_dma_data *data;
>>>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>>>
>>>> The offset, here, refers to the offset in the page ...
>>>>
>>>>>         grant_ref_t grant;
>>>>>         dma_addr_t dma_handle;
>>>>>     @@ -200,8 +200,8 @@ static void xen_grant_dma_unmap_page(struct
>>>>> device *dev, dma_addr_t dma_handle,
>>>>>                          unsigned long attrs)
>>>>>     {
>>>>>         struct xen_grant_dma_data *data;
>>>>> -    unsigned long offset = dma_handle & (PAGE_SIZE - 1);
>>>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>>>> +    unsigned long offset = dma_handle & ~XEN_PAGE_MASK;
>>>>
>>>> ... while, here, it refers to the offset in the grant.
>>>> So, the calculated number of grants may differ.
>>>
>>> Good point, I think you are right, so we need to additionally use
>>> xen_offset_in_page() macro in xen_grant_dma_map_page(),
>>>
>>> something like that to be squashed with current patch:
>>>
>>>
>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>>> index 9d5eca6d638a..bb984dc05deb 100644
>>> --- a/drivers/xen/grant-dma-ops.c
>>> +++ b/drivers/xen/grant-dma-ops.c
>>> @@ -169,7 +169,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>> device *dev, struct page *page,
>>>                                             unsigned long attrs)
>>>     {
>>>            struct xen_grant_dma_data *data;
>>> -       unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>> +       unsigned int i, n_pages = XEN_PFN_UP(xen_offset_in_page(offset)
>>> + size);
>>>            grant_ref_t grant;
>>>            dma_addr_t dma_handle;
>>>
>>> @@ -191,7 +191,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>> device *dev, struct page *page,
>>>                                    xen_page_to_gfn(page) + i, dir ==
>>> DMA_TO_DEVICE);
>>>            }
>>>
>>> -       dma_handle = grant_to_dma(grant) + offset;
>>> +       dma_handle = grant_to_dma(grant) + xen_offset_in_page(offset);
>>>
>>>            return dma_handle;
>>>     }
>>>
>>> Did I get your point right?
>>>
>>
>> I think it 's more complicated than that.
>> Let's say that the offset in page is > XEN_PAGE_SIZE, then the
>> calculation of the number of grants won't take into account the part
>> of the offset that is multiple of the XEN_PAGE_SIZE i.e it will
>> calculate only the strictly necessary number of grants.
>> But xen_grant_dma_map_page() grants access to the whole page because,
>> as it can be observed in the code snippet below, it does not take into
>> account the page offset.
>>
>> for (i = 0; i < n_pages; i++) {
>>    gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
>> xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
>> }
> 
> 
> Thanks, valid point. Agree it's indeed more complicated. I will comment
> on that later. I have just pushed another fix, it is not related to
> XEN_PAGE_SIZE directly, but also about page offset > PAGE_SIZE
> 

I got a little bit confused with the order that the patches will be 
applied :)
IIUC the above scenario cannot happen, i.e the offset to be > PAGE_SIZE, 
because this callback is used to map for transfer a portion of a single 
page.

> so touches the same code and should be prereq:
> 
> https://lore.kernel.org/all/20221007132736.2275574-1-olekstysh@gmail.com/
> 
> 
>>
>>>>
>>>>
>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>>>>         grant_ref_t grant;
>>>>>           if (WARN_ON(dir == DMA_NONE))
>>>>
>>>
>>> Thank you.
>>>
>>>
>>

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 16:03:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 16:03:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418170.662896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogpop-0007iV-GU; Fri, 07 Oct 2022 16:03:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418170.662896; Fri, 07 Oct 2022 16:03:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogpop-0007iO-Cj; Fri, 07 Oct 2022 16:03:23 +0000
Received: by outflank-mailman (input) for mailman id 418170;
 Fri, 07 Oct 2022 16:03:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vJJ6=2I=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1ogpon-0007iI-GH
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 16:03:21 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e86e2c6-4659-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 18:03:18 +0200 (CEST)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297Eqan7003431;
 Fri, 7 Oct 2022 16:01:47 GMT
Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta02.appoci.oracle.com [147.154.114.232])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k15up6ve5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 07 Oct 2022 16:01:46 +0000
Received: from pps.filterd
 (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5)
 with ESMTP id 297Db18L000583; Fri, 7 Oct 2022 16:01:44 GMT
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171])
 by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id
 3jxc06ydhy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 07 Oct 2022 16:01:44 +0000
Received: from CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22)
 by SN7PR10MB6643.namprd10.prod.outlook.com (2603:10b6:806:2ae::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct
 2022 16:01:42 +0000
Received: from CH0PR10MB5020.namprd10.prod.outlook.com
 ([fe80::1aa:5a18:ec58:7c2]) by CH0PR10MB5020.namprd10.prod.outlook.com
 ([fe80::1aa:5a18:ec58:7c2%3]) with mapi id 15.20.5676.036; Fri, 7 Oct 2022
 16:01:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e86e2c6-4659-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2022-7-12;
 bh=Jx1SSBrCclrfp4k6ArbkhpRZCSiSFaEy6PrCFHLF604=;
 b=g9n/Nk3ff3k02ypMZOC3W+NF2VRWbFJSbqnjAaqITDez0vst3+tosxNh0AfoseLeUrcb
 ZIppAEYFvhOQW8dNjUVgNfdwt40Q/rIZNZdMXZTzjv2YYXMY4KsXNdo5ZhK02FBSOHJm
 8JNfuwZZmjJPlo91qg+T2KK6vowgJgtDITj2KHlHLu6K2AAt8B2Z4CzZOKzrZhFJk9CY
 YyuZaBYrH9DmlWFawcgx5jE3qNOIvEbySW22wayHJtA6LWey65GOFbxVR6tcbejZRrEl
 H6OBGWywQ5yIQ3CWgjXc792Oa4criPT7KavNUxsGae/tUhawpVtG2Y1apo8i2YyXPFBo pQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cewVJtbWWdHTdd8AN1ERxsPRoLT6iDc85Lnpify1mUAlGRBRxp4Blyg8FPuG7x7m6z6+psiGifkUJazne8IHZXZOty5iWLwT1/fYKpBUQpBcLvw56FcjVXkM7XaDy2lC/JON4NxBCWcfHKJrhCkucgHlQKiE4qd9uhLbm+SRkT1INYYezUGIN6InVYQyorypvMUNAfQqBnhse75kFFoa5qkeh9p787jOo3bpM19qhDlGuE9Xt8WbNSg0SbPDpcbImITgOhwCqoFVwi67M0ZS9R0CGJDqM7aVL9gxd12Bnb2DLF10hTlmEZ6PK6KIG5Tw/Gf/GKBHuiivM3ufUsIEKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jx1SSBrCclrfp4k6ArbkhpRZCSiSFaEy6PrCFHLF604=;
 b=OPnv78Y/IQuIigX0mpt1jhs7LfpKuT5B1+MDuvP+794xhAkX09hZgQmwRSgPJISmxn2eDEdDDwsmAubVZepgQG3K9eO2smQe4TXBrlRIOokDLDjUjVzPSwPcbWuv5rQSAPzdRgGzJtb4r8w2Y2hcca0iYaoGWq4ZIN80hogSJK15Dr+jUXNUI2FvcihFDDNf2EligczpYFrtlfYrzFqnPF03RaEpBhLQDnG1QSGZtiz9337cZWo5swgg3dP95ZFjWjPpuSkV+J1hUJPWL2rQr7UAhddLF/clynOmmNNc/HkL+OG5qnKQg4MplDUVt4TvO2T3mb/q2sTgJCrRP/g+dQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jx1SSBrCclrfp4k6ArbkhpRZCSiSFaEy6PrCFHLF604=;
 b=PObYio3J5eLOj8WAVQy+coqVPyoaLJI+I/TRqFxwf0zOewDAWa3CueYxbNsC45f5gem1Ld9h0YtKqlOb2HD2NXQyetThE0SG7e9f04oCJwjLmYzEPEv1XKKx5GRci1K0cjUJAPR5V6qslQHQcMjefz+A7oWSSm7JK8ctDaZrU+Y=
Message-ID: <79358304-de2e-3025-f147-cba2f76f22d2@oracle.com>
Date: Fri, 7 Oct 2022 12:01:37 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH v2 3/3] xen/virtio: enable grant based virtio on x86
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Juergen Gross <jgross@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stefano Stabellini
 <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221007064143.10049-1-jgross@suse.com>
 <20221007064143.10049-4-jgross@suse.com>
 <67c9ec7d-a67d-ca28-4354-68e38aa27e13@epam.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <67c9ec7d-a67d-ca28-4354-68e38aa27e13@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA9PR10CA0010.namprd10.prod.outlook.com
 (2603:10b6:806:a7::15) To CH0PR10MB5020.namprd10.prod.outlook.com
 (2603:10b6:610:c0::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH0PR10MB5020:EE_|SN7PR10MB6643:EE_
X-MS-Office365-Filtering-Correlation-Id: 9b9f0bff-3f50-426c-35c5-08daa87d39bf
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	xbKhnVGKJi3Lz4raZmo7Npk9tU9joXdNNQv0lMAKEAiU28RZg1Rwm/MCc4XxVOpBLWUPUH+aNmgFA/rawRWGB6hxZjJ2cRgn5v+ZOi85TqNng8JKODACKOf5R1CaphCJxF8tNlh3iZgq9OXeTHJG0tMR0KM+CjY975EtZrWCSqWdikuSv8ac6TTv5BIrJKnbITnwTTjE1N1ob5l1J6ssLuiIoE5cyZEuE7pGEmCg0sOsQxf7uzMn2ttSfYJgwQGAQGgw+SIZEjpVwD0XhTY+Ekj+2q7r29mPAdejLwGf98LGLXnZs64pPbffgE9dp8dHXTCOiGz9KaZs/9MCUqYFo6iXPcst1WrWDdWnKYfAKJoDdSagMFv6rWQwK8bAhKRv9MSZmYgb5Ut29vj+WZfdPmODaoDZmFNB5v5taq8WrnYiN2ghwAWs5pFQNlW1+LdroAj3v34m17EoYyeB4LEO/6a5u3HQLABRCV6dG6ITxmC3WX1GnEuinfuFr/mFSigdbqsC+G6EeYGP62zouo0gpLhhHIrPvAxEB6aJycOm1OabQLCPej4YxJXh8lNEu5kbfu7quZKj2lsr6AE/Z5/GZQ3cveIS+OlK9dzEnMI494/tuNnxUIvas8WBx95NWW5J2RB5kXm11B4px97ahd11C8nSKwIY2GZT4bM+W3aZByhhVuPKlySLXUVTxLKnXMI2MWMuvUOW0k4t3+YrcBqwnLnD2HjF46GTBdXpXshTTqlFyGS5n9P5On3vLEduKMnvQx9pdZJDY0KpYF8bp1vhD539ppxKOHPVAyrJCMSiprE=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5020.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199015)(31686004)(36756003)(2906002)(31696002)(5660300002)(4744005)(44832011)(7416002)(186003)(83380400001)(4326008)(38100700002)(26005)(2616005)(6666004)(6512007)(66946007)(478600001)(6486002)(316002)(8676002)(53546011)(66476007)(86362001)(66556008)(6506007)(54906003)(41300700001)(8936002)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bW0rRFlRdXpZUi84SzB1ZU9QMGx1WlJSeXJMS2tUMmZ2ODIydFJqMnI1WGJL?=
 =?utf-8?B?d2pnMThaOXZYaUViMEE0ZWZJajB0SHp1cjltZVI4Nzg0L0FtMnZRbXNzeFlE?=
 =?utf-8?B?SFpVcDJZL2t1N3MyUHc5ME5LaWRmVmxOd1hRZnNEeWFtaUVtRmJsUVFKSGFM?=
 =?utf-8?B?MnlKNlJHS2JrREtmQW5jU2JFVml5VHBBZEtzYXVnRTV6NVRXZStCWnQ5NjEw?=
 =?utf-8?B?bzFWU3lPNEpuSWd6VFplbUVPaVo1YkhaVHd2Y0VJVUswNlpLK1VLVkxGS2d4?=
 =?utf-8?B?UFpMMURaNmVZQTNFekhXL2hsYlVLaWNjbHk2SEoxSjdXUUZ0MnN2NHhnZ2oy?=
 =?utf-8?B?UlNRRlU5UGthVWYrbWl1WnNsN3JQU3YzTVN3REZOQkk2eXZpRVp0UWVVNG80?=
 =?utf-8?B?YkNNdGpIU0pOM2ZkTFNRN2dJZEZYVFFvbzQrMFloRzBUUlVScTJzOGxFNTV0?=
 =?utf-8?B?RHdQdVBhdUxDMDhHQ1ZVMHZ4Vy9sbyt2NThuTE1BT3hsSE4wREI0T2pRRzl3?=
 =?utf-8?B?YTVXbGlPUENhT3hUa0JwQzRsOHhFc1VaSU5SeHNFYVRQL2NTT3ZIcCtrSkZh?=
 =?utf-8?B?RmxCb1U2UFJRQm1iQWxxWmpWRVc1RXB2QTB6eFBxSUMvUndSUndaeFgzSlVj?=
 =?utf-8?B?YmxNOVMreW5PZnlJZlI4WjIrd2ZDaU1FN29yY1VFcWdGbHdHUDcrQi9Bc1du?=
 =?utf-8?B?YWdYRzhZQWFxbzZCZjhhT3lFaU84eWFKdzBab2RQNENoOWg0U1FQaG1jSVFP?=
 =?utf-8?B?MHpCdUNqUVZqL0RUUDkweHQvcWJraW94UitaOExYUUxlRHdUdHBuUE9Oam1G?=
 =?utf-8?B?Ym5IdEU5bTNwT3Rtcks4NEl6TFF6cDlSbmhiWFEzTlcvVFVBdHhva2ZLQ0Jm?=
 =?utf-8?B?TjRZa0JFL1dzbGZVaWFZOUhQNXZ0SlRJajhwTWg0LzZNaFBWMTE0dktmMGpM?=
 =?utf-8?B?SkN3Q3J0eW43OEc5dnpweDA4Y0lRTThkNzlBQUNmM3BUVDFTZTdwbHNkSWVp?=
 =?utf-8?B?ZnBQY2poR1VDalBIQ3UvS3NYVWpHdWsramVhL1g3QWQrcnZXc2ZKZDRHRlNj?=
 =?utf-8?B?QXo2dnd4dnFtV0JyL2wvMkZ3eEpabXZ4RlM0VXROMFhMbGRjcEU1dEtLaHZT?=
 =?utf-8?B?NlZKelpaNjE2K2sxZEplZG9jMXRUZmVYZmlrajQvU0ZNNGhkZGszSk55eUx1?=
 =?utf-8?B?OEtndHdEZThXQWpUVkVNenBRbkFCQTkxSHJNNXk1ai84RzlXaFFFR1dkQUl2?=
 =?utf-8?B?SUljRjZhYmVQN1VibEVyREdnc1VabDhpSkJJQ1YrMVg2OXhmRmgrYWs1citH?=
 =?utf-8?B?MnVkb214VE9vY2wzNk9FR2g0NWN2YWdYTFFXanpRdzdGYVJZdGtkQVJGQitT?=
 =?utf-8?B?b0dnOEZyWmF0UVd1akhENngrd1Zya0tkWW9pVWZOcWNLeG10bGdEWit4OHlG?=
 =?utf-8?B?SHFGb280MUJneEJlQm9KVEpPME44RmttMWFGZENOUUNHbWpWbGRDWllIaXhq?=
 =?utf-8?B?dURjOXo0YnZwSFY3NmhZT2JrSm5SaldHUVp5QnBDUVlhL3phdC80RVB2M1pj?=
 =?utf-8?B?TWhCdm95SHNrM0R0MjVkRE43SUQ2T2dkSDBMWm95dml6T1lXVVkxOGpkS0FB?=
 =?utf-8?B?Y0NocTV4amxVNkJPMnFhL3czaXl5NWczTC84QnNYVCtxMUkvSTl0akgvTTRX?=
 =?utf-8?B?U0VxNlh0dlQySzJ4bitneUhRV3JsWnk2Qi9Gd2pDSTJpWjh2cncyYm4xT3J5?=
 =?utf-8?B?M0lUQWd3VHd5MkxUWWljOHkxVHdXK2U0Ykcva0lhc2RBTmZtSlJVWVIrVjl2?=
 =?utf-8?B?TEhwcE5LcG5WWWk0WldsY2hzZnhQSlEvNE1ROWw2cDlXa2w5Z3FyczViVmZK?=
 =?utf-8?B?OElsVE9vb0tXazdlcWNQVC8yZ1pOMkxha01qRHdEYkMyOUxjT21RNXk5bk01?=
 =?utf-8?B?TGRMaVhzMUkxWWg4Y3RMVWYyWnd5cDh1QjYyOFU3S0V0SWM3VWtVVzlFdHZO?=
 =?utf-8?B?Tmx2NitXMERYbjZ2ZzNRWHZkeHV4UFRlWXFxK0swTHlPUjR2M1UreTZkN3FK?=
 =?utf-8?B?cUxxeGdyZ0M4RzBKbm9UM2J4WFpvUTRCNVJPMzJMbFVzR3hldFo4d0FSMXZy?=
 =?utf-8?B?Ukhwcmh5YVlkdVNNZThXY2w3T3lGREVQSkpRczA1VnpJT3NyU1A4eEFiTjN2?=
 =?utf-8?B?Y3c9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b9f0bff-3f50-426c-35c5-08daa87d39bf
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5020.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 16:01:42.2994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AqprQsVq+F2/PmUTr9U14IKYRFFe0fg9Kd6uAvNvbABL9oOJ001Hep2xngBrEiM8BmNNQF+MvWEzCJow68sLbF+OjwYdwbKlfiVjmN2L1DU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6643
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 spamscore=0
 suspectscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070096
X-Proofpoint-GUID: 0pNU2b0sWDMhD8X8wifFbKp150WptGju
X-Proofpoint-ORIG-GUID: 0pNU2b0sWDMhD8X8wifFbKp150WptGju


On 10/7/22 10:00 AM, Oleksandr Tyshchenko wrote:
> On 07.10.22 09:41, Juergen Gross wrote:
>
> Hello Juergen
>
>> Use an x86-specific virtio_check_mem_acc_cb() for Xen in order to setup
>> the correct DMA ops.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> V2:
>> - add missing PV check in xen_virtio_mem_acc() (Oleksandr Tyshchenko)
>> - add xen_virtio_restricted_mem_acc() stub (Oleksandr Tyshchenko)
>
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> #
> common code



Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>




From xen-devel-bounces@lists.xenproject.org Fri Oct 07 16:16:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 16:16:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418177.662907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogq1j-00011x-R0; Fri, 07 Oct 2022 16:16:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418177.662907; Fri, 07 Oct 2022 16:16:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogq1j-00011q-OH; Fri, 07 Oct 2022 16:16:43 +0000
Received: by outflank-mailman (input) for mailman id 418177;
 Fri, 07 Oct 2022 16:16:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7mFU=2I=epam.com=prvs=2279168535=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ogq1h-00011k-Qp
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 16:16:42 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b328db2-465b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 18:16:38 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297E4i1l001623;
 Fri, 7 Oct 2022 16:16:27 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k2a45tth9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 16:16:27 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS8PR03MB7110.eurprd03.prod.outlook.com (2603:10a6:20b:23d::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 16:16:24 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 16:16:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b328db2-465b-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V51KPGWkhtZ+/B0twUdYse0yc+3+VGIPaFiAqP0wo5tbRZkgX0hCmcrq1gB6AEVhBVA+Hro4/ukkwQUakaMq7BbU7bKmUFTu/pEKGYthUV/JpbT4XW+Bnc56dcdxxkiR7oB4DIBDA+Ul5IgqOi5nkBO9jFZHpmFQ/Ci0rAE2lpLGClAiKlCn3FNP3KYA+vvoj8MxcIjEvBXbtTHpb4c0UvQhNAuiTKoRisLbikcNdQXT24lDSR8iL0p00anrjkG8co5Tf3Tch9Yb1ya/HAQ/NWP1eg01mUGmOFiMbRsblqurz5e9NlEFNUJlR6aPNxjckp4dy3/KSSgp1yNoian0gw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mtisMjhh27gKuY6Is/xcjm7Rk4z5HNyvqCiveWVp27k=;
 b=mxfb9KA7lpXowSz9Wnnl8AebD/P0o4M+3x6GO8ZzaDi3Jzm3uWXkLyKSGMT+/kcHRDopo9ESOw0+GnTq/tdt44+oWprIfydKoHTMfy38ObmTlwtaM1gfwe0pnKhCt50RjGQokm2wpePQSvLHRc6KFAt05SNw3iN7IU7iYWvTroXvDHiZeOehkHv8yOPBaB+1/q3OKcKkh76U3qZQ12MJSjfgzJ4xyU78LxHI/936hZzzB8UXe5uiy3vMsIlOFRUsT/ys+o2oNsuCCWaRwRqy2CA+R/lb2WcOBourppSwiXlMT1HNUZxMxaD43tdu4nTfGgYGw17R8Vbx/mJMkblhew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mtisMjhh27gKuY6Is/xcjm7Rk4z5HNyvqCiveWVp27k=;
 b=qUdG4H3mugzJIxNiOPBA5MgeF1dOoERY8VGs5go0eSbrqPykmWtUkodpr5LFmpi64SycVNsFa6fn2N/NK/LikJkq4xqDiLeERXoObjJqEsv56hmFw+lqYwnonyGg03yyiIfOM83K8YtevScXiKIPpbp3rI8c4UxS6AAiG5Su/S+2iLuSXeliiqV+tSnxzyeaf9lCQspEo74sbaOBIEFNSSgHSQ7JVyhemqgu+A+3R5LzQoiY4oHo2XgoGC+vk2XLRmn5oFx+gMjewa7NkKwLuNHMoYRu3tXfcqgQpaQYN4AcL5SZd1uZSUOyU7ILr35wSZW9UbuRY9i89xLpNsCznQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Topic: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Index: 
 AQHY2Xx9ME9woenUJk6IqJF2QACToq4Bp86AgAA2I4CAAKgkgIAAbJWAgAAjboCAAAc3gA==
Date: Fri, 7 Oct 2022 16:16:23 +0000
Message-ID: <ab4ef342-5982-6e0e-7859-eaab026d48a4@epam.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
 <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
 <816da52a-f646-c114-fa6d-9320152a0e79@epam.com>
 <677bc264-c507-3bed-6d51-0d010a0dd449@gmail.com>
In-Reply-To: <677bc264-c507-3bed-6d51-0d010a0dd449@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS8PR03MB7110:EE_
x-ms-office365-filtering-correlation-id: 43d4d72e-b68f-4020-7c13-08daa87f4760
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lrhfDmhIeKqBzVoV7kylYQGLbPC2scO7IHijsqavcdLHoumWUaSfozhm/2ZKEb8iV2yj4e7432bJc3JtqZwM6P7SZQZVTuO5IZl4sbkV8GSGAzBoOWq7kzzWRt19LBzT9NfqN82GIlMPmGyBpSCXxRj3/mrLN06JxQCwEhK+DNK/n4P0PGn+IEW0wzQgK50Vz5AYEIsDO1DlcVpVOTTD0Pr68a8tGaiEnDQP59eeYCzzrLB0r1yWQvS8Bn/hWEK189KiOpxxygVg0EdrL9kc8qCMR4X4ve60n4NM70rrQu/1llFD3fidR1g17iM8i4bbBmWAhuY2xzJKmn67AGbEWEm9HVjFyaegQYc/HFOYSMnb/Yxmzdv9VXHPn3n9Tugf4eJDYuujht3TUfBPSHMfc2lsha87dAFmjGyoaPzsqvZt7ijYvaj1511zrPlGvqKs4ycd9+60DxrFImfD4V0vlWbzUi+gmmeUUEtZqpoDHhfa0287TH67u08dDi919Q+Cxb27NjWRdeDdnvJNMfwS0FKbpRqE4FxvP9sZ75gEOPWxqC+TrnZvSVnFgXhxJ4pUhwRgknPpciYireN5L3zlG49YyyQZJDNrBv9gwxSXlfBCE1DcAtp+nD58tJZ6xXsq1drtCSSnmSGZgfjWkdjgQ2olRRuz3SGbESTPQR/bB2Ckxphl+j0iStUO16roMyseZ1kXonKnbJdmW0yWecTC36IwwVCV+2oP8qgmSb46HIYLJZ6HLRH0B3dQumRyzM/bMiNEgq/L6zt4bXaqfBG+9c8Da5wTTfBxWSxX9aNW2yhLEL0j0m5whH09rZ+EZxt2mlUIcFj3Gco/XBNhidhgLQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199015)(31686004)(53546011)(8936002)(8676002)(5660300002)(36756003)(2906002)(91956017)(41300700001)(4326008)(54906003)(110136005)(66476007)(86362001)(76116006)(66446008)(66946007)(66556008)(316002)(64756008)(31696002)(71200400001)(966005)(122000001)(6486002)(478600001)(6512007)(6506007)(26005)(55236004)(38070700005)(38100700002)(186003)(2616005)(83380400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZW02K0crTWpmUDlLVC9jUm5tYVNPMHdMa05vT0VFRTNsOXRRN3FIeFlxb0tt?=
 =?utf-8?B?dFRYVmYxVklJYnd3N2w0am5Kc3FUd2kzVmZsZHhFbFc4UVJWZWpmVkhlcnRz?=
 =?utf-8?B?ZTVlL25OYTA4WldHcXZ1QU9vK2tKQTdSdnAvZUd5T2hoVHlTV2VrK3ZITkVR?=
 =?utf-8?B?UEc5eHY2dWQ1TnFuYTNnSUQrRUZqVGt1VjhrSjRFdDlLeTN2Z1V1OG5xV3dQ?=
 =?utf-8?B?M09QUGVYcUg2Q0c2OTQ2YnQ2Z3oyMGRZdFB0NTBvSkVwcjl1Mlhob2dNUFVr?=
 =?utf-8?B?bUk3VlVxSXlXam9QUUEzemtkaGNUcmFrdDJITmlnU1ZUaXBHVCtiNTZwOW1v?=
 =?utf-8?B?bzRmVWcrYkcxL1UzNy8xNTQ0d0xBS08rKzVjL25QcXlhYzNUQUd5R1daZnRG?=
 =?utf-8?B?RTBhWlk5Q3ZEL3lIWVRvRTRuN2cxUVU0SFA5NmxWL3lOKzhycDJVTXU4bDgy?=
 =?utf-8?B?cVlkT3gvUzVTYUpOOGdONXVDUUthK2N6VEZuZkMra25NSWloSTBKRWUxTGF1?=
 =?utf-8?B?dThidmM4RHdXdUlDZmtwZDRDVFdFbnlKem4wM2syMzBBYWUrbzQ1alJnN2U1?=
 =?utf-8?B?ejNoaDhpSC8rd3lJN01WWDZ3UmFzUFhzakZQS1hMWE5mMlppcVFPSFRTcXVj?=
 =?utf-8?B?Ny9Cb0N0SHVVZitHVHc0S2JlUDhVMnVSelVwWXN0ek5hZlhsUWtZZGdsWW5P?=
 =?utf-8?B?bW1VV1VyOUZQM0ZzODVaSEFOSFB1MER0N045ZkJDYzFXYlF4a05EQ2FKbmVX?=
 =?utf-8?B?dUx2R2t2M255NHVWY1RyQ1N0TmlRNTU3ZDhmaWFmN0NEVW96N2dETmpBcWo1?=
 =?utf-8?B?bCtsNTFhQXVmTjYzMXBoSERaVnVCSmJ3enZYSExZVWc4clV0NDR5bUZ3V3Iy?=
 =?utf-8?B?Q3pSMDhrSVpBY2dzOG5JODNZRWZiV01RM0dFVWRSdTRPUml6VGlBZUE5aWJh?=
 =?utf-8?B?RDNxNzdPTkdDb21HQ3RNdEhqK3UvT1BrVDhJby9aN1R1R0dMZE0walBLUUtJ?=
 =?utf-8?B?cHlKTnFoNlNsRVJXaVFrTHhDcm9Sam9kRjV3QnEvc0pMRjNlcFFJcm5TMHJ2?=
 =?utf-8?B?d0dDRER6WGE4VEh0OUlhUTdLYUR2ZUF1MXRmN0QzK1VnaHJSZ3Mvdkg0Ykdk?=
 =?utf-8?B?NVlRS1R2aWlPWUc3aFlpdlRqb0thYWJLVTNVYmE5L0NHQVpzK0FRcVE0TEtH?=
 =?utf-8?B?c1ZrdDV6cFlaendmWHhZSVFpN0lyczB3encyaFhxQkhVeWs1VTJOR09UVm1T?=
 =?utf-8?B?Y3MxREdoaHh4dndFY2lXYVAzRm9WVHA3WHJnQXhvYlMrRkYrbjlGTmhJTnRZ?=
 =?utf-8?B?b2ZoR0dtelB5Zk5NeVNXbFA0OFVKWENvRjVZUTFGTHRsTjdaNldLWllxZ0VP?=
 =?utf-8?B?UHBxUG5MYmRaSVYyWlhxVVVFMGZmeGY3dzZFNzRQd0lmNkJ1MTFhUUhtZkxl?=
 =?utf-8?B?RjdBdEdQa2NndHFlYzgzWGZkMGFIWFFpTzF6b05TT1RtVXMydUFUVjl6Y1JO?=
 =?utf-8?B?bFp3WkdvUmpxM1BGWmZBMWVBYWhxRjc3dFNOWkpPUXFOT251KzlmcGZkSFdD?=
 =?utf-8?B?eDVoa00zUlJUNkZpM3prQ2JENmp3MVE5aEtORTdRdUd6NFo5MVhhMHhxL1Z0?=
 =?utf-8?B?eS9XN3UxK2NtY1M5L3MvM21YZ3NuNENFQjVPd0k5RU54L2hSaGhxd1BqWUZ0?=
 =?utf-8?B?RlVORjRUcHhRL0lobDFzQU5MT20yOUh2ZnpSdjNBdy80SW1hTnVBMU85N1E5?=
 =?utf-8?B?Nms0Y3ovdzBLY0lpSkxhNi9Xd0FqUTdIVWRISjRpWGlhZzZjQVFhWVpWUnRU?=
 =?utf-8?B?dHp3NU5YZmpZUGRSYTdabDRpd2F1Q1IwZlZKVnU0anVONDRnZUcyeTFGa3ps?=
 =?utf-8?B?YzR0QUc1NFBZeXYxQkxFRXRWc0pXVmVOajFKeXlEVVkvR2VHaXgwMEV2eFVL?=
 =?utf-8?B?M0N1aXJDL1lEOFBVNGgzRm9tWTRzblgrcFU4VmtySURRM3BwWlRIa3ZIa2hI?=
 =?utf-8?B?cWF3NnZva0RjYnV1czlvbURtZG1XSXBOUk0ycmFMbFpPTWoxUTBMZ3JuUlNs?=
 =?utf-8?B?Q204MVk5SXJXY2xSRGdUUGxKRFd2YVQ2Y3RMSU1wVThPdnhrTk5TakNqNEdw?=
 =?utf-8?B?a0kxVXNXclBiZWR2bDluRHFpWHJYQkhvU2dFa0JjK0lUaWhJOFQyeEQzVXdG?=
 =?utf-8?Q?3chsyMoiSum0lioIo6R8g2o=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A6269777069F0B45BA54312DC2F1F010@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43d4d72e-b68f-4020-7c13-08daa87f4760
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 16:16:23.7696
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wNb8fXGXwaCvsp54ddX0Fi2b+V+QQGKUgq5yAgG4hlcvhqz00z05uOXGTwfmHD1Pg4xIy+nTcCwQACXwFDUCDsvSxajYVaDMLZJsw3QnGeA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7110
X-Proofpoint-GUID: 4fHGvnIvjf-5tEh_Dl5Wq_hHcWLDZoax
X-Proofpoint-ORIG-GUID: 4fHGvnIvjf-5tEh_Dl5Wq_hHcWLDZoax
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 impostorscore=0
 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070097

DQpPbiAwNy4xMC4yMiAxODo1MCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KDQpIZWxsbyBY
ZW5pYQ0KDQo+DQo+IE9uIDEwLzcvMjIgMTY6NDMsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3Rl
Og0KPj4NCj4+IE9uIDA3LjEwLjIyIDEwOjE1LCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPj4+
DQo+Pj4gT24gMTAvNy8yMiAwMDoxMywgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4N
Cj4+PiBIaSBPbGVrc2FuZHINCj4+DQo+Pg0KPj4gSGVsbG8gWGVuaWENCj4+DQo+Pg0KPj4+DQo+
Pj4+DQo+Pj4+IE9uIDA2LjEwLjIyIDIwOjU5LCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPj4+
Pg0KPj4+PiBIZWxsbyBYZW5pYQ0KPj4+Pg0KPj4+Pj4NCj4+Pj4+IE9uIDEwLzYvMjIgMTU6MDks
IE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IEZyb206IE9sZWtzYW5kciBUeXNo
Y2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+Pg0KPj4+Pj4+IEFs
dGhvdWdoIFhFTl9QQUdFX1NJWkUgaXMgZXF1YWwgdG8gUEFHRV9TSVpFICg0S0IpIGZvciBub3cs
IGl0IHdvdWxkDQo+Pj4+Pj4gYmUgbW9yZSBjb3JyZWN0IHRvIHVzZSBYZW4gc3BlY2lmaWMgI2Rl
ZmluZS1zIGFzIFhFTl9QQUdFX1NJWkUgY2FuDQo+Pj4+Pj4gYmUgY2hhbmdlZCBhdCBzb21lIHBv
aW50IGluIHRoZSBmdXR1cmUuDQo+Pj4+Pj4NCj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+Pj4gLS0t
DQo+Pj4+Pj4gQ2M6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+Pj4+PiBDYzog
WGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29tPg0KPj4+Pj4+DQo+Pj4+Pj4g
QXMgaXQgd2FzIHByb3Bvc2VkIGF0Og0KPj4+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMv
X19odHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDUxNzQ4MjMuMTgwMDc2
MS0xLW9sZWtzdHlzaEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSF6SHQteFpfN3RaY19F
TTZ6dmEyMUVfWWd3SWlFZWltRldmc0pJcFB3QXUtVEJjbnpRaFhIcWxLem1YbXdJY0k2dUl4X2Fy
SE5aaWFaZUh0XzQyOF84cC1EeU1wZCQgDQo+Pj4+Pj4NCj4+Pj4+Pg0KPj4+Pj4+IFtsb3JlWy5d
a2VybmVsWy5db3JnXQ0KPj4+Pj4+DQo+Pj4+Pj4gU2hvdWxkIGdvIGluIG9ubHkgYWZ0ZXIgdGhh
dCBzZXJpZXMuDQo+Pj4+Pj4gLS0tDQo+Pj4+Pj4gwqDCoMKgIGRyaXZlcnMveGVuL2dyYW50LWRt
YS1vcHMuYyB8IDIwICsrKysrKysrKystLS0tLS0tLS0tDQo+Pj4+Pj4gwqDCoMKgIDEgZmlsZSBj
aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4+Pj4+Pg0KPj4+Pj4+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgDQo+Pj4+Pj4gYi9kcml2
ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4+PiBpbmRleCBjNjZmNTZkMjQwMTMuLjUzOTJm
ZGMyNWRjYSAxMDA2NDQNCj4+Pj4+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMN
Cj4+Pj4+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4+PiBAQCAtMzEs
MTIgKzMxLDEyIEBAIHN0YXRpYyANCj4+Pj4+PiBERUZJTkVfWEFSUkFZX0ZMQUdTKHhlbl9ncmFu
dF9kbWFfZGV2aWNlcywNCj4+Pj4+PiBYQV9GTEFHU19MT0NLX0lSUSk7DQo+Pj4+Pj4gwqDCoMKg
IMKgIHN0YXRpYyBpbmxpbmUgZG1hX2FkZHJfdCBncmFudF90b19kbWEoZ3JhbnRfcmVmX3QgZ3Jh
bnQpDQo+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+PiAtwqDCoMKgIHJldHVybiBYRU5fR1JBTlRfRE1B
X0FERFJfT0ZGIHwgKChkbWFfYWRkcl90KWdyYW50IDw8DQo+Pj4+Pj4gUEFHRV9TSElGVCk7DQo+
Pj4+Pj4gK8KgwqDCoCByZXR1cm4gWEVOX0dSQU5UX0RNQV9BRERSX09GRiB8ICgoZG1hX2FkZHJf
dClncmFudCA8PA0KPj4+Pj4+IFhFTl9QQUdFX1NISUZUKTsNCj4+Pj4+PiDCoMKgwqAgfQ0KPj4+
Pj4NCj4+Pj4+IFdpdGggdGhpcyBjaGFuZ2UsIGNhbiB0aGUgb2Zmc2V0IGFkZGVkIHRvIHRoZSBk
bWEgaGFuZGxlLCANCj4+Pj4+IGdlbmVyYXRlZCBieQ0KPj4+Pj4gZ3JhbnRfdG9fZG1hKCksIGJl
IHRoZSBvZmZzZXQgaW4gdGhlIHBhZ2U/IENvdWxkbid0IGl0IGNvcnJ1cHQgdGhlDQo+Pj4+PiBn
cmFudCByZWY/DQo+Pj4+DQo+Pj4+DQo+Pj4+IEdvb2QgcG9pbnQsIGluZGVlZCwgSSB0aGluayBp
dCBjb3VsZCBjb3JydXB0IGlmIGd1ZXN0IHVzZXMgYSBkaWZmZXJlbnQNCj4+Pj4gdGhhbiBYZW4g
cGFnZSBncmFudWxhcml0eSAoaS5lIDY0S0IpLg0KPj4+Pg0KPj4+Pg0KPj4+Pj4NCj4+Pj4+PiDC
oMKgwqAgwqAgc3RhdGljIGlubGluZSBncmFudF9yZWZfdCBkbWFfdG9fZ3JhbnQoZG1hX2FkZHJf
dCBkbWEpDQo+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+PiAtwqDCoMKgIHJldHVybiAoZ3JhbnRfcmVm
X3QpKChkbWEgJiB+WEVOX0dSQU5UX0RNQV9BRERSX09GRikgPj4NCj4+Pj4+PiBQQUdFX1NISUZU
KTsNCj4+Pj4+PiArwqDCoMKgIHJldHVybiAoZ3JhbnRfcmVmX3QpKChkbWEgJiB+WEVOX0dSQU5U
X0RNQV9BRERSX09GRikgPj4NCj4+Pj4+PiBYRU5fUEFHRV9TSElGVCk7DQo+Pj4+Pj4gwqDCoMKg
IH0NCj4+Pj4+PiDCoMKgwqAgwqAgc3RhdGljIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgDQo+
Pj4+Pj4gKmZpbmRfeGVuX2dyYW50X2RtYV9kYXRhKHN0cnVjdA0KPj4+Pj4+IGRldmljZSAqZGV2
KQ0KPj4+Pj4+IEBAIC03OSw3ICs3OSw3IEBAIHN0YXRpYyB2b2lkICp4ZW5fZ3JhbnRfZG1hX2Fs
bG9jKHN0cnVjdCBkZXZpY2UNCj4+Pj4+PiAqZGV2LCBzaXplX3Qgc2l6ZSwNCj4+Pj4+PiDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgYXR0cnMp
DQo+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50
X2RtYV9kYXRhICpkYXRhOw0KPj4+Pj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMg
PSBQRk5fVVAoc2l6ZSk7DQo+Pj4+Pj4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9
IFhFTl9QRk5fVVAoc2l6ZSk7DQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBw
Zm47DQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgZ3JhbnRfcmVmX3QgZ3JhbnQ7DQo+Pj4+Pj4gwqDC
oMKgwqDCoMKgwqAgdm9pZCAqcmV0Ow0KPj4+Pj4+IEBAIC05MSwxNCArOTEsMTQgQEAgc3RhdGlj
IHZvaWQgKnhlbl9ncmFudF9kbWFfYWxsb2Moc3RydWN0IGRldmljZQ0KPj4+Pj4+ICpkZXYsIHNp
emVfdCBzaXplLA0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgIGlmICh1bmxpa2VseShkYXRhLT5icm9r
ZW4pKQ0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5VTEw7DQo+Pj4+Pj4g
wqDCoMKgIC3CoMKgwqAgcmV0ID0gYWxsb2NfcGFnZXNfZXhhY3Qobl9wYWdlcyAqIFBBR0VfU0la
RSwgZ2ZwKTsNCj4+Pj4+PiArwqDCoMKgIHJldCA9IGFsbG9jX3BhZ2VzX2V4YWN0KG5fcGFnZXMg
KiBYRU5fUEFHRV9TSVpFLCBnZnApOw0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgIGlmICghcmV0KQ0K
Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5VTEw7DQo+Pj4+Pj4gwqDCoMKg
IMKgwqDCoMKgwqAgcGZuID0gdmlydF90b19wZm4ocmV0KTsNCj4+Pj4+PiDCoMKgwqAgwqDCoMKg
wqDCoCBpZiAoZ250dGFiX2FsbG9jX2dyYW50X3JlZmVyZW5jZV9zZXEobl9wYWdlcywgJmdyYW50
KSkgew0KPj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHJldCwgbl9wYWdl
cyAqIFBBR0VfU0laRSk7DQo+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGZyZWVfcGFnZXNfZXhhY3Qo
cmV0LCBuX3BhZ2VzICogWEVOX1BBR0VfU0laRSk7DQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCByZXR1cm4gTlVMTDsNCj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCB9DQo+Pj4+Pj4gwqDCoMKg
IEBAIC0xMTYsNyArMTE2LDcgQEAgc3RhdGljIHZvaWQgeGVuX2dyYW50X2RtYV9mcmVlKHN0cnVj
dCBkZXZpY2UNCj4+Pj4+PiAqZGV2LCBzaXplX3Qgc2l6ZSwgdm9pZCAqdmFkZHIsDQo+Pj4+Pj4g
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZG1hX2FkZHJfdCBk
bWFfaGFuZGxlLCB1bnNpZ25lZCBsb25nIGF0dHJzKQ0KPj4+Pj4+IMKgwqDCoCB7DQo+Pj4+Pj4g
wqDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YTsNCj4+Pj4+PiAt
wqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gUEZOX1VQKHNpemUpOw0KPj4+Pj4+ICvC
oMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQKHNpemUpOw0KPj4+Pj4+
IMKgwqDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdyYW50Ow0KPj4+Pj4+IMKgwqDCoCDCoMKgwqDC
oMKgIGRhdGEgPSBmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShkZXYpOw0KPj4+Pj4+IEBAIC0xMzgs
NyArMTM4LDcgQEAgc3RhdGljIHZvaWQgeGVuX2dyYW50X2RtYV9mcmVlKHN0cnVjdCBkZXZpY2UN
Cj4+Pj4+PiAqZGV2LCBzaXplX3Qgc2l6ZSwgdm9pZCAqdmFkZHIsDQo+Pj4+Pj4gwqDCoMKgIMKg
wqDCoMKgwqAgZ250dGFiX2ZyZWVfZ3JhbnRfcmVmZXJlbmNlX3NlcShncmFudCwgbl9wYWdlcyk7
DQo+Pj4+Pj4gwqDCoMKgIC3CoMKgwqAgZnJlZV9wYWdlc19leGFjdCh2YWRkciwgbl9wYWdlcyAq
IFBBR0VfU0laRSk7DQo+Pj4+Pj4gK8KgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHZhZGRyLCBuX3Bh
Z2VzICogWEVOX1BBR0VfU0laRSk7DQo+Pj4+Pj4gwqDCoMKgIH0NCj4+Pj4+PiDCoMKgwqAgwqAg
c3RhdGljIHN0cnVjdCBwYWdlICp4ZW5fZ3JhbnRfZG1hX2FsbG9jX3BhZ2VzKHN0cnVjdCBkZXZp
Y2UgDQo+Pj4+Pj4gKmRldiwNCj4+Pj4+PiBzaXplX3Qgc2l6ZSwNCj4+Pj4+PiBAQCAtMTY4LDcg
KzE2OCw3IEBAIHN0YXRpYyBkbWFfYWRkcl90IHhlbl9ncmFudF9kbWFfbWFwX3BhZ2Uoc3RydWN0
DQo+Pj4+Pj4gZGV2aWNlICpkZXYsIHN0cnVjdCBwYWdlICpwYWdlLA0KPj4+Pj4+IMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGF0
dHJzKQ0KPj4+Pj4+IMKgwqDCoCB7DQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9n
cmFudF9kbWFfZGF0YSAqZGF0YTsNCj4+Pj4+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3Bh
Z2VzID0gUEZOX1VQKG9mZnNldCArIHNpemUpOw0KPj4+Pj4+ICvCoMKgwqAgdW5zaWduZWQgaW50
IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQKG9mZnNldCArIHNpemUpOw0KPj4+Pj4NCj4+Pj4+IFRo
ZSBvZmZzZXQsIGhlcmUsIHJlZmVycyB0byB0aGUgb2Zmc2V0IGluIHRoZSBwYWdlIC4uLg0KPj4+
Pj4NCj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBncmFudF9yZWZfdCBncmFudDsNCj4+Pj4+PiDCoMKg
wqDCoMKgwqDCoCBkbWFfYWRkcl90IGRtYV9oYW5kbGU7DQo+Pj4+Pj4gwqDCoMKgIEBAIC0yMDAs
OCArMjAwLDggQEAgc3RhdGljIHZvaWQgeGVuX2dyYW50X2RtYV91bm1hcF9wYWdlKHN0cnVjdA0K
Pj4+Pj4+IGRldmljZSAqZGV2LCBkbWFfYWRkcl90IGRtYV9oYW5kbGUsDQo+Pj4+Pj4gwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcg
YXR0cnMpDQo+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVu
X2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4+Pj4+IC3CoMKgwqAgdW5zaWduZWQgbG9uZyBvZmZz
ZXQgPSBkbWFfaGFuZGxlICYgKFBBR0VfU0laRSAtIDEpOw0KPj4+Pj4+IC3CoMKgwqAgdW5zaWdu
ZWQgaW50IGksIG5fcGFnZXMgPSBQRk5fVVAob2Zmc2V0ICsgc2l6ZSk7DQo+Pj4+Pj4gK8KgwqDC
oCB1bnNpZ25lZCBsb25nIG9mZnNldCA9IGRtYV9oYW5kbGUgJiB+WEVOX1BBR0VfTUFTSzsNCj4+
Pj4+DQo+Pj4+PiAuLi4gd2hpbGUsIGhlcmUsIGl0IHJlZmVycyB0byB0aGUgb2Zmc2V0IGluIHRo
ZSBncmFudC4NCj4+Pj4+IFNvLCB0aGUgY2FsY3VsYXRlZCBudW1iZXIgb2YgZ3JhbnRzIG1heSBk
aWZmZXIuDQo+Pj4+DQo+Pj4+IEdvb2QgcG9pbnQsIEkgdGhpbmsgeW91IGFyZSByaWdodCwgc28g
d2UgbmVlZCB0byBhZGRpdGlvbmFsbHkgdXNlDQo+Pj4+IHhlbl9vZmZzZXRfaW5fcGFnZSgpIG1h
Y3JvIGluIHhlbl9ncmFudF9kbWFfbWFwX3BhZ2UoKSwNCj4+Pj4NCj4+Pj4gc29tZXRoaW5nIGxp
a2UgdGhhdCB0byBiZSBzcXVhc2hlZCB3aXRoIGN1cnJlbnQgcGF0Y2g6DQo+Pj4+DQo+Pj4+DQo+
Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hl
bi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4gaW5kZXggOWQ1ZWNhNmQ2MzhhLi5iYjk4NGRjMDVkZWIg
MTAwNjQ0DQo+Pj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+PiArKysg
Yi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4gQEAgLTE2OSw3ICsxNjksNyBAQCBz
dGF0aWMgZG1hX2FkZHJfdCB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKHN0cnVjdA0KPj4+PiBkZXZp
Y2UgKmRldiwgc3RydWN0IHBhZ2UgKnBhZ2UsDQo+Pj4+IMKgwqAgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgdW5zaWduZWQgbG9uZyBhdHRycykNCj4+Pj4gwqDCoCDCoHsNCj4+Pj4gwqDCoCDCoMKg
wqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4+PiAtwqDCoMKg
wqDCoMKgIHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gWEVOX1BGTl9VUChvZmZzZXQgKyBzaXpl
KTsNCj4+Pj4gK8KgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IA0KPj4+PiBY
RU5fUEZOX1VQKHhlbl9vZmZzZXRfaW5fcGFnZShvZmZzZXQpDQo+Pj4+ICsgc2l6ZSk7DQo+Pj4+
IMKgwqAgwqDCoMKgwqDCoMKgwqAgZ3JhbnRfcmVmX3QgZ3JhbnQ7DQo+Pj4+IMKgwqAgwqDCoMKg
wqDCoMKgwqAgZG1hX2FkZHJfdCBkbWFfaGFuZGxlOw0KPj4+Pg0KPj4+PiBAQCAtMTkxLDcgKzE5
MSw3IEBAIHN0YXRpYyBkbWFfYWRkcl90IHhlbl9ncmFudF9kbWFfbWFwX3BhZ2Uoc3RydWN0DQo+
Pj4+IGRldmljZSAqZGV2LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCj4+Pj4gwqDCoCDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5f
cGFnZV90b19nZm4ocGFnZSkgKyBpLCBkaXIgPT0NCj4+Pj4gRE1BX1RPX0RFVklDRSk7DQo+Pj4+
IMKgwqAgwqDCoMKgwqDCoMKgwqAgfQ0KPj4+Pg0KPj4+PiAtwqDCoMKgwqDCoMKgIGRtYV9oYW5k
bGUgPSBncmFudF90b19kbWEoZ3JhbnQpICsgb2Zmc2V0Ow0KPj4+PiArwqDCoMKgwqDCoMKgIGRt
YV9oYW5kbGUgPSBncmFudF90b19kbWEoZ3JhbnQpICsgeGVuX29mZnNldF9pbl9wYWdlKG9mZnNl
dCk7DQo+Pj4+DQo+Pj4+IMKgwqAgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGRtYV9oYW5kbGU7DQo+
Pj4+IMKgwqAgwqB9DQo+Pj4+DQo+Pj4+IERpZCBJIGdldCB5b3VyIHBvaW50IHJpZ2h0Pw0KPj4+
Pg0KPj4+DQo+Pj4gSSB0aGluayBpdCAncyBtb3JlIGNvbXBsaWNhdGVkIHRoYW4gdGhhdC4NCj4+
PiBMZXQncyBzYXkgdGhhdCB0aGUgb2Zmc2V0IGluIHBhZ2UgaXMgPiBYRU5fUEFHRV9TSVpFLCB0
aGVuIHRoZQ0KPj4+IGNhbGN1bGF0aW9uIG9mIHRoZSBudW1iZXIgb2YgZ3JhbnRzIHdvbid0IHRh
a2UgaW50byBhY2NvdW50IHRoZSBwYXJ0DQo+Pj4gb2YgdGhlIG9mZnNldCB0aGF0IGlzIG11bHRp
cGxlIG9mIHRoZSBYRU5fUEFHRV9TSVpFIGkuZSBpdCB3aWxsDQo+Pj4gY2FsY3VsYXRlIG9ubHkg
dGhlIHN0cmljdGx5IG5lY2Vzc2FyeSBudW1iZXIgb2YgZ3JhbnRzLg0KPj4+IEJ1dCB4ZW5fZ3Jh
bnRfZG1hX21hcF9wYWdlKCkgZ3JhbnRzIGFjY2VzcyB0byB0aGUgd2hvbGUgcGFnZSBiZWNhdXNl
LA0KPj4+IGFzIGl0IGNhbiBiZSBvYnNlcnZlZCBpbiB0aGUgY29kZSBzbmlwcGV0IGJlbG93LCBp
dCBkb2VzIG5vdCB0YWtlIGludG8NCj4+PiBhY2NvdW50IHRoZSBwYWdlIG9mZnNldC4NCj4+Pg0K
Pj4+IGZvciAoaSA9IDA7IGkgPCBuX3BhZ2VzOyBpKyspIHsNCj4+PiDCoMKgIGdudHRhYl9ncmFu
dF9mb3JlaWduX2FjY2Vzc19yZWYoZ3JhbnQgKyBpLCBkYXRhLT5iYWNrZW5kX2RvbWlkLA0KPj4+
IHhlbl9wYWdlX3RvX2dmbihwYWdlKSArIGksIGRpciA9PSBETUFfVE9fREVWSUNFKTsNCj4+PiB9
DQo+Pg0KPj4NCj4+IFRoYW5rcywgdmFsaWQgcG9pbnQuIEFncmVlIGl0J3MgaW5kZWVkIG1vcmUg
Y29tcGxpY2F0ZWQuIEkgd2lsbCBjb21tZW50DQo+PiBvbiB0aGF0IGxhdGVyLiBJIGhhdmUganVz
dCBwdXNoZWQgYW5vdGhlciBmaXgsIGl0IGlzIG5vdCByZWxhdGVkIHRvDQo+PiBYRU5fUEFHRV9T
SVpFIGRpcmVjdGx5LCBidXQgYWxzbyBhYm91dCBwYWdlIG9mZnNldCA+IFBBR0VfU0laRQ0KPj4N
Cj4NCj4gSSBnb3QgYSBsaXR0bGUgYml0IGNvbmZ1c2VkIHdpdGggdGhlIG9yZGVyIHRoYXQgdGhl
IHBhdGNoZXMgd2lsbCBiZSANCj4gYXBwbGllZCA6KQ0KDQpUaGlzIHNlcmllcyBzaG91bGQgZ28g
aW4gdGhlIGZpcnN0IFsxXToNCg0KQ3VycmVudCBwYXRjaCBkZXBlbmRzIG9uIGl0IGFuZCBuZXcg
cGF0Y2ggWzJdIGFsc28gZGVwZW5kcyBvbiBpdC4gSSANCnRoaW5rIChidXQgbWlnaHQgbWlzdGFr
ZSkgdGhhdCBjdXJyZW50IHBhdGNoIHdlIG5lZWQvd2FudCB0byBwb3N0cG9uZSANCihiZWNhdXNl
IGl0IGRvZXNuJ3QgZml4L2ltcHJvdmUgc29tZXRoaW5nIGltbWVkaWF0ZWx5LCBidXQgbW9yZSBm
b3IgDQpmdXR1cmUgdXNlLWNhc2VzKSwNCg0KYnV0IHRoZSBuZXcgcGF0Y2ggaXMgYSBmaXggZm9y
IHRoZSByZWFsIHNpdHVhdGlvbi4gT25jZSB3ZSBkZWNpZGUgd2l0aCANCm5ldyBwYXRjaCBbMl0g
d2Ugd2lsbCBiZSBhYmxlIHRvIHJldHVybiB0byB0aGUgY3VycmVudCBwYXRjaCBhbmQgcmViYXNl
IGl0Lg0KDQoNClsxXSANCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIyMTAw
NTE3NDgyMy4xODAwNzYxLTEtb2xla3N0eXNoQGdtYWlsLmNvbS8NCg0KWzJdIA0KaHR0cHM6Ly9s
b3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIxMDA3MTMyNzM2LjIyNzU1NzQtMS1vbGVrc3R5
c2hAZ21haWwuY29tLw0KDQoNCg0KPiBJSVVDIHRoZSBhYm92ZSBzY2VuYXJpbyBjYW5ub3QgaGFw
cGVuLCBpLmUgdGhlIG9mZnNldCB0byBiZSA+IA0KPiBQQUdFX1NJWkUsIGJlY2F1c2UgdGhpcyBj
YWxsYmFjayBpcyB1c2VkIHRvIG1hcCBmb3IgdHJhbnNmZXIgYSBwb3J0aW9uIA0KPiBvZiBhIHNp
bmdsZSBwYWdlLg0KDQpJdCBoYXBwZW5zLiBJIGhhdmUgcmVjaGVja2VkIHRoYXQuIEFuZCBjYW4g
cHJvdmlkZSBzb21lIGRlYnVnIHByaW50cyBpZiANCm5lZWRlZC4NCg0KDQo+DQo+DQo+PiBzbyB0
b3VjaGVzIHRoZSBzYW1lIGNvZGUgYW5kIHNob3VsZCBiZSBwcmVyZXE6DQo+Pg0KPj4gaHR0cHM6
Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIyMTAw
NzEzMjczNi4yMjc1NTc0LTEtb2xla3N0eXNoQGdtYWlsLmNvbS9fXzshIUdGXzI5ZGJjUUlVQlBB
ITM2Q0o1UzVUNDdITWg5TnEtMFdWVVBTbG5IanZsVW9uLW9vRkdvd2J2R0E4QmRXU0NDOW5pRjBm
X2J0dml0ZTFHNkxJUnd5dzZYc1U2UEFuQ2pNeTkyS2lOa01HJCANCj4+IFtsb3JlWy5da2VybmVs
Wy5db3JnXQ0KPj4NCj4+DQo+Pj4NCj4+Pj4+DQo+Pj4+Pg0KPj4+Pj4+ICvCoMKgwqAgdW5zaWdu
ZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZOX1VQKG9mZnNldCArIHNpemUpOw0KPj4+Pj4+IMKg
wqDCoMKgwqDCoMKgIGdyYW50X3JlZl90IGdyYW50Ow0KPj4+Pj4+IMKgwqDCoCDCoMKgwqDCoMKg
IGlmIChXQVJOX09OKGRpciA9PSBETUFfTk9ORSkpDQo+Pj4+Pg0KPj4+Pg0KPj4+PiBUaGFuayB5
b3UuDQo+Pj4+DQo+Pj4+DQo+Pj4NCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hj
aGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 16:58:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 16:58:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418183.662917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogqfr-0005VG-Uj; Fri, 07 Oct 2022 16:58:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418183.662917; Fri, 07 Oct 2022 16:58:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogqfr-0005V9-SA; Fri, 07 Oct 2022 16:58:11 +0000
Received: by outflank-mailman (input) for mailman id 418183;
 Fri, 07 Oct 2022 16:58:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogqfq-0005Ux-9w; Fri, 07 Oct 2022 16:58:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogqfq-0006q2-6T; Fri, 07 Oct 2022 16:58:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogqfp-0007qK-Oa; Fri, 07 Oct 2022 16:58:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogqfp-0006Oa-OC; Fri, 07 Oct 2022 16:58:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Bvpdqnm1Mrw4Ff2KMOPhSe46ba1d+1zwJhWSEgfw0gM=; b=PguxoUlo2BwHwYdAVjeg5Tn+wE
	ytBMpFcW/KNV3tVZjlrzVaqJt3uY6eMtKeyTQstQrZRJ5xlEvz1mLmxOVHsf3XRmZ5QDA3wfvdo69
	q6Dk6+OKYGxXm9l+/JXgram0IyQScwjELJavt8Y5hwVaT7k4qdVGcIoynn3GC9e6a9PM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173457-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173457: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=66a5633aa038f4abb4455463755974febac69034
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 16:58:09 +0000

flight 173457 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173457/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  66a5633aa038f4abb4455463755974febac69034

Last test of basis   173428  2022-10-05 09:00:30 Z    2 days
Testing same since   173457  2022-10-07 14:03:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   66a5633aa0..9029bc265c  9029bc265cdf2bd63376dde9fdd91db4ce9c0586 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 17:24:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 17:24:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418191.662929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogr5T-0000Uk-4G; Fri, 07 Oct 2022 17:24:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418191.662929; Fri, 07 Oct 2022 17:24:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogr5T-0000Ud-0r; Fri, 07 Oct 2022 17:24:39 +0000
Received: by outflank-mailman (input) for mailman id 418191;
 Fri, 07 Oct 2022 17:24:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogr5R-0000UT-CI; Fri, 07 Oct 2022 17:24:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogr5R-0007LQ-1b; Fri, 07 Oct 2022 17:24:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogr5Q-00007l-H7; Fri, 07 Oct 2022 17:24:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogr5Q-0004bf-Gi; Fri, 07 Oct 2022 17:24:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NXEIpZI4HNhH+rHzpNqAvzA9jXGiOONgKSn328h5pqE=; b=ABy0NHwm1oRQF5qPPJuHFGNF6d
	340cP+62qJfOMFHHy3qMuJ0MZSQFCg9iD3/EbY9A94/+Pgu2Qj4RrB3r53I6utDMMhUKfil6We+n1
	yjS15Y3MoQFVChJX9rRF5KxlA2901pnZVREIzwPr2lOVbNkMqKSY/LeY3leudMkcWqhc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173454-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173454: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f28b7414ab715e6069e72a7bbe2f1354b2524beb
X-Osstest-Versions-That:
    linux=6215647d9699cb8f1bf7333ec849242c4a9cf9a6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 17:24:36 +0000

flight 173454 linux-5.4 real [real]
flight 173458 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173454/
http://logs.test-lab.xenproject.org/osstest/logs/173458/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail pass in 173458-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 173353
 test-armhf-armhf-xl-credit2  18 guest-start/debian.repeat    fail  like 173353
 test-armhf-armhf-xl-credit1  18 guest-start/debian.repeat    fail  like 173353
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173353
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173353
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173353
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173353
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173353
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173353
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173353
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                f28b7414ab715e6069e72a7bbe2f1354b2524beb
baseline version:
 linux                6215647d9699cb8f1bf7333ec849242c4a9cf9a6

Last test of basis   173353  2022-09-28 09:15:02 Z    9 days
Testing same since   173427  2022-10-05 08:44:11 Z    2 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
  Alan Stern <stern@rowland.harvard.edu>
  Alistair Popple <apopple@nvidia.com>
  Andrew Morton <akpm@linux-foundation.org>
  Arnd Bergmann <arnd@arndb.de>
  Bjørn Mork <bjorn@mork.no>
  Brian Norris <briannorris@chromium.org>
  Cai Huoqing <caihuoqing@baidu.com>
  Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
  ChenXiaoSong <chenxiaosong2@huawei.com>
  Christoph Hellwig <hch@lst.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Hildenbrand <david@redhat.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Fabio Estevam <festevam@denx.de>
  Faiz Abbas <faiz_abbas@ti.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Han Xu <han.xu@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heiko Stuebner <heiko@sntech.de>
  Hongling Zeng <zenghongling@kylinos.cn>
  Jakub Kicinski <kuba@kernel.org>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Michael Kelley <mikelley@microsoft.com>
  Michal Hocko <mhocko@suse.com>
  Minchan Kim <minchan@kernel.org>
  Niklas Cassel <niklas.cassel@wdc.com>
  Paolo Abeni <pabeni@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Xu <peterx@redhat.com>
  Rafał Miłecki <rafal@milecki.pl>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sergei Antonov <saproj@gmail.com>
  Stephen Boyd <sboyd@kernel.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Tony Lindgren <tony@atomide.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Wang Yufen <wangyufen@huawei.com>
  Yang Shi <shy828301@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  YuTong Chang <mtwget@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   6215647d9699..f28b7414ab71  f28b7414ab715e6069e72a7bbe2f1354b2524beb -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 17:32:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 17:32:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418201.662940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogrCg-00025F-0N; Fri, 07 Oct 2022 17:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418201.662940; Fri, 07 Oct 2022 17:32:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogrCf-000258-Tr; Fri, 07 Oct 2022 17:32:05 +0000
Received: by outflank-mailman (input) for mailman id 418201;
 Fri, 07 Oct 2022 17:32:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bDCD=2I=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1ogrCd-000252-UA
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 17:32:04 +0000
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f31dbd21-4665-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 19:32:01 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 044565C00D5;
 Fri,  7 Oct 2022 13:32:00 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Fri, 07 Oct 2022 13:32:00 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 7 Oct 2022 13:31:58 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f31dbd21-4665-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1665163919; x=
	1665250319; bh=UFRh/83Bkh5gjHTT0p6dZH9JJ3M4HOjeJ6B4cYvrhrU=; b=x
	JRXamX7rJ3U167b4EqfJtDn9oSxz6iIfwCjun7OK2y6b+Jxqe/+13ET8/8Qju8En
	QX25W6qvCxmVMca695HWptF03Hr90jAvqFydH5gz/uOX57KGsctTEoeY0gbi2waZ
	jcMxLrtVjcMaZICZl2qYsCRG2EOmUg+K11jCcHz6R7+glenkiXLboRgToB5El6GO
	UsvExncbEwPetXQ53sbYfkQEYO5bsXo6mJ4vdUFQmLWAm1jzclbYErsD1jK++jQv
	7gUHQAedv1OS9bbvYyM4WTRMFwPpQgYo5JRBg1rnNmSMZPFCMsjwGaqtbHmIeWV5
	U+Yfv9/FCyX1qJZmLSq1g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1665163919; x=1665250319; bh=UFRh/83Bkh5gjHTT0p6dZH9JJ3M4
	HOjeJ6B4cYvrhrU=; b=FQyCX8fwgbZdgJNBzd5bnpwXX0PnA/hIkbwQDwUHV2yd
	82Gk6y7ieS+Wj+s3v65gwq+zRIe5z9hlcm1LpaTYItjmn73ebs+GVcwWJxiR/mmb
	Sx5N/23MJnmgq50v3j4rKsb3msM9pQfjJ70QBDVytR6YkuWpH2hSu/taDvm8CS3A
	3ugEhMIeDHKaJWpVycfw75r2VWP0FFY6HUsrBFAHEwVRQtBa4z8IftvsUg2TqQUZ
	znmM07TLEbYKXWlObVsDy95R54oAQau4ZZL+khqI8pgtunFXVn2zyDTRtJ8TsoY8
	LC4QFxFPaABGtIgU+uy+mr3Wubg8GNzyffzlMrvKiQ==
X-ME-Sender: <xms:j2JAYz__eb26N6woZ7JP8w9oSaoIEKlJMeR_SRQyQ136_TC66XfyzQ>
    <xme:j2JAY_tjToDfHD3WC0a2aNs9labvQsdy1RMpFvOvh4JwsEq9FyP3PdZ6beoE_lnus
    lSrkIlhtYIKBps>
X-ME-Received: <xmr:j2JAYxBs-NsUahAfR6a0KCGWOcWIs2-KIThP_Pn1TWgSK_b_rNushYAR5Ati>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeijedguddugecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekteegiefhteehffegvdeggeej
    udelleeltdffveevtdetfeejuefgieeuhfeuleenucffohhmrghinhepkhgvrhhnvghlrd
    horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep
    uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:j2JAY_fOf52dLvqa7MBlVVkZcPs8JbyPLHifBw50ao1c75zjyvwPCg>
    <xmx:j2JAY4PNVB0VTZ3HQhye0YQeg4BaDctVCR2nW4BG9PNrzHkMUvYpLg>
    <xmx:j2JAYxnPaT156m7jJyRc5C7Ypq0BlMzgl0lvgfVD9zCZTkngbmadYw>
    <xmx:j2JAY1oe3O0nreGAxgCVAKWRoMzFMkkXxofuHjlGgWyz7C22BWlR5Q>
Feedback-ID: iac594737:Fastmail
Date: Fri, 7 Oct 2022 13:31:54 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>, "M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 0/2] xen/gntdev: Fixes for leaks and VMA splitting
Message-ID: <Y0BijRE6/gdBr9Bn@itl-email>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <9aa1e6ba-a153-8dfa-ce28-3ab78b26c6e4@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="icHkrWgI+wqJhboV"
Content-Disposition: inline
In-Reply-To: <9aa1e6ba-a153-8dfa-ce28-3ab78b26c6e4@suse.com>


--icHkrWgI+wqJhboV
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 7 Oct 2022 13:31:54 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>, "M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 0/2] xen/gntdev: Fixes for leaks and VMA splitting

On Fri, Oct 07, 2022 at 07:17:41AM +0200, Juergen Gross wrote:
> On 03.10.22 00:20, M. Vefa Bicakci wrote:
> > Hi all,
> >=20
> > First of all, sorry for the delay!
> >=20
> > These patches continue the code review for the following patches:
> >    https://lore.kernel.org/xen-devel/20220912040002.198191-1-m.v.b@runb=
ox.com/t/#u
> >=20
> > The original description of the patch set is as follows:
> >=20
> >    "The changes in this patch series intend to fix the Xen grant device
> >    driver, so that grant mapping leaks caused by partially failed grant
> >    mapping operations are avoided with the first patch, and so that the
> >    splitting of VMAs does not result in incorrectly unmapped grant pages
> >    with the second patch. The second patch also prevents a similar issue
> >    in a double-mapping scenario, where mmap() is used with MAP_FIXED to
> >    map grants over an existing mapping created with the same grants, and
> >    where grant pages are unmapped incorrectly as well."
> >=20
> > A summary of the changes from v1 is as follows:
> > - Addressed Juergen's code review comment regarding the first patch.
> > - Amended the description of the second patch to note that the described
> >    issues are encountered with PV domains.
> >=20
> > Verification notes:
> >=20
> > - I have tested these commits on top of Linux v5.15.70 and v5.15.71, and
> >    I verified that they compile successfully on top of the tag
> >    "next-20220930", which corresponds to the base commit ID included at
> >    the bottom of this e-mail.
> >=20
> > - My tests consist of using a kernel with Qubes OS v4.1's patches and
> >    these patches on my main computer for day-to-day tasks, in conjuncti=
on
> >    with Qubes OS's version of the Xen hypervisor v4.14.5, with the latt=
er
> >    custom-compiled with CONFIG_DEBUG.
> >=20
> > - I used a test program that verifies the following scenarios with an
> >    unprivileged paravirtualized (PV) Xen domain:
> >=20
> >    - A program mmap()s two pages from another Xen domain and munmap()s
> >      the pages one by one. This used to result in implicit unmap errors
> >      to be reported by Xen and a general protection fault to be trigger=
ed
> >      by Xen in the affected domain, but now works as expected.
> >    - A program mmap()s two pages from another Xen domain and then
> >      attempts to remap (via MAP_FIXED) the same mapping again over the
> >      same virtual address. This used to result in similar issues
> >      (implicit unmap errors and general protection fault), but now is
> >      rejected by the kernel.
> >    - A program mmap()s two pages from another Xen domain and then
> >      attempts to mmap() the same mapping again to a different virtual
> >      address, by passing NULL as mmap()'s first argument. This used to =
be
> >      rejected by the kernel, and it continues to be rejected by the
> >      kernel.
> >=20
> > - Unprivileged PVH Xen domains were also sanity tested with the same
> >    test program. I should note that PVH domains worked as expected
> >    without these patches too.
> >=20
> > - Finally, I have verified that the original "g.e. 0x1234 still pending"
> >    issue does not appear after rapidly resizing GUI windows in Qubes OS
> >    v4.1.
>=20
> Series pushed to xen/tip.git for-linus-6.1

Thanks!
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--icHkrWgI+wqJhboV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmNAYowACgkQsoi1X/+c
IsET/A//T7lUkkW0Asz4OA/e1UJcpTOuhv17BLYolj8QuDkNfiWix8EXsVX+BfkE
ok4HZW4qD6mYB3OzO0NjweeGQt7I1JtAxCu8uwlHA93f3vqRwntr/Cch7tDqloZ7
0P4YbGiyCzmCB3bsD6bh2AqsFO6uH0bIegiYOMLnXGcpDdQiiJx+wJ62LFqfW1A7
YkW3P0t6bDBFT90WBMy4v0apS4culhw5VOnLE6EIklj+xhSfZoags77z/Ua+Dg9w
blQAaS+bF4Evatf2ZwE/nfYGlPrbPYWRjh9T9kAyFO3PcwrppV1EiDLjM19lK8Vo
57DfdSpHBAmpFTLt4GFJyNf/AoB/jOlpw4LuVpLqgPVrWw17eEHNz7amK9bILJzo
3Y5R1xckDNg0rHyiVD+Vr27CSLadcCn6DSdnSuGOk3sT5iGaci8FGv3NRtOODS9J
MaiM7FyH4D7ttjrz+agrSFk/1/a2cbBKMAwBPy0qglfv8C/Alm11gZCojjFWxSAZ
O6gTN/MgbI7FUeYWX0fv9y6SzUurXG5lfxyTCQCSiECCnFbmuwBOa2W+br24AAgq
oKB38+t5Ax6ObXheQBMFhOm1WsD7Zln5YHLRWgC3Wu9ZSx836a1tey0oFJ5VNzrH
Y2M3ETghA702QUsZiBZX2wH38n+ttptCJotAvIh3bJv5ePia3ac=
=6gwm
-----END PGP SIGNATURE-----

--icHkrWgI+wqJhboV--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 17:35:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 17:35:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418208.662951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogrG6-0002nA-Fp; Fri, 07 Oct 2022 17:35:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418208.662951; Fri, 07 Oct 2022 17:35:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogrG6-0002n3-Cv; Fri, 07 Oct 2022 17:35:38 +0000
Received: by outflank-mailman (input) for mailman id 418208;
 Fri, 07 Oct 2022 17:35:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7mFU=2I=epam.com=prvs=2279168535=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ogrG4-0002mv-H8
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 17:35:36 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 71ac36cc-4666-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 19:35:34 +0200 (CEST)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297E49le018131;
 Fri, 7 Oct 2022 17:35:22 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k2kap9cyq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 07 Oct 2022 17:35:22 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB9PR03MB9637.eurprd03.prod.outlook.com (2603:10a6:10:457::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct
 2022 17:35:19 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Fri, 7 Oct 2022
 17:35:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71ac36cc-4666-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LbxlkZheDMAF+K96CDnpwZph1uegJZP93Jxrv3oOyvLbGXDVRLOsLDik4LVkujhqgLnOeqsWQZNUkb0T0DNJdgIiaVfWzQPjDAcRJfyouuMs8U0N7cLPnaQ86RsDUt/gMnVx92TovMbZS80StgbNEPPEcBBuqHxR6ouB9CMxZkOO8r1X/vksjqqAe6EQkc7G4lpTArPQ3ZyOr+cK9eD9zUEgJ9leUSA0UcQaazH7/YEJRlKKTtuoLVyuXIVPGR/QnZkzL/xoVAqg7XLkdzxljtwmspFvhHIyry+OAqNka5/feaIDd0k6F573ZBgCJ/ycL4/jU9Fz9GKxO4qaLsJ8lQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tPTrQC5ZIsOBvwhK/yI1h2HY2ZX9ykzf5kxYYOwCUqs=;
 b=IfG6kHP1206CH/mE2EljOIiCIXexlmwY3d1K9LdyDXjqJRG4uZK/NOdOXrnuD5ov6oVgQdm8YttLpX3AhlKGgeKL3QPCzAzrseioW8DLCQf5V9pwkVVBBUVzfTtoZvEtY/UC+t39XRdI4Cnr0ud9gZmzonpDQigZPQiIf0K4sbDfuYvI80is/WF3BXyU21WZwojVcxL/EbCVVyhCN32cQr8jni7KBT43zvH9o6ZQied7wyLqc4dUAkUgJg5hXasokcXYr7sq986PRCcQ0GCIkMofLGF147k6manb4acJJVuqHaNgwOEOFySJqjGeWqD7oEVlhraKMkrj4CanQPYqLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tPTrQC5ZIsOBvwhK/yI1h2HY2ZX9ykzf5kxYYOwCUqs=;
 b=PjpoYdWungux0he8gs7R2tFIBIP5BzwDuHNyXt73EDDb8GZa41u6mN/0ydNR8k4aG6kFXEvfEIBWirWQ7CmfLGc6ft6yIbgE6BZneYSHVWgc9bu3StqThwgFkdFJ2ObLLMQvYA92dCB+kjxWUInPvhKr5G5RPn0PBXDbQDWn8yeNQ/zX3qQ47owrZrlhqw0vgnLIVIPD+4ywDGpkcLDsz8JphOGo5XN0Cei7h24a1foSSolaZO6ZzuE+GlWdEo/ILkE86D4mN4st7NeEmbpcpWbimUZMEZfylVPjx5pazur+VUETavr+cGJp/lKjr+EFJg9LX2MaGYFvZLiYwZOp2A==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Topic: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Thread-Index: 
 AQHY2Xx9ME9woenUJk6IqJF2QACToq4Bp86AgAA2I4CAAKgkgIAAbJWAgAAjboCAAAc3gIAAFg0A
Date: Fri, 7 Oct 2022 17:35:18 +0000
Message-ID: <55d9f368-bf20-5439-e821-04c7709cb9a5@epam.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
 <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
 <816da52a-f646-c114-fa6d-9320152a0e79@epam.com>
 <677bc264-c507-3bed-6d51-0d010a0dd449@gmail.com>
 <ab4ef342-5982-6e0e-7859-eaab026d48a4@epam.com>
In-Reply-To: <ab4ef342-5982-6e0e-7859-eaab026d48a4@epam.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DB9PR03MB9637:EE_
x-ms-office365-filtering-correlation-id: 9a0d8ccd-0e2f-47e5-4bfd-08daa88a4dc2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 rJR3mPt+tVVmtun+cCHtxPzYtZDEu8NXwMuiRu4lUqxD8SQ+omdVHJZTqYiWExVlAXTWlvWmauXAQ6wtbxAAyrPVUOx+JZji8njbHVfq0H44jd0xDYsIQWFAnh3tr1mBIOK12ZYwQsy/dFIStFKmZFLgt+vq9MTbNDrtxQ9jb4YIb7L21941VJl2/S0svr3KGDwJCD49ENfL+ia+RvOe73MzzroZgoSdNbD2dbjcxdLI13g2x0fmedntxSzBx0w3F9XsW07XgeJguIlPmp8dLSzO8rsKUj7c+/91K1Jz5FnRR6AQZNXyK1FaZ09HwRmoHT98glIdtWtPMpspoCtLDjPFyJ0CFxCQhtuDMXgkS8ofRiaP5mC+atuNBfvzy5JPjlSwULMeHWYiWomdrCett8x2h95AQzxXlScGOyOL6/d772nt/o38tvxhBtds5ZviyuTckmRoV5XJUI3t78CLKcCeHUxfCoBPYYXeAOv/MT3BZa+VlYpG8HGlCpvBB29UqXlmub/gpceYW/t84I3LzIt5R9UMVXt2aw0W1pajY88JJSaAW7z8ovKNtof/Yhbt1UXkMTo88bhAxTlkelZxLgFDYI/c4jvcu9e7CK7GCFnyTpCoDq/kk/v/j6degNKdLeCqQyt3cIY6wnEkFS3DKekaOMh522ZG20LdZD/tgC0XoA0RxE1IZmAdF3oE3Vi/XYPS9UzXLTm+KwoX9AMfdTqSDjLUex115w47qUDXh0bzb21nqMiwXqkHOy0PBbKc7E4cAvhgqLG9yZRrut/PmOJwjgrrN2WUrCHkM+mBaGYsADr1a3e27xjfVb9TZcE13eLyVPMCF8h9/wnPOWHjxA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199015)(110136005)(26005)(2906002)(31686004)(66899015)(36756003)(6506007)(4326008)(31696002)(8676002)(64756008)(66446008)(966005)(83380400001)(71200400001)(6512007)(38100700002)(478600001)(45080400002)(55236004)(122000001)(53546011)(2616005)(6486002)(91956017)(66556008)(86362001)(41300700001)(30864003)(186003)(66476007)(38070700005)(316002)(54906003)(8936002)(5660300002)(66946007)(76116006)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WWN5WS9Fa1Btd1VoZGkrTXhsYWNtL0M5bkJJbnppOHd5R1hwN1NKUXU1bk9J?=
 =?utf-8?B?MnJlVFc5UFBqcUUxQ1llKzB0OERUeHcwcmNhNDlDdjNrYzdZUXpselNTWHo0?=
 =?utf-8?B?V2hNUk1vNzlHbVQrdUtqVW94dG9tbWpyd1dRVTlhT2hlN0ZvUWlzQkdPZCtV?=
 =?utf-8?B?aTRXUFg1RExPQXVlMytpWFBmNllsK0hQOVEvNVdoT3Axc1BNbjZMTVBCSDB2?=
 =?utf-8?B?TXd3SzhSODA4RW01Q0VUN0wvdFZYOGpGQjRKRzdVTG1GMnlLdk5TMzM2MWF4?=
 =?utf-8?B?dmJQSU56VGNpYnpLalhtbGtFNUhTUUt6bERueDN3TGNDTlRUZGhKQ0U4WE8w?=
 =?utf-8?B?OXV1WDJkdmoreFBvRVFuRHRGVTJ3V01XZ2JVeXVBc0xqelpHSFZ3MktDR1N6?=
 =?utf-8?B?enMwa3FRaHU5UzNvbDJ3dGxwa3RtdmsvRlMyUUhrM3F0aEVKZnVxZFBaeEU5?=
 =?utf-8?B?UzRpQWtYZW1kZXNPWTBIb01HdHJuZTMwc0l0M2pOUW5sbDE4WFRERlIxck5J?=
 =?utf-8?B?VDZMQTZlSFVRbHJVd0dlTnh6SUJDSy9IWGhld0wwbDZIVERmTERJVVNhellE?=
 =?utf-8?B?bThjNW9nVWhzNnlELzIwM0V6UGdxK2pndHc1WlJVSmFWMFJ3cnNRUzdocFRH?=
 =?utf-8?B?NkxtZ1FaOElQU0hDY3FkVDRTbTUzeXZWZHFqamVVMUR1NGpIdnBCYWtEQXdm?=
 =?utf-8?B?ZUdNa2MxRTdhZDR4OFJkUXJsQ2ZyOHpuTUh0bTZjcytNTnhQd0djVW9BS0xM?=
 =?utf-8?B?TEpobk9PUDlKUElidFk5YUZZc3YwUmRsemNEYUxPRHp5RkVCTXFTQzFTU2tY?=
 =?utf-8?B?ZDNtRVR1TjBhRGJyb1hwVEd4cGVHbndlU0lLRkdkUTBDR3VCK0JjSUtUSzkr?=
 =?utf-8?B?dExBWG8rV00zUk5ZblJnMUx5MmtjdlRFRzRQKytTeE9FMzFod0tPejdseDRj?=
 =?utf-8?B?ZEJ1aHlvRlRWeG1VZDdQQ3c3T1pzSVlPcVR6Vk9yRkUwK3d4dVpOZS9xdnFv?=
 =?utf-8?B?MVkwWGVaMHA0ck4wcitvKytIVll0RjhiNlZRMFV3TVdmMmtubllaQjg3Tkh0?=
 =?utf-8?B?clFYU2d1Y3l4WjdOejlneFhCTENqUkJvK0VTWnpYaUd4VENPbWxNRWVjRWdt?=
 =?utf-8?B?U2VoZUc5RXRtVGtKU1ZROXR6d0VNMVFMeHZ0cU00SVFmc25QZkpEYXFqUlJC?=
 =?utf-8?B?b04yY0tTTVhJMVZrMlZ3UFc4RDlyM1A3TUtCZmJOSkVTRUdMSUpnZ2JOUC8r?=
 =?utf-8?B?TEd3YUtlcHY2MVRuNG9DMVA4MzMzL1BaQTgyUXN3aWQ2VlJPekR0bkVrNU9U?=
 =?utf-8?B?MjROeGhGMHNkU2FmMnZWeEVib05NemZyQ3htM1I2MlF6SThzeDhuVDR1enVw?=
 =?utf-8?B?VVdKYlMxTmVjTUd0b2ZwVm9mK3I3MzM5MVd2bmw3TnYrNTUxc2gxMmhEZEFu?=
 =?utf-8?B?blpWOUxYTFdwT1V2a3FNUVl3MW13VEZuYUJlcWd0b1NuUDdUbjVJLzdhYzRB?=
 =?utf-8?B?L1YwbktIQ0RUdit5VG9OVWp4Q0U0dHFoWU1DNWFEa0puMmZkb0xTbXFxVVRs?=
 =?utf-8?B?UzY0MnQvS1o4Z1hEMXlnY3I0WHhpb3ExTU01YTh6bURUVFA4dUxoNDMwYTJV?=
 =?utf-8?B?N0R3eGdvOVA5VlpyS3BVOHMwblRCR2JBM3VTcjNINEtjWm8zQ0lidkFUeVZt?=
 =?utf-8?B?OFJQZkJXUDBFQ1llS3NBcFFoNW5mcjNZeThUeGZlakZBdHFQN2lVUTFUSXpa?=
 =?utf-8?B?aS9CeWh1UXYycWwzMG5ldDBrMEQ0ejUrT3UwaVpobXFRYU85WXpKZlFZSi9u?=
 =?utf-8?B?Szh5ZzFwS3B3TDJyeWFVS09BQUYzOUhwL1o3UmVkNzRmSWw2YXlHeHZ1YXFq?=
 =?utf-8?B?TWl6aklnc0xJT2pWOVlSVXpqZEZ4N1hrRzB3QnVXSTNIbjA0ckhuVkVDVnp5?=
 =?utf-8?B?V3IzNHYzNVFDZTBGZk14L21NdTBWWjJsQWJ6MFRyUTZuN2xIYmMvaFRGV1lw?=
 =?utf-8?B?d3ZzZUF2cXAzam1TSWxaVUVXem5Ca280dklHQy96WnZvdDFkNHhMb20zcE8z?=
 =?utf-8?B?Zk5rUnZXTHZpckhWT1pKa3N0UFhtSFBqSnp5WUxaczNpbFBnMzRzOGtDNmJu?=
 =?utf-8?B?WXQrVWFQY3hwdE1ORlFhL0ZleXZ3ZHl6Yyt3Y1FKbEFFVEN2UEFWck44M2d4?=
 =?utf-8?Q?KGGJ68SPnY1msflJ05X+Wbg=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A97091458DC746408F588385E68DA01B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a0d8ccd-0e2f-47e5-4bfd-08daa88a4dc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 17:35:18.9410
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KaJjIt2SV4dokhz5KDqNAKEaawei5ifTaQnNRhUp5rJxOSwkJBCVZauLQ8oZHeQCRwxCscpDkr2EW2cnFTnC7BR5LirVx/YfXJy1B69SGng=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB9637
X-Proofpoint-GUID: QAXRxH-9Sd3_akUCaNu91x_9UDqdzJiG
X-Proofpoint-ORIG-GUID: QAXRxH-9Sd3_akUCaNu91x_9UDqdzJiG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0
 lowpriorityscore=0 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0
 clxscore=1015 priorityscore=1501 mlxscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210070103

DQpPbiAwNy4xMC4yMiAxOToxNiwgT2xla3NhbmRyIHdyb3RlOg0KDQpIZWxsbyBYZW5pYQ0KDQo+
DQo+IE9uIDA3LjEwLjIyIDE4OjUwLCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPg0KPg0KPiBI
ZWxsbyBYZW5pYQ0KPg0KPj4NCj4+IE9uIDEwLzcvMjIgMTY6NDMsIE9sZWtzYW5kciBUeXNoY2hl
bmtvIHdyb3RlOg0KPj4+DQo+Pj4gT24gMDcuMTAuMjIgMTA6MTUsIFhlbmlhIFJhZ2lhZGFrb3Ug
d3JvdGU6DQo+Pj4+DQo+Pj4+IE9uIDEwLzcvMjIgMDA6MTMsIE9sZWtzYW5kciBUeXNoY2hlbmtv
IHdyb3RlOg0KPj4+Pg0KPj4+PiBIaSBPbGVrc2FuZHINCj4+Pg0KPj4+DQo+Pj4gSGVsbG8gWGVu
aWENCj4+Pg0KPj4+DQo+Pj4+DQo+Pj4+Pg0KPj4+Pj4gT24gMDYuMTAuMjIgMjA6NTksIFhlbmlh
IFJhZ2lhZGFrb3Ugd3JvdGU6DQo+Pj4+Pg0KPj4+Pj4gSGVsbG8gWGVuaWENCj4+Pj4+DQo+Pj4+
Pj4NCj4+Pj4+PiBPbiAxMC82LzIyIDE1OjA5LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4+Pj4+Pj4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtv
QGVwYW0uY29tPg0KPj4+Pj4+Pg0KPj4+Pj4+PiBBbHRob3VnaCBYRU5fUEFHRV9TSVpFIGlzIGVx
dWFsIHRvIFBBR0VfU0laRSAoNEtCKSBmb3Igbm93LCBpdCANCj4+Pj4+Pj4gd291bGQNCj4+Pj4+
Pj4gYmUgbW9yZSBjb3JyZWN0IHRvIHVzZSBYZW4gc3BlY2lmaWMgI2RlZmluZS1zIGFzIFhFTl9Q
QUdFX1NJWkUgY2FuDQo+Pj4+Pj4+IGJlIGNoYW5nZWQgYXQgc29tZSBwb2ludCBpbiB0aGUgZnV0
dXJlLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5r
byA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+Pj4+IC0tLQ0KPj4+Pj4+PiBD
YzogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+Pj4+PiBDYzogWGVuaWEgUmFn
aWFkYWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29tPg0KPj4+Pj4+Pg0KPj4+Pj4+PiBBcyBpdCB3
YXMgcHJvcG9zZWQgYXQ6DQo+Pj4+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRw
czovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDUxNzQ4MjMuMTgwMDc2MS0xLW9s
ZWtzdHlzaEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSF6SHQteFpfN3RaY19FTTZ6dmEy
MUVfWWd3SWlFZWltRldmc0pJcFB3QXUtVEJjbnpRaFhIcWxLem1YbXdJY0k2dUl4X2FySE5aaWFa
ZUh0XzQyOF84cC1EeU1wZCQgDQo+Pj4+Pj4+DQo+Pj4+Pj4+DQo+Pj4+Pj4+IFtsb3JlWy5da2Vy
bmVsWy5db3JnXQ0KPj4+Pj4+Pg0KPj4+Pj4+PiBTaG91bGQgZ28gaW4gb25seSBhZnRlciB0aGF0
IHNlcmllcy4NCj4+Pj4+Pj4gLS0tDQo+Pj4+Pj4+IMKgwqDCoCBkcml2ZXJzL3hlbi9ncmFudC1k
bWEtb3BzLmMgfCAyMCArKysrKysrKysrLS0tLS0tLS0tLQ0KPj4+Pj4+PiDCoMKgwqAgMSBmaWxl
IGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQ0KPj4+Pj4+Pg0KPj4+
Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIA0KPj4+Pj4+PiBi
L2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4+PiBpbmRleCBjNjZmNTZkMjQwMTMu
LjUzOTJmZGMyNWRjYSAxMDA2NDQNCj4+Pj4+Pj4gLS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1h
LW9wcy5jDQo+Pj4+Pj4+ICsrKyBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4+
PiBAQCAtMzEsMTIgKzMxLDEyIEBAIHN0YXRpYyANCj4+Pj4+Pj4gREVGSU5FX1hBUlJBWV9GTEFH
Uyh4ZW5fZ3JhbnRfZG1hX2RldmljZXMsDQo+Pj4+Pj4+IFhBX0ZMQUdTX0xPQ0tfSVJRKTsNCj4+
Pj4+Pj4gwqDCoMKgIMKgIHN0YXRpYyBpbmxpbmUgZG1hX2FkZHJfdCBncmFudF90b19kbWEoZ3Jh
bnRfcmVmX3QgZ3JhbnQpDQo+Pj4+Pj4+IMKgwqDCoCB7DQo+Pj4+Pj4+IC3CoMKgwqAgcmV0dXJu
IFhFTl9HUkFOVF9ETUFfQUREUl9PRkYgfCAoKGRtYV9hZGRyX3QpZ3JhbnQgPDwNCj4+Pj4+Pj4g
UEFHRV9TSElGVCk7DQo+Pj4+Pj4+ICvCoMKgwqAgcmV0dXJuIFhFTl9HUkFOVF9ETUFfQUREUl9P
RkYgfCAoKGRtYV9hZGRyX3QpZ3JhbnQgPDwNCj4+Pj4+Pj4gWEVOX1BBR0VfU0hJRlQpOw0KPj4+
Pj4+PiDCoMKgwqAgfQ0KPj4+Pj4+DQo+Pj4+Pj4gV2l0aCB0aGlzIGNoYW5nZSwgY2FuIHRoZSBv
ZmZzZXQgYWRkZWQgdG8gdGhlIGRtYSBoYW5kbGUsIA0KPj4+Pj4+IGdlbmVyYXRlZCBieQ0KPj4+
Pj4+IGdyYW50X3RvX2RtYSgpLCBiZSB0aGUgb2Zmc2V0IGluIHRoZSBwYWdlPyBDb3VsZG4ndCBp
dCBjb3JydXB0IHRoZQ0KPj4+Pj4+IGdyYW50IHJlZj8NCj4+Pj4+DQo+Pj4+Pg0KPj4+Pj4gR29v
ZCBwb2ludCwgaW5kZWVkLCBJIHRoaW5rIGl0IGNvdWxkIGNvcnJ1cHQgaWYgZ3Vlc3QgdXNlcyBh
IA0KPj4+Pj4gZGlmZmVyZW50DQo+Pj4+PiB0aGFuIFhlbiBwYWdlIGdyYW51bGFyaXR5IChpLmUg
NjRLQikuDQo+Pj4+Pg0KPj4+Pj4NCj4+Pj4+Pg0KPj4+Pj4+PiDCoMKgwqAgwqAgc3RhdGljIGlu
bGluZSBncmFudF9yZWZfdCBkbWFfdG9fZ3JhbnQoZG1hX2FkZHJfdCBkbWEpDQo+Pj4+Pj4+IMKg
wqDCoCB7DQo+Pj4+Pj4+IC3CoMKgwqAgcmV0dXJuIChncmFudF9yZWZfdCkoKGRtYSAmIH5YRU5f
R1JBTlRfRE1BX0FERFJfT0ZGKSA+Pg0KPj4+Pj4+PiBQQUdFX1NISUZUKTsNCj4+Pj4+Pj4gK8Kg
wqDCoCByZXR1cm4gKGdyYW50X3JlZl90KSgoZG1hICYgflhFTl9HUkFOVF9ETUFfQUREUl9PRkYp
ID4+DQo+Pj4+Pj4+IFhFTl9QQUdFX1NISUZUKTsNCj4+Pj4+Pj4gwqDCoMKgIH0NCj4+Pj4+Pj4g
wqDCoMKgIMKgIHN0YXRpYyBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhIA0KPj4+Pj4+PiAqZmlu
ZF94ZW5fZ3JhbnRfZG1hX2RhdGEoc3RydWN0DQo+Pj4+Pj4+IGRldmljZSAqZGV2KQ0KPj4+Pj4+
PiBAQCAtNzksNyArNzksNyBAQCBzdGF0aWMgdm9pZCAqeGVuX2dyYW50X2RtYV9hbGxvYyhzdHJ1
Y3QgZGV2aWNlDQo+Pj4+Pj4+ICpkZXYsIHNpemVfdCBzaXplLA0KPj4+Pj4+PiDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgYXR0cnMpDQo+Pj4+
Pj4+IMKgwqDCoCB7DQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1h
X2RhdGEgKmRhdGE7DQo+Pj4+Pj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBQ
Rk5fVVAoc2l6ZSk7DQo+Pj4+Pj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBY
RU5fUEZOX1VQKHNpemUpOw0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHBm
bjsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgZ3JhbnRfcmVmX3QgZ3JhbnQ7DQo+Pj4+Pj4+IMKg
wqDCoMKgwqDCoMKgIHZvaWQgKnJldDsNCj4+Pj4+Pj4gQEAgLTkxLDE0ICs5MSwxNCBAQCBzdGF0
aWMgdm9pZCAqeGVuX2dyYW50X2RtYV9hbGxvYyhzdHJ1Y3QgZGV2aWNlDQo+Pj4+Pj4+ICpkZXYs
IHNpemVfdCBzaXplLA0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBpZiAodW5saWtlbHkoZGF0YS0+
YnJva2VuKSkNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gTlVMTDsNCj4+
Pj4+Pj4gwqDCoMKgIC3CoMKgwqAgcmV0ID0gYWxsb2NfcGFnZXNfZXhhY3Qobl9wYWdlcyAqIFBB
R0VfU0laRSwgZ2ZwKTsNCj4+Pj4+Pj4gK8KgwqDCoCByZXQgPSBhbGxvY19wYWdlc19leGFjdChu
X3BhZ2VzICogWEVOX1BBR0VfU0laRSwgZ2ZwKTsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgaWYg
KCFyZXQpDQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5VTEw7DQo+Pj4+
Pj4+IMKgwqDCoCDCoMKgwqDCoMKgIHBmbiA9IHZpcnRfdG9fcGZuKHJldCk7DQo+Pj4+Pj4+IMKg
wqDCoCDCoMKgwqDCoMKgIGlmIChnbnR0YWJfYWxsb2NfZ3JhbnRfcmVmZXJlbmNlX3NlcShuX3Bh
Z2VzLCAmZ3JhbnQpKSB7DQo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0
KHJldCwgbl9wYWdlcyAqIFBBR0VfU0laRSk7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBmcmVl
X3BhZ2VzX2V4YWN0KHJldCwgbl9wYWdlcyAqIFhFTl9QQUdFX1NJWkUpOw0KPj4+Pj4+PiDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxMOw0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCB9
DQo+Pj4+Pj4+IMKgwqDCoCBAQCAtMTE2LDcgKzExNiw3IEBAIHN0YXRpYyB2b2lkIHhlbl9ncmFu
dF9kbWFfZnJlZShzdHJ1Y3QgDQo+Pj4+Pj4+IGRldmljZQ0KPj4+Pj4+PiAqZGV2LCBzaXplX3Qg
c2l6ZSwgdm9pZCAqdmFkZHIsDQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIGRtYV9hZGRyX3QgZG1hX2hhbmRsZSwgdW5zaWduZWQgbG9uZyBhdHRy
cykNCj4+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9n
cmFudF9kbWFfZGF0YSAqZGF0YTsNCj4+Pj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9w
YWdlcyA9IFBGTl9VUChzaXplKTsNCj4+Pj4+Pj4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9w
YWdlcyA9IFhFTl9QRk5fVVAoc2l6ZSk7DQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgIGdyYW50X3Jl
Zl90IGdyYW50Ow0KPj4+Pj4+PiDCoMKgwqAgwqDCoMKgwqDCoCBkYXRhID0gZmluZF94ZW5fZ3Jh
bnRfZG1hX2RhdGEoZGV2KTsNCj4+Pj4+Pj4gQEAgLTEzOCw3ICsxMzgsNyBAQCBzdGF0aWMgdm9p
ZCB4ZW5fZ3JhbnRfZG1hX2ZyZWUoc3RydWN0IGRldmljZQ0KPj4+Pj4+PiAqZGV2LCBzaXplX3Qg
c2l6ZSwgdm9pZCAqdmFkZHIsDQo+Pj4+Pj4+IMKgwqDCoCDCoMKgwqDCoMKgIGdudHRhYl9mcmVl
X2dyYW50X3JlZmVyZW5jZV9zZXEoZ3JhbnQsIG5fcGFnZXMpOw0KPj4+Pj4+PiDCoMKgwqAgLcKg
wqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHZhZGRyLCBuX3BhZ2VzICogUEFHRV9TSVpFKTsNCj4+Pj4+
Pj4gK8KgwqDCoCBmcmVlX3BhZ2VzX2V4YWN0KHZhZGRyLCBuX3BhZ2VzICogWEVOX1BBR0VfU0la
RSk7DQo+Pj4+Pj4+IMKgwqDCoCB9DQo+Pj4+Pj4+IMKgwqDCoCDCoCBzdGF0aWMgc3RydWN0IHBh
Z2UgKnhlbl9ncmFudF9kbWFfYWxsb2NfcGFnZXMoc3RydWN0IA0KPj4+Pj4+PiBkZXZpY2UgKmRl
diwNCj4+Pj4+Pj4gc2l6ZV90IHNpemUsDQo+Pj4+Pj4+IEBAIC0xNjgsNyArMTY4LDcgQEAgc3Rh
dGljIGRtYV9hZGRyX3QgeGVuX2dyYW50X2RtYV9tYXBfcGFnZShzdHJ1Y3QNCj4+Pj4+Pj4gZGV2
aWNlICpkZXYsIHN0cnVjdCBwYWdlICpwYWdlLA0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBhdHRycykNCj4+Pj4+
Pj4gwqDCoMKgIHsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFudF9kbWFf
ZGF0YSAqZGF0YTsNCj4+Pj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFBG
Tl9VUChvZmZzZXQgKyBzaXplKTsNCj4+Pj4+Pj4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgaSwgbl9w
YWdlcyA9IFhFTl9QRk5fVVAob2Zmc2V0ICsgc2l6ZSk7DQo+Pj4+Pj4NCj4+Pj4+PiBUaGUgb2Zm
c2V0LCBoZXJlLCByZWZlcnMgdG8gdGhlIG9mZnNldCBpbiB0aGUgcGFnZSAuLi4NCj4+Pj4+Pg0K
Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBncmFudF9yZWZfdCBncmFudDsNCj4+Pj4+Pj4gwqDCoMKg
wqDCoMKgwqAgZG1hX2FkZHJfdCBkbWFfaGFuZGxlOw0KPj4+Pj4+PiDCoMKgwqAgQEAgLTIwMCw4
ICsyMDAsOCBAQCBzdGF0aWMgdm9pZCB4ZW5fZ3JhbnRfZG1hX3VubWFwX3BhZ2Uoc3RydWN0DQo+
Pj4+Pj4+IGRldmljZSAqZGV2LCBkbWFfYWRkcl90IGRtYV9oYW5kbGUsDQo+Pj4+Pj4+IMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25n
IGF0dHJzKQ0KPj4+Pj4+PiDCoMKgwqAgew0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3Qg
eGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4+Pj4+PiAtwqDCoMKgIHVuc2lnbmVkIGxvbmcg
b2Zmc2V0ID0gZG1hX2hhbmRsZSAmIChQQUdFX1NJWkUgLSAxKTsNCj4+Pj4+Pj4gLcKgwqDCoCB1
bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFBGTl9VUChvZmZzZXQgKyBzaXplKTsNCj4+Pj4+Pj4g
K8KgwqDCoCB1bnNpZ25lZCBsb25nIG9mZnNldCA9IGRtYV9oYW5kbGUgJiB+WEVOX1BBR0VfTUFT
SzsNCj4+Pj4+Pg0KPj4+Pj4+IC4uLiB3aGlsZSwgaGVyZSwgaXQgcmVmZXJzIHRvIHRoZSBvZmZz
ZXQgaW4gdGhlIGdyYW50Lg0KPj4+Pj4+IFNvLCB0aGUgY2FsY3VsYXRlZCBudW1iZXIgb2YgZ3Jh
bnRzIG1heSBkaWZmZXIuDQo+Pj4+Pg0KPj4+Pj4gR29vZCBwb2ludCwgSSB0aGluayB5b3UgYXJl
IHJpZ2h0LCBzbyB3ZSBuZWVkIHRvIGFkZGl0aW9uYWxseSB1c2UNCj4+Pj4+IHhlbl9vZmZzZXRf
aW5fcGFnZSgpIG1hY3JvIGluIHhlbl9ncmFudF9kbWFfbWFwX3BhZ2UoKSwNCj4+Pj4+DQo+Pj4+
PiBzb21ldGhpbmcgbGlrZSB0aGF0IHRvIGJlIHNxdWFzaGVkIHdpdGggY3VycmVudCBwYXRjaDoN
Cj4+Pj4+DQo+Pj4+Pg0KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1v
cHMuYyANCj4+Pj4+IGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+PiBpbmRleCA5
ZDVlY2E2ZDYzOGEuLmJiOTg0ZGMwNWRlYiAxMDA2NDQNCj4+Pj4+IC0tLSBhL2RyaXZlcnMveGVu
L2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5j
DQo+Pj4+PiBAQCAtMTY5LDcgKzE2OSw3IEBAIHN0YXRpYyBkbWFfYWRkcl90IHhlbl9ncmFudF9k
bWFfbWFwX3BhZ2Uoc3RydWN0DQo+Pj4+PiBkZXZpY2UgKmRldiwgc3RydWN0IHBhZ2UgKnBhZ2Us
DQo+Pj4+PiDCoMKgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgYXR0cnMp
DQo+Pj4+PiDCoMKgIMKgew0KPj4+Pj4gwqDCoCDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dy
YW50X2RtYV9kYXRhICpkYXRhOw0KPj4+Pj4gLcKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgaSwg
bl9wYWdlcyA9IFhFTl9QRk5fVVAob2Zmc2V0ICsgc2l6ZSk7DQo+Pj4+PiArwqDCoMKgwqDCoMKg
IHVuc2lnbmVkIGludCBpLCBuX3BhZ2VzID0gDQo+Pj4+PiBYRU5fUEZOX1VQKHhlbl9vZmZzZXRf
aW5fcGFnZShvZmZzZXQpDQo+Pj4+PiArIHNpemUpOw0KPj4+Pj4gwqDCoCDCoMKgwqDCoMKgwqDC
oCBncmFudF9yZWZfdCBncmFudDsNCj4+Pj4+IMKgwqAgwqDCoMKgwqDCoMKgwqAgZG1hX2FkZHJf
dCBkbWFfaGFuZGxlOw0KPj4+Pj4NCj4+Pj4+IEBAIC0xOTEsNyArMTkxLDcgQEAgc3RhdGljIGRt
YV9hZGRyX3QgeGVuX2dyYW50X2RtYV9tYXBfcGFnZShzdHJ1Y3QNCj4+Pj4+IGRldmljZSAqZGV2
LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCj4+Pj4+IMKgwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuX3BhZ2VfdG9fZ2ZuKHBh
Z2UpICsgaSwgZGlyID09DQo+Pj4+PiBETUFfVE9fREVWSUNFKTsNCj4+Pj4+IMKgwqAgwqDCoMKg
wqDCoMKgwqAgfQ0KPj4+Pj4NCj4+Pj4+IC3CoMKgwqDCoMKgwqAgZG1hX2hhbmRsZSA9IGdyYW50
X3RvX2RtYShncmFudCkgKyBvZmZzZXQ7DQo+Pj4+PiArwqDCoMKgwqDCoMKgIGRtYV9oYW5kbGUg
PSBncmFudF90b19kbWEoZ3JhbnQpICsgDQo+Pj4+PiB4ZW5fb2Zmc2V0X2luX3BhZ2Uob2Zmc2V0
KTsNCj4+Pj4+DQo+Pj4+PiDCoMKgIMKgwqDCoMKgwqDCoMKgIHJldHVybiBkbWFfaGFuZGxlOw0K
Pj4+Pj4gwqDCoCDCoH0NCj4+Pj4+DQo+Pj4+PiBEaWQgSSBnZXQgeW91ciBwb2ludCByaWdodD8N
Cj4+Pj4+DQo+Pj4+DQo+Pj4+IEkgdGhpbmsgaXQgJ3MgbW9yZSBjb21wbGljYXRlZCB0aGFuIHRo
YXQuDQo+Pj4+IExldCdzIHNheSB0aGF0IHRoZSBvZmZzZXQgaW4gcGFnZSBpcyA+IFhFTl9QQUdF
X1NJWkUsIHRoZW4gdGhlDQo+Pj4+IGNhbGN1bGF0aW9uIG9mIHRoZSBudW1iZXIgb2YgZ3JhbnRz
IHdvbid0IHRha2UgaW50byBhY2NvdW50IHRoZSBwYXJ0DQo+Pj4+IG9mIHRoZSBvZmZzZXQgdGhh
dCBpcyBtdWx0aXBsZSBvZiB0aGUgWEVOX1BBR0VfU0laRSBpLmUgaXQgd2lsbA0KPj4+PiBjYWxj
dWxhdGUgb25seSB0aGUgc3RyaWN0bHkgbmVjZXNzYXJ5IG51bWJlciBvZiBncmFudHMuDQo+Pj4+
IEJ1dCB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKCkgZ3JhbnRzIGFjY2VzcyB0byB0aGUgd2hvbGUg
cGFnZSBiZWNhdXNlLA0KPj4+PiBhcyBpdCBjYW4gYmUgb2JzZXJ2ZWQgaW4gdGhlIGNvZGUgc25p
cHBldCBiZWxvdywgaXQgZG9lcyBub3QgdGFrZSBpbnRvDQo+Pj4+IGFjY291bnQgdGhlIHBhZ2Ug
b2Zmc2V0Lg0KPj4+Pg0KPj4+PiBmb3IgKGkgPSAwOyBpIDwgbl9wYWdlczsgaSsrKSB7DQo+Pj4+
IMKgwqAgZ250dGFiX2dyYW50X2ZvcmVpZ25fYWNjZXNzX3JlZihncmFudCArIGksIGRhdGEtPmJh
Y2tlbmRfZG9taWQsDQo+Pj4+IHhlbl9wYWdlX3RvX2dmbihwYWdlKSArIGksIGRpciA9PSBETUFf
VE9fREVWSUNFKTsNCj4+Pj4gfQ0KPj4+DQo+Pj4NCj4+PiBUaGFua3MsIHZhbGlkIHBvaW50LiBB
Z3JlZSBpdCdzIGluZGVlZCBtb3JlIGNvbXBsaWNhdGVkLiBJIHdpbGwgY29tbWVudA0KPj4+IG9u
IHRoYXQgbGF0ZXIuIEkgaGF2ZSBqdXN0IHB1c2hlZCBhbm90aGVyIGZpeCwgaXQgaXMgbm90IHJl
bGF0ZWQgdG8NCj4+PiBYRU5fUEFHRV9TSVpFIGRpcmVjdGx5LCBidXQgYWxzbyBhYm91dCBwYWdl
IG9mZnNldCA+IFBBR0VfU0laRQ0KPj4+DQo+Pg0KPj4gSSBnb3QgYSBsaXR0bGUgYml0IGNvbmZ1
c2VkIHdpdGggdGhlIG9yZGVyIHRoYXQgdGhlIHBhdGNoZXMgd2lsbCBiZSANCj4+IGFwcGxpZWQg
OikNCj4NCj4gVGhpcyBzZXJpZXMgc2hvdWxkIGdvIGluIHRoZSBmaXJzdCBbMV06DQo+DQo+IEN1
cnJlbnQgcGF0Y2ggZGVwZW5kcyBvbiBpdCBhbmQgbmV3IHBhdGNoIFsyXSBhbHNvIGRlcGVuZHMg
b24gaXQuIEkgDQo+IHRoaW5rIChidXQgbWlnaHQgbWlzdGFrZSkgdGhhdCBjdXJyZW50IHBhdGNo
IHdlIG5lZWQvd2FudCB0byBwb3N0cG9uZSANCj4gKGJlY2F1c2UgaXQgZG9lc24ndCBmaXgvaW1w
cm92ZSBzb21ldGhpbmcgaW1tZWRpYXRlbHksIGJ1dCBtb3JlIGZvciANCj4gZnV0dXJlIHVzZS1j
YXNlcyksDQo+DQo+IGJ1dCB0aGUgbmV3IHBhdGNoIGlzIGEgZml4IGZvciB0aGUgcmVhbCBzaXR1
YXRpb24uIE9uY2Ugd2UgZGVjaWRlIHdpdGggDQo+IG5ldyBwYXRjaCBbMl0gd2Ugd2lsbCBiZSBh
YmxlIHRvIHJldHVybiB0byB0aGUgY3VycmVudCBwYXRjaCBhbmQgDQo+IHJlYmFzZSBpdC4NCj4N
Cj4NCj4gWzFdIA0KPiBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDUx
NzQ4MjMuMTgwMDc2MS0xLW9sZWtzdHlzaEBnbWFpbC5jb20vDQo+DQo+IFsyXSANCj4gaHR0cHM6
Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIxMDA3MTMyNzM2LjIyNzU1NzQtMS1vbGVr
c3R5c2hAZ21haWwuY29tLw0KPg0KPg0KPg0KPj4gSUlVQyB0aGUgYWJvdmUgc2NlbmFyaW8gY2Fu
bm90IGhhcHBlbiwgaS5lIHRoZSBvZmZzZXQgdG8gYmUgPiANCj4+IFBBR0VfU0laRSwgYmVjYXVz
ZSB0aGlzIGNhbGxiYWNrIGlzIHVzZWQgdG8gbWFwIGZvciB0cmFuc2ZlciBhIA0KPj4gcG9ydGlv
biBvZiBhIHNpbmdsZSBwYWdlLg0KPg0KPiBJdCBoYXBwZW5zLiBJIGhhdmUgcmVjaGVja2VkIHRo
YXQuIEFuZCBjYW4gcHJvdmlkZSBzb21lIGRlYnVnIHByaW50cyANCj4gaWYgbmVlZGVkLg0KDQoN
ClRoaXMgaXMgdGhlIHByaW50IGluIHhlbl9ncmFudF9kbWFfbWFwX3BhZ2UoKSB3aGljaCBpcyBv
bmx5IHRyaWdnZXJzIGlmIA0KcGFzc2VkIG9mZnNldCA+IFBBR0VfU0laRSAoSSBhcHBsaWVkIGl0
IG9uIHRvcCBvZiBbMl0pDQoNCkBAIC0xOTUsNiArMTk1LDEyIEBAIHN0YXRpYyBkbWFfYWRkcl90
IHhlbl9ncmFudF9kbWFfbWFwX3BhZ2Uoc3RydWN0IA0KZGV2aWNlICpkZXYsIHN0cnVjdCBwYWdl
ICpwYWdlLA0KDQogwqDCoMKgwqDCoMKgwqAgZG1hX2hhbmRsZSA9IGdyYW50X3RvX2RtYShncmFu
dCkgKyBkbWFfb2Zmc2V0Ow0KDQorwqDCoMKgwqDCoMKgIGlmIChvZmZzZXQgPiBQQUdFX1NJWkUp
IHsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygiJXNbJWRdIGRtYV9oYW5k
bGUgMHglbGx4OiBvZmZzZXQgMHglbHggDQooZG1hX29mZnNldCAweCVseCBnZm5fb2Zmc2V0IDB4
JWx4KSBzaXplIDB4JWx4IG5fcGFnZXMgJWRcbiIsIF9fZnVuY19fLCANCl9fTElORV9fLA0KK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBkbWFfaGFuZGxlLCBvZmZzZXQsIGRtYV9vZmZzZXQsIA0KZ2ZuX29mZnNldCwgc2l6ZSwgbl9w
YWdlcyk7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBXQVJOX09OKDEpOw0KK8KgwqDC
oMKgwqDCoCB9DQorDQogwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGRtYV9oYW5kbGU7DQogwqB9DQoN
Cg0KQXQgdGhlIHJ1bnRpbWUgd2UgaGF2ZSwgZm9yIGV4YW1wbGU6DQoNClvCoMKgIDEwLjI3NzU5
OV0geGVuX2dyYW50X2RtYV9tYXBfcGFnZVsxOTldIGRtYV9oYW5kbGUgDQoweDgwMDAwMDAwMDAw
NDRhYTg6IG9mZnNldCAweDNhYTggKGRtYV9vZmZzZXQgMHhhYTggZ2ZuX29mZnNldCAweDMpIHNp
emUgDQoweDNhMCBuX3BhZ2VzIDENCg0KW8KgwqAgMTAuMjc3Njk1XSAtLS0tLS0tLS0tLS1bIGN1
dCBoZXJlIF0tLS0tLS0tLS0tLS0NClvCoMKgIDEwLjI3NzcxNV0gV0FSTklORzogQ1BVOiAzIFBJ
RDogMTIyIGF0IA0KZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jOjIwMSB4ZW5fZ3JhbnRfZG1h
X21hcF9wYWdlKzB4MTk0LzB4MWEwDQpbwqDCoCAxMC4yNzc3NTddIE1vZHVsZXMgbGlua2VkIGlu
Og0KW8KgwqAgMTAuMjc3Nzc5XSBDUFU6IDMgUElEOiAxMjIgQ29tbToga3dvcmtlci91ODo2IFRh
aW50ZWQ6IEfCoMKgwqDCoMKgwqDCoCBXIA0KNi4wLjAtcmM3LXlvY3RvLXN0YW5kYXJkLTAwMzUy
LWcwYzVlNDQyMzgyYmItZGlydHkgIzENClvCoMKgIDEwLjI3NzgyM10gSGFyZHdhcmUgbmFtZTog
WEVOVk0tNC4xNyAoRFQpDQpbwqDCoCAxMC4yNzc4NDBdIFdvcmtxdWV1ZTogcnBjaW9kIHJwY19h
c3luY19zY2hlZHVsZQ0KW8KgwqAgMTAuMjc3ODcwXSBwc3RhdGU6IDYwMDAwMDA1IChuWkN2IGRh
aWYgLVBBTiAtVUFPIC1UQ08gLURJVCAtU1NCUyANCkJUWVBFPS0tKQ0KW8KgwqAgMTAuMjc3ODk3
XSBwYyA6IHhlbl9ncmFudF9kbWFfbWFwX3BhZ2UrMHgxOTQvMHgxYTANClvCoMKgIDEwLjI3Nzky
MF0gbHIgOiB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKzB4MTk0LzB4MWEwDQpbwqDCoCAxMC40Nzcw
MzZdIHNwIDogZmZmZjgwMDAwOWViMzRhMA0KW8KgwqAgMTAuNDc3MDY4XSB4Mjk6IGZmZmY4MDAw
MDllYjM0YjAgeDI4OiBmZmZmMDAwMWMxZTBjNjAwIHgyNzogDQpmZmZmMDAwMWMwYmIzZjAwDQpb
wqDCoCAxMC40NzcxMTZdIHgyNjogMDAwMDAwMDAwMDAwM2FhOCB4MjU6IGZmZmYwMDAxYzBmYmFi
ODAgeDI0OiANCmZmZmZmYzAwMDAwMDAwMDANClvCoMKgIDEwLjQ3NzE2N10geDIzOiAwMDAwMDAw
MDAwMDAwMDAzIHgyMjogMDAwMDAwMDAwMDAwMDAwMSB4MjE6IA0KMDAwMDAwMDAwMDAwMDAwMQ0K
W8KgwqAgMTAuNDc3MjE1XSB4MjA6IGZmZmZmYzAwMDcwNDg4MDAgeDE5OiA4MDAwMDAwMDAwMDQ0
YWE4IHgxODogDQowMDAwMDAwMDAwMDAwMDEwDQpbwqDCoCAxMC40NzcyNjVdIHgxNzogNjU3MzY2
NjY2ZjIwM2EzOCB4MTY6IDAwMDAwMDAwZGVhZGJlZWYgeDE1OiANCjMwMzAzMDMwMzAzMDM4NzgN
ClvCoMKgIDEwLjQ3NzMxMV0geDE0OiAwMDAwMDAwMDAwMDAwNWQ1IHgxMzogZmZmZjAwMDFjMGZi
YWZlMCB4MTI6IA0KMDAwMDAwMDBmZmZmZmZlYQ0KW8KgwqAgMTAuNDc3MzYxXSB4MTE6IDAwMDAw
MDAwZmZmZmVmZmYgeDEwOiAwMDAwMDAwMGZmZmZlZmZmIHg5IDogDQpmZmZmODAwMDA5NjlhY2Mw
DQpbwqDCoCAxMC40Nzc0MDddIHg4IDogMDAwMDAwMDAwMDAxN2ZlOCB4NyA6IGMwMDAwMDAwZmZm
ZmVmZmYgeDYgOiANCjAwMDAwMDAwMDAwMGJmZjQNClvCoMKgIDEwLjQ3NzQ1OV0geDUgOiAwMDAw
MDAwMDAwMDU3ZmE4IHg0IDogMDAwMDAwMDAwMDAwMDAwMCB4MyA6IA0KZmZmZjgwMDAwOWViMzIz
OA0KW8KgwqAgMTAuNDc3NTA3XSB4MiA6IGFjZDlhYmYyYTYxZmM4MDAgeDEgOiAwMDAwMDAwMDAw
MDAwMDAwIHgwIDogDQowMDAwMDAwMDAwMDAwMDdmDQpbwqDCoCAxMC40Nzc1NTRdIENhbGwgdHJh
Y2U6DQpbwqDCoCAxMC40Nzc1NzBdwqAgeGVuX2dyYW50X2RtYV9tYXBfcGFnZSsweDE5NC8weDFh
MA0KW8KgwqAgMTAuNDc3NjA4XcKgIGRtYV9tYXBfcGFnZV9hdHRycysweDFkNC8weDIzMA0KW8Kg
wqAgMTAuNDc3NjM4XcKgIHZyaW5nX21hcF9vbmVfc2crMHg2MC8weDcwDQpbwqDCoCAxMC40Nzc2
NjhdwqAgdmlydHF1ZXVlX2FkZF9vdXRidWYrMHgyNDgvMHg3ODANClvCoMKgIDEwLjQ3NzcwNV3C
oCBzdGFydF94bWl0KzB4MWQwLzB4NTE4DQpbwqDCoCAxMC40Nzc3MzRdwqAgZGV2X2hhcmRfc3Rh
cnRfeG1pdCsweDk4LzB4MTU4DQpbwqDCoCAxMC40Nzc3NjddwqAgc2NoX2RpcmVjdF94bWl0KzB4
ZWMvMHgzNzgNClvCoMKgIDEwLjQ3Nzc5NV3CoCBfX2Rldl9xdWV1ZV94bWl0KzB4NWI4LzB4YzUw
DQpbwqDCoCAxMC40Nzc4MjBdwqAgaXBfZmluaXNoX291dHB1dDIrMHgyMzQvMHg1NjANClvCoMKg
IDEwLjQ3Nzg1M13CoCBfX2lwX2ZpbmlzaF9vdXRwdXQrMHhhYy8weDI2OA0KW8KgwqAgMTAuNDc3
ODc4XcKgIGlwX291dHB1dCsweGZjLzB4MWIwDQpbwqDCoCAxMC40Nzc5MDVdwqAgaXBfbG9jYWxf
b3V0KzB4NDgvMHg2MA0KW8KgwqAgMTAuNDc3OTM0XcKgIF9faXBfcXVldWVfeG1pdCsweDE0MC8w
eDNjOA0KW8KgwqAgMTAuNDc3OTYwXcKgIGlwX3F1ZXVlX3htaXQrMHgxNC8weDIwDQpbwqDCoCAx
MC40Nzc5ODZdwqAgX190Y3BfdHJhbnNtaXRfc2tiKzB4NDgwLzB4YWQwDQpbwqDCoCAxMC40Nzgw
MTRdwqAgdGNwX3dyaXRlX3htaXQrMHg1ZGMvMHgxMDQ4DQpbwqDCoCAxMC40NzgwNDVdwqAgX190
Y3BfcHVzaF9wZW5kaW5nX2ZyYW1lcysweDNjLzB4YzgNClvCoMKgIDEwLjQ3ODA3N13CoCBfX3Rj
cF9zb2NrX3NldF9jb3JrLnBhcnQuMCsweDYwLzB4NzANClvCoMKgIDEwLjQ3ODExM13CoCB0Y3Bf
c29ja19zZXRfY29yaysweDUwLzB4NjgNClvCoMKgIDEwLjQ3ODE0MV3CoCB4c190Y3Bfc2VuZF9y
ZXF1ZXN0KzB4MWQwLzB4MjQ4DQpbwqDCoCAxMC40NzgxNzRdwqAgeHBydF90cmFuc21pdCsweDE1
NC8weDI5OA0KW8KgwqAgMTAuNDc4MjA2XcKgIGNhbGxfdHJhbnNtaXQrMHg5OC8weGIwDQpbwqDC
oCAxMC40NzgyMzJdwqAgX19ycGNfZXhlY3V0ZSsweGIwLzB4MzM4DQpbwqDCoCAxMC40NzgyNThd
wqAgcnBjX2FzeW5jX3NjaGVkdWxlKzB4MmMvMHg1MA0KW8KgwqAgMTAuNDc4Mjg2XcKgIHByb2Nl
c3Nfb25lX3dvcmsrMHgxZDAvMHgzMjANClvCoMKgIDEwLjQ3ODMxNF3CoCB3b3JrZXJfdGhyZWFk
KzB4NGMvMHg0MDANClvCoMKgIDEwLjQ3ODM0MV3CoCBrdGhyZWFkKzB4MTEwLzB4MTIwDQpbwqDC
oCAxMC40NzgzNzFdwqAgcmV0X2Zyb21fZm9yaysweDEwLzB4MjANClvCoMKgIDEwLjQ3ODM5OV0g
LS0tWyBlbmQgdHJhY2UgMDAwMDAwMDAwMDAwMDAwMCBdLS0tDQoNCg0KV2UgZ2V0IGFuIG9mZnNl
dCAweDNhYTguIFdlIGFyZSBpbiB0aGUgcHJvY2VzcyBvZiBtYXBwaW5nIHZpcnRpbyANCmRlc2Ny
aXB0b3Igd2hpY2ggaXMgcGFzc2VkIGZyb20gdGhlIHRvcCBsZXZlbCBhcyBzY2F0dGVybGlzdCwg
YWNjb3JkaW5nIA0KdG8gdGhlIGR1bXANCg0KdGhlIGRtYV9tYXBfcGFnZSgpIGlzIGNhbGxlZCBm
cm9tIGhlcmUgd2l0aCBzY2F0dGVybGlzdCBwYXJhbWV0ZXJzOg0KDQpodHRwczovL2VsaXhpci5i
b290bGluLmNvbS9saW51eC92Ni4wLXJjNy9zb3VyY2UvZHJpdmVycy92aXJ0aW8vdmlydGlvX3Jp
bmcuYyNMMzYzDQoNClNvIHdlIGFyZSBub3QgZGVhbGluZyB3aXRoIGEgcmFuZ2Ugd2l0aGluIGEg
c2luZ2xlIHBhZ2UuDQoNCg0KT3IgSSByZWFsbHkgbWlzc2VkIHNvbWV0aGluZy4NCg0KDQo+DQo+
DQo+DQo+Pg0KPj4NCj4+PiBzbyB0b3VjaGVzIHRoZSBzYW1lIGNvZGUgYW5kIHNob3VsZCBiZSBw
cmVyZXE6DQo+Pj4NCj4+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3Jl
Lmtlcm5lbC5vcmcvYWxsLzIwMjIxMDA3MTMyNzM2LjIyNzU1NzQtMS1vbGVrc3R5c2hAZ21haWwu
Y29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhMzZDSjVTNVQ0N0hNaDlOcS0wV1ZVUFNsbkhqdmxVb24t
b29GR293YnZHQThCZFdTQ0M5bmlGMGZfYnR2aXRlMUc2TElSd3l3NlhzVTZQQW5Dak15OTJLaU5r
TUckIA0KPj4+IFtsb3JlWy5da2VybmVsWy5db3JnXQ0KPj4+DQo+Pj4NCj4+Pj4NCj4+Pj4+Pg0K
Pj4+Pj4+DQo+Pj4+Pj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGksIG5fcGFnZXMgPSBYRU5fUEZO
X1VQKG9mZnNldCArIHNpemUpOw0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBncmFudF9yZWZfdCBn
cmFudDsNCj4+Pj4+Pj4gwqDCoMKgIMKgwqDCoMKgwqAgaWYgKFdBUk5fT04oZGlyID09IERNQV9O
T05FKSkNCj4+Pj4+Pg0KPj4+Pj4NCj4+Pj4+IFRoYW5rIHlvdS4NCj4+Pj4+DQo+Pj4+Pg0KPj4+
Pg0KPj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 18:10:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 18:10:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418216.662962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogrnH-0006TU-8g; Fri, 07 Oct 2022 18:09:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418216.662962; Fri, 07 Oct 2022 18:09:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogrnH-0006TN-5A; Fri, 07 Oct 2022 18:09:55 +0000
Received: by outflank-mailman (input) for mailman id 418216;
 Fri, 07 Oct 2022 18:09:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PW8X=2I=citrix.com=prvs=2723e59b2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ogrnF-0006TH-Uk
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 18:09:54 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b35aafa-466b-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 20:09:52 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 07 Oct 2022 14:09:41 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SN4PR03MB6720.namprd03.prod.outlook.com (2603:10b6:806:1ef::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct
 2022 18:09:39 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Fri, 7 Oct 2022
 18:09:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b35aafa-466b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665166192;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=8zW/ySgS+9lnKtxD52Ap3bwv+jUBAFcFRypajQ4fiiY=;
  b=VgogzukGIu0tVY0aMouRFFVqsS7W6+XnAnYzeKtlZlakH1aOGObkWu+2
   sUq+UBbwuz7001pyAMT8WPLZSluB/e6TyII2e5RLW1t0Znaw9X65gRWvC
   PsEL/NV+Ikp3/UynOLc/UBLCMJ0/874hM8u+H+xje8DpoRi8+w0lPTQKV
   U=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 81866402
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ZEXkk60JRUTkdVqwkPbD5Qlwkn2cJEfYwER7XKvMYLTBsI5bpzYBz
 jEbWmuHO6zZNmrweoxwadnn9UsGupCDmtVhGwo5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GtH5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVE6LtpCG9zr
 sUDaw4GTE6xocKN7+OSH7wEasQLdKEHPas5k1Q5lHTzK6ZjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/F4/NpsgA/zyQouFTpGPPTdsaHWoN+mUGAq
 3id12/4HgsbJJqUzj/tHneE1rafw32nANh6+LuQ6uROh3CvmV4oJCZGaUee8eCykHyGcocKQ
 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3
 UPPmMnmbRRur7+9WX+b7q2Trz65JW4SN2BqTS0ZSQoI5fHzrYd1iQjAJv54C7K8hNDxHTD2w
 hiJoTI4irFVitQEv42k+XjXjjTqoYLGJjPZ/S3SV2Ohqwl/NIisYtXx7UCBtKgRaoGEUlOGo
 X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhkkTKu1Gq7ooQPUX
 XI=
IronPort-HdrOrdr: A9a23:sCQDD6jW3FUN1Rs8wokAuG7wIXBQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+
 O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.95,167,1661832000"; 
   d="scan'208";a="81866402"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=adwIheHNMlgIVqaNggpWUxkduE/5Ov8EJe7WYKub0ACYyyy3DV68p0G7NjWXRLdEAWLE7TWaPGKgfMaZkoD6gq8AcdKOzZlDPJ9pU6X2ZW7zScUnZ4orD3cVsh3g+sOV/9vsDMvVielDw/yKzT6WSoSKtDmE21FJW7ZBvby6KdGtIPx3jo/AHiyJq4N65c3fH3+uW8BO1x4NIqP0EcCzLAR5Fk3xIIWRV/d8+zPgTSUgkY7qmucqYGLB48XNwoOJQ4BjMmmR6dBxin7O5mf2RTQvOqrvRupv/chs1l6VJn2N2OBwjfgQeR0QRFnuvsT1nGQxmqhs4h5ehhWt2HBXtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8zW/ySgS+9lnKtxD52Ap3bwv+jUBAFcFRypajQ4fiiY=;
 b=PCffC4v/bSPtYdMCFYsdKtGnq+I1u7dRT+rw7iLNDP73txae4C/CvRC1KstIRIgAL/q/KsIqRyeda6CTKyYv/Tnh3sGUxWCD5OEwmPS8Molkol5aweXdQqEJXoqaSUWWQFUJftqWfW8oNzGrdjr6pgmnAT4R5rX8lcqQ9ITy10QJPRArcvfoCzZ9xOYpuqNbiHU/cSOKBwS9qG6XYQY35/zhOG5+UXqA/XuEj1cAQYhkFmT0M4vTFwn6jSTAB9fdTSprZB9sLjiiKMHmPC3IhNKmkNhgrlU2ChqZxo/CZ6uvLumdiufAezdZ73RgM53Wt67mhrRfoMOKoTTVKaFV8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8zW/ySgS+9lnKtxD52Ap3bwv+jUBAFcFRypajQ4fiiY=;
 b=AoguYWjEEvPfRC8K7NnRzvDROgtObbIrMcHlhBc1NgjT3EruRkrCo8b3CyfNm5Qz5ZX3GnJeFLImN6Nzjo/IvGTy1IJa/aprKZwXyB+m94VyG/PRtC85B+lR6e++EZCwQidR1lBUyd/c6KXzoHo7AooeSy+55qSyIuFcAAPWByg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 0/9] gnttab: further work from XSA-380 / -382 context
Thread-Topic: [PATCH 0/9] gnttab: further work from XSA-380 / -382 context
Thread-Index: AQHXmmIPP24RGEexIEa6TxPxC+1g3q4FcpIAgABIlwA=
Date: Fri, 7 Oct 2022 18:09:38 +0000
Message-ID: <25c2b0c1-d5fb-7a4a-016e-1d3192510d28@citrix.com>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
 <806fa06b-adee-caa5-0b6d-aaf1282fca11@suse.com>
In-Reply-To: <806fa06b-adee-caa5-0b6d-aaf1282fca11@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SN4PR03MB6720:EE_
x-ms-office365-filtering-correlation-id: 72d50bf1-7b5a-4e45-c177-08daa88f1985
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 eeazbK7oO+3rP0Q8+PHcufnIe14hrRJQqh7+5OlaGqIRdlqG6PoNAW5a6Jh0AXhJl5gSHmNrl89Mm1gCYSjoQ9vDNovxkJvWByz2NmLuQd2VTk4Lg4JNBub5CnRTE546PI11vd9ysk1QjuY7aoSyUBTzvTUcJLIFJNBSpuhgwVg8lOveIub6W69okKG70C9SR0EEh5W/rv8THGLXWMVE1Ov7Cx9DyNmXMUNGzga8dPmECdSCvY0onu8PpGMylqfmulFMTWyrJY/6oXgH+sxA7A9B2B67nBaBxhxe6sPpeyt9rfP/U4tZWxe0ySFSsA3ZsbXghU4vF9WC+rJWeHqi1M9Lpqdp6XSNBeYYJsP/W0yLod+oGhhBHFzrh4RAzhfxku0tCqukYP97j78BfvGiz03y7Pg3jBWUmKxsZurV7fCfvMGFQEmwiFEGN+7Jkw+90AxijWnppSRBpmYfc8GzqSkQj87mKfy038ZGfXxlBN4YaAx/VrxoBUAQQa5EW5VTo05c/zSB8gYl16XvjzAURHKA9xrC31CCAv6v/828FGoAVZV6vQkS2jB1dOzqTZyVcMhod4Lwd60kOwVUnr9XC9ww/QWZvWTJQo4C6L3s0Q/ULGrMfNiD/HD4CiU12tRsM9uSukGiuyWhMJPaW+ITBduer2zjHOv83pjpy/6wo9nQcXcovAsPcqB+cH6wb5DwuZljD3uYJ4m70+8osGUmMMQQqkVl1uWJc4HbHTqWbOXkw/n3gbnDHIH1KJA5kzHabX1UhSfNk4UjJGhZmE/wo6a86kje3PmRrLLWbNT0a7sGPSXJpnnhPdJUWJ18gVtwG8LBB7AP/gUDijgQHCa0fg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199015)(66446008)(31686004)(66946007)(76116006)(71200400001)(41300700001)(6506007)(91956017)(66476007)(64756008)(2906002)(66556008)(8676002)(5660300002)(2616005)(186003)(26005)(53546011)(31696002)(6486002)(83380400001)(4326008)(8936002)(86362001)(478600001)(54906003)(6512007)(110136005)(36756003)(38070700005)(82960400001)(122000001)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?TUlhd2huSU93ODYvSnBzSGFjSHZ0Q09kbEgrZm4vbXFuS0theElQZktxc2Vl?=
 =?utf-8?B?Z2RIcGFJalgwZXNxTHd2TVZDbUJPUXg4MjhSSFhSU1hSOE5nSUo4cGFBa0p1?=
 =?utf-8?B?TmZoOUN5bVNpRm4yMEtHRHZNZ2J2UExIZ21BT29hOTA5aFkwcVJaNGJjRGFh?=
 =?utf-8?B?QmxmZklLZHNZMXBrYktjMS9XbFY5dnh2T0t4QW9oYWYwWTRncklqeERnVTN6?=
 =?utf-8?B?S0wzR0RjbjhRRmJ2LzdJcjV4a0hkVG9odFBvWmVWandlRkFUMjJhOUVkU0hK?=
 =?utf-8?B?TVlORHZpRVRPbGUzOVRJUWN3R0dSbUV0Njd3RFdmNklLQ2k0YTYzQUpTaDBD?=
 =?utf-8?B?WTBCdGt3OE5DeFhMdk9Yb0h1ZkttTkRCZXlnTlg1YW5USThOcDlFai8yc3h4?=
 =?utf-8?B?cDhUQ3RVNVlreksyZ01NaW90M3ppRTRYUGhkb0J4U0NEQlVLdEloQmx0Wklm?=
 =?utf-8?B?ZUh0bzhyM1AwN2QrdVZIV2xOQmducktWM0Q1SE9uOHU4TEZ6aU14Y3FXZVNE?=
 =?utf-8?B?TTNtdjUzazdYUldZN3BpZmxQclNaK2hmaU9vUXlGNUw3T3E2T09tc3dWYjMz?=
 =?utf-8?B?TjBKazB6U1dpNndSemlFdFRRT005czNjd3FrL0tidWZXWjF5T1ZxVFBzblhu?=
 =?utf-8?B?L3g3TDlVZkJZeUNIY3pFUHk0VHFFUTR6aTRjNlNrcVZPNDMwVzAzREE2a2Fy?=
 =?utf-8?B?SStlSlFycDRzR1drSlYyYVFzVXgvTUlDb3VDdUw1ZS91RTJSdk9pdVhveitR?=
 =?utf-8?B?K3ZWSHVxVVd1OW9xSlZEczlkcTZFTFdDK0JzTDVLaDBjVjdTQVBoYjRLVGNh?=
 =?utf-8?B?RmsxbEJlRDdtbUMrOG9wSWk2YW8wdWdVTUlrTGxFOE1vRlZKRU8wTFM2RGRz?=
 =?utf-8?B?bjN5Q2RMdlFSU1ZncW0wRktVeDVRd3RoSlJHV3VaT1JUWUZiNHg0emFwRXZH?=
 =?utf-8?B?WHJKbFpRcDQxc1VqM1VIaVNkaE1POG83YWhiVFlLZThyS2lnOUl0WmRWQWhw?=
 =?utf-8?B?ajQ4TVh1NXdRendmY3pDZDcvT0JqSlB5YnVrbmdnbXlFeXUzMTRJZVBaOFhl?=
 =?utf-8?B?ZFV0VHU3eXZoR1NUU3NJUE42Um01Uys3eW5LU25icGJLazRiRUZXTUc3cWVT?=
 =?utf-8?B?RHZLM0xyQWpzVFQrQXR6N1BsSURFM0tCSjlVdnhKOWNpNGhvQkEvazR0YWRR?=
 =?utf-8?B?M1FqcThEVEp4ZW1QVjh2VGJ1YjFoY0hRZzhVdzhNeWZLTkZSSVZUUmRldU15?=
 =?utf-8?B?T3VxV2NKd1pvQ2NUWGd4Q3h0b1ZuT0pBalhacUFjTEJ1RWRUaDZmOEY1Ymgw?=
 =?utf-8?B?WXFVWTZsczczOVdJVm9BYjFWU3ZGYkRvYURTckRHVHErZEJWajBpallTcDRw?=
 =?utf-8?B?M21XRHl3ZHdxWUs5TmdwNW1CcURQK1lLWTNHNGp5elZ5OE1oSU9IVU1BdDZm?=
 =?utf-8?B?SW8rNERXcTArd1g1ck1pazVMWE5tdms1VlVCaXREUU93RFNxWHVBd3hpbkg1?=
 =?utf-8?B?T3d2L2RPRFg4RG9GWHNDUUxFR0ZNWTUreWllVXVvQXIvM1dlaWdKSHZybE5Z?=
 =?utf-8?B?MlhLTERrZjRsb0Q5cDNSWG1sL1N3T2kySnlZalQ4VVBHRGtGR0JEZWVLMVFH?=
 =?utf-8?B?d2ZjRDFJS2pMbHVraG5HTThmdkdsalhCVDhFZzdvQXdwQ3F3dUh6Z2NlV00x?=
 =?utf-8?B?TnZ6eVZ0VXN3Y2ZnbTNMTnRYZXJNbmVCUXI1anVDODU4QmFNeHRYUTJ3dTV3?=
 =?utf-8?B?RHZhRWFCbk1Ddk9WempZYU9ZOUo5SlBxanZGYldGSXBLRVlzSVU2UlV6bDFu?=
 =?utf-8?B?TWxRbVlRQVFQUHRHQlZJclVOZzZuNVpBMzEyOHZIbW1qRlltQ3Y2bS8zZ21z?=
 =?utf-8?B?N1RMcWlvamowQVBkb1RreHFMNitXaVBoTm1lRE1SY25xUGhmdEkweFlNUXgw?=
 =?utf-8?B?NVRDbmFGR1FmbzZQODdpVHV5NzZxT09BSTVERzVDYkZqc25SNkc5aUVvNUUx?=
 =?utf-8?B?dTlDNGJ5cVNBWmh6L2p2MzdoZlRCa0JoY2ZCcFRuZ3FITmVwUklvdnBpT0ZR?=
 =?utf-8?B?YjE1bS9Rd1psa0NCWjhxYVN3bTVPWGQrdXVmNUdWM09HTWdYeEVlRW9PdTdG?=
 =?utf-8?Q?qxDl0aFN9DgLGuLgFkAt91UJF?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4D5231C091E0C2428AAAB160C07B40B4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72d50bf1-7b5a-4e45-c177-08daa88f1985
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 18:09:38.7707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0VKyYybdif1MhVV+/Rg3a2AHRMpZgByf1wKsQ+S6AEacidw2OKVfgHAXhnrVyXaYz4j7rnkOgD/fdRZOnv+4MHtHuMi9idpkwvcMGe03vGA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6720

T24gMDcvMTAvMjAyMiAxNDo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjA4LjIwMjEg
MTI6MDYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gVGhlIGZpcnN0IGZvdXIgcGF0Y2hlcyBjYW4g
YmUgYXR0cmlidXRlZCB0byB0aGUgZm9ybWVyLCB0aGUgbGFzdCBmb3VyDQo+PiBwYXRjaGVzIHRv
IHRoZSBsYXR0ZXIuIFRoZSBtaWRkbGUgcGF0Y2ggaGFkIGJlZW4gc3VibWl0dGVkIHN0YW5kYWxv
bmUNCj4+IGJlZm9yZSwgaGFzIGEgc3VpdGFibGUgUmV2aWV3ZWQtYnkgdGFnLCBidXQgYWxzbyBo
YXMgYW4gb2JqZWN0aW9uIGJ5DQo+PiBBbmRyZXcgcGVuZGluZywgd2hpY2ggdW5mb3J0dW5hdGVs
eSBoYXMgbGVhZCB0byB0aGlzIHBhdGNoIG5vdyBiZWluZw0KPj4gc3R1Y2suIFNob3J0IG9mIEFu
ZHJldyBiZWluZyB3aWxsaW5nIHRvIHNldHRsZSB0aGUgZGlzYWdyZWVtZW50IG1vcmUNCj4+IHdp
dGggSnVsaWVuIHRoYW4gd2l0aCBtZSAoYWx0aG91Z2ggSSdtIG9uIEp1bGllbidzIHNpZGUpLCBJ
IGhhdmUgbm8NCj4+IGlkZWEgd2hhdCB0byBkbyBoZXJlLg0KPj4NCj4+IFRoZXJlJ3MgcHJvYmFi
bHkgbm90IG11Y2ggaW50ZXJyZWxhdGlvbiBiZXR3ZWVuIHRoZSBwYXRjaGVzLCBzbyB0aGV5DQo+
PiBjYW4gcGVyaGFwcyBnbyBpbiBhYm91dCBhbnkgb3JkZXIuDQo+Pg0KPj4gMTogZGVmZXIgYWxs
b2NhdGlvbiBvZiBtYXB0cmFjayBmcmFtZXMgdGFibGUNCj4+IDI6IGRyb3AgYSByZWR1bmRhbnQg
ZXhwcmVzc2lvbiBmcm9tIGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKCkNCj4+IDM6IGZvbGQgcmVj
dXJyaW5nIGlzX2lvbWVtX3BhZ2UoKQ0KPj4gNDogZHJvcCBHTlRNQVBfY2FuX2ZhaWwNCj4+IDU6
IGRlZmVyIGFsbG9jYXRpb24gb2Ygc3RhdHVzIGZyYW1lIHRyYWNraW5nIGFycmF5DQo+IEp1c3Qg
dG8gbWFrZSAib2ZmaWNpYWwiIHdoYXQgSSd2ZSBzYWlkIGluIHRoZSBjb3Vyc2Ugb2YgdGhlIHJl
c291cmNlDQo+IG1hbmFnZW1lbnQgZGlzY3Vzc2lvbiBhdCB0aGUgZXZlbnQgaW4gQ2FtYnJpZGdl
OiBJJ20gd2l0aGRyYXdpbmcgMQ0KPiBhbmQgNSwgaW4gdGhlIGV4cGVjdGF0aW9uIHRoYXQgZWFn
ZXIvbGF6eSBhbGxvY2F0aW9uIG9mIHJlc291cmNlcw0KPiB3aWxsIGJlY29tZSBhIHByb3BlcnR5
IHRvIGJlIGhvbm9yZWQgdW5pZm9ybWx5IGZvciBhIGd1ZXN0LiBXaXRoIDIsDQo+IDMsIDQsIGFu
ZCA2IGFscmVhZHkgaGF2aW5nIGdvbmUgaW4sIGl0IHdvdWxkIHN0aWxsIGJlIG5pY2UgdG8NCj4g
KGZpbmFsbHkpIGhhdmUgZmVlZGJhY2sgb24gLi4uDQoNClRvIHRoZXNlIGlzc3VlcyBpbiBwYXJ0
aWN1bGFyLCB0aGVyZSB3YXMgc3BlY2lmaWMgd29yayBkb25lIGluIDQuMTYgdG8NCmFkZHJlc3Mg
dGhlIGltcGFzc2UgaW4gYSB3YXkgd2hpY2ggZ290IHRoZSBzYXZpbmdzIGluIG1vc3QgY2FzZXMs
IGJ1dA0Kd2l0aG91dCBpbmNyZWFzaW5nIHRoZSByaXNrIG9mIGhpdHRpbmcga25vd24gYnVnZ3kg
cGF0aHMgaW4gZ3Vlc3QgZHJpdmVycy4NCg0KDQpGb3IgcGF0Y2ggNSwgdGhlIEFCSSBtYXggdmVy
c2lvbiBpcyBub3cga25vd24gdG8gZG9tYWluX2NyZWF0ZSgpLCBzbyB0aGUNCnN0YXR1cyBhcnJh
eSBhbGxvY2F0aW9uIGNhbiBzYWZlbHkgYmUgc2tpcHBlZCB3aGVuIGdudHRhYiB2MiBpc24ndA0K
YXZhaWxhYmxlLg0KDQpUaGlzIGdldHMgdGhlIHNhdmluZyBKdWxpZW4gd2FudHMgb24gQVJNLCBh
bmQgb24geDg2IHdlIG91Z2h0IHRvDQplbmNvdXJhZ2UgcGVvcGxlIHRvIHJlc3RyaWN0aW5nIHRv
IHYxIHdoZXJlIHBvc3NpYmxlLCBzbyB0aGV5IGdldCB0aGUNCnNhdmluZ3MgdG9vLg0KDQoNCkZv
ciBwYXRjaCAxLCBJIGFncmVlIHdpdGggdGhlIG9ic2VydmF0aW9uIHRoYXQgMTAyNCBtYXB0cmFj
ayBmcmFtZXMgaXMgYQ0Kc2lsbHkgZGVmYXVsdCB0byBoYXZlLsKgIEFkanVzdGluZyB0aGlzIGFw
cHJvcHJpYXRlbHkgd2lsbCByZXN1bHQgaW4gdGhlDQpraW5kIG9mIHNhdmluZ3Mgd2FudGVkIGlu
IHRoZSBwYXRjaCwgd2l0aG91dCBtb2RpZnlpbmcgdGhlIGh5cGVydmlzb3INCmRpcmVjdGx5Lg0K
DQpXZSBzaG91bGQgaGF2ZSBhIHBhdGNoIHRvIHhsIChvciBpcyBpdCBsaWJ4bD8pIHRvIG1ha2Ug
YSBiZXR0ZXIgY2hvaWNlDQp0aGFuIGJsaW5kbHkgcGlja2luZyAxMDI0Lg0KDQpIYXZpbmcgd3Jp
dHRlbiB0aGlzIG91dCwgc29tZXRoaW5nIGRvZXMgc3RyaWtlIG1lIGFzIG9kZC7CoCBUaGVzZSBs
aW1pdHMNCmFyZSBzcGVjaWZpZWQgaW4gZnJhbWVzLCBhbmQgZm9yIHRoZSBnbnR0YWIgbGltaXQs
IHRoaXMgZXF1YXRlcyBpbnRvIGENCmtub3duIG51bWJlciBvZiBncmFudHMuwqAgQnV0IHN0cnVj
dCBtYXB0cmFjayBpcyBpbnRlcm5hbCBYZW4sIHNvIHRoZQ0KdG9vbHN0YWNrIHNlbGVjdGluZyAx
MDI0IGZyYW1lcyBjYW4ndCBrbm93IGhvdyBtYW55IGdyYW50IG1hcHMgdGhhdA0KYWN0dWFsbHkg
ZXF1YXRlcyB0byBpbiBYZW4uwqAgUmlnaHQgbm93LCAxMDI0IG1hcHRyYWNrIGZyYW1lcyBlcXVh
dGVzIHRvDQoyXjE4IG1hcHBpbmdzIChJIHRoaW5rKS4NCg0KDQpGb3IgdHJhZGl0aW9uYWwgc2Vy
dmVyLXZpcnQgVk1zLCB0aGV5IGNhbiBoYXZlIDAgYmVjYXVzZSB0aGUgZnJvbnRlbmRzDQpzaG91
bGQgbmV2ZXIgYmUgbWFwcGluZyBncmFudHMuwqAgV2UgYWN0dWFsbHkgYWxyZWFkeSBkbyB0aGlz
IGZvciB0aGUNCnhlbnN0b3JlZCBzdHViZG9tLsKgIFRoZSBzYW1lIGlzIGFsbW9zdCBjZXJ0YWlu
bHkgdHJ1ZSBmb3IgcWVtdSBzdHViZG9tcy4NCg0KRm9yIFZNcyBpbiBhIGJpdCBvZiBhIG1vcmUg
aW50ZXJlc3RpbmcgY29uZmlndXJhdGlvbiwgZS5nLiB3aXRoIHZpcnRpbywNCnRoZW4gdGhleSBu
ZWVkICJzb21lIi4NCg0KRm9yIGRldmljZSBkcml2ZXIgVk1zLCB0aGV5IGRvIG5lZWQgYSBkb20w
LWxpa2UgbWFwcGluZyBjYXBhYmlsaXRpZXMuDQoNCkVpdGhlciB3YXksIHRoZXJlIGlzIGRlZmlu
aXRlbHkgcm9vbSB0byBpbXByb3ZlIHRoZSBzdGF0dXMgcXVvIHdpdGhvdXQNCmltcGFjdGluZyBy
dW50aW1lIHNhZmV0eS7CoCBJZiBwYXRjaGVzIHdlcmUgdG8gYXBwZWFyIHByb21wdGx5LCBJIHRo
aW5rDQp0aGVyZSdzIHByb2JhYmx5IHdpZ2dsZSByb29tIHRvIGNvbnNpZGVyIHRoZW0gZm9yIDQu
MTcgYXQgdGhpcyBwb2ludC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 18:24:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 18:24:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418224.662972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogs1R-0000dh-Eb; Fri, 07 Oct 2022 18:24:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418224.662972; Fri, 07 Oct 2022 18:24:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogs1R-0000da-Bv; Fri, 07 Oct 2022 18:24:33 +0000
Received: by outflank-mailman (input) for mailman id 418224;
 Fri, 07 Oct 2022 18:24:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PW8X=2I=citrix.com=prvs=2723e59b2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ogs1Q-0000dQ-5R
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 18:24:32 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 477167e0-466d-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 20:24:29 +0200 (CEST)
Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 07 Oct 2022 14:24:26 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB4959.namprd03.prod.outlook.com (2603:10b6:208:1a3::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 18:24:23 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Fri, 7 Oct 2022
 18:24:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 477167e0-466d-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665167069;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=FiRCk3Y/NObYQimek7mR4D1ZlH2EpOD+gibFR2m8lis=;
  b=WzMUjRKVPkat/D3xPekp7ffOETE40rDsBwANjygL0OW9jY7GaBVXLWLi
   DfN8/v0LvFIgVLbHNp37PnU8A2C8j31X+uLpLAOnubeU4ebBJrnWpcg4m
   fpbJvm/pL5Vl4eri/mVSTFFsGJje4wFPVeMYWYkz9ophrxiYXIhrDVNMP
   c=;
X-IronPort-RemoteIP: 104.47.56.170
X-IronPort-MID: 82241758
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AoJQ/UqykBx2GsqYRQON6t4n5zX0fS1M+Zkaij?=
 =?us-ascii?q?kTw14qbGYmMLcPOrxiLQjTXvW5WxI8XJcG4SpgwjnZAGzTh9pmuRSG8MG3qt?=
 =?us-ascii?q?OxfgcBBnHBoNelWH2QmE+eZMoxCFCeqqBMByRJRY04IJcp5V3XXbqvlQFmpi?=
 =?us-ascii?q?BbEbdW9en4LWj7smpYBGba0kFjq/Wp8AHgmszjG/sgnm/LezZO/HL1ujS/Jy?=
 =?us-ascii?q?0FPFlyiifuutNrbikIgvHESZZ0YLKRHX4K7Qk832uHIYpqDB6M/4VriAa+G6?=
 =?us-ascii?q?ea3XXI/zRdZJ2Fkg8ZKvrBtPNKxWUip9q0CFvERvgL714PwVQTyjjBpWA9XV?=
 =?us-ascii?q?fHH8xZo6viNvLFJAybQ3fv8EaP8U+APlGvluvjE5b2ieAp6WhW2lxGS9+pLP?=
 =?us-ascii?q?h7Xw7HfeYzYuXgz7lbKCjVHdF1dNdkSkwGGe2pCATlVRSv4CkCsaEuqhCkS1?=
 =?us-ascii?q?fAEuNsLPYQ/V31YECmMxsSm3j6CQWqfQ8aYnM50vSD1OpS11it6VHWpjbY9P?=
 =?us-ascii?q?xD1jPuOknwckZnztARLQD6VtgBhJJF+axBM8OR40Th7xpQH4NT/SyqDBNQQa?=
 =?us-ascii?q?KD1xkHSj6jMQrSPwhFgO0LtNdD3lZuiyd5w4/aVqJwjCp2NrJ6L/ghj5PgXe?=
 =?us-ascii?q?AygI4+OmOL8RPQ6lHewgAkzUYx9wY5dWWeI+6uz0cqklum/gZB/nxpC1QS/E?=
 =?us-ascii?q?vwJD7J18C50xuvS/xFFOB/czcnu++R3NZ0XrP3L/qyLxriWfD5OOHKgNEaKc?=
 =?us-ascii?q?ZHYF0k2WUufngtT709AcFBGfpCh5Bd8WQdH6yhhBMXcdWldRlE4KGsvGSEWx?=
 =?us-ascii?q?GXBlSv0DElRQTP39e9TBPmC2rDWyBTb8JaCpD3I9hIkogF+Qh7ZmzneC2loX?=
 =?us-ascii?q?NA3oG/l+YnWGjKzaV56qThSIbZKm0jCuqBIyC38pWERrZnM24RBonzNlohA1?=
 =?us-ascii?q?HQ7phtOcBwOmNIA8EuLuwZzp6pAwoPFAfEJC+4m2VZVPxfPZlrMKT6d5BX00?=
 =?us-ascii?q?xEpn/5xRT1VAWSbtphsELuiyNCFUEHMmLuAAjWOickA2wgZ7tQw0nTk2PTXL?=
 =?us-ascii?q?phkIhVUbChRwbNh/fm1ppBDLLhEnr9IzlYfE9FJjAPE3QmFFhJZBntgaM59s?=
 =?us-ascii?q?oVlTwrreXxEZ/YQMRITkWL3fUq8TrZOkvTh2YnAuUpU7Qx/IWrPmJhBuaedy?=
 =?us-ascii?q?mGMZDCi6pF1UGoZUhXEB1rUkwALllr674VKL12ap7mB/I9dOjjwmuxlQh5ub?=
 =?us-ascii?q?jfvQDqhaEDYNoifAeWGiCJlIhVVdF1pPvUfClGzV9z/YKOx2M6FLxMvxhLy3?=
 =?us-ascii?q?+JW4bqqWy+qltlqvtAkdeoVXGtxQmrD/FfIikR2bNWUpkvel6OlX+gcGJ24x?=
 =?us-ascii?q?e6ktxTTt+DeWfg08JPYy5ZqDZxuIfMEtCYWBrHrHAAyPvvTicWccYat2zJ2C?=
 =?us-ascii?q?34GgACxpUGlNHztXxPelviZjR54NdyxooR7ognlhT2DVCNiArNnsRxzMakIa?=
 =?us-ascii?q?gB5/WMUX4Yxzoq74EhRlye4PVSbgzUiyZMFJc1qxfXtwPpX36fnN00eAyQsK?=
 =?us-ascii?q?I5lauqNGPIIYbG+cJJJXXCj4f6IBcfu40qZjpz8UZfKsJ9T6er7KIy6Jb7vO?=
 =?us-ascii?q?jLZ6riPXQu+E0/lZtii83+9gtRbC3zZRPPf/h6yyVj6k8WcGv/Oh6L0kFyvA?=
 =?us-ascii?q?UCa5T3XzrYc80fUnw3lMRYwXVcoIQrvPzdrZhizppEXFUTNlMI0mO9TIC42H?=
 =?us-ascii?q?LJjZJezaP2r+G2BjhvhxEo+byhnbc78QYgQ6CM9FZ0FPJMC6ZENe1Q+YGj+n?=
 =?us-ascii?q?084KpfCMubK2z3UsTiwSML9klv9gmGLSshRs7ityrfcKPmSCctl8eMzdWrCs?=
 =?us-ascii?q?weU2kbmXZCtFYLM925ebCOg1jKspdL0MYwBXKc1riytVOdE0xUl3AOLYnjju?=
 =?us-ascii?q?8Y8v1YCOVeYjR6wvm5RCWNR2V3AvExhugGWt4lXRzkrseCB/uR7t1Z7JU2hO?=
 =?us-ascii?q?+5/cTH0yvLNIxOIxswOASXX3b2X0uRQXLRVCUmpkRIQ8FUKl/1yYy5jIxDZR?=
 =?us-ascii?q?w6E8/V84kTay1pT79qiZiKdlBuIG+v76n7P3angNnItPVogiMXg6z2daQcA7?=
 =?us-ascii?q?juE7v49SDh9RLbehKoVjVzQg83fOU9VLEwfzFL08g0eyn+qIPwVUxdf0JXlz?=
 =?us-ascii?q?GvowuP51ogCZdiflBGY5evmF/Kf3i7OI8YFgxWKl1bhoQvClr/hnoZadyRyr?=
 =?us-ascii?q?jAslFXWB87QAJszQP2O76x2BtTn+tY1vDxAPC8GEx6fyNUhbfPiZ6dAcgX/+?=
 =?us-ascii?q?rc8Z4TefhY/zSvHxFd92GBcHY0a/cyzHHvcql4YYhdK8zD1cizy3i52g7DlR?=
 =?us-ascii?q?HnSkKuv72MLCnJ1mYgo8fP+nQP5GsZoG5TjMgu0SPxoICWG8jhf6VKtZ/SXg?=
 =?us-ascii?q?UdfKGx8+/QqL88gQu/4x8173UOPU/Nucwr1VHvuY8eGYmdu3QppE9LbvGojG?=
 =?us-ascii?q?ezgbxzdbKAwEY4TIJoQw15zmEsPACxxwISCJxrb0jKhvT8LSIADvL16VzmSl?=
 =?us-ascii?q?xxE6Fs5AR0Vnuj1uKTQnapuwwihQuJ9yEDSamsii8WlrnCCFOz5P2iIgEHbG?=
 =?us-ascii?q?O9mUJdEmC09vfjtJ9GJpavSLrRi5jwEda4I?=
X-IronPort-AV: E=Sophos;i="5.95,167,1661832000"; 
   d="scan'208";a="82241758"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B/HYTodbG6cL9pE3tLtSWeAH/m77vd9gj+Nk16AnQZO3/X9yK9Aw5FazJqMTn2r9dfdnkFccE8flq3f5rWU9D3QMJVYyAelR0mRdCevLDwuezMW2Tde6mR0ZObxl0+7C2TNVEmEB8EhuVX2t6bEDl71VRnj4b0POXUiwfNiZfcbwcF/jKXlBJ6j2wdu4BavbghqVae97zaPIS772CNRO6wsAbIH0ozN70Uuf8biHMMkFZw/7zAzND5WKqwvgx0bxjhWZN0+LuTi+JmUCJyY4AetlRL3S0ibTyBDN/X4AdI9ORXI7bwRjH+SmidKmeqQ+TAcE0p52zdKYSdIB4EB/2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FiRCk3Y/NObYQimek7mR4D1ZlH2EpOD+gibFR2m8lis=;
 b=j4PFLe1rh4GO4FNS+9Ld10WwAAoTzHq7HTRk+2idPSI+561DGJeUP2Yk94b4xMB3Q1MF8+b2RNflZsT90dxQiB4ZO8nwCsxNs8jDfBCNeAuJ4GfvyXDHegv7vePW2CGofW16wJVXjA20w7Ap6lDWN42iHPvuvC1mSHPBnYk9z/tqFj3Rm9z9Ag38S3G0/DWKoDJSETYWTe691ULoAdBN0iagEcNThxybCWgR1YGqsaEDupKr/d9TCNVJAqWZ0u+xiTxP2l9OXLo8oV5fa2CvZYABUu2LGMVOcy7JHmWq4+weNLZyWbwj5mgpIcCKEAyygUYjtpQPk9qohqE+ZrhImQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FiRCk3Y/NObYQimek7mR4D1ZlH2EpOD+gibFR2m8lis=;
 b=XymrT3Gr/QGO0j0wXNHqtdt4zALUkM65luL1IUsAZQY6VM2zq51kjmkQ6WU7MOVxlrkbGgI5KrYb5YOtqKHOhWb0T89mb4d0p1kQQZ2OHB+qZLRRfC7HPDvbkKUdye96mqoo+e2TYrOb0NhVPUUVd7aVwpjmVwE6EzV9SWNEKzY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 7/9] gnttab: no need to translate handle for
 gnttab_get_status_frames()
Thread-Topic: [PATCH 7/9] gnttab: no need to translate handle for
 gnttab_get_status_frames()
Thread-Index: AQHXmmM3wQfSlkpB0kOBlQDRimPR0q4Fv0QA
Date: Fri, 7 Oct 2022 18:24:23 +0000
Message-ID: <f797f122-2fd7-3acb-3c0b-ec790c16be0f@citrix.com>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
 <ed6a8403-dc91-05c8-25e5-81b5fb706cc2@suse.com>
In-Reply-To: <ed6a8403-dc91-05c8-25e5-81b5fb706cc2@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB4959:EE_
x-ms-office365-filtering-correlation-id: 8bd02edb-c816-44dc-79b9-08daa89128a6
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Kw9HKKaTPgtBmFrZf43lTIF/P5CP0Ff5/8pyLiE7TFP34dwnaW9gpy0r53B4ZiBAt+8YTKPC9i0L6pqMaSZqDO9A3q2SOY5cPBBwLQLyR1e+ttsaRuVapd8+8em3LtwW3UH2z5TcT/D2Ewl4MeGZ4ZTBjvNhR206PjjIczCSqxr1cYrObYIpKRoZMw7xWUE+l6vbCgHkiO50t0GirJy813FvdyAf8nfosC2vuI6ptZO4yk2PYLwmQaj2kq+iP8AAZ4MBotGlqY5JehrAYfJOLmEuitgKHllrgStQpwzL9JlEdantva0fRIteII5VRopvzSR8ErQQhJd2FYBT2fTAz2V1carnXJiHN8IRrBhQC2+6WK1vKEdJCgx9IitPteE+/+oNjiBvukTEiJm7XptoB/0/TrccW5ahEmEV9qjjt88sPNQHe/o6bZ7NPYUxF0pnYCl+tkJ1iG9+tdL067QlhWlX0IuIXbkL45E+ZEXxB0XsIFS5oBBs8IJiaJvdvAnchz4CJMeaL5Ul9OiXguzMbAlmtqHjznU5P94VHdxjpHxTpEfWrxl+GpicMkLsVQ62igFrzbow+Pa0Nm2HN9Tl6qL6B9sA9uiUGS0Gb6IkfkSXASvS70POngvUITqWNzGRomBXOaqTX+6HgAR6/B1qFidW0g80niCHQ80zNQow2CjWPkd+qH3T5nzxZAM3449zqGaFN5PYU7H5AYsqSPfmFw8WBGYtIzieuYpV2fpfZ+VWnqOJPyZDBojLnVnc/VGmj+VGcIl46Ti2PgP273DIm4KyTiSDHilPnYJTZpLpF6kSmGhhRQnStvgQewXdU4pK2fubW4PCdP2G57FbmSvV+g==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(451199015)(2906002)(4744005)(4326008)(91956017)(64756008)(66946007)(66446008)(66476007)(66556008)(8676002)(41300700001)(8936002)(5660300002)(76116006)(54906003)(110136005)(316002)(122000001)(86362001)(82960400001)(38100700002)(2616005)(6506007)(53546011)(478600001)(6486002)(71200400001)(36756003)(26005)(6512007)(31686004)(38070700005)(31696002)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MHlGZjFSM1haMGlXR21xTmZtZS9yMWdGbDI3MnZXdlRVZThyQlViZ3VFWTBH?=
 =?utf-8?B?Tyt0K0ZJaUVnMVhTQ1huRkpoRGdXeWMzOE1UNGtDNUh4NUZyUVdJQWJTS0wv?=
 =?utf-8?B?RlJQMTh5M084bnVRbDh6ZmYyVnF1S3ZYWjV0aHd3RExvYy9FOEIyRXpSYnRT?=
 =?utf-8?B?L1ZjTmdQQ04vWndtRUhoa0Ixdi8yamRkb3R1eXlEakE5cTdjV1h2eE5ReXBM?=
 =?utf-8?B?eGRDb1ZBRG5VWVg4NmYxazVrUGNoK3FDbUREd0RVU3NibEtEMUdBL3MrUS9S?=
 =?utf-8?B?UkY4MG5QUXNsSml2TG5ndUx2N1lFZ2VBZU95SldrODhBQnFXdFB1TUZzZnN0?=
 =?utf-8?B?bkVtcUJCUzBLTUdiRWpFeU10c0FkTkdTVmpLSWJBODNHc3FSK0ZGeEFmZUJ6?=
 =?utf-8?B?RTE5cEZ0SFJCaC8zSmpxRmtoWTBWd3ozMzFnWDNSYlI2NmtUWnBSNHlxY2ZF?=
 =?utf-8?B?aXg1NW1WQ0lVNGc3NUVVM1pvQTFJNlU2QjJOWmdXbGF6S09TR3ZOdWc3V1VG?=
 =?utf-8?B?eC9QcXlETTZZQTZFakV3V1Vhc3FsNVRUMlBqeTNnamgreTVzNXlvSWx4VFh6?=
 =?utf-8?B?R0JuWEJXdnU3N3pkZzlORGdlOE90Ly9Fdm85RDVSWE9LN2JPS3lXK1B2S3Q2?=
 =?utf-8?B?M1RXV3JoU1NXSlNENHhqamZvSDhEU2ZpejlZU0Z1MHhrTnlPdmd4dkc0NGc0?=
 =?utf-8?B?bXFPSGxGRDkrS0luRytnUk5VaXBKVnlLNkhDTi8wV0FrUjVRbDVKd01vSVVM?=
 =?utf-8?B?anZOank1MzdDdW1SRDhrWUd5UnFHcXBNdGc1S1JyM3F3allCZWFzTnF2SkpU?=
 =?utf-8?B?T0oxMkVhSmc5b0k3dkNRTmZPTU5COUtra1BvOXBreFJHN09JU2FTdWJKWGhs?=
 =?utf-8?B?N1pxS1poVmRqbVFzL29vOTNYcGIvbUZ5NmsvUmJZQ0d4aXFIMnQ1QzBLQXM2?=
 =?utf-8?B?bFNHcDFleEl2VDJSZFozb0VEUWtWWFlObFY3dEY2UFFjWDRIZTNKTUx4Mzhs?=
 =?utf-8?B?VlFzby9JN3A1REZJUE91b0cxeGVrZDg1a28yb0ppMTg4YnIrdmRUclU3d1dM?=
 =?utf-8?B?WHNKVnJEUlN3YnYrQXVsNkVLM00rTzhoL0p3MmV5YUhiV09JRzMrTzEzNGk5?=
 =?utf-8?B?SWtnakEyVnNSTmltZGN4MENmSVZkQzRvbUJUSldXN0c1emhvUVFHelBWN2Jn?=
 =?utf-8?B?YXlIeWdDRFFIbGVLcm5ZamR4VVVUazNHVndlaFhKa3RKc1BXRUh3UUdlS3hh?=
 =?utf-8?B?MWlaSk93ZUV0SExHZHZadWd5R3FaVXoxS1EyRnFJY2dYZDhHcFYzNmU5KzBs?=
 =?utf-8?B?Nmp1b1lCc2N2elZRV1AvWWN1S1ZGNGtqanR2ODVvaXdJUnpoVXFyQ0doeXlT?=
 =?utf-8?B?d1oyTTdpemtFUkNQOFRUR05YWUJnbjJCZ2Uvc1htMjFQV0hVS1J1U3h0Tm9G?=
 =?utf-8?B?QWgrZkxYOGNkb3RYQ1NQMGhuQ1hKT2t4ZWVOSEcrL2VleEFOTVEvdjZ3QkRJ?=
 =?utf-8?B?N3k2cEJ4cVM5WkhMeWdJQjJKbU9FVFUzOWpBcnNsRlVoVnJJd3BiZ3k5TEJn?=
 =?utf-8?B?bVpycmYyYmlLbGdHUGtpS012cFZOcXpKdFRXVllnYjlzTGIxcmdsZ1Zicitl?=
 =?utf-8?B?OVdHZU9OUGxkaHc3Y3huclFxdStnS0V5K3lmVmt6eThvWU5sQU0zQmdUZFJH?=
 =?utf-8?B?SGp6QVEzZXhyTDJvSU1XQTFKcnJYeUIzZUhHUVprZWlPbmtMeHJUV2gzQk1M?=
 =?utf-8?B?NkNCR2hwbVNXRmh6V3o4MVJXSDJrSnZaWUp2dlFhRm9MWWNCVlplTDV1QlRl?=
 =?utf-8?B?L2dicWlKSVNiNHh0Q1lPbzk4eEcwKytCdXl0OS9ZOXpUdyswa001NlhoL0ZE?=
 =?utf-8?B?M1BPUWhBeTFwVU5oZGxFTEJCUXp2MlEyWXBmNUhFdzAwNWllTXZibUFvbFd1?=
 =?utf-8?B?cnZMQ3h6QlZOOHUxVG9rUFNaN2NlYkZRMVViQXFGaTczUGNvRUE2dUF6VjBQ?=
 =?utf-8?B?VE96bjFibzFOVklNYjFyUitCdnZESzB6c0VwYmpMSEdkbnJ5blNVS1IrVmdQ?=
 =?utf-8?B?Um5oWVVOYytIbnYzYWZRWHp5eG1rSmVIQzJUNC9QWFc0Q1Rydi96aE56L3A0?=
 =?utf-8?Q?yc5E86TLH3VEsb56CoS8Nws9o?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BDE4437F81138140950F0C3ACACFA54D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bd02edb-c816-44dc-79b9-08daa89128a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 18:24:23.1600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r8PyrBY0f3frxxcbkVBmcMQWm9kzJMLjjFocv1qFq/5OZE2/IFSzVcSZYKsNQ2TBXn6MBvCR4f6BIG3TOgRtRMFU2+JG3HW9CHQ+pNcDBOw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4959

T24gMjYvMDgvMjAyMSAxMToxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFVubGlrZSBmb3IgR05U
VEFCT1Bfc2V0dXBfdGFibGUgbmF0aXZlIGFuZCBjb21wYXQgZnJhbWUgbGlzdHMgYXJlIGFycmF5
cw0KDQoiR05UVEFCT1Bfc2V0dXBfdGFibGUsIG5hdGl2ZSINCg0KQnV0IEkgdGhpbmsgaXQgd291
bGQgYWxzbyBiZSBjbGVhcmVyIHRvIGZvbGxvdyB3aXRoDQoNCiJmcmFtZSBsaXN0cyBmb3IgR05U
VEFCT1BfZ2V0X3N0YXR1c19mcmFtZXMgYXJlIG9mIi4NCg0KPiBvZiB0aGUgc2FtZSB0eXBlICh1
aW50NjRfdCkuIEhlbmNlIHRoZXJlJ3Mgbm8gbmVlZCB0byB0cmFuc2xhdGUgdGhlIGZyYW1lDQo+
IHZhbHVlcy4gVGhpcyB0aGVuIGFsc28gcmVuZGVycyB1bm5lY2Vzc2FyeSB0aGUgbGltaXRfbWF4
IHBhcmFtZXRlciBvZg0KPiBnbnR0YWJfZ2V0X3N0YXR1c19mcmFtZXMoKS4NCj4NCj4gU2lnbmVk
LW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTog
QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 18:25:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 18:25:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418231.662984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogs26-0001Lm-SL; Fri, 07 Oct 2022 18:25:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418231.662984; Fri, 07 Oct 2022 18:25:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogs26-0001Lf-PW; Fri, 07 Oct 2022 18:25:14 +0000
Received: by outflank-mailman (input) for mailman id 418231;
 Fri, 07 Oct 2022 18:25:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogs25-0001LN-Eg; Fri, 07 Oct 2022 18:25:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogs25-0000EK-CV; Fri, 07 Oct 2022 18:25:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogs24-0001Vn-Qq; Fri, 07 Oct 2022 18:25:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogs24-0002m2-PV; Fri, 07 Oct 2022 18:25:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XFSKPCTa8eXb3+MEb3SG7hGLRLsqlrWnI+cEeOjOGAc=; b=0d6RiNA/QNQQUflIETuvlZ9tzf
	1J9vkouAOJILX/BAfSuf9HMZ0riVg3gUOg8fbebP4JGLrVbixibzeNbscNWbUqxST7Hi7sKmBbvJI
	e9VKp+xb8mzgjT6Eb3ZUtdIePCF9BXtOrceyPjxd7KnNYhovUNgU/bEHKHppwOdJyCeY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173456-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173456: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl:host-ping-check-xen:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4c86114194e644b6da9107d75910635c9e87179e
X-Osstest-Versions-That:
    linux=ffb39098bf87db327b2be4b5c6f1087bcba94ce9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 07 Oct 2022 18:25:12 +0000

flight 173456 linux-linus real [real]
flight 173460 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173456/
http://logs.test-lab.xenproject.org/osstest/logs/173460/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl          10 host-ping-check-xen fail pass in 173460-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 173451
 test-armhf-armhf-xl         15 migrate-support-check fail in 173460 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 173460 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173451
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173451
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173451
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173451
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173451
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173451
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173451
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                4c86114194e644b6da9107d75910635c9e87179e
baseline version:
 linux                ffb39098bf87db327b2be4b5c6f1087bcba94ce9

Last test of basis   173451  2022-10-06 21:13:17 Z    0 days
Testing same since   173456  2022-10-07 08:23:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Alexander Zhu <alexlzhu@fb.com>
  Alexey Lyashkov <alexey.lyashkov@gmail.com>
  Amir Goldstein <amir73il@gmail.com>
  Andrew Perepechko <anserper@ya.ru>
  Baokun Li <libaokun1@huawei.com>
  BingJing Chang <bingjingc@synology.com>
  Boris Burkov <boris@bur.io>
  Casey Schaufler <casey@schaufler-ca.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Darrick J. Wong <djwong@kernel.org>
  David Sterba <dsterba@suse.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Eric Whitney <enwlinux@gmail.com>
  Ethan Lien <ethanlien@synology.com>
  Filipe Manana <fdmanana@suse.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Ioannis Angelakopoulos <iangelak@fb.com>
  Jan Kara <jack@suse.cz>
  Jason Yan <yanaijie@huawei.com>
  Jeff Layton <jlayton@kernel.org>
  Jerry Lee <jerrylee@qnap.com>
  Jerry Lee 李修賢 <jerrylee@qnap.com>
  Jinke Han <hanjinke.666@bytedance.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Josef Bacik <josef@toxicpanda.com>
  Josh Triplett <josh@joshtriplett.org>
  Lalith Rajendran <lalithkraj@google.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Czerner <lczerner@redhat.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Nikolay Borisov <nborisov@suse.com>
  Omar Sandoval <osandov@fb.com>
  Omar Sandoval <osandov@osandov.com>
  Paul Moore <paul@paul-moore.com>
  Qu Wenruo <wqu@suse.com>
  Ritesh Harjani (IBM) <ritesh.list@gmail.com>
  Ritesh Harjani <ritesh.list@gmail.com>
  Stefan Roesch <shr@fb.com>
  Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
  Tadeusz Struk<tadeusz.struk@linaro.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Theodore Ts'o <tytso@mit.edu>
  Uros Bizjak <ubizjak@gmail.com>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  zhang songyi <zhang.songyi@zte.com.cn>
  Zhang Yi <yi.zhang@huawei.com>
  Zhihao Cheng <chengzhihao1@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   ffb39098bf87..4c86114194e6  4c86114194e644b6da9107d75910635c9e87179e -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 19:32:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 19:32:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418241.662995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogt4c-0000Th-PX; Fri, 07 Oct 2022 19:31:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418241.662995; Fri, 07 Oct 2022 19:31:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogt4c-0000Ta-Lq; Fri, 07 Oct 2022 19:31:54 +0000
Received: by outflank-mailman (input) for mailman id 418241;
 Fri, 07 Oct 2022 19:31:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ss/Z=2I=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ogt4a-0000TU-Nd
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 19:31:52 +0000
Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com
 [2607:f8b0:4864:20::829])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0aef6ec-4676-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 21:31:51 +0200 (CEST)
Received: by mail-qt1-x829.google.com with SMTP id fb18so3390796qtb.12
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 12:31:50 -0700 (PDT)
Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27])
 by smtp.gmail.com with ESMTPSA id
 de41-20020a05620a372900b006e07228ed53sm2767598qkb.18.2022.10.07.12.31.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 07 Oct 2022 12:31:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0aef6ec-4676-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=gBv3GlGHRWdoq6Ybc/QYiDjfAi4CdFQEmJaAU2QkoXo=;
        b=f5OiB8c9U9Woy2yDCx7xTdlpOlstrL5x3VUvbPK/d7JUPaj+W7VOnJ4380g/AIzTCw
         y/zgf2A+QOKvvownjeGNvpKhMAyWfvuF8/DdWRJtNUkpX7t5lelSBe3xbOt8Pnc1MAd5
         +eUsyTxGVXADjSt9RoMTzRz+ON11a8BVkJ8c5feLNZnQ4d2s1TgFZoJQzOqWfpIAUdhd
         CdcXMO4SWb0I7geq8Su6QPnxMY8KE/H8TEqKthL9n3wFInn8df8/EeYaQzigcFFTz3TC
         F9jv292cNuEV/XsgsqL5czqzVGiBb4hshr8za9oh8t9V0dzn2PuXXuMBIdEH3ZtQ0kpn
         wtDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=gBv3GlGHRWdoq6Ybc/QYiDjfAi4CdFQEmJaAU2QkoXo=;
        b=5HTg5rqdky2/053n3A6F+tbCl+ApvlAVeOnvM4JbvdsezffVCPrzLH+DBCK2qB1Upt
         ZaCkl+ATp08DdncNCuBNFl59kaPsKZ1OsAlCg6rQK6G+NhdL+Izd0mrhPkxOVuP0aqOU
         r0HGgMflgvOB5QUTXEp769YAgj+ItwutvA+MCuVdWLMrVTPcoMqAg426GbPg+OJH7Lm2
         YoGAvnnXYdma2RVEGjYCHYbMQ3Mm1ubUWI6P5hLSWZ/kt0CUYxeRiqKThYOJc6sGqjHN
         ZPclviEcg+bxZQPbjo8diWVkMXJZfPlhfMVEYlZXoi8b80X7uPTH9138tDIL9LaXBbOt
         GaLg==
X-Gm-Message-State: ACrzQf0rqy4osD5QUvM1rXIageCHVvMK/pLUYtAQK+IKqhlALQANL/1a
	Vrp728EKogvRtrYMieLCEH18LeIPiZY=
X-Google-Smtp-Source: AMsMyM5JE8mXf56Y4giTtTDOeaTP9MKf7rrH2VAf2ew0oF19aimdTy3uwUby2/s4aYOGvyaQfhYlnQ==
X-Received: by 2002:a05:622a:1aa8:b0:35c:c831:d601 with SMTP id s40-20020a05622a1aa800b0035cc831d601mr5549038qtc.434.1665171109189;
        Fri, 07 Oct 2022 12:31:49 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Jason Andryuk <jandryuk@gmail.com>,
	Christopher Clark <christopher.w.clark@gmail.com>
Subject: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Date: Fri,  7 Oct 2022 15:31:24 -0400
Message-Id: <20221007193124.20322-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

I observed this ASSERT_UNREACHABLE in partner_rings_remove consistently
trip.  It was in OpenXT with the viptables patch applied.

dom10 shuts down.
dom7 is REJECTED sending to dom10.
dom7 shuts down and this ASSERT trips for dom10.

The argo_send_info has a domid, but there is no refcount taken on
the domain.  Therefore it's not appropriate to ASSERT that the domain
can be looked up via domid.  Replace with a debug message.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
 xen/common/argo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/argo.c b/xen/common/argo.c
index 748b8714d6..973e1e9956 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -1298,7 +1298,8 @@ partner_rings_remove(struct domain *src_d)
                     ASSERT_UNREACHABLE();
             }
             else
-                ASSERT_UNREACHABLE();
+                argo_dprintk("%pd has entry for stale partner domid %d\n",
+                             src_d, send_info->id.domain_id);
 
             if ( dst_d )
                 rcu_unlock_domain(dst_d);
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 19:36:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 19:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418247.663006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogt94-0001E2-9e; Fri, 07 Oct 2022 19:36:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418247.663006; Fri, 07 Oct 2022 19:36:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogt94-0001Dv-6e; Fri, 07 Oct 2022 19:36:30 +0000
Received: by outflank-mailman (input) for mailman id 418247;
 Fri, 07 Oct 2022 19:36:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PW8X=2I=citrix.com=prvs=2723e59b2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ogt92-0001DS-Ru
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 19:36:28 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5468cdca-4677-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 21:36:26 +0200 (CEST)
Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 07 Oct 2022 15:36:23 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5341.namprd03.prod.outlook.com (2603:10b6:208:19f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 19:36:17 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Fri, 7 Oct 2022
 19:36:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5468cdca-4677-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665171386;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Tlb6xUuiyv3ehdq3dqr6CRWp/ClGMHT9k0urW2cDPLc=;
  b=TF7s40EryWt1VjNUlhtmJSFoohrR+kj8jExecovYFonjWSEB56b5g+po
   +IKlLctBRdcdgVOgzS8dEAf9glelt/ZKX7XQGe2pCXDc65HFhexNipglm
   cppgnd2kYWVxlcfXNcTb2zyhlZnT4sJSWJfOVhDjTRB51VTxkG3WDXQw3
   k=;
X-IronPort-RemoteIP: 104.47.66.40
X-IronPort-MID: 82246624
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AaopFOats0aSXX86J1CZ73bAOMefnOphVZv1Qm?=
 =?us-ascii?q?MifNp3fv4Xw3xbKv3m3sRAOTtXT8in+f9KLFo7KrYYkrBB+5gp36znrwqbCJ?=
 =?us-ascii?q?qyHHCV0Ikbv1gcjCz602xf45ielFaY0gBXBVjZFvyABWPxFTSkyH5tVnR22+?=
 =?us-ascii?q?F9zZS9nVaGRVYje02ZQKKt7F5a7EMhJDAuWrAiq6VmnuUBvHZ7WG2S1uU5g1?=
 =?us-ascii?q?5e/J8PhnYJNOnllo/IV78tqHeJz27alrEA5+zszpwFfNTOtAs+y2LDbYbR0f?=
 =?us-ascii?q?bMlQqIaM+SfRS3ZEVSc3ejLSWmMhIn6NJkfQLgtz7WgDiHfX0GeR3Zn6WO/p?=
 =?us-ascii?q?+6cyMQ2YtOeyJxxxrB2Ez6z0itkyoWFAY6PGFLyXnWBDfwgDXlwGGgFdIL9o?=
 =?us-ascii?q?Jaxv0Ee8KszNkOn/nwgCcTFKGv4HMYsFaj2Uy5yt3jhFaYqkms1fXJ9/s4jU?=
 =?us-ascii?q?oiSEVAwqaqqJc9sk/mM5AE7TJCs72gcG3Unp3xcaCgzqYnze58yJblKFocox?=
 =?us-ascii?q?v1U2R2dgeZjhMWAAHWo+NHxWm2389opQP79n/LpmapqQcsLmL0HN30he1/DM?=
 =?us-ascii?q?I4HgP58ndsyfo2GNxtrQCEaTiURU3hAI9sZF0oECCwIwvD2vKA6fw+dcvQ6a?=
 =?us-ascii?q?ZR5p70W+RrYYbx0cVeZOEYamK2p8+JxDeuG+GORwIuz5aRgGCvT1Cy8Dxocc?=
 =?us-ascii?q?X+6SdxjGJpkPPLaMlIHNyub2LFp7Cnbzk9Wm7EgXWgUaZHKTcpxqxyuaYpf2?=
 =?us-ascii?q?0+y5ngROJMCTvp26dG6Ifxm/83qkNRl3eIbMRaT1AKIkPhMm8o0ISXaKfhow?=
 =?us-ascii?q?/CaMtx+toJw6mZTu7x4mPAFLEBVaieA/KaLSwm0z3cKG370ZS8RiIcAUpHL4?=
 =?us-ascii?q?RWxEjlC9tqr4b1vOsICk5o7K90MHcUMXHovnBs8tbTavdNg6C6MgXwkaG/pV?=
 =?us-ascii?q?DeWB12hUDNvPOzZZawi7MfsnEV1WbYk8Gt2EBKMy+P4vzuzbxZJKy5hFbPr7?=
 =?us-ascii?q?dKh/7GQ2jWx5PwPJ8scEDOYZugFUIEPyyNsLjjD1vbK+CH1lTwq7hL8DiZHa?=
 =?us-ascii?q?zoSVRa5q5+oUHju3A6LPRsOzFsGcHcHX57aFdQo7DP270kYfgVa7MwTh7U23?=
 =?us-ascii?q?/cWQaI+cFeRttJ4JTy009X8yIaADFwcmLFj75D+QlDeUaYvswKd8zBNLlD23?=
 =?us-ascii?q?WQtL9VgsOT3uLudBjMK0WNkv1XuryNYKFyY869QS0TK/k4TEkBbtgokFtBej?=
 =?us-ascii?q?P16Vc08PbJG08kvRISoVfK+nf+jIIdlsH8vaM/r60mOhfqQtzl3z0Nz/Lt3G?=
 =?us-ascii?q?1FUd0x3JAeOhAxA1Z9l1R+sKpj41aniPKL4ggVG+FGEjjHpt6NlF+NzrhP9+?=
 =?us-ascii?q?fYyC1BlK4RZaoNhuiIXRVrWwYklUgTIHnzABMrIgD6MV9LrRsqNKArCtviQb?=
 =?us-ascii?q?NvuqBwrBpav2rhHnoulZKzWit97Kgi2M9IdcvoImG5wzLCEbf2Bg6/5lI8AT?=
 =?us-ascii?q?IrXC7kzd63VEQQr4GPZTQKHf7IXDmcrA0bKNjZbeTbNbYpmXMaOBOPnnqXlN?=
 =?us-ascii?q?sc03QX+06Ig76H/GqWix8DrnV6TAZuGN9DBAnoQlq+3UYqLobiDxxcd5uvwu?=
 =?us-ascii?q?0JMY1jvvQT3Upx/xtkVPzz7w4C3zXRWDEFrgjZVuoiPnxXxs/BrH5x8kLNlq?=
 =?us-ascii?q?u4Rz/ZP1qEZgJTBuhd1/skLCJexuZ6l4/HbM5MzfA6CE4gqhff21SjkWV/Pn?=
 =?us-ascii?q?zvRfUqVcU3xyZJGrNTWdIWFYz9taMwgw+3QyDJFAfL0S95qbuEZVd91Z9DaA?=
 =?us-ascii?q?bjcFmLhUiEt5lkdWZcsT16B3kS7d+jaWinCbQwkjt/sDDOEED5EySWnUTym/?=
 =?us-ascii?q?LqT/oNXlD0uFEkSh1ma3Uz0Vzqqad2jsSLO/VJXAJN/0H/7ylzPzLrWYJX+6?=
 =?us-ascii?q?rnHm758tqrJEFS/6c5c+2lycMSe4gOys/uEgYpoP7HEccAhni2YvWqceU6W9?=
 =?us-ascii?q?hcLRXR1t3huRLiMrIxbpSjnbWkP1foM0q7iRV/oMmFCyLtjVDLnFzQrrvicB?=
 =?us-ascii?q?0aLt+MLhoMn2ZEVCc09IqX/YLVU768mcIEtczwPXGWmsMxp5jKripZXPzBmf?=
 =?us-ascii?q?e/aNpQvuPB8JgnHyvi9lckA82xN45jUB8yjPURyrhiZwu0KGygw+RFO3g+e7?=
 =?us-ascii?q?C0Q56zQwWtICsXCv2WbX0uETfIzxCA7b/ZrJmOsmfwRuX+ewzeW9lhi7kZSw?=
 =?us-ascii?q?RKwST7NJHsmdXgiTl0RsPvL5otxqI1oPQMqV38JH3P/HxV/N7aGMMitX8J2j?=
 =?us-ascii?q?CEMlHvwz5bRGhvly1b+9X9VsGM7+BomraSpoA/DJT9q6I38gXd4zcBohI55P?=
 =?us-ascii?q?McloRiO+G+0w30wnRvRRq3aDGCruECl2UVaIl9+ghzp9w1SgZz+I1cwoxCOs?=
 =?us-ascii?q?7Eto2pJApkIjwZmKPxtrGJvFL3N71jeLmG5OiqDYDHrj9c+7ppYWAZTtsnvj?=
 =?us-ascii?q?3EI1fTDR+Xv/mchnoRIvfPV/3Ngu9uKMdm1NDYqoHoO4fJdCZv5F0CTJiVdY?=
 =?us-ascii?q?gXd6ms4z1dChyU1P3Cu2FnjGwgTJweX4fF+/+uvx55nwTpASmPxs3sxcB05u?=
 =?us-ascii?q?KhvFZp784pa/h0UqGu7IQgs?=
X-IronPort-AV: E=Sophos;i="5.95,167,1661832000"; 
   d="scan'208";a="82246624"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CjjJI0RNrDlMOH9KJq+Whf3mcgs+bAdJfygyK/739DUQy0/tT541E+bGw6tr75bu0gvfw6WeJbeufPchFO8mJii0rXTV8mIJjmX00IxHo6WAhHnxoCgoaFbnODoL/gUKWk4q7AbvoNzNS1mbf8aisZuBoPVQuTQT6gDL2kcyoIqNY2+rNllzcb7HEmFvOXaOjehVSVPJRGk//NZmYGfjcfLkSMuMUnZ8NZuOSS88YaqzLb7oXTbho6qmkCrYIX6Lg+jKkC2ARYmo2FbMKipSYT7BWfbUy5Z5GPuW7/7v3ASDYFXeDVaoAvZtLdroEzEg8wxImUFDIkZ8Qfo0TIiQ5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tlb6xUuiyv3ehdq3dqr6CRWp/ClGMHT9k0urW2cDPLc=;
 b=I3oNz7Hz2ImA4OYDy3F2POu6UcUebBB9uZmJuBgyIQrxrVpnQR6V8rG7WaZe3GZveo7xppR9qC+I8k3z8OHP54LvdaIg19t10FVXgXfgsAPuoi1qUIhNb4vV0O18CfFEEWKbkaYDtPKU9QiAes0AF4H07l7lj1BSNzrK+6vgw0THYRbz6TCUqBLc8XL3bTd0iJ9AYGF29ZwMiQ0g3g11V9lHPQg1YAZOGFpoJNPQe7YVXi6qIUcWg9VbHHg1+OX83+RaU8D0cvoms4DKNBxmYBODMA6iDGhNGWCvyrevVRyuWlDyjl6e6zWQ0mdLKWiCZAW3R15bUa3Wdatf01R6JA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Tlb6xUuiyv3ehdq3dqr6CRWp/ClGMHT9k0urW2cDPLc=;
 b=vMRaBX1Jxr1SnDgAYlFDmxKwkVP1XMk7/vsJEALWZF3yIJB6cnSYlSswTTOrX4zh4Zn5xq4PL9X+uIOG52QbxIJWl/W2TzfpWMkFUUJ8UdnjuxBiU+BUpNG0TzwfCSv5UZVY5xHFS/hDRIxnd4ikDQLOAq/dZgwg4qhUNuQ0fUs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH 8/9] gnttab: bail from GFN-storing loops early in case of
 error
Thread-Topic: [PATCH 8/9] gnttab: bail from GFN-storing loops early in case of
 error
Thread-Index: AQHXmmM/VphgVTklNkOGta5ws5Mbeq4F01sA
Date: Fri, 7 Oct 2022 19:36:16 +0000
Message-ID: <4808b724-31d3-bab4-e6b8-5e4bc5e0a104@citrix.com>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
 <61775fdb-bf56-b6db-563e-81820e4248fd@suse.com>
In-Reply-To: <61775fdb-bf56-b6db-563e-81820e4248fd@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5341:EE_
x-ms-office365-filtering-correlation-id: 4a670e3c-5b1c-4fff-5312-08daa89b33e2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 SarGP9kUDzYiUOqxzUtZwZmEXtBBV6ZO9cZAW+GKZMDo6uR80xW83SBTIw4/eYO4vR006n0oWG5A44gV7SRHTRoZNpUi6W4Awzx8c8VhzBg+QlXitdAgI35y+GsWkE9wmLI3yTevpg0VggIFM3hIY1+zk2tRmrDeMZrjaypvCbPIWrI3FGDWgOrzRY2NNMKn1ki7iTEOuTWcYM2OuyAT3HynUPXymo+llWQw400OfDcOhLqO+8eTVXSogy6ZtiTVQk1Rix9504EPK2AfvRtem9VHgJhD/44S3xKPaaTCSp25bxYh+sE7P7IZHP6ET+8ySGn3mSG5xkImPGnT1L37Do0iufsEbeVQ6MDnKCWFE4Y09X9wkVs9MK718Wk0htJfKE9Rb1TsacV7JxGG7Hzq/UXdUtfNnAiBI1EssIPiR+Ak7R9VpyJeSxJjlMGuLDf3oCL1RUkBN83ygQIBab5F/jHArWVwMPVqWCDj7UMyz6i6xw9o0K4WlhIogsRR8F4yH+UsMFhNhghNBBvd5R2mAHlEpxYQtv9SzjXL1cXLtgLX0kTPR5dxil186xUd9nr2KMTJJ9M6Figm5yn2oWT0f0CcYU7uunN8+s2kX6dwzd+G1MZC4taRmWXvgtnmSS5P4eIEawRLXEmV4IqDJc4V+AnHeSan6po1c6pseZjYBd9lCAoE9LrpQIOkTDVXpjctqbhLrpafD2X9Itbcjae+e+1LxDfj5MiablkHONYVtOYVdm3G10gz7lhO14LVCrxym530pnAhOmXXLFYlTOPzWASqxhXnBsvI5+JGllPVdoSozJWSgN0L6y/j+fBKEiRIpBOeUYyKftaqhwen4/Ct+A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199015)(2616005)(186003)(83380400001)(38070700005)(82960400001)(122000001)(38100700002)(5660300002)(4326008)(41300700001)(2906002)(8936002)(478600001)(26005)(6512007)(6486002)(66556008)(8676002)(66476007)(64756008)(316002)(66946007)(6506007)(66446008)(76116006)(91956017)(53546011)(71200400001)(54906003)(110136005)(36756003)(86362001)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?RGEwRmJqMXRxWWhYRk0yS2tMQWl4dkVxaWEyK1JGOWJOQjJqTWZRa2x4bUZC?=
 =?utf-8?B?Ly9abUlScGxYWC9FSVhBaTFzazdMaVRudkljd2JBZzcyam0zNXRndjVMaENP?=
 =?utf-8?B?YWZ5SzNySnppZy9YUUY3WkVqSEpSQm5KZk9lWWZtaWdKUU16VWNWS2lxL0tC?=
 =?utf-8?B?OEZvejJKYXhvV2pRdTEvclQ1R0EybEJLWlR5cE03cHJlMUpEaHFobU5HT2dM?=
 =?utf-8?B?SEhQOFRJWUY1eVpGVUNzNGUwT3dmc01OVlZrU0tobWczc2s5VUdwSHJycmMy?=
 =?utf-8?B?TEZWRlhuS3lkUmZ5VHk0OEZ3b3hNTG5rREpDQ3VFWmdLNnZIQkhxak4wN1VE?=
 =?utf-8?B?dFVNcEgySFdsN3FUUng4VVpsRE5RcnBTL1o2amIxbTRTRjhleDFzSVZGdGRJ?=
 =?utf-8?B?N082RnlPdGdxNXdvVlQrdkJJQ2xWRkluSENTMUcwdFU2WVV3ZFVVZWRGK0lt?=
 =?utf-8?B?U1JYUGloL1psTThnODdORlZzSVNPUDFSdi9ScVBlMDRaeSt4THZpVjd6cTdV?=
 =?utf-8?B?bTZLU2NTOUNSclg4NThqNVc5eWhiYWhBdGFSekgzRWpoTHZ4cFBOUXc1bXBH?=
 =?utf-8?B?bVN3TjB1QjNmb1diMlhhL1RBSGF3aXhzaUt1OVFBcTZqeE9qMzVtU0w1VWty?=
 =?utf-8?B?K3VGd0N5cEowa25OcXI0MDVmdG5KWnVIUHVJekRUajZSMEE2Tm55MVY5RXpZ?=
 =?utf-8?B?cFBjalJmMzNIa3BkYnUzdTlGMkZpb0wxQlhQa1I3MEFBS0VYczFKQkhQdUFX?=
 =?utf-8?B?RzNtTGJ6VU5qSWxWbEd3V0FUZXRJeEx5SEJPWGYxekhROTlOWEFpMVhpMTBG?=
 =?utf-8?B?NnE5bURWaXEza09rWnVyaFdGMktocWgrZW4zQVFNamJpcjJ1YWFqckNoMXJY?=
 =?utf-8?B?cGJTUUg2Uzh1c2xDL3hYZDUwZzhoS20rRElGckRyU09oYUcxTDZGWm5BT0Vu?=
 =?utf-8?B?c3J3MkcxSTF3bFFqb1VONnJyYURSQWpVZFNXOTJBL2xldU0xZ1FhOEhCY0FC?=
 =?utf-8?B?REY4WERqa1dodDkxSXMzYmk4bDdzSFdjMytoQkNqRDZudkY0MWJ5TzhSNm1j?=
 =?utf-8?B?ampTVlpWMFc2Um9yUE5uK3dWbXNHODJTc3N5YU5SS2VQVldGS0h0TGtJdnBI?=
 =?utf-8?B?Q3VFK2ZVajVWa095VlFRVU9xVlluTk1xZ294bEJjYzcxc1JNRXFoZlZQUE93?=
 =?utf-8?B?THY0NlJneG5oNmRTMVBrb0VKb0k3V09FaFgzbFNVdkpkbUs1YlJNZ1lEYlpp?=
 =?utf-8?B?cGtqTitGRXRCUmY2bDI1N0Q0Z2V5ZnpTT1ZCME84ZWtlZmJUclpETjcwNktk?=
 =?utf-8?B?VG5mQk9tMGE2UTJBWWhoVXh3OEZkYWJueXRxUUZ6RkgyaDNLdS9oREEyNzRH?=
 =?utf-8?B?N3BVU1dHcFNBOStQeFpkU3lkK0RleEUvUTl6REVWV3hvRUZ6NldnMUpybTVk?=
 =?utf-8?B?ZklWZVZpOTJkWjZOMHoyeDB5cXdydzRqNGVGU09lL2c1dVNrZVBteS9ZTXBO?=
 =?utf-8?B?RnRFR3doaWxLTzJwZ3JMVEI0cU5adGxLUmVlSXZoWlV1SHI0d3NlSStXaEJw?=
 =?utf-8?B?L0dlVWhyU2N1ZzRkK1dURWI5VHFPYmRuMjR6T3NhNGNjOHAyNitLcXJKTnBT?=
 =?utf-8?B?U0RmU3BJdEE0c0lSM2tMSVFUUlJYZGZlZ3FkY1dJTHZkOGNGcUdzV0svMkc4?=
 =?utf-8?B?QlBabnI4OFNOekxhR2lIWFlvaTlGaTZocjB0YU92eEd2cjd1cHJQdW5FTk5D?=
 =?utf-8?B?dTUrY2VLVmZEQjVqT0ludlNscWFlcURPS2E4MzFwakx5N0k3RFozdGxFMFRO?=
 =?utf-8?B?alphVHIydUJIbkVlcm5SSTBKaFd6VVJUQjVrU2xHRi9kWUQ2a1I3VzIrclg3?=
 =?utf-8?B?RGNzUUU3cVhKT25WVFRLZU05REZhcVdRdi9pTjBIbGdEbmpJT1pRdE5xcFNn?=
 =?utf-8?B?MmFaMEdZQWQvRnRXQjRicnc3MXZiVG5qK0lHNE1xVVRneUkwSVFnaGR4NWFx?=
 =?utf-8?B?VzdGVVphSzZBVGhzRVpxWHhhQkVIWlFXWllLUmpOVldMS1JNbzRxMmJzd3NX?=
 =?utf-8?B?NWc2YzNhZzBnRm5EK0Nua3BWWmdyUDFXN0huRzBTZW5vcVdrd3J6aHEvZzFF?=
 =?utf-8?Q?CSzsGtlUhhPRn8MGiLt8mHuN0?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BFAF6F8322D2934DB4277A43E0B8C53F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a670e3c-5b1c-4fff-5312-08daa89b33e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 19:36:17.0057
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +yUcbs/u063krRMnLJSqVJmTx3E84mXvLL/vozqVIEWH3Ff1XpeQmBKPj8lhViPMyGOFQqHavvYv+ORQrSq1XfFhIDDtVTqXcsacLhOn1V0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5341

T24gMjYvMDgvMjAyMSAxMToxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZSBjb250ZW50cyBv
ZiB0aGUgb3V0cHV0IGFycmF5cyBhcmUgdW5kZWZpbmVkIGluIGJvdGggY2FzZXMgYW55d2F5DQo+
IHdoZW4gdGhlIG9wZXJhdGlvbiBpdHNlbGYgZ2V0cyBtYXJrZWQgYXMgZmFpbGVkLiBUaGVyZSdz
IG5vIHZhbHVlIGluDQo+IHRyeWluZyB0byBjb250aW51ZSBhZnRlciBhIGd1ZXN0IG1lbW9yeSBh
Y2Nlc3MgZmFpbHVyZS4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo
QHN1c2UuY29tPg0KDQpOb3QgcmVhbGx5IEFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu
Y29vcGVyM0BjaXRyaXguY29tPg0KDQpUaGlzIGlzIGFuIGV4YW1wbGUgb2YgYSBiYWQgbG9vcCBh
ZGp1c3RtZW50LsKgIFRha2luZyBqdXN0IG9uZSBleGFtcGxlIHRvDQpkZW1vbnN0cmF0ZSB3aXRo
LA0KDQo+IC0tLSBhL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYw0KPiArKysgYi94ZW4vY29tbW9u
L2dyYW50X3RhYmxlLmMNCj4gQEAgLTMyODksMTcgKzMyOTIsMTUgQEAgZ250dGFiX2dldF9zdGF0
dXNfZnJhbWVzKFhFTl9HVUVTVF9IQU5ETA0KPiAgICAgICAgICAgICAgICAgICAic3RhdHVzIGZy
YW1lcywgYnV0IGhhcyBvbmx5ICV1XG4iLA0KPiAgICAgICAgICAgICAgICAgICBkLT5kb21haW5f
aWQsIG9wLm5yX2ZyYW1lcywgbnJfc3RhdHVzX2ZyYW1lcyhndCkpOw0KPiAgICAgICAgICBvcC5z
dGF0dXMgPSBHTlRTVF9nZW5lcmFsX2Vycm9yOw0KPiAtICAgICAgICBnb3RvIHVubG9jazsNCj4g
ICAgICB9DQo+ICANCj4gLSAgICBmb3IgKCBpID0gMDsgaSA8IG9wLm5yX2ZyYW1lczsgaSsrICkN
Cj4gKyAgICBmb3IgKCBpID0gMDsgb3Auc3RhdHVzID09IEdOVFNUX29rYXkgJiYgaSA8IG9wLm5y
X2ZyYW1lczsgaSsrICkNCj4gICAgICB7DQo+ICAgICAgICAgIGdtZm4gPSBnZm5feChnbnR0YWJf
c3RhdHVzX2dmbihkLCBndCwgaSkpOw0KPiAgICAgICAgICBpZiAoIF9fY29weV90b19ndWVzdF9v
ZmZzZXQob3AuZnJhbWVfbGlzdCwgaSwgJmdtZm4sIDEpICkNCj4gICAgICAgICAgICAgIG9wLnN0
YXR1cyA9IEdOVFNUX2JhZF92aXJ0X2FkZHI7DQo+ICAgICAgfQ0KPiAgDQo+IC0gdW5sb2NrOg0K
PiAgICAgIGdyYW50X3JlYWRfdW5sb2NrKGd0KTsNCj4gICBvdXQyOg0KPiAgICAgIHJjdV91bmxv
Y2tfZG9tYWluKGQpOw0KPg0KDQoNCklmIGluc3RlYWQsIHRoaXMgd2VyZSB3cml0dGVuDQoNCsKg
wqDCoCBmb3IgKCBpID0gMDsgaSA8IG9wLm5yX2ZyYW1lczsgaSsrICkNCsKgwqDCoCB7DQrCoMKg
wqDCoMKgwqDCoCBnbWZuID0gZ2ZuX3goZ250dGFiX3N0YXR1c19nZm4oZCwgZ3QsIGkpKTsNCsKg
wqDCoMKgwqDCoMKgIGlmICggX19jb3B5X3RvX2d1ZXN0X29mZnNldChvcC5mcmFtZV9saXN0LCBp
LCAmZ21mbiwgMSkgKQ0KwqDCoMKgwqDCoMKgwqAgew0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBv
cC5zdGF0dXMgPSBHTlRTVF9iYWRfdmlydF9hZGRyOw0KwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBn
b3RvIHVubG9jazsNCsKgwqDCoMKgwqDCoMKgIH0NCsKgwqDCoCB9DQoNCnRoZW4gdGhlIGRlbHRh
IHZzIHlvdXIgdmVyc2lvbiBpcyAtMzYgYnl0ZXMsIGFuZCBmYXN0ZXIgdG8gcnVuIGJlY2F1c2UN
CnRoZSBsb29wIGRvZXNuJ3QgbmVlZCBhIG1lbW9yeSByZWFkIGFuZCBjb21wYXJlIG9uIGV2ZXJ5
IGl0ZXJhdGlvbiB3aGVuDQp5b3UgY2FuIGV4aXQgYmFzZWQgcHVyZWx5IG9uIGV4aXN0aW5nIGNv
bnRyb2wgZmxvdy4NCg0KRnVydGhlcm1vcmUsIHRoZSB2ZXJzaW9uIHdpdGggYSBnb3RvIGlzIGNs
ZWFyZXIgdG8gZm9sbG93LCBiZWNhdXNlIHRoZQ0KZXhpdCBjb25kaXRpb24gaXMgbXVjaCBtb3Jl
IG9idmlvdXMuwqAgVGhlIGNvbXBhdCBjaGFuZ2UgY2FuIGRvIHRoZSBzYW1lDQp3aXRoIGJyZWFr
cyByYXRoZXIgdGhhbiBnb3RvcywgZm9yIGEgc2xpZ2h0bHkgbW9yZSBtb2Rlc3QgLTExIHNhdmlu
Zy4NCg0KQSBmb3JtIHdpdGggdGhlIG9wLnN0YXR1cyBjaGFuZ2VzIGFkanVzdG1lbnRzICpub3Qq
IGFkZGVkIHRvIHRoZSBsb29wDQpjb25kaXRpb24sIFJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVy
IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQoNCkluIHJlZmVyZW5jZSB0byB0aGUgaHlw
ZXJjYWxsIEFCSSBhZGp1c3RtZW50cywgaXQgb2NjdXJzIHRvIG1lIHRoYXQNCmxvb3BzIGxpa2Ug
dGhpcyAod2hpY2ggd2UgaGF2ZSBsb2FkcyBvZiwgZXZlbiBpbiBoeXBlcmNhbGwgaG90cGF0aHMp
IGFyZQ0KaG9ycmlmeWluZyBmb3IgcGVyZm9ybWFuY2UuwqAgRm9yIEhWTSwgd2UncmUgcmVkb2lu
ZyB0aGUgbmVzdGVkIHBhZ2V3YWxrDQpmb3IgZXZlcnkgdWludDY0X3QgZWxlbWVudCBvZiBhbiBh
cnJheS7CoA0KDQpBICJjb3B5IGFycmF5IHRvIGd1ZXN0IiBwcmltaXRpdmUgd291bGQgbW9yZSBl
ZmZpY2llbnQgc3RpbGwgdGhhbiBhDQpwbGFpbiB2aXJ0LT5waHlzIHRyYW5zbGF0aW9uLCBiZWNh
dXNlIHdlJ2QgYmUgYWJsZSB0byBkcm9wIHRoZSBwMm0gd2Fsa3MNCnRvby4NCg0KT2J2aW91c2x5
LCB3ZSBkb24ndCB3YW50IGV2ZXJ5IGluc3RhbmNlIGxpa2UgdGhpcyB0byBiZSBkb2luZyBpdHMg
b3duDQptYW51YWwgYm91bmNlIGJ1ZmZlcmluZywgc28gcGVyaGFwcyB3ZSBzaG91bGQgaW52ZXN0
IGluIHNvbWUgYnVmZmVyZWQNCmNvcHkgaGVscGVycyBhcyBwYXJ0IG9mIHRyeWluZyB0byBpbXBy
b3ZlIGh5cGVyY2FsbCBwZXJmb3JtYW5jZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 19:58:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 19:58:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418255.663017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtTn-0003qp-5B; Fri, 07 Oct 2022 19:57:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418255.663017; Fri, 07 Oct 2022 19:57:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtTn-0003qi-2M; Fri, 07 Oct 2022 19:57:55 +0000
Received: by outflank-mailman (input) for mailman id 418255;
 Fri, 07 Oct 2022 19:57:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PW8X=2I=citrix.com=prvs=2723e59b2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ogtTl-0003qc-OU
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 19:57:53 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5286cb4e-467a-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 21:57:51 +0200 (CEST)
Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 07 Oct 2022 15:57:30 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB6344.namprd03.prod.outlook.com (2603:10b6:a03:395::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 7 Oct
 2022 19:57:29 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Fri, 7 Oct 2022
 19:57:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5286cb4e-467a-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665172671;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=KV3BC7c7AkDoU8ohIWYMl6OirBPFWsYjUCGZ7KbiEQ4=;
  b=VBe1UJCb7CuqML7/Thu93epBQEg4K2bkx8XeVsPAzUi6rPdBRDc2iBWp
   AAdWT4G3YacggIiiQN1MI6sfx19N97xY5qD8TwKJOlmQQshqjxSsOB6s8
   BCgBVauLrrS/REWO9ApzJq5ScL2lSgjYgcOBBgmeqRD+TxfnKsarU+BOG
   I=;
X-IronPort-RemoteIP: 104.47.59.174
X-IronPort-MID: 82659519
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:jhRuoK5AUEEu30Xpul9fWAxRtOLGchMFZxGqfqrLsTDasY5as4F+v
 jNMDWGAaPiJYTb3fd92aYyx9x4BsJ7dmIRjHFdopC00Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gRhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c53DEV3y
 /MfEAorSQCluNPuye+kCdRF05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMkGSd05C0WDbRUvWMSd9YgQCzo
 WXe8n6iKhobKMae2XyO9XfEaurnzXmlBdNPTezQGvhCmkCp72ANEEYqRXi9/dKZlHKMQeJ5A
 hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0
 V2ElM+vAiZg2JWUVnC15rqStSm1OyUeMSkFfyBsZQkY59jupqkjgxSJScxseIaulcH8Ezz0x
 zGMrQA9iq8VgMpN0L+0lXjYhxq8q56PSRQ6jjg7RUqg5wJ9IYKgOYqh7AGB6e4addnFCF6co
 HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m80WirYUVcFu
 HPuhD4=
IronPort-HdrOrdr: A9a23:jfeWPqilFi0gEna4hyUdeTOG0nBQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+
 O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.95,167,1661832000"; 
   d="scan'208";a="82659519"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FxL2fFPDiRxbXkWj58LRuX2hxFRJxh5Nqbb5ye/7PjwrnywVeeb9nmepkJcopipPQd1SjSC4XamrmcQqBEEzkg8XBBGuJJGjY0lum7HMilofY8o9GhpVygSIXuOV1o+LIRlOUD+Sk13+01TAjhdjfxZsH0cd5uJjNwcWjVBs8rAAjrS72h21DgxxYfvD11I+4b947nyv07kej/+2TxDOlE9dU5AYHocso28k1u4VocbHftDcsyJqMkJocdYoMUPpdV6k89V6nsKhXOqfYKj7EWx/gB2EL4bpbp/CNZcX6gcSUlzgMUMfrIPCka186Lnhys0TxqD8OF3ybUtvltYhvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KV3BC7c7AkDoU8ohIWYMl6OirBPFWsYjUCGZ7KbiEQ4=;
 b=luEyM58TiOAYAAiQteTftwbQ9+OKZkyVrXVJJN8nJT394wGl0WR9e5i1dk/emFn9JjkoX7vTK36BG9M8jqalZ0zb9KPn9rRLA63uU1rMq5MsA4TZS+i2nHbO/Nmkos8iIf8ysfjidfSVbZbbf/PLDyxCV6vLr1PQUeqyVS7WrXL+hHzCYwFNG2rrHEVBT2otMBWKwCEE08rzTN5SJTYaMvLiQeeoIvyQB4VC7LEIWVvNITownHzZQxdmqJ+VKAr9iNXOdlyQ7ZAMTaOhsKw+RPgH08uc9Xmfr7WZQ0IJMbS0/qlu+dS7OVl+HwRUZqAaRwk916HQF0L2kRgDHhS/WA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KV3BC7c7AkDoU8ohIWYMl6OirBPFWsYjUCGZ7KbiEQ4=;
 b=wqFFmFZt4I7IYcChHwtR8kqTxaTTXc3RJsdq2AtsBPxVmpyhUdUK/a9lPI6/9Hul1hAWuVypmh1HMgOs2X6dcwW+xtXVdLpSGSNhxJUDGMdT/H421UV0pFALC5UYf0/q/V6xZAW5As4ZeQEddFXHgF2L3hxJx/BYAJRsnCB86bY=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Ian Jackson
	<iwj@xenproject.org>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 9/9] gnttab: don't silently truncate GFNs in compat
 setup-table handling
Thread-Topic: [PATCH 9/9] gnttab: don't silently truncate GFNs in compat
 setup-table handling
Thread-Index: AQHXmmNdHWNgMIrF1UaLY8uP4AWVM64F2UcA
Date: Fri, 7 Oct 2022 19:57:28 +0000
Message-ID: <c8b08c8b-0e2d-040e-32b7-0ca63c2908e6@citrix.com>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
 <c3f4d5ce-6ac8-1d1c-eed0-704354f8a5f7@suse.com>
In-Reply-To: <c3f4d5ce-6ac8-1d1c-eed0-704354f8a5f7@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6344:EE_
x-ms-office365-filtering-correlation-id: 5aa92053-3920-40e9-b1b5-08daa89e29ea
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 kIemQ+qN1xex4rkAjldk0C/mjMi2hIy2HfYfpvgIwS2SlibAyEHO1mKh/+nmNayDpbeahOWcozwtHYZ8jB77GaSuw8f3SeQmtpWM1dSKpIBosl1R3uE0boPI+JBoVAUo5Q++golUgYBF22r8cgiQ3jC0pPpMFS0bG6kRN8G+ddiuaP1+qMul02+Zta0YnCxeG+4IGXW3wnY8ikUpSlFdEGo5pVETReCu1DY9U/6YpSagCnTK853tO8Ltq78Yb7Nnl2CnZDo8vxr4h717KZj3ou+y7DORS0uQwGK2sSkeeJYaCgbJ7+o0wrAaFbOaQ+gsN0/YH4P9gLV5mXsMoMsYbjYcFumrDb9EMqSK40L+6qxArsEi0mBRzywmJPOTBgz02/HztMcxfG8Fnu5JaDbkI3l4j3A8e9lEXfnEPYlb08PCEUfEqRieoLaCS40vgaiVeHIp1+HafBYTkUC/IG00cdU6tauedLBwavCRhLPZZxm4K6sTkZcsumqrBdyddryMVYgk3wGnIGXczdItmlspjS/THUWN98Z5M3bCOCUR+0dAWSPbYrMqfgkHCn7+QqyRFmmXzUW0J2eH6JUpcuDN9tB6wb63paaOI7LGf5/liIRnaCLFS6CoKhs4Y1oUQ1+DgflWC2PjLyp1jv8Fbf+hH1WgYu++80jrb7p/FRr99yn9JZG7kxfO9IoalxQzZwj0jd467UK76dlTiNwzJXtvbFoU9MCUp8+VPWTQnojeJQQRik1nT4kh13z5kdX5B1aqnI9PcS0DJP37KI0/SsIH1XPfREpu9XX6JP1/cKnFo9RNu407v4SxZ6zbUm72kVwyyj6jXVyD6Cx22v2uLJhz5Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(54906003)(83380400001)(82960400001)(38070700005)(2616005)(8936002)(38100700002)(122000001)(66476007)(4326008)(64756008)(66446008)(8676002)(2906002)(66946007)(76116006)(5660300002)(110136005)(478600001)(26005)(41300700001)(71200400001)(53546011)(66556008)(186003)(6486002)(6512007)(316002)(91956017)(6506007)(36756003)(31696002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WEdBdG40MTJWV1A4dFNNT1pzR0Q3U0ZFMHFERXkyUlpVNHBFS2s3R0l2Yk45?=
 =?utf-8?B?aEFaNU1ld3BhQUF4LzRvTlovL29WRTV5c0NxSHFwaHRmb2VZOGlLMFg4Y0pT?=
 =?utf-8?B?dEJxejJXb2s3ZTZWMjVEQWhXL3l4Ry9OL25kOTRKYWVCUVdtZXhzRzJ0aEJa?=
 =?utf-8?B?ZXZHOUtBN1lSUm8vNTVZazRla1Uyb0hjRCtTS0FKYkM2czBKUzFXME9uZnJI?=
 =?utf-8?B?WUNqWnZDcXM2Z1B1N0dieWRXb0R2NmpkWGc2QkdaTmVuakJqUFVRUXNSZHVI?=
 =?utf-8?B?dlBEL0d4ajVGNGNYTmV1V2djN3NpQ2RkdXpMTmJQbE92WDkrTkkwd0wzQUpS?=
 =?utf-8?B?c2kyS3dnRW84MmJQU09mdWVOS3NyV0dEYmJiQ3hhTXlveFFZOElEMEFERGFa?=
 =?utf-8?B?TDczWTNEdnZOWUdMVXRzU0RqVDF2UlpYN2xpM1pmdXN2dGM2MWlRRnd1TGpF?=
 =?utf-8?B?Zk9YZFNHeTZkdzRnQ2Y1Z21NSnVwYkh2dVVjQkd4MUIvMGtHcWx5eFVUTGRH?=
 =?utf-8?B?emU4dk9xeFIyaHVDNFNHWGRudlBxYWJSQW5zRE96bkJSeitKYW9VM3VDOFVQ?=
 =?utf-8?B?MmxaT2VXVHhLMGJ3MU5wa0h4UnFxdkFWQ1YyRksvMnM4MDVYK2dIYUI5ek8y?=
 =?utf-8?B?RCtMb2xXUHlxOTZ3aVRTY0paM1BUbmZxYjlubVhXMGJONGp2QkxMM3NDbTlO?=
 =?utf-8?B?UjZEYmw4endXS2VycWdYcmFoM0VQWlE3NFpBSXV2SExVR2pZUlBiYjNORHdB?=
 =?utf-8?B?dFM1TEg0TjRXUXkxUlRJL0NBUzY5QWhxbXcxZUxUWGlvUFloWW1PdmlxRGpq?=
 =?utf-8?B?NWRSaWhVdm5HT1F4ZWRIbFo0U0hCcG1RY1VoclNxV1BNdHJOWUFsMXQyUUFG?=
 =?utf-8?B?SEhUclF1YWJtaElxRytmMTJvWDliNnhUcmp4MDBXU0huTVowM002eG8rUzVZ?=
 =?utf-8?B?SWRGS1RsTWQwOGRwdXFNVk5ueXZ3eFlxemx5aTYzUHliY1lVRWpHSXI3akZv?=
 =?utf-8?B?L0dlRTFWd2owNGM2QTFuQWVTcTdSOTFzekVKWEtPOHhNcHJZaW16YnRHQXZr?=
 =?utf-8?B?NFk2ZlhSUGIrUkhEOWFCZWdmRjlmdmpWVWpnRmsxRTJKNjFKL1FHTkMrYmM4?=
 =?utf-8?B?Ym1aNnJoMExxdDlKOHNFalhiSkVvUXhpVEpmcUdpa1dnWmtONHJiMkhhbXJ2?=
 =?utf-8?B?c2twSU8wVmFMOWFsNml0bStya3h1OWNSY25zK2laMitrazhXMlQ5bmZ1NWZ4?=
 =?utf-8?B?STFlTlMzSXVEaEJNWUJMV3NGNXdaV2RhRWRseXNhR25tYzBJTmd3d0VVRWZO?=
 =?utf-8?B?ZVBCZmtDMmdrUGNmdVBMMG1ibTV5N2QxWGlUQzlrUWowZHZrV1lVU0RTNDRx?=
 =?utf-8?B?VTE2Rys1NUx1RDNYUE55eFl1cHBiRFM1T3VaR1dPVlVVRXlDQXdtVFl2NlZF?=
 =?utf-8?B?MTUvOVpERi9HemQwWWRLYjZvbTRTMUViRCtBRlZjQjBnQUtxTHhoVVdWZ0Zi?=
 =?utf-8?B?Y01PZTA4Tkl0R212WTZibVdGeVFTTWcwZjFOKzVOSlVYUUZtbXhhTThsaUw0?=
 =?utf-8?B?RTBzY0dpNDVWTDFxWExBVDU3NkwvYnlRWHE5TWxNSkN2aHRpdjZtcFN6SzE4?=
 =?utf-8?B?VmtPVDE0TVA4RTNLS0pMbjVralVYUjAzWlFiR1hPNHY2azVKczZyZ2JiR010?=
 =?utf-8?B?N0JTcnc4QjBvMlNjVFFDaVlJaEc5UXJJZVFiUllMTTBua3hIczRTaVFlVGVB?=
 =?utf-8?B?OHo4ZERhdWhOTmQzaHdxMmpXL20rb2lLcy9lSy9OdWlLaDRESkZkZjB6NHhN?=
 =?utf-8?B?dXA5bzRUd29waXU1MlJlMnVJQjFuYlk0SXZPVWlmOExCUXJ1MFpha2gwcUh4?=
 =?utf-8?B?eFcvUHE1a3g1WkpnYTdRUmNpeGV3ZW8yOE5Mb2xuSlYvZHRUaGZMQ1JZOVB1?=
 =?utf-8?B?THhKVmJtb1I1SmVlUDB5eGdDcnZWNWNSYlpXb1lCOFpNUEhMRUdNVDRicVRV?=
 =?utf-8?B?QjVMTm84dHQ3STMxb0dKaHUvTHk2RjArdTA2NlpLRXprYTMrV2Roend5RHhL?=
 =?utf-8?B?Nnl0T2wzWTc1M3RPZXhHZVVid3lPVmxOUzk2aitRdnowVHl6eExlSlpEUVlu?=
 =?utf-8?Q?zqPxKmQqnkKsmjfgyZyCLiaxr?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BB6701990F74D342BEB19D26865D8CE5@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa92053-3920-40e9-b1b5-08daa89e29ea
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 19:57:28.7579
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kVHBHEfY3dFYfxxtmDSRPDecfY0ATqAGtyngpEoDrvjlXH8O7K5azs7FRuoEChfSQLGYzNMyBIPgwDx8Qrr4KMa3jSHXPAZmedufhHLue+U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6344

T24gMjYvMDgvMjAyMSAxMToxNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFJldHVybmluZyBiYWNr
IHRydW5jYXRlZCBmcmFtZSBudW1iZXJzIGlzIHVuaGVscGZ1bDogUXVpdGUgbGlrZWx5DQo+IHRo
ZXkncmUgbm90IG93bmVkIGJ5IHRoZSBkb21haW4gKGlmIGl0J3MgUFYpLCBvciB3ZSBtYXkgbWlz
Z3VpZGUgdGhlDQo+IGd1ZXN0IGludG8gd3JpdGluZyBncmFudCBlbnRyaWVzIGludG8gYSBwYWdl
IHRoYXQgaXQgYWN0dWFsbHkgdXNlcyBmb3INCj4gb3RoZXIgcHVycG9zZXMuDQo+IFNpZ25lZC1v
ZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IFJGQzogQXJn
dWFibHkgaW4gdGhlIDMyLWJpdCBQViBjYXNlIGl0IG1heSBiZSBuZWNlc3NhcnkgdG8gaW5zdGVh
ZCBwdXQNCj4gICAgICBpbiBwbGFjZSBhbiBleHBsaWNpdCBhZGRyZXNzIHJlc3RyaWN0aW9uIHdo
ZW4gYWxsb2NhdGluZw0KPiAgICAgIC0+c2hhcmVkX3Jhd1tOXS4gVGhpcyBpcyBjdXJyZW50bHkg
aW1wbGljaXQgYnkgYWxsb2NfeGVuaGVhcF9wYWdlKCkNCj4gICAgICBvbmx5IHJldHVybmluZyBt
ZW1vcnkgY292ZXJlZCBieSB0aGUgZGlyZWN0LW1hcC4NCg0KWWV0IGFub3RoZXIgcmVhc29uIHdo
eSBoYXZpbmcgdGhlIGdyYW50IHRhYmxlIGJlIFhlbiBtZW1vcnksIHJhdGhlciB0aGFuDQpndWVz
dCBtZW1vcnksIHdhcyBhIHRlcnJpYmxlIGlkZWEuwqAgQ2hhbmdpbmcgdGhpcyBpcyBpbiBjb25z
aWRlcmF0aW9uDQpmb3IgdGhlIGVuY3J5cHRlZCB2bSB3b3JrLg0KDQpJdHMgZmluZSBmb3Igbm93
LCBidXQgaXMgZnJhZ2lsZSBhbmQgbGlhYmxlIHRvIGJyZWFrIGZvciBlLmcuIGFuDQp4bWFsbG9j
KCkgLT4gdm1hbGxvYygpIGNvbnZlcnNpb24sIG9yIHdoZW4gd2UgZ2V0IDUtbGV2ZWwgcGFnaW5n
IGFuZCB0aGUNCmRpcmVjdG1hcCBib3VuZGFyeSBtb3ZlcyBhYm92ZSAxNlQuDQoNCg0KDQo+IC0t
LSBhL3hlbi9jb21tb24vY29tcGF0L2dyYW50X3RhYmxlLmMNCj4gKysrIGIveGVuL2NvbW1vbi9j
b21wYXQvZ3JhbnRfdGFibGUuYw0KPiBAQCAtMTc1LDggKzE3NSwxNSBAQCBpbnQgY29tcGF0X2dy
YW50X3RhYmxlX29wKHVuc2lnbmVkIGludCBjDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBpIDwgKF9zXyktPm5yX2ZyYW1lczsgKytpICkgXA0KPiAgICAgICAgICAgICAgICAg
ICAgICB7IFwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdF9wZm5fdCBmcmFtZSA9
IChfc18pLT5mcmFtZV9saXN0LnBbaV07IFwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgIGlm
ICggX19jb3B5X3RvX2NvbXBhdF9vZmZzZXQoKF9kXyktPmZyYW1lX2xpc3QsIFwNCj4gLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaSwgJmZyYW1l
LCAxKSApIFwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIGlmICggZnJhbWUgIT0gKF9zXykt
PmZyYW1lX2xpc3QucFtpXSApIFwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHsgXA0KPiAr
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmICggVkFMSURfTTJQKChfc18pLT5mcmFtZV9s
aXN0LnBbaV0pICkgXA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoX3NfKS0+
c3RhdHVzID0gR05UU1RfYWRkcmVzc190b29fYmlnOyBcDQo+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZWxzZSBcDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZyYW1l
IHw9IDB4ODAwMDAwMDBVO1wNCg0KU3BhY2UgYmVmb3JlIHRoZSBcLsKgIChUaGlzIGlzIG9uZSBy
ZWFzb24gd2h5IEkgaGF0ZSB0aGlzIHN0eWxlLsKgIFRoZQ0KYm9yZGVybGluZSBpbGxlZ2liaWxp
dHkgbWFrZXMgaXQgYWxtb3N0IGltcG9zc2libGUgdG8gc3BvdCBzdHlsZSBwcm9ibGVtcy4pDQoN
CldpdGggdGhlIGFkanVzdG1lbnQgZnJvbSB0aGUgcHJldmlvdXMgcGF0Y2gsIHlvdSdsbCBuZWVk
IGEgYnJlYWsgaW4gaGVyZS4NCg0KQnV0IGZvciAhdmFsaWQgY2FzZSwgc2hvdWxkbid0IHdlIHNh
dHVyYXRlIHRvIH4wdSA/wqAgSSByZWNhbGwgZnJvbSB0aGUNCm1pZ3JhdGlvbiB3b3JrIHRoYXQg
dmFyaW91cyBrZXJuZWxzIGRpc2FncmVlIG9uIHdoYXQgY29uc3RpdHV0ZXMgYW4NCmludmFsaWQg
TUZOLg0KDQpUaGVuIGFnYWluLCBJIGNhbid0IHNlZSB3aGF0IGxlZ2l0aW1hdGUgY2FzZSB3ZSdk
IGhhdmUgZm9yIGEgdHJ1bmNhdGlvbg0KYW5kIGFuIGludmFsaWQgTTJQIGVudHJ5IG5lZWRpbmcg
dHJhbnNsYXRpbmcuDQoNCn5BbmRyZXcNCg0KPiArICAgICAgICAgICAgICAgICAgICAgICAgfSBc
DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICBlbHNlIGlmICggX19jb3B5X3RvX2NvbXBhdF9v
ZmZzZXQoKF9kXyktPmZyYW1lX2xpc3QsIFwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpLCAmZnJhbWUsIDEpICkgXA0KPiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIChfc18pLT5zdGF0dXMgPSBHTlRTVF9iYWRfdmlydF9h
ZGRyOyBcDQo+ICAgICAgICAgICAgICAgICAgICAgIH0gXA0KPiAgICAgICAgICAgICAgICAgIH0g
d2hpbGUgKDApDQo+DQo+DQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:00:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:00:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418262.663027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtWD-0005IW-IN; Fri, 07 Oct 2022 20:00:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418262.663027; Fri, 07 Oct 2022 20:00:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtWD-0005IP-Fh; Fri, 07 Oct 2022 20:00:25 +0000
Received: by outflank-mailman (input) for mailman id 418262;
 Fri, 07 Oct 2022 20:00:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PW8X=2I=citrix.com=prvs=2723e59b2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ogtWC-0005IH-CV
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:00:24 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id acb45b84-467a-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 22:00:23 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 07 Oct 2022 16:00:20 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by PH7PR03MB6996.namprd03.prod.outlook.com (2603:10b6:510:15c::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 7 Oct
 2022 20:00:18 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Fri, 7 Oct 2022
 20:00:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acb45b84-467a-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665172822;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=pwdDaWVuzpSISfnq0sYokkblNP91vPNR32uGTzRmxsY=;
  b=Y/sgjnu7avYxM/o5U7y+lXQkDLhpeicCfzJ4jbwosDjQ2pBy5aLmbiv/
   N07yQvilL2KF58C0MovoJQBhadsQ+MrKSbR6Xs3V7GWqaYXz+MLyeT72O
   uPyvkzEglx9lZ94DK/IXzNSe6crGw8HmzRrJB4qnXGRXq+KdUZN5cUjwx
   c=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 82659683
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:F099j6B4CqA76BVW/+fiw5YqxClBgxIJ4kV8jS/XYbTApGwk1jYEx
 jcaDWmDOK6PYDekfowjPY7ioR8BusKGxt5gQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25Kyt4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kfEow4wehlGloTy
 vEGcihTciKet6WflefTpulE3qzPLeHNFaZG4zRK62GcCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvL9cLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toijy276RzXiTtIQ6BuP/ptFJqXav2UMYMDELaEeYnsnooxvrMz5YA
 wlOksY0loAw/UqnVMjgXDW3pXeFulgXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvBDjx1saaJTmqd+63SsnW5PSEPLkcNYCYFSU0O5NyLiKE+iAjeCOlqFqGdh8fwXzr3x
 li3QDMWgrwSiYsB0fW99FWe2ja0/MGXHkgy+xndWX+j4kVhfom5aoe06F/dq/FdMIKeSVrHt
 38B8ySD0N0z4Vi2vHTlaI0w8HuBvp5p7BW0bYZTIqQc
IronPort-HdrOrdr: A9a23:vH6BS6wBDUhabx8aK9IfKrPxj+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD
 AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo
 SOBK4=
X-IronPort-AV: E=Sophos;i="5.95,167,1661832000"; 
   d="scan'208";a="82659683"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KDgYrzF03HZJhnt6feLmSxodWZOMgBuW9The1VsaIXIVJ8tAvzOWfHVe3QNSqrZHFvqeuc0y+BzQ7vcQ2oNI/Qaw2cbxyXlaZzDrvcYg7XlxnaU7GSmW+Sg79PLHufSo4i8RVBz1Wm/qhnUeBYTEzlrCiYQSDw5QpHJN1XqiwnIs550FJGuI/uTSKsstsykf4BG25K3Y1gM5khM1TXgguvlirHaKI27z+lS30+H9X8jhxnpLHRq2+S8IfyF8ScxT0sKtPQnj0tG2R13BYPk7U4K7QCZ5w22Rd5opuKDYq6LaYyI3bWRyqCNtK/HTF+2A3NXFt/OG/4ibiMXujHUX0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pwdDaWVuzpSISfnq0sYokkblNP91vPNR32uGTzRmxsY=;
 b=MwQgMIYcBH8FxgnSq21irwWP0dzxzAnKgQBlbs0t5iYqD6xj1BKE+F0nH9wx3FborKthS+ShGbsF7qG0YRHg6jNfgtkzmiQUX7nFq9MYkqfgvcoyOtY7j3cKgvkiSvMVABp/Vh859f/ARmlfhwNf8cVVUpHcgy8IlHN3O7P5+TYUNmAcCsVp4FggEzRuQi28W3S+YdK42GN5WXGBBE74WaKzkqJyoxjhf7MPafHKTShtnNv0qqVcTVtOh0cYPa9U2qNLlwvXt0BOMvytuIglGE58gVX1IrtrWubguZXtAfruXtTANlm1EjTwJdGWZXsoa0/1xqs3knkC9dazJcpEiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pwdDaWVuzpSISfnq0sYokkblNP91vPNR32uGTzRmxsY=;
 b=wP29ek8Y+8ith6BE6qlP3guQM0vTFNecX3o1rvEo9pESOieIhqtxC/mT33+J9vgiiiU6e35NyHdZOEixryiDdczhOPVh5XnglWP8x3m+jLIhuYWAfTeu2QLwFW8ZrzDj5CvUXmmYDngPhh84kBgD259SdhlUMKVlvUqER1fWGzs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Christopher Clark <christopher.w.clark@gmail.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Topic: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Index: AQHY2oN8A4y+jZE/1ESf3tQREpmAra4DWdCA
Date: Fri, 7 Oct 2022 20:00:18 +0000
Message-ID: <a4524dcc-36ce-267a-afbd-5785eab73882@citrix.com>
References: <20221007193124.20322-1-jandryuk@gmail.com>
In-Reply-To: <20221007193124.20322-1-jandryuk@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH7PR03MB6996:EE_
x-ms-office365-filtering-correlation-id: 62535450-d7fd-4dcf-b8e6-08daa89e8eeb
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 CYvun8AMgO3vaN5vfA5UG/8OfdDBdyttQNHQ5ozuKhA9dFXSVMDIbCwfcQDGmOmQZxjTriRDouMRiIxhp/ZiCugq6phH87I3fqTek85P0r8OIMkwe1jG/Wm0ZdDFiV0NjrN3FVMEl6Ak8BkV2TTDWKucUYXrckj/EYCE05w2628S/39LFmJveo+/wvLvasxKl963BDqd2k60q4kMyohSgpB/HwaUqb9DNatkftQAf3q+OiVFLbMtVuPpI7QfHb7dnzWNWceVZojdaPukN8KYC9rsXZO/Y9jppERJFX2FQ+LY3n6JVXOoSXEsnG+QUAISKaVIlfr9COT1TppKFbYbz4w7vG52Blvo0e9e3TuhfoilJwcnTh9Ao7PuiMt3pMuMz3R1mmkjqvbzJTDpqoyPZ0rAwLr9TWzANFRm9T4xIsFnBR4a5PUm2gDZHDidaGmW6kDM1zgjpzNbnKbv17tsjobEfzoXexpuFqhzjCTaCYyQ7mm/HXd/JdPW4xCKRSKTfb6JL3fJQ9LH8G+T16Wbx/RDYdMBdUIMBYKiwmxjNZ2gIzKSaERUx9sOH1crn0h0NKDO14ruFtQWY7TNQOgHAC5q0+7NX9obEjXhSh9PImf5dnewgOZJQcTi0aXS2zFNK+6xCe2cgNeBnu4eo3kIbz1Vp8rKDebpXLhlXqzTIhpkyf88QX9q+vOfcMI2rWXaDogweOFP3V8eArVoGZKUmDv3oTsPZ4OCxTwvlgtPt5c5XVo/I5YAz5Xp9SmqROGZHmY3Ih4cBKKj5zQdfD0zNlR19sO6Qv9OMyQ++oYXHhX03lEERR1SyO4MtBGKA8syOrQx+yFJnNjT0/DrlAYhXA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199015)(26005)(31686004)(5660300002)(8936002)(2906002)(91956017)(36756003)(41300700001)(4326008)(110136005)(76116006)(64756008)(66476007)(54906003)(86362001)(66946007)(316002)(66446008)(66556008)(31696002)(122000001)(71200400001)(8676002)(6486002)(478600001)(6506007)(53546011)(6512007)(38070700005)(186003)(38100700002)(82960400001)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cEp6b3RTUmhHWkZ6RDJIN25LMjBnanc0aStzVDZPZm1kUkxpeC9OUXFNYk9p?=
 =?utf-8?B?VzFQMEdqSFF0WWMrQTFFVDEvWmI2aHZnOGpTanRpdDRheTF3VlppL3NTZVdh?=
 =?utf-8?B?dmZBNDluQXNweGlNVVFyTWpOMFoyMkl5WURDcXg5akVLaDlEaHVmSnVRNDRM?=
 =?utf-8?B?MFVvL1ZmOUIyTWhZMjhZSmxRcW84UjhhdzJQVzJ6M0tvMWpla2UxQ05OZjFY?=
 =?utf-8?B?ejU3QzJsai9lY2NIbGpGamNrRERFd2pSYkt5SHMrSmlwR21walRZeFVOdFZI?=
 =?utf-8?B?aEk4UkJXamRVUFo1c1NPa3l2blVwUDFTN1VvMklPRXcwY2ZrNkNteVRQR2dn?=
 =?utf-8?B?bFdsVkZRN2NOUlNKNERPVy9mcmI3clNvWk1NcVhtdlA5cG1US1A2Tnozemhn?=
 =?utf-8?B?RzlPZUs1US9sdU5uWHdCUWxManZOcC9BaHhqcE5TV1FCdVViOVI1TS9YejRV?=
 =?utf-8?B?bFlNWWdMZWVWcFpPM0V4OU4yMkliRHRINmtNemErcHVSS3dYVUlQWkRKaENi?=
 =?utf-8?B?YVIwWUtQd2FDTURXaXR4dmk3SEhrbG1oMEprVVNyZXNhdVpRRjc4Q20yMnUx?=
 =?utf-8?B?ZFZCY3lSb2pMZENoYXFjYmJMUUpJV2E1WUhrMitmOTZZUXdnR0xIcG1VdUxX?=
 =?utf-8?B?Z3oxZHhqYzZlUzBXUml4VmhMa0pQcVhHd3B0ak53UFlDQmdZM3RlYkVzam82?=
 =?utf-8?B?eGpRKzFmckVQTFZMZlprVWZlRlBVeXNLQnZ1WStBZ1F4TmRmZWtydlNSOWZH?=
 =?utf-8?B?Q09yYm55MkZiSkExSGk4Z3QvWHVJS0lKd2JaY2l2NWdWNzhDSy83MUU5bDVs?=
 =?utf-8?B?UWk1TXZ1QmFjRWpzQ0NmY3dEalBzdG91ZXpXVFNXMEVyWjlHUkY2K1cya1lK?=
 =?utf-8?B?M3lVMy9vbWcrSCs4TDlIVnVHRVU3c3FXZ3R2YWt4dUMxZjRWcG5xVk9Qajk0?=
 =?utf-8?B?M0RMbHpwc2VGRTVuNmtBaU5vWWVHcng4eUZkNUtzRTBtQmxubnZRNFM3d1FC?=
 =?utf-8?B?WjU0aUZ4NFVrakNPbkxvNkNsRkJGVGl6MmNVSzhtdHZ6LzV1U0E0WmNWQmwz?=
 =?utf-8?B?eW9sK2QwcG9NU3g0TDUvY3FEbk5DL3I4clFDTU90UkphblBXUUptSWVFSFpP?=
 =?utf-8?B?dHhVZHVRcjc5ZTI4YXY5ZG90bzZZa2laTEdmcFFLTHJiZ0ZiWE0ySElNY3lV?=
 =?utf-8?B?SnpCTmFlUWNoZ2U2ZUI5Vm1wWVlXZTNGMm1vb2RqWWFGQjFMaFJ1YkZTcWh2?=
 =?utf-8?B?Zk9JU2RvUmwzWUxGTUJCS1dJcHZjZk9tYU5OTmN5anJqK3V4MEU0U2g4NnBu?=
 =?utf-8?B?RHBEVkFUdytTd3ZDeGNXMjJYK25QYitZc09PbmFPZEJFazRhUTVwUG8rOC90?=
 =?utf-8?B?bU9nQm1yWitQQk9VaHFGMDhZZGpYUHhsRjZuRklyRXZWbjRUbHJCRm9zNG5B?=
 =?utf-8?B?NXh6SExwKzliYWVFeW0yN1FYMU9xcGZnUkVqc3VuNlhTUVdqSVB2UUNVYXJY?=
 =?utf-8?B?SUwrTjIwdlVWR3ZnSzZaeVBWaWxnQjd3Q1czbTFiQm5XdFh2a1JXUjd5L0Ew?=
 =?utf-8?B?SklWQ0hqaFgyRFRXNmRaWkxNN3RXQkw3RThVQXFpNVYvR0ExVmZYK3lSQzli?=
 =?utf-8?B?a3VxNFAyWHk3Uk9XSlNHUzF6UVpSUGNUNy9aeUx6UURubTdKck5CVGJsbGpo?=
 =?utf-8?B?eEVyaFVRV0tmS0lldHM5SG01bGE5anpiZ0daZ1NSR0VNTkt6bGtGYkFxYmZx?=
 =?utf-8?B?RTlubHVISDBYQmI3ZXVRR2puQ1JnZmN2a2NHeUJlblhwbktEWndDOHlGa2dm?=
 =?utf-8?B?OHZxTG10aUlHdW9xWnpBbnFBSDZ6MXRJekJZQmxzd2oyNkRsVHlIZEUrK0FD?=
 =?utf-8?B?bHNPRjkyQm1tMXA1Z0pFcm00L2diV0lMZk1DUHh4ekNZOVJjRDQrVHVOY05u?=
 =?utf-8?B?aUJVekdzdmxPU09VMld3WCtnM1o0RlhYb1U3KzJuRnpZZ2kwdEExdzU2SDkv?=
 =?utf-8?B?NnFlbFhUNW5NU2JQQkVERWN5Qi9yOTRzZlZTSEw2cFhnUDcreDhKUXgrYWRF?=
 =?utf-8?B?aHEvZXgyV2VRRnNTemxzQnowTmFlSmNUaXpEbkRkMnVBTWtTVXRub3c4cE9D?=
 =?utf-8?Q?Z2i+SoKdjXeOaIG9s4xX5zNtU?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <52BC2CCBABC4C446851EB950F754FC70@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62535450-d7fd-4dcf-b8e6-08daa89e8eeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 20:00:18.1989
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Aa+vSWN4vyRzTFE3zdOlNuqPe7uZV/QJyGAw5HhbWTKpKyT2JQK3kvI9g7PkutdnG+eEXW+7FaXa91P7jGmALNHsdAMVCkI0vOjpOw06H/Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6996

T24gMDcvMTAvMjAyMiAyMDozMSwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gSSBvYnNlcnZlZCB0
aGlzIEFTU0VSVF9VTlJFQUNIQUJMRSBpbiBwYXJ0bmVyX3JpbmdzX3JlbW92ZSBjb25zaXN0ZW50
bHkNCj4gdHJpcC4gIEl0IHdhcyBpbiBPcGVuWFQgd2l0aCB0aGUgdmlwdGFibGVzIHBhdGNoIGFw
cGxpZWQuDQo+DQo+IGRvbTEwIHNodXRzIGRvd24uDQo+IGRvbTcgaXMgUkVKRUNURUQgc2VuZGlu
ZyB0byBkb20xMC4NCj4gZG9tNyBzaHV0cyBkb3duIGFuZCB0aGlzIEFTU0VSVCB0cmlwcyBmb3Ig
ZG9tMTAuDQo+DQo+IFRoZSBhcmdvX3NlbmRfaW5mbyBoYXMgYSBkb21pZCwgYnV0IHRoZXJlIGlz
IG5vIHJlZmNvdW50IHRha2VuIG9uDQo+IHRoZSBkb21haW4uICBUaGVyZWZvcmUgaXQncyBub3Qg
YXBwcm9wcmlhdGUgdG8gQVNTRVJUIHRoYXQgdGhlIGRvbWFpbg0KPiBjYW4gYmUgbG9va2VkIHVw
IHZpYSBkb21pZC4gIFJlcGxhY2Ugd2l0aCBhIGRlYnVnIG1lc3NhZ2UuDQo+DQo+IFNpZ25lZC1v
ZmYtYnk6IEphc29uIEFuZHJ5dWsgPGphbmRyeXVrQGdtYWlsLmNvbT4NCg0KV2UncmUgaW50byB0
aGUgNC4xNyByZWxlYXNlIHByb2Nlc3Mgbm93LsKgIEEgYnVnZml4IGxpa2UgdGhpcyBvYnZpb3Vz
bHkNCnNob3VsZCBiZSBjb25zaWRlcmVkLCBidXQgd2lsbCBuZWVkIGFwcHJvdmFsIGZyb20gdGhl
IHJlbGVhc2UgbWFuYWdlci7CoA0KQ0MgSGVucnkuDQoNCn5BbmRyZXcNCg0KPiAtLS0NCj4gIHhl
bi9jb21tb24vYXJnby5jIHwgMyArKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo
KyksIDEgZGVsZXRpb24oLSkNCj4NCj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vYXJnby5jIGIv
eGVuL2NvbW1vbi9hcmdvLmMNCj4gaW5kZXggNzQ4Yjg3MTRkNi4uOTczZTFlOTk1NiAxMDA2NDQN
Cj4gLS0tIGEveGVuL2NvbW1vbi9hcmdvLmMNCj4gKysrIGIveGVuL2NvbW1vbi9hcmdvLmMNCj4g
QEAgLTEyOTgsNyArMTI5OCw4IEBAIHBhcnRuZXJfcmluZ3NfcmVtb3ZlKHN0cnVjdCBkb21haW4g
KnNyY19kKQ0KPiAgICAgICAgICAgICAgICAgICAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4g
ICAgICAgICAgICAgIH0NCj4gICAgICAgICAgICAgIGVsc2UNCj4gLSAgICAgICAgICAgICAgICBB
U1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4gKyAgICAgICAgICAgICAgICBhcmdvX2RwcmludGsoIiVw
ZCBoYXMgZW50cnkgZm9yIHN0YWxlIHBhcnRuZXIgZG9taWQgJWRcbiIsDQo+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHNyY19kLCBzZW5kX2luZm8tPmlkLmRvbWFpbl9pZCk7DQo+ICAN
Cj4gICAgICAgICAgICAgIGlmICggZHN0X2QgKQ0KPiAgICAgICAgICAgICAgICAgIHJjdV91bmxv
Y2tfZG9tYWluKGRzdF9kKTsNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:08:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:08:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418271.663039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogte2-00067D-Fx; Fri, 07 Oct 2022 20:08:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418271.663039; Fri, 07 Oct 2022 20:08:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogte2-000676-Ca; Fri, 07 Oct 2022 20:08:30 +0000
Received: by outflank-mailman (input) for mailman id 418271;
 Fri, 07 Oct 2022 20:08:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Hbjo=2I=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ogte0-00066k-CB
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:08:28 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cdc26f64-467b-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 22:08:26 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id ot12so13612064ejb.1
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 13:08:26 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 27-20020a170906059b00b0077ab3ca93efsm1619051ejn.223.2022.10.07.13.08.24
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 07 Oct 2022 13:08:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdc26f64-467b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=HBOe/w/Fu0j7MLMffzEkPrMeW/s5zdVs37pyRRTl5iM=;
        b=W6KR0cMugR1UnP1CCQZ3ASDqHQevdVexZ5nEPTpqCd9GiwmioTuqxaoR8OgmdgchWg
         CEbftxa2u3449IKL4hrII/xSDA6yMkUFwz3VW/z/KsAS9QExPe6K/kuawP7MzCuQwKZs
         JkFEA1Fj465vF2JpaxCWiGA2mrgugUUODqNfPXxPOk34FhJn4+XKQ6yNqhx6hPnURrql
         hEvavDxgq5VbcnASqSXacN3RY3ggUdA5yufsITuR8Djni/4jpXLEyuAOvL5LJGQNtaJJ
         UqHLojdK8IJUKj6IQaYFJV0BJnAchhp3Sgz2WNebYj88SZrqG6jVA5LKHTGVU1aZWLVE
         giMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=HBOe/w/Fu0j7MLMffzEkPrMeW/s5zdVs37pyRRTl5iM=;
        b=Kj6Yckry48Ugwhw2Ab0BJrCYybu4FyQUEMdSoEkmIddI751QisBZscC4IG/3jMNbX5
         2iRB7w56XtGTchdqH51ZHWgwR7Kb5VXgMF5kXgYJYkV/zCgO8wChEjoEDRPgiFS08zM4
         jZeZtr94MDl8rCH/TDmJrKPuUjvBdH+Cu1/k1u9UKm2QMSwJ8xzBY1lWAo9oMkAA6vJm
         AIZ2ayNZwDnW32kLPP6Eudx3aCDD1RLb8/on2BjIYwwUuvtemaqzqfzBndPXNu43nzAN
         L17pOPwDiTu3f1PIr1p3M2mKHTUGlvcwg5DKB5QgjONcyi8Xov6hCaBS3eiJtc11GOIn
         knrA==
X-Gm-Message-State: ACrzQf0j5PyXZMrr7kdqjFb1q8Lz4rwdGhQF+sOvw7Wny7W+GfNdcvlB
	eDbo9lTKp9oDYqbh1UG07BA=
X-Google-Smtp-Source: AMsMyM5tCMXYlhiuVdVI/TXN6k/EOqIbQBcV4m5rKvXyXqoxlumh/2KamC4uSAzbG1P3upXmtcCfxA==
X-Received: by 2002:a17:907:6d03:b0:782:abba:936c with SMTP id sa3-20020a1709076d0300b00782abba936cmr5438080ejc.758.1665173306030;
        Fri, 07 Oct 2022 13:08:26 -0700 (PDT)
Message-ID: <a7d21774-ec30-fa8b-e607-c8b4d43cd0ae@gmail.com>
Date: Fri, 7 Oct 2022 23:08:24 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen
 counterparts
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221006120912.1948459-1-olekstysh@gmail.com>
 <96a16b32-0950-b538-65e5-9955ed8cc529@gmail.com>
 <b3b8047e-b4a5-1e75-2a55-a7beecf8ca7d@epam.com>
 <7f54bdab-c68f-0d38-93f4-007408151f01@gmail.com>
 <816da52a-f646-c114-fa6d-9320152a0e79@epam.com>
 <677bc264-c507-3bed-6d51-0d010a0dd449@gmail.com>
 <ab4ef342-5982-6e0e-7859-eaab026d48a4@epam.com>
 <55d9f368-bf20-5439-e821-04c7709cb9a5@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <55d9f368-bf20-5439-e821-04c7709cb9a5@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10/7/22 20:35, Oleksandr Tyshchenko wrote:

Hi Oleksandr

>>>>>>> On 10/6/22 15:09, Oleksandr Tyshchenko wrote:
>>>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>>
>>>>>>>> Although XEN_PAGE_SIZE is equal to PAGE_SIZE (4KB) for now, it
>>>>>>>> would
>>>>>>>> be more correct to use Xen specific #define-s as XEN_PAGE_SIZE can
>>>>>>>> be changed at some point in the future.
>>>>>>>>
>>>>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>> ---
>>>>>>>> Cc: Juergen Gross <jgross@suse.com>
>>>>>>>> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
>>>>>>>>
>>>>>>>> As it was proposed at:
>>>>>>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!zHt-xZ_7tZc_EM6zva21E_YgwIiEeimFWfsJIpPwAu-TBcnzQhXHqlKzmXmwIcI6uIx_arHNZiaZeHt_428_8p-DyMpd$
>>>>>>>>
>>>>>>>>
>>>>>>>> [lore[.]kernel[.]org]
>>>>>>>>
>>>>>>>> Should go in only after that series.
>>>>>>>> ---
>>>>>>>>      drivers/xen/grant-dma-ops.c | 20 ++++++++++----------
>>>>>>>>      1 file changed, 10 insertions(+), 10 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/xen/grant-dma-ops.c
>>>>>>>> b/drivers/xen/grant-dma-ops.c
>>>>>>>> index c66f56d24013..5392fdc25dca 100644
>>>>>>>> --- a/drivers/xen/grant-dma-ops.c
>>>>>>>> +++ b/drivers/xen/grant-dma-ops.c
>>>>>>>> @@ -31,12 +31,12 @@ static
>>>>>>>> DEFINE_XARRAY_FLAGS(xen_grant_dma_devices,
>>>>>>>> XA_FLAGS_LOCK_IRQ);
>>>>>>>>        static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>>>>>>>>      {
>>>>>>>> -    return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant <<
>>>>>>>> PAGE_SHIFT);
>>>>>>>> +    return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant <<
>>>>>>>> XEN_PAGE_SHIFT);
>>>>>>>>      }
>>>>>>>
>>>>>>> With this change, can the offset added to the dma handle,
>>>>>>> generated by
>>>>>>> grant_to_dma(), be the offset in the page? Couldn't it corrupt the
>>>>>>> grant ref?
>>>>>>
>>>>>>
>>>>>> Good point, indeed, I think it could corrupt if guest uses a
>>>>>> different
>>>>>> than Xen page granularity (i.e 64KB).
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>>        static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>>>>>>>>      {
>>>>>>>> -    return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >>
>>>>>>>> PAGE_SHIFT);
>>>>>>>> +    return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >>
>>>>>>>> XEN_PAGE_SHIFT);
>>>>>>>>      }
>>>>>>>>        static struct xen_grant_dma_data
>>>>>>>> *find_xen_grant_dma_data(struct
>>>>>>>> device *dev)
>>>>>>>> @@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device
>>>>>>>> *dev, size_t size,
>>>>>>>>                       unsigned long attrs)
>>>>>>>>      {
>>>>>>>>          struct xen_grant_dma_data *data;
>>>>>>>> -    unsigned int i, n_pages = PFN_UP(size);
>>>>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(size);
>>>>>>>>          unsigned long pfn;
>>>>>>>>          grant_ref_t grant;
>>>>>>>>          void *ret;
>>>>>>>> @@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device
>>>>>>>> *dev, size_t size,
>>>>>>>>          if (unlikely(data->broken))
>>>>>>>>              return NULL;
>>>>>>>>      -    ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
>>>>>>>> +    ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
>>>>>>>>          if (!ret)
>>>>>>>>              return NULL;
>>>>>>>>            pfn = virt_to_pfn(ret);
>>>>>>>>            if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
>>>>>>>> -        free_pages_exact(ret, n_pages * PAGE_SIZE);
>>>>>>>> +        free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
>>>>>>>>              return NULL;
>>>>>>>>          }
>>>>>>>>      @@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct
>>>>>>>> device
>>>>>>>> *dev, size_t size, void *vaddr,
>>>>>>>>                         dma_addr_t dma_handle, unsigned long attrs)
>>>>>>>>      {
>>>>>>>>          struct xen_grant_dma_data *data;
>>>>>>>> -    unsigned int i, n_pages = PFN_UP(size);
>>>>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(size);
>>>>>>>>          grant_ref_t grant;
>>>>>>>>            data = find_xen_grant_dma_data(dev);
>>>>>>>> @@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device
>>>>>>>> *dev, size_t size, void *vaddr,
>>>>>>>>            gnttab_free_grant_reference_seq(grant, n_pages);
>>>>>>>>      -    free_pages_exact(vaddr, n_pages * PAGE_SIZE);
>>>>>>>> +    free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
>>>>>>>>      }
>>>>>>>>        static struct page *xen_grant_dma_alloc_pages(struct
>>>>>>>> device *dev,
>>>>>>>> size_t size,
>>>>>>>> @@ -168,7 +168,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>>>>>>> device *dev, struct page *page,
>>>>>>>>                           unsigned long attrs)
>>>>>>>>      {
>>>>>>>>          struct xen_grant_dma_data *data;
>>>>>>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>>>>>>> +    unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>>>>>>
>>>>>>> The offset, here, refers to the offset in the page ...
>>>>>>>
>>>>>>>>          grant_ref_t grant;
>>>>>>>>          dma_addr_t dma_handle;
>>>>>>>>      @@ -200,8 +200,8 @@ static void xen_grant_dma_unmap_page(struct
>>>>>>>> device *dev, dma_addr_t dma_handle,
>>>>>>>>                           unsigned long attrs)
>>>>>>>>      {
>>>>>>>>          struct xen_grant_dma_data *data;
>>>>>>>> -    unsigned long offset = dma_handle & (PAGE_SIZE - 1);
>>>>>>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>>>>>>> +    unsigned long offset = dma_handle & ~XEN_PAGE_MASK;
>>>>>>>
>>>>>>> ... while, here, it refers to the offset in the grant.
>>>>>>> So, the calculated number of grants may differ.
>>>>>>
>>>>>> Good point, I think you are right, so we need to additionally use
>>>>>> xen_offset_in_page() macro in xen_grant_dma_map_page(),
>>>>>>
>>>>>> something like that to be squashed with current patch:
>>>>>>
>>>>>>
>>>>>> diff --git a/drivers/xen/grant-dma-ops.c
>>>>>> b/drivers/xen/grant-dma-ops.c
>>>>>> index 9d5eca6d638a..bb984dc05deb 100644
>>>>>> --- a/drivers/xen/grant-dma-ops.c
>>>>>> +++ b/drivers/xen/grant-dma-ops.c
>>>>>> @@ -169,7 +169,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>>>>> device *dev, struct page *page,
>>>>>>                                              unsigned long attrs)
>>>>>>      {
>>>>>>             struct xen_grant_dma_data *data;
>>>>>> -       unsigned int i, n_pages = XEN_PFN_UP(offset + size);
>>>>>> +       unsigned int i, n_pages =
>>>>>> XEN_PFN_UP(xen_offset_in_page(offset)
>>>>>> + size);
>>>>>>             grant_ref_t grant;
>>>>>>             dma_addr_t dma_handle;
>>>>>>
>>>>>> @@ -191,7 +191,7 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>>>>> device *dev, struct page *page,
>>>>>>                                     xen_page_to_gfn(page) + i, dir ==
>>>>>> DMA_TO_DEVICE);
>>>>>>             }
>>>>>>
>>>>>> -       dma_handle = grant_to_dma(grant) + offset;
>>>>>> +       dma_handle = grant_to_dma(grant) +
>>>>>> xen_offset_in_page(offset);
>>>>>>
>>>>>>             return dma_handle;
>>>>>>      }
>>>>>>
>>>>>> Did I get your point right?
>>>>>>
>>>>>
>>>>> I think it 's more complicated than that.
>>>>> Let's say that the offset in page is > XEN_PAGE_SIZE, then the
>>>>> calculation of the number of grants won't take into account the part
>>>>> of the offset that is multiple of the XEN_PAGE_SIZE i.e it will
>>>>> calculate only the strictly necessary number of grants.
>>>>> But xen_grant_dma_map_page() grants access to the whole page because,
>>>>> as it can be observed in the code snippet below, it does not take into
>>>>> account the page offset.
>>>>>
>>>>> for (i = 0; i < n_pages; i++) {
>>>>>     gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
>>>>> xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
>>>>> }
>>>>
>>>>
>>>> Thanks, valid point. Agree it's indeed more complicated. I will comment
>>>> on that later. I have just pushed another fix, it is not related to
>>>> XEN_PAGE_SIZE directly, but also about page offset > PAGE_SIZE
>>>>
>>>
>>> I got a little bit confused with the order that the patches will be
>>> applied :)
>>
>> This series should go in the first [1]:
>>
>> Current patch depends on it and new patch [2] also depends on it. I
>> think (but might mistake) that current patch we need/want to postpone
>> (because it doesn't fix/improve something immediately, but more for
>> future use-cases),
>>
>> but the new patch is a fix for the real situation. Once we decide with
>> new patch [2] we will be able to return to the current patch and
>> rebase it.
>>
>>
>> [1]
>> https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/
>>
>> [2]
>> https://lore.kernel.org/xen-devel/20221007132736.2275574-1-olekstysh@gmail.com/
>>
>>
>>
>>> IIUC the above scenario cannot happen, i.e the offset to be >
>>> PAGE_SIZE, because this callback is used to map for transfer a
>>> portion of a single page.
>>
>> It happens. I have rechecked that. And can provide some debug prints
>> if needed.
> 
> 
> This is the print in xen_grant_dma_map_page() which is only triggers if
> passed offset > PAGE_SIZE (I applied it on top of [2])
> 
> @@ -195,6 +195,12 @@ static dma_addr_t xen_grant_dma_map_page(struct
> device *dev, struct page *page,
> 
>           dma_handle = grant_to_dma(grant) + dma_offset;
> 
> +       if (offset > PAGE_SIZE) {
> +               printk("%s[%d] dma_handle 0x%llx: offset 0x%lx
> (dma_offset 0x%lx gfn_offset 0x%lx) size 0x%lx n_pages %d\n", __func__,
> __LINE__,
> +                               dma_handle, offset, dma_offset,
> gfn_offset, size, n_pages);
> +               WARN_ON(1);
> +       }
> +
>           return dma_handle;
>    }
> 
> 
> At the runtime we have, for example:
> 
> [   10.277599] xen_grant_dma_map_page[199] dma_handle
> 0x8000000000044aa8: offset 0x3aa8 (dma_offset 0xaa8 gfn_offset 0x3) size
> 0x3a0 n_pages 1
> 
> [   10.277695] ------------[ cut here ]------------
> [   10.277715] WARNING: CPU: 3 PID: 122 at
> drivers/xen/grant-dma-ops.c:201 xen_grant_dma_map_page+0x194/0x1a0
> [   10.277757] Modules linked in:
> [   10.277779] CPU: 3 PID: 122 Comm: kworker/u8:6 Tainted: G        W
> 6.0.0-rc7-yocto-standard-00352-g0c5e442382bb-dirty #1
> [   10.277823] Hardware name: XENVM-4.17 (DT)
> [   10.277840] Workqueue: rpciod rpc_async_schedule
> [   10.277870] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=--)
> [   10.277897] pc : xen_grant_dma_map_page+0x194/0x1a0
> [   10.277920] lr : xen_grant_dma_map_page+0x194/0x1a0
> [   10.477036] sp : ffff800009eb34a0
> [   10.477068] x29: ffff800009eb34b0 x28: ffff0001c1e0c600 x27:
> ffff0001c0bb3f00
> [   10.477116] x26: 0000000000003aa8 x25: ffff0001c0fbab80 x24:
> fffffc0000000000
> [   10.477167] x23: 0000000000000003 x22: 0000000000000001 x21:
> 0000000000000001
> [   10.477215] x20: fffffc0007048800 x19: 8000000000044aa8 x18:
> 0000000000000010
> [   10.477265] x17: 657366666f203a38 x16: 00000000deadbeef x15:
> 3030303030303878
> [   10.477311] x14: 00000000000005d5 x13: ffff0001c0fbafe0 x12:
> 00000000ffffffea
> [   10.477361] x11: 00000000ffffefff x10: 00000000ffffefff x9 :
> ffff80000969acc0
> [   10.477407] x8 : 0000000000017fe8 x7 : c0000000ffffefff x6 :
> 000000000000bff4
> [   10.477459] x5 : 0000000000057fa8 x4 : 0000000000000000 x3 :
> ffff800009eb3238
> [   10.477507] x2 : acd9abf2a61fc800 x1 : 0000000000000000 x0 :
> 000000000000007f
> [   10.477554] Call trace:
> [   10.477570]  xen_grant_dma_map_page+0x194/0x1a0
> [   10.477608]  dma_map_page_attrs+0x1d4/0x230
> [   10.477638]  vring_map_one_sg+0x60/0x70
> [   10.477668]  virtqueue_add_outbuf+0x248/0x780
> [   10.477705]  start_xmit+0x1d0/0x518
> [   10.477734]  dev_hard_start_xmit+0x98/0x158
> [   10.477767]  sch_direct_xmit+0xec/0x378
> [   10.477795]  __dev_queue_xmit+0x5b8/0xc50
> [   10.477820]  ip_finish_output2+0x234/0x560
> [   10.477853]  __ip_finish_output+0xac/0x268
> [   10.477878]  ip_output+0xfc/0x1b0
> [   10.477905]  ip_local_out+0x48/0x60
> [   10.477934]  __ip_queue_xmit+0x140/0x3c8
> [   10.477960]  ip_queue_xmit+0x14/0x20
> [   10.477986]  __tcp_transmit_skb+0x480/0xad0
> [   10.478014]  tcp_write_xmit+0x5dc/0x1048
> [   10.478045]  __tcp_push_pending_frames+0x3c/0xc8
> [   10.478077]  __tcp_sock_set_cork.part.0+0x60/0x70
> [   10.478113]  tcp_sock_set_cork+0x50/0x68
> [   10.478141]  xs_tcp_send_request+0x1d0/0x248
> [   10.478174]  xprt_transmit+0x154/0x298
> [   10.478206]  call_transmit+0x98/0xb0
> [   10.478232]  __rpc_execute+0xb0/0x338
> [   10.478258]  rpc_async_schedule+0x2c/0x50
> [   10.478286]  process_one_work+0x1d0/0x320
> [   10.478314]  worker_thread+0x4c/0x400
> [   10.478341]  kthread+0x110/0x120
> [   10.478371]  ret_from_fork+0x10/0x20
> [   10.478399] ---[ end trace 0000000000000000 ]---
> 
> 
> We get an offset 0x3aa8. We are in the process of mapping virtio
> descriptor which is passed from the top level as scatterlist, according
> to the dump
> 
> the dma_map_page() is called from here with scatterlist parameters:
> 
> https://elixir.bootlin.com/linux/v6.0-rc7/source/drivers/virtio/virtio_ring.c#L363
> 
> So we are not dealing with a range within a single page.
> 
> 
> Or I really missed something.
> 
> 

No, you are right. I had a look at the code as well. It's legal for an 
sg to have offset greater than the page size. So, yes the code needs to 
account for this. And the size can be greater than the page size (since 
this is legal too for the sg length). My mistake.

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:21:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:21:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418277.663050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtqx-0000HL-MF; Fri, 07 Oct 2022 20:21:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418277.663050; Fri, 07 Oct 2022 20:21:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtqx-0000HE-J0; Fri, 07 Oct 2022 20:21:51 +0000
Received: by outflank-mailman (input) for mailman id 418277;
 Fri, 07 Oct 2022 20:21:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogtqx-0000H8-2o
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:21:51 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id abac773d-467d-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 22:21:49 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D21A361747;
 Fri,  7 Oct 2022 20:21:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 793CAC433D6;
 Fri,  7 Oct 2022 20:21:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abac773d-467d-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665174107;
	bh=9OcpNfdxowuCuZpBtOE0r/z8WUxNp3Cb1zXxvRedLZ0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=O/5nKnWWHEwNOyrth2TImx6RE2uH9RnaPalmza1/8vqf4V7CuJAuyWMAh4U468hEW
	 SHUrPxdmriFufGxVTwFo5d9XRYNSzDgoZkAP6L6POUK+5ZVvzmS3OeIrzCBbMFQ88p
	 0IqP0s6y/AEpv3/F14tNkAy8ZPLVGfySA5iwj04Yk/Qf4XBzBweSFgK8gODqXBt7I4
	 aMTW6PAKOy2iHNjz7w4hjXhRM/IYXbx5jiSho5WGXKkV8z4YjF88rexbbMx+vPwhGd
	 DP0O9BibbLQrdbteFBRNMP3mhjCGCoqOp94igA8mB/d5Axi1ObhFcsQjrpDIM24HDO
	 o747B5esXoCYQ==
Date: Fri, 7 Oct 2022 13:21:44 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: dega kiran <degakiran05@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    mubin.sayyed@amd.com
Subject: Re: Free Rtos porting on XEN
In-Reply-To: <CADY+DPK7HQBYCPNoRf5KW6Zaqx6bF8fUrtywiR49zXiWkiC+zw@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210071316300.3690179@ubuntu-linux-20-04-desktop>
References: <CADY+DPLf10UtUWE7Y9zZvN0NRFkGtV7ah3dg8t4wYWrF=8R2LQ@mail.gmail.com> <CADY+DPK7HQBYCPNoRf5KW6Zaqx6bF8fUrtywiR49zXiWkiC+zw@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1388137786-1665173905=:3690179"
Content-ID: <alpine.DEB.2.22.394.2210071318580.3690179@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1388137786-1665173905=:3690179
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210071318581.3690179@ubuntu-linux-20-04-desktop>

Hi Dega,

For Xen on Raspberry PI 4, that should work out of the box now and there
are a few users on xen-devel that got it to work successfully recently.
One of the documents that describes how to get Xen to run on RPi4 in
details is the following, although it is 2 years old now:
https://xenproject.org/2020/09/29/xen-on-raspberry-pi-4-adventures/

Specifically for FreeRTOS, I cannot help as I don't have any experience
with FreeRTOS outside of Xilinx boards. However, it might help you
to begin with Xilinx FreeRTOS, which is known to work on Xen, then try
to see how to port it to RPi4. The link I provided
(https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842141/FreeRTOS)
should have detailed information about Xilinx FreeRTOS.

Cheers,

Stefano



On Fri, 7 Oct 2022, dega kiran wrote:
> Hi Stefano Stabellini ,
> Thanks for the reply.
> 
> We are currently working on Raspberry PI 4 can you help us how we can port Xen with FreeRtos on Raspberry PI4.
> 
> Is there any reference I can go through for porting Xen with FreeRtos on Raspberry PI4.?
> 
> 
> Thanks and regards,
> Dega. 
> 
> On Tue, Oct 4, 2022 at 9:48 AM dega kiran <degakiran05@gmail.com> wrote:
>       Hi ,
> I am trying to port FREERtos on XEN . But not getting any concrete information for porting.
> 
> I am following https://github.com/GaloisInc/FreeRTOS-Xen
> 
> but getting a lot of errors.
> 
> Please Let me know how to follow the porting process.
> 
> 
> Thank you,
> Dega.
> 
> 
> 
--8323329-1388137786-1665173905=:3690179--


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:25:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:25:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418283.663061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtu6-0000zG-3t; Fri, 07 Oct 2022 20:25:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418283.663061; Fri, 07 Oct 2022 20:25:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogtu6-0000z9-1F; Fri, 07 Oct 2022 20:25:06 +0000
Received: by outflank-mailman (input) for mailman id 418283;
 Fri, 07 Oct 2022 20:25:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogtu4-0000z3-Ux
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:25:04 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 20150a9b-467e-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 22:25:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0D540B818F6;
 Fri,  7 Oct 2022 20:25:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E240FC433C1;
 Fri,  7 Oct 2022 20:25:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20150a9b-467e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665174301;
	bh=+DBDu+TIZ0+ezgXh+xEGUEbnY9odLaY1vmGFN84T6wA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sHRX6GBnNB4GS4TxSGIU21ok/25B+7t7xqremaM++vDU6ZmYINhMkDQKNAwe61Q/P
	 LcZNUlRWKJAxvcRm0fGNjXfmo5ldnudDe3YIl01/8p6iz/zj5S54/b2mC/9KUGhxVN
	 kKgKV4hsz2tcU+uUttS76wS8sOEZvyC1iNVD7sqv2ODvuJHg2wJEkFo5rOK7L/YrEo
	 qkdE0vangyGFPiVRCblU4R19pa/CtrIh+QMVx7hFMZfprXYKlimHZ+G14vn6xNjJOL
	 zud5HjJUIL+DHPZFi53N6maMnCWmDO4fdxKmL8VuBto4XJAtptK2w2Hr1yq1aiV1zu
	 dhl3vxW2hPGDw==
Date: Fri, 7 Oct 2022 13:24:58 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org, 
    linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
In-Reply-To: <014e7036-5daf-6465-663c-b690d6f719ee@suse.com>
Message-ID: <alpine.DEB.2.22.394.2210071324010.3690179@ubuntu-linux-20-04-desktop>
References: <20221006174804.2003029-1-olekstysh@gmail.com> <014e7036-5daf-6465-663c-b690d6f719ee@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 7 Oct 2022, Juergen Gross wrote:
> On 06.10.22 19:48, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > 
> > Use the same "xen-grant-dma" device concept (based on generic IOMMU
> > device-tree bindings) for the PCI devices behind device-tree based
> > PCI Host controller.
> > 
> > Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > ---
> > Slightly RFC. This is needed to support Xen grant mappings for virtio-pci
> > devices
> > on Arm at some point in the future. The Xen toolstack side is not published
> > yet.
> > Here, for PCI devices we use the same way to pass backend domid to the guest
> > as for
> > platform devices.
> 
> I should mention we decided at the Xen Summit, that I will start a try to
> modify the virtio spec to include the backend id (domid in the Xen case)
> in the device independent config part.

Good idea


> As this will take some time to be accepted (if ever), other means to
> specify the backend domid are needed until then. DT is one possibility
> (at least on Arm), while Xenstore is the way to go for setups with a
> Xen toolstack.

What do you think of my idea of using PCI config registers on the *root
complex* (not the device) to retrieve the information?


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:33:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:33:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418301.663090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogu2U-00035N-CK; Fri, 07 Oct 2022 20:33:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418301.663090; Fri, 07 Oct 2022 20:33:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogu2U-00035G-7c; Fri, 07 Oct 2022 20:33:46 +0000
Received: by outflank-mailman (input) for mailman id 418301;
 Fri, 07 Oct 2022 20:33:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogu2S-0002u5-4p
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:33:44 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 55004645-467f-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 22:33:42 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6650561DD2;
 Fri,  7 Oct 2022 20:33:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E36FC433D6;
 Fri,  7 Oct 2022 20:33:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55004645-467f-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665174820;
	bh=dVFICHtaG+JkviHXFXOU1zYcJHQZVRLeOHTl8JVmAJc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mQm4ewWr+It2XZsEf4o4WiGWcReJ1VhX+yJq3CndHkPymXly8CiMzO49aO/pjcHgP
	 glxGQm+fn4wGE+GNx29OK5qD4Q+W24+8V3NQv+aKcQvOXadvmKp08EeQ0Mhg2jVJJy
	 0WPYInHV2JII9r55zFVQ8WKmLbJsupURyGHrmI/POn1jS2CZfOQxsLyrPbFPKbiUe2
	 uqoCc/c4o059L2OAVLJwK8Ew0RHnM6r9s0LEgSeQ389rCGgZwv7QbV05wDXh+Gv8S2
	 qMLiNAFFnVbqCzB3wRybhdFjVjH6lUEuLjXu/kqXlnQl+jxOFi3M2DyHHQ6MGwpF44
	 +OLctm8qDN5Og==
Date: Fri, 7 Oct 2022 13:33:38 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, stefano.stabellini@amd.com, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH] ImageBuilder: Add support for 64-bit addresses
In-Reply-To: <25626565-ba7d-265b-38f5-003b0b504d67@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210071332420.3690179@ubuntu-linux-20-04-desktop>
References: <20221006102035.16281-1-michal.orzel@amd.com> <alpine.DEB.2.22.394.2210061349110.3690179@ubuntu-linux-20-04-desktop> <25626565-ba7d-265b-38f5-003b0b504d67@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 7 Oct 2022, Michal Orzel wrote:
> Hi Stefano,
> 
> On 07/10/2022 00:34, Stefano Stabellini wrote:
> > 
> > 
> > +xen-devel
> > 
> > On Thu, 6 Oct 2022, Michal Orzel wrote:
> >> At the moment, ImageBuilder assumes that all addresses/sizes are
> >> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
> >> value for the first cell. Because of that, we cannot specify MEMORY_START
> >> and MEMORY_END to be above 32-bits (e.g. to place the images in the
> >> upper memory bank).
> >>
> >> Add support to properly handle 64-bit addresses:
> >>  - add function split_into_halves to split the value passed as a first
> >>    argument into upper and lower halves. These are then set as values for
> >>    variables passed respetively as the second and third argument,
> >>  - whenever there is a variable storing the full 64-bit number with
> >>    "addr" or "size" in name, introduce two additional variables with
> >>    "addr1,addr2"/"size1,size2" in name to store the halves. These are
> >>    then used to properly set cells.
> >>
> >> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> >>
> >> ---
> >>  scripts/uboot-script-gen | 60 +++++++++++++++++++++++++++++++++++-----
> >>  1 file changed, 53 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> >> index 16269f02f1e7..4c6525a910f3 100755
> >> --- a/scripts/uboot-script-gen
> >> +++ b/scripts/uboot-script-gen
> >> @@ -25,6 +25,14 @@ function dt_mknode()
> >>      fi
> >>  }
> >>
> >> +# Usage:
> >> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
> >> +function split_into_halves()
> >> +{
> >> +    eval "$2=$(printf "0x%X\n" $(($1 >> 32)))"
> >> +    eval "$3=$(printf "0x%X\n" $(($1 & 0xFFFFFFFF)))"
> >> +}
> > 
> > I know it is the same thing, but I would prefer the following version
> > because it makes it easier to read:
> > 
> > # Usage:
> > # split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
> > function split_into_halves()
> > {
> >     local value=$1
> >     local upper=$2
> >     local lower=$3
> > 
> >     eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
> >     eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
> > }
> That is ok for me.
> 
> > 
> > 
> >> +
> >>  # data_type is either
> >>  #   int
> >>  #   hex
> >> @@ -41,10 +49,14 @@ function dt_set()
> >>
> >>      if test $data_type = "var"
> >>      then
> >> -        eval data_addr_var="$data"_addr
> >> -        eval data_addr=\$"$data_addr_var"
> >> -        eval data_size_var="$data"_size
> >> -        eval data_size=\$"$data_size_var"
> >> +        eval data_addr1_var="$data"_addr1
> >> +        eval data_addr2_var="$data"_addr2
> >> +        eval data_addr1=\$"$data_addr1_var"
> >> +        eval data_addr2=\$"$data_addr2_var"
> >> +        eval data_size1_var="$data"_size1
> >> +        eval data_size2_var="$data"_size2
> >> +        eval data_size1=\$"$data_size1_var"
> >> +        eval data_size2=\$"$data_size2_var"
> > 
> > To avoid making the code more complex, is it possible to stick with just
> > a single data_addr variable in u-boot and calculate the upper and lower
> > 32-bit using u-boot commands?
> The reason why we need these extra variables is to add them into respective
> cells under different nodes. In dt_set we need to put the variable names
> for dynamic assignment and variable values for static assignment. We cannot
> do this having a single pair data_addr_var,data_addr. These evals corresponds
> to variables from xen_file_loading. dt_set and add_size are two different
> functions. The former is used to create the nodes and the latter is used to
> set values for the environment variables.
> 
> Example:
> dt_set "/chosen/dom0" "reg" "var" "dom0_linux"
> - this will create a reg property for dom0 kernel. We need to insert the upper
> and lower halves into this property (so we need separate variables for that)
> e.g.
> reg <0x${dom0_linux_addr1} 0x${dom0_linux_addr2} 0x${dom0_linux_size1} 0x${dom0_linux_size2}>
> 
> load_file $DOM0_KERNEL "dom0_linux" calling add_size
> - this will set values for upper and lower halves into u-boot env variables
> that corresponds to variables we placed previously in reg property,
> e.g.
> setenv dom0_linux_addr1 ${memaddr1}
> setenv dom0_linux_addr2 ${memaddr2}
> setenv dom0_linux_size1 ${filesize1}
> setenv dom0_linux_size2 ${filesize2}
> 
> FWICS, we cannot achieve this using a single pair.

OK. In that case please rebase the patch on the "master-next" branch.
We'll figure out how to handle the dynamic address calculation at a
later time.


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:35:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:35:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418321.663101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogu3j-0003yJ-Ps; Fri, 07 Oct 2022 20:35:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418321.663101; Fri, 07 Oct 2022 20:35:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogu3j-0003y8-N2; Fri, 07 Oct 2022 20:35:03 +0000
Received: by outflank-mailman (input) for mailman id 418321;
 Fri, 07 Oct 2022 20:35:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pvqn=2I=gmail.com=colin.i.king@srs-se1.protection.inumbo.net>)
 id 1ogu3i-0002Po-JT
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:35:02 +0000
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com
 [2a00:1450:4864:20::32a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8486f87a-467f-11ed-964a-05401a9f4f97;
 Fri, 07 Oct 2022 22:35:01 +0200 (CEST)
Received: by mail-wm1-x32a.google.com with SMTP id
 c3-20020a1c3503000000b003bd21e3dd7aso5209562wma.1
 for <xen-devel@lists.xenproject.org>; Fri, 07 Oct 2022 13:35:01 -0700 (PDT)
Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net.
 [80.193.200.194]) by smtp.gmail.com with ESMTPSA id
 q6-20020a05600c46c600b003c3c2df83ddsm1603609wmo.26.2022.10.07.13.35.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 07 Oct 2022 13:35:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8486f87a-467f-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=eAZ+qkXDXQxhybmpEVudKGXqy+FOYvvtvTW3/3P6xc4=;
        b=OEH5qQ9HbftMfggzW1MXzuzAbSXlsGWSI8v2Y7HW6NJ9gyPAy+DbHUdn1YOVoE7Q2S
         OeEwH6yXMTGDC8b998q7Lp4o9s1oMt4K6pu04HBI7G9D/XdocUnSMjVv8OGoXNWGRMBN
         qW15Whnb5fAgQH47L/TMvxX2wMYtZZGe2uk8R8DMBv5YAhUDhOmnNk0w2/4Xw8DYE5A3
         Oqxt2KEBMxFf+j+quLL+QW/2W3JUZoUv0SXZHZiZI+MGnLSkEZQWV8UHB6plAwQ1iIb4
         8FI4xY2mUJjcRF6ASxESDbP6leSAmZc36/agmiv7gsD3wT8d6+DeAAxdmk9+bEz94Ffg
         tI/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=eAZ+qkXDXQxhybmpEVudKGXqy+FOYvvtvTW3/3P6xc4=;
        b=PT84Uk0ajPNXoCwDAjqok18zvsZKcNzp9AWRX1VqGH+Kg/uMPedQBXKdKOqSt7/fjW
         BtfbApAeIgTmik84/GLqg/D4B8oK39GHPUtw2n3xGRc3Qm6Gf3jh9UoEZpuL7Gv2zOeA
         x90jEFkSZ1aza8iCv3pE8MWI97iWS5XD3Slhpx0I8p6lQpLzDbfUkDIMT1MSx+Nu4EsK
         ejfIL7zqKmzWA5KnhtapKGnFdbcNe88zLOp5a918cMO0IHrLdiMYUnoHz1ROcCFSIYg7
         OWJqiaL9hrY+JUIUQ+YVNQRJXyPjp6uubeENKJQcDs3TNEbxj/ZK18LCEhVexFFCYVB7
         wayQ==
X-Gm-Message-State: ACrzQf2XQYpQG2LAwweR3DFsxAda8XyetDgHq6OVhOJaKEA3CICgZLpQ
	WbIlqT595S4W6czK5GCNhWUCPVBXBVvMJE+S
X-Google-Smtp-Source: AMsMyM4CKIHDZoGddh2wMguI39VshoESTcUZatEZKQ9RPfSxxCAvYDZIiTWTWyr5m5Cyec5F076sYg==
X-Received: by 2002:a05:600c:524b:b0:3b4:8c0c:f3b6 with SMTP id fc11-20020a05600c524b00b003b48c0cf3b6mr12110120wmb.50.1665174901421;
        Fri, 07 Oct 2022 13:35:01 -0700 (PDT)
From: Colin Ian King <colin.i.king@gmail.com>
To: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] xen: Kconfig: Fix spelling mistake "Maxmium" -> "Maximum"
Date: Fri,  7 Oct 2022 21:35:00 +0100
Message-Id: <20221007203500.2756787-1-colin.i.king@gmail.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

There is a spelling mistake in a Kconfig description. Fix it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/xen/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index a65bd92121a5..d5d7c402b651 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -56,7 +56,7 @@ config XEN_MEMORY_HOTPLUG_LIMIT
 	depends on XEN_HAVE_PVMMU
 	depends on MEMORY_HOTPLUG
 	help
-	  Maxmium amount of memory (in GiB) that a PV guest can be
+	  Maximum amount of memory (in GiB) that a PV guest can be
 	  expanded to when using memory hotplug.
 
 	  A PV guest can have more memory than this limit if is
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 07 20:50:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 20:50:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418341.663112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oguIM-0006c5-4B; Fri, 07 Oct 2022 20:50:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418341.663112; Fri, 07 Oct 2022 20:50:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oguIM-0006by-1f; Fri, 07 Oct 2022 20:50:10 +0000
Received: by outflank-mailman (input) for mailman id 418341;
 Fri, 07 Oct 2022 20:50:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oguIK-0006bs-Jb
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 20:50:08 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ffaa9b1-4681-11ed-9377-c1cf23e5d27e;
 Fri, 07 Oct 2022 22:50:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 191B8B8245F;
 Fri,  7 Oct 2022 20:50:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF73CC433D6;
 Fri,  7 Oct 2022 20:50:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ffaa9b1-4681-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665175804;
	bh=0COepWKyJnS9dnJU4MRagprS9XKGb+mdMm+zs9Dr6HE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=R/n6C/ZHW3VrvpAReWY3qdvA79riZ/1MusojdeFSgo0zXBaJuWF7/EsFlejjbdhbA
	 HfYNa/R/vjeOfG/cbXSRt/c/QWLPU3V9wvdIj+Wvl9FQq6g5Rm2k99ZyvUKGNKOS50
	 w2TSPMmU0MRzpxFZu/fxXw5XDLhjbB78YGRG8IOt+9TnWwAHBD6KJEItHTx8IENWFn
	 4TlrGPMGu2JRkkeI2o5Xdt0DmziV+Gb4TybLkj5whz0J+5Pniku6VSb3hsWPNtpGeT
	 zf/+7P5+ET0o/PlhsGhQzf9/LrhWMPJyBCcAgWVN6rw25vZiipnF+cWQsRxAWgENp5
	 VpRZ1Y7utai9A==
Date: Fri, 7 Oct 2022 13:50:01 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Colin Ian King <colin.i.king@gmail.com>
cc: Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen: Kconfig: Fix spelling mistake "Maxmium" ->
 "Maximum"
In-Reply-To: <20221007203500.2756787-1-colin.i.king@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210071349510.3690179@ubuntu-linux-20-04-desktop>
References: <20221007203500.2756787-1-colin.i.king@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 7 Oct 2022, Colin Ian King wrote:
> There is a spelling mistake in a Kconfig description. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  drivers/xen/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index a65bd92121a5..d5d7c402b651 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -56,7 +56,7 @@ config XEN_MEMORY_HOTPLUG_LIMIT
>  	depends on XEN_HAVE_PVMMU
>  	depends on MEMORY_HOTPLUG
>  	help
> -	  Maxmium amount of memory (in GiB) that a PV guest can be
> +	  Maximum amount of memory (in GiB) that a PV guest can be
>  	  expanded to when using memory hotplug.
>  
>  	  A PV guest can have more memory than this limit if is
> -- 
> 2.37.3
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 07 23:37:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 07 Oct 2022 23:37:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418353.663122 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogwtw-0006Pm-WE; Fri, 07 Oct 2022 23:37:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418353.663122; Fri, 07 Oct 2022 23:37:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogwtw-0006Pf-Te; Fri, 07 Oct 2022 23:37:08 +0000
Received: by outflank-mailman (input) for mailman id 418353;
 Fri, 07 Oct 2022 23:37:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FwH6=2I=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogwtv-0006PW-CF
 for xen-devel@lists.xenproject.org; Fri, 07 Oct 2022 23:37:07 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f357f94f-4698-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 01:37:05 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 8F653B82477;
 Fri,  7 Oct 2022 23:37:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB729C433D6;
 Fri,  7 Oct 2022 23:37:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f357f94f-4698-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665185823;
	bh=Fx92Kd7vOkHb9hMJxKf9wpeSGLssJpRdqrhZafJUckA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=FZTTzhRCVxXmwNn3k88Ctc+jiXRctfZFGcV441irl/LYB/zz8baek81f8bYyRaWg5
	 5972v6N8PtbZ1CFKK6gKzCAyZ4OYb3mxBe+WqwQN3l5rV9eFJXjawXggfoSqjyfWmX
	 3QAvXKEqp2v/vn8w0IIJY/2TIyIb39Wec8JNDd5OSKpxhSpPSxCkokh4nWZWgblp2V
	 DQhBpr5eAouXuWoKxxGxCQUMJsHEyMpQ/y+dw0xQXbr4QRIhMfH7klLi6GoqdyPBY1
	 oHEgbEhLAcN56tApHnZwjhQsWLSdvWLvkxZZ3sE8WSF0kIvl4Rqh1CWdB88I3C2x+q
	 upn99qiX6LO+w==
Date: Fri, 7 Oct 2022 16:36:59 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>, Doug Goldstein <cardoe@cardoe.com>, 
    michal.orzel@amd.com
Subject: Re: [PATCH v1 0/4] Yocto Gitlab CI
In-Reply-To: <cover.1661352827.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210071618300.3690179@ubuntu-linux-20-04-desktop>
References: <cover.1661352827.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 24 Aug 2022, Bertrand Marquis wrote:
> This patch series is a first attempt to check if we could use Yocto in
> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
> 
> The first patch is making sure build-yocto.sh is not catched by
> gitignore.
> 
> The second patch is creating a container with all elements required to
> build Yocto, a checkout of the yocto layers required and an helper
> script to build and run xen on qemu with yocto.
> 
> The third patch is creating containers with a first build of yocto done
> so that susbsequent build with those containers would only rebuild what
> was changed and take the rest from the cache.
> 
> The fourth patch is adding a way to easily clean locally created
> containers.
> 
> This is is mainly for discussion and sharing as there are still some
> issues/problem to solve:
> - building the qemu* containers can take several hours depending on the
>   network bandwith and computing power of the machine where those are
>   created
> - produced containers containing the cache have a size between 8 and
>   12GB depending on the architecture. We might need to store the build
>   cache somewhere else to reduce the size. If we choose to have one
>   single image, the needed size is around 20GB and we need up to 40GB
>   during the build, which is why I splitted them.
> - during the build and run, we use a bit more then 20GB of disk which is
>   over the allowed size in gitlab
> 

So I tried to build one of the build containers on my x86 workstation
with the following:

  make yocto/kirkstone-qemuarm64

but I get an error from the build:

  21:30:20 build qemuarm64: Error
  22:00:38 run qemuarm64: Error
  22:00:41 Build Complete (2 errors)
  The command '/bin/sh -c /home/$USER_NAME/bin/build-yocto.sh $target' returned a non-zero code: 2

Anyone else is having a better luck than me?


I don't think it is a problem if it takes a long time to build the build
containers because they are not built often and they are not built as
part of the gitlab-ci runs.

The issue could be the resulting container size. I wasn't aware of a
limit in gitlab -- I would like to try if there is a way around the
limit (either by changing a setting, or potentially switching to a
premium account.) However I need to be able to complete a container
build first :-)

How did you find out about the 20 GB limit? I couldn't find it in the
docs. The only info I could find states that there is no hard limit on
registry.gitlab.com.

Cheers,

Stefano


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 00:15:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 00:15:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418359.663133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxV8-00035T-FU; Sat, 08 Oct 2022 00:15:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418359.663133; Sat, 08 Oct 2022 00:15:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxV8-00035M-Cr; Sat, 08 Oct 2022 00:15:34 +0000
Received: by outflank-mailman (input) for mailman id 418359;
 Sat, 08 Oct 2022 00:15:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZrwE=2J=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogxV6-00035E-TF
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 00:15:32 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 51292a78-469e-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 02:15:31 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 5AFF060EB7;
 Sat,  8 Oct 2022 00:15:29 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C7A1C433C1;
 Sat,  8 Oct 2022 00:15:27 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51292a78-469e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665188128;
	bh=66MHEqgacifMYHlGPJDL6vHpddMit9yKPTRA+6tWWlg=;
	h=Date:From:To:cc:Subject:From;
	b=PiUavO+l63Z10gGUDX9yI0EUvRRUaraIWQduPdARl/uCJ1Zh6CSJHFaOjYSIXKo8e
	 0+BLm3DbCDN5qrNnM9Q5f4emg6buFulkbaONh65tSfmO1TdLwcU9Qvl/x5LKocKQ6z
	 KWJCkQDLh6hg8Pq32Jy/Yj279tlQQfOTr37zo+KMM9ofjI8ZMMXv4hUZHEloh97P9H
	 WwFVo1Mi3RPWRzhNqrSLz/5qAQBPB5MMfjcfFbdrX4TJaMQk5WX9axfPqwnXp3tQor
	 FRY06+1LoGeDaicSJcYqlq1rRtPNiYfnunR+Z6qgEZn8hOSqfPE8MjovXuQNkuTnZh
	 PeAtTFidAZWsQ==
Date: Fri, 7 Oct 2022 17:15:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, jbeulich@suse.com, 
    george.dunlap@citrix.com, andrew.cooper3@citrix.com, 
    bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, roger.pau@citrix.com
Subject: [PATCH v3 0/4] introduce SPDX
Message-ID: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

This small series introduces SPDX tags to Xen:

1) add a mention to SPDX in CODING_STYLE
2) add a LICENSES directory with licenses and SPDX tags
3) adds the SPDX single-line comment to arch/arm/*.c

Note that arch/arm/*.c is just a start. Also, to make the changes as
mechanical as possible I restricted myself to:
- adding the single-line comment at the top of the file
- removing the copyright lines (when present) from the top of the file
  header

I purposedly restrained myself to do other cleanups to the headers: this
series already touches many files and I prefer to keep these changes as
mechanical as possible. Further improvements (style improvement,
removing what's left of the header, removing copyright lines, etc.) can
be done with subsequent patches more easily.

License changes are not intentional.

Cheers,

Stefano


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 00:15:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 00:15:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418361.663145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVR-0003ST-Oy; Sat, 08 Oct 2022 00:15:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418361.663145; Sat, 08 Oct 2022 00:15:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVR-0003Ri-LN; Sat, 08 Oct 2022 00:15:53 +0000
Received: by outflank-mailman (input) for mailman id 418361;
 Sat, 08 Oct 2022 00:15:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZrwE=2J=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogxVQ-00035E-BR
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 00:15:52 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5e1bdebb-469e-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 02:15:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 42A1CB823E4;
 Sat,  8 Oct 2022 00:15:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84A33C433D6;
 Sat,  8 Oct 2022 00:15:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e1bdebb-469e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665188150;
	bh=Pn0SMEjA4kouOtSJc3+2PqkihW2Mj/UTC9QmDMLz6gU=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=PsrT/GWgiKv+EXj2535+PgO3VFTa3Cf2Hzqod7FlQsrbHKdGBuGbYAD7HFxxsivHz
	 20Zo5je+3K57QOP0L/5N6FWeAKnlQkDFaXg1on9rsGtL4O5UTPpR8zO9WVxFCByD8r
	 33TQLTAPShx6Qyuaq56JrfmF/d/NFPH/12cBVjmvmHrQFHjxh83he2wzv0yU88Nk3B
	 JLsIPIk09WL673A1veSyMyPJsClEvRQvHMAkR4p7lNN9SyXwwbnIkwKe8o/2SAfRIb
	 ltOODlzCWLH9MdmPP+4Apws2lxsqeUNaFaPu9K6fIaSxAXLxminne3YreuZ0GyXxxB
	 SaQLDBwjTROeQ==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v3 1/4] Add SPDX to CODING_STYLE
Date: Fri,  7 Oct 2022 17:15:41 -0700
Message-Id: <20221008001544.78302-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 CODING_STYLE | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/CODING_STYLE b/CODING_STYLE
index 3386ee1d90..5faf274b3a 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but often implicitly (Linux
 coding style is fairly common). In general you should copy the style
 of the surrounding code. If you are unsure please ask.
 
+SPDX
+----
+
+New files should start with a single-line SPDX comment to express the
+license, e.g.:
+
+/* SPDX-License-Identifier: GPL-2.0 */
+
+See LICENSES/ for a list of licenses and SPDX tags currently used.
+
 MISRA C
 -------
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 00:16:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 00:16:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418365.663156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVX-0003oj-Vh; Sat, 08 Oct 2022 00:15:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418365.663156; Sat, 08 Oct 2022 00:15:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVX-0003oY-Ss; Sat, 08 Oct 2022 00:15:59 +0000
Received: by outflank-mailman (input) for mailman id 418365;
 Sat, 08 Oct 2022 00:15:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZrwE=2J=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogxVW-00035E-Qk
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 00:15:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6029d821-469e-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 02:15:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8D95361E13;
 Sat,  8 Oct 2022 00:15:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AE2BC433D6;
 Sat,  8 Oct 2022 00:15:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6029d821-469e-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665188154;
	bh=nkf5f1s9b73fs5L0inbQYTQtvT4GFe9oF/f4l6y5xS8=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=N/Eo7HuM/0fTqi8sFEsdzbpcafKvl7xqA6iaV4+eUdzefsftYGWCDrlsGByaI+plB
	 w9Mlh3tu8NAlCP6a9gdSlfpJiAOwy7d4tzShs0SstByuEZuCSDs4FAvQKl5a7A4vBm
	 EmnluaUJckHpUMG0fI0+vTzsmGAbArJRGEabWllQsogW3lKPJ4ANo2VSJwxYN+hxaC
	 QnK9WYu2wJxtGfVuxulTBymJmttWMppbIMaJFEzmeHk92JltkipzTpsoK0XCQGHxLb
	 rp/D//MLoHG81LfOpLHk6lveQWzOj/WkNGhUSaKOio21xJ/IObeWSNc5sQU7DmwlfE
	 Xj8QRXPzmSYBg==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v3 3/4] add SPDX to arch/arm/*.c
Date: Fri,  7 Oct 2022 17:15:43 -0700
Message-Id: <20221008001544.78302-3-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Add SPDX license information to all the *.c files under arch/arm.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
Changes in v3:
- change xen/arch/arm/domain_page.c to GPL-2.0-or-later

Changes in v2:
- use /* */
- actually check use the right license
- remove stale copyright info from top of the file header
---
 xen/arch/arm/alternative.c        | 13 +------------
 xen/arch/arm/bootfdt.c            |  5 +----
 xen/arch/arm/cpuerrata.c          |  1 +
 xen/arch/arm/cpufeature.c         | 13 +------------
 xen/arch/arm/decode.c             | 11 +----------
 xen/arch/arm/device.c             | 11 +----------
 xen/arch/arm/dm.c                 | 13 +------------
 xen/arch/arm/domain.c             | 12 +-----------
 xen/arch/arm/domain_build.c       |  1 +
 xen/arch/arm/domain_page.c        |  1 +
 xen/arch/arm/domctl.c             |  1 +
 xen/arch/arm/early_printk.c       |  5 +----
 xen/arch/arm/gic-v2.c             | 11 +----------
 xen/arch/arm/gic-v3-its.c         | 13 +------------
 xen/arch/arm/gic-v3-lpi.c         | 13 +------------
 xen/arch/arm/gic-v3.c             | 11 +----------
 xen/arch/arm/gic-vgic.c           | 11 +----------
 xen/arch/arm/gic.c                | 11 +----------
 xen/arch/arm/guest_atomics.c      | 13 +------------
 xen/arch/arm/guest_walk.c         | 13 +------------
 xen/arch/arm/guestcopy.c          |  1 +
 xen/arch/arm/hvm.c                | 13 +------------
 xen/arch/arm/io.c                 | 11 +----------
 xen/arch/arm/ioreq.c              | 13 +------------
 xen/arch/arm/irq.c                | 11 +----------
 xen/arch/arm/kernel.c             |  1 +
 xen/arch/arm/livepatch.c          |  1 +
 xen/arch/arm/mem_access.c         | 13 +------------
 xen/arch/arm/mm.c                 | 11 +----------
 xen/arch/arm/monitor.c            | 13 +------------
 xen/arch/arm/p2m.c                |  1 +
 xen/arch/arm/percpu.c             |  1 +
 xen/arch/arm/physdev.c            |  1 +
 xen/arch/arm/platform.c           | 11 +----------
 xen/arch/arm/platform_hypercall.c |  1 +
 xen/arch/arm/processor.c          | 11 +----------
 xen/arch/arm/psci.c               | 11 +----------
 xen/arch/arm/setup.c              | 11 +----------
 xen/arch/arm/shutdown.c           |  1 +
 xen/arch/arm/smp.c                |  1 +
 xen/arch/arm/smpboot.c            | 11 +----------
 xen/arch/arm/sysctl.c             |  1 +
 xen/arch/arm/time.c               | 11 +----------
 xen/arch/arm/traps.c              | 11 +----------
 xen/arch/arm/vcpreg.c             | 11 +----------
 xen/arch/arm/vgic-v2.c            | 11 +----------
 xen/arch/arm/vgic-v3-its.c        | 13 +------------
 xen/arch/arm/vgic-v3.c            | 11 +----------
 xen/arch/arm/vgic.c               | 11 +----------
 xen/arch/arm/vm_event.c           | 13 +------------
 xen/arch/arm/vpci.c               | 11 +----------
 xen/arch/arm/vpl011.c             | 13 +------------
 xen/arch/arm/vpsci.c              | 13 +------------
 xen/arch/arm/vsmc.c               | 10 +---------
 xen/arch/arm/vtimer.c             | 11 +----------
 xen/arch/arm/vuart.c              | 11 +----------
 56 files changed, 56 insertions(+), 438 deletions(-)

diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
index f03cd943c6..f00e3b9b3c 100644
--- a/xen/arch/arm/alternative.c
+++ b/xen/arch/arm/alternative.c
@@ -1,20 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * alternative runtime patching
  * inspired by the x86 version
  *
  * Copyright (C) 2014-2016 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/init.h>
diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 6014c0f852..0085c28d74 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Early Device Tree
  *
  * Copyright (C) 2012-2014 Citrix Systems, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 #include <xen/types.h>
 #include <xen/lib.h>
diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
index ae649d16ef..99bd4a7d38 100644
--- a/xen/arch/arm/cpuerrata.c
+++ b/xen/arch/arm/cpuerrata.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/cpu.h>
 #include <xen/cpumask.h>
 #include <xen/init.h>
diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
index 62d5e1770a..c4ec38bb25 100644
--- a/xen/arch/arm/cpufeature.c
+++ b/xen/arch/arm/cpufeature.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Contains CPU feature definitions
  *
  * Copyright (C) 2015 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/types.h>
diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index f5f6562600..2537dbebc1 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/decode.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/guest_access.h>
diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c
index 70cd6c1a19..ca8539dee5 100644
--- a/xen/arch/arm/device.c
+++ b/xen/arch/arm/device.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/device.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <asm/device.h>
diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c
index 1b3fd6bc7d..5569efa121 100644
--- a/xen/arch/arm/dm.c
+++ b/xen/arch/arm/dm.c
@@ -1,17 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (c) 2019 Arm ltd.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/dm.h>
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2d6253181a..834857ceac 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1,14 +1,4 @@
-/*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 #include <xen/bitops.h>
 #include <xen/errno.h>
 #include <xen/grant_table.h>
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 40e3c2e119..e363fb4764 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/init.h>
 #include <xen/compile.h>
 #include <xen/lib.h>
diff --git a/xen/arch/arm/domain_page.c b/xen/arch/arm/domain_page.c
index 71182575f9..b7c02c9190 100644
--- a/xen/arch/arm/domain_page.c
+++ b/xen/arch/arm/domain_page.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 #include <xen/mm.h>
 #include <xen/pmap.h>
 #include <xen/vmap.h>
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 1baf25c3d9..ad56efb0f5 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * Arch-specific domctl.c
  *
diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c
index 333073d97e..03cbe0fb88 100644
--- a/xen/arch/arm/early_printk.c
+++ b/xen/arch/arm/early_printk.c
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * printk() for use before the final page tables are setup.
  *
  * Copyright (C) 2012 Citrix Systems, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 
 #include <xen/init.h>
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index ae5bd8e95f..61802839cb 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic-v2.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/lib.h>
diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index e217c21bf8..1ec9934191 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/gic-v3-its.c
  *
  * ARM GICv3 Interrupt Translation Service (ITS) support
  *
  * Copyright (C) 2016,2017 - ARM Ltd
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; under version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/acpi.h>
diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 61d90eb386..ca7a0ab39a 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/gic-v3-lpi.c
  *
  * ARM GICv3 Locality-specific Peripheral Interrupts (LPI) support
  *
  * Copyright (C) 2016,2017 - ARM Ltd
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; under version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/cpu.h>
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 018fa0dfa0..37eb7ff95e 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic-v3.c
  *
@@ -9,16 +10,6 @@
  *
  * Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Cavium Inc
  * ported to Xen
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/acpi.h>
diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
index 98c021f1a8..56490dbc43 100644
--- a/xen/arch/arm/gic-vgic.c
+++ b/xen/arch/arm/gic-vgic.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic-vgic.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/errno.h>
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 9b82325442..d922ea67aa 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/lib.h>
diff --git a/xen/arch/arm/guest_atomics.c b/xen/arch/arm/guest_atomics.c
index 1b78a062f0..6ba77f082d 100644
--- a/xen/arch/arm/guest_atomics.c
+++ b/xen/arch/arm/guest_atomics.c
@@ -1,17 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/guest_atomics.c
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 #include <xen/cpu.h>
 
diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c
index 87de40d0cb..43d3215304 100644
--- a/xen/arch/arm/guest_walk.c
+++ b/xen/arch/arm/guest_walk.c
@@ -1,18 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Guest page table walk
  * Copyright (c) 2017 Sergej Proskurin <proskurin@sec.in.tum.de>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/domain_page.h>
diff --git a/xen/arch/arm/guestcopy.c b/xen/arch/arm/guestcopy.c
index abb6236e27..225fd343dd 100644
--- a/xen/arch/arm/guestcopy.c
+++ b/xen/arch/arm/guestcopy.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/domain_page.h>
 #include <xen/guest_access.h>
 #include <xen/lib.h>
diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c
index fc1a52767d..0989309fea 100644
--- a/xen/arch/arm/hvm.c
+++ b/xen/arch/arm/hvm.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/hvm.c
  *
  * Arch-specific hardware virtual machine abstractions.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/init.h>
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 4ce94243aa..172583df04 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/io.c
  *
  * ARM I/O handlers
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/ioreq.h>
diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 1338c86adb..5585457189 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arm/ioreq.c: hardware virtual machine I/O emulation
  *
  * Copyright (c) 2019 Arm ltd.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/domain.h>
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index fd0c15fffd..0fb924978d 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/irq.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/cpu.h>
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 2556a45c38..23b840ea9e 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Kernel image loading.
  *
diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c
index 57abc746e6..d646379c8c 100644
--- a/xen/arch/arm/livepatch.c
+++ b/xen/arch/arm/livepatch.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  *  Copyright (C) 2016 Citrix Systems R&D Ltd.
  */
diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c
index 3e3620294c..31db846354 100644
--- a/xen/arch/arm/mem_access.c
+++ b/xen/arch/arm/mem_access.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/mem_access.c
  *
  * Architecture-specific mem_access handling routines
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License v2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/mem_access.h>
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 6ccffeaea5..630175276f 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/mm.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/domain_page.h>
diff --git a/xen/arch/arm/monitor.c b/xen/arch/arm/monitor.c
index 8c4a396e3c..6c93a9e993 100644
--- a/xen/arch/arm/monitor.c
+++ b/xen/arch/arm/monitor.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/monitor.c
  *
  * Arch-specific monitor_op domctl handler.
  *
  * Copyright (c) 2016 Tamas K Lengyel (tamas.lengyel@zentific.com)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License v2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/vm_event.h>
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 8449f97fe7..4df5fff42d 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/cpu.h>
 #include <xen/domain_page.h>
 #include <xen/iocap.h>
diff --git a/xen/arch/arm/percpu.c b/xen/arch/arm/percpu.c
index 25442c48fe..f1ef844ef3 100644
--- a/xen/arch/arm/percpu.c
+++ b/xen/arch/arm/percpu.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/percpu.h>
 #include <xen/cpu.h>
 #include <xen/init.h>
diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
index 95a8cdc0ee..7b1682ee10 100644
--- a/xen/arch/arm/physdev.c
+++ b/xen/arch/arm/physdev.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * Arch-specific physdev.c
  *
diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
index 4db5bbb4c5..6701ff77bc 100644
--- a/xen/arch/arm/platform.c
+++ b/xen/arch/arm/platform.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/platform.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <asm/platform.h>
diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c
index 403cc84324..743687a303 100644
--- a/xen/arch/arm/platform_hypercall.c
+++ b/xen/arch/arm/platform_hypercall.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * platform_hypercall.c
  *
diff --git a/xen/arch/arm/processor.c b/xen/arch/arm/processor.c
index acad8b31d6..6de206c07e 100644
--- a/xen/arch/arm/processor.c
+++ b/xen/arch/arm/processor.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/processor.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2014 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #include <asm/procinfo.h>
 
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 0c90c2305c..695d2fa1f1 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/psci.c
  *
@@ -5,16 +6,6 @@
  *
  * Andre Przywara <andre.przywara@linaro.org>
  * Copyright (c) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 4395640019..1f26f67b90 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/setup.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/compile.h>
diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
index 0606cb84b3..205a5e7f8c 100644
--- a/xen/arch/arm/shutdown.c
+++ b/xen/arch/arm/shutdown.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/console.h>
 #include <xen/cpu.h>
 #include <xen/delay.h>
diff --git a/xen/arch/arm/smp.c b/xen/arch/arm/smp.c
index 5823a69d3e..bb65a08fc1 100644
--- a/xen/arch/arm/smp.c
+++ b/xen/arch/arm/smp.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/mm.h>
 #include <asm/system.h>
 #include <asm/smp.h>
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index f7bda3a18b..635977e489 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/smpboot.c
  *
  * Dummy smpboot support
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/cpu.h>
diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c
index f87944e847..b0a78a8b10 100644
--- a/xen/arch/arm/sysctl.c
+++ b/xen/arch/arm/sysctl.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * Arch-specific sysctl.c
  *
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index dec53b5f7d..92baaf8cb2 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/time.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/console.h>
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 79f9ed0725..061c92acbd 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/traps.c
  *
  * ARM Trap handlers
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/domain_page.h>
diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c
index b5fbbe1cb8..4adfc0a68d 100644
--- a/xen/arch/arm/vcpreg.c
+++ b/xen/arch/arm/vcpreg.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/arm64/vcpreg.c
  *
  * Emulate co-processor registers trapped.
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/sched.h>
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index b1bd7a46ad..0026cb4360 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vgic-v2.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/bitops.h>
diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
index 58d939b85f..299b384250 100644
--- a/xen/arch/arm/vgic-v3-its.c
+++ b/xen/arch/arm/vgic-v3-its.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/vgic-v3-its.c
  *
@@ -5,18 +6,6 @@
  *
  * Andre Przywara <andre.przywara@arm.com>
  * Copyright (c) 2016,2017 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; under version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 /*
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 7fb99a9ff2..7d2507079d 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vgic-v3.c
  *
@@ -6,16 +7,6 @@
  *
  * Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>
  * Copyright (c) 2014 Cavium Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/bitops.h>
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 83386cf3d5..c61c68870c 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vgic.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/bitops.h>
diff --git a/xen/arch/arm/vm_event.c b/xen/arch/arm/vm_event.c
index eaac92078d..ba99f56eb2 100644
--- a/xen/arch/arm/vm_event.c
+++ b/xen/arch/arm/vm_event.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/vm_event.c
  *
  * Architecture-specific vm_event handling routines
  *
  * Copyright (c) 2016 Tamas K Lengyel (tamas.lengyel@zentific.com)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License v2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/sched.h>
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index a9fc5817f9..3bc4bb5508 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -1,15 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vpci.c
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #include <xen/sched.h>
 #include <xen/vpci.h>
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
index 43522d48fd..f6144da1d7 100644
--- a/xen/arch/arm/vpl011.c
+++ b/xen/arch/arm/vpl011.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/vpl011.c
  *
  * Virtual PL011 UART
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #define XEN_WANT_FLEX_CONSOLE_RING 1
diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
index 744d43ec27..d1615be8a6 100644
--- a/xen/arch/arm/vpsci.c
+++ b/xen/arch/arm/vpsci.c
@@ -1,15 +1,4 @@
-/*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 #include <xen/errno.h>
 #include <xen/sched.h>
 #include <xen/types.h>
diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c
index 676740ef15..7335276f3f 100644
--- a/xen/arch/arm/vsmc.c
+++ b/xen/arch/arm/vsmc.c
@@ -1,17 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/vsmc.c
  *
  * Generic handler for SMC and HVC calls according to
  * ARM SMC calling convention
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index aeaea78e4c..48f2daa907 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vtimer.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/lib.h>
diff --git a/xen/arch/arm/vuart.c b/xen/arch/arm/vuart.c
index 80d4755d43..d5ba483f1e 100644
--- a/xen/arch/arm/vuart.c
+++ b/xen/arch/arm/vuart.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vuart.c
  *
@@ -19,16 +20,6 @@
  * Julien Grall <julien.grall@linaro.org>
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2012 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #include <xen/lib.h>
 #include <xen/sched.h>
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 00:16:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 00:16:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418366.663160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVY-0003rp-CQ; Sat, 08 Oct 2022 00:16:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418366.663160; Sat, 08 Oct 2022 00:16:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVY-0003rB-6f; Sat, 08 Oct 2022 00:16:00 +0000
Received: by outflank-mailman (input) for mailman id 418366;
 Sat, 08 Oct 2022 00:15:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZrwE=2J=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogxVW-0003Ov-OF
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 00:15:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5f0ac9f7-469e-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 02:15:54 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id A3D5C61E12;
 Sat,  8 Oct 2022 00:15:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AF59C433B5;
 Sat,  8 Oct 2022 00:15:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f0ac9f7-469e-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665188152;
	bh=0b+j2RsnRWPbQJ27hRNNZ7FPcRed4T5U+tS8JOtOw9g=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=SITePyn7/x5pghs6a+D8a7qv32ZbLr+HDW84tI0vYiCJFyNpDs4cOgZvZkXDamnP+
	 iVOGAaIm7PddY6Pgl4yQPXj3PqX6MgN1hYytGAcShv5/valgvHVJ8SbUn9und+qoje
	 k1w5v34l57+3/iC1UsRd2D7XOMvnauUkr2o9pQHPSUwkxK5Bwt9gX/ycqV6rsyfJkf
	 cwJ6U1ZLZ4bLkWWTJ0mp+ZtGqLCDwuYbVTytGb8MKY9z5xc3SzGPqwrNtRHRCQmFBo
	 CVfLKFT96QmjoNAyan1k5c0FHXazx8ywu3jwMJD/ESMdwfqMVhgCh4zlV4yx6SQHvI
	 PWx3aDMjCfRWw==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v3 2/4] Add licenses under LICENSES
Date: Fri,  7 Oct 2022 17:15:42 -0700
Message-Id: <20221008001544.78302-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Add the individual licenses under a new top-level directory named
"LICENSES". Each license file includes its related SPDX tags.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 LICENSES/BSD-2-Clause       |  32 +++
 LICENSES/BSD-3-Clause       |  36 +++
 LICENSES/BSD-3-Clause-Clear |  41 +++
 LICENSES/GPL-2.0            | 359 +++++++++++++++++++++++++
 LICENSES/LGPL-2.0           | 487 ++++++++++++++++++++++++++++++++++
 LICENSES/LGPL-2.1           | 503 ++++++++++++++++++++++++++++++++++++
 LICENSES/MIT                |  30 +++
 7 files changed, 1488 insertions(+)
 create mode 100644 LICENSES/BSD-2-Clause
 create mode 100644 LICENSES/BSD-3-Clause
 create mode 100644 LICENSES/BSD-3-Clause-Clear
 create mode 100644 LICENSES/GPL-2.0
 create mode 100644 LICENSES/LGPL-2.0
 create mode 100644 LICENSES/LGPL-2.1
 create mode 100644 LICENSES/MIT

diff --git a/LICENSES/BSD-2-Clause b/LICENSES/BSD-2-Clause
new file mode 100644
index 0000000000..da366e2ce5
--- /dev/null
+++ b/LICENSES/BSD-2-Clause
@@ -0,0 +1,32 @@
+Valid-License-Identifier: BSD-2-Clause
+SPDX-URL: https://spdx.org/licenses/BSD-2-Clause.html
+Usage-Guide:
+  To use the BSD 2-clause "Simplified" License put the following SPDX
+  tag/value pair into a comment according to the placement guidelines in
+  the licensing rules documentation:
+    SPDX-License-Identifier: BSD-2-Clause
+License-Text:
+
+Copyright (c) <year> <owner> . All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
diff --git a/LICENSES/BSD-3-Clause b/LICENSES/BSD-3-Clause
new file mode 100644
index 0000000000..34c7f057c8
--- /dev/null
+++ b/LICENSES/BSD-3-Clause
@@ -0,0 +1,36 @@
+Valid-License-Identifier: BSD-3-Clause
+SPDX-URL: https://spdx.org/licenses/BSD-3-Clause.html
+Usage-Guide:
+  To use the BSD 3-clause "New" or "Revised" License put the following SPDX
+  tag/value pair into a comment according to the placement guidelines in
+  the licensing rules documentation:
+    SPDX-License-Identifier: BSD-3-Clause
+License-Text:
+
+Copyright (c) <year> <owner> . All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holder nor the names of its
+   contributors may be used to endorse or promote products derived from this
+   software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
diff --git a/LICENSES/BSD-3-Clause-Clear b/LICENSES/BSD-3-Clause-Clear
new file mode 100644
index 0000000000..e53b56092b
--- /dev/null
+++ b/LICENSES/BSD-3-Clause-Clear
@@ -0,0 +1,41 @@
+Valid-License-Identifier: BSD-3-Clause-Clear
+SPDX-URL: https://spdx.org/licenses/BSD-3-Clause-Clear.html
+Usage-Guide:
+  To use the BSD 3-clause "Clear" License put the following SPDX
+  tag/value pair into a comment according to the placement guidelines in
+  the licensing rules documentation:
+    SPDX-License-Identifier: BSD-3-Clause-Clear
+License-Text:
+
+The Clear BSD License
+
+Copyright (c) [xxxx]-[xxxx] [Owner Organization]
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted (subject to the limitations in the disclaimer
+below) provided that the following conditions are met:
+
+ * Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+
+ * Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+ * Neither the name of [Owner Organization] nor the names of its
+   contributors may be used to endorse or promote products derived from
+   this software without specific prior written permission.
+
+NO EXPRESS OR IMPLIED LICENSES TO ANY PARTY'S PATENT RIGHTS ARE GRANTED BY
+THIS LICENSE. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
+CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
+NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER
+OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
+OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
+OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
+ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0
new file mode 100644
index 0000000000..ff0812fd89
--- /dev/null
+++ b/LICENSES/GPL-2.0
@@ -0,0 +1,359 @@
+Valid-License-Identifier: GPL-2.0
+Valid-License-Identifier: GPL-2.0-only
+Valid-License-Identifier: GPL-2.0+
+Valid-License-Identifier: GPL-2.0-or-later
+SPDX-URL: https://spdx.org/licenses/GPL-2.0.html
+Usage-Guide:
+  To use this license in source code, put one of the following SPDX
+  tag/value pairs into a comment according to the placement
+  guidelines in the licensing rules documentation.
+  For 'GNU General Public License (GPL) version 2 only' use:
+    SPDX-License-Identifier: GPL-2.0
+  or
+    SPDX-License-Identifier: GPL-2.0-only
+  For 'GNU General Public License (GPL) version 2 or any later version' use:
+    SPDX-License-Identifier: GPL-2.0+
+  or
+    SPDX-License-Identifier: GPL-2.0-or-later
+License-Text:
+
+		    GNU GENERAL PUBLIC LICENSE
+		       Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.
+                       51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+			    Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Library General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+		    GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an appropriate
+copyright notice and disclaimer of warranty; keep intact all the
+notices that refer to this License and to the absence of any warranty;
+and give any other recipients of the Program a copy of this License
+along with the Program.
+
+You may charge a fee for the physical act of transferring a copy, and
+you may at your option offer warranty protection in exchange for a fee.
+
+  2. You may modify your copy or copies of the Program or any portion
+of it, thus forming a work based on the Program, and copy and
+distribute such modifications or work under the terms of Section 1
+above, provided that you also meet all of these conditions:
+
+    a) You must cause the modified files to carry prominent notices
+    stating that you changed the files and the date of any change.
+
+    b) You must cause any work that you distribute or publish, that in
+    whole or in part contains or is derived from the Program or any
+    part thereof, to be licensed as a whole at no charge to all third
+    parties under the terms of this License.
+
+    c) If the modified program normally reads commands interactively
+    when run, you must cause it, when started running for such
+    interactive use in the most ordinary way, to print or display an
+    announcement including an appropriate copyright notice and a
+    notice that there is no warranty (or else, saying that you provide
+    a warranty) and that users may redistribute the program under
+    these conditions, and telling the user how to view a copy of this
+    License.  (Exception: if the Program itself is interactive but
+    does not normally print such an announcement, your work based on
+    the Program is not required to print an announcement.)
+
+These requirements apply to the modified work as a whole.  If
+identifiable sections of that work are not derived from the Program,
+and can be reasonably considered independent and separate works in
+themselves, then this License, and its terms, do not apply to those
+sections when you distribute them as separate works.  But when you
+distribute the same sections as part of a whole which is a work based
+on the Program, the distribution of the whole must be on the terms of
+this License, whose permissions for other licensees extend to the
+entire whole, and thus to each and every part regardless of who wrote it.
+
+Thus, it is not the intent of this section to claim rights or contest
+your rights to work written entirely by you; rather, the intent is to
+exercise the right to control the distribution of derivative or
+collective works based on the Program.
+
+In addition, mere aggregation of another work not based on the Program
+with the Program (or with a work based on the Program) on a volume of
+a storage or distribution medium does not bring the other work under
+the scope of this License.
+
+  3. You may copy and distribute the Program (or a work based on it,
+under Section 2) in object code or executable form under the terms of
+Sections 1 and 2 above provided that you also do one of the following:
+
+    a) Accompany it with the complete corresponding machine-readable
+    source code, which must be distributed under the terms of Sections
+    1 and 2 above on a medium customarily used for software interchange; or,
+
+    b) Accompany it with a written offer, valid for at least three
+    years, to give any third party, for a charge no more than your
+    cost of physically performing source distribution, a complete
+    machine-readable copy of the corresponding source code, to be
+    distributed under the terms of Sections 1 and 2 above on a medium
+    customarily used for software interchange; or,
+
+    c) Accompany it with the information you received as to the offer
+    to distribute corresponding source code.  (This alternative is
+    allowed only for noncommercial distribution and only if you
+    received the program in object code or executable form with such
+    an offer, in accord with Subsection b above.)
+
+The source code for a work means the preferred form of the work for
+making modifications to it.  For an executable work, complete source
+code means all the source code for all modules it contains, plus any
+associated interface definition files, plus the scripts used to
+control compilation and installation of the executable.  However, as a
+special exception, the source code distributed need not include
+anything that is normally distributed (in either source or binary
+form) with the major components (compiler, kernel, and so on) of the
+operating system on which the executable runs, unless that component
+itself accompanies the executable.
+
+If distribution of executable or object code is made by offering
+access to copy from a designated place, then offering equivalent
+access to copy the source code from the same place counts as
+distribution of the source code, even though third parties are not
+compelled to copy the source along with the object code.
+
+  4. You may not copy, modify, sublicense, or distribute the Program
+except as expressly provided under this License.  Any attempt
+otherwise to copy, modify, sublicense or distribute the Program is
+void, and will automatically terminate your rights under this License.
+However, parties who have received copies, or rights, from you under
+this License will not have their licenses terminated so long as such
+parties remain in full compliance.
+
+  5. You are not required to accept this License, since you have not
+signed it.  However, nothing else grants you permission to modify or
+distribute the Program or its derivative works.  These actions are
+prohibited by law if you do not accept this License.  Therefore, by
+modifying or distributing the Program (or any work based on the
+Program), you indicate your acceptance of this License to do so, and
+all its terms and conditions for copying, distributing or modifying
+the Program or works based on it.
+
+  6. Each time you redistribute the Program (or any work based on the
+Program), the recipient automatically receives a license from the
+original licensor to copy, distribute or modify the Program subject to
+these terms and conditions.  You may not impose any further
+restrictions on the recipients' exercise of the rights granted herein.
+You are not responsible for enforcing compliance by third parties to
+this License.
+
+  7. If, as a consequence of a court judgment or allegation of patent
+infringement or for any other reason (not limited to patent issues),
+conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License.  If you cannot
+distribute so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you
+may not distribute the Program at all.  For example, if a patent
+license would not permit royalty-free redistribution of the Program by
+all those who receive copies directly or indirectly through you, then
+the only way you could satisfy both it and this License would be to
+refrain entirely from distribution of the Program.
+
+If any portion of this section is held invalid or unenforceable under
+any particular circumstance, the balance of the section is intended to
+apply and the section as a whole is intended to apply in other
+circumstances.
+
+It is not the purpose of this section to induce you to infringe any
+patents or other property right claims or to contest validity of any
+such claims; this section has the sole purpose of protecting the
+integrity of the free software distribution system, which is
+implemented by public license practices.  Many people have made
+generous contributions to the wide range of software distributed
+through that system in reliance on consistent application of that
+system; it is up to the author/donor to decide if he or she is willing
+to distribute software through any other system and a licensee cannot
+impose that choice.
+
+This section is intended to make thoroughly clear what is believed to
+be a consequence of the rest of this License.
+
+  8. If the distribution and/or use of the Program is restricted in
+certain countries either by patents or by copyrighted interfaces, the
+original copyright holder who places the Program under this License
+may add an explicit geographical distribution limitation excluding
+those countries, so that distribution is permitted only in or among
+countries not thus excluded.  In such case, this License incorporates
+the limitation as if written in the body of this License.
+
+  9. The Free Software Foundation may publish revised and/or new versions
+of the General Public License from time to time.  Such new versions will
+be similar in spirit to the present version, but may differ in detail to
+address new problems or concerns.
+
+Each version is given a distinguishing version number.  If the Program
+specifies a version number of this License which applies to it and "any
+later version", you have the option of following the terms and conditions
+either of that version or of any later version published by the Free
+Software Foundation.  If the Program does not specify a version number of
+this License, you may choose any version ever published by the Free Software
+Foundation.
+
+  10. If you wish to incorporate parts of the Program into other free
+programs whose distribution conditions are different, write to the author
+to ask for permission.  For software which is copyrighted by the Free
+Software Foundation, write to the Free Software Foundation; we sometimes
+make exceptions for this.  Our decision will be guided by the two goals
+of preserving the free status of all derivatives of our free software and
+of promoting the sharing and reuse of software generally.
+
+			    NO WARRANTY
+
+  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
+OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
+OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
+TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
+PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
+REPAIR OR CORRECTION.
+
+  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
+INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
+OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
+TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
+YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
+PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGES.
+
+		     END OF TERMS AND CONDITIONS
+
+	    How to Apply These Terms to Your New Programs
+
+  If you develop a new program, and you want it to be of the greatest
+possible use to the public, the best way to achieve this is to make it
+free software which everyone can redistribute and change under these terms.
+
+  To do so, attach the following notices to the program.  It is safest
+to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least
+the "copyright" line and a pointer to where the full notice is found.
+
+    <one line to give the program's name and a brief idea of what it does.>
+    Copyright (C) <year>  <name of author>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+
+
+Also add information on how to contact you by electronic and paper mail.
+
+If the program is interactive, make it output a short notice like this
+when it starts in an interactive mode:
+
+    Gnomovision version 69, Copyright (C) year name of author
+    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
+    This is free software, and you are welcome to redistribute it
+    under certain conditions; type `show c' for details.
+
+The hypothetical commands `show w' and `show c' should show the appropriate
+parts of the General Public License.  Of course, the commands you use may
+be called something other than `show w' and `show c'; they could even be
+mouse-clicks or menu items--whatever suits your program.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the program, if
+necessary.  Here is a sample; alter the names:
+
+  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
+  `Gnomovision' (which makes passes at compilers) written by James Hacker.
+
+  <signature of Ty Coon>, 1 April 1989
+  Ty Coon, President of Vice
+
+This General Public License does not permit incorporating your program into
+proprietary programs.  If your program is a subroutine library, you may
+consider it more useful to permit linking proprietary applications with the
+library.  If this is what you want to do, use the GNU Library General
+Public License instead of this License.
diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0
new file mode 100644
index 0000000000..957d798fe0
--- /dev/null
+++ b/LICENSES/LGPL-2.0
@@ -0,0 +1,487 @@
+Valid-License-Identifier: LGPL-2.0
+Valid-License-Identifier: LGPL-2.0+
+SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html
+Usage-Guide:
+  To use this license in source code, put one of the following SPDX
+  tag/value pairs into a comment according to the placement
+  guidelines in the licensing rules documentation.
+  For 'GNU Library General Public License (LGPL) version 2.0 only' use:
+    SPDX-License-Identifier: LGPL-2.0
+  For 'GNU Library General Public License (LGPL) version 2.0 or any later
+  version' use:
+    SPDX-License-Identifier: LGPL-2.0+
+License-Text:
+
+GNU LIBRARY GENERAL PUBLIC LICENSE
+Version 2, June 1991
+
+Copyright (C) 1991 Free Software Foundation, Inc.
+51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+[This is the first released version of the library GPL. It is numbered 2
+because it goes with version 2 of the ordinary GPL.]
+
+Preamble
+
+The licenses for most software are designed to take away your freedom to
+share and change it. By contrast, the GNU General Public Licenses are
+intended to guarantee your freedom to share and change free software--to
+make sure the software is free for all its users.
+
+This license, the Library General Public License, applies to some specially
+designated Free Software Foundation software, and to any other libraries
+whose authors decide to use it. You can use it for your libraries, too.
+
+When we speak of free software, we are referring to freedom, not price. Our
+General Public Licenses are designed to make sure that you have the freedom
+to distribute copies of free software (and charge for this service if you
+wish), that you receive source code or can get it if you want it, that you
+can change the software or use pieces of it in new free programs; and that
+you know you can do these things.
+
+To protect your rights, we need to make restrictions that forbid anyone to
+deny you these rights or to ask you to surrender the rights. These
+restrictions translate to certain responsibilities for you if you
+distribute copies of the library, or if you modify it.
+
+For example, if you distribute copies of the library, whether gratis or for
+a fee, you must give the recipients all the rights that we gave you. You
+must make sure that they, too, receive or can get the source code. If you
+link a program with the library, you must provide complete object files to
+the recipients so that they can relink them with the library, after making
+changes to the library and recompiling it. And you must show them these
+terms so they know their rights.
+
+Our method of protecting your rights has two steps: (1) copyright the
+library, and (2) offer you this license which gives you legal permission to
+copy, distribute and/or modify the library.
+
+Also, for each distributor's protection, we want to make certain that
+everyone understands that there is no warranty for this free library. If
+the library is modified by someone else and passed on, we want its
+recipients to know that what they have is not the original version, so that
+any problems introduced by others will not reflect on the original authors'
+reputations.
+
+Finally, any free program is threatened constantly by software patents. We
+wish to avoid the danger that companies distributing free software will
+individually obtain patent licenses, thus in effect transforming the
+program into proprietary software. To prevent this, we have made it clear
+that any patent must be licensed for everyone's free use or not licensed at
+all.
+
+Most GNU software, including some libraries, is covered by the ordinary GNU
+General Public License, which was designed for utility programs. This
+license, the GNU Library General Public License, applies to certain
+designated libraries. This license is quite different from the ordinary
+one; be sure to read it in full, and don't assume that anything in it is
+the same as in the ordinary license.
+
+The reason we have a separate public license for some libraries is that
+they blur the distinction we usually make between modifying or adding to a
+program and simply using it. Linking a program with a library, without
+changing the library, is in some sense simply using the library, and is
+analogous to running a utility program or application program. However, in
+a textual and legal sense, the linked executable is a combined work, a
+derivative of the original library, and the ordinary General Public License
+treats it as such.
+
+Because of this blurred distinction, using the ordinary General Public
+License for libraries did not effectively promote software sharing, because
+most developers did not use the libraries. We concluded that weaker
+conditions might promote sharing better.
+
+However, unrestricted linking of non-free programs would deprive the users
+of those programs of all benefit from the free status of the libraries
+themselves. This Library General Public License is intended to permit
+developers of non-free programs to use free libraries, while preserving
+your freedom as a user of such programs to change the free libraries that
+are incorporated in them. (We have not seen how to achieve this as regards
+changes in header files, but we have achieved it as regards changes in the
+actual functions of the Library.) The hope is that this will lead to faster
+development of free libraries.
+
+The precise terms and conditions for copying, distribution and modification
+follow. Pay close attention to the difference between a "work based on the
+library" and a "work that uses the library". The former contains code
+derived from the library, while the latter only works together with the
+library.
+
+Note that it is possible for a library to be covered by the ordinary
+General Public License rather than by this special one.
+
+TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+0. This License Agreement applies to any software library which contains a
+   notice placed by the copyright holder or other authorized party saying
+   it may be distributed under the terms of this Library General Public
+   License (also called "this License"). Each licensee is addressed as
+   "you".
+
+   A "library" means a collection of software functions and/or data
+   prepared so as to be conveniently linked with application programs
+   (which use some of those functions and data) to form executables.
+
+   The "Library", below, refers to any such software library or work which
+   has been distributed under these terms. A "work based on the Library"
+   means either the Library or any derivative work under copyright law:
+   that is to say, a work containing the Library or a portion of it, either
+   verbatim or with modifications and/or translated straightforwardly into
+   another language. (Hereinafter, translation is included without
+   limitation in the term "modification".)
+
+   "Source code" for a work means the preferred form of the work for making
+   modifications to it. For a library, complete source code means all the
+   source code for all modules it contains, plus any associated interface
+   definition files, plus the scripts used to control compilation and
+   installation of the library.
+
+   Activities other than copying, distribution and modification are not
+   covered by this License; they are outside its scope. The act of running
+   a program using the Library is not restricted, and output from such a
+   program is covered only if its contents constitute a work based on the
+   Library (independent of the use of the Library in a tool for writing
+   it). Whether that is true depends on what the Library does and what the
+   program that uses the Library does.
+
+1. You may copy and distribute verbatim copies of the Library's complete
+   source code as you receive it, in any medium, provided that you
+   conspicuously and appropriately publish on each copy an appropriate
+   copyright notice and disclaimer of warranty; keep intact all the notices
+   that refer to this License and to the absence of any warranty; and
+   distribute a copy of this License along with the Library.
+
+   You may charge a fee for the physical act of transferring a copy, and
+   you may at your option offer warranty protection in exchange for a fee.
+
+2. You may modify your copy or copies of the Library or any portion of it,
+   thus forming a work based on the Library, and copy and distribute such
+   modifications or work under the terms of Section 1 above, provided that
+   you also meet all of these conditions:
+
+   a) The modified work must itself be a software library.
+
+   b) You must cause the files modified to carry prominent notices stating
+      that you changed the files and the date of any change.
+
+   c) You must cause the whole of the work to be licensed at no charge to
+      all third parties under the terms of this License.
+
+   d) If a facility in the modified Library refers to a function or a table
+      of data to be supplied by an application program that uses the
+      facility, other than as an argument passed when the facility is
+      invoked, then you must make a good faith effort to ensure that, in
+      the event an application does not supply such function or table, the
+      facility still operates, and performs whatever part of its purpose
+      remains meaningful.
+
+   (For example, a function in a library to compute square roots has a
+   purpose that is entirely well-defined independent of the
+   application. Therefore, Subsection 2d requires that any
+   application-supplied function or table used by this function must be
+   optional: if the application does not supply it, the square root
+   function must still compute square roots.)
+
+   These requirements apply to the modified work as a whole. If
+   identifiable sections of that work are not derived from the Library, and
+   can be reasonably considered independent and separate works in
+   themselves, then this License, and its terms, do not apply to those
+   sections when you distribute them as separate works. But when you
+   distribute the same sections as part of a whole which is a work based on
+   the Library, the distribution of the whole must be on the terms of this
+   License, whose permissions for other licensees extend to the entire
+   whole, and thus to each and every part regardless of who wrote it.
+
+   Thus, it is not the intent of this section to claim rights or contest
+   your rights to work written entirely by you; rather, the intent is to
+   exercise the right to control the distribution of derivative or
+   collective works based on the Library.
+
+   In addition, mere aggregation of another work not based on the Library
+   with the Library (or with a work based on the Library) on a volume of a
+   storage or distribution medium does not bring the other work under the
+   scope of this License.
+
+3. You may opt to apply the terms of the ordinary GNU General Public
+   License instead of this License to a given copy of the Library. To do
+   this, you must alter all the notices that refer to this License, so that
+   they refer to the ordinary GNU General Public License, version 2,
+   instead of to this License. (If a newer version than version 2 of the
+   ordinary GNU General Public License has appeared, then you can specify
+   that version instead if you wish.) Do not make any other change in these
+   notices.
+
+   Once this change is made in a given copy, it is irreversible for that
+   copy, so the ordinary GNU General Public License applies to all
+   subsequent copies and derivative works made from that copy.
+
+   This option is useful when you wish to copy part of the code of the
+   Library into a program that is not a library.
+
+4. You may copy and distribute the Library (or a portion or derivative of
+   it, under Section 2) in object code or executable form under the terms
+   of Sections 1 and 2 above provided that you accompany it with the
+   complete corresponding machine-readable source code, which must be
+   distributed under the terms of Sections 1 and 2 above on a medium
+   customarily used for software interchange.
+
+   If distribution of object code is made by offering access to copy from a
+   designated place, then offering equivalent access to copy the source
+   code from the same place satisfies the requirement to distribute the
+   source code, even though third parties are not compelled to copy the
+   source along with the object code.
+
+5. A program that contains no derivative of any portion of the Library, but
+   is designed to work with the Library by being compiled or linked with
+   it, is called a "work that uses the Library". Such a work, in isolation,
+   is not a derivative work of the Library, and therefore falls outside the
+   scope of this License.
+
+   However, linking a "work that uses the Library" with the Library creates
+   an executable that is a derivative of the Library (because it contains
+   portions of the Library), rather than a "work that uses the
+   library". The executable is therefore covered by this License. Section 6
+   states terms for distribution of such executables.
+
+   When a "work that uses the Library" uses material from a header file
+   that is part of the Library, the object code for the work may be a
+   derivative work of the Library even though the source code is
+   not. Whether this is true is especially significant if the work can be
+   linked without the Library, or if the work is itself a library. The
+   threshold for this to be true is not precisely defined by law.
+
+   If such an object file uses only numerical parameters, data structure
+   layouts and accessors, and small macros and small inline functions (ten
+   lines or less in length), then the use of the object file is
+   unrestricted, regardless of whether it is legally a derivative
+   work. (Executables containing this object code plus portions of the
+   Library will still fall under Section 6.)
+
+   Otherwise, if the work is a derivative of the Library, you may
+   distribute the object code for the work under the terms of Section
+   6. Any executables containing that work also fall under Section 6,
+   whether or not they are linked directly with the Library itself.
+
+6. As an exception to the Sections above, you may also compile or link a
+   "work that uses the Library" with the Library to produce a work
+   containing portions of the Library, and distribute that work under terms
+   of your choice, provided that the terms permit modification of the work
+   for the customer's own use and reverse engineering for debugging such
+   modifications.
+
+   You must give prominent notice with each copy of the work that the
+   Library is used in it and that the Library and its use are covered by
+   this License. You must supply a copy of this License. If the work during
+   execution displays copyright notices, you must include the copyright
+   notice for the Library among them, as well as a reference directing the
+   user to the copy of this License. Also, you must do one of these things:
+
+   a) Accompany the work with the complete corresponding machine-readable
+      source code for the Library including whatever changes were used in
+      the work (which must be distributed under Sections 1 and 2 above);
+      and, if the work is an executable linked with the Library, with the
+      complete machine-readable "work that uses the Library", as object
+      code and/or source code, so that the user can modify the Library and
+      then relink to produce a modified executable containing the modified
+      Library. (It is understood that the user who changes the contents of
+      definitions files in the Library will not necessarily be able to
+      recompile the application to use the modified definitions.)
+
+   b) Accompany the work with a written offer, valid for at least three
+      years, to give the same user the materials specified in Subsection
+      6a, above, for a charge no more than the cost of performing this
+      distribution.
+
+   c) If distribution of the work is made by offering access to copy from a
+      designated place, offer equivalent access to copy the above specified
+      materials from the same place.
+
+   d) Verify that the user has already received a copy of these materials
+      or that you have already sent this user a copy.
+
+   For an executable, the required form of the "work that uses the Library"
+   must include any data and utility programs needed for reproducing the
+   executable from it. However, as a special exception, the source code
+   distributed need not include anything that is normally distributed (in
+   either source or binary form) with the major components (compiler,
+   kernel, and so on) of the operating system on which the executable runs,
+   unless that component itself accompanies the executable.
+
+   It may happen that this requirement contradicts the license restrictions
+   of other proprietary libraries that do not normally accompany the
+   operating system. Such a contradiction means you cannot use both them
+   and the Library together in an executable that you distribute.
+
+7. You may place library facilities that are a work based on the Library
+   side-by-side in a single library together with other library facilities
+   not covered by this License, and distribute such a combined library,
+   provided that the separate distribution of the work based on the Library
+   and of the other library facilities is otherwise permitted, and provided
+   that you do these two things:
+
+   a) Accompany the combined library with a copy of the same work based on
+      the Library, uncombined with any other library facilities. This must
+      be distributed under the terms of the Sections above.
+
+   b) Give prominent notice with the combined library of the fact that part
+      of it is a work based on the Library, and explaining where to find
+      the accompanying uncombined form of the same work.
+
+8. You may not copy, modify, sublicense, link with, or distribute the
+   Library except as expressly provided under this License. Any attempt
+   otherwise to copy, modify, sublicense, link with, or distribute the
+   Library is void, and will automatically terminate your rights under this
+   License. However, parties who have received copies, or rights, from you
+   under this License will not have their licenses terminated so long as
+   such parties remain in full compliance.
+
+9. You are not required to accept this License, since you have not signed
+   it. However, nothing else grants you permission to modify or distribute
+   the Library or its derivative works. These actions are prohibited by law
+   if you do not accept this License. Therefore, by modifying or
+   distributing the Library (or any work based on the Library), you
+   indicate your acceptance of this License to do so, and all its terms and
+   conditions for copying, distributing or modifying the Library or works
+   based on it.
+
+10. Each time you redistribute the Library (or any work based on the
+    Library), the recipient automatically receives a license from the
+    original licensor to copy, distribute, link with or modify the Library
+    subject to these terms and conditions. You may not impose any further
+    restrictions on the recipients' exercise of the rights granted
+    herein. You are not responsible for enforcing compliance by third
+    parties to this License.
+
+11. If, as a consequence of a court judgment or allegation of patent
+    infringement or for any other reason (not limited to patent issues),
+    conditions are imposed on you (whether by court order, agreement or
+    otherwise) that contradict the conditions of this License, they do not
+    excuse you from the conditions of this License. If you cannot
+    distribute so as to satisfy simultaneously your obligations under this
+    License and any other pertinent obligations, then as a consequence you
+    may not distribute the Library at all. For example, if a patent license
+    would not permit royalty-free redistribution of the Library by all
+    those who receive copies directly or indirectly through you, then the
+    only way you could satisfy both it and this License would be to refrain
+    entirely from distribution of the Library.
+
+    If any portion of this section is held invalid or unenforceable under
+    any particular circumstance, the balance of the section is intended to
+    apply, and the section as a whole is intended to apply in other
+    circumstances.
+
+    It is not the purpose of this section to induce you to infringe any
+    patents or other property right claims or to contest validity of any
+    such claims; this section has the sole purpose of protecting the
+    integrity of the free software distribution system which is implemented
+    by public license practices. Many people have made generous
+    contributions to the wide range of software distributed through that
+    system in reliance on consistent application of that system; it is up
+    to the author/donor to decide if he or she is willing to distribute
+    software through any other system and a licensee cannot impose that
+    choice.
+
+    This section is intended to make thoroughly clear what is believed to
+    be a consequence of the rest of this License.
+
+12. If the distribution and/or use of the Library is restricted in certain
+    countries either by patents or by copyrighted interfaces, the original
+    copyright holder who places the Library under this License may add an
+    explicit geographical distribution limitation excluding those
+    countries, so that distribution is permitted only in or among countries
+    not thus excluded. In such case, this License incorporates the
+    limitation as if written in the body of this License.
+
+13. The Free Software Foundation may publish revised and/or new versions of
+    the Library General Public License from time to time. Such new versions
+    will be similar in spirit to the present version, but may differ in
+    detail to address new problems or concerns.
+
+    Each version is given a distinguishing version number. If the Library
+    specifies a version number of this License which applies to it and "any
+    later version", you have the option of following the terms and
+    conditions either of that version or of any later version published by
+    the Free Software Foundation. If the Library does not specify a license
+    version number, you may choose any version ever published by the Free
+    Software Foundation.
+
+14. If you wish to incorporate parts of the Library into other free
+    programs whose distribution conditions are incompatible with these,
+    write to the author to ask for permission. For software which is
+    copyrighted by the Free Software Foundation, write to the Free Software
+    Foundation; we sometimes make exceptions for this. Our decision will be
+    guided by the two goals of preserving the free status of all
+    derivatives of our free software and of promoting the sharing and reuse
+    of software generally.
+
+NO WARRANTY
+
+15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+    FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN
+    OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+    PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER
+    EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE
+    ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE LIBRARY IS WITH
+    YOU. SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL
+    NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+    WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+    REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU FOR
+    DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL
+    DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE LIBRARY
+    (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED
+    INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF
+    THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF SUCH HOLDER OR
+    OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.
+
+END OF TERMS AND CONDITIONS
+
+How to Apply These Terms to Your New Libraries
+
+If you develop a new library, and you want it to be of the greatest
+possible use to the public, we recommend making it free software that
+everyone can redistribute and change. You can do so by permitting
+redistribution under these terms (or, alternatively, under the terms of the
+ordinary General Public License).
+
+To apply these terms, attach the following notices to the library. It is
+safest to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least the
+"copyright" line and a pointer to where the full notice is found.
+
+one line to give the library's name and an idea of what it does.
+Copyright (C) year name of author
+
+This library is free software; you can redistribute it and/or modify it
+under the terms of the GNU Library General Public License as published by
+the Free Software Foundation; either version 2 of the License, or (at your
+option) any later version.
+
+This library is distributed in the hope that it will be useful, but WITHOUT
+ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public
+License for more details.
+
+You should have received a copy of the GNU Library General Public License
+along with this library; if not, write to the Free Software Foundation,
+Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+
+Also add information on how to contact you by electronic and paper mail.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the library, if
+necessary. Here is a sample; alter the names:
+
+Yoyodyne, Inc., hereby disclaims all copyright interest in
+the library `Frob' (a library for tweaking knobs) written
+by James Random Hacker.
+
+signature of Ty Coon, 1 April 1990
+Ty Coon, President of Vice
+
+That's all there is to it!
diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1
new file mode 100644
index 0000000000..27bb4342a3
--- /dev/null
+++ b/LICENSES/LGPL-2.1
@@ -0,0 +1,503 @@
+Valid-License-Identifier: LGPL-2.1
+Valid-License-Identifier: LGPL-2.1+
+SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html
+Usage-Guide:
+  To use this license in source code, put one of the following SPDX
+  tag/value pairs into a comment according to the placement
+  guidelines in the licensing rules documentation.
+  For 'GNU Lesser General Public License (LGPL) version 2.1 only' use:
+    SPDX-License-Identifier: LGPL-2.1
+  For 'GNU Lesser General Public License (LGPL) version 2.1 or any later
+  version' use:
+    SPDX-License-Identifier: LGPL-2.1+
+License-Text:
+
+GNU LESSER GENERAL PUBLIC LICENSE
+Version 2.1, February 1999
+
+Copyright (C) 1991, 1999 Free Software Foundation, Inc.
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+[This is the first released version of the Lesser GPL. It also counts as
+the successor of the GNU Library Public License, version 2, hence the
+version number 2.1.]
+
+Preamble
+
+The licenses for most software are designed to take away your freedom to
+share and change it. By contrast, the GNU General Public Licenses are
+intended to guarantee your freedom to share and change free software--to
+make sure the software is free for all its users.
+
+This license, the Lesser General Public License, applies to some specially
+designated software packages--typically libraries--of the Free Software
+Foundation and other authors who decide to use it. You can use it too, but
+we suggest you first think carefully about whether this license or the
+ordinary General Public License is the better strategy to use in any
+particular case, based on the explanations below.
+
+When we speak of free software, we are referring to freedom of use, not
+price. Our General Public Licenses are designed to make sure that you have
+the freedom to distribute copies of free software (and charge for this
+service if you wish); that you receive source code or can get it if you
+want it; that you can change the software and use pieces of it in new free
+programs; and that you are informed that you can do these things.
+
+To protect your rights, we need to make restrictions that forbid
+distributors to deny you these rights or to ask you to surrender these
+rights. These restrictions translate to certain responsibilities for you if
+you distribute copies of the library or if you modify it.
+
+For example, if you distribute copies of the library, whether gratis or for
+a fee, you must give the recipients all the rights that we gave you. You
+must make sure that they, too, receive or can get the source code. If you
+link other code with the library, you must provide complete object files to
+the recipients, so that they can relink them with the library after making
+changes to the library and recompiling it. And you must show them these
+terms so they know their rights.
+
+We protect your rights with a two-step method: (1) we copyright the
+library, and (2) we offer you this license, which gives you legal
+permission to copy, distribute and/or modify the library.
+
+To protect each distributor, we want to make it very clear that there is no
+warranty for the free library. Also, if the library is modified by someone
+else and passed on, the recipients should know that what they have is not
+the original version, so that the original author's reputation will not be
+affected by problems that might be introduced by others.
+
+Finally, software patents pose a constant threat to the existence of any
+free program. We wish to make sure that a company cannot effectively
+restrict the users of a free program by obtaining a restrictive license
+from a patent holder. Therefore, we insist that any patent license obtained
+for a version of the library must be consistent with the full freedom of
+use specified in this license.
+
+Most GNU software, including some libraries, is covered by the ordinary GNU
+General Public License. This license, the GNU Lesser General Public
+License, applies to certain designated libraries, and is quite different
+from the ordinary General Public License. We use this license for certain
+libraries in order to permit linking those libraries into non-free
+programs.
+
+When a program is linked with a library, whether statically or using a
+shared library, the combination of the two is legally speaking a combined
+work, a derivative of the original library. The ordinary General Public
+License therefore permits such linking only if the entire combination fits
+its criteria of freedom. The Lesser General Public License permits more lax
+criteria for linking other code with the library.
+
+We call this license the "Lesser" General Public License because it does
+Less to protect the user's freedom than the ordinary General Public
+License. It also provides other free software developers Less of an
+advantage over competing non-free programs. These disadvantages are the
+reason we use the ordinary General Public License for many
+libraries. However, the Lesser license provides advantages in certain
+special circumstances.
+
+For example, on rare occasions, there may be a special need to encourage
+the widest possible use of a certain library, so that it becomes a de-facto
+standard. To achieve this, non-free programs must be allowed to use the
+library. A more frequent case is that a free library does the same job as
+widely used non-free libraries. In this case, there is little to gain by
+limiting the free library to free software only, so we use the Lesser
+General Public License.
+
+In other cases, permission to use a particular library in non-free programs
+enables a greater number of people to use a large body of free
+software. For example, permission to use the GNU C Library in non-free
+programs enables many more people to use the whole GNU operating system, as
+well as its variant, the GNU/Linux operating system.
+
+Although the Lesser General Public License is Less protective of the users'
+freedom, it does ensure that the user of a program that is linked with the
+Library has the freedom and the wherewithal to run that program using a
+modified version of the Library.
+
+The precise terms and conditions for copying, distribution and modification
+follow. Pay close attention to the difference between a "work based on the
+library" and a "work that uses the library". The former contains code
+derived from the library, whereas the latter must be combined with the
+library in order to run.
+
+TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+0. This License Agreement applies to any software library or other program
+   which contains a notice placed by the copyright holder or other
+   authorized party saying it may be distributed under the terms of this
+   Lesser General Public License (also called "this License"). Each
+   licensee is addressed as "you".
+
+   A "library" means a collection of software functions and/or data
+   prepared so as to be conveniently linked with application programs
+   (which use some of those functions and data) to form executables.
+
+   The "Library", below, refers to any such software library or work which
+   has been distributed under these terms. A "work based on the Library"
+   means either the Library or any derivative work under copyright law:
+   that is to say, a work containing the Library or a portion of it, either
+   verbatim or with modifications and/or translated straightforwardly into
+   another language. (Hereinafter, translation is included without
+   limitation in the term "modification".)
+
+   "Source code" for a work means the preferred form of the work for making
+   modifications to it. For a library, complete source code means all the
+   source code for all modules it contains, plus any associated interface
+   definition files, plus the scripts used to control compilation and
+   installation of the library.
+
+    Activities other than copying, distribution and modification are not
+    covered by this License; they are outside its scope. The act of running
+    a program using the Library is not restricted, and output from such a
+    program is covered only if its contents constitute a work based on the
+    Library (independent of the use of the Library in a tool for writing
+    it). Whether that is true depends on what the Library does and what the
+    program that uses the Library does.
+
+1. You may copy and distribute verbatim copies of the Library's complete
+   source code as you receive it, in any medium, provided that you
+   conspicuously and appropriately publish on each copy an appropriate
+   copyright notice and disclaimer of warranty; keep intact all the notices
+   that refer to this License and to the absence of any warranty; and
+   distribute a copy of this License along with the Library.
+
+   You may charge a fee for the physical act of transferring a copy, and
+   you may at your option offer warranty protection in exchange for a fee.
+
+2. You may modify your copy or copies of the Library or any portion of it,
+   thus forming a work based on the Library, and copy and distribute such
+   modifications or work under the terms of Section 1 above, provided that
+   you also meet all of these conditions:
+
+   a) The modified work must itself be a software library.
+
+   b) You must cause the files modified to carry prominent notices stating
+      that you changed the files and the date of any change.
+
+   c) You must cause the whole of the work to be licensed at no charge to
+      all third parties under the terms of this License.
+
+   d) If a facility in the modified Library refers to a function or a table
+      of data to be supplied by an application program that uses the
+      facility, other than as an argument passed when the facility is
+      invoked, then you must make a good faith effort to ensure that, in
+      the event an application does not supply such function or table, the
+      facility still operates, and performs whatever part of its purpose
+      remains meaningful.
+
+   (For example, a function in a library to compute square roots has a
+    purpose that is entirely well-defined independent of the
+    application. Therefore, Subsection 2d requires that any
+    application-supplied function or table used by this function must be
+    optional: if the application does not supply it, the square root
+    function must still compute square roots.)
+
+   These requirements apply to the modified work as a whole. If
+   identifiable sections of that work are not derived from the Library, and
+   can be reasonably considered independent and separate works in
+   themselves, then this License, and its terms, do not apply to those
+   sections when you distribute them as separate works. But when you
+   distribute the same sections as part of a whole which is a work based on
+   the Library, the distribution of the whole must be on the terms of this
+   License, whose permissions for other licensees extend to the entire
+   whole, and thus to each and every part regardless of who wrote it.
+
+   Thus, it is not the intent of this section to claim rights or contest
+   your rights to work written entirely by you; rather, the intent is to
+   exercise the right to control the distribution of derivative or
+   collective works based on the Library.
+
+   In addition, mere aggregation of another work not based on the Library
+   with the Library (or with a work based on the Library) on a volume of a
+   storage or distribution medium does not bring the other work under the
+   scope of this License.
+
+3. You may opt to apply the terms of the ordinary GNU General Public
+   License instead of this License to a given copy of the Library. To do
+   this, you must alter all the notices that refer to this License, so that
+   they refer to the ordinary GNU General Public License, version 2,
+   instead of to this License. (If a newer version than version 2 of the
+   ordinary GNU General Public License has appeared, then you can specify
+   that version instead if you wish.) Do not make any other change in these
+   notices.
+
+   Once this change is made in a given copy, it is irreversible for that
+   copy, so the ordinary GNU General Public License applies to all
+   subsequent copies and derivative works made from that copy.
+
+   This option is useful when you wish to copy part of the code of the
+   Library into a program that is not a library.
+
+4. You may copy and distribute the Library (or a portion or derivative of
+   it, under Section 2) in object code or executable form under the terms
+   of Sections 1 and 2 above provided that you accompany it with the
+   complete corresponding machine-readable source code, which must be
+   distributed under the terms of Sections 1 and 2 above on a medium
+   customarily used for software interchange.
+
+   If distribution of object code is made by offering access to copy from a
+   designated place, then offering equivalent access to copy the source
+   code from the same place satisfies the requirement to distribute the
+   source code, even though third parties are not compelled to copy the
+   source along with the object code.
+
+5. A program that contains no derivative of any portion of the Library, but
+   is designed to work with the Library by being compiled or linked with
+   it, is called a "work that uses the Library". Such a work, in isolation,
+   is not a derivative work of the Library, and therefore falls outside the
+   scope of this License.
+
+   However, linking a "work that uses the Library" with the Library creates
+   an executable that is a derivative of the Library (because it contains
+   portions of the Library), rather than a "work that uses the
+   library". The executable is therefore covered by this License. Section 6
+   states terms for distribution of such executables.
+
+   When a "work that uses the Library" uses material from a header file
+   that is part of the Library, the object code for the work may be a
+   derivative work of the Library even though the source code is
+   not. Whether this is true is especially significant if the work can be
+   linked without the Library, or if the work is itself a library. The
+   threshold for this to be true is not precisely defined by law.
+
+   If such an object file uses only numerical parameters, data structure
+   layouts and accessors, and small macros and small inline functions (ten
+   lines or less in length), then the use of the object file is
+   unrestricted, regardless of whether it is legally a derivative
+   work. (Executables containing this object code plus portions of the
+   Library will still fall under Section 6.)
+
+   Otherwise, if the work is a derivative of the Library, you may
+   distribute the object code for the work under the terms of Section
+   6. Any executables containing that work also fall under Section 6,
+   whether or not they are linked directly with the Library itself.
+
+6. As an exception to the Sections above, you may also combine or link a
+   "work that uses the Library" with the Library to produce a work
+   containing portions of the Library, and distribute that work under terms
+   of your choice, provided that the terms permit modification of the work
+   for the customer's own use and reverse engineering for debugging such
+   modifications.
+
+   You must give prominent notice with each copy of the work that the
+   Library is used in it and that the Library and its use are covered by
+   this License. You must supply a copy of this License. If the work during
+   execution displays copyright notices, you must include the copyright
+   notice for the Library among them, as well as a reference directing the
+   user to the copy of this License. Also, you must do one of these things:
+
+   a) Accompany the work with the complete corresponding machine-readable
+      source code for the Library including whatever changes were used in
+      the work (which must be distributed under Sections 1 and 2 above);
+      and, if the work is an executable linked with the Library, with the
+      complete machine-readable "work that uses the Library", as object
+      code and/or source code, so that the user can modify the Library and
+      then relink to produce a modified executable containing the modified
+      Library. (It is understood that the user who changes the contents of
+      definitions files in the Library will not necessarily be able to
+      recompile the application to use the modified definitions.)
+
+   b) Use a suitable shared library mechanism for linking with the
+      Library. A suitable mechanism is one that (1) uses at run time a copy
+      of the library already present on the user's computer system, rather
+      than copying library functions into the executable, and (2) will
+      operate properly with a modified version of the library, if the user
+      installs one, as long as the modified version is interface-compatible
+      with the version that the work was made with.
+
+   c) Accompany the work with a written offer, valid for at least three
+      years, to give the same user the materials specified in Subsection
+      6a, above, for a charge no more than the cost of performing this
+      distribution.
+
+   d) If distribution of the work is made by offering access to copy from a
+      designated place, offer equivalent access to copy the above specified
+      materials from the same place.
+
+   e) Verify that the user has already received a copy of these materials
+      or that you have already sent this user a copy.
+
+   For an executable, the required form of the "work that uses the Library"
+   must include any data and utility programs needed for reproducing the
+   executable from it. However, as a special exception, the materials to be
+   distributed need not include anything that is normally distributed (in
+   either source or binary form) with the major components (compiler,
+   kernel, and so on) of the operating system on which the executable runs,
+   unless that component itself accompanies the executable.
+
+   It may happen that this requirement contradicts the license restrictions
+   of other proprietary libraries that do not normally accompany the
+   operating system. Such a contradiction means you cannot use both them
+   and the Library together in an executable that you distribute.
+
+7. You may place library facilities that are a work based on the Library
+   side-by-side in a single library together with other library facilities
+   not covered by this License, and distribute such a combined library,
+   provided that the separate distribution of the work based on the Library
+   and of the other library facilities is otherwise permitted, and provided
+   that you do these two things:
+
+   a) Accompany the combined library with a copy of the same work based on
+      the Library, uncombined with any other library facilities. This must
+      be distributed under the terms of the Sections above.
+
+   b) Give prominent notice with the combined library of the fact that part
+      of it is a work based on the Library, and explaining where to find
+      the accompanying uncombined form of the same work.
+
+8. You may not copy, modify, sublicense, link with, or distribute the
+   Library except as expressly provided under this License. Any attempt
+   otherwise to copy, modify, sublicense, link with, or distribute the
+   Library is void, and will automatically terminate your rights under this
+   License. However, parties who have received copies, or rights, from you
+   under this License will not have their licenses terminated so long as
+   such parties remain in full compliance.
+
+9. You are not required to accept this License, since you have not signed
+   it. However, nothing else grants you permission to modify or distribute
+   the Library or its derivative works. These actions are prohibited by law
+   if you do not accept this License. Therefore, by modifying or
+   distributing the Library (or any work based on the Library), you
+   indicate your acceptance of this License to do so, and all its terms and
+   conditions for copying, distributing or modifying the Library or works
+   based on it.
+
+10. Each time you redistribute the Library (or any work based on the
+    Library), the recipient automatically receives a license from the
+    original licensor to copy, distribute, link with or modify the Library
+    subject to these terms and conditions. You may not impose any further
+    restrictions on the recipients' exercise of the rights granted
+    herein. You are not responsible for enforcing compliance by third
+    parties with this License.
+
+11. If, as a consequence of a court judgment or allegation of patent
+    infringement or for any other reason (not limited to patent issues),
+    conditions are imposed on you (whether by court order, agreement or
+    otherwise) that contradict the conditions of this License, they do not
+    excuse you from the conditions of this License. If you cannot
+    distribute so as to satisfy simultaneously your obligations under this
+    License and any other pertinent obligations, then as a consequence you
+    may not distribute the Library at all. For example, if a patent license
+    would not permit royalty-free redistribution of the Library by all
+    those who receive copies directly or indirectly through you, then the
+    only way you could satisfy both it and this License would be to refrain
+    entirely from distribution of the Library.
+
+    If any portion of this section is held invalid or unenforceable under
+    any particular circumstance, the balance of the section is intended to
+    apply, and the section as a whole is intended to apply in other
+    circumstances.
+
+    It is not the purpose of this section to induce you to infringe any
+    patents or other property right claims or to contest validity of any
+    such claims; this section has the sole purpose of protecting the
+    integrity of the free software distribution system which is implemented
+    by public license practices. Many people have made generous
+    contributions to the wide range of software distributed through that
+    system in reliance on consistent application of that system; it is up
+    to the author/donor to decide if he or she is willing to distribute
+    software through any other system and a licensee cannot impose that
+    choice.
+
+    This section is intended to make thoroughly clear what is believed to
+    be a consequence of the rest of this License.
+
+12. If the distribution and/or use of the Library is restricted in certain
+    countries either by patents or by copyrighted interfaces, the original
+    copyright holder who places the Library under this License may add an
+    explicit geographical distribution limitation excluding those
+    countries, so that distribution is permitted only in or among countries
+    not thus excluded. In such case, this License incorporates the
+    limitation as if written in the body of this License.
+
+13. The Free Software Foundation may publish revised and/or new versions of
+    the Lesser General Public License from time to time. Such new versions
+    will be similar in spirit to the present version, but may differ in
+    detail to address new problems or concerns.
+
+    Each version is given a distinguishing version number. If the Library
+    specifies a version number of this License which applies to it and "any
+    later version", you have the option of following the terms and
+    conditions either of that version or of any later version published by
+    the Free Software Foundation. If the Library does not specify a license
+    version number, you may choose any version ever published by the Free
+    Software Foundation.
+
+14. If you wish to incorporate parts of the Library into other free
+    programs whose distribution conditions are incompatible with these,
+    write to the author to ask for permission. For software which is
+    copyrighted by the Free Software Foundation, write to the Free Software
+    Foundation; we sometimes make exceptions for this. Our decision will be
+    guided by the two goals of preserving the free status of all
+    derivatives of our free software and of promoting the sharing and reuse
+    of software generally.
+
+NO WARRANTY
+
+15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+    FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN
+    OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+    PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER
+    EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE
+    ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE LIBRARY IS WITH
+    YOU. SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL
+    NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+    WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+    REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU FOR
+    DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL
+    DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE LIBRARY
+    (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED
+    INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF
+    THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF SUCH HOLDER OR
+    OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.
+
+END OF TERMS AND CONDITIONS
+
+How to Apply These Terms to Your New Libraries
+
+If you develop a new library, and you want it to be of the greatest
+possible use to the public, we recommend making it free software that
+everyone can redistribute and change. You can do so by permitting
+redistribution under these terms (or, alternatively, under the terms of the
+ordinary General Public License).
+
+To apply these terms, attach the following notices to the library. It is
+safest to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least the
+"copyright" line and a pointer to where the full notice is found.
+
+one line to give the library's name and an idea of what it does.
+Copyright (C) year name of author
+
+This library is free software; you can redistribute it and/or modify it
+under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation; either version 2.1 of the License, or (at
+your option) any later version.
+
+This library is distributed in the hope that it will be useful, but WITHOUT
+ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
+for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with this library; if not, write to the Free Software Foundation,
+Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Also add
+information on how to contact you by electronic and paper mail.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the library, if
+necessary. Here is a sample; alter the names:
+
+Yoyodyne, Inc., hereby disclaims all copyright interest in
+the library `Frob' (a library for tweaking knobs) written
+by James Random Hacker.
+
+signature of Ty Coon, 1 April 1990
+Ty Coon, President of Vice
+That's all there is to it!
diff --git a/LICENSES/MIT b/LICENSES/MIT
new file mode 100644
index 0000000000..f33a68ceb3
--- /dev/null
+++ b/LICENSES/MIT
@@ -0,0 +1,30 @@
+Valid-License-Identifier: MIT
+SPDX-URL: https://spdx.org/licenses/MIT.html
+Usage-Guide:
+  To use the MIT License put the following SPDX tag/value pair into a
+  comment according to the placement guidelines in the licensing rules
+  documentation:
+    SPDX-License-Identifier: MIT
+License-Text:
+
+MIT License
+
+Copyright (c) <year> <copyright holders>
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the "Software"),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense,
+and/or sell copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 00:16:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 00:16:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418367.663173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVZ-0004AB-B5; Sat, 08 Oct 2022 00:16:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418367.663173; Sat, 08 Oct 2022 00:16:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogxVZ-00049Z-35; Sat, 08 Oct 2022 00:16:01 +0000
Received: by outflank-mailman (input) for mailman id 418367;
 Sat, 08 Oct 2022 00:15:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZrwE=2J=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ogxVX-0003Ov-JY
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 00:15:59 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 618cb439-469e-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 02:15:57 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0B255B823E4;
 Sat,  8 Oct 2022 00:15:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DC7DC433B5;
 Sat,  8 Oct 2022 00:15:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 618cb439-469e-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665188155;
	bh=0tlZ5oqIKF90SmBwwmcNmsbO0/yMV9+vvKH5K5z8FCc=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=Avn5S7iq6eYjBd59mzdCOlm0MLm2AVQrmJ/XZJjk9/5V/4fjjSmUC6wL1cThU0+V1
	 Ng/bn4PnR0lOikrpKN8Jc8SltKq57nqSzq7px7R2yqNzhu6OLxc7WMwhmfBpUPwLGU
	 N9rtxatgJNOWFhxd+jXB0KCopIQEsrXHkzYE1Ux1BB8oWWzDGaxKr66Bhh5Vs6th5v
	 BbNguOHV081/WNfUC+dNNWM1ThLJiCotQAXh/d4j9510Eb/wz1PXH/rzDQG9m4otXL
	 b61YMjjqIZHcAv/Q5hIBXmmPOiTRGcaBuz7hIyJcAabJYA/i29ImbTah07YTWE7ZLJ
	 LUVnv4GfeAc7g==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v3 4/4] Remove extra copies of licenses and license headers
Date: Fri,  7 Oct 2022 17:15:44 -0700
Message-Id: <20221008001544.78302-4-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Remove the extra copy of the GPL license and license copyright headers
from CONTRIBUTING and the top-level COPYING.

Mention of the LICENSES/ directory and also mention the SPDX tag.

SPDX support is still in progress and COPYING files in subdirectories
still need to be updated.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
Patch new in v3
---
 CONTRIBUTING | 150 ++--------------------
 COPYING      | 351 +--------------------------------------------------
 2 files changed, 17 insertions(+), 484 deletions(-)

diff --git a/CONTRIBUTING b/CONTRIBUTING
index 6ec146baf0..7b6b03fb96 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -19,10 +19,6 @@ Most notably:
  - tools/xl           : LGPL v2.1
  - xen/include/public : MIT license
 
-The COMMON COPYRIGHT NOTICES section of this document contains
-sample copyright notices for the most common licenses used within
-this repository.
-
 When creating new components, new files, or importing code please follow
 the conventions outlined below. As a general rule, whenever code using a
 license other than GPLv2 is introduced, attention must be drawn to the
@@ -32,20 +28,22 @@ deviation. Any new code must be GPLv2 compatible.
 New components
 --------------
 
-When creating new components and directories that contain a
-significant amount of files that are licensed under licenses other
-than GPLv2 or the license specified in the COPYING file, please
-create a new COPYING file in that directory containing a copy of the
-license text and a rationale for using a different license. This helps
-ensure that the license of this new component/directory is maintained
-consistently with the original intention.
+When creating new components and directories that contain a significant
+amount of files that are licensed under licenses other than GPLv2,
+please create a new COPYING file in that directory with the rationale
+for using a different license. This helps ensure that the license of
+this new component/directory is maintained consistently with the
+original intention.
 
 New files
 ---------
 
-If specific files that differ from the license in a directory are introduced,
-exceptions should be highlighted and discussed in the commit message or cover
-letter introducing the file.
+New files should start with a single-line SPDX comment to express the
+license. The following comment and license are recommended:
+
+/* SPDX-License-Identifier: GPL-2.0 */
+
+See LICENSES/ for a list of licenses and SPDX tags currently used.
 
 Importing code
 --------------
@@ -105,127 +103,3 @@ For more information on contributing to this repository, see
  - https://wiki.xenproject.org/wiki/Category:Developers
 
 
-COMMON COPYRIGHT NOTICES
-========================
-
-The following section contains sample copyright notice for the most
-common licenses used within the Xen Project that is consistent with the
-projects coding standards.
-
-GPL v2 License
---------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms and conditions of the GNU General Public
- * License, version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
- */
-
-
-LGPL v2.1 License
------------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License, version 2.1, as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; If not, see <http://www.gnu.org/licenses/>.
- */
-
-BSD-Modified License (also known as BSD-3-Clause)
--------------------------------------------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- *   1. Redistributions of source code must retain the above copyright
- *      notice, this list of conditions and the following disclaimer.
- *   2. Redistributions in binary form must reproduce the above
- *      copyright notice, this list of conditions and the following
- *      disclaimer in the documentation and/or other materials provided
- *      with the distribution.
- *   3. Neither the name of the copyright holder nor the names of its
- *      contributors may be used to endorse or promote products derived
- *      from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
- * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
- * OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-
-MIT License
------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- *
- * Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without restriction,
- * including without limitation the rights to use, copy, modify, merge,
- * publish, distribute, sublicense, and/or sell copies of the Software,
- * and to permit persons to whom the Software is furnished to do so,
- * subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
- * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
- * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
- * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- */
-
diff --git a/COPYING b/COPYING
index a4bc2b2dd4..824c3aa353 100644
--- a/COPYING
+++ b/COPYING
@@ -3,11 +3,11 @@ GNU General Public License
 --------------------------
 
 Most files in this repository are licensed under the terms of the GNU
-General Public License (GPL), a copy of which is attached at the end
-of this notice. Note that the only valid version of the GPL as far as
-the files in this repository are concerned is _this_ particular
-version of the license (i.e., *only* v2, not v2.2 or v3.x or
-whatever), unless explicitly otherwise stated.
+General Public License (GPL), a copy of which is present under the
+LICENSES/ directory. Note that the only valid version of the GPL as far
+as the files in this repository are concerned is _this_ particular
+version of the license (i.e., *only* v2, not v2.2 or v3.x or whatever),
+unless explicitly otherwise stated.
 
 Some code fragments in the hypervisor and associated subsystems
 include other license stanzas: the most common ones are listed in
@@ -73,344 +73,3 @@ governs the license of its containing directory and its subdirectories.
 
 For more information, see the CONTRIBUTING file.
 
-=====================================================================
-
-		    GNU GENERAL PUBLIC LICENSE
-		       Version 2, June 1991
-
- Copyright (C) 1989, 1991 Free Software Foundation, Inc.
-                       59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- Everyone is permitted to copy and distribute verbatim copies
- of this license document, but changing it is not allowed.
-
-			    Preamble
-
-  The licenses for most software are designed to take away your
-freedom to share and change it.  By contrast, the GNU General Public
-License is intended to guarantee your freedom to share and change free
-software--to make sure the software is free for all its users.  This
-General Public License applies to most of the Free Software
-Foundation's software and to any other program whose authors commit to
-using it.  (Some other Free Software Foundation software is covered by
-the GNU Library General Public License instead.)  You can apply it to
-your programs, too.
-
-  When we speak of free software, we are referring to freedom, not
-price.  Our General Public Licenses are designed to make sure that you
-have the freedom to distribute copies of free software (and charge for
-this service if you wish), that you receive source code or can get it
-if you want it, that you can change the software or use pieces of it
-in new free programs; and that you know you can do these things.
-
-  To protect your rights, we need to make restrictions that forbid
-anyone to deny you these rights or to ask you to surrender the rights.
-These restrictions translate to certain responsibilities for you if you
-distribute copies of the software, or if you modify it.
-
-  For example, if you distribute copies of such a program, whether
-gratis or for a fee, you must give the recipients all the rights that
-you have.  You must make sure that they, too, receive or can get the
-source code.  And you must show them these terms so they know their
-rights.
-
-  We protect your rights with two steps: (1) copyright the software, and
-(2) offer you this license which gives you legal permission to copy,
-distribute and/or modify the software.
-
-  Also, for each author's protection and ours, we want to make certain
-that everyone understands that there is no warranty for this free
-software.  If the software is modified by someone else and passed on, we
-want its recipients to know that what they have is not the original, so
-that any problems introduced by others will not reflect on the original
-authors' reputations.
-
-  Finally, any free program is threatened constantly by software
-patents.  We wish to avoid the danger that redistributors of a free
-program will individually obtain patent licenses, in effect making the
-program proprietary.  To prevent this, we have made it clear that any
-patent must be licensed for everyone's free use or not licensed at all.
-
-  The precise terms and conditions for copying, distribution and
-modification follow.
-
-		    GNU GENERAL PUBLIC LICENSE
-   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
-
-  0. This License applies to any program or other work which contains
-a notice placed by the copyright holder saying it may be distributed
-under the terms of this General Public License.  The "Program", below,
-refers to any such program or work, and a "work based on the Program"
-means either the Program or any derivative work under copyright law:
-that is to say, a work containing the Program or a portion of it,
-either verbatim or with modifications and/or translated into another
-language.  (Hereinafter, translation is included without limitation in
-the term "modification".)  Each licensee is addressed as "you".
-
-Activities other than copying, distribution and modification are not
-covered by this License; they are outside its scope.  The act of
-running the Program is not restricted, and the output from the Program
-is covered only if its contents constitute a work based on the
-Program (independent of having been made by running the Program).
-Whether that is true depends on what the Program does.
-
-  1. You may copy and distribute verbatim copies of the Program's
-source code as you receive it, in any medium, provided that you
-conspicuously and appropriately publish on each copy an appropriate
-copyright notice and disclaimer of warranty; keep intact all the
-notices that refer to this License and to the absence of any warranty;
-and give any other recipients of the Program a copy of this License
-along with the Program.
-
-You may charge a fee for the physical act of transferring a copy, and
-you may at your option offer warranty protection in exchange for a fee.
-
-  2. You may modify your copy or copies of the Program or any portion
-of it, thus forming a work based on the Program, and copy and
-distribute such modifications or work under the terms of Section 1
-above, provided that you also meet all of these conditions:
-
-    a) You must cause the modified files to carry prominent notices
-    stating that you changed the files and the date of any change.
-
-    b) You must cause any work that you distribute or publish, that in
-    whole or in part contains or is derived from the Program or any
-    part thereof, to be licensed as a whole at no charge to all third
-    parties under the terms of this License.
-
-    c) If the modified program normally reads commands interactively
-    when run, you must cause it, when started running for such
-    interactive use in the most ordinary way, to print or display an
-    announcement including an appropriate copyright notice and a
-    notice that there is no warranty (or else, saying that you provide
-    a warranty) and that users may redistribute the program under
-    these conditions, and telling the user how to view a copy of this
-    License.  (Exception: if the Program itself is interactive but
-    does not normally print such an announcement, your work based on
-    the Program is not required to print an announcement.)
-
-These requirements apply to the modified work as a whole.  If
-identifiable sections of that work are not derived from the Program,
-and can be reasonably considered independent and separate works in
-themselves, then this License, and its terms, do not apply to those
-sections when you distribute them as separate works.  But when you
-distribute the same sections as part of a whole which is a work based
-on the Program, the distribution of the whole must be on the terms of
-this License, whose permissions for other licensees extend to the
-entire whole, and thus to each and every part regardless of who wrote it.
-
-Thus, it is not the intent of this section to claim rights or contest
-your rights to work written entirely by you; rather, the intent is to
-exercise the right to control the distribution of derivative or
-collective works based on the Program.
-
-In addition, mere aggregation of another work not based on the Program
-with the Program (or with a work based on the Program) on a volume of
-a storage or distribution medium does not bring the other work under
-the scope of this License.
-
-  3. You may copy and distribute the Program (or a work based on it,
-under Section 2) in object code or executable form under the terms of
-Sections 1 and 2 above provided that you also do one of the following:
-
-    a) Accompany it with the complete corresponding machine-readable
-    source code, which must be distributed under the terms of Sections
-    1 and 2 above on a medium customarily used for software interchange; or,
-
-    b) Accompany it with a written offer, valid for at least three
-    years, to give any third party, for a charge no more than your
-    cost of physically performing source distribution, a complete
-    machine-readable copy of the corresponding source code, to be
-    distributed under the terms of Sections 1 and 2 above on a medium
-    customarily used for software interchange; or,
-
-    c) Accompany it with the information you received as to the offer
-    to distribute corresponding source code.  (This alternative is
-    allowed only for noncommercial distribution and only if you
-    received the program in object code or executable form with such
-    an offer, in accord with Subsection b above.)
-
-The source code for a work means the preferred form of the work for
-making modifications to it.  For an executable work, complete source
-code means all the source code for all modules it contains, plus any
-associated interface definition files, plus the scripts used to
-control compilation and installation of the executable.  However, as a
-special exception, the source code distributed need not include
-anything that is normally distributed (in either source or binary
-form) with the major components (compiler, kernel, and so on) of the
-operating system on which the executable runs, unless that component
-itself accompanies the executable.
-
-If distribution of executable or object code is made by offering
-access to copy from a designated place, then offering equivalent
-access to copy the source code from the same place counts as
-distribution of the source code, even though third parties are not
-compelled to copy the source along with the object code.
-
-  4. You may not copy, modify, sublicense, or distribute the Program
-except as expressly provided under this License.  Any attempt
-otherwise to copy, modify, sublicense or distribute the Program is
-void, and will automatically terminate your rights under this License.
-However, parties who have received copies, or rights, from you under
-this License will not have their licenses terminated so long as such
-parties remain in full compliance.
-
-  5. You are not required to accept this License, since you have not
-signed it.  However, nothing else grants you permission to modify or
-distribute the Program or its derivative works.  These actions are
-prohibited by law if you do not accept this License.  Therefore, by
-modifying or distributing the Program (or any work based on the
-Program), you indicate your acceptance of this License to do so, and
-all its terms and conditions for copying, distributing or modifying
-the Program or works based on it.
-
-  6. Each time you redistribute the Program (or any work based on the
-Program), the recipient automatically receives a license from the
-original licensor to copy, distribute or modify the Program subject to
-these terms and conditions.  You may not impose any further
-restrictions on the recipients' exercise of the rights granted herein.
-You are not responsible for enforcing compliance by third parties to
-this License.
-
-  7. If, as a consequence of a court judgment or allegation of patent
-infringement or for any other reason (not limited to patent issues),
-conditions are imposed on you (whether by court order, agreement or
-otherwise) that contradict the conditions of this License, they do not
-excuse you from the conditions of this License.  If you cannot
-distribute so as to satisfy simultaneously your obligations under this
-License and any other pertinent obligations, then as a consequence you
-may not distribute the Program at all.  For example, if a patent
-license would not permit royalty-free redistribution of the Program by
-all those who receive copies directly or indirectly through you, then
-the only way you could satisfy both it and this License would be to
-refrain entirely from distribution of the Program.
-
-If any portion of this section is held invalid or unenforceable under
-any particular circumstance, the balance of the section is intended to
-apply and the section as a whole is intended to apply in other
-circumstances.
-
-It is not the purpose of this section to induce you to infringe any
-patents or other property right claims or to contest validity of any
-such claims; this section has the sole purpose of protecting the
-integrity of the free software distribution system, which is
-implemented by public license practices.  Many people have made
-generous contributions to the wide range of software distributed
-through that system in reliance on consistent application of that
-system; it is up to the author/donor to decide if he or she is willing
-to distribute software through any other system and a licensee cannot
-impose that choice.
-
-This section is intended to make thoroughly clear what is believed to
-be a consequence of the rest of this License.
-
-  8. If the distribution and/or use of the Program is restricted in
-certain countries either by patents or by copyrighted interfaces, the
-original copyright holder who places the Program under this License
-may add an explicit geographical distribution limitation excluding
-those countries, so that distribution is permitted only in or among
-countries not thus excluded.  In such case, this License incorporates
-the limitation as if written in the body of this License.
-
-  9. The Free Software Foundation may publish revised and/or new versions
-of the General Public License from time to time.  Such new versions will
-be similar in spirit to the present version, but may differ in detail to
-address new problems or concerns.
-
-Each version is given a distinguishing version number.  If the Program
-specifies a version number of this License which applies to it and "any
-later version", you have the option of following the terms and conditions
-either of that version or of any later version published by the Free
-Software Foundation.  If the Program does not specify a version number of
-this License, you may choose any version ever published by the Free Software
-Foundation.
-
-  10. If you wish to incorporate parts of the Program into other free
-programs whose distribution conditions are different, write to the author
-to ask for permission.  For software which is copyrighted by the Free
-Software Foundation, write to the Free Software Foundation; we sometimes
-make exceptions for this.  Our decision will be guided by the two goals
-of preserving the free status of all derivatives of our free software and
-of promoting the sharing and reuse of software generally.
-
-			    NO WARRANTY
-
-  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
-FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
-OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
-PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
-OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
-MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
-TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
-PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
-REPAIR OR CORRECTION.
-
-  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
-WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
-REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
-INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
-OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
-TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
-YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
-PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGES.
-
-		     END OF TERMS AND CONDITIONS
-
-	    How to Apply These Terms to Your New Programs
-
-  If you develop a new program, and you want it to be of the greatest
-possible use to the public, the best way to achieve this is to make it
-free software which everyone can redistribute and change under these terms.
-
-  To do so, attach the following notices to the program.  It is safest
-to attach them to the start of each source file to most effectively
-convey the exclusion of warranty; and each file should have at least
-the "copyright" line and a pointer to where the full notice is found.
-
-    <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) <year>  <name of author>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program; If not, see <http://www.gnu.org/licenses/>.
-
-
-Also add information on how to contact you by electronic and paper mail.
-
-If the program is interactive, make it output a short notice like this
-when it starts in an interactive mode:
-
-    Gnomovision version 69, Copyright (C) year name of author
-    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-    This is free software, and you are welcome to redistribute it
-    under certain conditions; type `show c' for details.
-
-The hypothetical commands `show w' and `show c' should show the appropriate
-parts of the General Public License.  Of course, the commands you use may
-be called something other than `show w' and `show c'; they could even be
-mouse-clicks or menu items--whatever suits your program.
-
-You should also get your employer (if you work as a programmer) or your
-school, if any, to sign a "copyright disclaimer" for the program, if
-necessary.  Here is a sample; alter the names:
-
-  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
-  `Gnomovision' (which makes passes at compilers) written by James Hacker.
-
-  <signature of Ty Coon>, 1 April 1989
-  Ty Coon, President of Vice
-
-This General Public License does not permit incorporating your program into
-proprietary programs.  If your program is a subroutine library, you may
-consider it more useful to permit linking proprietary applications with the
-library.  If this is what you want to do, use the GNU Library General
-Public License instead of this License.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 01:12:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 01:12:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418390.663189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogyOB-0005ST-AF; Sat, 08 Oct 2022 01:12:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418390.663189; Sat, 08 Oct 2022 01:12:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogyOB-0005SM-6U; Sat, 08 Oct 2022 01:12:27 +0000
Received: by outflank-mailman (input) for mailman id 418390;
 Sat, 08 Oct 2022 01:12:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XOy/=2J=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ogyO9-0005SG-By
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 01:12:25 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2087.outbound.protection.outlook.com [40.107.104.87])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42e1a11e-46a6-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 03:12:22 +0200 (CEST)
Received: from DU2PR04CA0052.eurprd04.prod.outlook.com (2603:10a6:10:234::27)
 by DU0PR08MB8812.eurprd08.prod.outlook.com (2603:10a6:10:47b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 8 Oct
 2022 01:12:20 +0000
Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:234:cafe::8a) by DU2PR04CA0052.outlook.office365.com
 (2603:10a6:10:234::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Sat, 8 Oct 2022 01:12:20 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Sat, 8 Oct 2022 01:12:20 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Sat, 08 Oct 2022 01:12:19 +0000
Received: from eee54d568dfc.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7B8521BD-FB8D-44C9-B043-B47B83BB864F.1; 
 Sat, 08 Oct 2022 01:12:14 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eee54d568dfc.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 08 Oct 2022 01:12:14 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PA4PR08MB5903.eurprd08.prod.outlook.com (2603:10a6:102:e9::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 8 Oct
 2022 01:12:12 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::10bf:2915:c966:b45a%3]) with mapi id 15.20.5676.038; Sat, 8 Oct 2022
 01:12:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42e1a11e-46a6-11ed-964a-05401a9f4f97
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Dk1BAApvvglQJ0oO3vW/NVw36ozmpNNFpjbF4SJonU274khCN+uojKlcvHGt7LW3KJvoRWatuEibQC4aNq8JjIMHBp/T3MT5GdXadeIQ/E4Wq0OCxbfdNiOTxZPZr7mkiMhNz+cFGYAxM5Em+WUa+zA/wB0RFhB8P/rNub1DtBo5WzKz/0XDmVVWMmm2RI6j6RVGT6BfU8LAxWgDRR3mlklxyoqLgvxrBWac8h5LW4O0ovxitLxeFhTGrMUzlVAFOHpw6C2Ps94j+ThLdWYAK9vMgpcSWhbJBnHO9EBob/eNCGiZNL++zFSMYRkkbnAVX/NxqFxiNwxOCwWtZuiLjg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vNxP3LEs07NmCGRCKog1G1IpJpiFJh5GDDGw6HO/dAM=;
 b=hqE8F07Esk0Vh7lYlpQ6OKnD4ZS+mjeF7U9VWsONgBV4OlMUo2kqZONA3ZLXGs5POHOKyFJlgacmcnzbfB+5L/O7cjPuV+qVlKz1JGK9zravX3T2kra9JgNLzNkecq2Nr7IJlchChJ7x8TMPt+jKo4oVCm0ZDcP66c++IhlVaolHelLcYRw/jpKMujo3fs+WdqNx4NRt1y4PCdLbgEI3dg8BSz0STq1KROFWyEAFkSXhD37LiO19iOEaAyJXdHEv4T30hPHUo2/xKcn+t6quSKWQI2esjtJgH5W4XeVWlal4SL9oRdLbELYAHZnja+tBEcV99Gav9fWGcIk97h7Shw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vNxP3LEs07NmCGRCKog1G1IpJpiFJh5GDDGw6HO/dAM=;
 b=Q34HWwHa8gh6n1AzgtH7m7D1a/nrZkJV3CLtBuxW48AMkyquUOo7zW6t3UMjpRtrcSd2z0FOYeQ9iYQ3iimwezixlVXhfC8FdOImWUG1+sJwDzLL/ziZ3vMRorDjgf0bHfSl+yBLOGmFmDQg/vnAK9oA/6kgFdS6FS7dOrXpyzI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RakXG8oEmmmveUDD5Eav12WRBFNlzPiGGbRwugUVItJGwsXibEbMP2EB5SPLp1HtSHUPhd3/EPRlAdMOTIxgcBXJX1SIgc3a/IBzGmcg6PJyUpqm9f0U1vpSBJ2smt8X6igSJk6aaJeIGWsCc1ObCuQrjb4k6j8rf7UF12QxFLzwoBFmSZqsFbRCD1RJvUDu/Ew8p3K2SSzTT1KFq3G35PxM4iQMR9N/YVYq2VVJksrNLw9Sy25pkSKrDQjyOzqxN1Gsx2T3e6JW7qdr5WE/KRQCzJAdgbX91dfM72uuFCEoP+8vwB+ESOqFivuCOMkJiw3frS2tgu2TeX+mUUplkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vNxP3LEs07NmCGRCKog1G1IpJpiFJh5GDDGw6HO/dAM=;
 b=O4BgjhcWsGK5oKKYpsbdSDK45n8M2vUVgnhjIUymQeaFx2yNZn6jnf1riuM+wjOdYDEKLMGqmAEezG9BIFHUhexomtIftFYPy6s4upKAx84ogNzfGskz0s1OXixd3A7hHuCKMXHKTEXf7quX9tPl82cG1JC13J5mof+0bQdD4v6HCZXdqvOD/xoeRwGILaf0GELab9qbgKHCmAzKlQaJTFrXWcd8pwM8n0Q8BdhHXjCuRBhuqDBQD5pS5dX26w/bhDO+K00I7PPckN026GaKfghm6WCNDv6s/QhC/vEh0p+gR/RrIs7hy2lZhIkFT9+L+jGtN/ZvJgwb6YEq79Ct5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vNxP3LEs07NmCGRCKog1G1IpJpiFJh5GDDGw6HO/dAM=;
 b=Q34HWwHa8gh6n1AzgtH7m7D1a/nrZkJV3CLtBuxW48AMkyquUOo7zW6t3UMjpRtrcSd2z0FOYeQ9iYQ3iimwezixlVXhfC8FdOImWUG1+sJwDzLL/ziZ3vMRorDjgf0bHfSl+yBLOGmFmDQg/vnAK9oA/6kgFdS6FS7dOrXpyzI=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jason Andryuk
	<jandryuk@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Christopher Clark <christopher.w.clark@gmail.com>
Subject: RE: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Topic: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Index: AQHY2oOIAk0kP8Ly4EylVwyMRp/g6q4DWdEAgABVmDA=
Date: Sat, 8 Oct 2022 01:12:12 +0000
Message-ID:
 <AS8PR08MB7991432FC3C0643161277930925E9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221007193124.20322-1-jandryuk@gmail.com>
 <a4524dcc-36ce-267a-afbd-5785eab73882@citrix.com>
In-Reply-To: <a4524dcc-36ce-267a-afbd-5785eab73882@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: E7CB587E436A3F4FB5C3AC36D395DE91.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PA4PR08MB5903:EE_|DBAEUR03FT042:EE_|DU0PR08MB8812:EE_
X-MS-Office365-Filtering-Correlation-Id: e31faa46-caec-4ae6-2460-08daa8ca25ff
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 SzEZGZ1TGj5Wv4t6jPVkgRRzofezulwKnAjWekJero2k+FOs9683tiRmI4Il7bk34khACdJAFwGMKsNx22St5bL8fe3M6hoEv6F4rPuFY4EJ9dWqSthDNeBDf+EO7GcQMWfMO+LtwLdAp7/qhrgltxmk9cWnPJdH0M16Tk57mNOpVjb0JPvcjLNTJD+JWFPXS9fqUWGNeFnBHuUwbHu/DR5a848bnvQYxw3mBUKaTVK1ew2dU/nFrS1mHIAb8meQEdjB6vjUOEihw923CMZHcTloyYinv74cP+xySTnveB8A9GtR3lIgpqsyIoZccB05Kz0fcyVJqcU3eGg8IXStDMj4o5MkXfkoPWuZyTDg8sT/tLU8NinSVXDgpyAUGeRXBbG2yRfgL29IwsbogpoeBHo1wrnuyQeDe/Gf7V9YpP0oolHmtzOUp0sTd/l5WPS6XuCw/VuW2AZ/8YPrUA6Kr4k/J9/MOR3YkWG34g1vCup2lq8NDFJOSH4zGULXIa4YHD4CpNrOsaOigxm8bW16pSw7GKdZl4AcUtU2Q6lJNfSBfNqi0q2JoA5kyeXA6cmWsAIUpYmplz1AwVhQyQAl+q+6iHOy5pSE3fTWNCl0eZ7kugBHTh4fWzPwEt6YE0JVfzsU9V/GreAHss4+eUVjSpJpydUV9ZAHCG8xljJLQM95ztYElvAdc7H0Dur4ITBJ0HqSqUAaTT+wfp64ldFHBFlaDmWRI2WwzFVldI48qmFk7brAJii4CskzPphKzl04WtMVvho1dPOdBd1gDeOZvjXMjKhAEXU6GzObESGYDo4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(9686003)(38100700002)(41300700001)(2906002)(478600001)(26005)(186003)(55016003)(71200400001)(122000001)(8936002)(52536014)(316002)(38070700005)(33656002)(53546011)(86362001)(6506007)(7696005)(110136005)(66446008)(66476007)(64756008)(76116006)(5660300002)(966005)(66556008)(66946007)(8676002)(4326008)(83380400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5903
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	43e5137a-8ec3-44e1-b46d-08daa8ca21ad
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	C+t/s2BgvjmYbADfUIjBU41+Fp63qYJWdA0PhmFmvwA2/A9Eaym9BXkGQUX1S1l68xX8JsnEowscPpUr+Qsqd/aDIMkvhscPlZauhrXIx19hh3rHmrgw8zIpsh6mpcYfTJImKSbr/Q+YsO0SpkT33w91rzBRHX4eMlzRvwFUZftjYByJLES/cbb1mB+2JlswbaSCvY4lM/OsaMykLO5tBvF+z2wNafo4cGiPh2w1ttEJlzXwBUnWNdqjIvEfZ/boA/F9g3xlg2Zl8IAuKEiJGIbcfiBTgYl+lqoYDh08Jn7LzcWMvPSBsuMqF6oUuDkj6WeE/ALBWu4Qig6XtB7S9BgxSBwHuTGQWFlLj2LgT5rC5lkfm48KJgAShdfDoSwVfb/zIBdpuLPymrjX2jRI6rrW5wvDCtCBdKdc7f86RgPC/P5dNEE52qPr6nLncViXwhvqNJOtO5LEnSGAiqjjE0MkN9UGkcP/v9QV1gRNil8omNOHYlykfeHhy3fH4zfGEXHF4BUxXxMitB3YyK63x20YmB1AcJcAZ4IPn78AF6zSgrzqKOZeo2PlySCE1gmPZJSGx59p4vx9ygxrYPtgQ0yfQXR5FV0+WE0lH/1y9lgKzML2tVKBNrpZFk782K/INVPN/Z7bnTCS1uvENbXVfN0FWIoixe/BTr3rLnV9MH20KMFigp8T+Zff/7snvTJGATul6NHZ9hySYwh+6HNPAzMhS1LTCg2fLaJoXIRJupRLuJCvgVItz/FOqA047f21CO+S4XQyjhthMLtYIsDEHcHqjXTakW4JCQG9Puid+Hs=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(4326008)(82310400005)(110136005)(33656002)(86362001)(356005)(81166007)(2906002)(5660300002)(82740400003)(52536014)(41300700001)(70206006)(8936002)(70586007)(8676002)(316002)(26005)(40480700001)(36860700001)(55016003)(47076005)(9686003)(186003)(83380400001)(336012)(40460700003)(53546011)(6506007)(966005)(107886003)(7696005)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2022 01:12:20.0684
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e31faa46-caec-4ae6-2460-08daa8ca25ff
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8812

SGkgQW5kcmV3IGFuZCBKYXNvbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBG
cm9tOiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPg0KPiBTdWJqZWN0
OiBSZTogW1BBVENIXSBhcmdvOiBSZW1vdmUgcmVhY2hhYmxlIEFTU0VSVF9VTlJFQUNIQUJMRQ0K
PiANCj4gT24gMDcvMTAvMjAyMiAyMDozMSwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gPiBJIG9i
c2VydmVkIHRoaXMgQVNTRVJUX1VOUkVBQ0hBQkxFIGluIHBhcnRuZXJfcmluZ3NfcmVtb3ZlDQo+
IGNvbnNpc3RlbnRseQ0KPiA+IHRyaXAuICBJdCB3YXMgaW4gT3BlblhUIHdpdGggdGhlIHZpcHRh
YmxlcyBwYXRjaCBhcHBsaWVkLg0KPiA+DQo+ID4gZG9tMTAgc2h1dHMgZG93bi4NCj4gPiBkb203
IGlzIFJFSkVDVEVEIHNlbmRpbmcgdG8gZG9tMTAuDQo+ID4gZG9tNyBzaHV0cyBkb3duIGFuZCB0
aGlzIEFTU0VSVCB0cmlwcyBmb3IgZG9tMTAuDQo+ID4NCj4gPiBUaGUgYXJnb19zZW5kX2luZm8g
aGFzIGEgZG9taWQsIGJ1dCB0aGVyZSBpcyBubyByZWZjb3VudCB0YWtlbiBvbg0KPiA+IHRoZSBk
b21haW4uICBUaGVyZWZvcmUgaXQncyBub3QgYXBwcm9wcmlhdGUgdG8gQVNTRVJUIHRoYXQgdGhl
IGRvbWFpbg0KPiA+IGNhbiBiZSBsb29rZWQgdXAgdmlhIGRvbWlkLiAgUmVwbGFjZSB3aXRoIGEg
ZGVidWcgbWVzc2FnZS4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEphc29uIEFuZHJ5dWsgPGph
bmRyeXVrQGdtYWlsLmNvbT4NCj4gDQo+IFdlJ3JlIGludG8gdGhlIDQuMTcgcmVsZWFzZSBwcm9j
ZXNzIG5vdy7CoCBBIGJ1Z2ZpeCBsaWtlIHRoaXMgb2J2aW91c2x5DQo+IHNob3VsZCBiZSBjb25z
aWRlcmVkLCBidXQgd2lsbCBuZWVkIGFwcHJvdmFsIGZyb20gdGhlIHJlbGVhc2UgbWFuYWdlci4N
Cj4gQ0MgSGVucnkuDQoNCkFuZHJldzogVGhhbmtzIGZvciB0aGUgaW5mb3JtYXRpb24hDQoNCkph
c29uOiBXb3VsZCB5b3UgbWluZCBhZGRpbmcgYSAiRml4ZXM6IiB0YWcgZm9sbG93aW5nIHRoZSBy
dWxlIGRlc2NyaWJlZA0KaW4gWzFdPyBUaGFua3MgdmVyeSBtdWNoISBXaXRoIHRoaXMgdGFnIGFu
ZCBwcm9wZXIgcmV2aWV3L2FjayBmcm9tDQptYWludGFpbmVyczoNCg0KUmVsZWFzZS1hY2tlZC1i
eTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpbMV0gaHR0cHM6Ly94ZW5iaXRz
Lnhlbi5vcmcvZG9jcy91bnN0YWJsZS9wcm9jZXNzL3NlbmRpbmctcGF0Y2hlcy5odG1sI2ZpeGVz
DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IH5BbmRyZXcNCj4gDQo+ID4gLS0tDQo+
ID4gIHhlbi9jb21tb24vYXJnby5jIHwgMyArKy0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z
ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9jb21t
b24vYXJnby5jIGIveGVuL2NvbW1vbi9hcmdvLmMNCj4gPiBpbmRleCA3NDhiODcxNGQ2Li45NzNl
MWU5OTU2IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9jb21tb24vYXJnby5jDQo+ID4gKysrIGIveGVu
L2NvbW1vbi9hcmdvLmMNCj4gPiBAQCAtMTI5OCw3ICsxMjk4LDggQEAgcGFydG5lcl9yaW5nc19y
ZW1vdmUoc3RydWN0IGRvbWFpbiAqc3JjX2QpDQo+ID4gICAgICAgICAgICAgICAgICAgICAgQVNT
RVJUX1VOUkVBQ0hBQkxFKCk7DQo+ID4gICAgICAgICAgICAgIH0NCj4gPiAgICAgICAgICAgICAg
ZWxzZQ0KPiA+IC0gICAgICAgICAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+ID4gKyAg
ICAgICAgICAgICAgICBhcmdvX2RwcmludGsoIiVwZCBoYXMgZW50cnkgZm9yIHN0YWxlIHBhcnRu
ZXIgZG9taWQgJWRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3JjX2Qs
IHNlbmRfaW5mby0+aWQuZG9tYWluX2lkKTsNCj4gPg0KPiA+ICAgICAgICAgICAgICBpZiAoIGRz
dF9kICkNCj4gPiAgICAgICAgICAgICAgICAgIHJjdV91bmxvY2tfZG9tYWluKGRzdF9kKTsNCg0K


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 01:48:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 01:48:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418398.663208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogyx3-0000vp-8O; Sat, 08 Oct 2022 01:48:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418398.663208; Sat, 08 Oct 2022 01:48:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogyx3-0000vi-4Q; Sat, 08 Oct 2022 01:48:29 +0000
Received: by outflank-mailman (input) for mailman id 418398;
 Sat, 08 Oct 2022 01:48:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyx2-0000vY-DP; Sat, 08 Oct 2022 01:48:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyx2-0002y2-Af; Sat, 08 Oct 2022 01:48:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyx1-0003jV-Lj; Sat, 08 Oct 2022 01:48:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyx1-0001g3-Jq; Sat, 08 Oct 2022 01:48:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=E4WNPTqIsT91GpDopiRZBINuPpKEE01dTWX+ZRQwRjA=; b=S7k3hwhlXBUT++/RxFd+Tkxh71
	1fI+kX/0cZy5W8E08CVjCxxFqk1QWKviiAARicFaHaG7ioBMBVm/E/IZNSqKCH+3r88+QASBlPvFz
	LNaEV9r6zsYgtcVAGnZOBYGNCGoeQoBsSbS9zsn79emPg098cSuuAqrbqMYLzrzNtfNE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173459-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173459: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-examine:reboot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=66a5633aa038f4abb4455463755974febac69034
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 01:48:27 +0000

flight 173459 xen-unstable real [real]
flight 173464 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173459/
http://logs.test-lab.xenproject.org/osstest/logs/173464/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-examine      8 reboot              fail pass in 173464-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173452
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173452
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173452
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173452
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173452
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173452
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173452
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173452
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173452
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173452
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173452
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173452
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  66a5633aa038f4abb4455463755974febac69034

Last test of basis   173452  2022-10-07 01:54:41 Z    0 days
Testing same since   173459  2022-10-07 17:08:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   66a5633aa0..9029bc265c  9029bc265cdf2bd63376dde9fdd91db4ce9c0586 -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 01:49:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 01:49:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418405.663219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogyxq-0001Tt-Hp; Sat, 08 Oct 2022 01:49:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418405.663219; Sat, 08 Oct 2022 01:49:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogyxq-0001Tm-EE; Sat, 08 Oct 2022 01:49:18 +0000
Received: by outflank-mailman (input) for mailman id 418405;
 Sat, 08 Oct 2022 01:49:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyxp-0001Sr-7H; Sat, 08 Oct 2022 01:49:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyxp-0002ye-4R; Sat, 08 Oct 2022 01:49:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyxo-0003mI-Q9; Sat, 08 Oct 2022 01:49:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogyxo-00026G-Pe; Sat, 08 Oct 2022 01:49:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1VP1XJTiwYcNZtxJQmem8iNF1XSPQ4rzyCCGceL4xBo=; b=jp1eVJH2mpA74cIi9IEdh2PWyR
	aJlLbzFxLQ685qHehQCrhSszSPnIhEI+zgcda86b1AozlpmVk8LcO12PGT/fg/fVTPwQ+pzO2hIhM
	n/yYVHMbleovq11s5mJKxTESvN1olVEjnoxAV4JDDHFNO+6+hiJ8OHrcfFxxvxaPPImQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173463-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173463: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=406ad0582a3df7af498ec4f0adee1a95ceeae64f
X-Osstest-Versions-That:
    ovmf=5ff7d712d489a4fba4e8b0f609218e33c1208e52
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 01:49:16 +0000

flight 173463 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173463/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 406ad0582a3df7af498ec4f0adee1a95ceeae64f
baseline version:
 ovmf                 5ff7d712d489a4fba4e8b0f609218e33c1208e52

Last test of basis   173449  2022-10-06 17:40:27 Z    1 days
Testing same since   173463  2022-10-07 18:42:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   5ff7d712d4..406ad0582a  406ad0582a3df7af498ec4f0adee1a95ceeae64f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 02:47:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 02:47:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418424.663234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogzsJ-0008T3-Ru; Sat, 08 Oct 2022 02:47:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418424.663234; Sat, 08 Oct 2022 02:47:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ogzsJ-0008Sw-P7; Sat, 08 Oct 2022 02:47:39 +0000
Received: by outflank-mailman (input) for mailman id 418424;
 Sat, 08 Oct 2022 02:47:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogzsJ-0008Sm-3z; Sat, 08 Oct 2022 02:47:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogzsI-0004Vm-T5; Sat, 08 Oct 2022 02:47:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ogzsI-0006Mi-Hc; Sat, 08 Oct 2022 02:47:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ogzsI-0004Po-HA; Sat, 08 Oct 2022 02:47:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dBhzCPAvLvxOodj/PzWkdBNABTqAA3JEsHp5CFb4D4g=; b=kQn5ydbdzStpj0sKDUPCZ2smEQ
	SX5QSUplUIG9C9Y77lmjvrZ7YFKMvnb79iUz2xPf6YFJrlJzgXRzNkNyA86qQ2MqJI8uy9+CrhWAe
	SYQc21N2JUEg1+VZs9W8oEcfIGm0VUL7JAjpJVE04fcJ0pltRlFPPxYDdnHOclE1fTRs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173461-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173461: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=6e150d605c9e21dbe939875c13e82da33fb59ed0
X-Osstest-Versions-That:
    linux=f28b7414ab715e6069e72a7bbe2f1354b2524beb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 02:47:38 +0000

flight 173461 linux-5.4 real [real]
flight 173465 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173461/
http://logs.test-lab.xenproject.org/osstest/logs/173465/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-vhd      13 guest-start         fail pass in 173465-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 173465 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 173465 never pass
 test-armhf-armhf-xl-credit1  14 guest-start                  fail  like 173439
 test-armhf-armhf-xl-credit2  18 guest-start/debian.repeat    fail  like 173454
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173454
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat    fail like 173454
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173454
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173454
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173454
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173454
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173454
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173454
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173454
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173454
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173454
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173454
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173454
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                6e150d605c9e21dbe939875c13e82da33fb59ed0
baseline version:
 linux                f28b7414ab715e6069e72a7bbe2f1354b2524beb

Last test of basis   173454  2022-10-07 04:50:45 Z    0 days
Testing same since   173461  2022-10-07 17:40:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexandre Chartre <alexandre.chartre@oracle.com>
  Allen Pais <apais@linux.microsoft.com>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ben Hutchings <ben@decadent.org.uk>
  Borislav Petkov <bp@suse.de>
  Chandan Babu R <chandan.babu@oracle.com>
  Christoph Hellwig <hch@lst.de>
  Daniel Sneddon <daniel.sneddon@linux.intel.com>
  Darrick J. Wong <darrick.wong@oracle.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Hansen <dave.hansen@linux.intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Corbet <corbet@lwn.net>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Kees Cook <keescook@chromium.org>
  Kim Phillips <kim.phillips@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Mark Gross <mgross@linux.intel.com>
  Nathan Chancellor <nathan@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Sami Tolvanen <samitolvanen@google.com>
  Sean Christopherson <seanjc@google.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Slade Watkins <srw@sladewatkins.net>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Thomas Gleixner <tglx@linutronix.de>
  Uros Bizjak <ubizjak@gmail.com>
  YueHaibing <yuehaibing@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   f28b7414ab71..6e150d605c9e  6e150d605c9e21dbe939875c13e82da33fb59ed0 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 06:18:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 06:18:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418434.663246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh3AD-0005Dp-Vg; Sat, 08 Oct 2022 06:18:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418434.663246; Sat, 08 Oct 2022 06:18:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh3AD-0005Di-QN; Sat, 08 Oct 2022 06:18:21 +0000
Received: by outflank-mailman (input) for mailman id 418434;
 Sat, 08 Oct 2022 06:18:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh3AC-0005DY-2q; Sat, 08 Oct 2022 06:18:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh3AB-0000lF-W6; Sat, 08 Oct 2022 06:18:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh3AB-0001sc-Fa; Sat, 08 Oct 2022 06:18:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oh3AB-0006v3-F8; Sat, 08 Oct 2022 06:18:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6U86gp7GEfzxoHIRnsKF0boqBLUy7A59jueEPzDTD1A=; b=uR34gs+/xaAGU9WDRn33obbGKw
	Wd9sk6e8dbmiBDtckhDxHHazYZAWgj/Ov+ZTTIXHky3OCyQF5sRiCAltfvKhDN+Z5pbYcnhPrnJZv
	fq+Fzeg4am3nQF69V+LUXdpNunC5xhPeBAe8GsNkjlHxDxsz7vfWNFi0k18pJWztLcjc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173462-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173462: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-pair:debian-fixup/dst_host:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
X-Osstest-Versions-That:
    linux=4c86114194e644b6da9107d75910635c9e87179e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 06:18:19 +0000

flight 173462 linux-linus real [real]
flight 173467 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173462/
http://logs.test-lab.xenproject.org/osstest/logs/173467/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-pair      21 debian-fixup/dst_host fail pass in 173467-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173456
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173456
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173456
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173456
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173456
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173456
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173456
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173456
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78
baseline version:
 linux                4c86114194e644b6da9107d75910635c9e87179e

Last test of basis   173456  2022-10-07 08:23:54 Z    0 days
Testing same since   173462  2022-10-07 18:41:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Anuj Gupta <anuj20.g@samsung.com>
  Atte Heikkilä <atteh.mailbox@gmail.com>
  Bart Van Assche <bvanassche@acm.org>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christian Brauner <brauner@kernel.org>
  Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
  Christoph Hellwig <hch@lst.de>
  Coly Li <colyli@suse.de>
  Daniel Wagner <dwagner@suse.de>
  Dave Airlie <airlied@redhat.com>
  David Sloan <david.sloan@eideticom.com>
  David Sterba <dsterba@suse.com>
  Douglas Miller <dougmill@linux.vnet.ibm.com>
  dougmill@linux.vnet.ibm.com <dougmill@linux.vnet.ibm.com>
  Dylan Yudaken <dylany@fb.com>
  Fabio M. De Francesco <fmdefrancesco@gmail.com>
  Gao Xiang <hsiangkao@linux.alibaba.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Genjian Zhang <zhanggenjian@kylinos.cn>
  Geoff Levand <geoff@infradead.org>
  Guixin Liu <kanie@linux.alibaba.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Hannes Reinecke <hare@suse.de>
  Hugh Dickins <hughd@google.com>
  Hyunchul Lee <hyc.lee@gmail.com>
  Jack Wang <jinpu.wang@ionos.com>
  Jackie Liu <liuyun01@kylinos.cn>
  Jan Kara <jack@suse.cz>
  Jens Axboe <axboe@kernel.dk>
  Jiangshan Yi <yijiangshan@kylinos.cn>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jilin Yuan <yuanjilin@cdjrlc.com>
  Johannes Weiner <hannes@cmpxchg.org>
  Jules Maselbas <jmaselbas@kalray.eu>
  Kanchan Joshi <joshi.k@samsung.com>
  Keith Busch <kbusch@kernel.org>
  Li Jinlin <lijinlin3@huawei.com>
  Li Lei <lilei@szsandstone.com>
  Li zeming <zeming@nfschina.com>
  Lin Feng <linf@wangsu.com>
  Linjun Bao <meljbao@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Shixin <liushixin2@huawei.com>
  Liu Song <liusong@linux.alibaba.com>
  Logan Gunthorpe <logang@deltatee.com>
  Luca Boccassi <bluca@debian.org>
  Martin Belanger <martin.belanger@dell.com>
  Md Haris Iqbal <haris.iqbal@ionos.com>
  Miaohe Lin <linmiaohe@huawei.com>
  Mickaël Salaün <mic@digikod.net>
  Minghao Chi <chi.minghao@zte.com.cn>
  Mingzhe Zou <mingzhe.zou@easystack.cn>
  Namjae Jeon <linkinjeon@kernel.org>
  Pankaj Raghav <p.raghav@samsung.com>
  Paul Menzel <pmenzel@molgen.mpg.de>
  Pavel Begunkov <asml.silence@gmail.com>
  Ping-Xiang Chen <p.x.chen.1005@gmail.com>
  Ping-Xiang Chen <p.x.chen@uci.edu>
  Rishabh Bhatnagar <risbhat@amazon.com>
  Sagi Grimberg <sagi@grimberg.me>
  Santosh Pradhan <santosh.pradhan@ionos.com>
  Saurabh Sengar <ssengar@linux.microsoft.com>
  Shigeru Yoshida <syoshida@redhat.com>
  Song Liu <song@kernel.org>
  Stefan Haberland <sth@linux.ibm.com>
  Stefan Metzmacher <metze@samba.org>
  Steve French <stfrench@microsoft.com>
  Tejun Heo <tj@kernel.org>
  Tom Talpey <tom@talpey.com>
  Uros Bizjak <ubizjak@gmail.com>
  Varun Prakash <varun@chelsio.com>
  Wolfram Sang <wsa+renesas@sang-engineering.com>
  XU pengfei <xupengfei@nfschina.com>
  ye xingchen <ye.xingchen@zte.com.cn>
  Yu Kuai <yukuai3@huawei.com>
  Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhou nan <zhounan@nfschina.com>
  ZiyangZhang <ZiyangZhang@linux.alibaba.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        fail    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   4c86114194e6..9d84bb40bcb3  9d84bb40bcb30a7fa16f33baa967aeb9953dda78 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 08:10:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 08:10:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418447.663256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh4uh-0001Cv-H4; Sat, 08 Oct 2022 08:10:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418447.663256; Sat, 08 Oct 2022 08:10:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh4uh-0001Cn-CU; Sat, 08 Oct 2022 08:10:27 +0000
Received: by outflank-mailman (input) for mailman id 418447;
 Sat, 08 Oct 2022 08:10:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4ug-0001Cd-OO; Sat, 08 Oct 2022 08:10:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4ug-0003Vn-Ez; Sat, 08 Oct 2022 08:10:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4uf-00068I-JS; Sat, 08 Oct 2022 08:10:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4uf-0002TO-Iw; Sat, 08 Oct 2022 08:10:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vyyr4jAXWclA/aH2qCDNVJXHNNuGVC6jNlA09eZnAg0=; b=zYL5Wfx9YJL1BZ4XckNIhhXmSO
	IhV46H9t/ZxviZxfWxosZckgvM55v9PabT4HgGwrCK5g6IEpvgP0yrZypBLaAyl57i9w0FYseVAih
	Jx3xHP7+7sK+udInAKSOtnUaW74zbQvkq5/MwVCuvUC5zM0I2yJ59Z9qn+Zl3ALoARWg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173466-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173466: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-examine:reboot:fail:heisenbug
    xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 08:10:25 +0000

flight 173466 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173466/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-examine      8 reboot           fail in 173459 pass in 173466
 test-amd64-i386-migrupgrade  11 xen-install/dst_host       fail pass in 173459
 test-amd64-i386-qemuu-rhel6hvm-amd  7 xen-install          fail pass in 173459

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173459
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173459
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173459
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173459
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173459
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173459
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173459
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173459
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173459
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173459
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173459
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173459
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173466  2022-10-08 01:53:31 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 08:11:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 08:11:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418455.663267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh4vQ-0001mu-UI; Sat, 08 Oct 2022 08:11:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418455.663267; Sat, 08 Oct 2022 08:11:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh4vQ-0001mn-Rd; Sat, 08 Oct 2022 08:11:12 +0000
Received: by outflank-mailman (input) for mailman id 418455;
 Sat, 08 Oct 2022 08:11:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4vQ-0001md-6x; Sat, 08 Oct 2022 08:11:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4vQ-0003WR-6B; Sat, 08 Oct 2022 08:11:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4vP-0006Ag-Vk; Sat, 08 Oct 2022 08:11:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oh4vP-00036z-VJ; Sat, 08 Oct 2022 08:11:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WoYRAohcSzPtqQqHlMoaCasxjQkre8NzjEN2uFHR6wU=; b=nl6PSD9UgPax8vtKNH8gBthxUT
	9kM+xQRrKISv2LB904JFZsDc5qlG5zLrShXezfwCZ3sPEWok1ricDEr4D6Se+e5lfzX/QekjBLnOG
	vazmGYfRzLHvffmTPKFbh+2A4IgkYJkfTeHvJipWQzctImKyiEdQXkXRBAsnE+dawH/4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173469-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173469: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=a670f12a741a9511d9cedc7257d3693567f8fc43
X-Osstest-Versions-That:
    ovmf=406ad0582a3df7af498ec4f0adee1a95ceeae64f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 08:11:11 +0000

flight 173469 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173469/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 a670f12a741a9511d9cedc7257d3693567f8fc43
baseline version:
 ovmf                 406ad0582a3df7af498ec4f0adee1a95ceeae64f

Last test of basis   173463  2022-10-07 18:42:36 Z    0 days
Testing same since   173469  2022-10-08 06:11:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dun Tan <dun.tan@intel.com>
  Tan, Dun <dun.tan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   406ad0582a..a670f12a74  a670f12a741a9511d9cedc7257d3693567f8fc43 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 09:36:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 09:36:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418466.663278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh6Fi-000236-3s; Sat, 08 Oct 2022 09:36:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418466.663278; Sat, 08 Oct 2022 09:36:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh6Fi-00022z-0e; Sat, 08 Oct 2022 09:36:14 +0000
Received: by outflank-mailman (input) for mailman id 418466;
 Sat, 08 Oct 2022 09:36:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh6Fh-00022p-G9; Sat, 08 Oct 2022 09:36:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh6Fh-00059n-DF; Sat, 08 Oct 2022 09:36:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh6Fg-0002Kb-Uo; Sat, 08 Oct 2022 09:36:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oh6Fg-0001lI-UL; Sat, 08 Oct 2022 09:36:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4mE6QGjFbRc6F034eg6kxWYoo/B7+xS6+WjC0VDKpLY=; b=seY4cnVK0u/MRxwbFk4Tyy1QJQ
	GW5YROt+xCVVrD8Whl287fEvg5u7XAcN/HNQ4iF91XJfC8LjJ+4oIy91D7cQB18x0jUeuEwztUUy6
	t6fQZq6ksfk9S7rofTMw3pSw9nmtcml7/slYR9jMZm4pH9op2YZ6UnKeUIAjNbwA74Jg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173468-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173468: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=8ef8d9e21b10f62cad0c36a6ac2b57ac61acd0ec
X-Osstest-Versions-That:
    libvirt=491d918502e50bf15c75d183bb41e3c0de5a0e1b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 09:36:12 +0000

flight 173468 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173468/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173453
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173453
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173453
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              8ef8d9e21b10f62cad0c36a6ac2b57ac61acd0ec
baseline version:
 libvirt              491d918502e50bf15c75d183bb41e3c0de5a0e1b

Last test of basis   173453  2022-10-07 04:20:17 Z    1 days
Testing same since   173468  2022-10-08 04:18:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel P. Berrangé <berrange@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   491d918502..8ef8d9e21b  8ef8d9e21b10f62cad0c36a6ac2b57ac61acd0ec -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 10:51:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 10:51:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418474.663288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh7QO-0002U8-H5; Sat, 08 Oct 2022 10:51:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418474.663288; Sat, 08 Oct 2022 10:51:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh7QO-0002U1-EL; Sat, 08 Oct 2022 10:51:20 +0000
Received: by outflank-mailman (input) for mailman id 418474;
 Sat, 08 Oct 2022 10:51:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh7QN-0002Tr-1s; Sat, 08 Oct 2022 10:51:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh7QM-0006jm-U0; Sat, 08 Oct 2022 10:51:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh7QM-0004kA-Iq; Sat, 08 Oct 2022 10:51:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oh7QM-00075J-IS; Sat, 08 Oct 2022 10:51:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iMWsdncL3/F6vZQzu0OAd43E0rRhrwsvf991i0X3wQg=; b=oKcewxupota+lDduSd7cFRLVd7
	XcHf0i/X7TfG2NS2im5gxom7gITATJQHap8S5q+XG7UqrJSRLaz+XvGtwcB6qckGnsiF76ErPe6QZ
	BITKdbAEYt2pxn9jlLrsq8dFEcmk0kZMyr2aY4DXeDT3Jkl2VbBMyAENgECT5WSVKFGQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173471-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173471: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=4364d661685d4806b8fb66ff76eaece7ea6a4426
X-Osstest-Versions-That:
    ovmf=a670f12a741a9511d9cedc7257d3693567f8fc43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 10:51:18 +0000

flight 173471 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173471/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 4364d661685d4806b8fb66ff76eaece7ea6a4426
baseline version:
 ovmf                 a670f12a741a9511d9cedc7257d3693567f8fc43

Last test of basis   173469  2022-10-08 06:11:54 Z    0 days
Testing same since   173471  2022-10-08 08:41:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Zhihao Li <zhihao.li@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   a670f12a74..4364d66168  4364d661685d4806b8fb66ff76eaece7ea6a4426 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 11:08:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 11:08:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418483.663299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh7h0-0004E1-Ti; Sat, 08 Oct 2022 11:08:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418483.663299; Sat, 08 Oct 2022 11:08:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh7h0-0004Du-Ql; Sat, 08 Oct 2022 11:08:30 +0000
Received: by outflank-mailman (input) for mailman id 418483;
 Sat, 08 Oct 2022 11:08:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XqZC=2J=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1oh7gz-0004Do-P8
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 11:08:29 +0000
Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com
 [2a00:1450:4864:20::62e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 88d68202-46f9-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 13:08:28 +0200 (CEST)
Received: by mail-ej1-x62e.google.com with SMTP id q9so11565744ejd.0
 for <xen-devel@lists.xenproject.org>; Sat, 08 Oct 2022 04:08:27 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 m30-20020a17090677de00b00779cde476e4sm2627061ejn.62.2022.10.08.04.08.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 08 Oct 2022 04:08:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88d68202-46f9-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=zPZgg2KnD8Z7siPytxPxGEaqGU1Xq2bMtMqXe2XAWmg=;
        b=B1AWuiRwETAIVwO/fjjrTIH84Ti6hy4VAfEWe/YHtWmZuE1NIAopPN3V7M9lMJ2TzZ
         IuxTg7TcatqYM4JJp5rddRhXJ7wkzTpAiBfEmyL/wfnxZuteKGQoodfqdbMlwC0HbUNe
         gUMHhXo0nEXPu3+pAoPKs9z96PcL9tzDiW0+wYzAfhG7JLyta9IOT77fahhq1UMY5PM2
         0EhbjMrZ69HhbAC/pd/vudkReI1B/YF55AaQkvEWxAZQ8yrmO24RTqqIrPVDifjSAMZS
         2ki7XxLHJ8+olq4T6uH6wq8sRT7ouHFkPyWFF/Oyt5OcskhjsvmYz1kOPxK8/VIv+6Nu
         H17w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=zPZgg2KnD8Z7siPytxPxGEaqGU1Xq2bMtMqXe2XAWmg=;
        b=6TYStsREOU25DFHT+trYhlLW+8BGz0TmwT7Weh3IsDBvj7xctcqm9UMUQY9REtWQLD
         6ubuhYHKV2Z2bYSQhjeDDFc+wai6rZiDPV+DHigkvYDkvS/oAWnlEAyf5LXOapVh0Of7
         eZhZnzmaD/aG6Wt5GbNPvmTl9aOtl7pNWYWQu9Its65R64qCUOYylH7PqCFkMxnHVSTX
         iqRaKEF7ZVtRsS+Xa+NYJPUV+r+mIbvmkXibVzw51eIbhjmH7m/V71m+m5JNQ0Qc2TdT
         E04g2KjrbRNugtvm9S3lV1TOqWokxfplF0p9hTaKPXQPnIgbWpeEUo8Iko1ZORXSisb5
         1IRQ==
X-Gm-Message-State: ACrzQf1D/CJVE9ckn6oIOjdbuEmfHuRa+MVCt/koszoQumNTC02pnGcf
	pathvIgGddZrwyKzTsVIO9hixEqkRkxQcA==
X-Google-Smtp-Source: AMsMyM7/VoqHTVniuWj17yldk3O8VkznRZMOeEK4f+aulZOQhWkBG6yv3r/ch0RcU4jBrk76zzL4uA==
X-Received: by 2002:a17:907:728e:b0:782:8e91:64c8 with SMTP id dt14-20020a170907728e00b007828e9164c8mr7688796ejc.36.1665227307127;
        Sat, 08 Oct 2022 04:08:27 -0700 (PDT)
Message-ID: <6e33b687-8862-d208-a707-77a95c61525e@gmail.com>
Date: Sat, 8 Oct 2022 14:08:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221007132736.2275574-1-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221007132736.2275574-1-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/7/22 16:27, Oleksandr Tyshchenko wrote:

Hi Oleksandr

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Passed to xen_grant_dma_map_page() offset in the page
> can be > PAGE_SIZE even if the guest uses the same page granularity
> as Xen (4KB).
> 
> Before current patch, if such case happened we ended up providing
> grants for the whole region in xen_grant_dma_map_page() which
> was really unnecessary. The more, we ended up not releasing all
> grants which represented that region in xen_grant_dma_unmap_page().
> 
> Current patch updates the code to be able to deal with such cases.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> Depens on:
> https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/
> 
> Should go in only after that series.
> ---
>   drivers/xen/grant-dma-ops.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index c66f56d24013..1385f0e686fe 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -168,7 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   					 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned long dma_offset = offset_in_page(offset),
> +			gfn_offset = PFN_DOWN(offset);
> +	unsigned int i, n_pages = PFN_UP(dma_offset + size);

IIUC, the above with a later patch will become:

dma_offset = xen_offset_in_page(offset)
gfn_offset = XEN_PFN_DOWN(offset)
n_pages = XEN_PFN_UP(dma_offset + size)

>   	grant_ref_t grant;
>   	dma_addr_t dma_handle;
>   
> @@ -187,10 +189,10 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   
>   	for (i = 0; i < n_pages; i++) {
>   		gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
> -				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
> +				xen_page_to_gfn(page) + i + gfn_offset, dir == DMA_TO_DEVICE);

Here, why the pfn is not calculated before passing it to pfn_to_gfn()?
I mean sth like pfn_to_gfn(page_to_xen_pfn(page) + gfn_offset + i)

>   	}
>   
> -	dma_handle = grant_to_dma(grant) + offset;
> +	dma_handle = grant_to_dma(grant) + dma_offset;
>   
>   	return dma_handle;
>   }

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 12:50:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 12:50:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418499.663311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9Hm-0007G3-NW; Sat, 08 Oct 2022 12:50:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418499.663311; Sat, 08 Oct 2022 12:50:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9Hm-0007Fw-Kl; Sat, 08 Oct 2022 12:50:34 +0000
Received: by outflank-mailman (input) for mailman id 418499;
 Sat, 08 Oct 2022 12:50:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh9Hm-0007Fm-9L; Sat, 08 Oct 2022 12:50:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh9Hm-0000Wd-5O; Sat, 08 Oct 2022 12:50:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oh9Hl-0007dv-In; Sat, 08 Oct 2022 12:50:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oh9Hl-00034C-IQ; Sat, 08 Oct 2022 12:50:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=z/OqefhBPHTUNQ2E2L4lp7PGJHe7r9X1kNF+rmOIrTY=; b=YlENG/InuJ/t9bPCWT2yGUReXk
	etft2Yo3yD/qcTDBMGqH6HUzIywIU2Rq6VWnjoHU88swy/wLgmwYY+UmWvFXAvb/t0jeF2wkdo41E
	RV+vLxehRAYEDVF1VQGk2NY5eXt5MMBVfJeA82VqqWHv4fVlfIrB15uuc3zNb95ZRTZ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173470-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173470: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e8bc52cb8df80c31c73c726ab58ea9746e9ff734
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 12:50:33 +0000

flight 173470 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173470/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                e8bc52cb8df80c31c73c726ab58ea9746e9ff734
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    0 days
Testing same since   173470  2022-10-08 06:21:34 Z    0 days    1 attempts

------------------------------------------------------------
371 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 23278 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 12:52:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 12:52:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418506.663321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9JM-0007nV-3R; Sat, 08 Oct 2022 12:52:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418506.663321; Sat, 08 Oct 2022 12:52:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9JM-0007nO-0c; Sat, 08 Oct 2022 12:52:12 +0000
Received: by outflank-mailman (input) for mailman id 418506;
 Sat, 08 Oct 2022 12:52:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3uQB=2J=epam.com=prvs=22807980a5=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1oh9JL-0007nE-EF
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 12:52:11 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04964643-4708-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 14:52:09 +0200 (CEST)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 298911uO012561;
 Sat, 8 Oct 2022 12:52:04 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k31j68qbg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 08 Oct 2022 12:52:04 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM9PR03MB6866.eurprd03.prod.outlook.com (2603:10a6:20b:286::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 8 Oct
 2022 12:52:02 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Sat, 8 Oct 2022
 12:52:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04964643-4708-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EOaiaA7tLOwLS2SYknu2iPzAUN4E6tQORHyCSZRXw2RYvOHiwixqYaZPiGa4jYfgDosBKwB/uh77OsRAuZxLGbMZk6Y9f2/jWU4PElFjecN11sxTKpyo5prlF56wbk5KAypM+rH/J6Iq9LRNFIUt1pOKvo1o3ZwKgZFMcyxoEq7K1v2ai9b0b/v4aEPbkPEQPC/g7oqscxUVmJjGfoyZtPxj8t6heIBxfmAaYgnRktO2Vgf7NtVq90p+siN1huG61+JjaiWYIXIp/ZTILAMBrtsWGK4EGX7OHWFiHcPQqcYthXFu1PlIeABWpYJ96GInrrNRuDNDXn06ViTYdEpl7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ebOG11VqUSl46Rl8uhBp/KlV214XTtkqQQFSfMCps/g=;
 b=gHICtnPakGqiGvqG/BFg0jQlXJ6yMk5Az1me9NN6Tj6TJGcB4dCUzGiwfdg6pXTO6S1iWr/3TqBqChHPx3Bj8vzXdt6Tj2Sde1bxvMSF0HP692hVLfvO0NZjfWXpabdJEad4I966xnbTIk/QMpj4hKY1cVY1igcpzYgx89nCxg561cHfg7AQx72VpFkDKjygh26Dnkt445h5bGVVlYauqsGtNaKhzoHr2gsX0V762TfIwrpCo/WM6XVwnQo8F5AB5/+oEEOHQWrHgvE/gh/Lpx28ZInuBpr5Oex2dyEgMgZ9cdAjpJcn30J2JJdPMoJoYvu47IkUX1SoW5I+1TMgEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ebOG11VqUSl46Rl8uhBp/KlV214XTtkqQQFSfMCps/g=;
 b=qDcl3PRolhKQFLUqTg7bx1WoZvzGALNw8ManY+CkyJK/nu/Z0amwS17I2ngCaRYshpgAutX61v4N+Kx/WMIYwwEg3Sozjgp0K+ek8EvV5A36nfvcxprhh/+aMZGjMgrtQpMcH6ZEuIUsB/y8Unkh+tsS4uArgeNCAiFbO8iCJ3nQpvWzAZ8S1PlTP/FLlk6+TveLXwlOdpk5ukh0O4Csv9fRdpDFB2FGCSJUNETi1RmsIQ9HwvBG/RzPb/qWu1jmnCIhXIHy6m44ZvpfKCv3iq9Ms7+Oa6VAbfCmqDhihykmV2sIDZlQKziAj0Gq7WQ1PqZ8i2JlVl2WqKDC2YlAFw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Thread-Topic: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Thread-Index: AQHY2lCewf5wqMeDhkqfFwKHpttMBq4EV/CAgAAc7QA=
Date: Sat, 8 Oct 2022 12:52:01 +0000
Message-ID: <d6ec5092-8d93-22c2-7b6e-944ad88ad582@epam.com>
References: <20221007132736.2275574-1-olekstysh@gmail.com>
 <6e33b687-8862-d208-a707-77a95c61525e@gmail.com>
In-Reply-To: <6e33b687-8862-d208-a707-77a95c61525e@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AM9PR03MB6866:EE_
x-ms-office365-filtering-correlation-id: 449b4b5a-6d44-48dd-f8e3-08daa92be533
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 IYHIrF4EAk9BJno2t4meT1DuHODPQ8w3xQ6j1rqoIY82/i0xjeu0SHmguFW6Fd29cfUcPEmkIFeedyR5GiTN5fTAGX9IjpahejRw7hhhZPJ4kNGOEcgIeo2HVpvuefz8DaNfpTT1UCH5InTiQ63RtlCxI2Mi3Ey5NV3nzcIW6a51KtcM4HJ5+nvwPSLYCkFeDkzZ1Fo/43KiUAej9P0vjW8ihrr/fybfo5r9cIFDyvHXEAxmfr50VsCGKOU7PXlpKaw08uRGMnwFlZplIk3qOFTYo69cGBKGXQVyd6SsE0U1Ep2BRM7xpxYP3BjraHDeACsgmSg99VhH1OajG6Q+YXCTWJuy5RyT/4ZHGqmgiof8GKSNSP7lGL5StGvzL+NtUlVbJqPdITI+ANXRyF/g1c00COwZ2sTAx0OHC1kc7EPfF5KnCsH4suYwOIFBpVeGhG3+/jFfykDyKpbSVbi0GGIwlDiOq63HEAEbwS9mYe3IBmqgO6+W5cWNLB+IFujrkOObKglh9Zm8s5WdJhXLKrrZBSbXNiPcqiMltzj6W+eVBabZGlTPvfdgPx2aj9NDL0tFM2fyoMEbPs+moKEUJIQ9l48fANbDHD38B3+C0C2TiEhQqCNr2Bmtdq1erhbltnfIElErxeEVYvh0fnq/29lGmM/RmQncLNl0bBXmoZ7IzctRBHULbYYkNQSQRmfiGuwIJYQLMUtW0IsCgTkd04bX0dQBqUphA7pp1GFK0IFWBx4VQFgGe4UNub00uU76rQL8OAx5BklMkr+L/9KDnpmg4F+d5vPP/RsoZnxjL+40wFTvs1zR6MbO+9wv1zJt0cuY6MMESYcfeGiZlyapeg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(451199015)(86362001)(31696002)(36756003)(38070700005)(38100700002)(122000001)(91956017)(8676002)(4326008)(64756008)(66446008)(76116006)(66946007)(66556008)(66476007)(71200400001)(316002)(110136005)(54906003)(2906002)(41300700001)(8936002)(5660300002)(186003)(83380400001)(2616005)(6486002)(966005)(478600001)(6512007)(6506007)(26005)(55236004)(53546011)(66899015)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?U1g4Ulo0TjJvUW96RWF4ZHk0Nk5maXBvQktXSmQ1YjNYaXRIamhGOXg5UUJw?=
 =?utf-8?B?MU5mNHYrdzFaSERyaklucEh1c0pqVjk1Mi9pWkJCVGxUTWxpQ0htSUdIeDlw?=
 =?utf-8?B?TEprbE1ZNGloTmI1aCtWRjVmVUtaTVhqQ01ucllwQnovbXB0TTlta3dRZk9m?=
 =?utf-8?B?a0VVcEMzcE1LR3p5dUtrdmpUSXE1OEFNMS9JY1VJWGJweWpJUUFqbDM4b2pq?=
 =?utf-8?B?VDQyYkdaVVVuNUhkVUl2azZ0MncwZk1uSFdsb2RJem5STXE0VzlQb2hwRlJp?=
 =?utf-8?B?U1FNRXYxSmZlZUUyNWVVOXNHQlJWMk45YW51Z0ZJaURFY2pDcXZLWTVyYXZp?=
 =?utf-8?B?VE5XMHhUMkNSVzVzR1MyRHlIY3BSNERVd3VlYlBYaVN6NDNpUzZtNlhMUjZF?=
 =?utf-8?B?ekRLa1djQkJRNklxSUFOTDRkeDE5TGNSRE5lWXJwQ3dIME80SEJEbHFZZzVE?=
 =?utf-8?B?Q29oSGVLaUorYXNPanhtNW5lOFB0WGRRTit2cXkxQ0VVTld3SlNhK29qZXRh?=
 =?utf-8?B?MlNXZGF4OGhKeHBXTWloNGZvTzZtdGN5SXo5N00rWnc4a3EyU1Y5bHNPR2V5?=
 =?utf-8?B?NE5VL2xxb21Tc2N4czNxT0swY0NxU09iREt2OVh3b2QrMHVnRFVGYjdaSmVp?=
 =?utf-8?B?TlVyK3Vja1RMR1paK1NaUkFDV3BYT3k2Z1BMbmJGWGJYckhhdzJST2FxaXJF?=
 =?utf-8?B?dDRDSmNYQmZIS3RNUFBZUGFjQlFVNGNIMG4vdEl3dHRNWEt2MUdpQjY4d1cy?=
 =?utf-8?B?bHhTRDdpUXNDZkhrUkxXUE82T3ROaWFnc2FWQlhUdURzSmZrT0xoTUZxdThq?=
 =?utf-8?B?NmRSZHlCQlVKUkhnd2xScFZHNlBsYW9wUFMyYUtXSEpyaUJVcElHZ1VpcVpp?=
 =?utf-8?B?RkJtVWpVaS80VENTUmd0MGI1dGh2RFE4U25uZmJJSWo4bTltakxKNUU3dTBS?=
 =?utf-8?B?bktybkFhSG5ET2p1NXdzc2pFMFNIa09IN0E0UXA4WFpSd0VGNmZWdFFBUVlX?=
 =?utf-8?B?TnRMU1BmTXdVcjdSeTdsRVJNejBxMXEybEZ4MEtiaEQ1ZlNjajNRUkxDQk5W?=
 =?utf-8?B?ZlVmZEoreDMzb2Y5UGpyRWpVZVEzV0pIOHVrdW1zYkRqOEFlWTN1aWhFQTZI?=
 =?utf-8?B?aWVISUtKWWVGb0htdENCSVhtMzUzL1JoSmh6S2F6cnZITzhwdTZxaXlaRnZT?=
 =?utf-8?B?ZEdabUFTd3kraFR5VU5jS0VTS0J2SFZFMVBzTDFkdTRueCtGZlZBUnY3MW9p?=
 =?utf-8?B?RktuWEtVbFNrQjFvd2FYeXhmSy9oTWh5SzlWRnRLMXhOUmZxOVNoTEVCQTBS?=
 =?utf-8?B?UHpUOHpVM0htbEZHcEo5aFRyLzl5OG9wVTgyZk92eVYxdnVQSkRCdzV0UDhJ?=
 =?utf-8?B?T3Ftd0lNeks2WGtkOGlQZGE3YWFXUG94cGNCSCs4UzRFaE5vZG5abEVvNG8v?=
 =?utf-8?B?Um95cXRCbFdmOE1lRGpXemtnemN5VzhHRlFheXZFVmVhOER6RlFSTnF4RXN5?=
 =?utf-8?B?a2oyYWhWcDhQWnhETVNZQlZMMnRLVkRrUG1UQUdGUi94MXpLdURKRmxFKzJx?=
 =?utf-8?B?NWVDTEk4L1JYblRrM3RFWFpjRXJvSUNhV0xNMzZlY2lwSExaWEJuUlI1VC9p?=
 =?utf-8?B?T2pPUjVMN2hYQVVmL2Z3dzVWOFBROG5YSTZENDJMU1B5aWdJVnZRUTN2R1Zs?=
 =?utf-8?B?SjhkL2ZMdUV4UUQ2YytBUDU5dTlGQlBRY3lhV0RFWkNsUEZHUDVmYXQ1TXJC?=
 =?utf-8?B?bHpFaTN1WUdqbkdCeUJqTDlqWFlwZ0t6YnJBaUxVV0hVTGViRHNKSW1qelY4?=
 =?utf-8?B?U1EySGs0cktuQ1VwclNoQkdwcmNoTWJzS3U1Zis0K1gxNWg1WmE4SERKZ0xR?=
 =?utf-8?B?RzZlZXEvOU9kZkhTOHZhbXV1QkhhYUd3eGZBK0VvRlA0N1gvVlNZZEs0ZUxr?=
 =?utf-8?B?cnUwNXJ0TGtkVnRRV1E3c3Q0ZnRrL2QwTVFqQjJ4M0Ztd1JIVmJtRXlvSEdU?=
 =?utf-8?B?TGRUSy9TNkM0NXQ5OFI4Q2NJdGtEdGxNQk5pWnJST1RROGtjNE9xdStqMGxI?=
 =?utf-8?B?YzY4ekhYZXNWc3VqVWxHUGEyOGhkV3ZOVW50ek8vOFZKQnUxSVZ2Vy9yd0RK?=
 =?utf-8?B?ak94K3ZzOUg2eEV4L3RWc0FjaW1PdisrdTJkOE9za2JhMWxuTnMvVjBvZTY0?=
 =?utf-8?Q?jvYHWYZ/bFqlrv0IQhl85TQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <81926CB25B1D1E49BF38265666E59273@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 449b4b5a-6d44-48dd-f8e3-08daa92be533
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2022 12:52:01.9954
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IXMZYSgfW8wvUpk0y86xUGCPcmJ5k87aq7y72DeZqXJzeefYBhjiQFRP7GN/f2wiUGKvaHA4Uia4u09TgiuaGDtBadlf2xu4UuhCnV1NDy8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6866
X-Proofpoint-GUID: mpIPI5_NwG7Xx1NvbU1U1gva-l2aaEad
X-Proofpoint-ORIG-GUID: mpIPI5_NwG7Xx1NvbU1U1gva-l2aaEad
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 lowpriorityscore=0 mlxlogscore=999 spamscore=0 malwarescore=0
 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0
 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210080081

DQpPbiAwOC4xMC4yMiAxNDowOCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KSGVsbG8gWGVu
aWENCg0KPg0KPiBPbiAxMC83LzIyIDE2OjI3LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4NCj4gSGkgT2xla3NhbmRyDQo+DQo+PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xl
a3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gUGFzc2VkIHRvIHhlbl9ncmFudF9k
bWFfbWFwX3BhZ2UoKSBvZmZzZXQgaW4gdGhlIHBhZ2UNCj4+IGNhbiBiZSA+IFBBR0VfU0laRSBl
dmVuIGlmIHRoZSBndWVzdCB1c2VzIHRoZSBzYW1lIHBhZ2UgZ3JhbnVsYXJpdHkNCj4+IGFzIFhl
biAoNEtCKS4NCj4+DQo+PiBCZWZvcmUgY3VycmVudCBwYXRjaCwgaWYgc3VjaCBjYXNlIGhhcHBl
bmVkIHdlIGVuZGVkIHVwIHByb3ZpZGluZw0KPj4gZ3JhbnRzIGZvciB0aGUgd2hvbGUgcmVnaW9u
IGluIHhlbl9ncmFudF9kbWFfbWFwX3BhZ2UoKSB3aGljaA0KPj4gd2FzIHJlYWxseSB1bm5lY2Vz
c2FyeS4gVGhlIG1vcmUsIHdlIGVuZGVkIHVwIG5vdCByZWxlYXNpbmcgYWxsDQo+PiBncmFudHMg
d2hpY2ggcmVwcmVzZW50ZWQgdGhhdCByZWdpb24gaW4geGVuX2dyYW50X2RtYV91bm1hcF9wYWdl
KCkuDQo+Pg0KPj4gQ3VycmVudCBwYXRjaCB1cGRhdGVzIHRoZSBjb2RlIHRvIGJlIGFibGUgdG8g
ZGVhbCB3aXRoIHN1Y2ggY2FzZXMuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5
c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gLS0tDQo+PiBDYzog
SnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4gQ2M6IFhlbmlhIFJhZ2lhZGFrb3Ug
PGJ1cnphbG9kb3dhQGdtYWlsLmNvbT4NCj4+DQo+PiBEZXBlbnMgb246DQo+PiBodHRwczovL3Vy
bGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIx
MDA1MTc0ODIzLjE4MDA3NjEtMS1vbGVrc3R5c2hAZ21haWwuY29tL19fOyEhR0ZfMjlkYmNRSVVC
UEEheG5rTmFLcGZaNExzc1FKY0pzX0o5MUtFUlpLTVAyUmQteEVkQnFYTlhKOEd5Q1hKMGdrUmVy
MWVsVllmeE9XdHdOX0ZPbDl0VmllRFdsZk4tVVphSFFzeUxNaEEkIA0KPj4gW2xvcmVbLl1rZXJu
ZWxbLl1vcmddDQo+Pg0KPj4gU2hvdWxkIGdvIGluIG9ubHkgYWZ0ZXIgdGhhdCBzZXJpZXMuDQo+
PiAtLS0NCj4+IMKgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyB8IDggKysrKystLS0NCj4+
IMKgIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+Pg0K
Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBiL2RyaXZlcnMveGVu
L2dyYW50LWRtYS1vcHMuYw0KPj4gaW5kZXggYzY2ZjU2ZDI0MDEzLi4xMzg1ZjBlNjg2ZmUgMTAw
NjQ0DQo+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+ICsrKyBiL2RyaXZl
cnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4gQEAgLTE2OCw3ICsxNjgsOSBAQCBzdGF0aWMgZG1h
X2FkZHJfdCB4ZW5fZ3JhbnRfZG1hX21hcF9wYWdlKHN0cnVjdCANCj4+IGRldmljZSAqZGV2LCBz
dHJ1Y3QgcGFnZSAqcGFnZSwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgYXR0cnMpDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHN0
cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+PiAtwqDCoMKgIHVuc2lnbmVkIGludCBp
LCBuX3BhZ2VzID0gUEZOX1VQKG9mZnNldCArIHNpemUpOw0KPj4gK8KgwqDCoCB1bnNpZ25lZCBs
b25nIGRtYV9vZmZzZXQgPSBvZmZzZXRfaW5fcGFnZShvZmZzZXQpLA0KPj4gK8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgZ2ZuX29mZnNldCA9IFBGTl9ET1dOKG9mZnNldCk7DQo+PiArwqDCoMKgIHVu
c2lnbmVkIGludCBpLCBuX3BhZ2VzID0gUEZOX1VQKGRtYV9vZmZzZXQgKyBzaXplKTsNCj4NCj4g
SUlVQywgdGhlIGFib3ZlIHdpdGggYSBsYXRlciBwYXRjaCB3aWxsIGJlY29tZToNCj4NCj4gZG1h
X29mZnNldCA9IHhlbl9vZmZzZXRfaW5fcGFnZShvZmZzZXQpDQo+IGdmbl9vZmZzZXQgPSBYRU5f
UEZOX0RPV04ob2Zmc2V0KQ0KPiBuX3BhZ2VzID0gWEVOX1BGTl9VUChkbWFfb2Zmc2V0ICsgc2l6
ZSkNCg0KDQpJZiBzYXlpbmcgImxhdGVyIiBwYXRjaCB5b3UgbWVhbnQgInhlbi92aXJ0aW86IENv
bnZlcnQgDQpQQUdFX1NJWkUvUEFHRV9TSElGVC9QRk5fVVAgdG8gWGVuIGNvdW50ZXJwYXJ0cyIg
dGhlbiB5ZXMsIGV4YWN0bHkuDQoNCg0KPg0KPg0KPj4gwqDCoMKgwqDCoCBncmFudF9yZWZfdCBn
cmFudDsNCj4+IMKgwqDCoMKgwqAgZG1hX2FkZHJfdCBkbWFfaGFuZGxlOw0KPj4gwqAgQEAgLTE4
NywxMCArMTg5LDEwIEBAIHN0YXRpYyBkbWFfYWRkcl90IA0KPj4geGVuX2dyYW50X2RtYV9tYXBf
cGFnZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBwYWdlICpwYWdlLA0KPj4gwqAgwqDCoMKg
wqDCoCBmb3IgKGkgPSAwOyBpIDwgbl9wYWdlczsgaSsrKSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKg
wqAgZ250dGFiX2dyYW50X2ZvcmVpZ25fYWNjZXNzX3JlZihncmFudCArIGksIA0KPj4gZGF0YS0+
YmFja2VuZF9kb21pZCwNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuX3Bh
Z2VfdG9fZ2ZuKHBhZ2UpICsgaSwgZGlyID09IERNQV9UT19ERVZJQ0UpOw0KPj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fcGFnZV90b19nZm4ocGFnZSkgKyBpICsgZ2ZuX29m
ZnNldCwgZGlyID09IA0KPj4gRE1BX1RPX0RFVklDRSk7DQo+DQo+IEhlcmUsIHdoeSB0aGUgcGZu
IGlzIG5vdCBjYWxjdWxhdGVkIGJlZm9yZSBwYXNzaW5nIGl0IHRvIHBmbl90b19nZm4oKT8NCj4g
SSBtZWFuIHN0aCBsaWtlIHBmbl90b19nZm4ocGFnZV90b194ZW5fcGZuKHBhZ2UpICsgZ2ZuX29m
ZnNldCArIGkpDQoNClRoZSBnZm5fb2Zmc2V0IGlzIGp1c3QgYSBjb25zdCB2YWx1ZSBoZXJlLCB3
aGljaCBqdXN0IG1lYW5zIGhvdyBtYW55IA0KZ2ZucyB3ZSBzaG91bGQgc2tpcC4gQnV0IC4uLg0K
DQouLi4gSSB0aGluaywgSSBnZXQgeW91ciBwb2ludC4gU28sIGlmIHRoZSByZWdpb24gd2hpY2gg
aXMgY29udGlndW91cyBpbiANCnBmbiBtaWdodCBiZSBub24tY29udGlndW91cyBpbiBnZm4gKHdo
aWNoIHNlZW1zIHRvIGJlIHRoZSBjYXNlIGZvciB4ODYncyANClBWLCBidXQgSSBtYXkgbWlzdGFr
ZSkgd2Ugc2hvdWxkIGluZGVlZCB1c2Ugb3Blbi1jb2RlZA0KDQpjb25zdHJ1Y3Rpb24gInBmbl90
b19nZm4ocGFnZV90b194ZW5fcGZuKHBhZ2UpICsgZ2ZuX29mZnNldCArIGkpIi7CoCBBbmQgDQp0
aGUgZ2ZuX29mZnNldCBzaG91bGQgYmUgcmVuYW1lZCB0byBwZm5fb2Zmc2V0IHRoZW4uDQoNCg0K
Q29ycmVjdD8NCg0KDQpUaGFua3MuDQoNCg0KPg0KPj4gwqDCoMKgwqDCoCB9DQo+PiDCoCAtwqDC
oMKgIGRtYV9oYW5kbGUgPSBncmFudF90b19kbWEoZ3JhbnQpICsgb2Zmc2V0Ow0KPj4gK8KgwqDC
oCBkbWFfaGFuZGxlID0gZ3JhbnRfdG9fZG1hKGdyYW50KSArIGRtYV9vZmZzZXQ7DQo+PiDCoCDC
oMKgwqDCoMKgIHJldHVybiBkbWFfaGFuZGxlOw0KPj4gwqAgfQ0KPg0KLS0gDQpSZWdhcmRzLA0K
DQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 12:59:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 12:59:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418516.663332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9Qg-0000Ew-VQ; Sat, 08 Oct 2022 12:59:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418516.663332; Sat, 08 Oct 2022 12:59:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9Qg-0000Ep-Sm; Sat, 08 Oct 2022 12:59:46 +0000
Received: by outflank-mailman (input) for mailman id 418516;
 Sat, 08 Oct 2022 12:59:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XqZC=2J=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1oh9Qf-0000Ej-LM
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 12:59:45 +0000
Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com
 [2a00:1450:4864:20::631])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1493b0c2-4709-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 14:59:44 +0200 (CEST)
Received: by mail-ej1-x631.google.com with SMTP id nb11so16466986ejc.5
 for <xen-devel@lists.xenproject.org>; Sat, 08 Oct 2022 05:59:44 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 bx10-20020a0564020b4a00b00456cbd8c65bsm3458103edb.6.2022.10.08.05.59.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 08 Oct 2022 05:59:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1493b0c2-4709-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=xfjlFhbPvAiZaDtCTy2aYvhAArjEPm1WFxaHbT8nyHI=;
        b=cSRqO2nAuD4hdK6rSHRMxiXIlZRmuejx2sU72K+cUUQ7e/Ity03/COx2Z1qjYGRr+7
         5ZBvfphK2rxoxH1V+AHKvVGZYWivc4x6oa/DKTZ5RboqAd5Bn71/D9SE/EcuHqIjKn91
         OhBAWL4hS4AHYSYzCb4ZEiCWnfxDyhm/AgSatPGnu3Tb14g08odyUU+elq1/ErUpGaaE
         4uKZCESNwtyWWnqoOFrYOygojUVr3a6/qHquBeNmrC8rHlW5vFuPnxyq//ZJvggewhcZ
         HIMtdMYlvIiTSpqiMiQ5ItFJQ7kzkIpEs+s5jAvtGsp821Tu49wHdhRS3zw2IHDq8Dnb
         XOjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=xfjlFhbPvAiZaDtCTy2aYvhAArjEPm1WFxaHbT8nyHI=;
        b=K/1Ny87SZwmGOOHGxxkkfwkz9aNZlWPo0BZeL3ybxg2vqo2WTh8naH6E1BrdEBPBTg
         55gjo+3uUAPzGaOPppFeYvOnkrhjScyhESSl6UxvFLA615EscG35ROuXtHroD2r9W60q
         5PefDGXHf+6xpsDJvajO3g9ttWsQkl2dyIVJkxm70Tx0v0eYZIPRuQGVB4L43fHNN99L
         s7niUe9iJXVeU1HEMRCcaU0dz7yh1rvc8IHkaszAchXHfjB6YhSnBQflAsRm5JfiaQGr
         w6GP0OsXQLJZS264AK61t0Nykn/B54a63z/MSfJfWz6kjd5lqgcKPtyng0tOgge+lHHR
         CKvA==
X-Gm-Message-State: ACrzQf0biiy7TnHku1x0A066BwilYhxb6BwkOP8z80HoxDwlyN7gTeVd
	mjuWxxO8LVYHGDJKZzn3Umk=
X-Google-Smtp-Source: AMsMyM7oiakATrF7MhnyVQEC0+Xhi6onoKuUCwkbFQlI+p1wkIG2VNiKLh4wCbA0UAEsWU0CM7UjhQ==
X-Received: by 2002:a17:907:760f:b0:78c:336b:d8bd with SMTP id jx15-20020a170907760f00b0078c336bd8bdmr7340909ejc.685.1665233984014;
        Sat, 08 Oct 2022 05:59:44 -0700 (PDT)
Message-ID: <cb6e650f-d8ad-037d-8c35-8a786650b02f@gmail.com>
Date: Sat, 8 Oct 2022 15:59:41 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221007132736.2275574-1-olekstysh@gmail.com>
 <6e33b687-8862-d208-a707-77a95c61525e@gmail.com>
 <d6ec5092-8d93-22c2-7b6e-944ad88ad582@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <d6ec5092-8d93-22c2-7b6e-944ad88ad582@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10/8/22 15:52, Oleksandr Tyshchenko wrote:
> 
> On 08.10.22 14:08, Xenia Ragiadakou wrote:
> 
> Hello Xenia
> 
>>
>> On 10/7/22 16:27, Oleksandr Tyshchenko wrote:
>>
>> Hi Oleksandr
>>
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> Passed to xen_grant_dma_map_page() offset in the page
>>> can be > PAGE_SIZE even if the guest uses the same page granularity
>>> as Xen (4KB).
>>>
>>> Before current patch, if such case happened we ended up providing
>>> grants for the whole region in xen_grant_dma_map_page() which
>>> was really unnecessary. The more, we ended up not releasing all
>>> grants which represented that region in xen_grant_dma_unmap_page().
>>>
>>> Current patch updates the code to be able to deal with such cases.
>>>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>> ---
>>> Cc: Juergen Gross <jgross@suse.com>
>>> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
>>>
>>> Depens on:
>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!xnkNaKpfZ4LssQJcJs_J91KERZKMP2Rd-xEdBqXNXJ8GyCXJ0gkRer1elVYfxOWtwN_FOl9tVieDWlfN-UZaHQsyLMhA$
>>> [lore[.]kernel[.]org]
>>>
>>> Should go in only after that series.
>>> ---
>>>    drivers/xen/grant-dma-ops.c | 8 +++++---
>>>    1 file changed, 5 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>>> index c66f56d24013..1385f0e686fe 100644
>>> --- a/drivers/xen/grant-dma-ops.c
>>> +++ b/drivers/xen/grant-dma-ops.c
>>> @@ -168,7 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct
>>> device *dev, struct page *page,
>>>                         unsigned long attrs)
>>>    {
>>>        struct xen_grant_dma_data *data;
>>> -    unsigned int i, n_pages = PFN_UP(offset + size);
>>> +    unsigned long dma_offset = offset_in_page(offset),
>>> +            gfn_offset = PFN_DOWN(offset);
>>> +    unsigned int i, n_pages = PFN_UP(dma_offset + size);
>>
>> IIUC, the above with a later patch will become:
>>
>> dma_offset = xen_offset_in_page(offset)
>> gfn_offset = XEN_PFN_DOWN(offset)
>> n_pages = XEN_PFN_UP(dma_offset + size)
> 
> 
> If saying "later" patch you meant "xen/virtio: Convert
> PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen counterparts" then yes, exactly.

Ah ok, I see.

>>
>>
>>>        grant_ref_t grant;
>>>        dma_addr_t dma_handle;
>>>    @@ -187,10 +189,10 @@ static dma_addr_t
>>> xen_grant_dma_map_page(struct device *dev, struct page *page,
>>>          for (i = 0; i < n_pages; i++) {
>>>            gnttab_grant_foreign_access_ref(grant + i,
>>> data->backend_domid,
>>> -                xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
>>> +                xen_page_to_gfn(page) + i + gfn_offset, dir ==
>>> DMA_TO_DEVICE);
>>
>> Here, why the pfn is not calculated before passing it to pfn_to_gfn()?
>> I mean sth like pfn_to_gfn(page_to_xen_pfn(page) + gfn_offset + i)
> 
> The gfn_offset is just a const value here, which just means how many
> gfns we should skip. But ...
> 
> ... I think, I get your point. So, if the region which is contiguous in
> pfn might be non-contiguous in gfn (which seems to be the case for x86's
> PV, but I may mistake) we should indeed use open-coded
> 
> construction "pfn_to_gfn(page_to_xen_pfn(page) + gfn_offset + i)".  And
> the gfn_offset should be renamed to pfn_offset then.
> 
> 
> Correct?

Yes, that 's what I had in mind unless I 'm missing sth.

>>
>>>        }
>>>    -    dma_handle = grant_to_dma(grant) + offset;
>>> +    dma_handle = grant_to_dma(grant) + dma_offset;
>>>          return dma_handle;
>>>    }
>>

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 13:22:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 13:22:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418523.663344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9m9-0003cM-P2; Sat, 08 Oct 2022 13:21:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418523.663344; Sat, 08 Oct 2022 13:21:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oh9m9-0003cF-MK; Sat, 08 Oct 2022 13:21:57 +0000
Received: by outflank-mailman (input) for mailman id 418523;
 Sat, 08 Oct 2022 13:21:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3uQB=2J=epam.com=prvs=22807980a5=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1oh9m8-0003c9-A5
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 13:21:56 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c76411d-470c-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 15:21:54 +0200 (CEST)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2989h9QN027439;
 Sat, 8 Oct 2022 13:21:49 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k32k58q6n-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 08 Oct 2022 13:21:48 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS1PR03MB8192.eurprd03.prod.outlook.com (2603:10a6:20b:483::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 8 Oct
 2022 13:21:44 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5676.038; Sat, 8 Oct 2022
 13:21:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c76411d-470c-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H9+QBfVhD+7J/FssQFg/sq7W9OwULWjtTX5vW7PRWTS4uzEfCe80oGx0b+0huKgDWgeCCMIsdBxd2QbMC0N7CLbXXnKK1aJmhgyBkE97lrzpDtxCFJ/BXQFrXiybIjipr9xkbkpiRR/LECV/cklE5WF9mZFF2jt1MAYe4T57XSmQOHzqAzVl9e41p0dDRFcOLLz10mxWEkSWiwy7x0vt8jdus4vmTDcZis1pow+9rFuej3wnSZC9xNuqo16loHYlwujBBhfNGlNmkTMl6DPWeUt9AVaD2ENS90vRkBJWEjLyB4AoTlX+DichO5Sl60huV/7dj7HH4LJVs9578Gegzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b/klni/RAQWHxR2tnxUhtEL4A/iXWkUQqH1vnYdMMXU=;
 b=C7GGcx4BDK30tJgUVtPR1x4Pn/YFRczh6MnuzwMfcNDrVgxocWwVZmGhmTtCTJAB+4rgoN0iCmNK4OnpCC7Vr8DlthoUJeJRmWLXS2OQpC+oe6qlC7LPrKWhF09KIzHbavb6qc1KOiI8ifjfNEuqaYE6UzNZ88yF3fsresAmjGoNI4HsctyLrd9dNRlxfiEQAvbCEudZ1BDcN0qWIWhc8IbEN983r0oNznyWO9awowXO7JxOsbNv8AMePnReOdPkmn2hFIT75tW578Lb2ZowHR0vJsZ1SPUIYnUZ3AWKQJds0EJrqJAKBJiZcssvaMazvQAPCazOSOwCAVjLSQq/Hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b/klni/RAQWHxR2tnxUhtEL4A/iXWkUQqH1vnYdMMXU=;
 b=THF75VJtNCKFsYGc6Jmes5Mpkhkho4moGK+dOdBQ5zDQq79IEZGDntEOMWYkYNGtnwyRRYoCv3vMqLpNND415YBroswjK4ueVzSIpalAoR1SIjxwnWsbEIKcOTVVWQg5WEfkkfrDeTdyi0+AFcBEc9YLikgC+vlrWKPcCybfgfj3OVk3J4HwmTYcvRHbpDBLvb8OBngTtJHH+6um0147oU6XC1bbJFj5e+uEH5J9kEXxGQblcE/liGgMeU4kL8fpugREml54UemEl80S4hslGt/Tq42gjXTc3IZNkC25I4pOTN+mwHoz0U8XCvhqE+KSmGHK/gE1TwO5Ofz/HWK/zQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Thread-Topic: [PATCH] xen/virtio: Handle cases when page offset > PAGE_SIZE
 properly
Thread-Index: AQHY2lCewf5wqMeDhkqfFwKHpttMBq4EV/CAgAAc7QCAAAIqgIAABikA
Date: Sat, 8 Oct 2022 13:21:44 +0000
Message-ID: <e5cbc60c-a3df-87b2-0e7c-a1f69269a06d@epam.com>
References: <20221007132736.2275574-1-olekstysh@gmail.com>
 <6e33b687-8862-d208-a707-77a95c61525e@gmail.com>
 <d6ec5092-8d93-22c2-7b6e-944ad88ad582@epam.com>
 <cb6e650f-d8ad-037d-8c35-8a786650b02f@gmail.com>
In-Reply-To: <cb6e650f-d8ad-037d-8c35-8a786650b02f@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS1PR03MB8192:EE_
x-ms-office365-filtering-correlation-id: d00cf335-9a42-43e6-c8b9-08daa9300bb5
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 DzkPEnkN5obJ1ZCKlzzirDX04xEpgxAysw/69WzUadkoXLgsw+0vYxGO4lRv/3SxugCxy8Qrs/uXJUTLMuh4UH1hN4B49ftM7cdGrwDs0rtVIpH3ytRY41J5KM9s97rkaZzFA7k1C8LHMydmhuQ/7hzlo0fPMgq9YRFTN40F8iQIx/2yHWHA6Fh61xeghCY/WNMNtuDY5t7x7iJj/DNIdAJjE9UmiRLW4U/WMKeN2JvUgebt6Ty/qXlGTCnSGJYBQ9EXqsExEAmEvkuAllDKudHRiIsH/ibkbKdkkPelGZ2mxh3+AChw2Zb8ZUgJZPo9f3wDwGEkXcwrUmJ19zLwT+skgPRLY8JylcrP4yWy2iRU4hMq3iKmIFX8c1CmC7gdfm667+JC0HXts09l7IUWA5W4eqPGRjMYPFPXEEycAPKQJQxVc2AzY4IuXmz7dlvS9nI3XsY0aLyWBV9tHJ9waXQTI3YgcatYtSsdAlNZMuYDZgiYuNYB61B3DwAX0DWi42ooobGvNV7THqkqA+ADsvbMkmVq7pI2H6RUFlKCmHULLZFNt8BbtYpqNDYiX8mHkFXGQWPb/9XqcEg752UdbPdisZXuyCcYBKX/CqxpmuLjTXhtroDjNt1UXXgz1OgJMx2CcvdeFavNeLHON9CUXhJpMGMod41+aMrlMUjlBbbYlT2oQJyjsE3cQehqi8BHyX6aaTBShFpb/ppcssIhpR6RQV6RUM6zENZWzQZ9W1Cu+7VQ9Weiw8VHyBK3lZ+zUI0l2F9k3qmdsLnK5QZ5Liw1QHIK3/TLth2IBz1HHTUwzFaTc/Xf8wr8g4vechsDm+1mqubWdXJVLqdOMq1q/w==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(31686004)(66899015)(83380400001)(36756003)(55236004)(53546011)(6512007)(6506007)(122000001)(2906002)(26005)(31696002)(110136005)(54906003)(4326008)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(8676002)(8936002)(186003)(2616005)(41300700001)(478600001)(6486002)(966005)(86362001)(38070700005)(91956017)(316002)(5660300002)(71200400001)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?Rmw3SjR5VFhaNFB4NTZmNEN6NDB3eUtEclYycnhCMFg4QzA3bndpM2s5S2dF?=
 =?utf-8?B?WGZoMkRJVnBldFRKckR2NThUeERmYVJKK2xFTG5ib2VlNzRUOHVWZDUzU2ND?=
 =?utf-8?B?NnBDb2QyYmRUR3ZEaWZHZFA1RlZpT3dnUTRRTTNGNWwyc3k2LzAwYkpPUEFT?=
 =?utf-8?B?YTVoRFJzV1hEOEJ0MmxNeURhTWg5VGFtR24xcUkvMDRjcHAxWjFPTEV0SUNX?=
 =?utf-8?B?RWcvSk11Z2lFS2NtYzFGV0QrWTA5cjFQZXA3b1dSNzFnL2gydVNIQVRvaEt0?=
 =?utf-8?B?aHE5eGlHcDl1V2VrcE1HMml1eUE1cllvSENnSzF2UUZMcXpBRlg1U1AwamdL?=
 =?utf-8?B?SjNoRDFFb2JQZnZrcGtka2lmbllUMHB0anVlVjFFS0pqK3RnQ1IveG4zOXVV?=
 =?utf-8?B?TjMwVG5hTFNLaVJpay9KVkd1N3Vxck9CeFQyUVBIVURmVkNwYmVVZWlIeUhM?=
 =?utf-8?B?THB2Q1BQYzY2RGV5SSs2SFllejFpMHRsbkRHdDQvS1QxdnlZMG9Md29MVkFO?=
 =?utf-8?B?NWpCSklaU0xqSVZ2WlYvOTdWdTBDc3NheDV5Zi92STZ0QzQrK01NMkdmaUhI?=
 =?utf-8?B?V1VZaTlnMEpsUm1sSW1sVFFRVTEzVXdOdXRFZVdyRkgyeHV2dWVLbDRQeU9j?=
 =?utf-8?B?VUdsRkZaa3NKK3BYOC94OHQweWZFNWd1NVdnZUJqK0Z2aWF6dDJicFd4aktG?=
 =?utf-8?B?cDhTVFNoZTRheFNzcmdCZnpoMkJqVVAxQnlBQ01UYjdqTFZXckwwY3ltVGZ0?=
 =?utf-8?B?VnBUb1lHWnJxSHFKSEplYU1XTzNWbWN6dnJJR2lpZE4vblZIcXhSNS93a2gr?=
 =?utf-8?B?N2tjTXo2ZmdkVC80ei9KbWZxakRvK1Z2di9OdmtwYkVUODY2aXVjRWQzQ0Zr?=
 =?utf-8?B?Z1g5eGh5eVBLQ1l4cyt0V3R4c2NpaU9vUGJta0h2eFozamY0R1VodUY5ajZU?=
 =?utf-8?B?elN6L3hFdEZCWktwVjZoUWhtM0xFcG1BNVJCQ0ROdS9wNFVSeFliSmpkWFZ3?=
 =?utf-8?B?VzVzVVFLRndjYmpaMm80djR1YXhlbjNjWXRMNXpMcTU0Z2ZvRkhyWmpFbGlC?=
 =?utf-8?B?eW1EM3U1a2lhc3FBQk1HS3NRaG1LNFE1TDJnTUdMc3lobGtWRThMVUFkR3pI?=
 =?utf-8?B?bWFEQmt0U3NGSVR0MmRtQXdrcURCWVBHSEJMTWsxS2pIazZGTDBFOUs4VnNl?=
 =?utf-8?B?bFk2VnpFOG9TRG45S2hRL2tab1ZXMGpUM3JBbTNsNFRpMFRBWGNDUWRoYml1?=
 =?utf-8?B?ODZySjZvWURoeXg1azhzZ0o2Ukd4OHIyQzZTSXhxeHdRckxibjNtdEEwMyt6?=
 =?utf-8?B?dGhsckd5V3NXTVhicXUzNVA2M3hwdWxXSmdiSXUyYW1BdzZUVVJDT01YWGow?=
 =?utf-8?B?NHN4TWVhVnBtOTJON0FVRC83a1RCdXZ6b2NsdUhzUG5QODJaTkthTktZNEhT?=
 =?utf-8?B?ZkNtLzdBYTF6SEpiMmNyMStDYmRCaW1MTFUzRmFhb1RVWmVZbWZwSFdzcEcx?=
 =?utf-8?B?QUxmNkhJNENPZ3lSTzBYcTVDcXNuaFYvRkRoZHlFcDBrZmJJS3RTUzR3QW10?=
 =?utf-8?B?aXc2dmdkQi9FMHlaUHAvaGF1VVlmSW11UEo5M2lqbTF3amc4aFdyK2pBR2tO?=
 =?utf-8?B?OVlrczROTUhOSTQxbUNicmpqN0I4alhRVzBZeW5oRk9LMnRkRWVITy9TYkhV?=
 =?utf-8?B?YndJSm5BV2ZmdUtpUmVRWC8vVWNTR0g2b09laUgzQ2V0b0xBVlFZMUFqRmNZ?=
 =?utf-8?B?Qm9zTnc5OE9ORm1uTUdQV2Fvd1hBeC9uYStySDJkUVYwOUxhcUVvTC8wRWR3?=
 =?utf-8?B?TU9UeGg3ZFA4K1NtbzlBVGtuRDFUQk96dlNiS24vcnIyZVVLUlE4cjBUbFdQ?=
 =?utf-8?B?M2c3bnAwd29IaWh4ZW1FWkp1Y0FqQ040R29GdG5SNnMyYjZZWndUOFQ5dHpR?=
 =?utf-8?B?dk81emVJMEg1WE03T0hMb1RsVEFBTXUyYWZ2dGtOV082bG5UTm5rSUhKQXNC?=
 =?utf-8?B?Q2J2Qm1MdzZXK2tMUENJZmpkcVU0MWM1cFZOOVB4M05pL0NVeFZ0U1VUdFFH?=
 =?utf-8?B?S3pUd0w2WTNzY0JhSXZnaHdNUE1DNDJsWFowSDhrUzlJaEZDV3kxQUpUcGtW?=
 =?utf-8?B?L3Y3OHRMUml4RlRKbXlIa2R5aXRVMkpaWXZsSG5pMnhOVDNKMTBFVk5vaEJs?=
 =?utf-8?Q?uFO8J+UAJWa5p26lw5Se9Ws=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <47C1A15E5A2FEE459963495B6C3544E1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d00cf335-9a42-43e6-c8b9-08daa9300bb5
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2022 13:21:44.5864
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ADZXUvNI3NG1395ZMnwf7AWMIFyUMUT/SfDuRA/wsAufiIVuxIBxAZNhZhFL+IfVMOBMrgkbCXptpUt2LUgZLJWRhqbDL9hL2MZZdcQEhLA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR03MB8192
X-Proofpoint-ORIG-GUID: vbSfc4yvM6uA19YxpM870IBr80CaxRKI
X-Proofpoint-GUID: vbSfc4yvM6uA19YxpM870IBr80CaxRKI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 priorityscore=1501 clxscore=1015 impostorscore=0 mlxscore=0
 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxlogscore=999
 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210080085

DQpPbiAwOC4xMC4yMiAxNTo1OSwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KSGVsbG8gWGVu
aWENCg0KPg0KPiBPbiAxMC84LzIyIDE1OjUyLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4+DQo+PiBPbiAwOC4xMC4yMiAxNDowOCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCj4+DQo+
PiBIZWxsbyBYZW5pYQ0KPj4NCj4+Pg0KPj4+IE9uIDEwLzcvMjIgMTY6MjcsIE9sZWtzYW5kciBU
eXNoY2hlbmtvIHdyb3RlOg0KPj4+DQo+Pj4gSGkgT2xla3NhbmRyDQo+Pj4NCj4+Pj4gRnJvbTog
T2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+
Pg0KPj4+PiBQYXNzZWQgdG8geGVuX2dyYW50X2RtYV9tYXBfcGFnZSgpIG9mZnNldCBpbiB0aGUg
cGFnZQ0KPj4+PiBjYW4gYmUgPiBQQUdFX1NJWkUgZXZlbiBpZiB0aGUgZ3Vlc3QgdXNlcyB0aGUg
c2FtZSBwYWdlIGdyYW51bGFyaXR5DQo+Pj4+IGFzIFhlbiAoNEtCKS4NCj4+Pj4NCj4+Pj4gQmVm
b3JlIGN1cnJlbnQgcGF0Y2gsIGlmIHN1Y2ggY2FzZSBoYXBwZW5lZCB3ZSBlbmRlZCB1cCBwcm92
aWRpbmcNCj4+Pj4gZ3JhbnRzIGZvciB0aGUgd2hvbGUgcmVnaW9uIGluIHhlbl9ncmFudF9kbWFf
bWFwX3BhZ2UoKSB3aGljaA0KPj4+PiB3YXMgcmVhbGx5IHVubmVjZXNzYXJ5LiBUaGUgbW9yZSwg
d2UgZW5kZWQgdXAgbm90IHJlbGVhc2luZyBhbGwNCj4+Pj4gZ3JhbnRzIHdoaWNoIHJlcHJlc2Vu
dGVkIHRoYXQgcmVnaW9uIGluIHhlbl9ncmFudF9kbWFfdW5tYXBfcGFnZSgpLg0KPj4+Pg0KPj4+
PiBDdXJyZW50IHBhdGNoIHVwZGF0ZXMgdGhlIGNvZGUgdG8gYmUgYWJsZSB0byBkZWFsIHdpdGgg
c3VjaCBjYXNlcy4NCj4+Pj4NCj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVu
a28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+PiAtLS0NCj4+Pj4gQ2M6IEp1
ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+Pj4gQ2M6IFhlbmlhIFJhZ2lhZGFrb3Ug
PGJ1cnphbG9kb3dhQGdtYWlsLmNvbT4NCj4+Pj4NCj4+Pj4gRGVwZW5zIG9uOg0KPj4+PiBodHRw
czovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVs
LzIwMjIxMDA1MTc0ODIzLjE4MDA3NjEtMS1vbGVrc3R5c2hAZ21haWwuY29tL19fOyEhR0ZfMjlk
YmNRSVVCUEEheG5rTmFLcGZaNExzc1FKY0pzX0o5MUtFUlpLTVAyUmQteEVkQnFYTlhKOEd5Q1hK
MGdrUmVyMWVsVllmeE9XdHdOX0ZPbDl0VmllRFdsZk4tVVphSFFzeUxNaEEkIA0KPj4+Pg0KPj4+
PiBbbG9yZVsuXWtlcm5lbFsuXW9yZ10NCj4+Pj4NCj4+Pj4gU2hvdWxkIGdvIGluIG9ubHkgYWZ0
ZXIgdGhhdCBzZXJpZXMuDQo+Pj4+IC0tLQ0KPj4+PiDCoMKgIGRyaXZlcnMveGVuL2dyYW50LWRt
YS1vcHMuYyB8IDggKysrKystLS0NCj4+Pj4gwqDCoCAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRp
b25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPj4+Pg0KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94
ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+IGlu
ZGV4IGM2NmY1NmQyNDAxMy4uMTM4NWYwZTY4NmZlIDEwMDY0NA0KPj4+PiAtLS0gYS9kcml2ZXJz
L3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9w
cy5jDQo+Pj4+IEBAIC0xNjgsNyArMTY4LDkgQEAgc3RhdGljIGRtYV9hZGRyX3QgeGVuX2dyYW50
X2RtYV9tYXBfcGFnZShzdHJ1Y3QNCj4+Pj4gZGV2aWNlICpkZXYsIHN0cnVjdCBwYWdlICpwYWdl
LA0KPj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVu
c2lnbmVkIGxvbmcgYXR0cnMpDQo+Pj4+IMKgwqAgew0KPj4+PiDCoMKgwqDCoMKgwqAgc3RydWN0
IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YTsNCj4+Pj4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgaSwg
bl9wYWdlcyA9IFBGTl9VUChvZmZzZXQgKyBzaXplKTsNCj4+Pj4gK8KgwqDCoCB1bnNpZ25lZCBs
b25nIGRtYV9vZmZzZXQgPSBvZmZzZXRfaW5fcGFnZShvZmZzZXQpLA0KPj4+PiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBnZm5fb2Zmc2V0ID0gUEZOX0RPV04ob2Zmc2V0KTsNCj4+Pj4gK8KgwqDC
oCB1bnNpZ25lZCBpbnQgaSwgbl9wYWdlcyA9IFBGTl9VUChkbWFfb2Zmc2V0ICsgc2l6ZSk7DQo+
Pj4NCj4+PiBJSVVDLCB0aGUgYWJvdmUgd2l0aCBhIGxhdGVyIHBhdGNoIHdpbGwgYmVjb21lOg0K
Pj4+DQo+Pj4gZG1hX29mZnNldCA9IHhlbl9vZmZzZXRfaW5fcGFnZShvZmZzZXQpDQo+Pj4gZ2Zu
X29mZnNldCA9IFhFTl9QRk5fRE9XTihvZmZzZXQpDQo+Pj4gbl9wYWdlcyA9IFhFTl9QRk5fVVAo
ZG1hX29mZnNldCArIHNpemUpDQo+Pg0KPj4NCj4+IElmIHNheWluZyAibGF0ZXIiIHBhdGNoIHlv
dSBtZWFudCAieGVuL3ZpcnRpbzogQ29udmVydA0KPj4gUEFHRV9TSVpFL1BBR0VfU0hJRlQvUEZO
X1VQIHRvIFhlbiBjb3VudGVycGFydHMiIHRoZW4geWVzLCBleGFjdGx5Lg0KPg0KPiBBaCBvaywg
SSBzZWUuDQo+DQo+Pj4NCj4+Pg0KPj4+PiDCoMKgwqDCoMKgwqAgZ3JhbnRfcmVmX3QgZ3JhbnQ7
DQo+Pj4+IMKgwqDCoMKgwqDCoCBkbWFfYWRkcl90IGRtYV9oYW5kbGU7DQo+Pj4+IMKgwqAgQEAg
LTE4NywxMCArMTg5LDEwIEBAIHN0YXRpYyBkbWFfYWRkcl90DQo+Pj4+IHhlbl9ncmFudF9kbWFf
bWFwX3BhZ2Uoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgcGFnZSAqcGFnZSwNCj4+Pj4gwqDC
oCDCoMKgwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBuX3BhZ2VzOyBpKyspIHsNCj4+Pj4gwqDCoMKg
wqDCoMKgwqDCoMKgwqAgZ250dGFiX2dyYW50X2ZvcmVpZ25fYWNjZXNzX3JlZihncmFudCArIGks
DQo+Pj4+IGRhdGEtPmJhY2tlbmRfZG9taWQsDQo+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgeGVuX3BhZ2VfdG9fZ2ZuKHBhZ2UpICsgaSwgZGlyID09IERNQV9UT19ERVZJQ0Up
Ow0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHhlbl9wYWdlX3RvX2dmbihw
YWdlKSArIGkgKyBnZm5fb2Zmc2V0LCBkaXIgPT0NCj4+Pj4gRE1BX1RPX0RFVklDRSk7DQo+Pj4N
Cj4+PiBIZXJlLCB3aHkgdGhlIHBmbiBpcyBub3QgY2FsY3VsYXRlZCBiZWZvcmUgcGFzc2luZyBp
dCB0byBwZm5fdG9fZ2ZuKCk/DQo+Pj4gSSBtZWFuIHN0aCBsaWtlIHBmbl90b19nZm4ocGFnZV90
b194ZW5fcGZuKHBhZ2UpICsgZ2ZuX29mZnNldCArIGkpDQo+Pg0KPj4gVGhlIGdmbl9vZmZzZXQg
aXMganVzdCBhIGNvbnN0IHZhbHVlIGhlcmUsIHdoaWNoIGp1c3QgbWVhbnMgaG93IG1hbnkNCj4+
IGdmbnMgd2Ugc2hvdWxkIHNraXAuIEJ1dCAuLi4NCj4+DQo+PiAuLi4gSSB0aGluaywgSSBnZXQg
eW91ciBwb2ludC4gU28sIGlmIHRoZSByZWdpb24gd2hpY2ggaXMgY29udGlndW91cyBpbg0KPj4g
cGZuIG1pZ2h0IGJlIG5vbi1jb250aWd1b3VzIGluIGdmbiAod2hpY2ggc2VlbXMgdG8gYmUgdGhl
IGNhc2UgZm9yIHg4NidzDQo+PiBQViwgYnV0IEkgbWF5IG1pc3Rha2UpIHdlIHNob3VsZCBpbmRl
ZWQgdXNlIG9wZW4tY29kZWQNCj4+DQo+PiBjb25zdHJ1Y3Rpb24gInBmbl90b19nZm4ocGFnZV90
b194ZW5fcGZuKHBhZ2UpICsgZ2ZuX29mZnNldCArIGkpIi7CoCBBbmQNCj4+IHRoZSBnZm5fb2Zm
c2V0IHNob3VsZCBiZSByZW5hbWVkIHRvIHBmbl9vZmZzZXQgdGhlbi4NCj4+DQo+Pg0KPj4gQ29y
cmVjdD8NCj4NCj4gWWVzLCB0aGF0ICdzIHdoYXQgSSBoYWQgaW4gbWluZCB1bmxlc3MgSSAnbSBt
aXNzaW5nIHN0aC4NCg0KDQpvaywgdGhhbmtzIGZvciBjb25maXJtaW5nLiBTbyBJIHdpbGwgY3Jl
YXRlIFYyIHRoZW4uDQoNCg0KPg0KPj4+DQo+Pj4+IMKgwqDCoMKgwqDCoCB9DQo+Pj4+IMKgwqAg
LcKgwqDCoCBkbWFfaGFuZGxlID0gZ3JhbnRfdG9fZG1hKGdyYW50KSArIG9mZnNldDsNCj4+Pj4g
K8KgwqDCoCBkbWFfaGFuZGxlID0gZ3JhbnRfdG9fZG1hKGdyYW50KSArIGRtYV9vZmZzZXQ7DQo+
Pj4+IMKgwqAgwqDCoMKgwqDCoCByZXR1cm4gZG1hX2hhbmRsZTsNCj4+Pj4gwqDCoCB9DQo+Pj4N
Cj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 13:56:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 13:56:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418529.663355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohAJN-0007HS-Dx; Sat, 08 Oct 2022 13:56:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418529.663355; Sat, 08 Oct 2022 13:56:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohAJN-0007HL-9b; Sat, 08 Oct 2022 13:56:17 +0000
Received: by outflank-mailman (input) for mailman id 418529;
 Sat, 08 Oct 2022 13:56:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohAJL-0007HB-Pv; Sat, 08 Oct 2022 13:56:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohAJL-0001j9-O4; Sat, 08 Oct 2022 13:56:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohAJL-0000he-7H; Sat, 08 Oct 2022 13:56:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohAJL-0003ir-6q; Sat, 08 Oct 2022 13:56:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XMsdfX9fs+MRL/rJ/JGJ1lgZgHX6GB9zPXHxrGpd30I=; b=4m5FvKBuhzlMylZhUaGnsFDLxy
	IQsAHXNu0/XwPmwUTBUP0+saqNjvACSGTzGal07ly8CKRieWHkczdbV6i0Da6iCbnqz1fQpkZQpAH
	ZGTT8803kuF5zJVYFW0Vpj+5X0ABQZ1BFPJLKOnKvxkivJ2dkr6/7fGa9FUkW+mFTUAA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173472-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173472: tolerable FAIL - PUSHED
X-Osstest-Failures:
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
X-Osstest-Versions-This:
    ovmf=de103f1981cfca90dd19296d4b20449a2b93dc26
X-Osstest-Versions-That:
    ovmf=4364d661685d4806b8fb66ff76eaece7ea6a4426
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 13:56:15 +0000

flight 173472 ovmf real [real]
flight 173473 ovmf real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173472/
http://logs.test-lab.xenproject.org/osstest/logs/173473/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 173473-retest

version targeted for testing:
 ovmf                 de103f1981cfca90dd19296d4b20449a2b93dc26
baseline version:
 ovmf                 4364d661685d4806b8fb66ff76eaece7ea6a4426

Last test of basis   173471  2022-10-08 08:41:54 Z    0 days
Testing same since   173472  2022-10-08 11:13:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Foster Nong <foster.nong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   4364d66168..de103f1981  de103f1981cfca90dd19296d4b20449a2b93dc26 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 15:10:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 15:10:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418539.663373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBTI-0007OY-5y; Sat, 08 Oct 2022 15:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418539.663373; Sat, 08 Oct 2022 15:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBTI-0007NU-0n; Sat, 08 Oct 2022 15:10:36 +0000
Received: by outflank-mailman (input) for mailman id 418539;
 Sat, 08 Oct 2022 15:10:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0eQj=2J=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ohBTG-0007Gm-Pb
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 15:10:34 +0000
Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com
 [2a00:1450:4864:20::62a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5b10c4a0-471b-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 17:10:33 +0200 (CEST)
Received: by mail-ej1-x62a.google.com with SMTP id k2so16891942ejr.2
 for <xen-devel@lists.xenproject.org>; Sat, 08 Oct 2022 08:10:33 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l25-20020a50d6d9000000b0045723aa48ccsm3523119edj.93.2022.10.08.08.10.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 08 Oct 2022 08:10:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b10c4a0-471b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=20FlK2f2Ao6in3DL/pE8fjcn0IFPQLl6lYsp91zsW/g=;
        b=ROTHMsmP/hzHS74G5W9dubaxDxyjkONMkP12fjLSs7nXD77oMmyr0l2NmnTjHv1Hwy
         zks7PaJdMSnEWoAwqOi4UUoC/kVKHQBEn96iD61c9+n+1FyW4sj89a410hBePPTvINK8
         UuWofOk3ZZLRM2tvGpQmPVrNfKp7G6/wRNk4HT9KH4xo0vtnzi+/rXdpzu+0xabMtWhO
         hEx800aqTYrse+VY0x4iY7CgkcjXyxeaVDfNM2f184zWPNkzqCHSrll/+0v7GeQThF7D
         SXMJJswpnKdExgww62wuwncf+ygGRYHuTAZ3Ac37jBQBsTaDaL7waMhuE2VrE+7Fah4G
         P/rA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=20FlK2f2Ao6in3DL/pE8fjcn0IFPQLl6lYsp91zsW/g=;
        b=4ed9YuPVAcEQy1STFwnmcnX5T78Oefi+Yc5UisjZ1T9+Fbhnt7m2KjvpyaL/fDHOcR
         67IZGKovM64QE2VFEMzcQH+ascqWT28qdHrOIIdv1amNjxcc1DYrIsBIw49qpXOqYEF/
         9PJD0UeCmN84Wr+GE3bgTDYLW69YXvxrHV3ZX0uQvkNJ4koHYywu4tPSqhV17Tgl6GAl
         hKz3gaJ7Cf2XM5r87c8QR62iWiLskG640TqKz5lzBwFJPqN9JvHZ7enhu9IRSD2qAPvo
         Y6JhAdQBSL1iV2wrfuCZGfGH8MZfx5XwiPp+tHy6mZXm+0Ov86PUOY4/2EbmyXucBoYl
         U2eQ==
X-Gm-Message-State: ACrzQf365iqegQsk+kcAstCCy3jVy7EXPPsy1mXGuN/v1svFs9JZxU4p
	fAZuk3eyymZJnsuJU6ClhEFpL7TnXwg=
X-Google-Smtp-Source: AMsMyM5XtGDmusETEHuN4wJntwNBpo8Mn3TJU8DM8u6nC3r7GTulKyyiTrXMGTKfS0fnjt2h4eGUBQ==
X-Received: by 2002:a17:906:974f:b0:780:4a3c:d179 with SMTP id o15-20020a170906974f00b007804a3cd179mr8378820ejy.289.1665241832708;
        Sat, 08 Oct 2022 08:10:32 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V2 1/2] xen/virtio: Handle cases when page offset > PAGE_SIZE properly
Date: Sat,  8 Oct 2022 18:10:12 +0300
Message-Id: <20221008151013.2537826-2-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221008151013.2537826-1-olekstysh@gmail.com>
References: <20221008151013.2537826-1-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Passed to xen_grant_dma_map_page() offset in the page
can be > PAGE_SIZE even if the guest uses the same page granularity
as Xen (4KB).

Before current patch, if such case happened we ended up providing
grants for the whole region in xen_grant_dma_map_page() which
was really unnecessary. The more, we ended up not releasing all
grants which represented that region in xen_grant_dma_unmap_page().

Current patch updates the code to be able to deal with such cases.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Cc: Juergen Gross <jgross@suse.com>
Cc: Xenia Ragiadakou <burzalodowa@gmail.com>

Changes V1 -> V2:
   - s/gfn_offset/pfn_offset
   - clarify gfn calculation when granting a page

Previous discussion is at:
https://lore.kernel.org/lkml/20221007132736.2275574-1-olekstysh@gmail.com/
---
 drivers/xen/grant-dma-ops.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index c66f56d24013..1d018e3a68a0 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -168,7 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 					 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(offset + size);
+	unsigned long dma_offset = offset_in_page(offset),
+			pfn_offset = PFN_DOWN(offset);
+	unsigned int i, n_pages = PFN_UP(dma_offset + size);
 	grant_ref_t grant;
 	dma_addr_t dma_handle;
 
@@ -187,10 +189,11 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 
 	for (i = 0; i < n_pages; i++) {
 		gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
-				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
+				pfn_to_gfn(page_to_xen_pfn(page) + i + pfn_offset),
+				dir == DMA_TO_DEVICE);
 	}
 
-	dma_handle = grant_to_dma(grant) + offset;
+	dma_handle = grant_to_dma(grant) + dma_offset;
 
 	return dma_handle;
 }
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 15:10:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 15:10:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418538.663365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBTH-0007H6-LV; Sat, 08 Oct 2022 15:10:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418538.663365; Sat, 08 Oct 2022 15:10:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBTH-0007Gz-Ir; Sat, 08 Oct 2022 15:10:35 +0000
Received: by outflank-mailman (input) for mailman id 418538;
 Sat, 08 Oct 2022 15:10:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0eQj=2J=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ohBTG-0007Gm-7Q
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 15:10:34 +0000
Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com
 [2a00:1450:4864:20::631])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a58d888-471b-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 17:10:32 +0200 (CEST)
Received: by mail-ej1-x631.google.com with SMTP id a26so16859015ejc.4
 for <xen-devel@lists.xenproject.org>; Sat, 08 Oct 2022 08:10:32 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l25-20020a50d6d9000000b0045723aa48ccsm3523119edj.93.2022.10.08.08.10.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 08 Oct 2022 08:10:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a58d888-471b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=C5DKsFFe8GPmeoM51frqAs/ZJNFCYSbjNvK+URttuB0=;
        b=YZEi5wYvmKc822x5qZvwjXOKD/IDcmbU98kIh5rLAX9WDSnrbVNe4M6BVGos4rdcpj
         Uz88wSpTNaflbdEqvvyY3wvFvZLBP7L9iQJQPlz9ZhRBwyNaR3vEIX/KwWCZRNTUHk/J
         KEK0QKfrljjuBE7L7cYhY3GzMXAPWeNEM6mrE11Ktq3m4EXJ/pko9Qb+IGcd5jtdAn7/
         GPnCNELGQx/QfoACdZp8fSuHX4mo2dU0mbXQyipCgOKpJA6YMoFb7YzTGSJW27zuLSTt
         RPwfByzsmEH8Gc25nVf7ImFxZ0n9t/tHYBnIJJ68S/hzi82LtUIkImEEuNSWh+yxnoxp
         VHDQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=C5DKsFFe8GPmeoM51frqAs/ZJNFCYSbjNvK+URttuB0=;
        b=hDVtQJOudaTRl/vct9L210hV8+1DluBQGU9cw3oxoGUi6ipixgTUiFDCfyu3xXQNTx
         vfghVG0GhIj0Ny2X7O8e2dZs9zyfWJ2h5SlO7gJauwx0O9lqg9EBE8F8DCQHsF4TDhlg
         DTpz98H0lMGLIPMzlgeb0P0D6LzbvzRkPObgd86XBqgtr+KgVu7YL5Z2U09FJ35Do/xg
         2TchwB5XvaNK1e0GsX87yzUWP1A3cUBg2X9K26MnGTc6SFpMV+gJvYTV30Lk5IG8+esV
         +iZ7urNAyJ9BqY122qeqfyewY3SMeDATXdphqqACImnsl5sP1MUrOhBTLZM/pPUwoVE6
         VxsQ==
X-Gm-Message-State: ACrzQf3pcnLlIOIJD3r9IG3uGnR6x9o7j1B6MlA38cilJ27PMwM6V6Rb
	0kEqRnFcQUXq4sEz94WjyQhEGgyCAtg=
X-Google-Smtp-Source: AMsMyM6JPxbo4+cgHinL2jtWQLwIksmTxOnGzE4YG9CLtfRaECFGgMBAaRcIrMcuCErVSdbK35q2Qw==
X-Received: by 2002:a17:906:cc56:b0:78d:98c3:8714 with SMTP id mm22-20020a170906cc5600b0078d98c38714mr2194404ejb.445.1665241831517;
        Sat, 08 Oct 2022 08:10:31 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V2 0/2] Other misc fixes for Xen grant DMA-mapping layer
Date: Sat,  8 Oct 2022 18:10:11 +0300
Message-Id: <20221008151013.2537826-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

These are other several fixes, which were identified and sent separately,
but now they are put together in completeness here.

Current series depends on the series which has been already pushed
to xen/tip.git for-linus-6.1:
https://lore.kernel.org/xen-devel/20221005174823.1800761-1-olekstysh@gmail.com/

Oleksandr Tyshchenko (2):
  xen/virtio: Handle cases when page offset > PAGE_SIZE properly
  xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen counterparts

 drivers/xen/grant-dma-ops.c | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 15:10:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 15:10:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418540.663387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBTJ-0007ly-AT; Sat, 08 Oct 2022 15:10:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418540.663387; Sat, 08 Oct 2022 15:10:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBTJ-0007lr-7W; Sat, 08 Oct 2022 15:10:37 +0000
Received: by outflank-mailman (input) for mailman id 418540;
 Sat, 08 Oct 2022 15:10:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0eQj=2J=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ohBTH-0007Gm-Nd
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 15:10:35 +0000
Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com
 [2a00:1450:4864:20::62a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5be7e6b9-471b-11ed-9377-c1cf23e5d27e;
 Sat, 08 Oct 2022 17:10:35 +0200 (CEST)
Received: by mail-ej1-x62a.google.com with SMTP id k2so16892019ejr.2
 for <xen-devel@lists.xenproject.org>; Sat, 08 Oct 2022 08:10:34 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 l25-20020a50d6d9000000b0045723aa48ccsm3523119edj.93.2022.10.08.08.10.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 08 Oct 2022 08:10:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5be7e6b9-471b-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=BJfFnZUElo4fDCQOc+GUeP/mNGH0ahT8QNQddIgzFpg=;
        b=g8aEsBuSKZ+1up29Gc0SivPAU0QfBvEDsDLSm/BA/WXxN1bgp6/ngqfrbqm2DWVHLw
         XY8BXGqopp6EWzVAt9v4zmoAu6Jbpj0rLDLEU7d1IjG38hYiQitRNR61MMREM0lqONMW
         WNOejInVh1VNU8xCdlu2gGUxtnyeyDK/he9Y7VJw4AK7iugU2I1s3KutVEVcLuoghSY2
         NQAW8eDDrLuM9/t3Aiccabh+YNbgX+hG6puCWDK/Shdi8LAkwVk2JbYaZOTgHfs+ZJfh
         gOjpzeOjYWGMgF5upe3h1GLGqIuLRi8laVdgMnKu5jjdzeB4pIQZ6Qi90e0vj9Sza4WE
         +h4A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=BJfFnZUElo4fDCQOc+GUeP/mNGH0ahT8QNQddIgzFpg=;
        b=hEYWh3R8sttSys3sLTB7E4+O+MULcoAXYmqveqHJy7zBRch0d8i7BFCkZURD5YRB3n
         BhvQmZpiWOeCxfshMatJjExFN6qlEhd0ZXUNCmCplAF5/jQobwYhoKhZbY8WT+MATd8k
         QZNYKZr7Qv2XIK2xvHh0jJa3BlJqaRQzId540Vv+v46E79rTZY0vfbPfNqIZrwYl7uRy
         CjK2yXo27MeV0iG0/3p64LZp7Wx8gw8VGoyXQGHkSnMyQabJk60wnGmaKSPeov+wYIWq
         e0MDZ5HRwFDOyrW+KWaggtkJssM6rKWfH9k4AsfN8gPoojGOVDduQL5YI1rGbHTRrwSG
         8ydw==
X-Gm-Message-State: ACrzQf3c3izN2t3/au0b/cN48zx8a2g7sThd8/hWKMtya7axk7NHIv4X
	32WySRqKBwQeFtxazF8DT/B1jaB1b4w=
X-Google-Smtp-Source: AMsMyM4cQnfbv1dRZ3p5BrDqTgfEyct+5Knto6fqk5S+UPZWC9Wybbx5bOvo/nRGWvYlCvM7hU59hA==
X-Received: by 2002:a17:907:802:b0:781:8017:b2df with SMTP id wv2-20020a170907080200b007818017b2dfmr8109754ejb.606.1665241834228;
        Sat, 08 Oct 2022 08:10:34 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V2 2/2] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen counterparts
Date: Sat,  8 Oct 2022 18:10:13 +0300
Message-Id: <20221008151013.2537826-3-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221008151013.2537826-1-olekstysh@gmail.com>
References: <20221008151013.2537826-1-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Currently, a grant ref is always based on the Xen page granularity
(4KB), and guest commonly uses the same page granularity.
But the guest may use a different page granularity (i.e 64KB).
So adopt the code to be able to deal with it.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Cc: Juergen Gross <jgross@suse.com>
Cc: Xenia Ragiadakou <burzalodowa@gmail.com>

Changes V1 -> V2:
   - update commit description
   - rebase
   - use xen_offset_in_page() in xen_grant_dma_map(unmap)_page()

Previous discussion is at:
https://lore.kernel.org/xen-devel/20221006120912.1948459-1-olekstysh@gmail.com/
---
 drivers/xen/grant-dma-ops.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 1d018e3a68a0..aff0f95ed954 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
 
 static inline dma_addr_t grant_to_dma(grant_ref_t grant)
 {
-	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
+	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << XEN_PAGE_SHIFT);
 }
 
 static inline grant_ref_t dma_to_grant(dma_addr_t dma)
 {
-	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
+	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> XEN_PAGE_SHIFT);
 }
 
 static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
@@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
 				 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(size);
+	unsigned int i, n_pages = XEN_PFN_UP(size);
 	unsigned long pfn;
 	grant_ref_t grant;
 	void *ret;
@@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
 	if (unlikely(data->broken))
 		return NULL;
 
-	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
+	ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
 	if (!ret)
 		return NULL;
 
 	pfn = virt_to_pfn(ret);
 
 	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
-		free_pages_exact(ret, n_pages * PAGE_SIZE);
+		free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
 		return NULL;
 	}
 
@@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
 			       dma_addr_t dma_handle, unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned int i, n_pages = PFN_UP(size);
+	unsigned int i, n_pages = XEN_PFN_UP(size);
 	grant_ref_t grant;
 
 	data = find_xen_grant_dma_data(dev);
@@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
 
 	gnttab_free_grant_reference_seq(grant, n_pages);
 
-	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
+	free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
 }
 
 static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
@@ -168,9 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
 					 unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned long dma_offset = offset_in_page(offset),
-			pfn_offset = PFN_DOWN(offset);
-	unsigned int i, n_pages = PFN_UP(dma_offset + size);
+	unsigned long dma_offset = xen_offset_in_page(offset),
+			pfn_offset = XEN_PFN_DOWN(offset);
+	unsigned int i, n_pages = XEN_PFN_UP(dma_offset + size);
 	grant_ref_t grant;
 	dma_addr_t dma_handle;
 
@@ -203,8 +203,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
 				     unsigned long attrs)
 {
 	struct xen_grant_dma_data *data;
-	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
-	unsigned int i, n_pages = PFN_UP(offset + size);
+	unsigned long dma_offset = xen_offset_in_page(dma_handle);
+	unsigned int i, n_pages = XEN_PFN_UP(dma_offset + size);
 	grant_ref_t grant;
 
 	if (WARN_ON(dir == DMA_NONE))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 08 15:12:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 15:12:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418557.663399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBVR-0000ZO-MN; Sat, 08 Oct 2022 15:12:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418557.663399; Sat, 08 Oct 2022 15:12:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBVR-0000ZH-Jc; Sat, 08 Oct 2022 15:12:49 +0000
Received: by outflank-mailman (input) for mailman id 418557;
 Sat, 08 Oct 2022 15:12:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=x/cu=2J=alien8.de=bp@srs-se1.protection.inumbo.net>)
 id 1ohBVG-0000Yd-5T
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 15:12:48 +0000
Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a3910ff0-471b-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 17:12:35 +0200 (CEST)
Received: from nazgul.tnic (unknown [46.183.103.8])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4DFE01EC05B0;
 Sat,  8 Oct 2022 17:12:30 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3910ff0-471b-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
	t=1665241950;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
	bh=DYgRImUlP5sBAB0m+Fi/O5fIFHatVYNoMS9h40YOHco=;
	b=NkOfR/aWMdEV1z9XGZ2/WEYAky35KX2YfStKR//x78sVUpXeyC+sGuu3T9Zh09vBWI1C/X
	A9AOyivIJDLtZgMOzooIcg120y6SnGXYZoWlzlWjzrevFMtmpWkjC/S7u2OSXlig/PKlIe
	DfUmPNUpd3yffSBvtxuHwT3ZtoOVU2E=
Date: Sat, 8 Oct 2022 17:12:35 +0200
From: Borislav Petkov <bp@alien8.de>
To: Ross Philipson <ross.philipson@oracle.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
	kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
	Jan Kiszka <jan.kiszka@siemens.com>, jailhouse-dev@googlegroups.com,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls
Message-ID: <Y0GTUg1ACpKZYMHY@nazgul.tnic>
References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
 <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>

Adding Xen and Jailhouse people and MLs to Cc.

Folks, thread starts here:

https://lore.kernel.org/r/1650035401-22855-1-git-send-email-ross.philipson@oracle.com

On Fri, Apr 15, 2022 at 11:10:00AM -0400, Ross Philipson wrote:
> There are a number of places where early_memremap is called
> but the return pointer is not checked for NULL. The call
> can result in a NULL being returned so the checks must
> be added.
> 
> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
> ---
>  arch/x86/kernel/devicetree.c | 10 ++++++++++
>  arch/x86/kernel/e820.c       |  5 +++++
>  arch/x86/kernel/jailhouse.c  |  6 ++++++
>  arch/x86/kernel/mpparse.c    | 23 +++++++++++++++++++++++
>  arch/x86/kernel/setup.c      |  5 +++++
>  arch/x86/xen/enlighten_hvm.c |  2 ++
>  arch/x86/xen/mmu_pv.c        |  8 ++++++++
>  arch/x86/xen/setup.c         |  2 ++
>  8 files changed, 61 insertions(+)

Ok, a couple of notes:

1. the pr_*("<prefix>:" ... )

thing is done using pr_fmt() - grep the tree for examples.

2. I think you should not panic() the machine but issue a the
warning/error and let the machine die a painful death anyway. But Xen
folks will know better what would be the optimal thing to do.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 15:17:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 15:17:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418566.663409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBa1-0001NM-86; Sat, 08 Oct 2022 15:17:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418566.663409; Sat, 08 Oct 2022 15:17:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohBa1-0001NF-5c; Sat, 08 Oct 2022 15:17:33 +0000
Received: by outflank-mailman (input) for mailman id 418566;
 Sat, 08 Oct 2022 15:17:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Fr1J=2J=runbox.com=m.v.b@srs-se1.protection.inumbo.net>)
 id 1ohBZz-0001N8-0t
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 15:17:31 +0000
Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com
 [2a0c:5a00:149::26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 531441e1-471c-11ed-964a-05401a9f4f97;
 Sat, 08 Oct 2022 17:17:30 +0200 (CEST)
Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com)
 by mailtransmit05.runbox.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93)
 (envelope-from <m.v.b@runbox.com>)
 id 1ohBZv-005sgY-HQ; Sat, 08 Oct 2022 17:17:27 +0200
Received: from [10.9.9.73] (helo=submission02.runbox)
 by mailtransmit02.runbox with esmtp (Exim 4.86_2)
 (envelope-from <m.v.b@runbox.com>)
 id 1ohBZu-0007DE-Sw; Sat, 08 Oct 2022 17:17:27 +0200
Received: by submission02.runbox with esmtpsa [Authenticated ID (536975)]
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 id 1ohBZr-00088a-QG; Sat, 08 Oct 2022 17:17:23 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 531441e1-471c-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com;
	 s=selector2; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ckAECo5Hee38U9yD/vQmVIvkFJ4wx3mMw6mzw2eeuNs=; b=GVKxVqd1VDdL3NEIDagwkT/XCi
	nEiN9yuacrMjamKgdY8KNWopW2T4AzZOMgtNvSIWoputKNbJMv70Uleuuk5h6lydCTEM0VSfvHkRT
	YyaTUSnPil/DQ6TaYQhaFoBuz5Ynb+Cf3UU/+ZMyQ17CRRUrbWXedkyghC4jr3aKANysDeaYRBPOg
	+bnyhkZuyHmO0q892RGRn7GYCMss8Nt7vNgnUp+Gxco9DdTf5NKPjhT+5fsWTDqxnwBlL+ZagkkmH
	1KX8OgyYuq9DsuCDvOdA0+/PCs9ZVUj8YqaJ8D10C3ya2n3o/CT8e4Cad2Lz/6bs0Km3Y5CxDoI6n
	Cb89UNUQ==;
Message-ID: <9cdb37b7-b4c0-3bc3-ecdc-643ddc2fbcc5@runbox.com>
Date: Sat, 8 Oct 2022 11:17:20 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2 0/2] xen/gntdev: Fixes for leaks and VMA splitting
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Demi Marie Obenour <demi@invisiblethingslab.com>,
 Gerd Hoffmann <kraxel@redhat.com>
References: <20221002222006.2077-1-m.v.b@runbox.com>
 <9aa1e6ba-a153-8dfa-ce28-3ab78b26c6e4@suse.com>
Content-Language: en-CA
From: "M. Vefa Bicakci" <m.v.b@runbox.com>
In-Reply-To: <9aa1e6ba-a153-8dfa-ce28-3ab78b26c6e4@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2022-10-07 01:17, Juergen Gross wrote:
> On 03.10.22 00:20, M. Vefa Bicakci wrote:
>> Hi all,
>>
>> First of all, sorry for the delay!
>>
>> These patches continue the code review for the following patches:
>>    https://lore.kernel.org/xen-devel/20220912040002.198191-1-m.v.b@runbox.com/t/#u
>>
>> The original description of the patch set is as follows:
>>
>>    "The changes in this patch series intend to fix the Xen grant device
>>    driver, so that grant mapping leaks caused by partially failed grant
>>    mapping operations are avoided with the first patch, and so that the
>>    splitting of VMAs does not result in incorrectly unmapped grant pages
>>    with the second patch. The second patch also prevents a similar issue
>>    in a double-mapping scenario, where mmap() is used with MAP_FIXED to
>>    map grants over an existing mapping created with the same grants, and
>>    where grant pages are unmapped incorrectly as well."
>>
>> A summary of the changes from v1 is as follows:
>> - Addressed Juergen's code review comment regarding the first patch.
>> - Amended the description of the second patch to note that the described
>>    issues are encountered with PV domains.
>>
>> Verification notes:
>>
>> - I have tested these commits on top of Linux v5.15.70 and v5.15.71, and
>>    I verified that they compile successfully on top of the tag
>>    "next-20220930", which corresponds to the base commit ID included at
>>    the bottom of this e-mail.
>>
>> - My tests consist of using a kernel with Qubes OS v4.1's patches and
>>    these patches on my main computer for day-to-day tasks, in conjunction
>>    with Qubes OS's version of the Xen hypervisor v4.14.5, with the latter
>>    custom-compiled with CONFIG_DEBUG.
>>
>> - I used a test program that verifies the following scenarios with an
>>    unprivileged paravirtualized (PV) Xen domain:
>>
>>    - A program mmap()s two pages from another Xen domain and munmap()s
>>      the pages one by one. This used to result in implicit unmap errors
>>      to be reported by Xen and a general protection fault to be triggered
>>      by Xen in the affected domain, but now works as expected.
>>    - A program mmap()s two pages from another Xen domain and then
>>      attempts to remap (via MAP_FIXED) the same mapping again over the
>>      same virtual address. This used to result in similar issues
>>      (implicit unmap errors and general protection fault), but now is
>>      rejected by the kernel.
>>    - A program mmap()s two pages from another Xen domain and then
>>      attempts to mmap() the same mapping again to a different virtual
>>      address, by passing NULL as mmap()'s first argument. This used to be
>>      rejected by the kernel, and it continues to be rejected by the
>>      kernel.
>>
>> - Unprivileged PVH Xen domains were also sanity tested with the same
>>    test program. I should note that PVH domains worked as expected
>>    without these patches too.
>>
>> - Finally, I have verified that the original "g.e. 0x1234 still pending"
>>    issue does not appear after rapidly resizing GUI windows in Qubes OS
>>    v4.1.
> 
> Series pushed to xen/tip.git for-linus-6.1
> 
> 
> Juergen

I am a bit late, but thank you for reviewing the changes and merging them!

Vefa


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 17:49:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 17:49:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418612.663439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohDxD-0001yy-43; Sat, 08 Oct 2022 17:49:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418612.663439; Sat, 08 Oct 2022 17:49:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohDxD-0001yr-1G; Sat, 08 Oct 2022 17:49:39 +0000
Received: by outflank-mailman (input) for mailman id 418612;
 Sat, 08 Oct 2022 17:49:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohDxB-0001yh-QY; Sat, 08 Oct 2022 17:49:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohDxB-0006eS-N6; Sat, 08 Oct 2022 17:49:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohDxB-0001L9-5N; Sat, 08 Oct 2022 17:49:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohDxB-0002ID-4r; Sat, 08 Oct 2022 17:49:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W7sPIAmXX0ffFoztxFFdSGzsBcORPV5wO+wsWOou7cw=; b=ZVAUZLfdnPCvgJbUKf3TaVkCoj
	sguY1UPlMW+hVuC9OkDwglAs+Bjb+FicmQcW9eNSJW0WllRfcUChpdlGB4KlUzDwKqrprHUepDKvT
	QwyHy91BkZD1yV4AYdIkiNd35Ktq8+3rNrXiREuskhfFOrYPTmJpR2mfMkNSnZB3RNmE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173474-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173474: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e8bc52cb8df80c31c73c726ab58ea9746e9ff734
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 17:49:37 +0000

flight 173474 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173474/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-xsm  8 xen-boot                   fail pass in 173470
 test-arm64-arm64-xl-vhd       8 xen-boot                   fail pass in 173470
 test-armhf-armhf-xl-rtds      8 xen-boot                   fail pass in 173470

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173470 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173470 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173470 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173470 never pass
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 173470 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 173470 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                e8bc52cb8df80c31c73c726ab58ea9746e9ff734
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    0 days
Testing same since   173470  2022-10-08 06:21:34 Z    0 days    2 attempts

------------------------------------------------------------
371 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 23278 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 19:08:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 19:08:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418734.663503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohFBB-0005VP-3E; Sat, 08 Oct 2022 19:08:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418734.663503; Sat, 08 Oct 2022 19:08:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohFBB-0005VI-0G; Sat, 08 Oct 2022 19:08:09 +0000
Received: by outflank-mailman (input) for mailman id 418734;
 Sat, 08 Oct 2022 19:08:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohFB9-0005VC-K3
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 19:08:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohFB8-0008Co-4y; Sat, 08 Oct 2022 19:08:06 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohFB7-0004Do-Ur; Sat, 08 Oct 2022 19:08:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=26SuXPiKmeQ6L1tCSaeCg0p0DSactkNxVy4Ub0DZ92g=; b=H2l4WrT42499PKwQITuQem4xur
	FEN8WuaVwTsx/zmejHffh/9q9SEp2ZWv1dNSheUUVUCY0A9gxRI1za006e8UKmpwx+anNaiLAvCT6
	fe9DBPm3pirAL0D8bvLDbTtWvSGl8mpZAhgQ3fT/Ru3iqUbOqgT4tLJlgdUFYPTYmEHE=;
Message-ID: <a957dfbe-c4c4-c8cc-93c5-616a44fe1797@xen.org>
Date: Sat, 8 Oct 2022 20:08:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
 <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
 <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
 <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com>
 <82963a1c-3301-72ff-e995-77c30ec5a64b@suse.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
In-Reply-To: <82963a1c-3301-72ff-e995-77c30ec5a64b@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 06/10/2022 15:11, Jan Beulich wrote:
>> ... the space cannot become ordinary RAM, then such a precaution
>> wouldn't be necessary. After all hiding EfiACPIReclaimMemory from
>> Dom0 just because it can't be mapped WB wouldn't be very nice
>> either. I guess I'll submit v2 with this part of the change left
>> as it was.
> 
> And while already in the process of committing the patch I came to
> realize that if the WB conditional isn't supposed to move, isn't
> the change done for Arm then wrong as well? Shouldn't it then be
> 
>          if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
>               (desc_ptr->Attribute & EFI_MEMORY_WB) &&
>               (desc_ptr->Type == EfiConventionalMemory ||
>               ...
> 
> leaving the EfiACPIReclaimMemory case entirely unaffected by the
> change?

IIUC, the concern is the region EfiACPIReclaimMemory could have the 
attribute EFI_MEMORY_RUNTIME. Is that correct?

Given that the memory is reclaimable, I am not sure why it can also have 
this atribute set (to me it means the opposite). But I guess for 
hardening purpose it would be better to use the version you just suggested.

Bertrand, Stefano, what do you think?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 22:00:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 22:00:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418822.663550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohHs0-00017Y-3B; Sat, 08 Oct 2022 22:00:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418822.663550; Sat, 08 Oct 2022 22:00:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohHs0-00017R-0L; Sat, 08 Oct 2022 22:00:32 +0000
Received: by outflank-mailman (input) for mailman id 418822;
 Sat, 08 Oct 2022 22:00:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IpNc=2J=epam.com=prvs=2280ebcbdc=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1ohHry-00017L-BX
 for xen-devel@lists.xenproject.org; Sat, 08 Oct 2022 22:00:30 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c33e14f-4754-11ed-964a-05401a9f4f97;
 Sun, 09 Oct 2022 00:00:28 +0200 (CEST)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 298JNVmC025211;
 Sat, 8 Oct 2022 22:00:10 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k31gf1fs2-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 08 Oct 2022 22:00:09 +0000
Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18)
 by AS4PR03MB8602.eurprd03.prod.outlook.com (2603:10a6:20b:585::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 8 Oct
 2022 22:00:04 +0000
Received: from VI1PR03MB3710.eurprd03.prod.outlook.com
 ([fe80::d287:2a0b:40db:8c6]) by VI1PR03MB3710.eurprd03.prod.outlook.com
 ([fe80::d287:2a0b:40db:8c6%3]) with mapi id 15.20.5676.038; Sat, 8 Oct 2022
 22:00:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c33e14f-4754-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VtQMz5ENceg8SeMlXgJbW6k33B3yyq6dCRfNjca4/QJfeQAxxQ1oq1wxbR6m8nXE3PVVNCvccixZ7LzxhiqWqOhmoj1HMK2j9760zZc9iYFT2hWsdU7JkPXwLXBuQ56aMuJgZOlEA+h5tt8C7jPlWLdld+B6eQB1enkIGEDNHj0xTt3ZwKGKFMTUXw6Ty5HxbwTFo+LfY8ApOwCoODZhcq+itgR0HOWLbGQ7D1CIpN9z1A6CMuCm7EJdiZ2xXHVyYLkDlXmDSoP9v9IsS3zFGORTFhEssX3CVrkBwBSzmI+HIUfeECOVLSMOSuRkgzZDgYNXzerVrgFLVPdHd/j7sA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lSYKyVF/vWxyqV3U+G5s1EFVb7pGe7lKPFsx4VlLqaA=;
 b=fcuuE59ekPznNFU67WMC1uIrOp5I5VBuBrkwyVmlFLb/F2SIHGorMghJ/Yso5KYtj864VVxgXmmSn4PnWkM0QGVtrMgfYNT7MhG9bqNUprwKgJ/fhZ3C8Gw0iwyK0K5NwzXE86QCp9u/hv6KgJTpWiN+t0bRhJW63M3AUUa3BPN++Qe6hrjcNlrKp1IsRCWpJS4kOsNcmgcQ+2OvDjnJqn0ENE0MhK0GJZbpQosPf9lYMgZM/1t4beoc27633Nol3dmiWp4ixHKvk9sumNxWhiT8l8t260F3iq5ZciJH9HRliVPPjR4yaCVHoEttJ9OA32OTKj5L25hx3MuLPQdfGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lSYKyVF/vWxyqV3U+G5s1EFVb7pGe7lKPFsx4VlLqaA=;
 b=KNeSXxWMC1CupNGtt++QB/xWPkkEl58xCBWXD4P7bEdNu+0SPLqBwE6OYIaHsPI91kN0SqxxYZlp1rco/Tt886t03NrrUpnUICyYAuBUi+koV07REwfpww50NPprCR1Sit5m6DvEQyHUHWAH5GNJjPSvl8l3XkuTK2j68tgjaHRgrq4tyY6fen1qT+A0I6awk6Rno1TkVyP6FDtz9vg7lrir8L4ouvxsCXumHt+RhuCTuH8DTMvIjPKOkCYDjahz/V/jRbL9AdOkgdhy7yZ5IqllrkoSCrtX61PrF+573E20hMn7a41fWfNHqtFYVQPBjzJe7v9gozCNpCzLRnaqVg==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Mykyta Poturai <Mykyta_Poturai@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Mirela
 Simonovic <mirela.simonovic@aggios.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George
 Dunlap <george.dunlap@citrix.com>,
        Ian Jackson <iwj@xenproject.org>, Jan
 Beulich <jbeulich@suse.com>,
        Wei Liu <wl@xen.org>, Dario Faggioli
	<dfaggioli@suse.com>,
        Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
        Mykyta
 Poturai <mykyta.poturai@epam.com>
Subject: Re: [PATCH 01/19] xen/arm: Implement PSCI system suspend
Thread-Topic: [PATCH 01/19] xen/arm: Implement PSCI system suspend
Thread-Index: AQHY2jgjWfMPRPlYK0auWtHF0HPLyK4E74yA
Date: Sat, 8 Oct 2022 22:00:02 +0000
Message-ID: <87czb2f02o.fsf@hp.mail-host-address-is-not-set>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
 <598de284f5f133a622eca3e120a1aabae0f2a1e2.1665137247.git.mykyta_poturai@epam.com>
In-Reply-To: 
 <598de284f5f133a622eca3e120a1aabae0f2a1e2.1665137247.git.mykyta_poturai@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 28.1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|AS4PR03MB8602:EE_
x-ms-office365-filtering-correlation-id: 2f8e1592-5f6b-4569-0556-08daa978744c
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 yf5baOOLtmQlPH4erOkILZAdM13MYopS9D4GNYZ1goDFkvxpLbvEJ5h1ovSxFsx6IDMbyb94/AKpGTw9LsVoiyF1+hhA9tSK24Y74kUCL9f+C6VG6qCEYQpW8O+wkzS6wWqA/A+K69ZTgkizj6/s6Qe8+0tOZjItjoL6sYB2zJLwrIXgWyv56EVZ2MouCpycFRS3OGUv0uW7DUXLJIusbEOxSXyJMgZmHQFnhKrpIzt+LeE5p8K3cvVid0IbKCruNni7hAqAgYihb4zREyxiVXDIHMTPgt2Wzv3YT5ommrZp1mRFZiWivm0KAIs7FsPWil089Hw9djeyeAYu3Mx2WdW8ZjvTiiHQU9ZisoeDa+30I4cI07QiJNAhHi1MgSbQfZ8XSZxnPqX9IHT0PCzTZS1QHgUWkU6PE+VTj66ujbOvSEHEoXoe+dlLfocD/lPa9Z7zi4KdxLfZDADvxShL/Crll1MQ8UmUrZaf49r3mXTxLXGWG+I89BO27+Olw89AO4c3CpCliXcLvGeZoIIcCbN+iSraXDXvahM53o+S6468bHO1RyqkPQ4fBziipnt/8KXlcidyDTGRWuGcBoajhkbv67I2YTrZK3iahoH3iMpES3XWNfbffzNUjZ0/5fcIezYo+qIIDxodZ/bl5bzkzPOGUOryxNJdG8GrsrZaU3ZXgSIIwYt2A4FJ1TDdC7aaehnt/hjk4Jr8rEc3ra1sC6p9gZiYF4hEOFtWaVyYGKene+WQ/26S0cF9js16yCWEhPYWPYrv/2XsRO8UHs0Ghh2JnetJk2XWnb41GejEsD4=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199015)(4326008)(41300700001)(186003)(91956017)(38070700005)(66946007)(76116006)(66556008)(66476007)(66446008)(64756008)(8676002)(86362001)(83380400001)(6862004)(15650500001)(8936002)(7416002)(30864003)(5660300002)(6506007)(107886003)(6486002)(38100700002)(478600001)(122000001)(71200400001)(316002)(54906003)(6636002)(55236004)(26005)(6512007)(9686003)(2906002)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?5nyI9y6IvhnxzAipY3tsExwBRRELXxq/eC5e52qF+3e0nLhkqt/Omrbh+o?=
 =?iso-8859-1?Q?RcKNT2C2SrRpy4NlfCX9nYeANGH9rdw8OJz2H8Qc18cYdgWBShpuqt+yTr?=
 =?iso-8859-1?Q?S7sNzXnKOvgGnc4/YAbqGr1qwmwxNP+RQ2fC7cwHSfKo6HVb30Xg0dGrRC?=
 =?iso-8859-1?Q?NGn7+/+nUq8Ez+arK/892nwLhd6wyhmG4q6cEhwTcfO+LWkW8rDoIE29SC?=
 =?iso-8859-1?Q?B1NJHROS3YMUpLy4BBEuA0oeiKdia7KPbZqERJ5VMK0knbOvVDNGW2GKTV?=
 =?iso-8859-1?Q?eBvivMooTPCO4eoTETVZAGDcAESNZlZ5Vn4Cjt6TE8GVqxknxO0vCJ95kb?=
 =?iso-8859-1?Q?v3X7UpHoO9XfZYkM/jy5jUhAxYUr4mVqJSPXRtVDb7HwerztfzFRQvDgBT?=
 =?iso-8859-1?Q?spdxVODoTtD9GlA7BPl5itr9LAYdk5xdYJDxhOBLN8edYeT+11JrquSjtx?=
 =?iso-8859-1?Q?Rrf8c6tBiWY9jNIu8YpICuXGZjIXikJU8LWlQEJUYXwWoAIATUzJItXCtk?=
 =?iso-8859-1?Q?rsdMbcP1CbEIGIzVmYNws1KQn0G9j0El6Cy5mOChEfRDcErJgjAS5/uiPq?=
 =?iso-8859-1?Q?M/L8NK9/MEMDZFt+APG0Jxu4qpZlINuIA41VlBeVU1KvVYv2F8LIOyexa3?=
 =?iso-8859-1?Q?y3LPCn2o5Ax9+xU4YrHO92VJ6Vr4Yo0+ICiV5chro7pIj+wVa5c8O/Gou/?=
 =?iso-8859-1?Q?HQQBBBn97ytz8aaRA8CELa9tBfIC2TPflsQFLzIHgGMlpEmwJWvhIhjooi?=
 =?iso-8859-1?Q?MF+c+Xx2oVkIOfBmhbU7vKXe6ueywDkAPlRrTEDdJSNCJN4uSEPB3rjGia?=
 =?iso-8859-1?Q?cz8T/PqDg5hJzdEAcMI/UB4ZveUL9+2K5yiuroFAiN1GksEHN7hilNcz5x?=
 =?iso-8859-1?Q?CfeIsIHx4nTCY87G9V/wtfttr9+TSDezNH/QWyGWQTANUPYL+6wY56MkIM?=
 =?iso-8859-1?Q?iz/CrmgHzS6/0PPKLCu+sO8hyuqb+j41g0K5gsqT7b0LF8JmuPcyRfBI9P?=
 =?iso-8859-1?Q?7JVnT0gC84DWWifZanqEqt6+Lk1gWd/MveSPY3VLK9OT8Usey5yQJ9G/I6?=
 =?iso-8859-1?Q?fFe2P1n4rfqbzENAOmigfIcUwmEOoOWmMjM6EhuronMcZFi1vUU4yBiEtc?=
 =?iso-8859-1?Q?SMu4LAzcNG8CPuLgqjJaR5/kxnfp6nxL4o7SZD7Cm/EUEklsyZHrbt9RS8?=
 =?iso-8859-1?Q?T8SghNM35daN43cV9t1VqjBCpfbm1FiR/1ECRJE63Oa1gFOUCma0NzwVwt?=
 =?iso-8859-1?Q?qs/9nKyq+q65DLzhF9hMww7XQ5xCt2PeRFoZA1awO3dpDEw/PQegfMu9Xk?=
 =?iso-8859-1?Q?1dR6laG9XMwammXaawww+FtOwxUB3UiFAn/IcSKgECrsDhzQb3qfCxNQQh?=
 =?iso-8859-1?Q?ZaDYoRBRMfwOA3DewOW2H9CAj1LaqUDgik40pUiWd/rzkAog//sWQk52Lm?=
 =?iso-8859-1?Q?Ea8E5X8i69fAU2jyyrWTC/URYp7RCciOaat8MRYzaFXc52yHmPyKjfkDJo?=
 =?iso-8859-1?Q?bu1p6g2eyslH7yMLcGV9Yc10GxbsjSXbmE8NYKu66FBn9MBrhbwkW/dOIM?=
 =?iso-8859-1?Q?1YIQN9gccaUTUFJ31C/5NgF51Yop/35ziSb93M3cBZ7/XMniC2WAz6gShR?=
 =?iso-8859-1?Q?TJErcSMG0B7i4Zj9qYUVfsPlbA9ZTm8anSbXhsC/a1TFCfLoIxNnlAvA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f8e1592-5f6b-4569-0556-08daa978744c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2022 22:00:03.8499
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XGJa4pfNSp+1oRysuKicV64efnJw/wgY57NiA3JFxUTM6ldN9HxVWV1jNTqOmaxzJzxueIQxtNAPthOoexqZEWTnEI/qGsfdasHMHIBBRLE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR03MB8602
X-Proofpoint-GUID: baf05AZYT_W3RrThA9UK-Sc07hzGF5ss
X-Proofpoint-ORIG-GUID: baf05AZYT_W3RrThA9UK-Sc07hzGF5ss
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 lowpriorityscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 clxscore=1011
 adultscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210080142


Hi Mykyta,

Mykyta Poturai <Mykyta_Poturai@epam.com> writes:

> From: Mirela Simonovic <mirela.simonovic@aggios.com>
>
> The implementation consists of:
> -Adding PSCI system suspend call as new PSCI function
> -Trapping PSCI system_suspend HVC

AFAIK, this can be SMC as well.

> -Implementing PSCI system suspend call (virtual interface that allows
>  guests to suspend themselves)
>
> The PSCI system suspend should be called by a guest from its boot
> VCPU.

Why such limititation? PSCI standart does not limit choise of a CPU.


> Non-boot VCPUs of the guest should be hot-unplugged using PSCI
> CPU_OFF call prior to issuing PSCI system suspend. Interrupts that
> are left enabled by the guest are assumed to be its wake-up interrupts.
> Therefore, a wake-up interrupt triggers the resume of the guest. Guest
> should resume regardless of the state of Xen (suspended or not).
>
> When a guest calls PSCI system suspend the respective domain will be
> suspended if the following conditions are met:
> 1) Given resume entry point is not invalid
> 2) Other (if any) VCPUs of the calling guest are hot-unplugged
>
> If the conditions above are met the calling domain is labeled as
> suspended and the calling VCPU is blocked. If nothing else wouldn't
> be done the suspended domain would resume from the place where it
> called PSCI system suspend. This is expected if processing of the PSCI
> system suspend call fails. However, in the case of success the calling
> guest should resume (continue execution after the wake-up) from the entry
> point which is given as the first argument of the PSCI system suspend
> call. In addition to the entry point, the guest expects to start within
> the environment whose state matches the state after reset. This means
> that the guest should find reset register values, MMU disabled, etc.
> Thereby, the context of VCPU should be 'reset' (as if the system is
> comming out of reset), the program counter should contain entry point,
> which is 1st argument, and r0/x0 should contain context ID which is 2nd
> argument of PSCI system suspend call. The context of VCPU is set during
> resume path, to prevent it being overwritten by ctxt_switch_from after
> vcpu is blocked and scheduled out.
>
> VCPU is marked as suspended with _VPF_suspended flag. A suspended domain
> will resume after the Xen receives an interrupt which is targeted to the
> domain, unblocks the domain's VCPU, and schedules it in. During the
> vcpu_unblock execution the VCPU is checked for VPF_suspended flag. If
> the flag is present, the context of that VCPU gets cleared and entry
> point/cid are set.
>
> Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
> Signed-off-by: Saeed Nowshadi <saeed.nowshadi@xilinx.com>
> Signed-off-by: Mykyta Poturai <mykyta.poturai@epam.com>
> ---
>  xen/arch/arm/Makefile            |   1 +
>  xen/arch/arm/domain.c            |   4 +
>  xen/arch/arm/suspend.c           | 182 +++++++++++++++++++++++++++++++
>  xen/arch/arm/vpsci.c             |  28 +++++
>  xen/common/sched/core.c          |   8 ++
>  xen/include/asm-arm/domain.h     |   3 +
>  xen/include/asm-arm/perfc_defn.h |   1 +
>  xen/include/asm-arm/psci.h       |   2 +
>  xen/include/asm-arm/suspend.h    |  17 +++
>  xen/include/xen/sched.h          |   3 +
>  10 files changed, 249 insertions(+)
>  create mode 100644 xen/arch/arm/suspend.c
>  create mode 100644 xen/include/asm-arm/suspend.h
>
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index b5913c9d39..07dbbd99a3 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -49,6 +49,7 @@ obj-y +=3D setup.o
>  obj-y +=3D shutdown.o
>  obj-y +=3D smp.o
>  obj-y +=3D smpboot.o
> +obj-y +=3D suspend.o
>  obj-y +=3D sysctl.o
>  obj-y +=3D time.o
>  obj-y +=3D traps.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 23c8b345d4..4110154bda 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -40,6 +40,8 @@
>  #include <asm/vtimer.h>
>  #include <asm/vscmi.h>
> =20
> +#include <public/sched.h>
> +

Do you really need this include?

>  #include "vpci.h"
>  #include "vuart.h"
> =20
> @@ -101,6 +103,8 @@ static void ctxt_switch_from(struct vcpu *p)
>      if ( is_idle_vcpu(p) )
>          return;
> =20
> +    /* VCPU's context should not be saved if its domain is suspended */
> +

Is this a some leftover?

>      p2m_save_state(p);
> =20
>      /* CP 15 */
> diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
> new file mode 100644
> index 0000000000..987ba6ac11
> --- /dev/null
> +++ b/xen/arch/arm/suspend.c
> @@ -0,0 +1,182 @@
> +/*
> + * Copyright (C) 2022 EPAM Systems Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU Lesser General Public License as publis=
hed
> + * by the Free Software Foundation; version 2.1 only. with the special
> + * exception on linking described in file LICENSE.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU Lesser General Public License for more details.
> + */
> +
> +#include <xen/sched.h>
> +#include <asm/cpufeature.h>
> +#include <asm/event.h>
> +#include <asm/psci.h>
> +#include <asm/suspend.h>
> +#include <public/sched.h>
> +
> +struct cpu_context cpu_context;
> +
> +/* Reset values of VCPU architecture specific registers */
> +static void vcpu_arch_reset(struct vcpu *v)
> +{
> +    v->arch.ttbr0 =3D 0;
> +    v->arch.ttbr1 =3D 0;
> +    v->arch.ttbcr =3D 0;
> +
> +    v->arch.csselr =3D 0;
> +    v->arch.cpacr =3D 0;
> +    v->arch.contextidr =3D 0;
> +    v->arch.tpidr_el0 =3D 0;
> +    v->arch.tpidrro_el0 =3D 0;
> +    v->arch.tpidr_el1 =3D 0;
> +    v->arch.vbar =3D 0;
> +    v->arch.dacr =3D 0;
> +    v->arch.par =3D 0;
> +#if defined(CONFIG_ARM_32)
> +    v->arch.mair0 =3D 0;
> +    v->arch.mair1 =3D 0;
> +    v->arch.amair0 =3D 0;
> +    v->arch.amair1 =3D 0;
> +#else
> +    v->arch.mair =3D 0;
> +    v->arch.amair =3D 0;
> +#endif
> +    /* Fault Status */
> +#if defined(CONFIG_ARM_32)
> +    v->arch.dfar =3D 0;
> +    v->arch.ifar =3D 0;
> +    v->arch.dfsr =3D 0;
> +#elif defined(CONFIG_ARM_64)
> +    v->arch.far =3D 0;
> +    v->arch.esr =3D 0;
> +#endif
> +
> +    v->arch.ifsr  =3D 0;
> +    v->arch.afsr0 =3D 0;
> +    v->arch.afsr1 =3D 0;
> +
> +#ifdef CONFIG_ARM_32
> +    v->arch.joscr =3D 0;
> +    v->arch.jmcr =3D 0;
> +#endif
> +
> +    if ( is_32bit_domain(v->domain) && cpu_has_thumbee )
> +    {
> +        v->arch.teecr =3D 0;
> +        v->arch.teehbr =3D 0;
> +    }
> +}
> +
> +
> +static void vcpu_suspend(register_t epoint, register_t cid)
> +{
> +    struct vcpu *v =3D current;
> +
> +    v->arch.suspend_ep =3D epoint;
> +    v->arch.suspend_cid =3D cid;
> +    set_bit(_VPF_suspended, &v->pause_flags);
> +    return;
> +}
> +
> +/*
> + * This function sets the context of current VCPU to the state which is =
expected
> + * by the guest on resume. The expected VCPU state is:
> + * 1) pc to contain resume entry point (1st argument of PSCI SYSTEM_SUSP=
END)
> + * 2) r0/x0 to contain context ID (2nd argument of PSCI SYSTEM_SUSPEND)
> + * 3) All other general purpose and system registers should have reset v=
alues
> + */
> +void vcpu_resume(struct vcpu *v)
> +{
> +
> +    struct vcpu_guest_context ctxt;
> +
> +    /* Make sure that VCPU guest regs are zeroed */
> +    memset(&ctxt, 0, sizeof(ctxt));
> +
> +    /* Set non-zero values to the registers prior to copying */
> +    ctxt.user_regs.pc64 =3D (u64)v->arch.suspend_ep;
> +
> +    if ( is_32bit_domain(v->domain) )
> +    {
> +        ctxt.user_regs.r0_usr =3D v->arch.suspend_cid;
> +        ctxt.user_regs.cpsr =3D PSR_GUEST32_INIT;
> +
> +        /* Thumb set is allowed only for 32-bit domain */
> +        if ( v->arch.suspend_ep & 1 )
> +        {
> +            ctxt.user_regs.cpsr |=3D PSR_THUMB;
> +            ctxt.user_regs.pc64 &=3D ~(u64)1;
> +        }
> +    }
> +#ifdef CONFIG_ARM_64
> +    else
> +    {
> +        ctxt.user_regs.x0 =3D v->arch.suspend_cid;
> +        ctxt.user_regs.cpsr =3D PSR_GUEST64_INIT;
> +    }
> +#endif
> +    ctxt.sctlr =3D SCTLR_GUEST_INIT;
> +    ctxt.flags =3D VGCF_online;
> +
> +    /* Reset architecture specific registers */
> +    vcpu_arch_reset(v);
> +
> +    /* Initialize VCPU registers */
> +    arch_set_info_guest(v, &ctxt);
> +    clear_bit(_VPF_suspended, &v->pause_flags);
> +}
> +
> +int32_t domain_suspend(register_t epoint, register_t cid)
> +{
> +    struct vcpu *v;
> +    struct domain *d =3D current->domain;
> +    bool is_thumb =3D epoint & 1;
> +
> +    dprintk(XENLOG_DEBUG,
> +            "Dom%d suspend: epoint=3D0x%"PRIregister", cid=3D0x%"PRIregi=
ster"\n",
> +            d->domain_id, epoint, cid);
> +
> +    /* THUMB set is not allowed with 64-bit domain */
> +    if ( is_64bit_domain(d) && is_thumb )
> +        return PSCI_INVALID_ADDRESS;
> +
> +    /* Ensure that all CPUs other than the calling one are offline */
> +    for_each_vcpu ( d, v )
> +    {
> +        if ( v !=3D current && is_vcpu_online(v) )
> +            return PSCI_DENIED;
> +    }
> +
> +    //TODO: add support for suspending from any VCPU

How hard it would be to implement?

> +    if (current->vcpu_id !=3D 0)
> +        return PSCI_DENIED;
> +
> +    /*
> +     * Prepare the calling VCPU for suspend (reset its context, save ent=
ry point
> +     * into pc and context ID into r0/x0 as specified by PSCI SYSTEM_SUS=
PEND)
> +     */
> +    vcpu_suspend(epoint, cid);
> +
> +    /*
> +     * The calling domain is suspended by blocking its last running VCPU=
. If an
> +     * event is pending the domain will resume right away (VCPU will not=
 block,
> +     * but when scheduled in it will resume from the given entry point).
> +     */
> +    vcpu_block_unless_event_pending(current);
> +
> +    return PSCI_SUCCESS;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
> index c1e250be59..f4e6e92873 100644
> --- a/xen/arch/arm/vpsci.c
> +++ b/xen/arch/arm/vpsci.c
> @@ -18,6 +18,7 @@
>  #include <asm/vgic.h>
>  #include <asm/vpsci.h>
>  #include <asm/event.h>
> +#include <asm/suspend.h>
> =20
>  #include <public/sched.h>
> =20
> @@ -208,6 +209,11 @@ static void do_psci_0_2_system_reset(void)
>      domain_shutdown(d,SHUTDOWN_reboot);
>  }
> =20
> +static int32_t do_psci_1_0_system_suspend(register_t epoint, register_t =
cid)
> +{
> +    return domain_suspend(epoint, cid);
> +}
> +
>  static int32_t do_psci_1_0_features(uint32_t psci_func_id)
>  {
>      /* /!\ Ordered by function ID and not name */
> @@ -225,6 +231,8 @@ static int32_t do_psci_1_0_features(uint32_t psci_fun=
c_id)
>      case PSCI_0_2_FN32_SYSTEM_OFF:
>      case PSCI_0_2_FN32_SYSTEM_RESET:
>      case PSCI_1_0_FN32_PSCI_FEATURES:
> +    case PSCI_1_0_FN32_SYSTEM_SUSPEND:
> +    case PSCI_1_0_FN64_SYSTEM_SUSPEND:
>      case ARM_SMCCC_VERSION_FID:
>          return 0;
>      default:
> @@ -355,6 +363,26 @@ bool do_vpsci_0_2_call(struct cpu_user_regs *regs, u=
int32_t fid)
>          return true;
>      }
> =20
> +    case PSCI_1_0_FN32_SYSTEM_SUSPEND:
> +    case PSCI_1_0_FN64_SYSTEM_SUSPEND:
> +    {
> +        register_t epoint =3D PSCI_ARG(regs,1);
> +        register_t cid =3D PSCI_ARG(regs,2);
> +        register_t ret;
> +
> +        perfc_incr(vpsci_system_suspend);
> +        /* Set the result to PSCI_SUCCESS if the call fails.
> +         * Otherwise preserve the context_id in x0. For now=20

Looks like there is a trailing space                          ^

> +         * we don't support the case where the system is suspended
> +         * to a shallower level and PSCI_SUCCESS is returned to the=20

And in this line also

> +         * caller.
> +         */
> +        ret =3D do_psci_1_0_system_suspend(epoint, cid);
> +        if ( ret !=3D PSCI_SUCCESS )
> +            PSCI_SET_RESULT(regs, ret);
> +        return true;
> +    }
> +
>      default:
>          return false;
>      }
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 8f4b1ca10d..4e1ea62c44 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -38,6 +38,10 @@
>  #include <xsm/xsm.h>
>  #include <xen/err.h>
> =20
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> +#include <asm/suspend.h>
> +#endif
> +
>  #include "private.h"
> =20
>  #ifdef CONFIG_XEN_GUEST
> @@ -957,6 +961,10 @@ void vcpu_unblock(struct vcpu *v)
>  {
>      if ( !test_and_clear_bit(_VPF_blocked, &v->pause_flags) )
>          return;
> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
> +    if ( test_bit(_VPF_suspended, &v->pause_flags) )
> +        vcpu_resume(v);
> +#endif

This does not look good. I do understant that that was I, who suggested
to add this flag, but I didn't expected that it will get into common code.

Also, this is not justified in the commit message. I remeber that there was
some discussion about why vcpu_block()/vcpu_unblock() could not be used, an=
d
I'd love to see its summary in the commit message.

> =20
>      /* Polling period ends when a VCPU is unblocked. */
>      if ( unlikely(v->poll_evtchn !=3D 0) )
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 413e5a2a18..715841e0b5 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -203,6 +203,9 @@ struct arch_vcpu
>      struct vtimer virt_timer;
>      bool   vtimer_initialized;
> =20
> +    register_t suspend_ep;
> +    register_t suspend_cid;
> +
>      /*
>       * The full P2M may require some cleaning (e.g when emulation
>       * set/way). As the action can take a long time, it requires
> diff --git a/xen/include/asm-arm/perfc_defn.h b/xen/include/asm-arm/perfc=
_defn.h
> index 31f071222b..d71e91a5e4 100644
> --- a/xen/include/asm-arm/perfc_defn.h
> +++ b/xen/include/asm-arm/perfc_defn.h
> @@ -33,6 +33,7 @@ PERFCOUNTER(vpsci_system_reset,        "vpsci: system_r=
eset")
>  PERFCOUNTER(vpsci_cpu_suspend,         "vpsci: cpu_suspend")
>  PERFCOUNTER(vpsci_cpu_affinity_info,   "vpsci: cpu_affinity_info")
>  PERFCOUNTER(vpsci_features,            "vpsci: features")
> +PERFCOUNTER(vpsci_system_suspend,      "vpsci: system_suspend")
> =20
>  PERFCOUNTER(vcpu_kick,                 "vcpu: notify other vcpu")
> =20
> diff --git a/xen/include/asm-arm/psci.h b/xen/include/asm-arm/psci.h
> index 832f77afff..26462d0c47 100644
> --- a/xen/include/asm-arm/psci.h
> +++ b/xen/include/asm-arm/psci.h
> @@ -43,10 +43,12 @@ void call_psci_system_reset(void);
>  #define PSCI_0_2_FN32_SYSTEM_OFF          PSCI_0_2_FN32(8)
>  #define PSCI_0_2_FN32_SYSTEM_RESET        PSCI_0_2_FN32(9)
>  #define PSCI_1_0_FN32_PSCI_FEATURES       PSCI_0_2_FN32(10)
> +#define PSCI_1_0_FN32_SYSTEM_SUSPEND      PSCI_0_2_FN32(14)
> =20
>  #define PSCI_0_2_FN64_CPU_SUSPEND         PSCI_0_2_FN64(1)
>  #define PSCI_0_2_FN64_CPU_ON              PSCI_0_2_FN64(3)
>  #define PSCI_0_2_FN64_AFFINITY_INFO       PSCI_0_2_FN64(4)
> +#define PSCI_1_0_FN64_SYSTEM_SUSPEND      PSCI_0_2_FN64(14)
> =20
>  /* PSCI v0.2 affinity level state returned by AFFINITY_INFO */
>  #define PSCI_0_2_AFFINITY_LEVEL_ON      0
> diff --git a/xen/include/asm-arm/suspend.h b/xen/include/asm-arm/suspend.=
h
> new file mode 100644
> index 0000000000..fbaa414f0c
> --- /dev/null
> +++ b/xen/include/asm-arm/suspend.h
> @@ -0,0 +1,17 @@
> +#ifndef __ASM_ARM_SUSPEND_H__
> +#define __ASM_ARM_SUSPEND_H__
> +
> +int32_t domain_suspend(register_t epoint, register_t cid);
> +void vcpu_resume(struct vcpu *v);
> +
> +#endif
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 3b4ed3a2ab..b2f6d1af28 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -903,6 +903,9 @@ static inline struct domain *next_domain_in_cpupool(
>  /* VCPU is parked. */
>  #define _VPF_parked          8
>  #define VPF_parked           (1UL<<_VPF_parked)
> +/* VCPU is suspended */
> +#define _VPF_suspended       9
> +#define VPF_suspended        (1UL<<_VPF_suspended)
> =20
>  static inline bool vcpu_runnable(const struct vcpu *v)
>  {


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Sat Oct 08 23:20:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 08 Oct 2022 23:20:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418831.663562 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohJ7O-0001WN-3Z; Sat, 08 Oct 2022 23:20:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418831.663562; Sat, 08 Oct 2022 23:20:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohJ7O-0001WG-0Y; Sat, 08 Oct 2022 23:20:30 +0000
Received: by outflank-mailman (input) for mailman id 418831;
 Sat, 08 Oct 2022 23:20:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohJ7M-0001W6-6y; Sat, 08 Oct 2022 23:20:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohJ7L-0004Zb-Px; Sat, 08 Oct 2022 23:20:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohJ7L-00041K-B7; Sat, 08 Oct 2022 23:20:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohJ7L-0006c0-Ai; Sat, 08 Oct 2022 23:20:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PCfs3frdlgtIJeCbuT9NspTiYgm4NnmFHRXBU0qXe2M=; b=D1LkRZYUpmziDPLgzgyBuLyKTl
	AbHPsXrDTzz94CfmttYFAIDj207gV7RLOQVCQdJvUay8ckIT7MTiTOYdcOeuhLOMOQ4F5veYqb0Zx
	JQepiCTu4e8mIMpZAx6OUR5y75PIu7PDO7LjMdhFOf0ZKgJk7/jKdq4JSiUIslsmXMkk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173475-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173475: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a6afa4199d3d038fbfdff5511f7523b0e30cb774
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 08 Oct 2022 23:20:27 +0000

flight 173475 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173475/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                a6afa4199d3d038fbfdff5511f7523b0e30cb774
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    1 days
Failing since        173470  2022-10-08 06:21:34 Z    0 days    3 attempts
Testing same since   173475  2022-10-08 18:11:26 Z    0 days    1 attempts

------------------------------------------------------------
565 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 41571 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 01:18:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 01:18:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418877.663591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohKxR-0000Pq-MK; Sun, 09 Oct 2022 01:18:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418877.663591; Sun, 09 Oct 2022 01:18:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohKxR-0000Pj-JP; Sun, 09 Oct 2022 01:18:21 +0000
Received: by outflank-mailman (input) for mailman id 418877;
 Sun, 09 Oct 2022 01:18:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VjX+=2K=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ohKxQ-0000PY-Ea
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 01:18:20 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80053.outbound.protection.outlook.com [40.107.8.53])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 403d5839-4770-11ed-9377-c1cf23e5d27e;
 Sun, 09 Oct 2022 03:18:17 +0200 (CEST)
Received: from AM5PR0201CA0022.eurprd02.prod.outlook.com
 (2603:10a6:203:3d::32) by AS8PR08MB6616.eurprd08.prod.outlook.com
 (2603:10a6:20b:319::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sun, 9 Oct
 2022 01:18:07 +0000
Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:3d:cafe::a4) by AM5PR0201CA0022.outlook.office365.com
 (2603:10a6:203:3d::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Sun, 9 Oct 2022 01:18:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Sun, 9 Oct 2022 01:18:06 +0000
Received: ("Tessian outbound 7e4a920b87c0:v128");
 Sun, 09 Oct 2022 01:18:06 +0000
Received: from 0f822583eadc.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 483830DC-1096-4343-9FB5-BB312EE722F9.1; 
 Sun, 09 Oct 2022 01:18:00 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0f822583eadc.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sun, 09 Oct 2022 01:18:00 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DBBPR08MB6060.eurprd08.prod.outlook.com (2603:10a6:10:20a::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sun, 9 Oct
 2022 01:17:58 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Sun, 9 Oct 2022
 01:17:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 403d5839-4770-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=m1DbNEFVfWcALmY64XXQbvmSc9A5+iyYoZlif1PnTjPxtw+LrnJholRuUKZW9qAnCYXcyO8C902Qnt7ZPu3S1K3ehik33DQyoWW4PdeyQWeZw7V7GMsgpQ4CBACmTyXTLt2i2FCiWVqB8HT3p2avkAG4FDtrTLeMaPfvbp2dVGYbZgT7OWcf/oc5iiaKVgAf265UHlKr/ZPT468C4FoW1FOsX66KB+ax8rta/plgZkgIVpzwniTEuPsdJKrGjhkwU10j5qQo9sJM2LepmstJ0lvUErAXg8KfVYotKfDtWvRzekur/sGVxDnqIWlue+pTRs1OWwg9CmYhlldlLovWVQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ep38x4U8Qh8AD5F15qbwiIthdByVZrxuVBEAFoGUl18=;
 b=lg8GRhXn1b6WWtcdfa+POT9WAPBtXyPvG7a9+IOaNpHFPZmujLvyyAICUgmiYAPXmcHx1KLhtIKeYEQAL4eFRiRLLA/vlLHUByHmgwpV5fUvNovUrfm8qsEGHB5Lp5V+71pySvH60HsVRqxIhhzFx/E7Fv6YiLtUFUzlgBCu9x3fl43xIdre/4vV6GbpjJO4Y4lPrRGOWqEoDaO23e51y2N/Js20ugOF2EIQp0QJOwK+bk0O+iwEUIVLBW+WB46zaT1c9tEzIyNu98UQw5IYusED/fJsyNWe7cU90osApm2G4C3CBlwSWplHCdbqZQf93XxPv+pQLpRrRE7sPK8Mvg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ep38x4U8Qh8AD5F15qbwiIthdByVZrxuVBEAFoGUl18=;
 b=CfphZB93woGVtwj9IWqgwK0FdquUlrCEiVWuN1R1bn7vZOM/wKjKRrmyBWnzCIUC3wXkx8EkmZD3Z8WatxI5cmd9ynnR65Gu3OkirvO+m0+p473mZlvtiahwavOg0IROeXOJJTKLRt474113cbm1HNFAA/MqzhfKtQxoiPtoQv0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EMfhN/rf6g00JLXU8vwDxmW5UrmlTka0HuNKkoxTk2XxHIecv5nH3FVYyu+ZQm3t9Ta+14hf9XDm/kci0WKeK1fPUMQ3OxvMmzu3dQfLRAfyCYbBqlWte1EVH6/XHqFqno0P3fJ6f4y2ZuNwcKaQJOKgLLWY9XzDbTEiFtgD+cxI4yuGny+s+7pmjtfqHlEBF/06tBEQYvjIHM3+li5lm4sQRuRQbIBEsatteNG/dYa4CrZaU2j73It1C385Q98ieKS62iUNiL2gtzKXurKOw1pSjTPBUgbeiMeftlMpFx5cxA25jcY5hiuHWC92t/y5Xvdz28CLVCCa29wHzD7diQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ep38x4U8Qh8AD5F15qbwiIthdByVZrxuVBEAFoGUl18=;
 b=MflVxZlEuka4Fy6TNC9zlohhf0nOatdbwQer8OO1Qs1D/X4lbfWZuuk1Qh5Rx7H3CHs+uQEWqT9qlkBAQ5NQ2L8g9g0/MdeaaCDoom6m6og6Jkzk31lEQgsoKsJtFVPIokeBZX3Q916ju0OzgdmxPbrFtMd3/xDrNi2mx/uyGmDp8USr5B8wLdt3FAoylohL88HAs5V2U86Z/i81YJkF6eIi+uwvEwBA8/JWwy8nR0yMr41gBpXzC126qSPte8ZZLE2erwutf+DbxUfOelz+0Dh7M+zfcA/kCx6d8jgJJVXR8O60hTnzt8+vLcsXxA0P89siuSR5gH2iB9EnCu/ERw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ep38x4U8Qh8AD5F15qbwiIthdByVZrxuVBEAFoGUl18=;
 b=CfphZB93woGVtwj9IWqgwK0FdquUlrCEiVWuN1R1bn7vZOM/wKjKRrmyBWnzCIUC3wXkx8EkmZD3Z8WatxI5cmd9ynnR65Gu3OkirvO+m0+p473mZlvtiahwavOg0IROeXOJJTKLRt474113cbm1HNFAA/MqzhfKtQxoiPtoQv0=
From: Henry Wang <Henry.Wang@arm.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"xen-announce@lists.xenproject.org" <xen-announce@lists.xenproject.org>,
	"xen-users@lists.xenproject.org" <xen-users@lists.xenproject.org>
Subject: Xen 4.17 rc1
Thread-Topic: Xen 4.17 rc1
Thread-Index: AdjbfFOVLfyYUCOOT7KfcRna0kbjEQ==
Date: Sun, 9 Oct 2022 01:17:58 +0000
Message-ID:
 <AS8PR08MB7991A9E825109AEEE4E155C892219@AS8PR08MB7991.eurprd08.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 206E7502C1898C4CA6935AAEFC823425.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DBBPR08MB6060:EE_|VE1EUR03FT024:EE_|AS8PR08MB6616:EE_
X-MS-Office365-Filtering-Correlation-Id: d4b0eda9-6583-4742-b79c-08daa9941f12
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XzkKDc3VYFLdWdfd7NqwjoQiOSvKwQq13ydzju0wRsbFlj5l6gdc0HuP8zg5Cz05jfcRGFU7yxjqVmIrGFI+99OVrs+iZHL5N1DZMeWPZKiiX/nXUXPXDvjUuLaniS30aDddRPfZzSryYvNZLIhWxZ+kS2JyZB2RgfmhOPevb3LVMGm2y0C+heyRTxNPJtgsWnYjZE55JdPM/h6H4H7TGB14M896f76aN+WVSfx3rYhgebprwbX09gGmJA67KBKgDzJMT4tvjTSAXo0sn5KkKtAoliZrlLrySzvK107Ews4Fm1M+ypFcOha7s19M54d55NbYPhNF25oqXI3WG44Df/VAXsBPy2Q1Syp8CLEplKoX9q16QNviWOHjHGMg0VotQcr3O5o7x1f/YF2VrbkZJPV+uJByfWceBHXDRLrcboiJGZCn9n+bKAiLcVUB1eCsAJOoGyZ6YUhcGsdEKXwywjTKRSXacuarLbwpW1y58DbLkovNdMU/ZCEmZiHC8RPTiWeUGIbzLPIxwBLiypstMrzIcKCErQLgjx23OYNawqvAw+KEuHJsEaHIN0hGJL07cVybjsdl0S5fnGYnfW449xQQFkqR3pz+NlmgIqiL6pv5oIbm1ip8gr9m5+J8EjnJdd4tXrD1HQVJzmqmEAF5fAsT74kFtmWJ3vN5Oq3Z9InPoAiIcjXqoxGkfskZbKCdtgxkCQVXyFIf8kA8ruk6jHezIQq77RNdUu5ZeAGD240qFQmbzUxxUaIdWpgYJrBd7xXEHrOzQKrFTLniQR2pdDZ8fbQqwDnRKIN3uQz+yGs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199015)(6506007)(7696005)(26005)(450100002)(38100700002)(55016003)(122000001)(86362001)(316002)(71200400001)(8676002)(66556008)(66946007)(76116006)(66446008)(64756008)(7116003)(66476007)(966005)(38070700005)(33656002)(186003)(478600001)(9686003)(83380400001)(2906002)(110136005)(5660300002)(52536014)(41300700001)(4744005)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6060
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6aaf2545-65c1-4b45-331a-08daa9941a0d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XARcq1fmWRs3ScodZ5ZL/0+2TVVW7vgM/fRyd9SWkX6ziuV/339xlOD0weHsOFAfr1KFHi0E1G0y4BhQAYC2mv0S8l9OnCKrhzoRm6Sc3eSedcNLsdVTqVtSsEwvpB3hJphXeibnddoR9A8nIjB1zd1mf187uM6QqucPXJ+GApm+bAqipA+E0e2uwa8/QxG11iirgLhV9eDb79ZrljJkVcm4h6CXzb7ILBpA8WmXVRktvahg4ZAZAy6jSLO13SluP7Zd9Ro90Xb6h84VLqxukEserwYkIeZ60yox7LepbCG15yROgLL3HWKi/TKsN4OoqjvV6HWnQ4daYH06Pwb6bkpV8tWJlJq8WcNc2pGoMT5LgvDBf9dRRFwXlfVwxUrm8Zp/jUb+Sr/irMSDxZbVjZek1D/xP21DGzNb5b/EoV0kX9vXVWlDr1x+RLm6cFICC872D0xqDONFaa10LY14pesVXdJgAwJfxpqjiK3wJMZRwE/KocaYXTyPK5YUN82MRLUS8IC+ky7cDbyyLG0b2sUCr3XH+uIY8ATDCmXovqy9YDYEuR0TSaw967l01ct6CcfPO0h4xg3UmrDeAkA4YNN/33J9lptqmY/f061f2b6p0JQWHjri5OokzTG+FbVL05ydwxE4siwn9+RFJXtSnYbtQ27b43rOgTPOeQzcekOdBvPGoVG499qK6IsE55mDy26v4hXo32jbd9Dsnh7B3KHGMIZu4OzBQg/a8jC6WR00npqFLVz+3IZQQ/s52nL7nEkZWiVrjtWlYn9baPcPVw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(36840700001)(46966006)(9686003)(26005)(186003)(110136005)(316002)(82740400003)(81166007)(356005)(478600001)(966005)(36860700001)(33656002)(86362001)(55016003)(40480700001)(83380400001)(47076005)(336012)(6506007)(7696005)(5660300002)(8676002)(4744005)(52536014)(8936002)(82310400005)(70206006)(70586007)(450100002)(2906002)(7116003)(41300700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2022 01:18:06.5889
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d4b0eda9-6583-4742-b79c-08daa9941f12
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6616

Hi all,

Xen 4.17 rc1 is tagged. You can check that out from xen.git:

git://xenbits.xen.org/xen.git 4.17.0-rc1

For your convenience there is also a tarball at:
https://downloads.xenproject.org/release/xen/4.17.0-rc1/xen-4.17.0-rc1.tar.=
gz

And the signature is at:
https://downloads.xenproject.org/release/xen/4.17.0-rc1/xen-4.17.0-rc1.tar.=
gz.sig

Please send bug reports and test reports to xen-devel@lists.xenproject.org.
When sending bug reports, please CC relevant maintainers and me
(Henry.Wang@arm.com).

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 05:50:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 05:50:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418889.663602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohPCA-0004UP-0D; Sun, 09 Oct 2022 05:49:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418889.663602; Sun, 09 Oct 2022 05:49:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohPC9-0004UI-TA; Sun, 09 Oct 2022 05:49:49 +0000
Received: by outflank-mailman (input) for mailman id 418889;
 Sun, 09 Oct 2022 05:49:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohPC8-0004U8-VV; Sun, 09 Oct 2022 05:49:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohPC8-0006tR-Sd; Sun, 09 Oct 2022 05:49:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohPC8-0003eG-CV; Sun, 09 Oct 2022 05:49:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohPC8-0002b2-Al; Sun, 09 Oct 2022 05:49:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4CBPUYnLX9Fos0QdYlVS4a8c/pl4IULDvP5jcySAfg0=; b=tLEMRu9tVB8tliJ2hnWogcKhLE
	aIwHSsyNWRc7x+0GhWy3nbOHeuH3iT/EU7K5EKJmTDdCl0RaHXzN+MSf6YC9dxxRxdPL2IFX8zYow
	5xo+km7EcSLbOEfLv2BmgrdvrmwSbYhyT37s8XWIPWsWkucxnLxsYxYrXIu8JnNX+mzs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173476-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173476: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a6afa4199d3d038fbfdff5511f7523b0e30cb774
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 09 Oct 2022 05:49:48 +0000

flight 173476 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173476/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl           8 xen-boot                   fail pass in 173475
 test-arm64-arm64-examine      8 reboot                     fail pass in 173475
 test-armhf-armhf-libvirt-qcow2  8 xen-boot                 fail pass in 173475
 test-armhf-armhf-xl-credit1   8 xen-boot                   fail pass in 173475

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173475 like 173462
 test-arm64-arm64-xl         15 migrate-support-check fail in 173475 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173475 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                a6afa4199d3d038fbfdff5511f7523b0e30cb774
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    1 days
Failing since        173470  2022-10-08 06:21:34 Z    0 days    4 attempts
Testing same since   173475  2022-10-08 18:11:26 Z    0 days    2 attempts

------------------------------------------------------------
565 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 41571 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 07:25:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 07:25:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418899.663613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohQgo-00070C-0y; Sun, 09 Oct 2022 07:25:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418899.663613; Sun, 09 Oct 2022 07:25:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohQgn-000705-Sm; Sun, 09 Oct 2022 07:25:33 +0000
Received: by outflank-mailman (input) for mailman id 418899;
 Sun, 09 Oct 2022 07:25:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jWcR=2K=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ohQgl-0006zx-MY
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 07:25:32 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50060.outbound.protection.outlook.com [40.107.5.60])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c03bd00-47a3-11ed-9377-c1cf23e5d27e;
 Sun, 09 Oct 2022 09:25:27 +0200 (CEST)
Received: from DB8P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::31)
 by DU0PR08MB9323.eurprd08.prod.outlook.com (2603:10a6:10:41e::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sun, 9 Oct
 2022 07:25:24 +0000
Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:130:cafe::7) by DB8P191CA0021.outlook.office365.com
 (2603:10a6:10:130::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Sun, 9 Oct 2022 07:25:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Sun, 9 Oct 2022 07:25:24 +0000
Received: ("Tessian outbound d354c7aef2bc:v128");
 Sun, 09 Oct 2022 07:25:24 +0000
Received: from 634525224f6b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2081EC75-5BBB-44E8-BC07-46825C757132.1; 
 Sun, 09 Oct 2022 07:25:18 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 634525224f6b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sun, 09 Oct 2022 07:25:18 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by DU0PR08MB9680.eurprd08.prod.outlook.com (2603:10a6:10:444::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Sun, 9 Oct
 2022 07:25:14 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684%4]) with mapi id 15.20.5676.028; Sun, 9 Oct 2022
 07:25:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c03bd00-47a3-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=TRQXSXuShkTTpttDVFogQldPI2yKzgg16DGAe+2EDe5UetiDgkoGRaPBa6Wqye/Xnd76aWLD2H+1KpNF2T6XPYCWGqlpABw3Voe7SOCADSz25+RSQy68XaK5OvA+G1mypUueaNLyXm18YtbMV+I1QCATCJqD6tHuv+uLky+on/tE6iWNXfJCNvcuMy0WiUIR46v3zovvzGlDOEKqSa58sxVLXz7MKXIKK+1dG5txgv8ZjyNAZen6P4weoPYsNCos12+ZxjadzaTcJKCKqnXTnSIixNgxE5fcdXAOLGlfnEYsD67UwS3WnrTIppr4yPwZmg+7IZJiInuXjaFcQ8HSow==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3RmasekNwVZi3GCrRiO0Y6AzzYy2ZSdK+KPVikoIS2I=;
 b=U7XXoJBx9Q77mm/Ku3sGwALbOqiRxvg7qT4mGRjxJl1R+zZMzBSt5sGmD8egIM9avUdcH9vevTghDLW2MN8azQbtjQt6BgMtgJ+23ebOVXOSjp/CktHozLuTLmGzDYMGBSGIkbzQR8FxewEdFD8fPiMrrt9aJhaFq6LAFJ7XYq1rXDvcFjE9EhvFKt6rEFCf+9Ij+p+jAxS38DcRPFtTqyg/BH46s2whcI3tUpFPXLUei1mXejuSVGl4roozH6rOZpFzSR36WldXsVn6W2cvVPid5JJmGEIDiYcu4MpJyj2oVZ9MkZ/t2HyktVBFE/+xojise0zLC0341oRrhRBq9A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3RmasekNwVZi3GCrRiO0Y6AzzYy2ZSdK+KPVikoIS2I=;
 b=4MIqF38b6aHYmST2ZndjMqJ+kGMXxkRJhRopYDqJPIgvwM+XwnlEyvp9753VYwYVfJX9ToTTHmVJwo3bj6twRj13qhVuTavpHTclv3Z8xGEyqQBt83pvXbcG9mX++TP9bKLDvfYkOEn/mHJL7/HXLVga3pXlRJgkJ2559w7WNTg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TITeQl0G8RYlii/zj2Svt5DvV0W4rT6wSbBiZAsEHXUaFFUvCbrj1hjNRbF7VG2BjvEJSg7D2mPSkc6DEDwkLACoTGjhsiwCzZg8ODmwszUjC0fE6T90EKJFt79AMM6Y7zG0kUxAx0hjZQLLDS0FBprDmk6fgNuK52hFUUg3OGN2tU/8sLAnFjXIbcC6fJX8HwHIbWrjgpIQHGatWEQnlANdowgZmioZ1m8ZgRjtNdoRwT3C5SiXQcQ3y8/vFTRTISSCkEaoj9doVlVoTvcqcRe3twYbmUoSdz9HcolyGb/L+i2i/IrlisL/V/XFQeYaiO8jQ3PHjhwuL2zA70GG8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3RmasekNwVZi3GCrRiO0Y6AzzYy2ZSdK+KPVikoIS2I=;
 b=NVPZwTCDEkxlad4YkgUUHlFUkCp89amDuKBZs94UTvCgZ+3WtIXV4EI5aHT8xI6bsOsxE9fofAmxKehoL8taYecBF110NODNXnCnv391uglIQ8/Ie16kLNhnDhVozycB+A10CGOwRlJHEVh38E8XF9ojB1Mh8qMiK3IGVcWbyALYUNx9siLqHZTrrR02aMQw8PUlDTHH5aY6haqSFklgOSNACtktjK3juJpJDRD5AvZ/UQxvFD41fbDszAMrh5UEIK9hYFlZz/NaLt+x1D5JXAuta2DNAWsRQrMvRE0CJ9LIMgUiECfMkAtqoqyBKyjLEam2i/qcQmrVmGCfP03JsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3RmasekNwVZi3GCrRiO0Y6AzzYy2ZSdK+KPVikoIS2I=;
 b=4MIqF38b6aHYmST2ZndjMqJ+kGMXxkRJhRopYDqJPIgvwM+XwnlEyvp9753VYwYVfJX9ToTTHmVJwo3bj6twRj13qhVuTavpHTclv3Z8xGEyqQBt83pvXbcG9mX++TP9bKLDvfYkOEn/mHJL7/HXLVga3pXlRJgkJ2559w7WNTg=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to
 common
Thread-Topic: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to
 common
Thread-Index:
 AQHYzNExhaWvtVxVf06aoC2sQxI0u63zd60AgAKngwCAAEMigIAA3nNwgABKNYCADjuwgA==
Date: Sun, 9 Oct 2022 07:25:14 +0000
Message-ID:
 <PAXPR08MB7420DE5F342F17E77F5483879E219@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20220920091218.1208658-1-wei.chen@arm.com>
 <20220920091218.1208658-6-wei.chen@arm.com>
 <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com>
 <fc03f565-8c05-e310-fa0a-698ad7c569e3@arm.com>
 <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com>
 <PAXPR08MB742077FE40B3FB0614787B599E569@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <9c32c4a9-d319-8886-c026-f33820a4f77b@suse.com>
In-Reply-To: <9c32c4a9-d319-8886-c026-f33820a4f77b@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B59D858B5E2C6A48B24AD788ED6A7FF4.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	PAXPR08MB7420:EE_|DU0PR08MB9680:EE_|DBAEUR03FT022:EE_|DU0PR08MB9323:EE_
X-MS-Office365-Filtering-Correlation-Id: 9e8747d7-a171-4d1a-9124-08daa9c76e6c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 +Dbo+CRNI3Xd7I5Ndjq+V8Bx906o4qIo7AA/T1oSimHzXRakQYOsdnVvo/uyyrpuVvuk7qApsNYXMICl1awe11I1+ubVNMwtoi6rLQDHwRwYgSfOBIZgtc5WuE3HjOxGerR+YwKZFkkG/3xfgesxGLjiirLO9Z7+I/+n5Rvp3Cv+nsFTNGXywAicfrmnVMv7MdxIGZgrBvOftS0DJf/zkjkr3E7CAvdOvX0fSM9w09/9IFj3R6xUptsYbHz2OdEMJs0qgn/3tglDY8TQ9QRjQ7Gk2H2EqsDgx1T978G/KKmv0ke2Jbl/rBQLuYU6+Lrwun9taEj3Ss3TTtsc7MTxOFXGXKgih1Oo4xkjGr6AFAtuiGRPYuPQLU9fLF9wXVFxiCuzAX4so7tFpkhFNMvYU4L/SC/x4SHM653liiK06C1EcUgII92eGpF0RmJlax9Okf25FSiG9nTuhtCsVD7Xo+0N0ZAHVbE1km7LNDbOfkKKqTL+hMqL3h5+d6QkerNwFE8FtyZzjXh58ouhJuh5ZroL4MwzFUcQ2/G3CHpOC7XQbtPdUXCDNkERSLhtthk/ecIN/GVdbJevr+lyJkVzLvUBGkPHHCqaAfZTUGKQUrev72W44Qc1ckvnWCweIc3KnCdyb+8Av8pFvpwIv4OHfxyFhLwOdaWoOtsDDixVJQGCzF6hR/LGRtIdC3uLQ9V+mvnOU66ASFDw+7S5jxSQsHMfgi8VGzudaTRsQt/B3LG7+2LakyBnlL9WO7rIK7ogEAwWUUCwlRfqWiVp0ypTyg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199015)(38100700002)(55016003)(86362001)(64756008)(66556008)(8676002)(4326008)(66476007)(54906003)(6916009)(38070700005)(76116006)(5660300002)(41300700001)(83380400001)(53546011)(8936002)(478600001)(26005)(186003)(52536014)(2906002)(9686003)(71200400001)(33656002)(6506007)(7696005)(122000001)(66446008)(316002)(66946007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9680
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ea2f5ec8-373d-4ecf-3928-08daa9c768d5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xPlf2ani9+lmsfFx/tGPGQoN2rnVW3VKao4sxOfUaEl3153zmWxNR4PqA9aS87DMTfGVY/veDfgHr4zwa743Gxwvz7DVNuyUe65ZGsg/vylNPpJVLuL2gKPaWl0AQjH+ZPVs5XgrSCRDSEOrjXHiWW7dhf85XIlpEM7pqaRXkmL0SSsckvl5j0osZ7Md/6qPMwn7kg67U7ZTuoGUv9dvIzVJZezSkUr/cJQM21eGDVwqIhoUPJusJYUfQy+i2DdKYt+pkodDOeQvpJLoczIuyam3mA1ot/HuUp2GbBdQzAvc8UaUe445Gn7+PWN5A0UoVr7HRBCFbKg0Di3PQBoFNHq741gZ4S1eAcgcYA+yp3I9kdQpHPJkH76b0lY37MMOHYcKSazFIjnKei6WTrKCZLc6xtV9Hfms0ACf/zPB79I8mmJyU8qzZ5NmEerOIsuDNKelM7aDXrgj6CYl1EIm7ax0DRLL7LoyRVLrfC8JLQZ9pn9tmRVcuN3Y3JxpzFxdNJZZ3V24Vzn9ctAh/K/bcuBYOfZtHZe1KVNkZZLd8jzBStxj+dyzWVdSoOEUZakW2Iq7AWNqXgi4ayV0PAFVxTfxGT7a7yj/4+7buIEsbSlsLXdy9fJb3+GKy8H80ltLKSm233sEKOaurMfsoVV+Zqkk+zNXZsR5EtjXezA20H06Cb3F/9q9RPUytdWFHhPUSfazsTAks6MdWu+tePd8ZhkVZ1CVaPQ1/IA3yoLPdzhApK+B224rNDzmivmJjq6/
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(36840700001)(46966006)(356005)(81166007)(5660300002)(82310400005)(478600001)(33656002)(54906003)(2906002)(316002)(7696005)(6506007)(36860700001)(55016003)(86362001)(40480700001)(70586007)(186003)(4326008)(70206006)(336012)(6862004)(82740400003)(9686003)(8676002)(52536014)(41300700001)(8936002)(83380400001)(26005)(53546011)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2022 07:25:24.2541
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e8747d7-a171-4d1a-9124-08daa9c76e6c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9323

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDnmnIgzMOaXpSAxNDowMw0K
PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y
Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1
bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU
Q0ggdjUgNS82XSB4ZW4veDg2OiBtb3ZlIE5VTUEgc2NhbiBub2RlcyBjb2RlcyBmcm9tIHg4Ng0K
PiB0byBjb21tb24NCj4gDQo+IE9uIDMwLjA5LjIwMjIgMDM6NDAsIFdlaSBDaGVuIHdyb3RlOg0K
PiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKYW4gQmV1bGljaCA8
amJldWxpY2hAc3VzZS5jb20+DQo+ID4+IFNlbnQ6IDIwMjLlubQ55pyIMjnml6UgMjA6MjENCj4g
Pj4NCj4gPj4gT24gMjkuMDkuMjAyMiAxMDoyMSwgV2VpIENoZW4gd3JvdGU6DQo+ID4+PiBPbiAy
MDIyLzkvMjcgMjM6NDgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+Pj4+IE9uIDIwLjA5LjIwMjIg
MTE6MTIsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4+PiAtLS0gYS94ZW4vZHJpdmVycy9hY3BpL0tj
b25maWcNCj4gPj4+Pj4gKysrIGIveGVuL2RyaXZlcnMvYWNwaS9LY29uZmlnDQo+ID4+Pj4+IEBA
IC03LDQgKzcsNSBAQCBjb25maWcgQUNQSV9MRUdBQ1lfVEFCTEVTX0xPT0tVUA0KPiA+Pj4+Pg0K
PiA+Pj4+PiAgIGNvbmZpZyBBQ1BJX05VTUENCj4gPj4+Pj4gICAJYm9vbA0KPiA+Pj4+PiArCXNl
bGVjdCBIQVNfTlVNQV9OT0RFX0ZXSUQNCj4gPj4+Pj4gICAJc2VsZWN0IE5VTUENCj4gPj4+Pg0K
PiA+Pj4+IFdoaWxlIEkgbWlnaHQgZ3Vlc3MgdGhhdCB5b3UndmUgY2hvc2VuIHRoZSBpbnNlcnRp
b24gcG9pbnQgdG8gaGF2ZQ0KPiA+Pj4+IHRoaW5ncyBzb3J0ZWQgYWxwaGFiZXRpY2FsbHksIEkg
dGhpbmsgaGVyZSBpdCB3b3VsZCBiZSBtb3JlIG5hdHVyYWwNCj4gPj4+PiB0byBzZWxlY3QgdGhl
IHdpZGVyIG9wdGlvbiBmaXJzdCBhbmQgdGhlbiBhbHNvIHNlbGVjdCB0aGUgbW9yZQ0KPiA+Pj4+
IG5hcnJvdyBvbmUuDQo+ID4+Pj4NCj4gPj4+DQo+ID4+PiBPaywgSSB3aWxsIGFkanVzdCB0aGUg
b3JkZXIuDQo+ID4+Pg0KPiA+Pj4+IE9uZSBmdXJ0aGVyIHF1ZXN0aW9uIHRob3VnaDogSG93IGlz
IHRoaXMgZ29pbmcgdG8gd29yayBmb3IgQXJtNjQNCj4gPj4+PiBvbmNlIGl0IHdhbnRzIHRvIHN1
cHBvcnQgYm90aCB0aGUgZm9ybSBvZiBOVU1BIHlvdSdyZSB3b3JraW5nIHRvDQo+ID4+Pj4gZW5h
YmxlIF9hbmRfIEFDUEktYmFzZWQgTlVNQT8gVGhlcmUgYmV0dGVyIHdvdWxkbid0IGJlIGEgcmVx
dWlyZW1lbnQNCj4gPj4+PiB0byBwaWNrIG9uZSBvZiB0aGUgdHdvIGF0IGJ1aWxkIHRpbWUgLSBp
dCB3b3VsZCBiZSBuaWNlIGZvciBzdXBwb3J0DQo+ID4+Pj4gb2YgYm90aCBmb3JtcyB0byBiZSBh
YmxlIHRvIGNvLWV4aXN0IGluIGEgc2luZ2xlIGJpbmFyeS4NCj4gPj4+DQo+ID4+PiBXZSBhcmUg
YWxzbyB3b3JraW5nIGluIHRoaXMgd2F5LiBJbiBwYXJ0IzMsIHdlIHdpbGwgY2hlY2sgQUNQSSBm
aXJzdCwNCj4gPj4+IG9ubHkgd2hlbiBBQ1BJIGlzIG9mZiwgdGhlIERUIE5VTUEgd2lsbCBiZSB1
c2VkIGJ5IEFybS4gSWYgQUNQSSBpcyBvbiwNCj4gPj4+IHdlIHdpbGwgc2tpcCBEVCBOVU1BLg0K
PiA+Pg0KPiA+PiBFdmVuIG1vcmUgc28gYW4gYW5zd2VyIHRvIG15IHF1ZXN0aW9uIHdvdWxkIGJl
IG5pY2U6IFlvdSdsbCB0aGVuIGhhdmUNCj4gPj4gQ09ORklHX0hBU19OVU1BX05PREVfRldJRD15
IGV2ZW4gb24gQXJtICh1c2luZyBQWE0gYXMgbWFuZGF0ZWQgYnkgQUNQSQ0KPiA+PiB3aGVuIGlu
IEFDUEkgbW9kZSkuIEJ1dCB0aGVuIHdoYXQncyB0aGUgRldJRCBmb3IgRFQ/IEkga25vdyBpdCB3
YXMgbWUNCj4gPj4gdG8gc3VnZ2VzdCB0aGlzIGJ1aWxkIHRpbWUgZGlzdGluY3Rpb24sIGJ1dCBJ
J20gYWZyYWlkIEkgd2Fzbid0IGRvaW5nDQo+ID4+IG11Y2ggZ29vZCB3aXRoIHRoYXQgKGFuZCBJ
J20gc29ycnkpLg0KPiA+DQo+ID4gSG93IGFib3V0IGludHJvZHVjaW5nIGEgZmxhZyBmb3Igc2Vs
ZWN0ZWQgTlVNQSBpbXBsZW1lbnRhdGlvbiB0bw0KPiA+IHNldCBpdCBpbiBydW50aW1lPw0KPiA+
IEZvciBleGFtcGxlOg0KPiA+IGJvb2wgbnVtYV9oYXNfZndfbm9kZWlkOw0KPiA+DQo+ID4gQUNQ
SSBOVU1BIHdpbGwgc2V0IHRoaXMgZmxhZyB0byAxLCBidXQgMCBmb3IgRFQgTlVNQS4NCj4gDQo+
IFRoYXQncyBhbiBvcHRpb24gYWxvbmdzaWRlIGdvaW5nIGJhY2sgdG8gd2hhdCB5b3UgaGFkIGlu
IGFuIGVhcmxpZXINCj4gdmVyc2lvbi4gQW5vdGhlciB3b3VsZCBiZSAobmFtZSBzdWJqZWN0IHRv
IGltcHJvdmVtZW50KQ0KPiANCj4gY29uc3QgY2hhciAqX19yb19hZnRlcl9pbml0IG51bWFfZndf
bmlkX25hbWU7DQo+IA0KPiB3aGljaCBmb3IgQUNQSSB3b3VsZCBiZSBzZXQgdG8gIlBYTSIgKGVs
aW1pbmF0aW5nIHRoZSBuZWVkIHRvIHBhc3MNCj4gaXQgdG8gY2VydGFpbiBmdW5jdGlvbnMsIGFs
YmVpdCB0aGUgZndfbmlkIHdpbGwgY29udGludWUgdG8gbmVlZCB0bw0KPiBiZSBwYXNzZWQgYW55
d2F5KS4gSSBndWVzcyBJJ20gbm90IHJlYWxseSBjZXJ0YWluIHdoaWNoIG9mIHRoaXMgYW5kDQo+
IHlvdXIgZWFybGllciBhcHByb2FjaCBJIHByZWZlcjsgdGhlIGJvb2xlYW4geW91IHN1Z2dlc3Qg
YWJvdmUgbG9va3MNCj4gbGVzcyBkZXNpcmFibGUgdG8gbWUsIHRob3VnaC4NCj4gDQoNCk9rLCBJ
IHdpbGwgZm9sbG93IHlvdXIgc3VnZ2VzdGlvbi4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0KPiBK
YW4NCg==


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 09:07:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 09:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418927.663624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSHO-0001i5-Pd; Sun, 09 Oct 2022 09:07:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418927.663624; Sun, 09 Oct 2022 09:07:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSHO-0001hy-Ms; Sun, 09 Oct 2022 09:07:26 +0000
Received: by outflank-mailman (input) for mailman id 418927;
 Sun, 09 Oct 2022 09:07:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohSHN-0001ho-2G; Sun, 09 Oct 2022 09:07:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohSHM-0002mG-UX; Sun, 09 Oct 2022 09:07:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohSHM-0006GJ-D2; Sun, 09 Oct 2022 09:07:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohSHM-0002Kl-CT; Sun, 09 Oct 2022 09:07:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A6aElLqnh32dya9xh+eh4tpUlF5A5Kx744demjNprsc=; b=XQyPPErgRnW0ccArDQFhx1FjnR
	3ZscJbCnpdowIGwUnCbu8+xkm7O3ahvxyHvIEh4lfazZ4FhSmRDltUa0/GIpG2LNQpeKmfcuCGLn8
	EIlpnY60dTslen0oMSRyQi+CKSCEvpIvK/RLQfOjboe7m9jzaU2kXXfBZeimKZrmUkQE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173477-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173477: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start.2:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 09 Oct 2022 09:07:24 +0000

flight 173477 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173477/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 173466 pass in 173477
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173466 pass in 173477
 test-armhf-armhf-xl-arndale   8 xen-boot                   fail pass in 173466
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173466
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173466
 test-armhf-armhf-xl-rtds     19 guest-start.2              fail pass in 173466

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 173466 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 173466 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173466
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173466
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173466
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173466
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173466
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173466
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173466
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173466
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173466
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173466
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173466
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173466
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173477  2022-10-09 01:53:41 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 09:30:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 09:30:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418936.663634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSe0-0005C7-R2; Sun, 09 Oct 2022 09:30:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418936.663634; Sun, 09 Oct 2022 09:30:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSe0-0005C0-ON; Sun, 09 Oct 2022 09:30:48 +0000
Received: by outflank-mailman (input) for mailman id 418936;
 Sun, 09 Oct 2022 09:30:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohSdz-0005Bu-2i
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 09:30:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSdv-0003Dn-Cu; Sun, 09 Oct 2022 09:30:43 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSdv-0000od-50; Sun, 09 Oct 2022 09:30:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=FWgU6+2ftm+DVwYPLX3NI2/OKNW1Iztel4h2ct3GwrQ=; b=47KdhBLVUmiId+7daTwGFLwWIX
	Xs328OUJFClP0nkdse2NkAa9AKB7HDCvQ4UZMQ72PWjPsgeG+OrPCdRaNbMbmAMno4EaVYgyCQQXn
	lzfYE+UW2KK1g6pRAEW7twOC4zuaQDH+ocItegyoCsY9AQhu0n7g5qfboyMh1ctsOAPY=;
Message-ID: <aae228af-a939-0f51-0496-167c03107a6c@xen.org>
Date: Sun, 9 Oct 2022 10:30:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Mykyta Poturai <Mykyta_Poturai@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Mirela Simonovic <mirela.simonovic@aggios.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 Dario Faggioli <dfaggioli@suse.com>,
 Saeed Nowshadi <saeed.nowshadi@xilinx.com>,
 Mykyta Poturai <mykyta.poturai@epam.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
 <598de284f5f133a622eca3e120a1aabae0f2a1e2.1665137247.git.mykyta_poturai@epam.com>
 <87czb2f02o.fsf@hp.mail-host-address-is-not-set>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH 01/19] xen/arm: Implement PSCI system suspend
In-Reply-To: <87czb2f02o.fsf@hp.mail-host-address-is-not-set>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/10/2022 23:00, Volodymyr Babchuk wrote:
>> diff --git a/xen/arch/arm/suspend.c b/xen/arch/arm/suspend.c
>> new file mode 100644
>> index 0000000000..987ba6ac11
>> --- /dev/null
>> +++ b/xen/arch/arm/suspend.c
>> @@ -0,0 +1,182 @@
>> +/*
>> + * Copyright (C) 2022 EPAM Systems Inc.

Not related to Volodymyr's answer but I will reply here as I noticed it.

The code was written in 2018 by Aggios. So shouldn't this be a 2018 
copyright from Aggios? You can add yours on top if you want but it is 
not super clear what has been modified (a changelog after --- in the 
commit message would have been useful).

>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU Lesser General Public License as published
>> + * by the Free Software Foundation; version 2.1 only. with the special
>> + * exception on linking described in file LICENSE.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU Lesser General Public License for more details.
>> + */

We are not allowing LGPL* license in the hypervisor. This has to be 
GPLv2-only (this was the original contribution even if there were no 
copyright).

But it would be better to use an SPDX tag as it makes clearer which 
license is used (see [1]).

[...]

>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
>> index 8f4b1ca10d..4e1ea62c44 100644
>> --- a/xen/common/sched/core.c
>> +++ b/xen/common/sched/core.c
>> @@ -38,6 +38,10 @@
>>   #include <xsm/xsm.h>
>>   #include <xen/err.h>
>>   
>> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
>> +#include <asm/suspend.h>
>> +#endif
>> +
>>   #include "private.h"
>>   
>>   #ifdef CONFIG_XEN_GUEST
>> @@ -957,6 +961,10 @@ void vcpu_unblock(struct vcpu *v)
>>   {
>>       if ( !test_and_clear_bit(_VPF_blocked, &v->pause_flags) )
>>           return;
>> +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
>> +    if ( test_bit(_VPF_suspended, &v->pause_flags) )
>> +        vcpu_resume(v);
>> +#endif
> 
> This does not look good. I do understant that that was I, who suggested
> to add this flag, but I didn't expected that it will get into common code.

AFAIU, you are using the flag to indicate whether the vCPU should be 
reset. If I am not mistaken, this should only happen for vCPU0 (other 
vCPUs will be brought up using PSCI CPU ON). So you could reset the vCPU 
before blocking it.

With that, the flag should not be necessary (at least in this situation).

> 
> Also, this is not justified in the commit message. I remeber that there was
> some discussion about why vcpu_block()/vcpu_unblock() could not be used, and
> I'd love to see its summary in the commit message.

Are you referring to the discussion in [2]?

Cheers,

[1] 20221008001544.78302-2-sstabellini@kernel.org
[2] 1542022244-22977-3-git-send-email-mirela.simonovic@aggios.com

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 09:33:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 09:33:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418943.663646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSgR-0005lj-7i; Sun, 09 Oct 2022 09:33:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418943.663646; Sun, 09 Oct 2022 09:33:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSgR-0005lc-4n; Sun, 09 Oct 2022 09:33:19 +0000
Received: by outflank-mailman (input) for mailman id 418943;
 Sun, 09 Oct 2022 09:33:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohSgQ-0005lW-Mm
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 09:33:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSgP-0003GY-Sq; Sun, 09 Oct 2022 09:33:17 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSgP-00012i-NE; Sun, 09 Oct 2022 09:33:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=F1ux7XQQtYKI0ztKv4YK4GfNC1gooHc2NPnDh6HqJFs=; b=f4sonY+87DApWah7vkdoitvdcG
	jPgNHDKGQl0ClR7nO9QcOjE8MpH1+jQLcSre+jKjpYo/VIm69D2eMTUbiWRGmsqKC/ewO+DcqiABm
	ghwd7pc2ZGiBBOnb35coJt8rG8EHDFbwgRWmzDk6Ovttbutg27Z2MGb5WV5jG5kZklbw=;
Message-ID: <4c07bd2c-fe8c-9a4c-a7f1-33181596249a@xen.org>
Date: Sun, 9 Oct 2022 10:33:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v3 1/4] Add SPDX to CODING_STYLE
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
 <20221008001544.78302-1-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221008001544.78302-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 08/10/2022 01:15, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
>   CODING_STYLE | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/CODING_STYLE b/CODING_STYLE
> index 3386ee1d90..5faf274b3a 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but often implicitly (Linux
>   coding style is fairly common). In general you should copy the style
>   of the surrounding code. If you are unsure please ask.
>   
> +SPDX
> +----
> +
> +New files should start with a single-line SPDX comment to express the
> +license, e.g.:
> +
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +See LICENSES/ for a list of licenses and SPDX tags currently used.

This directory doesn't yet exist. As Jan wrote in v2, this should be 
populated first (i.e. patch #2 should be before patch #1).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 09:35:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 09:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418949.663656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSic-0006VJ-Je; Sun, 09 Oct 2022 09:35:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418949.663656; Sun, 09 Oct 2022 09:35:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSic-0006VC-H4; Sun, 09 Oct 2022 09:35:34 +0000
Received: by outflank-mailman (input) for mailman id 418949;
 Sun, 09 Oct 2022 09:35:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohSib-0006V4-AL
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 09:35:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSia-0003Jp-Je; Sun, 09 Oct 2022 09:35:32 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSia-00019R-EP; Sun, 09 Oct 2022 09:35:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=862saF05gKQ4XV/omcfxMl00I/ckBJVqGCE7iSsf9uQ=; b=NmBQW1OyJraTLR6EI3zMYBAr/y
	VCxBgtyVK8jHF+hYt3orDSzegmI6TZUlZzzJ17+VoCBorrQx3oO09X1hWFauM2KGPD8C3ej8OVhNC
	kuH0BE/a4sF+csewYUJ8O+oKu1QN3zBR2RL4niRab6659En0n12KRxYECq40wgp9rAUI=;
Message-ID: <3a6c0165-957e-5868-4156-567425eaa3dc@xen.org>
Date: Sun, 9 Oct 2022 10:35:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v3 1/4] Add SPDX to CODING_STYLE
From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
 <20221008001544.78302-1-sstabellini@kernel.org>
 <4c07bd2c-fe8c-9a4c-a7f1-33181596249a@xen.org>
In-Reply-To: <4c07bd2c-fe8c-9a4c-a7f1-33181596249a@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 09/10/2022 10:33, Julien Grall wrote:
> Hi Stefano,
> 
> On 08/10/2022 01:15, Stefano Stabellini wrote:
>> From: Stefano Stabellini <stefano.stabellini@amd.com>
>>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
>> ---
>>   CODING_STYLE | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/CODING_STYLE b/CODING_STYLE
>> index 3386ee1d90..5faf274b3a 100644
>> --- a/CODING_STYLE
>> +++ b/CODING_STYLE
>> @@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but 
>> often implicitly (Linux
>>   coding style is fairly common). In general you should copy the style
>>   of the surrounding code. If you are unsure please ask.
>> +SPDX
>> +----
>> +
>> +New files should start with a single-line SPDX comment to express the
>> +license, e.g.:
>> +
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +
>> +See LICENSES/ for a list of licenses and SPDX tags currently used.
> 
> This directory doesn't yet exist. As Jan wrote in v2, this should be 
> populated first (i.e. patch #2 should be before patch #1).

Actually, even patch #4 should be to avoid temporary conflicting 
information between CODING_STYLE and CONTRIBUTING.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 09:37:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 09:37:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418956.663668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSkX-00075T-VX; Sun, 09 Oct 2022 09:37:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418956.663668; Sun, 09 Oct 2022 09:37:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSkX-00075M-So; Sun, 09 Oct 2022 09:37:33 +0000
Received: by outflank-mailman (input) for mailman id 418956;
 Sun, 09 Oct 2022 09:37:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohSkX-00075G-49
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 09:37:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSkV-0003Lo-TT; Sun, 09 Oct 2022 09:37:31 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSkV-0001FA-Nf; Sun, 09 Oct 2022 09:37:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=6/iCMtOLA08dXbAmWj7rJVwslFm3Y1V5+grt8biXx+4=; b=HwZvoWTDiJHYmtnyeT2GHsyVmX
	P5TL+DfW9m+9YK2qNaR4SNvncSnZr6Qpsi1MwcPMJ+KyXrc79+Rei0lusQoIGcPDeiRm3EhY18U56
	ToNuXHnt+Ih1R9g4r6BdxDnjxaD7Q8XPFj3LEbCrbvItU6hs2vLPQ9PN94kAZHuKLFA8=;
Message-ID: <d0e54afc-d32c-130e-f829-1eb0970c703f@xen.org>
Date: Sun, 9 Oct 2022 10:37:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v3 2/4] Add licenses under LICENSES
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
 <20221008001544.78302-2-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221008001544.78302-2-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 08/10/2022 01:15, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> Add the individual licenses under a new top-level directory named
> "LICENSES". Each license file includes its related SPDX tags.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

I haven't looked at the exact wording of each license. Assuming the 
patch is moved before patch #1:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 09:44:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 09:44:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418963.663679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSrR-00008Q-Op; Sun, 09 Oct 2022 09:44:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418963.663679; Sun, 09 Oct 2022 09:44:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohSrR-00008J-LP; Sun, 09 Oct 2022 09:44:41 +0000
Received: by outflank-mailman (input) for mailman id 418963;
 Sun, 09 Oct 2022 09:44:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohSrQ-00008D-CI
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 09:44:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSrP-0003SI-AB; Sun, 09 Oct 2022 09:44:39 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohSrP-0001de-4A; Sun, 09 Oct 2022 09:44:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=3S5qYAgvcTTdYqX4l2hUDGN/8uOp8UEssYg3PCAUQkY=; b=2w7OmDgDWWllenQslaFkGg7oz/
	bHaAnJJck8fqTIc7HmA/ybQPB2hzsjU8V8ZI1cot2wBV8SSarRUnS1o+bd4I47otaa8KrEkcujDeM
	WLkvfNc1ZMo/S1/jmxwuEutJg8wuLo6qf8PydndRe1F/3Bm5bVH/0Tr4Vc3jE3Be9K7k=;
Message-ID: <b0039c3c-e220-ee65-0756-43d4ebf4adbb@xen.org>
Date: Sun, 9 Oct 2022 10:44:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v3 3/4] add SPDX to arch/arm/*.c
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
 <20221008001544.78302-3-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221008001544.78302-3-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/10/2022 01:15, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> Add SPDX license information to all the *.c files under arch/arm.

It would be helpful to explain in the commit messages how the SPDX was 
decided for file with no copyright license:
   - domain_page.c is a split from mm.c. So the license should be 
unfortunatelY GPLv2+
   - all the others are using the default Xen license so GPLv2.

It is also probably worth to mention that existing copyright are 
*replaced* with a SPDX tag.

With that:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 10:15:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 10:15:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418976.663690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohTKn-0003zO-2b; Sun, 09 Oct 2022 10:15:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418976.663690; Sun, 09 Oct 2022 10:15:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohTKm-0003zH-Vh; Sun, 09 Oct 2022 10:15:00 +0000
Received: by outflank-mailman (input) for mailman id 418976;
 Sun, 09 Oct 2022 10:14:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ohTKl-0003zB-HR
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 10:14:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohTKk-00047M-7U; Sun, 09 Oct 2022 10:14:58 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ohTKk-0002xV-1K; Sun, 09 Oct 2022 10:14:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=gGkiVbiKCcq5WPm6rQqeDJd0L2Y4IZoyaoPOQ/AJXF0=; b=VxcoulwSI1D70k0F1mmzHZ8gnm
	CGM8oS6eb673yeDgvt67XxE/pB1jb/0rH3v50vIyC6vgqJV2gdCi1/4HMppSpeS2dI9Sj4Z+z8r7y
	2kp0GPAfUQUCarIKDBPfGo3iPfQ0zZdWFC5G6hHRlJ7tTf82w8rc4rub/xHbc3SGlIM0=;
Message-ID: <b87e4263-4018-b840-74be-965aec89d187@xen.org>
Date: Sun, 9 Oct 2022 11:14:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
 <20221008001544.78302-4-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3 4/4] Remove extra copies of licenses and license
 headers
In-Reply-To: <20221008001544.78302-4-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 08/10/2022 01:15, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> Remove the extra copy of the GPL license and license copyright headers
> from CONTRIBUTING and the top-level COPYING.
> 
> Mention of the LICENSES/ directory and also mention the SPDX tag.
> 
> SPDX support is still in progress and COPYING files in subdirectories
> still need to be updated.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
> Patch new in v3
> ---
>   CONTRIBUTING | 150 ++--------------------
>   COPYING      | 351 +--------------------------------------------------
>   2 files changed, 17 insertions(+), 484 deletions(-)
> 
> diff --git a/CONTRIBUTING b/CONTRIBUTING
> index 6ec146baf0..7b6b03fb96 100644
> --- a/CONTRIBUTING
> +++ b/CONTRIBUTING
> @@ -19,10 +19,6 @@ Most notably:
>    - tools/xl           : LGPL v2.1
>    - xen/include/public : MIT license
>   
> -The COMMON COPYRIGHT NOTICES section of this document contains
> -sample copyright notices for the most common licenses used within
> -this repository.
> -

How about replacing this section with something like:

" See LICENSES/ for a list of licenses and SPDX tags currently used."

>   When creating new components, new files, or importing code please follow
>   the conventions outlined below. As a general rule, whenever code using a
>   license other than GPLv2 is introduced, attention must be drawn to the
> @@ -32,20 +28,22 @@ deviation. Any new code must be GPLv2 compatible.
>   New components
>   --------------
>   
> -When creating new components and directories that contain a
> -significant amount of files that are licensed under licenses other
> -than GPLv2 or the license specified in the COPYING file, please
> -create a new COPYING file in that directory containing a copy of the
> -license text and a rationale for using a different license. This helps
> -ensure that the license of this new component/directory is maintained
> -consistently with the original intention.
> +When creating new components and directories that contain a significant
> +amount of files that are licensed under licenses other than GPLv2,
> +please create a new COPYING file in that directory with the rationale
> +for using a different license. This helps ensure that the license of
> +this new component/directory is maintained consistently with the
> +original intention.

I don't understand why the wording "or the license specified in the 
COPYING file" is dropped. To me, the sentence was indicating that it is 
not necessary to create a COPYING file in every sub-directory if the 
license is not GPLv2 and it matches the license of a parent directory.

Do you plan to remove COPYING completely?

>   
>   New files
>   ---------
>   
> -If specific files that differ from the license in a directory are introduced,

This is fine to drop but ...

> -exceptions should be highlighted and discussed in the commit message or cover
> -letter introducing the file.

... I think this should be kept because we want to have justification 
why the license of a file doesn't match the license of the directory.

> +New files should start with a single-line SPDX comment to express the
> +license. The following comment and license are recommended:

Someone reading this may think that a new file in libxl wants to be 
GPLv2. So I would add in parentheses that the license may be different 
in some directory.

Similarly, I think this should be stronger than recommended. The SPDX 
should be a *must* and for the license there are effectively little 
leeway in which one we could use for existing components.
So how about:

"For instance, if the file is GPLv2, the comment would look like:

/* SPDX-License-Identifier... */

The recommended license of a directory will depend on the COPYING file. 
If the new file is using a different license, this should be highlighted 
and discussed in the commit message or cover letter introducing the file.
"

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 12:25:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 12:25:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.418995.663702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohVNA-0001Iy-Kc; Sun, 09 Oct 2022 12:25:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 418995.663702; Sun, 09 Oct 2022 12:25:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohVNA-0001Ir-Fn; Sun, 09 Oct 2022 12:25:36 +0000
Received: by outflank-mailman (input) for mailman id 418995;
 Sun, 09 Oct 2022 12:25:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohVN9-0001Ih-15; Sun, 09 Oct 2022 12:25:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohVN8-0006Zd-PM; Sun, 09 Oct 2022 12:25:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohVN8-0002a4-4M; Sun, 09 Oct 2022 12:25:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohVN8-00045w-3u; Sun, 09 Oct 2022 12:25:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lgXVsIx4B4EPgGOclErZ+EDnJkYiw7kUM2i52coYr84=; b=qsyBnrkvwe1eWPaK/Om/zTtlcD
	+y7AcjIFhjncqvEnlW6SflL7zxvJH0Frejycw4I9/KCDta6k4URnLHl82vsBMUxGdiKatGp9BFg6Y
	Izn2uuaFjANDmZk1AVgyk3SideHlhB/yvi2aBvrv6g7MklTcS93Ui4irXgRAsWFNr+eA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173478-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173478: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a6afa4199d3d038fbfdff5511f7523b0e30cb774
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 09 Oct 2022 12:25:34 +0000

flight 173478 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173478/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl           8 xen-boot                   fail pass in 173475
 test-arm64-arm64-examine      8 reboot                     fail pass in 173475
 test-armhf-armhf-libvirt-qcow2  8 xen-boot                 fail pass in 173475
 test-armhf-armhf-xl-credit1   8 xen-boot                   fail pass in 173475

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173475 like 173462
 test-arm64-arm64-xl         15 migrate-support-check fail in 173475 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173475 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                a6afa4199d3d038fbfdff5511f7523b0e30cb774
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    1 days
Failing since        173470  2022-10-08 06:21:34 Z    1 days    5 attempts
Testing same since   173475  2022-10-08 18:11:26 Z    0 days    3 attempts

------------------------------------------------------------
565 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 41571 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 19:30:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 19:30:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419019.663712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohbzh-0003ei-OE; Sun, 09 Oct 2022 19:29:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419019.663712; Sun, 09 Oct 2022 19:29:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohbzh-0003eb-LG; Sun, 09 Oct 2022 19:29:49 +0000
Received: by outflank-mailman (input) for mailman id 419019;
 Sun, 09 Oct 2022 19:29:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohbzg-0003eN-GM; Sun, 09 Oct 2022 19:29:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohbzg-0006Yy-Am; Sun, 09 Oct 2022 19:29:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohbzf-0007Bv-N2; Sun, 09 Oct 2022 19:29:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohbzf-0002b5-MV; Sun, 09 Oct 2022 19:29:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jmDugup2vH7sDmOzXOIe+B8/jNmYl9WXFIUS4qk+P/8=; b=ko9BUTUc+hkbjwm5A/0un1MBZS
	M9vZ/593966QqTBo2hesfxjlymBpFvuKsBwJOp4DFy1GXGYQAMqet2sZuNDB5lc/oxswq/hzE4euA
	NJeya3L4WJgbQy+d3x7Wk7/OptrT909K6k/sdHn4jWiNU6B7HXBiiSs1yyt1D1iphn/Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173479-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173479: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a6afa4199d3d038fbfdff5511f7523b0e30cb774
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 09 Oct 2022 19:29:47 +0000

flight 173479 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173479/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl           8 xen-boot                   fail pass in 173475
 test-arm64-arm64-examine      8 reboot                     fail pass in 173475
 test-armhf-armhf-libvirt-qcow2  8 xen-boot                 fail pass in 173475
 test-armhf-armhf-xl-credit1   8 xen-boot                   fail pass in 173475
 test-arm64-arm64-libvirt-raw  8 xen-boot                   fail pass in 173478

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173475 like 173462
 test-arm64-arm64-xl         15 migrate-support-check fail in 173475 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173475 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173475 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173475 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                a6afa4199d3d038fbfdff5511f7523b0e30cb774
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    2 days
Failing since        173470  2022-10-08 06:21:34 Z    1 days    6 attempts
Testing same since   173475  2022-10-08 18:11:26 Z    1 days    4 attempts

------------------------------------------------------------
565 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 41571 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:52:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:52:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419028.663723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdHg-0004uE-Vb; Sun, 09 Oct 2022 20:52:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419028.663723; Sun, 09 Oct 2022 20:52:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdHg-0004u7-Rh; Sun, 09 Oct 2022 20:52:28 +0000
Received: by outflank-mailman (input) for mailman id 419028;
 Sun, 09 Oct 2022 20:52:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdHe-0004u1-Mi
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:52:26 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4646b4be-4814-11ed-964a-05401a9f4f97;
 Sun, 09 Oct 2022 22:52:24 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id EF0F360C92;
 Sun,  9 Oct 2022 20:52:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC14CC43470;
 Sun,  9 Oct 2022 20:52:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4646b4be-4814-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348742;
	bh=WOtLqPtfTzhG6xYKuXLzf9SXFlrNx350kTurMW1iEWw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=bGVsRFYHKQtNA4R65IBHvJqQhHVfXeVzI56AvLm8fW7H5Kq2kgFfGutf7RKDs6hgq
	 p7TDDcpMn9biVK2r1bAXLntk+tX4cBLFyHSjwxWA5FuqMxUzO6ZOn0cxwyBZdnwXQG
	 IM74+upYugArq9YuX/P250IdX/3q9YWT7ZLFiUc2HKZRSOEKxhbl3khzFLPKqNgcF9
	 3q9s82VxGZOOBUj32wxkslhG2JvJhZxXtg45H32JYVfp76slkyZ8ZE8KWKt9FidK4G
	 qFxa58aT1SG/veA5qEpW3I60HIsHAtMmHRkpcYTFQDn1bm6Lusy6o5uY44nzKeajWz
	 zNwzVB3QyJYvQ==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 6.0 16/18] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:51:33 -0400
Message-Id: <20221009205136.1201774-16-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205136.1201774-1-sashal@kernel.org>
References: <20221009205136.1201774-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 0ed2e487a693..9b1a58dda935 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -765,6 +765,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -774,7 +775,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:53:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:53:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419032.663734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdIN-0005ON-79; Sun, 09 Oct 2022 20:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419032.663734; Sun, 09 Oct 2022 20:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdIN-0005OA-3d; Sun, 09 Oct 2022 20:53:11 +0000
Received: by outflank-mailman (input) for mailman id 419032;
 Sun, 09 Oct 2022 20:53:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdIL-0005Nw-MY
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:53:09 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5f7f961b-4814-11ed-9377-c1cf23e5d27e;
 Sun, 09 Oct 2022 22:53:08 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 4D90160C6F;
 Sun,  9 Oct 2022 20:53:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C36CC433C1;
 Sun,  9 Oct 2022 20:53:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f7f961b-4814-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348784;
	bh=WOtLqPtfTzhG6xYKuXLzf9SXFlrNx350kTurMW1iEWw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=t2K74xDBDcjV6Ndo0svxo/s4Egy0X2AEbs0azaXQW5tOvx36zW05KOV+jUT4KfKEa
	 IFngIj8adhRSuCdozSwOa6xdjL+WRAmPDTTWkotb0vafQJKfMBpxARYnxsdvUJGfQo
	 nspRalsK0zE/Ic82FJVs9xuJb2UMm6/P/NciiHTxbFrroYD4cfdnLdGopUjtKUFF5W
	 8TUykGCQ9kQk6xvDB1aXIcboNotYJEYr5XUY9miDNtazSdP5wHG6NMdQDFtjcpjQMR
	 dn1aYHDOxh40v3Yd4hsJhlzRGzlNeSIdSg3ff7Qkst94zj/BbysQdIGZnSxv4ZbY6G
	 9v10CfDF5dAbw==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 5.19 14/16] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:52:23 -0400
Message-Id: <20221009205226.1202133-14-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205226.1202133-1-sashal@kernel.org>
References: <20221009205226.1202133-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 0ed2e487a693..9b1a58dda935 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -765,6 +765,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -774,7 +775,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:53:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:53:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419038.663744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdIz-0005xN-Ei; Sun, 09 Oct 2022 20:53:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419038.663744; Sun, 09 Oct 2022 20:53:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdIz-0005xG-C7; Sun, 09 Oct 2022 20:53:49 +0000
Received: by outflank-mailman (input) for mailman id 419038;
 Sun, 09 Oct 2022 20:53:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdIy-0004u1-Ok
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:53:48 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7890795a-4814-11ed-964a-05401a9f4f97;
 Sun, 09 Oct 2022 22:53:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 30274B80DC9;
 Sun,  9 Oct 2022 20:53:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4715CC433D6;
 Sun,  9 Oct 2022 20:53:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7890795a-4814-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348825;
	bh=Ni3aGGiJlZu9KJ4N6LRidb1HrO9afGdBuz4Hc+sk+7o=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=CMuA+Bo3/HgV7u8Lfn7SjpUz9dOkvcGMnrCLpQ/CD25thh7k+OaqwfmkAxknvif3Y
	 Tr7IpRt8EsFV4CAlFC2zjh/zgVDVBf/djg8gCpvc97MuZCNPFNlsDyeoLzo7X1o7sf
	 6uaeHtdp05ndDSJ+X7GEYW2rVf3JAW6LvHQ9CSeHGtGKbw8wCvoBF2GYfRkHp/ch89
	 O5DjkWElT0GU8apaMNEt+FCzxbOVIm6thv28geQz/Ei99osG9RVb4yW6K886IFiQ5H
	 NRsD/tYuoVXP/8VmkzoyKVcXndRkGM8727DbwiRCCvkG2sQFcqjfOxrBfqR6ZKgQwM
	 qDzkX4DBAVXEQ==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 5.15 13/15] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:53:06 -0400
Message-Id: <20221009205308.1202627-13-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205308.1202627-1-sashal@kernel.org>
References: <20221009205308.1202627-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 133ef31639df..561aad13412f 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -759,6 +759,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -768,7 +769,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:54:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:54:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419046.663756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdJW-0006Y9-Nw; Sun, 09 Oct 2022 20:54:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419046.663756; Sun, 09 Oct 2022 20:54:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdJW-0006Y2-Jr; Sun, 09 Oct 2022 20:54:22 +0000
Received: by outflank-mailman (input) for mailman id 419046;
 Sun, 09 Oct 2022 20:54:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdJV-0004u1-JT
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:54:21 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b67b7da-4814-11ed-964a-05401a9f4f97;
 Sun, 09 Oct 2022 22:54:20 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 0E9F060CBB;
 Sun,  9 Oct 2022 20:54:19 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 458D9C43142;
 Sun,  9 Oct 2022 20:54:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b67b7da-4814-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348858;
	bh=aW+O/Bep5E72Knf9F5KLUligbpxqba0bCHR1Uql63Oo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=jgrIWXL2Z839VxBtGng3BpFHc4mzvpL6u4JZfzahaZ2fIr7fWAl56PkePPYKyqgIj
	 WKS9U6aIwJIuiovoQQQvyDuAS8r8qRBrHwOtfsAfr7isUgzDBYBE/u4v9+aZEZnjAh
	 UifpweFx4bWvzht6pL+xutTSLkkvbxo6kWR/LOlGcwwyoC6/uGBeOTRSuGBY8SiGkx
	 Pyq3QCwGHOOvDao/Ko2DOAcWkm2NGLU4o/dD9E/hy2Sn4zJxtDbrwGUVm/Ew0BKyD0
	 PlBr4tyTWSzoG9+RHDXN5Hr1Me2vz8AfGb3y4v2kNv2ePc418zTtv9snmCPo1j1PHh
	 yXCd2epOqgVOQ==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 5.10 08/10] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:53:47 -0400
Message-Id: <20221009205350.1203176-8-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205350.1203176-1-sashal@kernel.org>
References: <20221009205350.1203176-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 804c65d2b95f..815030b7f6fa 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -768,6 +768,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -777,7 +778,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:55:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:55:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419050.663766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdK8-0007Fr-VP; Sun, 09 Oct 2022 20:55:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419050.663766; Sun, 09 Oct 2022 20:55:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdK8-0007Fk-Sh; Sun, 09 Oct 2022 20:55:00 +0000
Received: by outflank-mailman (input) for mailman id 419050;
 Sun, 09 Oct 2022 20:54:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdJq-0004u1-SK
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:54:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98e30225-4814-11ed-964a-05401a9f4f97;
 Sun, 09 Oct 2022 22:54:42 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C6420B80DC5;
 Sun,  9 Oct 2022 20:54:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB442C433D7;
 Sun,  9 Oct 2022 20:54:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98e30225-4814-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348880;
	bh=q35u9k51iKg4WFnPv2+Jft9j9x8EK3aRtf5Pa+iGBKU=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=l6G/+FP9dX3PX6wRIpv5S6d7aHqwjOmyGhFR5NZNAA9NLbG9Bd7N13fKUd9TUfAXr
	 GOOV/PWJMPpyeJsjlJreKpMA1GRMUVmkYF5Xaxz8OfaiQ80AUD6RWKxN/eo792EBju
	 UQQlV/11CKGd8xrM+mUaBKM/HGrTdslv6Ecd5Y/JmDF1MoLKiC3B6UNwmkpTKEmBiB
	 S2I3LLhbB38dlr+kwS1qK8K69ZjYjlglKTMD/wocHkeoLP1CYXl4Tl76wRagCMpsk4
	 tfHfPyVUB1ICmU7mUCSbWsgAMY4F6pLxMGz/YC0aJNJI0O5yaQI7tN0kMDUk4rSr0o
	 39gUAN5DIQy+Q==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 5.4 5/6] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:54:21 -0400
Message-Id: <20221009205423.1203538-5-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205423.1203538-1-sashal@kernel.org>
References: <20221009205423.1203538-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 65cf405cd975..26b35e75b701 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -759,6 +759,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -768,7 +769,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:55:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:55:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419051.663771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdK9-0007IY-8O; Sun, 09 Oct 2022 20:55:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419051.663771; Sun, 09 Oct 2022 20:55:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdK9-0007Hi-4T; Sun, 09 Oct 2022 20:55:01 +0000
Received: by outflank-mailman (input) for mailman id 419051;
 Sun, 09 Oct 2022 20:54:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdK4-0004u1-Sl
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:54:57 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a069c07c-4814-11ed-964a-05401a9f4f97;
 Sun, 09 Oct 2022 22:54:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 4B8D160C98;
 Sun,  9 Oct 2022 20:54:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B824C433D6;
 Sun,  9 Oct 2022 20:54:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a069c07c-4814-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348893;
	bh=HDBZX01FN2W9c75Sd8NoXHb1ZhN7yyXXynCHY/64+/k=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=pt7bTe+swnrVgAIZUI319jGl8bUpA4xsKzNCd7+sQPVqIF0i/DZ63Eg5JcllsHDbN
	 hm03b7Mq4Jy2rlwygWwRaUN/lSc0L28sjK5xx/A5QmGUkVIqXCpc9viNCv1Qd9/rLx
	 +g894KW5BLmWvbg8LkKXehPOlHpO2+LbO52F8/Svj2BdwxEQ2Ytmr//+5F2JxmJgVq
	 QD6wUrCdm5opT2Uwjt2QvuVhesMl5hdfYEtRuanofxE9G04zFztCr0Fyo1PKZUhaV9
	 KGxyYL2RpjpukVg2JtCgqT1BvIBui/3zLEa5r2gHvwrjhiDq4/gRVg+ox6m3qLrxlX
	 Y6e463HYckFPA==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 4.19 5/6] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:54:41 -0400
Message-Id: <20221009205443.1203725-5-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205443.1203725-1-sashal@kernel.org>
References: <20221009205443.1203725-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 8f1ff8dad2ce..04bfd9c3987b 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -752,6 +752,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -761,7 +762,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 09 20:55:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 09 Oct 2022 20:55:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419054.663788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdKH-0007u2-LG; Sun, 09 Oct 2022 20:55:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419054.663788; Sun, 09 Oct 2022 20:55:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohdKH-0007tv-If; Sun, 09 Oct 2022 20:55:09 +0000
Received: by outflank-mailman (input) for mailman id 419054;
 Sun, 09 Oct 2022 20:55:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9gvH=2K=kernel.org=sashal@srs-se1.protection.inumbo.net>)
 id 1ohdKG-00075x-L8
 for xen-devel@lists.xenproject.org; Sun, 09 Oct 2022 20:55:08 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a825828d-4814-11ed-9377-c1cf23e5d27e;
 Sun, 09 Oct 2022 22:55:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 674C9B80DC4;
 Sun,  9 Oct 2022 20:55:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A90A6C433D6;
 Sun,  9 Oct 2022 20:55:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a825828d-4814-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665348906;
	bh=pKq6STDJUV1Dof39xPqd3W5VALSdKIfQtmFHciFElP0=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=mn9AyhzKFNp/lsYOlFv/JUG6QmKPSib90OLsLstmUmGH6IFO6MQXkys06kQ78MvYw
	 xQsZjtS6Ix2AV3YV6VrXUvwrY+DJz5xTQYD/pTtrtoKIaqmP3GKBE5FZklaXmOu+Un
	 jN99ZAXkiG7ID2P0s00Rp+2jAjRThcH6nSIxmh+PYvEds10gfFavvwMQvym1LT9TFj
	 tfZuVXtQyl9S/2g4rmmSIJgkuUjhJI5lZG8ZJa+Xkn3xRPHc6ADyI/IgFd1EbQHu9E
	 3Ng1folcEeQx5FGxWw35kTiv9Vs7XFFVHw94lwk9KQ3M0SCqEdg4RDXFY35i3zyuWw
	 vXi3WtNisKFfg==
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Sasha Levin <sashal@kernel.org>,
	nathan@kernel.org,
	ndesaulniers@google.com,
	llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 4.14 5/6] x86/entry: Work around Clang __bdos() bug
Date: Sun,  9 Oct 2022 16:54:54 -0400
Message-Id: <20221009205456.1203807-5-sashal@kernel.org>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20221009205456.1203807-1-sashal@kernel.org>
References: <20221009205456.1203807-1-sashal@kernel.org>
MIME-Version: 1.0
X-stable: review
X-Patchwork-Hint: Ignore
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 88d084a57b14..3f38541c28d2 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -753,6 +753,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -762,7 +763,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 02:26:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 02:26:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419086.663800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohiUU-00048m-VF; Mon, 10 Oct 2022 02:26:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419086.663800; Mon, 10 Oct 2022 02:26:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohiUU-00048e-OG; Mon, 10 Oct 2022 02:26:02 +0000
Received: by outflank-mailman (input) for mailman id 419086;
 Mon, 10 Oct 2022 02:26:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohiUU-00048U-B9; Mon, 10 Oct 2022 02:26:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohiUU-0000fa-2V; Mon, 10 Oct 2022 02:26:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohiUT-0003HD-DI; Mon, 10 Oct 2022 02:26:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohiUT-0000fG-Cr; Mon, 10 Oct 2022 02:26:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZaR+hRybpSb2L9lTYnuvjcMGPs1gIdwNca7Y3vZWq9c=; b=fJv/Dk/JzB3ulGsV1W09Dy20q/
	SVKexkP0nnenrheMpdnQYWHvjqE9BP1SXRgpyoqZ8LiJEPAvcN+13wI4LlvodjKFSUoAM0XcasZMK
	ZGPG0ukjcfYEPcf1SSra9uPXabgBOm9kqB4MKE3OJ9ynXoJRipu7hGKFfevw9uaYTSPg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173480-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173480: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-examine:reboot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a6afa4199d3d038fbfdff5511f7523b0e30cb774
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 02:26:01 +0000

flight 173480 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173480/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl           8 xen-boot                   fail pass in 173475
 test-arm64-arm64-examine      8 reboot                     fail pass in 173475
 test-armhf-armhf-libvirt-qcow2  8 xen-boot                 fail pass in 173475
 test-armhf-armhf-xl-credit1   8 xen-boot                   fail pass in 173475
 test-arm64-arm64-libvirt-raw  8 xen-boot                   fail pass in 173478

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173475 like 173462
 test-arm64-arm64-xl         15 migrate-support-check fail in 173475 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173475 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173475 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 173475 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 173475 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173475 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                a6afa4199d3d038fbfdff5511f7523b0e30cb774
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    2 days
Failing since        173470  2022-10-08 06:21:34 Z    1 days    7 attempts
Testing same since   173475  2022-10-08 18:11:26 Z    1 days    5 attempts

------------------------------------------------------------
565 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 41571 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 03:00:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 03:00:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419096.663811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohj2A-0000iP-Js; Mon, 10 Oct 2022 03:00:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419096.663811; Mon, 10 Oct 2022 03:00:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohj2A-0000iI-GY; Mon, 10 Oct 2022 03:00:50 +0000
Received: by outflank-mailman (input) for mailman id 419096;
 Mon, 10 Oct 2022 03:00:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohj29-0000i5-Qi; Mon, 10 Oct 2022 03:00:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohj29-0001nJ-PF; Mon, 10 Oct 2022 03:00:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohj29-0004pb-7k; Mon, 10 Oct 2022 03:00:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohj29-0004Wz-7I; Mon, 10 Oct 2022 03:00:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=B/FeNLYV9Z8yyP4+S7u9wNdmLfnN8ymuJ9bQCn709Ws=; b=Lbi1bSYHe+4suJQhZizO5e5Atc
	+n05mxDMhHIbf1332a5WNB99VB7Km00+FT+lYGMKKqA3Tnfqgu2UjQDfBXB3zqL/EK6DX71KS/X+N
	3xJHoStCFdd8pPjze4JbAGznEq5o6ffpHAAgmCeC0u7ulWTQzyAau+rs4xJu0izWEsyY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173481-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173481: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=3c9e2f239a38590b4e3a8c1ec2304227f2af0103
X-Osstest-Versions-That:
    ovmf=de103f1981cfca90dd19296d4b20449a2b93dc26
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 03:00:49 +0000

flight 173481 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173481/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 3c9e2f239a38590b4e3a8c1ec2304227f2af0103
baseline version:
 ovmf                 de103f1981cfca90dd19296d4b20449a2b93dc26

Last test of basis   173472  2022-10-08 11:13:08 Z    1 days
Testing same since   173481  2022-10-10 01:11:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Yuan Yu <yuanyu@google.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   de103f1981..3c9e2f239a  3c9e2f239a38590b4e3a8c1ec2304227f2af0103 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 06:19:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 06:19:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419104.663822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohm85-0004jP-Eb; Mon, 10 Oct 2022 06:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419104.663822; Mon, 10 Oct 2022 06:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohm85-0004jI-BS; Mon, 10 Oct 2022 06:19:09 +0000
Received: by outflank-mailman (input) for mailman id 419104;
 Mon, 10 Oct 2022 06:19:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zSpT=2L=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ohm83-0004iw-0Z
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 06:19:07 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2040.outbound.protection.outlook.com [40.107.21.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c87e0ff-4863-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 08:18:58 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9380.eurprd04.prod.outlook.com (2603:10a6:10:368::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 10 Oct
 2022 06:19:02 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Mon, 10 Oct 2022
 06:19:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c87e0ff-4863-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YcJzmQ9og4039wGM08mYGcQepv0Nwj2cFbjeL3i4LsJQ2Isw3Bp4Z82bbevFmZ0qd79fKa4/tiatRnDw9O8Kvo0BiLxUE+VjQ6vaqhYYrxvT9UlrafkElWv9Hl+pnJsNmoXSc59TFUlMO3Fz94Q3iEAq7TUkbXFxmI9l1fQWpqWRwGbEM7qQwZ98V89lmwifQhx7YiSvKpAreQyOiEIf3XFYvNmEVZTBLc/TBFbDkorbHAmYHqVvviu0JKpsA5+rZ1nKuR6pqEZcd2uPUoCzCAk8hFlaZSeuOoPtq/2U2Le/nXjNJhXPTPm6eTjpR4rL6x7SMmwuVuMkfUTz+P9w1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XfrW9xDO3p/KtxAA3jnh286ln62fMs6xCFkbcN3D4Ls=;
 b=SV3QRK/m/3nBNedBlI6NMQiniV+598NeFYYLOue+e/eVEaDMJLzjUpQhKVBEcTpwUUHC1sH7+tZcPpBLGo6lWND+LGhB4rDE9qVzgmMfGElhB7ezm8e34bVjRB44tvaJDLpsQ4rrUzrDQd+eJS4XmdvPFlBuj5ApTgyPxb6avelKJU5Q+oZD4iVv58i7TbuZ2dw6BoSjdwob3qtLKKW/9pJUjNDzqrTceMu3Q5+gU4A8PmVS6LuFkPiiO/P9t6YdzgskKsfk5tqrz3IQnGdmg3WUJNM3T3lB2IsXHReVyXXhyiBdPlsN3cwTVQPxOx2AYmTqvGV104mfuY7tNvTFDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XfrW9xDO3p/KtxAA3jnh286ln62fMs6xCFkbcN3D4Ls=;
 b=J8cBMmvdxgnG1KuvbYmvI6Dty34he4gFcKlwRYPQ7vRAVJauQaBhColvalbOZYE6CCL+vJBd1oIPYzCnCy+ao7rxNkVhRbqM2f6/Id/dPGxUyadUT4abY7wSoyDQMRgARlu+hAfgsZJeZH5Do8UDyFf65h7xEQx7y9dDUuq986V12eGcrDGa3ScExCxvESg5Rm+yQwhGQfjtB7fV74865UJDp4cMJpIwRiDIBOLsvv3CLWShev9sRRTG13OiDQYdt3/HCsw8Fl1QbYpBdkqPRoZaRiN8qkFy3xTlGCClu04UmIAWJ8rDwIK8BDyXeTFwKjdBf7Ll2dySQ6S5YrXMKw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5bafacf7-0eb1-75c1-954c-d492059cecb5@suse.com>
Date: Mon, 10 Oct 2022 08:18:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [linux-linus test] 173480: regressions - FAIL
Content-Language: en-US
To: osstest service owner <osstest-admin@xenproject.org>
References: <osstest-173480-mainreport@xen.org>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <osstest-173480-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0225.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9380:EE_
X-MS-Office365-Filtering-Correlation-Id: f1c6adb3-0ce4-4ef7-8422-08daaa8752ae
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pweNNezDhv+Ih2xG1Q099ojdBlIDQv5xqhdepSvY7Z8ZTtfZqXEaDk2p3pJwZk9hre5ke1uVf9pZqKZq3wC8QcHoj9yp/K/uO+QgK1ToMvmjCAComppklBVLJow8KuplmAsY21QS99RJVTtAsluB24dnXzX0oA/vTV2FuCJHbu/aLCWeXC/5GkWs642O/yIJvw7srJWjeUuGlBx0h1BLBiShq4Z0TiJOwzSN/xwQl3eYrCjTZU5CmPnEwBFAa+h0DKnZWNc2XhdWbgx/SkGrq0JwQRCEL9PNCzMEsx8Chb7tfO4hRTKumx7yxAjwaNba0I41yVkGq/ogK0h8g4JEnMlHLpmQQgptqXBHrbFWH3/E22tkA+//z6kGvao8oqTtIyoo3+PZk74uc2LRQxWLYFZf98J+6WUaO9+D/RSOz2GvWTMDArvHGLz2XeXAHXyN7/N/WLGYTJOsWEOGNutn4qDD+jwchZqQqs6AM5bzl9yFeD9y4m46otFUMSmq48P2tmh+JfDj3oaMD5MpFO/8DCbLdXFzLgNUraSVG4cM5rS/Tf5XTCSE1jW0JO0PzkY+iJ/N9WKyA4jZsn+3NPiIj1vrl6inelFNB9PKt8nYqmrdyT8rVjC93ksRPURcDK1Nxjzkhola256duiN4lP8Olki8iR4QVqZ2uQbxLwLPtpqArCUY2r7zHMNVBrtQOO0OJtoN/etYKP1/3IrovWNsVcBDhTHgaoaxWkX9wtXEjOMDXLkhywCqNybcq8ZWQI67TWcqUaCdTiD5KUQ3LoU8eup6jte1uJhxYN8oNWM2Srfa0cHxmcYr99L1enA3fOASB4MIHztFu5X/Q3N7Skr/5g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(66946007)(2906002)(36756003)(8936002)(478600001)(316002)(6506007)(6512007)(66556008)(31696002)(6916009)(6666004)(83380400001)(4326008)(186003)(41300700001)(66476007)(2616005)(6486002)(8676002)(53546011)(86362001)(5660300002)(31686004)(966005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UllMTzIvRlAyRWpzaWp0YWdBTnUvWnUxZTRIZktjS01iNnljWlB1cVIyd3JG?=
 =?utf-8?B?RFJTbVhocWFLbVJsdjVHYWROUDJFMTdxeEJXWU5QREFGRE84R01iYW1MZUVy?=
 =?utf-8?B?bmREdnk1MlZyZlVkMSt1MTA5czhTT3lHd1FJSitSMFdoVlgzd2QrUWxTYm1J?=
 =?utf-8?B?N1U1aHRaZ0ZvOEZFRWhydEVmTlBoRkppMytUaTBudWdsck5aY1JZd1dHcDRO?=
 =?utf-8?B?ZG83Uk9CNDgwM0RqNGdlOWxydHMxNHRrK29GYUxyTnIxUEp0eXpjQW1PRjZt?=
 =?utf-8?B?Sk04ekwxOHYwSGMrd2dUUHN2YWxjYmxWbWJaNTFvaHYwdWVFTjNuZjNLNHNz?=
 =?utf-8?B?VDRoVE5zMHR5VjdYemEwcGRVMm9Ydk9kS0tQTi9FMWc5ZFFwSGhzRjJaUU9D?=
 =?utf-8?B?K1hDY29SR0JMTC9ndlRXSWtHV2FJcjErUHVNTXh5Z0NaeWpILzhodXk2Rngx?=
 =?utf-8?B?ME1qc1AvZythc2ZVZ0NpaTVQN2FpNFFGRWZBaGVSMVNCdDRkMFZ4NUZWd3or?=
 =?utf-8?B?TkFVTStRNUEraDRaaHJCUG9jWVFtQUIzcWRNM0I0RXZuSnBRZ1hvckJqN1cx?=
 =?utf-8?B?a2hCRDI1dTgyY2lhY25OWlVkaGFnMUJXcHQ1bXVOSUZOa2g4dGlKMys4aVR2?=
 =?utf-8?B?K1ZZMW16M2hmKzNobytJcjJmcWREYjBOV1E5bzhxc3E2eGZoT3czMHdCNWFG?=
 =?utf-8?B?UEpSVy9MMS9SUlI2clVxMjFhU0tQaTFkTE9NN3h5cHoyQ2hVT2hVWHRUVGVK?=
 =?utf-8?B?OEpldGpaRmVGSHpHdzc3b1VsUWxaYmNNMXhOaHFrQit4cTlyeDhCUjEvMERl?=
 =?utf-8?B?ODdyWTk5c1JvN0dKS0F1Szhpb01GZC9Tb0I0SVp5Tk5BbEt4VDVYMy9tcHBr?=
 =?utf-8?B?cEpmRG1PRmRvbllORXQyQUJxbXhPME1lbFFPSlFiSzlESUoxdUhCVGc5N21O?=
 =?utf-8?B?YzIxazM4VmUvZy96bUZDODRLVFlJcENtbkJqR3VESDlyaDBJUUxvZGQzMnhC?=
 =?utf-8?B?NkJHcWtlbzFsT3FEdFE4VW1CWDJzaHlqU3RkcjhmenVheHZJaDVHZUdRTS9K?=
 =?utf-8?B?RFNML3l3VC91aW1pK25LQXQ4N1JEMU5ENGxwRUhwV0RLcVFIVkQwUk4zSVpn?=
 =?utf-8?B?ZUZ4WEczS2tiOGxyVVNhOWVnNlRWWDlxVWlKdVpxV3RsWk9OcXA1b1EyZ05I?=
 =?utf-8?B?Q2JFbllHZFkrK2JBSDI0THAvdlluVnNRbGd4Qkd6YUU3ejBIQkZCL3EzczRC?=
 =?utf-8?B?c28wdjAwM1VuSFo2bEQxL2NOMm80Y3E0a3VIcUZKeXlyWWJDdXREa01nMDRo?=
 =?utf-8?B?Q3RnVkplQTU5eTNDTXVnRG5nSW5La1E5VXE1SVZpdFBJNC8rWitkK1g2M3Jj?=
 =?utf-8?B?WUJPZWdOTk41Rk1ZSENJUDVibkxzMnZlVFJRdFh0dXZvcUZadnVnNE9EU2lQ?=
 =?utf-8?B?UEFsSUNpcEttZ1pUQk42S2VrNFpWV2V2UGtIcUlNcTN5bjVMMUZxb2lEV2JU?=
 =?utf-8?B?SVJOOE54UHF6ckc3T2p4cjJxcStDNG5JNzJLNzJxQXdPTkJKdnhaVG5obWE4?=
 =?utf-8?B?WTRmblJyeW1wT2lvdGhjSC9ud0NyWUxKN0xDR0ZqWWRzWVJKQjJxdWZHWW02?=
 =?utf-8?B?S2ltbytlMmZHRGpwa3VwSnU5Ri9ab1F0SjJjb2ZuL1RnRHBkQTl3OHJ2SGxK?=
 =?utf-8?B?VEZ6SGVaR2FOL1dmOHZDZDZNd2VxdzRaMkdLRm5zdWMwaUpraEZiVklTNldy?=
 =?utf-8?B?OHV2UURuMmhHalpDUkZkK3JtbmVkWDJTeGRvZlphdytXbmFOc3pJOEpSRGRR?=
 =?utf-8?B?UWc1S2w4T0RZOFJvanNWcEdOSjl2SzI2R3FJeHY1UHA4eU11Yi9hZTFQT0pX?=
 =?utf-8?B?NXg2amcwUWtvT1REYVRXUTNTMnFjZ2pKdnFyeGUwS2ZqMmVFSWE5UW1xL1dJ?=
 =?utf-8?B?ZDgrbi9OODdYVndGcnB0OFlJaEZRWkpuNlVnTjhaZG1pR2ZENEtnaXFYTlNv?=
 =?utf-8?B?TzgvL1liWWFOS1Erb09VNUVtRU9MbStmQXE4UGZEbzNpcW56M2lGNkduT1hX?=
 =?utf-8?B?UkIxZ09jZFYrYWhTZjA4NEQxR3d2NnM2Y2ZweUxVRGlUWSt6SkRjTm4xMXpE?=
 =?utf-8?B?RkhFeFVWRFhrdk9hMTl4eWc2S3NVNXJEMHlkTjIycmdSbjZWclpNa3Z1eUEw?=
 =?utf-8?Q?iuyM5fgbGyKM5wS0XarP+OFk20iGStF+QuLWM3l/5xxC?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1c6adb3-0ce4-4ef7-8422-08daaa8752ae
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 06:19:02.7227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wUe6RwRpfaktNoJX3SB0HkT1tpW3T09rN7h+Lt/vs2V0RBnlwlc+fH1KmRNtIgw1ALghfM+HVQpq4T1EztdJsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9380

On 10.10.2022 04:26, osstest service owner wrote:
> flight 173480 linux-linus real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/173480/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
>  test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
>  test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
>  test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
>  test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
>  test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
>  test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
>  test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
>  test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
>  test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
>  test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
>  test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
>  test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Hmm, they can't find their volume groups. Since xen-unstable flights have
been working afaics, is there perhaps a kernel Kconfig change needed (e.g.
because of a newly present or split option)? Albeit then it's not really
clear to me why only Arm would be affected - I assume basic arrangements
like these match between x86 and Arm.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 06:20:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 06:20:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419111.663833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohm9m-00068f-UA; Mon, 10 Oct 2022 06:20:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419111.663833; Mon, 10 Oct 2022 06:20:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohm9m-00068Y-RD; Mon, 10 Oct 2022 06:20:54 +0000
Received: by outflank-mailman (input) for mailman id 419111;
 Mon, 10 Oct 2022 06:20:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zSpT=2L=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ohm9l-00068O-QA
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 06:20:53 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2083.outbound.protection.outlook.com [40.107.21.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id acd8f766-4863-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 08:20:46 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9380.eurprd04.prod.outlook.com (2603:10a6:10:368::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 10 Oct
 2022 06:20:51 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Mon, 10 Oct 2022
 06:20:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: acd8f766-4863-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DKGdVrUIlGHSC0xUXrbY9eAsx1oUB957ET5pAyvv+zea3uE8jox208G/wwXTeTkJ3HTOHdBy9Jazl4aJTlTgCpzs8v/F03SXVZbucOBBuIh3iPNOeeZvgoAkIqWrwd0Oa1pBA/mBfIMRjw4jEkco21Qfij3R81cKxcXQERJdkmRFuEM0mg1beG9qyqNO59veHnomT9UrrrDFfhkaQf6d83cGN6+OEiwm9lkXjm/c3yU5vuhjR7qPxwmC2/YI9BmpOwbI/hiR8I7XgpdJAvAQFXQKfBGoL38zfOp1cpTIl1PFmpM0+gmUK6Vx4hePgUHsiuP3tIb+SmZjaSA2JKrrHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G8uhotMRLEWevni8/P/wrPFXh2RFR72AYYIlNtVhUnw=;
 b=IMk3EyFCK9+VfzVQ7jZSyKJfilwQcBipxs0JKN2Ff49mwx99l0c88Oz9l6y8wadhuNh7YTjBGVMBCaXXi6JkD6NdoSuR9uRz974yCgz8zb7OoVnWRNt5lDycT9gMPc+1yE43OI40janrmS0sS4eyxFLFf9hk1JaeFJRQYM1OnrHlYojJZFrvWB2lOZimO4BaIAmIrMljTi/k+m4JJqMwwWx8NAT93SqaA9l8c20vYBTZj1xEDvOBL0ggaakQ3WFzCfS3GiZSI3rAjh+h6iYPr60e0s8o1D9tNuEL2UVOYBySrSLSGKrODBi9Pz4JvPeF/P4XC0QEN3nhznqLHcvdIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=G8uhotMRLEWevni8/P/wrPFXh2RFR72AYYIlNtVhUnw=;
 b=YojT2RLLL3x2Ybi0//o3GMJhUnIeUS5kesC2k4UFjWx1UDgoUkyGq2pF7UoMD5WGsaFXYsaHtpVm/S4pEW6uZFzODPaYT3W3s8l+2seVQI7EiBntcAKS5pM+lwZteSt8NMH0ZOcUzpsnm6nBnBzgFmkBNpOO30588QJ+tlSGcBLud5/N3vpiqtQCpotd2F9jVyXlC9Rc7/vKVUPuwMSOJLN003s4xID5e9aS3Rgz2uaowYa/joFkcbU+GHb7yajmua312+a48L/Ffjue7E10dozVtBBnpAwZB/2+uJd86jPZdhQB48r8rNRGO/YrdF0LeV+j1FgK7b4yra7IbkP4ZA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <319015d6-ec1c-3500-2437-00d40fe4d2c3@suse.com>
Date: Mon, 10 Oct 2022 08:20:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
 <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
 <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
 <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com>
 <82963a1c-3301-72ff-e995-77c30ec5a64b@suse.com>
 <a957dfbe-c4c4-c8cc-93c5-616a44fe1797@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <a957dfbe-c4c4-c8cc-93c5-616a44fe1797@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P193CA0137.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::42) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9380:EE_
X-MS-Office365-Filtering-Correlation-Id: 42d430f3-4df5-45c3-1c16-08daaa87943e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	k+3mpoAV9IlBd3Vf/tKO526IoUdJm3u5dDdQfbASyvGTYnpmtDlEiEA3Xq1zXQaHEvcSBoYdELaU272hNRoc85o+gNAR89J3njRAtBkwlTpMUH78VlWMO5lbNI8/4i07wtsFSxluDFnp9GKgj+bFfZbS1rFG9YX8pJuEFwjkmFp4m+7tdUE0epbJ+6WsywmYulALd6EKAw5TFejYYW8Ivh/bGQW4edAUv3Gpy7sLb99LA34q9+wyHHMGmJ5ktvh4TBTMNgRsqZSXWMxRARi8+IVA7mYjEYNVE7gmMV9OVufOV+U0kSJ4pAqkkE66IyT87qimMmu6sQ7JC1kRagBDTKjkYi9B2jhj3xZ0g6+nJxrFo5Rx/kG+qkz0AsZKbci0PYa4aF+mLwkad8qRNyOrkRvY2qnn9yncjVPyhxwxh959tEirIfpAG5ItwGh8sSymhaBIXkprWnUBUDEWsieGc/h21J6JlbaslUNk8vAOTramCTSV3oOnUyundLuZwTd5Gbv0md7Bq+u0+3uEb/PmiojGMUqLpAFFP3COq9bx4+hVd2K0WjzZL2mh+DpfvB7xpgrrU6DqIicIQ/NoJL3e9Iksj4kMwed/UGYR9cfMIWrDX2rX0omatNKFdqg1rsC2SXdpBpW6C+of3VdmPiYz5lZT2uqrzbAKOa7LYqY0P+VNKBUEQKIcBJOWNzfdQ/UqfiFy9vwTUlFngAkt9KoEd0Szj4BzaeC7UKXP+lAhoFUd14MnkWXAefIz/NsKLRmiuf/KvsHztTVONDunpEoMCDHdK6c52N8a/NdDk7FGSxk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(66946007)(2906002)(36756003)(8936002)(478600001)(316002)(6506007)(6512007)(66556008)(31696002)(6916009)(6666004)(4326008)(186003)(41300700001)(66476007)(2616005)(6486002)(8676002)(53546011)(54906003)(86362001)(5660300002)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWw0SFNBdHNocUJaSzBCakdUdzZEY0hrMHY4SFlqNmgyLzY1aFZWVWY3SjFz?=
 =?utf-8?B?OGZLS0ViOTNaMnJ1cjEzZms3bWtFRm90ZUE4ckNMV254dVZ2Y1RFWnBBeGpo?=
 =?utf-8?B?clpzWThXWThRelFSY1pKNnZjN2c2akxrUXM3M1g5YXI3K1NPMm9US1pzSHh0?=
 =?utf-8?B?NFcyYTg2NngrK0Yzd0NOM1JWL1p2bml2Mk1zVTdjQS91NFJzekZhb1RSNXp6?=
 =?utf-8?B?cjJua3JpYld5b05DSGsvSzNDczRPWEdxTFY0RmtuVmZyL2hLaytrK3h3WjIz?=
 =?utf-8?B?TjN3Z0FjcXNZYkdzenRpYmZwbkRqRkN0cWVuQXZHb2xkeXJiRzA1YXE1RERU?=
 =?utf-8?B?OXBwY1F5bVhlL1h0elR3ZHpIbWhkWGNvN2VqRWUzMlc1U0wzclZ1Z2V5QnRP?=
 =?utf-8?B?Z2R2bHJMSkdleWgzU21CWTNyTE93TERXcjlhRVFldjF2VWZiUC81Vmd2M1Rn?=
 =?utf-8?B?a09Zb2h1dnpvUmsva0dHZ05CYUNZaEw2cFlFWXJ5L21SbU9kL2wwMVRLeC9F?=
 =?utf-8?B?TzNuZkFpcVhvR2o3TnZybHlWbFRFaHJ4c0ttYWZYdXZJVURUUElaRXJQaXpt?=
 =?utf-8?B?aURSNkVEaWpibjB5d2o4aU9LWEMwTkRGQkI4NENLVHAvNDhjVHJBdVJGRE1L?=
 =?utf-8?B?a2YwZ0lSUkpBVHVFc3FlUU02c3FKRnFWMVRYc2VVcng3eUJBRlkyOHcweEJh?=
 =?utf-8?B?ZDVmNkk3bUUrUDkyMVpBTmVua0hhUExEZE0xSDJMR1k5S01xMHVDdG1POHhT?=
 =?utf-8?B?Uis4TGJLb3d2c3lwb3BGampuRkp2MVJjQ1F0NU93c3h4VDhoM0Q0RDRsc1gx?=
 =?utf-8?B?SUJ2T3FzbkVic25EMDhGOWhwK3VKdUJ4Q1pudXQ4QWVQTjlrVERUdzBXSXJO?=
 =?utf-8?B?SitFTGJuNWUwZFVNQ1pPTy9mcHA4RnBIb2piVXV0Sk5VM25vQ2QxcFhraW5t?=
 =?utf-8?B?ckFLdDUyMlNQeXNjMjArbC9JemJvREt3MU93ZDZFdStYRldYbWhZcGZYZnBz?=
 =?utf-8?B?UW5hbTZaRE4xaXFCTStLcEh4UzlSaGE2K2NZc3U0N3V1OXVjek5JZjJCemF1?=
 =?utf-8?B?ejZQeEVJdXh4R0V5eWJOQlAxZXlOMWVzcnRCblh1dno5dTV4QjgraDNHMTB2?=
 =?utf-8?B?K0lkd0cxV3RVZXZ0bkJVaHYyR1VVMjhrVExnVkd6c0RPZ1kzano1NWRpVHRZ?=
 =?utf-8?B?bE1yNmlqWVJPOVFPOGVMRGNWRkhBTUgzc3NYbXkvTmQ2SXFjdWpnc3RyNTFy?=
 =?utf-8?B?d29MVzYvMDRqck9rOTVzS25mUzVSWVJjRmZVZHZJSkpOdjBxTjhZdHRCcml6?=
 =?utf-8?B?SVZraFZheXpwOTJ4bzJPR3JOd1dIcFE2dnQzMTY4ODhjbDlhVjE1aVJYVnhB?=
 =?utf-8?B?TzJ1LzJxVS9aQ28zZEhOSVBwcEEvU0ZtK2t5UW82QTRiajlIMEs4MEN4SDdp?=
 =?utf-8?B?a21KT0I0VWE0bGNQQ2dJQWRhanllSHFKZFRPc2tQdTNhMWJjQ2pKWkFMNEFV?=
 =?utf-8?B?cEc4Y1MyaVduT0JpbGRYL1RqNzZzV3NUOGZ2WkhDSnIxT2ZIUXZlRHdhamph?=
 =?utf-8?B?SUY1ZmY5TXprb0ZvNU5TanVaODU5cHpOemo0am5vQWFlbnI5VUl3a1lySWtq?=
 =?utf-8?B?QmlLQjliSTU5UlZTOGxTRGhyTWVsa3NvTjhYVGZ2VTZJNEcxOHVjZWE4WXRW?=
 =?utf-8?B?K09RN2dsanhaL3RtbXVYS3gzLzErNmNJdXcvQThNcVYyay85dGNCRW9HU2o2?=
 =?utf-8?B?UkRCRXc1cExDenkvdWpxZUhjb0IvVStXc2lDdjJmYXVENHc4bHVNUlhiRmNr?=
 =?utf-8?B?WnUvZVZ3RmNUd0RVczhHT3BkMTZvckdsaklNQlNQYno3L0xNdmVJMDdxU2I5?=
 =?utf-8?B?YXpFbG5aYk1BZ0tRZTNLbDdQM2JBQ1ZHTUdLOW9oa01WeWxTVjk1Rk1xK3ZJ?=
 =?utf-8?B?OE9FeHE0V2d1dGpzT0dXbzRJOWJwclhGNmhSdFp4SjlQYXJBMG12c3pJcHpD?=
 =?utf-8?B?NWVhQWFJWlZaTFdHYWw5eEkyQ3FTQXNJR2FOVVF3QkxoSHlGcVBoNDFDUGlQ?=
 =?utf-8?B?R0QxYVpNWU05RHVsUzZvMmxKZzFrQms3ZUZJYU14ZDUzWm5wQ1BvUzBVVVNy?=
 =?utf-8?B?Unp4YWFSWFo2Q0IyT1NRUGdNVURKU0dlc0RPejN3ajl0SDVjREVwTDJwZnlT?=
 =?utf-8?Q?NkVKWxITTZEsC6M+o5PZaiY2EcbbOhMysqCU0YO/EY5j?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42d430f3-4df5-45c3-1c16-08daaa87943e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 06:20:51.2157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wk8okW8+0QOHJmFIuk+yGNSDo4yYgu0CUfIGHlreTzeM9p5Y7S2qavwKKN/EwWHEQ74u2rsOzsyr+s4ROZ5cWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9380

On 08.10.2022 21:08, Julien Grall wrote:
> On 06/10/2022 15:11, Jan Beulich wrote:
>>> ... the space cannot become ordinary RAM, then such a precaution
>>> wouldn't be necessary. After all hiding EfiACPIReclaimMemory from
>>> Dom0 just because it can't be mapped WB wouldn't be very nice
>>> either. I guess I'll submit v2 with this part of the change left
>>> as it was.
>>
>> And while already in the process of committing the patch I came to
>> realize that if the WB conditional isn't supposed to move, isn't
>> the change done for Arm then wrong as well? Shouldn't it then be
>>
>>          if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
>>               (desc_ptr->Attribute & EFI_MEMORY_WB) &&
>>               (desc_ptr->Type == EfiConventionalMemory ||
>>               ...
>>
>> leaving the EfiACPIReclaimMemory case entirely unaffected by the
>> change?
> 
> IIUC, the concern is the region EfiACPIReclaimMemory could have the attribute EFI_MEMORY_RUNTIME. Is that correct?

Yes, ...

> Given that the memory is reclaimable, I am not sure why it can also have this atribute set (to me it means the opposite).

... at least on x86 all sorts of strange/bogus type/attribute combinations
have been observed.

Jan

> But I guess for hardening purpose it would be better to use the version you just suggested.
> 
> Bertrand, Stefano, what do you think?
> 
> Cheers,
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 07:04:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 07:04:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419117.663844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohmpq-0002Wg-6k; Mon, 10 Oct 2022 07:04:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419117.663844; Mon, 10 Oct 2022 07:04:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohmpq-0002WZ-3b; Mon, 10 Oct 2022 07:04:22 +0000
Received: by outflank-mailman (input) for mailman id 419117;
 Mon, 10 Oct 2022 07:04:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=COA5=2L=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ohmpo-0002WT-UG
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 07:04:21 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60056.outbound.protection.outlook.com [40.107.6.56])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bdf5cd7c-4869-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 09:04:11 +0200 (CEST)
Received: from AM5PR0402CA0009.eurprd04.prod.outlook.com
 (2603:10a6:203:90::19) by DB9PR08MB8358.eurprd08.prod.outlook.com
 (2603:10a6:10:3da::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Mon, 10 Oct
 2022 07:04:12 +0000
Received: from AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:90:cafe::e9) by AM5PR0402CA0009.outlook.office365.com
 (2603:10a6:203:90::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Mon, 10 Oct 2022 07:04:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT029.mail.protection.outlook.com (100.127.140.143) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 07:04:12 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Mon, 10 Oct 2022 07:04:12 +0000
Received: from 32af92862b80.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7789DF43-2657-4214-B0B5-BBF05F08952E.1; 
 Mon, 10 Oct 2022 07:04:05 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32af92862b80.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 10 Oct 2022 07:04:05 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by DBBPR08MB6155.eurprd08.prod.outlook.com (2603:10a6:10:1f5::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 10 Oct
 2022 07:04:02 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684%4]) with mapi id 15.20.5676.028; Mon, 10 Oct 2022
 07:04:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bdf5cd7c-4869-11ed-9377-c1cf23e5d27e
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=HdZ6D9iXbS7AC/RDyAjKKOXArjxZOrvxxEsjzcrwAymw+dcujx/nzpHyfW5+Z6iT7CEXNDNOA6mbqG1bdAVcDsbiGFs3LCS/KWLGeZphhc8wcb8dlw0DzJLj2k3d3LTOncl2xnKUjTSu2evAS1MWhLduTY6KvnrIUbomjfbLm/Yft/EJHmtkJqPPTBFOhheWaRR2o2Bs3Hp4eBHdqGFHw8OpaFt8HRBVuM4Gur2igZ6sDl9NmvKZtam/tTu559q4UoqDVfCojzNeMT9DNwtSDauK7fbb2yFsMhuKVK8YijHERdd/c7qw57pOMLXhysYhVseqV50OGYOwsjNYNNi/DA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RXs+Rw3c07S61ga/EnGPnDlOFegROYKN+yl/244Q074=;
 b=f0TaJXiS3zSf3lYMU9S1dJX3C1BYSd92AFb7Ve00FTkE5aEHcCcdjmtOJd/zAnEMj+vme2N01IB42MIoh9a5Hq8ftZkcKvVYfr6E0kb+vSclRqRoAdJd/mZnEZotSZw4WArLeiNj2vUHyONveInYoWHpJBaMTHRQKHJ1XrlFBd3meBso6rFKf//qNpIAkctXovHWWB+EXRCSezNACWlBHPibW+GtFQFq3KeHjUINuzNST4UetJttpkp6GUAJgqsE0gn3NoKmhX1vCRyAqQ7qy+xXzxU6bJol75hLgUe1TMA9tO9IbrHDk7g+GdPDKSoXdNfzc8WeRMD1/tH0C7PLEg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RXs+Rw3c07S61ga/EnGPnDlOFegROYKN+yl/244Q074=;
 b=mt5SMSi6agSZC3lPfGXJ9oTxSod/ntXNptYIjg2w3qxjb/qxjzrMhmOG+ED4DbSw0iQEZbMwpT4mM7gan4Sv7hD86clo0rgYMUPHLkgjplcG1v4nqxYZdhVmvWOk7/F7/k8dwKCMCOO/v1pF60mrxbVOyIPwW4ysENp0q8nwgnI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9f8942d03c47dc84
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mmg+T+vYfwvpz0MXT6pdkoYHIC1wMAzblW0dn++sMjhsxAXAN3C/aNBGKxQYsp6ePPzIxTizaOl1n4mMSzN45iyOxKgxd5FRuU4wrVKhBUfTYOIjSlRqTaKL+8K/bPfxscumGE2zi1ksUVh/5pgH3Iqq+ew9CBa6AKGLCQvIlJmKhHUXBWEMkIetB4Pt77c5F4nv/x/rrkSCAAgH3uLvRGBzqVCg1IdLoeyJbzUN+BJ4NTEWKeDwtohdmkN1tnXzZKxRAmrCITmAx1iWEthiNZhsgb324hvAALnh8OTvKMr8DbZ5wQkLAaCdb/v9O+LeqMSGxRezKE2dTEnPLECq3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RXs+Rw3c07S61ga/EnGPnDlOFegROYKN+yl/244Q074=;
 b=O+ewbCVItR5XmaGceFuixHQAXNgD/pvL08F5N0z8ghRDZcDZWAq9AZPYXINzPyoehqr7YY343bxAtinRBt1SXJFFiICqdTdTKsDI9AzyUCa7+uePJeOg83D4PNa2OpDPWIDoWMyvJBIUqBlSqOj5bUV1pcfaY+RkC9JXFtOScXYRMX981/2SUE/DJ1OFEVS1ir68ezYBS8IdCa9FwnT9KVaelZWmUy/A5Ce09xNL08z6jv/S1lQgKRATIrlu/o7mSakmjkSZnDLqUkiUS8WXoZjSodqr7WiyVTo3i42E2drSBbJugOWn7NQtD1GlF7xU0Vh1tMgQPGv/knnG5uqoGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RXs+Rw3c07S61ga/EnGPnDlOFegROYKN+yl/244Q074=;
 b=mt5SMSi6agSZC3lPfGXJ9oTxSod/ntXNptYIjg2w3qxjb/qxjzrMhmOG+ED4DbSw0iQEZbMwpT4mM7gan4Sv7hD86clo0rgYMUPHLkgjplcG1v4nqxYZdhVmvWOk7/F7/k8dwKCMCOO/v1pF60mrxbVOyIPwW4ysENp0q8nwgnI=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Message-ID: <e28f8faf-89fe-1e8f-4b8c-77097c2f2a90@arm.com>
Date: Mon, 10 Oct 2022 15:03:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to
 common
Content-Language: en-US
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220920091218.1208658-1-wei.chen@arm.com>
 <20220920091218.1208658-6-wei.chen@arm.com>
 <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com>
 <fc03f565-8c05-e310-fa0a-698ad7c569e3@arm.com>
 <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com>
 <PAXPR08MB742077FE40B3FB0614787B599E569@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <9c32c4a9-d319-8886-c026-f33820a4f77b@suse.com>
 <PAXPR08MB7420DE5F342F17E77F5483879E219@PAXPR08MB7420.eurprd08.prod.outlook.com>
In-Reply-To: <PAXPR08MB7420DE5F342F17E77F5483879E219@PAXPR08MB7420.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SI1PR02CA0041.apcprd02.prod.outlook.com
 (2603:1096:4:1f6::18) To PAXPR08MB7420.eurprd08.prod.outlook.com
 (2603:10a6:102:2b9::9)
MIME-Version: 1.0
X-MS-TrafficTypeDiagnostic:
	PAXPR08MB7420:EE_|DBBPR08MB6155:EE_|AM7EUR03FT029:EE_|DB9PR08MB8358:EE_
X-MS-Office365-Filtering-Correlation-Id: f9ba7bb4-078b-4f2e-1c38-08daaa8da2c3
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2pH2ybIUkrqf4y8tz8WndK7EMkJL2NmF16tNARxqjpxoCz3pEgLjuqK0Vgkpi5lvZGEMbDysKkS9HiAuxhYoM6XZrEj34rqj7ODwAZSeKPtDDexpptay2fLiuWUk+XsvaWiaa1Fd00XIBC9Wm478EVlVlFQbu0w87NJwC9j4XMUMPrODPm8ssqKMOTojfSTkLjrsBcqGIEwUMZ7sqIs8LmqqAowAs3mjRi35fxNMrHSITHp3zLYVo9dgR9rWkwIDnqtOQQfEp37AP15sCxcGC+YCQn+ZlRGFuj/7zEScJyKyfNKvMcjhpZPVUh0vdKZEbnwPQ3c48Lxfgqkev+PCLi/xsj1Gc6yAS9+A/z263bLZWSuofsCd23NdYfFfF+/c6H9NkGZhh43VwxZuzp3NbYE9NunsjprBrlDBoRYxkdnCjeyCxPP7Xw0cFBJm43w3P5iLI8aKomYdhb6iQ7jIXuhgSQcyp7FKKQzDIY/F6lZP2oXrqF7APc/S6C8lydrbY28c8IwKyiNEl7U4/ed1puJGk/YHV2I6tDdtd24UOwMb3wgC8JwGX8UWgQF9DyX6U6W3JnmsyFd6x7YPsS4bX2BA2gkxRF3h/gataLQc6i5xc2eyVlL8SIL28gx+E1Za1m6V3c892kXhvMeEuF1sF8Jz4nEo1vBkNZAzTZpZ1m/l65ZKFXh5Dhn2sU8kKF3oc2wgsEkrLYjxYEaJ7pmAWyb7l96PVrgBfDAee1HOcQ9nVtm8YSe2y7mCqRhiiJfJDBbiKzPP5RcacWIMquh/I9pzewnOZ2HpwBBOHnnptFo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199015)(36756003)(31686004)(66899015)(86362001)(83380400001)(186003)(31696002)(38100700002)(6486002)(26005)(2906002)(2616005)(478600001)(6512007)(6506007)(316002)(5660300002)(53546011)(41300700001)(8936002)(4326008)(66946007)(66556008)(66476007)(54906003)(8676002)(6916009)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6155
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4a1e4b1c-15c8-4893-9631-08daaa8d9cbf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e2FGSrW9Me7V1F54UnzU785Y/02J2v6N8UA20aSu1U0y0FAfH/q71h+4gJAAbnW2ZHerwvR7DQCsvpLKJzK7q6PeV0db7djaEkvTlJBO/YXohfpDJHkPC8q6mNktZIUSLVCGoK2w48bwOQODM+7RdswprA7XpgjoxALq/89Dh9ksqGMHcoiYPCeN8Uu9K8KBmJ0ok5t04vChRaWMb3bdZ0krqerjRnsGt1QLtUFkbWjPeeL4P4jA2Lsxhohu4OOUQ8Wrr66+5vrSlR0rS6pYK3geMA3Jq/hwtqSgwxO2BNYgnD3vGxZ3FJ89a7nrG6yebojerkQ0rpwThZhw/RXiGrEFS54NkV3lebbXQ81FIBl66pE71Nkbf6HGckuYZZ+QkVdqfA4db14X20zdMv3RW/oVXRrYsY1bKyGCch9aLc6q3n04HKyAtYePpZKttPAbkSPgYyITuJ3Jlcxl2L/JH+jke1HMUQohDaF8Uv3/KusXq8UFmVETtFMBrulyDJpYz5uutcpS0n8ar8Xfl9BP2om68Hf/GHTtLiVFp6eeUPELDuXzPdDsAXtR3yO1P/v5qd5mDS74FkQUzDLIPUpsFjqfnLRz112hqkXpMDjieDldw/KXrk8mTkkuLUszWuP9RI+eELbCYYEV6bKhClWUaYLRb0V42NIm2e1ZO0h6tvn0E2mqJGzoXaSyO/Ob6CQAwLbQtxTJjgcpphjWQg2Koa+HKbTxeExvsjFCq2sKUQZtiZUKAnyW0ga4Lyk81g2kN11JhQDQGoFq1nQmVOHoNeyOb2qjMMxDWm35Pt33fdBM07Wblutrl/a/ndGx5Z+p
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(66899015)(186003)(2616005)(2906002)(82310400005)(31696002)(356005)(31686004)(316002)(70206006)(41300700001)(6666004)(70586007)(40460700003)(40480700001)(6486002)(4326008)(478600001)(8676002)(6512007)(6862004)(8936002)(6506007)(86362001)(36756003)(26005)(53546011)(47076005)(54906003)(82740400003)(336012)(36860700001)(83380400001)(5660300002)(81166007)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 07:04:12.3527
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f9ba7bb4-078b-4f2e-1c38-08daaa8da2c3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8358

Hi Jan,

On 2022/10/9 15:25, Wei Chen wrote:
> Hi Jan,
> >
>>>> Even more so an answer to my question would be nice: You'll then have
>>>> CONFIG_HAS_NUMA_NODE_FWID=y even on Arm (using PXM as mandated by ACPI
>>>> when in ACPI mode). But then what's the FWID for DT? I know it was me
>>>> to suggest this build time distinction, but I'm afraid I wasn't doing
>>>> much good with that (and I'm sorry).
>>>
>>> How about introducing a flag for selected NUMA implementation to
>>> set it in runtime?
>>> For example:
>>> bool numa_has_fw_nodeid;
>>>
>>> ACPI NUMA will set this flag to 1, but 0 for DT NUMA.
>>
>> That's an option alongside going back to what you had in an earlier
>> version. Another would be (name subject to improvement)
>>
>> const char *__ro_after_init numa_fw_nid_name;
>>

When I was dealing with this comment, I found that I was still a little 
unclear:

When we were introducing "CONFIG_HAS_NUMA_NODE_FWID", we wanted to 
eliminate the redundant code of:
if ( fwid_name not equal to "node" )
     printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr"%"PRIpaddr"]%s\n",
            node, fwid_name , arch_nid, start, end - 1,
            hotplug ? " (hotplug)" : "");
else
     printk(KERN_INFO "NUMA: Node %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
            node, start, end - 1, hotplug ? " (hotplug)" : "");

But when I am working with numa_fw_nid_name, I find it's still not
easy to reduce above redundant code. For example:

"NUMA: Node %u %s %u
When numa_fw_nid_name = NULL, we can print "" for %s, but can't reduce
the second %u.

So can we split this message into 3 lines like:
     printk(KERN_INFO "NUMA: Node %u"...);
     if (numa_fw_nid_name)
         printk(KERN_INFO " %s %u"...);
     printk(KERN_INFO "[%"PRIpaddr"%"PRIpaddr"]%s\n"...);

Or another option, we can force each NUMA implementation to assign a
string for numa_fw_nid_name. For example, in DT NUMA, we can assign
numa_fw_nid_name="SOCKET".

Cheers,
Wei Chen

>> which for ACPI would be set to "PXM" (eliminating the need to pass
>> it to certain functions, albeit the fw_nid will continue to need to
>> be passed anyway). I guess I'm not really certain which of this and
>> your earlier approach I prefer; the boolean you suggest above looks
>> less desirable to me, though.
>>
> 
> Ok, I will follow your suggestion.
> 
> Cheers,
> Wei Chen
> 
>> Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 07:30:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 07:30:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419123.663854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohnEt-00067M-AU; Mon, 10 Oct 2022 07:30:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419123.663854; Mon, 10 Oct 2022 07:30:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohnEt-00067F-73; Mon, 10 Oct 2022 07:30:15 +0000
Received: by outflank-mailman (input) for mailman id 419123;
 Mon, 10 Oct 2022 07:30:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zpu8=2L=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ohnEr-000679-9M
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 07:30:13 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5ad569ea-486d-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 09:30:03 +0200 (CEST)
Received: from MWH0EPF00056D15.namprd21.prod.outlook.com
 (2603:10b6:30f:fff2:0:1:0:1e) by BL0PR12MB4899.namprd12.prod.outlook.com
 (2603:10b6:208:1cf::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 10 Oct
 2022 07:30:07 +0000
Received: from CO1NAM11FT107.eop-nam11.prod.protection.outlook.com
 (2a01:111:f400:7eab::205) by MWH0EPF00056D15.outlook.office365.com
 (2603:1036:d20::b) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.1 via Frontend
 Transport; Mon, 10 Oct 2022 07:30:07 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT107.mail.protection.outlook.com (10.13.175.97) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 07:30:07 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct
 2022 02:30:01 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct
 2022 00:29:54 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28
 via Frontend Transport; Mon, 10 Oct 2022 02:29:54 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ad569ea-486d-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z67TUcNQKzIfbwKP5sQTnuLFlbqa7beqiafxZORXa7cF88nYhJJZVkwzBzLpnFfsrxqJuwMfGLQ4hGqoEqpMfzK+0VeoPzgTQh4GDzfJ++m2TcAUP10MILyOmFczegXEG2JRtjFV1XD8tIr1oCZILrujavc1Qxtq1ecr/gDtcaKjlTxshS2QjrugrdkD4Yrk+2MYdTY2wBzXTFynwcfSfk3VIepIuYO9uea9C+BUKVAtBu04f3L4D+aj6lrvN2kyAJibHSS1DWEY+0ddZqo4e0S2MzUyYeI2REUyTsI3oU6r7cPZDfwBzQIxDTVnjmQuk7ImIu5WEUehVCVqKB25Mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/RAfJpdwynmbz/rlQlWCjryMbpbTDFitdlWEPh1RlAQ=;
 b=cVN013k3gJGLmFgsh0AFgQZKCLC6W4A+N2Ow9oghoq6cntitoRj7sMb2xGcPtdcxNbcq6thZUC5op6/2kBySrIcbTIqdeubyEx1HWbBfkFM7ZK59/UF1CxBFT2iZBM3vampkHIVrA4QcMDpSO8WPeVsQ0F9hiDxcFLUk6XwU0ZJJotQ3kjH5moJqdL0JzxTAMB3tt9FYHe70tpq0H42J9lX3h5E1T+xnPQHuWP06+Cka2K44vjVVeo0QlwqEvAZdFdB9zFB4d9PcL1pHHmrR2+zHtAdIVxAHlS61y8JKYnh7xZITE+IVfvDuj/fmeuAgW9a9mCCWOr8PmZMkpXKj5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/RAfJpdwynmbz/rlQlWCjryMbpbTDFitdlWEPh1RlAQ=;
 b=a1VaQXog0Tk6jLXmZx0LEIl8v7TbpxFY3Yv2X+xg/QZDRa7FI1FvS1DbnAgAChXg7CYhc0XvUT3U+GDBi4SCThyKysIJiNATjh73PJU61vKM6YmmHAF0SARwzd79LeJKfAy37PAnRnrrN+Xi9aoIrzLa7aLlNMHkyZNX4bedwe4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, Michal Orzel <michal.orzel@amd.com>
Subject: [ImageBuilder v2] Add support for 64-bit addresses/sizes
Date: Mon, 10 Oct 2022 09:29:47 +0200
Message-ID: <20221010072947.8300-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT107:EE_|BL0PR12MB4899:EE_
X-MS-Office365-Filtering-Correlation-Id: f3ad1132-65f8-4520-7a83-08daaa91417e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W2Oyzcp6M3St+DfQogNP101GTBXSmDrQP6W7aA8ESH0vONktP7mGJU/znaebQVPVYVM+a+jRHS+qBRShgNKeUlb/awlj+RDAOI3GHoQojyzDI96ttmlHljy+dH92Qmq8d2T3FbnS02eDd4enTXSUtQEz7rwAL76O/3B8rmC50vwXyG0hS8W2iRwlVTt7s21B6orHzUjBl8erYjjd0Ng2UGwZ+qSdh5bXj0qiE3E9XRatV9VAIMfhYvAvAfLipcEEp9gwJNHtWVp+d1qW6T/JQb2axRYV6lK3Hk3jzUZ/Ml3/j3p7puEBhhK35NWNwC9M7szREg4Es1MNwfsgyr2DK2dSNPl8NjuBS203HNL8g38/fPOp6mJHoKaBC8YGReIoOspos5zeQ0pHpM7NETG6WYrT25olw5pPqxCE+3V+vqmvgn8psmQ5fAV6OBSl4sP4XExM39Gl/UiGXbfonHCM+dKfvihGfK80OsOda2vCEewu29Vgj0RwPQ1MEjN8IWU/FjPtJasvGaSUOEm/YWhGMt/H18n9KbizB9SBQrVYYdJiPA2N2EJEXEuOhdLv7Xu6cxma8+TcDflZ92d9nS7vw4qvZ0TltLjjAhK3E+bTG4QuwMq1ZoFEnbujWqmO7iLvr0BzQncCoKnnAoX5CCsW99X9SYzaooqzFzWYAzGqnAhsAhwXTG7sKNyJGQ3h6yBe3sHkxwt+xpoe8HwLyb60tjM0ziYnnakav0OEERx+ZMpgSgqb0/SeVnDATEBPBE4fkelWnLHLGiEDWpysgrUGJPPXIyclf8wO+GohoQMvHH4=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39850400004)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(26005)(40480700001)(6916009)(82740400003)(81166007)(4326008)(36756003)(40460700003)(478600001)(86362001)(36860700001)(70206006)(54906003)(6666004)(2616005)(83380400001)(316002)(8936002)(336012)(356005)(70586007)(5660300002)(82310400005)(8676002)(44832011)(186003)(47076005)(1076003)(426003)(2906002)(41300700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 07:30:07.0415
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f3ad1132-65f8-4520-7a83-08daaa91417e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT107.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4899

At the moment, ImageBuilder assumes that all addresses/sizes are
32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
value for the first cell. Because of that, we cannot specify
MEMORY_START and MEMORY_END to be above 32-bits (e.g. to place the images
in the upper memory bank).

Add support to properly handle 64-bit addresses/sizes:
 - add function split_into_halves to split the value passed as a first
   argument into upper and lower halves. These are then set as values for
   variables passed respetively as the second and third argument,
 - add function split_addr_size to split address and size and form a
   string to be passed to dt_set as data argument for reg property.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Changes in v2:
- redesign a patch based on master-next instead of NXP dynamic assignment patch
---
 scripts/uboot-script-gen | 33 ++++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)

diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index b24dca2b7f7e..09d237d192c1 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -22,6 +22,29 @@ function dt_mknode()
     fi
 }
 
+# Usage:
+# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
+function split_into_halves()
+{
+    local value=$1
+    local upper=$2
+    local lower=$3
+
+    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
+    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
+}
+
+function split_addr_size()
+{
+    local addr=$1
+    local size=$2
+
+    split_into_halves $addr addr_upper addr_lower
+    split_into_halves $size size_upper size_lower
+
+    echo "$addr_upper $addr_lower $size_upper $size_lower"
+}
+
 # data_type is either
 #   int
 #   hex
@@ -93,7 +116,7 @@ function add_device_tree_kernel()
 
     dt_mknode "$path" "module$addr"
     dt_set "$path/module$addr" "compatible" "str_a" "multiboot,kernel multiboot,module"
-    dt_set "$path/module$addr" "reg" "hex"  "0x0 $addr 0x0 $(printf "0x%x" $size)"
+    dt_set "$path/module$addr" "reg" "hex"  "$(split_addr_size $addr $size)"
     dt_set "$path/module$addr" "bootargs" "str" "$bootargs"
 }
 
@@ -106,7 +129,7 @@ function add_device_tree_ramdisk()
 
     dt_mknode "$path"  "module$addr"
     dt_set "$path/module$addr" "compatible" "str_a" "multiboot,ramdisk multiboot,module"
-    dt_set "$path/module$addr" "reg" "hex"  "0x0 $addr 0x0 $(printf "0x%x" $size)"
+    dt_set "$path/module$addr" "reg" "hex"  "$(split_addr_size $addr $size)"
 }
 
 
@@ -118,7 +141,7 @@ function add_device_tree_passthrough()
 
     dt_mknode "$path"  "module$addr"
     dt_set "$path/module$addr" "compatible" "str_a" "multiboot,device-tree multiboot,module"
-    dt_set "$path/module$addr" "reg" "hex"  "0x0 $addr 0x0 $(printf "0x%x" $size)"
+    dt_set "$path/module$addr" "reg" "hex"  "$(split_addr_size $addr $size)"
 }
 
 function add_device_tree_mem()
@@ -260,7 +283,7 @@ function xen_device_tree_editing()
     then
         dt_mknode "/chosen" "dom0"
         dt_set "/chosen/dom0" "compatible" "str_a" "xen,linux-zimage xen,multiboot-module multiboot,module"
-        dt_set "/chosen/dom0" "reg" "hex" "0x0 $dom0_kernel_addr 0x0 $(printf "0x%x" $dom0_kernel_size)"
+        dt_set "/chosen/dom0" "reg" "hex" "$(split_addr_size $dom0_kernel_addr $dom0_kernel_size)"
         dt_set "/chosen" "xen,dom0-bootargs" "str" "$DOM0_CMD"
     fi
 
@@ -268,7 +291,7 @@ function xen_device_tree_editing()
     then
         dt_mknode "/chosen" "dom0-ramdisk"
         dt_set "/chosen/dom0-ramdisk" "compatible" "str_a" "xen,linux-initrd xen,multiboot-module multiboot,module"
-        dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 $ramdisk_addr 0x0 $(printf "0x%x" $ramdisk_size)"
+        dt_set "/chosen/dom0-ramdisk" "reg" "hex" "$(split_addr_size $ramdisk_addr $ramdisk_size)"
     fi
 
     i=0
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 07:51:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 07:51:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419130.663866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohnZh-0000RQ-7r; Mon, 10 Oct 2022 07:51:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419130.663866; Mon, 10 Oct 2022 07:51:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohnZh-0000RJ-58; Mon, 10 Oct 2022 07:51:45 +0000
Received: by outflank-mailman (input) for mailman id 419130;
 Mon, 10 Oct 2022 07:51:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohnZg-0000R9-Hy; Mon, 10 Oct 2022 07:51:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohnZg-0007t7-DQ; Mon, 10 Oct 2022 07:51:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohnZf-0004KP-Pa; Mon, 10 Oct 2022 07:51:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohnZf-0001ku-P7; Mon, 10 Oct 2022 07:51:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XDXbmkVdIDuCe1+j+Vg/GUgo2sTvo+dk47Ip2EaBrnA=; b=0864tyzszOE5iz64qjw3IkoxiF
	e5UzuXumLQI/cKKfW23i/+QuMiLhImx7a3B/Ljne0tU0K6s/lStqe+sktv4WvrtoebjT0kkvEXo8T
	6Kxe99SeaVKVXkn+KEskRp1gtDyP5imjNjmklq/r/+aRt1NppNWmwJapKg7u4wRtsTuo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173482-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173482: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start.2:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:debian-fixup:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 07:51:43 +0000

flight 173482 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173482/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 173466 pass in 173482
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173466 pass in 173482
 test-armhf-armhf-xl-rtds     19 guest-start.2    fail in 173477 pass in 173466
 test-armhf-armhf-xl-arndale   8 xen-boot         fail in 173477 pass in 173482
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173477 pass in 173482
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 173477 pass in 173482
 test-arm64-arm64-xl-seattle  13 debian-fixup               fail pass in 173477
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat  fail pass in 173477
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 173477

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 173477 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 173477 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173477
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173477
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173477
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173477
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173477
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173477
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173477
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173477
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173477
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173477
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173477
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173477
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173482  2022-10-10 01:52:00 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 08:25:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 08:25:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419147.663877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oho68-0001eX-EV; Mon, 10 Oct 2022 08:25:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419147.663877; Mon, 10 Oct 2022 08:25:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oho68-0001eP-8K; Mon, 10 Oct 2022 08:25:16 +0000
Received: by outflank-mailman (input) for mailman id 419147;
 Mon, 10 Oct 2022 08:25:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zSpT=2L=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oho67-0001eJ-NZ
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 08:25:15 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c738bf0-4875-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 10:25:07 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7659.eurprd04.prod.outlook.com (2603:10a6:10:209::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 08:25:12 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Mon, 10 Oct 2022
 08:25:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c738bf0-4875-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lymyZagojSFVxGn8zq7ACRAiS5L8QBpF/3y3FXfqfA8uB5WErJolvRp50I6gSWlscx0l2kgDVK3cbFSxzg9mhfqgk9xlWuPPV20orDMJn0uqD8kZZHN/or9OhG0SPI0InFoajVyvG6hmJzaS6P+Fjuxb8gaYySLnSyj9DOdRBAWRtbl9qbWGenygwIVpvZAI2Yi3PWldZjmsWUZ4gO84hSC0NiCMmKjPf7ROZqI2rpSOG1ojbtO8OVHy2eqP6GikFI+nyXxo9oiKs9gPw4N8BLSzQv2DyprLYVLtQeMAXqgb3Yn/ujak2SaZfpP7FoSaZmPkC7REp3WMkJmdnIydAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=USG35lcqYGmV0PxdvXYh3KCA99nEvFvkAAmaVTCXjmQ=;
 b=d6+V7y9+RnlgSp1oWE8tz8BYDXfULBCxwPBMpJRUe5qx+3MTbsYl5xDhHCu+0bTcMqwzqpJ69TGImGcsi9NkAQZZMg11sUIzV5XOMjXTKkfy/97Iu7/67GJvRgahNGVhv92XdmC09+PUcU6ZL8kCyEiKy0Em9eIqsyus9BbfxZ9J5/sq2U/2yj/ehlNB4lbz0V6Vnkp7BfSHaq/ZO3XvMzPxq64IU4vwXHBbIUNkRUhSdSN1k8bKxkP6cU6dsCEf5Ay7aZEp8HBt2WGj/6iqJkf6/3J57eu+Qnpii+UOenL5M+uIwm02C5LmxFDvHwn5HI8BXL53ItyuXtiYsmb3sw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=USG35lcqYGmV0PxdvXYh3KCA99nEvFvkAAmaVTCXjmQ=;
 b=Xn01D4/FSczfhYdIYyBLq5iptol3BABK4sNvB1M8wjhOJR8gjK/Puh2tqIU02kQ3IHdvsxI8t8tiVGKX08EpCQhlRLev9OzjmyEToWe5iskCD07vheAICYyxoxU6EA2cj3rNh4JWSH6rz1sfPZzpL5agPApbU0cm55NVYL/XxLxDY2Q5bjkaLE1YJ6e1+L97fgf1GTCvZlNNXLRUmzEDxY2ZOIrl1OpByd+4fiL2nFzu/cN81OtHPMpiiHRbLZl8znNWnSf6b0WENqmOphi1IoLUlXDEosm2wt1vmhc6ztX8/7vIFaKwYwyAvEnacKsBOI7J7ZWTU/oNC1YbIiY2IQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c78ff556-ffe3-52d1-65b0-75153c1472a8@suse.com>
Date: Mon, 10 Oct 2022 10:25:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to
 common
To: Wei Chen <Wei.Chen@arm.com>
Cc: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220920091218.1208658-1-wei.chen@arm.com>
 <20220920091218.1208658-6-wei.chen@arm.com>
 <5ac85819-9a1d-b8bc-d49d-13cb34a3e7e9@suse.com>
 <fc03f565-8c05-e310-fa0a-698ad7c569e3@arm.com>
 <47ec8e01-8ea6-4678-78c2-c67305fe3b7a@suse.com>
 <PAXPR08MB742077FE40B3FB0614787B599E569@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <9c32c4a9-d319-8886-c026-f33820a4f77b@suse.com>
 <PAXPR08MB7420DE5F342F17E77F5483879E219@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <e28f8faf-89fe-1e8f-4b8c-77097c2f2a90@arm.com>
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e28f8faf-89fe-1e8f-4b8c-77097c2f2a90@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7659:EE_
X-MS-Office365-Filtering-Correlation-Id: ec9453ea-edea-406a-1cfb-08daaa98f35a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FULXUuDeYqXB5imG1upSihJp13rdNTQD+5o3aGaltzSwB1TcZ1wDFYQYSUullQbp6I0g+qc+tviVlG2axKep3p93zEqUMhc5Sz/sa6F+8B9W4XIzkkowtLC7c4fsHm5KNooUXw4SEi/kOu+y/h/pfIsX1hp3bfLeiFkwOCOnpHTFRpXUHSdODzanKMZ9G4K8pnFRnWt5nLUps5mK9ho7Z8ienf/JtQdlgu6q48zJDskImsSwT5E01IfdLT2CjWSahmx4iSDbQ5vTp/0JEXxdolS7ln/FTr5uPOLRW5E5eV7DI0UqhHv676JDdUm66GOXvN54k7uyV9jrpdjL4gVTimgNp+dWtG/cGdPllQepIU70CU5a2LbCFNgAHTrKG8LbS2Fo6/FYF75a9PGhXPWpebtpABQI5+nN73Z86ZSb0OZJDWg1lCgTc5Zc6sRrWeplgquMiKNbgGIn5U90GH1xgn+mRpx5UTo2kgRomau6/OHdjtW+LjP7wVPuRn58L0QRG5XLNmRBi+Fc/zVFIMp1bZHTYD5/Qhrsr0N7u6rARVl2/PNlU7ZHehuG9+3W513hiNscJWTDeG1Eb2diIL8MH8t2arFtTQeWqkikLHxO9oUU51UzZ7n3CcMBFDycjdbnehjtPqabBbeohMVgHonzdfVgCQvQsOVhYBVPkpDRM0bJnhHLdxUhKkgPRJML90GN9kPyL20yRiOcixHXKvf47nfAjihtPUbqCs75Z4K6Q2ynFiTuPP3B0lL1AWA/qINgc+Tc1we0cqDxsZMiNZoTR+spcDYjelBkkR0OwshAp9U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199015)(186003)(66476007)(83380400001)(2616005)(5660300002)(38100700002)(8936002)(41300700001)(2906002)(4326008)(478600001)(8676002)(53546011)(6486002)(26005)(316002)(66556008)(66946007)(6512007)(6506007)(54906003)(6916009)(36756003)(86362001)(31686004)(66899015)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b3BXRlhOMlRoRlRIUW5ZSmd6TFZSSGlvRFpjSEFkeFlNOEFpb3JURldMaXZ4?=
 =?utf-8?B?cThBeTJ0VG5FZ1JFZWdhMVdqQnU1b3NLUEdQbFI3NnZQUUF3bkZONFY2MkVP?=
 =?utf-8?B?T1NVS1Y2VXVqYlAvcDAySVJFU2pqNzlURGlTUTA2L0h0MzNNVU5MT0FZbDVI?=
 =?utf-8?B?Q29ockorcGRtNGo0Z25NUlB2QVhNK3BCZHoxenc5RDZ2T3p2Qy9CUVVZZTRE?=
 =?utf-8?B?NTNyUURwTUxBS29WcW81azFGYktTcDJBamYvaEE5TytXeW52djdkR3FRY1Rt?=
 =?utf-8?B?em81V1d6bUhhbmxjb0RLeHZuN3o1NlA1K3ZqcVMxeGhOTnovN2cwYmZDKyti?=
 =?utf-8?B?ay9hbEVSU0NiWE5NUlMrZWk2WCtlTFYyTFh2akJTMVUwdUxQb0lmNjRyM3dL?=
 =?utf-8?B?RHJ0SWJqTUNWTGZ5bzMxTFlJTXliVnVvUkRmZFp3TDZoRjlIaHdnK2hRaXhK?=
 =?utf-8?B?N1ZGTnVTWklydVpDOGRkcWxnSHhoTTVBU1ZITnVoNHdabGYvSlhKYjl2bTdK?=
 =?utf-8?B?ME1RanJPamR1bC9DOHAvQW5kajRTWXFmQTJ0VU4vNCtJMUtHMUFsMzFydVZS?=
 =?utf-8?B?cFRSYnJ3anp1T2N2aFRaR2gwNzFPRWd5T0RjVkxKa01NcWY0bjNlR3hHVXdB?=
 =?utf-8?B?MUpRazYxckwrOTlrL05CTktPa2VEcjNqTTR6SmlvdElMQ05ESkU0MXllV1Iw?=
 =?utf-8?B?c0NTbnJTTi9OK2MwZEY4SjNaMFVaVWVkSFh5WHpmcXhjMWkyRHVEOFlLc3d0?=
 =?utf-8?B?cFA1endvbHJ3QjN1VWRFanRjYXczU2x4NzJkTDRHd2VVQTI3aHNzK3hUbGMw?=
 =?utf-8?B?bjRzcjFhSDk3RDlYR3hVMnlsOEJtUGJib3FKQUdVUHJWUDc2aUdjb1Q0NERu?=
 =?utf-8?B?bVNHeWRmUVF6dVRDQUlzMGdwUmNMLzhXUzJvNWhJVDIyQ2ZkYitYMENBQVlJ?=
 =?utf-8?B?b0N4bEpnUmY5cWVQWFhKOWtSUU4waDhWQmV1UXp4OEFGZjlPK094OEFPc2F0?=
 =?utf-8?B?cEZZYXFlaU1YSEhyN09BYS82dXd6aFE5bVpldU5CdmwyRytzRDlsZ1BHeGF1?=
 =?utf-8?B?c2pQZkZROHZQS0xrcng4WmlVZ3N0SG9KK3E1M2RuOStrVTBCVnRNcit2NStq?=
 =?utf-8?B?eTFlZGVRemE1UUxqcWcxazBoL0NLUVlsMDVaY3ZocXF6UHhmb2ROcUY5TjFn?=
 =?utf-8?B?Mk1wQ3hUMUlCYVFsRGdkUUZBNVFYTUR2cjFNVWczVWY0ckV6b21MVFQrZ2xW?=
 =?utf-8?B?VWZjK1RDeW1zTmExZXVxMlVEZ3FHaTJ5YUYzSXFJY1lBdUMydzQ3WVJCNjBr?=
 =?utf-8?B?cFloUXpYSTVaRHN5M3ZSUmtlUGlQWHkvb2p4WG1NRzZiTkJoRXlURjNYK2FW?=
 =?utf-8?B?L3R2SmdQbkQ2eDhwUlppWmFTNDl4Ry95MUxBYkpNMVB3eGphclBsV1NtVmFv?=
 =?utf-8?B?bFFIU1BXRnVKSkVCMHp1dXJNRTNBOStVb2g0OUkxUExvTmFRYTVzMnBUTkti?=
 =?utf-8?B?R0FyRmdOQUJib2I5VngvekxMVjMvVGJuMThQQTdGcmhTNnY3cHF3WjVVUWFP?=
 =?utf-8?B?Qy9TR0EwNkpLcDdOVVJUMCt4Zm80Zk44RGE0a0tWN2QwaWNKVkszVGJ6Vzdj?=
 =?utf-8?B?UlhMS2g2K2N4UHh5RVgwNnFMZzFoaUtQblRDRjVxNW1BWDF4REhZZHNUV21Z?=
 =?utf-8?B?aHBjd01ydkNuSXg4OUdhWkNZclNhWUhYVVpkL3dlZnpLQ25rMlFhMCtSdUVS?=
 =?utf-8?B?aDRVK3ZzWHZVaURuT09uL3BBSlV6OHBtTmY1a3BKWEdMa0ZRcjhDMnFRckRS?=
 =?utf-8?B?V0E4aEtCNjE5alFjdk0wRTQ5UnVtbytKWk5ZY1B0YlNaa0ZWYXBjcUE0TTRo?=
 =?utf-8?B?UVo5Z1dia09HZDdyWnVGam1YYzdoM242RElMbHRIQmpBclZ5NTdrK3ZhMTEz?=
 =?utf-8?B?WnZjNGlFUk9lazFwZjQzYU00eFRlOUd2YXJMcmtzYTd2MnJRTjBrakp3eHla?=
 =?utf-8?B?ZFhsNU9RU3lFRXRveEFLbHBWRXUwZzVQQ1N5N1I0UlpiOG5TaXYrZFhzN1NC?=
 =?utf-8?B?dmI3b3RFc3NUN3J0T0czWjVUdFFxS09sNXBmRDhUMTUxUGFIOFl3Nk5MaDVi?=
 =?utf-8?Q?Uw86yw/gzMyqjL0G0bwEfiaLU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec9453ea-edea-406a-1cfb-08daaa98f35a
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 08:25:12.3366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F6z1gnI69KThlQKy6yKf2ZKHHNiLvptiUyB9VbaKyTjSWFrPKe34KEfdT0BB/InlF7UyhUK/RLxzo8tAJ/TaVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7659

On 10.10.2022 09:03, Wei Chen wrote:
> On 2022/10/9 15:25, Wei Chen wrote:
>>>>> Even more so an answer to my question would be nice: You'll then have
>>>>> CONFIG_HAS_NUMA_NODE_FWID=y even on Arm (using PXM as mandated by ACPI
>>>>> when in ACPI mode). But then what's the FWID for DT? I know it was me
>>>>> to suggest this build time distinction, but I'm afraid I wasn't doing
>>>>> much good with that (and I'm sorry).
>>>>
>>>> How about introducing a flag for selected NUMA implementation to
>>>> set it in runtime?
>>>> For example:
>>>> bool numa_has_fw_nodeid;
>>>>
>>>> ACPI NUMA will set this flag to 1, but 0 for DT NUMA.
>>>
>>> That's an option alongside going back to what you had in an earlier
>>> version. Another would be (name subject to improvement)
>>>
>>> const char *__ro_after_init numa_fw_nid_name;
>>>
> 
> When I was dealing with this comment, I found that I was still a little 
> unclear:
> 
> When we were introducing "CONFIG_HAS_NUMA_NODE_FWID", we wanted to 
> eliminate the redundant code of:
> if ( fwid_name not equal to "node" )
>      printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr"%"PRIpaddr"]%s\n",
>             node, fwid_name , arch_nid, start, end - 1,
>             hotplug ? " (hotplug)" : "");
> else
>      printk(KERN_INFO "NUMA: Node %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
>             node, start, end - 1, hotplug ? " (hotplug)" : "");
> 
> But when I am working with numa_fw_nid_name, I find it's still not
> easy to reduce above redundant code. For example:

As said - this attempt to limit redundancy was a mistake when it comes
to the existence of two models in parallel for an arch (with either
one picked at runtime), unless ...

> "NUMA: Node %u %s %u
> When numa_fw_nid_name = NULL, we can print "" for %s, but can't reduce
> the second %u.
> 
> So can we split this message into 3 lines like:
>      printk(KERN_INFO "NUMA: Node %u"...);
>      if (numa_fw_nid_name)
>          printk(KERN_INFO " %s %u"...);
>      printk(KERN_INFO "[%"PRIpaddr"%"PRIpaddr"]%s\n"...);
> 
> Or another option, we can force each NUMA implementation to assign a
> string for numa_fw_nid_name. For example, in DT NUMA, we can assign
> numa_fw_nid_name="SOCKET".

... we can assume numa_fw_nid_name to always be non-NULL (is
there's any way to reach this piece of code). I have no insight whether
"socket" is a correct term to use in the DT case; that would need to be
confirmed by an Arm person.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 08:46:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 08:46:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419154.663888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohoQu-0004Lr-4r; Mon, 10 Oct 2022 08:46:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419154.663888; Mon, 10 Oct 2022 08:46:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohoQu-0004Lk-23; Mon, 10 Oct 2022 08:46:44 +0000
Received: by outflank-mailman (input) for mailman id 419154;
 Mon, 10 Oct 2022 08:46:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Lj0t=2L=siemens.com=jan.kiszka@srs-se1.protection.inumbo.net>)
 id 1ohoQs-0004Le-1F
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 08:46:42 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e9b05ee-4878-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 10:46:40 +0200 (CEST)
Received: from FR0P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::6) by
 DU0PR10MB6108.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3e4::20) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5676.19; Mon, 10 Oct 2022 08:46:38 +0000
Received: from VE1EUR01FT048.eop-EUR01.prod.protection.outlook.com
 (2603:10a6:d10:96:cafe::ad) by FR0P281CA0140.outlook.office365.com
 (2603:10a6:d10:96::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Mon, 10 Oct 2022 08:46:38 +0000
Received: from hybrid.siemens.com (194.138.21.76) by
 VE1EUR01FT048.mail.protection.outlook.com (10.152.3.69) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 08:46:37 +0000
Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by
 DEMCHDC8VSA.ad011.siemens.net (194.138.21.76) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.2.1118.12; Mon, 10 Oct 2022 10:46:34 +0200
Received: from [139.25.68.37] (139.25.68.37) by DEMCHDC89XA.ad011.siemens.net
 (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Mon, 10 Oct
 2022 10:46:33 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e9b05ee-4878-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OGgTFgLML7ftpomyo1pbBC+6XMwCY0/MeqnrvRvk2SPljdUhH0CXMEvgpHjeTLDfnYNsRJUUTz9DlqSCEEBX40Lc+vnOcglUsC6ySgOp/o702BmPde7p3L901ChJHN48l4Hd0Ai6SkgzJAEF78iOoWoIZptprjwjO13DXjRLDRwpfS/GtAQMRG7SjMD1JrunVc/aLVzcdMq2S8f3/zc8S3GKGic7lFDVjImyN8eUCSv4eBh6cK6ehzI4CCM4sjCdgIgt3uUcBBk3wZc/qyCGrJ9iq0Z4KWyUiMbwgdO5w4G5r3rS7MH/ZRaKAi7hkZmIaEOEPPzFCNN/m2rUv/4/6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M3F4/Mg5QZArYB53vsIqqIhiUrWNKzG4L7HrJ8U7xVU=;
 b=Se1Z4CFSDnTVs0Gf6ea80kNm+07xHCBfFpi2ibHyWuaWqkCrBQ3vtDVHdj0cRhTffFt+aCtn579Tt/zVJOadpfMfE7f/YsejmhbjDgFO+F7Ys7WN3B1bXZrp0fWQ/518ArNbkr0KBXeaVePAlnlZimWP+HhuPU0Gfrxj7EQUgbMcn4OQwyDKQWe5QIlVOAQYQSPC4ayausoYlXg6LRLB0IbgARlhzrXPctQnWbuZQjXKYCdMtMt32S+gpDR8MsxEFFbJjxjPAgWXMLVK0yVF9m6JXbMDJTDoAa124IVh2qTzf49UIwg8Tr22WcPiCln2lhFNeEKeHYaWvowyyijQqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 194.138.21.76) smtp.rcpttodomain=alien8.de smtp.mailfrom=siemens.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M3F4/Mg5QZArYB53vsIqqIhiUrWNKzG4L7HrJ8U7xVU=;
 b=ahcKejpz6ulUWKDfkg6pMqVpLNEhTnTgZNgDN/wiqKDIYK73lMdOJ7Jo+OQ5k95/YxSy4tz/vDSniCiVipqFFAGFK9PXjPB0j8hzE4YzJPguhA5BPqc/GqWMp/MS0WJd0QfFt+5QArZOEx+ZPjnRnHCnc5rl10grp83wkmb0FzLJbE/vEGOq5cXF1Be3jb6EY4v9LRh2O8PG+tNDmZ3YcSHlTkRxuPZ6AuKXXpdC3gA3uiFs3imoNPSZ9sDoOlrxBvbhpJbb77kGlIsHLW1fksIgtG4tHZ27W+/uOAK+WEaglbupmUrRt0UgG/VfvPkHQhZSH/J6NRs8Bc1SYEEnpA==
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.76)
 smtp.mailfrom=siemens.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=siemens.com;
Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates
 194.138.21.76 as permitted sender) receiver=protection.outlook.com;
 client-ip=194.138.21.76; helo=hybrid.siemens.com; pr=C
Message-ID: <c4c35f8a-47ba-5e24-18e7-5190330c7e2c@siemens.com>
Date: Mon, 10 Oct 2022 10:46:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>, Ross Philipson <ross.philipson@oracle.com>
CC: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<dpsmith@apertussolutions.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<hpa@zytor.com>, <luto@amacapital.net>, <dave.hansen@linux.intel.com>,
	<kanth.ghatraju@oracle.com>, <trenchboot-devel@googlegroups.com>,
	<jailhouse-dev@googlegroups.com>, <xen-devel@lists.xenproject.org>
References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
 <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>
 <Y0GTUg1ACpKZYMHY@nazgul.tnic>
From: Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <Y0GTUg1ACpKZYMHY@nazgul.tnic>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [139.25.68.37]
X-ClientProxiedBy: DEMCHDC8WBA.ad011.siemens.net (139.25.226.105) To
 DEMCHDC89XA.ad011.siemens.net (139.25.226.103)
X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007
X-TM-AS-Result: No-10--19.017700-8.000000
X-TMASE-MatchedRID: ObgwaKFsELAhz+KjBN9OufDMpLU9EzbQXKlUkWaHqwvx5KZMlKYS/XFa
	/hQHt1A1uSti1BoHqPa/jCH0Rcd4ASFDPhCO3zhjWO3sffakmrSULKc3M3OLX+ds4fnKv9CbT5y
	sQDj6eFk8cwBuO6HB35qG6AqjBmI1tQ6RnhDKnkCDC+22jz8Xi5v831J4kXLFsFkCLeeufNvESS
	xPxTa9gwaYevV4zG3ZjBYhGYtVarnOH38lNbOoTEwKCRzf8GZNB3U7YNIjWSM37vkU5XIl4IeAP
	CkZqxntBm9f7S94IJwlwoDYzPfxXyeOufXFPnmGPeqHl9AJspVMFlcbo5fDhC2416nc3bQlkYC3
	rjkUXRKUAUfla+IhaLKXWmEvaG3ElyyR46PvItPv291MwfmTC5H0YXYnbGozOX/V8P8ail2cIZL
	VZAQa0HhSEE8tGW+Gq7rFUcuGp/EgBwKKRHe+r+E2PD8v3QzJvTwTprSRTiLfqm6i3GCTZroQ3p
	6s8R2GK+LM6Wf90BQ=
X-TM-AS-User-Approved-Sender: No
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--19.017700-8.000000
X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007
X-TM-SNTS-SMTP: 261D062BC881AE064030412BAF3C4AE581FC2F1906697EC91488ACB5DD6C9CAB2000:8
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1EUR01FT048:EE_|DU0PR10MB6108:EE_
X-MS-Office365-Filtering-Correlation-Id: f2630c55-55a4-4e17-920e-08daaa9bf1bc
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	04TMPTkG8DfTl/crYlea/0+mIoAQkz3AAvu6d2ZMBc8ZvRFqKpMv3Ve6B8x/W0zcv0Jw/RJilAGds0fR22cJok548yO4+VU3UM5wVVsDyJTHemVZAY4p2ju4BZmLrYaIvs+PO6wD4LjSZZ7MF+uNVPtH986pEinFSCuXwh34Q/w7FSqMNcuWLoBdfGzB9UWrJSxIbWfdddvRx7Irpuo+BkFRR4zLm8hQlW1Ai+x5HDKWG0+38aeAXZOgl7Dv3HWb7Bh37t0QF0OD+LSd6qCz+qG2ncgSvpJeFVWUC5s0bUYIXSrMlHTlY9PTb4f5ydhNL111z6q669I2Z8TRpzo98dxiJmDdp9TIpKxbF4RRlsADVOk04NH88rPRr7du9KYlh9+GPk8igGX05heEq/+67mioOaSAeocrEmdJiagfleqww8LCAUouXQGD0a5MT1ZtVN29DZUMzXTR5l/YQeubpxMIAqVwk3v+hFG69eLTJYGlFClD5STtrY/xlqtzJMYBMUU5okCjAOiGSNw87e3HyioI8msAIr42pooZbWQBchYb1uCpJ00xfMO1coY4TGIt6Egm5mqcOWP1ercbr4u3Mh92aTRvnkKV22UUr8jaxwWCGdfLMlvagvlVoPdfJ1yP+kEHoylDGI4hGAdvOmZttfRxY5cARrolX3FQHXQw2QfqSxHd7//6vT+QrFN9tyhZGBS5poQssczx3MXkWEm+tTldPtJVriTL0V5LdUN1Ozfc0O3ccm05aoC2nyk4zpRSzUpcm6sXNlaZfsNIldFnOGtlg/8xZaGgFd93kNBweufmTy7BLn7X5q8/ArKc1ged4yDuK0Q6SKm1nTerBMktIDgZbbOS9GWMEgfTaPxGBr2O4+61GzybcWpOGbJxYJg7YxpiTvqBAxIb39Pl+KAnDg==
X-Forefront-Antispam-Report:
	CIP:194.138.21.76;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(478600001)(36860700001)(82740400003)(316002)(8676002)(6666004)(31686004)(82960400001)(44832011)(70206006)(4326008)(53546011)(26005)(5660300002)(956004)(2906002)(81166007)(336012)(31696002)(40480700001)(70586007)(6706004)(2616005)(186003)(54906003)(41300700001)(16576012)(966005)(83380400001)(356005)(110136005)(47076005)(40460700003)(16526019)(86362001)(82310400005)(8936002)(36756003)(7416002)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 08:46:37.8197
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f2630c55-55a4-4e17-920e-08daaa9bf1bc
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.76];Helo=[hybrid.siemens.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR01FT048.eop-EUR01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6108

On 08.10.22 17:12, Borislav Petkov wrote:
> Adding Xen and Jailhouse people and MLs to Cc.
> 
> Folks, thread starts here:
> 
> https://lore.kernel.org/r/1650035401-22855-1-git-send-email-ross.philipson@oracle.com
> 
> On Fri, Apr 15, 2022 at 11:10:00AM -0400, Ross Philipson wrote:
>> There are a number of places where early_memremap is called
>> but the return pointer is not checked for NULL. The call
>> can result in a NULL being returned so the checks must
>> be added.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
>> ---
>>  arch/x86/kernel/devicetree.c | 10 ++++++++++
>>  arch/x86/kernel/e820.c       |  5 +++++
>>  arch/x86/kernel/jailhouse.c  |  6 ++++++
>>  arch/x86/kernel/mpparse.c    | 23 +++++++++++++++++++++++
>>  arch/x86/kernel/setup.c      |  5 +++++
>>  arch/x86/xen/enlighten_hvm.c |  2 ++
>>  arch/x86/xen/mmu_pv.c        |  8 ++++++++
>>  arch/x86/xen/setup.c         |  2 ++
>>  8 files changed, 61 insertions(+)
> 
> Ok, a couple of notes:
> 
> 1. the pr_*("<prefix>:" ... )
> 
> thing is done using pr_fmt() - grep the tree for examples.
> 
> 2. I think you should not panic() the machine but issue a the
> warning/error and let the machine die a painful death anyway. But Xen
> folks will know better what would be the optimal thing to do.
> 
> Thx.
> 

For the Jailhouse bits:

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

(IOW, panic'ing is fine for us here)

Thanks,
Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 08:46:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 08:46:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419155.663899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohoR0-0004cS-CO; Mon, 10 Oct 2022 08:46:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419155.663899; Mon, 10 Oct 2022 08:46:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohoR0-0004cL-9Q; Mon, 10 Oct 2022 08:46:50 +0000
Received: by outflank-mailman (input) for mailman id 419155;
 Mon, 10 Oct 2022 08:46:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zSpT=2L=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ohoQz-0004Le-MI
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 08:46:49 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2088.outbound.protection.outlook.com [40.107.21.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1381ce65-4878-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 10:46:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by GV1PR04MB9053.eurprd04.prod.outlook.com (2603:10a6:150:1c::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 10 Oct
 2022 08:46:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Mon, 10 Oct 2022
 08:46:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1381ce65-4878-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f1Z8UztMWdQ20c5Pwi6sfh0mlpfMSVW3J7nLeJAZnegK4keCdpnaUJWEqPwzeuYHLBnZzDtpCFg5yy5DHdXvg2oNZ+TpHRl0nKY4YqfjNqrUWhW+/bE6wELq2Kf2Rc5tCnXnzRL4pwVSvKMzyqWEZlbKq0A/bxGA0oYiGT3rrPYUyz6VBOryzlAuB7Sr7+seN8Vq53oGwH3ds1RLrUnpcIMFivI+qHEch/4U0+IdUM5gd4hElPwbr+EJPGD6BuqJXxx4XcxYGQgc3ZCCESLuhHKLJ4JWSDr5fkIj7C606zwICyBnmurYdOFXyN42dzYWv34lvj0OzrdQBRWPhk2EQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oGnypTq7vraWhIQ+AdGroi5WfAv95mzqI6SjBXcQulM=;
 b=fpzSY1NwAbLMbKB0j67TkBmOMAKBk5qDJC1reRvZX3aFP3vCqhAiluJGciGkY4iGffL4Er0QQdAUAy+cdJp1SobDDk5V07PDvefQNBBT8YfUp5N8tcEOZVb9TSxYKQxRFiIoQSBqGjyQmnDsZugJvZe6y0szZNsLeIu0/nMx3ZtK6yUbjM8CceUQRKO9mQiyKVmw3bmMTUX3zBYOwXR06eVEE/+4U1QihYmFERl8W7Mn+P667Cc+8NR5w+jb9I8XUfya8kquoubTGN80BgdQeuPFJUycUJs/NlLxzX0FplmEM97kf5z/O00NgwXxsFBdTfywSmzvycMej1mbK7BVbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oGnypTq7vraWhIQ+AdGroi5WfAv95mzqI6SjBXcQulM=;
 b=HS94GKRuZQfXPnRgB2xji03d/y568x2G9lct0uSRA6LgjRF4TwUOaK5ZpD8U/jpg2d4VMIwGzhffYKmyQIgMCqt8Jyvga4grz8pEWj6iCezeVa8YZTqz8L58xLdzWn2ek1AWsqAjc0fhI0+tzIaJCAbU/SbDjk8m0NVlzaVNlkfsGOTDh1IXtXMwu2Vd8A7r3QdnaMK99QMAlw53YwhHvXPuwRCv6tJui9FS/xO0DHqn2EbQDvvGRSih9NQeH+7iz0VJUPkOeoN0UmsC69qwTp/fjlq+p3+OgAblmUcHJw5RmqRcshUTyihtU85GdyGY5C/db5aKxx7kIijN4SMg3w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <568c1ddd-dd85-2625-468e-b62cca0eb17c@suse.com>
Date: Mon, 10 Oct 2022 10:46:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 9/9] gnttab: don't silently truncate GFNs in compat
 setup-table handling
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@citrix.com>, Ian Jackson
 <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
 <c3f4d5ce-6ac8-1d1c-eed0-704354f8a5f7@suse.com>
 <c8b08c8b-0e2d-040e-32b7-0ca63c2908e6@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c8b08c8b-0e2d-040e-32b7-0ca63c2908e6@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM5PR0601CA0046.eurprd06.prod.outlook.com
 (2603:10a6:203:68::32) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9053:EE_
X-MS-Office365-Filtering-Correlation-Id: c77d6073-010f-4022-477c-08daaa9bf65d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KH0+OTFnElRk4B++/ZVX70KJr2HQ3ZtBPFaIA7HR+Po8PvTgx3a+wVSrq7PzGNw3ZuT8niYKRdH9VXX8OyfGpoYYOVRBO3BtRt1IimqpMJ6X5RWysSyL0Vi9Q5WlQJw4x8UO05yOvV2DLgTdsOWkIrf96Z5TTjBlkFjWBtOXKpWOMNFyWBXPjOTrmzrux2UM5KEUp9CuI6I6gS56t/Y8AOqlRZlHGHfvUmtao3KdH3Mb+pJzVEu2Dbjpc0LD/YCirtxUaNl+AVESISWeW7Wpg2oh+Tlon6mg2CIlvinO938dSepucx+yz/sW57OfYVXUlAfoR/lW9kEw7K6OB9nNGltPWPHsJVBJU6YoT4maRyf3ajp4oZPhQfGBYNt9Nfk3LT0pOLBs6N6acczP/uC0F+Gz21c9fwf/8on/sxGwOqblJYlEGLkuYmUqEXr4l8a2txHlp4BIPkpcVgUuOkz/d0WSD5o/8eT+pbhF4QKLGLZ+UulUMyvCsC8WrqyyFe1ro0pPS4r21K64BomWxp6G2ga4RYXbBAk6ZgDtEZp90mcqDtp2fF9wSNvNjrrudgBu6BT2qCNe3LtimJJSIyCaWI3rdAQsklzhbw8uWE8KQ5POkEAPIKgYjSa16ILeuhz+gpZFrCYEEnsB+eOZ+DxEV7oplnDl/EuVWRYHP9toryxN8HYZxxGzgdB7g8f5y4fCrdLvOw0gLRGfJzdsK4iHycdPYg8j3QjlM2P0unV/5pbCZMZGrNiCdHIi8EsGXmrKHfA3mYaUgQkF9DNqtxRk2QxxxDhjlcD2uTzLMDgGZzQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(136003)(39860400002)(376002)(451199015)(31686004)(26005)(8936002)(5660300002)(41300700001)(2906002)(31696002)(36756003)(478600001)(54906003)(38100700002)(8676002)(6506007)(6512007)(53546011)(86362001)(66476007)(316002)(66556008)(2616005)(6486002)(186003)(6916009)(4326008)(66946007)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWo1eEZYQ24xOHZ6ZTh4d3dIQ2RyaWFSdmhLQ2FSRm5oNGxycTVIM2tIT2k0?=
 =?utf-8?B?akdFVXRBcE1sNDgrVXViUEZ6YnpsWjlCT1Z5bGEzbUVRNytLZlpRZ3VCV2lV?=
 =?utf-8?B?QzY2L0p0WDYzc1kwQkYrZFJDTDZ3eDBIWWs3TG1sNXcrL1Z2UllFK2x1dVFM?=
 =?utf-8?B?U3hQVlZCYXpudm0zbG5iUWNkem1wNG1qRU8zZmZpZDJDaXFRSFU0Qmh1Rkts?=
 =?utf-8?B?dXA0N0dXMVU5ZzNHQVM3enJoKzZUK09uWWlDY09xNDRyUWVabHJCVDNhMElQ?=
 =?utf-8?B?eWJ3eGd1NXNZWjZuNWlqZHg3TGdIdGZBU3AzSTRPblA3SjlpZG4yV0xRV0VT?=
 =?utf-8?B?Y1JzazhDWXcxd3JZQ3owcUdFWHlxUWcyNGdaQk1UeVBsWXRUdkdhT1pmRzBH?=
 =?utf-8?B?cXhBNGxveDF0OEZZQ29ieW1LZXdDMmxvYVFBd0R5WXdHMDNzMDk5ZUp1aEhs?=
 =?utf-8?B?VEFYN3FyRXkyTDZDemZMOEdRWTFWb1k0RDh4VTVLRmlyRktvd2VETFRmemQ0?=
 =?utf-8?B?aU5naE9QekllVkhKVWlEaTdTZ2hDdlk0TXh3eFVoNjFGRmoyQkE2K1BzdUsr?=
 =?utf-8?B?Yk9mY1VZYWZBeE1KY1kyaHA4UmlsUjJPTHJWQW1RZUlzT1RnSmNoZVZLTm5R?=
 =?utf-8?B?L3lqTDA1WmVtWm51MlZUQlRBR0MzS1JISzhqdVpBTklMZkJPMTNGNGp6WW1D?=
 =?utf-8?B?amk3YmpKNjE0ejl5OGU4MDQrNXFiT2VNZjJjM0ZMbERXdThpYmcxR01WTUc1?=
 =?utf-8?B?dStLMGxOT1dJU29ENzJXb0lNNFFibktodkJmby8xQlJsMTExd0RobWIxRzBa?=
 =?utf-8?B?WUhTaE9haU5oNHNpYkpRKzQ1eUo0REt3UEdnNEtLeXAyVEFMWStITUdTandt?=
 =?utf-8?B?RzVPVnRBRnp1VnhRb2t6ZUg1THlkWThMNVhTNHZkcVZLVGdFVEhoWUtOd1ph?=
 =?utf-8?B?aGRjUklnY0dlNUw2VS9XTVlmWExBMnNSZkFKbnEvbkFWRXJCNDhwTUFTbk5x?=
 =?utf-8?B?TkpFeVNwK05Jem1YVjJNZ01wa2FyMms2Z0o1cnZVajlpU2p0akJrZnV6RHQ3?=
 =?utf-8?B?ZndYUEZ1Rm4yNll0YWQvS3RVYWhtT3ZHVHNoVXBqanVwTXprNkxSOWsrOThq?=
 =?utf-8?B?dXNKbDFIUkhOS05mS3k2VEozaWY3YjJrRjZCZWFiVW9CNTVRMVV0VHh5SHFZ?=
 =?utf-8?B?emRONXM0MU5RcmphWlhMdVFNRnFNRGFmTVFEMnRxb1pwbjd4M0Ywc2h0U1Mv?=
 =?utf-8?B?NkJsamRJZ2pEa0RrWnBVWktvdXdhQU5KU0xhWHJvbXZiaXhMVElHaGdZWElp?=
 =?utf-8?B?aGJOa29Ic0s5RVRYRkZKUEt0SlRYWHlwSUpNWkNRSmZUYkEzaHpwSHFhQWda?=
 =?utf-8?B?YmczcFdPbUUveVRNTExmRkZueVVxR1FzTVppMVp4c1EyNHVibGlGMElSZkE3?=
 =?utf-8?B?Q1pEL1B3MGdvRlo0TEhFMU5nNldoZEFXZ1VRNVBaYURFN0hUdnFwRU1Za0FX?=
 =?utf-8?B?U1Znc0NsSDJCUzVRWmFaUHNPeUhncGdVbHhlUUlyYmVNdHBRbldMaElHRXU3?=
 =?utf-8?B?S3NUV2RTNzRVeVhSTU9JTlIvUmZuUnBaeE5oeG1MUVZSZUtkNVNrd3ZXNkox?=
 =?utf-8?B?TkpxazAxTFliblM0YWs4L2c3UUUzczFOZEl4bnZrd0JrOW9DTmRYUnpxV0FC?=
 =?utf-8?B?WVhWUVZxc2xQbEFNRnVheXFUaWQ3MnI5aFhybksrSVFTYVd0eTNlYmQ3Rk1Q?=
 =?utf-8?B?QXNoMzlnSzQvR0tMOTFEdTJCdnpmVU9NbUJHM0VaQmJidFlwckY0b1ZVUi91?=
 =?utf-8?B?cE1yNmVTbk9HREZZWm55SnVueTh2QzdUOCtDL1JrNHRHN0pqMmlkS096bVpU?=
 =?utf-8?B?YlVVTFJCL3ZhaS9MNCtWVC91Wk1hMEFpUDRLcWxJN1NpNnl4YVdFSGdMZEtH?=
 =?utf-8?B?MnczU0NPa3h4RkxJay9WNlhiU0ZWZHpZSC8zcTNjVE4xU09Vcjd0dXppTjFM?=
 =?utf-8?B?a0dEdWtZVXBla0EvNkJLbkZ3MjNCS3g1THA3OTNxMloyd28xY2F1bml1UlM1?=
 =?utf-8?B?WnNBQXVpMFBvTUliWFNLWlNHMlZaR1hDVStOL2pMRSs4SlVFZFVvQ2lacksv?=
 =?utf-8?Q?nyBdCctubbHsimqw26gMrhJ1o?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c77d6073-010f-4022-477c-08daaa9bf65d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 08:46:45.8182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CBFG2KFM+99ONOlvEdLnObXSbclh/O4YywCyAskZGjuEQDrHQB+Nap3LFaR2qMIpkJM0fPTtpOmzqIdfiDCeOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9053

On 07.10.2022 21:57, Andrew Cooper wrote:
> On 26/08/2021 11:15, Jan Beulich wrote:
>> --- a/xen/common/compat/grant_table.c
>> +++ b/xen/common/compat/grant_table.c
>> @@ -175,8 +175,15 @@ int compat_grant_table_op(unsigned int c
>>                                   i < (_s_)->nr_frames; ++i ) \
>>                      { \
>>                          compat_pfn_t frame = (_s_)->frame_list.p[i]; \
>> -                        if ( __copy_to_compat_offset((_d_)->frame_list, \
>> -                                                     i, &frame, 1) ) \
>> +                        if ( frame != (_s_)->frame_list.p[i] ) \
>> +                        { \
>> +                            if ( VALID_M2P((_s_)->frame_list.p[i]) ) \
>> +                                (_s_)->status = GNTST_address_too_big; \
>> +                            else \
>> +                                frame |= 0x80000000U;\
> 
> Space before the \.  (This is one reason why I hate this style.  The
> borderline illegibility makes it almost impossible to spot style problems.)

There is a (imo severe) downsides to backslashes on the far right as well:
It's easier to miss adding one on a newly added line, which may or may not
result in a build failure.

> With the adjustment from the previous patch, you'll need a break in here.

Can do. Question then is whether to go further right here and adjust
the loop header and the other setting of (_s_)->status at the same time.

> But for !valid case, shouldn't we saturate to ~0u ?  I recall from the
> migration work that various kernels disagree on what constitutes an
> invalid MFN.
> 
> Then again, I can't see what legitimate case we'd have for a truncation
> and an invalid M2P entry needing translating.

I've dropped the use of VALID_M2P(). It's a bogus check anyway (I don't
actually recall how I came to think of doing this sort of check), and
there's indeed no reason to report back an (overflow) error in this way.
Furthermore I've noticed that the updating of "frame" was actually dead
code - the updated variable wasn't really used for anything; we would
have left both ->status and the array slot untouched, misguiding the
caller.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 08:52:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 08:52:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419166.663909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohoWt-0006Lw-0d; Mon, 10 Oct 2022 08:52:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419166.663909; Mon, 10 Oct 2022 08:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohoWs-0006Lp-Tw; Mon, 10 Oct 2022 08:52:54 +0000
Received: by outflank-mailman (input) for mailman id 419166;
 Mon, 10 Oct 2022 08:52:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bLGv=2L=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ohoWr-0006Lj-L2
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 08:52:53 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ecbbc4b6-4878-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 10:52:52 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id q9so18889833ejd.0
 for <xen-devel@lists.xenproject.org>; Mon, 10 Oct 2022 01:52:52 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 p16-20020a17090653d000b00770812e2394sm4971174ejo.160.2022.10.10.01.52.50
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 10 Oct 2022 01:52:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ecbbc4b6-4878-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=3Z5l4CKBmKCa6BsMTvccB8bFRHLFhMh7B4VtRTqQNQg=;
        b=nz9S/R1N6ZE2GTv9m67skadQj19LK1GjkVLuZGLc8g6uwtb5kLd/R47O4bSVB192wV
         WLK3Yxx8270rpQSQcZEU2mI+hX94GVEvCxPQcPRNmJ8lUzhHkU/Grj//QtZKV71tiP8V
         Wy9O8kEFKd4SgHbd1Z56V39c/+IR1MVlomylUEdFqhNUY9tWb/rlzBBr6l1/Y//stIUb
         mEce1pSU4/QFV+7RLPKGnzC/AV7m54XjT0/jInxUBoudJDYcrpqNDlLVOx1EDyCc1de+
         YqFPIwGF+zV9Wp7T6Bp4Kb/iLdWGIqH3jTY2SKXtA5eMaXlVYEW11RoxYMDnRH6zXXMS
         LPIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=3Z5l4CKBmKCa6BsMTvccB8bFRHLFhMh7B4VtRTqQNQg=;
        b=J53fRs2GoFwtAoIcnrgmHGaQcEcs0q4gc0Zb3wPGGhAPimw7Xl5t6L7J0rx9QRh2Mu
         UxTc/IkZyvlqpksZloqJIknawBQqv+jm5Z4g+P/zRgPicSBmtonQjX1lwgY0rwAcS5c0
         BMT4k/l0jQT8t3UIpniryEpJFM7/1tAzamzMxD41XFzUtRrttqIl/aNSlZEHUZsMMtIZ
         QSVgiqy25LvpELNs4zAkdr4MEo3v8h+Y4V3XIM7eWnGeHNhmO/Hf41fmFQSD12jgo1DC
         5kahnOUfEy47W0UolbcNDHE+ET8vQwr35PBEVIHBzN3Bmx211MNiGftGW4H7T0ecJ6gY
         GLdw==
X-Gm-Message-State: ACrzQf15EocCtuEFXaj506WU9T/Lba3nmwxrlF+Xv83JsdKvCHIznzy2
	VuwMIy0msal8V20Z212wFSG1OQPFyqo14w==
X-Google-Smtp-Source: AMsMyM7YE7esBBMYse2AC0OOuiWp2UIwtMaS79Eyc0SHEcpxWcPdaJoxlln9Ivfg5EsTA4N3TsTqiQ==
X-Received: by 2002:a17:907:70a:b0:750:bf91:caa3 with SMTP id xb10-20020a170907070a00b00750bf91caa3mr13793106ejb.711.1665391971890;
        Mon, 10 Oct 2022 01:52:51 -0700 (PDT)
Message-ID: <4fc23936-4bfd-635c-b3a2-554e280ce884@gmail.com>
Date: Mon, 10 Oct 2022 11:52:50 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [ImageBuilder v2] Add support for 64-bit addresses/sizes
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org
References: <20221010072947.8300-1-michal.orzel@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221010072947.8300-1-michal.orzel@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/10/22 10:29, Michal Orzel wrote:

Hi Michal

> At the moment, ImageBuilder assumes that all addresses/sizes are
> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
> value for the first cell. Because of that, we cannot specify
> MEMORY_START and MEMORY_END to be above 32-bits (e.g. to place the images
> in the upper memory bank).
> 
> Add support to properly handle 64-bit addresses/sizes:
>   - add function split_into_halves to split the value passed as a first
>     argument into upper and lower halves. These are then set as values for
>     variables passed respetively as the second and third argument,

s/respetively/respectively/

>   - add function split_addr_size to split address and size and form a
>     string to be passed to dt_set as data argument for reg property.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> ---
> Changes in v2:
> - redesign a patch based on master-next instead of NXP dynamic assignment patch
> ---
>   scripts/uboot-script-gen | 33 ++++++++++++++++++++++++++++-----
>   1 file changed, 28 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> index b24dca2b7f7e..09d237d192c1 100755
> --- a/scripts/uboot-script-gen
> +++ b/scripts/uboot-script-gen
> @@ -22,6 +22,29 @@ function dt_mknode()
>       fi
>   }
>   
> +# Usage:
> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
> +function split_into_halves()
> +{
> +    local value=$1
> +    local upper=$2
> +    local lower=$3
> +
> +    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
> +    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
> +}
> +
> +function split_addr_size()
> +{
> +    local addr=$1
> +    local size=$2
> +
> +    split_into_halves $addr addr_upper addr_lower
> +    split_into_halves $size size_upper size_lower
> +

Just a minor observation, the variables addr_upper, addr_lower, 
size_upper and size_lower can be declared local.

> +    echo "$addr_upper $addr_lower $size_upper $size_lower"
> +}
> +
>   # data_type is either
>   #   int
>   #   hex
> @@ -93,7 +116,7 @@ function add_device_tree_kernel()
>   
>       dt_mknode "$path" "module$addr"
>       dt_set "$path/module$addr" "compatible" "str_a" "multiboot,kernel multiboot,module"
> -    dt_set "$path/module$addr" "reg" "hex"  "0x0 $addr 0x0 $(printf "0x%x" $size)"
> +    dt_set "$path/module$addr" "reg" "hex"  "$(split_addr_size $addr $size)"
>       dt_set "$path/module$addr" "bootargs" "str" "$bootargs"
>   }
>   
> @@ -106,7 +129,7 @@ function add_device_tree_ramdisk()
>   
>       dt_mknode "$path"  "module$addr"
>       dt_set "$path/module$addr" "compatible" "str_a" "multiboot,ramdisk multiboot,module"
> -    dt_set "$path/module$addr" "reg" "hex"  "0x0 $addr 0x0 $(printf "0x%x" $size)"
> +    dt_set "$path/module$addr" "reg" "hex"  "$(split_addr_size $addr $size)"
>   }
>   
>   
> @@ -118,7 +141,7 @@ function add_device_tree_passthrough()
>   
>       dt_mknode "$path"  "module$addr"
>       dt_set "$path/module$addr" "compatible" "str_a" "multiboot,device-tree multiboot,module"
> -    dt_set "$path/module$addr" "reg" "hex"  "0x0 $addr 0x0 $(printf "0x%x" $size)"
> +    dt_set "$path/module$addr" "reg" "hex"  "$(split_addr_size $addr $size)"
>   }
>   
>   function add_device_tree_mem()
> @@ -260,7 +283,7 @@ function xen_device_tree_editing()
>       then
>           dt_mknode "/chosen" "dom0"
>           dt_set "/chosen/dom0" "compatible" "str_a" "xen,linux-zimage xen,multiboot-module multiboot,module"
> -        dt_set "/chosen/dom0" "reg" "hex" "0x0 $dom0_kernel_addr 0x0 $(printf "0x%x" $dom0_kernel_size)"
> +        dt_set "/chosen/dom0" "reg" "hex" "$(split_addr_size $dom0_kernel_addr $dom0_kernel_size)"
>           dt_set "/chosen" "xen,dom0-bootargs" "str" "$DOM0_CMD"
>       fi
>   
> @@ -268,7 +291,7 @@ function xen_device_tree_editing()
>       then
>           dt_mknode "/chosen" "dom0-ramdisk"
>           dt_set "/chosen/dom0-ramdisk" "compatible" "str_a" "xen,linux-initrd xen,multiboot-module multiboot,module"
> -        dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 $ramdisk_addr 0x0 $(printf "0x%x" $ramdisk_size)"
> +        dt_set "/chosen/dom0-ramdisk" "reg" "hex" "$(split_addr_size $ramdisk_addr $ramdisk_size)"
>       fi
>   
>       i=0

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 09:14:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 09:14:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419173.663921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohorQ-0000hm-Po; Mon, 10 Oct 2022 09:14:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419173.663921; Mon, 10 Oct 2022 09:14:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohorQ-0000hf-Lk; Mon, 10 Oct 2022 09:14:08 +0000
Received: by outflank-mailman (input) for mailman id 419173;
 Mon, 10 Oct 2022 09:14:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohorP-0000hV-LA; Mon, 10 Oct 2022 09:14:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohorP-0001aE-JG; Mon, 10 Oct 2022 09:14:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohorP-0007GZ-5k; Mon, 10 Oct 2022 09:14:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohorP-0006fJ-5J; Mon, 10 Oct 2022 09:14:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yyr4Gtg7ZKRp7iv5zTFXj8RL4w+krodwdgmXgwVBsuU=; b=yN4LvFOSm8EmuoLsD1PNiXRoKk
	UQDDc7l+rfIU36s7kOBM9cJ/WhQvu85taOMOmL3f0hhdB2PWIzHpX4ci5BRRhtcLdoNmoOG9jQgUz
	U2s1AoWSD8dq8aSDkxg3YMi2rYagh50u+5tZFZ0niHI3Vik3JdsIyYok8ispspbxhUCQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173484-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173484: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=8db4e9f9a0c2ec992e28259ceb7a8eb316716b05
X-Osstest-Versions-That:
    ovmf=3c9e2f239a38590b4e3a8c1ec2304227f2af0103
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 09:14:07 +0000

flight 173484 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173484/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05
baseline version:
 ovmf                 3c9e2f239a38590b4e3a8c1ec2304227f2af0103

Last test of basis   173481  2022-10-10 01:11:51 Z    0 days
Testing same since   173484  2022-10-10 06:43:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michael D Kinney <michael.d.kinney@intel.com>
  Yi Li <yi1.li@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   3c9e2f239a..8db4e9f9a0  8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 09:30:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 09:30:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419181.663932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohp6w-0003HY-3i; Mon, 10 Oct 2022 09:30:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419181.663932; Mon, 10 Oct 2022 09:30:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohp6w-0003HR-0j; Mon, 10 Oct 2022 09:30:10 +0000
Received: by outflank-mailman (input) for mailman id 419181;
 Mon, 10 Oct 2022 09:30:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zSpT=2L=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ohp6u-0003HL-Cv
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 09:30:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1fe35731-487e-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 11:30:06 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8175.eurprd04.prod.outlook.com (2603:10a6:102:1bc::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 09:30:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Mon, 10 Oct 2022
 09:30:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fe35731-487e-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GjTFZI78pZtMPawE7gwknRwkfxT5tH2fkFlBmnP6nhM7syoZUtmNsvyWAbATLYHMDhzupDG6qniWldo6lYBJjf5SSwaM641I17flOP82TegHL5LGY7iUrVQCe5k0S1vm45urlYhG+IkF7LZmkrP1RMmToxeyMUqakcSRclUGymQ5pxYpES0VYxWsDs9IvQGgZH3Lev77z/v+CjiQWaW4+Ft16nEY+D5MXADUEkXAoEx1l5T/mQ61V4zkAFjV9qgTbjWB32dggGnJ20yxsW+j5nyAF2b+pZXkuKDxcl08H9Zl4AqMOX9DXrzu8jfVF5U0oeVB9N5/CIGUgZ3+xF6emQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sC7jNsqGnBwktPxUK03Is/B2zAE9DDU9TpEMgsyH2UQ=;
 b=gB4W6B0eNVjXG2ybEjQd+V6v/97koLTBaH/zn1tlhi1swZuX2QDrCWKh++ccXL2JWByl2lY/aMm5A/ilzoq/9UY5M8lvecPDOX4LUrmP8JfhYanoCD7CfmhIeZaaNc5bK5uTCRTOkoSFoIiYFzvwTBNefiLK7PxsHYHuzgw3oYHTMDRx37ftAx3nI2So3CKsovby8+JlAzD+aX7eQIFXbIqcbXghhBRRND78KlBGZfdMuiJmMqf2l8leb5sTXxnxKrVzHVNChgcfkYxmbXMwJmMWOOkfZ02wtmGW2n9PhNAapzth/bJex7OjzDBoVSQd0LZRFW6LI6X7f0ejA7TgCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sC7jNsqGnBwktPxUK03Is/B2zAE9DDU9TpEMgsyH2UQ=;
 b=VwceYxjVpaMynqPuelpS1dX+4ZWZ1Af8sd+4PKps3Rm06bCa23IHibb9ZKkzPAN6dO8DhFnMYf0DW4fnlrAL/OhLCyv1SxDaea5hrl+YRlECmuW1kUdlVWMTuxgUvrE0DGxR6md5rdgL1WPZcQV4B9YTFTxgRwXs2XW3+nTDCVlhPpFuJRO3lW7SI2GcCX3+yNmnmqmqggvIIjHbxVm5wAf4S9EiIU0MkH09yWXTsBdMXhEC8f+4MLH0QUPvDvjkf/dlHdyG1HpLgr05WR5XoAkFyrhRI0u+vgcvFfmFi1wKXk0u7kH7NTklPCpJtqNvTjRvDmUBaWTkcoToXiJA8w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7b4b5e11-fadc-b6e3-b42b-50dddea9f09f@suse.com>
Date: Mon, 10 Oct 2022 11:30:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 8/9] gnttab: bail from GFN-storing loops early in case of
 error
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <eb7bbd51-1da3-9a7f-27c7-49dea1a41488@suse.com>
 <61775fdb-bf56-b6db-563e-81820e4248fd@suse.com>
 <4808b724-31d3-bab4-e6b8-5e4bc5e0a104@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4808b724-31d3-bab4-e6b8-5e4bc5e0a104@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8175:EE_
X-MS-Office365-Filtering-Correlation-Id: ee49af1f-5f6e-4e16-9476-08daaaa20286
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	02zfTZtVqt7SdNjkHw+/KD/CBmPzQpT7h1gy3EzgRz1XSJ9U20x67upLmOSiL/5nV9fcnC23usrLIrDU1uBcfoGe1RlyIscVs+VOYaV2rpnlhRslRJiulTa/VviYA1Aw98VWfTFGITlNAzHtTC2OBADjeZ2U60Z3183YO96wPV8D9xMmkVzlarlxROr2gdMMsjP+NOmnIDQm7J8gtujcA/at2GIvwEP3FBkvHbaJv+vswSMdBQzlx3tt7z2pfRBNDm7eBzQe8wzawAHjFsY1vlo/NiNWGTfesTnaerxqYao47TXi0HTa+R14fq1W3AmHMqjqvsVkcIpMznbOCQ3OQoDqSu80vEWrEev4e/dcd9zxz28R/64LxDns3kVJenJGDaR7j05LRp7UqoKlprYADg5b5KqvlgTU81UwK1jamwG8m24atKvOKMFzxmCghEp7s7Zvg/hWRE3IVqk9cjQmARCWItsKDw3O3uBi76174bD8kmXmy73SQpNT1tUylHur9eh0NCY9fxnQXxIJUziMVwcHppHC6ljNjEuMeAS0JOZJhTnclCBqKVSyb8qGHETC0YF//zpXXnl4XkiaGyFonSpHu4iNn2C3yYosupyLhtFWrTySV8YQK1IUNb/moWAJHEMydAn/VbcZlidNZssFaxuJKehVCJzVIWCKJkYY7H/gOM8OTtt/PzIPazsqK+jUtlK+/Z8VuX/4vE9nyJ5rRCIhZTHOqzXY4v0ylhjBzUcNQWNxxQOdQHlaYPEiZ1ZMB5FRsiR1wU2uj/Rdxpo2i0q61lWIqalGItZuLYubPJ4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199015)(83380400001)(36756003)(316002)(6486002)(2616005)(31696002)(86362001)(2906002)(53546011)(26005)(6512007)(6506007)(66946007)(4326008)(6916009)(66476007)(54906003)(66556008)(8676002)(38100700002)(8936002)(41300700001)(186003)(5660300002)(478600001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZzJnZlAvSGM0OWxqNzR4aVJVMVlsM2tKYkowMGFQN3pTSlJNMnRtTUF1ckU1?=
 =?utf-8?B?QmplMEVhQUQxU1JjajhmRElGWGEyZXY0L2dpWlZMQnk3aFVHTHZRVFhqeU9J?=
 =?utf-8?B?Ymt5VTloanlLcFdXVTVwZlFYSWFuWW9TT2FGdFlUdDFGUkdYdjNnQlkwc2pI?=
 =?utf-8?B?RUJlL3Q2Ri81Q0hUSitnTUdaS3VZNEU3ekFON3d6aGN0bzBkMW80L0E0bzFm?=
 =?utf-8?B?VHhnUy9JQ2QwdjFUT0ZCYWtQZlJqbGZTMlVDa2FvSlFTbkdjQVFZK1I1NXJn?=
 =?utf-8?B?andaZVdsTThwcDRzK09tb3JrQnJuZG9ya2pEUnlnUHdKMzl0Z3U0VE5HUkEw?=
 =?utf-8?B?QXNTM1I5TDM3bXUydnVwd1BkRFg0ajlwZW1BR1hjTGdkUGcvM3ZCbUZPWkZp?=
 =?utf-8?B?eHFOaUpRdWRFNzNBRy9XK0tNSDBLSnBIOWk4Q25aWEpiK0VKQ1hzSG1iSitE?=
 =?utf-8?B?eDJlb0tDUWNpV3BKQXRweFdCaUt0K09oQ1RMZDZIM1dLZWkwUElUbHJadnlj?=
 =?utf-8?B?MDRleENyUFh0WXVpQ2k2ZGR3ckRFamVvSjEwMmsveDh6UDZKNzIrS295UWJH?=
 =?utf-8?B?S1llNEZzWTFFdGF0c1BINmxnVE5QdmliUUVBV0hkZnVlVll2clVNU1FpTzJB?=
 =?utf-8?B?czczRC9mcmRIc1pmK0ZORVhUQU5wWHFGZkJuWmxYOUJLTng4YURSWlVPU3JW?=
 =?utf-8?B?MXEyNEZqUFUvMjhwbWs1QUc1cXZPT0lrZzhUN2RQMndvMmw5TU81cC90SUFo?=
 =?utf-8?B?TVU1bnpXWHFsUjdoZ0haZEY0MFhlU3B6Zm9PdFp2L2NZTDhBTE1jSXlKMnpx?=
 =?utf-8?B?T3A2V0djR2JpdTRJcE9pZjNva2t0bEpTTVBHZnkzbG9DcDk4SUdub0VxTGJJ?=
 =?utf-8?B?TXkrZHdjbG5KeHlleGFyOWlPckVNbG1aNGt4bGk0b2hFLzJPOXo1QW9Pc0Fa?=
 =?utf-8?B?ajJpSmJ3SlBkWENWUTBjNDNJUURWZlhQY0lsWkJpd2p0eUtWUGxCZTZWZUpK?=
 =?utf-8?B?cW44eVFBU2lmWVZPcmxIbXRyMTd0M3RYVVpyZGZxSWJ6WVROaTFTZncrcFpr?=
 =?utf-8?B?QzRpZ0hPV3ZhbHRicm5id0lrWkpEbDJndFQ1ZCsyVWhRV3p5d29qZmFlSDhB?=
 =?utf-8?B?TTZndE1od3dOSld3eUxVR29ROE9wN1RhQ2hKeEwyT0k0cVJVNnhnYk9qME0y?=
 =?utf-8?B?a3hnbU4rVk91Vnhody8zdkhiRWRiR0xnTXk0dTY3YTdON0drWTk5WmIwNUZR?=
 =?utf-8?B?Z2VvcUtBbXovd2srMlZuL1VpSmN2NENwM2xDdTB2Qm94bzIyelU5UndxMVhr?=
 =?utf-8?B?d3FnM0o2YWFsWG92bDdLY3FMeVlKbnpOZFhGY05BRWlST0ZNTGFpNUZiSUxE?=
 =?utf-8?B?TnNOQW1EK3lVQmpzQzdIbEFjaWRGbnQrbzF6SjVwMzh4T1llQnJ6dTNNajVa?=
 =?utf-8?B?TUtydlUrcjJIRHBuV0ZIYi9RbjhJWG1pNm5OUm9TcHNDTGFIN1N6QTQrVzRy?=
 =?utf-8?B?WUc5M2dGN0hUWnE0NS9KMEEvV0NCSHFYSk5BdFpsYnFSYUtTSE45ZE9RbVZk?=
 =?utf-8?B?Z2lrUWRBQkhNYWd6bFBqQU1nRW5NRTlsMTBkeTFPUEdjTW1jY1pIaEZ5NmE3?=
 =?utf-8?B?SzNtUEZQTjN0RnMySUFYdkdFcmVaSjFhR3hvWFlrVlZaZE1zU2hlZVdrNGR4?=
 =?utf-8?B?VlNZRDN5d3NKK0lHWHFpNWtIYXRYcFI4dmVveUpMeFFPMnI3Qllwcmh4Q21G?=
 =?utf-8?B?Z2U0STc3bVJaK21NdSsrdlovWUptblY2RG9GT2lQVU83ME5Uc2pab0VocWJ4?=
 =?utf-8?B?ZFpoWWlSY0Q2eWlaakJaYnQ1Zk5idWxjVXNIM2xzMXNGTHB4SDZveEQrc3pY?=
 =?utf-8?B?QVBvZHl6NXJkM2t3NTFuZ0NSMWVGWVJzeVBvdjZyTXorWWJqWFBqNDJ5SzRp?=
 =?utf-8?B?cDFQY3NqZVhjWDlYZi8vekd6V25KNVJsN2pJMzRTWGNhS3hjK2svQURDc3lQ?=
 =?utf-8?B?eEhBVG96QzJlemJxck4xRmdWT1RqNnovckRpY2t5MWpRbURXUlIzcHM1RmJ1?=
 =?utf-8?B?M0I5QW1ZemxpMFJYOWZJMXNxM3IxSnRiRGdjdGNSU3oxdjRlbnNsRXdsRzYr?=
 =?utf-8?Q?GtEGX3l+Vsw2FgbILhEqwQ9oE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee49af1f-5f6e-4e16-9476-08daaaa20286
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 09:30:03.1707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZF7XavpN4km8RS1zyd7bHWZ8vlzvNVC/ztbXZluadxjFKgk7lvbGB8yl3hybPJNjBrKO+9OGIsaSVUjYMtXEhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8175

On 07.10.2022 21:36, Andrew Cooper wrote:
> On 26/08/2021 11:14, Jan Beulich wrote:
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -3289,17 +3292,15 @@ gnttab_get_status_frames(XEN_GUEST_HANDL
>>                   "status frames, but has only %u\n",
>>                   d->domain_id, op.nr_frames, nr_status_frames(gt));
>>          op.status = GNTST_general_error;
>> -        goto unlock;
>>      }
>>  
>> -    for ( i = 0; i < op.nr_frames; i++ )
>> +    for ( i = 0; op.status == GNTST_okay && i < op.nr_frames; i++ )
>>      {
>>          gmfn = gfn_x(gnttab_status_gfn(d, gt, i));
>>          if ( __copy_to_guest_offset(op.frame_list, i, &gmfn, 1) )
>>              op.status = GNTST_bad_virt_addr;
>>      }
>>  
>> - unlock:
>>      grant_read_unlock(gt);
>>   out2:
>>      rcu_unlock_domain(d);
>>
> 
> 
> If instead, this were written
> 
>     for ( i = 0; i < op.nr_frames; i++ )
>     {
>         gmfn = gfn_x(gnttab_status_gfn(d, gt, i));
>         if ( __copy_to_guest_offset(op.frame_list, i, &gmfn, 1) )
>         {
>             op.status = GNTST_bad_virt_addr;
>             goto unlock;
>         }
>     }
> 
> then the delta vs your version is -36 bytes, and faster to run because
> the loop doesn't need a memory read and compare on every iteration when
> you can exit based purely on existing control flow.
> 
> Furthermore, the version with a goto is clearer to follow, because the
> exit condition is much more obvious.

I know you and others deem "goto" okay to use; where possible (and where
the resulting code remains readable/maintainable) I'm aiming at avoiding
them. Nevertheless I'll follow the request here.

>  The compat change can do the same
> with breaks rather than gotos, for a slightly more modest -11 saving.

There of course the original if() around the the loop then also needs
retaining; on the positive side this means a smaller diff.

> A form with the op.status changes adjustments *not* added to the loop
> condition, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

> In reference to the hypercall ABI adjustments, it occurs to me that
> loops like this (which we have loads of, even in hypercall hotpaths) are
> horrifying for performance.  For HVM, we're redoing the nested pagewalk
> for every uint64_t element of an array. 
> 
> A "copy array to guest" primitive would more efficient still than a
> plain virt->phys translation, because we'd be able to drop the p2m walks
> too.

Generally we can copy arrays (the last parameter of the copying primitives
is a count, after all) but ...

> Obviously, we don't want every instance like this to be doing its own
> manual bounce buffering, so perhaps we should invest in some buffered
> copy helpers as part of trying to improve hypercall performance.

... avoiding bounce buffering is possible only where the data to copy out
is available in ready-to-copy form. Here in the native cases we need to
retrieve the GFN (from e.g. gnttab_status_gfn()), and in the compat case
we need to translate from 64 to 32 bits. Neither really lends itself to
the use of a generic helper, I think.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 09:48:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 09:48:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419188.663943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohpOm-00059Z-L1; Mon, 10 Oct 2022 09:48:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419188.663943; Mon, 10 Oct 2022 09:48:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohpOm-00059S-GX; Mon, 10 Oct 2022 09:48:36 +0000
Received: by outflank-mailman (input) for mailman id 419188;
 Mon, 10 Oct 2022 09:48:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zpu8=2L=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ohpOk-00059J-AE
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 09:48:34 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2058.outbound.protection.outlook.com [40.107.223.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b26cfafd-4880-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 11:48:31 +0200 (CEST)
Received: from MW4PR03CA0198.namprd03.prod.outlook.com (2603:10b6:303:b8::23)
 by CY5PR12MB6130.namprd12.prod.outlook.com (2603:10b6:930:26::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Mon, 10 Oct
 2022 09:48:29 +0000
Received: from CO1NAM11FT043.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:b8:cafe::b0) by MW4PR03CA0198.outlook.office365.com
 (2603:10b6:303:b8::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19 via Frontend
 Transport; Mon, 10 Oct 2022 09:48:28 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT043.mail.protection.outlook.com (10.13.174.193) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 09:48:28 +0000
Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct
 2022 04:48:28 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com
 (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct
 2022 04:48:27 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Mon, 10 Oct 2022 04:48:27 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b26cfafd-4880-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gfg85jAaP0MgBJVLevGudJg+rEOFHmNzfY1t0C6E1DLHskBPNYJPiGd3wel8JyfmOferTHVgre3tJo/7Jrrz8WILromnkJUSQoFvAuwtNTDIwYEnn1uRkEJSIkgrG/oW5yfMNz9V90HhAERo3X5WT0AmiScCpCdG8gwSsCIVE+cIBdwkR7ayf5yF4ymYwiT1A4W4NjJsB15zIWjyJG6KcqQHOmh+x4YvBWTxvEYuIXPPvR/LA2YXjyXdZgo3ZZCV9xvSo1GQon9O8p0EwsjWsOZhDuVb4YGTsdOBZT4bvXrKZDFJVQDUgp03SvR1gy6R0kTmUcO61xziJs/VCkb+gA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n+oiqXiIEQsh91k5QdM3+lKlZyOl+iWPncFyfcj5C+Q=;
 b=K8Jc3/flkLvfrVxSyo3yzz+Kg9Z2iUuCtjL8cIzBEHsl28RKajxy2c+P5s6umKfQ2gn4p7EkBJG3Wkj1bVhjlxE7STtdrE2ZvYh3G8UvdfPkCVuc06fIEb6cN824Xl68aj+IRgwyjC+Jy/Q6Qt/yHL33uXrKTlchQddulZoQ34J+UOVWAX9LKIzD6WxB/GIFig+4XqGLjTCZmY3rBdZdXcJZF04UXj8T+42LTj9ltnU8lb+np9FmqfYrKviyp4wqZt5ZBzjtpfFTrbNUYveqxjW5eQmqivvYnnXGi+zVVVhTIrgvNaU6VHWkg9ViDEJIboLAnhFJM6a/y9/ScDiF6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n+oiqXiIEQsh91k5QdM3+lKlZyOl+iWPncFyfcj5C+Q=;
 b=S9EJuyPWuDpv4JAOqtNdqlgqEOtUb5G1SOKhKBYUuzfEPqBuuydsUUUHKXjPDjUNhM9KE1375yJ7BWGOJlY7n3Rc67NQIxw7GvdO7D4mj5Fv1CloVGbbafZpN8hGq2Qr4JJMRLUR6jw2FbyjTp4Kh9lKDepUoZbpGbqnKunhvUY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <f052cf3f-529c-2156-f058-2a320a4f1b02@amd.com>
Date: Mon, 10 Oct 2022 11:48:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [ImageBuilder v2] Add support for 64-bit addresses/sizes
To: Xenia Ragiadakou <burzalodowa@gmail.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>
References: <20221010072947.8300-1-michal.orzel@amd.com>
 <4fc23936-4bfd-635c-b3a2-554e280ce884@gmail.com>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <4fc23936-4bfd-635c-b3a2-554e280ce884@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT043:EE_|CY5PR12MB6130:EE_
X-MS-Office365-Filtering-Correlation-Id: 4108bc3d-a6f7-49e5-7e2f-08daaaa495a0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9oog1z1PCD03w+89bL2ao2EygLbtFZo2uzdCXdjHqXNiK/by29aBfiVMPMr5niKNXSrjZVFJI9ghz2OoDR/qV15snWkW8gPlp1fvIMCuTgD8WavQ3FCiRvUWB3Fv6rpnVn0x+RQlKRDGZ8SHjYIPi4cJjuA7+wVg0fRi/PoTiixsSMnkjB2coG6J+okY4qjod4NLjHaBiibNlMBW0LgAkw5bPuLk0u2MV+ED98I74yj6y4+jcCmYDnu95NFPpQoo3A04doawLPoKwolVvyXthEZYqSVUsThu0TW1ILloci3Ppn04BHq087qu8xyAMiBzkrTqXNq5raUuvZifUYVa1g7Loyitet77jnUfqOvpqoTXfW3IEx9hVYQarLOR0sUFe141KZlOaqoJI1JldHRa3syXQPme2aAe0HmoDp4ijnNtny4nvqmUBriCmyG9jhAmqtay8dFpdwM3RwKZamFd9gUfoqSjh746AT8aH8V5thIFbVP0Se04gV0AEg8WQ4h+IB0X6RzmjWEIvxMpxGI7q1ChDykzleSG8rLXGLKROCBjrOGPSD9lzFOKVKbXfzxswdB84C7V1aNMCCHMlW8LgGFSVZ5/pVgI5jDij+0c29q9y2QwVQew+B6EJOAaCJyCSNaVw39XK8pO8clQvnjebdxaMWFHEvK9WRNnSyBqOVkrbJ5VXeeH44mhaYIeWBKUZuWAPgnG591RVGi1ArH/K87COe++JTsfC6oNc2XBhWdKNH2l/kzZX0UFCUssbPe6NrihymSUNQkMNd1e6VBpTnu3egvakzaOuICDjTUkIGDRPx+I/TiUGoE0voibNsPlkkIoUBJoQmbhQktTmW0atA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(110136005)(36756003)(53546011)(44832011)(8936002)(82740400003)(83380400001)(186003)(2616005)(4326008)(40460700003)(81166007)(8676002)(478600001)(356005)(70586007)(6666004)(41300700001)(2906002)(36860700001)(70206006)(82310400005)(16576012)(40480700001)(86362001)(316002)(5660300002)(336012)(426003)(31696002)(26005)(31686004)(47076005)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 09:48:28.6309
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4108bc3d-a6f7-49e5-7e2f-08daaaa495a0
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT043.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6130

Hi Xenia,

On 10/10/2022 10:52, Xenia Ragiadakou wrote:
> 
> 
> On 10/10/22 10:29, Michal Orzel wrote:
> 
> Hi Michal
> 
>> At the moment, ImageBuilder assumes that all addresses/sizes are
>> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
>> value for the first cell. Because of that, we cannot specify
>> MEMORY_START and MEMORY_END to be above 32-bits (e.g. to place the images
>> in the upper memory bank).
>>
>> Add support to properly handle 64-bit addresses/sizes:
>>   - add function split_into_halves to split the value passed as a first
>>     argument into upper and lower halves. These are then set as values for
>>     variables passed respetively as the second and third argument,
> 
> s/respetively/respectively/
Ok.

> 
>>   - add function split_addr_size to split address and size and form a
>>     string to be passed to dt_set as data argument for reg property.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>> ---
>> Changes in v2:
>> - redesign a patch based on master-next instead of NXP dynamic assignment patch
>> ---
>>   scripts/uboot-script-gen | 33 ++++++++++++++++++++++++++++-----
>>   1 file changed, 28 insertions(+), 5 deletions(-)
>>
>> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
>> index b24dca2b7f7e..09d237d192c1 100755
>> --- a/scripts/uboot-script-gen
>> +++ b/scripts/uboot-script-gen
>> @@ -22,6 +22,29 @@ function dt_mknode()
>>       fi
>>   }
>>
>> +# Usage:
>> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
>> +function split_into_halves()
>> +{
>> +    local value=$1
>> +    local upper=$2
>> +    local lower=$3
>> +
>> +    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
>> +    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
>> +}
>> +
>> +function split_addr_size()
>> +{
>> +    local addr=$1
>> +    local size=$2
>> +
>> +    split_into_halves $addr addr_upper addr_lower
>> +    split_into_halves $size size_upper size_lower
>> +
> 
> Just a minor observation, the variables addr_upper, addr_lower,
> size_upper and size_lower can be declared local.
> 
This function is to be called to perform substitution and as such
is always executed within a subshell so no need for local.

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 10:25:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 10:25:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419197.663954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohpyR-0001ZQ-Cl; Mon, 10 Oct 2022 10:25:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419197.663954; Mon, 10 Oct 2022 10:25:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohpyR-0001ZJ-99; Mon, 10 Oct 2022 10:25:27 +0000
Received: by outflank-mailman (input) for mailman id 419197;
 Mon, 10 Oct 2022 10:25:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zSpT=2L=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ohpyP-0001ZD-9t
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 10:25:25 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70040.outbound.protection.outlook.com [40.107.7.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d9d84227-4885-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 12:25:24 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6806.eurprd04.prod.outlook.com (2603:10a6:20b:103::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 10:25:22 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Mon, 10 Oct 2022
 10:25:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9d84227-4885-11ed-9377-c1cf23e5d27e
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E0s28RPbKYG+g6zLXgAVnCktb1B2BckzMk1+bJbVKy1sL0Ypvrbin+Ud4OYEJsrFtdkkJJ1UG1bhrjkWo7aunV+fiWOeDJmWoUAmSaB107UV165ql97x+Dhllq8fUqFQGAR94s/rdrDO4+1M2j3sk3DC0dyb/sZ3Vj4XNpcpXC0ySpN3gBL6cshBd1qgOrx2HKCh7c51F1d4cLEEmqhoaBa8/XXkzBAputT2L0/UJepYhfyaEgIEtpmMm29KQfmhnC0DqpkwO+L0T4RdmeP0/KOEwVf7ai+GqA4cRnZZhNz70gcS9GlBRNWEeFYjEuyPXMTlj5CuwkCwEJAPAqo9bQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WoHimJzIzLxQ1QhsWTQCOEJZBtY6WWGzTNfOK95Ww9A=;
 b=Zyzb0pZYKVgEUtFRqEwC68n/Tn1e6yZ/lhYEm7TQzP6ey7/jJrd/D/k7j+OULxPUiZMwMGP3l1T1QRC3IYz+7nZVi2v9LUS/EgeY93sLjE2AF10s2NVB0p0dNVGoKUquDgHsAbH6pjpgnIiFgkbyPcFWTjmcQm5AAYu9EnP5nOyjNGu+wYyRbpCKO0Z/JWABu3Yu1YAuWjb+UUcSpqXkNBi3/GOVdvPUY9baYhD43Xt4Afye00J/V7k8M6ZsDrUMblPfg/xCKdoBriv15Ld09J9/lEN7e9AlSeVRZjXwN+qQkI4aD+BOo+iyKTbFTP5cFnfYE+4PueK2tnxH2FSe/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WoHimJzIzLxQ1QhsWTQCOEJZBtY6WWGzTNfOK95Ww9A=;
 b=e8hC42UF8KnlUoTlQ3yh82qjRAMiFCnJMsUY36wxm43f/Q569OGU18oMqEGf+36QF89cWOIV/Ss3LZemvJX05NZb7yTk65jGIFALCtZ5ArcLOY5Gm4HK3Kb+tkGRDJ/jt0gUxzjuXI6eMDsV29ohg933/Cqh+CLMpP9ZGLAHGYKchPqcJxA0yN1sJZwrhnqXMqMRmblsfCeZWRZY93JY4ieyrN9ygbNXVToEjHrZC54kfHhTSr7TntbtdEz99M/w11ZTs7KQXaddjSW4tEaBNkHvUlsYhJIWNNqQmH2vBFx99IvVkPtGCfi+Gzf/WDUxmFkajCmCQdP1b8iDhBmT2Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4c1cc983-6c16-4efc-9686-1e7a79c3122f@suse.com>
Date: Mon, 10 Oct 2022 12:25:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6806:EE_
X-MS-Office365-Filtering-Correlation-Id: fb50c21e-5071-437c-c585-08daaaa9bcad
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1jpCzpZ/c1NEcVHUd6dk/DfZlb+mb1zDUWfw4jS+DvqcmNWCecJt5205nBXOgzPsFLdMlk/DUYWKtE55KBV52j+U54MsiNuBgjxqHyGAW8hPItqRkUSNhEIDWHHF2OzQp8hsKrTUqaM8xvODl+P6JoNK5n6LjVNmsyBXqKeE30EP7wRBFO90kbps69viSTFnz6J0psIR26jcsgaG23kMLc//02/zZNlnluj2e/zfB+X0NVVLZKM7x781K7movXZ6zq+urS2bBBxbsgUbR20Z7jpG3oah3aNsQbps7m3CTe5eZ4OA7i2GxI6AaTFHNfwFtf6wEl7dl09dDj4mZ2mC4z52c29f/QDHDdsLN+6KrfP44WJ0hSUZTyl/yfyr88LhhZsZzKMpUjII3qnizbFNeGFyEH24VNYFUKiWPYlLbOJa9jkqUysfRBIvUbLdIjoQD8b6KuwHU6cndehAzQv82Yk08uaW6e4Dtn71lwOBakjhDaFQo/ACZE6Lg2fr9dLESRX4jEdFX+YsBX9yzXzho/8/023YXfflvtbNPdWSzL68YOpqPCKcXC8VRXElniBT/DlD9XgjrvhAqyEZOvOGhvUeZiyf/9c1N+yjfJvXfvtOvyM0t8R2BCTDx+SjuzDRXz62llofOeYHjuRj+rum/8S9gnLtEhKKU812W4ecOh0bgnIw68EbL4BOg77R836ecuqedGOpXAuZPNSIzGHuOV3m0Wsg/Ygq1S+ePeueLJ1onr6QqrQrbJ+ZOZ0zm1s2cGc6K7kVViB7H+YjAOfvc0hVk8Dyq/4OyvRM2ZZ/YNk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(39850400004)(376002)(346002)(366004)(451199015)(26005)(6512007)(478600001)(186003)(6506007)(6486002)(2616005)(83380400001)(4744005)(2906002)(316002)(54906003)(6916009)(5660300002)(41300700001)(4326008)(66946007)(66476007)(66556008)(8936002)(8676002)(86362001)(31696002)(36756003)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SHFMd0wzT052S2NmSXhFWHlPQ0hzSzZ0WVk4OU8rUjkvN05vbU1rWXROWFNa?=
 =?utf-8?B?Qjlkak9iaHg4aHQ0SnY4a0tUdHdrRGQrV1h6L1BMNkI3RHhaQXp2TkxHZFFu?=
 =?utf-8?B?V0h3Tm03bnVPRHVnV25kb1hUamtENWZtcjgxZVRTT1k1OUtMdG5lRUR6bkVt?=
 =?utf-8?B?T3NGU0hwdUgveTdVcGF4YTNielhONlUwYUZzclNka1ZCYVg2UW1HRUN1UktW?=
 =?utf-8?B?cFY4SlE0ZC8yTzQzd3oyc2ZpTGpEaE11VytaaXhBZzZwdktuOWVmM3I4UDM3?=
 =?utf-8?B?TzNMZWtmSjZNNk5Qd3I1VEFMaTQ0OXdIN1VOcDNLNU0rcURyWitmUTZMbzhs?=
 =?utf-8?B?Y01oWHQzVVhPVzFKM1hHeWhHMU5BbU1QU3FpZjlNZktkYTNnaHZXQUdHTWc0?=
 =?utf-8?B?OEJ3RHZUZStxeGovTXpVMXJYaUlIdHhMNGhNWjJBNmZpVE1PY25zT0E2cUhP?=
 =?utf-8?B?RU56KyswZ2NUSTcrSW54bUhLWG4zMFJKd01CVnNqTkN4NzFoZkxTSndVaEo0?=
 =?utf-8?B?SElxbExVTFh2YkdJYVprdThvenA1VmJnQVp6RXR5TVp1TmFGa05xdVVnYlB4?=
 =?utf-8?B?TzhydTh2UFdCd0dtUzM1QVdZUllJUDFlQVkwUmczQ0p4UFpmekxzaUl0Zy9Q?=
 =?utf-8?B?aFVGeFl3WjQ0YTA5dGRzdWt2Q1pUZzdHNkZ1N3Z4NERBOEJWMG04aU5EM3or?=
 =?utf-8?B?Y05wWFVFaDl0dmx3Qit1RUNuR1ZSZHMybUFhMTlPV0NjeVJhWnBKcmFOWFJv?=
 =?utf-8?B?SmY1Z1dzTjA5ZElzcnVnZ0RZV0NERDNoTmNJSlM2R1lBYWlTTG4ycjdDM3Ez?=
 =?utf-8?B?Q0Z5TkgxN1BGa3ZRZ2xVMnQzaFNua2tHSUtjd0dranZwd2FXY1lMZU5ROXVF?=
 =?utf-8?B?ZXBlTzUrQjdRakpIamJzaXVvVTBhdW1XcjNiQzZFaktwNmpCMHg3M0cxNzRY?=
 =?utf-8?B?Z25jaGpHOHBYcVA2VlhMTVZFSjdLMzE1WFVQclNxZkN5SXVRSmQ1VUJteG9n?=
 =?utf-8?B?clhqQ1NBdVVrQk84UXVJTzRpOUdTTlJGWTFDaEJVS3E3TDZ4alpuem9IYlJw?=
 =?utf-8?B?c1VaM3N3Zkk4K1M2K05VZlRmWXI4VDZOdk9KSFZvdGZjQTlNYWpkVWxYRmt2?=
 =?utf-8?B?Z3ZHQ091Q3BvMndmZjJ1VHhYSG93c2xxdXpyYzg3MVFHakU5Z2daUVZoaWM2?=
 =?utf-8?B?QUhVZktybU5wd1YvejZLY09KeWQ1blB2MDU0M2lWYnQwTURwUEp6QWx5V0JE?=
 =?utf-8?B?NXNJTFhsRU1LTjJnVGwrdjFUVk9HM2RMWGpKTng3N1JWN25IOEZDblIwQ3hN?=
 =?utf-8?B?YWFUdUhRVFlIeFh4aW1sWVJNZzlzdmtTWHcwYXhBT3RHR0xmSnlXQ011RnY3?=
 =?utf-8?B?VGFkelJ3YmN6NjVBdk5tNmdLbU1SMWxYUzlxSGFPVXRXaDZBZTV4ZlRWbDc3?=
 =?utf-8?B?enJBbENwL21tSXNtREF2T1lSU3ExeWNsN0Zyd2tHdUtEdy8xVzhCdm5QTnFT?=
 =?utf-8?B?ZWdLY2pZNmtTYXJ6djZLaG9oWFcvdTU2YVRkNXVWNXVybjVEakVab1pPcjB1?=
 =?utf-8?B?UUQ2Uk5MZlZ5d1RMRXNoWUt0OXE1U08vbk1uN2RQREpNcGZ2aG1CT0VMSEQv?=
 =?utf-8?B?Z04xSXRRSUxHbEpqV0VmSG1zMnVuSG5iakhQcEcxQjBBbUErKzNTNTJwNDN3?=
 =?utf-8?B?dE5vUk5DQ2hBWjJiVWpNKzBmQUJwTmF2LytZdEZJdzk1K0xEWG1XalRadTNO?=
 =?utf-8?B?ZnNMamJHNjU5SEx4cTNhRU5WbUtkZysvRmY0bS9DRGNFaml5eHR3bVNFZWFV?=
 =?utf-8?B?QVVzN2V4NVcyRDR5WWVSL0ltTktpTGQvLzVpM2pJN2ZnaUhSZnF6eWIzR2g0?=
 =?utf-8?B?NDJxQ1Y2U1dkY0pBdUxzMCtuYXZ1YnBkeitHYlp4UnJ4dFU3NEZBaGliWVps?=
 =?utf-8?B?VndtN1RoRHRwVmNibElHY1lmYU9pb0Q5WjMrc0s5eTdDYlp6VVBkUCtZUzJN?=
 =?utf-8?B?aU9HL29mWnZ1KzBaRlpJRkNVMUVreTFTRWlCc0RwNDVlQlJLZlVlOTNEWnMr?=
 =?utf-8?B?Z2RRLzJTdndidjlkRDJJYlNCUEIrZVVjTTIrYkNRWXNra2x0Vk5ZOHJQaHBJ?=
 =?utf-8?Q?LoNmNvPsX9VeOYGjw/G2yWAxe?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb50c21e-5071-437c-c585-08daaaa9bcad
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 10:25:21.9296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8tcwaYprkJA1shnNEN0LiM76NAqe0y7IP6r1HMbRXMw+oxoUS9K8TC9rG02RIzXaH4D5L2lT4nA6Ksc3mA0Klw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6806

With the addition of vmx_add_msr() calls to construct_vmcs() there are
now cases where simply freeing the VMCS isn't enough: The MSR bitmap
page as well as one of the MSR area ones (if it's the 2nd vmx_add_msr()
which fails) may also need freeing. Switch to using vmx_destroy_vmcs()
instead.

Fixes: 3bd36952dab6 ("x86/spec-ctrl: Introduce an option to control L1D_FLUSH for HVM HAP guests")
Fixes: 53a570b28569 ("x86/spec-ctrl: Support IBPB-on-entry")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
With both referenced commits having been for XSAs, we may want to
consider backporting this also to security-only stable trees. Otoh it's
"just" an error path ...

--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -1821,7 +1821,7 @@ int vmx_create_vmcs(struct vcpu *v)
 
     if ( (rc = construct_vmcs(v)) != 0 )
     {
-        vmx_free_vmcs(vmx->vmcs_pa);
+        vmx_destroy_vmcs(v);
         return rc;
     }
 


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 10:48:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 10:48:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419204.663964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqKl-0004JV-CP; Mon, 10 Oct 2022 10:48:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419204.663964; Mon, 10 Oct 2022 10:48:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqKl-0004JO-9V; Mon, 10 Oct 2022 10:48:31 +0000
Received: by outflank-mailman (input) for mailman id 419204;
 Mon, 10 Oct 2022 10:48:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bLGv=2L=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ohqKj-0004JH-Oy
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 10:48:29 +0000
Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com
 [2a00:1450:4864:20::62b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1265cd82-4889-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 12:48:27 +0200 (CEST)
Received: by mail-ej1-x62b.google.com with SMTP id k2so24028006ejr.2
 for <xen-devel@lists.xenproject.org>; Mon, 10 Oct 2022 03:48:27 -0700 (PDT)
Received: from [192.168.1.93] (adsl-75.176.58.241.tellas.gr. [176.58.241.75])
 by smtp.gmail.com with ESMTPSA id
 d9-20020a50cd49000000b0043bbb3535d6sm6943881edj.66.2022.10.10.03.48.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 10 Oct 2022 03:48:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1265cd82-4889-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=/m8cPN/80S1OIhTrMIUFxGtQ8bvuTGNRYFePTvQwocw=;
        b=IRK5TZwwAvQ+Vlbw24wW/SxGXRajfXcbnllTa8pIf4veYXbIjURZx6mjTOqUm16DY4
         f7uXGaF+77IxG5lXHYdkAMlgusP8Xxg6ziFNKqOw2IJggkXK8MfFUZHxMwEjfUGlWWCa
         BGmy7+qFYz2rSFleRkxecpOKKpCu1mbutTTgGJK44eepljEq6cgxlkgdWydemnJiuszf
         vdRHJST78XzXo8A3GzKviWS8J7mV8VlLgEXYPLfv2SZfnGXes4aiv8NLpbXBsCM0bjUB
         TIl2KHQnGKo0RFFiYG7grIeeB5zK4Vu2noGHZHEboJYINzTiO720EPnRyPp7aUtwCpF/
         WYQw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=/m8cPN/80S1OIhTrMIUFxGtQ8bvuTGNRYFePTvQwocw=;
        b=rjheu9TQgu9JxfyQo2WpkvsqJ0PenrMkwatft+ZqP11lGFP7pktB+L9RdqeBwHh4cy
         l37J0+hC66JbJeiPYOm8k22TkUIblfTVj+jE32vtxP/bVEFEriAQ1Wp3+yGtRV7eYkdJ
         BiyD2u2RwxKIQCtVkdpFMi4wiXEz/YcPB4gfXkW5P/lHPWS58BlA+HKR7TXWqfc5u2YS
         rvKiy/tAV3AcptIuSsjhkyPiGnyUyhcrFnZEkVVyTOwcv2VPHDcR69djmx/m+LkgVpjK
         ooCNKmjtuD08NpKtEIUBq6BH7uGUF4SMwFhlC+2O8zbdHMuZM9oylP9yWYSeeJ+ap2Py
         7O1A==
X-Gm-Message-State: ACrzQf1PHOYY4HdSX6K3fdrstbofyJ9IoKMx0ZlqzuZAiRJ3RUbl81cY
	XxkMBGj/5kry7fFuA/6beQ46xcaYJI02hg==
X-Google-Smtp-Source: AMsMyM63vDgQpimP5OFrEy6pXvR08tkb87zbwtyLlCJ0yd4gWH6UDuIWZ7bDe5MvAU5nyQJp4oIzJQ==
X-Received: by 2002:a17:906:d550:b0:78d:a6d4:c18f with SMTP id cr16-20020a170906d55000b0078da6d4c18fmr5593488ejc.113.1665398907086;
        Mon, 10 Oct 2022 03:48:27 -0700 (PDT)
Message-ID: <81ac614e-ca88-5f14-bd76-eaa20c9270bc@gmail.com>
Date: Mon, 10 Oct 2022 13:48:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [ImageBuilder v2] Add support for 64-bit addresses/sizes
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org
References: <20221010072947.8300-1-michal.orzel@amd.com>
 <4fc23936-4bfd-635c-b3a2-554e280ce884@gmail.com>
 <f052cf3f-529c-2156-f058-2a320a4f1b02@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <f052cf3f-529c-2156-f058-2a320a4f1b02@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/10/22 12:48, Michal Orzel wrote:
> Hi Xenia,
> 
> On 10/10/2022 10:52, Xenia Ragiadakou wrote:
>>
>>
>> On 10/10/22 10:29, Michal Orzel wrote:
>>
>> Hi Michal
>>
>>> At the moment, ImageBuilder assumes that all addresses/sizes are
>>> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
>>> value for the first cell. Because of that, we cannot specify
>>> MEMORY_START and MEMORY_END to be above 32-bits (e.g. to place the images
>>> in the upper memory bank).
>>>
>>> Add support to properly handle 64-bit addresses/sizes:
>>>    - add function split_into_halves to split the value passed as a first
>>>      argument into upper and lower halves. These are then set as values for
>>>      variables passed respetively as the second and third argument,
>>
>> s/respetively/respectively/
> Ok.
> 
>>
>>>    - add function split_addr_size to split address and size and form a
>>>      string to be passed to dt_set as data argument for reg property.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>> ---
>>> Changes in v2:
>>> - redesign a patch based on master-next instead of NXP dynamic assignment patch
>>> ---
>>>    scripts/uboot-script-gen | 33 ++++++++++++++++++++++++++++-----
>>>    1 file changed, 28 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
>>> index b24dca2b7f7e..09d237d192c1 100755
>>> --- a/scripts/uboot-script-gen
>>> +++ b/scripts/uboot-script-gen
>>> @@ -22,6 +22,29 @@ function dt_mknode()
>>>        fi
>>>    }
>>>
>>> +# Usage:
>>> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
>>> +function split_into_halves()
>>> +{
>>> +    local value=$1
>>> +    local upper=$2
>>> +    local lower=$3
>>> +
>>> +    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
>>> +    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
>>> +}
>>> +
>>> +function split_addr_size()
>>> +{
>>> +    local addr=$1
>>> +    local size=$2
>>> +
>>> +    split_into_halves $addr addr_upper addr_lower
>>> +    split_into_halves $size size_upper size_lower
>>> +
>>
>> Just a minor observation, the variables addr_upper, addr_lower,
>> size_upper and size_lower can be declared local.
>>
> This function is to be called to perform substitution and as such
> is always executed within a subshell so no need for local.

So split_addr_size() is supposed to be executed only in a subshell ... 
Ok I did not think of that. So neither addr or size need to be declared 
local.

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 10:53:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 10:53:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419210.663976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqPj-0005ir-0d; Mon, 10 Oct 2022 10:53:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419210.663976; Mon, 10 Oct 2022 10:53:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqPi-0005ik-Ty; Mon, 10 Oct 2022 10:53:38 +0000
Received: by outflank-mailman (input) for mailman id 419210;
 Mon, 10 Oct 2022 10:53:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pai1=2L=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ohqPh-0005ie-BI
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 10:53:37 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130078.outbound.protection.outlook.com [40.107.13.78])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c967fca1-4889-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 12:53:34 +0200 (CEST)
Received: from AS4PR10CA0002.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5dc::19)
 by DU0PR08MB9751.eurprd08.prod.outlook.com (2603:10a6:10:445::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 10:53:28 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:5dc:cafe::8b) by AS4PR10CA0002.outlook.office365.com
 (2603:10a6:20b:5dc::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Mon, 10 Oct 2022 10:53:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 10:53:27 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Mon, 10 Oct 2022 10:53:27 +0000
Received: from 166f743c75a7.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 92EA9236-8100-4409-8700-5B5F410C18B0.1; 
 Mon, 10 Oct 2022 10:53:21 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 166f743c75a7.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 10 Oct 2022 10:53:21 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB6346.eurprd08.prod.outlook.com (2603:10a6:10:25b::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 10:53:20 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022
 10:53:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c967fca1-4889-11ed-964a-05401a9f4f97
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=dx2Zqf+nhiHhdXb2pUTj2t+93oSIdlzurQp9ESi0OkRJ11rWrE+ylRA9wK3DdwZyecMAfcv8GiWyiXvcQ3A3ydCBvkF8mxnSwb0KDdaAZouWIrALPhsSiQ7qGU7odxNqZhtQGpWAKmTLjuH8T8NJXY75RNkIE13I0qbNm3LVv/SKG6XWJzwEAVBelFCfFztzgK55TzqUIFpwZSVgCSNZOKDr/r9s2pd49zRVqZQxIgdJ056qwwWVKi4fRn512ayn64tlwLbC68vFw9DhKC1m5390BdvUVHlELB14FOpjosO8t4jPQ4/maNnQvg/WvZkkcCikPF4YyzxqiHsqVdjHRg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GVWEMsvpSV6M9Z34qOHiGgzzMXl2a+1Jgr+E0j4hWJU=;
 b=F+sBsb6QcS5/aQeSkAmB2TzyiJb9vNZ8/2PqW/IATaL7DiBp2s42+DkIO/OT9cgUxDY++cCcOmWSJoDx9MZfXu7dipxlE/4fssvGGCLCDHdlilt0n6P6+OUloI9bAOh13nmoX5lyTwF4zWeSqYeRSbgfFC+rKRWlIieAd8ltSgqm0BQsxvhChBQLP1lVg0HlxiK9Hm5FwYngaZrN5+IFiCVTym8OET4RpdI5LCxhK+FE6gbIV/voQQKdRfYupkKFUUBgvhflQOv2HVFJI4DIQP4Q3U3m1xnDEvis6kZwDySJ/klOtaBMfg5pmFZRXPZYb+SN3OHKXET04/Al+8vClA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GVWEMsvpSV6M9Z34qOHiGgzzMXl2a+1Jgr+E0j4hWJU=;
 b=lvaHLFB4Od/tDVGCt1E+b69eeSAczM4gewtN++bZi9Tq2mHfZhYmG+F2tth9AVHUvxCa6N0nkfAPoVHr4tQvzMJxvd42JyADkP3ANK2gqnrNFnsIZSBKg+yY2TXfiKpaXDFMmuy6nsmwUK96GbVnGWxEJzRZWFh9cqE/SKzI/GE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G77Hs/dBEz0zoRMRByVmWg36KyjHe4WP1XwADTND/g9yGMww17Bab0h7CgyYGTaDHF/9T+7RcuSOxUshv124pz7NC0iryWktSkzQ/p8fHdJ2+IIPofMlfWGRze645tl7nhnEJlne2qx5Sg8D3SifcuKEzhQPeiOPpOg9Q2JIdaK/t2CgE0kMPOqHXtwkgjv33MGjV+xrHx8XyBOhY4C53ylGRIdctRTvhY5457PYByBexkS193Oc5cCnpkzX5n2Vlmk+6Nsw6UZi67hw7HjYAGvdIt2S6/sQI6XnQXQ30u17m0NIEsLZueBp6k/6ekdXh3CeGiQfHxLg19DrLUE65Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GVWEMsvpSV6M9Z34qOHiGgzzMXl2a+1Jgr+E0j4hWJU=;
 b=VgC0aiB4wtRO5ZstMwUlK8gj1w2K8WXC8/TN3QeI9XOII9pHojlbVWlpPYttzVrjcSxPTqxm/1wGrO2VuzwOM2iW17okZHpCtbpAeTDHXfQcaF0YK8jQ9F9qVFZc0upeNqU78O1IH62+fuR9sO5MMLLz6gZgFITPwm3Iz2L2LviHhLp1jeV5ne40WEy8+wFqCzhAEW8QWhWelLcDvgGP9bnolnC+CH9OnltomIyJPyAkxlAD7P2gOxse5FYriJ3VZZUt/eeTW0kxVPYMhMd4PZF/F72Bf29Z+VL90jh6WgRwrilEa3/wMeDrqJ0rBEVfzyGqSJzig/tnZvVURA7G/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GVWEMsvpSV6M9Z34qOHiGgzzMXl2a+1Jgr+E0j4hWJU=;
 b=lvaHLFB4Od/tDVGCt1E+b69eeSAczM4gewtN++bZi9Tq2mHfZhYmG+F2tth9AVHUvxCa6N0nkfAPoVHr4tQvzMJxvd42JyADkP3ANK2gqnrNFnsIZSBKg+yY2TXfiKpaXDFMmuy6nsmwUK96GbVnGWxEJzRZWFh9cqE/SKzI/GE=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: RE: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
Thread-Topic: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
Thread-Index: AQHY3JKk95KKydAo1UWcu6C5J8zQU64Hckhw
Date: Mon, 10 Oct 2022 10:53:19 +0000
Message-ID:
 <AS8PR08MB79916EB4B9BE42E3238AF14392209@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <4c1cc983-6c16-4efc-9686-1e7a79c3122f@suse.com>
In-Reply-To: <4c1cc983-6c16-4efc-9686-1e7a79c3122f@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B19BE698B9BF8544B3DE2B4612C0943B.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB6346:EE_|VE1EUR03FT009:EE_|DU0PR08MB9751:EE_
X-MS-Office365-Filtering-Correlation-Id: 46b90197-5b18-4a78-4457-08daaaada99b
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CL64yAQlCi6pkqdf/h3ku5z1e13+1AtpEV5C5O5jjvG96/lw8T465vluOdsE1FyY4VNhCXHnaK0F+nBaHkW9Z2ecmONlM8Y+fM71acopW6iNm1E20VGLVQ8bk3NyDWUl3ZFXbodXYSTlYG3kwoGa8sooNs02kBmCIssFbgY6ddCuVhhX4H9u0Y2BXWHyaY9ixZgkC04EBR3J8bImux1meIUbW6nLvsfD/kVJDK6RVEdYU07924g6AwWFdWvclYHPAscyBAMc9O2/66wMdVwVrJhAMoP+4aoJcsQzdxVrzV91LewEGcxyiheGBJdw4lizAO5GuGl+sMP0U5yDAmmG6QqaqtUn/rMZ79UpUj3Om7X4Uz43EloHIZ81w2BCmtHLvqKjYq0+sVMpql1+BvVM/kwSuo8O29/f9PV3x4XCQ2+kxPFDWDGsO5LGnH1NeGl/yeMLDcXURwP1NeP4v3DnRwNLo+TR7vZCTYJahZOjsqs12CvL4RbBxPMMwjHg5y5v5wiisjSDArGdK1KR7+8/jnRs9TZsehEf7snPbS7rUNhrAiVtK4Fb0DSXz/uR8PiA8gIPgymlRTtZ5I0gx1Vcu9blAolNu5i/z+snJCWAKSFRY2Z5GPDPjaEElrJFhYjwdWpGWY3E/PwNC8NiDrVdrGiTcp4LdxyLBtIAyJVYH8x7ZDgM5J9pIeZ8GwmKizWR7IZNWOD/Bdw7ef9mCRdVNKOc44wl4Domfi7bBpn7u5/j/tEHNty4qs1cYOO2E1FMr50qkg8fdX6OpP7J8nL+3w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199015)(66556008)(83380400001)(186003)(9686003)(26005)(66446008)(76116006)(4326008)(2906002)(66946007)(52536014)(86362001)(66476007)(4744005)(5660300002)(64756008)(8676002)(71200400001)(38100700002)(6506007)(7696005)(478600001)(122000001)(55016003)(110136005)(54906003)(8936002)(38070700005)(41300700001)(33656002)(316002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6346
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	52f2b67c-1925-4db4-3831-08daaaada4b3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AjGhsYNZ020o0GMEK/h9Kp+1bW2qIGdzzCJX0i6vUCp9l5SCMeIlbJ/UkeI/0dm2rzrHILmrbBlXlP2o0Bef4XaQxpZLbsIgxxn3NoUjyKaiG5SyvBKDJ/GFQ4/Vo/Zyjk1yGgCIaDkH2cd3rK8coxUM+39dCn2ToR0FkHV3/rCVy6EWDzmmYk7MYhnthyz+/xT4qEWEkJOq+SOPGWPI+hx/HJA3E0/9uA3U32iQGmot3IwsuetvFuONpGmJQYXyyXBOdtTHPsShbA/iAubZJmMlk5dgvsvSlLhnJYvTyOHzn89xqF36/PWidtcx5bQPXYm1TgoMf05UTGI/BqX3nsnY+lqVT7bq3FyQbdgnU1MOG9Tq25Yp57hXn/uCn5haaE6Powk+wYDAiXG5VTw5JL2i60p5RemQd8XUvhMm1rJkMJl497yCn3Y44QvaoG27J/Dh6PF9hz7olntNOGNMlnjWdmKvfZxgTElE+ckxrE2i6ODITHel+Eoy/6kJbxFOep2ymUzGgMO3xj15GppAlzSfHh8sFKEQvYLs/AWMjWfoSmeTCnaRU6K9HcSw4M47FgutNxZ6o8lPEK3MZ8IOOo+jjzNvGo4GTArJsKAKaA5Y1jfr7r6cXaHBYaJC+Br+NE/9ZFV6yjDDCCt3LtTW7+qYBGFJSfaoj4lKMhzCLMgNb+gDETcpmnDih5ymzSPe6mN0EKyrwUTzzdE5YnfXV+NEUl6l1sZ9M5yFbyUrghnzxk5QSr2HtKIZOAowtlr98BH0TjCi7g3QUnUuIbdrNQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(26005)(9686003)(6506007)(47076005)(107886003)(478600001)(186003)(336012)(83380400001)(4744005)(55016003)(2906002)(40480700001)(7696005)(40460700003)(316002)(5660300002)(82310400005)(110136005)(54906003)(70586007)(41300700001)(4326008)(8676002)(8936002)(70206006)(52536014)(86362001)(356005)(81166007)(33656002)(82740400003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 10:53:27.6217
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 46b90197-5b18-4a78-4457-08daaaada99b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9751

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIXVs0LjE3P10gVk1YOiBj
b3JyZWN0IGVycm9yIGhhbmRsaW5nIGluIHZteF9jcmVhdGVfdm1jcygpDQo+IA0KPiBXaXRoIHRo
ZSBhZGRpdGlvbiBvZiB2bXhfYWRkX21zcigpIGNhbGxzIHRvIGNvbnN0cnVjdF92bWNzKCkgdGhl
cmUgYXJlDQo+IG5vdyBjYXNlcyB3aGVyZSBzaW1wbHkgZnJlZWluZyB0aGUgVk1DUyBpc24ndCBl
bm91Z2g6IFRoZSBNU1IgYml0bWFwDQo+IHBhZ2UgYXMgd2VsbCBhcyBvbmUgb2YgdGhlIE1TUiBh
cmVhIG9uZXMgKGlmIGl0J3MgdGhlIDJuZCB2bXhfYWRkX21zcigpDQo+IHdoaWNoIGZhaWxzKSBt
YXkgYWxzbyBuZWVkIGZyZWVpbmcuIFN3aXRjaCB0byB1c2luZyB2bXhfZGVzdHJveV92bWNzKCkN
Cj4gaW5zdGVhZC4NCj4gDQo+IEZpeGVzOiAzYmQzNjk1MmRhYjYgKCJ4ODYvc3BlYy1jdHJsOiBJ
bnRyb2R1Y2UgYW4gb3B0aW9uIHRvIGNvbnRyb2wNCj4gTDFEX0ZMVVNIIGZvciBIVk0gSEFQIGd1
ZXN0cyIpDQo+IEZpeGVzOiA1M2E1NzBiMjg1NjkgKCJ4ODYvc3BlYy1jdHJsOiBTdXBwb3J0IElC
UEItb24tZW50cnkiKQ0KPiBSZXBvcnRlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl
cjNAY2l0cml4LmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1
c2UuY29tPg0KDQpJIHRoaW5rIHRoZSBjaGFuZ2UgbWFrZXMgc2Vuc2UgdG8gbWUgYW5kIGl0IGlz
IHF1aXRlIHNpbXBsZSwgc28gSSB3b3VsZA0Kbm90IG9iamVjdCB0byBoYXZpbmcgdGhpcyBjaGFu
Z2UgaW4gNC4xNy4gV2l0aCBwcm9wZXIgcmV2aWV3L2FjayBmcm9tDQpvdGhlciB4ODYgbWFpbnRh
aW5lcnM6DQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNv
bT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 10:58:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 10:58:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419216.663987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqUf-0006UU-JO; Mon, 10 Oct 2022 10:58:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419216.663987; Mon, 10 Oct 2022 10:58:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqUf-0006UN-Fj; Mon, 10 Oct 2022 10:58:45 +0000
Received: by outflank-mailman (input) for mailman id 419216;
 Mon, 10 Oct 2022 10:58:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ELN4=2L=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ohqUe-0006UH-7N
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 10:58:44 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60070.outbound.protection.outlook.com [40.107.6.70])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 813f5cf4-488a-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 12:58:43 +0200 (CEST)
Received: from AS4P189CA0012.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5d7::15)
 by PAWPR08MB9032.eurprd08.prod.outlook.com (2603:10a6:102:341::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Mon, 10 Oct
 2022 10:58:26 +0000
Received: from AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:5d7:cafe::e3) by AS4P189CA0012.outlook.office365.com
 (2603:10a6:20b:5d7::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Mon, 10 Oct 2022 10:58:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT053.mail.protection.outlook.com (100.127.140.202) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 10:58:25 +0000
Received: ("Tessian outbound ce981123c49d:v128");
 Mon, 10 Oct 2022 10:58:25 +0000
Received: from ca465dd21652.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DE545B81-A71F-4838-B664-BCED90E17D9A.1; 
 Mon, 10 Oct 2022 10:58:18 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca465dd21652.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 10 Oct 2022 10:58:18 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB9PR08MB8316.eurprd08.prod.outlook.com (2603:10a6:10:3dc::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Mon, 10 Oct
 2022 10:58:16 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022
 10:58:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 813f5cf4-488a-11ed-964a-05401a9f4f97
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=VCGuEW+eXtPcfi6Npt0M0vQc4kQifrC4G+nzB/ihPAh9VTmFIoS3tlkjdXC7+ZPipluMu75ONVs0K78WexpJPm9RsrWYqg4OE//UvnXGcMgrXT2xRYpKpTu++J87a7S+2GP3tQTX9jmtkpDDHM/CIfijHjz3wQE5UriNc2ZGysZmDsSg1ykBByndjrtihAmvruB5BRQAXnM5V7FZyqN8+Yd08bOxMn7UJi9YWnmRbTvKPnukzNlLMrDJsCJjDxDA0EfG4QayESpIsILvW4Ty2IKkE9WLn/YjStrU6qAHsZD5K6VNJIRU1MbFvo52uJFbG9jqeK6hQiYGShoP/gf1ag==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lqyKgq6V0Ht3/clpAcGjbaZ8K0mBwk9PP5HdqHA3juU=;
 b=Ry3FaMGzh/WsSV5R4qsbNHEdho0FceSV8iAbTV/HS6weKyIkFJT+JqMrvhFK0frf7SSbnBcvg07GQKAJFjMVcsC76gJSMwJ0JPLSV3B+Gu0eUi3xJ/Myl3KULJ2u+lSyWm7+pTYNIV3jgioQ2U8+dP407nyOFB1rA1qI+Fy4uRXnWJPjelkwDiQnvKRbtuKecbEmoqf7syH6BJx+4avDL8SSKr0WEfHad3BOQN8smbJ6xFiCjUX/8ncgUkuynrpnqizlNkb1GcENhw1kxaaaQ/ziJju4z4Locb4NfsGpLN0aC/6ZBx7RxN8BoMvxP+7IixjuAz+Et7KOew8y88pzVw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lqyKgq6V0Ht3/clpAcGjbaZ8K0mBwk9PP5HdqHA3juU=;
 b=oEgEshByIDuD1lkxp7hb69RnuwTPobcd9GAFj14i69wbQaBxTOvNcjzakNayDrrtLcMao/YbcX9O6gohbVG3vBnbPVRpwkt/OQVCsZdaXOqKOUObCdhfZoO6kD+/yAi2Cirrd30Ok151KhCUJxp7BqbXe7WHgGfccKx1hOLruXk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 65a13d9994d6c2d3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=grgpor5JOKq9mCk6exaAtD8ArmDNGJMFex9xnYw1Gf/t9qtP5/PyjHZjKYjtAaaem9a2vlF7W3/93UmlLsa7IZkzwypMI9frNkeJvjY8r2KsT2fIv8e9JJnP3bfaIXpleHf5R/yCOmOHMS7AuIk2Qeld0T52bpLJmSuSBNRr/2hpAbtVwbl+NY2lUa8f4zU8tCgT3Px9ZsZ2BVIcgQWuijubz0oq1gTf5UnvO8kptVI48mp7aw7RQ6YdSEHSRPKUMnhwezxP55a0STfEi+L69RHV7zv6p8iU3h5jw5+n4PviZVvI/gaVJiquwyO5CEkYBmaFoOQYwFXcbjUxbJURRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lqyKgq6V0Ht3/clpAcGjbaZ8K0mBwk9PP5HdqHA3juU=;
 b=YtYpGodtlmJ6oLqXMN+JhoXdRehCRQNDGE2X4kV7F35XQpKqFBbn/ReaKzPUtUdjpJIQMjTPus7bcAM8AzqECF5N07mPmC7OJxmyt7A3io0NQnf4c/KxVO3TKv3/WbAirV+kRU3Vw6PYQKJaExcMYMy+/QkJLLb/XF2P4WDblt7UhENNdHQRuHYU+pbBJmZ9WdtoCGKUiWbFV/7TbUxzk/azoRTrwiPm4D9wP4SWexl2gdskvDhWEjFPCSJ/1kg+6DxyT/z+jrvaloC9YdKE3bt0+mWBlwXhy57NGR/atLSfDyNqa+Jc9pHsJguX4p88SSEk5EP7amMspf7XLuaBhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lqyKgq6V0Ht3/clpAcGjbaZ8K0mBwk9PP5HdqHA3juU=;
 b=oEgEshByIDuD1lkxp7hb69RnuwTPobcd9GAFj14i69wbQaBxTOvNcjzakNayDrrtLcMao/YbcX9O6gohbVG3vBnbPVRpwkt/OQVCsZdaXOqKOUObCdhfZoO6kD+/yAi2Cirrd30Ok151KhCUJxp7BqbXe7WHgGfccKx1hOLruXk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Wei Liu
	<wl@xen.org>, Doug Goldstein <cardoe@cardoe.com>, "michal.orzel@amd.com"
	<michal.orzel@amd.com>
Subject: Re: [PATCH v1 0/4] Yocto Gitlab CI
Thread-Topic: [PATCH v1 0/4] Yocto Gitlab CI
Thread-Index: AQHYt8nlVEDeUTiM20ag9zvPCK1jqa4D28+AgAPjAYA=
Date: Mon, 10 Oct 2022 10:58:16 +0000
Message-ID: <524BB739-088F-4F82-A312-BC660C34BD10@arm.com>
References: <cover.1661352827.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210071618300.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210071618300.3690179@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|DB9PR08MB8316:EE_|AM7EUR03FT053:EE_|PAWPR08MB9032:EE_
X-MS-Office365-Filtering-Correlation-Id: 03b0938a-47b1-41a8-9786-08daaaae5b1f
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CKAg96okt6GuMm23JOfS1DoORIwshWxLDMr3jvY+W31JS+Lan9F31KCMGycu8GCvsY1qf8mO5WLPH5X9kaga1topqKg6W5Jb+66DvWmzaTTpkg1x2GWYvtzPZcGx9l/6jQBWxX1vVWHJrKUXwvO30Gj4X/XcOReg4cGG03Cx2jChW6tXNIzm7M2x+MT+RTR5uViOCbAXfBIR4Pv0Zc0Nim+l90j4MTYU0UFff50xUcQndMvXVQY9Hg27SM9YeEuvwaJ5wamNkUWqFkPaaX7uOAV4muG9hpnuzMqycQCFwZClkrPUJLhwPPPwErDIFM7OyFH9kwHNqYIz2CfEN9owhJNu4e1pv+cOz31GrqkFLbxCKwqUP2OAFM5MGjPv7AC/g43Yy3e6r6MUjA4pcEs5oBTIvyhi4HqbGuKQsZGDRrXc9lAYumwtW3rNFO4acOrW9k7kGC9AmOfzIJb89meE990qeav39kVRjh35DmDdE7ybpnCxh7MT9mhPU4hbb5WGs18EG93pRlRNXMKjigoA3pp+K0xSIkOaQ6X7mWhNM+l/sZ0M2W/kxJV6FnbBDS560FcPNo3wM1tkM47W2VGddo9ncgSSkjWlztJwkzaa6xQDmoLvGwhrxNSmCa4k6hEEy+JJKKy6ezv4aWhcf6FjMPnj81RxFr2JKmgMZ3b77JqjY5Ac7dSxEVsIu9mNYT+EPErSRalQn+Jf4lzWp2r+9VaNtvySuUKzEUhO2N12K8PLv7CE26qhSAoBPHFtSZu0MQ/qmcjTQIoNcKV0tWdXWBPNa4FjqdMWvCGSRWoy1Y4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(451199015)(6486002)(36756003)(33656002)(38100700002)(122000001)(8676002)(91956017)(38070700005)(66446008)(66476007)(66556008)(64756008)(66946007)(4326008)(316002)(76116006)(86362001)(6916009)(2906002)(54906003)(41300700001)(5660300002)(6506007)(2616005)(186003)(71200400001)(6512007)(26005)(83380400001)(53546011)(8936002)(478600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2A87BC778EE11449AC15325D3C32E6A9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8316
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	318630ed-ea23-4e79-a737-08daaaae5567
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VNw7tsYnDzMX1AGNOycXOCFbIuRcOlzeGAnJJMlI8dZeVL0krkcm2fq3n3WzV2lfL6eVUQgEvLyvGqC8LdOdomGfCsnZhbJOT4bV8pWcWBgKJK//jPuErHCnPSkE7ZJQ7LhrUfngR/pRH4qb6OpHCJaX90+RKc+UzU5sHAZdHo5Bi7oSLm2NnCb23VYYy8qcUJdh6GhkYWFqX1zgSMDX6VLR3UWKAz1X//LOkL/nBCozkoJiakIeCUaOeg2r+7d3dTXBNDkEEC4w23MDFmAE0QexjNd7wY2cDJ0C8fnRcWA53eiintGYF1rlE/qWRNFmx/Xbtly2FHabaxOn51JxX+ri+v4miw1Jq94TQOxG+4GixP2OBesE0TPunhYFn00w+2T+2o5IdRUk1sStTIlgGv7RRxSJv8yQdThUYX+hxyGGZheNHmFNkbIbIQ4QgAK/UJXhqeY1ILjkDm2KOdpIVG/n+04sDHE3x81t04Gsb+4LsxO3uFz9dPvztMVVGgOM+ADLgtEuLIg1UNoFpPmrXlLFpA3aZ0y7IqYoJyBQphzWVIEPQV6kC8vPSLMgpY4dZIijcnYDMc4cVtVeUbj15Umx1/3ed1uk/DPRcM+XUFWmohUBQv40wWXMC9vThVpOKPK29sbF0bVychrhDdRpfYfIQ1eO16IwIoytezrlbzeuMyHG55k4SMpeRi/EtynuNmkD0DGIiw42s5p0yspYUT5vqLXk1joaXL+eLxjFUDplsryXOZ/xWDgEJee1gu/EgZFkjtI5pRHzcpZzYTtBYw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(356005)(316002)(478600001)(82740400003)(6486002)(40480700001)(6506007)(53546011)(26005)(6862004)(186003)(336012)(6512007)(83380400001)(40460700003)(36756003)(5660300002)(2616005)(8936002)(41300700001)(54906003)(2906002)(70206006)(82310400005)(8676002)(86362001)(36860700001)(4326008)(81166007)(70586007)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 10:58:25.5706
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 03b0938a-47b1-41a8-9786-08daaaae5b1f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9032

HI Stefano,

> On 8 Oct 2022, at 00:36, Stefano Stabellini <sstabellini@kernel.org> wrot=
e:
>=20
> On Wed, 24 Aug 2022, Bertrand Marquis wrote:
>> This patch series is a first attempt to check if we could use Yocto in
>> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
>>=20
>> The first patch is making sure build-yocto.sh is not catched by
>> gitignore.
>>=20
>> The second patch is creating a container with all elements required to
>> build Yocto, a checkout of the yocto layers required and an helper
>> script to build and run xen on qemu with yocto.
>>=20
>> The third patch is creating containers with a first build of yocto done
>> so that susbsequent build with those containers would only rebuild what
>> was changed and take the rest from the cache.
>>=20
>> The fourth patch is adding a way to easily clean locally created
>> containers.
>>=20
>> This is is mainly for discussion and sharing as there are still some
>> issues/problem to solve:
>> - building the qemu* containers can take several hours depending on the
>>  network bandwith and computing power of the machine where those are
>>  created
>> - produced containers containing the cache have a size between 8 and
>>  12GB depending on the architecture. We might need to store the build
>>  cache somewhere else to reduce the size. If we choose to have one
>>  single image, the needed size is around 20GB and we need up to 40GB
>>  during the build, which is why I splitted them.
>> - during the build and run, we use a bit more then 20GB of disk which is
>>  over the allowed size in gitlab
>>=20
>=20
> So I tried to build one of the build containers on my x86 workstation
> with the following:
>=20
>  make yocto/kirkstone-qemuarm64
>=20
> but I get an error from the build:
>=20
>  21:30:20 build qemuarm64: Error
>  22:00:38 run qemuarm64: Error
>  22:00:41 Build Complete (2 errors)
>  The command '/bin/sh -c /home/$USER_NAME/bin/build-yocto.sh $target' ret=
urned a non-zero code: 2
>=20
> Anyone else is having a better luck than me?

I will relaunch an image creation test locally and come back to you.
It could be that Yocto has been updated since I last tested that.

>=20
>=20
> I don't think it is a problem if it takes a long time to build the build
> containers because they are not built often and they are not built as
> part of the gitlab-ci runs.
>=20
> The issue could be the resulting container size. I wasn't aware of a
> limit in gitlab -- I would like to try if there is a way around the
> limit (either by changing a setting, or potentially switching to a
> premium account.) However I need to be able to complete a container
> build first :-)
>=20
> How did you find out about the 20 GB limit? I couldn't find it in the
> docs. The only info I could find states that there is no hard limit on
> registry.gitlab.com.

This came after discussions internally with our internal gitlab and I found
some forum discussions saying something like that.
But it could be that Xen Project does not have this limitation hence the
need to test.

Cheers
Bertrand

>=20
> Cheers,
>=20
> Stefano



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 11:17:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 11:17:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419223.663997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqmd-0000q8-6Q; Mon, 10 Oct 2022 11:17:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419223.663997; Mon, 10 Oct 2022 11:17:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohqmd-0000q1-3V; Mon, 10 Oct 2022 11:17:19 +0000
Received: by outflank-mailman (input) for mailman id 419223;
 Mon, 10 Oct 2022 11:17:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zpu8=2L=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ohqmc-0000pv-EN
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 11:17:18 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam04on2065.outbound.protection.outlook.com [40.107.100.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 184fa91a-488d-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 13:17:16 +0200 (CEST)
Received: from BN9PR03CA0699.namprd03.prod.outlook.com (2603:10b6:408:ef::14)
 by CY8PR12MB7633.namprd12.prod.outlook.com (2603:10b6:930:9c::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 11:17:12 +0000
Received: from BN8NAM11FT058.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ef:cafe::b3) by BN9PR03CA0699.outlook.office365.com
 (2603:10b6:408:ef::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Mon, 10 Oct 2022 11:17:12 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT058.mail.protection.outlook.com (10.13.177.58) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Mon, 10 Oct 2022 11:17:12 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct
 2022 06:17:10 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct
 2022 06:17:10 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Mon, 10 Oct 2022 06:17:09 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 184fa91a-488d-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KBY6RjRxWRivXIiK04D50FeHD4/ShUxrZm4oxgHkDP3yzvszwtVqUtY+bNuOnBLzSC31SL57o4K2TCQpe+lwxvmgdeMpyRiqQKTWTBH7SPNZgvZblht4eSn8wIGAE/maHViKsNB7YkPFiiyhGcbagud1a4uaDY7gJXDBTozL/w9xo8hrhNbjmh4EMoTHC23WbOxDulZnit0FzLEclYJI/wzM6oYRfIO9I9l1luvtEmw6x+tyuVWnvaH++5HEGa5rOvs6JvQZAEgRjXFwTj6uxk4T2km5RK/bXXpo2TpkUaFXI2z0KNN+AG5cGvBwhXtVQffiEQNv24tRhvoK34TWrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k6OCjTyvdzPX0EU3EY/BixjntWzEslkxV2JB4JQdw6o=;
 b=HhnNHfOuaCfvMtou4VrS8XOMNv2GWLjlwSJ/byr0L+Oejo7RzhyiRrd5oxM/YAr1aE2cfrecKEkgNXvmmBDyO7vH9zSFVaTS0Xo3N0zsh9+Zj7skxiY8Cvx+0Rk8uDF2BP0GH6v06AUrpvXiVPy3R7oQ/8byB+8uW+rJHPXq8EIuPwOW4ZLUHtinU+LZ2+UTUAenaLqy+lMGpxHXT51z2T6pbECeYcGm6RsU4wjFRcBcXKzT5i+2V2TE2AuqS9dZ7BCbHju9lxvI5f17Qp863wt5T2yOZQc2aUvts18C7P/3M+Wg4PZDyO2svoJJLhy3+WCvP2SS/xzdN952Kzsk1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k6OCjTyvdzPX0EU3EY/BixjntWzEslkxV2JB4JQdw6o=;
 b=RcNnJSt8D3XoB/MyiSNuc12HJMQv7Pa9bGn0xAgRv2xODvRu+FK0tOolQ7M85IkfBMl4i1srb7U814Lc+r5KdAt6KBAcIr5G+I88hm3VSktgts9BCPCKPsERJco7vYMJoZ1OBjinfpvG/Mc6OUKlFFvmCQi5mn1bYB+vfMmDy7M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <890ee988-34ff-38c4-3ffa-70abe00d3df8@amd.com>
Date: Mon, 10 Oct 2022 13:17:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [ImageBuilder v2] Add support for 64-bit addresses/sizes
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>
References: <20221010072947.8300-1-michal.orzel@amd.com>
 <4fc23936-4bfd-635c-b3a2-554e280ce884@gmail.com>
 <f052cf3f-529c-2156-f058-2a320a4f1b02@amd.com>
 <81ac614e-ca88-5f14-bd76-eaa20c9270bc@gmail.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <81ac614e-ca88-5f14-bd76-eaa20c9270bc@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT058:EE_|CY8PR12MB7633:EE_
X-MS-Office365-Filtering-Correlation-Id: ed26ab94-fb82-4f18-4db8-08daaab0fada
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dBmMMhUhq6v3bZYyRj0Fl2NfXnUFUVuOzQ+bLGgcseGDA/6tbq8UFNj/SUTG39ihu5qPCgGQ/Qpown3Q8nxopZQhJ+lz3UURN+jAWlUNSj1k22aNhEW0OeQPG+wY2pMK9jYTUAVGHSrRT89QOyVCfvqHNYgUH1EDffjB2cBFvDol9UfN7K8mNXG1eNMfLP5nkkbIOd1Ic/FyDBd7Tg7KYea5g5ARnMJoLVfIDAj9oKLg0SB9we86plk0mYq2pojmRQRgV7F+rInWclkHyRa0YVgptPlLaHBce2PquaJaMUYOgU2LrMepennt7qLs+IangqUZgDaOsa6MLZcaJHRB87B97EiDWvvK6CVuvMkfNzchioykU/mLEfxF6yWKHH7tbr6ztPdSciZNYuOQwZ4Lk9IZAE5PjCVrEcYPT0xZ8pJv95H0tgb/ljBg6hvuj6bY5OVUX3TxAG26HQ/5GxpowA+jdAG1M5Okorp/OL1k04WFuKqvtovaO4iaYU2yuzxxMuIxSLBGOKk5chMdrSOQsJK+Lsf0YUshlIhy5myo/Fz9lGkKlQ36NLzDYI40A/MLNouAQDfzpW2y9PtY3v/vLLAjCk/BScNucuCqx0jE1sSh8v+ny9HoKz0+K9dRNbsenYDmO19Ph8C8TwEYMCrhiKWJ3epi2+6zy+hK3eKXrGDiZPs3nd2AllNWSwFqgJK8BJi0P3jEKdJrNQR2ClIIAG8qHAXlN6r6y1EmoKYErAg5is2d80KJ/gkwHlsJI1gr1UWQaPb8UerfEezt5SSNBuzNkkISH88iNdKWIS/pNvrR5m6besgNb/Bbu7Ql20Qtqpei55lYz2tJRmQ2oy37nA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(31686004)(110136005)(40480700001)(31696002)(82740400003)(86362001)(36756003)(81166007)(356005)(41300700001)(44832011)(70206006)(4326008)(2906002)(70586007)(8936002)(8676002)(40460700003)(186003)(83380400001)(47076005)(36860700001)(316002)(16576012)(2616005)(5660300002)(26005)(82310400005)(426003)(53546011)(336012)(478600001)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 11:17:12.5454
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ed26ab94-fb82-4f18-4db8-08daaab0fada
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT058.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7633



On 10/10/2022 12:48, Xenia Ragiadakou wrote:
> 
> 
> On 10/10/22 12:48, Michal Orzel wrote:
>> Hi Xenia,
>>
>> On 10/10/2022 10:52, Xenia Ragiadakou wrote:
>>>
>>>
>>> On 10/10/22 10:29, Michal Orzel wrote:
>>>
>>> Hi Michal
>>>
>>>> At the moment, ImageBuilder assumes that all addresses/sizes are
>>>> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
>>>> value for the first cell. Because of that, we cannot specify
>>>> MEMORY_START and MEMORY_END to be above 32-bits (e.g. to place the images
>>>> in the upper memory bank).
>>>>
>>>> Add support to properly handle 64-bit addresses/sizes:
>>>>    - add function split_into_halves to split the value passed as a first
>>>>      argument into upper and lower halves. These are then set as values for
>>>>      variables passed respetively as the second and third argument,
>>>
>>> s/respetively/respectively/
>> Ok.
>>
>>>
>>>>    - add function split_addr_size to split address and size and form a
>>>>      string to be passed to dt_set as data argument for reg property.
>>>>
>>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>>> ---
>>>> Changes in v2:
>>>> - redesign a patch based on master-next instead of NXP dynamic assignment patch
>>>> ---
>>>>    scripts/uboot-script-gen | 33 ++++++++++++++++++++++++++++-----
>>>>    1 file changed, 28 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
>>>> index b24dca2b7f7e..09d237d192c1 100755
>>>> --- a/scripts/uboot-script-gen
>>>> +++ b/scripts/uboot-script-gen
>>>> @@ -22,6 +22,29 @@ function dt_mknode()
>>>>        fi
>>>>    }
>>>>
>>>> +# Usage:
>>>> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
>>>> +function split_into_halves()
>>>> +{
>>>> +    local value=$1
>>>> +    local upper=$2
>>>> +    local lower=$3
>>>> +
>>>> +    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
>>>> +    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
>>>> +}
>>>> +
>>>> +function split_addr_size()
>>>> +{
>>>> +    local addr=$1
>>>> +    local size=$2
>>>> +
>>>> +    split_into_halves $addr addr_upper addr_lower
>>>> +    split_into_halves $size size_upper size_lower
>>>> +
>>>
>>> Just a minor observation, the variables addr_upper, addr_lower,
>>> size_upper and size_lower can be declared local.
>>>
>> This function is to be called to perform substitution and as such
>> is always executed within a subshell so no need for local.
> 
> So split_addr_size() is supposed to be executed only in a subshell ...
> Ok I did not think of that. So neither addr or size need to be declared
> local.
Exactly, but in ImageBuilder we don't seem to use $1, $2, ... directly so
that is why I added local only for the arguments passed to this function.

> 
> --
> Xenia

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 11:59:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 11:59:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419229.664009 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohrRd-0005d9-DS; Mon, 10 Oct 2022 11:59:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419229.664009; Mon, 10 Oct 2022 11:59:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohrRd-0005d2-AW; Mon, 10 Oct 2022 11:59:41 +0000
Received: by outflank-mailman (input) for mailman id 419229;
 Mon, 10 Oct 2022 11:59:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrRb-0005cs-Ob; Mon, 10 Oct 2022 11:59:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrRb-0004ph-Lp; Mon, 10 Oct 2022 11:59:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrRb-0002Uz-6G; Mon, 10 Oct 2022 11:59:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrRb-0002XP-5k; Mon, 10 Oct 2022 11:59:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Q4o20nYeXRejb9DAbgbHE10lWHVuqSRoqM0eGzeorX8=; b=nRI7YluxBpMjMtZe9G/STyWmve
	aIdkcPt4kqnenj3FcMEcSyZ0gwywJcvM53pFHFWqZlHyt3GVvuIluZGi3BLAWo9nhv8VwUOvHd5Nw
	olFYreSX1wC3Qzgo+Rw/zGUiWpTSl4SmW3kCxNa+x7DFB+35Yh9GjSeEEVRBdOFjWlPQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173483-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173483: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=493ffd6605b2d3d4dc7008ab927dba319f36671f
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 11:59:39 +0000

flight 173483 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173483/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                493ffd6605b2d3d4dc7008ab927dba319f36671f
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    2 days
Failing since        173470  2022-10-08 06:21:34 Z    2 days    8 attempts
Testing same since   173483  2022-10-10 02:30:10 Z    0 days    1 attempts

------------------------------------------------------------
629 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 49657 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 12:13:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 12:13:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419238.664019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohrfC-0008Ab-NY; Mon, 10 Oct 2022 12:13:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419238.664019; Mon, 10 Oct 2022 12:13:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohrfC-0008AU-Kv; Mon, 10 Oct 2022 12:13:42 +0000
Received: by outflank-mailman (input) for mailman id 419238;
 Mon, 10 Oct 2022 12:13:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MT9y=2L=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1ohrfB-0008AO-Dg
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 12:13:41 +0000
Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com
 [2607:f8b0:4864:20::532])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f93d3db0-4894-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 14:13:40 +0200 (CEST)
Received: by mail-pg1-x532.google.com with SMTP id f193so10211311pgc.0
 for <xen-devel@lists.xenproject.org>; Mon, 10 Oct 2022 05:13:40 -0700 (PDT)
Received: from leoy-yangtze.lan (211-75-219-199.hinet-ip.hinet.net.
 [211.75.219.199]) by smtp.gmail.com with ESMTPSA id
 o8-20020a170902d4c800b00179c81f6693sm6503693plg.264.2022.10.10.05.13.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 10 Oct 2022 05:13:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f93d3db0-4894-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-disposition:mime-version:message-id:subject:cc:to:from:date
         :from:to:cc:subject:date:message-id:reply-to;
        bh=m4K7D+0K/F7YWltdqfyFSRBf0Smxfeog/g1nUNmU0aM=;
        b=bEqw4HPnYF0QI5wyBrfwp1/dcKkLnDoVB41yhGDjhB67qtBofwXkqFXOmm63kxpFpS
         CJb/lRz8deKCkD0MEV+OzCCw6eSpUes8XLGtEorXzufotdiPhe+3zztvQVW+1YFDy0z4
         kO+rGmK5igt+oQOELFlUjbxXx0h5ISXt2jRZ0A54eHr1U5+xPUsV2Cekx9VnE5LsAySA
         iiN1KMtKMVhYUBAjaO2XrqpQoiG8D0cHEZ1EioVRmQ+Ivu10tVi76vf9sS5/2HRuOXr1
         etio6Rg1JrvzX2OXBof3ARic99bFQ37HTVB36ppm8hVaojU/5XLgSPa+zNkH68zINNP2
         Mcng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-disposition:mime-version:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=m4K7D+0K/F7YWltdqfyFSRBf0Smxfeog/g1nUNmU0aM=;
        b=fu09ifAUggKZwSR+LLTGxNMMqJEzRsmgSVA3lctzqX89R2sLAbE3IZx8bWcR2f+LWI
         tCz54FL+4GRGP3MPD2lrAnezRlA27FXidXhR1owepBS1tHHeNZifhx/8EzVM6nXVzi1z
         k8qbxy+QuAwIC2sledR0D9hw+0d7VwFNI1Loasj64HC2QCqa8rIVaRPy1z8yOwajRDm7
         LYXgxRpyG1ft89FYn/fRw5llsRRI/A9HPCLdzeq40OBSd9X3+oOoBs7S3UY3mrj8WWbW
         /oRGltKg3cBrn/MnkrCCnHMckE9mzLkhE37NwS1TPsd4P1cmqXqStZx42+LaVYxT42as
         RG1g==
X-Gm-Message-State: ACrzQf2mwebSvFD5Cbl9qcRuud+CrjtmPRF0Nb3HUr61f/2+J8f+4TR5
	WVvre4N1aZtF7WnYxsrnuYYjBjWa5PCOubjgd9Xxtg==
X-Google-Smtp-Source: AMsMyM4m9ME0T38Q303eUueTkdWIyoKPKshmxkXp50RQmJYTo/D3I69CfN0DeQt7iDIz0LEFSoaK0A==
X-Received: by 2002:a65:6055:0:b0:42a:7b2b:dc71 with SMTP id a21-20020a656055000000b0042a7b2bdc71mr16180548pgp.23.1665404018321;
        Mon, 10 Oct 2022 05:13:38 -0700 (PDT)
Date: Mon, 10 Oct 2022 20:13:30 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>
Subject: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi there,

I tested the networking performance on my Arm64 platform in Xen
virtual machine, below I will try to give out summary for testing
result and share some analysis, at the end I want to check a bit
from the community and get suggestion before I can proceed.

First of all, if you want to know more details for the profiling, you
could access the slides:
https://docs.google.com/presentation/d/1iTQRx8-UYnm19eU6CnVUSaAodKZ0JuRiHYaXBomfu3E/edit?usp=sharing

## Testing summary

The TL;DR is that I used two tools: netperf and ddsperf to test the
networking latency and throughput for Xen Dom0 and DomU, the below
result shows the performance for sending data from a Xen domain (Dom0
or DomU) to my x86 PC respectively, and performance is poor when
transmit data from Xen DomU (Note, I used the default networking
bridge configuration when launch Xen VM).

  Throughput result:

    Profile     netperf (Mbits/sec)    ddsperf (Mbits/sec)
    Xen-Dom0    939.41                 > 620
    Xen-DomU    107.73                 4~12

  Latency result:

    Profile     ddsperf's max ping/pong latency (us)
    Xen-Dom0    200 ~ 1400
    Xen-DomU    > 60,000

## Analysis

The critical thing for the performance is low level network driver if
it uses synchronous or asynchronous mode for skb transferring.

When we transfer data from my x86 machine to Xen DomU, the data flow is:

  bridge -> xenif (Xen network backend driver)               => Dom0
	      `> xennet driver (Xen net forend driver)       => DomU

In this flow, Xen network backend driver (in Dom0) copies skb into the
mediate buffer (gnttab_batch_copy()) and notify Xen VM by sending rx
irq, the key point is the backend driver doesn't wait for Xen VM to
process the skb and directly return to user space, therefore, Xen Dom0
and DomU work in asynchronous mode in this case (Dom0 doesn't need to
wait for DomU), the duration for handling a skb is 30+ us.

Conversely, if transmit data from Xen DomU, the flow is:

           DomU                    |               Dom0
  ---------------------------------+------------------------------------
  xennet driver receives skb       |
    `> send tx interrupt to Dom0   |
                                   |  xenif respond tx interrupt
	                           |  Copy skb into mediate buffer
                                   |  Notify DomU (send tx irq)
  xennet driver handle tx irq      |
  free skb                         |

So we can see when DomU sends out packets, it needs to wait for Dom0 to
process the packets, until Dom0 notifies DomU that packet has been
processed the net forend driver in DomU releases skb.

This means it's a long way to process skbs: Xen DomU and Dom0 work
in synchronous mode, the forend driver in DomU sends out skb and
notifies Dom0, Dom0 handles skb and notifies back to DomU, finally DomU
knows the skb has been processed and releases it.  The duration between
sendind and releasing a skb is about 180+ us.

## Questions

Given Xen network driver has been merged in Linux kernel 2.6 (back in
2007), it's very unlikely I am the first person to observe this issue.

I think this is a common issue and not specific to Arm64 arch, the
reason is the long latency is mainly caused by Xen networking driver
and I did't see the Xen context switching on Arm64 is abnormal (I saw
it takes ~10us for context switching between Xen domains).

Could anyone confirm if this is a known issue?
 
The second question is how to mitigate the long latency when send data
from DomU.  A possible solution is the Xen network forend driver copies
skb into mediate (bounce) buffer, just like what does in Xen net
backend driver with gnttab_batch_copy(), in this way the forend driver
doesn't need to wait for backend driver response and directly return
back.  But here I am not clear for the mechanism for Xen grant table,
especially if the Xen grant table is only writtable from Dom0, then it
would be hard for us to optimize the forend driver in DomU by directly
copying skb into the grant table.  Any thoughts for this?

Welcome any suggestion and comments.  Thanks!

Leo


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 12:14:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 12:14:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419243.664031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohrgB-0000I7-1X; Mon, 10 Oct 2022 12:14:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419243.664031; Mon, 10 Oct 2022 12:14:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohrgA-0000Hz-Tw; Mon, 10 Oct 2022 12:14:42 +0000
Received: by outflank-mailman (input) for mailman id 419243;
 Mon, 10 Oct 2022 12:14:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrg9-0000Hd-2P; Mon, 10 Oct 2022 12:14:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrg8-00056l-WB; Mon, 10 Oct 2022 12:14:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrg8-0002sz-Fd; Mon, 10 Oct 2022 12:14:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohrg8-0006D1-FA; Mon, 10 Oct 2022 12:14:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VK4oRgQeWYXZ//srrn18TKQMxguXXnGZQDci2MTwml4=; b=SLlU2hSqxvXLUPKTNLkToATml6
	BI6tjRfs+EUC0MEsb5WQvlzdUVifS9CgeeGj5Q0bk4y5FANbzeZeQUNCbL8Val4OVN8T0Nj09yjK4
	XzQ/M7XrbQu5wvpiAKGmxBgpLlZisD5JkGXQWHeggvrn04QDslazkXobRKaWAthfhKiM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173485-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173485: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f80580f56b267c96f16f985dbf707b2f96947da4
X-Osstest-Versions-That:
    ovmf=8db4e9f9a0c2ec992e28259ceb7a8eb316716b05
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 12:14:40 +0000

flight 173485 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173485/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f80580f56b267c96f16f985dbf707b2f96947da4
baseline version:
 ovmf                 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05

Last test of basis   173484  2022-10-10 06:43:17 Z    0 days
Testing same since   173485  2022-10-10 10:41:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   8db4e9f9a0..f80580f56b  f80580f56b267c96f16f985dbf707b2f96947da4 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 14:58:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 14:58:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419280.664045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohuEX-000191-Cf; Mon, 10 Oct 2022 14:58:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419280.664045; Mon, 10 Oct 2022 14:58:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohuEX-00018u-9K; Mon, 10 Oct 2022 14:58:21 +0000
Received: by outflank-mailman (input) for mailman id 419280;
 Mon, 10 Oct 2022 14:58:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tNTn=2L=vmware.com=namit@srs-se1.protection.inumbo.net>)
 id 1ohuEV-00018o-VT
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 14:58:20 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-centralusazlp170130009.outbound.protection.outlook.com
 [2a01:111:f403:c111::9])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f81b3aa1-48ab-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 16:58:17 +0200 (CEST)
Received: from BY3PR05MB8531.namprd05.prod.outlook.com (2603:10b6:a03:3ce::6)
 by MN2PR05MB6269.namprd05.prod.outlook.com (2603:10b6:208:cd::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.7; Mon, 10 Oct
 2022 14:58:07 +0000
Received: from BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6]) by BY3PR05MB8531.namprd05.prod.outlook.com
 ([fe80::942c:7d1b:6b3d:85b6%7]) with mapi id 15.20.5723.013; Mon, 10 Oct 2022
 14:58:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f81b3aa1-48ab-11ed-964a-05401a9f4f97
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RYj8IVbHL5TeLctsE7SNniC4FhYikkGDfbW0Rh/bWGfKp+dVSpMubwdf74yA6joIBSfDPNAaeKHB41UwmZSVt5h0p3JLVNBFWA9J2I97sR4pFQaUvDEjhzbc0T7nah5yd/6d/rZrqSv1JzFnTZKcc0UJPkVfp9CecYEpPXLz8//pAsyx2JDS0av94+AARXsuufWD/Tzdqb2u3rgTduatjT6CUQEh7C1NH+BOaquia6E5zf6daF0sSoqnL3scA1FeUFNy4Pgq0X2Lsb0mrEdBQRMgwQVMqGSveSmSTPdIuIe61D9e+3ZeFC18Ql2cbUCJPIP7aOvhZzsf4WMBoiHB9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rYO8dCN0RAPjyyKUKeDabhUwzPIiWj1zLa9O3qPgnss=;
 b=hFmw2HbN2k2RgzviO6NuWIEeKI6tgcPwGAEySt3FAGZlD+HMdz/kFaUKQWX4IJX/UnUkMo8hOHpRNdJUHahnbNnS65znKX706RZgW4Ejv0sVsfywzk4sIWxjJS949KmjE2uSNI05dkL79m1o5BI5sOoTgSoV5+HfO1/v2abSXa2YFIvK2ah63AKfYThL5GQMYylFLk7AmvFx41nAlC+41DRl7QA/BUJK3kqcPKUEpaWsrmXdD2lPijeaLfNkINGBDUZblEnuw5avgI21qPcgvOirFb0kP5GfLkHLl+Ukq9o8lNc28GsiGX8QfrF6mMSqLYAS6tMk8iBVVPqHV0M9zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com;
 dkim=pass header.d=vmware.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rYO8dCN0RAPjyyKUKeDabhUwzPIiWj1zLa9O3qPgnss=;
 b=kKhFXmsgMoN4bD3ECeDgjXdJeFROVkSqpwQO96Y5dtj4F/794y7qnh+aDGwdcGfNOFn9s2KBukH+P7DQPbyuLkNSspikuxUfd37g+Ss0t+aFXcZ43bGiP1x9O/LzzeFYObQj16EmVxXL16NJRFHiNAv4GrISbJ5Ay7vyUCw3uWs=
From: Nadav Amit <namit@vmware.com>
To: Nadav Amit <namit@vmware.com>
CC: Alexander Graf <graf@amazon.com>, Vitaly Kuznetsov <vkuznets@redhat.com>,
	Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>,
	Srivatsa Bhat <srivatsab@vmware.com>, "srivatsa@csail.mit.edu"
	<srivatsa@csail.mit.edu>, Alexey Makhalov <amakhalov@vmware.com>, Vasavi
 Sirnapalli <vsirnapalli@vmware.com>, "er.ajay.kaher@gmail.com"
	<er.ajay.kaher@gmail.com>, "willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "jailhouse-dev@googlegroups.com"
	<jailhouse-dev@googlegroups.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Topic: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Thread-Index:
 AQHYx28G+J2WSwxm3kmFzqoOhSDYUK3dXFQAgBj77YCABouGgIAAKhGAgAD4GgCAAK7iAIAJLbYA
Date: Mon, 10 Oct 2022 14:58:07 +0000
Message-ID: <37B773B8-A918-45E8-9642-9F6112CDCBB6@vmware.com>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com> <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com> <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
 <f1a7e603-2e64-fd2a-1100-f2898060e3f7@amazon.com>
 <DF8775A4-5332-412C-9359-749E96E83907@vmware.com>
In-Reply-To: <DF8775A4-5332-412C-9359-749E96E83907@vmware.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=vmware.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BY3PR05MB8531:EE_|MN2PR05MB6269:EE_
x-ms-office365-filtering-correlation-id: 69df7bd8-e1bb-47a0-8da2-08daaacfd759
x-ld-processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 3ndTD+kWc7Des/PCBwoe6WcHAIvzmJxk31e4vq8i/2to+pJZkz6An7DBSzBE20ofdGn3MEHsGiyOG9tLA+rVv1oZt+GRNHXBSL3pafvfP+6zY7bxBmE+DxxRLBgd9/leF/ExseJuB8g+ZNm+xCEFHvTKg9pLavn45NAth6JngtYblEsNaME7JDmbzm6sZejjFAPIBoxtUxIghRj2CtySG0w6Srd+h6RB8X9NeSVeqTKofwFbGckOkchJkQWMj5vkAsDpbgWFdnhK2pWTtCdP4V4/TVmgIAiyK2VVkZp6Y3znqHsVvhAhKFrc2Bl2pES/0FzWyveObNE6YSGRUIrC6e/RJLmskGBWjy4LBmibPxmv/yXd3r1hAfUNGnQJBTIPYlqY/Q+J6lRWQbjGaijmfKRX0yHCf7w/ZJt2D4Y8EBS2S3px655MbNz87Yl7U3GfyDRl4vnVyH1qLaHL3pDaph3ZZEyaVT5ioo+a8HhbkgutP3qEb/0G2N50kpXkYMucSHOq7MNi9UXL8oouvaDHJh4IxhGIarIPR6+6lCVHpDqmMy12dHa1WD1IlyP5dCRKbh1XgBKLBofxay9KuP5Fxq29AMubo+mF0QIRKfts4BXj6OHJeg/txs+bcg0xLHcGiROGIsPPd3X6LLOy+ABq8jrsavHJ7QIv6kWJKiCrYLaQhbLHCOnNrqL94BsThR9zKBzJVaOQ7yZe8EBpvHRkpEkRu/p+2b4ZNUIzzqBzy9uuOjmZpSI8HfdinzFCwFj88YM/vmw6UTpP2arHmKjv55hE7S3gz939mIAdzdPvtBY=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY3PR05MB8531.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(4326008)(8676002)(76116006)(66556008)(7416002)(66446008)(66476007)(8936002)(38070700005)(6512007)(26005)(66946007)(83380400001)(6506007)(86362001)(64756008)(54906003)(5660300002)(33656002)(41300700001)(6486002)(2906002)(122000001)(36756003)(6862004)(6200100001)(37006003)(478600001)(38100700002)(71200400001)(316002)(53546011)(186003)(2616005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bTJoNWcycWlRRSs0UzFML0kzaENSTjFPWC8wSnNYR2F2amF6bEx3M1N1eDFU?=
 =?utf-8?B?aTZqWEFSTVAxT0N5ZEp6WWpyNVlZQllwbGt6YVpLcHZIdlZkMloyMTFmM0FO?=
 =?utf-8?B?bkZtT2t6SlBadlgrRDBzU3NoUnh0MkI2RWpmNFFpS0MvMXZGSjhzblZ5Tnp2?=
 =?utf-8?B?a3F2THhycEloeVhveHRqdVowWmFmSlp2a1VZTkdyZWxCTmUrQm5NUmlIdTVN?=
 =?utf-8?B?ZVZEdm01azVlMjJqb0VCUGNtRTB3bGx2UDJ2TjR3eU42enJxejlkWkF5U2ZI?=
 =?utf-8?B?Q2JRQU8wYmY0Nkh1dGNyT0RudGg3bStnU0xYTWIrTkVLVE00dXJSdmtUMnpG?=
 =?utf-8?B?dFdMTVBmN1pVUmhlbW5NNWV3OFd1UzR6N2FKdW41bXZhd1VPOXdBN21uYXRY?=
 =?utf-8?B?RytNbmNxbjB6SU0xWW1FNFhyLy9QK251MXNZZ0piMFNyamxkRHVzREVIUHRu?=
 =?utf-8?B?RlA5TkV6aFlNY3VwZFE0MXRqa0NlM2JiUDYvV2VDenY4VHNldG1JVTNGNGly?=
 =?utf-8?B?U2dVRTZiTDl6ZHExeTFOOUFIRTFtbFZ3RkswVG84YVZ5VXhGbktqL3dKV21N?=
 =?utf-8?B?L2pyVjhZYlFOYmNsVnJyZGJTMmRzLzdkOHJQbUNkUTBRR09rZHdJUm1DZ0Qz?=
 =?utf-8?B?cGh1ckx2b3pSK0V1M090bEI5R1lkVk5EeSsvNU93dnZBLzN4MjFKUWU4akJm?=
 =?utf-8?B?SHJlZlZQTEt6b0dLSmluUEZBRUNmdmRoK211ZkFpemQyY1pCMDVlR3dhcGlS?=
 =?utf-8?B?ZGh6M3pTUVlvczVmaFQyWmQ1eGZITjRkZWxJbnNrOFY3WkxnVkRmMmQ4cVAv?=
 =?utf-8?B?Wk4wWDBJQ1BYZ3NzVVZCT1FNU2RPbmgyQ2hCUkZzcVEyZlFNclFlSkNoYjVB?=
 =?utf-8?B?UVA4dEs1NHlDYWxQUkZNSDNIcU5DdFZ6bzBHRTBRb3JlZG02cnF0R2Q1N1pS?=
 =?utf-8?B?d0NSNEV5TURHNDNrWTFQVkg0N2puVWppVmNMcVFGRFU4djdrQVNYNTRuMU55?=
 =?utf-8?B?eWNRZjZ3NXlHalJBUndtd0Jnckk0VVhmOHgveEdmSXVxdUxVckFoYXpDcys3?=
 =?utf-8?B?T1J0Z05OSHRDako3MlhZRHNISFB1dTJ3UlQrN1RKS0VqajZ3OE9nSmpwZVNE?=
 =?utf-8?B?TEN3aVFScWxqakUrV1BIR1FCa3ByakExQ2owWk1nYzBTMWFBb2tpS1BQSEVN?=
 =?utf-8?B?YzZnd1VkV213QVdxcFJ6SGhoUWVjZHNqR2RVQ2hTNENmL3RKRGgyN3hGbm12?=
 =?utf-8?B?RFR4TjhleWpiSkRZd0Y3TENTWHl4SVNTamttSC9tVVIxdGFYZkNReDRldVVt?=
 =?utf-8?B?Wnh2WUtBd0hydmJKQ0I0WHd3NDdBd3hVQTBDMzg2RURlbTRON2twdGUvNEVu?=
 =?utf-8?B?TVZ6cjJPa0c1QlhIK3JTZnZKM0FrSVF2QlVkZHljdXppdytwNVJQc2ZldEd1?=
 =?utf-8?B?dU9Cemk3MlhoZnpPRm42ZWxOZlFLbFQra3hZRzN3aUNiZ1FVNEVuTjZldHNm?=
 =?utf-8?B?NlBtVFN6amY3alVtNkh1RFE0N0lZNGhUeEkxVVc3L2RqcTRKaFo4NXkyVzJj?=
 =?utf-8?B?K1pSL3UzcjJMa0hyUUw1eStrdko2WThZaExyUy9OckNrM0lWUTQ2bmpmNmlD?=
 =?utf-8?B?ZnRGZHNFMk54cnQ3ZG9Ma0I4SXllL3RodFdPMzh2d0VzVTEyMkFka3YxcnRw?=
 =?utf-8?B?ODdFU3RYM0MxZkxJeWJwSGp0bzZJM29YL2p6WjU2NVQzYTFjMCtCejd5RjFX?=
 =?utf-8?B?aXI0SktsQWVPYTQzVWFYc0VhbERxaUE0ZGxuSUR3OGFoRE4xVUVLTy8wTUhV?=
 =?utf-8?B?OHV5cytod3VBN2JVREd6QlZsZUFYRWxydHA3alh5dEYyMFhnR2t1YzVUVDQ0?=
 =?utf-8?B?bW1rajdrRnc5RTNJR3pYZjhVUGw2aC93OGJXSlBYb2JSREM5Rkg4dnh2eXZp?=
 =?utf-8?B?SWZKazF2VlNhaHQzY3VDemRkMXkwQWJGcDNVY2ZScTNJc1RmNHJ1cEdXRjIz?=
 =?utf-8?B?MCtMN0F0VzlOSlBMeU1RV2cxbTljNndiWEF1cmtFQUZEQlJOYjA3RUYwQkVD?=
 =?utf-8?B?aU1mbGYrN1hQcXE0QVNXTTNxTDlVV3VSVGQ2ZnlkdmJIOGtzd2oxeUw1SWV4?=
 =?utf-8?Q?quyg3M4cBRrnLa5sMOx3o+wqU?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E9C3B43181985F4F97F91A814A79A6C1@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69df7bd8-e1bb-47a0-8da2-08daaacfd759
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 14:58:07.3956
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xGHU5bIcBDSFl8n5qpOcg5QjgLSkBqoIyZVxUwqwYTGbkWdZeTV3Ie/t33RGlF1rfww1qFYruaX4UR5W2+SFBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR05MB6269

T24gT2N0IDQsIDIwMjIsIGF0IDExOjQ4IEFNLCBOYWRhdiBBbWl0IDxuYW1pdEB2bXdhcmUuY29t
PiB3cm90ZToNCg0KPiBPbiBPY3QgNCwgMjAyMiwgYXQgMToyMiBBTSwgQWxleGFuZGVyIEdyYWYg
PGdyYWZAYW1hem9uLmNvbT4gd3JvdGU6DQo+IA0KPj4g4pqgIEV4dGVybmFsIEVtYWlsDQo+PiAN
Cj4+IEhleSBOYWRhdiwNCj4+IA0KPj4gT24gMDMuMTAuMjIgMTk6MzQsIE5hZGF2IEFtaXQgd3Jv
dGU6DQo+Pj4gT24gT2N0IDMsIDIwMjIsIGF0IDg6MDMgQU0sIFZpdGFseSBLdXpuZXRzb3YgPHZr
dXpuZXRzQHJlZGhhdC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+PiBOb3QgbXkgYnV0IHJhdGhlciBQ
Q0kgbWFpbnRhaW5lcidzIGNhbGwgYnV0IElNSE8gZHJvcHBpbmcgJ2NvbnN0JyBpcw0KPj4+PiBi
ZXR0ZXIsIGludHJvZHVjaW5nIGEgbmV3IGdsb2JhbCB2YXIgaXMgb3VyICdsYXN0IHJlc29ydCcg
YW5kIHNob3VsZCBiZQ0KPj4+PiBhdm9pZGVkIHdoZW5ldmVyIHBvc3NpYmxlLiBBbHRlcm5hdGl2
ZWx5LCB5b3UgY2FuIGFkZCBhDQo+Pj4+IHJhd19wY2lfZXh0X29wc19wcmVmZXJyZWQoKSBmdW5j
dGlvbiBjaGVja2luZyBzb21ldGhpbiB3aXRoaW4gJ3N0cnVjdA0KPj4+PiBoeXBlcnZpc29yX3g4
NicgYnV0IEknbSB1bnN1cmUgaWYgaXQncyBiZXR0ZXIuDQo+Pj4+IA0KPj4+PiBBbHNvLCBwbGVh
c2UgY2hlY2sgQWxleCcgcXVlc3Rpb24vc3VnZ2VzdGlvbi4NCj4+PiBIZXJlIGlzIG15IHRha2Ug
KGFuZCBBamF5IGtub3dzIHByb2JhYmx5IG1vcmUgdGhhbiBtZSk6DQo+Pj4gDQo+Pj4gTG9va2lu
ZyBicmllZmx5IG9uIE1DRkcsIEkgZG8gbm90IHNlZSBhIGNsZWFuIHdheSBvZiB1c2luZyB0aGUg
QUNQSSB0YWJsZS4NCj4+PiBUaGUgdHdvIG9wdGlvbnMgYXJlIGVpdGhlciB0byB1c2UgYSByZXNl
cnZlZCBmaWVsZCAod2hpY2ggd2hvIGtub3dzLCBtaWdodA0KPj4+IGJlIHVzZWQgb25lIGRheSkg
b3Igc29tZSBPRU0gSUQuIEkgYW0gYWxzbyBub3QgZmFtaWxpYXIgd2l0aA0KPj4+IFBDSV9DT01N
QU5ELk1FTU9SWT0wLCBzbyBBamF5IGNhbiBob3BlZnVsbHkgZ2l2ZSBzb21lIGFuc3dlciBhYm91
dCB0aGF0Lg0KPj4+IA0KPj4+IEFueWhvdywgSSB1bmRlcnN0YW5kIChhbHRob3VnaCBub3QgcmVs
YXRlKSB0byB0aGUgb2JqZWN0aW9uIGZvciBhIG5ldyBnbG9iYWwNCj4+PiB2YXJpYWJsZS4gSG93
IGFib3V0IGV4cGxpY2l0bHkgY2FsbGluZyB0aGlzIGhhcmR3YXJlIGJ1ZyBhIOKAnGJ1Z+KAnSBh
bmQgdXNpbmcNCj4+PiB0aGUgcHJvcGVyIGluZnJhc3RydWN0dXJlPyBDYWxsaW5nIGl0IGV4cGxp
Y2l0bHkgYSBidWcgbWF5IGV2ZW4gcHVzaCB3aG9ldmVyDQo+Pj4gY2FuIHRvIHJlc29sdmUgaXQu
DQo+PiANCj4+IA0KPj4gSSBhbSBhIGxvdCBtb3JlIGNvbmNlcm5lZCB3aXRoIGhvdyB3ZSBwcm9w
YWdhdGUgaXQgZXh0ZXJuYWxseSB0aGFuDQo+PiB3aXRoaW4gTGludXguIElmIHdlIGhhcmQgY29k
ZSB0aGF0IGFsbCBMaW51eCBrZXJuZWxzIDYuMisgdGhhdCBhcmUNCj4+IHJ1bm5pbmcgaW4gVk13
YXJlIHByZWZlciBFQ0FNIG92ZXIgUElPLCB3ZSBsb2NrIG91cnNlbHZlcyBpbnRvIHRoYXQNCj4+
IHN0YW5jZSBmb3IgYmV0dGVyIG9yIHdvcnNlLCB3aGljaCBtZWFuczoNCj4+IA0KPj4gKiBBbGwg
cGFzdCBhbmQgZnV0dXJlIHZlcnNpb25zIG9mIGFueSBWTXdhcmUgaHlwZXJ2aXNvciBwcm9kdWN0
IGhhdmUgdG8NCj4+IGFsd2F5cyBhbGxvdyBFQ0FNIGFjY2VzcyBmb3IgYW55IFBDSWUgY29uZmln
IHNwYWNlIHdyaXRlDQo+PiAqIE5vIG90aGVyIGh5cGVydmlzb3IgYmVuZWZpdHMgZnJvbSBhbnkg
b2YgdGhpcyB3aXRob3V0IHVwc3RyZWFtIGNvZGUgY2hhbmdlDQo+PiAqIE5vIHJlYWwgaGFyZHdh
cmUgcGxhdGZvcm0gYmVuZWZpdHMgZnJvbSB0aGlzIHdpdGhvdXQgdXBzdHJlYW0gY29kZSBjaGFu
Z2UNCj4+IA0KPj4gQnkgbW92aW5nIGl0IGludG8gTUNGRywgd2UgY2FuIGNyZWF0ZSBhIHBhdGgg
Zm9yIHRoZSBvdXRzaWRlIGVudmlyb25tZW50DQo+PiB0byB0ZWxsIHRoZSBPUyB3aGV0aGVyIGl0
J3Mgc2FmZSB0byB1c2UgRUNBTSBhbHdheXMuIFRoaXMgb2J2aW91c2x5DQo+PiBkb2Vzbid0IHdv
cmsgd2l0aCBNQ0ZHIGFzIGl0IHN0YW5kcyB0b2RheSwgd2UnZCBoYXZlIHRvIHByb3Bvc2UgYW4g
TUNGRw0KPj4gc3BlYyBjaGFuZ2UgdG8gdGhlIFBDSSBTSUcncyAiUENJIEZpcm13YXJlIFNwZWNp
ZmljYXRpb24iIHRvIGFkZCB0aGUNCj4+IHJlc3BlY3RpdmUgZmllbGQuIEZ1dHVyZSBWTXdhcmUg
dmVyc2lvbnMgY291bGQgdGhlbiBhbHdheXMgZXhwb3NlIHRoZQ0KPj4gZmxhZyAtIGFuZCBpZiB5
b3UgZmluZCBpdCBicm9rZW4sIHJlbW92ZSBpdCBhZ2Fpbi4NCj4+IA0KPj4gUHV0dGluZyBhbGwg
b2YgdGhlIGxvZ2ljIG9uIHdoaWNoIHN5c3RlbSBwb3RlbnRpYWxseSBwcmVmZXJzIEVDQU0gb3Zl
cg0KPj4gUElPIGNvbmZpZyBzcGFjZSBhY2Nlc3MgaW50byBMaW51eCBpcyBqdXN0IGEgYmlnIGhh
Y2sgdGhhdCB3ZSBzaG91bGQNCj4+IGF2b2lkIGFzIG11Y2ggYXMgcG9zc2libGUuDQo+IA0KPiBU
aGFua3MgQWxleC4gWW91IHJhaXNlIGltcG9ydGFudCBwb2ludHMuIExldCBtZSB0cnkgdG8gYnJl
YWsgZG93biB5b3VyDQo+IGNvbmNlcm5zIHNsaWdodGx5IGRpZmZlcmVudGx5Og0KPiANCj4gMS4g
RW5hYmxpbmcgTU1JTyBhY2Nlc3Mgc2hvdWxkIGJlIHNlbGVjdGl2ZSwgYW5kIHBvdGVudGlhbGx5
IGNvbnRyb2xsZWQgYnkNCj4gdGhlIGh5cGVydmlzb3IuIFRoZSB2ZXJ5IGxlYXN0IGEgImNoaWNr
ZW4tYml04oCdIGlzIG5lZWRlZC4NCj4gDQo+IDIuIFBDSSBTSUcgd291bGQgY2hhbmdlIGl0cyBz
cGVjaWZpY2F0aW9ucyB0byBhZGRyZXNzIHVuY2xlYXIgaGFyZHdhcmUgYnVnLg0KPiANCj4gSSB0
aGluayAoMSkgbWFrZXMgc2Vuc2UgYW5kIHdlIGNhbiBkaXNjdXNzIGRpZmZlcmVudCB3YXlzIG9m
IGFkZHJlc3NpbmcgaXQuDQo+IEJ1dCAoMikgd291bGQgbm90IGhhcHBlbiBpbiBhIHJlYXNvbmFi
bGUgdGltZWxpbmUgYW5kIHNlZW1zIHRvIG1lIGFzIGFuDQo+IHVubmVjZXNzYXJ5IGNvbXBsaWNh
dGlvbi4NCj4gDQo+IEJ1dCBiZWZvcmUgd2UgZGlzY3VzcyBob3cgdG8gYWRkcmVzcyB0aGUgaXNz
dWUsIHBlcmhhcHMgd2UgbmVlZCB0byBmaXJzdA0KPiB1bmRlcnN0YW5kIGl0IGJldHRlci4gSSBh
bSBub3Qgc3VyZSB0aGF0IEkgdW5kZXJzdGFuZCB0aGlzIE1NSU8gYnVnLCBhbmQgc28NCj4gZmFy
IG5vYm9keSB3YXMgYWJsZSB0byBwcm92aWRlIGV4YWN0IGRldGFpbHMuDQo+IA0KPiBTbyBJIHdl
bnQgdG8gaGF2ZSBhIGxvb2suIEl0IG1pZ2h0IG5vdCBiZSBzdXBlciBoZWxwZnVsLCBidXQgZm9y
IHRoZSByZWNvcmQsDQo+IGhlcmUgaXMgd2hhdCBJIGNvbGxlY3RlZC4NCj4gDQo+IEZpcnN0LCB3
ZSBoYXZlIGNvbW1pdCBkNmVjZTU0OTFhZTcxZCAoImkzODYveDg2LTY0IENvcnJlY3QgZm9yIGJy
b2tlbiBNQ0ZHDQo+IHRhYmxlcyBvbiBLOCBzeXN0ZW1z4oCdKS4gSXQgdHJpZWQgdG8gInRyeSB0
byBkaXNjb3ZlciBhbGwgZGV2aWNlcyBvbiBidXMgMA0KPiB0aGF0IGFyZSB1bnJlYWNoYWJsZSB1
c2luZyBNTSBhbmQgZmFsbGJhY2sgZm9yIHRoZW0u4oCdIEludGVyZXN0aW5nbHksIGl0DQo+IHNl
ZW1zIHNpbWlsYXIgdG8gRnJlZUJTRCBjb2RlIChjb21taXQgMmQxMDU3MGFmZTJiM2UpIHRoYXQg
YWxzbyBtZW50aW9ucyBLOA0KPiBhbmQgaGFzIHNpbWlsYXIgZGV0ZWN0aW9uIGxvZ2ljIGluIEZy
ZWVCU0TigJlzIHBjaWVfY2ZncmVnb3BlbigpLg0KPiANCj4gVGhlbiBjb21taXQgYTBjYTk5MDk2
MDk0NzAgKCJQQ0kgeDg2OiBhbHdheXMgdXNlIGNvbmYxIHRvIGFjY2VzcyBjb25maWcNCj4gc3Bh
Y2UgYmVsb3cgMjU2IGJ5dGVz4oCdKS4gVGhlIGNvcnJlc3BvbmRlbmNlIFsxXSBtZW50aW9ucyBz
b21lIGJ1Z3M6IEFUSQ0KPiBjaGlwc2V0LCBWSUEgY2hpcHNldCwgSW50ZWwgMyBTZXJpZXMgRXhw
cmVzcyBjaGlwc2V0IGZhbWlseSBhbmQgc29tZSByZXBvcnRzDQo+IG9uIE52aWRpYS4gSXQgdHVy
bmVkIG91dCBzb21lIGRldmljZXMgaGFkIHByb2JsZW0gcHJvYmluZyAtIHRvIGZpZ3VyZSBvdXQg
aWYNCj4gTU1JTyBpcyBicm9rZW4gLSB0aGUgd2F5IHRoZSBwcmV2aW91cyBwYXRjaCBkaWQuDQo+
IA0KPiBBbGwgb2YgdGhlc2UgYnVncyBhcmUgY2lyY2EgMjAwOCwgb2YgY291cnNlLiBBbmQgbm90
ZSB0aGF0IEZyZWVCU0QgZGlkIG5vdA0KPiB0YWtlIGEgc2ltaWxhciBwYXRoLiBUaGUgY29ycmVz
cG9uZGVuY2UgYXJvdW5kIExpbnV4IHBhdGNoIGlzIGVuZGxlc3MuIEkNCj4gYWRtaXQgdGhhdCBJ
IGRpZCBub3QgdW5kZXJzdGFuZCB3aGV0aGVyIGV2ZW50dWFsbHkgdGhlIGlzc3VlcyB3ZXJlIGZv
dW5kIHRvDQo+IGJlIHBlci1idXMgb3IgcGVyLWRldmljZS4NCj4gDQo+IA0KPiBCYWNrIHRvIHRo
ZSBtYXR0ZXIgYXQgaGFuZC4gVGhlIGJlbmVmaXQgb2YgdXNpbmcgdGhlIE1DRkcgYXBwcm9hY2gg
dGhhdCB5b3UNCj4gcHJvcG9zZSBpcyB0aGF0IGl0IGNhbiBlbmFibGUgbmF0aXZlIHN5c3RlbXMg
dG8gdXNlIE1NSU8gYXMgd2VsbC4gSG93ZXZlciwNCj4gc2luY2UgdGhlIGxpc3Qgb2YgYnVncyBp
cyB1bmNsZWFyIGFuZCB0aGUgcHJvYmxlbXMgbWlnaHQgYmUgZGV2aWNlLXNwZWNpZmljLA0KPiBp
dCBpcyBub3QgY2xlYXIgd2hhdCBpbmZvcm1hdGlvbiBCSU9TZXMgaGF2ZSB0aGF0IExpbnV4IGRv
ZXNu4oCZdC4gSW4gb3RoZXINCj4gd29yZHMsIHRoZSBiZW5lZml0IG9mIGdldHRpbmcgaXQgaW50
byB0aGUgc3BlY2lmaWNhdGlvbnMgaXMgcXVlc3Rpb25hYmxlLA0KPiBhbmQgdGhlIGNvbXBsZXhp
dHkrdGltZSBpcyBoaWdoLg0KPiANCj4gQ2FuIHdlIGFncmVlIHRoYXQgdGhlIGZlYXR1cmUgd291
bGQgYmUgZW5hYmxlZCBleHBsaWNpdGx5IGJ5IHRoZSBoeXBlcnZpc29yDQo+IGFuZCBMaW51eCB3
b3VsZCBlbmFibGUgaXQgYmFzZWQgb24gdGhlIGh5cGVydmlzb3IgaW5wdXQgKHRocm91Z2ggc29t
ZQ0KPiBjaGFubmVsPykNCg0KQWxleCwgaXMgaXQgb2sgd2l0aCB5b3U/IFdlIHdpbGwgZW5hYmxl
IHRoZSBmZWF0dXJlIChkaXNhYmxlIHRoZSBidWcpDQpleHBsaWNpdGx5IGZyb20gdGhlIGh5cGVy
dmlzb3IsIGJ1dCB3b3VsZCBub3QgcmVseSBvbiBNQ0ZHIGNoYW5nZXMsIHdoaWNoDQp3b3VsZCBl
dmVuIGluIHRoZSBiZXN0IGNhc2Ugd291bGQgdGFrZSBzb21lIHRpbWUu


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 16:45:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 16:45:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419293.664056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohvta-00050D-4W; Mon, 10 Oct 2022 16:44:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419293.664056; Mon, 10 Oct 2022 16:44:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohvta-000506-1t; Mon, 10 Oct 2022 16:44:50 +0000
Received: by outflank-mailman (input) for mailman id 419293;
 Mon, 10 Oct 2022 16:44:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ILM/=2L=citrix.com=prvs=2752edee2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ohvtY-000500-Pr
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 16:44:49 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6f547af-48ba-11ed-9377-c1cf23e5d27e;
 Mon, 10 Oct 2022 18:44:45 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 10 Oct 2022 12:44:32 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by PH0PR03MB5927.namprd03.prod.outlook.com (2603:10b6:510:41::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 16:44:29 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022
 16:44:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6f547af-48ba-11ed-9377-c1cf23e5d27e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665420285;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=mBqbcUYOc9zM9Qw0osksRarxI3Qusap2bfCtB6fbxlU=;
  b=eu+gEZUFgwzHTJI0WSAnnl8T7ZiMlrXtdaKpSOzBCKDvTljIT3VHyMJN
   1VfwAKdlUl9IrO0RPQ/fHiIq0kqchqlhizinb2kzOdjb4CnNbhH9FHuOi
   L0C/5muo9/8Xd6apKMdqoTN+oIzfRO0kVWR7VXzfC32Fj1CYrojnbMQVa
   A=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 81511096
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:1oBkkKOs7DAkDhbvrR2DlsFynXyQoLVcMsEvi/4bfWQNrUpz3zcOx
 jEaXmyFbK6OMTCjLtEgao/ioUoAuZCHmoMwHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr4GtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4ePqgUpd5uGTFy2
 fUeMwxcMQ+ZoN2f3+fuIgVsrpxLwMjDGqo64ygl5xeJSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF+BTM+/tfD2v7lWSd1JDENtbPd8PMbsJShkuC/
 UrN/njjAwFcP9uaodaA2iL127aWxXKlMG4UPLuq0Pp3pmes/108NCccZFGQiqS6hFHrDrqzL
 GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvBGjhHoLCTD3WH+d+pQSiaPCEUKSoIY38CRA5cut37+tht31TIU8ppF7OzgpvtAzbsz
 juWrS84wbIOkcoM0Kb99lfC696xmqX0oscOzl2/dgqYAslRPeZJu6TABYDn0Mt9
IronPort-HdrOrdr: A9a23:fgrLj6D5Cg8hPO3lHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U
 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca
 Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z
 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+
 djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+
 DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ
 zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw
 ==
X-IronPort-AV: E=Sophos;i="5.95,173,1661832000"; 
   d="scan'208";a="81511096"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CAkajMTzyOlGP0xqfqzPHowtvjqfgST8S1GC8R/1IK6+NKXHmV5JJd5uWzbZ+/D51c0YwRw05+JgDBh8YazXesm87cc6f/8hQigDQA0lVed4WN/mHEYHZbs9o39KCK4yLEJ9ilnmvHkwAb1m37ef2k2qCDWlKjlyzzkuMQc9szHKrgilaisXf2D8chhC+H45uwSm2EhhAcfDnqfUawT11DwaoGhjj5ty5TUw2DaN9DGJzCcByzTsVGVINVGb1/4eXoDsRQgFsuXDQ1zMJvgAu28JF0VhijofMF/HiOhBFFhsbU9PpeZgdl1eQspsdCthekFfPYQ5I9rAGx7PNvU+wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mBqbcUYOc9zM9Qw0osksRarxI3Qusap2bfCtB6fbxlU=;
 b=TZC9MLHbzGAGyeXFw6CU9uOcu8yfMqwDGkRmi8YWcTTGz0bftEQefUXIlxQfsgV0TGREdY/wKZ556qHuU/JePzekeOGiZQXQ7DnN9Oimg0a13C5oIlKF+GBzx5kh0EkCjImBGRmpi/JYPMDxUTTdtCmw0iOHjDIcF95381XERpdISezwErzXnMtw4rc1yja3254gqq7e6Nk/m3LkPJ6LuEmapd73WAl169n6518TufOqlp5d4p9G6wgyGWRN5IXpKEF2bOMuthGRDiUQbj+JiY8OJ+ysY8AWrnmgcF9CCVbZgqWH3xNJC1ZZkVvBfV6s0u2iKE1c2HYaHHVQZypA1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mBqbcUYOc9zM9Qw0osksRarxI3Qusap2bfCtB6fbxlU=;
 b=xe7qzL9x31YgueuZG9T5zVpdTX5vu68xm3AF/Ez0bWlB2BwuG6pEf6HJMJCzoYgyWymn0Btyd8FDR2h+EB0tc57CwnrrnMGNIOSqQKiCEY4zekHm9rdWy7l0/MI3/o6/cbRjAY+WR/14XhFJQ3HsSMhNH9vh9Z1Xwmsx+jerJ84=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86emul: respect NSCB
Thread-Topic: [PATCH] x86emul: respect NSCB
Thread-Index: AQHYyNP7HPEYuhoQC0yvtYIRC5F8064H/XmA
Date: Mon, 10 Oct 2022 16:44:29 +0000
Message-ID: <f5851974-86ab-8da7-3b5f-4196faae7969@citrix.com>
References: <b0103a30-22b7-c010-3e8b-6eab1c25ee47@suse.com>
In-Reply-To: <b0103a30-22b7-c010-3e8b-6eab1c25ee47@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5927:EE_
x-ms-office365-filtering-correlation-id: b54173e1-43d4-4e83-553a-08daaadeb37b
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 atlB1CyMfyYPsEHYMTbynaW5/UdlIcY7Oh+Ap69yVa+djp0UFFJn4DmiSPUKoXSvnz922jGHemuwQD2ARL/x502i0n6UD4wHctZhHYy7L0R/hz5DXcc6KhUzjoESezM/m6uAlB+oXvRsaBnUw9NmYLDv2APfxBGzuAuDYEJSk5lolz40h42/cR9a5eWmkuEGjW9HPjCWd3VPyOzE+m0VhjC7S7asoQ2Y+WYpiVYrWfzRLgpXKJE9ZLAdobQ8TTG1luXyWjLjYhFo9pV8LOurfr+bHkS/7ye8L1312mysX6IULsT8WR1Q+HQdqkKuGYOtTBrdZqWmZbx8KwQCpUAYjSW2mOrGHNrHUedW3oZpGmHk5//+BmfhKFHralE4qXY4HJmY6n0h74iZzUfPQ3gQv0G+wI97gX3S7J1MXhM/5e+0dsXBKqTAGS6/Kb14LVFjdYyUGO6OUU8Cmli+tJB4CsVw08rSSZ1EnqpyV9RZ5qXOER5+4cx4FiDTbyEVPW8DzqMsybGd4bzVNrJVpnbX57+Qmj6+aXxDrsIfaQ+X+y/MZmp5DH7HQURtoU8M2ImAf3DxmyRipKIT9EPrNavCfXS4oyIZMtrc5dQ1UIcNqxJIlUKYXivU4CVrmebfdvj+R+THPxBJ/coPLFBZ/vVOHoCB1EGfD4c92SqFbCXP7FUuwAJIkVfqZzomEmLAAqTpv8TLHoLVJYHxMIB4Ue0ipg296PsOMOqzv5V/q5ufnz5J9MlnMLv+VZCnbfr/PmPrKO6bu7kDikhUY4ry+5mWzKDGGu7QqxZm0EBVZZetRe96Px7j2bkSRLMKbBmZNPXKjGmV1r1R+q7u66sw3uQgNQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(136003)(366004)(396003)(451199015)(8676002)(5660300002)(54906003)(6486002)(71200400001)(107886003)(86362001)(478600001)(41300700001)(36756003)(110136005)(4326008)(64756008)(31696002)(316002)(66946007)(66556008)(76116006)(66446008)(558084003)(66476007)(2616005)(122000001)(38070700005)(82960400001)(8936002)(38100700002)(186003)(26005)(83380400001)(53546011)(91956017)(6506007)(6512007)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?T1BlY0tkZ3NpRDVJUnJDdVc2ZEhiVXdETlU4QVYxejFxT2dBWm5YWnBMaUQ0?=
 =?utf-8?B?Q01kSHpadjAyZDgwRk8wSWpkdG4rVEpPSFl4SjI4WStOb2xFbjByLzBLaURx?=
 =?utf-8?B?RUR2c1dCV3o3RXMrUFNKVmtvaVVnNEtsTFlkdlIrUEsvMVRSdSsrelJUNXIr?=
 =?utf-8?B?WFJMWGJaYVFSWFFOYml2R1lHVG5wNnd3OUs3c1Q4YVhGZkFQNnVwY3dhcm8z?=
 =?utf-8?B?ZTlrY2VodHdabGptcms1TEU5MmIvY1lWVVJnWld1NnluOXFQRGJsZlp5akdE?=
 =?utf-8?B?V2xLTkhtRmVPQXh6d251U1BoSGI1aU1zVWQ2MFpaVlQ0a0QxdVUwdlNla2xB?=
 =?utf-8?B?QVd4Q2RUL296ZEJGaWIwUHBNUDh2dXR3Q3M5c3BQTUNmOGJTMW1uMFI3TVZJ?=
 =?utf-8?B?MkNjRmxyMHlxOWd0Z0pyNjQ4Sk5RWTRNUlBIR0ZlemhldmpkYnp0SUlPQ25k?=
 =?utf-8?B?UDNBVGtpUHJkdUpWNXdRVkNiQVA3aEJvWFBzOVArL1VNLzZWUG5CUHEyeWFw?=
 =?utf-8?B?UVFqaXl0bkNCajlXcCt6alN2MWoxNUpYdmNiYXE4RzdlYlZ3MW9CeTdpNFVo?=
 =?utf-8?B?WktRL0hqWll6b3Yzbm16NU4yT3pGN2RsMmtwUVFvYnExL3VOdkNzSXh2OVNY?=
 =?utf-8?B?ODlNT3JJNUtrTVRsalQvalhTc3pnK3pZY1d6VEhyVWp3OHRwRHdCcis0aHpZ?=
 =?utf-8?B?ZFVHTkJIR05ZU1EwTWx5NklvWFY2OVIzbmhpRDZLa2ZBcGk1MkxzMnlJZGRL?=
 =?utf-8?B?K0VtR1VQdXVrRldVdjhyOW9IRzFtWFNnQzloK1BPV1FRVTl3Yzg0MDNwMEFo?=
 =?utf-8?B?Tm4yaTJycGtpN1ZFVW9NRnUzeWppcWEzZ2kwcUUwd0ZjTmdXdlZSVTh3RWlx?=
 =?utf-8?B?UVk4WUU1cW9MQ1k3K0pQUGlTM0hPWE9LMmpsZ05lcm92MDQxVEhRUkxPRkVY?=
 =?utf-8?B?RXBKZ05XZzIzYWVtNDZSUXBlVEcrUldqbGhGbis0enI5ZDU5NCtQSEdOQTFs?=
 =?utf-8?B?cC9yMjRxeEJ4QmJ4MklEb2FkZ3d6NForcW1ncGJHTE1vOE92UHBsb2Joemxm?=
 =?utf-8?B?bzdVdGd2a3ZsTzRWWFZsM2xFRlZDWVA1UXhSSis0bS9mTTNzdmdJU2FWZHlN?=
 =?utf-8?B?VTViOWp2SUd5K0ZhLzlaQStXMGduMllKUVN6U0twcDI4Sm50Z2JkdGtKK1pW?=
 =?utf-8?B?bGZwa1RqT0NONTNqWnhQRWRya1JVMkhTbzcxeHYyYllYOGlCRE9BZE11RE5P?=
 =?utf-8?B?VWhUWXBEUlgzNlpCbzd3b2syeXlrZEtjRC96d2thbDNZWHpTaC8rWTlYeHFk?=
 =?utf-8?B?eWY3K24zb3NSancwRmxtYk5ENHJHSVJsdkcyOVRRZHJsSlY4NTJZSnJTYWMz?=
 =?utf-8?B?YVlRcTVPdVU0RXFMb1R1d0tCRnZvYjhYN2NES0NqRVgwQVFodHpZTW8yQTRs?=
 =?utf-8?B?STI2eDFsYjZxZ1JhZVVSMGVKZ1lCd2FORlJBYnFUdU1taW5LdTJ5eG9VeE5w?=
 =?utf-8?B?c3NGOEFIZlhzaTFYTkRhTkI4d2l4K21ibjlPdU9GaGVTTitKY1dDZCtJYmRl?=
 =?utf-8?B?UTRxbzExbE42VlczL1pjQ0tsOVcrdkhDcnJJdlZIUjNFZmdqNmgzZXhNSjZN?=
 =?utf-8?B?OFNGWXpGanh5dkRUajFPcERhVGh2QW5aNEpPYXl5Q3FrVUQvbVEreGRTaXQ2?=
 =?utf-8?B?STJ0YmpmK0lxSDVGMTQ2TFAwbUxrRUZ0YW5Ed2YxTzhyU3YyNlRHVkJULzFi?=
 =?utf-8?B?T1lEQ1p6Ti9vVDdBN3hwVWhuTGlZL3gyMHhKWlhyOG9ZcjNJUXc3Q0NvS2gy?=
 =?utf-8?B?R3JNRGpFZjhOTnlTbkpGUXM3OXQ1cE9vS3FZRXlVWUdMeGorRHhESlEvNUFY?=
 =?utf-8?B?N3puN1U1Wkt0bnBZQktIMDFyZ0hwT1FGejhwaXpaN0ExNDllbkZuSjhIcTBP?=
 =?utf-8?B?SWU1R2xJTVNXaTJUeXJFbDF2QjhJcEc3cmJxRTRSSEtCb01TOHVnRDhQOHlt?=
 =?utf-8?B?WEUrNVlzenhQaFNqV0hFbmN3UExpd0JDQWw2bEh6b0RXNVZOcHVkTEZGb2Yv?=
 =?utf-8?B?UWt2TFREakppUVRQUzhCQmQrSGJHSk9yNWtrbHpaRjM2czYzcndzYlptRU13?=
 =?utf-8?Q?hNFQf0vgxDNkw3O1DmO24fz8w?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2378EFE801FCCA4AAE02D6A15F075545@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b54173e1-43d4-4e83-553a-08daaadeb37b
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 16:44:29.6700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vXzLgYeFoEOMU0OziNuExd6gP8rRSgNwwOcejGgMr4wsKUGx0uWOgL0CAm1NAnyuvlO2HunBYcVZdQ0AOK/Sr+ETUgSo5180PJXniDogMXg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5927

T24gMTUvMDkvMjAyMiAwODoyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IHByb3Rtb2RlX2xvYWRf
c2VnKCkgd291bGQgYmV0dGVyIGFkaGVyZSB0byB0aGF0ICJmZWF0dXJlIiBvZiBjbGVhcmluZw0K
PiBiYXNlIChhbmQgbGltaXQpIGR1cmluZyBOVUxMIHNlbGVjdG9yIGxvYWRzLg0KPg0KPiBTaWdu
ZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5
OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 17:05:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 17:05:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419300.664067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohwDm-0007md-SC; Mon, 10 Oct 2022 17:05:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419300.664067; Mon, 10 Oct 2022 17:05:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohwDm-0007mW-PS; Mon, 10 Oct 2022 17:05:42 +0000
Received: by outflank-mailman (input) for mailman id 419300;
 Mon, 10 Oct 2022 17:05:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qYuc=2L=redhat.com=mst@srs-se1.protection.inumbo.net>)
 id 1ohwDl-0007mQ-HB
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 17:05:41 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c3ca9a08-48bd-11ed-964a-05401a9f4f97;
 Mon, 10 Oct 2022 19:05:39 +0200 (CEST)
Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com
 [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-332-6iR5IGC2MRa5nE9NriFQpQ-1; Mon, 10 Oct 2022 13:05:37 -0400
Received: by mail-wm1-f69.google.com with SMTP id
 az35-20020a05600c602300b003c5273b79fdso3636660wmb.3
 for <xen-devel@lists.xenproject.org>; Mon, 10 Oct 2022 10:05:37 -0700 (PDT)
Received: from redhat.com ([2.55.183.131]) by smtp.gmail.com with ESMTPSA id
 l19-20020a05600c089300b003c5571c27a1sm7263313wmp.32.2022.10.10.10.05.27
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 10 Oct 2022 10:05:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3ca9a08-48bd-11ed-964a-05401a9f4f97
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1665421538;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PIyB/HY40+8TeBToBpv65MXDYl/DWNxmK/k3JvGCIiE=;
	b=PiMNZMXYIjwHTRSp9CrTHy6SAKZJUVjFHCIsBtjmq00NKlxFrwm75xbUyRWrpcXTgP4e84
	oI72jmcQugS57KJQiPqy6k9hGtxKc4f2TVZIcI7QhTIxa7jt1410wMqVm4sRR8TuGeWH24
	vEaCEu+pxxZq7N7opy5bDhh6I1eXRSI=
X-MC-Unique: 6iR5IGC2MRa5nE9NriFQpQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-transfer-encoding:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=PIyB/HY40+8TeBToBpv65MXDYl/DWNxmK/k3JvGCIiE=;
        b=KcF28Lg0HgQcCdrOPOkJu+vCv63ZAOoxnLoagqnUDQfH29ldn/aipvuFyjmbjpO9Ek
         MZjcWNBPKgF25fR91wZnBtnmU2U/PqdIRuSeONW+zsv1VeVxOhErHX9htyXikTiysSe2
         VywgRfbfHj1eSfg25cwpg4lJc+xZ1lf7K78YhU2d+gOOQLrNaRmHyCqyfrIfrAdHYftw
         3yG0Uy2jjbC2Tr+SA6Ri6iudDActcKtCI3yinwYD926pHgtQz28GX9uCfVpN4+FiIPMU
         JjLBgoZH/jgTLBPOoogJ87/JNuud2fsucAIo8q4jZXTlAzZCh0NAlg0iu8YWQegSEMGz
         65ug==
X-Gm-Message-State: ACrzQf2w20SwhygfDFoM0c+Ol7xzDlP2U+WTZNbWQYK9IkkIt4nT3YyG
	WMkmpi4EavHqkhHXDySPijtmUm0Zo1S473L/FIb95vTkk1X3h0T2BvzOreIpIXflxwxU9VytZoA
	rC8Hzs0ikNjXdJyiDhRtVEtlBd44=
X-Received: by 2002:a05:6000:551:b0:22e:4499:a478 with SMTP id b17-20020a056000055100b0022e4499a478mr12211626wrf.459.1665421535013;
        Mon, 10 Oct 2022 10:05:35 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6MDzV9L01F029gTj1ssLnHEx3xEyweFq79VqCpbwfJHiOCzNf0Eeex8rsDJwqhIumi3/kkGQ==
X-Received: by 2002:a05:6000:551:b0:22e:4499:a478 with SMTP id b17-20020a056000055100b0022e4499a478mr12211606wrf.459.1665421534723;
        Mon, 10 Oct 2022 10:05:34 -0700 (PDT)
Date: Mon, 10 Oct 2022 13:05:24 -0400
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Nadav Amit <namit@vmware.com>
Cc: Alexander Graf <graf@amazon.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Ajay Kaher <akaher@vmware.com>, "x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	Srivatsa Bhat <srivatsab@vmware.com>,
	"srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
	Alexey Makhalov <amakhalov@vmware.com>,
	Vasavi Sirnapalli <vsirnapalli@vmware.com>,
	"er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>,
	"willy@infradead.org" <willy@infradead.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"jailhouse-dev@googlegroups.com" <jailhouse-dev@googlegroups.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"helgaas@kernel.org" <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/PCI: Prefer MMIO over PIO on all hypervisor
Message-ID: <20221010130413-mutt-send-email-mst@kernel.org>
References: <9FEC6622-780D-41E6-B7CA-8D39EDB2C093@vmware.com>
 <87zgf3pfd1.fsf@redhat.com>
 <B64FD502-E794-4E94-A267-D690476C57EE@vmware.com>
 <87tu4l9cfm.fsf@redhat.com>
 <04F550C5-786A-4B8E-9A88-EBFBD8872F16@vmware.com>
 <f1a7e603-2e64-fd2a-1100-f2898060e3f7@amazon.com>
 <DF8775A4-5332-412C-9359-749E96E83907@vmware.com>
MIME-Version: 1.0
In-Reply-To: <DF8775A4-5332-412C-9359-749E96E83907@vmware.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, Oct 04, 2022 at 06:48:11PM +0000, Nadav Amit wrote:
> On Oct 4, 2022, at 1:22 AM, Alexander Graf <graf@amazon.com> wrote:
> 
> > ⚠ External Email
> > 
> > Hey Nadav,
> > 
> > On 03.10.22 19:34, Nadav Amit wrote:
> >> On Oct 3, 2022, at 8:03 AM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> >> 
> >>> Not my but rather PCI maintainer's call but IMHO dropping 'const' is
> >>> better, introducing a new global var is our 'last resort' and should be
> >>> avoided whenever possible. Alternatively, you can add a
> >>> raw_pci_ext_ops_preferred() function checking somethin within 'struct
> >>> hypervisor_x86' but I'm unsure if it's better.
> >>> 
> >>> Also, please check Alex' question/suggestion.
> >> Here is my take (and Ajay knows probably more than me):
> >> 
> >> Looking briefly on MCFG, I do not see a clean way of using the ACPI table.
> >> The two options are either to use a reserved field (which who knows, might
> >> be used one day) or some OEM ID. I am also not familiar with
> >> PCI_COMMAND.MEMORY=0, so Ajay can hopefully give some answer about that.
> >> 
> >> Anyhow, I understand (although not relate) to the objection for a new global
> >> variable. How about explicitly calling this hardware bug a “bug” and using
> >> the proper infrastructure? Calling it explicitly a bug may even push whoever
> >> can to resolve it.
> > 
> > 
> > I am a lot more concerned with how we propagate it externally than
> > within Linux. If we hard code that all Linux kernels 6.2+ that are
> > running in VMware prefer ECAM over PIO, we lock ourselves into that
> > stance for better or worse, which means:
> > 
> > * All past and future versions of any VMware hypervisor product have to
> > always allow ECAM access for any PCIe config space write
> > * No other hypervisor benefits from any of this without upstream code change
> > * No real hardware platform benefits from this without upstream code change
> > 
> > By moving it into MCFG, we can create a path for the outside environment
> > to tell the OS whether it's safe to use ECAM always. This obviously
> > doesn't work with MCFG as it stands today, we'd have to propose an MCFG
> > spec change to the PCI SIG's "PCI Firmware Specification" to add the
> > respective field. Future VMware versions could then always expose the
> > flag - and if you find it broken, remove it again.
> > 
> > Putting all of the logic on which system potentially prefers ECAM over
> > PIO config space access into Linux is just a big hack that we should
> > avoid as much as possible.
> 
> Thanks Alex. You raise important points. Let me try to break down your
> concerns slightly differently:
> 
> 1. Enabling MMIO access should be selective, and potentially controlled by
> the hypervisor. The very least a "chicken-bit” is needed.
> 
> 2. PCI SIG would change its specifications to address unclear hardware bug.
> 
> I think (1) makes sense and we can discuss different ways of addressing it.
> But (2) would not happen in a reasonable timeline and seems to me as an
> unnecessary complication.
> 
> But before we discuss how to address the issue, perhaps we need to first
> understand it better. I am not sure that I understand this MMIO bug, and so
> far nobody was able to provide exact details.
> 
> So I went to have a look. It might not be super helpful, but for the record,
> here is what I collected.
> 
> First, we have commit d6ece5491ae71d ("i386/x86-64 Correct for broken MCFG
> tables on K8 systems”). It tried to "try to discover all devices on bus 0
> that are unreachable using MM and fallback for them.” Interestingly, it
> seems similar to FreeBSD code (commit 2d10570afe2b3e) that also mentions K8
> and has similar detection logic in FreeBSD’s pcie_cfgregopen().
> 
> Then commit a0ca9909609470 ("PCI x86: always use conf1 to access config
> space below 256 bytes”). The correspondence [1] mentions some bugs: ATI
> chipset, VIA chipset, Intel 3 Series Express chipset family and some reports
> on Nvidia. It turned out some devices had problem probing - to figure out if
> MMIO is broken - the way the previous patch did.

There's also a statement by Linus that MCFG might not cover all buses
in that thread.  I didn't think the implications through yet ...

> All of these bugs are circa 2008, of course. And note that FreeBSD did not
> take a similar path. The correspondence around Linux patch is endless. I
> admit that I did not understand whether eventually the issues were found to
> be per-bus or per-device.
> 
> 
> Back to the matter at hand. The benefit of using the MCFG approach that you
> propose is that it can enable native systems to use MMIO as well. However,
> since the list of bugs is unclear and the problems might be device-specific,
> it is not clear what information BIOSes have that Linux doesn’t. In other
> words, the benefit of getting it into the specifications is questionable,
> and the complexity+time is high.
> 
> Can we agree that the feature would be enabled explicitly by the hypervisor
> and Linux would enable it based on the hypervisor input (through some
> channel?)
> 
> Thanks,
> Nadav
> 
> [1] https://lore.kernel.org/all/20080112144030.GA19279@jurassic.park.msu.ru/T/#u



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 18:08:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 18:08:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419306.664078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohxCZ-0006I2-Di; Mon, 10 Oct 2022 18:08:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419306.664078; Mon, 10 Oct 2022 18:08:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohxCZ-0006Hv-Aq; Mon, 10 Oct 2022 18:08:31 +0000
Received: by outflank-mailman (input) for mailman id 419306;
 Mon, 10 Oct 2022 18:08:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ILM/=2L=citrix.com=prvs=2752edee2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ohxCX-0006Hp-Od
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 18:08:30 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 88ae3b86-48c6-11ed-8fd0-01056ac49cbb;
 Mon, 10 Oct 2022 20:08:28 +0200 (CEST)
Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 10 Oct 2022 14:08:13 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB5933.namprd03.prod.outlook.com (2603:10b6:a03:2d5::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct
 2022 18:08:09 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022
 18:08:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88ae3b86-48c6-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665425307;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=PnZoCexthh/EXunivWF7KSnsSKgHi7Gq9hM7Q3WRMC8=;
  b=N/x0t0e5yNirVtofB3QrHlONTgC89sDGtoQPjlVgs5LiSGhLXdJ+kHed
   UJwrF58eP+xpneeYArYcvebNosF8q7GHQoE4nQG682URs+dZazjp0JiKt
   i8WNFLCGv6eneHDYtaEVL2Feq3snZ2/3fZEyLSSl2x2fzJmfUAUVZajFB
   k=;
X-IronPort-RemoteIP: 104.47.66.48
X-IronPort-MID: 84925573
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:j6SxlKC33X/cNhVW/xriw5YqxClBgxIJ4kV8jS/XYbTApGt01TBWm
 jYYWz+FPvrfYWr8ft51Odnn9kMD65WGyNIxQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2q4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k7DZM32OFzLF1cq
 /ApLis3bAGxtem5lefTpulE3qzPLeHNFaZG4DRF8mucCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWMG7g7FzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr
 WPa5WXpRBodMbRzzBLVriP227KQxksXXqoJT5+Fz8dhg2aT/Ug/JBM6c1mQr+uA3xvWt9V3b
 hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz
 FDht8ztLSxitvuSU3313peZqymjfxccK2AqbDUBCwAC5rHeTJobixvOSpNmD/Szh9isQzXom
 WjW/G45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5
 RDoR+D2ADgyMKyw
IronPort-HdrOrdr: A9a23:JDptpqMlAIYJRcBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+
 Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu
 UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+
 jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI
 SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
X-IronPort-AV: E=Sophos;i="5.95,173,1661832000"; 
   d="scan'208";a="84925573"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EZ/8ONue2NH2c7wmoRYCoPyGStpJbmoCrNgTc3mHHpM6KHFUiog0lPtp0sDk/k1VrNLUXCsvMDkfpRQkBy4XXxsLBBhtcosjyePefPG+RRrZsXXpgDmwX1zq3g6RIqVVjUJJ7LbVUQVAv3FaN8JTl7vge4qp/OmgsQdZHaRLHGxCT9ETd5O5AhxMAWnpKVgtcxql42J1JLAWV3y5VZB5g6WmCenAi3Gm80scx8mDBQmSYEvNOnxLQHSQ9UXpgRnahcj2DA8k/TEFiicjOS+LQJrb3vWIGP6voHvZ54cyEs9cDmLuAGZriUTjgiKM7Gf5ZyNWvy6x74ywY9MS+HO36Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PnZoCexthh/EXunivWF7KSnsSKgHi7Gq9hM7Q3WRMC8=;
 b=PHA3JzhDzf7HwGaACHEhm3g54FKAoeEVKQZ3YF1hNvkP3rvU3+c19DSmT/XQI93qOo3+/42Ct5jSAGkZwFsZm3RYCy4PYGk/+wteQMHcBziywFO8cFDofz5yvYi79iM0XB+W9zRmV6RR2WrI+gm9tJOdtFw1WUd/7FZ1lRqgR1ynkCPb+El6XxxZlCNhdKBnbMtiXqpF8aX43Uc4upoI6PmYZsOTOT1iB3G2Qu/Q9udgMk0bHyn0zsUSwa9LHXCA2wYhn2G2e+TAplUz5neqlxM0yVgn0MZ3HEKULqsZeB5JCkhg01f7T+ONw/+hXWQ1WK6rkXr1EWTZyao3+ijM4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PnZoCexthh/EXunivWF7KSnsSKgHi7Gq9hM7Q3WRMC8=;
 b=Ghc4z3IXMfcXu0UfifsAYwz/um0lojUJk6Q2XY0ipxgMoEf6gO9N37PugGJredCsVwpIzRuutOv3eNDZxFuX521TJiNxTmbg/bms8piP9+u6GVkfZbIZHeHqQKVpCk/CKFXDid6u22WJ5oS8vd/CsG2I4DvC78aLMrg1OuhpLeQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
 INS/OUTS
Thread-Topic: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
 INS/OUTS
Thread-Index: AQHY2YU75mqlIJYsj0WxLAJHeHNvXK4H83eA
Date: Mon, 10 Oct 2022 18:08:09 +0000
Message-ID: <2dc898c0-b42a-28d7-7126-9379f03119f3@citrix.com>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
 <4d01771c-fd02-b607-c480-04bcb11fa7b3@suse.com>
In-Reply-To: <4d01771c-fd02-b607-c480-04bcb11fa7b3@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5933:EE_
x-ms-office365-filtering-correlation-id: 80fd0a94-3f14-4f73-27f4-08daaaea6391
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Y8UNt3BEpsD8qWlgk9z396CZUW8YnzPqWPUlUaBBZnDAlLSW6T+t366uBDrOq0p/oRDFkvV34cU9lTULP4qQni6YRnmk16QyzDTH8u7uYuzA7CJ5Dc1OzPnVQMz3FyUcOSWS8uTJP2rYEcoCKlsqCN4e3Cab1kVEYz0gEOfOdi1PehhqMLPjE6aXreKaKZ5iSXbrW5peA0m06RilvaqjZjJwnkrT28+pfWOC7n3Ku3BfidT7CVgz8oeyOnKugK+3peKkdFAe5TZcexI5BCTuXQVCgZuSaIsa6NJmFU5Isrp/DbYXSNy3DwGqEt7cTqr6c22coTgAF7Hu0tdPdP+AhasNv1pDKBwpSfR98/5LmRGrnBdIPr7d0yyNqKmzUQ5PPAKupFvJizoZ594zabwbZ8Lrtod1x/9HZ8WLx8frflmgixA29OK/SvdoSL05TQ1ZfjWVxuRWP3D60FJjTIrIJ7V0a7b0pSXK8I6rVJA33FGRCIfBCb9lMjFf581+LVPlcEKJF+knE8IZsL/T+DiRVFvuvRJBEvfD2fzbfwdsrAp36BAxAV2EfTFH+HAn7kT1ZoM3OhOMT19HMdTGTTo8xU2Mb50SKZ4ls1f9zUQd6IccFTsqLTaVo5P8RkPdgCiuFy4/tKBh5Y3jY15x27tz2Bb09qvUOww/J4Kd1GhzkzjqvjKSE9MWTOZ2gSq5lXmbiSTnjIWTKgOlNxdLgJthjinPqQFOr1t5v3pfM/oUDrFshkbZTc9obJsRwhAQAfR0wHfQTSmcyd4HSPA09IpUZV7ycvzAQ7U+6/DA74Vz4LVFjWV5YapUztPxBafq7qtPPxmAjHLQ9vQSaBkAUVJktg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199015)(6506007)(36756003)(53546011)(2616005)(26005)(316002)(6512007)(38100700002)(8936002)(71200400001)(82960400001)(41300700001)(31696002)(86362001)(76116006)(91956017)(66476007)(64756008)(66556008)(122000001)(4326008)(54906003)(66946007)(66446008)(5660300002)(6486002)(478600001)(8676002)(110136005)(38070700005)(31686004)(83380400001)(2906002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?eHZxYVVaZ0Jia21YRVNsb012LzhXck80MUJDNzRYRHZUdndvWEdVMVcyNUdi?=
 =?utf-8?B?VzlCZW9Nb1JIaythbzhyR1YvQ3Z1eThEeGtXOHE3YlViUlQvYWQ2UVhJZ1c1?=
 =?utf-8?B?YTljMTJsN0NMS1BWTjJrTWZVNnpNWmI5OGJjeDNzalNEckZYRE5Fd0J2RlFh?=
 =?utf-8?B?eTlTaytneW10Q3k1Z2dEUGYrQkJFcUprc1JKcFlPbXNNeWVnSzliOUJZU2pK?=
 =?utf-8?B?cXdIRWVMZ0JpZ3NFY0w1K2tFVUN1cmxpVGZkTnE0ZUlWSGNkY1NZL2pSa1d2?=
 =?utf-8?B?UDhVY29sMlZHVWZDcllGWTB3OEVpN2lGUjZKOUFTQ1QrUEJ2aGUrNHJONTV4?=
 =?utf-8?B?eGxRdUNyNE9ZM1hrd1dlQ2JOcU5MMVk2NERCeXdSY1N1M3NkYUJYWlorQzJR?=
 =?utf-8?B?NTQ1ZUd6UzRMOFk4UjJ1TStZcDBzRmJCSEczdk1BQk5PZkVjVGZMS0hVYVQ2?=
 =?utf-8?B?VE1NRjVKYVJpLzJ0aTRzRU1rTmxtYzlyZUFyTHFCRUhoNW1xVk0zc3ZMdTJH?=
 =?utf-8?B?UktNbVlNUWdRVVlZVnhMbGlFQU5MVi84aUhGZ3RCdE1vNTJzclpZZ3hnbU1U?=
 =?utf-8?B?VW5Za1NxV0lSOUM5NldJZ0gvbjRETDRVb3JabHBEZjV4Zk8wODlMbGIrVnBj?=
 =?utf-8?B?d0UzYmk2QXZrc2VkUytmbm9BbnlmS251eURUb1M2VFZ0cDlDQ241b2l3TU5J?=
 =?utf-8?B?a1pRSG9VQjZYbDJQUmNnNWpjbm5jU01jMlZSVnAraXdKK3hVd1kwbzdGMkU3?=
 =?utf-8?B?dVNLQ0t0R0lSL0VlaWNIeW1BYlZqTTVBQUFqV1FZSzVETmpkQnhPN0JDSzMz?=
 =?utf-8?B?bW80QlAwcE5CS2FwMUcrL3hIaDhYN0xUaUMzcndacDhQbHhPWm52UllXSklR?=
 =?utf-8?B?eEt3ME9kL3M0REtBbEsySnMvSEJlR1dOVituL3ZFU3RVWlRLaWhoZitwRmEw?=
 =?utf-8?B?NU40aENVdlhVVmxzOXRCU3JmR2ZjTWhqRDhrZ2pCZGkzTnhnR2lFYVUyOHd2?=
 =?utf-8?B?ZG1PZTdVK2pwdzVyckhkTWhIdlNRZCtybFJiTmEyTnlMd3FTQ1ZPc0F0djFk?=
 =?utf-8?B?bWdPejhHaTVjVWtpV1hHeHkzSk1RNW80M2FTV1pDd1RmQURHeUhpaVdXWDN4?=
 =?utf-8?B?OHRlRUdrT3ZSazVhQmhGQ0NhQ090V095c0hYc2RPaFE2T05FV1JtclpjZjVp?=
 =?utf-8?B?ci9FT0lNOHdLTWRpWGhQWDdVUERad2dYeTVLWjkrajltTXBvdHlKOGRnVVFM?=
 =?utf-8?B?S2cramwrOGs5RXgzZzR2ck5iM3VnblNkK21sa3JUTUF5Z1c4LzZuL2FlNW9X?=
 =?utf-8?B?R2N4RXdTZHZmTlVCeXJWMVZVTHZWT0ZES3U5ZlVvaCtoeCt2d01Qc3AyMEFl?=
 =?utf-8?B?NEFhcHZtMnk5eGowY3BMeXI0ZG03VkU0dGZrc3YvSEM3N3hjVndxQzNvM0FC?=
 =?utf-8?B?aUc4VG5uV0g3VU9BcGpsanBlcWQrZUg1NkQxckVmaVFKV1dBdkg2Sy9xWGxi?=
 =?utf-8?B?T2JaY3NaMGZwbFFONHNTdzdabnVGdGRud24rbnJvYTNBRFhZdXBiRlJ3cGxL?=
 =?utf-8?B?TXpxTXVpcjJ1bG01UmpWQzYrRUZKVFZnWXRHUjR4b0dJazRDbkl0M0tOK0dy?=
 =?utf-8?B?WTgrTitmVHpYaXZ2OWtvN2FWTDl5anVvTGtDQWVmYTlmekVlay9iZnMya0pT?=
 =?utf-8?B?bmpYeDI1bWxBbHZ3MjZmYnp6T3VVU3EvTm1pTUd4Q21rWFVWSCtuQ1hleDRL?=
 =?utf-8?B?MEI0aEs0U2NJMFpQMjJRakh5eWtXaXMxMFEwNHlySXRFdGZwQ2FhMlZpSE9V?=
 =?utf-8?B?ZTY3aGxvZk5meU1RanUrVVBsZ0RFR09BRERWZVpVSUxCVUt0SWY1Y3hKWHpJ?=
 =?utf-8?B?dUNINkFQZVhLSXhjWTZzQS9iakhrUUNqeXBrLzF5SW9HbmVjZjRJNitiQlAx?=
 =?utf-8?B?VDZuNlBRSzJNYnFtWEdDVTk1dFBYQnVGYXdTS2tZNnBpOUt6eDVXUnVyMGdJ?=
 =?utf-8?B?d0tpdVVEUjdiSms4MlduSGt3enlDbDhNSVo4OXJBYWRPM1pkNEw4dTRQR1g5?=
 =?utf-8?B?dVRJdTRKNzcxOVU5K01BYVBTZHhhNGhkZFZOZUVQaXp6NzJEOE9uSDJFeUhv?=
 =?utf-8?Q?ptiyRstG8tKB7QGbxES9VZrMs?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9C7D3BF5F10764439C740B59A1BB05BD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80fd0a94-3f14-4f73-27f4-08daaaea6391
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 18:08:09.5560
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W+uAo5p+R+7DFzb/Jv44GVWtBpE9PAb6BmJmX9QPc3YsBSf4gXosFujxTjkWSIkxLwYwTQSZ4rj+iMjod48q2V+oSGkkT5IgWv1/eQnsnp0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5933

T24gMDYvMTAvMjAyMiAxNDoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEJhc2VkIG9uIG9ic2Vy
dmF0aW9ucyBvbiBhIGZhaXIgcmFuZ2Ugb2YgaGFyZHdhcmUgZnJvbSBib3RoIHByaW1hcnkNCj4g
dmVuZG9ycyBldmVuIHplcm8taXRlcmF0aW9uLWNvdW50IGluc3RhbmNlcyBvZiB0aGVzZSBpbnNu
cyBwZXJmb3JtIHRoZQ0KPiBwb3J0IHJlbGF0ZWQgcGVybWlzc2lvbiBjaGVja2luZyBmaXJzdC4N
Cj4NCj4gRml4ZXM6IGZlMzAwNjAwNDY0YyAoIng4NjogRml4IGVtdWxhdGlvbiBvZiBSRVAgcHJl
Zml4IikNCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0K
PiAtLS0NCj4gUGFydGx5IFJGQyBmb3IgdGhpcyBub3QgYmVpbmcgZG9jdW1lbnRlZCBhbnl3aGVy
ZTsgaW5xdWlyeSBwZW5kaW5nLg0KDQpJbnRlbCBkbyBhY3R1YWxseSBkb2N1bWVudCB0aGlzIGlu
IHR3byByb3VuZGFib3V0IHdheXMuDQoNCjEpIFRoZSBvcmRlciBvZiBjaGVja3MgaW4gdGhlIHBz
ZXVkb2NvZGUuwqAgTXVsdGlwbGUgdGltZXMgaW4gdGhlIHBhc3QsDQpJbnRlbCBoYXZlIHNhaWQg
dGhhdCB0aGUgb3JkZXIgb2YgY2hlY2tzIGluIHBzZXVkb2NvZGUgaXMgYXV0aG9yaXRhdGl2ZS4N
Cg0KMikgVGhpcyBwYXJhZ3JhcGggSSd2ZSBqdXN0IGZvdW5kIGF0IHRoZSBlbmQgb2YgdGhlIElO
UyBkZXNjcmlwdGlvbi4NCg0KIlRoZXNlIGluc3RydWN0aW9ucyBtYXkgcmVhZCBmcm9tIHRoZSBJ
L08gcG9ydCB3aXRob3V0IHdyaXRpbmcgdG8gdGhlDQptZW1vcnkgbG9jYXRpb24gaWYgYW4gZXhj
ZXB0aW9uIG9yIFZNIGV4aXQgb2NjdXJzIGR1ZSB0byB0aGUgd3JpdGUgKGUuZy4NCiNQRikuIElm
IHRoaXMgd291bGQgYmUgcHJvYmxlbWF0aWMsIGZvciBleGFtcGxlIGJlY2F1c2UgdGhlIEkvTyBw
b3J0DQpyZWFkIGhhcyBzaWRlLWVmZmVjdHMsIHNvZnR3YXJlIHNob3VsZCBlbnN1cmUgdGhlIHdy
aXRlIHRvIHRoZSBtZW1vcnkNCmxvY2F0aW9uIGRvZXMgbm90IGNhdXNlIGFuIGV4Y2VwdGlvbiBv
ciBWTSBleGl0LiINCg0KVGhpcyBtYWtlcyBpdCBjbGVhciB0aGF0IHRoZSBJTyBwb3J0IGlzIHJl
YWQgYmVmb3JlIHRoZSBtZW1vcnkgb3BlcmFuZA0KaXMgaW50ZXJwcmV0ZWQuwqAgKEFzIGEgdGFu
Z2VudCwgd2hpbGUgdGhlIFNETSBzdGF0ZW1lbnQgaXMgYWxsIHRydWUsDQppdCdzIGVudGlyZWx5
IHVzZWxlc3MgYWR2aWNlIGZvciBlLmcuIGEgbWlncmF0aW5nIFZNLikNCg0KDQpSZXZpZXdlZC1i
eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4sIHByZWZlcmFibHkg
d2l0aA0Kc29tZSBvZiBeIGRpc2N1c3NlZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQoNCj4NCj4g
VGhlIHJlZmVyZW5jZWQgY29tbWl0IGlzIHN0aWxsIG5vdCByZWFsbHkgdGhlIG9uZSwgYnV0IGJl
Zm9yZSBpdCBSRVANCj4gaGFuZGxpbmcgd2FzIHNvIGJyb2tlbiB0aGF0IEkgZGlkbid0IHdhbnQg
dG8gZ28gaHVudCBmdXJ0aGVyLg0KPg0KPiAtLS0gYS94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUv
eDg2X2VtdWxhdGUuYw0KPiArKysgYi94ZW4vYXJjaC94ODYveDg2X2VtdWxhdGUveDg2X2VtdWxh
dGUuYw0KPiBAQCAtNDI0OCwxNCArNDI0OCwxNSBAQCB4ODZfZW11bGF0ZSgNCj4gICAgICAgICAg
Z290byBpbXVsOw0KPiAgDQo+ICAgICAgY2FzZSAweDZjIC4uLiAweDZkOiAvKiBpbnMgJWR4LCVl
czolZWRpICovIHsNCj4gLSAgICAgICAgdW5zaWduZWQgbG9uZyBucl9yZXBzID0gZ2V0X3JlcF9w
cmVmaXgoZmFsc2UsIGZhbHNlKTsNCj4gKyAgICAgICAgdW5zaWduZWQgbG9uZyBucl9yZXBzOw0K
PiAgICAgICAgICB1bnNpZ25lZCBpbnQgcG9ydCA9IF9yZWdzLmR4Ow0KPiAgDQo+ICAgICAgICAg
IGRzdC5ieXRlcyA9ICEoYiAmIDEpID8gMSA6IChvcF9ieXRlcyA9PSA4KSA/IDQgOiBvcF9ieXRl
czsNCj4gLSAgICAgICAgZHN0Lm1lbS5zZWcgPSB4ODZfc2VnX2VzOw0KPiAtICAgICAgICBkc3Qu
bWVtLm9mZiA9IHRydW5jYXRlX2VhX2FuZF9yZXBzKF9yZWdzLnIoZGkpLCBucl9yZXBzLCBkc3Qu
Ynl0ZXMpOw0KPiAgICAgICAgICBpZiAoIChyYyA9IGlvcG9ydF9hY2Nlc3NfY2hlY2socG9ydCwg
ZHN0LmJ5dGVzLCBjdHh0LCBvcHMpKSAhPSAwICkNCj4gICAgICAgICAgICAgIGdvdG8gZG9uZTsN
Cj4gKyAgICAgICAgbnJfcmVwcyA9IGdldF9yZXBfcHJlZml4KGZhbHNlLCBmYWxzZSk7DQo+ICsg
ICAgICAgIGRzdC5tZW0ub2ZmID0gdHJ1bmNhdGVfZWFfYW5kX3JlcHMoX3JlZ3MucihkaSksIG5y
X3JlcHMsIGRzdC5ieXRlcyk7DQo+ICsgICAgICAgIGRzdC5tZW0uc2VnID0geDg2X3NlZ19lczsN
Cg0KQXMgYSBmdXJ0aGVyIG9ic2VydmF0aW9uLCBib3RoIHRoZSBJbnRlbCBhbmQgQU1EIG1hbnVh
bHMgZWx1ZGUgdG8gdGhlDQp1c2Ugb2YgdW5zZWdtZW50ZWQgbWVtb3J5IHNwYWNlIGZvciB0aGUg
NjRiaXQgZm9ybXMgb2YgdGhlc2UuDQoNCkhvd2V2ZXIsIGFzIGJvdGggJWRzIChvdXRzKSBhbmQg
JWVzIChpbnMpIGlnbm9yZSB0aGVpciBiYXNlcyBpbiA2NGJpdA0KbW9kZSwgSSBjYW4ndCB0aGlu
ayBvZiBhbnkgcHJhY3RpY2FsIGNvbnNlcXVlbmNlcyBvZiBjb25kaXRpb25hbGx5IG5vdA0KdXNp
bmcgeDg2X3NlZ19ub25lIGhlcmUuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 18:54:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 18:54:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419314.664088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohxun-0003SA-Ve; Mon, 10 Oct 2022 18:54:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419314.664088; Mon, 10 Oct 2022 18:54:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohxun-0003S3-T2; Mon, 10 Oct 2022 18:54:13 +0000
Received: by outflank-mailman (input) for mailman id 419314;
 Mon, 10 Oct 2022 18:54:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohxum-0003Rt-SY; Mon, 10 Oct 2022 18:54:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohxum-0005DS-P2; Mon, 10 Oct 2022 18:54:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ohxum-0006y7-B4; Mon, 10 Oct 2022 18:54:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ohxum-0006sg-AY; Mon, 10 Oct 2022 18:54:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=awQ3w5QIFJF3162XMEP5EyZ6usW4GwC8ON7KhFyTncE=; b=U3D3nMciQOLIigoB5ElbAI2zIz
	DX32KNG9Z773MylUrlPDMa4f1P9gSxiyDwHGNKvPnLtJ0e++VVCb0MW9QiH8/JFfX4LRnlFViCK17
	LHJM0Z+O2CdzCMl9w/udzcEF/1eG4/nmljOhmglIW8TUlwCtewqhF3gJVeRYVLDarWtI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173486-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173486: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:<job status>:broken:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:host-install(5):broken:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=493ffd6605b2d3d4dc7008ab927dba319f36671f
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 10 Oct 2022 18:54:12 +0000

flight 173486 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173486/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-rtds        <job status>                 broken
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds      5 host-install(5)          broken pass in 173483

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot       fail in 173483 REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                493ffd6605b2d3d4dc7008ab927dba319f36671f
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    3 days
Failing since        173470  2022-10-08 06:21:34 Z    2 days    9 attempts
Testing same since   173483  2022-10-10 02:30:10 Z    0 days    2 attempts

------------------------------------------------------------
629 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     broken  
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl-rtds broken
broken-step test-armhf-armhf-xl-rtds host-install(5)

Not pushing.

(No revision log; it would be 49657 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 18:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 18:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419322.664100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohxx8-00049n-DI; Mon, 10 Oct 2022 18:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419322.664100; Mon, 10 Oct 2022 18:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ohxx8-00049g-AC; Mon, 10 Oct 2022 18:56:38 +0000
Received: by outflank-mailman (input) for mailman id 419322;
 Mon, 10 Oct 2022 18:56:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ILM/=2L=citrix.com=prvs=2752edee2=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ohxx6-00049Y-Sg
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 18:56:36 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4217313a-48cd-11ed-91b4-6bf2151ebd3b;
 Mon, 10 Oct 2022 20:56:35 +0200 (CEST)
Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 10 Oct 2022 14:56:27 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BY5PR03MB4984.namprd03.prod.outlook.com (2603:10b6:a03:1ea::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Mon, 10 Oct
 2022 18:56:24 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022
 18:56:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4217313a-48cd-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665428195;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=0jJ8k2lLFkwvMAqf2glIod6D/ZyiJxjnfdS2+UJFb8Y=;
  b=iRfP+rcXq8o1jeSM0Q1cm1juQKnvIkhLzbZvA6P0Ld7boes8eYD7gDM5
   ZBjnkWjp43QwCi5Ud/EEe2YwW07i1kCCFwO0xs2lApUwMIVGZR0myBkxY
   KRKdgcYSlEIg9sAB4iwKmqBUFbBxA6RJTNxZ5nNbreLDIjlFnsGtwhJ7y
   g=;
X-IronPort-RemoteIP: 104.47.59.169
X-IronPort-MID: 82042255
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:tUv4W6rp38RRpAF8iFXOrzXuyJZeBmIqZBIvgKrLsJaIsI4StFCzt
 garIBmBPP6IZTOmfIsnaNi+8EgGuZLUyYdrTgZlqn80RXtH95uZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgS5AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6
 McEBxMEcDK6m++464K6F9Viqp0NFZy+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUoojumF3Nn9I7RmQe18mEqCq
 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJITOHirKM36LGV7m5IChEofmHlm6fnzRCeYcJVc
 X49/AN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62
 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqRSICVxpD3NDlr6k6lBeJRdFmeJNZlfXwEDD0h
 jyP8i43guxJidZRjvvqu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd
 UMsw6C2hN3ix7nU/MBRaI3hxI2U2ss=
IronPort-HdrOrdr: A9a23:ehJTM67ry/cS0jTTKwPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.95,173,1661832000"; 
   d="scan'208";a="82042255"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hcBsX4OlYmRmNJfC3MDsJwuquJ0hGQ5HKFPUL17lWD9RBumhmu/1QSXDXorSH5IJSzcPFdqTdgGJT45+tt3ml6NRIH2KWHXaZ648YTZs+aYftsj2shMMXdlZ9KHS3t0sks+VfHqyEbEaBRoreeim6DmebMHuL5BB1UOIZ5SRiCKLy8ew0/vRv67pUK66onle7Y90lOqgS3VCC+mgnbX1R6uyGBZk6EKSN4ZiBAueQ+V7WcVX7Hg7Dhht0gFwGTQRxy8VCWKTlw0jSdO4Tbd0ePNij7Ytn8g6Zq0ZT4FGHzGuWSTOBXGXckZpR+dOSMGzpIZoIugwUb9PJ28Z7+Gmsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0jJ8k2lLFkwvMAqf2glIod6D/ZyiJxjnfdS2+UJFb8Y=;
 b=KL4jB7sVpOLjnvfKTIRSScOfzUQgr1Jeg5dhvHvASYaJWJpMokyAQMR/WsUSzEl1eaNDzbnkMloEerF2VtJV0rX0suL6+04EOmXzYyanQdaYRjNhY9rwhGIzfr7+lH7t7GHC1pdzrATZ6jikoIglPY6+6hqmjgV9sLftsLtE0xKTnnvhxnEuGbK9pJCAt7AKIFn/dIeje4ZSrOiGSxwdeO3CPjdVSBpdN7L0vixnbYczdOyoXkTDN7Cgd5fx++vk2Mukxw2iJ7bJdOvALDvF4YWTMZLXGv2lkpBFp/TcYj52Iap5FtVzo52zhdUHplbvINIZ3Dg5oSx2AFIOL3QwCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0jJ8k2lLFkwvMAqf2glIod6D/ZyiJxjnfdS2+UJFb8Y=;
 b=F1qABKEqKclX41koGXpP2VPnNKCVJPi6HCg0vJgK1qlCdJT0j7hSCp4CrkIT7nDm1+qId7FXM06fhK/58L+2e6YXjy6XxhyRYIRVOUox1aO9S9pXQN6tLtUFVOqrr3yiX3iRCZk4Mzj5QYCtIzJz7mqPJogYCrLwOqFZw2Ur1I8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH 1/2][4.17] x86emul: further correct 64-bit mode zero count
 repeated string insn handling
Thread-Topic: [PATCH 1/2][4.17] x86emul: further correct 64-bit mode zero
 count repeated string insn handling
Thread-Index: AQHY2YUgg4gsheo4JECtz9+zXlXTaK4IAO8A
Date: Mon, 10 Oct 2022 18:56:23 +0000
Message-ID: <9c407e09-4af8-b021-293d-b1db8a0ca4f9@citrix.com>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
 <1dac86de-cb8c-d2b2-d0ab-bf76707d22d0@suse.com>
In-Reply-To: <1dac86de-cb8c-d2b2-d0ab-bf76707d22d0@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BY5PR03MB4984:EE_
x-ms-office365-filtering-correlation-id: d4f04f96-996c-48af-92f6-08daaaf120ca
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 970wF+eQAmsC1hXQJjQIviyxq24DcVD1licAG/YEBRE92k9zAkpSFWIfe3sFqmQhREn8KgC88/X0PkFugvDvd0+m2iQ+VkgDRMr33wmJZDwsG9lxuXUDAqAWmmFGEUTavB1QtLCudBBPjB6gRtaGwGRIFsZrlFPAe91GGicFx74Qp5Bz3bZJV3EKWnY38vwYOpWNQzl1ol0rUJOt/BIs4Gz+MLVXGn4qM9dXUkkm1AHeG5Our4hK/psYvxeIra5jxnIiAitLWIg4oWTRAxS2X5WwV5c0JhemuVPOZSYC/Bt/jTzprYt5MK3S+qvyHqRs2U40qCcz3jKFhF9Ll+9eQckrKyqwZW+Po0hJWtGufoqkwGB2epvh8MdEKHR72RGFAtAP4/2RXxYB41l5/C09tn8EZn1EFrks6pfobcKrm1WqezonKHkAqHooCQnooILry3WHOi1sAfSn+VcZ2fl/ijL3jBjDzjYIRWNkxVhUfILMx8LvWN+/VGGdLA80AAVguLCUX0tIH8VpCCSPkHDZQydJ7cwXP7xOjcHJSg7mNyFKTb1pREjUQr94s+HvwATScnZxcuFcu1Z5+PzeFynA9liy8IKQEwuq3U+woE4Xdu3fDUrZe5CjnAIRleRNOB7kExTJO7DPr3n3/xCvVV5FkgGB9e2tWjNCN9H3aLFJL2esalIidGyr5H+FG9wCpm3wjbJzd96jPYjymd1MAerdqbdo7fnMh2yT6P9oaZabtS0ZbH2vMh7U3FH//1azcj/oSeEfWsYUz+wdEzuM+2V3/BxUHSBRdDyOun5ZMRYBS1IhSgIEyOW88PMi4D5BxD6a20bdHMdn/Nhl/eWORmAU9A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(451199015)(110136005)(31696002)(86362001)(83380400001)(82960400001)(186003)(122000001)(2616005)(38070700005)(41300700001)(66446008)(54906003)(4326008)(53546011)(5660300002)(66556008)(66946007)(91956017)(8676002)(64756008)(76116006)(8936002)(6506007)(6512007)(2906002)(26005)(478600001)(71200400001)(316002)(66476007)(38100700002)(6486002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Nk9LTGlGN0tGUHJlV1IwZURaZVJ2UkdRdzNac0NIa2F1d3Q0MU9tUUxVdVE1?=
 =?utf-8?B?TzM2ODhvOHdEQ1h1UHNWVGFBQWdQOG9kUUd0SnBHdk5xQ1duQWJ2OC9XcHVQ?=
 =?utf-8?B?K0NXNUZhaVZwbC9KV3VQK01VT1dTTlhva3RpaStQUUpsT2FQOFByTHFBREZZ?=
 =?utf-8?B?NEg3STV0R1BzdEwzYjdxd0V5RXVBNCtzeFg4U2J0bGV1RS9xZU95TnFoM0hT?=
 =?utf-8?B?SzdWWW41Q3VDMG1hanNObCtUbFo0djd0WVFURW9ob2NzckZMSjhhMUdMRE5w?=
 =?utf-8?B?U29ITVZlajQ0dUwzV3hwaHhNRnRRdUJlTWJzYllYWVUyTHRFamVGbkxNOVFR?=
 =?utf-8?B?azkzVjR3WGhkYkZQZHRYMHh6dGNXVWgyb2FHenBiMXFRNXJvWWRVM0duWmpi?=
 =?utf-8?B?ZndxYXh0V2U2VUl0ZGppRVpUMWx5RHJkNHlnZDUvRnc1aEhQSzRwT1NNZlMr?=
 =?utf-8?B?Tk4vYlU5QWsxRFdjRk4wNDlITGZDNHZWeGloSytER0V2SUdhWFg5b1hveGFB?=
 =?utf-8?B?a0lQazZITy9UUWEwVUJJS2JmQWxvZ1kyTFpYakVhSHNYNGxGRndHb3dhRzRF?=
 =?utf-8?B?bVNKWlhBOGwxOURoSmFKV25JMllCYlROUlA1alAvYU1xQWlGUXNFLzNKbDl0?=
 =?utf-8?B?bFdUOUpxdzVqZHFFemc0M2hYLzdkNUdPSmZRV1RqTC9xUjBTTDRJMkFOYTlP?=
 =?utf-8?B?L2N5a2VxdlJMTTJXdzF0blZrbjJtajdXeFUvbkY0aEcrRnZ3SjUvMWtsaXJZ?=
 =?utf-8?B?WTR0b3hpVG1Kc1MxZjlMQmk0MWJ6TFY3cTFhekx1QXp6UjRWc05ZZHkvYXlF?=
 =?utf-8?B?REs0cHp5ZFJEcjFRTGFSbUlGM0FXdXZKK3gvVFAyMGZ2cll2V0MxM2RIT0dk?=
 =?utf-8?B?MG5yLzRkVXNIZWJaMGt1QjJhZlAwWWU2b2JzZm9kSGN0TzVqR21LL08zQnI0?=
 =?utf-8?B?TTF0cW1DNnBURE55R3FEaEh6RENCS1lOSGZsbkV4VG82cU5VczFkV2JtajAy?=
 =?utf-8?B?d0trN0d3VEZyOUJkUW1BMHBsZVJVdHRsV0loOTE1RGtwWHlqbC85aUQ2a1Vy?=
 =?utf-8?B?aW50UEhWT1N1U2VET0JuQUtQRjE4cUxDRzdxM3F6TGpBWlR6eWU3bDFOWG9M?=
 =?utf-8?B?L1YxNDRPMUo3YmdNeVRQaVhHV1dweHNxZVgxTUVoZWZPcHhXRTNFRENvK3Zy?=
 =?utf-8?B?MU81NjhoTTczQmhKS203dDUrL1dzcWM3MUw1K2M3TGdWTTFvUVFzTktHZlpO?=
 =?utf-8?B?WDlSeVRQbWpibXRHRGdGRWdYRDA0bzJTRUpZZEVsVkxjNmRoRC8xcmtMUElt?=
 =?utf-8?B?dVV2VGh4S1pLWWpTU1ZuYUJhWDBCNEVPcjI4SDlFZFJvanlhRVhMRjZHdmVx?=
 =?utf-8?B?UFBCZStkVExRUURlak41UGt6U0I5SUVPV1dFOXhJb3VSK0M2VUQyK2VORzNz?=
 =?utf-8?B?VHZ3ODB4UjJnUVZCZnpmNWNvblJEYlVCUHVhdnZiWWd2RjRPQ2RpeGRtVGQ0?=
 =?utf-8?B?ZHl0SGhpZVZuTm9lUXA3NWtvY2hpbk91bThmNGRRODdwM3daVGNSOFd0L05Q?=
 =?utf-8?B?ZTBiMGNNdVE2SFlSODhuSmJwUDJCN0h4SlNZN2ZteUdRNTczeWZzaUUzRU5z?=
 =?utf-8?B?R2tEYmxkNjZvNWppajg3NGo2cGRyQWp0QnAxSWdKTjZrSHh5QmlPM2xCTkhN?=
 =?utf-8?B?OUdrL3h1RWw5aGJiTzdva0JJRFZIUWpkWHdienlYM3p0QzY3NG03L3I1VWpl?=
 =?utf-8?B?OFU4WHd5Z0VRNHhlbkxHbzdTQk5oei9BN0hzaExlMklvaEdwRm5EYnBRRlh6?=
 =?utf-8?B?R1VZekNxV1A1RnZoUmlXODZsS0g5cnpIY0dpUVFjbThtZFpSaUlCWjFScnRC?=
 =?utf-8?B?RlZlbloyK3RYUlBGVnlwL1NUYTE2dmdYYkZHa1RscHRVKzR6b2JUcUZBbzl6?=
 =?utf-8?B?UWFuN29mSkRldXZMZ0MrRDJZRGNoOERHWjhXaDFBUkR1eEdlaDlKRTgrK285?=
 =?utf-8?B?UzhSOWl4anpvQk56QStiaFRmK2x2dmJNSkIzM3FybE16djBaOExmcFRrN0Nu?=
 =?utf-8?B?VGhaWFlaWkxzZEZrODZNdkJIZ1dJdEd2UFJSZ3p0cE41Mnh4OXU0RWRFOEdH?=
 =?utf-8?Q?CGjZmcFSxbARED3nSPCN1pzSo?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2E3E6CC47C93B642BDEF5CF90A40784A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f04f96-996c-48af-92f6-08daaaf120ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 18:56:23.9864
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3xzxPQ6l7O7j+nUa4ciiCjj3DTmrP+6I5xR2TZsauqFOtzLKAGWy6lmxulKIfBGyv6PChQSwTwuNOBMAsqlpFkZYDIvE7myO1/qkPG6xQmg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4984

T24gMDYvMTAvMjAyMiAxNDoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEluIGFuIGVudGlyZWx5
IGRpZmZlcmVudCBjb250ZXh0IEkgY2FtZSBhY3Jvc3MgTGludXggY29tbWl0IDQyOGUzZDA4NTc0
Yg0KPiAoIktWTTogeDg2OiBGaXggemVybyBpdGVyYXRpb25zIFJFUC1zdHJpbmciKSwgd2hpY2gg
cG9pbnRzIG91dCB0aGF0DQo+IHdlJ3JlIHN0aWxsIGRvaW5nIHRoaW5ncyB3cm9uZzogRm9yIG9u
ZSwgdGhlcmUncyBubyB6ZXJvLWV4dGVuc2lvbiBhdA0KPiBhbGwgb24gQU1ELiBBbmQgdGhlbiB3
aGlsZSBSQ1ggaXMgemVyby1leHRlbmRlZCBmcm9tIDMyIGJpdHMgdW5pZm9ybWx5DQo+IGZvciBh
bGwgc3RyaW5nIGluc3RydWN0aW9ucyBvbiBuZXdlciBoYXJkd2FyZSwgUlNJL1JESSBhcmUgb25s
eSBmb3IgTU9WUw0KPiBhbmQgU1RPUyBvbiB0aGUgc3lzdGVtcyBJIGhhdmUgYWNjZXNzIHRvLiAo
T24gYW4gb2xkIGZhbWlseSAweGYgc3lzdGVtDQo+IEkndmUgZnVydGhlciBmb3VuZCB0aGF0IGZv
ciBSRVAgTE9EUyBldmVuIFJDWCBpcyBub3QgemVyby1leHRlbmRlZC4pDQo+DQo+IEZpeGVzOiA3
OWU5OTZhODlmNjkgKCJ4ODZlbXVsOiBjb3JyZWN0IDY0LWJpdCBtb2RlIHJlcGVhdGVkIHN0cmlu
ZyBpbnNuIGhhbmRsaW5nIHdpdGggemVybyBjb3VudCIpDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gLS0tDQo+IFBhcnRseSBSRkMgZm9yIG5vbmUg
b2YgdGhpcyBiZWluZyBkb2N1bWVudGVkIGFueXdoZXJlIChhbmQgaXQgcGFydGx5DQo+IGJlaW5n
IG1vZGVsIHNwZWNpZmljKTsgaW5xdWlyeSBwZW5kaW5nLg0KDQpOb25lIG9mIHRoaXMgc3VycHJp
c2VzIG1lLsKgIFRoZSByZXAgaW5zdHJ1Y3Rpb25zIGhhdmUgYWx3YXlzIGJlZW4NCm1pY3JvY29k
ZWQsIGFuZCAwIHJlcHMgaXMgYSBzcGVjaWFsIGNhc2Ugd2hpY2ggaGFzIGJlZW4gbGFyZ2VseSBp
Z25vcmVkDQp1bnRpbCByZWNlbnRseS4NCg0KSSB3b3VsZG4ndCBiZSBzdXJwcmlzZWQgaWYgdGhl
IGJlaGF2aW91ciBjaGFuZ2VzIHdpdGgNCk1JU0NfRU5BQkxFLkZBU1RfU1RSSU5HUyAoZ2l2ZW4g
dGhlIEtWTSBjb21taXQgbWVzc2FnZSkgYW5kIEkgYWxzbw0Kd291bGRuJ3QgYmUgc3VycHJpc2Vk
IGlmIGl0J3MgZGlmZmVyZW50IGJldHdlZW4gQ29yZSBhbmQgQXRvbSB0b28gKGdpdmVuDQp0aGUg
RmFtIDB4ZiBvYnNlcnZhdGlvbikuDQoNCkl0J3MgYWxtb3N0IHdvcnRoIGV4ZWN1dGluZyBhIHpl
cm8tbGVuZ3RoIHJlcCBzdHViLCBleGNlcHQgdGhhdCBtYXkNCnBvdGVudGlhbGx5IGdvIHZlcnkg
d3JvbmcgaW4gY2VydGFpbiBlY3gvcmN4IGNhc2VzLg0KDQpJJ20gbm90IHN1cmUgaG93IGltcG9y
dGFudCB0aGVzZSBjYXNlcyBhcmUgdG8gY292ZXIuwqAgR2l2ZW4gdGhhdCB0aGV5IGRvDQpkaWZm
ZXIgYmV0d2VlbiB2ZW5kb3JzIGFuZCBnZW5lcmF0aW9uLCBhbmQgdGhhdCB0aGVpciB1c2UgaW4g
Y29tcGlsZWQNCmNvZGUgaXMgbm90IGdvaW5nIHRvIGNvbnNpZGVyIHRoZSByZWdpc3RlcnMgbGl2
ZSBhZnRlciB1c2UsIGlzIHRoZQ0KY29tcGxleGl0eSByZWFsbHkgd29ydGggaXQ/DQoNCn5BbmRy
ZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 21:42:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 21:42:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419379.664128 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi0XM-0006RV-RS; Mon, 10 Oct 2022 21:42:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419379.664128; Mon, 10 Oct 2022 21:42:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi0XM-0006RO-OO; Mon, 10 Oct 2022 21:42:12 +0000
Received: by outflank-mailman (input) for mailman id 419379;
 Mon, 10 Oct 2022 21:42:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zPM=2L=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oi0XL-0006RI-2Q
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 21:42:11 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 644c34ad-48e4-11ed-8fd0-01056ac49cbb;
 Mon, 10 Oct 2022 23:42:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 86E07B80E41;
 Mon, 10 Oct 2022 21:42:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AB6CC433D6;
 Mon, 10 Oct 2022 21:42:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 644c34ad-48e4-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665438127;
	bh=vGkDy70hnp9OjlQ/BdLF7CswwyQr80qNtWkcWXNI9L0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=PYqXduc8FTxN7CVdK/SDITZhOOWSzLbTiIhjIh6uCQI1eMzqF98loXwbql4pf60jM
	 tR+FkA3CEFBF61kvow3+nb31EoTOT4XEcw2r9Izay6tl0DHTFbQQEQCG16eb5JX2rm
	 7oJShy0+hhxAcH27Pnjpb3cer9V4cvurG5QabqdJoRqegnXZLT4w2eBFBPgOS5K0Yx
	 PQvrwFPHwpN31WnJucO2THfWdc5iR84SMBtQsiES8Jg29EQU394lO7/3IlmWCBmEaW
	 98J+EyTxcD1LI2P+PCsqqiNo+pS7xIXIRXX8oDelEEZPkle9SvcNvpstRDrkMSkWh7
	 T/8I9E4Kx+ROw==
Date: Mon, 10 Oct 2022 14:42:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org, 
    sstabellini@kernel.org
Subject: Re: [ImageBuilder v2] Add support for 64-bit addresses/sizes
In-Reply-To: <890ee988-34ff-38c4-3ffa-70abe00d3df8@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210101424330.3690179@ubuntu-linux-20-04-desktop>
References: <20221010072947.8300-1-michal.orzel@amd.com> <4fc23936-4bfd-635c-b3a2-554e280ce884@gmail.com> <f052cf3f-529c-2156-f058-2a320a4f1b02@amd.com> <81ac614e-ca88-5f14-bd76-eaa20c9270bc@gmail.com> <890ee988-34ff-38c4-3ffa-70abe00d3df8@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 10 Oct 2022, Michal Orzel wrote:
> On 10/10/2022 12:48, Xenia Ragiadakou wrote:
> > 
> > 
> > On 10/10/22 12:48, Michal Orzel wrote:
> >> Hi Xenia,
> >>
> >> On 10/10/2022 10:52, Xenia Ragiadakou wrote:
> >>>
> >>>
> >>> On 10/10/22 10:29, Michal Orzel wrote:
> >>>
> >>> Hi Michal
> >>>
> >>>> At the moment, ImageBuilder assumes that all addresses/sizes are
> >>>> 32-bit max. It sets #{address,size}-cells to 0x2 and puts 0x0 as the
> >>>> value for the first cell. Because of that, we cannot specify
> >>>> MEMORY_START and MEMORY_END to be above 32-bits (e.g. to place the images
> >>>> in the upper memory bank).
> >>>>
> >>>> Add support to properly handle 64-bit addresses/sizes:
> >>>>    - add function split_into_halves to split the value passed as a first
> >>>>      argument into upper and lower halves. These are then set as values for
> >>>>      variables passed respetively as the second and third argument,
> >>>
> >>> s/respetively/respectively/
> >> Ok.
> >>
> >>>
> >>>>    - add function split_addr_size to split address and size and form a
> >>>>      string to be passed to dt_set as data argument for reg property.
> >>>>
> >>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> >>>> ---
> >>>> Changes in v2:
> >>>> - redesign a patch based on master-next instead of NXP dynamic assignment patch
> >>>> ---
> >>>>    scripts/uboot-script-gen | 33 ++++++++++++++++++++++++++++-----
> >>>>    1 file changed, 28 insertions(+), 5 deletions(-)
> >>>>
> >>>> diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
> >>>> index b24dca2b7f7e..09d237d192c1 100755
> >>>> --- a/scripts/uboot-script-gen
> >>>> +++ b/scripts/uboot-script-gen
> >>>> @@ -22,6 +22,29 @@ function dt_mknode()
> >>>>        fi
> >>>>    }
> >>>>
> >>>> +# Usage:
> >>>> +# split_into_halves <value> <variable_to_store_upper> <variable_to_store_lower>
> >>>> +function split_into_halves()
> >>>> +{
> >>>> +    local value=$1
> >>>> +    local upper=$2
> >>>> +    local lower=$3
> >>>> +
> >>>> +    eval "$upper=$(printf "0x%X\n" $(($value >> 32)))"
> >>>> +    eval "$lower=$(printf "0x%X\n" $(($value & 0xFFFFFFFF)))"
> >>>> +}
> >>>> +
> >>>> +function split_addr_size()
> >>>> +{
> >>>> +    local addr=$1
> >>>> +    local size=$2
> >>>> +
> >>>> +    split_into_halves $addr addr_upper addr_lower
> >>>> +    split_into_halves $size size_upper size_lower
> >>>> +
> >>>
> >>> Just a minor observation, the variables addr_upper, addr_lower,
> >>> size_upper and size_lower can be declared local.
> >>>
> >> This function is to be called to perform substitution and as such
> >> is always executed within a subshell so no need for local.
> > 
> > So split_addr_size() is supposed to be executed only in a subshell ...
> > Ok I did not think of that. So neither addr or size need to be declared
> > local.
> Exactly, but in ImageBuilder we don't seem to use $1, $2, ... directly so
> that is why I added local only for the arguments passed to this function.

Thanks Michal for the patch and Xenia for the review.

I like to use local, not just because of necessity, but also just as a
way to "tag" variables that we know are not going to be used outside a
specific function. Almost like a naming convention.

I ended up committing a slightly modified version of split_addr_size that
should be simpler and slightly more performant:

function split_value()
{
    local value=$1
    printf "0x%X " "$(($value >> 32))"
    printf "0x%X " "$(($value & 0xFFFFFFFF))"
}

function split_addr_size()
{
    local addr=$1
    local size=$2

    split_value $addr
    split_value $size
}



From xen-devel-bounces@lists.xenproject.org Mon Oct 10 23:19:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 23:19:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419387.664139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi23R-0008Jf-SN; Mon, 10 Oct 2022 23:19:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419387.664139; Mon, 10 Oct 2022 23:19:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi23R-0008JY-Pj; Mon, 10 Oct 2022 23:19:25 +0000
Received: by outflank-mailman (input) for mailman id 419387;
 Mon, 10 Oct 2022 23:19:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4lBe=2L=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1oi23Q-0008JS-7v
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 23:19:24 +0000
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f7350fea-48f1-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 01:19:21 +0200 (CEST)
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 10 Oct 2022 16:19:18 -0700
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
 by orsmga008.jf.intel.com with ESMTP; 10 Oct 2022 16:19:17 -0700
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Mon, 10 Oct 2022 16:19:17 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Mon, 10 Oct 2022 16:19:16 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31 via Frontend Transport; Mon, 10 Oct 2022 16:19:16 -0700
Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by
 edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2375.31; Mon, 10 Oct 2022 16:19:16 -0700
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN9PR11MB5484.namprd11.prod.outlook.com (2603:10b6:408:105::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 10 Oct
 2022 23:19:14 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::b2db:19f5:f440:f6a2]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::b2db:19f5:f440:f6a2%8]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022
 23:19:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7350fea-48f1-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1665443961; x=1696979961;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=/nJSzPrbw8ZQgYvNNmNknEKOMk9hCAwrRnSkpx/282U=;
  b=Lbr1kmdXzlgNDyEtb2e+E2o7gtk1m4aiACbzjhTQeZaatD8mWP85Lm2C
   eeEDooHELcoYKwhRFH6VX8s0c/ZP3ibB3DnWQ1SQa128O2ARg1blzzrmL
   HlvjAyFf5c9ed0Td833dDgytOBz94UiRdtvADq7ae8KU9g1VbnZub0xnp
   5zSA/mqDPhARdw1SFKvsjgdSZEobcpOqMjzLTkVTaXyHBBpAWNvQ241EL
   iB/N53Zh7UAF6UxkxUnD3be+VweDQHrqzXbMp0Qf42D3XBu/bPCDB3dG2
   WNtDxUQ7Za4WDNb4W7yU4+OAtLq8Xzgvt8d1blTRm8PWTgXYfOkCGfd7t
   g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="390666118"
X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; 
   d="scan'208";a="390666118"
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="657120626"
X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; 
   d="scan'208";a="657120626"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a3DdD/ZHS7WVy9Rp/XB4X90lae9Jj3Nd26DfjsO/UXpcFxOMGBWjdFv03tg7umAmhcgNfN/p93F1QLlOwMIGpQE4f2j/dM84NGZSCmecUzZsxrceHYZJBhwBj1uzCpAkfz8FpHkQHslx/i0Hrh2AZhPSJI8LNeAFZIoiHgyqllYr47N9oNeZvLkQTcZG7PojQBzBZKauyIK9o00tBq3stqggYLfDBb+ypcnbmfIPSPbo9CZzquEgGbV0vhqiviK6WMYxdD6uB4tUCrOOyS2VqRijIvFgBjRinf1wQQhlfHmnexYPvQajZjYIZ63q+T/Jjqu55lDnzcjjbPWQBvfk6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/nJSzPrbw8ZQgYvNNmNknEKOMk9hCAwrRnSkpx/282U=;
 b=CqXGmRn5eM78anz5GJ0iu2T1Q8HDEBDI58L/DnTaUXEPic+Ir7yyVsZ+Sb00UYgzBoyG80rvliNVbOCH789u2cRG3jLWfjgGcao3pLHehM/hPLQDTB3u/fV4wDFqGbDKTC5aXk3E0qN3RDj29t2vZ87g59K3/ZOMTE/zUaIlmXLLrcJqqxB1aimAUBlOl6IqFedfZR8qxxTkOm2SxjH/zRy8sAAPKux1zPxNa7zg+lAb27V16ljv2Uclar24W0W6G8ZKDILgvOarMStJAWFmYMLGHrQbTMZGKts9OIR0OaCO4ueOXn0lnF0RyxGVrxcvIkUtvRz+ietCHj/1TxrpUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Nakajima, Jun" <jun.nakajima@intel.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= <roger.pau@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: RE: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
Thread-Topic: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
Thread-Index: AQHY3JKipcgRyk6QSEu91qZECWaYba4IRCqQ
Date: Mon, 10 Oct 2022 23:19:14 +0000
Message-ID: <BN9PR11MB5276393EFC9F9DB8CF9400828C209@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <4c1cc983-6c16-4efc-9686-1e7a79c3122f@suse.com>
In-Reply-To: <4c1cc983-6c16-4efc-9686-1e7a79c3122f@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|BN9PR11MB5484:EE_
x-ms-office365-filtering-correlation-id: 6a2ef2dc-39d9-40cb-e8f2-08daab15d8e4
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Lga4s6INqmomm+c9qIvQ3JJU0StlImZydq+lbh9arc064v7wZx3tb6Po0Q6s2J/EyYEaqYxcBZOfHd3Cr2wZ7dDhkBUNddjBFAuLMJTYI27UoHhGZiC1wBqlVL/gdwBZAddotbPvi+V/uGd09f3oNd4DuLKXBrUDLQyADp8pW+T8N12skyxp339/VqK49dca8gjGQAlzF2DbmJ3SkORWKjAqFzHpXQud8xgKu0mpb+yuFLPrznhw9l9xWwai/17HOJF42QO6GOIfsVDEoSidawhj7FSya6vqux7uxD9mrnk+rqyhywXlhYp5FlbxBG5z81+I+mT5epSJd9QJJGDmelceJ/p5oXvYwXDfnntYNxeJ2Y+CVlioO89rPFtpUyKTGqucw/eTUARxRXf4PnDpSCQnIFsgSvwn8hFhntEQ6JiapnUwowjj7JdvJkgZF8S8umXfPaRailp4W9BtzIMUs4GdqW/ZIjB7+3gTPq6ZBWnNNS7GI2V5CJWkkQ2igvwMYT/F2APTYcOX6y/SlqORC+w1TXAY80IwX6dT1aHJlsq0pgLAxdfvBOBHgsIKCiPAmG8/jT756UXwzDbKTxMcIntkkX2XRYAzktZbqsH6B/ydDq67IWo/9C3qXZbzvqVake8TCFFZ9R4dq8TdOUNo455pD+/Vi0CXf1bPl93bKhQY7g3PAJ4fc61pm0cwG/IjV7wSEjdQCGnx/T20H6iQcYNudt8I2mLLPBkw06ffWNuJmrYvQfaYdhejo+zCnj9DoFYp0FnRLFZJemH5NjDqeg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(376002)(366004)(346002)(451199015)(64756008)(316002)(4326008)(8676002)(66476007)(66446008)(76116006)(110136005)(66946007)(478600001)(38100700002)(33656002)(122000001)(82960400001)(26005)(2906002)(9686003)(41300700001)(66556008)(6506007)(71200400001)(7696005)(86362001)(5660300002)(54906003)(38070700005)(52536014)(4744005)(186003)(8936002)(55016003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cHNVRzhsQ1E5eENJL3NxbERrb25jNWJFVEg5TU9jR2pvT2d6UzBDSER5Vm5j?=
 =?utf-8?B?OGFMRkl5dms1bUxSR3ZYVjlScmFlbHpwajMvM1V0YXlBM3NRODlEa1JWcFFZ?=
 =?utf-8?B?SGpvQzExQXFnVEtmdTVjNTZTaUtwcHZvWlZBb3Qyb0JUQXowNmRnT1hhWndS?=
 =?utf-8?B?ZWhUK2VBbTU0cmRJN1BQemNnNG5laTRnaHRmazQvajBjZ1BFY1lxQWxHck5E?=
 =?utf-8?B?MlBVbmhmRnZ3Slp6b1VNa0w2Y2doc1FFanpKWjJReDdrUkcwQlJMd0h3TDEy?=
 =?utf-8?B?U29QOFlDeVVLa0JGMVRQQkJFK2FVSWF2US9SOVhHa1BiK1h4dFBNZEdDQ3lv?=
 =?utf-8?B?ajNHVWxJRTFPVG5xUDJUTEJRbXpFUjRnVGZFb2U4bXA4VnN6cU9aUFM5aUVH?=
 =?utf-8?B?M0svNkZ6NjRHeExDQVd3eGNxY0tTSGZzcGw1V09qTU9qNzJxRFUxYng2dHFt?=
 =?utf-8?B?bTdWcnVzOGU1OUJzYVNoSnROWHBlaGZNcVAxRzVKK2daWEVHeHlhYit0dEJX?=
 =?utf-8?B?NU1jcWlpVko2UTdDVlQxeVFWeDRsRWhGanJ5cHhyaXNDOFBBSytSNWtEU3Vm?=
 =?utf-8?B?OCt4U0VJbTVsVC9mdlVmS3I1TGlXT3ZSWXV6SWcwVkRESGNWUU1kbGxMMDR5?=
 =?utf-8?B?d2tYaGNqeDdwNkdxTjUrdTFtbUZmcWhRcDFCdnZZRWFBY2Mzeko5Z1Bod0Mw?=
 =?utf-8?B?dnVkd3J3andRSE83VnJaQXpMUUFSYnFKc3E0dEVHSm5jZHhUT2ZyYXU5ZVRC?=
 =?utf-8?B?bkFMVXJaNFFRaFYxVlcyV0Zhb0dGTFUzZktZejhDYmVDSHdrcFcyR2lXS0t6?=
 =?utf-8?B?djJjanNhSS9iSTJnYVRvVVhGRm81RFA2RVN6Nm5sTjA4VENpYnlicGQ5VGxE?=
 =?utf-8?B?N2U2T3ZFb3Z2UkNJdXpnTWx0VWxzV3hyMk9vOTAyTzluZjRqWUNlRzJLOUN0?=
 =?utf-8?B?b1lzT2gvemUrTm04UG5FQ2tVbmEzK3RVU1dhSmticDdpcE1UN005bThaSjA1?=
 =?utf-8?B?UnN5dm0xRHY4YVBGTnF4aVlvbmF4TWdDY2FoaDArN3RUQlVOYmw4MWllVldV?=
 =?utf-8?B?VEdMOUZqUGlEcjliZTB1SFlxQmlxNGx1UjNDbW1Pemk4UDVBOGJjcGdyVTJF?=
 =?utf-8?B?d1VpOWhzdjV4ZXBDL0RsMXo3ZENYdU0rM2p3WmM3c0JzSTVTKy8wYTFab2M0?=
 =?utf-8?B?VTZIcFNkSGNTZHh0OXJ4bFNoM080MERYVk9hb2J2QmJKdndTYlJkb3ZPd1k2?=
 =?utf-8?B?b0Q1c3pReENHeHoxc0dJZDJTcFhGMHdGK3hxRUxsTk5jdGxTc3JDZFIySUNG?=
 =?utf-8?B?ZzJFa09XeG5ZNGF6bGxPNVpTK1NBTHdMUUJ4QmpnUHYzbG9Xc3VQUGlMSlR3?=
 =?utf-8?B?aGxPWjZzSjlkSjhRQ1dma0Q2bnN2VWxZdGpYeVFjQjJJRHNxT01xdUtYcHdY?=
 =?utf-8?B?Y1VmY285WnRoZmZUV242RXZCRXFYc1crVjZTTUNodkZ4U2E1dVdPLzlHeTNH?=
 =?utf-8?B?VWZrVWRhREh3WXBhMVlkZDl1ZFlEK0ZwWmdPUlExd1hOUWdpWm85VXovandX?=
 =?utf-8?B?V2VZYXdtK09RMktwellQd3VqTTMrSEg5cEhvbm13ekVtZU1oN3c1TS9yZ2No?=
 =?utf-8?B?UjBQSUJ5MWVUK0NtY3d5QVNBQzkwdHJwSGJkMkxPTlNNYTVzK2xHUzRmNGty?=
 =?utf-8?B?cSsxQzJiazc2QWkrbUI1bVF1cWlYR0dDV0pwWkl2T2QxQVIxQUhqb042NFFa?=
 =?utf-8?B?WTI5bG9sSSt6Y0VVekZoaEQ5eU1rdXVTNWVYRThiSTZCcXV0N3RhL256S0Rt?=
 =?utf-8?B?WFZnSjJoQnk3REVNQm1kOGxDODlMa053R3dueHBHZ3VqQ1VvWGMvN0RnWHB6?=
 =?utf-8?B?dHFsVS9iOFh1N0F2WHhHUk1XSkhUUkZnZTBDVWdPYzEwQUJRTENNajVxZ056?=
 =?utf-8?B?N0FQWE92TnRySVl6S2hEK1BJOW1OcFlWeWJrcEYwZkM2c3ljWGZ6a3J2N3RH?=
 =?utf-8?B?TXV4azNIVXBGWWlmWjhuQ0Q4OXdLYXduNGgvMkhQZm9qYWRCdzhCNjlPYldt?=
 =?utf-8?B?cnFDRjU4OXFTK3BTWWpSdFRWMEJFME11a3VrYjBnZkNkVjVTRFh4ODdhUnZv?=
 =?utf-8?Q?RB5AuHTqqOURL4E+d92FS8IJV?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a2ef2dc-39d9-40cb-e8f2-08daab15d8e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 23:19:14.7265
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rMAsrQwwtkXyqGeFlOy2UICcqipE95X5/SjzaNovHkJIgghSlsCA0QvQX+oE5iwODatlYGAeE55faDrdZ/YPUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5484
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IE1vbmRheSwg
T2N0b2JlciAxMCwgMjAyMiA2OjI1IFBNDQo+IA0KPiBXaXRoIHRoZSBhZGRpdGlvbiBvZiB2bXhf
YWRkX21zcigpIGNhbGxzIHRvIGNvbnN0cnVjdF92bWNzKCkgdGhlcmUgYXJlDQo+IG5vdyBjYXNl
cyB3aGVyZSBzaW1wbHkgZnJlZWluZyB0aGUgVk1DUyBpc24ndCBlbm91Z2g6IFRoZSBNU1IgYml0
bWFwDQo+IHBhZ2UgYXMgd2VsbCBhcyBvbmUgb2YgdGhlIE1TUiBhcmVhIG9uZXMgKGlmIGl0J3Mg
dGhlIDJuZCB2bXhfYWRkX21zcigpDQo+IHdoaWNoIGZhaWxzKSBtYXkgYWxzbyBuZWVkIGZyZWVp
bmcuIFN3aXRjaCB0byB1c2luZyB2bXhfZGVzdHJveV92bWNzKCkNCj4gaW5zdGVhZC4NCj4gDQo+
IEZpeGVzOiAzYmQzNjk1MmRhYjYgKCJ4ODYvc3BlYy1jdHJsOiBJbnRyb2R1Y2UgYW4gb3B0aW9u
IHRvIGNvbnRyb2wNCj4gTDFEX0ZMVVNIIGZvciBIVk0gSEFQIGd1ZXN0cyIpDQo+IEZpeGVzOiA1
M2E1NzBiMjg1NjkgKCJ4ODYvc3BlYy1jdHJsOiBTdXBwb3J0IElCUEItb24tZW50cnkiKQ0KPiBS
ZXBvcnRlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4g
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdl
ZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 23:51:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 23:51:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419393.664152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi2Xw-0004NZ-DE; Mon, 10 Oct 2022 23:50:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419393.664152; Mon, 10 Oct 2022 23:50:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi2Xw-0004NS-7S; Mon, 10 Oct 2022 23:50:56 +0000
Received: by outflank-mailman (input) for mailman id 419393;
 Mon, 10 Oct 2022 23:50:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zPM=2L=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oi2Xu-0004NJ-QN
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 23:50:54 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f6b1baf-48f6-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 01:50:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 74A6BB81100;
 Mon, 10 Oct 2022 23:50:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 577DEC433C1;
 Mon, 10 Oct 2022 23:50:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f6b1baf-48f6-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665445850;
	bh=ql01mw8O2lPAPWEa8qMQjpv4fx+WlR5ssKGLIryOI/g=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=JdaXsEGVg8zBNZIPoLrFnFUnksvuslpVkkuWLOC94XtYhwsVQKidu+zOyk/68eZDT
	 EWcsqrPZwu4nYeKTPNdi6qqwELv7P1eIfbqQ9eNWtSSNu/LDyOK2gO1xsq8OKWv+p/
	 zrBlR67FoMgzDLmKWzfkOPGguvyQFDYcN7dRAw2SkhXsbFiFVGlPbgvJN9CfJYrzrT
	 /yFcPxgJU2o4lpe2zijYtuMoPokel13H62YOpkACsTLjBUakGNr2f1VJeW/uY4vk3v
	 JT6pKXxvJpsnD/jUUupaHAaTKaJwzMw3WCxbqr+E1xnAXj466Gij3DMA3esCwOStJ1
	 JfiOAWPjmSnsQ==
Date: Mon, 10 Oct 2022 16:50:46 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Leo Yan <leo.yan@linaro.org>
cc: Xen Develop <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Mathieu Poirier <mathieu.poirier@linaro.org>, 
    Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>, 
    jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, 
    wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
Message-ID: <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

+Xen/Linux maintainers


On Mon, 10 Oct 2022, Leo Yan wrote:
> Hi there,
> 
> I tested the networking performance on my Arm64 platform in Xen
> virtual machine, below I will try to give out summary for testing
> result and share some analysis, at the end I want to check a bit
> from the community and get suggestion before I can proceed.
> 
> First of all, if you want to know more details for the profiling, you
> could access the slides:
> https://docs.google.com/presentation/d/1iTQRx8-UYnm19eU6CnVUSaAodKZ0JuRiHYaXBomfu3E/edit?usp=sharing
> 
> ## Testing summary
> 
> The TL;DR is that I used two tools: netperf and ddsperf to test the
> networking latency and throughput for Xen Dom0 and DomU, the below
> result shows the performance for sending data from a Xen domain (Dom0
> or DomU) to my x86 PC respectively, and performance is poor when
> transmit data from Xen DomU (Note, I used the default networking
> bridge configuration when launch Xen VM).
> 
>   Throughput result:
> 
>     Profile     netperf (Mbits/sec)    ddsperf (Mbits/sec)
>     Xen-Dom0    939.41                 > 620
>     Xen-DomU    107.73                 4~12
> 
>   Latency result:
> 
>     Profile     ddsperf's max ping/pong latency (us)
>     Xen-Dom0    200 ~ 1400
>     Xen-DomU    > 60,000
> 
> ## Analysis
> 
> The critical thing for the performance is low level network driver if
> it uses synchronous or asynchronous mode for skb transferring.
> 
> When we transfer data from my x86 machine to Xen DomU, the data flow is:
> 
>   bridge -> xenif (Xen network backend driver)               => Dom0
> 	      `> xennet driver (Xen net forend driver)       => DomU
> 
> In this flow, Xen network backend driver (in Dom0) copies skb into the
> mediate buffer (gnttab_batch_copy()) and notify Xen VM by sending rx
> irq, the key point is the backend driver doesn't wait for Xen VM to
> process the skb and directly return to user space, therefore, Xen Dom0
> and DomU work in asynchronous mode in this case (Dom0 doesn't need to
> wait for DomU), the duration for handling a skb is 30+ us.
> 
> Conversely, if transmit data from Xen DomU, the flow is:
> 
>            DomU                    |               Dom0
>   ---------------------------------+------------------------------------
>   xennet driver receives skb       |
>     `> send tx interrupt to Dom0   |
>                                    |  xenif respond tx interrupt
> 	                           |  Copy skb into mediate buffer
>                                    |  Notify DomU (send tx irq)
>   xennet driver handle tx irq      |
>   free skb                         |
> 
> So we can see when DomU sends out packets, it needs to wait for Dom0 to
> process the packets, until Dom0 notifies DomU that packet has been
> processed the net forend driver in DomU releases skb.
> 
> This means it's a long way to process skbs: Xen DomU and Dom0 work
> in synchronous mode, the forend driver in DomU sends out skb and
> notifies Dom0, Dom0 handles skb and notifies back to DomU, finally DomU
> knows the skb has been processed and releases it.  The duration between
> sendind and releasing a skb is about 180+ us.

180us is not great but above you wrote > 60,000 us. In what ways the two
measurements differ?


> ## Questions
> 
> Given Xen network driver has been merged in Linux kernel 2.6 (back in
> 2007), it's very unlikely I am the first person to observe this issue.
> 
> I think this is a common issue and not specific to Arm64 arch, the
> reason is the long latency is mainly caused by Xen networking driver
> and I did't see the Xen context switching on Arm64 is abnormal (I saw
> it takes ~10us for context switching between Xen domains).
 
Context switching between domains shouldn't come into the picture. For a
latency measurement like that I would make sure to:

- use the null scheduler, sched=null
- use vwfi=native

This way, we can be sure both domains are running and there are no
context switches. It should lead to the best latency measurements. Also
this is the configuration we use by default at Xilinx.


> Could anyone confirm if this is a known issue?

This is not something that was discussed recently as far as I know.


> The second question is how to mitigate the long latency when send data
> from DomU.  A possible solution is the Xen network forend driver copies
> skb into mediate (bounce) buffer, just like what does in Xen net
> backend driver with gnttab_batch_copy(), in this way the forend driver
> doesn't need to wait for backend driver response and directly return
> back.

About this, I am not super familiar with drivers/net/xen-netfront.c but
I take you are referring to xennet_tx_buf_gc? Is that the function that
is causing xennet_start_xmit to wait?

I didn't think that waiting for the backend is actually required. I
mean, in theory xennet_start_xmit could return without calling
xennet_tx_buf_gc, it is just an optimization. But I am not sure about
this.


> But here I am not clear for the mechanism for Xen grant table,
> especially if the Xen grant table is only writtable from Dom0, then it
> would be hard for us to optimize the forend driver in DomU by directly
> copying skb into the grant table.  Any thoughts for this?

The grant table is a mechanism for the frontend to "grant" access to a
specific page to the backend. It is used for dynamic memory sharing
between frontend and backend:

- frontend grants a page
- frontend copies grant reference to shared ring
- backend receives request and map granted page
- backend process request
- backend complete request and unmap granted page, send notification
- frontend un-grant the page

This is the regular process. In addition, for performance reason, it is
also possible to request Xen to copy a grant to the backend. This is
less common, but it is used by PV network, specifically by
gnttab_batch_copy. It is an alternative to mapping which is expected to
be faster for networking.


From xen-devel-bounces@lists.xenproject.org Mon Oct 10 23:58:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 10 Oct 2022 23:58:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419399.664162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi2f0-00059l-1N; Mon, 10 Oct 2022 23:58:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419399.664162; Mon, 10 Oct 2022 23:58:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi2ez-00059e-Un; Mon, 10 Oct 2022 23:58:13 +0000
Received: by outflank-mailman (input) for mailman id 419399;
 Mon, 10 Oct 2022 23:58:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zPM=2L=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oi2ey-00059Y-QW
 for xen-devel@lists.xenproject.org; Mon, 10 Oct 2022 23:58:12 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 64b908fe-48f7-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 01:58:11 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 31CAECE0E73;
 Mon, 10 Oct 2022 23:58:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04D1AC433C1;
 Mon, 10 Oct 2022 23:58:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64b908fe-48f7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665446287;
	bh=CHWkXRVtBi6XSq8aIpc4PaWg12g+VGGkTIIgiPmrE3s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=T3d2KUiJ1vXkGGemvkl3dLBoI2Nu9pNcEQtrYSoePFjTH2cDp2Hys2/eLmuSZiqKR
	 GAFCzV+8Zlm3JtDpOWRzPnkl5YpC9cGp3n7xy3TDr338jxD0UbqV54Bq6YWppaht/m
	 d3I1jW3eC4quCrjagwk12bBBwBQHNp98YCk23g6wQ20Hyc8rW4wQpjcMrxswWOqit1
	 8Axl/+moTo/ZxjLmWsmfvBDKZhj+ZBJ+Ph4LeWqBKyG4WFpBkZygwB/AslR+GaVhHV
	 rvhi+dcdxPcnCQIhszecY/5GGu7bDcX8fFyWwAKZAt67CO9CgLKUU4vcKU/KRfmrV7
	 w4H0FaG6er7Ig==
Date: Mon, 10 Oct 2022 16:58:04 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: Julien Grall <julien@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Volodymyr Babchuk <volodymyr_babchuk@epam.com>, 
    Henry Wang <Henry.Wang@arm.com>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
In-Reply-To: <319015d6-ec1c-3500-2437-00d40fe4d2c3@suse.com>
Message-ID: <alpine.DEB.2.22.394.2210101657180.3690179@ubuntu-linux-20-04-desktop>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com> <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com> <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com> <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org> <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
 <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org> <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com> <82963a1c-3301-72ff-e995-77c30ec5a64b@suse.com> <a957dfbe-c4c4-c8cc-93c5-616a44fe1797@xen.org> <319015d6-ec1c-3500-2437-00d40fe4d2c3@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-834925715-1665446287=:3690179"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-834925715-1665446287=:3690179
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Mon, 10 Oct 2022, Jan Beulich wrote:
> On 08.10.2022 21:08, Julien Grall wrote:
> > On 06/10/2022 15:11, Jan Beulich wrote:
> >>> ... the space cannot become ordinary RAM, then such a precaution
> >>> wouldn't be necessary. After all hiding EfiACPIReclaimMemory from
> >>> Dom0 just because it can't be mapped WB wouldn't be very nice
> >>> either. I guess I'll submit v2 with this part of the change left
> >>> as it was.
> >>
> >> And while already in the process of committing the patch I came to
> >> realize that if the WB conditional isn't supposed to move, isn't
> >> the change done for Arm then wrong as well? Shouldn't it then be
> >>
> >>          if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
> >>               (desc_ptr->Attribute & EFI_MEMORY_WB) &&
> >>               (desc_ptr->Type == EfiConventionalMemory ||
> >>               ...
> >>
> >> leaving the EfiACPIReclaimMemory case entirely unaffected by the
> >> change?
> > 
> > IIUC, the concern is the region EfiACPIReclaimMemory could have the attribute EFI_MEMORY_RUNTIME. Is that correct?
> 
> Yes, ...
> 
> > Given that the memory is reclaimable, I am not sure why it can also have this atribute set (to me it means the opposite).
> 
> ... at least on x86 all sorts of strange/bogus type/attribute combinations
> have been observed.

Yeah... it is a good idea to be able to cope with strange and bogus
firmware tables as it is known to happen
--8323329-834925715-1665446287=:3690179--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 00:26:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 00:26:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419405.664173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi36M-00011M-Gn; Tue, 11 Oct 2022 00:26:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419405.664173; Tue, 11 Oct 2022 00:26:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi36M-00011F-Cq; Tue, 11 Oct 2022 00:26:30 +0000
Received: by outflank-mailman (input) for mailman id 419405;
 Tue, 11 Oct 2022 00:26:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0qgQ=2M=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oi36K-000115-6c
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 00:26:28 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5661a4f1-48fb-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 02:26:25 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8399460FCF;
 Tue, 11 Oct 2022 00:26:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BE88C433C1;
 Tue, 11 Oct 2022 00:26:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5661a4f1-48fb-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665447983;
	bh=tU9BBGGHJTh3lSTNEV/+WssVkNmezsErJAYxoqNdPO4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pFKMNJtSYDlnvtPk74/+SUs8cieOy8iISQrijy60n++P88aQTo1OvAYQKcdVTj6KE
	 QIsehGDYBQP+hLF5h55JPid9kRV5M2KWkfwKa9YVXQTISA2ao+27ysUxaPosztihNk
	 Qod6694nQKrx+OFlnz/qX6T3+CQNscu8scd4x5zdRF8tGOVxiHTAXS8WlDpCrXiocF
	 XBSnhU77FOunMmGOQ2kMlbOjr5xopn4U91JBVByjqneT0Khura2EV8U0DH+BGWWaPW
	 Nq7nd6Hc9NOSMsHOFrtYTgPgpI2fgOmZytkfTLR6MM7txYBUctpMMWq5xcMLpYt4mV
	 THFeOFtrPZnhw==
Date: Mon, 10 Oct 2022 17:26:19 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, wl@xen.org, jbeulich@suse.com, 
    george.dunlap@citrix.com, andrew.cooper3@citrix.com, 
    bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, roger.pau@citrix.com, 
    Stefano Stabellini <stefano.stabellini@amd.com>
Subject: Re: [PATCH v3 4/4] Remove extra copies of licenses and license
 headers
In-Reply-To: <b87e4263-4018-b840-74be-965aec89d187@xen.org>
Message-ID: <alpine.DEB.2.22.394.2210101716390.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop> <20221008001544.78302-4-sstabellini@kernel.org> <b87e4263-4018-b840-74be-965aec89d187@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sun, 9 Oct 2022, Julien Grall wrote:
> Hi Stefano,
> 
> On 08/10/2022 01:15, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefano.stabellini@amd.com>
> > 
> > Remove the extra copy of the GPL license and license copyright headers
> > from CONTRIBUTING and the top-level COPYING.
> > 
> > Mention of the LICENSES/ directory and also mention the SPDX tag.
> > 
> > SPDX support is still in progress and COPYING files in subdirectories
> > still need to be updated.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> > ---
> > Patch new in v3
> > ---
> >   CONTRIBUTING | 150 ++--------------------
> >   COPYING      | 351 +--------------------------------------------------
> >   2 files changed, 17 insertions(+), 484 deletions(-)
> > 
> > diff --git a/CONTRIBUTING b/CONTRIBUTING
> > index 6ec146baf0..7b6b03fb96 100644
> > --- a/CONTRIBUTING
> > +++ b/CONTRIBUTING
> > @@ -19,10 +19,6 @@ Most notably:
> >    - tools/xl           : LGPL v2.1
> >    - xen/include/public : MIT license
> >   -The COMMON COPYRIGHT NOTICES section of this document contains
> > -sample copyright notices for the most common licenses used within
> > -this repository.
> > -
> 
> How about replacing this section with something like:
> 
> " See LICENSES/ for a list of licenses and SPDX tags currently used."

Good idea


> >   When creating new components, new files, or importing code please follow
> >   the conventions outlined below. As a general rule, whenever code using a
> >   license other than GPLv2 is introduced, attention must be drawn to the
> > @@ -32,20 +28,22 @@ deviation. Any new code must be GPLv2 compatible.
> >   New components
> >   --------------
> >   -When creating new components and directories that contain a
> > -significant amount of files that are licensed under licenses other
> > -than GPLv2 or the license specified in the COPYING file, please
> > -create a new COPYING file in that directory containing a copy of the
> > -license text and a rationale for using a different license. This helps
> > -ensure that the license of this new component/directory is maintained
> > -consistently with the original intention.
> > +When creating new components and directories that contain a significant
> > +amount of files that are licensed under licenses other than GPLv2,
> > +please create a new COPYING file in that directory with the rationale
> > +for using a different license. This helps ensure that the license of
> > +this new component/directory is maintained consistently with the
> > +original intention.
> 
> I don't understand why the wording "or the license specified in the COPYING
> file" is dropped. To me, the sentence was indicating that it is not necessary
> to create a COPYING file in every sub-directory if the license is not GPLv2
> and it matches the license of a parent directory.
> 
> Do you plan to remove COPYING completely?

No, I don't plan to remove COPYING completely. COPYING is useful to tell
the user what license to choose. I only meant to clarify that COPYING
doesn't need to have a full copy of the license again. An SPDX tag would
be enough. I can change it to:

---
When creating new components and directories that contain a
significant amount of files that are licensed under licenses other
than GPLv2 or the license specified in the COPYING file, please
create a new COPYING file in that directory containing the SPDX tag
and a rationale for using a different license. This helps ensure that
the license of this new component/directory is maintained consistently
with the original intention.
---


> >     New files
> >   ---------
> >   -If specific files that differ from the license in a directory are
> > introduced,
> 
> This is fine to drop but ...
> 
> > -exceptions should be highlighted and discussed in the commit message or
> > cover
> > -letter introducing the file.
> 
> ... I think this should be kept because we want to have justification why the
> license of a file doesn't match the license of the directory.

Good idea


> > +New files should start with a single-line SPDX comment to express the
> > +license. The following comment and license are recommended:
> 
> Someone reading this may think that a new file in libxl wants to be GPLv2. So
> I would add in parentheses that the license may be different in some
> directory.
> 
> Similarly, I think this should be stronger than recommended. The SPDX should
> be a *must* and for the license there are effectively little leeway in which
> one we could use for existing components.
> So how about:
> 
> "For instance, if the file is GPLv2, the comment would look like:
> 
> /* SPDX-License-Identifier... */
> 
> The recommended license of a directory will depend on the COPYING file. If the
> new file is using a different license, this should be highlighted and
> discussed in the commit message or cover letter introducing the file.
> "
> 
> Cheers,
> 
> -- 
> Julien Grall
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 02:38:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 02:38:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419412.664184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi59c-0005Nw-So; Tue, 11 Oct 2022 02:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419412.664184; Tue, 11 Oct 2022 02:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi59c-0005Np-P4; Tue, 11 Oct 2022 02:38:00 +0000
Received: by outflank-mailman (input) for mailman id 419412;
 Tue, 11 Oct 2022 02:37:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oi59b-0005Nf-NT; Tue, 11 Oct 2022 02:37:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oi59b-00053Z-KO; Tue, 11 Oct 2022 02:37:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oi59b-0003ra-06; Tue, 11 Oct 2022 02:37:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oi59a-000599-VR; Tue, 11 Oct 2022 02:37:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=flPFdkPyYuI9sJL8vs+x6IyQ+OE6sqQNB9tHK6m9yWA=; b=PRHy9bpVq1Jw2H9xMl42q6Md11
	L8YYkM+XmswJroDThWNROnHPGtDdptrJkzwZMI9DsUc5uOADBAXF8vpMnjBsV0OTwG+8r1XSUVRN/
	NJAluTJra6g3YkmeCUHmvAkVFtez8RZGfNFwhiF7furAuVoVPjF+Mxt6I9ULa3yDs/MI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173487-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173487: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4de65c5830233e7a4adf2e679510089ec4e210c7
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 02:37:58 +0000

flight 173487 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173487/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                4de65c5830233e7a4adf2e679510089ec4e210c7
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    3 days
Failing since        173470  2022-10-08 06:21:34 Z    2 days   10 attempts
Testing same since   173487  2022-10-10 19:12:23 Z    0 days    1 attempts

------------------------------------------------------------
685 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 55578 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 03:42:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 03:42:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419422.664195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi69q-0004e9-KU; Tue, 11 Oct 2022 03:42:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419422.664195; Tue, 11 Oct 2022 03:42:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oi69q-0004e2-G6; Tue, 11 Oct 2022 03:42:18 +0000
Received: by outflank-mailman (input) for mailman id 419422;
 Tue, 11 Oct 2022 03:42:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xsRG=2M=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1oi69o-0004dw-61
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 03:42:16 +0000
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0cda750-4916-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 05:42:13 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id EFE665C0151;
 Mon, 10 Oct 2022 23:42:11 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 10 Oct 2022 23:42:11 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 10 Oct 2022 23:42:11 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0cda750-4916-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=
	1665459731; x=1665546131; bh=PNRzeYBxnqmwQZTl997sPEK/gSvhfY9baZ4
	KGgodxYk=; b=NUsRfSiQHRdJpvyEuXFl0W3rLydfl68+aLCgmUKBS/KGQCZMfKU
	c/oajzF/woMQzNTW5jjMdsQ/bgnBiR4rl90TOeLb5x6/31h+YeCRjmHonNRmGVtR
	miM+AEKPxjPRLI26+V9tOfIeN/tqIczQttgtucP/ipb6OhPF8wC07IpDO2vWbXfJ
	hOgv13YkOTCvMzaesN/adJS+W4qSpucfcPKXIDQt/QBCu7uR/teCRvHYPhRLi54I
	mH4gEOAscAAmJzfaAkap6QkuloOtTkxbbWnFgz5V5vMZNyo9rgEA68N51hgsY1wm
	FHr2dYPszgnzAC/R6YLFTVuZtcnK0N+HUsQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:feedback-id:feedback-id:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; t=1665459731; x=1665546131; bh=PNRzeYBxnqmwQ
	ZTl997sPEK/gSvhfY9baZ4KGgodxYk=; b=fxu690SRE8UDM/+dQ9J4CwvlydXFg
	g4S0qhCXW2FKOJfsUaAl/b+W5gK9KdVZGPcYZEd2xe10fjSw6rCG9/8c+NbapH7G
	1XSkQQLe8zSw+6TN1vnkKy96R2sOcCpfygofWCOzvkcXXb5jiJyc7tAU283PjNH+
	y9fISvzvSBTDaguVwMH/QfKRFTipfPvuy2CQRTImpYKFZBlR6wEDlt3xyVO/MikO
	r9eFzRssDE65zTkrQbONYzAHLXzlzoUzBWKYcrTQj7alyOI2RITHSUGlrOB/0pfm
	ZrJ2WFgssnqA/lq/DJ1uZX97232dldU+UFwoNk+Nk2pEMvWr7w0ZU1EWQ==
X-ME-Sender: <xms:E-ZEY4YFNpKsmm5rXdvgOXVSxAVTt62gWD3RMYgYa9Xw0vIpzezyQg>
    <xme:E-ZEYzbadF1SHzg8tnZF0OWihgn4ZufYOXpSHvxEpD8VF6AaY09nY4vUg2zqUyquc
    9EqTgwIUoioh0I>
X-ME-Received: <xmr:E-ZEYy_F9btHzcM5GLgEDSDNs9_EVSD4A8zkzbjHlhUbIWDD-G9h6gMGwX52StUEd-VXdSzaDQ2K>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejhedgjedvucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghmihcu
    ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh
    hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvhfeltddtgedvtdefvdelteehtdeh
    teeugfdtjeehleffkedvjeevkeejkeekgfenucffohhmrghinhepgigvnhhprhhojhgvtg
    htrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho
    mhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:E-ZEYyqbBKUy2NQ4LHNNtCEy4YRqR4TL6M00xyh5OeC7O8zMX91jHg>
    <xmx:E-ZEYzqRWRlpFwX8GtDZ3nq7CGOIpZCRtcz4OJhV2wtZQ3YO2dUltA>
    <xmx:E-ZEYwSO-_EyvTHtwSHGC3QD4NuVaJp12Pjtbfb9PYYQwhojItw80Q>
    <xmx:E-ZEY8AhYMCbDrPyAD2mjjn8mJXNGNvkS_t922JXde5zH23rjVHM1g>
Feedback-ID: iac594737:Fastmail
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	Jan Beulich <jbeulich@suse.com>,
	Ard Biesheuval <ardb@kernel.org>
Subject: [PATCH v2] Use EfiACPIReclaimMemory for ESRT
Date: Mon, 10 Oct 2022 23:42:03 -0400
Message-Id: <ce73ae2fa148c5d79a038275b0983d24537e97de.1665458679.git.demi@invisiblethingslab.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

A previous patch tried to get Linux to use the ESRT under Xen if it is
in memory of type EfiRuntimeServicesData.  However, this turns out to be
a bad idea.  Ard Biesheuvel pointed out that EfiRuntimeServices* memory
winds up fragmenting both the EFI page tables and the direct map, and
that EfiACPIReclaimMemory is a much better choice for this purpose.

Link: https://lists.xenproject.org/archives/html/xen-devel/2022-09/msg01365.html
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
---
Changes since v1:

- Add link to Ard Biesheuvel’s post on xen-devel
- Expand comment to mention buggy firmware that place the ESRT in
  EfiBootServicesData.

 xen/common/efi/boot.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index db0340c8e2628314226c618dda11ede4c62fdf3b..b3de1011ee58a67a82a94da050eb1343f4e37faa 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -601,11 +601,14 @@ static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc)
     if ( physical_start > esrt || esrt - physical_start >= len )
         return 0;
     /*
-     * The specification requires EfiBootServicesData, but accept
-     * EfiRuntimeServicesData, which is a more logical choice.
+     * The specification requires EfiBootServicesData, but also accept
+     * EfiRuntimeServicesData (for compatibility with buggy firmware)
+     * and EfiACPIReclaimMemory (which will contain the tables after
+     * successful kexec).
      */
     if ( (desc->Type != EfiRuntimeServicesData) &&
-         (desc->Type != EfiBootServicesData) )
+         (desc->Type != EfiBootServicesData) &&
+         (desc->Type != EfiACPIReclaimMemory) )
         return 0;
     available_len = len - (esrt - physical_start);
     if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) )
@@ -1144,18 +1147,19 @@ static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable)
     for ( i = 0; i < info_size; i += mdesc_size )
     {
         /*
-         * ESRT needs to be moved to memory of type EfiRuntimeServicesData
+         * ESRT needs to be moved to memory of type EfiACPIReclaimMemory
          * so that the memory it is in will not be used for other purposes.
          */
         void *new_esrt = NULL;
-        size_t esrt_size = get_esrt_size(memory_map + i);
+        const EFI_MEMORY_DESCRIPTOR *desc = memory_map + i;
+        size_t esrt_size = get_esrt_size(desc);
 
         if ( !esrt_size )
             continue;
-        if ( ((EFI_MEMORY_DESCRIPTOR *)(memory_map + i))->Type ==
-             EfiRuntimeServicesData )
+        if ( desc->Type == EfiRuntimeServicesData ||
+             desc->Type == EfiACPIReclaimMemory )
             break; /* ESRT already safe from reuse */
-        status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size,
+        status = efi_bs->AllocatePool(EfiACPIReclaimMemory, esrt_size,
                                       &new_esrt);
         if ( status == EFI_SUCCESS && new_esrt )
         {
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 07:52:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 07:52:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419429.664206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiA3s-0007Sm-Pu; Tue, 11 Oct 2022 07:52:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419429.664206; Tue, 11 Oct 2022 07:52:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiA3s-0007Sf-Mv; Tue, 11 Oct 2022 07:52:24 +0000
Received: by outflank-mailman (input) for mailman id 419429;
 Tue, 11 Oct 2022 07:52:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W/N3=2M=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1oiA3q-0007SZ-UL
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 07:52:23 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9cd47189-4939-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 09:52:11 +0200 (CEST)
Received: from DB9PR06CA0029.eurprd06.prod.outlook.com (2603:10a6:10:1db::34)
 by PA4PR08MB7641.eurprd08.prod.outlook.com (2603:10a6:102:273::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Tue, 11 Oct
 2022 07:52:17 +0000
Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1db:cafe::2f) by DB9PR06CA0029.outlook.office365.com
 (2603:10a6:10:1db::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 07:52:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 07:52:16 +0000
Received: ("Tessian outbound d354c7aef2bc:v128");
 Tue, 11 Oct 2022 07:52:16 +0000
Received: from 5851c18ca419.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9453B380-AE3A-4E28-9BEE-9A7308B457EA.1; 
 Tue, 11 Oct 2022 07:52:10 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5851c18ca419.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 07:52:10 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB9096.eurprd08.prod.outlook.com (2603:10a6:20b:5c0::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 11 Oct
 2022 07:52:04 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5709.019; Tue, 11 Oct 2022
 07:52:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9cd47189-4939-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Fc8UrCRe9RhtXjGtbFZlm3dHqalIwN4sfL35yTJ+OdOe5pd/QlIqCgBIxeD0v5BvNga+21vLvR4nsUVLDyx8DesahP1yFugb3/to7YkbaWriuO61aFwj2FxyNqyHQdWwenqJsbahW655IyWoVG1SHwShROu3OYnLEelOGbwfvdNt4myQeRlirKCLFU1jTIg7Bq2PNXYBAdOalwzA9PMpoTNmVPp1aPiO+MHxdnkV3gZIOIrTtmIvWw65tizR0zvfZBtTFPmHapnIcv9T0aShoUkwSJrMjFWmHPbUXqu8B74+Bk9Rj7sDrGgHoLKD8/PYTKpMIe8EbstWXZngSsZjXA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+++nReco2zvuoEaFP+dp8pLVLMN5kLeKXds4nuY0d04=;
 b=nzgFefO+RUOY6e9UZpya6wd0MqKMqjwdOZijdT2ivsk7uECVuKA/xXajTotRq+UU+iUL/qjBcXU5tHaEYUEnaekVAgPFFhBvyiK9rPFW7LquTjYyeO7sVt/BxvKOaFuHZkORPVfruDbxS8qNNnGZnD0FNYy7Lsqpd9jbPekQ8KmeWyyzW07InmhFin/Qgyo5ElwIJyVpJktxXZPX3sOj6WgwV+JEwYnmsuVKiA6xb+BSP1xcjcYzkJsE1/vJR5MoO/I9skFB25YFwrTUy9lJT/zuQRGwnmkpSqlND1xdWchZ5f9g6k3B7+ynE1tWcgpvYZBiGirLz5+VIzS64MbYuw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+++nReco2zvuoEaFP+dp8pLVLMN5kLeKXds4nuY0d04=;
 b=wdEcRmSdw7jdEe77rl3CbKgjs7IsmrE+MFnY1ajSrEbmT/oceb4bz3jX0PFloMwnQtuXzRXgZ5rsURkXCW06R/oTtYE54IPbxHbdp10bFa6z0sJxinmFvLmj4sjI8O1sd99Dz9cUXoHv6vpLQ7hj8XajSxicSZ4dUzEGgTefhqk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 67238e4f5c8420f3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W06vR8WffKJQDlJ0S+6J3yfO2sfLeTdVofO0Yx/VYEwZmLl2vSHbMcfLTqh0QtDv5c5fYKTzIuGnnA7HCWaIaV9TpgfSWZWyMFIfotKJbcTeIDQPBfjg+nw/SKmYaEjC96j5jT6msqVlvuMryoitlNwcxizBkUBVXWR6ST1nFWpOtMLmlJaIpK7LRfcQi04MZLRdu5VUxOJ3dwJUei55YQcdWfLcY4Jhq6SkQXLZm+bXB/+8/9ajGlVzWLCu6ewBIln14R1QdaY9+JxnAqDXYHyRdSLy08oS5VR8hswwt308gnhcSBgba9pV+rws/YWMN35sW1fmunzG33PZhVScbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+++nReco2zvuoEaFP+dp8pLVLMN5kLeKXds4nuY0d04=;
 b=PCH17v8Hq+PXmEZ6zHL2iwMoLCuNEu6oMjA9VIV44XmbTLsggnA6rM1LRriimDhG2rOBNEhtTgFPB2qM7nreOsZgC4U4zDY9ZT5xWTsiEFroAkBRu9okrBWfjjutPJKwf/bXbgvIDpG9SJTc42qMjmuzs0H2/KSCXAm586IV7EbnfYe2mdQUf0p0R1CR749OuToab7KwPARTUaIf4vgtcwYzRJpjISz89MWkw/xXVE1PpCwq6E8ai88O+6exKFAk/iSab2YUE7LlSNL1H7K0w/1F1T8tINLV63WXL1qOIQNoWBWWazhtGtYpDTxhAXGtku4X5MPOPzqfsSeGPSkLSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+++nReco2zvuoEaFP+dp8pLVLMN5kLeKXds4nuY0d04=;
 b=wdEcRmSdw7jdEe77rl3CbKgjs7IsmrE+MFnY1ajSrEbmT/oceb4bz3jX0PFloMwnQtuXzRXgZ5rsURkXCW06R/oTtYE54IPbxHbdp10bFa6z0sJxinmFvLmj4sjI8O1sd99Dz9cUXoHv6vpLQ7hj8XajSxicSZ4dUzEGgTefhqk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Volodymyr Babchuk
	<volodymyr_babchuk@epam.com>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
Thread-Topic: [PATCH][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
Thread-Index:
 AQHY1KFdAull5ChokkeaXft6EPXQra337WuAgAZ9tQCAATqNgIAAE7eAgABoeoCAAPMPAIAAXMKAgAN3ooCAAk5MAIABJ2UAgACEbQA=
Date: Tue, 11 Oct 2022 07:52:02 +0000
Message-ID: <FC753E33-7A6F-424D-B092-9B3D655E8437@arm.com>
References: <cc0fbcb4-5ea3-178c-e691-9acb7cc9a3a7@suse.com>
 <9C12552C-0A64-433D-9F0C-5672281DD45D@arm.com>
 <73faf43d-56e2-2bbf-6336-f6420a1aa0c0@suse.com>
 <f1a71d28-ed04-0936-47e3-aa7a9f8c6dbc@xen.org>
 <0d33ecc6-898a-9379-f934-fe569cbdc8f9@suse.com>
 <3b3f6e1c-4f41-6b1e-b226-f0dd515d14ca@xen.org>
 <7d152954-4f5a-2833-f974-442c15f4e8b9@suse.com>
 <82963a1c-3301-72ff-e995-77c30ec5a64b@suse.com>
 <a957dfbe-c4c4-c8cc-93c5-616a44fe1797@xen.org>
 <319015d6-ec1c-3500-2437-00d40fe4d2c3@suse.com>
 <alpine.DEB.2.22.394.2210101657180.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210101657180.3690179@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB9096:EE_|DBAEUR03FT017:EE_|PA4PR08MB7641:EE_
X-MS-Office365-Filtering-Correlation-Id: cb6571cc-c81d-4f99-5f5a-08daab5d8462
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9Jegj3eyTkfXMDwtgZSFKa5td4RYNAjs1+e1w1RzZm6dxGndjj/4IEBLHarfpNR3aTLv/uDVBygi7st7+0jgL6io8f3rJ+EQlWoMLPHtdFVV3701xUj0yJct6BdZfPFNuNfsIJkvaiXsNnrppilEOan5ZblmVsY3w0w7ZhP4DFz8fgC6SaFlKa/LZ2jhlKfeQJ0vGu0pWbVvSBXWVLNNCCN9Gfr+moXpr2LSbuQyw938L+oVKKm3m+InQdh6M0neRv0rsG29fVvWBYsWPKgtW4GzyaD1TXb7Qnm08rzE1MEmm18vLDXhTgNK3JA7/VDPF+YCWRwrDGfmEBhyRmuafccfE9joEZicdTX4q0o06syV1BoLcECMsJzjGy3iHgtFt+W79F0vk7iLpLmbtoj6/HKZmeECXhu7BhUfJWpDrQZU1InVVR62HeFXPcZcc3CBbYOKlQS202xtfgmuUPg+lS8AN7TD1mmEU2dybtgUDvzBT6fdTBRvZETTfv8aANp2svVDGi7qRcfoYd3ySKRaO4UKa4mlaG06B8iPdYmcJVu2g9r2sDymeT1hGF8NEAyCqv9iHxsA55GLZtnXN/VxiNpzXPNOGNx9PILBJCRCWpS+I1kBu0tOipQ0nqJ//r1KRV2yXn57g9zVoKMpxLjTDkLylwjBcjSetWu8gQ7xuhUu/CTqRdz+F5DkTQt4hcdUSkVu2C+CQsmXrsfwoWXSRb7yu3ufjkOFj2VrfkiCTBYlirRYmXs2ciLmcMzx/Qxhbq9plky6xlnwHRo0kZY6ZjLqc0b9eUCtUHT/n3JOBh4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(39860400002)(396003)(346002)(376002)(451199015)(2616005)(53546011)(6512007)(4326008)(66946007)(91956017)(316002)(8676002)(76116006)(86362001)(6916009)(6506007)(38100700002)(26005)(66556008)(122000001)(71200400001)(66446008)(66476007)(478600001)(54906003)(33656002)(38070700005)(186003)(6486002)(64756008)(36756003)(5660300002)(2906002)(41300700001)(8936002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <4839BDF9C4F2394EB9FDFACF6A7B400F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9096
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9ee22d27-9c8a-4dca-0b58-08daab5d7c23
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KcATyBfkboRdgJi2OuSo2tm0IXQrunNh5bbae9H/OsPiXn3sPoo/zzNh2IQofP5+Yco8hIZ1yyPHYNToXNzBgZTxAZbskqhNIW6bfRkmlmewxUs1AFb2cjn8zvqrUdKgf4k8BPf0o0qeYTRudurRcIQgHi+jVq6wivbtDDEarSLCnb0J9Ex+3bXm/SLwGcom0VECo2xNvObgyLLsERSOiuf7AmIu5TfyrydFKv/O3CGYQ2bsCfWCV4p5Tp0FIqFkn0sPgk9Q5PaRQ4Py4J8ToWvnOrMaFKCp5YXtWg4gFqq0izmRE9bnsmSgIXEA2QrRLNN85htc22QQBqPbTodwRdQ1jrJI9lOcRbp0i6HPCfOsm2q6cd4p+oq7zyoDPjRrTkJArfhGN71cnmQ8Md/fbc/lBh2dDJ9pQYFz1UL+KPCw3cwXpnEZupGkebATiLrg/Y4S/K9djfKy/XrQUtqmPslLTNqkrNz96jraYvm+5bWR4ilbjg2kiGHbET2wqwXDS2CJ1EP5NMg9uYS+KzbZBYbOUP0xZOxAGZy2qgWfcJRPCH7JT0K3zosA+DhzmiWj2VpZqioZpekqqYLZRtFnepYsFIhkvslpiBSda1wYNHvE2BpHQ+f91WNgggOJJEywvaqMhnV6aAbmVQ2d3symZlFQ/FLG/Lpw6GfUcXrrjd7pXelTXvQSqzpkiE/a9vhlAMR57E9E2Gzvwi3eRpnUch7uA6BpoiWPSh/DLNoWlWPtNKoSHnJCVE858SC0Zpmp8mGD+3lRSJ78lBBYzyBiaQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(41300700001)(40480700001)(6862004)(8936002)(2616005)(2906002)(6506007)(33656002)(478600001)(70586007)(8676002)(53546011)(356005)(36756003)(4326008)(70206006)(81166007)(40460700003)(5660300002)(26005)(82740400003)(6512007)(316002)(186003)(336012)(6486002)(86362001)(54906003)(36860700001)(47076005)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 07:52:16.7694
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cb6571cc-c81d-4f99-5f5a-08daab5d8462
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7641

Hi,

> On 11 Oct 2022, at 00:58, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Mon, 10 Oct 2022, Jan Beulich wrote:
>> On 08.10.2022 21:08, Julien Grall wrote:
>>> On 06/10/2022 15:11, Jan Beulich wrote:
>>>>> ... the space cannot become ordinary RAM, then such a precaution
>>>>> wouldn't be necessary. After all hiding EfiACPIReclaimMemory from
>>>>> Dom0 just because it can't be mapped WB wouldn't be very nice
>>>>> either. I guess I'll submit v2 with this part of the change left
>>>>> as it was.
>>>>=20
>>>> And while already in the process of committing the patch I came to
>>>> realize that if the WB conditional isn't supposed to move, isn't
>>>> the change done for Arm then wrong as well? Shouldn't it then be
>>>>=20
>>>>          if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
>>>>               (desc_ptr->Attribute & EFI_MEMORY_WB) &&
>>>>               (desc_ptr->Type =3D=3D EfiConventionalMemory ||
>>>>               ...
>>>>=20
>>>> leaving the EfiACPIReclaimMemory case entirely unaffected by the
>>>> change?
>>>=20
>>> IIUC, the concern is the region EfiACPIReclaimMemory could have the att=
ribute EFI_MEMORY_RUNTIME. Is that correct?
>>=20
>> Yes, ...
>>=20
>>> Given that the memory is reclaimable, I am not sure why it can also hav=
e this atribute set (to me it means the opposite).
>>=20
>> ... at least on x86 all sorts of strange/bogus type/attribute combinatio=
ns
>> have been observed.
>=20
> Yeah... it is a good idea to be able to cope with strange and bogus
> firmware tables as it is known to happen

I agree with that but if we make an assumption that something is bogus, we =
should at least warn the user if possible.

Bertrand=


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 08:34:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 08:34:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419441.664217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiAhy-0004QG-F1; Tue, 11 Oct 2022 08:33:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419441.664217; Tue, 11 Oct 2022 08:33:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiAhy-0004Q9-CJ; Tue, 11 Oct 2022 08:33:50 +0000
Received: by outflank-mailman (input) for mailman id 419441;
 Tue, 11 Oct 2022 08:33:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiAhw-0004Pz-SQ; Tue, 11 Oct 2022 08:33:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiAhw-0004qQ-Ai; Tue, 11 Oct 2022 08:33:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiAhv-0006fP-Ok; Tue, 11 Oct 2022 08:33:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiAhv-0004uH-OF; Tue, 11 Oct 2022 08:33:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qqR/DPfxh8gBg/NVFK/Dxn4aUcm84UW3EJj6YMWgJls=; b=VqdqBMVsdOB2CZdaCVgugDA6xU
	ENAi/KCNKxs8UBAaHCfgqkTAjSya8c9beVh17KOLNLIyNyhY0ztOdBKhbvjqMoutOrdW5VpXTSMwM
	hIkfh4Hu9rQWPRXPnKZ6oUmxNt99pl+bF5vpOlbUd4rWSw1hgshSwPt7A19EZx+yTLQs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173488-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173488: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-arm64-arm64-xl-seattle:debian-fixup:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 08:33:47 +0000

flight 173488 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173488/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-seattle  13 debian-fixup     fail in 173482 pass in 173488
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 173482 pass in 173488
 test-arm64-arm64-xl           8 xen-boot                   fail pass in 173482
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 173482

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173482 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173482 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173482
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173482
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173482
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173482
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173482
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173482
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173482
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173482
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173482
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173482
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173482
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173482
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173482
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173488  2022-10-11 01:53:08 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 08:48:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 08:48:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419449.664227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiAwO-0006FG-Nj; Tue, 11 Oct 2022 08:48:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419449.664227; Tue, 11 Oct 2022 08:48:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiAwO-0006F9-Kv; Tue, 11 Oct 2022 08:48:44 +0000
Received: by outflank-mailman (input) for mailman id 419449;
 Tue, 11 Oct 2022 08:48:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiAwN-0006F3-Rm
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 08:48:43 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130059.outbound.protection.outlook.com [40.107.13.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81ff52e5-4941-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 10:48:42 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM0PR04MB6899.eurprd04.prod.outlook.com (2603:10a6:208:183::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 08:48:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 08:48:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81ff52e5-4941-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DRo/OcTnm/1E4fpZ4ajhb3J69oUa8h596+EWEjoQ/GjN28NxZ2kPXur7ieaaS5sjfD9XduUA0BqP4ul1qm78ZPObhr3rCb6nmPqP1aa5TcymDvhxP9+BAYuDGeNZ2j+cPFBPIzUbJxtjuKdvHF+C5kvTkqhfUgbYUv7xvYiCcRNw/y4JFncS9H9dqgctyRSwt+AJ8Wx6N6skRG8wnuDA9X++6r0lB320QdqhZB1d/r2nmdGanoVWXvxOo0AW8jNOXrvumTDnBzN9Vgpoh38uC/4nyh1pkxI4i/+WqfXAwvT8nq4s8nW0orJN88AqYrHpyBjgJlo723SIwWHej2iDfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yCFMIznkAEoGtILkRiPo+tByavozNVbWDchF5HojaPI=;
 b=kTHUpV7NNYGwWvXg2QqY9zHcwR3/XVILStR3ZQXRyfBgeGddX7zA6breUMcvQDVyYi/8i2sP4P0CbVkIISVogfFOTOwx8E+/B6dPOZsiDKm52Pm2+oFISgHKX/zj+R19amME3B2gQqQhwpJLZOckOqSL0qxrD2jHpOQFoimpJKrBtt5f4g/sPoWx/wcNRhJVHFOc5awkYHs6IKdNk36oG4+1K3Jl6vB3EQVIMv033KSmCyPxV9rd80dPctJLGwYz6WHzScLco8rx9SK0XbRbCcg+ufIDRIuXtdFRJrxAyHzLrKJUiQ0doBCNngoDXQjB5GgOYHHOuECZyxIeUytQ6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yCFMIznkAEoGtILkRiPo+tByavozNVbWDchF5HojaPI=;
 b=JyCrVODnvXl7CHIZVEzUPFN6vaGGx8a+BClH5h0tNYw6xLox1yv4EhyXB3rIuELpciPQ5v+u0M3mJngUV4jinynnk3JEMz4rMbhRM22uS3aP3DeNUmyjU6MNkNVL3uO2xWz9C1DCgo270njLntcX6F/dtkWgqvlLlGFuyNkT+2zcZMQJPlBRW9Hls4VlZqFwVQmp2T5NaqWQO+wLQrLNdOu8WhyNzypuoM6+QH75tUqKkI5KVcRMMqSt+st9EfFC2eixy/sMO1I6W3G2QUslUlX0jO2manxmAmTl/pKjAql4jBSe5ce2vVrXfS4FBIMRTuT40OEQnem5cXew0d4t/A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
Date: Tue, 11 Oct 2022 10:48:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] common: map_vcpu_info() wants to unshare the underlying page
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0587.eurprd06.prod.outlook.com
 (2603:10a6:20b:486::25) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6899:EE_
X-MS-Office365-Filtering-Correlation-Id: 25f3b257-01c3-42d3-4727-08daab656500
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1Qj0gJCC4qylo6/XifcuXgf7M9q8mM8dSPcYHuCRRqtJfK+zowmqXxW7rvGa+MbVl9T1zQx+1bSZasto8k3CRobkH9ZiwwBJlqzZH3WBW1puROMDlZXUDYMFfIx+hpbbwQp4veHe3w0CheFCqgu7ysZvLnjrhIGqSSYpnz1OLXG0KEASDCOVHGCEgBTgAf7Yu+zcIYzyuYNsTl11pfl2Y3U1TJ/gnN7Hzm5iZNPyZjOQ8l6Z/PjkutiK3ar84Mu0vgTNw0wGFXK83Gm9KWmCZn1XAG5PxIKQsO8M4bhcaBhHgPW83IH0opgCoxU6dc1YaMhJw3ONQaqn6qA/BHYyE6hUq+X2+IqZ7TybFksAQEhWBsT70cuQtdSb6xwE/Or6/s2FCrY0ah7w9P4K0U/dwqpESlrYXYQmGNoVHODCPA2VG8SjOfpXM+SuJbs61/8nq9SRIi6NZ/JofdnvfqFpGMYGjwXl08j7mK1aJXmfTXsoisx6Hf+t8q8gxmP/jsj9wIfPs1oK5IvhVOSppyiQ6pOQQ6rwLxL8pD+IQvqGPidKLjR68fPzX2oTDfOR7imSm9YiDX35CrM0viyTN+Zch7Ldb/6p0sm6TD3ZoCVyBDSPlndIPdRXW+xKtsvZQAM96Bg+9MoqwGMSYGEpcCn2qH6CDHdECLeu2KmQElGQ5VjstvF92ho7qOALAHj5VhL4vuHzNF1J/3e2otfMujZFxXb6NsYAFrd1GXal9uhFWxJ1OMxMa2M+D0KH0fEBjt+CwHbzsRSuJqxKw2B6JNH7zy0n/NmEtPBX5L4EW8YmR3c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(39860400002)(346002)(366004)(451199015)(5660300002)(8936002)(31686004)(31696002)(66476007)(54906003)(6916009)(86362001)(66946007)(66556008)(8676002)(4326008)(316002)(478600001)(6486002)(36756003)(38100700002)(26005)(6506007)(41300700001)(2906002)(186003)(2616005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGdyb0U1Tk4vMzNoYU9xK3VWb3NQRjR5Q0VkQnJHYWlQM05YbTB1VWFHSlVV?=
 =?utf-8?B?djdDZVpSUTdVa2NEL1VTdStXUVpnYU9tN0pZNXNKbndBYVlVLzBkVXFjQ2hx?=
 =?utf-8?B?cHhXNnJSVnNleWM2SjQrS2lFSi8wZkpqcU1PeHlwZVBQb2h0OEJZZVNwWk1w?=
 =?utf-8?B?VHVqRzNTcXpFZm1NWmozTmVYVVEzajlIVTJLVEhBT1JOdE9MdzZiWXcrdGd1?=
 =?utf-8?B?aDhxc0lTRlNuUDlnbGs4WnNSM21JWTdFWW9scU9sd21RNUxlZmovVWlmTjJG?=
 =?utf-8?B?Y1dFSlozLy9VQmtCeGllb2I3UVBUWDJTWjdneUxBUHRMY1c2Ukc3VEZIMkJR?=
 =?utf-8?B?TVozT0VmeEJTUGlqQTlIbHFFSmdDeHZrSzZXN0hkejhyTnNiZjY4K21WTTh0?=
 =?utf-8?B?UXlPaEVQUzNKV3ZSZVB4MVlpU25BSlliSlFodjIrTU1WRUVTaThGbHpUL1J4?=
 =?utf-8?B?Z01NYTFNTldiZ21PSXg5QnBkS2pnYjRQTHJJY0poWHVzSHJZNldMSktjd0R2?=
 =?utf-8?B?M3JpRHF5QnZsaWRNQVNTUXlqaVc1M0pTVXdqT1dnVXlaMXhCWm1Hb1FtT0Ni?=
 =?utf-8?B?L2pBeVlicUF4Nm0zTThOdlpTN05oQmp6bWg4RlFodHRtUU8zdWR4N0ViQ2Zl?=
 =?utf-8?B?MVJmR0NncnFEbG83bXd5cEpJYlpqK0MxUUNMU09iZitISWs2bVNhUjdSRE5V?=
 =?utf-8?B?M3VGU21GSFc3Zkhab3phSEFKRGVLNTd0b2ovU0hua3JIZ3lEd2JheEhHNW5G?=
 =?utf-8?B?NFczWFM0ekxubzJGblVzK3BVdCtJMFhHQzNSNDRwL0FnR1hGUGVPZHFmbW93?=
 =?utf-8?B?TmpmNjlLOG51TFZ0T2NMUlNDRllWVEdYUmphM21GKzVEeVhmMDZZNS9FbGRF?=
 =?utf-8?B?UjNMMG1HenpiaGpzcWpmYW9WVHo2aGVNaUJ0Y3liT1hMOVpmTEIwSnNpb2Zm?=
 =?utf-8?B?MUFFd1RlWTl4c2pPUjNtdjIyNDFQZmFhaGtuN05VSFh1cjh2YjR1L2x0TDRN?=
 =?utf-8?B?VCtWRk0ybFYxZmhUcTNITWZ3TnVicTFRbzdNbTA3bVJrSThDRmRIWUx1Rmtn?=
 =?utf-8?B?WHcxd2haVUpNM2E2Y3BzeGsxK0k4VWlMQlIwV0FlMEpWdkRYa2RDV1ZJYWto?=
 =?utf-8?B?alNDM3dTcXZndWNvQ3JjekxKcHRVMXJZSkRMQ2VXZ25sSm9PbFhEelhnbXlM?=
 =?utf-8?B?M2haS2orMmJBaVBNYXNLK0VCRlgxMmo1RDA5elAzK3ErRzhVQjllVEpQcUhL?=
 =?utf-8?B?MzlTMHlvVWFRaXpqbXVQcUE2MVZaSTNXbWhsRVBubzU5bkRDM2lRc3FPU09X?=
 =?utf-8?B?NzBXYmRTMkoyUjY1NWUwek9vRjVmcVJLbmpib0lkQ0tXZDV4OEQ4SGtNY0s4?=
 =?utf-8?B?THBvSHNuSHA1V3hSTGlzalExTm9XOVJQQlkxRjlUM045ZjVCTmZmR01HdjFs?=
 =?utf-8?B?cXVzc3Y3cUlVRVJYcUlHV2xGNE9QM0dmVzM4R2F0OVg1TEh1b3ViQldPSkJ3?=
 =?utf-8?B?S3F3N1pzaW9GblhHcEtwQzFUWnpEdG8vM1VNdWhNb2ZOSXRxUEJZeHZpcG5x?=
 =?utf-8?B?QzBqL1JIOGYwdGVPWDFPbTdPV2M2OUpHakFtQjU0MTFOSnlPY1Vibi95Q1l2?=
 =?utf-8?B?Ymp0TmNhOEV1MjUyNkVHZnBmbWJxaGw5L0FGdjVXOFVzSC90Ym1uOVpINzJt?=
 =?utf-8?B?ZzYyT2VNQU8vdlR0U0hKMmhNcVoySkd2UHFCdHE4aEJFTlBFbGJ0Y0VKR1Ex?=
 =?utf-8?B?WkRjcUM3WFFBTS80bzFiM2Y0WERDdktPSTVCZWM2K1czWHA4SHZNemtPcmZ3?=
 =?utf-8?B?YVRtSlN2Ylp1QWlFNkZvOHc0WUNXb3dxb0E4UmR3QXByNGtJTldodE5TbHNn?=
 =?utf-8?B?VGRleFJBK1pqUWxpOG1lclVtbVp6cDRSelZJWHZPU0xTRGZKK3FYVE1wZFJa?=
 =?utf-8?B?VjIzazZkdlVuNndBSHNzdmFCTFRYb1hoVFJ3bHc2SXRYdk5vQWFnM0s4emFO?=
 =?utf-8?B?T0ViNUh2K2ZEQjhLNmw1ZkZ2NHloVVpGYjBvQnV3SVl5NnloYWR4dlBkTU1M?=
 =?utf-8?B?RFdBdTR2cG9jbmRqNng5d3pLNU5BUHVzU3dwV1pEUzR1cG4rd29SeGZ2QnpE?=
 =?utf-8?Q?2pfIe291XVaguwgSmYIV2TSS2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25f3b257-01c3-42d3-4727-08daab656500
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 08:48:40.2316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hU4i2DCl5zcS8xoI4cuTMyKbRL6PePZChS6hkyQ1i+hCA9SBNci1krMq8mKe5SsdH9A3bdyVKq1Zw4D42vTSmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6899

Not passing P2M_UNSHARE to get_page_from_gfn() means there won't even be
an attempt to unshare the referenced page, without any indication to the
caller (e.g. -EAGAIN). Note that guests have no direct control over
which of their pages are shared (or paged out), and hence they have no
way to make sure all on their own that the subsequent obtaining of a
writable type reference can actually succeed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Really I wonder whether the function wouldn't better use
check_get_page_from_gfn() _and_ permit p2m_ram_rw only. Otoh the P2M
type is stale by the time it is being looked at, so all depends on the
subsequent obtaining of a writable type reference anyway ...

A similar issue then apparently exists in guest_wrmsr_xen() when writing
the hypercall page. Interestingly there p2m_is_paging() is being checked
for (but shared pages aren't).

--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1484,7 +1484,7 @@ int map_vcpu_info(struct vcpu *v, unsign
     if ( (v != current) && !(v->pause_flags & VPF_down) )
         return -EINVAL;
 
-    page = get_page_from_gfn(d, gfn, NULL, P2M_ALLOC);
+    page = get_page_from_gfn(d, gfn, NULL, P2M_UNSHARE);
     if ( !page )
         return -EINVAL;
 


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 09:28:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 09:28:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419477.664248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiBYZ-00032d-36; Tue, 11 Oct 2022 09:28:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419477.664248; Tue, 11 Oct 2022 09:28:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiBYZ-00032W-0D; Tue, 11 Oct 2022 09:28:11 +0000
Received: by outflank-mailman (input) for mailman id 419477;
 Tue, 11 Oct 2022 09:28:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiBYY-00032Q-8U
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 09:28:10 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2047.outbound.protection.outlook.com [40.107.104.47])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04aadb1d-4947-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 11:28:09 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8600.eurprd04.prod.outlook.com (2603:10a6:10:2db::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 09:28:07 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 09:28:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04aadb1d-4947-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JX2G5Hrb2e11gb0n9RjKB/eO0dJZ9bcxjCF5cxm4Ird0YYOCbqiAxoYhpyiqkK5wTO+n1YPB2TNQWRHAcaKkEK8e8KsUGW6yht5X+e0DsX6K9houVgplIxBTBnfEvKu9Lp6w22MuT4hbx5iUX0wBg+IavGhG7GrH2/Rzsnxz7mRYcCo0sSpqDC7ibiraCHBMXuswatUks1TJlYiEu9WC4aqsIImyFvXjgDCx+WVemaa5pU8HBpSCKi4ySOHtpr0wU/2OZ8l8SEwFBKlq7TO8KZwq8O74RpLjTRscAFRwC56QNJrj2yap0RiKK8kwtwK/eOd+cm35gm4bimS8LKfJqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8PYxNmAx/0BwYebHPv3JpL7U0cAtJcGFRrWrDqUDEgM=;
 b=VuFP6tLulfhs1qWbX0vFoqctto7bGA60L95pNo1Soik8V8qV+/dGmke7sPL2+9zhzk4H0kSkRmqY9IiFPR54kqsKI5B3AgQ05mtEdlf204/+d3H+0mKyBBIOvS6CwLuzCR1GdTYsBgBaTtn/TH5KD1a4onQ/vIYdux//Ne7MUSqjD2ok8HLJDc+qRcQpY4++gLc/vbiqMYhjrfdKyI07L5AGMhgQXw/ZdaBtg4gmbrPBa908XrRe04ueJ4Newuga6m3T9pveDGtZbNZHSobwjkM/KGFVBqPk9ex47gFtaq5SR/bgWmEelceC7if2aObO0YHm+i7Pk7V5LT2PWlhqQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8PYxNmAx/0BwYebHPv3JpL7U0cAtJcGFRrWrDqUDEgM=;
 b=M7L1v1bU4IF5cflTe8t3yoqdvBAitbhegc7zYgqNxfp/oa1pzX+2JCkJdngrQe/6ieQm/xE3UyRH44NkszGaSXB0yjzXo1AE2cpojyGd0JrDij+HfAqOF8s4zF3pzeOO+j1JF+T3DZlHabctACLUMKmoxPHWnAKcsI4Iupr1iq52OmLF/yU5EbbWgp1gj1B/0KxwU1H8fheZtztoZbIKQdoZoiFHIjUKr80xT6X7Vj/tkUrDY4ZlfVbqbOge+qRtyim2J/WS/j5WduaASMe67YCrQWbdIJteXYJ96PjTNhqMpncnoZiIDOuMCuRYnFTVSxDUuNNhe3Yqu65qg1baZw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f9cd7b84-6f51-d797-cd2a-b9c9bc62b0f6@suse.com>
Date: Tue, 11 Oct 2022 11:28:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Christopher Clark <christopher.w.clark@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] Argo: don't obtain excess page references
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0125.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8600:EE_
X-MS-Office365-Filtering-Correlation-Id: 9a361519-4bca-4f63-8d30-08daab6ae82c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vBcIoCKTGwE5HdmxX5WKpY6oCoBs+8PoS3SKivkogH3Vu/8T4gcufYxL1Ik82g/6JTYQPvuNAqJ2/meN59fGdkm5N8rrote1Xfwm9lH8hRFQ9G9zQPPsCFYcPkoS3pTnImQVvQJet+MpWCqSjdE/M+RLXnDexBCICB74UKBiO/WzKPN6YOBL+BGQp+BU4MrCCIQ2FYIjmyS3an0WlQoIFF5stgGhwR48Pwv7mGPYRW6B+uQAYYgQpMn5KALo+VE1KQFPJLaTC3F3+WM+J8g8yqMMR7l2Hf05QZcqZ/SnXo/2+e2UZfur4AF1EckcjaTLydBej6h2RqsBf5AnxXYoXlvbb6AW/vI1RPk7pFvu/jpDgi0KW8g85Ug4ug4rTlBkkcrD84+6ny3EABNot45z1vr1e7mMP5xhskKIcY1fO6tSc+BV7VlYd6qAnoD3Z4y9dVXNbOuNyZ/wu9pN74ZSIBouLtD9VszdraSjlilJzxHB8eGM8OGo6ix8xoqbRK/qajfP51xzChAXNVPoZwCTOvtg2wBDoLw4F6hK+uXpDnQzYJjqK/9jVtFnmxTdQFYu1wI5V90fCXQrzEXsak3F6EQ99IaL9LoHAt2FSNufJQxr8cHd2dNH/5EHSMaAADTkUYT/NrYuCyosOZWeKfrr3TEZk3WpIw3BN1FcVMBOclUrnD4f3Umx+mPhAk9tkGHveNO+NXCRV3uAuC+x0uQl9zO3SnR0M/fDdwOWr0GbAbN2KKG2qLnJ6QkZDv/YhUSIaJgMSnw5I7yGZBf2X7qVlieyPxiu1S7wGknufgolIa8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199015)(2906002)(31686004)(6916009)(4326008)(316002)(4744005)(86362001)(66946007)(8676002)(66556008)(66476007)(5660300002)(31696002)(36756003)(41300700001)(8936002)(478600001)(83380400001)(6512007)(2616005)(6506007)(6486002)(38100700002)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGd2WUFnTDhuRzdqWHAxS2h0WU51Rm53K1ROMFB4RjNJNGs5RSs4QmxLeU1O?=
 =?utf-8?B?ZE1VWmJrVjhRaEQwMitsOUVpZk9BOVQwNlhGb2NERUdoZVRGaTNVZ0ZRQXg5?=
 =?utf-8?B?dWxpbjJRcDFsZGxlMVU5RDdQb2Q1bVVXZ3FtWXltRjh1VHRiVXI1Z0FDTGl6?=
 =?utf-8?B?UzVESU9SOWR5VTgvTTlKRGJmVHY4b0ZadXQwbG5EVFJvVHJ2MStia0xzcG5w?=
 =?utf-8?B?WjdxcS9ldUdPTnRFclM0aHkzOFVkcVdzTTJmSWkyb1k5L2hJOUFPWnR2MURs?=
 =?utf-8?B?bW5TMlpmZjBBRFJTcDNSdEdXc1ROc2NLbkNGcEVaclhBUXhDdkhqaEk4SFpw?=
 =?utf-8?B?cmJwTzdoV21wYllVa1YzclpKQ1JKS2RLWHl0QkNDWVo2RjRGeTg0TUJlRFQy?=
 =?utf-8?B?VEJxZHJwTTc2QjlpcHpMNmlqaGN2NjhjeVVFYmh0RTdSNlZNdHFRM1RycmpB?=
 =?utf-8?B?eS81OFoyT1NaYzVmb21ZOUpaS1NkWHZkV0hwSlJGZ0RRR0tOdk9hOFZGcG1z?=
 =?utf-8?B?NUcydkhnUU9pMTYvQkVEV3p2SkZKT2VwUWZ5dzhsQ3RyMDNsU1FNMzZ1TUY5?=
 =?utf-8?B?V3RHVmNTdXlETGV3SllqeitZYnJlSlBKQmtCeEpoTkloWnMxZnRWaEtxektO?=
 =?utf-8?B?UkdMeVRLRGhVUU00ZER0bE9mc1ljcGRPMEp5ZWNJUko1cmxHYlRYY3o3K0kv?=
 =?utf-8?B?b01uUjNEdEZOM1V6SGRXQno5WExPWWJOd0pHK3E5cXA5bVNHWFNoN3FuNi8y?=
 =?utf-8?B?N1c3VE01UWhpNU84R2J4Smt2Rm1oeHMyR3JidS9hZkxKMEdOeStxY0V0d1Ry?=
 =?utf-8?B?L08xU0FXd0o4ZDE4ZTZ0R0c4NmhPcHVWNzl4VWhacHJ0MzcyU3pmODd1VGVh?=
 =?utf-8?B?RndHQUR0amdyS1hzc0JTeVFXSjdYc1lPYXlZSDhEcnZpdWtnY1JNaS9RNjdX?=
 =?utf-8?B?MU40TUlsVFd1eUVsSDdHK01Ic2tLZWRaQTdhbEZsNEQvMmdudmdkMkp0aUNh?=
 =?utf-8?B?NUczQjR1NXN2cTcwc1ZUM0FabmNyMDhDNTk3TzdmdDlUSVZzZW1WZVBNWDZF?=
 =?utf-8?B?N3hjTWVBZk9Gc0ZJeUp4THdOQ2Q5bDV0WjlqVnNmc2FxVmRIRmR4RFFLMWlG?=
 =?utf-8?B?Tmo2NlVXTE41OGc3MEdveWs5SjkvSS8wWEN6VmRTSjBJMENBWDBaNk9TaG9K?=
 =?utf-8?B?YWp5NlNJMVJKb0ZhYm43QnFGZ3BBbVBIdmtVS2FYbUNlemxRM3hCTjBkQ3RG?=
 =?utf-8?B?WTdLQlFKbWZzbmEvOFNVSmNyanA0dUFkTnArRkIwQWZHWjUyVHlmVE83OVI3?=
 =?utf-8?B?RzcydlVBRUxSMGc2cFIvV1B6R214YUNpZTkycVlDN3FYMG5XOW4wUXZmcUts?=
 =?utf-8?B?S0FvcWZpQmhyZUNxc1liZ01CWDFLNnoyYjhWVjB5OVRGWUVLcEoyT2k0R0xX?=
 =?utf-8?B?eEFqNkZwVGtmclRVRk0yS2VXUG42b2dnUmhZTk5nak40K2VhTEZqcHVBckxV?=
 =?utf-8?B?OHFTRFNpRFRqalIxZ2VNR0daQkhyL2FxNzFzY2ZSS21mTHd2cXNEeWtMOUNz?=
 =?utf-8?B?ZGROZHpTNElJcjV1bm43ZzRyai9CazBuMXdDdHFCSU8rZmlHVFE2b1dnZUZV?=
 =?utf-8?B?bzNVajEyNk1iSUhYcjRBRWU5RjVXdHhweHZCbWlKUGRKQ21KWE1CUVVxVStN?=
 =?utf-8?B?eUt1VUxhTzZ0ZXZzRE50Y2tMWGNqNC92ankzRHJCWE5tall1YWVIdmI3b2dS?=
 =?utf-8?B?cVB3QW5TTjhScDZQckU5RDVTU2pReVg1anUwQzlLV0Q3MFNja3JyZU1jU2F3?=
 =?utf-8?B?YlVHYUt5QTVwakxHWEVSeUNGaDY4a0x5a2RlbndFZ1NMUkp1cjBqL0wzc3Jt?=
 =?utf-8?B?OWFUTXVDS1hQTDgwVTV4YVo4d2ROMjJRMVJwZjlKaDM2VW1NRm1OdGFuZFpi?=
 =?utf-8?B?YjFybmJBWER4dkVwOHJXZ3ZGd0dudEJEaVBhU1JrbVVLTzcveXZsUzBXL0ZQ?=
 =?utf-8?B?TjhxdWtzdFM2T2FLby9jQU9BUDFVTWdTZ1MxUkpSSU5hNFQzRGJjcjJweFlK?=
 =?utf-8?B?QXEzTEZDQ0pxajFnQzhlZEVVeG9wMS90YUdFMm1EaVVNdHZEVjd4WWxQVzRI?=
 =?utf-8?Q?nkJpTO/gyPKq3zuA9W8Y9yglb?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a361519-4bca-4f63-8d30-08daab6ae82c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 09:28:07.7088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C8YJusw+Re1ZhEeh4VNi0RxzQjo+/4S1E2wIa4D/vYJvKVhChUSdLnvemkY4uBgSPmcmezZYeUv8T9srLGUgDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8600

find_ring_mfn() already holds a page reference when trying to obtain a
writable type reference. We shouldn't make assumptions on the general
reference count limit being effectively "infinity". Obtain merely a type
ref, re-using the general ref by only dropping the previously acquired
one in the case of an error.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I further question the log-dirty check there: The present P2M type of a
page doesn't really matter for writing to the page (plus it's stale by
the time it is looked at). Instead I think every write to such a page
needs to be accompanied by a call to paging_mark_dirty().

--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -1429,10 +1429,11 @@ find_ring_mfn(struct domain *d, gfn_t gf
         ret = -EAGAIN;
 #endif
     else if ( (p2mt != p2m_ram_rw) ||
-              !get_page_and_type(page, d, PGT_writable_page) )
+              !get_page_type(page, PGT_writable_page) )
         ret = -EINVAL;
 
-    put_page(page);
+    if ( unlikely(ret) )
+        put_page(page);
 
     return ret;
 }


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 09:41:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 09:41:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419487.664259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiBlh-0005Sr-7S; Tue, 11 Oct 2022 09:41:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419487.664259; Tue, 11 Oct 2022 09:41:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiBlh-0005Sk-4w; Tue, 11 Oct 2022 09:41:45 +0000
Received: by outflank-mailman (input) for mailman id 419487;
 Tue, 11 Oct 2022 09:41:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiBlg-0005Se-Iz
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 09:41:44 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a381c6ec-4948-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 11:39:45 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8797.eurprd04.prod.outlook.com (2603:10a6:102:20c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Tue, 11 Oct
 2022 09:41:41 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 09:41:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a381c6ec-4948-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AVK36Dr2a/MjxVqTeWYw7y/TXXwemlfoQRITM4K3OYzqJOmqXhQBJO2MglMfJbJ2gwc5Gwg/+jTvuwSh6lnidp1uMowWpL9DN9C1rYPotyYJ9zXOPV87F+BXMxfHTZxd7VRcKDbfOrIbSQzp4C+DbZcfy7LMdmGOf4RHKjKnzmN5upGG7Ognutli/W+OBtg/iq/2gtumrW0nVWM/nxiTo0doww9R0ZTMe8k4uQCh0CPa+15Ket633aTAZMUUINKJBGc0jQQxVIqdZ+NYkcGJSCtwyFQeFjoznd45U2JyNqmHPaYYpZ7MPAyEzAZXZ0GYUoxjnwX1KMAbn2q2OTQqhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gI19HlK+CO49gbR4ePjFhXDQFIgGxU0z5umPLsZbJxo=;
 b=DeRaVHD0Mg6HuFj2bXXIFQPR4nlTmhEVHGt/aW99m1SkDsRGoIIus0bMHCHRMHu9a5BexpJrYkbeELK2J2SQaKI1F2jJw3x2ZX1Sbml5ekLSPZyT5cElis1Iwgdpar7mL8eVrLplR55+Kkdpg3koTltV1oDlmzH2XJaztunKvQ+JQD46+DPJQjIJ8kdxijKS5MYVOYAMFK9B2AYmN8xFUd9Q3D9qVUu0yhdfYpZwgLYO+CmJN6EVWBCMGtOHMhNhlLfikC6Ve4JhHZdutaCPayECkiKzBKw0LkGnm1dfPWeo9V+kJ+leJfwfEAYw7XwZ8Big7MRwjySctt3N71kMpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gI19HlK+CO49gbR4ePjFhXDQFIgGxU0z5umPLsZbJxo=;
 b=X3KXzH/EkgNbxumTMix2x4CGl8/lXqpwEWl0oyxYG5RpmTP66QPfMXpbpUySDCi5e3AtfODV8utIDDFILWp+iF3YlJcADjT+iDjIk/YaPftGohv8Yt5I+OigKJvc9y1YMQq2elyCOkjcQs9Tl7sk/HoDPAYxvUCtzKcxJvjnMrwokuPoJS3Ndl4UXf4jQeflC6W0ZRoxd1mOR1QwcqjfU3vEp9eW0tclUqQqYwFaWKe8QwFshvJbtOeg5j80pF862fSZC8iFNlb4nOdEGVCg5KrjuoYcUsCwBUuzFYd6aTVIoa5MQQ0NQoZZ+N/PL9meCYiWjaf6/tCpe9p9Ta7T2A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81c08d76-0937-32d1-c6ac-439c4bf33883@suse.com>
Date: Tue, 11 Oct 2022 11:41:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3][4.17] EFI: don't convert memory marked for runtime use to
 ordinary RAM
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8797:EE_
X-MS-Office365-Filtering-Correlation-Id: ca33df96-7167-4d3f-2561-08daab6ccd2d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t39YMtTicgy/yb05vmicxlhqXpZPetnB4YINIL+LhzhpvMwkRyhpOgeyXfeOscyK87qUO4VtgCvwQ/j3WAVdwR+B4WA3lL531N2Vog7lmd3RjIEcMzgWCpHe0eMHKmXuc6Kbp6Rz0SMI14ck45+zxTWOiz2c+NBYNdm6TGTe/VSc0adJ0ZdNsFLSPYCgSauY6tTn56zsw/cSA3EYVRjZnRRINxHP0pNbElynBHMHsea/brDfOeEv2AZs+gepZd8VhgwnpB5xuNNr4imhZiLEL9X12vj0i12HIQjUOXcuhOEw/+4HFG0zU/oU2xpDIqOjbS4++B3tyquAqqAyWW70/zMFTV3eiK9mA2xi3f8rro9P/uTrccJvUVB/pJC4JAWDR9dlfsagxU1j8qzU8lgEYbncaGhy1tdqi7zhGKqG4r5NiwUN9PErAPXUJjmRDBLYWRIApsHLlk1xS6Mtyj0Nbfz3W7ZH6/nzXHOJdBmasrvHNckx+qGLYJ9XnsBpM9eMJBa5RAMaydVz5G0kSrT32KTKwfgmzdxyibw+5f42GsH1Pm3fmcm6KSMgeCknjRNlOdAtqgNtrnQ46Vta8YQpFrcHJtaQTqtEybbL4AMRaxL3I2h82R6fSrqdtcRU4aNzcJgQlT91GIM5awNWED1R418pLxtJ87wOuBPYh9zuPicd90J5DGKGKMrHg+DVeMsbHe3P2dWyAZdeViJyfpFgb6s1Q6wrBm6sQozJYRvGhU/tdGhXy8+VTMh8lvQBRf0CQCPAl1qDKpreRg9KCTm+ITtdpN1BraYk80Zv4DFMKo4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(39860400002)(346002)(366004)(136003)(451199015)(26005)(4326008)(478600001)(6486002)(66556008)(66946007)(8676002)(6916009)(36756003)(6506007)(316002)(54906003)(66476007)(83380400001)(38100700002)(2616005)(86362001)(6512007)(186003)(31696002)(31686004)(5660300002)(2906002)(8936002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VmdwV1NYWVBmaEhCdjUxMEpDWEN6OGhFOEFWaUgybnJMeWx5NDdpaEtLL2NF?=
 =?utf-8?B?QUZ4Z2dZYUErNXdicGwvWDN0cEs5RXpKMnA0bkdORHJIUzBhaGpJUjY5Mkdu?=
 =?utf-8?B?TUZuWENyM05qOXlLQUtXc2U3dUx4Wnc3dXNEYzJRWDY3QS9Jb2J1dHVUeWtr?=
 =?utf-8?B?WkQ4dGdoK0ZGTnlnbkhBYjlWTW4wVVRqbExtS2wzU3RDMC9RNTVrYzhiendD?=
 =?utf-8?B?YWtVWjBxcTdnSVRxbTdaU3VZQjJWdHlqUkErWXpkMzVrQXIwT09Bd3p5aVEr?=
 =?utf-8?B?RExvV29VZGk1SG1zQ0JFY2xMV01xREViNXA3Z2MxZVVSLzdUYXc4TTA5d3dZ?=
 =?utf-8?B?NXpxU3JOVkI4ZVVSbW0zSGJEN2hDQWZQdXo2K0I4bSs0NU1ZVGhPL3lhTUhY?=
 =?utf-8?B?aEpDSHhoMDczcnFkQjVUM0k1Zm05UHBBWGxGMDFXQS9nc25jdzBKSDlHUER0?=
 =?utf-8?B?dENrN0dSdldHNXhEVDNGL2JUck16RTJDWXNoY3FWQmtLaFpEcTQ4dUhNcCtR?=
 =?utf-8?B?ejVWZFlaTkdkZXNEL0hCRi9zYzBDQzc3UTJsV2tzNjRRcUJsUEdaRUJwZ2U3?=
 =?utf-8?B?bzBDb0lHSFQ4WXQ5Q0JMR3ZZQU9sayt4azQybWJFUFA0RUZ1TzVZS0gxL3Rm?=
 =?utf-8?B?aHJuMWptd3hhQ0FQa3d5RVZzcDY1akE3aDArUXdJcTlIS1FBS2szSzFBQlZj?=
 =?utf-8?B?eENNOUt2ODI0UmRTeE9tTHA0VGhScEJaNHVlYUJneUZuRjV4V0NlVnNwSlo1?=
 =?utf-8?B?MFcrQlhEYURBYjJ5VFVlRks5Wi9EMUFYM1V4a25BdjZLVlIzcVdOS01UbHc2?=
 =?utf-8?B?ZnVZTlRBVTBHL0h0ZnNEWkI0QitYM3pRMW1mZmZJWktlemlhbTN2azVqOWJC?=
 =?utf-8?B?OWZPS3BNUTNmbE9qS2EvV3JuSHVGd2ZGNGdvVW9JNTJCK0kyb2t5RHJDMTVw?=
 =?utf-8?B?VVFHZDBOeGd5S1g0akRRVG5Fa0taUzJ5V2RnVmNtUWVQR0VJaXZRVkhKL1dz?=
 =?utf-8?B?cnVmS1cySFhnbFZBdENBYkc0TEt5THN6UVl2OGExRlJNVVN4UjJLREprMHZ5?=
 =?utf-8?B?eHpWZnc3UU5KYnk3SnMzbkhXNFVVbU55TmFaM1duUHVzVTV3d2p5a2Z2eXln?=
 =?utf-8?B?MyswYmFRdUdrV1loZTZqY3pZYTRLQUx6cVU4Z3dCbXJZdFlSRUw1cjV1dGlL?=
 =?utf-8?B?Zlc3OXBYbUg4T1J6bVhjQjByeXdtaEZGWnUyNUU3MjlILzF5a3k5WFdBNkR1?=
 =?utf-8?B?SnYzNTJxUXNpbjFlcUwyb0lPMElWc0NpZitJLzNxSVBCN01lWGNZNFFhcjkv?=
 =?utf-8?B?YW43MFZvNDRzL3dnSWRlTS92aVA4eFRPU2VxRlg0OWQ4RnZ1STE2amNOUXZP?=
 =?utf-8?B?QUxTZ1lCcnp1ak94OVFGbDhMamJxL1IyTGhJRktFZ3FtM0NjTC9HZzQ1bHF5?=
 =?utf-8?B?MnJ4VEpQTDVxdTRyL2gzYjZYOHFWREZ3U3h6bGdjNGdVVUN6ZXVBYnNSa012?=
 =?utf-8?B?WEpNTHp4bkx1MDdqQXFvSHVkb1F3TTk1NStFY0RWbWgxN2szcWMrOXlUREVE?=
 =?utf-8?B?Z3pTWTRYZjRqODRmNlBnSjhtYTllNWFWcTN6LytLV3FnOWxvMG04V0lKMDFz?=
 =?utf-8?B?SDZ5VnBrUC9MeU1IclBuRlFHSTREVnA5M0hDL09pUEFmQWFGUy93YTNpSmUy?=
 =?utf-8?B?NGdITGsyWTJoNlYrTmxJaXlKVVNIL2NadGNGb3NrVXZXWklKZDRhMG52SGlB?=
 =?utf-8?B?Z2IrSWVZbTBOL3Z3aDJVczRJdUlXRXgyMU5LL3dDTG9yTUZGY1F1Um9OeDMy?=
 =?utf-8?B?ZjlRSEFvNEhHdlNvOUdkbkZSSll5UFpXemdvY3dzRkdsOEEwZE1NTXZ5OGdW?=
 =?utf-8?B?clF6QlZldy9VeHU3eE1ra05EQTBnUWIydEFEZ0JPek9CaENnTjhTMzU3c2d4?=
 =?utf-8?B?QlBueFpMd0ZCMXprUXlCM3VmR1dsQm03ekJSOS9qRyttVEJmU3ZrWWZoNXEv?=
 =?utf-8?B?ZGM2dTM5dm1nQW0vdWtIckthSS9BYWUra2ZpTi9OVWZySW9VSnN1Tkc2aDlp?=
 =?utf-8?B?aFBrQTYzZFpMeVNmZ2NpZmRMby9uK05YQU1QZVlXVDA0M2tKaG40Vi9FcjlR?=
 =?utf-8?Q?+HUmEyErcedhNYxisqzhu+QCN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca33df96-7167-4d3f-2561-08daab6ccd2d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 09:41:41.4233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: moKC9lJzPXEl9xH/RzGFDlcu/OOANfDNc3Z1d9PFwBjBFgrZGm1XmQwT8qjACBwVm2mFA05PM4i+sUaYNatHCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8797

efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
higher priority than the type of the range. To avoid accessing memory at
runtime which was re-used for other purposes, make
efi_arch_process_memory_map() follow suit. While in theory the same would
apply to EfiACPIReclaimMemory, we don't actually "reclaim" or clobber
that memory (converted to E820_ACPI on x86) there (and it would be a bug
if the Dom0 kernel tried to reclaim the range, bypassing Xen's memory
management, plus it would be at least bogus if it clobbered that space),
hence that type's handling can be left alone.

Fixes: bf6501a62e80 ("x86-64: EFI boot code")
Fixes: facac0af87ef ("x86-64: EFI runtime code")
Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
---
v3: Alter Arm change to leave EfiACPIReclaimMemory handling alone.
v2: Amend description.

--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -183,7 +183,8 @@ static EFI_STATUS __init efi_process_mem
 
     for ( Index = 0; Index < (mmap_size / desc_size); Index++ )
     {
-        if ( desc_ptr->Attribute & EFI_MEMORY_WB &&
+        if ( !(desc_ptr->Attribute & EFI_MEMORY_RUNTIME) &&
+             (desc_ptr->Attribute & EFI_MEMORY_WB) &&
              (desc_ptr->Type == EfiConventionalMemory ||
               desc_ptr->Type == EfiLoaderCode ||
               desc_ptr->Type == EfiLoaderData ||
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -185,7 +185,9 @@ static void __init efi_arch_process_memo
             /* fall through */
         case EfiLoaderCode:
         case EfiLoaderData:
-            if ( desc->Attribute & EFI_MEMORY_WB )
+            if ( desc->Attribute & EFI_MEMORY_RUNTIME )
+                type = E820_RESERVED;
+            else if ( desc->Attribute & EFI_MEMORY_WB )
                 type = E820_RAM;
             else
         case EfiUnusableMemory:


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 09:59:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 09:59:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419499.664271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiC2W-0007Ln-M9; Tue, 11 Oct 2022 09:59:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419499.664271; Tue, 11 Oct 2022 09:59:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiC2W-0007Lg-JG; Tue, 11 Oct 2022 09:59:08 +0000
Received: by outflank-mailman (input) for mailman id 419499;
 Tue, 11 Oct 2022 09:59:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiC2V-0007La-28
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 09:59:07 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2042.outbound.protection.outlook.com [40.107.22.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57304db2-494b-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 11:59:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8770.eurprd04.prod.outlook.com (2603:10a6:20b:42d::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 09:59:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 09:59:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57304db2-494b-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i4YhkdpI87yQw3JVFCrmChaACLq/5p6s/CwwfJKF1Kazz6Svw10XQfeJYybyrdpScCflAVsZg/ew4XKVdgKF0+4Z/l0G3x0Q3X4+64BLUzOsGnznbxo1uyQohmFC7ZO+twRD69aH394HHdvNunXyOToYXHhi5t3u9azq7BKSkgbyxmUBzN1LvPcrRg8ZIclKtA1l8DnTMRRdXdGdCNZKHZVNw4UrPu5dMxb8Nroqzoah7ZwTeODMzASIzB0SiW7dwK2aiXnXVg2KL4XjzJNNUBOvDzTXS5qMXivzoVIY0IHjUOGUWJnOV1bSJSxe6FNipfyjtUij8avXl+n7woFJsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aRFtWcXR6mreWH8ttueUTWqNt+dyzYd70iitrGS0ev8=;
 b=VACyDG7Cy32rLETsGLfkMNXZaBckyEVpeWlh5ynyLM9TpZO5kyShm+kmHcM9afV9u5mF2gIjrls6R3feCwoeBB41fEaA/AgXYSMuQaoO2rN9foVByaS8z6EkovJRAuIx5VsSWRH5D9CMp4tLJlO+TxkWsMEnxYSU7eFGBCfdCWBnB/Ihg2P5ENktrJ688B7KJvWKXvpB+v9eCYb15xtAjW2XHI+q7uMjabQMMB/m9C79sdSB04VG10iZVTJ84navQpJ+ieOcLfddLa20EIAtbWE5JlvZULAadeZo69FWW6tyVfyqBuFkPj7pzciT4+hBWNuFeVm/4bXkZpqggEDgag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aRFtWcXR6mreWH8ttueUTWqNt+dyzYd70iitrGS0ev8=;
 b=4QJ7P0Oz+Cio8UQwPgaaUX1dHvP4oJO0B83FspmlvFUQ6fu00BclOola7gGdyeBdpvEYS3ZgmaMS/Iq5LRObKa6ApZoVUWeOfdENwnMiRRSX2FYekHkgEhdmDY9XjdQn3GFOwmGhg/uB45tbnDehpL4bO6EeiieqsCXXF30w4pC2SmNqjvthQOh+XE7k8NQXyO4a5QLur4NP13GhGDHmRVBmrkBLYEIQ1kKjTF9qLxIqZ5R3GHlB4No2ZsET4DtbJRP38T0VZ1HHdpiIYehxishXfGVwKl4Odh3GBucTh27dzexl62zrE+KF+DBM4lexi+8hgb6iU3r+GeweqLpqwg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9c1731eb-44f6-41c6-cb4e-51abf0c50052@suse.com>
Date: Tue, 11 Oct 2022 11:59:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Ard Biesheuval <ardb@kernel.org>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
References: <ce73ae2fa148c5d79a038275b0983d24537e97de.1665458679.git.demi@invisiblethingslab.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ce73ae2fa148c5d79a038275b0983d24537e97de.1665458679.git.demi@invisiblethingslab.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8770:EE_
X-MS-Office365-Filtering-Correlation-Id: bd258242-bb24-4d77-0861-08daab6f3a08
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ud/Vtpa6F2756aJ+6H4YCsv4y3pDhdQ5edTf2qJKeqzG+007tISSqteD1Z3p5Qfxzd+uToagfdVL9kon4B+pfuWjjeHeXMOZjc3sS0zHOSlPyAixvEdz7AzHSakCqB/nmf56gRBZuXPtTA2NHdXY1UZJ6hJ+zkEDucogYXXGTARi6a+bEW9ACpjJ1jSdWM4X9sIF+7lVb9GDqNtK9UTdSbZ0yKd35KAbD17Ri+l4PW/0gCqODXeN/Geecd0QEHP5Cds9fv2eNcxwOE1gQXpvW2HJ/6OXJz7eWbSdwOgCR6sKKZkwu+6KwDfglsN9s1Xdt70hDZnFob/rJY1+UkE2xyO+f20Tl6BqrxrV46Ir1oOuUaKLShl8+UyrYN/xj0TN1G0dD5IqadLECr6n5xOrFduEWig0pFSrkV0ZVtaLYFjIU1hMUaMUlt6uGl8/gSUBeDCSFBFrehkhb75q7K7q4LV6qtMY8ROC6eceueD9Xsio81YpbSjBq+ne7Gw6VEsioueOBEigQVLkazcCdCtYolDlRLv2GR2vfmlGZOTVp8+nAHiBd8q+HzXBddHXDXE6NFW0zmTFQk0Xnqtu9C0nrsMEoze7V25C4wip1/z1A/sfHG3usTJ5CSx8tx29gFcY9E3Qa35t86D7qM7hC3W5r2ovNf8KxPHGTs9AcaSutdAcrIslakaA0+mnqfxUW7fs5yhXxPJ8NrjPcOXiRyGLHaLc4s9tlFVCQQiGliLo8ryz+Fsgdm1DYV6UIds65zeV/BPk2HuTZxWdk7uK8MFfLoXkuiAQt/n23w2/JpQ0G/I+QbEskK8OJrkI5cj2GwWTqV+RV8fALC0ykisoD6kGMQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199015)(2906002)(31686004)(6916009)(4326008)(316002)(4744005)(86362001)(66946007)(8676002)(66556008)(66476007)(5660300002)(31696002)(54906003)(36756003)(966005)(41300700001)(8936002)(478600001)(53546011)(6512007)(2616005)(6506007)(6486002)(38100700002)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dW54Z0hjM1VobUNRL2JYbnBaUk9ETTgrbHp5Nmp1RDNyMnFrN0pOVFZBeDU0?=
 =?utf-8?B?V0VFZTltc1lkWFF6d3B2WFRQT29nbEZYWTVQSWRKMnVHRVpNQzg1WXpvQnhX?=
 =?utf-8?B?bXFGanhYUDg2MWdCekpxRDJtVmlqeXdUREVtd3dqdUg4WWRlSytQTndJRlF3?=
 =?utf-8?B?SHhqWngyM3p6cVVrNDhtNnZrSHlRRTVRZmYzVmYwNGhnV0pUN2JlbnE3eHRO?=
 =?utf-8?B?VGJKTFRBV3haWjBEbkc4RDlZRVZmNWloSDFqclMvMFo4MWk2dEtabnNPUDlr?=
 =?utf-8?B?azFablRSQWxRdEVFa1JDekswV3lEZVhMVXZlQ0NOaW1CNC9XenM2SHU0d1pa?=
 =?utf-8?B?Q1FkNHg0KytZeVV1WUhja0Rva3lZZVNnemJGKzVPNnBCNnI3Q2hRdlNaQVRI?=
 =?utf-8?B?ODZwVTRWaFdRYlp2MmJjWlliR2VuUHlVcDF4bGJ3M0wwcmo5TERXbHB0NWI4?=
 =?utf-8?B?azRWWm5nSzZPTFVIQ0tXMWFKL0xzNEw3bkhBUWJCZTJEMUJCZW5UZ3E0ZXVY?=
 =?utf-8?B?R1NVYmxiMDVFTXhRNlcydWFVc2NCUDdQZ3d4RmtZTTRZM3prNEZhalZVQTV6?=
 =?utf-8?B?UVNsOEpSN3pLSlZ3czdEM2F0VmxKRzgzYXdYYlhhRSt4MThpazgwb2wzaUdM?=
 =?utf-8?B?T0U3YTd2Qm1LdjFFVWdaMFJXSWttNkdXMVNYY3o4SHFFdk5sUkJXdHVueVlB?=
 =?utf-8?B?S2pkYzNIL0VhdWlZaUdaa0x3Njllc2RFSEtVUmZtMGZoQzlGMWNXdFo2OW9M?=
 =?utf-8?B?aThlVnREa0lZT3V5NEpWZ1ZJaytoVzFnUHQ2MGJ3Q2E2Mk82V3V0UzlSNDVu?=
 =?utf-8?B?VnVvVkMzNHptWFNHMFJ4THV0cjRhOGpQTkg2eE9GT29NbUU5TUNhWmIxQytC?=
 =?utf-8?B?SGF3WUxmUFhoUElyN2hLSk10VWRNMXhRS0VQSzE0ZXoyUnNrbHdOeUZzaVBy?=
 =?utf-8?B?VWZQUlVUa2tvV2gzdUpRV3k4ckNMVDRjYkRIaGEwcGxSK3BwdEJ2Vm1mZDlS?=
 =?utf-8?B?Q1VGSzFlNmxxazg2OGQrWkVDSjF4T1h0REZCU1pZREdWczljcERyWXVxMkda?=
 =?utf-8?B?SjJlNW16WEZyVy9xSTduTXFtTHJTT0NFL2theFhXMmJkcXczakttUmlGY2lv?=
 =?utf-8?B?cGlFdHVhaVFiNHpOMmFSci9sUmJJcDU1di93aW1FbUdvNG9JT1JDNlBBNXFa?=
 =?utf-8?B?RERPUW1KNTNBMmVzdGk5VlNCSExoQWh6K1dLSzM4a1dFaGU0djhqMFJKUFh5?=
 =?utf-8?B?Y0gxSzFZd2RvK295L2pyQS84M1NmSnk2dFB5TXdsUGxsYlBRSWdKQmlMMWhk?=
 =?utf-8?B?K1hwaTl6M2JKckVNZjEvcHFmN2tUYnBHSXBFeG9KNHY0VFBMMzJZUkMvb1dt?=
 =?utf-8?B?WitiR0RrY2tJNkgrODA4VXFLczFPWGdBQlR3U09KTlVLSkV4MmIzR08vWWY3?=
 =?utf-8?B?WXdMR0FZamxUWkIrSXZhYWRwRkNGNXZLelpDaEhROVVGVWNlUUFDKzJuVHBM?=
 =?utf-8?B?M2w0SkJqdlJLWlE3UmlxbEgzZEpnbXQyNVIvUS9kTHh3bzRMMk1HYzQyaDZj?=
 =?utf-8?B?SUY4NnAzUEtFcmZKSG8vN0JOSXVLVXgzL2RpMUxKbkJZTEpJQjlQWHhuMHhF?=
 =?utf-8?B?YzZYTXcwYkIvNU91dzNzUUdQS01BekJBcjRkc0doWHkzdkVBZytaR3cyK0FX?=
 =?utf-8?B?dERNaXlSUCtocFZYQklsUXhzcUFlZFpVSDZEcGNFR2JnY2VaVXU3SzEybXJh?=
 =?utf-8?B?K0JSWjhqT3RxUHhMZjZDYlVIMUg2eGVyVlByTDY3QytubVdGUFJycTN4TUZL?=
 =?utf-8?B?VWtkcXRUWlhuWm5uOTF2aW1DUjBHKzcwUU1nbDZ5bmpDL0RvaUlHenF4dFQ4?=
 =?utf-8?B?WkJBRGRBUExPdFF1NkQ2SHM1cFFDTUJKcWdQQ1FFVWlFOCs1ZlpxVVkxeFBa?=
 =?utf-8?B?dlp0Q2pudi8wUWV6YmlEYXVDTjRxRS9rQ3NIaWNEL0k4T2w4SlpPYjM1c1VN?=
 =?utf-8?B?dGxWUzd4dzIzOWF2aGZHeEllamtOQzZUbVlxd2YxUU5aZTArcFJsdmdoYWti?=
 =?utf-8?B?Ujd4ZmpUYUpIaWRjdmZPMURMUCtwRHhRNGZVUmV1V0hadVJoR0FURGFBeWFw?=
 =?utf-8?Q?Ku/jiXv7TqqCeBgGunuwTyxTt?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd258242-bb24-4d77-0861-08daab6f3a08
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 09:59:03.1702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yCKH1SM9ZHhw4RgYTZ87k//nBmHaDi9VbIbgaVk1R5lhc2e/VjqKqLp9pVXwTB8ySHxQQSIwZWgcG63QAnWexA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8770

On 11.10.2022 05:42, Demi Marie Obenour wrote:
> A previous patch tried to get Linux to use the ESRT under Xen if it is
> in memory of type EfiRuntimeServicesData.  However, this turns out to be
> a bad idea.  Ard Biesheuvel pointed out that EfiRuntimeServices* memory
> winds up fragmenting both the EFI page tables and the direct map,

Can this statement please be made describe Xen, not Linux? Aiui at least
the directmap aspect doesn't apply to Xen.

> and
> that EfiACPIReclaimMemory is a much better choice for this purpose.

I think the "better" wants explaining here, without requiring people to
follow ...

> Link: https://lists.xenproject.org/archives/html/xen-devel/2022-09/msg01365.html

... this link. Since the code change looks okay to me, I'd be okay to
replace the description with an adjusted one while committing. However,
if you expect the change to go into 4.17, you will want to resubmit
with Henry on Cc:, so he can consider giving the now necessary release-
ack.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 10:01:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 10:01:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419506.664281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiC4h-0000Ot-61; Tue, 11 Oct 2022 10:01:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419506.664281; Tue, 11 Oct 2022 10:01:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiC4h-0000Om-3I; Tue, 11 Oct 2022 10:01:23 +0000
Received: by outflank-mailman (input) for mailman id 419506;
 Tue, 11 Oct 2022 10:01:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiC4g-0000Od-26
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 10:01:22 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140053.outbound.protection.outlook.com [40.107.14.53])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a7d48b1a-494b-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 12:01:21 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB9278.eurprd04.prod.outlook.com (2603:10a6:102:2b8::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 11 Oct
 2022 10:01:19 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 10:01:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7d48b1a-494b-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NIfILdPyn/W44petXoqAmYP7ohhHMihvbANmnS6q01vZfBcFyZfuFtTbIMXGdGSOjkDgHMC58FvvW6OtbbnGsKc7OPeDTBHC4h7GDI+4s/Y6dqJHx5ykIrd+hFIeIEgsbtrGJ1Dcu5TUPdpD8Ee0MkbOv0H4X3vgwsKh42wVYQ9uxwXYSmnKUxnqA2kRp64m9gNCFQEgU72HoweFq/DYT2NNUMXFMbN90mn7fvSdaeB6NEtjoF2m91eKSOdWCmfpOHOCpp+gHMp31ldPlIp9CwCIp1sDguBfk1/sZ4dBDROKE8lGT608EkaPK2SYmeLghfW74z8OXwZ87rPVYUWutw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AxpY7tfm4Gi4neBIrsxFJNMvPDnzEcd6Y8/4zEBSaZM=;
 b=d4+mTBHfYbhCvT09yiunCkb7C2vD3edPoQdrTkuyijl7W/tfaZL4pOrGj1KPulN7PudcKcWU0sebadSAge8Wnsm1n+aqk/pnWAMIHbcE4FuQGUs+FkAZ9Ox2dKGaI17Z+bZYZnHx7hd49rHyp0/lZMJX5dwsrFAmA7l/H9fO1w14DhE6Oroozv0SVyrG9wB944ATaLjvHuYaUazKyFtlWWdDYrWF+MdwftQyzHgTe0U6unuJk2UnBXygcg4z7xP7q9Bh3Eh+Fpi5xz0xSZrz7Zx53kOtbT05E3KSkBW38a1nGA7e21luu59qxYc2aZpgj/9Lyac9jvRR8P2PgPaMtA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AxpY7tfm4Gi4neBIrsxFJNMvPDnzEcd6Y8/4zEBSaZM=;
 b=RxTYsCaLCYPQHIP/9yLXpylrT6o2q7MkvK7SJqYluTyAaLurKWvLf5QqlAU6vzVSXWD2Yeg6BEDHnajSlFl7umSdnCg6/chR4dYZwLzstHVMpBKsLcYUYqU9lGqr4ZdVemTEoIOq/yrzf5Nc44aOQMaP/QntUf/AuOk1Zb8LnUodDVkZFAv4eCZiW+RaQPgsCaza5qrzBf48yxion+hJ1AHxmoJ4U114dSccmdO9GCqQTpFRNEAg6WcAV67qE56IAWzmHod2Qkt7V/QVXTL7NO65p4JNlQj0GAyUud56RqCIBxf56h25VeVQZsfWOAcsHtJF91SFc0Sm06wyqloIOw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1fc32039-5a3e-5f74-d6ab-059ab8037338@suse.com>
Date: Tue, 11 Oct 2022 12:01:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: [4.17?] Re: [PATCH] x86emul: respect NSCB
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang <Henry.Wang@arm.com>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b0103a30-22b7-c010-3e8b-6eab1c25ee47@suse.com>
 <f5851974-86ab-8da7-3b5f-4196faae7969@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f5851974-86ab-8da7-3b5f-4196faae7969@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0120.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9278:EE_
X-MS-Office365-Filtering-Correlation-Id: 7780e50a-0254-46c6-4d05-08daab6f8ad6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XE9LpqsQRJJM29YxtsuftOck0EFPaVlh0W8h3YmnuDDcAdvdMjkFQoupIraerCfppG+kh6uSELFQ4s0a2RB9ov2Pt8mESMnTZvfifRWPOdgXQHJo9zQyJ4uxjUkjiasNX8/Xq7SpguLGX0SzQuumFBPNHAaxcuxmc6S6/np71PBJNexafdrMW/Gk2wUz8AKxYZc8MZh1IlIcEqGAl9ZcMV5Kx4YFZsKY43QiYCrFvlbFYWppgxVS4kiaeVLXs/2J/qfsLTdg+atTnz/LO5KUCj9sZuAa9x/dIgX4WgBh64Yx7ECOmdS0X09tyNF0cG2KlbzqINL9UECg8O/uLufn6HWgsX5VToVHaypFr+6wQVoQTSGLNulwygt6vsPPrrc7mcLSBJUz87B2qdoVENNHQabKe3REOcwm8nWurmS/qXImUuBFfCSq2uAWfu3vTSUXQ0a+MK52efduecpwqcjdtN7uCm637iWI1zdOxuWCDib09jP5gzRilnTax6pyEzooB1a5WSEDnC/YMoUucAhBYIMpQHdGrV+0yoPSgkf6GqarXIafz46B2pH0r5ZHA6uIThVYOkNr3mJCgEoy2qVSab1SF3snk3/9V1cAsuqUUQ3pm12PbC84of6jzoq2/4i1iVGH9FXHh8M96mqMeLcL673DWbN6YRrYmTp9fpF6U4sLHFDV3CNd7rL/8gF2VOeP9HBgIyncguvFfd2+nBzMyo37i+yf+q+jJiSwG4lRXpIGjB0111AfBu7k5jo4NmF8ZwPx0/W+X1tuBVCoXodnyfLxVdWXj0+fPOegiMAlO4c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199015)(54906003)(110136005)(316002)(8676002)(66476007)(26005)(36756003)(6512007)(6486002)(4326008)(66946007)(38100700002)(66556008)(31686004)(31696002)(478600001)(186003)(83380400001)(2616005)(53546011)(2906002)(4744005)(8936002)(5660300002)(6506007)(86362001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXh3OE9ZUHhzTW1zVktBMUhKZ0JZamNqK0JoTzMvVlRLSWdMeS9vOEswZnV0?=
 =?utf-8?B?S3EyZjNManB5blI3aGp3ckdOTlVVcG0yYWtMSzBpRURxZVQwR1hFZ016Z1g2?=
 =?utf-8?B?Q2kxU3lQTGFiVjljdW5UQUxCckx0dmlQTTBaQ25NZGVFT0RqYjJFQzZkSytx?=
 =?utf-8?B?UlJPV0grZi9Wd2hWYXVhdTU2S1dvR05TZWFtYXprYlozY1pZSW1Bd3ZadnVj?=
 =?utf-8?B?eFZRUVd6WlI5ZUpuV0ZVaVh0aVZBOTc0WG44WDV1SGdlRzJ0QnRBUHcxNkxF?=
 =?utf-8?B?MHU2SWgxdWlrbVFseGJ0UGU5MDFyMGlUZVBzcUk4dWRlUzNUcFZmYU1LKy9w?=
 =?utf-8?B?M1BUYjBUeXFVN2xmRHlVVFZqbjYyZURQVGczTi9VN3N0dnNUWG0xTi9lbE43?=
 =?utf-8?B?cG5iNHNBdjBSR2phdERoQ2x3U0tTczNCR3V1Q0I3SkRFTnN2aGxvZjhZU3Nv?=
 =?utf-8?B?bGNPci9KeXNUd1ZINkhRcWI0TG90cnZ2R204ZzBGZS9nc0U4d3pLVEU3ek1V?=
 =?utf-8?B?ck5tQkZ1NGN3aURDaTM1bzdMZllLTXpPSG9hNkpJZ0FCTUhqQnkvY2x4dWY3?=
 =?utf-8?B?RDFXMUpIL09wYmxyZ3JaK1BoaXpHMnJ0MWNyL3MxU0ZRQmN5TWg2VXBYNzRq?=
 =?utf-8?B?cXVycnpWSFhrNlk3NWZxZHBEVjVoVEw0Ym40VjJ2aHgweDgyeGlLTSt0Rklr?=
 =?utf-8?B?S2xjRjVVVTlmWXJKdDJtNEsvRTB3dEdBZHpFRGpEckN5QVFOT0NYcGRFRldO?=
 =?utf-8?B?eHpmMWVQSkRkbkdaM1JIb0VicVhFYlQyNFhpYk52OEMxRFk0M1dQUDdjY3J0?=
 =?utf-8?B?dGhuMFZ3WHZQUlYxTDZldkFQTDBheEtVM3lJMXpmQWl1NmRFUTE0cUJmM1B6?=
 =?utf-8?B?VXlGTDhnN1BZbUI1UGh5U1RMZ0xPeWkvdDJxNmlNTFEwWVU5OFFxZE5MRW9W?=
 =?utf-8?B?UjgzSVFBOXpDSkU4QXI3eUpudGR0SnlvNkxiRTZRVHZJZWxmbUtJVnVuZkVS?=
 =?utf-8?B?NHVrMzNuR3pYemg4RU5NeERPYmpISm5JUDRIRytyc2lWajhDNDhscjNRNHJi?=
 =?utf-8?B?eVc1NnNYWmRVOWNnbXQ0amtjcHJWMlVCaWJwTEdlN3RiZE9Qems0TjhyL0Nw?=
 =?utf-8?B?WEpqUFRQak5WS0tGd1hYeG16d1BNa01weERkZnZvamlQVXlhaXRQdUpiYjZL?=
 =?utf-8?B?UFQybjZLekFQbnNEWUJCc1FjUDVYZktORUFkR2daNkJsS0RwTGdsdXB6NDFK?=
 =?utf-8?B?YjJ2RFUzNFNaZ1V1Vm9BaFluZm5iOElaZUR0NjFBWlp2cEJEQ2ZYNVcxVHVr?=
 =?utf-8?B?UHJVRGsyT2NHNkIzY01UWXJ2MWlNSG5Ddmg0S1pyNEwyVktLUlE1OWZ1ODZT?=
 =?utf-8?B?bHJ4bks4T2l5RVZpUzAzMGJkOUg5YjN6L0tZQlJPWEoxZnlpZFg0endWUE01?=
 =?utf-8?B?WENqcWZrdE5nOGdWRkRhN3dWR01rc0JhZTg3K3A5TnJETHZrL2xqQ0hpRUhm?=
 =?utf-8?B?Wkl3aGYxelF4MDN3T1AwSTkxclA3VXZzOU85OHpSbWJWZEk5eWJPSmE4YjhN?=
 =?utf-8?B?NGVkbTNtSUpPa245a0E4TmszSTAySVVrdkhMc21FaEhqbWZ5Y3ZrUUx2Q2FM?=
 =?utf-8?B?QW8ySE82dFhPNkJmaCtnTEgwenpNWnB6ZTAwcWZnZktwMjZ1cjlJOGZYeFJo?=
 =?utf-8?B?TVFqV2U4enFRYlgwNnZlN3dSRDd5ckRxVG5YemdQV1ljSzRKclVMQzIxNW4z?=
 =?utf-8?B?R1B5TERLeGxZS0d5ZHUza1ZqbGZIUDJsNUcyMjEwQnh5UmJ5UDM1ZE5SZ281?=
 =?utf-8?B?Z0ZLQjhQS2NDOWpncVpRWVc2K29WTzVIbTMxT0h5ekgrSzlqdHZRRVVRZnFv?=
 =?utf-8?B?UGlYdE9IbzFGRGFkZGhLT3lNcWpYZTJXblo0cEE3eG1JNHQxeXN2OUZTekFH?=
 =?utf-8?B?UExvMUJURmVHYzhaOXRGQk9wa0JmaFJiYU41MWdFVHBHSE0xL2dvN3RpaGo5?=
 =?utf-8?B?L1gwRzNHOFBVNTl3RTFHMWxhU3lTRHE5d2FMeFZGOUZVUFVjWVZGQUN5ZHV1?=
 =?utf-8?B?TkNsaGx1UnZDYnBCQkR0eU9qb1pwR20zV2IwZGlQd0o5a2lEQkQxcE1nZDY4?=
 =?utf-8?Q?8Se/ONQChukFaQfonbDIUyhb5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7780e50a-0254-46c6-4d05-08daab6f8ad6
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 10:01:18.8647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vbIzsf3b6vCTZeWdR/IbGTsx3f5zvmA+f9WvYzta0H0BZmVoY6i2VmH+PhpTvp/IQF6sgB7YMeQ0uwdD+2/WMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9278

On 10.10.2022 18:44, Andrew Cooper wrote:
> On 15/09/2022 08:22, Jan Beulich wrote:
>> protmode_load_seg() would better adhere to that "feature" of clearing
>> base (and limit) during NULL selector loads.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

Henry - this was submitted before the code freeze, so you weren't Cc-ed.
May I ask to consider giving this a release ack?

Thanks, Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 10:20:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 10:20:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419518.664292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCNK-00037F-O7; Tue, 11 Oct 2022 10:20:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419518.664292; Tue, 11 Oct 2022 10:20:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCNK-000378-LO; Tue, 11 Oct 2022 10:20:38 +0000
Received: by outflank-mailman (input) for mailman id 419518;
 Tue, 11 Oct 2022 10:20:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiCNJ-000372-6R
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 10:20:37 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140073.outbound.protection.outlook.com [40.107.14.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 583b7658-494e-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 12:20:35 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8997.eurprd04.prod.outlook.com (2603:10a6:10:2e0::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 10:20:33 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 10:20:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 583b7658-494e-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZKRIOFcung8purjBz+ylm+c9qMxg7eJlyzDYB1lhOAUyqoGfp2AQ7tPFuQr6HaghpnZjytaEL8KAwrJfB06JRzchgXv7Z3+SViwzuf3+kVgsaHpJn9X7gz+eFxiTN4stjv8ae5bBD8Ge+9FVuu8ex5c9GW5+g21N6Ek7Wr3GRzx/nKP9uHgMCaZVJjmrM3VqWwwTht3/WvOoe3wrs+1a/Dm13OxaPyi1XepaP67ckyLyZQ3W98KGneybIkaIPRcOgQH3ns0kSxQHklxWL0tHyuC6V7cveAr9mbha2DXlNim4BwhK5VfpcXrCNKsdMThe2MwbylEwWkmq3OyXJ+RjPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h8WS9LAcEqfvEKpatDzokNE1RHUHaEmluWzzsaBKdys=;
 b=hIjX06cZuYlMLk097TxgWPslaMWdGf1R/M/+WHXfTfOKOvKrVxuvi/qEz/4GRLB3LkBGnPgq9NarmPMQ3IfYmuGsW9BXU7SqjWPSVgcrSnK8wN8g123SOmGH77v0VHWn/aqGNoQKku6iBZngajh7D/nq+/0o0QIOmzRNde9ZPlmKRnL9d+YZjHlGkNn/Gb1Nelv5JShBWk868LNmV5ZPNA55Ip86nCyh8kC4wANB5izYrFbkDevm7rdMkd/Tumn+5eKOtR7UeEQXlKhe9g5vZ3DhP86BzjdDjQL2sMNElFWl2/kkFTGSwfrlnN4BTJlge14sh7idLbGPwXeRfR3oVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h8WS9LAcEqfvEKpatDzokNE1RHUHaEmluWzzsaBKdys=;
 b=w/QeKJWmhLytvqLPjnMJsg7M2WhgslpvkusSaxh5iTOV3NOvuFNrDhTnodLENvrNSeCd8owTNQN1NAo3jBOZnuZhOsKN2EOHB+CrwTuSpt4la7a2c8wgs4E0HSJDEs5VLpePvOFURDZQo12GqzDHhcI3y8z+0zAwijlmZdvqnQQ+87E0LOYBHZWhDOrI1zQj9BUBBHOKXJYv9VycaMEOWrDTYOaWITPKUBk440y4WVK0HyRqK+DA5IbefX6OTvg+SXJnSHCm92L+AuR1qZodnnSBTJq4o7SO0BI5KFzuBaGaKPoHRjuIZCNVOQvPPxksX0g19KO46EH1cmdZnPw/FA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0fe3af83-a743-5edd-1c83-921f5e666039@suse.com>
Date: Tue, 11 Oct 2022 12:20:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
 INS/OUTS
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
 <4d01771c-fd02-b607-c480-04bcb11fa7b3@suse.com>
 <2dc898c0-b42a-28d7-7126-9379f03119f3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2dc898c0-b42a-28d7-7126-9379f03119f3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8997:EE_
X-MS-Office365-Filtering-Correlation-Id: 2414ac20-2191-4eff-35e0-08daab723afc
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MTlCnHPyRWTOgUkblXdlemyBYiwcByY93nEoeF5+FMN2u0Hrln5nRm1lmAOnRSHnGHjZ/GUqvQyvQBUBsP8HiVwEWkkefFcwjHXYeuo/szAXXrvrIatb08Sk7/QhinhsAir+AuUgmmizp6VMKqcu3/pk3toIShdGCG9VUsk0KtdfWPwp7QUz5ZqduPM2k4nlsWfaEe+BDS9Ln1E2R2ZTnmMAUSBtIvpwGf4xFOLbNZKgInjRxDWUObzKrvkMjb2TI9EsJF9XMuIy6WlVZHOXnqF8qMGUSl0f6lr4lIGSFV2UW4E53tRPsRwY5eDsqyA/MdzuR6sd/lyYqG+IB7hSOes7+EXC9StiUU/5+e7o65jySMsYx2CN4a8KQPclKx5G9zjTWGiUj6rfYPOTre/6bKdPNd5ivSFafuhkp/w0TAVC8QYxQeZyogOLQeUtBkmHfuVCQ2AgNg165uk0jAzeLV4a0+N8/khYrGAkiWGcnE//X/PHuq5VFDX8A22tFSql9wpiOH9YEggntVueZ5wCJGbnaEWsoWrVLt2Yw8nijjd0QKogzGZjyeN9APYUJdnAPFi250Xjq+OGYHHj0AMHwuS+OxyeDfc7NcRap2AjSEHQjvrhYRs/B4NqHVCaff2z+XIfCDFQE+1jJtiovp+pXlFZ86XU92c+ZNwtrUYIhaV4bTXE0blOq1oVhtkDlBxZFXt2eDW78MYVzm4YGa4grbVBgX4uDD3WyYzxYL9GTAYL+T1Ca0paaVT8BpZwUPylp0z8PO9zZ+ITUshJiEW2Zo1GzGrLaxmbC6QNoa4lwZ4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(346002)(136003)(376002)(451199015)(31686004)(36756003)(8936002)(2906002)(5660300002)(31696002)(66556008)(41300700001)(66476007)(4326008)(8676002)(186003)(66946007)(86362001)(83380400001)(2616005)(54906003)(6916009)(316002)(6512007)(26005)(53546011)(478600001)(6506007)(6486002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkFJdmNzOVBHU0lRTENsdlVpOW9UaHNBZDdqYThrTDh3aGE1aTY4UTlDU3lD?=
 =?utf-8?B?U3VUN2JlNVpQVEpFODZxOUtHTlVoWjlYNk5TM1FxYit2TnNFQzZBMmUzeSsy?=
 =?utf-8?B?MldpSXdwQk5IVEQ3RmJTL2s1ZktEaERhR1YzMDgxU1ZqR3VlZVhUMmtCR25C?=
 =?utf-8?B?QXpVSkVBMGlTekcvNjNFckJSWlVSckRHdXpyNUlKSmREKzhzaU8xMzFSVVRi?=
 =?utf-8?B?MXV6YXN0YklIS2JXVFB4NFIydUxWZGxsZG5OekhLbGVndjVBQkZ1QzVUVmlz?=
 =?utf-8?B?NTdxbGZaZTdweVZueVBWbHRKaXZRV2YyZkFCK1g5ZTc5eDBBemFBbGhIbURJ?=
 =?utf-8?B?aThVSFRvU3VtSEUzSnF5OHo3dWtNMFFGR2VwQVdPbVphWlBoVzdmMFo5Ujd1?=
 =?utf-8?B?Y21VZm5aZC8zY1dvMDRWRm5CVENKMHQ0M3EwZHJQd3FabWtxeVA4SElFVkZo?=
 =?utf-8?B?djBKUm0rK1RmNnQvSW41RGk3dVgxR0ttU1lTZ3hNVjlHMHBDdnhGVUR2c2RT?=
 =?utf-8?B?S3NVSXdZRnJhRDZHN2oxVGxnL2k3M1lvbUNWNWtnTGZBcXkxNCt5YzRzc3ZR?=
 =?utf-8?B?bEt6OXQ0UWYySDkvK0RmekZKNUlPWnVQclRVZ1IyTG0vYllEM296a1hGK0hi?=
 =?utf-8?B?WlRzaklJNVphRVdyUWlibkxFTUVaM2RXRnp0eXBRc2NMT01kSVZGNWtpNWts?=
 =?utf-8?B?OUNWQXFjL1dOOHFDRHBHT204R2N6NzhNUWJ4OTliOExKR3JHRURQOURFdWZH?=
 =?utf-8?B?WUZZVVZTOXl0VU5iMWxnTTgyRE9QVU1kUllqcUJiMGdodUVPNjczUUJEa0ZZ?=
 =?utf-8?B?aWtBQlJqek52R2R5L1hlSWJBaE9lMmUrY2FMSmhSdkZTZG5IdDdWT3NRcFFj?=
 =?utf-8?B?TDVlaCsyNXJUaUozaFRVeVhjUDBRT2dOOW1NTHZGbXVIMytnMCtOTDZtSThq?=
 =?utf-8?B?dE9jUXI3SkxMN0VFMGxTNzZyNXNKKzRUTEI5M2o0TG40YUpOek41ME0vTEVF?=
 =?utf-8?B?YndHOUpBWXk1TDFJUEVmeHB5aVhxc0pvdnZreG9vV2ltbEk3THBlbm9HY3Av?=
 =?utf-8?B?WXpWZWxHQ1ZFTDJWVThTVU1wRm91WkN1ZVpIRHBxY0E1dzh2d2QvR2NENUZI?=
 =?utf-8?B?TWFWdzdnRDE3RnhQbEp1SGZzQlc2QWtaQjF3cUdtMzBkRTFLWGRyb1p1Y2xt?=
 =?utf-8?B?Sk1NS3hRQVd5RUl2S3l6MGdkenRZWjJEOVJjNE5XV2srN0ZuSzFoTUI5ek1n?=
 =?utf-8?B?eGhPcVNuNlZHMW4wTVh1KzB1Q2lWRkxlVkV2aDhVdUF6UXh6aDhxOUZJWUJN?=
 =?utf-8?B?eUorbUFDSTVBcVNBRDVHY2pkcjdpNWpTUkJmZVhJcmRSa2dwQ2dwdm90eW1G?=
 =?utf-8?B?V0s3Yy9LbURnaDl0cHVVZ3hnQWRNZ3I4SG1TT01wQUY4dzN2RmVpZEpuMWF5?=
 =?utf-8?B?WWQ1OWNoTlFqeERmR0pBUC9DUk9UMzFoRmZPbnhtMEtwZjZZS0dDQ2RqNlp1?=
 =?utf-8?B?VmhIZktYc0NENDlYbGV1Z2FvTEh2VFl5THFjQ2tuSStmNllIbFRJY0tCV3pL?=
 =?utf-8?B?QlF6SFhEVTYvMTVDaUZUWkVlaEw0blo2d3ZvcjQyb3grbDROOW1WQlozQnVR?=
 =?utf-8?B?c2NVZStHako2aHBhUHFrQTlZMnpOUDFGTUpWQ1QwVE54a2pUTlRzWU9HVlRW?=
 =?utf-8?B?NCttZnM5aFNhRHJhWDc4RW9uL3FPUGxaT0FoWkZXU1ZHT21Wa01Ed3lzbXBq?=
 =?utf-8?B?OEs1NHphK0ExeFVFcGRUR01CUlRyMWcvZFJSbkJFdk5kQ0pvTFgyZG5haVoy?=
 =?utf-8?B?M25ZbXlXZHRhZ2NrcEFXdWJJekRWWG5VVnRVb3grODhNdmlkOFdBOVMwY3Vv?=
 =?utf-8?B?ZUVKTWk0UzdBdE5NVllQUmF6Z0EwR204RVlycDAyaEhtbjZlRm1iNlk2UUtY?=
 =?utf-8?B?NStTbnNkZmVWdUlrbXlzd3hhaFBlb0N1VWJPRFpwUHpvcFhWREI0czFidGJ6?=
 =?utf-8?B?c1NRSGtvSnEya1RaZVJEWk0zaHJYK3VQc3pIMTBBYzVxK2syZ1hONmc3dzNT?=
 =?utf-8?B?dUlKckEraEt0Y1dtM014blpLTEh4ZGlvaEZXejdqOVNXZ2F4cXdYUWh4aEZS?=
 =?utf-8?Q?iF2dLBwJVdGqjCmkPMVDqdvVh?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2414ac20-2191-4eff-35e0-08daab723afc
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 10:20:33.1825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QGL2g4HUFDYCmm3obzdanrW/HOoQDlqX0/gIoEMEt2JKTTPr2D4/nTpXEqj8dmjNxZvVjZmcObqqJlMfLZKSBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8997

On 10.10.2022 20:08, Andrew Cooper wrote:
> On 06/10/2022 14:11, Jan Beulich wrote:
>> Based on observations on a fair range of hardware from both primary
>> vendors even zero-iteration-count instances of these insns perform the
>> port related permission checking first.
>>
>> Fixes: fe300600464c ("x86: Fix emulation of REP prefix")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Partly RFC for this not being documented anywhere; inquiry pending.
> 
> Intel do actually document this in two roundabout ways.
> 
> 1) The order of checks in the pseudocode.  Multiple times in the past,
> Intel have said that the order of checks in pseudocode is authoritative.

Which pseudo code are you referring to here? There's none I could find
for REP, and the INS and OUTS pages doesn't describe this specific
behavior for REP INS / REP OUTS. Instead, if the description of REP
was authoritative, then

WHILE CountReg ≠ 0
DO
...
OD;

would mean the entire INS/OUTS operation is contained in the body of
that loop, leading to no possible exceptions when the count is zero.

> 2) This paragraph I've just found at the end of the INS description.
> 
> "These instructions may read from the I/O port without writing to the
> memory location if an exception or VM exit occurs due to the write (e.g.
> #PF). If this would be problematic, for example because the I/O port
> read has side-effects, software should ensure the write to the memory
> location does not cause an exception or VM exit."
> 
> This makes it clear that the IO port is read before the memory operand
> is interpreted.  (As a tangent, while the SDM statement is all true,
> it's entirely useless advice for e.g. a migrating VM.)

I, too, had noticed that paragraph. But as above it adds no clarity
whatsoever for the count == 0 case.

> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, preferably with
> some of ^ discussed in the commit message.

Thanks, I'll apply this provisionally as I'll need to wait for an ack
from Henry anyway. In the meantime you might clarify whether my
responses above (which mean no further discussion in the description
for there being nothing to refer to) don't find your agreement.

>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -4248,14 +4248,15 @@ x86_emulate(
>>          goto imul;
>>  
>>      case 0x6c ... 0x6d: /* ins %dx,%es:%edi */ {
>> -        unsigned long nr_reps = get_rep_prefix(false, false);
>> +        unsigned long nr_reps;
>>          unsigned int port = _regs.dx;
>>  
>>          dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes;
>> -        dst.mem.seg = x86_seg_es;
>> -        dst.mem.off = truncate_ea_and_reps(_regs.r(di), nr_reps, dst.bytes);
>>          if ( (rc = ioport_access_check(port, dst.bytes, ctxt, ops)) != 0 )
>>              goto done;
>> +        nr_reps = get_rep_prefix(false, false);
>> +        dst.mem.off = truncate_ea_and_reps(_regs.r(di), nr_reps, dst.bytes);
>> +        dst.mem.seg = x86_seg_es;
> 
> As a further observation, both the Intel and AMD manuals elude to the
> use of unsegmented memory space for the 64bit forms of these.
> 
> However, as both %ds (outs) and %es (ins) ignore their bases in 64bit
> mode, I can't think of any practical consequences of conditionally not
> using x86_seg_none here.

I find "not using" irritating, but perhaps I'm simply not reading this
the way it was meant. I'm convinced the memory accesses by these insns
are normal ones, so using ES: means linear address unconditionally (for
INS) in 64-bit mode. For OUTS, however, I don't think an FS: or GS:
override would be ignored. The SDM text also doesn't read as if it
would, to me at least. What is it that you have derived your reply
from? "In 64-bit mode, ..., and 64-bit address is specified using RSI
by default" (for OUTS) doesn't say anything about the segment override
being ignored, and earlier text actually talks about the possibility of
an override, without restricting that to any subset of modes.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 10:31:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 10:31:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419530.664304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCXo-0005Bi-Oe; Tue, 11 Oct 2022 10:31:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419530.664304; Tue, 11 Oct 2022 10:31:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCXo-0005Bb-L6; Tue, 11 Oct 2022 10:31:28 +0000
Received: by outflank-mailman (input) for mailman id 419530;
 Tue, 11 Oct 2022 10:31:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiCXn-0005BR-Qt; Tue, 11 Oct 2022 10:31:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiCXn-0007B6-MP; Tue, 11 Oct 2022 10:31:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiCXn-0001Ah-91; Tue, 11 Oct 2022 10:31:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiCXn-0002uc-8a; Tue, 11 Oct 2022 10:31:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sYg567NMbiKkKh0CDUpIW+yBQJBvVFjDT/6Zfihb2gY=; b=yK/n6HvLeInJsTcMsv2SxTzZd4
	8BPuI8u44XZi4gbDDB/GWYevlNNV6BpyilgzIybF80SZ0I5Ro6nyUhB1wGPlSPpAVQUv2sxQk3Ie8
	dHqA4C/wGaSaL6mPYgxYVwdeOZJYFMXdNA9+d5e9c3kbbHFphnGkEq1K2MT+Xx5JakvQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173490-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173490: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=68bf64778846baade8ffcc40cc17b0e9d1d78545
X-Osstest-Versions-That:
    libvirt=8ef8d9e21b10f62cad0c36a6ac2b57ac61acd0ec
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 10:31:27 +0000

flight 173490 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173490/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173468
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173468
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173468
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              68bf64778846baade8ffcc40cc17b0e9d1d78545
baseline version:
 libvirt              8ef8d9e21b10f62cad0c36a6ac2b57ac61acd0ec

Last test of basis   173468  2022-10-08 04:18:50 Z    3 days
Testing same since   173490  2022-10-11 04:20:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jiri Denemark <jdenemar@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   8ef8d9e21b..68bf647788  68bf64778846baade8ffcc40cc17b0e9d1d78545 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 10:32:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 10:32:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419541.664315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCZ9-0005pE-9N; Tue, 11 Oct 2022 10:32:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419541.664315; Tue, 11 Oct 2022 10:32:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCZ9-0005p7-6H; Tue, 11 Oct 2022 10:32:51 +0000
Received: by outflank-mailman (input) for mailman id 419541;
 Tue, 11 Oct 2022 10:32:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiCZ7-0005jM-SC
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 10:32:49 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130089.outbound.protection.outlook.com [40.107.13.89])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d384544-4950-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 12:32:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 10:32:47 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 10:32:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d384544-4950-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PgdBzoC8Mce5oREt/6h1OfZitjGn1wYrsOhVOdrwVzPuHEgYDAGf+dYGqqjsy4tjtc4PcPOcUqXvMnGTcdBPooTLfate3q864JgRE2xV3J7hFvt/2/qSab0ZIhCZ2Fugyj6FI+Lvu1nz+S5PDb5FGuJ4CKbcOhonfAo6C3mDIGSgRG87DMJa/yVJkTqvcpWt96bp+uOM5DLQbEZ5UXSTdEfmpVgIct2NGPhJFNt+zRhdygXH8R6vsZ85W9b5KKuB37syJD85mkkq3utes1+gEGhPmJerTRcUlgsRfq30NwVep+RbdzjfLIGVcCf//q4GufkTjpr4qgXPzIXU2AuT0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=scZ4KbixaPv599tYfN4CIeBtDOwAInSpvwmi+VBdTAc=;
 b=WQ8rQU6I4fqXMbqW/VQ+4MuzGepNd7GkjH9B/kxNyawSGV81jc+CDljuq5/EQfJ8L+ZsAgOxv4Ia5POGPw8teTG8JTSEHnAZKWVjjxlvMkJjHWM4bXLAttmDmJSPiAiu6LfASiZbOvQkYMo4p4eayIMnighl3qqJQVth8NjvyzDlwsnFsoTw2jir+bx20Z1CX0FMmGwFpJHlBOINzAbpSUADqcssI1ylONVQmzSsnxz6ocaWJu4vMS4+ZGkDuiOFjGAAWB9KVWnd8x/r+LeNk4fRKwypemoXrb/cP+F+1XXHc7x9cXfFAdJr03Wg+zX96uux4QV0m/FtVlgoQrWjkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=scZ4KbixaPv599tYfN4CIeBtDOwAInSpvwmi+VBdTAc=;
 b=L5bovrEGoPCT6acIKmQUC/cI+G+URKUJlHEFRqEtcEaDXs9brH/F5zqzHxDzPtoKQLvYs+ZRao+HTqlStA/nzNMxJ5i1782GWWs63hQqpjhv9xsQb/3OjEj4cgVMqc4QHAkK2avhDyFmDxjXnnuIqrdQVjZNDz+pgA/JPiS4Q+K3oQLdCNlpDbSrmbt7vWtJ0FuDGunVumRTWmiBmNHMDxEbd8YIIAkgJXfnF0qIwhthU9Y99rRLIFjMTIbIW4yTOkAUR83gb5wD+ElsBuBZgQieic8GJ4dqMQANtZdQW8wUndr5HITiSUo2htNhj6zzbLiKdRyen/hK2lXg6ScMCQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3f0fdef1-7e70-3d6c-3e67-aecc7bcad051@suse.com>
Date: Tue, 11 Oct 2022 12:32:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 1/2][4.17] x86emul: further correct 64-bit mode zero count
 repeated string insn handling
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
 <1dac86de-cb8c-d2b2-d0ab-bf76707d22d0@suse.com>
 <9c407e09-4af8-b021-293d-b1db8a0ca4f9@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9c407e09-4af8-b021-293d-b1db8a0ca4f9@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0081.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9186:EE_
X-MS-Office365-Filtering-Correlation-Id: dbd29457-bc14-4ae0-df19-08daab73f03d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aNmcax+zY7JUYAqLG0UA1sLoGpjlRcPmNjzx8kdhlEBDUwHViLjNFRAFaBoJ+UnpbrwyjwJNmFAmzJix3lDSFauJ3+w4Z9a/2O7xQHjS2zjsMxWWzzI76u2/N2F8mtMgKyH2GJb+thwYpiwnGDqHm6D7uoExi16UZEOyBE93cO/yAhivJmtPRv/ADwshQPX+wFbyWLIeD6hRltNoIt0MtHlFfk52QAbCtXyYcblPtFrWvHJ6X7mvJjAzfD73Mk882sV9I+6rITOVODZ/Z75hKaH74wsJIuUIJqlwzN4dsK1ERGIAwEgh+QiY/5UVCJwf4WugJnIlVsmFwba9YtdE2zwYvPuFPv1hvs1k1TuLddTo1URobjafpMc/c6PAnhUbrPhhFrpscmHYoqcKloBjY8itqtQkppAFYhnh/cHxkWssLkpoYqBPr4kxeU+3zDNzegjHwszyrMthslz4+ap/Oj1YBcFzRv1JZ2MC8eTftYezRsuIdlxFBJTsYsfJzLh9UMPu5xD/LBI6rVX3Yrj9ekyFglG6f4vtT2f3ipElnxqd5kGnJpOXfXIkPi+oa5un5UHt/Pbhl/Czjwpopf3gNCwu9Oczps1ge/MLBl4LqF/aQ89+eyIIvjLOI979ATCJ2mPZEnOUreXzIcIQF52HrC27c+wqWeAl0YnJLLS043pdO28aeRzOgRgjrxgiJ3Hoce85epWyx2jf4Eynfqh4qv2rMOpo519UEk4Qgibcc7bubt2CgwcaO5JbCgrvo1TLOE0M4uZuscJaACxfyxz4fuadkwogqa9/+O3ci8N6HT0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(39860400002)(346002)(366004)(136003)(451199015)(8936002)(478600001)(5660300002)(8676002)(4326008)(41300700001)(2616005)(6486002)(186003)(66556008)(83380400001)(66476007)(66946007)(53546011)(6512007)(38100700002)(86362001)(36756003)(31696002)(26005)(6506007)(6916009)(31686004)(54906003)(316002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K2ZwK1dyT2RRa0RyN29ZTk5Dd21zdXdmU2xyZllUb2RWSnJOb3MramZ4NTMv?=
 =?utf-8?B?NkVCM2hnZktpNTE0SHd0ZmZuT2hDY1hPaEFVUGp3R2JrL2dyeWN0VjZLdFRT?=
 =?utf-8?B?S1gyOFo3RDJEN0dvb3U5YVA2RENkY3ZvZ09JeTY3RFNYS3JGWXZJVVRZOGlO?=
 =?utf-8?B?ajNEZ0s0c0lRVjA2S3VXaUVxNGU1cjJQTE1GdXV1eVRJcjVoc1FTYU80Qi9v?=
 =?utf-8?B?MCs2TUtxdWpnY0dvclRvRWZkUVJVd3hYMllLVTdxK0tLVm1lOVdaUHh2aXM3?=
 =?utf-8?B?SXYxejhwczMraE9XSlpZTG9YeGN5QjRPUSt0a3BZRzF4cXVWL20yek8vU3RV?=
 =?utf-8?B?OThxYkRhTGZkY0ZFbXBkMU9GWGNYWGZCT3g4OWplRCtiT1hPcExqcmR0R1Jt?=
 =?utf-8?B?VHUraS9YRDZmK3RvZHBPc2hGZnRxZ29aN3JYdnlpeHUvUlRkYkFEU0hFMFBJ?=
 =?utf-8?B?aDl5MGlTdWUzWWkwLzE4NWM0NDF3WnBFSXhUWUgwYnN4SEtUWE9NM2VUYXpN?=
 =?utf-8?B?QkhIWmNIZTNmVFlueVhOOUJ1Y2IyazJhcmF3NjFMMjdyWDVQZEk2WncwbVlI?=
 =?utf-8?B?U1VwQUQ5cUhEd1EvaE0wOFI3ZGlrQ1hkd2RSRVNxQUc2b09NRGFhM2Q1OEc0?=
 =?utf-8?B?bFNJUUl2d0EzeTVPWWFCc1JUbjZqQ3FkWHVmM3NHWmVwUVhPUXZ1b09nNDdT?=
 =?utf-8?B?QkhjSEoybjBVZVdSUllTK1JpS3VZSWozTlFZTEVBcXlRb2l2bzlnYURLbkVP?=
 =?utf-8?B?MFUvL2t1UTRlNHFyWXJjRjZBT3FiMktiOXlaakNZQ3c3L04rWVA3M29mdjFs?=
 =?utf-8?B?R3ZoaFphK0N0c3M5Q0lRNGM4YmRyNXhjS3N0Si9FSFIwZklSRldrV1BEb21H?=
 =?utf-8?B?U3d0WlhjVGkxRG5oTS9pSGxJY3V4bnJQN0REY3lRY0dKSXJJWllyaGtnSmx5?=
 =?utf-8?B?OVFpdFY2QmlwRDdVSXMrbnY1cnlqbGgzLzNyOXU0S0lLM1hndzYwb2MxZVR0?=
 =?utf-8?B?RTN0ZTl5ejRVTytWeVA0MVNTVlJPSGF3WFVlSmhScmg5bEpKRTRKMSt4S1JE?=
 =?utf-8?B?M1RWNm5XVVpWQzhCeW5vVnFkbi9vdzNVYjUxK0x4bUhxTzBPVkxNK0psd3F5?=
 =?utf-8?B?bUJLMGpnUWhpcmIvMjFtS0xqM2RuT0w5SCt3dmFqVHhmelkwY3FYWVBjNVdM?=
 =?utf-8?B?dTRIeU55bEcvZFdiKzdQQitlcHNnMVMrVFNIamJ1bVp2WkJ0L2VLeUhyb3Ez?=
 =?utf-8?B?T05SWUs4d3JXTWRyY0g3eTVvY2VNcnZwRUsvaGM4dk1uaFdCSGhpamNESExi?=
 =?utf-8?B?UGRqSzNQY0Zva05vdGZLUGNLYkhNdlNWQW4xVjRmcSt4aW50QUhTa0Z6ei9P?=
 =?utf-8?B?ZlB3RVM5TklzMGwvaXV2T2h5bEs1WUgyODljcFlIWW51dm1oemtkbHlxM1ZZ?=
 =?utf-8?B?WnBZblMrUVI0N3VjYmw4WGNXTEZrRnpNeXE1a1p6bXlBMUVKTHRuQVF5VU11?=
 =?utf-8?B?RlVZK3NhOHVQVFV6MVhpT2FkSEJ6bHZja3ovTDdzbW10cnE0ZmdjL0k3Tlp2?=
 =?utf-8?B?ck54ak56VnhHckF1V2FWdmRnOTVzTFNzZGcxa1lZV05yaXBycHVoSzBYcFh0?=
 =?utf-8?B?eUFTWFFueHR5QW41NjJMMnJtUWZIby9Vdm5HWnZNbmJKTlRWYjY0R0pwWTFa?=
 =?utf-8?B?Y0xzeEZqbnIwVnY5OXdSdWdydVF1UWY4VXI3dHh2RlZZK0pjNjhUeStlZjRO?=
 =?utf-8?B?WC9lRzQxN0RsYjJlaFZsYWxEck1JakFGaFpXTloyUWxaUDVXbWduRXAwbHd4?=
 =?utf-8?B?clFpN0szTmlhTGZDcVIxVlc2bXNHWDNXWng2WG1hQUZ5OU9MNEZPMXBOVXFE?=
 =?utf-8?B?VWl6RGQ0UFZ1S3Jremx4U201ZkxlTWRPZ3MwSVRzR0dScWtuZUxPUXRXNTdU?=
 =?utf-8?B?NHdkaFVmSlh4MmNUSFlvaTZLc05CUGozMjdDZ3lIV1M2QkdZdHdDTHJUT21a?=
 =?utf-8?B?TktBUmZ6Z1JEZVgrVEJ4cnRXT1RRemlSMDF5U0ZCMVU5bVUreVphcDRBaTdu?=
 =?utf-8?B?K3JNSmJ0TlJNeFM5ejJUQk5Xb0NWcFV2MUR6T2w3OTk3R0o4dU5tcThzZnFa?=
 =?utf-8?Q?oEuHDczKMjBo7aSAzfQ+5kLrF?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbd29457-bc14-4ae0-df19-08daab73f03d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 10:32:46.8240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hkHqc+R420XqTSfoE95aEeCEWSeQGVtAyB1eJdfZQdyerUXwAVT9/wIQZvbk1S22LxJEZZLXkg+tf7gVvR77Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9186

On 10.10.2022 20:56, Andrew Cooper wrote:
> On 06/10/2022 14:11, Jan Beulich wrote:
>> In an entirely different context I came across Linux commit 428e3d08574b
>> ("KVM: x86: Fix zero iterations REP-string"), which points out that
>> we're still doing things wrong: For one, there's no zero-extension at
>> all on AMD. And then while RCX is zero-extended from 32 bits uniformly
>> for all string instructions on newer hardware, RSI/RDI are only for MOVS
>> and STOS on the systems I have access to. (On an old family 0xf system
>> I've further found that for REP LODS even RCX is not zero-extended.)
>>
>> Fixes: 79e996a89f69 ("x86emul: correct 64-bit mode repeated string insn handling with zero count")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Partly RFC for none of this being documented anywhere (and it partly
>> being model specific); inquiry pending.
> 
> None of this surprises me.  The rep instructions have always been
> microcoded, and 0 reps is a special case which has been largely ignored
> until recently.
> 
> I wouldn't be surprised if the behaviour changes with
> MISC_ENABLE.FAST_STRINGS (given the KVM commit message) and I also
> wouldn't be surprised if it's different between Core and Atom too (given
> the Fam 0xf observation).
> 
> It's almost worth executing a zero-length rep stub, except that may
> potentially go very wrong in certain ecx/rcx cases.
> 
> I'm not sure how important these cases are to cover.  Given that they do
> differ between vendors and generation, and that their use in compiled
> code is not going to consider the registers live after use, is the
> complexity really worth it?

By "complexity", what do you mean? The patch doesn't add new complexity,
it only converts "true" to "false" in several places, plus it updates a
comment. I don't think we can legitimately simplify things (by removing
logic), so the only thing I can think of is your thought towards
executing a zero-length REP stub (which you say may be problematic in
certain cases). Patch 2 makes clear why this wouldn't be a good idea
for INS and OUTS. It also cannot possibly be got right when emulating
16-bit code (without switching to a 16-bit code segment), and it's
uncertain whether a 32-bit address size override would actually yield
the same behavior as a native address size operation in 32-bit code.
Of course, if limiting this (the way we currently do) to just 32-bit
addressing in 64-bit mode, then this ought to be representative (with
the INS/OUTS caveat remaining), but - as you say - adding complexity
for likely little gain.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 10:44:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 10:44:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419547.664326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCka-0007Uz-Aq; Tue, 11 Oct 2022 10:44:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419547.664326; Tue, 11 Oct 2022 10:44:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCka-0007Us-7b; Tue, 11 Oct 2022 10:44:40 +0000
Received: by outflank-mailman (input) for mailman id 419547;
 Tue, 11 Oct 2022 10:44:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JHvS=2M=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiCkY-0007Uk-Qu
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 10:44:38 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c65bd20-4951-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 12:42:38 +0200 (CEST)
Received: from AS9PR04CA0084.eurprd04.prod.outlook.com (2603:10a6:20b:48b::26)
 by PR3PR08MB5674.eurprd08.prod.outlook.com (2603:10a6:102:81::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 10:44:34 +0000
Received: from AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:48b:cafe::25) by AS9PR04CA0084.outlook.office365.com
 (2603:10a6:20b:48b::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Tue, 11 Oct 2022 10:44:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT060.mail.protection.outlook.com (100.127.140.216) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 10:44:33 +0000
Received: ("Tessian outbound 99ee3885c6d5:v128");
 Tue, 11 Oct 2022 10:44:33 +0000
Received: from b9b726336b13.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B7D8AFC0-3E55-4244-9291-FC831D9C254E.1; 
 Tue, 11 Oct 2022 10:44:27 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9b726336b13.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 10:44:27 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV1PR08MB8010.eurprd08.prod.outlook.com (2603:10a6:150:9a::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 11 Oct
 2022 10:44:24 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 10:44:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c65bd20-4951-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=mppKK4Xo0596eqIlNVIEWDWHakZd3IK3wDPxjKLvOdXzbzM78SwpIlkJvYxFvPsn82t1DQL25jmQE5+xgnVQbsyTsPY9WaJR++KnquMnRGxGEAyTPgyd03FnrWBb/l/FQyyYhfdXXBMyYSj39hMNuN88y9Y8lzGk9zbDUYCbTzum5JJtcd7yHteskMWgzodagUiXrs9Vs9+0tjgVcBs5o0Tn+/2OA6BHJrgJrEqsdPQoT/HT2GuCVefACModeAu8+IjhJR2J49REx+eyJHJv+ym2mAdl+9XQAt2izxLSXAoFNfM3553NOi6owgYwZoyJcKChP6/JsN7/gn9GRy8kNg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gDDhC9dVVuqXaO8kimaQS5XB0AfnLhjX+Pw6ixg6hgw=;
 b=KR9xEls2ldEH7T9vklDE8E6ditbdoEuRnXU19bDnGakYaXiOoiBTTqUAO8P6XKWzxuVw6OuPwY8dq5905LA84Fcw0M5I3Se7y29YSr5MJilVopb+BfrjOZXAUkCAd/8q3lrZpNmdL/uQlpccNRGsI4ZvJOKFS0RtaxM27BLm6JsLtcjJpqzHbEXqPbawFyKS/vYjjkzjrMcSmUKKzL/pQa3eomPVYXlWhp/1PmkijzyQ+otWbm08ehzWO9PZ2mtONYJw6N1W2TIn0NHAJxFE8hluNeYtbf+hvlI1zZB0mlinndhCim3BtyDx2BYP9y0ujpQcMkXvqlgdRRfXDx/JfA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gDDhC9dVVuqXaO8kimaQS5XB0AfnLhjX+Pw6ixg6hgw=;
 b=Vw3ScPku5ZHbbiQmqK/7CR60wGryawmIGVR/dgGeb68Jph1vUBhVgxfPHFO4uGsU6QzVQTKnMNZALUODrIqyTvVgdi73einPqzbkWtjbNkqTjynLPpIQMqE+Jj2jNvupHwnF0QRE4p6tbcLSvD/dGBQX/YV1ktZF2jQva0BjTic=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V2pQBBtMxeRyR8+7ThO6dbUxg5KMfsSjLm0FR4VdHAS3C1KRbGw9w67lZ3WUljhFNITW8Mz1jimkkB0Wv1VEktD5QxYuSu2cmOPTqYi/wdzY5laoQlFjxPKbAv38Y6Nt0Iif62TCHSZNKzzGOqMFkdBNUsDT8Rc0I4IfkYimgnuMHH0fuNBNLh7mu75X9xaEY1RTQOyKWHtAFjulEmE+XpK4uA72ECLfzwJ/I6rU44h0SRcOhwYtkTds7waU23jHqNWYueJZ6jPgopJMsistHJFuGgZrGDAML0TInMJ82UyBlBh9HbNHbwu7fAfAaYcEDrE5Nu3biaXOvewQRwaN0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gDDhC9dVVuqXaO8kimaQS5XB0AfnLhjX+Pw6ixg6hgw=;
 b=kWRED51UOO53TEHDviG4PtiRC6f8GeZaUwYWuuDTsfOMscofwRQtuiM4Xy3LGngTh61PAxShSFoBiNubbPYQt7DEkYjhc765iKSLBQU/HIrHBojNr18Pk5Vu/OWhquhr9GlR1LPTbEpQTM99QrB5gZvBc6Ouaf0khTZKsebHfn6W/uD3GhGLGBboazLjMVbvbEa4857do6m80SH82pkJ2PjqWJ13nB0KgYmveqG6INQQeHpo5c89o3WtOLyROmuLg1R2a46vmd9K/adkh86modHmr8T9voAiLRSea7g14m/fn72piAd3aV/WE+5KzEPYUErR/lDwbDPDfhYIpmvE4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gDDhC9dVVuqXaO8kimaQS5XB0AfnLhjX+Pw6ixg6hgw=;
 b=Vw3ScPku5ZHbbiQmqK/7CR60wGryawmIGVR/dgGeb68Jph1vUBhVgxfPHFO4uGsU6QzVQTKnMNZALUODrIqyTvVgdi73einPqzbkWtjbNkqTjynLPpIQMqE+Jj2jNvupHwnF0QRE4p6tbcLSvD/dGBQX/YV1ktZF2jQva0BjTic=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>
Subject: RE: [4.17?] Re: [PATCH] x86emul: respect NSCB
Thread-Topic: [4.17?] Re: [PATCH] x86emul: respect NSCB
Thread-Index: AQHYyNQExUU6HB2zzUWbaDsrkt18Oq4H/XmAgAEhrYCAAAmScA==
Date: Tue, 11 Oct 2022 10:44:23 +0000
Message-ID:
 <AS8PR08MB79917F69AA9899C2A86C3C1092239@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <b0103a30-22b7-c010-3e8b-6eab1c25ee47@suse.com>
 <f5851974-86ab-8da7-3b5f-4196faae7969@citrix.com>
 <1fc32039-5a3e-5f74-d6ab-059ab8037338@suse.com>
In-Reply-To: <1fc32039-5a3e-5f74-d6ab-059ab8037338@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 36D912E2A1E73248A0560A90A5C9F2D5.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV1PR08MB8010:EE_|AM7EUR03FT060:EE_|PR3PR08MB5674:EE_
X-MS-Office365-Filtering-Correlation-Id: 7b56eef3-be40-48ee-1ce6-08daab7595d6
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 UJeN7Qk+k5pg7ZI8qJiz9NyqxuUvBbWUHLhrrK8zLFedQvt6L9/FSUnxyJkWNY5BAbpxm6EiI4C6f+yW44Gtkzb++iZBE0NkxbG9A1Ya6aJslQH2K2+YRrV+uBzLCBJHzFbamMB8VL3bijQUtdHeYBN/gGQeIpd+anaCyxN91tR3n2ar/nHfVXcgndRQAMCYrnI+KAfOOKjVqXWrF/rYqwaeM1OiNuNU0ePkaZaYaz7/nOgA6uPTpMta30USf/OW1LzOCLjDFrkg32pfTmTt6TsIcecp3mqUcKZsmuDjX8i1MXQo984/UvegwfpHhCq3z+sikFuv/blMXE+zopr0NzCrQm0dGqNPO9jhzQeY5VD04XOqKcwgQiuarCL3nfr/jpRZcv5oRPFiCf1njY+baMTuJ6zWNHfrCap2HlZppOpYTvI6qIzKYa/HQT2a3AbPTySonz/wzvn5Hyusxvgg4MSgRT8Fe69W5g/D1Qtqg/DZLjzYMkgO91uYz00YQQM7cUDko2n5KCXAcj80NGVMSOP84WZwDg8u3/SA/TsoPHi0HDgt6GRS6nqbLv5FRo2M0KhFNI4H0X5pKYvzNCNtpIkLIFdSP21iPuCjGDNTC+s05chOxJ4hSiRWKGc7XO4CApYxrI2S7P779eTTqYSyfni3yd+T07ovgL3TFRxWwOioUdNqI77d/rac4tJ47+HxF4Aq7fk/4KhNdoG06F3eFTiVv8Q+f/4LOvfVIDip+fG2ODlBrzGgQrjVutek24TGBT20n00ybA8rU36BLCoa6g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199015)(7696005)(5660300002)(53546011)(38100700002)(52536014)(8936002)(122000001)(6506007)(86362001)(41300700001)(66946007)(83380400001)(186003)(4326008)(478600001)(55016003)(9686003)(71200400001)(33656002)(8676002)(26005)(66446008)(38070700005)(316002)(76116006)(66556008)(54906003)(2906002)(64756008)(66476007)(6916009);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8010
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e765c545-b60f-4225-95ef-08daab758fdc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6LkUX46aqlHu53WULwkCrIY3EppI9e5hXypI/y8X/2qGhpY3tejEe0NkiEf2gvcURSkR6J/LRwq7lIZ9cluQaoVQYnF4w8sXTcD7jE2UzZ7jRg/j5dBEQsozvn+GYCpxcxlNWm9fuZFAlfCs4QnQ15IVqO0afrOb/Vi/n2GoNM4BJTV6cQcN/wWl/SCwDAUEcFh/z/MmRYl8mXTMInMZmjcUTe/onJ6XGTeLpvoP2dk0r6OBHS1x+Hdh0vUujyOCZVQVfuVmhIbcTBaMvfdULA+ooovbi55DofQLhQiWifD4i1mjmArG4YcUjNjXfLJnQQIeCtmfgt3aIU3l8bE7y8ngggCdBwpaSjiI4jJi0aIxjvPG0Wt4LcoRpgXSgoexG2ddSNimU/C/U2mDXe0zq/u0uwN7lFWXTpQaj6VsrfeXtdUMPfVWdBHoiCY7ob8jjRmJPGvfKFABM5C1G1BOMw9HCKKbcDLo5r336wdyt5tj5eJIXd53OrgqhSHCq+Rla27wh4ScGd3sVI/y3mckr3btrD6dgcZ24I5Kkab6SY6fukYFlvjG76j6BDwpvekQrQKZTt/5cu/ae0+AT0GnTphH3WO9u0xGlC7hJAJiV6Pyj1OUHVzhiZnlFGp8BV0969vjI1DMO+6UJuzWYjDuAzDO5Pv19tNSxh0saFpqnnCSKzrtPpyNE7rtHhAJF8KVt2BfxF1f1k7n3fPtSKXdIAc7gYy1HmNmCExA+aLPxV+REMXj5/PSbNDIc6cktBv0rcZ4tVr5OWnvYbxBlRDWFg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(33656002)(81166007)(36860700001)(82740400003)(40460700003)(86362001)(40480700001)(356005)(55016003)(316002)(54906003)(478600001)(52536014)(5660300002)(6862004)(70586007)(8676002)(8936002)(41300700001)(70206006)(2906002)(82310400005)(83380400001)(47076005)(336012)(4326008)(6506007)(53546011)(107886003)(26005)(7696005)(186003)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 10:44:33.9082
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b56eef3-be40-48ee-1ce6-08daab7595d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5674

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogWzQuMTc/XSBSZTogW1BBVENIXSB4
ODZlbXVsOiByZXNwZWN0IE5TQ0INCj4gDQo+IE9uIDEwLjEwLjIwMjIgMTg6NDQsIEFuZHJldyBD
b29wZXIgd3JvdGU6DQo+ID4gT24gMTUvMDkvMjAyMiAwODoyMiwgSmFuIEJldWxpY2ggd3JvdGU6
DQo+ID4+IHByb3Rtb2RlX2xvYWRfc2VnKCkgd291bGQgYmV0dGVyIGFkaGVyZSB0byB0aGF0ICJm
ZWF0dXJlIiBvZiBjbGVhcmluZw0KPiA+PiBiYXNlIChhbmQgbGltaXQpIGR1cmluZyBOVUxMIHNl
bGVjdG9yIGxvYWRzLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+DQo+ID4NCj4gPiBSZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5k
cmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gDQo+IFRoYW5rcy4NCj4gDQo+IEhlbnJ5IC0gdGhp
cyB3YXMgc3VibWl0dGVkIGJlZm9yZSB0aGUgY29kZSBmcmVlemUsIHNvIHlvdSB3ZXJlbid0IENj
LWVkLg0KPiBNYXkgSSBhc2sgdG8gY29uc2lkZXIgZ2l2aW5nIHRoaXMgYSByZWxlYXNlIGFjaz8N
Cg0KU2luY2UgdGhpcyBwYXRjaCBpcyBzaW1wbGUgYW5kIHRvIG15IGJlc3Qga25vd2xlZGdlIHRo
aXMgcGF0Y2ggaXMgdHJ5aW5nIHRvDQppbXByb3ZlIHRoZSBjb2RlIHNvOg0KDQpSZWxlYXNlLWFj
a2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCihJZiBpdCB3aWxsIG5v
dCBjYXVzZSB0b28gbXVjaCB0aW1lIG9mIGRpZ2dpbmcsIHdvdWxkIHlvdSBtaW5kIGFkZGluZyBh
DQoiRml4ZXM6IiB0YWcgcG9pbnRpbmcgdG8gdGhlIG9yaWdpbmFsIGNvbW1pdCB0aGF0IG1pc3Np
bmcgdGhpcw0KYCB2Y3B1X2hhc19uc2NiKClgIGNoZWNrIHdoZW4geW91IGRvIHRoZSBjb21taXR0
aW5nPyBJIHRoaW5rIHRoaXMgd291bGQNCmhlbHAgdG8gaWRlbnRpZnkgdGhpcyBwYXRjaCBhcyBh
IGJ1Z2ZpeCBzbyBpdCBpcyBtb3JlIHJlYXNvbmFibGUgdG8gY29tbWl0DQp0aGlzIHBhdGNoIGlu
IGN1cnJlbnQgcGhhc2UuIEJ1dCBpZiB0b28gbXVjaCB0cm91YmxlIG9yIHlvdSB0aGluayB0aGlz
IGlzDQpub3QgcmVhbGx5IGEgZml4IHRoZW4ganVzdCBpZ25vcmUgbXkgY29tbWVudC4uLikNCg0K
S2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gVGhhbmtzLCBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 10:52:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 10:52:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419559.664337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCsF-0000ga-4E; Tue, 11 Oct 2022 10:52:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419559.664337; Tue, 11 Oct 2022 10:52:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiCsF-0000gT-16; Tue, 11 Oct 2022 10:52:35 +0000
Received: by outflank-mailman (input) for mailman id 419559;
 Tue, 11 Oct 2022 10:52:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JHvS=2M=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiCsE-0000gN-2z
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 10:52:34 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce6d8d6f-4952-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 12:52:32 +0200 (CEST)
Received: from DB7PR03CA0099.eurprd03.prod.outlook.com (2603:10a6:10:72::40)
 by PA4PR08MB5997.eurprd08.prod.outlook.com (2603:10a6:102:f0::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct
 2022 10:52:29 +0000
Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:72:cafe::ba) by DB7PR03CA0099.outlook.office365.com
 (2603:10a6:10:72::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Tue, 11 Oct 2022 10:52:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 10:52:29 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Tue, 11 Oct 2022 10:52:29 +0000
Received: from da331d3eb171.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8C31D6CF-A310-458E-98FF-8C2913AA1E76.1; 
 Tue, 11 Oct 2022 10:52:22 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da331d3eb171.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 10:52:22 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM0PR08MB5378.eurprd08.prod.outlook.com (2603:10a6:208:18a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 10:52:21 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 10:52:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce6d8d6f-4952-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=f3AUoKePr8HP4nTThWehX+lyRYgctNu7TzSfJP/Rlj7ncRlDuGX2wrXV9p7C+a59ZurWjohgjaaCPHkLolMc8jZER5T2Zlqu1tgyuFK4ntMnq4kytagIS043c4VS5SsOAKCqSn7dRb//uQ4I3dDd+4sBz1bP8QIouKHfLSiu11aBre51GPCJOQk/j5hHokJx9axzDbBIT4818YTKkHhdKDSSomTakJuC1F5OxPOuByjJ+bciIXMqKv76OeDdGpwHLWA0/xLazlJBHoAq9JPXi1U/4gOgrgxqvH1/ZNIcqspSBqWVUNFHh0gZlPLibBBMEjDZqOzqTvWpIBElo6tY6g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O/cdhmkn5SLFEzarDHl5c+nSjvJbxMYydiKVlDOEM4M=;
 b=b+xsW5evJmxlzkuQmrlWWjDHs3zu5Hd7kVE9UKEYaEJp4J4n6NNFqTm9Bdtvc5PWcEbcsa8dzJtBNPK+YpHBlIY+bYf3t3VYqdvR1CduV8tkqS9sJypes9LL1HmGFuc/CqDvIuijppXFdDJWesOjq4EceOWPLakjUCgB7NPoARh30wm+DREqD+btOxxrT1vdbQeduWJC/TxD3Gh1N6Cj5MaXxkdpwjjvJ38IxPPf72bGxeL6Wg6qwH8+a+uOa//xbnPmEiwgjwK4ozo3egHZHAZES3iuM4wpmIqkDZYtXfNYD/HWEJekRHAW1WGPZJVmDQ/lyGPpZHe1l271/hjuuQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=O/cdhmkn5SLFEzarDHl5c+nSjvJbxMYydiKVlDOEM4M=;
 b=z28xEegyxNgUV+boROJWRG3oGiN5JfHxPCon4QIBDr4/RBlt1yNUYbal3P2Feoxcjn2MOmVw5U7UZNuIJI40jAkI+21HpwiZqxx+27IApv9ZjKvxqr+mSezh+P5ZF1Vk+jfLGd9NugB1dCJFNsVklaDm4JDCupjEcmd5xzSMwoA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dHXqLbEsHiTA0F//2vY4b6XrkQBQEj893UXCuuzg+MuWf6LRAp9akVy11aSOFqc2On7J+V7qsmmaRKG3T2RoAPoEzwxU7MNCwLdhQXL+GuaRLNbenHatIWIiBUL5rkIUOzpZc72T25ZJkJBC8wyeOwdafTgneGMf0moMaPV2MZLA56zHyys2GpAyodFu1P3LKM+JE9e3b9+hfugCANRKzQioITo1YJh9Apct2ctMrikByesaNXwzitVFHQtYNI3xTdEzYaHzotuh82BTranHMX4nDPm8+HjNiJWL03S8yyilwjz3ng16x0m4LP9lwiM3Eg0ggaBYOnLaKPVwaLlHaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O/cdhmkn5SLFEzarDHl5c+nSjvJbxMYydiKVlDOEM4M=;
 b=acGtO5TzWHcMGr09kehMKlWUBfTgmOv05xOsIRv7bwasDM72CfG0gxbzlHmxvl8ezWDNwEXm4BXC/8yfr/6BBj/rXEPvU4WOz9efDJWVVAK9bK3EpX6BJaRhC5iseCxKD6VdxtelF6KETIaxBu/V0fm7Nw+dujdM9fDHVBLvt2S10HOJ2kfl5tHQFjTyc1po2k2WXbKNojK47SLS7tJ2bX7RBDZHTbHK33GVs1gp9yd15IqUIiQJzXDgYQBxnUJtwQiE9VwSSd2EXnNcZEJRzfea1Bp48k45S3PMJv6Czh4Ihj2r5ZMIQ3mSEseSuC68wVEEsL1JsE5FeAN4nIRq6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=O/cdhmkn5SLFEzarDHl5c+nSjvJbxMYydiKVlDOEM4M=;
 b=z28xEegyxNgUV+boROJWRG3oGiN5JfHxPCon4QIBDr4/RBlt1yNUYbal3P2Feoxcjn2MOmVw5U7UZNuIJI40jAkI+21HpwiZqxx+27IApv9ZjKvxqr+mSezh+P5ZF1Vk+jfLGd9NugB1dCJFNsVklaDm4JDCupjEcmd5xzSMwoA=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>
Subject: RE: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
 INS/OUTS
Thread-Topic: [PATCH 2/2][4.17] x86emul: pull permission check ahead for REP
 INS/OUTS
Thread-Index: AQHY2YU/ul6th/D86kebfP+n1ma7Bq4H83eAgAEPrYCAAAbpgA==
Date: Tue, 11 Oct 2022 10:52:21 +0000
Message-ID:
 <AS8PR08MB7991A463587075CA084E9E1792239@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
 <4d01771c-fd02-b607-c480-04bcb11fa7b3@suse.com>
 <2dc898c0-b42a-28d7-7126-9379f03119f3@citrix.com>
 <0fe3af83-a743-5edd-1c83-921f5e666039@suse.com>
In-Reply-To: <0fe3af83-a743-5edd-1c83-921f5e666039@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: BEEBC16C2362A1418D2C88D9CEBDA092.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM0PR08MB5378:EE_|DBAEUR03FT009:EE_|PA4PR08MB5997:EE_
X-MS-Office365-Filtering-Correlation-Id: ad7c0c4f-e938-41e9-8645-08daab76b117
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 OYmSxqIsuJjCVlrczKi91aT19FUFQvWO7ia1i6Fyg3yh/tPzaJRduHw3cHR/WiO/YKB0Nt2dGNOqCRKLFEiN7JNOCwEmHzWCz+O8K1Fjev6d3iTAg+yOevyMInO4JvAKmpvgqcKEu30gkeHD3gZbvzpKHdWtyAqgytJAjwj+B9qSjnLXSo/LNGBCdC5pOhqT54qnT51HaUqMebKYSOAN6LmxIzc0lvVpnrYBikLgpbNkQDr/D6CvgeUIVghnWRSE6uhXwT9Kj4XFMDnsSu1CMMznqs/1XGKa7Y2VRxT9P0w9MJyt6M9pouX5Kr2FvvG2jNQhWR2Wf74UTIqd0F36OknUXDM+LtZZnZiFnokysJEH6TgxwEqJ6X/FDHSo/3CYUkDRbuYVPULFqCENWmDv2rgISbzXwq9ePpPGeviTLl3+gA6XowPbfNt6Di7FBs+Mv+mtxS8ZQzK6/YlJi5agZfTz3a0QOYJ9z2L8tqWjwKp8uQM1EJwjhjMYS6I3VC0stG9h5HZjiH6FrmM+lhn75IGQXT9zIGiQKn/jM7/0kJL81MmNVerr8waksPAWeHnW5jJcgMdgaZN8NvUiJ1JHQMvTb65rYbMCpcZoKtazeDh67XnK2yuPo4+VqoY7xSjEwV2+JW7lREM/nMXDsVJSpU0/ULptGb/W5i6+p6i+IyfGt1FGVkh5kEdT81R9bI5VAtCsW2/qUa1uqSELP8NDouTiC2P9sOEz1uMTY0v100suYc2wrvWJ3Zj9l1dmFzWCbYEMHoR1WSYjyknNH75bWQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199015)(7696005)(86362001)(38070700005)(33656002)(122000001)(38100700002)(52536014)(316002)(6916009)(478600001)(54906003)(64756008)(8936002)(5660300002)(76116006)(71200400001)(66476007)(66946007)(66556008)(4326008)(2906002)(41300700001)(66446008)(8676002)(83380400001)(53546011)(55016003)(6506007)(9686003)(26005)(186003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5378
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c57cdf70-43dd-49db-9df8-08daab76ac40
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t9oc9RdV8liC8TxeIcyt/I61tTE+p9vCK+ijdQtBHBn5BC4ZRjIEz/e1uIuIxb89UsgrLGKxrd8ZtxqXE7LPjqrI+FHikQXVsYQcNM522MTRjtwYJNX4HHBOY3Z6qzfVSGSbn7/YM+lT1Ksg2Opc8TPJSTVklqbCxnMCdg8whw7YpDEccHBOJIDxsimMP86nCR7jBjiDUoo69rXVh5cAqFR8CgNAr3SpETO5WAdidCfAzcuzuWNAKEWVrm2YwBedXQ4A7rVQ8hwkaTgDbStICEynB/f8aan3JxW2VfzQUYhrGvrWSODH6sLnbbL0gSPmvAEhj5vRE4IIqERWJ6IyyfDC6Wi1EnSI5Hqi9N7SkTDwVaOmMVXki3tXXmsopJUxB9+txCDTisr8CecOVelLTDl78c3jH8uvSeFqFLlFymqC7m97dqDzhBbOInwCQocCN2bYrqO3F3QbTFRaxDgedmYRPC8e5JTR+fSGwNFvR0mejJbu+mv2F1r3NyCGiyy4ODfzLFLaKRNjcK62bD6y1qKW+J1SprF0BwxflEzohQM5Emc+TB4aMTdnlt+lhA20aa8nta09y+kx8RYxl8qcSRx7FqruGZBQFodIolfjPqKdBWVP3hLKxV+wI7b469sZx2nWA6BDoRI2SXTGIBTvC+JuM+5HEtHOfVBDcWYsSsRbhrdQDYJkpTBg3N6u3sGgKebZpde2H/i6oseJpVbRMRjruTyQWFTfCl2S0mo7N2+WzzbE+5r2bTzrC4xFtd/d7p4qxFyC28qvjJIa/vRfWg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(5660300002)(52536014)(8936002)(6862004)(70586007)(70206006)(4326008)(316002)(54906003)(7696005)(53546011)(356005)(81166007)(6506007)(33656002)(82740400003)(336012)(26005)(186003)(9686003)(478600001)(107886003)(86362001)(8676002)(36860700001)(2906002)(41300700001)(83380400001)(40480700001)(55016003)(40460700003)(47076005)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 10:52:29.1789
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ad7c0c4f-e938-41e9-8645-08daab76b117
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5997

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAyLzJdWzQuMTdd
IHg4NmVtdWw6IHB1bGwgcGVybWlzc2lvbiBjaGVjayBhaGVhZCBmb3IgUkVQDQo+IElOUy9PVVRT
DQo+IA0KPiBPbiAxMC4xMC4yMDIyIDIwOjA4LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPiA+IE9u
IDA2LzEwLzIwMjIgMTQ6MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+PiBCYXNlZCBvbiBvYnNl
cnZhdGlvbnMgb24gYSBmYWlyIHJhbmdlIG9mIGhhcmR3YXJlIGZyb20gYm90aCBwcmltYXJ5DQo+
ID4+IHZlbmRvcnMgZXZlbiB6ZXJvLWl0ZXJhdGlvbi1jb3VudCBpbnN0YW5jZXMgb2YgdGhlc2Ug
aW5zbnMgcGVyZm9ybSB0aGUNCj4gPj4gcG9ydCByZWxhdGVkIHBlcm1pc3Npb24gY2hlY2tpbmcg
Zmlyc3QuDQo+ID4+DQo+ID4+IEZpeGVzOiBmZTMwMDYwMDQ2NGMgKCJ4ODY6IEZpeCBlbXVsYXRp
b24gb2YgUkVQIHByZWZpeCIpDQo+ID4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4NCj4gPiBSZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNv
b3BlcjNAY2l0cml4LmNvbT4sIHByZWZlcmFibHkNCj4gd2l0aA0KPiA+IHNvbWUgb2YgXiBkaXNj
dXNzZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KPiANCj4gVGhhbmtzLCBJJ2xsIGFwcGx5IHRo
aXMgcHJvdmlzaW9uYWxseSBhcyBJJ2xsIG5lZWQgdG8gd2FpdCBmb3IgYW4gYWNrDQo+IGZyb20g
SGVucnkgYW55d2F5Lg0KDQpTb3JyeSBJIHdhcyBhY3R1YWxseSB3YWl0aW5nIGZvciB0aGUgcmV2
aWV3L2FjayBpbiB0aGUgUGF0Y2gjMSBvZiB0aGlzIHNlcmllcw0Kc28gdGhhdCBJIGNhbiBhY2sg
dGhlbSB0b2dldGhlciBhZnRlciB0aGV5IGFyZSBwcm9wZXJseSByZXZpZXdlZC4uLg0KDQo+IElu
IHRoZSBtZWFudGltZSB5b3UgbWlnaHQgY2xhcmlmeSB3aGV0aGVyIG15DQo+IHJlc3BvbnNlcyBh
Ym92ZSAod2hpY2ggbWVhbiBubyBmdXJ0aGVyIGRpc2N1c3Npb24gaW4gdGhlIGRlc2NyaXB0aW9u
DQo+IGZvciB0aGVyZSBiZWluZyBub3RoaW5nIHRvIHJlZmVyIHRvKSBkb24ndCBmaW5kIHlvdXIg
YWdyZWVtZW50Lg0KDQouLi5TaW5jZSBJSVVDIHRoaXMgcGF0Y2ggaXMgYWxzbyB0cnlpbmcgdG8g
aGFyZGVuIHRoZSBjb2RlLCBzbyBhcyBsb25nIGFzIHlvdQ0KYW5kIEFuZHJldyByZWFjaCB0aGUg
YWdyZWVtZW50IG9mIHRoaXMgcGF0Y2gsIHlvdSBjYW4gaGF2ZSBteToNCg0KUmVsZWFzZS1hY2tl
ZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpI
ZW5yeQ0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:04:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:04:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419566.664348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiD3C-0002OY-7W; Tue, 11 Oct 2022 11:03:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419566.664348; Tue, 11 Oct 2022 11:03:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiD3C-0002OR-4g; Tue, 11 Oct 2022 11:03:54 +0000
Received: by outflank-mailman (input) for mailman id 419566;
 Tue, 11 Oct 2022 11:03:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiD3A-0002OL-3b
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:03:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiD38-0007rg-Hv; Tue, 11 Oct 2022 11:03:50 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.14.212]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiD38-0007BV-9d; Tue, 11 Oct 2022 11:03:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=lYHF+FKUShw8v4NfUQVz5YAlt60TC3cv2R0+1usQIkc=; b=gPCMifqGVf7QlnCukG/4EMcSeL
	ZLF5PBjWbvkiZKU6TvQcx1VAuGbaukXdPeFkiZzMeaSY0v2L0QKyU4wk/5hEpjFGGS4mBIijxV2+X
	U/HaTYiRay/Du3qr6aFQw/+j2F6fh2Y+y1kp7QNqdUO/REnbil+rPH6ErE4R0KOfBWHw=;
Message-ID: <f8e9513f-d21f-6986-ba96-8385be4dcaf2@xen.org>
Date: Tue, 11 Oct 2022 12:03:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH v3 4/4] Remove extra copies of licenses and license
 headers
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, wl@xen.org, jbeulich@suse.com,
 george.dunlap@citrix.com, andrew.cooper3@citrix.com,
 bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210071710070.3690179@ubuntu-linux-20-04-desktop>
 <20221008001544.78302-4-sstabellini@kernel.org>
 <b87e4263-4018-b840-74be-965aec89d187@xen.org>
 <alpine.DEB.2.22.394.2210101716390.3690179@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2210101716390.3690179@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 11/10/2022 01:26, Stefano Stabellini wrote:
> On Sun, 9 Oct 2022, Julien Grall wrote:
>>>    When creating new components, new files, or importing code please follow
>>>    the conventions outlined below. As a general rule, whenever code using a
>>>    license other than GPLv2 is introduced, attention must be drawn to the
>>> @@ -32,20 +28,22 @@ deviation. Any new code must be GPLv2 compatible.
>>>    New components
>>>    --------------
>>>    -When creating new components and directories that contain a
>>> -significant amount of files that are licensed under licenses other
>>> -than GPLv2 or the license specified in the COPYING file, please
>>> -create a new COPYING file in that directory containing a copy of the
>>> -license text and a rationale for using a different license. This helps
>>> -ensure that the license of this new component/directory is maintained
>>> -consistently with the original intention.
>>> +When creating new components and directories that contain a significant
>>> +amount of files that are licensed under licenses other than GPLv2,
>>> +please create a new COPYING file in that directory with the rationale
>>> +for using a different license. This helps ensure that the license of
>>> +this new component/directory is maintained consistently with the
>>> +original intention.
>>
>> I don't understand why the wording "or the license specified in the COPYING
>> file" is dropped. To me, the sentence was indicating that it is not necessary
>> to create a COPYING file in every sub-directory if the license is not GPLv2
>> and it matches the license of a parent directory.
>>
>> Do you plan to remove COPYING completely?
> 
> No, I don't plan to remove COPYING completely. COPYING is useful to tell
> the user what license to choose. I only meant to clarify that COPYING
> doesn't need to have a full copy of the license again. An SPDX tag would
> be enough. I can change it to:
> 
> ---
> When creating new components and directories that contain a
> significant amount of files that are licensed under licenses other
> than GPLv2 or the license specified in the COPYING file, please
> create a new COPYING file in that directory containing the SPDX tag
> and a rationale for using a different license. This helps ensure that
> the license of this new component/directory is maintained consistently
> with the original intention.
> ---

Sounds good to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:13:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:13:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419572.664358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDCd-00040w-3z; Tue, 11 Oct 2022 11:13:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419572.664358; Tue, 11 Oct 2022 11:13:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDCd-00040p-19; Tue, 11 Oct 2022 11:13:39 +0000
Received: by outflank-mailman (input) for mailman id 419572;
 Tue, 11 Oct 2022 11:13:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3DRi=2M=citrix.com=prvs=276b56479=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oiDCb-00040j-W1
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:13:38 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id beefeaa2-4955-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 13:13:35 +0200 (CEST)
Received: from mail-bn8nam04lp2049.outbound.protection.outlook.com (HELO
 NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 07:13:09 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DM6PR03MB5145.namprd03.prod.outlook.com (2603:10b6:5:1e9::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct
 2022 11:13:07 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.021; Tue, 11 Oct 2022
 11:13:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: beefeaa2-4955-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665486815;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=DxKKZvA+xwRFz4ieq7pKElvtN+v56YSUwmmWRv544k4=;
  b=XIiWI3zgNYu0PTnwE+Jsnw03NsnhoZDkl2VxZcPQASfDJIYb5yE2jROB
   RC7H6TBMWBr+tO1vsg/l3baCzz096tZOmQfJrghNcAndPD/IVdKrIj0Rf
   j1gdyWOHNpAkUPjsRlABGY8+mjhb17lpnsC15J6M0GP0hIzHbqQ2hh+f2
   A=;
X-IronPort-RemoteIP: 104.47.74.49
X-IronPort-MID: 82878647
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:KgMzEqCCegpyzhVW/xviw5YqxClBgxIJ4kV8jS/XYbTApDkq3jxVy
 jEYDGjXa62NajSmc91wa46/oE1SucDWydUxQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2r4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k0ZoM3qrhGGlhq7
 NAYDTUtZA+Bl8WplefTpulE3qzPLeHNFaZH5jRK62GcCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWIE7g7EzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr
 WPa5WXpRBodMbRzzBLVqCLz1rGTwksXXqoTTeOAqtNBmWap/UMsVDlOWgSC4r6m3xvWt9V3b
 hZ8FjAVhYg/8la6COb0WRKQqWSB+BUbXrJ4Eec39QWMwar8+BuCCy4PSTspQMMinN87Q3otz
 FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNpFv6zh9itRTXom
 WjW/W45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5
 SBsdxS2hAzWMaywqQ==
IronPort-HdrOrdr: A9a23:frPXRanXgxBUbuKKqnPkeetF4qbpDfOPimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee
 r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+
 uzUagmccPeEQ==
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82878647"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iUoyRt0xHHjnK0GngtGbQYd9B8zMHXHlzgypZJwIQqJqfTTIC53jmQ9ZcFuVvMnlex0+3pARgvZNAeeKeUfEi8UWU8sqMuyjVzThRiQWQtO5c3ZzK83V8JhQNogMFCEo0P6PQQTMopqGxeH39jKeO2C1A3YWv+fzw1PMfxiAx+e+eXK//RpSQ/uf+l2N4ReeLNNUzmgFT5yK2y4WRhtq+i8E2xItPyXhnK/P9KEufYKyIobAGyz0/uyVGLbjvHCX6ojvmZuQ42fyvO9jbnlfXJ/Vy8vVoDeHzZuhOCDtiwqhjph670WlkofWdQbflcHyMiFLUGiVidIMuujB66v8bQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DxKKZvA+xwRFz4ieq7pKElvtN+v56YSUwmmWRv544k4=;
 b=lfapv03Fxh53RQSIvnTZBgLC/pO4cLZaOoSuKVVrRsdth4w/e/JUF0QryLQ6m5PBmIvQiTH7mFF39J/zxz2jpsywt9hW/UNuG3RlUJBm44l1aiNPC+QUTWFctS5uyIvnT/cwunrt/Mj39iJL10icAJc5hh07dFygomyEJy1UMBGONsIF1V9kxhv6OC9ODOB5Xe59HV85Omq0LreVtR98Ct9y/ze1xcN7Zo99fbu+Q6PhxA3M67+Ha5tWoR7WPUzAZh1V3rrHBid6djtbudWS9aJHmH2NcdVStYcNMWhv4uRYbRFbqA26EW7+ImI7ZGBJah/YYM0C+fRWn+KJ2cOw8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DxKKZvA+xwRFz4ieq7pKElvtN+v56YSUwmmWRv544k4=;
 b=kyvLyjKhuNkhujOCAYef9uXwu5IepLayD603p39wbvq/GwCGIlFhrji6CrwFDzImme1gjbjajsrX4TuK/7eKbUk7IqJetzwDfNVws8rPQWfeMcf3T1ZFiVkVkmApg+QxXDT453z2yTzP+2KkDpQiLFJJxBHwp58BE+AjwpAmQb0=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>, Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [4.17?] Re: [PATCH] x86emul: respect NSCB
Thread-Topic: [4.17?] Re: [PATCH] x86emul: respect NSCB
Thread-Index: AQHYyNP7HPEYuhoQC0yvtYIRC5F8064H/XmAgAEhrYCAAAwLgIAACAWA
Date: Tue, 11 Oct 2022 11:13:06 +0000
Message-ID: <6be3288e-7d08-1e07-1283-c68a2acad88e@citrix.com>
References: <b0103a30-22b7-c010-3e8b-6eab1c25ee47@suse.com>
 <f5851974-86ab-8da7-3b5f-4196faae7969@citrix.com>
 <1fc32039-5a3e-5f74-d6ab-059ab8037338@suse.com>
 <AS8PR08MB79917F69AA9899C2A86C3C1092239@AS8PR08MB7991.eurprd08.prod.outlook.com>
In-Reply-To:
 <AS8PR08MB79917F69AA9899C2A86C3C1092239@AS8PR08MB7991.eurprd08.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DM6PR03MB5145:EE_
x-ms-office365-filtering-correlation-id: 4d5d50d7-5fb7-46c7-21a6-08daab799277
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Yf+bG0eXdrHjpfwVVAohOneIe+jXbWbQpw8bxAaBrgEW+pGGHqfhs66pKXE/Rzug/3XmY2WhhhGZGzu6DveWRR2SF0h0jMUIf92NOgtoYg9vJ/nwPebm5LKggW89SdSXOr5xamaQYUSc9k3RqyksVgg72C2P8oUjwvrr14CFYXsN+v7XbjqfuawaDPY0Mm7bLjdhQeAEY8Ea/iEwc7k0ryEY7G7XjJdX+zPOShlanOVqyBDxRAGOXvCSRwjn4xiUcTmsWk3xkuOeOzUMkKVJtH9/jXrxLjYLHm29wJhkSJxmeJP4Z/LQrL9jF7u+/oxaXQxd9SaQdjD+NrlcJQpCxyInElThgg+v3Pd9gsPtOrVfwP3xcb6tkJSkcP+BhCbmnAAVcktEXbSYz732m/JlxP8LRXipm2SKzKnVQhGBG/90ay8gxOOjgLdnCoF1xDA4kfb+PUdVgPDJB6YkLUbpjOCiFwLa3+xFB4AFbNclt/ye//JyFM/6wSfBA/IBsv4ZhACN77x6B700WKx3U5PSBBRPpK7SPuBeG/xwbgIttuT820ATotgfCFdxjf9epBzahxf2bz1RJnmJkUrm6Vl0+xHawqaa/FsfbrLLYqq8sJgy86YYdtsD/S5vLZ/aT2rKp9nunprAsAjbeRAdn90Hf9k3MtBCNbSzSxbsie0eJB73g0DR6uNxI21pQPmp/aCiVONjybYuqQUQSaRsms02WU9tqc6y1N9CpZc2VqVUCR2FUsZe9SqcUFPLBRarIqJfBPup6m/2/G4lh5dD1Et1seUd3uLtSt5bBC8mIiPr5Rn0HUiBwtbe9mVSJUXKWOedXA4PZiUU53oUphlDA2tQxg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(316002)(26005)(186003)(36756003)(5660300002)(8936002)(2906002)(6512007)(2616005)(8676002)(66446008)(66476007)(66556008)(66946007)(4326008)(76116006)(91956017)(64756008)(53546011)(6506007)(41300700001)(83380400001)(31686004)(71200400001)(38070700005)(122000001)(82960400001)(478600001)(110136005)(54906003)(86362001)(31696002)(38100700002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?aVNDZGdJdEI5QzQwSnNLZzlhQnFJUVdvZnE0dnJFblBieWEwbU1LaGl2NHZo?=
 =?utf-8?B?eVorUGtMZlNkLzNORmg5WDdLWkU5ZVM3M3lRYVRrVlpoVlhHR1lZVklQY20w?=
 =?utf-8?B?K28wKzFMZGR0cHpGanlhQU9LL1ptUUV2L1BaNDBESmQyYWw2V21ZcnN4QWhw?=
 =?utf-8?B?T093cWRUOVI5azZvSkpRcWlpdG84MGowSU95OHh1Nm1nZHBqVElJZUNDcndM?=
 =?utf-8?B?MFd1N3ZUbm9DUVJQY2ZHK0pTaGRWK3Q4bVhnS2htTG5kR2lZVXg2TmJCSDBM?=
 =?utf-8?B?WkpGckNZUDFDaXMzNkp1MVNpUHZXNnFQQXlqUmJvbEpBMDhaZ24yT2NEL1FD?=
 =?utf-8?B?SHVHdFJwLzdQVElPUlpJTmxvZktLcFAvSUhoVEE4V1dCSFArbHFEeFNyS2pL?=
 =?utf-8?B?eHF3a0Iwc3AveW1GR1QyV3F4OUJtbHpwdGZYaFR0ZlpFVnhCMmVaaVlkYkdS?=
 =?utf-8?B?WmtlWlhpQ3dpcGpKdjd5cjZCNUpYUXRDc0ZLQjdiZEJsZEZwSklKYUxPbkgy?=
 =?utf-8?B?RVA1MHJGMVRkNHFIUlhEUU5TRFRlLzAyWkkwUnFVL1RMR3dOTHFmNzFLTjVQ?=
 =?utf-8?B?b05NanZwcExkaTFVT29HRWhXQlZHQWZOM2FIYklzTldHMlB3OWNOVC9xaVNv?=
 =?utf-8?B?SlhRTGJEbzlqRXBZOEVEM1ROcG81NXdjcDZnaitPbVFqN3dUK3FlNWxzREkz?=
 =?utf-8?B?RHdUbFRNQTFWeHkwQzlWRXltdllUdStYV0JOVVEvNFFnb09CTG0xQ2hvODFV?=
 =?utf-8?B?OGpad21QOU9EWTBjdHlKeHZsdk9yUjcxYzdTR1F0cVBGZTVuVDAxdEZYc2Ux?=
 =?utf-8?B?NnRTdThKOXJPZFFiRVJMd29WcjQrRmZKRmZMTG1reDhXa2lwbTQ2R3ViM2ZW?=
 =?utf-8?B?dFZnUUJTRmJrZkRCS294eHRSZDF3R0preS9OM1FhU0U3RmdxZGcySmt3QzM4?=
 =?utf-8?B?eW9sME4rd2ZBVVg0NVA1Vm93ZWRyemU1Q2pqNjBuZk1PN0FDTGM4dTVWY2xs?=
 =?utf-8?B?SXU0akEvOW1RZTFWcFlEMkVJUVlGcFc3Q085K25xMkRIaXd0ZEVJZ2s5M01D?=
 =?utf-8?B?MFJFdDltazh5bFdhTEFVWTNuMGJZenYwSm1Da25qSllRSzRncE5hMEIwV29a?=
 =?utf-8?B?TElaMkJpRmhNV1B2V21oWjNaMDdOSHlLTXYxL1RjMUZmMmVINlR0UUJnL3VE?=
 =?utf-8?B?djFjbkpDMkJSU3poWnVSNEs0aDdnLy9tWUhYWWc4Zks3QmE2OVQwUFhEYTdr?=
 =?utf-8?B?cUM4WHEwMUJjSVd2SWR3NHpGU2dHVVA1Qlg2Rktxd3JRc3kxejB3TDZIN0pO?=
 =?utf-8?B?TkxQcnFQcDJxMkx2VUMyOFFCamZoMk1yZUt1NEtJNFU5WmZOb1VxcUEyWWhv?=
 =?utf-8?B?VzhuaWh0SzEvUTZ2VVJkbkQ2OEhxdDZVb3ZQakZKWHJxcjFMeU5NL3Vqc3dQ?=
 =?utf-8?B?K05lVTIyenpkSFJ5WlQwRzZiVGpLRFhyWDA4N2x2RG5FMFU2ZzFFekt1WDc4?=
 =?utf-8?B?T21aT2wxS3owREtwdENsRCtTa3pITEtFUWNXQm9yVkphaVRQOUhScTRkNG1P?=
 =?utf-8?B?RE41dVdJblQreEFuL3ZCVFFXT2dvWm5ia0J0UkdmQm5hSHRwWEErTURhNlVN?=
 =?utf-8?B?WWRPMGQvazdtZDJNRlU2Z1pHbXNEQkJ2Sng4Ky9Id3dJQzVZMWVscVNyN2g5?=
 =?utf-8?B?QWpQaVc4Z3ZCbmdIREZ4clo3bGc0M0F4bTNzME9jK1lGeUE4UkdLeHF1dGFH?=
 =?utf-8?B?M2k3aVN3TFI2Vm4rZWo2Zmpxeml3b004S0pBZ1l1b1Nzd0cycjF4Z2Npai9q?=
 =?utf-8?B?azJ2V2FDckduT0tma1dySnZDbUlyWm14bGt5aDFQWnNFbytzUUFOMDRXaytw?=
 =?utf-8?B?MFlqOE9qY1RjL3ZVSXRYOTN6ZGs4QnJxaGtEWkhpRjJWRklNSEpKWXI5MFlW?=
 =?utf-8?B?UVpWZVZrbi9vTHA2YVc5SHFIbnluL2QxcFpVdnV2WEltK3ZnUW5LUStYaFZQ?=
 =?utf-8?B?elhnZldJRmdHanRzbzJ5M0VuZ1NiMUNweUxoalZBMm9ibmx2VFU2bXJPZHNP?=
 =?utf-8?B?Q1pibFZjR0daQ21QdTdTYS9QOHhvdWRiQUZvN00wR2ZZVDhTYThmR2htY1pv?=
 =?utf-8?Q?p+KSuuyK4sFTsA7nrNGilTo2N?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FD4430F6ADD95C4E951E8EFB70D8DB1E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d5d50d7-5fb7-46c7-21a6-08daab799277
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 11:13:06.2707
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J3txwyLiO3utLgigqOxEt7K/qpNf57h4FSh5GwnAzFRr8mj8DUdT0sAJh5/H7Tb8/IBYXziClMfUWB+VyaalHdtwQAZf+mR6/3yWgJNn7oY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5145

T24gMTEvMTAvMjAyMiAxMTo0NCwgSGVucnkgV2FuZyB3cm90ZToNCj4gSGkgSmFuLA0KPg0KPj4g
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4NCj4+IFN1YmplY3Q6IFs0LjE3P10gUmU6IFtQQVRDSF0geDg2ZW11bDogcmVz
cGVjdCBOU0NCDQo+Pg0KPj4gT24gMTAuMTAuMjAyMiAxODo0NCwgQW5kcmV3IENvb3BlciB3cm90
ZToNCj4+PiBPbiAxNS8wOS8yMDIyIDA4OjIyLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4gcHJv
dG1vZGVfbG9hZF9zZWcoKSB3b3VsZCBiZXR0ZXIgYWRoZXJlIHRvIHRoYXQgImZlYXR1cmUiIG9m
IGNsZWFyaW5nDQo+Pj4+IGJhc2UgKGFuZCBsaW1pdCkgZHVyaW5nIE5VTEwgc2VsZWN0b3IgbG9h
ZHMuDQo+Pj4+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl
LmNvbT4NCj4+PiBSZXZpZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0
cml4LmNvbT4NCj4+IFRoYW5rcy4NCj4+DQo+PiBIZW5yeSAtIHRoaXMgd2FzIHN1Ym1pdHRlZCBi
ZWZvcmUgdGhlIGNvZGUgZnJlZXplLCBzbyB5b3Ugd2VyZW4ndCBDYy1lZC4NCj4+IE1heSBJIGFz
ayB0byBjb25zaWRlciBnaXZpbmcgdGhpcyBhIHJlbGVhc2UgYWNrPw0KPiBTaW5jZSB0aGlzIHBh
dGNoIGlzIHNpbXBsZSBhbmQgdG8gbXkgYmVzdCBrbm93bGVkZ2UgdGhpcyBwYXRjaCBpcyB0cnlp
bmcgdG8NCj4gaW1wcm92ZSB0aGUgY29kZSBzbzoNCj4NCj4gUmVsZWFzZS1hY2tlZC1ieTogSGVu
cnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPg0KPiAoSWYgaXQgd2lsbCBub3QgY2F1c2Ug
dG9vIG11Y2ggdGltZSBvZiBkaWdnaW5nLCB3b3VsZCB5b3UgbWluZCBhZGRpbmcgYQ0KPiAiRml4
ZXM6IiB0YWcgcG9pbnRpbmcgdG8gdGhlIG9yaWdpbmFsIGNvbW1pdCB0aGF0IG1pc3NpbmcgdGhp
cw0KPiBgIHZjcHVfaGFzX25zY2IoKWAgY2hlY2sgd2hlbiB5b3UgZG8gdGhlIGNvbW1pdHRpbmc/
IEkgdGhpbmsgdGhpcyB3b3VsZA0KPiBoZWxwIHRvIGlkZW50aWZ5IHRoaXMgcGF0Y2ggYXMgYSBi
dWdmaXggc28gaXQgaXMgbW9yZSByZWFzb25hYmxlIHRvIGNvbW1pdA0KPiB0aGlzIHBhdGNoIGlu
IGN1cnJlbnQgcGhhc2UuIEJ1dCBpZiB0b28gbXVjaCB0cm91YmxlIG9yIHlvdSB0aGluayB0aGlz
IGlzDQo+IG5vdCByZWFsbHkgYSBmaXggdGhlbiBqdXN0IGlnbm9yZSBteSBjb21tZW50Li4uKQ0K
DQpUaGVyZSBpc24ndCByZWFsbHkgYW4gYXBwcm9wcmlhdGUgRml4ZXMgdGFnLg0KDQpUaGlzIENQ
VUlEIGJpdCBpcyBvbmUgSSBtYW5hZ2VkIHRvIGdldCBBTUQgdG8gcmV0cm9hY3RpdmVseSBhZGQg
dG8gZml4DQphbiBlbnVtZXJhdGlvbiBwcm9ibGVtIHRoZXkgaGFkIG5vIGFudGljaXBhdGVkIHdo
ZW4gbWFraW5nIGEgY2hhbmdlIGluIFplbjIuDQoNCmkuZS4gdGhlIENQVUlEIGJpdCBkaWQgbm90
IGV4aXN0IGF0IHRoZSBwb2ludCBhdCB3aGljaCB0aGUgY29kZSwNCm1vZGlmaWVkIGluIHRoaXMg
cGF0Y2gsIHdhcyB3cml0dGVuLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:17:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:17:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419578.664370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGZ-0004mw-Jz; Tue, 11 Oct 2022 11:17:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419578.664370; Tue, 11 Oct 2022 11:17:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGZ-0004mp-HD; Tue, 11 Oct 2022 11:17:43 +0000
Received: by outflank-mailman (input) for mailman id 419578;
 Tue, 11 Oct 2022 11:17:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDGY-0004mj-CW
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:17:42 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 517f2c44-4956-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 13:17:40 +0200 (CEST)
Received: from FR3P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::10)
 by AS2PR08MB8672.eurprd08.prod.outlook.com (2603:10a6:20b:55f::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:37 +0000
Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4b:cafe::bf) by FR3P281CA0060.outlook.office365.com
 (2603:10a6:d10:4b::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:37 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:36 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Tue, 11 Oct 2022 11:17:36 +0000
Received: from 3d56859cccad.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 98E9BC8D-BB58-43C4-81D0-43894675FEB3.1; 
 Tue, 11 Oct 2022 11:17:29 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3d56859cccad.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:29 +0000
Received: from FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14)
 by DU0PR08MB8686.eurprd08.prod.outlook.com (2603:10a6:10:402::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Tue, 11 Oct
 2022 11:17:27 +0000
Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1e:cafe::89) by FR0P281CA0080.outlook.office365.com
 (2603:10a6:d10:1e::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:27 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:27 +0000
Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:26 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com
 (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:25 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 517f2c44-4956-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Ftn3sGz+YvNcpBwNjBcF79AFOCwkrOsURiu+3WeLqrBGpO+MjC5TiFbfe2qOr+HTOtubdCKeiE7/XZGH10Y0FGs5LBT4u0/0DV0W5ZvaDO/X09cuhEjndpNKLpLjwdlxph71sNgZXv7AmuryRvjAKXwWHVgIS1xb5nT92OA1V+7sHKIfn1vnXAzHhmUsD/6iaY6Ym2R6U+rOeJgPN3wA/XDn92ErDG227fQXb+BQuVSq0RY6tbN8pqdNnKqQ8I/6maAWVMAnD1YhshRZN9qNO/G+O1/JOBpfrHFwTJtOxUlR28sEStqm3N2D15qv2VVzNoNzDLWhOdsWczW6oifllw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZcgLla+HZ240syv8yfnm4s6c61WXbrfIb18OF9+do9c=;
 b=cy5SlO0858Vcn+i4AOVx+DVYGr8nRMRsydZvL1B/kqdzhzhAdCndoG1azQrPqVEOP66rVaa/nlOa2Y67SlUvrDMcNH5cW5gZi3a42I4ojsa23G++/p3X8PKXwOE0JZjOPD5ySvMZsQ624ntT+K8ImGeH5Q8YiGm7AdOSotWT5lL9hgthVk1f1DbrAplpMa3YeHhOGHXRlWLBME/EOIjR9vOlMG28p6/o5DoNzNuwGQ6fbkySmN0AFuTOXiscGdxbwZwx6OF3pm8iaSyGmkJq9T5MuIqUuPhuZArR3FpAL9CN1iLLQIpApro4jXIS8L9EuodlyX/DXS+ak7HoPi9M7g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZcgLla+HZ240syv8yfnm4s6c61WXbrfIb18OF9+do9c=;
 b=ULko2i5VUUMwMk1WvZgmS7AQwXe9QRmIfOVhZScVRGPmHmtnzrIhQkIG11jao2Oi1O1o+m7QAi0nm0hO0zHwNy7NVJC1+dwN1KFoPOSe/vGAlV3ZblF4Lxzv3y5AwM1fl28fl0yIUQE/1iTFV/pLyWtiIt/2b6Fb6UjXggjHxsM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 285fc00237352b6c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hYaViO5cnB5fv3iJqAtbt0p5sjKxdZy5CjTTJBhZo0GCiDDEWisS3N7eNQs9Omj9IGtQuAByRWbCkO4zdzkf0QzyNHWlFQ2mjAjSHZ3diKohbSsLf7vwhTzngUsWWOONrEDKvziR4c2ze63HxIgZi7AHyvbfGhnCkEfSGgJrAKjyfBaqlrDraLz2ej+9dOaiYYOkUDUTK3vV6rPOkhAj80xUsRstRpJ8DwVIspOmbVdC+PDKgSNwrqtfb52YKFkHYwORq4O6BDL14aHfuIqeaWhKaSLptwMBKEeWZMD6DNXU31VfT+C34gx41y2Uq68kzuMWPXFwTRd8sghcxXxHGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZcgLla+HZ240syv8yfnm4s6c61WXbrfIb18OF9+do9c=;
 b=PwWbxEq6zw2lrC2y0jxI8cu6EkUt2R8L6yLHwf0wz0az+opG67UlVb3q3TWQ86Brx9NasMm9QgEYpDv6K79k8oQ+/UipzeAwvr+CyIe4hTughCYYPcQ7lp5Zhv7GEiutgRbPJ4BK9CiCYWOZnyhLD28FJt9dFDK1Ka/yi79ONN58UwMozvdyr4rSd+eSkKgRMPbEofIFTQUj7Q2kpWcOLdaTLKZGfo1MYsOmFbYCm0G4+gfJqplreOmHG9iC/+8vjviQ8v9Tt2Th2cKTDVrK4H3mTnJZ3vVGQaFVoAH6HKRDjjtAgaklge1sqp0rE3FtPsxFxG8C1qJZ748UGhVQfg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZcgLla+HZ240syv8yfnm4s6c61WXbrfIb18OF9+do9c=;
 b=ULko2i5VUUMwMk1WvZgmS7AQwXe9QRmIfOVhZScVRGPmHmtnzrIhQkIG11jao2Oi1O1o+m7QAi0nm0hO0zHwNy7NVJC1+dwN1KFoPOSe/vGAlV3ZblF4Lxzv3y5AwM1fl28fl0yIUQE/1iTFV/pLyWtiIt/2b6Fb6UjXggjHxsM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v6 0/6] Device tree based NUMA support for Arm - Part#2
Date: Tue, 11 Oct 2022 19:17:02 +0800
Message-ID: <20221011111708.1272985-1-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VE1EUR03FT040:EE_|DU0PR08MB8686:EE_|VE1EUR03FT003:EE_|AS2PR08MB8672:EE_
X-MS-Office365-Filtering-Correlation-Id: 84a7414f-fa4b-44a4-c7cb-08daab7a33bb
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 BTStB5u0z1eJ5nlzYSKfp5KfptKxnyE6xNyNzR52O/4AWqzAzajWOBNCqhFd1aKrlCsE/TB/3xnEEq6FygxYQ0D2XCFHxG4CbT5lJe7PVt1Vo3sessTb+N584gz/LDlOJC0X086Grb3or1hcqycBLYecvRXj7xNyDPT8n/SWmxJA1M1tQGekisMGC6e2ofSCWQEsepy3EHRQbNcCNifmHpDWygNsUdfUdjgo/XPwSAKZJHv6Wgr9jZp8c5GdtpPfsve3u4gsDikpD/kiqKrq9ffnODaE0clFvr3xxZMCgSmNxnnL1v7k1VtAz8k8Oo1UFK6nIFi1CwrinTWZTD5OO3FSIFJptjw45pLPTc3anLBDv5vSQIka0SsswbeysxCtBCyVEEPlMAKcaCJctY98o1jitW0FB4E1dVFRpAr7OswEKYnQ+z4LNIcAE6gvfXKNK2da2hqn1L5vtcJ5GJQT1e9xwU4PzoyQ5gFY25XQ+py+HFl/OlVUAJFkSLo5F4bro3ElXFCj5i06RZ2IvgzAlOvAhYdCZOm47lbBkL+SxGBy3h3S8cAvJBRBsncnG7oDU8KfFRbdFLtldfbJociEi5HsvVT9JjlQoc5vdn0kt20bas6QqzWS7FcdcaorkPFatIzsBcyb8tkGTrmiHTSjqZqdhUS3uE973ApldS0ePChSFlaUns0bv5hFfpWZbb86SMPEXXdVcoe7bsINh0OtxjCI2vhtgc8N4zY3VhA7dBAtKeu01jwnQrjuha6NbeIBKnFfNOnUoJubo9jVMlvul4CA9ot6B2RvN+icVcasmrI35lC/J7yLh6V0PmGo/7rlPRUIg5TY8244JTjIUvpJznak8kVeFM5SW+tWZU9m04YYpWo1D1Zr7N6qAf5fuT2Y
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(70586007)(478600001)(966005)(8936002)(6916009)(4326008)(316002)(54906003)(8676002)(70206006)(6666004)(26005)(5660300002)(41300700001)(82740400003)(336012)(1076003)(40460700003)(2616005)(7696005)(186003)(44832011)(82310400005)(36860700001)(2906002)(83380400001)(426003)(356005)(36756003)(86362001)(81166007)(40480700001)(47076005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8686
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d6a1e9f5-ec10-4941-40cb-08daab7a2e06
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AfVZ83Bvw0WVvs2bRYqetktFauC/btL1N28qc+4t1YCQxviuGvqkFw+PpZrfaBfSESvD/5MZVRlE3nGzfdr2i4aJE0kjjWBLcKCShxbht/bOe2A9LVwSOyul4OHkVOIwOBdxF/4L8amrJC+6aR4i4ba6il5MVXc9YybY6SKPibma+apiezkenHEUomr+Y9+CiLPG2XEevhw8mwgb5JNBzCuFuy6jEHqCXCndffAHha67o3EriPxXJL/abefahaStWfDwMmq5BX4Em1re3a/09MfzSNTvHIrwuwlvqSMbdFQdhukWqhRgikRYrlNRoPeisEPzNcrnSgj5Ib7tK0CpATL2CTblPiDcmNiGET1uXGTqX0W+JWYDpOnKp7nHsnsZ4NhW/uK7qkerxcd6QZlWpKXxqYH3hAbXhDEyDYEoV4xp6odGhcAiujxLrnvyBKQgPaiIC3G5tq7C0HmhdkPORQmkDyisE9RiF6BZDRxtYdBvy7Pk1hPktSYWxOd6uDEldbY8GPL7Tl1YTBomRE2yZ1lz4Kez61hhPDxra4/yWQTIRwBILIawIyf2agOTwGWuy7n8vQ4HltSqMMrL1R9LUnZC6qvD35wGbs2oexe7kB+SJ6aS547mIaTPS/5eD+Tk9iUiNS2vFPSeq0tggREopsPAOw/r+0KxyYcRtn/g8/7XA9YHPI/jeBy5PHimng/7BEG4pT8/E7OiiGcq0grl4Xp5XiTXYFAXrkpCW3Gn50ti/UGXgw2GxD/30hBPyJgyeiFhqy8jG03mg+Tqj45pZKkPZRH2VR/ba+o5qqXZx7K8bbP45CcGONtoc2mS/oPuqgi0hM1bScPq1zyom0uGUw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(40470700004)(46966006)(36840700001)(70586007)(8676002)(70206006)(26005)(7696005)(4326008)(1076003)(186003)(316002)(107886003)(478600001)(54906003)(6666004)(41300700001)(47076005)(36756003)(2616005)(336012)(426003)(83380400001)(6916009)(8936002)(44832011)(82310400005)(36860700001)(86362001)(5660300002)(40480700001)(966005)(2906002)(81166007)(40460700003)(82740400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:17:36.7244
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 84a7414f-fa4b-44a4-c7cb-08daab7a33bb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8672

(The Arm device tree based NUMA support patch set contains 35
patches. In order to make stuff easier for reviewers, I split
them into 3 parts:
1. Preparation. I have re-sorted the patch series. And moved
   independent patches to the head of the series - merged in [1]
2. Move generically usable code from x86 to common - this series.
3. Add new code to support Arm.

This series only contains the second part patches. As the whole NUMA
series has been reviewed for 1 round in [2], so this series would
be v6)

Xen memory allocation and scheduler modules are NUMA aware.
But actually, on x86 has implemented the architecture APIs
to support NUMA. Arm was providing a set of fake architecture
APIs to make it compatible with NUMA awared memory allocation
and scheduler.

Arm system was working well as a single node NUMA system with
these fake APIs, because we didn't have multiple nodes NUMA
system on Arm. But in recent years, more and more Arm devices
support multiple nodes NUMA system.

So now we have a new problem. When Xen is running on these Arm
devices, Xen still treat them as single node SMP systems. The
NUMA affinity capability of Xen memory allocation and scheduler
becomes meaningless. Because they rely on input data that does
not reflect real NUMA layout.

Xen still think the access time for all of the memory is the
same for all CPUs. However, Xen may allocate memory to a VM
from different NUMA nodes with different access speeds. This
difference can be amplified in workloads inside VM, causing
performance instability and timeouts.

So in this patch series, we implement a set of NUMA API to use
device tree to describe the NUMA layout. We reuse most of the
code of x86 NUMA to create and maintain the mapping between
memory and CPU, create the matrix between any two NUMA nodes.
Except ACPI and some x86 specified code, we have moved other
code to common. In next stage, when we implement ACPI based
NUMA for Arm64, we may move the ACPI NUMA code to common too,
but in current stage, we keep it as x86 only.

This patch serires has been tested and booted well on one
Arm64 NUMA machine and one HPE x86 NUMA machine.

[1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html

---
v5 -> v6:
 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa
    can be set to -1 by users. So acpi_numa < 0 does not mean
    a broken firmware.
 2. Replace numa_scan_node to numa_process_nodes in commit log.
 3. Limit the scope of page_num_node, vnuma and page of numa_setup
    function.
 4. Use memset to init page_num_node instead of for_each_online_node.
 5. Use %u instead of %d for nodeid_t and j in numa_setup print
    messages.
 6. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift
    when only one node is in the system.
 7. Drop the marco: node_to_first_cpu(node)
 8. Use arch_numa_unavailable to replace arch_numa_disabled for
    acpi_numa <= 0.
 9. Remove Kconfig for HAS_NUMA_NODE_FWID.
10. Use numa_fw_nid_name for NUMA implementation to set their fw
    NUMA node name for print messages.

v4 -> v5:
 1. Use arch_numa_broken instead of arch_numa_disabled for
    acpi_numa < 0 check. Because arch_numa_disabled might
    include acpi_numa < 0 (init failed) and acpi_numa == 0
    (no data or data no init) cases.
 2. Use nodeid_t instead of uint8_t for memnodemap.
 3. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the
    further adjustments for _memnodemap's type.
 4. Use __ro_after_init for numa_off.
 5. Use pointer-to-const for proper function parameters.
 6. Use unsigned int for variables that are not realy used for node ID.
 7. Fix code comments code-style and adjust the length.
 8. Fix code-styles.
 9. Rename numa_scan_nodes to numa_process_nodes.
10. Defer introduce arch_numa_disabled for acpi_numa <= 0. And remove
    the paramter init_as_disable of arch_numa_disabled.
11. Fix typo "expandsion".
12. Fix Indentation for l1tf_safe_maddr.
13. Remove double blank lines.
14. Add a space between for_each_node_mask and '('.
    Add a space page_list_for_each and '('.
15. Use bool for nodes_cover_memory return value.
16. Use a plain "int ret" to record compute_hash_shift return value.
17. Add a blank line before the function's main "return".
18. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig.

v3 -> v4:
 1. Add init_as_disable as arch_numa_disabled parameter in the patche
    where use it.
 2. Drop unnecessary "else" from arch_numa_setup, and fix its
   indentation.
 3. Restore compute_hash_shift's return value to int.
 4. Remove unnecessary parentheses for macros.
 5. Use unsigned int for proper variables.
 6. Fix some code-style.
 7. Move arch_get_ram_range function comment to header file.
 8. Use bool for found, and add a new "err" for the return
    value of arch_get_ram_range.
 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges.
10. Use bool as return value for functions that only return
    0/1 or 0/-EINVAL.
11. Move mem_hotplug to a proper place in mm.h
12. Remove useless "size" in numa_scan_nodes.
13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping
    between node id and architectural node id (fw node id).

v2 -> v3:
 1. Drop enumeration of numa status.
 2. Use helpers to get/update acpi_numa.
 3. Insert spaces among parameters of strncmp in numa_setup.
 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch.
 5. Remove acpi.h from common/numa.c.
 6. Rename acpi_scan_nodes to numa_scan_nodes.
 7. Replace u8 by uint8_t for memnodemap.
 8. Use unsigned int for memnode_shift and adjust related functions
    (compute_hash_shift, populate_memnodemap) to use correct types for
    return values or parameters.
 9. Use nodeid_t for nodeid and node numbers.
10. Use __read_mostly and __ro_after_init for appropriate variables.
11. Adjust the __read_mostly and __initdata location for some variables.
12. Convert from plain int to unsigned for cpuid and other proper 
13. Remove unnecessary change items in history.
14. Rename arch_get_memory_map to arch_get_ram_range.
15. Use -ENOENT instead of -ENODEV to indicate end of memory map.
16. Add description to code comment that arch_get_ram_range returns
    RAM range in [start, end) format.
17. Rename bad_srat to numa_fw_bad.
18. Rename node_to_pxm to numa_node_to_arch_nid.
19. Merge patch#7 and #8 into patch#6.
20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h
22. Use 2-64 for node range.

v1 -> v2:
 1. Refine the commit messages of several patches.
 2. Merge v1 patch#9,10 into one patch. Introduce the new functions
    in the same patch that this patch will be used first time.
 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary,
    in this case, we can drop mem_hotplug_boundary.
 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa.
 5. Correct return value of srat_disabled.
 6. Introduce numa_enabled_with_firmware.
 7. Refine the justification of using !node_data[nid].node_spanned_pages.
 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
 9. Adjust the conditional express for ASSERT.
10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86.
11. Use conditional macro to gate MAX_NUMNODES for other architectures.
12. Use arch_get_memory_map to replace arch_get_memory_bank_range
    and arch_get_memory_bank_number.
13. Remove the !start || !end check, because caller guarantee
    these two pointers will not be NULL.
14. Add code comment for numa_update_node_memblks to explain:
    Assumes all memory regions belonging to a single node
    are in one chunk. Holes between them will be included
    in the node.
15. Merge this single patch instead of serval patches to move
    x86 SRAT code to common.
16. Export node_to_pxm to keep pxm information in NUMA scan
    nodes error messages.
17. Change the code style to target file's Xen code-style.
18. Adjust some __init and __initdata for some functions and
    variables.
19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts.
20. Turn numa_scan_nodes to static.
21. Change NR_NUMA_NODES upper bound from 4095 to 255.

Wei Chen (6):
  xen/x86: Provide helpers for common code to access acpi_numa
  xen/x86: move generically usable NUMA code from x86 to common
  xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid
  xen/x86: use arch_get_ram_range to get information from E820 map
  xen/x86: move NUMA process nodes nodes code from x86 to common
  xen: introduce a Kconfig option to configure NUMA nodes number

 xen/arch/Kconfig                 |  11 +
 xen/arch/x86/include/asm/acpi.h  |   2 -
 xen/arch/x86/include/asm/mm.h    |   2 -
 xen/arch/x86/include/asm/numa.h  |  61 +--
 xen/arch/x86/include/asm/setup.h |   1 -
 xen/arch/x86/mm.c                |   2 -
 xen/arch/x86/numa.c              | 441 +----------------
 xen/arch/x86/smpboot.c           |   2 +-
 xen/arch/x86/srat.c              | 335 +------------
 xen/common/Makefile              |   1 +
 xen/common/numa.c                | 802 +++++++++++++++++++++++++++++++
 xen/common/page_alloc.c          |   2 +
 xen/include/xen/mm.h             |   2 +
 xen/include/xen/numa.h           |  96 +++-
 14 files changed, 959 insertions(+), 801 deletions(-)
 create mode 100644 xen/common/numa.c

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:17:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:17:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419579.664380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGk-00056Q-1d; Tue, 11 Oct 2022 11:17:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419579.664380; Tue, 11 Oct 2022 11:17:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGj-00056J-V2; Tue, 11 Oct 2022 11:17:53 +0000
Received: by outflank-mailman (input) for mailman id 419579;
 Tue, 11 Oct 2022 11:17:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDGi-0004mj-8j
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:17:52 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 573d0b69-4956-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 13:17:50 +0200 (CEST)
Received: from DB6PR0601CA0042.eurprd06.prod.outlook.com (2603:10a6:4:17::28)
 by PAXPR08MB6431.eurprd08.prod.outlook.com (2603:10a6:102:157::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct
 2022 11:17:47 +0000
Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:17:cafe::f9) by DB6PR0601CA0042.outlook.office365.com
 (2603:10a6:4:17::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:46 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Tue, 11 Oct 2022 11:17:46 +0000
Received: from 767c858d8d13.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1063E91D-D5AA-4233-AD73-F0E00D5A85C8.1; 
 Tue, 11 Oct 2022 11:17:40 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 767c858d8d13.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:40 +0000
Received: from AM6P194CA0020.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::33)
 by DBAPR08MB5768.eurprd08.prod.outlook.com (2603:10a6:10:1b1::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:37 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::52) by AM6P194CA0020.outlook.office365.com
 (2603:10a6:209:90::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:37 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:36 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:31 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 573d0b69-4956-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Yv0al7Ia6sFLoblssvAZqs+EV4oAyDTrU5RxWW4uQo39cNLWiaKUVT+KFEl464YePyV4zfRBWfeWPIv0K7WTAz0kL+4Usff6OD5p6YpWkECRmm7riep1qclHfVYOoQusvRNcpfbv4jXfyruwbZE5wrY1HfncSSnVG7ellU6AhgbTaYPU0SzC+Ui0FJmEnU1g+J8TL/5DdSn2n8vQw5Uk1Z3jpx7Qk23nCuP7DTRPVxPOMdDUIT4eBJv1rEHb2D9cEgBfxJMYsHnTqleARtWT7xTTMxWuJbS9FGVkdfXxquLAoFso7lQyPrRzsPK7v6u7oFIATfV2jHxKvL+rGRk92g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HTMDqPnJAO8ukxU/OyQ6SxcZEtGPj2cCfm4781eG/lI=;
 b=eC0Zn9TxUwaNt0dbUemBsjLUDFOUKUwpDnTcxkJrhY5qZHPlC3m2ow9pMV0IybabW0W3g7jCoXDyhc9/xu7WqiH2Hs6Q31vVoSH3CMfWJxIM0nUREWro0Nc5Wd7PlyvyiHGmEbbKrLcWc+mWofeH8wzWZXQxHVeikpQHFrRYtWYZOOquTzbEC5vJ1spK6M5qTK2VlxvTSEo9kBVLvlgcGnIobA5CaRi1UMXyJTYtArYZABxCqJyycyVtJIwUVLgsw4lc2nR+jmKVYmPAuePgr/zlnz5czqINGGf3oNjXc8hdG2ka5bC5E5pHpfe2swZPP07GGjUedumiUCM939o67w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HTMDqPnJAO8ukxU/OyQ6SxcZEtGPj2cCfm4781eG/lI=;
 b=hdhexpfSY1Bs2bmSwbOsWlmt/VuNrOsDTiRT7tfAr08yGKflr2zY4ktXTwY1OWBEAjnioH/2t44JWsCHWDmPJLwdgds7vFbjgEvdObotf8mnGS/G1iHmKK8MFFziB1Vx3PhQ499zRq3j2huneSS5yi0rJzogpnLs88w8K2HHjeY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: fa28ce6fddd9d7d1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M+EXJlTLIQvqTwCj+0x4xKhJvHDrHNZwDHwNjPbBP99uIM/5qbGuh7Ykp0PdLDNuNrknVrx6w07vlRduado8HgkGvOoQh+E0HY37fYfutfWTvDIg0iIW4wXkUg241HJ6mHYGi4vBcEUhiPAP43WeODXm+ZxRri1gjTh5qEVvyUWY/eK6K2I55uEyXO5knNrYTYfpr4ntqUv7Qdp81BUK87SONJYFixxOYOlV7d77YiRWgvkaFrCRk/OwGbDqUZeQRfNxx1TmDnubXOiupvwaDTC0qBz9JLudkqOnSC1FTUwz+YvS8r+zmlcO+wIM0FpU7BTvUJDoMvCN6wFDH8iqKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HTMDqPnJAO8ukxU/OyQ6SxcZEtGPj2cCfm4781eG/lI=;
 b=e0+Xe6SNtCdp8TinwG5Y3U3KWdvldohofBYJc+BvaKu4iokq7fYlVUxDQE4sEJa/sVWpp4aNGnrtgYksdA4P/zBjuesdvjAKs7v24ipM7xEMl0AoyzXkbygcyRrti6ADaSOliR61MZeZfegS4i4pGGM/MaVQQ1kZivqYzMzFCO30d2r4fFbE7x6W5wQE3Z4RGpOxHvhQzaY3OInTBJeiVGrtS5VC0j6otNiQz5LfaUxmIpb6zbNvwtw4Id6PJ9tlpK+EV1YT5ewcIPVxv6v8GfEESOJAYDcceuny9gD3jqIV71+uP/0LkEHSG0+Nk/ThU2dIqxncBVe93eJCtQXHHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HTMDqPnJAO8ukxU/OyQ6SxcZEtGPj2cCfm4781eG/lI=;
 b=hdhexpfSY1Bs2bmSwbOsWlmt/VuNrOsDTiRT7tfAr08yGKflr2zY4ktXTwY1OWBEAjnioH/2t44JWsCHWDmPJLwdgds7vFbjgEvdObotf8mnGS/G1iHmKK8MFFziB1Vx3PhQ499zRq3j2huneSS5yi0rJzogpnLs88w8K2HHjeY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
Date: Tue, 11 Oct 2022 19:17:04 +0800
Message-ID: <20221011111708.1272985-3-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221011111708.1272985-1-wei.chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VE1EUR03FT044:EE_|DBAPR08MB5768:EE_|DBAEUR03FT058:EE_|PAXPR08MB6431:EE_
X-MS-Office365-Filtering-Correlation-Id: a5104c61-8280-436b-e18f-08daab7a39c3
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 D9GeSJ6Pzi9+EMPYyyaJ8ovrqej0tqU/SdmMSG3TFo1HoUZosEI1zzlvBbhd2prapEPDUrics1c3r+uPMu2h1H+axnPKoN20LnO1Po2rjn17FyZ0jxeGxh+Z7T971DPO7tFnMikA7BOguZD3A95XlcnNAARKdnEt8b+GdIiiUL53vdr18wYsKizaUZ3RBG9gftE2cPyevvIGXylbUuRsve5iLoDV18xWvSIoGgk8GvLdu96Jz1R3v9kJqnP6ZSpSV85X98rz/jAkU6bD/55nfcqPQJ82h2xHIcP4eUfKCnM7LvflmY/PrE0vvl/O9yeRD8sn+QP4N/3T6ihMx3gS0yfII8KZN214waqg5pDic7pm4BQpErgqQ8yv6FuvoFDfi4jkc04VhtH6XWtYi80mV1b8d0Ybd+K8AZFTxXYz15XRuzgYa43Jr07O63iR3XUlOaJyI8Qo/JghyuUEoNztO5hjCDps9TbVijr9Zr48wiQNfm43EqTkvvsVuPx9qfdYEmieSx2zYA5VxWcR4FnnK5ATMFKBx/Lotk1ySY6BO0PfkLEPtJeMcCDemT8bC3devOdHwID8+qPS+4w31Papxa4ydIhmclFTqNz0mZ0QuyQ5SkzU3PnUfCxr9zD5S6nFKRaQhgfxUAiNoo6Zh0wqnhSuGjcojJ8N7t7b8Ea4WxnGZlf0mAMsjhL+yY1sEE68YeVErQQG7fUHwVDu2uM7b9oLDiOj2xDaW8iZv2dGdzRCW5otj5VQ9+C64O/rvzoo3vez3T6nnnTdLVtWl5CgQwqzlvSTknYCjyE+QyvUapxntY7pgPrq67Px6fazWqk0WjA6gGeRxXPDHdC9EonFbw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39850400004)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(6916009)(54906003)(316002)(70206006)(4326008)(8676002)(70586007)(6666004)(478600001)(5660300002)(26005)(41300700001)(81166007)(426003)(356005)(2906002)(336012)(44832011)(30864003)(2616005)(186003)(8936002)(1076003)(47076005)(7696005)(83380400001)(36756003)(36860700001)(82740400003)(86362001)(40460700003)(82310400005)(40480700001)(21314003)(36900700001)(579004);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5768
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	30906582-eb93-467e-a8e6-08daab7a33a7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	C8+Uz/W0IOcUJQXzKaNS6enR8gDrzv3skAEHqIsJ7ITEv8UtuttbYTADd111dWCACD0oyNkK1WDClTTbqginFbDIKfcp+vGZBH3Ljn9mwCQRxgPehh4Tw9MN0O88Btpuvq1HnxkoYa0zUp57lzLH3Lz+ND7AT/ZabSoQCEDi+QPsp+vpj4qscfmXPHgWijrbHdBr2GWcmLir4sE2d7SLahuH91JWUFNaS0OkfDv3LT5ddmGd0Ud//FGeKXyp3qWXvvLkRgFhCX2YSjBFizR9jMgwKpbbViy3+t6eszl4x+3s9lK8E66ceaxfUezfDu2sQH6fFQL5goa3qEx03Fo1wfOm+oBhKesDkVUjZPaSTIGMHpElthC6bL/W58gtdFh/I8ZwT2b8c8eQWlqI06bsaWwcQJF/RQIdu+N/MjGn5k3OAoTFn8XUswkA+Ek8x8waLexdOlxWKbCyIbIe8gCGKJZF57Dreqz6cIijPvTg7hUuo4MqYwfRDtTuVrWXlw4YKg3m+NGcvBJSOrY/gCQwR56HONGRVw761hVgPMZA1KTpcFnKmRBYNT+0zosguJU8mpTDalLzl6+hhcYgHK+f87ku+RN4K5Y70V4Ic9jBzjc/rnZLtCrb4qsC3QqI/1WNWan3FE+AH+JliCLMiuqPTSsd/w0qo0s1l/5mJVNh8p/srrZ6IuGMDI5S2QL/zLy/J/qVsD9phPvCk2ke5WE5YH/AEg23XJGyuksUY9Al1YsUKFM/3UIEzcNKu12jKAbTet/1LXIoth+XwrxJsXRVwFzsAxSOcG7TGg0+bY8ZK3w=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(26005)(7696005)(40460700003)(41300700001)(2616005)(8936002)(107886003)(186003)(1076003)(6666004)(36756003)(426003)(82310400005)(8676002)(336012)(83380400001)(478600001)(316002)(54906003)(6916009)(81166007)(44832011)(5660300002)(47076005)(4326008)(70206006)(70586007)(30864003)(86362001)(36860700001)(2906002)(40480700001)(82740400003)(21314003)(579004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:17:46.9844
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a5104c61-8280-436b-e18f-08daab7a39c3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6431

There are some codes in x86/numa.c can be shared by common
architectures to implememnt NUMA support. Just like some
variables and functions to check and store NUMA memory map.
And some variables and functions to do NUMA initialization.

In this patch, we move them to common/numa.c and xen/numa.h
and use the CONFIG_NUMA to gate them for non-NUMA supported
architectures. As the target header file is Xen-style, so
we trim some spaces and replace tabs for the codes that has
been moved to xen/numa.h at the same time.

As acpi_scan_nodes has been used in a common function, it
doesn't make sense to use acpi_xxx in common code, so we
rename it to numa_process_nodes in this patch too. After that
if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes
in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA
will be selected by CONFIG_ACPI_NUMA for x86. So, we replace
CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes.

As arch_numa_disabled has been implememnted for ACPI NUMA,
we can rename srat_disabled to numa_disabled and move it
to common code as well.

The macro node_to_first_cpu(node) hasn't been used anywhere,
so we drop it in this patch too.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v5 -> v6:
 1. Replace numa_scan_node to numa_process_nodes in commit log.
 2. Limit the scope of page_num_node, vnuma and page of numa_setup
    function.
 3. Use memset to init page_num_node instead of for_each_online_node.
 4. Use %u instead of %d for nodeid_t and j in numa_setup print
    messages.
 5. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift
    when only one node is in the system.
 6. Drop the marco: node_to_first_cpu(node)
v4 -> v5:
 1. Use nodeid_t instead of uint8_t for memnodemap.
 2. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the
    further adjustments for _memnodemap's type.
 3. Use __ro_after_init for numa_off.
 4. Use pointer-to-const for proper function parameters.
 5. Use unsigned int for variables that are not realy used for node ID.
 6. Fix code comments code-style and adjust the length.
 7. Fix code-styles.
 8. Rename numa_scan_nodes to numa_process_nodes.
 9. Use a plain "int ret" to record compute_hash_shift return value.
v3 -> v4:
 1. Restore compute_hash_shift's return value to int.
 2. Remove unnecessary parentheses for macros.
 3. Use unsigned int for proper variables.
 4. Fix some code-style.
v2 -> v3:
 1. Remove acpi.h from common/numa.c.
 2. Rename acpi_scan_nodes to numa_scan_nodes.
 3. Replace u8 by uint8_t for memnodemap.
 4. Use unsigned int for memnode_shift and adjust related functions
    (compute_hash_shift, populate_memnodemap) to use correct types for
    return values or parameters.
 5. Use nodeid_t for nodeid and node numbers.
 6. Use __read_mostly and __ro_after_init for appropriate variables.
 7. Adjust the __read_mostly and __initdata location for some variables.
 8. convert from plain int to unsigned for cpuid and other proper variables.
 9. Use __attribute_pure__ instead of __attribute__((pure)).
10. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA in numa_initmem_init.
11. Add const for some functions' parameters.
12. Move srat_disabled to common code with new name numa_disabled.
13. Fix some spaces code-style for numa_emulation.
14. Change from int to unsigned int for numa_fake.
v1 -> v2:
1. New patch in v2.
---
 xen/arch/x86/include/asm/acpi.h  |   1 -
 xen/arch/x86/include/asm/numa.h  |  57 +---
 xen/arch/x86/include/asm/setup.h |   1 -
 xen/arch/x86/numa.c              | 433 +---------------------------
 xen/arch/x86/smpboot.c           |   2 +-
 xen/arch/x86/srat.c              |  10 +-
 xen/common/Makefile              |   1 +
 xen/common/numa.c                | 464 +++++++++++++++++++++++++++++++
 xen/include/xen/numa.h           |  66 +++++
 9 files changed, 539 insertions(+), 496 deletions(-)
 create mode 100644 xen/common/numa.c

diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h
index 9a9cc4c240..5c2dd5da2d 100644
--- a/xen/arch/x86/include/asm/acpi.h
+++ b/xen/arch/x86/include/asm/acpi.h
@@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address;
 #define ARCH_HAS_POWER_INIT	1
 
 extern s8 acpi_numa;
-extern int acpi_scan_nodes(u64 start, u64 end);
 #define NR_NODE_MEMBLKS (MAX_NUMNODES*2)
 
 extern struct acpi_sleep_info acpi_sinfo;
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 237f2c6dbf..6c87942d43 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -9,72 +9,17 @@ typedef u8 nodeid_t;
 
 extern int srat_rev;
 
-extern nodeid_t      cpu_to_node[NR_CPUS];
-extern cpumask_t     node_to_cpumask[];
-
-#define cpu_to_node(cpu)		(cpu_to_node[cpu])
-#define parent_node(node)		(node)
-#define node_to_first_cpu(node)  (__ffs(node_to_cpumask[node]))
-#define node_to_cpumask(node)    (node_to_cpumask[node])
-
-struct node { 
-	paddr_t start, end;
-};
-
-extern int compute_hash_shift(struct node *nodes, int numnodes,
-			      nodeid_t *nodeids);
 extern nodeid_t pxm_to_node(unsigned int pxm);
 
 #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
-#define VIRTUAL_BUG_ON(x) 
 
-extern void numa_add_cpu(int cpu);
-extern void numa_init_array(void);
-extern bool numa_off;
-
-extern int arch_numa_setup(const char *opt);
-extern bool arch_numa_disabled(void);
-extern bool srat_disabled(void);
-extern void numa_set_node(int cpu, nodeid_t node);
+extern bool numa_disabled(void);
 extern nodeid_t setup_node(unsigned int pxm);
 extern void srat_detect_node(int cpu);
 
-extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
 extern nodeid_t apicid_to_node[];
 extern void init_cpu_to_node(void);
 
-static inline void clear_node_cpumask(int cpu)
-{
-	cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
-}
-
-/* Simple perfect hash to map pdx to node numbers */
-extern int memnode_shift; 
-extern unsigned long memnodemapsize;
-extern u8 *memnodemap;
-
-struct node_data {
-    unsigned long node_start_pfn;
-    unsigned long node_spanned_pages;
-};
-
-extern struct node_data node_data[];
-
-static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr)
-{ 
-	nodeid_t nid;
-	VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
-	nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; 
-	VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); 
-	return nid; 
-} 
-
-#define NODE_DATA(nid)		(&(node_data[nid]))
-
-#define node_start_pfn(nid)	(NODE_DATA(nid)->node_start_pfn)
-#define node_spanned_pages(nid)	(NODE_DATA(nid)->node_spanned_pages)
-#define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
-				 NODE_DATA(nid)->node_spanned_pages)
 #define arch_want_default_dmazone() (num_online_nodes() > 1)
 
 extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h
index 21037b7f31..ae470ea12f 100644
--- a/xen/arch/x86/include/asm/setup.h
+++ b/xen/arch/x86/include/asm/setup.h
@@ -20,7 +20,6 @@ void early_time_init(void);
 
 void set_nr_cpu_ids(unsigned int max_cpus);
 
-void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
 void arch_init_memory(void);
 void subarch_init_memory(void);
 
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 1c3198445d..90b2a22591 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -4,20 +4,11 @@
  * Adapted for Xen: Ryan Harper <ryanh@us.ibm.com>
  */ 
 
-#include <xen/mm.h>
-#include <xen/string.h>
 #include <xen/init.h>
-#include <xen/ctype.h>
+#include <xen/mm.h>
 #include <xen/nodemask.h>
 #include <xen/numa.h>
-#include <xen/keyhandler.h>
-#include <xen/param.h>
-#include <xen/time.h>
-#include <xen/smp.h>
-#include <xen/pfn.h>
 #include <asm/acpi.h>
-#include <xen/sched.h>
-#include <xen/softirq.h>
 
 #ifndef Dprintk
 #define Dprintk(x...)
@@ -26,28 +17,13 @@
 /* from proto.h */
 #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1)))
 
-struct node_data node_data[MAX_NUMNODES];
-
-/* Mapping from pdx to node id */
-int memnode_shift;
-static typeof(*memnodemap) _memnodemap[64];
-unsigned long memnodemapsize;
-u8 *memnodemap;
-
-nodeid_t cpu_to_node[NR_CPUS] __read_mostly = {
-    [0 ... NR_CPUS-1] = NUMA_NO_NODE
-};
 /*
  * Keep BIOS's CPU2node information, should not be used for memory allocaion
  */
 nodeid_t apicid_to_node[MAX_LOCAL_APIC] = {
     [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE
 };
-cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
 
-nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
-
-bool numa_off;
 s8 acpi_numa = 0;
 
 int __init arch_numa_setup(const char *opt)
@@ -69,270 +45,6 @@ bool arch_numa_disabled(void)
     return acpi_numa < 0;
 }
 
-bool srat_disabled(void)
-{
-    return numa_off || arch_numa_disabled();
-}
-
-/*
- * Given a shift value, try to populate memnodemap[]
- * Returns :
- * 1 if OK
- * 0 if memnodmap[] too small (of shift too small)
- * -1 if node overlap or lost ram (shift too big)
- */
-static int __init populate_memnodemap(const struct node *nodes,
-                                      int numnodes, int shift, nodeid_t *nodeids)
-{
-    int i, res = -1;
-
-    memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap));
-    for ( i = 0; i < numnodes; i++ )
-    {
-        unsigned long spdx = paddr_to_pdx(nodes[i].start);
-        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1);
-
-        if ( spdx > epdx )
-            continue;
-        if ( (epdx >> shift) >= memnodemapsize )
-            return 0;
-        do {
-            if ( memnodemap[spdx >> shift] != NUMA_NO_NODE &&
-                 (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) )
-                return -1;
-
-            if ( !nodeids )
-                memnodemap[spdx >> shift] = i;
-            else
-                memnodemap[spdx >> shift] = nodeids[i];
-
-            spdx += (1UL << shift);
-        } while ( spdx <= epdx );
-        res = 1;
-    }
-
-    return res;
-}
-
-static int __init allocate_cachealigned_memnodemap(void)
-{
-    unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap));
-    unsigned long mfn = mfn_x(alloc_boot_pages(size, 1));
-
-    memnodemap = mfn_to_virt(mfn);
-    mfn <<= PAGE_SHIFT;
-    size <<= PAGE_SHIFT;
-    printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n",
-           mfn, mfn + size);
-    memnodemapsize = size / sizeof(*memnodemap);
-
-    return 0;
-}
-
-/*
- * The LSB of all start addresses in the node map is the value of the
- * maximum possible shift.
- */
-static int __init extract_lsb_from_nodes(const struct node *nodes,
-                                         int numnodes, const nodeid_t *nodeids)
-{
-    int i, nodes_used = 0;
-    unsigned long spdx, epdx;
-    unsigned long bitfield = 0, memtop = 0;
-
-    for ( i = 0; i < numnodes; i++ )
-    {
-        spdx = paddr_to_pdx(nodes[i].start);
-        epdx = paddr_to_pdx(nodes[i].end - 1) + 1;
-        if ( spdx >= epdx )
-            continue;
-        if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) )
-            bitfield |= spdx;
-        if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] )
-            nodes_used++;
-        if ( epdx > memtop )
-            memtop = epdx;
-    }
-    if ( nodes_used <= 1 )
-        i = BITS_PER_LONG - 1;
-    else
-        i = find_first_bit(&bitfield, sizeof(unsigned long)*8);
-    memnodemapsize = ((memtop - 1) >> i) + 1;
-    return i;
-}
-
-int __init compute_hash_shift(struct node *nodes, int numnodes,
-                              nodeid_t *nodeids)
-{
-    int shift;
-
-    shift = extract_lsb_from_nodes(nodes, numnodes, nodeids);
-    if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) )
-        memnodemap = _memnodemap;
-    else if ( allocate_cachealigned_memnodemap() )
-        return -1;
-    printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift);
-
-    if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 )
-    {
-        printk(KERN_INFO "Your memory is not aligned you need to "
-               "rebuild your hypervisor with a bigger NODEMAPSIZE "
-               "shift=%d\n", shift);
-        return -1;
-    }
-
-    return shift;
-}
-/* initialize NODE_DATA given nodeid and start/end */
-void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
-{
-    unsigned long start_pfn = paddr_to_pfn(start);
-    unsigned long end_pfn = paddr_to_pfn(end);
-
-    NODE_DATA(nodeid)->node_start_pfn = start_pfn;
-    NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn;
-
-    node_set_online(nodeid);
-} 
-
-void __init numa_init_array(void)
-{
-    int rr, i;
-
-    /* There are unfortunately some poorly designed mainboards around
-       that only connect memory to a single CPU. This breaks the 1:1 cpu->node
-       mapping. To avoid this fill in the mapping for all possible
-       CPUs, as the number of CPUs is not known yet.
-       We round robin the existing nodes. */
-    rr = first_node(node_online_map);
-    for ( i = 0; i < nr_cpu_ids; i++ )
-    {
-        if ( cpu_to_node[i] != NUMA_NO_NODE )
-            continue;
-        numa_set_node(i, rr);
-        rr = cycle_node(rr, node_online_map);
-    }
-}
-
-#ifdef CONFIG_NUMA_EMU
-static int numa_fake __initdata = 0;
-
-/* Numa emulation */
-static int __init numa_emulation(unsigned long start_pfn,
-                                 unsigned long end_pfn)
-{
-    int i;
-    struct node nodes[MAX_NUMNODES];
-    uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake;
-
-    /* Kludge needed for the hash function */
-    if ( hweight64(sz) > 1 )
-    {
-        u64 x = 1;
-        while ( (x << 1) < sz )
-            x <<= 1;
-        if ( x < sz/2 )
-            printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n");
-        sz = x;
-    }
-
-    memset(&nodes,0,sizeof(nodes));
-    for ( i = 0; i < numa_fake; i++ )
-    {
-        nodes[i].start = pfn_to_paddr(start_pfn) + i * sz;
-        if ( i == numa_fake - 1 )
-            sz = pfn_to_paddr(end_pfn) - nodes[i].start;
-        nodes[i].end = nodes[i].start + sz;
-        printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n",
-               i,
-               nodes[i].start, nodes[i].end,
-               (nodes[i].end - nodes[i].start) >> 20);
-        node_set_online(i);
-    }
-    memnode_shift = compute_hash_shift(nodes, numa_fake, NULL);
-    if ( memnode_shift < 0 )
-    {
-        memnode_shift = 0;
-        printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n");
-        return -1;
-    }
-    for_each_online_node ( i )
-        setup_node_bootmem(i, nodes[i].start, nodes[i].end);
-    numa_init_array();
-
-    return 0;
-}
-#endif
-
-void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
-{ 
-    int i;
-    paddr_t start = pfn_to_paddr(start_pfn);
-    paddr_t end = pfn_to_paddr(end_pfn);
-
-#ifdef CONFIG_NUMA_EMU
-    if ( numa_fake && !numa_emulation(start_pfn, end_pfn) )
-        return;
-#endif
-
-#ifdef CONFIG_ACPI_NUMA
-    if ( !numa_off && !acpi_scan_nodes(start, end) )
-        return;
-#endif
-
-    printk(KERN_INFO "%s\n",
-           numa_off ? "NUMA turned off" : "No NUMA configuration found");
-
-    printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n",
-           start, end);
-    /* setup dummy node covering all memory */
-    memnode_shift = BITS_PER_LONG - 1;
-    memnodemap = _memnodemap;
-    /* Dummy node only uses 1 slot in reality */
-    memnodemap[0] = 0;
-    memnodemapsize = 1;
-
-    nodes_clear(node_online_map);
-    node_set_online(0);
-    for ( i = 0; i < nr_cpu_ids; i++ )
-        numa_set_node(i, 0);
-    cpumask_copy(&node_to_cpumask[0], cpumask_of(0));
-    setup_node_bootmem(0, start, end);
-}
-
-void numa_add_cpu(int cpu)
-{
-    cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
-} 
-
-void numa_set_node(int cpu, nodeid_t node)
-{
-    cpu_to_node[cpu] = node;
-}
-
-/* [numa=off] */
-static int __init cf_check numa_setup(const char *opt)
-{
-    if ( !strncmp(opt, "off", 3) )
-        numa_off = true;
-    else if ( !strncmp(opt, "on", 2) )
-        numa_off = false;
-#ifdef CONFIG_NUMA_EMU
-    else if ( !strncmp(opt, "fake=", 5) )
-    {
-        numa_off = false;
-        numa_fake = simple_strtoul(opt + 5, NULL, 0);
-        if ( numa_fake >= MAX_NUMNODES )
-            numa_fake = MAX_NUMNODES;
-    }
-#endif
-    else
-        return arch_numa_setup(opt);
-
-    return 0;
-} 
-custom_param("numa", numa_setup);
-
 /*
  * Setup early cpu_to_node.
  *
@@ -381,146 +93,3 @@ unsigned int __init arch_get_dma_bitsize(void)
                  flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1)
                  + PAGE_SHIFT, 32);
 }
-
-static void cf_check dump_numa(unsigned char key)
-{
-    s_time_t now = NOW();
-    unsigned int i, j, n;
-    struct domain *d;
-    struct page_info *page;
-    unsigned int page_num_node[MAX_NUMNODES];
-    const struct vnuma_info *vnuma;
-
-    printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key,
-           now);
-
-    for_each_online_node ( i )
-    {
-        paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1);
-
-        printk("NODE%u start->%lu size->%lu free->%lu\n",
-               i, node_start_pfn(i), node_spanned_pages(i),
-               avail_node_heap_pages(i));
-        /* sanity check phys_to_nid() */
-        if ( phys_to_nid(pa) != i )
-            printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n",
-                   pa, phys_to_nid(pa), i);
-    }
-
-    j = cpumask_first(&cpu_online_map);
-    n = 0;
-    for_each_online_cpu ( i )
-    {
-        if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] )
-        {
-            if ( n > 1 )
-                printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]);
-            else
-                printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]);
-            j = i;
-            n = 1;
-        }
-        else
-            ++n;
-    }
-    if ( n > 1 )
-        printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]);
-    else
-        printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]);
-
-    rcu_read_lock(&domlist_read_lock);
-
-    printk("Memory location of each domain:\n");
-    for_each_domain ( d )
-    {
-        process_pending_softirqs();
-
-        printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d));
-
-        for_each_online_node ( i )
-            page_num_node[i] = 0;
-
-        spin_lock(&d->page_alloc_lock);
-        page_list_for_each(page, &d->page_list)
-        {
-            i = phys_to_nid(page_to_maddr(page));
-            page_num_node[i]++;
-        }
-        spin_unlock(&d->page_alloc_lock);
-
-        for_each_online_node ( i )
-            printk("    Node %u: %u\n", i, page_num_node[i]);
-
-        if ( !read_trylock(&d->vnuma_rwlock) )
-            continue;
-
-        if ( !d->vnuma )
-        {
-            read_unlock(&d->vnuma_rwlock);
-            continue;
-        }
-
-        vnuma = d->vnuma;
-        printk("     %u vnodes, %u vcpus, guest physical layout:\n",
-               vnuma->nr_vnodes, d->max_vcpus);
-        for ( i = 0; i < vnuma->nr_vnodes; i++ )
-        {
-            unsigned int start_cpu = ~0U;
-
-            if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE )
-                printk("       %3u: pnode ???,", i);
-            else
-                printk("       %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]);
-
-            printk(" vcpus ");
-
-            for ( j = 0; j < d->max_vcpus; j++ )
-            {
-                if ( !(j & 0x3f) )
-                    process_pending_softirqs();
-
-                if ( vnuma->vcpu_to_vnode[j] == i )
-                {
-                    if ( start_cpu == ~0U )
-                    {
-                        printk("%d", j);
-                        start_cpu = j;
-                    }
-                }
-                else if ( start_cpu != ~0U )
-                {
-                    if ( j - 1 != start_cpu )
-                        printk("-%d ", j - 1);
-                    else
-                        printk(" ");
-                    start_cpu = ~0U;
-                }
-            }
-
-            if ( start_cpu != ~0U  && start_cpu != j - 1 )
-                printk("-%d", j - 1);
-
-            printk("\n");
-
-            for ( j = 0; j < vnuma->nr_vmemranges; j++ )
-            {
-                if ( vnuma->vmemrange[j].nid == i )
-                    printk("           %016"PRIx64" - %016"PRIx64"\n",
-                           vnuma->vmemrange[j].start,
-                           vnuma->vmemrange[j].end);
-            }
-        }
-
-        read_unlock(&d->vnuma_rwlock);
-    }
-
-    rcu_read_unlock(&domlist_read_lock);
-}
-
-static int __init cf_check register_numa_trigger(void)
-{
-    register_keyhandler('u', dump_numa, "dump NUMA info", 1);
-    return 0;
-}
-__initcall(register_numa_trigger);
-
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index b46fd9ab18..9df08e9366 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -1350,7 +1350,7 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm)
 
     x86_acpiid_to_apicid[acpi_id] = apic_id;
 
-    if ( !srat_disabled() )
+    if ( !numa_disabled() )
     {
         nodeid_t node = setup_node(pxm);
 
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index fbcd8749c4..ce507dac9e 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -238,7 +238,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa)
 	unsigned pxm;
 	nodeid_t node;
 
-	if (srat_disabled())
+	if (numa_disabled())
 		return;
 	if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) {
 		bad_srat();
@@ -274,7 +274,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 	unsigned pxm;
 	nodeid_t node;
 
-	if (srat_disabled())
+	if (numa_disabled())
 		return;
 	if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) {
 		bad_srat();
@@ -314,7 +314,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 	unsigned int i;
 	bool next = false;
 
-	if (srat_disabled())
+	if (numa_disabled())
 		return;
 	if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) {
 		bad_srat();
@@ -543,8 +543,8 @@ void __init srat_parse_regions(paddr_t addr)
 	pfn_pdx_hole_setup(mask >> PAGE_SHIFT);
 }
 
-/* Use the information discovered above to actually set up the nodes. */
-int __init acpi_scan_nodes(paddr_t start, paddr_t end)
+/* Use discovered information to actually set up the nodes. */
+int __init numa_process_nodes(paddr_t start, paddr_t end)
 {
 	int i;
 	nodemask_t all_nodes_parsed;
diff --git a/xen/common/Makefile b/xen/common/Makefile
index 3baf83d527..9a3a12b12d 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o
 obj-y += memory.o
 obj-y += multicall.o
 obj-y += notifier.o
+obj-$(CONFIG_NUMA) += numa.o
 obj-y += page_alloc.o
 obj-$(CONFIG_HAS_PDX) += pdx.o
 obj-$(CONFIG_PERF_COUNTERS) += perfc.o
diff --git a/xen/common/numa.c b/xen/common/numa.c
new file mode 100644
index 0000000000..3ad3a5138b
--- /dev/null
+++ b/xen/common/numa.c
@@ -0,0 +1,464 @@
+/*
+ * Generic VM initialization for NUMA setups.
+ * Copyright 2002,2003 Andi Kleen, SuSE Labs.
+ * Adapted for Xen: Ryan Harper <ryanh@us.ibm.com>
+ */
+
+#include <xen/init.h>
+#include <xen/keyhandler.h>
+#include <xen/mm.h>
+#include <xen/nodemask.h>
+#include <xen/numa.h>
+#include <xen/param.h>
+#include <xen/sched.h>
+#include <xen/softirq.h>
+
+struct node_data __ro_after_init node_data[MAX_NUMNODES];
+
+/* Mapping from pdx to node id */
+unsigned int __ro_after_init memnode_shift;
+unsigned long __ro_after_init memnodemapsize;
+nodeid_t *__ro_after_init memnodemap;
+static typeof(*memnodemap) __ro_after_init _memnodemap[64];
+
+nodeid_t __read_mostly cpu_to_node[NR_CPUS] = {
+    [0 ... NR_CPUS-1] = NUMA_NO_NODE
+};
+
+cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES];
+
+nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
+
+bool __ro_after_init numa_off;
+
+bool numa_disabled(void)
+{
+    return numa_off || arch_numa_disabled();
+}
+
+/*
+ * Given a shift value, try to populate memnodemap[]
+ * Returns :
+ * 1 if OK
+ * 0 if memnodmap[] too small (of shift too small)
+ * -1 if node overlap or lost ram (shift too big)
+ */
+static int __init populate_memnodemap(const struct node *nodes,
+                                      unsigned int numnodes, unsigned int shift,
+                                      const nodeid_t *nodeids)
+{
+    unsigned int i;
+    int res = -1;
+
+    memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap));
+
+    for ( i = 0; i < numnodes; i++ )
+    {
+        unsigned long spdx = paddr_to_pdx(nodes[i].start);
+        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1);
+
+        if ( spdx > epdx )
+            continue;
+
+        if ( (epdx >> shift) >= memnodemapsize )
+            return 0;
+
+        do {
+            if ( memnodemap[spdx >> shift] != NUMA_NO_NODE &&
+                 (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) )
+                return -1;
+
+            if ( !nodeids )
+                memnodemap[spdx >> shift] = i;
+            else
+                memnodemap[spdx >> shift] = nodeids[i];
+
+            spdx += (1UL << shift);
+        } while ( spdx <= epdx );
+
+        res = 1;
+    }
+
+    return res;
+}
+
+static int __init allocate_cachealigned_memnodemap(void)
+{
+    unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap));
+    unsigned long mfn = mfn_x(alloc_boot_pages(size, 1));
+
+    memnodemap = mfn_to_virt(mfn);
+    mfn <<= PAGE_SHIFT;
+    size <<= PAGE_SHIFT;
+    printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n",
+           mfn, mfn + size);
+    memnodemapsize = size / sizeof(*memnodemap);
+
+    return 0;
+}
+
+/*
+ * The LSB of all start addresses in the node map is the value of the
+ * maximum possible shift.
+ */
+static unsigned int __init extract_lsb_from_nodes(const struct node *nodes,
+                                                  nodeid_t numnodes,
+                                                  const nodeid_t *nodeids)
+{
+    unsigned int i, nodes_used = 0;
+    unsigned long bitfield = 0, memtop = 0;
+
+    for ( i = 0; i < numnodes; i++ )
+    {
+        unsigned long spdx = paddr_to_pdx(nodes[i].start);
+        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1) + 1;
+
+        if ( spdx >= epdx )
+            continue;
+
+        if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) )
+            bitfield |= spdx;
+
+        if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] )
+            nodes_used++;
+
+        if ( epdx > memtop )
+            memtop = epdx;
+    }
+
+    if ( nodes_used <= 1 )
+        i = min(PADDR_BITS, BITS_PER_LONG - 1);
+    else
+        i = find_first_bit(&bitfield, sizeof(unsigned long) * 8);
+
+    memnodemapsize = ((memtop - 1) >> i) + 1;
+
+    return i;
+}
+
+int __init compute_hash_shift(const struct node *nodes,
+                              unsigned int numnodes, const nodeid_t *nodeids)
+{
+    unsigned int shift = extract_lsb_from_nodes(nodes, numnodes, nodeids);
+
+    if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) )
+        memnodemap = _memnodemap;
+    else if ( allocate_cachealigned_memnodemap() )
+        return -1;
+
+    printk(KERN_DEBUG "NUMA: Using %u for the hash shift\n", shift);
+
+    if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 )
+    {
+        printk(KERN_INFO "Your memory is not aligned you need to "
+               "rebuild your hypervisor with a bigger NODEMAPSIZE "
+               "shift=%u\n", shift);
+        return -1;
+    }
+
+    return shift;
+}
+
+/* Initialize NODE_DATA given nodeid and start/end */
+void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
+{
+    unsigned long start_pfn = paddr_to_pfn(start);
+    unsigned long end_pfn = paddr_to_pfn(end);
+
+    NODE_DATA(nodeid)->node_start_pfn = start_pfn;
+    NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn;
+
+    node_set_online(nodeid);
+}
+
+void __init numa_init_array(void)
+{
+    unsigned int i;
+    nodeid_t rr;
+
+    /*
+     * There are unfortunately some poorly designed mainboards
+     * around that only connect memory to a single CPU. This
+     * breaks the 1:1 cpu->node mapping. To avoid this fill in
+     * the mapping for all possible CPUs, as the number of CPUs
+     * is not known yet. We round robin the existing nodes.
+     */
+    rr = first_node(node_online_map);
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_to_node[i] != NUMA_NO_NODE )
+            continue;
+        numa_set_node(i, rr);
+        rr = cycle_node(rr, node_online_map);
+    }
+}
+
+#ifdef CONFIG_NUMA_EMU
+static unsigned int __initdata numa_fake;
+
+/* Numa emulation */
+static int __init numa_emulation(unsigned long start_pfn,
+                                 unsigned long end_pfn)
+{
+    int ret;
+    unsigned int i;
+    struct node nodes[MAX_NUMNODES];
+    uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake;
+
+    /* Kludge needed for the hash function */
+    if ( hweight64(sz) > 1 )
+    {
+        uint64_t x = 1;
+
+        while ( (x << 1) < sz )
+            x <<= 1;
+        if ( x < sz / 2 )
+            printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n");
+        sz = x;
+    }
+
+    memset(&nodes, 0, sizeof(nodes));
+    for ( i = 0; i < numa_fake; i++ )
+    {
+        nodes[i].start = pfn_to_paddr(start_pfn) + i * sz;
+
+        if ( i == numa_fake - 1 )
+            sz = pfn_to_paddr(end_pfn) - nodes[i].start;
+
+        nodes[i].end = nodes[i].start + sz;
+        printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n",
+               i, nodes[i].start, nodes[i].end,
+               (nodes[i].end - nodes[i].start) >> 20);
+        node_set_online(i);
+    }
+
+    ret = compute_hash_shift(nodes, numa_fake, NULL);
+    if ( ret < 0 )
+    {
+        printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n");
+        return -1;
+    }
+    memnode_shift = ret;
+
+    for_each_online_node ( i )
+        setup_node_bootmem(i, nodes[i].start, nodes[i].end);
+
+    numa_init_array();
+
+    return 0;
+}
+#endif
+
+void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
+{
+    unsigned int i;
+    paddr_t start = pfn_to_paddr(start_pfn);
+    paddr_t end = pfn_to_paddr(end_pfn);
+
+#ifdef CONFIG_NUMA_EMU
+    if ( numa_fake && !numa_emulation(start_pfn, end_pfn) )
+        return;
+#endif
+
+#ifdef CONFIG_NUMA
+    if ( !numa_off && !numa_process_nodes(start, end) )
+        return;
+#endif
+
+    printk(KERN_INFO "%s\n",
+           numa_off ? "NUMA turned off" : "No NUMA configuration found");
+
+    printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n",
+           start, end);
+
+    /* Setup dummy node covering all memory */
+    memnode_shift = BITS_PER_LONG - 1;
+    memnodemap = _memnodemap;
+
+    /* Dummy node only uses 1 slot in reality */
+    memnodemap[0] = 0;
+    memnodemapsize = 1;
+
+    nodes_clear(node_online_map);
+    node_set_online(0);
+    for ( i = 0; i < nr_cpu_ids; i++ )
+        numa_set_node(i, 0);
+
+    cpumask_copy(&node_to_cpumask[0], cpumask_of(0));
+    setup_node_bootmem(0, start, end);
+}
+
+void numa_add_cpu(unsigned int cpu)
+{
+    cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
+}
+
+void numa_set_node(unsigned int cpu, nodeid_t node)
+{
+    cpu_to_node[cpu] = node;
+}
+
+/* [numa=off] */
+static int __init cf_check numa_setup(const char *opt)
+{
+    if ( !strncmp(opt, "off", 3) )
+        numa_off = true;
+    else if ( !strncmp(opt, "on", 2) )
+        numa_off = false;
+#ifdef CONFIG_NUMA_EMU
+    else if ( !strncmp(opt, "fake=", 5) )
+    {
+        numa_off = false;
+        numa_fake = simple_strtoul(opt + 5, NULL, 0);
+        if ( numa_fake >= MAX_NUMNODES )
+            numa_fake = MAX_NUMNODES;
+    }
+#endif
+    else
+        return arch_numa_setup(opt);
+
+    return 0;
+}
+custom_param("numa", numa_setup);
+
+static void cf_check dump_numa(unsigned char key)
+{
+    s_time_t now = NOW();
+    unsigned int i, j, n;
+    struct domain *d;
+
+    printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key,
+           now);
+
+    for_each_online_node ( i )
+    {
+        paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1);
+
+        printk("NODE%u start->%lu size->%lu free->%lu\n",
+               i, node_start_pfn(i), node_spanned_pages(i),
+               avail_node_heap_pages(i));
+        /* Sanity check phys_to_nid() */
+        if ( phys_to_nid(pa) != i )
+            printk("phys_to_nid(%"PRIpaddr") -> %u should be %u\n",
+                   pa, phys_to_nid(pa), i);
+    }
+
+    j = cpumask_first(&cpu_online_map);
+    n = 0;
+    for_each_online_cpu ( i )
+    {
+        if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] )
+        {
+            if ( n > 1 )
+                printk("CPU%u...%u -> NODE%u\n", j, j + n - 1, cpu_to_node[j]);
+            else
+                printk("CPU%u -> NODE%u\n", j, cpu_to_node[j]);
+            j = i;
+            n = 1;
+        }
+        else
+            ++n;
+    }
+    if ( n > 1 )
+        printk("CPU%u...%u -> NODE%u\n", j, j + n - 1, cpu_to_node[j]);
+    else
+        printk("CPU%u -> NODE%u\n", j, cpu_to_node[j]);
+
+    rcu_read_lock(&domlist_read_lock);
+
+    printk("Memory location of each domain:\n");
+    for_each_domain ( d )
+    {
+        const struct page_info *page;
+        unsigned int page_num_node[MAX_NUMNODES];
+        const struct vnuma_info *vnuma;
+
+        process_pending_softirqs();
+
+        printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d));
+
+        memset(page_num_node, 0, sizeof(unsigned int) * MAX_NUMNODES);
+
+        spin_lock(&d->page_alloc_lock);
+        page_list_for_each ( page, &d->page_list )
+        {
+            i = phys_to_nid(page_to_maddr(page));
+            page_num_node[i]++;
+        }
+        spin_unlock(&d->page_alloc_lock);
+
+        for_each_online_node ( i )
+            printk("    Node %u: %u\n", i, page_num_node[i]);
+
+        if ( !read_trylock(&d->vnuma_rwlock) )
+            continue;
+
+        if ( !d->vnuma )
+        {
+            read_unlock(&d->vnuma_rwlock);
+            continue;
+        }
+
+        vnuma = d->vnuma;
+        printk("     %u vnodes, %u vcpus, guest physical layout:\n",
+               vnuma->nr_vnodes, d->max_vcpus);
+        for ( i = 0; i < vnuma->nr_vnodes; i++ )
+        {
+            unsigned int start_cpu = ~0U;
+
+            if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE )
+                printk("       %3u: pnode ???,", i);
+            else
+                printk("       %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]);
+
+            printk(" vcpus ");
+
+            for ( j = 0; j < d->max_vcpus; j++ )
+            {
+                if ( !(j & 0x3f) )
+                    process_pending_softirqs();
+
+                if ( vnuma->vcpu_to_vnode[j] == i )
+                {
+                    if ( start_cpu == ~0U )
+                    {
+                        printk("%u", j);
+                        start_cpu = j;
+                    }
+                }
+                else if ( start_cpu != ~0U )
+                {
+                    if ( j - 1 != start_cpu )
+                        printk("-%u ", j - 1);
+                    else
+                        printk(" ");
+                    start_cpu = ~0U;
+                }
+            }
+
+            if ( start_cpu != ~0U  && start_cpu != j - 1 )
+                printk("-%u", j - 1);
+
+            printk("\n");
+
+            for ( j = 0; j < vnuma->nr_vmemranges; j++ )
+            {
+                if ( vnuma->vmemrange[j].nid == i )
+                    printk("           %016"PRIx64" - %016"PRIx64"\n",
+                           vnuma->vmemrange[j].start,
+                           vnuma->vmemrange[j].end);
+            }
+        }
+
+        read_unlock(&d->vnuma_rwlock);
+    }
+
+    rcu_read_unlock(&domlist_read_lock);
+}
+
+static int __init cf_check register_numa_trigger(void)
+{
+    register_keyhandler('u', dump_numa, "dump NUMA info", 1);
+    return 0;
+}
+__initcall(register_numa_trigger);
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 7aef1a88dc..5b3877344b 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -18,4 +18,70 @@
   (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \
    ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE)
 
+/* The following content can be used when NUMA feature is enabled */
+#ifdef CONFIG_NUMA
+
+extern nodeid_t      cpu_to_node[NR_CPUS];
+extern cpumask_t     node_to_cpumask[];
+
+#define cpu_to_node(cpu)        cpu_to_node[cpu]
+#define parent_node(node)       (node)
+#define node_to_cpumask(node)   node_to_cpumask[node]
+
+struct node {
+    paddr_t start, end;
+};
+
+extern int compute_hash_shift(const struct node *nodes,
+                              unsigned int numnodes, const nodeid_t *nodeids);
+
+#define VIRTUAL_BUG_ON(x)
+
+extern bool numa_off;
+
+extern void numa_add_cpu(unsigned int cpu);
+extern void numa_init_array(void);
+extern void numa_set_node(unsigned int cpu, nodeid_t node);
+extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
+extern int numa_process_nodes(paddr_t start, paddr_t end);
+
+extern int arch_numa_setup(const char *opt);
+extern bool arch_numa_disabled(void);
+extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
+
+static inline void clear_node_cpumask(unsigned int cpu)
+{
+    cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
+}
+
+/* Simple perfect hash to map pdx to node numbers */
+extern unsigned int memnode_shift;
+extern unsigned long memnodemapsize;
+extern uint8_t *memnodemap;
+
+struct node_data {
+    unsigned long node_start_pfn;
+    unsigned long node_spanned_pages;
+};
+
+extern struct node_data node_data[];
+
+static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
+{
+    nodeid_t nid;
+    VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
+    nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift];
+    VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]);
+    return nid;
+}
+
+#define NODE_DATA(nid)          (&node_data[nid])
+
+#define node_start_pfn(nid)     (NODE_DATA(nid)->node_start_pfn)
+#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages)
+#define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
+                                 NODE_DATA(nid)->node_spanned_pages)
+
+#endif
+
 #endif /* _XEN_NUMA_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:17:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:17:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419580.664388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGk-0005DK-Kp; Tue, 11 Oct 2022 11:17:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419580.664388; Tue, 11 Oct 2022 11:17:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGk-0005Bh-E9; Tue, 11 Oct 2022 11:17:54 +0000
Received: by outflank-mailman (input) for mailman id 419580;
 Tue, 11 Oct 2022 11:17:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDGj-0004mj-8o
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:17:53 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 587ea365-4956-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 13:17:52 +0200 (CEST)
Received: from AM6P193CA0065.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::42)
 by PAXPR08MB6479.eurprd08.prod.outlook.com (2603:10a6:102:157::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct
 2022 11:17:49 +0000
Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8e:cafe::83) by AM6P193CA0065.outlook.office365.com
 (2603:10a6:209:8e::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:49 +0000
Received: ("Tessian outbound 99ee3885c6d5:v128");
 Tue, 11 Oct 2022 11:17:48 +0000
Received: from bd4e7d53a030.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8B9874B2-2752-4B3F-BDFB-8DC215C06B7A.1; 
 Tue, 11 Oct 2022 11:17:42 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd4e7d53a030.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:41 +0000
Received: from AM6P194CA0034.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::47)
 by DB9PR08MB7510.eurprd08.prod.outlook.com (2603:10a6:10:301::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 11 Oct
 2022 11:17:38 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::4a) by AM6P194CA0034.outlook.office365.com
 (2603:10a6:209:90::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:38 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:38 +0000
Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:36 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com
 (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:35 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 587ea365-4956-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=kriEdOG+ocz57Bm3EsrWwvRu6Nt01latUYW5rC1oMkgB3kGRxP9WOhb/mE7fw8QPdQ/a0b9sjUY1fhyPXtRRB2VwYGt/cGEqDipzAScS6C9KM/5f74MxBgTC080AnQ21rs6dDF8SQtYo3J9ipEU9fsoBNkP8Nqh82ShODTOU06dYHJ15iZ3EPBB1Dp4FnUtcYrZvpjz2Cim37KP3YZq2sYo1+RNpC5MSAcwZVP7wQXD0oi09Bd1ekO5yHYRVxaWkDJc65/IenJBocEuXKahgipxRN510TNL1qj2dccsQsnsq14GikArc3sFFtE/kJLmoDZ4hjaXi0hOJdPuSUTxSoA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Yk9pOwOqX2MUuUQPvSNQCJe5TGtYxGC6yPWBHHiZQQ=;
 b=oEb6nNLMC05WVXGSxwPAKk8gfuG1+TTxI5mgrdFMdfrJx1PjszU9R+tE0dmjw4DvdzOhC0JpFfPVr8P4AeXhxITeewUNiMd6VW4BsUp8/ByYkzwtZTeeCPI2yPX2ajeZj3FRZTRVmSTzw8YO6NzLVlR2oTdRc3GbM4pmoWhxMeLbfpuB0LssdBqYRlIiI2l6x9tduKjfnhASKIPRRosv0rs5HcDAU82LRYOeajfIRfFSGy775QqT/lUZO1qr/0F9wkCSUDNMo7YCQGJKvtaARU/ur8QYKxOQL9ZpVTEROlviKweEMIsirYLiv2mdPejbGMcJvSl29rn3IYPM+p6Cfw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Yk9pOwOqX2MUuUQPvSNQCJe5TGtYxGC6yPWBHHiZQQ=;
 b=VtmmRESpBrxHW3xSIX76ADWh1xSV9Bb/ML7dGv1HbhSt4oWCl5LaVQSfNGR5VaTS7AKo5bNCD9BYuVwlYqqekeKTJUJIQjgIzvsvozpjfGBmLUf/3w8OSQrfiT7vKRzYZvDPkBw7ZZNSMqTLO4XVKEDf8ZEWzij3MPb1dm5g9kA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3c3a2ee416e47c6d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MZXTZXRv5BrCFJd5SQ3RwkIyBkjH7yQuK3V3bbdtsFOXQe7PYZDKV5/nwQ6abrhDF7UKjVkIJwZF9wXdap7oUXnFJawZOM8Z5vqOPZLLSLW6vB6WmyNouuEumJNeYQsWbVneTMvZqLNLqclui1qfJ4oUvy3eTIWjXGqsGV4rCFOI30TBN8yM65iL0SzNnBt7xsGLaYJxVSKcRuRtC+Sd5MhYpxodlrVfnGk5gpuXdnDtxPa0Bp2NgFH7ANJS9jcz+Y3dA7OGnVloRAuLvfjub5MPdA0macfT7ur1NKRmwENJYh+PB1avtp35RtTmcnhhE/CgGdbftC9bc419D/AwFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Yk9pOwOqX2MUuUQPvSNQCJe5TGtYxGC6yPWBHHiZQQ=;
 b=HABZqJHTowppUIVZzxktdqnV1OJwgXW5J8emMRdMEhYylA4i/6QLlJhd0b7j45DnCEwqh/Ze/kpqAP2XL+S4l3gdInlnCuSTftqldzCtjMY+7N778xOwKnf6DPJvSgBY2V2kgE0BXmF7r16dGTODhjm6+v/BEOHP53MtIMZN6JdNFrK4CA2LBZUAWIUkUQZkFDNcR0lE+ENKt+PI3abjX5V+cg9/+4zf+Fq2kL+JKtZmRqeymTosEmQHV+VRhjVAt5E09xDndzTEg6EEpO89exQKU40FHPSboW1tQoWCY3qFLHjO15eKumgFvmP/qXeRew7dYpaA11FEPCMtzI4IHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Yk9pOwOqX2MUuUQPvSNQCJe5TGtYxGC6yPWBHHiZQQ=;
 b=VtmmRESpBrxHW3xSIX76ADWh1xSV9Bb/ML7dGv1HbhSt4oWCl5LaVQSfNGR5VaTS7AKo5bNCD9BYuVwlYqqekeKTJUJIQjgIzvsvozpjfGBmLUf/3w8OSQrfiT7vKRzYZvDPkBw7ZZNSMqTLO4XVKEDf8ZEWzij3MPb1dm5g9kA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Jiamei Xie
	<jiamei.xie@arm.com>
Subject: [PATCH v6 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid
Date: Tue, 11 Oct 2022 19:17:05 +0800
Message-ID: <20221011111708.1272985-4-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221011111708.1272985-1-wei.chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VE1EUR03FT044:EE_|DB9PR08MB7510:EE_|VE1EUR03FT021:EE_|PAXPR08MB6479:EE_
X-MS-Office365-Filtering-Correlation-Id: c11e0636-0cbd-4a27-4b24-08daab7a3b12
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FNi4pqAm3Jq5owMO6uF0vaU6qN4UKzR5r9yqNXIL+JUu2Z0bhsjMQuyT+1rVNCPVLOV/hcrXmW/OFxQvwF7Xjushhs68teiZ63rctvwjRkL2KIQx5zOvq5aSLOIT1PfHd9f0zaL2j1XavUPp4i1I9f/ENde54CQIgARzYA8CQpcGJzlscMEOdXPdX5xkQGrUApCO9Xvez0Dr+l4Q0lIpRJ808DNbJEyhkfLlYYIGmWmPgFP/jxxVFS5XVWdg7CmXvyyGYBGRMNPBsrtQCDdVYaIJn/ae/29z3ZEwi1gzrRlJD5TZYyuHOeOHa7TBd8+hqWhwR/cLD1eXkVoX6voU3rqqcJOuZvE1dcOrkMcT55ZUE35/HTpQV1pQpy5GWFzbfodfyxIXQ6nfd81Cr9NELes6AYtkqlu8O7+bRVBDQ6q+IZ53MipYjEFuBMRYPZHUDQTMIED8yRXDbCF2OUyiTvElf3qa2KV7QKum3QxxZoOYbvOBQCCTDwP+wb8FIQxvoCK19YDnBd+7L9Gr12Kw6yHUE3ec3oI7lT2axSPsYPQZMrzkiwlq38C2bgzYbhpkqytMnHWakapdNXGwxY/I4F/k2xdRebmX/k/ORoCQvpYg/hwxKgz8fS4ln15FKbUrEmzsa1cCIiT9qhs+la3Jv7mHBLVGTi2YZWxZWFW0Ws/J43o0woxFuUh8Q3qXJiCXINPSOsiPAKWixsY6e1rgFVJRBdEhLWzeeKEbG2hI53fOBM0LYHP/i6oMismq34ZEkHNDij8y0eyKl/WvlB6mX87O5LNRi3Y8mL8Wi7fHI15Id9GFyPy9eDzHDeqzDzk1
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199015)(36840700001)(46966006)(40470700004)(86362001)(82740400003)(44832011)(356005)(336012)(8676002)(70586007)(47076005)(36756003)(81166007)(316002)(1076003)(26005)(6916009)(40460700003)(2906002)(186003)(70206006)(2616005)(36860700001)(5660300002)(54906003)(41300700001)(6666004)(40480700001)(426003)(7696005)(478600001)(8936002)(83380400001)(82310400005)(4326008)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7510
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	61a4010e-bebd-47e6-fb72-08daab7a34a1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QGtb/90oul/CjLtKfAr00mJkmAouyqrgLNDUMcVecvsPjbGj5YkR4I0KeN3jSWzFnlVT3k7eGxDvxbMJxKIVW36eqCzV3ddshCHk9e0oHfj7I/9Tpzm04D+km11toudROEJpI1q5UbzOF92gvaF+/OYEUuNN1yYERf0+1qRLlSpeXoK0yxCWQ2sVM0f/SOUd1hM211L0fBCpqubVpLetjsLwUKkqoepqmk26lB43Ccl9dm56M4zrLb9q2wHZ+WkVMqpTPw6o0raqpdVyzD9qgtm76Bls1xAf3fXBZQT4o4D/qxB83v8ibr0kn6jSWUGGNVpMNmJjq/qNrmRNYsizsG/gG9jUun7v95bYRBFlvFzpjaL2/3XGrqHl/J8fY5EUHdrGTsI7h4CyjSoWs1W48pIUF5s2eTm+yu4VsJMc1jTFMWM3hNrf6cnr3oyeDsY3s9H7ZLwLDFgqUv6tgh6HjSCU+05hF5MX4pQMtO7HIGUWoETyPMY3HifE5mAPM92vEcHL63IOLOQ9YHTmvOlADT0gRGFoAemG+vIfYU/Ih6Dxf7rVMv5IRVtkdn8LfrZRe+3qi1qmaiVABLqHTVC2/aLG7uPMs1bvQwlaNh6+rNg9uZpFeJdyUWC0IJwr6mxvFxivnDiNEmWytlpPqQeJ18v7T/yIdpAikp7lMhPwbM8glU16cdIFBvd5MbbFKgTuiuIhazuoTOVAr1a/NQ50+fNRU2J/kHDhdUPQ7SRMlg2hU25z8hJDg5UglyCXVqmYn26wMod3uK8y+zrIgvhAnw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(36756003)(86362001)(83380400001)(36860700001)(5660300002)(82740400003)(426003)(47076005)(336012)(2616005)(186003)(1076003)(81166007)(7696005)(6666004)(26005)(478600001)(54906003)(6916009)(8676002)(316002)(70586007)(70206006)(8936002)(82310400005)(44832011)(2906002)(41300700001)(4326008)(40460700003)(40480700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:17:49.0667
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c11e0636-0cbd-4a27-4b24-08daab7a3b12
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6479

VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
results in two lines of error-checking code in phys_to_nid
that is not actually working and causing two compilation
errors:
1. error: "MAX_NUMNODES" undeclared (first use in this function).
   This is because in the common header file, "MAX_NUMNODES" is
   defined after the common header file includes the ARCH header
   file, where phys_to_nid has attempted to use "MAX_NUMNODES".
   This error was resolved after we moved the phys_to_nid from
   x86 ARCH header file to common header file.
2. error: wrong type argument to unary exclamation mark.
   This is because, the error-checking code contains !node_data[nid].
   But node_data is a data structure variable, it's not a pointer.

So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
enable the two lines of error-checking code. And fix the left
compilation errors by replacing !node_data[nid] to
!node_data[nid].node_spanned_pages. Although NUMA allows one node
can only have CPUs but without any memory. And node with 0 bytes
of memory might have an entry in memnodemap[] theoretically. But
that doesn't mean phys_to_nid can find any valid address from a
node with 0 bytes memory.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Tested-by: Jiamei Xie <jiamei.xie@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v5 -> v6:
1. No Change.
v4 -> v5:
1. No change.
v3 -> v4:
1. No change.
v2 -> v3:
1. Remove unnecessary change items in history.
2. Add Acked-by.
v1 -> v2:
1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
2. Adjust the conditional express for ASSERT.
3. Refine the justification of using !node_data[nid].node_spanned_pages.
---
 xen/include/xen/numa.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 5b3877344b..04556f3a6f 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -35,8 +35,6 @@ struct node {
 extern int compute_hash_shift(const struct node *nodes,
                               unsigned int numnodes, const nodeid_t *nodeids);
 
-#define VIRTUAL_BUG_ON(x)
-
 extern bool numa_off;
 
 extern void numa_add_cpu(unsigned int cpu);
@@ -69,9 +67,9 @@ extern struct node_data node_data[];
 static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
 {
     nodeid_t nid;
-    VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
+    ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize);
     nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift];
-    VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]);
+    ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages);
     return nid;
 }
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:17:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:17:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419581.664403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGm-0005f0-Rf; Tue, 11 Oct 2022 11:17:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419581.664403; Tue, 11 Oct 2022 11:17:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGm-0005er-OZ; Tue, 11 Oct 2022 11:17:56 +0000
Received: by outflank-mailman (input) for mailman id 419581;
 Tue, 11 Oct 2022 11:17:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDGl-0005JI-9X
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:17:55 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5998eeba-4956-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 13:17:54 +0200 (CEST)
Received: from AM6PR10CA0006.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::19)
 by AS8PR08MB8135.eurprd08.prod.outlook.com (2603:10a6:20b:560::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:52 +0000
Received: from VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:89:cafe::1f) by AM6PR10CA0006.outlook.office365.com
 (2603:10a6:209:89::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT060.mail.protection.outlook.com (10.152.19.187) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:51 +0000
Received: ("Tessian outbound c2c2da38ad67:v128");
 Tue, 11 Oct 2022 11:17:51 +0000
Received: from d152a0e8dd55.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2F4013E8-57F7-4C57-A676-F8F9298A5C85.1; 
 Tue, 11 Oct 2022 11:17:44 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d152a0e8dd55.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:44 +0000
Received: from AS8P189CA0002.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::21)
 by GV2PR08MB9423.eurprd08.prod.outlook.com (2603:10a6:150:dd::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 11 Oct
 2022 11:17:42 +0000
Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:31f:cafe::c0) by AS8P189CA0002.outlook.office365.com
 (2603:10a6:20b:31f::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:42 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:41 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:39 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5998eeba-4956-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=GhSS5lDHhdDXM7DG+/VSMazfSzMFJltIrlB7XAynjkQswYHd4ksEmsPo9WRsBAZSxQFUKH1v/6HAKWFsKhJSWTAEaV3pCWqy8EW5ylw1ySXcADp09o5DoQLZGwb9LaZMeTLumoEXnXxteQgdIEd2aGtUjLDX2BTGcl3sQFyAbuOy+z1LFbHcwVbZ0RR2J4TJFaghGnvTjhCvZZrW8/+q4DrkfoK733fqq6B5/uEaK6zzQDkkXaQLyZj3RpWr7BIfep3OvI7thkL0kR8BobFYDi+a3H/y7dAfR02pl8Xtnui8ys+B47LXABF6s1ScuKGL4b6YccO47nxlOyZmAwmZqA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8XBiCXCtEfLqbQyP7SqA0jieOjNJeHMOSZh9sQ5Tpuo=;
 b=MQmWw3RUUPzE+uAfvT3ZmWxPeRPlnwrcjnF8rhkTMNcfEVqvnvL+avqxwXOwdd2l+74XZqGDL7VoDsXSJtdVl8IQPDKDCFTjdlcQ+j38c8ksaKKsAEQ+9cjiQnEnW6DPOSGJi87ZtiSvRl1XFsXmcCUXHlWKMkdauDhqMh97yLkzrV08bO2w2+T4ut48Sk/oB5CC3hSsSnhxqBcqlsLZosYN2vZUd+q5QVFfQXymLmbHL+DUSvk+DzvUlWiEKD2pIESb8X/33puq0oZQpSYu+OQD7bV2Hg/YiHzCQ/ftotaH2a/5BiaM+JgMVShQo3mf59XBKwx4giCpEsWwYR6PHA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8XBiCXCtEfLqbQyP7SqA0jieOjNJeHMOSZh9sQ5Tpuo=;
 b=4FmyHll2jSn9fjneyzvV4xolXxgfMExxkArW030z7KQcpxuP3XmmJWkEarmcVQuDZ1pwf64Z6yq5PW+XnYD23hW+AkEnE0Nsug+U99f+fefqmSHY6MWMgfFsXXkJsxq+/5E65UlKfDZZsIlN8acne89YKdKEK59NQJG2uqhtSu4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8e01e321f1b19aa4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QIiMjHAic+mbjwL8pZuVzIbLhytSPnzScRBszNZ19nNj+E5Rj/ywJTiaIl6EdVGq91J+4ti78Z6NWoHwgweUwyibFv6irn+iiWjPtQnPykfyOeikbowpFORryAtX148WIl0r2x3YBxV4Axyjh5ZnlVt61/4DhiLdQSaC80GlnQ5tvtm2svU8BFDUPLJLJm5VMhA9CgUy69rTQssI7grluK2uXOSbgkcxtv/otg+OHm5G+CTTKNJ3IDb9dI7HL7rNnLPsvt88CoSfW3RsJuiXBoHUkeloIKSanIDoZd2QznK/xLxYTwMJfCAgKqbqinrj4E9M5xvykdW8f35dK2gRKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8XBiCXCtEfLqbQyP7SqA0jieOjNJeHMOSZh9sQ5Tpuo=;
 b=e3jOmNdW4KjqxdRH6GJpouchLXO8J3IormgSl51/IiWp7FZm/vWpG2gLpOpDtiRS8LG4Jdsj6xKzyW0pXz966hNH5alOG3RMvdvmCGXmfbsphGC0kEVJ0Dz+9ww06xQSedNss/it70mngjyhzpQIlxWKorEZFOsBEhCDpMdbw/AuMokE+b/TgY70TS9OKwldg+g2O1fFsq5oW34v7B0aPyCQFl8BmM+lTHc3ymPksnnMSJ0mlYvtkvjPG6gVHqcvvKmIW5vHaStVDlLH6XAZrVSX35hpO7ETBJzCRTWJx1x/hQWssTOrYHthkkOzm+jkVjIzpXEA3s5Xbiip0eRHRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8XBiCXCtEfLqbQyP7SqA0jieOjNJeHMOSZh9sQ5Tpuo=;
 b=4FmyHll2jSn9fjneyzvV4xolXxgfMExxkArW030z7KQcpxuP3XmmJWkEarmcVQuDZ1pwf64Z6yq5PW+XnYD23hW+AkEnE0Nsug+U99f+fefqmSHY6MWMgfFsXXkJsxq+/5E65UlKfDZZsIlN8acne89YKdKEK59NQJG2uqhtSu4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v6 4/6] xen/x86: use arch_get_ram_range to get information from E820 map
Date: Tue, 11 Oct 2022 19:17:06 +0800
Message-ID: <20221011111708.1272985-5-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221011111708.1272985-1-wei.chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VE1EUR03FT026:EE_|GV2PR08MB9423:EE_|VE1EUR03FT060:EE_|AS8PR08MB8135:EE_
X-MS-Office365-Filtering-Correlation-Id: 5d7c771b-ac8f-44b9-51ac-08daab7a3c96
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 zpH6AGOs/6ddNjWEremKs5Syk0BWtaHP4/KjrnSpzRXnVjQuXGNMxeOoFLU2EgJ35pT13ppq0GbW7FmkquKTHvJNNR+Sw3IQZTmTx4jJxf00DtBK655vfFdjH0DkDOkmhtYLACkH+AObSxt8ztmPTH9nuNY7WR1bmJucQeBiTIkbHKJjxXT+tyaZBlzh4omLjY3UXyT4hp1UDp74OBmK1MGgb2qZuRnInsdAgX8kc0vDnw4OJvPFVZPHQjGxGTBhSZkPET3WGb/nQ0KKWs448PqHdnK9p215nP/06ZyTsUJcE+avEhYs+LdzxHEq/6UQ1K4xNEAnqnNMkmT+nSq4YAyKKyIWIs79NQ/G6TYd9y30X0VJrmJfYZoqoaQ13FEGxibnCHlBIUFDkhzUVKGEPGKSplwJOXj/Dl2l2IE2ivZdeU6WGwlTulZ0GyUxkhQvFBypv7GCzUi5p1EUedYtabn2T+VoHUZoxcUwPcsF2BSPB/2ZtYz3BdYvwnm/+ESUpjaVLOq+GEpK1zYl7Uzx83HGMFqJ0tFeq0KUYXA8D+gcwXHbQgrUwXmajyla2PY4ssaAD1Hk41v3U2sWQ+AV+scdTVTZehXVTljX9W0N5MC1dSwrLuJpqQysSMoTZT7JRpFF7mC1zn8ciXmFdAPkZQzlxgqwZFx252GoPanq1J9FZG60gi/CpWA8pvY+kz07csFHACyJdo7+hp1EB63tGK1YAsBwheci2y9xqAjXzJBCtkC2xjKSSdF5cYs4jtSDc45YbOe/xNMvjrHI/6S3tqaq1YUUBiwNNKl+JKO6glB2wOQlssk/mrSri5eaNEMY
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(8936002)(5660300002)(316002)(336012)(44832011)(2906002)(41300700001)(8676002)(4326008)(70206006)(356005)(86362001)(40460700003)(82740400003)(81166007)(2616005)(478600001)(186003)(70586007)(7696005)(1076003)(6666004)(26005)(426003)(47076005)(36756003)(36860700001)(40480700001)(54906003)(6916009)(83380400001)(82310400005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9423
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e765b3d5-b519-4d96-87d4-08daab7a3698
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bjC7W6qcW0UayCWBXtlTUAwFsd/QvLS2baxkLS/ElnyC01U9eV2detlS7THDxYd6oCLxl8/8+hGZqSHXaqmrg8q/swiYfQfMgtBl2J3gJdaZ9U1T9akcxfB0GUVefDqpcx1A34rBaFSsNSkbA+DJrWH92VCRHDChKs2kVn7zRZZXrbmryTKLS4z31WxkaWbIco2p+oX1w6X3EgG4drrQI5iONeE7wnyLXfQAjoWCHA23TcTWZfDGQqmLuG0jzJ2iWFoekriiJOLn8HGuLmFHv/pDrK4yLoiY/Aycs0qjBnhhOU3SgUC1kuYn7rpcinuUp1fKJcmf9EOdmLFs2IwdKT+EjhNLNUc80gkvEJcK6whVLO2BY6cCvODATdIX7K1rmnCNghEJIORRtXNLCIbo3rAfGLyLBbXBD7Xa/fjFlrWhW9+pBSgyHcw0ZM6i9/oQbcuN9HKCJLVB1J9SpfDil7i4Nu7AX13liVPpOZKyD/xUAk9bgkY5hrx33zs7yRqQIS5MTPwbp0YtfIwvs5gP/jP2OzLMH2jjS0nbVs4FTQk4X/JpiP0Yf4ubH5Ti1cmEIUUQhAaGz14JiLGfWzw522Vc8Ll2ZSrj0KTzn8Bv237Iq619+xt5XGTRmc5/QdqrDN0Eep39NjpzD1c+HF5N54uvku7X9pS9iQSN145yTNN+38YV8Aj9HeYhUI0WCgnYhLag2thRDQCz33Cf4w1wibRVbVtusoMHtlyrTiwaeoOSG2KEFPZlXMXctBirTvQduR583KAKEvcelQRkATFL1A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(7696005)(26005)(82740400003)(70206006)(40480700001)(316002)(8676002)(86362001)(4326008)(70586007)(36860700001)(81166007)(40460700003)(36756003)(83380400001)(186003)(1076003)(6666004)(82310400005)(478600001)(2616005)(6916009)(2906002)(54906003)(47076005)(336012)(426003)(5660300002)(8936002)(107886003)(44832011)(41300700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:17:51.5784
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d7c771b-ac8f-44b9-51ac-08daab7a3c96
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8135

The sanity check of nodes_cover_memory is also a requirement of
other architectures that support NUMA. But now, the code of
nodes_cover_memory is tied to the x86 E820. In this case, we
introduce arch_get_ram_range to decouple architecture specific
memory map from this function. This means, other architectures
like Arm can also use it to check its node and memory coverage
from bootmem info.

Depends arch_get_ram_range, we make nodes_cover_memory become
architecture independent. We also use neutral words to replace
SRAT and E820 in the print message of this function. This will
to make the massage seems more common.

As arch_get_ram_range use unsigned int for index, we also adjust
the index in nodes_cover_memory from int to unsigned int.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
v5 -> v6:
1. No Change.
v4 -> v5:
1. Add Rb.
2. Adjust the code comments.
v3 -> v4:
1. Move function comment to header file.
2. Use bool for found, and add a new "err" for the return
   value of arch_get_ram_range.
3. Use -ENODATA instead of -EINVAL for non-RAM type ranges.
v2 -> v3:
1. Rename arch_get_memory_map to arch_get_ram_range.
2. Use -ENOENT instead of -ENODEV to indicate end of memory map.
3. Add description to code comment that arch_get_ram_range returns
   RAM range in [start, end) format.
v1 -> v2:
1. Use arch_get_memory_map to replace arch_get_memory_bank_range
   and arch_get_memory_bank_number.
2. Remove the !start || !end check, because caller guarantee
   these two pointers will not be NULL.
---
 xen/arch/x86/numa.c    | 15 +++++++++++++++
 xen/arch/x86/srat.c    | 30 ++++++++++++++++++------------
 xen/include/xen/numa.h | 13 +++++++++++++
 3 files changed, 46 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 90b2a22591..fa8caaa084 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -9,6 +9,7 @@
 #include <xen/nodemask.h>
 #include <xen/numa.h>
 #include <asm/acpi.h>
+#include <asm/e820.h>
 
 #ifndef Dprintk
 #define Dprintk(x...)
@@ -93,3 +94,17 @@ unsigned int __init arch_get_dma_bitsize(void)
                  flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1)
                  + PAGE_SHIFT, 32);
 }
+
+int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end)
+{
+    if ( idx >= e820.nr_map )
+        return -ENOENT;
+
+    if ( e820.map[idx].type != E820_RAM )
+        return -ENODATA;
+
+    *start = e820.map[idx].addr;
+    *end = *start + e820.map[idx].size;
+
+    return 0;
+}
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index ce507dac9e..1a108a34c6 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -452,37 +452,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
    Make sure the PXMs cover all memory. */
 static int __init nodes_cover_memory(void)
 {
-	int i;
+	unsigned int i;
 
-	for (i = 0; i < e820.nr_map; i++) {
-		int j, found;
+	for (i = 0; ; i++) {
+		int err;
+		unsigned int j;
+		bool found;
 		paddr_t start, end;
 
-		if (e820.map[i].type != E820_RAM) {
-			continue;
-		}
+		/* Try to loop memory map from index 0 to end to get RAM ranges. */
+		err = arch_get_ram_range(i, &start, &end);
 
-		start = e820.map[i].addr;
-		end = e820.map[i].addr + e820.map[i].size;
+		/* Reached the end of the memory map? */
+		if (err == -ENOENT)
+			break;
+
+		/* Skip non-RAM entries. */
+		if (err)
+			continue;
 
 		do {
-			found = 0;
+			found = false;
 			for_each_node_mask(j, memory_nodes_parsed)
 				if (start < nodes[j].end
 				    && end > nodes[j].start) {
 					if (start >= nodes[j].start) {
 						start = nodes[j].end;
-						found = 1;
+						found = true;
 					}
 					if (end <= nodes[j].end) {
 						end = nodes[j].start;
-						found = 1;
+						found = true;
 					}
 				}
 		} while (found && start < end);
 
 		if (start < end) {
-			printk(KERN_ERR "SRAT: No PXM for e820 range: "
+			printk(KERN_ERR "NUMA: No NODE for RAM range: "
 				"[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1);
 			return 0;
 		}
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 04556f3a6f..9da0e7d555 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -80,6 +80,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
 #define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
                                  NODE_DATA(nid)->node_spanned_pages)
 
+/*
+ * This function provides the ability for caller to get one RAM entry
+ * from architectural memory map by index.
+ *
+ * This function will return zero if it can return a proper RAM entry.
+ * Otherwise it will return -ENOENT for out of scope index, or other
+ * error codes, e.g. return -ENODATA for non-RAM type memory entry.
+ *
+ * Note: the range is exclusive at the end, e.g. [*start, *end).
+ */
+extern int arch_get_ram_range(unsigned int idx,
+                              paddr_t *start, paddr_t *end);
+
 #endif
 
 #endif /* _XEN_NUMA_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:18:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:18:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419583.664413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGt-0006B2-AA; Tue, 11 Oct 2022 11:18:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419583.664413; Tue, 11 Oct 2022 11:18:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGt-0006Av-6g; Tue, 11 Oct 2022 11:18:03 +0000
Received: by outflank-mailman (input) for mailman id 419583;
 Tue, 11 Oct 2022 11:18:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDGq-0004mj-Ux
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:18:01 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2083.outbound.protection.outlook.com [40.107.105.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c8438cd-4956-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 13:17:58 +0200 (CEST)
Received: from DB3PR08CA0029.eurprd08.prod.outlook.com (2603:10a6:8::42) by
 AS8PR08MB9018.eurprd08.prod.outlook.com (2603:10a6:20b:5b0::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:56 +0000
Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:8:0:cafe::4a) by DB3PR08CA0029.outlook.office365.com
 (2603:10a6:8::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:56 +0000
Received: ("Tessian outbound c2c2da38ad67:v128");
 Tue, 11 Oct 2022 11:17:56 +0000
Received: from 8b4df52797c0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0F0B5C61-17F5-4120-8925-1621E946FF22.1; 
 Tue, 11 Oct 2022 11:17:50 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b4df52797c0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:50 +0000
Received: from AM6P192CA0079.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::20)
 by DU0PR08MB9321.eurprd08.prod.outlook.com (2603:10a6:10:41c::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct
 2022 11:17:44 +0000
Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::f3) by AM6P192CA0079.outlook.office365.com
 (2603:10a6:209:8d::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:44 +0000
Received: from nebula.arm.com (40.67.248.234) by
 AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:44 +0000
Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:43 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com
 (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:42 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c8438cd-4956-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Ggek+HHavReWjBPeM6fag+YG9Os54Lcb7xbGY9LGt2QEJof6WExEV89Zo/bFtT67V4ZdJ4r6j4WVEdYM+laSDjxMrfORNR5Vs2rY4XzUo9D2XloE1cdqDE1DyRjvWrTM+HbmZR1L+ehDkoEMjZ/jmyErRmJ2LBDdVqN6IU8J4wxc2Djfk9TE74K6kCVkBBzDXWtfX8eyiaZJ1x8bK02FdYcp62aqHJhYOUyp6DimkrRSaTc8XlZSdPzDYAe/AI1e3GVVYTr2UKTFlsMk5Vd9r+xsRo1GuBp3/LGJXYEQUPSLMnD+cfh51CAM7KdkNURP3EFhPbjzCV48/sbVNXpJnw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lmtPbi5pcFtu3YOaa9pP8XWKV7pTj13eU1mWM3baRXs=;
 b=gPV410L3xH1UlJkSmSAR4sRw1qAI0Ov4j7oInO67BAEZc/FBxbJri5QXoBD7mQ3RtaEIOP+nJ/Df4WGSAynBBuTdZfe4F886H+SFYXXf6zA73fvhefW1hBia8xgXG4sw/HT0XR7wQ3QdOmz1ZW4pue0ROn80iB7Dm54Qs880E+YeQTL88kMcY+28RkRe46GLpU290d0TlDHF9epICszq+hy/prfhPoKs9emaAzbq92/Qj9SpgclcmDFSSbtrZERfMvQQqOLuC8M8LyH5sl7VaH0lGPeX7aLnmfy/h7730rVB6tV8F2swF1f6m/I1oy3osnUzAk3VbvBlthPqWhka3A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lmtPbi5pcFtu3YOaa9pP8XWKV7pTj13eU1mWM3baRXs=;
 b=Pq9/cFyTIOJo8EAeT8qfmJPlRszavRgX19HGLfFcPFFQj2jjCqLb4lbLEm8xvsuhsY5QA2d8Eat6L6QzichBBIxyrJEJknK2BWne2a/Nbpj833ZxgT69bROT2yIliNfmMtykblQniGKNsH8yEXSak5XPPtg0J46k5w+WZMTyLUs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4d35e5234c3abdb1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EGYJOO3N60YmKJW+dwFMEoR5+/M6U/N2zTHJfyXIkVbMGZ9Agz7BNVc7oNmM1TJAQKdi6+RiLie9hkR1IRB7oafY1doGAnB2KfN+bwNerYuGYdayU6Ix9Vz2AbqOo8cjrz0Uly4vNTOyyz6OBLERDTYE8RvnzvuK4uY8izBAG0ttH4X6VV3WgQGGrMe7nGKaDk09fs2RHfGB3joJVbFbrAdgFBYUuz7ch/DtINm4ihW/FGDJFJrdpzUyDSX2VqCPx5RtUt2zU8bygMns4JFcX3yUUxtL3g1hIffliekDUmF7Of0OwejWG3cnQUP+d3ON7w9TVB3fFcB6F4ABkPhV5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lmtPbi5pcFtu3YOaa9pP8XWKV7pTj13eU1mWM3baRXs=;
 b=nmAb3y+c8qfBsyW1Qt3IyoCSpAyFl1vZM9hQ9PbeTvVD1bftN6IMTwnPKfZ8i6/I1Zk0xug8S75lmmZ+X/UxFVkKUWoL0ZNXu/5ZhNSfsSf+zNnZe1jRpgW3A/uYXm+CeJShN2+BImLL9krtQ2I+llRcHdaiX1XyxXDZ4TniSq/+miFW0pGJRvNDDjeNwuRJr7EDZZX+ov4GkScxidXNpr7Vc+YAHSbv2eM9i8YsN/wNqgTMriT2mgX4BUxC4ubvQt9g43w3kkXO6R+0DQSqo3gPDO/RZvkgOLrXuO0z1mYdNUsgTsHyoXyn0I238CFGkhMjdXqEqNTvYsu9U8AiBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lmtPbi5pcFtu3YOaa9pP8XWKV7pTj13eU1mWM3baRXs=;
 b=Pq9/cFyTIOJo8EAeT8qfmJPlRszavRgX19HGLfFcPFFQj2jjCqLb4lbLEm8xvsuhsY5QA2d8Eat6L6QzichBBIxyrJEJknK2BWne2a/Nbpj833ZxgT69bROT2yIliNfmMtykblQniGKNsH8yEXSak5XPPtg0J46k5w+WZMTyLUs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v6 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common
Date: Tue, 11 Oct 2022 19:17:07 +0800
Message-ID: <20221011111708.1272985-6-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221011111708.1272985-1-wei.chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	AM7EUR03FT025:EE_|DU0PR08MB9321:EE_|DBAEUR03FT017:EE_|AS8PR08MB9018:EE_
X-MS-Office365-Filtering-Correlation-Id: bd57cbb5-ca29-48fd-507e-08daab7a3f68
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GN9oUQFBvcydSuD1TbEowWZLbg/qLuRcsHK/rKMmDz0ie55I8d9hmviXvuIV/ZSDaOljlitUEsFMHTcaXWokbZl/vFN97iqtZfS049CtTGFSDWo+Jw1KXqaQ7cyy4fIuVbpETk41dvRWHOB40qGyJNZiFaUs7KOIfqUkd82rKATQN23LpKx2+MQh15/8MKaz2l0/dpd0lXFZ3u3O6WRfmU/G/CZvOmeebilEc6sxLlkkMaJIDATQPaiUYdL4bGNtMILQ+fUzqFcDVQ/HlOKcgxqSWvziZYRkOu+arZKXE6NDi+yQCtEecFGC1WcSU5mDDmjSDAjfaTw/nsqqHVRCzl013RfHwVcE66KMkQKUt7JhxU4Ara5/hlq1GHc39viPcUs8yJmS7o6eEkvKOFtonWDvuq35+o3CG1IVjzwencl++CbyW0BoI3OZKAaiKbc9z43z5k3zAYRH7swLy2mIlz8lwayOUizKC6Xm3Zxw0Ch9Dd+JxG/o0FHJYPkdebNcp6TTNdrrXuTZ7TTynzR43t95Qm8RtlsIKPUIKmKzHkwrcMWFsy4NEbHEksxpKnCvNPQLt3LHxJNH4R6D2EgJCBEWphmHE3QOifID9jCxrAeSz+bApduhhDGtjAXV7VdarGM4xZ+qqeBmVCBAQ0UScmlTbMZjFmRsyD1u2En5JHTnFAzhckSj6zhELblemzk250vX9NH3okFJJK+fwVJqC9iNXhL+IxfRCYh1SXZdEJJZik1zTet/BgvAXJ3jSmU+6peZyXwGDzplbEQJWa9ZIY+r6y5RkVEnGYGCIEqRKEIHmC34gYf7dNNQKTFEEKeT
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(82740400003)(36756003)(86362001)(81166007)(40460700003)(40480700001)(6916009)(356005)(316002)(54906003)(8676002)(8936002)(2906002)(5660300002)(30864003)(44832011)(4326008)(70586007)(70206006)(41300700001)(82310400005)(336012)(47076005)(83380400001)(426003)(7696005)(6666004)(478600001)(2616005)(186003)(1076003)(26005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9321
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b7338732-8c64-42a8-3a4c-08daab7a3809
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KEM8JyU6mtXlvMjgYNrNcFNW0k26mRuaN6S1upAT/yrNUH0vwvcJhmj6j/nfTawkxW1mLYGQTf8MS2mbijxz1fY6N/zwbHbhtoc/0jvXo2UdeJ6u3OaFdI/b/1p0vc5/xOwLVP73JALjBraYUdluPkq2dMHdkXXdSUqRvQspNiFaWJoNeqvyMjT7TN0zvjWJ1YuxxnqaViFrEAQmbZLlFOKR7hWO0Raw09sCG3x+disGh5pCoVSoGvrqXQwTpjCm/oRZFq0YUCQEDDd1fkeS1ctGynGZ3SqrLJciyS+JF4+xZoI/wZCK8Wk3SqLxrBPgE5I66MdctDeyFVkju/Plu5EIrVtN+T5IdinUMJP8mnWTNCi3aLyBOlYz7eAnmgriUQ1oaM2Qf+D3d2bnoKa2g5vw9g2jTluK/94q31Iefzqwn+pvAGMfYt/3eUdyBBCoinohGPg2C1P2M77dEj4ntoDzO9/hczH7FfBgUzmEBCIUe5HcX6mU8cK12T2XS13pMdw6ZTGzvJ6IgMbSnzA5S3mVqEV9b1gAJvqz1WoZ9FuEPp3twJs0l4hNWAfTuWKuSEEca273QppECWVX0RFHDUy6OQbmO9ikGbkz10IrF1aRM4m+R7Qnj3PtZphy0UKYRZkwdEOztOI5NRFr4ipmdhAyoiI6l+rX7JOYnHHCGXg213hyKUC7Vl9lI+EKbvZ/NhqQB20vmMtsdFrGK8KA6tfTg/yJo/6Qxw9QNGjK7LDyXRcaYFU9DGe4DyPDTyH/Y4pi7q0k/3cOl9wtBgU27w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(46966006)(36840700001)(316002)(54906003)(6916009)(40480700001)(40460700003)(2906002)(8676002)(186003)(1076003)(30864003)(6666004)(107886003)(83380400001)(2616005)(41300700001)(336012)(70586007)(4326008)(5660300002)(426003)(8936002)(82310400005)(81166007)(47076005)(82740400003)(44832011)(26005)(478600001)(7696005)(36756003)(70206006)(86362001)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:17:56.4351
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bd57cbb5-ca29-48fd-507e-08daab7a3f68
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9018

x86 has implemented a set of codes to process NUMA nodes. These
codes will parse NUMA memory and processor information from
ACPI SRAT table. But except some ACPI specific codes, most
of the process code like memory blocks validation, node memory
range updates and some sanity check can be reused by other
NUMA implementation.

So in this patch, we move some variables and related functions
for NUMA memory and processor to common as library. At the
same time, numa_set_processor_nodes_parsed has been introduced
for ACPI specific code to update processor parsing results.
With this helper, we can reuse most of NUMA memory affinity init
code from ACPI. As bad_srat and node_to_pxm functions have been
used in common code to do architectural fallback and node to
architectural node info translation. But it doesn't make sense
to reuse the functions names in common code, we have rename them
to neutral names as well.

PXM is an ACPI specific item, we can't use it in common code
directly. As an alternative, we extend the parameters of
numa_update_node_memblks. The caller can pass the PXM as print
messages' prefix or as architectural node id. And we introduced
an numa_fw_nid_name for each NUMA implementation to set their
specific firmware NUMA node name. In this case, we do not need
to retain a lot of per-arch code but still can print architectural
log messages for different NUMA implementations. A default value
"NONAME" will be set to indicate an unset numa_fw_nid_name.

mem_hotplug is accessed by common code if memory hotplug is
activated. Even if this is only supported by x86, export the
variable so that other architectures could support it in the future.

As asm/acpi.h has been removed from common/numa.c, we have to
move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch
as well.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v5 -> v6:
 1. Fix code-style.
 2. Use arch_numa_unavailable to replace arch_numa_disabled for
    acpi_numa <= 0.
 3. Remove Kconfig for HAS_NUMA_NODE_FWID.
 4. Use numa_fw_nid_name for NUMA implementation to set their fw
    NUMA node name for print messages.
v4 -> v5:
 1. Introduce arch_numa_disabled for acpi_numa <= 0 in this patch.
 2. Remove the paramter init_as_disable of arch_numa_disabled.
 3. Fix typo "expandsion".
 4. Add const to proper varibales.
 5. Fix Indentation for l1tf_safe_maddr.
 6. Remove double blank lines.
 7. Add a space between for_each_node_mask and '('.
    Add a space page_list_for_each and '('.
 8. Use bool for nodes_cover_memory return value.
 9. Use a plain "int ret" to record compute_hash_shift return value.
10. Add a blank line before the function's main "return".
11. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig.
v3 -> v4:
1. Use bool as return value for functions that only return
   0/1 or 0/-EINVAL.
2. Move mem_hotplug to a proper place in mm.h
3. Remove useless "size" in numa_scan_nodes.
4. Use unsigned int or const for proper variables.
5. Fix code-style.
6. Add init_as_disable as arch_numa_disabled parameter.
7. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping
   between node id and architectural node id (fw node id).
v2 -> v3:
1. Add __ro_after_init to proper variables.
2. Rename bad_srat to numa_fw_bad.
3. Rename node_to_pxm to numa_node_to_arch_nid.
4. Merge patch#7 and #8 into this patch.
5. Correct int to unsigned int in proper places.
6. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h
7. Drop helpers to access mem_hotplug, we export mem_hotplug
   from x86/mm.c to common/page_alloc.c
v1 -> v2:
1. Add code comment for numa_update_node_memblks to explain:
   Assumes all memory regions belonging to a single node
   are in one chunk. Holes between them will be included
   in the node.
2. Merge this single patch instead of serval patches to move
   x86 SRAT code to common.
3. Export node_to_pxm to keep pxm information in NUMA scan
   nodes error messages.
4. Change the code style to target file's Xen code-style.
5. Adjust some __init and __initdata for some functions and
   variables.
6. Merge two patches into this patch:
   1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA.
   2. replace "SRAT" texts.
7. Turn numa_scan_nodes to static.
---
 xen/arch/x86/include/asm/acpi.h |   1 -
 xen/arch/x86/include/asm/mm.h   |   2 -
 xen/arch/x86/include/asm/numa.h |   3 +-
 xen/arch/x86/mm.c               |   2 -
 xen/arch/x86/numa.c             |   5 +
 xen/arch/x86/srat.c             | 335 +++----------------------------
 xen/common/numa.c               | 340 +++++++++++++++++++++++++++++++-
 xen/common/page_alloc.c         |   2 +
 xen/include/xen/mm.h            |   2 +
 xen/include/xen/numa.h          |  10 +-
 10 files changed, 381 insertions(+), 321 deletions(-)

diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h
index 5c2dd5da2d..c453450a74 100644
--- a/xen/arch/x86/include/asm/acpi.h
+++ b/xen/arch/x86/include/asm/acpi.h
@@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address;
 #define ARCH_HAS_POWER_INIT	1
 
 extern s8 acpi_numa;
-#define NR_NODE_MEMBLKS (MAX_NUMNODES*2)
 
 extern struct acpi_sleep_info acpi_sinfo;
 #define acpi_video_flags bootsym(video_flags)
diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h
index 0fc826de46..95ff71a83a 100644
--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -474,8 +474,6 @@ static inline int get_page_and_type(struct page_info *page,
     ASSERT(((_p)->count_info & PGC_count_mask) != 0);          \
     ASSERT(page_get_owner(_p) == (_d))
 
-extern paddr_t mem_hotplug;
-
 /******************************************************************************
  * With shadow pagetables, the different kinds of address start
  * to get get confusing.
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 6c87942d43..2ca3475271 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -10,6 +10,7 @@ typedef u8 nodeid_t;
 extern int srat_rev;
 
 extern nodeid_t pxm_to_node(unsigned int pxm);
+extern unsigned int numa_node_to_arch_nid(nodeid_t n);
 
 #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
 
@@ -22,8 +23,6 @@ extern void init_cpu_to_node(void);
 
 #define arch_want_default_dmazone() (num_online_nodes() > 1)
 
-extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
-
 void srat_parse_regions(paddr_t addr);
 extern u8 __node_distance(nodeid_t a, nodeid_t b);
 unsigned int arch_get_dma_bitsize(void);
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index db1817b691..68f9989e1f 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -157,8 +157,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE)
 l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE)
     l1_fixmap_x[L1_PAGETABLE_ENTRIES];
 
-paddr_t __read_mostly mem_hotplug;
-
 /* Frame table size in pages. */
 unsigned long max_page;
 unsigned long total_pages;
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index fa8caaa084..4227bd5930 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -46,6 +46,11 @@ bool arch_numa_disabled(void)
     return acpi_numa < 0;
 }
 
+bool arch_numa_unavailable(void)
+{
+    return acpi_numa <= 0;
+}
+
 /*
  * Setup early cpu_to_node.
  *
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index 1a108a34c6..3bab47591e 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -24,10 +24,6 @@
 
 static struct acpi_table_slit *__read_mostly acpi_slit;
 
-static nodemask_t memory_nodes_parsed __initdata;
-static nodemask_t processor_nodes_parsed __initdata;
-static struct node nodes[MAX_NUMNODES] __initdata;
-
 struct pxm2node {
 	unsigned pxm;
 	nodeid_t node;
@@ -35,19 +31,6 @@ struct pxm2node {
 static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] =
 	{ [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} };
 
-static unsigned node_to_pxm(nodeid_t n);
-
-static int num_node_memblks;
-static struct node node_memblk_range[NR_NODE_MEMBLKS];
-static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS];
-static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS);
-
-enum conflicts {
-	NO_CONFLICT,
-	OVERLAP,
-	INTERLEAVE,
-};
-
 static inline bool node_found(unsigned idx, unsigned pxm)
 {
 	return ((pxm2node[idx].pxm == pxm) &&
@@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm)
 	return node;
 }
 
-int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node)
-{
-	int i;
-
-	for (i = 0; i < num_node_memblks; i++) {
-		struct node *nd = &node_memblk_range[i];
-
-		if (nd->start <= start && nd->end >= end &&
-			memblk_nodeid[i] == node)
-			return 1;
-	}
-
-	return 0;
-}
-
-static
-enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start,
-					  paddr_t end, paddr_t nd_start,
-					  paddr_t nd_end, unsigned int *mblkid)
-{
-	unsigned int i;
-
-	/*
-	 * Scan all recorded nodes' memory blocks to check conflicts:
-	 * Overlap or interleave.
-	 */
-	for (i = 0; i < num_node_memblks; i++) {
-		struct node *nd = &node_memblk_range[i];
-
-		*mblkid = i;
-
-		/* Skip 0 bytes node memory block. */
-		if (nd->start == nd->end)
-			continue;
-		/*
-		 * Use memblk range to check memblk overlaps, include the
-		 * self-overlap case. As nd's range is non-empty, the special
-		 * case "nd->end == end && nd->start == start" also can be covered.
-		 */
-		if (nd->end > start && nd->start < end)
-			return OVERLAP;
-
-		/*
-		 * Use node memory range to check whether new range contains
-		 * memory from other nodes - interleave check. We just need
-		 * to check full contains situation. Because overlaps have
-		 * been checked above.
-		 */
-	        if (nid != memblk_nodeid[i] &&
-		    nd->start >= nd_start && nd->end <= nd_end)
-			return INTERLEAVE;
-	}
-
-	return NO_CONFLICT;
-}
-
-static __init void cutoff_node(int i, paddr_t start, paddr_t end)
-{
-	struct node *nd = &nodes[i];
-	if (nd->start < start) {
-		nd->start = start;
-		if (nd->end < nd->start)
-			nd->start = nd->end;
-	}
-	if (nd->end > end) {
-		nd->end = end;
-		if (nd->start > nd->end)
-			nd->start = nd->end;
-	}
-}
-
-static __init void bad_srat(void)
+void __init numa_fw_bad(void)
 {
 	int i;
 	printk(KERN_ERR "SRAT: SRAT not used.\n");
@@ -241,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa)
 	if (numa_disabled())
 		return;
 	if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	if (!(pa->flags & ACPI_SRAT_CPU_ENABLED))
@@ -254,12 +166,12 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa)
 	pxm = pa->proximity_domain;
 	node = setup_node(pxm);
 	if (node == NUMA_NO_NODE) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 
 	apicid_to_node[pa->apic_id] = node;
-	node_set(node, processor_nodes_parsed);
+	numa_set_processor_nodes_parsed(node);
 	acpi_numa = 1;
 
 	if (opt_acpi_verbose)
@@ -277,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 	if (numa_disabled())
 		return;
 	if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	if (!(pa->flags & ACPI_SRAT_CPU_ENABLED))
@@ -290,11 +202,11 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 	}
 	node = setup_node(pxm);
 	if (node == NUMA_NO_NODE) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	apicid_to_node[pa->apic_id] = node;
-	node_set(node, processor_nodes_parsed);
+	numa_set_processor_nodes_parsed(node);
 	acpi_numa = 1;
 
 	if (opt_acpi_verbose)
@@ -306,33 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 void __init
 acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 {
-	struct node *nd;
-	paddr_t nd_start, nd_end;
-	paddr_t start, end;
 	unsigned pxm;
 	nodeid_t node;
-	unsigned int i;
-	bool next = false;
 
 	if (numa_disabled())
 		return;
 	if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	if (!(ma->flags & ACPI_SRAT_MEM_ENABLED))
 		return;
 
-	start = ma->base_address;
-	end = start + ma->length;
 	/* Supplement the heuristics in l1tf_calculations(). */
-	l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE));
+	l1tf_safe_maddr = max(l1tf_safe_maddr,
+			      ROUNDUP(ma->base_address + ma->length,
+				      PAGE_SIZE));
 
-	if (num_node_memblks >= NR_NODE_MEMBLKS)
-	{
+	if (!numa_memblks_available()) {
 		dprintk(XENLOG_WARNING,
-                "Too many numa entry, try bigger NR_NODE_MEMBLKS \n");
-		bad_srat();
+			"Too many numa entries, try bigger NR_NODE_MEMBLKS!\n");
+		numa_fw_bad();
 		return;
 	}
 
@@ -341,159 +247,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 		pxm &= 0xff;
 	node = setup_node(pxm);
 	if (node == NUMA_NO_NODE) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 
-	/*
-	 * For the node that already has some memory blocks, we will
-	 * expand the node memory range temporarily to check memory
-	 * interleaves with other nodes. We will not use this node
-	 * temp memory range to check overlaps, because it will mask
-	 * the overlaps in same node.
-	 *
-	 * Node with 0 bytes memory doesn't need this expandsion.
-	 */
-	nd_start = start;
-	nd_end = end;
-	nd = &nodes[node];
-	if (nd->start != nd->end) {
-		if (nd_start > nd->start)
-			nd_start = nd->start;
-
-		if (nd_end < nd->end)
-			nd_end = nd->end;
-	}
-
-	/* It is fine to add this area to the nodes data it will be used later*/
-	switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) {
-	case OVERLAP:
-		if (memblk_nodeid[i] == node) {
-			bool mismatch = !(ma->flags &
-					  ACPI_SRAT_MEM_HOT_PLUGGABLE) !=
-			                !test_bit(i, memblk_hotplug);
-
-			printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n",
-			       mismatch ? KERN_ERR : KERN_WARNING, pxm, start,
-			       end - 1, node_memblk_range[i].start,
-			       node_memblk_range[i].end - 1);
-			if (mismatch) {
-				bad_srat();
-				return;
-			}
-			break;
-		}
-
-		printk(KERN_ERR
-		       "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n",
-		       pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]),
-		       node_memblk_range[i].start,
-		       node_memblk_range[i].end - 1);
-		bad_srat();
-		return;
-
-	case INTERLEAVE:
-		printk(KERN_ERR
-		       "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n",
-		       pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]),
-		       node_memblk_range[i].start, node_memblk_range[i].end - 1);
-		bad_srat();
-		return;
-
-	case NO_CONFLICT:
-		break;
-	}
-
-	if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) {
-		node_set(node, memory_nodes_parsed);
-		nd->start = nd_start;
-		nd->end = nd_end;
-	}
-
-	printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
-	       node, pxm, start, end - 1,
-	       ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : "");
-
-	/* Keep node_memblk_range[] sorted by address. */
-	for (i = 0; i < num_node_memblks; ++i)
-		if (node_memblk_range[i].start > start ||
-		    (node_memblk_range[i].start == start &&
-		     node_memblk_range[i].end > end))
-			break;
-
-	memmove(&node_memblk_range[i + 1], &node_memblk_range[i],
-	        (num_node_memblks - i) * sizeof(*node_memblk_range));
-	node_memblk_range[i].start = start;
-	node_memblk_range[i].end = end;
-
-	memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i],
-	        (num_node_memblks - i) * sizeof(*memblk_nodeid));
-	memblk_nodeid[i] = node;
-
-	if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
-		next = true;
-		if (end > mem_hotplug)
-			mem_hotplug = end;
-	}
-	for (; i <= num_node_memblks; ++i) {
-		bool prev = next;
-
-		next = test_bit(i, memblk_hotplug);
-		if (prev)
-			__set_bit(i, memblk_hotplug);
-		else
-			__clear_bit(i, memblk_hotplug);
-	}
-
-	num_node_memblks++;
-}
-
-/* Sanity check to catch more bad SRATs (they are amazingly common).
-   Make sure the PXMs cover all memory. */
-static int __init nodes_cover_memory(void)
-{
-	unsigned int i;
-
-	for (i = 0; ; i++) {
-		int err;
-		unsigned int j;
-		bool found;
-		paddr_t start, end;
-
-		/* Try to loop memory map from index 0 to end to get RAM ranges. */
-		err = arch_get_ram_range(i, &start, &end);
-
-		/* Reached the end of the memory map? */
-		if (err == -ENOENT)
-			break;
-
-		/* Skip non-RAM entries. */
-		if (err)
-			continue;
-
-		do {
-			found = false;
-			for_each_node_mask(j, memory_nodes_parsed)
-				if (start < nodes[j].end
-				    && end > nodes[j].start) {
-					if (start >= nodes[j].start) {
-						start = nodes[j].end;
-						found = true;
-					}
-					if (end <= nodes[j].end) {
-						end = nodes[j].start;
-						found = true;
-					}
-				}
-		} while (found && start < end);
-
-		if (start < end) {
-			printk(KERN_ERR "NUMA: No NODE for RAM range: "
-				"[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1);
-			return 0;
-		}
-	}
-	return 1;
+	numa_fw_nid_name = "PXM";
+	if (!numa_update_node_memblks(node, pxm, ma->base_address, ma->length,
+				      ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE))
+		numa_fw_bad();
 }
 
 void __init acpi_numa_arch_fixup(void) {}
@@ -549,59 +310,9 @@ void __init srat_parse_regions(paddr_t addr)
 	pfn_pdx_hole_setup(mask >> PAGE_SHIFT);
 }
 
-/* Use discovered information to actually set up the nodes. */
-int __init numa_process_nodes(paddr_t start, paddr_t end)
+unsigned int numa_node_to_arch_nid(nodeid_t n)
 {
-	int i;
-	nodemask_t all_nodes_parsed;
-
-	/* First clean up the node list */
-	for (i = 0; i < MAX_NUMNODES; i++)
-		cutoff_node(i, start, end);
-
-	if (acpi_numa <= 0)
-		return -1;
-
-	if (!nodes_cover_memory()) {
-		bad_srat();
-		return -1;
-	}
-
-	memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks,
-				memblk_nodeid);
-
-	if (memnode_shift < 0) {
-		printk(KERN_ERR
-		     "SRAT: No NUMA node hash function found. Contact maintainer\n");
-		bad_srat();
-		return -1;
-	}
-
-	nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed);
-
-	/* Finally register nodes */
-	for_each_node_mask(i, all_nodes_parsed)
-	{
-		uint64_t size = nodes[i].end - nodes[i].start;
-
-		if ( size == 0 )
-			printk(KERN_INFO "SRAT: node %u has no memory\n", i);
-
-		setup_node_bootmem(i, nodes[i].start, nodes[i].end);
-	}
-	for (i = 0; i < nr_cpu_ids; i++) {
-		if (cpu_to_node[i] == NUMA_NO_NODE)
-			continue;
-		if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed))
-			numa_set_node(i, NUMA_NO_NODE);
-	}
-	numa_init_array();
-	return 0;
-}
-
-static unsigned node_to_pxm(nodeid_t n)
-{
-	unsigned i;
+	unsigned int i;
 
 	if ((n < ARRAY_SIZE(pxm2node)) && (pxm2node[n].node == n))
 		return pxm2node[n].pxm;
@@ -618,8 +329,8 @@ u8 __node_distance(nodeid_t a, nodeid_t b)
 
 	if (!acpi_slit)
 		return a == b ? 10 : 20;
-	index = acpi_slit->locality_count * node_to_pxm(a);
-	slit_val = acpi_slit->entry[index + node_to_pxm(b)];
+	index = acpi_slit->locality_count * numa_node_to_arch_nid(a);
+	slit_val = acpi_slit->entry[index + numa_node_to_arch_nid(b)];
 
 	/* ACPI defines 0xff as an unreachable node and 0-9 are undefined */
 	if ((slit_val == 0xff) || (slit_val <= 9))
diff --git a/xen/common/numa.c b/xen/common/numa.c
index 3ad3a5138b..1967e07f99 100644
--- a/xen/common/numa.c
+++ b/xen/common/numa.c
@@ -13,6 +13,21 @@
 #include <xen/sched.h>
 #include <xen/softirq.h>
 
+static nodemask_t __initdata processor_nodes_parsed;
+static nodemask_t __initdata memory_nodes_parsed;
+static struct node __initdata nodes[MAX_NUMNODES];
+
+static unsigned int __ro_after_init num_node_memblks;
+static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS];
+static nodeid_t __ro_after_init memblk_nodeid[NR_NODE_MEMBLKS];
+static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS);
+
+enum conflicts {
+    NO_CONFLICT,
+    OVERLAP,
+    INTERLEAVE,
+};
+
 struct node_data __ro_after_init node_data[MAX_NUMNODES];
 
 /* Mapping from pdx to node id */
@@ -31,11 +46,334 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
 
 bool __ro_after_init numa_off;
 
+const char *__ro_after_init numa_fw_nid_name = "NONAME";
+
 bool numa_disabled(void)
 {
     return numa_off || arch_numa_disabled();
 }
 
+void __init numa_set_processor_nodes_parsed(nodeid_t node)
+{
+    node_set(node, processor_nodes_parsed);
+}
+
+bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node)
+{
+    unsigned int i;
+
+    for ( i = 0; i < num_node_memblks; i++ )
+    {
+        const struct node *nd = &node_memblk_range[i];
+
+        if ( nd->start <= start && nd->end >= end &&
+             memblk_nodeid[i] == node )
+            return true;
+    }
+
+    return false;
+}
+
+static enum conflicts __init conflicting_memblks(
+    nodeid_t nid, paddr_t start, paddr_t end, paddr_t nd_start,
+    paddr_t nd_end, unsigned int *mblkid)
+{
+    unsigned int i;
+
+    /*
+     * Scan all recorded nodes' memory blocks to check conflicts:
+     * Overlap or interleave.
+     */
+    for ( i = 0; i < num_node_memblks; i++ )
+    {
+        const struct node *nd = &node_memblk_range[i];
+
+        *mblkid = i;
+
+        /* Skip 0 bytes node memory block. */
+        if ( nd->start == nd->end )
+            continue;
+        /*
+         * Use memblk range to check memblk overlaps, include the
+         * self-overlap case. As nd's range is non-empty, the special
+         * case "nd->end == end && nd->start == start" also can be covered.
+         */
+        if ( nd->end > start && nd->start < end )
+            return OVERLAP;
+
+        /*
+         * Use node memory range to check whether new range contains
+         * memory from other nodes - interleave check. We just need
+         * to check full contains situation. Because overlaps have
+         * been checked above.
+         */
+        if ( nid != memblk_nodeid[i] &&
+             nd->start >= nd_start && nd->end <= nd_end )
+            return INTERLEAVE;
+    }
+
+    return NO_CONFLICT;
+}
+
+static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end)
+{
+    struct node *nd = &nodes[i];
+
+    if ( nd->start < start )
+    {
+        nd->start = start;
+        if ( nd->end < nd->start )
+            nd->start = nd->end;
+    }
+
+    if ( nd->end > end )
+    {
+        nd->end = end;
+        if ( nd->start > nd->end )
+            nd->start = nd->end;
+    }
+}
+
+bool __init numa_memblks_available(void)
+{
+    return num_node_memblks < NR_NODE_MEMBLKS;
+}
+
+/*
+ * This function will be called by NUMA memory affinity initialization to
+ * update NUMA node's memory range. In this function, we assume all memory
+ * regions belonging to a single node are in one chunk. Holes (or MMIO
+ * ranges) between them will be included in the node.
+ *
+ * So in numa_update_node_memblks, if there are multiple banks for each
+ * node, start and end are stretched to cover the holes between them, and
+ * it works as long as memory banks of different NUMA nodes don't interleave.
+ */
+bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid,
+                                     paddr_t start, paddr_t size, bool hotplug)
+{
+    unsigned int i;
+    bool next = false;
+    paddr_t end = start + size;
+    paddr_t nd_start = start;
+    paddr_t nd_end = end;
+    struct node *nd = &nodes[node];
+
+    /*
+     * For the node that already has some memory blocks, we will
+     * expand the node memory range temporarily to check memory
+     * interleaves with other nodes. We will not use this node
+     * temp memory range to check overlaps, because it will mask
+     * the overlaps in same node.
+     *
+     * Node with 0 bytes memory doesn't need this expansion.
+     */
+    if ( nd->start != nd->end )
+    {
+        if ( nd_start > nd->start )
+            nd_start = nd->start;
+
+        if ( nd_end < nd->end )
+            nd_end = nd->end;
+    }
+
+    /* It is fine to add this area to the nodes data it will be used later */
+    switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) )
+    {
+    case OVERLAP:
+        if ( memblk_nodeid[i] == node )
+        {
+            bool mismatch = !hotplug != !test_bit(i, memblk_hotplug);
+
+            printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n",
+                   mismatch ? KERN_ERR : KERN_WARNING, numa_fw_nid_name,
+                   arch_nid, start, end - 1,
+                   node_memblk_range[i].start, node_memblk_range[i].end - 1);
+            if ( mismatch )
+                return false;
+            break;
+        }
+
+        printk(KERN_ERR
+               "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n",
+               numa_fw_nid_name, arch_nid, start, end - 1, numa_fw_nid_name,
+               numa_node_to_arch_nid(memblk_nodeid[i]),
+               node_memblk_range[i].start, node_memblk_range[i].end - 1);
+        return false;
+
+    case INTERLEAVE:
+        printk(KERN_ERR
+               "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n",
+               numa_fw_nid_name, arch_nid, nd_start, nd_end - 1,
+               numa_fw_nid_name, numa_node_to_arch_nid(memblk_nodeid[i]),
+               node_memblk_range[i].start, node_memblk_range[i].end - 1);
+        return false;
+
+    case NO_CONFLICT:
+        break;
+    }
+
+    if ( !hotplug )
+    {
+        node_set(node, memory_nodes_parsed);
+        nd->start = nd_start;
+        nd->end = nd_end;
+    }
+
+    printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
+           node, numa_fw_nid_name, arch_nid, start, end - 1,
+           hotplug ? " (hotplug)" : "");
+
+    /* Keep node_memblk_range[] sorted by address. */
+    for ( i = 0; i < num_node_memblks; ++i )
+        if ( node_memblk_range[i].start > start ||
+             (node_memblk_range[i].start == start &&
+             node_memblk_range[i].end > end) )
+            break;
+
+    memmove(&node_memblk_range[i + 1], &node_memblk_range[i],
+            (num_node_memblks - i) * sizeof(*node_memblk_range));
+    node_memblk_range[i].start = start;
+    node_memblk_range[i].end = end;
+
+    memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i],
+            (num_node_memblks - i) * sizeof(*memblk_nodeid));
+    memblk_nodeid[i] = node;
+
+    if ( hotplug ) {
+        next = true;
+        if ( end > mem_hotplug )
+            mem_hotplug = end;
+    }
+
+    for ( ; i <= num_node_memblks; ++i )
+    {
+        bool prev = next;
+
+        next = test_bit(i, memblk_hotplug);
+        if ( prev )
+            __set_bit(i, memblk_hotplug);
+        else
+            __clear_bit(i, memblk_hotplug);
+    }
+
+    num_node_memblks++;
+
+    return true;
+}
+
+/*
+ * Sanity check to catch more bad SRATs (they are amazingly common).
+ * Make sure the PXMs cover all memory.
+ */
+static bool __init nodes_cover_memory(void)
+{
+    unsigned int i;
+
+    for ( i = 0; ; i++ )
+    {
+        int err;
+        unsigned int j;
+        bool found;
+        paddr_t start, end;
+
+        /* Try to loop memory map from index 0 to end to get RAM ranges. */
+        err = arch_get_ram_range(i, &start, &end);
+
+        /* Reached the end of the memory map? */
+        if ( err == -ENOENT )
+            break;
+
+        /* Skip non-RAM entries. */
+        if ( err )
+            continue;
+
+        do {
+            found = false;
+            for_each_node_mask ( j, memory_nodes_parsed )
+                if ( start < nodes[j].end && end > nodes[j].start )
+                {
+                    if ( start >= nodes[j].start )
+                    {
+                        start = nodes[j].end;
+                        found = true;
+                    }
+
+                    if ( end <= nodes[j].end )
+                    {
+                        end = nodes[j].start;
+                        found = true;
+                    }
+                }
+        } while ( found && start < end );
+
+        if ( start < end )
+        {
+            printk(KERN_ERR "NUMA: No node for RAM range: "
+                   "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1);
+            return false;
+        }
+    }
+
+    return true;
+}
+
+/* Use discovered information to actually set up the nodes. */
+static bool __init numa_process_nodes(paddr_t start, paddr_t end)
+{
+    int ret;
+    unsigned int i;
+    nodemask_t all_nodes_parsed;
+
+    /* First clean up the node list */
+    for ( i = 0; i < MAX_NUMNODES; i++ )
+        cutoff_node(i, start, end);
+
+    /* When numa is on and has data, we can start to process numa nodes. */
+    if ( arch_numa_unavailable() )
+        return false;
+
+    if ( !nodes_cover_memory() )
+    {
+        numa_fw_bad();
+        return false;
+    }
+
+    ret = compute_hash_shift(node_memblk_range, num_node_memblks,
+                             memblk_nodeid);
+    if ( ret < 0 )
+    {
+        printk(KERN_ERR
+               "NUMA: No NUMA node hash function found. Contact maintainer\n");
+        numa_fw_bad();
+        return false;
+    }
+    memnode_shift = ret;
+
+    nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed);
+
+    /* Finally register nodes */
+    for_each_node_mask ( i, all_nodes_parsed )
+    {
+        if ( nodes[i].end == nodes[i].start )
+            printk(KERN_INFO "NUMA: node %u has no memory\n", i);
+
+        setup_node_bootmem(i, nodes[i].start, nodes[i].end);
+    }
+
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_to_node[i] == NUMA_NO_NODE )
+            continue;
+        if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) )
+            numa_set_node(i, NUMA_NO_NODE);
+    }
+
+    numa_init_array();
+
+    return true;
+}
+
 /*
  * Given a shift value, try to populate memnodemap[]
  * Returns :
@@ -261,7 +599,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
 #endif
 
 #ifdef CONFIG_NUMA
-    if ( !numa_off && !numa_process_nodes(start, end) )
+    if ( !numa_off && numa_process_nodes(start, end) )
         return;
 #endif
 
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 62afb07bc6..80447a341d 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -159,6 +159,8 @@
 #define PGT_TYPE_INFO_INITIALIZER 0
 #endif
 
+paddr_t __read_mostly mem_hotplug;
+
 /*
  * Comma-separated list of hexadecimal page numbers containing bad bytes.
  * e.g. 'badpage=0x3f45,0x8a321'.
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index a925028ab3..9d14aed74b 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -147,6 +147,8 @@ int assign_page(
 /* Dump info to serial console */
 void arch_dump_shared_mem_info(void);
 
+extern paddr_t mem_hotplug;
+
 /*
  * Extra fault info types which are used to further describe
  * the source of an access violation.
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 9da0e7d555..04ecaf7769 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -11,6 +11,7 @@
 #define NUMA_NO_DISTANCE 0xFF
 
 #define MAX_NUMNODES    (1 << NODES_SHIFT)
+#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
 
 #define vcpu_to_node(v) (cpu_to_node((v)->processor))
 
@@ -36,14 +37,16 @@ extern int compute_hash_shift(const struct node *nodes,
                               unsigned int numnodes, const nodeid_t *nodeids);
 
 extern bool numa_off;
+extern const char *numa_fw_nid_name;
 
 extern void numa_add_cpu(unsigned int cpu);
 extern void numa_init_array(void);
 extern void numa_set_node(unsigned int cpu, nodeid_t node);
 extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
-extern int numa_process_nodes(paddr_t start, paddr_t end);
+extern void numa_fw_bad(void);
 
 extern int arch_numa_setup(const char *opt);
+extern bool arch_numa_unavailable(void);
 extern bool arch_numa_disabled(void);
 extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
 
@@ -92,6 +95,11 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
  */
 extern int arch_get_ram_range(unsigned int idx,
                               paddr_t *start, paddr_t *end);
+extern bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
+extern bool numa_memblks_available(void);
+extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid,
+                                     paddr_t start, paddr_t size, bool hotplug);
+extern void numa_set_processor_nodes_parsed(nodeid_t node);
 
 #endif
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:18:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:18:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419584.664421 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGu-0006L3-5r; Tue, 11 Oct 2022 11:18:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419584.664421; Tue, 11 Oct 2022 11:18:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDGt-0006Ix-TG; Tue, 11 Oct 2022 11:18:03 +0000
Received: by outflank-mailman (input) for mailman id 419584;
 Tue, 11 Oct 2022 11:18:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDGs-0005JI-M0
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:18:02 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e35e6e0-4956-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 13:18:01 +0200 (CEST)
Received: from AM6PR08CA0040.eurprd08.prod.outlook.com (2603:10a6:20b:c0::28)
 by DBAPR08MB5654.eurprd08.prod.outlook.com (2603:10a6:10:1a6::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:58 +0000
Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:c0:cafe::23) by AM6PR08CA0040.outlook.office365.com
 (2603:10a6:20b:c0::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:57 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Tue, 11 Oct 2022 11:17:57 +0000
Received: from 75c7a65fa408.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D9034031-9535-46F2-AD6A-AE2E5A96FB01.1; 
 Tue, 11 Oct 2022 11:17:49 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75c7a65fa408.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:49 +0000
Received: from AS9PR06CA0763.eurprd06.prod.outlook.com (2603:10a6:20b:484::17)
 by AS2PR08MB8287.eurprd08.prod.outlook.com (2603:10a6:20b:556::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:48 +0000
Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:484:cafe::9c) by AS9PR06CA0763.outlook.office365.com
 (2603:10a6:20b:484::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:48 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:47 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:46 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e35e6e0-4956-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=EpXIhCCsOUPZNUd7C0KS5Pq+8Q0KW22KuI2ZR0fXg+sXI464Gr+X6s3eY9Z8npF58h8qIBJ8P3nEO7V5RV0qz0eCzpC4cnvJ9Ndrjihksz+abCAPP5hhY4W5eQT/FJ7Rh8Ejceit9z4Hbsz3ta+xR4S5fawigRidznG6N2HFQr+QYffBta66qKDu95CSF7UV65yxj4mcF2FnuiX0JbIINYPL13kHxX8TQ7vGKBqKvV3tI6+maEgM+J0qKL61gKPn1fDZscofw/EBQHpZFE93tYGRZ0bcU0+1bSlYjJ/+Gpp9VHfjPRFppnffsdI9ABgefppB/gj4LXxoc8oWubD+/Q==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b2GLMwmhodAy6ZR2vEpQ3koomWaM0KLVXx6V9XMPT4I=;
 b=CqsZhUH7ym+/NWroFJscO4QZBU2x+RSK62Lb7rZ6vuV1z8QQf5TyUQqXdyjGMDN1KI/HmiNiSkQVAyHhJngfYvQADol9/UNbzMquH+sso+M/TGabceyu0aTHET8OZ741PGhXqVh+HISiIOdfwoc0eUb+R8sOsD+HFA4rm+kJp5N5y3blcFfEt7O3w+Y/gUDLGiGgX6EiTXZetkJSP+njDOd9chavaOn8lA7kQyuVGsTjrIShDOIqck7+t4dEQvw01cG6NCgaWOWS3z8ht/AAqzYZhTKAxPAV844Olq6BpNCJEF5xlZSOeU0eQNMkjKiPgECn3IWgvilENp1Hgqgoqg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b2GLMwmhodAy6ZR2vEpQ3koomWaM0KLVXx6V9XMPT4I=;
 b=AZiMjepOJzCKjWCxfp1H0x5R/A3mxCtAAJmp4C4m/sakkfdGVRlic+4f+VYWJNeXKJOk7ZMcLpplHFOuahzWVCRo+FOkuPTT0vmCg9JIoajcy3jHQMZ31NCc5pw20h2Y+zo0yu0SvibWw5fV5pJbWlO+wXFgmgzyhnoyIQsIkMg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8ee3ca894f3d2594
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vy9ZUbnWOx19vcPbzheCWCmg1Idqy7Dc/uCO6LM0eBo5Ns2TRf2RUv2am9fgS4VHZVk1EeyAPFmQC1zeymucZ6UbiEXwN2X0wiK6JfSAtvAwPm9tBG4rdtGiocqetpDVNbEnD/Qmf6aiMB8m7jWM4HB9p3L+PRjxN3lc0P5JzAWLZuVsj8jBTDX4HuMsHn7HjQ/P6NiXty+u3N/iEof5qLi5TQyNmB0OYLs2DVTo21XFhIPZ4sYOrmLtYIs6nPjYI+xLszOsJHgtE9v8CGYi6Cwwmdq9amKyPGlIvTRE0O3p0hm1iYzTO+Pl2KBvAH3B5tWaP1xJqzbK2UllL/l9pQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b2GLMwmhodAy6ZR2vEpQ3koomWaM0KLVXx6V9XMPT4I=;
 b=JyyQciqUoGYZE3xI4iGoEZErXG3+6njOZPw8Q9muearZRW/8wXVZMtKVdanMGjFWWdhQOvNS+e3ZrY2wt4Vhd9b/9WdthWPq936/lTUKyXdcZ5/iRPjqQ9nC300MSSQrcsRIQNRwv0GbjwC2G5uMQnYrhs5Q2ghZEu+lFfX/W0fFZzT0Fuz3tyjToCYOFPW2nMqVY21TZRXoeF2q1SdYq8B19gOYfogQaeMKndFlp/Ltik8EGwDSuqapOvcuUtXbdjHiREWnNIOSOGk4ZLyzjyyhVFCWtLup4EyITDUW4zGqJfIXZxRv1DpuDKkwkytABOxI57vmE6sO0CPPHh/kKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b2GLMwmhodAy6ZR2vEpQ3koomWaM0KLVXx6V9XMPT4I=;
 b=AZiMjepOJzCKjWCxfp1H0x5R/A3mxCtAAJmp4C4m/sakkfdGVRlic+4f+VYWJNeXKJOk7ZMcLpplHFOuahzWVCRo+FOkuPTT0vmCg9JIoajcy3jHQMZ31NCc5pw20h2Y+zo0yu0SvibWw5fV5pJbWlO+wXFgmgzyhnoyIQsIkMg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v6 6/6] xen: introduce a Kconfig option to configure NUMA nodes number
Date: Tue, 11 Oct 2022 19:17:08 +0800
Message-ID: <20221011111708.1272985-7-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221011111708.1272985-1-wei.chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VE1EUR03FT064:EE_|AS2PR08MB8287:EE_|VE1EUR03FT055:EE_|DBAPR08MB5654:EE_
X-MS-Office365-Filtering-Correlation-Id: 375dc67e-5645-4266-a395-08daab7a3ffb
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ieN/S/xTVUQt2x3L5xfXJFeG42YmcRvmX3i6lmYOl8fr5TI230ulc1iTz+vJKwpC1I3dV+9jjn9uE1S7BVcuT5yh+OHrvwPEIyaHQTtZRkez761WMHIZ7vGb462DyGVUBM75ffbNG44w4Io/5E/HjSu5koVT5kx4bSOc9Vad0+nRHwl7TcCRsdsVq3iVkyNqwnkPiPfrUfaN9wccaM5LTgkbRb0gZqCjuwSZfUMc7Um9JbOLvjQp31sQTT2JyADjWRaRuDScF3kMSBao4Z/hK1D5PGyImu/z2K6rK+zVTT0iGw8KtWjlb4B68oKwt8JU8GwlQAFH0bc9QSpqXWjhPqJ9ETK45/7kDKXyYXeHTzP/GnwTzT0Q9U+S4XXEDusakEZwV6o8Ql1cOHPcREN89j+yoZe30tkrU2WguEBd79YMcJKkZgAD4nhgR1az3GrAi+A74J6tAy8JY1nRISooRfocXR161nlt4V4wwMjjMQBOtMssOuslzFRG9px7YsqRRr4BPyyjPrC2hcz8eYiREPO7FiipgJMAzqeJAwO/FtMWJ9+pzI2WzpwS9QYujW0ONDBoJ+IGWbndU1c7FXLP34+Bo69iqOaY6p4AAcuMCSAZoHONoT+/Tx4Ejrbi+PsLs2Ah5kxAKmPekiuJtP6iHkdoW2YCSDH41H6cD7mqrXUOZjAuJsMGE9H2V0VNlfiE6WWHO56s1jfe0tYoF8kCpSJJjYP89P4NfNv8z1W3zIHehjTH9c+I3o7Z5h/Zgk3YqFE5vIjURG9GuYtHSOt+j/UeO8m+I2TsHgpvxZrB41g=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(46966006)(36840700001)(40470700004)(1076003)(2616005)(186003)(44832011)(82310400005)(356005)(2906002)(6666004)(36756003)(4326008)(70206006)(70586007)(8676002)(316002)(478600001)(40460700003)(41300700001)(6916009)(5660300002)(36860700001)(26005)(86362001)(40480700001)(54906003)(336012)(8936002)(426003)(7696005)(47076005)(82740400003)(83380400001)(81166007)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8287
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	25bfa2e3-3974-4acf-eccc-08daab7a3a37
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3wnGOjiS5wwh3hZCKpKkt8qpcnWMHB+wTYR5GPScuAWtB3KHGE+u5jC3EdlqykMLwpXbSYzpaEtMAcPhSh81laTFJ7RB/SO9LRoQHZFI2AP6fXWhn8uYulzfmWAmWw7ly3727Z4YQo23JtEPjkMz3drJApOFJlwEzxDplUHtkNfwbOLWOwXc9CBHL1bUQnoD4yA0vw5E+zoh42m4RhPj2mQUt98ID3xQMYjDnJVETO4jG9vlpb6aYXp9SYBdwHgIUYpbj2c3HOrVojqjyAwhe/AOVr6StW4KWPcXYFxemetMGCgRfmWkOrsU50mUj+v7cWjMpjM6p1SBwziovMtu/gPDIAnyklppVEb8A+eCB3Qj3HOW7F2iyWZPi0EBTRhge40BiY5onddZ9prf5nJax6m9KTSbBs4A8x/uBTB9LFpa5NsA5uYt+WrFeuDiiDDsHiq0IFq6I66xaBUamsKAqrrSXqzMSAqIqss3/xUo5agG+RzJUuIGjyYANG9vPG6CIgWI+CNj/osT0dM55w3nOyRI9S59VLCDPWl7xRH0EJ/4pkiPsk0Urz6MHu6lC3ine8+v7dXvWHVOZ/1+XU8H32B/9oqFFBF3Z0fd+YUMPxRuRws5MZ2gH7+hwLiSZaYcsmpVqhWca19EU5QDNeILqQUy9g4v3NML4KpA/CM0nbxjG25ei7r+/DVW9IOENf6Fk4ZbMXihypdsFrnybqotMst0DJUbLJno6uNpA+hKxIpihPzWd9ZPJnlWRCEXwnbEBvjk6u6D1yaaSyEKacSR0Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39850400004)(451199015)(46966006)(40470700004)(36840700001)(40460700003)(1076003)(4326008)(2906002)(41300700001)(8676002)(2616005)(186003)(70206006)(86362001)(426003)(83380400001)(70586007)(47076005)(36756003)(8936002)(44832011)(336012)(5660300002)(6666004)(82740400003)(107886003)(7696005)(40480700001)(82310400005)(478600001)(81166007)(316002)(6916009)(54906003)(26005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:17:57.3059
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 375dc67e-5645-4266-a395-08daab7a3ffb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5654

Currently the maximum number of NUMA nodes is a hardcoded value.
This provides little flexibility unless changing the code.

Introduce a new Kconfig option to change the maximum number of
NUMA nodes conveniently. Also considering that not all
architectures support NUMA, this Kconfig option is only visible
on NUMA enabled architectures. Architectures not supporting NUMA
still use 1 for MAX_NUMNODES.

As NODES_SHIFT is currently unused, we're taking this
opportunity to remove it.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v5 -> v6:
1. No change.
v4 -> v5:
1. No change.
v3 -> v4:
1. Update the commit log to follow Jan's suggestion.
2. Add Ack-by.
v2 -> v3:
1. Fix indent.
2. Use 2-64 for node range.
v1 -> v2:
1. Add NODES_SHIFT remove message in commit log
2. Change NR_NUMA_NODES upper bound from 4095 to 255.
---
 xen/arch/Kconfig                | 11 +++++++++++
 xen/arch/x86/include/asm/numa.h |  2 --
 xen/include/xen/numa.h          | 11 ++++++-----
 3 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig
index f16eb0df43..7028f7b74f 100644
--- a/xen/arch/Kconfig
+++ b/xen/arch/Kconfig
@@ -17,3 +17,14 @@ config NR_CPUS
 	  For CPU cores which support Simultaneous Multi-Threading or similar
 	  technologies, this the number of logical threads which Xen will
 	  support.
+
+config NR_NUMA_NODES
+	int "Maximum number of NUMA nodes supported"
+	range 2 64
+	default "64"
+	depends on NUMA
+	help
+	  Controls the build-time size of various arrays and bitmaps
+	  associated with multiple-nodes management. It is the upper bound of
+	  the number of NUMA nodes that the scheduler, memory allocation and
+	  other NUMA-aware components can handle.
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 2ca3475271..7866afa408 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -3,8 +3,6 @@
 
 #include <xen/cpumask.h>
 
-#define NODES_SHIFT 6
-
 typedef u8 nodeid_t;
 
 extern int srat_rev;
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 04ecaf7769..71a5f837b3 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -3,14 +3,15 @@
 
 #include <asm/numa.h>
 
-#ifndef NODES_SHIFT
-#define NODES_SHIFT     0
-#endif
-
 #define NUMA_NO_NODE     0xFF
 #define NUMA_NO_DISTANCE 0xFF
 
-#define MAX_NUMNODES    (1 << NODES_SHIFT)
+#ifdef CONFIG_NR_NUMA_NODES
+#define MAX_NUMNODES CONFIG_NR_NUMA_NODES
+#else
+#define MAX_NUMNODES 1
+#endif
+
 #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
 
 #define vcpu_to_node(v) (cpu_to_node((v)->processor))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:22:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:22:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419613.664436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDL6-0000rY-NS; Tue, 11 Oct 2022 11:22:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419613.664436; Tue, 11 Oct 2022 11:22:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDL6-0000rR-KC; Tue, 11 Oct 2022 11:22:24 +0000
Received: by outflank-mailman (input) for mailman id 419613;
 Tue, 11 Oct 2022 11:22:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2VIF=2M=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1oiDL5-0000rL-4G
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:22:23 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7eecb4a-4956-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 13:22:20 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 26A6C5C0165;
 Tue, 11 Oct 2022 07:22:19 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 11 Oct 2022 07:22:19 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 11 Oct 2022 07:22:17 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7eecb4a-4956-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1665487339; x=
	1665573739; bh=CQLvPIi+zS+g8PJ804HomIoSRHPl8Tc4biMEue8VQbo=; b=E
	eZ/qDgPzncG4Sr0f0dYKZVX8++llNC685ahpdV+kNuN1i3Iv38eoURhvRb/7nLhi
	L2px3E0ZfZMAaOefKDGKPahpzPQm7tFBM+auRgOPg99wSZKcxe/8JUP+5x+qT8xH
	5xPL4LQFvMuMYGU/aJzA1h3WWJhXBotNwO4No3X+S5E1oMBKPdJ/FISALxC92wwN
	qGFBzMFOpCdybqD6pD4iQr9rvxmvraxfHFsp2vFsAnGi8MP+VVj8Mqc0Zyux8xm4
	9M1KBox0SurzVTyQ7eeKXn9dEp48qxGtaLXG362C/7iPgTve/YeEp+GXihdgSV5R
	A6hUub4usEpdJKWQn1Ilw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1665487339; x=1665573739; bh=CQLvPIi+zS+g8PJ804HomIoSRHPl
	8Tc4biMEue8VQbo=; b=K2LFOFJC9g3g+nkSLFeBF9Ka8LKdDb2lFrNivLc4fZx/
	2W4xCwXkBN90CrIx+2/md1xmboEdXEFSF8p0jQ2gAlRqRY1iWaCkdbNyc0KncBIb
	W2SIK0wUv1H6h17M4ZuvU+Y+lPuvumTkKIZYoGT4yo09QnvOus3rFFZtdflxHakl
	Idyqr21zLV35IAYiMEWckvyFdAjqFoFyxGxkByWxjBXtNj08xUU6n6xs0317JVxi
	HR+XpDVGG7KkexfPoIHmKaGbavxpfOTwsQmb/efPIQd0jfRKzexz3jmdnvEzLdK8
	Gsrr5C3OkjmiVA1kqLPcH4TICZW0mUy0eu6YS430vg==
X-ME-Sender: <xms:6lFFY2AMuu3AbuWTk_jc7yiKiHetvQd5QTa9jN9tquVV5UOthciiOA>
    <xme:6lFFYwihy09I8YHmlOxG1TkXwtILeX9ANo_mqc8KDg7NMa1s6jA7xq65gx9xgGKq3
    o2mpWQKdHGI9Q>
X-ME-Received: <xmr:6lFFY5kYIUf7RMdOgdgtRxwXh5q1mCxr_DELsGYz5bABVh2Ty3L58X42vgRgc2aZp2Ka5zfCYstiIxSCuBMplx9zp0Qddu6gMLxT>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejiedgfeehucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdff
    veffkedvudetvdetvdefffduueeuveelfedtfeevfedtveelgfegtdevvdeunecuffhomh
    grihhnpehgihhthhhusgdrtghomhdprggttghorhguihhnghhlhidrphhinhhgnecuvehl
    uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvg
    hksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:6lFFY0xbIKUkZHtymVEA3PW7SafJZH8VoyKhhF7UL7jmT9vfHTmFZQ>
    <xmx:6lFFY7TrIK8cWVrQNv0zkbq7v5na6Z5iOFiAxZxnCJvDAug0hEWGlw>
    <xmx:6lFFY_avngfwB1wOeSz2nPHWhFoVoczqJoc8m9HeWgCBHEDhBBLLFQ>
    <xmx:61FFY1fe9KinpiScHmC55r3pP69BNAPQWpJLey5Gw-HNXXHphNeugg>
Feedback-ID: i1568416f:Fastmail
Date: Tue, 11 Oct 2022 13:22:15 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer
Message-ID: <Y0VR53lPZbbmbR2L@mail-itl>
References: <d243c1b5-712d-a958-0b6c-b232eb4edc80@suse.com>
 <20200929151627.GE1482@mail-itl>
 <ea53b845-5edf-a61e-62ae-7ababc30b3e0@suse.com>
 <20210131021526.GB6354@mail-itl>
 <YWHDIQC3K8J3LD8+@mail-itl>
 <YwJZ3X0HpT9w6Veh@mail-itl>
 <b1df84d5-a1ca-3019-16a7-36d0bb568779@suse.com>
 <YwNTu1fL7uITg0OZ@mail-itl>
 <YymUZCfLZRWl6xr5@mail-itl>
 <e813f296-ba1d-7ff0-a84c-97737d7ac7a5@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="hvm1Jo/UDaOd/PS4"
Content-Disposition: inline
In-Reply-To: <e813f296-ba1d-7ff0-a84c-97737d7ac7a5@suse.com>


--hvm1Jo/UDaOd/PS4
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 11 Oct 2022 13:22:15 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Dario Faggioli <dfaggioli@suse.com>,
	George Dunlap <george.dunlap@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer

On Tue, Sep 20, 2022 at 04:30:41PM +0200, Jan Beulich wrote:
> On 20.09.2022 12:22, Marek Marczykowski-G=C3=B3recki wrote:
> > On Mon, Aug 22, 2022 at 12:00:27PM +0200, Marek Marczykowski-G=C3=B3rec=
ki wrote:
> >> On Mon, Aug 22, 2022 at 11:53:50AM +0200, Jan Beulich wrote:
> >>> On 21.08.2022 18:14, Marek Marczykowski-G=C3=B3recki wrote:
> >>>> On Sat, Oct 09, 2021 at 06:28:17PM +0200, Marek Marczykowski-G=C3=B3=
recki wrote:
> >>>>> On Sun, Jan 31, 2021 at 03:15:30AM +0100, Marek Marczykowski-G=C3=
=B3recki wrote:
> >>>>>> I'm resurrecting this thread as it was recently mentioned elsewher=
e. I
> >>>>>> can still reproduce the issue on the recent staging branch (9dc687=
f155).
> >>>>>>
> >>>>>> It fails after the first resume (not always, but frequent enough to
> >>>>>> debug it). At least one guest needs to be running - with just (PV)=
 dom0
> >>>>>> the crash doesn't happen (at least for the ~8 times in a row I tri=
ed).
> >>>>>> If the first resume works, the second (almost?) always will fail b=
ut
> >>>>>> with a different symptoms - dom0 kernel lockups (at least some of =
its
> >>>>>> vcpus). I haven't debugged this one yet at all.
> >>>>>>
> >>>>>> Any help will be appreciated, I can apply some debug patches, chan=
ge
> >>>>>> configuration etc.
> >>>>>
> >>>>> This still happens on 4.14.3. Maybe it is related to freeing percpu
> >>>>> areas, as it caused other issues with suspend too? Just a thought...
> >>>>
> >>>> I have reproduced this on current staging(*). And I can reproduce it
> >>>> reliably. And also, I got (I believe) closely related crash with cre=
dit1
> >>>> scheduler.
> >>>>
> >>>> (*) It isn't plain staging, it's one with my xhci console patches on
> >>>> top, including attempt to make it survive S3. I believe the only
> >>>> relevant part there is sticking set_timer() into console resume path=
 (or
> >>>> just having a timer with rather short delay registered). The actual =
tree
> >>>> at https://github.com/marmarek/xen/tree/master-xue2-debug, including
> >>>> quite a lot of debug prints and debug hacks.
> >>>>
> >>>> Specific crash with credit2:
> >>
> >> (XEN) Assertion 'c2rqd(sched_unit_master(unit)) =3D=3D svc->rqd' faile=
d at common/sched/credit2.c:2274
> >> (XEN) ----[ Xen-4.17-unstable  x86_64  debug=3Dy  Tainted:   C    ]----
> >> (XEN) CPU:    10
> >> (XEN) RIP:    e008:[<ffff82d040247a4d>] credit2.c#csched2_unit_wake+0x=
152/0x154
> >> (XEN) RFLAGS: 0000000000010083   CONTEXT: hypervisor (d0v0)
> >> (XEN) rax: ffff830251778230   rbx: ffff830251768cb0   rcx: 00000032111=
d6000
> >> (XEN) rdx: ffff8302515c1eb0   rsi: 0000000000000006   rdi: ffff8302517=
69000
> >> (XEN) rbp: ffff8302515cfd90   rsp: ffff8302515cfd70   r8:  ffff8302517=
69000
> >> (XEN) r9:  0000000000000000   r10: 0000000000000000   r11: 00000000000=
00000
> >> (XEN) r12: ffff830251768dd0   r13: ffff8302515c1d00   r14: 00000000000=
00006
> >> (XEN) r15: ffff82d0405ddb40   cr0: 0000000080050033   cr4: 00000000003=
72660
> >> (XEN) cr3: 000000022f2a1000   cr2: ffff8881012738e0
> >> (XEN) fsb: 0000744bf6a0db80   gsb: ffff888255600000   gss: 00000000000=
00000
> >> (XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: e010   cs: e008
> >> (XEN) Xen code around <ffff82d040247a4d> (credit2.c#csched2_unit_wake+=
0x152/0x154):
> >> (XEN)  df e8 6f bf ff ff eb ad <0f> 0b f3 0f 1e fa 55 48 89 e5 41 57 4=
1 56 41 55
> >> (XEN) Xen stack trace from rsp=3Dffff8302515cfd70:
> >> (XEN)    ffff83025174b000 ffff830251768cb0 ffff830251778270 ffff82d040=
5c4298
> >> (XEN)    ffff8302515cfdd8 ffff82d04024fcb8 0000000000000202 ffff830251=
778270
> >> (XEN)    ffff83025174b000 0000000000000001 ffff830251769018 0000000000=
000000
> >> (XEN)    0000000000000000 ffff8302515cfe48 ffff82d04020a8c9 ffff888255=
6aedc0
> >> (XEN)    0000000000000003 00001910537e623e 0000000b988f78a6 0000000059=
d4a716
> >> (XEN)    00001901f30fa41e 0000000217f96af6 0000000000000000 ffff830251=
74b000
> >> (XEN)    ffff830251756000 0000000000000002 0000000000000001 ffff830251=
5cfe70
> >> (XEN)    ffff82d0402f7968 ffff830251756000 ffff8302515cfef8 0000000000=
000018
> >> (XEN)    ffff8302515cfee8 ffff82d0402ec6de 0000000000000000 ffffffff82=
f157e0
> >> (XEN)    0000000000000000 0000000000000000 ffff8302515cfef8 0000000000=
000000
> >> (XEN)    0000000000000000 ffff8302515cffff ffff830251756000 0000000000=
000000
> >> (XEN)    0000000000000000 0000000000000000 0000000000000000 00007cfdae=
a300e7
> >> (XEN)    ffff82d0402012bd 0000000000000000 ffffffff82c51120 ffff888100=
36cf00
> >> (XEN)    0000000000000002 000000000001e120 0000000000000002 0000000000=
000246
> >> (XEN)    ffffffff82f157e0 0000000000000001 0000000000000000 0000000000=
000018
> >> (XEN)    ffffffff81e4a30a 0000000000000000 0000000000000002 0000000000=
000001
> >> (XEN)    0000010000000000 ffffffff81e4a30a 000000000000e033 0000000000=
000246
> >> (XEN)    ffffc9004aef7c18 000000000000e02b fb5ee398d214b10c eb5ef398c2=
14a10c
> >> (XEN)    eb56f390c21ca104 ebd6f310c29ca184 0000e0100000000a ffff830251=
756000
> >> (XEN)    0000003211016000 0000000000372660 0000000000000000 8000000296=
3e1002
> >> (XEN) Xen call trace:
> >> (XEN)    [<ffff82d040247a4d>] R credit2.c#csched2_unit_wake+0x152/0x154
> >> (XEN)    [<ffff82d04024fcb8>] F vcpu_wake+0xfd/0x267
> >> (XEN)    [<ffff82d04020a8c9>] F common_vcpu_op+0x178/0x5d1
> >> (XEN)    [<ffff82d0402f7968>] F do_vcpu_op+0x69/0x226
> >> (XEN)    [<ffff82d0402ec6de>] F pv_hypercall+0x575/0x657
> >> (XEN)    [<ffff82d0402012bd>] F lstar_enter+0x13d/0x150
> >> (XEN)
> >> (XEN)
> >> (XEN) ****************************************
> >> (XEN) Panic on CPU 10:
> >> (XEN) Assertion 'c2rqd(sched_unit_master(unit)) =3D=3D svc->rqd' faile=
d at common/sched/credit2.c:2274
> >> (XEN) ****************************************
> >=20
> > Ok, I think I figured it out!
> >=20
> > I added a function that verifies run queues of all the sched units, and
> > called it basically every other line on the resume path. The debug
> > function (if anybody is interested):
> >=20
> >     void verify_sched_units(void)
> >     {  =20
> >         struct domain *d;
> >         const struct sched_unit *unit;
> >        =20
> >         for_each_domain ( d )
> >         {
> >             for_each_sched_unit ( d, unit )
> >             {
> >                 if ( c2rqd(sched_unit_master(unit)) !=3D csched2_unit(u=
nit)->rqd )
> >                 {
> >                     printk(XENLOG_WARNING "d%d sched unit %d: rq=3D%d, =
unit master %d, rq=3D%d\n",
> >                             d->domain_id, unit->unit_id,
> >                             csched2_unit(unit)->rqd ? csched2_unit(unit=
)->rqd->id : -1,
> >                             sched_unit_master(unit),
> >                             c2rqd(sched_unit_master(unit))->id);
> >                     WARN_ON(1);
> >                 }
> >             }
> >         }
> >     }
> >=20
> > It appears that restore_vcpu_affinity() is responsible, specifically
> > this part:
> >=20
> > 1216         /*
> > 1217          * Re-assign the initial processor as after resume we have=
 no
> > 1218          * guarantee the old processor has come back to life again.
> > 1219          *
> > 1220          * Therefore, here, before actually unpausing the domains,=
 we should
> > 1221          * set v->processor of each of their vCPUs to something th=
at will
> > 1222          * make sense for the scheduler of the cpupool in which th=
ey are in.
> > 1223          */
> > ...
> > 1249         res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)=
));
> > 1250         sched_set_res(unit, res);
> > 1251=20
> > 1252         spin_unlock_irq(lock);
> > 1253=20
> > 1254         /* v->processor might have changed, so reacquire the lock.=
 */
> > 1255         lock =3D unit_schedule_lock_irq(unit);
> > 1256         res =3D sched_pick_resource(unit_scheduler(unit), unit);
> > 1257         sched_set_res(unit, res);
> > 1258         spin_unlock_irq(lock);
> > 1259=20
> > 1260         if ( old_cpu !=3D sched_unit_master(unit) )
> > 1261             sched_move_irqs(unit);
> >=20
> > It calls sched_set_res() directly, which assigns sched resources, but
> > does _not_ adjust runqueues (if new pcpu happen to be assigned to
> > another runqueue than the one from previous pcpu).
> >=20
> > I have two (non exclusive) ideas here:
> > 1. If old_cpu is actually still available, do not move it at all.
> > 2. Use sched_migrate() instead of sched_set_res().
> >=20
> > Here is the patch that fixes it for me:
> > ---8<---
> > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> > index 83455fbde1c8..dcf202d8b307 100644
> > --- a/xen/common/sched/core.c
> > +++ b/xen/common/sched/core.c
> > @@ -1246,19 +1246,29 @@ void restore_vcpu_affinity(struct domain *d)
> >              }
> >          }
> > =20
> > -        res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)));
> > +        /* Prefer old cpu if available. */
> > +        if ( cpumask_test_cpu(old_cpu, cpumask_scratch_cpu(cpu)) )
> > +            res =3D get_sched_res(old_cpu);
> > +        else
> > +            res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)=
));
> >          sched_set_res(unit, res);
> > =20
> >          spin_unlock_irq(lock);
> > =20
> > -        /* v->processor might have changed, so reacquire the lock. */
> > -        lock =3D unit_schedule_lock_irq(unit);
> > -        res =3D sched_pick_resource(unit_scheduler(unit), unit);
> > -        sched_set_res(unit, res);
> > -        spin_unlock_irq(lock);
> > -
> > +        /*
> > +         * If different cpu was chosen, it was random, let scheduler d=
o proper
> > +         * decision.
> > +         */
> >          if ( old_cpu !=3D sched_unit_master(unit) )
> > +        {
> > +            /* v->processor might have changed, so reacquire the lock.=
 */
> > +            lock =3D unit_schedule_lock_irq(unit);
> > +            res =3D sched_pick_resource(unit_scheduler(unit), unit);
> > +            sched_migrate(unit_scheduler(unit), unit, res->master_cpu);
> > +            spin_unlock_irq(lock);
> > +
> >              sched_move_irqs(unit);
> > +        }
> >      }
> > =20
> >      rcu_read_unlock(&sched_res_rculock);
> > ---8<---
> >=20
> > I have several doubts here:
> >=20
> > 1. If old_cpu is available, is sched_set_res() needed at all?
> > 2. Should both calls be changed to sched_migrate()? Currently I changed
> >    only the second one, in case scheduler could be confused about
> >    old_cpu not being available anymore.
> > 3. Are there any extra locking requirements for sched_migrate() at this
> >    stage? The long comment above sched_unit_migrate_start() suggests
> >    there might be, but I'm not sure if that's really the case during
> >    resume.
> > 4. Related to the above - should thaw_domains() be modified to call
> >    restore_vcpu_affinity() for all domains first, and unpause only
> >    later? That could reduce locking requirements, I guess.
>=20
> All questions primarily to the scheduler maintainers - forwarding
> accordingly.

Ping?

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--hvm1Jo/UDaOd/PS4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNFUecACgkQ24/THMrX
1yys5Qf7B2NMRdG9dd8xg5U0EY55HEQr+gFJFba6hJpUA/AykYhirKQkHdYchiUj
dZDgxY1O1LeJuST+zw9TEF4QmoczNwO1d9aIwSGjH+GDmcpd5MCUS0rAqNKYEd8F
/p7yTf4yc4SwhaVUY/f9EJEPsdB9rY2D9b+BhbK8Fs6aLfDA/gd+z3I+C0nlzCor
bOrDZfbCpJtgWUhmRVGZxl0ily1l8vWpeYn2wMrgPktWR5iJzc6bsAFZYtwMqOk5
ouESkOZLhb/Xe4anP7IXsvGZmu+iseRIUgfoyDAk1nh4pAporVRkW8qSOhpB5ojD
/6I2HKl5EI5jwFH1KIOgLKt9IMcahQ==
=2bdb
-----END PGP SIGNATURE-----

--hvm1Jo/UDaOd/PS4--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:26:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:26:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419621.664446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDP8-0001ZF-DB; Tue, 11 Oct 2022 11:26:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419621.664446; Tue, 11 Oct 2022 11:26:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDP8-0001Z8-AB; Tue, 11 Oct 2022 11:26:34 +0000
Received: by outflank-mailman (input) for mailman id 419621;
 Tue, 11 Oct 2022 11:26:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiDP7-0001Yy-DD; Tue, 11 Oct 2022 11:26:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiDP7-0008M3-AX; Tue, 11 Oct 2022 11:26:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiDP6-0002Mc-R2; Tue, 11 Oct 2022 11:26:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiDP6-0006k0-QZ; Tue, 11 Oct 2022 11:26:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IZCpgnMBezMBdZGdz6VgZBmVOcAnOzajxfEz7VU6Xgs=; b=pmUAGBlJAYcWtMQRmE8MM+j+nN
	7V0No9kl7LRs7aRJtdSc1ry7Tg3Q2Oy+KetsUq8Yl2lyoF7167RXJlKQ4CGnRLoZn8reHqp37Xutb
	cAa6QSR68DTzUcf9RCn6LkQOD31qmr3GQH9ox18fVqzezNL/7S1MfIOPcjz5nnx/XgA8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173489-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173489: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=27bc50fc90647bbf7b734c3fc306a5e61350da53
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 11:26:32 +0000

flight 173489 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173489/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                27bc50fc90647bbf7b734c3fc306a5e61350da53
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    3 days
Failing since        173470  2022-10-08 06:21:34 Z    3 days   11 attempts
Testing same since   173489  2022-10-11 02:42:09 Z    0 days    1 attempts

------------------------------------------------------------
900 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 83035 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:27:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419639.664458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDPv-0002FQ-Nl; Tue, 11 Oct 2022 11:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419639.664458; Tue, 11 Oct 2022 11:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDPv-0002FJ-Kl; Tue, 11 Oct 2022 11:27:23 +0000
Received: by outflank-mailman (input) for mailman id 419639;
 Tue, 11 Oct 2022 11:27:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=s0xJ=2M=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1oiDHb-0005JI-Dk
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:18:47 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77c9da8f-4956-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 13:18:44 +0200 (CEST)
Received: from AS8PR04CA0037.eurprd04.prod.outlook.com (2603:10a6:20b:312::12)
 by PAXPR08MB6431.eurprd08.prod.outlook.com (2603:10a6:102:157::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct
 2022 11:18:42 +0000
Received: from AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:312:cafe::85) by AS8PR04CA0037.outlook.office365.com
 (2603:10a6:20b:312::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Tue, 11 Oct 2022 11:18:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT056.mail.protection.outlook.com (100.127.140.107) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:18:42 +0000
Received: ("Tessian outbound ce981123c49d:v128");
 Tue, 11 Oct 2022 11:18:42 +0000
Received: from 6c97752c028a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D66A348E-1FB8-413A-943A-806BE4E632C8.1; 
 Tue, 11 Oct 2022 11:17:31 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6c97752c028a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 11:17:31 +0000
Received: from FR0P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::19)
 by AM8PR08MB5617.eurprd08.prod.outlook.com (2603:10a6:20b:1dc::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 11:17:30 +0000
Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1e:cafe::35) by FR0P281CA0079.outlook.office365.com
 (2603:10a6:d10:1e::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:29 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 11:17:29 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 11 Oct
 2022 11:17:28 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Tue, 11 Oct 2022 11:17:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77c9da8f-4956-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=JPxNdC5RT7RQwy3YaHeh5xp1o5z7Qkbb+l5pj2a+Fk300Gs7h9aEgWZbUXG9t6bUsPZQ0LBl1vfY7uxTqP1IZMxP170YKTklMBlvTsLRqh2MRYHfoIlg3nnaBEqG1OrnoNNaqDZF29NgF/5HSKCFCIPBiKu9bJt3CpDwmFSNo1GgHIgbn5tC+ZSuLVUVuIo7hP5ErVMV1Ccxso4rqaY6/YVhs2suwqi8ne6be9U+sCCThsjv4FGS13DC8FFhUlVUNRE6YPy30lwnNkIyLhYHs4FP8hWYj+Wv2bTb3c0KiNweWX0NxBBB3UMulMDhdUXfW3OQBnxr86Mdl3U50AWJTg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ap0di6Khvem8tyXcEgez0sUBnboUdmih2D7MHTKX98U=;
 b=HnKafNJ/8Q99uwCPL+vU3Mp3ejLjaRTK1BCXwqFptI05UQZ0oOrwQ0xWVoW9+i3sEM7IdOoXPu7pplTZU7qdEyK+5/Mj0w0QzRGaFFHw1Xabhtal63ZX1uM1D5lTmIjWeje/Nl1HWxdS3sQKFqmWZVDnwVJR/C+0t8MyHmmgmaqmGqfabmGOXS8SB0rYc+CAhCmJzRyjx0s6EAuLSNaQGi7EPlIkmpf4lmp2wFalYM63xbALWDFPep/7IHIEKaR2un0r8VfEIk0nTbOrQjF3RZ4y2XTttc+QoB2UFLxkdjdQQB807EmXvGzpgrffk6poOVjxCjQxQVd1+tG1kXRPLA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ap0di6Khvem8tyXcEgez0sUBnboUdmih2D7MHTKX98U=;
 b=cUslA7IH2Ya8h2D8+lWnU2leL5n0Bd3OqrDl+oj63z/S0RUBzVTjtmdhTfVrly2PG3u+Rt1pj0sJceKqyO/X3Z047U7JOOZEvzvVBb3ttpTYm28lRqtvHJK2zddB17Jv7WYfQSM28jJV3IAVNDWR/LUrx5pQLxQ+xvHkea16vFk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: a3e15ecbbd01f2b2
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F1JqgZwjOGTIHmnd9VdUhTyGiFxvNOeENwMzPlLcFSRvH2eln6stqA0lvAB+ls44tcQvEY65DCvzzfPl2GOdKpN/QLwQqfFobpk+Ve2fRVH4JhIiD+eiSJh/KcUsC8u11W59vOu+Py/5KVCvoyA3zfot7ekoEpnshSkSI0PyPQKZ2KoWKkGYnk3Fn78cJQvnCQ9Aq/cHXYZ6v/kWFEFP0132i3f/QUdPgizyTlvt7myjbcRDp6bGCcFKA77Wc37DivIsP4zISB2KOEpyzkRjSBDOO7RsDVIWruMuSwZ3sYzZIJjXtIpYf8O6dtvzf2ZixMEjqTZTgx+4agXmd4IsNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ap0di6Khvem8tyXcEgez0sUBnboUdmih2D7MHTKX98U=;
 b=FY8ehMI2ElLo0B3C/szZ9hhbsqxOE6y2epKUdXVYLU7GVXuxXOmCKo5CeIGJXXuyU2O3hG8JuLmWpsbr8TntdbAghpZtyN9lATx7vKgpW8vtmzEJst5aiHBr6Tg+li7a0OzOwjf07qkGujJdn/nxSc2j+lxm+h78o5VLyIJEr5dkOE9GTY2NNky2yGXglyrsxqDmoOlfaaHINS/dGlmWfFH5vRFvFqHfiQyL7ABba7MP2FLQu5aqu+WxlNTEg+KAhVOO1469qNdxi0ZJytRBgkxWKmK4JlKQbGNtMHNIxCTnU3w7ZGAqrQ6kcxDVTkX271SMTN18Kol+WKObaALM5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ap0di6Khvem8tyXcEgez0sUBnboUdmih2D7MHTKX98U=;
 b=cUslA7IH2Ya8h2D8+lWnU2leL5n0Bd3OqrDl+oj63z/S0RUBzVTjtmdhTfVrly2PG3u+Rt1pj0sJceKqyO/X3Z047U7JOOZEvzvVBb3ttpTYm28lRqtvHJK2zddB17Jv7WYfQSM28jJV3IAVNDWR/LUrx5pQLxQ+xvHkea16vFk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v6 1/6] xen/x86: Provide helpers for common code to access acpi_numa
Date: Tue, 11 Oct 2022 19:17:03 +0800
Message-ID: <20221011111708.1272985-2-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221011111708.1272985-1-wei.chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VE1EUR03FT040:EE_|AM8PR08MB5617:EE_|AM7EUR03FT056:EE_|PAXPR08MB6431:EE_
X-MS-Office365-Filtering-Correlation-Id: 3cffe94f-17ac-40a9-3d36-08daab7a5afe
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 oSABmc7VCUyomQZl3ZnYTe/VPSe4Izlyf9kSE7yQvve75dejXyN46T2Arg4y8D1Ka/8ckjkGxriXpiZO9aspNBmsGoZkgFee4LqViBQlzFGRRyKBMlBYGKMKFM9H2xrw05B3Ddg/+vjapgqwEmEuLJszzYgcECb6kX66K2P720Vyldcaz2V1PGhuosgVRzqwRaD4oqJ/7dbZAUQf9ls9rnqHL9MoPSuq9+ptB9AlUB3dQwrYHL/+vYBFhIhI+d40W/7gJ0GMt3WYKK0ubb8T7Li+l7dgbsdWcvCg6L/k4csevri2/HMrKNLXX3dwOxSXSQ7D6Bco8KSUJvBxLHveFVBW1KPgQcpDimzEb6HwDFzyUUZQ1Rp1j4szv7IUJXONfaBguBh8Xb6N7gH5WMeeSal6kt+h61O0OjVqSP8Pak0AlaRYz2VPCI1GarsUotR5pYSwbeFFWMh/T32wkwM0GdQEElUUNpPKbWa4EcOMJ+xipkx0Y9DrwZQ+BlDjUV9fvSWcnJM6a7U9cw5edN08vDYQtwnDBrwT5M8atXrEcJqUrrzN8BBzVznJHlwX44FYVSn3+UIdRmOZbBWaCk5DXZN0y5qakKElqXPVoc+oqPbB+7fW/L1pQej/fZEQNFMhjSgQBt/x6PWkk0VE7lAblyqDOu0FJraVX65l7j3OJXNxPg1E12PVMsHsAZEfk5l9/UECM5dYaL/2GkiGTMtMCpBy8i8p0zvL2NZD8+8t2v1acYgINsvfadkHB6XmLeqPHTf982Rtn4EwPcwcCsOp3ioQ9VdTX83iFCVHKtANMzhRMOCxvpPljvht5Li6oOJh
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(86362001)(81166007)(356005)(36860700001)(82740400003)(36756003)(2616005)(336012)(426003)(83380400001)(40480700001)(44832011)(40460700003)(2906002)(478600001)(7696005)(26005)(6666004)(1076003)(186003)(8676002)(8936002)(70206006)(47076005)(82310400005)(70586007)(316002)(6916009)(54906003)(4326008)(41300700001)(5660300002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5617
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6e694e78-ebd8-4466-708b-08daab7a2f92
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1Rtuta59U8Zr+DjFSbbI8O08TCLDx22qlagG96HoI+UVABXATTtmFgs0a4St30HguNCbrAWXeRcKoLQlEKANsxPhBgzvQhQXl7BXcHarQjS8xImH8na3BfHPwlnFPwu27UPuTspav6C1sjR66AUopQgwk1kWKiqPM2PmR2uF0G/TYp6gi8h6A1GwFcENudSSYOb08krOSynbO2Ncw8f+RBsleSfdiUkgW7cS5G2KtQSIZHLFPrg9ESrssLqjcrExTmEDTjCnMZI2NxiCVfkF6q4y5UJcJvVKA8Grl9RvI5WbczZloX2aXo0j/UoVGR9Sz0MZPVvpHtE9aD/HPv4OYjBmlxKTFjXzL/Ahn5NaU3ELCn9oo5buGS0QJYyiofIO2qtCBT2/w6E5yP5/DJ7+etQYhqeVYEL5pq7ckTgZ8ylOEHJMyOA/o+TCclTfUVV4ef0QBwDWAOugudPlgzty8VB6239w+u3bJSQTTijE50sjZeU2GaqG9YYE6egxtAzeVJcgyA8QZ/yMJTtYLJJoR//NVY0np6hnpAuetRsHjIQqtyAMeR/phkN760QG7u7vi+BFoED2A5BDn88b9vOXUhglcgsV2Mn9z+BsM8oaB76aqrNxj/KSAqzwJbAzr0iwnF/B5btPOyjxoFEwZDmJPFSUWWPMZNkKiIqNIkaaN1hwt8xc6rKJAcZMbJk2ZHV9JxVnVsM2HVZaau1NHtDknpHBe6zV0jM8j8LKIfNBAiSGo2v/cCH61JNR2pxzyts06JQIOuEktidLC4PhirEWIQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(26005)(7696005)(40460700003)(41300700001)(2616005)(8936002)(186003)(1076003)(6666004)(36756003)(426003)(82310400005)(8676002)(336012)(83380400001)(478600001)(316002)(54906003)(6916009)(81166007)(44832011)(5660300002)(47076005)(4326008)(70206006)(70586007)(86362001)(36860700001)(2906002)(40480700001)(82740400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 11:18:42.6692
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cffe94f-17ac-40a9-3d36-08daab7a5afe
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6431

acpi_numa is a specific NUMA switch for ACPI NUMA implementation.
Other NUMA implementation may not need this switch. But this switch is
not only used by ACPI code, it is also used directly in some general
NUMA logic code. So far this hasn't caused any problem because Xen only
has x86 implementing ACPI NUMA, but now Arm is implementing device tree
based NUMA. Accesssing acpi_numa directly in some functions will be a
block of reusing NUMA common code. It is also difficult for us to replace
it with a new generic switch, because it is hard to prove that the new
switch states can guarantee the original code will work correctly.

So in this patch, we provide two helpers for common code to update and
get states of acpi_numa. And other new NUMA implementations just need
to provide the same helpers for common code. In this case, the generic
NUMA logic code can be reused by all NUMA implementations.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v5 -> v6:
1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa
   can be set to -1 by users. So acpi_numa < 0 does not mean
   a broken firmware.
v4 -> v5:
1. Use arch_numa_broken instead of arch_numa_disabled for
   acpi_numa < 0 check. Because arch_numa_disabled might
   include acpi_numa < 0 (init failed) and acpi_numa == 0
   (no data or data no init) cases.
v3 -> v4:
1. Drop parameter from arch_numa_disabled, the parameter will be
   introduced in later patch where use it.
2. Drop unnecessary "else" from arch_numa_setup, and fix its
   indentation.
v2 -> v3:
1. Drop enumeration of numa status.
2. Use helpers to get/update acpi_numa.
3. Insert spaces among parameters of strncmp in numa_setup.
v1 -> v2:
1. Remove fw_numa.
2. Use enumeration to replace numa_off and acpi_numa.
3. Correct return value of srat_disabled.
4. Introduce numa_enabled_with_firmware.
---
 xen/arch/x86/include/asm/numa.h |  5 +++--
 xen/arch/x86/numa.c             | 38 ++++++++++++++++++++++-----------
 2 files changed, 28 insertions(+), 15 deletions(-)

diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index c32ccffde3..237f2c6dbf 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -32,8 +32,9 @@ extern void numa_add_cpu(int cpu);
 extern void numa_init_array(void);
 extern bool numa_off;
 
-
-extern int srat_disabled(void);
+extern int arch_numa_setup(const char *opt);
+extern bool arch_numa_disabled(void);
+extern bool srat_disabled(void);
 extern void numa_set_node(int cpu, nodeid_t node);
 extern nodeid_t setup_node(unsigned int pxm);
 extern void srat_detect_node(int cpu);
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 322157fab7..1c3198445d 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
 bool numa_off;
 s8 acpi_numa = 0;
 
-int srat_disabled(void)
+int __init arch_numa_setup(const char *opt)
 {
-    return numa_off || acpi_numa < 0;
+#ifdef CONFIG_ACPI_NUMA
+    if ( !strncmp(opt, "noacpi", 6) )
+    {
+        numa_off = false;
+        acpi_numa = -1;
+        return 0;
+    }
+#endif
+
+    return -EINVAL;
+}
+
+bool arch_numa_disabled(void)
+{
+    return acpi_numa < 0;
+}
+
+bool srat_disabled(void)
+{
+    return numa_off || arch_numa_disabled();
 }
 
 /*
@@ -294,28 +313,21 @@ void numa_set_node(int cpu, nodeid_t node)
 /* [numa=off] */
 static int __init cf_check numa_setup(const char *opt)
 {
-    if ( !strncmp(opt,"off",3) )
+    if ( !strncmp(opt, "off", 3) )
         numa_off = true;
-    else if ( !strncmp(opt,"on",2) )
+    else if ( !strncmp(opt, "on", 2) )
         numa_off = false;
 #ifdef CONFIG_NUMA_EMU
     else if ( !strncmp(opt, "fake=", 5) )
     {
         numa_off = false;
-        numa_fake = simple_strtoul(opt+5,NULL,0);
+        numa_fake = simple_strtoul(opt + 5, NULL, 0);
         if ( numa_fake >= MAX_NUMNODES )
             numa_fake = MAX_NUMNODES;
     }
-#endif
-#ifdef CONFIG_ACPI_NUMA
-    else if ( !strncmp(opt,"noacpi",6) )
-    {
-        numa_off = false;
-        acpi_numa = -1;
-    }
 #endif
     else
-        return -EINVAL;
+        return arch_numa_setup(opt);
 
     return 0;
 } 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 11:42:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 11:42:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419650.664469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDeP-0004qD-62; Tue, 11 Oct 2022 11:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419650.664469; Tue, 11 Oct 2022 11:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDeP-0004q6-3N; Tue, 11 Oct 2022 11:42:21 +0000
Received: by outflank-mailman (input) for mailman id 419650;
 Tue, 11 Oct 2022 11:42:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lIFp=2M=denx.de=pavel@srs-se1.protection.inumbo.net>)
 id 1oiDeN-0004q0-Ll
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 11:42:19 +0000
Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c1914434-4959-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 13:42:17 +0200 (CEST)
Received: by jabberwock.ucw.cz (Postfix, from userid 1017)
 id 9C7A91C0025; Tue, 11 Oct 2022 13:42:15 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1914434-4959-11ed-91b4-6bf2151ebd3b
Date: Tue, 11 Oct 2022 13:42:15 +0200
From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Kees Cook <keescook@chromium.org>, Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
	nathan@kernel.org, ndesaulniers@google.com, llvm@lists.linux.dev
Subject: Re: [PATCH AUTOSEL 4.19 5/6] x86/entry: Work around Clang __bdos()
 bug
Message-ID: <20221011114215.GA12851@duo.ucw.cz>
References: <20221009205443.1203725-1-sashal@kernel.org>
 <20221009205443.1203725-5-sashal@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv"
Content-Disposition: inline
In-Reply-To: <20221009205443.1203725-5-sashal@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)


--ZGiS0Q5IWpPtfppv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Kees Cook <keescook@chromium.org>
>=20
> [ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]
>=20
> Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=
=3Dy
> and CONFIG_UBSAN_BOUNDS=3Dy when operating on an array with a dynamic
> offset. Work around this by using a direct assignment of an empty
> instance. Avoids this warning:
>=20
> ../include/linux/fortify-string.h:309:4: warning: call to __write_overflo=
w_field declared with 'warn
> ing' attribute: detected write beyond size of field (1st parameter); mayb=
e use struct_group()? [-Wat
> tribute-warning]
>                         __write_overflow_field(p_size_field, size);
>                         ^
>=20
> which was isolated to the memset() call in xen_load_idt().
>=20
> Note that this looks very much like another bug that was worked around:
> https://github.com/ClangBuiltLinux/linux/issues/1592

At least in 4.19, there's no UBSAN_BOUNDS. Sounds like we don't need
it in old kernels?

Best regards,
								Pavel
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -752,6 +752,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
>  {
>  	static DEFINE_SPINLOCK(lock);
>  	static struct trap_info traps[257];
> +	static const struct trap_info zero =3D { };
>  	unsigned out;
> =20
>  	trace_xen_cpu_load_idt(desc);
> @@ -761,7 +762,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
>  	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
> =20
>  	out =3D xen_convert_trap_info(desc, traps, false);
> -	memset(&traps[out], 0, sizeof(traps[0]));
> +	traps[out] =3D zero;
> =20
>  	xen_mc_flush();
>  	if (HYPERVISOR_set_trap_table(traps))
> --=20
> 2.35.1

--=20
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--ZGiS0Q5IWpPtfppv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY0VWlwAKCRAw5/Bqldv6
8ohVAJsF4vk8+1nzRcz7J6Zq4UFdI6Kl8ACffFGKzc5xIB2EYvVi0yKvMcv+Y2Y=
=eeGa
-----END PGP SIGNATURE-----

--ZGiS0Q5IWpPtfppv--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:00:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:00:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419657.664479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDvZ-0007P7-1p; Tue, 11 Oct 2022 12:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419657.664479; Tue, 11 Oct 2022 12:00:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDvY-0007OO-V9; Tue, 11 Oct 2022 12:00:04 +0000
Received: by outflank-mailman (input) for mailman id 419657;
 Tue, 11 Oct 2022 12:00:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiDvY-0007DV-D0
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 12:00:04 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130053.outbound.protection.outlook.com [40.107.13.53])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3cfb5adc-495c-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 14:00:02 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8852.eurprd04.prod.outlook.com (2603:10a6:20b:42f::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 12:00:01 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 12:00:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3cfb5adc-495c-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LGh+6mIDFH03iyWvLNoDUhDHfXY3QVuY83jbw7u+aQSi6ga/kBxCB2zr1XSi0yyetJpJEQjAP61EuX06pEV6k+yuAWtGgQZ4WD2ko2mt5p9KKhZ5c926zJ8ALSMEW7MVIOKq2Kjg8qceiGTw2iwn/z9XW28RDXVYrUC4Jlwsebc6OS1vDxpdB77UO4+aKemT+vUMzE/44YSikVuiL0agRuPBLrQEax6zflWHL9l3f3Z2wi8U0Oc5SYR1UqMRLGHhP6ynkgW+WVg5bFLldVHsESty9bWx4FD/JQgQGTCXvhfmCHSyTdxJw7BIQ/RD4CN+PzhRvGSZhF+CCfTnihNb7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XatgHpPKUxXVOOyNfudNkIqba4tIM7LNzz3DahNNyR0=;
 b=e6L51KQusJJNldmen6TAMC9P4f7DA01DBQrXVMfQwsXJOfjharkdBcGe5m6UFKE56LnN6uSoYLTDNtQRKs03PEp7Qxnd+c3cVqG09U/N5+SCZjM08YrRrDU7h3P6oK9SID6Dn5Hor2us8ppxUYfRCcJQd0equEj6zpqaKjdJzqft2xEqUf4AlUy8QeOVPk86sEzh8OYBZrr6u35A9eU+i5vtSlCm2DanQZCmwMnrGc9WZEGKiu5xy2PgpBCSTCmmcJ6VF/ksArqWbw8z5GFzIKKQCSGpX3+k9vi9PAWWYfFXKL63ILOzQdgKxuDEH6jKNsQSZEtMOOq5NDTmSYCxpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XatgHpPKUxXVOOyNfudNkIqba4tIM7LNzz3DahNNyR0=;
 b=N10kQ7aWG7Pt8K9jOQ00NlhjCDvl+Aw00OeSRhUBenfgcX0tTZSJ0PgTk8ObPmNqTGmwwyh7+V6tKOjnz4RvHvu7Fsbhm3PSvJKqfLtB1jVyhW52ytxR0LtZwL77sYmDGHzuRi2ypqCSp163Jk4DGRmneTsQngW4K64QfHEtLe5A7c8msjUBH/WbiOgqYHRB9CZUENr954razsBDNmtp22Yo9Nh3axXwTF24Q6fQpQOkjd91KEmkZ35L6N43cbYJ0TFwhEKQ7odnSx7CTdWGDkN0mfDZ0RXY+pbkYAtHwKiz7kzQS0Gst0DZmYmhvNLq8fqAUTAzKDcJJTmtCMfn5w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
Date: Tue, 11 Oct 2022 13:59:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20220716145658.4175730-2-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0020.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::33) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8852:EE_
X-MS-Office365-Filtering-Correlation-Id: 2bc76c25-4e57-438f-1966-08daab802016
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D4660kSBaPXqPuncWIUVR1OhuIwP2UnAtPUauIzeapsi8xAihE/vTcCpaZt8NRmC+NUhC0Tgit51XrchRfs0GaV1eLb2pwVSwpyg0d/XZn6nyY2M1F5Iy+OETNQaLfYilhVR77CCcbyjzx6nTZZKoobg3KFUeFAsAnmyXAeqIZIZDAJLOR1EuYphVIfHOTiEatO5FhhVBG1G1yPi35zEmn4rwoo987cA63FnAySInrUMwPuWagm7ToQXHf1tZsiaH+U4VfnMuRc8Yax+hHtUipL+d+b2Vn20WMZI38Py4UCC9QggYZsg55Xfvynn68uucp1BIUu6ZTYtR0D+jrYtaw4Kjc7PJdTcDGL7iwZeaPGVUeLZjVuGe8VK0wYTqaqgtBQkjypTIpp3p80bhGLoI0Ta1XvN3C4BvfprEHKhCdRYzxuoKe3OjUaRbCkuscUkJPuxLfWVzuXCTZJCWmljH+mVLdSEyqxBKcXmSpb4OlXLr/K8bT8Q0wcC5hb2y662dW5lrKWDiE1EHMUGe5vFNDnMEFFbGkor+eNVgD8LXKT9tz3/Q1IfiWt4Zlh0F3N0FdU3hqdZblm4yBBCUEmSCcYAakrnoOgztdE8smqEHwWKgO3Uvp1mPQrh7fYv6p/briu3NiU8TGy3c4EZ7IhEEswj8Fv1XEoa9dFgwx+AHcpZx1Kd9WUpcAaxrjymT+cFDJNdtIDrT+juayhtQEvF3a7KhjSa1De1WnlZ2auWZMNPiK4zrG8lkIejjUZqcnQ6Y+oygnisVnA0612j8PT2kTh1bERs35vd8Ubxx+lhTeA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(31686004)(6512007)(26005)(6916009)(54906003)(316002)(86362001)(38100700002)(6486002)(36756003)(66556008)(83380400001)(2616005)(53546011)(6506007)(7416002)(8936002)(31696002)(5660300002)(66946007)(8676002)(186003)(41300700001)(66476007)(478600001)(4326008)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VTJHaHJrdUxPVDMyczgrRUxjdkJyR1Axbnh4NzZKeTlFMHY4RDRtN2JFWDFE?=
 =?utf-8?B?ZjN6SDNuL21nT0ZpMGxrejE5Zk5ZTjRHcGdRMDY5N21KWjhELy9qOHY3OU0r?=
 =?utf-8?B?UjFvekZpbyt1clE4Tmhzb3JVT25waTFRYThxQXo0Y2JSUDg3RzlVNnNHd2Mz?=
 =?utf-8?B?SlI4WlRYM09YZHBqamYySkdqN01TZ3EvdjZ3VWN3QXpibHVYL2tmbHZOTUty?=
 =?utf-8?B?NlFvWkJSYUdndmVoMWxLUzFqNCtvOUxqTGNVSWxGVVNRakNhVDlLNWl3TkJS?=
 =?utf-8?B?eEZZT1orbTkyTUFDWjFrdEhtVkF1eU5nQjh4ZW9WRzNPallMTFdyYXR4UzFC?=
 =?utf-8?B?VzZseVVSdXdVejNYRFZOOFkrTFRSeENtZzBVODZyMmg5SlF1NVhMQzVCVTFG?=
 =?utf-8?B?N3Z0TkE3dEoySFhJNXlVKzlkUW1hV2xTN3RmU2NBR3JodXd5SGlDREJTV1N2?=
 =?utf-8?B?eVVPUmFpNnhDcEZkWE1SMkNVekpJWEZkdEFHTzJSN3JkcXBPS0xOd043UXdD?=
 =?utf-8?B?dENWckQxMm5rUWN5bnErZHVxSXpzMjl5MlBVSUs1L3VnWEZuQmNSNitxSHRQ?=
 =?utf-8?B?VnNlaWtsSXJVK1BoY0tvR3NqcHJKSFRHbUwwZjIwL25rQko5TDNURVF4WWMz?=
 =?utf-8?B?eklUeURSZlgrVTU5Nmw4MExFOVNOcVBVT0RrL0w0YlVORzlBMHpid1NOUnda?=
 =?utf-8?B?NkYvQ2ZPMy9vQS9KZWFKYnZuYnYwc0M0eE04dGpTNHE0M0pQZVlJeFFEbDVF?=
 =?utf-8?B?a3UyVldhS3NYQ1hoRzRuOHpNV0c1c2dXMXhkY2RtN004TXZqbU5RVXJFQmhI?=
 =?utf-8?B?OHlNRzRvZk9mMFIrNnlTN0xiT01xRHJnTnJkb0lRc3p5eHR4OTF1UnlGQW9N?=
 =?utf-8?B?SFQ4Z1dOV1JLc0U3bkE3Nm1uUUEzSnJadm5EZ3Z1ZGh5UC9lYjMvVmpQTUVi?=
 =?utf-8?B?enV0cHE0b0xkZUMwSWREYlRkU29tS3l2S2MzRGFtTFdvUHpVRjUxOFJ2cHo5?=
 =?utf-8?B?NGFiM1ZvYWxFdVFhYU5xaGlpQ2Z0MkxjYkVpWWxXRVBmaHN2a2dFUTI1MVlM?=
 =?utf-8?B?ZUVhUDNSdXc4Z2ZCVXlsOGtueUxwMzFtNlhES2NEWkZFd2l0TUN5aFlJM0dz?=
 =?utf-8?B?VGhKemRuRkhJejRrcW1CU2hDeDhDSkt3NEY0UG82K0hEZ25QTFdaaTgxVXRn?=
 =?utf-8?B?QXFFb0t3ODc0VEVMb1E1VXlZbGtaSDI3NUtENnlLMWhmOXVvb25pT0tJTkVa?=
 =?utf-8?B?NXVKZjFNZ0V2ckMyc0RCWlNaa0cwR0V6OWx0a1NDaDBsZmhPSGQyS2c4M3ZX?=
 =?utf-8?B?Sk42THo4NXR0N3Y1MnpDbTkya0RvWmlWWldHcmhHZXM1eCswQWs1K2FlUjJS?=
 =?utf-8?B?VGpDMFI1VlZmNklKT2hLdW9IQndFS1FFakhPSlV3blJUN0laUFBWd0xPNC9h?=
 =?utf-8?B?b3VOd3l4ZVdxOFhkL0l5OWVuMFFhU2ZiYTdjQUJaZ0lBSFRTbXphaUh4ZEZ6?=
 =?utf-8?B?M2tsWGdZdldrVVh5VFZTZSs1SjkwOEtoc0FlQURZaVZ0cTRoNDJPRFNCR20r?=
 =?utf-8?B?YVF0ZWhuMHd6OHRkcytDdUJSOUYyVVlMZ3ZkQ213cmp1ZFRQa3k3NmxKMlhO?=
 =?utf-8?B?T2tiVkxnREFZVE8xcXJKekl4QjNpakVpMkdsMlB5U0JqQUlGQ2Rad2o4Um1s?=
 =?utf-8?B?V1poYWtxNHdGYm90T1ZhYk80SThyYW1FNzlCQlZLeWN2RGdXZUxkYkVxNUJN?=
 =?utf-8?B?MXc0NGxZK05rVG1pbXQxS2MvUERINGs5TS82ZVg1aG1nOTN3TE9Mbzh5d29V?=
 =?utf-8?B?ZGo0MEdzQXNRcFV3cVFONW5vRVk5N2JTaWk3SHcyNTR1cGxPdmw1Sm9qOXQy?=
 =?utf-8?B?UFFqYXdmZ1Z0YUxPM0hzYVAzWkVJNFpYV3FzZi9wYVhhZjJ6VWlwNUtjYXhQ?=
 =?utf-8?B?OFZHM1U3N2o0cWUvaHBwbFJLRU1NNy9WQlkxQ21YSXZhK0F2cHE2bEhWRHdX?=
 =?utf-8?B?TzBOZGNaSi9IVDBYMURVMmpHdTVueURQa0NlUHlneEVKNzlZa3ZWdEdFdHYz?=
 =?utf-8?B?WVRsZFh0SzBqaUJXSkxDRkNZRHc2ZmVoWVdSRnJCN0JDOVFDVmtKZlFUVnM1?=
 =?utf-8?Q?uV2X3Hbp011KBaTzDKRBobC2v?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc76c25-4e57-438f-1966-08daab802016
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 12:00:01.0704
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mmmLVQGgFxQ4H8AWJn4zfmUMFcW3apCSTYH3PdnN39jJR/M6o+h6rqKzprLyjVkecS5HBNcAnL7VIncNeHyM/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8852

On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Rework Arm implementation to store grant table frame GFN
> in struct page_info directly instead of keeping it in
> standalone status/shared arrays. This patch is based on
> the assumption that a grant table page is a xenheap page.
> 
> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
> to hold 52-bit/28-bit + extra bit value respectively. In order
> to not grow the size of struct page_info borrow the required
> amount of bits from type_info's count portion which current
> context won't suffer (currently only 1 bit is used on Arm).

I'm afraid this isn't true: There's no requirement for a guest to pass
all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
tries to obtain a reference for every vCPU. With my adding of GFN
(really gaddr) based registration of the runstate area (already
looking towards 4.18) the maximum possible count is to further grow.

I guess this went unnoticed because Linux presumably uses different
GFNs for every vCPU, so the issue doesn't surface. But I'm afraid this
is a regression (unless I'm overlooking something, perhaps a
mitigating factor) which wants fixing for 4.17.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:03:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:03:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419673.664491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDyh-0008OZ-I3; Tue, 11 Oct 2022 12:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419673.664491; Tue, 11 Oct 2022 12:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiDyh-0008OS-E8; Tue, 11 Oct 2022 12:03:19 +0000
Received: by outflank-mailman (input) for mailman id 419673;
 Tue, 11 Oct 2022 12:03:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dF7p=2M=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1oiDyg-0008O3-Bo
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 12:03:18 +0000
Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com
 [2607:f8b0:4864:20::1030])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0262672-495c-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 14:03:16 +0200 (CEST)
Received: by mail-pj1-x1030.google.com with SMTP id 70so12277038pjo.4
 for <xen-devel@lists.xenproject.org>; Tue, 11 Oct 2022 05:03:16 -0700 (PDT)
Received: from leoy-yangtze.lan (211-75-219-202.hinet-ip.hinet.net.
 [211.75.219.202]) by smtp.gmail.com with ESMTPSA id
 e14-20020a17090301ce00b001782f94f8ebsm8555135plh.3.2022.10.11.05.03.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 11 Oct 2022 05:03:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0262672-495c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=Fw7xUTA3OfRm+ktROCFDpggksMcvBm0LHXupBoTitsY=;
        b=poMvKA3x6D9ff95kRZ8DZsl5ank2XOKrIHHVLKunbMpuGI1s+KrEVhkrlUBU/spP4Z
         xvoTJ84DLxi9uB2Dc2oQagO6lbLh97G6wCheyipMYakBW8edpa3qpkltpC8V3zV1S+m+
         0ekmvjIR38mHHzdQgLs6VROY7MVi9/ttnozqIjZa3E5sBB47cpv0i7KlVF428VPgdixg
         lfTAmvjYZDuPwAkoeCWSRasBq7R/4LCvB9fSkuFGsTWDjNACy0FvAXNpsVqNHOlGVPsI
         StDfPDnfZrsftcD8YDJKTgI36lxqMmZ303r0vZ3veLN4Fw4MAnKcYYtYNSvD1UGuMBK2
         geVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=Fw7xUTA3OfRm+ktROCFDpggksMcvBm0LHXupBoTitsY=;
        b=YEtswKg2xM+pIGtT1EOTOk+WwwPx9w1jJXGhGf0vnJyav6+Mac3/xq3oauTjMqfp9+
         wRTI4VNM7oxqT47XURZ4fCSfgVSGnlDh8rO1nV7Uz+W8mskUmuPTCu3qRlw4wbyvGZGB
         0lUoSaKWfHU6xcqkvzDCP/zkIgHGbfqUIzguzIjr9eIfcZHJoO/NyY5BdNwJsPqWSMyX
         yMVYjTRuh6DhAeVfrZBfdu03voBx9hBvPcw1SJCgWZ4ts9gCZ0LLTTwpvN9eIimqf5qU
         E6wwxXy5RZiVunGaHIlpKDCBJjWO/kVXELADN+7BW5bZg9HGtJFliqJ0wnMceSpIGeVF
         ELTA==
X-Gm-Message-State: ACrzQf33f5XGb9YEh2n0+PFvdARcsN+2V74q+nzRaG0Mwnu7/+bkbFh1
	l49Rmt65oBYDJSS5XoBUOSi28Q==
X-Google-Smtp-Source: AMsMyM6GO05Kc0vW+atcj6gu+28B8erR9r00BWvogZ8fs6Dqi1qW34KoEfcqD3l80eANs4ShanDTvw==
X-Received: by 2002:a17:902:d4d2:b0:178:491b:40d with SMTP id o18-20020a170902d4d200b00178491b040dmr24592958plg.79.1665489795167;
        Tue, 11 Oct 2022 05:03:15 -0700 (PDT)
Date: Tue, 11 Oct 2022 20:03:06 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>

Hi Stefano,

On Mon, Oct 10, 2022 at 04:50:46PM -0700, Stefano Stabellini wrote:
> +Xen/Linux maintainers

Thanks for reviewing.

[...]

> >   Throughput result:
> > 
> >     Profile     netperf (Mbits/sec)    ddsperf (Mbits/sec)
> >     Xen-Dom0    939.41                 > 620
> >     Xen-DomU    107.73                 4~12
> > 
> >   Latency result:
> > 
> >     Profile     ddsperf's max ping/pong latency (us)
> >     Xen-Dom0    200 ~ 1400
> >     Xen-DomU    > 60,000
> > 
> > ## Analysis
> > 
> > The critical thing for the performance is low level network driver if
> > it uses synchronous or asynchronous mode for skb transferring.
> > 
> > When we transfer data from my x86 machine to Xen DomU, the data flow is:
> > 
> >   bridge -> xenif (Xen network backend driver)               => Dom0
> > 	      `> xennet driver (Xen net forend driver)       => DomU
> > 
> > In this flow, Xen network backend driver (in Dom0) copies skb into the
> > mediate buffer (gnttab_batch_copy()) and notify Xen VM by sending rx
> > irq, the key point is the backend driver doesn't wait for Xen VM to
> > process the skb and directly return to user space, therefore, Xen Dom0
> > and DomU work in asynchronous mode in this case (Dom0 doesn't need to
> > wait for DomU), the duration for handling a skb is 30+ us.
> > 
> > Conversely, if transmit data from Xen DomU, the flow is:
> > 
> >            DomU                    |               Dom0
> >   ---------------------------------+------------------------------------
> >   xennet driver receives skb       |
> >     `> send tx interrupt to Dom0   |
> >                                    |  xenif respond tx interrupt
> > 	                           |  Copy skb into mediate buffer
> >                                    |  Notify DomU (send tx irq)
> >   xennet driver handle tx irq      |
> >   free skb                         |
> > 
> > So we can see when DomU sends out packets, it needs to wait for Dom0 to
> > process the packets, until Dom0 notifies DomU that packet has been
> > processed the net forend driver in DomU releases skb.
> > 
> > This means it's a long way to process skbs: Xen DomU and Dom0 work
> > in synchronous mode, the forend driver in DomU sends out skb and
> > notifies Dom0, Dom0 handles skb and notifies back to DomU, finally DomU
> > knows the skb has been processed and releases it.  The duration between
> > sendind and releasing a skb is about 180+ us.
> 
> 180us is not great but above you wrote > 60,000 us. In what ways the two
> measurements differ?

108us is measured by using ftrace events 'net_dev_queue' and
'kfree_skb'.

60,000us is the measured maximum latency via ddsperf ping & pong [1],
the latency is not only caused by low level driver and hypervisor, it
also contains the latency caused by the test program itself.

AFAIK, ddsperf monitors traffic from userspace and throttle data
transferring when it detects tx rate is low, I think this is one main
reason for the huge latency (60ms+) from ddsperf.

[1] https://cyclonedds.io/docs/cyclonedds/latest/getting_started.html#measuring-latency

> > ## Questions
> > 
> > Given Xen network driver has been merged in Linux kernel 2.6 (back in
> > 2007), it's very unlikely I am the first person to observe this issue.
> > 
> > I think this is a common issue and not specific to Arm64 arch, the
> > reason is the long latency is mainly caused by Xen networking driver
> > and I did't see the Xen context switching on Arm64 is abnormal (I saw
> > it takes ~10us for context switching between Xen domains).
>  
> Context switching between domains shouldn't come into the picture. For a
> latency measurement like that I would make sure to:
> 
> - use the null scheduler, sched=null
> - use vwfi=native
> 
> This way, we can be sure both domains are running and there are no
> context switches. It should lead to the best latency measurements. Also
> this is the configuration we use by default at Xilinx.

Okay, will try these two options at my side and share back the testing
result.

> > Could anyone confirm if this is a known issue?
> 
> This is not something that was discussed recently as far as I know.

It is a bit worried me if I am the first one to report this issue.

Either it's because this is a specific issue for Arm64 since Xen is
much less deployed on Arm64 than x86 platforms; or I must miss something
for causing the poor network performance.

> > The second question is how to mitigate the long latency when send data
> > from DomU.  A possible solution is the Xen network forend driver copies
> > skb into mediate (bounce) buffer, just like what does in Xen net
> > backend driver with gnttab_batch_copy(), in this way the forend driver
> > doesn't need to wait for backend driver response and directly return
> > back.
> 
> About this, I am not super familiar with drivers/net/xen-netfront.c but
> I take you are referring to xennet_tx_buf_gc? Is that the function that
> is causing xennet_start_xmit to wait?

No.  We can take the whole flow in xen-netfront.c as:

  xennet_start_xmit()
             ----------> notify Xen Dom0 to process skb
             <---------  Dom0 copies skb and notify back to DomU
  xennet_tx_buf_gc()
  softirq/NET_TX : __kfree_skb()

> I didn't think that waiting for the backend is actually required. I
> mean, in theory xennet_start_xmit could return without calling
> xennet_tx_buf_gc, it is just an optimization. But I am not sure about
> this.

The function xennet_start_xmit() will not wait and directly return
back, but if we review the whole flow we can see the skb is freed until
the softirq NET_TX.  In this whole flow, it needs DomU and Dom0 to work
together (includes two context switches) to process skb.

Here I mean the optimization is to allow Dom0 and DomU to work in
parallel.  It could be something like blow, the key point is DomU
doesn't need to wait for Dom0's notification.

       DomU                     |             Dom0
  ------------------------------+-------------------------------
  xennet_start_xmit()           |
  copy skb in grant page        |
  notify Xen Dom0               |
                                |  fetch skb from grant page
  xennet_tx_buf_gc()            |  deliver skb to bridge
    kfree_skb()                 |

> > But here I am not clear for the mechanism for Xen grant table,
> > especially if the Xen grant table is only writtable from Dom0, then it
> > would be hard for us to optimize the forend driver in DomU by directly
> > copying skb into the grant table.  Any thoughts for this?
> 
> The grant table is a mechanism for the frontend to "grant" access to a
> specific page to the backend. It is used for dynamic memory sharing
> between frontend and backend:
> 
> - frontend grants a page
> - frontend copies grant reference to shared ring
> - backend receives request and map granted page
> - backend process request
> - backend complete request and unmap granted page, send notification
> - frontend un-grant the page
> 
> This is the regular process. In addition, for performance reason, it is
> also possible to request Xen to copy a grant to the backend. This is
> less common, but it is used by PV network, specifically by
> gnttab_batch_copy. It is an alternative to mapping which is expected to
> be faster for networking.

Thanks a lot for the shared info.

I saw both net frontend and backend drivers use gnttab_batch_copy(); I
need a bit more time to understand ring and grant table and how these
two parts co-work together.

Thanks,
Leo


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:05:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:05:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419689.664528 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE0u-0001Di-TA; Tue, 11 Oct 2022 12:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419689.664528; Tue, 11 Oct 2022 12:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE0u-0001Bp-OR; Tue, 11 Oct 2022 12:05:36 +0000
Received: by outflank-mailman (input) for mailman id 419689;
 Tue, 11 Oct 2022 12:05:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4MZe=2M=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1oiE0s-0000jT-S8
 for xen-devel@lists.xen.org; Tue, 11 Oct 2022 12:05:35 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id feebe960-495c-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 14:05:31 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE0a-0000i9-BB; Tue, 11 Oct 2022 12:05:16 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE0a-0001d2-A6; Tue, 11 Oct 2022 12:05:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: feebe960-495c-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=dFQV4fOhLMkdX0k3VkiIWqiku+NkHYyvSTpf1rTiHUA=; b=3J84H67nyFcg13Y/Kjm+Kj8uB7
	RD3056F0ZucJIY7O5Vz60ewi4VUsUM7yKI9XjzvqHtMp246XSGXevP7F3vqIXVSH8OooApTrFm6Cl
	4mygkEIEKdeGMwYJW+aM9Qd60jddiVLYJ0ii3JQREVdlt4fta1Ib+7J4Fv2irzDsR6Q0=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 411 v3 (CVE-2022-33748) - lock order
 inversion in transitive grant copy handling
Message-Id: <E1oiE0a-0001d2-A6@xenbits.xenproject.org>
Date: Tue, 11 Oct 2022 12:05:16 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2022-33748 / XSA-411
                               version 3

        lock order inversion in transitive grant copy handling

UPDATES IN VERSION 3
====================

Public release.

ISSUE DESCRIPTION
=================

As part of XSA-226 a missing cleanup call was inserted on an error
handling path.  While doing so, locking requirements were not paid
attention to.  As a result two cooperating guests granting each
other transitive grants can cause locks to be acquired nested within
one another, but in respectively opposite order.  With suitable
timing between the involved grant copy operations this may result in
the locking up of a CPU.

IMPACT
======

Malicious or buggy guest kernels may be able to mount a Denial of
Service (DoS) attack affecting the entire system.

VULNERABLE SYSTEMS
==================

Xen versions 4.0 and newer are vulnerable.  Xen versions 3.4 and older
are not vulnerable.

Only guests with access to transitive grants can exploit the
vulnerability.  In particular, this means that:

 * ARM systems which have taken the XSA-268 fix are not vulnerable, as
   Grant Table v2 was disabled for other security reasons.

 * All systems with the XSA-226 fixes, and booted with
   `gnttab=max-ver:1` or `gnttab=no-transitive` are not vulnerable.

 * From Xen 4.16, the maximum grant table version can be controlled on a
   per-domain basis.  For the xl toolstack, the vulnerability does not
   manifest if either:

   1) Every guest has `max_grant_version=1` in their configuration file,
      or

   2) The global xl.conf has `max_grant_version=1`, and no guests have
      the default overridden by selecting `max_grant_version=2`.

Only multiple cooperating guests can exploit the vulnerability.

MITIGATION
==========

Disallowing the use of transitive grants either via the
`gnttab=no-transitive` Xen command line option, or by disabling grant
interface version 2 altogether via the `gnttab=max-ver:1` Xen command
line option or the xl controls as mentioned above will avoid the
vulnerability.

CREDITS
=======

This issue was discovered by Jan Beulich of SUSE.

RESOLUTION
==========

Applying the appropriate attached patch resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa411.patch           xen-unstable - Xen 4.15.x
xsa411-4.14.patch      Xen 4.14.x - 4.13.x

$ sha256sum xsa411*
0802e2e4e9d03c82429a710bbb783cee2fded52d29b1d969b97c680d30c3ac57  xsa411.patch
8473f2ee34562298c5174f0a5b3c64c561a945333aab675845093ad23250d1cf  xsa411-4.14.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches described above (or others which are
substantially similar) is permitted during the embargo, even on
public-facing systems with untrusted guest users and administrators.

But: Distribution of updated software is prohibited (except to other
members of the predisclosure list).

Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.

HOWEVER, deployment of the mitigations is NOT permitted (except where
all the affected systems and VMs are administered and used only by
organisations which are members of the Xen Project Security Issues
Predisclosure List).  Specifically, deployment on public cloud systems
is NOT permitted.

This is because it is a guest visible change which will draw attention
to the issue.
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNFTAAMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZPsQH/1JCqscbx49QygGVEnq43C97HQpcoZcUNJGwGjBJ
Li0SXejxd3iWsYsFlMAgmacHIjevEGv318JJLSM21hBULGe85cc6QatpWS0VWrBc
tQVbDIgqNRv42gJCtf1dLF0TnlTZ6p3wiqfsxEYBn1zlEhe2ZEMpY8an4707O32d
nQ90JFh44QJXx6HMZD3pEw2g1+4pMDu9yDUp/Yc3YmxYnXmPW6KE7iMmGkLLGigI
GfiTI4FA/BDVIZkjPErwG7pyXmp2sdtVkv5o/cg7YTOrLzeBmegdyUvzuXkizJ2F
PQnc1rgS/vXPkC62cy6fmLkeAf0dQhq6KBuxW3N8s2fXRXk=
=/bRo
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa411.patch"
Content-Disposition: attachment; filename="xsa411.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBnbnR0YWI6IGNvcnJlY3QgbG9ja2luZyBvbiB0cmFuc2l0aXZlIGdyYW50
IGNvcHkgZXJyb3IgcGF0aAoKV2hpbGUgdGhlIGNvbW1lbnQgbmV4dCB0byB0
aGUgbG9jayBkcm9wcGluZyBpbiBwcmVwYXJhdGlvbiBvZgpyZWN1cnNpdmVs
eSBjYWxsaW5nIGFjcXVpcmVfZ3JhbnRfZm9yX2NvcHkoKSBtaXN0YWtlbmx5
IHRhbGtzIGFib3V0IHRoZQpyZCA9PSB0ZCBjYXNlIChleGNsdWRlZCBhIGZl
dyBsaW5lcyBmdXJ0aGVyIHVwKSwgdGhlIHNhbWUgY29uY2VybnMgYXBwbHkK
dG8gdGhlIGNhbGxpbmcgb2YgcmVsZWFzZV9ncmFudF9mb3JfY29weSgpIG9u
IGEgc3Vic2VxdWVudCBlcnJvciBwYXRoLgoKVGhpcyBpcyBDVkUtMjAyMi0z
Mzc0OCAvIFhTQS00MTEuCgpGaXhlczogYWQ0OGZiOTYzZGJmICgiZ250dGFi
OiBmaXggdHJhbnNpdGl2ZSBncmFudCBoYW5kbGluZyIpClNpZ25lZC1vZmYt
Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KLS0tCnYyOiBF
eHRlbmQgY29kZSBjb21tZW50LgoKLS0tIGEveGVuL2NvbW1vbi9ncmFudF90
YWJsZS5jCisrKyBiL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYwpAQCAtMjYy
Miw5ICsyNjIyLDggQEAgYWNxdWlyZV9ncmFudF9mb3JfY29weSgKICAgICAg
ICAgICAgICAgICAgICAgIHRyYW5zX2RvbWlkKTsKIAogICAgICAgICAvKgot
ICAgICAgICAgKiBhY3F1aXJlX2dyYW50X2Zvcl9jb3B5KCkgY291bGQgdGFr
ZSB0aGUgbG9jayBvbiB0aGUKLSAgICAgICAgICogcmVtb3RlIHRhYmxlIChp
ZiByZCA9PSB0ZCksIHNvIHdlIGhhdmUgdG8gZHJvcCB0aGUgbG9jawotICAg
ICAgICAgKiBoZXJlIGFuZCByZWFjcXVpcmUuCisgICAgICAgICAqIGFjcXVp
cmVfZ3JhbnRfZm9yX2NvcHkoKSB3aWxsIHRha2UgdGhlIGxvY2sgb24gdGhl
IHJlbW90ZSB0YWJsZSwKKyAgICAgICAgICogc28gd2UgaGF2ZSB0byBkcm9w
IHRoZSBsb2NrIGhlcmUgYW5kIHJlYWNxdWlyZS4KICAgICAgICAgICovCiAg
ICAgICAgIGFjdGl2ZV9lbnRyeV9yZWxlYXNlKGFjdCk7CiAgICAgICAgIGdy
YW50X3JlYWRfdW5sb2NrKHJndCk7CkBAIC0yNjYxLDExICsyNjYwLDI1IEBA
IGFjcXVpcmVfZ3JhbnRfZm9yX2NvcHkoCiAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGFjdC0+dHJhbnNfZ3JlZiAhPSB0cmFuc19ncmVmIHx8CiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICFhY3QtPmlzX3N1Yl9wYWdlKSkgKQog
ICAgICAgICB7CisgICAgICAgICAgICAvKgorICAgICAgICAgICAgICogTGlr
ZSBhYm92ZSBmb3IgYWNxdWlyZV9ncmFudF9mb3JfY29weSgpIHdlIG5lZWQg
dG8gZHJvcCBhbmQgdGhlbgorICAgICAgICAgICAgICogcmUtYWNxdWlyZSB0
aGUgbG9ja3MgaGVyZSB0byBwcmV2ZW50IGxvY2sgb3JkZXIgaW52ZXJzaW9u
IGlzc3Vlcy4KKyAgICAgICAgICAgICAqIFVubGlrZSBmb3IgYWNxdWlyZV9n
cmFudF9mb3JfY29weSgpIHdlIGRvbid0IG5lZWQgdG8gcmUtY2hlY2sKKyAg
ICAgICAgICAgICAqIGFueXRoaW5nLCBhcyByZWxlYXNlX2dyYW50X2Zvcl9j
b3B5KCkgZG9lc24ndCBkZXBlbmQgb24gdGhlIGdyYW50CisgICAgICAgICAg
ICAgKiB0YWJsZSBlbnRyeTogSXQgb25seSB1cGRhdGVzIGludGVybmFsIHN0
YXRlIGFuZCB0aGUgc3RhdHVzIGZsYWdzLgorICAgICAgICAgICAgICovCisg
ICAgICAgICAgICBhY3RpdmVfZW50cnlfcmVsZWFzZShhY3QpOworICAgICAg
ICAgICAgZ3JhbnRfcmVhZF91bmxvY2socmd0KTsKKwogICAgICAgICAgICAg
cmVsZWFzZV9ncmFudF9mb3JfY29weSh0ZCwgdHJhbnNfZ3JlZiwgcmVhZG9u
bHkpOwogICAgICAgICAgICAgcmN1X3VubG9ja19kb21haW4odGQpOworCisg
ICAgICAgICAgICBncmFudF9yZWFkX2xvY2socmd0KTsKKyAgICAgICAgICAg
IGFjdCA9IGFjdGl2ZV9lbnRyeV9hY3F1aXJlKHJndCwgZ3JlZik7CiAgICAg
ICAgICAgICByZWR1Y2Vfc3RhdHVzX2Zvcl9waW4ocmQsIGFjdCwgc3RhdHVz
LCByZWFkb25seSk7CiAgICAgICAgICAgICBhY3RpdmVfZW50cnlfcmVsZWFz
ZShhY3QpOwogICAgICAgICAgICAgZ3JhbnRfcmVhZF91bmxvY2socmd0KTsK
KwogICAgICAgICAgICAgcHV0X3BhZ2UoKnBhZ2UpOwogICAgICAgICAgICAg
KnBhZ2UgPSBOVUxMOwogICAgICAgICAgICAgcmV0dXJuIEVSRVNUQVJUOwo=

--=separator
Content-Type: application/octet-stream; name="xsa411-4.14.patch"
Content-Disposition: attachment; filename="xsa411-4.14.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiBnbnR0YWI6IGNvcnJlY3QgbG9ja2luZyBvbiB0cmFuc2l0aXZlIGdyYW50
IGNvcHkgZXJyb3IgcGF0aAoKV2hpbGUgdGhlIGNvbW1lbnQgbmV4dCB0byB0
aGUgbG9jayBkcm9wcGluZyBpbiBwcmVwYXJhdGlvbiBvZgpyZWN1cnNpdmVs
eSBjYWxsaW5nIGFjcXVpcmVfZ3JhbnRfZm9yX2NvcHkoKSBtaXN0YWtlbmx5
IHRhbGtzIGFib3V0IHRoZQpyZCA9PSB0ZCBjYXNlIChleGNsdWRlZCBhIGZl
dyBsaW5lcyBmdXJ0aGVyIHVwKSwgdGhlIHNhbWUgY29uY2VybnMgYXBwbHkK
dG8gdGhlIGNhbGxpbmcgb2YgcmVsZWFzZV9ncmFudF9mb3JfY29weSgpIG9u
IGEgc3Vic2VxdWVudCBlcnJvciBwYXRoLgoKVGhpcyBpcyBDVkUtMjAyMi0z
Mzc0OCAvIFhTQS00MTEuCgpGaXhlczogYWQ0OGZiOTYzZGJmICgiZ250dGFi
OiBmaXggdHJhbnNpdGl2ZSBncmFudCBoYW5kbGluZyIpClNpZ25lZC1vZmYt
Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCi0tLSBhL3hl
bi9jb21tb24vZ3JhbnRfdGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50
X3RhYmxlLmMKQEAgLTI2MTcsOSArMjYxNyw4IEBAIGFjcXVpcmVfZ3JhbnRf
Zm9yX2NvcHkoCiAgICAgICAgICAgICAgICAgICAgICB0cmFuc19kb21pZCk7
CiAKICAgICAgICAgLyoKLSAgICAgICAgICogYWNxdWlyZV9ncmFudF9mb3Jf
Y29weSgpIGNvdWxkIHRha2UgdGhlIGxvY2sgb24gdGhlCi0gICAgICAgICAq
IHJlbW90ZSB0YWJsZSAoaWYgcmQgPT0gdGQpLCBzbyB3ZSBoYXZlIHRvIGRy
b3AgdGhlIGxvY2sKLSAgICAgICAgICogaGVyZSBhbmQgcmVhY3F1aXJlLgor
ICAgICAgICAgKiBhY3F1aXJlX2dyYW50X2Zvcl9jb3B5KCkgd2lsbCB0YWtl
IHRoZSBsb2NrIG9uIHRoZSByZW1vdGUgdGFibGUsCisgICAgICAgICAqIHNv
IHdlIGhhdmUgdG8gZHJvcCB0aGUgbG9jayBoZXJlIGFuZCByZWFjcXVpcmUu
CiAgICAgICAgICAqLwogICAgICAgICBhY3RpdmVfZW50cnlfcmVsZWFzZShh
Y3QpOwogICAgICAgICBncmFudF9yZWFkX3VubG9jayhyZ3QpOwpAQCAtMjY1
NiwxMSArMjY1NSwyNSBAQCBhY3F1aXJlX2dyYW50X2Zvcl9jb3B5KAogICAg
ICAgICAgICAgICAgICAgICAgICAgICBhY3QtPnRyYW5zX2dyZWYgIT0gdHJh
bnNfZ3JlZiB8fAogICAgICAgICAgICAgICAgICAgICAgICAgICAhYWN0LT5p
c19zdWJfcGFnZSkpICkKICAgICAgICAgeworICAgICAgICAgICAgLyoKKyAg
ICAgICAgICAgICAqIExpa2UgYWJvdmUgZm9yIGFjcXVpcmVfZ3JhbnRfZm9y
X2NvcHkoKSB3ZSBuZWVkIHRvIGRyb3AgYW5kIHRoZW4KKyAgICAgICAgICAg
ICAqIHJlLWFjcXVpcmUgdGhlIGxvY2tzIGhlcmUgdG8gcHJldmVudCBsb2Nr
IG9yZGVyIGludmVyc2lvbiBpc3N1ZXMuCisgICAgICAgICAgICAgKiBVbmxp
a2UgZm9yIGFjcXVpcmVfZ3JhbnRfZm9yX2NvcHkoKSB3ZSBkb24ndCBuZWVk
IHRvIHJlLWNoZWNrCisgICAgICAgICAgICAgKiBhbnl0aGluZywgYXMgcmVs
ZWFzZV9ncmFudF9mb3JfY29weSgpIGRvZXNuJ3QgZGVwZW5kIG9uIHRoZSBn
cmFudAorICAgICAgICAgICAgICogdGFibGUgZW50cnk6IEl0IG9ubHkgdXBk
YXRlcyBpbnRlcm5hbCBzdGF0ZSBhbmQgdGhlIHN0YXR1cyBmbGFncy4KKyAg
ICAgICAgICAgICAqLworICAgICAgICAgICAgYWN0aXZlX2VudHJ5X3JlbGVh
c2UoYWN0KTsKKyAgICAgICAgICAgIGdyYW50X3JlYWRfdW5sb2NrKHJndCk7
CisKICAgICAgICAgICAgIHJlbGVhc2VfZ3JhbnRfZm9yX2NvcHkodGQsIHRy
YW5zX2dyZWYsIHJlYWRvbmx5KTsKLSAgICAgICAgICAgIGZpeHVwX3N0YXR1
c19mb3JfY29weV9waW4ocmQsIGFjdCwgc3RhdHVzKTsKICAgICAgICAgICAg
IHJjdV91bmxvY2tfZG9tYWluKHRkKTsKKworICAgICAgICAgICAgZ3JhbnRf
cmVhZF9sb2NrKHJndCk7CisgICAgICAgICAgICBhY3QgPSBhY3RpdmVfZW50
cnlfYWNxdWlyZShyZ3QsIGdyZWYpOworICAgICAgICAgICAgZml4dXBfc3Rh
dHVzX2Zvcl9jb3B5X3BpbihyZCwgYWN0LCBzdGF0dXMpOwogICAgICAgICAg
ICAgYWN0aXZlX2VudHJ5X3JlbGVhc2UoYWN0KTsKICAgICAgICAgICAgIGdy
YW50X3JlYWRfdW5sb2NrKHJndCk7CisKICAgICAgICAgICAgIHB1dF9wYWdl
KCpwYWdlKTsKICAgICAgICAgICAgICpwYWdlID0gTlVMTDsKICAgICAgICAg
ICAgIHJldHVybiBFUkVTVEFSVDsK

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:05:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:05:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419692.664574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE0z-0002NF-Gn; Tue, 11 Oct 2022 12:05:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419692.664574; Tue, 11 Oct 2022 12:05:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE0z-0002Hr-B8; Tue, 11 Oct 2022 12:05:41 +0000
Received: by outflank-mailman (input) for mailman id 419692;
 Tue, 11 Oct 2022 12:05:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4MZe=2M=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1oiE0w-0000jT-Ql
 for xen-devel@lists.xen.org; Tue, 11 Oct 2022 12:05:39 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 003bd45d-495d-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 14:05:31 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE0V-0000hm-Qc; Tue, 11 Oct 2022 12:05:11 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE0V-0001bv-Mi; Tue, 11 Oct 2022 12:05:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 003bd45d-495d-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=JjAcHcoAm3evk0Fas9oObSjCsQcHiKHqNFeMsvOxTIQ=; b=n5wfZMFlhCVYeeT7PbbGwxc2M9
	/mtVUR1EQAC9XNwdH614mBe7JzNPPLhA0OAuhFwPpz8MggHCZ4PqT0t38UJfLAIJixYGrPMi8Q5JA
	YupKx56kMwLI7pUKJ9fTNVXV5I5vGhvFIlAvAtPxY0/6nVszVxcemXZunM6yT65Xa40w=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 410 v3 (CVE-2022-33746) - P2M pool freeing
 may take excessively long
Message-Id: <E1oiE0V-0001bv-Mi@xenbits.xenproject.org>
Date: Tue, 11 Oct 2022 12:05:11 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2022-33746 / XSA-410
                               version 3

              P2M pool freeing may take excessively long

UPDATES IN VERSION 3
====================

Public release.

ISSUE DESCRIPTION
=================

The P2M pool backing second level address translation for guests may be
of significant size.  Therefore its freeing may take more time than is
reasonable without intermediate preemption checks.  Such checking for
the need to preempt was so far missing.

IMPACT
======

A group of collaborating guests can cause the temporary locking up of a
CPU, potentially leading to a Denial of Service (DoS) affecting the
entire host.

VULNERABLE SYSTEMS
==================

All Xen versions are vulnerable.

x86 HVM and PVH guests as well as Arm guests can trigger the
vulnerability.  x86 PV guests cannot trigger the vulnerability.

MITIGATION
==========

Running only PV guests will avoid the vulnerability.

CREDITS
=======

This issue was discovered by Julien Grall of Amazon.

RESOLUTION
==========

Applying the appropriate set of attached patches resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

xsa410/xsa410-??.patch           xen-unstable
xsa410/xsa410-4.16-??.patch      Xen 4.16.x - 4.15.x
xsa410/xsa410-4.14-??.patch      Xen 4.14.x
xsa410/xsa410-4.13-??.patch      Xen 4.13.x

$ sha256sum xsa410* xsa410*/*
70b2f2c880b30094c9bdbd3ae4b20b32acfc8daf94d5add5884998ff20ffc0e7  xsa410.meta
632f4d71bc9dfc5ddcf649b1e484a918b4cb3d270dedad3b904bf4552318ae0d  xsa410/xsa410-01.patch
a2c1e6871a76b9d0c7f54b5557c6d0e1a02423bca5b27354aa7e872b0016047e  xsa410/xsa410-02.patch
61b8c71ad199dfa9762e739a592aa0a7f3b79d42e88d80a9589a993c768352be  xsa410/xsa410-03.patch
fb11b3d730bb665add2447b8f2258755604ce51e0ccc0731cddd938a538b051f  xsa410/xsa410-4.13-01.patch
ce5e780fdd162a1961fb0d51ccd7db8c3b2cedcee444ee3a58569bd8bbcfd6e8  xsa410/xsa410-4.13-02.patch
33514a6bf40d6c73fa7ca064b3e0401048f87eecbd007601bca6943b58f5c4b5  xsa410/xsa410-4.13-03.patch
af7d5eeda27e789c91e39b58110b25b668ecc241ed87bf4d75d9ff2bf647c660  xsa410/xsa410-4.13-04.patch
972e95787d635056bb0476bff990af0957d9669b4b4948975a74ed085b9fdc38  xsa410/xsa410-4.13-05.patch
4587ff1246f1ea59053e76cdded0e42aba8e747123c8b37b7fe4e03f39d3a447  xsa410/xsa410-4.13-06.patch
99a2a83ea89aa0a79c3cd938917d6b7de1e7e52ec744fb2e0ed1ed2a577cb203  xsa410/xsa410-4.13-07.patch
b36cc0d96111dbf65b7fefbce5fe9c5fe737dca24453f10f76253ce5bdcbb37d  xsa410/xsa410-4.13-08.patch
b548a1ba8082e5dbb35943bbacc5391766343c373c6edd2eb96d430cacdac00b  xsa410/xsa410-4.13-09.patch
9fae7cf66cb298737ad5f021c349291ec84f8de83d02a9b814967fb97b85ad1f  xsa410/xsa410-4.13-10.patch
0b91fcfc0a29428cfc06f4f1ddb01f5d1e7f144eae05635f2e9ef46dd7b33f0a  xsa410/xsa410-4.14-01.patch
a7a7e7e9529e91454035ad468c46faae34638be1f5f0694e1fe352c6c1acff06  xsa410/xsa410-4.14-02.patch
75bb2296a9f8adeb0ae3fc330f158614aab94a9263aba99730fe31d71be93d62  xsa410/xsa410-4.14-03.patch
8ad3dc1957fdb440e0bbd3b8e17286361ddfa6bb748ba6d48cc85ca8e88862ba  xsa410/xsa410-4.14-04.patch
5aba547158d8f182eb8a148a03c3c69741d264b568a80b349c34b99e36e75647  xsa410/xsa410-4.14-05.patch
5b343f47ce34c53a0cf300a05ccd6898f695e62ced4b0f14d64c9947c8c17250  xsa410/xsa410-4.14-06.patch
d34f3107061f13fdd1338d78544584d3509f8f7dabde78027f308c934cfeeb10  xsa410/xsa410-4.14-07.patch
8ccce0e109f6e0957643a04c822b7637b2cc7094ab73c4b19898657c05282f76  xsa410/xsa410-4.14-08.patch
ca3116eb10b4ea29a4e5ce97a40d0f504418a8cd890fa49fb4ddf6c3acba9a9b  xsa410/xsa410-4.14-09.patch
ec1ad7529e6406f7fff9ebe35caf64419e360feadc9fae4ea679bff88238eefa  xsa410/xsa410-4.14-10.patch
27857174e10917e02c6b9c6b8c29d5510c308035462a9a18bcdfebcef8c1e7af  xsa410/xsa410-4.16-01.patch
7fc330e398e99023f9875004409ae4cb3943b15338662c242887f593d909e271  xsa410/xsa410-4.16-02.patch
9a72aaef6a65ec984022590c5e1bb39527873df4607604746d0a0b91636271d8  xsa410/xsa410-4.16-03.patch
4dffbb2e5933c18426e6ce0cbba94c42637f59b8cec03aad2bfc54d81c49d3e3  xsa410/xsa410-4.16-04.patch
2e5d91e3e5e0e7a294caada1399e017487063642bbb42bddfa5169db6faab37e  xsa410/xsa410-4.16-05.patch
8174d9ed5f633f5a043084bf0cfb08211173f1afbfc5240c306bffa69c883595  xsa410/xsa410-4.16-06.patch
b78792bd0d51a8e18d570d225df556f2099272cab00f1cb95bbbb4c08d299ce1  xsa410/xsa410-4.16-07.patch
1f3f14bf3091e685cf6ac530baf7bd060586cf3db330ba1218d1048eb672d6eb  xsa410/xsa410-4.16-08.patch
63af35d559156436276967c94b3402982914b0fdd77187ff5b0bbf3dda356589  xsa410/xsa410-4.16-09.patch
85e8da807225df97583f5331491f29ecea059ce770c59a1a898a4b19b838f0c1  xsa410/xsa410-4.16-10.patch
6cf86d574ff45719659ed23af352fdc64d6563434057b733ac46ec6d5c758a3f  xsa410/xsa410-04.patch
296d38e69eebab2985cdab70419ca5fd73380d94b35c96fa7f6820fead59bf95  xsa410/xsa410-05.patch
e590762c70faad493b4e95c9f747ad9c3b313233f1b0aba3e81df5f40565cc51  xsa410/xsa410-06.patch
28164010d988fb590c7b22ef7f3571142660ec975ee8709f28fe310f220f7b08  xsa410/xsa410-07.patch
0ad43b452e5aef2657f311b6fa2fbc1eb07702d08c78878b1e614c573606feeb  xsa410/xsa410-08.patch
04f02d9b06f74a8921557196b39c2cf3dd8fd7bf0c1f350d0c55d8d49187e9a7  xsa410/xsa410-09.patch
a67ae39583867ed5d3900c4b45e2e32e9ac4ec58298c6508cedb273e9b7caf4b  xsa410/xsa410-10.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches and/or mitigations described above (or
others which are substantially similar) is permitted during the
embargo, even on public-facing systems with untrusted guest users and
administrators.

But: Distribution of updated software is prohibited (except to other
members of the predisclosure list).

Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.

(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNFS/4MHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZFn8H/AlU50r9Lk0QaxVbvuKVir3rVgP+QURgVeHMTcuj
UbNpjasPjQMbT9vzTPtIN+b59J0FwhWWZRIcZhYX6sPC/L9eAomUiFnVOe9Jmyec
cv0gpn/fWum850A9/cZ+F3wNNmgbHcm+uLvCWM11vO79kUMzKmCeDGguU5cgbmBo
hiNNL/mUEnu5QQn+jXolFCCA+CzlSJLg+tJwZn0il6dIf7z9d2yAxJRMUHF8s/c3
d23+6kTxLkfdnkGuwxkEVcSCaBN6YCGPaUy4AaQYzqPun/hcqGCsXCgK7X+iJIxq
36LWZLuqwAL80CQzEnMkgBNpqyQiudEwbZnBSMt0nzctg1g=
=EdsG
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa410.meta"
Content-Disposition: attachment; filename="xsa410.meta"
Content-Transfer-Encoding: base64

ewogICJYU0EiOiA0MTAsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg
Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs
CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK
ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6
IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJk
OGE2OTMwMTk4NDVjYWE0ZTIxNmJjYWMxMGY5NTAxYTgxNGM5OWFlIiwKICAg
ICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK
ICAgICAgICAgICAgInhzYTQxMC94c2E0MTAtNC4xMy0qLnBhdGNoIgogICAg
ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0Ijog
ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg
ICAgIlN0YWJsZVJlZiI6ICIyNjFiODgyZjc3MDQ1MTVhMDFmNzQ1ODlmNTdm
MGMxMzAzZTNiNzAxIiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAg
ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxMC94c2E0MTAt
NC4xNC0qLnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog
ICAgfSwKICAgICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg
ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJkZjMzOTVmNmIy
ZDc1OWFiYTM5ZmI2N2E3YmMwZmU0OTE0N2M4YjM5IiwKICAgICAgICAgICJQ
cmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAg
ICAgInhzYTQxMC94c2E0MTAtNC4xNi0qLnBhdGNoIgogICAgICAgICAgXQog
ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2IjogewogICAgICAi
UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs
ZVJlZiI6ICI4OWZlNmQwZWRlYTg0MWQxZDI2OTBjZjNmNTE3M2UzMzRjNjg3
ODIzIiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0
Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQxMC94c2E0MTAtNC4xNi0qLnBh
dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg
ICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i
OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogIjAxY2EyOWYwYjE3YTUwYTk0
YjBlMjMyYmEyNzZjMzJlOTVkODBhZTMiLAogICAgICAgICAgIlByZXJlcXMi
OiBbXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNh
NDEwL3hzYTQxMC0/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg
ICAgfQogICAgfQogIH0KfQo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-01.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-01.patch"
Content-Transfer-Encoding: base64

RnJvbSBlNzQ0OTJhZWE4MTg1YjY1MjliMmVlYmE5OTA4NDBhM2JlYzU2ZDEy
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpEYXRlOiBNb24sIDYgSnVuIDIwMjIgMDY6
MTc6MjUgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvMl0geGVuL2FybTogcDJt
OiBQcmV2ZW50IGFkZGluZyBtYXBwaW5nIHdoZW4gZG9tYWluIGlzIGR5aW5n
CgpEdXJpbmcgdGhlIGRvbWFpbiBkZXN0cm95IHByb2Nlc3MsIHRoZSBkb21h
aW4gd2lsbCBzdGlsbCBiZSBhY2Nlc3NpYmxlCnVudGlsIGl0IGlzIGZ1bGx5
IGRlc3Ryb3llZC4gU28gZG9lcyB0aGUgUDJNIGJlY2F1c2Ugd2UgZG9uJ3Qg
YmFpbApvdXQgZWFybHkgaWYgaXNfZHlpbmcgaXMgbm9uLXplcm8uIElmIGEg
ZG9tYWluIGhhcyBwZXJtaXNzaW9uIHRvCm1vZGlmeSB0aGUgb3RoZXIgZG9t
YWluJ3MgUDJNIChpLmUuIGRvbTAsIG9yIGEgc3R1YmRvbWFpbiksIHRoZW4K
Zm9yZWlnbiBtYXBwaW5nIGNhbiBiZSBhZGRlZCBwYXN0IHJlbGlucXVpc2hf
cDJtX21hcHBpbmcoKS4KClRoZXJlZm9yZSwgd2UgbmVlZCB0byBwcmV2ZW50
IG1hcHBpbmcgdG8gYmUgYWRkZWQgd2hlbiB0aGUgZG9tYWluCmlzIGR5aW5n
LiBUaGlzIGNvbW1pdCBwcmV2ZW50cyBzdWNoIGFkZGluZyBvZiBtYXBwaW5n
IGJ5IGFkZGluZyB0aGUKZC0+aXNfZHlpbmcgY2hlY2sgdG8gcDJtX3NldF9l
bnRyeSgpLiBBbHNvIHRoaXMgY29tbWl0IGVuaGFuY2VzIHRoZQpjaGVjayBp
biByZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgdG8gbWFrZSBzdXJlIHRoYXQg
bm8gbWFwcGluZ3MgY2FuCmJlIGFkZGVkIGluIHRoZSBQMk0gYWZ0ZXIgdGhl
IFAyTSBsb2NrIGlzIHJlbGVhc2VkLgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0y
MDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IEp1bGllbiBH
cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEhlbnJ5
IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KVGVzdGVkLWJ5OiBIZW5yeSBX
YW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5OiBTdGVmYW5v
IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ci0tLQogeGVu
L2FyY2gvYXJtL3AybS5jIHwgMTEgKysrKysrKysrKysKIDEgZmlsZSBjaGFu
Z2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5jCmluZGV4IDg0NDlmOTdm
ZTdlNC4uYzJlMGIxMTZjNDY3IDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0v
cDJtLmMKKysrIGIveGVuL2FyY2gvYXJtL3AybS5jCkBAIC0xMDkyLDYgKzEw
OTIsMTUgQEAgaW50IHAybV9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4g
KnAybSwKIHsKICAgICBpbnQgcmMgPSAwOwogCisgICAgLyoKKyAgICAgKiBB
bnkgcmVmZXJlbmNlIHRha2VuIGJ5IHRoZSBQMk0gbWFwcGluZ3MgKGUuZy4g
Zm9yZWlnbiBtYXBwaW5nKSB3aWxsCisgICAgICogYmUgZHJvcHBlZCBpbiBy
ZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkuIEFzIHRoZSBQMk0gd2lsbCBzdGls
bAorICAgICAqIGJlIGFjY2Vzc2libGUgYWZ0ZXIsIHdlIG5lZWQgdG8gcHJl
dmVudCBtYXBwaW5nIHRvIGJlIGFkZGVkIHdoZW4gdGhlCisgICAgICogZG9t
YWluIGlzIGR5aW5nLgorICAgICAqLworICAgIGlmICggdW5saWtlbHkocDJt
LT5kb21haW4tPmlzX2R5aW5nKSApCisgICAgICAgIHJldHVybiAtRU5PTUVN
OworCiAgICAgd2hpbGUgKCBuciApCiAgICAgewogICAgICAgICB1bnNpZ25l
ZCBsb25nIG1hc2s7CkBAIC0xNjM0LDYgKzE2NDMsOCBAQCBpbnQgcmVsaW5x
dWlzaF9wMm1fbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2ln
bmVkIGludCBvcmRlcjsKICAgICBnZm5fdCBzdGFydCwgZW5kOwogCisgICAg
QlVHX09OKCFkLT5pc19keWluZyk7CisgICAgLyogTm8gbWFwcGluZ3MgY2Fu
IGJlIGFkZGVkIGluIHRoZSBQMk0gYWZ0ZXIgdGhlIFAyTSBsb2NrIGlzIHJl
bGVhc2VkLiAqLwogICAgIHAybV93cml0ZV9sb2NrKHAybSk7CiAKICAgICBz
dGFydCA9IHAybS0+bG93ZXN0X21hcHBlZF9nZm47Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-02.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-02.patch"
Content-Transfer-Encoding: base64

RnJvbSA1YmU3MzY0NzVjZTEzODAxYmVhMjhmMmUwNWUxMjFmMmRkMzFhMzRh
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpEYXRlOiBNb24sIDYgSnVuIDIwMjIgMDY6
MTc6MjYgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0geGVuL2FybTogcDJt
OiBIYW5kbGUgcHJlZW1wdGlvbiB3aGVuIGZyZWVpbmcgaW50ZXJtZWRpYXRl
CiBwYWdlIHRhYmxlcwoKQXQgdGhlIG1vbWVudCB0aGUgUDJNIHBhZ2UgdGFi
bGVzIHdpbGwgYmUgZnJlZWQgd2hlbiB0aGUgZG9tYWluIHN0cnVjdHVyZQpp
cyBmcmVlZCB3aXRob3V0IGFueSBwcmVlbXB0aW9uLiBBcyB0aGUgUDJNIGlz
IHF1aXRlIGxhcmdlLCBpdGVyYXRpbmcKdGhyb3VnaCB0aGlzIG1heSB0YWtl
IG1vcmUgdGltZSB0aGFuIGl0IGlzIHJlYXNvbmFibGUgd2l0aG91dCBpbnRl
cm1lZGlhdGUKcHJlZW1wdGlvbiAodG8gcnVuIHNvZnRpcnFzIGFuZCBwZXJo
YXBzIHNjaGVkdWxlcikuCgpTcGxpdCBwMm1fdGVhcmRvd24oKSBpbiB0d28g
cGFydHM6IG9uZSBwcmVlbXB0aWJsZSBhbmQgY2FsbGVkIHdoZW4KcmVsaW5x
dWlzaGluZyB0aGUgcmVzb3VyY2VzLCB0aGUgb3RoZXIgb25lIG5vbi1wcmVl
bXB0aWJsZSBhbmQgY2FsbGVkCndoZW4gZnJlZWluZyB0aGUgZG9tYWluIHN0
cnVjdHVyZS4KCkFzIHdlIGFyZSBub3cgZnJlZWluZyB0aGUgUDJNIHBhZ2Vz
IGVhcmx5LCB3ZSBhbHNvIG5lZWQgdG8gcHJldmVudApmdXJ0aGVyIGFsbG9j
YXRpb24gaWYgc29tZW9uZSBjYWxsIHAybV9zZXRfZW50cnkoKSBwYXN0IHAy
bV90ZWFyZG93bigpCihJIHdhc24ndCBhYmxlIHRvIHByb3ZlIHRoaXMgd2ls
bCBuZXZlciBoYXBwZW4pLiBUaGlzIGlzIGRvbmUgYnkKdGhlIGNoZWNraW5n
IGRvbWFpbi0+aXNfZHlpbmcgZnJvbSBwcmV2aW91cyBwYXRjaCBpbiBwMm1f
c2V0X2VudHJ5KCkuCgpTaW1pbGFybHksIHdlIHdhbnQgdG8gbWFrZSBzdXJl
IHRoYXQgbm8tb25lIGNhbiBhY2Nlc3NlZCB0aGUgZnJlZQpwYWdlcy4gVGhl
cmVmb3JlIHRoZSByb290IGlzIGNsZWFyZWQgYmVmb3JlIGZyZWVpbmcgcGFn
ZXMuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjItMzM3NDYgLyBYU0EtNDEw
LgoKU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u
LmNvbT4KU2lnbmVkLW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh
cm0uY29tPgpUZXN0ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt
LmNvbT4KUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl
bGxpbmlAa2VybmVsLm9yZz4KLS0tCiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMg
ICAgICAgICAgfCAxMCArKysrKystLQogeGVuL2FyY2gvYXJtL2luY2x1ZGUv
YXNtL3AybS5oIHwgMTMgKysrKysrKystLQogeGVuL2FyY2gvYXJtL3AybS5j
ICAgICAgICAgICAgIHwgNDcgKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKy0tLQogMyBmaWxlcyBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCA3
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21h
aW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYwppbmRleCAyY2Q0ODE5Nzlj
ZjEuLmU1YWUzZTcxZWIyMCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL2Rv
bWFpbi5jCisrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYwpAQCAtNzk3LDEw
ICs3OTcsMTAgQEAgZmFpbDoKIHZvaWQgYXJjaF9kb21haW5fZGVzdHJveShz
dHJ1Y3QgZG9tYWluICpkKQogewogICAgIC8qIElPTU1VIHBhZ2UgdGFibGUg
aXMgc2hhcmVkIHdpdGggUDJNLCBhbHdheXMgY2FsbAotICAgICAqIGlvbW11
X2RvbWFpbl9kZXN0cm95KCkgYmVmb3JlIHAybV90ZWFyZG93bigpLgorICAg
ICAqIGlvbW11X2RvbWFpbl9kZXN0cm95KCkgYmVmb3JlIHAybV9maW5hbF90
ZWFyZG93bigpLgogICAgICAqLwogICAgIGlvbW11X2RvbWFpbl9kZXN0cm95
KGQpOwotICAgIHAybV90ZWFyZG93bihkKTsKKyAgICBwMm1fZmluYWxfdGVh
cmRvd24oZCk7CiAgICAgZG9tYWluX3ZnaWNfZnJlZShkKTsKICAgICBkb21h
aW5fdnVhcnRfZnJlZShkKTsKICAgICBmcmVlX3hlbmhlYXBfcGFnZShkLT5z
aGFyZWRfaW5mbyk7CkBAIC0xMDA0LDYgKzEwMDQsNyBAQCBlbnVtIHsKICAg
ICBQUk9HX3hlbiwKICAgICBQUk9HX3BhZ2UsCiAgICAgUFJPR19tYXBwaW5n
LAorICAgIFBST0dfcDJtLAogICAgIFBST0dfZG9uZSwKIH07CiAKQEAgLTEw
NjQsNiArMTA2NSwxMSBAQCBpbnQgZG9tYWluX3JlbGlucXVpc2hfcmVzb3Vy
Y2VzKHN0cnVjdCBkb21haW4gKmQpCiAgICAgICAgIGlmICggcmV0ICkKICAg
ICAgICAgICAgIHJldHVybiByZXQ7CiAKKyAgICBQUk9HUkVTUyhwMm0pOgor
ICAgICAgICByZXQgPSBwMm1fdGVhcmRvd24oZCk7CisgICAgICAgIGlmICgg
cmV0ICkKKyAgICAgICAgICAgIHJldHVybiByZXQ7CisKICAgICBQUk9HUkVT
Uyhkb25lKToKICAgICAgICAgYnJlYWs7CiAKZGlmZiAtLWdpdCBhL3hlbi9h
cmNoL2FybS9pbmNsdWRlL2FzbS9wMm0uaCBiL3hlbi9hcmNoL2FybS9pbmNs
dWRlL2FzbS9wMm0uaAppbmRleCA4Y2NlNDU5YjY3YmEuLmExNWVhNjdmOWI0
OCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3AybS5o
CisrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9wMm0uaApAQCAtMTky
LDggKzE5MiwxNyBAQCB2b2lkIHNldHVwX3ZpcnRfcGFnaW5nKHZvaWQpOwog
LyogSW5pdCB0aGUgZGF0YXN0cnVjdHVyZXMgZm9yIGxhdGVyIHVzZSBieSB0
aGUgcDJtIGNvZGUgKi8KIGludCBwMm1faW5pdChzdHJ1Y3QgZG9tYWluICpk
KTsKIAotLyogUmV0dXJuIGFsbCB0aGUgcDJtIHJlc291cmNlcyB0byBYZW4u
ICovCi12b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKTsKKy8q
CisgKiBUaGUgUDJNIHJlc291cmNlcyBhcmUgZnJlZWQgaW4gdHdvIHBhcnRz
OgorICogIC0gcDJtX3RlYXJkb3duKCkgd2lsbCBiZSBjYWxsZWQgd2hlbiBy
ZWxpbnF1aXNoIHRoZSByZXNvdXJjZXMuIEl0CisgKiAgICB3aWxsIGZyZWUg
bGFyZ2UgcmVzb3VyY2VzIChlLmcuIGludGVybWVkaWF0ZSBwYWdlLXRhYmxl
cykgdGhhdAorICogICAgcmVxdWlyZXMgcHJlZW1wdGlvbi4KKyAqICAtIHAy
bV9maW5hbF90ZWFyZG93bigpIHdpbGwgYmUgY2FsbGVkIHdoZW4gZG9tYWlu
IHN0cnVjdCBpcyBiZWVuCisgKiAgICBmcmVlZC4gVGhpcyAqY2Fubm90KiBi
ZSBwcmVlbXB0ZWQgYW5kIHRoZXJlZm9yZSBvbmUgc21hbGwKKyAqICAgIHJl
c291cmNlcyBzaG91bGQgYmUgZnJlZWQgaGVyZS4KKyAqLworaW50IHAybV90
ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKTsKK3ZvaWQgcDJtX2ZpbmFsX3Rl
YXJkb3duKHN0cnVjdCBkb21haW4gKmQpOwogCiAvKgogICogUmVtb3ZlIG1h
cHBpbmcgcmVmY291bnQgb24gZWFjaCBtYXBwaW5nIHBhZ2UgaW4gdGhlIHAy
bQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gv
YXJtL3AybS5jCmluZGV4IGMyZTBiMTE2YzQ2Ny4uYjQ0NWY0ZDc1NDFlIDEw
MDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMKKysrIGIveGVuL2FyY2gv
YXJtL3AybS5jCkBAIC0xNTUxLDE3ICsxNTUxLDU4IEBAIHN0YXRpYyB2b2lk
IHAybV9mcmVlX3ZtaWQoc3RydWN0IGRvbWFpbiAqZCkKICAgICBzcGluX3Vu
bG9jaygmdm1pZF9hbGxvY19sb2NrKTsKIH0KIAotdm9pZCBwMm1fdGVhcmRv
d24oc3RydWN0IGRvbWFpbiAqZCkKK2ludCBwMm1fdGVhcmRvd24oc3RydWN0
IGRvbWFpbiAqZCkKIHsKICAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtID0g
cDJtX2dldF9ob3N0cDJtKGQpOworICAgIHVuc2lnbmVkIGxvbmcgY291bnQg
PSAwOwogICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOworICAgIHVuc2lnbmVk
IGludCBpOworICAgIGludCByYyA9IDA7CisKKyAgICBwMm1fd3JpdGVfbG9j
ayhwMm0pOworCisgICAgLyoKKyAgICAgKiBXZSBhcmUgYWJvdXQgdG8gZnJl
ZSB0aGUgaW50ZXJtZWRpYXRlIHBhZ2UtdGFibGVzLCBzbyBjbGVhciB0aGUK
KyAgICAgKiByb290IHRvIHByZXZlbnQgYW55IHdhbGsgdG8gdXNlIHRoZW0u
CisgICAgICovCisgICAgZm9yICggaSA9IDA7IGkgPCBQMk1fUk9PVF9QQUdF
UzsgaSsrICkKKyAgICAgICAgY2xlYXJfYW5kX2NsZWFuX3BhZ2UocDJtLT5y
b290ICsgaSk7CisKKyAgICAvKgorICAgICAqIFRoZSBkb21haW4gd2lsbCBu
b3QgYmUgc2NoZWR1bGVkIGFueW1vcmUsIHNvIGluIHRoZW9yeSB3ZSBzaG91
bGQKKyAgICAgKiBub3QgbmVlZCB0byBmbHVzaCB0aGUgVExCcy4gRG8gaXQg
Zm9yIHNhZmV0eSBwdXJwb3NlLgorICAgICAqCisgICAgICogTm90ZSB0aGF0
IGFsbCB0aGUgZGV2aWNlcyBoYXZlIGFscmVhZHkgYmVlbiBkZS1hc3NpZ25l
ZC4gU28gd2UgZG9uJ3QKKyAgICAgKiBuZWVkIHRvIGZsdXNoIHRoZSBJT01N
VSBUTEIgaGVyZS4KKyAgICAgKi8KKyAgICBwMm1fZm9yY2VfdGxiX2ZsdXNo
X3N5bmMocDJtKTsKKworICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3Jl
bW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQorICAgIHsKKyAgICAgICAgZnJl
ZV9kb21oZWFwX3BhZ2UocGcpOworICAgICAgICBjb3VudCsrOworICAgICAg
ICAvKiBBcmJpdHJhcmlseSBwcmVlbXB0IGV2ZXJ5IDUxMiBpdGVyYXRpb25z
ICovCisgICAgICAgIGlmICggIShjb3VudCAlIDUxMikgJiYgaHlwZXJjYWxs
X3ByZWVtcHRfY2hlY2soKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIHJj
ID0gLUVSRVNUQVJUOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0K
KyAgICB9CisKKyAgICBwMm1fd3JpdGVfdW5sb2NrKHAybSk7CisKKyAgICBy
ZXR1cm4gcmM7Cit9CisKK3ZvaWQgcDJtX2ZpbmFsX3RlYXJkb3duKHN0cnVj
dCBkb21haW4gKmQpCit7CisgICAgc3RydWN0IHAybV9kb21haW4gKnAybSA9
IHAybV9nZXRfaG9zdHAybShkKTsKIAogICAgIC8qIHAybSBub3QgYWN0dWFs
bHkgaW5pdGlhbGl6ZWQgKi8KICAgICBpZiAoICFwMm0tPmRvbWFpbiApCiAg
ICAgICAgIHJldHVybjsKIAotICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0
X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQotICAgICAgICBmcmVlX2Rv
bWhlYXBfcGFnZShwZyk7CisgICAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgm
cDJtLT5wYWdlcykpOwogCiAgICAgaWYgKCBwMm0tPnJvb3QgKQogICAgICAg
ICBmcmVlX2RvbWhlYXBfcGFnZXMocDJtLT5yb290LCBQMk1fUk9PVF9PUkRF
Uik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-03.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGFkZCBvcHRpb24gdG8gc2tpcCByb290IHBh
Z2V0YWJsZSByZW1vdmFsIGluIHAybV90ZWFyZG93bigpCgpBZGQgYSBuZXcg
cGFyYW1ldGVyIHRvIHAybV90ZWFyZG93bigpIGluIG9yZGVyIHRvIHNlbGVj
dCB3aGV0aGVyIHRoZQpyb290IHBhZ2UgdGFibGUgc2hvdWxkIGFsc28gYmUg
ZnJlZWQuICBOb3RlIHRoYXQgYWxsIHVzZXJzIGFyZQphZGp1c3RlZCB0byBw
YXNzIHRoZSBwYXJhbWV0ZXIgdG8gcmVtb3ZlIHRoZSByb290IHBhZ2UgdGFi
bGVzLCBzbwpiZWhhdmlvciBpcyBub3QgbW9kaWZpZWQuCgpObyBmdW5jdGlv
bmFsIGNoYW5nZSBpbnRlbmRlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTdWdnZXN0ZWQtYnk6IEp1bGllbiBHcmFs
bCA8anVsaWVuQHhlbi5vcmc+ClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBN
b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGltIERl
ZWdhbiA8dGltQHhlbi5vcmc+Ci0tLQpDaGFuZ2VzIHNpbmNlIHYxOgogLSBO
ZXcgaW4gdGhpcyB2ZXJzaW9uLgoKLS0tIGEveGVuL2FyY2gveDg2L2luY2x1
ZGUvYXNtL3AybS5oCisrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9w
Mm0uaApAQCAtNjAwLDcgKzYwMCw3IEBAIGludCBwMm1faW5pdChzdHJ1Y3Qg
ZG9tYWluICpkKTsKIGludCBwMm1fYWxsb2NfdGFibGUoc3RydWN0IHAybV9k
b21haW4gKnAybSk7CiAKIC8qIFJldHVybiBhbGwgdGhlIHAybSByZXNvdXJj
ZXMgdG8gWGVuLiAqLwotdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9k
b21haW4gKnAybSk7Cit2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2Rv
bWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290KTsKIHZvaWQgcDJtX2ZpbmFs
X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpOwogCiAvKiBBZGQvcmVtb3Zl
IGEgcGFnZSB0by9mcm9tIGEgZG9tYWluJ3MgcDJtIHRhYmxlLiAqLwotLS0g
YS94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCisrKyBiL3hlbi9hcmNoL3g4
Ni9tbS9oYXAvaGFwLmMKQEAgLTU0MSwxOCArNTQxLDE4IEBAIHZvaWQgaGFw
X2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgfQog
CiAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgTUFYX0FMVFAyTTsgaSsrICkK
LSAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNoLmFsdHAybV9wMm1b
aV0pOworICAgICAgICAgICAgcDJtX3RlYXJkb3duKGQtPmFyY2guYWx0cDJt
X3AybVtpXSwgdHJ1ZSk7CiAgICAgfQogCiAgICAgLyogRGVzdHJveSBuZXN0
ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZvciAoaSA9IDA7IGkgPCBNQVhfTkVT
VEVEUDJNOyBpKyspIHsKLSAgICAgICAgcDJtX3RlYXJkb3duKGQtPmFyY2gu
bmVzdGVkX3AybVtpXSk7CisgICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNo
Lm5lc3RlZF9wMm1baV0sIHRydWUpOwogICAgIH0KIAogICAgIGlmICggZC0+
YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3BhZ2VzICE9IDAgKQogICAgICAgICBo
YXBfdGVhcmRvd24oZCwgTlVMTCk7CiAKLSAgICBwMm1fdGVhcmRvd24ocDJt
X2dldF9ob3N0cDJtKGQpKTsKKyAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9o
b3N0cDJtKGQpLCB0cnVlKTsKICAgICAvKiBGcmVlIGFueSBtZW1vcnkgdGhh
dCB0aGUgcDJtIHRlYXJkb3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xv
Y2soZCk7CiAgICAgaGFwX3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwot
LS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLWJhc2ljLmMKKysrIGIveGVuL2Fy
Y2gveDg2L21tL3AybS1iYXNpYy5jCkBAIC0xNTQsMTAgKzE1NCwxMCBAQCBp
bnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCkKICAqIGh2bSBmaXhtZTog
d2hlbiBhZGRpbmcgc3VwcG9ydCBmb3IgcHZoIG5vbi1oYXJkd2FyZSBkb21h
aW5zLCB0aGlzIHBhdGggbXVzdAogICogY2xlYW51cCBhbnkgZm9yZWlnbiBw
Mm0gdHlwZXMgKHJlbGVhc2UgcmVmY250cyBvbiB0aGVtKS4KICAqLwotdm9p
ZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybSkKK3ZvaWQg
cDJtX3RlYXJkb3duKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIGJvb2wgcmVt
b3ZlX3Jvb3QpCiB7CiAjaWZkZWYgQ09ORklHX0hWTQotICAgIHN0cnVjdCBw
YWdlX2luZm8gKnBnOworICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnLCAqcm9v
dF9wZyA9IE5VTEw7CiAgICAgc3RydWN0IGRvbWFpbiAqZDsKIAogICAgIGlm
ICggIXAybSApCkBAIC0xNzEsMTAgKzE3MSwyMCBAQCB2b2lkIHAybV90ZWFy
ZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAgICAgQVNTRVJUKGF0b21p
Y19yZWFkKCZkLT5zaHJfcGFnZXMpID09IDApOwogI2VuZGlmCiAKLSAgICBw
Mm0tPnBoeXNfdGFibGUgPSBwYWdldGFibGVfbnVsbCgpOworICAgIGlmICgg
cmVtb3ZlX3Jvb3QgKQorICAgICAgICBwMm0tPnBoeXNfdGFibGUgPSBwYWdl
dGFibGVfbnVsbCgpOworICAgIGVsc2UgaWYgKCAhcGFnZXRhYmxlX2lzX251
bGwocDJtLT5waHlzX3RhYmxlKSApCisgICAgeworICAgICAgICByb290X3Bn
ID0gcGFnZXRhYmxlX2dldF9wYWdlKHAybS0+cGh5c190YWJsZSk7CisgICAg
ICAgIGNsZWFyX2RvbWFpbl9wYWdlKHBhZ2V0YWJsZV9nZXRfbWZuKHAybS0+
cGh5c190YWJsZSkpOworICAgIH0KIAogICAgIHdoaWxlICggKHBnID0gcGFn
ZV9saXN0X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQotICAgICAgICBk
LT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoZCwgcGcpOworICAgICAgICBpZiAo
IHBnICE9IHJvb3RfcGcgKQorICAgICAgICAgICAgZC0+YXJjaC5wYWdpbmcu
ZnJlZV9wYWdlKGQsIHBnKTsKKworICAgIGlmICggcm9vdF9wZyApCisgICAg
ICAgIHBhZ2VfbGlzdF9hZGQocm9vdF9wZywgJnAybS0+cGFnZXMpOwogCiAg
ICAgcDJtX3VubG9jayhwMm0pOwogI2VuZGlmCi0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9zaGFkb3cvY29tbW9uLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3No
YWRvdy9jb21tb24uYwpAQCAtMjcwNyw3ICsyNzA3LDcgQEAgaW50IHNoYWRv
d19lbmFibGUoc3RydWN0IGRvbWFpbiAqZCwgdTMyCiAgb3V0X3VubG9ja2Vk
OgogI2lmZGVmIENPTkZJR19IVk0KICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBh
Z2V0YWJsZV9pc19udWxsKHAybV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAg
ICAgICAgcDJtX3RlYXJkb3duKHAybSk7CisgICAgICAgIHAybV90ZWFyZG93
bihwMm0sIHRydWUpOwogI2VuZGlmCiAgICAgaWYgKCBydiAhPSAwICYmIHBn
ICE9IE5VTEwgKQogICAgIHsKQEAgLTI4NzMsNyArMjg3Myw3IEBAIHZvaWQg
c2hhZG93X2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4KICAgICAgICAg
c2hhZG93X3RlYXJkb3duKGQsIE5VTEwpOwogCiAgICAgLyogSXQgaXMgbm93
IHNhZmUgdG8gcHVsbCBkb3duIHRoZSBwMm0gbWFwLiAqLwotICAgIHAybV90
ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCkpOworICAgIHAybV90ZWFyZG93
bihwMm1fZ2V0X2hvc3RwMm0oZCksIHRydWUpOwogICAgIC8qIEZyZWUgYW55
IHNoYWRvdyBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJkb3duIHJlbGVhc2Vk
ICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgc2hhZG93X3NldF9hbGxv
Y2F0aW9uKGQsIDAsIE5VTEwpOwo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-01.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-01.patch"
Content-Transfer-Encoding: base64

RnJvbSBiZTFhNDJmNDk2ZjhkNTFmYzM2YzlhNjdhZDFmMzJlM2M3N2M2OWFm
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpEYXRlOiBNb24sIDYgSnVuIDIwMjIgMDY6
MTc6MjUgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvMl0geGVuL2FybTogcDJt
OiBQcmV2ZW50IGFkZGluZyBtYXBwaW5nIHdoZW4gZG9tYWluIGlzIGR5aW5n
CgpEdXJpbmcgdGhlIGRvbWFpbiBkZXN0cm95IHByb2Nlc3MsIHRoZSBkb21h
aW4gd2lsbCBzdGlsbCBiZSBhY2Nlc3NpYmxlCnVudGlsIGl0IGlzIGZ1bGx5
IGRlc3Ryb3llZC4gU28gZG9lcyB0aGUgUDJNIGJlY2F1c2Ugd2UgZG9uJ3Qg
YmFpbApvdXQgZWFybHkgaWYgaXNfZHlpbmcgaXMgbm9uLXplcm8uIElmIGEg
ZG9tYWluIGhhcyBwZXJtaXNzaW9uIHRvCm1vZGlmeSB0aGUgb3RoZXIgZG9t
YWluJ3MgUDJNIChpLmUuIGRvbTAsIG9yIGEgc3R1YmRvbWFpbiksIHRoZW4K
Zm9yZWlnbiBtYXBwaW5nIGNhbiBiZSBhZGRlZCBwYXN0IHJlbGlucXVpc2hf
cDJtX21hcHBpbmcoKS4KClRoZXJlZm9yZSwgd2UgbmVlZCB0byBwcmV2ZW50
IG1hcHBpbmcgdG8gYmUgYWRkZWQgd2hlbiB0aGUgZG9tYWluCmlzIGR5aW5n
LiBUaGlzIGNvbW1pdCBwcmV2ZW50cyBzdWNoIGFkZGluZyBvZiBtYXBwaW5n
IGJ5IGFkZGluZyB0aGUKZC0+aXNfZHlpbmcgY2hlY2sgdG8gcDJtX3NldF9l
bnRyeSgpLiBBbHNvIHRoaXMgY29tbWl0IGVuaGFuY2VzIHRoZQpjaGVjayBp
biByZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgdG8gbWFrZSBzdXJlIHRoYXQg
bm8gbWFwcGluZ3MgY2FuCmJlIGFkZGVkIGluIHRoZSBQMk0gYWZ0ZXIgdGhl
IFAyTSBsb2NrIGlzIHJlbGVhc2VkLgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0y
MDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IEp1bGllbiBH
cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEhlbnJ5
IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KVGVzdGVkLWJ5OiBIZW5yeSBX
YW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5OiBTdGVmYW5v
IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ci0tLQogeGVu
L2FyY2gvYXJtL3AybS5jIHwgMTEgKysrKysrKysrKysKIDEgZmlsZSBjaGFu
Z2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5jCmluZGV4IDk5M2ZlNGRl
ZDIxMi4uZmY3NDU3NzYzODBiIDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0v
cDJtLmMKKysrIGIveGVuL2FyY2gvYXJtL3AybS5jCkBAIC0xMDg5LDYgKzEw
ODksMTUgQEAgaW50IHAybV9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4g
KnAybSwKIHsKICAgICBpbnQgcmMgPSAwOwogCisgICAgLyoKKyAgICAgKiBB
bnkgcmVmZXJlbmNlIHRha2VuIGJ5IHRoZSBQMk0gbWFwcGluZ3MgKGUuZy4g
Zm9yZWlnbiBtYXBwaW5nKSB3aWxsCisgICAgICogYmUgZHJvcHBlZCBpbiBy
ZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkuIEFzIHRoZSBQMk0gd2lsbCBzdGls
bAorICAgICAqIGJlIGFjY2Vzc2libGUgYWZ0ZXIsIHdlIG5lZWQgdG8gcHJl
dmVudCBtYXBwaW5nIHRvIGJlIGFkZGVkIHdoZW4gdGhlCisgICAgICogZG9t
YWluIGlzIGR5aW5nLgorICAgICAqLworICAgIGlmICggdW5saWtlbHkocDJt
LT5kb21haW4tPmlzX2R5aW5nKSApCisgICAgICAgIHJldHVybiAtRU5PTUVN
OworCiAgICAgd2hpbGUgKCBuciApCiAgICAgewogICAgICAgICB1bnNpZ25l
ZCBsb25nIG1hc2s7CkBAIC0xNTc4LDYgKzE1ODcsOCBAQCBpbnQgcmVsaW5x
dWlzaF9wMm1fbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2ln
bmVkIGludCBvcmRlcjsKICAgICBnZm5fdCBzdGFydCwgZW5kOwogCisgICAg
QlVHX09OKCFkLT5pc19keWluZyk7CisgICAgLyogTm8gbWFwcGluZ3MgY2Fu
IGJlIGFkZGVkIGluIHRoZSBQMk0gYWZ0ZXIgdGhlIFAyTSBsb2NrIGlzIHJl
bGVhc2VkLiAqLwogICAgIHAybV93cml0ZV9sb2NrKHAybSk7CiAKICAgICBz
dGFydCA9IHAybS0+bG93ZXN0X21hcHBlZF9nZm47Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-02.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-02.patch"
Content-Transfer-Encoding: base64

RnJvbSAwMGUxNmY0YjcwYzQ3YzA5NjAyMjM0Y2NmZjFkY2VjNWNhMWVjYmZj
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpEYXRlOiBNb24sIDYgSnVuIDIwMjIgMDY6
MTc6MjYgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0geGVuL2FybTogcDJt
OiBIYW5kbGUgcHJlZW1wdGlvbiB3aGVuIGZyZWVpbmcgaW50ZXJtZWRpYXRl
CiBwYWdlIHRhYmxlcwoKQXQgdGhlIG1vbWVudCB0aGUgUDJNIHBhZ2UgdGFi
bGVzIHdpbGwgYmUgZnJlZWQgd2hlbiB0aGUgZG9tYWluIHN0cnVjdHVyZQpp
cyBmcmVlZCB3aXRob3V0IGFueSBwcmVlbXB0aW9uLiBBcyB0aGUgUDJNIGlz
IHF1aXRlIGxhcmdlLCBpdGVyYXRpbmcKdGhyb3VnaCB0aGlzIG1heSB0YWtl
IG1vcmUgdGltZSB0aGFuIGl0IGlzIHJlYXNvbmFibGUgd2l0aG91dCBpbnRl
cm1lZGlhdGUKcHJlZW1wdGlvbiAodG8gcnVuIHNvZnRpcnFzIGFuZCBwZXJo
YXBzIHNjaGVkdWxlcikuCgpTcGxpdCBwMm1fdGVhcmRvd24oKSBpbiB0d28g
cGFydHM6IG9uZSBwcmVlbXB0aWJsZSBhbmQgY2FsbGVkIHdoZW4KcmVsaW5x
dWlzaGluZyB0aGUgcmVzb3VyY2VzLCB0aGUgb3RoZXIgb25lIG5vbi1wcmVl
bXB0aWJsZSBhbmQgY2FsbGVkCndoZW4gZnJlZWluZyB0aGUgZG9tYWluIHN0
cnVjdHVyZS4KCkFzIHdlIGFyZSBub3cgZnJlZWluZyB0aGUgUDJNIHBhZ2Vz
IGVhcmx5LCB3ZSBhbHNvIG5lZWQgdG8gcHJldmVudApmdXJ0aGVyIGFsbG9j
YXRpb24gaWYgc29tZW9uZSBjYWxsIHAybV9zZXRfZW50cnkoKSBwYXN0IHAy
bV90ZWFyZG93bigpCihJIHdhc24ndCBhYmxlIHRvIHByb3ZlIHRoaXMgd2ls
bCBuZXZlciBoYXBwZW4pLiBUaGlzIGlzIGRvbmUgYnkKdGhlIGNoZWNraW5n
IGRvbWFpbi0+aXNfZHlpbmcgZnJvbSBwcmV2aW91cyBwYXRjaCBpbiBwMm1f
c2V0X2VudHJ5KCkuCgpTaW1pbGFybHksIHdlIHdhbnQgdG8gbWFrZSBzdXJl
IHRoYXQgbm8tb25lIGNhbiBhY2Nlc3NlZCB0aGUgZnJlZQpwYWdlcy4gVGhl
cmVmb3JlIHRoZSByb290IGlzIGNsZWFyZWQgYmVmb3JlIGZyZWVpbmcgcGFn
ZXMuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjItMzM3NDYgLyBYU0EtNDEw
LgoKU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u
LmNvbT4KU2lnbmVkLW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh
cm0uY29tPgpUZXN0ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt
LmNvbT4KUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl
bGxpbmlAa2VybmVsLm9yZz4KLS0tCiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMg
ICAgICAgIHwgMTIgKysrKysrKy0tCiB4ZW4vYXJjaC9hcm0vcDJtLmMgICAg
ICAgICAgIHwgNDcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
LS0tCiB4ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oIHwgIDEgKwogeGVu
L2luY2x1ZGUvYXNtLWFybS9wMm0uaCAgICB8IDEzICsrKysrKysrLS0KIDQg
ZmlsZXMgY2hhbmdlZCwgNjYgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo
LSkKCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMgYi94ZW4v
YXJjaC9hcm0vZG9tYWluLmMKaW5kZXggZGRlY2NiOTkyY2Y2Li4xZTI0YTdk
YmI0YTEgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYworKysg
Yi94ZW4vYXJjaC9hcm0vZG9tYWluLmMKQEAgLTc3NSwxMCArNzc1LDEwIEBA
IGZhaWw6CiB2b2lkIGFyY2hfZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRvbWFp
biAqZCkKIHsKICAgICAvKiBJT01NVSBwYWdlIHRhYmxlIGlzIHNoYXJlZCB3
aXRoIFAyTSwgYWx3YXlzIGNhbGwKLSAgICAgKiBpb21tdV9kb21haW5fZGVz
dHJveSgpIGJlZm9yZSBwMm1fdGVhcmRvd24oKS4KKyAgICAgKiBpb21tdV9k
b21haW5fZGVzdHJveSgpIGJlZm9yZSBwMm1fZmluYWxfdGVhcmRvd24oKS4K
ICAgICAgKi8KICAgICBpb21tdV9kb21haW5fZGVzdHJveShkKTsKLSAgICBw
Mm1fdGVhcmRvd24oZCk7CisgICAgcDJtX2ZpbmFsX3RlYXJkb3duKGQpOwog
ICAgIGRvbWFpbl92Z2ljX2ZyZWUoZCk7CiAgICAgZG9tYWluX3Z1YXJ0X2Zy
ZWUoZCk7CiAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+c2hhcmVkX2luZm8p
OwpAQCAtMTAxNCw2ICsxMDE0LDE0IEBAIGludCBkb21haW5fcmVsaW5xdWlz
aF9yZXNvdXJjZXMoc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAgaWYgKCBy
ZXQgKQogICAgICAgICAgICAgcmV0dXJuIHJldDsKIAorICAgICAgICBkLT5h
cmNoLnJlbG1lbSA9IFJFTE1FTV9wMm07CisgICAgICAgIC8qIEZhbGx0aHJv
dWdoICovCisKKyAgICBjYXNlIFJFTE1FTV9wMm06CisgICAgICAgIHJldCA9
IHAybV90ZWFyZG93bihkKTsKKyAgICAgICAgaWYgKCByZXQgKQorICAgICAg
ICAgICAgcmV0dXJuIHJldDsKKwogICAgICAgICBkLT5hcmNoLnJlbG1lbSA9
IFJFTE1FTV9kb25lOwogICAgICAgICAvKiBGYWxsdGhyb3VnaCAqLwogCmRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0v
cDJtLmMKaW5kZXggZmY3NDU3NzYzODBiLi40MjYzODc4N2EyOTUgMTAwNjQ0
Ci0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYworKysgYi94ZW4vYXJjaC9hcm0v
cDJtLmMKQEAgLTE0OTUsMTcgKzE0OTUsNTggQEAgc3RhdGljIHZvaWQgcDJt
X2ZyZWVfdm1pZChzdHJ1Y3QgZG9tYWluICpkKQogICAgIHNwaW5fdW5sb2Nr
KCZ2bWlkX2FsbG9jX2xvY2spOwogfQogCi12b2lkIHAybV90ZWFyZG93bihz
dHJ1Y3QgZG9tYWluICpkKQoraW50IHAybV90ZWFyZG93bihzdHJ1Y3QgZG9t
YWluICpkKQogewogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0gPSBwMm1f
Z2V0X2hvc3RwMm0oZCk7CisgICAgdW5zaWduZWQgbG9uZyBjb3VudCA9IDA7
CiAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CisgICAgdW5zaWduZWQgaW50
IGk7CisgICAgaW50IHJjID0gMDsKKworICAgIHAybV93cml0ZV9sb2NrKHAy
bSk7CisKKyAgICAvKgorICAgICAqIFdlIGFyZSBhYm91dCB0byBmcmVlIHRo
ZSBpbnRlcm1lZGlhdGUgcGFnZS10YWJsZXMsIHNvIGNsZWFyIHRoZQorICAg
ICAqIHJvb3QgdG8gcHJldmVudCBhbnkgd2FsayB0byB1c2UgdGhlbS4KKyAg
ICAgKi8KKyAgICBmb3IgKCBpID0gMDsgaSA8IFAyTV9ST09UX1BBR0VTOyBp
KysgKQorICAgICAgICBjbGVhcl9hbmRfY2xlYW5fcGFnZShwMm0tPnJvb3Qg
KyBpKTsKKworICAgIC8qCisgICAgICogVGhlIGRvbWFpbiB3aWxsIG5vdCBi
ZSBzY2hlZHVsZWQgYW55bW9yZSwgc28gaW4gdGhlb3J5IHdlIHNob3VsZAor
ICAgICAqIG5vdCBuZWVkIHRvIGZsdXNoIHRoZSBUTEJzLiBEbyBpdCBmb3Ig
c2FmZXR5IHB1cnBvc2UuCisgICAgICoKKyAgICAgKiBOb3RlIHRoYXQgYWxs
IHRoZSBkZXZpY2VzIGhhdmUgYWxyZWFkeSBiZWVuIGRlLWFzc2lnbmVkLiBT
byB3ZSBkb24ndAorICAgICAqIG5lZWQgdG8gZmx1c2ggdGhlIElPTU1VIFRM
QiBoZXJlLgorICAgICAqLworICAgIHAybV9mb3JjZV90bGJfZmx1c2hfc3lu
YyhwMm0pOworCisgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3Zl
X2hlYWQoJnAybS0+cGFnZXMpKSApCisgICAgeworICAgICAgICBmcmVlX2Rv
bWhlYXBfcGFnZShwZyk7CisgICAgICAgIGNvdW50Kys7CisgICAgICAgIC8q
IEFyYml0cmFyaWx5IHByZWVtcHQgZXZlcnkgNTEyIGl0ZXJhdGlvbnMgKi8K
KyAgICAgICAgaWYgKCAhKGNvdW50ICUgNTEyKSAmJiBoeXBlcmNhbGxfcHJl
ZW1wdF9jaGVjaygpICkKKyAgICAgICAgeworICAgICAgICAgICAgcmMgPSAt
RVJFU1RBUlQ7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAg
IH0KKworICAgIHAybV93cml0ZV91bmxvY2socDJtKTsKKworICAgIHJldHVy
biByYzsKK30KKwordm9pZCBwMm1fZmluYWxfdGVhcmRvd24oc3RydWN0IGRv
bWFpbiAqZCkKK3sKKyAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtID0gcDJt
X2dldF9ob3N0cDJtKGQpOwogCiAgICAgLyogcDJtIG5vdCBhY3R1YWxseSBp
bml0aWFsaXplZCAqLwogICAgIGlmICggIXAybS0+ZG9tYWluICkKICAgICAg
ICAgcmV0dXJuOwogCi0gICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVt
b3ZlX2hlYWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGZyZWVfZG9taGVh
cF9wYWdlKHBnKTsKKyAgICBBU1NFUlQocGFnZV9saXN0X2VtcHR5KCZwMm0t
PnBhZ2VzKSk7CiAKICAgICBpZiAoIHAybS0+cm9vdCApCiAgICAgICAgIGZy
ZWVfZG9taGVhcF9wYWdlcyhwMm0tPnJvb3QsIFAyTV9ST09UX09SREVSKTsK
ZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmggYi94
ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oCmluZGV4IGYxNzc2YzZjMDg5
OS4uOWI0NGE5NjQ4YzUwIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20t
YXJtL2RvbWFpbi5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWlu
LmgKQEAgLTYyLDYgKzYyLDcgQEAgc3RydWN0IGFyY2hfZG9tYWluCiAgICAg
ICAgIFJFTE1FTV94ZW4sCiAgICAgICAgIFJFTE1FTV9wYWdlLAogICAgICAg
ICBSRUxNRU1fbWFwcGluZywKKyAgICAgICAgUkVMTUVNX3AybSwKICAgICAg
ICAgUkVMTUVNX2RvbmUsCiAgICAgfSByZWxtZW07CiAKZGlmZiAtLWdpdCBh
L3hlbi9pbmNsdWRlL2FzbS1hcm0vcDJtLmggYi94ZW4vaW5jbHVkZS9hc20t
YXJtL3AybS5oCmluZGV4IDVmZGI2ZTgxODM0OC4uMjBkZjYyMTI3MTJlIDEw
MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCisrKyBiL3hl
bi9pbmNsdWRlL2FzbS1hcm0vcDJtLmgKQEAgLTE3MSw4ICsxNzEsMTcgQEAg
dm9pZCBzZXR1cF92aXJ0X3BhZ2luZyh2b2lkKTsKIC8qIEluaXQgdGhlIGRh
dGFzdHJ1Y3R1cmVzIGZvciBsYXRlciB1c2UgYnkgdGhlIHAybSBjb2RlICov
CiBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7CiAKLS8qIFJldHVy
biBhbGwgdGhlIHAybSByZXNvdXJjZXMgdG8gWGVuLiAqLwotdm9pZCBwMm1f
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCk7CisvKgorICogVGhlIFAyTSBy
ZXNvdXJjZXMgYXJlIGZyZWVkIGluIHR3byBwYXJ0czoKKyAqICAtIHAybV90
ZWFyZG93bigpIHdpbGwgYmUgY2FsbGVkIHdoZW4gcmVsaW5xdWlzaCB0aGUg
cmVzb3VyY2VzLiBJdAorICogICAgd2lsbCBmcmVlIGxhcmdlIHJlc291cmNl
cyAoZS5nLiBpbnRlcm1lZGlhdGUgcGFnZS10YWJsZXMpIHRoYXQKKyAqICAg
IHJlcXVpcmVzIHByZWVtcHRpb24uCisgKiAgLSBwMm1fZmluYWxfdGVhcmRv
d24oKSB3aWxsIGJlIGNhbGxlZCB3aGVuIGRvbWFpbiBzdHJ1Y3QgaXMgYmVl
bgorICogICAgZnJlZWQuIFRoaXMgKmNhbm5vdCogYmUgcHJlZW1wdGVkIGFu
ZCB0aGVyZWZvcmUgb25lIHNtYWxsCisgKiAgICByZXNvdXJjZXMgc2hvdWxk
IGJlIGZyZWVkIGhlcmUuCisgKi8KK2ludCBwMm1fdGVhcmRvd24oc3RydWN0
IGRvbWFpbiAqZCk7Cit2b2lkIHAybV9maW5hbF90ZWFyZG93bihzdHJ1Y3Qg
ZG9tYWluICpkKTsKIAogLyoKICAqIFJlbW92ZSBtYXBwaW5nIHJlZmNvdW50
IG9uIGVhY2ggbWFwcGluZyBwYWdlIGluIHRoZSBwMm0KLS0gCjIuMzcuMQoK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-03.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGFkZCBvcHRpb24gdG8gc2tpcCByb290IHBh
Z2V0YWJsZSByZW1vdmFsIGluIHAybV90ZWFyZG93bigpCgpBZGQgYSBuZXcg
cGFyYW1ldGVyIHRvIHAybV90ZWFyZG93bigpIGluIG9yZGVyIHRvIHNlbGVj
dCB3aGV0aGVyIHRoZQpyb290IHBhZ2UgdGFibGUgc2hvdWxkIGFsc28gYmUg
ZnJlZWQuICBOb3RlIHRoYXQgYWxsIHVzZXJzIGFyZQphZGp1c3RlZCB0byBw
YXNzIHRoZSBwYXJhbWV0ZXIgdG8gcmVtb3ZlIHRoZSByb290IHBhZ2UgdGFi
bGVzLCBzbwpiZWhhdmlvciBpcyBub3QgbW9kaWZpZWQuCgpObyBmdW5jdGlv
bmFsIGNoYW5nZSBpbnRlbmRlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTdWdnZXN0ZWQtYnk6IEp1bGllbiBHcmFs
bCA8anVsaWVuQHhlbi5vcmc+ClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBN
b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGltIERl
ZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2
L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTU5
OSw3ICs1OTksNyBAQCBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7
CiBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0p
OwogCiAvKiBSZXR1cm4gYWxsIHRoZSBwMm0gcmVzb3VyY2VzIHRvIFhlbi4g
Ki8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1fZG9tYWluICpwMm0p
Owordm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybSwg
Ym9vbCByZW1vdmVfcm9vdCk7CiB2b2lkIHAybV9maW5hbF90ZWFyZG93bihz
dHJ1Y3QgZG9tYWluICpkKTsKIAogLyogQWRkIGEgcGFnZSB0byBhIGRvbWFp
bidzIHAybSB0YWJsZSAqLwotLS0gYS94ZW4vYXJjaC94ODYvbW0vaGFwL2hh
cC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAgLTUyMSwx
OCArNTIxLDE4IEBAIHZvaWQgaGFwX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBk
b21haW4gKmQKICAgICAgICAgfQogCiAgICAgICAgIGZvciAoIGkgPSAwOyBp
IDwgTUFYX0FMVFAyTTsgaSsrICkKLSAgICAgICAgICAgIHAybV90ZWFyZG93
bihkLT5hcmNoLmFsdHAybV9wMm1baV0pOworICAgICAgICAgICAgcDJtX3Rl
YXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgdHJ1ZSk7CiAgICAgfQog
CiAgICAgLyogRGVzdHJveSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZv
ciAoaSA9IDA7IGkgPCBNQVhfTkVTVEVEUDJNOyBpKyspIHsKLSAgICAgICAg
cDJtX3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtpXSk7CisgICAgICAg
IHAybV90ZWFyZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIHRydWUpOwog
ICAgIH0KIAogICAgIGlmICggZC0+YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3Bh
Z2VzICE9IDAgKQogICAgICAgICBoYXBfdGVhcmRvd24oZCwgTlVMTCk7CiAK
LSAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpKTsKKyAgICBw
Mm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKICAgICAv
KiBGcmVlIGFueSBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJkb3duIHJlbGVh
c2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFwX3NldF9hbGxv
Y2F0aW9uKGQsIDAsIE5VTEwpOwotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJt
LmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03MzcsMTEgKzcz
NywxMSBAQCBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWlu
ICpwCiAgKiBodm0gZml4bWU6IHdoZW4gYWRkaW5nIHN1cHBvcnQgZm9yIHB2
aCBub24taGFyZHdhcmUgZG9tYWlucywgdGhpcyBwYXRoIG11c3QKICAqIGNs
ZWFudXAgYW55IGZvcmVpZ24gcDJtIHR5cGVzIChyZWxlYXNlIHJlZmNudHMg
b24gdGhlbSkuCiAgKi8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1f
ZG9tYWluICpwMm0pCit2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2Rv
bWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290KQogLyogUmV0dXJuIGFsbCB0
aGUgcDJtIHBhZ2VzIHRvIFhlbi4KICAqIFdlIGtub3cgd2UgZG9uJ3QgaGF2
ZSBhbnkgZXh0cmEgbWFwcGluZ3MgdG8gdGhlc2UgcGFnZXMgKi8KIHsKLSAg
ICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKKyAgICBzdHJ1Y3QgcGFnZV9pbmZv
ICpwZywgKnJvb3RfcGcgPSBOVUxMOwogICAgIHN0cnVjdCBkb21haW4gKmQ7
CiAKICAgICBpZiAocDJtID09IE5VTEwpCkBAIC03NTEsMTAgKzc1MSwyMiBA
QCB2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAK
ICAgICBwMm1fbG9jayhwMm0pOwogICAgIEFTU0VSVChhdG9taWNfcmVhZCgm
ZC0+c2hyX3BhZ2VzKSA9PSAwKTsKLSAgICBwMm0tPnBoeXNfdGFibGUgPSBw
YWdldGFibGVfbnVsbCgpOworCisgICAgaWYgKCByZW1vdmVfcm9vdCApCisg
ICAgICAgIHAybS0+cGh5c190YWJsZSA9IHBhZ2V0YWJsZV9udWxsKCk7Cisg
ICAgZWxzZSBpZiAoICFwYWdldGFibGVfaXNfbnVsbChwMm0tPnBoeXNfdGFi
bGUpICkKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBwYWdldGFibGVfZ2V0
X3BhZ2UocDJtLT5waHlzX3RhYmxlKTsKKyAgICAgICAgY2xlYXJfZG9tYWlu
X3BhZ2UocGFnZXRhYmxlX2dldF9tZm4ocDJtLT5waHlzX3RhYmxlKSk7Cisg
ICAgfQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGQtPmFyY2gucGFnaW5nLmZy
ZWVfcGFnZShkLCBwZyk7CisgICAgICAgIGlmICggcGcgIT0gcm9vdF9wZyAp
CisgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoZCwgcGcp
OworCisgICAgaWYgKCByb290X3BnICkKKyAgICAgICAgcGFnZV9saXN0X2Fk
ZChyb290X3BnLCAmcDJtLT5wYWdlcyk7CisKICAgICBwMm1fdW5sb2NrKHAy
bSk7CiB9CiAKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24u
YworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0y
Njg0LDcgKzI2ODQsNyBAQCBpbnQgc2hhZG93X2VuYWJsZShzdHJ1Y3QgZG9t
YWluICpkLCB1MzIKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogIG91dF91bmxv
Y2tlZDoKICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBhZ2V0YWJsZV9pc19udWxs
KHAybV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAgICAgICAgcDJtX3RlYXJk
b3duKHAybSk7CisgICAgICAgIHAybV90ZWFyZG93bihwMm0sIHRydWUpOwog
ICAgIGlmICggcnYgIT0gMCAmJiBwZyAhPSBOVUxMICkKICAgICB7CiAgICAg
ICAgIHBnLT5jb3VudF9pbmZvICY9IH5QR0NfY291bnRfbWFzazsKQEAgLTI4
MzUsNyArMjgzNSw3IEBAIHZvaWQgc2hhZG93X2ZpbmFsX3RlYXJkb3duKHN0
cnVjdCBkb21haW4KICAgICAgICAgc2hhZG93X3RlYXJkb3duKGQsIE5VTEwp
OwogCiAgICAgLyogSXQgaXMgbm93IHNhZmUgdG8gcHVsbCBkb3duIHRoZSBw
Mm0gbWFwLiAqLwotICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0o
ZCkpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIHRy
dWUpOwogICAgIC8qIEZyZWUgYW55IHNoYWRvdyBtZW1vcnkgdGhhdCB0aGUg
cDJtIHRlYXJkb3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7
CiAgICAgc2hhZG93X3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-04.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvSEFQOiBhZGp1c3QgbW9uaXRvciB0YWJsZSByZWxhdGVkIGVycm9y
IGhhbmRsaW5nCgpoYXBfbWFrZV9tb25pdG9yX3RhYmxlKCkgd2lsbCByZXR1
cm4gSU5WQUxJRF9NRk4gaWYgaXQgZW5jb3VudGVycyBhbgplcnJvciBjb25k
aXRpb24sIGJ1dCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcygpIHdhc27igJl0
IGhhbmRsaW5nIHRoaXMKdmFsdWUsIHJlc3VsdGluZyBpbiBhbiBpbmFwcHJv
cHJpYXRlIHZhbHVlIGJlaW5nIHN0b3JlZCBpbgptb25pdG9yX3RhYmxlLiBU
aGlzIHdvdWxkIHN1YnNlcXVlbnRseSBtaXNndWlkZSBhdCBsZWFzdApoYXBf
dmNwdV90ZWFyZG93bigpLiBBdm9pZCB0aGlzIGJ5IGJhaWxpbmcgZWFybHku
CgpGdXJ0aGVyLCB3aGVuIGEgZG9tYWluIGhhcy93YXMgYWxyZWFkeSBjcmFz
aGVkIG9yIChwZXJoYXBzIGxlc3MKaW1wb3J0YW50IGFzIHRoZXJlJ3Mgbm8g
c3VjaCBwYXRoIGtub3duIHRvIGxlYWQgaGVyZSkgaXMgYWxyZWFkeSBkeWlu
ZywKYXZvaWQgY2FsbGluZyBkb21haW5fY3Jhc2goKSBvbiBpdCBhZ2FpbiAt
IHRoYXQncyBhdCBiZXN0IGNvbmZ1c2luZy4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBSb2dl
ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KCi0tLSBhL3hl
bi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYwpAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgPGFzbS9k
b21haW4uaD4KICNpbmNsdWRlIDx4ZW4vbnVtYS5oPgogI2luY2x1ZGUgPGFz
bS9odm0vbmVzdGVkaHZtLmg+CisjaW5jbHVkZSA8cHVibGljL3NjaGVkLmg+
CiAKICNpbmNsdWRlICJwcml2YXRlLmgiCiAKQEAgLTQwNSw4ICs0MDYsMTMg
QEAgc3RhdGljIG1mbl90IGhhcF9tYWtlX21vbml0b3JfdGFibGUoc3RydQog
ICAgIHJldHVybiBtNG1mbjsKIAogIG9vbToKLSAgICBwcmludGsoWEVOTE9H
X0dfRVJSICJvdXQgb2YgbWVtb3J5IGJ1aWxkaW5nIG1vbml0b3IgcGFnZXRh
YmxlXG4iKTsKLSAgICBkb21haW5fY3Jhc2goZCk7CisgICAgaWYgKCAhZC0+
aXNfZHlpbmcgJiYKKyAgICAgICAgICghZC0+aXNfc2h1dHRpbmdfZG93biB8
fCBkLT5zaHV0ZG93bl9jb2RlICE9IFNIVVRET1dOX2NyYXNoKSApCisgICAg
eworICAgICAgICBwcmludGsoWEVOTE9HX0dfRVJSICIlcGQ6IG91dCBvZiBt
ZW1vcnkgYnVpbGRpbmcgbW9uaXRvciBwYWdldGFibGVcbiIsCisgICAgICAg
ICAgICAgICBkKTsKKyAgICAgICAgZG9tYWluX2NyYXNoKGQpOworICAgIH0K
ICAgICByZXR1cm4gSU5WQUxJRF9NRk47CiB9CiAKQEAgLTY5Myw2ICs2OTks
OSBAQCBzdGF0aWMgdm9pZCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1
CiAgICAgaWYgKCBwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLm1vbml0b3Jf
dGFibGUpICkKICAgICB7CiAgICAgICAgIG1mbl90IG1tZm4gPSBoYXBfbWFr
ZV9tb25pdG9yX3RhYmxlKHYpOworCisgICAgICAgIGlmICggbWZuX2VxKG1t
Zm4sIElOVkFMSURfTUZOKSApCisgICAgICAgICAgICBnb3RvIHVubG9jazsK
ICAgICAgICAgdi0+YXJjaC5tb25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX2Zy
b21fbWZuKG1tZm4pOwogICAgICAgICBtYWtlX2NyMyh2LCBtbWZuKTsKICAg
ICAgICAgaHZtX3VwZGF0ZV9ob3N0X2NyMyh2KTsKQEAgLTcwMSw2ICs3MTAs
NyBAQCBzdGF0aWMgdm9pZCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1
CiAgICAgLyogQ1IzIGlzIGVmZmVjdGl2ZWx5IHVwZGF0ZWQgYnkgYSBtb2Rl
IGNoYW5nZS4gRmx1c2ggQVNJRHMsIGV0Yy4gKi8KICAgICBoYXBfdXBkYXRl
X2NyMyh2LCAwLCBmYWxzZSk7CiAKKyB1bmxvY2s6CiAgICAgcGFnaW5nX3Vu
bG9jayhkKTsKICAgICBwdXRfZ2ZuKGQsIGNyM19nZm4pOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-05.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvc2hhZG93OiB0b2xlcmF0ZSBmYWlsdXJlIG9mIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKQoKU3Vic2VxdWVudGx5IHNoX3NldF90b3BsZXZlbF9z
aGFkb3coKSB3aWxsIGJlIGFkanVzdGVkIHRvIGluc3RhbGwgYQpibGFuayBl
bnRyeSBpbiBjYXNlIHByZWFsbG9jIGZhaWxzLiBUaGVyZSBhcmUsIGluIGZh
Y3QsIHByZS1leGlzdGluZwplcnJvciBwYXRocyB3aGljaCB3b3VsZCBwdXQg
aW4gcGxhY2UgYSBibGFuayBlbnRyeS4gVGhlIDQtIGFuZCAyLWxldmVsCmNv
ZGUgaW4gc2hfdXBkYXRlX2NyMygpLCBob3dldmVyLCBhc3N1bWUgdGhlIHRv
cCBsZXZlbCBlbnRyeSB0byBiZQp2YWxpZC4KCkhlbmNlIGJhaWwgZnJvbSB0
aGUgZnVuY3Rpb24gaW4gdGhlIHVubGlrZWx5IGV2ZW50IHRoYXQgaXQncyBu
b3QuIE5vdGUKdGhhdCAzLWxldmVsIGxvZ2ljIHdvcmtzIGRpZmZlcmVudGx5
OiBJbiBwYXJ0aWN1bGFyIGEgZ3Vlc3QgaXMgZnJlZSB0bwpzdXBwbHkgYSBQ
RFBUUiBwb2ludGluZyBhdCA0IG5vbi1wcmVzZW50IChvciBvdGhlcndpc2Ug
ZGVlbWVkIGludmFsaWQpCmVudHJpZXMuIFRoZSBndWVzdCB3aWxsIGNyYXNo
LCBidXQgd2UgYWxyZWFkeSBjb3BlIHdpdGggdGhhdC4KClJlYWxseSBtZm5f
dmFsaWQoKSBpcyBsaWtlbHkgd3JvbmcgdG8gdXNlIGluIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKSwKYW5kIGl0IHNob3VsZCBpbnN0ZWFkIGJlICFtZm5f
ZXEoZ21mbiwgSU5WQUxJRF9NRk4pLiBBdm9pZCBzdWNoIGEgY2hhbmdlCmlu
IHNlY3VyaXR5IGNvbnRleHQsIGJ1dCBhZGQgYSByZXNwZWN0aXZlIGFzc2Vy
dGlvbi4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00
MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KUmV2
aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMK
KysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCkBAIC0zODYx
LDYgKzM4NjEsNyBAQCBzaF9zZXRfdG9wbGV2ZWxfc2hhZG93KHN0cnVjdCB2
Y3B1ICp2LAogICAgIC8qIE5vdyBmaWd1cmUgb3V0IHRoZSBuZXcgY29udGVu
dHM6IGlzIHRoaXMgYSB2YWxpZCBndWVzdCBNRk4/ICovCiAgICAgaWYgKCAh
bWZuX3ZhbGlkKGdtZm4pICkKICAgICB7CisgICAgICAgIEFTU0VSVChtZm5f
ZXEoZ21mbiwgSU5WQUxJRF9NRk4pKTsKICAgICAgICAgbmV3X2VudHJ5ID0g
cGFnZXRhYmxlX251bGwoKTsKICAgICAgICAgZ290byBpbnN0YWxsX25ld19l
bnRyeTsKICAgICB9CkBAIC00MDE0LDYgKzQwMTUsMTEgQEAgc2hfdXBkYXRl
X2NyMyhzdHJ1Y3QgdmNwdSAqdiwgaW50IGRvX2xvYwogICAgIGlmICggc2hf
cmVtb3ZlX3dyaXRlX2FjY2VzcyhkLCBnbWZuLCAyLCAwKSAhPSAwICkKICAg
ICAgICAgZmx1c2hfdGxiX21hc2soZC0+ZGlydHlfY3B1bWFzayk7CiAgICAg
c2hfc2V0X3RvcGxldmVsX3NoYWRvdyh2LCAwLCBnbWZuLCBTSF90eXBlX2wy
X3NoYWRvdyk7CisgICAgaWYgKCB1bmxpa2VseShwYWdldGFibGVfaXNfbnVs
bCh2LT5hcmNoLnNoYWRvd190YWJsZVswXSkpICkKKyAgICB7CisgICAgICAg
IEFTU0VSVChkLT5pc19keWluZyB8fCBkLT5pc19zaHV0dGluZ19kb3duKTsK
KyAgICAgICAgcmV0dXJuOworICAgIH0KICNlbGlmIEdVRVNUX1BBR0lOR19M
RVZFTFMgPT0gMwogICAgIC8qIFBBRSBndWVzdHMgaGF2ZSBmb3VyIHNoYWRv
d190YWJsZSBlbnRyaWVzLCBiYXNlZCBvbiB0aGUKICAgICAgKiBjdXJyZW50
IHZhbHVlcyBvZiB0aGUgZ3Vlc3QncyBmb3VyIGwzZXMuICovCkBAIC00MDU5
LDYgKzQwNjUsMTEgQEAgc2hfdXBkYXRlX2NyMyhzdHJ1Y3QgdmNwdSAqdiwg
aW50IGRvX2xvYwogICAgIGlmICggc2hfcmVtb3ZlX3dyaXRlX2FjY2Vzcyhk
LCBnbWZuLCA0LCAwKSAhPSAwICkKICAgICAgICAgZmx1c2hfdGxiX21hc2so
ZC0+ZGlydHlfY3B1bWFzayk7CiAgICAgc2hfc2V0X3RvcGxldmVsX3NoYWRv
dyh2LCAwLCBnbWZuLCBTSF90eXBlX2w0X3NoYWRvdyk7CisgICAgaWYgKCB1
bmxpa2VseShwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLnNoYWRvd190YWJs
ZVswXSkpICkKKyAgICB7CisgICAgICAgIEFTU0VSVChkLT5pc19keWluZyB8
fCBkLT5pc19zaHV0dGluZ19kb3duKTsKKyAgICAgICAgcmV0dXJuOworICAg
IH0KICAgICBpZiAoICFzaGFkb3dfbW9kZV9leHRlcm5hbChkKSAmJiAhaXNf
cHZfMzJiaXRfZG9tYWluKGQpICkKICAgICB7CiAgICAgICAgIG1mbl90IHNt
Zm4gPSBwYWdldGFibGVfZ2V0X21mbih2LT5hcmNoLnNoYWRvd190YWJsZVsw
XSk7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-06.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9zaGFkb3c6IHRvbGVyYXRlIGZhaWx1cmUgaW4gc2hh
ZG93X3ByZWFsbG9jKCkKClByZXZlbnQgX3NoYWRvd19wcmVhbGxvYygpIGZy
b20gY2FsbGluZyBCVUcoKSB3aGVuIHVuYWJsZSB0byBmdWxmaWxsCnRoZSBw
cmUtYWxsb2NhdGlvbiBhbmQgaW5zdGVhZCByZXR1cm4gdHJ1ZS9mYWxzZS4g
IE1vZGlmeQpzaGFkb3dfcHJlYWxsb2MoKSB0byBjcmFzaCB0aGUgZG9tYWlu
IG9uIGFsbG9jYXRpb24gZmFpbHVyZSAoaWYgdGhlCmRvbWFpbiBpcyBub3Qg
YWxyZWFkeSBkeWluZyksIGFzIHNoYWRvdyBjYW5ub3Qgb3BlcmF0ZSBub3Jt
YWxseSBhZnRlcgp0aGF0LiAgTW9kaWZ5IGNhbGxlcnMgdG8gYWxzbyBncmFj
ZWZ1bGx5IGhhbmRsZSB7Xyx9c2hhZG93X3ByZWFsbG9jKCkKZmFpbGluZyB0
byBmdWxmaWxsIHRoZSByZXF1ZXN0LgoKTm90ZSB0aGlzIGluIHR1cm4gcmVx
dWlyZXMgYWRqdXN0aW5nIHRoZSBjYWxsZXJzIG9mCnNoX21ha2VfbW9uaXRv
cl90YWJsZSgpIGFsc28gdG8gaGFuZGxlIGl0IHJldHVybmluZyBJTlZBTElE
X01GTi4Kc2hfdXBkYXRlX3BhZ2luZ19tb2RlcygpIGlzIGFsc28gbW9kaWZp
ZWQgdG8gYWRkIGFkZGl0aW9uYWwgZXJyb3IKcGF0aHMgaW4gY2FzZSBvZiBh
bGxvY2F0aW9uIGZhaWx1cmUsIHNvbWUgb2YgdGhvc2Ugd2lsbCByZXR1cm4g
d2l0aApudWxsIG1vbml0b3IgcGFnZSB0YWJsZXMgKGFuZCB0aGUgZG9tYWlu
IGxpa2VseSBjcmFzaGVkKS4gIFRoaXMgaXMgbm8KZGlmZmVyZW50IHRoYXQg
Y3VycmVudCBlcnJvciBwYXRocywgYnV0IHRoZSBuZXdseSBpbnRyb2R1Y2Vk
IG9uZXMgYXJlCm1vcmUgbGlrZWx5IHRvIHRyaWdnZXIuCgpUaGUgbm93IGFk
ZGVkIGZhaWx1cmUgcG9pbnRzIGluIHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMo
KSBhbHNvIHJlcXVpcmUKdGhhdCBvbiBzb21lIGVycm9yIHJldHVybiBwYXRo
cyB0aGUgcHJldmlvdXMgc3RydWN0dXJlcyBhcmUgY2xlYXJlZCwKYW5kIHRo
dXMgbW9uaXRvciB0YWJsZSBpcyBudWxsLgoKV2hpbGUgdGhlcmUgYWRqdXN0
IHRoZSAndHlwZScgcGFyYW1ldGVyIHR5cGUgb2Ygc2hhZG93X3ByZWFsbG9j
KCkgdG8KdW5zaWduZWQgaW50IHJhdGhlciB0aGFuIHUzMi4KClRoaXMgaXMg
cGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PgpBY2tlZC1ieTogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94
ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCisrKyBiL3hlbi9hcmNo
L3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKQEAgLTM2LDYgKzM2LDcgQEAKICNp
bmNsdWRlIDxhc20vc2hhZG93Lmg+CiAjaW5jbHVkZSA8YXNtL2h2bS9pb3Jl
cS5oPgogI2luY2x1ZGUgPHhlbi9udW1hLmg+CisjaW5jbHVkZSA8cHVibGlj
L3NjaGVkLmg+CiAjaW5jbHVkZSAicHJpdmF0ZS5oIgogCiBERUZJTkVfUEVS
X0NQVSh1aW50MzJfdCx0cmFjZV9zaGFkb3dfcGF0aF9mbGFncyk7CkBAIC04
OTYsMTQgKzg5NywxNSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgdHJhY2Vfc2hh
ZG93X3ByZWFsbG9jCiAKIC8qIE1ha2Ugc3VyZSB0aGVyZSBhcmUgYXQgbGVh
c3QgY291bnQgb3JkZXItc2l6ZWQgcGFnZXMKICAqIGF2YWlsYWJsZSBpbiB0
aGUgc2hhZG93IHBhZ2UgcG9vbC4gKi8KLXN0YXRpYyB2b2lkIF9zaGFkb3df
cHJlYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHBhZ2Vz
KQorc3RhdGljIGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsb2Mo
c3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHBhZ2VzKQogewogICAg
IHN0cnVjdCB2Y3B1ICp2OwogICAgIHN0cnVjdCBwYWdlX2luZm8gKnNwLCAq
dDsKICAgICBtZm5fdCBzbWZuOwogICAgIGludCBpOwogCi0gICAgaWYgKCBk
LT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcyA+PSBwYWdlcyApIHJl
dHVybjsKKyAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3Bh
Z2VzID49IHBhZ2VzICkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAv
KiBTaG91bGRuJ3QgaGF2ZSBlbmFibGVkIHNoYWRvd3MgaWYgd2UndmUgbm8g
dmNwdXMuICovCiAgICAgQVNTRVJUKGQtPnZjcHUgJiYgZC0+dmNwdVswXSk7
CkBAIC05MTksNyArOTIxLDggQEAgc3RhdGljIHZvaWQgX3NoYWRvd19wcmVh
bGxvYyhzdHJ1Y3QgZG9tYQogICAgICAgICBzaF91bnBpbihkLCBzbWZuKTsK
IAogICAgICAgICAvKiBTZWUgaWYgdGhhdCBmcmVlZCB1cCBlbm91Z2ggc3Bh
Y2UgKi8KLSAgICAgICAgaWYgKCBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJl
ZV9wYWdlcyA+PSBwYWdlcyApIHJldHVybjsKKyAgICAgICAgaWYgKCBkLT5h
cmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcyA+PSBwYWdlcyApCisgICAg
ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICAvKiBTdGFnZSB0
d286IGFsbCBzaGFkb3cgcGFnZXMgYXJlIGluIHVzZSBpbiBoaWVyYXJjaGll
cyB0aGF0IGFyZQpAQCAtOTQwLDcgKzk0Myw3IEBAIHN0YXRpYyB2b2lkIF9z
aGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWEKICAgICAgICAgICAgICAgICBp
ZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2Vz
ICkKICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgIGZs
dXNoX3RsYl9tYXNrKGQtPmRpcnR5X2NwdW1hc2spOwotICAgICAgICAgICAg
ICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgICAgIHJldHVybiB0
cnVlOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAg
ICAgfQpAQCAtOTUzLDcgKzk1NiwxMiBAQCBzdGF0aWMgdm9pZCBfc2hhZG93
X3ByZWFsbG9jKHN0cnVjdCBkb21hCiAgICAgICAgICAgIGQtPmFyY2gucGFn
aW5nLnNoYWRvdy50b3RhbF9wYWdlcywKICAgICAgICAgICAgZC0+YXJjaC5w
YWdpbmcuc2hhZG93LmZyZWVfcGFnZXMsCiAgICAgICAgICAgIGQtPmFyY2gu
cGFnaW5nLnNoYWRvdy5wMm1fcGFnZXMpOwotICAgIEJVRygpOworCisgICAg
QVNTRVJUKGQtPmlzX2R5aW5nKTsKKworICAgIGZsdXNoX3RsYl9tYXNrKGQt
PmRpcnR5X2NwdW1hc2spOworCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiAv
KiBNYWtlIHN1cmUgdGhlcmUgYXJlIGF0IGxlYXN0IGNvdW50IHBhZ2VzIG9m
IHRoZSBvcmRlciBhY2NvcmRpbmcgdG8KQEAgLTk2MSw5ICs5NjksMTkgQEAg
c3RhdGljIHZvaWQgX3NoYWRvd19wcmVhbGxvYyhzdHJ1Y3QgZG9tYQogICog
VGhpcyBtdXN0IGJlIGNhbGxlZCBiZWZvcmUgYW55IGNhbGxzIHRvIHNoYWRv
d19hbGxvYygpLiAgU2luY2UgdGhpcwogICogd2lsbCBmcmVlIGV4aXN0aW5n
IHNoYWRvd3MgdG8gbWFrZSByb29tLCBpdCBtdXN0IGJlIGNhbGxlZCBlYXJs
eSBlbm91Z2gKICAqIHRvIGF2b2lkIGZyZWVpbmcgc2hhZG93cyB0aGF0IHRo
ZSBjYWxsZXIgaXMgY3VycmVudGx5IHdvcmtpbmcgb24uICovCi12b2lkIHNo
YWRvd19wcmVhbGxvYyhzdHJ1Y3QgZG9tYWluICpkLCB1MzIgdHlwZSwgdW5z
aWduZWQgaW50IGNvdW50KQorYm9vbCBzaGFkb3dfcHJlYWxsb2Moc3RydWN0
IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHR5cGUsIHVuc2lnbmVkIGludCBj
b3VudCkKIHsKLSAgICByZXR1cm4gX3NoYWRvd19wcmVhbGxvYyhkLCBzaGFk
b3dfc2l6ZSh0eXBlKSAqIGNvdW50KTsKKyAgICBib29sIHJldCA9IF9zaGFk
b3dfcHJlYWxsb2MoZCwgc2hhZG93X3NpemUodHlwZSkgKiBjb3VudCk7CisK
KyAgICBpZiAoICFyZXQgJiYgIWQtPmlzX2R5aW5nICYmCisgICAgICAgICAo
IWQtPmlzX3NodXR0aW5nX2Rvd24gfHwgZC0+c2h1dGRvd25fY29kZSAhPSBT
SFVURE9XTl9jcmFzaCkgKQorICAgICAgICAvKgorICAgICAgICAgKiBGYWls
aW5nIHRvIGFsbG9jYXRlIG1lbW9yeSByZXF1aXJlZCBmb3Igc2hhZG93IHVz
YWdlIGNhbiBvbmx5IHJlc3VsdCBpbgorICAgICAgICAgKiBhIGRvbWFpbiBj
cmFzaCwgZG8gaXQgaGVyZSByYXRoZXIgdGhhdCByZWx5aW5nIG9uIGV2ZXJ5
IGNhbGxlciB0byBkbyBpdC4KKyAgICAgICAgICovCisgICAgICAgIGRvbWFp
bl9jcmFzaChkKTsKKworICAgIHJldHVybiByZXQ7CiB9CiAKIC8qIERlbGli
ZXJhdGVseSBmcmVlIGFsbCB0aGUgbWVtb3J5IHdlIGNhbjogdGhpcyB3aWxs
IHRlYXIgZG93biBhbGwgb2YKQEAgLTExODYsNyArMTIwNCw3IEBAIHZvaWQg
c2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3QKIHN0YXRpYyBz
dHJ1Y3QgcGFnZV9pbmZvICoKIHNoYWRvd19hbGxvY19wMm1fcGFnZShzdHJ1
Y3QgZG9tYWluICpkKQogewotICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOwor
ICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnID0gTlVMTDsKIAogICAgIC8qIFRo
aXMgaXMgY2FsbGVkIGJvdGggZnJvbSB0aGUgcDJtIGNvZGUgKHdoaWNoIG5l
dmVyIGhvbGRzIHRoZQogICAgICAqIHBhZ2luZyBsb2NrKSBhbmQgdGhlIGxv
Zy1kaXJ0eSBjb2RlICh3aGljaCBhbHdheXMgZG9lcykuICovCkBAIC0xMjA0
LDE2ICsxMjIyLDE4IEBAIHNoYWRvd19hbGxvY19wMm1fcGFnZShzdHJ1Y3Qg
ZG9tYWluICpkKQogICAgICAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2lu
Zy5zaGFkb3cucDJtX3BhZ2VzLAogICAgICAgICAgICAgICAgICAgICBzaGFk
b3dfbWluX2FjY2VwdGFibGVfcGFnZXMoZCkpOwogICAgICAgICB9Ci0gICAg
ICAgIHBhZ2luZ191bmxvY2soZCk7Ci0gICAgICAgIHJldHVybiBOVUxMOwor
ICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICBzaGFkb3dfcHJlYWxs
b2MoZCwgU0hfdHlwZV9wMm1fdGFibGUsIDEpOworICAgIGlmICggIXNoYWRv
d19wcmVhbGxvYyhkLCBTSF90eXBlX3AybV90YWJsZSwgMSkgKQorICAgICAg
ICBnb3RvIG91dDsKKwogICAgIHBnID0gbWZuX3RvX3BhZ2Uoc2hhZG93X2Fs
bG9jKGQsIFNIX3R5cGVfcDJtX3RhYmxlLCAwKSk7CiAgICAgZC0+YXJjaC5w
YWdpbmcuc2hhZG93LnAybV9wYWdlcysrOwogICAgIGQtPmFyY2gucGFnaW5n
LnNoYWRvdy50b3RhbF9wYWdlcy0tOwogICAgIEFTU0VSVCghcGFnZV9nZXRf
b3duZXIocGcpICYmICEocGctPmNvdW50X2luZm8gJiBQR0NfY291bnRfbWFz
aykpOwogCisgb3V0OgogICAgIHBhZ2luZ191bmxvY2soZCk7CiAKICAgICBy
ZXR1cm4gcGc7CkBAIC0xMzA0LDcgKzEzMjQsOSBAQCBpbnQgc2hhZG93X3Nl
dF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4KICAgICAgICAgZWxzZSBpZiAo
IGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9wYWdlcyA+IHBhZ2VzICkK
ICAgICAgICAgewogICAgICAgICAgICAgLyogTmVlZCB0byByZXR1cm4gbWVt
b3J5IHRvIGRvbWhlYXAgKi8KLSAgICAgICAgICAgIF9zaGFkb3dfcHJlYWxs
b2MoZCwgMSk7CisgICAgICAgICAgICBpZiAoICFfc2hhZG93X3ByZWFsbG9j
KGQsIDEpICkKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKKwog
ICAgICAgICAgICAgc3AgPSBwYWdlX2xpc3RfcmVtb3ZlX2hlYWQoJmQtPmFy
Y2gucGFnaW5nLnNoYWRvdy5mcmVlbGlzdCk7CiAgICAgICAgICAgICBBU1NF
UlQoc3ApOwogICAgICAgICAgICAgLyoKQEAgLTIzOTYsMTIgKzI0MTgsMTMg
QEAgc3RhdGljIHZvaWQgc2hfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1Ywog
ICAgIGlmICggbWZuX2VxKHYtPmFyY2gucGFnaW5nLnNoYWRvdy5vb3Nfc25h
cHNob3RbMF0sIElOVkFMSURfTUZOKSApCiAgICAgewogICAgICAgICBpbnQg
aTsKKworICAgICAgICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlw
ZV9vb3Nfc25hcHNob3QsIFNIQURPV19PT1NfUEFHRVMpICkKKyAgICAgICAg
ICAgIHJldHVybjsKKwogICAgICAgICBmb3IoaSA9IDA7IGkgPCBTSEFET1df
T09TX1BBR0VTOyBpKyspCi0gICAgICAgIHsKLSAgICAgICAgICAgIHNoYWRv
d19wcmVhbGxvYyhkLCBTSF90eXBlX29vc19zbmFwc2hvdCwgMSk7CiAgICAg
ICAgICAgICB2LT5hcmNoLnBhZ2luZy5zaGFkb3cub29zX3NuYXBzaG90W2ld
ID0KICAgICAgICAgICAgICAgICBzaGFkb3dfYWxsb2MoZCwgU0hfdHlwZV9v
b3Nfc25hcHNob3QsIDApOwotICAgICAgICB9CiAgICAgfQogI2VuZGlmIC8q
IE9PUyAqLwogCkBAIC0yNDYzLDYgKzI0ODYsMTAgQEAgc3RhdGljIHZvaWQg
c2hfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1YwogICAgICAgICBpZiAoIHBh
Z2V0YWJsZV9pc19udWxsKHYtPmFyY2gubW9uaXRvcl90YWJsZSkgKQogICAg
ICAgICB7CiAgICAgICAgICAgICBtZm5fdCBtbWZuID0gdi0+YXJjaC5wYWdp
bmcubW9kZS0+c2hhZG93Lm1ha2VfbW9uaXRvcl90YWJsZSh2KTsKKworICAg
ICAgICAgICAgaWYgKCBtZm5fZXEobW1mbiwgSU5WQUxJRF9NRk4pICkKKyAg
ICAgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgICAgIHYtPmFyY2gu
bW9uaXRvcl90YWJsZSA9IHBhZ2V0YWJsZV9mcm9tX21mbihtbWZuKTsKICAg
ICAgICAgICAgIG1ha2VfY3IzKHYsIG1tZm4pOwogICAgICAgICAgICAgaHZt
X3VwZGF0ZV9ob3N0X2NyMyh2KTsKQEAgLTI1MDAsNiArMjUyNywxMSBAQCBz
dGF0aWMgdm9pZCBzaF91cGRhdGVfcGFnaW5nX21vZGVzKHN0cnVjCiAgICAg
ICAgICAgICAgICAgb2xkX21mbiA9IHBhZ2V0YWJsZV9nZXRfbWZuKHYtPmFy
Y2gubW9uaXRvcl90YWJsZSk7CiAgICAgICAgICAgICAgICAgdi0+YXJjaC5t
b25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX251bGwoKTsKICAgICAgICAgICAg
ICAgICBuZXdfbWZuID0gdi0+YXJjaC5wYWdpbmcubW9kZS0+c2hhZG93Lm1h
a2VfbW9uaXRvcl90YWJsZSh2KTsKKyAgICAgICAgICAgICAgICBpZiAoIG1m
bl9lcShuZXdfbWZuLCBJTlZBTElEX01GTikgKQorICAgICAgICAgICAgICAg
IHsKKyAgICAgICAgICAgICAgICAgICAgb2xkX21vZGUtPnNoYWRvdy5kZXN0
cm95X21vbml0b3JfdGFibGUodiwgb2xkX21mbik7CisgICAgICAgICAgICAg
ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAg
ICAgICAgdi0+YXJjaC5tb25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX2Zyb21f
bWZuKG5ld19tZm4pOwogICAgICAgICAgICAgICAgIFNIQURPV19QUklOVEso
Im5ldyBtb25pdG9yIHRhYmxlICUiUFJJX21mbiAiXG4iLAogICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIG1mbl94KG5ld19tZm4pKTsKLS0tIGEv
eGVuL2FyY2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCisrKyBiL3hlbi9hcmNo
L3g4Ni9tbS9zaGFkb3cvbXVsdGkuYwpAQCAtMTUyNCw3ICsxNTI0LDggQEAg
c2hfbWFrZV9tb25pdG9yX3RhYmxlKHN0cnVjdCB2Y3B1ICp2KQogICAgIEFT
U0VSVChwYWdldGFibGVfZ2V0X3Bmbih2LT5hcmNoLm1vbml0b3JfdGFibGUp
ID09IDApOwogCiAgICAgLyogR3VhcmFudGVlIHdlIGNhbiBnZXQgdGhlIG1l
bW9yeSB3ZSBuZWVkICovCi0gICAgc2hhZG93X3ByZWFsbG9jKGQsIFNIX3R5
cGVfbW9uaXRvcl90YWJsZSwgQ09ORklHX1BBR0lOR19MRVZFTFMpOworICAg
IGlmICggIXNoYWRvd19wcmVhbGxvYyhkLCBTSF90eXBlX21vbml0b3JfdGFi
bGUsIENPTkZJR19QQUdJTkdfTEVWRUxTKSApCisgICAgICAgIHJldHVybiBJ
TlZBTElEX01GTjsKIAogICAgIHsKICAgICAgICAgbWZuX3QgbTRtZm47CkBA
IC0zMDUyLDkgKzMwNTMsMTQgQEAgc3RhdGljIGludCBzaF9wYWdlX2ZhdWx0
KHN0cnVjdCB2Y3B1ICp2LAogICAgICAqIFByZWFsbG9jYXRlIHNoYWRvdyBw
YWdlcyAqYmVmb3JlKiByZW1vdmluZyB3cml0YWJsZSBhY2Nlc3NlcwogICAg
ICAqIG90aGVyd2hpc2UgYW4gT09TIEwxIG1pZ2h0IGJlIGRlbW90ZWQgYW5k
IHByb21vdGVkIGFnYWluIHdpdGgKICAgICAgKiB3cml0YWJsZSBtYXBwaW5n
cy4gKi8KLSAgICBzaGFkb3dfcHJlYWxsb2MoZCwKLSAgICAgICAgICAgICAg
ICAgICAgU0hfdHlwZV9sMV9zaGFkb3csCi0gICAgICAgICAgICAgICAgICAg
IEdVRVNUX1BBR0lOR19MRVZFTFMgPCA0ID8gMSA6IEdVRVNUX1BBR0lOR19M
RVZFTFMgLSAxKTsKKyAgICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hf
dHlwZV9sMV9zaGFkb3csCisgICAgICAgICAgICAgICAgICAgICAgICAgIEdV
RVNUX1BBR0lOR19MRVZFTFMgPCA0CisgICAgICAgICAgICAgICAgICAgICAg
ICAgID8gMSA6IEdVRVNUX1BBR0lOR19MRVZFTFMgLSAxKSApCisgICAgewor
ICAgICAgICBwYWdpbmdfdW5sb2NrKGQpOworICAgICAgICBwdXRfZ2ZuKGQs
IGdmbl94KGdmbikpOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CiAKICAg
ICByYyA9IGd3X3JlbW92ZV93cml0ZV9hY2Nlc3Nlcyh2LCB2YSwgJmd3KTsK
IApAQCAtMzg3MSw3ICszODc3LDEyIEBAIHNoX3NldF90b3BsZXZlbF9zaGFk
b3coc3RydWN0IHZjcHUgKnYsCiAgICAgaWYgKCAhbWZuX3ZhbGlkKHNtZm4p
ICkKICAgICB7CiAgICAgICAgIC8qIE1ha2Ugc3VyZSB0aGVyZSdzIGVub3Vn
aCBmcmVlIHNoYWRvdyBtZW1vcnkuICovCi0gICAgICAgIHNoYWRvd19wcmVh
bGxvYyhkLCByb290X3R5cGUsIDEpOworICAgICAgICBpZiAoICFzaGFkb3df
cHJlYWxsb2MoZCwgcm9vdF90eXBlLCAxKSApCisgICAgICAgIHsKKyAgICAg
ICAgICAgIG5ld19lbnRyeSA9IHBhZ2V0YWJsZV9udWxsKCk7CisgICAgICAg
ICAgICBnb3RvIGluc3RhbGxfbmV3X2VudHJ5OworICAgICAgICB9CisKICAg
ICAgICAgLyogU2hhZG93IHRoZSBwYWdlLiAqLwogICAgICAgICBzbWZuID0g
c2hfbWFrZV9zaGFkb3codiwgZ21mbiwgcm9vdF90eXBlKTsKICAgICB9Ci0t
LSBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvcHJpdmF0ZS5oCisrKyBiL3hl
bi9hcmNoL3g4Ni9tbS9zaGFkb3cvcHJpdmF0ZS5oCkBAIC0zNDcsNyArMzQ3
LDggQEAgdm9pZCBzaGFkb3dfcHJvbW90ZShzdHJ1Y3QgZG9tYWluICpkLCBt
Zgogdm9pZCBzaGFkb3dfZGVtb3RlKHN0cnVjdCBkb21haW4gKmQsIG1mbl90
IGdtZm4sIHUzMiB0eXBlKTsKIAogLyogU2hhZG93IHBhZ2UgYWxsb2NhdGlv
biBmdW5jdGlvbnMgKi8KLXZvaWQgIHNoYWRvd19wcmVhbGxvYyhzdHJ1Y3Qg
ZG9tYWluICpkLCB1MzIgc2hhZG93X3R5cGUsIHVuc2lnbmVkIGludCBjb3Vu
dCk7Citib29sIF9fbXVzdF9jaGVjayBzaGFkb3dfcHJlYWxsb2Moc3RydWN0
IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHNoYWRvd190eXBlLAorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBjb3Vu
dCk7CiBtZm5fdCBzaGFkb3dfYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwKICAg
ICAgICAgICAgICAgICAgICAgdTMyIHNoYWRvd190eXBlLAogICAgICAgICAg
ICAgICAgICAgICB1bnNpZ25lZCBsb25nIGJhY2twb2ludGVyKTsK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-07.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHJlZnVzZSBuZXcgYWxsb2NhdGlvbnMgZm9y
IGR5aW5nIGRvbWFpbnMKClRoaXMgd2lsbCBpbiBwYXJ0aWN1bGFyIHByZXZl
bnQgYW55IGF0dGVtcHRzIHRvIGFkZCBlbnRyaWVzIHRvIHRoZSBwMm0sCm9u
Y2UgLSBpbiBhIHN1YnNlcXVlbnQgY2hhbmdlIC0gbm9uLXJvb3QgZW50cmll
cyBoYXZlIGJlZW4gcmVtb3ZlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGlt
IERlZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0v
aGFwL2hhcC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAg
LTI0NCw2ICsyNDQsOSBAQCBzdGF0aWMgc3RydWN0IHBhZ2VfaW5mbyAqaGFw
X2FsbG9jKHN0cnVjCiAKICAgICBBU1NFUlQocGFnaW5nX2xvY2tlZF9ieV9t
ZShkKSk7CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgIHJldHVybiBOVUxMOworCiAgICAgcGcgPSBwYWdlX2xpc3RfcmVt
b3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLmhhcC5mcmVlbGlzdCk7CiAgICAg
aWYgKCB1bmxpa2VseSghcGcpICkKICAgICAgICAgcmV0dXJuIE5VTEw7CkBA
IC0yODAsNyArMjgzLDcgQEAgc3RhdGljIHN0cnVjdCBwYWdlX2luZm8gKmhh
cF9hbGxvY19wMm1fcAogICAgICAgICBkLT5hcmNoLnBhZ2luZy5oYXAucDJt
X3BhZ2VzKys7CiAgICAgICAgIEFTU0VSVCghcGFnZV9nZXRfb3duZXIocGcp
ICYmICEocGctPmNvdW50X2luZm8gJiBQR0NfY291bnRfbWFzaykpOwogICAg
IH0KLSAgICBlbHNlIGlmICggIWQtPmFyY2gucGFnaW5nLnAybV9hbGxvY19m
YWlsZWQgKQorICAgIGVsc2UgaWYgKCAhZC0+YXJjaC5wYWdpbmcucDJtX2Fs
bG9jX2ZhaWxlZCAmJiAhZC0+aXNfZHlpbmcgKQogICAgIHsKICAgICAgICAg
ZC0+YXJjaC5wYWdpbmcucDJtX2FsbG9jX2ZhaWxlZCA9IDE7CiAgICAgICAg
IGRwcmludGsoWEVOTE9HX0VSUiwgImQlaSBmYWlsZWQgdG8gYWxsb2NhdGUg
ZnJvbSBIQVAgcG9vbFxuIiwKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRv
dy9jb21tb24uYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1v
bi5jCkBAIC05MDcsNiArOTA3LDEwIEBAIHN0YXRpYyBib29sIF9fbXVzdF9j
aGVjayBfc2hhZG93X3ByZWFsbG8KICAgICBpZiAoIGQtPmFyY2gucGFnaW5n
LnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2VzICkKICAgICAgICAgcmV0dXJu
IHRydWU7CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgIC8qIE5vIHJlY2xhaW0gd2hlbiB0aGUgZG9tYWluIGlzIGR5aW5n
LCB0ZWFyZG93biB3aWxsIHRha2UgY2FyZSBvZiBpdC4gKi8KKyAgICAgICAg
cmV0dXJuIGZhbHNlOworCiAgICAgLyogU2hvdWxkbid0IGhhdmUgZW5hYmxl
ZCBzaGFkb3dzIGlmIHdlJ3ZlIG5vIHZjcHVzLiAqLwogICAgIEFTU0VSVChk
LT52Y3B1ICYmIGQtPnZjcHVbMF0pOwogCkBAIC05NTcsNyArOTYxLDcgQEAg
c3RhdGljIGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsbwogICAg
ICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcywKICAg
ICAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcyk7CiAK
LSAgICBBU1NFUlQoZC0+aXNfZHlpbmcpOworICAgIEFTU0VSVF9VTlJFQUNI
QUJMRSgpOwogCiAgICAgZmx1c2hfdGxiX21hc2soZC0+ZGlydHlfY3B1bWFz
ayk7CiAKQEAgLTk3MSwxMCArOTc1LDEzIEBAIHN0YXRpYyBib29sIF9fbXVz
dF9jaGVjayBfc2hhZG93X3ByZWFsbG8KICAqIHRvIGF2b2lkIGZyZWVpbmcg
c2hhZG93cyB0aGF0IHRoZSBjYWxsZXIgaXMgY3VycmVudGx5IHdvcmtpbmcg
b24uICovCiBib29sIHNoYWRvd19wcmVhbGxvYyhzdHJ1Y3QgZG9tYWluICpk
LCB1bnNpZ25lZCBpbnQgdHlwZSwgdW5zaWduZWQgaW50IGNvdW50KQogewot
ICAgIGJvb2wgcmV0ID0gX3NoYWRvd19wcmVhbGxvYyhkLCBzaGFkb3dfc2l6
ZSh0eXBlKSAqIGNvdW50KTsKKyAgICBib29sIHJldDsKKworICAgIGlmICgg
dW5saWtlbHkoZC0+aXNfZHlpbmcpICkKKyAgICAgICByZXR1cm4gZmFsc2U7
CiAKLSAgICBpZiAoICFyZXQgJiYgIWQtPmlzX2R5aW5nICYmCi0gICAgICAg
ICAoIWQtPmlzX3NodXR0aW5nX2Rvd24gfHwgZC0+c2h1dGRvd25fY29kZSAh
PSBTSFVURE9XTl9jcmFzaCkgKQorICAgIHJldCA9IF9zaGFkb3dfcHJlYWxs
b2MoZCwgc2hhZG93X3NpemUodHlwZSkgKiBjb3VudCk7CisgICAgaWYgKCAh
cmV0ICYmICghZC0+aXNfc2h1dHRpbmdfZG93biB8fCBkLT5zaHV0ZG93bl9j
b2RlICE9IFNIVVRET1dOX2NyYXNoKSApCiAgICAgICAgIC8qCiAgICAgICAg
ICAqIEZhaWxpbmcgdG8gYWxsb2NhdGUgbWVtb3J5IHJlcXVpcmVkIGZvciBz
aGFkb3cgdXNhZ2UgY2FuIG9ubHkgcmVzdWx0IGluCiAgICAgICAgICAqIGEg
ZG9tYWluIGNyYXNoLCBkbyBpdCBoZXJlIHJhdGhlciB0aGF0IHJlbHlpbmcg
b24gZXZlcnkgY2FsbGVyIHRvIGRvIGl0LgpAQCAtMTIwNiw2ICsxMjEzLDkg
QEAgc2hhZG93X2FsbG9jX3AybV9wYWdlKHN0cnVjdCBkb21haW4gKmQpCiB7
CiAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGcgPSBOVUxMOwogCisgICAgaWYg
KCB1bmxpa2VseShkLT5pc19keWluZykgKQorICAgICAgIHJldHVybiBOVUxM
OworCiAgICAgLyogVGhpcyBpcyBjYWxsZWQgYm90aCBmcm9tIHRoZSBwMm0g
Y29kZSAod2hpY2ggbmV2ZXIgaG9sZHMgdGhlCiAgICAgICogcGFnaW5nIGxv
Y2spIGFuZCB0aGUgbG9nLWRpcnR5IGNvZGUgKHdoaWNoIGFsd2F5cyBkb2Vz
KS4gKi8KICAgICBwYWdpbmdfbG9ja19yZWN1cnNpdmUoZCk7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-08.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHRydWx5IGZyZWUgcGFnaW5nIHBvb2wgbWVt
b3J5IGZvciBkeWluZyBkb21haW5zCgpNb2RpZnkge2hhcCxzaGFkb3d9X2Zy
ZWUgdG8gZnJlZSB0aGUgcGFnZSBpbW1lZGlhdGVseSBpZiB0aGUgZG9tYWlu
IGlzCmR5aW5nLCBzbyB0aGF0IHBhZ2VzIGRvbid0IGFjY3VtdWxhdGUgaW4g
dGhlIHBvb2wgd2hlbgp7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRvd24oKSBn
ZXQgY2FsbGVkLiBUaGlzIGlzIHRvIGxpbWl0IHRoZSBhbW91bnQgb2YKd29y
ayB3aGljaCBuZWVkcyB0byBiZSBkb25lIHRoZXJlIChpbiBhIG5vbi1wcmVl
bXB0YWJsZSBtYW5uZXIpLgoKTm90ZSB0aGUgY2FsbCB0byBzaGFkb3dfZnJl
ZSgpIGluIHNoYWRvd19mcmVlX3AybV9wYWdlKCkgaXMgbW92ZWQgYWZ0ZXIK
aW5jcmVhc2luZyB0b3RhbF9wYWdlcywgc28gdGhhdCB0aGUgZGVjcmVhc2Ug
ZG9uZSBpbiBzaGFkb3dfZnJlZSgpIGluCmNhc2UgdGhlIGRvbWFpbiBpcyBk
eWluZyBkb2Vzbid0IHVuZGVyZmxvdyB0aGUgY291bnRlciwgZXZlbiBpZiBq
dXN0IGZvcgphIHNob3J0IGludGVydmFsLgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2Vy
IFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5
OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KCi0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hhcC9oYXAu
YwpAQCAtMjY0LDYgKzI2NCwxOCBAQCBzdGF0aWMgdm9pZCBoYXBfZnJlZShz
dHJ1Y3QgZG9tYWluICpkLCBtCiAKICAgICBBU1NFUlQocGFnaW5nX2xvY2tl
ZF9ieV9tZShkKSk7CiAKKyAgICAvKgorICAgICAqIEZvciBkeWluZyBkb21h
aW5zLCBhY3R1YWxseSBmcmVlIHRoZSBtZW1vcnkgaGVyZS4gVGhpcyB3YXkg
bGVzcyB3b3JrIGlzCisgICAgICogbGVmdCB0byBoYXBfZmluYWxfdGVhcmRv
d24oKSwgd2hpY2ggY2Fubm90IGVhc2lseSBoYXZlIHByZWVtcHRpb24gY2hl
Y2tzCisgICAgICogYWRkZWQuCisgICAgICovCisgICAgaWYgKCB1bmxpa2Vs
eShkLT5pc19keWluZykgKQorICAgIHsKKyAgICAgICAgZnJlZV9kb21oZWFw
X3BhZ2UocGcpOworICAgICAgICBkLT5hcmNoLnBhZ2luZy5oYXAudG90YWxf
cGFnZXMtLTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGQtPmFy
Y2gucGFnaW5nLmhhcC5mcmVlX3BhZ2VzKys7CiAgICAgcGFnZV9saXN0X2Fk
ZF90YWlsKHBnLCAmZC0+YXJjaC5wYWdpbmcuaGFwLmZyZWVsaXN0KTsKIH0K
LS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24uYworKysgYi94
ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0xMTU1LDYgKzEx
NTUsNyBAQCBtZm5fdCBzaGFkb3dfYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwK
IHZvaWQgc2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3Qgc21m
bikKIHsKICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpuZXh0ID0gTlVMTCwgKnNw
ID0gbWZuX3RvX3BhZ2Uoc21mbik7CisgICAgYm9vbCBkeWluZyA9IEFDQ0VT
U19PTkNFKGQtPmlzX2R5aW5nKTsKICAgICBzdHJ1Y3QgcGFnZV9saXN0X2hl
YWQgKnBpbl9saXN0OwogICAgIHVuc2lnbmVkIGludCBwYWdlczsKICAgICB1
MzIgc2hhZG93X3R5cGU7CkBAIC0xMTk3LDExICsxMTk4LDMyIEBAIHZvaWQg
c2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3QKICAgICAgICAg
ICoganVzdCBiZWZvcmUgdGhlIGFsbG9jYXRvciBoYW5kcyB0aGUgcGFnZSBv
dXQgYWdhaW4uICovCiAgICAgICAgIHBhZ2Vfc2V0X3RsYmZsdXNoX3RpbWVz
dGFtcChzcCk7CiAgICAgICAgIHBlcmZjX2RlY3Ioc2hhZG93X2FsbG9jX2Nv
dW50KTsKLSAgICAgICAgcGFnZV9saXN0X2FkZF90YWlsKHNwLCAmZC0+YXJj
aC5wYWdpbmcuc2hhZG93LmZyZWVsaXN0KTsKKworICAgICAgICAvKgorICAg
ICAgICAgKiBGb3IgZHlpbmcgZG9tYWlucywgYWN0dWFsbHkgZnJlZSB0aGUg
bWVtb3J5IGhlcmUuIFRoaXMgd2F5IGxlc3MKKyAgICAgICAgICogd29yayBp
cyBsZWZ0IHRvIHNoYWRvd19maW5hbF90ZWFyZG93bigpLCB3aGljaCBjYW5u
b3QgZWFzaWx5IGhhdmUKKyAgICAgICAgICogcHJlZW1wdGlvbiBjaGVja3Mg
YWRkZWQuCisgICAgICAgICAqLworICAgICAgICBpZiAoIHVubGlrZWx5KGR5
aW5nKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIC8qCisgICAgICAgICAg
ICAgKiBUaGUgYmFja3BvaW50ZXIgZmllbGQgKHNoLmJhY2spIHVzZWQgYnkg
c2hhZG93IGNvZGUgYWxpYXNlcyB0aGUKKyAgICAgICAgICAgICAqIGRvbWFp
biBvd25lciBmaWVsZCwgdW5jb25kaXRpb25hbGx5IGNsZWFyIGl0IGhlcmUg
dG8gYXZvaWQKKyAgICAgICAgICAgICAqIGZyZWVfZG9taGVhcF9wYWdlKCkg
YXR0ZW1wdGluZyB0byBwYXJzZSBpdC4KKyAgICAgICAgICAgICAqLworICAg
ICAgICAgICAgcGFnZV9zZXRfb3duZXIoc3AsIE5VTEwpOworICAgICAgICAg
ICAgZnJlZV9kb21oZWFwX3BhZ2Uoc3ApOworICAgICAgICB9CisgICAgICAg
IGVsc2UKKyAgICAgICAgICAgIHBhZ2VfbGlzdF9hZGRfdGFpbChzcCwgJmQt
PmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlbGlzdCk7CisKICAgICAgICAgc3Ag
PSBuZXh0OwogICAgIH0KIAotICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5m
cmVlX3BhZ2VzICs9IHBhZ2VzOworICAgIGlmICggdW5saWtlbHkoZHlpbmcp
ICkKKyAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnRvdGFsX3BhZ2Vz
IC09IHBhZ2VzOworICAgIGVsc2UKKyAgICAgICAgZC0+YXJjaC5wYWdpbmcu
c2hhZG93LmZyZWVfcGFnZXMgKz0gcGFnZXM7CiB9CiAKIC8qIERpdmVydCBh
IHBhZ2UgZnJvbSB0aGUgcG9vbCB0byBiZSB1c2VkIGJ5IHRoZSBwMm0gbWFw
cGluZy4KQEAgLTEyNzEsOSArMTI5Myw5IEBAIHNoYWRvd19mcmVlX3AybV9w
YWdlKHN0cnVjdCBkb21haW4gKmQsIHMKICAgICAgKiBwYWdpbmcgbG9jaykg
YW5kIHRoZSBsb2ctZGlydHkgY29kZSAod2hpY2ggYWx3YXlzIGRvZXMpLiAq
LwogICAgIHBhZ2luZ19sb2NrX3JlY3Vyc2l2ZShkKTsKIAotICAgIHNoYWRv
d19mcmVlKGQsIHBhZ2VfdG9fbWZuKHBnKSk7CiAgICAgZC0+YXJjaC5wYWdp
bmcuc2hhZG93LnAybV9wYWdlcy0tOwogICAgIGQtPmFyY2gucGFnaW5nLnNo
YWRvdy50b3RhbF9wYWdlcysrOworICAgIHNoYWRvd19mcmVlKGQsIHBhZ2Vf
dG9fbWZuKHBnKSk7CiAKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-09.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGZyZWUgdGhlIHBhZ2luZyBtZW1vcnkgcG9v
bCBwcmVlbXB0aXZlbHkKClRoZSBwYWdpbmcgbWVtb3J5IHBvb2wgaXMgY3Vy
cmVudGx5IGZyZWVkIGluIHR3byBkaWZmZXJlbnQgcGxhY2VzOgpmcm9tIHtz
aGFkb3csaGFwfV90ZWFyZG93bigpIHZpYSBkb21haW5fcmVsaW5xdWlzaF9y
ZXNvdXJjZXMoKSBhbmQKZnJvbSB7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRv
d24oKSB2aWEgY29tcGxldGVfZG9tYWluX2Rlc3Ryb3koKS4KV2hpbGUgdGhl
IGZvcm1lciBkb2VzIGhhbmRsZSBwcmVlbXB0aW9uLCB0aGUgbGF0ZXIgZG9l
c24ndC4KCkF0dGVtcHQgdG8gbW92ZSBhcyBtdWNoIHAybSByZWxhdGVkIGZy
ZWVpbmcgYXMgcG9zc2libGUgdG8gaGFwcGVuCmJlZm9yZSB0aGUgY2FsbCB0
byB7c2hhZG93LGhhcH1fdGVhcmRvd24oKSwgc28gdGhhdCBtb3N0IG1lbW9y
eSBjYW4gYmUKZnJlZWQgaW4gYSBwcmVlbXB0aXZlIHdheS4gIEluIG9yZGVy
IHRvIGF2b2lkIGNhdXNpbmcgaXNzdWVzIHRvCmV4aXN0aW5nIGNhbGxlcnMg
bGVhdmUgdGhlIHJvb3QgcDJtIHBhZ2UgdGFibGVzIHNldCBhbmQgZnJlZSB0
aGVtIGluCntoYXAsc2hhZG93fV9maW5hbF90ZWFyZG93bigpLiAgQWxzbyBt
b2RpZnkge2hhcCxzaGFkb3d9X2ZyZWUgdG8gZnJlZQp0aGUgcGFnZSBpbW1l
ZGlhdGVseSBpZiB0aGUgZG9tYWluIGlzIGR5aW5nLCBzbyB0aGF0IHBhZ2Vz
IGRvbid0CmFjY3VtdWxhdGUgaW4gdGhlIHBvb2wgd2hlbiB7c2hhZG93LGhh
cH1fZmluYWxfdGVhcmRvd24oKSBnZXQgY2FsbGVkLgoKTW92ZSBhbHRwMm1f
dmNwdV9kaXNhYmxlX3ZlKCkgdG8gYmUgZG9uZSBpbiBoYXBfdGVhcmRvd24o
KSwgYXMgdGhhdCdzCnRoZSBwbGFjZSB3aGVyZSBhbHRwMm1fYWN0aXZlIGdl
dHMgZGlzYWJsZWQgbm93LgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0yMDIyLTMz
NzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVl
Z2FuIDx0aW1AeGVuLm9yZz4KCi0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4u
YworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTM4LDcgKzM4LDYg
QEAKICNpbmNsdWRlIDx4ZW4vbGl2ZXBhdGNoLmg+CiAjaW5jbHVkZSA8cHVi
bGljL3N5c2N0bC5oPgogI2luY2x1ZGUgPHB1YmxpYy9odm0vaHZtX3ZjcHUu
aD4KLSNpbmNsdWRlIDxhc20vYWx0cDJtLmg+CiAjaW5jbHVkZSA8YXNtL3Jl
Z3MuaD4KICNpbmNsdWRlIDxhc20vbWMxNDY4MThydGMuaD4KICNpbmNsdWRl
IDxhc20vc3lzdGVtLmg+CkBAIC0yMDk4LDEyICsyMDk3LDYgQEAgaW50IGRv
bWFpbl9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1Y3QgZAogICAgICAgICAg
ICAgdnBtdV9kZXN0cm95KHYpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYg
KCBhbHRwMm1fYWN0aXZlKGQpICkKLSAgICAgICAgewotICAgICAgICAgICAg
Zm9yX2VhY2hfdmNwdSAoIGQsIHYgKQotICAgICAgICAgICAgICAgIGFsdHAy
bV92Y3B1X2Rpc2FibGVfdmUodik7Ci0gICAgICAgIH0KLQogICAgICAgICBp
ZiAoIGlzX3B2X2RvbWFpbihkKSApCiAgICAgICAgIHsKICAgICAgICAgICAg
IGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKLS0tIGEveGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCkBA
IC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdlLmg+
CiAjaW5jbHVkZSA8eGVuL2d1ZXN0X2FjY2Vzcy5oPgogI2luY2x1ZGUgPHhl
bi9rZXloYW5kbGVyLmg+CisjaW5jbHVkZSA8YXNtL2FsdHAybS5oPgogI2lu
Y2x1ZGUgPGFzbS9ldmVudC5oPgogI2luY2x1ZGUgPGFzbS9wYWdlLmg+CiAj
aW5jbHVkZSA8YXNtL2N1cnJlbnQuaD4KQEAgLTUzMiwxOCArNTMzLDggQEAg
dm9pZCBoYXBfZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZAogICAg
IHVuc2lnbmVkIGludCBpOwogCiAgICAgaWYgKCBodm1fYWx0cDJtX3N1cHBv
cnRlZCgpICkKLSAgICB7Ci0gICAgICAgIGQtPmFyY2guYWx0cDJtX2FjdGl2
ZSA9IDA7Ci0KLSAgICAgICAgaWYgKCBkLT5hcmNoLmFsdHAybV9lcHRwICkK
LSAgICAgICAgewotICAgICAgICAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+
YXJjaC5hbHRwMm1fZXB0cCk7Ci0gICAgICAgICAgICBkLT5hcmNoLmFsdHAy
bV9lcHRwID0gTlVMTDsKLSAgICAgICAgfQotCiAgICAgICAgIGZvciAoIGkg
PSAwOyBpIDwgTUFYX0FMVFAyTTsgaSsrICkKICAgICAgICAgICAgIHAybV90
ZWFyZG93bihkLT5hcmNoLmFsdHAybV9wMm1baV0sIHRydWUpOwotICAgIH0K
IAogICAgIC8qIERlc3Ryb3kgbmVzdGVkcDJtJ3MgZmlyc3QgKi8KICAgICBm
b3IgKGkgPSAwOyBpIDwgTUFYX05FU1RFRFAyTTsgaSsrKSB7CkBAIC01NTgs
NiArNTQ5LDggQEAgdm9pZCBoYXBfZmluYWxfdGVhcmRvd24oc3RydWN0IGRv
bWFpbiAqZAogICAgIHBhZ2luZ19sb2NrKGQpOwogICAgIGhhcF9zZXRfYWxs
b2NhdGlvbihkLCAwLCBOVUxMKTsKICAgICBBU1NFUlQoZC0+YXJjaC5wYWdp
bmcuaGFwLnAybV9wYWdlcyA9PSAwKTsKKyAgICBBU1NFUlQoZC0+YXJjaC5w
YWdpbmcuaGFwLmZyZWVfcGFnZXMgPT0gMCk7CisgICAgQVNTRVJUKGQtPmFy
Y2gucGFnaW5nLmhhcC50b3RhbF9wYWdlcyA9PSAwKTsKICAgICBwYWdpbmdf
dW5sb2NrKGQpOwogfQogCkBAIC01NjUsNiArNTU4LDcgQEAgdm9pZCBoYXBf
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYm9vbAogewogICAgIHN0cnVj
dCB2Y3B1ICp2OwogICAgIG1mbl90IG1mbjsKKyAgICB1bnNpZ25lZCBpbnQg
aTsKIAogICAgIEFTU0VSVChkLT5pc19keWluZyk7CiAgICAgQVNTRVJUKGQg
IT0gY3VycmVudC0+ZG9tYWluKTsKQEAgLTU4Niw2ICs1ODAsMzEgQEAgdm9p
ZCBoYXBfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYm9vbAogICAgICAg
ICB9CiAgICAgfQogCisgICAgcGFnaW5nX3VubG9jayhkKTsKKworICAgIC8q
IExlYXZlIHRoZSByb290IHB0IGluIGNhc2Ugd2UgZ2V0IGZ1cnRoZXIgYXR0
ZW1wdHMgdG8gbW9kaWZ5IHRoZSBwMm0uICovCisgICAgaWYgKCBodm1fYWx0
cDJtX3N1cHBvcnRlZCgpICkKKyAgICB7CisgICAgICAgIGlmICggYWx0cDJt
X2FjdGl2ZShkKSApCisgICAgICAgICAgICBmb3JfZWFjaF92Y3B1ICggZCwg
diApCisgICAgICAgICAgICAgICAgYWx0cDJtX3ZjcHVfZGlzYWJsZV92ZSh2
KTsKKworICAgICAgICBkLT5hcmNoLmFsdHAybV9hY3RpdmUgPSAwOworCisg
ICAgICAgIEZSRUVfWEVOSEVBUF9QQUdFKGQtPmFyY2guYWx0cDJtX2VwdHAp
OworCisgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgTUFYX0FMVFAyTTsgaSsr
ICkKKyAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNoLmFsdHAybV9w
Mm1baV0sIGZhbHNlKTsKKyAgICB9CisKKyAgICAvKiBEZXN0cm95IG5lc3Rl
ZHAybSdzIGFmdGVyIGFsdHAybS4gKi8KKyAgICBmb3IgKCBpID0gMDsgaSA8
IE1BWF9ORVNURURQMk07IGkrKyApCisgICAgICAgIHAybV90ZWFyZG93bihk
LT5hcmNoLm5lc3RlZF9wMm1baV0sIGZhbHNlKTsKKworICAgIHAybV90ZWFy
ZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIGZhbHNlKTsKKworICAgIHBhZ2lu
Z19sb2NrKGQpOworCiAgICAgaWYgKCBkLT5hcmNoLnBhZ2luZy5oYXAudG90
YWxfcGFnZXMgIT0gMCApCiAgICAgewogICAgICAgICBoYXBfc2V0X2FsbG9j
YXRpb24oZCwgMCwgcHJlZW1wdGVkKTsKLS0tIGEveGVuL2FyY2gveDg2L21t
L3NoYWRvdy9jb21tb24uYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93
L2NvbW1vbi5jCkBAIC0yNzkxLDYgKzI3OTEsMTkgQEAgdm9pZCBzaGFkb3df
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYgogICAgICAgICB9CiAgICAg
fQogCisgICAgcGFnaW5nX3VubG9jayhkKTsKKworICAgIHAybV90ZWFyZG93
bihwMm1fZ2V0X2hvc3RwMm0oZCksIGZhbHNlKTsKKworICAgIHBhZ2luZ19s
b2NrKGQpOworCisgICAgLyoKKyAgICAgKiBSZWNsYWltIGFsbCBzaGFkb3cg
bWVtb3J5IHNvIHRoYXQgc2hhZG93X3NldF9hbGxvY2F0aW9uKCkgZG9lc24n
dCBmaW5kCisgICAgICogaW4tdXNlIHBhZ2VzLCBhcyBfc2hhZG93X3ByZWFs
bG9jKCkgd2lsbCBubyBsb25nZXIgdHJ5IHRvIHJlY2xhaW0gcGFnZXMKKyAg
ICAgKiBiZWNhdXNlIHRoZSBkb21haW4gaXMgZHlpbmcuCisgICAgICovCisg
ICAgc2hhZG93X2Jsb3dfdGFibGVzKGQpOworCiAjaWYgKFNIQURPV19PUFRJ
TUlaQVRJT05TICYgKFNIT1BUX1ZJUlRVQUxfVExCfFNIT1BUX09VVF9PRl9T
WU5DKSkKICAgICAvKiBGcmVlIHRoZSB2aXJ0dWFsLVRMQiBhcnJheSBhdHRh
Y2hlZCB0byBlYWNoIHZjcHUgKi8KICAgICBmb3JfZWFjaF92Y3B1KGQsIHYp
CkBAIC0yOTA5LDYgKzI5MjIsOSBAQCB2b2lkIHNoYWRvd19maW5hbF90ZWFy
ZG93bihzdHJ1Y3QgZG9tYWluCiAgICAgICAgICAgICAgICAgICAgZC0+YXJj
aC5wYWdpbmcuc2hhZG93LnRvdGFsX3BhZ2VzLAogICAgICAgICAgICAgICAg
ICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3BhZ2VzLAogICAgICAg
ICAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5wMm1fcGFnZXMp
OworICAgIEFTU0VSVCghZC0+YXJjaC5wYWdpbmcuc2hhZG93LnRvdGFsX3Bh
Z2VzKTsKKyAgICBBU1NFUlQoIWQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVl
X3BhZ2VzKTsKKyAgICBBU1NFUlQoIWQtPmFyY2gucGFnaW5nLnNoYWRvdy5w
Mm1fcGFnZXMpOwogICAgIHBhZ2luZ191bmxvY2soZCk7CiB9CiAK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.13-10.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.13-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj
dDogeGVuL3g4NjogcDJtOiBBZGQgcHJlZW1wdGlvbiBpbiBwMm1fdGVhcmRv
d24oKQoKVGhlIGxpc3QgcDJtLT5wYWdlcyBjb250YWluIGFsbCB0aGUgcGFn
ZXMgdXNlZCBieSB0aGUgUDJNLiBPbiBsYXJnZQppbnN0YW5jZSB0aGlzIGNh
biBiZSBxdWl0ZSBsYXJnZSBhbmQgdGhlIHRpbWUgc3BlbnQgdG8gY2FsbApk
LT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoKSB3aWxsIHRha2UgbW9yZSB0aGFu
IDFtcyBmb3IgYSA4MEdCIGd1ZXN0Cm9uIGEgWGVuIHJ1bm5pbmcgaW4gbmVz
dGVkIGVudmlyb25tZW50IG9uIGEgYzUubWV0YWwuCgpCeSBleHRyYXBvbGF0
aW9uLCBpdCB3b3VsZCB0YWtlID4gMTAwbXMgZm9yIGEgOFRCIGd1ZXN0ICh3
aGF0IHdlCmN1cnJlbnQgc2VjdXJpdHkgc3VwcG9ydCkuIFNvIGFkZCBzb21l
IHByZWVtcHRpb24gaW4gcDJtX3RlYXJkb3duKCkKYW5kIHByb3BhZ2F0ZSB0
byB0aGUgY2FsbGVycy4gTm90ZSB0aGVyZSBhcmUgMyBwbGFjZXMgd2hlcmUK
dGhlIHByZWVtcHRpb24gaXMgbm90IGVuYWJsZWQ6CiAgICAtIGhhcF9maW5h
bF90ZWFyZG93bigpL3NoYWRvd19maW5hbF90ZWFyZG93bigpOiBXZSBhcmUK
ICAgICAgcHJldmVudGluZyB1cGRhdGUgdGhlIFAyTSBvbmNlIHRoZSBkb21h
aW4gaXMgZHlpbmcgKHNvCiAgICAgIG5vIG1vcmUgcGFnZXMgY291bGQgYmUg
YWxsb2NhdGVkKSBhbmQgbW9zdCBvZiB0aGUgUDJNIHBhZ2VzCiAgICAgIHdp
bGwgYmUgZnJlZWQgaW4gcHJlZW1wdGl2ZSBtYW5uZWVyIHdoZW4gcmVsaW5x
dWlzaGluZyB0aGUKICAgICAgcmVzb3VyY2VzLiBTbyB0aGlzIGlzIGZpbmUg
dG8gZGlzYWJsZSBwcmVlbXB0aW9uLgogICAgLSBzaGFkb3dfZW5hYmxlKCk6
IFRoaXMgaXMgZmluZSBiZWNhdXNlIGl0IHdpbGwgdW5kbyB0aGUgYWxsb2Nh
dGlvbgogICAgICB0aGF0IG1heSBoYXZlIGJlZW4gbWFkZSBieSBwMm1fYWxs
b2NfdGFibGUoKSAoc28gb25seSB0aGUgcm9vdAogICAgICBwYWdlIHRhYmxl
KS4KClRoZSBwcmVlbXB0aW9uIGlzIGFyYml0cmFyaWx5IGNoZWNrZWQgZXZl
cnkgMTAyNCBpdGVyYXRpb25zLgoKTm90ZSB0aGF0IHdpdGggdGhlIGN1cnJl
bnQgYXBwcm9hY2gsIFhlbiBkb2Vzbid0IGtlZXAgdHJhY2sgb24gd2hldGhl
cgp0aGUgYWx0L25lc3RlZCBQMk1zIGhhdmUgYmVlbiBjbGVhcmVkLiBTbyB0
aGVyZSBhcmUgc29tZSByZWR1bmRhbnQgd29yay4KSG93ZXZlciwgdGhpcyBp
cyBub3QgZXhwZWN0ZWQgdG8gaW5jdXJyIHRvbyBtdWNoIG92ZXJoZWFkICh0
aGUgUDJNIGxvY2sKc2hvdWxkbid0IGJlIGNvbnRlbmRlZCBkdXJpbmcgdGVh
cmRvd24pLiBTbyB0aGlzIGlzIG9wdGltaXphdGlvbiBpcwpsZWZ0IG91dHNp
ZGUgb2YgdGhlIHNlY3VyaXR5IGV2ZW50LgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCi0tLSBhL3hlbi9pbmNs
dWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9w
Mm0uaApAQCAtNTk5LDcgKzU5OSw3IEBAIGludCBwMm1faW5pdChzdHJ1Y3Qg
ZG9tYWluICpkKTsKIGludCBwMm1fYWxsb2NfdGFibGUoc3RydWN0IHAybV9k
b21haW4gKnAybSk7CiAKIC8qIFJldHVybiBhbGwgdGhlIHAybSByZXNvdXJj
ZXMgdG8gWGVuLiAqLwotdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9k
b21haW4gKnAybSwgYm9vbCByZW1vdmVfcm9vdCk7Cit2b2lkIHAybV90ZWFy
ZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290
LCBib29sICpwcmVlbXB0ZWQpOwogdm9pZCBwMm1fZmluYWxfdGVhcmRvd24o
c3RydWN0IGRvbWFpbiAqZCk7CiAKIC8qIEFkZCBhIHBhZ2UgdG8gYSBkb21h
aW4ncyBwMm0gdGFibGUgKi8KLS0tIGEveGVuL2FyY2gveDg2L21tL2hhcC9o
YXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCkBAIC01MzQs
MTcgKzUzNCwxNyBAQCB2b2lkIGhhcF9maW5hbF90ZWFyZG93bihzdHJ1Y3Qg
ZG9tYWluICpkCiAKICAgICBpZiAoIGh2bV9hbHRwMm1fc3VwcG9ydGVkKCkg
KQogICAgICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9BTFRQMk07IGkrKyAp
Ci0gICAgICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJjaC5hbHRwMm1fcDJt
W2ldLCB0cnVlKTsKKyAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNo
LmFsdHAybV9wMm1baV0sIHRydWUsIE5VTEwpOwogCiAgICAgLyogRGVzdHJv
eSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZvciAoaSA9IDA7IGkgPCBN
QVhfTkVTVEVEUDJNOyBpKyspIHsKLSAgICAgICAgcDJtX3RlYXJkb3duKGQt
PmFyY2gubmVzdGVkX3AybVtpXSwgdHJ1ZSk7CisgICAgICAgIHAybV90ZWFy
ZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIHRydWUsIE5VTEwpOwogICAg
IH0KIAogICAgIGlmICggZC0+YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3BhZ2Vz
ICE9IDAgKQogICAgICAgICBoYXBfdGVhcmRvd24oZCwgTlVMTCk7CiAKLSAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKKyAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlLCBOVUxM
KTsKICAgICAvKiBGcmVlIGFueSBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJk
b3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFw
X3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwpAQCAtNTk0LDE0ICs1OTQs
MjQgQEAgdm9pZCBoYXBfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYm9v
bAogICAgICAgICBGUkVFX1hFTkhFQVBfUEFHRShkLT5hcmNoLmFsdHAybV9l
cHRwKTsKIAogICAgICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9BTFRQMk07
IGkrKyApCi0gICAgICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJjaC5hbHRw
Mm1fcDJtW2ldLCBmYWxzZSk7CisgICAgICAgIHsKKyAgICAgICAgICAgIHAy
bV90ZWFyZG93bihkLT5hcmNoLmFsdHAybV9wMm1baV0sIGZhbHNlLCBwcmVl
bXB0ZWQpOworICAgICAgICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgKnByZWVt
cHRlZCApCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAg
ICAgfQogCiAgICAgLyogRGVzdHJveSBuZXN0ZWRwMm0ncyBhZnRlciBhbHRw
Mm0uICovCiAgICAgZm9yICggaSA9IDA7IGkgPCBNQVhfTkVTVEVEUDJNOyBp
KysgKQotICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJjaC5uZXN0ZWRfcDJt
W2ldLCBmYWxzZSk7CisgICAgeworICAgICAgICBwMm1fdGVhcmRvd24oZC0+
YXJjaC5uZXN0ZWRfcDJtW2ldLCBmYWxzZSwgcHJlZW1wdGVkKTsKKyAgICAg
ICAgaWYgKCBwcmVlbXB0ZWQgJiYgKnByZWVtcHRlZCApCisgICAgICAgICAg
ICByZXR1cm47CisgICAgfQogCi0gICAgcDJtX3RlYXJkb3duKHAybV9nZXRf
aG9zdHAybShkKSwgZmFsc2UpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0
X2hvc3RwMm0oZCksIGZhbHNlLCBwcmVlbXB0ZWQpOworICAgIGlmICggcHJl
ZW1wdGVkICYmICpwcmVlbXB0ZWQgKQorICAgICAgICByZXR1cm47CiAKICAg
ICBwYWdpbmdfbG9jayhkKTsKIAotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJt
LmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03MzcsMTIgKzcz
NywxMyBAQCBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWlu
ICpwCiAgKiBodm0gZml4bWU6IHdoZW4gYWRkaW5nIHN1cHBvcnQgZm9yIHB2
aCBub24taGFyZHdhcmUgZG9tYWlucywgdGhpcyBwYXRoIG11c3QKICAqIGNs
ZWFudXAgYW55IGZvcmVpZ24gcDJtIHR5cGVzIChyZWxlYXNlIHJlZmNudHMg
b24gdGhlbSkuCiAgKi8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1f
ZG9tYWluICpwMm0sIGJvb2wgcmVtb3ZlX3Jvb3QpCit2b2lkIHAybV90ZWFy
ZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290
LCBib29sICpwcmVlbXB0ZWQpCiAvKiBSZXR1cm4gYWxsIHRoZSBwMm0gcGFn
ZXMgdG8gWGVuLgogICogV2Uga25vdyB3ZSBkb24ndCBoYXZlIGFueSBleHRy
YSBtYXBwaW5ncyB0byB0aGVzZSBwYWdlcyAqLwogewogICAgIHN0cnVjdCBw
YWdlX2luZm8gKnBnLCAqcm9vdF9wZyA9IE5VTEw7CiAgICAgc3RydWN0IGRv
bWFpbiAqZDsKKyAgICB1bnNpZ25lZCBpbnQgaSA9IDA7CiAKICAgICBpZiAo
cDJtID09IE5VTEwpCiAgICAgICAgIHJldHVybjsKQEAgLTc2MSw4ICs3NjIs
MTkgQEAgdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAy
bQogICAgIH0KIAogICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92
ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQotICAgICAgICBpZiAoIHBnICE9IHJv
b3RfcGcgKQotICAgICAgICAgICAgZC0+YXJjaC5wYWdpbmcuZnJlZV9wYWdl
KGQsIHBnKTsKKyAgICB7CisgICAgICAgIGlmICggcGcgPT0gcm9vdF9wZyAp
CisgICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICBkLT5hcmNoLnBh
Z2luZy5mcmVlX3BhZ2UoZCwgcGcpOworCisgICAgICAgIC8qIEFyYml0cmFy
aWx5IGNoZWNrIHByZWVtcHRpb24gZXZlcnkgMTAyNCBpdGVyYXRpb25zICov
CisgICAgICAgIGlmICggcHJlZW1wdGVkICYmICEoKytpICUgMTAyNCkgJiYg
Z2VuZXJhbF9wcmVlbXB0X2NoZWNrKCkgKQorICAgICAgICB7CisgICAgICAg
ICAgICAqcHJlZW1wdGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIGJyZWFrOwor
ICAgICAgICB9CisgICAgfQogCiAgICAgaWYgKCByb290X3BnICkKICAgICAg
ICAgcGFnZV9saXN0X2FkZChyb290X3BnLCAmcDJtLT5wYWdlcyk7Ci0tLSBh
L3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKKysrIGIveGVuL2Fy
Y2gveDg2L21tL3NoYWRvdy9jb21tb24uYwpAQCAtMjc0Nyw4ICsyNzQ3LDEy
IEBAIGludCBzaGFkb3dfZW5hYmxlKHN0cnVjdCBkb21haW4gKmQsIHUzMgog
IG91dF9sb2NrZWQ6CiAgICAgcGFnaW5nX3VubG9jayhkKTsKICBvdXRfdW5s
b2NrZWQ6CisgICAgLyoKKyAgICAgKiBUaGlzIGlzIGZpbmUgdG8gaWdub3Jl
IHRoZSBwcmVlbXB0aW9uIGhlcmUgYmVjYXVzZSBvbmx5IHRoZSByb290Cisg
ICAgICogd2lsbCBiZSBhbGxvY2F0ZWQgYnkgcDJtX2FsbG9jX3RhYmxlKCku
CisgICAgICovCiAgICAgaWYgKCBydiAhPSAwICYmICFwYWdldGFibGVfaXNf
bnVsbChwMm1fZ2V0X3BhZ2V0YWJsZShwMm0pKSApCi0gICAgICAgIHAybV90
ZWFyZG93bihwMm0sIHRydWUpOworICAgICAgICBwMm1fdGVhcmRvd24ocDJt
LCB0cnVlLCBOVUxMKTsKICAgICBpZiAoIHJ2ICE9IDAgJiYgcGcgIT0gTlVM
TCApCiAgICAgewogICAgICAgICBwZy0+Y291bnRfaW5mbyAmPSB+UEdDX2Nv
dW50X21hc2s7CkBAIC0yNzkzLDcgKzI3OTcsOSBAQCB2b2lkIHNoYWRvd190
ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkLCBiCiAKICAgICBwYWdpbmdfdW5s
b2NrKGQpOwogCi0gICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9zdHAybShk
KSwgZmFsc2UpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0o
ZCksIGZhbHNlLCBwcmVlbXB0ZWQpOworICAgIGlmICggcHJlZW1wdGVkICYm
ICpwcmVlbXB0ZWQgKQorICAgICAgICByZXR1cm47CiAKICAgICBwYWdpbmdf
bG9jayhkKTsKIApAQCAtMjkxMiw3ICsyOTE4LDcgQEAgdm9pZCBzaGFkb3df
ZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbgogICAgICAgICBzaGFkb3df
dGVhcmRvd24oZCwgTlVMTCk7CiAKICAgICAvKiBJdCBpcyBub3cgc2FmZSB0
byBwdWxsIGRvd24gdGhlIHAybSBtYXAuICovCi0gICAgcDJtX3RlYXJkb3du
KHAybV9nZXRfaG9zdHAybShkKSwgdHJ1ZSk7CisgICAgcDJtX3RlYXJkb3du
KHAybV9nZXRfaG9zdHAybShkKSwgdHJ1ZSwgTlVMTCk7CiAgICAgLyogRnJl
ZSBhbnkgc2hhZG93IG1lbW9yeSB0aGF0IHRoZSBwMm0gdGVhcmRvd24gcmVs
ZWFzZWQgKi8KICAgICBwYWdpbmdfbG9jayhkKTsKICAgICBzaGFkb3dfc2V0
X2FsbG9jYXRpb24oZCwgMCwgTlVMTCk7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-01.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-01.patch"
Content-Transfer-Encoding: base64

RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj
dDogeGVuL2FybTogcDJtOiBQcmV2ZW50IGFkZGluZyBtYXBwaW5nIHdoZW4g
ZG9tYWluIGlzIGR5aW5nCgpEdXJpbmcgdGhlIGRvbWFpbiBkZXN0cm95IHBy
b2Nlc3MsIHRoZSBkb21haW4gd2lsbCBzdGlsbCBiZSBhY2Nlc3NpYmxlCnVu
dGlsIGl0IGlzIGZ1bGx5IGRlc3Ryb3llZC4gU28gZG9lcyB0aGUgUDJNIGJl
Y2F1c2Ugd2UgZG9uJ3QgYmFpbApvdXQgZWFybHkgaWYgaXNfZHlpbmcgaXMg
bm9uLXplcm8uIElmIGEgZG9tYWluIGhhcyBwZXJtaXNzaW9uIHRvCm1vZGlm
eSB0aGUgb3RoZXIgZG9tYWluJ3MgUDJNIChpLmUuIGRvbTAsIG9yIGEgc3R1
YmRvbWFpbiksIHRoZW4KZm9yZWlnbiBtYXBwaW5nIGNhbiBiZSBhZGRlZCBw
YXN0IHJlbGlucXVpc2hfcDJtX21hcHBpbmcoKS4KClRoZXJlZm9yZSwgd2Ug
bmVlZCB0byBwcmV2ZW50IG1hcHBpbmcgdG8gYmUgYWRkZWQgd2hlbiB0aGUg
ZG9tYWluCmlzIGR5aW5nLiBUaGlzIGNvbW1pdCBwcmV2ZW50cyBzdWNoIGFk
ZGluZyBvZiBtYXBwaW5nIGJ5IGFkZGluZyB0aGUKZC0+aXNfZHlpbmcgY2hl
Y2sgdG8gcDJtX3NldF9lbnRyeSgpLiBBbHNvIHRoaXMgY29tbWl0IGVuaGFu
Y2VzIHRoZQpjaGVjayBpbiByZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgdG8g
bWFrZSBzdXJlIHRoYXQgbm8gbWFwcGluZ3MgY2FuCmJlIGFkZGVkIGluIHRo
ZSBQMk0gYWZ0ZXIgdGhlIFAyTSBsb2NrIGlzIHJlbGVhc2VkLgoKVGhpcyBp
cyBwYXJ0IG9mIENWRS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1v
ZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25l
ZC1vZmYtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KVGVz
dGVkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmll
d2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5l
bC5vcmc+CgotLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMKKysrIGIveGVuL2Fy
Y2gvYXJtL3AybS5jCkBAIC0xMDg1LDYgKzEwODUsMTUgQEAgaW50IHAybV9z
ZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAybQogewogICAgIGludCBy
YyA9IDA7CiAKKyAgICAvKgorICAgICAqIEFueSByZWZlcmVuY2UgdGFrZW4g
YnkgdGhlIFAyTSBtYXBwaW5ncyAoZS5nLiBmb3JlaWduIG1hcHBpbmcpIHdp
bGwKKyAgICAgKiBiZSBkcm9wcGVkIGluIHJlbGlucXVpc2hfcDJtX21hcHBp
bmcoKS4gQXMgdGhlIFAyTSB3aWxsIHN0aWxsCisgICAgICogYmUgYWNjZXNz
aWJsZSBhZnRlciwgd2UgbmVlZCB0byBwcmV2ZW50IG1hcHBpbmcgdG8gYmUg
YWRkZWQgd2hlbiB0aGUKKyAgICAgKiBkb21haW4gaXMgZHlpbmcuCisgICAg
ICovCisgICAgaWYgKCB1bmxpa2VseShwMm0tPmRvbWFpbi0+aXNfZHlpbmcp
ICkKKyAgICAgICAgcmV0dXJuIC1FTk9NRU07CisKICAgICB3aGlsZSAoIG5y
ICkKICAgICB7CiAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWFzazsKQEAgLTE1
NzksNiArMTU4OCw4IEBAIGludCByZWxpbnF1aXNoX3AybV9tYXBwaW5nKHN0
cnVjdCBkb21haW4KICAgICB1bnNpZ25lZCBpbnQgb3JkZXI7CiAgICAgZ2Zu
X3Qgc3RhcnQsIGVuZDsKIAorICAgIEJVR19PTighZC0+aXNfZHlpbmcpOwor
ICAgIC8qIE5vIG1hcHBpbmdzIGNhbiBiZSBhZGRlZCBpbiB0aGUgUDJNIGFm
dGVyIHRoZSBQMk0gbG9jayBpcyByZWxlYXNlZC4gKi8KICAgICBwMm1fd3Jp
dGVfbG9jayhwMm0pOwogCiAgICAgc3RhcnQgPSBwMm0tPmxvd2VzdF9tYXBw
ZWRfZ2ZuOwo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-02.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-02.patch"
Content-Transfer-Encoding: base64

RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj
dDogeGVuL2FybTogcDJtOiBIYW5kbGUgcHJlZW1wdGlvbiB3aGVuIGZyZWVp
bmcgaW50ZXJtZWRpYXRlIHBhZ2UgdGFibGVzCgpBdCB0aGUgbW9tZW50IHRo
ZSBQMk0gcGFnZSB0YWJsZXMgd2lsbCBiZSBmcmVlZCB3aGVuIHRoZSBkb21h
aW4gc3RydWN0dXJlCmlzIGZyZWVkIHdpdGhvdXQgYW55IHByZWVtcHRpb24u
IEFzIHRoZSBQMk0gaXMgcXVpdGUgbGFyZ2UsIGl0ZXJhdGluZwp0aHJvdWdo
IHRoaXMgbWF5IHRha2UgbW9yZSB0aW1lIHRoYW4gaXQgaXMgcmVhc29uYWJs
ZSB3aXRob3V0IGludGVybWVkaWF0ZQpwcmVlbXB0aW9uICh0byBydW4gc29m
dGlycXMgYW5kIHBlcmhhcHMgc2NoZWR1bGVyKS4KClNwbGl0IHAybV90ZWFy
ZG93bigpIGluIHR3byBwYXJ0czogb25lIHByZWVtcHRpYmxlIGFuZCBjYWxs
ZWQgd2hlbgpyZWxpbnF1aXNoaW5nIHRoZSByZXNvdXJjZXMsIHRoZSBvdGhl
ciBvbmUgbm9uLXByZWVtcHRpYmxlIGFuZCBjYWxsZWQKd2hlbiBmcmVlaW5n
IHRoZSBkb21haW4gc3RydWN0dXJlLgoKQXMgd2UgYXJlIG5vdyBmcmVlaW5n
IHRoZSBQMk0gcGFnZXMgZWFybHksIHdlIGFsc28gbmVlZCB0byBwcmV2ZW50
CmZ1cnRoZXIgYWxsb2NhdGlvbiBpZiBzb21lb25lIGNhbGwgcDJtX3NldF9l
bnRyeSgpIHBhc3QgcDJtX3RlYXJkb3duKCkKKEkgd2Fzbid0IGFibGUgdG8g
cHJvdmUgdGhpcyB3aWxsIG5ldmVyIGhhcHBlbikuIFRoaXMgaXMgZG9uZSBi
eQp0aGUgY2hlY2tpbmcgZG9tYWluLT5pc19keWluZyBmcm9tIHByZXZpb3Vz
IHBhdGNoIGluIHAybV9zZXRfZW50cnkoKS4KClNpbWlsYXJseSwgd2Ugd2Fu
dCB0byBtYWtlIHN1cmUgdGhhdCBuby1vbmUgY2FuIGFjY2Vzc2VkIHRoZSBm
cmVlCnBhZ2VzLiBUaGVyZWZvcmUgdGhlIHJvb3QgaXMgY2xlYXJlZCBiZWZv
cmUgZnJlZWluZyBwYWdlcy4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAyMi0z
Mzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5n
IDxIZW5yeS5XYW5nQGFybS5jb20+ClRlc3RlZC1ieTogSGVucnkgV2FuZyA8
SGVucnkuV2FuZ0Bhcm0uY29tPgpSZXZpZXdlZC1ieTogU3RlZmFubyBTdGFi
ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgoKLS0tIGEveGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYwpA
QCAtNzc0LDEwICs3NzQsMTAgQEAgZmFpbDoKIHZvaWQgYXJjaF9kb21haW5f
ZGVzdHJveShzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIC8qIElPTU1VIHBh
Z2UgdGFibGUgaXMgc2hhcmVkIHdpdGggUDJNLCBhbHdheXMgY2FsbAotICAg
ICAqIGlvbW11X2RvbWFpbl9kZXN0cm95KCkgYmVmb3JlIHAybV90ZWFyZG93
bigpLgorICAgICAqIGlvbW11X2RvbWFpbl9kZXN0cm95KCkgYmVmb3JlIHAy
bV9maW5hbF90ZWFyZG93bigpLgogICAgICAqLwogICAgIGlvbW11X2RvbWFp
bl9kZXN0cm95KGQpOwotICAgIHAybV90ZWFyZG93bihkKTsKKyAgICBwMm1f
ZmluYWxfdGVhcmRvd24oZCk7CiAgICAgZG9tYWluX3ZnaWNfZnJlZShkKTsK
ICAgICBkb21haW5fdnVhcnRfZnJlZShkKTsKICAgICBmcmVlX3hlbmhlYXBf
cGFnZShkLT5zaGFyZWRfaW5mbyk7CkBAIC05NzksNiArOTc5LDcgQEAgZW51
bSB7CiAgICAgUFJPR194ZW4sCiAgICAgUFJPR19wYWdlLAogICAgIFBST0df
bWFwcGluZywKKyAgICBQUk9HX3AybSwKICAgICBQUk9HX2RvbmUsCiB9Owog
CkBAIC0xMDI5LDYgKzEwMzAsMTEgQEAgaW50IGRvbWFpbl9yZWxpbnF1aXNo
X3Jlc291cmNlcyhzdHJ1Y3QgZAogICAgICAgICBpZiAoIHJldCApCiAgICAg
ICAgICAgICByZXR1cm4gcmV0OwogCisgICAgUFJPR1JFU1MocDJtKToKKyAg
ICAgICAgcmV0ID0gcDJtX3RlYXJkb3duKGQpOworICAgICAgICBpZiAoIHJl
dCApCisgICAgICAgICAgICByZXR1cm4gcmV0OworCiAgICAgUFJPR1JFU1Mo
ZG9uZSk6CiAgICAgICAgIGJyZWFrOwogCi0tLSBhL3hlbi9pbmNsdWRlL2Fz
bS1hcm0vcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaApA
QCAtMTgzLDggKzE4MywxNyBAQCB2b2lkIHNldHVwX3ZpcnRfcGFnaW5nKHZv
aWQpOwogLyogSW5pdCB0aGUgZGF0YXN0cnVjdHVyZXMgZm9yIGxhdGVyIHVz
ZSBieSB0aGUgcDJtIGNvZGUgKi8KIGludCBwMm1faW5pdChzdHJ1Y3QgZG9t
YWluICpkKTsKIAotLyogUmV0dXJuIGFsbCB0aGUgcDJtIHJlc291cmNlcyB0
byBYZW4uICovCi12b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpk
KTsKKy8qCisgKiBUaGUgUDJNIHJlc291cmNlcyBhcmUgZnJlZWQgaW4gdHdv
IHBhcnRzOgorICogIC0gcDJtX3RlYXJkb3duKCkgd2lsbCBiZSBjYWxsZWQg
d2hlbiByZWxpbnF1aXNoIHRoZSByZXNvdXJjZXMuIEl0CisgKiAgICB3aWxs
IGZyZWUgbGFyZ2UgcmVzb3VyY2VzIChlLmcuIGludGVybWVkaWF0ZSBwYWdl
LXRhYmxlcykgdGhhdAorICogICAgcmVxdWlyZXMgcHJlZW1wdGlvbi4KKyAq
ICAtIHAybV9maW5hbF90ZWFyZG93bigpIHdpbGwgYmUgY2FsbGVkIHdoZW4g
ZG9tYWluIHN0cnVjdCBpcyBiZWVuCisgKiAgICBmcmVlZC4gVGhpcyAqY2Fu
bm90KiBiZSBwcmVlbXB0ZWQgYW5kIHRoZXJlZm9yZSBvbmUgc21hbGwKKyAq
ICAgIHJlc291cmNlcyBzaG91bGQgYmUgZnJlZWQgaGVyZS4KKyAqLworaW50
IHAybV90ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKTsKK3ZvaWQgcDJtX2Zp
bmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpOwogCiAvKgogICogUmVt
b3ZlIG1hcHBpbmcgcmVmY291bnQgb24gZWFjaCBtYXBwaW5nIHBhZ2UgaW4g
dGhlIHAybQotLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMKKysrIGIveGVuL2Fy
Y2gvYXJtL3AybS5jCkBAIC0xNDk2LDE3ICsxNDk2LDU4IEBAIHN0YXRpYyB2
b2lkIHAybV9mcmVlX3ZtaWQoc3RydWN0IGRvbWFpbgogICAgIHNwaW5fdW5s
b2NrKCZ2bWlkX2FsbG9jX2xvY2spOwogfQogCi12b2lkIHAybV90ZWFyZG93
bihzdHJ1Y3QgZG9tYWluICpkKQoraW50IHAybV90ZWFyZG93bihzdHJ1Y3Qg
ZG9tYWluICpkKQogewogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0gPSBw
Mm1fZ2V0X2hvc3RwMm0oZCk7CisgICAgdW5zaWduZWQgbG9uZyBjb3VudCA9
IDA7CiAgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CisgICAgdW5zaWduZWQg
aW50IGk7CisgICAgaW50IHJjID0gMDsKKworICAgIHAybV93cml0ZV9sb2Nr
KHAybSk7CisKKyAgICAvKgorICAgICAqIFdlIGFyZSBhYm91dCB0byBmcmVl
IHRoZSBpbnRlcm1lZGlhdGUgcGFnZS10YWJsZXMsIHNvIGNsZWFyIHRoZQor
ICAgICAqIHJvb3QgdG8gcHJldmVudCBhbnkgd2FsayB0byB1c2UgdGhlbS4K
KyAgICAgKi8KKyAgICBmb3IgKCBpID0gMDsgaSA8IFAyTV9ST09UX1BBR0VT
OyBpKysgKQorICAgICAgICBjbGVhcl9hbmRfY2xlYW5fcGFnZShwMm0tPnJv
b3QgKyBpKTsKKworICAgIC8qCisgICAgICogVGhlIGRvbWFpbiB3aWxsIG5v
dCBiZSBzY2hlZHVsZWQgYW55bW9yZSwgc28gaW4gdGhlb3J5IHdlIHNob3Vs
ZAorICAgICAqIG5vdCBuZWVkIHRvIGZsdXNoIHRoZSBUTEJzLiBEbyBpdCBm
b3Igc2FmZXR5IHB1cnBvc2UuCisgICAgICoKKyAgICAgKiBOb3RlIHRoYXQg
YWxsIHRoZSBkZXZpY2VzIGhhdmUgYWxyZWFkeSBiZWVuIGRlLWFzc2lnbmVk
LiBTbyB3ZSBkb24ndAorICAgICAqIG5lZWQgdG8gZmx1c2ggdGhlIElPTU1V
IFRMQiBoZXJlLgorICAgICAqLworICAgIHAybV9mb3JjZV90bGJfZmx1c2hf
c3luYyhwMm0pOworCisgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVt
b3ZlX2hlYWQoJnAybS0+cGFnZXMpKSApCisgICAgeworICAgICAgICBmcmVl
X2RvbWhlYXBfcGFnZShwZyk7CisgICAgICAgIGNvdW50Kys7CisgICAgICAg
IC8qIEFyYml0cmFyaWx5IHByZWVtcHQgZXZlcnkgNTEyIGl0ZXJhdGlvbnMg
Ki8KKyAgICAgICAgaWYgKCAhKGNvdW50ICUgNTEyKSAmJiBoeXBlcmNhbGxf
cHJlZW1wdF9jaGVjaygpICkKKyAgICAgICAgeworICAgICAgICAgICAgcmMg
PSAtRVJFU1RBUlQ7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQor
ICAgIH0KKworICAgIHAybV93cml0ZV91bmxvY2socDJtKTsKKworICAgIHJl
dHVybiByYzsKK30KKwordm9pZCBwMm1fZmluYWxfdGVhcmRvd24oc3RydWN0
IGRvbWFpbiAqZCkKK3sKKyAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtID0g
cDJtX2dldF9ob3N0cDJtKGQpOwogCiAgICAgLyogcDJtIG5vdCBhY3R1YWxs
eSBpbml0aWFsaXplZCAqLwogICAgIGlmICggIXAybS0+ZG9tYWluICkKICAg
ICAgICAgcmV0dXJuOwogCi0gICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3Rf
cmVtb3ZlX2hlYWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGZyZWVfZG9t
aGVhcF9wYWdlKHBnKTsKKyAgICBBU1NFUlQocGFnZV9saXN0X2VtcHR5KCZw
Mm0tPnBhZ2VzKSk7CiAKICAgICBpZiAoIHAybS0+cm9vdCApCiAgICAgICAg
IGZyZWVfZG9taGVhcF9wYWdlcyhwMm0tPnJvb3QsIFAyTV9ST09UX09SREVS
KTsK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-03.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGFkZCBvcHRpb24gdG8gc2tpcCByb290IHBh
Z2V0YWJsZSByZW1vdmFsIGluIHAybV90ZWFyZG93bigpCgpBZGQgYSBuZXcg
cGFyYW1ldGVyIHRvIHAybV90ZWFyZG93bigpIGluIG9yZGVyIHRvIHNlbGVj
dCB3aGV0aGVyIHRoZQpyb290IHBhZ2UgdGFibGUgc2hvdWxkIGFsc28gYmUg
ZnJlZWQuICBOb3RlIHRoYXQgYWxsIHVzZXJzIGFyZQphZGp1c3RlZCB0byBw
YXNzIHRoZSBwYXJhbWV0ZXIgdG8gcmVtb3ZlIHRoZSByb290IHBhZ2UgdGFi
bGVzLCBzbwpiZWhhdmlvciBpcyBub3QgbW9kaWZpZWQuCgpObyBmdW5jdGlv
bmFsIGNoYW5nZSBpbnRlbmRlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTdWdnZXN0ZWQtYnk6IEp1bGllbiBHcmFs
bCA8anVsaWVuQHhlbi5vcmc+ClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBN
b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGltIERl
ZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2
L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTU5
NSw3ICs1OTUsNyBAQCBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7
CiBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0p
OwogCiAvKiBSZXR1cm4gYWxsIHRoZSBwMm0gcmVzb3VyY2VzIHRvIFhlbi4g
Ki8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1fZG9tYWluICpwMm0p
Owordm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybSwg
Ym9vbCByZW1vdmVfcm9vdCk7CiB2b2lkIHAybV9maW5hbF90ZWFyZG93bihz
dHJ1Y3QgZG9tYWluICpkKTsKIAogLyogQWRkIGEgcGFnZSB0byBhIGRvbWFp
bidzIHAybSB0YWJsZSAqLwotLS0gYS94ZW4vYXJjaC94ODYvbW0vaGFwL2hh
cC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAgLTU0MCwx
OCArNTQwLDE4IEBAIHZvaWQgaGFwX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBk
b21haW4gKmQKICAgICAgICAgfQogCiAgICAgICAgIGZvciAoIGkgPSAwOyBp
IDwgTUFYX0FMVFAyTTsgaSsrICkKLSAgICAgICAgICAgIHAybV90ZWFyZG93
bihkLT5hcmNoLmFsdHAybV9wMm1baV0pOworICAgICAgICAgICAgcDJtX3Rl
YXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgdHJ1ZSk7CiAgICAgfQog
CiAgICAgLyogRGVzdHJveSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZv
ciAoaSA9IDA7IGkgPCBNQVhfTkVTVEVEUDJNOyBpKyspIHsKLSAgICAgICAg
cDJtX3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtpXSk7CisgICAgICAg
IHAybV90ZWFyZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIHRydWUpOwog
ICAgIH0KIAogICAgIGlmICggZC0+YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3Bh
Z2VzICE9IDAgKQogICAgICAgICBoYXBfdGVhcmRvd24oZCwgTlVMTCk7CiAK
LSAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpKTsKKyAgICBw
Mm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKICAgICAv
KiBGcmVlIGFueSBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJkb3duIHJlbGVh
c2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFwX3NldF9hbGxv
Y2F0aW9uKGQsIDAsIE5VTEwpOwotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJt
LmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03MzcsMTEgKzcz
NywxMSBAQCBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWlu
ICpwCiAgKiBodm0gZml4bWU6IHdoZW4gYWRkaW5nIHN1cHBvcnQgZm9yIHB2
aCBub24taGFyZHdhcmUgZG9tYWlucywgdGhpcyBwYXRoIG11c3QKICAqIGNs
ZWFudXAgYW55IGZvcmVpZ24gcDJtIHR5cGVzIChyZWxlYXNlIHJlZmNudHMg
b24gdGhlbSkuCiAgKi8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1f
ZG9tYWluICpwMm0pCit2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2Rv
bWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290KQogLyogUmV0dXJuIGFsbCB0
aGUgcDJtIHBhZ2VzIHRvIFhlbi4KICAqIFdlIGtub3cgd2UgZG9uJ3QgaGF2
ZSBhbnkgZXh0cmEgbWFwcGluZ3MgdG8gdGhlc2UgcGFnZXMgKi8KIHsKLSAg
ICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKKyAgICBzdHJ1Y3QgcGFnZV9pbmZv
ICpwZywgKnJvb3RfcGcgPSBOVUxMOwogICAgIHN0cnVjdCBkb21haW4gKmQ7
CiAKICAgICBpZiAocDJtID09IE5VTEwpCkBAIC03NTEsMTAgKzc1MSwyMiBA
QCB2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAK
ICAgICBwMm1fbG9jayhwMm0pOwogICAgIEFTU0VSVChhdG9taWNfcmVhZCgm
ZC0+c2hyX3BhZ2VzKSA9PSAwKTsKLSAgICBwMm0tPnBoeXNfdGFibGUgPSBw
YWdldGFibGVfbnVsbCgpOworCisgICAgaWYgKCByZW1vdmVfcm9vdCApCisg
ICAgICAgIHAybS0+cGh5c190YWJsZSA9IHBhZ2V0YWJsZV9udWxsKCk7Cisg
ICAgZWxzZSBpZiAoICFwYWdldGFibGVfaXNfbnVsbChwMm0tPnBoeXNfdGFi
bGUpICkKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBwYWdldGFibGVfZ2V0
X3BhZ2UocDJtLT5waHlzX3RhYmxlKTsKKyAgICAgICAgY2xlYXJfZG9tYWlu
X3BhZ2UocGFnZXRhYmxlX2dldF9tZm4ocDJtLT5waHlzX3RhYmxlKSk7Cisg
ICAgfQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGQtPmFyY2gucGFnaW5nLmZy
ZWVfcGFnZShkLCBwZyk7CisgICAgICAgIGlmICggcGcgIT0gcm9vdF9wZyAp
CisgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoZCwgcGcp
OworCisgICAgaWYgKCByb290X3BnICkKKyAgICAgICAgcGFnZV9saXN0X2Fk
ZChyb290X3BnLCAmcDJtLT5wYWdlcyk7CisKICAgICBwMm1fdW5sb2NrKHAy
bSk7CiB9CiAKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24u
YworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0y
Njg2LDcgKzI2ODYsNyBAQCBpbnQgc2hhZG93X2VuYWJsZShzdHJ1Y3QgZG9t
YWluICpkLCB1MzIKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogIG91dF91bmxv
Y2tlZDoKICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBhZ2V0YWJsZV9pc19udWxs
KHAybV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAgICAgICAgcDJtX3RlYXJk
b3duKHAybSk7CisgICAgICAgIHAybV90ZWFyZG93bihwMm0sIHRydWUpOwog
ICAgIGlmICggcnYgIT0gMCAmJiBwZyAhPSBOVUxMICkKICAgICB7CiAgICAg
ICAgIHBnLT5jb3VudF9pbmZvICY9IH5QR0NfY291bnRfbWFzazsKQEAgLTI4
MzksNyArMjgzOSw3IEBAIHZvaWQgc2hhZG93X2ZpbmFsX3RlYXJkb3duKHN0
cnVjdCBkb21haW4KICAgICAgICAgc2hhZG93X3RlYXJkb3duKGQsIE5VTEwp
OwogCiAgICAgLyogSXQgaXMgbm93IHNhZmUgdG8gcHVsbCBkb3duIHRoZSBw
Mm0gbWFwLiAqLwotICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0o
ZCkpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIHRy
dWUpOwogICAgIC8qIEZyZWUgYW55IHNoYWRvdyBtZW1vcnkgdGhhdCB0aGUg
cDJtIHRlYXJkb3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7
CiAgICAgc2hhZG93X3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-04.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvSEFQOiBhZGp1c3QgbW9uaXRvciB0YWJsZSByZWxhdGVkIGVycm9y
IGhhbmRsaW5nCgpoYXBfbWFrZV9tb25pdG9yX3RhYmxlKCkgd2lsbCByZXR1
cm4gSU5WQUxJRF9NRk4gaWYgaXQgZW5jb3VudGVycyBhbgplcnJvciBjb25k
aXRpb24sIGJ1dCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcygpIHdhc27igJl0
IGhhbmRsaW5nIHRoaXMKdmFsdWUsIHJlc3VsdGluZyBpbiBhbiBpbmFwcHJv
cHJpYXRlIHZhbHVlIGJlaW5nIHN0b3JlZCBpbgptb25pdG9yX3RhYmxlLiBU
aGlzIHdvdWxkIHN1YnNlcXVlbnRseSBtaXNndWlkZSBhdCBsZWFzdApoYXBf
dmNwdV90ZWFyZG93bigpLiBBdm9pZCB0aGlzIGJ5IGJhaWxpbmcgZWFybHku
CgpGdXJ0aGVyLCB3aGVuIGEgZG9tYWluIGhhcy93YXMgYWxyZWFkeSBjcmFz
aGVkIG9yIChwZXJoYXBzIGxlc3MKaW1wb3J0YW50IGFzIHRoZXJlJ3Mgbm8g
c3VjaCBwYXRoIGtub3duIHRvIGxlYWQgaGVyZSkgaXMgYWxyZWFkeSBkeWlu
ZywKYXZvaWQgY2FsbGluZyBkb21haW5fY3Jhc2goKSBvbiBpdCBhZ2FpbiAt
IHRoYXQncyBhdCBiZXN0IGNvbmZ1c2luZy4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBSb2dl
ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KCi0tLSBhL3hl
bi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYwpAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgPGFzbS9k
b21haW4uaD4KICNpbmNsdWRlIDx4ZW4vbnVtYS5oPgogI2luY2x1ZGUgPGFz
bS9odm0vbmVzdGVkaHZtLmg+CisjaW5jbHVkZSA8cHVibGljL3NjaGVkLmg+
CiAKICNpbmNsdWRlICJwcml2YXRlLmgiCiAKQEAgLTQwNCw4ICs0MDUsMTMg
QEAgc3RhdGljIG1mbl90IGhhcF9tYWtlX21vbml0b3JfdGFibGUoc3RydQog
ICAgIHJldHVybiBtNG1mbjsKIAogIG9vbToKLSAgICBwcmludGsoWEVOTE9H
X0dfRVJSICJvdXQgb2YgbWVtb3J5IGJ1aWxkaW5nIG1vbml0b3IgcGFnZXRh
YmxlXG4iKTsKLSAgICBkb21haW5fY3Jhc2goZCk7CisgICAgaWYgKCAhZC0+
aXNfZHlpbmcgJiYKKyAgICAgICAgICghZC0+aXNfc2h1dHRpbmdfZG93biB8
fCBkLT5zaHV0ZG93bl9jb2RlICE9IFNIVVRET1dOX2NyYXNoKSApCisgICAg
eworICAgICAgICBwcmludGsoWEVOTE9HX0dfRVJSICIlcGQ6IG91dCBvZiBt
ZW1vcnkgYnVpbGRpbmcgbW9uaXRvciBwYWdldGFibGVcbiIsCisgICAgICAg
ICAgICAgICBkKTsKKyAgICAgICAgZG9tYWluX2NyYXNoKGQpOworICAgIH0K
ICAgICByZXR1cm4gSU5WQUxJRF9NRk47CiB9CiAKQEAgLTc1OCw2ICs3NjQs
OSBAQCBzdGF0aWMgdm9pZCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1
CiAgICAgaWYgKCBwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLmh2bS5tb25p
dG9yX3RhYmxlKSApCiAgICAgewogICAgICAgICBtZm5fdCBtbWZuID0gaGFw
X21ha2VfbW9uaXRvcl90YWJsZSh2KTsKKworICAgICAgICBpZiAoIG1mbl9l
cShtbWZuLCBJTlZBTElEX01GTikgKQorICAgICAgICAgICAgZ290byB1bmxv
Y2s7CiAgICAgICAgIHYtPmFyY2guaHZtLm1vbml0b3JfdGFibGUgPSBwYWdl
dGFibGVfZnJvbV9tZm4obW1mbik7CiAgICAgICAgIG1ha2VfY3IzKHYsIG1t
Zm4pOwogICAgICAgICBodm1fdXBkYXRlX2hvc3RfY3IzKHYpOwpAQCAtNzY2
LDYgKzc3NSw3IEBAIHN0YXRpYyB2b2lkIGhhcF91cGRhdGVfcGFnaW5nX21v
ZGVzKHN0cnUKICAgICAvKiBDUjMgaXMgZWZmZWN0aXZlbHkgdXBkYXRlZCBi
eSBhIG1vZGUgY2hhbmdlLiBGbHVzaCBBU0lEcywgZXRjLiAqLwogICAgIGhh
cF91cGRhdGVfY3IzKHYsIDAsIGZhbHNlKTsKIAorIHVubG9jazoKICAgICBw
YWdpbmdfdW5sb2NrKGQpOwogICAgIHB1dF9nZm4oZCwgY3IzX2dmbik7CiB9
Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-05.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvc2hhZG93OiB0b2xlcmF0ZSBmYWlsdXJlIG9mIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKQoKU3Vic2VxdWVudGx5IHNoX3NldF90b3BsZXZlbF9z
aGFkb3coKSB3aWxsIGJlIGFkanVzdGVkIHRvIGluc3RhbGwgYQpibGFuayBl
bnRyeSBpbiBjYXNlIHByZWFsbG9jIGZhaWxzLiBUaGVyZSBhcmUsIGluIGZh
Y3QsIHByZS1leGlzdGluZwplcnJvciBwYXRocyB3aGljaCB3b3VsZCBwdXQg
aW4gcGxhY2UgYSBibGFuayBlbnRyeS4gVGhlIDQtIGFuZCAyLWxldmVsCmNv
ZGUgaW4gc2hfdXBkYXRlX2NyMygpLCBob3dldmVyLCBhc3N1bWUgdGhlIHRv
cCBsZXZlbCBlbnRyeSB0byBiZQp2YWxpZC4KCkhlbmNlIGJhaWwgZnJvbSB0
aGUgZnVuY3Rpb24gaW4gdGhlIHVubGlrZWx5IGV2ZW50IHRoYXQgaXQncyBu
b3QuIE5vdGUKdGhhdCAzLWxldmVsIGxvZ2ljIHdvcmtzIGRpZmZlcmVudGx5
OiBJbiBwYXJ0aWN1bGFyIGEgZ3Vlc3QgaXMgZnJlZSB0bwpzdXBwbHkgYSBQ
RFBUUiBwb2ludGluZyBhdCA0IG5vbi1wcmVzZW50IChvciBvdGhlcndpc2Ug
ZGVlbWVkIGludmFsaWQpCmVudHJpZXMuIFRoZSBndWVzdCB3aWxsIGNyYXNo
LCBidXQgd2UgYWxyZWFkeSBjb3BlIHdpdGggdGhhdC4KClJlYWxseSBtZm5f
dmFsaWQoKSBpcyBsaWtlbHkgd3JvbmcgdG8gdXNlIGluIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKSwKYW5kIGl0IHNob3VsZCBpbnN0ZWFkIGJlICFtZm5f
ZXEoZ21mbiwgSU5WQUxJRF9NRk4pLiBBdm9pZCBzdWNoIGEgY2hhbmdlCmlu
IHNlY3VyaXR5IGNvbnRleHQsIGJ1dCBhZGQgYSByZXNwZWN0aXZlIGFzc2Vy
dGlvbi4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00
MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KUmV2
aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMK
KysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCkBAIC0zODU0
LDYgKzM4NTQsNyBAQCBzaF9zZXRfdG9wbGV2ZWxfc2hhZG93KHN0cnVjdCB2
Y3B1ICp2LAogICAgIC8qIE5vdyBmaWd1cmUgb3V0IHRoZSBuZXcgY29udGVu
dHM6IGlzIHRoaXMgYSB2YWxpZCBndWVzdCBNRk4/ICovCiAgICAgaWYgKCAh
bWZuX3ZhbGlkKGdtZm4pICkKICAgICB7CisgICAgICAgIEFTU0VSVChtZm5f
ZXEoZ21mbiwgSU5WQUxJRF9NRk4pKTsKICAgICAgICAgbmV3X2VudHJ5ID0g
cGFnZXRhYmxlX251bGwoKTsKICAgICAgICAgZ290byBpbnN0YWxsX25ld19l
bnRyeTsKICAgICB9CkBAIC00MDA3LDYgKzQwMDgsMTEgQEAgc2hfdXBkYXRl
X2NyMyhzdHJ1Y3QgdmNwdSAqdiwgaW50IGRvX2xvYwogICAgIGlmICggc2hf
cmVtb3ZlX3dyaXRlX2FjY2VzcyhkLCBnbWZuLCAyLCAwKSAhPSAwICkKICAg
ICAgICAgZ3Vlc3RfZmx1c2hfdGxiX21hc2soZCwgZC0+ZGlydHlfY3B1bWFz
ayk7CiAgICAgc2hfc2V0X3RvcGxldmVsX3NoYWRvdyh2LCAwLCBnbWZuLCBT
SF90eXBlX2wyX3NoYWRvdyk7CisgICAgaWYgKCB1bmxpa2VseShwYWdldGFi
bGVfaXNfbnVsbCh2LT5hcmNoLnNoYWRvd190YWJsZVswXSkpICkKKyAgICB7
CisgICAgICAgIEFTU0VSVChkLT5pc19keWluZyB8fCBkLT5pc19zaHV0dGlu
Z19kb3duKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KICNlbGlmIEdVRVNU
X1BBR0lOR19MRVZFTFMgPT0gMwogICAgIC8qIFBBRSBndWVzdHMgaGF2ZSBm
b3VyIHNoYWRvd190YWJsZSBlbnRyaWVzLCBiYXNlZCBvbiB0aGUKICAgICAg
KiBjdXJyZW50IHZhbHVlcyBvZiB0aGUgZ3Vlc3QncyBmb3VyIGwzZXMuICov
CkBAIC00MDUyLDYgKzQwNTgsMTEgQEAgc2hfdXBkYXRlX2NyMyhzdHJ1Y3Qg
dmNwdSAqdiwgaW50IGRvX2xvYwogICAgIGlmICggc2hfcmVtb3ZlX3dyaXRl
X2FjY2VzcyhkLCBnbWZuLCA0LCAwKSAhPSAwICkKICAgICAgICAgZ3Vlc3Rf
Zmx1c2hfdGxiX21hc2soZCwgZC0+ZGlydHlfY3B1bWFzayk7CiAgICAgc2hf
c2V0X3RvcGxldmVsX3NoYWRvdyh2LCAwLCBnbWZuLCBTSF90eXBlX2w0X3No
YWRvdyk7CisgICAgaWYgKCB1bmxpa2VseShwYWdldGFibGVfaXNfbnVsbCh2
LT5hcmNoLnNoYWRvd190YWJsZVswXSkpICkKKyAgICB7CisgICAgICAgIEFT
U0VSVChkLT5pc19keWluZyB8fCBkLT5pc19zaHV0dGluZ19kb3duKTsKKyAg
ICAgICAgcmV0dXJuOworICAgIH0KICAgICBpZiAoICFzaGFkb3dfbW9kZV9l
eHRlcm5hbChkKSAmJiAhaXNfcHZfMzJiaXRfZG9tYWluKGQpICkKICAgICB7
CiAgICAgICAgIG1mbl90IHNtZm4gPSBwYWdldGFibGVfZ2V0X21mbih2LT5h
cmNoLnNoYWRvd190YWJsZVswXSk7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-06.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9zaGFkb3c6IHRvbGVyYXRlIGZhaWx1cmUgaW4gc2hh
ZG93X3ByZWFsbG9jKCkKClByZXZlbnQgX3NoYWRvd19wcmVhbGxvYygpIGZy
b20gY2FsbGluZyBCVUcoKSB3aGVuIHVuYWJsZSB0byBmdWxmaWxsCnRoZSBw
cmUtYWxsb2NhdGlvbiBhbmQgaW5zdGVhZCByZXR1cm4gdHJ1ZS9mYWxzZS4g
IE1vZGlmeQpzaGFkb3dfcHJlYWxsb2MoKSB0byBjcmFzaCB0aGUgZG9tYWlu
IG9uIGFsbG9jYXRpb24gZmFpbHVyZSAoaWYgdGhlCmRvbWFpbiBpcyBub3Qg
YWxyZWFkeSBkeWluZyksIGFzIHNoYWRvdyBjYW5ub3Qgb3BlcmF0ZSBub3Jt
YWxseSBhZnRlcgp0aGF0LiAgTW9kaWZ5IGNhbGxlcnMgdG8gYWxzbyBncmFj
ZWZ1bGx5IGhhbmRsZSB7Xyx9c2hhZG93X3ByZWFsbG9jKCkKZmFpbGluZyB0
byBmdWxmaWxsIHRoZSByZXF1ZXN0LgoKTm90ZSB0aGlzIGluIHR1cm4gcmVx
dWlyZXMgYWRqdXN0aW5nIHRoZSBjYWxsZXJzIG9mCnNoX21ha2VfbW9uaXRv
cl90YWJsZSgpIGFsc28gdG8gaGFuZGxlIGl0IHJldHVybmluZyBJTlZBTElE
X01GTi4Kc2hfdXBkYXRlX3BhZ2luZ19tb2RlcygpIGlzIGFsc28gbW9kaWZp
ZWQgdG8gYWRkIGFkZGl0aW9uYWwgZXJyb3IKcGF0aHMgaW4gY2FzZSBvZiBh
bGxvY2F0aW9uIGZhaWx1cmUsIHNvbWUgb2YgdGhvc2Ugd2lsbCByZXR1cm4g
d2l0aApudWxsIG1vbml0b3IgcGFnZSB0YWJsZXMgKGFuZCB0aGUgZG9tYWlu
IGxpa2VseSBjcmFzaGVkKS4gIFRoaXMgaXMgbm8KZGlmZmVyZW50IHRoYXQg
Y3VycmVudCBlcnJvciBwYXRocywgYnV0IHRoZSBuZXdseSBpbnRyb2R1Y2Vk
IG9uZXMgYXJlCm1vcmUgbGlrZWx5IHRvIHRyaWdnZXIuCgpUaGUgbm93IGFk
ZGVkIGZhaWx1cmUgcG9pbnRzIGluIHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMo
KSBhbHNvIHJlcXVpcmUKdGhhdCBvbiBzb21lIGVycm9yIHJldHVybiBwYXRo
cyB0aGUgcHJldmlvdXMgc3RydWN0dXJlcyBhcmUgY2xlYXJlZCwKYW5kIHRo
dXMgbW9uaXRvciB0YWJsZSBpcyBudWxsLgoKV2hpbGUgdGhlcmUgYWRqdXN0
IHRoZSAndHlwZScgcGFyYW1ldGVyIHR5cGUgb2Ygc2hhZG93X3ByZWFsbG9j
KCkgdG8KdW5zaWduZWQgaW50IHJhdGhlciB0aGFuIHUzMi4KClRoaXMgaXMg
cGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PgpBY2tlZC1ieTogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94
ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCisrKyBiL3hlbi9hcmNo
L3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKQEAgLTM2LDYgKzM2LDcgQEAKICNp
bmNsdWRlIDxhc20vc2hhZG93Lmg+CiAjaW5jbHVkZSA8YXNtL2h2bS9pb3Jl
cS5oPgogI2luY2x1ZGUgPHhlbi9udW1hLmg+CisjaW5jbHVkZSA8cHVibGlj
L3NjaGVkLmg+CiAjaW5jbHVkZSAicHJpdmF0ZS5oIgogCiBERUZJTkVfUEVS
X0NQVSh1aW50MzJfdCx0cmFjZV9zaGFkb3dfcGF0aF9mbGFncyk7CkBAIC05
MjcsMTQgKzkyOCwxNSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgdHJhY2Vfc2hh
ZG93X3ByZWFsbG9jCiAKIC8qIE1ha2Ugc3VyZSB0aGVyZSBhcmUgYXQgbGVh
c3QgY291bnQgb3JkZXItc2l6ZWQgcGFnZXMKICAqIGF2YWlsYWJsZSBpbiB0
aGUgc2hhZG93IHBhZ2UgcG9vbC4gKi8KLXN0YXRpYyB2b2lkIF9zaGFkb3df
cHJlYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHBhZ2Vz
KQorc3RhdGljIGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsb2Mo
c3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHBhZ2VzKQogewogICAg
IHN0cnVjdCB2Y3B1ICp2OwogICAgIHN0cnVjdCBwYWdlX2luZm8gKnNwLCAq
dDsKICAgICBtZm5fdCBzbWZuOwogICAgIGludCBpOwogCi0gICAgaWYgKCBk
LT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcyA+PSBwYWdlcyApIHJl
dHVybjsKKyAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3Bh
Z2VzID49IHBhZ2VzICkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAv
KiBTaG91bGRuJ3QgaGF2ZSBlbmFibGVkIHNoYWRvd3MgaWYgd2UndmUgbm8g
dmNwdXMuICovCiAgICAgQVNTRVJUKGQtPnZjcHUgJiYgZC0+dmNwdVswXSk7
CkBAIC05NTAsNyArOTUyLDggQEAgc3RhdGljIHZvaWQgX3NoYWRvd19wcmVh
bGxvYyhzdHJ1Y3QgZG9tYQogICAgICAgICBzaF91bnBpbihkLCBzbWZuKTsK
IAogICAgICAgICAvKiBTZWUgaWYgdGhhdCBmcmVlZCB1cCBlbm91Z2ggc3Bh
Y2UgKi8KLSAgICAgICAgaWYgKCBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJl
ZV9wYWdlcyA+PSBwYWdlcyApIHJldHVybjsKKyAgICAgICAgaWYgKCBkLT5h
cmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcyA+PSBwYWdlcyApCisgICAg
ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICAvKiBTdGFnZSB0
d286IGFsbCBzaGFkb3cgcGFnZXMgYXJlIGluIHVzZSBpbiBoaWVyYXJjaGll
cyB0aGF0IGFyZQpAQCAtOTcxLDcgKzk3NCw3IEBAIHN0YXRpYyB2b2lkIF9z
aGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWEKICAgICAgICAgICAgICAgICBp
ZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2Vz
ICkKICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgIGd1
ZXN0X2ZsdXNoX3RsYl9tYXNrKGQsIGQtPmRpcnR5X2NwdW1hc2spOwotICAg
ICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgICAg
IHJldHVybiB0cnVlOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg
IH0KICAgICAgICAgfQpAQCAtOTg0LDcgKzk4NywxMiBAQCBzdGF0aWMgdm9p
ZCBfc2hhZG93X3ByZWFsbG9jKHN0cnVjdCBkb21hCiAgICAgICAgICAgIGQt
PmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9wYWdlcywKICAgICAgICAgICAg
ZC0+YXJjaC5wYWdpbmcuc2hhZG93LmZyZWVfcGFnZXMsCiAgICAgICAgICAg
IGQtPmFyY2gucGFnaW5nLnNoYWRvdy5wMm1fcGFnZXMpOwotICAgIEJVRygp
OworCisgICAgQVNTRVJUKGQtPmlzX2R5aW5nKTsKKworICAgIGd1ZXN0X2Zs
dXNoX3RsYl9tYXNrKGQsIGQtPmRpcnR5X2NwdW1hc2spOworCisgICAgcmV0
dXJuIGZhbHNlOwogfQogCiAvKiBNYWtlIHN1cmUgdGhlcmUgYXJlIGF0IGxl
YXN0IGNvdW50IHBhZ2VzIG9mIHRoZSBvcmRlciBhY2NvcmRpbmcgdG8KQEAg
LTk5Miw5ICsxMDAwLDE5IEBAIHN0YXRpYyB2b2lkIF9zaGFkb3dfcHJlYWxs
b2Moc3RydWN0IGRvbWEKICAqIFRoaXMgbXVzdCBiZSBjYWxsZWQgYmVmb3Jl
IGFueSBjYWxscyB0byBzaGFkb3dfYWxsb2MoKS4gIFNpbmNlIHRoaXMKICAq
IHdpbGwgZnJlZSBleGlzdGluZyBzaGFkb3dzIHRvIG1ha2Ugcm9vbSwgaXQg
bXVzdCBiZSBjYWxsZWQgZWFybHkgZW5vdWdoCiAgKiB0byBhdm9pZCBmcmVl
aW5nIHNoYWRvd3MgdGhhdCB0aGUgY2FsbGVyIGlzIGN1cnJlbnRseSB3b3Jr
aW5nIG9uLiAqLwotdm9pZCBzaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWFp
biAqZCwgdTMyIHR5cGUsIHVuc2lnbmVkIGludCBjb3VudCkKK2Jvb2wgc2hh
ZG93X3ByZWFsbG9jKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGludCB0
eXBlLCB1bnNpZ25lZCBpbnQgY291bnQpCiB7Ci0gICAgcmV0dXJuIF9zaGFk
b3dfcHJlYWxsb2MoZCwgc2hhZG93X3NpemUodHlwZSkgKiBjb3VudCk7Cisg
ICAgYm9vbCByZXQgPSBfc2hhZG93X3ByZWFsbG9jKGQsIHNoYWRvd19zaXpl
KHR5cGUpICogY291bnQpOworCisgICAgaWYgKCAhcmV0ICYmICFkLT5pc19k
eWluZyAmJgorICAgICAgICAgKCFkLT5pc19zaHV0dGluZ19kb3duIHx8IGQt
PnNodXRkb3duX2NvZGUgIT0gU0hVVERPV05fY3Jhc2gpICkKKyAgICAgICAg
LyoKKyAgICAgICAgICogRmFpbGluZyB0byBhbGxvY2F0ZSBtZW1vcnkgcmVx
dWlyZWQgZm9yIHNoYWRvdyB1c2FnZSBjYW4gb25seSByZXN1bHQgaW4KKyAg
ICAgICAgICogYSBkb21haW4gY3Jhc2gsIGRvIGl0IGhlcmUgcmF0aGVyIHRo
YXQgcmVseWluZyBvbiBldmVyeSBjYWxsZXIgdG8gZG8gaXQuCisgICAgICAg
ICAqLworICAgICAgICBkb21haW5fY3Jhc2goZCk7CisKKyAgICByZXR1cm4g
cmV0OwogfQogCiAvKiBEZWxpYmVyYXRlbHkgZnJlZSBhbGwgdGhlIG1lbW9y
eSB3ZSBjYW46IHRoaXMgd2lsbCB0ZWFyIGRvd24gYWxsIG9mCkBAIC0xMjEx
LDcgKzEyMjksNyBAQCB2b2lkIHNoYWRvd19mcmVlKHN0cnVjdCBkb21haW4g
KmQsIG1mbl90CiBzdGF0aWMgc3RydWN0IHBhZ2VfaW5mbyAqCiBzaGFkb3df
YWxsb2NfcDJtX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCkKIHsKLSAgICBzdHJ1
Y3QgcGFnZV9pbmZvICpwZzsKKyAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZyA9
IE5VTEw7CiAKICAgICAvKiBUaGlzIGlzIGNhbGxlZCBib3RoIGZyb20gdGhl
IHAybSBjb2RlICh3aGljaCBuZXZlciBob2xkcyB0aGUKICAgICAgKiBwYWdp
bmcgbG9jaykgYW5kIHRoZSBsb2ctZGlydHkgY29kZSAod2hpY2ggYWx3YXlz
IGRvZXMpLiAqLwpAQCAtMTIyOSwxNiArMTI0NywxOCBAQCBzaGFkb3dfYWxs
b2NfcDJtX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAgICAgICAg
ICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcywKICAgICAg
ICAgICAgICAgICAgICAgc2hhZG93X21pbl9hY2NlcHRhYmxlX3BhZ2VzKGQp
KTsKICAgICAgICAgfQotICAgICAgICBwYWdpbmdfdW5sb2NrKGQpOwotICAg
ICAgICByZXR1cm4gTlVMTDsKKyAgICAgICAgZ290byBvdXQ7CiAgICAgfQog
Ci0gICAgc2hhZG93X3ByZWFsbG9jKGQsIFNIX3R5cGVfcDJtX3RhYmxlLCAx
KTsKKyAgICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlwZV9wMm1f
dGFibGUsIDEpICkKKyAgICAgICAgZ290byBvdXQ7CisKICAgICBwZyA9IG1m
bl90b19wYWdlKHNoYWRvd19hbGxvYyhkLCBTSF90eXBlX3AybV90YWJsZSwg
MCkpOwogICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5wMm1fcGFnZXMrKzsK
ICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cudG90YWxfcGFnZXMtLTsKICAg
ICBBU1NFUlQoIXBhZ2VfZ2V0X293bmVyKHBnKSAmJiAhKHBnLT5jb3VudF9p
bmZvICYgUEdDX2NvdW50X21hc2spKTsKIAorIG91dDoKICAgICBwYWdpbmdf
dW5sb2NrKGQpOwogCiAgICAgcmV0dXJuIHBnOwpAQCAtMTMyOSw3ICsxMzQ5
LDkgQEAgaW50IHNoYWRvd19zZXRfYWxsb2NhdGlvbihzdHJ1Y3QgZG9tYWlu
CiAgICAgICAgIGVsc2UgaWYgKCBkLT5hcmNoLnBhZ2luZy5zaGFkb3cudG90
YWxfcGFnZXMgPiBwYWdlcyApCiAgICAgICAgIHsKICAgICAgICAgICAgIC8q
IE5lZWQgdG8gcmV0dXJuIG1lbW9yeSB0byBkb21oZWFwICovCi0gICAgICAg
ICAgICBfc2hhZG93X3ByZWFsbG9jKGQsIDEpOworICAgICAgICAgICAgaWYg
KCAhX3NoYWRvd19wcmVhbGxvYyhkLCAxKSApCisgICAgICAgICAgICAgICAg
cmV0dXJuIC1FTk9NRU07CisKICAgICAgICAgICAgIHNwID0gcGFnZV9saXN0
X3JlbW92ZV9oZWFkKCZkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZWxpc3Qp
OwogICAgICAgICAgICAgQVNTRVJUKHNwKTsKICAgICAgICAgICAgIC8qCkBA
IC0yMzk3LDEyICsyNDE5LDEzIEBAIHN0YXRpYyB2b2lkIHNoX3VwZGF0ZV9w
YWdpbmdfbW9kZXMoc3RydWMKICAgICBpZiAoIG1mbl9lcSh2LT5hcmNoLnBh
Z2luZy5zaGFkb3cub29zX3NuYXBzaG90WzBdLCBJTlZBTElEX01GTikgKQog
ICAgIHsKICAgICAgICAgaW50IGk7CisKKyAgICAgICAgaWYgKCAhc2hhZG93
X3ByZWFsbG9jKGQsIFNIX3R5cGVfb29zX3NuYXBzaG90LCBTSEFET1dfT09T
X1BBR0VTKSApCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgZm9y
KGkgPSAwOyBpIDwgU0hBRE9XX09PU19QQUdFUzsgaSsrKQotICAgICAgICB7
Ci0gICAgICAgICAgICBzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlwZV9vb3Nf
c25hcHNob3QsIDEpOwogICAgICAgICAgICAgdi0+YXJjaC5wYWdpbmcuc2hh
ZG93Lm9vc19zbmFwc2hvdFtpXSA9CiAgICAgICAgICAgICAgICAgc2hhZG93
X2FsbG9jKGQsIFNIX3R5cGVfb29zX3NuYXBzaG90LCAwKTsKLSAgICAgICAg
fQogICAgIH0KICNlbmRpZiAvKiBPT1MgKi8KIApAQCAtMjQ2NCw2ICsyNDg3
LDEwIEBAIHN0YXRpYyB2b2lkIHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMoc3Ry
dWMKICAgICAgICAgaWYgKCBwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLmh2
bS5tb25pdG9yX3RhYmxlKSApCiAgICAgICAgIHsKICAgICAgICAgICAgIG1m
bl90IG1tZm4gPSB2LT5hcmNoLnBhZ2luZy5tb2RlLT5zaGFkb3cubWFrZV9t
b25pdG9yX3RhYmxlKHYpOworCisgICAgICAgICAgICBpZiAoIG1mbl9lcSht
bWZuLCBJTlZBTElEX01GTikgKQorICAgICAgICAgICAgICAgIHJldHVybjsK
KwogICAgICAgICAgICAgdi0+YXJjaC5odm0ubW9uaXRvcl90YWJsZSA9IHBh
Z2V0YWJsZV9mcm9tX21mbihtbWZuKTsKICAgICAgICAgICAgIG1ha2VfY3Iz
KHYsIG1tZm4pOwogICAgICAgICAgICAgaHZtX3VwZGF0ZV9ob3N0X2NyMyh2
KTsKQEAgLTI1MDEsNiArMjUyOCwxMSBAQCBzdGF0aWMgdm9pZCBzaF91cGRh
dGVfcGFnaW5nX21vZGVzKHN0cnVjCiAgICAgICAgICAgICAgICAgb2xkX21m
biA9IHBhZ2V0YWJsZV9nZXRfbWZuKHYtPmFyY2guaHZtLm1vbml0b3JfdGFi
bGUpOwogICAgICAgICAgICAgICAgIHYtPmFyY2guaHZtLm1vbml0b3JfdGFi
bGUgPSBwYWdldGFibGVfbnVsbCgpOwogICAgICAgICAgICAgICAgIG5ld19t
Zm4gPSB2LT5hcmNoLnBhZ2luZy5tb2RlLT5zaGFkb3cubWFrZV9tb25pdG9y
X3RhYmxlKHYpOworICAgICAgICAgICAgICAgIGlmICggbWZuX2VxKG5ld19t
Zm4sIElOVkFMSURfTUZOKSApCisgICAgICAgICAgICAgICAgeworICAgICAg
ICAgICAgICAgICAgICBvbGRfbW9kZS0+c2hhZG93LmRlc3Ryb3lfbW9uaXRv
cl90YWJsZSh2LCBvbGRfbWZuKTsKKyAgICAgICAgICAgICAgICAgICAgcmV0
dXJuOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB2LT5h
cmNoLmh2bS5tb25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX2Zyb21fbWZuKG5l
d19tZm4pOwogICAgICAgICAgICAgICAgIFNIQURPV19QUklOVEsoIm5ldyBt
b25pdG9yIHRhYmxlICUiUFJJX21mbiAiXG4iLAogICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIG1mbl94KG5ld19tZm4pKTsKLS0tIGEveGVuL2Fy
Y2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9t
bS9zaGFkb3cvbXVsdGkuYwpAQCAtMTUzNSw3ICsxNTM1LDggQEAgc2hfbWFr
ZV9tb25pdG9yX3RhYmxlKHN0cnVjdCB2Y3B1ICp2KQogICAgIEFTU0VSVChw
YWdldGFibGVfZ2V0X3Bmbih2LT5hcmNoLmh2bS5tb25pdG9yX3RhYmxlKSA9
PSAwKTsKIAogICAgIC8qIEd1YXJhbnRlZSB3ZSBjYW4gZ2V0IHRoZSBtZW1v
cnkgd2UgbmVlZCAqLwotICAgIHNoYWRvd19wcmVhbGxvYyhkLCBTSF90eXBl
X21vbml0b3JfdGFibGUsIENPTkZJR19QQUdJTkdfTEVWRUxTKTsKKyAgICBp
ZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlwZV9tb25pdG9yX3RhYmxl
LCBDT05GSUdfUEFHSU5HX0xFVkVMUykgKQorICAgICAgICByZXR1cm4gSU5W
QUxJRF9NRk47CiAKICAgICB7CiAgICAgICAgIG1mbl90IG00bWZuOwpAQCAt
MzA2Nyw5ICszMDY4LDE0IEBAIHN0YXRpYyBpbnQgc2hfcGFnZV9mYXVsdChz
dHJ1Y3QgdmNwdSAqdiwKICAgICAgKiBQcmVhbGxvY2F0ZSBzaGFkb3cgcGFn
ZXMgKmJlZm9yZSogcmVtb3Zpbmcgd3JpdGFibGUgYWNjZXNzZXMKICAgICAg
KiBvdGhlcndoaXNlIGFuIE9PUyBMMSBtaWdodCBiZSBkZW1vdGVkIGFuZCBw
cm9tb3RlZCBhZ2FpbiB3aXRoCiAgICAgICogd3JpdGFibGUgbWFwcGluZ3Mu
ICovCi0gICAgc2hhZG93X3ByZWFsbG9jKGQsCi0gICAgICAgICAgICAgICAg
ICAgIFNIX3R5cGVfbDFfc2hhZG93LAotICAgICAgICAgICAgICAgICAgICBH
VUVTVF9QQUdJTkdfTEVWRUxTIDwgNCA/IDEgOiBHVUVTVF9QQUdJTkdfTEVW
RUxTIC0gMSk7CisgICAgaWYgKCAhc2hhZG93X3ByZWFsbG9jKGQsIFNIX3R5
cGVfbDFfc2hhZG93LAorICAgICAgICAgICAgICAgICAgICAgICAgICBHVUVT
VF9QQUdJTkdfTEVWRUxTIDwgNAorICAgICAgICAgICAgICAgICAgICAgICAg
ICA/IDEgOiBHVUVTVF9QQUdJTkdfTEVWRUxTIC0gMSkgKQorICAgIHsKKyAg
ICAgICAgcGFnaW5nX3VubG9jayhkKTsKKyAgICAgICAgcHV0X2dmbihkLCBn
Zm5feChnZm4pKTsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQogCiAgICAg
cmMgPSBnd19yZW1vdmVfd3JpdGVfYWNjZXNzZXModiwgdmEsICZndyk7CiAK
QEAgLTM4NjQsNyArMzg3MCwxMiBAQCBzaF9zZXRfdG9wbGV2ZWxfc2hhZG93
KHN0cnVjdCB2Y3B1ICp2LAogICAgIGlmICggIW1mbl92YWxpZChzbWZuKSAp
CiAgICAgewogICAgICAgICAvKiBNYWtlIHN1cmUgdGhlcmUncyBlbm91Z2gg
ZnJlZSBzaGFkb3cgbWVtb3J5LiAqLwotICAgICAgICBzaGFkb3dfcHJlYWxs
b2MoZCwgcm9vdF90eXBlLCAxKTsKKyAgICAgICAgaWYgKCAhc2hhZG93X3By
ZWFsbG9jKGQsIHJvb3RfdHlwZSwgMSkgKQorICAgICAgICB7CisgICAgICAg
ICAgICBuZXdfZW50cnkgPSBwYWdldGFibGVfbnVsbCgpOworICAgICAgICAg
ICAgZ290byBpbnN0YWxsX25ld19lbnRyeTsKKyAgICAgICAgfQorCiAgICAg
ICAgIC8qIFNoYWRvdyB0aGUgcGFnZS4gKi8KICAgICAgICAgc21mbiA9IHNo
X21ha2Vfc2hhZG93KHYsIGdtZm4sIHJvb3RfdHlwZSk7CiAgICAgfQotLS0g
YS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3ByaXZhdGUuaAorKysgYi94ZW4v
YXJjaC94ODYvbW0vc2hhZG93L3ByaXZhdGUuaApAQCAtMzUxLDcgKzM1MSw4
IEBAIHZvaWQgc2hhZG93X3Byb21vdGUoc3RydWN0IGRvbWFpbiAqZCwgbWYK
IHZvaWQgc2hhZG93X2RlbW90ZShzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBn
bWZuLCB1MzIgdHlwZSk7CiAKIC8qIFNoYWRvdyBwYWdlIGFsbG9jYXRpb24g
ZnVuY3Rpb25zICovCi12b2lkICBzaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRv
bWFpbiAqZCwgdTMyIHNoYWRvd190eXBlLCB1bnNpZ25lZCBpbnQgY291bnQp
OworYm9vbCBfX211c3RfY2hlY2sgc2hhZG93X3ByZWFsbG9jKHN0cnVjdCBk
b21haW4gKmQsIHVuc2lnbmVkIGludCBzaGFkb3dfdHlwZSwKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgY291bnQp
OwogbWZuX3Qgc2hhZG93X2FsbG9jKHN0cnVjdCBkb21haW4gKmQsCiAgICAg
ICAgICAgICAgICAgICAgIHUzMiBzaGFkb3dfdHlwZSwKICAgICAgICAgICAg
ICAgICAgICAgdW5zaWduZWQgbG9uZyBiYWNrcG9pbnRlcik7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-07.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHJlZnVzZSBuZXcgYWxsb2NhdGlvbnMgZm9y
IGR5aW5nIGRvbWFpbnMKClRoaXMgd2lsbCBpbiBwYXJ0aWN1bGFyIHByZXZl
bnQgYW55IGF0dGVtcHRzIHRvIGFkZCBlbnRyaWVzIHRvIHRoZSBwMm0sCm9u
Y2UgLSBpbiBhIHN1YnNlcXVlbnQgY2hhbmdlIC0gbm9uLXJvb3QgZW50cmll
cyBoYXZlIGJlZW4gcmVtb3ZlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGlt
IERlZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0v
aGFwL2hhcC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAg
LTI0NCw2ICsyNDQsOSBAQCBzdGF0aWMgc3RydWN0IHBhZ2VfaW5mbyAqaGFw
X2FsbG9jKHN0cnVjCiAKICAgICBBU1NFUlQocGFnaW5nX2xvY2tlZF9ieV9t
ZShkKSk7CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgIHJldHVybiBOVUxMOworCiAgICAgcGcgPSBwYWdlX2xpc3RfcmVt
b3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLmhhcC5mcmVlbGlzdCk7CiAgICAg
aWYgKCB1bmxpa2VseSghcGcpICkKICAgICAgICAgcmV0dXJuIE5VTEw7CkBA
IC0yODAsNyArMjgzLDcgQEAgc3RhdGljIHN0cnVjdCBwYWdlX2luZm8gKmhh
cF9hbGxvY19wMm1fcAogICAgICAgICBkLT5hcmNoLnBhZ2luZy5oYXAucDJt
X3BhZ2VzKys7CiAgICAgICAgIEFTU0VSVCghcGFnZV9nZXRfb3duZXIocGcp
ICYmICEocGctPmNvdW50X2luZm8gJiBQR0NfY291bnRfbWFzaykpOwogICAg
IH0KLSAgICBlbHNlIGlmICggIWQtPmFyY2gucGFnaW5nLnAybV9hbGxvY19m
YWlsZWQgKQorICAgIGVsc2UgaWYgKCAhZC0+YXJjaC5wYWdpbmcucDJtX2Fs
bG9jX2ZhaWxlZCAmJiAhZC0+aXNfZHlpbmcgKQogICAgIHsKICAgICAgICAg
ZC0+YXJjaC5wYWdpbmcucDJtX2FsbG9jX2ZhaWxlZCA9IDE7CiAgICAgICAg
IGRwcmludGsoWEVOTE9HX0VSUiwgImQlaSBmYWlsZWQgdG8gYWxsb2NhdGUg
ZnJvbSBIQVAgcG9vbFxuIiwKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRv
dy9jb21tb24uYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1v
bi5jCkBAIC05MzgsNiArOTM4LDEwIEBAIHN0YXRpYyBib29sIF9fbXVzdF9j
aGVjayBfc2hhZG93X3ByZWFsbG8KICAgICBpZiAoIGQtPmFyY2gucGFnaW5n
LnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2VzICkKICAgICAgICAgcmV0dXJu
IHRydWU7CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgIC8qIE5vIHJlY2xhaW0gd2hlbiB0aGUgZG9tYWluIGlzIGR5aW5n
LCB0ZWFyZG93biB3aWxsIHRha2UgY2FyZSBvZiBpdC4gKi8KKyAgICAgICAg
cmV0dXJuIGZhbHNlOworCiAgICAgLyogU2hvdWxkbid0IGhhdmUgZW5hYmxl
ZCBzaGFkb3dzIGlmIHdlJ3ZlIG5vIHZjcHVzLiAqLwogICAgIEFTU0VSVChk
LT52Y3B1ICYmIGQtPnZjcHVbMF0pOwogCkBAIC05ODgsNyArOTkyLDcgQEAg
c3RhdGljIGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsbwogICAg
ICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcywKICAg
ICAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcyk7CiAK
LSAgICBBU1NFUlQoZC0+aXNfZHlpbmcpOworICAgIEFTU0VSVF9VTlJFQUNI
QUJMRSgpOwogCiAgICAgZ3Vlc3RfZmx1c2hfdGxiX21hc2soZCwgZC0+ZGly
dHlfY3B1bWFzayk7CiAKQEAgLTEwMDIsMTAgKzEwMDYsMTMgQEAgc3RhdGlj
IGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsbwogICogdG8gYXZv
aWQgZnJlZWluZyBzaGFkb3dzIHRoYXQgdGhlIGNhbGxlciBpcyBjdXJyZW50
bHkgd29ya2luZyBvbi4gKi8KIGJvb2wgc2hhZG93X3ByZWFsbG9jKHN0cnVj
dCBkb21haW4gKmQsIHVuc2lnbmVkIGludCB0eXBlLCB1bnNpZ25lZCBpbnQg
Y291bnQpCiB7Ci0gICAgYm9vbCByZXQgPSBfc2hhZG93X3ByZWFsbG9jKGQs
IHNoYWRvd19zaXplKHR5cGUpICogY291bnQpOworICAgIGJvb2wgcmV0Owor
CisgICAgaWYgKCB1bmxpa2VseShkLT5pc19keWluZykgKQorICAgICAgIHJl
dHVybiBmYWxzZTsKIAotICAgIGlmICggIXJldCAmJiAhZC0+aXNfZHlpbmcg
JiYKLSAgICAgICAgICghZC0+aXNfc2h1dHRpbmdfZG93biB8fCBkLT5zaHV0
ZG93bl9jb2RlICE9IFNIVVRET1dOX2NyYXNoKSApCisgICAgcmV0ID0gX3No
YWRvd19wcmVhbGxvYyhkLCBzaGFkb3dfc2l6ZSh0eXBlKSAqIGNvdW50KTsK
KyAgICBpZiAoICFyZXQgJiYgKCFkLT5pc19zaHV0dGluZ19kb3duIHx8IGQt
PnNodXRkb3duX2NvZGUgIT0gU0hVVERPV05fY3Jhc2gpICkKICAgICAgICAg
LyoKICAgICAgICAgICogRmFpbGluZyB0byBhbGxvY2F0ZSBtZW1vcnkgcmVx
dWlyZWQgZm9yIHNoYWRvdyB1c2FnZSBjYW4gb25seSByZXN1bHQgaW4KICAg
ICAgICAgICogYSBkb21haW4gY3Jhc2gsIGRvIGl0IGhlcmUgcmF0aGVyIHRo
YXQgcmVseWluZyBvbiBldmVyeSBjYWxsZXIgdG8gZG8gaXQuCkBAIC0xMjMx
LDYgKzEyMzgsOSBAQCBzaGFkb3dfYWxsb2NfcDJtX3BhZ2Uoc3RydWN0IGRv
bWFpbiAqZCkKIHsKICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZyA9IE5VTEw7
CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisgICAgICAg
cmV0dXJuIE5VTEw7CisKICAgICAvKiBUaGlzIGlzIGNhbGxlZCBib3RoIGZy
b20gdGhlIHAybSBjb2RlICh3aGljaCBuZXZlciBob2xkcyB0aGUKICAgICAg
KiBwYWdpbmcgbG9jaykgYW5kIHRoZSBsb2ctZGlydHkgY29kZSAod2hpY2gg
YWx3YXlzIGRvZXMpLiAqLwogICAgIHBhZ2luZ19sb2NrX3JlY3Vyc2l2ZShk
KTsK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-08.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHRydWx5IGZyZWUgcGFnaW5nIHBvb2wgbWVt
b3J5IGZvciBkeWluZyBkb21haW5zCgpNb2RpZnkge2hhcCxzaGFkb3d9X2Zy
ZWUgdG8gZnJlZSB0aGUgcGFnZSBpbW1lZGlhdGVseSBpZiB0aGUgZG9tYWlu
IGlzCmR5aW5nLCBzbyB0aGF0IHBhZ2VzIGRvbid0IGFjY3VtdWxhdGUgaW4g
dGhlIHBvb2wgd2hlbgp7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRvd24oKSBn
ZXQgY2FsbGVkLiBUaGlzIGlzIHRvIGxpbWl0IHRoZSBhbW91bnQgb2YKd29y
ayB3aGljaCBuZWVkcyB0byBiZSBkb25lIHRoZXJlIChpbiBhIG5vbi1wcmVl
bXB0YWJsZSBtYW5uZXIpLgoKTm90ZSB0aGUgY2FsbCB0byBzaGFkb3dfZnJl
ZSgpIGluIHNoYWRvd19mcmVlX3AybV9wYWdlKCkgaXMgbW92ZWQgYWZ0ZXIK
aW5jcmVhc2luZyB0b3RhbF9wYWdlcywgc28gdGhhdCB0aGUgZGVjcmVhc2Ug
ZG9uZSBpbiBzaGFkb3dfZnJlZSgpIGluCmNhc2UgdGhlIGRvbWFpbiBpcyBk
eWluZyBkb2Vzbid0IHVuZGVyZmxvdyB0aGUgY291bnRlciwgZXZlbiBpZiBq
dXN0IGZvcgphIHNob3J0IGludGVydmFsLgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2Vy
IFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5
OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KCi0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hhcC9oYXAu
YwpAQCAtMjY0LDYgKzI2NCwxOCBAQCBzdGF0aWMgdm9pZCBoYXBfZnJlZShz
dHJ1Y3QgZG9tYWluICpkLCBtCiAKICAgICBBU1NFUlQocGFnaW5nX2xvY2tl
ZF9ieV9tZShkKSk7CiAKKyAgICAvKgorICAgICAqIEZvciBkeWluZyBkb21h
aW5zLCBhY3R1YWxseSBmcmVlIHRoZSBtZW1vcnkgaGVyZS4gVGhpcyB3YXkg
bGVzcyB3b3JrIGlzCisgICAgICogbGVmdCB0byBoYXBfZmluYWxfdGVhcmRv
d24oKSwgd2hpY2ggY2Fubm90IGVhc2lseSBoYXZlIHByZWVtcHRpb24gY2hl
Y2tzCisgICAgICogYWRkZWQuCisgICAgICovCisgICAgaWYgKCB1bmxpa2Vs
eShkLT5pc19keWluZykgKQorICAgIHsKKyAgICAgICAgZnJlZV9kb21oZWFw
X3BhZ2UocGcpOworICAgICAgICBkLT5hcmNoLnBhZ2luZy5oYXAudG90YWxf
cGFnZXMtLTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGQtPmFy
Y2gucGFnaW5nLmhhcC5mcmVlX3BhZ2VzKys7CiAgICAgcGFnZV9saXN0X2Fk
ZF90YWlsKHBnLCAmZC0+YXJjaC5wYWdpbmcuaGFwLmZyZWVsaXN0KTsKIH0K
LS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24uYworKysgYi94
ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0xMTgwLDYgKzEx
ODAsNyBAQCBtZm5fdCBzaGFkb3dfYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwK
IHZvaWQgc2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3Qgc21m
bikKIHsKICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpuZXh0ID0gTlVMTCwgKnNw
ID0gbWZuX3RvX3BhZ2Uoc21mbik7CisgICAgYm9vbCBkeWluZyA9IEFDQ0VT
U19PTkNFKGQtPmlzX2R5aW5nKTsKICAgICBzdHJ1Y3QgcGFnZV9saXN0X2hl
YWQgKnBpbl9saXN0OwogICAgIHVuc2lnbmVkIGludCBwYWdlczsKICAgICB1
MzIgc2hhZG93X3R5cGU7CkBAIC0xMjIyLDExICsxMjIzLDMyIEBAIHZvaWQg
c2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3QKICAgICAgICAg
ICoganVzdCBiZWZvcmUgdGhlIGFsbG9jYXRvciBoYW5kcyB0aGUgcGFnZSBv
dXQgYWdhaW4uICovCiAgICAgICAgIHBhZ2Vfc2V0X3RsYmZsdXNoX3RpbWVz
dGFtcChzcCk7CiAgICAgICAgIHBlcmZjX2RlY3Ioc2hhZG93X2FsbG9jX2Nv
dW50KTsKLSAgICAgICAgcGFnZV9saXN0X2FkZF90YWlsKHNwLCAmZC0+YXJj
aC5wYWdpbmcuc2hhZG93LmZyZWVsaXN0KTsKKworICAgICAgICAvKgorICAg
ICAgICAgKiBGb3IgZHlpbmcgZG9tYWlucywgYWN0dWFsbHkgZnJlZSB0aGUg
bWVtb3J5IGhlcmUuIFRoaXMgd2F5IGxlc3MKKyAgICAgICAgICogd29yayBp
cyBsZWZ0IHRvIHNoYWRvd19maW5hbF90ZWFyZG93bigpLCB3aGljaCBjYW5u
b3QgZWFzaWx5IGhhdmUKKyAgICAgICAgICogcHJlZW1wdGlvbiBjaGVja3Mg
YWRkZWQuCisgICAgICAgICAqLworICAgICAgICBpZiAoIHVubGlrZWx5KGR5
aW5nKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIC8qCisgICAgICAgICAg
ICAgKiBUaGUgYmFja3BvaW50ZXIgZmllbGQgKHNoLmJhY2spIHVzZWQgYnkg
c2hhZG93IGNvZGUgYWxpYXNlcyB0aGUKKyAgICAgICAgICAgICAqIGRvbWFp
biBvd25lciBmaWVsZCwgdW5jb25kaXRpb25hbGx5IGNsZWFyIGl0IGhlcmUg
dG8gYXZvaWQKKyAgICAgICAgICAgICAqIGZyZWVfZG9taGVhcF9wYWdlKCkg
YXR0ZW1wdGluZyB0byBwYXJzZSBpdC4KKyAgICAgICAgICAgICAqLworICAg
ICAgICAgICAgcGFnZV9zZXRfb3duZXIoc3AsIE5VTEwpOworICAgICAgICAg
ICAgZnJlZV9kb21oZWFwX3BhZ2Uoc3ApOworICAgICAgICB9CisgICAgICAg
IGVsc2UKKyAgICAgICAgICAgIHBhZ2VfbGlzdF9hZGRfdGFpbChzcCwgJmQt
PmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlbGlzdCk7CisKICAgICAgICAgc3Ag
PSBuZXh0OwogICAgIH0KIAotICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5m
cmVlX3BhZ2VzICs9IHBhZ2VzOworICAgIGlmICggdW5saWtlbHkoZHlpbmcp
ICkKKyAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnRvdGFsX3BhZ2Vz
IC09IHBhZ2VzOworICAgIGVsc2UKKyAgICAgICAgZC0+YXJjaC5wYWdpbmcu
c2hhZG93LmZyZWVfcGFnZXMgKz0gcGFnZXM7CiB9CiAKIC8qIERpdmVydCBh
IHBhZ2UgZnJvbSB0aGUgcG9vbCB0byBiZSB1c2VkIGJ5IHRoZSBwMm0gbWFw
cGluZy4KQEAgLTEyOTYsOSArMTMxOCw5IEBAIHNoYWRvd19mcmVlX3AybV9w
YWdlKHN0cnVjdCBkb21haW4gKmQsIHMKICAgICAgKiBwYWdpbmcgbG9jaykg
YW5kIHRoZSBsb2ctZGlydHkgY29kZSAod2hpY2ggYWx3YXlzIGRvZXMpLiAq
LwogICAgIHBhZ2luZ19sb2NrX3JlY3Vyc2l2ZShkKTsKIAotICAgIHNoYWRv
d19mcmVlKGQsIHBhZ2VfdG9fbWZuKHBnKSk7CiAgICAgZC0+YXJjaC5wYWdp
bmcuc2hhZG93LnAybV9wYWdlcy0tOwogICAgIGQtPmFyY2gucGFnaW5nLnNo
YWRvdy50b3RhbF9wYWdlcysrOworICAgIHNoYWRvd19mcmVlKGQsIHBhZ2Vf
dG9fbWZuKHBnKSk7CiAKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-09.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGZyZWUgdGhlIHBhZ2luZyBtZW1vcnkgcG9v
bCBwcmVlbXB0aXZlbHkKClRoZSBwYWdpbmcgbWVtb3J5IHBvb2wgaXMgY3Vy
cmVudGx5IGZyZWVkIGluIHR3byBkaWZmZXJlbnQgcGxhY2VzOgpmcm9tIHtz
aGFkb3csaGFwfV90ZWFyZG93bigpIHZpYSBkb21haW5fcmVsaW5xdWlzaF9y
ZXNvdXJjZXMoKSBhbmQKZnJvbSB7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRv
d24oKSB2aWEgY29tcGxldGVfZG9tYWluX2Rlc3Ryb3koKS4KV2hpbGUgdGhl
IGZvcm1lciBkb2VzIGhhbmRsZSBwcmVlbXB0aW9uLCB0aGUgbGF0ZXIgZG9l
c24ndC4KCkF0dGVtcHQgdG8gbW92ZSBhcyBtdWNoIHAybSByZWxhdGVkIGZy
ZWVpbmcgYXMgcG9zc2libGUgdG8gaGFwcGVuCmJlZm9yZSB0aGUgY2FsbCB0
byB7c2hhZG93LGhhcH1fdGVhcmRvd24oKSwgc28gdGhhdCBtb3N0IG1lbW9y
eSBjYW4gYmUKZnJlZWQgaW4gYSBwcmVlbXB0aXZlIHdheS4gIEluIG9yZGVy
IHRvIGF2b2lkIGNhdXNpbmcgaXNzdWVzIHRvCmV4aXN0aW5nIGNhbGxlcnMg
bGVhdmUgdGhlIHJvb3QgcDJtIHBhZ2UgdGFibGVzIHNldCBhbmQgZnJlZSB0
aGVtIGluCntoYXAsc2hhZG93fV9maW5hbF90ZWFyZG93bigpLiAgQWxzbyBt
b2RpZnkge2hhcCxzaGFkb3d9X2ZyZWUgdG8gZnJlZQp0aGUgcGFnZSBpbW1l
ZGlhdGVseSBpZiB0aGUgZG9tYWluIGlzIGR5aW5nLCBzbyB0aGF0IHBhZ2Vz
IGRvbid0CmFjY3VtdWxhdGUgaW4gdGhlIHBvb2wgd2hlbiB7c2hhZG93LGhh
cH1fZmluYWxfdGVhcmRvd24oKSBnZXQgY2FsbGVkLgoKTW92ZSBhbHRwMm1f
dmNwdV9kaXNhYmxlX3ZlKCkgdG8gYmUgZG9uZSBpbiBoYXBfdGVhcmRvd24o
KSwgYXMgdGhhdCdzCnRoZSBwbGFjZSB3aGVyZSBhbHRwMm1fYWN0aXZlIGdl
dHMgZGlzYWJsZWQgbm93LgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0yMDIyLTMz
NzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVl
Z2FuIDx0aW1AeGVuLm9yZz4KCi0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4u
YworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTM4LDcgKzM4LDYg
QEAKICNpbmNsdWRlIDx4ZW4vbGl2ZXBhdGNoLmg+CiAjaW5jbHVkZSA8cHVi
bGljL3N5c2N0bC5oPgogI2luY2x1ZGUgPHB1YmxpYy9odm0vaHZtX3ZjcHUu
aD4KLSNpbmNsdWRlIDxhc20vYWx0cDJtLmg+CiAjaW5jbHVkZSA8YXNtL3Jl
Z3MuaD4KICNpbmNsdWRlIDxhc20vbWMxNDY4MThydGMuaD4KICNpbmNsdWRl
IDxhc20vc3lzdGVtLmg+CkBAIC0yMTIwLDEyICsyMTE5LDYgQEAgaW50IGRv
bWFpbl9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1Y3QgZAogICAgICAgICAg
ICAgdnBtdV9kZXN0cm95KHYpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYg
KCBhbHRwMm1fYWN0aXZlKGQpICkKLSAgICAgICAgewotICAgICAgICAgICAg
Zm9yX2VhY2hfdmNwdSAoIGQsIHYgKQotICAgICAgICAgICAgICAgIGFsdHAy
bV92Y3B1X2Rpc2FibGVfdmUodik7Ci0gICAgICAgIH0KLQogICAgICAgICBp
ZiAoIGlzX3B2X2RvbWFpbihkKSApCiAgICAgICAgIHsKICAgICAgICAgICAg
IGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKLS0tIGEveGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCkBA
IC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdlLmg+
CiAjaW5jbHVkZSA8eGVuL2d1ZXN0X2FjY2Vzcy5oPgogI2luY2x1ZGUgPHhl
bi9rZXloYW5kbGVyLmg+CisjaW5jbHVkZSA8YXNtL2FsdHAybS5oPgogI2lu
Y2x1ZGUgPGFzbS9ldmVudC5oPgogI2luY2x1ZGUgPGFzbS9wYWdlLmg+CiAj
aW5jbHVkZSA8YXNtL2N1cnJlbnQuaD4KQEAgLTU0NSwyNCArNTQ2LDggQEAg
dm9pZCBoYXBfZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZAogICAg
IHVuc2lnbmVkIGludCBpOwogCiAgICAgaWYgKCBodm1fYWx0cDJtX3N1cHBv
cnRlZCgpICkKLSAgICB7Ci0gICAgICAgIGQtPmFyY2guYWx0cDJtX2FjdGl2
ZSA9IDA7Ci0KLSAgICAgICAgaWYgKCBkLT5hcmNoLmFsdHAybV9lcHRwICkK
LSAgICAgICAgewotICAgICAgICAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+
YXJjaC5hbHRwMm1fZXB0cCk7Ci0gICAgICAgICAgICBkLT5hcmNoLmFsdHAy
bV9lcHRwID0gTlVMTDsKLSAgICAgICAgfQotCi0gICAgICAgIGlmICggZC0+
YXJjaC5hbHRwMm1fdmlzaWJsZV9lcHRwICkKLSAgICAgICAgewotICAgICAg
ICAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+YXJjaC5hbHRwMm1fdmlzaWJs
ZV9lcHRwKTsKLSAgICAgICAgICAgIGQtPmFyY2guYWx0cDJtX3Zpc2libGVf
ZXB0cCA9IE5VTEw7Ci0gICAgICAgIH0KLQogICAgICAgICBmb3IgKCBpID0g
MDsgaSA8IE1BWF9BTFRQMk07IGkrKyApCiAgICAgICAgICAgICBwMm1fdGVh
cmRvd24oZC0+YXJjaC5hbHRwMm1fcDJtW2ldLCB0cnVlKTsKLSAgICB9CiAK
ICAgICAvKiBEZXN0cm95IG5lc3RlZHAybSdzIGZpcnN0ICovCiAgICAgZm9y
IChpID0gMDsgaSA8IE1BWF9ORVNURURQMk07IGkrKykgewpAQCAtNTc3LDYg
KzU2Miw4IEBAIHZvaWQgaGFwX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21h
aW4gKmQKICAgICBwYWdpbmdfbG9jayhkKTsKICAgICBoYXBfc2V0X2FsbG9j
YXRpb24oZCwgMCwgTlVMTCk7CiAgICAgQVNTRVJUKGQtPmFyY2gucGFnaW5n
LmhhcC5wMm1fcGFnZXMgPT0gMCk7CisgICAgQVNTRVJUKGQtPmFyY2gucGFn
aW5nLmhhcC5mcmVlX3BhZ2VzID09IDApOworICAgIEFTU0VSVChkLT5hcmNo
LnBhZ2luZy5oYXAudG90YWxfcGFnZXMgPT0gMCk7CiAgICAgcGFnaW5nX3Vu
bG9jayhkKTsKIH0KIApAQCAtNTg0LDYgKzU3MSw3IEBAIHZvaWQgaGFwX3Rl
YXJkb3duKHN0cnVjdCBkb21haW4gKmQsIGJvb2wKIHsKICAgICBzdHJ1Y3Qg
dmNwdSAqdjsKICAgICBtZm5fdCBtZm47CisgICAgdW5zaWduZWQgaW50IGk7
CiAKICAgICBBU1NFUlQoZC0+aXNfZHlpbmcpOwogICAgIEFTU0VSVChkICE9
IGN1cnJlbnQtPmRvbWFpbik7CkBAIC02MDUsNiArNTkzLDMyIEBAIHZvaWQg
aGFwX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQsIGJvb2wKICAgICAgICAg
fQogICAgIH0KIAorICAgIHBhZ2luZ191bmxvY2soZCk7CisKKyAgICAvKiBM
ZWF2ZSB0aGUgcm9vdCBwdCBpbiBjYXNlIHdlIGdldCBmdXJ0aGVyIGF0dGVt
cHRzIHRvIG1vZGlmeSB0aGUgcDJtLiAqLworICAgIGlmICggaHZtX2FsdHAy
bV9zdXBwb3J0ZWQoKSApCisgICAgeworICAgICAgICBpZiAoIGFsdHAybV9h
Y3RpdmUoZCkgKQorICAgICAgICAgICAgZm9yX2VhY2hfdmNwdSAoIGQsIHYg
KQorICAgICAgICAgICAgICAgIGFsdHAybV92Y3B1X2Rpc2FibGVfdmUodik7
CisKKyAgICAgICAgZC0+YXJjaC5hbHRwMm1fYWN0aXZlID0gMDsKKworICAg
ICAgICBGUkVFX1hFTkhFQVBfUEFHRShkLT5hcmNoLmFsdHAybV9lcHRwKTsK
KyAgICAgICAgRlJFRV9YRU5IRUFQX1BBR0UoZC0+YXJjaC5hbHRwMm1fdmlz
aWJsZV9lcHRwKTsKKworICAgICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9B
TFRQMk07IGkrKyApCisgICAgICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJj
aC5hbHRwMm1fcDJtW2ldLCBmYWxzZSk7CisgICAgfQorCisgICAgLyogRGVz
dHJveSBuZXN0ZWRwMm0ncyBhZnRlciBhbHRwMm0uICovCisgICAgZm9yICgg
aSA9IDA7IGkgPCBNQVhfTkVTVEVEUDJNOyBpKysgKQorICAgICAgICBwMm1f
dGVhcmRvd24oZC0+YXJjaC5uZXN0ZWRfcDJtW2ldLCBmYWxzZSk7CisKKyAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCBmYWxzZSk7CisK
KyAgICBwYWdpbmdfbG9jayhkKTsKKwogICAgIGlmICggZC0+YXJjaC5wYWdp
bmcuaGFwLnRvdGFsX3BhZ2VzICE9IDAgKQogICAgIHsKICAgICAgICAgaGFw
X3NldF9hbGxvY2F0aW9uKGQsIDAsIHByZWVtcHRlZCk7Ci0tLSBhL3hlbi9h
cmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKKysrIGIveGVuL2FyY2gveDg2
L21tL3NoYWRvdy9jb21tb24uYwpAQCAtMjc5NSw2ICsyNzk1LDE5IEBAIHZv
aWQgc2hhZG93X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQsIGIKICAgICAg
ICAgfQogICAgIH0KIAorICAgIHBhZ2luZ191bmxvY2soZCk7CisKKyAgICBw
Mm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCBmYWxzZSk7CisKKyAg
ICBwYWdpbmdfbG9jayhkKTsKKworICAgIC8qCisgICAgICogUmVjbGFpbSBh
bGwgc2hhZG93IG1lbW9yeSBzbyB0aGF0IHNoYWRvd19zZXRfYWxsb2NhdGlv
bigpIGRvZXNuJ3QgZmluZAorICAgICAqIGluLXVzZSBwYWdlcywgYXMgX3No
YWRvd19wcmVhbGxvYygpIHdpbGwgbm8gbG9uZ2VyIHRyeSB0byByZWNsYWlt
IHBhZ2VzCisgICAgICogYmVjYXVzZSB0aGUgZG9tYWluIGlzIGR5aW5nLgor
ICAgICAqLworICAgIHNoYWRvd19ibG93X3RhYmxlcyhkKTsKKwogI2lmIChT
SEFET1dfT1BUSU1JWkFUSU9OUyAmIChTSE9QVF9WSVJUVUFMX1RMQnxTSE9Q
VF9PVVRfT0ZfU1lOQykpCiAgICAgLyogRnJlZSB0aGUgdmlydHVhbC1UTEIg
YXJyYXkgYXR0YWNoZWQgdG8gZWFjaCB2Y3B1ICovCiAgICAgZm9yX2VhY2hf
dmNwdShkLCB2KQpAQCAtMjkxMyw2ICsyOTI2LDkgQEAgdm9pZCBzaGFkb3df
ZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbgogICAgICAgICAgICAgICAg
ICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9wYWdlcywKICAgICAg
ICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdl
cywKICAgICAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cu
cDJtX3BhZ2VzKTsKKyAgICBBU1NFUlQoIWQtPmFyY2gucGFnaW5nLnNoYWRv
dy50b3RhbF9wYWdlcyk7CisgICAgQVNTRVJUKCFkLT5hcmNoLnBhZ2luZy5z
aGFkb3cuZnJlZV9wYWdlcyk7CisgICAgQVNTRVJUKCFkLT5hcmNoLnBhZ2lu
Zy5zaGFkb3cucDJtX3BhZ2VzKTsKICAgICBwYWdpbmdfdW5sb2NrKGQpOwog
fQogCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.14-10.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.14-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj
dDogeGVuL3g4NjogcDJtOiBBZGQgcHJlZW1wdGlvbiBpbiBwMm1fdGVhcmRv
d24oKQoKVGhlIGxpc3QgcDJtLT5wYWdlcyBjb250YWluIGFsbCB0aGUgcGFn
ZXMgdXNlZCBieSB0aGUgUDJNLiBPbiBsYXJnZQppbnN0YW5jZSB0aGlzIGNh
biBiZSBxdWl0ZSBsYXJnZSBhbmQgdGhlIHRpbWUgc3BlbnQgdG8gY2FsbApk
LT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoKSB3aWxsIHRha2UgbW9yZSB0aGFu
IDFtcyBmb3IgYSA4MEdCIGd1ZXN0Cm9uIGEgWGVuIHJ1bm5pbmcgaW4gbmVz
dGVkIGVudmlyb25tZW50IG9uIGEgYzUubWV0YWwuCgpCeSBleHRyYXBvbGF0
aW9uLCBpdCB3b3VsZCB0YWtlID4gMTAwbXMgZm9yIGEgOFRCIGd1ZXN0ICh3
aGF0IHdlCmN1cnJlbnQgc2VjdXJpdHkgc3VwcG9ydCkuIFNvIGFkZCBzb21l
IHByZWVtcHRpb24gaW4gcDJtX3RlYXJkb3duKCkKYW5kIHByb3BhZ2F0ZSB0
byB0aGUgY2FsbGVycy4gTm90ZSB0aGVyZSBhcmUgMyBwbGFjZXMgd2hlcmUK
dGhlIHByZWVtcHRpb24gaXMgbm90IGVuYWJsZWQ6CiAgICAtIGhhcF9maW5h
bF90ZWFyZG93bigpL3NoYWRvd19maW5hbF90ZWFyZG93bigpOiBXZSBhcmUK
ICAgICAgcHJldmVudGluZyB1cGRhdGUgdGhlIFAyTSBvbmNlIHRoZSBkb21h
aW4gaXMgZHlpbmcgKHNvCiAgICAgIG5vIG1vcmUgcGFnZXMgY291bGQgYmUg
YWxsb2NhdGVkKSBhbmQgbW9zdCBvZiB0aGUgUDJNIHBhZ2VzCiAgICAgIHdp
bGwgYmUgZnJlZWQgaW4gcHJlZW1wdGl2ZSBtYW5uZWVyIHdoZW4gcmVsaW5x
dWlzaGluZyB0aGUKICAgICAgcmVzb3VyY2VzLiBTbyB0aGlzIGlzIGZpbmUg
dG8gZGlzYWJsZSBwcmVlbXB0aW9uLgogICAgLSBzaGFkb3dfZW5hYmxlKCk6
IFRoaXMgaXMgZmluZSBiZWNhdXNlIGl0IHdpbGwgdW5kbyB0aGUgYWxsb2Nh
dGlvbgogICAgICB0aGF0IG1heSBoYXZlIGJlZW4gbWFkZSBieSBwMm1fYWxs
b2NfdGFibGUoKSAoc28gb25seSB0aGUgcm9vdAogICAgICBwYWdlIHRhYmxl
KS4KClRoZSBwcmVlbXB0aW9uIGlzIGFyYml0cmFyaWx5IGNoZWNrZWQgZXZl
cnkgMTAyNCBpdGVyYXRpb25zLgoKTm90ZSB0aGF0IHdpdGggdGhlIGN1cnJl
bnQgYXBwcm9hY2gsIFhlbiBkb2Vzbid0IGtlZXAgdHJhY2sgb24gd2hldGhl
cgp0aGUgYWx0L25lc3RlZCBQMk1zIGhhdmUgYmVlbiBjbGVhcmVkLiBTbyB0
aGVyZSBhcmUgc29tZSByZWR1bmRhbnQgd29yay4KSG93ZXZlciwgdGhpcyBp
cyBub3QgZXhwZWN0ZWQgdG8gaW5jdXJyIHRvbyBtdWNoIG92ZXJoZWFkICh0
aGUgUDJNIGxvY2sKc2hvdWxkbid0IGJlIGNvbnRlbmRlZCBkdXJpbmcgdGVh
cmRvd24pLiBTbyB0aGlzIGlzIG9wdGltaXphdGlvbiBpcwpsZWZ0IG91dHNp
ZGUgb2YgdGhlIHNlY3VyaXR5IGV2ZW50LgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCi0tLSBhL3hlbi9pbmNs
dWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9w
Mm0uaApAQCAtNTk1LDcgKzU5NSw3IEBAIGludCBwMm1faW5pdChzdHJ1Y3Qg
ZG9tYWluICpkKTsKIGludCBwMm1fYWxsb2NfdGFibGUoc3RydWN0IHAybV9k
b21haW4gKnAybSk7CiAKIC8qIFJldHVybiBhbGwgdGhlIHAybSByZXNvdXJj
ZXMgdG8gWGVuLiAqLwotdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9k
b21haW4gKnAybSwgYm9vbCByZW1vdmVfcm9vdCk7Cit2b2lkIHAybV90ZWFy
ZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290
LCBib29sICpwcmVlbXB0ZWQpOwogdm9pZCBwMm1fZmluYWxfdGVhcmRvd24o
c3RydWN0IGRvbWFpbiAqZCk7CiAKIC8qIEFkZCBhIHBhZ2UgdG8gYSBkb21h
aW4ncyBwMm0gdGFibGUgKi8KLS0tIGEveGVuL2FyY2gveDg2L21tL2hhcC9o
YXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCkBAIC01NDcs
MTcgKzU0NywxNyBAQCB2b2lkIGhhcF9maW5hbF90ZWFyZG93bihzdHJ1Y3Qg
ZG9tYWluICpkCiAKICAgICBpZiAoIGh2bV9hbHRwMm1fc3VwcG9ydGVkKCkg
KQogICAgICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9BTFRQMk07IGkrKyAp
Ci0gICAgICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJjaC5hbHRwMm1fcDJt
W2ldLCB0cnVlKTsKKyAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNo
LmFsdHAybV9wMm1baV0sIHRydWUsIE5VTEwpOwogCiAgICAgLyogRGVzdHJv
eSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZvciAoaSA9IDA7IGkgPCBN
QVhfTkVTVEVEUDJNOyBpKyspIHsKLSAgICAgICAgcDJtX3RlYXJkb3duKGQt
PmFyY2gubmVzdGVkX3AybVtpXSwgdHJ1ZSk7CisgICAgICAgIHAybV90ZWFy
ZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIHRydWUsIE5VTEwpOwogICAg
IH0KIAogICAgIGlmICggZC0+YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3BhZ2Vz
ICE9IDAgKQogICAgICAgICBoYXBfdGVhcmRvd24oZCwgTlVMTCk7CiAKLSAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKKyAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlLCBOVUxM
KTsKICAgICAvKiBGcmVlIGFueSBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJk
b3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFw
X3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwpAQCAtNjA4LDE0ICs2MDgs
MjQgQEAgdm9pZCBoYXBfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYm9v
bAogICAgICAgICBGUkVFX1hFTkhFQVBfUEFHRShkLT5hcmNoLmFsdHAybV92
aXNpYmxlX2VwdHApOwogCiAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgTUFY
X0FMVFAyTTsgaSsrICkKLSAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5h
cmNoLmFsdHAybV9wMm1baV0sIGZhbHNlKTsKKyAgICAgICAgeworICAgICAg
ICAgICAgcDJtX3RlYXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgZmFs
c2UsIHByZWVtcHRlZCk7CisgICAgICAgICAgICBpZiAoIHByZWVtcHRlZCAm
JiAqcHJlZW1wdGVkICkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAg
ICAgIH0KICAgICB9CiAKICAgICAvKiBEZXN0cm95IG5lc3RlZHAybSdzIGFm
dGVyIGFsdHAybS4gKi8KICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9ORVNU
RURQMk07IGkrKyApCi0gICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNoLm5l
c3RlZF9wMm1baV0sIGZhbHNlKTsKKyAgICB7CisgICAgICAgIHAybV90ZWFy
ZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIGZhbHNlLCBwcmVlbXB0ZWQp
OworICAgICAgICBpZiAoIHByZWVtcHRlZCAmJiAqcHJlZW1wdGVkICkKKyAg
ICAgICAgICAgIHJldHVybjsKKyAgICB9CiAKLSAgICBwMm1fdGVhcmRvd24o
cDJtX2dldF9ob3N0cDJtKGQpLCBmYWxzZSk7CisgICAgcDJtX3RlYXJkb3du
KHAybV9nZXRfaG9zdHAybShkKSwgZmFsc2UsIHByZWVtcHRlZCk7CisgICAg
aWYgKCBwcmVlbXB0ZWQgJiYgKnByZWVtcHRlZCApCisgICAgICAgIHJldHVy
bjsKIAogICAgIHBhZ2luZ19sb2NrKGQpOwogCi0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9wMm0uYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMKQEAgLTcz
NywxMiArNzM3LDEzIEBAIGludCBwMm1fYWxsb2NfdGFibGUoc3RydWN0IHAy
bV9kb21haW4gKnAKICAqIGh2bSBmaXhtZTogd2hlbiBhZGRpbmcgc3VwcG9y
dCBmb3IgcHZoIG5vbi1oYXJkd2FyZSBkb21haW5zLCB0aGlzIHBhdGggbXVz
dAogICogY2xlYW51cCBhbnkgZm9yZWlnbiBwMm0gdHlwZXMgKHJlbGVhc2Ug
cmVmY250cyBvbiB0aGVtKS4KICAqLwotdm9pZCBwMm1fdGVhcmRvd24oc3Ry
dWN0IHAybV9kb21haW4gKnAybSwgYm9vbCByZW1vdmVfcm9vdCkKK3ZvaWQg
cDJtX3RlYXJkb3duKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIGJvb2wgcmVt
b3ZlX3Jvb3QsIGJvb2wgKnByZWVtcHRlZCkKIC8qIFJldHVybiBhbGwgdGhl
IHAybSBwYWdlcyB0byBYZW4uCiAgKiBXZSBrbm93IHdlIGRvbid0IGhhdmUg
YW55IGV4dHJhIG1hcHBpbmdzIHRvIHRoZXNlIHBhZ2VzICovCiB7CiAgICAg
c3RydWN0IHBhZ2VfaW5mbyAqcGcsICpyb290X3BnID0gTlVMTDsKICAgICBz
dHJ1Y3QgZG9tYWluICpkOworICAgIHVuc2lnbmVkIGludCBpID0gMDsKIAog
ICAgIGlmIChwMm0gPT0gTlVMTCkKICAgICAgICAgcmV0dXJuOwpAQCAtNzYx
LDggKzc2MiwxOSBAQCB2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2Rv
bWFpbiAqcDJtCiAgICAgfQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xp
c3RfcmVtb3ZlX2hlYWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGlmICgg
cGcgIT0gcm9vdF9wZyApCi0gICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5m
cmVlX3BhZ2UoZCwgcGcpOworICAgIHsKKyAgICAgICAgaWYgKCBwZyA9PSBy
b290X3BnICkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIGQt
PmFyY2gucGFnaW5nLmZyZWVfcGFnZShkLCBwZyk7CisKKyAgICAgICAgLyog
QXJiaXRyYXJpbHkgY2hlY2sgcHJlZW1wdGlvbiBldmVyeSAxMDI0IGl0ZXJh
dGlvbnMgKi8KKyAgICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgISgrK2kgJSAx
MDI0KSAmJiBnZW5lcmFsX3ByZWVtcHRfY2hlY2soKSApCisgICAgICAgIHsK
KyAgICAgICAgICAgICpwcmVlbXB0ZWQgPSB0cnVlOworICAgICAgICAgICAg
YnJlYWs7CisgICAgICAgIH0KKyAgICB9CiAKICAgICBpZiAoIHJvb3RfcGcg
KQogICAgICAgICBwYWdlX2xpc3RfYWRkKHJvb3RfcGcsICZwMm0tPnBhZ2Vz
KTsKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24uYworKysg
Yi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0yNzQ5LDgg
KzI3NDksMTIgQEAgaW50IHNoYWRvd19lbmFibGUoc3RydWN0IGRvbWFpbiAq
ZCwgdTMyCiAgb3V0X2xvY2tlZDoKICAgICBwYWdpbmdfdW5sb2NrKGQpOwog
IG91dF91bmxvY2tlZDoKKyAgICAvKgorICAgICAqIFRoaXMgaXMgZmluZSB0
byBpZ25vcmUgdGhlIHByZWVtcHRpb24gaGVyZSBiZWNhdXNlIG9ubHkgdGhl
IHJvb3QKKyAgICAgKiB3aWxsIGJlIGFsbG9jYXRlZCBieSBwMm1fYWxsb2Nf
dGFibGUoKS4KKyAgICAgKi8KICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBhZ2V0
YWJsZV9pc19udWxsKHAybV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAgICAg
ICAgcDJtX3RlYXJkb3duKHAybSwgdHJ1ZSk7CisgICAgICAgIHAybV90ZWFy
ZG93bihwMm0sIHRydWUsIE5VTEwpOwogICAgIGlmICggcnYgIT0gMCAmJiBw
ZyAhPSBOVUxMICkKICAgICB7CiAgICAgICAgIHBnLT5jb3VudF9pbmZvICY9
IH5QR0NfY291bnRfbWFzazsKQEAgLTI3OTcsNyArMjgwMSw5IEBAIHZvaWQg
c2hhZG93X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQsIGIKIAogICAgIHBh
Z2luZ191bmxvY2soZCk7CiAKLSAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9o
b3N0cDJtKGQpLCBmYWxzZSk7CisgICAgcDJtX3RlYXJkb3duKHAybV9nZXRf
aG9zdHAybShkKSwgZmFsc2UsIHByZWVtcHRlZCk7CisgICAgaWYgKCBwcmVl
bXB0ZWQgJiYgKnByZWVtcHRlZCApCisgICAgICAgIHJldHVybjsKIAogICAg
IHBhZ2luZ19sb2NrKGQpOwogCkBAIC0yOTE2LDcgKzI5MjIsNyBAQCB2b2lk
IHNoYWRvd19maW5hbF90ZWFyZG93bihzdHJ1Y3QgZG9tYWluCiAgICAgICAg
IHNoYWRvd190ZWFyZG93bihkLCBOVUxMKTsKIAogICAgIC8qIEl0IGlzIG5v
dyBzYWZlIHRvIHB1bGwgZG93biB0aGUgcDJtIG1hcC4gKi8KLSAgICBwMm1f
dGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKKyAgICBwMm1f
dGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlLCBOVUxMKTsKICAg
ICAvKiBGcmVlIGFueSBzaGFkb3cgbWVtb3J5IHRoYXQgdGhlIHAybSB0ZWFy
ZG93biByZWxlYXNlZCAqLwogICAgIHBhZ2luZ19sb2NrKGQpOwogICAgIHNo
YWRvd19zZXRfYWxsb2NhdGlvbihkLCAwLCBOVUxMKTsK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-01.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-01.patch"
Content-Transfer-Encoding: base64

RnJvbSA0YjQzNTkxMjJhNDE0Y2MxNTE1NmUxM2UzODA1OTg4YjcxZmY5ZGEw
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpEYXRlOiBNb24sIDYgSnVuIDIwMjIgMDY6
MTc6MjUgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvMl0geGVuL2FybTogcDJt
OiBQcmV2ZW50IGFkZGluZyBtYXBwaW5nIHdoZW4gZG9tYWluIGlzIGR5aW5n
CgpEdXJpbmcgdGhlIGRvbWFpbiBkZXN0cm95IHByb2Nlc3MsIHRoZSBkb21h
aW4gd2lsbCBzdGlsbCBiZSBhY2Nlc3NpYmxlCnVudGlsIGl0IGlzIGZ1bGx5
IGRlc3Ryb3llZC4gU28gZG9lcyB0aGUgUDJNIGJlY2F1c2Ugd2UgZG9uJ3Qg
YmFpbApvdXQgZWFybHkgaWYgaXNfZHlpbmcgaXMgbm9uLXplcm8uIElmIGEg
ZG9tYWluIGhhcyBwZXJtaXNzaW9uIHRvCm1vZGlmeSB0aGUgb3RoZXIgZG9t
YWluJ3MgUDJNIChpLmUuIGRvbTAsIG9yIGEgc3R1YmRvbWFpbiksIHRoZW4K
Zm9yZWlnbiBtYXBwaW5nIGNhbiBiZSBhZGRlZCBwYXN0IHJlbGlucXVpc2hf
cDJtX21hcHBpbmcoKS4KClRoZXJlZm9yZSwgd2UgbmVlZCB0byBwcmV2ZW50
IG1hcHBpbmcgdG8gYmUgYWRkZWQgd2hlbiB0aGUgZG9tYWluCmlzIGR5aW5n
LiBUaGlzIGNvbW1pdCBwcmV2ZW50cyBzdWNoIGFkZGluZyBvZiBtYXBwaW5n
IGJ5IGFkZGluZyB0aGUKZC0+aXNfZHlpbmcgY2hlY2sgdG8gcDJtX3NldF9l
bnRyeSgpLiBBbHNvIHRoaXMgY29tbWl0IGVuaGFuY2VzIHRoZQpjaGVjayBp
biByZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgdG8gbWFrZSBzdXJlIHRoYXQg
bm8gbWFwcGluZ3MgY2FuCmJlIGFkZGVkIGluIHRoZSBQMk0gYWZ0ZXIgdGhl
IFAyTSBsb2NrIGlzIHJlbGVhc2VkLgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0y
MDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IEp1bGllbiBH
cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEhlbnJ5
IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KVGVzdGVkLWJ5OiBIZW5yeSBX
YW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5OiBTdGVmYW5v
IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ci0tLQogeGVu
L2FyY2gvYXJtL3AybS5jIHwgMTEgKysrKysrKysrKysKIDEgZmlsZSBjaGFu
Z2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv
YXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5jCmluZGV4IGZiNzFmYTRj
MWM5MC4uY2JlZmY5MGY0MzcxIDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0v
cDJtLmMKKysrIGIveGVuL2FyY2gvYXJtL3AybS5jCkBAIC0xMDkzLDYgKzEw
OTMsMTUgQEAgaW50IHAybV9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4g
KnAybSwKIHsKICAgICBpbnQgcmMgPSAwOwogCisgICAgLyoKKyAgICAgKiBB
bnkgcmVmZXJlbmNlIHRha2VuIGJ5IHRoZSBQMk0gbWFwcGluZ3MgKGUuZy4g
Zm9yZWlnbiBtYXBwaW5nKSB3aWxsCisgICAgICogYmUgZHJvcHBlZCBpbiBy
ZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkuIEFzIHRoZSBQMk0gd2lsbCBzdGls
bAorICAgICAqIGJlIGFjY2Vzc2libGUgYWZ0ZXIsIHdlIG5lZWQgdG8gcHJl
dmVudCBtYXBwaW5nIHRvIGJlIGFkZGVkIHdoZW4gdGhlCisgICAgICogZG9t
YWluIGlzIGR5aW5nLgorICAgICAqLworICAgIGlmICggdW5saWtlbHkocDJt
LT5kb21haW4tPmlzX2R5aW5nKSApCisgICAgICAgIHJldHVybiAtRU5PTUVN
OworCiAgICAgd2hpbGUgKCBuciApCiAgICAgewogICAgICAgICB1bnNpZ25l
ZCBsb25nIG1hc2s7CkBAIC0xNjEwLDYgKzE2MTksOCBAQCBpbnQgcmVsaW5x
dWlzaF9wMm1fbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2ln
bmVkIGludCBvcmRlcjsKICAgICBnZm5fdCBzdGFydCwgZW5kOwogCisgICAg
QlVHX09OKCFkLT5pc19keWluZyk7CisgICAgLyogTm8gbWFwcGluZ3MgY2Fu
IGJlIGFkZGVkIGluIHRoZSBQMk0gYWZ0ZXIgdGhlIFAyTSBsb2NrIGlzIHJl
bGVhc2VkLiAqLwogICAgIHAybV93cml0ZV9sb2NrKHAybSk7CiAKICAgICBz
dGFydCA9IHAybS0+bG93ZXN0X21hcHBlZF9nZm47Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-02.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-02.patch"
Content-Transfer-Encoding: base64

RnJvbSAwZDU4NDY0OTAzNDhmYTA5YTBkMDkxNWQ3Yzc5NTY4NWEwMTZjZTEw
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPgpEYXRlOiBNb24sIDYgSnVuIDIwMjIgMDY6
MTc6MjYgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0geGVuL2FybTogcDJt
OiBIYW5kbGUgcHJlZW1wdGlvbiB3aGVuIGZyZWVpbmcgaW50ZXJtZWRpYXRl
CiBwYWdlIHRhYmxlcwoKQXQgdGhlIG1vbWVudCB0aGUgUDJNIHBhZ2UgdGFi
bGVzIHdpbGwgYmUgZnJlZWQgd2hlbiB0aGUgZG9tYWluIHN0cnVjdHVyZQpp
cyBmcmVlZCB3aXRob3V0IGFueSBwcmVlbXB0aW9uLiBBcyB0aGUgUDJNIGlz
IHF1aXRlIGxhcmdlLCBpdGVyYXRpbmcKdGhyb3VnaCB0aGlzIG1heSB0YWtl
IG1vcmUgdGltZSB0aGFuIGl0IGlzIHJlYXNvbmFibGUgd2l0aG91dCBpbnRl
cm1lZGlhdGUKcHJlZW1wdGlvbiAodG8gcnVuIHNvZnRpcnFzIGFuZCBwZXJo
YXBzIHNjaGVkdWxlcikuCgpTcGxpdCBwMm1fdGVhcmRvd24oKSBpbiB0d28g
cGFydHM6IG9uZSBwcmVlbXB0aWJsZSBhbmQgY2FsbGVkIHdoZW4KcmVsaW5x
dWlzaGluZyB0aGUgcmVzb3VyY2VzLCB0aGUgb3RoZXIgb25lIG5vbi1wcmVl
bXB0aWJsZSBhbmQgY2FsbGVkCndoZW4gZnJlZWluZyB0aGUgZG9tYWluIHN0
cnVjdHVyZS4KCkFzIHdlIGFyZSBub3cgZnJlZWluZyB0aGUgUDJNIHBhZ2Vz
IGVhcmx5LCB3ZSBhbHNvIG5lZWQgdG8gcHJldmVudApmdXJ0aGVyIGFsbG9j
YXRpb24gaWYgc29tZW9uZSBjYWxsIHAybV9zZXRfZW50cnkoKSBwYXN0IHAy
bV90ZWFyZG93bigpCihJIHdhc24ndCBhYmxlIHRvIHByb3ZlIHRoaXMgd2ls
bCBuZXZlciBoYXBwZW4pLiBUaGlzIGlzIGRvbmUgYnkKdGhlIGNoZWNraW5n
IGRvbWFpbi0+aXNfZHlpbmcgZnJvbSBwcmV2aW91cyBwYXRjaCBpbiBwMm1f
c2V0X2VudHJ5KCkuCgpTaW1pbGFybHksIHdlIHdhbnQgdG8gbWFrZSBzdXJl
IHRoYXQgbm8tb25lIGNhbiBhY2Nlc3NlZCB0aGUgZnJlZQpwYWdlcy4gVGhl
cmVmb3JlIHRoZSByb290IGlzIGNsZWFyZWQgYmVmb3JlIGZyZWVpbmcgcGFn
ZXMuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjItMzM3NDYgLyBYU0EtNDEw
LgoKU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9u
LmNvbT4KU2lnbmVkLW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh
cm0uY29tPgpUZXN0ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt
LmNvbT4KUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl
bGxpbmlAa2VybmVsLm9yZz4KLS0tCiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMg
ICAgIHwgMTAgKysrKysrKy0tCiB4ZW4vYXJjaC9hcm0vcDJtLmMgICAgICAg
IHwgNDcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t
CiB4ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oIHwgMTMgKysrKysrKysrLS0K
IDMgZmlsZXMgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlv
bnMoLSkKCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMgYi94
ZW4vYXJjaC9hcm0vZG9tYWluLmMKaW5kZXggOTZlMWIyMzU1MDFkLi4yNjk0
YzM5MTI3YzUgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYwor
KysgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMKQEAgLTc4OSwxMCArNzg5LDEw
IEBAIGZhaWw6CiB2b2lkIGFyY2hfZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRv
bWFpbiAqZCkKIHsKICAgICAvKiBJT01NVSBwYWdlIHRhYmxlIGlzIHNoYXJl
ZCB3aXRoIFAyTSwgYWx3YXlzIGNhbGwKLSAgICAgKiBpb21tdV9kb21haW5f
ZGVzdHJveSgpIGJlZm9yZSBwMm1fdGVhcmRvd24oKS4KKyAgICAgKiBpb21t
dV9kb21haW5fZGVzdHJveSgpIGJlZm9yZSBwMm1fZmluYWxfdGVhcmRvd24o
KS4KICAgICAgKi8KICAgICBpb21tdV9kb21haW5fZGVzdHJveShkKTsKLSAg
ICBwMm1fdGVhcmRvd24oZCk7CisgICAgcDJtX2ZpbmFsX3RlYXJkb3duKGQp
OwogICAgIGRvbWFpbl92Z2ljX2ZyZWUoZCk7CiAgICAgZG9tYWluX3Z1YXJ0
X2ZyZWUoZCk7CiAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+c2hhcmVkX2lu
Zm8pOwpAQCAtOTk2LDYgKzk5Niw3IEBAIGVudW0gewogICAgIFBST0dfeGVu
LAogICAgIFBST0dfcGFnZSwKICAgICBQUk9HX21hcHBpbmcsCisgICAgUFJP
R19wMm0sCiAgICAgUFJPR19kb25lLAogfTsKIApAQCAtMTA1Niw2ICsxMDU3
LDExIEBAIGludCBkb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoc3RydWN0
IGRvbWFpbiAqZCkKICAgICAgICAgaWYgKCByZXQgKQogICAgICAgICAgICAg
cmV0dXJuIHJldDsKIAorICAgIFBST0dSRVNTKHAybSk6CisgICAgICAgIHJl
dCA9IHAybV90ZWFyZG93bihkKTsKKyAgICAgICAgaWYgKCByZXQgKQorICAg
ICAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIFBST0dSRVNTKGRvbmUpOgog
ICAgICAgICBicmVhazsKIApkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3Ay
bS5jIGIveGVuL2FyY2gvYXJtL3AybS5jCmluZGV4IGNiZWZmOTBmNDM3MS4u
M2JjZDFlODk3ZTg4IDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMK
KysrIGIveGVuL2FyY2gvYXJtL3AybS5jCkBAIC0xNTI3LDE3ICsxNTI3LDU4
IEBAIHN0YXRpYyB2b2lkIHAybV9mcmVlX3ZtaWQoc3RydWN0IGRvbWFpbiAq
ZCkKICAgICBzcGluX3VubG9jaygmdm1pZF9hbGxvY19sb2NrKTsKIH0KIAot
dm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKK2ludCBwMm1f
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKIHsKICAgICBzdHJ1Y3QgcDJt
X2RvbWFpbiAqcDJtID0gcDJtX2dldF9ob3N0cDJtKGQpOworICAgIHVuc2ln
bmVkIGxvbmcgY291bnQgPSAwOwogICAgIHN0cnVjdCBwYWdlX2luZm8gKnBn
OworICAgIHVuc2lnbmVkIGludCBpOworICAgIGludCByYyA9IDA7CisKKyAg
ICBwMm1fd3JpdGVfbG9jayhwMm0pOworCisgICAgLyoKKyAgICAgKiBXZSBh
cmUgYWJvdXQgdG8gZnJlZSB0aGUgaW50ZXJtZWRpYXRlIHBhZ2UtdGFibGVz
LCBzbyBjbGVhciB0aGUKKyAgICAgKiByb290IHRvIHByZXZlbnQgYW55IHdh
bGsgdG8gdXNlIHRoZW0uCisgICAgICovCisgICAgZm9yICggaSA9IDA7IGkg
PCBQMk1fUk9PVF9QQUdFUzsgaSsrICkKKyAgICAgICAgY2xlYXJfYW5kX2Ns
ZWFuX3BhZ2UocDJtLT5yb290ICsgaSk7CisKKyAgICAvKgorICAgICAqIFRo
ZSBkb21haW4gd2lsbCBub3QgYmUgc2NoZWR1bGVkIGFueW1vcmUsIHNvIGlu
IHRoZW9yeSB3ZSBzaG91bGQKKyAgICAgKiBub3QgbmVlZCB0byBmbHVzaCB0
aGUgVExCcy4gRG8gaXQgZm9yIHNhZmV0eSBwdXJwb3NlLgorICAgICAqCisg
ICAgICogTm90ZSB0aGF0IGFsbCB0aGUgZGV2aWNlcyBoYXZlIGFscmVhZHkg
YmVlbiBkZS1hc3NpZ25lZC4gU28gd2UgZG9uJ3QKKyAgICAgKiBuZWVkIHRv
IGZsdXNoIHRoZSBJT01NVSBUTEIgaGVyZS4KKyAgICAgKi8KKyAgICBwMm1f
Zm9yY2VfdGxiX2ZsdXNoX3N5bmMocDJtKTsKKworICAgIHdoaWxlICggKHBn
ID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQorICAg
IHsKKyAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOworICAgICAgICBj
b3VudCsrOworICAgICAgICAvKiBBcmJpdHJhcmlseSBwcmVlbXB0IGV2ZXJ5
IDUxMiBpdGVyYXRpb25zICovCisgICAgICAgIGlmICggIShjb3VudCAlIDUx
MikgJiYgaHlwZXJjYWxsX3ByZWVtcHRfY2hlY2soKSApCisgICAgICAgIHsK
KyAgICAgICAgICAgIHJjID0gLUVSRVNUQVJUOworICAgICAgICAgICAgYnJl
YWs7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBwMm1fd3JpdGVfdW5sb2Nr
KHAybSk7CisKKyAgICByZXR1cm4gcmM7Cit9CisKK3ZvaWQgcDJtX2ZpbmFs
X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpCit7CisgICAgc3RydWN0IHAy
bV9kb21haW4gKnAybSA9IHAybV9nZXRfaG9zdHAybShkKTsKIAogICAgIC8q
IHAybSBub3QgYWN0dWFsbHkgaW5pdGlhbGl6ZWQgKi8KICAgICBpZiAoICFw
Mm0tPmRvbWFpbiApCiAgICAgICAgIHJldHVybjsKIAotICAgIHdoaWxlICgg
KHBnID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQot
ICAgICAgICBmcmVlX2RvbWhlYXBfcGFnZShwZyk7CisgICAgQVNTRVJUKHBh
Z2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOwogCiAgICAgaWYgKCBwMm0t
PnJvb3QgKQogICAgICAgICBmcmVlX2RvbWhlYXBfcGFnZXMocDJtLT5yb290
LCBQMk1fUk9PVF9PUkRFUik7CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9h
c20tYXJtL3AybS5oIGIveGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaAppbmRl
eCA4ZjExZDljOTdiNWQuLmIzYmE4MzI4M2UxMSAxMDA2NDQKLS0tIGEveGVu
L2luY2x1ZGUvYXNtLWFybS9wMm0uaAorKysgYi94ZW4vaW5jbHVkZS9hc20t
YXJtL3AybS5oCkBAIC0xOTIsOCArMTkyLDE3IEBAIHZvaWQgc2V0dXBfdmly
dF9wYWdpbmcodm9pZCk7CiAvKiBJbml0IHRoZSBkYXRhc3RydWN0dXJlcyBm
b3IgbGF0ZXIgdXNlIGJ5IHRoZSBwMm0gY29kZSAqLwogaW50IHAybV9pbml0
KHN0cnVjdCBkb21haW4gKmQpOwogCi0vKiBSZXR1cm4gYWxsIHRoZSBwMm0g
cmVzb3VyY2VzIHRvIFhlbi4gKi8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVj
dCBkb21haW4gKmQpOworLyoKKyAqIFRoZSBQMk0gcmVzb3VyY2VzIGFyZSBm
cmVlZCBpbiB0d28gcGFydHM6CisgKiAgLSBwMm1fdGVhcmRvd24oKSB3aWxs
IGJlIGNhbGxlZCB3aGVuIHJlbGlucXVpc2ggdGhlIHJlc291cmNlcy4gSXQK
KyAqICAgIHdpbGwgZnJlZSBsYXJnZSByZXNvdXJjZXMgKGUuZy4gaW50ZXJt
ZWRpYXRlIHBhZ2UtdGFibGVzKSB0aGF0CisgKiAgICByZXF1aXJlcyBwcmVl
bXB0aW9uLgorICogIC0gcDJtX2ZpbmFsX3RlYXJkb3duKCkgd2lsbCBiZSBj
YWxsZWQgd2hlbiBkb21haW4gc3RydWN0IGlzIGJlZW4KKyAqICAgIGZyZWVk
LiBUaGlzICpjYW5ub3QqIGJlIHByZWVtcHRlZCBhbmQgdGhlcmVmb3JlIG9u
ZSBzbWFsbAorICogICAgcmVzb3VyY2VzIHNob3VsZCBiZSBmcmVlZCBoZXJl
LgorICovCitpbnQgcDJtX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpOwor
dm9pZCBwMm1fZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCk7CiAK
IC8qCiAgKiBSZW1vdmUgbWFwcGluZyByZWZjb3VudCBvbiBlYWNoIG1hcHBp
bmcgcGFnZSBpbiB0aGUgcDJtCi0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-03.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-03.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGFkZCBvcHRpb24gdG8gc2tpcCByb290IHBh
Z2V0YWJsZSByZW1vdmFsIGluIHAybV90ZWFyZG93bigpCgpBZGQgYSBuZXcg
cGFyYW1ldGVyIHRvIHAybV90ZWFyZG93bigpIGluIG9yZGVyIHRvIHNlbGVj
dCB3aGV0aGVyIHRoZQpyb290IHBhZ2UgdGFibGUgc2hvdWxkIGFsc28gYmUg
ZnJlZWQuICBOb3RlIHRoYXQgYWxsIHVzZXJzIGFyZQphZGp1c3RlZCB0byBw
YXNzIHRoZSBwYXJhbWV0ZXIgdG8gcmVtb3ZlIHRoZSByb290IHBhZ2UgdGFi
bGVzLCBzbwpiZWhhdmlvciBpcyBub3QgbW9kaWZpZWQuCgpObyBmdW5jdGlv
bmFsIGNoYW5nZSBpbnRlbmRlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTdWdnZXN0ZWQtYnk6IEp1bGllbiBHcmFs
bCA8anVsaWVuQHhlbi5vcmc+ClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBN
b25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGltIERl
ZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2
L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTU3
NCw3ICs1NzQsNyBAQCBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCk7
CiBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0p
OwogCiAvKiBSZXR1cm4gYWxsIHRoZSBwMm0gcmVzb3VyY2VzIHRvIFhlbi4g
Ki8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1fZG9tYWluICpwMm0p
Owordm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybSwg
Ym9vbCByZW1vdmVfcm9vdCk7CiB2b2lkIHAybV9maW5hbF90ZWFyZG93bihz
dHJ1Y3QgZG9tYWluICpkKTsKIAogLyogQWRkIGEgcGFnZSB0byBhIGRvbWFp
bidzIHAybSB0YWJsZSAqLwotLS0gYS94ZW4vYXJjaC94ODYvbW0vaGFwL2hh
cC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAgLTU0MSwx
OCArNTQxLDE4IEBAIHZvaWQgaGFwX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBk
b21haW4gKmQKICAgICAgICAgfQogCiAgICAgICAgIGZvciAoIGkgPSAwOyBp
IDwgTUFYX0FMVFAyTTsgaSsrICkKLSAgICAgICAgICAgIHAybV90ZWFyZG93
bihkLT5hcmNoLmFsdHAybV9wMm1baV0pOworICAgICAgICAgICAgcDJtX3Rl
YXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgdHJ1ZSk7CiAgICAgfQog
CiAgICAgLyogRGVzdHJveSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZv
ciAoaSA9IDA7IGkgPCBNQVhfTkVTVEVEUDJNOyBpKyspIHsKLSAgICAgICAg
cDJtX3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtpXSk7CisgICAgICAg
IHAybV90ZWFyZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIHRydWUpOwog
ICAgIH0KIAogICAgIGlmICggZC0+YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3Bh
Z2VzICE9IDAgKQogICAgICAgICBoYXBfdGVhcmRvd24oZCwgTlVMTCk7CiAK
LSAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpKTsKKyAgICBw
Mm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKICAgICAv
KiBGcmVlIGFueSBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJkb3duIHJlbGVh
c2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFwX3NldF9hbGxv
Y2F0aW9uKGQsIDAsIE5VTEwpOwotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJt
LmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03NDksMTEgKzc0
OSwxMSBAQCBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVjdCBwMm1fZG9tYWlu
ICpwCiAgKiBodm0gZml4bWU6IHdoZW4gYWRkaW5nIHN1cHBvcnQgZm9yIHB2
aCBub24taGFyZHdhcmUgZG9tYWlucywgdGhpcyBwYXRoIG11c3QKICAqIGNs
ZWFudXAgYW55IGZvcmVpZ24gcDJtIHR5cGVzIChyZWxlYXNlIHJlZmNudHMg
b24gdGhlbSkuCiAgKi8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1f
ZG9tYWluICpwMm0pCit2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2Rv
bWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290KQogLyogUmV0dXJuIGFsbCB0
aGUgcDJtIHBhZ2VzIHRvIFhlbi4KICAqIFdlIGtub3cgd2UgZG9uJ3QgaGF2
ZSBhbnkgZXh0cmEgbWFwcGluZ3MgdG8gdGhlc2UgcGFnZXMgKi8KIHsKLSAg
ICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKKyAgICBzdHJ1Y3QgcGFnZV9pbmZv
ICpwZywgKnJvb3RfcGcgPSBOVUxMOwogICAgIHN0cnVjdCBkb21haW4gKmQ7
CiAKICAgICBpZiAocDJtID09IE5VTEwpCkBAIC03NjMsMTAgKzc2MywyMiBA
QCB2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAK
ICAgICBwMm1fbG9jayhwMm0pOwogICAgIEFTU0VSVChhdG9taWNfcmVhZCgm
ZC0+c2hyX3BhZ2VzKSA9PSAwKTsKLSAgICBwMm0tPnBoeXNfdGFibGUgPSBw
YWdldGFibGVfbnVsbCgpOworCisgICAgaWYgKCByZW1vdmVfcm9vdCApCisg
ICAgICAgIHAybS0+cGh5c190YWJsZSA9IHBhZ2V0YWJsZV9udWxsKCk7Cisg
ICAgZWxzZSBpZiAoICFwYWdldGFibGVfaXNfbnVsbChwMm0tPnBoeXNfdGFi
bGUpICkKKyAgICB7CisgICAgICAgIHJvb3RfcGcgPSBwYWdldGFibGVfZ2V0
X3BhZ2UocDJtLT5waHlzX3RhYmxlKTsKKyAgICAgICAgY2xlYXJfZG9tYWlu
X3BhZ2UocGFnZXRhYmxlX2dldF9tZm4ocDJtLT5waHlzX3RhYmxlKSk7Cisg
ICAgfQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGQtPmFyY2gucGFnaW5nLmZy
ZWVfcGFnZShkLCBwZyk7CisgICAgICAgIGlmICggcGcgIT0gcm9vdF9wZyAp
CisgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoZCwgcGcp
OworCisgICAgaWYgKCByb290X3BnICkKKyAgICAgICAgcGFnZV9saXN0X2Fk
ZChyb290X3BnLCAmcDJtLT5wYWdlcyk7CisKICAgICBwMm1fdW5sb2NrKHAy
bSk7CiB9CiAKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24u
YworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0y
NzAxLDcgKzI3MDEsNyBAQCBpbnQgc2hhZG93X2VuYWJsZShzdHJ1Y3QgZG9t
YWluICpkLCB1MzIKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogIG91dF91bmxv
Y2tlZDoKICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBhZ2V0YWJsZV9pc19udWxs
KHAybV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAgICAgICAgcDJtX3RlYXJk
b3duKHAybSk7CisgICAgICAgIHAybV90ZWFyZG93bihwMm0sIHRydWUpOwog
ICAgIGlmICggcnYgIT0gMCAmJiBwZyAhPSBOVUxMICkKICAgICB7CiAgICAg
ICAgIHBnLT5jb3VudF9pbmZvICY9IH5QR0NfY291bnRfbWFzazsKQEAgLTI4
NjYsNyArMjg2Niw3IEBAIHZvaWQgc2hhZG93X2ZpbmFsX3RlYXJkb3duKHN0
cnVjdCBkb21haW4KICAgICAgICAgc2hhZG93X3RlYXJkb3duKGQsIE5VTEwp
OwogCiAgICAgLyogSXQgaXMgbm93IHNhZmUgdG8gcHVsbCBkb3duIHRoZSBw
Mm0gbWFwLiAqLwotICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0o
ZCkpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIHRy
dWUpOwogICAgIC8qIEZyZWUgYW55IHNoYWRvdyBtZW1vcnkgdGhhdCB0aGUg
cDJtIHRlYXJkb3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7
CiAgICAgc2hhZG93X3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-04.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvSEFQOiBhZGp1c3QgbW9uaXRvciB0YWJsZSByZWxhdGVkIGVycm9y
IGhhbmRsaW5nCgpoYXBfbWFrZV9tb25pdG9yX3RhYmxlKCkgd2lsbCByZXR1
cm4gSU5WQUxJRF9NRk4gaWYgaXQgZW5jb3VudGVycyBhbgplcnJvciBjb25k
aXRpb24sIGJ1dCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcygpIHdhc27igJl0
IGhhbmRsaW5nIHRoaXMKdmFsdWUsIHJlc3VsdGluZyBpbiBhbiBpbmFwcHJv
cHJpYXRlIHZhbHVlIGJlaW5nIHN0b3JlZCBpbgptb25pdG9yX3RhYmxlLiBU
aGlzIHdvdWxkIHN1YnNlcXVlbnRseSBtaXNndWlkZSBhdCBsZWFzdApoYXBf
dmNwdV90ZWFyZG93bigpLiBBdm9pZCB0aGlzIGJ5IGJhaWxpbmcgZWFybHku
CgpGdXJ0aGVyLCB3aGVuIGEgZG9tYWluIGhhcy93YXMgYWxyZWFkeSBjcmFz
aGVkIG9yIChwZXJoYXBzIGxlc3MKaW1wb3J0YW50IGFzIHRoZXJlJ3Mgbm8g
c3VjaCBwYXRoIGtub3duIHRvIGxlYWQgaGVyZSkgaXMgYWxyZWFkeSBkeWlu
ZywKYXZvaWQgY2FsbGluZyBkb21haW5fY3Jhc2goKSBvbiBpdCBhZ2FpbiAt
IHRoYXQncyBhdCBiZXN0IGNvbmZ1c2luZy4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBSb2dl
ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KCi0tLSBhL3hl
bi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYwpAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgPGFzbS9k
b21haW4uaD4KICNpbmNsdWRlIDx4ZW4vbnVtYS5oPgogI2luY2x1ZGUgPGFz
bS9odm0vbmVzdGVkaHZtLmg+CisjaW5jbHVkZSA8cHVibGljL3NjaGVkLmg+
CiAKICNpbmNsdWRlICJwcml2YXRlLmgiCiAKQEAgLTQwNSw4ICs0MDYsMTMg
QEAgc3RhdGljIG1mbl90IGhhcF9tYWtlX21vbml0b3JfdGFibGUoc3RydQog
ICAgIHJldHVybiBtNG1mbjsKIAogIG9vbToKLSAgICBwcmludGsoWEVOTE9H
X0dfRVJSICJvdXQgb2YgbWVtb3J5IGJ1aWxkaW5nIG1vbml0b3IgcGFnZXRh
YmxlXG4iKTsKLSAgICBkb21haW5fY3Jhc2goZCk7CisgICAgaWYgKCAhZC0+
aXNfZHlpbmcgJiYKKyAgICAgICAgICghZC0+aXNfc2h1dHRpbmdfZG93biB8
fCBkLT5zaHV0ZG93bl9jb2RlICE9IFNIVVRET1dOX2NyYXNoKSApCisgICAg
eworICAgICAgICBwcmludGsoWEVOTE9HX0dfRVJSICIlcGQ6IG91dCBvZiBt
ZW1vcnkgYnVpbGRpbmcgbW9uaXRvciBwYWdldGFibGVcbiIsCisgICAgICAg
ICAgICAgICBkKTsKKyAgICAgICAgZG9tYWluX2NyYXNoKGQpOworICAgIH0K
ICAgICByZXR1cm4gSU5WQUxJRF9NRk47CiB9CiAKQEAgLTc2Niw2ICs3NzIs
OSBAQCBzdGF0aWMgdm9pZCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1
CiAgICAgaWYgKCBwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLmh2bS5tb25p
dG9yX3RhYmxlKSApCiAgICAgewogICAgICAgICBtZm5fdCBtbWZuID0gaGFw
X21ha2VfbW9uaXRvcl90YWJsZSh2KTsKKworICAgICAgICBpZiAoIG1mbl9l
cShtbWZuLCBJTlZBTElEX01GTikgKQorICAgICAgICAgICAgZ290byB1bmxv
Y2s7CiAgICAgICAgIHYtPmFyY2guaHZtLm1vbml0b3JfdGFibGUgPSBwYWdl
dGFibGVfZnJvbV9tZm4obW1mbik7CiAgICAgICAgIG1ha2VfY3IzKHYsIG1t
Zm4pOwogICAgICAgICBodm1fdXBkYXRlX2hvc3RfY3IzKHYpOwpAQCAtNzc0
LDYgKzc4Myw3IEBAIHN0YXRpYyB2b2lkIGhhcF91cGRhdGVfcGFnaW5nX21v
ZGVzKHN0cnUKICAgICAvKiBDUjMgaXMgZWZmZWN0aXZlbHkgdXBkYXRlZCBi
eSBhIG1vZGUgY2hhbmdlLiBGbHVzaCBBU0lEcywgZXRjLiAqLwogICAgIGhh
cF91cGRhdGVfY3IzKHYsIDAsIGZhbHNlKTsKIAorIHVubG9jazoKICAgICBw
YWdpbmdfdW5sb2NrKGQpOwogICAgIHB1dF9nZm4oZCwgY3IzX2dmbik7CiB9
Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-05.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvc2hhZG93OiB0b2xlcmF0ZSBmYWlsdXJlIG9mIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKQoKU3Vic2VxdWVudGx5IHNoX3NldF90b3BsZXZlbF9z
aGFkb3coKSB3aWxsIGJlIGFkanVzdGVkIHRvIGluc3RhbGwgYQpibGFuayBl
bnRyeSBpbiBjYXNlIHByZWFsbG9jIGZhaWxzLiBUaGVyZSBhcmUsIGluIGZh
Y3QsIHByZS1leGlzdGluZwplcnJvciBwYXRocyB3aGljaCB3b3VsZCBwdXQg
aW4gcGxhY2UgYSBibGFuayBlbnRyeS4gVGhlIDQtIGFuZCAyLWxldmVsCmNv
ZGUgaW4gc2hfdXBkYXRlX2NyMygpLCBob3dldmVyLCBhc3N1bWUgdGhlIHRv
cCBsZXZlbCBlbnRyeSB0byBiZQp2YWxpZC4KCkhlbmNlIGJhaWwgZnJvbSB0
aGUgZnVuY3Rpb24gaW4gdGhlIHVubGlrZWx5IGV2ZW50IHRoYXQgaXQncyBu
b3QuIE5vdGUKdGhhdCAzLWxldmVsIGxvZ2ljIHdvcmtzIGRpZmZlcmVudGx5
OiBJbiBwYXJ0aWN1bGFyIGEgZ3Vlc3QgaXMgZnJlZSB0bwpzdXBwbHkgYSBQ
RFBUUiBwb2ludGluZyBhdCA0IG5vbi1wcmVzZW50IChvciBvdGhlcndpc2Ug
ZGVlbWVkIGludmFsaWQpCmVudHJpZXMuIFRoZSBndWVzdCB3aWxsIGNyYXNo
LCBidXQgd2UgYWxyZWFkeSBjb3BlIHdpdGggdGhhdC4KClJlYWxseSBtZm5f
dmFsaWQoKSBpcyBsaWtlbHkgd3JvbmcgdG8gdXNlIGluIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKSwKYW5kIGl0IHNob3VsZCBpbnN0ZWFkIGJlICFtZm5f
ZXEoZ21mbiwgSU5WQUxJRF9NRk4pLiBBdm9pZCBzdWNoIGEgY2hhbmdlCmlu
IHNlY3VyaXR5IGNvbnRleHQsIGJ1dCBhZGQgYSByZXNwZWN0aXZlIGFzc2Vy
dGlvbi4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00
MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KUmV2
aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5j
CisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKQEAgLTI1
MTYsNiArMjUxNiw3IEBAIHZvaWQgc2hfc2V0X3RvcGxldmVsX3NoYWRvdyhz
dHJ1Y3QgdmNwdQogICAgIC8qIE5vdyBmaWd1cmUgb3V0IHRoZSBuZXcgY29u
dGVudHM6IGlzIHRoaXMgYSB2YWxpZCBndWVzdCBNRk4/ICovCiAgICAgaWYg
KCAhbWZuX3ZhbGlkKGdtZm4pICkKICAgICB7CisgICAgICAgIEFTU0VSVCht
Zm5fZXEoZ21mbiwgSU5WQUxJRF9NRk4pKTsKICAgICAgICAgbmV3X2VudHJ5
ID0gcGFnZXRhYmxlX251bGwoKTsKICAgICAgICAgZ290byBpbnN0YWxsX25l
d19lbnRyeTsKICAgICB9Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cv
bXVsdGkuYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMK
QEAgLTMzMTIsNiArMzMxMiwxMSBAQCBzaF91cGRhdGVfY3IzKHN0cnVjdCB2
Y3B1ICp2LCBpbnQgZG9fbG9jCiAgICAgaWYgKCBzaF9yZW1vdmVfd3JpdGVf
YWNjZXNzKGQsIGdtZm4sIDQsIDApICE9IDAgKQogICAgICAgICBndWVzdF9m
bHVzaF90bGJfbWFzayhkLCBkLT5kaXJ0eV9jcHVtYXNrKTsKICAgICBzaF9z
ZXRfdG9wbGV2ZWxfc2hhZG93KHYsIDAsIGdtZm4sIFNIX3R5cGVfbDRfc2hh
ZG93LCBzaF9tYWtlX3NoYWRvdyk7CisgICAgaWYgKCB1bmxpa2VseShwYWdl
dGFibGVfaXNfbnVsbCh2LT5hcmNoLnBhZ2luZy5zaGFkb3cuc2hhZG93X3Rh
YmxlWzBdKSkgKQorICAgIHsKKyAgICAgICAgQVNTRVJUKGQtPmlzX2R5aW5n
IHx8IGQtPmlzX3NodXR0aW5nX2Rvd24pOworICAgICAgICByZXR1cm47Cisg
ICAgfQogICAgIGlmICggIXNoYWRvd19tb2RlX2V4dGVybmFsKGQpICYmICFp
c19wdl8zMmJpdF9kb21haW4oZCkgKQogICAgIHsKICAgICAgICAgbWZuX3Qg
c21mbiA9IHBhZ2V0YWJsZV9nZXRfbWZuKHYtPmFyY2gucGFnaW5nLnNoYWRv
dy5zaGFkb3dfdGFibGVbMF0pOwpAQCAtMzM3MCw2ICszMzc1LDExIEBAIHNo
X3VwZGF0ZV9jcjMoc3RydWN0IHZjcHUgKnYsIGludCBkb19sb2MKICAgICBp
ZiAoIHNoX3JlbW92ZV93cml0ZV9hY2Nlc3MoZCwgZ21mbiwgMiwgMCkgIT0g
MCApCiAgICAgICAgIGd1ZXN0X2ZsdXNoX3RsYl9tYXNrKGQsIGQtPmRpcnR5
X2NwdW1hc2spOwogICAgIHNoX3NldF90b3BsZXZlbF9zaGFkb3codiwgMCwg
Z21mbiwgU0hfdHlwZV9sMl9zaGFkb3csIHNoX21ha2Vfc2hhZG93KTsKKyAg
ICBpZiAoIHVubGlrZWx5KHBhZ2V0YWJsZV9pc19udWxsKHYtPmFyY2gucGFn
aW5nLnNoYWRvdy5zaGFkb3dfdGFibGVbMF0pKSApCisgICAgeworICAgICAg
ICBBU1NFUlQoZC0+aXNfZHlpbmcgfHwgZC0+aXNfc2h1dHRpbmdfZG93bik7
CisgICAgICAgIHJldHVybjsKKyAgICB9CiAjZWxzZQogI2Vycm9yIFRoaXMg
c2hvdWxkIG5ldmVyIGhhcHBlbgogI2VuZGlmCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-06.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9zaGFkb3c6IHRvbGVyYXRlIGZhaWx1cmUgaW4gc2hh
ZG93X3ByZWFsbG9jKCkKClByZXZlbnQgX3NoYWRvd19wcmVhbGxvYygpIGZy
b20gY2FsbGluZyBCVUcoKSB3aGVuIHVuYWJsZSB0byBmdWxmaWxsCnRoZSBw
cmUtYWxsb2NhdGlvbiBhbmQgaW5zdGVhZCByZXR1cm4gdHJ1ZS9mYWxzZS4g
IE1vZGlmeQpzaGFkb3dfcHJlYWxsb2MoKSB0byBjcmFzaCB0aGUgZG9tYWlu
IG9uIGFsbG9jYXRpb24gZmFpbHVyZSAoaWYgdGhlCmRvbWFpbiBpcyBub3Qg
YWxyZWFkeSBkeWluZyksIGFzIHNoYWRvdyBjYW5ub3Qgb3BlcmF0ZSBub3Jt
YWxseSBhZnRlcgp0aGF0LiAgTW9kaWZ5IGNhbGxlcnMgdG8gYWxzbyBncmFj
ZWZ1bGx5IGhhbmRsZSB7Xyx9c2hhZG93X3ByZWFsbG9jKCkKZmFpbGluZyB0
byBmdWxmaWxsIHRoZSByZXF1ZXN0LgoKTm90ZSB0aGlzIGluIHR1cm4gcmVx
dWlyZXMgYWRqdXN0aW5nIHRoZSBjYWxsZXJzIG9mCnNoX21ha2VfbW9uaXRv
cl90YWJsZSgpIGFsc28gdG8gaGFuZGxlIGl0IHJldHVybmluZyBJTlZBTElE
X01GTi4Kc2hfdXBkYXRlX3BhZ2luZ19tb2RlcygpIGlzIGFsc28gbW9kaWZp
ZWQgdG8gYWRkIGFkZGl0aW9uYWwgZXJyb3IKcGF0aHMgaW4gY2FzZSBvZiBh
bGxvY2F0aW9uIGZhaWx1cmUsIHNvbWUgb2YgdGhvc2Ugd2lsbCByZXR1cm4g
d2l0aApudWxsIG1vbml0b3IgcGFnZSB0YWJsZXMgKGFuZCB0aGUgZG9tYWlu
IGxpa2VseSBjcmFzaGVkKS4gIFRoaXMgaXMgbm8KZGlmZmVyZW50IHRoYXQg
Y3VycmVudCBlcnJvciBwYXRocywgYnV0IHRoZSBuZXdseSBpbnRyb2R1Y2Vk
IG9uZXMgYXJlCm1vcmUgbGlrZWx5IHRvIHRyaWdnZXIuCgpUaGUgbm93IGFk
ZGVkIGZhaWx1cmUgcG9pbnRzIGluIHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMo
KSBhbHNvIHJlcXVpcmUKdGhhdCBvbiBzb21lIGVycm9yIHJldHVybiBwYXRo
cyB0aGUgcHJldmlvdXMgc3RydWN0dXJlcyBhcmUgY2xlYXJlZCwKYW5kIHRo
dXMgbW9uaXRvciB0YWJsZSBpcyBudWxsLgoKV2hpbGUgdGhlcmUgYWRqdXN0
IHRoZSAndHlwZScgcGFyYW1ldGVyIHR5cGUgb2Ygc2hhZG93X3ByZWFsbG9j
KCkgdG8KdW5zaWduZWQgaW50IHJhdGhlciB0aGFuIHUzMi4KClRoaXMgaXMg
cGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PgpBY2tlZC1ieTogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94
ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCisrKyBiL3hlbi9hcmNo
L3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKQEAgLTM2LDYgKzM2LDcgQEAKICNp
bmNsdWRlIDxhc20vZmx1c2h0bGIuaD4KICNpbmNsdWRlIDxhc20vc2hhZG93
Lmg+CiAjaW5jbHVkZSA8eGVuL251bWEuaD4KKyNpbmNsdWRlIDxwdWJsaWMv
c2NoZWQuaD4KICNpbmNsdWRlICJwcml2YXRlLmgiCiAKIERFRklORV9QRVJf
Q1BVKHVpbnQzMl90LHRyYWNlX3NoYWRvd19wYXRoX2ZsYWdzKTsKQEAgLTky
OCwxNCArOTI5LDE1IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCB0cmFjZV9zaGFk
b3dfcHJlYWxsb2MKIAogLyogTWFrZSBzdXJlIHRoZXJlIGFyZSBhdCBsZWFz
dCBjb3VudCBvcmRlci1zaXplZCBwYWdlcwogICogYXZhaWxhYmxlIGluIHRo
ZSBzaGFkb3cgcGFnZSBwb29sLiAqLwotc3RhdGljIHZvaWQgX3NoYWRvd19w
cmVhbGxvYyhzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgcGFnZXMp
CitzdGF0aWMgYm9vbCBfX211c3RfY2hlY2sgX3NoYWRvd19wcmVhbGxvYyhz
dHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQgcGFnZXMpCiB7CiAgICAg
c3RydWN0IHZjcHUgKnY7CiAgICAgc3RydWN0IHBhZ2VfaW5mbyAqc3AsICp0
OwogICAgIG1mbl90IHNtZm47CiAgICAgaW50IGk7CiAKLSAgICBpZiAoIGQt
PmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2VzICkgcmV0
dXJuOworICAgIGlmICggZC0+YXJjaC5wYWdpbmcuc2hhZG93LmZyZWVfcGFn
ZXMgPj0gcGFnZXMgKQorICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8q
IFNob3VsZG4ndCBoYXZlIGVuYWJsZWQgc2hhZG93cyBpZiB3ZSd2ZSBubyB2
Y3B1cy4gKi8KICAgICBBU1NFUlQoZC0+dmNwdSAmJiBkLT52Y3B1WzBdKTsK
QEAgLTk1MSw3ICs5NTMsOCBAQCBzdGF0aWMgdm9pZCBfc2hhZG93X3ByZWFs
bG9jKHN0cnVjdCBkb21hCiAgICAgICAgIHNoX3VucGluKGQsIHNtZm4pOwog
CiAgICAgICAgIC8qIFNlZSBpZiB0aGF0IGZyZWVkIHVwIGVub3VnaCBzcGFj
ZSAqLwotICAgICAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVl
X3BhZ2VzID49IHBhZ2VzICkgcmV0dXJuOworICAgICAgICBpZiAoIGQtPmFy
Y2gucGFnaW5nLnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2VzICkKKyAgICAg
ICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAogICAgIC8qIFN0YWdlIHR3
bzogYWxsIHNoYWRvdyBwYWdlcyBhcmUgaW4gdXNlIGluIGhpZXJhcmNoaWVz
IHRoYXQgYXJlCkBAIC05NzQsNyArOTc3LDcgQEAgc3RhdGljIHZvaWQgX3No
YWRvd19wcmVhbGxvYyhzdHJ1Y3QgZG9tYQogICAgICAgICAgICAgICAgIGlm
ICggZC0+YXJjaC5wYWdpbmcuc2hhZG93LmZyZWVfcGFnZXMgPj0gcGFnZXMg
KQogICAgICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAgZ3Vl
c3RfZmx1c2hfdGxiX21hc2soZCwgZC0+ZGlydHlfY3B1bWFzayk7Ci0gICAg
ICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICAgICAg
cmV0dXJuIHRydWU7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg
fQogICAgICAgICB9CkBAIC05ODcsNyArOTkwLDEyIEBAIHN0YXRpYyB2b2lk
IF9zaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWEKICAgICAgICAgICAgZC0+
YXJjaC5wYWdpbmcuc2hhZG93LnRvdGFsX3BhZ2VzLAogICAgICAgICAgICBk
LT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcywKICAgICAgICAgICAg
ZC0+YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcyk7Ci0gICAgQlVHKCk7
CisKKyAgICBBU1NFUlQoZC0+aXNfZHlpbmcpOworCisgICAgZ3Vlc3RfZmx1
c2hfdGxiX21hc2soZCwgZC0+ZGlydHlfY3B1bWFzayk7CisKKyAgICByZXR1
cm4gZmFsc2U7CiB9CiAKIC8qIE1ha2Ugc3VyZSB0aGVyZSBhcmUgYXQgbGVh
c3QgY291bnQgcGFnZXMgb2YgdGhlIG9yZGVyIGFjY29yZGluZyB0bwpAQCAt
OTk1LDkgKzEwMDMsMTkgQEAgc3RhdGljIHZvaWQgX3NoYWRvd19wcmVhbGxv
YyhzdHJ1Y3QgZG9tYQogICogVGhpcyBtdXN0IGJlIGNhbGxlZCBiZWZvcmUg
YW55IGNhbGxzIHRvIHNoYWRvd19hbGxvYygpLiAgU2luY2UgdGhpcwogICog
d2lsbCBmcmVlIGV4aXN0aW5nIHNoYWRvd3MgdG8gbWFrZSByb29tLCBpdCBt
dXN0IGJlIGNhbGxlZCBlYXJseSBlbm91Z2gKICAqIHRvIGF2b2lkIGZyZWVp
bmcgc2hhZG93cyB0aGF0IHRoZSBjYWxsZXIgaXMgY3VycmVudGx5IHdvcmtp
bmcgb24uICovCi12b2lkIHNoYWRvd19wcmVhbGxvYyhzdHJ1Y3QgZG9tYWlu
ICpkLCB1MzIgdHlwZSwgdW5zaWduZWQgaW50IGNvdW50KQorYm9vbCBzaGFk
b3dfcHJlYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHR5
cGUsIHVuc2lnbmVkIGludCBjb3VudCkKIHsKLSAgICByZXR1cm4gX3NoYWRv
d19wcmVhbGxvYyhkLCBzaGFkb3dfc2l6ZSh0eXBlKSAqIGNvdW50KTsKKyAg
ICBib29sIHJldCA9IF9zaGFkb3dfcHJlYWxsb2MoZCwgc2hhZG93X3NpemUo
dHlwZSkgKiBjb3VudCk7CisKKyAgICBpZiAoICFyZXQgJiYgIWQtPmlzX2R5
aW5nICYmCisgICAgICAgICAoIWQtPmlzX3NodXR0aW5nX2Rvd24gfHwgZC0+
c2h1dGRvd25fY29kZSAhPSBTSFVURE9XTl9jcmFzaCkgKQorICAgICAgICAv
KgorICAgICAgICAgKiBGYWlsaW5nIHRvIGFsbG9jYXRlIG1lbW9yeSByZXF1
aXJlZCBmb3Igc2hhZG93IHVzYWdlIGNhbiBvbmx5IHJlc3VsdCBpbgorICAg
ICAgICAgKiBhIGRvbWFpbiBjcmFzaCwgZG8gaXQgaGVyZSByYXRoZXIgdGhh
dCByZWx5aW5nIG9uIGV2ZXJ5IGNhbGxlciB0byBkbyBpdC4KKyAgICAgICAg
ICovCisgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKKworICAgIHJldHVybiBy
ZXQ7CiB9CiAKIC8qIERlbGliZXJhdGVseSBmcmVlIGFsbCB0aGUgbWVtb3J5
IHdlIGNhbjogdGhpcyB3aWxsIHRlYXIgZG93biBhbGwgb2YKQEAgLTEyMTgs
NyArMTIzNiw3IEBAIHZvaWQgc2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAq
ZCwgbWZuX3QKIHN0YXRpYyBzdHJ1Y3QgcGFnZV9pbmZvICoKIHNoYWRvd19h
bGxvY19wMm1fcGFnZShzdHJ1Y3QgZG9tYWluICpkKQogewotICAgIHN0cnVj
dCBwYWdlX2luZm8gKnBnOworICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnID0g
TlVMTDsKIAogICAgIC8qIFRoaXMgaXMgY2FsbGVkIGJvdGggZnJvbSB0aGUg
cDJtIGNvZGUgKHdoaWNoIG5ldmVyIGhvbGRzIHRoZQogICAgICAqIHBhZ2lu
ZyBsb2NrKSBhbmQgdGhlIGxvZy1kaXJ0eSBjb2RlICh3aGljaCBhbHdheXMg
ZG9lcykuICovCkBAIC0xMjM2LDE2ICsxMjU0LDE4IEBAIHNoYWRvd19hbGxv
Y19wMm1fcGFnZShzdHJ1Y3QgZG9tYWluICpkKQogICAgICAgICAgICAgICAg
ICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cucDJtX3BhZ2VzLAogICAgICAg
ICAgICAgICAgICAgICBzaGFkb3dfbWluX2FjY2VwdGFibGVfcGFnZXMoZCkp
OwogICAgICAgICB9Ci0gICAgICAgIHBhZ2luZ191bmxvY2soZCk7Ci0gICAg
ICAgIHJldHVybiBOVUxMOworICAgICAgICBnb3RvIG91dDsKICAgICB9CiAK
LSAgICBzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlwZV9wMm1fdGFibGUsIDEp
OworICAgIGlmICggIXNoYWRvd19wcmVhbGxvYyhkLCBTSF90eXBlX3AybV90
YWJsZSwgMSkgKQorICAgICAgICBnb3RvIG91dDsKKwogICAgIHBnID0gbWZu
X3RvX3BhZ2Uoc2hhZG93X2FsbG9jKGQsIFNIX3R5cGVfcDJtX3RhYmxlLCAw
KSk7CiAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcysrOwog
ICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9wYWdlcy0tOwogICAg
IEFTU0VSVCghcGFnZV9nZXRfb3duZXIocGcpICYmICEocGctPmNvdW50X2lu
Zm8gJiBQR0NfY291bnRfbWFzaykpOwogCisgb3V0OgogICAgIHBhZ2luZ191
bmxvY2soZCk7CiAKICAgICByZXR1cm4gcGc7CkBAIC0xMzM2LDcgKzEzNTYs
OSBAQCBpbnQgc2hhZG93X3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4K
ICAgICAgICAgZWxzZSBpZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3Rh
bF9wYWdlcyA+IHBhZ2VzICkKICAgICAgICAgewogICAgICAgICAgICAgLyog
TmVlZCB0byByZXR1cm4gbWVtb3J5IHRvIGRvbWhlYXAgKi8KLSAgICAgICAg
ICAgIF9zaGFkb3dfcHJlYWxsb2MoZCwgMSk7CisgICAgICAgICAgICBpZiAo
ICFfc2hhZG93X3ByZWFsbG9jKGQsIDEpICkKKyAgICAgICAgICAgICAgICBy
ZXR1cm4gLUVOT01FTTsKKwogICAgICAgICAgICAgc3AgPSBwYWdlX2xpc3Rf
cmVtb3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlbGlzdCk7
CiAgICAgICAgICAgICBBU1NFUlQoc3ApOwogICAgICAgICAgICAgLyoKQEAg
LTIzMzQsMTIgKzIzNTYsMTMgQEAgc3RhdGljIHZvaWQgc2hfdXBkYXRlX3Bh
Z2luZ19tb2RlcyhzdHJ1YwogICAgIGlmICggbWZuX2VxKHYtPmFyY2gucGFn
aW5nLnNoYWRvdy5vb3Nfc25hcHNob3RbMF0sIElOVkFMSURfTUZOKSApCiAg
ICAgewogICAgICAgICBpbnQgaTsKKworICAgICAgICBpZiAoICFzaGFkb3df
cHJlYWxsb2MoZCwgU0hfdHlwZV9vb3Nfc25hcHNob3QsIFNIQURPV19PT1Nf
UEFHRVMpICkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBmb3Io
aSA9IDA7IGkgPCBTSEFET1dfT09TX1BBR0VTOyBpKyspCi0gICAgICAgIHsK
LSAgICAgICAgICAgIHNoYWRvd19wcmVhbGxvYyhkLCBTSF90eXBlX29vc19z
bmFwc2hvdCwgMSk7CiAgICAgICAgICAgICB2LT5hcmNoLnBhZ2luZy5zaGFk
b3cub29zX3NuYXBzaG90W2ldID0KICAgICAgICAgICAgICAgICBzaGFkb3df
YWxsb2MoZCwgU0hfdHlwZV9vb3Nfc25hcHNob3QsIDApOwotICAgICAgICB9
CiAgICAgfQogI2VuZGlmIC8qIE9PUyAqLwogCkBAIC0yNDAzLDYgKzI0MjYs
OSBAQCBzdGF0aWMgdm9pZCBzaF91cGRhdGVfcGFnaW5nX21vZGVzKHN0cnVj
CiAgICAgICAgICAgICBtZm5fdCBtbWZuID0gc2hfbWFrZV9tb25pdG9yX3Rh
YmxlKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2LCB2LT5hcmNo
LnBhZ2luZy5tb2RlLT5zaGFkb3cuc2hhZG93X2xldmVscyk7CiAKKyAgICAg
ICAgICAgIGlmICggbWZuX2VxKG1tZm4sIElOVkFMSURfTUZOKSApCisgICAg
ICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgICAgICB2LT5hcmNoLmh2
bS5tb25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX2Zyb21fbWZuKG1tZm4pOwog
ICAgICAgICAgICAgbWFrZV9jcjModiwgbW1mbik7CiAgICAgICAgICAgICBo
dm1fdXBkYXRlX2hvc3RfY3IzKHYpOwpAQCAtMjQ0MSw2ICsyNDY3LDEyIEBA
IHN0YXRpYyB2b2lkIHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMoc3RydWMKICAg
ICAgICAgICAgICAgICB2LT5hcmNoLmh2bS5tb25pdG9yX3RhYmxlID0gcGFn
ZXRhYmxlX251bGwoKTsKICAgICAgICAgICAgICAgICBuZXdfbWZuID0gc2hf
bWFrZV9tb25pdG9yX3RhYmxlKAogICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdiwgdi0+YXJjaC5wYWdpbmcubW9kZS0+c2hhZG93LnNoYWRvd19s
ZXZlbHMpOworICAgICAgICAgICAgICAgIGlmICggbWZuX2VxKG5ld19tZm4s
IElOVkFMSURfTUZOKSApCisgICAgICAgICAgICAgICAgeworICAgICAgICAg
ICAgICAgICAgICBzaF9kZXN0cm95X21vbml0b3JfdGFibGUodiwgb2xkX21m
biwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIG9sZF9tb2RlLT5zaGFkb3cuc2hhZG93X2xldmVscyk7CisgICAgICAg
ICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgICAgICB9CiAgICAg
ICAgICAgICAgICAgdi0+YXJjaC5odm0ubW9uaXRvcl90YWJsZSA9IHBhZ2V0
YWJsZV9mcm9tX21mbihuZXdfbWZuKTsKICAgICAgICAgICAgICAgICBTSEFE
T1dfUFJJTlRLKCJuZXcgbW9uaXRvciB0YWJsZSAlIlBSSV9tZm4gIlxuIiwK
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5feChuZXdfbWZu
KSk7CkBAIC0yNTI2LDcgKzI1NTgsMTIgQEAgdm9pZCBzaF9zZXRfdG9wbGV2
ZWxfc2hhZG93KHN0cnVjdCB2Y3B1CiAgICAgaWYgKCAhbWZuX3ZhbGlkKHNt
Zm4pICkKICAgICB7CiAgICAgICAgIC8qIE1ha2Ugc3VyZSB0aGVyZSdzIGVu
b3VnaCBmcmVlIHNoYWRvdyBtZW1vcnkuICovCi0gICAgICAgIHNoYWRvd19w
cmVhbGxvYyhkLCByb290X3R5cGUsIDEpOworICAgICAgICBpZiAoICFzaGFk
b3dfcHJlYWxsb2MoZCwgcm9vdF90eXBlLCAxKSApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIG5ld19lbnRyeSA9IHBhZ2V0YWJsZV9udWxsKCk7CisgICAg
ICAgICAgICBnb3RvIGluc3RhbGxfbmV3X2VudHJ5OworICAgICAgICB9CisK
ICAgICAgICAgLyogU2hhZG93IHRoZSBwYWdlLiAqLwogICAgICAgICBzbWZu
ID0gbWFrZV9zaGFkb3codiwgZ21mbiwgcm9vdF90eXBlKTsKICAgICB9Ci0t
LSBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvaHZtLmMKKysrIGIveGVuL2Fy
Y2gveDg2L21tL3NoYWRvdy9odm0uYwpAQCAtNzAwLDcgKzcwMCw5IEBAIG1m
bl90IHNoX21ha2VfbW9uaXRvcl90YWJsZShjb25zdCBzdHJ1Y3QKICAgICBB
U1NFUlQoIXBhZ2V0YWJsZV9nZXRfcGZuKHYtPmFyY2guaHZtLm1vbml0b3Jf
dGFibGUpKTsKIAogICAgIC8qIEd1YXJhbnRlZSB3ZSBjYW4gZ2V0IHRoZSBt
ZW1vcnkgd2UgbmVlZCAqLwotICAgIHNoYWRvd19wcmVhbGxvYyhkLCBTSF90
eXBlX21vbml0b3JfdGFibGUsIENPTkZJR19QQUdJTkdfTEVWRUxTKTsKKyAg
ICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlwZV9tb25pdG9yX3Rh
YmxlLCBDT05GSUdfUEFHSU5HX0xFVkVMUykgKQorICAgICAgICByZXR1cm4g
SU5WQUxJRF9NRk47CisKICAgICBtNG1mbiA9IHNoYWRvd19hbGxvYyhkLCBT
SF90eXBlX21vbml0b3JfdGFibGUsIDApOwogICAgIG1mbl90b19wYWdlKG00
bWZuKS0+c2hhZG93X2ZsYWdzID0gNDsKIAotLS0gYS94ZW4vYXJjaC94ODYv
bW0vc2hhZG93L211bHRpLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRv
dy9tdWx0aS5jCkBAIC0yNDQwLDkgKzI0NDAsMTQgQEAgc3RhdGljIGludCBz
aF9wYWdlX2ZhdWx0KHN0cnVjdCB2Y3B1ICp2LAogICAgICAqIFByZWFsbG9j
YXRlIHNoYWRvdyBwYWdlcyAqYmVmb3JlKiByZW1vdmluZyB3cml0YWJsZSBh
Y2Nlc3NlcwogICAgICAqIG90aGVyd2hpc2UgYW4gT09TIEwxIG1pZ2h0IGJl
IGRlbW90ZWQgYW5kIHByb21vdGVkIGFnYWluIHdpdGgKICAgICAgKiB3cml0
YWJsZSBtYXBwaW5ncy4gKi8KLSAgICBzaGFkb3dfcHJlYWxsb2MoZCwKLSAg
ICAgICAgICAgICAgICAgICAgU0hfdHlwZV9sMV9zaGFkb3csCi0gICAgICAg
ICAgICAgICAgICAgIEdVRVNUX1BBR0lOR19MRVZFTFMgPCA0ID8gMSA6IEdV
RVNUX1BBR0lOR19MRVZFTFMgLSAxKTsKKyAgICBpZiAoICFzaGFkb3dfcHJl
YWxsb2MoZCwgU0hfdHlwZV9sMV9zaGFkb3csCisgICAgICAgICAgICAgICAg
ICAgICAgICAgIEdVRVNUX1BBR0lOR19MRVZFTFMgPCA0CisgICAgICAgICAg
ICAgICAgICAgICAgICAgID8gMSA6IEdVRVNUX1BBR0lOR19MRVZFTFMgLSAx
KSApCisgICAgeworICAgICAgICBwYWdpbmdfdW5sb2NrKGQpOworICAgICAg
ICBwdXRfZ2ZuKGQsIGdmbl94KGdmbikpOworICAgICAgICByZXR1cm4gMDsK
KyAgICB9CiAKICAgICByYyA9IGd3X3JlbW92ZV93cml0ZV9hY2Nlc3Nlcyh2
LCB2YSwgJmd3KTsKIAotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3By
aXZhdGUuaAorKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L3ByaXZhdGUu
aApAQCAtMzgzLDcgKzM4Myw4IEBAIHZvaWQgc2hhZG93X3Byb21vdGUoc3Ry
dWN0IGRvbWFpbiAqZCwgbWYKIHZvaWQgc2hhZG93X2RlbW90ZShzdHJ1Y3Qg
ZG9tYWluICpkLCBtZm5fdCBnbWZuLCB1MzIgdHlwZSk7CiAKIC8qIFNoYWRv
dyBwYWdlIGFsbG9jYXRpb24gZnVuY3Rpb25zICovCi12b2lkICBzaGFkb3df
cHJlYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwgdTMyIHNoYWRvd190eXBlLCB1
bnNpZ25lZCBpbnQgY291bnQpOworYm9vbCBfX211c3RfY2hlY2sgc2hhZG93
X3ByZWFsbG9jKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGludCBzaGFk
b3dfdHlwZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1
bnNpZ25lZCBpbnQgY291bnQpOwogbWZuX3Qgc2hhZG93X2FsbG9jKHN0cnVj
dCBkb21haW4gKmQsCiAgICAgICAgICAgICAgICAgICAgIHUzMiBzaGFkb3df
dHlwZSwKICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBiYWNr
cG9pbnRlcik7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-07.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHJlZnVzZSBuZXcgYWxsb2NhdGlvbnMgZm9y
IGR5aW5nIGRvbWFpbnMKClRoaXMgd2lsbCBpbiBwYXJ0aWN1bGFyIHByZXZl
bnQgYW55IGF0dGVtcHRzIHRvIGFkZCBlbnRyaWVzIHRvIHRoZSBwMm0sCm9u
Y2UgLSBpbiBhIHN1YnNlcXVlbnQgY2hhbmdlIC0gbm9uLXJvb3QgZW50cmll
cyBoYXZlIGJlZW4gcmVtb3ZlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGlt
IERlZWdhbiA8dGltQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0v
aGFwL2hhcC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAg
LTI0NSw2ICsyNDUsOSBAQCBzdGF0aWMgc3RydWN0IHBhZ2VfaW5mbyAqaGFw
X2FsbG9jKHN0cnVjCiAKICAgICBBU1NFUlQocGFnaW5nX2xvY2tlZF9ieV9t
ZShkKSk7CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgIHJldHVybiBOVUxMOworCiAgICAgcGcgPSBwYWdlX2xpc3RfcmVt
b3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLmhhcC5mcmVlbGlzdCk7CiAgICAg
aWYgKCB1bmxpa2VseSghcGcpICkKICAgICAgICAgcmV0dXJuIE5VTEw7CkBA
IC0yODEsNyArMjg0LDcgQEAgc3RhdGljIHN0cnVjdCBwYWdlX2luZm8gKmhh
cF9hbGxvY19wMm1fcAogICAgICAgICBkLT5hcmNoLnBhZ2luZy5oYXAucDJt
X3BhZ2VzKys7CiAgICAgICAgIEFTU0VSVCghcGFnZV9nZXRfb3duZXIocGcp
ICYmICEocGctPmNvdW50X2luZm8gJiBQR0NfY291bnRfbWFzaykpOwogICAg
IH0KLSAgICBlbHNlIGlmICggIWQtPmFyY2gucGFnaW5nLnAybV9hbGxvY19m
YWlsZWQgKQorICAgIGVsc2UgaWYgKCAhZC0+YXJjaC5wYWdpbmcucDJtX2Fs
bG9jX2ZhaWxlZCAmJiAhZC0+aXNfZHlpbmcgKQogICAgIHsKICAgICAgICAg
ZC0+YXJjaC5wYWdpbmcucDJtX2FsbG9jX2ZhaWxlZCA9IDE7CiAgICAgICAg
IGRwcmludGsoWEVOTE9HX0VSUiwgImQlaSBmYWlsZWQgdG8gYWxsb2NhdGUg
ZnJvbSBIQVAgcG9vbFxuIiwKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRv
dy9jb21tb24uYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1v
bi5jCkBAIC05MzksNiArOTM5LDEwIEBAIHN0YXRpYyBib29sIF9fbXVzdF9j
aGVjayBfc2hhZG93X3ByZWFsbG8KICAgICBpZiAoIGQtPmFyY2gucGFnaW5n
LnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2VzICkKICAgICAgICAgcmV0dXJu
IHRydWU7CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgIC8qIE5vIHJlY2xhaW0gd2hlbiB0aGUgZG9tYWluIGlzIGR5aW5n
LCB0ZWFyZG93biB3aWxsIHRha2UgY2FyZSBvZiBpdC4gKi8KKyAgICAgICAg
cmV0dXJuIGZhbHNlOworCiAgICAgLyogU2hvdWxkbid0IGhhdmUgZW5hYmxl
ZCBzaGFkb3dzIGlmIHdlJ3ZlIG5vIHZjcHVzLiAqLwogICAgIEFTU0VSVChk
LT52Y3B1ICYmIGQtPnZjcHVbMF0pOwogCkBAIC05OTEsNyArOTk1LDcgQEAg
c3RhdGljIGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsbwogICAg
ICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcywKICAg
ICAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcyk7CiAK
LSAgICBBU1NFUlQoZC0+aXNfZHlpbmcpOworICAgIEFTU0VSVF9VTlJFQUNI
QUJMRSgpOwogCiAgICAgZ3Vlc3RfZmx1c2hfdGxiX21hc2soZCwgZC0+ZGly
dHlfY3B1bWFzayk7CiAKQEAgLTEwMDUsMTAgKzEwMDksMTMgQEAgc3RhdGlj
IGJvb2wgX19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsbwogICogdG8gYXZv
aWQgZnJlZWluZyBzaGFkb3dzIHRoYXQgdGhlIGNhbGxlciBpcyBjdXJyZW50
bHkgd29ya2luZyBvbi4gKi8KIGJvb2wgc2hhZG93X3ByZWFsbG9jKHN0cnVj
dCBkb21haW4gKmQsIHVuc2lnbmVkIGludCB0eXBlLCB1bnNpZ25lZCBpbnQg
Y291bnQpCiB7Ci0gICAgYm9vbCByZXQgPSBfc2hhZG93X3ByZWFsbG9jKGQs
IHNoYWRvd19zaXplKHR5cGUpICogY291bnQpOworICAgIGJvb2wgcmV0Owor
CisgICAgaWYgKCB1bmxpa2VseShkLT5pc19keWluZykgKQorICAgICAgIHJl
dHVybiBmYWxzZTsKIAotICAgIGlmICggIXJldCAmJiAhZC0+aXNfZHlpbmcg
JiYKLSAgICAgICAgICghZC0+aXNfc2h1dHRpbmdfZG93biB8fCBkLT5zaHV0
ZG93bl9jb2RlICE9IFNIVVRET1dOX2NyYXNoKSApCisgICAgcmV0ID0gX3No
YWRvd19wcmVhbGxvYyhkLCBzaGFkb3dfc2l6ZSh0eXBlKSAqIGNvdW50KTsK
KyAgICBpZiAoICFyZXQgJiYgKCFkLT5pc19zaHV0dGluZ19kb3duIHx8IGQt
PnNodXRkb3duX2NvZGUgIT0gU0hVVERPV05fY3Jhc2gpICkKICAgICAgICAg
LyoKICAgICAgICAgICogRmFpbGluZyB0byBhbGxvY2F0ZSBtZW1vcnkgcmVx
dWlyZWQgZm9yIHNoYWRvdyB1c2FnZSBjYW4gb25seSByZXN1bHQgaW4KICAg
ICAgICAgICogYSBkb21haW4gY3Jhc2gsIGRvIGl0IGhlcmUgcmF0aGVyIHRo
YXQgcmVseWluZyBvbiBldmVyeSBjYWxsZXIgdG8gZG8gaXQuCkBAIC0xMjM4
LDYgKzEyNDUsOSBAQCBzaGFkb3dfYWxsb2NfcDJtX3BhZ2Uoc3RydWN0IGRv
bWFpbiAqZCkKIHsKICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZyA9IE5VTEw7
CiAKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisgICAgICAg
cmV0dXJuIE5VTEw7CisKICAgICAvKiBUaGlzIGlzIGNhbGxlZCBib3RoIGZy
b20gdGhlIHAybSBjb2RlICh3aGljaCBuZXZlciBob2xkcyB0aGUKICAgICAg
KiBwYWdpbmcgbG9jaykgYW5kIHRoZSBsb2ctZGlydHkgY29kZSAod2hpY2gg
YWx3YXlzIGRvZXMpLiAqLwogICAgIHBhZ2luZ19sb2NrX3JlY3Vyc2l2ZShk
KTsK

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-08.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHRydWx5IGZyZWUgcGFnaW5nIHBvb2wgbWVt
b3J5IGZvciBkeWluZyBkb21haW5zCgpNb2RpZnkge2hhcCxzaGFkb3d9X2Zy
ZWUgdG8gZnJlZSB0aGUgcGFnZSBpbW1lZGlhdGVseSBpZiB0aGUgZG9tYWlu
IGlzCmR5aW5nLCBzbyB0aGF0IHBhZ2VzIGRvbid0IGFjY3VtdWxhdGUgaW4g
dGhlIHBvb2wgd2hlbgp7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRvd24oKSBn
ZXQgY2FsbGVkLiBUaGlzIGlzIHRvIGxpbWl0IHRoZSBhbW91bnQgb2YKd29y
ayB3aGljaCBuZWVkcyB0byBiZSBkb25lIHRoZXJlIChpbiBhIG5vbi1wcmVl
bXB0YWJsZSBtYW5uZXIpLgoKTm90ZSB0aGUgY2FsbCB0byBzaGFkb3dfZnJl
ZSgpIGluIHNoYWRvd19mcmVlX3AybV9wYWdlKCkgaXMgbW92ZWQgYWZ0ZXIK
aW5jcmVhc2luZyB0b3RhbF9wYWdlcywgc28gdGhhdCB0aGUgZGVjcmVhc2Ug
ZG9uZSBpbiBzaGFkb3dfZnJlZSgpIGluCmNhc2UgdGhlIGRvbWFpbiBpcyBk
eWluZyBkb2Vzbid0IHVuZGVyZmxvdyB0aGUgY291bnRlciwgZXZlbiBpZiBq
dXN0IGZvcgphIHNob3J0IGludGVydmFsLgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2Vy
IFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5
OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KCi0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hhcC9oYXAu
YwpAQCAtMjY1LDYgKzI2NSwxOCBAQCBzdGF0aWMgdm9pZCBoYXBfZnJlZShz
dHJ1Y3QgZG9tYWluICpkLCBtCiAKICAgICBBU1NFUlQocGFnaW5nX2xvY2tl
ZF9ieV9tZShkKSk7CiAKKyAgICAvKgorICAgICAqIEZvciBkeWluZyBkb21h
aW5zLCBhY3R1YWxseSBmcmVlIHRoZSBtZW1vcnkgaGVyZS4gVGhpcyB3YXkg
bGVzcyB3b3JrIGlzCisgICAgICogbGVmdCB0byBoYXBfZmluYWxfdGVhcmRv
d24oKSwgd2hpY2ggY2Fubm90IGVhc2lseSBoYXZlIHByZWVtcHRpb24gY2hl
Y2tzCisgICAgICogYWRkZWQuCisgICAgICovCisgICAgaWYgKCB1bmxpa2Vs
eShkLT5pc19keWluZykgKQorICAgIHsKKyAgICAgICAgZnJlZV9kb21oZWFw
X3BhZ2UocGcpOworICAgICAgICBkLT5hcmNoLnBhZ2luZy5oYXAudG90YWxf
cGFnZXMtLTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGQtPmFy
Y2gucGFnaW5nLmhhcC5mcmVlX3BhZ2VzKys7CiAgICAgcGFnZV9saXN0X2Fk
ZF90YWlsKHBnLCAmZC0+YXJjaC5wYWdpbmcuaGFwLmZyZWVsaXN0KTsKIH0K
LS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24uYworKysgYi94
ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0xMTg3LDYgKzEx
ODcsNyBAQCBtZm5fdCBzaGFkb3dfYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwK
IHZvaWQgc2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3Qgc21m
bikKIHsKICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpuZXh0ID0gTlVMTCwgKnNw
ID0gbWZuX3RvX3BhZ2Uoc21mbik7CisgICAgYm9vbCBkeWluZyA9IEFDQ0VT
U19PTkNFKGQtPmlzX2R5aW5nKTsKICAgICBzdHJ1Y3QgcGFnZV9saXN0X2hl
YWQgKnBpbl9saXN0OwogICAgIHVuc2lnbmVkIGludCBwYWdlczsKICAgICB1
MzIgc2hhZG93X3R5cGU7CkBAIC0xMjI5LDExICsxMjMwLDMyIEBAIHZvaWQg
c2hhZG93X2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3QKICAgICAgICAg
ICoganVzdCBiZWZvcmUgdGhlIGFsbG9jYXRvciBoYW5kcyB0aGUgcGFnZSBv
dXQgYWdhaW4uICovCiAgICAgICAgIHBhZ2Vfc2V0X3RsYmZsdXNoX3RpbWVz
dGFtcChzcCk7CiAgICAgICAgIHBlcmZjX2RlY3Ioc2hhZG93X2FsbG9jX2Nv
dW50KTsKLSAgICAgICAgcGFnZV9saXN0X2FkZF90YWlsKHNwLCAmZC0+YXJj
aC5wYWdpbmcuc2hhZG93LmZyZWVsaXN0KTsKKworICAgICAgICAvKgorICAg
ICAgICAgKiBGb3IgZHlpbmcgZG9tYWlucywgYWN0dWFsbHkgZnJlZSB0aGUg
bWVtb3J5IGhlcmUuIFRoaXMgd2F5IGxlc3MKKyAgICAgICAgICogd29yayBp
cyBsZWZ0IHRvIHNoYWRvd19maW5hbF90ZWFyZG93bigpLCB3aGljaCBjYW5u
b3QgZWFzaWx5IGhhdmUKKyAgICAgICAgICogcHJlZW1wdGlvbiBjaGVja3Mg
YWRkZWQuCisgICAgICAgICAqLworICAgICAgICBpZiAoIHVubGlrZWx5KGR5
aW5nKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIC8qCisgICAgICAgICAg
ICAgKiBUaGUgYmFja3BvaW50ZXIgZmllbGQgKHNoLmJhY2spIHVzZWQgYnkg
c2hhZG93IGNvZGUgYWxpYXNlcyB0aGUKKyAgICAgICAgICAgICAqIGRvbWFp
biBvd25lciBmaWVsZCwgdW5jb25kaXRpb25hbGx5IGNsZWFyIGl0IGhlcmUg
dG8gYXZvaWQKKyAgICAgICAgICAgICAqIGZyZWVfZG9taGVhcF9wYWdlKCkg
YXR0ZW1wdGluZyB0byBwYXJzZSBpdC4KKyAgICAgICAgICAgICAqLworICAg
ICAgICAgICAgcGFnZV9zZXRfb3duZXIoc3AsIE5VTEwpOworICAgICAgICAg
ICAgZnJlZV9kb21oZWFwX3BhZ2Uoc3ApOworICAgICAgICB9CisgICAgICAg
IGVsc2UKKyAgICAgICAgICAgIHBhZ2VfbGlzdF9hZGRfdGFpbChzcCwgJmQt
PmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlbGlzdCk7CisKICAgICAgICAgc3Ag
PSBuZXh0OwogICAgIH0KIAotICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5m
cmVlX3BhZ2VzICs9IHBhZ2VzOworICAgIGlmICggdW5saWtlbHkoZHlpbmcp
ICkKKyAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LnRvdGFsX3BhZ2Vz
IC09IHBhZ2VzOworICAgIGVsc2UKKyAgICAgICAgZC0+YXJjaC5wYWdpbmcu
c2hhZG93LmZyZWVfcGFnZXMgKz0gcGFnZXM7CiB9CiAKIC8qIERpdmVydCBh
IHBhZ2UgZnJvbSB0aGUgcG9vbCB0byBiZSB1c2VkIGJ5IHRoZSBwMm0gbWFw
cGluZy4KQEAgLTEzMDMsOSArMTMyNSw5IEBAIHNoYWRvd19mcmVlX3AybV9w
YWdlKHN0cnVjdCBkb21haW4gKmQsIHMKICAgICAgKiBwYWdpbmcgbG9jaykg
YW5kIHRoZSBsb2ctZGlydHkgY29kZSAod2hpY2ggYWx3YXlzIGRvZXMpLiAq
LwogICAgIHBhZ2luZ19sb2NrX3JlY3Vyc2l2ZShkKTsKIAotICAgIHNoYWRv
d19mcmVlKGQsIHBhZ2VfdG9fbWZuKHBnKSk7CiAgICAgZC0+YXJjaC5wYWdp
bmcuc2hhZG93LnAybV9wYWdlcy0tOwogICAgIGQtPmFyY2gucGFnaW5nLnNo
YWRvdy50b3RhbF9wYWdlcysrOworICAgIHNoYWRvd19mcmVlKGQsIHBhZ2Vf
dG9fbWZuKHBnKSk7CiAKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-09.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGZyZWUgdGhlIHBhZ2luZyBtZW1vcnkgcG9v
bCBwcmVlbXB0aXZlbHkKClRoZSBwYWdpbmcgbWVtb3J5IHBvb2wgaXMgY3Vy
cmVudGx5IGZyZWVkIGluIHR3byBkaWZmZXJlbnQgcGxhY2VzOgpmcm9tIHtz
aGFkb3csaGFwfV90ZWFyZG93bigpIHZpYSBkb21haW5fcmVsaW5xdWlzaF9y
ZXNvdXJjZXMoKSBhbmQKZnJvbSB7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRv
d24oKSB2aWEgY29tcGxldGVfZG9tYWluX2Rlc3Ryb3koKS4KV2hpbGUgdGhl
IGZvcm1lciBkb2VzIGhhbmRsZSBwcmVlbXB0aW9uLCB0aGUgbGF0ZXIgZG9l
c24ndC4KCkF0dGVtcHQgdG8gbW92ZSBhcyBtdWNoIHAybSByZWxhdGVkIGZy
ZWVpbmcgYXMgcG9zc2libGUgdG8gaGFwcGVuCmJlZm9yZSB0aGUgY2FsbCB0
byB7c2hhZG93LGhhcH1fdGVhcmRvd24oKSwgc28gdGhhdCBtb3N0IG1lbW9y
eSBjYW4gYmUKZnJlZWQgaW4gYSBwcmVlbXB0aXZlIHdheS4gIEluIG9yZGVy
IHRvIGF2b2lkIGNhdXNpbmcgaXNzdWVzIHRvCmV4aXN0aW5nIGNhbGxlcnMg
bGVhdmUgdGhlIHJvb3QgcDJtIHBhZ2UgdGFibGVzIHNldCBhbmQgZnJlZSB0
aGVtIGluCntoYXAsc2hhZG93fV9maW5hbF90ZWFyZG93bigpLiAgQWxzbyBt
b2RpZnkge2hhcCxzaGFkb3d9X2ZyZWUgdG8gZnJlZQp0aGUgcGFnZSBpbW1l
ZGlhdGVseSBpZiB0aGUgZG9tYWluIGlzIGR5aW5nLCBzbyB0aGF0IHBhZ2Vz
IGRvbid0CmFjY3VtdWxhdGUgaW4gdGhlIHBvb2wgd2hlbiB7c2hhZG93LGhh
cH1fZmluYWxfdGVhcmRvd24oKSBnZXQgY2FsbGVkLgoKTW92ZSBhbHRwMm1f
dmNwdV9kaXNhYmxlX3ZlKCkgdG8gYmUgZG9uZSBpbiBoYXBfdGVhcmRvd24o
KSwgYXMgdGhhdCdzCnRoZSBwbGFjZSB3aGVyZSBhbHRwMm1fYWN0aXZlIGdl
dHMgZGlzYWJsZWQgbm93LgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0yMDIyLTMz
NzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVl
Z2FuIDx0aW1AeGVuLm9yZz4KCi0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4u
YworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTM4LDcgKzM4LDYg
QEAKICNpbmNsdWRlIDx4ZW4vbGl2ZXBhdGNoLmg+CiAjaW5jbHVkZSA8cHVi
bGljL3N5c2N0bC5oPgogI2luY2x1ZGUgPHB1YmxpYy9odm0vaHZtX3ZjcHUu
aD4KLSNpbmNsdWRlIDxhc20vYWx0cDJtLmg+CiAjaW5jbHVkZSA8YXNtL3Jl
Z3MuaD4KICNpbmNsdWRlIDxhc20vbWMxNDY4MThydGMuaD4KICNpbmNsdWRl
IDxhc20vc3lzdGVtLmg+CkBAIC0yMzgxLDEyICsyMzgwLDYgQEAgaW50IGRv
bWFpbl9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1Y3QgZAogICAgICAgICAg
ICAgdnBtdV9kZXN0cm95KHYpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYg
KCBhbHRwMm1fYWN0aXZlKGQpICkKLSAgICAgICAgewotICAgICAgICAgICAg
Zm9yX2VhY2hfdmNwdSAoIGQsIHYgKQotICAgICAgICAgICAgICAgIGFsdHAy
bV92Y3B1X2Rpc2FibGVfdmUodik7Ci0gICAgICAgIH0KLQogICAgICAgICBp
ZiAoIGlzX3B2X2RvbWFpbihkKSApCiAgICAgICAgIHsKICAgICAgICAgICAg
IGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKLS0tIGEveGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCkBA
IC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSA8eGVuL2RvbWFpbl9wYWdlLmg+
CiAjaW5jbHVkZSA8eGVuL2d1ZXN0X2FjY2Vzcy5oPgogI2luY2x1ZGUgPHhl
bi9rZXloYW5kbGVyLmg+CisjaW5jbHVkZSA8YXNtL2FsdHAybS5oPgogI2lu
Y2x1ZGUgPGFzbS9ldmVudC5oPgogI2luY2x1ZGUgPGFzbS9wYWdlLmg+CiAj
aW5jbHVkZSA8YXNtL2N1cnJlbnQuaD4KQEAgLTU0NiwyNCArNTQ3LDggQEAg
dm9pZCBoYXBfZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZAogICAg
IHVuc2lnbmVkIGludCBpOwogCiAgICAgaWYgKCBodm1fYWx0cDJtX3N1cHBv
cnRlZCgpICkKLSAgICB7Ci0gICAgICAgIGQtPmFyY2guYWx0cDJtX2FjdGl2
ZSA9IDA7Ci0KLSAgICAgICAgaWYgKCBkLT5hcmNoLmFsdHAybV9lcHRwICkK
LSAgICAgICAgewotICAgICAgICAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+
YXJjaC5hbHRwMm1fZXB0cCk7Ci0gICAgICAgICAgICBkLT5hcmNoLmFsdHAy
bV9lcHRwID0gTlVMTDsKLSAgICAgICAgfQotCi0gICAgICAgIGlmICggZC0+
YXJjaC5hbHRwMm1fdmlzaWJsZV9lcHRwICkKLSAgICAgICAgewotICAgICAg
ICAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZC0+YXJjaC5hbHRwMm1fdmlzaWJs
ZV9lcHRwKTsKLSAgICAgICAgICAgIGQtPmFyY2guYWx0cDJtX3Zpc2libGVf
ZXB0cCA9IE5VTEw7Ci0gICAgICAgIH0KLQogICAgICAgICBmb3IgKCBpID0g
MDsgaSA8IE1BWF9BTFRQMk07IGkrKyApCiAgICAgICAgICAgICBwMm1fdGVh
cmRvd24oZC0+YXJjaC5hbHRwMm1fcDJtW2ldLCB0cnVlKTsKLSAgICB9CiAK
ICAgICAvKiBEZXN0cm95IG5lc3RlZHAybSdzIGZpcnN0ICovCiAgICAgZm9y
IChpID0gMDsgaSA8IE1BWF9ORVNURURQMk07IGkrKykgewpAQCAtNTc4LDYg
KzU2Myw4IEBAIHZvaWQgaGFwX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21h
aW4gKmQKICAgICBwYWdpbmdfbG9jayhkKTsKICAgICBoYXBfc2V0X2FsbG9j
YXRpb24oZCwgMCwgTlVMTCk7CiAgICAgQVNTRVJUKGQtPmFyY2gucGFnaW5n
LmhhcC5wMm1fcGFnZXMgPT0gMCk7CisgICAgQVNTRVJUKGQtPmFyY2gucGFn
aW5nLmhhcC5mcmVlX3BhZ2VzID09IDApOworICAgIEFTU0VSVChkLT5hcmNo
LnBhZ2luZy5oYXAudG90YWxfcGFnZXMgPT0gMCk7CiAgICAgcGFnaW5nX3Vu
bG9jayhkKTsKIH0KIApAQCAtNjAzLDYgKzU5MCw3IEBAIHZvaWQgaGFwX3Zj
cHVfdGVhcmRvd24oc3RydWN0IHZjcHUgKnYpCiB2b2lkIGhhcF90ZWFyZG93
bihzdHJ1Y3QgZG9tYWluICpkLCBib29sICpwcmVlbXB0ZWQpCiB7CiAgICAg
c3RydWN0IHZjcHUgKnY7CisgICAgdW5zaWduZWQgaW50IGk7CiAKICAgICBB
U1NFUlQoZC0+aXNfZHlpbmcpOwogICAgIEFTU0VSVChkICE9IGN1cnJlbnQt
PmRvbWFpbik7CkBAIC02MTEsNiArNTk5LDI4IEBAIHZvaWQgaGFwX3RlYXJk
b3duKHN0cnVjdCBkb21haW4gKmQsIGJvb2wKICAgICBmb3JfZWFjaF92Y3B1
ICggZCwgdiApCiAgICAgICAgIGhhcF92Y3B1X3RlYXJkb3duKHYpOwogCisg
ICAgLyogTGVhdmUgdGhlIHJvb3QgcHQgaW4gY2FzZSB3ZSBnZXQgZnVydGhl
ciBhdHRlbXB0cyB0byBtb2RpZnkgdGhlIHAybS4gKi8KKyAgICBpZiAoIGh2
bV9hbHRwMm1fc3VwcG9ydGVkKCkgKQorICAgIHsKKyAgICAgICAgaWYgKCBh
bHRwMm1fYWN0aXZlKGQpICkKKyAgICAgICAgICAgIGZvcl9lYWNoX3ZjcHUg
KCBkLCB2ICkKKyAgICAgICAgICAgICAgICBhbHRwMm1fdmNwdV9kaXNhYmxl
X3ZlKHYpOworCisgICAgICAgIGQtPmFyY2guYWx0cDJtX2FjdGl2ZSA9IDA7
CisKKyAgICAgICAgRlJFRV9YRU5IRUFQX1BBR0UoZC0+YXJjaC5hbHRwMm1f
ZXB0cCk7CisgICAgICAgIEZSRUVfWEVOSEVBUF9QQUdFKGQtPmFyY2guYWx0
cDJtX3Zpc2libGVfZXB0cCk7CisKKyAgICAgICAgZm9yICggaSA9IDA7IGkg
PCBNQVhfQUxUUDJNOyBpKysgKQorICAgICAgICAgICAgcDJtX3RlYXJkb3du
KGQtPmFyY2guYWx0cDJtX3AybVtpXSwgZmFsc2UpOworICAgIH0KKworICAg
IC8qIERlc3Ryb3kgbmVzdGVkcDJtJ3MgYWZ0ZXIgYWx0cDJtLiAqLworICAg
IGZvciAoIGkgPSAwOyBpIDwgTUFYX05FU1RFRFAyTTsgaSsrICkKKyAgICAg
ICAgcDJtX3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtpXSwgZmFsc2Up
OworCisgICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9zdHAybShkKSwgZmFs
c2UpOworCiAgICAgcGFnaW5nX2xvY2soZCk7IC8qIEtlZXAgdmFyaW91cyBh
c3NlcnRzIGhhcHB5ICovCiAKICAgICBpZiAoIGQtPmFyY2gucGFnaW5nLmhh
cC50b3RhbF9wYWdlcyAhPSAwICkKLS0tIGEveGVuL2FyY2gveDg2L21tL3No
YWRvdy9jb21tb24uYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2Nv
bW1vbi5jCkBAIC0yODI0LDggKzI4MjQsMTcgQEAgdm9pZCBzaGFkb3dfdGVh
cmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYgogICAgIGZvcl9lYWNoX3ZjcHUg
KCBkLCB2ICkKICAgICAgICAgc2hhZG93X3ZjcHVfdGVhcmRvd24odik7CiAK
KyAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCBmYWxzZSk7
CisKICAgICBwYWdpbmdfbG9jayhkKTsKIAorICAgIC8qCisgICAgICogUmVj
bGFpbSBhbGwgc2hhZG93IG1lbW9yeSBzbyB0aGF0IHNoYWRvd19zZXRfYWxs
b2NhdGlvbigpIGRvZXNuJ3QgZmluZAorICAgICAqIGluLXVzZSBwYWdlcywg
YXMgX3NoYWRvd19wcmVhbGxvYygpIHdpbGwgbm8gbG9uZ2VyIHRyeSB0byBy
ZWNsYWltIHBhZ2VzCisgICAgICogYmVjYXVzZSB0aGUgZG9tYWluIGlzIGR5
aW5nLgorICAgICAqLworICAgIHNoYWRvd19ibG93X3RhYmxlcyhkKTsKKwog
I2lmIChTSEFET1dfT1BUSU1JWkFUSU9OUyAmIChTSE9QVF9WSVJUVUFMX1RM
QnxTSE9QVF9PVVRfT0ZfU1lOQykpCiAgICAgLyogRnJlZSB0aGUgdmlydHVh
bC1UTEIgYXJyYXkgYXR0YWNoZWQgdG8gZWFjaCB2Y3B1ICovCiAgICAgZm9y
X2VhY2hfdmNwdShkLCB2KQpAQCAtMjk0Niw2ICsyOTU1LDkgQEAgdm9pZCBz
aGFkb3dfZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbgogICAgICAgICAg
ICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9wYWdlcywK
ICAgICAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJl
ZV9wYWdlcywKICAgICAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5z
aGFkb3cucDJtX3BhZ2VzKTsKKyAgICBBU1NFUlQoIWQtPmFyY2gucGFnaW5n
LnNoYWRvdy50b3RhbF9wYWdlcyk7CisgICAgQVNTRVJUKCFkLT5hcmNoLnBh
Z2luZy5zaGFkb3cuZnJlZV9wYWdlcyk7CisgICAgQVNTRVJUKCFkLT5hcmNo
LnBhZ2luZy5zaGFkb3cucDJtX3BhZ2VzKTsKICAgICBwYWdpbmdfdW5sb2Nr
KGQpOwogfQogCg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-4.16-10.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-4.16-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj
dDogeGVuL3g4NjogcDJtOiBBZGQgcHJlZW1wdGlvbiBpbiBwMm1fdGVhcmRv
d24oKQoKVGhlIGxpc3QgcDJtLT5wYWdlcyBjb250YWluIGFsbCB0aGUgcGFn
ZXMgdXNlZCBieSB0aGUgUDJNLiBPbiBsYXJnZQppbnN0YW5jZSB0aGlzIGNh
biBiZSBxdWl0ZSBsYXJnZSBhbmQgdGhlIHRpbWUgc3BlbnQgdG8gY2FsbApk
LT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoKSB3aWxsIHRha2UgbW9yZSB0aGFu
IDFtcyBmb3IgYSA4MEdCIGd1ZXN0Cm9uIGEgWGVuIHJ1bm5pbmcgaW4gbmVz
dGVkIGVudmlyb25tZW50IG9uIGEgYzUubWV0YWwuCgpCeSBleHRyYXBvbGF0
aW9uLCBpdCB3b3VsZCB0YWtlID4gMTAwbXMgZm9yIGEgOFRCIGd1ZXN0ICh3
aGF0IHdlCmN1cnJlbnQgc2VjdXJpdHkgc3VwcG9ydCkuIFNvIGFkZCBzb21l
IHByZWVtcHRpb24gaW4gcDJtX3RlYXJkb3duKCkKYW5kIHByb3BhZ2F0ZSB0
byB0aGUgY2FsbGVycy4gTm90ZSB0aGVyZSBhcmUgMyBwbGFjZXMgd2hlcmUK
dGhlIHByZWVtcHRpb24gaXMgbm90IGVuYWJsZWQ6CiAgICAtIGhhcF9maW5h
bF90ZWFyZG93bigpL3NoYWRvd19maW5hbF90ZWFyZG93bigpOiBXZSBhcmUK
ICAgICAgcHJldmVudGluZyB1cGRhdGUgdGhlIFAyTSBvbmNlIHRoZSBkb21h
aW4gaXMgZHlpbmcgKHNvCiAgICAgIG5vIG1vcmUgcGFnZXMgY291bGQgYmUg
YWxsb2NhdGVkKSBhbmQgbW9zdCBvZiB0aGUgUDJNIHBhZ2VzCiAgICAgIHdp
bGwgYmUgZnJlZWQgaW4gcHJlZW1wdGl2ZSBtYW5uZWVyIHdoZW4gcmVsaW5x
dWlzaGluZyB0aGUKICAgICAgcmVzb3VyY2VzLiBTbyB0aGlzIGlzIGZpbmUg
dG8gZGlzYWJsZSBwcmVlbXB0aW9uLgogICAgLSBzaGFkb3dfZW5hYmxlKCk6
IFRoaXMgaXMgZmluZSBiZWNhdXNlIGl0IHdpbGwgdW5kbyB0aGUgYWxsb2Nh
dGlvbgogICAgICB0aGF0IG1heSBoYXZlIGJlZW4gbWFkZSBieSBwMm1fYWxs
b2NfdGFibGUoKSAoc28gb25seSB0aGUgcm9vdAogICAgICBwYWdlIHRhYmxl
KS4KClRoZSBwcmVlbXB0aW9uIGlzIGFyYml0cmFyaWx5IGNoZWNrZWQgZXZl
cnkgMTAyNCBpdGVyYXRpb25zLgoKTm90ZSB0aGF0IHdpdGggdGhlIGN1cnJl
bnQgYXBwcm9hY2gsIFhlbiBkb2Vzbid0IGtlZXAgdHJhY2sgb24gd2hldGhl
cgp0aGUgYWx0L25lc3RlZCBQMk1zIGhhdmUgYmVlbiBjbGVhcmVkLiBTbyB0
aGVyZSBhcmUgc29tZSByZWR1bmRhbnQgd29yay4KSG93ZXZlciwgdGhpcyBp
cyBub3QgZXhwZWN0ZWQgdG8gaW5jdXJyIHRvbyBtdWNoIG92ZXJoZWFkICh0
aGUgUDJNIGxvY2sKc2hvdWxkbid0IGJlIGNvbnRlbmRlZCBkdXJpbmcgdGVh
cmRvd24pLiBTbyB0aGlzIGlzIG9wdGltaXphdGlvbiBpcwpsZWZ0IG91dHNp
ZGUgb2YgdGhlIHNlY3VyaXR5IGV2ZW50LgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEph
biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCi0tLSBhL3hlbi9pbmNs
dWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9w
Mm0uaApAQCAtNTc0LDcgKzU3NCw3IEBAIGludCBwMm1faW5pdChzdHJ1Y3Qg
ZG9tYWluICpkKTsKIGludCBwMm1fYWxsb2NfdGFibGUoc3RydWN0IHAybV9k
b21haW4gKnAybSk7CiAKIC8qIFJldHVybiBhbGwgdGhlIHAybSByZXNvdXJj
ZXMgdG8gWGVuLiAqLwotdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9k
b21haW4gKnAybSwgYm9vbCByZW1vdmVfcm9vdCk7Cit2b2lkIHAybV90ZWFy
ZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBib29sIHJlbW92ZV9yb290
LCBib29sICpwcmVlbXB0ZWQpOwogdm9pZCBwMm1fZmluYWxfdGVhcmRvd24o
c3RydWN0IGRvbWFpbiAqZCk7CiAKIC8qIEFkZCBhIHBhZ2UgdG8gYSBkb21h
aW4ncyBwMm0gdGFibGUgKi8KLS0tIGEveGVuL2FyY2gveDg2L21tL2hhcC9o
YXAuYworKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCkBAIC01NDgs
MTcgKzU0OCwxNyBAQCB2b2lkIGhhcF9maW5hbF90ZWFyZG93bihzdHJ1Y3Qg
ZG9tYWluICpkCiAKICAgICBpZiAoIGh2bV9hbHRwMm1fc3VwcG9ydGVkKCkg
KQogICAgICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9BTFRQMk07IGkrKyAp
Ci0gICAgICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJjaC5hbHRwMm1fcDJt
W2ldLCB0cnVlKTsKKyAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNo
LmFsdHAybV9wMm1baV0sIHRydWUsIE5VTEwpOwogCiAgICAgLyogRGVzdHJv
eSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAgIGZvciAoaSA9IDA7IGkgPCBN
QVhfTkVTVEVEUDJNOyBpKyspIHsKLSAgICAgICAgcDJtX3RlYXJkb3duKGQt
PmFyY2gubmVzdGVkX3AybVtpXSwgdHJ1ZSk7CisgICAgICAgIHAybV90ZWFy
ZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIHRydWUsIE5VTEwpOwogICAg
IH0KIAogICAgIGlmICggZC0+YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3BhZ2Vz
ICE9IDAgKQogICAgICAgICBoYXBfdGVhcmRvd24oZCwgTlVMTCk7CiAKLSAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlKTsKKyAg
ICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCB0cnVlLCBOVUxM
KTsKICAgICAvKiBGcmVlIGFueSBtZW1vcnkgdGhhdCB0aGUgcDJtIHRlYXJk
b3duIHJlbGVhc2VkICovCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFw
X3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOwpAQCAtNjEyLDE0ICs2MTIs
MjQgQEAgdm9pZCBoYXBfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYm9v
bAogICAgICAgICBGUkVFX1hFTkhFQVBfUEFHRShkLT5hcmNoLmFsdHAybV92
aXNpYmxlX2VwdHApOwogCiAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgTUFY
X0FMVFAyTTsgaSsrICkKLSAgICAgICAgICAgIHAybV90ZWFyZG93bihkLT5h
cmNoLmFsdHAybV9wMm1baV0sIGZhbHNlKTsKKyAgICAgICAgeworICAgICAg
ICAgICAgcDJtX3RlYXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgZmFs
c2UsIHByZWVtcHRlZCk7CisgICAgICAgICAgICBpZiAoIHByZWVtcHRlZCAm
JiAqcHJlZW1wdGVkICkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAg
ICAgIH0KICAgICB9CiAKICAgICAvKiBEZXN0cm95IG5lc3RlZHAybSdzIGFm
dGVyIGFsdHAybS4gKi8KICAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9ORVNU
RURQMk07IGkrKyApCi0gICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNoLm5l
c3RlZF9wMm1baV0sIGZhbHNlKTsKKyAgICB7CisgICAgICAgIHAybV90ZWFy
ZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIGZhbHNlLCBwcmVlbXB0ZWQp
OworICAgICAgICBpZiAoIHByZWVtcHRlZCAmJiAqcHJlZW1wdGVkICkKKyAg
ICAgICAgICAgIHJldHVybjsKKyAgICB9CiAKLSAgICBwMm1fdGVhcmRvd24o
cDJtX2dldF9ob3N0cDJtKGQpLCBmYWxzZSk7CisgICAgcDJtX3RlYXJkb3du
KHAybV9nZXRfaG9zdHAybShkKSwgZmFsc2UsIHByZWVtcHRlZCk7CisgICAg
aWYgKCBwcmVlbXB0ZWQgJiYgKnByZWVtcHRlZCApCisgICAgICAgIHJldHVy
bjsKIAogICAgIHBhZ2luZ19sb2NrKGQpOyAvKiBLZWVwIHZhcmlvdXMgYXNz
ZXJ0cyBoYXBweSAqLwogCi0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwor
KysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMKQEAgLTc0OSwxMiArNzQ5LDEz
IEBAIGludCBwMm1fYWxsb2NfdGFibGUoc3RydWN0IHAybV9kb21haW4gKnAK
ICAqIGh2bSBmaXhtZTogd2hlbiBhZGRpbmcgc3VwcG9ydCBmb3IgcHZoIG5v
bi1oYXJkd2FyZSBkb21haW5zLCB0aGlzIHBhdGggbXVzdAogICogY2xlYW51
cCBhbnkgZm9yZWlnbiBwMm0gdHlwZXMgKHJlbGVhc2UgcmVmY250cyBvbiB0
aGVtKS4KICAqLwotdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21h
aW4gKnAybSwgYm9vbCByZW1vdmVfcm9vdCkKK3ZvaWQgcDJtX3RlYXJkb3du
KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIGJvb2wgcmVtb3ZlX3Jvb3QsIGJv
b2wgKnByZWVtcHRlZCkKIC8qIFJldHVybiBhbGwgdGhlIHAybSBwYWdlcyB0
byBYZW4uCiAgKiBXZSBrbm93IHdlIGRvbid0IGhhdmUgYW55IGV4dHJhIG1h
cHBpbmdzIHRvIHRoZXNlIHBhZ2VzICovCiB7CiAgICAgc3RydWN0IHBhZ2Vf
aW5mbyAqcGcsICpyb290X3BnID0gTlVMTDsKICAgICBzdHJ1Y3QgZG9tYWlu
ICpkOworICAgIHVuc2lnbmVkIGludCBpID0gMDsKIAogICAgIGlmIChwMm0g
PT0gTlVMTCkKICAgICAgICAgcmV0dXJuOwpAQCAtNzczLDggKzc3NCwxOSBA
QCB2b2lkIHAybV90ZWFyZG93bihzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtCiAg
ICAgfQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCi0gICAgICAgIGlmICggcGcgIT0gcm9vdF9w
ZyApCi0gICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoZCwg
cGcpOworICAgIHsKKyAgICAgICAgaWYgKCBwZyA9PSByb290X3BnICkKKyAg
ICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIGQtPmFyY2gucGFnaW5n
LmZyZWVfcGFnZShkLCBwZyk7CisKKyAgICAgICAgLyogQXJiaXRyYXJpbHkg
Y2hlY2sgcHJlZW1wdGlvbiBldmVyeSAxMDI0IGl0ZXJhdGlvbnMgKi8KKyAg
ICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgISgrK2kgJSAxMDI0KSAmJiBnZW5l
cmFsX3ByZWVtcHRfY2hlY2soKSApCisgICAgICAgIHsKKyAgICAgICAgICAg
ICpwcmVlbXB0ZWQgPSB0cnVlOworICAgICAgICAgICAgYnJlYWs7CisgICAg
ICAgIH0KKyAgICB9CiAKICAgICBpZiAoIHJvb3RfcGcgKQogICAgICAgICBw
YWdlX2xpc3RfYWRkKHJvb3RfcGcsICZwMm0tPnBhZ2VzKTsKLS0tIGEveGVu
L2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24uYworKysgYi94ZW4vYXJjaC94
ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0yNzcwLDggKzI3NzAsMTIgQEAg
aW50IHNoYWRvd19lbmFibGUoc3RydWN0IGRvbWFpbiAqZCwgdTMyCiAgb3V0
X2xvY2tlZDoKICAgICBwYWdpbmdfdW5sb2NrKGQpOwogIG91dF91bmxvY2tl
ZDoKKyAgICAvKgorICAgICAqIFRoaXMgaXMgZmluZSB0byBpZ25vcmUgdGhl
IHByZWVtcHRpb24gaGVyZSBiZWNhdXNlIG9ubHkgdGhlIHJvb3QKKyAgICAg
KiB3aWxsIGJlIGFsbG9jYXRlZCBieSBwMm1fYWxsb2NfdGFibGUoKS4KKyAg
ICAgKi8KICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBhZ2V0YWJsZV9pc19udWxs
KHAybV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAgICAgICAgcDJtX3RlYXJk
b3duKHAybSwgdHJ1ZSk7CisgICAgICAgIHAybV90ZWFyZG93bihwMm0sIHRy
dWUsIE5VTEwpOwogICAgIGlmICggcnYgIT0gMCAmJiBwZyAhPSBOVUxMICkK
ICAgICB7CiAgICAgICAgIHBnLT5jb3VudF9pbmZvICY9IH5QR0NfY291bnRf
bWFzazsKQEAgLTI4MjQsNyArMjgyOCw5IEBAIHZvaWQgc2hhZG93X3RlYXJk
b3duKHN0cnVjdCBkb21haW4gKmQsIGIKICAgICBmb3JfZWFjaF92Y3B1ICgg
ZCwgdiApCiAgICAgICAgIHNoYWRvd192Y3B1X3RlYXJkb3duKHYpOwogCi0g
ICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9zdHAybShkKSwgZmFsc2UpOwor
ICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIGZhbHNlLCBw
cmVlbXB0ZWQpOworICAgIGlmICggcHJlZW1wdGVkICYmICpwcmVlbXB0ZWQg
KQorICAgICAgICByZXR1cm47CiAKICAgICBwYWdpbmdfbG9jayhkKTsKIApA
QCAtMjk0NSw3ICsyOTUxLDcgQEAgdm9pZCBzaGFkb3dfZmluYWxfdGVhcmRv
d24oc3RydWN0IGRvbWFpbgogICAgICAgICBzaGFkb3dfdGVhcmRvd24oZCwg
TlVMTCk7CiAKICAgICAvKiBJdCBpcyBub3cgc2FmZSB0byBwdWxsIGRvd24g
dGhlIHAybSBtYXAuICovCi0gICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9z
dHAybShkKSwgdHJ1ZSk7CisgICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9z
dHAybShkKSwgdHJ1ZSwgTlVMTCk7CiAgICAgLyogRnJlZSBhbnkgc2hhZG93
IG1lbW9yeSB0aGF0IHRoZSBwMm0gdGVhcmRvd24gcmVsZWFzZWQgKi8KICAg
ICBwYWdpbmdfbG9jayhkKTsKICAgICBzaGFkb3dfc2V0X2FsbG9jYXRpb24o
ZCwgMCwgTlVMTCk7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-04.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-04.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvSEFQOiBhZGp1c3QgbW9uaXRvciB0YWJsZSByZWxhdGVkIGVycm9y
IGhhbmRsaW5nCgpoYXBfbWFrZV9tb25pdG9yX3RhYmxlKCkgd2lsbCByZXR1
cm4gSU5WQUxJRF9NRk4gaWYgaXQgZW5jb3VudGVycyBhbgplcnJvciBjb25k
aXRpb24sIGJ1dCBoYXBfdXBkYXRlX3BhZ2luZ19tb2RlcygpIHdhc27igJl0
IGhhbmRsaW5nIHRoaXMKdmFsdWUsIHJlc3VsdGluZyBpbiBhbiBpbmFwcHJv
cHJpYXRlIHZhbHVlIGJlaW5nIHN0b3JlZCBpbgptb25pdG9yX3RhYmxlLiBU
aGlzIHdvdWxkIHN1YnNlcXVlbnRseSBtaXNndWlkZSBhdCBsZWFzdApoYXBf
dmNwdV90ZWFyZG93bigpLiBBdm9pZCB0aGlzIGJ5IGJhaWxpbmcgZWFybHku
CgpGdXJ0aGVyLCB3aGVuIGEgZG9tYWluIGhhcy93YXMgYWxyZWFkeSBjcmFz
aGVkIG9yIChwZXJoYXBzIGxlc3MKaW1wb3J0YW50IGFzIHRoZXJlJ3Mgbm8g
c3VjaCBwYXRoIGtub3duIHRvIGxlYWQgaGVyZSkgaXMgYWxyZWFkeSBkeWlu
ZywKYXZvaWQgY2FsbGluZyBkb21haW5fY3Jhc2goKSBvbiBpdCBhZ2FpbiAt
IHRoYXQncyBhdCBiZXN0IGNvbmZ1c2luZy4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBSb2dl
ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KLS0tCnYxMTog
QWxzbyBjaGVjayBmb3IgImNyYXNoZWQiIHN0YXR1cy4gUmUtd3JpdGUgLyBl
eHRlbmQgZGVzY3JpcHRpb24uCnYyOiBOZXcuCgotLS0gYS94ZW4vYXJjaC94
ODYvbW0vaGFwL2hhcC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvaGFw
LmMKQEAgLTM5LDYgKzM5LDcgQEAKICNpbmNsdWRlIDxhc20vZG9tYWluLmg+
CiAjaW5jbHVkZSA8eGVuL251bWEuaD4KICNpbmNsdWRlIDxhc20vaHZtL25l
c3RlZGh2bS5oPgorI2luY2x1ZGUgPHB1YmxpYy9zY2hlZC5oPgogCiAjaW5j
bHVkZSAicHJpdmF0ZS5oIgogCkBAIC00MDUsOCArNDA2LDEzIEBAIHN0YXRp
YyBtZm5fdCBoYXBfbWFrZV9tb25pdG9yX3RhYmxlKHN0cnUKICAgICByZXR1
cm4gbTRtZm47CiAKICBvb206Ci0gICAgcHJpbnRrKFhFTkxPR19HX0VSUiAi
b3V0IG9mIG1lbW9yeSBidWlsZGluZyBtb25pdG9yIHBhZ2V0YWJsZVxuIik7
Ci0gICAgZG9tYWluX2NyYXNoKGQpOworICAgIGlmICggIWQtPmlzX2R5aW5n
ICYmCisgICAgICAgICAoIWQtPmlzX3NodXR0aW5nX2Rvd24gfHwgZC0+c2h1
dGRvd25fY29kZSAhPSBTSFVURE9XTl9jcmFzaCkgKQorICAgIHsKKyAgICAg
ICAgcHJpbnRrKFhFTkxPR19HX0VSUiAiJXBkOiBvdXQgb2YgbWVtb3J5IGJ1
aWxkaW5nIG1vbml0b3IgcGFnZXRhYmxlXG4iLAorICAgICAgICAgICAgICAg
ZCk7CisgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKKyAgICB9CiAgICAgcmV0
dXJuIElOVkFMSURfTUZOOwogfQogCkBAIC03NjMsNiArNzY5LDkgQEAgc3Rh
dGljIHZvaWQgY2ZfY2hlY2sgaGFwX3VwZGF0ZV9wYWdpbmdfbQogICAgIGlm
ICggcGFnZXRhYmxlX2lzX251bGwodi0+YXJjaC5odm0ubW9uaXRvcl90YWJs
ZSkgKQogICAgIHsKICAgICAgICAgbWZuX3QgbW1mbiA9IGhhcF9tYWtlX21v
bml0b3JfdGFibGUodik7CisKKyAgICAgICAgaWYgKCBtZm5fZXEobW1mbiwg
SU5WQUxJRF9NRk4pICkKKyAgICAgICAgICAgIGdvdG8gdW5sb2NrOwogICAg
ICAgICB2LT5hcmNoLmh2bS5tb25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX2Zy
b21fbWZuKG1tZm4pOwogICAgICAgICBtYWtlX2NyMyh2LCBtbWZuKTsKICAg
ICAgICAgaHZtX3VwZGF0ZV9ob3N0X2NyMyh2KTsKQEAgLTc3MSw2ICs3ODAs
NyBAQCBzdGF0aWMgdm9pZCBjZl9jaGVjayBoYXBfdXBkYXRlX3BhZ2luZ19t
CiAgICAgLyogQ1IzIGlzIGVmZmVjdGl2ZWx5IHVwZGF0ZWQgYnkgYSBtb2Rl
IGNoYW5nZS4gRmx1c2ggQVNJRHMsIGV0Yy4gKi8KICAgICBoYXBfdXBkYXRl
X2NyMyh2LCAwLCBmYWxzZSk7CiAKKyB1bmxvY2s6CiAgICAgcGFnaW5nX3Vu
bG9jayhkKTsKICAgICBwdXRfZ2ZuKGQsIGNyM19nZm4pOwogfQo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-05.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-05.patch"
Content-Transfer-Encoding: base64

RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0
OiB4ODYvc2hhZG93OiB0b2xlcmF0ZSBmYWlsdXJlIG9mIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKQoKU3Vic2VxdWVudGx5IHNoX3NldF90b3BsZXZlbF9z
aGFkb3coKSB3aWxsIGJlIGFkanVzdGVkIHRvIGluc3RhbGwgYQpibGFuayBl
bnRyeSBpbiBjYXNlIHByZWFsbG9jIGZhaWxzLiBUaGVyZSBhcmUsIGluIGZh
Y3QsIHByZS1leGlzdGluZwplcnJvciBwYXRocyB3aGljaCB3b3VsZCBwdXQg
aW4gcGxhY2UgYSBibGFuayBlbnRyeS4gVGhlIDQtIGFuZCAyLWxldmVsCmNv
ZGUgaW4gc2hfdXBkYXRlX2NyMygpLCBob3dldmVyLCBhc3N1bWUgdGhlIHRv
cCBsZXZlbCBlbnRyeSB0byBiZQp2YWxpZC4KCkhlbmNlIGJhaWwgZnJvbSB0
aGUgZnVuY3Rpb24gaW4gdGhlIHVubGlrZWx5IGV2ZW50IHRoYXQgaXQncyBu
b3QuIE5vdGUKdGhhdCAzLWxldmVsIGxvZ2ljIHdvcmtzIGRpZmZlcmVudGx5
OiBJbiBwYXJ0aWN1bGFyIGEgZ3Vlc3QgaXMgZnJlZSB0bwpzdXBwbHkgYSBQ
RFBUUiBwb2ludGluZyBhdCA0IG5vbi1wcmVzZW50IChvciBvdGhlcndpc2Ug
ZGVlbWVkIGludmFsaWQpCmVudHJpZXMuIFRoZSBndWVzdCB3aWxsIGNyYXNo
LCBidXQgd2UgYWxyZWFkeSBjb3BlIHdpdGggdGhhdC4KClJlYWxseSBtZm5f
dmFsaWQoKSBpcyBsaWtlbHkgd3JvbmcgdG8gdXNlIGluIHNoX3NldF90b3Bs
ZXZlbF9zaGFkb3coKSwKYW5kIGl0IHNob3VsZCBpbnN0ZWFkIGJlICFtZm5f
ZXEoZ21mbiwgSU5WQUxJRF9NRk4pLiBBdm9pZCBzdWNoIGEgY2hhbmdlCmlu
IHNlY3VyaXR5IGNvbnRleHQsIGJ1dCBhZGQgYSByZXNwZWN0aXZlIGFzc2Vy
dGlvbi4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00
MTAuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KUmV2
aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20+Ci0tLQpDaGFuZ2VzIHNpbmNlIHYxMToKIC0gSnVzdGlmeSBBU1NF
UlQoKSBpbiBzaF9zZXRfdG9wbGV2ZWxfc2hhZG93KCkuCgpDaGFuZ2VzIHNp
bmNlIHY5OgogLSBBZGQgYXNzZXJ0aW9ucy4gQ29tbWl0IG1lc3NhZ2UgYWRq
dXN0bWVudHMuCgpDaGFuZ2VzIHNpbmNlIHY3OgogLSBOZXcgaW4gdGhpcyB2
ZXJzaW9uLgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24u
YworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBAIC0y
NTIxLDYgKzI1MjEsNyBAQCB2b2lkIHNoX3NldF90b3BsZXZlbF9zaGFkb3co
c3RydWN0IHZjcHUKICAgICAvKiBOb3cgZmlndXJlIG91dCB0aGUgbmV3IGNv
bnRlbnRzOiBpcyB0aGlzIGEgdmFsaWQgZ3Vlc3QgTUZOPyAqLwogICAgIGlm
ICggIW1mbl92YWxpZChnbWZuKSApCiAgICAgeworICAgICAgICBBU1NFUlQo
bWZuX2VxKGdtZm4sIElOVkFMSURfTUZOKSk7CiAgICAgICAgIG5ld19lbnRy
eSA9IHBhZ2V0YWJsZV9udWxsKCk7CiAgICAgICAgIGdvdG8gaW5zdGFsbF9u
ZXdfZW50cnk7CiAgICAgfQotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93
L211bHRpLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9tdWx0aS5j
CkBAIC0zMzE2LDYgKzMzMTYsMTEgQEAgc3RhdGljIHZvaWQgY2ZfY2hlY2sg
c2hfdXBkYXRlX2NyMyhzdHJ1YwogICAgIGlmICggc2hfcmVtb3ZlX3dyaXRl
X2FjY2VzcyhkLCBnbWZuLCA0LCAwKSAhPSAwICkKICAgICAgICAgZ3Vlc3Rf
Zmx1c2hfdGxiX21hc2soZCwgZC0+ZGlydHlfY3B1bWFzayk7CiAgICAgc2hf
c2V0X3RvcGxldmVsX3NoYWRvdyh2LCAwLCBnbWZuLCBTSF90eXBlX2w0X3No
YWRvdywgc2hfbWFrZV9zaGFkb3cpOworICAgIGlmICggdW5saWtlbHkocGFn
ZXRhYmxlX2lzX251bGwodi0+YXJjaC5wYWdpbmcuc2hhZG93LnNoYWRvd190
YWJsZVswXSkpICkKKyAgICB7CisgICAgICAgIEFTU0VSVChkLT5pc19keWlu
ZyB8fCBkLT5pc19zaHV0dGluZ19kb3duKTsKKyAgICAgICAgcmV0dXJuOwor
ICAgIH0KICAgICBpZiAoICFzaGFkb3dfbW9kZV9leHRlcm5hbChkKSAmJiAh
aXNfcHZfMzJiaXRfZG9tYWluKGQpICkKICAgICB7CiAgICAgICAgIG1mbl90
IHNtZm4gPSBwYWdldGFibGVfZ2V0X21mbih2LT5hcmNoLnBhZ2luZy5zaGFk
b3cuc2hhZG93X3RhYmxlWzBdKTsKQEAgLTMzNzIsNiArMzM3NywxMSBAQCBz
dGF0aWMgdm9pZCBjZl9jaGVjayBzaF91cGRhdGVfY3IzKHN0cnVjCiAgICAg
aWYgKCBzaF9yZW1vdmVfd3JpdGVfYWNjZXNzKGQsIGdtZm4sIDIsIDApICE9
IDAgKQogICAgICAgICBndWVzdF9mbHVzaF90bGJfbWFzayhkLCBkLT5kaXJ0
eV9jcHVtYXNrKTsKICAgICBzaF9zZXRfdG9wbGV2ZWxfc2hhZG93KHYsIDAs
IGdtZm4sIFNIX3R5cGVfbDJfc2hhZG93LCBzaF9tYWtlX3NoYWRvdyk7Cisg
ICAgaWYgKCB1bmxpa2VseShwYWdldGFibGVfaXNfbnVsbCh2LT5hcmNoLnBh
Z2luZy5zaGFkb3cuc2hhZG93X3RhYmxlWzBdKSkgKQorICAgIHsKKyAgICAg
ICAgQVNTRVJUKGQtPmlzX2R5aW5nIHx8IGQtPmlzX3NodXR0aW5nX2Rvd24p
OworICAgICAgICByZXR1cm47CisgICAgfQogI2Vsc2UKICNlcnJvciBUaGlz
IHNob3VsZCBuZXZlciBoYXBwZW4KICNlbmRpZgo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-06.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-06.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9zaGFkb3c6IHRvbGVyYXRlIGZhaWx1cmUgaW4gc2hh
ZG93X3ByZWFsbG9jKCkKClByZXZlbnQgX3NoYWRvd19wcmVhbGxvYygpIGZy
b20gY2FsbGluZyBCVUcoKSB3aGVuIHVuYWJsZSB0byBmdWxmaWxsCnRoZSBw
cmUtYWxsb2NhdGlvbiBhbmQgaW5zdGVhZCByZXR1cm4gdHJ1ZS9mYWxzZS4g
IE1vZGlmeQpzaGFkb3dfcHJlYWxsb2MoKSB0byBjcmFzaCB0aGUgZG9tYWlu
IG9uIGFsbG9jYXRpb24gZmFpbHVyZSAoaWYgdGhlCmRvbWFpbiBpcyBub3Qg
YWxyZWFkeSBkeWluZyksIGFzIHNoYWRvdyBjYW5ub3Qgb3BlcmF0ZSBub3Jt
YWxseSBhZnRlcgp0aGF0LiAgTW9kaWZ5IGNhbGxlcnMgdG8gYWxzbyBncmFj
ZWZ1bGx5IGhhbmRsZSB7Xyx9c2hhZG93X3ByZWFsbG9jKCkKZmFpbGluZyB0
byBmdWxmaWxsIHRoZSByZXF1ZXN0LgoKTm90ZSB0aGlzIGluIHR1cm4gcmVx
dWlyZXMgYWRqdXN0aW5nIHRoZSBjYWxsZXJzIG9mCnNoX21ha2VfbW9uaXRv
cl90YWJsZSgpIGFsc28gdG8gaGFuZGxlIGl0IHJldHVybmluZyBJTlZBTElE
X01GTi4Kc2hfdXBkYXRlX3BhZ2luZ19tb2RlcygpIGlzIGFsc28gbW9kaWZp
ZWQgdG8gYWRkIGFkZGl0aW9uYWwgZXJyb3IKcGF0aHMgaW4gY2FzZSBvZiBh
bGxvY2F0aW9uIGZhaWx1cmUsIHNvbWUgb2YgdGhvc2Ugd2lsbCByZXR1cm4g
d2l0aApudWxsIG1vbml0b3IgcGFnZSB0YWJsZXMgKGFuZCB0aGUgZG9tYWlu
IGxpa2VseSBjcmFzaGVkKS4gIFRoaXMgaXMgbm8KZGlmZmVyZW50IHRoYXQg
Y3VycmVudCBlcnJvciBwYXRocywgYnV0IHRoZSBuZXdseSBpbnRyb2R1Y2Vk
IG9uZXMgYXJlCm1vcmUgbGlrZWx5IHRvIHRyaWdnZXIuCgpUaGUgbm93IGFk
ZGVkIGZhaWx1cmUgcG9pbnRzIGluIHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMo
KSBhbHNvIHJlcXVpcmUKdGhhdCBvbiBzb21lIGVycm9yIHJldHVybiBwYXRo
cyB0aGUgcHJldmlvdXMgc3RydWN0dXJlcyBhcmUgY2xlYXJlZCwKYW5kIHRo
dXMgbW9uaXRvciB0YWJsZSBpcyBudWxsLgoKV2hpbGUgdGhlcmUgYWRqdXN0
IHRoZSAndHlwZScgcGFyYW1ldGVyIHR5cGUgb2Ygc2hhZG93X3ByZWFsbG9j
KCkgdG8KdW5zaWduZWQgaW50IHJhdGhlciB0aGFuIHUzMi4KClRoaXMgaXMg
cGFydCBvZiBDVkUtMjAyMi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2Zm
LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4K
U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
PgpBY2tlZC1ieTogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+Ci0tLQpBbmRy
ZXcgcG9pbnRpbmcgb3V0IHRoYXQgLT5pc19zaHV0dGluZ19kb3duIGNhbiBi
ZSByZXNldCBhZ2FpbiwgSSB3b25kZXIKd2hldGhlciByZXN1bWluZyBhIGNy
YXNoZWQgZG9tYWluIHdvdWxkbid0IGJldHRlciBiZSByZWZ1c2VkLCBpZiBm
b3IKbm90aGluZyBlbHNlIHRoYW4gaXRzIFhlbi1pbnRlcm5hbCBzdGF0ZSBw
b3RlbnRpYWxseSBub3QgYWxsb3dpbmcKZnVydGhlciBleGVjdXRpb24uIE9m
IGNvdXJzZSB0aGVuIGEgcXVlc3Rpb24gaXMgd2hldGhlciBzb2Z0LXJlc2V0
CnRpZGllcyBzdGF0ZSBlbm91Z2ggZm9yIGEgZ3Vlc3QgdG8gYmVjb21lIHJl
c3VtYWJsZS4KLS0tCkNoYW5nZXMgc2luY2Ugdjk6CiAtIElOVkFMSURfTUZO
IHJhdGhlciB0aGFuICJpbnZhbGlkIG1mbiIgaW4gZGVzY3JpcHRpb24uCgpD
aGFuZ2VzIHNpbmNlIHY3OgogLSBSZWZpbmUgY29uZGl0aW9uYWwgaW4gc2hh
ZG93X3ByZWFsbG9jKCkuCiAtIEFkZCBUTEIgZmx1c2ggYW5kIGFzc2VydGlv
biB0byBfc2hhZG93X3ByZWFsbG9jKCkuCiAtIFJlLXdyYXAgbG9uZyBsaW5l
LgoKQ2hhbmdlcyBzaW5jZSB2NjoKIC0gVXNlIGQtPmlzX2R5aW5nIGluc3Rl
YWQgb2YgaXNfZHlpbmdfZG9tYWluKCkuCgpDaGFuZ2VzIHNpbmNlIHY1Ogog
LSBSZW1vdmUgX19tdXN0X2NoZWNrIGZyb20gZGVmaW5pdGlvbi4KCkNoYW5n
ZXMgc2luY2UgdjQ6CiAtIEFkZCBfX211c3RfY2hlY2sgYXR0cmlidXRlcyB0
byB7Xyx9c2hhZG93X3ByZWFsbG9jKCkuCiAtIFByZS1hbGxvY2F0ZSBhbGwg
T09TIHBhZ2VzIG91dHNpZGUgb2YgdGhlIGFsbG9jYXRpb24gbG9vcCwgc28g
dGhhdAogICB3ZSBkb24ndCByZXR1cm4gdG8gdGhlIGNhbGxlciB3aXRoIGEg
cGFydGlhbGx5IHBvcHVsYXRlZCBPT1MgYXJyYXkuCiAtIEFkZCBhbiBvdXQg
bGFiZWwgdG8gc2hhZG93X2FsbG9jX3AybV9wYWdlKCkuCiAtIENyYXNoIHRo
ZSBkb21haW4gaW4gc2hhZG93X3ByZWFsbG9jKCkgcmF0aGVyIHRoYW4KICAg
X3NoYWRvd19wcmVhbGxvYygpLCBzbyB0aGF0IHRoZSBjYWxsIGluIHNoYWRv
d19zZXRfYWxsb2NhdGlvbigpCiAgIGF2b2lkcyB0aGUgZG9tYWluX2NyYXNo
IG9uIGZhaWx1cmUuCiAtIERvIG5vdCBjcmFzaCB0aGUgZG9tYWluIGlmIGFs
cmVhZHkgZHlpbmcuCgpDaGFuZ2VzIHNpbmNlIHYzOgogLSBOZXcgaW4gdGhp
cyB2ZXJzaW9uLgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21t
b24uYworKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCkBA
IC0zNiw2ICszNiw3IEBACiAjaW5jbHVkZSA8YXNtL2ZsdXNodGxiLmg+CiAj
aW5jbHVkZSA8YXNtL3NoYWRvdy5oPgogI2luY2x1ZGUgPHhlbi9udW1hLmg+
CisjaW5jbHVkZSA8cHVibGljL3NjaGVkLmg+CiAjaW5jbHVkZSAicHJpdmF0
ZS5oIgogCiBERUZJTkVfUEVSX0NQVSh1aW50MzJfdCx0cmFjZV9zaGFkb3df
cGF0aF9mbGFncyk7CkBAIC05MjgsMTQgKzkyOSwxNSBAQCBzdGF0aWMgaW5s
aW5lIHZvaWQgdHJhY2Vfc2hhZG93X3ByZWFsbG9jCiAKIC8qIE1ha2Ugc3Vy
ZSB0aGVyZSBhcmUgYXQgbGVhc3QgY291bnQgb3JkZXItc2l6ZWQgcGFnZXMK
ICAqIGF2YWlsYWJsZSBpbiB0aGUgc2hhZG93IHBhZ2UgcG9vbC4gKi8KLXN0
YXRpYyB2b2lkIF9zaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwg
dW5zaWduZWQgaW50IHBhZ2VzKQorc3RhdGljIGJvb2wgX19tdXN0X2NoZWNr
IF9zaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQg
aW50IHBhZ2VzKQogewogICAgIHN0cnVjdCB2Y3B1ICp2OwogICAgIHN0cnVj
dCBwYWdlX2luZm8gKnNwLCAqdDsKICAgICBtZm5fdCBzbWZuOwogICAgIGlu
dCBpOwogCi0gICAgaWYgKCBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9w
YWdlcyA+PSBwYWdlcyApIHJldHVybjsKKyAgICBpZiAoIGQtPmFyY2gucGFn
aW5nLnNoYWRvdy5mcmVlX3BhZ2VzID49IHBhZ2VzICkKKyAgICAgICAgcmV0
dXJuIHRydWU7CiAKICAgICAvKiBTaG91bGRuJ3QgaGF2ZSBlbmFibGVkIHNo
YWRvd3MgaWYgd2UndmUgbm8gdmNwdXMuICovCiAgICAgQVNTRVJUKGQtPnZj
cHUgJiYgZC0+dmNwdVswXSk7CkBAIC05NTEsNyArOTUzLDggQEAgc3RhdGlj
IHZvaWQgX3NoYWRvd19wcmVhbGxvYyhzdHJ1Y3QgZG9tYQogICAgICAgICBz
aF91bnBpbihkLCBzbWZuKTsKIAogICAgICAgICAvKiBTZWUgaWYgdGhhdCBm
cmVlZCB1cCBlbm91Z2ggc3BhY2UgKi8KLSAgICAgICAgaWYgKCBkLT5hcmNo
LnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcyA+PSBwYWdlcyApIHJldHVybjsK
KyAgICAgICAgaWYgKCBkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdl
cyA+PSBwYWdlcyApCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9
CiAKICAgICAvKiBTdGFnZSB0d286IGFsbCBzaGFkb3cgcGFnZXMgYXJlIGlu
IHVzZSBpbiBoaWVyYXJjaGllcyB0aGF0IGFyZQpAQCAtOTc0LDcgKzk3Nyw3
IEBAIHN0YXRpYyB2b2lkIF9zaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWEK
ICAgICAgICAgICAgICAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5m
cmVlX3BhZ2VzID49IHBhZ2VzICkKICAgICAgICAgICAgICAgICB7CiAgICAg
ICAgICAgICAgICAgICAgIGd1ZXN0X2ZsdXNoX3RsYl9tYXNrKGQsIGQtPmRp
cnR5X2NwdW1hc2spOwotICAgICAgICAgICAgICAgICAgICByZXR1cm47Cisg
ICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAg
ICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQpAQCAtOTg3LDcgKzk5
MCwxMiBAQCBzdGF0aWMgdm9pZCBfc2hhZG93X3ByZWFsbG9jKHN0cnVjdCBk
b21hCiAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9w
YWdlcywKICAgICAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93LmZyZWVf
cGFnZXMsCiAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5wMm1f
cGFnZXMpOwotICAgIEJVRygpOworCisgICAgQVNTRVJUKGQtPmlzX2R5aW5n
KTsKKworICAgIGd1ZXN0X2ZsdXNoX3RsYl9tYXNrKGQsIGQtPmRpcnR5X2Nw
dW1hc2spOworCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiAvKiBNYWtlIHN1
cmUgdGhlcmUgYXJlIGF0IGxlYXN0IGNvdW50IHBhZ2VzIG9mIHRoZSBvcmRl
ciBhY2NvcmRpbmcgdG8KQEAgLTk5NSw5ICsxMDAzLDE5IEBAIHN0YXRpYyB2
b2lkIF9zaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWEKICAqIFRoaXMgbXVz
dCBiZSBjYWxsZWQgYmVmb3JlIGFueSBjYWxscyB0byBzaGFkb3dfYWxsb2Mo
KS4gIFNpbmNlIHRoaXMKICAqIHdpbGwgZnJlZSBleGlzdGluZyBzaGFkb3dz
IHRvIG1ha2Ugcm9vbSwgaXQgbXVzdCBiZSBjYWxsZWQgZWFybHkgZW5vdWdo
CiAgKiB0byBhdm9pZCBmcmVlaW5nIHNoYWRvd3MgdGhhdCB0aGUgY2FsbGVy
IGlzIGN1cnJlbnRseSB3b3JraW5nIG9uLiAqLwotdm9pZCBzaGFkb3dfcHJl
YWxsb2Moc3RydWN0IGRvbWFpbiAqZCwgdTMyIHR5cGUsIHVuc2lnbmVkIGlu
dCBjb3VudCkKK2Jvb2wgc2hhZG93X3ByZWFsbG9jKHN0cnVjdCBkb21haW4g
KmQsIHVuc2lnbmVkIGludCB0eXBlLCB1bnNpZ25lZCBpbnQgY291bnQpCiB7
Ci0gICAgcmV0dXJuIF9zaGFkb3dfcHJlYWxsb2MoZCwgc2hhZG93X3NpemUo
dHlwZSkgKiBjb3VudCk7CisgICAgYm9vbCByZXQgPSBfc2hhZG93X3ByZWFs
bG9jKGQsIHNoYWRvd19zaXplKHR5cGUpICogY291bnQpOworCisgICAgaWYg
KCAhcmV0ICYmICFkLT5pc19keWluZyAmJgorICAgICAgICAgKCFkLT5pc19z
aHV0dGluZ19kb3duIHx8IGQtPnNodXRkb3duX2NvZGUgIT0gU0hVVERPV05f
Y3Jhc2gpICkKKyAgICAgICAgLyoKKyAgICAgICAgICogRmFpbGluZyB0byBh
bGxvY2F0ZSBtZW1vcnkgcmVxdWlyZWQgZm9yIHNoYWRvdyB1c2FnZSBjYW4g
b25seSByZXN1bHQgaW4KKyAgICAgICAgICogYSBkb21haW4gY3Jhc2gsIGRv
IGl0IGhlcmUgcmF0aGVyIHRoYXQgcmVseWluZyBvbiBldmVyeSBjYWxsZXIg
dG8gZG8gaXQuCisgICAgICAgICAqLworICAgICAgICBkb21haW5fY3Jhc2go
ZCk7CisKKyAgICByZXR1cm4gcmV0OwogfQogCiAvKiBEZWxpYmVyYXRlbHkg
ZnJlZSBhbGwgdGhlIG1lbW9yeSB3ZSBjYW46IHRoaXMgd2lsbCB0ZWFyIGRv
d24gYWxsIG9mCkBAIC0xMjE4LDcgKzEyMzYsNyBAQCB2b2lkIHNoYWRvd19m
cmVlKHN0cnVjdCBkb21haW4gKmQsIG1mbl90CiBzdGF0aWMgc3RydWN0IHBh
Z2VfaW5mbyAqY2ZfY2hlY2sKIHNoYWRvd19hbGxvY19wMm1fcGFnZShzdHJ1
Y3QgZG9tYWluICpkKQogewotICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOwor
ICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnID0gTlVMTDsKIAogICAgIC8qIFRo
aXMgaXMgY2FsbGVkIGJvdGggZnJvbSB0aGUgcDJtIGNvZGUgKHdoaWNoIG5l
dmVyIGhvbGRzIHRoZQogICAgICAqIHBhZ2luZyBsb2NrKSBhbmQgdGhlIGxv
Zy1kaXJ0eSBjb2RlICh3aGljaCBhbHdheXMgZG9lcykuICovCkBAIC0xMjM2
LDE2ICsxMjU0LDE4IEBAIHNoYWRvd19hbGxvY19wMm1fcGFnZShzdHJ1Y3Qg
ZG9tYWluICpkKQogICAgICAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2lu
Zy5zaGFkb3cucDJtX3BhZ2VzLAogICAgICAgICAgICAgICAgICAgICBzaGFk
b3dfbWluX2FjY2VwdGFibGVfcGFnZXMoZCkpOwogICAgICAgICB9Ci0gICAg
ICAgIHBhZ2luZ191bmxvY2soZCk7Ci0gICAgICAgIHJldHVybiBOVUxMOwor
ICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICBzaGFkb3dfcHJlYWxs
b2MoZCwgU0hfdHlwZV9wMm1fdGFibGUsIDEpOworICAgIGlmICggIXNoYWRv
d19wcmVhbGxvYyhkLCBTSF90eXBlX3AybV90YWJsZSwgMSkgKQorICAgICAg
ICBnb3RvIG91dDsKKwogICAgIHBnID0gbWZuX3RvX3BhZ2Uoc2hhZG93X2Fs
bG9jKGQsIFNIX3R5cGVfcDJtX3RhYmxlLCAwKSk7CiAgICAgZC0+YXJjaC5w
YWdpbmcuc2hhZG93LnAybV9wYWdlcysrOwogICAgIGQtPmFyY2gucGFnaW5n
LnNoYWRvdy50b3RhbF9wYWdlcy0tOwogICAgIEFTU0VSVCghcGFnZV9nZXRf
b3duZXIocGcpICYmICEocGctPmNvdW50X2luZm8gJiBQR0NfY291bnRfbWFz
aykpOwogCisgb3V0OgogICAgIHBhZ2luZ191bmxvY2soZCk7CiAKICAgICBy
ZXR1cm4gcGc7CkBAIC0xMzM2LDcgKzEzNTYsOSBAQCBpbnQgc2hhZG93X3Nl
dF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4KICAgICAgICAgZWxzZSBpZiAo
IGQtPmFyY2gucGFnaW5nLnNoYWRvdy50b3RhbF9wYWdlcyA+IHBhZ2VzICkK
ICAgICAgICAgewogICAgICAgICAgICAgLyogTmVlZCB0byByZXR1cm4gbWVt
b3J5IHRvIGRvbWhlYXAgKi8KLSAgICAgICAgICAgIF9zaGFkb3dfcHJlYWxs
b2MoZCwgMSk7CisgICAgICAgICAgICBpZiAoICFfc2hhZG93X3ByZWFsbG9j
KGQsIDEpICkKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKKwog
ICAgICAgICAgICAgc3AgPSBwYWdlX2xpc3RfcmVtb3ZlX2hlYWQoJmQtPmFy
Y2gucGFnaW5nLnNoYWRvdy5mcmVlbGlzdCk7CiAgICAgICAgICAgICBBU1NF
UlQoc3ApOwogICAgICAgICAgICAgLyoKQEAgLTIzMzksMTIgKzIzNjEsMTMg
QEAgc3RhdGljIHZvaWQgc2hfdXBkYXRlX3BhZ2luZ19tb2RlcyhzdHJ1Ywog
ICAgIGlmICggbWZuX2VxKHYtPmFyY2gucGFnaW5nLnNoYWRvdy5vb3Nfc25h
cHNob3RbMF0sIElOVkFMSURfTUZOKSApCiAgICAgewogICAgICAgICBpbnQg
aTsKKworICAgICAgICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlw
ZV9vb3Nfc25hcHNob3QsIFNIQURPV19PT1NfUEFHRVMpICkKKyAgICAgICAg
ICAgIHJldHVybjsKKwogICAgICAgICBmb3IoaSA9IDA7IGkgPCBTSEFET1df
T09TX1BBR0VTOyBpKyspCi0gICAgICAgIHsKLSAgICAgICAgICAgIHNoYWRv
d19wcmVhbGxvYyhkLCBTSF90eXBlX29vc19zbmFwc2hvdCwgMSk7CiAgICAg
ICAgICAgICB2LT5hcmNoLnBhZ2luZy5zaGFkb3cub29zX3NuYXBzaG90W2ld
ID0KICAgICAgICAgICAgICAgICBzaGFkb3dfYWxsb2MoZCwgU0hfdHlwZV9v
b3Nfc25hcHNob3QsIDApOwotICAgICAgICB9CiAgICAgfQogI2VuZGlmIC8q
IE9PUyAqLwogCkBAIC0yNDA4LDYgKzI0MzEsOSBAQCBzdGF0aWMgdm9pZCBz
aF91cGRhdGVfcGFnaW5nX21vZGVzKHN0cnVjCiAgICAgICAgICAgICBtZm5f
dCBtbWZuID0gc2hfbWFrZV9tb25pdG9yX3RhYmxlKAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB2LCB2LT5hcmNoLnBhZ2luZy5tb2RlLT5zaGFk
b3cuc2hhZG93X2xldmVscyk7CiAKKyAgICAgICAgICAgIGlmICggbWZuX2Vx
KG1tZm4sIElOVkFMSURfTUZOKSApCisgICAgICAgICAgICAgICAgcmV0dXJu
OworCiAgICAgICAgICAgICB2LT5hcmNoLmh2bS5tb25pdG9yX3RhYmxlID0g
cGFnZXRhYmxlX2Zyb21fbWZuKG1tZm4pOwogICAgICAgICAgICAgbWFrZV9j
cjModiwgbW1mbik7CiAgICAgICAgICAgICBodm1fdXBkYXRlX2hvc3RfY3Iz
KHYpOwpAQCAtMjQ0Niw2ICsyNDcyLDEyIEBAIHN0YXRpYyB2b2lkIHNoX3Vw
ZGF0ZV9wYWdpbmdfbW9kZXMoc3RydWMKICAgICAgICAgICAgICAgICB2LT5h
cmNoLmh2bS5tb25pdG9yX3RhYmxlID0gcGFnZXRhYmxlX251bGwoKTsKICAg
ICAgICAgICAgICAgICBuZXdfbWZuID0gc2hfbWFrZV9tb25pdG9yX3RhYmxl
KAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdiwgdi0+YXJjaC5w
YWdpbmcubW9kZS0+c2hhZG93LnNoYWRvd19sZXZlbHMpOworICAgICAgICAg
ICAgICAgIGlmICggbWZuX2VxKG5ld19tZm4sIElOVkFMSURfTUZOKSApCisg
ICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICBzaF9kZXN0
cm95X21vbml0b3JfdGFibGUodiwgb2xkX21mbiwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9sZF9tb2RlLT5zaGFk
b3cuc2hhZG93X2xldmVscyk7CisgICAgICAgICAgICAgICAgICAgIHJldHVy
bjsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgdi0+YXJj
aC5odm0ubW9uaXRvcl90YWJsZSA9IHBhZ2V0YWJsZV9mcm9tX21mbihuZXdf
bWZuKTsKICAgICAgICAgICAgICAgICBTSEFET1dfUFJJTlRLKCJuZXcgbW9u
aXRvciB0YWJsZSAlIlBSSV9tZm4gIlxuIiwKICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBtZm5feChuZXdfbWZuKSk7CkBAIC0yNTMxLDcgKzI1
NjMsMTIgQEAgdm9pZCBzaF9zZXRfdG9wbGV2ZWxfc2hhZG93KHN0cnVjdCB2
Y3B1CiAgICAgaWYgKCAhbWZuX3ZhbGlkKHNtZm4pICkKICAgICB7CiAgICAg
ICAgIC8qIE1ha2Ugc3VyZSB0aGVyZSdzIGVub3VnaCBmcmVlIHNoYWRvdyBt
ZW1vcnkuICovCi0gICAgICAgIHNoYWRvd19wcmVhbGxvYyhkLCByb290X3R5
cGUsIDEpOworICAgICAgICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgcm9v
dF90eXBlLCAxKSApCisgICAgICAgIHsKKyAgICAgICAgICAgIG5ld19lbnRy
eSA9IHBhZ2V0YWJsZV9udWxsKCk7CisgICAgICAgICAgICBnb3RvIGluc3Rh
bGxfbmV3X2VudHJ5OworICAgICAgICB9CisKICAgICAgICAgLyogU2hhZG93
IHRoZSBwYWdlLiAqLwogICAgICAgICBzbWZuID0gbWFrZV9zaGFkb3codiwg
Z21mbiwgcm9vdF90eXBlKTsKICAgICB9Ci0tLSBhL3hlbi9hcmNoL3g4Ni9t
bS9zaGFkb3cvaHZtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9o
dm0uYwpAQCAtNjk3LDcgKzY5Nyw5IEBAIG1mbl90IHNoX21ha2VfbW9uaXRv
cl90YWJsZShjb25zdCBzdHJ1Y3QKICAgICBBU1NFUlQoIXBhZ2V0YWJsZV9n
ZXRfcGZuKHYtPmFyY2guaHZtLm1vbml0b3JfdGFibGUpKTsKIAogICAgIC8q
IEd1YXJhbnRlZSB3ZSBjYW4gZ2V0IHRoZSBtZW1vcnkgd2UgbmVlZCAqLwot
ICAgIHNoYWRvd19wcmVhbGxvYyhkLCBTSF90eXBlX21vbml0b3JfdGFibGUs
IENPTkZJR19QQUdJTkdfTEVWRUxTKTsKKyAgICBpZiAoICFzaGFkb3dfcHJl
YWxsb2MoZCwgU0hfdHlwZV9tb25pdG9yX3RhYmxlLCBDT05GSUdfUEFHSU5H
X0xFVkVMUykgKQorICAgICAgICByZXR1cm4gSU5WQUxJRF9NRk47CisKICAg
ICBtNG1mbiA9IHNoYWRvd19hbGxvYyhkLCBTSF90eXBlX21vbml0b3JfdGFi
bGUsIDApOwogICAgIG1mbl90b19wYWdlKG00bWZuKS0+c2hhZG93X2ZsYWdz
ID0gNDsKIAotLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMK
KysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCkBAIC0yNDQ3
LDkgKzI0NDcsMTQgQEAgc3RhdGljIGludCBjZl9jaGVjayBzaF9wYWdlX2Zh
dWx0KAogICAgICAqIFByZWFsbG9jYXRlIHNoYWRvdyBwYWdlcyAqYmVmb3Jl
KiByZW1vdmluZyB3cml0YWJsZSBhY2Nlc3NlcwogICAgICAqIG90aGVyd2hp
c2UgYW4gT09TIEwxIG1pZ2h0IGJlIGRlbW90ZWQgYW5kIHByb21vdGVkIGFn
YWluIHdpdGgKICAgICAgKiB3cml0YWJsZSBtYXBwaW5ncy4gKi8KLSAgICBz
aGFkb3dfcHJlYWxsb2MoZCwKLSAgICAgICAgICAgICAgICAgICAgU0hfdHlw
ZV9sMV9zaGFkb3csCi0gICAgICAgICAgICAgICAgICAgIEdVRVNUX1BBR0lO
R19MRVZFTFMgPCA0ID8gMSA6IEdVRVNUX1BBR0lOR19MRVZFTFMgLSAxKTsK
KyAgICBpZiAoICFzaGFkb3dfcHJlYWxsb2MoZCwgU0hfdHlwZV9sMV9zaGFk
b3csCisgICAgICAgICAgICAgICAgICAgICAgICAgIEdVRVNUX1BBR0lOR19M
RVZFTFMgPCA0CisgICAgICAgICAgICAgICAgICAgICAgICAgID8gMSA6IEdV
RVNUX1BBR0lOR19MRVZFTFMgLSAxKSApCisgICAgeworICAgICAgICBwYWdp
bmdfdW5sb2NrKGQpOworICAgICAgICBwdXRfZ2ZuKGQsIGdmbl94KGdmbikp
OworICAgICAgICByZXR1cm4gMDsKKyAgICB9CiAKICAgICByYyA9IGd3X3Jl
bW92ZV93cml0ZV9hY2Nlc3Nlcyh2LCB2YSwgJmd3KTsKIAotLS0gYS94ZW4v
YXJjaC94ODYvbW0vc2hhZG93L3ByaXZhdGUuaAorKysgYi94ZW4vYXJjaC94
ODYvbW0vc2hhZG93L3ByaXZhdGUuaApAQCAtMzgzLDcgKzM4Myw4IEBAIHZv
aWQgc2hhZG93X3Byb21vdGUoc3RydWN0IGRvbWFpbiAqZCwgbWYKIHZvaWQg
c2hhZG93X2RlbW90ZShzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBnbWZuLCB1
MzIgdHlwZSk7CiAKIC8qIFNoYWRvdyBwYWdlIGFsbG9jYXRpb24gZnVuY3Rp
b25zICovCi12b2lkICBzaGFkb3dfcHJlYWxsb2Moc3RydWN0IGRvbWFpbiAq
ZCwgdTMyIHNoYWRvd190eXBlLCB1bnNpZ25lZCBpbnQgY291bnQpOworYm9v
bCBfX211c3RfY2hlY2sgc2hhZG93X3ByZWFsbG9jKHN0cnVjdCBkb21haW4g
KmQsIHVuc2lnbmVkIGludCBzaGFkb3dfdHlwZSwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgY291bnQpOwogbWZu
X3Qgc2hhZG93X2FsbG9jKHN0cnVjdCBkb21haW4gKmQsCiAgICAgICAgICAg
ICAgICAgICAgIHUzMiBzaGFkb3dfdHlwZSwKICAgICAgICAgICAgICAgICAg
ICAgdW5zaWduZWQgbG9uZyBiYWNrcG9pbnRlcik7Cg==

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-07.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-07.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHJlZnVzZSBuZXcgYWxsb2NhdGlvbnMgZm9y
IGR5aW5nIGRvbWFpbnMKClRoaXMgd2lsbCBpbiBwYXJ0aWN1bGFyIHByZXZl
bnQgYW55IGF0dGVtcHRzIHRvIGFkZCBlbnRyaWVzIHRvIHRoZSBwMm0sCm9u
Y2UgLSBpbiBhIHN1YnNlcXVlbnQgY2hhbmdlIC0gbm9uLXJvb3QgZW50cmll
cyBoYXZlIGJlZW4gcmVtb3ZlZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy
Mi0zMzc0NiAvIFhTQS00MTAuCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUg
TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog
SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpBY2tlZC1ieTogVGlt
IERlZWdhbiA8dGltQHhlbi5vcmc+Ci0tLQpDaGFuZ2VzIHNpbmNlIHY5Ogog
LSBTcGxpdCBvZmYgZnJvbSBsYXRlciBwYXRjaC4KCi0tLSBhL3hlbi9hcmNo
L3g4Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hhcC9o
YXAuYwpAQCAtMjQ1LDYgKzI0NSw5IEBAIHN0YXRpYyBzdHJ1Y3QgcGFnZV9p
bmZvICpoYXBfYWxsb2Moc3RydWMKIAogICAgIEFTU0VSVChwYWdpbmdfbG9j
a2VkX2J5X21lKGQpKTsKIAorICAgIGlmICggdW5saWtlbHkoZC0+aXNfZHlp
bmcpICkKKyAgICAgICAgcmV0dXJuIE5VTEw7CisKICAgICBwZyA9IHBhZ2Vf
bGlzdF9yZW1vdmVfaGVhZCgmZC0+YXJjaC5wYWdpbmcuaGFwLmZyZWVsaXN0
KTsKICAgICBpZiAoIHVubGlrZWx5KCFwZykgKQogICAgICAgICByZXR1cm4g
TlVMTDsKQEAgLTI4MSw3ICsyODQsNyBAQCBzdGF0aWMgc3RydWN0IHBhZ2Vf
aW5mbyAqY2ZfY2hlY2sgaGFwX2FsCiAgICAgICAgIGQtPmFyY2gucGFnaW5n
LmhhcC5wMm1fcGFnZXMrKzsKICAgICAgICAgQVNTRVJUKCFwYWdlX2dldF9v
d25lcihwZykgJiYgIShwZy0+Y291bnRfaW5mbyAmIFBHQ19jb3VudF9tYXNr
KSk7CiAgICAgfQotICAgIGVsc2UgaWYgKCAhZC0+YXJjaC5wYWdpbmcucDJt
X2FsbG9jX2ZhaWxlZCApCisgICAgZWxzZSBpZiAoICFkLT5hcmNoLnBhZ2lu
Zy5wMm1fYWxsb2NfZmFpbGVkICYmICFkLT5pc19keWluZyApCiAgICAgewog
ICAgICAgICBkLT5hcmNoLnBhZ2luZy5wMm1fYWxsb2NfZmFpbGVkID0gMTsK
ICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCAiZCVpIGZhaWxlZCB0byBh
bGxvY2F0ZSBmcm9tIEhBUCBwb29sXG4iLAotLS0gYS94ZW4vYXJjaC94ODYv
bW0vc2hhZG93L2NvbW1vbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFk
b3cvY29tbW9uLmMKQEAgLTkzOSw2ICs5MzksMTAgQEAgc3RhdGljIGJvb2wg
X19tdXN0X2NoZWNrIF9zaGFkb3dfcHJlYWxsbwogICAgIGlmICggZC0+YXJj
aC5wYWdpbmcuc2hhZG93LmZyZWVfcGFnZXMgPj0gcGFnZXMgKQogICAgICAg
ICByZXR1cm4gdHJ1ZTsKIAorICAgIGlmICggdW5saWtlbHkoZC0+aXNfZHlp
bmcpICkKKyAgICAgICAgLyogTm8gcmVjbGFpbSB3aGVuIHRoZSBkb21haW4g
aXMgZHlpbmcsIHRlYXJkb3duIHdpbGwgdGFrZSBjYXJlIG9mIGl0LiAqLwor
ICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAvKiBTaG91bGRuJ3QgaGF2
ZSBlbmFibGVkIHNoYWRvd3MgaWYgd2UndmUgbm8gdmNwdXMuICovCiAgICAg
QVNTRVJUKGQtPnZjcHUgJiYgZC0+dmNwdVswXSk7CiAKQEAgLTk5MSw3ICs5
OTUsNyBAQCBzdGF0aWMgYm9vbCBfX211c3RfY2hlY2sgX3NoYWRvd19wcmVh
bGxvCiAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3Bh
Z2VzLAogICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cucDJtX3Bh
Z2VzKTsKIAotICAgIEFTU0VSVChkLT5pc19keWluZyk7CisgICAgQVNTRVJU
X1VOUkVBQ0hBQkxFKCk7CiAKICAgICBndWVzdF9mbHVzaF90bGJfbWFzayhk
LCBkLT5kaXJ0eV9jcHVtYXNrKTsKIApAQCAtMTAwNSwxMCArMTAwOSwxMyBA
QCBzdGF0aWMgYm9vbCBfX211c3RfY2hlY2sgX3NoYWRvd19wcmVhbGxvCiAg
KiB0byBhdm9pZCBmcmVlaW5nIHNoYWRvd3MgdGhhdCB0aGUgY2FsbGVyIGlz
IGN1cnJlbnRseSB3b3JraW5nIG9uLiAqLwogYm9vbCBzaGFkb3dfcHJlYWxs
b2Moc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHR5cGUsIHVuc2ln
bmVkIGludCBjb3VudCkKIHsKLSAgICBib29sIHJldCA9IF9zaGFkb3dfcHJl
YWxsb2MoZCwgc2hhZG93X3NpemUodHlwZSkgKiBjb3VudCk7CisgICAgYm9v
bCByZXQ7CisKKyAgICBpZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisg
ICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCAhcmV0ICYmICFkLT5p
c19keWluZyAmJgotICAgICAgICAgKCFkLT5pc19zaHV0dGluZ19kb3duIHx8
IGQtPnNodXRkb3duX2NvZGUgIT0gU0hVVERPV05fY3Jhc2gpICkKKyAgICBy
ZXQgPSBfc2hhZG93X3ByZWFsbG9jKGQsIHNoYWRvd19zaXplKHR5cGUpICog
Y291bnQpOworICAgIGlmICggIXJldCAmJiAoIWQtPmlzX3NodXR0aW5nX2Rv
d24gfHwgZC0+c2h1dGRvd25fY29kZSAhPSBTSFVURE9XTl9jcmFzaCkgKQog
ICAgICAgICAvKgogICAgICAgICAgKiBGYWlsaW5nIHRvIGFsbG9jYXRlIG1l
bW9yeSByZXF1aXJlZCBmb3Igc2hhZG93IHVzYWdlIGNhbiBvbmx5IHJlc3Vs
dCBpbgogICAgICAgICAgKiBhIGRvbWFpbiBjcmFzaCwgZG8gaXQgaGVyZSBy
YXRoZXIgdGhhdCByZWx5aW5nIG9uIGV2ZXJ5IGNhbGxlciB0byBkbyBpdC4K
QEAgLTEyMzgsNiArMTI0NSw5IEBAIHNoYWRvd19hbGxvY19wMm1fcGFnZShz
dHJ1Y3QgZG9tYWluICpkKQogewogICAgIHN0cnVjdCBwYWdlX2luZm8gKnBn
ID0gTlVMTDsKIAorICAgIGlmICggdW5saWtlbHkoZC0+aXNfZHlpbmcpICkK
KyAgICAgICByZXR1cm4gTlVMTDsKKwogICAgIC8qIFRoaXMgaXMgY2FsbGVk
IGJvdGggZnJvbSB0aGUgcDJtIGNvZGUgKHdoaWNoIG5ldmVyIGhvbGRzIHRo
ZQogICAgICAqIHBhZ2luZyBsb2NrKSBhbmQgdGhlIGxvZy1kaXJ0eSBjb2Rl
ICh3aGljaCBhbHdheXMgZG9lcykuICovCiAgICAgcGFnaW5nX2xvY2tfcmVj
dXJzaXZlKGQpOwo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-08.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-08.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IHRydWx5IGZyZWUgcGFnaW5nIHBvb2wgbWVt
b3J5IGZvciBkeWluZyBkb21haW5zCgpNb2RpZnkge2hhcCxzaGFkb3d9X2Zy
ZWUgdG8gZnJlZSB0aGUgcGFnZSBpbW1lZGlhdGVseSBpZiB0aGUgZG9tYWlu
IGlzCmR5aW5nLCBzbyB0aGF0IHBhZ2VzIGRvbid0IGFjY3VtdWxhdGUgaW4g
dGhlIHBvb2wgd2hlbgp7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRvd24oKSBn
ZXQgY2FsbGVkLiBUaGlzIGlzIHRvIGxpbWl0IHRoZSBhbW91bnQgb2YKd29y
ayB3aGljaCBuZWVkcyB0byBiZSBkb25lIHRoZXJlIChpbiBhIG5vbi1wcmVl
bXB0YWJsZSBtYW5uZXIpLgoKTm90ZSB0aGUgY2FsbCB0byBzaGFkb3dfZnJl
ZSgpIGluIHNoYWRvd19mcmVlX3AybV9wYWdlKCkgaXMgbW92ZWQgYWZ0ZXIK
aW5jcmVhc2luZyB0b3RhbF9wYWdlcywgc28gdGhhdCB0aGUgZGVjcmVhc2Ug
ZG9uZSBpbiBzaGFkb3dfZnJlZSgpIGluCmNhc2UgdGhlIGRvbWFpbiBpcyBk
eWluZyBkb2Vzbid0IHVuZGVyZmxvdyB0aGUgY291bnRlciwgZXZlbiBpZiBq
dXN0IGZvcgphIHNob3J0IGludGVydmFsLgoKVGhpcyBpcyBwYXJ0IG9mIENW
RS0yMDIyLTMzNzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2Vy
IFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2Zm
LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5
OiBUaW0gRGVlZ2FuIDx0aW1AeGVuLm9yZz4KLS0tCkNoYW5nZXMgc2luY2Ug
djk6CiAtIFNwbGl0IG9mZiBmcm9tIGxhdGVyIHBhdGNoLiBBZGQgY29tbWVu
dHMuCgotLS0gYS94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCisrKyBiL3hl
bi9hcmNoL3g4Ni9tbS9oYXAvaGFwLmMKQEAgLTI2NSw2ICsyNjUsMTggQEAg
c3RhdGljIHZvaWQgaGFwX2ZyZWUoc3RydWN0IGRvbWFpbiAqZCwgbQogCiAg
ICAgQVNTRVJUKHBhZ2luZ19sb2NrZWRfYnlfbWUoZCkpOwogCisgICAgLyoK
KyAgICAgKiBGb3IgZHlpbmcgZG9tYWlucywgYWN0dWFsbHkgZnJlZSB0aGUg
bWVtb3J5IGhlcmUuIFRoaXMgd2F5IGxlc3Mgd29yayBpcworICAgICAqIGxl
ZnQgdG8gaGFwX2ZpbmFsX3RlYXJkb3duKCksIHdoaWNoIGNhbm5vdCBlYXNp
bHkgaGF2ZSBwcmVlbXB0aW9uIGNoZWNrcworICAgICAqIGFkZGVkLgorICAg
ICAqLworICAgIGlmICggdW5saWtlbHkoZC0+aXNfZHlpbmcpICkKKyAgICB7
CisgICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsKKyAgICAgICAgZC0+
YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3BhZ2VzLS07CisgICAgICAgIHJldHVy
bjsKKyAgICB9CisKICAgICBkLT5hcmNoLnBhZ2luZy5oYXAuZnJlZV9wYWdl
cysrOwogICAgIHBhZ2VfbGlzdF9hZGRfdGFpbChwZywgJmQtPmFyY2gucGFn
aW5nLmhhcC5mcmVlbGlzdCk7CiB9Ci0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9z
aGFkb3cvY29tbW9uLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9j
b21tb24uYwpAQCAtMTE4Nyw2ICsxMTg3LDcgQEAgbWZuX3Qgc2hhZG93X2Fs
bG9jKHN0cnVjdCBkb21haW4gKmQsCiB2b2lkIHNoYWRvd19mcmVlKHN0cnVj
dCBkb21haW4gKmQsIG1mbl90IHNtZm4pCiB7CiAgICAgc3RydWN0IHBhZ2Vf
aW5mbyAqbmV4dCA9IE5VTEwsICpzcCA9IG1mbl90b19wYWdlKHNtZm4pOwor
ICAgIGJvb2wgZHlpbmcgPSBBQ0NFU1NfT05DRShkLT5pc19keWluZyk7CiAg
ICAgc3RydWN0IHBhZ2VfbGlzdF9oZWFkICpwaW5fbGlzdDsKICAgICB1bnNp
Z25lZCBpbnQgcGFnZXM7CiAgICAgdTMyIHNoYWRvd190eXBlOwpAQCAtMTIy
OSwxMSArMTIzMCwzMiBAQCB2b2lkIHNoYWRvd19mcmVlKHN0cnVjdCBkb21h
aW4gKmQsIG1mbl90CiAgICAgICAgICAqIGp1c3QgYmVmb3JlIHRoZSBhbGxv
Y2F0b3IgaGFuZHMgdGhlIHBhZ2Ugb3V0IGFnYWluLiAqLwogICAgICAgICBw
YWdlX3NldF90bGJmbHVzaF90aW1lc3RhbXAoc3ApOwogICAgICAgICBwZXJm
Y19kZWNyKHNoYWRvd19hbGxvY19jb3VudCk7Ci0gICAgICAgIHBhZ2VfbGlz
dF9hZGRfdGFpbChzcCwgJmQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlbGlz
dCk7CisKKyAgICAgICAgLyoKKyAgICAgICAgICogRm9yIGR5aW5nIGRvbWFp
bnMsIGFjdHVhbGx5IGZyZWUgdGhlIG1lbW9yeSBoZXJlLiBUaGlzIHdheSBs
ZXNzCisgICAgICAgICAqIHdvcmsgaXMgbGVmdCB0byBzaGFkb3dfZmluYWxf
dGVhcmRvd24oKSwgd2hpY2ggY2Fubm90IGVhc2lseSBoYXZlCisgICAgICAg
ICAqIHByZWVtcHRpb24gY2hlY2tzIGFkZGVkLgorICAgICAgICAgKi8KKyAg
ICAgICAgaWYgKCB1bmxpa2VseShkeWluZykgKQorICAgICAgICB7CisgICAg
ICAgICAgICAvKgorICAgICAgICAgICAgICogVGhlIGJhY2twb2ludGVyIGZp
ZWxkIChzaC5iYWNrKSB1c2VkIGJ5IHNoYWRvdyBjb2RlIGFsaWFzZXMgdGhl
CisgICAgICAgICAgICAgKiBkb21haW4gb3duZXIgZmllbGQsIHVuY29uZGl0
aW9uYWxseSBjbGVhciBpdCBoZXJlIHRvIGF2b2lkCisgICAgICAgICAgICAg
KiBmcmVlX2RvbWhlYXBfcGFnZSgpIGF0dGVtcHRpbmcgdG8gcGFyc2UgaXQu
CisgICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIHBhZ2Vfc2V0X293bmVy
KHNwLCBOVUxMKTsKKyAgICAgICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKHNw
KTsKKyAgICAgICAgfQorICAgICAgICBlbHNlCisgICAgICAgICAgICBwYWdl
X2xpc3RfYWRkX3RhaWwoc3AsICZkLT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJl
ZWxpc3QpOworCiAgICAgICAgIHNwID0gbmV4dDsKICAgICB9CiAKLSAgICBk
LT5hcmNoLnBhZ2luZy5zaGFkb3cuZnJlZV9wYWdlcyArPSBwYWdlczsKKyAg
ICBpZiAoIHVubGlrZWx5KGR5aW5nKSApCisgICAgICAgIGQtPmFyY2gucGFn
aW5nLnNoYWRvdy50b3RhbF9wYWdlcyAtPSBwYWdlczsKKyAgICBlbHNlCisg
ICAgICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5mcmVlX3BhZ2VzICs9IHBh
Z2VzOwogfQogCiAvKiBEaXZlcnQgYSBwYWdlIGZyb20gdGhlIHBvb2wgdG8g
YmUgdXNlZCBieSB0aGUgcDJtIG1hcHBpbmcuCkBAIC0xMzAzLDkgKzEzMjUs
OSBAQCBzaGFkb3dfZnJlZV9wMm1fcGFnZShzdHJ1Y3QgZG9tYWluICpkLCBz
CiAgICAgICogcGFnaW5nIGxvY2spIGFuZCB0aGUgbG9nLWRpcnR5IGNvZGUg
KHdoaWNoIGFsd2F5cyBkb2VzKS4gKi8KICAgICBwYWdpbmdfbG9ja19yZWN1
cnNpdmUoZCk7CiAKLSAgICBzaGFkb3dfZnJlZShkLCBwYWdlX3RvX21mbihw
ZykpOwogICAgIGQtPmFyY2gucGFnaW5nLnNoYWRvdy5wMm1fcGFnZXMtLTsK
ICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cudG90YWxfcGFnZXMrKzsKKyAg
ICBzaGFkb3dfZnJlZShkLCBwYWdlX3RvX21mbihwZykpOwogCiAgICAgcGFn
aW5nX3VubG9jayhkKTsKIH0K

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-09.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-09.patch"
Content-Transfer-Encoding: base64

RnJvbTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
ClN1YmplY3Q6IHg4Ni9wMm06IGZyZWUgdGhlIHBhZ2luZyBtZW1vcnkgcG9v
bCBwcmVlbXB0aXZlbHkKClRoZSBwYWdpbmcgbWVtb3J5IHBvb2wgaXMgY3Vy
cmVudGx5IGZyZWVkIGluIHR3byBkaWZmZXJlbnQgcGxhY2VzOgpmcm9tIHtz
aGFkb3csaGFwfV90ZWFyZG93bigpIHZpYSBkb21haW5fcmVsaW5xdWlzaF9y
ZXNvdXJjZXMoKSBhbmQKZnJvbSB7c2hhZG93LGhhcH1fZmluYWxfdGVhcmRv
d24oKSB2aWEgY29tcGxldGVfZG9tYWluX2Rlc3Ryb3koKS4KV2hpbGUgdGhl
IGZvcm1lciBkb2VzIGhhbmRsZSBwcmVlbXB0aW9uLCB0aGUgbGF0ZXIgZG9l
c24ndC4KCkF0dGVtcHQgdG8gbW92ZSBhcyBtdWNoIHAybSByZWxhdGVkIGZy
ZWVpbmcgYXMgcG9zc2libGUgdG8gaGFwcGVuCmJlZm9yZSB0aGUgY2FsbCB0
byB7c2hhZG93LGhhcH1fdGVhcmRvd24oKSwgc28gdGhhdCBtb3N0IG1lbW9y
eSBjYW4gYmUKZnJlZWQgaW4gYSBwcmVlbXB0aXZlIHdheS4gIEluIG9yZGVy
IHRvIGF2b2lkIGNhdXNpbmcgaXNzdWVzIHRvCmV4aXN0aW5nIGNhbGxlcnMg
bGVhdmUgdGhlIHJvb3QgcDJtIHBhZ2UgdGFibGVzIHNldCBhbmQgZnJlZSB0
aGVtIGluCntoYXAsc2hhZG93fV9maW5hbF90ZWFyZG93bigpLiAgQWxzbyBt
b2RpZnkge2hhcCxzaGFkb3d9X2ZyZWUgdG8gZnJlZQp0aGUgcGFnZSBpbW1l
ZGlhdGVseSBpZiB0aGUgZG9tYWluIGlzIGR5aW5nLCBzbyB0aGF0IHBhZ2Vz
IGRvbid0CmFjY3VtdWxhdGUgaW4gdGhlIHBvb2wgd2hlbiB7c2hhZG93LGhh
cH1fZmluYWxfdGVhcmRvd24oKSBnZXQgY2FsbGVkLgoKTW92ZSBhbHRwMm1f
dmNwdV9kaXNhYmxlX3ZlKCkgdG8gYmUgZG9uZSBpbiBoYXBfdGVhcmRvd24o
KSwgYXMgdGhhdCdzCnRoZSBwbGFjZSB3aGVyZSBhbHRwMm1fYWN0aXZlIGdl
dHMgZGlzYWJsZWQgbm93LgoKVGhpcyBpcyBwYXJ0IG9mIENWRS0yMDIyLTMz
NzQ2IC8gWFNBLTQxMC4KClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpTaWduZWQtb2ZmLWJ5OiBKYW4g
QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2VkLWJ5OiBUaW0gRGVl
Z2FuIDx0aW1AeGVuLm9yZz4KLS0tCkNoYW5nZXMgc2luY2Ugdjk6Ci0gU3Bs
aXQgcGFydHMgb2ZmIGludG8gbmV3IGVhcmxpZXIgcGF0Y2hlcy4KCkNoYW5n
ZXMgc2luY2Ugdjc6CiAtIFJlLWJhc2Ugb3ZlciBjaGFuZ2VzIGVhcmxpZXIg
aW4gdGhlIHNlcmllcy4KIC0gQ29udmVydCBBU1NFUlQoKSB0byBBU1NFUlRf
VU5SRUFDSEFCTEUoKSBpbiBfc2hhZG93X3ByZWFsbG9jKCkuCiAtIEF2b2lk
IGRvdWJsZSBibGFuayBsaW5lcy4KCkNoYW5nZXMgc2luY2UgdjY6CiAtIEZh
aWwgYWxsb2NhdGlvbiBhbmQgcmV0dXJuIHBhZ2VzIHRvIGRvbWhlYXAgb24g
ZnJlZSBvbmx5IHdoZW4KICAgZC0+aXNfZHlpbmcsIG90aGVyd2lzZSBzdGls
bCBydW5uaW5nIHZDUFVzIGNvdWxkIG1hbGZ1bmN0aW9uLgoKQ2hhbmdlcyBz
aW5jZSB2NDoKIC0gVXNlIHRoZSBuZXdseSBpbnRyb2R1Y2VkIGlzX2R5aW5n
X2RvbWFpbigpLgogLSBDbGVhciB0aGUgcGFnZSBvd25lciBmaWVsZCBpbiBz
aGFkb3dfZnJlZSgpIGJlZm9yZSByZXR1cm5pbmcgdG8KICAgZG9taGVhcC4K
IC0gVXNlIHByZWVtcHRpb24gaW4gdGhlIHNoYWRvd19ibG93X3RhYmxlcygp
IGNhbGwgaW4KICAgc2hhZG93X3RlYXJkb3duKCkuCgpDaGFuZ2VzIHNpbmNl
IHYzOgogLSBVc2UgRlJFRV9YRU5IRUFQX1BBR0UuCiAtIENsZWFyIHYuc2gu
YmFjayBpbnN0ZWFkIG9mIHRoZSBkb21haW4gb3duZXIgaW4gc2hhZG93X2Zy
ZWUoKS4KIC0gRmFpbCBwcmUtYWxsb2NhdGlvbiBpbiBfc2hhZG93X3ByZWFs
bG9jKCkgd2hlbiBkeWluZy4KCkNoYW5nZXMgc2luY2UgdjI6CiAtIEZyZWUg
bWVtb3J5IHdoZW4gcmV0dXJuZWQgdG8gdGhlIGhhcC9zaGFkb3cgcG9vbCBp
ZiB0aGUgZG9tYWluIGlzCiAgIGR5aW5nLgogLSBSZXN0b3JlIHNoYWRvd190
ZWFyZG93bigpIGNhbGwgaW4gc2hhZG93X2ZpbmFsX3RlYXJkb3duKCkuCiAt
IEV4cGFuZCBjb21taXQgbWVzc2FnZS4KIC0gRG8gbm90IHByaW50IGFuIGVy
cm9yIG1lc3NhZ2UgaWYgcGFnaW5nIGFsbG9jYXRpb24gZmFpbHMgd2hlbiB0
aGUKICAgZG9tYWluIGlzIGR5aW5nLgoKQ2hhbmdlcyBzaW5jZSB2MToKIC0g
Rml4IGNhbGxzIHRvIGFsdHAybV92Y3B1X2Rpc2FibGVfdmUoKS4KIC0gRml4
IHNvbWUgc3R5bGUgaXNzdWVzIG9mIG1vdmVkIGNvZGUuCiAtIEZpeCB7aGFw
LHNoYWRvd31fZmluYWxfdGVhcmRvd24oKSB0byBlbXB0eSB0aGUgcG9vbCwg
aW4gY2FzZSBpdAogICBnZXRzIGNhbGxlZCBmcm9tIHRoZSBmYWlsZWQgZG9t
YWluIGNyZWF0aW9uIHBhdGguCiAtIExlYXZlIHRoZSByb290IHBhZ2UgdGFi
bGUocykgaW4gcGxhY2UgdW50aWwKICAge3NoYWRvdyxoYXB9X2ZpbmFsX3Rl
YXJkb3duKCkuCiAtIFByZXZlbnQgcDJtIG1lbW9yeSBhbGxvY2F0aW9uIGlm
IHRoZSBkb21haW4gaXMgZHlpbmcuCgotLS0gYS94ZW4vYXJjaC94ODYvZG9t
YWluLmMKKysrIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jCkBAIC0zOCw3ICsz
OCw2IEBACiAjaW5jbHVkZSA8eGVuL2xpdmVwYXRjaC5oPgogI2luY2x1ZGUg
PHB1YmxpYy9zeXNjdGwuaD4KICNpbmNsdWRlIDxwdWJsaWMvaHZtL2h2bV92
Y3B1Lmg+Ci0jaW5jbHVkZSA8YXNtL2FsdHAybS5oPgogI2luY2x1ZGUgPGFz
bS9yZWdzLmg+CiAjaW5jbHVkZSA8YXNtL21jMTQ2ODE4cnRjLmg+CiAjaW5j
bHVkZSA8YXNtL3N5c3RlbS5oPgpAQCAtMjQwNiwxMiArMjQwNSw2IEBAIGlu
dCBkb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoc3RydWN0IGQKICAgICAg
ICAgICAgIHZwbXVfZGVzdHJveSh2KTsKICAgICAgICAgfQogCi0gICAgICAg
IGlmICggYWx0cDJtX2FjdGl2ZShkKSApCi0gICAgICAgIHsKLSAgICAgICAg
ICAgIGZvcl9lYWNoX3ZjcHUgKCBkLCB2ICkKLSAgICAgICAgICAgICAgICBh
bHRwMm1fdmNwdV9kaXNhYmxlX3ZlKHYpOwotICAgICAgICB9Ci0KICAgICAg
ICAgaWYgKCBpc19wdl9kb21haW4oZCkgKQogICAgICAgICB7CiAgICAgICAg
ICAgICBmb3JfZWFjaF92Y3B1ICggZCwgdiApCi0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9oYXAvaGFwLmMKKysrIGIveGVuL2FyY2gveDg2L21tL2hhcC9oYXAu
YwpAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgPHhlbi9kb21haW5fcGFn
ZS5oPgogI2luY2x1ZGUgPHhlbi9ndWVzdF9hY2Nlc3MuaD4KICNpbmNsdWRl
IDx4ZW4va2V5aGFuZGxlci5oPgorI2luY2x1ZGUgPGFzbS9hbHRwMm0uaD4K
ICNpbmNsdWRlIDxhc20vZXZlbnQuaD4KICNpbmNsdWRlIDxhc20vcGFnZS5o
PgogI2luY2x1ZGUgPGFzbS9jdXJyZW50Lmg+CkBAIC01NDYsMjQgKzU0Nyw4
IEBAIHZvaWQgaGFwX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQK
ICAgICB1bnNpZ25lZCBpbnQgaTsKIAogICAgIGlmICggaHZtX2FsdHAybV9z
dXBwb3J0ZWQoKSApCi0gICAgewotICAgICAgICBkLT5hcmNoLmFsdHAybV9h
Y3RpdmUgPSAwOwotCi0gICAgICAgIGlmICggZC0+YXJjaC5hbHRwMm1fZXB0
cCApCi0gICAgICAgIHsKLSAgICAgICAgICAgIGZyZWVfeGVuaGVhcF9wYWdl
KGQtPmFyY2guYWx0cDJtX2VwdHApOwotICAgICAgICAgICAgZC0+YXJjaC5h
bHRwMm1fZXB0cCA9IE5VTEw7Ci0gICAgICAgIH0KLQotICAgICAgICBpZiAo
IGQtPmFyY2guYWx0cDJtX3Zpc2libGVfZXB0cCApCi0gICAgICAgIHsKLSAg
ICAgICAgICAgIGZyZWVfeGVuaGVhcF9wYWdlKGQtPmFyY2guYWx0cDJtX3Zp
c2libGVfZXB0cCk7Ci0gICAgICAgICAgICBkLT5hcmNoLmFsdHAybV92aXNp
YmxlX2VwdHAgPSBOVUxMOwotICAgICAgICB9Ci0KICAgICAgICAgZm9yICgg
aSA9IDA7IGkgPCBNQVhfQUxUUDJNOyBpKysgKQogICAgICAgICAgICAgcDJt
X3RlYXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgdHJ1ZSk7Ci0gICAg
fQogCiAgICAgLyogRGVzdHJveSBuZXN0ZWRwMm0ncyBmaXJzdCAqLwogICAg
IGZvciAoaSA9IDA7IGkgPCBNQVhfTkVTVEVEUDJNOyBpKyspIHsKQEAgLTU3
OCw2ICs1NjMsOCBAQCB2b2lkIGhhcF9maW5hbF90ZWFyZG93bihzdHJ1Y3Qg
ZG9tYWluICpkCiAgICAgcGFnaW5nX2xvY2soZCk7CiAgICAgaGFwX3NldF9h
bGxvY2F0aW9uKGQsIDAsIE5VTEwpOwogICAgIEFTU0VSVChkLT5hcmNoLnBh
Z2luZy5oYXAucDJtX3BhZ2VzID09IDApOworICAgIEFTU0VSVChkLT5hcmNo
LnBhZ2luZy5oYXAuZnJlZV9wYWdlcyA9PSAwKTsKKyAgICBBU1NFUlQoZC0+
YXJjaC5wYWdpbmcuaGFwLnRvdGFsX3BhZ2VzID09IDApOwogICAgIHBhZ2lu
Z191bmxvY2soZCk7CiB9CiAKQEAgLTYwMyw2ICs1OTAsNyBAQCB2b2lkIGhh
cF92Y3B1X3RlYXJkb3duKHN0cnVjdCB2Y3B1ICp2KQogdm9pZCBoYXBfdGVh
cmRvd24oc3RydWN0IGRvbWFpbiAqZCwgYm9vbCAqcHJlZW1wdGVkKQogewog
ICAgIHN0cnVjdCB2Y3B1ICp2OworICAgIHVuc2lnbmVkIGludCBpOwogCiAg
ICAgQVNTRVJUKGQtPmlzX2R5aW5nKTsKICAgICBBU1NFUlQoZCAhPSBjdXJy
ZW50LT5kb21haW4pOwpAQCAtNjExLDYgKzU5OSwyOCBAQCB2b2lkIGhhcF90
ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkLCBib29sCiAgICAgZm9yX2VhY2hf
dmNwdSAoIGQsIHYgKQogICAgICAgICBoYXBfdmNwdV90ZWFyZG93bih2KTsK
IAorICAgIC8qIExlYXZlIHRoZSByb290IHB0IGluIGNhc2Ugd2UgZ2V0IGZ1
cnRoZXIgYXR0ZW1wdHMgdG8gbW9kaWZ5IHRoZSBwMm0uICovCisgICAgaWYg
KCBodm1fYWx0cDJtX3N1cHBvcnRlZCgpICkKKyAgICB7CisgICAgICAgIGlm
ICggYWx0cDJtX2FjdGl2ZShkKSApCisgICAgICAgICAgICBmb3JfZWFjaF92
Y3B1ICggZCwgdiApCisgICAgICAgICAgICAgICAgYWx0cDJtX3ZjcHVfZGlz
YWJsZV92ZSh2KTsKKworICAgICAgICBkLT5hcmNoLmFsdHAybV9hY3RpdmUg
PSAwOworCisgICAgICAgIEZSRUVfWEVOSEVBUF9QQUdFKGQtPmFyY2guYWx0
cDJtX2VwdHApOworICAgICAgICBGUkVFX1hFTkhFQVBfUEFHRShkLT5hcmNo
LmFsdHAybV92aXNpYmxlX2VwdHApOworCisgICAgICAgIGZvciAoIGkgPSAw
OyBpIDwgTUFYX0FMVFAyTTsgaSsrICkKKyAgICAgICAgICAgIHAybV90ZWFy
ZG93bihkLT5hcmNoLmFsdHAybV9wMm1baV0sIGZhbHNlKTsKKyAgICB9CisK
KyAgICAvKiBEZXN0cm95IG5lc3RlZHAybSdzIGFmdGVyIGFsdHAybS4gKi8K
KyAgICBmb3IgKCBpID0gMDsgaSA8IE1BWF9ORVNURURQMk07IGkrKyApCisg
ICAgICAgIHAybV90ZWFyZG93bihkLT5hcmNoLm5lc3RlZF9wMm1baV0sIGZh
bHNlKTsKKworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCks
IGZhbHNlKTsKKwogICAgIHBhZ2luZ19sb2NrKGQpOyAvKiBLZWVwIHZhcmlv
dXMgYXNzZXJ0cyBoYXBweSAqLwogCiAgICAgaWYgKCBkLT5hcmNoLnBhZ2lu
Zy5oYXAudG90YWxfcGFnZXMgIT0gMCApCi0tLSBhL3hlbi9hcmNoL3g4Ni9t
bS9zaGFkb3cvY29tbW9uLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRv
dy9jb21tb24uYwpAQCAtMjgzMSw4ICsyODMxLDE3IEBAIHZvaWQgc2hhZG93
X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQsIGIKICAgICBmb3JfZWFjaF92
Y3B1ICggZCwgdiApCiAgICAgICAgIHNoYWRvd192Y3B1X3RlYXJkb3duKHYp
OwogCisgICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9zdHAybShkKSwgZmFs
c2UpOworCiAgICAgcGFnaW5nX2xvY2soZCk7CiAKKyAgICAvKgorICAgICAq
IFJlY2xhaW0gYWxsIHNoYWRvdyBtZW1vcnkgc28gdGhhdCBzaGFkb3dfc2V0
X2FsbG9jYXRpb24oKSBkb2Vzbid0IGZpbmQKKyAgICAgKiBpbi11c2UgcGFn
ZXMsIGFzIF9zaGFkb3dfcHJlYWxsb2MoKSB3aWxsIG5vIGxvbmdlciB0cnkg
dG8gcmVjbGFpbSBwYWdlcworICAgICAqIGJlY2F1c2UgdGhlIGRvbWFpbiBp
cyBkeWluZy4KKyAgICAgKi8KKyAgICBzaGFkb3dfYmxvd190YWJsZXMoZCk7
CisKICNpZiAoU0hBRE9XX09QVElNSVpBVElPTlMgJiAoU0hPUFRfVklSVFVB
TF9UTEJ8U0hPUFRfT1VUX09GX1NZTkMpKQogICAgIC8qIEZyZWUgdGhlIHZp
cnR1YWwtVExCIGFycmF5IGF0dGFjaGVkIHRvIGVhY2ggdmNwdSAqLwogICAg
IGZvcl9lYWNoX3ZjcHUoZCwgdikKQEAgLTI5NTMsNiArMjk2Miw5IEBAIHZv
aWQgc2hhZG93X2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4KICAgICAg
ICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5zaGFkb3cudG90YWxfcGFn
ZXMsCiAgICAgICAgICAgICAgICAgICAgZC0+YXJjaC5wYWdpbmcuc2hhZG93
LmZyZWVfcGFnZXMsCiAgICAgICAgICAgICAgICAgICAgZC0+YXJjaC5wYWdp
bmcuc2hhZG93LnAybV9wYWdlcyk7CisgICAgQVNTRVJUKCFkLT5hcmNoLnBh
Z2luZy5zaGFkb3cudG90YWxfcGFnZXMpOworICAgIEFTU0VSVCghZC0+YXJj
aC5wYWdpbmcuc2hhZG93LmZyZWVfcGFnZXMpOworICAgIEFTU0VSVCghZC0+
YXJjaC5wYWdpbmcuc2hhZG93LnAybV9wYWdlcyk7CiAgICAgcGFnaW5nX3Vu
bG9jayhkKTsKIH0KIAo=

--=separator
Content-Type: application/octet-stream; name="xsa410/xsa410-10.patch"
Content-Disposition: attachment; filename="xsa410/xsa410-10.patch"
Content-Transfer-Encoding: base64

RnJvbTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU3ViamVj
dDogeGVuL3g4NjogcDJtOiBBZGQgcHJlZW1wdGlvbiBpbiBwMm1fdGVhcmRv
d24oKQoKVGhlIGxpc3QgcDJtLT5wYWdlcyBjb250YWluIGFsbCB0aGUgcGFn
ZXMgdXNlZCBieSB0aGUgUDJNLiBPbiBsYXJnZQppbnN0YW5jZSB0aGlzIGNh
biBiZSBxdWl0ZSBsYXJnZSBhbmQgdGhlIHRpbWUgc3BlbnQgdG8gY2FsbApk
LT5hcmNoLnBhZ2luZy5mcmVlX3BhZ2UoKSB3aWxsIHRha2UgbW9yZSB0aGFu
IDFtcyBmb3IgYSA4MEdCIGd1ZXN0Cm9uIGEgWGVuIHJ1bm5pbmcgaW4gbmVz
dGVkIGVudmlyb25tZW50IG9uIGEgYzUubWV0YWwuCgpCeSBleHRyYXBvbGF0
aW9uLCBpdCB3b3VsZCB0YWtlID4gMTAwbXMgZm9yIGEgOFRCIGd1ZXN0ICh3
aGF0IHdlCmN1cnJlbnQgc2VjdXJpdHkgc3VwcG9ydCkuIFNvIGFkZCBzb21l
IHByZWVtcHRpb24gaW4gcDJtX3RlYXJkb3duKCkKYW5kIHByb3BhZ2F0ZSB0
byB0aGUgY2FsbGVycy4gTm90ZSB0aGVyZSBhcmUgMyBwbGFjZXMgd2hlcmUK
dGhlIHByZWVtcHRpb24gaXMgbm90IGVuYWJsZWQ6CiAgICAtIGhhcF9maW5h
bF90ZWFyZG93bigpL3NoYWRvd19maW5hbF90ZWFyZG93bigpOiBXZSBhcmUK
ICAgICAgcHJldmVudGluZyB1cGRhdGUgdGhlIFAyTSBvbmNlIHRoZSBkb21h
aW4gaXMgZHlpbmcgKHNvCiAgICAgIG5vIG1vcmUgcGFnZXMgY291bGQgYmUg
YWxsb2NhdGVkKSBhbmQgbW9zdCBvZiB0aGUgUDJNIHBhZ2VzCiAgICAgIHdp
bGwgYmUgZnJlZWQgaW4gcHJlZW1wdGl2ZSBtYW5uZWVyIHdoZW4gcmVsaW5x
dWlzaGluZyB0aGUKICAgICAgcmVzb3VyY2VzLiBTbyB0aGlzIGlzIGZpbmUg
dG8gZGlzYWJsZSBwcmVlbXB0aW9uLgogICAgLSBzaGFkb3dfZW5hYmxlKCk6
IFRoaXMgaXMgZmluZSBiZWNhdXNlIGl0IHdpbGwgdW5kbyB0aGUgYWxsb2Nh
dGlvbgogICAgICB0aGF0IG1heSBoYXZlIGJlZW4gbWFkZSBieSBwMm1fYWxs
b2NfdGFibGUoKSAoc28gb25seSB0aGUgcm9vdAogICAgICBwYWdlIHRhYmxl
KS4KClRoZSBwcmVlbXB0aW9uIGlzIGFyYml0cmFyaWx5IGNoZWNrZWQgZXZl
cnkgMTAyNCBpdGVyYXRpb25zLgoKV2Ugbm93IG5lZWQgdG8gaW5jbHVkZSA8
eGVuL2V2ZW50Lmg+IGluIHAybS1iYXNpYyBpbiBvcmRlciB0bwppbXBvcnQg
dGhlIGRlZmluaXRpb24gZm9yIGxvY2FsX2V2ZW50c19uZWVkX2RlbGl2ZXJ5
KCkgdXNlZCBieQpnZW5lcmFsX3ByZWVtcHRfY2hlY2soKS4gSWRlYWxseSwg
dGhlIGluY2x1c2lvbiBzaG91bGQgaGFwcGVuIGluCnhlbi9zY2hlZC5oIGJ1
dCBpdCBvcGVuZWQgYSBjYW4gb2Ygd29ybXMuCgpOb3RlIHRoYXQgd2l0aCB0
aGUgY3VycmVudCBhcHByb2FjaCwgWGVuIGRvZXNuJ3Qga2VlcCB0cmFjayBv
biB3aGV0aGVyCnRoZSBhbHQvbmVzdGVkIFAyTXMgaGF2ZSBiZWVuIGNsZWFy
ZWQuIFNvIHRoZXJlIGFyZSBzb21lIHJlZHVuZGFudCB3b3JrLgpIb3dldmVy
LCB0aGlzIGlzIG5vdCBleHBlY3RlZCB0byBpbmN1cnIgdG9vIG11Y2ggb3Zl
cmhlYWQgKHRoZSBQMk0gbG9jawpzaG91bGRuJ3QgYmUgY29udGVuZGVkIGR1
cmluZyB0ZWFyZG93bikuIFNvIHRoaXMgaXMgb3B0aW1pemF0aW9uIGlzCmxl
ZnQgb3V0c2lkZSBvZiB0aGUgc2VjdXJpdHkgZXZlbnQuCgpUaGlzIGlzIHBh
cnQgb2YgQ1ZFLTIwMjItMzM3NDYgLyBYU0EtNDEwLgoKU2lnbmVkLW9mZi1i
eTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KU2lnbmVkLW9m
Zi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgotLS0tCkNo
YW5nZXMgc2luY2UgdjEyOgogICAgLSBDb3JyZWN0IGFsdHAybSBwcmVlbXB0
aW9uIGNoZWNrIHBsYWNlbWVudC4KCkNoYW5nZXMgc2luY2Ugdjk6CiAgICAt
IEludGVncmF0ZSBwYXRjaCBpbnRvIHNlcmllcy4KCkNoYW5nZXMgc2luY2Ug
djI6CiAgICAtIFJld29yayB0aGUgbG9vcCBkb2luZyB0aGUgcHJlZW1wdGlv
bgogICAgLSBBZGQgYSBjb21tZW50IGluIHNoYWRvd19lbmFibGUoKSB0byBl
eHBsYWluIHdoeSBwMm1fdGVhcmRvd24oKQogICAgICBkb2Vzbid0IG5lZWQg
dG8gYmUgcHJlZW1wdGlibGUuCgpDaGFuZ2VzIHNpbmNlIHYxOgogICAgLSBV
cGRhdGUgdGhlIGNvbW1pdCBtZXNzYWdlCiAgICAtIFJlYmFzZSBvbiB0b3Ag
b2YgUm9nZXIncyB2OCBzZXJpZXMKICAgIC0gRml4IHByZWVtcHRpb24gY2hl
Y2sKICAgIC0gVXNlICd1bnNpZ25lZCBpbnQnIHJhdGhlciB0aGFuICd1bnNp
Z25lZCBsb25nJyBmb3IgdGhlIGNvdW50ZXIKCi0tLSBhL3hlbi9hcmNoL3g4
Ni9pbmNsdWRlL2FzbS9wMm0uaAorKysgYi94ZW4vYXJjaC94ODYvaW5jbHVk
ZS9hc20vcDJtLmgKQEAgLTYwMCw3ICs2MDAsNyBAQCBpbnQgcDJtX2luaXQo
c3RydWN0IGRvbWFpbiAqZCk7CiBpbnQgcDJtX2FsbG9jX3RhYmxlKHN0cnVj
dCBwMm1fZG9tYWluICpwMm0pOwogCiAvKiBSZXR1cm4gYWxsIHRoZSBwMm0g
cmVzb3VyY2VzIHRvIFhlbi4gKi8KLXZvaWQgcDJtX3RlYXJkb3duKHN0cnVj
dCBwMm1fZG9tYWluICpwMm0sIGJvb2wgcmVtb3ZlX3Jvb3QpOwordm9pZCBw
Mm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybSwgYm9vbCByZW1v
dmVfcm9vdCwgYm9vbCAqcHJlZW1wdGVkKTsKIHZvaWQgcDJtX2ZpbmFsX3Rl
YXJkb3duKHN0cnVjdCBkb21haW4gKmQpOwogCiAvKiBBZGQvcmVtb3ZlIGEg
cGFnZSB0by9mcm9tIGEgZG9tYWluJ3MgcDJtIHRhYmxlLiAqLwotLS0gYS94
ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9t
bS9oYXAvaGFwLmMKQEAgLTU0OCwxNyArNTQ4LDE3IEBAIHZvaWQgaGFwX2Zp
bmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQKIAogICAgIGlmICggaHZt
X2FsdHAybV9zdXBwb3J0ZWQoKSApCiAgICAgICAgIGZvciAoIGkgPSAwOyBp
IDwgTUFYX0FMVFAyTTsgaSsrICkKLSAgICAgICAgICAgIHAybV90ZWFyZG93
bihkLT5hcmNoLmFsdHAybV9wMm1baV0sIHRydWUpOworICAgICAgICAgICAg
cDJtX3RlYXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgdHJ1ZSwgTlVM
TCk7CiAKICAgICAvKiBEZXN0cm95IG5lc3RlZHAybSdzIGZpcnN0ICovCiAg
ICAgZm9yIChpID0gMDsgaSA8IE1BWF9ORVNURURQMk07IGkrKykgewotICAg
ICAgICBwMm1fdGVhcmRvd24oZC0+YXJjaC5uZXN0ZWRfcDJtW2ldLCB0cnVl
KTsKKyAgICAgICAgcDJtX3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtp
XSwgdHJ1ZSwgTlVMTCk7CiAgICAgfQogCiAgICAgaWYgKCBkLT5hcmNoLnBh
Z2luZy5oYXAudG90YWxfcGFnZXMgIT0gMCApCiAgICAgICAgIGhhcF90ZWFy
ZG93bihkLCBOVUxMKTsKIAotICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hv
c3RwMm0oZCksIHRydWUpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hv
c3RwMm0oZCksIHRydWUsIE5VTEwpOwogICAgIC8qIEZyZWUgYW55IG1lbW9y
eSB0aGF0IHRoZSBwMm0gdGVhcmRvd24gcmVsZWFzZWQgKi8KICAgICBwYWdp
bmdfbG9jayhkKTsKICAgICBoYXBfc2V0X2FsbG9jYXRpb24oZCwgMCwgTlVM
TCk7CkBAIC02MTIsMTQgKzYxMiwyNCBAQCB2b2lkIGhhcF90ZWFyZG93bihz
dHJ1Y3QgZG9tYWluICpkLCBib29sCiAgICAgICAgIEZSRUVfWEVOSEVBUF9Q
QUdFKGQtPmFyY2guYWx0cDJtX3Zpc2libGVfZXB0cCk7CiAKICAgICAgICAg
Zm9yICggaSA9IDA7IGkgPCBNQVhfQUxUUDJNOyBpKysgKQotICAgICAgICAg
ICAgcDJtX3RlYXJkb3duKGQtPmFyY2guYWx0cDJtX3AybVtpXSwgZmFsc2Up
OworICAgICAgICB7CisgICAgICAgICAgICBwMm1fdGVhcmRvd24oZC0+YXJj
aC5hbHRwMm1fcDJtW2ldLCBmYWxzZSwgcHJlZW1wdGVkKTsKKyAgICAgICAg
ICAgIGlmICggcHJlZW1wdGVkICYmICpwcmVlbXB0ZWQgKQorICAgICAgICAg
ICAgICAgIHJldHVybjsKKyAgICAgICAgfQogICAgIH0KIAogICAgIC8qIERl
c3Ryb3kgbmVzdGVkcDJtJ3MgYWZ0ZXIgYWx0cDJtLiAqLwogICAgIGZvciAo
IGkgPSAwOyBpIDwgTUFYX05FU1RFRFAyTTsgaSsrICkKLSAgICAgICAgcDJt
X3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtpXSwgZmFsc2UpOworICAg
IHsKKyAgICAgICAgcDJtX3RlYXJkb3duKGQtPmFyY2gubmVzdGVkX3AybVtp
XSwgZmFsc2UsIHByZWVtcHRlZCk7CisgICAgICAgIGlmICggcHJlZW1wdGVk
ICYmICpwcmVlbXB0ZWQgKQorICAgICAgICAgICAgcmV0dXJuOworICAgIH0K
IAotICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIGZhbHNl
KTsKKyAgICBwMm1fdGVhcmRvd24ocDJtX2dldF9ob3N0cDJtKGQpLCBmYWxz
ZSwgcHJlZW1wdGVkKTsKKyAgICBpZiAoIHByZWVtcHRlZCAmJiAqcHJlZW1w
dGVkICkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgcGFnaW5nX2xvY2soZCk7
IC8qIEtlZXAgdmFyaW91cyBhc3NlcnRzIGhhcHB5ICovCiAKLS0tIGEveGVu
L2FyY2gveDg2L21tL3AybS1iYXNpYy5jCisrKyBiL3hlbi9hcmNoL3g4Ni9t
bS9wMm0tYmFzaWMuYwpAQCAtMjMsNiArMjMsNyBAQAogICogYWxvbmcgd2l0
aCB0aGlzIHByb2dyYW07IElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5v
cmcvbGljZW5zZXMvPi4KICAqLwogCisjaW5jbHVkZSA8eGVuL2V2ZW50Lmg+
CiAjaW5jbHVkZSA8eGVuL3R5cGVzLmg+CiAjaW5jbHVkZSA8YXNtL3AybS5o
PgogI2luY2x1ZGUgIm1tLWxvY2tzLmgiCkBAIC0xNTQsMTEgKzE1NSwxMiBA
QCBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCkKICAqIGh2bSBmaXht
ZTogd2hlbiBhZGRpbmcgc3VwcG9ydCBmb3IgcHZoIG5vbi1oYXJkd2FyZSBk
b21haW5zLCB0aGlzIHBhdGggbXVzdAogICogY2xlYW51cCBhbnkgZm9yZWln
biBwMm0gdHlwZXMgKHJlbGVhc2UgcmVmY250cyBvbiB0aGVtKS4KICAqLwot
dm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybSwgYm9v
bCByZW1vdmVfcm9vdCkKK3ZvaWQgcDJtX3RlYXJkb3duKHN0cnVjdCBwMm1f
ZG9tYWluICpwMm0sIGJvb2wgcmVtb3ZlX3Jvb3QsIGJvb2wgKnByZWVtcHRl
ZCkKIHsKICNpZmRlZiBDT05GSUdfSFZNCiAgICAgc3RydWN0IHBhZ2VfaW5m
byAqcGcsICpyb290X3BnID0gTlVMTDsKICAgICBzdHJ1Y3QgZG9tYWluICpk
OworICAgIHVuc2lnbmVkIGludCBpID0gMDsKIAogICAgIGlmICggIXAybSAp
CiAgICAgICAgIHJldHVybjsKQEAgLTE4MCw4ICsxODIsMTkgQEAgdm9pZCBw
Mm1fdGVhcmRvd24oc3RydWN0IHAybV9kb21haW4gKnAybQogICAgIH0KIAog
ICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZwMm0t
PnBhZ2VzKSkgKQotICAgICAgICBpZiAoIHBnICE9IHJvb3RfcGcgKQotICAg
ICAgICAgICAgZC0+YXJjaC5wYWdpbmcuZnJlZV9wYWdlKGQsIHBnKTsKKyAg
ICB7CisgICAgICAgIGlmICggcGcgPT0gcm9vdF9wZyApCisgICAgICAgICAg
ICBjb250aW51ZTsKKworICAgICAgICBkLT5hcmNoLnBhZ2luZy5mcmVlX3Bh
Z2UoZCwgcGcpOworCisgICAgICAgIC8qIEFyYml0cmFyaWx5IGNoZWNrIHBy
ZWVtcHRpb24gZXZlcnkgMTAyNCBpdGVyYXRpb25zICovCisgICAgICAgIGlm
ICggcHJlZW1wdGVkICYmICEoKytpICUgMTAyNCkgJiYgZ2VuZXJhbF9wcmVl
bXB0X2NoZWNrKCkgKQorICAgICAgICB7CisgICAgICAgICAgICAqcHJlZW1w
dGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9Cisg
ICAgfQogCiAgICAgaWYgKCByb290X3BnICkKICAgICAgICAgcGFnZV9saXN0
X2FkZChyb290X3BnLCAmcDJtLT5wYWdlcyk7Ci0tLSBhL3hlbi9hcmNoL3g4
Ni9tbS9zaGFkb3cvY29tbW9uLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3No
YWRvdy9jb21tb24uYwpAQCAtMjc3Niw4ICsyNzc2LDEyIEBAIGludCBzaGFk
b3dfZW5hYmxlKHN0cnVjdCBkb21haW4gKmQsIHUzMgogICAgIHBhZ2luZ191
bmxvY2soZCk7CiAgb3V0X3VubG9ja2VkOgogI2lmZGVmIENPTkZJR19IVk0K
KyAgICAvKgorICAgICAqIFRoaXMgaXMgZmluZSB0byBpZ25vcmUgdGhlIHBy
ZWVtcHRpb24gaGVyZSBiZWNhdXNlIG9ubHkgdGhlIHJvb3QKKyAgICAgKiB3
aWxsIGJlIGFsbG9jYXRlZCBieSBwMm1fYWxsb2NfdGFibGUoKS4KKyAgICAg
Ki8KICAgICBpZiAoIHJ2ICE9IDAgJiYgIXBhZ2V0YWJsZV9pc19udWxsKHAy
bV9nZXRfcGFnZXRhYmxlKHAybSkpICkKLSAgICAgICAgcDJtX3RlYXJkb3du
KHAybSwgdHJ1ZSk7CisgICAgICAgIHAybV90ZWFyZG93bihwMm0sIHRydWUs
IE5VTEwpOwogI2VuZGlmCiAgICAgaWYgKCBydiAhPSAwICYmIHBnICE9IE5V
TEwgKQogICAgIHsKQEAgLTI4MzEsNyArMjgzNSw5IEBAIHZvaWQgc2hhZG93
X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQsIGIKICAgICBmb3JfZWFjaF92
Y3B1ICggZCwgdiApCiAgICAgICAgIHNoYWRvd192Y3B1X3RlYXJkb3duKHYp
OwogCi0gICAgcDJtX3RlYXJkb3duKHAybV9nZXRfaG9zdHAybShkKSwgZmFs
c2UpOworICAgIHAybV90ZWFyZG93bihwMm1fZ2V0X2hvc3RwMm0oZCksIGZh
bHNlLCBwcmVlbXB0ZWQpOworICAgIGlmICggcHJlZW1wdGVkICYmICpwcmVl
bXB0ZWQgKQorICAgICAgICByZXR1cm47CiAKICAgICBwYWdpbmdfbG9jayhk
KTsKIApAQCAtMjk1Miw3ICsyOTU4LDcgQEAgdm9pZCBzaGFkb3dfZmluYWxf
dGVhcmRvd24oc3RydWN0IGRvbWFpbgogICAgICAgICBzaGFkb3dfdGVhcmRv
d24oZCwgTlVMTCk7CiAKICAgICAvKiBJdCBpcyBub3cgc2FmZSB0byBwdWxs
IGRvd24gdGhlIHAybSBtYXAuICovCi0gICAgcDJtX3RlYXJkb3duKHAybV9n
ZXRfaG9zdHAybShkKSwgdHJ1ZSk7CisgICAgcDJtX3RlYXJkb3duKHAybV9n
ZXRfaG9zdHAybShkKSwgdHJ1ZSwgTlVMTCk7CiAgICAgLyogRnJlZSBhbnkg
c2hhZG93IG1lbW9yeSB0aGF0IHRoZSBwMm0gdGVhcmRvd24gcmVsZWFzZWQg
Ki8KICAgICBwYWdpbmdfbG9jayhkKTsKICAgICBzaGFkb3dfc2V0X2FsbG9j
YXRpb24oZCwgMCwgTlVMTCk7Cg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419736.664640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE1s-0005pu-B5; Tue, 11 Oct 2022 12:06:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419736.664640; Tue, 11 Oct 2022 12:06:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE1s-0005pa-5y; Tue, 11 Oct 2022 12:06:36 +0000
Received: by outflank-mailman (input) for mailman id 419736;
 Tue, 11 Oct 2022 12:06:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4MZe=2M=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1oiE1p-0004Vk-Ax
 for xen-devel@lists.xen.org; Tue, 11 Oct 2022 12:06:34 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 243dd65b-495d-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 14:06:31 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE1a-0000lU-1p; Tue, 11 Oct 2022 12:06:18 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE1a-00035H-0H; Tue, 11 Oct 2022 12:06:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 243dd65b-495d-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=u9s7KbjDl2ik+N56tmQDc+Q2GInY2Vgmmhj4qbHHE9I=; b=6pvESZUSUHuzaKBgJKyAySRGMz
	gpG5ulDavxahl4H9ghuXd/h51JMyYTUkz/vhO7+8jjXu+ydQF2N6cIgqk4dzX7zoCjcuM2+GOgRAc
	6SAML5ZTusz1wyibFXr257bDhIH4F7mVw67r4oXHz93svwFvs+yp3RTQYRCrwnNyNmvk=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 409 v3 (CVE-2022-33747) - Arm: unbounded
 memory consumption for 2nd-level page tables
Message-Id: <E1oiE1a-00035H-0H@xenbits.xenproject.org>
Date: Tue, 11 Oct 2022 12:06:18 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2022-33747 / XSA-409
                               version 3

      Arm: unbounded memory consumption for 2nd-level page tables

UPDATES IN VERSION 3
====================

Public release.

ISSUE DESCRIPTION
=================

Certain actions require e.g. removing pages from a guest's P2M
(Physical-to-Machine) mapping.  When large pages are in use to map guest
pages in the 2nd-stage page tables, such a removal operation may incur a
memory allocation (to replace a large mapping with individual smaller
ones).

These memory allocations are taken from the global memory pool. A
malicious guest might be able to cause the global memory pool to be
exhausted by manipulating its own P2M mappings.

IMPACT
======

A malicious guest could cause a Denial of Service, preventing any system
operation requiring further allocation of Xen memory, including creating
new guests.  NB however that memory exhaustion by itself shouldn’t cause
either Xen or properly-written guests to crash.

VULNERABLE SYSTEMS
==================

All versions of Xen are affected.

Only Arm systems are vulnerable.  x86 systems are not vulnerable.

MITIGATION
==========

There is no known mitigation.

RESOLUTION
==========

Applying the appropriate set of attached patches resolves this issue.

Note that patches for released versions are generally prepared to
apply to the stable branches, and may not apply cleanly to the most
recent release tarball.  Downstreams are encouraged to update to the
tip of the stable branch before applying these patches.

Note further that the patches for this XSA depend on the patches for
XSA-410.

xsa409/*.patch           xen-unstable
xsa409-4.16/*.patch      Xen 4.16.x
xsa409-4.15/*.patch      Xen 4.15.x
xsa409-4.14/*.patch      Xen 4.14.x
xsa409-4.13/*.patch      Xen 4.13.x

$ sha256sum xsa409* xsa409*/*
a211afb31199a8edf189928f5285b6a58ce35aac991ae3f708b07274ad5f1082  xsa409.meta
96cc260fbf3c2bedd17d61080ba536791f1116cd7dcc6a172dbcccc452e66974  xsa409-4.13/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch
f94376d12757312175e19b6c51c56bcb3e21055f729440eb9112bee9fc44cd65  xsa409-4.13/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch
b52ca6538a0525dc1638391ee032a7aedced31cc3bcdc8efea02d975813fa251  xsa409-4.13/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch
5a59740c398804950ce99102ae2741d5d539313e4a24d0727926d2b4965f148e  xsa409-4.13/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch
b7c3438a4c6a4957b0e9b911419638c8719550c91db4587660a6d498a73747ae  xsa409-4.14/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch
5a01d80c7157feeeb3374c221d306bd98a134a99597ebfdeee5d62df47e60f27  xsa409-4.14/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch
d9b4385c1d55f9c758a108368ef5fbfc86ab2ff532314f88245cc1fce4f95ea2  xsa409-4.14/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch
96456aea63d6471888b5364330e69c15ffd2ed055200cd286fb59cab379c3905  xsa409-4.14/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch
4c31fd8b3f346e6e9834c33e61037d122b802a83dceec168ed5e699566ca01e2  xsa409-4.15/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch
4b9b1ba9c5c7a644268500906b628664ea0630777653f86e62faf85d9e004b8c  xsa409-4.15/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch
04a097e055e7faf9163e1e7105bfb3a78782fa6e9c3025597725a198d85d9887  xsa409-4.15/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch
9b59622a9c00d75fe3f57b20d286e91df3589855d55e0bad83c64145002c3bc7  xsa409-4.15/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch
2ce57902cff4ad61432b61bf8a10dcc699b88b6b9a02c6e7c51c720b276ec39d  xsa409-4.16/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch
18ad838d9c4a6da8890d5d6b3165000e21d8db022bc743989dfda6cc43a7686c  xsa409-4.16/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch
201bf6c15d0380f4588a12f33bff90f05fe3c8da75dcb0801063216bedcc00c7  xsa409-4.16/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch
f8cea9b75636e73ffffb88b18d80f60ab9ca47856232f1cff787d5d0a1742106  xsa409-4.16/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch
62be1c9896e1a0563abbe515bd50e117147a274b3bae0ce062d1e86cdd535b61  xsa409/0001-libxl-docs-Add-per-arch-extra-default-paging-memory.patch
6bcd3cdd9eb998f5714b1c44d3cf1aaa3b1f3615ef8ccb530cf804638b18c9e3  xsa409/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch
b4740035de11fc0b4b7bcb281b288b1972ef3b97649ff3e61072384aeddf864b  xsa409/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch
ac7af4fea2fa84384fd65308ee8cb50470515a96d2160e467867c8bb766b580a  xsa409/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches and/or mitigations described above (or
others which are substantially similar) is permitted during the
embargo, even on public-facing systems with untrusted guest users and
administrators.

But: Distribution of updated software is prohibited (except to other
members of the predisclosure list).

Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.

(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNFS/cMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZKqsIAMobhnQXNUKRUiS1TFrV5NhbUdx0r0PHX3alf3r0
ZUk3mQyq3lKK6MkXB0bpkgq95fv6dw9SIriPRZdivVBK7Yb2VBImdZ/YyXoU5JWN
3EPO8Svxzm8WCntk9smjwNix2SByWSVjQfROjrrgihWLbX4n0IQkOLFlvVgllJmK
ETc0q3bMKEODH7+kkmrTmT+nomlHbuq7HHAZk0jyw/hVs1JdRMN9TXBBdLjLOYFe
/hsDiLWwK51L7ehPZB4d/+rLQYo27chGwNGQwDDXXiWWhMmXJJCO3MhrB4NEt0JE
P4DAkmh2OXh6QyuZPTH48ADbAdL7ecq2atrM6HD2oulwFCI=
=/zM/
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa409.meta"
Content-Disposition: attachment; filename="xsa409.meta"
Content-Transfer-Encoding: base64

ewogICJYU0EiOiA0MDksCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg
Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs
CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK
ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6
IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJk
OGE2OTMwMTk4NDVjYWE0ZTIxNmJjYWMxMGY5NTAxYTgxNGM5OWFlIiwKICAg
ICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICA0MTAKICAgICAgICAg
IF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQw
OS00LjEzLyoucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9
CiAgICB9LAogICAgIjQuMTQiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAg
ICAgICJ4ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogIjI2MWI4ODJm
NzcwNDUxNWEwMWY3NDU4OWY1N2YwYzEzMDNlM2I3MDEiLAogICAgICAgICAg
IlByZXJlcXMiOiBbCiAgICAgICAgICAgIDQxMAogICAgICAgICAgXSwKICAg
ICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDA5LTQuMTQv
Ki5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0s
CiAgICAiNC4xNSI6IHsKICAgICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhl
biI6IHsKICAgICAgICAgICJTdGFibGVSZWYiOiAiZGYzMzk1ZjZiMmQ3NTlh
YmEzOWZiNjdhN2JjMGZlNDkxNDdjOGIzOSIsCiAgICAgICAgICAiUHJlcmVx
cyI6IFsKICAgICAgICAgICAgNDEwCiAgICAgICAgICBdLAogICAgICAgICAg
IlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MDktNC4xNS8qLnBhdGNo
IgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0
LjE2IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewog
ICAgICAgICAgIlN0YWJsZVJlZiI6ICI4OWZlNmQwZWRlYTg0MWQxZDI2OTBj
ZjNmNTE3M2UzMzRjNjg3ODIzIiwKICAgICAgICAgICJQcmVyZXFzIjogWwog
ICAgICAgICAgICA0MTAKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hl
cyI6IFsKICAgICAgICAgICAgInhzYTQwOS00LjE2LyoucGF0Y2giCiAgICAg
ICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAogICAgIm1hc3RlciI6
IHsKICAgICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhlbiI6IHsKICAgICAg
ICAgICJTdGFibGVSZWYiOiAiMDFjYTI5ZjBiMTdhNTBhOTRiMGUyMzJiYTI3
NmMzMmU5NWQ4MGFlMyIsCiAgICAgICAgICAiUHJlcmVxcyI6IFsKICAgICAg
ICAgICAgNDEwCiAgICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBb
CiAgICAgICAgICAgICJ4c2E0MDkvKi5wYXRjaCIKICAgICAgICAgIF0KICAg
ICAgICB9CiAgICAgIH0KICAgIH0KICB9Cn0=

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.13/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Disposition: attachment;
 filename="xsa409-4.13/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Transfer-Encoding: base64

RnJvbSAyZDU1YWNlYzQ5YjY3MTRmZDdjZTQyYmQ4MjU1MjQ1NDE2MTNiOThm
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IFR1ZSwgOSBBdWcgMjAyMiAwNjoz
OToyMyArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMS80XSBsaWJ4bCwgZG9jczog
VXNlIGFyY2gtc3BlY2lmaWMgZGVmYXVsdCBwYWdpbmcgbWVtb3J5CgpUaGUg
ZGVmYXVsdCBwYWdpbmcgbWVtb3J5IChkZXNjaWJlZCBpbiBgc2hhZG93X21l
bW9yeWAgZW50cnkgaW4geGwKY29uZmlnKSBpbiBsaWJ4bCBpcyB1c2VkIHRv
IGRldGVybWluZSB0aGUgbWVtb3J5IHBvb2wgc2l6ZSBmb3IgeGwKZ3Vlc3Rz
LiBDdXJyZW50bHkgdGhpcyBzaXplIGlzIG9ubHkgdXNlZCBmb3IgeDg2LCBh
bmQgY29udGFpbnMgYSBwYXJ0Cm9mIFJBTSB0byBzaGFkb3cgdGhlIHJlc2lk
ZW50IHByb2Nlc3Nlcy4gU2luY2Ugb24gQXJtIHRoZXJlIGlzIG5vCnNoYWRv
dyBtb2RlIGd1ZXN0cywgc28gdGhlIHBhcnQgb2YgUkFNIHRvIHNoYWRvdyB0
aGUgcmVzaWRlbnQgcHJvY2Vzc2VzCmlzIG5vdCBuZWNlc3NhcnkuIFRoZXJl
Zm9yZSwgdGhpcyBjb21taXQgc3BsaXRzIHRoZSBmdW5jdGlvbgpgbGlieGxf
Z2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkoKWAgdG8gYXJjaCBzcGVjaWZp
YyBoZWxwZXJzIGFuZApyZW5hbWVkIHRoZSBoZWxwZXIgdG8gYGxpYnhsX19h
cmNoX2dldF9yZXF1aXJlZF9wYWdpbmdfbWVtb3J5KClgLgoKT24geDg2LCB0
aGlzIGhlbHBlciBjYWxscyB0aGUgb3JpZ2luYWwgdmFsdWUgZnJvbQpgbGli
eGxfZ2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkoKWAgc28gbm8gZnVuY3Rp
b25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpPbiBBcm0sIHRoaXMgaGVscGVyIHJl
dHVybnMgMU1CIHBlciB2Y3B1IHBsdXMgNEtCIHBlciBNaUIgb2YgUkFNCmZv
ciB0aGUgUDJNIG1hcC4KCkFsc28gdXBkYXRlIHRoZSB4bC5jZmcgZG9jdW1l
bnRhdGlvbiB0byBhZGQgQXJtIGRvY3VtZW50YXRpb24KYWNjb3JkaW5nIHRv
IGNvZGUgY2hhbmdlcyBhbmQgY29ycmVjdCB0aGUgY29tbWVudCBzdHlsZSBm
b2xsb3dpbmcgWGVuCmNvZGluZyBzdHlsZS4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTdWdnZXN0ZWQtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEhl
bnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQtYnk6IEFu
dGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0K
IGRvY3MvbWFuL3hsLmNmZy41LnBvZC5pbiAgfCAgNSArKysrKwogdG9vbHMv
bGlieGwvbGlieGxfYXJjaC5oICB8ICA0ICsrKysKIHRvb2xzL2xpYnhsL2xp
YnhsX2FybS5jICAgfCAxMiArKysrKysrKysrKysKIHRvb2xzL2xpYnhsL2xp
YnhsX3V0aWxzLmMgfCAgOSArKy0tLS0tLS0KIHRvb2xzL2xpYnhsL2xpYnhs
X3g4Ni5jICAgfCAxMiArKysrKysrKysrKysKIDUgZmlsZXMgY2hhbmdlZCwg
MzUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9kb2NzL21hbi94bC5jZmcuNS5wb2QuaW4gYi9kb2NzL21hbi94bC5jZmcu
NS5wb2QuaW4KaW5kZXggMjQ1ZDNmOTQ3MjhhLi4zYjI5N2M2YTk3ZjAgMTAw
NjQ0Ci0tLSBhL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbgorKysgYi9kb2Nz
L21hbi94bC5jZmcuNS5wb2QuaW4KQEAgLTE3OTAsNiArMTc5MCwxMSBAQCBh
cmUgbm90IHVzaW5nIGhhcmR3YXJlIGFzc2lzdGVkIHBhZ2luZyAoaS5lLiB5
b3UgYXJlIHVzaW5nIHNoYWRvdwogbW9kZSkgYW5kIHlvdXIgZ3Vlc3Qgd29y
a2xvYWQgY29uc2lzdHMgb2YgYSB2ZXJ5IGxhcmdlIG51bWJlciBvZgogc2lt
aWxhciBwcm9jZXNzZXMgdGhlbiBpbmNyZWFzaW5nIHRoaXMgdmFsdWUgbWF5
IGltcHJvdmUgcGVyZm9ybWFuY2UuCiAKK09uIEFybSwgdGhpcyBmaWVsZCBp
cyB1c2VkIHRvIGRldGVybWluZSB0aGUgc2l6ZSBvZiB0aGUgZ3Vlc3QgUDJN
IHBhZ2VzCitwb29sLCBhbmQgdGhlIGRlZmF1bHQgdmFsdWUgaXMgMU1CIHBl
ciB2Q1BVIHBsdXMgNEtCIHBlciBNQiBvZiBSQU0gZm9yCit0aGUgUDJNIG1h
cC4gVXNlcnMgc2hvdWxkIGFkanVzdCB0aGlzIHZhbHVlIGlmIGJpZ2dlciBQ
Mk0gcG9vbCBzaXplIGlzCituZWVkZWQuCisKID1iYWNrCiAKID1oZWFkMyBQ
cm9jZXNzb3IgYW5kIFBsYXRmb3JtIEZlYXR1cmVzCmRpZmYgLS1naXQgYS90
b29scy9saWJ4bC9saWJ4bF9hcmNoLmggYi90b29scy9saWJ4bC9saWJ4bF9h
cmNoLmgKaW5kZXggNmE5MTc3NWI5ZTIwLi5iMDlmODY4NDkwYWMgMTAwNjQ0
Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2FyY2guaAorKysgYi90b29scy9s
aWJ4bC9saWJ4bF9hcmNoLmgKQEAgLTgzLDYgKzgzLDEwIEBAIGludCBsaWJ4
bF9fYXJjaF9leHRyYV9tZW1vcnkobGlieGxfX2djICpnYywKICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfZG9tYWluX2J1aWxk
X2luZm8gKmluZm8sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVp
bnQ2NF90ICpvdXQpOwogCitfaGlkZGVuCit1bnNpZ25lZCBsb25nIGxpYnhs
X19hcmNoX2dldF9yZXF1aXJlZF9wYWdpbmdfbWVtb3J5KHVuc2lnbmVkIGxv
bmcgbWF4bWVtX2tiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgc21wX2NwdXMp
OworCiAjaWYgZGVmaW5lZChfX2kzODZfXykgfHwgZGVmaW5lZChfX3g4Nl82
NF9fKQogCiAjZGVmaW5lIExBUElDX0JBU0VfQUREUkVTUyAgMHhmZWUwMDAw
MApkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxfYXJtLmMgYi90b29s
cy9saWJ4bC9saWJ4bF9hcm0uYwppbmRleCAzNGY4YTI5MDU2ZGIuLmY0YjNk
YzhlNzEzOSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfYXJtLmMK
KysrIGIvdG9vbHMvbGlieGwvbGlieGxfYXJtLmMKQEAgLTE1Myw2ICsxNTMs
MTggQEAgb3V0OgogICAgIHJldHVybiByYzsKIH0KIAordW5zaWduZWQgbG9u
ZyBsaWJ4bF9fYXJjaF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNp
Z25lZCBsb25nIG1heG1lbV9rYiwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNt
cF9jcHVzKQoreworICAgIC8qCisgICAgICogMjU2IHBhZ2VzICgxTUIpIHBl
ciB2Y3B1LAorICAgICAqIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIGZv
ciB0aGUgUDJNIG1hcCwKKyAgICAgKiBUaGlzIGlzIGhpZ2hlciB0aGFuIHRo
ZSBtaW5pbXVtIHRoYXQgWGVuIHdvdWxkIGFsbG9jYXRlIGlmIG5vIHZhbHVl
CisgICAgICogd2VyZSBnaXZlbiAoYnV0IHRoZSBYZW4gbWluaW11bSBpcyBm
b3Igc2FmZXR5LCBub3QgcGVyZm9ybWFuY2UpLgorICAgICAqLworICAgIHJl
dHVybiA0ICogKDI1NiAqIHNtcF9jcHVzICsgbWF4bWVtX2tiIC8gMTAyNCk7
Cit9CisKIHN0YXRpYyBzdHJ1Y3QgYXJjaF9pbmZvIHsKICAgICBjb25zdCBj
aGFyICpndWVzdF90eXBlOwogICAgIGNvbnN0IGNoYXIgKnRpbWVyX2NvbXBh
dDsKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX3V0aWxzLmMgYi90
b29scy9saWJ4bC9saWJ4bF91dGlscy5jCmluZGV4IGIwMzkxNDNiOGFlZi4u
ZTE4YjE1MjRlZjc4IDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4bF91
dGlscy5jCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX3V0aWxzLmMKQEAgLTE4
LDYgKzE4LDcgQEAKICNpbmNsdWRlIDxjdHlwZS5oPgogCiAjaW5jbHVkZSAi
bGlieGxfaW50ZXJuYWwuaCIKKyNpbmNsdWRlICJsaWJ4bF9hcmNoLmgiCiAj
aW5jbHVkZSAiX3BhdGhzLmgiCiAKICNpZm5kZWYgTElCWExfSEFWRV9OT05D
T05TVF9MSUJYTF9CQVNFTkFNRV9SRVRVUk5fVkFMVUUKQEAgLTM5LDEzICs0
MCw3IEBAIGNoYXIgKmxpYnhsX2Jhc2VuYW1lKGNvbnN0IGNoYXIgKm5hbWUp
CiAKIHVuc2lnbmVkIGxvbmcgbGlieGxfZ2V0X3JlcXVpcmVkX3NoYWRvd19t
ZW1vcnkodW5zaWduZWQgbG9uZyBtYXhtZW1fa2IsIHVuc2lnbmVkIGludCBz
bXBfY3B1cykKIHsKLSAgICAvKiAyNTYgcGFnZXMgKDFNQikgcGVyIHZjcHUs
Ci0gICAgICAgcGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBSQU0gZm9yIHRoZSBQ
Mk0gbWFwLAotICAgICAgIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIHRv
IHNoYWRvdyB0aGUgcmVzaWRlbnQgcHJvY2Vzc2VzLgotICAgICAgIFRoaXMg
aXMgaGlnaGVyIHRoYW4gdGhlIG1pbmltdW0gdGhhdCBYZW4gd291bGQgYWxs
b2NhdGUgaWYgbm8gdmFsdWUKLSAgICAgICB3ZXJlIGdpdmVuIChidXQgdGhl
IFhlbiBtaW5pbXVtIGlzIGZvciBzYWZldHksIG5vdCBwZXJmb3JtYW5jZSku
Ci0gICAgICovCi0gICAgcmV0dXJuIDQgKiAoMjU2ICogc21wX2NwdXMgKyAy
ICogKG1heG1lbV9rYiAvIDEwMjQpKTsKKyAgICByZXR1cm4gbGlieGxfX2Fy
Y2hfZ2V0X3JlcXVpcmVkX3BhZ2luZ19tZW1vcnkobWF4bWVtX2tiLCBzbXBf
Y3B1cyk7CiB9CiAKIGNoYXIgKmxpYnhsX2RvbWlkX3RvX25hbWUobGlieGxf
Y3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkKQpkaWZmIC0tZ2l0IGEvdG9vbHMv
bGlieGwvbGlieGxfeDg2LmMgYi90b29scy9saWJ4bC9saWJ4bF94ODYuYwpp
bmRleCBmMzRjMGVkYzEwMjkuLjM0ODg3NmU1YzA1NyAxMDA2NDQKLS0tIGEv
dG9vbHMvbGlieGwvbGlieGxfeDg2LmMKKysrIGIvdG9vbHMvbGlieGwvbGli
eGxfeDg2LmMKQEAgLTY4MSw2ICs2ODEsMTggQEAgaW50IGxpYnhsX19hcmNo
X3Bhc3N0aHJvdWdoX21vZGVfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLAog
ICAgIHJldHVybiByYzsKIH0KIAordW5zaWduZWQgbG9uZyBsaWJ4bF9fYXJj
aF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNpZ25lZCBsb25nIG1h
eG1lbV9rYiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNtcF9jcHVzKQorewor
ICAgIC8qCisgICAgICogMjU2IHBhZ2VzICgxTUIpIHBlciB2Y3B1LAorICAg
ICAqIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIGZvciB0aGUgUDJNIG1h
cCwKKyAgICAgKiBwbHVzIDEgcGFnZSBwZXIgTWlCIG9mIFJBTSB0byBzaGFk
b3cgdGhlIHJlc2lkZW50IHByb2Nlc3Nlcy4KKyAgICAgKiBUaGlzIGlzIGhp
Z2hlciB0aGFuIHRoZSBtaW5pbXVtIHRoYXQgWGVuIHdvdWxkIGFsbG9jYXRl
IGlmIG5vIHZhbHVlCisgICAgICogd2VyZSBnaXZlbiAoYnV0IHRoZSBYZW4g
bWluaW11bSBpcyBmb3Igc2FmZXR5LCBub3QgcGVyZm9ybWFuY2UpLgorICAg
ICAqLworICAgIHJldHVybiA0ICogKDI1NiAqIHNtcF9jcHVzICsgMiAqICht
YXhtZW1fa2IgLyAxMDI0KSk7Cit9CiAKIC8qCiAgKiBMb2NhbCB2YXJpYWJs
ZXM6Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.13/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Disposition: attachment;
 filename="xsa409-4.13/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Transfer-Encoding: base64

RnJvbSA4MjdmZDg0MzQ1YWM3YzgyZmRmOWQxNmViZDM0MTMzMzlhOTFiNjc4
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMi80XSB4ZW4vYXJtOiBDb25z
dHJ1Y3QgdGhlIFAyTSBwYWdlcyBwb29sIGZvciBndWVzdHMKClRoaXMgY29t
bWl0IGNvbnN0cnVjdHMgdGhlIHAybSBwYWdlcyBwb29sIGZvciBndWVzdHMg
ZnJvbSB0aGUKZGF0YSBzdHJ1Y3R1cmUgYW5kIGhlbHBlciBwZXJzcGVjdGl2
ZS4KClRoaXMgaXMgaW1wbGVtZW50ZWQgYnk6CgotIEFkZGluZyBhIGBzdHJ1
Y3QgcGFnaW5nX2RvbWFpbmAgd2hpY2ggY29udGFpbnMgYSBmcmVlbGlzdCwg
YQpjb3VudGVyIHZhcmlhYmxlIGFuZCBhIHNwaW5sb2NrIHRvIGBzdHJ1Y3Qg
YXJjaF9kb21haW5gIHRvCmluZGljYXRlIHRoZSBmcmVlIHAybSBwYWdlcyBh
bmQgdGhlIG51bWJlciBvZiBwMm0gdG90YWwgcGFnZXMgaW4KdGhlIHAybSBw
YWdlcyBwb29sLgoKLSBBZGRpbmcgYSBoZWxwZXIgYHAybV9nZXRfYWxsb2Nh
dGlvbmAgdG8gZ2V0IHRoZSBwMm0gcG9vbCBzaXplLgoKLSBBZGRpbmcgYSBo
ZWxwZXIgYHAybV9zZXRfYWxsb2NhdGlvbmAgdG8gc2V0IHRoZSBwMm0gcGFn
ZXMgcG9vbApzaXplLiBUaGlzIGhlbHBlciBzaG91bGQgYmUgY2FsbGVkIGJl
Zm9yZSBhbGxvY2F0aW5nIG1lbW9yeSBmb3IKYSBndWVzdC4KCi0gQWRkaW5n
IGEgaGVscGVyIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAgdG8gZnJlZSB0
aGUgcDJtIHBhZ2VzCnBvb2wuIFRoaXMgaGVscGVyIHNob3VsZCBiZSBjYWxs
ZWQgZHVyaW5nIHRoZSB4bCBkb21haW4gZGVzdG9yeS4KClRoaXMgaXMgcGFy
dCBvZiBDVkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTaWduZWQtb2ZmLWJ5
OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5
OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+
Ci0tLQogeGVuL2FyY2gvYXJtL3AybS5jICAgICAgICAgICB8IDg4ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogeGVuL2luY2x1ZGUv
YXNtLWFybS9kb21haW4uaCB8IDEwICsrKysKIHhlbi9pbmNsdWRlL2FzbS1h
cm0vcDJtLmggICAgfCAgNCArKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDIgaW5z
ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBi
L3hlbi9hcmNoL2FybS9wMm0uYwppbmRleCA0MjYzODc4N2EyOTUuLjdkNmZl
Yzc4ODc5NSAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCisrKyBi
L3hlbi9hcmNoL2FybS9wMm0uYwpAQCAtNTMsNiArNTMsOTIgQEAgc3RhdGlj
IHVpbnQ2NF90IGdlbmVyYXRlX3Z0dGJyKHVpbnQxNl90IHZtaWQsIG1mbl90
IHJvb3RfbWZuKQogICAgIHJldHVybiAobWZuX3RvX21hZGRyKHJvb3RfbWZu
KSB8ICgodWludDY0X3Qpdm1pZCA8PCA0OCkpOwogfQogCisvKiBSZXR1cm4g
dGhlIHNpemUgb2YgdGhlIHBvb2wsIHJvdW5kZWQgdXAgdG8gdGhlIG5lYXJl
c3QgTUIgKi8KK3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIG5yX3BhZ2Vz
ID0gQUNDRVNTX09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2Vz
KTsKKworICAgIHJldHVybiBST1VORFVQKG5yX3BhZ2VzLCAxIDw8ICgyMCAt
IFBBR0VfU0hJRlQpKSA+PiAoMjAgLSBQQUdFX1NISUZUKTsKK30KKworLyoK
KyAqIFNldCB0aGUgcG9vbCBvZiBwYWdlcyB0byB0aGUgcmVxdWlyZWQgbnVt
YmVyIG9mIHBhZ2VzLgorICogUmV0dXJucyAwIGZvciBzdWNjZXNzLCBub24t
emVybyBmb3IgZmFpbHVyZS4KKyAqIENhbGwgd2l0aCBkLT5hcmNoLnBhZ2lu
Zy5sb2NrIGhlbGQuCisgKi8KK2ludCBwMm1fc2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBwYWdlcywgYm9vbCAqcHJl
ZW1wdGVkKQoreworICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOworCisgICAg
QVNTRVJUKHNwaW5faXNfbG9ja2VkKCZkLT5hcmNoLnBhZ2luZy5sb2NrKSk7
CisKKyAgICBmb3IgKCA7IDsgKQorICAgIHsKKyAgICAgICAgaWYgKCBkLT5h
cmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPCBwYWdlcyApCisgICAgICAg
IHsKKyAgICAgICAgICAgIC8qIE5lZWQgdG8gYWxsb2NhdGUgbW9yZSBtZW1v
cnkgZnJvbSBkb21oZWFwICovCisgICAgICAgICAgICBwZyA9IGFsbG9jX2Rv
bWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICAgICAgICAgIGlmICggcGcgPT0g
TlVMTCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRr
KFhFTkxPR19FUlIgIkZhaWxlZCB0byBhbGxvY2F0ZSBQMk0gcGFnZXMuXG4i
KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKKyAgICAgICAg
ICAgIH0KKyAgICAgICAgICAgIEFDQ0VTU19PTkNFKGQtPmFyY2gucGFnaW5n
LnAybV90b3RhbF9wYWdlcykgPQorICAgICAgICAgICAgICAgIGQtPmFyY2gu
cGFnaW5nLnAybV90b3RhbF9wYWdlcyArIDE7CisgICAgICAgICAgICBwYWdl
X2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxp
c3QpOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBkLT5hcmNoLnBh
Z2luZy5wMm1fdG90YWxfcGFnZXMgPiBwYWdlcyApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIC8qIE5lZWQgdG8gcmV0dXJuIG1lbW9yeSB0byBkb21oZWFw
ICovCisgICAgICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgm
ZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgICAgIGlm
KCBwZyApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgQUNDRVNT
X09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzKSA9CisgICAg
ICAgICAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cyAtIDE7CisgICAgICAgICAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcp
OworICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSCisgICAg
ICAgICAgICAgICAgICAgICAgICJGYWlsZWQgdG8gZnJlZSBQMk0gcGFnZXMs
IFAyTSBmcmVlbGlzdCBpcyBlbXB0eS5cbiIpOworICAgICAgICAgICAgICAg
IHJldHVybiAtRU5PTUVNOworICAgICAgICAgICAgfQorICAgICAgICB9Cisg
ICAgICAgIGVsc2UKKyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIC8q
IENoZWNrIHRvIHNlZSBpZiB3ZSBuZWVkIHRvIHlpZWxkIGFuZCB0cnkgYWdh
aW4gKi8KKyAgICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgZ2VuZXJhbF9wcmVl
bXB0X2NoZWNrKCkgKQorICAgICAgICB7CisgICAgICAgICAgICAqcHJlZW1w
dGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7Cisg
ICAgICAgIH0KKyAgICB9CisKKyAgICByZXR1cm4gMDsKK30KKworaW50IHAy
bV90ZWFyZG93bl9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQpCit7Cisg
ICAgaW50IHJldCA9IDA7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsK
KworICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAg
aWYgKCBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgIT0gMCApCisg
ICAgeworICAgICAgICByZXQgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwg
JnByZWVtcHRlZCk7CisgICAgICAgIGlmICggcHJlZW1wdGVkICkKKyAgICAg
ICAgeworICAgICAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5n
LmxvY2spOworICAgICAgICAgICAgcmV0dXJuIC1FUkVTVEFSVDsKKyAgICAg
ICAgfQorICAgICAgICBBU1NFUlQoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFs
X3BhZ2VzID09IDApOworICAgIH0KKyAgICBzcGluX3VubG9jaygmZC0+YXJj
aC5wYWdpbmcubG9jayk7CisKKyAgICByZXR1cm4gcmV0OworfQorCiAvKiBV
bmxvY2sgdGhlIGZsdXNoIGFuZCBkbyBhIFAyTSBUTEIgZmx1c2ggaWYgbmVj
ZXNzYXJ5ICovCiB2b2lkIHAybV93cml0ZV91bmxvY2soc3RydWN0IHAybV9k
b21haW4gKnAybSkKIHsKQEAgLTE1NjcsNyArMTY1Myw5IEBAIGludCBwMm1f
aW5pdChzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2lnbmVkIGludCBjcHU7
CiAKICAgICByd2xvY2tfaW5pdCgmcDJtLT5sb2NrKTsKKyAgICBzcGluX2xv
Y2tfaW5pdCgmZC0+YXJjaC5wYWdpbmcubG9jayk7CiAgICAgSU5JVF9QQUdF
X0xJU1RfSEVBRCgmcDJtLT5wYWdlcyk7CisgICAgSU5JVF9QQUdFX0xJU1Rf
SEVBRCgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKIAogICAgIHAy
bS0+dm1pZCA9IElOVkFMSURfVk1JRDsKIApkaWZmIC0tZ2l0IGEveGVuL2lu
Y2x1ZGUvYXNtLWFybS9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v
ZG9tYWluLmgKaW5kZXggOWI0NGE5NjQ4YzUwLi43YmMxNGMyZTllNDcgMTAw
NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaApAQCAtNDIsNiArNDIsMTQg
QEAgc3RydWN0IHZ0aW1lciB7CiAgICAgICAgIHVpbnQ2NF90IGN2YWw7CiB9
OwogCitzdHJ1Y3QgcGFnaW5nX2RvbWFpbiB7CisgICAgc3BpbmxvY2tfdCBs
b2NrOworICAgIC8qIEZyZWUgUDJNIHBhZ2VzIGZyb20gdGhlIHByZS1hbGxv
Y2F0ZWQgUDJNIHBvb2wgKi8KKyAgICBzdHJ1Y3QgcGFnZV9saXN0X2hlYWQg
cDJtX2ZyZWVsaXN0OworICAgIC8qIE51bWJlciBvZiBwYWdlcyBmcm9tIHRo
ZSBwcmUtYWxsb2NhdGVkIFAyTSBwb29sICovCisgICAgdW5zaWduZWQgbG9u
ZyBwMm1fdG90YWxfcGFnZXM7Cit9OworCiBzdHJ1Y3QgYXJjaF9kb21haW4K
IHsKICNpZmRlZiBDT05GSUdfQVJNXzY0CkBAIC01Myw2ICs2MSw4IEBAIHN0
cnVjdCBhcmNoX2RvbWFpbgogCiAgICAgc3RydWN0IGh2bV9kb21haW4gaHZt
OwogCisgICAgc3RydWN0IHBhZ2luZ19kb21haW4gcGFnaW5nOworCiAgICAg
c3RydWN0IHZtbWlvIHZtbWlvOwogCiAgICAgLyogQ29udGludWFibGUgZG9t
YWluX3JlbGlucXVpc2hfcmVzb3VyY2VzKCkuICovCmRpZmYgLS1naXQgYS94
ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oIGIveGVuL2luY2x1ZGUvYXNtLWFy
bS9wMm0uaAppbmRleCAyMGRmNjIxMjcxMmUuLmIxYzliOTQ3YmI4ZiAxMDA2
NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaAorKysgYi94ZW4v
aW5jbHVkZS9hc20tYXJtL3AybS5oCkBAIC0xOTcsNiArMTk3LDEwIEBAIHZv
aWQgcDJtX3Jlc3RvcmVfc3RhdGUoc3RydWN0IHZjcHUgKm4pOwogLyogUHJp
bnQgZGVidWdnaW5nL3N0YXRpc3RpYWwgaW5mbyBhYm91dCBhIGRvbWFpbidz
IHAybSAqLwogdm9pZCBwMm1fZHVtcF9pbmZvKHN0cnVjdCBkb21haW4gKmQp
OwogCit1bnNpZ25lZCBpbnQgcDJtX2dldF9hbGxvY2F0aW9uKHN0cnVjdCBk
b21haW4gKmQpOworaW50IHAybV9zZXRfYWxsb2NhdGlvbihzdHJ1Y3QgZG9t
YWluICpkLCB1bnNpZ25lZCBsb25nIHBhZ2VzLCBib29sICpwcmVlbXB0ZWQp
OworaW50IHAybV90ZWFyZG93bl9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4g
KmQpOworCiBzdGF0aWMgaW5saW5lIHZvaWQgcDJtX3dyaXRlX2xvY2soc3Ry
dWN0IHAybV9kb21haW4gKnAybSkKIHsKICAgICB3cml0ZV9sb2NrKCZwMm0t
PmxvY2spOwotLSAKMi4zNy4xCgo=

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.13/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Disposition: attachment;
 filename="xsa409-4.13/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Transfer-Encoding: base64

RnJvbSAzZjNjZWMxMjc2M2NkNjEyZmNjMDBiODA5ZGE0YTdmMzU3ZTQxM2Ux
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMy80XSB4ZW4vYXJtLCBsaWJ4
bDogSW1wbGVtZW50IFhFTl9ET01DVExfc2hhZG93X29wIGZvciBBcm0KClRo
aXMgY29tbWl0IGltcGxlbWVudHMgdGhlIGBYRU5fRE9NQ1RMX3NoYWRvd19v
cGAgc3VwcG9ydCBpbiBYZW4KZm9yIEFybS4gVGhlIHAybSBwYWdlcyBwb29s
IHNpemUgZm9yIHhsIGd1ZXN0cyBpcyBzdXBwb3NlZCB0byBiZQpkZXRlcm1p
bmVkIGJ5IGBYRU5fRE9NQ1RMX3NoYWRvd19vcGAuIEhlbmNlLCB0aGlzIGNv
bW1pdDoKCi0gSW50cm9kdWNlcyBhIGZ1bmN0aW9uIGBwMm1fZG9tY3RsYCBh
bmQgaW1wbGVtZW50cyB0aGUgc3Vib3BzCmBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTmAgYW5kCmBYRU5fRE9NQ1RMX1NIQURPV19PUF9H
RVRfQUxMT0NBVElPTmAgb2YgYFhFTl9ET01DVExfc2hhZG93X29wYC4KCi0g
QWRkcyB0aGUgYFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FUSU9O
YCBzdXBwb3J0IGluIGxpYnhsLgoKVGhlcmVmb3JlIGVuYWJsaW5nIHRoZSBz
ZXR0aW5nIG9mIHNoYWRvdyBtZW1vcnkgcG9vbCBzaXplCndoZW4gY3JlYXRp
bmcgYSBndWVzdCBmcm9tIHhsIGFuZCBnZXR0aW5nIHNoYWRvdyBtZW1vcnkg
cG9vbCBzaXplCmZyb20gWGVuLgoKTm90ZSB0aGF0IHRoZSBgWEVOX0RPTUNU
TF9zaGFkb3dfb3BgIGFkZGVkIGluIHRoaXMgY29tbWl0IGlzIG9ubHkKYSBk
dW1teSBvcCwgYW5kIHRoZSBmdW5jdGlvbmFsaXR5IG9mIHNldHRpbmcvZ2V0
dGluZyBwMm0gbWVtb3J5IHBvb2wKc2l6ZSBmb3IgeGwgZ3Vlc3RzIHdpbGwg
YmUgYWRkZWQgaW4gZm9sbG93aW5nIGNvbW1pdHMuCgpUaGlzIGlzIHBhcnQg
b2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0EtNDA5LgoKU2lnbmVkLW9mZi1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPgpSZXZpZXdlZC1ieTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgot
LS0KIHRvb2xzL2xpYnhsL2xpYnhsX2FybS5jIHwgMTIgKysrKysrKysrKysr
CiB4ZW4vYXJjaC9hcm0vZG9tY3RsLmMgICB8IDMyICsrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2Vy
dGlvbnMoKykKCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9hcm0u
YyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2FybS5jCmluZGV4IGY0YjNkYzhlNzEz
OS4uMDI1ZGYxYmZkMDA0IDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4
bF9hcm0uYworKysgYi90b29scy9saWJ4bC9saWJ4bF9hcm0uYwpAQCAtMTMw
LDYgKzEzMCwxOCBAQCBpbnQgbGlieGxfX2FyY2hfZG9tYWluX3NhdmVfY29u
ZmlnKGxpYnhsX19nYyAqZ2MsCiBpbnQgbGlieGxfX2FyY2hfZG9tYWluX2Ny
ZWF0ZShsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9kb21haW5fY29uZmlnICpkX2Nv
bmZpZywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90
IGRvbWlkKQogeworICAgIGxpYnhsX2N0eCAqY3R4ID0gbGlieGxfX2djX293
bmVyKGdjKTsKKyAgICB1bnNpZ25lZCBpbnQgc2hhZG93X21iID0gRElWX1JP
VU5EVVAoZF9jb25maWctPmJfaW5mby5zaGFkb3dfbWVta2IsIDEwMjQpOwor
CisgICAgaW50IHIgPSB4Y19zaGFkb3dfY29udHJvbChjdHgtPnhjaCwgZG9t
aWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRU5fRE9NQ1RM
X1NIQURPV19PUF9TRVRfQUxMT0NBVElPTiwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICZzaGFkb3dfbWIsIDApOworICAgIGlmIChyKSB7Cisg
ICAgICAgIExPR0VEKEVSUk9SLCBkb21pZCwKKyAgICAgICAgICAgICAgIkZh
aWxlZCB0byBzZXQgJXUgTWlCIHNoYWRvdyBhbGxvY2F0aW9uIiwgc2hhZG93
X21iKTsKKyAgICAgICAgcmV0dXJuIEVSUk9SX0ZBSUw7CisgICAgfQorCiAg
ICAgcmV0dXJuIDA7CiB9CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9k
b21jdGwuYyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwppbmRleCA5ZGE4OGI4
YzY0ZTIuLmVmMTI5OWFlMWM2NCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJt
L2RvbWN0bC5jCisrKyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwpAQCAtNDUs
MTEgKzQ1LDQzIEBAIHN0YXRpYyBpbnQgaGFuZGxlX3Z1YXJ0X2luaXQoc3Ry
dWN0IGRvbWFpbiAqZCwKICAgICByZXR1cm4gcmM7CiB9CiAKK3N0YXRpYyBs
b25nIHAybV9kb21jdGwoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhlbl9k
b21jdGxfc2hhZG93X29wICpzYywKKyAgICAgICAgICAgICAgICAgICAgICAg
WEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3Rs
KQoreworICAgIGlmICggdW5saWtlbHkoZCA9PSBjdXJyZW50LT5kb21haW4p
ICkKKyAgICB7CisgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJUcmllZCB0
byBkbyBhIHAybSBkb21jdGwgb3Agb24gaXRzZWxmLlxuIik7CisgICAgICAg
IHJldHVybiAtRUlOVkFMOworICAgIH0KKworICAgIGlmICggdW5saWtlbHko
ZC0+aXNfZHlpbmcpICkKKyAgICB7CisgICAgICAgIHByaW50ayhYRU5MT0df
RVJSICJUcmllZCB0byBkbyBhIHAybSBkb21jdGwgb3Agb24gZHlpbmcgZG9t
YWluICV1XG4iLAorICAgICAgICAgICAgICAgZC0+ZG9tYWluX2lkKTsKKyAg
ICAgICAgcmV0dXJuIC1FSU5WQUw7CisgICAgfQorCisgICAgc3dpdGNoICgg
c2MtPm9wICkKKyAgICB7CisgICAgY2FzZSBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTjoKKyAgICAgICAgcmV0dXJuIDA7CisgICAgY2Fz
ZSBYRU5fRE9NQ1RMX1NIQURPV19PUF9HRVRfQUxMT0NBVElPTjoKKyAgICAg
ICAgcmV0dXJuIDA7CisgICAgZGVmYXVsdDoKKyAgICB7CisgICAgICAgIHBy
aW50ayhYRU5MT0dfRVJSICJCYWQgcDJtIGRvbWN0bCBvcCAldVxuIiwgc2Mt
Pm9wKTsKKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7CisgICAgfQorICAgIH0K
K30KKwogbG9uZyBhcmNoX2RvX2RvbWN0bChzdHJ1Y3QgeGVuX2RvbWN0bCAq
ZG9tY3RsLCBzdHJ1Y3QgZG9tYWluICpkLAogICAgICAgICAgICAgICAgICAg
ICBYRU5fR1VFU1RfSEFORExFX1BBUkFNKHhlbl9kb21jdGxfdCkgdV9kb21j
dGwpCiB7CiAgICAgc3dpdGNoICggZG9tY3RsLT5jbWQgKQogICAgIHsKKyAg
ICBjYXNlIFhFTl9ET01DVExfc2hhZG93X29wOgorICAgICAgICByZXR1cm4g
cDJtX2RvbWN0bChkLCAmZG9tY3RsLT51LnNoYWRvd19vcCwgdV9kb21jdGwp
OwogICAgIGNhc2UgWEVOX0RPTUNUTF9jYWNoZWZsdXNoOgogICAgIHsKICAg
ICAgICAgZ2ZuX3QgcyA9IF9nZm4oZG9tY3RsLT51LmNhY2hlZmx1c2guc3Rh
cnRfcGZuKTsKLS0gCjIuMzcuMQoK

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.13/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Disposition: attachment;
 filename="xsa409-4.13/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Transfer-Encoding: base64

RnJvbSA4ZWUwYWE4ZjYxZWY2ZjExMzVkMDVkZWNkZWNiNDVlN2E5NDBlNzg0
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzozMCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSB4ZW4vYXJtOiBBbGxv
Y2F0ZSBhbmQgZnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgUDJNIHBvb2wKClRo
aXMgY29tbWl0IHNldHMvdGVhcnNkb3duIG9mIHAybSBwYWdlcyBwb29sIGZv
ciBub24tcHJpdmlsZWdlZCBBcm0KZ3Vlc3RzIGJ5IGNhbGxpbmcgYHAybV9z
ZXRfYWxsb2NhdGlvbmAgYW5kIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAu
CgotIEZvciBkb20wLCBQMk0gcGFnZXMgc2hvdWxkIGNvbWUgZnJvbSBoZWFw
IGRpcmVjdGx5IGluc3RlYWQgb2YgcDJtCnBvb2wsIHNvIHRoYXQgdGhlIGtl
cm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGV4dGVuZGVkIHJlZ2lv
bnMuCgotIEZvciB4bCBndWVzdHMsIHRoZSBzZXR0aW5nIG9mIHRoZSBwMm0g
cG9vbCBpcyBjYWxsZWQgaW4KYFhFTl9ET01DVExfc2hhZG93X29wYCBhbmQg
dGhlIHAybSBwb29sIGlzIGRlc3Ryb3llZCBpbgpgZG9tYWluX3JlbGlucXVp
c2hfcmVzb3VyY2VzYC4gTm90ZSB0aGF0IGRvbWN0bC0+dS5zaGFkb3dfb3Au
bWIgaXMKdXBkYXRlZCB3aXRoIHRoZSBuZXcgc2l6ZSB3aGVuIHNldHRpbmcg
dGhlIHAybSBwb29sLgoKLSBGb3IgZG9tMGxlc3MgZG9tVXMsIHRoZSBzZXR0
aW5nIG9mIHRoZSBwMm0gcG9vbCBpcyBjYWxsZWQgYmVmb3JlCmFsbG9jYXRp
bmcgbWVtb3J5IGR1cmluZyBkb21haW4gY3JlYXRpb24uIFVzZXJzIGNhbiBz
cGVjaWZ5IHRoZSBwMm0KcG9vbCBzaXplIGJ5IGB4ZW4sZG9tYWluLXAybS1t
ZW0tbWJgIGR0cyBwcm9wZXJ0eS4KClRvIGFjdHVhbGx5IGFsbG9jYXRlL2Zy
ZWUgcGFnZXMgZnJvbSB0aGUgcDJtIHBvb2wsIHRoaXMgY29tbWl0IGFkZHMK
dHdvIGhlbHBlciBmdW5jdGlvbnMgbmFtZWx5IGBwMm1fYWxsb2NfcGFnZWAg
YW5kIGBwMm1fZnJlZV9wYWdlYCB0bwpgc3RydWN0IHAybV9kb21haW5gLiBC
eSByZXBsYWNpbmcgdGhlIGBhbGxvY19kb21oZWFwX3BhZ2VgIGFuZApgZnJl
ZV9kb21oZWFwX3BhZ2VgIHdpdGggdGhlc2UgdHdvIGhlbHBlciBmdW5jdGlv
bnMsIHAybSBwYWdlcyBjYW4KYmUgYWRkZWQvcmVtb3ZlZCBmcm9tIHRoZSBs
aXN0IG9mIHAybSBwb29sIHJhdGhlciB0aGFuIGZyb20gdGhlIGhlYXAuCgpT
aW5jZSBwYWdlIGZyb20gYHAybV9hbGxvY19wYWdlYCBpcyBjbGVhbmVkLCB0
YWtlIHRoZSBvcHBvcnR1bml0eQp0byByZW1vdmUgdGhlIHJlZHVuZGFudCBg
Y2xlYW5fcGFnZWAgaW4gYHAybV9jcmVhdGVfdGFibGVgLgoKVGhpcyBpcyBw
YXJ0IG9mIENWRS0yMDIyLTMzNzQ3IC8gWFNBLTQwOS4KClNpZ25lZC1vZmYt
Ynk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQt
Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y
Zz4KLS0tCiBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0
IHwgIDggKysrKwogeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAg
ICAgICB8ICA4ICsrKysKIHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAg
ICAgICAgICAgfCAyOSArKysrKysrKysrKysrKwogeGVuL2FyY2gvYXJtL2Rv
bWN0bC5jICAgICAgICAgICAgICAgICB8IDIzICsrKysrKysrKystCiB4ZW4v
YXJjaC9hcm0vcDJtLmMgICAgICAgICAgICAgICAgICAgIHwgNTcgKysrKysr
KysrKysrKysrKysrKysrKysrKy0tCiB4ZW4vaW5jbHVkZS9hc20tYXJtL2Rv
bWFpbi5oICAgICAgICAgIHwgIDEgKwogNiBmaWxlcyBjaGFuZ2VkLCAxMjEg
aW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k
b2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0IGIvZG9jcy9t
aXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dAppbmRleCA1MjQzYmM3
ZmQzNDQuLjQ3MGM5NDkxYTc4MSAxMDA2NDQKLS0tIGEvZG9jcy9taXNjL2Fy
bS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dAorKysgYi9kb2NzL21pc2MvYXJt
L2RldmljZS10cmVlL2Jvb3RpbmcudHh0CkBAIC0xNjQsNiArMTY0LDE0IEBA
IHdpdGggdGhlIGZvbGxvd2luZyBwcm9wZXJ0aWVzOgogICAgIEJvdGggI2Fk
ZHJlc3MtY2VsbHMgYW5kICNzaXplLWNlbGxzIG5lZWQgdG8gYmUgc3BlY2lm
aWVkIGJlY2F1c2UKICAgICBib3RoIHN1Yi1ub2RlcyAoZGVzY3JpYmVkIHNo
b3J0bHkpIGhhdmUgcmVnIHByb3BlcnRpZXMuCiAKKy0geGVuLGRvbWFpbi1w
Mm0tbWVtLW1iCisKKyAgICBPcHRpb25hbC4gQSAzMi1iaXQgaW50ZWdlciBz
cGVjaWZ5aW5nIHRoZSBhbW91bnQgb2YgbWVnYWJ5dGVzIG9mIFJBTQorICAg
IHVzZWQgZm9yIHRoZSBkb21haW4gUDJNIHBvb2wuIFRoaXMgaXMgaW4tc3lu
YyB3aXRoIHRoZSBzaGFkb3dfbWVtb3J5CisgICAgb3B0aW9uIGluIHhsLmNm
Zy4gTGVhdmluZyB0aGlzIGZpZWxkIGVtcHR5IGluIGRldmljZSB0cmVlIHdp
bGwgbGVhZCB0bworICAgIHRoZSBkZWZhdWx0IHNpemUgb2YgZG9tYWluIFAy
TSBwb29sLCBpLmUuIDFNQiBwZXIgZ3Vlc3QgdkNQVSBwbHVzIDRLQgorICAg
IHBlciBNQiBvZiBndWVzdCBSQU0gcGx1cyA1MTJLQiBmb3IgZ3Vlc3QgZXh0
ZW5kZWQgcmVnaW9ucy4KKwogVW5kZXIgdGhlICJ4ZW4sZG9tYWluIiBjb21w
YXRpYmxlIG5vZGUsIG9uZSBvciBtb3JlIHN1Yi1ub2RlcyBhcmUgcHJlc2Vu
dAogZm9yIHRoZSBEb21VIGtlcm5lbCBhbmQgcmFtZGlzay4KIApkaWZmIC0t
Z2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gvYXJtL2Rv
bWFpbi5jCmluZGV4IDFlMjRhN2RiYjRhMS4uMzFhYmU3ZDZmOWRjIDEwMDY0
NAotLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMKKysrIGIveGVuL2FyY2gv
YXJtL2RvbWFpbi5jCkBAIC0xMDIyLDYgKzEwMjIsMTQgQEAgaW50IGRvbWFp
bl9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQogICAg
ICAgICBpZiAoIHJldCApCiAgICAgICAgICAgICByZXR1cm4gcmV0OwogCisg
ICAgICAgIGQtPmFyY2gucmVsbWVtID0gUkVMTUVNX3AybV9wb29sOworICAg
ICAgICAvKiBGYWxsdGhyb3VnaCAqLworCisgICAgY2FzZSBSRUxNRU1fcDJt
X3Bvb2w6CisgICAgICAgIHJldCA9IHAybV90ZWFyZG93bl9hbGxvY2F0aW9u
KGQpOworICAgICAgICBpZiggcmV0ICkKKyAgICAgICAgICAgIHJldHVybiBy
ZXQ7CisKICAgICAgICAgZC0+YXJjaC5yZWxtZW0gPSBSRUxNRU1fZG9uZTsK
ICAgICAgICAgLyogRmFsbHRocm91Z2ggKi8KIApkaWZmIC0tZ2l0IGEveGVu
L2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFp
bl9idWlsZC5jCmluZGV4IGNlN2Y2MWU4MjU5Zi4uZWI4NTk2MDBlNTdkIDEw
MDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKKysrIGIv
eGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jCkBAIC0yMzI3LDYgKzIzMjcs
MjEgQEAgc3RhdGljIHZvaWQgX19pbml0IGZpbmRfZ250dGFiX3JlZ2lvbihz
dHJ1Y3QgZG9tYWluICpkLAogICAgICAgICAgICBraW5mby0+Z250dGFiX3N0
YXJ0LCBraW5mby0+Z250dGFiX3N0YXJ0ICsga2luZm8tPmdudHRhYl9zaXpl
KTsKIH0KIAorc3RhdGljIHVuc2lnbmVkIGxvbmcgX19pbml0IGRvbWFpbl9w
Mm1fcGFnZXModW5zaWduZWQgbG9uZyBtYXhtZW1fa2IsCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp
bnQgc21wX2NwdXMpCit7CisgICAgLyoKKyAgICAgKiBLZWVwIGluIHN5bmMg
d2l0aCBsaWJ4bF9fZ2V0X3JlcXVpcmVkX3BhZ2luZ19tZW1vcnkoKS4KKyAg
ICAgKiAyNTYgcGFnZXMgKDFNQikgcGVyIHZjcHUsIHBsdXMgMSBwYWdlIHBl
ciBNaUIgb2YgUkFNIGZvciB0aGUgUDJNIG1hcCwKKyAgICAgKiBwbHVzIDEy
OCBwYWdlcyB0byBjb3ZlciBleHRlbmRlZCByZWdpb25zLgorICAgICAqLwor
ICAgIHVuc2lnbmVkIGxvbmcgbWVta2IgPSA0ICogKDI1NiAqIHNtcF9jcHVz
ICsgKG1heG1lbV9rYiAvIDEwMjQpICsgMTI4KTsKKworICAgIEJVSUxEX0JV
R19PTihQQUdFX1NJWkUgIT0gU1pfNEspOworCisgICAgcmV0dXJuIERJVl9S
T1VORF9VUChtZW1rYiwgMTAyNCkgPDwgKDIwIC0gUEFHRV9TSElGVCk7Cit9
CisKIHN0YXRpYyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21haW4oc3RydWN0
IGRvbWFpbiAqZCwgc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbykKIHsKICAg
ICB1bnNpZ25lZCBpbnQgaTsKQEAgLTI0MTgsNiArMjQzMyw4IEBAIHN0YXRp
YyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21VKHN0cnVjdCBkb21haW4gKmQs
CiAgICAgc3RydWN0IGtlcm5lbF9pbmZvIGtpbmZvID0ge307CiAgICAgaW50
IHJjOwogICAgIHU2NCBtZW07CisgICAgdTMyIHAybV9tZW1fbWI7CisgICAg
dW5zaWduZWQgbG9uZyBwMm1fcGFnZXM7CiAKICAgICByYyA9IGR0X3Byb3Bl
cnR5X3JlYWRfdTY0KG5vZGUsICJtZW1vcnkiLCAmbWVtKTsKICAgICBpZiAo
ICFyYyApCkBAIC0yNDI3LDYgKzI0NDQsMTggQEAgc3RhdGljIGludCBfX2lu
aXQgY29uc3RydWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwKICAgICB9CiAg
ICAga2luZm8udW5hc3NpZ25lZF9tZW0gPSAocGFkZHJfdCltZW0gKiBTWl8x
SzsKIAorICAgIHJjID0gZHRfcHJvcGVydHlfcmVhZF91MzIobm9kZSwgInhl
bixkb21haW4tcDJtLW1lbS1tYiIsICZwMm1fbWVtX21iKTsKKyAgICAvKiBJ
ZiB4ZW4sZG9tYWluLXAybS1tZW0tbWIgaXMgbm90IHNwZWNpZmllZCwgdXNl
IHRoZSBkZWZhdWx0IHZhbHVlLiAqLworICAgIHAybV9wYWdlcyA9IHJjID8K
KyAgICAgICAgICAgICAgICBwMm1fbWVtX21iIDw8ICgyMCAtIFBBR0VfU0hJ
RlQpIDoKKyAgICAgICAgICAgICAgICBkb21haW5fcDJtX3BhZ2VzKG1lbSwg
ZC0+bWF4X3ZjcHVzKTsKKworICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdp
bmcubG9jayk7CisgICAgcmMgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgcDJt
X3BhZ2VzLCBOVUxMKTsKKyAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdp
bmcubG9jayk7CisgICAgaWYgKCByYyAhPSAwICkKKyAgICAgICAgcmV0dXJu
IHJjOworCiAgICAgcHJpbnRrKCIqKiogTE9BRElORyBET01VIGNwdXM9JXUg
bWVtb3J5PSUiUFJJeDY0IktCICoqKlxuIiwgZC0+bWF4X3ZjcHVzLCBtZW0p
OwogCiAgICAga2luZm8udnBsMDExID0gZHRfcHJvcGVydHlfcmVhZF9ib29s
KG5vZGUsICJ2cGwwMTEiKTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9k
b21jdGwuYyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwppbmRleCBlZjEyOTlh
ZTFjNjQuLmRhYjNkYTNhMjNiYyAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJt
L2RvbWN0bC5jCisrKyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwpAQCAtNDgs
NiArNDgsOSBAQCBzdGF0aWMgaW50IGhhbmRsZV92dWFydF9pbml0KHN0cnVj
dCBkb21haW4gKmQsCiBzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBk
b21haW4gKmQsIHN0cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCiAg
ICAgICAgICAgICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0o
eGVuX2RvbWN0bF90KSB1X2RvbWN0bCkKIHsKKyAgICBsb25nIHJjOworICAg
IGJvb2wgcHJlZW1wdGVkID0gZmFsc2U7CisKICAgICBpZiAoIHVubGlrZWx5
KGQgPT0gY3VycmVudC0+ZG9tYWluKSApCiAgICAgewogICAgICAgICBwcmlu
dGsoWEVOTE9HX0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9wIG9u
IGl0c2VsZi5cbiIpOwpAQCAtNjQsOSArNjcsMjcgQEAgc3RhdGljIGxvbmcg
cDJtX2RvbWN0bChzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgeGVuX2RvbWN0
bF9zaGFkb3dfb3AgKnNjLAogICAgIHN3aXRjaCAoIHNjLT5vcCApCiAgICAg
ewogICAgIGNhc2UgWEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJ
T046Ci0gICAgICAgIHJldHVybiAwOworICAgIHsKKyAgICAgICAgLyogQWxs
b3cgYW5kIGhhbmRsZSBwcmVlbXB0aW9uICovCisgICAgICAgIHNwaW5fbG9j
aygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAgICAgIHJjID0gcDJtX3Nl
dF9hbGxvY2F0aW9uKGQsIHNjLT5tYiA8PCAoMjAgLSBQQUdFX1NISUZUKSwg
JnByZWVtcHRlZCk7CisgICAgICAgIHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBh
Z2luZy5sb2NrKTsKKworICAgICAgICBpZiAoIHByZWVtcHRlZCApCisgICAg
ICAgICAgICAvKiBOb3QgZmluaXNoZWQuIFNldCB1cCB0byByZS1ydW4gdGhl
IGNhbGwuICovCisgICAgICAgICAgICByYyA9IGh5cGVyY2FsbF9jcmVhdGVf
Y29udGludWF0aW9uKF9fSFlQRVJWSVNPUl9kb21jdGwsICJoIiwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdV9k
b21jdGwpOworICAgICAgICBlbHNlCisgICAgICAgICAgICAvKiBGaW5pc2hl
ZC4gUmV0dXJuIHRoZSBuZXcgYWxsb2NhdGlvbi4gKi8KKyAgICAgICAgICAg
IHNjLT5tYiA9IHAybV9nZXRfYWxsb2NhdGlvbihkKTsKKworICAgICAgICBy
ZXR1cm4gcmM7CisgICAgfQogICAgIGNhc2UgWEVOX0RPTUNUTF9TSEFET1df
T1BfR0VUX0FMTE9DQVRJT046CisgICAgeworICAgICAgICBzYy0+bWIgPSBw
Mm1fZ2V0X2FsbG9jYXRpb24oZCk7CiAgICAgICAgIHJldHVybiAwOworICAg
IH0KICAgICBkZWZhdWx0OgogICAgIHsKICAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgIkJhZCBwMm0gZG9tY3RsIG9wICV1XG4iLCBzYy0+b3ApOwpkaWZm
IC0tZ2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3Ay
bS5jCmluZGV4IDdkNmZlYzc4ODc5NS4uMzE5NjY5MDU0NDZlIDEwMDY0NAot
LS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMKKysrIGIveGVuL2FyY2gvYXJtL3Ay
bS5jCkBAIC01Myw2ICs1Myw1NCBAQCBzdGF0aWMgdWludDY0X3QgZ2VuZXJh
dGVfdnR0YnIodWludDE2X3Qgdm1pZCwgbWZuX3Qgcm9vdF9tZm4pCiAgICAg
cmV0dXJuIChtZm5fdG9fbWFkZHIocm9vdF9tZm4pIHwgKCh1aW50NjRfdCl2
bWlkIDw8IDQ4KSk7CiB9CiAKK3N0YXRpYyBzdHJ1Y3QgcGFnZV9pbmZvICpw
Mm1fYWxsb2NfcGFnZShzdHJ1Y3QgZG9tYWluICpkKQoreworICAgIHN0cnVj
dCBwYWdlX2luZm8gKnBnOworCisgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBh
Z2luZy5sb2NrKTsKKyAgICAvKgorICAgICAqIEZvciBoYXJkd2FyZSBkb21h
aW4sIHRoZXJlIHNob3VsZCBiZSBubyBsaW1pdCBpbiB0aGUgbnVtYmVyIG9m
IHBhZ2VzIHRoYXQKKyAgICAgKiBjYW4gYmUgYWxsb2NhdGVkLCBzbyB0aGF0
IHRoZSBrZXJuZWwgbWF5IHRha2UgYWR2YW50YWdlIG9mIHRoZSBleHRlbmRl
ZAorICAgICAqIHJlZ2lvbnMuIEhlbmNlLCBhbGxvY2F0ZSBwMm0gcGFnZXMg
Zm9yIGhhcmR3YXJlIGRvbWFpbnMgZnJvbSBoZWFwLgorICAgICAqLworICAg
IGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQpICkKKyAgICB7CisgICAgICAg
IHBnID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDApOworICAgICAgICBp
ZiAoIHBnID09IE5VTEwgKQorICAgICAgICB7CisgICAgICAgICAgICBwcmlu
dGsoWEVOTE9HX0dfRVJSICJGYWlsZWQgdG8gYWxsb2NhdGUgUDJNIHBhZ2Vz
IGZvciBod2RvbS5cbiIpOworICAgICAgICAgICAgc3Bpbl91bmxvY2soJmQt
PmFyY2gucGFnaW5nLmxvY2spOworICAgICAgICAgICAgcmV0dXJuIE5VTEw7
CisgICAgICAgIH0KKyAgICB9CisgICAgZWxzZQorICAgIHsKKyAgICAgICAg
cGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLnAy
bV9mcmVlbGlzdCk7CisgICAgICAgIGlmICggdW5saWtlbHkoIXBnKSApCisg
ICAgICAgIHsKKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBh
Z2luZy5sb2NrKTsKKyAgICAgICAgICAgIHJldHVybiBOVUxMOworICAgICAg
ICB9CisgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdlcy0t
OworICAgIH0KKyAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9j
ayk7CisKKyAgICByZXR1cm4gcGc7Cit9CisKK3N0YXRpYyB2b2lkIHAybV9m
cmVlX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHBhZ2VfaW5mbyAq
cGcpCit7CisgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsK
KyAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSApCisgICAgICAgIGZy
ZWVfZG9taGVhcF9wYWdlKHBnKTsKKyAgICBlbHNlCisgICAgeworICAgICAg
ICBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMrKzsKKyAgICAgICAg
cGFnZV9saXN0X2FkZF90YWlsKHBnLCAmZC0+YXJjaC5wYWdpbmcucDJtX2Zy
ZWVsaXN0KTsKKyAgICB9CisgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFn
aW5nLmxvY2spOworfQorCiAvKiBSZXR1cm4gdGhlIHNpemUgb2YgdGhlIHBv
b2wsIHJvdW5kZWQgdXAgdG8gdGhlIG5lYXJlc3QgTUIgKi8KIHVuc2lnbmVk
IGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCkKIHsK
QEAgLTc1NCw3ICs4MDIsNyBAQCBzdGF0aWMgaW50IHAybV9jcmVhdGVfdGFi
bGUoc3RydWN0IHAybV9kb21haW4gKnAybSwgbHBhZV90ICplbnRyeSkKIAog
ICAgIEFTU0VSVCghcDJtX2lzX3ZhbGlkKCplbnRyeSkpOwogCi0gICAgcGFn
ZSA9IGFsbG9jX2RvbWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICBwYWdlID0g
cDJtX2FsbG9jX3BhZ2UocDJtLT5kb21haW4pOwogICAgIGlmICggcGFnZSA9
PSBOVUxMICkKICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAKQEAgLTg3NCw3
ICs5MjIsNyBAQCBzdGF0aWMgdm9pZCBwMm1fZnJlZV9lbnRyeShzdHJ1Y3Qg
cDJtX2RvbWFpbiAqcDJtLAogICAgIHBnID0gbWZuX3RvX3BhZ2UobWZuKTsK
IAogICAgIHBhZ2VfbGlzdF9kZWwocGcsICZwMm0tPnBhZ2VzKTsKLSAgICBm
cmVlX2RvbWhlYXBfcGFnZShwZyk7CisgICAgcDJtX2ZyZWVfcGFnZShwMm0t
PmRvbWFpbiwgcGcpOwogfQogCiBzdGF0aWMgYm9vbCBwMm1fc3BsaXRfc3Vw
ZXJwYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIGxwYWVfdCAqZW50cnks
CkBAIC04OTgsNyArOTQ2LDcgQEAgc3RhdGljIGJvb2wgcDJtX3NwbGl0X3N1
cGVycGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBscGFlX3QgKmVudHJ5
LAogICAgIEFTU0VSVChsZXZlbCA8IHRhcmdldCk7CiAgICAgQVNTRVJUKHAy
bV9pc19zdXBlcnBhZ2UoKmVudHJ5LCBsZXZlbCkpOwogCi0gICAgcGFnZSA9
IGFsbG9jX2RvbWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICBwYWdlID0gcDJt
X2FsbG9jX3BhZ2UocDJtLT5kb21haW4pOwogICAgIGlmICggIXBhZ2UgKQog
ICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTE2MDksNyArMTY1Nyw3IEBA
IGludCBwMm1fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKIAogICAgIHdo
aWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2Vz
KSkgKQogICAgIHsKLSAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOwor
ICAgICAgICBwMm1fZnJlZV9wYWdlKHAybS0+ZG9tYWluLCBwZyk7CiAgICAg
ICAgIGNvdW50Kys7CiAgICAgICAgIC8qIEFyYml0cmFyaWx5IHByZWVtcHQg
ZXZlcnkgNTEyIGl0ZXJhdGlvbnMgKi8KICAgICAgICAgaWYgKCAhKGNvdW50
ICUgNTEyKSAmJiBoeXBlcmNhbGxfcHJlZW1wdF9jaGVjaygpICkKQEAgLTE2
MzMsNiArMTY4MSw3IEBAIHZvaWQgcDJtX2ZpbmFsX3RlYXJkb3duKHN0cnVj
dCBkb21haW4gKmQpCiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVChw
YWdlX2xpc3RfZW1wdHkoJnAybS0+cGFnZXMpKTsKKyAgICBBU1NFUlQocGFn
ZV9saXN0X2VtcHR5KCZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxpc3QpKTsK
IAogICAgIGlmICggcDJtLT5yb290ICkKICAgICAgICAgZnJlZV9kb21oZWFw
X3BhZ2VzKHAybS0+cm9vdCwgUDJNX1JPT1RfT1JERVIpOwpkaWZmIC0tZ2l0
IGEveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaCBiL3hlbi9pbmNsdWRl
L2FzbS1hcm0vZG9tYWluLmgKaW5kZXggN2JjMTRjMmU5ZTQ3Li5kYzViMjZk
MTVlMWQgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWlu
LmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaApAQCAtNzMs
NiArNzMsNyBAQCBzdHJ1Y3QgYXJjaF9kb21haW4KICAgICAgICAgUkVMTUVN
X3BhZ2UsCiAgICAgICAgIFJFTE1FTV9tYXBwaW5nLAogICAgICAgICBSRUxN
RU1fcDJtLAorICAgICAgICBSRUxNRU1fcDJtX3Bvb2wsCiAgICAgICAgIFJF
TE1FTV9kb25lLAogICAgIH0gcmVsbWVtOwogCi0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.14/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Disposition: attachment;
 filename="xsa409-4.14/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Transfer-Encoding: base64

RnJvbSAyNjA5YjZlNmQ1Mjc4M2YxYTU4ZTRjNTA4MzJhOWM2ZWJkNjcxMzM2
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IFR1ZSwgOSBBdWcgMjAyMiAwNjoz
OToyMyArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMS80XSBsaWJ4bCwgZG9jczog
VXNlIGFyY2gtc3BlY2lmaWMgZGVmYXVsdCBwYWdpbmcgbWVtb3J5CgpUaGUg
ZGVmYXVsdCBwYWdpbmcgbWVtb3J5IChkZXNjaWJlZCBpbiBgc2hhZG93X21l
bW9yeWAgZW50cnkgaW4geGwKY29uZmlnKSBpbiBsaWJ4bCBpcyB1c2VkIHRv
IGRldGVybWluZSB0aGUgbWVtb3J5IHBvb2wgc2l6ZSBmb3IgeGwKZ3Vlc3Rz
LiBDdXJyZW50bHkgdGhpcyBzaXplIGlzIG9ubHkgdXNlZCBmb3IgeDg2LCBh
bmQgY29udGFpbnMgYSBwYXJ0Cm9mIFJBTSB0byBzaGFkb3cgdGhlIHJlc2lk
ZW50IHByb2Nlc3Nlcy4gU2luY2Ugb24gQXJtIHRoZXJlIGlzIG5vCnNoYWRv
dyBtb2RlIGd1ZXN0cywgc28gdGhlIHBhcnQgb2YgUkFNIHRvIHNoYWRvdyB0
aGUgcmVzaWRlbnQgcHJvY2Vzc2VzCmlzIG5vdCBuZWNlc3NhcnkuIFRoZXJl
Zm9yZSwgdGhpcyBjb21taXQgc3BsaXRzIHRoZSBmdW5jdGlvbgpgbGlieGxf
Z2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkoKWAgdG8gYXJjaCBzcGVjaWZp
YyBoZWxwZXJzIGFuZApyZW5hbWVkIHRoZSBoZWxwZXIgdG8gYGxpYnhsX19h
cmNoX2dldF9yZXF1aXJlZF9wYWdpbmdfbWVtb3J5KClgLgoKT24geDg2LCB0
aGlzIGhlbHBlciBjYWxscyB0aGUgb3JpZ2luYWwgdmFsdWUgZnJvbQpgbGli
eGxfZ2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkoKWAgc28gbm8gZnVuY3Rp
b25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpPbiBBcm0sIHRoaXMgaGVscGVyIHJl
dHVybnMgMU1CIHBlciB2Y3B1IHBsdXMgNEtCIHBlciBNaUIgb2YgUkFNCmZv
ciB0aGUgUDJNIG1hcC4KCkFsc28gdXBkYXRlIHRoZSB4bC5jZmcgZG9jdW1l
bnRhdGlvbiB0byBhZGQgQXJtIGRvY3VtZW50YXRpb24KYWNjb3JkaW5nIHRv
IGNvZGUgY2hhbmdlcyBhbmQgY29ycmVjdCB0aGUgY29tbWVudCBzdHlsZSBm
b2xsb3dpbmcgWGVuCmNvZGluZyBzdHlsZS4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTdWdnZXN0ZWQtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEhl
bnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQtYnk6IEFu
dGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0K
IGRvY3MvbWFuL3hsLmNmZy41LnBvZC5pbiAgfCAgNSArKysrKwogdG9vbHMv
bGlieGwvbGlieGxfYXJjaC5oICB8ICA0ICsrKysKIHRvb2xzL2xpYnhsL2xp
YnhsX2FybS5jICAgfCAxMiArKysrKysrKysrKysKIHRvb2xzL2xpYnhsL2xp
YnhsX3V0aWxzLmMgfCAgOSArKy0tLS0tLS0KIHRvb2xzL2xpYnhsL2xpYnhs
X3g4Ni5jICAgfCAxMiArKysrKysrKysrKysKIDUgZmlsZXMgY2hhbmdlZCwg
MzUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9kb2NzL21hbi94bC5jZmcuNS5wb2QuaW4gYi9kb2NzL21hbi94bC5jZmcu
NS5wb2QuaW4KaW5kZXggMDUzMjczOWMxZmZmLi4yMjI0MDgwYjMwY2UgMTAw
NjQ0Ci0tLSBhL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbgorKysgYi9kb2Nz
L21hbi94bC5jZmcuNS5wb2QuaW4KQEAgLTE4MDMsNiArMTgwMywxMSBAQCBh
cmUgbm90IHVzaW5nIGhhcmR3YXJlIGFzc2lzdGVkIHBhZ2luZyAoaS5lLiB5
b3UgYXJlIHVzaW5nIHNoYWRvdwogbW9kZSkgYW5kIHlvdXIgZ3Vlc3Qgd29y
a2xvYWQgY29uc2lzdHMgb2YgYSB2ZXJ5IGxhcmdlIG51bWJlciBvZgogc2lt
aWxhciBwcm9jZXNzZXMgdGhlbiBpbmNyZWFzaW5nIHRoaXMgdmFsdWUgbWF5
IGltcHJvdmUgcGVyZm9ybWFuY2UuCiAKK09uIEFybSwgdGhpcyBmaWVsZCBp
cyB1c2VkIHRvIGRldGVybWluZSB0aGUgc2l6ZSBvZiB0aGUgZ3Vlc3QgUDJN
IHBhZ2VzCitwb29sLCBhbmQgdGhlIGRlZmF1bHQgdmFsdWUgaXMgMU1CIHBl
ciB2Q1BVIHBsdXMgNEtCIHBlciBNQiBvZiBSQU0gZm9yCit0aGUgUDJNIG1h
cC4gVXNlcnMgc2hvdWxkIGFkanVzdCB0aGlzIHZhbHVlIGlmIGJpZ2dlciBQ
Mk0gcG9vbCBzaXplIGlzCituZWVkZWQuCisKID1iYWNrCiAKID1oZWFkMyBQ
cm9jZXNzb3IgYW5kIFBsYXRmb3JtIEZlYXR1cmVzCmRpZmYgLS1naXQgYS90
b29scy9saWJ4bC9saWJ4bF9hcmNoLmggYi90b29scy9saWJ4bC9saWJ4bF9h
cmNoLmgKaW5kZXggNmE5MTc3NWI5ZTIwLi5iMDlmODY4NDkwYWMgMTAwNjQ0
Ci0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2FyY2guaAorKysgYi90b29scy9s
aWJ4bC9saWJ4bF9hcmNoLmgKQEAgLTgzLDYgKzgzLDEwIEBAIGludCBsaWJ4
bF9fYXJjaF9leHRyYV9tZW1vcnkobGlieGxfX2djICpnYywKICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfZG9tYWluX2J1aWxk
X2luZm8gKmluZm8sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVp
bnQ2NF90ICpvdXQpOwogCitfaGlkZGVuCit1bnNpZ25lZCBsb25nIGxpYnhs
X19hcmNoX2dldF9yZXF1aXJlZF9wYWdpbmdfbWVtb3J5KHVuc2lnbmVkIGxv
bmcgbWF4bWVtX2tiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgc21wX2NwdXMp
OworCiAjaWYgZGVmaW5lZChfX2kzODZfXykgfHwgZGVmaW5lZChfX3g4Nl82
NF9fKQogCiAjZGVmaW5lIExBUElDX0JBU0VfQUREUkVTUyAgMHhmZWUwMDAw
MApkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxfYXJtLmMgYi90b29s
cy9saWJ4bC9saWJ4bF9hcm0uYwppbmRleCAzNGY4YTI5MDU2ZGIuLmY0YjNk
YzhlNzEzOSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfYXJtLmMK
KysrIGIvdG9vbHMvbGlieGwvbGlieGxfYXJtLmMKQEAgLTE1Myw2ICsxNTMs
MTggQEAgb3V0OgogICAgIHJldHVybiByYzsKIH0KIAordW5zaWduZWQgbG9u
ZyBsaWJ4bF9fYXJjaF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNp
Z25lZCBsb25nIG1heG1lbV9rYiwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNt
cF9jcHVzKQoreworICAgIC8qCisgICAgICogMjU2IHBhZ2VzICgxTUIpIHBl
ciB2Y3B1LAorICAgICAqIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIGZv
ciB0aGUgUDJNIG1hcCwKKyAgICAgKiBUaGlzIGlzIGhpZ2hlciB0aGFuIHRo
ZSBtaW5pbXVtIHRoYXQgWGVuIHdvdWxkIGFsbG9jYXRlIGlmIG5vIHZhbHVl
CisgICAgICogd2VyZSBnaXZlbiAoYnV0IHRoZSBYZW4gbWluaW11bSBpcyBm
b3Igc2FmZXR5LCBub3QgcGVyZm9ybWFuY2UpLgorICAgICAqLworICAgIHJl
dHVybiA0ICogKDI1NiAqIHNtcF9jcHVzICsgbWF4bWVtX2tiIC8gMTAyNCk7
Cit9CisKIHN0YXRpYyBzdHJ1Y3QgYXJjaF9pbmZvIHsKICAgICBjb25zdCBj
aGFyICpndWVzdF90eXBlOwogICAgIGNvbnN0IGNoYXIgKnRpbWVyX2NvbXBh
dDsKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX3V0aWxzLmMgYi90
b29scy9saWJ4bC9saWJ4bF91dGlscy5jCmluZGV4IGIwMzkxNDNiOGFlZi4u
ZTE4YjE1MjRlZjc4IDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4bF91
dGlscy5jCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX3V0aWxzLmMKQEAgLTE4
LDYgKzE4LDcgQEAKICNpbmNsdWRlIDxjdHlwZS5oPgogCiAjaW5jbHVkZSAi
bGlieGxfaW50ZXJuYWwuaCIKKyNpbmNsdWRlICJsaWJ4bF9hcmNoLmgiCiAj
aW5jbHVkZSAiX3BhdGhzLmgiCiAKICNpZm5kZWYgTElCWExfSEFWRV9OT05D
T05TVF9MSUJYTF9CQVNFTkFNRV9SRVRVUk5fVkFMVUUKQEAgLTM5LDEzICs0
MCw3IEBAIGNoYXIgKmxpYnhsX2Jhc2VuYW1lKGNvbnN0IGNoYXIgKm5hbWUp
CiAKIHVuc2lnbmVkIGxvbmcgbGlieGxfZ2V0X3JlcXVpcmVkX3NoYWRvd19t
ZW1vcnkodW5zaWduZWQgbG9uZyBtYXhtZW1fa2IsIHVuc2lnbmVkIGludCBz
bXBfY3B1cykKIHsKLSAgICAvKiAyNTYgcGFnZXMgKDFNQikgcGVyIHZjcHUs
Ci0gICAgICAgcGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBSQU0gZm9yIHRoZSBQ
Mk0gbWFwLAotICAgICAgIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIHRv
IHNoYWRvdyB0aGUgcmVzaWRlbnQgcHJvY2Vzc2VzLgotICAgICAgIFRoaXMg
aXMgaGlnaGVyIHRoYW4gdGhlIG1pbmltdW0gdGhhdCBYZW4gd291bGQgYWxs
b2NhdGUgaWYgbm8gdmFsdWUKLSAgICAgICB3ZXJlIGdpdmVuIChidXQgdGhl
IFhlbiBtaW5pbXVtIGlzIGZvciBzYWZldHksIG5vdCBwZXJmb3JtYW5jZSku
Ci0gICAgICovCi0gICAgcmV0dXJuIDQgKiAoMjU2ICogc21wX2NwdXMgKyAy
ICogKG1heG1lbV9rYiAvIDEwMjQpKTsKKyAgICByZXR1cm4gbGlieGxfX2Fy
Y2hfZ2V0X3JlcXVpcmVkX3BhZ2luZ19tZW1vcnkobWF4bWVtX2tiLCBzbXBf
Y3B1cyk7CiB9CiAKIGNoYXIgKmxpYnhsX2RvbWlkX3RvX25hbWUobGlieGxf
Y3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkKQpkaWZmIC0tZ2l0IGEvdG9vbHMv
bGlieGwvbGlieGxfeDg2LmMgYi90b29scy9saWJ4bC9saWJ4bF94ODYuYwpp
bmRleCAwN2M3YjA1ZTBkMzYuLjBhZDQ1NTMwMWQ4OCAxMDA2NDQKLS0tIGEv
dG9vbHMvbGlieGwvbGlieGxfeDg2LmMKKysrIGIvdG9vbHMvbGlieGwvbGli
eGxfeDg2LmMKQEAgLTg1Miw2ICs4NTIsMTggQEAgaW50IGxpYnhsX19hcmNo
X3Bhc3N0aHJvdWdoX21vZGVfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLAog
ICAgIHJldHVybiByYzsKIH0KIAordW5zaWduZWQgbG9uZyBsaWJ4bF9fYXJj
aF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNpZ25lZCBsb25nIG1h
eG1lbV9rYiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNtcF9jcHVzKQorewor
ICAgIC8qCisgICAgICogMjU2IHBhZ2VzICgxTUIpIHBlciB2Y3B1LAorICAg
ICAqIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIGZvciB0aGUgUDJNIG1h
cCwKKyAgICAgKiBwbHVzIDEgcGFnZSBwZXIgTWlCIG9mIFJBTSB0byBzaGFk
b3cgdGhlIHJlc2lkZW50IHByb2Nlc3Nlcy4KKyAgICAgKiBUaGlzIGlzIGhp
Z2hlciB0aGFuIHRoZSBtaW5pbXVtIHRoYXQgWGVuIHdvdWxkIGFsbG9jYXRl
IGlmIG5vIHZhbHVlCisgICAgICogd2VyZSBnaXZlbiAoYnV0IHRoZSBYZW4g
bWluaW11bSBpcyBmb3Igc2FmZXR5LCBub3QgcGVyZm9ybWFuY2UpLgorICAg
ICAqLworICAgIHJldHVybiA0ICogKDI1NiAqIHNtcF9jcHVzICsgMiAqICht
YXhtZW1fa2IgLyAxMDI0KSk7Cit9CiAKIC8qCiAgKiBMb2NhbCB2YXJpYWJs
ZXM6Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.14/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Disposition: attachment;
 filename="xsa409-4.14/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Transfer-Encoding: base64

RnJvbSBhNmQ1NjM2ODQ3M2EyODNjYmZkOTNkYThlYzVjNzBiM2JjODZhYWIz
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMi80XSB4ZW4vYXJtOiBDb25z
dHJ1Y3QgdGhlIFAyTSBwYWdlcyBwb29sIGZvciBndWVzdHMKClRoaXMgY29t
bWl0IGNvbnN0cnVjdHMgdGhlIHAybSBwYWdlcyBwb29sIGZvciBndWVzdHMg
ZnJvbSB0aGUKZGF0YSBzdHJ1Y3R1cmUgYW5kIGhlbHBlciBwZXJzcGVjdGl2
ZS4KClRoaXMgaXMgaW1wbGVtZW50ZWQgYnk6CgotIEFkZGluZyBhIGBzdHJ1
Y3QgcGFnaW5nX2RvbWFpbmAgd2hpY2ggY29udGFpbnMgYSBmcmVlbGlzdCwg
YQpjb3VudGVyIHZhcmlhYmxlIGFuZCBhIHNwaW5sb2NrIHRvIGBzdHJ1Y3Qg
YXJjaF9kb21haW5gIHRvCmluZGljYXRlIHRoZSBmcmVlIHAybSBwYWdlcyBh
bmQgdGhlIG51bWJlciBvZiBwMm0gdG90YWwgcGFnZXMgaW4KdGhlIHAybSBw
YWdlcyBwb29sLgoKLSBBZGRpbmcgYSBoZWxwZXIgYHAybV9nZXRfYWxsb2Nh
dGlvbmAgdG8gZ2V0IHRoZSBwMm0gcG9vbCBzaXplLgoKLSBBZGRpbmcgYSBo
ZWxwZXIgYHAybV9zZXRfYWxsb2NhdGlvbmAgdG8gc2V0IHRoZSBwMm0gcGFn
ZXMgcG9vbApzaXplLiBUaGlzIGhlbHBlciBzaG91bGQgYmUgY2FsbGVkIGJl
Zm9yZSBhbGxvY2F0aW5nIG1lbW9yeSBmb3IKYSBndWVzdC4KCi0gQWRkaW5n
IGEgaGVscGVyIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAgdG8gZnJlZSB0
aGUgcDJtIHBhZ2VzCnBvb2wuIFRoaXMgaGVscGVyIHNob3VsZCBiZSBjYWxs
ZWQgZHVyaW5nIHRoZSB4bCBkb21haW4gZGVzdG9yeS4KClRoaXMgaXMgcGFy
dCBvZiBDVkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTaWduZWQtb2ZmLWJ5
OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5
OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+
Ci0tLQogeGVuL2FyY2gvYXJtL3AybS5jICAgICAgICAgICB8IDg4ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogeGVuL2luY2x1ZGUv
YXNtLWFybS9kb21haW4uaCB8IDEwICsrKysKIHhlbi9pbmNsdWRlL2FzbS1h
cm0vcDJtLmggICAgfCAgNCArKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDIgaW5z
ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBi
L3hlbi9hcmNoL2FybS9wMm0uYwppbmRleCA2MmY0ZDMxZGMxY2MuLjBjMzMx
YTM2YTUzNiAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCisrKyBi
L3hlbi9hcmNoL2FybS9wMm0uYwpAQCAtNDksNiArNDksOTIgQEAgc3RhdGlj
IHVpbnQ2NF90IGdlbmVyYXRlX3Z0dGJyKHVpbnQxNl90IHZtaWQsIG1mbl90
IHJvb3RfbWZuKQogICAgIHJldHVybiAobWZuX3RvX21hZGRyKHJvb3RfbWZu
KSB8ICgodWludDY0X3Qpdm1pZCA8PCA0OCkpOwogfQogCisvKiBSZXR1cm4g
dGhlIHNpemUgb2YgdGhlIHBvb2wsIHJvdW5kZWQgdXAgdG8gdGhlIG5lYXJl
c3QgTUIgKi8KK3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIG5yX3BhZ2Vz
ID0gQUNDRVNTX09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2Vz
KTsKKworICAgIHJldHVybiBST1VORFVQKG5yX3BhZ2VzLCAxIDw8ICgyMCAt
IFBBR0VfU0hJRlQpKSA+PiAoMjAgLSBQQUdFX1NISUZUKTsKK30KKworLyoK
KyAqIFNldCB0aGUgcG9vbCBvZiBwYWdlcyB0byB0aGUgcmVxdWlyZWQgbnVt
YmVyIG9mIHBhZ2VzLgorICogUmV0dXJucyAwIGZvciBzdWNjZXNzLCBub24t
emVybyBmb3IgZmFpbHVyZS4KKyAqIENhbGwgd2l0aCBkLT5hcmNoLnBhZ2lu
Zy5sb2NrIGhlbGQuCisgKi8KK2ludCBwMm1fc2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBwYWdlcywgYm9vbCAqcHJl
ZW1wdGVkKQoreworICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOworCisgICAg
QVNTRVJUKHNwaW5faXNfbG9ja2VkKCZkLT5hcmNoLnBhZ2luZy5sb2NrKSk7
CisKKyAgICBmb3IgKCA7IDsgKQorICAgIHsKKyAgICAgICAgaWYgKCBkLT5h
cmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPCBwYWdlcyApCisgICAgICAg
IHsKKyAgICAgICAgICAgIC8qIE5lZWQgdG8gYWxsb2NhdGUgbW9yZSBtZW1v
cnkgZnJvbSBkb21oZWFwICovCisgICAgICAgICAgICBwZyA9IGFsbG9jX2Rv
bWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICAgICAgICAgIGlmICggcGcgPT0g
TlVMTCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRr
KFhFTkxPR19FUlIgIkZhaWxlZCB0byBhbGxvY2F0ZSBQMk0gcGFnZXMuXG4i
KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKKyAgICAgICAg
ICAgIH0KKyAgICAgICAgICAgIEFDQ0VTU19PTkNFKGQtPmFyY2gucGFnaW5n
LnAybV90b3RhbF9wYWdlcykgPQorICAgICAgICAgICAgICAgIGQtPmFyY2gu
cGFnaW5nLnAybV90b3RhbF9wYWdlcyArIDE7CisgICAgICAgICAgICBwYWdl
X2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxp
c3QpOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBkLT5hcmNoLnBh
Z2luZy5wMm1fdG90YWxfcGFnZXMgPiBwYWdlcyApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIC8qIE5lZWQgdG8gcmV0dXJuIG1lbW9yeSB0byBkb21oZWFw
ICovCisgICAgICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgm
ZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgICAgIGlm
KCBwZyApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgQUNDRVNT
X09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzKSA9CisgICAg
ICAgICAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cyAtIDE7CisgICAgICAgICAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcp
OworICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSCisgICAg
ICAgICAgICAgICAgICAgICAgICJGYWlsZWQgdG8gZnJlZSBQMk0gcGFnZXMs
IFAyTSBmcmVlbGlzdCBpcyBlbXB0eS5cbiIpOworICAgICAgICAgICAgICAg
IHJldHVybiAtRU5PTUVNOworICAgICAgICAgICAgfQorICAgICAgICB9Cisg
ICAgICAgIGVsc2UKKyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIC8q
IENoZWNrIHRvIHNlZSBpZiB3ZSBuZWVkIHRvIHlpZWxkIGFuZCB0cnkgYWdh
aW4gKi8KKyAgICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgZ2VuZXJhbF9wcmVl
bXB0X2NoZWNrKCkgKQorICAgICAgICB7CisgICAgICAgICAgICAqcHJlZW1w
dGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7Cisg
ICAgICAgIH0KKyAgICB9CisKKyAgICByZXR1cm4gMDsKK30KKworaW50IHAy
bV90ZWFyZG93bl9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQpCit7Cisg
ICAgaW50IHJldCA9IDA7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsK
KworICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAg
aWYgKCBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgIT0gMCApCisg
ICAgeworICAgICAgICByZXQgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwg
JnByZWVtcHRlZCk7CisgICAgICAgIGlmICggcHJlZW1wdGVkICkKKyAgICAg
ICAgeworICAgICAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5n
LmxvY2spOworICAgICAgICAgICAgcmV0dXJuIC1FUkVTVEFSVDsKKyAgICAg
ICAgfQorICAgICAgICBBU1NFUlQoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFs
X3BhZ2VzID09IDApOworICAgIH0KKyAgICBzcGluX3VubG9jaygmZC0+YXJj
aC5wYWdpbmcubG9jayk7CisKKyAgICByZXR1cm4gcmV0OworfQorCiAvKiBV
bmxvY2sgdGhlIGZsdXNoIGFuZCBkbyBhIFAyTSBUTEIgZmx1c2ggaWYgbmVj
ZXNzYXJ5ICovCiB2b2lkIHAybV93cml0ZV91bmxvY2soc3RydWN0IHAybV9k
b21haW4gKnAybSkKIHsKQEAgLTE1NjgsNyArMTY1NCw5IEBAIGludCBwMm1f
aW5pdChzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2lnbmVkIGludCBjcHU7
CiAKICAgICByd2xvY2tfaW5pdCgmcDJtLT5sb2NrKTsKKyAgICBzcGluX2xv
Y2tfaW5pdCgmZC0+YXJjaC5wYWdpbmcubG9jayk7CiAgICAgSU5JVF9QQUdF
X0xJU1RfSEVBRCgmcDJtLT5wYWdlcyk7CisgICAgSU5JVF9QQUdFX0xJU1Rf
SEVBRCgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKIAogICAgIHAy
bS0+dm1pZCA9IElOVkFMSURfVk1JRDsKIApkaWZmIC0tZ2l0IGEveGVuL2lu
Y2x1ZGUvYXNtLWFybS9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v
ZG9tYWluLmgKaW5kZXggOWM0ZGI3NWYwODdkLi45NmE4NzhkMzM0NDggMTAw
NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaApAQCAtNDIsNiArNDIsMTQg
QEAgc3RydWN0IHZ0aW1lciB7CiAgICAgdWludDY0X3QgY3ZhbDsKIH07CiAK
K3N0cnVjdCBwYWdpbmdfZG9tYWluIHsKKyAgICBzcGlubG9ja190IGxvY2s7
CisgICAgLyogRnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgcHJlLWFsbG9jYXRl
ZCBQMk0gcG9vbCAqLworICAgIHN0cnVjdCBwYWdlX2xpc3RfaGVhZCBwMm1f
ZnJlZWxpc3Q7CisgICAgLyogTnVtYmVyIG9mIHBhZ2VzIGZyb20gdGhlIHBy
ZS1hbGxvY2F0ZWQgUDJNIHBvb2wgKi8KKyAgICB1bnNpZ25lZCBsb25nIHAy
bV90b3RhbF9wYWdlczsKK307CisKIHN0cnVjdCBhcmNoX2RvbWFpbgogewog
I2lmZGVmIENPTkZJR19BUk1fNjQKQEAgLTUzLDYgKzYxLDggQEAgc3RydWN0
IGFyY2hfZG9tYWluCiAKICAgICBzdHJ1Y3QgaHZtX2RvbWFpbiBodm07CiAK
KyAgICBzdHJ1Y3QgcGFnaW5nX2RvbWFpbiBwYWdpbmc7CisKICAgICBzdHJ1
Y3Qgdm1taW8gdm1taW87CiAKICAgICAvKiBDb250aW51YWJsZSBkb21haW5f
cmVsaW5xdWlzaF9yZXNvdXJjZXMoKS4gKi8KZGlmZiAtLWdpdCBhL3hlbi9p
bmNsdWRlL2FzbS1hcm0vcDJtLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3Ay
bS5oCmluZGV4IGY0MGY4Mjc5NGRhOS4uYjczM2Y1NWQ0ODFjIDEwMDY0NAot
LS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCisrKyBiL3hlbi9pbmNs
dWRlL2FzbS1hcm0vcDJtLmgKQEAgLTIwOSw2ICsyMDksMTAgQEAgdm9pZCBw
Mm1fcmVzdG9yZV9zdGF0ZShzdHJ1Y3QgdmNwdSAqbik7CiAvKiBQcmludCBk
ZWJ1Z2dpbmcvc3RhdGlzdGlhbCBpbmZvIGFib3V0IGEgZG9tYWluJ3MgcDJt
ICovCiB2b2lkIHAybV9kdW1wX2luZm8oc3RydWN0IGRvbWFpbiAqZCk7CiAK
K3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3RydWN0IGRvbWFp
biAqZCk7CitpbnQgcDJtX3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4g
KmQsIHVuc2lnbmVkIGxvbmcgcGFnZXMsIGJvb2wgKnByZWVtcHRlZCk7Citp
bnQgcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCk7
CisKIHN0YXRpYyBpbmxpbmUgdm9pZCBwMm1fd3JpdGVfbG9jayhzdHJ1Y3Qg
cDJtX2RvbWFpbiAqcDJtKQogewogICAgIHdyaXRlX2xvY2soJnAybS0+bG9j
ayk7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.14/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Disposition: attachment;
 filename="xsa409-4.14/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Transfer-Encoding: base64

RnJvbSA3NDM2NWQ4YWI0NTQzOTYzYmJhYzgzY2ZmNzdlNzQyYTNjYzhhZGIw
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMy80XSB4ZW4vYXJtLCBsaWJ4
bDogSW1wbGVtZW50IFhFTl9ET01DVExfc2hhZG93X29wIGZvciBBcm0KClRo
aXMgY29tbWl0IGltcGxlbWVudHMgdGhlIGBYRU5fRE9NQ1RMX3NoYWRvd19v
cGAgc3VwcG9ydCBpbiBYZW4KZm9yIEFybS4gVGhlIHAybSBwYWdlcyBwb29s
IHNpemUgZm9yIHhsIGd1ZXN0cyBpcyBzdXBwb3NlZCB0byBiZQpkZXRlcm1p
bmVkIGJ5IGBYRU5fRE9NQ1RMX3NoYWRvd19vcGAuIEhlbmNlLCB0aGlzIGNv
bW1pdDoKCi0gSW50cm9kdWNlcyBhIGZ1bmN0aW9uIGBwMm1fZG9tY3RsYCBh
bmQgaW1wbGVtZW50cyB0aGUgc3Vib3BzCmBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTmAgYW5kCmBYRU5fRE9NQ1RMX1NIQURPV19PUF9H
RVRfQUxMT0NBVElPTmAgb2YgYFhFTl9ET01DVExfc2hhZG93X29wYC4KCi0g
QWRkcyB0aGUgYFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FUSU9O
YCBzdXBwb3J0IGluIGxpYnhsLgoKVGhlcmVmb3JlIGVuYWJsaW5nIHRoZSBz
ZXR0aW5nIG9mIHNoYWRvdyBtZW1vcnkgcG9vbCBzaXplCndoZW4gY3JlYXRp
bmcgYSBndWVzdCBmcm9tIHhsIGFuZCBnZXR0aW5nIHNoYWRvdyBtZW1vcnkg
cG9vbCBzaXplCmZyb20gWGVuLgoKTm90ZSB0aGF0IHRoZSBgWEVOX0RPTUNU
TF9zaGFkb3dfb3BgIGFkZGVkIGluIHRoaXMgY29tbWl0IGlzIG9ubHkKYSBk
dW1teSBvcCwgYW5kIHRoZSBmdW5jdGlvbmFsaXR5IG9mIHNldHRpbmcvZ2V0
dGluZyBwMm0gbWVtb3J5IHBvb2wKc2l6ZSBmb3IgeGwgZ3Vlc3RzIHdpbGwg
YmUgYWRkZWQgaW4gZm9sbG93aW5nIGNvbW1pdHMuCgpUaGlzIGlzIHBhcnQg
b2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0EtNDA5LgoKU2lnbmVkLW9mZi1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPgpSZXZpZXdlZC1ieTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgot
LS0KIHRvb2xzL2xpYnhsL2xpYnhsX2FybS5jIHwgMTIgKysrKysrKysrKysr
CiB4ZW4vYXJjaC9hcm0vZG9tY3RsLmMgICB8IDMyICsrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2Vy
dGlvbnMoKykKCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9hcm0u
YyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2FybS5jCmluZGV4IGY0YjNkYzhlNzEz
OS4uMDI1ZGYxYmZkMDA0IDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4
bF9hcm0uYworKysgYi90b29scy9saWJ4bC9saWJ4bF9hcm0uYwpAQCAtMTMw
LDYgKzEzMCwxOCBAQCBpbnQgbGlieGxfX2FyY2hfZG9tYWluX3NhdmVfY29u
ZmlnKGxpYnhsX19nYyAqZ2MsCiBpbnQgbGlieGxfX2FyY2hfZG9tYWluX2Ny
ZWF0ZShsaWJ4bF9fZ2MgKmdjLCBsaWJ4bF9kb21haW5fY29uZmlnICpkX2Nv
bmZpZywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90
IGRvbWlkKQogeworICAgIGxpYnhsX2N0eCAqY3R4ID0gbGlieGxfX2djX293
bmVyKGdjKTsKKyAgICB1bnNpZ25lZCBpbnQgc2hhZG93X21iID0gRElWX1JP
VU5EVVAoZF9jb25maWctPmJfaW5mby5zaGFkb3dfbWVta2IsIDEwMjQpOwor
CisgICAgaW50IHIgPSB4Y19zaGFkb3dfY29udHJvbChjdHgtPnhjaCwgZG9t
aWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBYRU5fRE9NQ1RM
X1NIQURPV19PUF9TRVRfQUxMT0NBVElPTiwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICZzaGFkb3dfbWIsIDApOworICAgIGlmIChyKSB7Cisg
ICAgICAgIExPR0VEKEVSUk9SLCBkb21pZCwKKyAgICAgICAgICAgICAgIkZh
aWxlZCB0byBzZXQgJXUgTWlCIHNoYWRvdyBhbGxvY2F0aW9uIiwgc2hhZG93
X21iKTsKKyAgICAgICAgcmV0dXJuIEVSUk9SX0ZBSUw7CisgICAgfQorCiAg
ICAgcmV0dXJuIDA7CiB9CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9k
b21jdGwuYyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwppbmRleCA5ZGE4OGI4
YzY0ZTIuLmVmMTI5OWFlMWM2NCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJt
L2RvbWN0bC5jCisrKyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwpAQCAtNDUs
MTEgKzQ1LDQzIEBAIHN0YXRpYyBpbnQgaGFuZGxlX3Z1YXJ0X2luaXQoc3Ry
dWN0IGRvbWFpbiAqZCwKICAgICByZXR1cm4gcmM7CiB9CiAKK3N0YXRpYyBs
b25nIHAybV9kb21jdGwoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhlbl9k
b21jdGxfc2hhZG93X29wICpzYywKKyAgICAgICAgICAgICAgICAgICAgICAg
WEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3Rs
KQoreworICAgIGlmICggdW5saWtlbHkoZCA9PSBjdXJyZW50LT5kb21haW4p
ICkKKyAgICB7CisgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJUcmllZCB0
byBkbyBhIHAybSBkb21jdGwgb3Agb24gaXRzZWxmLlxuIik7CisgICAgICAg
IHJldHVybiAtRUlOVkFMOworICAgIH0KKworICAgIGlmICggdW5saWtlbHko
ZC0+aXNfZHlpbmcpICkKKyAgICB7CisgICAgICAgIHByaW50ayhYRU5MT0df
RVJSICJUcmllZCB0byBkbyBhIHAybSBkb21jdGwgb3Agb24gZHlpbmcgZG9t
YWluICV1XG4iLAorICAgICAgICAgICAgICAgZC0+ZG9tYWluX2lkKTsKKyAg
ICAgICAgcmV0dXJuIC1FSU5WQUw7CisgICAgfQorCisgICAgc3dpdGNoICgg
c2MtPm9wICkKKyAgICB7CisgICAgY2FzZSBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTjoKKyAgICAgICAgcmV0dXJuIDA7CisgICAgY2Fz
ZSBYRU5fRE9NQ1RMX1NIQURPV19PUF9HRVRfQUxMT0NBVElPTjoKKyAgICAg
ICAgcmV0dXJuIDA7CisgICAgZGVmYXVsdDoKKyAgICB7CisgICAgICAgIHBy
aW50ayhYRU5MT0dfRVJSICJCYWQgcDJtIGRvbWN0bCBvcCAldVxuIiwgc2Mt
Pm9wKTsKKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7CisgICAgfQorICAgIH0K
K30KKwogbG9uZyBhcmNoX2RvX2RvbWN0bChzdHJ1Y3QgeGVuX2RvbWN0bCAq
ZG9tY3RsLCBzdHJ1Y3QgZG9tYWluICpkLAogICAgICAgICAgICAgICAgICAg
ICBYRU5fR1VFU1RfSEFORExFX1BBUkFNKHhlbl9kb21jdGxfdCkgdV9kb21j
dGwpCiB7CiAgICAgc3dpdGNoICggZG9tY3RsLT5jbWQgKQogICAgIHsKKyAg
ICBjYXNlIFhFTl9ET01DVExfc2hhZG93X29wOgorICAgICAgICByZXR1cm4g
cDJtX2RvbWN0bChkLCAmZG9tY3RsLT51LnNoYWRvd19vcCwgdV9kb21jdGwp
OwogICAgIGNhc2UgWEVOX0RPTUNUTF9jYWNoZWZsdXNoOgogICAgIHsKICAg
ICAgICAgZ2ZuX3QgcyA9IF9nZm4oZG9tY3RsLT51LmNhY2hlZmx1c2guc3Rh
cnRfcGZuKTsKLS0gCjIuMzcuMQoK

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.14/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Disposition: attachment;
 filename="xsa409-4.14/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Transfer-Encoding: base64

RnJvbSBiNGE2YTkzYzhlMDY0MDNjMWJlZGZhMTQ1ODNhYWQ4Yjg0MDFlMzAx
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzozMCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSB4ZW4vYXJtOiBBbGxv
Y2F0ZSBhbmQgZnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgUDJNIHBvb2wKClRo
aXMgY29tbWl0IHNldHMvdGVhcnNkb3duIG9mIHAybSBwYWdlcyBwb29sIGZv
ciBub24tcHJpdmlsZWdlZCBBcm0KZ3Vlc3RzIGJ5IGNhbGxpbmcgYHAybV9z
ZXRfYWxsb2NhdGlvbmAgYW5kIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAu
CgotIEZvciBkb20wLCBQMk0gcGFnZXMgc2hvdWxkIGNvbWUgZnJvbSBoZWFw
IGRpcmVjdGx5IGluc3RlYWQgb2YgcDJtCnBvb2wsIHNvIHRoYXQgdGhlIGtl
cm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGV4dGVuZGVkIHJlZ2lv
bnMuCgotIEZvciB4bCBndWVzdHMsIHRoZSBzZXR0aW5nIG9mIHRoZSBwMm0g
cG9vbCBpcyBjYWxsZWQgaW4KYFhFTl9ET01DVExfc2hhZG93X29wYCBhbmQg
dGhlIHAybSBwb29sIGlzIGRlc3Ryb3llZCBpbgpgZG9tYWluX3JlbGlucXVp
c2hfcmVzb3VyY2VzYC4gTm90ZSB0aGF0IGRvbWN0bC0+dS5zaGFkb3dfb3Au
bWIgaXMKdXBkYXRlZCB3aXRoIHRoZSBuZXcgc2l6ZSB3aGVuIHNldHRpbmcg
dGhlIHAybSBwb29sLgoKLSBGb3IgZG9tMGxlc3MgZG9tVXMsIHRoZSBzZXR0
aW5nIG9mIHRoZSBwMm0gcG9vbCBpcyBjYWxsZWQgYmVmb3JlCmFsbG9jYXRp
bmcgbWVtb3J5IGR1cmluZyBkb21haW4gY3JlYXRpb24uIFVzZXJzIGNhbiBz
cGVjaWZ5IHRoZSBwMm0KcG9vbCBzaXplIGJ5IGB4ZW4sZG9tYWluLXAybS1t
ZW0tbWJgIGR0cyBwcm9wZXJ0eS4KClRvIGFjdHVhbGx5IGFsbG9jYXRlL2Zy
ZWUgcGFnZXMgZnJvbSB0aGUgcDJtIHBvb2wsIHRoaXMgY29tbWl0IGFkZHMK
dHdvIGhlbHBlciBmdW5jdGlvbnMgbmFtZWx5IGBwMm1fYWxsb2NfcGFnZWAg
YW5kIGBwMm1fZnJlZV9wYWdlYCB0bwpgc3RydWN0IHAybV9kb21haW5gLiBC
eSByZXBsYWNpbmcgdGhlIGBhbGxvY19kb21oZWFwX3BhZ2VgIGFuZApgZnJl
ZV9kb21oZWFwX3BhZ2VgIHdpdGggdGhlc2UgdHdvIGhlbHBlciBmdW5jdGlv
bnMsIHAybSBwYWdlcyBjYW4KYmUgYWRkZWQvcmVtb3ZlZCBmcm9tIHRoZSBs
aXN0IG9mIHAybSBwb29sIHJhdGhlciB0aGFuIGZyb20gdGhlIGhlYXAuCgpT
aW5jZSBwYWdlIGZyb20gYHAybV9hbGxvY19wYWdlYCBpcyBjbGVhbmVkLCB0
YWtlIHRoZSBvcHBvcnR1bml0eQp0byByZW1vdmUgdGhlIHJlZHVuZGFudCBg
Y2xlYW5fcGFnZWAgaW4gYHAybV9jcmVhdGVfdGFibGVgLgoKVGhpcyBpcyBw
YXJ0IG9mIENWRS0yMDIyLTMzNzQ3IC8gWFNBLTQwOS4KClNpZ25lZC1vZmYt
Ynk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQt
Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y
Zz4KLS0tCiBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0
IHwgIDggKysrKwogeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAg
ICAgICB8ICA2ICsrKwogeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAg
ICAgICAgICB8IDI5ICsrKysrKysrKysrKysrCiB4ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMgICAgICAgICAgICAgICAgIHwgMjMgKysrKysrKysrKy0KIHhlbi9h
cmNoL2FybS9wMm0uYyAgICAgICAgICAgICAgICAgICAgfCA1NyArKysrKysr
KysrKysrKysrKysrKysrKysrLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTE4IGlu
c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9j
cy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCBiL2RvY3MvbWlz
Yy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKaW5kZXggNTI0M2JjN2Zk
MzQ0Li40NzBjOTQ5MWE3ODEgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlzYy9hcm0v
ZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKKysrIGIvZG9jcy9taXNjL2FybS9k
ZXZpY2UtdHJlZS9ib290aW5nLnR4dApAQCAtMTY0LDYgKzE2NCwxNCBAQCB3
aXRoIHRoZSBmb2xsb3dpbmcgcHJvcGVydGllczoKICAgICBCb3RoICNhZGRy
ZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBuZWVkIHRvIGJlIHNwZWNpZmll
ZCBiZWNhdXNlCiAgICAgYm90aCBzdWItbm9kZXMgKGRlc2NyaWJlZCBzaG9y
dGx5KSBoYXZlIHJlZyBwcm9wZXJ0aWVzLgogCistIHhlbixkb21haW4tcDJt
LW1lbS1tYgorCisgICAgT3B0aW9uYWwuIEEgMzItYml0IGludGVnZXIgc3Bl
Y2lmeWluZyB0aGUgYW1vdW50IG9mIG1lZ2FieXRlcyBvZiBSQU0KKyAgICB1
c2VkIGZvciB0aGUgZG9tYWluIFAyTSBwb29sLiBUaGlzIGlzIGluLXN5bmMg
d2l0aCB0aGUgc2hhZG93X21lbW9yeQorICAgIG9wdGlvbiBpbiB4bC5jZmcu
IExlYXZpbmcgdGhpcyBmaWVsZCBlbXB0eSBpbiBkZXZpY2UgdHJlZSB3aWxs
IGxlYWQgdG8KKyAgICB0aGUgZGVmYXVsdCBzaXplIG9mIGRvbWFpbiBQMk0g
cG9vbCwgaS5lLiAxTUIgcGVyIGd1ZXN0IHZDUFUgcGx1cyA0S0IKKyAgICBw
ZXIgTUIgb2YgZ3Vlc3QgUkFNIHBsdXMgNTEyS0IgZm9yIGd1ZXN0IGV4dGVu
ZGVkIHJlZ2lvbnMuCisKIFVuZGVyIHRoZSAieGVuLGRvbWFpbiIgY29tcGF0
aWJsZSBub2RlLCBvbmUgb3IgbW9yZSBzdWItbm9kZXMgYXJlIHByZXNlbnQK
IGZvciB0aGUgRG9tVSBrZXJuZWwgYW5kIHJhbWRpc2suCiAKZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21h
aW4uYwppbmRleCBjYWE2MjViZDE2ZjkuLmFhZTYxNWY3ZDZhZCAxMDA2NDQK
LS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL2Fy
bS9kb21haW4uYwpAQCAtOTgwLDYgKzk4MCw3IEBAIGVudW0gewogICAgIFBS
T0dfcGFnZSwKICAgICBQUk9HX21hcHBpbmcsCiAgICAgUFJPR19wMm0sCisg
ICAgUFJPR19wMm1fcG9vbCwKICAgICBQUk9HX2RvbmUsCiB9OwogCkBAIC0x
MDM1LDYgKzEwMzYsMTEgQEAgaW50IGRvbWFpbl9yZWxpbnF1aXNoX3Jlc291
cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQogICAgICAgICBpZiAoIHJldCApCiAg
ICAgICAgICAgICByZXR1cm4gcmV0OwogCisgICAgUFJPR1JFU1MocDJtX3Bv
b2wpOgorICAgICAgICByZXQgPSBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbihk
KTsKKyAgICAgICAgaWYoIHJldCApCisgICAgICAgICAgICByZXR1cm4gcmV0
OworCiAgICAgUFJPR1JFU1MoZG9uZSk6CiAgICAgICAgIGJyZWFrOwogCmRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4v
YXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKaW5kZXggZjQ5ZGJmMWNhMTJlLi4z
YzA1ZmE1YWM3ZDAgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5f
YnVpbGQuYworKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKQEAg
LTIzMzMsNiArMjMzMywyMSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZmluZF9n
bnR0YWJfcmVnaW9uKHN0cnVjdCBkb21haW4gKmQsCiAgICAgICAgICAgIGtp
bmZvLT5nbnR0YWJfc3RhcnQsIGtpbmZvLT5nbnR0YWJfc3RhcnQgKyBraW5m
by0+Z250dGFiX3NpemUpOwogfQogCitzdGF0aWMgdW5zaWduZWQgbG9uZyBf
X2luaXQgZG9tYWluX3AybV9wYWdlcyh1bnNpZ25lZCBsb25nIG1heG1lbV9r
YiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHVuc2lnbmVkIGludCBzbXBfY3B1cykKK3sKKyAgICAvKgorICAgICAq
IEtlZXAgaW4gc3luYyB3aXRoIGxpYnhsX19nZXRfcmVxdWlyZWRfcGFnaW5n
X21lbW9yeSgpLgorICAgICAqIDI1NiBwYWdlcyAoMU1CKSBwZXIgdmNwdSwg
cGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBSQU0gZm9yIHRoZSBQMk0gbWFwLAor
ICAgICAqIHBsdXMgMTI4IHBhZ2VzIHRvIGNvdmVyIGV4dGVuZGVkIHJlZ2lv
bnMuCisgICAgICovCisgICAgdW5zaWduZWQgbG9uZyBtZW1rYiA9IDQgKiAo
MjU2ICogc21wX2NwdXMgKyAobWF4bWVtX2tiIC8gMTAyNCkgKyAxMjgpOwor
CisgICAgQlVJTERfQlVHX09OKFBBR0VfU0laRSAhPSBTWl80Syk7CisKKyAg
ICByZXR1cm4gRElWX1JPVU5EX1VQKG1lbWtiLCAxMDI0KSA8PCAoMjAgLSBQ
QUdFX1NISUZUKTsKK30KKwogc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0
X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8g
KmtpbmZvKQogewogICAgIHVuc2lnbmVkIGludCBpOwpAQCAtMjQyNCw2ICsy
NDM5LDggQEAgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3Ry
dWN0IGRvbWFpbiAqZCwKICAgICBzdHJ1Y3Qga2VybmVsX2luZm8ga2luZm8g
PSB7fTsKICAgICBpbnQgcmM7CiAgICAgdTY0IG1lbTsKKyAgICB1MzIgcDJt
X21lbV9tYjsKKyAgICB1bnNpZ25lZCBsb25nIHAybV9wYWdlczsKIAogICAg
IHJjID0gZHRfcHJvcGVydHlfcmVhZF91NjQobm9kZSwgIm1lbW9yeSIsICZt
ZW0pOwogICAgIGlmICggIXJjICkKQEAgLTI0MzMsNiArMjQ1MCwxOCBAQCBz
dGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWlu
ICpkLAogICAgIH0KICAgICBraW5mby51bmFzc2lnbmVkX21lbSA9IChwYWRk
cl90KW1lbSAqIFNaXzFLOwogCisgICAgcmMgPSBkdF9wcm9wZXJ0eV9yZWFk
X3UzMihub2RlLCAieGVuLGRvbWFpbi1wMm0tbWVtLW1iIiwgJnAybV9tZW1f
bWIpOworICAgIC8qIElmIHhlbixkb21haW4tcDJtLW1lbS1tYiBpcyBub3Qg
c3BlY2lmaWVkLCB1c2UgdGhlIGRlZmF1bHQgdmFsdWUuICovCisgICAgcDJt
X3BhZ2VzID0gcmMgPworICAgICAgICAgICAgICAgIHAybV9tZW1fbWIgPDwg
KDIwIC0gUEFHRV9TSElGVCkgOgorICAgICAgICAgICAgICAgIGRvbWFpbl9w
Mm1fcGFnZXMobWVtLCBkLT5tYXhfdmNwdXMpOworCisgICAgc3Bpbl9sb2Nr
KCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICByYyA9IHAybV9zZXRfYWxs
b2NhdGlvbihkLCBwMm1fcGFnZXMsIE5VTEwpOworICAgIHNwaW5fdW5sb2Nr
KCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICBpZiAoIHJjICE9IDAgKQor
ICAgICAgICByZXR1cm4gcmM7CisKICAgICBwcmludGsoIioqKiBMT0FESU5H
IERPTVUgY3B1cz0ldSBtZW1vcnk9JSJQUkl4NjQiS0IgKioqXG4iLCBkLT5t
YXhfdmNwdXMsIG1lbSk7CiAKICAgICBraW5mby52cGwwMTEgPSBkdF9wcm9w
ZXJ0eV9yZWFkX2Jvb2wobm9kZSwgInZwbDAxMSIpOwpkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gvYXJtL2RvbWN0bC5jIGIveGVuL2FyY2gvYXJtL2RvbWN0bC5j
CmluZGV4IGVmMTI5OWFlMWM2NC4uZGFiM2RhM2EyM2JjIDEwMDY0NAotLS0g
YS94ZW4vYXJjaC9hcm0vZG9tY3RsLmMKKysrIGIveGVuL2FyY2gvYXJtL2Rv
bWN0bC5jCkBAIC00OCw2ICs0OCw5IEBAIHN0YXRpYyBpbnQgaGFuZGxlX3Z1
YXJ0X2luaXQoc3RydWN0IGRvbWFpbiAqZCwKIHN0YXRpYyBsb25nIHAybV9k
b21jdGwoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhlbl9kb21jdGxfc2hh
ZG93X29wICpzYywKICAgICAgICAgICAgICAgICAgICAgICAgWEVOX0dVRVNU
X0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKQogeworICAg
IGxvbmcgcmM7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsKKwogICAg
IGlmICggdW5saWtlbHkoZCA9PSBjdXJyZW50LT5kb21haW4pICkKICAgICB7
CiAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJUcmllZCB0byBkbyBhIHAy
bSBkb21jdGwgb3Agb24gaXRzZWxmLlxuIik7CkBAIC02NCw5ICs2NywyNyBA
QCBzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQsIHN0
cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCiAgICAgc3dpdGNoICgg
c2MtPm9wICkKICAgICB7CiAgICAgY2FzZSBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTjoKLSAgICAgICAgcmV0dXJuIDA7CisgICAgewor
ICAgICAgICAvKiBBbGxvdyBhbmQgaGFuZGxlIHByZWVtcHRpb24gKi8KKyAg
ICAgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICAg
ICAgcmMgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgc2MtPm1iIDw8ICgyMCAt
IFBBR0VfU0hJRlQpLCAmcHJlZW1wdGVkKTsKKyAgICAgICAgc3Bpbl91bmxv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworCisgICAgICAgIGlmICggcHJl
ZW1wdGVkICkKKyAgICAgICAgICAgIC8qIE5vdCBmaW5pc2hlZC4gU2V0IHVw
IHRvIHJlLXJ1biB0aGUgY2FsbC4gKi8KKyAgICAgICAgICAgIHJjID0gaHlw
ZXJjYWxsX2NyZWF0ZV9jb250aW51YXRpb24oX19IWVBFUlZJU09SX2RvbWN0
bCwgImgiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1X2RvbWN0bCk7CisgICAgICAgIGVsc2UKKyAgICAgICAg
ICAgIC8qIEZpbmlzaGVkLiBSZXR1cm4gdGhlIG5ldyBhbGxvY2F0aW9uLiAq
LworICAgICAgICAgICAgc2MtPm1iID0gcDJtX2dldF9hbGxvY2F0aW9uKGQp
OworCisgICAgICAgIHJldHVybiByYzsKKyAgICB9CiAgICAgY2FzZSBYRU5f
RE9NQ1RMX1NIQURPV19PUF9HRVRfQUxMT0NBVElPTjoKKyAgICB7CisgICAg
ICAgIHNjLT5tYiA9IHAybV9nZXRfYWxsb2NhdGlvbihkKTsKICAgICAgICAg
cmV0dXJuIDA7CisgICAgfQogICAgIGRlZmF1bHQ6CiAgICAgewogICAgICAg
ICBwcmludGsoWEVOTE9HX0VSUiAiQmFkIHAybSBkb21jdGwgb3AgJXVcbiIs
IHNjLT5vcCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94
ZW4vYXJjaC9hcm0vcDJtLmMKaW5kZXggMGMzMzFhMzZhNTM2Li4xM2IwNmMw
ZmU0MWQgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYworKysgYi94
ZW4vYXJjaC9hcm0vcDJtLmMKQEAgLTQ5LDYgKzQ5LDU0IEBAIHN0YXRpYyB1
aW50NjRfdCBnZW5lcmF0ZV92dHRicih1aW50MTZfdCB2bWlkLCBtZm5fdCBy
b290X21mbikKICAgICByZXR1cm4gKG1mbl90b19tYWRkcihyb290X21mbikg
fCAoKHVpbnQ2NF90KXZtaWQgPDwgNDgpKTsKIH0KIAorc3RhdGljIHN0cnVj
dCBwYWdlX2luZm8gKnAybV9hbGxvY19wYWdlKHN0cnVjdCBkb21haW4gKmQp
Cit7CisgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CisKKyAgICBzcGluX2xv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgIC8qCisgICAgICogRm9y
IGhhcmR3YXJlIGRvbWFpbiwgdGhlcmUgc2hvdWxkIGJlIG5vIGxpbWl0IGlu
IHRoZSBudW1iZXIgb2YgcGFnZXMgdGhhdAorICAgICAqIGNhbiBiZSBhbGxv
Y2F0ZWQsIHNvIHRoYXQgdGhlIGtlcm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ug
b2YgdGhlIGV4dGVuZGVkCisgICAgICogcmVnaW9ucy4gSGVuY2UsIGFsbG9j
YXRlIHAybSBwYWdlcyBmb3IgaGFyZHdhcmUgZG9tYWlucyBmcm9tIGhlYXAu
CisgICAgICovCisgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQor
ICAgIHsKKyAgICAgICAgcGcgPSBhbGxvY19kb21oZWFwX3BhZ2UoTlVMTCwg
MCk7CisgICAgICAgIGlmICggcGcgPT0gTlVMTCApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlIgIkZhaWxlZCB0byBhbGxv
Y2F0ZSBQMk0gcGFnZXMgZm9yIGh3ZG9tLlxuIik7CisgICAgICAgICAgICBz
cGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAgICAgICAg
ICByZXR1cm4gTlVMTDsKKyAgICAgICAgfQorICAgIH0KKyAgICBlbHNlCisg
ICAgeworICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgmZC0+
YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgaWYgKCB1bmxp
a2VseSghcGcpICkKKyAgICAgICAgeworICAgICAgICAgICAgc3Bpbl91bmxv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgICAgICAgICAgcmV0dXJu
IE5VTEw7CisgICAgICAgIH0KKyAgICAgICAgZC0+YXJjaC5wYWdpbmcucDJt
X3RvdGFsX3BhZ2VzLS07CisgICAgfQorICAgIHNwaW5fdW5sb2NrKCZkLT5h
cmNoLnBhZ2luZy5sb2NrKTsKKworICAgIHJldHVybiBwZzsKK30KKworc3Rh
dGljIHZvaWQgcDJtX2ZyZWVfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1
Y3QgcGFnZV9pbmZvICpwZykKK3sKKyAgICBzcGluX2xvY2soJmQtPmFyY2gu
cGFnaW5nLmxvY2spOworICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQp
ICkKKyAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOworICAgIGVsc2UK
KyAgICB7CisgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cysrOworICAgICAgICBwYWdlX2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNo
LnBhZ2luZy5wMm1fZnJlZWxpc3QpOworICAgIH0KKyAgICBzcGluX3VubG9j
aygmZC0+YXJjaC5wYWdpbmcubG9jayk7Cit9CisKIC8qIFJldHVybiB0aGUg
c2l6ZSBvZiB0aGUgcG9vbCwgcm91bmRlZCB1cCB0byB0aGUgbmVhcmVzdCBN
QiAqLwogdW5zaWduZWQgaW50IHAybV9nZXRfYWxsb2NhdGlvbihzdHJ1Y3Qg
ZG9tYWluICpkKQogewpAQCAtNzUwLDcgKzc5OCw3IEBAIHN0YXRpYyBpbnQg
cDJtX2NyZWF0ZV90YWJsZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBscGFl
X3QgKmVudHJ5KQogCiAgICAgQVNTRVJUKCFwMm1faXNfdmFsaWQoKmVudHJ5
KSk7CiAKLSAgICBwYWdlID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDAp
OworICAgIHBhZ2UgPSBwMm1fYWxsb2NfcGFnZShwMm0tPmRvbWFpbik7CiAg
ICAgaWYgKCBwYWdlID09IE5VTEwgKQogICAgICAgICByZXR1cm4gLUVOT01F
TTsKIApAQCAtODcwLDcgKzkxOCw3IEBAIHN0YXRpYyB2b2lkIHAybV9mcmVl
X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgcGcgPSBtZm5f
dG9fcGFnZShtZm4pOwogCiAgICAgcGFnZV9saXN0X2RlbChwZywgJnAybS0+
cGFnZXMpOwotICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsKKyAgICBwMm1f
ZnJlZV9wYWdlKHAybS0+ZG9tYWluLCBwZyk7CiB9CiAKIHN0YXRpYyBib29s
IHAybV9zcGxpdF9zdXBlcnBhZ2Uoc3RydWN0IHAybV9kb21haW4gKnAybSwg
bHBhZV90ICplbnRyeSwKQEAgLTg5NCw3ICs5NDIsNyBAQCBzdGF0aWMgYm9v
bCBwMm1fc3BsaXRfc3VwZXJwYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0s
IGxwYWVfdCAqZW50cnksCiAgICAgQVNTRVJUKGxldmVsIDwgdGFyZ2V0KTsK
ICAgICBBU1NFUlQocDJtX2lzX3N1cGVycGFnZSgqZW50cnksIGxldmVsKSk7
CiAKLSAgICBwYWdlID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDApOwor
ICAgIHBhZ2UgPSBwMm1fYWxsb2NfcGFnZShwMm0tPmRvbWFpbik7CiAgICAg
aWYgKCAhcGFnZSApCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApAQCAtMTYx
MCw3ICsxNjU4LDcgQEAgaW50IHAybV90ZWFyZG93bihzdHJ1Y3QgZG9tYWlu
ICpkKQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCiAgICAgewotICAgICAgICBmcmVlX2RvbWhl
YXBfcGFnZShwZyk7CisgICAgICAgIHAybV9mcmVlX3BhZ2UocDJtLT5kb21h
aW4sIHBnKTsKICAgICAgICAgY291bnQrKzsKICAgICAgICAgLyogQXJiaXRy
YXJpbHkgcHJlZW1wdCBldmVyeSA1MTIgaXRlcmF0aW9ucyAqLwogICAgICAg
ICBpZiAoICEoY291bnQgJSA1MTIpICYmIGh5cGVyY2FsbF9wcmVlbXB0X2No
ZWNrKCkgKQpAQCAtMTYzNCw2ICsxNjgyLDcgQEAgdm9pZCBwMm1fZmluYWxf
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAgcmV0dXJuOwog
CiAgICAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOwor
ICAgIEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmQtPmFyY2gucGFnaW5nLnAy
bV9mcmVlbGlzdCkpOwogCiAgICAgaWYgKCBwMm0tPnJvb3QgKQogICAgICAg
ICBmcmVlX2RvbWhlYXBfcGFnZXMocDJtLT5yb290LCBQMk1fUk9PVF9PUkRF
Uik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.15/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Disposition: attachment;
 filename="xsa409-4.15/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Transfer-Encoding: base64

RnJvbSA0MWI1MTM0MmU3ODk2MjFkMmJkZDgyNWI4ZTczZTk0NmZkYzZiYTkz
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IFR1ZSwgOSBBdWcgMjAyMiAwNjoz
OToyMyArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMS80XSBsaWJ4bCwgZG9jczog
VXNlIGFyY2gtc3BlY2lmaWMgZGVmYXVsdCBwYWdpbmcgbWVtb3J5CgpUaGUg
ZGVmYXVsdCBwYWdpbmcgbWVtb3J5IChkZXNjaWJlZCBpbiBgc2hhZG93X21l
bW9yeWAgZW50cnkgaW4geGwKY29uZmlnKSBpbiBsaWJ4bCBpcyB1c2VkIHRv
IGRldGVybWluZSB0aGUgbWVtb3J5IHBvb2wgc2l6ZSBmb3IgeGwKZ3Vlc3Rz
LiBDdXJyZW50bHkgdGhpcyBzaXplIGlzIG9ubHkgdXNlZCBmb3IgeDg2LCBh
bmQgY29udGFpbnMgYSBwYXJ0Cm9mIFJBTSB0byBzaGFkb3cgdGhlIHJlc2lk
ZW50IHByb2Nlc3Nlcy4gU2luY2Ugb24gQXJtIHRoZXJlIGlzIG5vCnNoYWRv
dyBtb2RlIGd1ZXN0cywgc28gdGhlIHBhcnQgb2YgUkFNIHRvIHNoYWRvdyB0
aGUgcmVzaWRlbnQgcHJvY2Vzc2VzCmlzIG5vdCBuZWNlc3NhcnkuIFRoZXJl
Zm9yZSwgdGhpcyBjb21taXQgc3BsaXRzIHRoZSBmdW5jdGlvbgpgbGlieGxf
Z2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkoKWAgdG8gYXJjaCBzcGVjaWZp
YyBoZWxwZXJzIGFuZApyZW5hbWVkIHRoZSBoZWxwZXIgdG8gYGxpYnhsX19h
cmNoX2dldF9yZXF1aXJlZF9wYWdpbmdfbWVtb3J5KClgLgoKT24geDg2LCB0
aGlzIGhlbHBlciBjYWxscyB0aGUgb3JpZ2luYWwgdmFsdWUgZnJvbQpgbGli
eGxfZ2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkoKWAgc28gbm8gZnVuY3Rp
b25hbCBjaGFuZ2UgaW50ZW5kZWQuCgpPbiBBcm0sIHRoaXMgaGVscGVyIHJl
dHVybnMgMU1CIHBlciB2Y3B1IHBsdXMgNEtCIHBlciBNaUIgb2YgUkFNCmZv
ciB0aGUgUDJNIG1hcC4KCkFsc28gdXBkYXRlIHRoZSB4bC5jZmcgZG9jdW1l
bnRhdGlvbiB0byBhZGQgQXJtIGRvY3VtZW50YXRpb24KYWNjb3JkaW5nIHRv
IGNvZGUgY2hhbmdlcyBhbmQgY29ycmVjdCB0aGUgY29tbWVudCBzdHlsZSBm
b2xsb3dpbmcgWGVuCmNvZGluZyBzdHlsZS4KClRoaXMgaXMgcGFydCBvZiBD
VkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTdWdnZXN0ZWQtYnk6IEp1bGll
biBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ClNpZ25lZC1vZmYtYnk6IEhl
bnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQtYnk6IEFu
dGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0K
IGRvY3MvbWFuL3hsLmNmZy41LnBvZC5pbiAgICAgICB8ICA1ICsrKysrCiB0
b29scy9saWJzL2xpZ2h0L2xpYnhsX2FyY2guaCAgfCAgNCArKysrCiB0b29s
cy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jICAgfCAxMiArKysrKysrKysrKysK
IHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfdXRpbHMuYyB8ICA5ICsrLS0tLS0t
LQogdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYyAgIHwgMTMgKysrKysr
KysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA3
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvY3MvbWFuL3hsLmNmZy41
LnBvZC5pbiBiL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbgppbmRleCA1NjM3
MGEzN2RiYjEuLmFmN2ZhZTdjNTJmOSAxMDA2NDQKLS0tIGEvZG9jcy9tYW4v
eGwuY2ZnLjUucG9kLmluCisrKyBiL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5p
bgpAQCAtMTc0Niw2ICsxNzQ2LDExIEBAIGFyZSBub3QgdXNpbmcgaGFyZHdh
cmUgYXNzaXN0ZWQgcGFnaW5nIChpLmUuIHlvdSBhcmUgdXNpbmcgc2hhZG93
CiBtb2RlKSBhbmQgeW91ciBndWVzdCB3b3JrbG9hZCBjb25zaXN0cyBvZiBh
IHZlcnkgbGFyZ2UgbnVtYmVyIG9mCiBzaW1pbGFyIHByb2Nlc3NlcyB0aGVu
IGluY3JlYXNpbmcgdGhpcyB2YWx1ZSBtYXkgaW1wcm92ZSBwZXJmb3JtYW5j
ZS4KIAorT24gQXJtLCB0aGlzIGZpZWxkIGlzIHVzZWQgdG8gZGV0ZXJtaW5l
IHRoZSBzaXplIG9mIHRoZSBndWVzdCBQMk0gcGFnZXMKK3Bvb2wsIGFuZCB0
aGUgZGVmYXVsdCB2YWx1ZSBpcyAxTUIgcGVyIHZDUFUgcGx1cyA0S0IgcGVy
IE1CIG9mIFJBTSBmb3IKK3RoZSBQMk0gbWFwLiBVc2VycyBzaG91bGQgYWRq
dXN0IHRoaXMgdmFsdWUgaWYgYmlnZ2VyIFAyTSBwb29sIHNpemUgaXMKK25l
ZWRlZC4KKwogPWJhY2sKIAogPWhlYWQzIFByb2Nlc3NvciBhbmQgUGxhdGZv
cm0gRmVhdHVyZXMKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli
eGxfYXJjaC5oIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcmNoLmgKaW5k
ZXggODUyN2ZjNWM2YzIzLi42NzQxYjdmNmY0NTcgMTAwNjQ0Ci0tLSBhL3Rv
b2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oCisrKyBiL3Rvb2xzL2xpYnMv
bGlnaHQvbGlieGxfYXJjaC5oCkBAIC05MCw2ICs5MCwxMCBAQCB2b2lkIGxp
YnhsX19hcmNoX3VwZGF0ZV9kb21haW5fY29uZmlnKGxpYnhsX19nYyAqZ2Ms
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpYnhs
X2RvbWFpbl9jb25maWcgKmRzdCwKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgY29uc3QgbGlieGxfZG9tYWluX2NvbmZpZyAqc3Jj
KTsKIAorX2hpZGRlbgordW5zaWduZWQgbG9uZyBsaWJ4bF9fYXJjaF9nZXRf
cmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNpZ25lZCBsb25nIG1heG1lbV9r
YiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdW5zaWduZWQgaW50IHNtcF9jcHVzKTsKKwogI2lmIGRl
ZmluZWQoX19pMzg2X18pIHx8IGRlZmluZWQoX194ODZfNjRfXykKIAogI2Rl
ZmluZSBMQVBJQ19CQVNFX0FERFJFU1MgIDB4ZmVlMDAwMDAKZGlmZiAtLWdp
dCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgYi90b29scy9saWJz
L2xpZ2h0L2xpYnhsX2FybS5jCmluZGV4IGUyOTAxZjEzYjcyNC4uZDU5YjQ2
NDE5MmMyIDEwMDY0NAotLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2Fy
bS5jCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMKQEAgLTE1
NCw2ICsxNTQsMTggQEAgb3V0OgogICAgIHJldHVybiByYzsKIH0KIAordW5z
aWduZWQgbG9uZyBsaWJ4bF9fYXJjaF9nZXRfcmVxdWlyZWRfcGFnaW5nX21l
bW9yeSh1bnNpZ25lZCBsb25nIG1heG1lbV9rYiwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWdu
ZWQgaW50IHNtcF9jcHVzKQoreworICAgIC8qCisgICAgICogMjU2IHBhZ2Vz
ICgxTUIpIHBlciB2Y3B1LAorICAgICAqIHBsdXMgMSBwYWdlIHBlciBNaUIg
b2YgUkFNIGZvciB0aGUgUDJNIG1hcCwKKyAgICAgKiBUaGlzIGlzIGhpZ2hl
ciB0aGFuIHRoZSBtaW5pbXVtIHRoYXQgWGVuIHdvdWxkIGFsbG9jYXRlIGlm
IG5vIHZhbHVlCisgICAgICogd2VyZSBnaXZlbiAoYnV0IHRoZSBYZW4gbWlu
aW11bSBpcyBmb3Igc2FmZXR5LCBub3QgcGVyZm9ybWFuY2UpLgorICAgICAq
LworICAgIHJldHVybiA0ICogKDI1NiAqIHNtcF9jcHVzICsgbWF4bWVtX2ti
IC8gMTAyNCk7Cit9CisKIHN0YXRpYyBzdHJ1Y3QgYXJjaF9pbmZvIHsKICAg
ICBjb25zdCBjaGFyICpndWVzdF90eXBlOwogICAgIGNvbnN0IGNoYXIgKnRp
bWVyX2NvbXBhdDsKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli
eGxfdXRpbHMuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdXRpbHMuYwpp
bmRleCA0Njk5YzRhMGEzNmYuLmUyNzZjMGVlOWNjMyAxMDA2NDQKLS0tIGEv
dG9vbHMvbGlicy9saWdodC9saWJ4bF91dGlscy5jCisrKyBiL3Rvb2xzL2xp
YnMvbGlnaHQvbGlieGxfdXRpbHMuYwpAQCAtMTgsNiArMTgsNyBAQAogI2lu
Y2x1ZGUgPGN0eXBlLmg+CiAKICNpbmNsdWRlICJsaWJ4bF9pbnRlcm5hbC5o
IgorI2luY2x1ZGUgImxpYnhsX2FyY2guaCIKICNpbmNsdWRlICJfcGF0aHMu
aCIKIAogI2lmbmRlZiBMSUJYTF9IQVZFX05PTkNPTlNUX0xJQlhMX0JBU0VO
QU1FX1JFVFVSTl9WQUxVRQpAQCAtMzksMTMgKzQwLDcgQEAgY2hhciAqbGli
eGxfYmFzZW5hbWUoY29uc3QgY2hhciAqbmFtZSkKIAogdW5zaWduZWQgbG9u
ZyBsaWJ4bF9nZXRfcmVxdWlyZWRfc2hhZG93X21lbW9yeSh1bnNpZ25lZCBs
b25nIG1heG1lbV9rYiwgdW5zaWduZWQgaW50IHNtcF9jcHVzKQogewotICAg
IC8qIDI1NiBwYWdlcyAoMU1CKSBwZXIgdmNwdSwKLSAgICAgICBwbHVzIDEg
cGFnZSBwZXIgTWlCIG9mIFJBTSBmb3IgdGhlIFAyTSBtYXAsCi0gICAgICAg
cGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBSQU0gdG8gc2hhZG93IHRoZSByZXNp
ZGVudCBwcm9jZXNzZXMuCi0gICAgICAgVGhpcyBpcyBoaWdoZXIgdGhhbiB0
aGUgbWluaW11bSB0aGF0IFhlbiB3b3VsZCBhbGxvY2F0ZSBpZiBubyB2YWx1
ZQotICAgICAgIHdlcmUgZ2l2ZW4gKGJ1dCB0aGUgWGVuIG1pbmltdW0gaXMg
Zm9yIHNhZmV0eSwgbm90IHBlcmZvcm1hbmNlKS4KLSAgICAgKi8KLSAgICBy
ZXR1cm4gNCAqICgyNTYgKiBzbXBfY3B1cyArIDIgKiAobWF4bWVtX2tiIC8g
MTAyNCkpOworICAgIHJldHVybiBsaWJ4bF9fYXJjaF9nZXRfcmVxdWlyZWRf
cGFnaW5nX21lbW9yeShtYXhtZW1fa2IsIHNtcF9jcHVzKTsKIH0KIAogY2hh
ciAqbGlieGxfZG9taWRfdG9fbmFtZShsaWJ4bF9jdHggKmN0eCwgdWludDMy
X3QgZG9taWQpCmRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhs
X3g4Ni5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF94ODYuYwppbmRleCAx
OGMzYzc3Y2NkZTMuLjRkNjY0NzhmZTlkZCAxMDA2NDQKLS0tIGEvdG9vbHMv
bGlicy9saWdodC9saWJ4bF94ODYuYworKysgYi90b29scy9saWJzL2xpZ2h0
L2xpYnhsX3g4Ni5jCkBAIC04ODIsNiArODgyLDE5IEBAIHZvaWQgbGlieGxf
X2FyY2hfdXBkYXRlX2RvbWFpbl9jb25maWcobGlieGxfX2djICpnYywKICAg
ICAgICAgICAgICAgICAgICAgbGlieGxfZGVmYm9vbF92YWwoc3JjLT5iX2lu
Zm8uYXJjaF94ODYubXNyX3JlbGF4ZWQpKTsKIH0KIAordW5zaWduZWQgbG9u
ZyBsaWJ4bF9fYXJjaF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNp
Z25lZCBsb25nIG1heG1lbV9rYiwKKyAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNt
cF9jcHVzKQoreworICAgIC8qCisgICAgICogMjU2IHBhZ2VzICgxTUIpIHBl
ciB2Y3B1LAorICAgICAqIHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIGZv
ciB0aGUgUDJNIG1hcCwKKyAgICAgKiBwbHVzIDEgcGFnZSBwZXIgTWlCIG9m
IFJBTSB0byBzaGFkb3cgdGhlIHJlc2lkZW50IHByb2Nlc3Nlcy4KKyAgICAg
KiBUaGlzIGlzIGhpZ2hlciB0aGFuIHRoZSBtaW5pbXVtIHRoYXQgWGVuIHdv
dWxkIGFsbG9jYXRlIGlmIG5vIHZhbHVlCisgICAgICogd2VyZSBnaXZlbiAo
YnV0IHRoZSBYZW4gbWluaW11bSBpcyBmb3Igc2FmZXR5LCBub3QgcGVyZm9y
bWFuY2UpLgorICAgICAqLworICAgIHJldHVybiA0ICogKDI1NiAqIHNtcF9j
cHVzICsgMiAqIChtYXhtZW1fa2IgLyAxMDI0KSk7Cit9CisKIC8qCiAgKiBM
b2NhbCB2YXJpYWJsZXM6CiAgKiBtb2RlOiBDCi0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.15/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Disposition: attachment;
 filename="xsa409-4.15/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Transfer-Encoding: base64

RnJvbSA1ZDdkYzYyMzdlN2I1ZTczYjJmNThhOGI3NTQ1Y2U0Yjg5NTQzNjY1
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMi80XSB4ZW4vYXJtOiBDb25z
dHJ1Y3QgdGhlIFAyTSBwYWdlcyBwb29sIGZvciBndWVzdHMKClRoaXMgY29t
bWl0IGNvbnN0cnVjdHMgdGhlIHAybSBwYWdlcyBwb29sIGZvciBndWVzdHMg
ZnJvbSB0aGUKZGF0YSBzdHJ1Y3R1cmUgYW5kIGhlbHBlciBwZXJzcGVjdGl2
ZS4KClRoaXMgaXMgaW1wbGVtZW50ZWQgYnk6CgotIEFkZGluZyBhIGBzdHJ1
Y3QgcGFnaW5nX2RvbWFpbmAgd2hpY2ggY29udGFpbnMgYSBmcmVlbGlzdCwg
YQpjb3VudGVyIHZhcmlhYmxlIGFuZCBhIHNwaW5sb2NrIHRvIGBzdHJ1Y3Qg
YXJjaF9kb21haW5gIHRvCmluZGljYXRlIHRoZSBmcmVlIHAybSBwYWdlcyBh
bmQgdGhlIG51bWJlciBvZiBwMm0gdG90YWwgcGFnZXMgaW4KdGhlIHAybSBw
YWdlcyBwb29sLgoKLSBBZGRpbmcgYSBoZWxwZXIgYHAybV9nZXRfYWxsb2Nh
dGlvbmAgdG8gZ2V0IHRoZSBwMm0gcG9vbCBzaXplLgoKLSBBZGRpbmcgYSBo
ZWxwZXIgYHAybV9zZXRfYWxsb2NhdGlvbmAgdG8gc2V0IHRoZSBwMm0gcGFn
ZXMgcG9vbApzaXplLiBUaGlzIGhlbHBlciBzaG91bGQgYmUgY2FsbGVkIGJl
Zm9yZSBhbGxvY2F0aW5nIG1lbW9yeSBmb3IKYSBndWVzdC4KCi0gQWRkaW5n
IGEgaGVscGVyIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAgdG8gZnJlZSB0
aGUgcDJtIHBhZ2VzCnBvb2wuIFRoaXMgaGVscGVyIHNob3VsZCBiZSBjYWxs
ZWQgZHVyaW5nIHRoZSB4bCBkb21haW4gZGVzdG9yeS4KClRoaXMgaXMgcGFy
dCBvZiBDVkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTaWduZWQtb2ZmLWJ5
OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5
OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+
Ci0tLQogeGVuL2FyY2gvYXJtL3AybS5jICAgICAgICAgICB8IDg4ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogeGVuL2luY2x1ZGUv
YXNtLWFybS9kb21haW4uaCB8IDEwICsrKysKIHhlbi9pbmNsdWRlL2FzbS1h
cm0vcDJtLmggICAgfCAgNCArKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDIgaW5z
ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBi
L3hlbi9hcmNoL2FybS9wMm0uYwppbmRleCA0YWQzZTA2MDZlOWMuLjY4ODNk
ODYyNzcwMiAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCisrKyBi
L3hlbi9hcmNoL2FybS9wMm0uYwpAQCAtNTAsNiArNTAsOTIgQEAgc3RhdGlj
IHVpbnQ2NF90IGdlbmVyYXRlX3Z0dGJyKHVpbnQxNl90IHZtaWQsIG1mbl90
IHJvb3RfbWZuKQogICAgIHJldHVybiAobWZuX3RvX21hZGRyKHJvb3RfbWZu
KSB8ICgodWludDY0X3Qpdm1pZCA8PCA0OCkpOwogfQogCisvKiBSZXR1cm4g
dGhlIHNpemUgb2YgdGhlIHBvb2wsIHJvdW5kZWQgdXAgdG8gdGhlIG5lYXJl
c3QgTUIgKi8KK3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIG5yX3BhZ2Vz
ID0gQUNDRVNTX09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2Vz
KTsKKworICAgIHJldHVybiBST1VORFVQKG5yX3BhZ2VzLCAxIDw8ICgyMCAt
IFBBR0VfU0hJRlQpKSA+PiAoMjAgLSBQQUdFX1NISUZUKTsKK30KKworLyoK
KyAqIFNldCB0aGUgcG9vbCBvZiBwYWdlcyB0byB0aGUgcmVxdWlyZWQgbnVt
YmVyIG9mIHBhZ2VzLgorICogUmV0dXJucyAwIGZvciBzdWNjZXNzLCBub24t
emVybyBmb3IgZmFpbHVyZS4KKyAqIENhbGwgd2l0aCBkLT5hcmNoLnBhZ2lu
Zy5sb2NrIGhlbGQuCisgKi8KK2ludCBwMm1fc2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBwYWdlcywgYm9vbCAqcHJl
ZW1wdGVkKQoreworICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOworCisgICAg
QVNTRVJUKHNwaW5faXNfbG9ja2VkKCZkLT5hcmNoLnBhZ2luZy5sb2NrKSk7
CisKKyAgICBmb3IgKCA7IDsgKQorICAgIHsKKyAgICAgICAgaWYgKCBkLT5h
cmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPCBwYWdlcyApCisgICAgICAg
IHsKKyAgICAgICAgICAgIC8qIE5lZWQgdG8gYWxsb2NhdGUgbW9yZSBtZW1v
cnkgZnJvbSBkb21oZWFwICovCisgICAgICAgICAgICBwZyA9IGFsbG9jX2Rv
bWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICAgICAgICAgIGlmICggcGcgPT0g
TlVMTCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRr
KFhFTkxPR19FUlIgIkZhaWxlZCB0byBhbGxvY2F0ZSBQMk0gcGFnZXMuXG4i
KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKKyAgICAgICAg
ICAgIH0KKyAgICAgICAgICAgIEFDQ0VTU19PTkNFKGQtPmFyY2gucGFnaW5n
LnAybV90b3RhbF9wYWdlcykgPQorICAgICAgICAgICAgICAgIGQtPmFyY2gu
cGFnaW5nLnAybV90b3RhbF9wYWdlcyArIDE7CisgICAgICAgICAgICBwYWdl
X2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxp
c3QpOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBkLT5hcmNoLnBh
Z2luZy5wMm1fdG90YWxfcGFnZXMgPiBwYWdlcyApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIC8qIE5lZWQgdG8gcmV0dXJuIG1lbW9yeSB0byBkb21oZWFw
ICovCisgICAgICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgm
ZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgICAgIGlm
KCBwZyApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgQUNDRVNT
X09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzKSA9CisgICAg
ICAgICAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cyAtIDE7CisgICAgICAgICAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcp
OworICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSCisgICAg
ICAgICAgICAgICAgICAgICAgICJGYWlsZWQgdG8gZnJlZSBQMk0gcGFnZXMs
IFAyTSBmcmVlbGlzdCBpcyBlbXB0eS5cbiIpOworICAgICAgICAgICAgICAg
IHJldHVybiAtRU5PTUVNOworICAgICAgICAgICAgfQorICAgICAgICB9Cisg
ICAgICAgIGVsc2UKKyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIC8q
IENoZWNrIHRvIHNlZSBpZiB3ZSBuZWVkIHRvIHlpZWxkIGFuZCB0cnkgYWdh
aW4gKi8KKyAgICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgZ2VuZXJhbF9wcmVl
bXB0X2NoZWNrKCkgKQorICAgICAgICB7CisgICAgICAgICAgICAqcHJlZW1w
dGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7Cisg
ICAgICAgIH0KKyAgICB9CisKKyAgICByZXR1cm4gMDsKK30KKworaW50IHAy
bV90ZWFyZG93bl9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQpCit7Cisg
ICAgaW50IHJldCA9IDA7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsK
KworICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAg
aWYgKCBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgIT0gMCApCisg
ICAgeworICAgICAgICByZXQgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwg
JnByZWVtcHRlZCk7CisgICAgICAgIGlmICggcHJlZW1wdGVkICkKKyAgICAg
ICAgeworICAgICAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5n
LmxvY2spOworICAgICAgICAgICAgcmV0dXJuIC1FUkVTVEFSVDsKKyAgICAg
ICAgfQorICAgICAgICBBU1NFUlQoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFs
X3BhZ2VzID09IDApOworICAgIH0KKyAgICBzcGluX3VubG9jaygmZC0+YXJj
aC5wYWdpbmcubG9jayk7CisKKyAgICByZXR1cm4gcmV0OworfQorCiAvKiBV
bmxvY2sgdGhlIGZsdXNoIGFuZCBkbyBhIFAyTSBUTEIgZmx1c2ggaWYgbmVj
ZXNzYXJ5ICovCiB2b2lkIHAybV93cml0ZV91bmxvY2soc3RydWN0IHAybV9k
b21haW4gKnAybSkKIHsKQEAgLTE2MDIsNyArMTY4OCw5IEBAIGludCBwMm1f
aW5pdChzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2lnbmVkIGludCBjcHU7
CiAKICAgICByd2xvY2tfaW5pdCgmcDJtLT5sb2NrKTsKKyAgICBzcGluX2xv
Y2tfaW5pdCgmZC0+YXJjaC5wYWdpbmcubG9jayk7CiAgICAgSU5JVF9QQUdF
X0xJU1RfSEVBRCgmcDJtLT5wYWdlcyk7CisgICAgSU5JVF9QQUdFX0xJU1Rf
SEVBRCgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKIAogICAgIHAy
bS0+dm1pZCA9IElOVkFMSURfVk1JRDsKIApkaWZmIC0tZ2l0IGEveGVuL2lu
Y2x1ZGUvYXNtLWFybS9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v
ZG9tYWluLmgKaW5kZXggYmIwYTZhZGJlMDBiLi4xZDg5MzU3NzhmM2IgMTAw
NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaApAQCAtNDAsNiArNDAsMTQg
QEAgc3RydWN0IHZ0aW1lciB7CiAgICAgdWludDY0X3QgY3ZhbDsKIH07CiAK
K3N0cnVjdCBwYWdpbmdfZG9tYWluIHsKKyAgICBzcGlubG9ja190IGxvY2s7
CisgICAgLyogRnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgcHJlLWFsbG9jYXRl
ZCBQMk0gcG9vbCAqLworICAgIHN0cnVjdCBwYWdlX2xpc3RfaGVhZCBwMm1f
ZnJlZWxpc3Q7CisgICAgLyogTnVtYmVyIG9mIHBhZ2VzIGZyb20gdGhlIHBy
ZS1hbGxvY2F0ZWQgUDJNIHBvb2wgKi8KKyAgICB1bnNpZ25lZCBsb25nIHAy
bV90b3RhbF9wYWdlczsKK307CisKIHN0cnVjdCBhcmNoX2RvbWFpbgogewog
I2lmZGVmIENPTkZJR19BUk1fNjQKQEAgLTUxLDYgKzU5LDggQEAgc3RydWN0
IGFyY2hfZG9tYWluCiAKICAgICBzdHJ1Y3QgaHZtX2RvbWFpbiBodm07CiAK
KyAgICBzdHJ1Y3QgcGFnaW5nX2RvbWFpbiBwYWdpbmc7CisKICAgICBzdHJ1
Y3Qgdm1taW8gdm1taW87CiAKICAgICAvKiBDb250aW51YWJsZSBkb21haW5f
cmVsaW5xdWlzaF9yZXNvdXJjZXMoKS4gKi8KZGlmZiAtLWdpdCBhL3hlbi9p
bmNsdWRlL2FzbS1hcm0vcDJtLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3Ay
bS5oCmluZGV4IDNhMmQ1MWIzNWQ3MS4uMTg2NzViMjM0NTcwIDEwMDY0NAot
LS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCisrKyBiL3hlbi9pbmNs
dWRlL2FzbS1hcm0vcDJtLmgKQEAgLTIxOCw2ICsyMTgsMTAgQEAgdm9pZCBw
Mm1fcmVzdG9yZV9zdGF0ZShzdHJ1Y3QgdmNwdSAqbik7CiAvKiBQcmludCBk
ZWJ1Z2dpbmcvc3RhdGlzdGlhbCBpbmZvIGFib3V0IGEgZG9tYWluJ3MgcDJt
ICovCiB2b2lkIHAybV9kdW1wX2luZm8oc3RydWN0IGRvbWFpbiAqZCk7CiAK
K3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3RydWN0IGRvbWFp
biAqZCk7CitpbnQgcDJtX3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4g
KmQsIHVuc2lnbmVkIGxvbmcgcGFnZXMsIGJvb2wgKnByZWVtcHRlZCk7Citp
bnQgcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCk7
CisKIHN0YXRpYyBpbmxpbmUgdm9pZCBwMm1fd3JpdGVfbG9jayhzdHJ1Y3Qg
cDJtX2RvbWFpbiAqcDJtKQogewogICAgIHdyaXRlX2xvY2soJnAybS0+bG9j
ayk7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.15/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Disposition: attachment;
 filename="xsa409-4.15/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Transfer-Encoding: base64

RnJvbSA2YmI2OWQ3OGIxMmQ1YjVmMzA4YmU0MGI0OTdmNTZjMmQ0NWZhN2Fj
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMy80XSB4ZW4vYXJtLCBsaWJ4
bDogSW1wbGVtZW50IFhFTl9ET01DVExfc2hhZG93X29wIGZvciBBcm0KClRo
aXMgY29tbWl0IGltcGxlbWVudHMgdGhlIGBYRU5fRE9NQ1RMX3NoYWRvd19v
cGAgc3VwcG9ydCBpbiBYZW4KZm9yIEFybS4gVGhlIHAybSBwYWdlcyBwb29s
IHNpemUgZm9yIHhsIGd1ZXN0cyBpcyBzdXBwb3NlZCB0byBiZQpkZXRlcm1p
bmVkIGJ5IGBYRU5fRE9NQ1RMX3NoYWRvd19vcGAuIEhlbmNlLCB0aGlzIGNv
bW1pdDoKCi0gSW50cm9kdWNlcyBhIGZ1bmN0aW9uIGBwMm1fZG9tY3RsYCBh
bmQgaW1wbGVtZW50cyB0aGUgc3Vib3BzCmBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTmAgYW5kCmBYRU5fRE9NQ1RMX1NIQURPV19PUF9H
RVRfQUxMT0NBVElPTmAgb2YgYFhFTl9ET01DVExfc2hhZG93X29wYC4KCi0g
QWRkcyB0aGUgYFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FUSU9O
YCBzdXBwb3J0IGluIGxpYnhsLgoKVGhlcmVmb3JlIGVuYWJsaW5nIHRoZSBz
ZXR0aW5nIG9mIHNoYWRvdyBtZW1vcnkgcG9vbCBzaXplCndoZW4gY3JlYXRp
bmcgYSBndWVzdCBmcm9tIHhsIGFuZCBnZXR0aW5nIHNoYWRvdyBtZW1vcnkg
cG9vbCBzaXplCmZyb20gWGVuLgoKTm90ZSB0aGF0IHRoZSBgWEVOX0RPTUNU
TF9zaGFkb3dfb3BgIGFkZGVkIGluIHRoaXMgY29tbWl0IGlzIG9ubHkKYSBk
dW1teSBvcCwgYW5kIHRoZSBmdW5jdGlvbmFsaXR5IG9mIHNldHRpbmcvZ2V0
dGluZyBwMm0gbWVtb3J5IHBvb2wKc2l6ZSBmb3IgeGwgZ3Vlc3RzIHdpbGwg
YmUgYWRkZWQgaW4gZm9sbG93aW5nIGNvbW1pdHMuCgpUaGlzIGlzIHBhcnQg
b2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0EtNDA5LgoKU2lnbmVkLW9mZi1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPgpSZXZpZXdlZC1ieTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgot
LS0KIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgfCAxMiArKysrKysr
KysrKysKIHhlbi9hcmNoL2FybS9kb21jdGwuYyAgICAgICAgfCAzMiArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk
LCA0NCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9s
aWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJt
LmMKaW5kZXggZDU5YjQ2NDE5MmMyLi5kMjFmNjE0ZWQ3ODggMTAwNjQ0Ci0t
LSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMKKysrIGIvdG9vbHMv
bGlicy9saWdodC9saWJ4bF9hcm0uYwpAQCAtMTMxLDYgKzEzMSwxOCBAQCBp
bnQgbGlieGxfX2FyY2hfZG9tYWluX2NyZWF0ZShsaWJ4bF9fZ2MgKmdjLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9i
dWlsZF9zdGF0ZSAqc3RhdGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB1aW50MzJfdCBkb21pZCkKIHsKKyAgICBsaWJ4bF9jdHggKmN0eCA9
IGxpYnhsX19nY19vd25lcihnYyk7CisgICAgdW5zaWduZWQgaW50IHNoYWRv
d19tYiA9IERJVl9ST1VORFVQKGRfY29uZmlnLT5iX2luZm8uc2hhZG93X21l
bWtiLCAxMDI0KTsKKworICAgIGludCByID0geGNfc2hhZG93X2NvbnRyb2wo
Y3R4LT54Y2gsIGRvbWlkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgWEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT04sCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAmc2hhZG93X21iLCAwKTsKKyAg
ICBpZiAocikgeworICAgICAgICBMT0dFRChFUlJPUiwgZG9taWQsCisgICAg
ICAgICAgICAgICJGYWlsZWQgdG8gc2V0ICV1IE1pQiBzaGFkb3cgYWxsb2Nh
dGlvbiIsIHNoYWRvd19tYik7CisgICAgICAgIHJldHVybiBFUlJPUl9GQUlM
OworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCmRpZmYgLS1naXQgYS94
ZW4vYXJjaC9hcm0vZG9tY3RsLmMgYi94ZW4vYXJjaC9hcm0vZG9tY3RsLmMK
aW5kZXggYThjNDhiMGJlYWFiLi5hMDQ5YmM3ZjNlNTIgMTAwNjQ0Ci0tLSBh
L3hlbi9hcmNoL2FybS9kb21jdGwuYworKysgYi94ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMKQEAgLTQ1LDExICs0NSw0MyBAQCBzdGF0aWMgaW50IGhhbmRsZV92
dWFydF9pbml0KHN0cnVjdCBkb21haW4gKmQsCiAgICAgcmV0dXJuIHJjOwog
fQogCitzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQs
IHN0cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCisgICAgICAgICAg
ICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0
bF90KSB1X2RvbWN0bCkKK3sKKyAgICBpZiAoIHVubGlrZWx5KGQgPT0gY3Vy
cmVudC0+ZG9tYWluKSApCisgICAgeworICAgICAgICBwcmludGsoWEVOTE9H
X0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9wIG9uIGl0c2VsZi5c
biIpOworICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICB9CisKKyAgICBp
ZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisgICAgeworICAgICAgICBw
cmludGsoWEVOTE9HX0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9w
IG9uIGR5aW5nIGRvbWFpbiAldVxuIiwKKyAgICAgICAgICAgICAgIGQtPmRv
bWFpbl9pZCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOworICAgIH0KKwor
ICAgIHN3aXRjaCAoIHNjLT5vcCApCisgICAgeworICAgIGNhc2UgWEVOX0RP
TUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT046CisgICAgICAgIHJldHVy
biAwOworICAgIGNhc2UgWEVOX0RPTUNUTF9TSEFET1dfT1BfR0VUX0FMTE9D
QVRJT046CisgICAgICAgIHJldHVybiAwOworICAgIGRlZmF1bHQ6CisgICAg
eworICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiQmFkIHAybSBkb21jdGwg
b3AgJXVcbiIsIHNjLT5vcCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOwor
ICAgIH0KKyAgICB9Cit9CisKIGxvbmcgYXJjaF9kb19kb21jdGwoc3RydWN0
IHhlbl9kb21jdGwgKmRvbWN0bCwgc3RydWN0IGRvbWFpbiAqZCwKICAgICAg
ICAgICAgICAgICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9t
Y3RsX3QpIHVfZG9tY3RsKQogewogICAgIHN3aXRjaCAoIGRvbWN0bC0+Y21k
ICkKICAgICB7CisgICAgY2FzZSBYRU5fRE9NQ1RMX3NoYWRvd19vcDoKKyAg
ICAgICAgcmV0dXJuIHAybV9kb21jdGwoZCwgJmRvbWN0bC0+dS5zaGFkb3df
b3AsIHVfZG9tY3RsKTsKICAgICBjYXNlIFhFTl9ET01DVExfY2FjaGVmbHVz
aDoKICAgICB7CiAgICAgICAgIGdmbl90IHMgPSBfZ2ZuKGRvbWN0bC0+dS5j
YWNoZWZsdXNoLnN0YXJ0X3Bmbik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.15/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Disposition: attachment;
 filename="xsa409-4.15/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Transfer-Encoding: base64

RnJvbSBiYTNkYTI3ZWFjNjMyNjQ3NmI5ZjE0MzBlMjA0YmFlNTEwODYzYjk3
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzozMCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSB4ZW4vYXJtOiBBbGxv
Y2F0ZSBhbmQgZnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgUDJNIHBvb2wKClRo
aXMgY29tbWl0IHNldHMvdGVhcnNkb3duIG9mIHAybSBwYWdlcyBwb29sIGZv
ciBub24tcHJpdmlsZWdlZCBBcm0KZ3Vlc3RzIGJ5IGNhbGxpbmcgYHAybV9z
ZXRfYWxsb2NhdGlvbmAgYW5kIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAu
CgotIEZvciBkb20wLCBQMk0gcGFnZXMgc2hvdWxkIGNvbWUgZnJvbSBoZWFw
IGRpcmVjdGx5IGluc3RlYWQgb2YgcDJtCnBvb2wsIHNvIHRoYXQgdGhlIGtl
cm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGV4dGVuZGVkIHJlZ2lv
bnMuCgotIEZvciB4bCBndWVzdHMsIHRoZSBzZXR0aW5nIG9mIHRoZSBwMm0g
cG9vbCBpcyBjYWxsZWQgaW4KYFhFTl9ET01DVExfc2hhZG93X29wYCBhbmQg
dGhlIHAybSBwb29sIGlzIGRlc3Ryb3llZCBpbgpgZG9tYWluX3JlbGlucXVp
c2hfcmVzb3VyY2VzYC4gTm90ZSB0aGF0IGRvbWN0bC0+dS5zaGFkb3dfb3Au
bWIgaXMKdXBkYXRlZCB3aXRoIHRoZSBuZXcgc2l6ZSB3aGVuIHNldHRpbmcg
dGhlIHAybSBwb29sLgoKLSBGb3IgZG9tMGxlc3MgZG9tVXMsIHRoZSBzZXR0
aW5nIG9mIHRoZSBwMm0gcG9vbCBpcyBjYWxsZWQgYmVmb3JlCmFsbG9jYXRp
bmcgbWVtb3J5IGR1cmluZyBkb21haW4gY3JlYXRpb24uIFVzZXJzIGNhbiBz
cGVjaWZ5IHRoZSBwMm0KcG9vbCBzaXplIGJ5IGB4ZW4sZG9tYWluLXAybS1t
ZW0tbWJgIGR0cyBwcm9wZXJ0eS4KClRvIGFjdHVhbGx5IGFsbG9jYXRlL2Zy
ZWUgcGFnZXMgZnJvbSB0aGUgcDJtIHBvb2wsIHRoaXMgY29tbWl0IGFkZHMK
dHdvIGhlbHBlciBmdW5jdGlvbnMgbmFtZWx5IGBwMm1fYWxsb2NfcGFnZWAg
YW5kIGBwMm1fZnJlZV9wYWdlYCB0bwpgc3RydWN0IHAybV9kb21haW5gLiBC
eSByZXBsYWNpbmcgdGhlIGBhbGxvY19kb21oZWFwX3BhZ2VgIGFuZApgZnJl
ZV9kb21oZWFwX3BhZ2VgIHdpdGggdGhlc2UgdHdvIGhlbHBlciBmdW5jdGlv
bnMsIHAybSBwYWdlcyBjYW4KYmUgYWRkZWQvcmVtb3ZlZCBmcm9tIHRoZSBs
aXN0IG9mIHAybSBwb29sIHJhdGhlciB0aGFuIGZyb20gdGhlIGhlYXAuCgpT
aW5jZSBwYWdlIGZyb20gYHAybV9hbGxvY19wYWdlYCBpcyBjbGVhbmVkLCB0
YWtlIHRoZSBvcHBvcnR1bml0eQp0byByZW1vdmUgdGhlIHJlZHVuZGFudCBg
Y2xlYW5fcGFnZWAgaW4gYHAybV9jcmVhdGVfdGFibGVgLgoKVGhpcyBpcyBw
YXJ0IG9mIENWRS0yMDIyLTMzNzQ3IC8gWFNBLTQwOS4KClNpZ25lZC1vZmYt
Ynk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQt
Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y
Zz4KLS0tCiBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0
IHwgIDggKysrKwogeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAg
ICAgICB8ICA2ICsrKwogeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAg
ICAgICAgICB8IDI5ICsrKysrKysrKysrKysrCiB4ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMgICAgICAgICAgICAgICAgIHwgMjMgKysrKysrKysrKy0KIHhlbi9h
cmNoL2FybS9wMm0uYyAgICAgICAgICAgICAgICAgICAgfCA1NyArKysrKysr
KysrKysrKysrKysrKysrKysrLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTE4IGlu
c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9j
cy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCBiL2RvY3MvbWlz
Yy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKaW5kZXggNTI0M2JjN2Zk
MzQ0Li40NzBjOTQ5MWE3ODEgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlzYy9hcm0v
ZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKKysrIGIvZG9jcy9taXNjL2FybS9k
ZXZpY2UtdHJlZS9ib290aW5nLnR4dApAQCAtMTY0LDYgKzE2NCwxNCBAQCB3
aXRoIHRoZSBmb2xsb3dpbmcgcHJvcGVydGllczoKICAgICBCb3RoICNhZGRy
ZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBuZWVkIHRvIGJlIHNwZWNpZmll
ZCBiZWNhdXNlCiAgICAgYm90aCBzdWItbm9kZXMgKGRlc2NyaWJlZCBzaG9y
dGx5KSBoYXZlIHJlZyBwcm9wZXJ0aWVzLgogCistIHhlbixkb21haW4tcDJt
LW1lbS1tYgorCisgICAgT3B0aW9uYWwuIEEgMzItYml0IGludGVnZXIgc3Bl
Y2lmeWluZyB0aGUgYW1vdW50IG9mIG1lZ2FieXRlcyBvZiBSQU0KKyAgICB1
c2VkIGZvciB0aGUgZG9tYWluIFAyTSBwb29sLiBUaGlzIGlzIGluLXN5bmMg
d2l0aCB0aGUgc2hhZG93X21lbW9yeQorICAgIG9wdGlvbiBpbiB4bC5jZmcu
IExlYXZpbmcgdGhpcyBmaWVsZCBlbXB0eSBpbiBkZXZpY2UgdHJlZSB3aWxs
IGxlYWQgdG8KKyAgICB0aGUgZGVmYXVsdCBzaXplIG9mIGRvbWFpbiBQMk0g
cG9vbCwgaS5lLiAxTUIgcGVyIGd1ZXN0IHZDUFUgcGx1cyA0S0IKKyAgICBw
ZXIgTUIgb2YgZ3Vlc3QgUkFNIHBsdXMgNTEyS0IgZm9yIGd1ZXN0IGV4dGVu
ZGVkIHJlZ2lvbnMuCisKIFVuZGVyIHRoZSAieGVuLGRvbWFpbiIgY29tcGF0
aWJsZSBub2RlLCBvbmUgb3IgbW9yZSBzdWItbm9kZXMgYXJlIHByZXNlbnQK
IGZvciB0aGUgRG9tVSBrZXJuZWwgYW5kIHJhbWRpc2suCiAKZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21h
aW4uYwppbmRleCAyMjNlYzk2OTRkZjEuLmE1ZmZkOTUyZWNkMCAxMDA2NDQK
LS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL2Fy
bS9kb21haW4uYwpAQCAtOTg1LDYgKzk4NSw3IEBAIGVudW0gewogICAgIFBS
T0dfcGFnZSwKICAgICBQUk9HX21hcHBpbmcsCiAgICAgUFJPR19wMm0sCisg
ICAgUFJPR19wMm1fcG9vbCwKICAgICBQUk9HX2RvbmUsCiB9OwogCkBAIC0x
MDQ0LDYgKzEwNDUsMTEgQEAgaW50IGRvbWFpbl9yZWxpbnF1aXNoX3Jlc291
cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQogICAgICAgICBpZiAoIHJldCApCiAg
ICAgICAgICAgICByZXR1cm4gcmV0OwogCisgICAgUFJPR1JFU1MocDJtX3Bv
b2wpOgorICAgICAgICByZXQgPSBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbihk
KTsKKyAgICAgICAgaWYoIHJldCApCisgICAgICAgICAgICByZXR1cm4gcmV0
OworCiAgICAgUFJPR1JFU1MoZG9uZSk6CiAgICAgICAgIGJyZWFrOwogCmRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4v
YXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKaW5kZXggMjZjMTM0Mjk0ODhkLi5k
ZjBlYzg0ZjAzNGMgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5f
YnVpbGQuYworKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKQEAg
LTIzMzMsNiArMjMzMywyMSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZmluZF9n
bnR0YWJfcmVnaW9uKHN0cnVjdCBkb21haW4gKmQsCiAgICAgICAgICAgIGtp
bmZvLT5nbnR0YWJfc3RhcnQsIGtpbmZvLT5nbnR0YWJfc3RhcnQgKyBraW5m
by0+Z250dGFiX3NpemUpOwogfQogCitzdGF0aWMgdW5zaWduZWQgbG9uZyBf
X2luaXQgZG9tYWluX3AybV9wYWdlcyh1bnNpZ25lZCBsb25nIG1heG1lbV9r
YiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHVuc2lnbmVkIGludCBzbXBfY3B1cykKK3sKKyAgICAvKgorICAgICAq
IEtlZXAgaW4gc3luYyB3aXRoIGxpYnhsX19nZXRfcmVxdWlyZWRfcGFnaW5n
X21lbW9yeSgpLgorICAgICAqIDI1NiBwYWdlcyAoMU1CKSBwZXIgdmNwdSwg
cGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBSQU0gZm9yIHRoZSBQMk0gbWFwLAor
ICAgICAqIHBsdXMgMTI4IHBhZ2VzIHRvIGNvdmVyIGV4dGVuZGVkIHJlZ2lv
bnMuCisgICAgICovCisgICAgdW5zaWduZWQgbG9uZyBtZW1rYiA9IDQgKiAo
MjU2ICogc21wX2NwdXMgKyAobWF4bWVtX2tiIC8gMTAyNCkgKyAxMjgpOwor
CisgICAgQlVJTERfQlVHX09OKFBBR0VfU0laRSAhPSBTWl80Syk7CisKKyAg
ICByZXR1cm4gRElWX1JPVU5EX1VQKG1lbWtiLCAxMDI0KSA8PCAoMjAgLSBQ
QUdFX1NISUZUKTsKK30KKwogc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0
X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8g
KmtpbmZvKQogewogICAgIHVuc2lnbmVkIGludCBpOwpAQCAtMjQyNCw2ICsy
NDM5LDggQEAgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3Ry
dWN0IGRvbWFpbiAqZCwKICAgICBzdHJ1Y3Qga2VybmVsX2luZm8ga2luZm8g
PSB7fTsKICAgICBpbnQgcmM7CiAgICAgdTY0IG1lbTsKKyAgICB1MzIgcDJt
X21lbV9tYjsKKyAgICB1bnNpZ25lZCBsb25nIHAybV9wYWdlczsKIAogICAg
IHJjID0gZHRfcHJvcGVydHlfcmVhZF91NjQobm9kZSwgIm1lbW9yeSIsICZt
ZW0pOwogICAgIGlmICggIXJjICkKQEAgLTI0MzMsNiArMjQ1MCwxOCBAQCBz
dGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWlu
ICpkLAogICAgIH0KICAgICBraW5mby51bmFzc2lnbmVkX21lbSA9IChwYWRk
cl90KW1lbSAqIFNaXzFLOwogCisgICAgcmMgPSBkdF9wcm9wZXJ0eV9yZWFk
X3UzMihub2RlLCAieGVuLGRvbWFpbi1wMm0tbWVtLW1iIiwgJnAybV9tZW1f
bWIpOworICAgIC8qIElmIHhlbixkb21haW4tcDJtLW1lbS1tYiBpcyBub3Qg
c3BlY2lmaWVkLCB1c2UgdGhlIGRlZmF1bHQgdmFsdWUuICovCisgICAgcDJt
X3BhZ2VzID0gcmMgPworICAgICAgICAgICAgICAgIHAybV9tZW1fbWIgPDwg
KDIwIC0gUEFHRV9TSElGVCkgOgorICAgICAgICAgICAgICAgIGRvbWFpbl9w
Mm1fcGFnZXMobWVtLCBkLT5tYXhfdmNwdXMpOworCisgICAgc3Bpbl9sb2Nr
KCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICByYyA9IHAybV9zZXRfYWxs
b2NhdGlvbihkLCBwMm1fcGFnZXMsIE5VTEwpOworICAgIHNwaW5fdW5sb2Nr
KCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICBpZiAoIHJjICE9IDAgKQor
ICAgICAgICByZXR1cm4gcmM7CisKICAgICBwcmludGsoIioqKiBMT0FESU5H
IERPTVUgY3B1cz0ldSBtZW1vcnk9JSJQUkl4NjQiS0IgKioqXG4iLCBkLT5t
YXhfdmNwdXMsIG1lbSk7CiAKICAgICBraW5mby52cGwwMTEgPSBkdF9wcm9w
ZXJ0eV9yZWFkX2Jvb2wobm9kZSwgInZwbDAxMSIpOwpkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gvYXJtL2RvbWN0bC5jIGIveGVuL2FyY2gvYXJtL2RvbWN0bC5j
CmluZGV4IGEwNDliYzdmM2U1Mi4uNGFiNWVkNGFiMjRkIDEwMDY0NAotLS0g
YS94ZW4vYXJjaC9hcm0vZG9tY3RsLmMKKysrIGIveGVuL2FyY2gvYXJtL2Rv
bWN0bC5jCkBAIC00OCw2ICs0OCw5IEBAIHN0YXRpYyBpbnQgaGFuZGxlX3Z1
YXJ0X2luaXQoc3RydWN0IGRvbWFpbiAqZCwKIHN0YXRpYyBsb25nIHAybV9k
b21jdGwoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhlbl9kb21jdGxfc2hh
ZG93X29wICpzYywKICAgICAgICAgICAgICAgICAgICAgICAgWEVOX0dVRVNU
X0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKQogeworICAg
IGxvbmcgcmM7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsKKwogICAg
IGlmICggdW5saWtlbHkoZCA9PSBjdXJyZW50LT5kb21haW4pICkKICAgICB7
CiAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJUcmllZCB0byBkbyBhIHAy
bSBkb21jdGwgb3Agb24gaXRzZWxmLlxuIik7CkBAIC02NCw5ICs2NywyNyBA
QCBzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQsIHN0
cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCiAgICAgc3dpdGNoICgg
c2MtPm9wICkKICAgICB7CiAgICAgY2FzZSBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTjoKLSAgICAgICAgcmV0dXJuIDA7CisgICAgewor
ICAgICAgICAvKiBBbGxvdyBhbmQgaGFuZGxlIHByZWVtcHRpb24gKi8KKyAg
ICAgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICAg
ICAgcmMgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgc2MtPm1iIDw8ICgyMCAt
IFBBR0VfU0hJRlQpLCAmcHJlZW1wdGVkKTsKKyAgICAgICAgc3Bpbl91bmxv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworCisgICAgICAgIGlmICggcHJl
ZW1wdGVkICkKKyAgICAgICAgICAgIC8qIE5vdCBmaW5pc2hlZC4gU2V0IHVw
IHRvIHJlLXJ1biB0aGUgY2FsbC4gKi8KKyAgICAgICAgICAgIHJjID0gaHlw
ZXJjYWxsX2NyZWF0ZV9jb250aW51YXRpb24oX19IWVBFUlZJU09SX2RvbWN0
bCwgImgiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1X2RvbWN0bCk7CisgICAgICAgIGVsc2UKKyAgICAgICAg
ICAgIC8qIEZpbmlzaGVkLiBSZXR1cm4gdGhlIG5ldyBhbGxvY2F0aW9uLiAq
LworICAgICAgICAgICAgc2MtPm1iID0gcDJtX2dldF9hbGxvY2F0aW9uKGQp
OworCisgICAgICAgIHJldHVybiByYzsKKyAgICB9CiAgICAgY2FzZSBYRU5f
RE9NQ1RMX1NIQURPV19PUF9HRVRfQUxMT0NBVElPTjoKKyAgICB7CisgICAg
ICAgIHNjLT5tYiA9IHAybV9nZXRfYWxsb2NhdGlvbihkKTsKICAgICAgICAg
cmV0dXJuIDA7CisgICAgfQogICAgIGRlZmF1bHQ6CiAgICAgewogICAgICAg
ICBwcmludGsoWEVOTE9HX0VSUiAiQmFkIHAybSBkb21jdGwgb3AgJXVcbiIs
IHNjLT5vcCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94
ZW4vYXJjaC9hcm0vcDJtLmMKaW5kZXggNjg4M2Q4NjI3NzAyLi5jMTA1NWZm
MmE3NDUgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYworKysgYi94
ZW4vYXJjaC9hcm0vcDJtLmMKQEAgLTUwLDYgKzUwLDU0IEBAIHN0YXRpYyB1
aW50NjRfdCBnZW5lcmF0ZV92dHRicih1aW50MTZfdCB2bWlkLCBtZm5fdCBy
b290X21mbikKICAgICByZXR1cm4gKG1mbl90b19tYWRkcihyb290X21mbikg
fCAoKHVpbnQ2NF90KXZtaWQgPDwgNDgpKTsKIH0KIAorc3RhdGljIHN0cnVj
dCBwYWdlX2luZm8gKnAybV9hbGxvY19wYWdlKHN0cnVjdCBkb21haW4gKmQp
Cit7CisgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CisKKyAgICBzcGluX2xv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgIC8qCisgICAgICogRm9y
IGhhcmR3YXJlIGRvbWFpbiwgdGhlcmUgc2hvdWxkIGJlIG5vIGxpbWl0IGlu
IHRoZSBudW1iZXIgb2YgcGFnZXMgdGhhdAorICAgICAqIGNhbiBiZSBhbGxv
Y2F0ZWQsIHNvIHRoYXQgdGhlIGtlcm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ug
b2YgdGhlIGV4dGVuZGVkCisgICAgICogcmVnaW9ucy4gSGVuY2UsIGFsbG9j
YXRlIHAybSBwYWdlcyBmb3IgaGFyZHdhcmUgZG9tYWlucyBmcm9tIGhlYXAu
CisgICAgICovCisgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQor
ICAgIHsKKyAgICAgICAgcGcgPSBhbGxvY19kb21oZWFwX3BhZ2UoTlVMTCwg
MCk7CisgICAgICAgIGlmICggcGcgPT0gTlVMTCApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlIgIkZhaWxlZCB0byBhbGxv
Y2F0ZSBQMk0gcGFnZXMgZm9yIGh3ZG9tLlxuIik7CisgICAgICAgICAgICBz
cGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAgICAgICAg
ICByZXR1cm4gTlVMTDsKKyAgICAgICAgfQorICAgIH0KKyAgICBlbHNlCisg
ICAgeworICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgmZC0+
YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgaWYgKCB1bmxp
a2VseSghcGcpICkKKyAgICAgICAgeworICAgICAgICAgICAgc3Bpbl91bmxv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgICAgICAgICAgcmV0dXJu
IE5VTEw7CisgICAgICAgIH0KKyAgICAgICAgZC0+YXJjaC5wYWdpbmcucDJt
X3RvdGFsX3BhZ2VzLS07CisgICAgfQorICAgIHNwaW5fdW5sb2NrKCZkLT5h
cmNoLnBhZ2luZy5sb2NrKTsKKworICAgIHJldHVybiBwZzsKK30KKworc3Rh
dGljIHZvaWQgcDJtX2ZyZWVfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1
Y3QgcGFnZV9pbmZvICpwZykKK3sKKyAgICBzcGluX2xvY2soJmQtPmFyY2gu
cGFnaW5nLmxvY2spOworICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQp
ICkKKyAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOworICAgIGVsc2UK
KyAgICB7CisgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cysrOworICAgICAgICBwYWdlX2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNo
LnBhZ2luZy5wMm1fZnJlZWxpc3QpOworICAgIH0KKyAgICBzcGluX3VubG9j
aygmZC0+YXJjaC5wYWdpbmcubG9jayk7Cit9CisKIC8qIFJldHVybiB0aGUg
c2l6ZSBvZiB0aGUgcG9vbCwgcm91bmRlZCB1cCB0byB0aGUgbmVhcmVzdCBN
QiAqLwogdW5zaWduZWQgaW50IHAybV9nZXRfYWxsb2NhdGlvbihzdHJ1Y3Qg
ZG9tYWluICpkKQogewpAQCAtNzUxLDcgKzc5OSw3IEBAIHN0YXRpYyBpbnQg
cDJtX2NyZWF0ZV90YWJsZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBscGFl
X3QgKmVudHJ5KQogCiAgICAgQVNTRVJUKCFwMm1faXNfdmFsaWQoKmVudHJ5
KSk7CiAKLSAgICBwYWdlID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDAp
OworICAgIHBhZ2UgPSBwMm1fYWxsb2NfcGFnZShwMm0tPmRvbWFpbik7CiAg
ICAgaWYgKCBwYWdlID09IE5VTEwgKQogICAgICAgICByZXR1cm4gLUVOT01F
TTsKIApAQCAtODc4LDcgKzkyNiw3IEBAIHN0YXRpYyB2b2lkIHAybV9mcmVl
X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgcGcgPSBtZm5f
dG9fcGFnZShtZm4pOwogCiAgICAgcGFnZV9saXN0X2RlbChwZywgJnAybS0+
cGFnZXMpOwotICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsKKyAgICBwMm1f
ZnJlZV9wYWdlKHAybS0+ZG9tYWluLCBwZyk7CiB9CiAKIHN0YXRpYyBib29s
IHAybV9zcGxpdF9zdXBlcnBhZ2Uoc3RydWN0IHAybV9kb21haW4gKnAybSwg
bHBhZV90ICplbnRyeSwKQEAgLTkwMiw3ICs5NTAsNyBAQCBzdGF0aWMgYm9v
bCBwMm1fc3BsaXRfc3VwZXJwYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0s
IGxwYWVfdCAqZW50cnksCiAgICAgQVNTRVJUKGxldmVsIDwgdGFyZ2V0KTsK
ICAgICBBU1NFUlQocDJtX2lzX3N1cGVycGFnZSgqZW50cnksIGxldmVsKSk7
CiAKLSAgICBwYWdlID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDApOwor
ICAgIHBhZ2UgPSBwMm1fYWxsb2NfcGFnZShwMm0tPmRvbWFpbik7CiAgICAg
aWYgKCAhcGFnZSApCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApAQCAtMTY0
NCw3ICsxNjkyLDcgQEAgaW50IHAybV90ZWFyZG93bihzdHJ1Y3QgZG9tYWlu
ICpkKQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCiAgICAgewotICAgICAgICBmcmVlX2RvbWhl
YXBfcGFnZShwZyk7CisgICAgICAgIHAybV9mcmVlX3BhZ2UocDJtLT5kb21h
aW4sIHBnKTsKICAgICAgICAgY291bnQrKzsKICAgICAgICAgLyogQXJiaXRy
YXJpbHkgcHJlZW1wdCBldmVyeSA1MTIgaXRlcmF0aW9ucyAqLwogICAgICAg
ICBpZiAoICEoY291bnQgJSA1MTIpICYmIGh5cGVyY2FsbF9wcmVlbXB0X2No
ZWNrKCkgKQpAQCAtMTY2OCw2ICsxNzE2LDcgQEAgdm9pZCBwMm1fZmluYWxf
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAgcmV0dXJuOwog
CiAgICAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOwor
ICAgIEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmQtPmFyY2gucGFnaW5nLnAy
bV9mcmVlbGlzdCkpOwogCiAgICAgaWYgKCBwMm0tPnJvb3QgKQogICAgICAg
ICBmcmVlX2RvbWhlYXBfcGFnZXMocDJtLT5yb290LCBQMk1fUk9PVF9PUkRF
Uik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.16/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Disposition: attachment;
 filename="xsa409-4.16/0001-libxl-docs-Use-arch-specific-default-paging-memory.patch"
Content-Transfer-Encoding: base64

RnJvbSBiZDRhN2RiNDAwMTM2NGZkMDNhODBhMmU3M2I4MWM0NmFhYTQ0ZTlj
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgMjIgQXVnIDIwMjIgMDE6
MzU6MDkgKzAwMDAKU3ViamVjdDogW1BBVENIIDEvNF0gbGlieGwsIGRvY3M6
IFVzZSBhcmNoLXNwZWNpZmljIGRlZmF1bHQgcGFnaW5nIG1lbW9yeQoKVGhl
IGRlZmF1bHQgcGFnaW5nIG1lbW9yeSAoZGVzY2liZWQgaW4gYHNoYWRvd19t
ZW1vcnlgIGVudHJ5IGluIHhsCmNvbmZpZykgaW4gbGlieGwgaXMgdXNlZCB0
byBkZXRlcm1pbmUgdGhlIG1lbW9yeSBwb29sIHNpemUgZm9yIHhsCmd1ZXN0
cy4gQ3VycmVudGx5IHRoaXMgc2l6ZSBpcyBvbmx5IHVzZWQgZm9yIHg4Niwg
YW5kIGNvbnRhaW5zIGEgcGFydApvZiBSQU0gdG8gc2hhZG93IHRoZSByZXNp
ZGVudCBwcm9jZXNzZXMuIFNpbmNlIG9uIEFybSB0aGVyZSBpcyBubwpzaGFk
b3cgbW9kZSBndWVzdHMsIHNvIHRoZSBwYXJ0IG9mIFJBTSB0byBzaGFkb3cg
dGhlIHJlc2lkZW50IHByb2Nlc3NlcwppcyBub3QgbmVjZXNzYXJ5LiBUaGVy
ZWZvcmUsIHRoaXMgY29tbWl0IHNwbGl0cyB0aGUgZnVuY3Rpb24KYGxpYnhs
X2dldF9yZXF1aXJlZF9zaGFkb3dfbWVtb3J5KClgIHRvIGFyY2ggc3BlY2lm
aWMgaGVscGVycyBhbmQKcmVuYW1lZCB0aGUgaGVscGVyIHRvIGBsaWJ4bF9f
YXJjaF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSgpYC4KCk9uIHg4Niwg
dGhpcyBoZWxwZXIgY2FsbHMgdGhlIG9yaWdpbmFsIHZhbHVlIGZyb20KYGxp
YnhsX2dldF9yZXF1aXJlZF9zaGFkb3dfbWVtb3J5KClgIHNvIG5vIGZ1bmN0
aW9uYWwgY2hhbmdlIGludGVuZGVkLgoKT24gQXJtLCB0aGlzIGhlbHBlciBy
ZXR1cm5zIDFNQiBwZXIgdmNwdSBwbHVzIDRLQiBwZXIgTWlCIG9mIFJBTQpm
b3IgdGhlIFAyTSBtYXAgYW5kIGFkZGl0aW9uYWwgNTEyS0IuCgpBbHNvIHVw
ZGF0ZSB0aGUgeGwuY2ZnIGRvY3VtZW50YXRpb24gdG8gYWRkIEFybSBkb2N1
bWVudGF0aW9uCmFjY29yZGluZyB0byBjb2RlIGNoYW5nZXMgYW5kIGNvcnJl
Y3QgdGhlIGNvbW1lbnQgc3R5bGUgZm9sbG93aW5nIFhlbgpjb2Rpbmcgc3R5
bGUuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0EtNDA5
LgoKU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24u
Y29tPgpTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFy
bS5jb20+ClJldmlld2VkLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w
ZXJhcmRAY2l0cml4LmNvbT4KLS0tCiBkb2NzL21hbi94bC5jZmcuNS5wb2Qu
aW4gICAgICAgfCAgNSArKysrKwogdG9vbHMvbGlicy9saWdodC9saWJ4bF9h
cmNoLmggIHwgIDQgKysrKwogdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0u
YyAgIHwgMTQgKysrKysrKysrKysrKysKIHRvb2xzL2xpYnMvbGlnaHQvbGli
eGxfdXRpbHMuYyB8ICA5ICsrLS0tLS0tLQogdG9vbHMvbGlicy9saWdodC9s
aWJ4bF94ODYuYyAgIHwgMTMgKysrKysrKysrKysrKwogNSBmaWxlcyBjaGFu
Z2VkLCAzOCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAt
LWdpdCBhL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbiBiL2RvY3MvbWFuL3hs
LmNmZy41LnBvZC5pbgppbmRleCBiOThkMTYxMzk4N2UuLmVkYTFlNzdlYmQw
NiAxMDA2NDQKLS0tIGEvZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluCisrKyBi
L2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbgpAQCAtMTc2OCw2ICsxNzY4LDEx
IEBAIGFyZSBub3QgdXNpbmcgaGFyZHdhcmUgYXNzaXN0ZWQgcGFnaW5nIChp
LmUuIHlvdSBhcmUgdXNpbmcgc2hhZG93CiBtb2RlKSBhbmQgeW91ciBndWVz
dCB3b3JrbG9hZCBjb25zaXN0cyBvZiBhIHZlcnkgbGFyZ2UgbnVtYmVyIG9m
CiBzaW1pbGFyIHByb2Nlc3NlcyB0aGVuIGluY3JlYXNpbmcgdGhpcyB2YWx1
ZSBtYXkgaW1wcm92ZSBwZXJmb3JtYW5jZS4KIAorT24gQXJtLCB0aGlzIGZp
ZWxkIGlzIHVzZWQgdG8gZGV0ZXJtaW5lIHRoZSBzaXplIG9mIHRoZSBndWVz
dCBQMk0gcGFnZXMKK3Bvb2wsIGFuZCB0aGUgZGVmYXVsdCB2YWx1ZSBpcyAx
TUIgcGVyIHZDUFUgcGx1cyA0S0IgcGVyIE1CIG9mIFJBTSBmb3IKK3RoZSBQ
Mk0gbWFwIGFuZCBhZGRpdGlvbmFsIDUxMktCIGZvciBleHRlbmRlZCByZWdp
b25zLiBVc2VycyBzaG91bGQKK2FkanVzdCB0aGlzIHZhbHVlIGlmIGJpZ2dl
ciBQMk0gcG9vbCBzaXplIGlzIG5lZWRlZC4KKwogPWJhY2sKIAogPWhlYWQz
IFByb2Nlc3NvciBhbmQgUGxhdGZvcm0gRmVhdHVyZXMKZGlmZiAtLWdpdCBh
L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oIGIvdG9vbHMvbGlicy9s
aWdodC9saWJ4bF9hcmNoLmgKaW5kZXggMTUyMmVjYjk3ZjcyLi41YTA2MGMy
YzMwMzMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJj
aC5oCisrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oCkBAIC05
MCw2ICs5MCwxMCBAQCB2b2lkIGxpYnhsX19hcmNoX3VwZGF0ZV9kb21haW5f
Y29uZmlnKGxpYnhsX19nYyAqZ2MsCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGxpYnhsX2RvbWFpbl9jb25maWcgKmRzdCwKICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGli
eGxfZG9tYWluX2NvbmZpZyAqc3JjKTsKIAorX2hpZGRlbgordW5zaWduZWQg
bG9uZyBsaWJ4bF9fYXJjaF9nZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1
bnNpZ25lZCBsb25nIG1heG1lbV9rYiwKKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50
IHNtcF9jcHVzKTsKKwogI2lmIGRlZmluZWQoX19pMzg2X18pIHx8IGRlZmlu
ZWQoX194ODZfNjRfXykKIAogI2RlZmluZSBMQVBJQ19CQVNFX0FERFJFU1Mg
IDB4ZmVlMDAwMDAKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli
eGxfYXJtLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jCmluZGV4
IGVlZjFkZTA5MzkxNC4uNzNhOTVlODNhZjI0IDEwMDY0NAotLS0gYS90b29s
cy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jCisrKyBiL3Rvb2xzL2xpYnMvbGln
aHQvbGlieGxfYXJtLmMKQEAgLTE1NCw2ICsxNTQsMjAgQEAgb3V0OgogICAg
IHJldHVybiByYzsKIH0KIAordW5zaWduZWQgbG9uZyBsaWJ4bF9fYXJjaF9n
ZXRfcmVxdWlyZWRfcGFnaW5nX21lbW9yeSh1bnNpZ25lZCBsb25nIG1heG1l
bV9rYiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNtcF9jcHVzKQoreworICAg
IC8qCisgICAgICogMjU2IHBhZ2VzICgxTUIpIHBlciB2Y3B1LAorICAgICAq
IHBsdXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIGZvciB0aGUgUDJNIG1hcCwK
KyAgICAgKiBwbHVzIDEgcGFnZSBwZXIgTWlCIG9mIGV4dGVuZGVkIHJlZ2lv
bi4gVGhpcyBkZWZhdWx0IHZhbHVlIGlzIDEyOCBNaUIKKyAgICAgKiB3aGlj
aCBzaG91bGQgYmUgZW5vdWdoIGZvciBkb21haW5zIHRoYXQgYXJlIG5vdCBy
dW5uaW5nIGJhY2tlbmQuCisgICAgICogVGhpcyBpcyBoaWdoZXIgdGhhbiB0
aGUgbWluaW11bSB0aGF0IFhlbiB3b3VsZCBhbGxvY2F0ZSBpZiBubyB2YWx1
ZQorICAgICAqIHdlcmUgZ2l2ZW4gKGJ1dCB0aGUgWGVuIG1pbmltdW0gaXMg
Zm9yIHNhZmV0eSwgbm90IHBlcmZvcm1hbmNlKS4KKyAgICAgKi8KKyAgICBy
ZXR1cm4gNCAqICgyNTYgKiBzbXBfY3B1cyArIG1heG1lbV9rYiAvIDEwMjQg
KyAxMjgpOworfQorCiBzdGF0aWMgc3RydWN0IGFyY2hfaW5mbyB7CiAgICAg
Y29uc3QgY2hhciAqZ3Vlc3RfdHlwZTsKICAgICBjb25zdCBjaGFyICp0aW1l
cl9jb21wYXQ7CmRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhs
X3V0aWxzLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3V0aWxzLmMKaW5k
ZXggNDY5OWM0YTBhMzZmLi5lMjc2YzBlZTljYzMgMTAwNjQ0Ci0tLSBhL3Rv
b2xzL2xpYnMvbGlnaHQvbGlieGxfdXRpbHMuYworKysgYi90b29scy9saWJz
L2xpZ2h0L2xpYnhsX3V0aWxzLmMKQEAgLTE4LDYgKzE4LDcgQEAKICNpbmNs
dWRlIDxjdHlwZS5oPgogCiAjaW5jbHVkZSAibGlieGxfaW50ZXJuYWwuaCIK
KyNpbmNsdWRlICJsaWJ4bF9hcmNoLmgiCiAjaW5jbHVkZSAiX3BhdGhzLmgi
CiAKICNpZm5kZWYgTElCWExfSEFWRV9OT05DT05TVF9MSUJYTF9CQVNFTkFN
RV9SRVRVUk5fVkFMVUUKQEAgLTM5LDEzICs0MCw3IEBAIGNoYXIgKmxpYnhs
X2Jhc2VuYW1lKGNvbnN0IGNoYXIgKm5hbWUpCiAKIHVuc2lnbmVkIGxvbmcg
bGlieGxfZ2V0X3JlcXVpcmVkX3NoYWRvd19tZW1vcnkodW5zaWduZWQgbG9u
ZyBtYXhtZW1fa2IsIHVuc2lnbmVkIGludCBzbXBfY3B1cykKIHsKLSAgICAv
KiAyNTYgcGFnZXMgKDFNQikgcGVyIHZjcHUsCi0gICAgICAgcGx1cyAxIHBh
Z2UgcGVyIE1pQiBvZiBSQU0gZm9yIHRoZSBQMk0gbWFwLAotICAgICAgIHBs
dXMgMSBwYWdlIHBlciBNaUIgb2YgUkFNIHRvIHNoYWRvdyB0aGUgcmVzaWRl
bnQgcHJvY2Vzc2VzLgotICAgICAgIFRoaXMgaXMgaGlnaGVyIHRoYW4gdGhl
IG1pbmltdW0gdGhhdCBYZW4gd291bGQgYWxsb2NhdGUgaWYgbm8gdmFsdWUK
LSAgICAgICB3ZXJlIGdpdmVuIChidXQgdGhlIFhlbiBtaW5pbXVtIGlzIGZv
ciBzYWZldHksIG5vdCBwZXJmb3JtYW5jZSkuCi0gICAgICovCi0gICAgcmV0
dXJuIDQgKiAoMjU2ICogc21wX2NwdXMgKyAyICogKG1heG1lbV9rYiAvIDEw
MjQpKTsKKyAgICByZXR1cm4gbGlieGxfX2FyY2hfZ2V0X3JlcXVpcmVkX3Bh
Z2luZ19tZW1vcnkobWF4bWVtX2tiLCBzbXBfY3B1cyk7CiB9CiAKIGNoYXIg
KmxpYnhsX2RvbWlkX3RvX25hbWUobGlieGxfY3R4ICpjdHgsIHVpbnQzMl90
IGRvbWlkKQpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF94
ODYuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfeDg2LmMKaW5kZXggMWZl
YWRlYmIxODUyLi41MTM2Mjg5M2NmOTggMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xp
YnMvbGlnaHQvbGlieGxfeDg2LmMKKysrIGIvdG9vbHMvbGlicy9saWdodC9s
aWJ4bF94ODYuYwpAQCAtODgyLDYgKzg4MiwxOSBAQCB2b2lkIGxpYnhsX19h
cmNoX3VwZGF0ZV9kb21haW5fY29uZmlnKGxpYnhsX19nYyAqZ2MsCiAgICAg
ICAgICAgICAgICAgICAgIGxpYnhsX2RlZmJvb2xfdmFsKHNyYy0+Yl9pbmZv
LmFyY2hfeDg2Lm1zcl9yZWxheGVkKSk7CiB9CiAKK3Vuc2lnbmVkIGxvbmcg
bGlieGxfX2FyY2hfZ2V0X3JlcXVpcmVkX3BhZ2luZ19tZW1vcnkodW5zaWdu
ZWQgbG9uZyBtYXhtZW1fa2IsCisgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBzbXBf
Y3B1cykKK3sKKyAgICAvKgorICAgICAqIDI1NiBwYWdlcyAoMU1CKSBwZXIg
dmNwdSwKKyAgICAgKiBwbHVzIDEgcGFnZSBwZXIgTWlCIG9mIFJBTSBmb3Ig
dGhlIFAyTSBtYXAsCisgICAgICogcGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBS
QU0gdG8gc2hhZG93IHRoZSByZXNpZGVudCBwcm9jZXNzZXMuCisgICAgICog
VGhpcyBpcyBoaWdoZXIgdGhhbiB0aGUgbWluaW11bSB0aGF0IFhlbiB3b3Vs
ZCBhbGxvY2F0ZSBpZiBubyB2YWx1ZQorICAgICAqIHdlcmUgZ2l2ZW4gKGJ1
dCB0aGUgWGVuIG1pbmltdW0gaXMgZm9yIHNhZmV0eSwgbm90IHBlcmZvcm1h
bmNlKS4KKyAgICAgKi8KKyAgICByZXR1cm4gNCAqICgyNTYgKiBzbXBfY3B1
cyArIDIgKiAobWF4bWVtX2tiIC8gMTAyNCkpOworfQorCiAvKgogICogTG9j
YWwgdmFyaWFibGVzOgogICogbW9kZTogQwotLSAKMi4zNy4xCgo=

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.16/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Disposition: attachment;
 filename="xsa409-4.16/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Transfer-Encoding: base64

RnJvbSA0MTlhNGJiYzIwY2Y3YzVkN2Q5ZGVkYWU1OWZiODA0OTkyMmU2YTJj
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMi80XSB4ZW4vYXJtOiBDb25z
dHJ1Y3QgdGhlIFAyTSBwYWdlcyBwb29sIGZvciBndWVzdHMKClRoaXMgY29t
bWl0IGNvbnN0cnVjdHMgdGhlIHAybSBwYWdlcyBwb29sIGZvciBndWVzdHMg
ZnJvbSB0aGUKZGF0YSBzdHJ1Y3R1cmUgYW5kIGhlbHBlciBwZXJzcGVjdGl2
ZS4KClRoaXMgaXMgaW1wbGVtZW50ZWQgYnk6CgotIEFkZGluZyBhIGBzdHJ1
Y3QgcGFnaW5nX2RvbWFpbmAgd2hpY2ggY29udGFpbnMgYSBmcmVlbGlzdCwg
YQpjb3VudGVyIHZhcmlhYmxlIGFuZCBhIHNwaW5sb2NrIHRvIGBzdHJ1Y3Qg
YXJjaF9kb21haW5gIHRvCmluZGljYXRlIHRoZSBmcmVlIHAybSBwYWdlcyBh
bmQgdGhlIG51bWJlciBvZiBwMm0gdG90YWwgcGFnZXMgaW4KdGhlIHAybSBw
YWdlcyBwb29sLgoKLSBBZGRpbmcgYSBoZWxwZXIgYHAybV9nZXRfYWxsb2Nh
dGlvbmAgdG8gZ2V0IHRoZSBwMm0gcG9vbCBzaXplLgoKLSBBZGRpbmcgYSBo
ZWxwZXIgYHAybV9zZXRfYWxsb2NhdGlvbmAgdG8gc2V0IHRoZSBwMm0gcGFn
ZXMgcG9vbApzaXplLiBUaGlzIGhlbHBlciBzaG91bGQgYmUgY2FsbGVkIGJl
Zm9yZSBhbGxvY2F0aW5nIG1lbW9yeSBmb3IKYSBndWVzdC4KCi0gQWRkaW5n
IGEgaGVscGVyIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAgdG8gZnJlZSB0
aGUgcDJtIHBhZ2VzCnBvb2wuIFRoaXMgaGVscGVyIHNob3VsZCBiZSBjYWxs
ZWQgZHVyaW5nIHRoZSB4bCBkb21haW4gZGVzdG9yeS4KClRoaXMgaXMgcGFy
dCBvZiBDVkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTaWduZWQtb2ZmLWJ5
OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5
OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+
Ci0tLQogeGVuL2FyY2gvYXJtL3AybS5jICAgICAgICAgICB8IDg4ICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogeGVuL2luY2x1ZGUv
YXNtLWFybS9kb21haW4uaCB8IDEwICsrKysKIHhlbi9pbmNsdWRlL2FzbS1h
cm0vcDJtLmggICAgfCAgNCArKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDIgaW5z
ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBi
L3hlbi9hcmNoL2FybS9wMm0uYwppbmRleCAzYmNkMWU4OTdlODguLjc5ZjNk
MzdmNTIzMCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCisrKyBi
L3hlbi9hcmNoL2FybS9wMm0uYwpAQCAtNTAsNiArNTAsOTIgQEAgc3RhdGlj
IHVpbnQ2NF90IGdlbmVyYXRlX3Z0dGJyKHVpbnQxNl90IHZtaWQsIG1mbl90
IHJvb3RfbWZuKQogICAgIHJldHVybiAobWZuX3RvX21hZGRyKHJvb3RfbWZu
KSB8ICgodWludDY0X3Qpdm1pZCA8PCA0OCkpOwogfQogCisvKiBSZXR1cm4g
dGhlIHNpemUgb2YgdGhlIHBvb2wsIHJvdW5kZWQgdXAgdG8gdGhlIG5lYXJl
c3QgTUIgKi8KK3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIG5yX3BhZ2Vz
ID0gQUNDRVNTX09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2Vz
KTsKKworICAgIHJldHVybiBST1VORFVQKG5yX3BhZ2VzLCAxIDw8ICgyMCAt
IFBBR0VfU0hJRlQpKSA+PiAoMjAgLSBQQUdFX1NISUZUKTsKK30KKworLyoK
KyAqIFNldCB0aGUgcG9vbCBvZiBwYWdlcyB0byB0aGUgcmVxdWlyZWQgbnVt
YmVyIG9mIHBhZ2VzLgorICogUmV0dXJucyAwIGZvciBzdWNjZXNzLCBub24t
emVybyBmb3IgZmFpbHVyZS4KKyAqIENhbGwgd2l0aCBkLT5hcmNoLnBhZ2lu
Zy5sb2NrIGhlbGQuCisgKi8KK2ludCBwMm1fc2V0X2FsbG9jYXRpb24oc3Ry
dWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBwYWdlcywgYm9vbCAqcHJl
ZW1wdGVkKQoreworICAgIHN0cnVjdCBwYWdlX2luZm8gKnBnOworCisgICAg
QVNTRVJUKHNwaW5faXNfbG9ja2VkKCZkLT5hcmNoLnBhZ2luZy5sb2NrKSk7
CisKKyAgICBmb3IgKCA7IDsgKQorICAgIHsKKyAgICAgICAgaWYgKCBkLT5h
cmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPCBwYWdlcyApCisgICAgICAg
IHsKKyAgICAgICAgICAgIC8qIE5lZWQgdG8gYWxsb2NhdGUgbW9yZSBtZW1v
cnkgZnJvbSBkb21oZWFwICovCisgICAgICAgICAgICBwZyA9IGFsbG9jX2Rv
bWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICAgICAgICAgIGlmICggcGcgPT0g
TlVMTCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcHJpbnRr
KFhFTkxPR19FUlIgIkZhaWxlZCB0byBhbGxvY2F0ZSBQMk0gcGFnZXMuXG4i
KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKKyAgICAgICAg
ICAgIH0KKyAgICAgICAgICAgIEFDQ0VTU19PTkNFKGQtPmFyY2gucGFnaW5n
LnAybV90b3RhbF9wYWdlcykgPQorICAgICAgICAgICAgICAgIGQtPmFyY2gu
cGFnaW5nLnAybV90b3RhbF9wYWdlcyArIDE7CisgICAgICAgICAgICBwYWdl
X2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxp
c3QpOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBkLT5hcmNoLnBh
Z2luZy5wMm1fdG90YWxfcGFnZXMgPiBwYWdlcyApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIC8qIE5lZWQgdG8gcmV0dXJuIG1lbW9yeSB0byBkb21oZWFw
ICovCisgICAgICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgm
ZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgICAgIGlm
KCBwZyApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgQUNDRVNT
X09OQ0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzKSA9CisgICAg
ICAgICAgICAgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cyAtIDE7CisgICAgICAgICAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcp
OworICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSCisgICAg
ICAgICAgICAgICAgICAgICAgICJGYWlsZWQgdG8gZnJlZSBQMk0gcGFnZXMs
IFAyTSBmcmVlbGlzdCBpcyBlbXB0eS5cbiIpOworICAgICAgICAgICAgICAg
IHJldHVybiAtRU5PTUVNOworICAgICAgICAgICAgfQorICAgICAgICB9Cisg
ICAgICAgIGVsc2UKKyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIC8q
IENoZWNrIHRvIHNlZSBpZiB3ZSBuZWVkIHRvIHlpZWxkIGFuZCB0cnkgYWdh
aW4gKi8KKyAgICAgICAgaWYgKCBwcmVlbXB0ZWQgJiYgZ2VuZXJhbF9wcmVl
bXB0X2NoZWNrKCkgKQorICAgICAgICB7CisgICAgICAgICAgICAqcHJlZW1w
dGVkID0gdHJ1ZTsKKyAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7Cisg
ICAgICAgIH0KKyAgICB9CisKKyAgICByZXR1cm4gMDsKK30KKworaW50IHAy
bV90ZWFyZG93bl9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQpCit7Cisg
ICAgaW50IHJldCA9IDA7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsK
KworICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAg
aWYgKCBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgIT0gMCApCisg
ICAgeworICAgICAgICByZXQgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwg
JnByZWVtcHRlZCk7CisgICAgICAgIGlmICggcHJlZW1wdGVkICkKKyAgICAg
ICAgeworICAgICAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5n
LmxvY2spOworICAgICAgICAgICAgcmV0dXJuIC1FUkVTVEFSVDsKKyAgICAg
ICAgfQorICAgICAgICBBU1NFUlQoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFs
X3BhZ2VzID09IDApOworICAgIH0KKyAgICBzcGluX3VubG9jaygmZC0+YXJj
aC5wYWdpbmcubG9jayk7CisKKyAgICByZXR1cm4gcmV0OworfQorCiAvKiBV
bmxvY2sgdGhlIGZsdXNoIGFuZCBkbyBhIFAyTSBUTEIgZmx1c2ggaWYgbmVj
ZXNzYXJ5ICovCiB2b2lkIHAybV93cml0ZV91bmxvY2soc3RydWN0IHAybV9k
b21haW4gKnAybSkKIHsKQEAgLTE1OTksNyArMTY4NSw5IEBAIGludCBwMm1f
aW5pdChzdHJ1Y3QgZG9tYWluICpkKQogICAgIHVuc2lnbmVkIGludCBjcHU7
CiAKICAgICByd2xvY2tfaW5pdCgmcDJtLT5sb2NrKTsKKyAgICBzcGluX2xv
Y2tfaW5pdCgmZC0+YXJjaC5wYWdpbmcubG9jayk7CiAgICAgSU5JVF9QQUdF
X0xJU1RfSEVBRCgmcDJtLT5wYWdlcyk7CisgICAgSU5JVF9QQUdFX0xJU1Rf
SEVBRCgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKIAogICAgIHAy
bS0+dm1pZCA9IElOVkFMSURfVk1JRDsKIApkaWZmIC0tZ2l0IGEveGVuL2lu
Y2x1ZGUvYXNtLWFybS9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v
ZG9tYWluLmgKaW5kZXggOWIzNjQ3NTg3YTA0Li5jOTBkYWE2NWFmYTcgMTAw
NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmgKKysrIGIv
eGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaApAQCAtNDAsNiArNDAsMTQg
QEAgc3RydWN0IHZ0aW1lciB7CiAgICAgdWludDY0X3QgY3ZhbDsKIH07CiAK
K3N0cnVjdCBwYWdpbmdfZG9tYWluIHsKKyAgICBzcGlubG9ja190IGxvY2s7
CisgICAgLyogRnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgcHJlLWFsbG9jYXRl
ZCBQMk0gcG9vbCAqLworICAgIHN0cnVjdCBwYWdlX2xpc3RfaGVhZCBwMm1f
ZnJlZWxpc3Q7CisgICAgLyogTnVtYmVyIG9mIHBhZ2VzIGZyb20gdGhlIHBy
ZS1hbGxvY2F0ZWQgUDJNIHBvb2wgKi8KKyAgICB1bnNpZ25lZCBsb25nIHAy
bV90b3RhbF9wYWdlczsKK307CisKIHN0cnVjdCBhcmNoX2RvbWFpbgogewog
I2lmZGVmIENPTkZJR19BUk1fNjQKQEAgLTUxLDYgKzU5LDggQEAgc3RydWN0
IGFyY2hfZG9tYWluCiAKICAgICBzdHJ1Y3QgaHZtX2RvbWFpbiBodm07CiAK
KyAgICBzdHJ1Y3QgcGFnaW5nX2RvbWFpbiBwYWdpbmc7CisKICAgICBzdHJ1
Y3Qgdm1taW8gdm1taW87CiAKICAgICAvKiBDb250aW51YWJsZSBkb21haW5f
cmVsaW5xdWlzaF9yZXNvdXJjZXMoKS4gKi8KZGlmZiAtLWdpdCBhL3hlbi9p
bmNsdWRlL2FzbS1hcm0vcDJtLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3Ay
bS5oCmluZGV4IGIzYmE4MzI4M2UxMS4uYzk1OTg3NDBiZDAyIDEwMDY0NAot
LS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCisrKyBiL3hlbi9pbmNs
dWRlL2FzbS1hcm0vcDJtLmgKQEAgLTIxOCw2ICsyMTgsMTAgQEAgdm9pZCBw
Mm1fcmVzdG9yZV9zdGF0ZShzdHJ1Y3QgdmNwdSAqbik7CiAvKiBQcmludCBk
ZWJ1Z2dpbmcvc3RhdGlzdGlhbCBpbmZvIGFib3V0IGEgZG9tYWluJ3MgcDJt
ICovCiB2b2lkIHAybV9kdW1wX2luZm8oc3RydWN0IGRvbWFpbiAqZCk7CiAK
K3Vuc2lnbmVkIGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3RydWN0IGRvbWFp
biAqZCk7CitpbnQgcDJtX3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4g
KmQsIHVuc2lnbmVkIGxvbmcgcGFnZXMsIGJvb2wgKnByZWVtcHRlZCk7Citp
bnQgcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCk7
CisKIHN0YXRpYyBpbmxpbmUgdm9pZCBwMm1fd3JpdGVfbG9jayhzdHJ1Y3Qg
cDJtX2RvbWFpbiAqcDJtKQogewogICAgIHdyaXRlX2xvY2soJnAybS0+bG9j
ayk7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.16/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Disposition: attachment;
 filename="xsa409-4.16/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Transfer-Encoding: base64

RnJvbSAzMzJhOTk3OWQ0ZGQwYjA0N2FhMTZkYjIwMWM1MGZjZWRiZDU2NzQz
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMy80XSB4ZW4vYXJtLCBsaWJ4
bDogSW1wbGVtZW50IFhFTl9ET01DVExfc2hhZG93X29wIGZvciBBcm0KClRo
aXMgY29tbWl0IGltcGxlbWVudHMgdGhlIGBYRU5fRE9NQ1RMX3NoYWRvd19v
cGAgc3VwcG9ydCBpbiBYZW4KZm9yIEFybS4gVGhlIHAybSBwYWdlcyBwb29s
IHNpemUgZm9yIHhsIGd1ZXN0cyBpcyBzdXBwb3NlZCB0byBiZQpkZXRlcm1p
bmVkIGJ5IGBYRU5fRE9NQ1RMX3NoYWRvd19vcGAuIEhlbmNlLCB0aGlzIGNv
bW1pdDoKCi0gSW50cm9kdWNlcyBhIGZ1bmN0aW9uIGBwMm1fZG9tY3RsYCBh
bmQgaW1wbGVtZW50cyB0aGUgc3Vib3BzCmBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTmAgYW5kCmBYRU5fRE9NQ1RMX1NIQURPV19PUF9H
RVRfQUxMT0NBVElPTmAgb2YgYFhFTl9ET01DVExfc2hhZG93X29wYC4KCi0g
QWRkcyB0aGUgYFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FUSU9O
YCBzdXBwb3J0IGluIGxpYnhsLgoKVGhlcmVmb3JlIGVuYWJsaW5nIHRoZSBz
ZXR0aW5nIG9mIHNoYWRvdyBtZW1vcnkgcG9vbCBzaXplCndoZW4gY3JlYXRp
bmcgYSBndWVzdCBmcm9tIHhsIGFuZCBnZXR0aW5nIHNoYWRvdyBtZW1vcnkg
cG9vbCBzaXplCmZyb20gWGVuLgoKTm90ZSB0aGF0IHRoZSBgWEVOX0RPTUNU
TF9zaGFkb3dfb3BgIGFkZGVkIGluIHRoaXMgY29tbWl0IGlzIG9ubHkKYSBk
dW1teSBvcCwgYW5kIHRoZSBmdW5jdGlvbmFsaXR5IG9mIHNldHRpbmcvZ2V0
dGluZyBwMm0gbWVtb3J5IHBvb2wKc2l6ZSBmb3IgeGwgZ3Vlc3RzIHdpbGwg
YmUgYWRkZWQgaW4gZm9sbG93aW5nIGNvbW1pdHMuCgpUaGlzIGlzIHBhcnQg
b2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0EtNDA5LgoKU2lnbmVkLW9mZi1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPgpSZXZpZXdlZC1ieTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgot
LS0KIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgfCAxMiArKysrKysr
KysrKysKIHhlbi9hcmNoL2FybS9kb21jdGwuYyAgICAgICAgfCAzMiArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk
LCA0NCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9s
aWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJt
LmMKaW5kZXggNzNhOTVlODNhZjI0Li4yMmEwYzU2MWJiYzYgMTAwNjQ0Ci0t
LSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMKKysrIGIvdG9vbHMv
bGlicy9saWdodC9saWJ4bF9hcm0uYwpAQCAtMTMxLDYgKzEzMSwxOCBAQCBp
bnQgbGlieGxfX2FyY2hfZG9tYWluX2NyZWF0ZShsaWJ4bF9fZ2MgKmdjLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9i
dWlsZF9zdGF0ZSAqc3RhdGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB1aW50MzJfdCBkb21pZCkKIHsKKyAgICBsaWJ4bF9jdHggKmN0eCA9
IGxpYnhsX19nY19vd25lcihnYyk7CisgICAgdW5zaWduZWQgaW50IHNoYWRv
d19tYiA9IERJVl9ST1VORFVQKGRfY29uZmlnLT5iX2luZm8uc2hhZG93X21l
bWtiLCAxMDI0KTsKKworICAgIGludCByID0geGNfc2hhZG93X2NvbnRyb2wo
Y3R4LT54Y2gsIGRvbWlkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgWEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT04sCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAmc2hhZG93X21iLCAwKTsKKyAg
ICBpZiAocikgeworICAgICAgICBMT0dFRChFUlJPUiwgZG9taWQsCisgICAg
ICAgICAgICAgICJGYWlsZWQgdG8gc2V0ICV1IE1pQiBzaGFkb3cgYWxsb2Nh
dGlvbiIsIHNoYWRvd19tYik7CisgICAgICAgIHJldHVybiBFUlJPUl9GQUlM
OworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCmRpZmYgLS1naXQgYS94
ZW4vYXJjaC9hcm0vZG9tY3RsLmMgYi94ZW4vYXJjaC9hcm0vZG9tY3RsLmMK
aW5kZXggMWJhZjI1YzNkOThiLi45YmY3MmU2OTMwMTkgMTAwNjQ0Ci0tLSBh
L3hlbi9hcmNoL2FybS9kb21jdGwuYworKysgYi94ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMKQEAgLTQ3LDExICs0Nyw0MyBAQCBzdGF0aWMgaW50IGhhbmRsZV92
dWFydF9pbml0KHN0cnVjdCBkb21haW4gKmQsCiAgICAgcmV0dXJuIHJjOwog
fQogCitzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQs
IHN0cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCisgICAgICAgICAg
ICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0
bF90KSB1X2RvbWN0bCkKK3sKKyAgICBpZiAoIHVubGlrZWx5KGQgPT0gY3Vy
cmVudC0+ZG9tYWluKSApCisgICAgeworICAgICAgICBwcmludGsoWEVOTE9H
X0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9wIG9uIGl0c2VsZi5c
biIpOworICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICB9CisKKyAgICBp
ZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisgICAgeworICAgICAgICBw
cmludGsoWEVOTE9HX0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9w
IG9uIGR5aW5nIGRvbWFpbiAldVxuIiwKKyAgICAgICAgICAgICAgIGQtPmRv
bWFpbl9pZCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOworICAgIH0KKwor
ICAgIHN3aXRjaCAoIHNjLT5vcCApCisgICAgeworICAgIGNhc2UgWEVOX0RP
TUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT046CisgICAgICAgIHJldHVy
biAwOworICAgIGNhc2UgWEVOX0RPTUNUTF9TSEFET1dfT1BfR0VUX0FMTE9D
QVRJT046CisgICAgICAgIHJldHVybiAwOworICAgIGRlZmF1bHQ6CisgICAg
eworICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiQmFkIHAybSBkb21jdGwg
b3AgJXVcbiIsIHNjLT5vcCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOwor
ICAgIH0KKyAgICB9Cit9CisKIGxvbmcgYXJjaF9kb19kb21jdGwoc3RydWN0
IHhlbl9kb21jdGwgKmRvbWN0bCwgc3RydWN0IGRvbWFpbiAqZCwKICAgICAg
ICAgICAgICAgICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9t
Y3RsX3QpIHVfZG9tY3RsKQogewogICAgIHN3aXRjaCAoIGRvbWN0bC0+Y21k
ICkKICAgICB7CisgICAgY2FzZSBYRU5fRE9NQ1RMX3NoYWRvd19vcDoKKyAg
ICAgICAgcmV0dXJuIHAybV9kb21jdGwoZCwgJmRvbWN0bC0+dS5zaGFkb3df
b3AsIHVfZG9tY3RsKTsKICAgICBjYXNlIFhFTl9ET01DVExfY2FjaGVmbHVz
aDoKICAgICB7CiAgICAgICAgIGdmbl90IHMgPSBfZ2ZuKGRvbWN0bC0+dS5j
YWNoZWZsdXNoLnN0YXJ0X3Bmbik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409-4.16/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Disposition: attachment;
 filename="xsa409-4.16/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Transfer-Encoding: base64

RnJvbSAzOTY2NGQ5ZWUwNDFmOTZlOWM3ZWUxMzFlZDhlZjcyYTRkMTljOWY4
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzozMCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSB4ZW4vYXJtOiBBbGxv
Y2F0ZSBhbmQgZnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgUDJNIHBvb2wKClRo
aXMgY29tbWl0IHNldHMvdGVhcnNkb3duIG9mIHAybSBwYWdlcyBwb29sIGZv
ciBub24tcHJpdmlsZWdlZCBBcm0KZ3Vlc3RzIGJ5IGNhbGxpbmcgYHAybV9z
ZXRfYWxsb2NhdGlvbmAgYW5kIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAu
CgotIEZvciBkb20wLCBQMk0gcGFnZXMgc2hvdWxkIGNvbWUgZnJvbSBoZWFw
IGRpcmVjdGx5IGluc3RlYWQgb2YgcDJtCnBvb2wsIHNvIHRoYXQgdGhlIGtl
cm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGV4dGVuZGVkIHJlZ2lv
bnMuCgotIEZvciB4bCBndWVzdHMsIHRoZSBzZXR0aW5nIG9mIHRoZSBwMm0g
cG9vbCBpcyBjYWxsZWQgaW4KYFhFTl9ET01DVExfc2hhZG93X29wYCBhbmQg
dGhlIHAybSBwb29sIGlzIGRlc3Ryb3llZCBpbgpgZG9tYWluX3JlbGlucXVp
c2hfcmVzb3VyY2VzYC4gTm90ZSB0aGF0IGRvbWN0bC0+dS5zaGFkb3dfb3Au
bWIgaXMKdXBkYXRlZCB3aXRoIHRoZSBuZXcgc2l6ZSB3aGVuIHNldHRpbmcg
dGhlIHAybSBwb29sLgoKLSBGb3IgZG9tMGxlc3MgZG9tVXMsIHRoZSBzZXR0
aW5nIG9mIHRoZSBwMm0gcG9vbCBpcyBjYWxsZWQgYmVmb3JlCmFsbG9jYXRp
bmcgbWVtb3J5IGR1cmluZyBkb21haW4gY3JlYXRpb24uIFVzZXJzIGNhbiBz
cGVjaWZ5IHRoZSBwMm0KcG9vbCBzaXplIGJ5IGB4ZW4sZG9tYWluLXAybS1t
ZW0tbWJgIGR0cyBwcm9wZXJ0eS4KClRvIGFjdHVhbGx5IGFsbG9jYXRlL2Zy
ZWUgcGFnZXMgZnJvbSB0aGUgcDJtIHBvb2wsIHRoaXMgY29tbWl0IGFkZHMK
dHdvIGhlbHBlciBmdW5jdGlvbnMgbmFtZWx5IGBwMm1fYWxsb2NfcGFnZWAg
YW5kIGBwMm1fZnJlZV9wYWdlYCB0bwpgc3RydWN0IHAybV9kb21haW5gLiBC
eSByZXBsYWNpbmcgdGhlIGBhbGxvY19kb21oZWFwX3BhZ2VgIGFuZApgZnJl
ZV9kb21oZWFwX3BhZ2VgIHdpdGggdGhlc2UgdHdvIGhlbHBlciBmdW5jdGlv
bnMsIHAybSBwYWdlcyBjYW4KYmUgYWRkZWQvcmVtb3ZlZCBmcm9tIHRoZSBs
aXN0IG9mIHAybSBwb29sIHJhdGhlciB0aGFuIGZyb20gdGhlIGhlYXAuCgpT
aW5jZSBwYWdlIGZyb20gYHAybV9hbGxvY19wYWdlYCBpcyBjbGVhbmVkLCB0
YWtlIHRoZSBvcHBvcnR1bml0eQp0byByZW1vdmUgdGhlIHJlZHVuZGFudCBg
Y2xlYW5fcGFnZWAgaW4gYHAybV9jcmVhdGVfdGFibGVgLgoKVGhpcyBpcyBw
YXJ0IG9mIENWRS0yMDIyLTMzNzQ3IC8gWFNBLTQwOS4KClNpZ25lZC1vZmYt
Ynk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQt
Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y
Zz4KLS0tCiBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0
IHwgIDggKysrKwogeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAg
ICAgICB8ICA2ICsrKwogeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAg
ICAgICAgICB8IDI5ICsrKysrKysrKysrKysrCiB4ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMgICAgICAgICAgICAgICAgIHwgMjMgKysrKysrKysrKy0KIHhlbi9h
cmNoL2FybS9wMm0uYyAgICAgICAgICAgICAgICAgICAgfCA1NyArKysrKysr
KysrKysrKysrKysrKysrKysrLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTE4IGlu
c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9j
cy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCBiL2RvY3MvbWlz
Yy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKaW5kZXggNzE4OTU2NjNh
NGRlLi5kOTJjY2M1NmZmZTAgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlzYy9hcm0v
ZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKKysrIGIvZG9jcy9taXNjL2FybS9k
ZXZpY2UtdHJlZS9ib290aW5nLnR4dApAQCAtMTgyLDYgKzE4MiwxNCBAQCB3
aXRoIHRoZSBmb2xsb3dpbmcgcHJvcGVydGllczoKICAgICBCb3RoICNhZGRy
ZXNzLWNlbGxzIGFuZCAjc2l6ZS1jZWxscyBuZWVkIHRvIGJlIHNwZWNpZmll
ZCBiZWNhdXNlCiAgICAgYm90aCBzdWItbm9kZXMgKGRlc2NyaWJlZCBzaG9y
dGx5KSBoYXZlIHJlZyBwcm9wZXJ0aWVzLgogCistIHhlbixkb21haW4tcDJt
LW1lbS1tYgorCisgICAgT3B0aW9uYWwuIEEgMzItYml0IGludGVnZXIgc3Bl
Y2lmeWluZyB0aGUgYW1vdW50IG9mIG1lZ2FieXRlcyBvZiBSQU0KKyAgICB1
c2VkIGZvciB0aGUgZG9tYWluIFAyTSBwb29sLiBUaGlzIGlzIGluLXN5bmMg
d2l0aCB0aGUgc2hhZG93X21lbW9yeQorICAgIG9wdGlvbiBpbiB4bC5jZmcu
IExlYXZpbmcgdGhpcyBmaWVsZCBlbXB0eSBpbiBkZXZpY2UgdHJlZSB3aWxs
IGxlYWQgdG8KKyAgICB0aGUgZGVmYXVsdCBzaXplIG9mIGRvbWFpbiBQMk0g
cG9vbCwgaS5lLiAxTUIgcGVyIGd1ZXN0IHZDUFUgcGx1cyA0S0IKKyAgICBw
ZXIgTUIgb2YgZ3Vlc3QgUkFNIHBsdXMgNTEyS0IgZm9yIGd1ZXN0IGV4dGVu
ZGVkIHJlZ2lvbnMuCisKIFVuZGVyIHRoZSAieGVuLGRvbWFpbiIgY29tcGF0
aWJsZSBub2RlLCBvbmUgb3IgbW9yZSBzdWItbm9kZXMgYXJlIHByZXNlbnQK
IGZvciB0aGUgRG9tVSBrZXJuZWwgYW5kIHJhbWRpc2suCiAKZGlmZiAtLWdp
dCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9kb21h
aW4uYwppbmRleCAyNjk0YzM5MTI3YzUuLmE4MThmMzNhMWFmYSAxMDA2NDQK
LS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jCisrKyBiL3hlbi9hcmNoL2Fy
bS9kb21haW4uYwpAQCAtOTk3LDYgKzk5Nyw3IEBAIGVudW0gewogICAgIFBS
T0dfcGFnZSwKICAgICBQUk9HX21hcHBpbmcsCiAgICAgUFJPR19wMm0sCisg
ICAgUFJPR19wMm1fcG9vbCwKICAgICBQUk9HX2RvbmUsCiB9OwogCkBAIC0x
MDYyLDYgKzEwNjMsMTEgQEAgaW50IGRvbWFpbl9yZWxpbnF1aXNoX3Jlc291
cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQogICAgICAgICBpZiAoIHJldCApCiAg
ICAgICAgICAgICByZXR1cm4gcmV0OwogCisgICAgUFJPR1JFU1MocDJtX3Bv
b2wpOgorICAgICAgICByZXQgPSBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbihk
KTsKKyAgICAgICAgaWYoIHJldCApCisgICAgICAgICAgICByZXR1cm4gcmV0
OworCiAgICAgUFJPR1JFU1MoZG9uZSk6CiAgICAgICAgIGJyZWFrOwogCmRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94ZW4v
YXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKaW5kZXggZDAyYmFjYmNkMWVkLi44
YWVjMzc1NWNhNWQgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5f
YnVpbGQuYworKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKQEAg
LTI4MzMsNiArMjgzMywyMSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZmluZF9n
bnR0YWJfcmVnaW9uKHN0cnVjdCBkb21haW4gKmQsCiAgICAgICAgICAgIGtp
bmZvLT5nbnR0YWJfc3RhcnQsIGtpbmZvLT5nbnR0YWJfc3RhcnQgKyBraW5m
by0+Z250dGFiX3NpemUpOwogfQogCitzdGF0aWMgdW5zaWduZWQgbG9uZyBf
X2luaXQgZG9tYWluX3AybV9wYWdlcyh1bnNpZ25lZCBsb25nIG1heG1lbV9r
YiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHVuc2lnbmVkIGludCBzbXBfY3B1cykKK3sKKyAgICAvKgorICAgICAq
IEtlZXAgaW4gc3luYyB3aXRoIGxpYnhsX19nZXRfcmVxdWlyZWRfcGFnaW5n
X21lbW9yeSgpLgorICAgICAqIDI1NiBwYWdlcyAoMU1CKSBwZXIgdmNwdSwg
cGx1cyAxIHBhZ2UgcGVyIE1pQiBvZiBSQU0gZm9yIHRoZSBQMk0gbWFwLAor
ICAgICAqIHBsdXMgMTI4IHBhZ2VzIHRvIGNvdmVyIGV4dGVuZGVkIHJlZ2lv
bnMuCisgICAgICovCisgICAgdW5zaWduZWQgbG9uZyBtZW1rYiA9IDQgKiAo
MjU2ICogc21wX2NwdXMgKyAobWF4bWVtX2tiIC8gMTAyNCkgKyAxMjgpOwor
CisgICAgQlVJTERfQlVHX09OKFBBR0VfU0laRSAhPSBTWl80Syk7CisKKyAg
ICByZXR1cm4gRElWX1JPVU5EX1VQKG1lbWtiLCAxMDI0KSA8PCAoMjAgLSBQ
QUdFX1NISUZUKTsKK30KKwogc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0
X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8g
KmtpbmZvKQogewogICAgIHVuc2lnbmVkIGludCBpOwpAQCAtMjkyNCw2ICsy
OTM5LDggQEAgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3Ry
dWN0IGRvbWFpbiAqZCwKICAgICBzdHJ1Y3Qga2VybmVsX2luZm8ga2luZm8g
PSB7fTsKICAgICBpbnQgcmM7CiAgICAgdTY0IG1lbTsKKyAgICB1MzIgcDJt
X21lbV9tYjsKKyAgICB1bnNpZ25lZCBsb25nIHAybV9wYWdlczsKIAogICAg
IHJjID0gZHRfcHJvcGVydHlfcmVhZF91NjQobm9kZSwgIm1lbW9yeSIsICZt
ZW0pOwogICAgIGlmICggIXJjICkKQEAgLTI5MzMsNiArMjk1MCwxOCBAQCBz
dGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWlu
ICpkLAogICAgIH0KICAgICBraW5mby51bmFzc2lnbmVkX21lbSA9IChwYWRk
cl90KW1lbSAqIFNaXzFLOwogCisgICAgcmMgPSBkdF9wcm9wZXJ0eV9yZWFk
X3UzMihub2RlLCAieGVuLGRvbWFpbi1wMm0tbWVtLW1iIiwgJnAybV9tZW1f
bWIpOworICAgIC8qIElmIHhlbixkb21haW4tcDJtLW1lbS1tYiBpcyBub3Qg
c3BlY2lmaWVkLCB1c2UgdGhlIGRlZmF1bHQgdmFsdWUuICovCisgICAgcDJt
X3BhZ2VzID0gcmMgPworICAgICAgICAgICAgICAgIHAybV9tZW1fbWIgPDwg
KDIwIC0gUEFHRV9TSElGVCkgOgorICAgICAgICAgICAgICAgIGRvbWFpbl9w
Mm1fcGFnZXMobWVtLCBkLT5tYXhfdmNwdXMpOworCisgICAgc3Bpbl9sb2Nr
KCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICByYyA9IHAybV9zZXRfYWxs
b2NhdGlvbihkLCBwMm1fcGFnZXMsIE5VTEwpOworICAgIHNwaW5fdW5sb2Nr
KCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICBpZiAoIHJjICE9IDAgKQor
ICAgICAgICByZXR1cm4gcmM7CisKICAgICBwcmludGsoIioqKiBMT0FESU5H
IERPTVUgY3B1cz0ldSBtZW1vcnk9JSJQUkl4NjQiS0IgKioqXG4iLCBkLT5t
YXhfdmNwdXMsIG1lbSk7CiAKICAgICBraW5mby52cGwwMTEgPSBkdF9wcm9w
ZXJ0eV9yZWFkX2Jvb2wobm9kZSwgInZwbDAxMSIpOwpkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gvYXJtL2RvbWN0bC5jIGIveGVuL2FyY2gvYXJtL2RvbWN0bC5j
CmluZGV4IDliZjcyZTY5MzAxOS4uYzhmZGViMTI0MDg0IDEwMDY0NAotLS0g
YS94ZW4vYXJjaC9hcm0vZG9tY3RsLmMKKysrIGIveGVuL2FyY2gvYXJtL2Rv
bWN0bC5jCkBAIC01MCw2ICs1MCw5IEBAIHN0YXRpYyBpbnQgaGFuZGxlX3Z1
YXJ0X2luaXQoc3RydWN0IGRvbWFpbiAqZCwKIHN0YXRpYyBsb25nIHAybV9k
b21jdGwoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHhlbl9kb21jdGxfc2hh
ZG93X29wICpzYywKICAgICAgICAgICAgICAgICAgICAgICAgWEVOX0dVRVNU
X0hBTkRMRV9QQVJBTSh4ZW5fZG9tY3RsX3QpIHVfZG9tY3RsKQogeworICAg
IGxvbmcgcmM7CisgICAgYm9vbCBwcmVlbXB0ZWQgPSBmYWxzZTsKKwogICAg
IGlmICggdW5saWtlbHkoZCA9PSBjdXJyZW50LT5kb21haW4pICkKICAgICB7
CiAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJUcmllZCB0byBkbyBhIHAy
bSBkb21jdGwgb3Agb24gaXRzZWxmLlxuIik7CkBAIC02Niw5ICs2OSwyNyBA
QCBzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQsIHN0
cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCiAgICAgc3dpdGNoICgg
c2MtPm9wICkKICAgICB7CiAgICAgY2FzZSBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTjoKLSAgICAgICAgcmV0dXJuIDA7CisgICAgewor
ICAgICAgICAvKiBBbGxvdyBhbmQgaGFuZGxlIHByZWVtcHRpb24gKi8KKyAg
ICAgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICAg
ICAgcmMgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgc2MtPm1iIDw8ICgyMCAt
IFBBR0VfU0hJRlQpLCAmcHJlZW1wdGVkKTsKKyAgICAgICAgc3Bpbl91bmxv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworCisgICAgICAgIGlmICggcHJl
ZW1wdGVkICkKKyAgICAgICAgICAgIC8qIE5vdCBmaW5pc2hlZC4gU2V0IHVw
IHRvIHJlLXJ1biB0aGUgY2FsbC4gKi8KKyAgICAgICAgICAgIHJjID0gaHlw
ZXJjYWxsX2NyZWF0ZV9jb250aW51YXRpb24oX19IWVBFUlZJU09SX2RvbWN0
bCwgImgiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB1X2RvbWN0bCk7CisgICAgICAgIGVsc2UKKyAgICAgICAg
ICAgIC8qIEZpbmlzaGVkLiBSZXR1cm4gdGhlIG5ldyBhbGxvY2F0aW9uLiAq
LworICAgICAgICAgICAgc2MtPm1iID0gcDJtX2dldF9hbGxvY2F0aW9uKGQp
OworCisgICAgICAgIHJldHVybiByYzsKKyAgICB9CiAgICAgY2FzZSBYRU5f
RE9NQ1RMX1NIQURPV19PUF9HRVRfQUxMT0NBVElPTjoKKyAgICB7CisgICAg
ICAgIHNjLT5tYiA9IHAybV9nZXRfYWxsb2NhdGlvbihkKTsKICAgICAgICAg
cmV0dXJuIDA7CisgICAgfQogICAgIGRlZmF1bHQ6CiAgICAgewogICAgICAg
ICBwcmludGsoWEVOTE9HX0VSUiAiQmFkIHAybSBkb21jdGwgb3AgJXVcbiIs
IHNjLT5vcCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94
ZW4vYXJjaC9hcm0vcDJtLmMKaW5kZXggNzlmM2QzN2Y1MjMwLi4xYmY5Y2Jl
YjUzY2YgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYworKysgYi94
ZW4vYXJjaC9hcm0vcDJtLmMKQEAgLTUwLDYgKzUwLDU0IEBAIHN0YXRpYyB1
aW50NjRfdCBnZW5lcmF0ZV92dHRicih1aW50MTZfdCB2bWlkLCBtZm5fdCBy
b290X21mbikKICAgICByZXR1cm4gKG1mbl90b19tYWRkcihyb290X21mbikg
fCAoKHVpbnQ2NF90KXZtaWQgPDwgNDgpKTsKIH0KIAorc3RhdGljIHN0cnVj
dCBwYWdlX2luZm8gKnAybV9hbGxvY19wYWdlKHN0cnVjdCBkb21haW4gKmQp
Cit7CisgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7CisKKyAgICBzcGluX2xv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgIC8qCisgICAgICogRm9y
IGhhcmR3YXJlIGRvbWFpbiwgdGhlcmUgc2hvdWxkIGJlIG5vIGxpbWl0IGlu
IHRoZSBudW1iZXIgb2YgcGFnZXMgdGhhdAorICAgICAqIGNhbiBiZSBhbGxv
Y2F0ZWQsIHNvIHRoYXQgdGhlIGtlcm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ug
b2YgdGhlIGV4dGVuZGVkCisgICAgICogcmVnaW9ucy4gSGVuY2UsIGFsbG9j
YXRlIHAybSBwYWdlcyBmb3IgaGFyZHdhcmUgZG9tYWlucyBmcm9tIGhlYXAu
CisgICAgICovCisgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQor
ICAgIHsKKyAgICAgICAgcGcgPSBhbGxvY19kb21oZWFwX3BhZ2UoTlVMTCwg
MCk7CisgICAgICAgIGlmICggcGcgPT0gTlVMTCApCisgICAgICAgIHsKKyAg
ICAgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlIgIkZhaWxlZCB0byBhbGxv
Y2F0ZSBQMk0gcGFnZXMgZm9yIGh3ZG9tLlxuIik7CisgICAgICAgICAgICBz
cGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisgICAgICAgICAg
ICByZXR1cm4gTlVMTDsKKyAgICAgICAgfQorICAgIH0KKyAgICBlbHNlCisg
ICAgeworICAgICAgICBwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgmZC0+
YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgaWYgKCB1bmxp
a2VseSghcGcpICkKKyAgICAgICAgeworICAgICAgICAgICAgc3Bpbl91bmxv
Y2soJmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgICAgICAgICAgcmV0dXJu
IE5VTEw7CisgICAgICAgIH0KKyAgICAgICAgZC0+YXJjaC5wYWdpbmcucDJt
X3RvdGFsX3BhZ2VzLS07CisgICAgfQorICAgIHNwaW5fdW5sb2NrKCZkLT5h
cmNoLnBhZ2luZy5sb2NrKTsKKworICAgIHJldHVybiBwZzsKK30KKworc3Rh
dGljIHZvaWQgcDJtX2ZyZWVfcGFnZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1
Y3QgcGFnZV9pbmZvICpwZykKK3sKKyAgICBzcGluX2xvY2soJmQtPmFyY2gu
cGFnaW5nLmxvY2spOworICAgIGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQp
ICkKKyAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOworICAgIGVsc2UK
KyAgICB7CisgICAgICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdl
cysrOworICAgICAgICBwYWdlX2xpc3RfYWRkX3RhaWwocGcsICZkLT5hcmNo
LnBhZ2luZy5wMm1fZnJlZWxpc3QpOworICAgIH0KKyAgICBzcGluX3VubG9j
aygmZC0+YXJjaC5wYWdpbmcubG9jayk7Cit9CisKIC8qIFJldHVybiB0aGUg
c2l6ZSBvZiB0aGUgcG9vbCwgcm91bmRlZCB1cCB0byB0aGUgbmVhcmVzdCBN
QiAqLwogdW5zaWduZWQgaW50IHAybV9nZXRfYWxsb2NhdGlvbihzdHJ1Y3Qg
ZG9tYWluICpkKQogewpAQCAtNzUxLDcgKzc5OSw3IEBAIHN0YXRpYyBpbnQg
cDJtX2NyZWF0ZV90YWJsZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBscGFl
X3QgKmVudHJ5KQogCiAgICAgQVNTRVJUKCFwMm1faXNfdmFsaWQoKmVudHJ5
KSk7CiAKLSAgICBwYWdlID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDAp
OworICAgIHBhZ2UgPSBwMm1fYWxsb2NfcGFnZShwMm0tPmRvbWFpbik7CiAg
ICAgaWYgKCBwYWdlID09IE5VTEwgKQogICAgICAgICByZXR1cm4gLUVOT01F
TTsKIApAQCAtODc4LDcgKzkyNiw3IEBAIHN0YXRpYyB2b2lkIHAybV9mcmVl
X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgcGcgPSBtZm5f
dG9fcGFnZShtZm4pOwogCiAgICAgcGFnZV9saXN0X2RlbChwZywgJnAybS0+
cGFnZXMpOwotICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsKKyAgICBwMm1f
ZnJlZV9wYWdlKHAybS0+ZG9tYWluLCBwZyk7CiB9CiAKIHN0YXRpYyBib29s
IHAybV9zcGxpdF9zdXBlcnBhZ2Uoc3RydWN0IHAybV9kb21haW4gKnAybSwg
bHBhZV90ICplbnRyeSwKQEAgLTkwMiw3ICs5NTAsNyBAQCBzdGF0aWMgYm9v
bCBwMm1fc3BsaXRfc3VwZXJwYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0s
IGxwYWVfdCAqZW50cnksCiAgICAgQVNTRVJUKGxldmVsIDwgdGFyZ2V0KTsK
ICAgICBBU1NFUlQocDJtX2lzX3N1cGVycGFnZSgqZW50cnksIGxldmVsKSk7
CiAKLSAgICBwYWdlID0gYWxsb2NfZG9taGVhcF9wYWdlKE5VTEwsIDApOwor
ICAgIHBhZ2UgPSBwMm1fYWxsb2NfcGFnZShwMm0tPmRvbWFpbik7CiAgICAg
aWYgKCAhcGFnZSApCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApAQCAtMTY0
MSw3ICsxNjg5LDcgQEAgaW50IHAybV90ZWFyZG93bihzdHJ1Y3QgZG9tYWlu
ICpkKQogCiAgICAgd2hpbGUgKCAocGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hl
YWQoJnAybS0+cGFnZXMpKSApCiAgICAgewotICAgICAgICBmcmVlX2RvbWhl
YXBfcGFnZShwZyk7CisgICAgICAgIHAybV9mcmVlX3BhZ2UocDJtLT5kb21h
aW4sIHBnKTsKICAgICAgICAgY291bnQrKzsKICAgICAgICAgLyogQXJiaXRy
YXJpbHkgcHJlZW1wdCBldmVyeSA1MTIgaXRlcmF0aW9ucyAqLwogICAgICAg
ICBpZiAoICEoY291bnQgJSA1MTIpICYmIGh5cGVyY2FsbF9wcmVlbXB0X2No
ZWNrKCkgKQpAQCAtMTY2NSw2ICsxNzEzLDcgQEAgdm9pZCBwMm1fZmluYWxf
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAgcmV0dXJuOwog
CiAgICAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOwor
ICAgIEFTU0VSVChwYWdlX2xpc3RfZW1wdHkoJmQtPmFyY2gucGFnaW5nLnAy
bV9mcmVlbGlzdCkpOwogCiAgICAgaWYgKCBwMm0tPnJvb3QgKQogICAgICAg
ICBmcmVlX2RvbWhlYXBfcGFnZXMocDJtLT5yb290LCBQMk1fUk9PVF9PUkRF
Uik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409/0001-libxl-docs-Add-per-arch-extra-default-paging-memory.patch"
Content-Disposition: attachment;
 filename="xsa409/0001-libxl-docs-Add-per-arch-extra-default-paging-memory.patch"
Content-Transfer-Encoding: base64

RnJvbSBkMGYzZjMyOWViM2I2NTJhY2MzNTQyNjVjYTRkNDA0MjgwNzcyNGI1
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyNyArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMS80XSBsaWJ4bCwgZG9jczog
QWRkIHBlci1hcmNoIGV4dHJhIGRlZmF1bHQgcGFnaW5nIG1lbW9yeQoKVGhp
cyBjb21taXQgYWRkcyBhIHBlci1hcmNoIG1hY3JvIGBFWFRSQV9ERUZBVUxU
X1BBR0lOR19NRU1fTUJgCnRvIHRoZSBkZWZhdWx0IHBhZ2luZyBtZW1vcnkg
c2l6ZSwgaW4gb3JkZXIgdG8gY292ZXIgdGhlIHAybQpwb29sIGZvciBleHRl
bmRlZCByZWdpb25zIG9mIGEgeGwtYmFzZWQgZ3Vlc3Qgb24gQXJtLgoKRm9y
IEFybSwgdGhlIGV4dHJhIGRlZmF1bHQgcGFnaW5nIG1lbW9yeSBpcyAxMjhN
Qi4KRm9yIHg4NiwgdGhlIGV4dHJhIGRlZmF1bHQgcGFnaW5nIG1lbW9yeSBp
cyB6ZXJvLCBzaW5jZSB0aGVyZQphcmUgbm8gZXh0ZW5kZWQgcmVnaW9ucyBv
biB4ODYuCgpBbHNvIHVwZGF0ZSB0aGUgeGwuY2ZnIGRvY3VtZW50YXRpb24g
dG8gYWRkIEFybSBkb2N1bWVudGF0aW9uCmFjY29yZGluZyB0byBjb2RlIGNo
YW5nZXMuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0Et
NDA5LgoKU2lnbmVkLW9mZi1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh
cm0uY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h
em9uLmNvbT4KLS0tCiBkb2NzL21hbi94bC5jZmcuNS5wb2QuaW4gICAgICAg
IHwgIDUgKysrKysKIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJjaC5oICAg
fCAxMSArKysrKysrKysrKwogdG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVh
dGUuYyB8ICA3ICsrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0
aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvY3MvbWFu
L3hsLmNmZy41LnBvZC5pbiBiL2RvY3MvbWFuL3hsLmNmZy41LnBvZC5pbgpp
bmRleCA2ZDk4ZDczZDc2YzAuLjcwZGUxMDMzNTUwZiAxMDA2NDQKLS0tIGEv
ZG9jcy9tYW4veGwuY2ZnLjUucG9kLmluCisrKyBiL2RvY3MvbWFuL3hsLmNm
Zy41LnBvZC5pbgpAQCAtMjcyNSw2ICsyNzI1LDExIEBAIGFyZSBub3QgdXNp
bmcgaGFyZHdhcmUgYXNzaXN0ZWQgcGFnaW5nIChpLmUuIHlvdSBhcmUgdXNp
bmcgc2hhZG93CiBtb2RlKSBhbmQgeW91ciBndWVzdCB3b3JrbG9hZCBjb25z
aXN0cyBvZiBhIHZlcnkgbGFyZ2UgbnVtYmVyIG9mCiBzaW1pbGFyIHByb2Nl
c3NlcyB0aGVuIGluY3JlYXNpbmcgdGhpcyB2YWx1ZSBtYXkgaW1wcm92ZSBw
ZXJmb3JtYW5jZS4KIAorT24gQXJtLCB0aGlzIGZpZWxkIGlzIHVzZWQgdG8g
ZGV0ZXJtaW5lIHRoZSBzaXplIG9mIHRoZSBndWVzdCBQMk0gcGFnZXMKK3Bv
b2wsIGFuZCB0aGUgZGVmYXVsdCB2YWx1ZSBpcyB0aGUgc2FtZSBhcyB4ODYg
SEFQIG1vZGUsIHBsdXMgNTEyS0IgdG8KK2NvdmVyIHRoZSBleHRlbmRlZCBy
ZWdpb25zLiBVc2VycyBzaG91bGQgYWRqdXN0IHRoaXMgdmFsdWUgaWYgYmln
Z2VyCitQMk0gcG9vbCBzaXplIGlzIG5lZWRlZC4KKwogPWJhY2sKIAogPWhl
YWQyIERldmljZS1Nb2RlbCBPcHRpb25zCmRpZmYgLS1naXQgYS90b29scy9s
aWJzL2xpZ2h0L2xpYnhsX2FyY2guaCBiL3Rvb2xzL2xpYnMvbGlnaHQvbGli
eGxfYXJjaC5oCmluZGV4IDAzYjg5OTI5ZTY4Yy4uMjQ3Y2NhMTMwZmMzIDEw
MDY0NAotLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FyY2guaAorKysg
Yi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FyY2guaApAQCAtOTksMTAgKzk5
LDIxIEBAIHZvaWQgbGlieGxfX2FyY2hfdXBkYXRlX2RvbWFpbl9jb25maWco
bGlieGxfX2djICpnYywKIAogI2RlZmluZSBMQVBJQ19CQVNFX0FERFJFU1Mg
IDB4ZmVlMDAwMDAKICNkZWZpbmUgQUNQSV9JTkZPX1BIWVNJQ0FMX0FERFJF
U1MgMHhmYzAwMDAwMAorI2RlZmluZSBFWFRSQV9ERUZBVUxUX1BBR0lOR19N
RU1fTUIgMAogCiBpbnQgbGlieGxfX2RvbV9sb2FkX2FjcGkobGlieGxfX2dj
ICpnYywKICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBsaWJ4bF9k
b21haW5fYnVpbGRfaW5mbyAqYl9pbmZvLAogICAgICAgICAgICAgICAgICAg
ICAgICAgIHN0cnVjdCB4Y19kb21faW1hZ2UgKmRvbSk7CisKKyNlbHNlCisK
Ky8qCisgKiAxMjhNQiBleHRyYSBkZWZhdWx0IHBhZ2luZyBtZW1vcnkgb24g
QXJtIGZvciBleHRlbmRlZCByZWdpb25zLiBUaGlzCisgKiB2YWx1ZSBpcyBu
b3JtYWxseSBlbm91Z2ggZm9yIGRvbWFpbnMgdGhhdCBhcmUgbm90IHJ1bm5p
bmcgYmFja2VuZC4KKyAqIFNlZSB0aGUgYHNoYWRvd19tZW1vcnlgIGluIHhs
LmNmZyBkb2N1bWVudGF0aW9uIGZvciBtb3JlIGluZm9ybWF0aW9uLgorICov
CisjZGVmaW5lIEVYVFJBX0RFRkFVTFRfUEFHSU5HX01FTV9NQiAxMjgKKwog
I2VuZGlmCiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdo
dC9saWJ4bF9jcmVhdGUuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3Jl
YXRlLmMKaW5kZXggYjlkZDJkZWVkZjEzLi42MTJlYWNmYzdmYWMgMTAwNjQ0
Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3JlYXRlLmMKKysrIGIv
dG9vbHMvbGlicy9saWdodC9saWJ4bF9jcmVhdGUuYwpAQCAtMTAzNSwxMiAr
MTAzNSwxNyBAQCB1bnNpZ25lZCBsb25nIGxpYnhsX19nZXRfcmVxdWlyZWRf
cGFnaW5nX21lbW9yeSh1bnNpZ25lZCBsb25nIG1heG1lbV9rYiwKICAgICAg
KiBwbHVzIDEgcGFnZSBwZXIgTWlCIG9mIFJBTSBmb3IgdGhlIFAyTSBtYXAg
KGZvciBub24tUFYgZ3Vlc3RzKSwKICAgICAgKiBwbHVzIDEgcGFnZSBwZXIg
TWlCIG9mIFJBTSB0byBzaGFkb3cgdGhlIHJlc2lkZW50IHByb2Nlc3NlcyAo
Zm9yIHNoYWRvdwogICAgICAqIG1vZGUgZ3Vlc3RzKS4KKyAgICAgKiBwbHVz
IDEgcGFnZSBwZXIgTWlCIG9mIFJBTSBmb3IgdGhlIGFyY2hpdGVjdHVyZSBz
cGVjaWZpYworICAgICAqIEVYVFJBX0RFRkFVTFRfUEFHSU5HX01FTV9NQi4g
T24geDg2LCB0aGlzIHZhbHVlIGlzIHplcm8uIE9uIEFybSwgdGhpcworICAg
ICAqIHZhbHVlIGlzIDEyOCBNaUIgdG8gY292ZXIgZG9tYWluIGV4dGVuZGVk
IHJlZ2lvbnMgKGVub3VnaCBmb3IgZG9tYWlucworICAgICAqIHRoYXQgYXJl
IG5vdCBydW5uaW5nIGJhY2tlbmQpLgogICAgICAqIFRoaXMgaXMgaGlnaGVy
IHRoYW4gdGhlIG1pbmltdW0gdGhhdCBYZW4gd291bGQgYWxsb2NhdGUgaWYg
bm8gdmFsdWUKICAgICAgKiB3ZXJlIGdpdmVuIChidXQgdGhlIFhlbiBtaW5p
bXVtIGlzIGZvciBzYWZldHksIG5vdCBwZXJmb3JtYW5jZSkuCiAgICAgICov
CiAgICAgcmV0dXJuIDQgKiAoMjU2ICogc21wX2NwdXMgKwogICAgICAgICAg
ICAgICAgICgodHlwZSAhPSBMSUJYTF9ET01BSU5fVFlQRV9QVikgKyAhaGFw
KSAqCi0gICAgICAgICAgICAgICAgKG1heG1lbV9rYiAvIDEwMjQpKTsKKyAg
ICAgICAgICAgICAgICAobWF4bWVtX2tiIC8gMTAyNCkgKworICAgICAgICAg
ICAgICAgIEVYVFJBX0RFRkFVTFRfUEFHSU5HX01FTV9NQik7CiB9CiAKIHN0
YXRpYyB1bnNpZ25lZCBsb25nIGxpYnhsX19nZXRfcmVxdWlyZWRfaW9tbXVf
bWVtb3J5KHVuc2lnbmVkIGxvbmcgbWF4bWVtX2tiKQotLSAKMi4zNy4xCgo=

--=separator
Content-Type: application/octet-stream;
 name="xsa409/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Disposition: attachment;
 filename="xsa409/0002-xen-arm-Construct-the-P2M-pages-pool-for-guests.patch"
Content-Transfer-Encoding: base64

RnJvbSAwNDMxNDhhODc3ZmRhM2RjOGQyY2JkYzAyOTE3YjAyYzgzZWVhNzI3
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMi80XSB4ZW4vYXJtOiBDb25z
dHJ1Y3QgdGhlIFAyTSBwYWdlcyBwb29sIGZvciBndWVzdHMKClRoaXMgY29t
bWl0IGNvbnN0cnVjdHMgdGhlIHAybSBwYWdlcyBwb29sIGZvciBndWVzdHMg
ZnJvbSB0aGUKZGF0YSBzdHJ1Y3R1cmUgYW5kIGhlbHBlciBwZXJzcGVjdGl2
ZS4KClRoaXMgaXMgaW1wbGVtZW50ZWQgYnk6CgotIEFkZGluZyBhIGBzdHJ1
Y3QgcGFnaW5nX2RvbWFpbmAgd2hpY2ggY29udGFpbnMgYSBmcmVlbGlzdCwg
YQpjb3VudGVyIHZhcmlhYmxlIGFuZCBhIHNwaW5sb2NrIHRvIGBzdHJ1Y3Qg
YXJjaF9kb21haW5gIHRvCmluZGljYXRlIHRoZSBmcmVlIHAybSBwYWdlcyBh
bmQgdGhlIG51bWJlciBvZiBwMm0gdG90YWwgcGFnZXMgaW4KdGhlIHAybSBw
YWdlcyBwb29sLgoKLSBBZGRpbmcgYSBoZWxwZXIgYHAybV9nZXRfYWxsb2Nh
dGlvbmAgdG8gZ2V0IHRoZSBwMm0gcG9vbCBzaXplLgoKLSBBZGRpbmcgYSBo
ZWxwZXIgYHAybV9zZXRfYWxsb2NhdGlvbmAgdG8gc2V0IHRoZSBwMm0gcGFn
ZXMgcG9vbApzaXplLiBUaGlzIGhlbHBlciBzaG91bGQgYmUgY2FsbGVkIGJl
Zm9yZSBhbGxvY2F0aW5nIG1lbW9yeSBmb3IKYSBndWVzdC4KCi0gQWRkaW5n
IGEgaGVscGVyIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAgdG8gZnJlZSB0
aGUgcDJtIHBhZ2VzCnBvb2wuIFRoaXMgaGVscGVyIHNob3VsZCBiZSBjYWxs
ZWQgZHVyaW5nIHRoZSB4bCBkb21haW4gZGVzdG9yeS4KClRoaXMgaXMgcGFy
dCBvZiBDVkUtMjAyMi0zMzc0NyAvIFhTQS00MDkuCgpTaWduZWQtb2ZmLWJ5
OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+ClJldmlld2VkLWJ5
OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+
Ci0tLQogeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2RvbWFpbi5oIHwgMTAg
KysrKwogeGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3AybS5oICAgIHwgIDQg
KysKIHhlbi9hcmNoL2FybS9wMm0uYyAgICAgICAgICAgICAgICB8IDg4ICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdl
ZCwgMTAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9h
cm0vaW5jbHVkZS9hc20vZG9tYWluLmggYi94ZW4vYXJjaC9hcm0vaW5jbHVk
ZS9hc20vZG9tYWluLmgKaW5kZXggY2Q5Y2UxOWI0YjQxLi5kZjU2YzFkZGQ0
MjkgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9kb21h
aW4uaAorKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZG9tYWluLmgK
QEAgLTUzLDYgKzUzLDE0IEBAIHN0cnVjdCB2dGltZXIgewogICAgIHVpbnQ2
NF90IGN2YWw7CiB9OwogCitzdHJ1Y3QgcGFnaW5nX2RvbWFpbiB7CisgICAg
c3BpbmxvY2tfdCBsb2NrOworICAgIC8qIEZyZWUgUDJNIHBhZ2VzIGZyb20g
dGhlIHByZS1hbGxvY2F0ZWQgUDJNIHBvb2wgKi8KKyAgICBzdHJ1Y3QgcGFn
ZV9saXN0X2hlYWQgcDJtX2ZyZWVsaXN0OworICAgIC8qIE51bWJlciBvZiBw
YWdlcyBmcm9tIHRoZSBwcmUtYWxsb2NhdGVkIFAyTSBwb29sICovCisgICAg
dW5zaWduZWQgbG9uZyBwMm1fdG90YWxfcGFnZXM7Cit9OworCiBzdHJ1Y3Qg
YXJjaF9kb21haW4KIHsKICNpZmRlZiBDT05GSUdfQVJNXzY0CkBAIC02NCw2
ICs3Miw4IEBAIHN0cnVjdCBhcmNoX2RvbWFpbgogCiAgICAgc3RydWN0IGh2
bV9kb21haW4gaHZtOwogCisgICAgc3RydWN0IHBhZ2luZ19kb21haW4gcGFn
aW5nOworCiAgICAgc3RydWN0IHZtbWlvIHZtbWlvOwogCiAgICAgLyogQ29u
dGludWFibGUgZG9tYWluX3JlbGlucXVpc2hfcmVzb3VyY2VzKCkuICovCmRp
ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vcDJtLmggYi94
ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vcDJtLmgKaW5kZXggYTE1ZWE2N2Y5
YjQ4Li40MmJmZDU0OGM0OGIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9p
bmNsdWRlL2FzbS9wMm0uaAorKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9h
c20vcDJtLmgKQEAgLTIxOCw2ICsyMTgsMTAgQEAgdm9pZCBwMm1fcmVzdG9y
ZV9zdGF0ZShzdHJ1Y3QgdmNwdSAqbik7CiAvKiBQcmludCBkZWJ1Z2dpbmcv
c3RhdGlzdGlhbCBpbmZvIGFib3V0IGEgZG9tYWluJ3MgcDJtICovCiB2b2lk
IHAybV9kdW1wX2luZm8oc3RydWN0IGRvbWFpbiAqZCk7CiAKK3Vuc2lnbmVk
IGludCBwMm1fZ2V0X2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCk7Citp
bnQgcDJtX3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQsIHVuc2ln
bmVkIGxvbmcgcGFnZXMsIGJvb2wgKnByZWVtcHRlZCk7CitpbnQgcDJtX3Rl
YXJkb3duX2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCk7CisKIHN0YXRp
YyBpbmxpbmUgdm9pZCBwMm1fd3JpdGVfbG9jayhzdHJ1Y3QgcDJtX2RvbWFp
biAqcDJtKQogewogICAgIHdyaXRlX2xvY2soJnAybS0+bG9jayk7CmRpZmYg
LS1naXQgYS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0vcDJt
LmMKaW5kZXggYjQ0NWY0ZDc1NDFlLi5kYjM4NWZlNDEwMjMgMTAwNjQ0Ci0t
LSBhL3hlbi9hcmNoL2FybS9wMm0uYworKysgYi94ZW4vYXJjaC9hcm0vcDJt
LmMKQEAgLTQ0LDYgKzQ0LDkyIEBAIHN0YXRpYyB1aW50NjRfdCBnZW5lcmF0
ZV92dHRicih1aW50MTZfdCB2bWlkLCBtZm5fdCByb290X21mbikKICAgICBy
ZXR1cm4gKG1mbl90b19tYWRkcihyb290X21mbikgfCAoKHVpbnQ2NF90KXZt
aWQgPDwgNDgpKTsKIH0KIAorLyogUmV0dXJuIHRoZSBzaXplIG9mIHRoZSBw
b29sLCByb3VuZGVkIHVwIHRvIHRoZSBuZWFyZXN0IE1CICovCit1bnNpZ25l
ZCBpbnQgcDJtX2dldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQpCit7
CisgICAgdW5zaWduZWQgbG9uZyBucl9wYWdlcyA9IEFDQ0VTU19PTkNFKGQt
PmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdlcyk7CisKKyAgICByZXR1cm4g
Uk9VTkRVUChucl9wYWdlcywgMSA8PCAoMjAgLSBQQUdFX1NISUZUKSkgPj4g
KDIwIC0gUEFHRV9TSElGVCk7Cit9CisKKy8qCisgKiBTZXQgdGhlIHBvb2wg
b2YgcGFnZXMgdG8gdGhlIHJlcXVpcmVkIG51bWJlciBvZiBwYWdlcy4KKyAq
IFJldHVybnMgMCBmb3Igc3VjY2Vzcywgbm9uLXplcm8gZm9yIGZhaWx1cmUu
CisgKiBDYWxsIHdpdGggZC0+YXJjaC5wYWdpbmcubG9jayBoZWxkLgorICov
CitpbnQgcDJtX3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQsIHVu
c2lnbmVkIGxvbmcgcGFnZXMsIGJvb2wgKnByZWVtcHRlZCkKK3sKKyAgICBz
dHJ1Y3QgcGFnZV9pbmZvICpwZzsKKworICAgIEFTU0VSVChzcGluX2lzX2xv
Y2tlZCgmZC0+YXJjaC5wYWdpbmcubG9jaykpOworCisgICAgZm9yICggOyA7
ICkKKyAgICB7CisgICAgICAgIGlmICggZC0+YXJjaC5wYWdpbmcucDJtX3Rv
dGFsX3BhZ2VzIDwgcGFnZXMgKQorICAgICAgICB7CisgICAgICAgICAgICAv
KiBOZWVkIHRvIGFsbG9jYXRlIG1vcmUgbWVtb3J5IGZyb20gZG9taGVhcCAq
LworICAgICAgICAgICAgcGcgPSBhbGxvY19kb21oZWFwX3BhZ2UoTlVMTCwg
MCk7CisgICAgICAgICAgICBpZiAoIHBnID09IE5VTEwgKQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSICJGYWls
ZWQgdG8gYWxsb2NhdGUgUDJNIHBhZ2VzLlxuIik7CisgICAgICAgICAgICAg
ICAgcmV0dXJuIC1FTk9NRU07CisgICAgICAgICAgICB9CisgICAgICAgICAg
ICBBQ0NFU1NfT05DRShkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMp
ID0KKyAgICAgICAgICAgICAgICBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxf
cGFnZXMgKyAxOworICAgICAgICAgICAgcGFnZV9saXN0X2FkZF90YWlsKHBn
LCAmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsKKyAgICAgICAgfQor
ICAgICAgICBlbHNlIGlmICggZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3Bh
Z2VzID4gcGFnZXMgKQorICAgICAgICB7CisgICAgICAgICAgICAvKiBOZWVk
IHRvIHJldHVybiBtZW1vcnkgdG8gZG9taGVhcCAqLworICAgICAgICAgICAg
cGcgPSBwYWdlX2xpc3RfcmVtb3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLnAy
bV9mcmVlbGlzdCk7CisgICAgICAgICAgICBpZiggcGcgKQorICAgICAgICAg
ICAgeworICAgICAgICAgICAgICAgIEFDQ0VTU19PTkNFKGQtPmFyY2gucGFn
aW5nLnAybV90b3RhbF9wYWdlcykgPQorICAgICAgICAgICAgICAgICAgICBk
LT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgLSAxOworICAgICAgICAg
ICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsKKyAgICAgICAgICAgIH0K
KyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAg
ICAgICBwcmludGsoWEVOTE9HX0VSUgorICAgICAgICAgICAgICAgICAgICAg
ICAiRmFpbGVkIHRvIGZyZWUgUDJNIHBhZ2VzLCBQMk0gZnJlZWxpc3QgaXMg
ZW1wdHkuXG4iKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsK
KyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgICAgICBlbHNlCisgICAg
ICAgICAgICBicmVhazsKKworICAgICAgICAvKiBDaGVjayB0byBzZWUgaWYg
d2UgbmVlZCB0byB5aWVsZCBhbmQgdHJ5IGFnYWluICovCisgICAgICAgIGlm
ICggcHJlZW1wdGVkICYmIGdlbmVyYWxfcHJlZW1wdF9jaGVjaygpICkKKyAg
ICAgICAgeworICAgICAgICAgICAgKnByZWVtcHRlZCA9IHRydWU7CisgICAg
ICAgICAgICByZXR1cm4gLUVSRVNUQVJUOworICAgICAgICB9CisgICAgfQor
CisgICAgcmV0dXJuIDA7Cit9CisKK2ludCBwMm1fdGVhcmRvd25fYWxsb2Nh
dGlvbihzdHJ1Y3QgZG9tYWluICpkKQoreworICAgIGludCByZXQgPSAwOwor
ICAgIGJvb2wgcHJlZW1wdGVkID0gZmFsc2U7CisKKyAgICBzcGluX2xvY2so
JmQtPmFyY2gucGFnaW5nLmxvY2spOworICAgIGlmICggZC0+YXJjaC5wYWdp
bmcucDJtX3RvdGFsX3BhZ2VzICE9IDAgKQorICAgIHsKKyAgICAgICAgcmV0
ID0gcDJtX3NldF9hbGxvY2F0aW9uKGQsIDAsICZwcmVlbXB0ZWQpOworICAg
ICAgICBpZiAoIHByZWVtcHRlZCApCisgICAgICAgIHsKKyAgICAgICAgICAg
IHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICAgICAg
ICAgIHJldHVybiAtRVJFU1RBUlQ7CisgICAgICAgIH0KKyAgICAgICAgQVNT
RVJUKGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdlcyA9PSAwKTsKKyAg
ICB9CisgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5nLmxvY2spOwor
CisgICAgcmV0dXJuIHJldDsKK30KKwogLyogVW5sb2NrIHRoZSBmbHVzaCBh
bmQgZG8gYSBQMk0gVExCIGZsdXNoIGlmIG5lY2Vzc2FyeSAqLwogdm9pZCBw
Mm1fd3JpdGVfdW5sb2NrKHN0cnVjdCBwMm1fZG9tYWluICpwMm0pCiB7CkBA
IC0xNjIzLDcgKzE3MDksOSBAQCBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFp
biAqZCkKICAgICB1bnNpZ25lZCBpbnQgY3B1OwogCiAgICAgcndsb2NrX2lu
aXQoJnAybS0+bG9jayk7CisgICAgc3Bpbl9sb2NrX2luaXQoJmQtPmFyY2gu
cGFnaW5nLmxvY2spOwogICAgIElOSVRfUEFHRV9MSVNUX0hFQUQoJnAybS0+
cGFnZXMpOworICAgIElOSVRfUEFHRV9MSVNUX0hFQUQoJmQtPmFyY2gucGFn
aW5nLnAybV9mcmVlbGlzdCk7CiAKICAgICBwMm0tPnZtaWQgPSBJTlZBTElE
X1ZNSUQ7CiAKLS0gCjIuMzcuMQoK

--=separator
Content-Type: application/octet-stream;
 name="xsa409/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Disposition: attachment;
 filename="xsa409/0003-xen-arm-libxl-Implement-XEN_DOMCTL_shadow_op-for-Arm.patch"
Content-Transfer-Encoding: base64

RnJvbSBhNTYzZTJjMDJmOWU4OWM2ZWNlNGY2NTI1YzEwYjdiZTNiNTE1Yjli
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzoyOSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMy80XSB4ZW4vYXJtLCBsaWJ4
bDogSW1wbGVtZW50IFhFTl9ET01DVExfc2hhZG93X29wIGZvciBBcm0KClRo
aXMgY29tbWl0IGltcGxlbWVudHMgdGhlIGBYRU5fRE9NQ1RMX3NoYWRvd19v
cGAgc3VwcG9ydCBpbiBYZW4KZm9yIEFybS4gVGhlIHAybSBwYWdlcyBwb29s
IHNpemUgZm9yIHhsIGd1ZXN0cyBpcyBzdXBwb3NlZCB0byBiZQpkZXRlcm1p
bmVkIGJ5IGBYRU5fRE9NQ1RMX3NoYWRvd19vcGAuIEhlbmNlLCB0aGlzIGNv
bW1pdDoKCi0gSW50cm9kdWNlcyBhIGZ1bmN0aW9uIGBwMm1fZG9tY3RsYCBh
bmQgaW1wbGVtZW50cyB0aGUgc3Vib3BzCmBYRU5fRE9NQ1RMX1NIQURPV19P
UF9TRVRfQUxMT0NBVElPTmAgYW5kCmBYRU5fRE9NQ1RMX1NIQURPV19PUF9H
RVRfQUxMT0NBVElPTmAgb2YgYFhFTl9ET01DVExfc2hhZG93X29wYC4KCi0g
QWRkcyB0aGUgYFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FUSU9O
YCBzdXBwb3J0IGluIGxpYnhsLgoKVGhlcmVmb3JlIGVuYWJsaW5nIHRoZSBz
ZXR0aW5nIG9mIHNoYWRvdyBtZW1vcnkgcG9vbCBzaXplCndoZW4gY3JlYXRp
bmcgYSBndWVzdCBmcm9tIHhsIGFuZCBnZXR0aW5nIHNoYWRvdyBtZW1vcnkg
cG9vbCBzaXplCmZyb20gWGVuLgoKTm90ZSB0aGF0IHRoZSBgWEVOX0RPTUNU
TF9zaGFkb3dfb3BgIGFkZGVkIGluIHRoaXMgY29tbWl0IGlzIG9ubHkKYSBk
dW1teSBvcCwgYW5kIHRoZSBmdW5jdGlvbmFsaXR5IG9mIHNldHRpbmcvZ2V0
dGluZyBwMm0gbWVtb3J5IHBvb2wKc2l6ZSBmb3IgeGwgZ3Vlc3RzIHdpbGwg
YmUgYWRkZWQgaW4gZm9sbG93aW5nIGNvbW1pdHMuCgpUaGlzIGlzIHBhcnQg
b2YgQ1ZFLTIwMjItMzM3NDcgLyBYU0EtNDA5LgoKU2lnbmVkLW9mZi1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPgpSZXZpZXdlZC1ieTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgot
LS0KIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgfCAxMiArKysrKysr
KysrKysKIHhlbi9hcmNoL2FybS9kb21jdGwuYyAgICAgICAgfCAzMiArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk
LCA0NCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9s
aWdodC9saWJ4bF9hcm0uYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJt
LmMKaW5kZXggMWEzYWMxNjQ2ZTk0Li4yYTVlOTNjMjg0MDMgMTAwNjQ0Ci0t
LSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMKKysrIGIvdG9vbHMv
bGlicy9saWdodC9saWJ4bF9hcm0uYwpAQCAtMjA5LDYgKzIwOSwxOCBAQCBp
bnQgbGlieGxfX2FyY2hfZG9tYWluX2NyZWF0ZShsaWJ4bF9fZ2MgKmdjLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX2RvbWFpbl9i
dWlsZF9zdGF0ZSAqc3RhdGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICB1aW50MzJfdCBkb21pZCkKIHsKKyAgICBsaWJ4bF9jdHggKmN0eCA9
IGxpYnhsX19nY19vd25lcihnYyk7CisgICAgdW5zaWduZWQgaW50IHNoYWRv
d19tYiA9IERJVl9ST1VORFVQKGRfY29uZmlnLT5iX2luZm8uc2hhZG93X21l
bWtiLCAxMDI0KTsKKworICAgIGludCByID0geGNfc2hhZG93X2NvbnRyb2wo
Y3R4LT54Y2gsIGRvbWlkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgWEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT04sCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAmc2hhZG93X21iLCAwKTsKKyAg
ICBpZiAocikgeworICAgICAgICBMT0dFRChFUlJPUiwgZG9taWQsCisgICAg
ICAgICAgICAgICJGYWlsZWQgdG8gc2V0ICV1IE1pQiBzaGFkb3cgYWxsb2Nh
dGlvbiIsIHNoYWRvd19tYik7CisgICAgICAgIHJldHVybiBFUlJPUl9GQUlM
OworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCmRpZmYgLS1naXQgYS94
ZW4vYXJjaC9hcm0vZG9tY3RsLmMgYi94ZW4vYXJjaC9hcm0vZG9tY3RsLmMK
aW5kZXggMWJhZjI1YzNkOThiLi45YmY3MmU2OTMwMTkgMTAwNjQ0Ci0tLSBh
L3hlbi9hcmNoL2FybS9kb21jdGwuYworKysgYi94ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMKQEAgLTQ3LDExICs0Nyw0MyBAQCBzdGF0aWMgaW50IGhhbmRsZV92
dWFydF9pbml0KHN0cnVjdCBkb21haW4gKmQsCiAgICAgcmV0dXJuIHJjOwog
fQogCitzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQs
IHN0cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCisgICAgICAgICAg
ICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0
bF90KSB1X2RvbWN0bCkKK3sKKyAgICBpZiAoIHVubGlrZWx5KGQgPT0gY3Vy
cmVudC0+ZG9tYWluKSApCisgICAgeworICAgICAgICBwcmludGsoWEVOTE9H
X0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9wIG9uIGl0c2VsZi5c
biIpOworICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICB9CisKKyAgICBp
ZiAoIHVubGlrZWx5KGQtPmlzX2R5aW5nKSApCisgICAgeworICAgICAgICBw
cmludGsoWEVOTE9HX0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9w
IG9uIGR5aW5nIGRvbWFpbiAldVxuIiwKKyAgICAgICAgICAgICAgIGQtPmRv
bWFpbl9pZCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOworICAgIH0KKwor
ICAgIHN3aXRjaCAoIHNjLT5vcCApCisgICAgeworICAgIGNhc2UgWEVOX0RP
TUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT046CisgICAgICAgIHJldHVy
biAwOworICAgIGNhc2UgWEVOX0RPTUNUTF9TSEFET1dfT1BfR0VUX0FMTE9D
QVRJT046CisgICAgICAgIHJldHVybiAwOworICAgIGRlZmF1bHQ6CisgICAg
eworICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiQmFkIHAybSBkb21jdGwg
b3AgJXVcbiIsIHNjLT5vcCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOwor
ICAgIH0KKyAgICB9Cit9CisKIGxvbmcgYXJjaF9kb19kb21jdGwoc3RydWN0
IHhlbl9kb21jdGwgKmRvbWN0bCwgc3RydWN0IGRvbWFpbiAqZCwKICAgICAg
ICAgICAgICAgICAgICAgWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh4ZW5fZG9t
Y3RsX3QpIHVfZG9tY3RsKQogewogICAgIHN3aXRjaCAoIGRvbWN0bC0+Y21k
ICkKICAgICB7CisgICAgY2FzZSBYRU5fRE9NQ1RMX3NoYWRvd19vcDoKKyAg
ICAgICAgcmV0dXJuIHAybV9kb21jdGwoZCwgJmRvbWN0bC0+dS5zaGFkb3df
b3AsIHVfZG9tY3RsKTsKICAgICBjYXNlIFhFTl9ET01DVExfY2FjaGVmbHVz
aDoKICAgICB7CiAgICAgICAgIGdmbl90IHMgPSBfZ2ZuKGRvbWN0bC0+dS5j
YWNoZWZsdXNoLnN0YXJ0X3Bmbik7Ci0tIAoyLjM3LjEKCg==

--=separator
Content-Type: application/octet-stream;
 name="xsa409/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Disposition: attachment;
 filename="xsa409/0004-xen-arm-Allocate-and-free-P2M-pages-from-the-P2M-poo.patch"
Content-Transfer-Encoding: base64

RnJvbSA2NGE3MWYxNTM4YzY1Nzc3OWY3NGZhM2I2MzIyNmFjM2ViOTUzNzlh
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+CkRhdGU6IE1vbiwgNiBKdW4gMjAyMiAwNjox
NzozMCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSB4ZW4vYXJtOiBBbGxv
Y2F0ZSBhbmQgZnJlZSBQMk0gcGFnZXMgZnJvbSB0aGUgUDJNIHBvb2wKClRo
aXMgY29tbWl0IHNldHMvdGVhcnNkb3duIG9mIHAybSBwYWdlcyBwb29sIGZv
ciBub24tcHJpdmlsZWdlZCBBcm0KZ3Vlc3RzIGJ5IGNhbGxpbmcgYHAybV9z
ZXRfYWxsb2NhdGlvbmAgYW5kIGBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbmAu
CgotIEZvciBkb20wLCBQMk0gcGFnZXMgc2hvdWxkIGNvbWUgZnJvbSBoZWFw
IGRpcmVjdGx5IGluc3RlYWQgb2YgcDJtCnBvb2wsIHNvIHRoYXQgdGhlIGtl
cm5lbCBtYXkgdGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGV4dGVuZGVkIHJlZ2lv
bnMuCgotIEZvciB4bCBndWVzdHMsIHRoZSBzZXR0aW5nIG9mIHRoZSBwMm0g
cG9vbCBpcyBjYWxsZWQgaW4KYFhFTl9ET01DVExfc2hhZG93X29wYCBhbmQg
dGhlIHAybSBwb29sIGlzIGRlc3Ryb3llZCBpbgpgZG9tYWluX3JlbGlucXVp
c2hfcmVzb3VyY2VzYC4gTm90ZSB0aGF0IGRvbWN0bC0+dS5zaGFkb3dfb3Au
bWIgaXMKdXBkYXRlZCB3aXRoIHRoZSBuZXcgc2l6ZSB3aGVuIHNldHRpbmcg
dGhlIHAybSBwb29sLgoKLSBGb3IgZG9tMGxlc3MgZG9tVXMsIHRoZSBzZXR0
aW5nIG9mIHRoZSBwMm0gcG9vbCBpcyBjYWxsZWQgYmVmb3JlCmFsbG9jYXRp
bmcgbWVtb3J5IGR1cmluZyBkb21haW4gY3JlYXRpb24uIFVzZXJzIGNhbiBz
cGVjaWZ5IHRoZSBwMm0KcG9vbCBzaXplIGJ5IGB4ZW4sZG9tYWluLXAybS1t
ZW0tbWJgIGR0cyBwcm9wZXJ0eS4KClRvIGFjdHVhbGx5IGFsbG9jYXRlL2Zy
ZWUgcGFnZXMgZnJvbSB0aGUgcDJtIHBvb2wsIHRoaXMgY29tbWl0IGFkZHMK
dHdvIGhlbHBlciBmdW5jdGlvbnMgbmFtZWx5IGBwMm1fYWxsb2NfcGFnZWAg
YW5kIGBwMm1fZnJlZV9wYWdlYCB0bwpgc3RydWN0IHAybV9kb21haW5gLiBC
eSByZXBsYWNpbmcgdGhlIGBhbGxvY19kb21oZWFwX3BhZ2VgIGFuZApgZnJl
ZV9kb21oZWFwX3BhZ2VgIHdpdGggdGhlc2UgdHdvIGhlbHBlciBmdW5jdGlv
bnMsIHAybSBwYWdlcyBjYW4KYmUgYWRkZWQvcmVtb3ZlZCBmcm9tIHRoZSBs
aXN0IG9mIHAybSBwb29sIHJhdGhlciB0aGFuIGZyb20gdGhlIGhlYXAuCgpT
aW5jZSBwYWdlIGZyb20gYHAybV9hbGxvY19wYWdlYCBpcyBjbGVhbmVkLCB0
YWtlIHRoZSBvcHBvcnR1bml0eQp0byByZW1vdmUgdGhlIHJlZHVuZGFudCBg
Y2xlYW5fcGFnZWAgaW4gYHAybV9jcmVhdGVfdGFibGVgLgoKVGhpcyBpcyBw
YXJ0IG9mIENWRS0yMDIyLTMzNzQ3IC8gWFNBLTQwOS4KClNpZ25lZC1vZmYt
Ynk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4KUmV2aWV3ZWQt
Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9y
Zz4KLS0tCiBkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jvb3RpbmcudHh0
IHwgIDggKysrKwogeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAg
ICAgICB8ICA2ICsrKwogeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jICAg
ICAgICAgICB8IDI5ICsrKysrKysrKysrKysrCiB4ZW4vYXJjaC9hcm0vZG9t
Y3RsLmMgICAgICAgICAgICAgICAgIHwgMjMgKysrKysrKysrKy0KIHhlbi9h
cmNoL2FybS9wMm0uYyAgICAgICAgICAgICAgICAgICAgfCA1NyArKysrKysr
KysrKysrKysrKysrKysrKysrLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTE4IGlu
c2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9j
cy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dCBiL2RvY3MvbWlz
Yy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKaW5kZXggOTgyNTM0MTRi
OGQxLi5iZjQwMWQzYzkxYzEgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlzYy9hcm0v
ZGV2aWNlLXRyZWUvYm9vdGluZy50eHQKKysrIGIvZG9jcy9taXNjL2FybS9k
ZXZpY2UtdHJlZS9ib290aW5nLnR4dApAQCAtMjExLDYgKzIxMSwxNCBAQCB3
aXRoIHRoZSBmb2xsb3dpbmcgcHJvcGVydGllczoKICAgICBJbiB0aGUgZnV0
dXJlIG90aGVyIHBvc3NpYmxlIHByb3BlcnR5IHZhbHVlcyBtaWdodCBiZSBh
ZGRlZCB0bwogICAgIGVuYWJsZSBvbmx5IHNlbGVjdGVkIGludGVyZmFjZXMu
CiAKKy0geGVuLGRvbWFpbi1wMm0tbWVtLW1iCisKKyAgICBPcHRpb25hbC4g
QSAzMi1iaXQgaW50ZWdlciBzcGVjaWZ5aW5nIHRoZSBhbW91bnQgb2YgbWVn
YWJ5dGVzIG9mIFJBTQorICAgIHVzZWQgZm9yIHRoZSBkb21haW4gUDJNIHBv
b2wuIFRoaXMgaXMgaW4tc3luYyB3aXRoIHRoZSBzaGFkb3dfbWVtb3J5Cisg
ICAgb3B0aW9uIGluIHhsLmNmZy4gTGVhdmluZyB0aGlzIGZpZWxkIGVtcHR5
IGluIGRldmljZSB0cmVlIHdpbGwgbGVhZCB0bworICAgIHRoZSBkZWZhdWx0
IHNpemUgb2YgZG9tYWluIFAyTSBwb29sLCBpLmUuIDFNQiBwZXIgZ3Vlc3Qg
dkNQVSBwbHVzIDRLQgorICAgIHBlciBNQiBvZiBndWVzdCBSQU0gcGx1cyA1
MTJLQiBmb3IgZ3Vlc3QgZXh0ZW5kZWQgcmVnaW9ucy4KKwogVW5kZXIgdGhl
ICJ4ZW4sZG9tYWluIiBjb21wYXRpYmxlIG5vZGUsIG9uZSBvciBtb3JlIHN1
Yi1ub2RlcyBhcmUgcHJlc2VudAogZm9yIHRoZSBEb21VIGtlcm5lbCBhbmQg
cmFtZGlzay4KIApkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5j
IGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jCmluZGV4IGU1YWUzZTcxZWIyMC4u
MzNlZTRmNDAzMmExIDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWlu
LmMKKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbi5jCkBAIC0xMDA1LDYgKzEw
MDUsNyBAQCBlbnVtIHsKICAgICBQUk9HX3BhZ2UsCiAgICAgUFJPR19tYXBw
aW5nLAogICAgIFBST0dfcDJtLAorICAgIFBST0dfcDJtX3Bvb2wsCiAgICAg
UFJPR19kb25lLAogfTsKIApAQCAtMTA3MCw2ICsxMDcxLDExIEBAIGludCBk
b21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoc3RydWN0IGRvbWFpbiAqZCkK
ICAgICAgICAgaWYgKCByZXQgKQogICAgICAgICAgICAgcmV0dXJuIHJldDsK
IAorICAgIFBST0dSRVNTKHAybV9wb29sKToKKyAgICAgICAgcmV0ID0gcDJt
X3RlYXJkb3duX2FsbG9jYXRpb24oZCk7CisgICAgICAgIGlmKCByZXQgKQor
ICAgICAgICAgICAgcmV0dXJuIHJldDsKKwogICAgIFBST0dSRVNTKGRvbmUp
OgogICAgICAgICBicmVhazsKIApkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJt
L2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5j
CmluZGV4IDNmZDExODZiNTNhOC4uOTMyMDBiZmY1NzExIDEwMDY0NAotLS0g
YS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMKKysrIGIveGVuL2FyY2gv
YXJtL2RvbWFpbl9idWlsZC5jCkBAIC0zMDc5LDYgKzMwNzksMjEgQEAgc3Rh
dGljIHZvaWQgX19pbml0IGZpbmRfZ250dGFiX3JlZ2lvbihzdHJ1Y3QgZG9t
YWluICpkLAogICAgICAgICAgICBraW5mby0+Z250dGFiX3N0YXJ0LCBraW5m
by0+Z250dGFiX3N0YXJ0ICsga2luZm8tPmdudHRhYl9zaXplKTsKIH0KIAor
c3RhdGljIHVuc2lnbmVkIGxvbmcgX19pbml0IGRvbWFpbl9wMm1fcGFnZXMo
dW5zaWduZWQgbG9uZyBtYXhtZW1fa2IsCisgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgc21wX2Nw
dXMpCit7CisgICAgLyoKKyAgICAgKiBLZWVwIGluIHN5bmMgd2l0aCBsaWJ4
bF9fZ2V0X3JlcXVpcmVkX3BhZ2luZ19tZW1vcnkoKS4KKyAgICAgKiAyNTYg
cGFnZXMgKDFNQikgcGVyIHZjcHUsIHBsdXMgMSBwYWdlIHBlciBNaUIgb2Yg
UkFNIGZvciB0aGUgUDJNIG1hcCwKKyAgICAgKiBwbHVzIDEyOCBwYWdlcyB0
byBjb3ZlciBleHRlbmRlZCByZWdpb25zLgorICAgICAqLworICAgIHVuc2ln
bmVkIGxvbmcgbWVta2IgPSA0ICogKDI1NiAqIHNtcF9jcHVzICsgKG1heG1l
bV9rYiAvIDEwMjQpICsgMTI4KTsKKworICAgIEJVSUxEX0JVR19PTihQQUdF
X1NJWkUgIT0gU1pfNEspOworCisgICAgcmV0dXJuIERJVl9ST1VORF9VUCht
ZW1rYiwgMTAyNCkgPDwgKDIwIC0gUEFHRV9TSElGVCk7Cit9CisKIHN0YXRp
YyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb21haW4oc3RydWN0IGRvbWFpbiAq
ZCwgc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbykKIHsKICAgICB1bnNpZ25l
ZCBpbnQgaTsKQEAgLTMxOTAsNiArMzIwNSw4IEBAIHN0YXRpYyBpbnQgX19p
bml0IGNvbnN0cnVjdF9kb21VKHN0cnVjdCBkb21haW4gKmQsCiAgICAgY29u
c3QgY2hhciAqZG9tMGxlc3NfZW5oYW5jZWQ7CiAgICAgaW50IHJjOwogICAg
IHU2NCBtZW07CisgICAgdTMyIHAybV9tZW1fbWI7CisgICAgdW5zaWduZWQg
bG9uZyBwMm1fcGFnZXM7CiAKICAgICByYyA9IGR0X3Byb3BlcnR5X3JlYWRf
dTY0KG5vZGUsICJtZW1vcnkiLCAmbWVtKTsKICAgICBpZiAoICFyYyApCkBA
IC0zMTk5LDYgKzMyMTYsMTggQEAgc3RhdGljIGludCBfX2luaXQgY29uc3Ry
dWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwKICAgICB9CiAgICAga2luZm8u
dW5hc3NpZ25lZF9tZW0gPSAocGFkZHJfdCltZW0gKiBTWl8xSzsKIAorICAg
IHJjID0gZHRfcHJvcGVydHlfcmVhZF91MzIobm9kZSwgInhlbixkb21haW4t
cDJtLW1lbS1tYiIsICZwMm1fbWVtX21iKTsKKyAgICAvKiBJZiB4ZW4sZG9t
YWluLXAybS1tZW0tbWIgaXMgbm90IHNwZWNpZmllZCwgdXNlIHRoZSBkZWZh
dWx0IHZhbHVlLiAqLworICAgIHAybV9wYWdlcyA9IHJjID8KKyAgICAgICAg
ICAgICAgICBwMm1fbWVtX21iIDw8ICgyMCAtIFBBR0VfU0hJRlQpIDoKKyAg
ICAgICAgICAgICAgICBkb21haW5fcDJtX3BhZ2VzKG1lbSwgZC0+bWF4X3Zj
cHVzKTsKKworICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7
CisgICAgcmMgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgcDJtX3BhZ2VzLCBO
VUxMKTsKKyAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7
CisgICAgaWYgKCByYyAhPSAwICkKKyAgICAgICAgcmV0dXJuIHJjOworCiAg
ICAgcHJpbnRrKCIqKiogTE9BRElORyBET01VIGNwdXM9JXUgbWVtb3J5PSUi
UFJJeDY0IktCICoqKlxuIiwgZC0+bWF4X3ZjcHVzLCBtZW0pOwogCiAgICAg
a2luZm8udnBsMDExID0gZHRfcHJvcGVydHlfcmVhZF9ib29sKG5vZGUsICJ2
cGwwMTEiKTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21jdGwuYyBi
L3hlbi9hcmNoL2FybS9kb21jdGwuYwppbmRleCA5YmY3MmU2OTMwMTkuLmM4
ZmRlYjEyNDA4NCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL2RvbWN0bC5j
CisrKyBiL3hlbi9hcmNoL2FybS9kb21jdGwuYwpAQCAtNTAsNiArNTAsOSBA
QCBzdGF0aWMgaW50IGhhbmRsZV92dWFydF9pbml0KHN0cnVjdCBkb21haW4g
KmQsCiBzdGF0aWMgbG9uZyBwMm1fZG9tY3RsKHN0cnVjdCBkb21haW4gKmQs
IHN0cnVjdCB4ZW5fZG9tY3RsX3NoYWRvd19vcCAqc2MsCiAgICAgICAgICAg
ICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0oeGVuX2RvbWN0
bF90KSB1X2RvbWN0bCkKIHsKKyAgICBsb25nIHJjOworICAgIGJvb2wgcHJl
ZW1wdGVkID0gZmFsc2U7CisKICAgICBpZiAoIHVubGlrZWx5KGQgPT0gY3Vy
cmVudC0+ZG9tYWluKSApCiAgICAgewogICAgICAgICBwcmludGsoWEVOTE9H
X0VSUiAiVHJpZWQgdG8gZG8gYSBwMm0gZG9tY3RsIG9wIG9uIGl0c2VsZi5c
biIpOwpAQCAtNjYsOSArNjksMjcgQEAgc3RhdGljIGxvbmcgcDJtX2RvbWN0
bChzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgeGVuX2RvbWN0bF9zaGFkb3df
b3AgKnNjLAogICAgIHN3aXRjaCAoIHNjLT5vcCApCiAgICAgewogICAgIGNh
c2UgWEVOX0RPTUNUTF9TSEFET1dfT1BfU0VUX0FMTE9DQVRJT046Ci0gICAg
ICAgIHJldHVybiAwOworICAgIHsKKyAgICAgICAgLyogQWxsb3cgYW5kIGhh
bmRsZSBwcmVlbXB0aW9uICovCisgICAgICAgIHNwaW5fbG9jaygmZC0+YXJj
aC5wYWdpbmcubG9jayk7CisgICAgICAgIHJjID0gcDJtX3NldF9hbGxvY2F0
aW9uKGQsIHNjLT5tYiA8PCAoMjAgLSBQQUdFX1NISUZUKSwgJnByZWVtcHRl
ZCk7CisgICAgICAgIHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2Nr
KTsKKworICAgICAgICBpZiAoIHByZWVtcHRlZCApCisgICAgICAgICAgICAv
KiBOb3QgZmluaXNoZWQuIFNldCB1cCB0byByZS1ydW4gdGhlIGNhbGwuICov
CisgICAgICAgICAgICByYyA9IGh5cGVyY2FsbF9jcmVhdGVfY29udGludWF0
aW9uKF9fSFlQRVJWSVNPUl9kb21jdGwsICJoIiwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdV9kb21jdGwpOwor
ICAgICAgICBlbHNlCisgICAgICAgICAgICAvKiBGaW5pc2hlZC4gUmV0dXJu
IHRoZSBuZXcgYWxsb2NhdGlvbi4gKi8KKyAgICAgICAgICAgIHNjLT5tYiA9
IHAybV9nZXRfYWxsb2NhdGlvbihkKTsKKworICAgICAgICByZXR1cm4gcmM7
CisgICAgfQogICAgIGNhc2UgWEVOX0RPTUNUTF9TSEFET1dfT1BfR0VUX0FM
TE9DQVRJT046CisgICAgeworICAgICAgICBzYy0+bWIgPSBwMm1fZ2V0X2Fs
bG9jYXRpb24oZCk7CiAgICAgICAgIHJldHVybiAwOworICAgIH0KICAgICBk
ZWZhdWx0OgogICAgIHsKICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIkJh
ZCBwMm0gZG9tY3RsIG9wICV1XG4iLCBzYy0+b3ApOwpkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5jCmluZGV4
IGRiMzg1ZmU0MTAyMy4uZjE3NTAwZGRmM2EzIDEwMDY0NAotLS0gYS94ZW4v
YXJjaC9hcm0vcDJtLmMKKysrIGIveGVuL2FyY2gvYXJtL3AybS5jCkBAIC00
NCw2ICs0NCw1NCBAQCBzdGF0aWMgdWludDY0X3QgZ2VuZXJhdGVfdnR0YnIo
dWludDE2X3Qgdm1pZCwgbWZuX3Qgcm9vdF9tZm4pCiAgICAgcmV0dXJuICht
Zm5fdG9fbWFkZHIocm9vdF9tZm4pIHwgKCh1aW50NjRfdCl2bWlkIDw8IDQ4
KSk7CiB9CiAKK3N0YXRpYyBzdHJ1Y3QgcGFnZV9pbmZvICpwMm1fYWxsb2Nf
cGFnZShzdHJ1Y3QgZG9tYWluICpkKQoreworICAgIHN0cnVjdCBwYWdlX2lu
Zm8gKnBnOworCisgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2Nr
KTsKKyAgICAvKgorICAgICAqIEZvciBoYXJkd2FyZSBkb21haW4sIHRoZXJl
IHNob3VsZCBiZSBubyBsaW1pdCBpbiB0aGUgbnVtYmVyIG9mIHBhZ2VzIHRo
YXQKKyAgICAgKiBjYW4gYmUgYWxsb2NhdGVkLCBzbyB0aGF0IHRoZSBrZXJu
ZWwgbWF5IHRha2UgYWR2YW50YWdlIG9mIHRoZSBleHRlbmRlZAorICAgICAq
IHJlZ2lvbnMuIEhlbmNlLCBhbGxvY2F0ZSBwMm0gcGFnZXMgZm9yIGhhcmR3
YXJlIGRvbWFpbnMgZnJvbSBoZWFwLgorICAgICAqLworICAgIGlmICggaXNf
aGFyZHdhcmVfZG9tYWluKGQpICkKKyAgICB7CisgICAgICAgIHBnID0gYWxs
b2NfZG9taGVhcF9wYWdlKE5VTEwsIDApOworICAgICAgICBpZiAoIHBnID09
IE5VTEwgKQorICAgICAgICB7CisgICAgICAgICAgICBwcmludGsoWEVOTE9H
X0dfRVJSICJGYWlsZWQgdG8gYWxsb2NhdGUgUDJNIHBhZ2VzIGZvciBod2Rv
bS5cbiIpOworICAgICAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFn
aW5nLmxvY2spOworICAgICAgICAgICAgcmV0dXJuIE5VTEw7CisgICAgICAg
IH0KKyAgICB9CisgICAgZWxzZQorICAgIHsKKyAgICAgICAgcGcgPSBwYWdl
X2xpc3RfcmVtb3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLnAybV9mcmVlbGlz
dCk7CisgICAgICAgIGlmICggdW5saWtlbHkoIXBnKSApCisgICAgICAgIHsK
KyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2Nr
KTsKKyAgICAgICAgICAgIHJldHVybiBOVUxMOworICAgICAgICB9CisgICAg
ICAgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdlcy0tOworICAgIH0K
KyAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7CisKKyAg
ICByZXR1cm4gcGc7Cit9CisKK3N0YXRpYyB2b2lkIHAybV9mcmVlX3BhZ2Uo
c3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHBhZ2VfaW5mbyAqcGcpCit7Cisg
ICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsKKyAgICBpZiAo
IGlzX2hhcmR3YXJlX2RvbWFpbihkKSApCisgICAgICAgIGZyZWVfZG9taGVh
cF9wYWdlKHBnKTsKKyAgICBlbHNlCisgICAgeworICAgICAgICBkLT5hcmNo
LnBhZ2luZy5wMm1fdG90YWxfcGFnZXMrKzsKKyAgICAgICAgcGFnZV9saXN0
X2FkZF90YWlsKHBnLCAmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsK
KyAgICB9CisgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5nLmxvY2sp
OworfQorCiAvKiBSZXR1cm4gdGhlIHNpemUgb2YgdGhlIHBvb2wsIHJvdW5k
ZWQgdXAgdG8gdGhlIG5lYXJlc3QgTUIgKi8KIHVuc2lnbmVkIGludCBwMm1f
Z2V0X2FsbG9jYXRpb24oc3RydWN0IGRvbWFpbiAqZCkKIHsKQEAgLTc0Nyw3
ICs3OTUsNyBAQCBzdGF0aWMgaW50IHAybV9jcmVhdGVfdGFibGUoc3RydWN0
IHAybV9kb21haW4gKnAybSwgbHBhZV90ICplbnRyeSkKIAogICAgIEFTU0VS
VCghcDJtX2lzX3ZhbGlkKCplbnRyeSkpOwogCi0gICAgcGFnZSA9IGFsbG9j
X2RvbWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICBwYWdlID0gcDJtX2FsbG9j
X3BhZ2UocDJtLT5kb21haW4pOwogICAgIGlmICggcGFnZSA9PSBOVUxMICkK
ICAgICAgICAgcmV0dXJuIC1FTk9NRU07CiAKQEAgLTg3Nyw3ICs5MjUsNyBA
QCBzdGF0aWMgdm9pZCBwMm1fZnJlZV9lbnRyeShzdHJ1Y3QgcDJtX2RvbWFp
biAqcDJtLAogICAgIHBnID0gbWZuX3RvX3BhZ2UobWZuKTsKIAogICAgIHBh
Z2VfbGlzdF9kZWwocGcsICZwMm0tPnBhZ2VzKTsKLSAgICBmcmVlX2RvbWhl
YXBfcGFnZShwZyk7CisgICAgcDJtX2ZyZWVfcGFnZShwMm0tPmRvbWFpbiwg
cGcpOwogfQogCiBzdGF0aWMgYm9vbCBwMm1fc3BsaXRfc3VwZXJwYWdlKHN0
cnVjdCBwMm1fZG9tYWluICpwMm0sIGxwYWVfdCAqZW50cnksCkBAIC05MDEs
NyArOTQ5LDcgQEAgc3RhdGljIGJvb2wgcDJtX3NwbGl0X3N1cGVycGFnZShz
dHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBscGFlX3QgKmVudHJ5LAogICAgIEFT
U0VSVChsZXZlbCA8IHRhcmdldCk7CiAgICAgQVNTRVJUKHAybV9pc19zdXBl
cnBhZ2UoKmVudHJ5LCBsZXZlbCkpOwogCi0gICAgcGFnZSA9IGFsbG9jX2Rv
bWhlYXBfcGFnZShOVUxMLCAwKTsKKyAgICBwYWdlID0gcDJtX2FsbG9jX3Bh
Z2UocDJtLT5kb21haW4pOwogICAgIGlmICggIXBhZ2UgKQogICAgICAgICBy
ZXR1cm4gZmFsc2U7CiAKQEAgLTE2NjUsNyArMTcxMyw3IEBAIGludCBwMm1f
dGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKIAogICAgIHdoaWxlICggKHBn
ID0gcGFnZV9saXN0X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQogICAg
IHsKLSAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOworICAgICAgICBw
Mm1fZnJlZV9wYWdlKHAybS0+ZG9tYWluLCBwZyk7CiAgICAgICAgIGNvdW50
Kys7CiAgICAgICAgIC8qIEFyYml0cmFyaWx5IHByZWVtcHQgZXZlcnkgNTEy
IGl0ZXJhdGlvbnMgKi8KICAgICAgICAgaWYgKCAhKGNvdW50ICUgNTEyKSAm
JiBoeXBlcmNhbGxfcHJlZW1wdF9jaGVjaygpICkKQEAgLTE2ODksNiArMTcz
Nyw3IEBAIHZvaWQgcDJtX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4g
KmQpCiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVChwYWdlX2xpc3Rf
ZW1wdHkoJnAybS0+cGFnZXMpKTsKKyAgICBBU1NFUlQocGFnZV9saXN0X2Vt
cHR5KCZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxpc3QpKTsKIAogICAgIGlm
ICggcDJtLT5yb290ICkKICAgICAgICAgZnJlZV9kb21oZWFwX3BhZ2VzKHAy
bS0+cm9vdCwgUDJNX1JPT1RfT1JERVIpOwotLSAKMi4zNy4xCgo=

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.419726.664608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE1n-0004vl-0u; Tue, 11 Oct 2022 12:06:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 419726.664608; Tue, 11 Oct 2022 12:06:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiE1m-0004vO-T6; Tue, 11 Oct 2022 12:06:30 +0000
Received: by outflank-mailman (input) for mailman id 419726;
 Tue, 11 Oct 2022 12:06:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4MZe=2M=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1oiE1k-0004Vb-Ne
 for xen-devel@lists.xen.org; Tue, 11 Oct 2022 12:06:28 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 200b1cf2-495d-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 14:06:26 +0200 (CEST)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE1U-0000l5-0S; Tue, 11 Oct 2022 12:06:12 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1oiE1T-0002aK-VO; Tue, 11 Oct 2022 12:06:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 200b1cf2-495d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=h2SM72HX5eauaekrZ4M41cQi8TBIUNWs4wGUg43miHc=; b=of+bLpezprwwFfnB+znTu3o+qp
	CxsT5vKPIQY2EEPp/miYqZ8R26zvoFgVJMKTxGn5w+fdOB3EAB+7V74PI16mDNbO0l2deZK77DJZC
	iGCn4rqBpdXQvt7MJJ6GuQ/gSQ+rhc4uajva8Qzx+owPEy6RiO0OmuZgEnFx7x2/PvjU=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 413 v2 (CVE-2022-33749) - XAPI open file
 limit DoS
Message-Id: <E1oiE1T-0002aK-VO@xenbits.xenproject.org>
Date: Tue, 11 Oct 2022 12:06:11 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

            Xen Security Advisory CVE-2022-33749 / XSA-413
                               version 2

                       XAPI open file limit DoS

UPDATES IN VERSION 2
====================

Public release.

ISSUE DESCRIPTION
=================

It is possible for an unauthenticated client on the network to cause
XAPI to hit its file-descriptor limit. This causes XAPI to be unable
to accept new requests for other (trusted) clients, and blocks XAPI
from carrying out any tasks that require the opening of file
descriptors.

IMPACT
======

An attacker is capable of blocking connections to the XAPI HTTP
interface, and also interrupt ongoing operations, causing a XAPI
toolstack Denial of Service.  Such DoS would also affect any guests
that require toolstack actions.

VULNERABLE SYSTEMS
==================

All versions of XAPI are vulnerable.

Systems which are not using the XAPI toolstack are not vulnerable.

MITIGATION
==========

Not exposing to untrusted clients the network interface XAPI is
listening on will prevent the issue.

RESOLUTION
==========

Applying the attached patches resolves this issue.

xsa413/xsa413-*.patch         Xapi master

$ sha256sum xsa413*/*
63f72af7a92944700318add5cc200160ff7f834b6d304dd22441fa2de74c7b83  xsa413/xsa413-1.patch
6fbcbfb1915ebc4a726374d94e050406d8f1d52c3cb9afc06bcf7cec9e5a19c8  xsa413/xsa413-2.patch
c41de04ff2b63756e693c6c75ec4d7206a88db06c1da0b263c9d0644da90ef8b  xsa413/xsa413-3.patch
6ee2dc09f6c5f64ce9627e9b4e314237817f7c0c2eebe30a2c83709d1faf0050  xsa413/xsa413-4.patch
360a5099ece45118488706acd76b6da3ca8e6f107cee24586dbf6ec7f5858aeb  xsa413/xsa413-5.patch
cc79e086affcfd784ab8cd38e1d0acd6adb241c24141f3409161e417cc314b28  xsa413/xsa413-6.patch
$

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the patches and/or mitigations described above (or
others which are substantially similar) is permitted during the
embargo, even on public-facing systems with untrusted guest users and
administrators.

But: Distribution of updated software is prohibited (except to other
members of the predisclosure list).

Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmNFTAEMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZmIMH/RBAGOrAi8NI7BBeGHwMW7WqyMfT6mTVUFkb2z9z
ZFtvPFvim5AobCUpAKFtUAWpSQoUEEPyTO83C2VDe9jQC37mRo/qAduX7wj8oaJv
Dq+QFECP95bsfmu0SwKYL7ZW+3lLxDVwtp88z4P/H/U0VYqG+bNrR569znBbn0wL
p7EKQG5A4PS0nLg8ehnxjwuKCn0dCgUIZibh3AIMOUDTFY/apVeDFbX7bKIoQgLV
/0B18MevryxqSRe3QpL2WW/kRGLLKF7i5SA7nAbOPMzPWHOLNDZb+b+Hq7/eYwzI
a2+6yUcBkWAqyi9M3fXkhslySA/WqLdPXBIkd47zZS9rIuU=
=Ih6z
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa413/xsa413-1.patch"
Content-Disposition: attachment; filename="xsa413/xsa413-1.patch"
Content-Transfer-Encoding: base64

RnJvbSA5Mzg0N2I1ZWFjMGFjMjg3ZGVhOTI5OGYzOTRkMDFhNTFlYjk2MmJi
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgSG9lcyA8cm9i
LmhvZXNAY2l0cml4LmNvbT4KRGF0ZTogVGh1LCA3IEp1bCAyMDIyIDEzOjQw
OjU2ICswMDAwClN1YmplY3Q6IFtQQVRDSCAxLzZdIFJlbW92ZSB1bnVzZWQg
SHR0cF9wcm94eS5odHRwX3Byb3h5CgpTaWduZWQtb2ZmLWJ5OiBSb2IgSG9l
cyA8cm9iLmhvZXNAY2l0cml4LmNvbT4KLS0tCiBvY2FtbC9saWJzL2h0dHAt
c3ZyL2h0dHBfcHJveHkubWwgIHwgNTQgLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tCiBvY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfcHJveHkubWxp
IHwgIDQgLS0tCiBvY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1saSAg
IHwgIDYgLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA2NCBkZWxldGlvbnMoLSkK
CmRpZmYgLS1naXQgYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfcHJveHku
bWwgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfcHJveHkubWwKaW5kZXgg
MGY0NzQ1NzZkLi40ZDdhMWQ4MmYgMTAwNjQ0Ci0tLSBhL29jYW1sL2xpYnMv
aHR0cC1zdnIvaHR0cF9wcm94eS5tbAorKysgYi9vY2FtbC9saWJzL2h0dHAt
c3ZyL2h0dHBfcHJveHkubWwKQEAgLTUzLDU3ICs1MywzIEBAIGxldCBvbmUg
cmVxdWVzdCBmcm9tZmQgcyA9CiAgIHwgbSAtPgogICAgICAgZXJyb3IgIlBy
b3h5IGRvZXNuJ3Qgc3VwcG9ydDogJXMiIChIdHRwLnN0cmluZ19vZl9tZXRo
b2RfdCBtKSA7CiAgICAgICBIdHRwX3N2ci5yZXNwb25zZV9mb3JiaWRkZW4g
fnJlcTpyZXF1ZXN0IGZyb21mZAotCi1sZXQgc2VydmVyID0gcmVmIE5vbmUK
LQotbGV0IG0gPSBNdXRleC5jcmVhdGUgKCkKLQotbGV0IGh0dHBfcHJveHkg
c3JjX2lwIHNyY19wb3J0IHRyYW5zcG9ydCA9Ci0gIGxldCB0Y3BfY29ubmVj
dGlvbiBfIGZyb21mZCA9Ci0gICAgKCogTkIgJ2Zyb21mZCcgaXMgYWNjZXB0
ZWQgd2l0aGluIHRoZSBzZXJ2ZXJfaW8gbW9kdWxlIGFuZCBpdCBleHBlY3Rz
IHVzIHRvIGNsb3NlIGl0ICopCi0gICAgZmluYWxseQotICAgICAgKGZ1biAo
KSAtPgotICAgICAgICBsZXQgYmlvID0gQnVmX2lvLm9mX2ZkIGZyb21mZCBp
bgotICAgICAgICBsZXQgcmVxdWVzdCwgXyA9IEh0dHBfc3ZyLnJlcXVlc3Rf
b2ZfYmlvIGJpbyBpbgotICAgICAgICBPcHRpb24uaXRlcgotICAgICAgICAg
IChmdW4gcmVxdWVzdCAtPiB3aXRoX3RyYW5zcG9ydCB0cmFuc3BvcnQgKG9u
ZSByZXF1ZXN0IGZyb21mZCkpCi0gICAgICAgICAgcmVxdWVzdAotICAgICAg
KQotICAgICAgKGZ1biAoKSAtPiBVbml4LmNsb3NlIGZyb21mZCkKLSAgaW4K
LSAgdHJ5Ci0gICAgbGV0IGFkZHIgPSBVbml4LmluZXRfYWRkcl9vZl9zdHJp
bmcgc3JjX2lwIGluCi0gICAgbGV0IHNvY2thZGRyID0gVW5peC5BRERSX0lO
RVQgKGFkZHIsIHNyY19wb3J0KSBpbgotICAgIFhhcGlfc3RkZXh0X3RocmVh
ZHMuVGhyZWFkZXh0Lk11dGV4LmV4ZWN1dGUgbSAoZnVuICgpIC0+Ci0gICAg
ICAgICgqIHNodXRkb3duIGFueSBzZXJ2ZXIgd2hpY2ggY3VycmVudGx5IGV4
aXN0cyAqKQotICAgICAgICBPcHRpb24uaXRlciAoZnVuIHNlcnZlciAtPiBz
ZXJ2ZXIuU2VydmVyX2lvLnNodXRkb3duICgpKSAhc2VydmVyIDsKLSAgICAg
ICAgKCogTWFrZSBzdXJlIHdlIGRvbid0IHRyeSB0byBkb3VibGUtY2xvc2Ug
dGhlIHNlcnZlciAqKQotICAgICAgICBzZXJ2ZXIgOj0gTm9uZSA7Ci0gICAg
ICAgIGxldCBoYW5kbGVyID0ge1NlcnZlcl9pby5uYW1lPSAiaHR0cF9wcm94
eSI7IGJvZHk9IHRjcF9jb25uZWN0aW9ufSBpbgotICAgICAgICBsZXQgc29j
ayA9Ci0gICAgICAgICAgVW5peC5zb2NrZXQgKFVuaXguZG9tYWluX29mX3Nv
Y2thZGRyIHNvY2thZGRyKSBVbml4LlNPQ0tfU1RSRUFNIDAKLSAgICAgICAg
aW4KLSAgICAgICAgKCB0cnkKLSAgICAgICAgICAgICgqIE1ha2Ugc3VyZSBl
eGNlcHRpb25zIGNhdXNlIHRoZSBzb2NrZXQgdG8gYmUgY2xvc2VkICopCi0g
ICAgICAgICAgICBVbml4LnNldF9jbG9zZV9vbl9leGVjIHNvY2sgOwotICAg
ICAgICAgICAgVW5peC5zZXRzb2Nrb3B0IHNvY2sgVW5peC5TT19SRVVTRUFE
RFIgdHJ1ZSA7Ci0gICAgICAgICAgICAoIG1hdGNoIHNvY2thZGRyIHdpdGgK
LSAgICAgICAgICAgIHwgVW5peC5BRERSX0lORVQgXyAtPgotICAgICAgICAg
ICAgICAgIFhhcGlfc3RkZXh0X3VuaXguVW5peGV4dC5zZXRfdGNwX25vZGVs
YXkgc29jayB0cnVlCi0gICAgICAgICAgICB8IF8gLT4KLSAgICAgICAgICAg
ICAgICAoKQotICAgICAgICAgICAgKSA7Ci0gICAgICAgICAgICBVbml4LmJp
bmQgc29jayBzb2NrYWRkciA7IFVuaXgubGlzdGVuIHNvY2sgMTI4Ci0gICAg
ICAgICAgd2l0aCBlIC0+Ci0gICAgICAgICAgICBkZWJ1ZyAiQ2F1Z2h0IGV4
Y2VwdGlvbiBpbiBIdHRwX3N2ci5iaW5kIChjbG9zaW5nIHNvY2tldCk6ICVz
IgotICAgICAgICAgICAgICAoUHJpbnRleGMudG9fc3RyaW5nIGUpIDsKLSAg
ICAgICAgICAgIFVuaXguY2xvc2Ugc29jayA7Ci0gICAgICAgICAgICByYWlz
ZSBlCi0gICAgICAgICkgOwotICAgICAgICBsZXQgcyA9IFNlcnZlcl9pby5z
ZXJ2ZXIgaGFuZGxlciBzb2NrIGluCi0gICAgICAgIHNlcnZlciA6PSBTb21l
IHMKLSAgICApCi0gIHdpdGggZSAtPgotICAgIGVycm9yICJDYXVnaHQgZXhj
ZXB0aW9uIHNldHRpbmcgdXAgcHJveHkgZnJvbSBpbnRlcm5hbCBuZXR3b3Jr
OiAlcyIKLSAgICAgIChQcmludGV4Yy50b19zdHJpbmcgZSkgOwotICAgIHJh
aXNlIGUKZGlmZiAtLWdpdCBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9w
cm94eS5tbGkgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfcHJveHkubWxp
CmluZGV4IDQzZWYwMTJkZS4uYTUxNjE4MDFkIDEwMDY0NAotLS0gYS9vY2Ft
bC9saWJzL2h0dHAtc3ZyL2h0dHBfcHJveHkubWxpCisrKyBiL29jYW1sL2xp
YnMvaHR0cC1zdnIvaHR0cF9wcm94eS5tbGkKQEAgLTE1LDcgKzE1LDMgQEAK
IHZhbCBvbmUgOiBIdHRwLlJlcXVlc3QudCAtPiBVbml4LmZpbGVfZGVzY3Ig
LT4gVW5peC5maWxlX2Rlc2NyIC0+IHVuaXQKICgqKiBbb25lIHJlcXVlc3Qg
aW5wdXQgb3V0cHV0XSBwcm94aWVzIHRoZSBzaW5nbGUgSFRUUCByZXF1ZXN0
IFtyZXF1ZXN0XQogICAgIGZyb20gW2lucHV0XSB0byBbb3V0cHV0XSAqKQot
Ci12YWwgaHR0cF9wcm94eSA6IHN0cmluZyAtPiBpbnQgLT4gWG1scnBjX2Ns
aWVudC50cmFuc3BvcnQgLT4gdW5pdAotKCoqIFtodHRwX3Byb3h5IGlwIHBv
cnQgdHJhbnNwb3J0XSBlc3RhYmxpc2hlcyBhbiBIVFRQIHByb3h5IG9uIFtp
cF06W3BvcnRdCi0gICAgd2hpY2ggZm9yd2FyZHMgYWxsIHJlcXVlc3RzIHZp
YSBbdHJhbnNwb3J0XSAqKQpkaWZmIC0tZ2l0IGEvb2NhbWwvbGlicy9odHRw
LXN2ci9odHRwX3N2ci5tbGkgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBf
c3ZyLm1saQppbmRleCA4OTk2ZTAyMDMuLjZkOTAzMmZmNCAxMDA2NDQKLS0t
IGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbGkKKysrIGIvb2Nh
bWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbGkKQEAgLTEyNSw5ICsxMjUs
MyBAQCB2YWwgcmVzcG9uZF90b19vcHRpb25zIDogSHR0cC5SZXF1ZXN0LnQg
LT4gVW5peC5maWxlX2Rlc2NyIC0+IHVuaXQKIHZhbCBoZWFkZXJzIDogVW5p
eC5maWxlX2Rlc2NyIC0+IHN0cmluZyBsaXN0IC0+IHVuaXQKIAogdmFsIHJl
YWRfYm9keSA6ID9saW1pdDppbnQgLT4gSHR0cC5SZXF1ZXN0LnQgLT4gQnVm
X2lvLnQgLT4gc3RyaW5nCi0KLXZhbCByZXF1ZXN0X29mX2JpbyA6Ci0gICAg
ID91c2VfZmFzdHBhdGg6Ym9vbAotICAtPiA/cHJveHlfc2VlbjpzdHJpbmcK
LSAgLT4gQnVmX2lvLnQKLSAgLT4gSHR0cC5SZXF1ZXN0LnQgb3B0aW9uICog
c3RyaW5nIG9wdGlvbgotLSAKMi4zMS4xCgo=

--=separator
Content-Type: application/octet-stream; name="xsa413/xsa413-2.patch"
Content-Disposition: attachment; filename="xsa413/xsa413-2.patch"
Content-Transfer-Encoding: base64

RnJvbSBkYjM5N2IwYzU0NDA1ZWQyMzQxYjY1NjJkZjFjNWE5ZjRlYzhhODI3
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgSG9lcyA8cm9i
LmhvZXNAY2l0cml4LmNvbT4KRGF0ZTogVGh1LCA3IEp1bCAyMDIyIDE0OjAw
OjAwICswMDAwClN1YmplY3Q6IFtQQVRDSCAyLzZdIGh0dHAtc3ZyOiByZW1v
dmUgInNsb3cgcGF0aCIKCkV2ZXJ5dGhpbmcgZXhjZXB0IGEgdGVzdCBhbHJl
YWR5IHVzZWQgdGhlICJmYXN0IHBhdGgiLCBzbyB0aGUgc2xvdwp2ZXJzaW9u
IHdhcyB2aXJ0dWFsbHkgdW51c2VkIChhbmQgc2xvdykuCgpBbHNvIHJlbW92
ZXMgc29tZSBvdGhlciBkZWFkIGNvZGUuCgpTaWduZWQtb2ZmLWJ5OiBSb2Ig
SG9lcyA8cm9iLmhvZXNAY2l0cml4LmNvbT4KLS0tCiBvY2FtbC9saWJzL2h0
dHAtc3ZyL2h0dHAubWwgICAgICAgICB8ICAgMiAtCiBvY2FtbC9saWJzL2h0
dHAtc3ZyL2h0dHAubWxpICAgICAgICB8ICAgMiAtCiBvY2FtbC9saWJzL2h0
dHAtc3ZyL2h0dHBfc3ZyLm1sICAgICB8IDE0MCArLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tCiBvY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1s
aSAgICB8ICAgNSAtCiBvY2FtbC9saWJzL2h0dHAtc3ZyL3Rlc3Rfc2VydmVy
Lm1sICB8ICAgNyArLQogb2NhbWwveGFwaS94YXBpX2h0dHAubWwgICAgICAg
ICAgICAgfCAgIDEgLQogb2NhbWwveGNwLXJyZGQvYmluL3JyZGQveGNwX3Jy
ZGQubWwgfCAgIDEgLQogNyBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMo
KyksIDE1MyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9vY2FtbC9saWJz
L2h0dHAtc3ZyL2h0dHAubWwgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAu
bWwKaW5kZXggNTBlNDQ2NTczLi40YmNhMGYyZjEgMTAwNjQ0Ci0tLSBhL29j
YW1sL2xpYnMvaHR0cC1zdnIvaHR0cC5tbAorKysgYi9vY2FtbC9saWJzL2h0
dHAtc3ZyL2h0dHAubWwKQEAgLTM0OCw4ICszNDgsNiBAQCBsZXQgcmVhZF91
cF90byBidWYgYWxyZWFkeV9yZWFkIG1hcmtlciBmZCA9CiAgIGRvbmUgOwog
ICAhYgogCi1sZXQgcmVhZF9odHRwX2hlYWRlciBidWYgZmQgPSByZWFkX3Vw
X3RvIGJ1ZiAwIGVuZF9vZl9oZWFkZXJzIGZkCi0KIGxldCBzbWFsbGVzdF9y
ZXF1ZXN0ID0gIkdFVCAvIEhUVFAvMS4wXHJcblxyXG4iCiAKICgqIGxldCBz
bWFsbGVzdF9yZXNwb25zZSA9ICJIVFRQLzEuMCAyMDAgT0tcclxuXHJcbiIg
KikKZGlmZiAtLWdpdCBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cC5tbGkg
Yi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAubWxpCmluZGV4IGMyNGE0MzJl
OS4uNzQ2M2RkNWYyIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3Zy
L2h0dHAubWxpCisrKyBiL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cC5tbGkK
QEAgLTMwLDggKzMwLDYgQEAgZXhjZXB0aW9uIEZvcmJpZGRlbgogCiB0eXBl
IGF1dGhvcml6YXRpb24gPSBCYXNpYyBvZiBzdHJpbmcgKiBzdHJpbmcgfCBV
bmtub3duQXV0aCBvZiBzdHJpbmcKIAotdmFsIHJlYWRfaHR0cF9oZWFkZXIg
OiBieXRlcyAtPiBVbml4LmZpbGVfZGVzY3IgLT4gaW50Ci0KIHZhbCBtYWtl
X2ZyYW1lX2hlYWRlciA6IHN0cmluZyAtPiBzdHJpbmcKIAogdmFsIHJlYWRf
aHR0cF9yZXF1ZXN0X2hlYWRlciA6IFVuaXguZmlsZV9kZXNjciAtPiBib29s
ICogc3RyaW5nICogc3RyaW5nIG9wdGlvbgpkaWZmIC0tZ2l0IGEvb2NhbWwv
bGlicy9odHRwLXN2ci9odHRwX3N2ci5tbCBiL29jYW1sL2xpYnMvaHR0cC1z
dnIvaHR0cF9zdnIubWwKaW5kZXggNzFlZDBmMWU3Li40YzU2ZjViZTAgMTAw
NjQ0Ci0tLSBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWwKKysr
IGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbApAQCAtMjUzLDEy
ICsyNTMsMTAgQEAgZW5kKQogbW9kdWxlIFNlcnZlciA9IHN0cnVjdAogICB0
eXBlICdhIHQgPSB7CiAgICAgICBtdXRhYmxlIGhhbmRsZXJzOiAnYSBURS50
IFJhZGl4X3RyZWUudCBNZXRob2RNYXAudAotICAgIDsgbXV0YWJsZSB1c2Vf
ZmFzdHBhdGg6IGJvb2wKICAgICA7IGRlZmF1bHRfY29udGV4dDogJ2EKICAg
fQogCi0gIGxldCBlbXB0eSBkZWZhdWx0X2NvbnRleHQgPQotICAgIHtoYW5k
bGVycz0gTWV0aG9kTWFwLmVtcHR5OyB1c2VfZmFzdHBhdGg9IGZhbHNlOyBk
ZWZhdWx0X2NvbnRleHR9CisgIGxldCBlbXB0eSBkZWZhdWx0X2NvbnRleHQg
PSB7aGFuZGxlcnM9IE1ldGhvZE1hcC5lbXB0eTsgZGVmYXVsdF9jb250ZXh0
fQogCiAgIGxldCBhZGRfaGFuZGxlciB4IHR5IHVyaSBoYW5kbGVyID0KICAg
ICBsZXQgZXhpc3RpbmcgPQpAQCAtMjg0LDggKzI4Miw2IEBAIG1vZHVsZSBT
ZXJ2ZXIgPSBzdHJ1Y3QKICAgICBNZXRob2RNYXAuZm9sZAogICAgICAgKGZ1
biBtIHJ0IGFjYyAtPiBmb2xkIChmdW4gayB0ZSBhY2MgLT4gKG0sIGssIHRl
LlRFLnN0YXRzKSA6OiBhY2MpIGFjYyBydCkKICAgICAgIHguaGFuZGxlcnMg
W10KLQotICBsZXQgZW5hYmxlX2Zhc3RwYXRoIHggPSB4LnVzZV9mYXN0cGF0
aCA8LSB0cnVlCiBlbmQKIAogbGV0IGVzY2FwZSB1cmkgPQpAQCAtMzEyLDEy
MSArMzA4LDEwIEBAIGxldCBlc2NhcGUgdXJpID0KICAgICAgIF0KICAgICB1
cmkKIAotZXhjZXB0aW9uIFRvb19tYW55X2hlYWRlcnMKLQogZXhjZXB0aW9u
IEdlbmVyaWNfZXJyb3Igb2Ygc3RyaW5nCiAKLWxldCByZXF1ZXN0X29mX2Jp
b19leG5fc2xvdyBpYyA9Ci0gICgqIFRyeSB0byBrZWVwIHRoZSBjb25uZWN0
aW9uIG9wZW4gZm9yIGEgd2hpbGUgdG8gcHJldmVudCBzcHVyaW91cyBFbmRf
b2ZfZmlsZSB0eXBlCi0gICAgIAkgICBwcm9ibGVtcyB1bmRlciBsb2FkICop
Ci0gIGxldCBpbml0aWFsX3RpbWVvdXQgPSA1LiAqLiA2MC4gaW4KLSAgbGV0
IGNvbnRlbnRfbGVuZ3RoID0gcmVmICgtMUwpIGluCi0gIGxldCBjb29raWUg
PSByZWYgIiIgaW4KLSAgbGV0IHRyYW5zZmVyX2VuY29kaW5nID0gcmVmIE5v
bmUgaW4KLSAgbGV0IGFjY2VwdCA9IHJlZiBOb25lIGluCi0gIGxldCBhdXRo
ID0gcmVmIE5vbmUgaW4KLSAgbGV0IHRhc2sgPSByZWYgTm9uZSBpbgotICBs
ZXQgc3VidGFza19vZiA9IHJlZiBOb25lIGluCi0gIGxldCBjb250ZW50X3R5
cGUgPSByZWYgTm9uZSBpbgotICBsZXQgaG9zdCA9IHJlZiBOb25lIGluCi0g
IGxldCB1c2VyX2FnZW50ID0gcmVmIE5vbmUgaW4KLSAgY29udGVudF9sZW5n
dGggOj0gLTFMIDsKLSAgY29va2llIDo9ICIiIDsKLSAgbGV0IHJlcSA9Ci0g
ICAgQnVmX2lvLmlucHV0X2xpbmUgfnRpbWVvdXQ6aW5pdGlhbF90aW1lb3V0
IGljCi0gICAgfD4gQnl0ZXMudG9fc3RyaW5nCi0gICAgfD4gUmVxdWVzdC5v
Zl9yZXF1ZXN0X2xpbmUKLSAgaW4KLSAgKCogRGVmYXVsdCBmb3IgSFRUUC8x
LjEgaXMgcGVyc2lzdGVudCBjb25uZWN0aW9ucy4gQW55dGhpbmcgZWxzZSBj
bG9zZXMgKikKLSAgKCogdGhlIGNoYW5uZWwgYXMgc29vbiBhcyB0aGUgcmVx
dWVzdCBpcyBwcm9jZXNzZWQgKikKLSAgaWYgcmVxLlJlcXVlc3QudmVyc2lv
biA8PiAiMS4xIiB0aGVuIHJlcS5SZXF1ZXN0LmNsb3NlIDwtIHRydWUgOwot
ICBsZXQgcmVjIHJlYWRfcmVzdF9vZl9oZWFkZXJzIGxlZnQgPQotICAgIGxl
dCBjbF9oZHIgPSBsb3dlcmNhc2UgSHR0cC5IZHIuY29udGVudF9sZW5ndGgg
aW4KLSAgICBsZXQgY29va2llX2hkciA9IGxvd2VyY2FzZSBIdHRwLkhkci5j
b29raWUgaW4KLSAgICBsZXQgY29ubmVjdGlvbl9oZHIgPSBsb3dlcmNhc2Ug
SHR0cC5IZHIuY29ubmVjdGlvbiBpbgotICAgIGxldCB0cmFuc2Zlcl9lbmNv
ZGluZ19oZHIgPSBsb3dlcmNhc2UgSHR0cC5IZHIudHJhbnNmZXJfZW5jb2Rp
bmcgaW4KLSAgICBsZXQgYWNjZXB0X2hkciA9IGxvd2VyY2FzZSBIdHRwLkhk
ci5hY2NlcHQgaW4KLSAgICBsZXQgYXV0aF9oZHIgPSBsb3dlcmNhc2UgSHR0
cC5IZHIuYXV0aG9yaXphdGlvbiBpbgotICAgIGxldCB0YXNrX2hkciA9IGxv
d2VyY2FzZSBIdHRwLkhkci50YXNrX2lkIGluCi0gICAgbGV0IHN1YnRhc2tf
b2ZfaGRyID0gbG93ZXJjYXNlIEh0dHAuSGRyLnN1YnRhc2tfb2YgaW4KLSAg
ICBsZXQgY29udGVudF90eXBlX2hkciA9IGxvd2VyY2FzZSBIdHRwLkhkci5j
b250ZW50X3R5cGUgaW4KLSAgICBsZXQgaG9zdF9oZHIgPSBsb3dlcmNhc2Ug
SHR0cC5IZHIuaG9zdCBpbgotICAgIGxldCB1c2VyX2FnZW50X2hkciA9IGxv
d2VyY2FzZSBIdHRwLkhkci51c2VyX2FnZW50IGluCi0gICAgbGV0IHIgPQot
ICAgICAgQnVmX2lvLmlucHV0X2xpbmUgfnRpbWVvdXQ6QnVmX2lvLmluZmlu
aXRlX3RpbWVvdXQgaWMgfD4gQnl0ZXMudG9fc3RyaW5nCi0gICAgaW4KLSAg
ICBtYXRjaCBBc3RyaW5nLlN0cmluZy5jdXQgfnNlcDoiOiIgciB3aXRoCi0g
ICAgfCBTb21lIChrLCB2KSAtPgotICAgICAgICBsZXQgayA9IGxvd2VyY2Fz
ZSBrIGluCi0gICAgICAgIGxldCB2ID0gU3RyaW5nLnRyaW0gdiBpbgotICAg
ICAgICBsZXQgYWJzb3JiZWQgPQotICAgICAgICAgIG1hdGNoIGsgd2l0aAot
ICAgICAgICAgIHwgayB3aGVuIGsgPSBjbF9oZHIgLT4KLSAgICAgICAgICAg
ICAgY29udGVudF9sZW5ndGggOj0gSW50NjQub2Zfc3RyaW5nIHYgOwotICAg
ICAgICAgICAgICB0cnVlCi0gICAgICAgICAgfCBrIHdoZW4gayA9IGNvb2tp
ZV9oZHIgLT4KLSAgICAgICAgICAgICAgY29va2llIDo9IHYgOwotICAgICAg
ICAgICAgICB0cnVlCi0gICAgICAgICAgfCBrIHdoZW4gayA9IHRyYW5zZmVy
X2VuY29kaW5nX2hkciAtPgotICAgICAgICAgICAgICB0cmFuc2Zlcl9lbmNv
ZGluZyA6PSBTb21lIHYgOwotICAgICAgICAgICAgICB0cnVlCi0gICAgICAg
ICAgfCBrIHdoZW4gayA9IGFjY2VwdF9oZHIgLT4KLSAgICAgICAgICAgICAg
YWNjZXB0IDo9IFNvbWUgdiA7Ci0gICAgICAgICAgICAgIHRydWUKLSAgICAg
ICAgICB8IGsgd2hlbiBrID0gYXV0aF9oZHIgLT4KLSAgICAgICAgICAgICAg
YXV0aCA6PSBTb21lIChhdXRob3JpemF0aW9uX29mX3N0cmluZyB2KSA7Ci0g
ICAgICAgICAgICAgIHRydWUKLSAgICAgICAgICB8IGsgd2hlbiBrID0gdGFz
a19oZHIgLT4KLSAgICAgICAgICAgICAgdGFzayA6PSBTb21lIHYgOwotICAg
ICAgICAgICAgICB0cnVlCi0gICAgICAgICAgfCBrIHdoZW4gayA9IHN1YnRh
c2tfb2ZfaGRyIC0+Ci0gICAgICAgICAgICAgIHN1YnRhc2tfb2YgOj0gU29t
ZSB2IDsKLSAgICAgICAgICAgICAgdHJ1ZQotICAgICAgICAgIHwgayB3aGVu
IGsgPSBjb250ZW50X3R5cGVfaGRyIC0+Ci0gICAgICAgICAgICAgIGNvbnRl
bnRfdHlwZSA6PSBTb21lIHYgOwotICAgICAgICAgICAgICB0cnVlCi0gICAg
ICAgICAgfCBrIHdoZW4gayA9IGhvc3RfaGRyIC0+Ci0gICAgICAgICAgICAg
IGhvc3QgOj0gU29tZSB2IDsKLSAgICAgICAgICAgICAgdHJ1ZQotICAgICAg
ICAgIHwgayB3aGVuIGsgPSB1c2VyX2FnZW50X2hkciAtPgotICAgICAgICAg
ICAgICB1c2VyX2FnZW50IDo9IFNvbWUgdiA7Ci0gICAgICAgICAgICAgIHRy
dWUKLSAgICAgICAgICB8IGsgd2hlbiBrID0gY29ubmVjdGlvbl9oZHIgLT4K
LSAgICAgICAgICAgICAgcmVxLlJlcXVlc3QuY2xvc2UgPC0gbG93ZXJjYXNl
IHYgPSAiY2xvc2UiIDsKLSAgICAgICAgICAgICAgdHJ1ZQotICAgICAgICAg
IHwgXyAtPgotICAgICAgICAgICAgICBmYWxzZQotICAgICAgICBpbgotICAg
ICAgICBpZiAobm90IGFic29yYmVkKSAmJiBsZWZ0IDw9IDAgdGhlbiByYWlz
ZSBUb29fbWFueV9oZWFkZXJzIDsKLSAgICAgICAgaWYgYWJzb3JiZWQgdGhl
bgotICAgICAgICAgIHJlYWRfcmVzdF9vZl9oZWFkZXJzIChsZWZ0IC0gMSkK
LSAgICAgICAgZWxzZQotICAgICAgICAgIChrLCB2KSA6OiByZWFkX3Jlc3Rf
b2ZfaGVhZGVycyAobGVmdCAtIDEpCi0gICAgfCBOb25lIC0+Ci0gICAgICAg
IFtdCi0gIGluCi0gIGxldCBoZWFkZXJzID0gcmVhZF9yZXN0X29mX2hlYWRl
cnMgMjQyIGluCi0gIGxldCByZXF1ZXN0ID0KLSAgICB7Ci0gICAgICByZXEg
d2l0aAotICAgICAgUmVxdWVzdC5jb29raWU9IEh0dHAucGFyc2Vfa2V5dmFs
cGFpcnMgIWNvb2tpZQotICAgIDsgY29udGVudF9sZW5ndGg9Ci0gICAgICAg
IChpZiAhY29udGVudF9sZW5ndGggPSAtMUwgdGhlbiBOb25lIGVsc2UgU29t
ZSAhY29udGVudF9sZW5ndGgpCi0gICAgOyBhdXRoPSAhYXV0aAotICAgIDsg
dGFzaz0gIXRhc2sKLSAgICA7IHN1YnRhc2tfb2Y9ICFzdWJ0YXNrX29mCi0g
ICAgOyBjb250ZW50X3R5cGU9ICFjb250ZW50X3R5cGUKLSAgICA7IGhvc3Q9
ICFob3N0Ci0gICAgOyB1c2VyX2FnZW50PSAhdXNlcl9hZ2VudAotICAgIDsg
YWRkaXRpb25hbF9oZWFkZXJzPSBoZWFkZXJzCi0gICAgOyBhY2NlcHQ9ICFh
Y2NlcHQKLSAgICB9Ci0gIGluCi0gIChyZXF1ZXN0LCBOb25lKQotCiAoKiog
W3JlcXVlc3Rfb2ZfYmlvX2V4biBpY10gcmVhZHMgYSBzaW5nbGUgSHR0cC5y
ZXEgZnJvbSBbaWNdIGFuZCByZXR1cm5zIGl0LiBPbiBlcnJvcgogICAgIAlp
dCBzaW1wbHkgdGhyb3dzIGFuIGV4Y2VwdGlvbiBhbmQgZG9lc24ndCB0b3Vj
aCB0aGUgb3V0cHV0IHN0cmVhbS4gKikKLQogbGV0IHJlcXVlc3Rfb2ZfYmlv
X2V4biB+cHJveHlfc2VlbiBiaW8gPQogICBsZXQgZmQgPSBCdWZfaW8uZmRf
b2YgYmlvIGluCiAgIGxldCBmcmFtZSwgaGVhZGVycywgcHJveHknID0gSHR0
cC5yZWFkX2h0dHBfcmVxdWVzdF9oZWFkZXIgZmQgaW4KQEAgLTUwNSwyMCAr
MzkwLDkgQEAgbGV0IHJlcXVlc3Rfb2ZfYmlvX2V4biB+cHJveHlfc2VlbiBi
aW8gPQogCiAoKiogW3JlcXVlc3Rfb2ZfYmlvIGljXSByZXR1cm5zIFtTb21l
IHJlcV0gcmVhZCBmcm9tIFtpY10sIG9yIFtOb25lXS4gSWYgW05vbmVdIGl0
IHdpbGwgaGF2ZQogICAgIAlhbHJlYWR5IHNlbnQgYmFjayBhIHN1aXRhYmxl
IGVycm9yIGNvZGUgYW5kIHJlc3BvbnNlIHRvIHRoZSBjbGllbnQuICopCi1s
ZXQgcmVxdWVzdF9vZl9iaW8gPyh1c2VfZmFzdHBhdGggPSBmYWxzZSkgP3By
b3h5X3NlZW4gaWMgPQorbGV0IHJlcXVlc3Rfb2ZfYmlvID9wcm94eV9zZWVu
IGljID0KICAgdHJ5Ci0gICAgbGV0IHIsIHByb3h5ID0KLSAgICAgICggaWYg
dXNlX2Zhc3RwYXRoIHRoZW4KLSAgICAgICAgICByZXF1ZXN0X29mX2Jpb19l
eG4gfnByb3h5X3NlZW4KLSAgICAgIGVsc2UKLSAgICAgICAgcmVxdWVzdF9v
Zl9iaW9fZXhuX3Nsb3cKLSAgICAgICkKLSAgICAgICAgaWMKLSAgICBpbgot
ICAgICgqCi0JCVByaW50Zi5mcHJpbnRmIHN0ZGVyciAiUGFyc2VkIFslc11c
biIgKEh0dHAuUmVxdWVzdC50b193aXJlX3N0cmluZyByKTsKLQkJZmx1c2gg
c3RkZXJyOwotKikKKyAgICBsZXQgciwgcHJveHkgPSByZXF1ZXN0X29mX2Jp
b19leG4gfnByb3h5X3NlZW4gaWMgaW4KICAgICAoU29tZSByLCBwcm94eSkK
ICAgd2l0aCBlIC0+CiAgICAgRC53YXJuICIlcyAoJXMpIiAoUHJpbnRleGMu
dG9fc3RyaW5nIGUpIF9fTE9DX18gOwpAQCAtNTMwLDEwICs0MDQsNiBAQCBs
ZXQgcmVxdWVzdF9vZl9iaW8gPyh1c2VfZmFzdHBhdGggPSBmYWxzZSkgP3By
b3h5X3NlZW4gaWMgPQogICAgICAgICAgICAgcmVzcG9uc2VfaW50ZXJuYWxf
ZXJyb3Igc3MKICAgICAgICAgICAgICAgfmV4dHJhOiJUaGUgSFRUUCBoZWFk
ZXJzIGNvdWxkIG5vdCBiZSBwYXJzZWQuIiA7CiAgICAgICAgICAgICBkZWJ1
ZyAiRXJyb3IgcGFyc2luZyBIVFRQIGhlYWRlcnMiCi0gICAgICAgIHwgVG9v
X21hbnlfaGVhZGVycyAtPgotICAgICAgICAgICAgKCogZG9uJ3QgbG9nIGFu
eXRoaW5nLCBzaW5jZSBpdCBjb3VsZCBmaWxsIHRoZSBsb2cgKikKLSAgICAg
ICAgICAgIHJlc3BvbnNlX2ludGVybmFsX2Vycm9yIHNzCi0gICAgICAgICAg
ICAgIH5leHRyYToiVG9vIG1hbnkgSFRUUCBoZWFkZXJzIHdlcmUgcmVjZWl2
ZWQuIgogICAgICAgICB8IEJ1Zl9pby5UaW1lb3V0IC0+CiAgICAgICAgICAg
ICAoKQogICAgICAgICAoKiBJZGxlIGNvbm5lY3Rpb24gY2xvc2VkLiBOQiBp
bmZpbml0ZSB0aW1lb3V0IHVzZWQgd2hlbiBoZWFkZXJzIGFyZSBiZWluZyBy
ZWFkICopCkBAIC02MjMsOSArNDkzLDcgQEAgbGV0IGhhbmRsZV9jb25uZWN0
aW9uICh4IDogJ2EgU2VydmVyLnQpIF8gc3MgPQogICAgICBhbG9uZyBpbiB0
aGUgbG9vcCBiZWxvdy4gKikKICAgbGV0IHJlYyBsb29wIHByb3h5X3NlZW4g
PQogICAgICgqIDEuIHdlIG11c3Qgc3VjY2Vzc2Z1bGx5IHBhcnNlIGEgcmVx
dWVzdCAqKQotICAgIGxldCByZXEsIHByb3h5ID0KLSAgICAgIHJlcXVlc3Rf
b2ZfYmlvIH51c2VfZmFzdHBhdGg6eC5TZXJ2ZXIudXNlX2Zhc3RwYXRoID9w
cm94eV9zZWVuIGljCi0gICAgaW4KKyAgICBsZXQgcmVxLCBwcm94eSA9IHJl
cXVlc3Rfb2ZfYmlvID9wcm94eV9zZWVuIGljIGluCiAgICAgKCogMi4gbm93
IHdlIGF0dGVtcHQgdG8gcHJvY2VzcyB0aGUgcmVxdWVzdCAqKQogICAgIGxl
dCBmaW5pc2hlZCA9CiAgICAgICBPcHRpb24uZm9sZCB+bm9uZTp0cnVlCmRp
ZmYgLS1naXQgYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1saSBi
L29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpCmluZGV4IDZkOTAz
MmZmNC4uMzc4MWM3ZWVlIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAt
c3ZyL2h0dHBfc3ZyLm1saQorKysgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0
dHBfc3ZyLm1saQpAQCAtNDgsMTMgKzQ4LDggQEAgbW9kdWxlIFNlcnZlciA6
IHNpZwogCiAgIHZhbCBhbGxfc3RhdHMgOiAnYSB0IC0+IChIdHRwLm1ldGhv
ZF90ICogdXJpX3BhdGggKiBTdGF0cy50KSBsaXN0CiAgICgqKiBbYWxsX3N0
YXRzIHhdIHJldHVybnMgYSBsaXN0IG9mIChtZXRob2QsIHVyaSwgc3RhdHMp
IHRyaXBsZXMgKikKLQotICB2YWwgZW5hYmxlX2Zhc3RwYXRoIDogJ2EgdCAt
PiB1bml0Ci0gICgqKiBbZW5hYmxlX2Zhc3RwYXRoIHhdIHN3aXRjaGVzIG9u
IGV4cGVyaW1lbnRhbCBwZXJmb3JtYW5jZSBvcHRpbWlzYXRpb25zICopCiBl
bmQKIAotZXhjZXB0aW9uIFRvb19tYW55X2hlYWRlcnMKLQogZXhjZXB0aW9u
IEdlbmVyaWNfZXJyb3Igb2Ygc3RyaW5nCiAKIHR5cGUgc29ja2V0CmRpZmYg
LS1naXQgYS9vY2FtbC9saWJzL2h0dHAtc3ZyL3Rlc3Rfc2VydmVyLm1sIGIv
b2NhbWwvbGlicy9odHRwLXN2ci90ZXN0X3NlcnZlci5tbAppbmRleCAxMjc2
YTdkYzcuLjJiMzk4Y2ZhNyAxMDA2NDQKLS0tIGEvb2NhbWwvbGlicy9odHRw
LXN2ci90ZXN0X3NlcnZlci5tbAorKysgYi9vY2FtbC9saWJzL2h0dHAtc3Zy
L3Rlc3Rfc2VydmVyLm1sCkBAIC0xMCwxNyArMTAsMTIgQEAgbGV0IGZpbmlz
aGVkX2MgPSBDb25kaXRpb24uY3JlYXRlICgpCiAKIGxldCBfID0KICAgbGV0
IHBvcnQgPSByZWYgODA4MCBpbgotICBsZXQgdXNlX2Zhc3RwYXRoID0gcmVm
IGZhbHNlIGluCiAgIEFyZy5wYXJzZQotICAgIFsKLSAgICAgICgiLXAiLCBB
cmcuU2V0X2ludCBwb3J0LCAicG9ydCB0byBsaXN0ZW4gb24iKQotICAgIDsg
KCItZmFzdCIsIEFyZy5TZXQgdXNlX2Zhc3RwYXRoLCAidXNlIEhUVFAgZmFz
dHBhdGgiKQotICAgIF0KKyAgICBbKCItcCIsIEFyZy5TZXRfaW50IHBvcnQs
ICJwb3J0IHRvIGxpc3RlbiBvbiIpXQogICAgIChmdW4geCAtPiBQcmludGYu
ZnByaW50ZiBzdGRlcnIgIklnbm9yaW5nIHVuZXhwZWN0ZWQgYXJndW1lbnQ6
ICVzXG4iIHgpCiAgICAgIkEgc2ltcGxlIHRlc3QgSFRUUCBzZXJ2ZXIiIDsK
ICAgbGV0IG9wZW4gSHR0cF9zdnIgaW4KICAgbGV0IHNlcnZlciA9IFNlcnZl
ci5lbXB0eSAoKSBpbgotICBpZiAhdXNlX2Zhc3RwYXRoIHRoZW4gU2VydmVy
LmVuYWJsZV9mYXN0cGF0aCBzZXJ2ZXIgOwogICBTZXJ2ZXIuYWRkX2hhbmRs
ZXIgc2VydmVyIEh0dHAuR2V0ICIvc3RvcCIKICAgICAoRmRJTwogICAgICAg
IChmdW4gXyBzIF8gLT4KZGlmZiAtLWdpdCBhL29jYW1sL3hhcGkveGFwaV9o
dHRwLm1sIGIvb2NhbWwveGFwaS94YXBpX2h0dHAubWwKaW5kZXggMmM1NGE4
ZDQyLi45ZWVlNDZjM2YgMTAwNjQ0Ci0tLSBhL29jYW1sL3hhcGkveGFwaV9o
dHRwLm1sCisrKyBiL29jYW1sL3hhcGkveGFwaV9odHRwLm1sCkBAIC0yODIs
NyArMjgyLDYgQEAgbGV0IHdpdGhfY29udGV4dCA/KGR1bW15ID0gZmFsc2Up
IGxhYmVsIChyZXEgOiBSZXF1ZXN0LnQpIChzIDogVW5peC5maWxlX2Rlc2Ny
KQogCiBsZXQgc2VydmVyID0KICAgbGV0IHNlcnZlciA9IEh0dHBfc3ZyLlNl
cnZlci5lbXB0eSAoKSBpbgotICBIdHRwX3N2ci5TZXJ2ZXIuZW5hYmxlX2Zh
c3RwYXRoIHNlcnZlciA7CiAgIHNlcnZlcgogCiBsZXQgaHR0cF9yZXF1ZXN0
ID0gSHR0cC5SZXF1ZXN0Lm1ha2UgfnVzZXJfYWdlbnQ6Q29uc3RhbnRzLnhh
cGlfdXNlcl9hZ2VudApkaWZmIC0tZ2l0IGEvb2NhbWwveGNwLXJyZGQvYmlu
L3JyZGQveGNwX3JyZGQubWwgYi9vY2FtbC94Y3AtcnJkZC9iaW4vcnJkZC94
Y3BfcnJkZC5tbAppbmRleCBmYTY3OTE4NDIuLjQ5ZGM3NDEzMSAxMDA2NDQK
LS0tIGEvb2NhbWwveGNwLXJyZGQvYmluL3JyZGQveGNwX3JyZGQubWwKKysr
IGIvb2NhbWwveGNwLXJyZGQvYmluL3JyZGQveGNwX3JyZGQubWwKQEAgLTc0
LDcgKzc0LDYgQEAgbGV0IGFjY2VwdF9mb3JldmVyIHNvY2sgZiA9CiAoKiBC
aW5kIHNlcnZlciB0byB0aGUgZmlsZSBkZXNjcmlwdG9yLiAqKQogbGV0IHN0
YXJ0ICh4bWxycGNfcGF0aCwgaHR0cF9md2RfcGF0aCkgcHJvY2VzcyA9CiAg
IGxldCBzZXJ2ZXIgPSBIdHRwX3N2ci5TZXJ2ZXIuZW1wdHkgKCkgaW4KLSAg
SHR0cF9zdnIuU2VydmVyLmVuYWJsZV9mYXN0cGF0aCBzZXJ2ZXIgOwogICBs
ZXQgb3BlbiBScmRkX2h0dHBfaGFuZGxlciBpbgogICBIdHRwX3N2ci5TZXJ2
ZXIuYWRkX2hhbmRsZXIgc2VydmVyIEh0dHAuUG9zdCAiLyIKICAgICAoSHR0
cF9zdnIuQnVmSU8gKHhtbHJwY19oYW5kbGVyIHByb2Nlc3MpKSA7Ci0tIAoy
LjMxLjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa413/xsa413-3.patch"
Content-Disposition: attachment; filename="xsa413/xsa413-3.patch"
Content-Transfer-Encoding: base64

RnJvbSBjYjI0NTBjZjE2YTgwNDM4ODk4Yzc4Y2FjYjU5ZjJmMWUzYWE5NGJl
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgSG9lcyA8cm9i
LmhvZXNAY2l0cml4LmNvbT4KRGF0ZTogTW9uLCAxMSBKdWwgMjAyMiAxNjoy
ODoyMSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggMy82XSBMaW1pdCBjb25jdXJy
ZW50IGNvbm5lY3Rpb25zIHdpdGggc2VtYXBob3JlCgpUbyBhZGQgc29tZSBw
cm90ZWN0aW9uIGFnYWluc3Qgb3ZlcmxvYWRpbmcgdGhlIHNlcnZlciwgYW5k
IHJ1bm5pbmcgb3V0Cm9mIGZpbGUgZGVzY3JpcHRvcnMgYW5kIG90aGVyIHJl
c291cmNlcywgdGhlIG51bWJlciBvZiBjb25jdXJyZW50CmNvbm5lY3Rpb25z
IGlzIG5vdyBsaW1pdGVkIHRvIDgwMCBieSBkZWZhdWx0LiBDb25uZWN0aW9u
cyBjb21pbmcgaW4gd2hlbgp0aGUgbGltaXQgaGFzIGJlZW4gcmVhY2hlZCBh
cmUgcHV0IG9uIGhvbGQsIGFuZCBub3QgYWNjZXB0ZWQgdW50aWwKYW5vdGhl
ciBjb25uZWN0aW9uIGZpbmlzaGVzLgoKVGhlcmUgYXJlIHRocmVlIHNlcGFy
YXRlIGJ1Y2tldHMgZm9yIGNvbm5lY3Rpb25zIHRvIHRoZSBtYWluIHVuaXgK
c29ja2V0LCB0aGUgY2xpZW50LWNlcnQgKHVuaXgpIHNvY2tldCBhbmQgdGhl
IFRDUCBzb2NrZXQuCgpUaGlzIGFsc28gYWRkIHNvbWUgbW9yZSBkZWJ1ZyBs
b2dnaW5nIHdoZW4gY29ubmVjdGlvbnMgYXJlIGFjY2VwdGVkIGFuZApkaXNj
b25uZWN0ZWQuIFRoaXMgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdCBhbG9uZyB3
aXRoIG90aGVyICJodHRwIiBsb2dzLApidXQgY2FuIGJlIGVuYWJsZWQgaW4g
dGhlIGNvbmYgZmlsZS4KClNpZ25lZC1vZmYtYnk6IFJvYiBIb2VzIDxyb2Iu
aG9lc0BjaXRyaXguY29tPgotLS0KIG9jYW1sL2RhdGFiYXNlL2RhdGFiYXNl
X3NlcnZlcl9tYWluLm1sIHwgIDIgKy0KIG9jYW1sL2xpYnMvaHR0cC1zdnIv
aHR0cF9zdnIubWwgICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKysrKysr
Ky0tLS0KIG9jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpICAgICAg
IHwgIDIgKy0KIG9jYW1sL2xpYnMvaHR0cC1zdnIvc2VydmVyX2lvLm1sICAg
ICAgIHwgMTcgKysrKysrKysrKystLS0tLS0KIG9jYW1sL2xpYnMvaHR0cC1z
dnIvc2VydmVyX2lvLm1saSAgICAgIHwgIDEgKwogb2NhbWwvbGlicy9odHRw
LXN2ci90ZXN0X3NlcnZlci5tbCAgICAgfCAgMiArLQogb2NhbWwveGFwaS94
YXBpLm1sICAgICAgICAgICAgICAgICAgICAgfCAgNiArKysrKy0KIG9jYW1s
L3hhcGkveGFwaV9nbG9icy5tbCAgICAgICAgICAgICAgIHwgIDkgKysrKysr
KysrCiBvY2FtbC94YXBpL3hhcGlfbWdtdF9pZmFjZS5tbCAgICAgICAgICB8
ICA3ICsrKysrLS0KIG9jYW1sL3hjcC1ycmRkL2Jpbi9ycmRkL3hjcF9ycmRk
Lm1sICAgIHwgIDIgKy0KIDEwIGZpbGVzIGNoYW5nZWQsIDU3IGluc2VydGlv
bnMoKyksIDE3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL29jYW1sL2Rh
dGFiYXNlL2RhdGFiYXNlX3NlcnZlcl9tYWluLm1sIGIvb2NhbWwvZGF0YWJh
c2UvZGF0YWJhc2Vfc2VydmVyX21haW4ubWwKaW5kZXggOTc3OGU0YTM5Li40
ODA5YmM3ZmQgMTAwNjQ0Ci0tLSBhL29jYW1sL2RhdGFiYXNlL2RhdGFiYXNl
X3NlcnZlcl9tYWluLm1sCisrKyBiL29jYW1sL2RhdGFiYXNlL2RhdGFiYXNl
X3NlcnZlcl9tYWluLm1sCkBAIC04MSw3ICs4MSw3IEBAIGxldCBfID0KICAg
ICAgICAgICAoSHR0cF9zdnIuQnVmSU8gcmVtb3RlX2RhdGFiYXNlX2FjY2Vz
c19oYW5kbGVyX3YxKSA7CiAgICAgICAgIEh0dHBfc3ZyLlNlcnZlci5hZGRf
aGFuZGxlciBzZXJ2ZXIgSHR0cC5Qb3N0ICIvcG9zdF9yZW1vdGVfZGJfYWNj
ZXNzX3YyIgogICAgICAgICAgIChIdHRwX3N2ci5CdWZJTyByZW1vdGVfZGF0
YWJhc2VfYWNjZXNzX2hhbmRsZXJfdjIpIDsKLSAgICAgICAgSHR0cF9zdnIu
c3RhcnQgc2VydmVyIHNvY2tldCA7CisgICAgICAgIEh0dHBfc3ZyLnN0YXJ0
IH5jb25uX2xpbWl0OjEwMjQgc2VydmVyIHNvY2tldCA7CiAgICAgICAgIFBy
aW50Zi5wcmludGYgInNlcnZlciBsaXN0ZW5pbmdcbiUhIiA7CiAgICAgICAg
IGlmICFzZWxmX3Rlc3QgdGhlbiAoCiAgICAgICAgICAgUHJpbnRmLnByaW50
ZiAiUnVubmluZyB1bml0LXRlc3RzXG4lISIgOwpkaWZmIC0tZ2l0IGEvb2Nh
bWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbCBiL29jYW1sL2xpYnMvaHR0
cC1zdnIvaHR0cF9zdnIubWwKaW5kZXggNGM1NmY1YmUwLi45MDE3Zjk0YmYg
MTAwNjQ0Ci0tLSBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWwK
KysrIGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbApAQCAtMTA1
LDYgKzEwNSw3IEBAIGxldCByZXNwb25zZV9mY3QgcmVxID8oaGRycyA9IFtd
KSBzIChyZXNwb25zZV9sZW5ndGggOiBpbnQ2NCkKICAgICAgIEh0dHAuUmVz
cG9uc2UuY29udGVudF9sZW5ndGg9IFNvbWUgcmVzcG9uc2VfbGVuZ3RoCiAg
ICAgfQogICBpbgorICBELmRlYnVnICJSZXNwb25zZSAlcyIgKEh0dHAuUmVz
cG9uc2UudG9fc3RyaW5nIHJlcykgOwogICBVbml4ZXh0LnJlYWxseV93cml0
ZV9zdHJpbmcgcyAoSHR0cC5SZXNwb25zZS50b193aXJlX3N0cmluZyByZXMp
IDsKICAgd3JpdGVfcmVzcG9uc2VfdG9fZmRfZm4gcwogCkBAIC0xMjIsNiAr
MTIzLDcgQEAgbGV0IHJlc3BvbnNlX21pc3NpbmcgPyhoZHJzID0gW10pIHMg
Ym9keSA9CiAgICAgICB+aGVhZGVyczooY29ubmVjdGlvbiA6OiBjYWNoZSA6
OiBoZHJzKQogICAgICAgfmJvZHkgIjQwNCIgIk5vdCBGb3VuZCIKICAgaW4K
KyAgRC5kZWJ1ZyAiUmVzcG9uc2UgJXMiIChIdHRwLlJlc3BvbnNlLnRvX3N0
cmluZyByZXMpIDsKICAgVW5peGV4dC5yZWFsbHlfd3JpdGVfc3RyaW5nIHMg
KEh0dHAuUmVzcG9uc2UudG9fd2lyZV9zdHJpbmcgcmVzKQogCiBsZXQgcmVz
cG9uc2VfZXJyb3JfaHRtbCA/KHZlcnNpb24gPSAiMS4xIikgcyBjb2RlIG1l
c3NhZ2UgaGRycyBib2R5ID0KQEAgLTEzMyw2ICsxMzUsNyBAQCBsZXQgcmVz
cG9uc2VfZXJyb3JfaHRtbCA/KHZlcnNpb24gPSAiMS4xIikgcyBjb2RlIG1l
c3NhZ2UgaGRycyBib2R5ID0KICAgICAgIH5oZWFkZXJzOihjb250ZW50X3R5
cGUgOjogY29ubmVjdGlvbiA6OiBjYWNoZSA6OiBoZHJzKQogICAgICAgfmJv
ZHkgY29kZSBtZXNzYWdlCiAgIGluCisgIEQuZGVidWcgIlJlc3BvbnNlICVz
IiAoSHR0cC5SZXNwb25zZS50b19zdHJpbmcgcmVzKSA7CiAgIFVuaXhleHQu
cmVhbGx5X3dyaXRlX3N0cmluZyBzIChIdHRwLlJlc3BvbnNlLnRvX3dpcmVf
c3RyaW5nIHJlcykKIAogbGV0IHJlc3BvbnNlX3VuYXV0aG9yaXNlZCA/cmVx
IGxhYmVsIHMgPQpAQCAtNDg0LDcgKzQ4NywxNSBAQCBsZXQgaGFuZGxlX29u
ZSAoeCA6ICdhIFNlcnZlci50KSBzcyBjb250ZXh0IHJlcSA9CiAgICAgKSA7
CiAgICAgIWZpbmlzaGVkCiAKLWxldCBoYW5kbGVfY29ubmVjdGlvbiAoeCA6
ICdhIFNlcnZlci50KSBfIHNzID0KK2xldCBoYW5kbGVfY29ubmVjdGlvbiAo
eCA6ICdhIFNlcnZlci50KSBjYWxsZXIgc3MgPQorICAoIG1hdGNoIGNhbGxl
ciB3aXRoCisgIHwgVW5peC5BRERSX1VOSVggXyAtPgorICAgICAgZGVidWcg
IkFjY2VwdGVkIHVuaXggY29ubmVjdGlvbiIKKyAgfCBVbml4LkFERFJfSU5F
VCAoYWRkciwgcG9ydCkgLT4KKyAgICAgIGRlYnVnICJBY2NlcHRlZCBpbmV0
IGNvbm5lY3Rpb24gZnJvbSAlczolZCIKKyAgICAgICAgKFVuaXguc3RyaW5n
X29mX2luZXRfYWRkciBhZGRyKQorICAgICAgICBwb3J0CisgICkgOwogICBs
ZXQgaWMgPSBCdWZfaW8ub2ZfZmQgc3MgaW4KICAgKCogRm9yIEhUVFBTIHJl
cXVlc3RzLCBhIFBST1hZIGhlYWRlciBpcyBzZW50IGJ5IHN0dW5uZWwgcmln
aHQgYXQgdGhlIGJlZ2lubmluZyBvZgogICAgICBvZiBpdHMgY29ubmVjdGlv
biB0byB0aGUgc2VydmVyLCBiZWZvcmUgSFRUUCByZXF1ZXN0cyBhcmUgdHJh
bnNmZXJyZWQsIGFuZApAQCAtNTA0LDcgKzUxNSw3IEBAIGxldCBoYW5kbGVf
Y29ubmVjdGlvbiAoeCA6ICdhIFNlcnZlci50KSBfIHNzID0KICAgICBpZiBu
b3QgZmluaXNoZWQgdGhlbgogICAgICAgbG9vcCBwcm94eQogICBpbgotICBs
b29wIE5vbmUgOyBVbml4LmNsb3NlIHNzCisgIGxvb3AgTm9uZSA7IGRlYnVn
ICJDbG9zaW5nIGNvbm5lY3Rpb24iIDsgVW5peC5jbG9zZSBzcwogCiBsZXQg
YmluZCA/KGxpc3Rlbl9iYWNrbG9nID0gMTI4KSBzb2NrYWRkciBuYW1lID0K
ICAgbGV0IGRvbWFpbiA9CkBAIC01NzAsOCArNTgxLDE1IEBAIGxldCBzb2Nr
ZXRfdGFibGUgPSBIYXNodGJsLmNyZWF0ZSAxMAogdHlwZSBzb2NrZXQgPSBV
bml4LmZpbGVfZGVzY3IgKiBzdHJpbmcKIAogKCogU3RhcnQgYW4gSFRUUCBz
ZXJ2ZXIgb24gYSBuZXcgc29ja2V0ICopCi1sZXQgc3RhcnQgKHggOiAnYSBT
ZXJ2ZXIudCkgKHNvY2tldCwgbmFtZSkgPQotICBsZXQgaGFuZGxlciA9IHtT
ZXJ2ZXJfaW8ubmFtZTsgYm9keT0gaGFuZGxlX2Nvbm5lY3Rpb24geH0gaW4K
K2xldCBzdGFydCB+Y29ubl9saW1pdCAoeCA6ICdhIFNlcnZlci50KSAoc29j
a2V0LCBuYW1lKQorICAgID0KK2xldCBoYW5kbGVyID0KKyAgICB7CisgICAg
ICBTZXJ2ZXJfaW8ubmFtZQorICAgIDsgYm9keT0gaGFuZGxlX2Nvbm5lY3Rp
b24geAorICAgIDsgbG9jaz0gWGFwaV9zdGRleHRfdGhyZWFkcy5TZW1hcGhv
cmUuY3JlYXRlIGNvbm5fbGltaXQKKyAgICB9CisgIGluCiAgIGxldCBzZXJ2
ZXIgPSBTZXJ2ZXJfaW8uc2VydmVyIGhhbmRsZXIgc29ja2V0IGluCiAgIEhh
c2h0YmwuYWRkIHNvY2tldF90YWJsZSBzb2NrZXQgc2VydmVyCiAKZGlmZiAt
LWdpdCBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpIGIvb2Nh
bWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbGkKaW5kZXggMzc4MWM3ZWVl
Li5kMGM3OWU0ZDQgMTAwNjQ0Ci0tLSBhL29jYW1sL2xpYnMvaHR0cC1zdnIv
aHR0cF9zdnIubWxpCisrKyBiL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9z
dnIubWxpCkBAIC01OSw3ICs1OSw3IEBAIHZhbCBiaW5kIDogP2xpc3Rlbl9i
YWNrbG9nOmludCAtPiBVbml4LnNvY2thZGRyIC0+IHN0cmluZyAtPiBzb2Nr
ZXQKICgqIFtiaW5kX3JldHJ5XTogbGlrZSBbYmluZF0gYnV0IHdpbGwgY2F0
Y2ggKHBvc3NpYmx5IHRyYW5zaWVudCBleGNlcHRpb25zKSBhbmQgcmV0cnkg
KikKIHZhbCBiaW5kX3JldHJ5IDogP2xpc3Rlbl9iYWNrbG9nOmludCAtPiBV
bml4LnNvY2thZGRyIC0+IHNvY2tldAogCi12YWwgc3RhcnQgOiAnYSBTZXJ2
ZXIudCAtPiBzb2NrZXQgLT4gdW5pdAordmFsIHN0YXJ0IDogY29ubl9saW1p
dDppbnQgLT4gJ2EgU2VydmVyLnQgLT4gc29ja2V0IC0+IHVuaXQKIAogdmFs
IGhhbmRsZV9vbmUgOiAnYSBTZXJ2ZXIudCAtPiBVbml4LmZpbGVfZGVzY3Ig
LT4gJ2EgLT4gSHR0cC5SZXF1ZXN0LnQgLT4gYm9vbAogCmRpZmYgLS1naXQg
YS9vY2FtbC9saWJzL2h0dHAtc3ZyL3NlcnZlcl9pby5tbCBiL29jYW1sL2xp
YnMvaHR0cC1zdnIvc2VydmVyX2lvLm1sCmluZGV4IDI4ZmQ1ODRkMS4uOWIy
ZDMzYTBlIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL3NlcnZl
cl9pby5tbAorKysgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL3NlcnZlcl9pby5t
bApAQCAtMjMsMTIgKzIzLDE3IEBAIHR5cGUgaGFuZGxlciA9IHsKICAgICBu
YW1lOiBzdHJpbmcKICAgOyAoKiBib2R5IHNob3VsZCBjbG9zZSB0aGUgcHJv
dmlkZWQgZmQgKikKICAgICBib2R5OiBVbml4LnNvY2thZGRyIC0+IFVuaXgu
ZmlsZV9kZXNjciAtPiB1bml0CisgIDsgbG9jazogWGFwaV9zdGRleHRfdGhy
ZWFkcy5TZW1hcGhvcmUudAogfQogCiBsZXQgaGFuZGxlcl9ieV90aHJlYWQg
KGggOiBoYW5kbGVyKSAocyA6IFVuaXguZmlsZV9kZXNjcikKICAgICAoY2Fs
bGVyIDogVW5peC5zb2NrYWRkcikgPQogICBUaHJlYWQuY3JlYXRlCi0gICAg
KGZ1biAoKSAtPiBEZWJ1Zy53aXRoX3RocmVhZF9uYW1lZCBoLm5hbWUgKGZ1
biAoKSAtPiBoLmJvZHkgY2FsbGVyIHMpICgpKQorICAgIChmdW4gKCkgLT4K
KyAgICAgIEZ1bi5wcm90ZWN0CisgICAgICAgIH5maW5hbGx5OihmdW4gKCkg
LT4gWGFwaV9zdGRleHRfdGhyZWFkcy5TZW1hcGhvcmUucmVsZWFzZSBoLmxv
Y2sgMSkKKyAgICAgICAgKERlYnVnLndpdGhfdGhyZWFkX25hbWVkIGgubmFt
ZSAoZnVuICgpIC0+IGguYm9keSBjYWxsZXIgcykpCisgICAgKQogICAgICgp
CiAKICgqKiBGdW5jdGlvbiB3aXRoIHRoZSBtYWluIGFjY2VwdCBsb29wICop
CkBAIC0zNywxNiArNDIsMTcgQEAgZXhjZXB0aW9uIFBsZWFzZUNsb3NlCiAK
IGxldCBzZXRfaW50ZXJzZWN0IGEgYiA9IExpc3QuZmlsdGVyIChmdW4geCAt
PiBMaXN0Lm1lbSB4IGIpIGEKIAotbGV0IGVzdGFibGlzaF9zZXJ2ZXIgPyhz
aWduYWxfZmRzID0gW10pIGZvcmtlciBzb2NrID0KK2xldCBlc3RhYmxpc2hf
c2VydmVyID8oc2lnbmFsX2ZkcyA9IFtdKSBmb3JrZXIgaGFuZGxlciBzb2Nr
ID0KICAgd2hpbGUgdHJ1ZSBkbwogICAgIHRyeQogICAgICAgbGV0IHIsIF8s
IF8gPSBVbml4LnNlbGVjdCAoW3NvY2tdIEAgc2lnbmFsX2ZkcykgW10gW10g
KC0xLikgaW4KICAgICAgICgqIElmIGFueSBvZiB0aGUgc2lnbmFsX2ZkIGlz
IGFjdGl2ZSB0aGVuIGJhaWwgb3V0ICopCiAgICAgICBpZiBzZXRfaW50ZXJz
ZWN0IHIgc2lnbmFsX2ZkcyA8PiBbXSB0aGVuIHJhaXNlIFBsZWFzZUNsb3Nl
IDsKKyAgICAgIFhhcGlfc3RkZXh0X3RocmVhZHMuU2VtYXBob3JlLmFjcXVp
cmUgaGFuZGxlci5sb2NrIDEgOwogICAgICAgbGV0IHMsIGNhbGxlciA9IFVu
aXguYWNjZXB0IHNvY2sgaW4KICAgICAgIHRyeQogICAgICAgICBVbml4LnNl
dF9jbG9zZV9vbl9leGVjIHMgOwotICAgICAgICBpZ25vcmUgKGZvcmtlciBz
IGNhbGxlcikKKyAgICAgICAgaWdub3JlIChmb3JrZXIgaGFuZGxlciBzIGNh
bGxlcikKICAgICAgIHdpdGggZXhjIC0+CiAgICAgICAgICgqIE5CIHByb3Zp
ZGVkICdmb3JrZXInIGlzIGNvbmZpZ3VyZWQgdG8gbWFrZSBhIGJhY2tncm91
bmQgdGhyZWFkIHRoZW4gdGhlCiAgICAgICAgICAgIAkgICAgIG9ubHkgd2F5
IHdlIGNhbiBnZXQgaGVyZSBpcyBpZiBzZXRfY2xvc2Vfb25fZXhlYyBvciBU
aHJlYWQuY3JlYXRlIGZhaWxzLgpAQCAtODksOSArOTUsOCBAQCBsZXQgc2Vy
dmVyIGhhbmRsZXIgc29jayA9CiAgICAgICAgIERlYnVnLndpdGhfdGhyZWFk
X25hbWVkIGhhbmRsZXIubmFtZQogICAgICAgICAgIChmdW4gKCkgLT4KICAg
ICAgICAgICAgIHRyeQotICAgICAgICAgICAgICBlc3RhYmxpc2hfc2VydmVy
IH5zaWduYWxfZmRzOltzdGF0dXNfb3V0XQotICAgICAgICAgICAgICAgICho
YW5kbGVyX2J5X3RocmVhZCBoYW5kbGVyKQotICAgICAgICAgICAgICAgIHNv
Y2sKKyAgICAgICAgICAgICAgZXN0YWJsaXNoX3NlcnZlciB+c2lnbmFsX2Zk
czpbc3RhdHVzX291dF0gaGFuZGxlcl9ieV90aHJlYWQKKyAgICAgICAgICAg
ICAgICBoYW5kbGVyIHNvY2sKICAgICAgICAgICAgIHdpdGggUGxlYXNlQ2xv
c2UgLT4gZGVidWcgIlNlcnZlciB0aHJlYWQgZXhpdGluZyIKICAgICAgICAg
ICApCiAgICAgICAgICAgKCkKZGlmZiAtLWdpdCBhL29jYW1sL2xpYnMvaHR0
cC1zdnIvc2VydmVyX2lvLm1saSBiL29jYW1sL2xpYnMvaHR0cC1zdnIvc2Vy
dmVyX2lvLm1saQppbmRleCBiNDg5NTJmODkuLjNhY2EwMjM0NyAxMDA2NDQK
LS0tIGEvb2NhbWwvbGlicy9odHRwLXN2ci9zZXJ2ZXJfaW8ubWxpCisrKyBi
L29jYW1sL2xpYnMvaHR0cC1zdnIvc2VydmVyX2lvLm1saQpAQCAtMTYsNiAr
MTYsNyBAQCB0eXBlIGhhbmRsZXIgPSB7CiAgICAgbmFtZTogc3RyaW5nICAo
KiogdXNlZCBmb3IgbmFtaW5nIHRoZSB0aHJlYWQgKikKICAgOyBib2R5OiBV
bml4LnNvY2thZGRyIC0+IFVuaXguZmlsZV9kZXNjciAtPiB1bml0CiAgICAg
ICAgICgqKiBmdW5jdGlvbiBjYWxsZWQgaW4gYSB0aHJlYWQgZm9yIGVhY2gg
Y29ubmVjdGlvbiopCisgIDsgbG9jazogWGFwaV9zdGRleHRfdGhyZWFkcy5T
ZW1hcGhvcmUudAogfQogCiB0eXBlIHNlcnZlciA9IHsKZGlmZiAtLWdpdCBh
L29jYW1sL2xpYnMvaHR0cC1zdnIvdGVzdF9zZXJ2ZXIubWwgYi9vY2FtbC9s
aWJzL2h0dHAtc3ZyL3Rlc3Rfc2VydmVyLm1sCmluZGV4IDJiMzk4Y2ZhNy4u
NTFlNGY1NTllIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL3Rl
c3Rfc2VydmVyLm1sCisrKyBiL29jYW1sL2xpYnMvaHR0cC1zdnIvdGVzdF9z
ZXJ2ZXIubWwKQEAgLTY4LDcgKzY4LDcgQEAgbGV0IF8gPQogICBsZXQgaW5l
dF9hZGRyID0gVW5peC5pbmV0X2FkZHJfb2Zfc3RyaW5nIGlwIGluCiAgIGxl
dCBhZGRyID0gVW5peC5BRERSX0lORVQgKGluZXRfYWRkciwgIXBvcnQpIGlu
CiAgIGxldCBzb2NrZXQgPSBIdHRwX3N2ci5iaW5kIH5saXN0ZW5fYmFja2xv
Zzo1IGFkZHIgInNlcnZlciIgaW4KLSAgc3RhcnQgc2VydmVyIHNvY2tldCA7
CisgIHN0YXJ0IH5jb25uX2xpbWl0OjEwMjQgc2VydmVyIHNvY2tldCA7CiAg
IFByaW50Zi5wcmludGYgIlNlcnZlciBzdGFydGVkIG9uICVzOiVkXG4iIGlw
ICFwb3J0IDsKICAgd2l0aF9sb2NrIGZpbmlzaGVkX20gKGZ1biAoKSAtPgog
ICAgICAgd2hpbGUgbm90ICFmaW5pc2hlZCBkbwpkaWZmIC0tZ2l0IGEvb2Nh
bWwveGFwaS94YXBpLm1sIGIvb2NhbWwveGFwaS94YXBpLm1sCmluZGV4IGQw
YjcxZmIwZi4uM2Q4M2Q2ZTM5IDEwMDY0NAotLS0gYS9vY2FtbC94YXBpL3hh
cGkubWwKKysrIGIvb2NhbWwveGFwaS94YXBpLm1sCkBAIC04NDQsNyArODQ0
LDExIEBAIGxldCBsaXN0ZW5fdW5peF9zb2NrZXQgc29ja19wYXRoID0KICAg
VW5peGV4dC5ta2Rpcl9zYWZlIChGaWxlbmFtZS5kaXJuYW1lIHNvY2tfcGF0
aCkgMG83MDAgOwogICBVbml4ZXh0LnVubGlua19zYWZlIHNvY2tfcGF0aCA7
CiAgIGxldCBkb21haW5fc29jayA9IFhhcGlfaHR0cC5iaW5kIChVbml4LkFE
RFJfVU5JWCBzb2NrX3BhdGgpIGluCi0gIGlnbm9yZSAoSHR0cF9zdnIuc3Rh
cnQgWGFwaV9odHRwLnNlcnZlciBkb21haW5fc29jaykKKyAgaWdub3JlCisg
ICAgKEh0dHBfc3ZyLnN0YXJ0CisgICAgICAgfmNvbm5fbGltaXQ6IVhhcGlf
Z2xvYnMuY29ubl9saW1pdF91bml4CisgICAgICAgWGFwaV9odHRwLnNlcnZl
ciBkb21haW5fc29jaworICAgICkKIAogbGV0IHNldF9zdHVubmVsX3RpbWVv
dXQgKCkgPQogICB0cnkKZGlmZiAtLWdpdCBhL29jYW1sL3hhcGkveGFwaV9n
bG9icy5tbCBiL29jYW1sL3hhcGkveGFwaV9nbG9icy5tbAppbmRleCBkOWMw
YzJiN2IuLjhkZmQ5ODUzOCAxMDA2NDQKLS0tIGEvb2NhbWwveGFwaS94YXBp
X2dsb2JzLm1sCisrKyBiL29jYW1sL3hhcGkveGFwaV9nbG9icy5tbApAQCAt
OTU3LDYgKzk1NywxMiBAQCBsZXQgc3FsaXRlMyA9IHJlZiAiL3Vzci9iaW4v
c3FsaXRlMyIKIAogbGV0IHNhbWJhX2RpciA9ICIvdmFyL2xpYi9zYW1iYSIK
IAorbGV0IGNvbm5fbGltaXRfdGNwID0gcmVmIDgwMAorCitsZXQgY29ubl9s
aW1pdF91bml4ID0gcmVmIDEwMjQKKworbGV0IGNvbm5fbGltaXRfY2xpZW50
Y2VydCA9IHJlZiA4MDAKKwogbGV0IHhhcGlfZ2xvYnNfc3BlYyA9CiAgIFsK
ICAgICAoICJtYXN0ZXJfY29ubmVjdGlvbl9yZXNldF90aW1lb3V0IgpAQCAt
MTAzMCw2ICsxMDM2LDkgQEAgbGV0IHhhcGlfZ2xvYnNfc3BlYyA9CiAgIDsg
KCAid2luYmluZF91cGRhdGVfY2xvc2VzdF9rZGNfaW50ZXJ2YWwiCiAgICAg
LCBGbG9hdCB3aW5iaW5kX3VwZGF0ZV9jbG9zZXN0X2tkY19pbnRlcnZhbAog
ICAgICkKKyAgOyAoImNvbm5fbGltaXRfdGNwIiwgSW50IGNvbm5fbGltaXRf
dGNwKQorICA7ICgiY29ubl9saW1pdF91bml4IiwgSW50IGNvbm5fbGltaXRf
dW5peCkKKyAgOyAoImNvbm5fbGltaXRfY2xpZW50Y2VydCIsIEludCBjb25u
X2xpbWl0X2NsaWVudGNlcnQpCiAgIF0KIAogbGV0IG9wdGlvbnNfb2ZfeGFw
aV9nbG9ic19zcGVjID0KZGlmZiAtLWdpdCBhL29jYW1sL3hhcGkveGFwaV9t
Z210X2lmYWNlLm1sIGIvb2NhbWwveGFwaS94YXBpX21nbXRfaWZhY2UubWwK
aW5kZXggYmU5M2FlMjU4Li4zODE2MTdmNDcgMTAwNjQ0Ci0tLSBhL29jYW1s
L3hhcGkveGFwaV9tZ210X2lmYWNlLm1sCisrKyBiL29jYW1sL3hhcGkveGFw
aV9tZ210X2lmYWNlLm1sCkBAIC04MSw3ICs4MSw4IEBAIGVuZCA9IHN0cnVj
dAogICAgICAgICAgIGlwdjZfZW5hYmxlZCA6PSBVbml4LmRvbWFpbl9vZl9z
b2NrYWRkciBzb2NrYWRkciA9IFVuaXguUEZfSU5FVDYgOwogICAgICAgICAg
IFhhcGlfaHR0cC5iaW5kIHNvY2thZGRyCiAgICAgaW4KLSAgICBIdHRwX3N2
ci5zdGFydCBYYXBpX2h0dHAuc2VydmVyIHNvY2tldCA7CisgICAgSHR0cF9z
dnIuc3RhcnQgfmNvbm5fbGltaXQ6IVhhcGlfZ2xvYnMuY29ubl9saW1pdF90
Y3AgWGFwaV9odHRwLnNlcnZlcgorICAgICAgc29ja2V0IDsKICAgICBtYW5h
Z2VtZW50X3NlcnZlcnMgOj0gc29ja2V0IDo6ICFtYW5hZ2VtZW50X3NlcnZl
cnMgOwogICAgIGlmIFBvb2xfcm9sZS5pc19tYXN0ZXIgKCkgJiYgYWRkciA9
IE5vbmUgdGhlbgogICAgICAgKCogTkIgaWYgd2Ugc3luY2hyb25vdXNseSBi
cmluZyB1cCB0aGUgbWFuYWdlbWVudCBpbnRlcmZhY2Ugb24gYSBtYXN0ZXIg
d2l0aCBhIGJsYW5rCkBAIC0xMzksNyArMTQwLDkgQEAgbW9kdWxlIENsaWVu
dF9jZXJ0aWZpY2F0ZV9hdXRoX3NlcnZlciA9IHN0cnVjdAogICAgICAgVW5p
eGV4dC5ta2Rpcl9zYWZlIChGaWxlbmFtZS5kaXJuYW1lIHNvY2tfcGF0aCkg
MG83MDAgOwogICAgICAgVW5peGV4dC51bmxpbmtfc2FmZSBzb2NrX3BhdGgg
OwogICAgICAgbGV0IGRvbWFpbl9zb2NrID0gWGFwaV9odHRwLmJpbmQgKFVu
aXguQUREUl9VTklYIHNvY2tfcGF0aCkgaW4KLSAgICAgIEh0dHBfc3ZyLnN0
YXJ0IFhhcGlfaHR0cC5zZXJ2ZXIgZG9tYWluX3NvY2sgOworICAgICAgSHR0
cF9zdnIuc3RhcnQKKyAgICAgICAgfmNvbm5fbGltaXQ6IVhhcGlfZ2xvYnMu
Y29ubl9saW1pdF9jbGllbnRjZXJ0CisgICAgICAgIFhhcGlfaHR0cC5zZXJ2
ZXIgZG9tYWluX3NvY2sgOwogICAgICAgbWFuYWdlbWVudF9zZXJ2ZXIgOj0g
U29tZSBkb21haW5fc29jawogICAgICkKIApkaWZmIC0tZ2l0IGEvb2NhbWwv
eGNwLXJyZGQvYmluL3JyZGQveGNwX3JyZGQubWwgYi9vY2FtbC94Y3AtcnJk
ZC9iaW4vcnJkZC94Y3BfcnJkZC5tbAppbmRleCA0OWRjNzQxMzEuLjhkMDE3
ZDQ4MSAxMDA2NDQKLS0tIGEvb2NhbWwveGNwLXJyZGQvYmluL3JyZGQveGNw
X3JyZGQubWwKKysrIGIvb2NhbWwveGNwLXJyZGQvYmluL3JyZGQveGNwX3Jy
ZGQubWwKQEAgLTkzLDcgKzkzLDcgQEAgbGV0IHN0YXJ0ICh4bWxycGNfcGF0
aCwgaHR0cF9md2RfcGF0aCkgcHJvY2VzcyA9CiAgIFhhcGlfc3RkZXh0X3Vu
aXguVW5peGV4dC5ta2Rpcl9zYWZlIChGaWxlbmFtZS5kaXJuYW1lIHhtbHJw
Y19wYXRoKSAwbzcwMCA7CiAgIFhhcGlfc3RkZXh0X3VuaXguVW5peGV4dC51
bmxpbmtfc2FmZSB4bWxycGNfcGF0aCA7CiAgIGxldCB4bWxycGNfc29ja2V0
ID0gSHR0cF9zdnIuYmluZCAoVW5peC5BRERSX1VOSVggeG1scnBjX3BhdGgp
ICJ1bml4X3JwYyIgaW4KLSAgSHR0cF9zdnIuc3RhcnQgc2VydmVyIHhtbHJw
Y19zb2NrZXQgOworICBIdHRwX3N2ci5zdGFydCB+Y29ubl9saW1pdDoxMDI0
IHNlcnZlciB4bWxycGNfc29ja2V0IDsKICAgWGFwaV9zdGRleHRfdW5peC5V
bml4ZXh0LnVubGlua19zYWZlIGh0dHBfZndkX3BhdGggOwogICBsZXQgaHR0
cF9md2Rfc29ja2V0ID0gVW5peC5zb2NrZXQgVW5peC5QRl9VTklYIFVuaXgu
U09DS19TVFJFQU0gMCBpbgogICBVbml4LmJpbmQgaHR0cF9md2Rfc29ja2V0
IChVbml4LkFERFJfVU5JWCBodHRwX2Z3ZF9wYXRoKSA7Ci0tIAoyLjMxLjEK
Cg==

--=separator
Content-Type: application/octet-stream; name="xsa413/xsa413-4.patch"
Content-Disposition: attachment; filename="xsa413/xsa413-4.patch"
Content-Transfer-Encoding: base64

RnJvbSAxYmJiZTk4ZTRiN2E1MWI0OTNlNDk0MDg2NjNjZDZlNjU3NDE2MDYx
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgSG9lcyA8cm9i
LmhvZXNAY2l0cml4LmNvbT4KRGF0ZTogRnJpLCA4IEp1bCAyMDIyIDEwOjI0
OjI3ICswMDAwClN1YmplY3Q6IFtQQVRDSCA0LzZdIFJlY2VpdmUgdGltZW91
dCBmb3IgVENQIGNvbm5lY3Rpb25zIHdoZW4gZmlyc3QgcmVhZGluZwogSFRU
UCBoZWFkZXJzCgpXaGVuIGEgY29ubmVjdGlvbiB0byB4YXBpJ3MgVENQIHNv
Y2tldCBpcyBlc3RhYmxpc2hlZCwgbm8gYXV0aGVudGljYXRpb24KaGFzIHRh
a2VuIHBsYWNlIHVudGlsIHRoZSBIVFRQIHJlcXVlc3QgaGFzIGJlZW4gcmVj
ZWl2ZWQuIFdlIG5lZWQgdG8KdHJlYXQgdGhlc2UgY29ubmVjdGlvbnMgd2l0
aCBzb21lIG1vcmUgY2FyZSB1bnRpbCB0aGVuLgoKVG8gcHJvdGVjdCBhZ2Fp
bnN0IHVuYXV0aGVudGljYXRlZCBjbGllbnRzIGhvbGRpbmcgY29ubmVjdGlv
bnMgb3Blbgp3aXRob3V0IGFjdHVhbGx5IG1ha2luZyBhbnkgY2FsbHMsIGEg
cmVhZCB0aW1lb3V0ICgxMCBzZWNvbmRzIGJ5CmRlZmF1bHQpIGlzIGludHJv
ZHVjZWQgZm9yIGV2ZXJ5IHJlYWQgZnJvbSB0aGUgc29ja2V0IHVudGlsIGFs
bCBoZWFkZXJzCmhhdmUgYmVlbiByZWFkLiBBbiBIVFRQIDQwOCAicmVxdWVz
dCB0aW1lb3V0IiByZXNwb25zZSBpcyByZXR1cm5lZCBhbmQKdGhlIGNvbm5l
Y3Rpb24gYnJva2VuIGlmIGEgdGltZW91dCBvY2N1cnMuCgpTaWduZWQtb2Zm
LWJ5OiBSb2IgSG9lcyA8cm9iLmhvZXNAY2l0cml4LmNvbT4KLS0tCiBvY2Ft
bC9saWJzL2h0dHAtc3ZyL2h0dHAubWwgICAgICB8IDEwICsrKysrKysrLQog
b2NhbWwvbGlicy9odHRwLXN2ci9odHRwLm1saSAgICAgfCAgMyArKy0KIG9j
YW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWwgIHwgMzggKysrKysrKysr
KysrKysrKysrKystLS0tLS0tLS0tLS0KIG9jYW1sL2xpYnMvaHR0cC1zdnIv
aHR0cF9zdnIubWxpIHwgIDMgKystCiBvY2FtbC9saWJzL2h0dHAtc3ZyL2h0
dHBfdGVzdC5tbCB8ICAyICstCiBvY2FtbC94YXBpL3hhcGlfZ2xvYnMubWwg
ICAgICAgICB8ICA0ICsrKysKIG9jYW1sL3hhcGkveGFwaV9tZ210X2lmYWNl
Lm1sICAgIHwgIDUgKysrLS0KIDcgZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0
aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvb2NhbWwv
bGlicy9odHRwLXN2ci9odHRwLm1sIGIvb2NhbWwvbGlicy9odHRwLXN2ci9o
dHRwLm1sCmluZGV4IDRiY2EwZjJmMS4uYTRkNTI4ZDhjIDEwMDY0NAotLS0g
YS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAubWwKKysrIGIvb2NhbWwvbGli
cy9odHRwLXN2ci9odHRwLm1sCkBAIC0zNjMsNyArMzYzLDE0IEBAIGxldCBy
ZWFkX2ZyYW1lX2hlYWRlciBidWYgPQogICBsZXQgcHJlZml4ID0gQnl0ZXMu
c3ViX3N0cmluZyBidWYgMCBmcmFtZV9oZWFkZXJfbGVuZ3RoIGluCiAgIHRy
eSBTY2FuZi5zc2NhbmYgcHJlZml4ICJGUkFNRSAlMDEyZCIgKGZ1biB4IC0+
IFNvbWUgeCkgd2l0aCBfIC0+IE5vbmUKIAotbGV0IHJlYWRfaHR0cF9yZXF1
ZXN0X2hlYWRlciBmZCA9CitsZXQgc2V0X3NvY2tldF90aW1lb3V0IGZkIHQg
PQorICB0cnkgVW5peC4oc2V0c29ja29wdF9mbG9hdCBmZCBTT19SQ1ZUSU1F
TyB0KQorICB3aXRoIFVuaXguVW5peF9lcnJvciAoVW5peC5FTk9UU09DSywg
XywgXykgLT4KKyAgICAoKiBJbiB0aGUgdW5pdCB0ZXN0cywgdGhlIGZkIGNv
bWVzIGZyb20gYSBwaXBlLi4uIGlnbm9yZSAqKQorICAgICgpCisKK2xldCBy
ZWFkX2h0dHBfcmVxdWVzdF9oZWFkZXIgfnJlYWRfdGltZW91dCBmZCA9Cisg
IE9wdGlvbi5pdGVyIChmdW4gdCAtPiBzZXRfc29ja2V0X3RpbWVvdXQgZmQg
dCkgcmVhZF90aW1lb3V0IDsKICAgbGV0IGJ1ZiA9IEJ5dGVzLmNyZWF0ZSAx
MDI0IGluCiAgIFVuaXhleHQucmVhbGx5X3JlYWQgZmQgYnVmIDAgNiA7CiAg
ICgqIHJldHVybiBQUk9YWSBoZWFkZXIgaWYgaXQgZXhpc3RzLCBhbmQgdGhl
biByZWFkIHVwIHRvIEZSQU1FIGhlYWRlciBsZW5ndGggKHdoaWNoIGFsc28g
bWF5IG5vdCBleGlzdCkgKikKQEAgLTM4Nyw2ICszOTQsNyBAQCBsZXQgcmVh
ZF9odHRwX3JlcXVlc3RfaGVhZGVyIGZkID0KICAgICAgICAgVW5peGV4dC5y
ZWFsbHlfcmVhZCBmZCBidWYgMCBsZW5ndGggOwogICAgICAgICAodHJ1ZSwg
bGVuZ3RoKQogICBpbgorICBzZXRfc29ja2V0X3RpbWVvdXQgZmQgMC4gOwog
ICAoZnJhbWUsIEJ5dGVzLnN1Yl9zdHJpbmcgYnVmIDAgaGVhZGVyc19sZW5n
dGgsIHByb3h5KQogCiBsZXQgcmVhZF9odHRwX3Jlc3BvbnNlX2hlYWRlciBi
dWYgZmQgPQpkaWZmIC0tZ2l0IGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRw
Lm1saSBiL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cC5tbGkKaW5kZXggNzQ2
M2RkNWYyLi5iMDZhZDEwNWYgMTAwNjQ0Ci0tLSBhL29jYW1sL2xpYnMvaHR0
cC1zdnIvaHR0cC5tbGkKKysrIGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRw
Lm1saQpAQCAtMzIsNyArMzIsOCBAQCB0eXBlIGF1dGhvcml6YXRpb24gPSBC
YXNpYyBvZiBzdHJpbmcgKiBzdHJpbmcgfCBVbmtub3duQXV0aCBvZiBzdHJp
bmcKIAogdmFsIG1ha2VfZnJhbWVfaGVhZGVyIDogc3RyaW5nIC0+IHN0cmlu
ZwogCi12YWwgcmVhZF9odHRwX3JlcXVlc3RfaGVhZGVyIDogVW5peC5maWxl
X2Rlc2NyIC0+IGJvb2wgKiBzdHJpbmcgKiBzdHJpbmcgb3B0aW9uCit2YWwg
cmVhZF9odHRwX3JlcXVlc3RfaGVhZGVyIDoKKyAgcmVhZF90aW1lb3V0OmZs
b2F0IG9wdGlvbiAtPiBVbml4LmZpbGVfZGVzY3IgLT4gYm9vbCAqIHN0cmlu
ZyAqIHN0cmluZyBvcHRpb24KIAogdmFsIHJlYWRfaHR0cF9yZXNwb25zZV9o
ZWFkZXIgOiBieXRlcyAtPiBVbml4LmZpbGVfZGVzY3IgLT4gaW50CiAKZGlm
ZiAtLWdpdCBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWwgYi9v
Y2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1sCmluZGV4IDkwMTdmOTRi
Zi4uNzdkZWEwOGJkIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3Zy
L2h0dHBfc3ZyLm1sCisrKyBiL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9z
dnIubWwKQEAgLTE2Myw2ICsxNjMsMTMgQEAgbGV0IHJlc3BvbnNlX2JhZHJl
cXVlc3QgP3JlcSBzID0KICAgaW4KICAgcmVzcG9uc2VfZXJyb3JfaHRtbCA/
dmVyc2lvbiBzICI0MDAiICJCYWQgUmVxdWVzdCIgW10gYm9keQogCitsZXQg
cmVzcG9uc2VfcmVxdWVzdF90aW1lb3V0IHMgPQorICBsZXQgYm9keSA9Cisg
ICAgIjxodG1sPjxib2R5PjxoMT5IVFRQIDQwOCByZXF1ZXN0IHRpbWVvdXQ8
L2gxPlRpbWVkIG91dCB3YWl0aW5nIGZvciB0aGUgXAorICAgICByZXF1ZXN0
LjwvYm9keT48L2h0bWw+IgorICBpbgorICByZXNwb25zZV9lcnJvcl9odG1s
IHMgIjQwOCIgIlJlcXVlc3QgVGltZW91dCIgW10gYm9keQorCiBsZXQgcmVz
cG9uc2VfaW50ZXJuYWxfZXJyb3IgP3JlcSA/ZXh0cmEgcyA9CiAgIGxldCB2
ZXJzaW9uID0gT3B0aW9uLm1hcCBnZXRfcmV0dXJuX3ZlcnNpb24gcmVxIGlu
CiAgIGxldCBleHRyYSA9CkBAIC0zMTUsOSArMzIyLDkgQEAgZXhjZXB0aW9u
IEdlbmVyaWNfZXJyb3Igb2Ygc3RyaW5nCiAKICgqKiBbcmVxdWVzdF9vZl9i
aW9fZXhuIGljXSByZWFkcyBhIHNpbmdsZSBIdHRwLnJlcSBmcm9tIFtpY10g
YW5kIHJldHVybnMgaXQuIE9uIGVycm9yCiAgICAgCWl0IHNpbXBseSB0aHJv
d3MgYW4gZXhjZXB0aW9uIGFuZCBkb2Vzbid0IHRvdWNoIHRoZSBvdXRwdXQg
c3RyZWFtLiAqKQotbGV0IHJlcXVlc3Rfb2ZfYmlvX2V4biB+cHJveHlfc2Vl
biBiaW8gPQorbGV0IHJlcXVlc3Rfb2ZfYmlvX2V4biB+cHJveHlfc2VlbiB+
cmVhZF90aW1lb3V0IGJpbyA9CiAgIGxldCBmZCA9IEJ1Zl9pby5mZF9vZiBi
aW8gaW4KLSAgbGV0IGZyYW1lLCBoZWFkZXJzLCBwcm94eScgPSBIdHRwLnJl
YWRfaHR0cF9yZXF1ZXN0X2hlYWRlciBmZCBpbgorICBsZXQgZnJhbWUsIGhl
YWRlcnMsIHByb3h5JyA9IEh0dHAucmVhZF9odHRwX3JlcXVlc3RfaGVhZGVy
IH5yZWFkX3RpbWVvdXQgZmQgaW4KICAgbGV0IHByb3h5ID0gbWF0Y2ggcHJv
eHknIHdpdGggTm9uZSAtPiBwcm94eV9zZWVuIHwgeCAtPiB4IGluCiAgIGxl
dCBhZGRpdGlvbmFsX2hlYWRlcnMgPQogICAgIHByb3h5IHw+IE9wdGlvbi5m
b2xkIH5ub25lOltdIH5zb21lOihmdW4gcCAtPiBbKCJTVFVOTkVMX1BST1hZ
IiwgcCldKQpAQCAtMzkzLDkgKzQwMCw5IEBAIGxldCByZXF1ZXN0X29mX2Jp
b19leG4gfnByb3h5X3NlZW4gYmlvID0KIAogKCoqIFtyZXF1ZXN0X29mX2Jp
byBpY10gcmV0dXJucyBbU29tZSByZXFdIHJlYWQgZnJvbSBbaWNdLCBvciBb
Tm9uZV0uIElmIFtOb25lXSBpdCB3aWxsIGhhdmUKICAgICAJYWxyZWFkeSBz
ZW50IGJhY2sgYSBzdWl0YWJsZSBlcnJvciBjb2RlIGFuZCByZXNwb25zZSB0
byB0aGUgY2xpZW50LiAqKQotbGV0IHJlcXVlc3Rfb2ZfYmlvID9wcm94eV9z
ZWVuIGljID0KK2xldCByZXF1ZXN0X29mX2JpbyA/cHJveHlfc2VlbiB+cmVh
ZF90aW1lb3V0IGljID0KICAgdHJ5Ci0gICAgbGV0IHIsIHByb3h5ID0gcmVx
dWVzdF9vZl9iaW9fZXhuIH5wcm94eV9zZWVuIGljIGluCisgICAgbGV0IHIs
IHByb3h5ID0gcmVxdWVzdF9vZl9iaW9fZXhuIH5wcm94eV9zZWVuIH5yZWFk
X3RpbWVvdXQgaWMgaW4KICAgICAoU29tZSByLCBwcm94eSkKICAgd2l0aCBl
IC0+CiAgICAgRC53YXJuICIlcyAoJXMpIiAoUHJpbnRleGMudG9fc3RyaW5n
IGUpIF9fTE9DX18gOwpAQCAtNDE5LDYgKzQyNiw4IEBAIGxldCByZXF1ZXN0
X29mX2JpbyA/cHJveHlfc2VlbiBpYyA9CiAgICAgICAgICgqIEdlbmVyaWMg
ZXJyb3JzIHRocm93biBkdXJpbmcgcGFyc2luZyAqKQogICAgICAgICB8IEVu
ZF9vZl9maWxlIC0+CiAgICAgICAgICAgICAoKQorICAgICAgICB8IFVuaXgu
VW5peF9lcnJvciAoVW5peC5FQUdBSU4sIF8sIF8pIC0+CisgICAgICAgICAg
ICByZXNwb25zZV9yZXF1ZXN0X3RpbWVvdXQgc3MKICAgICAgICAgKCogUHJl
bWF0dXJlIHRlcm1pbmF0aW9uIG9mIGNvbm5lY3Rpb24hICopCiAgICAgICAg
IHwgVW5peC5Vbml4X2Vycm9yIChhLCBiLCBjKSAtPgogICAgICAgICAgICAg
cmVzcG9uc2VfaW50ZXJuYWxfZXJyb3Igc3MKQEAgLTQ4Nyw3ICs0OTYsNyBA
QCBsZXQgaGFuZGxlX29uZSAoeCA6ICdhIFNlcnZlci50KSBzcyBjb250ZXh0
IHJlcSA9CiAgICAgKSA7CiAgICAgIWZpbmlzaGVkCiAKLWxldCBoYW5kbGVf
Y29ubmVjdGlvbiAoeCA6ICdhIFNlcnZlci50KSBjYWxsZXIgc3MgPQorbGV0
IGhhbmRsZV9jb25uZWN0aW9uIH5oZWFkZXJfcmVhZF90aW1lb3V0ICh4IDog
J2EgU2VydmVyLnQpIGNhbGxlciBzcyA9CiAgICggbWF0Y2ggY2FsbGVyIHdp
dGgKICAgfCBVbml4LkFERFJfVU5JWCBfIC0+CiAgICAgICBkZWJ1ZyAiQWNj
ZXB0ZWQgdW5peCBjb25uZWN0aW9uIgpAQCAtNTAyLDIwICs1MTEsMjIgQEAg
bGV0IGhhbmRsZV9jb25uZWN0aW9uICh4IDogJ2EgU2VydmVyLnQpIGNhbGxl
ciBzcyA9CiAgICAgIGp1c3Qgb25jZSBwZXIgY29ubmVjdGlvbi4gVG8gYWxs
b3cgZm9yIHRoZSBQUk9YWSBtZXRhZGF0YSAoaW5jbHVkaW5nIGUuZy4gdGhl
CiAgICAgIGNsaWVudCBJUCkgdG8gYmUgYWRkZWQgdG8gYWxsIHJlcXVlc3Qg
cmVjb3JkcyBvbiBhIGNvbm5lY3Rpb24sIGl0IG11c3QgYmUgcGFzc2VkCiAg
ICAgIGFsb25nIGluIHRoZSBsb29wIGJlbG93LiAqKQotICBsZXQgcmVjIGxv
b3AgcHJveHlfc2VlbiA9CisgIGxldCByZWMgbG9vcCB+cmVhZF90aW1lb3V0
IHByb3h5X3NlZW4gPQogICAgICgqIDEuIHdlIG11c3Qgc3VjY2Vzc2Z1bGx5
IHBhcnNlIGEgcmVxdWVzdCAqKQotICAgIGxldCByZXEsIHByb3h5ID0gcmVx
dWVzdF9vZl9iaW8gP3Byb3h5X3NlZW4gaWMgaW4KKyAgICBsZXQgcmVxLCBw
cm94eSA9IHJlcXVlc3Rfb2ZfYmlvID9wcm94eV9zZWVuIH5yZWFkX3RpbWVv
dXQgaWMgaW4KICAgICAoKiAyLiBub3cgd2UgYXR0ZW1wdCB0byBwcm9jZXNz
IHRoZSByZXF1ZXN0ICopCiAgICAgbGV0IGZpbmlzaGVkID0KICAgICAgIE9w
dGlvbi5mb2xkIH5ub25lOnRydWUKICAgICAgICAgfnNvbWU6KGhhbmRsZV9v
bmUgeCBzcyB4LlNlcnZlci5kZWZhdWx0X2NvbnRleHQpCiAgICAgICAgIHJl
cQogICAgIGluCi0gICAgKCogMy4gZG8gaXQgYWdhaW4gaWYgdGhlIGNvbm5l
Y3Rpb24gaXMga2VwdCBvcGVuICopCisgICAgKCogMy4gZG8gaXQgYWdhaW4g
aWYgdGhlIGNvbm5lY3Rpb24gaXMga2VwdCBvcGVuLCBidXQgd2l0aG91dCB0
aW1lb3V0cyAqKQogICAgIGlmIG5vdCBmaW5pc2hlZCB0aGVuCi0gICAgICBs
b29wIHByb3h5CisgICAgICBsb29wIH5yZWFkX3RpbWVvdXQ6Tm9uZSBwcm94
eQogICBpbgotICBsb29wIE5vbmUgOyBkZWJ1ZyAiQ2xvc2luZyBjb25uZWN0
aW9uIiA7IFVuaXguY2xvc2Ugc3MKKyAgbG9vcCB+cmVhZF90aW1lb3V0Omhl
YWRlcl9yZWFkX3RpbWVvdXQgTm9uZSA7CisgIGRlYnVnICJDbG9zaW5nIGNv
bm5lY3Rpb24iIDsKKyAgVW5peC5jbG9zZSBzcwogCiBsZXQgYmluZCA/KGxp
c3Rlbl9iYWNrbG9nID0gMTI4KSBzb2NrYWRkciBuYW1lID0KICAgbGV0IGRv
bWFpbiA9CkBAIC01ODEsMTIgKzU5MiwxMSBAQCBsZXQgc29ja2V0X3RhYmxl
ID0gSGFzaHRibC5jcmVhdGUgMTAKIHR5cGUgc29ja2V0ID0gVW5peC5maWxl
X2Rlc2NyICogc3RyaW5nCiAKICgqIFN0YXJ0IGFuIEhUVFAgc2VydmVyIG9u
IGEgbmV3IHNvY2tldCAqKQotbGV0IHN0YXJ0IH5jb25uX2xpbWl0ICh4IDog
J2EgU2VydmVyLnQpIChzb2NrZXQsIG5hbWUpCi0gICAgPQotbGV0IGhhbmRs
ZXIgPQorbGV0IHN0YXJ0ID9oZWFkZXJfcmVhZF90aW1lb3V0IH5jb25uX2xp
bWl0ICh4IDogJ2EgU2VydmVyLnQpIChzb2NrZXQsIG5hbWUpID0KKyAgbGV0
IGhhbmRsZXIgPQogICAgIHsKICAgICAgIFNlcnZlcl9pby5uYW1lCi0gICAg
OyBib2R5PSBoYW5kbGVfY29ubmVjdGlvbiB4CisgICAgOyBib2R5PSBoYW5k
bGVfY29ubmVjdGlvbiB+aGVhZGVyX3JlYWRfdGltZW91dCB4CiAgICAgOyBs
b2NrPSBYYXBpX3N0ZGV4dF90aHJlYWRzLlNlbWFwaG9yZS5jcmVhdGUgY29u
bl9saW1pdAogICAgIH0KICAgaW4KZGlmZiAtLWdpdCBhL29jYW1sL2xpYnMv
aHR0cC1zdnIvaHR0cF9zdnIubWxpIGIvb2NhbWwvbGlicy9odHRwLXN2ci9o
dHRwX3N2ci5tbGkKaW5kZXggZDBjNzllNGQ0Li40MGE1MDc0ZWEgMTAwNjQ0
Ci0tLSBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpCisrKyBi
L29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpCkBAIC01OSw3ICs1
OSw4IEBAIHZhbCBiaW5kIDogP2xpc3Rlbl9iYWNrbG9nOmludCAtPiBVbml4
LnNvY2thZGRyIC0+IHN0cmluZyAtPiBzb2NrZXQKICgqIFtiaW5kX3JldHJ5
XTogbGlrZSBbYmluZF0gYnV0IHdpbGwgY2F0Y2ggKHBvc3NpYmx5IHRyYW5z
aWVudCBleGNlcHRpb25zKSBhbmQgcmV0cnkgKikKIHZhbCBiaW5kX3JldHJ5
IDogP2xpc3Rlbl9iYWNrbG9nOmludCAtPiBVbml4LnNvY2thZGRyIC0+IHNv
Y2tldAogCi12YWwgc3RhcnQgOiBjb25uX2xpbWl0OmludCAtPiAnYSBTZXJ2
ZXIudCAtPiBzb2NrZXQgLT4gdW5pdAordmFsIHN0YXJ0IDoKKyAgP2hlYWRl
cl9yZWFkX3RpbWVvdXQ6ZmxvYXQgLT4gY29ubl9saW1pdDppbnQgLT4gJ2Eg
U2VydmVyLnQgLT4gc29ja2V0IC0+IHVuaXQKIAogdmFsIGhhbmRsZV9vbmUg
OiAnYSBTZXJ2ZXIudCAtPiBVbml4LmZpbGVfZGVzY3IgLT4gJ2EgLT4gSHR0
cC5SZXF1ZXN0LnQgLT4gYm9vbAogCmRpZmYgLS1naXQgYS9vY2FtbC9saWJz
L2h0dHAtc3ZyL2h0dHBfdGVzdC5tbCBiL29jYW1sL2xpYnMvaHR0cC1zdnIv
aHR0cF90ZXN0Lm1sCmluZGV4IDA2MzNjNThkMS4uZTA2N2E4YjhhIDEwMDY0
NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfdGVzdC5tbAorKysg
Yi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfdGVzdC5tbApAQCAtMjAwLDcg
KzIwMCw3IEBAIGxldCB0ZXN0X3JlYWRfaHR0cF9yZXF1ZXN0X2hlYWRlciBf
ID0KICAgfD4gTGlzdC5pdGVyIChmdW4gKGZyYW1lLCBwcm94eSwgaGVhZGVy
KSAtPgogICAgICAgICAgd2l0aF9mZCAobWtfaGVhZGVyX3N0cmluZyB+ZnJh
bWUgfnByb3h5IH5oZWFkZXIpIChmdW4gZmQgLT4KICAgICAgICAgICAgICBs
ZXQgYWN0dWFsX2ZyYW1lLCBhY3R1YWxfaGVhZGVyLCBhY3R1YWxfcHJveHkg
PQotICAgICAgICAgICAgICAgSHR0cC5yZWFkX2h0dHBfcmVxdWVzdF9oZWFk
ZXIgZmQKKyAgICAgICAgICAgICAgIEh0dHAucmVhZF9odHRwX3JlcXVlc3Rf
aGVhZGVyIH5yZWFkX3RpbWVvdXQ6Tm9uZSBmZAogICAgICAgICAgICAgIGlu
CiAgICAgICAgICAgICAgYXNzZXJ0IChhY3R1YWxfZnJhbWUgPSBmcmFtZSkg
OwogICAgICAgICAgICAgIGFzc2VydCAoYWN0dWFsX2hlYWRlciA9IGhlYWRl
cikgOwpkaWZmIC0tZ2l0IGEvb2NhbWwveGFwaS94YXBpX2dsb2JzLm1sIGIv
b2NhbWwveGFwaS94YXBpX2dsb2JzLm1sCmluZGV4IDhkZmQ5ODUzOC4uNGM4
NzRmZjY1IDEwMDY0NAotLS0gYS9vY2FtbC94YXBpL3hhcGlfZ2xvYnMubWwK
KysrIGIvb2NhbWwveGFwaS94YXBpX2dsb2JzLm1sCkBAIC05NTcsNiArOTU3
LDkgQEAgbGV0IHNxbGl0ZTMgPSByZWYgIi91c3IvYmluL3NxbGl0ZTMiCiAK
IGxldCBzYW1iYV9kaXIgPSAiL3Zhci9saWIvc2FtYmEiCiAKK2xldCBoZWFk
ZXJfcmVhZF90aW1lb3V0X3RjcCA9IHJlZiAxMC4KKygqIFRpbWVvdXQgaW4g
c2Vjb25kcyBmb3IgZXZlcnkgcmVhZCB3aGlsZSByZWFkaW5nIEhUVFAgaGVh
ZGVycyAob24gVENQIG9ubHkpICopCisKIGxldCBjb25uX2xpbWl0X3RjcCA9
IHJlZiA4MDAKIAogbGV0IGNvbm5fbGltaXRfdW5peCA9IHJlZiAxMDI0CkBA
IC0xMDM2LDYgKzEwMzksNyBAQCBsZXQgeGFwaV9nbG9ic19zcGVjID0KICAg
OyAoICJ3aW5iaW5kX3VwZGF0ZV9jbG9zZXN0X2tkY19pbnRlcnZhbCIKICAg
ICAsIEZsb2F0IHdpbmJpbmRfdXBkYXRlX2Nsb3Nlc3Rfa2RjX2ludGVydmFs
CiAgICAgKQorICA7ICgiaGVhZGVyX3JlYWRfdGltZW91dF90Y3AiLCBGbG9h
dCBoZWFkZXJfcmVhZF90aW1lb3V0X3RjcCkKICAgOyAoImNvbm5fbGltaXRf
dGNwIiwgSW50IGNvbm5fbGltaXRfdGNwKQogICA7ICgiY29ubl9saW1pdF91
bml4IiwgSW50IGNvbm5fbGltaXRfdW5peCkKICAgOyAoImNvbm5fbGltaXRf
Y2xpZW50Y2VydCIsIEludCBjb25uX2xpbWl0X2NsaWVudGNlcnQpCmRpZmYg
LS1naXQgYS9vY2FtbC94YXBpL3hhcGlfbWdtdF9pZmFjZS5tbCBiL29jYW1s
L3hhcGkveGFwaV9tZ210X2lmYWNlLm1sCmluZGV4IDM4MTYxN2Y0Ny4uODBh
NDg1MmFhIDEwMDY0NAotLS0gYS9vY2FtbC94YXBpL3hhcGlfbWdtdF9pZmFj
ZS5tbAorKysgYi9vY2FtbC94YXBpL3hhcGlfbWdtdF9pZmFjZS5tbApAQCAt
ODEsOCArODEsOSBAQCBlbmQgPSBzdHJ1Y3QKICAgICAgICAgICBpcHY2X2Vu
YWJsZWQgOj0gVW5peC5kb21haW5fb2Zfc29ja2FkZHIgc29ja2FkZHIgPSBV
bml4LlBGX0lORVQ2IDsKICAgICAgICAgICBYYXBpX2h0dHAuYmluZCBzb2Nr
YWRkcgogICAgIGluCi0gICAgSHR0cF9zdnIuc3RhcnQgfmNvbm5fbGltaXQ6
IVhhcGlfZ2xvYnMuY29ubl9saW1pdF90Y3AgWGFwaV9odHRwLnNlcnZlcgot
ICAgICAgc29ja2V0IDsKKyAgICBIdHRwX3N2ci5zdGFydAorICAgICAgfmhl
YWRlcl9yZWFkX3RpbWVvdXQ6IVhhcGlfZ2xvYnMuaGVhZGVyX3JlYWRfdGlt
ZW91dF90Y3AKKyAgICAgIH5jb25uX2xpbWl0OiFYYXBpX2dsb2JzLmNvbm5f
bGltaXRfdGNwIFhhcGlfaHR0cC5zZXJ2ZXIgc29ja2V0IDsKICAgICBtYW5h
Z2VtZW50X3NlcnZlcnMgOj0gc29ja2V0IDo6ICFtYW5hZ2VtZW50X3NlcnZl
cnMgOwogICAgIGlmIFBvb2xfcm9sZS5pc19tYXN0ZXIgKCkgJiYgYWRkciA9
IE5vbmUgdGhlbgogICAgICAgKCogTkIgaWYgd2Ugc3luY2hyb25vdXNseSBi
cmluZyB1cCB0aGUgbWFuYWdlbWVudCBpbnRlcmZhY2Ugb24gYSBtYXN0ZXIg
d2l0aCBhIGJsYW5rCi0tIAoyLjMxLjEKCg==

--=separator
Content-Type: application/octet-stream; name="xsa413/xsa413-5.patch"
Content-Disposition: attachment; filename="xsa413/xsa413-5.patch"
Content-Transfer-Encoding: base64

RnJvbSA3ZWI4ODIxZWZmZGQzN2U5ZmNjYTA0OTM5NjJmYWU3MGRjOGI1ZTk4
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgSG9lcyA8cm9i
LmhvZXNAY2l0cml4LmNvbT4KRGF0ZTogVHVlLCAyNiBKdWwgMjAyMiAxNDo1
Nzo0MiArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNS82XSBUb3RhbCB0aW1lb3V0
IGZvciByZWNlaXZpbmcgSFRUUCBoZWFkZXJzCgpTaWduZWQtb2ZmLWJ5OiBS
b2IgSG9lcyA8cm9iLmhvZXNAY2l0cml4LmNvbT4KLS0tCiBvY2FtbC9saWJz
L2h0dHAtc3ZyL2h0dHAubWwgICAgICB8IDQyICsrKysrKysrKysrKysrKysr
KysrKysrKysrLS0tLS0tCiBvY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAubWxp
ICAgICB8ICA3ICsrKysrLQogb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3N2
ci5tbCAgfCAzMyArKysrKysrKysrKysrKysrLS0tLS0tLS0tCiBvY2FtbC9s
aWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1saSB8ICA3ICsrKysrLQogb2NhbWwv
bGlicy9odHRwLXN2ci9odHRwX3Rlc3QubWwgfCAgMyArKy0KIG9jYW1sL3hh
cGkveGFwaV9nbG9icy5tbCAgICAgICAgIHwgIDQgKysrCiBvY2FtbC94YXBp
L3hhcGlfbWdtdF9pZmFjZS5tbCAgICB8ICAxICsKIDcgZmlsZXMgY2hhbmdl
ZCwgNzQgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCgpkaWZmIC0t
Z2l0IGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwLm1sIGIvb2NhbWwvbGli
cy9odHRwLXN2ci9odHRwLm1sCmluZGV4IGE0ZDUyOGQ4Yy4uYWY4YTU2ZWUy
IDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAubWwKKysr
IGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwLm1sCkBAIC0yNiw2ICsyNiw4
IEBAIGV4Y2VwdGlvbiBNZXRob2Rfbm90X2ltcGxlbWVudGVkCiAKIGV4Y2Vw
dGlvbiBNYWxmb3JtZWRfdXJsIG9mIHN0cmluZwogCitleGNlcHRpb24gVGlt
ZW91dAorCiBtb2R1bGUgRCA9IERlYnVnLk1ha2UgKHN0cnVjdCBsZXQgbmFt
ZSA9ICJodHRwIiBlbmQpCiAKIG9wZW4gRApAQCAtMjgxLDcgKzI4Myw3IEBA
IGxldCBoZWFkZXJfbGVuX2hlYWRlciA9IFByaW50Zi5zcHJpbnRmICJcclxu
JXM6IiBIZHIuaGVhZGVyX2xlbgogCiBsZXQgaGVhZGVyX2xlbl92YWx1ZV9s
ZW4gPSA1CiAKLWxldCByZWFkX3VwX3RvIGJ1ZiBhbHJlYWR5X3JlYWQgbWFy
a2VyIGZkID0KK2xldCByZWFkX3VwX3RvID9kZWFkbGluZSBidWYgYWxyZWFk
eV9yZWFkIG1hcmtlciBmZCA9CiAgIGxldCBtYXJrZXIgPSBTY2FubmVyLm1h
a2UgbWFya2VyIGluCiAgIGxldCBobF9tYXJrZXIgPSBTY2FubmVyLm1ha2Ug
aGVhZGVyX2xlbl9oZWFkZXIgaW4KICAgbGV0IGIgPSByZWYgMCBpbgpAQCAt
Mjg5LDYgKzI5MSwxMiBAQCBsZXQgcmVhZF91cF90byBidWYgYWxyZWFkeV9y
ZWFkIG1hcmtlciBmZCA9CiAgIGxldCBoZWFkZXJfbGVuID0gcmVmIE5vbmUg
aW4KICAgbGV0IGhlYWRlcl9sZW5fdmFsdWVfYXQgPSByZWYgTm9uZSBpbgog
ICB3aGlsZSBub3QgKFNjYW5uZXIubWF0Y2hlZCBtYXJrZXIpIGRvCisgICAg
T3B0aW9uLml0ZXIKKyAgICAgIChmdW4gZCAtPgorICAgICAgICBpZiBNdGlt
ZS5TcGFuLmNvbXBhcmUgKE10aW1lX2Nsb2NrLmVsYXBzZWQgKCkpIGQgPiAw
IHRoZW4KKyAgICAgICAgICByYWlzZSBUaW1lb3V0CisgICAgICApCisgICAg
ICBkZWFkbGluZSA7CiAgICAgbGV0IHNhZmVfdG9fcmVhZCA9CiAgICAgICBt
YXRjaCAoIWhlYWRlcl9sZW5fdmFsdWVfYXQsICFoZWFkZXJfbGVuKSB3aXRo
CiAgICAgICB8IE5vbmUsIE5vbmUgLT4KQEAgLTM2OSwyOSArMzc3LDQ3IEBA
IGxldCBzZXRfc29ja2V0X3RpbWVvdXQgZmQgdCA9CiAgICAgKCogSW4gdGhl
IHVuaXQgdGVzdHMsIHRoZSBmZCBjb21lcyBmcm9tIGEgcGlwZS4uLiBpZ25v
cmUgKikKICAgICAoKQogCi1sZXQgcmVhZF9odHRwX3JlcXVlc3RfaGVhZGVy
IH5yZWFkX3RpbWVvdXQgZmQgPQorbGV0IHJlYWRfaHR0cF9yZXF1ZXN0X2hl
YWRlciB+cmVhZF90aW1lb3V0IH50b3RhbF90aW1lb3V0IGZkID0KICAgT3B0
aW9uLml0ZXIgKGZ1biB0IC0+IHNldF9zb2NrZXRfdGltZW91dCBmZCB0KSBy
ZWFkX3RpbWVvdXQgOwogICBsZXQgYnVmID0gQnl0ZXMuY3JlYXRlIDEwMjQg
aW4KLSAgVW5peGV4dC5yZWFsbHlfcmVhZCBmZCBidWYgMCA2IDsKKyAgbGV0
IGRlYWRsaW5lID0KKyAgICBPcHRpb24ubWFwCisgICAgICAoZnVuIHQgLT4K
KyAgICAgICAgbGV0IHN0YXJ0ID0gTXRpbWVfY2xvY2suZWxhcHNlZCAoKSBp
bgorICAgICAgICBsZXQgdGltZW91dF9ucyA9IGludF9vZl9mbG9hdCAodCAq
LiAxZTkpIGluCisgICAgICAgIE10aW1lLlNwYW4uKGFkZCBzdGFydCAodGlt
ZW91dF9ucyAqIG5zKSkKKyAgICAgICkKKyAgICAgIHRvdGFsX3RpbWVvdXQK
KyAgaW4KKyAgbGV0IGNoZWNrX3RpbWVvdXRfYW5kX3JlYWQgeCB5ID0KKyAg
ICBPcHRpb24uaXRlcgorICAgICAgKGZ1biBkIC0+CisgICAgICAgIGlmIE10
aW1lLlNwYW4uY29tcGFyZSAoTXRpbWVfY2xvY2suZWxhcHNlZCAoKSkgZCA+
IDAgdGhlbgorICAgICAgICAgIHJhaXNlIFRpbWVvdXQKKyAgICAgICkKKyAg
ICAgIGRlYWRsaW5lIDsKKyAgICBVbml4ZXh0LnJlYWxseV9yZWFkIGZkIGJ1
ZiB4IHkKKyAgaW4KKyAgY2hlY2tfdGltZW91dF9hbmRfcmVhZCAwIDYgOwog
ICAoKiByZXR1cm4gUFJPWFkgaGVhZGVyIGlmIGl0IGV4aXN0cywgYW5kIHRo
ZW4gcmVhZCB1cCB0byBGUkFNRSBoZWFkZXIgbGVuZ3RoICh3aGljaCBhbHNv
IG1heSBub3QgZXhpc3QpICopCiAgIGxldCBwcm94eSA9CiAgICAgbWF0Y2gg
Qnl0ZXMuc3ViX3N0cmluZyBidWYgMCA2IHdpdGgKICAgICB8ICJQUk9YWSAi
IC0+Ci0gICAgICAgIGxldCBwcm94eV9oZWFkZXJfbGVuZ3RoID0gcmVhZF91
cF90byBidWYgNiAiXHJcbiIgZmQgaW4KKyAgICAgICAgbGV0IHByb3h5X2hl
YWRlcl9sZW5ndGggPSByZWFkX3VwX3RvID9kZWFkbGluZSBidWYgNiAiXHJc
biIgZmQgaW4KICAgICAgICAgKCogY2hvcCAnUFJPWFkgJyBmcm9tIHRoZSBi
ZWdpbm5pbmcsIGFuZCAnXHJcbicgZnJvbSB0aGUgZW5kICopCiAgICAgICAg
IGxldCBwcm94eSA9IEJ5dGVzLnN1Yl9zdHJpbmcgYnVmIDYgKHByb3h5X2hl
YWRlcl9sZW5ndGggLSA2IC0gMikgaW4KLSAgICAgICAgVW5peGV4dC5yZWFs
bHlfcmVhZCBmZCBidWYgMCBmcmFtZV9oZWFkZXJfbGVuZ3RoIDsKKyAgICAg
ICAgY2hlY2tfdGltZW91dF9hbmRfcmVhZCAwIGZyYW1lX2hlYWRlcl9sZW5n
dGggOwogICAgICAgICBTb21lIHByb3h5CiAgICAgfCBfIC0+Ci0gICAgICAg
IFVuaXhleHQucmVhbGx5X3JlYWQgZmQgYnVmIDYgKGZyYW1lX2hlYWRlcl9s
ZW5ndGggLSA2KSA7CisgICAgICAgIGNoZWNrX3RpbWVvdXRfYW5kX3JlYWQg
NiAoZnJhbWVfaGVhZGVyX2xlbmd0aCAtIDYpIDsKICAgICAgICAgTm9uZQog
ICBpbgogICBsZXQgZnJhbWUsIGhlYWRlcnNfbGVuZ3RoID0KICAgICBtYXRj
aCByZWFkX2ZyYW1lX2hlYWRlciBidWYgd2l0aAogICAgIHwgTm9uZSAtPgot
ICAgICAgICAoZmFsc2UsIHJlYWRfdXBfdG8gYnVmIGZyYW1lX2hlYWRlcl9s
ZW5ndGggZW5kX29mX2hlYWRlcnMgZmQpCisgICAgICAgIChmYWxzZSwgcmVh
ZF91cF90byA/ZGVhZGxpbmUgYnVmIGZyYW1lX2hlYWRlcl9sZW5ndGggZW5k
X29mX2hlYWRlcnMgZmQpCiAgICAgfCBTb21lIGxlbmd0aCAtPgotICAgICAg
ICBVbml4ZXh0LnJlYWxseV9yZWFkIGZkIGJ1ZiAwIGxlbmd0aCA7CisgICAg
ICAgIGNoZWNrX3RpbWVvdXRfYW5kX3JlYWQgMCBsZW5ndGggOwogICAgICAg
ICAodHJ1ZSwgbGVuZ3RoKQogICBpbgogICBzZXRfc29ja2V0X3RpbWVvdXQg
ZmQgMC4gOwpkaWZmIC0tZ2l0IGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRw
Lm1saSBiL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cC5tbGkKaW5kZXggYjA2
YWQxMDVmLi4yM2U2MzZhNTAgMTAwNjQ0Ci0tLSBhL29jYW1sL2xpYnMvaHR0
cC1zdnIvaHR0cC5tbGkKKysrIGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRw
Lm1saQpAQCAtMjgsMTIgKzI4LDE3IEBAIGV4Y2VwdGlvbiBNZXRob2Rfbm90
X2ltcGxlbWVudGVkCiAKIGV4Y2VwdGlvbiBGb3JiaWRkZW4KIAorZXhjZXB0
aW9uIFRpbWVvdXQKKwogdHlwZSBhdXRob3JpemF0aW9uID0gQmFzaWMgb2Yg
c3RyaW5nICogc3RyaW5nIHwgVW5rbm93bkF1dGggb2Ygc3RyaW5nCiAKIHZh
bCBtYWtlX2ZyYW1lX2hlYWRlciA6IHN0cmluZyAtPiBzdHJpbmcKIAogdmFs
IHJlYWRfaHR0cF9yZXF1ZXN0X2hlYWRlciA6Ci0gIHJlYWRfdGltZW91dDpm
bG9hdCBvcHRpb24gLT4gVW5peC5maWxlX2Rlc2NyIC0+IGJvb2wgKiBzdHJp
bmcgKiBzdHJpbmcgb3B0aW9uCisgICAgIHJlYWRfdGltZW91dDpmbG9hdCBv
cHRpb24KKyAgLT4gdG90YWxfdGltZW91dDpmbG9hdCBvcHRpb24KKyAgLT4g
VW5peC5maWxlX2Rlc2NyCisgIC0+IGJvb2wgKiBzdHJpbmcgKiBzdHJpbmcg
b3B0aW9uCiAKIHZhbCByZWFkX2h0dHBfcmVzcG9uc2VfaGVhZGVyIDogYnl0
ZXMgLT4gVW5peC5maWxlX2Rlc2NyIC0+IGludAogCmRpZmYgLS1naXQgYS9v
Y2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1sIGIvb2NhbWwvbGlicy9o
dHRwLXN2ci9odHRwX3N2ci5tbAppbmRleCA3N2RlYTA4YmQuLjE1NTQ2MmQz
MyAxMDA2NDQKLS0tIGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5t
bAorKysgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1sCkBAIC0z
MjIsOSArMzIyLDExIEBAIGV4Y2VwdGlvbiBHZW5lcmljX2Vycm9yIG9mIHN0
cmluZwogCiAoKiogW3JlcXVlc3Rfb2ZfYmlvX2V4biBpY10gcmVhZHMgYSBz
aW5nbGUgSHR0cC5yZXEgZnJvbSBbaWNdIGFuZCByZXR1cm5zIGl0LiBPbiBl
cnJvcgogICAgIAlpdCBzaW1wbHkgdGhyb3dzIGFuIGV4Y2VwdGlvbiBhbmQg
ZG9lc24ndCB0b3VjaCB0aGUgb3V0cHV0IHN0cmVhbS4gKikKLWxldCByZXF1
ZXN0X29mX2Jpb19leG4gfnByb3h5X3NlZW4gfnJlYWRfdGltZW91dCBiaW8g
PQorbGV0IHJlcXVlc3Rfb2ZfYmlvX2V4biB+cHJveHlfc2VlbiB+cmVhZF90
aW1lb3V0IH50b3RhbF90aW1lb3V0IGJpbyA9CiAgIGxldCBmZCA9IEJ1Zl9p
by5mZF9vZiBiaW8gaW4KLSAgbGV0IGZyYW1lLCBoZWFkZXJzLCBwcm94eScg
PSBIdHRwLnJlYWRfaHR0cF9yZXF1ZXN0X2hlYWRlciB+cmVhZF90aW1lb3V0
IGZkIGluCisgIGxldCBmcmFtZSwgaGVhZGVycywgcHJveHknID0KKyAgICBI
dHRwLnJlYWRfaHR0cF9yZXF1ZXN0X2hlYWRlciB+cmVhZF90aW1lb3V0IH50
b3RhbF90aW1lb3V0IGZkCisgIGluCiAgIGxldCBwcm94eSA9IG1hdGNoIHBy
b3h5JyB3aXRoIE5vbmUgLT4gcHJveHlfc2VlbiB8IHggLT4geCBpbgogICBs
ZXQgYWRkaXRpb25hbF9oZWFkZXJzID0KICAgICBwcm94eSB8PiBPcHRpb24u
Zm9sZCB+bm9uZTpbXSB+c29tZTooZnVuIHAgLT4gWygiU1RVTk5FTF9QUk9Y
WSIsIHApXSkKQEAgLTQwMCw5ICs0MDIsMTEgQEAgbGV0IHJlcXVlc3Rfb2Zf
YmlvX2V4biB+cHJveHlfc2VlbiB+cmVhZF90aW1lb3V0IGJpbyA9CiAKICgq
KiBbcmVxdWVzdF9vZl9iaW8gaWNdIHJldHVybnMgW1NvbWUgcmVxXSByZWFk
IGZyb20gW2ljXSwgb3IgW05vbmVdLiBJZiBbTm9uZV0gaXQgd2lsbCBoYXZl
CiAgICAgCWFscmVhZHkgc2VudCBiYWNrIGEgc3VpdGFibGUgZXJyb3IgY29k
ZSBhbmQgcmVzcG9uc2UgdG8gdGhlIGNsaWVudC4gKikKLWxldCByZXF1ZXN0
X29mX2JpbyA/cHJveHlfc2VlbiB+cmVhZF90aW1lb3V0IGljID0KK2xldCBy
ZXF1ZXN0X29mX2JpbyA/cHJveHlfc2VlbiB+cmVhZF90aW1lb3V0IH50b3Rh
bF90aW1lb3V0IGljID0KICAgdHJ5Ci0gICAgbGV0IHIsIHByb3h5ID0gcmVx
dWVzdF9vZl9iaW9fZXhuIH5wcm94eV9zZWVuIH5yZWFkX3RpbWVvdXQgaWMg
aW4KKyAgICBsZXQgciwgcHJveHkgPQorICAgICAgcmVxdWVzdF9vZl9iaW9f
ZXhuIH5wcm94eV9zZWVuIH5yZWFkX3RpbWVvdXQgfnRvdGFsX3RpbWVvdXQg
aWMKKyAgICBpbgogICAgIChTb21lIHIsIHByb3h5KQogICB3aXRoIGUgLT4K
ICAgICBELndhcm4gIiVzICglcykiIChQcmludGV4Yy50b19zdHJpbmcgZSkg
X19MT0NfXyA7CkBAIC00MjYsNyArNDMwLDcgQEAgbGV0IHJlcXVlc3Rfb2Zf
YmlvID9wcm94eV9zZWVuIH5yZWFkX3RpbWVvdXQgaWMgPQogICAgICAgICAo
KiBHZW5lcmljIGVycm9ycyB0aHJvd24gZHVyaW5nIHBhcnNpbmcgKikKICAg
ICAgICAgfCBFbmRfb2ZfZmlsZSAtPgogICAgICAgICAgICAgKCkKLSAgICAg
ICAgfCBVbml4LlVuaXhfZXJyb3IgKFVuaXguRUFHQUlOLCBfLCBfKSAtPgor
ICAgICAgICB8IFVuaXguVW5peF9lcnJvciAoVW5peC5FQUdBSU4sIF8sIF8p
IHwgSHR0cC5UaW1lb3V0IC0+CiAgICAgICAgICAgICByZXNwb25zZV9yZXF1
ZXN0X3RpbWVvdXQgc3MKICAgICAgICAgKCogUHJlbWF0dXJlIHRlcm1pbmF0
aW9uIG9mIGNvbm5lY3Rpb24hICopCiAgICAgICAgIHwgVW5peC5Vbml4X2Vy
cm9yIChhLCBiLCBjKSAtPgpAQCAtNDk2LDcgKzUwMCw4IEBAIGxldCBoYW5k
bGVfb25lICh4IDogJ2EgU2VydmVyLnQpIHNzIGNvbnRleHQgcmVxID0KICAg
ICApIDsKICAgICAhZmluaXNoZWQKIAotbGV0IGhhbmRsZV9jb25uZWN0aW9u
IH5oZWFkZXJfcmVhZF90aW1lb3V0ICh4IDogJ2EgU2VydmVyLnQpIGNhbGxl
ciBzcyA9CitsZXQgaGFuZGxlX2Nvbm5lY3Rpb24gfmhlYWRlcl9yZWFkX3Rp
bWVvdXQgfmhlYWRlcl90b3RhbF90aW1lb3V0CisgICAgKHggOiAnYSBTZXJ2
ZXIudCkgY2FsbGVyIHNzID0KICAgKCBtYXRjaCBjYWxsZXIgd2l0aAogICB8
IFVuaXguQUREUl9VTklYIF8gLT4KICAgICAgIGRlYnVnICJBY2NlcHRlZCB1
bml4IGNvbm5lY3Rpb24iCkBAIC01MTEsOSArNTE2LDExIEBAIGxldCBoYW5k
bGVfY29ubmVjdGlvbiB+aGVhZGVyX3JlYWRfdGltZW91dCAoeCA6ICdhIFNl
cnZlci50KSBjYWxsZXIgc3MgPQogICAgICBqdXN0IG9uY2UgcGVyIGNvbm5l
Y3Rpb24uIFRvIGFsbG93IGZvciB0aGUgUFJPWFkgbWV0YWRhdGEgKGluY2x1
ZGluZyBlLmcuIHRoZQogICAgICBjbGllbnQgSVApIHRvIGJlIGFkZGVkIHRv
IGFsbCByZXF1ZXN0IHJlY29yZHMgb24gYSBjb25uZWN0aW9uLCBpdCBtdXN0
IGJlIHBhc3NlZAogICAgICBhbG9uZyBpbiB0aGUgbG9vcCBiZWxvdy4gKikK
LSAgbGV0IHJlYyBsb29wIH5yZWFkX3RpbWVvdXQgcHJveHlfc2VlbiA9Cisg
IGxldCByZWMgbG9vcCB+cmVhZF90aW1lb3V0IH50b3RhbF90aW1lb3V0IHBy
b3h5X3NlZW4gPQogICAgICgqIDEuIHdlIG11c3Qgc3VjY2Vzc2Z1bGx5IHBh
cnNlIGEgcmVxdWVzdCAqKQotICAgIGxldCByZXEsIHByb3h5ID0gcmVxdWVz
dF9vZl9iaW8gP3Byb3h5X3NlZW4gfnJlYWRfdGltZW91dCBpYyBpbgorICAg
IGxldCByZXEsIHByb3h5ID0KKyAgICAgIHJlcXVlc3Rfb2ZfYmlvID9wcm94
eV9zZWVuIH5yZWFkX3RpbWVvdXQgfnRvdGFsX3RpbWVvdXQgaWMKKyAgICBp
bgogICAgICgqIDIuIG5vdyB3ZSBhdHRlbXB0IHRvIHByb2Nlc3MgdGhlIHJl
cXVlc3QgKikKICAgICBsZXQgZmluaXNoZWQgPQogICAgICAgT3B0aW9uLmZv
bGQgfm5vbmU6dHJ1ZQpAQCAtNTIyLDkgKzUyOSwxMCBAQCBsZXQgaGFuZGxl
X2Nvbm5lY3Rpb24gfmhlYWRlcl9yZWFkX3RpbWVvdXQgKHggOiAnYSBTZXJ2
ZXIudCkgY2FsbGVyIHNzID0KICAgICBpbgogICAgICgqIDMuIGRvIGl0IGFn
YWluIGlmIHRoZSBjb25uZWN0aW9uIGlzIGtlcHQgb3BlbiwgYnV0IHdpdGhv
dXQgdGltZW91dHMgKikKICAgICBpZiBub3QgZmluaXNoZWQgdGhlbgotICAg
ICAgbG9vcCB+cmVhZF90aW1lb3V0Ok5vbmUgcHJveHkKKyAgICAgIGxvb3Ag
fnJlYWRfdGltZW91dDpOb25lIH50b3RhbF90aW1lb3V0Ok5vbmUgcHJveHkK
ICAgaW4KLSAgbG9vcCB+cmVhZF90aW1lb3V0OmhlYWRlcl9yZWFkX3RpbWVv
dXQgTm9uZSA7CisgIGxvb3AgfnJlYWRfdGltZW91dDpoZWFkZXJfcmVhZF90
aW1lb3V0IH50b3RhbF90aW1lb3V0OmhlYWRlcl90b3RhbF90aW1lb3V0Cisg
ICAgTm9uZSA7CiAgIGRlYnVnICJDbG9zaW5nIGNvbm5lY3Rpb24iIDsKICAg
VW5peC5jbG9zZSBzcwogCkBAIC01OTIsMTEgKzYwMCwxMiBAQCBsZXQgc29j
a2V0X3RhYmxlID0gSGFzaHRibC5jcmVhdGUgMTAKIHR5cGUgc29ja2V0ID0g
VW5peC5maWxlX2Rlc2NyICogc3RyaW5nCiAKICgqIFN0YXJ0IGFuIEhUVFAg
c2VydmVyIG9uIGEgbmV3IHNvY2tldCAqKQotbGV0IHN0YXJ0ID9oZWFkZXJf
cmVhZF90aW1lb3V0IH5jb25uX2xpbWl0ICh4IDogJ2EgU2VydmVyLnQpIChz
b2NrZXQsIG5hbWUpID0KK2xldCBzdGFydCA/aGVhZGVyX3JlYWRfdGltZW91
dCA/aGVhZGVyX3RvdGFsX3RpbWVvdXQgfmNvbm5fbGltaXQKKyAgICAoeCA6
ICdhIFNlcnZlci50KSAoc29ja2V0LCBuYW1lKSA9CiAgIGxldCBoYW5kbGVy
ID0KICAgICB7CiAgICAgICBTZXJ2ZXJfaW8ubmFtZQotICAgIDsgYm9keT0g
aGFuZGxlX2Nvbm5lY3Rpb24gfmhlYWRlcl9yZWFkX3RpbWVvdXQgeAorICAg
IDsgYm9keT0gaGFuZGxlX2Nvbm5lY3Rpb24gfmhlYWRlcl9yZWFkX3RpbWVv
dXQgfmhlYWRlcl90b3RhbF90aW1lb3V0IHgKICAgICA7IGxvY2s9IFhhcGlf
c3RkZXh0X3RocmVhZHMuU2VtYXBob3JlLmNyZWF0ZSBjb25uX2xpbWl0CiAg
ICAgfQogICBpbgpkaWZmIC0tZ2l0IGEvb2NhbWwvbGlicy9odHRwLXN2ci9o
dHRwX3N2ci5tbGkgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1s
aQppbmRleCA0MGE1MDc0ZWEuLjc2MWUzOTQzNiAxMDA2NDQKLS0tIGEvb2Nh
bWwvbGlicy9odHRwLXN2ci9odHRwX3N2ci5tbGkKKysrIGIvb2NhbWwvbGli
cy9odHRwLXN2ci9odHRwX3N2ci5tbGkKQEAgLTYwLDcgKzYwLDEyIEBAIHZh
bCBiaW5kIDogP2xpc3Rlbl9iYWNrbG9nOmludCAtPiBVbml4LnNvY2thZGRy
IC0+IHN0cmluZyAtPiBzb2NrZXQKIHZhbCBiaW5kX3JldHJ5IDogP2xpc3Rl
bl9iYWNrbG9nOmludCAtPiBVbml4LnNvY2thZGRyIC0+IHNvY2tldAogCiB2
YWwgc3RhcnQgOgotICA/aGVhZGVyX3JlYWRfdGltZW91dDpmbG9hdCAtPiBj
b25uX2xpbWl0OmludCAtPiAnYSBTZXJ2ZXIudCAtPiBzb2NrZXQgLT4gdW5p
dAorICAgICA/aGVhZGVyX3JlYWRfdGltZW91dDpmbG9hdAorICAtPiA/aGVh
ZGVyX3RvdGFsX3RpbWVvdXQ6ZmxvYXQKKyAgLT4gY29ubl9saW1pdDppbnQK
KyAgLT4gJ2EgU2VydmVyLnQKKyAgLT4gc29ja2V0CisgIC0+IHVuaXQKIAog
dmFsIGhhbmRsZV9vbmUgOiAnYSBTZXJ2ZXIudCAtPiBVbml4LmZpbGVfZGVz
Y3IgLT4gJ2EgLT4gSHR0cC5SZXF1ZXN0LnQgLT4gYm9vbAogCmRpZmYgLS1n
aXQgYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfdGVzdC5tbCBiL29jYW1s
L2xpYnMvaHR0cC1zdnIvaHR0cF90ZXN0Lm1sCmluZGV4IGUwNjdhOGI4YS4u
NDYyZjQ2MDY2IDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0
dHBfdGVzdC5tbAorKysgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfdGVz
dC5tbApAQCAtMjAwLDcgKzIwMCw4IEBAIGxldCB0ZXN0X3JlYWRfaHR0cF9y
ZXF1ZXN0X2hlYWRlciBfID0KICAgfD4gTGlzdC5pdGVyIChmdW4gKGZyYW1l
LCBwcm94eSwgaGVhZGVyKSAtPgogICAgICAgICAgd2l0aF9mZCAobWtfaGVh
ZGVyX3N0cmluZyB+ZnJhbWUgfnByb3h5IH5oZWFkZXIpIChmdW4gZmQgLT4K
ICAgICAgICAgICAgICBsZXQgYWN0dWFsX2ZyYW1lLCBhY3R1YWxfaGVhZGVy
LCBhY3R1YWxfcHJveHkgPQotICAgICAgICAgICAgICAgSHR0cC5yZWFkX2h0
dHBfcmVxdWVzdF9oZWFkZXIgfnJlYWRfdGltZW91dDpOb25lIGZkCisgICAg
ICAgICAgICAgICBIdHRwLnJlYWRfaHR0cF9yZXF1ZXN0X2hlYWRlciB+cmVh
ZF90aW1lb3V0Ok5vbmUKKyAgICAgICAgICAgICAgICAgfnRvdGFsX3RpbWVv
dXQ6Tm9uZSBmZAogICAgICAgICAgICAgIGluCiAgICAgICAgICAgICAgYXNz
ZXJ0IChhY3R1YWxfZnJhbWUgPSBmcmFtZSkgOwogICAgICAgICAgICAgIGFz
c2VydCAoYWN0dWFsX2hlYWRlciA9IGhlYWRlcikgOwpkaWZmIC0tZ2l0IGEv
b2NhbWwveGFwaS94YXBpX2dsb2JzLm1sIGIvb2NhbWwveGFwaS94YXBpX2ds
b2JzLm1sCmluZGV4IDRjODc0ZmY2NS4uNjlhNGZhZTY4IDEwMDY0NAotLS0g
YS9vY2FtbC94YXBpL3hhcGlfZ2xvYnMubWwKKysrIGIvb2NhbWwveGFwaS94
YXBpX2dsb2JzLm1sCkBAIC05NjAsNiArOTYwLDkgQEAgbGV0IHNhbWJhX2Rp
ciA9ICIvdmFyL2xpYi9zYW1iYSIKIGxldCBoZWFkZXJfcmVhZF90aW1lb3V0
X3RjcCA9IHJlZiAxMC4KICgqIFRpbWVvdXQgaW4gc2Vjb25kcyBmb3IgZXZl
cnkgcmVhZCB3aGlsZSByZWFkaW5nIEhUVFAgaGVhZGVycyAob24gVENQIG9u
bHkpICopCiAKK2xldCBoZWFkZXJfdG90YWxfdGltZW91dF90Y3AgPSByZWYg
NjAuCisoKiBUaW1lb3V0IGluIHNlY29uZHMgdG8gcmVjZWl2ZSBhbGwgSFRU
UCBoZWFkZXJzIChvbiBUQ1Agb25seSkgKikKKwogbGV0IGNvbm5fbGltaXRf
dGNwID0gcmVmIDgwMAogCiBsZXQgY29ubl9saW1pdF91bml4ID0gcmVmIDEw
MjQKQEAgLTEwNDAsNiArMTA0Myw3IEBAIGxldCB4YXBpX2dsb2JzX3NwZWMg
PQogICAgICwgRmxvYXQgd2luYmluZF91cGRhdGVfY2xvc2VzdF9rZGNfaW50
ZXJ2YWwKICAgICApCiAgIDsgKCJoZWFkZXJfcmVhZF90aW1lb3V0X3RjcCIs
IEZsb2F0IGhlYWRlcl9yZWFkX3RpbWVvdXRfdGNwKQorICA7ICgiaGVhZGVy
X3RvdGFsX3RpbWVvdXRfdGNwIiwgRmxvYXQgaGVhZGVyX3RvdGFsX3RpbWVv
dXRfdGNwKQogICA7ICgiY29ubl9saW1pdF90Y3AiLCBJbnQgY29ubl9saW1p
dF90Y3ApCiAgIDsgKCJjb25uX2xpbWl0X3VuaXgiLCBJbnQgY29ubl9saW1p
dF91bml4KQogICA7ICgiY29ubl9saW1pdF9jbGllbnRjZXJ0IiwgSW50IGNv
bm5fbGltaXRfY2xpZW50Y2VydCkKZGlmZiAtLWdpdCBhL29jYW1sL3hhcGkv
eGFwaV9tZ210X2lmYWNlLm1sIGIvb2NhbWwveGFwaS94YXBpX21nbXRfaWZh
Y2UubWwKaW5kZXggODBhNDg1MmFhLi4wODRiNDM1MzEgMTAwNjQ0Ci0tLSBh
L29jYW1sL3hhcGkveGFwaV9tZ210X2lmYWNlLm1sCisrKyBiL29jYW1sL3hh
cGkveGFwaV9tZ210X2lmYWNlLm1sCkBAIC04Myw2ICs4Myw3IEBAIGVuZCA9
IHN0cnVjdAogICAgIGluCiAgICAgSHR0cF9zdnIuc3RhcnQKICAgICAgIH5o
ZWFkZXJfcmVhZF90aW1lb3V0OiFYYXBpX2dsb2JzLmhlYWRlcl9yZWFkX3Rp
bWVvdXRfdGNwCisgICAgICB+aGVhZGVyX3RvdGFsX3RpbWVvdXQ6IVhhcGlf
Z2xvYnMuaGVhZGVyX3RvdGFsX3RpbWVvdXRfdGNwCiAgICAgICB+Y29ubl9s
aW1pdDohWGFwaV9nbG9icy5jb25uX2xpbWl0X3RjcCBYYXBpX2h0dHAuc2Vy
dmVyIHNvY2tldCA7CiAgICAgbWFuYWdlbWVudF9zZXJ2ZXJzIDo9IHNvY2tl
dCA6OiAhbWFuYWdlbWVudF9zZXJ2ZXJzIDsKICAgICBpZiBQb29sX3JvbGUu
aXNfbWFzdGVyICgpICYmIGFkZHIgPSBOb25lIHRoZW4KLS0gCjIuMzEuMQoK

--=separator
Content-Type: application/octet-stream; name="xsa413/xsa413-6.patch"
Content-Disposition: attachment; filename="xsa413/xsa413-6.patch"
Content-Transfer-Encoding: base64

RnJvbSAxYTQ3NDE3YTE0MTUxNDY5YWUyOTE0M2UxNDEzMWNiMmYwYmUwNGRh
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgSG9lcyA8cm9i
LmhvZXNAY2l0cml4LmNvbT4KRGF0ZTogVHVlLCAyNiBKdWwgMjAyMiAxNjoy
MDoxOSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggNi82XSBNYXhpbXVtIGhlYWRl
ciBsZW5ndGgKClNpZ25lZC1vZmYtYnk6IFJvYiBIb2VzIDxyb2IuaG9lc0Bj
aXRyaXguY29tPgotLS0KIG9jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cC5tbCAg
ICAgIHwgMTQgKysrKysrKysrKy0tLS0KIG9jYW1sL2xpYnMvaHR0cC1zdnIv
aHR0cC5tbGkgICAgIHwgIDMgKysrCiBvY2FtbC9saWJzL2h0dHAtc3ZyL2h0
dHBfc3ZyLm1sICB8IDMxICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0t
LS0KIG9jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpIHwgIDEgKwog
b2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3Rlc3QubWwgfCAgMiArLQogb2Nh
bWwveGFwaS94YXBpX2dsb2JzLm1sICAgICAgICAgfCAgNCArKysrCiBvY2Ft
bC94YXBpL3hhcGlfbWdtdF9pZmFjZS5tbCAgICB8ICAxICsKIDcgZmlsZXMg
Y2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwLm1sIGIvb2Nh
bWwvbGlicy9odHRwLXN2ci9odHRwLm1sCmluZGV4IGFmOGE1NmVlMi4uMDhh
YzBjNjgzIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAu
bWwKKysrIGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwLm1sCkBAIC0yOCw2
ICsyOCw4IEBAIGV4Y2VwdGlvbiBNYWxmb3JtZWRfdXJsIG9mIHN0cmluZwog
CiBleGNlcHRpb24gVGltZW91dAogCitleGNlcHRpb24gVG9vX2xhcmdlCisK
IG1vZHVsZSBEID0gRGVidWcuTWFrZSAoc3RydWN0IGxldCBuYW1lID0gImh0
dHAiIGVuZCkKIAogb3BlbiBECkBAIC0yODMsNyArMjg1LDcgQEAgbGV0IGhl
YWRlcl9sZW5faGVhZGVyID0gUHJpbnRmLnNwcmludGYgIlxyXG4lczoiIEhk
ci5oZWFkZXJfbGVuCiAKIGxldCBoZWFkZXJfbGVuX3ZhbHVlX2xlbiA9IDUK
IAotbGV0IHJlYWRfdXBfdG8gP2RlYWRsaW5lIGJ1ZiBhbHJlYWR5X3JlYWQg
bWFya2VyIGZkID0KK2xldCByZWFkX3VwX3RvID9kZWFkbGluZSA/bWF4IGJ1
ZiBhbHJlYWR5X3JlYWQgbWFya2VyIGZkID0KICAgbGV0IG1hcmtlciA9IFNj
YW5uZXIubWFrZSBtYXJrZXIgaW4KICAgbGV0IGhsX21hcmtlciA9IFNjYW5u
ZXIubWFrZSBoZWFkZXJfbGVuX2hlYWRlciBpbgogICBsZXQgYiA9IHJlZiAw
IGluCkBAIC0zMTAsNiArMzEyLDcgQEAgbGV0IHJlYWRfdXBfdG8gP2RlYWRs
aW5lIGJ1ZiBhbHJlYWR5X3JlYWQgbWFya2VyIGZkID0KIAkJUHJpbnRmLmZw
cmludGYgc3RkZXJyICJiID0gJWQ7IHNhZmVfdG9fcmVhZCA9ICVkXG4iICFi
IHNhZmVfdG9fcmVhZDsKIAkJZmx1c2ggc3RkZXJyOwogKikKKyAgICBPcHRp
b24uaXRlciAoZnVuIG0gLT4gaWYgIWIgKyBzYWZlX3RvX3JlYWQgPiBtIHRo
ZW4gcmFpc2UgVG9vX2xhcmdlKSBtYXggOwogICAgIGxldCBuID0KICAgICAg
IGlmICFiIDwgYWxyZWFkeV9yZWFkIHRoZW4KICAgICAgICAgbWluIHNhZmVf
dG9fcmVhZCAoYWxyZWFkeV9yZWFkIC0gIWIpCkBAIC0zNzcsOSArMzgwLDkg
QEAgbGV0IHNldF9zb2NrZXRfdGltZW91dCBmZCB0ID0KICAgICAoKiBJbiB0
aGUgdW5pdCB0ZXN0cywgdGhlIGZkIGNvbWVzIGZyb20gYSBwaXBlLi4uIGln
bm9yZSAqKQogICAgICgpCiAKLWxldCByZWFkX2h0dHBfcmVxdWVzdF9oZWFk
ZXIgfnJlYWRfdGltZW91dCB+dG90YWxfdGltZW91dCBmZCA9CitsZXQgcmVh
ZF9odHRwX3JlcXVlc3RfaGVhZGVyIH5yZWFkX3RpbWVvdXQgfnRvdGFsX3Rp
bWVvdXQgfm1heF9sZW5ndGggZmQgPQogICBPcHRpb24uaXRlciAoZnVuIHQg
LT4gc2V0X3NvY2tldF90aW1lb3V0IGZkIHQpIHJlYWRfdGltZW91dCA7Ci0g
IGxldCBidWYgPSBCeXRlcy5jcmVhdGUgMTAyNCBpbgorICBsZXQgYnVmID0g
Qnl0ZXMuY3JlYXRlIChPcHRpb24udmFsdWUgfmRlZmF1bHQ6MTAyNCBtYXhf
bGVuZ3RoKSBpbgogICBsZXQgZGVhZGxpbmUgPQogICAgIE9wdGlvbi5tYXAK
ICAgICAgIChmdW4gdCAtPgpAQCAtNDE1LDcgKzQxOCwxMCBAQCBsZXQgcmVh
ZF9odHRwX3JlcXVlc3RfaGVhZGVyIH5yZWFkX3RpbWVvdXQgfnRvdGFsX3Rp
bWVvdXQgZmQgPQogICBsZXQgZnJhbWUsIGhlYWRlcnNfbGVuZ3RoID0KICAg
ICBtYXRjaCByZWFkX2ZyYW1lX2hlYWRlciBidWYgd2l0aAogICAgIHwgTm9u
ZSAtPgotICAgICAgICAoZmFsc2UsIHJlYWRfdXBfdG8gP2RlYWRsaW5lIGJ1
ZiBmcmFtZV9oZWFkZXJfbGVuZ3RoIGVuZF9vZl9oZWFkZXJzIGZkKQorICAg
ICAgICBsZXQgbWF4ID0gT3B0aW9uLm1hcCAoZnVuIG0gLT4gbSAtIGZyYW1l
X2hlYWRlcl9sZW5ndGgpIG1heF9sZW5ndGggaW4KKyAgICAgICAgKCBmYWxz
ZQorICAgICAgICAsIHJlYWRfdXBfdG8gP2RlYWRsaW5lID9tYXggYnVmIGZy
YW1lX2hlYWRlcl9sZW5ndGggZW5kX29mX2hlYWRlcnMgZmQKKyAgICAgICAg
KQogICAgIHwgU29tZSBsZW5ndGggLT4KICAgICAgICAgY2hlY2tfdGltZW91
dF9hbmRfcmVhZCAwIGxlbmd0aCA7CiAgICAgICAgICh0cnVlLCBsZW5ndGgp
CmRpZmYgLS1naXQgYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAubWxpIGIv
b2NhbWwvbGlicy9odHRwLXN2ci9odHRwLm1saQppbmRleCAyM2U2MzZhNTAu
LjUzZGQ1ZDk2ZiAxMDA2NDQKLS0tIGEvb2NhbWwvbGlicy9odHRwLXN2ci9o
dHRwLm1saQorKysgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHAubWxpCkBA
IC0zMCw2ICszMCw4IEBAIGV4Y2VwdGlvbiBGb3JiaWRkZW4KIAogZXhjZXB0
aW9uIFRpbWVvdXQKIAorZXhjZXB0aW9uIFRvb19sYXJnZQorCiB0eXBlIGF1
dGhvcml6YXRpb24gPSBCYXNpYyBvZiBzdHJpbmcgKiBzdHJpbmcgfCBVbmtu
b3duQXV0aCBvZiBzdHJpbmcKIAogdmFsIG1ha2VfZnJhbWVfaGVhZGVyIDog
c3RyaW5nIC0+IHN0cmluZwpAQCAtMzcsNiArMzksNyBAQCB2YWwgbWFrZV9m
cmFtZV9oZWFkZXIgOiBzdHJpbmcgLT4gc3RyaW5nCiB2YWwgcmVhZF9odHRw
X3JlcXVlc3RfaGVhZGVyIDoKICAgICAgcmVhZF90aW1lb3V0OmZsb2F0IG9w
dGlvbgogICAtPiB0b3RhbF90aW1lb3V0OmZsb2F0IG9wdGlvbgorICAtPiBt
YXhfbGVuZ3RoOmludCBvcHRpb24KICAgLT4gVW5peC5maWxlX2Rlc2NyCiAg
IC0+IGJvb2wgKiBzdHJpbmcgKiBzdHJpbmcgb3B0aW9uCiAKZGlmZiAtLWdp
dCBhL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWwgYi9vY2FtbC9s
aWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1sCmluZGV4IDE1NTQ2MmQzMy4uMTEy
YzI2YTFlIDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBf
c3ZyLm1sCisrKyBiL29jYW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWwK
QEAgLTE3MCw2ICsxNzAsMTMgQEAgbGV0IHJlc3BvbnNlX3JlcXVlc3RfdGlt
ZW91dCBzID0KICAgaW4KICAgcmVzcG9uc2VfZXJyb3JfaHRtbCBzICI0MDgi
ICJSZXF1ZXN0IFRpbWVvdXQiIFtdIGJvZHkKIAorbGV0IHJlc3BvbnNlX3Jl
cXVlc3RfaGVhZGVyX2ZpZWxkc190b29fbGFyZ2UgcyA9CisgIGxldCBib2R5
ID0KKyAgICAiPGh0bWw+PGJvZHk+PGgxPkhUVFAgNDMxIHJlcXVlc3QgaGVh
ZGVyIGZpZWxkcyB0b28gbGFyZ2U8L2gxPkV4Y2VlZGVkIHRoZSBcCisgICAg
IG1heGltdW0gaGVhZGVyIHNpemUuPC9ib2R5PjwvaHRtbD4iCisgIGluCisg
IHJlc3BvbnNlX2Vycm9yX2h0bWwgcyAiNDMxIiAiUmVxdWVzdCBIZWFkZXIg
RmllbGRzIFRvbyBMYXJnZSIgW10gYm9keQorCiBsZXQgcmVzcG9uc2VfaW50
ZXJuYWxfZXJyb3IgP3JlcSA/ZXh0cmEgcyA9CiAgIGxldCB2ZXJzaW9uID0g
T3B0aW9uLm1hcCBnZXRfcmV0dXJuX3ZlcnNpb24gcmVxIGluCiAgIGxldCBl
eHRyYSA9CkBAIC0zMjIsMTAgKzMyOSwxMSBAQCBleGNlcHRpb24gR2VuZXJp
Y19lcnJvciBvZiBzdHJpbmcKIAogKCoqIFtyZXF1ZXN0X29mX2Jpb19leG4g
aWNdIHJlYWRzIGEgc2luZ2xlIEh0dHAucmVxIGZyb20gW2ljXSBhbmQgcmV0
dXJucyBpdC4gT24gZXJyb3IKICAgICAJaXQgc2ltcGx5IHRocm93cyBhbiBl
eGNlcHRpb24gYW5kIGRvZXNuJ3QgdG91Y2ggdGhlIG91dHB1dCBzdHJlYW0u
ICopCi1sZXQgcmVxdWVzdF9vZl9iaW9fZXhuIH5wcm94eV9zZWVuIH5yZWFk
X3RpbWVvdXQgfnRvdGFsX3RpbWVvdXQgYmlvID0KK2xldCByZXF1ZXN0X29m
X2Jpb19leG4gfnByb3h5X3NlZW4gfnJlYWRfdGltZW91dCB+dG90YWxfdGlt
ZW91dCB+bWF4X2xlbmd0aCBiaW8KKyAgICA9CiAgIGxldCBmZCA9IEJ1Zl9p
by5mZF9vZiBiaW8gaW4KICAgbGV0IGZyYW1lLCBoZWFkZXJzLCBwcm94eScg
PQotICAgIEh0dHAucmVhZF9odHRwX3JlcXVlc3RfaGVhZGVyIH5yZWFkX3Rp
bWVvdXQgfnRvdGFsX3RpbWVvdXQgZmQKKyAgICBIdHRwLnJlYWRfaHR0cF9y
ZXF1ZXN0X2hlYWRlciB+cmVhZF90aW1lb3V0IH50b3RhbF90aW1lb3V0IH5t
YXhfbGVuZ3RoIGZkCiAgIGluCiAgIGxldCBwcm94eSA9IG1hdGNoIHByb3h5
JyB3aXRoIE5vbmUgLT4gcHJveHlfc2VlbiB8IHggLT4geCBpbgogICBsZXQg
YWRkaXRpb25hbF9oZWFkZXJzID0KQEAgLTQwMiwxMCArNDEwLDEwIEBAIGxl
dCByZXF1ZXN0X29mX2Jpb19leG4gfnByb3h5X3NlZW4gfnJlYWRfdGltZW91
dCB+dG90YWxfdGltZW91dCBiaW8gPQogCiAoKiogW3JlcXVlc3Rfb2ZfYmlv
IGljXSByZXR1cm5zIFtTb21lIHJlcV0gcmVhZCBmcm9tIFtpY10sIG9yIFtO
b25lXS4gSWYgW05vbmVdIGl0IHdpbGwgaGF2ZQogICAgIAlhbHJlYWR5IHNl
bnQgYmFjayBhIHN1aXRhYmxlIGVycm9yIGNvZGUgYW5kIHJlc3BvbnNlIHRv
IHRoZSBjbGllbnQuICopCi1sZXQgcmVxdWVzdF9vZl9iaW8gP3Byb3h5X3Nl
ZW4gfnJlYWRfdGltZW91dCB+dG90YWxfdGltZW91dCBpYyA9CitsZXQgcmVx
dWVzdF9vZl9iaW8gP3Byb3h5X3NlZW4gfnJlYWRfdGltZW91dCB+dG90YWxf
dGltZW91dCB+bWF4X2xlbmd0aCBpYyA9CiAgIHRyeQogICAgIGxldCByLCBw
cm94eSA9Ci0gICAgICByZXF1ZXN0X29mX2Jpb19leG4gfnByb3h5X3NlZW4g
fnJlYWRfdGltZW91dCB+dG90YWxfdGltZW91dCBpYworICAgICAgcmVxdWVz
dF9vZl9iaW9fZXhuIH5wcm94eV9zZWVuIH5yZWFkX3RpbWVvdXQgfnRvdGFs
X3RpbWVvdXQgfm1heF9sZW5ndGggaWMKICAgICBpbgogICAgIChTb21lIHIs
IHByb3h5KQogICB3aXRoIGUgLT4KQEAgLTQzMiw2ICs0NDAsOCBAQCBsZXQg
cmVxdWVzdF9vZl9iaW8gP3Byb3h5X3NlZW4gfnJlYWRfdGltZW91dCB+dG90
YWxfdGltZW91dCBpYyA9CiAgICAgICAgICAgICAoKQogICAgICAgICB8IFVu
aXguVW5peF9lcnJvciAoVW5peC5FQUdBSU4sIF8sIF8pIHwgSHR0cC5UaW1l
b3V0IC0+CiAgICAgICAgICAgICByZXNwb25zZV9yZXF1ZXN0X3RpbWVvdXQg
c3MKKyAgICAgICAgfCBIdHRwLlRvb19sYXJnZSAtPgorICAgICAgICAgICAg
cmVzcG9uc2VfcmVxdWVzdF9oZWFkZXJfZmllbGRzX3Rvb19sYXJnZSBzcwog
ICAgICAgICAoKiBQcmVtYXR1cmUgdGVybWluYXRpb24gb2YgY29ubmVjdGlv
biEgKikKICAgICAgICAgfCBVbml4LlVuaXhfZXJyb3IgKGEsIGIsIGMpIC0+
CiAgICAgICAgICAgICByZXNwb25zZV9pbnRlcm5hbF9lcnJvciBzcwpAQCAt
NTAxLDcgKzUxMSw3IEBAIGxldCBoYW5kbGVfb25lICh4IDogJ2EgU2VydmVy
LnQpIHNzIGNvbnRleHQgcmVxID0KICAgICAhZmluaXNoZWQKIAogbGV0IGhh
bmRsZV9jb25uZWN0aW9uIH5oZWFkZXJfcmVhZF90aW1lb3V0IH5oZWFkZXJf
dG90YWxfdGltZW91dAotICAgICh4IDogJ2EgU2VydmVyLnQpIGNhbGxlciBz
cyA9CisgICAgfm1heF9oZWFkZXJfbGVuZ3RoICh4IDogJ2EgU2VydmVyLnQp
IGNhbGxlciBzcyA9CiAgICggbWF0Y2ggY2FsbGVyIHdpdGgKICAgfCBVbml4
LkFERFJfVU5JWCBfIC0+CiAgICAgICBkZWJ1ZyAiQWNjZXB0ZWQgdW5peCBj
b25uZWN0aW9uIgpAQCAtNTE5LDcgKzUyOSw4IEBAIGxldCBoYW5kbGVfY29u
bmVjdGlvbiB+aGVhZGVyX3JlYWRfdGltZW91dCB+aGVhZGVyX3RvdGFsX3Rp
bWVvdXQKICAgbGV0IHJlYyBsb29wIH5yZWFkX3RpbWVvdXQgfnRvdGFsX3Rp
bWVvdXQgcHJveHlfc2VlbiA9CiAgICAgKCogMS4gd2UgbXVzdCBzdWNjZXNz
ZnVsbHkgcGFyc2UgYSByZXF1ZXN0ICopCiAgICAgbGV0IHJlcSwgcHJveHkg
PQotICAgICAgcmVxdWVzdF9vZl9iaW8gP3Byb3h5X3NlZW4gfnJlYWRfdGlt
ZW91dCB+dG90YWxfdGltZW91dCBpYworICAgICAgcmVxdWVzdF9vZl9iaW8g
P3Byb3h5X3NlZW4gfnJlYWRfdGltZW91dCB+dG90YWxfdGltZW91dAorICAg
ICAgICB+bWF4X2xlbmd0aDptYXhfaGVhZGVyX2xlbmd0aCBpYwogICAgIGlu
CiAgICAgKCogMi4gbm93IHdlIGF0dGVtcHQgdG8gcHJvY2VzcyB0aGUgcmVx
dWVzdCAqKQogICAgIGxldCBmaW5pc2hlZCA9CkBAIC02MDAsMTIgKzYxMSwx
NCBAQCBsZXQgc29ja2V0X3RhYmxlID0gSGFzaHRibC5jcmVhdGUgMTAKIHR5
cGUgc29ja2V0ID0gVW5peC5maWxlX2Rlc2NyICogc3RyaW5nCiAKICgqIFN0
YXJ0IGFuIEhUVFAgc2VydmVyIG9uIGEgbmV3IHNvY2tldCAqKQotbGV0IHN0
YXJ0ID9oZWFkZXJfcmVhZF90aW1lb3V0ID9oZWFkZXJfdG90YWxfdGltZW91
dCB+Y29ubl9saW1pdAotICAgICh4IDogJ2EgU2VydmVyLnQpIChzb2NrZXQs
IG5hbWUpID0KK2xldCBzdGFydCA/aGVhZGVyX3JlYWRfdGltZW91dCA/aGVh
ZGVyX3RvdGFsX3RpbWVvdXQgP21heF9oZWFkZXJfbGVuZ3RoCisgICAgfmNv
bm5fbGltaXQgKHggOiAnYSBTZXJ2ZXIudCkgKHNvY2tldCwgbmFtZSkgPQog
ICBsZXQgaGFuZGxlciA9CiAgICAgewogICAgICAgU2VydmVyX2lvLm5hbWUK
LSAgICA7IGJvZHk9IGhhbmRsZV9jb25uZWN0aW9uIH5oZWFkZXJfcmVhZF90
aW1lb3V0IH5oZWFkZXJfdG90YWxfdGltZW91dCB4CisgICAgOyBib2R5PQor
ICAgICAgICBoYW5kbGVfY29ubmVjdGlvbiB+aGVhZGVyX3JlYWRfdGltZW91
dCB+aGVhZGVyX3RvdGFsX3RpbWVvdXQKKyAgICAgICAgICB+bWF4X2hlYWRl
cl9sZW5ndGggeAogICAgIDsgbG9jaz0gWGFwaV9zdGRleHRfdGhyZWFkcy5T
ZW1hcGhvcmUuY3JlYXRlIGNvbm5fbGltaXQKICAgICB9CiAgIGluCmRpZmYg
LS1naXQgYS9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBfc3ZyLm1saSBiL29j
YW1sL2xpYnMvaHR0cC1zdnIvaHR0cF9zdnIubWxpCmluZGV4IDc2MWUzOTQz
Ni4uMzIzNTExYmY0IDEwMDY0NAotLS0gYS9vY2FtbC9saWJzL2h0dHAtc3Zy
L2h0dHBfc3ZyLm1saQorKysgYi9vY2FtbC9saWJzL2h0dHAtc3ZyL2h0dHBf
c3ZyLm1saQpAQCAtNjIsNiArNjIsNyBAQCB2YWwgYmluZF9yZXRyeSA6ID9s
aXN0ZW5fYmFja2xvZzppbnQgLT4gVW5peC5zb2NrYWRkciAtPiBzb2NrZXQK
IHZhbCBzdGFydCA6CiAgICAgID9oZWFkZXJfcmVhZF90aW1lb3V0OmZsb2F0
CiAgIC0+ID9oZWFkZXJfdG90YWxfdGltZW91dDpmbG9hdAorICAtPiA/bWF4
X2hlYWRlcl9sZW5ndGg6aW50CiAgIC0+IGNvbm5fbGltaXQ6aW50CiAgIC0+
ICdhIFNlcnZlci50CiAgIC0+IHNvY2tldApkaWZmIC0tZ2l0IGEvb2NhbWwv
bGlicy9odHRwLXN2ci9odHRwX3Rlc3QubWwgYi9vY2FtbC9saWJzL2h0dHAt
c3ZyL2h0dHBfdGVzdC5tbAppbmRleCA0NjJmNDYwNjYuLjRkYWQ5OGEzNiAx
MDA2NDQKLS0tIGEvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3Rlc3QubWwK
KysrIGIvb2NhbWwvbGlicy9odHRwLXN2ci9odHRwX3Rlc3QubWwKQEAgLTIw
MSw3ICsyMDEsNyBAQCBsZXQgdGVzdF9yZWFkX2h0dHBfcmVxdWVzdF9oZWFk
ZXIgXyA9CiAgICAgICAgICB3aXRoX2ZkIChta19oZWFkZXJfc3RyaW5nIH5m
cmFtZSB+cHJveHkgfmhlYWRlcikgKGZ1biBmZCAtPgogICAgICAgICAgICAg
IGxldCBhY3R1YWxfZnJhbWUsIGFjdHVhbF9oZWFkZXIsIGFjdHVhbF9wcm94
eSA9CiAgICAgICAgICAgICAgICBIdHRwLnJlYWRfaHR0cF9yZXF1ZXN0X2hl
YWRlciB+cmVhZF90aW1lb3V0Ok5vbmUKLSAgICAgICAgICAgICAgICAgfnRv
dGFsX3RpbWVvdXQ6Tm9uZSBmZAorICAgICAgICAgICAgICAgICB+dG90YWxf
dGltZW91dDpOb25lIH5tYXhfbGVuZ3RoOk5vbmUgZmQKICAgICAgICAgICAg
ICBpbgogICAgICAgICAgICAgIGFzc2VydCAoYWN0dWFsX2ZyYW1lID0gZnJh
bWUpIDsKICAgICAgICAgICAgICBhc3NlcnQgKGFjdHVhbF9oZWFkZXIgPSBo
ZWFkZXIpIDsKZGlmZiAtLWdpdCBhL29jYW1sL3hhcGkveGFwaV9nbG9icy5t
bCBiL29jYW1sL3hhcGkveGFwaV9nbG9icy5tbAppbmRleCA2OWE0ZmFlNjgu
LjUwNWRiMDI2MiAxMDA2NDQKLS0tIGEvb2NhbWwveGFwaS94YXBpX2dsb2Jz
Lm1sCisrKyBiL29jYW1sL3hhcGkveGFwaV9nbG9icy5tbApAQCAtOTYzLDYg
Kzk2Myw5IEBAIGxldCBoZWFkZXJfcmVhZF90aW1lb3V0X3RjcCA9IHJlZiAx
MC4KIGxldCBoZWFkZXJfdG90YWxfdGltZW91dF90Y3AgPSByZWYgNjAuCiAo
KiBUaW1lb3V0IGluIHNlY29uZHMgdG8gcmVjZWl2ZSBhbGwgSFRUUCBoZWFk
ZXJzIChvbiBUQ1Agb25seSkgKikKIAorbGV0IG1heF9oZWFkZXJfbGVuZ3Ro
X3RjcCA9IHJlZiAxMDI0CisoKiBNYXhpbXVtIGFjY2VwdGVkIHNpemUgb2Yg
SFRUUCBoZWFkZXJzIGluIGJ5dGVzIChvbiBUQ1Agb25seSkgKikKKwogbGV0
IGNvbm5fbGltaXRfdGNwID0gcmVmIDgwMAogCiBsZXQgY29ubl9saW1pdF91
bml4ID0gcmVmIDEwMjQKQEAgLTEwNDQsNiArMTA0Nyw3IEBAIGxldCB4YXBp
X2dsb2JzX3NwZWMgPQogICAgICkKICAgOyAoImhlYWRlcl9yZWFkX3RpbWVv
dXRfdGNwIiwgRmxvYXQgaGVhZGVyX3JlYWRfdGltZW91dF90Y3ApCiAgIDsg
KCJoZWFkZXJfdG90YWxfdGltZW91dF90Y3AiLCBGbG9hdCBoZWFkZXJfdG90
YWxfdGltZW91dF90Y3ApCisgIDsgKCJtYXhfaGVhZGVyX2xlbmd0aF90Y3Ai
LCBJbnQgbWF4X2hlYWRlcl9sZW5ndGhfdGNwKQogICA7ICgiY29ubl9saW1p
dF90Y3AiLCBJbnQgY29ubl9saW1pdF90Y3ApCiAgIDsgKCJjb25uX2xpbWl0
X3VuaXgiLCBJbnQgY29ubl9saW1pdF91bml4KQogICA7ICgiY29ubl9saW1p
dF9jbGllbnRjZXJ0IiwgSW50IGNvbm5fbGltaXRfY2xpZW50Y2VydCkKZGlm
ZiAtLWdpdCBhL29jYW1sL3hhcGkveGFwaV9tZ210X2lmYWNlLm1sIGIvb2Nh
bWwveGFwaS94YXBpX21nbXRfaWZhY2UubWwKaW5kZXggMDg0YjQzNTMxLi4z
ZTgyY2M4ZWIgMTAwNjQ0Ci0tLSBhL29jYW1sL3hhcGkveGFwaV9tZ210X2lm
YWNlLm1sCisrKyBiL29jYW1sL3hhcGkveGFwaV9tZ210X2lmYWNlLm1sCkBA
IC04NCw2ICs4NCw3IEBAIGVuZCA9IHN0cnVjdAogICAgIEh0dHBfc3ZyLnN0
YXJ0CiAgICAgICB+aGVhZGVyX3JlYWRfdGltZW91dDohWGFwaV9nbG9icy5o
ZWFkZXJfcmVhZF90aW1lb3V0X3RjcAogICAgICAgfmhlYWRlcl90b3RhbF90
aW1lb3V0OiFYYXBpX2dsb2JzLmhlYWRlcl90b3RhbF90aW1lb3V0X3RjcAor
ICAgICAgfm1heF9oZWFkZXJfbGVuZ3RoOiFYYXBpX2dsb2JzLm1heF9oZWFk
ZXJfbGVuZ3RoX3RjcAogICAgICAgfmNvbm5fbGltaXQ6IVhhcGlfZ2xvYnMu
Y29ubl9saW1pdF90Y3AgWGFwaV9odHRwLnNlcnZlciBzb2NrZXQgOwogICAg
IG1hbmFnZW1lbnRfc2VydmVycyA6PSBzb2NrZXQgOjogIW1hbmFnZW1lbnRf
c2VydmVycyA7CiAgICAgaWYgUG9vbF9yb2xlLmlzX21hc3RlciAoKSAmJiBh
ZGRyID0gTm9uZSB0aGVuCi0tIAoyLjMxLjEKCg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:18:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:18:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420105.664686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEDT-0004r0-U4; Tue, 11 Oct 2022 12:18:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420105.664686; Tue, 11 Oct 2022 12:18:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEDT-0004qt-RO; Tue, 11 Oct 2022 12:18:35 +0000
Received: by outflank-mailman (input) for mailman id 420105;
 Tue, 11 Oct 2022 12:18:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wAu/=2M=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1oiEDS-0004qn-Ee
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 12:18:34 +0000
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com
 [2a00:1450:4864:20::52e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2d477c3-495e-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 14:18:33 +0200 (CEST)
Received: by mail-ed1-x52e.google.com with SMTP id e18so19843232edj.3
 for <xen-devel@lists.xenproject.org>; Tue, 11 Oct 2022 05:18:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2d477c3-495e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=hudP2FFaaj4NR/0F9kfxxnoFgN58kE6pkjrD7lBVFt4=;
        b=m5OcWoklQEqbJVdIcbbnxKVNtqR/WBFdnw2HrbioyHjUC1UzzkExxMJcJUuNZH7qUj
         K1bWTtVGE3l9rmMBygrIY/LEvSR+k7TNNT1oUFi5xpTvgBXxnMMnshFR5Sm7Si8RLHL5
         jqnDR7kaqGlPgqthaKsS0mHARGBDRutAqKRNuSUslhP71HVcLYbC1a/mi6EO+TiWtQm/
         2UJ7AOGQeWNq4lWSnIWjEORLc9m23uFEv7CX+Q0cjvG/oIPQ8FBFt59/U/agAh635HWv
         hKPrS1PVMcT3ceDPK+mGD4E9IJ1if9nM9IiJ39HIVT1U+nXz04pdOxbbqqfiL3xBU/4g
         fYhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=hudP2FFaaj4NR/0F9kfxxnoFgN58kE6pkjrD7lBVFt4=;
        b=M4DpxgZuGh8B1F/xB+Yar1F/a7J7nGfdOD3INSjN5d8EqEEbBvh+qkrENrtiGtY1mO
         2ztYxSN5i0EQOIdCNIHRKlIHJPpyj20kxGTRLllQ9pXhRRfBNR4FUvjbA5erpzfVSNsr
         rYUYpCPDcQ6tFYzZQXfXDisrw8IP8e0kVHzDGpALQv6mAUBLvK4+sxXvnpwUJululzuT
         aFAUub1MqABvJi38hExKb7Dzzh3VupHIMxHvnQimZ/j7e7oLjm9uv6gxRY4AEbqlQMoL
         8PD0440M8jEjA3L1qJQX8HVK+NUoWGWzoUWgzyh3Wcsf2NFMq9V/2TGBUhS3ROhSqehJ
         EGoQ==
X-Gm-Message-State: ACrzQf09X+RtxUPoiJEcEbECzJ+t1rR6/+cEzSypWyg60TXJiwQkoWLI
	WKCuO5O/pok+uMYzoHq3rVkF1t2j/A5k++o+t8I=
X-Google-Smtp-Source: AMsMyM6oQLSokOjUBOpcu8ldlmCxtYo5c1qvRTuhfGWGDQYUlTtYfhvQ13tl0hZmoKcVZ+xpsY21E2kjHiqOnLrHHcg=
X-Received: by 2002:a05:6402:f83:b0:458:8c97:29af with SMTP id
 eh3-20020a0564020f8300b004588c9729afmr22570031edb.210.1665490712785; Tue, 11
 Oct 2022 05:18:32 -0700 (PDT)
MIME-Version: 1.0
References: <20221007193124.20322-1-jandryuk@gmail.com> <a4524dcc-36ce-267a-afbd-5785eab73882@citrix.com>
 <AS8PR08MB7991432FC3C0643161277930925E9@AS8PR08MB7991.eurprd08.prod.outlook.com>
In-Reply-To: <AS8PR08MB7991432FC3C0643161277930925E9@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 11 Oct 2022 08:18:21 -0400
Message-ID: <CAKf6xpt3LL3tLMEQkxivqVCw-kQhLnZBfjO=kFvim9NwamNkDQ@mail.gmail.com>
Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
To: Henry Wang <Henry.Wang@arm.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 7, 2022 at 9:12 PM Henry Wang <Henry.Wang@arm.com> wrote:
>
> Hi Andrew and Jason,
>
> > -----Original Message-----
> > From: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
> >
> > On 07/10/2022 20:31, Jason Andryuk wrote:
> > > I observed this ASSERT_UNREACHABLE in partner_rings_remove
> > consistently
> > > trip.  It was in OpenXT with the viptables patch applied.
> > >
> > > dom10 shuts down.
> > > dom7 is REJECTED sending to dom10.
> > > dom7 shuts down and this ASSERT trips for dom10.

dom7 used a wildcard ring, and dom10 connected to it with a (driver
level) stream socket.

> > > The argo_send_info has a domid, but there is no refcount taken on
> > > the domain.  Therefore it's not appropriate to ASSERT that the domain
> > > can be looked up via domid.  Replace with a debug message.
> > >
> > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> >
> > We're into the 4.17 release process now.  A bugfix like this obviously
> > should be considered, but will need approval from the release manager.
> > CC Henry.

Thanks, Andrew.

> Andrew: Thanks for the information!
>
> Jason: Would you mind adding a "Fixes:" tag following the rule described
> in [1]? Thanks very much! With this tag and proper review/ack from
> maintainers:

Of course.  It would be:
Fixes: 82a817307c5b "argo: init, destroy and soft-reset, with enable
command line opt"

> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks, Henry.  We'll see what feedback Christopher provides.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:32:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:32:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420153.664711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEQu-000861-Ca; Tue, 11 Oct 2022 12:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420153.664711; Tue, 11 Oct 2022 12:32:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEQu-00085u-9o; Tue, 11 Oct 2022 12:32:28 +0000
Received: by outflank-mailman (input) for mailman id 420153;
 Tue, 11 Oct 2022 12:32:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JHvS=2M=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiEQs-00085o-He
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 12:32:26 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2785284-4960-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 14:32:24 +0200 (CEST)
Received: from AM5PR0701CA0021.eurprd07.prod.outlook.com
 (2603:10a6:203:51::31) by AM7PR08MB5493.eurprd08.prod.outlook.com
 (2603:10a6:20b:102::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 12:32:23 +0000
Received: from AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:51:cafe::ce) by AM5PR0701CA0021.outlook.office365.com
 (2603:10a6:203:51::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.14 via Frontend
 Transport; Tue, 11 Oct 2022 12:32:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT021.mail.protection.outlook.com (100.127.140.243) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 12:32:22 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Tue, 11 Oct 2022 12:32:22 +0000
Received: from 77a78fb4f2a3.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AAD49120-7C84-4D12-AA89-71AB4C748BAA.1; 
 Tue, 11 Oct 2022 12:32:15 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 77a78fb4f2a3.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 12:32:15 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9743.eurprd08.prod.outlook.com (2603:10a6:20b:615::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Tue, 11 Oct
 2022 12:32:06 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 12:32:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2785284-4960-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=bovRSMQALX2r+Ts2sHAQqPNxF5ulfu7oWHofW+PFFRi/GLQFqBCs7tF96Kx6zRgbOSu5F/47Emr6HgOFPJPqGWG/RUR5N438HQzM6dqaB5NfZ0UW4QsVffmcOU2MLy2GzrWxaUqV1QSaVUITcM+/GXb55D5cLHtS5+N4uzLprq2+TzR/KEzi2Dozf48XqR80NzKSf/AFhVMV2Lqc0q8YDOMGicfFfxaqrOI+pnDbgOeC2Dx60tqxlotoAKS92mG/t+PfDazIgC7AJDl+Cabujh8K8LGiZVAytskNlJD3RrOiGjYLrlc0Hil0jaXmGlmaQLRSX0yBAg8s7LFlsI3tBg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kZo+0/jmC8tf0qBn/Jl7wbtEWwCnGQKx+gcTW/4eJTk=;
 b=C3RXerq7mXlaaBtEr321uW8QyS1qLVC7W0BRSwyPiuAxQ3itazmbGWJAzp0J1JnQjNApDoIZlmTZoIR7SfGKQEFqPw2efNr3lYcNS/hljZwfzpE82HrZ38YSP1EfI4w42RLQNfjkbSefr2474SB8xNbjIdsgelD6D8Ks5651SlZWF40LjKLeMUO0Uu6zI1OZ+G1FUz9UtivL/GDBtvqKsCk6PkPcFYeQN8phMhaf30LSyXT689CF8cxqqsAO4G7dnTWaf5iCSCCQ0XqgxOQ0/bVJGWvxyR7/RqHAnEx6+SL18eyZj5ygaD5dTXSk7rZEjRtS0kIL0+4VRn0KBHOmxQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kZo+0/jmC8tf0qBn/Jl7wbtEWwCnGQKx+gcTW/4eJTk=;
 b=k44X7J9cLgSIHaJuJEN8ZIMOZGMHQWP7szHLUKhgUYTDo/aZUZ8NjIhfM9MuadrqAqDUBD4kvkKZEiOHOeLUn7svrvr00nwCwMWlLsnoadcds2AlymqCV4WsevnT56dr1LHA2q10KKhfiKSslLNNBx5gxguyZoV4QbFxFxJBawY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N+/7Yx2Cyw2dDnsfx+TMMhaKIs+8XIP0D+9FAhfVFFXuB3Uku+ro+U/S4HvM0q79sYsP8ngMd1btPbEG4fqK6PqN0wKhz3ORq/itXbhUmIXNL6nTJ7dGOYvPNwaBjTBxEfc295keti7f7sSkX1b8I7j0dqkor5/uP1PWzdQw8ioHeD1bmNf41v1Huejkoc0ZQvIPp3Fp9TAvfFYel/qXSxuvv8y71k2tagzmhLT3ey5p/Qwtk4zOOWpvqBNn2oH1Sdt0rh0oy7FabFdDVJ/t9M77E7ne85OMW4ntiHpjC9ZUZC2S3tqu8ZhGv51oEqiZ1qrMmWPf8yOzLALDuE1rHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kZo+0/jmC8tf0qBn/Jl7wbtEWwCnGQKx+gcTW/4eJTk=;
 b=C1+ahuKroxbAtn1TzuCwHP2Qqmwh8pkEUX+5xu2W9VVqjWdMBqVhriQK3HImwyJoCSK+ukPhS3WS04uCDR45XsHLNxpUIOI1BD2Dms14zmLBb3mqhPYZRzDZ5vy+DXULxhKhn8wSe/uTwRexjTekL5M60VNNQJJ2/lD+AskJWTCR6FBmJfjEbldYHDxrgGljbv6Tw+WIMyKw1b7oaJIvo+5BPs2qPU23vu2UJKnQ/bkK/8AedJiwRPyrQUQriy6SLiOAJ+BQayKm135GK+9V7ircCWdndl2tUPofSUE4dMzM1tALmYnJPmaVqIlQ3jEs/d7WSpCVkuBT3DWTLt9UHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kZo+0/jmC8tf0qBn/Jl7wbtEWwCnGQKx+gcTW/4eJTk=;
 b=k44X7J9cLgSIHaJuJEN8ZIMOZGMHQWP7szHLUKhgUYTDo/aZUZ8NjIhfM9MuadrqAqDUBD4kvkKZEiOHOeLUn7svrvr00nwCwMWlLsnoadcds2AlymqCV4WsevnT56dr1LHA2q10KKhfiKSslLNNBx5gxguyZoV4QbFxFxJBawY=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [4.17?] Re: [PATCH] x86emul: respect NSCB
Thread-Topic: [4.17?] Re: [PATCH] x86emul: respect NSCB
Thread-Index: AQHYyNQExUU6HB2zzUWbaDsrkt18Oq4H/XmAgAEhrYCAAAmScIAACn8AgAAV25A=
Date: Tue, 11 Oct 2022 12:32:06 +0000
Message-ID:
 <AS8PR08MB7991EB68457560FB835E978192239@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <b0103a30-22b7-c010-3e8b-6eab1c25ee47@suse.com>
 <f5851974-86ab-8da7-3b5f-4196faae7969@citrix.com>
 <1fc32039-5a3e-5f74-d6ab-059ab8037338@suse.com>
 <AS8PR08MB79917F69AA9899C2A86C3C1092239@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <6be3288e-7d08-1e07-1283-c68a2acad88e@citrix.com>
In-Reply-To: <6be3288e-7d08-1e07-1283-c68a2acad88e@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B9D7BA4B197AEC49933DB347229AA6D6.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9743:EE_|AM7EUR03FT021:EE_|AM7PR08MB5493:EE_
X-MS-Office365-Filtering-Correlation-Id: 4c79e9fb-e93c-4271-7a5e-08daab84a592
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 nYI9/XQ73jP2THS2QcpvGbx5PhFYfbVGwcmmL6hlghCALG6NV/Y/lwQhe28lt5rgxUyt2woSoGXFH6Cu0RbzP+Hn1Ltc0fMJ1rfRLzpV79R/y185NClHRktSJrBRHjR6OmhueyUXnEYMLeeR1AyQtDlCWN7JZqpencleKZ2XzaxboOvWJvj8h94va17iTtPIXvQuXdTPln+EKYGzraJZCw7gQG7mw30KjXX0MNTNRkLZrM/F2IQCAt6JW0vjWVIIx8CJOxM97qhP7twEOl5tSst6MwfGc1o/ym9YDq0ZMdP3lWtLUnyUhBQHWi5dDdsSxXkp3tpJlTS05nfXIXV/u5f3KiG4QNV7ohAUrHRs5xgRUFmuEx7dpkHzEZ6ZLxt2ADc8e+uQbaqyGfxW5Z/HEHX3Q32+UYAp0xIPdUZDOtuNk7hn1YLGEV7cHE8ilJP7n4X4GjstyHWPMrTbTB0pzbDLuIHvIe1P9K6mWyuJkgryw4Pq8j/i89DacqGWvttJpXFFhHlrcCNTUpUfyFrLCeO08OIwnrUt5sJEToQJVXTnkXtBx6eVlteyRqcy12w7/1mDYw1TF1W2QR6dwBLZjmHhOFhYMklHLLEE0XR5Fgz4vlcekelWhvURutb0apK/GAeg1VbU/cXb4ZHjUDbtfhA1hnNQA5ODN60ZZ80FEgFFSAhw20NHG/7tKYFJUbYKjA7pNmd7SUTSyhHzGF2i404TrAuoCPgAmUFr9EkeSwNHFQGlXwLcxuP9F7OqX3q8soM9nOIYvq94dDaUtjZ8qQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199015)(5660300002)(52536014)(8936002)(76116006)(4326008)(66946007)(4744005)(71200400001)(316002)(54906003)(110136005)(38070700005)(7696005)(6506007)(33656002)(38100700002)(122000001)(26005)(186003)(9686003)(478600001)(66556008)(86362001)(66476007)(66446008)(64756008)(8676002)(2906002)(41300700001)(83380400001)(55016003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9743
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	534841d1-f5c2-453a-eb61-08daab849c11
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WVmPoJcKBwxTYkgLQBL513Ic9MRJyVQvgrQGJvtk/SdWASBE8bEdqE7yu+i2T2tzxPiMAPHKHW0QccePqwWk5nbhduPfQCd5ONRD6F8l01HvgHlZGjbF9yB8nysAG0eLEMaBTU1dCG2u20RYRSRrTCqGY9jtyFlP6YGqXE/xF5GXKg1QnCqsgpQl1+9Q88hIGealMqqysk5EIMOlUKT25z2V5gIW5EhF1GNPq4zqraJ8aTu4WbgNM2PWEk9Koer5AhBu/PgMES/+1lJJz4Aon4ceIfjT1+H1nqYcdsAguYSDZipJzo/P7J5sw7UEzSR6e4LFy22/MzkyDeo9MOsnNOpbLxbpdWsf1qy1MA1sZ2jffpjNKvQOgG9MmWXapxYcaOsDmBo65NXRaB9qamsZ3hnjkQKm1EUoQROdIPkv5+QtSUse0xiocN8sGHmp3Xt50EVgpIyFr7VbUau3fYA8VC838cMIPlFdYfRPxuvtE5pum7p9wMbWtcMZFdnQQ0RD7mQ/z+S2N6J51amJQy6RN8ZehStvikfN+KB7y1pQLL62mp+7QT4E2UEkvHCqyD9FNTtRTsnkZiXTAeVXy1XTgaXJj38lEjDKP07CL+9gaJFU7qf4BulBJFuwGHSvT2vUg+/ggdkS+AeuzTg5VjbJSPKTgyNILKJnUe+KZlYLQxYPBg6Rfe0KSYr5bEgY1S7Lj6r41Ca8bYDYH6KlcP1AzwBdfVFxF+Oi1ukhZ69S+r+clcs2RSyW7cBtcSxynXsfzttJZxaMTHG9iq1J26ULCw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39850400004)(396003)(451199015)(40470700004)(46966006)(36840700001)(2906002)(4326008)(33656002)(4744005)(316002)(5660300002)(86362001)(70206006)(8676002)(70586007)(36860700001)(82310400005)(54906003)(52536014)(82740400003)(41300700001)(8936002)(478600001)(47076005)(336012)(7696005)(356005)(83380400001)(6506007)(110136005)(9686003)(40480700001)(26005)(40460700003)(81166007)(186003)(55016003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 12:32:22.7594
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c79e9fb-e93c-4271-7a5e-08daab84a592
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5493

SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl
dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+ID4gKElmIGl0IHdpbGwgbm90
IGNhdXNlIHRvbyBtdWNoIHRpbWUgb2YgZGlnZ2luZywgd291bGQgeW91IG1pbmQgYWRkaW5nIGEN
Cj4gPiAiRml4ZXM6IiB0YWcgcG9pbnRpbmcgdG8gdGhlIG9yaWdpbmFsIGNvbW1pdCB0aGF0IG1p
c3NpbmcgdGhpcw0KPiA+IGAgdmNwdV9oYXNfbnNjYigpYCBjaGVjayB3aGVuIHlvdSBkbyB0aGUg
Y29tbWl0dGluZz8gSSB0aGluayB0aGlzIHdvdWxkDQo+ID4gaGVscCB0byBpZGVudGlmeSB0aGlz
IHBhdGNoIGFzIGEgYnVnZml4IHNvIGl0IGlzIG1vcmUgcmVhc29uYWJsZSB0byBjb21taXQNCj4g
PiB0aGlzIHBhdGNoIGluIGN1cnJlbnQgcGhhc2UuIEJ1dCBpZiB0b28gbXVjaCB0cm91YmxlIG9y
IHlvdSB0aGluayB0aGlzIGlzDQo+ID4gbm90IHJlYWxseSBhIGZpeCB0aGVuIGp1c3QgaWdub3Jl
IG15IGNvbW1lbnQuLi4pDQo+IA0KPiBUaGVyZSBpc24ndCByZWFsbHkgYW4gYXBwcm9wcmlhdGUg
Rml4ZXMgdGFnLg0KPiANCj4gVGhpcyBDUFVJRCBiaXQgaXMgb25lIEkgbWFuYWdlZCB0byBnZXQg
QU1EIHRvIHJldHJvYWN0aXZlbHkgYWRkIHRvIGZpeA0KPiBhbiBlbnVtZXJhdGlvbiBwcm9ibGVt
IHRoZXkgaGFkIG5vIGFudGljaXBhdGVkIHdoZW4gbWFraW5nIGEgY2hhbmdlIGluDQo+IFplbjIu
DQo+IA0KPiBpLmUuIHRoZSBDUFVJRCBiaXQgZGlkIG5vdCBleGlzdCBhdCB0aGUgcG9pbnQgYXQg
d2hpY2ggdGhlIGNvZGUsDQo+IG1vZGlmaWVkIGluIHRoaXMgcGF0Y2gsIHdhcyB3cml0dGVuLg0K
DQpPaCwgdGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbiEgVGhlbiBwbGVhc2UganVzdCBpZ25v
cmUgbXkgY29tbWVudHMsIHNvcnJ5DQpmb3IgdGhlIG5vaXNlLg0KDQpLaW5kIHJlZ2FyZHMsDQpI
ZW5yeQ0KDQo+IA0KPiB+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 12:57:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 12:57:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420197.664786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEpC-0003se-4l; Tue, 11 Oct 2022 12:57:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420197.664786; Tue, 11 Oct 2022 12:57:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEpC-0003sX-1f; Tue, 11 Oct 2022 12:57:34 +0000
Received: by outflank-mailman (input) for mailman id 420197;
 Tue, 11 Oct 2022 12:57:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W/N3=2M=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1oiEpA-0003sQ-TQ
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 12:57:33 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4473514a-4964-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 14:57:32 +0200 (CEST)
Received: from DB6PR0301CA0021.eurprd03.prod.outlook.com (2603:10a6:4:3e::31)
 by GV1PR08MB7313.eurprd08.prod.outlook.com (2603:10a6:150:1c::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 11 Oct
 2022 12:57:28 +0000
Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:3e:cafe::f7) by DB6PR0301CA0021.outlook.office365.com
 (2603:10a6:4:3e::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19 via Frontend
 Transport; Tue, 11 Oct 2022 12:57:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 12:57:28 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Tue, 11 Oct 2022 12:57:28 +0000
Received: from 789df65a4ad2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FDD5BABE-CE8D-4E09-AF1E-76F8B66B46F1.1; 
 Tue, 11 Oct 2022 12:57:21 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 789df65a4ad2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 11 Oct 2022 12:57:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAVPR08MB9625.eurprd08.prod.outlook.com (2603:10a6:102:310::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 12:57:20 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5709.019; Tue, 11 Oct 2022
 12:57:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4473514a-4964-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=CsDa0TQchRMWjl50hDu+isqeiPf++z9Qhp1cD4rJ2qR50svrC7eRkaFmk27mS9cXfqxqOKnLoT9ekBvdhTaaO663zOCeH9oz6h9wqDwihVLauWMnErBUn2mywu9jaY+v0dn4XB6hctTMZTA5UWitqOCZnte5fIuYBcUvV7klqx6VaY/V2Nyktmf3k3F3kl0GL0I/daY+B601v8VDf0XvRkGX6HOYNWGLHTsLgDpPJBcvlvfHj+gHynOVNB80PcydXWblz8Bvwk6fq7v1UV0gi/DYxL0OoiRm8XGPgO+XQlbalzJGjxf7Hp+7K2aqjAhjQO4guF1oGNJdGxTl1zVh9Q==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=13Gq5yH0/DvrNgjO0367SBt/QtrgEhDlvlSzOEqs0eQ=;
 b=ofT+gf1QUISLpJ7aLGV+8FXZMXVtD/f4CRAA4GZvyZLLU9MkArq273Zm3n8dwEjjqRUt0T2SUpiCr6aDvh2Z9+rpxjBa5bOmw2Z4rsChKJiKQRx/8C4mKC1pc3s1NpA2D9+d8ivF/fongfKma1NVXBoT9/af7rzptkjL17vmazLVU3SaWbjwbie3q7zBjTa4YgQLQ1Ec8t+emZ/780Wd4zxpNgwQYK5c3bojaVdmYADPzpIReojbH/+CrcrH9Vv0aMySbA9bgSrg//2cVeBDsbwVESIgXrT+aefGdufdgVqBCbXpzQD9Q4BZNptMwyroCorLGYwxoCtZRBqcfqzTQw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=13Gq5yH0/DvrNgjO0367SBt/QtrgEhDlvlSzOEqs0eQ=;
 b=HvVY94Fjv9sA4Kd2ObDSNGpRnNv+zBQDeURUMcF/UNHkn+8AgQ/ouDbZNoukhWbfrcvh40scsMiWcmpLzVO3uxhiB6jVlqrMq53KNDYoHamUm5U3nXhLf/fWm22sDVgKfDa85e+pIHi0VKpMXWIdkSCgX0Ym4Kh+DUWOuYjS6Qo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9ba5172e819ffd99
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e/fhkRWsUnZ5ufq1a5hgn89RcU1NCXGp7YNsxXC54Z3oqWzKq5PYYseg9c2qSsU4opnMevdHKsO5vtRjlubcP14Uowb8/ElEAezqN0Rd3CHIqSpE9NnOEvLlYO0LvMfpRIp+iVKDeMh/Ai83IjbCbqecEDz3dg4lAE8CSnmUDkKA+GPoAsAJIgbyBu/GBSvwVK9m7tJgzdbJ1gpBhwgHqpxBp59QcQBstB7kD7eBvKeKKYdyJoBU8OVhamb6KW2hCRFErdydEiTgUfQmSripSZQ+7lEzcKRpGxWeGIbl5+uJM9W0Lg2XCWUA8uCFx0eg3dSnvchqNE/SZB/FDZl8Fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=13Gq5yH0/DvrNgjO0367SBt/QtrgEhDlvlSzOEqs0eQ=;
 b=WrHqyaxSM75ULARqUMfEUNvhqYBHGr51WCEhDAnpoqkXMLa1ZBRT44/QankYwQWQ0+M9L24CwDqT37j8AZkU024OAdeNQ1Dsmz9hUAnBsOEtKMSgKl7F4qk/F09qKPJ6AgrH19Vv6sYV07Ss4ByOBPEbNfh1Wn8Pyiire5F0Wjg+ikda9bjtemDUHH+G3J4/WFUs0Q+840CrUvSwmIG1H5024EuNBE9N6d3HwJsTQf+vcFg8t8WIi/GhBFIzZLk2xbVyqK71ZU2kFAwCYBKQdcpcTl1qmhdKr9zFNlwOcqevw31xwTMAxRXJKX/roYJZt45IfE0SeJ+PSZsN2VBDfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=13Gq5yH0/DvrNgjO0367SBt/QtrgEhDlvlSzOEqs0eQ=;
 b=HvVY94Fjv9sA4Kd2ObDSNGpRnNv+zBQDeURUMcF/UNHkn+8AgQ/ouDbZNoukhWbfrcvh40scsMiWcmpLzVO3uxhiB6jVlqrMq53KNDYoHamUm5U3nXhLf/fWm22sDVgKfDa85e+pIHi0VKpMXWIdkSCgX0Ym4Kh+DUWOuYjS6Qo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, Wei Liu
	<wl@xen.org>, Doug Goldstein <cardoe@cardoe.com>, "michal.orzel@amd.com"
	<michal.orzel@amd.com>
Subject: Re: [PATCH v1 0/4] Yocto Gitlab CI
Thread-Topic: [PATCH v1 0/4] Yocto Gitlab CI
Thread-Index: AQHYt8nlVEDeUTiM20ag9zvPCK1jqa4D28+AgAWWm4A=
Date: Tue, 11 Oct 2022 12:57:19 +0000
Message-ID: <4B9E702A-E606-4A78-BC27-BFCFA60A077E@arm.com>
References: <cover.1661352827.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210071618300.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210071618300.3690179@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAVPR08MB9625:EE_|DBAEUR03FT025:EE_|GV1PR08MB7313:EE_
X-MS-Office365-Filtering-Correlation-Id: b3b73797-c338-4011-10fa-08daab8826f7
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 isBxSGiSeTfw5LuW1eeCj/BptV35jW6FOqzL/QHPjAKjP+KAFinrKzDvMt9yzTdqX780nU54vznUD7ziuE9099lFjh9qnKyXRIATlsKxrBvk+rsETQbzB5a6JYfkR4GzRiJ3j1Bkl74fLfz+Ys42YPv/DHfhVsT1G0z3HK7pN1nZUqJvcMNkDqf4pjaSGFwzLlTa423S81hhwztsIYO30L6V/Fb6LBo5HNmtWXEec3ULmVoZiCFxJ5qvWSVxSffOS977Hxc4ejx+fJuSXsZtSd6osocrMGaEtAurSJ4Rez4vwffPG1xgIqJlzr6YKqGgn5lWr6yXclzb8ySD5Bh+7UhgqqBOimbpXRduiOvUt2CJcTEkEvnKjr5D9g68xQzSHOEuWVGtsx64NuuiIsAEwGdxUKAIxnZsuMZg+s6h8mEOcjUbdUvqO/M/wQfpotEJ+f+RPY3TF3Z4iIssvYqEwFXMDimOO86L9LtmDhCpXhu+wYSjMCNcD/lnE2YNlvL3uL8Ookw7PpwsvHEcN919sEayeC9JdaqB/9IbAOeE1VtE6O0C5SbhzIhPtTtiebONcL9cft6h5EUGQWssuCfcIWcvQbUjSHi/nlRgx5LsRXy98xMX5bMNHca+JYlhLj4NpO+ZkwYriITJBwMGvCcl1mvkYYNW/fZOWQy7eChkkMBhO+h39niSPYTqdrkXLK3Ktl8gK/4dMW5YjpzVXx9yC/KP7kfp4Q0B27x83eVD/pQZrjY7+/bTJ6WPc8AoOvAzDKG24ZY5L0v4pgllzR8d6/O41atsYO1tnHtGDcJG96U=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(451199015)(478600001)(2906002)(6486002)(41300700001)(8936002)(38100700002)(5660300002)(33656002)(36756003)(86362001)(38070700005)(71200400001)(83380400001)(6916009)(186003)(54906003)(316002)(6506007)(53546011)(2616005)(26005)(6512007)(8676002)(91956017)(66556008)(66476007)(66446008)(64756008)(66946007)(122000001)(76116006)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <40CA5AB2E20838488BBC4A5B2995B201@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9625
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	386d8c5a-5bec-4be9-6085-08daab8821e4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Zy/YnMyohrTrBIC6cSufoFK/kyaEcDti0RlO2cBipBEVqIBCUNQocFTO8p3KokwaI3ID8udQM3Sb+zv/eSTxNWARFWAC9mJGjLXGLOVawVD4Y2OgdeXpAB/fzpj5GQV/Gq6gb2nCBpPF2GX2frR9baoBvO3Egf/ZaU2dPuqF0yddIZHHxrSgjfZPptkAmuCmCXORIAOJh3Hs76KhlqhI+BDiF1c+bqoEdqqeEqZbJu9NbTLoXXnyKCRqRM2OfQzOgAMVRFxZeLXNmBVNZzebk6u6mt6jvFrPvpsL+4vhtgE+AH8TY2zFAuYqQOQjqM+EJb+860HpzbKhGEb9ni1eqS+xia2hBVcVb5HDvJJz9dME8p5wcplAmf5QqeDdliHfK2t3ZNj+mGW/uo+w5KTOKybdQJ9ktb6i3zfB2Q4ye/3N23j1tDISybjgEfkS4WuGB6JNBUyJWTZfW8BNlwUHXMXyDwFwysVzfzY4KLmVDv+8qvapxtqHJBMhNJdnYBxG7WJXUOMDOgY1rHf2mZMp0dswBvRiA6vWh8vNz6hfYrliF7GXq+OSOvwr0JTpQ2oC2vHBYX26dINsg4cL9jOMkYfFkDLFy6FMOKW+5r/v1aj9ePfcRnBvDK9MEqLbY+Bp9jS+memCeYR2Kuuktm+0/lpqLLRXHoQD8eqtZTHQeDs1BrNrPc29W4iak0iySLHuTp8dPxayuJpPTQ5omwEjjmm9QRfqd3c9tZQ6LPK1ofohZjqotJqD4IdWYOZjYi5rNEnZqDPxHjFV0MjhBkkauQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(4326008)(8936002)(8676002)(70206006)(41300700001)(6862004)(316002)(5660300002)(54906003)(70586007)(36756003)(2906002)(478600001)(6486002)(82740400003)(6512007)(82310400005)(26005)(53546011)(47076005)(36860700001)(186003)(6506007)(40480700001)(81166007)(33656002)(40460700003)(356005)(86362001)(2616005)(336012)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 12:57:28.3974
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b3b73797-c338-4011-10fa-08daab8826f7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7313

Hi Stefano,

> On 8 Oct 2022, at 00:36, Stefano Stabellini <sstabellini@kernel.org> wrot=
e:
>=20
> On Wed, 24 Aug 2022, Bertrand Marquis wrote:
>> This patch series is a first attempt to check if we could use Yocto in
>> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
>>=20
>> The first patch is making sure build-yocto.sh is not catched by
>> gitignore.
>>=20
>> The second patch is creating a container with all elements required to
>> build Yocto, a checkout of the yocto layers required and an helper
>> script to build and run xen on qemu with yocto.
>>=20
>> The third patch is creating containers with a first build of yocto done
>> so that susbsequent build with those containers would only rebuild what
>> was changed and take the rest from the cache.
>>=20
>> The fourth patch is adding a way to easily clean locally created
>> containers.
>>=20
>> This is is mainly for discussion and sharing as there are still some
>> issues/problem to solve:
>> - building the qemu* containers can take several hours depending on the
>>  network bandwith and computing power of the machine where those are
>>  created
>> - produced containers containing the cache have a size between 8 and
>>  12GB depending on the architecture. We might need to store the build
>>  cache somewhere else to reduce the size. If we choose to have one
>>  single image, the needed size is around 20GB and we need up to 40GB
>>  during the build, which is why I splitted them.
>> - during the build and run, we use a bit more then 20GB of disk which is
>>  over the allowed size in gitlab
>>=20
>=20
> So I tried to build one of the build containers on my x86 workstation
> with the following:
>=20
>  make yocto/kirkstone-qemuarm64
>=20
> but I get an error from the build:
>=20
>  21:30:20 build qemuarm64: Error
>  22:00:38 run qemuarm64: Error
>  22:00:41 Build Complete (2 errors)
>  The command '/bin/sh -c /home/$USER_NAME/bin/build-yocto.sh $target' ret=
urned a non-zero code: 2
>=20
> Anyone else is having a better luck than me?
>=20

I did a new run and everything went ok on my side.
I will push a v2 of the serie to dump more logs when an error is happening.

Cheers
Bertrand

>=20
> I don't think it is a problem if it takes a long time to build the build
> containers because they are not built often and they are not built as
> part of the gitlab-ci runs.
>=20
> The issue could be the resulting container size. I wasn't aware of a
> limit in gitlab -- I would like to try if there is a way around the
> limit (either by changing a setting, or potentially switching to a
> premium account.) However I need to be able to complete a container
> build first :-)
>=20
> How did you find out about the 20 GB limit? I couldn't find it in the
> docs. The only info I could find states that there is no hard limit on
> registry.gitlab.com.
>=20
> Cheers,
>=20
> Stefano



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 13:02:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 13:02:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420206.664797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEtd-0005NJ-Qk; Tue, 11 Oct 2022 13:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420206.664797; Tue, 11 Oct 2022 13:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiEtd-0005NC-O0; Tue, 11 Oct 2022 13:02:09 +0000
Received: by outflank-mailman (input) for mailman id 420206;
 Tue, 11 Oct 2022 13:02:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiEtc-0005N6-9f
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 13:02:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiEtX-00021O-1S; Tue, 11 Oct 2022 13:02:03 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.14.212]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiEtW-0000OD-PA; Tue, 11 Oct 2022 13:02:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=x4kUecLRn/PpXV1NA2Xv+wHU7ZIN5eA7nNXU1lzxSeQ=; b=m3IYHxRfVe/qYuqp0TSpd47nbt
	csiIiKbODTEYFrGDktJvBKk5zI1lAlMKfVEk8M2taSvHTm/r1RwmckJdx0PmVqVgPeqeBFzxlWFY0
	MjgPhHXr+O2IozdCRfmx+PZkaNsu8CV9SPn1OKvOseqlPtkT23Nfem/nq4/I6xFsH9Ro=;
Message-ID: <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
Date: Tue, 11 Oct 2022 14:01:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
 <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 11/10/2022 12:59, Jan Beulich wrote:
> On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Rework Arm implementation to store grant table frame GFN
>> in struct page_info directly instead of keeping it in
>> standalone status/shared arrays. This patch is based on
>> the assumption that a grant table page is a xenheap page.
>>
>> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
>> to hold 52-bit/28-bit + extra bit value respectively. In order
>> to not grow the size of struct page_info borrow the required
>> amount of bits from type_info's count portion which current
>> context won't suffer (currently only 1 bit is used on Arm).
> 
> I'm afraid this isn't true: There's no requirement for a guest to pass
> all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
> tries to obtain a reference for every vCPU. 

AFAIU, this would be a reference of the **count_info** not **type_info** 
(which BTW will never be incremented on Arm because we have no type 
support).

The commit message is only referring to the 'type_info's count'. So...

> With my adding of GFN
> (really gaddr) based registration of the runstate area (already
> looking towards 4.18) the maximum possible count is to further grow.

... I am not sure which problem you are referring too.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 13:21:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 13:21:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420241.664911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFCQ-0000xh-Nh; Tue, 11 Oct 2022 13:21:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420241.664911; Tue, 11 Oct 2022 13:21:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFCQ-0000xa-L3; Tue, 11 Oct 2022 13:21:34 +0000
Received: by outflank-mailman (input) for mailman id 420241;
 Tue, 11 Oct 2022 13:21:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiFCP-0000xT-JL
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 13:21:33 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2040.outbound.protection.outlook.com [40.107.21.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f1ac112-4967-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 15:21:32 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 13:21:30 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 13:21:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f1ac112-4967-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P3wOkGMwTjfT1ALFEoVlVJwKJN1uGgtFAZrNQcFoQGd710KwpkXQwg3BmWZd/lIhvlmmTpI+vnx0v4Wtt5CUMf4GSrbHqOq2/aRn1lcxBBW60JZ5JlHbahtmk3uRFHJV+fjKbxYpp7364pvK7/bhReoBaGlqyttgNPdu/3YbL4KJiZYCBHJd7DxMIvrPF4ZJ5jXCcruAIOYlT3fvcaYjPvk5su9cpVcTH4TGV5hmncUAP95ND18fNJxKhVdG7Ar/j7uvIGskBps/CFLhj9l2YD5Mek/EKQr7PBfFtThGP0s+0LMdtTCKpFde/ua0/eCMyt1WuFcP7dswZsh3CXV4pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zqwqqaA9FVLMp5U2TPTFMwQk9XAGEadfa7OT1geaFg4=;
 b=SI6DGWBUC918FY49TZO1pFyT5ES9gLS+VUPsfkkUwB6HJdewYN/DZLr/6Kqn2MsLXMkZi8yUZcSDIKx7xcLR7qNXfDorcXE2iKYZ79/qXBbxl35BePy6tysNxMW/6/qf8qu4SjpEsdHbTxjKUniKMQs9zXfRwfmgjPmtNTelTkKMoEanhpKEim0N/lRLJCWcTZxfjjGbFV2fMjMZl3PyiJXuLzKSvEe5x6LjpM3VsuEMlUKofNS16q019O9zlH098RBwrztqZ4i04ct0qmiogP8s7ZWgLzgJbxak24DSkw6wSf49IGSAW1DQay8Cw8pcVREJpLylnQj4ikhevljELQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zqwqqaA9FVLMp5U2TPTFMwQk9XAGEadfa7OT1geaFg4=;
 b=k5ZBPsh7oYTo0OvMbWfw/HXXf7raSgm4zLN3mGpP9GTkFmf/G7KFw/pWx4zQ+QZ5LkQJxdepjmgSH5Ty1crIecmZg89pAXto2iu9VZ5ny4u2WIUQkIhtLy4J+AA4uh1i8ziIHt9q4iecbtLz+OUO+LJyh5AeYEvDT77j7wCvvr2o2BCaIMXYY6RqQSiK0Ec457SAWusex5z5qXfaEKnMibFwAdDap/t64n6JyHeQPpTqT+49ZCeMXjRtwObcs4geLBCuTIHESu+eyVYaetnZiZrfKtK7CKLAjwLgQOZbn+i1wH+lhUaWW2vBUF7ldmKwRGi1RbVuDEnsGbyzsALNRw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <591495f4-28f1-f50e-b426-d7fbfc7e2f87@suse.com>
Date: Tue, 11 Oct 2022 15:21:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: preparations for 4.15.4
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Julien Grall <julien@xen.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0178.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8824:EE_
X-MS-Office365-Filtering-Correlation-Id: 605846ac-935b-4807-cf31-08daab8b8280
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HpTJcrIQf7qUG8hXU4tApjVVQpvL8yw1fCvX21Qu4MT2OzUjIed2vNNCoqVwQWEPaqru12ScTeaHOqVcKr9zpXY2ijU5uSsXYLqerd5Rel+Jlny1f567qUcg425qdxdg87bq1HR5BoYg9rk5DYOuBBg6PhBgzVsxd0XBUuIO9m2G9UeTiCXv1HPBGM8MQAa4DjcNKickYkDJX5xjzUlNC7/YO9n1dFW+ADimYZ1uVxfN9nk/8gSDK0lPM3w7yZKsGJKCpFL7XZHoLSJPhjGBkmVP2GdUKWiiePC3eV2NMgiuY17CkbAUYWH9x4bRTLbVBKtSvxYRsnt8QH+GTD7p/65C1013sKwHNmQKVUrlY0Hnra7vFfLi8g1+FaO+RnmCax8x0d9oJs2GXEa2F5SQXxAKClBSlXkkLVujPVxShLy061aqRmHMe+d0CsNdMneQpFu0O0o70ov5itZij0UYjbc3iE+7x9GGZ97KtstuBc7MZE4dokESksKI+7IPGIkdruuP7w+EMGampOA+I7cUfgC3ns/qGDZVngnIBSEHiyKUBy4+BiZFD+R817+T3odRIdZzxLTWMpJe0ja/DqqIvRL2hDHpAdMT4gRVdQjmV3hAEYY8KWow3Bf28yrTVXCZtIOadlWgBZPSOHNkfJld+2LcBsImuEGS0skKO4OgxLlufI4JVqs2ikVNuMilJ1ZB11muJ2J8bE3BqtHz+R4SuGMZcIAiYuI8ibe1LZWryMC/ci9wC4Iuf4Br/Se8P3zHQtEiBKwHEA+n29rJZnfBS21/er0PMobRPr6/YDZjvAo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(66476007)(36756003)(38100700002)(66556008)(4326008)(7116003)(31696002)(316002)(66946007)(86362001)(8676002)(54906003)(2906002)(6512007)(4744005)(41300700001)(6916009)(8936002)(5660300002)(186003)(2616005)(478600001)(6486002)(26005)(6506007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGc0TytUVjlOb01NUldsa29UTWw5NUlYQURaWUVUOFV5WGdsVmFUUThFWUpm?=
 =?utf-8?B?Z2cxUm5RVjAwSGphdVd6OHNoOVZPUGY3RVdWOVZIL1MwczB4d3VVZzk2MFM1?=
 =?utf-8?B?elVPOG80c3B0dkxJTHI3eU1Od1BiUWJLT3c5czlqM3ZCQk0xVmNQL0hiVWhk?=
 =?utf-8?B?b0d6a2R0dkxUcmFxS2x5R2lDTU5SOWM1Wm1zMkI2VVRmdmk0SWUyRThIR3hL?=
 =?utf-8?B?ZmMvMFl6aHl0dTJIUG9mSmFKTUd0ZWlxUWpDajJJSlI1dEh3R3d3MGwrY0do?=
 =?utf-8?B?dDlGVktXM1RmZ0h1YWdabDVzZFBvdE5vUnU4dXM2dXVsQnZtazY3RUhXOVc0?=
 =?utf-8?B?WnZ4L2IrYzJ5Q0x2K3l5QXZHSmxtU2NPT0hmZ3FJZ2ZEOHdNcElwZCtOL2d5?=
 =?utf-8?B?d0lyUHpMd2dRZ0dBVG1nWEtVN0JKZ09GNU02YXFmU0VTRGFHS2s5Q09UTXVS?=
 =?utf-8?B?aWZMWjJVVTd4MVVQaitkL2hlMDJIMU9LNjJkazFZYk9iMU9WMTg4TUpMN0pG?=
 =?utf-8?B?MzAwMWkvZmttczJHOVBBSmgxOWdWczEzT0ZrcDlwTFU3TTl2Mnl5bVVLL1kz?=
 =?utf-8?B?QlNmY1V4aW5JSDUydExiR0NlN2FWWmNpaUdjRFR2UU1FV3JkcnR4SkF4M1VC?=
 =?utf-8?B?WTVPWWVTQ3loLzY5RDhwOFhTNUpvV1hHMjFuTDhDTU5ReTdjZ1FpbmtJR3cv?=
 =?utf-8?B?RFhBM1EzSmI3UHUvazZiOTJoM2kwY1VrVG9STnZVd0h5b1V4SFcwRkQvVEYx?=
 =?utf-8?B?UmJBQUF4aVErRWxnMkZQZldIZ1g5WmlENkpwMWxtb3V2OHJEZkpnTkZJZnlu?=
 =?utf-8?B?emRSSnVCSlNVQjJPWXhmMjVSNHBYYzBQN3dONktPNGdyZVFNQ2NqQmUxU1RG?=
 =?utf-8?B?cThXWFZZSWpuYm84NTRZOERMVDQwL2JCSlR2VjBrZ1hVb3pOQ1J1aloxMzEv?=
 =?utf-8?B?U1RrQWVkdC9kNjc1M0hYMmlWSlB3djQxa2s5aXpJMGVpWWYvWVROTUR3OXFp?=
 =?utf-8?B?ZEJzMHhYVHhBVG56WU1Fb2ZkSFl4WVpTTERmZjdCVmtaejdpNkprZllhWFRP?=
 =?utf-8?B?UkxqQTBjZFpHTkx6clBMcC9BYW11VlRnRnBBSW1TaDZ5S3RFUTgrYkxYNStm?=
 =?utf-8?B?OGdrakpHbVAxZ0hrOTREYkRqcWNqNFh4Z1VyVnRvYTA0bXJUK0RRaGZvOG9S?=
 =?utf-8?B?M2pZUzFIOE5UZTZYS0oyV1JMZGVLK3dUN01yRHh4WWlpMHMyVTQrL1owUXdQ?=
 =?utf-8?B?RVJDVVZselJ1NkU2c000NDhSbHhyV1J6QmJYOERUTnRCdVJyazFLM0svd3M0?=
 =?utf-8?B?NXpFLzJRYzlWK1Uya2xkcFRBNVIzQk9IV080ZjN2b3drNlloSGRaV3gveWVT?=
 =?utf-8?B?VXNKU09zM1ExMjliV1JueFA2aUptRjVJb0xkZUZGZld0cUpOVmphWEpYSytB?=
 =?utf-8?B?QmtrT043aGI2UVlxdFpObVhaT2JmQVZBMXk3ek1OazFVWjkyQXI0S2ptdnVS?=
 =?utf-8?B?Yyt0OUprQmNRUU1PSmRKMjdDbjdXbUNxakQ4WlVrNEozRDViTHBQeStWRE0z?=
 =?utf-8?B?Rlk4VnNZUUtOK2tMMHdLTFhNUEtlUXpiUU1lM1JDVHFtQ20zL1VhbmRWNFJz?=
 =?utf-8?B?SllUYkJwZzhBTzdrQ1pTS2JnOUVoZS9IOTV0VmhJWThEN3p5WU1jK29kUVdI?=
 =?utf-8?B?QlpQZXUxODUyVm00TjNwWlFnZUdyTGtTREtEUm5TMER3bVRMV3dvc3JZeEwr?=
 =?utf-8?B?WnhDNzYrYzhkQlZCWGtzRlBBcnErNWtMbzJUR25KeXh1YUQzSjFoOW1jQVpq?=
 =?utf-8?B?K0trQ3JDYStsalowREtoQjhYKzMwQVhDazN1Y2RsMlhDcDNsRVpiaFpld3k2?=
 =?utf-8?B?SE5NWDZLTjhxTTZRRGtGQW8wb2lBNjFpV2JKSW94MlIzdXF3Q2JBZERrS0tw?=
 =?utf-8?B?Rld6eVFlSGhwbVBLcDh4VkJjb0NwUU9YdVhMeXkvMW1IVGYzTkplYk91ZWhx?=
 =?utf-8?B?UklRZE8wcUplZlVzZ0U1Tk5LVG5sNzNGYnAxMC9VVTcwQnlGVTUwQlptRlZv?=
 =?utf-8?B?WE9RSUJsdW8ybVpDUmFkbUZmYzM1ZTNkTVJIZ1pZQytUMDRLcFp0Sk5rTUJ6?=
 =?utf-8?Q?scIqaHG5e4w53h3X/FY23vjOk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 605846ac-935b-4807-cf31-08daab8b8280
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 13:21:30.7129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 10i6eYgTLd4RqdoXEjXe4Iq+HpzWRjZKpQK9TQUP5QydR8TD9qIg/32M5mp/vRIQpuDOd8UZbNfe8VV9N4nOGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824

All,

the release is due around the end of the month. Since 4.15's general
support period has ended earlier this month, this is going to be the
final XenProject-coordinated release from this branch.

Please point out backports you find missing from the respective staging
branch, but which you consider relevant.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 13:28:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 13:28:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420276.665023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFJ9-0002oB-MW; Tue, 11 Oct 2022 13:28:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420276.665023; Tue, 11 Oct 2022 13:28:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFJ9-0002o4-JW; Tue, 11 Oct 2022 13:28:31 +0000
Received: by outflank-mailman (input) for mailman id 420276;
 Tue, 11 Oct 2022 13:28:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiFJ8-0002ny-K1
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 13:28:30 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2072.outbound.protection.outlook.com [40.107.247.72])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98079aef-4968-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 15:28:29 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8767.eurprd04.prod.outlook.com (2603:10a6:102:20e::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct
 2022 13:28:28 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 13:28:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98079aef-4968-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FpBP5ev52dLnuZfK2I8HhQ1BdYMGmHVayjjR22qTGn6Y13jc0zdB9z9lS4b5N6MexgpV6glO9leN1oLANcWOMjK7+pEtjERd9gRe8CpkS4r5OLm8Il4MyV8zlqEWoEXUYMae5lT1ksEWmc4dAijllroX7i7QK1fFBnlm4fI2wlfQscPUUU61eBLZ5iajoOmX88gfjMcLCXGRaVK9HrlFrqqJu648SMZoD1a4cqktOVwZxXm6se4vLxB8H2xM99rTkhjvuYjnzkKH1guIN/KknkQfg7REXDiLzZrRak3A2UZioaTYgC4B2vm18XyvIFhpQOVDCvnNCuAt5NCFQa+Nyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3KryHIzf/Kz8GVsaPjcvhzBMiBaQ5ofEduiQuZ9eTRY=;
 b=XxtxWfr26x10Ay4R+3/pmWn6j01GrzOVYc4W8qmW8JW36FUNkP1CGP2f2cV5HJvFNuHCPGdbDLJ9uJIP3grZccDm+nk1lOT3wT8Wo3seomTTo/u4dI7r/KPyYO1sf+x4ZEweSeHozN4abVZhmeI4Y2Xm9fs0JUPsKiQ977ddEczLO2+hPoc2bfJJZr6Xo8DggrNsWzaMyuvXdZbVCq23GSfdZrpU7vyIgKfX+7QT60K4WmZKPpsxX9Cid9FrASCvLP44F/FvHBUMm3zt02CKaDtgohqrHPe3KRpDYTsB127l08Gtrtc22aVYR5tWR8trkKSXYOHfV6iLzHHllkzDFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3KryHIzf/Kz8GVsaPjcvhzBMiBaQ5ofEduiQuZ9eTRY=;
 b=UTGgTuXqUi4Qh9pxWTC/Ur3aSRqAIa0WvK6XaYIGPt4zfrkEtQJ7mJ5/lFBHBip+BXXYHNS4gslM4tPR8AeYqv/9HqKFHDNxQMp1B8SgxX47uZqcFMJW2I6UXa09eMBfPY/vhsGkbTquaKYnLFbEQLDNS9ykC894+HVVkiazUkMIujcxC3KGEEeXG2cLsaQf9W2U3nFJXpVqw3Sy3xChISzW+AwYd7OxCsG9r+vTo8Qb+TZpvF9Bz3z+d2gTxUm3bpBJ66HxXMq0gHCkynLw6lhFMyjV22dPgxKRssbGiUEh/9o6I876fjEHR1tl6e98S9ULXu/jYee5iQg0XUpomA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <77349d2b-de72-3e68-362a-493f350eeec4@suse.com>
Date: Tue, 11 Oct 2022 15:28:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
 <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
 <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0014.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::7) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8767:EE_
X-MS-Office365-Filtering-Correlation-Id: 31f97ce3-678f-4cbd-33e5-08daab8c7b75
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kuZcdMuX1289I+e3P1Rw/iYPIp1BS0tN45EpaFS6hN+ekduAk2j6FtmYYdCHnx1gtIJ2tOmc8zjk51fL2OfSnnY8f2cPdKR4/UZ94OV00KfSmMocuTqwt4ta4UTRCv2yRYXi+Tyt0JafOXCwy6baibR64p7cmieLmgb4WJgiRmB/ZRRhJRd222zzzMFunv/HlIAfcrCTENx7t7YtV6ClkxymQnhlVci7N3aC3e0QLjZZ9WpzeaUc/0Ctn2jiRDz1XzJQyoOlNs8eA0ZC9ik8KB+D3TVdaMezNF52KL7CUBFnGTc+nQ6i0F/lj+bBARxsv6ilCSJbED42Ws697LX9+SLBOTZqtRxQPKx7C5PTM+yofk0QSw9aMTcdLKa/A0Ad4AySMs78czqQy68WN1WvKqzeaZjQfQZjIYPU8IgMTvh9+g/SIvGG24OZ0F1+9M34QORvQjrvo7rqUPaYPJ6XXe3yYwv27iw6HlHTQGbKZroc1Xh7sbLA4Kmm7arRpwtU8uqm+kYn752u7KsTStcCDD4JD8ndFtte3g442dojHMsdJRyJ7DHSm/YANlhw8tI+sa8tsOWIFH3ujstxoMDtyRacwbnz6dZK273NgBeMFAzx1RNjFQw6Y4kIMMZYMbZqRnE/2mDIYi9vz2TWTuzAj1PaPfpvAofemJ/0NzwdAO9PFQwzk3Y9DTjTOoo/3BiiEiG31qXpX3aKxI1Ng+IraOiVL8trCxwUJTZpdJqEJ0YR4li926HRHJomY71GpyVwjavTQfhTPfpaYGuDuC1kED0Mysk+AmdryVKunIMC0lE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199015)(54906003)(31696002)(8936002)(41300700001)(478600001)(36756003)(7416002)(316002)(4326008)(5660300002)(66476007)(86362001)(66556008)(8676002)(66946007)(6486002)(110136005)(186003)(38100700002)(26005)(53546011)(6512007)(6506007)(2616005)(83380400001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c0lVRlY5QU41Qk04MkN3SnZwNmY2QkR3UkF2czZ0R0YvdklpYnRMZk9pMnov?=
 =?utf-8?B?QlZtRm0wdW5teE5ZYlMxLzlTbllicXoxMjhqY0xsdEg0UURCTVJRYkVtNUhn?=
 =?utf-8?B?b0Q3eEQzZjVBYlNvcjk1Q0I2V3RZK0E0RFpCRVBLSFk3MXV2UzZFMExwTFJh?=
 =?utf-8?B?QUxKY2krcGFYbnUwRUxyblg4NDZHVWQvUDJDM05QL3JqUGlvNUFobkZ4WS9J?=
 =?utf-8?B?eXNOM0U4TDBWMkNWUG9QRHdZZStiYUJEZDJoYXBEbXZNYTV1cWdRdml2Uktq?=
 =?utf-8?B?eWNMQnVGTFQwV29PN3ZSWi8rSGxReG5WeVRZbGV6U0JrSkZLUDJ4SDJ5bk1h?=
 =?utf-8?B?RnpMNzhQZkRaRTIzenlRT21OR2dSY01uZXJiTFIyWnFUYXoxUzY1aTZGenND?=
 =?utf-8?B?TXhEZkVaWWVEeEJQdHlMdElFOU5HUEVXbFRSMTY3Ykw0ZExkM3Myc2lkbVJw?=
 =?utf-8?B?T0ZvWWhoQTdmMzF3Q3E3c21YY1ZVS2EvTHJFa2xiWkdpd0ZFbU1uYUVzU1Rz?=
 =?utf-8?B?Q0xLM0p5R3J1emJTc1AwdytnVC9RNDRDTzR5UEhKZXlrUE1OT0lUNkluUUNy?=
 =?utf-8?B?VVFPL1hhZ1RzYmxUbWZGTWhBc0d3Q1RZbW10ZDYwY2hzR2ZUalN4RE1aT3Zh?=
 =?utf-8?B?dnNKVDY0ZlhpTlUvMUdvYkdMMVdndHFlVU9tdTVDbXo4N0xPSU53S2JIaEtB?=
 =?utf-8?B?d3hGalROZUY3UkxFUXc4L3JidlhLeitTVVFzUUV3N2hmQ2JFNHVzSDZadlZP?=
 =?utf-8?B?NXEyR3YwUnRDdmNVMEZrMjBzQnJ6OTJ4Y0NtRm9qNWZWMTI0cU9kS0UvT0dL?=
 =?utf-8?B?YWhmSkJxWGJScFA1SHJFUi9KdWNGOU1Nb0RNNmdqZVdIQzFlMVVBeU9IbUMv?=
 =?utf-8?B?R1M4R1RqYzZoUUV1cUk4Um5pK2RiQ0hRU051dFFSbWxJcCtXVU5iV3RNeEJT?=
 =?utf-8?B?OEJCSjZMbXNqNXZWQTJKQytVdkE0UDJvaHZBN3JaWVRJMWpseFJhS2tqVGFp?=
 =?utf-8?B?V2pNU0R3MHd4ZFlUM3VOM05UWGp6dXBHQWF2OUJMQVlPc3JPZlVIZVFPc21h?=
 =?utf-8?B?RjhvS0U2UVNNWnZBNDFYK2tLT1VMeml1RldlNlljQmhoVDRsMm0yVzlXL2Jk?=
 =?utf-8?B?LzJ5c0NrUFlLK0xIMUZIVTVNZEtZb3g3RG1xeXpKbTBTdmFVOFpTVExoaWhn?=
 =?utf-8?B?STdVVHZ3MHJSc3pDZ0NJd1dTU0lFSFFZVnZFSW5PNkVZSnVKc2x4U1czZzFp?=
 =?utf-8?B?VGFqZEhmeHo1L05nWXo3NVpGTTVNZ2tqVDdscTA3a01ZYUtFQVgzM1NZeTJG?=
 =?utf-8?B?TDFyRjNmNUp3Q3BwdGZIRGVGMGZlMDVyTXUzYVphWEptcm5qb3U2bDhXZ25w?=
 =?utf-8?B?RHQxZjlJSWZ3emluUngxME1wa0tQbTlFYmxuTEpFcStBemI0VDFuR2lZR1pB?=
 =?utf-8?B?R3hwdUptbG5QUGRLcG83LzlsTXpwTmJGbU1Jd1VzOE9xeGV4OTBjU3NlYmlV?=
 =?utf-8?B?VXZvaVVXMTgzZnZpQW1DaWhONXFPUG1LVmUxaWdkaDFlOFJLOGtJM3pibExX?=
 =?utf-8?B?SkJuUjJtM2IwTWNvYUR0RndCYmRmK2h1VXFsb1VXaFloNWE2bG5GdlNPUWJp?=
 =?utf-8?B?OHRXVVphSlVGMTNJUjRiMVJRREhoQlB0d0U5L01uNjB0SElYQ0hjZnZNTWk5?=
 =?utf-8?B?UllxTGU3b3RsbXUwNTlBYVJnWXhaSmxpTVZlWVBxRGhkMUkwODJGaXhkdTVw?=
 =?utf-8?B?bTlGc0tReHJQekFsbEVNVUpjNlA0TGhxMjZQRW1sUDlMMkpxTmdTRUpHM05l?=
 =?utf-8?B?T0NqeWpOdG1Za0dGcEY3K2lLdzVGWGtLanZWd3NtbmZQNVZvdjk1akEvTk1m?=
 =?utf-8?B?ZXEzazlUL085THVaRVcxRUx1SmhQNThoeCtVL1JKb0h5V2tVRG1ESlhhZVNQ?=
 =?utf-8?B?NmhKTmVsbXNiYTZhTFA5TkFqcExkZzdvaWEyZm1HRnh2MjBBK2psenlkaU52?=
 =?utf-8?B?K1p6T0x3TUh4VHlyRWUvZkpWeXgzMDh5bk5aVDJzQks1TDZrWjlqN3hDcXZ1?=
 =?utf-8?B?d2pCamJ4LzNwcVk3dTkvUEp1MDMvcU45UlkyK2lJeDVhN2RVQjhQVklWSGl5?=
 =?utf-8?Q?TVgnRQfnv+VjYoYlp3Vvbnf/D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31f97ce3-678f-4cbd-33e5-08daab8c7b75
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 13:28:28.2646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jKCyIt1yLwMLfeGXVrpWCEVF7kmwruKc0AuqQBxNmGnn64DQSTp1aPFDjzuhV8WrRFAk+umkzcREBvELggMl1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8767

On 11.10.2022 15:01, Julien Grall wrote:
> Hi Jan,
> 
> On 11/10/2022 12:59, Jan Beulich wrote:
>> On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> Rework Arm implementation to store grant table frame GFN
>>> in struct page_info directly instead of keeping it in
>>> standalone status/shared arrays. This patch is based on
>>> the assumption that a grant table page is a xenheap page.
>>>
>>> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
>>> to hold 52-bit/28-bit + extra bit value respectively. In order
>>> to not grow the size of struct page_info borrow the required
>>> amount of bits from type_info's count portion which current
>>> context won't suffer (currently only 1 bit is used on Arm).
>>
>> I'm afraid this isn't true: There's no requirement for a guest to pass
>> all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
>> tries to obtain a reference for every vCPU. 
> 
> AFAIU, this would be a reference of the **count_info** not **type_info** 
> (which BTW will never be incremented on Arm because we have no type 
> support).

I should have said "obtain a writable type reference".

> The commit message is only referring to the 'type_info's count'. So...
> 
>> With my adding of GFN
>> (really gaddr) based registration of the runstate area (already
>> looking towards 4.18) the maximum possible count is to further grow.
> 
> ... I am not sure which problem you are referring too.

Wow - a mere stub (but not inline) function to make the build happy.
Then why is the description talking about one bit that's needed on
Arm?

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 13:33:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 13:33:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420281.665034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFO6-0004RH-8v; Tue, 11 Oct 2022 13:33:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420281.665034; Tue, 11 Oct 2022 13:33:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFO6-0004RA-5b; Tue, 11 Oct 2022 13:33:38 +0000
Received: by outflank-mailman (input) for mailman id 420281;
 Tue, 11 Oct 2022 13:33:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiFO4-0004R4-Vx
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 13:33:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiFO0-0002l8-JG; Tue, 11 Oct 2022 13:33:32 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234]
 helo=[192.168.14.212]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiFO0-0002aI-CA; Tue, 11 Oct 2022 13:33:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=WFc6xpKXMAEIOWCleSu0UUdBGcfxJX5Ix2+BZR3CeWE=; b=ZHIuApTcci4X7s8wo2WC2tyqjv
	ts2wsHfyWJyWHe4P/BitwPc50RLSfDPSs330VzythlPALczN5sqdmKcEbJlXPpCMdg2H0kk2zTvLw
	Rz1PqpvBrkixeLqkE9IldddGYyHAwSdVXE3qceFgG8/f4uevmapgZqNSPW63e6EbkCn8=;
Message-ID: <d297735d-771e-22f2-1b46-9c390ebb5afd@xen.org>
Date: Tue, 11 Oct 2022 14:33:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
 <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
 <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
 <77349d2b-de72-3e68-362a-493f350eeec4@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <77349d2b-de72-3e68-362a-493f350eeec4@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 11/10/2022 14:28, Jan Beulich wrote:
> On 11.10.2022 15:01, Julien Grall wrote:
>> Hi Jan,
>>
>> On 11/10/2022 12:59, Jan Beulich wrote:
>>> On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> Rework Arm implementation to store grant table frame GFN
>>>> in struct page_info directly instead of keeping it in
>>>> standalone status/shared arrays. This patch is based on
>>>> the assumption that a grant table page is a xenheap page.
>>>>
>>>> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
>>>> to hold 52-bit/28-bit + extra bit value respectively. In order
>>>> to not grow the size of struct page_info borrow the required
>>>> amount of bits from type_info's count portion which current
>>>> context won't suffer (currently only 1 bit is used on Arm).
>>>
>>> I'm afraid this isn't true: There's no requirement for a guest to pass
>>> all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
>>> tries to obtain a reference for every vCPU.
>>
>> AFAIU, this would be a reference of the **count_info** not **type_info**
>> (which BTW will never be incremented on Arm because we have no type
>> support).
> 
> I should have said "obtain a writable type reference".

Thanks for the clarification.

> 
>> The commit message is only referring to the 'type_info's count'. So...
>>
>>> With my adding of GFN
>>> (really gaddr) based registration of the runstate area (already
>>> looking towards 4.18) the maximum possible count is to further grow.
>>
>> ... I am not sure which problem you are referring too.
> 
> Wow - a mere stub (but not inline) function to make the build happy.
> Then why is the description talking about one bit that's needed on
> Arm?

Because share_xen_page_with_guest() will always set the type info's 
count to 1.

TBH I don't exactly know why we set it. I always assumed this was a 
requirement for the common code but never checked.

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 13:38:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 13:38:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420288.665045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFSR-0005M7-UF; Tue, 11 Oct 2022 13:38:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420288.665045; Tue, 11 Oct 2022 13:38:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiFSR-0005M0-Qm; Tue, 11 Oct 2022 13:38:07 +0000
Received: by outflank-mailman (input) for mailman id 420288;
 Tue, 11 Oct 2022 13:38:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lm68=2M=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiFSQ-0005Lo-Fx
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 13:38:06 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef049f53-4969-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 15:38:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct
 2022 13:38:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Tue, 11 Oct 2022
 13:38:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef049f53-4969-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TAqyLWgnwc1MzGZbcaO/mrqyISNO5iiM4gZ1kU/DTopaRN4Vd3L5KY8dlJaGH9yQbpMTYLLGLuLKZpI/lD1rtizraDFE4V4UHNXv4FZCTj1ajTWvhG7ulqumM7Wr87+tHMuBX4Cqk6oPSXvSXlOO/8V1rZQZpdebvGTP1SSSNc++Hj2oxduT+opvNd4EIQhLih+XQXo2Zgsup0DCT6b+PRq/ZMX+wepyBcKvj8Ozi8nZcqx35nRypUA3t7j/ZSAd1fL9uES4O/wvePma17YKXNFXXONaWWcmEKB+tX/l3ETYssVMjYNPru9aSwuDCFGcF6tBA+TESB2mShtYEJawLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k7FxmdC11CggFfz6/skPhgjgBNHXzbsJ4GzURyS4DY4=;
 b=aG3y1u2kF5n2m9ieCGogw17gLrw/zKcgaf6TJeDIWtGvz/sDftM3wxoxMSa3MvD/BsgX5X+LGPUFB5xLR/9Pg9Zng3QSigjRf0ZQKqJJQz3ykWSYA725tCISFK803ajDOohGjXNu5NRlJ1V58/qHMzqEvK8aiwprxU98qL+2pF/vTUMNsbAXJFmdGXFgdWlxl/oQyI+9ZTBXSycbRBwU++qaAyvc+ndb1majAs/6NvuwLToX5BMM8ZZ6NhcXajYkZOv+t89un+icXV53rDvt8I4KkOTtEbWTu1KLFni7CUsEDhxG8m2303n+fd7Wgnipe081BAn6h9JR4i6Xq3UA5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k7FxmdC11CggFfz6/skPhgjgBNHXzbsJ4GzURyS4DY4=;
 b=BaVHsRRz2d1mD8ylCJSYlLccKHSEcpLqbQST10hJUNiiocTIdqp3mdnI0Mtr6KQgdvtv1ntf5nrHS6yej3jde9rxLy63qqbfPgEBKhuCMio/+2BleGN/DRFPA0xCoZnQjXIFW3+Ff5oSnUhBm4cVNMNqQ5jxoJg9MOu3amgXq5wbXDCSRlE1VsUO0TYlDx6PekVTysIQwGpnEeMq8ZuQBpbdR7bbWtkI28F574QfBEi+mYhDrbOxIiPZfMN9QHUEVcIfq0RWS7eQnqMw7znz7YS7SkK0BtgahQsoCxNRxkeX6lGwxBkwVfKhSgbSm0Xc6qtRrfl9jLfYxHLzX7aEPQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f417bc91-8453-92d5-e357-30e584130e67@suse.com>
Date: Tue, 11 Oct 2022 15:38:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
 <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
 <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
 <77349d2b-de72-3e68-362a-493f350eeec4@suse.com>
 <d297735d-771e-22f2-1b46-9c390ebb5afd@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d297735d-771e-22f2-1b46-9c390ebb5afd@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0083.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8898:EE_
X-MS-Office365-Filtering-Correlation-Id: 607a6902-1613-450b-e381-08daab8dd237
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XPfiLv7R8q2Io/IesH9UqejZ1jCwI+AOq1lFQeZB5tB0IU9oFzcR8RdKaOmiDW1V8FDUtBFd45W+VAMn9ahdVA+QCkjvF2poufb+UMvBNrqizE1yn/UksKnSkdkSwHqtlTSN8n7jJNuPIWim4vsGBQdJW64Ga4Wot+xyaPK6HhzakJDkQLnV6d872p+H8GNfC5zsscryhopB1c0bPqaVeANZVmLdhZePTrf0+8zMwual83z7CNYRKbImEZ0P6SNa0sxCpkspKZmEbD+aPMQ6EuaF7JsBtNvfXjY+Yt1qfcNAp/455fyDR5HJMIXvNA3cgTDOnizzzDOfjGyOzyj0exIrot8W3JMIDioPV0QE5CqeTPPHHeRuTPMcFr+Na/8DRSrBRPSDlowEX41m1GLgL5AnFHVdLbuuZ+jexxv9r4/Fb+3Aom0I1xaMB+NPFiZBV7MNApiFkyzMf5/miX6OcIRkRZvyXjcTEWDa5Xj5+DCMTDiZUm8ZvRiOuMdoo8LwIANEhlb2k5/YYMcUkSK6OPnfZw9JcMSuzcjaDCZgFUBPHnaAceNYNx7PDL59sOyUqXnmuA/Ru285Fu4VwgxnAUxFzDRNOX/cluuljyHlp/BF+AUnHQAB17APFvsHx9xNJUbMe3ZxqjcPcCt6Bt3NzqQVdl7+xvdUp7IA1FRcQZnhb8u0mnBZI1zM7niDAquJLgQVJiR4LuFxkecnr7z3AZftBXq9BwWqCck0HnYDtPTh8nm8fY5tppg6F5ck1kl7DjFPj8vvTIlUInTVWZQAEODholq84lJQ4BGdkYXUE1Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199015)(31686004)(36756003)(6506007)(26005)(6512007)(2616005)(186003)(53546011)(6486002)(478600001)(2906002)(83380400001)(38100700002)(4326008)(41300700001)(31696002)(6916009)(54906003)(86362001)(66946007)(66476007)(66556008)(7416002)(8676002)(8936002)(5660300002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dnZsdkttMnBBNk8vTWg3R3FwZnFuZDRXLzI2VHhVbmhwT3ptSGI2S1NoRnhW?=
 =?utf-8?B?S05HbmM3Y2VsZlEyRkhuU0tmVDFoN0FRbUc5V1B6M3FiejhnZmFMREttb1lZ?=
 =?utf-8?B?bFRHMWErYWFhbE5TYVdkamV4SkkvbXk2cGg4NHV4UkdXclpPSWcwMVdPdW85?=
 =?utf-8?B?bHZGR0RTcERGcnVGdWpQeXMwRllTK285YWRLZXNWQUMzZTRoTThQeVhiQmV6?=
 =?utf-8?B?L2JIazkxMU41TDFNS01wVXVSclY1NDI4ZVA3eTJyS2YxOSs5bWpwTFp3UHp6?=
 =?utf-8?B?blZvbUN6ZElOa3pQTEplTWw2UTR2ZlNGYzdiSjJOMmdZTkF4ZDAwbmR0UTlX?=
 =?utf-8?B?eTZ5ellpLzZoMDdzbjBNNzdaRkdEZ3pKUGp3ek5aWmIvR0xWWEEyU3hvWWJu?=
 =?utf-8?B?aUsxTUoyWHU2ZjFBUVBHdW1uMzNWNmlqYUZrT1pTUlNnRnhzOXAwM1FraVox?=
 =?utf-8?B?bG1XWlBBZklyek9qWVlYRG16TUc1cE15ZUlxNTJqRXhRcGxUQ0YzZWJOV0ZV?=
 =?utf-8?B?eUJPbjBIbFRSZThqT0ZQTEZHRFc5YUVYVkVCemhiV3dGUnBOMENleUZObnQ0?=
 =?utf-8?B?L1FEbithaHpLSW9udlN1cUQzYXFwVExpRGdxRm42bFBzdGI4bW03cEt1dmZ5?=
 =?utf-8?B?WHQ3QUVYdnZSbzBJUGVBeWozVUJwNjZ5MmJYNTFrU20va2tyVXFaY2ZKZ2F4?=
 =?utf-8?B?WFhrQy9nc2dtdzdvWkNGNHphWG1nOGkvN0hieTJHQW5zcGtYbTNKaUhRWWhk?=
 =?utf-8?B?U2xEQWtsc3V1QmE2QUpGNWRSTlBTNHlJdWNVTUE4SUNKMlpON2xSaTRqUUZi?=
 =?utf-8?B?WVRxL1JNS2llWWJ6NHFQOCt4akFHc0JKTmlvNk8xMTVUUUNiVWI4VGgwMjd4?=
 =?utf-8?B?RENIRlM3MVI1YktwSVc0aTNiRXBkMVdDN3Ntck40NmtwbThnQUR5dlg0QVFw?=
 =?utf-8?B?VjhyZ01kVjk2b2Y3NHdUUndVc1o3amxZanhlak4yK1A0TStoUGtwRmNpZWpl?=
 =?utf-8?B?Ni9WM3VlWVNpMThxS0dJRmZKWWx5Nmh5UXFRa25LekdOcFp4NE5uQVlxUmYr?=
 =?utf-8?B?aW5oOWVqZEdGVDZydWlxVFJTMTdQdWt1bEZvUXFhcFBVcFNkUk0xYmxrNVYv?=
 =?utf-8?B?WmhXZ3lsMXZuamhzT2pWcUxSUVpUTDlNOFErdjI3Yy9aMktYOFlqMk5nVWpR?=
 =?utf-8?B?L3BhMjdnYXRqZnJ0aWNMUk1ZTWhjRFhjNWJCVVdsUzJKd29WNzZiUXE0eGNP?=
 =?utf-8?B?V3hJYVVHVFlUUnZkZjVLaFFsVm4zaWQ1QndnS1hVQnZyWWIrdXZ2RS85M3Aw?=
 =?utf-8?B?QnA3V3Ira1orVVg0OWpLbUJVbHFnamRFTmV4SFZBYTVab1Rpdmp5TU1IaHJZ?=
 =?utf-8?B?TU9haVY4dVFDRUUvRFlpWHZXYnk4WDltVFpyVy9iKzlETmV2REpJT296cmFm?=
 =?utf-8?B?Q2t1YTVsRzVxeFRMcExUWkY2RjZrUHJMVTRIbHdYajI4SHkrM2VKMXJ5Ty9J?=
 =?utf-8?B?VU5kUkQ3OFJQK1FmR2wvbEtuQXduQmI0eEdkaDgvalNGY0NtbHViaC9KaUtS?=
 =?utf-8?B?R2o2MlJWVlEydzE1N2xyZndCTHU0djBCWEF3NlRNNjNxMkFlam9raG5McnZa?=
 =?utf-8?B?bHVVS3BIRkp1MkZ3WTF1RVphZ0JpWFhzUHgxZ2xCOFdVZWd3OEVmU3B3aE1Z?=
 =?utf-8?B?VXBnNGE5bTdZZjk0eW1nZmcxbzNJTUdPMDhRSDBiY3RQNmt1V2hYamRuWVhs?=
 =?utf-8?B?OC80VFNvYUZyK0xSWXUyeittY1lKbW5rMnk0akZBeENMdzBtWkZRc2FGcUJJ?=
 =?utf-8?B?RVZWamZOdDZJTVBTQVRIcDd5WHJLVU9keklEOFhLQWlXSGZmMjRBQnlZMW96?=
 =?utf-8?B?QmZJdXJ5M0lvMkxNRzBwTGtkWmkrWHN4RVpua2ZNalNCU2Nzc0VzcDhWR0w1?=
 =?utf-8?B?SWJzMmkwM0JKY1dRM1h2RnNPMVVXbjFJaWtOcHA0MUE1b2hjVnVCWFBMMVJK?=
 =?utf-8?B?SnVYN2ZBMVFZWHNQMWl3RXRKTXRqOUZ6TDk3STRWZXc3U3Z0MHJva0V0eXNu?=
 =?utf-8?B?RVZNQU1HT3FjaTNHWGtidjBja3I3dEx4aGVSTk45QjFSUFllemh2bjFmdVBZ?=
 =?utf-8?Q?mljVeVf8Gdf5UQ9/Rvvhm6j6k?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 607a6902-1613-450b-e381-08daab8dd237
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 13:38:03.3056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o04SGZFCaGkzEo3IIDgKvAmYcndWsSRy+wsEuatYUzVBG8vBPwO4Vyd6ifQYWPWCYCSFeghcXTDg+EexwNbchA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8898

On 11.10.2022 15:33, Julien Grall wrote:
> Hi Jan,
> 
> On 11/10/2022 14:28, Jan Beulich wrote:
>> On 11.10.2022 15:01, Julien Grall wrote:
>>> Hi Jan,
>>>
>>> On 11/10/2022 12:59, Jan Beulich wrote:
>>>> On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> Rework Arm implementation to store grant table frame GFN
>>>>> in struct page_info directly instead of keeping it in
>>>>> standalone status/shared arrays. This patch is based on
>>>>> the assumption that a grant table page is a xenheap page.
>>>>>
>>>>> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
>>>>> to hold 52-bit/28-bit + extra bit value respectively. In order
>>>>> to not grow the size of struct page_info borrow the required
>>>>> amount of bits from type_info's count portion which current
>>>>> context won't suffer (currently only 1 bit is used on Arm).
>>>>
>>>> I'm afraid this isn't true: There's no requirement for a guest to pass
>>>> all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
>>>> tries to obtain a reference for every vCPU.
>>>
>>> AFAIU, this would be a reference of the **count_info** not **type_info**
>>> (which BTW will never be incremented on Arm because we have no type
>>> support).
>>
>> I should have said "obtain a writable type reference".
> 
> Thanks for the clarification.
> 
>>
>>> The commit message is only referring to the 'type_info's count'. So...
>>>
>>>> With my adding of GFN
>>>> (really gaddr) based registration of the runstate area (already
>>>> looking towards 4.18) the maximum possible count is to further grow.
>>>
>>> ... I am not sure which problem you are referring too.
>>
>> Wow - a mere stub (but not inline) function to make the build happy.
>> Then why is the description talking about one bit that's needed on
>> Arm?
> 
> Because share_xen_page_with_guest() will always set the type info's 
> count to 1.
> 
> TBH I don't exactly know why we set it. I always assumed this was a 
> requirement for the common code but never checked.

I don't think there is any such requirement. In fact there are only
very few uses of type_info in common code. By also setting
PGT_count_mask to zero you could actually have the compiler eliminate
some dead code ...

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 15:53:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 15:53:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420380.665196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHZF-0006Ug-DY; Tue, 11 Oct 2022 15:53:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420380.665196; Tue, 11 Oct 2022 15:53:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHZF-0006UZ-Aj; Tue, 11 Oct 2022 15:53:17 +0000
Received: by outflank-mailman (input) for mailman id 420380;
 Tue, 11 Oct 2022 15:53:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kS0C=2M=citrix.com=prvs=276448a35=jennifer.herbert@srs-se1.protection.inumbo.net>)
 id 1oiHZD-0006UT-Ox
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 15:53:15 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf41bed3-497c-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 17:53:14 +0200 (CEST)
Received: from mail-dm6nam04lp2040.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.40])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 11:53:11 -0400
Received: from DS7PR03MB5414.namprd03.prod.outlook.com (2603:10b6:5:2c2::6) by
 PH0PR03MB6706.namprd03.prod.outlook.com (2603:10b6:510:111::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Tue, 11 Oct
 2022 15:53:04 +0000
Received: from DS7PR03MB5414.namprd03.prod.outlook.com
 ([fe80::353b:c664:37bd:4409]) by DS7PR03MB5414.namprd03.prod.outlook.com
 ([fe80::353b:c664:37bd:4409%9]) with mapi id 15.20.5709.019; Tue, 11 Oct 2022
 15:53:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf41bed3-497c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665503594;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=+xvmkyZ/E8fK8igTCvvgWw/bIjuoZ3pgd41D/5FMsTU=;
  b=NvDbO7KoCurBaMTX2P+qeIBYLr6qesE93ICXm7PIjb//NleIzrzs59BX
   WwwN79TAY8ciW3V1Z3IAM+TvwCsGjUz2S+kGPxLRgvG4mFUREowRREqNJ
   fq6f3eLlOPQeP4/9NiE7+QF/SReVK/2vABN0e10tByBib2M3riAQclTwP
   k=;
X-IronPort-RemoteIP: 104.47.73.40
X-IronPort-MID: 82495932
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ADs7GJq0B5Creg1zWsPbDix16xRVVYHBdZcB5p?=
 =?us-ascii?q?9g8DSJ0pFHjZ4UTrseF4Mq/hLhYC2nMkxUFUfSHAGgGdRZowRtuGckO6qJSc?=
 =?us-ascii?q?LN2E/DahkmKa/tEXtFgN36lTP1e0cUndBy6k6n37BgtPZRFkYw9WPoSQQ9VQ?=
 =?us-ascii?q?e5fmjYEHWRoxm5KJfD/aTc5LDlEVC0tF6HoqRzXM78obcj9qXl75mW4d6kZW?=
 =?us-ascii?q?QBIUL/1u/AV2DnvigBrqcKX+fpzNtDMORXxkcMeSd9OPU+IGdJJ+SwSXJIzn?=
 =?us-ascii?q?+k8ySaA5QQiIUi2Sr+sQ2ypGEtNECiO7slTsg6KtZETuYWRm5+ep80CCI/uX?=
 =?us-ascii?q?R0Dzr/0D9/+eyv26ozhub9Qg8U9l/+83m/ryvnkOFk733o/UElBqbjscDiU/?=
 =?us-ascii?q?1NX5MirJAavxKmLNNopYYAzPLqdofyDHWhAGaB5ro3s8RfsPypN0dcHf/fTY?=
 =?us-ascii?q?IwEv07//IdA5fzI9VgES5Hgf3JtD0fWq/ixeeHeWf6NvZuS+QCbsqwqerP1Q?=
 =?us-ascii?q?JVDl0e911wtm6CT2H+9g/9yBbeabYCsbcD+eR81T6Nwg9e7TUG4Bmh7aitKy?=
 =?us-ascii?q?hZ1qGTIhxVnDg2qaULPXa/E1vDPTKb4E8MvZbSgLXxkiQJqDZXYWP31wyS/K?=
 =?us-ascii?q?hX09CAu6OE4PPkjIkHKDUPtXTFFrSV/64ClqZi7VNCMhXSRy5Q5U6awTxE8d?=
 =?us-ascii?q?hz7qe5ZDR4/LNicic+Yi4g2eRS2NgWos0YSnmBE0XhTs+RS9UgVkhyuBxcw+?=
 =?us-ascii?q?WOKD+ikzP7LGFEQZ9LshKxQao3uDqPoRNoYKELTUuRu/MEgWj+IGRE9+OaDo?=
 =?us-ascii?q?fMkLxbJFuyujkp2M0KhP91IVxfHrjz8ntp/n82yMVMRX8UeZX1Mvou/B/i/0?=
 =?us-ascii?q?HOnpMGavl/YmM8JmqIv536ANr4tSAPobBH44pZb4+pHGTXmhb7/+8g78a9Kw?=
 =?us-ascii?q?FFiiAwo13QWwaY4k8Nt9ViMGmT6Xk/HLfd8SAWnGvb/QKoSTy7EcS28wkqxn?=
 =?us-ascii?q?4TeNo85eL2BcdKeXKaYEXSISsBTiKHVvIARXj1F9Tgsi5Kz8k+Prz/08RCqo?=
 =?us-ascii?q?nPYfnzpyyitBeh75l/qo95VtRIWu2CHateokFf/mYK7EboNb02tv60V8hOtv?=
 =?us-ascii?q?wgMht29kOcG99jj1Lv4PSgaOf+6NQMgVuctIIWPvk6nA908HWnuJOZlhPtQI?=
 =?us-ascii?q?rJJl2RBgyv8pSIAYutmvxbPbBeZjKMcRZfJI9PkwJRMMTi7pzNPxF9sGAR3S?=
 =?us-ascii?q?vopEbxMzpBE7eOVanKs3U4MY2j74VNJCgR9kv10VEaQfjQAmVqDFUVjjPcZ/?=
 =?us-ascii?q?BGqkThOXSeNQ/K/BXAP5NzDHwEIrH0nRVtl9doWSVXRgCWNNMQ64J8nOvqDg?=
 =?us-ascii?q?3QiYApEx8QI2pOjkk2MxsaJ9x0oVIYgJUBbENArAXETolQXyD4Y8ekaVFNjE?=
 =?us-ascii?q?zICzPLGjJ+4bMHJ6v1lRtrnVi7uxb16AX1yu6zCFYs9hJh/72nlEy+To4TsM?=
 =?us-ascii?q?xKabAVaO0PJWFgKIV/+cOC10+smAYRJqm64qn+vM1n6SRCcncrGoHYKERVEg?=
 =?us-ascii?q?/rmFKzGoJuRM0wJYCNCrnS0+ljIGKLq11x3eckh64ylwDGUJDejd8QuDmauw?=
 =?us-ascii?q?GnuHHe0uXFGHNu9d/EFVls4D60rSa4u1E4Jx2zFu+ttwzKZtAnyaNw88lnka?=
 =?us-ascii?q?f0NumufXINvJhvOI5FV8m9edVpC221WCXMH04jU3rbNl6dp1Jy5bGdtrZL95?=
 =?us-ascii?q?9cVEKk+ZSv0VDUe8MQdYUyQcd1c+nwfyP4dI981XOjqpEBpn5Eqd/7I5Fr7n?=
 =?us-ascii?q?j9cYiB5P9EaQUCdWNcq6dokVQWS5OpLOF6qNSjDCEjsqNBb9U5ddRjqTLjOS?=
 =?us-ascii?q?s34OAVt+oq+E9WACvtISJk/MzkDjNhVG2rUGV29u+OCL4ArsmHLrJbaW1MLt?=
 =?us-ascii?q?wJL48vkBynyndJ2KOm6ZAkOBtQHU74wdLDf/IH7QRThcKuJ4i9DjuCTWmU/z?=
 =?us-ascii?q?06EPWJM0nNDSKYjFCpQ9Z1eUP8Zl8iRzyUtCf06Cpq2QdQj0fNh/PizbAh2r?=
 =?us-ascii?q?Qfdr1hjdfiQERGKKpfSDzifzQwJJUp9PEbNCZG5BcbMlUftC5Y7ACbJuAgi3?=
 =?us-ascii?q?u12f1lbbZlauerQlupR/0iPwEzPzyShIHEcv2S33EAPrRSXBx/0JANosM8G3?=
 =?us-ascii?q?oOMJTeUP1eoyWV7pwpojBhKCJo01O/KRt2L13ll0S3MGa68mL0EnK2aNYhEc?=
 =?us-ascii?q?/9NbXTQJUTMeMIwXRynR+tYrBJNHIaWSjSBwYS2itPAkvK6Z5iLjdTER+HMW?=
 =?us-ascii?q?ESQyHfcsae1pumxOEtnYhP3phYkqEbUUpX2cmx7+z9a88sZtLVwccHXO0tzx?=
 =?us-ascii?q?QoNqn6n8idRUPl46Ies0af1OI1JfR/bI9KGdGKkFy3h2jok/kf856i+8TU7o?=
 =?us-ascii?q?BHn9oUTUyfT5H0v0+87O1lUVQXp5YvJuJ864ox25bptGLXWV1dh4KhMuuGwe?=
 =?us-ascii?q?/pCRwlhNapu948KLzm8Ii/UZNyaWTK3dHBV0FyDZihufUsolYBzAF46744A+?=
 =?us-ascii?q?hUpeoqTsL13EPJ0qiqhRTYf0x/vC9CCi0JdiRZgkQ=3D=3D?=
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82495932"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TanR+fj6Lek1CCXQxQ60L6r7DKss43I5n946SYv5SkRaM3Kl8sHrxdbNf7DVeYzBXHQBJh4aFsHtJapIu8JKZHG9S/C4Msk9wTAmkqEcEFw/rYpa5JXkRWpnH6Vnfd/2UcvHgjaiYQS0xtTzG3vsTFTwbBrlWvfE51nydijGEFlzEx1TfL795qIBGQFan7uubkA/pMUo2EVzgrKNmoEGfYL3EVKJfO30u28EsCW86KnhYp5PPs8UqabpHYUtt4QHNosuM9N7dRoHs7YNbkLKzBF7FtqBx6SywPKfulQZIi+Ra4x23m5te8uDoluVsLRWIV3Wh4v6MzXAbz1+fwqW9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MZ7ExuzOTp8O8C3NGFcNskr/VK/eO07S0mvlNM3K458=;
 b=ZjhY/xYpRr+APmmet5jUviKIbtXRGWFOGGsnLKNw/AXW3k0KR9ztmXPwkK68gpyMJ1qC5E4FL3qnk3k0pLipcyZ+qk50W5cckR8hNqjcRbR4NCG9KXSrTODfDGS5jMn6t4MeLEKJ5fpFnEW2x2XdnIrDhOCMkzlSHGZali3zWvGS+ctH4Lr1BfvTfu8UfEvj44xKeXLOQk9sqqzIxCDTxIpr8fyqPwzadO/Lrr4VBkMnFsH9ut9xNs0hNG1nr+W6XswfBJLTbbBY1zX3fLDxPp/rVotdKGnYq+OYfGKjuff8vV1M8/1MwSfgzt+g8nbIQItSghQF3RoR0A8GRmpnkw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MZ7ExuzOTp8O8C3NGFcNskr/VK/eO07S0mvlNM3K458=;
 b=b5AHzniwyYXRV0H4IvLs9no1DRMM712+FPdHLsQqtwo65Jsgd0HmQlcJaWWm+71MTG9Fo+q68jPxvSuoxVYuunf0ey/WKSQqC/WwOb6ioEc1L3+0brSIfLRhM7J10rOR4aDjrzf8zg2ke7/JV6t2ZBUp1lyNyrYhZpERg4LHHd8=
From: Jennifer Herbert <jennifer.herbert@citrix.com>
To: Jennifer Herbert <jennifer.herbert@citrix.com>, "jbeulich@suse.com"
	<jbeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "wl@xen.org"
	<wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH 2/2] acpi: Add TPM2 interface definition.
Thread-Topic: [PATCH 2/2] acpi: Add TPM2 interface definition.
Thread-Index: AQHYyUN9uwGs56YGXEqEHrC97S9QC64JgBRQ
Date: Tue, 11 Oct 2022 15:53:03 +0000
Message-ID:
 <DS7PR03MB5414DE39CD2F506EDD49D822EF239@DS7PR03MB5414.namprd03.prod.outlook.com>
References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com>
 <20220915204029.1227112-1-jennifer.herbert@citrix.com>
 <20220915204029.1227112-2-jennifer.herbert@citrix.com>
In-Reply-To: <20220915204029.1227112-2-jennifer.herbert@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DS7PR03MB5414:EE_|PH0PR03MB6706:EE_
x-ms-office365-filtering-correlation-id: 991e4a33-f77f-4961-b8de-08daaba0aea5
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 P2Nd54sIt09l/s9TQqHcMSZOiDP6JFNcZkXBgtLLa8Do8L6JCrCHFYS5Bmukqkj7MSg6xyxQiPYbwysFRpTPAU+ECwH5FbZJ7kJE2kg1hQ0NsaVDoqO/OiiMKYrQ4YMjKMakQKZKnQwd9hqCMUMuTZMqNW6nFv9rEZEMLh6Ok0qAjiigdJJaLSVGSJo421KpkxFDLV7pEVg1+/dZXXU5P+9WXp2icR+f+AR2Em9dqLsBWeoVM+ZTOApd1t9gsLHKTD/WxLUqu4HKbtBctVsK97Fs9gxmTmWqXYXiX4b9sdSZyGvtuRIK0ERAAjHNALe1khsN3MMqiD2fBfGBX8uL9f0IAqlNU+4WZLcnGhTgU7+gE1nkap2aaO6hscHUYnAVriLLdNVIexKEWTseI9BWiBCF7sd0h4nDHZpS56crraYnlG+td2JyCyYE8ntLEEF3J/Bc3PSqyjyb+avRqLdcaKLlJa+yGtC7YNItVkxNhgEhrzEeyntMM4sbZOwrbgI/a+k3iGNw4ep96GtbiW3+CXzPR7+bVucmtcylDz9FjlquB1+CeClRfvEcKsNHp8mV58FGiu+CwMpu7oigfPel35bVtlbBxgRD6i0ETFH4J5IgZKiCVIZdR8e+eXofVXwYBjzpyGt+godncusGQLuZVMMI+GpHMauNzGBDvwYOjPNEjQrsysMEaLEo3jQzENUi01gnXreJkFhdOgUQpKU4RykHUccXjWO047G5T/YtXd0Q1LvPTai/VmcYdHGShjFKZH4jiF9K9Xs0G8Atc4r0gmH3uWrzn7yk9/AO4uRgRTw=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5414.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(451199015)(9686003)(7696005)(33656002)(71200400001)(82960400001)(86362001)(38100700002)(83380400001)(122000001)(38070700005)(26005)(4326008)(55016003)(66446008)(44832011)(8936002)(186003)(2906002)(41300700001)(52536014)(53546011)(76116006)(66476007)(6506007)(64756008)(66946007)(478600001)(110136005)(8676002)(316002)(6636002)(5660300002)(66556008)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?PTmDXBQk6CpZ0mfMJVVZkGorhGpGjFkumUs+HIzy2vdKVFMQhKnyEqGBp/Ld?=
 =?us-ascii?Q?+lQhIn8XZK/v6Phmasg2KZ2zN+ojcgkAdJazPGy0bpDgitAn4VCvfJxP4Y0T?=
 =?us-ascii?Q?RaGamQI2LJFxPAx4GwVg34JlBz7cONHqftyALZt1xsM5TtIn9T0rAT0URV+8?=
 =?us-ascii?Q?4h/loEgEf11228UWueOQgEXC3sqyFIf+F++7QXl07vcSQXjujDCzzvj5fuFZ?=
 =?us-ascii?Q?SJ60EhptVZw4Ljo4xq9hgGKOMpYA4C7bQzXWi17mvpIlgRQ+Rs8ajHPonV6C?=
 =?us-ascii?Q?DfvG9cUSoBhNPuhKMPNr8yH3QD+MhkmS86lZ22aQWw/SnWzK4ZeMkPrXFHVK?=
 =?us-ascii?Q?3kO1M/shz05rvPs5DqDcMN68dqJD1fi7ZTZgtsAzJqSBcF4LY3tSiuxgWbHN?=
 =?us-ascii?Q?KnYE5VL+5LvSFLe/lpElmSxQzOMBWPoZrvIOBVojdRLjLSVIQiT556Gahg4q?=
 =?us-ascii?Q?5IIeUuyrbGbUcBz6Mqfn4hKI3TtnmIGL3RAjUuN5RTOfHBvOY6058tysWh+k?=
 =?us-ascii?Q?LsBwh/zThFtiUYQYBM8JIwOV4gtqiFfRJsEh6o/dSTzGXIIxSfVijAF6/mUd?=
 =?us-ascii?Q?LQ2P0pQsoZ/8V5uVACf+vu9oQAusuGgvAesK19/fPnsYon1pEWfBDY4cpF8L?=
 =?us-ascii?Q?dXsZu4Ao1OTdKrXWZmbOt3lk8TH1e6RPz6p1ZWweWlZvuJztQlqheAHuV+G7?=
 =?us-ascii?Q?C8SUl75Pl5KPduvJnFnPNpfL/UtMNFcJxjgXicgQg75lfGRYfYpGvgzQm59x?=
 =?us-ascii?Q?+aPNcwag6eEywXAK0PoejvenA9EVAdqGZruFSA910B3zKBDGkQzgXpgZ9zbi?=
 =?us-ascii?Q?YRIs2XMyrY//Y2+zZFofRK0B6UnvjFp2UphQjbkd77Qk6pYetjLJ05fmJNqv?=
 =?us-ascii?Q?0QyrCl58lF2WmSy64ZIgzRVqrhiS56bzy8SpnzeegijfO0ZqIAHo3N4ZbzR3?=
 =?us-ascii?Q?HWWvQQACldpUziSj1McTZpbO9i2A4Oq9n0hHoephU/Po5iUJ6onhSlozAz2A?=
 =?us-ascii?Q?k719hKC2PG1vzRrXLDKC4gzw2rlqnZleCOt+TRu9JUJR8JVtAQ89738oq++b?=
 =?us-ascii?Q?izAcHc41NSw9zCVOWMIs2Q1MGqWNXTPBkrXMd64wrWbDl4GwyF7aywiU/GBS?=
 =?us-ascii?Q?/jlRcWBJXIWg98VGBaQaHeUj0AvplUSbvlrF2MS4hwOIKH7+Y7CF8PaLvgod?=
 =?us-ascii?Q?oaPHfcRcahX77QU7PAWi5/Ndk5qyS/UVk5ovC0tCW2kwgj+VAP2EYC/zuRu5?=
 =?us-ascii?Q?x0lYHLrIb/MeNWUGXSvUlyr26o2Ghv4/BuguWuw+jBIBEuBO9qAX/jgk0OCb?=
 =?us-ascii?Q?5JlrQeD2pfy4Z/Z/KKd5GNsDsYdlblXh5ZHzI9zxhjl1DVztUwzxnVpiocLP?=
 =?us-ascii?Q?di+an1MLNil9XglOnO1peE71YZ1h/iW15Yg3voQStpq6MqYOp7tK76OeKVV8?=
 =?us-ascii?Q?s8sPdpuOTSstHlMUFqSZzz91conD+SEOvfr6ZBnD6jIyoI3BLtib4btjiLhp?=
 =?us-ascii?Q?qs9fivU/yinBsLvKaYVE7Hj8a1JsnjbfuLH8XzZEkNrc7qfVXOuBUqrS6ZQ9?=
 =?us-ascii?Q?tF3f5N3XNV+76hE/lJVoC3kfO3NxsjvC12B7jUwrPOgFYvCz3w3jIhCpVtmO?=
 =?us-ascii?Q?Hw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5414.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 991e4a33-f77f-4961-b8de-08daaba0aea5
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 15:53:03.9403
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gnDj9kSSHDVVPLUCISM2/drFvlKhsMspRLUW31wLDSwtkC674JGpYM7QHRqpN41ffXT8hl56heHOAgxyHx1miBL4ZU8fLexLuRx0JoFtYCM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6706

Hi,
Are any further changes needed to upstream this patch series?

Cheers,
-jenny


-----Original Message-----
From: Jennifer Herbert <jennifer.herbert@citrix.com>=20
Sent: 15 September 2022 21:40
To: jbeulich@suse.com; Andrew Cooper <Andrew.Cooper3@citrix.com>; wl@xen.or=
g; Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org; Jennifer Herbert <jennifer.herbert@citr=
ix.com>
Subject: [PATCH 2/2] acpi: Add TPM2 interface definition.

This patch introduces an optional TPM 2 interface definition to the ACPI ta=
ble, which is to be used as part of a vTPM 2 implementation.

Signed-off-by: Jennifer Herbert <jennifer.herbert@citrix.com>
---
 tools/firmware/hvmloader/config.h |  1 +
 tools/firmware/hvmloader/util.c   |  7 ++++++
 tools/libacpi/Makefile            |  2 +-
 tools/libacpi/acpi2_0.h           | 26 ++++++++++++++++++++++
 tools/libacpi/build.c             | 35 ++++++++++++++++++++++++++++++
 tools/libacpi/libacpi.h           |  1 +
 tools/libacpi/ssdt_tpm2.asl       | 36 +++++++++++++++++++++++++++++++
 7 files changed, 107 insertions(+), 1 deletion(-)  create mode 100644 tool=
s/libacpi/ssdt_tpm2.asl

diff --git a/tools/firmware/hvmloader/config.h b/tools/firmware/hvmloader/c=
onfig.h
index c82adf6dc5..4dec7195f0 100644
--- a/tools/firmware/hvmloader/config.h
+++ b/tools/firmware/hvmloader/config.h
@@ -56,6 +56,7 @@ extern uint8_t ioapic_version;
 #define PCI_ISA_IRQ_MASK    0x0c20U /* ISA IRQs 5,10,11 are PCI connected =
*/
=20
 #define ACPI_TIS_HDR_ADDRESS 0xFED40F00UL
+#define ACPI_CRB_HDR_ADDRESS 0xFED40034UL
=20
 extern uint32_t pci_mem_start;
 extern const uint32_t pci_mem_end;
diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/uti=
l.c index 87bc2d677f..6e5d3609b9 100644
--- a/tools/firmware/hvmloader/util.c
+++ b/tools/firmware/hvmloader/util.c
@@ -1009,6 +1009,13 @@ void hvmloader_acpi_build_tables(struct acpi_config =
*config,
         config->table_flags |=3D ACPI_HAS_TPM;
         config->tis_hdr =3D (uint16_t *)ACPI_TIS_HDR_ADDRESS;
         break;
+    case 2:
+        config->table_flags |=3D ACPI_HAS_TPM;
+        config->crb_hdr =3D (uint16_t *)ACPI_CRB_HDR_ADDRESS;
+
+        mem_hole_populate_ram(TPM_LOG_AREA_ADDRESS >> PAGE_SHIFT, TPM_LOG_=
SIZE >> PAGE_SHIFT);
+        memset((void *)(TPM_LOG_AREA_ADDRESS), 0, TPM_LOG_SIZE);
+        break;
     }
=20
     config->numa.nr_vmemranges =3D nr_vmemranges; diff --git a/tools/libac=
pi/Makefile b/tools/libacpi/Makefile index 60860eaa00..125f29fb54 100644
--- a/tools/libacpi/Makefile
+++ b/tools/libacpi/Makefile
@@ -25,7 +25,7 @@ C_SRC-$(CONFIG_X86) =3D dsdt_anycpu.c dsdt_15cpu.c dsdt_a=
nycpu_qemu_xen.c dsdt_pvh
 C_SRC-$(CONFIG_ARM_64) =3D dsdt_anycpu_arm.c  DSDT_FILES ?=3D $(C_SRC-y)  =
C_SRC =3D $(addprefix $(ACPI_BUILD_DIR)/, $(DSDT_FILES)) -H_SRC =3D $(addpr=
efix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h ssdt_lapt=
op_slate.h)
+H_SRC =3D $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h=20
+ssdt_tpm.h ssdt_tpm2.h ssdt_laptop_slate.h)
=20
 MKDSDT_CFLAGS-$(CONFIG_ARM_64) =3D -DCONFIG_ARM_64
 MKDSDT_CFLAGS-$(CONFIG_X86) =3D -DCONFIG_X86 diff --git a/tools/libacpi/ac=
pi2_0.h b/tools/libacpi/acpi2_0.h index 2619ba32db..f4eb4d715b 100644
--- a/tools/libacpi/acpi2_0.h
+++ b/tools/libacpi/acpi2_0.h
@@ -121,6 +121,30 @@ struct acpi_20_tcpa {  };  #define ACPI_2_0_TCPA_LAML_=
SIZE (64*1024)
=20
+/*
+ * TPM2
+ */
+struct acpi_20_tpm2 {
+    struct acpi_header header;
+    uint16_t platform_class;
+    uint16_t reserved;
+    uint64_t control_area_address;
+    uint32_t start_method;
+    uint8_t start_method_params[12];
+    uint32_t log_area_minimum_length;
+    uint64_t log_area_start_address;
+};
+#define TPM2_ACPI_CLASS_CLIENT      0
+#define TPM2_START_METHOD_CRB       7
+
+#define TPM_CRB_ADDR_BASE           0xFED40000
+#define TPM_CRB_ADDR_CTRL           (TPM_CRB_ADDR_BASE + 0x40)
+
+#define TPM_LOG_AREA_ADDRESS        0xFED50000
+
+#define TPM_LOG_AREA_MINIMUM_SIZE   (64 << 10)
+#define TPM_LOG_SIZE                (64 << 10)
+
 /*
  * Fixed ACPI Description Table Structure (FADT) in ACPI 1.0.
  */
@@ -431,6 +455,7 @@ struct acpi_20_slit {  #define ACPI_2_0_RSDT_SIGNATURE =
ASCII32('R','S','D','T')  #define ACPI_2_0_XSDT_SIGNATURE ASCII32('X','S','=
D','T')  #define ACPI_2_0_TCPA_SIGNATURE ASCII32('T','C','P','A')
+#define ACPI_2_0_TPM2_SIGNATURE ASCII32('T','P','M','2')
 #define ACPI_2_0_HPET_SIGNATURE ASCII32('H','P','E','T')  #define ACPI_2_0=
_WAET_SIGNATURE ASCII32('W','A','E','T')  #define ACPI_2_0_SRAT_SIGNATURE A=
SCII32('S','R','A','T') @@ -444,6 +469,7 @@ struct acpi_20_slit {  #define =
ACPI_2_0_RSDT_REVISION 0x01  #define ACPI_2_0_XSDT_REVISION 0x01  #define A=
CPI_2_0_TCPA_REVISION 0x02
+#define ACPI_2_0_TPM2_REVISION 0x04
 #define ACPI_2_0_HPET_REVISION 0x01
 #define ACPI_2_0_WAET_REVISION 0x01
 #define ACPI_1_0_FADT_REVISION 0x01
diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index d313ccd8cf=
..d4f25a68d2 100644
--- a/tools/libacpi/build.c
+++ b/tools/libacpi/build.c
@@ -19,6 +19,7 @@
 #include "ssdt_s3.h"
 #include "ssdt_s4.h"
 #include "ssdt_tpm.h"
+#include "ssdt_tpm2.h"
 #include "ssdt_pm.h"
 #include "ssdt_laptop_slate.h"
 #include <xen/hvm/hvm_info_table.h>
@@ -352,6 +353,7 @@ static int construct_secondary_tables(struct acpi_ctxt =
*ctxt,
     struct acpi_20_tcpa *tcpa;
     unsigned char *ssdt;
     void *lasa;
+    struct acpi_20_tpm2 *tpm2;
=20
     /* MADT. */
     if ( (config->hvminfo->nr_vcpus > 1) || config->hvminfo->apic_mode ) @=
@ -449,6 +451,39 @@ static int construct_secondary_tables(struct acpi_ctxt =
*ctxt,
                              tcpa->header.length);
             }
             break;
+
+        case 2:
+            if (!config->crb_hdr ||
+                config->crb_hdr[0] =3D=3D 0 || config->crb_hdr[0] =3D=3D 0=
xffff)
+                break;
+
+            ssdt =3D ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_tpm2), 16);
+            if (!ssdt) return -1;
+            memcpy(ssdt, ssdt_tpm2, sizeof(ssdt_tpm2));
+            table_ptrs[nr_tables++] =3D ctxt->mem_ops.v2p(ctxt, ssdt);
+
+            tpm2 =3D ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_20_tpm2)=
, 16);
+            if (!tpm2) return -1;
+            memset(tpm2, 0, sizeof(*tpm2));
+            table_ptrs[nr_tables++] =3D ctxt->mem_ops.v2p(ctxt, tpm2);
+
+            tpm2->header.signature =3D ACPI_2_0_TPM2_SIGNATURE;
+            tpm2->header.length    =3D sizeof(*tpm2);
+            tpm2->header.revision  =3D ACPI_2_0_TPM2_REVISION;
+            fixed_strcpy(tpm2->header.oem_id, ACPI_OEM_ID);
+            fixed_strcpy(tpm2->header.oem_table_id, ACPI_OEM_TABLE_ID);
+            tpm2->header.oem_revision =3D ACPI_OEM_REVISION;
+            tpm2->header.creator_id   =3D ACPI_CREATOR_ID;
+            tpm2->header.creator_revision =3D ACPI_CREATOR_REVISION;
+            tpm2->platform_class =3D TPM2_ACPI_CLASS_CLIENT;
+            tpm2->control_area_address =3D TPM_CRB_ADDR_CTRL;
+            tpm2->start_method =3D TPM2_START_METHOD_CRB;
+            tpm2->log_area_minimum_length =3D TPM_LOG_AREA_MINIMUM_SIZE;
+            tpm2->log_area_start_address =3D TPM_LOG_AREA_ADDRESS;
+
+            set_checksum(tpm2,
+                         offsetof(struct acpi_header, checksum),
+                         tpm2->header.length);
         }
     }
=20
diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h index 914361=
6130..b5d08ff09b 100644
--- a/tools/libacpi/libacpi.h
+++ b/tools/libacpi/libacpi.h
@@ -80,6 +80,7 @@ struct acpi_config {
=20
     uint8_t tpm_version;
     const uint16_t *tis_hdr;
+    const uint16_t *crb_hdr;
     /*
      * Address where acpi_info should be placed.
      * This must match the OperationRegion(BIOS, SystemMemory, ....) diff =
--git a/tools/libacpi/ssdt_tpm2.asl b/tools/libacpi/ssdt_tpm2.asl new file =
mode 100644 index 0000000000..1801c338df
--- /dev/null
+++ b/tools/libacpi/ssdt_tpm2.asl
@@ -0,0 +1,36 @@
+/*
+ * ssdt_tpm2.asl
+ *
+ * Copyright (c) 2018-2022, Citrix Systems, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as=20
+published
+ * by the Free Software Foundation; version 2.1 only. with the special
+ * exception on linking described in file LICENSE.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ */
+
+/* SSDT for TPM CRB Interface for Xen with Qemu device model. */
+
+DefinitionBlock ("SSDT_TPM2.aml", "SSDT", 2, "Xen", "HVM", 0) {
+    Device (TPM)
+    {
+        Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */)  // _HID: Ha=
rdware ID
+        Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Setting=
s
+        {
+            Memory32Fixed (ReadWrite,
+                0xFED40000,         // Address Base
+                0x00001000,         // Address Length
+                )
+        })
+        Method (_STA, 0, NotSerialized)  // _STA: Status
+        {
+            Return (0x0F)
+        }
+    }
+}
--
2.31.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:04:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420395.665207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHk1-0000P6-GS; Tue, 11 Oct 2022 16:04:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420395.665207; Tue, 11 Oct 2022 16:04:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHk1-0000Oz-DF; Tue, 11 Oct 2022 16:04:25 +0000
Received: by outflank-mailman (input) for mailman id 420395;
 Tue, 11 Oct 2022 16:04:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qHIK=2M=citrix.com=prvs=2762267ab=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiHjz-0000OR-Tv
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:04:24 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d4151bb-497e-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 18:04:22 +0200 (CEST)
Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 12:04:03 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA2PR03MB5769.namprd03.prod.outlook.com (2603:10b6:806:11b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct
 2022 16:04:01 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 16:04:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d4151bb-497e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665504262;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=0ChCvhy3uY66meh6etxBW7TqKIZejV9GMCbCnAQ35io=;
  b=OcpYav/c6d+X8DdRLjbMoD4cjUP80pJsiNGQQm5yvZ8EkSk9iHN7q+o7
   BO9s12+eoVj6rhPLWTUoowKJZJhYCu46yt/Y0yPDpJgtZjcp2sBH/RYwe
   zAc72qRRlseH9hLbUysnlqN+SFuk29RhgPx5fc5HNpbyyD/uM9ov6Xm9j
   w=;
X-IronPort-RemoteIP: 104.47.66.47
X-IronPort-MID: 82474300
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:eR+x7qrVdlOvqYZZ9Np1c5uGDD9eBmLEZBIvgKrLsJaIsI4StFCzt
 garIBmBaKqPajTxLtl1b9m28xgF75LXn9diSQo+pC1nFisX+ZuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgS5QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7
 MY4D2gxbRa6i6GxwuiSaMxjuOAcBZy+VG8fkikIITDxK98DGMqGZpqQoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Nkkotj9ABM/KMEjCObd9SkUuC4
 HrP4kzyAw0ANczZwj2Amp6prr+VwXynA9pKfFG+3vlnhU28m0MYMwIbf0Ch/KKogHOYXOsKf
 iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZhZdo8pYkJTDol/
 laTmpXiAjkHmL+fRG+Z97yUhSivIiVTJmgHDQcbSSMV7t+lp5s85jrNU9JiHaidntDzXzbqz
 FiitzMijr8eicoK0aST/l3dhT+o4J/TQWYICh7/W2uk6kZ8e9Sjbonxs1zDt64cc8CeU0WLu
 2UCl46G9ucSAJqRlSuLBuIQALWu4PXDOzrZ6bJyI6QcG/2W0ybLVehtDPtWfi+F7u5slefVX
 XLu
IronPort-HdrOrdr: A9a23:5152Nq5pvUj5sZmCJwPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5
 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ
 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S
 zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN
 zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a
 hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd
 gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A==
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82474300"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eqB1WussvAi6ULayzvbRO8KGcJcT1LX4QiSrYw/yQFn9U0R11JYQ7mnejfu4iWnHuQfBFwnrml+ZPvVhKNnvIN5IMTvrbA08omIiCgH0phHVulsKDRL61OshagTWXtB+7LAAVXKzhf3S1tGSUIjOCQnTm+s5K85BkxND6UdJC8eEzFRFoDMwRDUf4u/7grSX0Lspm0SeidgRmnHkyj26rKUwPoX3gkxy5mk/jjPn36p1yJQQG/jtatl122WZ3MMD3N+oBqdWFf/H0i9mjTEhKfnawC/0sc551pqZ5BpAwfZrWbRQLu41KXGlR0GUrGKU8J2g2LySrbx2BLHx6gzy2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5IqmkX7BY352iyEmyV2PPJJVDTi/prr1MFNe89Y2774=;
 b=fyu/6EunJlRqX2jr8Ns4PPt58AtsjPiAsb98g1BURbyUXPqsD6XsPnsg7STUz3T2VKKrx/P5MJZq78Do5B3DYFF5uRmz1xJuSB4bnRk9/l/vUrfkJmqtNQJNAHACroVQFmrhyXX886ycEkE33AsQ0bm5a/sxEKzraZYWW9EcTwMevCjUEMrzgQEOmYu0wTaIXq6gLabgm9LTH4R/SGiH+jPhJYU9FQlOCqWV1cd1Sv4t/ZCHhz92felD4SAay/zZhuhzNa0JOCZyEEFJysbcA2QHqOjRCVYEuToz6j9Z8s/dU0QC1QYmgmgQoF90O0Dx/mMabtM6z5jry5NB9j5y5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5IqmkX7BY352iyEmyV2PPJJVDTi/prr1MFNe89Y2774=;
 b=qz3VsKhWq5GxZTX54QxFsZ2ASKBS+83g+FPn2zNIEwFPhlC4Yasv4I1l67xV/ckU8Ns7XQu9MN6y+uihfdAe9jqEiR09+bZAA9qT+vHWQQYuhAcXhecvyydkeuPghp8AL9i9ngo50KbNIG4t2/1EHa9FI0GSdvqqEH+WvmkDeY8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH for-4.17 0/4] amd/virt_ssbd: refactoring and cleanup
Date: Tue, 11 Oct 2022 18:02:41 +0200
Message-Id: <20221011160245.56735-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0451.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::6) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5769:EE_
X-MS-Office365-Filtering-Correlation-Id: 2239c5bd-faf1-4090-9a50-08daaba23672
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5R20XhabZ0uMD3OrKtXjpcLnOhCDeC9/3kTvoqGSoVHaXE/k0wzRFxIO4mvfnyWHSSG4MSKe1xG/BXDZjFKdwyKilUpJSP70S/pJQlnqewZoSGA2fw9l5mEAn3uq1Hlp3Va5WdOCm/rhXJd8o11mWtjlPqhMHkWdCEiaDnYn2Pyy9LZz485i/y7XQH51RzhOPPDBtTr17NjbE88b8qPDY3Y3uO374PTpI223aWglMVAGDX015q0TFzRLagMMgWgWLJss/U1BAA/azmnzhVjhGsfgEBTpB3u7XOIrcXWZAj9HgaGsHIQxKBySVwl6R7cg0S+8TA1G89mt06g5pQZCYuyKnBcIwzcTq2aJCj2mTtZ6p3HlniyRbeqaDix/cRzDqWmK14yrhN3OA2W6ktD9UBWg9bweq6AZ3UuSr7XzODQj3rTk+svAifGa8kFzBykxhxEVkYBbwOMZpOBNqu30BUbWBCGV5J5BNFgLuJAfN9+FD1JPQQUJ5LiKo/970sp2ckkyp6CD2wNoUsAgAdbEH/QtE50SWalxYHmnHIvP5VDUG3mohWAEdEKKs9wsDVXNvD3VS30n14A7odVAUjxsknNFVtQ/I4RUtOeenTnSZnBwy6dN1nBaHx53tnPae0HnO0QLlUPE1QAF01wgq2hIV2XvqRleA149s/al9HqASoJbj+hIfX/RwhvEF8Eh8FLfrIcN6VoabbewDDpR9A68FQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(36756003)(86362001)(83380400001)(5660300002)(38100700002)(82960400001)(2616005)(186003)(1076003)(6512007)(6506007)(6486002)(6666004)(26005)(478600001)(54906003)(6916009)(8676002)(66946007)(66556008)(66476007)(316002)(8936002)(41300700001)(2906002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dU1iVTFpZkU1bElURGpwVkVaMnk1UnlWSVlRcDRyS2dYT3loZWxLZ1hjL3Ur?=
 =?utf-8?B?ZHNaek9wZ0dKTHp6NTFTRWF4YXd6bWZ5RFNub3IwMmJCZm56Rk8vc0wzTTdD?=
 =?utf-8?B?V050eURvT3BuWFAvZzlPdTVoTC9TdENpRXlJRWZuY2ZTb3cvRmtNUFVCSXBv?=
 =?utf-8?B?NXEybkxWQmVOK0dadWREUXdRYzhtaVRmUVRqcG1aWHo3VkU2S0N6YzNWV2xC?=
 =?utf-8?B?QzhNa0NOdVhBQzBzbWdYcHBWNm9qcWp1ZUI0ZFNvTnk4c2s4d2R2NUdEQ2pv?=
 =?utf-8?B?U0EzekY3aHhFN2IvaXdCL3Y1NU4vcTBXQVFROGJwNG0xaUp5T2NMdlpFa2p2?=
 =?utf-8?B?Y2RoVXUwaXcwLy9kYUVEcXU4SkJNdUlRYVhTZWJBdC9SNzBhSk1CN0NLWmF2?=
 =?utf-8?B?Lzd3YVp3S0tLMVd3bFB6eHg5OEdqVWZaRzZjV2UxQm05dlA2YjFCVVBvdjJi?=
 =?utf-8?B?ZXg1Skw3eDcvUS90YldMVDRIbDdCbUl5bng4L1VPTU54SG8vcElMS09mRlpM?=
 =?utf-8?B?ZldRUGZlN1MwT2VENHVtNkdXVEJiN3ZEVzU4R3c5SC9ENHp1dFFkd0tmY2tI?=
 =?utf-8?B?WXplenIyRHlKTWs4cGEyemtZcjRKdjZVanlsdWxJYUV0Vks3bVgwMU9Ud3Nk?=
 =?utf-8?B?NkxMUzByYjFFVFJuQU56SFdvZ1EweHE5ZTN6SVBvMGd0SVZpRzYyOGNERFl3?=
 =?utf-8?B?cGNvandNWENYRElFd0hoT0F2Q3BtZ1dIT0VUNnhrdkMzUHV1VDcvNnVOVFhM?=
 =?utf-8?B?S0tzYkswbXlsZUdROU5PVkV5KzR1Rmo5d0pSRTM2MUcxcC8rWSt2WWpBUE80?=
 =?utf-8?B?ekpUamxueUFvcEJxWVloRmVuQmlYVkx0eEo1QjlZU3o3SkVQaVM2TEpWelln?=
 =?utf-8?B?MVpLOWV1cDZ1d2NCb3dQT2Q3dnE0N21CcWtYdVJsTFNGeVVhaUFvdHo0RzVz?=
 =?utf-8?B?RWdOOEZhaE9jdm5QUExqd0hVRzFvOUtDcWtIcFpqaGZBMDJ4VXl1UlRwOUtH?=
 =?utf-8?B?WXR6OTJVNEVCQzFqTFR0TDNxR2N6V01CYlBVd3A1K1BQMkZ3WkMzdm5DYWVJ?=
 =?utf-8?B?QS80MzB1a2xjNlRSZjV5M0IzUnV3citZNjJTTHZZbVZpbUMzUUJJOVMyOEhh?=
 =?utf-8?B?NkEydmdLUG5uOTNLQVJ5K2tWVURKNmNTcG8vcm5wR1pQc2l3N29WWUIvVHho?=
 =?utf-8?B?d1YwN3Z6Sy9TaThiWUdhWjNQTVFYOUYzU0pUaEZKU3NpdjRaSHFUeVFNNnRO?=
 =?utf-8?B?Mmt2b0tUd3lWcnE2Mnl6N29EUERUN04xS3hsK0JGbmlValQwbFhWWVloS3c2?=
 =?utf-8?B?b3k0MU05eUc1Umc5OEkxQU9iUTlMK3NVRU5lT1p6R3Uvdzd6OWZZOS9CS3Fi?=
 =?utf-8?B?Vml6K1JLLy95S09kOEg1a0dZWWhvSy92NTJhMHVXOC9tc2hjL1lZbkJ1TE83?=
 =?utf-8?B?NDZOSWdPdjZSYnFNZ2VrTi9XN3A5bnk2ZDQrYUd2bGJhc2UvcEp4TDU2SW1O?=
 =?utf-8?B?aHppRFVvRklIK2N6c1lwM3loS1NHbCsrelJRM243aVNNQm9va1ljZ3pyQlRK?=
 =?utf-8?B?SFFsVmlabWxNVWg4NGc2ditHdzZYMDcrc1BSa1FWWUl3ZFJqZU9FaW5aUTBK?=
 =?utf-8?B?RWVRa01jc29KRUduaFpxT0xtNTJmbDkrTE5TYTZ5SCtZSlg2MFUydDlTd1BF?=
 =?utf-8?B?Q21OdjdhZmtFZUoyRFhVb0NGWUk1SzZUN3hmQXZYT1ZBWUZaZjJQNUxnU0t3?=
 =?utf-8?B?UnVLQUx1d0V4RDlySWZXOHU3OTlLK2IxSUR4S2FCM2k0bEpsNmV2RkVEejlO?=
 =?utf-8?B?OTloQ3pGci9wU2xvK2hISXA1em56Q2FEK2FYY3pRS1ZKcENwUlZzZ2k5VENq?=
 =?utf-8?B?RFVMR3NNWjFPSDhpQ1BiU1V2dllCUFY0cmJpSGgrOEFMYlhYYk5WR2xEbXg3?=
 =?utf-8?B?S0FYVkwzT29TSkU4enAvNnBvM2NJQkRPZGlzaWpMdE01YkJraUVPM3pjdVpJ?=
 =?utf-8?B?aEpZc2JDQm4rNU9zd0QrUlhDeXkyb0lUckwvRXlDVTUrSFlpd25jU1VLY0NP?=
 =?utf-8?B?N3ZSODc2WVdXSUh4NSs4VEFhQnY2aGM5bDRJNW0xSTNqN2g5cU5pblVmcExz?=
 =?utf-8?Q?rg0fXIYaHS6Ezr4etWjmUGw13?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2239c5bd-faf1-4090-9a50-08daaba23672
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 16:04:01.6159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y1/COsV7+ifn0LIggrvueLTLiXxcHTxzo4nLkWCyK+uCZXqyYixxe6ZeStsjJHQp6UKfv4dv7U/VwYTIyGIo/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5769

Hello,

The following series aims to remove running C code with GIF=0 on the AMD
vm{entry,exit} paths.  As a result, the context switching of SSBD is
done when context switching vCPUs, and hence Xen code is run with the
guest selection of SSBD.

First patch is the one strictly needed, but patches 2 and 3 are also
desirable as cleanups and fixes to the documentation.

Patch 4 is untested, as there's no hardware with SSB_NO.

I tested on Naples and Milan CPUs (and migrating from Naples to Milan
correctly carrying the VIRT_SSBD bit), but I haven't tested on a
platform that exposes VIRT_SSBD itself.  I think the path is
sufficiently similar to the legacy one.

Currently running a gitlab CI loop in order to check everything is OK.

Roger Pau Monne (4):
  amd/virt_ssbd: set SSBD at vCPU context switch
  amd: remove VIRT_SC_MSR_HVM synthetic feature
  amd/ssbd: remove hypervisor SSBD selection
  amd/virt_ssbd: add to max HVM policy when SSB_NO is available

 docs/misc/xen-command-line.pandoc      |  8 +---
 xen/arch/x86/cpu/amd.c                 | 54 +++++++++++++-------------
 xen/arch/x86/cpuid.c                   | 16 +++++---
 xen/arch/x86/hvm/svm/entry.S           |  6 +--
 xen/arch/x86/hvm/svm/svm.c             | 45 ++++++++-------------
 xen/arch/x86/include/asm/amd.h         |  3 +-
 xen/arch/x86/include/asm/cpufeatures.h |  2 +-
 xen/arch/x86/include/asm/spec_ctrl.h   |  1 -
 xen/arch/x86/msr.c                     |  7 ++++
 xen/arch/x86/spec_ctrl.c               | 27 +++----------
 10 files changed, 73 insertions(+), 96 deletions(-)

-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:04:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420397.665224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHk3-0000lv-Ad; Tue, 11 Oct 2022 16:04:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420397.665224; Tue, 11 Oct 2022 16:04:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHk3-0000im-4F; Tue, 11 Oct 2022 16:04:27 +0000
Received: by outflank-mailman (input) for mailman id 420397;
 Tue, 11 Oct 2022 16:04:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qHIK=2M=citrix.com=prvs=2762267ab=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiHk2-0000XF-9u
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:04:26 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5ec56c10-497e-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 18:04:24 +0200 (CEST)
Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 12:04:15 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA2PR03MB5769.namprd03.prod.outlook.com (2603:10b6:806:11b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct
 2022 16:04:12 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 16:04:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ec56c10-497e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665504265;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=dGqvoHEhrk9uigp6ebhzbUXR8uqFN8JqnXryVWBtyfM=;
  b=Wax/K7jYJN5nNBRUV9/L5dcduegXgmtHAVw3CJ1daoIIpnIlgK+BxLcA
   ZhttLtRblFZ+fXnOAk6RzhNwm2M4I+tuLbi6TqGrvET/3E1d8SGj7ZOGa
   qDBpvxUdNYF+gtYDh2ThyY7aV7haJvsKe+z6h/fpeE7pqR5P7ctG6t1iZ
   o=;
X-IronPort-RemoteIP: 104.47.66.40
X-IronPort-MID: 82497052
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3A7MPMSKvJ6HapvVm7EUP75dsNn+fnOphVZkK7n?=
 =?us-ascii?q?cifNrXfiXmJ3RbKv53rLJtujFZ2djzeF6albpmDQlW6GbJGpuSZ81+gdvYUU?=
 =?us-ascii?q?cCbsp2Rci4ADJQz5KxWHqycTEAhj6Qu1YD2XPEqi4EHTiggwQoAnDHA8389W?=
 =?us-ascii?q?shYBmgwtZR8SZnqDVkaKxyZFD8SDormiG1OYSxZFBVuFjkN0Z2UKGdtCmepj?=
 =?us-ascii?q?5MgmeKyPrCPpadJJ5zy6XpBDB6FTXykKqRrEfssoWexd/PkyzlqnTB6yY8ac?=
 =?us-ascii?q?MjuxjAXDU8H0e9vbbpapJLTM6dUYX5kZlV5ajwNuqaiOycm+75YBLBWs2p0H?=
 =?us-ascii?q?8GOHYyGKcTXRaQv7qm1LQZTqFT7zl2cDR1DxcD6wqVK80G8RUxOVm8L04K9/?=
 =?us-ascii?q?pwD82HdBdz9eet21AjQ7cGsflkSsTNMEM1ojNvRRy8fegFTn7GsZazsOFxWY?=
 =?us-ascii?q?vMZ2PqiPgL4692dxOt7Ewgl20yo7KYVEPL7SCt9tdqUHCYmlWd0aiIfgCUl1?=
 =?us-ascii?q?U0a5ihjSihSWYj3JGTUWAulhccE/Z7a1A5M92Tc8dw6sKLqMRXZgVRby2vyD?=
 =?us-ascii?q?W1ZqLZz7MZs+BPbi+BXNxJ485vKShaoqHpj4ZheC6tNQTBlmi9HNXlCpOjVZ?=
 =?us-ascii?q?gywU06UEiPgYN0ez5oHPKk4V9gLVgcxXsnIySf+gDj28T4RzBrU6TdvcrKiC?=
 =?us-ascii?q?jmHSacT30jwmPv9zuSTZ3NgN5X9WuSM56vo5dSKk+vLYvpRtcr2/7Rn85FcW?=
 =?us-ascii?q?Ed7xHvYCfcUPcwkmUjyXXVNb6Vh8fQ07OILSQe9kalcHmuLsXWVGTrCHywlS?=
 =?us-ascii?q?oVjjrt+DatQANJFJcmgd3O9waIwuCIpfKVcSbaEI+jor36eQ22LcJR0HFNJP?=
 =?us-ascii?q?qipvmukOcfChETgR5SF6FE7BU+XJVgeL2pT87Rro48YSIJGY4nHrq4z+Drx/?=
 =?us-ascii?q?ZzPN2FMmGfmO+1maG4evJsCGUgQBnWB+9fXzBEpeMeyiWSYPOvfnDzNZPD6w?=
 =?us-ascii?q?sUaqUv0R7Et+/aJCzhcEZS5M+l8y9HtYqMyVwWccV5wTwz6MsQC7h924xoqs?=
 =?us-ascii?q?nBafjiLyTiVzcl9Z19LmTgXajZcp3PXPiyMcoeSCJaafJZiYicXz64sJ8Tjk?=
 =?us-ascii?q?QddRgrPqYkZ8yyBM+iLtgCtDuSZgVKLWkC0s1FI35KWri0fM8Dv77XUz1wI2?=
 =?us-ascii?q?kFKRisFlz2ywhswL0LZrcmYUVLfj92w2wnch8V/vhn9B4CoUamOpDOWHvMy2?=
 =?us-ascii?q?Zj3s12VCmz2SEddw9RRALjU4aNQO4jgFlhgVrGvFwHJQPE0bDfdRqVIqxda3?=
 =?us-ascii?q?3Y0soOdadXq1xvUWp4GbEEkaDWfLqovfcdmq9lOIPvv5jEmhsJNrQ9ZutLd8?=
 =?us-ascii?q?p/h044rWebcOVODUPkSemQXzYrKv+apWcvautoulH0jCLlpFXA8SJtDd2Aff?=
 =?us-ascii?q?/DlmrVS6slLARFtDB32YExN05VtB5iOdfD1hUSKEZWUf+JO1dYgOqawWyujX?=
 =?us-ascii?q?6DftFN5Q4JFnaAcMqWBvEl4GVoZlkWGiDWCwLpfMH74RdpDeCCujwEyGVbAc?=
 =?us-ascii?q?MFgCckfgnC5iEQQ8QerUEmanAlK1k9WFrPZMxXJCE0ClfRCcDPAKfEwxAulb?=
 =?us-ascii?q?IbM4L/tLqMbiq1QvcNJNnj6usBgSHrZRbE1urGRGzg3+4NX+oO50huJZPIc+?=
 =?us-ascii?q?aYayW5yzgOkIm28yMvrHveG9txQ4GyYBQpz8TambhwDUj4CW8m7bPRfTU6rU?=
 =?us-ascii?q?KA9iJjcGkOOSAU2jri+MYWsZ3l2ellYFo5PD2b8lU9a4lGquvINz6p+IGXP5?=
 =?us-ascii?q?1CN/i1aTcHes6TuKshoM+RpCUkgnXrR2IPJzepNFQ1CaGMSeuqrq7hHfQJmI?=
 =?us-ascii?q?T2IlLiwnRiu+9jHp0p9G31zxSv+8h1Dfr/rCBFDCyR+6x/isVrhjEzeJTymk?=
 =?us-ascii?q?w5Ks7RbQG5w8s16pFAdDE9Zk1oe9Fr7nTXgaKDRJ8E9Ps3OYje1NdzuIdDyy?=
 =?us-ascii?q?O6bVg4msv+SAJCDPussrFRwoJ0w1vj5R2RwGl6U2U0wGLSWErCJUwhDu8j4z?=
 =?us-ascii?q?BrXS+GrTlKN16YmpEcW1cPcQYfVh+mrVZ6FwM3iR7qNC4CUw7EzChDlkjhDn?=
 =?us-ascii?q?zOx/oJQfxMThTUu0IQ6gXa0w3crT4s4JlELoLrBIc5hwQwLqO3v646ThsEF4?=
 =?us-ascii?q?G+vVi/yClW/ScbeBXuF9vGE4guyl9zlakjDsWN8rv7gPbtE3ftaLy5rbbqkH?=
 =?us-ascii?q?td3bikft6WzWVL6ER+oRxDE70FyiG+aVDVM5tmHw5oqoytNDdXWLj5cFud2h?=
 =?us-ascii?q?/3lvs1A8NF06xWaZucufSnisnff2/X54NLU2FbenI/IxFWfj6SZ1qGs8PRoe?=
 =?us-ascii?q?U0lUcVNqllGN+IzoK1ykIpXyGxRBoYuW0OQeqdHvI8L4I8NtopjhysdA9MKI?=
 =?us-ascii?q?2GueVLOMziumSlpuLe1reUuxANeluoZavfc5UTz5g+dcuwkp5DnDmUNYCBej?=
 =?us-ascii?q?hexp6MsonqgENaANm8=3D?=
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82497052"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iEhkBnZmCWeIVJ8G7xcK5s2JGWxzr3aJWqsbR1c8/xvDr36GSCBKUTXByF7Io4fI+/EbK2TMLR7RJ42swHK5oKK3BoKgjKjtaxa4jsCXxLb6ffVq6xzL1TCQI6Zh8WboHFZaHmxmkUJOlFySiCb+9UFkAUd0IKbAaQH8x2o3duvhMIgBFQCsyDQ6gm3hDWFGVSmZN17Kvq1Gji80RtHXKb7OXWWbsUw04On0ceV7OLTHd03xNKd2Iv6FytAZHzIpopd1TkeoxWyHGHnFhlwt7Q0uKetWGOprZyxPlT/BQBwoGEiMPOt8vVEklsFif9DxybnQoqKl5+OullBF73p6GA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mVBkPo8rhBfvYMAMsLwRzoqZwqTHfHHJ+OE47LmFpUc=;
 b=g9BlfC1711NwbNs1++vxCAFS3byz0XpvB4v9cen74Oxh+IdHxn8PwmSipJmbOqrEoWNPJI6Fbc063QDP5rX+XegGikyeBI8f74UCjjSrfs+qpP44mMlse/AEzrFMLDx1pQBaZ2JE+T3U+LXgsTrZB9heMoIWNwXEFUUfigKd1GneOE8RgWfjEa6PYX2fEgq/5R1DuaY3WIs9ywMgbKOPb3yvaFucIWbO2+ywA3bJEsLD5/z3OqW9cWtgoHjsJHQlvDUYjJbna7WBewQUuf+eXVtZFydnwDYqbe+EWagOnUDs4b4V6hS0HJ4EdxbtqCDSA2p6C7Oqje88H16z/uZHpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mVBkPo8rhBfvYMAMsLwRzoqZwqTHfHHJ+OE47LmFpUc=;
 b=hk9UcBSEKL8yEkVJJfQNbshBTJthac3eSI+xZ4sEq5dWxfygTCH8VjUDJBy0n0NsRc8yyfCy9SSAJJ5mgl1GTdXn8cM7IpW7gCsbBMOrjGVTAjOvt/ooaOA395EceB0coBVgKqMd5VICJKPeNEA682Yz58C5yOOHUZ7uumg6MnQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 2/4] amd: remove VIRT_SC_MSR_HVM synthetic feature
Date: Tue, 11 Oct 2022 18:02:43 +0200
Message-Id: <20221011160245.56735-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221011160245.56735-1-roger.pau@citrix.com>
References: <20221011160245.56735-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::23)
 To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5769:EE_
X-MS-Office365-Filtering-Correlation-Id: 30c9f1ad-f2c4-4a28-f277-08daaba23cd7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PKsXHCw05MYbPQwt28LOUmRWNkjg1JKNM03mC7FUYchg2FS/z6ZyJeWRmgTzSlw+A4Zpg91bHuDhRR3P17dQtmB9nONtxZj1KA2kXNN3RFdWD/YXtsCi0A2VxdKR/HM7ZU+Afwyg1FGVhY0y1+3KOx7xYh3H8UNwBb/8LQcn81S69kU3B0qE/Hi4ODfn4oSyvvDOdvUhjmK1f9JOhSh7wFnKRyHE6vTwjkZGbQoqetrejn7z9bIZO5mVPTKKbmFQVAo0HzJUhNwvDHZ03o+1NU+sBgDKCXu4tglqt1bhbwshK9n6QKOchwkrBI0h8smHzsivHGpjH99MK0XJM0BXMYl5VNhJrUDoaOaQeBpjAejSl6VQ5+afCqQEdh4t1jFky9xJb43jJl7vlbdb+PHW4a/1UnyDY7qiElnpQXPNW8rkhppkayEddvRe0MruDEQJrR6+L6DziDvdyIQrG/c2UxZwb7fjVgP50HUoKmFESpMwOoPK0sTwyMMnJvX6lz3wSEQhHOaw8cMhtZDpOBVR/S77gsXl7BdziVX+ZNaksaL8z2vb9xcnlEh4Xp+aEe9HcjdByYwo31YkhrNQM9QFp/3DMqOTj2LdrOp10cwAKg19ywxE9sM2E5jK4DXmrvQ2uDed+PywbIqcrDWwYmRdjQhIJ8xucJYvS0FN0vGC5YH/j8r4g8uwgfZlv5UwJjV3ovDqL1HcbyR8tT/A8Re9eQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(36756003)(86362001)(83380400001)(5660300002)(38100700002)(82960400001)(2616005)(186003)(1076003)(6512007)(6506007)(6486002)(6666004)(26005)(478600001)(54906003)(6916009)(8676002)(66946007)(66556008)(66476007)(316002)(8936002)(41300700001)(2906002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3J4aG02SDNCc09mMkpzNUlKandjREEya2NmTTB5TDU5SVBQOHpVRE9ydHRk?=
 =?utf-8?B?dFVLOEM1VG5uUWI2MStnZ0szUTNQTkI1bkhaVWJrZDFOVWVYMUM0M2RiUVd6?=
 =?utf-8?B?L3J2dDlsdzM4K1ZtVklMSVh4MUJraWgwS3hmNFBjeXg4YVlUcmx5MUd1eEgw?=
 =?utf-8?B?akxjYzZyVmxzVHVvWldoQldCU1dQRFBHMDdFc211aUhnYTF0UGVCb3BBNHdv?=
 =?utf-8?B?b3ZydGVMazh4KzJsN0lDdDlBelM0b0hJb1R3SUVodnV3ZHJJR0Fyd3BGa0JJ?=
 =?utf-8?B?bHhLVkRFdjk1MCt2aHhUSlh4ZGtRd1ZQWndmdGs4SzIyUVRrRkNwNGU0Ylpw?=
 =?utf-8?B?bzBGd0UrMlUyV055TDRISXI3cDZnOWJtWEplZmNEWXkwQlBPblpwalc0czYr?=
 =?utf-8?B?S1ppK0ZBaDZXR3Z3djNyUDBLSHZtNmpQc1Q4WURVSTdMOHNKdW5TT1VWcHB2?=
 =?utf-8?B?K214T1ZodjBxeEVIOUNjb0lJVllTWGNWRW1IbVRhTWo3RWtaKzREWUZvclc0?=
 =?utf-8?B?eVBJWkxMM0ZlVXNHNm52bERjajkzTS9IV3dpQWZaRTVIWHJUQzNMZks5dStR?=
 =?utf-8?B?b2lNV2lJcVk4QnIwSjA1RlRlVmkxdDZsK2pXelo4TlNoNUx6aWxVVEJwVVNG?=
 =?utf-8?B?UjFXVVA0NU04dnpZakMvSXFaNmtETkx4dFU1SzRNbnhnQmhOYjNETFpxOG5S?=
 =?utf-8?B?MEp4ZC9YamVKbmp0bXI1N2JRY1lYNnVUdm9VUnlzbVFQMDByT0V6ZXJjSHlj?=
 =?utf-8?B?TTNrQ0ZOaXJyN3VpRGhKVEp1MmRsZUkrMXl2a256cTZVNmdSdzh2NndiSVRK?=
 =?utf-8?B?SmFiYUlsZktWcGlKS0p3Z2NsYWFZWWJlWXJLV3NCTTVzZVgycmpNVmwxaEJw?=
 =?utf-8?B?dEhWT2dXNFVUekZRMlUwR2lrdEhjUWxQdmNJZkhJTjNmQXNDLzc4Ny9nNUFh?=
 =?utf-8?B?ajg2NlU2WnJ2THVLTGJqMzgyclBIMWt4VUQycUhXeUlCVjJYQ25LN0N1NVdP?=
 =?utf-8?B?RkUweGlPdXFtN2dQcFdOdXZ4ZGRhVnpGRXhJLzJHam43SXRkcEFRSVNjTTNm?=
 =?utf-8?B?MzlOTW5kallUY0tBSEgvdHlQTHpmMEtaNzRaWEM1SUFDWEZweUdZcjU5UFFW?=
 =?utf-8?B?eE1jMnlyK3lHa0R2eENDOEJ0YmcwcE1xS2RmQzk5MytmTGNOeFVFcDVqbnRp?=
 =?utf-8?B?MXA1YTh0dWsrb2ZCOEhyK0J0NndDRVBReW1KbURMK2lzcUJEc2I4MjVHM3Yw?=
 =?utf-8?B?Sm9BdEtXeTIxQkNVSGltdVVUMXNyenUxOEszUnFNQzYrRXRIS0NJajAxeWI1?=
 =?utf-8?B?RElaNjdIM0hMQVk5L25ucW9nTSs2dDRrVjEwR0VWQ1c2d3FRam16dFVlUDR2?=
 =?utf-8?B?ZkRkK0dZenhiSGVSOXR1RWxVbTNhcDZiY25Da2grSlNCOERnWDhyekpJMzVh?=
 =?utf-8?B?QXVxTnJXNklGVG12OVhuN0xQVXBEbU15ZjRQbzVmemdjZU5wTUFadlBQL0Vn?=
 =?utf-8?B?STVZMXJYakYxZW00bU14ZE9oTEJ0dHZDV2xONCtFOFpINkVxSGEydTBtcytS?=
 =?utf-8?B?YklLQUxsdjFnQ2RSUkdZUlVERmJUUGFoUy95NEtYVERHWk16eklFRUZlNFUw?=
 =?utf-8?B?Q3U0a1JUd0tSZGNxS3Y3OVJhbVNlWDc2ajNOTjJKUDM4aXM4R1lhMU9BcTNV?=
 =?utf-8?B?cWx2S1BMNWV1UkJmZE16c2hSK2Z5aUU3TkIwT3VvU2toT3c4YmlBU3ZFN2Nw?=
 =?utf-8?B?eUplK3R5SmxxVytDc3NTeHJrbFluckh1cUEvYTNDeGUrMGdQM3dKaWlDREhE?=
 =?utf-8?B?NlNXOEN5TlNTemp1eDRKWnlrMUozWG5rWnVkdkQxSkhvOHhYOWdzZHU0b3hQ?=
 =?utf-8?B?d2tDaUwwcDVhOUdjUEtIWTFQSWJ5eTgzMGo0TmM1cFFGeUwyV1NkKzRkR3dn?=
 =?utf-8?B?U1pnbEwxbUgwd2xEVDFLYUtMMUZ3eGpjTnprTjgwUGhPNDhkZ0tDSzVZZUgy?=
 =?utf-8?B?ZUEwTnRVaHNDTTUrTTA1NnBzeThRSzA3WGJYbWlCT0RIUmhTc3pwTUtlRit0?=
 =?utf-8?B?UnRhY1MrdFN6cUdvVy9OSjRtU1A1aWt3L2Y4WDVkSHFvdm9uMDZiM2dGRmxB?=
 =?utf-8?Q?EDBhZ8sbkCNPAVd9FNQHeDkCL?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30c9f1ad-f2c4-4a28-f277-08daaba23cd7
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 16:04:12.4283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IwrwBFVLrI0umlA1XE0Yp1wQjMyQwpUqNukNTQvZrRivjkCjha1o1ca56DjbWPX/vD04ps1SaSR4EWdaTTORAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5769

Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched
on vm{entry,exit} there's no need to use a synthetic feature bit for
it anymore.

Remove the bit and instead use a global variable.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/amd.c                 | 1 +
 xen/arch/x86/cpuid.c                   | 9 +++++----
 xen/arch/x86/include/asm/amd.h         | 1 +
 xen/arch/x86/include/asm/cpufeatures.h | 2 +-
 xen/arch/x86/spec_ctrl.c               | 8 ++++----
 5 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index a1582e1cc9..c28f2d5220 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -49,6 +49,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe);
 /* Signal whether the ACPI C1E quirk is required. */
 bool __read_mostly amd_acpi_c1e_quirk;
 bool __ro_after_init amd_legacy_ssbd;
+bool __ro_after_init amd_virt_spec_ctrl;
 
 static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo,
 				 unsigned int *hi)
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 822f9ace10..acc2f606ce 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -3,6 +3,7 @@
 #include <xen/param.h>
 #include <xen/sched.h>
 #include <xen/nospec.h>
+#include <asm/amd.h>
 #include <asm/cpuid.h>
 #include <asm/hvm/hvm.h>
 #include <asm/hvm/nestedhvm.h>
@@ -543,9 +544,9 @@ static void __init calculate_hvm_max_policy(void)
 
     /*
      * VIRT_SSBD is exposed in the default policy as a result of
-     * VIRT_SC_MSR_HVM being set, it also needs exposing in the max policy.
+     * amd_virt_spec_ctrl being set, it also needs exposing in the max policy.
      */
-    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+    if ( amd_virt_spec_ctrl )
         __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     /*
@@ -606,9 +607,9 @@ static void __init calculate_hvm_def_policy(void)
 
     /*
      * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus
-     * VIRT_SC_MSR_HVM is set.
+     * amd_virt_spec_ctrl is set.
      */
-    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+    if ( amd_virt_spec_ctrl )
         __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     sanitise_featureset(hvm_featureset);
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index 81ed71710f..5c100784dd 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -152,6 +152,7 @@ extern bool amd_acpi_c1e_quirk;
 void amd_check_disable_c1e(unsigned int port, u8 value);
 
 extern bool amd_legacy_ssbd;
+extern bool amd_virt_spec_ctrl;
 bool amd_setup_legacy_ssbd(void);
 void amd_set_ssbd(bool enable);
 
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index 3895de4faf..efd3a667ef 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -24,7 +24,7 @@ XEN_CPUFEATURE(APERFMPERF,        X86_SYNTH( 8)) /* APERFMPERF */
 XEN_CPUFEATURE(MFENCE_RDTSC,      X86_SYNTH( 9)) /* MFENCE synchronizes RDTSC */
 XEN_CPUFEATURE(XEN_SMEP,          X86_SYNTH(10)) /* SMEP gets used by Xen itself */
 XEN_CPUFEATURE(XEN_SMAP,          X86_SYNTH(11)) /* SMAP gets used by Xen itself */
-XEN_CPUFEATURE(VIRT_SC_MSR_HVM,   X86_SYNTH(12)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */
+/* Bit 12 unused. */
 XEN_CPUFEATURE(IND_THUNK_LFENCE,  X86_SYNTH(13)) /* Use IND_THUNK_LFENCE */
 XEN_CPUFEATURE(IND_THUNK_JMP,     X86_SYNTH(14)) /* Use IND_THUNK_JMP */
 XEN_CPUFEATURE(SC_NO_BRANCH_HARDEN, X86_SYNTH(15)) /* (Disable) Conditional branch hardening */
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 4e53056624..0b94af6b86 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -514,12 +514,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
             boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) ||
-            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ||
+            amd_virt_spec_ctrl ||
             opt_eager_fpu || opt_md_clear_hvm)       ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
-            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL"
-                                                       : "",
+            amd_virt_spec_ctrl)                      ? " MSR_VIRT_SPEC_CTRL"
+                                                     : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
            opt_md_clear_hvm                          ? " MD_CLEAR"      : "",
@@ -1247,7 +1247,7 @@ void __init init_speculation_mitigations(void)
     /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */
     if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd &&
          (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) )
-        setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM);
+        amd_virt_spec_ctrl = true;
 
     /* Figure out default_xen_spec_ctrl. */
     if ( has_spec_ctrl && ibrs )
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:04:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420396.665217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHk2-0000eg-Pm; Tue, 11 Oct 2022 16:04:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420396.665217; Tue, 11 Oct 2022 16:04:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHk2-0000eZ-Mo; Tue, 11 Oct 2022 16:04:26 +0000
Received: by outflank-mailman (input) for mailman id 420396;
 Tue, 11 Oct 2022 16:04:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qHIK=2M=citrix.com=prvs=2762267ab=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiHk1-0000OR-AA
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:04:25 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f97b421-497e-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 18:04:24 +0200 (CEST)
Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 12:04:19 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA2PR03MB5769.namprd03.prod.outlook.com (2603:10b6:806:11b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct
 2022 16:04:17 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 16:04:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f97b421-497e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665504263;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=YWW/0Xrlj8OlYzjx1jxvYy8p0hZwDkcqnamKCBlqojA=;
  b=DtHcXWp9qbJ4i8VWcpWbuhJ3CkpiVC6cEy0IND0Lks9C74wvKT46KOnI
   +eSehz1U9UNETdGktCPoZlXPbkDyQjD4KYJvKE6JmaRQrAn9aKV6bqURp
   24CVLavBQr3KpWlsBEAixoJA9yc6NdzzjaxlJFDVTYwu1XfvB56RyS+2Q
   8=;
X-IronPort-RemoteIP: 104.47.66.47
X-IronPort-MID: 82474351
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:7yxDPq8h2ZPxOQNCn9ltDrUDXH+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 WsZDz/UOfmCMzfzfdxya4S/8kkD7cDWztBqTABspSo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5wVmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uN0DDBwz
 N0aEx8uYDCDq8XqwuK5YMA506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/Rxvze7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVqC7z2rSSxEsXXqoWP7iWyuVjm2Gq21AwUwIzVgThhMaQ3xvWt9V3b
 hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xJmUCVC8HV9Ugu+c/Xzls3
 ViM9/vrDzFytLyeSVqG66yZ6zi1PEA9L3IGZCICZRsI5Z/kuo5bpgnUUt9pHaqxj9v0MTL92
 TaHqG45nbp7pdEP/7W2+xbAmT3Em3TSZgs85wGSW33/6Ap8PdShf9bwtQed6utcJoGESFXHp
 GIDh8WV8OEJC9eKiTCJR+IOWrqu4p5pLQHhvLKmJLF5nxzFxpJpVdw4DO1WTKuxDvs5RA==
IronPort-HdrOrdr: A9a23:4YDSz6GheuwS/O5OpLqFc5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79
 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+tOKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+zLzGomjMlFx9fy7Yr9m
 bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfgWK1RH5m5+BwlquCm71gn1P
 HKvhcbJsx2r0jce2mkyCGdrjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MG40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIZLH45JlO11GkbKp
 guMCmFj8wmMW9yLkqp9FWH+ebcEUjaRXy9Mws/Us/86UkloJk29Tpb+CUlpAZxyHsMceg72w
 36CNUYqFg3dL5xUUtcPpZ0fSLlMB27fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82474351"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TeDUgGnB8XTBbP69vb3BIC1dzbzDYtxHgoL4S1mN9UlGc/lEnzAtn4doGh6VC2Lnal4P2h6J2M6PAuRXAu1LP/R9TZzInqDMTN9GExJbKx2k/VXXR3R8UEUCY75kAecHXB2SQsYec90WOcdyYthHR+9oQVa0AHcfagFjMuxPi1n976Yj/aOmg/pbiUDZ2utZs8ZK1thj++tRrzqLfCVimzsEZaAxtXez2M4rTASGfTK4WkxMi7/yuPJ680dn+UySvEfeitUcYEeWn/iQ1mPyeFdm8hRlUEgU94LbTgV4fny5LFq+5zC2TwSl/0uEGxkcGqhvj6A+qEGSKSWgDdoRDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GhLgI3FpRIlKsmCjqXjQcTnIcwm7M2jzmcvE579jJOA=;
 b=EtFVO7BguQJ3On4g4QpF6cHrAO+tRZ9hsG75hL2sKggdOSy6w6LoBr6WrkL4Im0DcDdPDX3eVEbj06HoXXiz9YAx55ki/ej4Syc1DvebwwtO9twLYQOQ+AMARsPcGOo9Qvv8L6WmKd56iDiw+/AbnpyL17350w+uaxCznIZMObqcx1iF81qYGJCYAHq7V2ng734IayrQrH02aHB+sRNixUijbI0eMEPDx+6eIQ+tR0WwOl3kbqGW6B+OFN7ktZI3zFLbX4D8jkFKX/9O8Peh4tppYCpV/+9trGOfr4uqHdm8TlUc1EtEmKCFp/nRZzevNAKU4SxETlMlnt5Arjb84A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GhLgI3FpRIlKsmCjqXjQcTnIcwm7M2jzmcvE579jJOA=;
 b=vDhqzRF+ptG8yU2KHVU4JtLIat+gkDN1pnuD1w29iqT4ryh+oIIZ7XQxFQ8bGTZf7UL93QGhgeO3hpXFcSJdpny4lh2TllP+xueolY50EhyPWnk8NHgPHND0oTDBXU1ZtwbaDYzb1lCxO2wjnIlW0Lz4lsv1bkeHpAo7sSx1rQE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Date: Tue, 11 Oct 2022 18:02:44 +0200
Message-Id: <20221011160245.56735-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221011160245.56735-1-roger.pau@citrix.com>
References: <20221011160245.56735-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0261.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:37c::14) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5769:EE_
X-MS-Office365-Filtering-Correlation-Id: 00d5132a-58c0-4eff-dc80-08daaba23ffd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4aGoRbXIkMB6zPLVpCjkgMacndO6pA1BaopHEgxfGeTz2s0i4Ikkh+ott9OHrlMG1V7EQM+vYM8juHsSZSmeQjGq3zHfDgeCX2ZZVm8alg2dbLMRanJLQHhYO8fX3+s6PyKkxg3weuNzHC2gUp6TG46kc6uDZvshEv7VZl9+JqpF0rHJGL/QnJKjLclDTAAmhPM088o6qT7bVLjIerlJxYm880uTtCmSdU02tj9fxpdbJTJOm9C/Gd3n8g/OKt/vdDpRsap16WjvZk9tDpcAx/2A8oHJL1ifMlY7BwlkOUUdcHytbG7vFN/csX5vwBb1NU8rPJc5WnjSyFOL0CITElDJKByBqAdXm8Jl4zIgAQmSAtxZ7AKxKKs7FGOzQD4ZCdLOQObAzCGslJiYPjXQmzZigAkE8C9zL1uCk+ZrvIF6Jmcis/8yNFhs7EVgzk1mKiFBclf4HiTAi9WtFxpdZEpQAUsGPUNIYwtXQCURjhueT3QfxWwgfDJ4yPflPHt4k+9mCl5UtMM1HvxoH+1QpZFpLKq/sumaAqHH68plMKIB4SnOY3LmEF78q9LMzpQoxVmUFyiOeDg3j1vIh6tCAHnUHsx003FVhRxYMwPWEloKIAa4PDSswdrOZft1jgB4/oPmx7UkZUYFTa9NHrcUfRujVYFHcOeEj5nzwJvRib/SjpaUE+GGKHGG40X2wNqWc4VWZPeiGIwy8tvKKO4ZPg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(36756003)(86362001)(83380400001)(5660300002)(38100700002)(82960400001)(2616005)(186003)(1076003)(6512007)(6506007)(6486002)(6666004)(26005)(478600001)(54906003)(6916009)(8676002)(66946007)(66556008)(66476007)(316002)(8936002)(41300700001)(2906002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a3dWbytnYURDOUttQlhxK1d1TG1aNkZ4QlFhY1R6WnpxbnoyZkNBd252Qi84?=
 =?utf-8?B?MGZGTThObEVXMnVDa20veWgyV1lnNlF0aVRPNnpyS21HUU5qTW9xWktRNVli?=
 =?utf-8?B?YVJFZUQ4RzFxR2tBcTAyNHR5ZXB5OTJPTnJFVGI1VWRUWDB4ckhMbnN4eDNi?=
 =?utf-8?B?NkordjZhSmZXTVZaVEwwUEhOaWRFcTVuWjJSY0FsQXRYZmp4RGkyUHk2djJX?=
 =?utf-8?B?UXZKamlRL1RITVJWekNqS2wvd0Fkd01YeW5FZ2Q3eUxuVnRsaDd4Yi9sRVNO?=
 =?utf-8?B?WWJQK1E1czF0SnBEdWR4c3grMWZaTWh1RVRWZ2w3K1dmRXdTWlZ0MWhLdGVH?=
 =?utf-8?B?RUZvTnJCMFlLaDVHSzJuRDhxdndoOTV4dUdoVjFpQXlRVTR1RWovcEJCelRI?=
 =?utf-8?B?MzlrU1ZCZE92WXA1enBmcjROUHBuRUIxQnNXSUQzalRvblhjR0dnL2RXSmJ6?=
 =?utf-8?B?MTEzTzltREhjVHhuazMwdktSdmh1L3VpbEN6RHUxL3ppNW9Jb3pxdmd3SWtS?=
 =?utf-8?B?Ri80QUZuZGJKelorbXZ4VUU4ZWhWaGR5YlkyMnRMSjNFKzZ6RVVSWnVPYkpz?=
 =?utf-8?B?SmR2OXdFbGpPUk1hWjZMeENNdkxXcU9TTFZZK2Q1TTl0SUhLY0lON2RSdXNO?=
 =?utf-8?B?UmtHOXRPTjVXZjNaYmdsY0l4QlV3Uk14dGpmaDk3bVY4d0QvM20zamh4YUMr?=
 =?utf-8?B?dVBPWmUvYllaUlk2MHo0NEhCdTVJSUtOOG9ISHhSWDM5K3A1akpwTm1heTBT?=
 =?utf-8?B?K2NwTVJlTGZsY2ViQVRGVXFJQkgxSjlOSFRuSUNsRnFtOEpoNFhBZ2dQV3N5?=
 =?utf-8?B?cjNRSyt5VkZJRjdqclRxdUdRaHd6TG5tMnFOVERXd08xUXFYOGEwNXNpRGJl?=
 =?utf-8?B?SzlGMWVhckpJWXRMc3BPWExRN0dDcW1YQ0VwNEJhTnNJOEFQUXoxbWx4bmxK?=
 =?utf-8?B?WlNjQ0lvN3RQK21Qb1U2aTJJUWZlcWVpamh0c0h2THByQ2o1TlpwZ2c3WWh6?=
 =?utf-8?B?bEs3dEhwZHF6ZGNOUmd6cUI5QTNKaXVRWDNlQlRQL1gvck0vM2E3MEluRW5m?=
 =?utf-8?B?dnFKWWFHQkp1ME41ZkNmVko1b2FmSG10cWYyL2N6K3BGamxoektGd2lac0h4?=
 =?utf-8?B?Nnlzdm8raDI3M1UwNGpYb2xIMHZ0Nzljekp5QXdhQ0Vzd2hqMGJ6N3g0VzhV?=
 =?utf-8?B?bEx3cS91bi9tWVM4dXBLcXFMZUJ3Q1pVQm40bWl3NUlqeVZVUkVpRWlmUmNB?=
 =?utf-8?B?Ti9SYmgzS1N4RU1QK0JXYmljRGNYcVpnNmNleHJQcm1kNnZDVFAxYjQ3Q3JS?=
 =?utf-8?B?YUhTOVZ0Q0VlaXFHUnlQV3AybnZEOUhDMFBIcStROTZpVHI2c0wxT3k2MTRK?=
 =?utf-8?B?TjQ2S0NkVGRkS3R5TkRvc0FTQVdVamg5dUVIamFKVzU5cFRpdXRrS3N5SlQ1?=
 =?utf-8?B?VWtsYUl5cXJJN3pDbFhrRC9VaEkyWWZWTFlSbHpEK0h5eDlDaGpOT25DRkxK?=
 =?utf-8?B?a3Rvc0hOL2NqMDhkSjhZRG80VllkeVVUd203SHFLWE1pZHBBSGEyaG9FMVdB?=
 =?utf-8?B?clJxaDRXcjBhVGVmb29EM0NKMkJJWE5HbS96YXhSaXFxeVM2c291OFJyV05k?=
 =?utf-8?B?RDhIZFR1aUErN2RkM3BGWllIeVBLbkhrVDRPRlM5SUlWUXhvZUhxY01VRW5G?=
 =?utf-8?B?WXlqREZLcjA2a2hNUHRmYXY5NW5MZ1djTFloMDhkN0RzbFkzQnlDT250ZUFw?=
 =?utf-8?B?OWpjVFdoRGJTRDlEemEwbU4zdUtod29jdWNLTnV6ZnU3QVhvNHZzcklXVjUx?=
 =?utf-8?B?azlweDdxRGpHYUp5U1BEbUh2dnZHWjR6dlBGS0hCemhUWGRZTVdoSzZJVUQ1?=
 =?utf-8?B?dUF2MWdnV1ptaDhDUlVuL0ltZmRGc3lUaFd6ZUpYL0VibEU0dXZqclBxYmxj?=
 =?utf-8?B?V2RNY29jQWZsY2JLS09xVWFlK3hWK01sM2VSSWpXbTkzK01GR2pDTHVoUHd1?=
 =?utf-8?B?WHZNRitJd085bTBnU25VWWZHVWNua0hDeVhuek1Fejh0NWNWT3U4eWRoRHJx?=
 =?utf-8?B?YjJIUWk3V1AycVVZRDNGRUdnT0JEVGNZWlRIK2xUaWxzZVV6eVp3V1dYeHdD?=
 =?utf-8?Q?571BS+vz7+ncQN8EIpHNIxbSy?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00d5132a-58c0-4eff-dc80-08daaba23ffd
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 16:04:17.6139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vUN3AgUwxdSS3W0vPZJeByMrSGUqtdg7JMAdV5iqcdhYMFE7sxveIANUqKswa8kkbkbdZ6Fn5q7dF7Nd4gc34g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5769

Like on Intel AMD guests are now capable of setting SSBD on their own,
either from SPEC_CTRL or from VIRT_SPEC_CTRL.  As a result the
unconditional setting of SSBD from Xen in order to cope with the bit
not being exposed to guests is no longer needed.

Remove the Xen command line `spec-ctrl=ssbd` option and related
settings.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 docs/misc/xen-command-line.pandoc    |  8 +-------
 xen/arch/x86/cpu/amd.c               | 11 ++++-------
 xen/arch/x86/include/asm/spec_ctrl.h |  1 -
 xen/arch/x86/spec_ctrl.c             | 19 +------------------
 4 files changed, 6 insertions(+), 33 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 68389843b2..f2666b881a 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2297,7 +2297,7 @@ By default SSBD will be mitigated at runtime (i.e `ssbd=runtime`).
 ### spec-ctrl (x86)
 > `= List of [ <bool>, xen=<bool>, {pv,hvm}=<bool>,
 >              {msr-sc,rsb,md-clear,ibpb-entry}=<bool>|{pv,hvm}=<bool>,
->              bti-thunk=retpoline|lfence|jmp, {ibrs,ibpb,ssbd,psfd,
+>              bti-thunk=retpoline|lfence|jmp, {ibrs,ibpb,psfd,
 >              eager-fpu,l1d-flush,branch-harden,srb-lock,
 >              unpriv-mmio}=<bool> ]`
 
@@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
 By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
 when hardware hints recommend using it as a blanket setting.
 
-On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
-option can be used to force or prevent Xen using the feature itself.  On AMD
-hardware, this is a global option applied at boot, and not virtualised for
-guest use.  On Intel hardware, the feature is virtualised for guests,
-independently of Xen's choice of setting.
-
 On hardware supporting PSFD (Predictive Store Forwarding Disable), the `psfd=`
 option can be used to force or prevent Xen using the feature itself.  By
 default, Xen will not use PSFD.  PSFD is implied by SSBD, and SSBD is off by
diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index c28f2d5220..cfeb8d1daf 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -730,11 +730,12 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 	}
 
 	if (cpu_has_virt_ssbd) {
-		wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0);
+		/* Handled by context switch logic. */
 		return;
 	}
 
-	if (!set_legacy_ssbd(c, opt_ssbd)) {
+	/* Test whether legacy SSBD is available. */
+	if (!set_legacy_ssbd(c, 0)) {
 		printk_once(XENLOG_ERR "No SSBD controls available\n");
 		if (amd_legacy_ssbd)
 			panic("CPU feature mismatch: no legacy SSBD\n");
@@ -777,12 +778,8 @@ bool __init amd_setup_legacy_ssbd(void)
 	if (!ssbd_ls_cfg)
 		return false;
 
-	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) {
-		/* Set initial state, applies to any (hotplug) CPU. */
-		ssbd_ls_cfg[i].count = opt_ssbd ? boot_cpu_data.x86_num_siblings
-		                                : 0;
+	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
 		spin_lock_init(&ssbd_ls_cfg[i].lock);
-	}
 
 	return true;
 }
diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h
index 9403b81dc7..ee5c7b8d54 100644
--- a/xen/arch/x86/include/asm/spec_ctrl.h
+++ b/xen/arch/x86/include/asm/spec_ctrl.h
@@ -66,7 +66,6 @@ void init_speculation_mitigations(void);
 void spec_ctrl_init_domain(struct domain *d);
 
 extern int8_t opt_ibpb_ctxt_switch;
-extern bool opt_ssbd;
 extern int8_t opt_eager_fpu;
 extern int8_t opt_l1d_flush;
 
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 0b94af6b86..dcee9795a5 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -56,7 +56,6 @@ static enum ind_thunk {
 
 static int8_t __initdata opt_ibrs = -1;
 int8_t __initdata opt_stibp = -1;
-bool __ro_after_init opt_ssbd;
 int8_t __initdata opt_psfd = -1;
 
 int8_t __ro_after_init opt_ibpb_ctxt_switch = -1;
@@ -126,7 +125,6 @@ static int __init cf_check parse_spec_ctrl(const char *s)
             opt_thunk = THUNK_JMP;
             opt_ibrs = 0;
             opt_ibpb_ctxt_switch = false;
-            opt_ssbd = false;
             opt_l1d_flush = 0;
             opt_branch_harden = false;
             opt_srb_lock = 0;
@@ -263,8 +261,6 @@ static int __init cf_check parse_spec_ctrl(const char *s)
             opt_ibrs = val;
         else if ( (val = parse_boolean("stibp", s, ss)) >= 0 )
             opt_stibp = val;
-        else if ( (val = parse_boolean("ssbd", s, ss)) >= 0 )
-            opt_ssbd = val;
         else if ( (val = parse_boolean("psfd", s, ss)) >= 0 )
             opt_psfd = val;
 
@@ -471,7 +467,7 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
                "\n");
 
     /* Settings for Xen's protection, irrespective of guests. */
-    printk("  Xen settings: BTI-Thunk %s, SPEC_CTRL: %s%s%s%s%s, Other:%s%s%s%s%s\n",
+    printk("  Xen settings: BTI-Thunk %s, SPEC_CTRL: %s%s%s%s, Other:%s%s%s%s%s\n",
            thunk == THUNK_NONE      ? "N/A" :
            thunk == THUNK_RETPOLINE ? "RETPOLINE" :
            thunk == THUNK_LFENCE    ? "LFENCE" :
@@ -482,9 +478,6 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (!boot_cpu_has(X86_FEATURE_STIBP) &&
             !boot_cpu_has(X86_FEATURE_AMD_STIBP))    ? "" :
            (default_xen_spec_ctrl & SPEC_CTRL_STIBP) ? " STIBP+" : " STIBP-",
-           (!boot_cpu_has(X86_FEATURE_SSBD) &&
-            !boot_cpu_has(X86_FEATURE_AMD_SSBD))     ? "" :
-           (default_xen_spec_ctrl & SPEC_CTRL_SSBD)  ? " SSBD+" : " SSBD-",
            (!boot_cpu_has(X86_FEATURE_PSFD) &&
             !boot_cpu_has(X86_FEATURE_INTEL_PSFD))   ? "" :
            (default_xen_spec_ctrl & SPEC_CTRL_PSFD)  ? " PSFD+" : " PSFD-",
@@ -1274,16 +1267,6 @@ void __init init_speculation_mitigations(void)
                        boot_cpu_has(X86_FEATURE_AMD_STIBP)) )
         default_xen_spec_ctrl |= SPEC_CTRL_STIBP;
 
-    if ( opt_ssbd && (boot_cpu_has(X86_FEATURE_SSBD) ||
-                      boot_cpu_has(X86_FEATURE_AMD_SSBD)) )
-    {
-        /* SSBD implies PSFD */
-        if ( opt_psfd == -1 )
-            opt_psfd = 1;
-
-        default_xen_spec_ctrl |= SPEC_CTRL_SSBD;
-    }
-
     /*
      * Don't use PSFD by default.  AMD designed the predictor to
      * auto-clear on privilege change.  PSFD is implied by SSBD, which is
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:04:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:04:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420401.665240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHkJ-0001Pu-IK; Tue, 11 Oct 2022 16:04:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420401.665240; Tue, 11 Oct 2022 16:04:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHkJ-0001Pn-EK; Tue, 11 Oct 2022 16:04:43 +0000
Received: by outflank-mailman (input) for mailman id 420401;
 Tue, 11 Oct 2022 16:04:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qHIK=2M=citrix.com=prvs=2762267ab=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiHkI-0000OR-JZ
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:04:42 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 680249ba-497e-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 18:04:39 +0200 (CEST)
Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 12:04:26 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6378.namprd03.prod.outlook.com (2603:10b6:303:11d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 11 Oct
 2022 16:04:23 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 16:04:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 680249ba-497e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665504279;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=meTjvBewTlHBs7LRXzpVInwurZ2rXlIRYOO2HPDbQdU=;
  b=cpSLawyXFBFYvGSd+2Owa0ryMJwIwHwAImGyP0Men5dENAIcmuyscsbT
   7fvqalKheWFldAV8VHhToguQcx/UcUKhQGi/5Q0luCiY9O76G9B4tMs60
   wLiG/1FqMbHi+WgaRVrBM7Qh6HqZ7YS5Rukk6/OO/xDXq20h/yOlMaU5J
   s=;
X-IronPort-RemoteIP: 104.47.55.169
X-IronPort-MID: 82116872
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:nuWw4a40B1cA5X/4Q3DuywxRtA/GchMFZxGqfqrLsTDasY5as4F+v
 mIcUWGCbK3YMWD2Kdkkb4y+9RgFu8TUxtVqSgdl+C9kHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gVnPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c57MT9h7
 cMWIgsyZwKhu86nmJiHb+5z05FLwMnDZOvzu1lG5BSAV7MMZ8CGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGNnWSd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL237aRzXyhMG4UPJ6Br/tKhFua/WoeDRQKaF27kPChpHfrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAkQzhbeZoZvck5bTUw0
 xmCmNaBLT5lvaCRSHmd3qyJtj70Mi8QRUcdYQcUQA1D5MPsyLzflTrKR9dnVaSz3tv8HGiqx
 yjQ9XZvwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd
 lBe8yRCxIji1a2wqRE=
IronPort-HdrOrdr: A9a23:aNVeeqDF1ZIEZg3lHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN
 hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dOwEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 529lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ5o+a87bWzHAb0cYa
 hT5Jm23ocXTbraVQGSgoBX+q3iYpxpdS32AXTruaSuokprdT5CvgklLfck7wc9HaIGOud5Dt
 v/Q9VVfcl1P6krhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc=
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82116872"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DIlRJ08G0I0wiTd+qD6Th+7eJGiBY6yDNDzALXLPbDWiSTAu37Lj8zUiNyYmv9qKzYov/yqSfgqN024/yKQ/GKTSeQEx76tss0/K72ceEz2uX/peXuRIBiuBz0GMbpu/8cxr/rxlsFq2BFOGE2/x5ITrFtZZMKBP+cG7ijEiJAQtl0ixZjYu6EMEdR2GKSPDqV1EHqsuJXsrJyGxT7RrK+WA59yXPVpdafzrX2toczlxTVU6JkT/xBVbXpv4Qf9GuukWV1YgZGgAThRB6Mwm71VaZtofS4HqEjH2lRsmssa8s051VSG1h1TwfGuhzYGgj8OTGQXSMBE/v/bjijU7xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EAuwn7S5ftuN5uITAlZ8x3DI+7/sASR3Tb63nr2Rm4w=;
 b=c3kuLMxMJEL19KqMsiVIhY38Tqr10qZUYhvjIwO1oGQk6cx+Ldo1aszyh/FjX7BxSKN9ILxGQzeHyj8yRmQDi2NTc0MAQ5IA/jW6B5WEFRbArYsx5j0nCWTZz6WefOi6UhjqXHc1BwvKZU5CBXqHUQhQR3y6bZzL0yoZ7sEDovocbvU92f4Vy3aOKtt3UJUqTgRV4HyQ48U5uEHCg9Vuwz7BWqp7vQc5iQk85w2JPSCkDsAnIymC7CUAJG+h7krZvO9SZaibCc+TZXvfFJu5wpE5I9bBY/Q5Ckzx0Cnm2/CVNjaZjpal7TeLvDWAN5zU258IIvyNGoNcS4E/9yRAfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EAuwn7S5ftuN5uITAlZ8x3DI+7/sASR3Tb63nr2Rm4w=;
 b=pYAu3gsdv206AH9vo3Lv5rwnFn75CGgB7XGzkd686JpfKfgbeZjwdEpYil/0t1NCX030kE32mz8P/lj+H8yN50Yokj/0qaMdBLMDVS7pO9F6BBbAX4DOxrQGT8P5WcUlvgQ8Rd8OiGWGg+xPObfS3/ZLfkz3rRPPpBvqEgrXZQo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH 4/4] amd/virt_ssbd: add to max HVM policy when SSB_NO is available
Date: Tue, 11 Oct 2022 18:02:45 +0200
Message-Id: <20221011160245.56735-5-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221011160245.56735-1-roger.pau@citrix.com>
References: <20221011160245.56735-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO6P265CA0004.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:339::20) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6378:EE_
X-MS-Office365-Filtering-Correlation-Id: 65229b3a-f6c5-4209-189b-08daaba24380
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+WZT989eOuc2Ww9o8kyCAsCm3zOEE+1tilKOU3yp2zQv1w/UPlvjX6NxnuXVecG30qIyOp3SG9K0Y5EL1B2fz6/6uCuNYWw8T3AkNEjA4C+zGGiIRQjq8V9X6XOPL+QLh0sfI/nMGaYLOdW5LqeAryQEaIZOqwBO7vAt0cWiToPo7Lx8FqiGlqKktRf2OFN3QBgfGxmJgFcrpTvz/jz2Muugqr+TlNU9IJJorfOpKC0+2ePFHhElLBhxt8oAYV/D3OG6ns48NahkR7ezNpibwbMpsD/deGHSwweGVVdb0X9gmZZhGAnwAZAJ7WR+jhxPoPEx1MTOqZ+tXgEVOx4Wg5E9gQ6x4oZiMO/53puU9d0Y7xiOWJSVhk2MpEw+NhjexXserPbvXeUmcYzrEp/yVOz4u12HCvlsTcvmFJnlFp4xYaw3LA0b/g98bcm1SdA7tdh+BHaKcI6quOwP7dhpmOoJ55tetnXIN5OZemHvdUyeQvVqPgBNZJv0bwpTY/7beyCt0NnvtSVXQZ+LYFvNcGN/zg207ItP2efIW1IULg9Bi0bnfR/WOkn/x7gm62uBkVBXQLoMg0w9kemKLnPAhjoT6NwFjS5PlzBckC4av+Aa6L/AqM9/HwWtS0PSh78JBLblQPuKq0mzqFMgJ8Tk6dy5ENxK5kdDobcFHLtsXTyvBg+Lr8GVm4AMCLIFGwfRANsGkFE2ADm640bGg39iKg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(8676002)(6506007)(41300700001)(6486002)(36756003)(38100700002)(2616005)(1076003)(8936002)(66476007)(186003)(86362001)(26005)(54906003)(478600001)(83380400001)(6916009)(2906002)(6666004)(4326008)(5660300002)(66946007)(82960400001)(6512007)(316002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZnQ3UXhFcGFSd09IY0FlQkp0eHhJSkFhbkJ3d2t5dmVDQlBXOVltcjVMOFlN?=
 =?utf-8?B?VnhuV3crMjdNbWYzNXczS210R0MrVjFxbVk2c0d3YVBSR0xpYWJsaVpFTExB?=
 =?utf-8?B?MmdxZzFNZ1d1QUV3Yk9QbDZXbVJhRXlqVkxkM1N2TzRkcExnV21mdTFFWnZR?=
 =?utf-8?B?MTMvb2lZb3EvTFZ6bjZRZ296YUxlNDlHSGlKRmR1eW1wOXpEdFpCZlZ2a1N2?=
 =?utf-8?B?WG02bm5XdnlpYUpiK2xhaTkxTm1QNVBQR2ZaVGUxVEQyR3VKWlNVRmloSkI0?=
 =?utf-8?B?akZnOHZULzRHTExJaHN2Ny9uRlh5enBoc2x2ZGxhbzhZbVlVVFNhVVVLc1Nm?=
 =?utf-8?B?d2NPUCtYUFJkRXp5NFhMQXNuaThOb0Qwcy9nSnk5M3dxdUM1cEV5RTVKcG8x?=
 =?utf-8?B?M2NmY0hZU2dIUTVhVXY4WmpmajZIcDhSV2J6QzIyczYrTldjY1N3TTRSWUg0?=
 =?utf-8?B?ZGsyRlhCYlZyc0JBbmJRQ093OW9iZlY3dkRVNjZjQjlWRHR6ZXFzUzhvWmsz?=
 =?utf-8?B?ZHl1c0wyOUhRMzZjSmJ6NndnL21wVDlPa3hlYlpRWlk2VWE4SHg4eGpNcmJu?=
 =?utf-8?B?Mkp4RXpjWkxPakNpdFg4VUJrUmxoN1Z2clZ0YjcwWkI1M084Q0ZQWUZLdDFW?=
 =?utf-8?B?SXZRUmlZTmZyYWpxSi9QT3ZrRVpRZVplTTRjZXNJWWd4TE9WQ0hEZVp6Rm9h?=
 =?utf-8?B?cklVUTlqTTVsbW5rQjJJRHdGTExoSFludXltaWx3K3lBNHJrdFZiQm9sVncw?=
 =?utf-8?B?b0xsRE5mQnZzU01hcWthN3ZNbm91RVdDYTdQNDQvK2J5MDk2bURmL1gzbTNU?=
 =?utf-8?B?WFo1MEZxOFhoeUV2b280aS8vcXEwYWlWbGs5bDZMbHhIRzdaa1p6L05nOUZI?=
 =?utf-8?B?V0NzdGxaRmpOdEtEUmVOTnI0R01sMXBNUy9xYmRIUlVOV3VuNzB2UjVzUXhs?=
 =?utf-8?B?UmhpSWtJNFM1QWN3SVRQQVo2RkMzeWtNa0FndzlXdTJIMm5TMVVwY0NvY1B6?=
 =?utf-8?B?VGtpeEplbHZoT1FiY3VxaCszZSsySEN3QmUrNzhvUWlCRmxDS1VybWRGbUpi?=
 =?utf-8?B?R2xQd2I2YXJaT0c1RWN6VnBUNDc3TDMzQzhrbFlXWnovejBSZGJTbVRYM213?=
 =?utf-8?B?dUNTZWdtNWxQdk9WNTRUeWtVQi9xUUw5b3RNNEZac1IwU0NiR1J5VlpUUFFK?=
 =?utf-8?B?TGUvZFdVcDVWakdyTmZMWEN5d0l0cDJuTmc0bG1IVUNSM1VPSHdlYng4dHpC?=
 =?utf-8?B?Rit1dVZFNDRLeUhaUGc0WjhMY3JzWmNlWnF6ZjQvOWhGaVBzVGNYZTVVb3V0?=
 =?utf-8?B?N01OR1A3SlJTamNkL1YydGdXWkhRZTZCQXZqR1JIVk4zbUhFNW5jKzhSRVpu?=
 =?utf-8?B?b3k0MnduVlVKWUZlYUM4ZHYzc3NnUC9qc1dWWkNocTVBT1dWWXNsOTJaaUMr?=
 =?utf-8?B?QVlEamI5STMzNHBhRWFZWVdDNFIwcURzNklYS2dobXVOV1NsaDJVVDQ0d2RL?=
 =?utf-8?B?U3l1U3BNZ0c5bGwzYXFpQzZPU3NiM05mRTQ5SE0yYUFqWHZYd0d1Y2ZmcThN?=
 =?utf-8?B?V1BERSsxd1dISHUyYVRVeFpsRmw1UkZHMFBFaldzTElqOWp1dXQ0WlExc3dl?=
 =?utf-8?B?QjlNYkVjZk5RakVFOGdYS1JybHczL2wxODdrV2xKOHZDZnBGa0ZialBDNkt0?=
 =?utf-8?B?eDRycUExdUxGemRndkhrUkRLZHF3L1ZKZmltTTcyblJzUWE3Mzh1NkdoTkRv?=
 =?utf-8?B?Sy90VHRnZWxUWU9KdDg5blVsTUVUSlNXSmE0cnZISU1GTHoyeGZta1VvUDFt?=
 =?utf-8?B?UGw2NUJDU1lpOUY3N0U2V3V2ZUtYRWh2WDRIL0hsN01RR0ZHSHFYRFRsRzVh?=
 =?utf-8?B?V3JGRTVHU0oxSERPTjFiNjVyQW9UOHF3OTlEbENPSytPMlU3YTlCaUYrWjF4?=
 =?utf-8?B?bkozdDJJSlBOTENMZk9vWDZmdTMzRGRic2h0SEJDWjRlWTlmYVcvTmxIU25G?=
 =?utf-8?B?bit3S09LckFIZXgxOTZWaEljZ3VnT2NqMkhOTEZ3VG5qVkpBbUpyVmtiaVdB?=
 =?utf-8?B?ZWxsYjFVdjBVYUpLRnFVRWJBd2xabXlvR3B0N0tIc2xScGdpZTFTY1BOOG1U?=
 =?utf-8?Q?t0mRQtwWmyuBxiJ/eHpLXPza0?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65229b3a-f6c5-4209-189b-08daaba24380
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 16:04:23.5615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dcIz4EBYZxpUIdCucKI0eQEwFO5xaX9S3+EesBqwDtC3Ouj0r5/glpTV1O3IsLzDUm/JpmIplSjGY6q/9Sl6fQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6378

Hardware that exposes SSB_NO can implement the setting of SSBD as a
no-op because it's not affected by SSB.

Take advantage of that and allow exposing VIRT_SPEC_CTRL.SSBD to guest
running on hadrware that has SSB_NO.  Only set VIRT_SSBD on the max
policy though, as the feature is only intended to be used for
migration compatibility.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
As there's no hardware with SSB_NO so far the patch is untested.  Post
it for reference if there's hardware with the bit set.
---
 xen/arch/x86/cpu/amd.c | 4 +++-
 xen/arch/x86/cpuid.c   | 7 ++++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index cfeb8d1daf..74cfeffc29 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -814,7 +814,9 @@ void amd_set_ssbd(bool enable)
 		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
 	else if ( amd_legacy_ssbd )
 		core_set_legacy_ssbd(enable);
-	else
+	else if ( cpu_has_ssb_no ) {
+		/* Nothing to do. */
+	} else
 		ASSERT_UNREACHABLE();
 }
 
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index acc2f606ce..e394dbe669 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -558,11 +558,16 @@ static void __init calculate_hvm_max_policy(void)
         __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
         __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
     }
-    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) )
+    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ||
+              boot_cpu_has(X86_FEATURE_SSB_NO) )
         /*
          * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed
          * and implemented using the former. Expose in the max policy only as
          * the preference is for guests to use SPEC_CTRL.SSBD if available.
+         *
+         * Allow VIRT_SSBD in the max policy if SSB_NO is exposed for migration
+         * compatibility reasons.  If SSB_NO is present setting
+         * VIRT_SPEC_CTRL.SSBD is a no-op.
          */
         __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:16:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:16:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420426.665251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHvB-00047A-N1; Tue, 11 Oct 2022 16:15:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420426.665251; Tue, 11 Oct 2022 16:15:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiHvB-000473-K2; Tue, 11 Oct 2022 16:15:57 +0000
Received: by outflank-mailman (input) for mailman id 420426;
 Tue, 11 Oct 2022 16:15:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qHIK=2M=citrix.com=prvs=2762267ab=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiHlL-0000OR-Uf
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:05:48 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f27c28c-497e-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 18:05:46 +0200 (CEST)
Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 12:04:08 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA2PR03MB5769.namprd03.prod.outlook.com (2603:10b6:806:11b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct
 2022 16:04:06 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 16:04:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f27c28c-497e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665504346;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=lgz/WGO6rZZcxY5NBE3oZRmF8PNamyCzYRjCRBsXCds=;
  b=OuAF7PuJwEKfiJsHtCwhHS6ivkdEtHIpW2z1t5ssQimhVsXIjcpz6SJV
   0uHGDep3uIG++r3i8tJLlfnID9vUsOGLSl2tQj0ih7xI4U8jzofX9aXyA
   k846lJy0sbATagHDPLIfEu6+7HUAobd4rrUYezOsnJHS28h0BEWmiopkS
   g=;
X-IronPort-RemoteIP: 104.47.66.48
X-IronPort-MID: 82907556
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ktAw06n/DiHhRdkyp22qL9Lo5gy3J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfWDjSPvePNmGkKI10PYXg8hsB65CBmtQxTlFsrHwxHyMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnPKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfUGoJ3
 qYGdWAxXjfcgMaM+Y6bTPhVv5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PnGSd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL217eQwH6lMG4UPJGDzaZuhG+D/Tw0Ex9RD1a38PK6hmfrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAkQzhbeZoZvck5bTUw0
 xmCmNaBLT5lvaCRSHmd3qyJtj70Mi8QRUcdYQcUQA1D5MPsyLzflTrKR9dnVauq1Nv8HGiqx
 yjQ9HRuwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd
 lBdypb2ADwmZX1VqBGwfQ==
IronPort-HdrOrdr: A9a23:0R1vB6iDzAKgUfEjIkw6gO1V83BQX0F13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hqAV7CZnichILMFu1fBOTZslnd8kHFltK1kJ
 0QCpSWa+eAcmSS8/yKhzVQeuxIqLfnzEnrv5an854Ed3AXV0gK1XYdNu/0KDwUeOEQbqBJaa
 Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN
 MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9
 gsAp4Y6o2mcfVmHJ6VfN1xJ/dfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q
 6xG29liQ==
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82907556"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jl+buQGtwI2MurLh9L+YAB4FgDdkKLpt7Idxva4/91C5iP/jzbTBPzmWjCmVX1W9sZxdmDLfRLKS6GsXBZHlCSpuyjcmJw5BxoceYaiQP0+3bNcS6qrulUQO/W8BwhNJAqLKwu2Hev+PP8PQfNReTCQACwDM78W1c0lHEXM9sB4JDhs6mz5t7AZJPFqR4/dkBH2s6EvxI/lg4mhhYqVFKqGEpVMWRRZE5SefI3UHymKXcCn/mQY2Doc3u0d7FymF0o2sOptRVDvMtjdgfBbxS7GCLhU4zNlAztYcYQvhcGKDNmb27M0BsgrMh12fETSznSW86rns2PmdZVdE13OUUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bWS8sZqxQqNjj3kC11vQty6DTyEgLxdM96zPK2XwtGA=;
 b=T0OmC4qLDyG4mfYwW9S+IZbVgQNvaJNnh7Mb8fc1ED48DfaaSm4N2rfEAqVS5fXExecHuhXb3ChUHHtH78na1btNwho4neaUByzwz/lhNUaCfZbwDP6G3/dr9a3gx9ayWrmFefmMiTh6eivLahHxJEilBQxOxnWI3reqGvkKKfNxhPlBWtTHsSedvZf/ItvzwBYAHAdYdKdqSZywYWHOCmJpKYIk8ac98fLk8D/g0Q6alNg03GdVrUCboHKnQ+T3PJCTYfJQGlybl//aBJkKECA9iO7N/cXurHfY20qi5mK8J4dnO/WJq9hlEdu+fFiXQcG1ySKljsdBiUdW4KH/vA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bWS8sZqxQqNjj3kC11vQty6DTyEgLxdM96zPK2XwtGA=;
 b=m3+FNu4hSIpFjgw8tmc9XFFRN48UCUxnRmE8co5QEIlexOUscVmEpntloVI7wBSfG6ao3QH5iCUqxFkPiGGPx/fDajCTcUY00wzv8HowmOaLrs78sECT9PF6vN/S/kL5aqJ04qlKcXym3azEUJZduKJo1XthzPWgvFLT+JOWjqY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 1/4] amd/virt_ssbd: set SSBD at vCPU context switch
Date: Tue, 11 Oct 2022 18:02:42 +0200
Message-Id: <20221011160245.56735-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221011160245.56735-1-roger.pau@citrix.com>
References: <20221011160245.56735-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO6P123CA0047.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:310::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5769:EE_
X-MS-Office365-Filtering-Correlation-Id: 690056f4-3f94-4648-57c9-08daaba2397b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jb56XMXcBPBAObEpiAJjySbz14te1MQdqpf0IbZihkLqBA5Jo98RIr+vnfLaw0PkG8LU/gV9V2ftKkjzANRyuipsbdALytQSqjTx4zW0Sg32qmvRspB2KjH/qEieiKCT/I7grPXsk4LB8YtFSLuiqG3GQcUHZyHtDNdWWWmkitZyOZ9w/ZMEwvBY2A8u7wCjZ3ZTM/tLBFmXHN9BDE/qwvJUblLkG4VuiVgkztxOmMS7epJ9boE/1hMsIBDUy7y4CpeB9tP9vdCn9gstFY8sLRxsGzR25j1BzioyiIjEWs2hY6BEKJsoOkork6sDzQT47ObgqCqPw/Gje+3dYi+qiaz0xhXvtNmucDqdnFsJGi6TPFw8uuN21ICvK21Hz0GC7cmSbjZ1u1oKQoUTmA5atk4KJ6vVXTlek/AruXIwob6go23UUsON8I8LYgaxssRVibbHeppMogvHcKpHRUj54PaFE9CmIOm0gPYmQ62d+znptiTZvaZyYrm+I+kJHeo23Gn54eYcpNgISbtxwFBb0+WGc8btMFimerehO+U6uW8oNbGIp0EkGkX0PE8rFfvwW1fzU1tQWJOykwPtePec/XsdBt113wkTi8eWmWhGUJ1z9IKSPFyL0jSnNXflx/NNktV4ibjGzxdwXgtwxVESf+1ExBMm6YF0aqKhAgvYOXzQTL1G/+jK2cMBar+TjdcTxqgSriVqQ07mbOHbi/l8yg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199015)(36756003)(86362001)(83380400001)(5660300002)(38100700002)(82960400001)(2616005)(186003)(1076003)(6512007)(6506007)(6486002)(6666004)(26005)(478600001)(54906003)(6916009)(8676002)(66946007)(66556008)(66476007)(316002)(8936002)(41300700001)(2906002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NExLOHNEc3ppdmJKMVdraGwySzVSQXN4RXI5cnNnRUpoeGVUM2pJZVo5Q0dx?=
 =?utf-8?B?SW5TbXZVVWV2TTlNQTBqQVpXWXRJTGpNVC9lQXBJbEVHTk5xUFV2bDJvUTFS?=
 =?utf-8?B?d3VLR0hTYUNlOGhLZ3E0RW52WHd3SmlJd1psUWtDL0hHVGREY3FxN3JlVS95?=
 =?utf-8?B?Ly85cWRSWTZvL0lxTEp0S1k4ODBVMDNaeThYRXU5NmxDNnhydE1SSkUyTThl?=
 =?utf-8?B?REdzckZxVk02Nm5ZTVBQSWU1UFRrWVBjcElaUXVGSlY3dWh0WmRqRUtZQU1Q?=
 =?utf-8?B?V0tVM1Zsa29KdVJDUGR6VHJ2Y3ltWGhSdHB4ZkZzdlBua2Y2VHlKWkQ0Q09O?=
 =?utf-8?B?OGlWakt6WDhyQXI1RFlFaGkzVm5ITnBnQjBzMHBXOCtsVUpkbTdzQWxzWkdv?=
 =?utf-8?B?Y01La3BQQzg0MlpoZkhFN08vUGhiSmJWajVkK2tyZDJMSHYwQ1ZndDUwVExt?=
 =?utf-8?B?ZmRML1Vxc3A2S1NLcXNWcFc4S2t1Z1JYVktvdzI3R2VUcmlJaEJsWGVObS9G?=
 =?utf-8?B?WlkrZC9jNUpidHVQQVl4cCs3cjdoQjNWZjRTc3dQZHVzNVdIRHExSDEzbWZp?=
 =?utf-8?B?WXFwVFNqaXZwcFlWVE9oYWI4aFlUR1hBMGNDUTRkbGtBcysxVFpNeGZCcnR5?=
 =?utf-8?B?L0YrVmdXajRNb2VSdDFXbG5zSENCMHdYSDIvR3QwRDJSdld3b2NYdGVMa2Y0?=
 =?utf-8?B?c2VLZ0U3UGJSNnZFTVlpbTJUT1lRMkdEa1E3OXYya0FWU0tDM3d0VmpSZHB0?=
 =?utf-8?B?aTlUNENHL2R6YXppQUNTMHhWTW1QNHF3UjQwNHJwS3ErK1pydE91VzU0ZU8y?=
 =?utf-8?B?N0F6ZmcrYVJ5Y3NTeGVBVFhpbTdUYWlGVCtOQWtNSGZZVXdSWVFCZUJKY3p5?=
 =?utf-8?B?cTlXaHUyWVRCMjY3OFhKYkM1Q3BBRC9Fc2hWRFVvVzhtZnZubzROUDBMSjNJ?=
 =?utf-8?B?UmRIc3pJclhuclU4a3VBbGU0blV4dHBSTlFLVi9KVFE4eWZvSXc4aVAyVW0w?=
 =?utf-8?B?VXhYUlIwcmxnaDREUE1VUzlENnEvdy9lM0tjdHIrcEt1YjFudDhOSUFVUlhx?=
 =?utf-8?B?VUZKbFBjbWxkdUtsNlVsdkxZbDZNYTB0aHdCUVpDeW15a2JvRmFHUlZ1UnVQ?=
 =?utf-8?B?MlliMkVpblR4TjhTeFVzL0Z0K29qVTMybWYzdFFmSCtBWWJnM0tpdmEzeEhr?=
 =?utf-8?B?U1VJekt2WmpMWVZtczl1ek0yVG1ocllQNVhPMk9QNkwzdzRBRDJrcEhBdldE?=
 =?utf-8?B?aERYMmNDYWJDYUVLTG90aG1pRHRRaFJLdnZzZXU5enF1ZFJneW9FYURMS21l?=
 =?utf-8?B?dWlwUVdRR2llOUhLaVo0Uk9CWWU0T1FhNlNUUnA5K0JvL3V5RFBwK1c5NTVL?=
 =?utf-8?B?b3NWejVSb3M3NDVxemg5eWxYcUlhVk5KcTQzVXJhZEh6aVUvaEEwUkdTekRo?=
 =?utf-8?B?M2VXM0RwaUdHOHpiK1p5WXlOQ3BNWWYwd2hPSUlPSW5iTndiVHBGdloySzAr?=
 =?utf-8?B?dnVKdHlzRzNQc1dEVDdSTGUvWkFUWldOOHZycDNGTHRCYTN3NTJyS2NRUTlU?=
 =?utf-8?B?M3lsL0pOVGJqR1NBelZtREM5UCtzaXVoMWlqOVBDbUU1UmN2ME5KWmZtRTRX?=
 =?utf-8?B?UUw4UE42RGU3ZUJxa3htK2kxNDdmMmpUMVdEeUtMODZLTEk2SFZLMHhGbzN3?=
 =?utf-8?B?NU04VWdmQ0hZSDFma2g0aXFRM2U4eHpRaTVJZ012SVZ1TGtlSmVhUUU5WXZk?=
 =?utf-8?B?NHBsbGNxSzF2OEhOUm9FUC95ZFRsUlJ0VDUzNXRvTHlwYnNIQ2E2cmN0blN3?=
 =?utf-8?B?RzZUMUdoNkNiSlpqZ2pyVk5RN1d5T29USHJLOCtaK1h0YzVpeHh2NWNBQUkz?=
 =?utf-8?B?V05zL3ltM3hIOEtwQ3p2dlVtUFgvZnV1bHVYVlRFck5BYjhOdzQ2YjlRT1I4?=
 =?utf-8?B?aUdjNndTa0UvNUhqUlB2bUM2UHJCSStZVExVTzI5SUxWUVFncWJXaDl4ZEk0?=
 =?utf-8?B?dnBYcjArRDhvYVdaOEpJdGZ4c293K0RhbCtKRmJKdnRIMUtjdjFiMzFYZW1m?=
 =?utf-8?B?T1lEUXUyMUE2cjJteityakpvM1h2ZmhVNVMxRWRrZEFDbTlUWXkzZDVtcnlK?=
 =?utf-8?Q?z7UVCKhPjHPr6EUrdxuSM/7bN?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 690056f4-3f94-4648-57c9-08daaba2397b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 16:04:06.7219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XY7WKD2QERFZtJupM8JqBZCtW/uoc6RgffHXNzEUPdN6I11KmsJsr6iNFBJ3Z48xufnZuYrX5MrvYXBxx/Y8jQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5769

The current logic for AMD SSBD context switches it on every
vm{entry,exit} if the Xen and guest selections don't match.  This is
expensive when not using SPEC_CTRL, and hence should be avoided as
much as possible.

When SSBD is not being set from SPEC_CTRL on AMD don't context switch
at vm{entry,exit} and instead only context switch SSBD when switching
vCPUs.  This has the side effect of running Xen code with the guest
selection of SSBD, which renders the ssbd option without effect (in a
similar way to what already happens on Intel hardware).

This fixes an issue with running C code in a GIF=0 region, that's
problematic when using UBSAN or other instrumentation techniques.

As a result of no longer running the code to set SSBD in a GIF=0
region the locking of amd_set_legacy_ssbd() can be done using normal
spinlocks, and some more checks can be added to assure it works as
intended.

Finally it's also worth noticing that since the guest SSBD selection
is no longer set on vmentry the VIRT_SPEC_MSR handling needs to
propagate the value to the hardware as part of handling the wrmsr.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/amd.c         | 50 ++++++++++++++++++----------------
 xen/arch/x86/hvm/svm/entry.S   |  6 +---
 xen/arch/x86/hvm/svm/svm.c     | 45 ++++++++++++------------------
 xen/arch/x86/include/asm/amd.h |  2 +-
 xen/arch/x86/msr.c             |  7 +++++
 5 files changed, 52 insertions(+), 58 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 98c52d0686..a1582e1cc9 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -742,7 +742,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 }
 
 static struct ssbd_ls_cfg {
-    bool locked;
+    spinlock_t lock;
     unsigned int count;
 } __cacheline_aligned *ssbd_ls_cfg;
 static unsigned int __ro_after_init ssbd_max_cores;
@@ -776,46 +776,48 @@ bool __init amd_setup_legacy_ssbd(void)
 	if (!ssbd_ls_cfg)
 		return false;
 
-	if (opt_ssbd)
-		for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
-			/* Set initial state, applies to any (hotplug) CPU. */
-			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;
+	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++) {
+		/* Set initial state, applies to any (hotplug) CPU. */
+		ssbd_ls_cfg[i].count = opt_ssbd ? boot_cpu_data.x86_num_siblings
+		                                : 0;
+		spin_lock_init(&ssbd_ls_cfg[i].lock);
+	}
 
 	return true;
 }
 
-/*
- * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality
- * that relies on exceptions as those are not expected to run in GIF==0
- * context.
- */
-void amd_set_legacy_ssbd(bool enable)
+static void core_set_legacy_ssbd(bool enable)
 {
 	const struct cpuinfo_x86 *c = &current_cpu_data;
 	struct ssbd_ls_cfg *status;
+	unsigned long flags;
 
 	if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) {
-		set_legacy_ssbd(c, enable);
+		BUG_ON(!set_legacy_ssbd(c, enable));
 		return;
 	}
 
+	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
+	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
 	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
 	                      c->cpu_core_id];
 
-	/*
-	 * Open code a very simple spinlock: this function is used with GIF==0
-	 * and different IF values, so would trigger the checklock detector.
-	 * Instead of trying to workaround the detector, use a very simple lock
-	 * implementation: it's better to reduce the amount of code executed
-	 * with GIF==0.
-	 */
-	while (test_and_set_bool(status->locked))
-		cpu_relax();
+	spin_lock_irqsave(&status->lock, flags);
 	status->count += enable ? 1 : -1;
+	ASSERT(status->count <= c->x86_num_siblings);
 	if (enable ? status->count == 1 : !status->count)
-		set_legacy_ssbd(c, enable);
-	barrier();
-	write_atomic(&status->locked, false);
+		BUG_ON(!set_legacy_ssbd(c, enable));
+	spin_unlock_irqrestore(&status->lock, flags);
+}
+
+void amd_set_ssbd(bool enable)
+{
+	if ( cpu_has_virt_ssbd )
+		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
+	else if ( amd_legacy_ssbd )
+		core_set_legacy_ssbd(enable);
+	else
+		ASSERT_UNREACHABLE();
 }
 
 /*
diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S
index a26589aa9a..94089e61bc 100644
--- a/xen/arch/x86/hvm/svm/entry.S
+++ b/xen/arch/x86/hvm/svm/entry.S
@@ -59,9 +59,6 @@ __UNLIKELY_END(nsvm_hap)
 
         clgi
 
-        ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \
-                        X86_FEATURE_VIRT_SC_MSR_HVM
-
         /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */
         /* SPEC_CTRL_EXIT_TO_SVM       Req: b=curr %rsp=regs/cpuinfo, Clob: acd */
         .macro svm_vmentry_spec_ctrl
@@ -131,8 +128,6 @@ __UNLIKELY_END(nsvm_hap)
         ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
         /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */
 
-        ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \
-                        X86_FEATURE_VIRT_SC_MSR_HVM
 
         /*
          * STGI is executed unconditionally, and is sufficiently serialising
@@ -140,6 +135,7 @@ __UNLIKELY_END(nsvm_hap)
          */
         stgi
 GLOBAL(svm_stgi_label)
+
         mov  %rsp,%rdi
         call svm_vmexit_handler
         jmp  .Lsvm_do_resume
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 1aeaabcb13..0c5ffad05d 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -973,6 +973,14 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v)
 
     /* Resume use of ISTs now that the host TR is reinstated. */
     enable_each_ist(idt_tables[cpu]);
+
+    /*
+     * Clear previous guest selection of SSBD if set.  Note that SPEC_CTRL.SSBD
+     * is already cleared by svm_vmexit_spec_ctrl.
+     */
+    if ( v->domain->arch.cpuid->extd.virt_ssbd &&
+         (v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD) )
+        amd_set_ssbd(false);
 }
 
 static void cf_check svm_ctxt_switch_to(struct vcpu *v)
@@ -1000,6 +1008,11 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v)
 
     if ( cpu_has_msr_tsc_aux )
         wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
+
+    /* Load SSBD if set by the guest. */
+    if ( v->domain->arch.cpuid->extd.virt_ssbd &&
+         (v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD) )
+        amd_set_ssbd(true);
 }
 
 static void noreturn cf_check svm_do_resume(void)
@@ -2518,6 +2531,10 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
         vmcb->spec_ctrl = val;
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        amd_set_ssbd(v->arch.msrs->virt_spec_ctrl.raw);
+        break;
+
     default:
         printk(XENLOG_G_ERR "%s(%pv, 0x%08x, 0x%016"PRIx64") Bad register\n",
                __func__, v, reg, val);
@@ -3116,34 +3133,6 @@ void svm_vmexit_handler(struct cpu_user_regs *regs)
     vmcb_set_vintr(vmcb, intr);
 }
 
-/* Called with GIF=0. */
-void vmexit_virt_spec_ctrl(void)
-{
-    unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0;
-
-    if ( val == current->arch.msrs->virt_spec_ctrl.raw )
-        return;
-
-    if ( cpu_has_virt_ssbd )
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
-    else
-        amd_set_legacy_ssbd(val);
-}
-
-/* Called with GIF=0. */
-void vmentry_virt_spec_ctrl(void)
-{
-    unsigned int val = current->arch.msrs->virt_spec_ctrl.raw;
-
-    if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) )
-        return;
-
-    if ( cpu_has_virt_ssbd )
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
-    else
-        amd_set_legacy_ssbd(val);
-}
-
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index 6a42f68542..81ed71710f 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -153,6 +153,6 @@ void amd_check_disable_c1e(unsigned int port, u8 value);
 
 extern bool amd_legacy_ssbd;
 bool amd_setup_legacy_ssbd(void);
-void amd_set_legacy_ssbd(bool enable);
+void amd_set_ssbd(bool enable);
 
 #endif /* __AMD_H__ */
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 95416995a5..a4c28879bc 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -697,7 +697,14 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
                 msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
         }
         else
+        {
             msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD;
+            /*
+             * Propagate the value to hardware, as it won't be context switched
+             * on vmentry.
+             */
+            goto set_reg;
+        }
         break;
 
     case MSR_AMD64_DE_CFG:
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:22:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:22:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420433.665262 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiI1U-0005eo-BY; Tue, 11 Oct 2022 16:22:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420433.665262; Tue, 11 Oct 2022 16:22:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiI1U-0005eh-8m; Tue, 11 Oct 2022 16:22:28 +0000
Received: by outflank-mailman (input) for mailman id 420433;
 Tue, 11 Oct 2022 16:22:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qHIK=2M=citrix.com=prvs=2762267ab=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiI1S-0005eb-BD
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:22:26 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e2dde4e1-4980-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 18:22:24 +0200 (CEST)
Received: from mail-bn8nam04lp2041.outbound.protection.outlook.com (HELO
 NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.41])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 11 Oct 2022 12:22:21 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by PH0PR03MB6723.namprd03.prod.outlook.com (2603:10b6:510:116::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.18; Tue, 11 Oct
 2022 16:22:16 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022
 16:22:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2dde4e1-4980-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665505344;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=w3ykRHEsqkgARQeFChrLO2Xs20bHdqLTH2B+EJCqL2g=;
  b=XyaudOKAckWYcNDmcQejdmQs6KrdjZXpR2njRZvKybJYdiPRsPlVFAjJ
   /Rd6DdAqh/9fpRRBJMW1yqlfMZ6GqekJfW6HC1MgXsmQw8UrcnrBNbcJF
   Cr3dH5Hp6xixj79jD5dWJjaceU2l1ZbIM5vI5Qo1C+u9pSBslwMAIfx3Y
   E=;
X-IronPort-RemoteIP: 104.47.74.41
X-IronPort-MID: 82909578
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:n7CfxK2im0xOeqs2dvbD5ctwkn2cJEfYwER7XKvMYLTBsI5bpzMPy
 WtKXDqPPq7YY2X0eYx/PoznoxxXvJ7Sm9I3TApvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpB5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUZueJoBjBDr
 sBfJWkIMxuujbm87p2kH7wEasQLdKEHPas5k1Q4kXTzK6ZjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g3J4/Zui4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWDUqiPx2b+ncSXTW40uCuOG6qZT3R6hynE+Kj0rSlykiKzs4qK5c5cFQ
 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 neWm/v5CDopt6eaIU9x7Z+RpDK2fCITfWkLYHdYSRNfu4W65oYukhjIU9BvVravicH4Ei3xx
 DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr8hu+lTOZJv7CV1GU=
IronPort-HdrOrdr: A9a23:0ZdiNq077q3gx4yqLrbUkAqjBVdyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp
 uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa
 DskfZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolys2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RLYGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUQTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+qZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wVh4S0LpXX9
 WGMfusqsq/KTihHjHkVyhUsZeRt00Ib1u7qhNogL3U79BU9EoJvHfwivZv3Uvoz6hNOqWs19
 60TZiAq4s+MPP+TZgNcdvpEvHHflDlcFbrDF+4B2jBOeUuB0/twqSHkIndotvaMKA18A==
X-IronPort-AV: E=Sophos;i="5.95,176,1661832000"; 
   d="scan'208";a="82909578"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fvCXc4Rc1wAV0srkO6xKEzsTN4wNzZktanKJ4ARks7hO0C3QaHkqQjT2ADe3OzxamnODEX66o9QWG8e1bgPSqKrkdxYu4KwwCh1zNFbHPWlkXzwMV2ko3QIIL3YHSTLv/VdUAuaZ+NJITOrJQQZeYUfIMO9sAbzUgcbu+kJQIhVhXkKCaAcHSNHjds7F6VyqdakTsmQAZ5v43LmgLZa/QG5Arvk6F7v5L0u2N/4ZbMNBz1htf683ITxTlJfBo1l9stgEjyn5ffVoGXdHFG16fH0RFVvzenFSBzua1LijdJPwjj/3WnqrXMHvfIDZpuh9hW8GBtkY147tj5j2iR51tQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MAqLP0bsxCz0hHWLie1B+857fbmoIn68UrorEMA+1SU=;
 b=TvrFhTvGynMbUZFA8zAuGvS44NkGHiG0GuxFzMcCfyb/yFbASeMHX1OSaHkBL1bq2pJKJTkNNaJqtF8f8yTc02Em5/k3iS85VK/TZSlN3ZyAUWbWwC6qtWhDPU3zU2p9qC3heYCHfEYtxRxVrtK2u/W23c7VPPUKC2N10BSPH+dsI+1+U2t1owVcIz3iqz5xnyiYzkYAl7TvK6KRmLvcWQBOwJf/OGc6wmJfQfolfivUQjKHj7NblZbwXrQMuVQQE+gr0zvqckDHMfVobHlXemQP1r+NUzf1ezIOLHLesGnCo7E2UrcFdW8hDR8UP8VW3VTfyLHC7jpXi3wLx11XcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MAqLP0bsxCz0hHWLie1B+857fbmoIn68UrorEMA+1SU=;
 b=QSlPevNY24xNn3ukVuHeET+OKfrVIZCXZCK6+tQu4+z/8sA2EXqkHWjaeXl3Bx/R/MbPTF5Gfk6u/JC5Rk0HPwBKI6Sku3ah88PHWSBS6N47kJO7xH1m2xWTFpZRRLqB3XDOuqUGcoQ4EYJmLuTsA2h00SqRtZuhRrGRdTUw1b8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 11 Oct 2022 18:22:11 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 1/5] x86/mwait-idle: add 'preferred-cstates' command
 line option
Message-ID: <Y0WYM/trMDVja61r@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <0690742b-21c8-e5b6-e8ff-5d4709e0c3ee@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0690742b-21c8-e5b6-e8ff-5d4709e0c3ee@suse.com>
X-ClientProxiedBy: LNXP265CA0025.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5c::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6723:EE_
X-MS-Office365-Filtering-Correlation-Id: ea1bd29c-99ff-4495-eeb3-08daaba4c30b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6KkcJ0Z2t7pxnCy5djYYt/60XLELoYwTc6V1nFIv0sblP7yePr4atFnY6iX5QUkdifoq/kWhgs1Wl2lVgqoO994ERWy2l3k68P9b9a4Smv2aQ+ZPKrtWDqWg7Md16g7AeBp9BSW39KHWpHjCh4UQVKsMaAf0oOqNyCI1TF7M+Y1eUB0xtH4IUFqHh6AvdpxX23Yzq3ZkWvezGn+16pkETt8x+Y1XBu4cPoE2Y43qEk8O/ASI27PS8nQ34uMjl2azQm2qLXoWh9MJZDdxKe2PKiWy69Z2vm5kFgNvJX7a4649IXqBgaUygSKCSeknLFZTT+4Bsd9KHd4UELc4KfP1j6mzrtvzNOtgNfTp5IwMen9/1R8Ue2eVv1xas1JOY527z257w+PR7lPxfqgAZolwFV8LcDGPtsMCHaSBvHS6GFOU26ZX9hJi6EKok8f1kcmrJ13UhGID3JAnUMXiojZyz/ZLm0cmtUbWUxihoyiUgnx3YLgUnYbJFvxJllCZHMQSTopEotf4czVmpkjFi9lvj3+05XVjNmQOFe7hstEoMKMNEm6XuMnkSkk3GO8kyo7LsGF//j5xkmhHrHd6M3HujwJmj9AGRAyLssK8tP4EqOqZT1E3r+qiVrCu/MqoxVqlyC3BMTZUEEX3rgR6d6AT0kVKeo9Izq+MFuzDB4hY18hi/XsXs9Ptfft4C6xLj/aP+BgyHMbjEekupcEOt5O4Ng==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(376002)(366004)(396003)(39860400002)(136003)(451199015)(9686003)(6512007)(26005)(54906003)(316002)(6486002)(82960400001)(478600001)(38100700002)(85182001)(86362001)(66476007)(83380400001)(33716001)(186003)(6506007)(4326008)(6666004)(30864003)(6916009)(8676002)(66556008)(8936002)(5660300002)(66946007)(41300700001)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nys5empBcm9ZMFJrd2pPaDZ3MUUvTThIRUNXZjk3WVA0K1VZY1RsaVNxa1c0?=
 =?utf-8?B?SE1HakkzZnI0cjZsb212QmcwNXRFenY1SnFoQS9TYlBZcEg3R3ZiVWVkZFNP?=
 =?utf-8?B?eXEzV2xFSTBPV0FYUEV1Snp5SVRDRnpGTkxmREJlUVQ5K0hGcW1ubXp2K0lw?=
 =?utf-8?B?Z0VQcWxPYnROQkRBS0ZhZncza3Z3Rk1KY1d1emo4Y0R4REowT25pSHFna0ZY?=
 =?utf-8?B?QnpUSUhtTVRuRmhEcUdzOVAzYXIxbUg4QmFveHMyL2J6REVZcVJWa0hIZFVC?=
 =?utf-8?B?NjV3R3d2R0x6aFZDbXV0eGE4TFJJMVRtRGhVd1JJTXBjZnpXeEpkTU11T2VR?=
 =?utf-8?B?M255SDFld2hhT3hIUHJGM241K3FLbExSaktzN2RrRWVtdHR3bnpVNUNRbWIy?=
 =?utf-8?B?aXRLZG90a2ZxbnMvZHVlWFVES0ZibUVjeHpZNnEwNGtNNmdTVTgwWERHTnl3?=
 =?utf-8?B?MnVrRkt1eW84QllDdHpreXd3SUJTb3B6ZmdtOEQ4eXF2MDFOT1I0TkJNT0lE?=
 =?utf-8?B?VWlKMkpCbFc0djBrYkQzd2tnZm9qaHdEMWN4ZUNkR1VDbGMrNnFIQjZqaFBF?=
 =?utf-8?B?bWorWnNhbE1OU0NTYkhray9SdkFZanh1RCtLSmtjZjNrYkhhalg5REsrb3Np?=
 =?utf-8?B?RGQ5L2QzVll3VU40dnE0ellZSmsva3BNSHlIa0VPQ2hkYTFVNFlpRVdReVor?=
 =?utf-8?B?ZS8vSEdiMHRXeVFaVkhFMmhKTWl0RkhMZ0VsVGJMUG9qcHhRVVR3Z2I5d21r?=
 =?utf-8?B?VVY1Mmw0elJPWk9sR3NjUVYwZG1ZMmVyaXVXTUl4UmhkbEwxS2s1QWhQa1dr?=
 =?utf-8?B?dWd0YVlEa3YyU3ArWlFMVVNRd0txeDlacUtIaGtlNEZISzRsK0g0Q21zVjVU?=
 =?utf-8?B?M2NTUUF4NzA4ZnZPVjhiQVlZbjRXaVZMUmxldWEwVHBpb2kxYjhVNlJYenZp?=
 =?utf-8?B?NzVIdlpSamlzdGlnVWtTOXJUb3pKRUlIS2tobUhMNjhDaWpZWFpiYTZKMCtP?=
 =?utf-8?B?Wm1SK0FkeGs2K0FDd25uSVJ6Y1hNN2M4QjdoNDBkeEhEZTd2VE5NV1dyOVZj?=
 =?utf-8?B?UG1VZll1NnZhaGxsZ09kbW9aaGJ0cm5nekJ3NHZaNEpqYnFmaElFQ1pNR2tz?=
 =?utf-8?B?SVlRaFFGV2FEcC9xOVdyZ2puWTNlZEJ6MHM4SGRRbmlpWWVaTGNuMjAvb2VX?=
 =?utf-8?B?MkF5Y1ExVDBCeFQvbS9pbHVPTFZPaHFRMGFHMXY2U2ozRVlLTUJ0M2NTVmxv?=
 =?utf-8?B?VWFnUTJZcXNvU3A1QnNqeHhrQTVwR1JvVGRLc3lsMmVtRmU3THZaNm5lbmNO?=
 =?utf-8?B?RnRzci9hRmtybzlheVJwWHppLzdkSmNRZ2o4ZlhWV3ZsSzVQUzNLYy83OWZi?=
 =?utf-8?B?cjdTV3Y1T3c3anVvOVhKb1dJblp4TFVpc2lxcWNtcGlrQzFzRTZNUkRJWUJt?=
 =?utf-8?B?ajZqVFNITVR1RjdPRjR3K04wMXQ0ZUs3MkhjZ1pqR3NiZVhVYXlPMDdmZUln?=
 =?utf-8?B?QTlXRFNzL3BTQStTRmJVcnRtNUJRYTlPc3FCT2tyWTF2cmlOREN6NXRWdE5l?=
 =?utf-8?B?VmgvcEU2V1hBM3ZHUUZ4NTZ1b2xmbG1qK1ZyNEdTR3BQVVlIdFY5NFIwUEll?=
 =?utf-8?B?MkRUTzZ5dEFuaDV4M3M1THRzY1N4bnZFWEF6TkNOakhOZC93ZDJ6L0JiRStR?=
 =?utf-8?B?Y2dVVnVCTHJ4dUtpbnJoVkRWRDhTM3ptcDdYTkxmYXN6dThJc0paZ1h2anJh?=
 =?utf-8?B?ZUYzcFU2TkY2a2JqQ3o2a05MLzU4bkFWYmJIL3RVZTBXME9nb0pGMmJUSEFi?=
 =?utf-8?B?dmdBNUtZWWdPcmt4MnVvUmFQQjdRME00QVRqd295eHlGOWhBUXNyQWdJVkc0?=
 =?utf-8?B?YU9ybzd4TXkrTzZYNWpZSW9US3ZxbVVTUDVOcmduanJhcDg5UXNPemdsNXFO?=
 =?utf-8?B?eFd0UkJzTWxzWGdVTkduQ25jSStQbXVrc2RjMk1CWWF0bUZDMTdwWWI0QlI1?=
 =?utf-8?B?Kzc0Rkw0Rk1MNGpSVEp6MW1GL0NzNFpyeEFRMXIyTnN6UTBHbDFvTlpUT1JY?=
 =?utf-8?B?OVA2NFhva3Y2Q3QxQlZuM3ZMeEJVc2gzRzRyL3dFdnRsVmIxT2JRQzFyaVNV?=
 =?utf-8?Q?Xx3Z7upPRxhBqmAkV0gP5OD1/?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea1bd29c-99ff-4495-eeb3-08daaba4c30b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 16:22:16.4327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3NIbY2wZXjKlKFzlmdZFYFmFHSor9yvQZA4CO2vq2tthVW6AbYMAjTGAOOCDW8WKPaVOhgk5ZyWxeJP69sJOLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6723

On Thu, Aug 18, 2022 at 03:03:33PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually
> exclusive - only one of them can be enabled. By default, 'intel_idle' driver
> enables C1 and disables C1E. However, some users prefer to use C1E instead of
> C1, because it saves more energy.
> 
> This patch adds a new module parameter ('preferred_cstates') for enabling C1E
> and disabling C1. Here is the idea behind it.
> 
> 1. This option has effect only for "mutually exclusive" C-states like C1 and
>    C1E on SPR.
> 2. It does not have any effect on independent C-states, which do not require
>    other C-states to be disabled (most states on most platforms as of today).
> 3. For mutually exclusive C-states, the 'intel_idle' driver always has a
>    reasonable default, such as enabling C1 on SPR by default. On other
>    platforms, the default may be different.
> 4. Users can override the default using the 'preferred_cstates' parameter.
> 5. The parameter accepts the preferred C-states bit-mask, similarly to the
>    existing 'states_off' parameter.
> 6. This parameter is not limited to C1/C1E, and leaves room for supporting
>    other mutually exclusive C-states, if they come in the future.
> 
> Today 'intel_idle' can only be compiled-in, which means that on SPR, in order
> to disable C1 and enable C1E, users should boot with the following kernel
> argument: intel_idle.preferred_cstates=4
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da0e58c038e6
> 
> Enable C1E (if requested) not only on the BSP's socket / package. Alter
> command line option to fit our model, and extend it to also accept
> string form arguments.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: Also accept string form arguments for command line option. Restore
>     C1E-control related enum from Linux, despite our somewhat different
>     use (and bigger code churn).
> 
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1912,6 +1912,12 @@ paging controls access to usermode addre
>  ### ple_window (Intel)
>  > `= <integer>`
>  
> +### preferred-cstates (x86)
> +> `= ( <integer> | List of ( C1 | C1E | C2 | ... )`
> +
> +This is a mask of C-states which are to be used preferably.  This option is
> +applicable only on hardware were certain C-states are exclusive of one another.
> +
>  ### psr (Intel)
>  > `= List of ( cmt:<boolean> | rmid_max:<integer> | cat:<boolean> | cos_max:<integer> | cdp:<boolean> )`
>  
> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -82,10 +82,29 @@ boolean_param("mwait-idle", opt_mwait_id
>  
>  static unsigned int mwait_substates;
>  
> +/*
> + * Some platforms come with mutually exclusive C-states, so that if one is
> + * enabled, the other C-states must not be used. Example: C1 and C1E on
> + * Sapphire Rapids platform. This parameter allows for selecting the
> + * preferred C-states among the groups of mutually exclusive C-states - the
> + * selected C-states will be registered, the other C-states from the mutually
> + * exclusive group won't be registered. If the platform has no mutually
> + * exclusive C-states, this parameter has no effect.
> + */
> +static unsigned int __ro_after_init preferred_states_mask;
> +static char __initdata preferred_states[64];
> +string_param("preferred-cstates", preferred_states);
> +
>  #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF
>  /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */
>  static unsigned int lapic_timer_reliable_states = (1 << 1);
>  
> +enum c1e_promotion {
> +	C1E_PROMOTION_PRESERVE,
> +	C1E_PROMOTION_ENABLE,
> +	C1E_PROMOTION_DISABLE
> +};
> +
>  struct idle_cpu {
>  	const struct cpuidle_state *state_table;
>  
> @@ -95,7 +114,7 @@ struct idle_cpu {
>  	 */
>  	unsigned long auto_demotion_disable_flags;
>  	bool byt_auto_demotion_disable_flag;
> -	bool disable_promotion_to_c1e;
> +	enum c1e_promotion c1e_promotion;
>  };
>  
>  static const struct idle_cpu *icpu;
> @@ -924,6 +943,15 @@ static void cf_check byt_auto_demotion_d
>  	wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0);
>  }
>  
> +static void cf_check c1e_promotion_enable(void *dummy)
> +{
> +	uint64_t msr_bits;
> +
> +	rdmsrl(MSR_IA32_POWER_CTL, msr_bits);
> +	msr_bits |= 0x2;
> +	wrmsrl(MSR_IA32_POWER_CTL, msr_bits);
> +}
> +
>  static void cf_check c1e_promotion_disable(void *dummy)
>  {
>  	u64 msr_bits;
> @@ -936,7 +964,7 @@ static void cf_check c1e_promotion_disab
>  static const struct idle_cpu idle_cpu_nehalem = {
>  	.state_table = nehalem_cstates,
>  	.auto_demotion_disable_flags = NHM_C1_AUTO_DEMOTE | NHM_C3_AUTO_DEMOTE,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_atom = {
> @@ -954,64 +982,64 @@ static const struct idle_cpu idle_cpu_li
>  
>  static const struct idle_cpu idle_cpu_snb = {
>  	.state_table = snb_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_byt = {
>  	.state_table = byt_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  	.byt_auto_demotion_disable_flag = true,
>  };
>  
>  static const struct idle_cpu idle_cpu_cht = {
>  	.state_table = cht_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  	.byt_auto_demotion_disable_flag = true,
>  };
>  
>  static const struct idle_cpu idle_cpu_ivb = {
>  	.state_table = ivb_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_ivt = {
>  	.state_table = ivt_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_hsw = {
>  	.state_table = hsw_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_bdw = {
>  	.state_table = bdw_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_skl = {
>  	.state_table = skl_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_skx = {
>  	.state_table = skx_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_icx = {
>         .state_table = icx_cstates,
> -       .disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static struct idle_cpu __read_mostly idle_cpu_spr = {
>  	.state_table = spr_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_avn = {
>  	.state_table = avn_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_knl = {
> @@ -1020,17 +1048,17 @@ static const struct idle_cpu idle_cpu_kn
>  
>  static const struct idle_cpu idle_cpu_bxt = {
>  	.state_table = bxt_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_dnv = {
>  	.state_table = dnv_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  static const struct idle_cpu idle_cpu_snr = {
>  	.state_table = snr_cstates,
> -	.disable_promotion_to_c1e = true,
> +	.c1e_promotion = C1E_PROMOTION_DISABLE,
>  };
>  
>  #define ICPU(model, cpu) \
> @@ -1241,6 +1269,25 @@ static void __init skx_idle_state_table_
>  }
>  
>  /*
> + * spr_idle_state_table_update - Adjust Sapphire Rapids idle states table.
> + */
> +static void __init spr_idle_state_table_update(void)
> +{
> +	/* Check if user prefers C1E over C1. */
> +	if (preferred_states_mask & BIT(2, U)) {
> +		if (preferred_states_mask & BIT(1, U))
> +			/* Both can't be enabled, stick to the defaults. */
> +			return;
> +
> +		spr_cstates[0].flags |= CPUIDLE_FLAG_DISABLED;
> +		spr_cstates[1].flags &= ~CPUIDLE_FLAG_DISABLED;
> +
> +		/* Request enabling C1E using the "C1E promotion" bit. */
> +		idle_cpu_spr.c1e_promotion = C1E_PROMOTION_ENABLE;
> +	}
> +}
> +
> +/*
>   * mwait_idle_state_table_update()
>   *
>   * Update the default state_table for this CPU-id
> @@ -1261,6 +1308,9 @@ static void __init mwait_idle_state_tabl
>  	case INTEL_FAM6_SKYLAKE_X:
>  		skx_idle_state_table_update();
>  		break;
> +	case INTEL_FAM6_SAPPHIRERAPIDS_X:
> +		spr_idle_state_table_update();
> +		break;
>  	}
>  }
>  
> @@ -1268,6 +1318,7 @@ static int __init mwait_idle_probe(void)
>  {
>  	unsigned int eax, ebx, ecx;
>  	const struct x86_cpu_id *id = x86_match_cpu(intel_idle_ids);
> +	const char *str;
>  
>  	if (!id) {
>  		pr_debug(PREFIX "does not run on family %d model %d\n",
> @@ -1309,6 +1360,39 @@ static int __init mwait_idle_probe(void)
>  	pr_debug(PREFIX "lapic_timer_reliable_states %#x\n",
>  		 lapic_timer_reliable_states);
>  
> +	str = preferred_states;
> +	if (isdigit(str[0]))
> +		preferred_states_mask = simple_strtoul(str, &str, 0);
> +	else if (str[0])
> +	{
> +		const char *ss;
> +
> +		do {
> +			const struct cpuidle_state *state = icpu->state_table;
> +			unsigned int bit = 1;
> +
> +			ss = strchr(str, ',');
> +			if (!ss)
> +				ss = strchr(str, '\0');
> +
> +			for (; state->name[0]; ++state) {
> +				bit <<= 1;
> +				if (!cmdline_strcmp(str, state->name)) {
> +					preferred_states_mask |= bit;
> +					break;
> +				}
> +			}
> +			if (!state->name[0])
> +				break;
> +
> +			str = ss + 1;
> +	    } while (*ss);
> +
> +	    str -= str == ss + 1;

I would add parentheses to the sum for clarity.

> +	}
> +	if (str[0])
> +		printk("unrecognized \"preferred-cstates=%s\"\n", str);
> +
>  	mwait_idle_state_table_update();
>  
>  	return 0;
> @@ -1400,8 +1484,18 @@ static int cf_check mwait_idle_cpu_init(
>  	if (icpu->byt_auto_demotion_disable_flag)
>  		on_selected_cpus(cpumask_of(cpu), byt_auto_demotion_disable, NULL, 1);
>  
> -	if (icpu->disable_promotion_to_c1e)
> +	switch (icpu->c1e_promotion) {
> +	case C1E_PROMOTION_DISABLE:
>  		on_selected_cpus(cpumask_of(cpu), c1e_promotion_disable, NULL, 1);
> +		break;
> +
> +	case C1E_PROMOTION_ENABLE:
> +		on_selected_cpus(cpumask_of(cpu), c1e_promotion_enable, NULL, 1);
> +		break;
> +
> +	case C1E_PROMOTION_PRESERVE:
> +		break;
> +	}

I find it kind of weird to user a notifier for this, won't it be
easier to set the C1E promotion as part of the CPU bringup process?

I see we also set other bits in the same way.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:29:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:29:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420441.665273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiI7o-0006by-5f; Tue, 11 Oct 2022 16:29:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420441.665273; Tue, 11 Oct 2022 16:29:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiI7o-0006br-2b; Tue, 11 Oct 2022 16:29:00 +0000
Received: by outflank-mailman (input) for mailman id 420441;
 Tue, 11 Oct 2022 16:28:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI7m-0006bh-R7; Tue, 11 Oct 2022 16:28:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI7m-0006yi-LU; Tue, 11 Oct 2022 16:28:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI7m-0007bB-3m; Tue, 11 Oct 2022 16:28:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI7m-0000nV-2q; Tue, 11 Oct 2022 16:28:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1d5BnMWIltSaSi5Wd7J5Y+5TFN30lYJuPsP13NvClUA=; b=XFUs0anLdUFuCEalL4vaSL2uap
	OS2xTExq1dul6aum7RGns7XS4Hzg43FhxttlM8B+1rKN1Ut+7+DG1Dkmpwk1ipZbqVjiqtEt0IXcv
	It+mnzbquiRGzpLp/ZIpQftdsumAVOA+eVE0Yn9Zr6B+brNP6NDY+92kSvuDQRufH7eI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173494-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173494: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:build-arm64:xen-build:fail:regression
    xen-4.15-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64:xen-build:fail:regression
    xen-4.15-testing:build-amd64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-armhf:xen-build:fail:regression
    xen-4.15-testing:build-i386-xsm:xen-build:fail:regression
    xen-4.15-testing:build-i386:xen-build:fail:regression
    xen-4.15-testing:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-3:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-4:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-5:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    xen=9690bb261d5fa09cb281e1fa124d93db7b84fda5
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 16:28:58 +0000

flight 173494 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173494/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172547
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64                   6 xen-build                fail REGR. vs. 172547
 build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
 build-armhf                   6 xen-build                fail REGR. vs. 172547
 build-i386-xsm                6 xen-build                fail REGR. vs. 172547
 build-i386                    6 xen-build                fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-amd64-coresched-amd64-xl  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-shadow    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-rtds      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ws16-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qemut-ws16-amd64  1 build-check(1)             blocked n/a
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qcow2     1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvshim    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-intel  1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-intel  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit2   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-amd64-livepatch    1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-intel  1 build-check(1)              blocked n/a
 test-amd64-amd64-migrupgrade  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pair         1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pygrub       1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-freebsd11-amd64  1 build-check(1)           blocked n/a
 test-amd64-amd64-qemuu-freebsd12-amd64  1 build-check(1)           blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-1        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-2        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-3        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-4        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-5        1 build-check(1)               blocked  n/a

version targeted for testing:
 xen                  9690bb261d5fa09cb281e1fa124d93db7b84fda5
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   57 days
Testing same since   173494  2022-10-11 13:38:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              fail    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64-xtf                                              pass    
 build-amd64                                                  fail    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       blocked 
 test-xtf-amd64-amd64-2                                       blocked 
 test-xtf-amd64-amd64-3                                       blocked 
 test-xtf-amd64-amd64-4                                       blocked 
 test-xtf-amd64-amd64-5                                       blocked 
 test-amd64-amd64-xl                                          blocked 
 test-amd64-coresched-amd64-xl                                blocked 
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        blocked 
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         blocked 
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      blocked 
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            blocked 
 test-amd64-amd64-xl-pvhv2-amd                                blocked 
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              blocked 
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       blocked 
 test-amd64-amd64-qemuu-freebsd12-amd64                       blocked 
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         blocked 
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         blocked 
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  blocked 
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  blocked 
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        blocked 
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          blocked 
 test-amd64-amd64-xl-pvhv2-intel                              blocked 
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   blocked 
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 blocked 
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                blocked 
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        blocked 
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   blocked 
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     blocked 
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   blocked 
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 689 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:29:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:29:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420448.665283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiI8e-00078k-F8; Tue, 11 Oct 2022 16:29:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420448.665283; Tue, 11 Oct 2022 16:29:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiI8e-00078d-C7; Tue, 11 Oct 2022 16:29:52 +0000
Received: by outflank-mailman (input) for mailman id 420448;
 Tue, 11 Oct 2022 16:29:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI8d-00078Q-5m; Tue, 11 Oct 2022 16:29:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI8d-0006zK-4w; Tue, 11 Oct 2022 16:29:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI8c-0007f9-Jq; Tue, 11 Oct 2022 16:29:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiI8c-0001BY-JP; Tue, 11 Oct 2022 16:29:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GEj6qAMW7eWaxlt3sxpfmKJuRIx1WArO7yACklhg/co=; b=01hweoC1EUhE0DbB3VhWfymKHl
	dmjJirPYygViekcNdP+j3BZR9zWx4leHUnbFwF+mkgur1UQdrkTVDyJC+Z56sU2sU2SCdAcnYvcFH
	kbHBrD3q/B8bZfyrcMH5XeBGKFYrkWwXrUvnvrTl4s9Naf1T6oRluY/POnfFmkdfN+IE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173492-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173492: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 16:29:50 +0000

flight 173492 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173492/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    4 days
Testing same since   173492  2022-10-11 13:01:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 427 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 16:53:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 16:53:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420460.665301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiIUw-0002Xl-Gw; Tue, 11 Oct 2022 16:52:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420460.665301; Tue, 11 Oct 2022 16:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiIUw-0002Xe-Dl; Tue, 11 Oct 2022 16:52:54 +0000
Received: by outflank-mailman (input) for mailman id 420460;
 Tue, 11 Oct 2022 16:52:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xsRG=2M=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1oiIUv-0002XY-1n
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 16:52:53 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 235cd4ea-4985-11ed-91b4-6bf2151ebd3b;
 Tue, 11 Oct 2022 18:52:50 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 9E7E95C0091;
 Tue, 11 Oct 2022 12:52:48 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 11 Oct 2022 12:52:48 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 11 Oct 2022 12:52:48 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 235cd4ea-4985-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm2; t=1665507168; x=
	1665593568; bh=C3UQ9ArIG3SiYomPhWP9uLz4e7VzNrkJ8+iF2qlT7Q0=; b=k
	Ygu/R1rubFOjsxjr2rg/eMWJ1VPHmbmNnGYftqVhGkSHux5kvV3PlCO44SR8GWpm
	X/iKLXC4JhvQydF5Bxyfr7+Kaf8kTlSdlWPAhvkvar1OIk8wJ0AWEToVB1qilz6O
	370FlI5zEe9qVyEvWtVUt1heQvMhx25jQVQcW4AzBynQgREFcB8ZbrVPNUCbwgw4
	ZO1uVqnXHXWoc6oBhlUmYyG4Dk4kHgQNpu8f1sVFvguCyrjvyRzjOqJp1kcRHNT1
	cD1ti3zRpoSbCKF+UdT+qVDM4PE6m9WU2rTKYPA4IW0Y83XyF9z9hO4aUPGGpFJn
	f0k2hpvzXeEx7CaHrx4tg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1665507168; x=1665593568; bh=C3UQ9ArIG3SiYomPhWP9uLz4e7Vz
	NrkJ8+iF2qlT7Q0=; b=VY2onS2t8ckFZzhCdiWJbY8L1hhspdrb6xTCxz1s40SY
	L1uA0r0cl3NbP/ILZBF0EuJdEDEUbNjIxZovx0++jTGoIng+TSevNLA9Il8KL7aC
	kUuxgMiMS5aJd1fdBBw9JvmrPX2kvfVoHjuFAWTQxGQxIy+vcEnKS8+o0kZFRMbd
	G/PSJ45bs9njaKSqT48fn4HlubtUskLWunpKbK+txd6yTKhNk+NrlfXK/gu9y6MA
	EE3X4ttnyAH1eb8fRWV+USk+EKMOeSKmRNUprmWQLsbCOqDXYXGISpvWqvTgTI5N
	KjAYu5O0InkHEnMWebIgQKHFFLfFi558uQ2N5687ug==
X-ME-Sender: <xms:YJ9FY_ET-TYNogzIayHDRCG-IrL3glUjWnxYi1rO28fAB1-YHXbmIg>
    <xme:YJ9FY8UfGtiTSzmN82i7LvckFtV-QSH-uqmFvWu5h5p8EMdOlrkuSBYo2o2S8Po3E
    Vjyu9FrCC35smQ>
X-ME-Received: <xmr:YJ9FYxLdppJIFmrHS0fpKN5lltHDAuBNwRDBdYnL6G0alQu14NAzkiet4CjE>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejiedguddtvdcutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm
    ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh
    hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvuedtgefhffffvdegtedtkedt
    hfduffdtudeigeeugfejieekueffueekgfevgeenucffohhmrghinhepgigvnhhprhhojh
    gvtghtrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf
    rhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:YJ9FY9G4JQk9_TEFqhUaULl3RyHCflHl_r4YE1uF_Tr4pGNeDA9H0Q>
    <xmx:YJ9FY1U7C6SxI1mRfk6d_eYLsfvVU1exYYJO52-xx658JirYlhm00g>
    <xmx:YJ9FY4M9WdlnYToZe8fyGzccGYKtYZG6C0V_ISByEhk8X-SRNBK_9A>
    <xmx:YJ9FY2fKt9QYjhEVeoWev5RMTeaAh8_rBrgH0F-FSPexk9B5GxxQuA>
Feedback-ID: iac594737:Fastmail
Date: Tue, 11 Oct 2022 12:52:22 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Ard Biesheuval <ardb@kernel.org>,
	Xen developer discussion <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT
Message-ID: <Y0WfXttQHfFle2R7@itl-email>
References: <ce73ae2fa148c5d79a038275b0983d24537e97de.1665458679.git.demi@invisiblethingslab.com>
 <9c1731eb-44f6-41c6-cb4e-51abf0c50052@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="hzkCLTD7EOYUE31i"
Content-Disposition: inline
In-Reply-To: <9c1731eb-44f6-41c6-cb4e-51abf0c50052@suse.com>


--hzkCLTD7EOYUE31i
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 11 Oct 2022 12:52:22 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Ard Biesheuval <ardb@kernel.org>,
	Xen developer discussion <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT

On Tue, Oct 11, 2022 at 11:59:01AM +0200, Jan Beulich wrote:
> On 11.10.2022 05:42, Demi Marie Obenour wrote:
> > A previous patch tried to get Linux to use the ESRT under Xen if it is
> > in memory of type EfiRuntimeServicesData.  However, this turns out to be
> > a bad idea.  Ard Biesheuvel pointed out that EfiRuntimeServices* memory
> > winds up fragmenting both the EFI page tables and the direct map,
>=20
> Can this statement please be made describe Xen, not Linux? Aiui at least
> the directmap aspect doesn't apply to Xen.

Should it apply to Xen?  My understanding is that Ard=E2=80=99s statements
regarding mismatched attributes refer to any kernel, not just Linux.
You would be in a better position to judge that, though.

> > and
> > that EfiACPIReclaimMemory is a much better choice for this purpose.
>=20
> I think the "better" wants explaining here, without requiring people to
> follow ...

Something like, =E2=80=9CEfiACPIReclaimMemory is the correct type for
configuration tables that are only used by the OS.=E2=80=9D?

> > Link: https://lists.xenproject.org/archives/html/xen-devel/2022-09/msg0=
1365.html
>=20
> ... this link. Since the code change looks okay to me, I'd be okay to
> replace the description with an adjusted one while committing.

That is fine with me.

> However,
> if you expect the change to go into 4.17, you will want to resubmit
> with Henry on Cc:, so he can consider giving the now necessary release-
> ack.

Will do, with your updated commit message.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--hzkCLTD7EOYUE31i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmNFn14ACgkQsoi1X/+c
IsH+2Q/6A5XGSxnT0LaZ3RYuDjNltuulYLcvgf3uAzvwRa79sXqgs5U3FYuo35kg
kBoxBz2jwrYYQfNQAUeFp8MjTJYvBLsrwURnMGrtqsaXcypJA28x6RXWZedzNnHx
raY+kBDvJosAOexH+kBXop6FTs/ZobEw5htFny+f7ZRpOMmPQIiTtgjnhyInEOZ3
gw7XvPNvkk+KYvkzR0eT7Yp4OMIjXMi4Cmy8x2Qx1QnHgzoNTFsaGAvOScByFnNR
N8mTFaDaDErIFUySiBkAiFMGNsC90mCNIXHPfGmlFqMwcBoMfjJ4nxFZQKgDTG/p
UZSC1TwRYrx2XbCCh1QpDq01weXOg4witJdExUHQHqoczxrGzdZNXFTcLn0Mgrp+
MsC+QNRjrjBJg7ze0RrXGgFpg8JmbCtfQpabvz03Jripbo5TpvlQvkpH7Xu6p9ym
L0wgWiEdKykBGd89b0zdZDfo+CWFcA8z42vGhhaH7lYgHKwaPvnMYLoj3j07pFyi
PWlQ1HWRBj72RHy/25kzmsoA+A0OJDSpie8mHG1u3GHhU3WIuAgiCjrBI7F3D6Sr
kObxQLZDVTEhQ6tynDLBekwH7LkZQwmRF6PaY+xoxwW8riEAhFMzwTKwb0kNWYlx
R1rjc10Nitwqp3Eyx6OC/7LuES+P0Qh3/SrC07qIjxTQJlKw0mY=
=496+
-----END PGP SIGNATURE-----

--hzkCLTD7EOYUE31i--


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 20:11:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 20:11:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420471.665318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiLam-0000hs-Ox; Tue, 11 Oct 2022 20:11:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420471.665318; Tue, 11 Oct 2022 20:11:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiLam-0000hl-Lv; Tue, 11 Oct 2022 20:11:08 +0000
Received: by outflank-mailman (input) for mailman id 420471;
 Tue, 11 Oct 2022 20:11:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLal-0000hb-MV; Tue, 11 Oct 2022 20:11:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLal-00030O-Ih; Tue, 11 Oct 2022 20:11:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLak-000621-TD; Tue, 11 Oct 2022 20:11:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLak-0002OW-Rk; Tue, 11 Oct 2022 20:11:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8VUNSBp6OdqxLzqgu8y5zByTZPgYnToR99X6eO5D31M=; b=yMcKVfRycPDUMH0aBsnPrO4NfG
	fd1+FeXqrb/Iazo+lKMHZ6Xn4iEVVVyEdmw13LHZ66AM9rYSAdZd9yGBIKFjTu+E+aRjcbEZak8Ew
	FUcmYtfb1/1eqyt4hQI+9LJF2glIpkDQ6upLPjREtO15VH0cD5voT5EXghD2cf2kzBL4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173491-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173491: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=60bb8154d1d77042a5d43d335a68fdb202302cbe
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 20:11:06 +0000

flight 173491 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173491/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                60bb8154d1d77042a5d43d335a68fdb202302cbe
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    4 days
Failing since        173470  2022-10-08 06:21:34 Z    3 days   12 attempts
Testing same since   173491  2022-10-11 11:42:23 Z    0 days    1 attempts

------------------------------------------------------------
927 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 85220 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 20:32:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 20:32:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420479.665328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiLvk-0003Wq-Ew; Tue, 11 Oct 2022 20:32:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420479.665328; Tue, 11 Oct 2022 20:32:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiLvk-0003Wj-CO; Tue, 11 Oct 2022 20:32:48 +0000
Received: by outflank-mailman (input) for mailman id 420479;
 Tue, 11 Oct 2022 20:32:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLvj-0003WZ-Bi; Tue, 11 Oct 2022 20:32:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLvj-0003V5-9O; Tue, 11 Oct 2022 20:32:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLvi-0007SU-TY; Tue, 11 Oct 2022 20:32:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiLvi-000852-T7; Tue, 11 Oct 2022 20:32:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pHzpv07ClwMb7L2q73ke8kGA3ZlXrKkKWh1rxEv4eAY=; b=dsv0/dp9jmKbLUZTkIFuOlNBuf
	xVFDN4LiigWvo611LlSrNXN9e5oIn2/VIPM9ojU7FfzGXz9D/939ejMMm80uj/KNWezfCbQGWCjbI
	U1qDb5DWTU9WwzUKzLV02w1Gb1BumV8QSku5j01w/uoQ3bEkc5oy28JHXlfPza0D9ouQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173501-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173501: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 20:32:46 +0000

flight 173501 xen-unstable-smoke real [real]
flight 173503 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173501/
http://logs.test-lab.xenproject.org/osstest/logs/173503/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    4 days
Testing same since   173492  2022-10-11 13:01:50 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 427 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 21:47:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 21:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420501.665358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiN5h-0003eY-3r; Tue, 11 Oct 2022 21:47:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420501.665358; Tue, 11 Oct 2022 21:47:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiN5h-0003eR-14; Tue, 11 Oct 2022 21:47:09 +0000
Received: by outflank-mailman (input) for mailman id 420501;
 Tue, 11 Oct 2022 21:47:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0qgQ=2M=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oiN5f-0003eL-Gw
 for xen-devel@lists.xenproject.org; Tue, 11 Oct 2022 21:47:07 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3e519d4f-49ae-11ed-8fd0-01056ac49cbb;
 Tue, 11 Oct 2022 23:47:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id E26AB612E8;
 Tue, 11 Oct 2022 21:47:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6C80C433C1;
 Tue, 11 Oct 2022 21:47:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e519d4f-49ae-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665524823;
	bh=CKa4NsoRTuQrE0ZnowDI8sJhAILN0d44//XO98OJQg8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=IudgEOlScCuSK5Elpr2t2ZwgjQ6jHbpjekrz2qGoHKzv5LR+uGVa1w3ffhGOC+2l6
	 Fm3SrUIwI75++RzJIlU7W0HBGAWTnsf1JUoRt3bGiI2v6DFTGKVsTmyNIJzyvQ9IYV
	 Bk/bwoQ89/s9b9P1+lMvgb9ZcwO5fMuNiK+GF6d/G3V46V2pS72+WoRzHoGhekW9Ul
	 nODv5n7wPiO3wHyuTY+0bwRgf8H8yTkop3wtDqWQDhonNfg5CxCvT4n+WPS61nK1oi
	 YCSbbcyjq7WOvXmaU+Aa43qU1oG2Ji4zO0zFWN8UO1SK9vNjxw60p3Zg7k+LOvQZ8/
	 m/eLPdkXdj31Q==
Date: Tue, 11 Oct 2022 14:47:00 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Leo Yan <leo.yan@linaro.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Xen Develop <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Mathieu Poirier <mathieu.poirier@linaro.org>, 
    Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>, 
    jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, 
    wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
Message-ID: <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop> <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 11 Oct 2022, Leo Yan wrote:
> > > The second question is how to mitigate the long latency when send data
> > > from DomU.  A possible solution is the Xen network forend driver copies
> > > skb into mediate (bounce) buffer, just like what does in Xen net
> > > backend driver with gnttab_batch_copy(), in this way the forend driver
> > > doesn't need to wait for backend driver response and directly return
> > > back.
> > 
> > About this, I am not super familiar with drivers/net/xen-netfront.c but
> > I take you are referring to xennet_tx_buf_gc? Is that the function that
> > is causing xennet_start_xmit to wait?
> 
> No.  We can take the whole flow in xen-netfront.c as:
> 
>   xennet_start_xmit()
>              ----------> notify Xen Dom0 to process skb
>              <---------  Dom0 copies skb and notify back to DomU
>   xennet_tx_buf_gc()
>   softirq/NET_TX : __kfree_skb()

Let me premise again that I am not an expert in PV netfront/netback.
However, I think the above is only true if DomU and Dom0 are running on
the same physical CPU. If you use sched=null as I suggested above,
you'll get domU and dom0 running at the same time on different physical
CPUs and the workflow doesn't work as described.

It should be:

CPU1: xennet_start_xmit()             ||  CPU2: doing something else
CPU1: notify Xen Dom0 to process skb  ||  CPU2: receive notification
CPU1: return from xennet_start_xmit() ||  CPU2: Dom0 copies skb
CPU1: do something else               ||  CPU2: notify back to DomU
CPU1: receive irq, xennet_tx_buf_gc() ||  CPU2: do something else


> > I didn't think that waiting for the backend is actually required. I
> > mean, in theory xennet_start_xmit could return without calling
> > xennet_tx_buf_gc, it is just an optimization. But I am not sure about
> > this.
> 
> The function xennet_start_xmit() will not wait and directly return
> back, but if we review the whole flow we can see the skb is freed until
> the softirq NET_TX.

Is it an issue that the skb is not freed until later? Is that affecting
the latency results? It shouldn't, right? What matters is when dom0 is
getting those packets on the physical network interface and that happens
before the skb is freed. I am just trying to figure out if we are
focusing on the right problem.


> In this whole flow, it needs DomU and Dom0 to work
> together (includes two context switches) to process skb.

There are not necessarily 2 context switches as things should run in
parallel.


> Here I mean the optimization is to allow Dom0 and DomU to work in
> parallel.  It could be something like blow, the key point is DomU
> doesn't need to wait for Dom0's notification.

I think it is already the case that domU doesn't need to wait for dom0's
notification? It is true that domU is waiting for dom0's notification to
free the skb but that shouldn't affect latency?


>        DomU                     |             Dom0
>   ------------------------------+-------------------------------
>   xennet_start_xmit()           |
>   copy skb in grant page        |
>   notify Xen Dom0               |
>                                 |  fetch skb from grant page
>   xennet_tx_buf_gc()            |  deliver skb to bridge
>     kfree_skb()                 |


From xen-devel-bounces@lists.xenproject.org Tue Oct 11 22:41:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 11 Oct 2022 22:41:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420510.665374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiNwe-00029v-9v; Tue, 11 Oct 2022 22:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420510.665374; Tue, 11 Oct 2022 22:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiNwe-00029o-7L; Tue, 11 Oct 2022 22:41:52 +0000
Received: by outflank-mailman (input) for mailman id 420510;
 Tue, 11 Oct 2022 22:41:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiNwd-00029e-20; Tue, 11 Oct 2022 22:41:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiNwc-0005xd-Ul; Tue, 11 Oct 2022 22:41:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiNwc-0007ib-G2; Tue, 11 Oct 2022 22:41:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiNwc-0004UX-FZ; Tue, 11 Oct 2022 22:41:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tOH1Cq9e5jgsfgS6lx4lMGIrAMhHBUSC30+jbVn+JKY=; b=bjabDIOBEcAX4UOk0dHIFQhNa1
	8Af6l5MLwAVZdqaCAPz0pXyzoOlGQKbFr+BQ9Whw0YZEuRa9UXEDg+jmyPU/n+Taysm6PAnO7oYNp
	jnUG2uPpnbtfcC2flQkZVwD5HL2vybtT/M5B770uKsPh8+beKArnIICoF7w88lzG/08Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173493-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173493: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 11 Oct 2022 22:41:50 +0000

flight 173493 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173493/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   54 days
Testing same since   173493  2022-10-11 13:07:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 00:15:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 00:15:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420523.665401 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiPPK-0004qv-29; Wed, 12 Oct 2022 00:15:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420523.665401; Wed, 12 Oct 2022 00:15:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiPPJ-0004qo-Vb; Wed, 12 Oct 2022 00:15:33 +0000
Received: by outflank-mailman (input) for mailman id 420523;
 Wed, 12 Oct 2022 00:15:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPPH-0004qe-Vz; Wed, 12 Oct 2022 00:15:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPPH-0008KM-RN; Wed, 12 Oct 2022 00:15:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPPH-0005NU-Eu; Wed, 12 Oct 2022 00:15:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPPH-0002CM-EN; Wed, 12 Oct 2022 00:15:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GAAfEBuO64Nkd+RmZ1E0B9RowuUJx0PxLLIKjV2Ig0Y=; b=DuOkHtl+NagNLgq6peTjrMSyXf
	MCcv+WunP1VLkKQaCULGJ1v8qoChHi28yvTntHEXKb25/38+jfBNM7fy3nFRXLPR15eLKmmtrPcbF
	R4vA3Em6SO/F12C/WAbPyNvaTkx35HHup0t3aV5VNscwEUl4rr2a7SOEDpDhXvoWlVhk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173496-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173496: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-pvhv2-intel:guest-localmigrate/x10:fail:regression
    xen-4.14-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.14-testing:build-arm64:xen-build:fail:regression
    xen-4.14-testing:build-armhf:xen-build:fail:regression
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.14-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6e5608d1c50e0f91ed3226489d9591c70fa37c30
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 00:15:31 +0000

flight 173496 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173496/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10 fail REGR. vs. 172550
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172550
 build-arm64                   6 xen-build                fail REGR. vs. 172550
 build-armhf                   6 xen-build                fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  6e5608d1c50e0f91ed3226489d9591c70fa37c30
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   57 days
Testing same since   173496  2022-10-11 14:08:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 436 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 00:47:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 00:47:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420539.665427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiPtf-0000bR-P2; Wed, 12 Oct 2022 00:46:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420539.665427; Wed, 12 Oct 2022 00:46:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiPtf-0000bK-Lg; Wed, 12 Oct 2022 00:46:55 +0000
Received: by outflank-mailman (input) for mailman id 420539;
 Wed, 12 Oct 2022 00:46:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPte-0000bA-J0; Wed, 12 Oct 2022 00:46:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPte-0000an-DX; Wed, 12 Oct 2022 00:46:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPte-0006gn-4U; Wed, 12 Oct 2022 00:46:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiPte-0006E7-44; Wed, 12 Oct 2022 00:46:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OyxfeS3GD+O4ihHCT6EbgyvRLtc7ivHFkEwL0WNp7BM=; b=pL27UIuSyMYfqy8n2zrjVDGiDw
	9MqAfM6Qn07phB2EXtbuxeal1uxCEvyeEo5p0WDXY2C3bpbRHEbpLUwDNG2mZII86XfFSo3+isY9i
	3t9HsdXqHKBEcRTFrmNDsX2eMYqSAxienGGq0+RNyrHroX6qXAMBr0XVPhJzu85ZZYyI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173498-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173498: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:build-arm64:xen-build:fail:regression
    xen-4.15-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64:xen-build:fail:regression
    xen-4.15-testing:build-armhf:xen-build:fail:regression
    xen-4.15-testing:build-i386:xen-build:fail:regression
    xen-4.15-testing:build-i386-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64-xsm:xen-build:fail:regression
    xen-4.15-testing:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-3:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-4:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-5:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    xen=9690bb261d5fa09cb281e1fa124d93db7b84fda5
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 00:46:54 +0000

flight 173498 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173498/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172547
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64                   6 xen-build                fail REGR. vs. 172547
 build-armhf                   6 xen-build                fail REGR. vs. 172547
 build-i386                    6 xen-build                fail REGR. vs. 172547
 build-i386-xsm                6 xen-build                fail REGR. vs. 172547
 build-amd64-xsm               6 xen-build                fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-amd64-coresched-amd64-xl  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-shadow    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-rtds      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ws16-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qemut-ws16-amd64  1 build-check(1)             blocked n/a
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qcow2     1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvshim    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-intel  1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-intel  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit2   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-amd64-livepatch    1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-intel  1 build-check(1)              blocked n/a
 test-amd64-amd64-migrupgrade  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pair         1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pygrub       1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-freebsd11-amd64  1 build-check(1)           blocked n/a
 test-amd64-amd64-qemuu-freebsd12-amd64  1 build-check(1)           blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-1        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-2        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-3        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-4        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-5        1 build-check(1)               blocked  n/a

version targeted for testing:
 xen                  9690bb261d5fa09cb281e1fa124d93db7b84fda5
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   57 days
Testing same since   173494  2022-10-11 13:38:08 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              fail    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64-xtf                                              pass    
 build-amd64                                                  fail    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       blocked 
 test-xtf-amd64-amd64-2                                       blocked 
 test-xtf-amd64-amd64-3                                       blocked 
 test-xtf-amd64-amd64-4                                       blocked 
 test-xtf-amd64-amd64-5                                       blocked 
 test-amd64-amd64-xl                                          blocked 
 test-amd64-coresched-amd64-xl                                blocked 
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        blocked 
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         blocked 
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      blocked 
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            blocked 
 test-amd64-amd64-xl-pvhv2-amd                                blocked 
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              blocked 
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       blocked 
 test-amd64-amd64-qemuu-freebsd12-amd64                       blocked 
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         blocked 
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         blocked 
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  blocked 
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  blocked 
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        blocked 
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          blocked 
 test-amd64-amd64-xl-pvhv2-intel                              blocked 
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   blocked 
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 blocked 
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                blocked 
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        blocked 
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   blocked 
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     blocked 
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   blocked 
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 689 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 00:59:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 00:59:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420547.665438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiQ5V-0002IP-S3; Wed, 12 Oct 2022 00:59:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420547.665438; Wed, 12 Oct 2022 00:59:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiQ5V-0002II-Oe; Wed, 12 Oct 2022 00:59:09 +0000
Received: by outflank-mailman (input) for mailman id 420547;
 Wed, 12 Oct 2022 00:59:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiQ5V-0002I6-4O; Wed, 12 Oct 2022 00:59:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiQ5V-0000m1-0B; Wed, 12 Oct 2022 00:59:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiQ5U-0007Pb-Nf; Wed, 12 Oct 2022 00:59:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiQ5U-0007EV-NA; Wed, 12 Oct 2022 00:59:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qeMqg92BWvwexbQTG3IuonhZ8adzuLnk4rcezB/FWAk=; b=OsutY0fJq+5D2RdozNwBRn7vOh
	1hhKgeWdJUQJ58Y6hdFUUJBgE04k9CcbTfs1jGxVK/AIKs3PLnTWPLKJaq1qjdf+VPUp9QKax/hxP
	A6oqkiFHxh+p3aUgQ5AITcTh/WDpMDldTb+RjC8pobfu1ZTX+FY4b0ZLLzBavsn7oCmE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173495-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173495: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.13-testing:build-arm64:xen-build:fail:regression
    xen-4.13-testing:test-amd64-amd64-xl-multivcpu:guest-localmigrate/x10:fail:regression
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-4.13-testing:build-armhf:xen-build:fail:regression
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=042de0843936b690acbc6dbcf57d26f6adccfc06
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 00:59:08 +0000

flight 173495 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173495/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172549
 build-arm64                   6 xen-build                fail REGR. vs. 172549
 test-amd64-amd64-xl-multivcpu 20 guest-localmigrate/x10  fail REGR. vs. 172549
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 172549
 build-armhf                   6 xen-build                fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  042de0843936b690acbc6dbcf57d26f6adccfc06
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   57 days
Testing same since   173495  2022-10-11 14:08:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 436 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 02:43:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 02:43:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420570.665488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiRi5-00050E-Uq; Wed, 12 Oct 2022 02:43:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420570.665488; Wed, 12 Oct 2022 02:43:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiRi5-000507-R2; Wed, 12 Oct 2022 02:43:05 +0000
Received: by outflank-mailman (input) for mailman id 420570;
 Wed, 12 Oct 2022 02:43:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiRi3-000501-Pp
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 02:43:04 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96583c13-49d7-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 04:43:01 +0200 (CEST)
Received: from DB6P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::12) by
 PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.19; Wed, 12 Oct 2022 02:42:58 +0000
Received: from DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:28:cafe::74) by DB6P191CA0002.outlook.office365.com
 (2603:10a6:6:28::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.39 via Frontend
 Transport; Wed, 12 Oct 2022 02:42:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT064.mail.protection.outlook.com (100.127.143.3) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 02:42:58 +0000
Received: ("Tessian outbound c2c2da38ad67:v128");
 Wed, 12 Oct 2022 02:42:58 +0000
Received: from 6ec5920f4f86.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8FEA14DA-62D4-40C8-A22C-FB663C14907A.1; 
 Wed, 12 Oct 2022 02:42:47 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6ec5920f4f86.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 02:42:47 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV1PR08MB7873.eurprd08.prod.outlook.com (2603:10a6:150:5c::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 02:42:45 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 02:42:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96583c13-49d7-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=oN/y5v/VJ0irccOs0ZrFrlqZ5Nf0kal8enjJLvhI7eLXxgsIw1/nL5z3x+G955PcDZOpmE+JSm9LexSmeecAvPf8FnW6vz5CgboT+TLjgphH49qPd3ltGkxnNRsDjG/PEJGjIGr08ZOdqKD/T+OzwpAGxWwwCCOy8y5Tg6geyn9Prfd2zOCxkmAeZbibZ6Q3X034zrQommz78DYAoJHsCzyMb6eZfd1dH2QSZDGXN4MyQt5HqkI1tE6kdn9rj/3EXywEeY5mq30ozVP+/cECREOWqJbV1jeOnx1lCBRsfeUuy+Ca9m+d+vRmjBaHhAHQE/xvN8GLaq357gzwWSBtJQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HlgJb5ET17a8iUSgNBzTl+zrSz74zEDEvzLC94XOolY=;
 b=VZmHg294RkuTs8emevGMPGCrxNZ8okKeXsCzD8HZq6ohqsbwX/FJ8WjMd7XdXbpjnGu1trlQ2H94xhfoFrwQ0laFcwxqTU/gyxJAIWPCb+1Wrq558qhbJcwLk8Exw7ZLpXQltswc0g2qO+Va6LvukRafncS+GL5w3uqrPJh92IyhG0RnqXguW/1viOWypO2Wenmu9Zr0A4wo3smMvb34pZUGHjpOyZk92dqC9eGnwu/EsYvvFrG5KqWiE8gxSG7JgwaDFFN6Vo61OPYP3yGMnzwUPcvZ3BzQ67tOs9/qWl3fmAYxW7Asc+8pbpK9ipcfXDBJyLbC5QfRAugXB0Pxxg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HlgJb5ET17a8iUSgNBzTl+zrSz74zEDEvzLC94XOolY=;
 b=l7/lUcXpjQaePxQG42EZudD1bETvh+WtH+ZfUKPPoyqOVi2lV/jwdP3XRzkDnv6CLJRurJYMAnfdb5A/AJcqiCTXMGQzxwjcH+YLJGaDvWqoN29IzZ5iPM6fe7JAP2yjyrqpBn79UnwJsrLb8e1ydgtKa02ukeSb0xHe+3FyHYo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QO8POneQa8U9IU9hIPkURH+3FZmvLVi7j/ptgOfe0eCXRvJdlWBKKOtC4yXKzEGE4D6HxaIWeV54v7IZ/n9b6DRkDVHjhh4JSpO64Mk9QNPpaKY3Gxyz9L6YsV76rypUJ06Hth02vaD1Z16SYpwLO/sAKThM5kwYfbb9JYNe6VytjZJxxYGllbkVlKZfwuWM1N7WL6+qFL1zbhKAT/B+RuqnD0CcRQ5mqlayZSnPljHmtNotfxAyzF1cbVU5o37Az9E2nqPngn+6jma2qsAS7YXbNGpIS23XHAAegCuqaBqPGes7jJ+Vp6aK+WbbpO19kSh3xHU8K7WSEKJHST1aDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HlgJb5ET17a8iUSgNBzTl+zrSz74zEDEvzLC94XOolY=;
 b=UKk4qCaVeFHg0YzMX5U+hPTyYMsE0cgJJNRKc5O9+QvTF/BtvarklaG7r2oKv3U2ZmP8O3Q78jGrdShvak3ScxD3S8aUghiLjkPMy5m5R2XrHQZuPDzaYDSuL217Li7qcGvCZxs1t13o2L1+N/eKM8sAcPjlw4E5jjEghEwuoKxtQTvNR/zG8ulcwVKEpiCXlaHyR4pYU/dURmMDF6YWFz66C1NC/RysnOsAB52dx0t2kApCXsuvc/mSUX7GubV+7mDPofyKFU8I1yQxpoVkaoUcLizzesmMvhi6OSFxeihN08R2AQgwoKv19eIzQJH98hdMUHrdHUYJGwtKykKxxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HlgJb5ET17a8iUSgNBzTl+zrSz74zEDEvzLC94XOolY=;
 b=l7/lUcXpjQaePxQG42EZudD1bETvh+WtH+ZfUKPPoyqOVi2lV/jwdP3XRzkDnv6CLJRurJYMAnfdb5A/AJcqiCTXMGQzxwjcH+YLJGaDvWqoN29IzZ5iPM6fe7JAP2yjyrqpBn79UnwJsrLb8e1ydgtKa02ukeSb0xHe+3FyHYo=
From: Henry Wang <Henry.Wang@arm.com>
To: osstest service owner <osstest-admin@xenproject.org>
CC: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>, Juergen
 Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>
Subject: RE: [xen-4.15-testing test] 173498: regressions - FAIL
Thread-Topic: [xen-4.15-testing test] 173498: regressions - FAIL
Thread-Index: AQHY3dQtFH1xMEjYXEqV6So1jL4Dp64KChlg
Date: Wed, 12 Oct 2022 02:42:45 +0000
Message-ID:
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <osstest-173498-mainreport@xen.org>
In-Reply-To: <osstest-173498-mainreport@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 0A67F89B394319418F48E0141025EEE2.1
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV1PR08MB7873:EE_|DBAEUR03FT064:EE_|PA4PR08MB6253:EE_
X-MS-Office365-Filtering-Correlation-Id: be737cb8-418c-4df2-c141-08daabfb78fa
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KEtL/BoLVAFmaYgyAHe3Qqv0fusZjmFnaVpzPLZak0f/ItJrqsgwAO37DwHm+/DOC32LYre6RMvAbmVbkHYhy+/9AMDiL/a1bHH4RHQ7ieggBnuwWdvTVavP4o61JuiTKcIFtq6WW7nHATrquhc8jH2S5S8hNr6FSWgi20sIqalDbhrOJq2pX1i6sQ29enRZchRE/F1z3PcvL1WEibfg48K36RvoVPjIedlNkWK23/9uETgSCDcn8u1bkmeNyl/aQyFxWcE2tqkZsHYoTD72r6AS7OX2dY5JLEH0dNFm9raJNqUHgqFUiGu2hQ6Qp6Bg3JBVPbhgEItIUcZWh0SqV2zMjsYxFv0uY/brSFr6nOPlhtageHslrivW20f8UmAkFpu4QoeGgUqL1pOTAlt3udF+Fvnj7XCfb5dO4OQCDPD29Ki2ny6ONfX+70Z9w+ff5D3AWouxJEM6zCre3PSy+m62KPDqhez0kKzrSFmOiKxtj3KTdgoFiHhxuOg+glzDJ5si+qRSkBSLhGtpq5h93e+hjWhobMqj7KLr8XoSYk+Qla9INJS2pZ38nPlfNdf03w6u8hI7Z0UPfsgX6vYcZlopqK7n36ceqHX9374yyymx1dkPH9FlTCU+8qt1ZroSgtBziHWBcLV9eiYMc6+89oJAGg6TvRbEi0uefzvWOXsbvgARz4N0Go7NudclFLIK3QIBaAO8QGMbYQ/ygYYjI9VgYimGCBey/ZNVnnzKxDk7dF8zbjuODaNDaA0bmfQ4pS6Csee2FaNk1CXK0BsKFnmoG6gufFjRXYbvNOHIXBU=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(54906003)(52536014)(8936002)(41300700001)(478600001)(966005)(5660300002)(33656002)(76116006)(64756008)(316002)(4326008)(6916009)(66476007)(66446008)(66946007)(66556008)(8676002)(86362001)(38070700005)(122000001)(186003)(38100700002)(55016003)(26005)(9686003)(71200400001)(7696005)(6506007)(83380400001)(2906002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7873
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d0d741bf-5143-4ce9-d114-08daabfb714b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yc03UeQE+yRPg2T+Ha/tFjRy6hm3xn9CjlOl23AWdS/V4ETDa+obF9xpxcjYMwFBjKt7VYEywvZVhllEdJeR8vMtpM+2dZ8Nvq84R62SgCFElR0ybTbO1MHnLLh1oBP2RBzv0rXHZVCZCPGl3APMUldShVzZ4K7grRP1MddsqrVtK0Vcv3XRz/gu2L+iHZnvjfH/iDshiDED8e+NJC2xET50xaVWVV+TY8EVngd/48RsRbtL3IKR53NjdPyn5X3Er0qN+FXkQegisbb2PInPh5ywvF6z3AGp+qt2lp+KwUj/kXWQaafEygT1Rk37HQ/+O25uvPlnecAc+ychbqkCwryj7+WQR5/PcQfdOESRiQH5Vr+/YTC2V3rU23uGs9wdu3ePAdN8U/t73u9Ugt+Ww8qKrBk6SvwTroS6Whp9d2scXyTeAI+79QhHcP4sNiWS3nGxTJAbGZee//PNVpRp38XJRpT05vXEq6mJOi1alrWa2H1thgGuDxGs+ggdfSj2r7YdSsQj0pC+j3cjwSK5q5v23oy671Bvh/1GToelgzt5HR22Oy8zEcOgsDRfxN68TSgqnxGCwC37tVxFAHfkRF5PZq2hiryhI8ZawnFKYgjVCpsJrhmi/IVkHRPwVDYLhylcT0HeYjWy9GSpenFOaaVnVvQk2ewuihQa7FyI3IX/0UUx3sSlKAgeIWExJClO7NhNbsb+0lPKbRvITPaRIPYKeZAEyfIByhlXQ2VGpNCBZNIUdwS7FFY6s0Hg5GF5tWB4HxXeTYc3/86CKK4PmFSq24CvWVPqNCvqplr/sj0=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(40460700003)(966005)(47076005)(478600001)(9686003)(7696005)(6506007)(26005)(2906002)(107886003)(6862004)(8936002)(82310400005)(81166007)(82740400003)(356005)(40480700001)(33656002)(55016003)(70206006)(316002)(5660300002)(36860700001)(52536014)(4326008)(41300700001)(86362001)(54906003)(70586007)(8676002)(186003)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 02:42:58.1186
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: be737cb8-418c-4df2-c141-08daabfb78fa
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6253

SGkgYWxsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFt4ZW4t
NC4xNS10ZXN0aW5nIHRlc3RdIDE3MzQ5ODogcmVncmVzc2lvbnMgLSBGQUlMDQo+IA0KPiBmbGln
aHQgMTczNDk4IHhlbi00LjE1LXRlc3RpbmcgcmVhbCBbcmVhbF0NCj4gaHR0cDovL2xvZ3MudGVz
dC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3MzQ5OC8NCj4gDQo+IFJlZ3Jlc3Np
b25zIDotKA0KDQpJIHRoaW5rIHRoZXNlIHJlZ3Jlc3Npb25zIGFyZSBmcm9tIHRoZSBiYWNrcG9y
dGluZyBoYXBwZW5lZCB5ZXN0ZXJkYXksDQpzZWUgYmVsb3cuLi4NCg0KPiANCj4gVGVzdHMgd2hp
Y2ggZGlkIG5vdCBzdWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcsDQo+IGluY2x1ZGluZyB0ZXN0cyB3
aGljaCBjb3VsZCBub3QgYmUgcnVuOg0KPiAgYnVpbGQtYXJtNjQgICAgICAgICAgICAgICAgICAg
NiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcyNTQ3DQo+ICBidWls
ZC1hcm02NC14c20gICAgICAgICAgICAgICA2IHhlbi1idWlsZCAgICAgICAgICAgICAgICBmYWls
IFJFR1IuIHZzLiAxNzI1NDcNCj4gIGJ1aWxkLWFtZDY0ICAgICAgICAgICAgICAgICAgIDYgeGVu
LWJ1aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3MjU0Nw0KPiAgYnVpbGQtYXJt
aGYgICAgICAgICAgICAgICAgICAgNiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdS
LiB2cy4gMTcyNTQ3DQoNCi4uLlRoZSBhcm0vYXJtNjQgcmVncmVzc2lvbiBpcyBmcm9tIHRoZSBi
YWNrcG9ydGluZyBvZiBjb21taXQ6DQp4ZW4vYXJtLCBsaWJ4bDogSW1wbGVtZW50IFhFTl9ET01D
VExfc2hhZG93X29wIGZvciBBcm0NCg0KVGhlIGlzc3VlIGlzOg0KSW4gNC4xNiwgY29tbWl0DQoy
MTA3Y2M3NmRiM2EgbGlieGM6IHNwbGl0IHhjX2xvZ2RpcnR5X2NvbnRyb2woKSBmcm9tIHhjX3No
YWRvd19jb250cm9sKCkNCmNoYW5nZXMgdGhlIHByb3RvdHlwZSBvZiB4Y19zaGFkb3dfY29udHJv
bCgpLCBhbmQgaGVuY2UgdGhlIGNhbGxpbmcgb2YNCnhjX3NoYWRvd19jb250cm9sKCkgaW4gNC4x
MywgNC4xNCBhbmQgNC4xNSBkb2VzIG5vdCBtYXRjaCB0aGUgY2FsbGluZyBvZg0KeGNfc2hhZG93
X2NvbnRyb2woKSBpbiA0LjE2IGFuZCBhZnRlci4NCg0KPiAgYnVpbGQtaTM4NiAgICAgICAgICAg
ICAgICAgICAgNiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcyNTQ3
DQo+ICBidWlsZC1pMzg2LXhzbSAgICAgICAgICAgICAgICA2IHhlbi1idWlsZCAgICAgICAgICAg
ICAgICBmYWlsIFJFR1IuIHZzLiAxNzI1NDcNCj4gIGJ1aWxkLWFtZDY0LXhzbSAgICAgICAgICAg
ICAgIDYgeGVuLWJ1aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3MjU0Nw0KDQpJ
IHRoaW5rIHRoZSB4ODYgcmVncmVzc2lvbiBpcyBmcm9tIHRoZSBiYWNrcG9ydGluZyBvZiBjb21t
aXQ6DQp4ZW4vZ250dGFiOiBmaXggZ250dGFiX2FjcXVpcmVfcmVzb3VyY2UoKQ0KDQpBcyB0aGUg
ZXJyb3IgbWVzc2FnZSBpczoNCm1ha2VbNV06IEVudGVyaW5nIGRpcmVjdG9yeSAnL2hvbWUvb3Nz
dGVzdC9idWlsZC4xNzM0OTguYnVpbGQtYW1kNjQveGVuL3Rvb2xzL3Rlc3RzL3Jlc291cmNlJw0K
dGVzdC1yZXNvdXJjZS5jOiBJbiBmdW5jdGlvbiAndGVzdF9nbnR0YWInOg0KdGVzdC1yZXNvdXJj
ZS5jOjc0OjE5OiBlcnJvcjogJ2dudHRhYicgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMg
ZnVuY3Rpb24pDQogICAgICAgICAodm9pZCAqKikmZ250dGFiLCBQUk9UX1JFQUQgfCBQUk9UX1dS
SVRFLCAwKTsNCiAgICAgICAgICAgICAgICAgICBefn5+fn4NCg0KS2luZCByZWdhcmRzLA0KSGVu
cnkNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 03:16:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 03:16:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420584.665523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiSEZ-0000lJ-NI; Wed, 12 Oct 2022 03:16:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420584.665523; Wed, 12 Oct 2022 03:16:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiSEZ-0000lC-JT; Wed, 12 Oct 2022 03:16:39 +0000
Received: by outflank-mailman (input) for mailman id 420584;
 Wed, 12 Oct 2022 03:16:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSEY-0000l2-S3; Wed, 12 Oct 2022 03:16:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSEY-0002Jh-J6; Wed, 12 Oct 2022 03:16:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSEY-0006aQ-8w; Wed, 12 Oct 2022 03:16:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSEY-000523-8U; Wed, 12 Oct 2022 03:16:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uW2Qp09ZZqQ1F7Q6Jv1iieBPL/vpkSGYzBX24iF6nsQ=; b=wmmees3AAOkAcsS49SgAFF1lOi
	16XQJe2IZoFLYbwxT8wG0p2YgD4miiqeH+BW3EK49Zai0beg3U9sXOrn1v9Mi/l0b9PYxoBLehRpF
	vAk6CP8EJKUQwFrAHFl26hRucQ1Yq4Ijn1fgiYY66GfQbbe2PCIvYI2KxCY7B1tFjrw8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173497-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173497: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-arm64-pvops:kernel-build:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=42e1e350bffc8d4614e568a03380b2ec34a131bf
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 03:16:38 +0000

flight 173497 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173497/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 173447
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 173447

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                42e1e350bffc8d4614e568a03380b2ec34a131bf
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z    5 days
Testing same since   173497  2022-10-11 15:38:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Hildenbrand <david@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 42e1e350bffc8d4614e568a03380b2ec34a131bf
Merge: f1d33f55c4 94d788408d
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Tue Oct 11 09:31:19 2022 -0400

    Merge tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging
    
    dump patches
    
    Hi
    
    Includes:
    - the first patches from "[PATCH v5 00/18] dump: Add arch section and s390x PV dump"
    - "[PATCH v2 0/2] Fix dumping in kdump format with non-aligned memory"
    
    # -----BEGIN PGP SIGNATURE-----
    #
    # iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmM+9UocHG1hcmNhbmRy
    # ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5aoMD/0eya5IqxX0ke9jjUcB
    # wWhRbsVdiO9yt2oN3gsQVkUtuK98p7/JpWSKHWXsQQjd7vIYPCj8RBHXZ4Cp71+S
    # n+Db/K22fmWvuP0LtCNzYujq1ZxKdQI8KdKmYwHQdGkgy85QwYO+0SgpVgLjRd/2
    # 1IWzHuzIcEmraxkSLvR8N0lmz/Z2CBc7ME5izO1mHSZrs8Ria2tDpXnz5rFxPy+q
    # TDqo+LP0GIapoHbbE+6JWGL2u9mLiP0sg9SclZOPZG3CsPQ5XYEStyZcLw1YYIO1
    # rruom463SbP4NJHIRspC8pADFI+d4uBamj/eUu8/9CUVqetk0UpKyXWiqgEDvmkO
    # /2/yFYS60gEghvd3XVnuZnTNeRSDSE1aUXUmKdGqDjYL4DYcsehIQ9z8ut/tuYIO
    # D+4RuiuCmEyznV/DDecnwHhrv9jWftNwdwjW5GAniEjDBp/DtoouAeMArQw9rE1Z
    # mXqTa5NaeW69VTtzxzN25GzSAjiEzFT7UFRt3bT8fb0NX+UOkluD/agBqRIM5lzh
    # KbUJjqWhqA6TnHtDekbNLlmocDCn+NeBeXxDUIa19C4LICCuuxbFU+MG7cvdjSEg
    # sXRB6/qAdWgv4O3zGw1SHff+qmvtHjKVj0ihrNkrrYrL+31O2splqTMeaCqGdq9C
    # elE/TAS46CcMUSYuWzxy6mAMmA==
    # =O9tr
    # -----END PGP SIGNATURE-----
    # gpg: Signature made Thu 06 Oct 2022 11:33:30 EDT
    # gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
    # gpg:                issuer "marcandre.lureau@redhat.com"
    # gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" [full]
    # gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" [full]
    # Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5
    
    * tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu:
      dump: fix kdump to work over non-aligned blocks
      dump: simplify a bit kdump get_next_page()
      dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note
      dump: Split elf header functions into prepare and write
      dump: Rework dump_calculate_size function
      dump: Rework filter area variables
      dump: Rework get_start_block
      dump: Refactor dump_iterate and introduce dump_filter_memblock_*()
      dump: Rename write_elf_loads to write_elf_phdr_loads
      dump: Replace opaque DumpState pointer with a typed one
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

commit 94d788408d2d5a6474c99b2c9cf06913b9db7c58
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Mon Sep 5 16:06:21 2022 +0400

    dump: fix kdump to work over non-aligned blocks
    
    Rewrite get_next_page() to work over non-aligned blocks. When it
    encounters non aligned addresses, it will try to fill a page provided by
    the caller.
    
    This solves a kdump crash with "tpm-crb-cmd" RAM memory region,
    qemu-kvm: ../dump/dump.c:1162: _Bool get_next_page(GuestPhysBlock **,
    uint64_t *, uint8_t **, DumpState *): Assertion `(block->target_start &
    ~target_page_mask) == 0' failed.
    
    because:
    guest_phys_block_add_section: target_start=00000000fed40080 target_end=00000000fed41000: added (count: 4)
    
    Fixes:
    https://bugzilla.redhat.com/show_bug.cgi?id=2120480
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Acked-by: David Hildenbrand <david@redhat.com>

commit 08df343874fcddd260021a04ce3c5a34f2c48164
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Thu Aug 25 12:40:12 2022 +0400

    dump: simplify a bit kdump get_next_page()
    
    This should be functionally equivalent, but slightly easier to read,
    with simplified paths and checks at the end of the function.
    
    The following patch is a major rewrite to get rid of the assert().
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: David Hildenbrand <david@redhat.com>

commit 2341a94d3a0a8a93a5a977e642da1807b8edaab8
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:11:01 2022 +0000

    dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note
    
    The functions in question do not actually write to the file descriptor
    they set up a buffer which is later written to the fd.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-9-frankja@linux.ibm.com>

commit 670e76998a61ca171200fcded3865b294a2d1243
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:11:00 2022 +0000

    dump: Split elf header functions into prepare and write
    
    Let's split the write from the modification of the elf header so we
    can consolidate the write of the data in one function.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-8-frankja@linux.ibm.com>

commit c370d5300f9ac1f90f8158082d22262b904fe30e
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:59 2022 +0000

    dump: Rework dump_calculate_size function
    
    dump_calculate_size() sums up all the sizes of the guest memory
    blocks. Since we already have a function that calculates the size of a
    single memory block (dump_get_memblock_size()) we can simply iterate
    over the blocks and use the function instead of calculating the size
    ourselves.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Message-Id: <20220811121111.9878-7-frankja@linux.ibm.com>

commit dddf725f70bfe7f5adb41fa31dbd06e767271bda
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:58 2022 +0000

    dump: Rework filter area variables
    
    While the DumpState begin and length variables directly mirror the API
    variable names they are not very descriptive. So let's add a
    "filter_area_" prefix and make has_filter a function checking length > 0.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-6-frankja@linux.ibm.com>

commit 0c2994ac9009577b967529ce18e269da5b280351
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:57 2022 +0000

    dump: Rework get_start_block
    
    get_start_block() returns the start address of the first memory block
    or -1.
    
    With the GuestPhysBlock iterator conversion we don't need to set the
    start address and can therefore remove that code and the "start"
    DumpState struct member. The only functionality left is the validation
    of the start block so it only makes sense to re-name the function to
    validate_start_block()
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Message-Id: <20220811121111.9878-5-frankja@linux.ibm.com>

commit 1e8113032f5b1efc5da66382470ce4809c76f8f2
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:56 2022 +0000

    dump: Refactor dump_iterate and introduce dump_filter_memblock_*()
    
    The iteration over the memblocks in dump_iterate() is hard to
    understand so it's about time to clean it up. Instead of manually
    grabbing the next memblock we can use QTAILQ_FOREACH to iterate over
    all memblocks.
    
    Additionally we move the calculation of the offset and length out by
    introducing and using the dump_filter_memblock_*() functions. These
    functions will later be used to cleanup other parts of dump.c.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-4-frankja@linux.ibm.com>

commit afae6056ea79e2d89fd90867de3a01732eae724f
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:55 2022 +0000

    dump: Rename write_elf_loads to write_elf_phdr_loads
    
    Let's make it a bit clearer that we write the program headers of the
    PT_LOAD type.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Steffen Eiden <seiden@ibm.linux.com>
    Message-Id: <20220811121111.9878-3-frankja@linux.ibm.com>

commit 1af0006ab959864dfa2f59e9136c5fb93000b61f
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:54 2022 +0000

    dump: Replace opaque DumpState pointer with a typed one
    
    It's always better to convey the type of a pointer if at all
    possible. So let's add the DumpState typedef to typedefs.h and move
    the dump note functions from the opaque pointers to DumpState
    pointers.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    CC: Peter Maydell <peter.maydell@linaro.org>
    CC: Cédric Le Goater <clg@kaod.org>
    CC: Daniel Henrique Barboza <danielhb413@gmail.com>
    CC: David Gibson <david@gibson.dropbear.id.au>
    CC: Greg Kurz <groug@kaod.org>
    CC: Palmer Dabbelt <palmer@dabbelt.com>
    CC: Alistair Francis <alistair.francis@wdc.com>
    CC: Bin Meng <bin.meng@windriver.com>
    CC: Cornelia Huck <cohuck@redhat.com>
    CC: Thomas Huth <thuth@redhat.com>
    CC: Richard Henderson <richard.henderson@linaro.org>
    CC: David Hildenbrand <david@redhat.com>
    Acked-by: Daniel Henrique Barboza <danielhb413@gmail.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-2-frankja@linux.ibm.com>


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 03:34:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 03:34:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420596.665543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiSVj-0003P6-Ft; Wed, 12 Oct 2022 03:34:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420596.665543; Wed, 12 Oct 2022 03:34:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiSVj-0003Oz-CJ; Wed, 12 Oct 2022 03:34:23 +0000
Received: by outflank-mailman (input) for mailman id 420596;
 Wed, 12 Oct 2022 03:34:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSVh-0003Op-Rl; Wed, 12 Oct 2022 03:34:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSVh-0002av-PX; Wed, 12 Oct 2022 03:34:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSVh-0007hF-Eb; Wed, 12 Oct 2022 03:34:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiSVh-0005Og-Dq; Wed, 12 Oct 2022 03:34:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XOnFvFzNs2HV+VCZymiuAP3owamDb6ueM4NP7iEKa3M=; b=zcbTp12RkKL7G+53qavNXqw6Cp
	UJArLbRA6h5oMBbAVY6LLiUy/7fHH7CcAQanlxgVfYNQh6F50SemTpQYkfPDNUz8AxhB5gipE98bp
	jPPXnjmfP4OBi1Iv3pbup7FaudvG2NsjT3VKuxG6hk5W/h9EJVAkG7LOeJ6baB9Hi0yM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173506-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173506: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 03:34:21 +0000

flight 173506 xen-unstable-smoke real [real]
flight 173523 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173506/
http://logs.test-lab.xenproject.org/osstest/logs/173523/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    4 days
Testing same since   173492  2022-10-11 13:01:50 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 427 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 05:29:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 05:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420688.665616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiUIb-0002DG-QN; Wed, 12 Oct 2022 05:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420688.665616; Wed, 12 Oct 2022 05:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiUIb-0002D9-Nq; Wed, 12 Oct 2022 05:28:57 +0000
Received: by outflank-mailman (input) for mailman id 420688;
 Wed, 12 Oct 2022 05:28:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiUIa-0002Cz-Al; Wed, 12 Oct 2022 05:28:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiUIa-00052d-7F; Wed, 12 Oct 2022 05:28:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiUIZ-0006dE-O5; Wed, 12 Oct 2022 05:28:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiUIZ-0004vQ-Nd; Wed, 12 Oct 2022 05:28:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=F0OygkzzGAySaKVvaG3YIJEi9HaoOeEZ+rKiGPPYuKA=; b=cSYSSHP4OwoxK2KAu52Mv4zqtk
	49Put2+YAbWeKa/d3cD+L6Yc9PZvmZGO3A6g1Bsa225EyxIAPAACfjjOVHjo7ZsScHlrJjof1apcD
	TsNYRU12UNnf94f5UOQumtHT6aqWoVjUpWSLlOd+CwiVLkiJmDsX2Qt+7lg/7Tgv5izw=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.15-testing bisection] complete build-arm64
Message-Id: <E1oiUIZ-0004vQ-Nd@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 05:28:55 +0000

branch xen-4.15-testing
xenbranch xen-4.15-testing
job build-arm64
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  c5215044578e88b401a1296ed6302df05c113c5f
  Bug not present: 45336d8f88725aec65ee177b1b09abf6eef1dc8d
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173543/


  commit c5215044578e88b401a1296ed6302df05c113c5f
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:10:16 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.15-testing/build-arm64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.15-testing/build-arm64.xen-build --summary-out=tmp/173543.bisection-summary --basis-template=172547 --blessings=real,real-bisect,real-retry xen-4.15-testing build-arm64 xen-build
Searching for failure / basis pass:
 173498 fail [host=laxton1] / 172547 ok.
Failure / basis pass flights: 173498 / 172547
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
Basis pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#444260d45ec2a84e8f8c192b3539a3cd5591d009-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#6503bd6a1b5364ffd346a8a475e1eb91b9f756e5-6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#9acedc3c58c31930737edbe212f2ccf437a0b757-9690bb261d5fa\
 09cb281e1fa124d93db7b84fda5
Loaded 10001 nodes in revision graph
Searching for test results:
 172547 pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173494 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173499 pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173507 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173508 pass e8a537d28d37c092bd03093064264071f2938ca8 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173509 pass 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173512 pass a670f12a741a9511d9cedc7257d3693567f8fc43 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173513 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 686c920fa9389fe2b6b619643024ed98b4b7d51f
 173515 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 7923ea47e578bca30a6e45951a9da09e827ff028
 173498 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173516 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
 173524 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 0c0680d6e7953ca4c91699e60060c732f9ead5c1
 173526 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
 173531 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
 173532 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
 173533 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
 173539 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
 173543 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
Searching for interesting versions
 Result found: flight 172547 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d, results HASH(0x561c46b799c0) HASH(0x561c46b7de50) HASH(0x561c46b80c00) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 0c0680d6e7953ca4c91699e60060c732f9ead5c1, results \
 HASH(0x561c46b779b8) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 686c920fa9389fe2b6b619643024ed98b4b7d51f, results HASH(0x561c46b60658) For basis failure, parent search stopping at a670f12a741a9511d9cedc7257d3693567f8fc43 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x561c46b61580) F\
 or basis failure, parent search stopping at 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x561c46b5e350) For basis failure, parent search stopping at e8a537d28d37c092bd03093064264071f2938ca8 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x561c46b56008) For basis failure, pare\
 nt search stopping at 444260d45ec2a84e8f8c192b3539a3cd5591d009 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x561c46b42748) HASH(0x561c46b54600) Result found: flight 173494 (fail), for basis failure (at ancestor ~746)
 Repro found: flight 173499 (pass), for basis pass
 Repro found: flight 173507 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
No revisions left to test, checking graph state.
 Result found: flight 173526 (pass), for last pass
 Result found: flight 173531 (fail), for first failure
 Repro found: flight 173532 (pass), for last pass
 Repro found: flight 173533 (fail), for first failure
 Repro found: flight 173539 (pass), for last pass
 Repro found: flight 173543 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  c5215044578e88b401a1296ed6302df05c113c5f
  Bug not present: 45336d8f88725aec65ee177b1b09abf6eef1dc8d
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173543/


  commit c5215044578e88b401a1296ed6302df05c113c5f
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:10:16 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200

pnmtopng: 152 colors found
Revision graph left in /home/logs/results/bisect/xen-4.15-testing/build-arm64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173543: tolerable ALL FAIL

flight 173543 xen-4.15-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173543/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-arm64                   6 xen-build               fail baseline untested


jobs:
 build-arm64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 05:38:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 05:38:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420699.665637 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiURp-0003wc-SB; Wed, 12 Oct 2022 05:38:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420699.665637; Wed, 12 Oct 2022 05:38:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiURp-0003wV-Oo; Wed, 12 Oct 2022 05:38:29 +0000
Received: by outflank-mailman (input) for mailman id 420699;
 Wed, 12 Oct 2022 05:38:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiURo-0003w5-1h; Wed, 12 Oct 2022 05:38:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiURn-0005Cm-UC; Wed, 12 Oct 2022 05:38:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiURn-0007De-Ie; Wed, 12 Oct 2022 05:38:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiURn-0006Zj-IB; Wed, 12 Oct 2022 05:38:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Knr+Jd/Tbnj8QilpArDQgdBcBMv27ZWuJgnpqwViK8k=; b=t4t8op7uFcN+CHRRk8RrDo3FJ2
	V82rhpdNJX4F7sPdJztM9kRKYktFocIFG1GGVZz5s0rBDYKvq/wSgmJVQQwB4Gry/MD4Y+BQAZPHb
	tVFlCDEOY4TQz+WhSpSW2ZAW5HjbH4QqpVYRtJO2C+OXYUL6gCGxW126zaba8CUI8BKo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173522-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173522: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:build-arm64:xen-build:fail:regression
    xen-4.15-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64:xen-build:fail:regression
    xen-4.15-testing:build-i386-xsm:xen-build:fail:regression
    xen-4.15-testing:build-i386:xen-build:fail:regression
    xen-4.15-testing:build-armhf:xen-build:fail:regression
    xen-4.15-testing:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-3:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-4:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-5:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    xen=9690bb261d5fa09cb281e1fa124d93db7b84fda5
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 05:38:27 +0000

flight 173522 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173522/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172547
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64                   6 xen-build                fail REGR. vs. 172547
 build-i386-xsm                6 xen-build                fail REGR. vs. 172547
 build-i386                    6 xen-build                fail REGR. vs. 172547
 build-armhf                   6 xen-build                fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-amd64-coresched-amd64-xl  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-shadow    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-rtds      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ws16-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qemut-ws16-amd64  1 build-check(1)             blocked n/a
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qcow2     1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvshim    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-intel  1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-intel  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit2   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-amd64-livepatch    1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-intel  1 build-check(1)              blocked n/a
 test-amd64-amd64-migrupgrade  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pair         1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pygrub       1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-freebsd11-amd64  1 build-check(1)           blocked n/a
 test-amd64-amd64-qemuu-freebsd12-amd64  1 build-check(1)           blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-1        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-2        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-3        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-4        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-5        1 build-check(1)               blocked  n/a

version targeted for testing:
 xen                  9690bb261d5fa09cb281e1fa124d93db7b84fda5
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   57 days
Testing same since   173494  2022-10-11 13:38:08 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              fail    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64-xtf                                              pass    
 build-amd64                                                  fail    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       blocked 
 test-xtf-amd64-amd64-2                                       blocked 
 test-xtf-amd64-amd64-3                                       blocked 
 test-xtf-amd64-amd64-4                                       blocked 
 test-xtf-amd64-amd64-5                                       blocked 
 test-amd64-amd64-xl                                          blocked 
 test-amd64-coresched-amd64-xl                                blocked 
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        blocked 
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         blocked 
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      blocked 
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            blocked 
 test-amd64-amd64-xl-pvhv2-amd                                blocked 
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              blocked 
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       blocked 
 test-amd64-amd64-qemuu-freebsd12-amd64                       blocked 
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         blocked 
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         blocked 
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  blocked 
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  blocked 
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        blocked 
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          blocked 
 test-amd64-amd64-xl-pvhv2-intel                              blocked 
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   blocked 
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 blocked 
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                blocked 
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        blocked 
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   blocked 
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     blocked 
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   blocked 
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 689 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:19:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:19:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420722.665689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiV5l-0000mI-I4; Wed, 12 Oct 2022 06:19:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420722.665689; Wed, 12 Oct 2022 06:19:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiV5l-0000mB-FO; Wed, 12 Oct 2022 06:19:45 +0000
Received: by outflank-mailman (input) for mailman id 420722;
 Wed, 12 Oct 2022 06:19:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiV5k-0000m5-Gb
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:19:44 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00048.outbound.protection.outlook.com [40.107.0.48])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dc0688b6-49f5-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:19:43 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PR3PR04MB7289.eurprd04.prod.outlook.com (2603:10a6:102:8a::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 06:19:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:19:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc0688b6-49f5-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nWNHtTTpJW4wlIRFKPIqCv+4M6vRkMelQCewCg8cwmJfbLh5GoUNmn38SLGHwOngg4diHxQcm7C8GE1roRPr5n/lZImJtEK4KLs2LN7WGmvYwtn55HvOnxyh0AaJ2Lsq8dGwgHrjbZ29XB0HPytLKHmIFDJ7wH68nI4LkPocYqQv9FzYXQ7nK3jwCwWzb/wzcko5ys00GBk8i5JafRUf8k9YapdpDUKtJAD0vOY22Baz6ZohSiK++xp6Ho8zEKwwh+jFeW/yIYn5WPP3tuef04GL2adrbXrgneaqazbklKM+33yqwp3Qz7sFFx5uwa5n5HThEtmZ1rlOVwFE8s7Vuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GoYfSbVMVBfFTdAfTBzG6lRq8XVvK8vP78Mm2MvdZ2w=;
 b=QfixR0YjQt75TdshC5hx/80tiMoOrmUlA+rytShNsxYCMJ5GKmxtOTQUwcxL8foCTXOlI56gD4usY2XSOrM+W19PEukGvoJxFB3c5smB5nGhPeUANQ3A16flX3/MUfsPPoK8B0vMeABO7H389elRn6gC/Cr47MlAFJkmokFxtrmm5IRqtphglK5tCRnmvX+NLm6IUwV5BzIzFsK/DYQklM6rvkw7ZWisG3x5WTkgb52fVRIR64VYeeJGJZEtMS7Qy5eWqroGlTyxt+6+pk3ltM7B+qd6FufH7lRDVZOCMMqUfB9DTY6AZrmCGirTzp5e45urHK2lTBYFIAKmg8vYog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GoYfSbVMVBfFTdAfTBzG6lRq8XVvK8vP78Mm2MvdZ2w=;
 b=4x/CCBtDVCNu0BNv8DTL6tPcZBR+ZCUoYA+uWhdg7IxT3a+IHrH83+DuBfKodt9LIe+AD48UvO9ybH1Sr9e+H/fJA5HFxgrmVwZXCh0nDNLZsayMAmrN/n3PN2pxOwnvjGPD7T8/qhc1C/+mqyk+W4Ln4QxmOlnOWJjxEwSTfeouV4pWIk+ShU+f/lk/E/M7KKL0O1T4etagdUuqRBEu2MZudN5TYwybG9b6h54WTLn2ybc2k/jO0Li5xJiPIZGxSu13+gaPNznm8CgAlBgH+V09qPKVG5R62loTXhxgyL1MQv3QlbvVtbvfB3csi/WG8W/BOwQJLjrrdwczv7JYKQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b5c8f764-6f2f-3848-6866-1a24db043964@suse.com>
Date: Wed, 12 Oct 2022 08:19:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT
Content-Language: en-US
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Ard Biesheuval <ardb@kernel.org>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
References: <ce73ae2fa148c5d79a038275b0983d24537e97de.1665458679.git.demi@invisiblethingslab.com>
 <9c1731eb-44f6-41c6-cb4e-51abf0c50052@suse.com> <Y0WfXttQHfFle2R7@itl-email>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0WfXttQHfFle2R7@itl-email>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P192CA0003.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7289:EE_
X-MS-Office365-Filtering-Correlation-Id: f1d01091-6a05-4e8c-9de9-08daac19bf19
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+NZiq99vpLZjmlc4am3SltaRUj/1Qm56dIWxNlyRUnnqgf+PVMc9wWlFVxjPmDx/9vw3RTUAuNuuB3nGD3tAXQhjW1afUjrd+Gcf2N+t1l8njnzhU41cAeRD26WF5hfnFvEslFt1c4HHHoN8gpq9fRBR9exRTeixWHFnhVypQ7B7NSkK58Z9nr5PX39MDPQ8av1VUMV39Ypgp0kEMo7p/9zixFRmVx8z0MAHOYm/XpbNnpX6MUGXyeEJIpV/ZZ5/FdDLzECyfuTrC2FZq+WBH2n6h67x76Q5nsKsH46LuEuU4o4rytPrdFcHNB07U/46AHTKcPCzi0OhFM8apCgFuHoZOMyYKwmU582cLzFgBwrM0LFJox6GwAVy5Qqv4UAb/bd8O7pJ6b6tX5eLVQxEd1fW+JTpSVUhQ+GfIaLxKVX8lVwAFhotM5Z5J9NqKZ/Lnp/EPrP4fLnO1TuqW2002cdXsis6kEnOccZ5sDYc8soI4gWEgYC6q1q6418yS+wnlkaZNcaAWFSOsH02Oj1lcauViksTRZfqMaqWtOXo1U5QKfVaRMRLJxOdfkgqleLlvLJ5ZdUOpQ5HyHNxugGrhYEZ/f2rJDLL1vgSNFXrWgZao4zWRx5D4HWboK0950nvsm4BQw5sKF8A3BeFm8sXq1vuGv3akdWULRvyhy+YbnXh8symKjzFDzMvLuBhO8PmmFGs9Shl/Rw3cGGhyaZMHsKwhpxcL1W98P0gZPibGl3PsCqDxGYbARiwhK0C1x4EGTTLvXaazMKF9wO7PxYkhJ54V0vqkxaEluGs0jHkqk8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(136003)(376002)(396003)(39860400002)(451199015)(2616005)(31686004)(6666004)(6512007)(6506007)(31696002)(186003)(53546011)(36756003)(86362001)(38100700002)(66476007)(66556008)(66946007)(4326008)(8676002)(478600001)(6486002)(5660300002)(6916009)(54906003)(316002)(8936002)(2906002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TFNNVWhSaTBWVlZVUi9YWDRvNVBKdE9KZVo4aTNSWEI2TlZlSkZkYnpiYkR6?=
 =?utf-8?B?TEtaS1FrQm9TenRpZXBLV24wbUU3akIyUU9ybGd4TU5GVERyS2c2U3FhQTVw?=
 =?utf-8?B?emV6U1hjc3pnT1lwSk9WeUVRc2Q5M0tSanh4SERBeTJETE9PU0I2a2w1cTJk?=
 =?utf-8?B?Z3RzM1JpMjBwbWRRdWFUcStMUGtyclgrdXFEdGlSV2tOSWxVVmM0Qytjc3Q3?=
 =?utf-8?B?RCtPOS9XMXBWcnNqMCtzSUN0MW5TSVEvbzl0N0Q2eDY5aXdrSThIOG9uL2FW?=
 =?utf-8?B?c1JlSDdiNHppZ1VTK1cwT3JwMTAzNGZVMCtZQTgwdXR0dlI0SzQrMTlrQVlE?=
 =?utf-8?B?ZlpnVzVJbzB2cHJGSTN0UTdSb3RnT1Q5T1p4YWFkbEdMQjNDWWdSRFFld1l1?=
 =?utf-8?B?ODFPLzhVVndGNkl3Q1J5bWlyY0p6NVRxV25lWUFjTFphYU8wVjJ4Z0RrZkRq?=
 =?utf-8?B?di8za3VlZS9ub1MyQ2ZHTUYzdDhHM0pld3A4Q1UxVXVkcTgyc3BvTTJNYVUw?=
 =?utf-8?B?VkZZaEZTZDJ3bERidm5nZG1HWk1LUmwwQUxPQ3NKSDlpU3k5Q1Fhd2pJV1pK?=
 =?utf-8?B?K3pSeFpnN0laTXU1TmFoOU0yVW40T2F1VVZZSjJEUnRXN21La1N6ZkYyemFp?=
 =?utf-8?B?T1NTWlF5S3NlZ1JSQjQvV25JZUprQzZEdklHT01FMzJNRVVYcWFHMVNYbGpK?=
 =?utf-8?B?U3VBTG56SExaandlWllBeU5vZFZzei9rRFZ4QkR6WGhZRTVVVHlxRVRLdjBs?=
 =?utf-8?B?bE83MWMremUrS3ZrOUE3aTVQcWdUNGxBVHRSZy9yMEJVS1ZVaWVvK1A1L09G?=
 =?utf-8?B?b2k4aUVxbklCN25SUzIvOUgzeWJnZHRqQVpKUC94bWloMFVpZS9ka1hDWTlq?=
 =?utf-8?B?cG1lc1FyQ3hYNFJxUW9nNTd6d0owa015TGRaREM3bFJONVdDUzhzM0IvOVhq?=
 =?utf-8?B?U04vOEF5S3FyOUV3N1p3VnhSZU1DZzhFYTIxOEFndFpJNXgwSk5lT3dpLzVo?=
 =?utf-8?B?bCs5ZHNiWDd1cEViZVlUSzZUaUMraUhrQ0VaakZHdDdSNiswSm01TWw4amRk?=
 =?utf-8?B?OXZORjhQL3JlYmpXVDBaaGxtNGZPSFR2YnE1QWlXKzB2b0lINHNVYU5vblFD?=
 =?utf-8?B?azNyd1NNWSsvaDdoMkxOSnZBekhQWCtZL2RaQUwxTWErbFhWajFOSk9RSWxL?=
 =?utf-8?B?QWJ0MUpLRFl0OFAvK1M2ZmlpRFcrM200bW5KY2VQVHdONlVWZXY3M1hqMEZY?=
 =?utf-8?B?YTZCVXpPVkc2TFgvTGl5R1JsZ0RoeDBacVBZS0tUMmJmVU5id05XdTR3QXZq?=
 =?utf-8?B?dW5nQ3RVell5QlJjM1J2aGk3RzVEZHltVzdOK2FWOGJqVzFnQ0RoMWZSbDNB?=
 =?utf-8?B?b0Z3L1pVNFNuWjMxY3Y1amJ4VDhKWllCZFBIREZKb1VFREt0UmRXY0JKOUpy?=
 =?utf-8?B?VDltYm9tSm1uRmhneEE3RkJRY1dOQmRWSDJqclRLU3c0RDZxWUZnNURUNVRs?=
 =?utf-8?B?QjhXU2lDL0VnMkxjRklFNlFvallXb1F2NGNWTmJ1ZXdYWnVPd01nWmo1NFM1?=
 =?utf-8?B?YlY1TGwvN20vZE1MZU93U0RZQVhNU2htOU43dmZHSVBlT3pxa3JsWlN5Y0d5?=
 =?utf-8?B?K2EvaWhNMHBibkJYMGE5bGJ2SGkxZGxCN2YyNzRPSjh6cFNDS2NKdkFiL3V6?=
 =?utf-8?B?UnRBMzlPVWRMY1lqOXhOajFMMjFjaElxMG5pc21ZUWxpZDc2SzBDWXlPckhv?=
 =?utf-8?B?TDBDTFR6cVJsK28ya2NDZjY5a2ViU2grZExXaFpnVHVwdHhkVk9DSERuTU5K?=
 =?utf-8?B?SlluSU1WV0dWQ1Y1ekl0aW1kWXlVc3o5dHI1UDlQdndyQlhlaWZHQW1YbjVH?=
 =?utf-8?B?SmJ1WmVrUDZrVEZvM1dFQnJsYkJSRGlWd2VReTZrK2tUV1d3VVc4WER1dWdw?=
 =?utf-8?B?WjlGN01kS0hpcFJiUWtidmtNYy9ZejJ4U01MZExMWmdLYjlzamx6WTl3OXdP?=
 =?utf-8?B?RnRRQ2w2ZXphNFZRSkZvY0VhOVFMME1pWlVXYldFNythcEE5RmZnbzlEZStJ?=
 =?utf-8?B?VGZ1YXg0S1lhd3F0TTdqN1BLWWpqSk5IazcxUXhQV0p5SmZOQis3dHRaNDkx?=
 =?utf-8?B?U2ZodHFIWk56eFR1ZDJMVDJKWFVObzdLZm5Ob3NDa3VvaFV1b3g5VkMzZ2FO?=
 =?utf-8?Q?Y0TYkZlC5/P2lRyItwFY09+b2n3P1YiEvylKBeB+8AAv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1d01091-6a05-4e8c-9de9-08daac19bf19
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:19:40.8352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nVsVJiz3Q8wI+7P1VV0eknAn+5XFQx4ytrliNhnj3GnIJnSMgHXUqtgYUZbYSEmRyeA5BTUSIl3bHs6PNyZ5dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7289

On 11.10.2022 18:52, Demi Marie Obenour wrote:
> On Tue, Oct 11, 2022 at 11:59:01AM +0200, Jan Beulich wrote:
>> On 11.10.2022 05:42, Demi Marie Obenour wrote:
>>> A previous patch tried to get Linux to use the ESRT under Xen if it is
>>> in memory of type EfiRuntimeServicesData.  However, this turns out to be
>>> a bad idea.  Ard Biesheuvel pointed out that EfiRuntimeServices* memory
>>> winds up fragmenting both the EFI page tables and the direct map,
>>
>> Can this statement please be made describe Xen, not Linux? Aiui at least
>> the directmap aspect doesn't apply to Xen.
> 
> Should it apply to Xen?  My understanding is that Ard’s statements
> regarding mismatched attributes refer to any kernel, not just Linux.
> You would be in a better position to judge that, though.

We run EFI runtime services functions on their own page tables (with
certain areas copied from the directmap). With EfiACPIReclaimMemory
converted to E820_ACPI we do not insert those ranges into the directmap
(i.e. no difference to EfiRuntimeServices*). At least this latter fact
means fragmentation effects - if they exist - are the same for both
types.

>>> and
>>> that EfiACPIReclaimMemory is a much better choice for this purpose.
>>
>> I think the "better" wants explaining here, without requiring people to
>> follow ...
> 
> Something like, “EfiACPIReclaimMemory is the correct type for
> configuration tables that are only used by the OS.”?

Preferably with "supposedly" inserted, unless you (or Ard) can point
out a place in the spec where this is actually written down.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:28:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:28:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420733.665713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVDy-0002Tn-HE; Wed, 12 Oct 2022 06:28:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420733.665713; Wed, 12 Oct 2022 06:28:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVDy-0002Tg-D6; Wed, 12 Oct 2022 06:28:14 +0000
Received: by outflank-mailman (input) for mailman id 420733;
 Wed, 12 Oct 2022 06:28:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiVDw-0002Ta-Uq
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:28:12 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00075.outbound.protection.outlook.com [40.107.0.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0b675bba-49f7-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:28:11 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8852.eurprd04.prod.outlook.com (2603:10a6:20b:42f::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 06:28:07 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:28:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b675bba-49f7-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n5HCJhx4VYpo1aoKCHYZ8YgH6AES7fj9yBXzHC4NxALAGr4Yt6fXYavTqiW5DJ5LsdfJaR1lO07jDS6ni8UvOhiEOIiX8zmPtTIeH2ofAZvaMDG/do2uEv1iHApmOJtlUby+iqz/lAYGQqxa90+C8LzC0RJrCYFc4OZD22tctK8nh0Iq9avUKlUlUP6P9fxZ3TW152dM25Zh0LTW7gxPtT9Xlqg0QY0tg0mytuobCvUHmIj3/rks09yY4KnqPjmEFZFVIoTlRtW3C8n6510+vsKGZ3RCvBnpwwQEJX/GTERimGrqMp/J2dSTnlP/x1NbcXsZYs/YQoXRJQ47YrwyGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lx5wPmLUQT8BJVNDZsV7PbijR+Asnthhs2nNHgkcCEw=;
 b=KA0zUYApLBqzfI7YW0dq1TOppf7WArX2wbxZC64o2D+kFFsN+5UXuHh0D3SEQXHn2XKe8aItS4qTFbaYfLOewiF9TfznYOWi2LnmfhaMxcAegNfVMKRt18NklrwqXIg7g7HVwuHhxtrWD/220+OXx2p7Fzzbb0716f576UsV7C/Br0it+Ll2dw398xOC88Z4qC/gA7D+N51HztG0mNZDvPvKtc2yk5pCXJ3+A+L25XsToUB90CQzVPivk5m/mICFrWliyMz/VYJB9ZHi6hH78He9A0RBT3Kvfwy/vcypzJ6W8arsBWfcsqUJO0+M1EY9CiHSQCgXIxkNIiN90sMF2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lx5wPmLUQT8BJVNDZsV7PbijR+Asnthhs2nNHgkcCEw=;
 b=SHc2zFvg8UWTn/pc6X03ng8lAbLmhGBIZvilFxgaKAuaFmESJdFdgvZKhnfTumFs5K6BeumloNgc8Tlqh0VbCJ4WZpy2MB6JSYIsg3uSc7tS3XeL0YNLBG7Nj07Ijnu/LWaeZ4mpqj5CbuP4d6m1mSChdnJZC4SGkzPcdk8CnWZkXk4+Do3lzECeK3ZtlA4qB/3eRvl7vfVjQyxNgMQ4/ucJcNkVDSZh0WRXkYzmYqvt3lQFUwhGyuotRJFQcWOyToe2z/tFqRwlIypvih1kRH5yS9QDAC+OSJfckrYGRjVAfOvXkSJqEk0VcRS2D7WgFIkG0yo2bojZWleTHArH3w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
Date: Wed, 12 Oct 2022 08:28:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 osstest service owner <osstest-admin@xenproject.org>
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0006.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8852:EE_
X-MS-Office365-Filtering-Correlation-Id: f72c3027-716b-4abd-aa04-08daac1aec85
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tAkoYPaRrTgk6RgrE8PJUifb1pRCjd7PHURoc82OYNuzkVyVKiYT++Rkw3FIvYuZLxAnzRjtspob95XyKKIA4UaFKVWTt1QeGZlUTn3kvNWEU9fY5jIyCzk4INELVQFbwMyrUvyAnomIwHKsO7cr5wc4m2WsD7NLGpkQzz99ioiVwiPAl2Osi2XZR9W8/ujnyO1+aI6/LUU4glDmrdpzj/cxyqmG9f1KutLUjImIoa+rKS3f3DYjaYEiWA4EL3PSzVrLsmXebVGlwBzMe22K4dACRPUdAQ6iHmJL4URiO7Qw1LSnMNw5F2iP4lIDPz2+7hapzGuuJkhZ8Tm53b2uonZrc3itQzkyeF9PuVzQlTb/MDFo/pyuNj2NO/I3ZRr/HfwN+7H2OfMXFXY0uzkiglhe6UReV5ktzu8a0fezQDti6oXoyihf0RU5Zk1qDbMH72+igt3SATRiyLita8nS7Twmaqnscz7lsD3OPDM2mGNl08uYgziHxtaLSS5QFL/oIkXc3TJf83QF77v32ArObiUE2UZeRYsPjo38KllUiGfKjEIQo/ZCOgcinu64BV0kUcZo8bWoOpAOoi/0FH5tFqk6zbxkgByEAReqWMHcRyb1BLXYbS9ta4TGR8eXLIxD8IupqGxe0U6yCxJZN4X9wjjuvG+3XKavGoPjkJqxscVvxIPcGHZ5TJoOx+FoqKcllvqohtKweoqGAhv56ojn7yeh7vmp0UmN+CUZaDi/ocsahgPrxGl1S7UFvoTSDcJM4Q4A6bzvFc4l2lJlaU5wqC3iUd1hzAhEt7M4AMnohsWoPIV51IgtIA/daT/PflWFR65xW4JA8Xka1468QXyuOA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199015)(6506007)(31686004)(6512007)(86362001)(6916009)(54906003)(316002)(38100700002)(966005)(6486002)(6666004)(36756003)(66556008)(8936002)(83380400001)(8676002)(2616005)(53546011)(31696002)(5660300002)(2906002)(66946007)(66476007)(186003)(41300700001)(478600001)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NzlCdUtxOXlvTU9NOUVZcFArZUQzSFIvNmJRelpPMDdmMCtXNDJKSnYxUkVp?=
 =?utf-8?B?aVRTRDgvYUZweEl1dE0rZUlSZDh1WS91ODR1dzFiWm0vRkc3Vk1PZ3BzY3N4?=
 =?utf-8?B?MkJvRE16QVA1NmlSZ0NuOHJaRm1ZQTRuRXMvSmhuVzFWQUlwbzV1Z2JkZDEz?=
 =?utf-8?B?NHV5dFNyN21BWTZXZ1N1QVNTcW1LdXVESlBDQVBXZkxKUjhubmtxNk1iNUNU?=
 =?utf-8?B?eUF2bjBNMFBPSG9FaDZXVDBKODBTb0I4dmlVU1VPckF3MFhDMjlEeVFSTVdw?=
 =?utf-8?B?S2R4c3VnS3dGSms0Z3pjWHlNc2JZNGVXTERjTndPV2VyRzdnRzBvWTlZenE5?=
 =?utf-8?B?SDBGVGRCVkE2cHlSejFJSy81NWVTRTY2Wm5oZ0xFZFFNaGVwQVJ2d1oxVDBT?=
 =?utf-8?B?M0NFK3BQUDlaNnMwSTBHNzFoamRsYTZBbkNzRi9GM0YwRHRxUGcxSDkrSVJD?=
 =?utf-8?B?TXQyZy9CWm1oV3dGRkh2NEgzaG05SWFOckFqdVBOdWdrVVBuRmt6QVhGbkxl?=
 =?utf-8?B?NWJMeTBMTGVNRTFxcC9KeExCRXQ5b2ppMitudUtKYUEyZ3RjNEV1b0pTWTEx?=
 =?utf-8?B?b0pGMnJwQVlKU2NWQ1RlWEpuM3Z4TC9YS25zanNZU0lTS1QwNlJlSmxMbjBY?=
 =?utf-8?B?Z1EwSFR6dTBQM1gxM1lEL29yaWMvdEJnVzN5cU9panNUVTNac2lrZStHNHNZ?=
 =?utf-8?B?eWRmdmhpeHJwNmhBTnh1Mk5WcHRyT2dWVmtoMytpSGQ0QVhTZVArd0QxU3FV?=
 =?utf-8?B?SFlna2J3c2hTaGViWWxTdFVQdXoxS1l3aWJreGVaMUthRjh1SjEyTjlLeWdo?=
 =?utf-8?B?RUI5eU42U0NEdHBpbytac1hoOHpIWDdXWVdVM0cyYytnU0RDdHFFUEV6ejBl?=
 =?utf-8?B?SGRBSmdaaGJtUmx3Si9KYXZzVGxvaW05dHZqR1JYa3l6Z293eU13Tm9PdjhK?=
 =?utf-8?B?KzM3UW1zSlkxVDlkbnBjMEVqSHVSL1VTb01mMWxQZjhVRjJaYXVRUklmYmtm?=
 =?utf-8?B?VzZCR2ttSjE5ejZ2UnJxQnRkNzJtbTdxMkF1UU9pYjU5Yk1qL3FQVlp5dDV1?=
 =?utf-8?B?aUpRMlJpMk1nVDVLMWMvcVE4TVI3V0dXeS92QVZhOC9zbzcwSUw0WVlveDZL?=
 =?utf-8?B?TWIvMGtjQTg4b3JxdFVPbkNxV1JMenZIM1FHTXU3RlYwOC9WSFNjaFc5allx?=
 =?utf-8?B?L2hSbHhBQ01CbExwYUlPMFdzOHpFYjZOTHAxQWV1a2RnRXhXanF3RkZOV2Nk?=
 =?utf-8?B?bWRVMFBBOEtVYkRIMmhuWFV5aXZHc3dyWHF2ZDBSZE9qaVl4VEZ1Qkc4bVVR?=
 =?utf-8?B?SnRlOGJsSGZPR3I3RFZOdkJNZ0ZacDd2ais3MkF6T016TlprY0hKM0FieEJv?=
 =?utf-8?B?a29tM1l4SDVEY3VOaWJ0QTc0d3VmdHZWY0NTeDVvcXZlaFRSK20zTXI3U0tY?=
 =?utf-8?B?aWk0NW1QSUo1WUxGTVBLRCtXTmdNS2Y0RlNISml2VDBpd3RONnlnNXlQdml2?=
 =?utf-8?B?V0FEa05KYjZCMFRWWWtBb2FadWtqTUhxckxGM1NJWFZ1dnZHbHRhWUF3VSsx?=
 =?utf-8?B?Yk1VdDB0U1hmZWNSRGlHMzdkNGJQaVJidCtDUy9FNkgvczc3YkhqRjlpY3Zl?=
 =?utf-8?B?QkdLQUlJYTc4R1FNRUc5QVFOT01Jb2d3dXZyU1hTZ2UyWThaVzllSTdFclQ5?=
 =?utf-8?B?N09HNUZ6UXpzVXlSb2R0RkEvaUwzZTE2QzlFNGd3SDh0d2czYnN1dUVLT3hP?=
 =?utf-8?B?dU04aEdKS1NnUmdDWW55TnRUTktTQ3BUTlh0UFpKMkllcUNzWld0aDhxSHRW?=
 =?utf-8?B?T1ZKb0tLNm5IQkplR1pvR1hOd3RwNkhVOS83Zy9RVmFCb0psZWUzZi94ZEhN?=
 =?utf-8?B?bWc1d21oQ1VHZHlLYmpHSVIrbmF1S2FhYWdZRDdlUDZnK0lkcDFWMWRZVW85?=
 =?utf-8?B?eFFselNaREVSVHFLRENacjVIY2FILzJ1VTI4SGlEZERjNm1tVHZuMWI0aUVj?=
 =?utf-8?B?bmY3dDVVTUVKSlltTE9VUmFwS2gvYnRrUUJBSFd3c0c3SmYrbTRkTW9pczN5?=
 =?utf-8?B?OUl0NGwvWXk5Y2dDa3NLTjUxL1UyWkQ3REduVjVQVzlHVGsydGxLaTdOekhq?=
 =?utf-8?B?U1U3cFNQenQ5RmE1Y0pDYUxCWFdWYkM3ditGOUE3ck9adG1oNngxUFVSS0N4?=
 =?utf-8?Q?D3XivZebOqUFXFPJK3Kp3R2p2XbGELrOb9d7kePu/hkJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f72c3027-716b-4abd-aa04-08daac1aec85
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:28:06.5375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H2o3ccLIWyWRwPByka91AesemngNwCijRaPHtQYJGZ87Ij3B+3mvJX9wL1/1wzsoz/t7e3/o7mteTvL4y8AgXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8852

On 12.10.2022 04:42, Henry Wang wrote:
>> -----Original Message-----
>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>
>> flight 173498 xen-4.15-testing real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>
>> Regressions :-(
> 
> I think these regressions are from the backporting happened yesterday,
> see below...
> 
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  build-arm64                   6 xen-build                fail REGR. vs. 172547
>>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>  build-amd64                   6 xen-build                fail REGR. vs. 172547
>>  build-armhf                   6 xen-build                fail REGR. vs. 172547
> 
> ...The arm/arm64 regression is from the backporting of commit:
> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
> 
> The issue is:
> In 4.16, commit
> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
> changes the prototype of xc_shadow_control(), and hence the calling of
> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
> xc_shadow_control() in 4.16 and after.

So did I commit a wrong patch, or were the patches for the older branches
wrong already in xsa.git?

>>  build-i386                    6 xen-build                fail REGR. vs. 172547
>>  build-i386-xsm                6 xen-build                fail REGR. vs. 172547
>>  build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
> 
> I think the x86 regression is from the backporting of commit:
> xen/gnttab: fix gnttab_acquire_resource()
> 
> As the error message is:
> make[5]: Entering directory '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
> test-resource.c: In function 'test_gnttab':
> test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
>          (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
>                    ^~~~~~

Hmm, I'm pretty sure I did a local build test of tools/ with this in place.
I'm not in the office today, so I won't be able to do anything about it
right away.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:34:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:34:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420739.665724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVK4-0003uQ-61; Wed, 12 Oct 2022 06:34:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420739.665724; Wed, 12 Oct 2022 06:34:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVK4-0003uJ-3P; Wed, 12 Oct 2022 06:34:32 +0000
Received: by outflank-mailman (input) for mailman id 420739;
 Wed, 12 Oct 2022 06:34:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zRMe=2N=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oiVK2-0003tx-KN
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:34:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ebaffaa1-49f7-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 08:34:28 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8E6A31F388;
 Wed, 12 Oct 2022 06:34:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4634413ACD;
 Wed, 12 Oct 2022 06:34:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0WRZD/NfRmOZKAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 12 Oct 2022 06:34:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebaffaa1-49f7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665556467; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=OChShBozUxd9JL2D32JXRxLYJ25EsewCWOYTNGqhNWk=;
	b=G5IoVps18BlIWKFg1kDJPt7BMjE3jF0ZYB+heTGn2PNanNfimTlQcXPdp0g4gFzbnZm0Qt
	fM/0PYRZ3KtNEo5FqUXD+k8uPbqLiF8SMJ7cWoxPrYpNUu+rxbPrpkxXOGrbtj4StC7Nb9
	vpA43DdW7PB5z5EMOigVeRx2xqKrgJk=
Message-ID: <233ccf7b-43ae-d563-3d3a-0dac4bed61c3@suse.com>
Date: Wed, 12 Oct 2022 08:34:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Henry Wang <Henry.Wang@arm.com>
Cc: Julien Grall <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 osstest service owner <osstest-admin@xenproject.org>
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------3nxA0T0TKSAzAtYuKGU3J00Y"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------3nxA0T0TKSAzAtYuKGU3J00Y
Content-Type: multipart/mixed; boundary="------------w5c8o0pzVsGJbhlNnpMbZVwc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>, Henry Wang <Henry.Wang@arm.com>
Cc: Julien Grall <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 osstest service owner <osstest-admin@xenproject.org>
Message-ID: <233ccf7b-43ae-d563-3d3a-0dac4bed61c3@suse.com>
Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
In-Reply-To: <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>

--------------w5c8o0pzVsGJbhlNnpMbZVwc
Content-Type: multipart/mixed; boundary="------------iuprGmO5VV0TXjrpRm0cR8uh"

--------------iuprGmO5VV0TXjrpRm0cR8uh
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTIuMTAuMjIgMDg6MjgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMi4xMC4yMDIy
IDA0OjQyLCBIZW5yeSBXYW5nIHdyb3RlOg0KPj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+Pj4gU3ViamVjdDogW3hlbi00LjE1LXRlc3RpbmcgdGVzdF0gMTczNDk4OiByZWdy
ZXNzaW9ucyAtIEZBSUwNCj4+Pg0KPj4+IGZsaWdodCAxNzM0OTggeGVuLTQuMTUtdGVzdGlu
ZyByZWFsIFtyZWFsXQ0KPj4+IGh0dHA6Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3Jn
L29zc3Rlc3QvbG9ncy8xNzM0OTgvDQo+Pj4NCj4+PiBSZWdyZXNzaW9ucyA6LSgNCj4+DQo+
PiBJIHRoaW5rIHRoZXNlIHJlZ3Jlc3Npb25zIGFyZSBmcm9tIHRoZSBiYWNrcG9ydGluZyBo
YXBwZW5lZCB5ZXN0ZXJkYXksDQo+PiBzZWUgYmVsb3cuLi4NCj4+DQo+Pj4NCj4+PiBUZXN0
cyB3aGljaCBkaWQgbm90IHN1Y2NlZWQgYW5kIGFyZSBibG9ja2luZywNCj4+PiBpbmNsdWRp
bmcgdGVzdHMgd2hpY2ggY291bGQgbm90IGJlIHJ1bjoNCj4+PiAgIGJ1aWxkLWFybTY0ICAg
ICAgICAgICAgICAgICAgIDYgeGVuLWJ1aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4g
dnMuIDE3MjU0Nw0KPj4+ICAgYnVpbGQtYXJtNjQteHNtICAgICAgICAgICAgICAgNiB4ZW4t
YnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcyNTQ3DQo+Pj4gICBidWls
ZC1hbWQ2NCAgICAgICAgICAgICAgICAgICA2IHhlbi1idWlsZCAgICAgICAgICAgICAgICBm
YWlsIFJFR1IuIHZzLiAxNzI1NDcNCj4+PiAgIGJ1aWxkLWFybWhmICAgICAgICAgICAgICAg
ICAgIDYgeGVuLWJ1aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3MjU0Nw0K
Pj4NCj4+IC4uLlRoZSBhcm0vYXJtNjQgcmVncmVzc2lvbiBpcyBmcm9tIHRoZSBiYWNrcG9y
dGluZyBvZiBjb21taXQ6DQo+PiB4ZW4vYXJtLCBsaWJ4bDogSW1wbGVtZW50IFhFTl9ET01D
VExfc2hhZG93X29wIGZvciBBcm0NCj4+DQo+PiBUaGUgaXNzdWUgaXM6DQo+PiBJbiA0LjE2
LCBjb21taXQNCj4+IDIxMDdjYzc2ZGIzYSBsaWJ4Yzogc3BsaXQgeGNfbG9nZGlydHlfY29u
dHJvbCgpIGZyb20geGNfc2hhZG93X2NvbnRyb2woKQ0KPj4gY2hhbmdlcyB0aGUgcHJvdG90
eXBlIG9mIHhjX3NoYWRvd19jb250cm9sKCksIGFuZCBoZW5jZSB0aGUgY2FsbGluZyBvZg0K
Pj4geGNfc2hhZG93X2NvbnRyb2woKSBpbiA0LjEzLCA0LjE0IGFuZCA0LjE1IGRvZXMgbm90
IG1hdGNoIHRoZSBjYWxsaW5nIG9mDQo+PiB4Y19zaGFkb3dfY29udHJvbCgpIGluIDQuMTYg
YW5kIGFmdGVyLg0KPiANCj4gU28gZGlkIEkgY29tbWl0IGEgd3JvbmcgcGF0Y2gsIG9yIHdl
cmUgdGhlIHBhdGNoZXMgZm9yIHRoZSBvbGRlciBicmFuY2hlcw0KPiB3cm9uZyBhbHJlYWR5
IGluIHhzYS5naXQ/DQo+IA0KPj4+ICAgYnVpbGQtaTM4NiAgICAgICAgICAgICAgICAgICAg
NiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcyNTQ3DQo+Pj4g
ICBidWlsZC1pMzg2LXhzbSAgICAgICAgICAgICAgICA2IHhlbi1idWlsZCAgICAgICAgICAg
ICAgICBmYWlsIFJFR1IuIHZzLiAxNzI1NDcNCj4+PiAgIGJ1aWxkLWFtZDY0LXhzbSAgICAg
ICAgICAgICAgIDYgeGVuLWJ1aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3
MjU0Nw0KPj4NCj4+IEkgdGhpbmsgdGhlIHg4NiByZWdyZXNzaW9uIGlzIGZyb20gdGhlIGJh
Y2twb3J0aW5nIG9mIGNvbW1pdDoNCj4+IHhlbi9nbnR0YWI6IGZpeCBnbnR0YWJfYWNxdWly
ZV9yZXNvdXJjZSgpDQo+Pg0KPj4gQXMgdGhlIGVycm9yIG1lc3NhZ2UgaXM6DQo+PiBtYWtl
WzVdOiBFbnRlcmluZyBkaXJlY3RvcnkgJy9ob21lL29zc3Rlc3QvYnVpbGQuMTczNDk4LmJ1
aWxkLWFtZDY0L3hlbi90b29scy90ZXN0cy9yZXNvdXJjZScNCj4+IHRlc3QtcmVzb3VyY2Uu
YzogSW4gZnVuY3Rpb24gJ3Rlc3RfZ250dGFiJzoNCj4+IHRlc3QtcmVzb3VyY2UuYzo3NDox
OTogZXJyb3I6ICdnbnR0YWInIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0
aW9uKQ0KPj4gICAgICAgICAgICh2b2lkICoqKSZnbnR0YWIsIFBST1RfUkVBRCB8IFBST1Rf
V1JJVEUsIDApOw0KPj4gICAgICAgICAgICAgICAgICAgICBefn5+fn4NCj4gDQo+IEhtbSwg
SSdtIHByZXR0eSBzdXJlIEkgZGlkIGEgbG9jYWwgYnVpbGQgdGVzdCBvZiB0b29scy8gd2l0
aCB0aGlzIGluIHBsYWNlLg0KPiBJJ20gbm90IGluIHRoZSBvZmZpY2UgdG9kYXksIHNvIEkg
d29uJ3QgYmUgYWJsZSB0byBkbyBhbnl0aGluZyBhYm91dCBpdA0KPiByaWdodCBhd2F5Lg0K
DQpNYXliZSB5b3UgZGlkbid0IGJ1aWxkIHRvb2xzL3Rlc3RzPw0KDQpJIGNhbiBzZW5kIGEg
Zml4Lg0KDQoNCkp1ZXJnZW4NCg0K
--------------iuprGmO5VV0TXjrpRm0cR8uh
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------iuprGmO5VV0TXjrpRm0cR8uh--

--------------w5c8o0pzVsGJbhlNnpMbZVwc--

--------------3nxA0T0TKSAzAtYuKGU3J00Y
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNGX/IFAwAAAAAACgkQsN6d1ii/Ey+E
YAf/aVOK694zqRDTPAphElENv/dmiiiMiedOALuzMJqqxqHiY9MfcUiN0N4ra1MZkOonsW02gxR2
Bocz5/49R3QoVnim1yaGRwlSqEpWEUjQnk4wtgoRuaOl0tcSMklDQ09yT62S48yTEFiq8zEz3pzk
haZvPnk8xnsLHIZ0gtAwjIqPItRGUbKScEQRJndkGeov1deeZSxcZsZlhePzBhzURK34m/GQ0e5p
3bPuOiiviWZtEjSgyTk9QzXagy8A2slcsO7YrDqiqIVHNQnDJicSrYMQcEIIg/FO7eV8Lhyo0qFL
nDv+EyuCHsil0/ZS1ywNMi8qLN8GUsDpb6/U9+JBwQ==
=DbUS
-----END PGP SIGNATURE-----

--------------3nxA0T0TKSAzAtYuKGU3J00Y--


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:36:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:36:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420746.665735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVLj-0004jE-JS; Wed, 12 Oct 2022 06:36:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420746.665735; Wed, 12 Oct 2022 06:36:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVLj-0004j7-Gn; Wed, 12 Oct 2022 06:36:15 +0000
Received: by outflank-mailman (input) for mailman id 420746;
 Wed, 12 Oct 2022 06:36:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiVLh-0004j1-SC
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:36:13 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2051.outbound.protection.outlook.com [40.107.249.51])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29cd9bce-49f8-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:36:12 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB8PR04MB6906.eurprd04.prod.outlook.com (2603:10a6:10:118::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 06:36:08 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:36:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29cd9bce-49f8-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SEwU9gxv/BV1WsprffAYs75709hkPnNsJ94uWLylpUjQKw3HW+jn9sD2jMbYZEg3z9X++XU2q1l3n+0SQFjnNnNbYkj43//cBE4pnKMS7bFhv3R9cA6Y/1lskvZEhCh3bUgfIickc9sPSY55bzcVsUIbTa4DsajpWWTE/tszsGzSUBvPsnl5Sy8w0osvGwYg3G+eSf/rGTqy9Y1L7Xi+YLvldMEJ23KD9G6RXpOsTfpwfpV4cgj8UzLQl3LMBEzZAEYkznL8AGuAY3+hW330ZbRiQUBe5lIsfKgdR0SxlaUPSH0A4IXwsN0OYL3EVBpkPkmctXwFHRMHOzbODtnc3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=g0CRIrfe1tLwH6ZN0KxJ/TK19Wc4PhRD2oiJkulZdKQ=;
 b=SRGQDaNOLg0ld4FkGW49yzkAZbdy0KDSmb08ZC54khmvuowjSDFuZ/SeLiJ0i5DdQw6jfP9NMeWm7VYNXHBhdJu6WrTQOykm1bezp1ILWCEMbpDkmepJmEcM2R7WdqcUEwz5hS8AcUYV+ZnBqpnm8wRnz8AdcSqzpwgomJKz83bjMydOM8pX1+NjVE5u0/c+8udux1EvXLhA60wWV1qQScn+Mf6Yhp26kClyR/DYgtVS7VgHtSSyfHbjCcwmksKVODTYInkVSOe3nTmRAPEYc2pLw5ivfPsv3cQi8LJEEneSDC3tVVF6toPMEEd8GPseYWvWlIwTcMbJbYvfyfD8Dg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=g0CRIrfe1tLwH6ZN0KxJ/TK19Wc4PhRD2oiJkulZdKQ=;
 b=DYfJviTaRAoByxZSO2UBOA4WWhvzpu6AIGmEbggW4b08z01G62V5FdQKhHFj7yUETVVZY8LXRJoHbyCjYmvvvouxYlHo6S87v/VmJvAVeORqgIC2ytsALFddP9MELCUexJtIwsLU1GMCNapPaRWvv4YAm5t/zuDBDTjDGW5Xfz1ez518sGDni1WGT3ZjvESpo2pvGqEM+Va+GOoGJewS94qNcLZsJXGkRmdyyuD6ADER4Qk8s2RzsmulO1X+KLgPVX186YfiyUeEx/RsVVJuGUB+1dDhnPEkHtRzpEa/zssCBoNIjozvabH03P3yUCK4XaBiGecBrRQ2oMYU4UIdeQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
Date: Wed, 12 Oct 2022 08:36:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <osstest-173492-mainreport@xen.org>
Cc: osstest service owner <osstest-admin@xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <osstest-173492-mainreport@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0263.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6906:EE_
X-MS-Office365-Filtering-Correlation-Id: 005e9082-779e-4ead-ac90-08daac1c0bf9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vjRyNewAzptY7SVgmPrXuYstWHxwRJ74VKfUkvAGJz+h5cFx2X0i5RNXtFH8zQ5j/MzZKyk2wmhaZ/oyN1repYsv14w1dx7B+ulzElGYo2QHrjE07OA3Wgfie8Fn+jUxspHiJ2TdEA9MZp5bovTgqYqg57S8mWnm5g9cHfnTj3ofMlv8bbVoexxjyJU+mCgRg2kZKd7pD+xo6eLTw4DtqZ1oo1j2d4juI9Oi9GQ5CLgcKbHd4XSRRqztOJcBcjETOXGHjthqDHqgFA0POmemIMYO+PEqfPqqF4aULnpnX4ToYf0EabfHM1KvR/yh0ehdLp12Wwr3iwamK9TUNlnwPOnNVAruGw7oWk/Y+L4WVLw7B8QTJc2d83tFGQixT8wsAqcW2cZ+LU8yqlkPsU7gPXWSizIPyEGNYhY6SVI0QaOK3xCv8R1upQ0asMIojPX4/wxQw3NsKVEAI0bUapT3oTOEbE55l3DNad2elLthWwLAVOj3t+l9/VWIG9EBxXYa44CNjdGa5Q34AsCcNZAdwV9lPrg/p07UPHZDM3OP7N8DMKqt+/Pv648AYgsQ3fhXVQMNgS2e8ZOLvMf2NmZbM5Aa/IWUJWoYDNVjW3v1gX0dDEcz+z6PwoOCHpaerk0MEDZ2jca8R9yf8duAy06AwDX+h9C9wUiwRJSJ8hhgrMCg772nFulr2BuSQ4Jzou0DM0/7/MJE1N+3/QUWTO8HkEupU1ZZHwP1td3QXu92sFfOjFJWXlPQuv9NkI5MC5zV6gQg6SzXw7BACG6OyANA/PFcfZSF6mXucB1G2RqlP4o+x3GfHymn0UdUXCo/kI8MdLGPkjbN1d+zQYhqlaV6BQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(376002)(39860400002)(346002)(451199015)(6506007)(41300700001)(83380400001)(6512007)(8936002)(66476007)(66556008)(8676002)(53546011)(4326008)(186003)(2616005)(86362001)(31696002)(6666004)(36756003)(66946007)(31686004)(5660300002)(478600001)(966005)(316002)(38100700002)(2906002)(6916009)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bitRT21rMU5iNDIrSDE5OW1aNEhabWpsVFducEFWdmxBNEJkTHJCNkJNSkZr?=
 =?utf-8?B?RFA1U2VRSXFjQzJwSmltbXpHSjBoWkwxblVXZHRaMllpc2gxdEFqZmRLcHdr?=
 =?utf-8?B?ejBoMUwzb0diVmJ0RzRGVGVyZVl4dVlrUm0wTld2d0xTUG8xQU5FUGFyWkE5?=
 =?utf-8?B?SDYxelg5SWczcWVDNWpRYktkMVNlakN0a1ViU25KQlUxTjc2eElVd1U1UUQ3?=
 =?utf-8?B?YXNHRDRZakdSOSsrNm5pdDVSOEtUWGJxb0NsL2hTK2F2ekNBZ3ozQTVFNll2?=
 =?utf-8?B?ODBVclNXZUg4VUFySmJMa0lHTGJIQVIyY09WbWhDZGRuaHovV3Z1bERpUFBs?=
 =?utf-8?B?clY1YStsU2d0aWZjdy9FRzUraWZqbm1sU1lLN3V3UW1sNDQ4OVc0OTNtZ0gx?=
 =?utf-8?B?anVqRXNvOEZ5QXU2aFJVbllHSEw0OWljWW1vY21IK1RZakNSQ1VmV2VFa290?=
 =?utf-8?B?K3hDSjlzQ0NyZkJEYTB6cFJYZmkxNzB2b3lLYUZXRzMxUzNNVXpRUktEbzU1?=
 =?utf-8?B?a2I5MDFIUFdXY3Y1VkN2Q2p0ajA0V3JNQkJlNUZVR1I4YUM1d25kTFBxSjh6?=
 =?utf-8?B?Yys2c0lML0MwSmNuM24rRE0zMmhEb2VDcjRaR0JrVkNlR0JPZFJZN0lkUE5R?=
 =?utf-8?B?ZHRaRDdjMERScks4dEUzcUNUOWt2bi9tS2txblorQ0JleTJuWmx1SXZCeHlT?=
 =?utf-8?B?aGNkM2Q3UzVyVXZiT2V5YlJIclhKT1FkTTJMT0o0a2REZnVEeXV2ck5ac0tp?=
 =?utf-8?B?NlhKd2FTNEdnT1lyZ0NEZktRbXpXRzFPaURTamo3NHZGSXBsZDI4V0U0ZDFm?=
 =?utf-8?B?ek9PYmtXdHFsRzJJbGNYc0xrRGQvMDhwUlJZdlhmNTFWYUc0ZFNIUm14UjVG?=
 =?utf-8?B?eDcyWFh5TWVaSEgrYTlHakJYRGVXVmFJSE9CRGkrUGRyUFUrODJTTTJ2Vm4r?=
 =?utf-8?B?RUVDR1BzREkraFlCZUVzdGdaZHRzVDVXS3Bpem9kd01qNDZGUTBGakxhVkxn?=
 =?utf-8?B?bGU3QlcrQStEU2IvOGJvSEpYaWVnU3FSUUNuOWlYNElMb29FSmJUQytMTXRB?=
 =?utf-8?B?TERzTGRVdnFTWDNOb0ZlcTlnNVkxYWJxaXROeEQwUXBTVmdINW9XbTloR3hC?=
 =?utf-8?B?eE05eEYvRFlabGY4K3NJWXdxa0p5Q2xxSjBaTU5hWGpueTZpYUx6eEx6VGNp?=
 =?utf-8?B?YU1YTnZGc1VKc3F6c05JQmZFaGRGeVJibE92N0ovcEczY1VUczJ5Q3BISlhE?=
 =?utf-8?B?ODJHT2JzMkJyWW9KUGNWTVdCVjlDNnhPMys4WklVZVZYVy9SZDF0am9PQ2FX?=
 =?utf-8?B?Qk84UjNveENFOVIrOE9ZZ09TM2dlTE13OHlTUDU2Qm52bFViMzBnQ253ekpm?=
 =?utf-8?B?UElvZHhqV1pFall0akF5UUs1a3VneVBLSlorVGxJcG9raEVWYVlRTXRSM0dL?=
 =?utf-8?B?cXNvNE1KVWJKeDhVQ3RJb1Q2enNVbTVITU9pV1BGN0xFbjdYdlR3Wmt1N1BG?=
 =?utf-8?B?cDJrSkRlZFAweVErWVFXenBOMUlYOHFxRzZra1B6ZFRZRUFGZEREWmZXNm5F?=
 =?utf-8?B?ajlFbThlbE9HOWE5NWFieU10YUJzMThxRXBFZzVXbkhRU3pTNUZYM3J1T01n?=
 =?utf-8?B?U2NIMUpmWk5kL2dQa21uL09wWllLNFVEeVpFT1Y4UndQdStML3RPR0RrK0pw?=
 =?utf-8?B?MTRQSlRpcVdVWlBqUkwzc0NId0hKUjhMSEovb0JMU0FNemVISnlHdFZBOTZW?=
 =?utf-8?B?bnh2ZStHUUF4MlFRUGtRL0RYb0phTlFQSnBxR2tPN1BQTUZpU2E4NW80d3lt?=
 =?utf-8?B?OXlYRlZGSHpSNHZ6QndXWFRxTGNRbHc5b3ZrWVdoUGh6bTNzd0NFTWxOWlRV?=
 =?utf-8?B?WVhTM1NWRExyNmZETXI5SmhKTmMzWWdGN1ZCVWZnN2VmeFZreTFCdEVOZ2I4?=
 =?utf-8?B?TzFLQmNaRHhRTC8yMk9uUzY3YVV5V2RwYVBsWkhWcGo2MVE4bE1NdFFBTVNv?=
 =?utf-8?B?NTZleGtTeC9FaHhBWGlxUVhDYUpWeUdNNkg2bGdEZk8zSml2YXNTYTZ3Q0xK?=
 =?utf-8?B?YWpvRks3YWJ0aFJpSmZ2NFcrQ2RFRFZ4T3JXMDFyN2NhNmFlemNXRDRGSkpM?=
 =?utf-8?B?VXR6TFpYK1RvTWdmYTA4NmZtNDRRYzBOZVNpZmp5azZVTDFCQ0FWdnl6M1py?=
 =?utf-8?Q?tgNpnHn9yz/Sr47V30yx8Cv5E5lNSFzdHeJg/ccGJKT8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 005e9082-779e-4ead-ac90-08daac1c0bf9
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:36:08.7726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HK6Mr/TByMrYSUvh7GfJ8ax1nX7T8KtTZOJEpptLB+9V0zk5mWh2ysFk7msIsbNBWK6p+oOtCtdeXF/csadEKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6906

On 11.10.2022 18:29, osstest service owner wrote:
> flight 173492 xen-unstable-smoke real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/173492/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457

Parsing config from /etc/xen/debian.guest.osstest.cfg
libxl: debug: libxl_create.c:2079:do_domain_create: ao 0xaaaacaccf680: create: how=(nil) callback=(nil) poller=0xaaaacaccefd0
libxl: detail: libxl_create.c:661:libxl__domain_make: passthrough: disabled
libxl: debug: libxl_arm.c:148:libxl__arch_domain_prepare_config: Configure the domain
libxl: debug: libxl_arm.c:151:libxl__arch_domain_prepare_config:  - Allocate 0 SPIs
libxl: error: libxl_create.c:709:libxl__domain_make: domain creation fail: No such file or directory
libxl: error: libxl_create.c:1294:initiate_domain_create: cannot make domain: -3

Later flights don't fail here anymore, though.

>  test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Similar log contents here, but later flights continue to fail the same way.

I'm afraid I can't draw conclusions from this; I haven't been able to spot
anything helpful in the hypervisor logs. My best guess right now is the use
of some uninitialized memory, which just happened to go fine in the later
flights for 64-bit.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:39:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:39:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420752.665745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVOh-0005MY-1m; Wed, 12 Oct 2022 06:39:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420752.665745; Wed, 12 Oct 2022 06:39:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVOg-0005MR-V9; Wed, 12 Oct 2022 06:39:18 +0000
Received: by outflank-mailman (input) for mailman id 420752;
 Wed, 12 Oct 2022 06:39:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiVOg-0005ME-BB
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:39:18 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20057.outbound.protection.outlook.com [40.107.2.57])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 97dcb299-49f8-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 08:39:17 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB7142.eurprd04.prod.outlook.com (2603:10a6:20b:113::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 06:39:14 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:39:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97dcb299-49f8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZHmzNYFAg1TK06fK2D6m8O6lfP0qfG+yjoAX6X59ONW3uR6JiStQLpqVC39YMr5ILCc3A3ImvjLB2tSSWznM9WhanagFkZk/phdcKDeNzRFWmT58x/YNRTXCn0iatYPI24B70wxr/QHJvJzCZkF41Q+Tc6Bjq6MTMLLm0bXZoh4F+vXBJUAZjbF5D4bej2OfEgxzYICoSX0CIHX1nwK2Kyu5o69CnktmMEo34AOF448iuv7MxqooG831/7fl2wUsMHwnBKNDfev5UOIW4GTRdjUhWhyvKLD7h8f6yqTFEVepOFNn/3LcYiyLD1d0cKet2H4CCzwTfaj5qREpMIU7uA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kiR3lOtyI7kl4wiASiFNsVg7dyJSUlAYC9iNTt2HI+I=;
 b=oGdaGMyTouQ7Lq9oOZIJVlr9rMlK6hVnfFWkuMFrFCeyjsYP0I6wso2+He7ihjyuSN6uruFzJa2FNAb2sYKEEYZyYHhvi4i7ljQq0wqy5f0yKinzy3/CPxIF3W/wBWFxiz1lmqhoHrY0fGV+QiZ/J8X8KRIifPjCUEJRqwhPWAKd4qXc4IVGFJG8AgfRcxB9iPxSJu0ZgmqGVctGb1IJHDJJRQfuMz5sZ2zdfh+MPyYIGHDy7OYM/gr7XNhPZ1dFpvlH/BZnSxzH/NuG7ieFxNfxIpchBDJRn9l8T2HATVEcAFfOSmZfYMb4aatTf5YoJe6EIuX7yYZwEuYTccDcEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kiR3lOtyI7kl4wiASiFNsVg7dyJSUlAYC9iNTt2HI+I=;
 b=fmCJJZhoHbt4gSh27U28I71Mi++mqPgLh1HBOWjqPxGSzZ6iNztogwJElQTVQrU7Dit+zLQoCUOv3ivxE5U4kQUtlT91urquVk743LvjJRJGmJcV9DQV1xtlp+2Sx/X14FBrmbYV8gHnNo3SGbmHgslEl0qFg/6w6SxDcSx7z6T3xevLaGCGJrsvuppT870FqqFUpzmK9rYgI5spbHe6NNEW+Z7xdrV++FsK4uWT4bThCjupsMfnS8VDegb9yPItFRexwrDwHlryNV7vrUrNNKsEonQ4uSLt4P5gyKZBa0S+2aOz3865f1fX/ZzOlddgQalGzYOLi2cwoxPup2Js9A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b8e0d396-119a-9cfd-d758-b3f26cd1849e@suse.com>
Date: Wed, 12 Oct 2022 08:39:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Julien Grall <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 osstest service owner <osstest-admin@xenproject.org>,
 Henry Wang <Henry.Wang@arm.com>
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
 <233ccf7b-43ae-d563-3d3a-0dac4bed61c3@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <233ccf7b-43ae-d563-3d3a-0dac4bed61c3@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM5PR0701CA0058.eurprd07.prod.outlook.com
 (2603:10a6:203:2::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7142:EE_
X-MS-Office365-Filtering-Correlation-Id: 6142f0b7-9d3b-4c4a-2cf2-08daac1c7a65
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MEUGNflARdsGENqXIrhZcQjRWa2cNl10zAj6OO+hQVa3vJg3cF5DzRo+K+c5kmIYffY3rsaWtFm3vFIwivyo3M7Ke79H7TWLCdHUKLAzoTjN3eAuMak3RJqqEXIV6yYOiKHjXR138h06ziAfUQjRr+9HRNkgIDAGo2Y6UftwndKWVVX2HdhdnYFi9s6lWsEYFxyUFBi7rzZRE+wa9YxsifX/W/uEhL7kJAA1h7U4PC8rCLxfp8QzjV8D1FiAaW9w5REwnhcqBe7KexILsNwI3J8HFlER5n1WIOIci0AFuUX+WbaP6csO9+gxehJA5O6aa2eFRbhwJnr64FNcU6gkSJY9arSPIjjlBMfC+DgDzjgzK7F8GGFwr+PEq79nJKY0xRMJaZV4YV1/2gZLiuzRo7wklVb3KOGLGrDULUqNckSFqaoQHs28fCX29eMQl3RAAq3nt+xrm+/8KJ1D1MbFJ7LtpjQTf2dY2/zaEcLKbOfJsHbwpAwwIqvcuW2JTOgH3N+AlBuCcQcak9BDRlqAA1Cjn9Qt3qq48eFXXxIPLa/mF7S5lmlx05bbrT+NqvOlcRqYMz/iicX0XPq843GvMkr/uQSFyjHcrDmuq/xqFZcED0wOX2zDRaO9vHjD/HlWdUD7sDrSRVHpNpKWfOEQNpuZbmDTjhaNMLnz6JOYjpxIHInQgQSLn9bWr2lhsfNswWy6vs408dcqoVXWRDblusrWoDKqcB5C77OIT+Th53H/Kz/rpa7N24i2B8YKO/hhfLUL8UJXjxm3FqRctFGY0DwJ0Xh123jkWN7FU5YdsLfuEtXaE9+hDxMxLDP9ExWZp788JPSjH3EgvvFgouYRxw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39850400004)(376002)(366004)(346002)(396003)(451199015)(31686004)(36756003)(31696002)(86362001)(5660300002)(38100700002)(186003)(2616005)(83380400001)(8676002)(53546011)(316002)(6506007)(6666004)(6486002)(966005)(6512007)(478600001)(2906002)(37006003)(54906003)(6636002)(66946007)(66556008)(66476007)(8936002)(41300700001)(4326008)(6862004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVQ2dzVVUVZpNUh2dXE2REJnN2g4MUsyblV3R3IrbjlzR0hvUmg2VHpUTUEr?=
 =?utf-8?B?VFNvQTlGWGtoL3lFbG9jM0xFVHkzczJFVjJTeXFINnlTQjU4d1pnUDAyUE8w?=
 =?utf-8?B?YUZ2T3NOTEI0L1JUUUpTYVBYNWZUK3llS0tGZW8zcGFUL204MXlLNTVKWVI2?=
 =?utf-8?B?ZjZRVXNqOXgzaFBDcmRteW5aYVJKMXNvRXQzcmc0a1RYejhnQjA5ZUpteTIz?=
 =?utf-8?B?dEc2cklySHBvTGNNRC9wYi9rZDExMXhoN1RaZ3VMQ2FybEJ2T1RpSktzcks3?=
 =?utf-8?B?dGVQUjVpdlVTbkQwS2xlWXROTTNqQk01SVl3MElkdkdDK08rMUZjeFRndjlC?=
 =?utf-8?B?YmRXdnBBazNjekQxT0Q4d2hNKzM5Q1NBSTVsN3JGL2lRZ0QxQ2NwSW1kSEV6?=
 =?utf-8?B?VUNtTDhraldIYTJTM0NTL1QvMVRKdmUvQmxsYXIxRWFxSEl2YUZmeEdTQytu?=
 =?utf-8?B?RWsvNS9qdG9aN01JVkJhMHd2RjloUDQ0NTBXRUp0QTNMU2ZjWDZyMlB4b3Yr?=
 =?utf-8?B?RW93TjN3VmM0MHhiSEtFMFBQNm5PZFpLZysyZlYrVURmcHJhWGNyWVRBWGk0?=
 =?utf-8?B?dENZb0kyS3psY1ZJQUthUlo1SUZyUGhQaC9UQUFqMnF0YVdESys5TkgxODNB?=
 =?utf-8?B?TXQzYnJ6czJsZ3VSR082QnhDYjdneXM3UjV1K08yK3hoK1dsMkZBNDFNa091?=
 =?utf-8?B?MFJNRXFVVEVPYzhuM0pSSjZOcmdiTk14WTZ6aXZLck12Z0o3OFU5SWFncUJB?=
 =?utf-8?B?MkFjblRDU1VmOElhRnhOdUExOEN5OG8xSTQreWkrT3hVRm9GRkQzNWk4azRI?=
 =?utf-8?B?VDZxNjhkTUFpNEFpS3A0c1M5T0ZzSlJaeVdyUFBIWDE0TE1jeVR0SHc4bFdD?=
 =?utf-8?B?akFnenFkWktvaE1BQTlONzBTc2xscFJHcXQ3a2lxMDJGbGlWNzVQZzlMRjNG?=
 =?utf-8?B?TDZ6OGdhSmhHTDIweDZQRDlkSUVhTm13elNJRFFWVlJld2xTOFVzUW4zZ2Vv?=
 =?utf-8?B?eVpOU2lOSkJGRHNUUnZoK3FTcVYxNW9QbUJ6VjRNNHNVMldoVjFoeXNha2lC?=
 =?utf-8?B?VncyMmVqMGo3RGlQdDhmVUhqZ1BNenZZbkNQWXU0Rlg1QjV4V01XcmVXMDlS?=
 =?utf-8?B?NDFqWnhiN2RYaTM2b25ROWNybGhEeFJUeW9yTC9xdnA5dmhobVhaQnRxNHRm?=
 =?utf-8?B?TXBDTnlyZUR6V2xxQ05mTy92WXFBUFlQQWhjck1vclEzL28vVjRPbGRtNGMz?=
 =?utf-8?B?Z21ROXdnN3Q5T3hsY1ZnK25WNEpLZDF0WHgzSzlYMXVtVjVwQ0xoZzEvcHVO?=
 =?utf-8?B?NE1ZVjV2bUd3WDhYTUtUUDF6U2NWUWtuZlNoZzJtMnlYdkp5cWlBMktsbDdU?=
 =?utf-8?B?NGZndUJ6ZTc5ZmpIdmVGd1RtbEZaSDZtNlZHMzczcXRWMFU2emlUTm0ycEVU?=
 =?utf-8?B?WnJBZkovVmZGRGVKMmx5dWJmUVZoUXZ3R3k3K2VkOUZlSWxna1I1cEpmR0pU?=
 =?utf-8?B?RUJ3eUJOazl2VS95QzVpekRzQmsrK3lVN3lkNmMyR1BPVkpJRVpvUzdNWlpX?=
 =?utf-8?B?VWw5enhlOEZEWnZHOW1aMEEwcTlFY2txaW11Y1RUYm5pOW9uTlljRWxUQnds?=
 =?utf-8?B?QVFLaEs4djd2UVdoSWRVWTYzWUdvc20wYXZVRE16NkJsTzNjREZSRmVJU3N3?=
 =?utf-8?B?dzFTNld6alhNWWlHbklrWVF6dGFFQ1pMUEZKRzZLdGhQKzdRL2EvYVZHbEpo?=
 =?utf-8?B?dG1UVWxma1phNUx0OWVpeHV0VjJCTFB6eGRjOUowbkdabXRxTEE5VjM2SWFE?=
 =?utf-8?B?eE9wNGVoaVBRTldCanZBcVRGalJMYms5dHZSS1AyVUZjV3FhTy9FdExsVjcw?=
 =?utf-8?B?NWx0aUMyWnZOUENzZk5iSFhQYWJ6SlUxZnB0eDdpVTdIMjFSRkJFWDRPQW1y?=
 =?utf-8?B?VTVqZkZIMlcwNjBuOEhlOFdscDJyb0NHcUo4RXdZNjNGSStoVU41NUswVm1s?=
 =?utf-8?B?UllzNzNJTE9SRmRrMkRValNQQUo4dFlJYnI4REFxcXlqRExrN3Z2NEpiR0hU?=
 =?utf-8?B?djMxZWFMQko4aEdyMVVEN2p5SEEyNGlNUXJDbVFzMy93NU1WNEJFeWhoRzJq?=
 =?utf-8?B?TzdWS1N5WHZHNUJzRFppaUQ1MGZjQXEvZTYzYkVTNEN5Zm9KU21QekhkdTFo?=
 =?utf-8?Q?d67YuFITa/HTnEUP2YuvfEPRwEYzi6hNpOvAyGOqESPv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6142f0b7-9d3b-4c4a-2cf2-08daac1c7a65
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:39:13.9952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SQdgrL0WvbSboQ9i+NvvJc3+ZD6wHzhs66tDTQ87Eqy4Iqna5eHQMX0YAdyzx1WbArjatrt7rW9SJS4eGXjbFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7142

On 12.10.2022 08:34, Juergen Gross wrote:
> On 12.10.22 08:28, Jan Beulich wrote:
>> On 12.10.2022 04:42, Henry Wang wrote:
>>>> -----Original Message-----
>>>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>>>
>>>> flight 173498 xen-4.15-testing real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>>>
>>>> Regressions :-(
>>>
>>> I think these regressions are from the backporting happened yesterday,
>>> see below...
>>>
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>   build-arm64                   6 xen-build                fail REGR. vs. 172547
>>>>   build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>>>   build-amd64                   6 xen-build                fail REGR. vs. 172547
>>>>   build-armhf                   6 xen-build                fail REGR. vs. 172547
>>>
>>> ...The arm/arm64 regression is from the backporting of commit:
>>> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
>>>
>>> The issue is:
>>> In 4.16, commit
>>> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
>>> changes the prototype of xc_shadow_control(), and hence the calling of
>>> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
>>> xc_shadow_control() in 4.16 and after.
>>
>> So did I commit a wrong patch, or were the patches for the older branches
>> wrong already in xsa.git?
>>
>>>>   build-i386                    6 xen-build                fail REGR. vs. 172547
>>>>   build-i386-xsm                6 xen-build                fail REGR. vs. 172547
>>>>   build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
>>>
>>> I think the x86 regression is from the backporting of commit:
>>> xen/gnttab: fix gnttab_acquire_resource()
>>>
>>> As the error message is:
>>> make[5]: Entering directory '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
>>> test-resource.c: In function 'test_gnttab':
>>> test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
>>>           (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
>>>                     ^~~~~~
>>
>> Hmm, I'm pretty sure I did a local build test of tools/ with this in place.
>> I'm not in the office today, so I won't be able to do anything about it
>> right away.
> 
> Maybe you didn't build tools/tests?

I'd need to check, but yes, that's the suspicion.

> I can send a fix.

That would be great, thanks.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:40:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420757.665757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVPS-0006g8-D8; Wed, 12 Oct 2022 06:40:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420757.665757; Wed, 12 Oct 2022 06:40:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVPS-0006g1-80; Wed, 12 Oct 2022 06:40:06 +0000
Received: by outflank-mailman (input) for mailman id 420757;
 Wed, 12 Oct 2022 06:40:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiVPR-0005ME-6g
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:40:05 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140085.outbound.protection.outlook.com [40.107.14.85])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b36fc7d5-49f8-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 08:40:03 +0200 (CEST)
Received: from AS9PR06CA0168.eurprd06.prod.outlook.com (2603:10a6:20b:45c::20)
 by PA4PR08MB5888.eurprd08.prod.outlook.com (2603:10a6:102:e8::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 06:39:59 +0000
Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45c:cafe::f5) by AS9PR06CA0168.outlook.office365.com
 (2603:10a6:20b:45c::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Wed, 12 Oct 2022 06:39:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 06:39:58 +0000
Received: ("Tessian outbound 99ee3885c6d5:v128");
 Wed, 12 Oct 2022 06:39:57 +0000
Received: from b564aa51bb61.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3812463C-0AA9-44D4-89E3-FE8ABB7F8796.1; 
 Wed, 12 Oct 2022 06:39:52 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b564aa51bb61.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 06:39:52 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PAVPR08MB9307.eurprd08.prod.outlook.com (2603:10a6:102:304::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 06:39:51 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 06:39:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b36fc7d5-49f8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=A0rjR5gFwf15VEYPNDjtBfCqKjZHaoS1MaQU7+Brs+Qg4kkYd4FntEEspVMhxovbsL44ZxM9XWqa5fFAsxzBchr8tswGKbKPz1ZQM9IlOmTW5CRP6GjLzwnHLB9jhiJza4/JOTfVxr9U/mDMbYOQbhhdHT49H5+JMh7SHCl6PAzu8KNy16n3IF85G6eBALO+9Vo+q6qGLj3S6oTfXn1NKK2bm6rCHcYhvXAKZxi0OmckbpINm+Ls01S5dyH6rg2pqZ8iUIUIE6caK75bPFPexWJ3GZ5b6pdcGb7CpG3+WWNrfJUDb2wtNsHWML5MlOFSFG1P55GraZ6IcOBSlR37cA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6O2fXGbZhBlxgDw1aJS9hwWvSe/3u4a0BYziEAVnHD8=;
 b=EQMNnBtbCkTNQ/z+hFtzGIlgiq9DTud6kVc/yEOYncoPbrZBmhKu1atScni7l4bpttJRZfmTq7C6/x5z2WMsCIdHOFUHCFbN6HBy/7ICBGI7Axf+xoGBR0pYlMQThbnMolBjlMsvhXcGl2l0ahVriDU0d+kNeMVxLgX5wvu2nVfXwycmj8GVxhU24NCvI+nhnP+xIYEh8HxyRs+mu8Hv8zwLGEDPdZOa1egSVIsRw3Ru6pOu7iBtYGHcm23NpJh5rTSVfIayjg7GHTsTdQGqSSBheG8MnpfaXrH9xCjll2O8YR+bvm4A3weHDwE4ejb9gTA4uH577SkXebUgKG/Icw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6O2fXGbZhBlxgDw1aJS9hwWvSe/3u4a0BYziEAVnHD8=;
 b=bIHs7xi8GPAM4Ee8RzdXlxSYN8/uKKOH9QS3+cBjFwnkWERBT8p3sx/S6O9HJ3aWKT6vs7HMjscqpg5w9d9BGLqhxWZHVFEv5ooSo/xBNdYkMdXWLmsVHCWzG0duVFPYIjIsA9+t+rqyYoxYWoyPSmXgG9jXGbamV5BBYkRM9yc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TYD4Bs58hS1AqV4dISDss7ZY3Q31o5DGAsbjbEcFgc/A++9geHOGNO4yARfq5KxrGwyMeba8tNIXlJ0AJ61DzGsC8feG1cs4EohQYMB9qLeu0w3b9k77tRLxZs/3gAGPj4OUqhLenEJro1aAouxrqE8UhSwRRREI+hdbMK+nhapLIO5qrtjmMB+ovuUx6EM8d31DdAbVlBTd9gdZjTEebvaYnYHipgG0gO9OTfDHjEVCbIP8WzBt2rTbX43t2xma+soz9NqkLvcJlX8OjrkEHMfbVExDD30GvwDIeEcLgm391PWgSyl9eu95+29p5lPyMzp498zbm35/Yi6HCbmJcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6O2fXGbZhBlxgDw1aJS9hwWvSe/3u4a0BYziEAVnHD8=;
 b=Qpnne6mtnkNonsxYXJpOvEfqjkRXT7aVaQRkyse3zDlS7HX9eRphq2qv3gfTasXYk171vK7hw4O2dK4qtZqf9qbAT/r5U/QZLHH9WuV0wtcEzwme+iaJiu75t//GxFOfU3eZytcOgRO4kbcWI+eeRpLBZ1Y2S7jBddDrMWqWYcUyAqCHlAqpFcD0SO/m6Y0Idv5nU8u/+cLgnVaMrfmHT9eqUsKRTHzmdTVQC53Q+Spcwg3Du5UTwQwHGzzOOGRfrxupFgHOZoSDa5GymiRZWja0XUvSKR9Zayxy9gW0wUF5WkqtOmH3m01dQDDQiu23HWDAXcm5dKlnB1Y77XTvqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6O2fXGbZhBlxgDw1aJS9hwWvSe/3u4a0BYziEAVnHD8=;
 b=bIHs7xi8GPAM4Ee8RzdXlxSYN8/uKKOH9QS3+cBjFwnkWERBT8p3sx/S6O9HJ3aWKT6vs7HMjscqpg5w9d9BGLqhxWZHVFEv5ooSo/xBNdYkMdXWLmsVHCWzG0duVFPYIjIsA9+t+rqyYoxYWoyPSmXgG9jXGbamV5BBYkRM9yc=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: osstest service owner <osstest-admin@xenproject.org>
Subject: RE: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Topic: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Index: AQHY3Y68aiBzpV7ZsUyzVLBH9N1mMq4KTrGAgAAAVMA=
Date: Wed, 12 Oct 2022 06:39:50 +0000
Message-ID:
 <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <osstest-173492-mainreport@xen.org>
 <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
In-Reply-To: <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 54ADE6885EAEB04DBB0417A789E0FE61.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PAVPR08MB9307:EE_|VE1EUR03FT004:EE_|PA4PR08MB5888:EE_
X-MS-Office365-Filtering-Correlation-Id: f040c6c2-ea94-40eb-71ba-08daac1c94f7
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 tNbCBGy0PWBV1YUxmqxryVFGS5LQb4YmOR1Kf4cyJre6+klquFQszyFhTns0bhw6jvFgSLJ8k/MShd+2GcjWSX0g1ls/kNSzi84ZlXor/ka0FPxoK1rn4+G1QDuq+G242zTApOz3tVm/IBd/SY7odcz/Doz+CqOXIWD116OTQYQIylO8tHbgkc7bQvescOk1cPxOlEhnN+5a1N6LygQASyeEe/rdQpxjcJCT8Oe+SRY6UrxQjyDlOv88yrxV8jP6sXuQHypDWosr6yR4D5sdD4kPvyVY5qeZ2P71t2VWEhZgJiBa48L3YdlgI8iaHPKrFFjjL6LoAJ00ZkCzfH3FDjD5iBxNPwcDHdo/g8isuqJliwggGHVkWgKaHqUiYJe2wc8LXxnRkhw2ZZGCkpvPr6cjoZc5IM5T4KnUZEwcp1nu8TTj5HHXvKRyycpC34IN6Q5sykeHkG7CwAwWNgLaPv683yRlXeS2W+gxfRlNqXyyYRT6TmJKd8TiPAUafa2rzsabd7iu56d62p1VQHkIAL1TAExoi7Oh5G8MSsKWUKEc3i8feyE381/ygVe4wanXvtXzVqfQtGY8VEXt3L8V2nmQru0nYg8WCqh9s9VvQ8Bcd1L3rz/xaVVlr4wuGaN1bMf3clCLua7sFG1DDyR02YhJHYXs+jf52/39+e0eYvd69Sg3CiOVxGSZw7DGFJ+UchMrVALge60OC2q0JFiRbsH/tDkfJ3MTlbYcHWBeCvdg9l53aKIk+b14iWxb0UUi+yL7F+44yB/KGcIbPKIujpDolFKr2C6P+wDZKHwcKDI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199015)(66476007)(83380400001)(7696005)(9686003)(53546011)(76116006)(64756008)(110136005)(66446008)(4326008)(26005)(66556008)(2906002)(186003)(6506007)(52536014)(8676002)(122000001)(55016003)(8936002)(33656002)(71200400001)(86362001)(966005)(41300700001)(478600001)(66946007)(38070700005)(316002)(38100700002)(5660300002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9307
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6f4ca304-749a-43dc-c1a4-08daac1c906c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OuT1UHpPwSVjTbwghBOK/pQ8tHbWyvVdQfVrciW/6UQ3M/eCR3Dm8xGmd3sBGM6Lf1n+sh1aB9gSEte71IDLR1JwDI1QgKcVvSjL9aWJTdE4RjfX8fFlbxIj+UMTo88bn+bXA2e0U6CVhtl4C6S/Zh1ATX0wOGXs5BgCH8ZTqvEoUv4Nbd6PjF0ZB55/5qklF4zCVwXmK0SpCXAmFvbGlsTPLiHvE4SUB6YiMyp5ae3U0qw68WZ+v5jUdgfn8Woz7qIpRkOdOugu07zQ6+hgzOuLiNKloV+/TtDFxOScIkjSbjtIzlB4KG6HUm75ysid6rOwMmtd8N0grjfwA8kQ/pcdj5VIZY61XTeZe7XgTtpYZ6vyjFNCNgA4O9reAv4A+1yX3HGtsXgFENY2fbcZq+ktjPNUwgrbZwWucfGVXiaYXMhS7EN+8D4fFbssvpI+yGd6Mcbvf/CYlNZCIu4ARC14bRmmTB6y+HEkaepABysc7xlUVA90ta8Ddg4K7sBsg8MVkhimkOS6S6wLltZQ7dpPWH4CaoaaS0X2M+BXiI9vEFd1LGJ3+Af+EYyYT5NO4J4KBHil+tRqrCd0fIr3zEXhn1OZGwYM3b/avzCv+dtTSFA+QSukvR1G1y2A4kH/Q1PWPJXBDm1rwmEzbibahhunJlBwqVbJli0TfSu8h0BleJKO2zswM+VffhSywblD5PiFX8l+PtwP+fqrIe+SnARIfWImsV4lac873uP1PtEAEIM4GItvAxtY/AVXqvx5Pd9MJ8MJ8c1G4eZL+94a9D8Sbe26fAtyIPWIK7nNzpA=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(70586007)(70206006)(4326008)(8676002)(336012)(186003)(2906002)(33656002)(40460700003)(47076005)(86362001)(52536014)(9686003)(7696005)(36860700001)(26005)(83380400001)(41300700001)(53546011)(5660300002)(55016003)(40480700001)(6506007)(8936002)(82310400005)(966005)(81166007)(356005)(82740400003)(110136005)(316002)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:39:58.3559
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f040c6c2-ea94-40eb-71ba-08daac1c94f7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5888

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJlOiBb
eGVuLXVuc3RhYmxlLXNtb2tlIHRlc3RdIDE3MzQ5MjogcmVncmVzc2lvbnMgLSBGQUlMDQo+IA0K
PiBPbiAxMS4xMC4yMDIyIDE4OjI5LCBvc3N0ZXN0IHNlcnZpY2Ugb3duZXIgd3JvdGU6DQo+ID4g
ZmxpZ2h0IDE3MzQ5MiB4ZW4tdW5zdGFibGUtc21va2UgcmVhbCBbcmVhbF0NCj4gPiBodHRwOi8v
bG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTczNDkyLw0KPiA+DQo+
ID4gUmVncmVzc2lvbnMgOi0oDQo+ID4NCj4gPiBUZXN0cyB3aGljaCBkaWQgbm90IHN1Y2NlZWQg
YW5kIGFyZSBibG9ja2luZywNCj4gPiBpbmNsdWRpbmcgdGVzdHMgd2hpY2ggY291bGQgbm90IGJl
IHJ1bjoNCj4gPiAgdGVzdC1hcm02NC1hcm02NC14bC14c20gICAgICAxNCBndWVzdC1zdGFydCAg
ICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTczNDU3DQo+IA0KPiBQYXJzaW5nIGNvbmZpZyBm
cm9tIC9ldGMveGVuL2RlYmlhbi5ndWVzdC5vc3N0ZXN0LmNmZw0KPiBsaWJ4bDogZGVidWc6IGxp
YnhsX2NyZWF0ZS5jOjIwNzk6ZG9fZG9tYWluX2NyZWF0ZTogYW8gMHhhYWFhY2FjY2Y2ODA6DQo+
IGNyZWF0ZTogaG93PShuaWwpIGNhbGxiYWNrPShuaWwpIHBvbGxlcj0weGFhYWFjYWNjZWZkMA0K
PiBsaWJ4bDogZGV0YWlsOiBsaWJ4bF9jcmVhdGUuYzo2NjE6bGlieGxfX2RvbWFpbl9tYWtlOiBw
YXNzdGhyb3VnaDogZGlzYWJsZWQNCj4gbGlieGw6IGRlYnVnOiBsaWJ4bF9hcm0uYzoxNDg6bGli
eGxfX2FyY2hfZG9tYWluX3ByZXBhcmVfY29uZmlnOiBDb25maWd1cmUNCj4gdGhlIGRvbWFpbg0K
PiBsaWJ4bDogZGVidWc6IGxpYnhsX2FybS5jOjE1MTpsaWJ4bF9fYXJjaF9kb21haW5fcHJlcGFy
ZV9jb25maWc6ICAtIEFsbG9jYXRlDQo+IDAgU1BJcw0KPiBsaWJ4bDogZXJyb3I6IGxpYnhsX2Ny
ZWF0ZS5jOjcwOTpsaWJ4bF9fZG9tYWluX21ha2U6IGRvbWFpbiBjcmVhdGlvbiBmYWlsOiBObw0K
PiBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5DQo+IGxpYnhsOiBlcnJvcjogbGlieGxfY3JlYXRlLmM6
MTI5NDppbml0aWF0ZV9kb21haW5fY3JlYXRlOiBjYW5ub3QgbWFrZSBkb21haW46DQo+IC0zDQo+
IA0KPiBMYXRlciBmbGlnaHRzIGRvbid0IGZhaWwgaGVyZSBhbnltb3JlLCB0aG91Z2guDQo+IA0K
PiA+ICB0ZXN0LWFybWhmLWFybWhmLXhsICAgICAgICAgIDE0IGd1ZXN0LXN0YXJ0ICAgICAgICAg
ICAgICBmYWlsIFJFR1IuIHZzLiAxNzM0NTcNCj4gDQo+IFNpbWlsYXIgbG9nIGNvbnRlbnRzIGhl
cmUsIGJ1dCBsYXRlciBmbGlnaHRzIGNvbnRpbnVlIHRvIGZhaWwgdGhlIHNhbWUgd2F5Lg0KPiAN
Cj4gSSdtIGFmcmFpZCBJIGNhbid0IGRyYXcgY29uY2x1c2lvbnMgZnJvbSB0aGlzOyBJIGhhdmVu
J3QgYmVlbiBhYmxlIHRvIHNwb3QNCj4gYW55dGhpbmcgaGVscGZ1bCBpbiB0aGUgaHlwZXJ2aXNv
ciBsb2dzLiBNeSBiZXN0IGd1ZXNzIHJpZ2h0IG5vdyBpcyB0aGUgdXNlDQo+IG9mIHNvbWUgdW5p
bml0aWFsaXplZCBtZW1vcnksIHdoaWNoIGp1c3QgaGFwcGVuZWQgdG8gZ28gZmluZSBpbiB0aGUg
bGF0ZXINCj4gZmxpZ2h0cyBmb3IgNjQtYml0Lg0KDQpJIGFtIGFsc28gcXVpdGUgY29uZnVzZWQg
YWJvdXQgdGhpcyBpc3N1ZSwgYXMgZnJvbSBteSBsb2NhbCB0ZXN0IHRvZGF5IG9uDQpkaWZmZXJl
bnQgQXJtL0FybTY0IGJvYXJkcywgdGhpcyBpc3N1ZSB3b3VsZCBiZSBvbmx5IHRyaWdnZXJlZCBv
biBzb21lIG9mDQp0aGVtIGluc3RlYWQgb2YgYWxsIG9mIHRoZW0uLi4NCg0KS2luZCByZWdhcmRz
LA0KSGVucnkNCg0KPiANCj4gSmFuDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:41:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:41:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420765.665767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVQR-0007Ih-OC; Wed, 12 Oct 2022 06:41:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420765.665767; Wed, 12 Oct 2022 06:41:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVQR-0007Ia-Lb; Wed, 12 Oct 2022 06:41:07 +0000
Received: by outflank-mailman (input) for mailman id 420765;
 Wed, 12 Oct 2022 06:41:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zRMe=2N=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oiVQQ-0007IK-An
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:41:06 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d86b81cd-49f8-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:41:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CCD411F37C;
 Wed, 12 Oct 2022 06:41:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8260F13ACD;
 Wed, 12 Oct 2022 06:41:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ypDhHYBhRmMKKwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 12 Oct 2022 06:41:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d86b81cd-49f8-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665556864; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Nl+ySH2Hy0TmPdpCGvYlAGDj4zROtpYB8MQhL5sxvts=;
	b=iIj/Nho/6liYpKPdsFxn6Pon/ZLel4ZyIrkSX894lB0maBuhIeZhEbE7pHwFf1KUCJvuKZ
	UKV/JZ/TIwldLkpCHsYjBEKcuPuBKtWnOKl20Pv4wjkW4OLIuYq7/KnW9d8MKMvgxFoU1t
	OEpeuYnu6rVDBRC3hCHEvjUU8tkXMt8=
Message-ID: <ef118620-486d-072a-4f0d-12a9757c6c4b@suse.com>
Date: Wed, 12 Oct 2022 08:41:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen: Kconfig: Fix spelling mistake "Maxmium" -> "Maximum"
Content-Language: en-US
To: Colin Ian King <colin.i.king@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221007203500.2756787-1-colin.i.king@gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221007203500.2756787-1-colin.i.king@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------CONNMaY0pNYVsgt9bIBLQVdX"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------CONNMaY0pNYVsgt9bIBLQVdX
Content-Type: multipart/mixed; boundary="------------l9r5jK4t18TqVqBB10oBu8pm";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Colin Ian King <colin.i.king@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <ef118620-486d-072a-4f0d-12a9757c6c4b@suse.com>
Subject: Re: [PATCH] xen: Kconfig: Fix spelling mistake "Maxmium" -> "Maximum"
References: <20221007203500.2756787-1-colin.i.king@gmail.com>
In-Reply-To: <20221007203500.2756787-1-colin.i.king@gmail.com>

--------------l9r5jK4t18TqVqBB10oBu8pm
Content-Type: multipart/mixed; boundary="------------r0dqWpWPY0zF3ozRRlcSDj5t"

--------------r0dqWpWPY0zF3ozRRlcSDj5t
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDcuMTAuMjIgMjI6MzUsIENvbGluIElhbiBLaW5nIHdyb3RlOg0KPiBUaGVyZSBpcyBh
IHNwZWxsaW5nIG1pc3Rha2UgaW4gYSBLY29uZmlnIGRlc2NyaXB0aW9uLiBGaXggaXQuDQo+
IA0KPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4uaS5raW5nQGdtYWls
LmNvbT4NCg0KUHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy02LjENCg0KDQpKdWVy
Z2VuDQoNCg==
--------------r0dqWpWPY0zF3ozRRlcSDj5t
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------r0dqWpWPY0zF3ozRRlcSDj5t--

--------------l9r5jK4t18TqVqBB10oBu8pm--

--------------CONNMaY0pNYVsgt9bIBLQVdX
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNGYYAFAwAAAAAACgkQsN6d1ii/Ey/Z
ngf+NCEIB+X69O6S3Ke3drn46e4Z+STRc1QHK+8BhY3MiO63AP1ym2u5mQ+LuGuniwP7D+/qlwa1
AZ2qa0VOLxLbpjJwtiVTTNx4Xj98sMKzfs88ErBkSvj5S00fMX9s4dj8yeF8CydovLjyq4bLp9rZ
EQ64Y+B7AUopfmynbK/JuAM7QWxC+p45sFPzJTSwEbM2kA/Pp2ARQZQmfulScL108ywPG0LThSa1
ZlTPIFFOtWOSW+TOypMk/SvLZXuPJ67B85awtH0eAx0bSsXlsDke1e0o3zKNqrDNZ/PMVGnrmGSj
U0hK96GDeJyMwTEULMi7CRnsoR7t2ncpLjJZs8mtlQ==
=/AKw
-----END PGP SIGNATURE-----

--------------CONNMaY0pNYVsgt9bIBLQVdX--


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:43:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:43:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420772.665779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVST-0007wz-5d; Wed, 12 Oct 2022 06:43:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420772.665779; Wed, 12 Oct 2022 06:43:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVST-0007ws-2W; Wed, 12 Oct 2022 06:43:13 +0000
Received: by outflank-mailman (input) for mailman id 420772;
 Wed, 12 Oct 2022 06:43:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiVSR-0007wd-0t
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:43:11 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 22a6fb4f-49f9-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:43:10 +0200 (CEST)
Received: from AM6PR08CA0012.eurprd08.prod.outlook.com (2603:10a6:20b:b2::24)
 by GV1PR08MB7825.eurprd08.prod.outlook.com (2603:10a6:150:59::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Wed, 12 Oct
 2022 06:43:04 +0000
Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::2e) by AM6PR08CA0012.outlook.office365.com
 (2603:10a6:20b:b2::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Wed, 12 Oct 2022 06:43:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 06:43:04 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Wed, 12 Oct 2022 06:43:04 +0000
Received: from e223bb904a97.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 374947B9-5377-4299-887C-12DA2B3D71BE.1; 
 Wed, 12 Oct 2022 06:42:53 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e223bb904a97.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 06:42:53 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PAVPR08MB9307.eurprd08.prod.outlook.com (2603:10a6:102:304::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 06:42:51 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 06:42:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22a6fb4f-49f9-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=je7qzIBJhIj1eGq8s5L4SiCRcJvlFVl//VLcUP5ho6RjVh5v+K3ypWoTaJRbJ90iRv9EnUXV4mVZ3n8BMQLhYRMzG8kxc8DlIPGaX6aawzN4C8YXmIXR/UnxCUz96EZzVaXpe90SbYeerrrjyRupNvZo7FjftkcEBNbSM4GddPJpZyV1jkvYXAF+egKrKLdFqCkoY26QKA8FGI7VYgnOhTxXCatKxxybvvb6ztWhv9XCURc21VNKCXzj76uZh4Zxpba6ZGE+ODe4tyhlh+kF5jRrv2KOgrwgdgpO+Veq3JGOfWUcsHXjCsjQBI6PMmleZW0prMtY/ptQGP1HdptcNg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u2mba0glZgU5sUG/ICggwLbmifDW1N4nzwqKJFMYVm8=;
 b=NcPNIUaaZwLpkPqd1uVYcpitY1Jmf1acDuk2XZ9unzGXJd2M9+la7f9XHJmCFsNXl6LtcrYKbE2N0wwHIw/XLV1sH39N3Idzx3qtzK0fa37RYqrx8A1A8Z3yUN8kAKxrYstAf+D4YEt4U4jJanGZvjiEJ0cwd3GYo30KRgAAqEE9yL9nsrl9FdG1O15Y/A9sZVFiWMR10CDOy5BASGZnNcu2RMN59Mohq024C+wzhI4Og4PNhen+jhADCabDZiMn5DtNLbrc346q4wU0WMwgCuDkTwviAcJ+fBIA7bg/q2SOlD4WgoYeG1rBrH///lG4kI6UQkEz7PPkE5ssQRUY4A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u2mba0glZgU5sUG/ICggwLbmifDW1N4nzwqKJFMYVm8=;
 b=dd8eLoiZAkgv3KbvqMNfeMPnQAcZddCNKe+Ybbgxv4GafEjYbk99ivS0n6hwe7ysrsHwANmgnd9USILt/Q7knOJ1H84QlhL4Ik9WLIHlO+lWvOMoRuVJnV6ZndmMDrhWemdzJLeVnDrziKcPC9AcRur5JIWIaSaX/0yX8I+hWZM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FfC3OK3OGPT/ZO5Uhaw8km840dPMKaFkgAl3Mcxxar2L/B8sb4Z7jOyrTBhjRhYpmh6wjFylITE6ARFfT75rzPhXFMQVEGBXhUQhbametOEjlc4UGZJrz1O/Q9xWRoQ/wywBRy6l26BI4j86KjA0Cmz1FKblqUYgjzCA79gKty/zxbmqo3ZSi0uch1iY/q5+iCt3++AK2TDJ67+lfF27AOET/6yRIj59S5B35vdGVsTWz8bCqvVWbih3fmtvjmG4Olwls11c60Xo+D1R2vGkp/rVwLft7yHMJ01kI1IXn3asuuAcSF/xdUrmIPVNVUPg8qackUIjR0qySfQDegu6QQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u2mba0glZgU5sUG/ICggwLbmifDW1N4nzwqKJFMYVm8=;
 b=cGDqrWS+xp3y45pf5l+jZ/OGw+/yORf3ADEHzXUNEjrd5Sup8OQfqHRirW7bIKKIpJNqOXc5hrr2HrKIoMaJHjjGPbXQIFsXxFBBgQrIPxl0UHMK1NEt2PJaHjvejV2GvM0+/WuDCcoQQspvdDxZQrJr5vD8Om7bWtJ7KtKzJBK0CWSn0ygY4Rqh2iqAmbjPhTySvrsJs9QdB4nzdpijPauNm5Pqpgq8gwqxbkm3Cos9pZgWK8ZPXgE+hdvyg+4Y9upfH2Ut8R/RrslO5rigqjF3BowlRO2WaRW469iztwhntJspr8RWUFj6jNAoqAJXXlTIDTAdvDUN66uTLfBF1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u2mba0glZgU5sUG/ICggwLbmifDW1N4nzwqKJFMYVm8=;
 b=dd8eLoiZAkgv3KbvqMNfeMPnQAcZddCNKe+Ybbgxv4GafEjYbk99ivS0n6hwe7ysrsHwANmgnd9USILt/Q7knOJ1H84QlhL4Ik9WLIHlO+lWvOMoRuVJnV6ZndmMDrhWemdzJLeVnDrziKcPC9AcRur5JIWIaSaX/0yX8I+hWZM=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, osstest service owner
	<osstest-admin@xenproject.org>
Subject: RE: [xen-4.15-testing test] 173498: regressions - FAIL
Thread-Topic: [xen-4.15-testing test] 173498: regressions - FAIL
Thread-Index: AQHY3dQtFH1xMEjYXEqV6So1jL4Dp64KChlggABBzQCAAANfQA==
Date: Wed, 12 Oct 2022 06:42:51 +0000
Message-ID:
 <AS8PR08MB79914768F6ACA39D7791BF4892229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
In-Reply-To: <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 8C34436AC558CD45A2CC334CD2F82B4F.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PAVPR08MB9307:EE_|AM7EUR03FT040:EE_|GV1PR08MB7825:EE_
X-MS-Office365-Filtering-Correlation-Id: 2f396c17-e3b6-4eb6-f468-08daac1d03d3
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ko+rtkCGPf9DRlc17fOn38elGdkLXeeshjGocEgOWKRQZOonn7J4LlcHoDUnt+aCszupjEQn9ZSosbcFxAPoOwNMwt+S3RpZ8hZg2rRo4kmi2tFmKbN8kuPt84vkavhqKMcB+TfY8Mob2phI+xfQe6CGgqZOvQIgzvWQbKrojzozRLd+Sfcq1Nwc4gjMJ6ndf6/cX+fH4lrs/QJMaCbslfyUBOs+usLW8bgGHpvSKhO5PkMefEpls/jhk8i2gNP5DONeo+My7qtbf3CDRGNmjrF7GoDs7hwbraVnlzTk84mV8yyVOt+wKOAxZ+pzLPJ4TqBZHgAUNgVtVwKKihfYXqxJ3NoH5GIa0JKN89vmUMO+iCyNJQXaIGKknwNbxh/SDCM/PG89WSgxQ+LEMjupBhMgYOixmNYkiKiSoCe6p8HsmSTzH6GrPCOnyOy7st2nn//LxLBPMBNqdnWfj1AKN7YG2JeSYXbWfyAtUWdC7mHR27iZgdXLOCoM1HBwcOFJYlhDuIOMswXd7eVRcwp6lIniZttOQMJVoZbOphWevVNNjNnPZCoFu2W24Z+ysXrW9Lt//jTDkEFkqr/94UamfC47fjmiipZ2wIpMXGn5eUU83SXz/wC3ZSY/027jvmuihFvIn9bby4uHp7CfugvBzLr+qODqrJVjLfZSD134I6ABcy+EMYPvlJ1ebsBF7L1fdQvqxnZ7Y7sM2jozT0lIVEVaN/9a/kwrdU60/ou5lMchdYHRXtnIiJot2MGRe0MRGHXUQ7GOy4hTDAbw9nMFzGcoLnFXvYf019QtatIh6Kk=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199015)(66476007)(83380400001)(7696005)(9686003)(53546011)(54906003)(76116006)(64756008)(66446008)(4326008)(26005)(66556008)(2906002)(186003)(6506007)(52536014)(8676002)(122000001)(55016003)(8936002)(33656002)(71200400001)(86362001)(966005)(41300700001)(478600001)(66946007)(38070700005)(316002)(6916009)(38100700002)(5660300002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9307
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	eb5ad310-ba30-49eb-800e-08daac1cfc1e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eSAhaIBlp/M2qmZfL2EkusRGxmBqfWe5oNTq2ofKVrKBywtPMYv50OfaGL+qNxG8xiv8972DRNch9gC2Jr5CwxN6eLe6KjIyXvfcEVzbnF0jRSQt46fbfzaXh1XhAwNPWnknm6fbj0OUz1630lSI6KPZkCOZDgI+9uaMooLBcC7jtQBOdoBD2Y3vvdxTPMVVQoGeKsH/lJtVb7JYB9gIgd8PIqgAzR1q0+pavvGkXiiGMkfyoZl9Og+ZEt8WRT1kL4z2sTuExXlQlARP7xPK6EeUbNImgstU7n47GnmeDKxzu1jrzfMlS9vmjIEEDmv4s5jf2kjW7QWbf1yotcMgBWhMps49LYuLte+atNVK5KvcsXK4VtYcTA8dwmEW2J7CSNwLBXhGhREE1OaLLQDm9Hjp0xmu0S+doSHsimBS4jZFv6Jq2ToBYw+g+gVi/XUlaK5355C6+I4qtLll33u5BQEwfagr53bWkFIL7O5Xd6a+DDzTB7UtlvJ93/P4N0GPnVXQlWhzom1Yyjc/tn89Q/uExKN1oLlGYFZRjEj0dMrK7vrndgJzhdv1OyGJFBsmJDkW7R2S0BsyWNdhOmMQBHuH2Aeicmvd/7ms2NkfW3+AxVLdGCwSPTZ6CrtPgOvAs414EAtuRJSKZunsMIse8T8VRkSh5rq2zU2soAwjmhfG5cXDoRlO6AQo9loMgImupD4T1jtWhNwjFdObltuTObQ+19vK61YmGg/9/6oGbFB2wqzYkv7bC3xkhj7LS94ZwIAFr1FRKcXJ+uL7MPspFgb64Z8z7vYzk1dgcJVsank=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(356005)(82310400005)(81166007)(966005)(82740400003)(478600001)(86362001)(54906003)(40480700001)(47076005)(33656002)(336012)(26005)(52536014)(186003)(36860700001)(316002)(55016003)(83380400001)(6506007)(7696005)(40460700003)(53546011)(41300700001)(2906002)(8936002)(5660300002)(9686003)(8676002)(4326008)(70586007)(70206006)(6862004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:43:04.3972
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f396c17-e3b6-4eb6-f468-08daac1d03d3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7825

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFt4ZW4tNC4xNS10ZXN0aW5n
IHRlc3RdIDE3MzQ5ODogcmVncmVzc2lvbnMgLSBGQUlMDQo+IA0KPiBPbiAxMi4xMC4yMDIyIDA0
OjQyLCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K
PiA+PiBTdWJqZWN0OiBbeGVuLTQuMTUtdGVzdGluZyB0ZXN0XSAxNzM0OTg6IHJlZ3Jlc3Npb25z
IC0gRkFJTA0KPiA+Pg0KPiA+PiBmbGlnaHQgMTczNDk4IHhlbi00LjE1LXRlc3RpbmcgcmVhbCBb
cmVhbF0NCj4gPj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9s
b2dzLzE3MzQ5OC8NCj4gPj4NCj4gPj4gUmVncmVzc2lvbnMgOi0oDQo+ID4NCj4gPiBJIHRoaW5r
IHRoZXNlIHJlZ3Jlc3Npb25zIGFyZSBmcm9tIHRoZSBiYWNrcG9ydGluZyBoYXBwZW5lZCB5ZXN0
ZXJkYXksDQo+ID4gc2VlIGJlbG93Li4uDQo+ID4NCj4gPj4NCj4gPj4gVGVzdHMgd2hpY2ggZGlk
IG5vdCBzdWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcsDQo+ID4+IGluY2x1ZGluZyB0ZXN0cyB3aGlj
aCBjb3VsZCBub3QgYmUgcnVuOg0KPiA+PiAgYnVpbGQtYXJtNjQgICAgICAgICAgICAgICAgICAg
NiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcyNTQ3DQo+ID4+ICBi
dWlsZC1hcm02NC14c20gICAgICAgICAgICAgICA2IHhlbi1idWlsZCAgICAgICAgICAgICAgICBm
YWlsIFJFR1IuIHZzLiAxNzI1NDcNCj4gPj4gIGJ1aWxkLWFtZDY0ICAgICAgICAgICAgICAgICAg
IDYgeGVuLWJ1aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3MjU0Nw0KPiA+PiAg
YnVpbGQtYXJtaGYgICAgICAgICAgICAgICAgICAgNiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAg
ZmFpbCBSRUdSLiB2cy4gMTcyNTQ3DQo+ID4NCj4gPiAuLi5UaGUgYXJtL2FybTY0IHJlZ3Jlc3Np
b24gaXMgZnJvbSB0aGUgYmFja3BvcnRpbmcgb2YgY29tbWl0Og0KPiA+IHhlbi9hcm0sIGxpYnhs
OiBJbXBsZW1lbnQgWEVOX0RPTUNUTF9zaGFkb3dfb3AgZm9yIEFybQ0KPiA+DQo+ID4gVGhlIGlz
c3VlIGlzOg0KPiA+IEluIDQuMTYsIGNvbW1pdA0KPiA+IDIxMDdjYzc2ZGIzYSBsaWJ4Yzogc3Bs
aXQgeGNfbG9nZGlydHlfY29udHJvbCgpIGZyb20geGNfc2hhZG93X2NvbnRyb2woKQ0KPiA+IGNo
YW5nZXMgdGhlIHByb3RvdHlwZSBvZiB4Y19zaGFkb3dfY29udHJvbCgpLCBhbmQgaGVuY2UgdGhl
IGNhbGxpbmcgb2YNCj4gPiB4Y19zaGFkb3dfY29udHJvbCgpIGluIDQuMTMsIDQuMTQgYW5kIDQu
MTUgZG9lcyBub3QgbWF0Y2ggdGhlIGNhbGxpbmcgb2YNCj4gPiB4Y19zaGFkb3dfY29udHJvbCgp
IGluIDQuMTYgYW5kIGFmdGVyLg0KPiANCj4gU28gZGlkIEkgY29tbWl0IGEgd3JvbmcgcGF0Y2gs
IG9yIHdlcmUgdGhlIHBhdGNoZXMgZm9yIHRoZSBvbGRlciBicmFuY2hlcw0KPiB3cm9uZyBhbHJl
YWR5IGluIHhzYS5naXQ/DQoNCkkgdGhpbmsgdGhlIGxhdHRlci4gRm9yIHRoaXMgY29tbWl0IEkg
dGhpbmsgdGhlIHBhdGNoIGZvciBtYXN0ZXIgYnJhbmNoIHdhcyBwaWNrZWQNCmZvciB0aGUgNC4x
My00LjE1IGJhY2twb3J0aW5nLCB3aXRob3V0IG5vdGljaW5nIHRoZSB4Y19zaGFkb3dfY29udHJv
bCgpDQpwcm90b3R5cGUgY2hhbmdlIGluIDQuMTYuDQoNCkkgY2FuIHNlbmQgYSBmaXggZm9yIHRo
aXMuIElmIHdlIGRvbid0IHdhbnQgdG8gYmFja3BvcnQgdGhlDQoibGlieGM6IHNwbGl0IHhjX2xv
Z2RpcnR5X2NvbnRyb2woKSBmcm9tIHhjX3NoYWRvd19jb250cm9sKCkiDQoNCktpbmQgcmVnYXJk
cywNCkhlbnJ5DQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:45:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:45:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420779.665790 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVUd-0000JS-HX; Wed, 12 Oct 2022 06:45:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420779.665790; Wed, 12 Oct 2022 06:45:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVUd-0000JK-EU; Wed, 12 Oct 2022 06:45:27 +0000
Received: by outflank-mailman (input) for mailman id 420779;
 Wed, 12 Oct 2022 06:45:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zRMe=2N=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oiVUb-0000JA-LT
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:45:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 730e5eb8-49f9-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 08:45:24 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3B71C22529;
 Wed, 12 Oct 2022 06:45:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0744813A5C;
 Wed, 12 Oct 2022 06:45:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4tpkAIRiRmO3LAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 12 Oct 2022 06:45:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 730e5eb8-49f9-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665557124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=pfSBOvu1OjtBmklXcnPKbzHd/cYxESBbfDXDCYhcEtE=;
	b=kzVeL9jJSSEXJ7XZEyVllcu9uwCi6gWxGyYSmMqxxFFCUwMpR2IwVQFjnbhA0jR5kY59md
	CSWj4VG/hD7hJ1Em2z17jbV8rNs9glyE8ebi5oYAqcvpnhriYa890kJyrbbKmla7tAWKS0
	y8PBYs50+IxWHiiVGU03h+mh6fmXwWU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH-for-4.15] tools/tests: fix wrong backport of upstream commit 52daa6a8483e4
Date: Wed, 12 Oct 2022 08:45:22 +0200
Message-Id: <20221012064522.6827-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The backport of upstream commit 52daa6a8483e4 had a bug, correct it.

Fixes: 3ac64b375183 ("xen/gnttab: fix gnttab_acquire_resource()")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/tests/resource/test-resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c
index bf485baff2..51a8f4a000 100644
--- a/tools/tests/resource/test-resource.c
+++ b/tools/tests/resource/test-resource.c
@@ -71,7 +71,7 @@ static void test_gnttab(uint32_t domid, unsigned int nr_frames)
     res = xenforeignmemory_map_resource(
         fh, domid, XENMEM_resource_grant_table,
         XENMEM_resource_grant_table_id_status, 0, 1,
-        (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
+        &addr, PROT_READ | PROT_WRITE, 0);
 
     if ( res )
     {
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:48:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:48:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420785.665801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVXS-0000wl-Vw; Wed, 12 Oct 2022 06:48:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420785.665801; Wed, 12 Oct 2022 06:48:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVXS-0000we-TC; Wed, 12 Oct 2022 06:48:22 +0000
Received: by outflank-mailman (input) for mailman id 420785;
 Wed, 12 Oct 2022 06:48:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiVXS-0000wY-CT
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:48:22 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130074.outbound.protection.outlook.com [40.107.13.74])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dc6b93d1-49f9-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:48:21 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB9568.eurprd04.prod.outlook.com (2603:10a6:102:26e::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Wed, 12 Oct
 2022 06:48:19 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:48:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc6b93d1-49f9-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xa1bQg0Yc9WlAZtzyTSWBkqLkKAksy+j+0RzmJ6vVpALXRhF/5BBK/IVzhD4XnTKbLXut81xYG8bU6MXI3ipvJmB6pkmLR61+6pjb2glmSdzEAWpsszUbIIjvF+bgCUVXjcxsOil5qAw+Alt4b0fYCa25Gx95Xu2/Mcl3HUQwTE9n08xB/iHJgv+stiG4MpoJu8mSEo6e43sdU6o+oBeAvZEBgTsK4Wi0cpUcCmZc2yldi79W+qyPqWwbv2Sn0xGK3rmYQbN/ZKoeJ4wfMKwHS8ikVAWWDt2p7TsfFNkNNy3S81HK/mh7AHRGIdMfnjFbtH8EBjAbc7sHtKAe6bXYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JjKEDje4nY+oSuLik7PY4Gm+zFBTltU1BPC2buuTfjo=;
 b=di59K9raWGbgqontxefxPTsz8fyDe+fSOsGTCwcuOzs4h94QWiwC10pk9W2XCI3ibgCO+1dkxYxVnlzyUwOQvmwM23LUptQEadiV0gdWCMQJa11H1933Vim7aM2mU0TzKNBBiBQZ30n7/D142RPG2ByMSw+r7pF8LToAa5PozFmWGatWu4ld95uGdv6/Kng19kN/sC49mEaVtZdSvWMljRvpKHLfjgp5RdCLaizwbt7SsDeNXKIRg6WB0AbnLnnsOSsdFVCzNPqMmWM3CSLw1t3Bf2dS+TWDcbSmAzgUhOvWb3tNNDd0OoQweJ5KOISh7VDIAh9I0pF34W9TP0B2kw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JjKEDje4nY+oSuLik7PY4Gm+zFBTltU1BPC2buuTfjo=;
 b=rYWsNHIvm4D2RLquVfHrRMY5rK9FlIB9NezKiGC5fnEl6hBJJT6vekMjuYwVuipps8daFsJQN6/Lou6sOIRomUdTx4iTNd9W+Wwk2ha09jnyrpM+2uNchDxyfFEL5Q89gheYtFpReIpfs+5EsCh0tqcmoItAyy0Y3Nw+vDOS/lv/A++JyQJ/WRkmoh1vT3tpXcbFzZQEfMEasCK63aG45tTgZ0Gue7EovFFWZw7x4hlqZSQTiG7qsdX7uwHDeqck9puETNV4jT8FBivKD/R69IcTVK55M0eDTzH8gWLtXLy5QSiXkLro0EknZ7Ns1pc2URYC2w2i91NlQFgalcI1Tw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3b0f71b0-1190-1a5a-fbf1-6c651e4f4745@suse.com>
Date: Wed, 12 Oct 2022 08:48:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 osstest service owner <osstest-admin@xenproject.org>
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
 <AS8PR08MB79914768F6ACA39D7791BF4892229@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB79914768F6ACA39D7791BF4892229@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0014.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::24) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9568:EE_
X-MS-Office365-Filtering-Correlation-Id: 23741176-a940-4ae4-e2a8-08daac1dbfb1
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jPP9ei6CxTn+m2wjWZLXAQeYW2yJAKBS2qeFRJtZ4ixDQm290oZulOCpGGdwn5i4IT5rONihwycQxB45CPN10l87TA0TxA6T5RbDpXHjAU+sFUn4VCgfdOml5TNOiY+CHXytmFOHetVy4Q9GnDCZctNbG3f+vw8+PRCx8O9ZZ3EzNFBi7jGPmk3hmOK2O8EIYJrFprPuw+BnaEZL7BlUqWM82CVfG1UpHSyx70AiAgVnRrsnWoV72rrhjOYzJYo+O7kK6jktRvcaJHX+h8g0lnuE0o6dzVQdn8JXVTS0NGemfN10ujBVpyb2x9U+sKfaF+/DkQZEHHf9mKmltX7rSg+SKYQH8RN1EE2E1rTI4XZmYzBqDJrXMlI7VNH5peRi9EgE3nvy5vt3qpvlnoPE6XfcK6MeBHYC7AoBM3h6yKMHbdZUbLQ2G2lNnMrgDaN2XleEh3E5dQB5i67/zNmjKQPDIKKfKjBGhXnIf1RjFjgi3Qa/zAQ6RBMxYMGuKPc0qowO4qmTq+l7AvCgZtvAEgNRIy0DPWPRkobnxqs9qNvwW/Mxr3golEtb+eBiEGULuxm+XT2qg8KtFg9n3432DBC06ZHcnfXAx9IPGMlMvuWQwJ6wOupsG6iqXes8FCYdznooJROiUAg0tdjbn3kL8tDblA+Di2J8md6Yj/fpyIWOhcWDBQRXnAs7PCRO52BiLvveoWI6xbVy6y6RDyxscYRamWMTa0pA1JZTKNWP7g7O9Ej4G74zxC5dEFKXQrruQ3Kx+llAk2ZXmDvMLVsxoTXTvgnXjeReeeacJ2cxmVnVp+PzoznMjOzyMK3fMjhPktRNqA7ZxOwdu8w3r2e4Ug==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199015)(36756003)(38100700002)(316002)(6486002)(54906003)(110136005)(8676002)(66476007)(2906002)(8936002)(5660300002)(66946007)(66556008)(41300700001)(4326008)(83380400001)(2616005)(478600001)(966005)(6666004)(31696002)(186003)(53546011)(6506007)(86362001)(6512007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzFpbDBGR3ZIbENyb29RZWQvbHNHNVFkbU0rN0pTVklJQXZPMWYzMVlYcUlC?=
 =?utf-8?B?ZTFsNG1yTFZadVJ0c1R2Z2hKZzZ1VW5pbFltOWxTdTZjVU8rSlViamVKRlFu?=
 =?utf-8?B?M2VpVGdoQkxSMHNCRjZ0U2tQYUdCYkEvSndZZXBFR3J1allrNzYyOHd6VEUw?=
 =?utf-8?B?V1hvMDZ0WEdmbUlwN0JBeWo4M2pqT2R3NXgvb0pIWUlMSHZZTFNGbWsvcGJk?=
 =?utf-8?B?UFJuKzAzaGVjOUxmY0JRU3NYekdnNWp2K3JCQUIrOFExVFZYR3RvTld1MnVR?=
 =?utf-8?B?aHppQkxaV0UyaWh4em9SVm5TMFpTMWZveXB2RExaYTVMODNxZ3kxZk42Qndo?=
 =?utf-8?B?VVJqK0Mrc0VLTC84SDRmOGhtSTlkSk5reFdCa2hpMmFIT2hqaE5DQ0hOaExs?=
 =?utf-8?B?UkkrenFaNlB5dzVCNFlBdFl6azgwYkJzMjhzOG1ZN0FETmh3NzRRbkZ2RURu?=
 =?utf-8?B?RStXeHNWcVlXTjhqZktFME9ocStsbkg3ZHRramFxM3FsRTgwbEI1UXh4MzZZ?=
 =?utf-8?B?QUhLTlVESERhWkE2Tm5LcklFcHZLRWYreE9tZFVmOTRFeTdsejJrekhHLytx?=
 =?utf-8?B?QnNSRTN5azdxcTRCU2JCTi9GSmV6ZXRqUFJmdFgxV2E5aFZzZW41cjFDSFV6?=
 =?utf-8?B?ZmhnR2lZUitmVmhJbUJhU01Ma3puOGRZdHRXUGFVcGcwU00rNXphc1Y2TlZs?=
 =?utf-8?B?MVliRW8wWkpySzV1YzlWRGVxSlRKRHZTUklEcVBuMkxBZ2FTcFF0aWhGN2xw?=
 =?utf-8?B?THQvbUdlNEVlbUxpSGEycWNYZi9Qd2tCL0tET2lCc3RMM3pDdHNtTGE3OUh5?=
 =?utf-8?B?Y2JBM2oyRzJhSWxpQ0NLU1VaUWdiVnpIbkloK1lyeWVUcGc2TnA3S2JlWGR1?=
 =?utf-8?B?VzlKRGZiM3dFbzNNblBIeXBxN091RUE2M2RvWGpQSXVXV3BNK2NKbEp0c1pv?=
 =?utf-8?B?a0kxK3JJd3dHeTlxblRMa0JOZHlNc211bzk5elF5aC9iMFU2V2pKMnR3ZERW?=
 =?utf-8?B?Q2U1V1N2dVdVemVXUnMxdXdnMnZUNVdjMjdiTmNTVnFUZ3FXc05sOWlaeks1?=
 =?utf-8?B?TjBJdEpEV1hiMERTMUxBVk5GbGZFQytObFE3djlJRjBwWlNXZ1g4Qks1T1Vx?=
 =?utf-8?B?b0NZc0tLVHNJd0ZLQ1NWZE54Y0FWTU9MZ3gvUzNWVmRBZVVRSzBnNEVadE9k?=
 =?utf-8?B?elJsR29RYmdxY3pBczExNkk4SHhXbDl0d28zbDJVeGxUVnJZMGpadWVSbzZs?=
 =?utf-8?B?WDZCVE9QZm53TjI3YVcwSGZmdVFBd0ZlZmRRZzlxaG5OMW0yckpxMGw4U2tW?=
 =?utf-8?B?QVJKYXJsdUM3cDRkUUdJKzZVUXVSb1JwbC9kQldlQjBMdU5nM3NndVYxS05P?=
 =?utf-8?B?NnpFMTFuQTBLMzl3Szc0U1J0VW43SlB1VitLS1g5TFZxdkdPald2NlVaTi90?=
 =?utf-8?B?TjNQTnJsYjdpa0RQUHlwb09GTkFuUk9hdWN2M0paZERrSDlkd21DU242Z3NQ?=
 =?utf-8?B?NlB4RWozYXR5dytwWXFzNm5lQnVNdlRIZXpsR29lZkExZDlIeTI2cnZac0Mr?=
 =?utf-8?B?SkNVRU1Vam5Mdnd3bEt3SWJNRTFsRmFQa1NaZzNnalZMYk5pL0JEZ0V2d0NF?=
 =?utf-8?B?RkJ2OHNMWFY2bnNaNVNDR0loZ3Fuby9lRy9hWHR4a0YyZHVtbFhtK1AyYVdS?=
 =?utf-8?B?SzR6K1RUTG1ZaWY1VVlDcWZGU0VobEdpRFRrN3BwQk9XcGh2STZGUk1yNE40?=
 =?utf-8?B?OVc2elAzWVQ0ZHBhUUQyOTNSWXlBc1QxMmg4TUtHWTdMZDQ3L2NsNnlSZThP?=
 =?utf-8?B?bW1ZU0hiMXZBZFV3QWRQWkRFdm14NnQwYUw1SlkvejBKL3BzK1BPLy9tSWVK?=
 =?utf-8?B?Rk1PMS9yWGNUSEk3eW9yZGdBZmxyZ1ZsSzRscVZlR25DbVluUy9McytiUThh?=
 =?utf-8?B?a0Z0aUo4NHNQOHRrbE1mM21ybTFhTFE5dFNxQnRKaS9xWnAwSGdoT2ZFOWNV?=
 =?utf-8?B?cDNNc1Z6STdXWTZIUHhzQ1FwMWVLWTR1ZUcxRk1xbWk5LzVrUzdMRW5MQ08x?=
 =?utf-8?B?R01ZYWhoV3Y5dUljZWxzWm1PQmp5WHBjS0E2cUNONlF1TlVycjc2THc4OEpO?=
 =?utf-8?B?MTVrNFFmeU1JWUlEZ3p5dEwwWFB5SDZrUmlnZDJldFNJVUhNdDZ6WHdsa1BF?=
 =?utf-8?Q?tQO5kbPVysnuYgqVSnB+UyYpKTDl1smBnzt/MpsbBoFX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23741176-a940-4ae4-e2a8-08daac1dbfb1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:48:19.7887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HG0xqwVoOiNOBEuVqYZo06LNZ/BRfu6A1Vp990F53emAhYKi7Ts7sVUzl/d4cKSxnvwQP86HV91ntujhrVS5Pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9568

On 12.10.2022 08:42, Henry Wang wrote:
> Hi Jan,
> 
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
>>
>> On 12.10.2022 04:42, Henry Wang wrote:
>>>> -----Original Message-----
>>>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>>>
>>>> flight 173498 xen-4.15-testing real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>>>
>>>> Regressions :-(
>>>
>>> I think these regressions are from the backporting happened yesterday,
>>> see below...
>>>
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>  build-arm64                   6 xen-build                fail REGR. vs. 172547
>>>>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>>>  build-amd64                   6 xen-build                fail REGR. vs. 172547
>>>>  build-armhf                   6 xen-build                fail REGR. vs. 172547
>>>
>>> ...The arm/arm64 regression is from the backporting of commit:
>>> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
>>>
>>> The issue is:
>>> In 4.16, commit
>>> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
>>> changes the prototype of xc_shadow_control(), and hence the calling of
>>> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
>>> xc_shadow_control() in 4.16 and after.
>>
>> So did I commit a wrong patch, or were the patches for the older branches
>> wrong already in xsa.git?
> 
> I think the latter. For this commit I think the patch for master branch was picked
> for the 4.13-4.15 backporting, without noticing the xc_shadow_control()
> prototype change in 4.16.
> 
> I can send a fix for this. If we don't want to backport the
> "libxc: split xc_logdirty_control() from xc_shadow_control()"

I don't think we should backport that extra change, but Anthony would have
the final say.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:49:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:49:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420791.665811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVYA-0001XK-CS; Wed, 12 Oct 2022 06:49:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420791.665811; Wed, 12 Oct 2022 06:49:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVYA-0001XD-9i; Wed, 12 Oct 2022 06:49:06 +0000
Received: by outflank-mailman (input) for mailman id 420791;
 Wed, 12 Oct 2022 06:49:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiVY8-0000wY-LE
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:49:04 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130074.outbound.protection.outlook.com [40.107.13.74])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5d08363-49f9-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:49:04 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB9568.eurprd04.prod.outlook.com (2603:10a6:102:26e::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Wed, 12 Oct
 2022 06:49:02 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:49:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5d08363-49f9-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PzZkM6+HhVhyfqD9dgvDepVgriwIqvogd/BtD+YuXVsgYkcILczJCXSgRvkM63qF5eiegYXMtjaU2+9UpHPijlFOvwtWioJ/AMn0IvTou9cWFn+aIqZ6//U/lYcpElxcowy+R6hy3DUJ0pWn5cCEnOKgRhoUuVCv7fQ/PuPktxU2TH5MDgyvPzaowuDFzBTt57kcwMFgda8iINxfs7kpE/zS0gU9JKghnUWujkxdzwbYYQoH1FL53ht4y66NtW3UkpK426gx56OfpS3Hl+/Szr4Ybx50Rxgvt7izuw4h9qhiIZiqlId2blSugJLDykbmFy3+uCD9TmudXgHAZHJBHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NmEF/J40oEYASYXTpa+WuTu//in8iYvQMdD2H/ckOq0=;
 b=iB77ROTQhZ1+/41lg3sEMDbEHMHCuq4BXt1P9sqKxDadRCB/cMeGfsP5nXRz/noGHzI1zrddN6VziBtjPQ3Ex5TmgMUonlcOHkAfuEXTexMMbWevOP/Xr74IeeIQak9GFkDC91ckCo9dZ1ZNT9mAr6Lif/YUX60ZzDvz41X9lhAK2fQWLEn9+JpFvAygq9OBXiVVViqlHmvMVMGpwrWZUUf+NDcCQ7v9+WRzE8l6BaUAl/N4hl/cNEFIUrw60h5Kd9Ec5WTn2YTsiGAUGfrLo3mIiQkh2yIjgaLLMu1iIrVKvprBPZjN8pCzNZTeLb3isJV0lhlEROKBcrTWx9VayQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NmEF/J40oEYASYXTpa+WuTu//in8iYvQMdD2H/ckOq0=;
 b=xZlD4F881oH/b3QwWjkMzcMD0AjuNvbq83D+U7YTVtKh72h68Q4/MbO+sBjuWfjZsjCAqKUzHsA96rqc7d8rfk6LBb7XMfku83yoG6Gq4FdMZqWsPSUqR+Q8u2TagJpwtOaNa/xxxfKeNO5qnT7fz6h0/uGTZCytFzvhOJ9kbQK8GxkKWI7cdxgv/AsoKU5BI+fYa1PvA+tT6BD42hcGKe8s13Zadyo2pxwLJ/00l7y8eVVoebc72+RwHhnUCqort4rLRXFzg9fW1PSkk5dalVFXeul65Mj4OJ5xy8v1wj0AbEgc+MTY7ZKlHqh0YT9zHEx6BGGWQpHBDzbVlmxcOw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a946d0cc-9a2c-3541-7f78-c32d5b2c804e@suse.com>
Date: Wed, 12 Oct 2022 08:48:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH-for-4.15] tools/tests: fix wrong backport of upstream
 commit 52daa6a8483e4
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221012064522.6827-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221012064522.6827-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0018.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::28) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9568:EE_
X-MS-Office365-Filtering-Correlation-Id: bb521913-c5c2-40d4-4db5-08daac1dd91e
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xd75LSBW3MekzKW01PIDUw4sYXsgQo5mP03/3l71tjkR4oaBhn5c5C9IzVcBwwX9HTrpxillNKwqPRG09iPC5lCg+7h2I0mrld64i4fY1uGy8g0QS5esNBef7bWEzC4wR1r8rgqsNZjbhdii5Yb8r51bQxed7GOFMaP4ubK15U7pkYt0kPRYgNVN8sTTYfklxN69bmPuVHG6aWiPgIKQBV3OPYpzV69h77SKT6HSlxpqRcUwO0C24ntXN0c5Igq8mC6RwQBPf8T4lDaaOGGUiQQfuPRSogZOPqfcJLE70GDQJVT3PWBhVIVOQlJY17Z9we/z/az5o6S8w/C43DVYVndDVPA+BCcb+3UB2l/bv0Qj8AgzvUkAeatpd12OXvixsNjP/fibLoqD0XKZKzc9CEs9hh2UNXVinMdQFV0osig1Vll9uKMjOcDmxUEuGFHXaXvyfo8UXj2ND6GWu2UA60f6sBecs4Ct/m0LWa4SURAgDb1SmupnmfB263w34n7yqAP5jvSMX06Fwhss5D98yFlrauiJHhjvmfkppF8+F7umwNCoxiYrpoiMHf9X5bbHWl78ASrgjt3HQXgltkkvaxScmjKHBCihJVMbOn5XfCb5ACE7xXlFMPSvRTum00ZchVgOQBZLwYghX1IW9QO5t2miO6DEUq/IDNUqJW+CiFmVjkWRfrCUa1tRb6lAe/uVn3IksDN9X+1xLi4MP1jt2aYL09kN0kgwC5vGr/1tbZtBfD+0mWb09VnNm5+h6szwwcoxu46uQkcWrw7Wjy/vUUnRKyGZlef9vaRDFCZidqYthNU/2JxKLwNvpQZc/TXO0HjvcjUC2KC+umdmf9ZUXw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199015)(36756003)(38100700002)(316002)(6486002)(54906003)(37006003)(6636002)(8676002)(6862004)(66476007)(2906002)(8936002)(5660300002)(66946007)(66556008)(41300700001)(4326008)(2616005)(478600001)(6666004)(31696002)(186003)(53546011)(6506007)(86362001)(6512007)(31686004)(558084003)(98903001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ekVOaW9CdDYzN1FpZmgySnprbEZtZTkwSjExWE1WUkN5UmtSZjRYOFR2T0E0?=
 =?utf-8?B?VmlnNFlUTWlvdy9NWTRacjBYbmNGWjJuRUhqSG96eXJCLzBWL2Zyd3RuYzRp?=
 =?utf-8?B?Y1hTWTZsaFBoUkE1MzVjcFVRbThRNFIySFowSFdzbW84R1B3RFRqSnRKanls?=
 =?utf-8?B?VTBVYlhwTkVpdk5rRnBUSytGbVhlcS9sajFOZzBoYm92SDNNVksxTUprRHlo?=
 =?utf-8?B?Uks5K3ZrSHJ5TFhJSWNnMVlrUXJzdHJoeHllYzFZdXpocGxNenFSRmZRTnJO?=
 =?utf-8?B?QU9yeWJlNXVlMDJjZFpIRDJqMXZPdk1kWUhqclRVU2xxRlNHcGtpbTZ5dWJz?=
 =?utf-8?B?eXhxaUZlZWxmUDladEdVOXhDK1pMdFk3TGY4eURZZ2M1NDlOOWF2WGZNVHhF?=
 =?utf-8?B?ejdab29ob2pFUHNBR091R29nN213eDR0cXpYVUpRSm1mNWxvZlhmWnJjWHNX?=
 =?utf-8?B?am9VN2lVYlo1RWlaMytBRFh2cC9vVWl5WHJESVRvalpQcjNnQ0s0RmdvMHh0?=
 =?utf-8?B?eTRuK2xEeFlTVGlOWFpQb2MzSmovNHBiNGRiS0FjekpveHhZdDFvMFU1WXdn?=
 =?utf-8?B?d09GRktWUmd2QkVNTXpmSkJKTEttdzhwK1k4eGhJL1Irazl3VlVYZEVVeU1t?=
 =?utf-8?B?U2pJdzFsREVnbUxWY3ZiWVNlZEVVZHJhcWRWMEthR0VCbnFmUHBPVWFaeHgw?=
 =?utf-8?B?RFU1c0tOTU1uWkIzS0UvSHFsblowdFB2RzdTVmw1dzBuV3FGVXZLeE13Nm9V?=
 =?utf-8?B?ZXpCS0VHd0ZtS2xjYUt0N0JqRS9XUEdIbG43bCtvd0JSaEdoZGRnYTl3TjhK?=
 =?utf-8?B?dnNhMnQ2RDVsRnZrRFIveTlrY1pvWXdNZEdBRmEvOVJzRHdoNnRRWEx5OFI2?=
 =?utf-8?B?YzMrWXl3WEl0emdrQ0FrVHhOK2VqZ2RZN1U2TGRSRkhLY1Jia0NPS1RhMy9l?=
 =?utf-8?B?dG5Uc0xwL1NUMHlqSTlCK05oMnFYREw3SXI3VkxpV2FIT0RnVlAyMmhvVytq?=
 =?utf-8?B?NGtyR2ZObHJJeWpLSEdUVEZPUEJsbE1jZkdnU2FJRnpLM2RsdkpLK1V4eG4r?=
 =?utf-8?B?ckxmZlF1bnpOcTd1Smd2a3RnWk1mNlp5ODR4OC9ycW1OS0Q5UW5IVW1PMXQ5?=
 =?utf-8?B?aDJ5TVljcTJuSkIwRklNcE1SZXBIZk9zN2NPMEZtWlNzNUNJNTc5bWtUWERr?=
 =?utf-8?B?YTltNUFJaGNqK2NqTmpNNENiQU9SU1JEdUl6RHMvMkZTKzh5dFk0eFF4SFVN?=
 =?utf-8?B?TGd1THZFR1l2MktBQWFCdFlXMm1GN2IrcGtwMTNmR3lobGROZlQ1cktIUmJX?=
 =?utf-8?B?UlVOYmJ3SVU2ODBCZUdRUFdXV2lDQ3hmVlIvWDVmU1ZUUUtnR3lncGFYVjI3?=
 =?utf-8?B?U2FDaVErNTlNSW1iRDFjQ0MvalZqK1lrcEJvbWVzMnNqdXRwMitBSW5iVEk5?=
 =?utf-8?B?YjJndDQwR2dyYm1BMkorUFg0K3AxUVN1T2VHU1NqRGNkbkl6YmNxQm9NcXVx?=
 =?utf-8?B?Vmh2OWRFK2FJY2I2U05CMFpHQXZ3Y0lHVHZ3T2NMemhwK1dXQUhzYWxwd0pI?=
 =?utf-8?B?TXVIYXZlMStVVGxxN09HWWtPbTFPY3FNTjhLODdibkdYWUlTQ2JmbE9UdUpI?=
 =?utf-8?B?eGczeHk2OFpjSjl0M1FEYlRaVUZzbktwSHlSUmQ0d3R6aDUxWlVPOWQwc3Zh?=
 =?utf-8?B?RUdLa0FVNGFhNnE5Mm0wbWU0UTZMQlVON2UrZkNaelg5OG1LMkRwa2RqL3Nq?=
 =?utf-8?B?M1pUNW5Xb2JObmtvWXhROVR1WlRVWmJDZkw1S0huSEN1WnRJRWc0YVpZc3Bw?=
 =?utf-8?B?K0pWTFkvK0JRL1NISTA0aWV2Qk1CaFdiUmxIRHZweWtXR0FvdENKQTd2WFVT?=
 =?utf-8?B?Sm5pZmlITDhTaE9Qalhtb0dhWWF6Zm5yTUdYa1QraVMyMjNPYU15ZVNrKzlT?=
 =?utf-8?B?MlFVdDFWRHVaUTJ2Q3ZQbjVuVjJBZVhNdEp0YmZiZnQvTjcxdVZBUVgvUDQx?=
 =?utf-8?B?WHc4eWJNaitSUDdEUVdqV2JhVFNXTlNacjBVUkQ3anQzb3kxZlJFMGxDZkwx?=
 =?utf-8?B?MTdVY2I4M1VzRUdUV09XdWkvV1c3UzRJREJGalZNK0V2YjJwQ1B1bURjbThV?=
 =?utf-8?B?NldwR29abFh6VmZIMzhqYVNkTUVoUVllaExIdmFSLzk3UDc3MTVwRkRvU1J1?=
 =?utf-8?Q?DNilUffd6hIP8xlL8qmAjOCfotVR8RPkvWJqTF/VdL4b?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb521913-c5c2-40d4-4db5-08daac1dd91e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:49:02.4736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: puUEV141xQwb4M+61PT+NaXSAxnWkFexkpJI/p5W3ceNDCf/9bd/N60YLnKBmln4MD7rNwqzTTnPQ7iXYFfdiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9568

On 12.10.2022 08:45, Juergen Gross wrote:
> The backport of upstream commit 52daa6a8483e4 had a bug, correct it.
> 
> Fixes: 3ac64b375183 ("xen/gnttab: fix gnttab_acquire_resource()")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Wed Oct 12 06:50:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 06:50:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420798.665823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVZC-0002tS-NN; Wed, 12 Oct 2022 06:50:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420798.665823; Wed, 12 Oct 2022 06:50:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVZC-0002tL-JC; Wed, 12 Oct 2022 06:50:10 +0000
Received: by outflank-mailman (input) for mailman id 420798;
 Wed, 12 Oct 2022 06:50:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiVZB-0000wY-Fw
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:50:09 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150080.outbound.protection.outlook.com [40.107.15.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1c2e890f-49fa-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 08:50:08 +0200 (CEST)
Received: from DB8PR06CA0053.eurprd06.prod.outlook.com (2603:10a6:10:120::27)
 by AS8PR08MB7885.eurprd08.prod.outlook.com (2603:10a6:20b:508::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Wed, 12 Oct
 2022 06:49:59 +0000
Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:120:cafe::c4) by DB8PR06CA0053.outlook.office365.com
 (2603:10a6:10:120::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend
 Transport; Wed, 12 Oct 2022 06:49:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 06:49:58 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Wed, 12 Oct 2022 06:49:58 +0000
Received: from b57922046a15.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E9042F5D-3949-4A27-AD6F-BD36226C1F31.1; 
 Wed, 12 Oct 2022 06:49:52 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b57922046a15.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 06:49:52 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB9002.eurprd08.prod.outlook.com (2603:10a6:10:467::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 06:49:51 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 06:49:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c2e890f-49fa-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=igjpYCZELz9t9oOiyOJkMhNnYZqAxAvAreiQ6F363AAy2ZG0+yIhssztgHcZF8SHJP3FOW2/Mo+Bqv1kzGntP1PwOn8w/PQ3gFMBvlBVExNw5K/3sHTL5cWy5lDwNDyf/G/9zrwbWN2SYKJmEMxgwZajJCknlYC1LaVxVyrixnLDE5Bia25yweLO1EY7IhBgudAh7tbvzr1b76hYSK+JlHZrK23Sr36o+NiOepscWLpZ2Z/Fo/zRszbO2GbuXV/Tg8uJkjFctk+ki2+BBjczHk7dZ2YxGeYTYE+MaY3eVbcvQ1d8GMSOpF4Df5R8Kc1TcoUIVuQhBhrpG7gX83U21A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gFZT/2iFchEk0DBkqTdx1ySupUUK19muxJpxMIblmmg=;
 b=FeERMrSs+KKqaja2hy3C1O8N9fzUMDz43vjjsbKJ2Yf55IklCXaWbI+p9fFJdpoJIAvGXcuxGWuGqMfKLZ3EoXICgBdADbt6smpoP38fMb3GB0r9KMNOhcO5c9e6E9TgbV3Rqo9WyXdLOLZs7fXn6oQpl8TqXps4AcP1+jnhgHhY0kQGHD19XfmGKB0uAWsgGWcaL1HG/wdVS/8jQk6C+4iYRaDxRJLvppOtEVa87uHf49fvKb3yLUpKbi1HgMBa62MQCGe/isbIZ8cUgjsC07rHAfH2DuYYLmEHnuRwlaxQEO+lzlXw649ur76lF+kVdjKn3KUDhOmc7LtVKHpLjw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gFZT/2iFchEk0DBkqTdx1ySupUUK19muxJpxMIblmmg=;
 b=4dDkeSiRVYqO+D/ko7r4SIz5hGS+8PaZCm11P2F1znkXKsyVI5wbRcKMBlgIpoiwKK9v0QEHAggmnbh2PVFI8oL8+sa+mhm4JWg1Pt5FHimGFixW9AbRqblDvWjvk552t9NdwxgMIT+XR/ZwSAEU4r5qQ1+bEjhByQo1GE8phCw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QIJlDXHd6VQb0Vv3H0149xk/Jpje/eNrcn808ctHEyBJh19UY63jjQ9FKherGywvoOJrN4VccYtWq+9niTxHCzn/NngCgC7JXbJcpA9FCFCZRGXOFZO5EkI2iJr7+GYqAUvEkP3jkk+Ivo3yKDuE8R6kvgNrbStopOog0z9Su8rJjbS3iz0dCouHFIA4drax5SUXLaoaiZsN4zZa1tTUdXJTJ3/3hXnPuf8koYSFaKwqSiK0rGegze32jRIr8hzWphHRDwo0SG6uvBUKcx33cCZ2+OThhzuhTaHZXzM6DMvrLLGvOXdJLBoz2tMaGrp//2JL1j2BGkaOlRzB4CDq6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gFZT/2iFchEk0DBkqTdx1ySupUUK19muxJpxMIblmmg=;
 b=gQUSVfZzrAwA32HeAoryIMiPlHUfe72pK83ueht+MEOiKnI577T17SlZa9MUb6WYIPPFxsI5PEH4asrZwc7ltAOIg894TWwovOWVIS84+iv4MM8/8cUq6yF4YtRFJygQ+Do0lXHpTfdHhcbGuokfJaTCkubuBV7kqZNAGPnEMX0QLAXkgA+porg9MkcYVvXCGz81/73vmjZNmJB65bvZblamtBSS53dFghvMdNYwW6IiA5YTa//s6hb3UmJVetnKXO0QiHgZr93sacnqHQEnYLcd0y/SYnp/qyn5DQecQBHJqFj+5FbO66At4oHjyVcJjGzU8HMgkLL+NPLNvQPAiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gFZT/2iFchEk0DBkqTdx1ySupUUK19muxJpxMIblmmg=;
 b=4dDkeSiRVYqO+D/ko7r4SIz5hGS+8PaZCm11P2F1znkXKsyVI5wbRcKMBlgIpoiwKK9v0QEHAggmnbh2PVFI8oL8+sa+mhm4JWg1Pt5FHimGFixW9AbRqblDvWjvk552t9NdwxgMIT+XR/ZwSAEU4r5qQ1+bEjhByQo1GE8phCw=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Anthony Perard
	<anthony.perard@citrix.com>
CC: Julien Grall <julien@xen.org>, Juergen Gross <jgross@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, osstest service owner
	<osstest-admin@xenproject.org>
Subject: RE: [xen-4.15-testing test] 173498: regressions - FAIL
Thread-Topic: [xen-4.15-testing test] 173498: regressions - FAIL
Thread-Index: AQHY3dQtFH1xMEjYXEqV6So1jL4Dp64KChlggABBzQCAAANfQIAAAkgAgAAAMNA=
Date: Wed, 12 Oct 2022 06:49:51 +0000
Message-ID:
 <AS8PR08MB799135DF0D337BA16229299092229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <osstest-173498-mainreport@xen.org>
 <AS8PR08MB79914E7F4F60378327C271D692229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d048659-aad7-7c86-9f41-94489d9d90f0@suse.com>
 <AS8PR08MB79914768F6ACA39D7791BF4892229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <3b0f71b0-1190-1a5a-fbf1-6c651e4f4745@suse.com>
In-Reply-To: <3b0f71b0-1190-1a5a-fbf1-6c651e4f4745@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 88D363B11B7B17408F7B96567893E549.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB9002:EE_|DBAEUR03FT035:EE_|AS8PR08MB7885:EE_
X-MS-Office365-Filtering-Correlation-Id: cdba2105-0e60-4c55-0631-08daac1dfac9
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 iXFxY4loJpPaTO0/USkPqujUZWpIxJl86RH5R7bZA01aOUSC/4zmkDeQKC3z2yg+m8IkIKOn5+7E2qWEvqMzcorGvjtxfs2FpIP0nGeX4TlBrkSCZR/TNazx8yIAGnsmrTlti9/63KrIH3GgFxNVRR76XYGJYNkcl+ezHAZjJa07rsrQpbMbLu0BH1Gp8d6InRySNJIpmEsQLah8UN6seXym4jwPcgg9iSw62tcmsQDbNWrq7NDU9JAIHgieKZgORsaeKLm8geP6uzUoOU4Op0YH548VNRzPssrdwe9xrMFxlz2GtIm5tP+Gsd/BrPIidzzZPFC6MuS2cnQVV8Hewj9ZIlKsFB96IMjDBLMqC1G9u0gUilDA0dogDG9WS4Rlny3TDMUjpI4ebILstJnkgr9kJdPd86T5Lkgym96y9a5A+gCmDWS3CQJDPG4iXL6ceEUugs/CdiQrv/4jCcdnYKTAZW+kxbhpRev9X3/jEN33grioVuS2uviiX/7MbP8RWiVCaosU460l3hwAyYOKzcEWkC+EThYpsJKquCiNXyBLwvdlpV+T+YK2vTR+MwyfzLvWx5vEFShrsD0hm/1zIyIkIlLcgFgAuDSYLKpnkHPr0bFph4cgMltHiLzWmhoY7zTd0xrZnfEKZpBNekQdkrAFAKR59rGSwpf+2LAGLbMiLCAosWhL5ju/97Y7ESWL6a4BSq0vlpKqhDddvkzDbkPQJ4gIt3WyL4kTf/wPYikPymXRK/YscSE1wfTXtPmoNvHul28paqZ4NM5FA5MK+TyLkhKatjdD+Ivq8LDF24E=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(33656002)(86362001)(5660300002)(38100700002)(122000001)(186003)(38070700005)(83380400001)(8676002)(9686003)(53546011)(316002)(7696005)(6506007)(26005)(966005)(478600001)(64756008)(2906002)(54906003)(71200400001)(110136005)(76116006)(66946007)(66556008)(66476007)(66446008)(8936002)(41300700001)(4326008)(52536014)(55016003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9002
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4171e5f8-20fe-46bf-8ffe-08daac1df66c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	upMDN2ptIGWiYYeOUk9DX4VEoZfIaYAWs6pxW5Gc9YywXn7CNpYe+tpQMvpFObX4yn2PC7dsB8fk7b3Ou63B075lzMI5lmMLQ/5WRH+bI8O9fTq4LEqTTcCRHPSLTDBGZc30VBlKx9b3Ucx5mpV7QU0ZZFeRiFIXtuUCPFbztfdQ4Qj1qan473WN5asK8+F1BaSt+ibmOm//dA1OKY1JC/0V+XOcDlnQRibySd7ZKs5NDlHKJB1von2rzdE/2ZYJEESMtJ5DoIkOrP4YYnB59b1TS1OwECIBAFTm//KGnRqdCsefl64tiItheHBbSGwoo3B0WSdDHDTc7Q6AJ3KdwLVI1V18JfOyg2WcAj8u1FwxfQ5Cn86Q74nPGGbkOHiojTtc18GBBDkowbsU3RzvUnSC69CLrr3qPF7aAPtmE7J+0WG1Ts6LCCgomXrxvqhTQdM7awrlGeJkVTSrJIdp95cazrEDxtjAWt3sf1wJfqdtxZRHXE8tavTCxcA282MyIPEDOITJ+2oKhaPuthOuXrOBt/sFteahWnxSSmRkPN2CYtO0OfH0DShoTD2AZUPLElUbdM+ykfVqYpX9vxE0APFeMO60WLTee+gKEHvXJmMHtTHfggPFaD0HHpd3+sOi/wVkRjiCmLWUih434qWGXDK8gDDaHmQNynbjxt/sHqqtQANq6m2GAYUVnd4PrZHyB/AGnJUKFmYNEdiZAFYMb9fwofluwpWKEZ18eZPKf6ZYghOFaHrQOQn2BSk+i28S/3KlTF/MPZlubkSNS+5zyt+fZpTPryP4Q9B9rDkIrms=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(2906002)(336012)(83380400001)(478600001)(40480700001)(55016003)(81166007)(82740400003)(86362001)(356005)(5660300002)(8936002)(70586007)(8676002)(26005)(40460700003)(47076005)(4326008)(54906003)(7696005)(52536014)(110136005)(966005)(41300700001)(186003)(70206006)(53546011)(6506007)(9686003)(82310400005)(316002)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:49:58.7853
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cdba2105-0e60-4c55-0631-08daac1dfac9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7885

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFt4ZW4tNC4xNS10ZXN0aW5n
IHRlc3RdIDE3MzQ5ODogcmVncmVzc2lvbnMgLSBGQUlMDQo+IA0KPiBPbiAxMi4xMC4yMDIyIDA4
OjQyLCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IEhpIEphbiwNCj4gPg0KPiA+PiAtLS0tLU9yaWdp
bmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j
b20+DQo+ID4+IFN1YmplY3Q6IFJlOiBbeGVuLTQuMTUtdGVzdGluZyB0ZXN0XSAxNzM0OTg6IHJl
Z3Jlc3Npb25zIC0gRkFJTA0KPiA+Pg0KPiA+PiBPbiAxMi4xMC4yMDIyIDA0OjQyLCBIZW5yeSBX
YW5nIHdyb3RlOg0KPiA+Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+Pj4gU3Vi
amVjdDogW3hlbi00LjE1LXRlc3RpbmcgdGVzdF0gMTczNDk4OiByZWdyZXNzaW9ucyAtIEZBSUwN
Cj4gPj4+Pg0KPiA+Pj4+IGZsaWdodCAxNzM0OTggeGVuLTQuMTUtdGVzdGluZyByZWFsIFtyZWFs
XQ0KPiA+Pj4+IGh0dHA6Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9n
cy8xNzM0OTgvDQo+ID4+Pj4NCj4gPj4+PiBSZWdyZXNzaW9ucyA6LSgNCj4gPj4+DQo+ID4+PiBJ
IHRoaW5rIHRoZXNlIHJlZ3Jlc3Npb25zIGFyZSBmcm9tIHRoZSBiYWNrcG9ydGluZyBoYXBwZW5l
ZCB5ZXN0ZXJkYXksDQo+ID4+PiBzZWUgYmVsb3cuLi4NCj4gPj4+DQo+ID4+Pj4NCj4gPj4+PiBU
ZXN0cyB3aGljaCBkaWQgbm90IHN1Y2NlZWQgYW5kIGFyZSBibG9ja2luZywNCj4gPj4+PiBpbmNs
dWRpbmcgdGVzdHMgd2hpY2ggY291bGQgbm90IGJlIHJ1bjoNCj4gPj4+PiAgYnVpbGQtYXJtNjQg
ICAgICAgICAgICAgICAgICAgNiB4ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2
cy4gMTcyNTQ3DQo+ID4+Pj4gIGJ1aWxkLWFybTY0LXhzbSAgICAgICAgICAgICAgIDYgeGVuLWJ1
aWxkICAgICAgICAgICAgICAgIGZhaWwgUkVHUi4gdnMuIDE3MjU0Nw0KPiA+Pj4+ICBidWlsZC1h
bWQ2NCAgICAgICAgICAgICAgICAgICA2IHhlbi1idWlsZCAgICAgICAgICAgICAgICBmYWlsIFJF
R1IuIHZzLiAxNzI1NDcNCj4gPj4+PiAgYnVpbGQtYXJtaGYgICAgICAgICAgICAgICAgICAgNiB4
ZW4tYnVpbGQgICAgICAgICAgICAgICAgZmFpbCBSRUdSLiB2cy4gMTcyNTQ3DQo+ID4+Pg0KPiA+
Pj4gLi4uVGhlIGFybS9hcm02NCByZWdyZXNzaW9uIGlzIGZyb20gdGhlIGJhY2twb3J0aW5nIG9m
IGNvbW1pdDoNCj4gPj4+IHhlbi9hcm0sIGxpYnhsOiBJbXBsZW1lbnQgWEVOX0RPTUNUTF9zaGFk
b3dfb3AgZm9yIEFybQ0KPiA+Pj4NCj4gPj4+IFRoZSBpc3N1ZSBpczoNCj4gPj4+IEluIDQuMTYs
IGNvbW1pdA0KPiA+Pj4gMjEwN2NjNzZkYjNhIGxpYnhjOiBzcGxpdCB4Y19sb2dkaXJ0eV9jb250
cm9sKCkgZnJvbSB4Y19zaGFkb3dfY29udHJvbCgpDQo+ID4+PiBjaGFuZ2VzIHRoZSBwcm90b3R5
cGUgb2YgeGNfc2hhZG93X2NvbnRyb2woKSwgYW5kIGhlbmNlIHRoZSBjYWxsaW5nIG9mDQo+ID4+
PiB4Y19zaGFkb3dfY29udHJvbCgpIGluIDQuMTMsIDQuMTQgYW5kIDQuMTUgZG9lcyBub3QgbWF0
Y2ggdGhlIGNhbGxpbmcgb2YNCj4gPj4+IHhjX3NoYWRvd19jb250cm9sKCkgaW4gNC4xNiBhbmQg
YWZ0ZXIuDQo+ID4+DQo+ID4+IFNvIGRpZCBJIGNvbW1pdCBhIHdyb25nIHBhdGNoLCBvciB3ZXJl
IHRoZSBwYXRjaGVzIGZvciB0aGUgb2xkZXIgYnJhbmNoZXMNCj4gPj4gd3JvbmcgYWxyZWFkeSBp
biB4c2EuZ2l0Pw0KPiA+DQo+ID4gSSB0aGluayB0aGUgbGF0dGVyLiBGb3IgdGhpcyBjb21taXQg
SSB0aGluayB0aGUgcGF0Y2ggZm9yIG1hc3RlciBicmFuY2ggd2FzDQo+IHBpY2tlZA0KPiA+IGZv
ciB0aGUgNC4xMy00LjE1IGJhY2twb3J0aW5nLCB3aXRob3V0IG5vdGljaW5nIHRoZSB4Y19zaGFk
b3dfY29udHJvbCgpDQo+ID4gcHJvdG90eXBlIGNoYW5nZSBpbiA0LjE2Lg0KPiA+DQo+ID4gSSBj
YW4gc2VuZCBhIGZpeCBmb3IgdGhpcy4gSWYgd2UgZG9uJ3Qgd2FudCB0byBiYWNrcG9ydCB0aGUN
Cj4gPiAibGlieGM6IHNwbGl0IHhjX2xvZ2RpcnR5X2NvbnRyb2woKSBmcm9tIHhjX3NoYWRvd19j
b250cm9sKCkiDQo+IA0KPiBJIGRvbid0IHRoaW5rIHdlIHNob3VsZCBiYWNrcG9ydCB0aGF0IGV4
dHJhIGNoYW5nZSwgYnV0IEFudGhvbnkgd291bGQgaGF2ZQ0KPiB0aGUgZmluYWwgc2F5Lg0KDQpU
aGVuIEkgd2lsbCB0cnkgdG8gcHJlcGFyZSBhIGZpeC4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkN
Cg0KPiANCj4gSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 07:00:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 07:00:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420805.665834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVii-0003qu-JO; Wed, 12 Oct 2022 07:00:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420805.665834; Wed, 12 Oct 2022 07:00:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVii-0003qn-GD; Wed, 12 Oct 2022 07:00:00 +0000
Received: by outflank-mailman (input) for mailman id 420805;
 Wed, 12 Oct 2022 06:59:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiVig-0003qh-Lz
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 06:59:58 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2073.outbound.protection.outlook.com [40.107.249.73])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7b3014c0-49fb-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 08:59:57 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.39; Wed, 12 Oct
 2022 06:59:55 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 06:59:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b3014c0-49fb-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LULjrTgtBdW7nCUrUP+SVrwPYK+jFWflmRtPTtEX7lDc/JmQ1HrpdY0mqFoBNe02eAEobY5FWmVDw61fmRlRDdssRmMu3r8zk1973XS1SkcwN49ok2Pia2o5tCwNHO1cCA4GoFMho50D5gSk8859S5q4nX/yPF9avzIn8POBYdYssjRFhEQZWsA8l+x7pzvAUlpMJEhpzN0yuKMpM0bPWZaQjrDo7sGYG75RWNbfLvYVsV6ljHny4RcnMlrqpCkI6upT4B4vLjKvTzHPPBhnPfCbgpo14Z/Z3OyutocX553uekMBuF9jn0dd6F+YJpct+wfg9lkgMlFHWYzpTbQtcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dv01eeo9+c6GDuIHwx7AmNms/V+0F4tcQVHqeVNHQdk=;
 b=iKrQIJX61OPsviqaxx3Js8Sv6U75Yj4LEKvaFtAHyPKFinl458gTaQ0WFVILWUwMiNf3TXg9NkF+6p0jXW6Z+uE1hnatvxXjlpt/0tKKZru/C/vja0VaoA2PdyI/zY5AxdE4crY+Uao+TMlfFLkh1KwMvSInk1DwPxZFAws1/Z4IDxfzKmrmriTsyg5WQ3mFc3ryNv1oXrPHVubzTaMs5q1zBXAHLDCeMK7hvUnXa9jFlYFN49RQl6CbE9dUXmx5uRtOPY2NOsUaqy4Wt/D0NCejeQSDS1pvrHkxLE4+ZzJ5d9b/quccrmSGQ91SwXCTWdSKLeLNaZgMomkzdyypiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dv01eeo9+c6GDuIHwx7AmNms/V+0F4tcQVHqeVNHQdk=;
 b=IBaP+TfQ6NHGfLT7is5+Jl+CnQpbESjF4VF+vPxktk2NUy42NSfBRaKEjH7A3vPqW4Ew1Zf8FMqkReYmttKnL5JjyXERL97BROUJlZHQtw7lvsBzyUMifOQQKKnWY6Yd9CajLmDnMOLI+Py6KlpoZy9K+elbT6tff5uyLnOJdzEPnJ+pYQPGlBGUd8Z5lZC+gQYvn28ijMyCNs/Yoycp3ApGsjYHVc1CzxLHIWNZ9wStXDV8f1zHzFsQorTH+g1jZuwdD0l2TXZDiUQaf+jeNCGCN0vrQ5rclCuefelSRkKARkqvBi0iCNcDzCkZGBAkIdfpAJLIFrKf2tDH9pwlpw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1c438faa-5251-4fb1-f3d0-ef3d8533ef5d@suse.com>
Date: Wed, 12 Oct 2022 08:59:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 2/2] acpi: Add TPM2 interface definition.
Content-Language: en-US
To: Jennifer Herbert <jennifer.herbert@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>, "wl@xen.org" <wl@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>
References: <0548fa97-5384-94e4-7329-b019e60555f4@citrix.com>
 <20220915204029.1227112-1-jennifer.herbert@citrix.com>
 <20220915204029.1227112-2-jennifer.herbert@citrix.com>
 <DS7PR03MB5414DE39CD2F506EDD49D822EF239@DS7PR03MB5414.namprd03.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DS7PR03MB5414DE39CD2F506EDD49D822EF239@DS7PR03MB5414.namprd03.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0457.eurprd06.prod.outlook.com
 (2603:10a6:20b:49a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7285:EE_
X-MS-Office365-Filtering-Correlation-Id: e9f7332d-61a2-4220-a0fb-08daac1f5e73
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yOgTFBcGMqPfOw1hyJail6m7L2YeCy6RBXJHzmt357fBqJ/UzzRCO8HLMfoR9vo5nT58wo4fWhvhGWN9E6kyvnV5UyVNtko3H37kl4mgWek8ijkrFXqEsD2iL1WWHIYzrFK2M10Q17emDWWx6jJSUeooh7J1aWTtBRQeZXgTe26P4Y29kXK1sjVJ4UbhW/9O99fTV0aZBV65E+DJ0pQW9TKELl0pO/ztP8j/dJea68lv+WSpSEGQqufSdDQjOXSGZ+eQJuXdVSvawG+rtIgzv1m9/9If7uenQk25eHOhszwfKUoSdx9T8gr7egCy99u5oVsAY8Bff15F8SPcNysNyzSku5t6rnXvKdcmWzZjeTmmIIjwMk+zDTjoQxyiPrKKIs3NtzEFTbYysPxn7D96Ttq//Ehk3TCjvzTkOEjFA1R5h2AQxxJRoUWhtp+SiCEc2x4zePKy1fkmTYKdSzoTUGt0xwMXLi0CaAOl+Qm+sajk8FcHRL6BKN4hVBFZeGu6CETnXPcGK8voQk6gDl3D++kvrfUrcjGrnJuIPiBe0/0jOyfnnh+zZKthlhfR+YzIZEqX8/u2/zjHo28RTeYYH1M2JQI/el8N9r9FZS0zFs7gDKY5oh/puOjF/BJ2tCVirhmSGZDZ+aDAqamkB+WuPcun58K9xBW/zGJtmY6J2V84U7gwnhOZYt4mHyD8Jg2KNPN6HRl0eMRNs3FBDk2eCMEVSMzI6Bmiux9GyGSSTniRdDI0gFiU3uzBJlubFFySwhR4TdBZuLWiVbQFtn8KlmmvkfTZx/19H8tXbi0Tjd8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39850400004)(346002)(136003)(366004)(396003)(451199015)(31686004)(8936002)(66556008)(4326008)(41300700001)(6512007)(66476007)(8676002)(66946007)(2616005)(558084003)(186003)(38100700002)(5660300002)(36756003)(2906002)(6916009)(478600001)(31696002)(86362001)(316002)(53546011)(6506007)(54906003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TnN6Smpub1I4L2xZQlNQd3poMnJRbFQyeEd3UTgxNU9Bbk51Ly9rSUgyOStE?=
 =?utf-8?B?N28ycTBNRFRlY1k3MVlDWVo0SU1FcW5OQ1dkSmRMTjZuMnF2QUYvT2pzVjFt?=
 =?utf-8?B?UFhQSmxCWjIwSHpIc21nWHlyYmRCZ01LVjNjMnZYUm9aN2RlOTgrVDBwTURQ?=
 =?utf-8?B?YTNQWWhybGJmSkIwK04zR0IzQTQxOVpRSFNJcllwaFY5MFBUR0x5K0xXQThS?=
 =?utf-8?B?TUtyRDVSTzBqVGhWK2krZUwycDJ5L2dHZXVRSEVOTjlFSGxPK014UXVMVnJI?=
 =?utf-8?B?dlNkRzRtSFpuTnlkZXAwYzF3c3lnOGQwUDA3L25GcVdtTjRodXNWc1lMUlA4?=
 =?utf-8?B?Q213UTJ4ZnZpcTByTVo0QWlXeWFRbllwL0htUkpic0x6a01DRmZYMEtVWENH?=
 =?utf-8?B?cThzYXdrM1Rlci9ONUxSWFkrOGcvT2VKZ2N2YVRVNTF6c0NaSThsRzNXTjFP?=
 =?utf-8?B?bHh5WkNUTDRZT3hIZzgzeXJsQlo1UXdCQ0wwUHEzcTFsUTF6aU1PL1hBY1Fj?=
 =?utf-8?B?THZCeEtFNHZVRGRDY2J6cGhGdUdITnhUeUVBT0J0Q1FFS3R1WTNRd2ZtSDBj?=
 =?utf-8?B?TDhrYnFDdkdmaWY0OGp2UWpGZ1lKWkN4K2VuZUUzbWxzcGtBS2pGTFVBMXhD?=
 =?utf-8?B?NkhURTRTK2FsYktMSHhFQld6Vm1YK0RETThSbWk3cXJ4ekgwcEJQWVR4VXZJ?=
 =?utf-8?B?bG5od2JVQnlkdWVLd0MrZFlZTmx5amJiVG9Jd2tGYjMvbEt1RlQyeC9UbVVV?=
 =?utf-8?B?NE1FUmFjdjUzNDV2S2VpYjdCNXB2aWxpbG5meVdvSGFQa1RxbWhnSC9tclJV?=
 =?utf-8?B?Q0ZtSUMxQWY0VFAzZUIxUUlnL21TZlo0Y3UrUkZvZmlCV1huTTVnS1RMbGRD?=
 =?utf-8?B?b1p2Znk2ZU04WElmVGRubEtDMHhidDUrSExGWlhjMHh2dFJSYWRDSEM0S0FJ?=
 =?utf-8?B?VENESjhLUGF6TWdTNVdMVEZSWG9vQi9Odmprc2svdllnQnZRNzQxanNYZDFq?=
 =?utf-8?B?OGVac1ZSMW8xTW5TbE1wNzNpblJmcldTRHlidWdBOVh1NW5RTDJLU051bnpU?=
 =?utf-8?B?RldsM1hRVmpoaVc4aXdmekhlUHVKcWRMbjgyYlVFMk9VOWU2RllyL081aUQr?=
 =?utf-8?B?NnIyQzVLcjYvNkVmNENGL2laTCt5RC8wYnBvYUZ0cUlSd0xjYnJJbUxNa1Er?=
 =?utf-8?B?VHBUWWtVbHE3MmtqOHkzQk1rRGdpaS9IUDJscmtDLzRNMWh1Qm5aellwMzky?=
 =?utf-8?B?bmlWRGFKS2kzdHJYK2N2OVl4c0xQcGx6Q24zQ0ZMdTRpWHd1UFJjTGgyY1ZV?=
 =?utf-8?B?U3k4eCtzZ3E0WFg5d0RVaERIeHBUMWlMK2QyR3YvVUZyZDRpTHBzUldIU29q?=
 =?utf-8?B?YjNjaXdZYXlISHp2enYxMHVUMEVKS1owOVVXbTlPYkR6V1lBdFJoVldqcUEy?=
 =?utf-8?B?RytrRzNzVWtWS3g0dmt3YWRrSVhRV0tua3RIQnBIL3R1R0ZtdDRCVzhSNXFy?=
 =?utf-8?B?elg1cTNYTjBvWjEveDZxQUVxVnZmWWNSMFBvSEE4eS9oZFJSNTdwTTl1WTNo?=
 =?utf-8?B?QmpjZGlQQk01RjZtcmJBTmZCd0hSaEFzNitaTEhnYmp4c1lyQlh4cGlFR0pG?=
 =?utf-8?B?V3Rwc3RQQXFLNmZLMk0xbjNBQnJJcWhoNStndE4xby9HQUdzN1c4SzBXZENE?=
 =?utf-8?B?NE9oSHcrbldpblNmVFExN05FSHJCdU13ZGd4Sm5ubXZEOTA3dWlXeGprejZS?=
 =?utf-8?B?T0VoTXlVTVhEb1F6cUxDK2QyenZ1R0wrRjZWZFB5cjQ4OW9WTVZmemZTS1VM?=
 =?utf-8?B?K1V4aUl6RXY5aFZVdFRTam9VeUoybjZCeitYM3B5RUwyUXJFMVpyd010NUVo?=
 =?utf-8?B?VnBWd2FyRVlzRk43RzlSd1BvQUFZd2JBRU01byt5alYrVjJ1eDhOWjVQQk9S?=
 =?utf-8?B?Titqb25jc0wyOTRvbjdoSy9TTE80OFlselBvTytocDNjVTNjb0VkWk1Dc0Jh?=
 =?utf-8?B?eGduSEZEd3pIaGx2VEhHWDAxeUY1UHZmSnN0aDNpWHh3eGd0YzRhYzNxa2Qv?=
 =?utf-8?B?MXkrTEJEY08veG9RcTNwcGZBUXVZcG1xS0sxbTZ1QWNPLzNNMElnUTJ1blIz?=
 =?utf-8?B?d3F2aXVlT1dJT2dLd1hoa0FEM00rVVp5aGZDQVZZa09pQUltbmoyQ3RmeG1F?=
 =?utf-8?Q?CH3ls+v5D0f+cuw3NGU/PJexIUvkbDPr9YG4wUFZAbfq?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9f7332d-61a2-4220-a0fb-08daac1f5e73
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 06:59:55.7133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YpwmSH5KQiIyGOo8xIyXnn74gAP4VNUv620PxW7m4+ny39an8ldT5hBd/NUrG0tcJCzo6jwG89yZuXhCku6AXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285

On 11.10.2022 17:53, Jennifer Herbert wrote:
> Are any further changes needed to upstream this patch series?

On Sept 19th Jason and I gave comments on the series, which will want
addressing one way or another (presumably in a v2).

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 07:16:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 07:16:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420818.665863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVyY-0006mK-B1; Wed, 12 Oct 2022 07:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420818.665863; Wed, 12 Oct 2022 07:16:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiVyY-0006mD-72; Wed, 12 Oct 2022 07:16:22 +0000
Received: by outflank-mailman (input) for mailman id 420818;
 Wed, 12 Oct 2022 07:16:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zRMe=2N=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oiVyX-0006m6-Fn
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 07:16:21 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c4ef1c96-49fd-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 09:16:19 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 814C31F8AC;
 Wed, 12 Oct 2022 07:16:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4873013A5C;
 Wed, 12 Oct 2022 07:16:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KZxSEMNpRmNROQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 12 Oct 2022 07:16:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4ef1c96-49fd-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665558979; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=uVN9aIUqx34P/45tcMyef9ckHEUfMNnGUM08QJbEcWE=;
	b=FZS6AM6zDQA0sW9E4AD+vHPONn2WtBOhg/pbZ/EKi9wcFoL2lpkJUc5MYMKmtT0BbNORyO
	rotC6zeIWH9kOkSQTxynPjX+Nlds9dAUuDfgnEezA+dCLuotphLFB882Cs/ODXkVenqH9X
	mujfc4JLFRWQQQk+D2ikhwVu/4ADcq4=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	sstabellini@kernel.org
Subject: [GIT PULL] xen: branch for v6.1-rc1
Date: Wed, 12 Oct 2022 09:16:18 +0200
Message-Id: <20221012071618.8859-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc1-tag

xen: branch for v6.1-rc1

It contains:

- Some minor typo fixes

- A fix of the Xen pcifront driver for supporting the device model to
  run in a Linux stub domain

- A cleanup of the pcifront driver

- A series to enable grant-based virtio with Xen on x86

- A cleanup of Xen PV guests to distinguish between safe and faulting
  MSR accesses

- Two fixes of the Xen gntdev driver

- Two fixes of the new xen grant DMA driver


Thanks.

Juergen

 Documentation/admin-guide/kernel-parameters.txt |   6 +
 arch/x86/xen/Kconfig                            |   9 ++
 arch/x86/xen/enlighten_hvm.c                    |   2 +-
 arch/x86/xen/enlighten_pv.c                     | 101 ++++++++++-----
 arch/x86/xen/pmu.c                              |  71 ++++++-----
 drivers/pci/xen-pcifront.c                      | 161 ++++++++----------------
 drivers/xen/Kconfig                             |   2 +-
 drivers/xen/gntdev-common.h                     |   3 +-
 drivers/xen/gntdev.c                            |  80 ++++++------
 drivers/xen/grant-dma-ops.c                     | 112 ++++++++++++-----
 drivers/xen/xen-pciback/xenbus.c                |   2 +-
 include/xen/xen-ops.h                           |   6 +
 12 files changed, 313 insertions(+), 242 deletions(-)

Colin Ian King (2):
      xen/xenbus: Fix spelling mistake "hardward" -> "hardware"
      xen: Kconfig: Fix spelling mistake "Maxmium" -> "Maximum"

Jason Andryuk (1):
      xen-pcifront: Handle missed Connected state

Juergen Gross (8):
      xen/pcifront: move xenstore config scanning into sub-function
      xen/virtio: restructure xen grant dma setup
      xen/virtio: use dom0 as default backend for CONFIG_XEN_VIRTIO_FORCE_GRANT
      xen/virtio: enable grant based virtio on x86
      xen/pv: add fault recovery control to pmu msr accesses
      xen/pv: fix vendor checks for pmu emulation
      xen/pv: refactor msr access functions to support safe and unsafe accesses
      xen/pv: support selecting safe/unsafe msr accesses

M. Vefa Bicakci (2):
      xen/gntdev: Prevent leaking grants
      xen/gntdev: Accommodate VMA splitting

Oleksandr Tyshchenko (2):
      xen/virtio: Fix n_pages calculation in xen_grant_dma_map(unmap)_page()
      xen/virtio: Fix potential deadlock when accessing xen_grant_dma_devices


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:02:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:02:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420828.665874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWhM-0004qb-4r; Wed, 12 Oct 2022 08:02:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420828.665874; Wed, 12 Oct 2022 08:02:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWhM-0004qU-2F; Wed, 12 Oct 2022 08:02:40 +0000
Received: by outflank-mailman (input) for mailman id 420828;
 Wed, 12 Oct 2022 08:02:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jpGp=2N=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1oiWhK-0004qO-8Y
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:02:38 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 3b4dc483-4a04-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 10:02:36 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D37815A1;
 Wed, 12 Oct 2022 01:02:41 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6305E3F67D;
 Wed, 12 Oct 2022 01:02:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b4dc483-4a04-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 0/3] Yocto Gitlab CI
Date: Wed, 12 Oct 2022 09:02:22 +0100
Message-Id: <cover.1665561024.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is a first attempt to check if we could use Yocto in
gitlab ci to build and run xen on qemu for arm, arm64 and x86.

The first patch is creating a container with all elements required to
build Yocto, a checkout of the yocto layers required and an helper
script to build and run xen on qemu with yocto.

The second patch is creating containers with a first build of yocto done
so that susbsequent build with those containers would only rebuild what
was changed and take the rest from the cache.

The third patch is adding a way to easily clean locally created
containers.

This is is mainly for discussion and sharing as there are still some
issues/problem to solve:
- building the qemu* containers can take several hours depending on the
  network bandwith and computing power of the machine where those are
  created
- produced containers containing the cache have a size between 8 and
  12GB depending on the architecture. We might need to store the build
  cache somewhere else to reduce the size. If we choose to have one
  single image, the needed size is around 20GB and we need up to 40GB
  during the build, which is why I splitted them.
- during the build and run, we use a bit more then 20GB of disk which is
  over the allowed size in gitlab

Once all problems passed, this can be used to build and run dom0 on qemu
with a modified Xen on the 3 archs in less than 10 minutes.

This has been tested on a x86 host machine and on an arm host machine
(with mk_dsdt.c fix).

Changes in v2:
- remove gitignore patch which was merged
- add a --dump-log support in build-yocto.sh script and use it during
  container creation to see the error logs.

Bertrand Marquis (3):
  automation: Add elements for Yocto test and run
  automation: Add yocto containers with cache
  automation: Add a clean rule for containers

 automation/build/Makefile                     |  19 +-
 automation/build/yocto/build-yocto.sh         | 340 ++++++++++++++++++
 .../build/yocto/kirkstone-qemuarm.dockerfile  |  28 ++
 .../yocto/kirkstone-qemuarm64.dockerfile      |  28 ++
 .../yocto/kirkstone-qemux86-64.dockerfile     |  28 ++
 automation/build/yocto/kirkstone.dockerfile   | 100 ++++++
 6 files changed, 542 insertions(+), 1 deletion(-)
 create mode 100755 automation/build/yocto/build-yocto.sh
 create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile
 create mode 100644 automation/build/yocto/kirkstone.dockerfile

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:02:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:02:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420829.665885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWha-000595-Dr; Wed, 12 Oct 2022 08:02:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420829.665885; Wed, 12 Oct 2022 08:02:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWha-00058x-AF; Wed, 12 Oct 2022 08:02:54 +0000
Received: by outflank-mailman (input) for mailman id 420829;
 Wed, 12 Oct 2022 08:02:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jpGp=2N=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1oiWhY-0004qO-OQ
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:02:52 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 451f85d9-4a04-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 10:02:52 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A620315A1;
 Wed, 12 Oct 2022 01:02:57 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C33733F67D;
 Wed, 12 Oct 2022 01:02:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 451f85d9-4a04-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 1/3] automation: Add elements for Yocto test and run
Date: Wed, 12 Oct 2022 09:02:23 +0100
Message-Id: <5ee13af0b3928460e7cc18dfb363dd75679e66c8.1665561024.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1665561024.git.bertrand.marquis@arm.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a container suitable to run yocto kirkstone build based on ubuntu
22.04. It contains all packages required by Yocto and a checkout of the
layers required to build Xen with Yocto.

Add a build script to build and run xen on qemu using Yocto.
The script supports arm32, arm64 and x86_64 and checks that dom0 is
properly booting. At this stage this does not run any guest on top of
dom0.

The build script is currently in the same directory than the docker
files so that it can be included directly in the image. This is required
for the next step which creates images with an initial cache content to
speed up testing.

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v2:
- add a --dump-log command line option to build-yocto.sh script to dump
the logs if an error occurs.
Changes in v1:
- add --image command line argument to build-yocto.sh to allow building
something different than xen-image-minimal.
- modify dockerfile to have one layer per line and make it easier to add
other. I kept the for loop to keep the number of docker steps lower
- update commit message to warn that no guest are tested.
- fix build-yocto script to properly return with an error if expect
script ends up in timeout or EOF.
---
 automation/build/yocto/build-yocto.sh       | 340 ++++++++++++++++++++
 automation/build/yocto/kirkstone.dockerfile | 100 ++++++
 2 files changed, 440 insertions(+)
 create mode 100755 automation/build/yocto/build-yocto.sh
 create mode 100644 automation/build/yocto/kirkstone.dockerfile

diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
new file mode 100755
index 000000000000..0d31dad607fb
--- /dev/null
+++ b/automation/build/yocto/build-yocto.sh
@@ -0,0 +1,340 @@
+#!/bin/bash
+#
+# Yocto meta virtualization build and run script
+#
+# This script is building Yocto xen-image-minimal for qemu targets and run
+# them using runqemu inside yocto to check that dom0 is booting properly
+# The build is using a local xen source tree so that specific patches can be
+# tested.
+# In order to optimize the build time, a build cache is used so that only xen
+# packages and its dependencies are rebuilt (qemu and final image mainly).
+#
+
+# Directories
+YOCTODIR="$HOME/yocto-layers"
+CACHEDIR="$HOME/yocto-cache"
+LOGDIR="$HOME/logs"
+XENDIR="$HOME/xen"
+BUILDDIR="$HOME/build"
+
+# what yocto bsp we support
+TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64"
+VERBOSE="n"
+TARGETLIST=""
+
+# actions to do
+do_clean="n"
+do_build="y"
+do_run="y"
+do_localsrc="n"
+do_dump="n"
+build_result=0
+
+# layers to include in the project
+build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \
+                 meta-openembedded/meta-oe meta-openembedded/meta-python \
+                 meta-openembedded/meta-filesystems \
+                 meta-openembedded/meta-networking meta-virtualization"
+
+# yocto image to build
+build_image="xen-image-minimal"
+
+function print_progress() {
+    echo -n "$(date +%T) $*"
+}
+
+function run_task() {
+    local task_name="$1"
+    local task_target="$2"
+
+    task_log="${task_name//project_}-${task_target}"
+
+    mkdir -p "${LOGDIR}"
+    print_progress
+    echo -n "${task_name//project_} ${task_target}: "
+    if [ "${VERBOSE}" = "n" ]; then
+        $@ > "${LOGDIR}/${task_log}.log" 2>&1
+    else
+        $@ 2>&1 | tee "${LOGDIR}/${task_log}.log"
+    fi
+
+    if [ ${?} -ne 0 ]; then
+        echo "Error"
+        build_result=$((build_result+1))
+        if [ "${do_dump}" = "y" ]; then
+            echo
+            echo "############ LOGS-START ############"
+            cat "${LOGDIR}/${task_log}.log"
+            echo "############  LOGS-END  ############"
+            echo
+        fi
+        return 1
+    else
+        echo "OK"
+        return 0
+    fi
+}
+
+function project_create() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+
+    (
+        # init yocto project
+        source ${YOCTODIR}/poky/oe-init-build-env "${destdir}"
+
+        # add needed layers
+        for layer in ${build_layerlist}; do
+            bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1
+        done
+    ) || return 1
+
+    # customize project configuration
+    cat <<EOF >> "${destdir}/conf/local.conf"
+# Yocto BSP
+MACHINE = "${target}"
+
+# Use local cache to reuse previous builds results
+SSTATE_DIR = "${CACHEDIR}/sstate-cache"
+DL_DIR = "${CACHEDIR}/downloads"
+
+# Enable xen and virtualization
+DISTRO_FEATURES = " virtualization xen ipv4"
+
+# Speed up run by not generating ssh host keys
+IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
+
+# Save some disk space
+INHERIT += "rm_work"
+
+EOF
+
+    if [ "${do_localsrc}" = "y" ]; then
+        XENVERS=$(grep -e "^XEN_REL" \
+            "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \
+            2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \
+            | sed -e "s/.*=//" | sort -V | tail -n 1)
+
+        XENBASE=$(dirname "$(realpath -m "${XENDIR}")")
+        XENSUB=$(basename "$(realpath -m "${XENDIR}")")
+
+        cat <<EOF >> "${destdir}/conf/local.conf"
+# Use local sources for xen and xen-tools
+FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:"
+FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:"
+
+SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/"
+SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/"
+
+PREFERRED_VERSION:pn-xen = "${XENVERS}%"
+PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%"
+
+S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}"
+S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}"
+
+SRCREV:pn-xen = "\${AUTOREV}"
+SRCREV:pn-xen-tools = "\${AUTOREV}"
+
+SRCPV:pn-xen = "1"
+SRCPV:pn-xen-tools = "1"
+
+# Disable all QA errors as the recipe is not up to date with changes in Xen
+# when we use local sources
+ERROR_QA:pn-xen = "arch"
+ERROR_QA:pn-xen-tools = "arch"
+
+EOF
+    fi
+}
+
+function project_build() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+
+    (
+        source ${YOCTODIR}/poky/oe-init-build-env "${destdir}"
+
+        bitbake "${build_image}" || exit 1
+    ) || return 1
+}
+
+function project_clean() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+
+    rm -rf "${destdir}"
+}
+
+function project_run() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+    (
+        source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1
+
+        /usr/bin/expect <<EOF
+set timeout 100
+spawn bash -c "runqemu serialstdio nographic slirp"
+
+expect_after {
+    -re "(.*)\r" {
+        exp_continue
+    }
+    timeout {send_user "ERROR-Timeout!\n"; exit 1}
+    eof {send_user "ERROR-EOF!\n"; exit 1}
+}
+
+# wait initial login
+expect -re ".* login: "
+send "root\r"
+expect -re "root@.*# "
+
+EOF
+    exit $?
+    ) || return 1
+}
+
+function help() {
+    cat <<EOF
+Usage: ${0} [TARGET1] [TARGET2]
+
+This script is build the yocto xen-image-minimal for different qemu targets
+and is running it after.
+Without any target specified, all supported targets are done.
+
+Options:
+  -h, --help       Print this help
+  -v, --verbose    Verbose build
+  --list-target    List supported targets
+  --clean          Clean existing project before starting
+  --no-build       Do not build (to run an already built project)
+  --no-run         Do not run
+  --dump-log       On error, dump the logs on the console
+  --image=IMG      Yocto image or package to build
+                   Default: xen-image-minimal
+  --xen-dir=DIR    path to xen hypervisor source tree
+                   if not provide, normal yocto version of xen is built
+                   Default: ${XENDIR}
+  --out-dir=DIR    directory where to create the projectss
+                   Default: ${BUILDDIR}
+  --log-dir=DIR    directory to store logs
+                   Default: ${LOGDIR}
+  --cache-dir=DIR  directory where to take and store build cache
+                   Default: ${CACHEDIR}
+  --layer-dir=DIR  directory containing the checkout of yocto layers
+                   Default: ${YOCTODIR}
+EOF
+}
+
+for OPTION in "$@"
+do
+    case ${OPTION} in
+        -h|--help)
+            help
+            exit 0
+            ;;
+        -v|--verbose)
+            VERBOSE="y"
+            ;;
+        --list-targets)
+            echo "${TARGET_SUPPORTED}"
+            exit 0
+            ;;
+        --clean)
+            do_clean="y"
+            ;;
+        --no-build)
+            do_build="n"
+            ;;
+        --no-run)
+            do_run="n"
+            ;;
+        --dump-log)
+            do_dump="y"
+            ;;
+        --image=*)
+            build_image="${OPTION#*=}"
+            ;;
+        --xen-dir=*)
+            XENDIR="${OPTION#*=}"
+            if [ ! -e "${XENDIR}/xen/Makefile" ]; then
+                echo "No Xen source tree in ${XENDIR}"
+                exit 1
+            fi
+            do_localsrc="y"
+            ;;
+        --out-dir=*)
+            BUILDDIR="${OPTION#*=}"
+            ;;
+        --log-dir=*)
+            LOGDIR="${OPTION#*=}"
+            ;;
+        --cache-dir=*)
+            CACHEDIR="${OPTION#*=}"
+            ;;
+        --layer-dir=*)
+            YOCTODIR="${OPTION#*=}"
+            ;;
+        --*)
+            echo "Invalid option ${OPTION}"
+            help
+            exit 1
+            ;;
+        *)
+            if echo "${TARGET_SUPPORTED}" | grep -q -w "${OPTION}"; then
+                TARGETLIST="${TARGETLIST} ${OPTION}"
+            else
+                echo "Unsupported target ${OPTION}"
+                exit 1
+            fi
+            ;;
+    esac
+done
+
+# if no target is specified build all targets
+if [ -z "${TARGETLIST}" ]; then
+    TARGETLIST="${TARGET_SUPPORTED}"
+fi
+
+mkdir -p "${CACHEDIR}"
+mkdir -p "${LOGDIR}"
+mkdir -p "${BUILDDIR}"
+
+# Make sure we have an absolute path
+YOCTODIR=$(realpath -m "${YOCTODIR}")
+CACHEDIR=$(realpath -m "${CACHEDIR}")
+BUILDDIR=$(realpath -m "${BUILDDIR}")
+LOGDIR=$(realpath -m "${LOGDIR}")
+if [ "${do_localsrc}" = "y" ]; then
+    XENDIR=$(realpath -m "${XENDIR}")
+fi
+
+# Check that we have all the layers we need
+for f in ${build_layerlist}; do
+    if [ ! -f "${YOCTODIR}/${f}/conf/layer.conf" ]; then
+        echo "Layer ${f} missing in ${YOCTODIR}"
+        exit 1
+    fi
+done
+
+for f in ${TARGETLIST}; do
+    if [ "${do_clean}" = "y" ]; then
+        run_task project_clean ${f}
+    fi
+    if [ ! -f ${BUILDDIR}/${f}/conf/local.conf ]; then
+        run_task project_create ${f}
+    fi
+    if [ -f ${BUILDDIR}/${f}/conf/local.conf ]; then
+        if [ "${do_build}" = "y" ]; then
+            run_task project_build ${f}
+        fi
+        if [ "${do_run}" = "y" ]; then
+            run_task project_run ${f}
+        fi
+
+    fi
+done
+
+print_progress "Build Complete (${build_result} errors)"
+echo
+exit ${build_result}
+
diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
new file mode 100644
index 000000000000..367a7863b685
--- /dev/null
+++ b/automation/build/yocto/kirkstone.dockerfile
@@ -0,0 +1,100 @@
+# Docker file to create an environment to build yocto with virtualization
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "host_uid=$(id -u)": to use current user uid for build user in the image
+# "host_gid=$(id -g)": to use current user gid for build user in the image
+# "yocto_version=VERS": to select the Yocto version (branch name)
+
+# Use standard ubuntu minimal
+From ubuntu:22.04
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV DEBIAN_FRONTEND=noninteractive
+
+# Install minimal ubuntu requirements for yocto and other tools we need
+# See https://docs.yoctoproject.org/4.0.1/brief-yoctoprojectqs/index.html#build-host-packages
+RUN apt-get update && \
+    apt-get --quiet --yes install \
+        gawk \
+        wget \
+        git \
+        diffstat \
+        unzip \
+        texinfo \
+        gcc \
+        build-essential \
+        chrpath \
+        socat \
+        cpio \
+        python3 \
+        python3-pip \
+        python3-pexpect \
+        xz-utils \
+        debianutils \
+        iputils-ping \
+        python3-git \
+        python3-jinja2 \
+        libegl1-mesa \
+        libsdl1.2-dev \
+        python3-subunit \
+        mesa-common-dev \
+        zstd \
+        liblz4-tool \
+        file \
+        vim \
+        bison \
+        expect \
+        locales \
+        liblz4-tool \
+        zstd \
+        openssl \
+        libssl3 \
+        ca-certificates \
+        && \
+        apt-get autoremove -y && \
+        apt-get clean && \
+        rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
+
+# Use bash as shell
+RUN rm /bin/sh && ln -s bash /bin/sh
+
+# Fix local for yocto
+RUN locale-gen en_US.UTF-8 && update-locale LC_ALL=en_US.UTF-8 \
+    LANG=en_US.UTF-8
+ENV LANG en_US.UTF-8
+ENV LC_ALL en_US.UTF-8
+
+# Create a user for the build (we don't want to build as root)
+ENV USER_NAME docker-build
+ARG host_uid=1000
+ARG host_gid=1000
+RUN groupadd -g $host_gid $USER_NAME && \
+    useradd -g $host_gid -m -s /bin/bash -u $host_uid $USER_NAME
+
+# Switch to our user instead of root and start in its home
+USER $USER_NAME
+WORKDIR /home/$USER_NAME
+
+# Create needed directories
+RUN mkdir -p /home/$USER_NAME/yocto-layers \
+             /home/$USER_NAME/yocto-cache \
+             /home/$USER_NAME/logs \
+             /home/$USER_NAME/bin \
+             /home/$USER_NAME/xen && \
+    chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
+
+# Copy the build script
+COPY build-yocto.sh /home/$USER_NAME/bin/
+
+# clone yocto repositories we need
+ARG yocto_version="kirkstone"
+RUN for rep in \
+                https://github.com/openembedded/meta-openembedded \
+                https://git.yoctoproject.org/poky \
+                https://git.yoctoproject.org/meta-virtualization \
+            ; do \
+        git -C /home/$USER_NAME/yocto-layers \
+            clone -b $yocto_version --single-branch $rep; \
+    done
+
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:02:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:02:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420830.665890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWha-0005CV-OQ; Wed, 12 Oct 2022 08:02:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420830.665890; Wed, 12 Oct 2022 08:02:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWha-0005Bn-IJ; Wed, 12 Oct 2022 08:02:54 +0000
Received: by outflank-mailman (input) for mailman id 420830;
 Wed, 12 Oct 2022 08:02:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jpGp=2N=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1oiWha-0004qO-4w
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:02:54 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 4609e511-4a04-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 10:02:53 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 371F91713;
 Wed, 12 Oct 2022 01:02:59 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E3A43F67D;
 Wed, 12 Oct 2022 01:02:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4609e511-4a04-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 3/3] automation: Add a clean rule for containers
Date: Wed, 12 Oct 2022 09:02:25 +0100
Message-Id: <357fcb93114840125a450acc9cf3ff7aa138a7bc.1665561024.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1665561024.git.bertrand.marquis@arm.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add make clean support to remove the containers from the local docker
registry:
- make clean: remove all images
- clean-yocto/kirkstone-qemuarm: remove yocto kirkstone for qemuarm
image

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v2:
- none
Changes in v1:
- patch added
---
 automation/build/Makefile | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/automation/build/Makefile b/automation/build/Makefile
index b0dc68f00b70..9fbb49c8717e 100644
--- a/automation/build/Makefile
+++ b/automation/build/Makefile
@@ -4,6 +4,17 @@ REGISTRY := registry.gitlab.com/xen-project/xen
 CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile))
 DOCKER_CMD ?= docker
 
+define CLEAN_RULE
+.PHONY: clean-$(1)
+clean-$(1):
+ifneq ($$(shell docker image ls -q $(REGISTRY)/$(subst /,:,$(1))),)
+	docker image rm $(REGISTRY)/$(subst /,:,$(1))
+endif
+
+clean: clean-$(1)
+
+endef
+
 help:
 	@echo "Builds containers for building Xen based on different distros"
 	@echo "To build one run 'make DISTRO/VERSION'. Available containers:"
@@ -18,5 +29,9 @@ help:
 
 $(subst .dockerfile,,$(wildcard yocto/kirkstone-*)): yocto/kirkstone
 
-.PHONY: all
+.PHONY: all clean
 all: $(CONTAINERS)
+
+clean:
+
+$(eval $(foreach img,$(CONTAINERS),$(call CLEAN_RULE,$(img))))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:02:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:02:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420831.665907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWhc-0005dX-1F; Wed, 12 Oct 2022 08:02:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420831.665907; Wed, 12 Oct 2022 08:02:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiWhb-0005cg-TR; Wed, 12 Oct 2022 08:02:55 +0000
Received: by outflank-mailman (input) for mailman id 420831;
 Wed, 12 Oct 2022 08:02:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jpGp=2N=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1oiWha-00058q-R6
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:02:54 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 45a0ff17-4a04-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 10:02:53 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E81B1684;
 Wed, 12 Oct 2022 01:02:58 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5F533F67D;
 Wed, 12 Oct 2022 01:02:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45a0ff17-4a04-11ed-91b4-6bf2151ebd3b
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2 2/3] automation: Add yocto containers with cache
Date: Wed, 12 Oct 2022 09:02:24 +0100
Message-Id: <3003e61047b648a703768d3ab1e2b251190ee591.1665561024.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1665561024.git.bertrand.marquis@arm.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Create yocto containers for kirkstone with a builder step to fill the
yocto cache by running the build script once.
Those containers depend on the kirkstone.dockerfile container to be
created and use it as base image.

To run a build test on one image the following command must be called
inside the container:
build-yocto.sh --xen-dir=XENSRC TARGET where
- XENSRC is the directory where xen sources are available in the
container
- TARGET is the build target (qemuarm64, qemuarm or qemux86_64)

In case of error, the script will return an error code and the logs will
be in /home/docker-build/logs.

!!!
The build of each container can take several hours depending on the
network bandwith (for downloading all sources) and the amount of
computing power on the machine where the docker images are created.
!!!

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v2:
- pass --dump-log option to build-yocto.sh during the image generation
so that we have more info when there is an error during the image
creation.
Changes in v1:
- fix dependency in Makefile
---
 automation/build/Makefile                     |  2 ++
 .../build/yocto/kirkstone-qemuarm.dockerfile  | 28 +++++++++++++++++++
 .../yocto/kirkstone-qemuarm64.dockerfile      | 28 +++++++++++++++++++
 .../yocto/kirkstone-qemux86-64.dockerfile     | 28 +++++++++++++++++++
 4 files changed, 86 insertions(+)
 create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile

diff --git a/automation/build/Makefile b/automation/build/Makefile
index a4b2b85178cf..b0dc68f00b70 100644
--- a/automation/build/Makefile
+++ b/automation/build/Makefile
@@ -16,5 +16,7 @@ help:
 		$(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \
 	fi
 
+$(subst .dockerfile,,$(wildcard yocto/kirkstone-*)): yocto/kirkstone
+
 .PHONY: all
 all: $(CONTAINERS)
diff --git a/automation/build/yocto/kirkstone-qemuarm.dockerfile b/automation/build/yocto/kirkstone-qemuarm.dockerfile
new file mode 100644
index 000000000000..b6bd8ceee9a7
--- /dev/null
+++ b/automation/build/yocto/kirkstone-qemuarm.dockerfile
@@ -0,0 +1,28 @@
+# Docker file to populate the initial sstate and download cache for yocto
+# for a specific target
+#
+# This requires the build-yocto.sh script to be in the same directory as this
+# dockerfile during the image creation
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "from_image=img" to select the docker image and tag to start from
+# "target=qemuxxx": to select which target to build in this image
+
+ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone
+
+FROM $from_image AS builder
+
+ARG target=qemuarm
+
+# This step can take one to several hours depending on your download bandwith
+# and the speed of your computer
+RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
+
+FROM $from_image
+
+# Only copy the cache status
+COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/.
+
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
new file mode 100644
index 000000000000..f279a7af928c
--- /dev/null
+++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
@@ -0,0 +1,28 @@
+# Docker file to populate the initial sstate and download cache for yocto
+# for a specific target
+#
+# This requires the build-yocto.sh script to be in the same directory as this
+# dockerfile during the image creation
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "from_image=img" to select the docker image and tag to start from
+# "target=qemuxxx": to select which target to build in this image
+
+ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone
+
+FROM $from_image AS builder
+
+ARG target=qemuarm64
+
+# This step can take one to several hours depending on your download bandwith
+# and the speed of your computer
+RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
+
+FROM $from_image
+
+# Only copy the cache status
+COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/.
+
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
diff --git a/automation/build/yocto/kirkstone-qemux86-64.dockerfile b/automation/build/yocto/kirkstone-qemux86-64.dockerfile
new file mode 100644
index 000000000000..595643df5905
--- /dev/null
+++ b/automation/build/yocto/kirkstone-qemux86-64.dockerfile
@@ -0,0 +1,28 @@
+# Docker file to populate the initial sstate and download cache for yocto
+# for a specific target
+#
+# This requires the build-yocto.sh script to be in the same directory as this
+# dockerfile during the image creation
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "from_image=img" to select the docker image and tag to start from
+# "target=qemuxxx": to select which target to build in this image
+
+ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone
+
+FROM $from_image AS builder
+
+ARG target=qemux86-64
+
+# This step can take one to several hours depending on your download bandwith
+# and the speed of your computer
+RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
+
+FROM $from_image
+
+# Only copy the cache status
+COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/.
+
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:26:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:26:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420857.665918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiX4M-0001G3-7Z; Wed, 12 Oct 2022 08:26:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420857.665918; Wed, 12 Oct 2022 08:26:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiX4M-0001Fw-3S; Wed, 12 Oct 2022 08:26:26 +0000
Received: by outflank-mailman (input) for mailman id 420857;
 Wed, 12 Oct 2022 08:26:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiX4K-0001Fk-DO
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:26:24 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2062.outbound.protection.outlook.com [40.107.105.62])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e18bdf1-4a07-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 10:26:23 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7264.eurprd04.prod.outlook.com (2603:10a6:800:1b1::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 08:26:21 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 08:26:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e18bdf1-4a07-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SQpEZv1wzxSTgdBvPbWwAjGgNjvbh3MmckLQp64f6x7+WvDRQ3htrTZJRsMYOx8GqaNiz9nE1zbqpZRUElDKrYUflpclliylGW9WKcfSgnXSFb1ABCEw14zl8FV4I3G6c2Lx+/3ANBSmV1msBFQyjEV0BZ7VtWX9k5nXONvT1xelwiuappgG1gcP4mWecjn871r9rhwM0m4/vuT3EaSp+mRSRb0g90PRYB2baaNjPMVn4VPmm18pqRo1xZ040mr4Zvgdk/KDQlTGx4k2I9ueGTo0Gzv4x/mTEHjRY4eo0tAZzI92a1gjk2t82url9ofSO0ALkIQ0aneRs0et8F54Lg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dgg7KhMWK/fhp3AzmzNV/nx4McQ/qL7ZCFCDlYQpZjA=;
 b=B9OA96dF7g3Xn4/TEwtFten7txj/E1sdnXu+mWLh6HH0SkYYL4OGqzbx8l/S9pAtbgDlnvyPFHTG2BPCFqtwPjLEXGqehr+Xt2IYSxb2SUfNsUqIo+9EvP0E+NPgPGCEX9LvWrDPxb6CaS8VVB3vGANh4jzhKQUsFOFlxcn2FVmIttEGwrBQ3cYZvPqxv7U6YCEpBNyH5gw8/5SqrRGIiqUv2lkW6WYC+/783wlxYafnDGQ1q/0B7dXx8I78/P4smqu94oRjJZXcD2cdTHN6lKuB4f0O6WKgtQflRH0ycG2m/GNiL/g3zPh9FFBOc10nceA6A4/WD0QK8TCEsoQRYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dgg7KhMWK/fhp3AzmzNV/nx4McQ/qL7ZCFCDlYQpZjA=;
 b=q2n+N/BeR1hVL7vIYGHzEUbvTyE1L3GYaSFdeay5UkwYAreRyfY1+DZiH5M7ioHXOWJVDLF6m0rU09Zxh9V/IcK7xrgOzYQueA6gCMmIZ3FwJIS3irwdkWt4NP41TKvRIvIFjLlSxNK19lQbbu3dTkkzMV3wecko+PHeO3XUg7dpkMpGno8N2JiE1DsrCSoOVAyDmFWcoTawJSqKWcj+G7mIN0CNLQDFQBebiPxg2IlBtx1tqXE837FJFusXnppX8e4P2R/onl2BmIA64rTEwGoKTjBh0W+ywuFX2d+LDp3JUYUK+UxrHm4UeC48RqRosQO+DfE5fP2QfNPi07VakA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0ac3e95f-293e-d395-f69d-846f87edc0ea@suse.com>
Date: Wed, 12 Oct 2022 10:26:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 1/4] amd/virt_ssbd: set SSBD at vCPU context
 switch
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011160245.56735-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0015.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7264:EE_
X-MS-Office365-Filtering-Correlation-Id: 10d7429b-450a-41d8-6975-08daac2b7176
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	l8xvKHfjHzDDY4hxFPn6w1XIXCnt0Ls9XiVXJULR4QpCygcPsrEaIMfJ9LnzjjzIUALkVEYtU3pbowhwnD5sXKwADuKzHXZhUeB86RiT0q7U5/+14oGJ0fYf5LHDuD/f8wH8h/JTQw9EbrZeUWDXx7nAuDb2J874sAxbS1clIxqCbcuR1w6v1oGtkAj+MBFCyxwDL+ItCBOv0jznni5zJl3q70sHG8jJu46rQbeVPB7bveM8og+sMU3UV5UGdBo4/rfIujXODVu+Eakby90y4Y4YnqpFdYNY05Mt8i+IsdLzmAavLD/6kqytfZGQc9Yzwo4h4pbb5pXNKCEwLjzsByYAV/S+YyY7bLSVGXt3MRQQUi/3NwC0HRXMOvViXyv3IHDZyyCVQ6/j/ynnduBtXYma/tvJ5sRmBAZy3W25ml6fT/WBdpdNl8Dk3Dj4FmUdGrUKru7ArBboXaRJxqoO9S/0RbnM6Aqgrt2WCE757I0OvZ1ogv6O8x3FREoYi5KNb5FkrvTVbJlfWePvtkoA+yXeyLSNznz5rjnYUbckocxWMEB95mdCxTRE8LEqutrHju2Y+01+7mx4tn2OMX3zUis289wEA6+Gvaz9dsudviru8W7qiQTOki54mdn2vFE9g7NUDepdcWqqSYp2UZlj5/9wlVmYUm7WpNidaY8bqSKOygWAwhLsFzOCGF/L4po2kjLdGHjXKruocgcYxLxtIVm01TP4tIOyRYOBAGArBfAKjmpiuJacTPFTZtYe0rIayI/05r5Bsu+iFPP/k/N/gWQUffMr0yYNFj88HwozKKE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(366004)(376002)(39850400004)(136003)(451199015)(86362001)(6506007)(38100700002)(6512007)(66476007)(8676002)(478600001)(66946007)(53546011)(2616005)(41300700001)(6486002)(66556008)(4326008)(316002)(2906002)(8936002)(31696002)(54906003)(5660300002)(186003)(6916009)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SC9qQ24yVmhPeGNuTGk0bDROUUQyN1ppR2ZuWExPU0sxTjRlWFQxQ212VVMy?=
 =?utf-8?B?bFc4dFRlN0U0UW5aTDRZWVMzTVRsbEpiQitPbFNHZ2NvOTZZajZOUzBtdDc5?=
 =?utf-8?B?V2pEdEoxRkJVM1BYcGlrOFVzUGFDM05KaWhGeEZHcVBpMEp3UEJORzg0NUxV?=
 =?utf-8?B?VVNqVkpBRXBCVFVtM3lYMVRIeW1tQTVZdjNPWmhXbjlCNUE0SE1PRnpJcklW?=
 =?utf-8?B?b1lPMjlvVm1hTnBMcXVBNHhaY0hYa2pwdFRKRkx6REk2alpjWjd3R2pjalpB?=
 =?utf-8?B?amhoaXZ3dHY1N2JwMzRIRnYwTjVueHRsTFJib2x6WkNsajJMUHhsOXFRTmFY?=
 =?utf-8?B?TzVRR0RPVnUxV0dLT0FjMlV2cmNmRnMxZGtNNW03elJvdFpUT3lyN2Fvd2pQ?=
 =?utf-8?B?M0tHSDZmaEgyZ2pvbFZRTlJFOHBWLzhBbGt6MlMzMzJ5U29OVThmUXFHb0lO?=
 =?utf-8?B?aVFmWUs0OWk1dU5EMkhPc3grQWFzbjgvcGNmUXFIaERZS090VTJBc0lmdHhI?=
 =?utf-8?B?NWpjNm9qNGFERGNmb0Z0QkxpdTZCNjlxV09Vc1kvazlONTBPR2F4alBVVitJ?=
 =?utf-8?B?UlowTHZISEJkajJ0d3BsWlZTa1c2RmRQRFhjWk5ucVJITWxoaDZINGVqeUFP?=
 =?utf-8?B?MGZ3a3hIL3IvbEpXOVlMdENnbm9LbVZXc1dnMGxucUdrOFNjaXNkUm1ydHpW?=
 =?utf-8?B?YmZyRng2Szl1NEJOOXRYbDZDeHp2SHVHUzJVMUxvWHFNVElSbThIRS8rYllT?=
 =?utf-8?B?QlR4RmFrSndWTUxjUjdMVVY2VGE4Z0VCZ2lBYlIvYUo1RzlJaTF2RC82WUFJ?=
 =?utf-8?B?QTl3OGM4RmJjaUtCZ2RrSjFGNHVCY01vWDZubGJQaVAzZHJVN1FCMklXOWVj?=
 =?utf-8?B?OXlvVEl2cEZISXFYcDBudkFoQzBOVGNhMHB2YjB4L29BTGdoR0pjaXZscnYw?=
 =?utf-8?B?Q1VhUkFDVmVWNGVJOVRRWE8wM3lvOXVid09RdG8wNUJKL08ybFh2aWNIR0gx?=
 =?utf-8?B?U3VSTk9OaWlobHN0RnVwUGxPMjZPYU1wK3BqQzNzNUZvVGMrd0cwWGR2WDZr?=
 =?utf-8?B?RDJHYU8xY2k2elpVTHVkRTRCU2hMcGRCWGl2aG1WbXcxTk01cGtTOU95dzBa?=
 =?utf-8?B?eGl0VGNQeUVnYkN6U1l6NnlobU5PcTE3dXZobXJ4NXpqSDRrL1VMTlhxY1FU?=
 =?utf-8?B?VGYrdWVxcVhseUdzSXJEVllKeUxlSlQySnQ0TU5zMzc4bE1mdjBjbWpnQXN1?=
 =?utf-8?B?U3FXSUp1Qmo2dFhwNm1MaEJvYjRPcWQxc2tSOW9EZUlpNml1MlZYZzNLUmgx?=
 =?utf-8?B?VUROcjJoczVMK2x0dy9XTnovdk40ZEhZNkVBV0pTU0phNHdBV0RBRldOOHhH?=
 =?utf-8?B?WWd1QVNnY01VanBGODVvaTNjd3VpeStzWEZrUWhxcnFqVkdvdnVtbkFPbkdG?=
 =?utf-8?B?MjFSemF0ODVTSFBIUC9iYmkvZ0tyNHBKWG1ubGRyV3l6bzVVRmFyZjRQbVhi?=
 =?utf-8?B?STNOZGF4NE1QOHF0UGszcktHQWFzbURMRmx6Sml1U2hJaXpmemo1UVh4ZnBR?=
 =?utf-8?B?blJzSE9zQmU0K2krN1JkdXRHN0psNXl6dVpDZU01aE43Yk9MOU5aM3JDUmM3?=
 =?utf-8?B?K093N2F5RUV4cVZjcTFPR2g2SSs3YlhlTHBPaGtFM0pTTzBqMCtaRTE1dHQz?=
 =?utf-8?B?Zk55UVExRjB3SlRCNEYxcG0wdUNBT29GUDNRa3EvTW10SkVDZmRaaklwYjI3?=
 =?utf-8?B?SUVvTDVJeWJmVDBLOUxNWnBTSEJMWEVaa2NyQXVoL0ZIRExIeDRweW1PeEF5?=
 =?utf-8?B?RDRHR2h0U3R6OTJZRXNFbW5OQ2JFdHpmcGdCY0ZrMmNQMURZS1Z0VVpiOGtU?=
 =?utf-8?B?azRsaTBvQU8vU2VBUkJ6c1JoUHViSm1OL3BBWmpLc2ZNeDZTblNNRDNOUUpD?=
 =?utf-8?B?eXZxZjQrMC9CSEJmSm9nMHJ6ZFRJRkhVdkJXa2hTRm5DTEJWK1BGT3hsWFBZ?=
 =?utf-8?B?MmszVlB4NmNCZVl4dFF1RmZFVTRab1FianR6dUt1TjhGZnNrbHRKZ0U3UGFj?=
 =?utf-8?B?ZVNkV2NrekVkcU1Ka3VLNXYzSFUwNWtOa29QbXE3Mjd2dmw2WHR2ZE1YNGhh?=
 =?utf-8?B?Nnc3Rk9GUjlvNDlkMXlUNFJkVmlnaHh3bVZGMSszcWtkN2p6ai9OM0k3Wkoy?=
 =?utf-8?Q?ELQ1wg4ZCYYQXPR3KuM92oaTTnadE6lUPPRntI+gJRZq?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10d7429b-450a-41d8-6975-08daac2b7176
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 08:26:21.5690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Omrkx5g8RL+Zteuoq3IGEaNxpLJ0uDNtKT2Yn2loWSBFkRqGeN1z4gHIFNXBDuvwPBf88OD40k3unHnZ7NyEsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7264

On 11.10.2022 18:02, Roger Pau Monne wrote:
> @@ -140,6 +135,7 @@ __UNLIKELY_END(nsvm_hap)
>           */
>          stgi
>  GLOBAL(svm_stgi_label)
> +
>          mov  %rsp,%rdi
>          call svm_vmexit_handler
>          jmp  .Lsvm_do_resume

Seemingly stray change?

> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -973,6 +973,14 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v)
>  
>      /* Resume use of ISTs now that the host TR is reinstated. */
>      enable_each_ist(idt_tables[cpu]);
> +
> +    /*
> +     * Clear previous guest selection of SSBD if set.  Note that SPEC_CTRL.SSBD
> +     * is already cleared by svm_vmexit_spec_ctrl.
> +     */
> +    if ( v->domain->arch.cpuid->extd.virt_ssbd &&

With this false, can ...

> +         (v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD) )

... this bit ever be set? IOW if the former condition actually needed here?

> +        amd_set_ssbd(false);
>  }
>  
>  static void cf_check svm_ctxt_switch_to(struct vcpu *v)
> @@ -1000,6 +1008,11 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v)
>  
>      if ( cpu_has_msr_tsc_aux )
>          wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
> +
> +    /* Load SSBD if set by the guest. */
> +    if ( v->domain->arch.cpuid->extd.virt_ssbd &&
> +         (v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD) )
> +        amd_set_ssbd(true);
>  }

Same here then.

> @@ -2518,6 +2531,10 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
>          vmcb->spec_ctrl = val;
>          break;
>  
> +    case MSR_VIRT_SPEC_CTRL:
> +        amd_set_ssbd(v->arch.msrs->virt_spec_ctrl.raw);

Would seem cheaper to pass "val & SPEC_CTRL_SSBD" here.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:27:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:27:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420862.665929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiX58-0001mo-FJ; Wed, 12 Oct 2022 08:27:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420862.665929; Wed, 12 Oct 2022 08:27:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiX58-0001mh-CZ; Wed, 12 Oct 2022 08:27:14 +0000
Received: by outflank-mailman (input) for mailman id 420862;
 Wed, 12 Oct 2022 08:27:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiX57-0001l6-GE
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:27:13 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id abb9da21-4a07-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 10:27:12 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7264.eurprd04.prod.outlook.com (2603:10a6:800:1b1::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 08:27:11 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 08:27:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abb9da21-4a07-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bjqY8p+ebUI16dl7Opvx+jw0SrTru+sKl47bCAODOEIy4tEIZgRGGxbbjyUcERFoez/2q3+JNYdfBv9oEAbTQVLNnO5ytaEIllGrxtvINfUIqOpyX7L+am4IJtz6nF6nldO1WzS0s6spJ1hnIvv1LgnitXRRUfJyi+G5qx1QTrYb4LCKYL+eQGN4xYpUAIeOWHuN6GMt6MADb2aYCBcbRhHNeLmRfQ4Y6CKfPBN/baRv5qCJcKLN/GXhtZCSWInta4xDua6hxf7CM8ieb5rNpP8QwzQGpW3fg1DcqXA0bjwPHEhLdjVzRPW5Z9XWBRMRvvjyTN2SpazwLevsOdtprQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hwHZdTiehv9+RkMjfVK3C2msH7GAW7q9G54m1RepLv0=;
 b=Civna5LcyKcJskYWOgCq18VSs8g/e40g6w0sYjK3Ar3r7MXp3GFIBT8fgOtzRw9jGFkiG0S4zth7aFL3/hlBAjjZpIjsu0PQMwMmGq0MtTYzDzk4BMvQm9CNk5MQJ5anmYlqT2TVmApXDi83udGQn5C++Xvhv7+0P3hZ0xbVV7lipN0dzWQLPrrJIkqbM8u4bYJNkbLI1LIwMsqpOqjyVbP3SVimz37mVojzrzIltF7Y1YvpkNhOCt5dHQKgm9zRA9W8uM8TE7e1dy9Sagdu/spLTR3MJ13jDvUuIqO4KAjeUM2+XZlogjBh4HX2o9EzOadx72ZbxGoKXtz7sWDcmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hwHZdTiehv9+RkMjfVK3C2msH7GAW7q9G54m1RepLv0=;
 b=2KC0OagRZHz5O5fmAXL+5c01voEI6JkIfxTA7MIJ0yBiuWbgh11yKYFyoXGpEs1SBbITZlrxVWDNnbJYB44n8xOji5Ji0EMtSl+eAAf8irAXsdPYwhp/UfhcTnNms7p4l72n43JOMTY4XTB/pMakdGd43of48dlphhAgcE9vsYKI6vlcwSeFnr6q8s2GaxP7v2JpQqiOBGaTjV6UCrVyHoSyqOgXETr5OCIaHMRF1z+NoCJFsMBh+foLe2AP71VV7iC6Ta6RLrD4vFI76F7tPnHLAQwyvdvwvBOjgZ6VNb2ZYvIlGPI+JVF21KOMF4O8xcAPgq1Nj9XrwvlcUG50FA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3510aeb0-6c91-89d0-d35c-ac2a0eea940f@suse.com>
Date: Wed, 12 Oct 2022 10:27:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 2/4] amd: remove VIRT_SC_MSR_HVM synthetic
 feature
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011160245.56735-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7264:EE_
X-MS-Office365-Filtering-Correlation-Id: 74b3d9d7-c7c2-4f26-f1b9-08daac2b8f21
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5vauyi2QL7SVNSSccMaa566VY/pIlNn/AVgc845jUAJ+66AixPSwrSKcfcJcgdeX6G9HgXHTQFgsz1jy3yqtYgihIo4wBSGEYEhXvFfC8vFcxfh+3i7dHMdEYABDoAMREiVhWkwu4fZa3tjTme0XzpGfLy07LJ/MiBDgjfOgumr/b2hV1XujWPjfvEFilYvITYiJdJyr/6ElvDm5Bo2ZDi9FM9JwuBjOih//g75yNcfTbQR1wPTZ2L6rHTPZp9h3R5F1SZGPZC+4qIIoxWeK/l+S34afKsh/bYkErJKzQrlXseSoVaVI+iL8QtH6Li9ZiaCv7dEZVIyV+uAY/cVPOfFUqGO8ZCDtf1mt1pqPWUtwqFi1dDS84W4WdyxifAEiFmikt3bplqdizKvfyfmn1G6umKZgB93b+Xzg43cdUg6jXhFw4AdpYMnK84HAokAtRdoExyucUaLEu9AmVxwM/aq4zdv3iYTTp1DXSKTE9VM+6Hp+LY6NyquFYMOlyCdNjMRyReLPD5kCY309vk2RDQ6O5lOS9LKeOhcKHY6j0yPeFuGpNZcjRGMxw5C7WjcCzDM/psbXsDnRicRMc14WBo/8/JPAoAqiykKbgdt59XlA4cnVPC6zMGNcprk8N2gfHYlyAjwhn9d21AEYiUN+IlHwG4a9jAQjSaBtQkQWeZ4TeJKv5mRI4JlDQWhr2Ok9qQs0A5m6Kj2oCQ8kU7AUJTTwN2DZAaS0n1fa30FBH+uhZ+nHOvA8Fn9CGjwuJNp6q+blDX9trXutUjtmsJepyYb/bafdVzD92vP2wjYbdhw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(366004)(376002)(39850400004)(136003)(451199015)(86362001)(6506007)(38100700002)(4744005)(6512007)(66476007)(8676002)(478600001)(66946007)(53546011)(2616005)(41300700001)(6486002)(66556008)(4326008)(316002)(2906002)(8936002)(31696002)(54906003)(5660300002)(186003)(6916009)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aGJEYjZhd3oxeW93cGl4RFRmOVBZUFhOblk3b1NTRlZqOEhPNnBkSFZsT1Bw?=
 =?utf-8?B?akZpR2ZMMHJQZFlFTy9Qci9XS0x5RWY5YUw3OU1lMXJTNnhrUlZXWTlKMVh3?=
 =?utf-8?B?aE1HTmtlaE4rYXQ5RytnZGh6MGY0OWpVOWRFWWJvRXorYVEwWWExVjZvNXBB?=
 =?utf-8?B?TUpsWDJ1TmNyUmsvYlJkckZHRFRSYmZ1MkNKZVhSbVpSaWE4QlVaMzlPUGEw?=
 =?utf-8?B?Um9DMzBTc2ZhOU9SVU43S255RkZuRzZzN1dFRDBzbkdvaUVZaVoxckZETXZK?=
 =?utf-8?B?bHZaOXRON2RpTUlnMi9Bdzh3cklOSGhCYkJNVHZZM3hqTFVyVy91SThUTW5N?=
 =?utf-8?B?OVB0MGxmRWpQWW1RQk9FaUJoajY2V0R1MFEvaUxHajRjcGQ1ZWh6OWxhZ2Jq?=
 =?utf-8?B?MnhwbFJrKzgvNWZSQ0NOMjdwMFRTUFJLeUlTNjU1VnBhN3kwby9hdkFFcHdQ?=
 =?utf-8?B?SEpOcHV1dWJsb09UOXdFSnh3VElPS21vWWNDSFFqMEMzczZCekNLOFBsdVVW?=
 =?utf-8?B?S1hCanR6QklxUjVqQ2VUKzA4d2JKeHJETDM2MUdoL0Iyd1VtREoxQ1lnbWcz?=
 =?utf-8?B?SUJIbS9KUkVCYVY0YlJRVTVVMlp0c1JaNWxLYmllYmxxampOaG1EWWVGYWJI?=
 =?utf-8?B?L0VFRFZnelZUU1JsMkMzWmxON1RqSmxBTTl3aDN4dU1HTzV2cFJXUTAyQU1D?=
 =?utf-8?B?b0lrWXFmeS9wRkdHc1VGdUd1SXh1cE9oNk5mT01ZK3VRaHdQNUZ1eGVtRnFL?=
 =?utf-8?B?Tk9EWitBU3RoVFFBQ3dUM0t5bWFEc0UxYW1KNHA5R3B3M3hoQlFBamVjZ05x?=
 =?utf-8?B?b2JYWTJrNDZCM3ZUV2I2SGQ2cHNFdG1Wdi9hbVdMaHBMRHJlVjVud1NQK21o?=
 =?utf-8?B?dk5hQXB3SkQxN0hlWnlsU2xMY1R4MjZTbEdETjUwYitVMU9iVWoweXVVU1Bt?=
 =?utf-8?B?aURVbkJpNWFzWlFkSURKWDM4Rkkwb1Rpa3ZaMkY0QlRHK09GMzc3WjlKbFhO?=
 =?utf-8?B?Wi9iLzkzVnkwb29GY1l3MDZLQnFSVlg4dkpWMmtOSkVrUDJvb1dYcnNJTzdX?=
 =?utf-8?B?a1Q4R0l0R3RiZHkyUHZKRjVDSy9FSVhvWkVNb0xQcEozelBlZTZZNnBDRXor?=
 =?utf-8?B?ZkNCT3ErbkI1bk5wYkoxU3g3VzFzekk4ZU4zbzgwMTdEVVZzYWo3SUNOM0Jq?=
 =?utf-8?B?bmczcFVQVERrMDBGQVBTRkQ0NTRNbHplU2EzUkJuTnZOeXVRdE9sMlNrcEow?=
 =?utf-8?B?aHlnVzEwc0MxSHVkYklRUUpOMU1kdGZJb3k0RWtJUm8zWEExeU5FMWdocGdj?=
 =?utf-8?B?SkR5cGFZelRSR2xUYkgvMHEvWG1pdVlJNlVpZnB6aHlxT2tCcjBaUUh1SUV3?=
 =?utf-8?B?NE1ZL2xlUlF3Wi9LMHNJbEV0QzB6MzF1L1dmZ3poY1JZNlh4SDZ3TU0vMTEv?=
 =?utf-8?B?c0ZzaktLV2NDUS9HNFlIcEZpMDZMbkxyaGQwV2R4Z0x2MEVtV2oyL0d2U1Bl?=
 =?utf-8?B?S3ZXNVg1aGtHVDhRSUNERGxOSFQ4L2tuODlmWjhxOFp1STJFd2drNytlME5s?=
 =?utf-8?B?MTJtM3BsN25PK01MNDlhVVJic3lvZVFKQzRROVp4VjFhNlc2TkNtc0haVWto?=
 =?utf-8?B?eWNlVVAxZW82QWNEMUZKUEdqQW0wbEdKd0hJQzZPK3pSUm00aFpaV0VlWk00?=
 =?utf-8?B?dXp1VXpmOEs0Z2VlSkpnQ3o4Rk9xeDMraERjaGRYWTF2ZVJzRHR0cURQWURI?=
 =?utf-8?B?T25abkxiS2hMaWErSXppZ2xuNjVoM0Y5NjJXa1dGZjlNbG9SR28rNWs3Qnhr?=
 =?utf-8?B?WU1SbDVaUDZvTUxHTnF3MXEzWFUyUU1JSHNVU1pPb2J5bTdtQ1ZlYTE5RGpY?=
 =?utf-8?B?LzRMeFo5bk9ocmpuY1V3aUFlbjI3eFRnRVgxODQwbnZjYlZTMkIwYXZJUGQ2?=
 =?utf-8?B?ekk2NUE0UGRic2F2cXhSZ3dyRGlaVjNuWllRelp3dWswM2UyalUxNFpYK2VI?=
 =?utf-8?B?dGJ5cEdIZndsZ1BSVDQ3VXdTc1dVMCt0SjlpazNuc2lUYXByWTJtcFYvQThw?=
 =?utf-8?B?Tk03dlBaVDc1Y3gzbmx2QjZVeDE2QXJ2c1NpbVNPQzVsT0JieDJsS1FJbnVF?=
 =?utf-8?B?SXJpK0dITm5mWlNiMTVPYy8wQ2NsSFF1YnJHUHVMWnJuTFJlZVcra0cxWVEw?=
 =?utf-8?Q?j1N/qu//PPfTr2Gkrb5hyYc3RCkbuTgVVcDuev6O3vUx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74b3d9d7-c7c2-4f26-f1b9-08daac2b8f21
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 08:27:11.3002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NG1xlyMNckSTgbnHMpmfNfB0uMQMbi9nh7r5lZRn2EOWYpEb95+ywOjLwqU6EYAuZHH6O/l9D/mMZBLYCsSeMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7264

On 11.10.2022 18:02, Roger Pau Monne wrote:
> Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched
> on vm{entry,exit} there's no need to use a synthetic feature bit for
> it anymore.
> 
> Remove the bit and instead use a global variable.
> 
> No functional change intended.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:30:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:30:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420869.665939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiX8c-0003FJ-Uo; Wed, 12 Oct 2022 08:30:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420869.665939; Wed, 12 Oct 2022 08:30:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiX8c-0003FC-Rd; Wed, 12 Oct 2022 08:30:50 +0000
Received: by outflank-mailman (input) for mailman id 420869;
 Wed, 12 Oct 2022 08:30:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiX8c-0003F6-3d
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:30:50 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150087.outbound.protection.outlook.com [40.107.15.87])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ca08a5d-4a08-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 10:30:49 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB7048.eurprd04.prod.outlook.com (2603:10a6:20b:11a::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 08:30:47 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 08:30:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ca08a5d-4a08-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ISFIED9PqVbaaAlq7hY5PKZuLng7UPazmI7qTME+glzO2pvHnrp/CF8QKgoRTyAzAZB7Ex5Phx+KnUY9+7jyVF/YY0m1pdNEJjmP+7cRf/DUxSi6ryoCCBZxSw8B4SyVCxUb+lpLH5AhqWuyTzOZYanRKyT6G4eog5N6AiqEoRz514FzkKa+lXJe8afcSI/Tp8lMIaLZXruJQ2WskpyVSwgipML/YHsiSdWx793WVZ40ICCHv9Hpt78L8Rxyv9UGdlRfAFnyXTL4EM5sl02gP11d4T//1PzZCk832MHlCB/qAeU5E7Jjqk81+dp3UFIzchX05E+KI1IcKo2DpRseXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vlRd0ejKm2CgnenIsDYyRVNhvj0pW/NxbxCBLpCkHD4=;
 b=bLuyl4Df2h3hVZD6ZSnojLrxwwCVqjod6taUTTzAqc5TjPhmU9VgjaxQmBqbz4me1lGbBOSa0E9OoxKQyh8KvZ6SWA0MpL3kxS9UEDwiVhRjYnp1Ykjv6q2sVBzLl+jBlnursdGf8giyKgZ4w1GATj54aKariGJdVabeEsrNDlFb5/7o14uTWj4Z4YOBnNfu2i2CYq/fBikTWaRiq1ZQLNLXiypym3ma2M+6y32TX2n1KvPTyRmX5Nlm1ryH7QfGb8DvA+9Qa07hRxlClDbBJMRT0knRhJDNejkLmzkmE65IWkiR9EmZGpYfxB8zIW/a0SHUs/SNKq4NBcPzBFyosA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vlRd0ejKm2CgnenIsDYyRVNhvj0pW/NxbxCBLpCkHD4=;
 b=EXZK3fT9kcLPZcAAa/kxqjXWfiK+ndKfsPWNj99ng8+GZi7E2LxjdmqyUB5syE+yizDgNO0n0MmOoDWLGobpJ1VdW6IyC+k/jhLo6BcFvgmZnkTAj2x/Ro5lX2QzO968ZXGjZN0TMkDjANTcDbEAzEZii3qgeA7PEMmjEMqA4gclcEm8oMYuc1/evDVS/lvKzfgb5FSbStnM+yqEufiI8vfifCRCsBt0FZ2IgX6/8n9KnpPEmAzZ3YpFWHUr4ER9xt3XU6lSF6fAm90IlyrvhvtB5LEdf243Yy2r5u3Py3ZfuZqgLCjKIpGv/OuQtpNZ8sHaAYwGNJOJi5cp/PmPeQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
Date: Wed, 12 Oct 2022 10:30:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011160245.56735-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7048:EE_
X-MS-Office365-Filtering-Correlation-Id: 16d7eaac-517a-4b74-f8c8-08daac2c1023
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	k230hvDSx1OyUYx5xQU6m0hXdr4RSZpp67yhVhJHV4ucG42EJeov/ZkMCbG/jjjswtmd10Mwmt3k/MY7Ml5++uSuR6aklkWEmNNkv7tAxnZkQYbBLMwZeKjA+zNM+0OgDBn7TUnLp+6Jos7WRVQl7LV6iLGJZVUqgQqY+sZYbxr4ryk8EEQO45BarrOgxj4dVQIYD5bOw0f3UiG6byZ+OQDGJ6vsaaA1pbcq//Un7q0BclEWoDqEJAydEX4cS109EGfgIsN/P+uX9zSqs7uqF9ShB1m/rsQVtZGHQxDcouy3CdfqdBdCZl/G3LJO2UCZ0hM3h/RMD4FLlLQSShkomI8App/S6/1iOM/HNlSRm5YckcegCylqFZaKbbV+iIBio+2mfe+Z0rjbnU2Rfvbwi5WiVUcOdTeiA/xo3he/Oy1bzJMzfBg4IQbC1BhaTXS5iRZnlWI8wFYZKGo7alNlAc0NO2HNY5IGLNoWA7j/gevVnh8RJdTBzsXklvXKNBKaj0D3GWcX/p6X1ZJ6EryusApHFZmo7g4aOxKxzX57jB8L422D5Zpfv/Ck2bqWhx5t4EGl3VYseSdbgFobgqwRaPjZdL2JD4E/MeOPKUCl3I+BmZ56mDvfg3v5tHZ1VGhltCfTXs83XZ7r2Eh4xLi8wc6TrLS+ErSa3DudoZw8a/HLoQ9Q4TTGD70H6cgCQHVnODAg+n9PQqgXwZwN0LsCAkxab7GFl8XMPvabIpRj3ysR9IbQkUihxvJKaDeRdMhI9wmLL1yG188XyOAy+F7LYVx5POC64oCxXMCkGd/Nmzo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(136003)(366004)(396003)(346002)(376002)(451199015)(83380400001)(8936002)(66476007)(66946007)(8676002)(54906003)(6916009)(4326008)(66556008)(53546011)(478600001)(6486002)(41300700001)(6506007)(36756003)(38100700002)(86362001)(2616005)(4744005)(31686004)(2906002)(316002)(186003)(31696002)(6512007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWRvV1VGRUNHZG15TGZRelViVHFvNklQK0xLOTZ2SDA4eGJRR0cwNG5nTUoy?=
 =?utf-8?B?QVZSV0RiRDZYczVqN2Y0QUZidkFWaGNBOTlzK3ExVjZzU296M2x5TnZsRC9j?=
 =?utf-8?B?STFWMXdtQ2ZsWmx1Wmhmd3ArWXY3UHRIUTVxTHVDNng2Z0lEVjM1UGNuZXh5?=
 =?utf-8?B?T3E0Sk5yVWwxMHprRWRBTzB0eHNYT3RVQjlXS3NZbHpCSEVaOWpSMkRhWmxO?=
 =?utf-8?B?Z2ZQOFFWV2dTd1BGNldvRVhhbXJ3THRjakZrdFZkUHJhUUFteFlNdUJvL3M0?=
 =?utf-8?B?Q3E4bENvMFZobDVEd0xjcHgzam1QSXpEa0dlNFpHN1VLOHFLQTVRSUpxMnl6?=
 =?utf-8?B?QXFJT2JSb1VFN2xjNVI5UUhsbHhHa21CbVBMTG80OFBsTVZpYm9jQW1mS21v?=
 =?utf-8?B?VEczbjBib0RJWE8wbGJVYWY2ejczTHlkbnhDMUFoZE5RU25hVlNBL2NjVjRR?=
 =?utf-8?B?aU9RcGMrV0tDeC9qaHpkemRXT0VhWHF5NEgxT2xMMTZ6V0VtSm1kMmZBSWZk?=
 =?utf-8?B?Qk9rTVBmZThiR2FiWkxEYklucUJRK205M3BlUVBTL0pZei9WbXZrL053aXNo?=
 =?utf-8?B?QjMyMWJJTVpzNlVNTmRqRlIyYjV1MGxTazE1Yk9HTGNFY3dnWGZhckFqYWo2?=
 =?utf-8?B?ZHNoUS9udVJCVUVxN2JjM3BuTDc2Nlp5V1I3REJZMzZxM2drMFhERW82clZh?=
 =?utf-8?B?UmNrVFMySUdvUTF6QkhXcnJWTzhHbGNvSDJzaU1xRDRBcThKY1kzb2NJNVpX?=
 =?utf-8?B?NnRFdlhFenZYL24xSGJIdDZyRHV4MEhkNWF3eWNYVlJZMG5ZcFpNOWVnZStF?=
 =?utf-8?B?a2xkVTUzbnNSMjZET1ZmT1NJenc3djFXQlZqUXRCU1hheElNTVhwYkVCWW1y?=
 =?utf-8?B?R2o0NytGMVlncVN4a296bWhVeldDMTNGbUk2eHBoQlpndmtSWjVlbDE5eTFT?=
 =?utf-8?B?dXlVakxwTHYwbVJ0dkl2ajRaQzBFWEl5dmQ0RzlaTDMxYWhESFl5Vml4V1ZZ?=
 =?utf-8?B?QzR5UUVVSTFUcnVVUng4MmlBUkswRURsRHA4NDdOZitIQ2F6aEdSYkJRSW9u?=
 =?utf-8?B?NmZHM2xrSzRxS0tnL2VTSmNTRStVWEFDSnZManJvc2J3NGNEZlJhcVpLa3pz?=
 =?utf-8?B?dXhmL3drQmlzc29LNEtXYlpORWtOY09ZZHZlMXdxS3JWQlRzYlNtWGJwQzZt?=
 =?utf-8?B?R0ZtQjhBUTArd2NNYytuNnBoZFFiM1B5TE51bG9HcUViOEZLbVdiU1czU0h5?=
 =?utf-8?B?ZFp1ekNxQU0rZ25HdTZOdkdvMlVkcVgxbW4rMytPZVVzNm9tQWNaaWRYKzZF?=
 =?utf-8?B?RlEyd0JIR3NvRDI5TjNEc1lkSDkxdkI0MlRzdHBzNXY3OVUxMW5mZDhxY0lp?=
 =?utf-8?B?aVcrQkU5U0lhWnFoMHM2eWVBNDZsbzhRekZrZ1JrSmZCenhzK2JZUlE0M01K?=
 =?utf-8?B?R2lmS3B2MlBYZXUzL2twdFJ3N09FWTFDSWNNSHlDcGpxaXJES0dpd2ZsYWd4?=
 =?utf-8?B?bGJrN3NaQjRpZWtYeEJCSXY3OFJwdXdvT2QxeDJrUkRUeHYveUlXS2k5dTZH?=
 =?utf-8?B?NVEvcVZ2a1YwOTM2TFU1STh1VTVRTU14U0oycXdubldzMzJRM2JaUFBwR3pY?=
 =?utf-8?B?UXBDdHVhQjd5MXdJblViblVkb0RDM3NQbFBRa0p1bHVETFNkRnUvdXJqWTVi?=
 =?utf-8?B?Y3FiNW81b2UrLzBZbzNJRVRBWVhRdTI4MFhZMExzamNLaWd1bUxMSlFNQ1RP?=
 =?utf-8?B?M0tZVFRZRXRyTWRpMUtXbnAvemJrNFV3dy94ekhaYTZpYVJBdGIvaTJtVEJL?=
 =?utf-8?B?TXF4NWpsMHduazRpQThKRjlmVkdzOENKNTdjSHNaUnhVMy9Md0lYaUFLcFFG?=
 =?utf-8?B?VmY1REZnd1l4bVFSZXgzOTFFYVNYT29nc09RejFNdFFPTDlGKzZaN25mc1o3?=
 =?utf-8?B?Rk1QOENLekxuUjNFbGs4cTRVd3lybTNWS2t1UlRwTU9CUk4yQjVrNEllUUYv?=
 =?utf-8?B?L3RNQjZnQk1CRW96eGVseFp2YVFlTEk1dG9EUWMxU2ZVaU04N2prOUVzVWZy?=
 =?utf-8?B?cVdiUWlmT1RsUXdwVzdkbCtUbndTbDN0SWUxRlA1VnJMK2hHZ3h3dms5b2s5?=
 =?utf-8?B?RERFRXhQWTRSTTA1YVRHT1VNcWRadGJMTVFOd04zRmsyZDZnVVVDWjY0Tkdp?=
 =?utf-8?Q?jgy7VqsgzkbPeDnpFJu1UkWJ6slD1BGVexg+9PJovfFg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16d7eaac-517a-4b74-f8c8-08daac2c1023
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 08:30:47.6771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9C9enkXZAbdwYzrtNedxFi8e5FyvysmbY1jnrXHvco42b1Emyu5ZmSKo0qJOhjlqit9NjkZHfhofSLZ12gurqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7048

On 11.10.2022 18:02, Roger Pau Monne wrote:
> @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
>  By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
>  when hardware hints recommend using it as a blanket setting.
>  
> -On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
> -option can be used to force or prevent Xen using the feature itself.

Why would we want to take away this level of control? Shouldn't we turn this
on while in Xen if so requested? Which would then either mean enabling it on
VMEXIT if a guest has it off, or running with it turned on using the OR of
guest and host settings.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:37:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:37:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420878.665957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiXEd-0004D1-Qy; Wed, 12 Oct 2022 08:37:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420878.665957; Wed, 12 Oct 2022 08:37:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiXEd-0004Cu-O0; Wed, 12 Oct 2022 08:37:03 +0000
Received: by outflank-mailman (input) for mailman id 420878;
 Wed, 12 Oct 2022 08:37:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiXEc-0004Cb-Ha
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 08:37:02 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2056.outbound.protection.outlook.com [40.107.104.56])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a6ff69f-4a09-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 10:37:01 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9455.eurprd04.prod.outlook.com (2603:10a6:20b:4d8::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 08:36:59 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 08:36:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a6ff69f-4a09-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eZ9wa3M42YxW+0Hn6jgMQw1GW+7dNdpDGOxUy7z6zgU+2slj3Aeocxb3eZWIQo29OLapeNAgkevuVGnYBfqKns78upFsGPnFXTJSFLuuUlun0luWOgDBMqUykEwncq/dTwxxldV2ImKAMTibu+YvTNqcv6LELihm85yvdg5fZFfsTlmZsV2sbDe+0CXFF4baP7ektSKOxYqnLQ956PgwmvhI7uyrxeIfm2Z+U/VLS2bKTiTqA9PWGwyQlr5dOe9W0qsTTV5+puy+wK4y8ZsiMQUr4W7hJsw7ogt5WKnLSaJEeoX4X4RdP5mSwJFhJUhRvvlUQY9QTd5oVnPpjRgxMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vpCbc1UXGVDHC3hoW7/BwA8ZrprD1MAEJdnQ3iZsO/c=;
 b=lrB1IhHLRdB7G1Y3sLX/E5xDex3WSpmFtPBtONQQ1CjkkleAJ5sFD6RVSGkij4PxPoirOOYHRONpnTgPAPoNA1VnGmRtcqacAV2rmtu2huHNFwAkkRJ8sUZFUa6pZzbx4XK+RaXz7LZMq0zacM2wBhvRLPLzJ4+G7qLS0KfRsfqrxU4bQhcN6YPLrh61M/dexW766h50bkgR2FUXwSwkp+0CPHVPArkb9iazTxfvOFkgMhKIEvC0mQu5ibbDSWo5oSmAyeGNjkqw9Mv4a69CP16IIUlvePMHQnrX5ex/NYU7+/66LQfMsDt5+gMREZdEigZYBqnSF+FF13/1GwRw8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vpCbc1UXGVDHC3hoW7/BwA8ZrprD1MAEJdnQ3iZsO/c=;
 b=uVKoFg7TX1PM5w7MiQcmLZyt5r7PRpw2EG8413Qg0j3BzEkKurwbG3tjgZWavr5L6DSaS5BbyRSKUpYS23NVIs/4yU9aN1SYZmqay6b+95KVHFQN5C3a2d/++n80Un0nV2CN2SIgl0XCuL3O7npir2M9MMYNTMMn9S4sJwwkFPcfF8Qq7gVMRfWuh3h3nDWjBUDGyePCMNiQmHDEwoZeYH1nOiagY5Bg3RQnagpi/GKKlXyPgu3m4w4EV7xJE/iuc7Z7oYqfsliv3U0L9sZpu+k3cjIFJgHYAOURLSiSQO0PGv0VTD6dMPF/GgyGm3Zobciigk3aZ1JuQO9EJGpG7A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1f70c472-1b62-7c79-dc31-65fca8040cfa@suse.com>
Date: Wed, 12 Oct 2022 10:36:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 4/4] amd/virt_ssbd: add to max HVM policy when SSB_NO is
 available
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-5-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011160245.56735-5-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9455:EE_
X-MS-Office365-Filtering-Correlation-Id: 4226bb9a-5874-401b-df7c-08daac2ced76
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N/6WxC1cnDsWEejPd/XJcukMChf0cU3n0QJoc6caCsLviBcSnNavmXQctHpiN3ODiVelUZ4gYAv61qvlodUnZOIzPdtr+oQ0f0TNhhIWPxu43IDCDF2mmIALI1JO2s/WcoppEkZ9RlJnNpxCnI1CoZ6XR/qOpCI3UKybB4vbRr+9UGZN3GuZ1kFqlVVmAj46Bpa0YFnwukXcIf9x8GI5FkabK/qyEjtRy0WsR5d3baOJlmnP4W9yYJmPJAq3bQ1KdT2NNBJR0lD6l6r7FKiyJ2RXW3kyl9aGYD7Fmh+p5f/bJvyTeBrL5NIHVOeNSaqpZ8+aaAcoQtoXuMucYw8POvsk8fYqRJVdlduauWik4rj6Yp+lA04IzJRw5dUn8SqtSnZA8MgfiVAxTuC0DksYm0xR1Nu3im8LFV47XtlgWHPxA8TWk/t2JLNCwWki6nniM3M1AcvtouffNBt+gOOWvi1kt76HK6qqOiP3ayf48wy1WEG9164ueOM2yhorTDIOF7wkfxQNTFH7ptHiST3yxTNPgzOWPXKOxg+cQsHJRmo+1BYuw8FU+yX+ch0ZnPwF3DJyy0NwoqbKbfVYKCvB5HsqoTvDiCEfCn0bVgy/aj3NuHE/LqOp3zv8Z4Tbmpp2UtNO9jOs0Atxq0aPPQr65pSDRkBBcwv/+7Y9XBzaju3RIXQ5gWj82GnKewbfu2QIiJPe4FvlaffhEFMgKI/nBIHwRoIwkRHPUVpvmvHiUcwYtrVeA5hCR/RBvQbqHqiToaCmeW0m2Xc18uX0F999b7QuUCQHjK5M4jUoLmnjsR4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(396003)(376002)(346002)(451199015)(31686004)(86362001)(31696002)(36756003)(6512007)(38100700002)(66946007)(66556008)(66476007)(8676002)(2906002)(4326008)(8936002)(5660300002)(41300700001)(316002)(53546011)(54906003)(186003)(6506007)(6916009)(2616005)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1BGTnBwVTNkSFdGQ09FYzBaN0dKeDJLcUdHNjNYZHFlQjVEclZkb3ZMSXhY?=
 =?utf-8?B?U2NyNlF0ckhlcUFFYTV3eitSSHdxVU1icGMwR3ZLd3dIa005TWRCczJlaklQ?=
 =?utf-8?B?QmtYamx6NlZjME5mbXhRWFZUdVV4aEEvL0gyM0ZQSFlqK0I2bTRWS0xvUjR0?=
 =?utf-8?B?S2ppMDFXV3BiUXpHMEhPNnR2Z2QwVlF5V0VCU1U0aXp4ei94NEhsM242RVpE?=
 =?utf-8?B?VWtSOGpmaHlzUkh3aXo0dHpQeHlZOWJpeHZYUXZkYVVnZ2xIaXZJY2EvNExq?=
 =?utf-8?B?VTcyaWxUdi9FcmJ6cC94WllDaTNpQ09FMjZISjJJYXlmR3RjUEJtRkZWU1hY?=
 =?utf-8?B?MnlxSUZqRE1uMEl4K2VIYmszR1RJbTVLQmcxeHJkaE96RXIvK0pEMFFFUm8y?=
 =?utf-8?B?YVJZQ0swSk5lSUdRQ1VyZ0E5Sy9UZENaRlROWUZaMUdtckQ0NVlubW40WENm?=
 =?utf-8?B?ZENHakNlNzhvdVJWSytzdnNMQk1SL2ppcks2OHFWelZqVGNFVlgwa2haVE1H?=
 =?utf-8?B?Sy9aNjNDRlpnckxhS1pEck5qQVY4Rk42VDRpN21pcGNndStTUWhEL3NVWksx?=
 =?utf-8?B?UkRNS204S3lvRDFYMHkraWh3SkhlTDYxWE1PbklaWThrZmhnK1F0TnU2bWVi?=
 =?utf-8?B?OFgzZXdLd1NBbTFqTno0YWgzUStzV1d3NFloRUpSS1FkSC9rbmY1aVpBbktZ?=
 =?utf-8?B?MlI0Z214bEVWQmJCMEx3VTY1ZmNtRlZrMk1LWms3U2VxSkNEbGgvbkZJZlMv?=
 =?utf-8?B?ZXdRcVhUclRacTdRbDR3dENTYkJVRklXa2l4aEMzaUNyLzJydUdSQzBWcDl5?=
 =?utf-8?B?ZUpPN2tSemx1WDN0cnQ3SiswU0IwalNIZlo1eWJrdTZWSlRrRDlRanNFdTZX?=
 =?utf-8?B?WllVdUF1ZHhZQXRQSWVxMmFPL1V2d3RFRE52NkdFUVEySlBTSGRjTnhvWmNo?=
 =?utf-8?B?M0l4U0x3Yktkam1nZWN4UXhDWnZRaW1kTk1XTWFBZGlGOFR4b2hrMXFEVmsx?=
 =?utf-8?B?L1BMRzVRTm0zMFJrSks0aVpKZG9raE5pMHhLTWJHOHlxajl5cnhUL3V4ODRo?=
 =?utf-8?B?bDFRV2l5NHBoZGZjZlM0Z3RObVhXL21aOTd2RVhiV0hQM042bk5QNlplVml6?=
 =?utf-8?B?ZXlYc21Nck1PNHVSUnRiT215c09jSFdiS01WU05SeGpNKzBoT3VPYTFMOU96?=
 =?utf-8?B?ZWZuTjB3UFZWaTMxc3RNWHFWYVVUYkR3YXFubUFqUEJCajBaeGZlMW1iSjRC?=
 =?utf-8?B?TUk4WWM0U0N4R2YvaVNKbVBHelBONFMrYkg1YWFEYm9uVGMwdUZlZTVaZ3Zh?=
 =?utf-8?B?cFVaTU5XaDU0SVQxWk5mdzFnek5HTXh5VTVQaWQ1NEx4Sk1leEpCcm9kL3E3?=
 =?utf-8?B?ZmxzRHdRY3hJQmRnQXNoZE5jeTNBRlNwOGk5YlNOR0JHUGVZcWxjaEc4RE5x?=
 =?utf-8?B?QzhSdXpuWldQbEl5bkhHby90eUNqOWtPeHZlU1BHTmphK1BhSFV1ZEdOQjdi?=
 =?utf-8?B?ZXM0by93bjNuRWUrS3d2YmREQllvZUFYYVhsTUx0YmFzYlN3azJ4R2VTM1Fi?=
 =?utf-8?B?S0VtMDRDNzZGdkZNNkg5T3g4TEdNdXlMRVdJUkpCNHZwU3llWDRBb21TWDlr?=
 =?utf-8?B?T0UzRm1rUUpsVlh4bGlHcWNnMWEzenNBM1d3cGprRkFTMmZWcHVlbGdnaWt0?=
 =?utf-8?B?L2JpVDJpNFJhTXpEREZHZDRBRlQyQjFjTFp2K3JweUgvWkdYMm80VWczUUxC?=
 =?utf-8?B?dkxzWDBHanIyVTJTMDFFTDhVZ1dNcm9GQWxIVUpIUkhJVjBMUFpBYnVTUm9V?=
 =?utf-8?B?Ynk4dThseisxVEliV1hmVU16Y1RBbXQzODVtRVBlZjhkZ3lEOExDU2FHcjBV?=
 =?utf-8?B?am9pa2d0SXp3ZFRRSjRRYXZ3bldwaEtVZEVGL1lxOWpOVmFuRE9DUE5ybDZ6?=
 =?utf-8?B?bEM0RUhvRjduOHMyUkkvSHpKMndqdk9zRmUzNVdTVjdlN28zMitTYUNldFBv?=
 =?utf-8?B?NDF0RzU0bnhjb21PbGpHbUxybkwwbWRROFdiUTdmdGlWeXRPUFF1VzFPR1NN?=
 =?utf-8?B?YlMzWTBSQUNmaXZsY1lGa01SZzBtVk9MalR5eXZxaXg2QWxlSllFblZxMGcz?=
 =?utf-8?B?NDEvWmxuTDk0L1BicG1Da0ZHMHpRcGJwc3hSNk9ObTlFdVdvTlo0NXdIUlJS?=
 =?utf-8?Q?4RryM/6C9qMBlbyjjHstSRNU+cJe7jmxgBh7ZXCRxhtw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4226bb9a-5874-401b-df7c-08daac2ced76
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 08:36:58.9969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ego82lcTqDQKQRyrTaNg95txViKC6fAsr1vstQJ3imlAuejhXuVPCjqsQ+aSkA0+QqjdD7Wot8MM434o5p2Giw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9455

On 11.10.2022 18:02, Roger Pau Monne wrote:
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -814,7 +814,9 @@ void amd_set_ssbd(bool enable)
>  		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
>  	else if ( amd_legacy_ssbd )
>  		core_set_legacy_ssbd(enable);
> -	else
> +	else if ( cpu_has_ssb_no ) {

Nit: While already an issue in patch 1, it is actually the combination
of inner blanks and brace placement which made me spot the style issue
here.

> +		/* Nothing to do. */

How is the late placement here in line with ...

> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -558,11 +558,16 @@ static void __init calculate_hvm_max_policy(void)
>          __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
>          __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
>      }
> -    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) )
> +    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ||
> +              boot_cpu_has(X86_FEATURE_SSB_NO) )
>          /*
>           * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed
>           * and implemented using the former. Expose in the max policy only as
>           * the preference is for guests to use SPEC_CTRL.SSBD if available.
> +         *
> +         * Allow VIRT_SSBD in the max policy if SSB_NO is exposed for migration
> +         * compatibility reasons.  If SSB_NO is present setting
> +         * VIRT_SPEC_CTRL.SSBD is a no-op.
>           */
>          __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);

... this comment addition talking about "no-op"?

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 08:48:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 08:48:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420889.665980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiXPd-0005wT-0F; Wed, 12 Oct 2022 08:48:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420889.665980; Wed, 12 Oct 2022 08:48:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiXPc-0005wM-T3; Wed, 12 Oct 2022 08:48:24 +0000
Received: by outflank-mailman (input) for mailman id 420889;
 Wed, 12 Oct 2022 08:48:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiXPc-0005wC-4y; Wed, 12 Oct 2022 08:48:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiXPb-0000qU-WA; Wed, 12 Oct 2022 08:48:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiXPb-0003vL-Mo; Wed, 12 Oct 2022 08:48:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiXPb-0006LF-MM; Wed, 12 Oct 2022 08:48:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CbQdAcTTm+VoqMi/BaJ6TisxsTmtnEZ/wzZ6GrtalmQ=; b=6Vz9ZCJqH5ZrbeVFNMlzVv+rTb
	njtlRu8FzmgaNbnTP/zUMLg5A2S8rndu08WWIo6oBZNCL4hhfIhNNYkSIG9vek0MKtXSIwtrWXftW
	VPSHfVKci+FhZiySX4z3RNLClDWZ9/8IVK3GmJ2KC5FLZ3wNv6upfllHP3X15J1ISz+Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173505-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173505: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=041bc24d867a2a577a06534d6d25e500b24a01ef
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 08:48:23 +0000

flight 173505 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173505/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                041bc24d867a2a577a06534d6d25e500b24a01ef
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    4 days
Failing since        173470  2022-10-08 06:21:34 Z    4 days   13 attempts
Testing same since   173505  2022-10-11 20:43:42 Z    0 days    1 attempts

------------------------------------------------------------
988 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 91185 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 09:37:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 09:37:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420918.666039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYAj-0003sp-8c; Wed, 12 Oct 2022 09:37:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420918.666039; Wed, 12 Oct 2022 09:37:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYAj-0003si-5K; Wed, 12 Oct 2022 09:37:05 +0000
Received: by outflank-mailman (input) for mailman id 420918;
 Wed, 12 Oct 2022 09:37:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYAh-0003sY-Tp; Wed, 12 Oct 2022 09:37:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYAh-0001j9-Ok; Wed, 12 Oct 2022 09:37:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYAh-0007fv-BO; Wed, 12 Oct 2022 09:37:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYAh-0007cl-Ar; Wed, 12 Oct 2022 09:37:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tqbJjuHSCVgRsPpzoH1eXYYTtMfkInnQu9U15y8twA8=; b=p1vf/AYHkCyQ6sn+YlpLrSsL5+
	CytS0siYhAykcKcBySkPkuRGTAt68r2+mh0c3PJDSCHp0ynmsJN8WmZz928tTStXWZF4EG39LLkoq
	IjllNs5hT9D3pR2WvGXmXSqzAB8/tKIxonYVH2b2FkadnUPLAMXqowFbNrgt/bUcSHVU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173517-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173517: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:build-arm64:xen-build:fail:regression
    xen-4.14-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.14-testing:build-armhf:xen-build:fail:regression
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.14-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6e5608d1c50e0f91ed3226489d9591c70fa37c30
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 09:37:03 +0000

flight 173517 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173517/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172550
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172550
 build-armhf                   6 xen-build                fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  6e5608d1c50e0f91ed3226489d9591c70fa37c30
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   57 days
Testing same since   173496  2022-10-11 14:08:01 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 436 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 10:00:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 10:00:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420933.666065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYX3-0007gQ-GI; Wed, 12 Oct 2022 10:00:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420933.666065; Wed, 12 Oct 2022 10:00:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYX3-0007gJ-DR; Wed, 12 Oct 2022 10:00:09 +0000
Received: by outflank-mailman (input) for mailman id 420933;
 Wed, 12 Oct 2022 10:00:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYX1-0007g8-M0; Wed, 12 Oct 2022 10:00:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYX1-0002DN-JN; Wed, 12 Oct 2022 10:00:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYX1-0000Vg-9v; Wed, 12 Oct 2022 10:00:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiYX1-0006kG-9X; Wed, 12 Oct 2022 10:00:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ib/sPsvrmd5QkmP0A++dj60WAABRfQRCjenMXME7Vho=; b=tyuEC37SN1egU7TAzf4rvl8jgm
	5vruBL3gL4rnYWiP15BJrhXHGrcFisFJB5LGxViR/pf+/AJ06C2aaMwqdXnC0o5OnoFrC4AlGbJaf
	/sBapW2W1FXOec4T/yLHTRN3bTVMGTwFr9mLXXMBl03bWzTnsdumqe5AW4GFeBmRuP1Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173538-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173538: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 10:00:07 +0000

flight 173538 xen-unstable-smoke real [real]
flight 173560 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173538/
http://logs.test-lab.xenproject.org/osstest/logs/173560/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    4 days
Testing same since   173492  2022-10-11 13:01:50 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 427 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 10:01:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 10:01:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420941.666076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYYT-0008F8-QR; Wed, 12 Oct 2022 10:01:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420941.666076; Wed, 12 Oct 2022 10:01:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYYT-0008F1-NY; Wed, 12 Oct 2022 10:01:37 +0000
Received: by outflank-mailman (input) for mailman id 420941;
 Wed, 12 Oct 2022 10:01:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiYYS-0008Ev-JW
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 10:01:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiYYR-0002Es-Ki; Wed, 12 Oct 2022 10:01:35 +0000
Received: from [15.248.2.148] (helo=[10.24.69.10])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiYYR-0000sp-EZ; Wed, 12 Oct 2022 10:01:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=w+yWvQkrnh/YS559Rxc8tdkYjKXcooXovV4rsV94Lpw=; b=JrLrF4mXMYYWwBAG52SIabV02F
	PIyU7HtSTft7JfeJkNd3sI19Y0S/htiV3Zr7s/0hu3xplaqeX0pO4+4ySOzb0c1bcsfqCMpCP7whJ
	bRRHER6vdB+D/e8orfIP1HOwIFSeTxWCReP+nhUkOof11imT1fq0JsTP9v5ywQkJrCLI=;
Message-ID: <add54637-1578-225e-7021-6b52e62b221b@xen.org>
Date: Wed, 12 Oct 2022 11:01:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: osstest service owner <osstest-admin@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>
References: <osstest-173492-mainreport@xen.org>
 <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
 <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

(+ Bertrand & Stefano)

Hi Henry,

On 12/10/2022 07:39, Henry Wang wrote:
>> -----Original Message-----
>> Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
>>
>> On 11.10.2022 18:29, osstest service owner wrote:
>>> flight 173492 xen-unstable-smoke real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/173492/
>>>
>>> Regressions :-(
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>   test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
>>
>> Parsing config from /etc/xen/debian.guest.osstest.cfg
>> libxl: debug: libxl_create.c:2079:do_domain_create: ao 0xaaaacaccf680:
>> create: how=(nil) callback=(nil) poller=0xaaaacaccefd0
>> libxl: detail: libxl_create.c:661:libxl__domain_make: passthrough: disabled
>> libxl: debug: libxl_arm.c:148:libxl__arch_domain_prepare_config: Configure
>> the domain
>> libxl: debug: libxl_arm.c:151:libxl__arch_domain_prepare_config:  - Allocate
>> 0 SPIs
>> libxl: error: libxl_create.c:709:libxl__domain_make: domain creation fail: No
>> such file or directory

So this is -ENOENT which could be returned by the P2M is it can't 
allocate a page table (see p2m_set_entry()).

>> libxl: error: libxl_create.c:1294:initiate_domain_create: cannot make domain:
>> -3
>>
>> Later flights don't fail here anymore, though.
>>
>>>   test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457
>>
>> Similar log contents here, but later flights continue to fail the same way.
>>
>> I'm afraid I can't draw conclusions from this; I haven't been able to spot
>> anything helpful in the hypervisor logs. My best guess right now is the use
>> of some uninitialized memory, which just happened to go fine in the later
>> flights for 64-bit.

It looks like the smoke flight failed on laxton0 but passed on 
rochester{0, 1}. The former is using GICv2 whilst the latter are using 
GICv3.

In the case of GICv2, we will create a P2M mapping when the domain is 
created. This is not necessary in the GICv3.

IIRC the P2M pool is only populated later on (we don't add a few pages 
like on x86). So I am guessing this is why we are seen failure.

If that's correct, then this is a complete oversight from me (I haven't 
done any GICv2 testing) while reviewing the series.

The easy way to solve it would be to add a few pages in the pool when 
the domain is created. I don't like it, but I think there other possible 
solutions would require more work as we would need to delay the mappings.

> 
> I am also quite confused about this issue, as from my local test today on
> different Arm/Arm64 boards, this issue would be only triggered on some of
> them instead of all of them...

Did this include any GICv2 HW?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 10:24:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 10:24:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420970.666122 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYub-0002wY-40; Wed, 12 Oct 2022 10:24:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420970.666122; Wed, 12 Oct 2022 10:24:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYub-0002wR-1E; Wed, 12 Oct 2022 10:24:29 +0000
Received: by outflank-mailman (input) for mailman id 420970;
 Wed, 12 Oct 2022 10:24:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiYuZ-0002vk-RO
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 10:24:27 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b975d72-4a18-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 12:24:25 +0200 (CEST)
Received: from AS9PR04CA0083.eurprd04.prod.outlook.com (2603:10a6:20b:48b::29)
 by AS2PR08MB9200.eurprd08.prod.outlook.com (2603:10a6:20b:59f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 10:24:19 +0000
Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:48b:cafe::74) by AS9PR04CA0083.outlook.office365.com
 (2603:10a6:20b:48b::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Wed, 12 Oct 2022 10:24:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 10:24:19 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Wed, 12 Oct 2022 10:24:19 +0000
Received: from fe4604dc9fb0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 44B766A6-985E-49E0-9E5D-061E6261B81E.1; 
 Wed, 12 Oct 2022 10:24:07 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fe4604dc9fb0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 10:24:07 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS1PR08MB7515.eurprd08.prod.outlook.com (2603:10a6:20b:482::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Wed, 12 Oct
 2022 10:24:05 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 10:24:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b975d72-4a18-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=lPgkn4ZpQwdV24IvZfqV1SymBX/UvTEsLIXlByLt/uSjYXoPIBJLqLFR6EHNPCsW5HLhDYLIF9Pho9XHG+tj90gU3NP7W2ztC+2YFjhTsrMQ4JaxYVIedq8ooM15yD5BIPgUyc4mieZNAYPtF7ejDqyLJEIT6FphAXeqKT/c5FA3y0vBveGjJRIn1KrQYz3+1Q9mVOBb69vxgmeLe199lz3mmfR0hQQ+L1rwVpc5uRBpEjbMKKMaPdG/IZa0fNK2okYypz0CbUvEYnp9W8JdW3rjMX7icOImscwVhGXAvrQWfHof9cNNjdGjWQQEmrvW9fA+vhV1ZNYu0sH89KJgDA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A5JorjQlCgjpfFzB9u/rsdXZuHeKperOYILOIF5GPWw=;
 b=V2W+8WLoelplb7zZrjabEIhQdmzveBxRgo2ZWu66ptoHrRr+ZOf+Kvm6Fh7IBhigVfLxnbQ5DNua1hBTMUYoxFI3Z8mnNBuu0+M7S0bmWcGAzB9nD4G8swF/57/j+sg637wI72hRjvgtnxsQtOtyC46djqSS6nsuCa5wfuAlC3vuM5un47bIG1d/cm3g2tzJgRaxk8onMRa+AXXh6zymA94NxqtWEIB6QUqqJgBYOD88MwP/PZwTS47HdtyoTOAVHREfUNCVS3UhDv/3OnbspYcpq1cw+eBAjFlmXitTbSFF4gZsuwaltY5/yqfQImQ0/G5a2jXs3cSIFifeepiaVw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A5JorjQlCgjpfFzB9u/rsdXZuHeKperOYILOIF5GPWw=;
 b=4Dc3lDM/1OleP7QRr2eLTOYLnmORpeSZweTPSKOAVJhwKNKmbAkVfUe0OSg0Caz8sGdVizF2pIPKB2NYkz6bGcj9udvAvz/fUrJn+vzUDaveUSqace5HQxhUizdLv/bayfNP6e0mFj3UuOSApXdOsn327ZsiWItj1BeU+gZd7+M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e8q+3a2c4/4UIsruHk0oIhyNd870q6tf0hCYXL/QH5aDMdBDYObBNsxXdQB+YkTQ5/UWLDVpbf7q7cxkmQF+fj9kaP8US2lJSzpW6jQtRXI3cSqaHZfdZSHkgcKCiGGnuc/x52VwL2/3NBj0DusHJddZLVRt0sWDV24jjabzVpSAZcNUD3+JrTBl3POeX16nEYThrPVMSta0BoZMo4DL5S7qEKnH7jXDVG35Wrn0DHNp4vCVkQq0xt528JBr5z8U722Dsjl7CrXVOdroek/gIeGO6/uofZtwIwXlPdL3Oz+cVC6pcSq3AsOYtKH901cV2afmwO0nSxCFUfVRcySvWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A5JorjQlCgjpfFzB9u/rsdXZuHeKperOYILOIF5GPWw=;
 b=k+11zBpPHdqb9UYtnVmaE/ASU9jXbsUzgl8ZCO9BGHLYi0cX+oTi43aC4RDQXPS57nosrt3xuS8gl8yPGq9fVDNs+p9joQs97f9FAJq8JSv2TFVrU+k9oOPGKDGf/kFsoyaDWhMiqCkZZbZkUYQ0uHjw5P9/ZJlK7DS+eN6z4rcuBFycHRRWUxeg1ENW6MUf4dzpWVlw8GrCLCmMbi1P1S/gED0MLkOkFGamOiH9wf4IebPcRVUNl5ZvBB7XB4bHTudy3YDJZwGn2tSsRpenTbncsF/knzdhq5ITVsGi+31l5Vz9tjMQ56QVHVH41Eo2/wMl7Z0KniXAboBo18g3uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A5JorjQlCgjpfFzB9u/rsdXZuHeKperOYILOIF5GPWw=;
 b=4Dc3lDM/1OleP7QRr2eLTOYLnmORpeSZweTPSKOAVJhwKNKmbAkVfUe0OSg0Caz8sGdVizF2pIPKB2NYkz6bGcj9udvAvz/fUrJn+vzUDaveUSqace5HQxhUizdLv/bayfNP6e0mFj3UuOSApXdOsn327ZsiWItj1BeU+gZd7+M=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Stefano Stabellini <sstabellini@kernel.org>
CC: osstest service owner <osstest-admin@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>
Subject: RE: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Topic: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Index: AQHY3Y68aiBzpV7ZsUyzVLBH9N1mMq4KTrGAgAAAVMCAADkIgIAABRmA
Date: Wed, 12 Oct 2022 10:24:05 +0000
Message-ID:
 <AS8PR08MB7991A13B6DD61F50F59997ED92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <osstest-173492-mainreport@xen.org>
 <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
 <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <add54637-1578-225e-7021-6b52e62b221b@xen.org>
In-Reply-To: <add54637-1578-225e-7021-6b52e62b221b@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F0C8437E9B62FC409C71A234F0C00D9D.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS1PR08MB7515:EE_|AM7EUR03FT022:EE_|AS2PR08MB9200:EE_
X-MS-Office365-Filtering-Correlation-Id: 9d2db943-467d-42cd-81f1-08daac3bec42
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 xe62Y0tvNyvhLCW7Mfe2rrAE5sgLtUlquTckkszLodxQG+obVM5xKXd6QOjoztyCJG3kyUqIBh5CCiJey4E9BlDWh3kbzJhkna2GeS+iNQqJYRngCSE6ZqorD5iYlLLX8ln9POZxAYpix/A25YydxJ/PfiSFX4T17tdc9V07M2qmKM56FowvD3E3wu/8gxFpMDLNlAmeMwEclqHC8k678QJpY6VM5fNp0Vxkm76KYm5gTXd4DcVg5ZTFRIwKDg6DgTiv0WPtsAOrBQa60alNK2QutgX7G6x97cJ2uAYkioZ/SvUeFduGmnINv9zJzHPraRkS0Plsix+21NmVH2NlIDpQxaLEc5ECaX6yzz6e+BFzlGJ2/bnFNDe8Mji+rfmBNGAtB49wwwt1tMyhqDWtQlHKzrpj/QlFSSrMnFR8EMxjh8N4tqwBVfgTco9doNFCNzfsAfSnnYH9Jj/Kzzdi91s5FdNMmm8XtOz6lMC3UYcKxfkyoJD5aZ3AVMod3Bq16yaHcM1yf+XHPGbI6YdY05AAUOgpXJiOPwhasqMcyG1aPH0MeHx2rhsArgn8mJSd5ini7+2VrU7VPNDoZvJvM8CkqKAUMzmJClQJQrWqyOpVTkThDMtWCdBdg1yd5zDEHGn/4mWIf3vHGn6C5qahmX9/A65045DjocbHIACOmybUezvlo46BRxIWwfLDUUUdpezBFs35UN9VvpPpbgK5nsiIcIBypc6vF2ab+5n9QiSE1OMy2u3llO7Ox9Bd4FurkEVYHeYEx5JWPapB70Nn0w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199015)(55016003)(122000001)(478600001)(110136005)(66446008)(41300700001)(5660300002)(64756008)(2906002)(4326008)(71200400001)(66556008)(66476007)(52536014)(9686003)(8936002)(38100700002)(4744005)(316002)(7696005)(38070700005)(26005)(86362001)(186003)(83380400001)(76116006)(8676002)(54906003)(66946007)(6506007)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7515
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	047107ec-199d-4d72-93e1-08daac3be42f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	j6vMQXOQlkeE22JPAcQuL9fwqdT7yCnOjRmJxJbSKTsVK4HGMkohQuaPOKqOxyYQ6C/Lu7nuWNmL+K3kifRmgEynDXTU6SH3rcsYZa8NwuMkiQ6EOkpyrMdJvfA/Y4vROjF1825U2smjgGuRxYxPtwnlnqxiYiZ4e1hw3l6+40hWmrjNWl8/KFinVOuUr6e6jCocXwREcEfTqQEVwCzxHZxfFxgz3sYwI9z1S/P+m+QF0vEFOQTjIXYdLJOQ29RBPch358+qG7/kgaw5nCTqpJRtE9nlcpS+yBhkxn9QCDBScyKLKaYGIt9pJJxzyRsVPunzAc8bFD1spgBYxGysY0nYmx/3lMJPM6Py4Lx/g3fCg3jgTOTPskjjQtOtlmd7Qb5BkkXtDD7QP8Exq+4V7kSJu64yphR/itv0cESwWHDRG77yth8DyQ5JQ6T3/yUIY0I5P6vcVmwhSEJ/ZJVOeqi+QIWsAHO4YH4yLcfsqBHKTfXqZ9Qflnsd91TlmChJ0vkCc/b+Pv9/LzneAc0sfzBXA7GYHVJ9SGt7mmE8fuxm4eUZ5OHsdDQW6q4O/FAalrkiAmzj4t9q6fpLqLszXDWXt2NvELtgupOg4w8BPigSIe5H6vZ7zLtR/LWDgoGHiiEYmfsRi2MtXhJ1tMLVkKpGv9tUiYpkOIkg7MXXWAkdX2Pk2bEIyI4LUs8rsxAPqsx1Rvy9Ddaa2w8Hid3w2FKH/4+3V5Z0KU2YFLKUZmE3oJnevXTpMrSTpDdA06mcpqUV7gqfwMfj2FOwWWMO1g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(110136005)(40460700003)(2906002)(316002)(54906003)(55016003)(40480700001)(186003)(82310400005)(4744005)(41300700001)(81166007)(107886003)(70586007)(52536014)(83380400001)(336012)(8936002)(8676002)(4326008)(5660300002)(33656002)(356005)(82740400003)(47076005)(26005)(6506007)(36860700001)(7696005)(70206006)(86362001)(478600001)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 10:24:19.2551
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d2db943-467d-42cd-81f1-08daac3bec42
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9200

SGkgSnVsaWVuLA0KDQpUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB5b3VyIHJlcGx5Lg0KDQo+IC0t
LS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhl
bi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbeGVuLXVuc3RhYmxlLXNtb2tlIHRlc3RdIDE3MzQ5Mjog
cmVncmVzc2lvbnMgLSBGQUlMDQo+IA0KPiAoKyBCZXJ0cmFuZCAmIFN0ZWZhbm8pDQo+IA0KPiBI
aSBIZW5yeSwNCj4gDQo+ID4gSSBhbSBhbHNvIHF1aXRlIGNvbmZ1c2VkIGFib3V0IHRoaXMgaXNz
dWUsIGFzIGZyb20gbXkgbG9jYWwgdGVzdCB0b2RheSBvbg0KPiA+IGRpZmZlcmVudCBBcm0vQXJt
NjQgYm9hcmRzLCB0aGlzIGlzc3VlIHdvdWxkIGJlIG9ubHkgdHJpZ2dlcmVkIG9uIHNvbWUgb2YN
Cj4gPiB0aGVtIGluc3RlYWQgb2YgYWxsIG9mIHRoZW0uLi4NCj4gDQo+IERpZCB0aGlzIGluY2x1
ZGUgYW55IEdJQ3YyIEhXPw0KDQpPaGggSSBkaWRuJ3QgdGhpbmsgdGhpcyB3YXkuLi5FeGFjdGx5
LCB0aGUgZmFpbGluZyBib2FyZHMgYXJlIHFlbXUtYXJtMzIsIGp1bm8NCmFuZCByYXNwYmVycnkt
cGktNCwgb3RoZXIgYm9hcmRzIHN1Y2ggYXMgRlZQLCBOMVNEUCBhcmUgZmluZS4gSSBhbSBzb3Jy
eSBhcw0KYmFjayB0byB0aGUgZGV2IHBoYXNlIEkgdGhpbmsgRlZQIGlzIHRoZSBvbmx5IGF2YWls
YWJsZSBib2FyZCBmb3IgbWUgc28gdGhpcw0KcGFydCBvZiB0ZXN0aW5nIHdhcyBtaXNzZWQsIGFu
ZCBvdXIgaW50ZXJuYWwgQ0kgYXQgdGhhdCB0aW1lIGFsc28gbWlzc2luZyB0aGVzZQ0KR0lDdjIg
Ym9hcmRzLi4uDQoNCldlIHdpbGwgdHJ5IHRvIG1ha2UgYSBmaXggZnJvbSBvdXIgc2lkZSBhbmQg
cHJvcGVybHkgdGVzdCBpdCB0aGlzIHRpbWUuIFRoYW5rDQp5b3UgdmVyeSBtdWNoIGZvciB5b3Vy
IGlucHV0Lg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeSANCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4g
LS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 10:29:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 10:29:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.420985.666139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYzK-0003os-OK; Wed, 12 Oct 2022 10:29:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 420985.666139; Wed, 12 Oct 2022 10:29:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiYzK-0003ol-LI; Wed, 12 Oct 2022 10:29:22 +0000
Received: by outflank-mailman (input) for mailman id 420985;
 Wed, 12 Oct 2022 10:29:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7nFe=2N=citrix.com=prvs=277557e37=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oiYzJ-0003of-F1
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 10:29:21 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ba712664-4a18-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 12:29:20 +0200 (CEST)
Received: from mail-dm6nam04lp2049.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 12 Oct 2022 06:29:15 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA2PR03MB5882.namprd03.prod.outlook.com (2603:10b6:806:118::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 10:29:13 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5709.022; Wed, 12 Oct 2022
 10:29:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba712664-4a18-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665570559;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=C8OlFt16P2mfb+og7Di4tImeUJXzZ6sDR/tS4WFUA0k=;
  b=FgoLADQsFKhHNBGLsHV4/Kq/VB/zgbA7CBWCpHXPIDuf1D/tXun0hE13
   usuR3y4G5vuuVfnJhEk4T+C/+qcsvj/L9F9aVpfDhZG2Own7jVMwxju4i
   JasKhT5Z0tNgCjd1IScMgcaO4ByvnRqGSbSTF6CUR5Ib1TpPC6rKl8M4N
   s=;
X-IronPort-RemoteIP: 104.47.73.49
X-IronPort-MID: 82176586
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:1ryRF6uz8I2Xw/MiwHpV67WQBOfnVNlfMUV32f8akzHdYApBsoF/q
 tZmKWnQOauLM2HzLYh1aoSxoxkG75DRx9RgS1BqqX00QXgQ+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakR5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklqz
 dU7LWhTYSqDjuS5/5agb+Mr3fgaeZyD0IM34hmMzBn/JNN+HdXvZvuP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTeIilAguFTuGIO9ltiibMNZhEuH4
 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurAttNSuDoqJaGhnWd5kEfOho6TmDqrOjmp3ymBd90c
 2w9r39GQa8asRbDosPGdx+lpH+JuDYMVtwWFPc1gCmtx6zO8kCmD24LZjdbbZots8pebSwn0
 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsRwYf/8Pqpo11ixvVV8tiC4a8lNizEjb1q
 xiRtzQ3jbgXic8N1o248ErBjjbqoYLGJiYy/R7LU3m5qwp1YY+jT5yl70DB6vRNJ5rfSUOO1
 FAGkcWD6OEFDbmWiTeABu4KGdmUC+2tNTTdhRtjGscn/jH1p3q7J9gMsXd5OVtjNdsCdXnxe
 kjPtAhN5ZhVeny3catwZIH3AMMvpUT9KenYujnvRoImSvBMmMWvpkmCuWb4M7jRrXUR
IronPort-HdrOrdr: A9a23:jJVN3ahoUruZPteYm+2Mw4NKDnBQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+
 O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.95,179,1661832000"; 
   d="scan'208";a="82176586"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vzb4hjpP/NplL7Elxqfq25nCAMAXBXmX8Fe69dC+c8GTPutMPWxr0+2mWYdKgZFVDM+WIQOirNr+fe419K1YHnNIcwSCyrBARZbnfTlXq0p+R9NQJNZGh5oCRZuRB6MPgSsaJlX/BvlyXYmUpu3w8sk/WbGcTDw6xjjY68HkWZ/FjD12VsqyVQH+EcXPJl+fXdiltrtAHLq7RIOe2EihUKZ93VTIAH3baWaVF5phr9fZicakl68A/MYR0MNWNlpfMm+Is0uCsBdyUJ9kZ4d1Cc9XgFFKHU7Nh4XGbzD43cDqkJxE/XzydheYA1VZVmqaM5VROJ9K5ERKOXynHAd4eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=C8OlFt16P2mfb+og7Di4tImeUJXzZ6sDR/tS4WFUA0k=;
 b=kZlyDLlGy9IDb++7xK/9EKxKrXkwORYGcIUY/AHsGTw5Z1dW1ihahjet6zafWf/t+Dx4Hr6Sq9FywQZNtY1OFAuvm7Q2HZLO2frBFeZjEj//4Ton2APNAwtAInLbo5Zk1kiqPBW9QFfFbahyUaOupKAmbkf2SFJMnPQey8KvwW7qw90uddhdlu2SStVjv1JtAsA8QUetlkBHzMJKf0YknJz9+HJ+iOjncg7ZNBxKsSnfYWrFC6320nvLjaoZWuEE5verS1SZAl+AmAPctp9SiibgzDrWlB9oryUdzifiK81n9ct/zxGdRx6V9sFpz2vpp/7Xd85uf9/vFOTTU5qM7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=C8OlFt16P2mfb+og7Di4tImeUJXzZ6sDR/tS4WFUA0k=;
 b=fjxIPBb33nbqsDCwcY+YtYnBAQ6hVTfoZ09osAVRSlT+nwjyAXHnRAdp4StPTy+mN+rYE14Rm6CdtHfojnLn368ThbONKKvaPh4tkeLj5navgZ05dqEOuBNEG73Aqj91vCjQWwBHzM7JrsHTK7KR++S7VB2ZU1gcymZsgFCamJw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>
CC: osstest service owner <osstest-admin@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>
Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Topic: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Index: AQHY3Y6y8LcGiSS6R0KH98TlKj582q4KTrGAgAABDACAADhQgIAAB8YA
Date: Wed, 12 Oct 2022 10:29:12 +0000
Message-ID: <09bd969d-b6f0-eedf-0a94-70856cc007e8@citrix.com>
References: <osstest-173492-mainreport@xen.org>
 <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
 <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <add54637-1578-225e-7021-6b52e62b221b@xen.org>
In-Reply-To: <add54637-1578-225e-7021-6b52e62b221b@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA2PR03MB5882:EE_
x-ms-office365-filtering-correlation-id: 6966933d-162b-4232-8078-08daac3c9b21
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 0HIb6fStEoxKetA/rh00ETOzjNiJXVc5GsUM2GfSEWpUMiouNKr7u+9wAkQifmEGh54sVoWpT15h//+LN5eGwJayVM6C+Ek+ZJdvbnqOsVjFRnd+lH1VMCJ1xoD+Ibsw9N+nIOVbDeTpXBOA68/oaJw6W2aLbn65J132UNamCC4XInhTuNsuhQh751OPlegQfuxqHUEsK8l22ND5Rx6PvT4qgtYJq/E+CbqifvM2olkzQWcjw7cpcz4vecIQZNZ+8vBKv3GRs83ak/9Dz4dYVXoORkSDaEm5832BV4cqwLL/IB0RgOvimnJEgQqxcoTGPIK4y+ED4PNc6LQ09iXQ4eAFhpYAtxbFUr/DecDtwuLKF5oJrmblfPo6uguWwtCR7Bi0YkjutwaEmeW9JYdkz6y7/ny0wTw1tjaWCCHD4KlmhGiro8XQc9K6l5LbfS4cR4aL4Ef6rLhjdgM5a9y1OFOpEcKTFuj337UXx0Hg+5c2ZFI6TOsDuEJR4j+FKbqGi5dc2LuHjgmDBxSoIMr3q8+Ej1WLaxlz1wlVpvCm99iiP0xYG7uMrs14psYb+hbxs0lHcV7uAxPxc0mndK0hcZFvyXgiBi6St0xMmqEw8qwCWxSGSZ1Dx19kySA/PbgqhXbpZ0NTQdwKf/N39oZ0Vn3s40jPjpPDO5yIFHnFwEPY7MY2/Jlk2yV3we9V4R5sXXgWzsbUJVQwPXuJCvChWnMYI+wWOZ+Px/fnX+3iyjaDiQgD/h4EEQDpu/guFVkXREzgiewMPa8qBc4x+4njqBWtbgbit3RkGLCujJREsbGNhNTsj2HG5KAIU1Z5R5z1laBd0u/VyYzHvucbXtNU70HuITyVtxJI0KbdF44wUAs=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199015)(5660300002)(31696002)(8936002)(86362001)(2906002)(6506007)(2616005)(186003)(41300700001)(83380400001)(64756008)(66476007)(66556008)(53546011)(4326008)(66446008)(54906003)(110136005)(26005)(66946007)(316002)(8676002)(91956017)(76116006)(38070700005)(122000001)(966005)(6486002)(478600001)(71200400001)(38100700002)(82960400001)(6512007)(66899015)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?R0VkVU0vU3haQ3ptQWwvdjFCSlZETTZ1dWFoTzVldTVWajZvaGFMZmNLNDc0?=
 =?utf-8?B?a1B6ZTg5STYxK2NsdXhyUW9tYld6c1JNMzY1L2Jydno5VElRa2dXUTcyS2Ev?=
 =?utf-8?B?M1FRSjE5NUV3WGdoQ0VxQUl2dDRrZXpBUjlJb04vbDNsQmpqdnYxbzl3eDBO?=
 =?utf-8?B?cDVXSTVFNGt6bk8xWkh1azlYQzVEUVcwNlJsNFVtSnVZNGR0Y3Ixd0twSmRG?=
 =?utf-8?B?SHdhcWJ0S0ptVkgvSnl3YjFHT3hZd0JLL2FoYm5VakpoWGFscUJWbkJuZ0Ro?=
 =?utf-8?B?ZE5HcE9wWXFiS3BJbGEySGUyUUtHbzRzbi8zR0wvSWhYTnhGVzlaekc2RSti?=
 =?utf-8?B?cFdRS2w3cTdJNGNKSDVrSVZRY1B3bEIwMXJKT3dLZ0pIOG5SekkvdjBLVEd1?=
 =?utf-8?B?cVdPTE5acGRCVGUyMnVzWiszczdudnV5Mmo2a2FZRkE5Z2xGb3l3bTFEbDdX?=
 =?utf-8?B?RVJBbHVhVUJMakdmVDNQcEtLUVJsZDlnRHEwSmwzbm9GSkd5VmVsZUsyb3Bl?=
 =?utf-8?B?WElaT3prVkIyWkR6VUVLb1k2bCtXUHNmSFNjbXdvZHhvbmxSU3VCdzJPanpX?=
 =?utf-8?B?Y3VxSHh0TEorSm5HYzh4RkU0a2hVaXpQd2NWaXdLendHZmFKeUtsZjhFZ0Rk?=
 =?utf-8?B?MkFZcFpsNG5aRlZUOHZNNnZPZUd5MUVrZTFleVZ0aTE2ZFFZb1RNdTZGdm5x?=
 =?utf-8?B?UlYyeGxSb2c4KzEvdDVoNjdWQkhoSzREbTZsOUw2RzJlRlJaVXRLRVdCY2dl?=
 =?utf-8?B?TTF5WVJHakU3bWFad2V1OTFsQzVCVDhLa1lFdWw0ZDYvVHFCSFBxdVFsNXRr?=
 =?utf-8?B?UkZUeHowbmk0QjJVSFJLRHQvS1QydVlEU3VVMW5JRG42MVFmTE5sMFRwWGIv?=
 =?utf-8?B?ZUEwdjdOcWpGanJWOWRIdG1VRlY0cWNnQ01jSURGaHE2SUNzV1JoeU1xSG1u?=
 =?utf-8?B?WTRsUENqOE1pK1RjaGtrMmxiMldPaTJKRlhlYnZHYTQ1NHdIQVZDZ2NCdW4v?=
 =?utf-8?B?VHQyNUREeWczL3Azb2Z2RVJhSzJtOC9vMXVrWkVDL1BhSVNLQ1JBaVpYNE1S?=
 =?utf-8?B?MGRlZXhWSVhtTC85c25sb0NGRkxQeEIyWVFnMTgvTmorN0ZwT2FBTk1NbzdN?=
 =?utf-8?B?dFJJRzRqQmhGbGorSFlqajNBM1JpMmdGZ01YU3pIU3QwQThrMkZmMWo1a3hF?=
 =?utf-8?B?akhJRlRtbFRCaEtaQkNhNE5vWmNBS3FvRXVPekFUc3cxL0tjOUpCenhMMEdH?=
 =?utf-8?B?VkxxMDZ0dmhnck5zRzlFOFhML1R0V2hPRFZldi9sbFNLaUlWMHFWQkVxb0JB?=
 =?utf-8?B?OG9nWVpScnN4aWNaWmdBR0JhcDRKcHBnc2p5ZGZMZ0UzWmlkR21aOEs3RFR5?=
 =?utf-8?B?QU1LZmtwSmdQbWh1eDN2SHEveForLzFoWERIU0FhZUlUWlJGNzBhZENnV0pE?=
 =?utf-8?B?QTRsenkyNDhtdFU5SGYycUlwd1FwQ3NYU3llWHI0eFpuQU0vNkV5QnV3SVpm?=
 =?utf-8?B?N1NnRzREc3JXcUMrbG4wRVZvdEI0R0lRQnFDcWczdU5CMkFoRWxsN2cyN0Jn?=
 =?utf-8?B?QzR0WmkwbjNZWTQzN1ZBYTNTcW5zcTdNN1ZIOWZTMzlRNWxxNHlNZTNHYzFY?=
 =?utf-8?B?RzBaK2FJR20yOGdKbHBzNVZDRGlRSGt3NmxMeFhBM2M4Q3plM0orNitENnVp?=
 =?utf-8?B?SHp2eEdJSy9zREc5VjAzOUs3c0M2U1Vnem5IRzVpS1Budk56MitIeUdEL21q?=
 =?utf-8?B?RzNVRkMzQkxuUytNRjBOR3pQdlBQRDZsTmxwaWRKUHlwSTE3MWJQRUMrbXN2?=
 =?utf-8?B?VEdZdnJBN3pkUW03QUVJb2haUWl4c3lNWVY0SmxQVHRKRExubHF2VkN5MHN2?=
 =?utf-8?B?UlR5VlYxdnNwTjB0Tkgrbk5MQksxRHBzVU9JV2pLSXljakMybXRpNDJLSFMr?=
 =?utf-8?B?RXpEK0RtSnVsdU5lNzdobklTWllKeTZTdHRuNWhpR1FvUXAxWE9Eamh2V2lT?=
 =?utf-8?B?aElyNXVWd3pVcTNMeDB5R3JUTEdNNTk1bUZBcklabWVkL3NCOWRmU1Njemhw?=
 =?utf-8?B?REc0ZGdEV0pITERwVjAwQ0g1U3EyWk9rWkdDYnV1VkRoRFU0ZmpJS0twZ0Fw?=
 =?utf-8?Q?iFinTl7g7DZfoK8cTtQXM/W5h?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4BC10ABFB7B43744BAFDFC916F57765D@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6966933d-162b-4232-8078-08daac3c9b21
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 10:29:12.6713
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1rcAFecwFa3rHIINtkX2IFKGTTjTgnzowGdOrnqQJz8A3bRfp34LF3UJcWSCsSzM5FNLPfC3KbNqDW/0biLAf8p1hmhPLtAlqC6gmAD6VaA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5882

T24gMTIvMTAvMjAyMiAxMTowMSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiAoKyBCZXJ0cmFuZCAm
IFN0ZWZhbm8pDQo+DQo+IEhpIEhlbnJ5LA0KPg0KPiBPbiAxMi8xMC8yMDIyIDA3OjM5LCBIZW5y
eSBXYW5nIHdyb3RlOg0KPj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+Pj4gU3ViamVj
dDogUmU6IFt4ZW4tdW5zdGFibGUtc21va2UgdGVzdF0gMTczNDkyOiByZWdyZXNzaW9ucyAtIEZB
SUwNCj4+Pg0KPj4+IE9uIDExLjEwLjIwMjIgMTg6MjksIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3
cm90ZToNCj4+Pj4gZmxpZ2h0IDE3MzQ5MiB4ZW4tdW5zdGFibGUtc21va2UgcmVhbCBbcmVhbF0N
Cj4+Pj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3
MzQ5Mi8NCj4+Pj4NCj4+Pj4gUmVncmVzc2lvbnMgOi0oDQo+Pj4+DQo+Pj4+IFRlc3RzIHdoaWNo
IGRpZCBub3Qgc3VjY2VlZCBhbmQgYXJlIGJsb2NraW5nLA0KPj4+PiBpbmNsdWRpbmcgdGVzdHMg
d2hpY2ggY291bGQgbm90IGJlIHJ1bjoNCj4+Pj4gwqAgdGVzdC1hcm02NC1hcm02NC14bC14c23C
oMKgwqDCoMKgIDE0IGd1ZXN0LXN0YXJ0wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZmFpbA0K
Pj4+PiBSRUdSLiB2cy4gMTczNDU3DQo+Pj4NCj4+PiBQYXJzaW5nIGNvbmZpZyBmcm9tIC9ldGMv
eGVuL2RlYmlhbi5ndWVzdC5vc3N0ZXN0LmNmZw0KPj4+IGxpYnhsOiBkZWJ1ZzogbGlieGxfY3Jl
YXRlLmM6MjA3OTpkb19kb21haW5fY3JlYXRlOiBhbyAweGFhYWFjYWNjZjY4MDoNCj4+PiBjcmVh
dGU6IGhvdz0obmlsKSBjYWxsYmFjaz0obmlsKSBwb2xsZXI9MHhhYWFhY2FjY2VmZDANCj4+PiBs
aWJ4bDogZGV0YWlsOiBsaWJ4bF9jcmVhdGUuYzo2NjE6bGlieGxfX2RvbWFpbl9tYWtlOiBwYXNz
dGhyb3VnaDoNCj4+PiBkaXNhYmxlZA0KPj4+IGxpYnhsOiBkZWJ1ZzogbGlieGxfYXJtLmM6MTQ4
OmxpYnhsX19hcmNoX2RvbWFpbl9wcmVwYXJlX2NvbmZpZzoNCj4+PiBDb25maWd1cmUNCj4+PiB0
aGUgZG9tYWluDQo+Pj4gbGlieGw6IGRlYnVnOiBsaWJ4bF9hcm0uYzoxNTE6bGlieGxfX2FyY2hf
ZG9tYWluX3ByZXBhcmVfY29uZmlnOsKgIC0NCj4+PiBBbGxvY2F0ZQ0KPj4+IDAgU1BJcw0KPj4+
IGxpYnhsOiBlcnJvcjogbGlieGxfY3JlYXRlLmM6NzA5OmxpYnhsX19kb21haW5fbWFrZTogZG9t
YWluIGNyZWF0aW9uDQo+Pj4gZmFpbDogTm8NCj4+PiBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5DQo+
DQo+IFNvIHRoaXMgaXMgLUVOT0VOVCB3aGljaCBjb3VsZCBiZSByZXR1cm5lZCBieSB0aGUgUDJN
IGlzIGl0IGNhbid0DQo+IGFsbG9jYXRlIGEgcGFnZSB0YWJsZSAoc2VlIHAybV9zZXRfZW50cnko
KSkuDQo+DQo+Pj4gbGlieGw6IGVycm9yOiBsaWJ4bF9jcmVhdGUuYzoxMjk0OmluaXRpYXRlX2Rv
bWFpbl9jcmVhdGU6IGNhbm5vdA0KPj4+IG1ha2UgZG9tYWluOg0KPj4+IC0zDQo+Pj4NCj4+PiBM
YXRlciBmbGlnaHRzIGRvbid0IGZhaWwgaGVyZSBhbnltb3JlLCB0aG91Z2guDQo+Pj4NCj4+Pj4g
wqAgdGVzdC1hcm1oZi1hcm1oZi14bMKgwqDCoMKgwqDCoMKgwqDCoCAxNCBndWVzdC1zdGFydMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZhaWwNCj4+Pj4gUkVHUi4gdnMuIDE3MzQ1Nw0KPj4+
DQo+Pj4gU2ltaWxhciBsb2cgY29udGVudHMgaGVyZSwgYnV0IGxhdGVyIGZsaWdodHMgY29udGlu
dWUgdG8gZmFpbCB0aGUNCj4+PiBzYW1lIHdheS4NCj4+Pg0KPj4+IEknbSBhZnJhaWQgSSBjYW4n
dCBkcmF3IGNvbmNsdXNpb25zIGZyb20gdGhpczsgSSBoYXZlbid0IGJlZW4gYWJsZQ0KPj4+IHRv
IHNwb3QNCj4+PiBhbnl0aGluZyBoZWxwZnVsIGluIHRoZSBoeXBlcnZpc29yIGxvZ3MuIE15IGJl
c3QgZ3Vlc3MgcmlnaHQgbm93IGlzDQo+Pj4gdGhlIHVzZQ0KPj4+IG9mIHNvbWUgdW5pbml0aWFs
aXplZCBtZW1vcnksIHdoaWNoIGp1c3QgaGFwcGVuZWQgdG8gZ28gZmluZSBpbiB0aGUNCj4+PiBs
YXRlcg0KPj4+IGZsaWdodHMgZm9yIDY0LWJpdC4NCj4NCj4gSXQgbG9va3MgbGlrZSB0aGUgc21v
a2UgZmxpZ2h0IGZhaWxlZCBvbiBsYXh0b24wIGJ1dCBwYXNzZWQgb24NCj4gcm9jaGVzdGVyezAs
IDF9LiBUaGUgZm9ybWVyIGlzIHVzaW5nIEdJQ3YyIHdoaWxzdCB0aGUgbGF0dGVyIGFyZSB1c2lu
Zw0KPiBHSUN2My4NCj4NCj4gSW4gdGhlIGNhc2Ugb2YgR0lDdjIsIHdlIHdpbGwgY3JlYXRlIGEg
UDJNIG1hcHBpbmcgd2hlbiB0aGUgZG9tYWluIGlzDQo+IGNyZWF0ZWQuIFRoaXMgaXMgbm90IG5l
Y2Vzc2FyeSBpbiB0aGUgR0lDdjMuDQo+DQo+IElJUkMgdGhlIFAyTSBwb29sIGlzIG9ubHkgcG9w
dWxhdGVkIGxhdGVyIG9uICh3ZSBkb24ndCBhZGQgYSBmZXcgcGFnZXMNCj4gbGlrZSBvbiB4ODYp
LiBTbyBJIGFtIGd1ZXNzaW5nIHRoaXMgaXMgd2h5IHdlIGFyZSBzZWVuIGZhaWx1cmUuDQo+DQo+
IElmIHRoYXQncyBjb3JyZWN0LCB0aGVuIHRoaXMgaXMgYSBjb21wbGV0ZSBvdmVyc2lnaHQgZnJv
bSBtZSAoSQ0KPiBoYXZlbid0IGRvbmUgYW55IEdJQ3YyIHRlc3RpbmcpIHdoaWxlIHJldmlld2lu
ZyB0aGUgc2VyaWVzLg0KPg0KPiBUaGUgZWFzeSB3YXkgdG8gc29sdmUgaXQgd291bGQgYmUgdG8g
YWRkIGEgZmV3IHBhZ2VzIGluIHRoZSBwb29sIHdoZW4NCj4gdGhlIGRvbWFpbiBpcyBjcmVhdGVk
LiBJIGRvbid0IGxpa2UgaXQsIGJ1dCBJIHRoaW5rIHRoZXJlIG90aGVyDQo+IHBvc3NpYmxlIHNv
bHV0aW9ucyB3b3VsZCByZXF1aXJlIG1vcmUgd29yayBhcyB3ZSB3b3VsZCBuZWVkIHRvIGRlbGF5
DQo+IHRoZSBtYXBwaW5ncy4NCg0KSG9uZXN0bHksIEkndmUgY29uc2lkZXJlZCBkb2luZyB0aGlz
IG9uIHg4NiB0b28uDQoNClRoZXJlIGFyZSBzZXZlcmFsIHRoaW5ncyB3aGljaCB3YW50IGFsbG9j
YXRpbmcgaW4gZG9tYWluX2NyZWF0ZSgpLCBidXQNCmFyZSBkZWZlcnJlZCB0byBtYXhfdmNwdXMo
KSBiZWNhdXNlIHRoZXkgcmVxdWlyZSB0aGUgUDJNIGhhdmluZyBhDQpub24temVybyBhbGxvY2F0
aW9uLsKgIFRoaXMgaW4gdHVybiBtZWFucyB3ZSd2ZSBnb3QgYSBsb2FkIG9mIGNoZWNrcyBpbg0K
cGF0aHMgd2hlcmUgd2UnZCBpZGVhbGx5IG5vdCBoYXZlIHRoZW0uDQoNCldlIGFscmVhZHkgaGF2
ZSBhIGNhbGN1bGF0aW9uIG9mIHRoZSBhYnNvbHV0ZWx5IG1pbmltdW0gd2Ugd2lsbCBldmVyDQpw
ZXJtaXQgdGhlIHAybSBwb29sIHRvIGJlLsKgIElNTyB3ZSBvdWdodCB0byBhbGxvY2F0ZSB0aGlz
IG1pbmltdW0gc2l6ZQ0KaW4gZG9tYWluX2NyZWF0ZSgpLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 10:50:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 10:50:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421001.666156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiZJB-0006m8-Lb; Wed, 12 Oct 2022 10:49:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421001.666156; Wed, 12 Oct 2022 10:49:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiZJB-0006m1-If; Wed, 12 Oct 2022 10:49:53 +0000
Received: by outflank-mailman (input) for mailman id 421001;
 Wed, 12 Oct 2022 10:49:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiZJB-0006lv-8a
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 10:49:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiZJ9-00038U-BO; Wed, 12 Oct 2022 10:49:51 +0000
Received: from [15.248.2.148] (helo=[10.24.69.10])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiZJ9-0002qx-5C; Wed, 12 Oct 2022 10:49:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=3MfTNnSjWR3ocVSJbg4TZTpjgmify4S/m7d0xAw11cc=; b=dDxQ1frUjEO9OwyxMb3pnpTLKU
	39lAryroWDmAUj5XT4pn8WkextH5vasfFEeGrBGEa3YUlNXbHBy/2XiZge3q0wDiNW8gECRUTFcKZ
	Ld9cQvWdAMvF82Q1Gams80jyx47Y8QeSpUqvb4ANBLw649lVZyoCx8m9M2v/HFb8cvUU=;
Message-ID: <1f884b50-afb7-0210-21f8-f7fe22105feb@xen.org>
Date: Wed, 12 Oct 2022 11:49:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
 <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: osstest service owner <osstest-admin@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>
References: <osstest-173492-mainreport@xen.org>
 <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
 <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <add54637-1578-225e-7021-6b52e62b221b@xen.org>
 <09bd969d-b6f0-eedf-0a94-70856cc007e8@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <09bd969d-b6f0-eedf-0a94-70856cc007e8@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 12/10/2022 11:29, Andrew Cooper wrote:
> On 12/10/2022 11:01, Julien Grall wrote:
>> (+ Bertrand & Stefano)
>>
>> Hi Henry,
>>
>> On 12/10/2022 07:39, Henry Wang wrote:
>>>> -----Original Message-----
>>>> Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
>>>>
>>>> On 11.10.2022 18:29, osstest service owner wrote:
>>>>> flight 173492 xen-unstable-smoke real [real]
>>>>> http://logs.test-lab.xenproject.org/osstest/logs/173492/
>>>>>
>>>>> Regressions :-(
>>>>>
>>>>> Tests which did not succeed and are blocking,
>>>>> including tests which could not be run:
>>>>>    test-arm64-arm64-xl-xsm      14 guest-start              fail
>>>>> REGR. vs. 173457
>>>>
>>>> Parsing config from /etc/xen/debian.guest.osstest.cfg
>>>> libxl: debug: libxl_create.c:2079:do_domain_create: ao 0xaaaacaccf680:
>>>> create: how=(nil) callback=(nil) poller=0xaaaacaccefd0
>>>> libxl: detail: libxl_create.c:661:libxl__domain_make: passthrough:
>>>> disabled
>>>> libxl: debug: libxl_arm.c:148:libxl__arch_domain_prepare_config:
>>>> Configure
>>>> the domain
>>>> libxl: debug: libxl_arm.c:151:libxl__arch_domain_prepare_config:  -
>>>> Allocate
>>>> 0 SPIs
>>>> libxl: error: libxl_create.c:709:libxl__domain_make: domain creation
>>>> fail: No
>>>> such file or directory
>>
>> So this is -ENOENT which could be returned by the P2M is it can't
>> allocate a page table (see p2m_set_entry()).
>>
>>>> libxl: error: libxl_create.c:1294:initiate_domain_create: cannot
>>>> make domain:
>>>> -3
>>>>
>>>> Later flights don't fail here anymore, though.
>>>>
>>>>>    test-armhf-armhf-xl          14 guest-start              fail
>>>>> REGR. vs. 173457
>>>>
>>>> Similar log contents here, but later flights continue to fail the
>>>> same way.
>>>>
>>>> I'm afraid I can't draw conclusions from this; I haven't been able
>>>> to spot
>>>> anything helpful in the hypervisor logs. My best guess right now is
>>>> the use
>>>> of some uninitialized memory, which just happened to go fine in the
>>>> later
>>>> flights for 64-bit.
>>
>> It looks like the smoke flight failed on laxton0 but passed on
>> rochester{0, 1}. The former is using GICv2 whilst the latter are using
>> GICv3.
>>
>> In the case of GICv2, we will create a P2M mapping when the domain is
>> created. This is not necessary in the GICv3.
>>
>> IIRC the P2M pool is only populated later on (we don't add a few pages
>> like on x86). So I am guessing this is why we are seen failure.
>>
>> If that's correct, then this is a complete oversight from me (I
>> haven't done any GICv2 testing) while reviewing the series.
>>
>> The easy way to solve it would be to add a few pages in the pool when
>> the domain is created. I don't like it, but I think there other
>> possible solutions would require more work as we would need to delay
>> the mappings.
> 
> Honestly, I've considered doing this on x86 too.

AFAICT, this is already the case for HAP (see call to 
hap_set_allocation() in hap_enable()). 256 pages will be pre-allocated.

> 
> There are several things which want allocating in domain_create(), but
> are deferred to max_vcpus() because they require the P2M having a
> non-zero allocation.  This in turn means we've got a load of checks in
> paths where we'd ideally not have them.
> 
> We already have a calculation of the absolutely minimum we will ever
> permit the p2m pool to be.  IMO we ought to allocate this minimum size
> in domain_create().

It depends on the number. At the moment domain_create() is not 
preemptible, so we don't want to allocate too many pages (I think even 
256 pages could be risky on some Arm platform).

Maybe the solution is to have domain_create() preemptible. But it is not 
something that could be done in the 4.17 time frame.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 11:05:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 11:05:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421009.666170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiZYI-00018S-1v; Wed, 12 Oct 2022 11:05:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421009.666170; Wed, 12 Oct 2022 11:05:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiZYH-00018L-VG; Wed, 12 Oct 2022 11:05:29 +0000
Received: by outflank-mailman (input) for mailman id 421009;
 Wed, 12 Oct 2022 11:05:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7nFe=2N=citrix.com=prvs=277557e37=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oiZYG-00018F-G9
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 11:05:28 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c5520df9-4a1d-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 13:05:26 +0200 (CEST)
Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 12 Oct 2022 07:05:21 -0400
Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27)
 by SJ0PR03MB5885.namprd03.prod.outlook.com (2603:10b6:a03:2dd::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 11:05:17 +0000
Received: from BN7PR03MB3618.namprd03.prod.outlook.com
 ([fe80::e026:95ff:3651:8e37]) by BN7PR03MB3618.namprd03.prod.outlook.com
 ([fe80::e026:95ff:3651:8e37%6]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022
 11:05:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5520df9-4a1d-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665572726;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=dZP7EKvOAwV6BeKqNmKjiGGeUYq+Wxw1VjmIE9d4GLw=;
  b=C/vIwJKEQxbupvpTDf/zmAJ9PSFWuZVixjpeKsAoRPfdUjWjdoMP1doj
   1yCmF87PhJGlBXhU3N7jVPuIpYK14TTYrUvUARSfuVFQ7si50Uwg9uIHO
   iW0e21U/PVvQx0txE8kwC6zzeWE+ZVwZe4zmW5qzndH5hC9MFm/mhfKxI
   w=;
X-IronPort-RemoteIP: 104.47.70.103
X-IronPort-MID: 82178614
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:qpNvZ6PKjHUHIoXvrR0slsFynXyQoLVcMsEvi/4bfWQNrUp01jEEy
 jQZWTuDaP+OYzamKYxxaoqy8ktX7J7XmtdjHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr4mtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eE6Eh8PlvG1B30
 98Hawo1XgKAttm1z+fuIgVsrpxLwMjDGqo64ykl5xeGSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsH8BTM/fFfD2v7lWSd1JDENtbPd8PMbsJShkuC/
 UrN/njjAwFcP9uaodaA2iL237Cfw3qnMG4UPJLm2ed1kVG0/Vc0GEc2cFqXqMi2pmfrDrqzL
 GRRoELCt5Ma9lGvT9T7dw21pjiDpBF0c/pdFfcrrj6EzKX86hycQGMDS1ZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9UQAfIHUefyYCQU0A6sP6vYAophvVS5BoF6vdpsbuBTj6z
 jSOrS4/r7Yel8gG0+O851+vqzW3vYTEVRJw7wnSX2SN/g5/fJSiZYGj9R7c9/koBISTQ0SFv
 XMEs9OD9+1IBpaI/BFhW80IFbCtovyDbzvVhAc3G4F7rmz2vXm+YYpX/TdyYl9zNdoJciPoZ
 0mVvh5N4JhUPz2haqofj5+NNvnGBJPITbzNPs04pPIXOvCdqCfvEPlSWHOt
IronPort-HdrOrdr: A9a23:z/5/y64YiILSTgrN3QPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.95,179,1661832000"; 
   d="scan'208";a="82178614"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bL1qpgq8oXsn5clm5lyBcKxff4GRr2JY2xXpz9Np/F7bVNUrSqUTEK+OG/t3/BWP1VzlCqBHykWcRgjhKc67V4uk2gxy1SwD0EWdB0m+tpD9wtFPFHpkmvBAYo+fVEeWq/F9qnQmnQZOCUryqOOOuWuKqp7xzXCTJ4c0Wj1KMcJjU8TTscjG5fXKgcIhTCBCm066OE79dpYHzwFQ4RoQjhBb13vm7E4ttYK6Dm0fDVyNJ8JP2VRKQxqnEOSIWNDBgoJmn86geqjMRViSgLQAy2/+TlvLT9TTCErjJGmqnpdIZxhDbKhzopyZJj7kdPpSNmOwYTdpR19+jaCqqdUPtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dZP7EKvOAwV6BeKqNmKjiGGeUYq+Wxw1VjmIE9d4GLw=;
 b=gv9FgiDu75CdgLX12vTjOIFWyPvSuYOtZM3Douw3IKgO9os9XJTGSkybqhdCxcz6ZDjyFLTozAqHrTwc1HZbynlregejGUx9S1wX3xI3NQkqd9vnOLftPJqj2gQ0Bk+VoIH6lgOr1z0L+t2pr4U8ilnCmY5Ch+0mAinWOzx++tAHAzBFHXdSiIakSF+AfczuYSjuRGyZ0W3A0+RCtHoql1JdQdwlehxJ/ViVmRjIxdih4QHEQBZp5Q8Ec0dZLwzQrLE05SBsAsTCHqkIdeiruC/YcfVw/EEcc2QNYKFYEY2lItBjzzRhRyMCDok7pfjegO1dWlz2G1P4YAOvX/SIWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dZP7EKvOAwV6BeKqNmKjiGGeUYq+Wxw1VjmIE9d4GLw=;
 b=qX+BTjZlslJJd0NOXfpnVqheU1VL248ic+DuP9594fpkxdMhBMc8CwrGaR/eKfJsEQDt72FzAwYW36IQ4ec83ST3oganPQO5T8ac5u4h05TdEC3EGlpLgQ3xLZUspUjm8L6aWCV9pgxRfsZnl07TVMVp0KpP5WOu5vMpE1zXZ9Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>
CC: osstest service owner <osstest-admin@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>
Subject: Re: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Topic: [xen-unstable-smoke test] 173492: regressions - FAIL
Thread-Index:
 AQHY3Y6y8LcGiSS6R0KH98TlKj582q4KTrGAgAABDACAADhQgIAAB8YAgAAFwQCAAARSAA==
Date: Wed, 12 Oct 2022 11:05:17 +0000
Message-ID: <c29fc52e-a738-5100-30e1-3bdfe50187e6@citrix.com>
References: <osstest-173492-mainreport@xen.org>
 <9a004932-ccaa-5e78-c0fa-6fe3f2c13b78@suse.com>
 <AS8PR08MB79917FBE55B5344A8A1F915D92229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <add54637-1578-225e-7021-6b52e62b221b@xen.org>
 <09bd969d-b6f0-eedf-0a94-70856cc007e8@citrix.com>
 <1f884b50-afb7-0210-21f8-f7fe22105feb@xen.org>
In-Reply-To: <1f884b50-afb7-0210-21f8-f7fe22105feb@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BN7PR03MB3618:EE_|SJ0PR03MB5885:EE_
x-ms-office365-filtering-correlation-id: 15cdf407-e73c-4c6a-3663-08daac41a56e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4i7vFiqEQdBuKxnj6HqyAW6NAxnkLBtQEauHPErT2scsTWXMENgHl9buv7dz5Is/FgRwyjYHrfh3tGN7qDr5qlN1+eYBYjcdLSyD72md4v+pnc1y6ePgU/Q5BjRXDoUBzIPhl8uyIS+4myXhz9BvFudsUYqN6+iCxob1RAtBiSFy18K0TQNIU45w6upk1HTuo4TO5qIh4I/L/zon9SQxc9DL5pMTERfm/tmphFWjpX7sj5pHP2Uic9g6cvrTUurzsb83YDoMT+E2Yxkid8GgKyrSco7JSPEbd2cRXM8/0WrsSBNTGPj/wkWpXWSQwXRQz3DHp3oa/TiUchC+4o4gsWN38SLu/6pVYBslPS/8gjAW9nEeIYyJzcWMSrCM+AMqAOCTSKFuZP6LLR4jwFL+mjPrWVhZjFULg9o7ZCUEhCf4iGPjpITn6A68UodZdLKFsBRzV6w8LtoUHHlp3idVDmv4QHUvP50HYZv8KTAHRxMQSaeMYp8wA1KyjdinEgVX17vbG4FtbxGVUVcb4LdRz3R8pOSYc1OgLK8eK6hQv9lYsy/QhRFRsBA/8mW/vnp3Y76xBmWjeg/KTrgvRwTHPDk0vtQE5L+8Pot97Lvzw3/mUiXCB82B7LSpZelvQ4a42Hne36mMOsd0t1goR4V5mD7YqUOXv++q3IrhNeZECTp4bzpdGvLk9Ido6rYJqXoy2qJ92XR0jcvpwdoqazxA9F/6+y7ivX9gGutnGWpe0b+GVLSe5gROO2frP8eSctxETE8KUCWGBS3Q+PynE9znQBWiKsonjjvZ4jyLZ2Po63XCGv2UlClPRMdRSChu/Ok3OlRuty1t7ba5dC96Y7wwg/rFZCgCwNKUFoa4Uuf8lrl2wpc4liaBO1yeyV8tyX4K
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199015)(38070700005)(31686004)(966005)(66899015)(71200400001)(6486002)(82960400001)(54906003)(110136005)(38100700002)(478600001)(316002)(186003)(66476007)(66446008)(91956017)(66946007)(66556008)(64756008)(76116006)(8676002)(122000001)(4326008)(53546011)(5660300002)(26005)(83380400001)(31696002)(41300700001)(6506007)(36756003)(8936002)(2616005)(2906002)(86362001)(6512007)(60764002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Um92aFE1Y3c3WUZUY1FvUmtheEJhcFh1MzhtUUt4ZWs1bElIQVZuQ2N1bW1s?=
 =?utf-8?B?d0RkRG1GQVoxbXdCU0lUQ0doOHhRVWh6ZG9NT1ZDejg4Q05sUXI3andDT0s2?=
 =?utf-8?B?QWE1ckJiUEdMaGczdFJ2SEd2LyswcEgyWnpWcnlPSklhVmYxaU5lRSsvVWJh?=
 =?utf-8?B?YWFEcWg0UUVzRjZDZGZpa2dkQUVVcXRSQXd0MGNKOS9aSUNrV3ZLaVowT0ll?=
 =?utf-8?B?NXZoc3JUaHEvRXRWYTlkUlp0SUhQSHZmb3B3cStjTXJlM0JONVY5NC9CaXBu?=
 =?utf-8?B?dU44Y2VXRzRWWTFjVWNKNmVIbWR2TUFqOEtnMVlhaHNZUkQxK05rcEx2UUs5?=
 =?utf-8?B?eXdqdkxUOVdBM3BLNjFKdjZwYUd6dzBaaWxjZUN6d083YXZGUGw5aldoc3RL?=
 =?utf-8?B?RXo4d0dGbW9yajRrT1AwR1NjQkJEQUdMWnZnOTdUWmdabEdRUFREcUVraUhr?=
 =?utf-8?B?N0U4UTVRMWlJd3phZnBQeENTUThVVDZyeDhCVzltNFhoUC9Ha2gyK2JPZXlC?=
 =?utf-8?B?N3VQN3lndVNaZURNVjNPOWxWWlVTMFE2UVl3SUZIVFVGRTRCZjBtU0hvcXZH?=
 =?utf-8?B?b2ZuZm9TcGxjdDV0VUw1Qjk4M3dtSmJEQVZ0R2ticHZ2dzZsbWVBSjVkSmhY?=
 =?utf-8?B?UUNOZncyajBLcHZIdk5GQldqSzVINldFR0E0ODhSdkVucktZbk92dktJZVpl?=
 =?utf-8?B?SnkrWWN0c1VteU1STERWUC9SbjlzUjNOVVlLdmMwYUZYODF2aUtMNEN4RzFu?=
 =?utf-8?B?RjNCYzViQWlsdGQ2SS8reXVEcGU2TG9uYUhTR3liMXZXNTBMeXJ1eVpwRi9n?=
 =?utf-8?B?bElCeVBZclZNazZjY3gwankwOWZnd01LVGtnak1rVldBdkJxQjVkU2ZmVE5v?=
 =?utf-8?B?WkpPZGo3SlFicEN4MUgxcWdaeTlBeWVaQlNkZU9NY1FCMWJmSTY2U25SaU8y?=
 =?utf-8?B?anFLSmhJM3lyN0ZwaGlSUWFaVjA1TnVBMm15dW1LMTNsZ1FGN012Q0hhZTJX?=
 =?utf-8?B?V0Z2bTRWYy9ZVXZKTjEvTTFBTmxPNlA1bytNc1Y1N3RMOUNwWjEwWDdhMFI0?=
 =?utf-8?B?N0pqWHI0VTZEN2Y0Zmlqa3BmSks5aUYvTk00TmVCdTl1aUtSRCs4OHNDTXpO?=
 =?utf-8?B?UDlVMXVXbmVGRzV2aEQzaytIbmdocXZhU1RPQjllVWx1Si9UMGJRWEoycEMr?=
 =?utf-8?B?T0w2d2xyWTc4eWNhNjI0aWI2U2ovcmNrZmJMekUrN3RoM2JoSmZvRU9zUW1R?=
 =?utf-8?B?eDhIY0wxbGxUNDg0R1BrSHd2dnh1cmpPOEtXMXhXaDllU2FOK3FJSTJFMUhZ?=
 =?utf-8?B?RHVXakw4dERpeDlma3dDSjlYT2trWTRqVWFrNklKR1BiWW5HNWxrZjdVZVVn?=
 =?utf-8?B?NlNvU3VCR1BZdFlMdnhjOFR5a25qU2d1cXZjRjNIUmZFZU9UZGRBUjRLVWxa?=
 =?utf-8?B?TEE4YnJIQlR1QWZBQmJBTVBtQ3N4SWxBT29pWnpocEM5Vzgvd2VXL1RHa2Fi?=
 =?utf-8?B?V2U5c0lQcmRSanVScjNTbjJjT2tZT3g3Z1h3WGlZZDQ5bEJzc1hLbDd1NU1J?=
 =?utf-8?B?WDZEQlYzbCtIalNUc0R2RkErRHZTWFdNbmNST0J6Y3JsUEpyZ0tVbGo1NkYv?=
 =?utf-8?B?dnU2T09aL3JZSmlDSDBtdnpxYXpmRjFISHUxdnpDUWlJcWFBalBMbmRkemNP?=
 =?utf-8?B?SDdST1ZjKzJ2a1MvV29Jb0tDSWJlaG0ydGZ3K1hodk84bFFDWGMyelZ0Z0tJ?=
 =?utf-8?B?YXpNRFlPaHArZFJJVkZJOEJLVmhaamV5N0lPNnZSUkhwekNQam83UnI5Nkxv?=
 =?utf-8?B?RUYrN1FscDZpcXFFNFZpQzFUdWc3K2xRR0tmN2ozSUswenpVMTFFRHo2MmRT?=
 =?utf-8?B?bjVvS2dMU1VGQlJ6d2prbGY2UTZWYnV3anNjRlhuTEVZaFpzdmU5eEZBTHhY?=
 =?utf-8?B?RFAwSitkRHhzTThxTlFnTTViNXRqVDY3ZC9WMFFxM0t1OXkxQ010SlVUWjFG?=
 =?utf-8?B?L3B0TjJ5aUxOV2xIczBWdVYwWmxCeStWUXoyc2NtY0FJMk9IV2RVUXltZStj?=
 =?utf-8?B?Y0FxbE45VGZyTUM1M2RuUDFpOVUzK29aSTZldUtraTk0eWJ4NGMxR2VBTys5?=
 =?utf-8?Q?okbUATZ4YO9pMFuoBcFWFyaNJ?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0C2F8006EB12F943B1C5B29BE96E2BD9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15cdf407-e73c-4c6a-3663-08daac41a56e
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 11:05:17.4193
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4A1ohCexRFiec4dnQab+ffFM6mQWGPOj1cnLS/UNCLhuewiIWVt5Xh7DQ8EHCar6dhNmxsq7O//GQkzZunUUNgr5hn7BICL4SHyAWoR2sro=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5885

T24gMTIvMTAvMjAyMiAxMTo0OSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBBbmRyZXcsDQo+
DQo+IE9uIDEyLzEwLzIwMjIgMTE6MjksIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxMi8x
MC8yMDIyIDExOjAxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gKCsgQmVydHJhbmQgJiBTdGVm
YW5vKQ0KPj4+DQo+Pj4gSGkgSGVucnksDQo+Pj4NCj4+PiBPbiAxMi8xMC8yMDIyIDA3OjM5LCBI
ZW5yeSBXYW5nIHdyb3RlOg0KPj4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+Pj4+
IFN1YmplY3Q6IFJlOiBbeGVuLXVuc3RhYmxlLXNtb2tlIHRlc3RdIDE3MzQ5MjogcmVncmVzc2lv
bnMgLSBGQUlMDQo+Pj4+Pg0KPj4+Pj4gT24gMTEuMTAuMjAyMiAxODoyOSwgb3NzdGVzdCBzZXJ2
aWNlIG93bmVyIHdyb3RlOg0KPj4+Pj4+IGZsaWdodCAxNzM0OTIgeGVuLXVuc3RhYmxlLXNtb2tl
IHJlYWwgW3JlYWxdDQo+Pj4+Pj4gaHR0cDovL2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcv
b3NzdGVzdC9sb2dzLzE3MzQ5Mi8NCj4+Pj4+Pg0KPj4+Pj4+IFJlZ3Jlc3Npb25zIDotKA0KPj4+
Pj4+DQo+Pj4+Pj4gVGVzdHMgd2hpY2ggZGlkIG5vdCBzdWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcs
DQo+Pj4+Pj4gaW5jbHVkaW5nIHRlc3RzIHdoaWNoIGNvdWxkIG5vdCBiZSBydW46DQo+Pj4+Pj4g
wqDCoCB0ZXN0LWFybTY0LWFybTY0LXhsLXhzbcKgwqDCoMKgwqAgMTQgZ3Vlc3Qtc3RhcnTCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmYWlsDQo+Pj4+Pj4gUkVHUi4gdnMuIDE3MzQ1Nw0KPj4+
Pj4NCj4+Pj4+IFBhcnNpbmcgY29uZmlnIGZyb20gL2V0Yy94ZW4vZGViaWFuLmd1ZXN0Lm9zc3Rl
c3QuY2ZnDQo+Pj4+PiBsaWJ4bDogZGVidWc6IGxpYnhsX2NyZWF0ZS5jOjIwNzk6ZG9fZG9tYWlu
X2NyZWF0ZTogYW8NCj4+Pj4+IDB4YWFhYWNhY2NmNjgwOg0KPj4+Pj4gY3JlYXRlOiBob3c9KG5p
bCkgY2FsbGJhY2s9KG5pbCkgcG9sbGVyPTB4YWFhYWNhY2NlZmQwDQo+Pj4+PiBsaWJ4bDogZGV0
YWlsOiBsaWJ4bF9jcmVhdGUuYzo2NjE6bGlieGxfX2RvbWFpbl9tYWtlOiBwYXNzdGhyb3VnaDoN
Cj4+Pj4+IGRpc2FibGVkDQo+Pj4+PiBsaWJ4bDogZGVidWc6IGxpYnhsX2FybS5jOjE0ODpsaWJ4
bF9fYXJjaF9kb21haW5fcHJlcGFyZV9jb25maWc6DQo+Pj4+PiBDb25maWd1cmUNCj4+Pj4+IHRo
ZSBkb21haW4NCj4+Pj4+IGxpYnhsOiBkZWJ1ZzogbGlieGxfYXJtLmM6MTUxOmxpYnhsX19hcmNo
X2RvbWFpbl9wcmVwYXJlX2NvbmZpZzrCoCAtDQo+Pj4+PiBBbGxvY2F0ZQ0KPj4+Pj4gMCBTUElz
DQo+Pj4+PiBsaWJ4bDogZXJyb3I6IGxpYnhsX2NyZWF0ZS5jOjcwOTpsaWJ4bF9fZG9tYWluX21h
a2U6IGRvbWFpbiBjcmVhdGlvbg0KPj4+Pj4gZmFpbDogTm8NCj4+Pj4+IHN1Y2ggZmlsZSBvciBk
aXJlY3RvcnkNCj4+Pg0KPj4+IFNvIHRoaXMgaXMgLUVOT0VOVCB3aGljaCBjb3VsZCBiZSByZXR1
cm5lZCBieSB0aGUgUDJNIGlzIGl0IGNhbid0DQo+Pj4gYWxsb2NhdGUgYSBwYWdlIHRhYmxlIChz
ZWUgcDJtX3NldF9lbnRyeSgpKS4NCj4+Pg0KPj4+Pj4gbGlieGw6IGVycm9yOiBsaWJ4bF9jcmVh
dGUuYzoxMjk0OmluaXRpYXRlX2RvbWFpbl9jcmVhdGU6IGNhbm5vdA0KPj4+Pj4gbWFrZSBkb21h
aW46DQo+Pj4+PiAtMw0KPj4+Pj4NCj4+Pj4+IExhdGVyIGZsaWdodHMgZG9uJ3QgZmFpbCBoZXJl
IGFueW1vcmUsIHRob3VnaC4NCj4+Pj4+DQo+Pj4+Pj4gwqDCoCB0ZXN0LWFybWhmLWFybWhmLXhs
wqDCoMKgwqDCoMKgwqDCoMKgIDE0IGd1ZXN0LXN0YXJ0wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgZmFpbA0KPj4+Pj4+IFJFR1IuIHZzLiAxNzM0NTcNCj4+Pj4+DQo+Pj4+PiBTaW1pbGFyIGxv
ZyBjb250ZW50cyBoZXJlLCBidXQgbGF0ZXIgZmxpZ2h0cyBjb250aW51ZSB0byBmYWlsIHRoZQ0K
Pj4+Pj4gc2FtZSB3YXkuDQo+Pj4+Pg0KPj4+Pj4gSSdtIGFmcmFpZCBJIGNhbid0IGRyYXcgY29u
Y2x1c2lvbnMgZnJvbSB0aGlzOyBJIGhhdmVuJ3QgYmVlbiBhYmxlDQo+Pj4+PiB0byBzcG90DQo+
Pj4+PiBhbnl0aGluZyBoZWxwZnVsIGluIHRoZSBoeXBlcnZpc29yIGxvZ3MuIE15IGJlc3QgZ3Vl
c3MgcmlnaHQgbm93IGlzDQo+Pj4+PiB0aGUgdXNlDQo+Pj4+PiBvZiBzb21lIHVuaW5pdGlhbGl6
ZWQgbWVtb3J5LCB3aGljaCBqdXN0IGhhcHBlbmVkIHRvIGdvIGZpbmUgaW4gdGhlDQo+Pj4+PiBs
YXRlcg0KPj4+Pj4gZmxpZ2h0cyBmb3IgNjQtYml0Lg0KPj4+DQo+Pj4gSXQgbG9va3MgbGlrZSB0
aGUgc21va2UgZmxpZ2h0IGZhaWxlZCBvbiBsYXh0b24wIGJ1dCBwYXNzZWQgb24NCj4+PiByb2No
ZXN0ZXJ7MCwgMX0uIFRoZSBmb3JtZXIgaXMgdXNpbmcgR0lDdjIgd2hpbHN0IHRoZSBsYXR0ZXIg
YXJlIHVzaW5nDQo+Pj4gR0lDdjMuDQo+Pj4NCj4+PiBJbiB0aGUgY2FzZSBvZiBHSUN2Miwgd2Ug
d2lsbCBjcmVhdGUgYSBQMk0gbWFwcGluZyB3aGVuIHRoZSBkb21haW4gaXMNCj4+PiBjcmVhdGVk
LiBUaGlzIGlzIG5vdCBuZWNlc3NhcnkgaW4gdGhlIEdJQ3YzLg0KPj4+DQo+Pj4gSUlSQyB0aGUg
UDJNIHBvb2wgaXMgb25seSBwb3B1bGF0ZWQgbGF0ZXIgb24gKHdlIGRvbid0IGFkZCBhIGZldyBw
YWdlcw0KPj4+IGxpa2Ugb24geDg2KS4gU28gSSBhbSBndWVzc2luZyB0aGlzIGlzIHdoeSB3ZSBh
cmUgc2VlbiBmYWlsdXJlLg0KPj4+DQo+Pj4gSWYgdGhhdCdzIGNvcnJlY3QsIHRoZW4gdGhpcyBp
cyBhIGNvbXBsZXRlIG92ZXJzaWdodCBmcm9tIG1lIChJDQo+Pj4gaGF2ZW4ndCBkb25lIGFueSBH
SUN2MiB0ZXN0aW5nKSB3aGlsZSByZXZpZXdpbmcgdGhlIHNlcmllcy4NCj4+Pg0KPj4+IFRoZSBl
YXN5IHdheSB0byBzb2x2ZSBpdCB3b3VsZCBiZSB0byBhZGQgYSBmZXcgcGFnZXMgaW4gdGhlIHBv
b2wgd2hlbg0KPj4+IHRoZSBkb21haW4gaXMgY3JlYXRlZC4gSSBkb24ndCBsaWtlIGl0LCBidXQg
SSB0aGluayB0aGVyZSBvdGhlcg0KPj4+IHBvc3NpYmxlIHNvbHV0aW9ucyB3b3VsZCByZXF1aXJl
IG1vcmUgd29yayBhcyB3ZSB3b3VsZCBuZWVkIHRvIGRlbGF5DQo+Pj4gdGhlIG1hcHBpbmdzLg0K
Pj4NCj4+IEhvbmVzdGx5LCBJJ3ZlIGNvbnNpZGVyZWQgZG9pbmcgdGhpcyBvbiB4ODYgdG9vLg0K
Pg0KPiBBRkFJQ1QsIHRoaXMgaXMgYWxyZWFkeSB0aGUgY2FzZSBmb3IgSEFQIChzZWUgY2FsbCB0
bw0KPiBoYXBfc2V0X2FsbG9jYXRpb24oKSBpbiBoYXBfZW5hYmxlKCkpLiAyNTYgcGFnZXMgd2ls
bCBiZSBwcmUtYWxsb2NhdGVkLg0KDQpSaWdodCwgYnV0IGl0J3MgYXN5bW1ldHJpYyB3aXRoIHNo
YWRvdy7CoCBUaGlzIHdhbnRzIGZpeGluZyBhbmQgc2ltcGxpZnlpbmcuDQoNCj4NCj4+DQo+PiBU
aGVyZSBhcmUgc2V2ZXJhbCB0aGluZ3Mgd2hpY2ggd2FudCBhbGxvY2F0aW5nIGluIGRvbWFpbl9j
cmVhdGUoKSwgYnV0DQo+PiBhcmUgZGVmZXJyZWQgdG8gbWF4X3ZjcHVzKCkgYmVjYXVzZSB0aGV5
IHJlcXVpcmUgdGhlIFAyTSBoYXZpbmcgYQ0KPj4gbm9uLXplcm8gYWxsb2NhdGlvbi7CoCBUaGlz
IGluIHR1cm4gbWVhbnMgd2UndmUgZ290IGEgbG9hZCBvZiBjaGVja3MgaW4NCj4+IHBhdGhzIHdo
ZXJlIHdlJ2QgaWRlYWxseSBub3QgaGF2ZSB0aGVtLg0KPj4NCj4+IFdlIGFscmVhZHkgaGF2ZSBh
IGNhbGN1bGF0aW9uIG9mIHRoZSBhYnNvbHV0ZWx5IG1pbmltdW0gd2Ugd2lsbCBldmVyDQo+PiBw
ZXJtaXQgdGhlIHAybSBwb29sIHRvIGJlLsKgIElNTyB3ZSBvdWdodCB0byBhbGxvY2F0ZSB0aGlz
IG1pbmltdW0gc2l6ZQ0KPj4gaW4gZG9tYWluX2NyZWF0ZSgpLg0KPg0KPiBJdCBkZXBlbmRzIG9u
IHRoZSBudW1iZXIuIEF0IHRoZSBtb21lbnQgZG9tYWluX2NyZWF0ZSgpIGlzIG5vdA0KPiBwcmVl
bXB0aWJsZSwgc28gd2UgZG9uJ3Qgd2FudCB0byBhbGxvY2F0ZSB0b28gbWFueSBwYWdlcyAoSSB0
aGluayBldmVuDQo+IDI1NiBwYWdlcyBjb3VsZCBiZSByaXNreSBvbiBzb21lIEFybSBwbGF0Zm9y
bSkuDQo+DQo+IE1heWJlIHRoZSBzb2x1dGlvbiBpcyB0byBoYXZlIGRvbWFpbl9jcmVhdGUoKSBw
cmVlbXB0aWJsZS4gQnV0IGl0IGlzDQo+IG5vdCBzb21ldGhpbmcgdGhhdCBjb3VsZCBiZSBkb25l
IGluIHRoZSA0LjE3IHRpbWUgZnJhbWUuDQoNCmRvbWFpbl9jcmVhdGUoKSBjYW4ndCBiZSBwcmUt
ZW1wdGlibGUgaW4gaXRzIGN1cnJlbnQgZm9ybSwgYmVjYXVzZSBpdA0KZGVwZW5kcyBvbiAiYXRv
bWljYWxseSIgdGFraW5nIHRoZSBkb21pZCBmcm9tIG5vdCBleGlzdGluZyB0byBleGlzdGluZy7C
oA0KU3BlY2lmaWNhbGx5LCB1bnRpbCB0aGUgaHlwZXJjYWxsIGNvbXBsZXRlcywgb3RoZXIgaHlw
ZXJjYWxscyBjYW4ndCBmaW5kDQphIHN0cnVjdCBkb21haW4qIGZvciB0aGUgZG9taWQuDQoNClRo
aXMgaXMgbmVjZXNzYXJ5LCBiZWNhdXNlIHdlIGd1YXJhbnRlZSB0aGF0IHdoZW4geW91IGNhbiBs
b29rIHVwIGENCmRvbWFpbiBieSBkb21pZCwgZS5nLiB0aGUgcHJlZGljYXRlcyB3b3JrIG9uIGl0
LCBhbmQgZC0+bWF4X3ZjcHVzIGlzDQpub256ZXJvLCBldGMuDQoNCkluIHNvbWUgZnV0dXJlIHdo
ZXJlIHRoZSBlcnJvciBwYXRocyBoYXZlIGJlZW4gbWFkZSBpZGVtcG90ZW50IGFuZCB3ZQ0KaGF2
ZSBhIGNsZWFuIHNwbGl0IGJldHdlZW4gdGVhcmRvd24gYW5kIGRlc3Ryb3ksIHdlIHByb2JhYmx5
IGNhbiBhbHRlcg0KdGhlIGV4aXN0aW5nIGNyZWF0aW9uIHBhdGggdG8gZG8gYSBtb3JlIGJhc2lj
IGluaXRpYWwgc2V0dXAgKHdoaWNoIGNhbg0KYmUgY2xlYW5lZCB1cCBieSB0aGUgZGVzdHJveSBs
b2dpYyksIHRoZW4gaW5zZXJ0IHRoZSBkb21haW4gaW50byBkb20NCmhhc2h0YWJsZSBhbmQgYXV0
b21hdGljYWxseSBjb250aW51ZSBpbnRvIGEgZGlmZmVyZW50IHN1Ym9wIGFuZCBwZXJmb3JtDQpt
b3JlIGxvbmctcnVubmluZyBzZXR1cC4NCg0KQnV0IHllYWggLSBhYnNvbHV0ZWx5IGRlZmluaXRl
bHkgbm90IDQuMTcgY29udGVudC4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 11:23:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 11:23:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421021.666193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiZpd-0003km-M3; Wed, 12 Oct 2022 11:23:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421021.666193; Wed, 12 Oct 2022 11:23:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiZpd-0003kf-JC; Wed, 12 Oct 2022 11:23:25 +0000
Received: by outflank-mailman (input) for mailman id 421021;
 Wed, 12 Oct 2022 11:23:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiZpb-0003kV-Ux; Wed, 12 Oct 2022 11:23:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiZpb-0003mH-S1; Wed, 12 Oct 2022 11:23:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiZpb-0004X4-IN; Wed, 12 Oct 2022 11:23:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiZpb-0007q7-Hz; Wed, 12 Oct 2022 11:23:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bn8tEYpc95/YtNrJHtDhJ6BMAEJZQWl9VJaodkM0mEs=; b=eDzdAg+HX6dN3Z006bwRRsd2ON
	VoMB2b2zymcO5oxmNTKjaDxgQK6dXKJk/J3XucJ3e/FAneUP2GXtiBTjHZMVSPAozdwWkD22ZQ2DR
	9CzSyxc4cDWYqyX2bp8xx05e4VnKcKsH5I7GFThHaLCRJRSf/uKRy12pfaDcjensPOD8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173521-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173521: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:build-arm64:xen-build:fail:regression
    xen-4.13-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.13-testing:build-armhf:xen-build:fail:regression
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=042de0843936b690acbc6dbcf57d26f6adccfc06
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 11:23:23 +0000

flight 173521 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173521/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172549
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172549
 build-armhf                   6 xen-build                fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  042de0843936b690acbc6dbcf57d26f6adccfc06
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   57 days
Testing same since   173495  2022-10-11 14:08:01 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 436 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 11:43:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 11:43:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421039.666225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oia8i-0006Kp-PO; Wed, 12 Oct 2022 11:43:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421039.666225; Wed, 12 Oct 2022 11:43:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oia8i-0006Ki-K9; Wed, 12 Oct 2022 11:43:08 +0000
Received: by outflank-mailman (input) for mailman id 421039;
 Wed, 12 Oct 2022 11:43:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oia8h-0006KY-LU; Wed, 12 Oct 2022 11:43:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oia8h-00046M-7m; Wed, 12 Oct 2022 11:43:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oia8g-0006AJ-Ud; Wed, 12 Oct 2022 11:43:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oia8g-0007QD-UA; Wed, 12 Oct 2022 11:43:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=xlfFSOOl2JILQXofqAHur/BhWZu+CAxmOM/ayhxgBLY=; b=sEtosU1AE0fdaWRCQ39OEIg+Z5
	KsXvwmT955U1bc63693wHMldNoBLXHDbI7jxW8Rde86xIS9n3Tn4k62H4/xkovoBVJXYBex46e6pV
	/uGv2JMIxhtmIT03QHRT1EIwjJiyz0bEAkCsK1NTC/uumiLGrEC903tDyqa3QlZPI8hA=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.15-testing bisection] complete build-arm64-xsm
Message-Id: <E1oia8g-0007QD-UA@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 11:43:06 +0000

branch xen-4.15-testing
xenbranch xen-4.15-testing
job build-arm64-xsm
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  c5215044578e88b401a1296ed6302df05c113c5f
  Bug not present: 45336d8f88725aec65ee177b1b09abf6eef1dc8d
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173592/


  commit c5215044578e88b401a1296ed6302df05c113c5f
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:10:16 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.15-testing/build-arm64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.15-testing/build-arm64-xsm.xen-build --summary-out=tmp/173592.bisection-summary --basis-template=172547 --blessings=real,real-bisect,real-retry xen-4.15-testing build-arm64-xsm xen-build
Searching for failure / basis pass:
 173522 fail [host=rochester0] / 172547 [host=laxton1] 172109 ok.
Failure / basis pass flights: 173522 / 172109
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
Basis pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 df3395f6b2d759aba39fb67a7bc0fe49147c8b39
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#6503bd6a1b5364ffd346a8a475e1eb91b9f756e5-6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#df3395f6b2d759aba39fb67a7bc0fe49147c8b39-9690bb261d5fa\
 09cb281e1fa124d93db7b84fda5
Loaded 10001 nodes in revision graph
Searching for test results:
 172109 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 df3395f6b2d759aba39fb67a7bc0fe49147c8b39
 172547 [host=laxton1]
 173494 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173498 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173522 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173544 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 df3395f6b2d759aba39fb67a7bc0fe49147c8b39
 173549 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173550 pass 917a7e3f347adb0721ff161a68309f51f621eec5 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173554 pass d63242bd69a0e3eaa39afd644b634f60f384b278 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173557 pass 406ad0582a3df7af498ec4f0adee1a95ceeae64f 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173563 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 7f055b011a657f8f16b0df242301efb312058eea
 173567 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 d65ebacb78901b695bc5e8a075ad1ad865a78928
 173568 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
 173571 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 7ad38a39f08aadc1578bdb46ccabaad79ed0faee
 173575 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
 173577 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
 173580 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
 173586 pass f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
 173592 fail f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 c5215044578e88b401a1296ed6302df05c113c5f
Searching for interesting versions
 Result found: flight 172109 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d, results HASH(0x55c490ded278) HASH(0x55c490df2e10) HASH(0x55c490de8640) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 7f055b011a657f8f16b0df242301efb312058eea, results \
 HASH(0x55c490de3408) For basis failure, parent search stopping at 406ad0582a3df7af498ec4f0adee1a95ceeae64f 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x55c490ddea08) For basis failure, parent search stopping at d63242bd69a0e3eaa39afd644b634f60f384b278 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x55c490dd7dc8) F\
 or basis failure, parent search stopping at 917a7e3f347adb0721ff161a68309f51f621eec5 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x55c490dd3a90) For basis failure, parent search stopping at 0dc9b78a46813d61533b2bb0f7ef897a06a273be 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 df3395f6b2d759aba39fb67a7bc0fe49147c8b39, results HASH(0x55c490dbc1c0) HASH(0x55c490dcb748) Re\
 sult found: flight 173494 (fail), for basis failure (at ancestor ~749)
 Repro found: flight 173544 (pass), for basis pass
 Repro found: flight 173549 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 45336d8f88725aec65ee177b1b09abf6eef1dc8d
No revisions left to test, checking graph state.
 Result found: flight 173568 (pass), for last pass
 Result found: flight 173575 (fail), for first failure
 Repro found: flight 173577 (pass), for last pass
 Repro found: flight 173580 (fail), for first failure
 Repro found: flight 173586 (pass), for last pass
 Repro found: flight 173592 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  c5215044578e88b401a1296ed6302df05c113c5f
  Bug not present: 45336d8f88725aec65ee177b1b09abf6eef1dc8d
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173592/


  commit c5215044578e88b401a1296ed6302df05c113c5f
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:10:16 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200

pnmtopng: 139 colors found
Revision graph left in /home/logs/results/bisect/xen-4.15-testing/build-arm64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173592: tolerable ALL FAIL

flight 173592 xen-4.15-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173592/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-arm64-xsm               6 xen-build               fail baseline untested


jobs:
 build-arm64-xsm                                              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 12:42:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 12:42:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421096.666269 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oib4D-0005W9-Qb; Wed, 12 Oct 2022 12:42:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421096.666269; Wed, 12 Oct 2022 12:42:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oib4D-0005W2-O3; Wed, 12 Oct 2022 12:42:33 +0000
Received: by outflank-mailman (input) for mailman id 421096;
 Wed, 12 Oct 2022 12:42:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oib4C-0005Vs-Bj; Wed, 12 Oct 2022 12:42:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oib4C-00058Y-9E; Wed, 12 Oct 2022 12:42:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oib4B-0000cj-UK; Wed, 12 Oct 2022 12:42:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oib4B-0006f4-Tp; Wed, 12 Oct 2022 12:42:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=RgCDb237SiAEX5WxeJGQ46L4emwy2y2ZtjURvsevlmo=; b=ZxVJkTjtOO8r9dDFzqFSQxPwnA
	EMh7ixfNn0eCo/xsf1csM24NOAgcj5avs2/1kTIB/jahYbnliMfA/Zbt0c0bXYYuHY+ZbZQ1S2Z1y
	08QfaSDSZqCvJ43cqqMRdypgmsNXTR5JDyB96Yns+LuemuROIeci3/YqE74sbFZ3imA0=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.14-testing bisection] complete build-arm64-xsm
Message-Id: <E1oib4B-0006f4-Tp@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 12:42:31 +0000

branch xen-4.14-testing
xenbranch xen-4.14-testing
job build-arm64-xsm
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  4220eac3799f46ba84316513606a33e1ea33fb4e
  Bug not present: fd688b06a57a327dc5dbda106a104a2af5e1aa2b
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173596/


  commit 4220eac3799f46ba84316513606a33e1ea33fb4e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:42:00 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.14-testing/build-arm64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.14-testing/build-arm64-xsm.xen-build --summary-out=tmp/173596.bisection-summary --basis-template=172550 --blessings=real,real-bisect,real-retry xen-4.14-testing build-arm64-xsm xen-build
Searching for failure / basis pass:
 173517 fail [host=rochester0] / 172550 [host=rochester1] 172114 ok.
Failure / basis pass flights: 173517 / 172114
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
Basis pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#83aebe33dc76760f911162f9e7a4b98a4929776b-83aebe33dc76760f911162f9e7a4b98a4929776b git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#261b882f7704515a01f74589f57f0c1303e3b701-6e5608d1c50e0\
 f91ed3226489d9591c70fa37c30
Loaded 10001 nodes in revision graph
Searching for test results:
 172114 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701
 172550 [host=rochester1]
 173496 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173535 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701
 173540 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173547 pass d82ec90f51f61c914396271d86e64a74121dde24 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173551 pass d97ee3244d806d324a22ea530215a9f10d2b23e2 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173555 pass 710f83b79d6eab641401c054b2f40f6c630f8cd5 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173559 pass 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173562 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 9b5a7fd916a74295886a7d473c311e3c7e254e54
 173566 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 e3b66e5cba89fc0b59c9a116e7414388d45e04a0
 173517 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173570 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
 173576 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
 173579 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
 173582 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
 173591 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
 173593 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
 173596 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
Searching for interesting versions
 Result found: flight 172114 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b, results HASH(0x55bb3b04dd18) HASH(0x55bb3b058668) HASH(0x55bb3b05c1f8) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 e3b66e5cba89fc0b59c9a116e7414388d45e04a0, results \
 HASH(0x55bb3b04b3e8) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 9b5a7fd916a74295886a7d473c311e3c7e254e54, results HASH(0x55bb3b01f568) For basis failure, parent search stopping at 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55bb3b014c18) F\
 or basis failure, parent search stopping at 710f83b79d6eab641401c054b2f40f6c630f8cd5 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55bb3b039768) For basis failure, parent search stopping at d97ee3244d806d324a22ea530215a9f10d2b23e2 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55bb3b01f268) For basis failure, pare\
 nt search stopping at d82ec90f51f61c914396271d86e64a74121dde24 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55bb3b0301f8) For basis failure, parent search stopping at 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701, results HASH(0x55bb3b023ba0) HASH(0x55bb3b030820) Result found: flight 173\
 496 (fail), for basis failure (at ancestor ~759)
 Repro found: flight 173535 (pass), for basis pass
 Repro found: flight 173540 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
No revisions left to test, checking graph state.
 Result found: flight 173576 (pass), for last pass
 Result found: flight 173579 (fail), for first failure
 Repro found: flight 173582 (pass), for last pass
 Repro found: flight 173591 (fail), for first failure
 Repro found: flight 173593 (pass), for last pass
 Repro found: flight 173596 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  4220eac3799f46ba84316513606a33e1ea33fb4e
  Bug not present: fd688b06a57a327dc5dbda106a104a2af5e1aa2b
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173596/


  commit 4220eac3799f46ba84316513606a33e1ea33fb4e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:42:00 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200

pnmtopng: 161 colors found
Revision graph left in /home/logs/results/bisect/xen-4.14-testing/build-arm64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173596: tolerable ALL FAIL

flight 173596 xen-4.14-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173596/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-arm64-xsm               6 xen-build               fail baseline untested


jobs:
 build-arm64-xsm                                              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 12:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 12:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421106.666283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oib6X-00065z-8K; Wed, 12 Oct 2022 12:44:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421106.666283; Wed, 12 Oct 2022 12:44:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oib6X-00065s-5P; Wed, 12 Oct 2022 12:44:57 +0000
Received: by outflank-mailman (input) for mailman id 421106;
 Wed, 12 Oct 2022 12:44:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oib6W-00065i-3D; Wed, 12 Oct 2022 12:44:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oib6W-0005AB-1M; Wed, 12 Oct 2022 12:44:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oib6V-0000kb-Lf; Wed, 12 Oct 2022 12:44:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oib6V-0008Vy-L9; Wed, 12 Oct 2022 12:44:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=NBHvEVjdczA/XXDWP7aNhiLfL9Xq4qybvHfXLQQGIF8=; b=aZj0n9FqZJ4hmcGMGUX+nIMjUs
	HDuh1pD8aoLFkxJTRDLltyWnv82DAIByHD8HvyZTxSUayoZkGoK/5VWh61TRTGE4ovbU3ZBUYc1SV
	Tbd1IJk6vIqwhvNimXz7GIKs9GWkSf0fw/oBYG+lFQDhltwpSske4I1Gi0sVl5d9vpqQ=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.13-testing bisection] complete build-arm64-xsm
Message-Id: <E1oib6V-0008Vy-L9@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 12:44:55 +0000

branch xen-4.13-testing
xenbranch xen-4.13-testing
job build-arm64-xsm
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  e6b1e3892b685346490eded1f6b6f5392b1020b0
  Bug not present: 2ae9bbef0f84a025719382ffcf44882b76316d62
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173595/


  commit e6b1e3892b685346490eded1f6b6f5392b1020b0
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:52:02 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.13-testing/build-arm64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.13-testing/build-arm64-xsm.xen-build --summary-out=tmp/173595.bisection-summary --basis-template=172549 --blessings=real,real-bisect,real-retry xen-4.13-testing build-arm64-xsm xen-build
Searching for failure / basis pass:
 173521 fail [host=rochester0] / 172549 [host=rochester1] 172113 ok.
Failure / basis pass flights: 173521 / 172113
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
Basis pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 d8a693019845caa4e216bcac10f9501a814c99ae
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#7269466a5b0c0e89b36dc9a7db0554ae404aa230-7269466a5b0c0e89b36dc9a7db0554ae404aa230 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#d8a693019845caa4e216bcac10f9501a814c99ae-042de0843936b\
 690acbc6dbcf57d26f6adccfc06
Loaded 10001 nodes in revision graph
Searching for test results:
 172113 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 d8a693019845caa4e216bcac10f9501a814c99ae
 172549 [host=rochester1]
 173495 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
 173519 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 d8a693019845caa4e216bcac10f9501a814c99ae
 173527 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
 173529 pass d82ec90f51f61c914396271d86e64a74121dde24 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173530 pass d97ee3244d806d324a22ea530215a9f10d2b23e2 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173541 pass 710f83b79d6eab641401c054b2f40f6c630f8cd5 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173548 pass 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173552 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 08eec20dc0550316dad64cdc63fee2371702f31f
 173556 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 9992c089de1fbb4d3217d2421ca60295998645d7
 173558 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
 173561 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
 173565 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
 173569 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
 173578 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
 173521 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
 173581 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
 173595 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
Searching for interesting versions
 Result found: flight 172113 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62, results HASH(0x55f9631c7400) HASH(0x55f9631cba38) HASH(0x55f9631d0670) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 9992c089de1fbb4d3217d2421ca60295998645d7, results \
 HASH(0x55f9631b5900) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 08eec20dc0550316dad64cdc63fee2371702f31f, results HASH(0x55f9631b9f38) For basis failure, parent search stopping at 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55f9631b6a08) F\
 or basis failure, parent search stopping at 710f83b79d6eab641401c054b2f40f6c630f8cd5 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55f9631aecc0) For basis failure, parent search stopping at d97ee3244d806d324a22ea530215a9f10d2b23e2 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55f9631b00c8) For basis failure, pare\
 nt search stopping at d82ec90f51f61c914396271d86e64a74121dde24 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55f9631aa9b0) For basis failure, parent search stopping at 0dc9b78a46813d61533b2bb0f7ef897a06a273be 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 d8a693019845caa4e216bcac10f9501a814c99ae, results HASH(0x55f963198978) HASH(0x55f9631a64f8) Result found: flight 173\
 495 (fail), for basis failure (at ancestor ~321)
 Repro found: flight 173519 (pass), for basis pass
 Repro found: flight 173521 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
No revisions left to test, checking graph state.
 Result found: flight 173561 (pass), for last pass
 Result found: flight 173565 (fail), for first failure
 Repro found: flight 173569 (pass), for last pass
 Repro found: flight 173578 (fail), for first failure
 Repro found: flight 173581 (pass), for last pass
 Repro found: flight 173595 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  e6b1e3892b685346490eded1f6b6f5392b1020b0
  Bug not present: 2ae9bbef0f84a025719382ffcf44882b76316d62
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173595/


  commit e6b1e3892b685346490eded1f6b6f5392b1020b0
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:52:02 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200

pnmtopng: 160 colors found
Revision graph left in /home/logs/results/bisect/xen-4.13-testing/build-arm64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173595: tolerable ALL FAIL

flight 173595 xen-4.13-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173595/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-arm64-xsm               6 xen-build               fail baseline untested


jobs:
 build-arm64-xsm                                              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:05:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:05:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421139.666319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibQ4-0000iM-9r; Wed, 12 Oct 2022 13:05:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421139.666319; Wed, 12 Oct 2022 13:05:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibQ4-0000hj-53; Wed, 12 Oct 2022 13:05:08 +0000
Received: by outflank-mailman (input) for mailman id 421139;
 Wed, 12 Oct 2022 13:05:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oibQ2-0000gX-QT
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:05:06 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d3df7ee-4a2e-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 15:05:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7283.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 13:05:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 13:05:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d3df7ee-4a2e-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q+jqd7oVkMRzUR+TScJsTt35j+ecBiOv1BR+wBMXP7RdLeceEtRtaBWKkOApnJbBSLFjDzJ9y4fv0o8YGLgBzMBQOHbryBSx18baSD3kv6rN+R000878PWdx9mOOSHHAM7VbfKhm0R1I93vUjRwCyYn4HF8kIALCsB65GcZg5MSZAFlD6jhY/5hrxeBtIyDh1Bgi1TUF/bGn7FCFyHDSokSn1cd8Pe0mv9kT/YHegpELOPHjc6yLCxkwsG6ut/nuVBUIubKRm5a+4xKJpvgw402envLKMvJcofKoy4lZuPw/hcWYXiBzdRA9nmDPNLlMr65SAxAoLzdJO6uSCx1xmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b2sXbvaGhT3VwITSLxnrPr1tyc6+JoIMGDhu4msM+tc=;
 b=DSL8XjEli1hDoo96iGppZ5L5NyQ1DJvSXFzhGyo0AoPT79JExUWuMNNqURL3ycpGxpsJT/fE9lL8Ia1EBV0SYdNccEv/tA4YStPiStFjMN56IH7/Xo70DzZ5UmE942o5S4DJbUDtgs+PNI+8MRvSZpCYaNdVN65Nwk9JBqa/aQDu3D5HEeP/bBWQ0eWk1z03ZaM/QmX/TBLkXpqq/OQ4yAf4MJpr4ejQr0cyCIIyKNiIkr+Jqm0AGIaKlaG+IyBKPI1hXVLUhUO3MZMk0AwmQsMsjArYzislwJGZTRg9VADo9GPB326nj/PDMjx643oLSwFUAQ8fiAsFBaXe+o0hVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=b2sXbvaGhT3VwITSLxnrPr1tyc6+JoIMGDhu4msM+tc=;
 b=VGnWlGnVT7/QIMGUlpJluaWLDvCrtReg/9D+cz8J0fmQ8q0Yyhrbv8sXsRWVliqlqurwHucbzxBGI4Ay5aFphGEAZLJjsZPTdvVaDO5wyrwbUnloX6GWbMOCtKgt4E5Ksc/S+IBYLh2Q3f4LaIx2ilqXKvyX2JEy4AyhnTi/bsOYlvqxKeGir7yP+Pg2KRdrDAjKdo5q1uggOf5Tnx/W4UEH3KI3lQq8ZDPT89L62nn3bDtFiqCFUJvx8cMggSaFaGmrHfmwK5CKlOid/I3eHKKsqFZ0zW/PrexvjyY/AptlN3mom5xKKiYXDfsxMzXba2Z3LMPDUSm6xcYKx2Gpzg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <805d66fe-e116-254f-015a-59a760639653@suse.com>
Date: Wed, 12 Oct 2022 15:05:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Anthony Perard <anthony.perard@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to
 fix build
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0274.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7283:EE_
X-MS-Office365-Filtering-Correlation-Id: 8cdd2d74-38c4-47e7-2d41-08daac526083
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4FjmLVCuFsZBjZdJ4hyD4xyxTlI2hhKUUdeCenNKqGUBtHExASRdT44M9dQa6kc8eB7mG7mSlf1UlJW8rEzspnOBD+0e5t8/eJ30RxtH2qeIgTu/U3N6AYLShSp5tJXHNVnXvxLE3aRs1v3RgAhtSszbQZqz3vDnsC08ZFQiaft/XSxxmQckJXavomtxqgi34T1C9FjI6i0WPrsSRlFeXixZQTvkvaiOwDPHQ0aY1/YnT/sa3a+XPpme2gZdCNgeQKEiZpNH7g6swgwj3Nshc/DnqHs5n9us8syFCf0m2HTxLtGNORu2adIlnrPbORLB8imp/BcZ/9C6stms1Kl9J27e6A/trLwXzOud4UFnUadqoZNgUqUzCpoTVDsB94il7YR9855fF1Sbp/a9s12xJGwBpxG1g9wP7z0efA0u/lvdNaaTuhIluxJMw+tTtgChZj0vZq8Ht8xZfW2D7ZzauzXFk1pGjTYMHWtidwAzjry/M68gnV0c7m/KRUv/uY47u6Enz3fXk1FLxFhKk/G68COqrCo6LVKOamwxj0f5l+D4OgYEv6HmEWZjbBDE062h6Oyzvwm8UEGei1PbMGX6zjER+xrA/xP0neNOCTmHKidoDm3oqFiO/Imu3N96+hTPwPdOXJS3HQ6oTmsfeC8GaiY45D53PVvm/quh6IOa/0fiFplI+YkCa8WC35EC8MSGi7qrW2mSi+9+yoGLkn4sryM1sI+1tCR4f1sgeE4Hubdd96ecysHB01AxlrEGNr574zJIxP4ECD965UyQDX/kqsavnc8VSyjBPIiWY5txAF8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(136003)(376002)(346002)(451199015)(54906003)(6916009)(316002)(66946007)(8936002)(4744005)(38100700002)(2906002)(4326008)(66476007)(41300700001)(66556008)(8676002)(5660300002)(6512007)(6506007)(186003)(2616005)(478600001)(6486002)(31686004)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WkxJOWxKTU12TU1FK2g1U0ZNajN6WFlNby83VnJlb0dza3VITVI4V2JSTkF4?=
 =?utf-8?B?UnhpRzlhWkc1ZnkyOTBhTEJLVE50Wm1JTnlHamU0bWNub0Ztb2JJRE5CTlZY?=
 =?utf-8?B?dDhzcDFrU2U5aFhsMmFqRWhhZHdld2p3cXFSZk9nbnlkbmp3REpYKy9BN09s?=
 =?utf-8?B?RlZ2TmRHKzNLMUlRK3F1VllwSVUwSkJYR3d2NWlka0dXRlNkOW9PL2kyRnor?=
 =?utf-8?B?cS9VUzFlZk1zWGV6VU1PcnhuNFlKc2ZJWVltUTZod043UGpZRHdlYVcwRno4?=
 =?utf-8?B?VVRlZk9wOVVFb1Q2OVpxeHhINWdBeldjL1p0aEo2YnEzYnZwSmN5QldseVhy?=
 =?utf-8?B?WVgzczB5TDJpYXZLYWo2eElBcFg0THkzZ2RCZEdxTURPWWs3TmxDWEVkZU1q?=
 =?utf-8?B?WUFWNE5ETHpINVRiQThzd2YwZXJVaHVKUGEwZUhuSVIzQU52L3pqMUR5eTJV?=
 =?utf-8?B?RWtPbTNMcWwzZ01Ncy9rZDhOVWhvR1h0Uk54OEFueUltOW12S0RjL1NIS1h4?=
 =?utf-8?B?ZCs1V3ZFeUFMR0ZVeVpreit1bndmUEhONDhQRC9WVXZYaUhFeVFSSmd6NlhY?=
 =?utf-8?B?L0hKUXRKOWJEdkRiaUlDZkE3T2hzQWMwcVZYN0xDZ0hvbkppL09vbmI4S0Iy?=
 =?utf-8?B?N25YS2tobGVZMXl5Yk1UdnQ0ZkRyU3pSbi8zQzN6K0FBOXlCV1o5bExUM3Bp?=
 =?utf-8?B?Umcydk1hcWwyYWwxNEc1NDV1TWFPNE5QRmtVRmY4dTdEYTY3Rk9XSGMyd3Uw?=
 =?utf-8?B?aVdHcFBkdjlTeitwbUEvcDhwZXBnUVM0QWM4cUJwL1ZSd201NTJnaXVSdmxY?=
 =?utf-8?B?cEZxRWpnVldQcERDa1U0UFR1dExGaCtTSW55b24yYjZja3RQUnVHRlA3OVNx?=
 =?utf-8?B?LytyeVJleVV5UHdiM1F5UnBrZlJsT0FGTFowYXNlYzhrV1RHdUdwbEl4cHor?=
 =?utf-8?B?RmRmdUJRMVd6ZElrTTc2UVhvRUxDWTU3QXppQ2QraVpLRlhtU3A4MFFiNnhl?=
 =?utf-8?B?NUI3SHNnN0s5R3NzcXBod2luN1FNcTFleENxUTZBdTFRSGNoMEdvTDB0SUI2?=
 =?utf-8?B?RmxvU0tick90UjhFcFpiMnVkVzB4Mi95TGtTaGk1MU9jZUNoNFcvZ2RGSzA1?=
 =?utf-8?B?TlpmSTNQYVdaeXE4MmU3L1pLRnpQTkE3aUx3bEJRaHc0cU4xbDNJS2ViSEJ4?=
 =?utf-8?B?MUVvMFpPc1FKZmIzU0ZLdVhpeXZPNVFkamxXaEVlL04vaTdreVFOaVJwTDg4?=
 =?utf-8?B?UXU4dW82VHhmZE1YNFc5ZlBWUFNXSVZ6NHl5YzMzTmpBdEg3MmR2Nkp3dlJm?=
 =?utf-8?B?Uk9Ra3pVZEVqaGgrQXpBY2NnaEkxeHBSaGJBNmdQcmNNY2hDL1M4NzNKR25o?=
 =?utf-8?B?ZkxKckt6cUFmRWJabWFraU9Nb1BPV2Z1RHpGYnVqNndNT2duT2M2ZnE2ZVNZ?=
 =?utf-8?B?MkNtWW5MUkMwZk1TYXV3WWdEZStGZ3I4c0EzUm5qSXV5ZTBFVjlNTGZwWXJC?=
 =?utf-8?B?NnYzWEpzZGRidnVXRCtEWG95M3YwLzhEWnVNOWZyeklEUlc1QW82Y3dtaVBo?=
 =?utf-8?B?OEJRTFhuUjE2dEVrQ3R4YVY2QjZZU29aeWF1eEFmU0NqbVA5bUJUS0VsekVn?=
 =?utf-8?B?U2Q0UU9Ed0k2ME9HWFZHNUlwdEtpeGl6akVodzVYKzdWd2ZFREw1aEV5ajU5?=
 =?utf-8?B?QlV0WUgxUlhBVjVVRUhiTVpSTkROMDd2RFcrd0V1YU0vS0ZDZ0w0V2JzR0V2?=
 =?utf-8?B?eDZCNFQvNGNubFFHTGJwYWtPVVVIMC9iOXd1cGMwUjFza1UvdVZxZVJLN3p1?=
 =?utf-8?B?cFRvVjlvbEZ2MGhVUDY3SjhsZEIvOTVZYm14UitKNVVPRDJhTTg2amNEZEU0?=
 =?utf-8?B?Z2hiTXcwdGdhbitEeU90dEJQT09hZ1VTTW9DRmFxVGVHUVZ6c2VtS2Z6Nklh?=
 =?utf-8?B?NTNKVzdmMWtUa0pFb29BZFo1YUhBYlB1ZFNNUzRTOFdIR2Q2QVV6dkdWQlF3?=
 =?utf-8?B?UGtvbHJGQmIzcDVXQjBmbGxkazlXTWR4UlpSdkZwRFA2UHlKWGtmckVtdEsr?=
 =?utf-8?B?YkR5dHozU2N2K2g2RVd6OWphK3RxL2ZVVVhwMXlLRUV6VUp1VTYrb0Q3cHA0?=
 =?utf-8?B?dlR6QTVmT1k4dzhqcVc5ZjlWejNOMjFkeUR6STdUMDRGM2FDWWNQSzFpTExC?=
 =?utf-8?Q?AsehQpzCrcQPHrBOovwj+GJRFjBkLKsoXW7eUG/qkhFX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cdd2d74-38c4-47e7-2d41-08daac526083
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:05:03.4570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J+i2ccRDaBfMPofw/Ztptfd0R2XeJiI6HRNljSmHPSD/iu+HriAGN2BHVY3dLgLh2V0SKEHB0QJ59c6QoIVG5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7283

The backport didn't adapt to the earlier function prototype taking more
(unused here) arguments.

Fixes: c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Also applicable to 4.14 and 4.13.

--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -136,7 +136,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
 
     int r = xc_shadow_control(ctx->xch, domid,
                               XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
-                              &shadow_mb, 0);
+                              NULL, 0, &shadow_mb, 0, NULL);
     if (r) {
         LOGED(ERROR, domid,
               "Failed to set %u MiB shadow allocation", shadow_mb);


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:07:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:07:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421148.666333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibSf-0001P0-QX; Wed, 12 Oct 2022 13:07:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421148.666333; Wed, 12 Oct 2022 13:07:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibSf-0001Ot-NP; Wed, 12 Oct 2022 13:07:49 +0000
Received: by outflank-mailman (input) for mailman id 421148;
 Wed, 12 Oct 2022 13:07:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oibSe-0001On-SY
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:07:48 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2076.outbound.protection.outlook.com [40.107.104.76])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dd41839b-4a2e-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 15:07:46 +0200 (CEST)
Received: from AM6P192CA0093.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::34)
 by AS2PR08MB9642.eurprd08.prod.outlook.com (2603:10a6:20b:609::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 13:07:42 +0000
Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::38) by AM6P192CA0093.outlook.office365.com
 (2603:10a6:209:8d::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Wed, 12 Oct 2022 13:07:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 13:07:41 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Wed, 12 Oct 2022 13:07:41 +0000
Received: from 0af00bf121f5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8BEBB238-F119-470C-A705-1CAC72510A2B.1; 
 Wed, 12 Oct 2022 13:07:34 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0af00bf121f5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 13:07:34 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PAWPR08MB8888.eurprd08.prod.outlook.com (2603:10a6:102:33c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 13:07:33 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 13:07:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd41839b-4a2e-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=NJlunwqiYToYGUmwn5fDGH8QBc1utnRGsO7+tPnCCiA5hf+gPK44l753Z4USMZWHxw8m8NtBicmfcmB92FtHXnuy1QXzX4O9DOqqU7frfMUx5oJKPmiFBy9bL3gzYXyzEIAEgZH6I8XUmt4piYcs3omkDyfc73soKD2H0YM4h5kV439aD7lKcXPovvLQ9zwU8zDvJ2HbEK8s2xcuquSq+Q2U9sLSDumdMm8mikmDbvopTo1T5uRYtlsP76mtIUouxj4m8WFcisyCwG+cB34vgC+t0g3uN1Nfg0fv+KInzP+7VkGAZmKuT8O9SWPjkfvaY9UAeKZzeW3G0XDLDwhMPQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AkGbKIG4JPb9t+41eWW+cdl8K3bOYyJ6hqUvvd78PnY=;
 b=kA6YCLcC97fHFrHKp7epKqUYQr4OfFP6dlqREPPBCulH61NmhZGNPhXYyCoG74cAwkvlQTs+qphNKqclBo4nDqX36OMsS3VdPHYQF/YtrBMWzS8D09m/S3/GNpVshSVcVfR7hNxFu7mPLWqP6Hlwl3dR8+p61Qs3hYS8wcIWm2I7QjIjBzV9OeNTtY3TcgoQGWwKBlYyQsgRXD8wKkQLCF/ZfmkCNBLkuHKN7hdDpQWznOPX6V8igd+6pRRqFheqIh4JisKLPr8vbpPdeE+/QPaBcvccjHyTlopuzh51tnqMPI6bnKbQWcVvcR9B/CCZl8aZNZ9/SIWFErDAUiC1lg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AkGbKIG4JPb9t+41eWW+cdl8K3bOYyJ6hqUvvd78PnY=;
 b=5xu6Oh4OWMvVL4+dglqJDOFzzM0+TZLBy42Bbw26T8AHZEJTEt0SMHpuqwZN8eqtnW6VfRhYLnZqPKlmi4VooW7/qYW0aL1Yc0Mq7kU/kpugu7O0+NOyrDaj2Me9EHIwLg726uKrHJ5c2jzGM2dacZXEqhKzrb8W0sv2tTpa9cM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R/fnWCzFdAs9cisjKHCD31Z4dSwDLxHPMPYtgFVTxTkoEAOGJaMfOvaSF6tUfFXmCZcdAS5eKUllFN9UVBzyfY+M9BO1e6/3xqWdlp5QnN21TVQsp76xK5O/1wWeBILIAbChnqpVjTlmtjEfzD/ZsDl3PHuXoYEhl7H+WMhAysq1QwKPph54tU0bBp92tWio2BEyDCkq0cbSFz5Aef4Q1aLpv4Iwi+2KdxzfeBWGXOWKK/Cmoc3VQg+2251+QTqvEmlCH+WhjOiUqQ9l/dOl1En2gD+3aqIgt4lHi9nBs7i69zO/9OlB+iCuDx0A5KLp1HCkJxI/M7RrFmEl/6FREQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AkGbKIG4JPb9t+41eWW+cdl8K3bOYyJ6hqUvvd78PnY=;
 b=Pyb2hJ9N4yK3fL4An/SO22ZoTyG8BmVUkK+riGXNubwWBeVARYQpmHgHeJhTz+sUDWUG/GYtk2qwP0TbVL/q+zxntRAawPjR8vbzAf125UW55yTzdXv0pMYNFSy5x6d7YWfGLaGY6RaxpUWKRbvChfi+3c0SN+TNXlFxNn9rB8o1yYtLaNu5Pdex2j/B1l+NcbXbpfVJfvhENN6adVFBwd/33OcjduI2tikcxe3GtCX/wjUxeCNvZ0AU57RxL8fYmnwfBbm0lOz7T2hHQSInJ4wq9FvV9T8so7BNgcPbRF6uDWEo0HWChc/LYiM2HcN3JaXcf6id3wxR429Y5SQ80g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AkGbKIG4JPb9t+41eWW+cdl8K3bOYyJ6hqUvvd78PnY=;
 b=5xu6Oh4OWMvVL4+dglqJDOFzzM0+TZLBy42Bbw26T8AHZEJTEt0SMHpuqwZN8eqtnW6VfRhYLnZqPKlmi4VooW7/qYW0aL1Yc0Mq7kU/kpugu7O0+NOyrDaj2Me9EHIwLg726uKrHJ5c2jzGM2dacZXEqhKzrb8W0sv2tTpa9cM=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <julien@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: RE: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation
 to fix build
Thread-Topic: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation
 to fix build
Thread-Index: AQHY3jtPuivbdxpwvESMJg2+jrcZsa4Kukrg
Date: Wed, 12 Oct 2022 13:07:33 +0000
Message-ID:
 <AS8PR08MB7991025777286F904D3FB6F192229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <805d66fe-e116-254f-015a-59a760639653@suse.com>
In-Reply-To: <805d66fe-e116-254f-015a-59a760639653@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 84D7BB2E0CAA1841BD17E2F1EA857CA0.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PAWPR08MB8888:EE_|VE1EUR03FT028:EE_|AS2PR08MB9642:EE_
X-MS-Office365-Filtering-Correlation-Id: 69bcfb94-2729-47d0-3584-08daac52bee3
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4YWg/NJIAnDXv9yMYPq6HkEheXha/HSxJiuhoAHHXqJ+PJgOhlgqORi4034BQUnewuXFVf7PCnHasF+Rt4E6nQfo2sfWeamzkWHne1WooJfXGcEwhufwvC5R+McTkGkg0XDiY3jAiNgXyv67G/aWfL2QcmnPtlBq4g3qN4mk8F9X8Sh8MQy0fIyzB6caXCTF+1Pz0O+0CutaLILeJuySKxtRFxJCSpt0MmhWfJlTutmE7MEY6bXefj6vOSCJncPeX2cBx5B36411kT+r6dZo1dmQhnQNg93aWJeVy/cbP34mN3399LP3I+Sbmt0tctsz+hqih1I2z5Zc94qBdGUXEUy8F0RfZGFk7GUWw2t89SXwvp/sx0IGUfUw/nT1a2lCsRQBMHyy7eWbp74wwYzPIcpWrL4f3ql59qvjNsJ/owHq/fFxgzVxXvYJYKvf0xlD9uXGjdxK2RsOwBOvTB2w2iQw6XM7kg7HKcu+1a6NooY35afuiAJE0BtaWVi9/RV2s4P3YKT0wovisCI2ldb5iZ8m1B1J0wwClYB81wAQh6CCJYIozwKaYVUBSFc1PsCoNjdpYNF2DJ3Wde/RtyJwqfu4jZzi+MXd9fHQKj7Hnp9Zk8loZI9OUoRY4GJhGkySytEIEbT2VSsH5siEwUeZr7YubLkk0mj/k/CYWSpRMFTW4iA76JW7gERxBfOdnCMjjoh5ALVJz9Q4btslqGZ7ID7RnyhOgOA1D2kBw0DqReW1tvAd0hbMaawVrHOACOZ1VjBVAX7LpzNdm71TnBXBSg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199015)(4744005)(86362001)(83380400001)(55016003)(316002)(8676002)(2906002)(71200400001)(5660300002)(122000001)(4326008)(6506007)(8936002)(64756008)(66476007)(66946007)(66446008)(52536014)(66556008)(76116006)(33656002)(9686003)(110136005)(38070700005)(38100700002)(7696005)(41300700001)(478600001)(54906003)(186003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8888
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7d3ac9f8-4554-452f-cad9-08daac52b9f2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0xpj/Tx5MAI9zkgFRkiyLJn/rqyH5KntJlakYcJD67yC1S1JNcwuk4AyOa32kV7Q97XfCG9sp9+Ga/suGS+UDeg2C3OcBB9oHbDYblGfSElOwBwBWqqpQp4lt4lJ29CtsPZCxUkXnnH8e3AuLGUVNEilxwQR/Q7+qH8Wt62Fvr+0Z3aDv1+QgN4v4qS3atP5dxXgEsOUSMCdPRrCXvI/VgLfrnKamgL/uaYUS7ESMqX7ex1I7t5IuOCxFLaHGHfkHXvc4rHxh2Gf0cubJW6UMcrk8Mafy2JYw9tjdBFsGr87GccObjd/zuUkcPfrKxyYi/b4FYUqHQK71VMRL+eUr63qUzzbY0C5efVGmQ/ieAyNvuiWvmR86rcJ+ztK51OOHAGB6mhTpkd+3gFxU6gy24xEipGeXuzJAjfsAqYpHPAWxV5ha6R2RoZwp3Cj+heLlvNI7Onqf0KuzuavhB7O0ZDr07BX3pwXqmvvRXYxSZJmooTrdeKAukcXkF7Pd2dBzebuVXFeVYQLgKIm2QNvic5nFSD8WTI6zhjKeXaFHVVezT86Gs3YrIliy7fTqEz16wn0j36CKbpKED94DoPt2yQAnGWBzsN0G2dpkJdXz93CxGJm25hR4raqmAHfOD6/ea1iiEMdRpA+pAGkQwRzeatKLawvhxfcqfThuo4n2F2u4d0+p22lMCrDX/twqwyS7P6eNp6Lf/odVFV/H2++fYOVugjXtS4ZDt0Ym+55r/1s2SJjAgd1dMSOJMK/FMuvW6vPdAYOD0LnU/20BnycYA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(83380400001)(8936002)(8676002)(52536014)(54906003)(33656002)(82310400005)(40460700003)(107886003)(47076005)(4326008)(110136005)(26005)(70586007)(70206006)(478600001)(356005)(36860700001)(81166007)(7696005)(41300700001)(6506007)(40480700001)(82740400003)(86362001)(55016003)(2906002)(316002)(186003)(336012)(5660300002)(9686003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:07:41.4797
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 69bcfb94-2729-47d0-3584-08daac52bee3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9642

SGkgSmFuLA0KDQpJIHRob3VnaHQgdG8gc2VuZCBteSBwYXRjaCBmb3IgZml4aW5nIHRoaXMgaXNz
dWUgdG9tb3Jyb3csIGJ1dCBzaW5jZSB5b3UgYXJlDQpzZW5kaW5nLi4uDQoNCj4gLS0tLS1Pcmln
aW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29t
Pg0KPiBTdWJqZWN0OiBbUEFUQ0hdWzQuMTVdIGxpYnhsL0FybTogY29ycmVjdCB4Y19zaGFkb3df
Y29udHJvbCgpIGludm9jYXRpb24gdG8NCj4gZml4IGJ1aWxkDQo+IA0KPiBUaGUgYmFja3BvcnQg
ZGlkbid0IGFkYXB0IHRvIHRoZSBlYXJsaWVyIGZ1bmN0aW9uIHByb3RvdHlwZSB0YWtpbmcgbW9y
ZQ0KPiAodW51c2VkIGhlcmUpIGFyZ3VtZW50cy4NCj4gDQo+IEZpeGVzOiBjNTIxNTA0NDU3OGUg
KCJ4ZW4vYXJtLCBsaWJ4bDogSW1wbGVtZW50IFhFTl9ET01DVExfc2hhZG93X29wDQo+IGZvciBB
cm0iKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+
IC0tLQ0KPiBBbHNvIGFwcGxpY2FibGUgdG8gNC4xNCBhbmQgNC4xMy4NCj4gDQo+IC0tLSBhL3Rv
b2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4
bF9hcm0uYw0KPiBAQCAtMTM2LDcgKzEzNiw3IEBAIGludCBsaWJ4bF9fYXJjaF9kb21haW5fY3Jl
YXRlKGxpYnhsX19nYyAqZ2MsDQo+IA0KDQpUaGUgZGVmaW5pdGlvbiBvZiBzaGFkb3dfbWIgc2hv
dWxkIGFsc28gYmUgY2hhbmdlZCB0byB1bnNpZ25lZCBsb25nLA0KYW5kLi4uDQoNCj4gICAgICBp
bnQgciA9IHhjX3NoYWRvd19jb250cm9sKGN0eC0+eGNoLCBkb21pZCwNCj4gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIFhFTl9ET01DVExfU0hBRE9XX09QX1NFVF9BTExPQ0FUSU9OLA0K
PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnNoYWRvd19tYiwgMCk7DQo+ICsgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCAwLCAmc2hhZG93X21iLCAwLCBOVUxMKTsN
Cj4gICAgICBpZiAocikgew0KPiAgICAgICAgICBMT0dFRChFUlJPUiwgZG9taWQsDQo+ICAgICAg
ICAgICAgICAgICJGYWlsZWQgdG8gc2V0ICV1IE1pQiBzaGFkb3cgYWxsb2NhdGlvbiIsIHNoYWRv
d19tYik7DQoNCi4uLmhlcmUgc2hvdWxkIGJlICVsdS4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkN
Cg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:13:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:13:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421155.666344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibXo-0002pC-EG; Wed, 12 Oct 2022 13:13:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421155.666344; Wed, 12 Oct 2022 13:13:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibXo-0002p5-Bc; Wed, 12 Oct 2022 13:13:08 +0000
Received: by outflank-mailman (input) for mailman id 421155;
 Wed, 12 Oct 2022 13:13:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oibXn-0002ow-Dt
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:13:07 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2045.outbound.protection.outlook.com [40.107.104.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9b541c2a-4a2f-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 15:13:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8456.eurprd04.prod.outlook.com (2603:10a6:20b:3df::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 13:13:02 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 13:13:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b541c2a-4a2f-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gj2AEV36PbLMFtXaxmSAvqblTg6dpQEIFzkNTQ1OrykM4YKAfU+HHpUHyT7T19JIXHhweACGDYUASav6BGqBfRBX2Is6ib941VItko/xOdECzPZE7MORWCoMtDgEKSjoipejYh/zOdEcAKRXtGn4EUmCqn5s7x/O79XgBpGdqAXbyBNwwD4pNsTFVwMGZC1MKYXdDDGCCe6YcQ0ZWFfxtNnWw6DYke9TwLY37ghMBBJ+gZ1Xp2oLdYdE6I+hngixv7G6BSzoqvdObdZW31TKUGRk6YhKxVelBnaPgf3fniPv8XGL+2eWNU3VF2NzDCJFQnXyaZfj2uBfoDSZchnaTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S1ZFKrD/744ZTHAWmpFvq+z8nzMaq45rAAJQQ+JwLmY=;
 b=CfIntN3W/hkyFtAmS7v+bOEBXATF067/ZIh89vbaN0hUbMBBnVVdJdeLLum6pg9bGsfSMtPZrOWJpcVa7KnapdSFAgF43soS36sqhyFGOtKG08WFUiwYpF1mJR45fJGlXk2B+O69WdpIJYlPa2N2GW+CIi5JlqeBGIgI+Ulr/QAu+fSsvwIiouTepLRquBLWlLmuoqhwbLlSmNeez/GlxK8xeDqO4a7/DH0nyOqcFbkOpC9iJiJWMZdiG9sXtHLiL2LWK/E3+yLg5caavjx7Tcbylxh+yp2ZMnxlSXWeKHT5jmv2OGAnPaILliGkb0QeN83scrrMq7jWbIUCYKoiqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S1ZFKrD/744ZTHAWmpFvq+z8nzMaq45rAAJQQ+JwLmY=;
 b=uYJCm6kL0mGS6sL8vPOcZ06/6SrTj9i1VdRVRFZqrEr6nn46dVpJMaXSsZpu6Ado8Nxk69k3lx653Wa55le57REKBHwm3qqOX2l3Zg0f4Saw4iuCm4ocJNKJpvBvoHSD2UHUKJEnA10x/5nm8dMzLesZBaL1AGIlErKqFtcXJlTD9kL8PYmsRAtaYO2uOtOmfcNsl4IzuQclxWUzzCFE7XZYmTRgfVNY0hB3Yot3o33wmKqX6fSNRBT9VU9TJDaqV3ouKwOQ/GON7vlreQLf+31mXQ7X/aVuJQvG9GnWAstA4YeIC+PGOunV1jJ7gRiZxzluEITzs6FyCcWxHvJOAA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c0b2e0b1-f5bb-e75a-dfc1-60eb7006cbf3@suse.com>
Date: Wed, 12 Oct 2022 15:13:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation
 to fix build
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Julien Grall <julien@xen.org>, Anthony Perard
 <anthony.perard@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <805d66fe-e116-254f-015a-59a760639653@suse.com>
 <AS8PR08MB7991025777286F904D3FB6F192229@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991025777286F904D3FB6F192229@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0117.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::32) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8456:EE_
X-MS-Office365-Filtering-Correlation-Id: 199c2824-365e-45fa-ccd8-08daac537e17
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QxE0UHQ4bbTjnZyStVl0UrZUieH15h3IddJO3RqbfBKnmoipubPB1+IlaiNjywx4Cu4hOmiD1yRJJjMkXfPMP7MCMTKqN5nA0oOpolePX6lBxfArOmhwbCiBfXGAVcsJzSi3aiylhriD8fd9l4LBQG48ZKoq/+6Qzwt+Tg6EA7zLwBh6s2N8gdc4Unl2bpuv5RkycTFfL++d+6hlFQ0OSvMXo25v9mrFhKN4u9VkRwqH32sBtmggV6XJXzFIIUYuT2QaTN1cpmgGSN4AyYiBSc4bokNBxDIgeAFNo8aWXUEK4OdTH293UYXPQl5mM53P+Bjm1n322YMeoRxim7/UptPyQbCZj6KT8il6eZKsXcwMzagQIYa6awpYw25LXmWQZbDHn9ugdIY++D7J+obqmA0oXi1aMu+X9ku7eFxUizHdGCIB9P9gBp5iPZ4kH+uGlNiZPqXsaZLx1j8EmVB0Zk2sRYZJxLmtCLkfUxPL79Kfs5+6MICw5Cg38uae82GNjiByL/1ngcueTdjU+WWdraJNeByBIX+Opz87A7UfTHV22KMWCd+PfIn6Wb0cN5ycUvGqDe7aX+iSa+TJVGNOZgHY9JOVHuC0WKSHN4xdDFvNW4kfBCguI0/eCzSGhKhMEwRLCcRgZhjSWmdo3LKDJkuRN9kcemyhqmCCtlAdPj/yA/GkccqwwyfbkEob3ggiqWF/rYw7KuVHtDs7wgSX/24L3p0atI5Kjg3sEfzxicRQFp1WMUWc45X73jgTgYryOjD0gVGvBOKJgknxW2bF4i2QdOiyUr8vlJXA40pOm3o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(376002)(396003)(346002)(136003)(366004)(451199015)(83380400001)(2906002)(316002)(8936002)(2616005)(6512007)(6916009)(54906003)(4326008)(8676002)(6506007)(86362001)(53546011)(66476007)(66556008)(66946007)(36756003)(41300700001)(31696002)(186003)(31686004)(5660300002)(6486002)(478600001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDFhWVFNdWc2MjdPTkFEb3J3dGVWY1VxZkIrTGZqNHFweG5mVlppMU9uS2lq?=
 =?utf-8?B?Vmp5ekt2cCs0STBSMVZFbHdFcng1d2ZwVUp2WkpDVG1wRTN3cHFsTVI3cUto?=
 =?utf-8?B?akxFb1BWREJQY1o5Rk01c213QVl1WlhVbk1sampzMTA5dlVRbDJzYTByZ1Fx?=
 =?utf-8?B?dFlZRHE5a1ZSQzVnc0JRRkhrd3lhSjZvMHRMQ210WnlHSU8vanpQSDJRREFm?=
 =?utf-8?B?ZGpZS1BLZzdNK1BUdEpucXpFSnA0bCtEMTJmZ2FUYzhrakZSQ2U2MlU0bURy?=
 =?utf-8?B?TWVpNWdhQ1RrNmhmdEVJVGRsZHlZa3IvTWlCbE9MZWNVdDZ5emJ4S1EvanI1?=
 =?utf-8?B?dFppWFFKVG04Tk5KdktPSWkxQzBLVHh1UUc1bTU2YnV0Q1RaQlBORGszMmV1?=
 =?utf-8?B?QzdPNW1INmpmd0NycUJ0RWNJcXU1Y1JPUCsrZDFOYkJOSU1RV1lubE5MbUc2?=
 =?utf-8?B?Nk1abndycVUyY0s1eXduRmZabE9KdUcwNlgzaUthYUF4bXc1bE8wMXFSdHFI?=
 =?utf-8?B?eHNKblBPeXE5RWdjcCtzSFprR2d5ZkdlWngrZFhkYUJkaUR2MkRYWmVTTFor?=
 =?utf-8?B?QUFTUTYxKzlhUElkNUVra1hUeVBxeWxiTFFLcWxzRXhyaDFBVmdxNVM3M0E0?=
 =?utf-8?B?MTZieVd5UUtiS25Cc0VUTUNMeWRyYlY3WU5KZ1o2SjBpZlJ2ejh1STY5T0c4?=
 =?utf-8?B?TmlkWEZBV0txdTZIeFl3TUlUdGNieGRMT3pmckJKRFRWSmVHNUpBckl2ajJL?=
 =?utf-8?B?cVUwNnVNeXZ3VFB0L1RUSjEyNk1ucGxhY1hwNW83YzVYM053MVE4cXg4aEVW?=
 =?utf-8?B?K0FHaGV4eHlucTczS1ZQdjM1Smlqc3NiZjVGbXp3Qjdza2JGOWdsK292OWxw?=
 =?utf-8?B?b3RNY2hiWTdtVTJwYTRoRlNSYXlaMzl3YnlEYjRHUVdxSEgxcXFWVmFmKzhO?=
 =?utf-8?B?RWZqVVliMGt1aEl5UXJLOFFDditnb0FnUnN3aExBNjk5ZkRpZ0FPMVVHMGZJ?=
 =?utf-8?B?UnRFUi8wbytpL0JMdDRUTDJmQnl1MGc0NUpWZzgvdnRlSWdoNzBsOHFJbjl0?=
 =?utf-8?B?Y3J1emNucFV5T3JPWWFHUi9WOWNtUjNYaEtvaWlHTmJxT2hPb1B4bm9zazJy?=
 =?utf-8?B?ZThndFpXTDV1WWd3NHdiSkc0NEx5QVNBMHNsdUZxaCswZ3k5M0pwSDNNeWxQ?=
 =?utf-8?B?OWVaTjJEdmE5Y0l4bldIWk9NSC92NWEyWEM4QUhIUkJmWlIzTWtrYXJlSmVY?=
 =?utf-8?B?a2ErNE9pZ1U1TEdIYXQ1eEljNjZaOXFsdU8vVVV6a3J1SGFyUDMzOU9tY1VO?=
 =?utf-8?B?aHdKek9KY1ZuVjVGNlNWTXZIblhmdkt3aUFMUklCQnZ2TzlpTmZuSlR1NXd5?=
 =?utf-8?B?RjF0a21SV1BncTFHOHBKVWwzRktzSzE1MHZEVlpHdlFaWkZPUmZZNHdSWGVJ?=
 =?utf-8?B?TFRLVkd0cUhSL094S3RKN1kyMmVIVmROWkZlZHNncnVCR1pJc3pFSHRVWFdE?=
 =?utf-8?B?QmVDUVVQbDRmeEV3VnpOQ2cvL2Rsbi9Wa0lBQ3pCSzhjM212WjQ2c2RmOHVl?=
 =?utf-8?B?OHRiVDlPb0ZJRlZjRllpV24yb1FhWEwybUluL08zUVF6U1o3OUtJakJhTlAx?=
 =?utf-8?B?dHAzdHNSaWkyb3R5TS81a3FpMllMUnpIL296U1QxS2hpeFFuaDZkWXBXWW1S?=
 =?utf-8?B?VTVjTVZiZ0VyNGgwa3FENVAzdjJ4cFhlbDZ3dUpOT2NlWi8xYkdCc000U2NI?=
 =?utf-8?B?U21DajdlRXZwZlJsRzN6TCtuMjJ1WmUzYzBIUTMvdzJGbEQ0cHYyUURzeFg2?=
 =?utf-8?B?WnZVc2ZaeHY1SU1YMWRkRHRTUm0zNTF5SkI0SGVLbFVUN01PZGw5ZkZBcExB?=
 =?utf-8?B?YXg0WE1ZaGFNdGdIdlBmTjcwbU9lK2x5bFZIZWd6YkpyT0lQN3lKR3NEaVQ1?=
 =?utf-8?B?Y2VNWXJWTWF0WHEzVDBZdnplUWdQNFBycWl5ZUtyL04zeUFUMko5SW4wS2Ni?=
 =?utf-8?B?clBVSldWdDd1YmNrMEJzTlBTREN4Z0tPVjA1anhIOVRrc0JJMG0yYTRqZWdD?=
 =?utf-8?B?VUFpR2doMGhWSEd2djc1dTNIdUNPTDhJeDZFYlpLa1VCUjgyZG8xQnhXaHh0?=
 =?utf-8?B?R3ZjbUhYVHVGRHd5bVFnV01LYnpMS3BKVWlibHVVWnZMRFFpLzZPUVJ4a0pL?=
 =?utf-8?Q?YlP3jCtmKPuOANddeUzdtsiYLEmUaF4tbiZOcpW3rBQz?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 199c2824-365e-45fa-ccd8-08daac537e17
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:13:02.6285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ly0shH944h2nUCfUMtNf4DR7lSkgBye+BRXpcyxPYHpfuTT0RmF8PDz5ViKfEx6Q8CFGRJXf1hBkvpciAOsPZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8456

On 12.10.2022 15:07, Henry Wang wrote:
> I thought to send my patch for fixing this issue tomorrow, but since you are
> sending...

Well, I was hoping to get something in before the day closes.

>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Subject: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to
>> fix build
>>
>> The backport didn't adapt to the earlier function prototype taking more
>> (unused here) arguments.
>>
>> Fixes: c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_op
>> for Arm")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Also applicable to 4.14 and 4.13.
>>
>> --- a/tools/libs/light/libxl_arm.c
>> +++ b/tools/libs/light/libxl_arm.c
>> @@ -136,7 +136,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
>>
> 
> The definition of shadow_mb should also be changed to unsigned long,
> and...
> 
>>      int r = xc_shadow_control(ctx->xch, domid,
>>                                XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
>> -                              &shadow_mb, 0);
>> +                              NULL, 0, &shadow_mb, 0, NULL);
>>      if (r) {
>>          LOGED(ERROR, domid,
>>                "Failed to set %u MiB shadow allocation", shadow_mb);
> 
> ...here should be %lu.

Oh, indeed. Why did I not pay attention when looking at the reverse x86
change in 4.16? Thanks for pointing out.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:14:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:14:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421160.666354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibYp-0003NC-NV; Wed, 12 Oct 2022 13:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421160.666354; Wed, 12 Oct 2022 13:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibYp-0003N5-Ku; Wed, 12 Oct 2022 13:14:11 +0000
Received: by outflank-mailman (input) for mailman id 421160;
 Wed, 12 Oct 2022 13:14:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oibYo-0003Mz-0x
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:14:10 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2045.outbound.protection.outlook.com [40.107.104.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c16a891b-4a2f-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 15:14:09 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8456.eurprd04.prod.outlook.com (2603:10a6:20b:3df::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 13:14:07 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 13:14:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c16a891b-4a2f-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ElJIi5bTV3sLomo6HwEE7wGiIXlMKCaBpBjcudOLzi+DejfsdMF3IKza7nrWiNNvy5RKS3h4dS5Z/IXGxb6tnMluIcLcDp5frwbmBY/2gzAy3m/s6yJI6sry11QAtOVcrXy/3M4gDdgI/4jEb1EMV95ayCB5cV8ZD+jzBKZkvx2Z0c453S26L/gZNY8GCXq8N7DeLZjw2JMfwoiKrB5iMUDuSKn4Zy39S/SkQ73EtOWRihkD1oj+nuKlPgUCn906nk6MElntk48GoMHafCnnVc8XS0T/2PSTGXzX2tnDcdoU7jW/WL/dKeYSbpPF8vnz/na2+O6IhONqSDm/jTNI7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/CHBNsqkoxu3QRtQarXnQNywHDbKb5AzSnkC0FMUZLk=;
 b=Y7bbhF+LDdIrNxx6wFiH7CazQbUf2Rhwbx2tG/yhDLpsUI1Eisnmd2jIwU05cZMiNl1+bnjzFs+V7+zMGGkAvr3TwgBscr7imfn5LGu5GnDzqiyCG7qD+l1tIl135f5GG/5977yrFlfhGCt9ggpnbUi9azWjwMebiuD9jUz8ZezZSqj070NbCeB2f4nOCvx1BVtg7lcj5qltQD9abJ9nsvYEFLCxL1PMqNufwlgNV48neXqD8s4nOdUZfRUzsnIcjBgFXssDyKgNdohUe4T4DL9eKw8Em8r420gep7YTmNrEKP1v/N+/YAw+s3N3O4ucDNNlg+lYR/xcoimG+L0rTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/CHBNsqkoxu3QRtQarXnQNywHDbKb5AzSnkC0FMUZLk=;
 b=srEUYPikHtz711XweOwUCPPcazGKPFH0SBaJut84dsyjYfXJqGD9WB2dmEObBiEz+bO2bjx9yMAWJmqGStgh+rEt26OBWqc015T/7IPCylzDmzvzlBRke3cKpsSLRkAF/F78yoANG0ZNHH7PID39wW6o3RCu12pEVvvTKBHLMDy5hOj5hQRTV+UNJoUkJCabFNPultZeRBbYmszGg9PvCDGyXxRNx7TzA+DZIp/EJ7oDM6lqOrypZXuZmbotEK8BQskCUdn9dozii4xaIjo3ndcj4cXlRbOajw4zxbm+a2/VahWXJH4xSTfKD7UhesOpst66ZyPinyn2QoR4MUW9gA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <af81d6d5-5d2b-3db8-634f-17392ef328f9@suse.com>
Date: Wed, 12 Oct 2022 15:14:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2][4.15] libxl/Arm: correct xc_shadow_control() invocation to
 fix build
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Anthony Perard <anthony.perard@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0009.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::22) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8456:EE_
X-MS-Office365-Filtering-Correlation-Id: 9710a03f-4dd2-4274-49d7-08daac53a500
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SPxxX5hLRnoBRF66vFnbx4QBR6HdfqnykmGMDSS/cWq7niFhL2SGtv8ra8v50Ffewk6hUwGpQZgqIZEK9P+Tcd85QF4qtKbUf36Z86r7CGslBlsDs7rvzfgW22u++nCI0UgnmlQF36iXiGq4ufkFsIBG1Cy8yxxeCssZCcozKajdu9j+jKXIFNHT/RyO5IrdC5sX13lTeU4yq0qvY2+ecCKjE/O7x7UNt3cTFfVsWdJmKRExfuqn1dIhLCcASbW25OaZTc3MttEWzQDNmWMYjI/ne8v/PFHXg3h/ER3TSSYtWmWVrljOtFriamvOTOLbji8sz98kDUdXAINtQKNWmHayrvljhSV2dxCcR/0EnG6AXhOMxgZiNyHVT71tMS/hryTkptsSjrIPDlb6XSPU1M0Aqg55OIjH24AnWmEPPbJPJFzeMOOOQMIxVnCs0zokR/hV2b97w4CdLXEHYdNgJUoVjnKviSyUCYygDFxop7MiROr/TmoUVKzFTSXeMLnQI3SeISOTuTJcEHwxTMYearCwQAKDmCeS9LWnVTKTe2ScdK2rhLtiTWdx0ymkaPhkTCm0CLsKWjxNA1fqX2Wa2zpaPEaPQXe1tI+NrystP4rKIKXYfRZG0rK0W5CAAIFRvmxytjYXtWvVL669JHfcdcv0Y8xlZwmtYd7GcUBRhEvDilUrwUdvKuwdp+tWaC3vRWE1WM8w5IqsnfgbxX+uy9oDiWlSUiijxAeRBWi+3NCSg10sSvnt9zOUKZsaMwewcnzL6ZJA33+GbTFvXIhmIVhgmZOxCJAnvYerabQD9YA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(376002)(396003)(346002)(136003)(366004)(451199015)(2906002)(316002)(8936002)(2616005)(6512007)(6916009)(54906003)(4326008)(8676002)(6506007)(86362001)(66476007)(66556008)(66946007)(36756003)(41300700001)(31696002)(4744005)(186003)(31686004)(5660300002)(6486002)(478600001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aW5MWndIWE9ubTIzK0xNc3p1WWF5d3ZJL3loRzhiRWIvZnc0dFZIdnV2VUNZ?=
 =?utf-8?B?RGhGcGVoOEhCalp0MXNzVFlDUEFLSDB3c3F4djJGUkZZYTU3UGwzUytUb0JB?=
 =?utf-8?B?VFA1RUpGbUFtMmhXejk5N3N2NFJUNnlibk5UTURyUWtvYWlMYm4zcm5zMHVo?=
 =?utf-8?B?WmVuWXBFK2JQbm5zMHVhdVplYVB5Q1RkMzM5NGV6TkdjZGcxZjVlY1lDNUlI?=
 =?utf-8?B?VURIK1hrVW9SU1ptM1BjVy8zbHVoOWcrSjlkTmdpT2pSNXN5RGNEd1BUVEpK?=
 =?utf-8?B?cVpMMVVmRmZSUzFRd0g2ZnFNa2NuOGxJNWVySS85dzBPME9UeEM4Mk1Vdm1w?=
 =?utf-8?B?aDh2aDhPZnd4bE13UERnTE5SRFdqdWgyNHIzNTJBT0hTanBkN3hRUGRkcEZj?=
 =?utf-8?B?aFYvcFNxUUdnUFcyL0JVS2JQZU9hTW5uRVptY0ZVaUE4TG5yOHZWRVRWSW13?=
 =?utf-8?B?dzk4NVdDV1lONko5V254Tm12QjZDR2ducmxmVHIyZFlFVGg1T21ERTVVWFRT?=
 =?utf-8?B?bCtYUVJ4cUhob2pXZ0o3NU9BNFordDRiMUhuNnpEN0NsL0s2Q1dHanFNaU5r?=
 =?utf-8?B?M3g5QW1uK2cwZzBQQ2M1MGpyaXozMjdTcUgrOGM2cjlTZjNocG1zZDZ5L2lr?=
 =?utf-8?B?T1NUTUgwckNxZHFIT1ZNTjFPZTc0YTRFdEVldmo0eWJMbTh1dy9MbHdJcmp0?=
 =?utf-8?B?VEdQTWpGY3BmRDRFd29VQ21hVitFNWJEYmhiSE0weVl3Zm1rMTdjUXdGVzFt?=
 =?utf-8?B?N0hjWHZzSGdMSm9SRjVJei9NamJ4NS9SaW4zY1NERy9NeC91KzRUUGN2SWNp?=
 =?utf-8?B?SzNoZWhYNlZ3cjNPb1BTMXRoT2NYckY4NXZJdkJlY2hJOHloS2R0Qm5tbjFR?=
 =?utf-8?B?T1Nsa0hDclpPdDRrY0JKU3RCRE5QbmZya1QzUXp6OUIxQ0JCd24zOVhHM2Rq?=
 =?utf-8?B?TTVENTk2L0VrbmhreEJySDJPenQyTE9NL2h1dW5QenRubHptZ3hoSTVyWk5V?=
 =?utf-8?B?ZzkvSDR0MnRqcEd0TDhoRDg4eUlQbVpZcmhsM2RLVGpGS0Zxa1dhSHdLTGxN?=
 =?utf-8?B?blc3VWxGSHUzWGdIaXRDZ0sxMXhWa2tBSWhFV3RmNGZ0RkE1ZVUwdjM3TWd6?=
 =?utf-8?B?TkVQTU1QVVJ6N1dqRmdQTFJYVTFxNFZ2QU5rbTh5WHhKa3B3VzR1djh2Z2pk?=
 =?utf-8?B?TkxwVEM3amxCZGZRWWpPNjRMUURxMGdpVXJpcWlxcXJNc1hvci9iZzgvakRQ?=
 =?utf-8?B?Z1VubXZrZ0U5ZTZ3UHU2Z2pNcTErYmtsZ0NFUE5YY2VZQ0ZqbVRjMHkzbWxx?=
 =?utf-8?B?RHlhSVZlL0lLeHZIUU9hVEJmNEhQN3N3ODd1OUpDV2l5Z3dmdSt0emh1R1c3?=
 =?utf-8?B?S3NhU1o4aTN2UzVVS2pGRE4wSW02TnVxSy96WmVxblEzdkNlRVVITE1ROU05?=
 =?utf-8?B?ZHlkM0x6VS92UktGVkNIeUtHMjY5ZldkbHJ5a1BpSFYvbis0ZXFTWWExTSs2?=
 =?utf-8?B?cVNsR0VYY2pCUWV1a3VkY1dxNDNEL05MWUJJdUFBckZaenl5c1Q4UVVJOEZL?=
 =?utf-8?B?NGsvRjM0aWRlMEdPV3NLVUFNYWdDcjZsZjhiKzRIZTRXTlRPK3FKTlBUQ3lz?=
 =?utf-8?B?NW9FNVhzd0NHd1dyc0pTb3RYOXFIeXBUQTY3a0lVQWNoNCtMRnROSDl2eUcy?=
 =?utf-8?B?MVEzQ0ZxY0UwNnpHaG0yT05Zck42alhNZzgva2I5M3hKdTNxYW56Qytwd1p5?=
 =?utf-8?B?WWhGYmJPZ2gvSTJEdG1hNTdTa0VFUDdMUFliWmJiWGRSQjZsV2Q4ZFA2Z3Jw?=
 =?utf-8?B?NXhjQmVSb2lLWU44NThwS0pjN250RnRTaVBkSEh1SmdaRHNwek1SRnNQQ05r?=
 =?utf-8?B?cFdqdTExc1ZnSkplSERtWndEUnQ5RDlWZzc1LzFRNjFNN1dDK1IvdlNsaFQx?=
 =?utf-8?B?eWtjVWRCTEk4U2hRYkdkaUpZVUhTSllpcDNqKzJJZUhUWUFuUlhEWlBON1Y4?=
 =?utf-8?B?Sll3aThKVEFoWHZmK2VGU1FpaGxCVWZMSVlEVjBnbXBoK3R1ZDVmZExBNVIy?=
 =?utf-8?B?VmxEVzdlczB0aS9TdlZFRjdVMjNyMUNneXJaMWV3TmI2dWhnMUgwbGJJQ1cx?=
 =?utf-8?B?bTlTZTFWV056TG12bHU2WXRqV2hNRjNIV2dXVml4SVUwT1VobUtqZEFLRnVG?=
 =?utf-8?Q?q9PwPdt20A+dWnPsXdmvx0f8kkIrVu/i4HtD1c1RnleO?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9710a03f-4dd2-4274-49d7-08daac53a500
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:14:07.8119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FGeLUF2ZuxWJ03K44popxXnaC/Ca1IU9Dn59VGT/5ejSP4YgqI1qajhk+4LWVkkixlpTQ4MFdkufdL78xqLUVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8456

The backport didn't adapt to the earlier function prototype taking more
(unused here) arguments.

Fixes: c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Also applicable to 4.14 and 4.13.
---
v2: Correct oversights.

--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -132,7 +132,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
                               uint32_t domid)
 {
     libxl_ctx *ctx = libxl__gc_owner(gc);
-    unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024);
+    unsigned long shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024);
 
     int r = xc_shadow_control(ctx->xch, domid,
                               XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
-                              &shadow_mb, 0);
+                              NULL, 0, &shadow_mb, 0, NULL);
     if (r) {
         LOGED(ERROR, domid,
-              "Failed to set %u MiB shadow allocation", shadow_mb);
+              "Failed to set %lu MiB shadow allocation", shadow_mb);
         return ERROR_FAIL;
     }
 


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:16:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:16:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421170.666366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibat-00048D-8B; Wed, 12 Oct 2022 13:16:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421170.666366; Wed, 12 Oct 2022 13:16:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibat-000486-5W; Wed, 12 Oct 2022 13:16:19 +0000
Received: by outflank-mailman (input) for mailman id 421170;
 Wed, 12 Oct 2022 13:16:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oibar-000480-W6
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:16:17 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0dc1da34-4a30-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 15:16:17 +0200 (CEST)
Received: from AM5PR0602CA0016.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::26) by AS8PR08MB8181.eurprd08.prod.outlook.com
 (2603:10a6:20b:54e::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 13:16:10 +0000
Received: from AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:a3:cafe::e4) by AM5PR0602CA0016.outlook.office365.com
 (2603:10a6:203:a3::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Wed, 12 Oct 2022 13:16:10 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT034.mail.protection.outlook.com (100.127.140.87) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 13:16:10 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Wed, 12 Oct 2022 13:16:10 +0000
Received: from ef9456e8fc61.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 56D3FC1B-A485-4875-B1D5-18134E17ACAA.1; 
 Wed, 12 Oct 2022 13:16:03 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef9456e8fc61.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 13:16:03 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB9439.eurprd08.prod.outlook.com (2603:10a6:10:42d::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Wed, 12 Oct
 2022 13:16:01 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 13:16:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0dc1da34-4a30-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=C6KCvZldk1Eo0kJF6+XzZ2LBXGq1XwYWJaP9Vy0+5UdB/QuTPBRr7G+hRrsTlWh3cvy/UfI57JNr8LqLnucf5nlEnvGIujkIlqAfT9WcAp65OlFKfH3SuBgxog6j/wqfCufMUwBLqIG1WK9N6MYSuHtldxbtIOPXUQse31KwUR+vpJJpbnPxQL2jj8e23fVkc6o4IFnkn03O+OORfcYtXFcaAQh2+Tpunr4E85axorRn7na7qY6Yh7cLtsVpcip17TaL6dnujkSYgkh8+lvDzsfLCyTLEF7j4AoD3MR7B6AiwGTt2jSUzQS6+Ktuom0C/uDwM1zAV/5O12rjKH6oVw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=coVUI+OovziYU9f2aKGAN07Z7YqMva50yfqK3aKrFMo=;
 b=YvGfmOWQrn+7vfExHUqAoEsUHjC09DZBOt8uJuBe7HL51n+Nz0h2rDorRYSTrkLfqvoj3kVzac6+6kY/yNwMHbnb0geFYvDZlPx3TnTWqMNk54SXKJatA/3TdlPFUZXt788prstmb7W0kYmLVNfn+Wti8KsM2ORHa3jQOD0vjp0gUpohbWrKE+A0vE4lcM7usawkbo8FgQFwNqQ/h1v3NDL8jnkfl5TnnEb9xOBTykTtw+xhlL+M7QYnG3yrwrpEyXakocXHM2zHVbks7hYtHE65fyq4hxqv/ulBFHxi+WIBdsGprsIutBg7SiYfBnF3MloMdxjBCFexx8j/rCT0tw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=coVUI+OovziYU9f2aKGAN07Z7YqMva50yfqK3aKrFMo=;
 b=D+e9DzzCN9NWkCWbGc+lAL1BJoGiubEar/fktcg/Z8F8ZdB41JEPefY0bZQzf103KED4gXyuSh5dZDfAIBeZuyEyVPWL7E3M5n8h0ukCujNJ8jAJPJE6DrYFLoJRrVloXszHAXKk4BrtuP8I6xmBv3br6GMv02HuFqIHcq07+dg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f4OrZBi5/KWk+/qjROv8/3hxyOPUJNLKuSPXYaj55F7WTE0K238rseIW5lJTAz2LmdSqHvTGfh26AL54uk8dZVfg/J353QI9AvXmuZyFjExnxWhvLBqeF/ZsnRKeIoMaHKcO1ElyCRjtvheswTaAmeR2jcyM8mEriVWC3FCj2tk/pGamAzPzlbmBkDA8trVjduOK9li7XDRx4xid2/VA7pQvxn+oAj285FrgfglgxuE/X7buazqcelBaKosnBwRiHWw0QrXL3IgpkQM9WsYyKYqd4CEZ+GGAs6LzXmfnxLrgCoCqRKWtapTzTFK4qGI+6zzg8iwf0zT0+WShY/uP+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=coVUI+OovziYU9f2aKGAN07Z7YqMva50yfqK3aKrFMo=;
 b=fF00BIqf2xLsGVhGRSsQgET/cOybmvhkKe/nfJwwniugdSNL1+ywaWB/zgETaE7dJIEWqSlEl8l6cloA0ONgd03cc5bGuxL5Uuz9jlOKN7ac0RqDN4NzdMX2DBwuFOuZ6gDe/ZnVcrnMfB5GIpp2SHyXjz8ryAtL9sQJC8bQxDxbSKAI7GA9KMgRMR/6YCTM08ZmAi/O9bI1V9DKenbMkpLM5GER/IZ0r6UR0LWxwbzSH7U9wwlUDH88L4dTb8suqkHTIRRw7DGx7eFXszlp18dAAgxDldqiVftS0EV2xEJSYV/dNH1wLYllmI0FisZuvWSOU9tqelcAMr162Ttd9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=coVUI+OovziYU9f2aKGAN07Z7YqMva50yfqK3aKrFMo=;
 b=D+e9DzzCN9NWkCWbGc+lAL1BJoGiubEar/fktcg/Z8F8ZdB41JEPefY0bZQzf103KED4gXyuSh5dZDfAIBeZuyEyVPWL7E3M5n8h0ukCujNJ8jAJPJE6DrYFLoJRrVloXszHAXKk4BrtuP8I6xmBv3br6GMv02HuFqIHcq07+dg=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation
 to fix build
Thread-Topic: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation
 to fix build
Thread-Index: AQHY3jtPuivbdxpwvESMJg2+jrcZsa4KukrggAAB8wCAAAA4YA==
Date: Wed, 12 Oct 2022 13:16:01 +0000
Message-ID:
 <AS8PR08MB7991974EDF0C5895E6DB6B9992229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <805d66fe-e116-254f-015a-59a760639653@suse.com>
 <AS8PR08MB7991025777286F904D3FB6F192229@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <c0b2e0b1-f5bb-e75a-dfc1-60eb7006cbf3@suse.com>
In-Reply-To: <c0b2e0b1-f5bb-e75a-dfc1-60eb7006cbf3@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 74CF9523D5DF204E9764D8945E49E9B5.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB9439:EE_|AM7EUR03FT034:EE_|AS8PR08MB8181:EE_
X-MS-Office365-Filtering-Correlation-Id: 50ffa9ae-d368-453e-af83-08daac53ee2e
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wrG6caUkjwM0jszeU06waCqNxEBhvLbNAkFxcDLxTdM3Z429cJC0yyLE1hiVCJm00PVA1/A9y9+qFUx4C3fYYurF+F/x4yPNAM0JMJASoBGTmcs6JF3cotU/DCck++hfthePzAs/ZM5YctOMKTNDElGIpbPl0d/J+N/wNni2lgD4urx/vbt2zSI9VyHhE6zIC1M07pDxEeZ51YT8JRDlBOYMVAF+ivI6+THBJSkdG91MLQUpQpSLQ6/5DUZEK6sXyzJ3hfWAvluWPmkh+aqJ7+CSAqN6h573WQ4Nki//KhKNydyINiZr+4evPAodX/uSzsh55qATqpWzYLtnyS3R+pRVSTL9u5jlhbe/uD0bH6EoE6C5Kz6Hsl4cJnnXw7McP+gx7/l4STVayPIQvYwmbwIfxesy6NQSM49bC9mZ18IlQ8DTBr36aoteMR8V97GRhz3hBjbAC2obgu0AvMpZtVB5/0OnTvc7KzYpyYNUe2oV2Wn7CYyz/SPlnTcOdv5fW/iGlT01K2O7gHE9HKe8qxG/DekPV6vI4cd1w38Ci2oWsTLq3ULjOoP7OfzZt1UgI+v36k2Vf2z4kAxUf52ieaLVhyJNDa3kVdIxhWpv7OlexoKtjWxELN26Leb7nXgpfAz+lZaGay02A413KMOngOtZ4D1lefM98XFrtF7VtIkthuOUgKRhzl2fl9pFXnXC9+3QMUjt9E54Jo5KhTMD6UUFc/WbtxTqHZYPuHHCLjWv9J9G2+FxvOUxkI4d/8FW1xbfppz+2WzXagiXmzQESg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(53546011)(478600001)(2906002)(316002)(122000001)(64756008)(8936002)(38100700002)(6916009)(66476007)(33656002)(4326008)(41300700001)(52536014)(66446008)(66556008)(76116006)(38070700005)(5660300002)(54906003)(8676002)(66946007)(71200400001)(186003)(9686003)(6506007)(83380400001)(7696005)(86362001)(55016003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9439
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	37637d4f-68b3-4dae-928a-08daac53e898
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c0Ez6y/wQiVciykFkUqXqJAqynasp4XjvaG395BGKwGid/IPPk34cJAz67pWuAyvvKJ1zcJw4Tw9IfMSp6T8/s3/GU5/sJRAlkuAKvR0eJ7si9o/eH/CkuSoa6PpkLBhAFFVgHQgAP67nQGgLSACXLyGSQP64DIjGdMsCDO0y4aRlOMejNVW3cE7Q29t5+yH+BmoZ4005UtM/4z7o78CXCwJ3MhlmWsbIp9BNMBzbndCtN6gzgdtzgp1YLJX95PyVkvweqmk54azS0llY0Wrzx95nb/Pxv8KnriZ8Z4W4T51hMWVCF1qR9rQjGa2ZHZ434CuT/rkO98QNrr8+cY9lDEHyzZBKLGyL89LYiQgjy8twFuuHYWSYItKvxO3oBOXDEjVOAyDXCEHzC5XlVhzfj5strt0nKkoSITspc55827IauTENhojvBedKg6tWPKu5NVrGwBgtnFr5aAHvgttYvi8q1YP+Oc32DJWVTJbfBJ5OqEDFgzgUWTBScinjE7BM0P7hFZdOQEDL//WzbQQAmlGC6J9nMaG1fsR5Zlt//Hi5As64lWGAmC9bBJev+yYxo75qia/ad5LnxtPqwxWNB7rbeTvbA1opSzNlu5iMYroxbBPGHmnq2Tz+1xcVGHjc6FcD2mRgN55XeTtoHQfRyeSyXiIvg91xx0IDumb3Ak67TSzCf+Ja5SSI7BmT7AYeMc2HVhxXsL6UULbo3OnDw9GbNsZ87wDP1sK2xfImoSZU/FiynOgjyqp8+rbSje13syLnnXNPgRw+0yOhh5kdg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(86362001)(81166007)(356005)(36860700001)(82740400003)(33656002)(336012)(83380400001)(55016003)(40480700001)(40460700003)(53546011)(2906002)(478600001)(26005)(7696005)(9686003)(6506007)(186003)(8676002)(8936002)(47076005)(70206006)(70586007)(82310400005)(316002)(54906003)(4326008)(5660300002)(41300700001)(6862004)(52536014);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:16:10.4021
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 50ffa9ae-d368-453e-af83-08daac53ee2e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8181

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF1bNC4xNV0gbGli
eGwvQXJtOiBjb3JyZWN0IHhjX3NoYWRvd19jb250cm9sKCkgaW52b2NhdGlvbg0KPiB0byBmaXgg
YnVpbGQNCj4gDQo+IE9uIDEyLjEwLjIwMjIgMTU6MDcsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4g
SSB0aG91Z2h0IHRvIHNlbmQgbXkgcGF0Y2ggZm9yIGZpeGluZyB0aGlzIGlzc3VlIHRvbW9ycm93
LCBidXQgc2luY2UgeW91IGFyZQ0KPiA+IHNlbmRpbmcuLi4NCj4gDQo+IFdlbGwsIEkgd2FzIGhv
cGluZyB0byBnZXQgc29tZXRoaW5nIGluIGJlZm9yZSB0aGUgZGF5IGNsb3Nlcy4NCg0KTm9ubyBJ
IHdhcyBub3QgY29tcGxhaW5pbmcsIHNvcnJ5IGZvciBtaXN1bmRlcnN0YW5kaW5nLiBBY3R1YWxs
eSB0aGFua3MgZm9yIHlvdXINCmVmZm9ydCBoZXJlLg0KDQo+IA0KPiA+PiAtLS0gYS90b29scy9s
aWJzL2xpZ2h0L2xpYnhsX2FybS5jDQo+ID4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf
YXJtLmMNCj4gPj4gQEAgLTEzNiw3ICsxMzYsNyBAQCBpbnQgbGlieGxfX2FyY2hfZG9tYWluX2Ny
ZWF0ZShsaWJ4bF9fZ2MgKmdjLA0KPiA+Pg0KPiA+DQo+ID4gVGhlIGRlZmluaXRpb24gb2Ygc2hh
ZG93X21iIHNob3VsZCBhbHNvIGJlIGNoYW5nZWQgdG8gdW5zaWduZWQgbG9uZywNCj4gPiBhbmQu
Li4NCj4gPg0KPiA+PiAgICAgIGludCByID0geGNfc2hhZG93X2NvbnRyb2woY3R4LT54Y2gsIGRv
bWlkLA0KPiA+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVOX0RPTUNUTF9TSEFE
T1dfT1BfU0VUX0FMTE9DQVRJT04sDQo+ID4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAmc2hhZG93X21iLCAwKTsNCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5V
TEwsIDAsICZzaGFkb3dfbWIsIDAsIE5VTEwpOw0KPiA+PiAgICAgIGlmIChyKSB7DQo+ID4+ICAg
ICAgICAgIExPR0VEKEVSUk9SLCBkb21pZCwNCj4gPj4gICAgICAgICAgICAgICAgIkZhaWxlZCB0
byBzZXQgJXUgTWlCIHNoYWRvdyBhbGxvY2F0aW9uIiwgc2hhZG93X21iKTsNCj4gPg0KPiA+IC4u
LmhlcmUgc2hvdWxkIGJlICVsdS4NCj4gDQo+IE9oLCBpbmRlZWQuIFdoeSBkaWQgSSBub3QgcGF5
IGF0dGVudGlvbiB3aGVuIGxvb2tpbmcgYXQgdGhlIHJldmVyc2UgeDg2DQo+IGNoYW5nZSBpbiA0
LjE2PyBUaGFua3MgZm9yIHBvaW50aW5nIG91dC4NCg0KV2VsbCBJIG1hZGUgdGhlIGV4YWN0IHNh
bWUgbWlzdGFrZSBoZXJlIGJlZm9yZSBJIGRpZCBteSBsb2NhbCB0ZXN0aW5nIHNvIEkNCnRoaW5r
IHRoaXMgaXMgcXVpdGUgZWFzeSB0byBpZ25vcmUgOikpKQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5y
eQ0KDQo+IA0KPiBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421175.666377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibbg-0004hE-I5; Wed, 12 Oct 2022 13:17:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421175.666377; Wed, 12 Oct 2022 13:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oibbg-0004h5-En; Wed, 12 Oct 2022 13:17:08 +0000
Received: by outflank-mailman (input) for mailman id 421175;
 Wed, 12 Oct 2022 13:17:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TAAv=2N=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oibbf-0004R6-MH
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:17:07 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2083.outbound.protection.outlook.com [40.107.22.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2afc641e-4a30-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 15:17:06 +0200 (CEST)
Received: from AM6P192CA0009.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::22)
 by AS8PR08MB9017.eurprd08.prod.outlook.com (2603:10a6:20b:5b1::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 13:16:59 +0000
Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:83:cafe::2a) by AM6P192CA0009.outlook.office365.com
 (2603:10a6:209:83::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Wed, 12 Oct 2022 13:16:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 13:16:58 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Wed, 12 Oct 2022 13:16:57 +0000
Received: from 61d9815d83af.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2761C29D-6DE8-460C-85C3-B31BEFDA1099.1; 
 Wed, 12 Oct 2022 13:16:52 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 61d9815d83af.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 13:16:52 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PAXPR08MB6624.eurprd08.prod.outlook.com (2603:10a6:102:dd::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct
 2022 13:16:47 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022
 13:16:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2afc641e-4a30-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=PbLvPxiv437oXziVxk+RGyEzKQXlDBNHtuUahDFTVPPS7u/Iib6PzocUjSRpYec4BiSwfq3Nlux4UIkBYdSPxpFN1vsFZjFLrUWvLZifSq2v45CWB3rEMAAzyO1Lc5oGDg2V5nqBMYui9m4AGvDeH4WBiSl7zXa36/uBSG6HAncy1IPnLrIToHiMnBJSmD2qj1YNDnmvaBiw2wk83EMxAWJN7sxEvvCcwedxV0BPuTM22bfQE8QmwyILiAysEnELTjBzCuUj/nHopKNjDRje7cfJca0DIqJ0kW6DZu47ogZUK0NyN4KwbYe4AqCRuluIj/MyhI0mOJDKXbblXUSTNw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ey/tiq3ryzq0B4YzFNq3KzGVSZxgfTzgiz74Mho5XZo=;
 b=aiTOg2037SB/q3sJW+pYDsYZW2T+xdqvqpay98Ut2ksSc06FEBF9CY+Y6iEpkDN7n74rDwRFaqjEgyvwlXs7aE/2jrhRe+U8mdkwJVNMlkuJgKvhmxN4/aBn7bu7+zxke9YvsyBMc03CnL95kBva3GTZu6lgru4rLnx1Udibo+x+oUqFIWMivrS9zyQN7ChqpVfPOhbZzqyYk7D2wzTHQqx7sOu6YLRikZTeomq2rngu4gEGHZ9rrM48H5sG7sZfb9+HYijRWBzv47gvmMRlHh1P8XtdYalAmXwWEcWQzWBgky++yxgFa6nGAiJg0AcVTAjH/Q4IFQnLSkGKGB3wwg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ey/tiq3ryzq0B4YzFNq3KzGVSZxgfTzgiz74Mho5XZo=;
 b=oL8tba/ERZ3szX89Z+34Dk7s3vAMFAp20nuDcPLt8bhgsoZ8IismyDpu/SBesUz5FO8MBdj/CginXkHoBxT88TI8QESywH7Kz06b7K90JUUp9DSyuNS5j31ty8QTgOdIN+IQtStpsxu/yIxnf6hxEwBXUnLgWCDagDOc/IPUFhU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a64eMV9MiezgWYm2Fb/tSyMIN+pTMgWFrAYtTmQFulUwU6xcptOnUaaimCRG/HYzHf5mVWJ545iTgj062p1CeBd3Jprdpu8WOoaFdMtr/lj1AjKs01c0RVOslp96Pn0MoJu64/ThQsirfKLN5sZsv0fCNfY1cvpY9J6CzztGsFGrrP+pR+SvVTzMQvSOiJd3op6A5VI8kjAzdS+tnMBBIXNAMw4Ql9xUS4ePnDvcnFZRhs2GvqwiNZFQKsa87KK+FSzcbzfraOpP5Ljbpl1Nyy8cwv0IDoiNENIAYjK+VGzVtyoEDWE4Sd2N8dtGOhTILOeWjqAzQbERMq7xa97QeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ey/tiq3ryzq0B4YzFNq3KzGVSZxgfTzgiz74Mho5XZo=;
 b=MW7ZQEAPFP5vDQI/uZPX6GeynpWMC/m5M++msAG2xKAi47Sp3WLfj32JIl+SyN8SKVDSg+pb3NlfVA4cm26YCQ6hp/5bi3ft0TFxcYGb95Wee/Wpw+e0JTO+Inf3wVDkYoVzGOMCCvEtRBVFvtpiu5qMp/XnFbzsobcyaTqAP8t4lCirZs5zm34DVroXU474us1/XqgO8HCIKFjonEnTJCaqvqHEjdp1S+3nZNLL+bjcJqO5ir4q/Zw+ObyB/AiQwc2a/F50aEDKZGJz85mcR2PQi0EWSGm22X8mfHl4YVY6qhi4O2iVZAV6nY/NJugvYWinxnJJprrpslETeVdkog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ey/tiq3ryzq0B4YzFNq3KzGVSZxgfTzgiz74Mho5XZo=;
 b=oL8tba/ERZ3szX89Z+34Dk7s3vAMFAp20nuDcPLt8bhgsoZ8IismyDpu/SBesUz5FO8MBdj/CginXkHoBxT88TI8QESywH7Kz06b7K90JUUp9DSyuNS5j31ty8QTgOdIN+IQtStpsxu/yIxnf6hxEwBXUnLgWCDagDOc/IPUFhU=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <julien@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: RE: [PATCH v2][4.15] libxl/Arm: correct xc_shadow_control()
 invocation to fix build
Thread-Topic: [PATCH v2][4.15] libxl/Arm: correct xc_shadow_control()
 invocation to fix build
Thread-Index: AQHY3jyGWQFzc6aKeEmXpDlYlShzFq4KvTJw
Date: Wed, 12 Oct 2022 13:16:47 +0000
Message-ID:
 <AS8PR08MB79910144ACE4842C43A205C392229@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <af81d6d5-5d2b-3db8-634f-17392ef328f9@suse.com>
In-Reply-To: <af81d6d5-5d2b-3db8-634f-17392ef328f9@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: C1AEA40DD7187949BE621A0FE1B08CC0.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PAXPR08MB6624:EE_|VE1EUR03FT059:EE_|AS8PR08MB9017:EE_
X-MS-Office365-Filtering-Correlation-Id: bf4be2ea-4919-4278-a3b1-08daac540ac5
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FRDtcrsT1W0qQlW/WafC3NQyoxyHhX6Qr01Pb+tR8tT2XY9kiLWI13uxL8biMV2EwjDQcih9C9FWe1h+mUGhuPjPwWuduFuPxZbzLcdG9b6Jp+Cmu+BHd88hJn494B/x4nIH0KFbwgVTBJf1ilRgNeJrGKXTCgfRNu7NrDa4Q4Brmth7TmrXx19n4lU7+V1thIYF2oolCOMqq04Sq6Iq1uETOJgKuUhL77vONZLmCR95cvUnNE5nnZSANe8Z47vA9WNao9YVEtxwm9wrGeFbyeQoWox7SuDTcFrg4Ko38EcixinKDgjjNPv4Z7dtKdE5BlMMuqm5jZ8M/xin6HlbSZ6q0TbW/ekHAuRfLNDsx4xRbf0pJskeWPct6MWJ3zCRKcQ1j47VT9kxk44aM8j13BYP3QGYC6+cxigHDkGdSQRpUNnUR+CNmNnXAIFuk492s1Dse4eQIN7VllEcpheuJHEEro6+Nlrfj078wpnnremT+bIcqYq+v2qTgnc32h6FPHHKuUK+W3wrJQDwMSNo4waOncq14egyPCsmQ1AgS6hZMmxggPziU5qrSCkjBP2o0NDzkfprVT+pd3aXbbFoBSSrqhkAhp3v1Uk6an7hMmWGOj1UoPX2gWDTkyFLfKehrjPsxBX+Nh3IZreh7EDI1tAe0GtjMfi+9uiSooYePBbQw3uGxCBofwhpQql0EWAJu0YgJuNC9whFVik8SlxqmdCQjOvLgKpWRNNR7kti+cgvQ2T7VL/gRT+zDl9hyXgCsE+90SF/CCqOCuFWKpPA4Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199015)(55016003)(33656002)(76116006)(6506007)(9686003)(7696005)(122000001)(110136005)(71200400001)(66946007)(66556008)(66476007)(66446008)(64756008)(478600001)(8676002)(4326008)(38100700002)(86362001)(38070700005)(52536014)(186003)(83380400001)(5660300002)(4744005)(8936002)(41300700001)(2906002)(316002)(54906003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6624
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bd256f28-c0c5-4963-b63b-08daac54043a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FHxMO9bpfKd4XBr+k8BVxXpQnCjHRRfHAvTnx2W+sZIOwmBx0zzK1IGqzn0gL6Y1xJ8MbNMN7D3p1jCSAsFF+2znFCIrsCxKTYvCgoUo6vhEqh6wMCrs/sTaGqNQEJEsO1o5MxRBEtYf6fy6czGHLFyFsiY9uZmUrd2Z9uDAQ5gy4eVDPdpTCxj64kIwxkoy4O7heYHxCveN7nHY8PqcJXE/GRNs9On5ItKKkuFM/LgzEj+UqgIdjG85cRWIvLLPOWxm/C9LwLTn7urEdjms3OMId/3mw/9mDfVUCdtrm27UkJrnwPOqYxmc8L545kGTr8A/h1uFIUFfFiSw5m4j5eTgZBJiEH8Fk+Vms2fiXlahd/xN5nPfHj3XoUK44t8M1qO+cjoRRWuiHo+wmE+Bn889QnoKtKdJirNLs8Lxeq/MdVRIkhsTGk7L7fW4owpUqxX+SE4Cyhsw+hY9wozFkUs9nuchTk9HHAwAq5D+X+ZGpgnvurUReNOBLa6q2Hpk0rQel3O/ZsZqXI5Io7dqHnZNaOcq3bqS6OTcCxpbAnRZ5L0nzPSeVqaYwZmsBt+4Sk4cD4L1o7cpE5BY9cFfgBCc4bC0idQURxplC+sGKxpIG3qQwRSbyBV96Xm1+UrJ0EyhDLEeVWiS1W4feG2wm5NNDlYp5ejaVnGwbMVkeVa7ZdBtbNo4Y6fYbgaVG/q34A8tITnTKVYi3J81QJeF6nL54LQujJ3jGzMB6cfGfKhPyCNbZw24guq+Tmn3b/3EWo4LR6tNE1/SS9dqIVibyA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(52536014)(336012)(83380400001)(316002)(478600001)(107886003)(54906003)(41300700001)(110136005)(33656002)(47076005)(40480700001)(82740400003)(82310400005)(356005)(186003)(81166007)(2906002)(40460700003)(86362001)(36860700001)(4744005)(5660300002)(55016003)(8936002)(70206006)(9686003)(7696005)(70586007)(26005)(8676002)(6506007)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:16:58.3143
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bf4be2ea-4919-4278-a3b1-08daac540ac5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9017

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIHYyXVs0LjE1XSBsaWJ4
bC9Bcm06IGNvcnJlY3QgeGNfc2hhZG93X2NvbnRyb2woKSBpbnZvY2F0aW9uDQo+IHRvIGZpeCBi
dWlsZA0KPiANCj4gVGhlIGJhY2twb3J0IGRpZG4ndCBhZGFwdCB0byB0aGUgZWFybGllciBmdW5j
dGlvbiBwcm90b3R5cGUgdGFraW5nIG1vcmUNCj4gKHVudXNlZCBoZXJlKSBhcmd1bWVudHMuDQo+
IA0KPiBGaXhlczogYzUyMTUwNDQ1NzhlICgieGVuL2FybSwgbGlieGw6IEltcGxlbWVudCBYRU5f
RE9NQ1RMX3NoYWRvd19vcA0KPiBmb3IgQXJtIikNCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogSGVucnkgV2FuZyA8SGVucnku
V2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KIA0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:46:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:46:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421185.666388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oic48-0008HQ-R2; Wed, 12 Oct 2022 13:46:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421185.666388; Wed, 12 Oct 2022 13:46:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oic48-0008HJ-Ne; Wed, 12 Oct 2022 13:46:32 +0000
Received: by outflank-mailman (input) for mailman id 421185;
 Wed, 12 Oct 2022 13:46:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zIvO=2N=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oic47-0008HD-6s
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 13:46:31 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70074.outbound.protection.outlook.com [40.107.7.74])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46567ca5-4a34-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 15:46:30 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8581.eurprd04.prod.outlook.com (2603:10a6:10:2d8::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Wed, 12 Oct
 2022 13:46:27 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022
 13:46:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46567ca5-4a34-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lO7Cc5MWsbaEKan4P6F5d51QXMuj0DS9Psf95qeNzPG1uazTXtBmwqCnqyRxQgUzdFRaJR9HTpJVpUTbLEDj/I77j33k69p1DdWqXVc4+BpIj4Oc7GyVRRP5TsPUBF6XLhitpyGw3I4/sYz1KWjI2977yxCwL/isJdn5MzPcldcypQRO10O2b1zdiiJNvGCyDu50bgljOA5nAqp0YJFh9XHwoIocVXgA4VfiSgu07kVAmdblkogb4GCh0/EdsSyUKSt5qhAADnKNHiMUOOD7Hy2uRyofU6HXi8eTyIParhVyrBEskpD/yNiSPEQcTiO8vrlzgN8JgiXImnpOiu08zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6QiShWwjdzjchzvdOjo90MiNbU72PRGGkQNLl+VmQa0=;
 b=QqtXRsoFkEeSAjWy5piIlgjS5qPfz7SeaKtplQzgRaC0srGl74dyeOafvXoR3SUugSHTBRd48JiGWVhMHXxOSsh1oGPgGe/ytpaTIgMssXe4p0PM+W6vmUDeDqxuWfbGCi/0dHP8jLq9cSE2aqw7ydjZuom+Lrgr0VhclqTdwrQz7pL3Z1s9rDPswI1FeNfQSU/uR0pJPGtoRM5U+4taNtVj60nqlXV0Cksd/PBEOkQRzvpDKdbiEbahNQy35CNQ4OaOYy/Nz2gOaZ4to02EtEu6DHJxq9SWgmNpmPPjdb2b08ZDp2Slmqg0ngrH0OeAHEcmqvjhlqmtVWH9EZk2TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6QiShWwjdzjchzvdOjo90MiNbU72PRGGkQNLl+VmQa0=;
 b=R64yx17vxUplx4Sr4NpF5y39c3Nc6rtsWYW5DbpHedQfbukSfdYWRMGPiLJIj/abtkIOHthE9sx8ts62TPWNG7pRFd4rBIsLnbiSAibXcJJlksFtGW77kIxNlTI0s2tL3Synx1b6wE2v2mrtOonNSekLh+2/QZSgjJMpAX5ThJ0O9zLap/4KJImsdrFS68cjfSOxoiCfbkqRejgTqiGjyWRTka0Ye/KdxCkHlx2DbXudx32qpueBaTv8BqiPbGErfxBLUN50m9QbV0zl0QzzrjBAAYyrLROFs+me8oco5veiTLEydWM0op2PrEXWZjz0JZFuPd548dLmnjftfJOovA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a7eb93d7-1921-c847-1b76-a0b5454b8cef@suse.com>
Date: Wed, 12 Oct 2022 15:46:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v3 1/5] x86/mwait-idle: add 'preferred-cstates' command
 line option
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <0690742b-21c8-e5b6-e8ff-5d4709e0c3ee@suse.com>
 <Y0WYM/trMDVja61r@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0WYM/trMDVja61r@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::22) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8581:EE_
X-MS-Office365-Filtering-Correlation-Id: b99d5c0f-0a6e-4cd2-ce9c-08daac5828b0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	S8TbnCDjP+afQ8ZkjccYwlsl9az+04GXR+XCC584wiakLhaZvc4IgoP0LI8BRBXhJin98lR3S36XEdqxp/TfxL14a2i3/uEqgEY0lCowWD3CmeMlodAki5uhwTXSgjLBHFw7SMb+86HzIY3J/cy7mLQs5UkKYEzrPsmWidvkiFyb6uRqSmSuO4Pe2rk7oUwZvy9v2bnLCPpMmepaLFtGEYW8TtH63a2ncPmzjyymdwjTWSVvU+MFgKNdowaKH7GbrUkTkpvKqdGVs7f15tJd9UNLrHDIgtr/oPdfEzWXiqHvWiUgaMutRUcj1lZKm4zSz/9iaZq6q2E/Qo0z7t+2UI3Q952ecBE8KXSyrRxzNxdCi8OfwMHCV+pse3p7KToNwwekhExL+VHQ0hXjyZjgamHzdvOyEvKPQZdtz5bJOZrjhBHxrJElw0QUQJmXLYgWXou34dGgcwQ4ZAXw8VWSl1m4HU8KUAASxO6DFXuYoYE5z5ql/VFv9NB31zst+393atsCkzQgNuNd0B6CdIX+Ws4DLm5rGAu1zxj81ZtJ7zaCanAxq/vCvLbtcPwArkKeGIa1N75B3gDx4Fa5WjUzXR4s6NehgctwQxUughN7uS+wx295B7U3Lb4qmdxp8BulUlWhYpxArS9+pnDIaixDNPKf9ManX5Qh04EKGvFtlohSKMa13F77U5wFiSuo5q0gXYy77ardXkeHF7yMfv9e46o86DYbeljBFx5ShAn02I/5WF2EWEkpa4yOjGSCsb/M2STZKDX1LIqDWKWrkuTR59QqE9+uJEqrlyLX1atW2TU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199015)(36756003)(31686004)(31696002)(86362001)(5660300002)(38100700002)(186003)(2616005)(2906002)(6506007)(478600001)(6512007)(66476007)(66946007)(8676002)(53546011)(6916009)(316002)(66556008)(8936002)(4326008)(6486002)(41300700001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZS9SZjNaNlFET0VmRGs3UGI4SDYxaWQ1K3NFSDN1MktXbW92L3NpdERWZkFt?=
 =?utf-8?B?bUZ0TnRaQTVBNXRrM3pyYUJvdDBqNTR3UkJaTitlY0lYTm91cGJmV3E4RUZ2?=
 =?utf-8?B?bm4wdnI0RWVQa3lRNktVczdia3ZaR1RWQmljZUU1YVZmZkxXTGRDZlI2YVJB?=
 =?utf-8?B?Rk10SURtVUxSTTF5T2VlTXF6VzhWVTVsRDFRZGlNcEVHQlBsM3dkaXVsNWQ3?=
 =?utf-8?B?N0pjV3dnMlBncnZRc2RYYW9nSWFQWWR1ZjZWLzZ5SXpKdmZXQm9yRk5UbUJ5?=
 =?utf-8?B?a0Q3TlNCMisxR1d4cWlVS2tzWDA4NHJmNTFrUDNmNExHc3RLSW5ZV1E4enVr?=
 =?utf-8?B?QXRieDc3VmVvTVN1RVBLR0Z4UTYyTXpkTndYUzltRUE1OXFtNVZhVitDa3Rr?=
 =?utf-8?B?c2xsaFowbUhOcE9tVFJhcGw2dFNGRElCNnVGZ0xFL1diOTIzQWZ0K04vQWVH?=
 =?utf-8?B?UGdjQ2o4YVpFbXZKRkNlSGlGOXEyME1tTVVPRmJ2N0dyRmY3Qi84dERYejUx?=
 =?utf-8?B?N0prZDdQdkJBSmI3aXY3OFIwNWQyQ21WdWp4T1loY1pwZjYrUTJFTkpPNldN?=
 =?utf-8?B?KzhmSXdOM2d0aS9NdHlvN3dXSFFBaXEwVjF3K0NIWjV2YmRCRXU5YzdUaVph?=
 =?utf-8?B?M1J4L2pqbE1YcFNaZXluVHlkRVVCRzJOQldNNnh5M2M0WEdQVDJLenIvSXdU?=
 =?utf-8?B?ZFdHc2tuYzJRdkhyZ3o3TEVjUTY2WngyVk1wWUtId2ZJcW5YbHJYUXpudzRl?=
 =?utf-8?B?MHg3ZTIrR0hWZ2lhWHFkV2lvZnZGSk9DN3hEZGkwU2kzaFRJV2YraytqV1pR?=
 =?utf-8?B?U25rTW43OWJHQm5hbUR2QkxDVnNDeWFOYnMxWWFoN1V4VS9Ob21tZVdndGg2?=
 =?utf-8?B?Z1NFTGRCclpTWm1GeGVhVkZIQU44eHIydWtJUzg5bmZFS3JvOVljS1MxV0dw?=
 =?utf-8?B?aGNqRWwvd25NNjZHMEpkRldGNVIvYzhicjhEcVVaVzRlL1lhOWU0ekdGakw4?=
 =?utf-8?B?ZnpKa1g2UmRnQkh1RUNLQW5Md1Q4ZTBqbkpkMU5uSDBSTXVrZFJjM2g5QjNK?=
 =?utf-8?B?aUVFR1MwYTljRjF0OW1ZbUJiN2I2MFNCRjQ4K3A4Q3RTT1ZCMVNvcGF0cGtX?=
 =?utf-8?B?dWJzcW82SXVpMGhkZTlxbkpqbDVYdDlBR0grVzZ4eDRTTVNFQmRROTFsUVFT?=
 =?utf-8?B?dFZNN000VFkrRDBUa0F5NHczR1NoNVpZaVpCZG9hSWRRTjNyT2FiQktBNXZS?=
 =?utf-8?B?Vm5VSExsUGNjVWFSV2I5T1VaQ2svV0lueHdYbTVhcjRHNmVlT2gzWTgrYncr?=
 =?utf-8?B?TjVjYmNBbGZvS1lQRmh4ZG4zMXoyckNlVHpvSE9zMndPMzMzdGhRZThmQ1B6?=
 =?utf-8?B?L0c4TnM1K3N5djV2dUNNMVRkK2RjUWZQMzRQMGRhTGREZ3RGQmxoeWVMMExU?=
 =?utf-8?B?b1RVdHRnZXE2RWsrYUJ3eThsdUJ5OXFIZFFzNmlWMGhCM29KT3lRRkY5MGdp?=
 =?utf-8?B?cjAwMHNCZ3FQRXNJNmRXTTBpK2RScGRTVC9vL1hEcVY1UTB6ekJnaTJSdTBM?=
 =?utf-8?B?VDB4T3Bac2RRTk02UHBBUlR3ZTB4Mm1SMGdTSzVSNWpZMWV3R2ZWeUk2YWFT?=
 =?utf-8?B?bm1zNE9jYXl1cktWRmVhaXdTaVBVWnQxRjQ5dXBXWHFzb1pDWDV1OWlCSnRS?=
 =?utf-8?B?SldSOHBsSU1HcWVHWFhUdmJjeDUwSVhKOHhnaWhmZWxwMVJ3M0VCTUZHTk13?=
 =?utf-8?B?YXJ4bXJXRzVkVjZkYndweWl0VFF2RzNwUkJvQlJ3S3ZlMVFrL3dwdjlWREpu?=
 =?utf-8?B?K3lNZE1SbTBySUFCVTBicDBWU1BhUk8wL3BrZ2FCUTgwdE40SnhGN0REUWt1?=
 =?utf-8?B?V1YwOXJsZHd0cEpjU2w4N044dDVCS2tGUGNsL1FxMFBnM0tvY1lWVWFZNndW?=
 =?utf-8?B?eVZ4UFJHQTgvSUFicWtRUjJmVkhzdldpa3FUeUtnOVA1SlRZMElxa0lUMG5T?=
 =?utf-8?B?aEIvZmJ1ekFvVlhHREE3RDM5Z1AvOSs3OWNIS2VyaTluUWZsSGRkTHVERllt?=
 =?utf-8?B?VlZnT3BScktvMkF3d0lqeU9qRnpUcjJYVi9JNUg0d0hsUlBlZUdEb1RQMzZm?=
 =?utf-8?B?aWpMREV3THBibWpuU1ltMWVQVW9RTUQxVEt2OUdYT1daV2RIbXhBK25hQnZZ?=
 =?utf-8?Q?28fxH9pHJRjvwTiHp91TCY6UJHQUBYgGpJvS2zhUtJ2z?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b99d5c0f-0a6e-4cd2-ce9c-08daac5828b0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 13:46:26.7996
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xTwKTN2ORNKlhTt6sv2eQ93Cjtwgzy2HMagXVqNnTvrZgUY1T9megPliAEVUzx3XHjfTZNngpMnlYQ4uh2QayQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8581

On 11.10.2022 18:22, Roger Pau Monné wrote:
> On Thu, Aug 18, 2022 at 03:03:33PM +0200, Jan Beulich wrote:
>> @@ -1309,6 +1360,39 @@ static int __init mwait_idle_probe(void)
>>  	pr_debug(PREFIX "lapic_timer_reliable_states %#x\n",
>>  		 lapic_timer_reliable_states);
>>  
>> +	str = preferred_states;
>> +	if (isdigit(str[0]))
>> +		preferred_states_mask = simple_strtoul(str, &str, 0);
>> +	else if (str[0])
>> +	{
>> +		const char *ss;
>> +
>> +		do {
>> +			const struct cpuidle_state *state = icpu->state_table;
>> +			unsigned int bit = 1;
>> +
>> +			ss = strchr(str, ',');
>> +			if (!ss)
>> +				ss = strchr(str, '\0');
>> +
>> +			for (; state->name[0]; ++state) {
>> +				bit <<= 1;
>> +				if (!cmdline_strcmp(str, state->name)) {
>> +					preferred_states_mask |= bit;
>> +					break;
>> +				}
>> +			}
>> +			if (!state->name[0])
>> +				break;
>> +
>> +			str = ss + 1;
>> +	    } while (*ss);
>> +
>> +	    str -= str == ss + 1;
> 
> I would add parentheses to the sum for clarity.

If I was to add parentheses here, then like this:

    str -= (str == ss + 1);

Looks like I've screwed up with indentation here, though.

>> @@ -1400,8 +1484,18 @@ static int cf_check mwait_idle_cpu_init(
>>  	if (icpu->byt_auto_demotion_disable_flag)
>>  		on_selected_cpus(cpumask_of(cpu), byt_auto_demotion_disable, NULL, 1);
>>  
>> -	if (icpu->disable_promotion_to_c1e)
>> +	switch (icpu->c1e_promotion) {
>> +	case C1E_PROMOTION_DISABLE:
>>  		on_selected_cpus(cpumask_of(cpu), c1e_promotion_disable, NULL, 1);
>> +		break;
>> +
>> +	case C1E_PROMOTION_ENABLE:
>> +		on_selected_cpus(cpumask_of(cpu), c1e_promotion_enable, NULL, 1);
>> +		break;
>> +
>> +	case C1E_PROMOTION_PRESERVE:
>> +		break;
>> +	}
> 
> I find it kind of weird to user a notifier for this, won't it be
> easier to set the C1E promotion as part of the CPU bringup process?

A CPU notifier _is_ part of the CPU bringup process, isn't it? So it's
not clear to me what alternative you're thinking of.

> I see we also set other bits in the same way.

Well, yes - right here I only extend what we already have in place.
Re-working that in whichever way ought to be a separate topic imo, and
preferably not be part of a port of a commit coming from Linux.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:47:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:47:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421189.666398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oic4o-0000QN-8Y; Wed, 12 Oct 2022 13:47:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421189.666398; Wed, 12 Oct 2022 13:47:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oic4o-0000QG-5o; Wed, 12 Oct 2022 13:47:14 +0000
Received: by outflank-mailman (input) for mailman id 421189;
 Wed, 12 Oct 2022 13:47:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oic4m-0000Pq-Bn; Wed, 12 Oct 2022 13:47:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oic4m-0006NA-8V; Wed, 12 Oct 2022 13:47:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oic4l-0006BC-ST; Wed, 12 Oct 2022 13:47:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oic4l-0006jh-Rx; Wed, 12 Oct 2022 13:47:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NN4wV2rTYqraMjyTvT4ofA1jlgecTA9gPW+ZAyNPy1g=; b=52f3kE4y9P8UxCHI3H2YMCl9VV
	Ix0pSXOK9MBmVhV7Y3FFCl+L/i1dntsk1gb1YS7SismUtzy8XwSL+mb0bzhCpejJ+ObAkehsavMeg
	0EDheyUdTWSXwyaosr0MS5eEC7hEHKlOyVI3Wf7qf+vc7PCZRjPX7N8EitHC7v81boto=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173583-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173583: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 13:47:11 +0000

flight 173583 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173583/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173538

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173538 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173538 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    4 days
Testing same since   173492  2022-10-11 13:01:50 Z    1 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 427 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 13:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 13:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421204.666415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oicFB-000278-9i; Wed, 12 Oct 2022 13:57:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421204.666415; Wed, 12 Oct 2022 13:57:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oicFB-000271-70; Wed, 12 Oct 2022 13:57:57 +0000
Received: by outflank-mailman (input) for mailman id 421204;
 Wed, 12 Oct 2022 13:57:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oicF9-00026r-9Y; Wed, 12 Oct 2022 13:57:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oicF9-0006YK-7I; Wed, 12 Oct 2022 13:57:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oicF8-0006kE-PN; Wed, 12 Oct 2022 13:57:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oicF8-0000Wd-Ot; Wed, 12 Oct 2022 13:57:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FGZO+hyXRmpOWxx3A2lrrMkX8JvSCwA0z/jyYm0W2qY=; b=4GqxtmbxIsWJfIzHJOhOn8G/wt
	XgvuFcG+o802uZx0xBafEOKXZNv3ZndWbGsizJmaA93EidHTgsazogPpoMfDhQZMfB5dygnCgBlXI
	99qcN6RdT0Q7zk005jbb4IMvxhJfNnUtSr/VMCPJfZSOU7WdRg1vHOhiR6OCkxHlDyLY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173511-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173511: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 13:57:54 +0000

flight 173511 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173511/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-amd64-i386-qemuu-rhel6hvm-amd  7 xen-install          fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop  fail in 173493 like 172623
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   55 days
Testing same since   173493  2022-10-11 13:07:01 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         pass    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 14:09:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 14:09:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421213.666426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oicPv-0003n1-Ah; Wed, 12 Oct 2022 14:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421213.666426; Wed, 12 Oct 2022 14:09:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oicPv-0003mu-7i; Wed, 12 Oct 2022 14:09:03 +0000
Received: by outflank-mailman (input) for mailman id 421213;
 Wed, 12 Oct 2022 14:09:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fG8j=2N=citrix.com=prvs=27725cbfe=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oicPt-0003mo-VG
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 14:09:01 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 69775591-4a37-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 16:08:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69775591-4a37-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665583739;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=+7zWONsme+WDKmmjQ1XFM8fVK9PhFgGENwA9ndf+Jzg=;
  b=JIuSTWYZgEcIOEPTQXpvZ8beGJpEw1z68zy4BiY6aJRhMw274sxC/7lb
   TB/esru5fJ3AKYIGkaWQVR/xdsB6kGe7IyRXMjFJMG4W2ZXWvQihuyItx
   wLlp/moWRqlOx5kHHUxnj6IGPQkOLRm6mNoKWQ8zhQYAERO4uuAnTpyqI
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 85085026
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:l457wKkNx7j9au6x6Yg+nxjo5gy7JkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMWW3VaaqNZjP0etsgaoq28hhXuJbQn4NmT1Y6pSE0HiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnP6gR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfL3xOy
 fkUOQ43M1OzorOL4ajkEfFAr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP
 ZNfMGcxKkSbC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TaGJ0Fwx7C+
 Aoq+UzVOzM9Csy9lgOF0Xvwmu7fgXuhSIU7QejQGvlC3wTImz175ActfVmmpfi0jGauVtQZL
 FYbkgI1trQ7/kGvStj7XjW7rWSCsxpaXMBfe8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy
 hmOhdyBLRxitqeED02U8Li8pCm3fyMSKAcqZyUJUA8E6NnLu5wog1TESdMLLUKupoSrQ3eqm
 WnM9XVgweVI5SIW60ml1X7agw6pqon3dFN21iCGY0O/sVhhSKfwMuRE9mPnxfpHKY+YSHyIs
 34Fh9WS4YgyMH2dqMCeaL5TRe/0vp5pJBWZ2AcyRMd5q1xB7lb5JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiOMrKigbArLmdrGR2Cg2bKhggBd2B1yckC1
 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+TDOSfOEOhUYArXBgzc0E9iiF+Mm
 zq4H5LToyizrcWkOnWHmWLtBQpiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY4cl3het/0Mzo/1E
 oSVABAwJKzX2SKacm1nqxlLNNvSYHqIhSJiZHBzZw/3hRDOo++Htc8iSnf+RpF/nMQL8BK+Z
 6NdEylcKpyjkgj6xgk=
IronPort-HdrOrdr: A9a23:82EYkKMXwq44CsBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.95,179,1661832000"; 
   d="scan'208";a="85085026"
Date: Wed, 12 Oct 2022 15:08:30 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2][4.15] libxl/Arm: correct xc_shadow_control()
 invocation to fix build
Message-ID: <Y0bKXm7lznpmYfAL@perard.uk.xensource.com>
References: <af81d6d5-5d2b-3db8-634f-17392ef328f9@suse.com>
 <AS8PR08MB79910144ACE4842C43A205C392229@AS8PR08MB7991.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <AS8PR08MB79910144ACE4842C43A205C392229@AS8PR08MB7991.eurprd08.prod.outlook.com>

On Wed, Oct 12, 2022 at 01:16:47PM +0000, Henry Wang wrote:
> Hi Jan,
> 
> > -----Original Message-----
> > From: Jan Beulich <jbeulich@suse.com>
> > Subject: [PATCH v2][4.15] libxl/Arm: correct xc_shadow_control() invocation
> > to fix build
> > 
> > The backport didn't adapt to the earlier function prototype taking more
> > (unused here) arguments.
> > 
> > Fixes: c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_op
> > for Arm")
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Henry Wang <Henry.Wang@arm.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 15:17:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 15:17:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421249.666464 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oidUF-0003Cf-Rw; Wed, 12 Oct 2022 15:17:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421249.666464; Wed, 12 Oct 2022 15:17:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oidUF-0003CY-P5; Wed, 12 Oct 2022 15:17:35 +0000
Received: by outflank-mailman (input) for mailman id 421249;
 Wed, 12 Oct 2022 15:14:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rPQ4=2N=oracle.com=ross.philipson@srs-se1.protection.inumbo.net>)
 id 1oidR5-000339-CS
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 15:14:19 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87b6d64a-4a40-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 17:14:14 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29CE3rfO012513;
 Wed, 12 Oct 2022 15:13:31 GMT
Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta01.appoci.oracle.com [130.35.100.223])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k30032b4s-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 12 Oct 2022 15:13:31 +0000
Received: from pps.filterd
 (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5)
 with ESMTP id 29CDAxsD027357; Wed, 12 Oct 2022 15:13:30 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174])
 by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id
 3k2ynba2nc-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 12 Oct 2022 15:13:30 +0000
Received: from BY5PR10MB3793.namprd10.prod.outlook.com (2603:10b6:a03:1f6::14)
 by IA1PR10MB6148.namprd10.prod.outlook.com (2603:10b6:208:3a8::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Wed, 12 Oct
 2022 15:13:27 +0000
Received: from BY5PR10MB3793.namprd10.prod.outlook.com
 ([fe80::34df:ea3:52e7:e171]) by BY5PR10MB3793.namprd10.prod.outlook.com
 ([fe80::34df:ea3:52e7:e171%4]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022
 15:13:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87b6d64a-4a40-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2022-7-12;
 bh=WK0nTrupIYI1lFgGV+/w9IqfI57mNcQD5z3ndwApQjw=;
 b=lQV+dj3/hWOTxx14xL1SyN0cg4Drsz8OmS97jjK5UqZdsB26QjR+TZdb/3JNnpdZ+8l/
 eVaNmKH3+JXMwhirjN2HseZ0yRNXx8qvZOUTdynJuFNpwnn3C9uMdmJ/N4ZCyMntdxvx
 zgBnjyPAamrbFM7zX31QvO0haDz99NKFHaF1d2clfIWtYFNMQ4/5nOvB9DnFQ028T0B1
 XbZsdJemxvJOzIYp5oW97jgkqAzQiIyiZFFuqXn4pXSLb6kxuTQLEj/QF0gIVwdWmuyL
 MHYA4NVEXTmTJhu225wCpiMstTtHAWH9vE3zh21keUoamQxLTWGWgTYjxoQ9QG4ncVvS ow== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QPii7UeBvH8PY0rCaziiajbnegaOsnJ/N+fcztdFFb9tG7G9SAbRLSRi+bUHhZfu6sn1pbBucXWrGOVMtC0483SNFBTT/sqkFcN3juvlLxURbK8qI8o8NSHK0UdeWZulqtAjesSWTl8MkNo4IOyUd7NNGZePzVn/3MyegocfKbPKHousFPwGUvOT/9M6NdQeFtqoyoII9MwKOHxcR7pncEJsTfF49SMIAa+3YQZsWMDVMLpSMhF6Nml6vCcJoldF2UpYAUQNLogtLZFRvbDbPbl4S3HAm8SiIkFgATJKX9droMZMJvzdhEmxZFUhjqkBIg/rnEVePY7PWUd5/9JXNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WK0nTrupIYI1lFgGV+/w9IqfI57mNcQD5z3ndwApQjw=;
 b=MOocMEYr7Vmb6Fo/8qC/DQIzRddfRUIqhBsN22wbTnI745ZXS7c3DiLQUWlqgfWAIFV1v1QYyk2HjzonzYoLRuxSHY/Du02UgvfdQmvH+PD4b8Z1XGEaTPm+IwBLR2XD1xdejNp1kwQ8Mb4hDslQE55xFCZcy7a8DxBwVBTlNduwTW6Nm/WPO+peoTLENn1SZwPfNiOTLbeZ1e0MIEF05AmTf40KHpne91ld05icADyZSXcxNn9sKVF04Omfi9XPAaDZffle8lJKlyc6HyFMLCyNtMrFQjhmeJ0Jge6N3p5dmEHbW7BQwsoRiPPkJWWkF4VJhDbCO9c5b8tOrGZhZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WK0nTrupIYI1lFgGV+/w9IqfI57mNcQD5z3ndwApQjw=;
 b=X1vIU8vz4CongTSuBfd1/P0SW0zRVXdY84kOls+ciKxitQbA6oxhArFSeQcfl35GJCR3WEoFACWT2e5cRhzB8Bvhi9cyjJkRO3SkbRfyksQgV8UmqNXfVIFP7CAwicsMxcKOZhG7fmBo8H6m+cY0axxpDaAomnOMadk+w/G1Ov8=
Message-ID: <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>
Date: Wed, 12 Oct 2022 11:13:20 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dpsmith@apertussolutions.com,
        tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        luto@amacapital.net, dave.hansen@linux.intel.com,
        kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
        Jan Kiszka <jan.kiszka@siemens.com>, jailhouse-dev@googlegroups.com,
        xen-devel@lists.xenproject.org,
        Andrew Cooper <andrew.cooper3@citrix.com>
References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
 <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>
 <Y0GTUg1ACpKZYMHY@nazgul.tnic>
From: Ross Philipson <ross.philipson@oracle.com>
In-Reply-To: <Y0GTUg1ACpKZYMHY@nazgul.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: BN9PR03CA0254.namprd03.prod.outlook.com
 (2603:10b6:408:ff::19) To BY5PR10MB3793.namprd10.prod.outlook.com
 (2603:10b6:a03:1f6::14)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BY5PR10MB3793:EE_|IA1PR10MB6148:EE_
X-MS-Office365-Filtering-Correlation-Id: 8f6f4d6d-112d-4b60-846e-08daac64509d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	x0YUnG3fygGGDRJ8KnJq7eVysjDT0PfHc6Azo1wMlBz1BBJ9BOxbiFOLhAAyxCLSeU+uJBzzZKM3Q/NotKHb0hR474O0WyEVzb/ncSOgAkW2wCCWrrMSc7I/E47+5efFn/YwwzlA9BF8V0wZFcmL7BKAmxLvihhYKb9OZirw/AZiANps+PXRFd9lMaGitufokS2wFpJmXnDlnZzvYFHMYESE/HKZZ1zC5Mf2jw0PIDBbt1CV7WeADFHJzUTf1CJsBrm1NSnf9erCRsMvOgu1UQT25Cbvlelinc+LvX6MSjW3ClBALmkAO/asNzvWsRj4FEDTlwIJq9fvM8/miu/BUFVlJ86xHulCl1Ytq1fDGjrqXr+cqEXL+8aFnsumO/AEd98AXSrDkG8/k3f9AtAb3GWBf+hQXqO2syfdsMeD1sT3ykrVAA7WjlKTz6pRruh5f1gMLaLjSR1plgxrwkfW74jq82YEADKvujLPdMuhBqIUsMEay3CnKEOwVmd60dTBnBj9vaFcg2z1KwbC7JL6TowZX162bh1psH/dPXP/OhK68IWJd/Cy914Iqob/QuU0RJ+WsXoVFLkNA8TmdqMJcQlxLk1ge0QVhnpshCN5R7n5YmwJnZu1F7Tw1ZW//RA2NZNEvRqMuO6NtBu1FSgD/O32SojwI2o3lKAlLDmkQkGCj7PCqzu9jsBvgaCaVu9NGFy4Suy3CvHH/+kn/to2E6sifPkHmQHZYk/7mh/o54X0GZapBScy3ZkGgCJmX3KCMAwydXa5Zy7McUzFqhquMyEs+J+zp4hCfF9a7mhWF1qtw90pkkqgKuYDeMLS6H6pPX8DHxd5xYEjCgPqIu1+og==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB3793.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(2906002)(83380400001)(86362001)(66476007)(31696002)(8936002)(66946007)(66556008)(44832011)(36756003)(8676002)(5660300002)(6916009)(53546011)(316002)(6506007)(478600001)(31686004)(966005)(41300700001)(38100700002)(54906003)(6486002)(4326008)(186003)(6666004)(2616005)(7416002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MFJmQ2ZuSDNrQ1NMU3h4TERyVmY4WVNPdk9qblk2SFNFS3RaTjVuVVVwU1B3?=
 =?utf-8?B?bWI4VS9oUFY3YnZPN1l6dDhWVTVNZzBIc3hiWHlvc20vSzdyb1ZZQkt0YnZF?=
 =?utf-8?B?ZFZBYStlUXZRVGdpalJ4ZDVhcUxiYTBkMFRBWTJ2SkVwVTc0amUzVHpOK3kr?=
 =?utf-8?B?MVJZY3NxeXhPUWJvQlVHUmN2dThTSy94eUxwK1JVWExEQjZtR2dGR21hRUFF?=
 =?utf-8?B?SnpNYkExRndlNkg0WlZMV2E0aXFhL1NaMGZzazluQVBvS2ZDMFFmeU9Ic1Fi?=
 =?utf-8?B?OTl0dHlHM2FzWGtPL2w4M2tCRm40SzN6TjUxcDVpRFpEVTNXWVRlbEd1RWUv?=
 =?utf-8?B?ZnU0MXFkWFptSFFmMTJSTXV2d0tCUUJxVS9hM09oWDVIeUp3ajhJUTZUVkJt?=
 =?utf-8?B?dGJzU3VQK0N5TzBmdFBQTWV0YlZjb3NJMzVFekRkWlRqOFU2VFV5WStINGxU?=
 =?utf-8?B?WExRVmxZNjREUCtMYkFOVytJZ1V4Wm03alBZcUJORk9MbWtNQUpRU21Ldktk?=
 =?utf-8?B?b1dFNXg4d1d3ZERZcHJFaEliaEVRbmZhR2Z1Mk0wUUpYa1pKQlByb2RBeTI1?=
 =?utf-8?B?TzlGVExNUWFWNi9wL29qZnhoWFgxQklPVlZUbGVLQklwd1BRNnVNZVZoU1NS?=
 =?utf-8?B?Szhsbm5JQW50RUFjdm80VkNMVDB1T05sOGZzN3FRd3FkbXk0TmtVQWhGTFJn?=
 =?utf-8?B?b3FrTW1zMHFyNXpTeW9JcG81ZjhDR2hBaHlWRGl3OThJY2IzVXU3ZTFpSkdR?=
 =?utf-8?B?bTN0aXJSOUYyeEtpbEFUWjZuMWxaQ25mZG5LYmhJSkVhZnNRNlV6OW5IRUdV?=
 =?utf-8?B?d2liK3k1eWVmaDZBQ1JVQ0hLTVRTNzQydTVKT0RlOVNQdXJ0S1JjY3I0M3Vv?=
 =?utf-8?B?ZTdwOTIrRFBCck5JNUlDNUF2aFJ1aHR4bzFjRUJ6WUlmcklSQk9VVzI4NDdF?=
 =?utf-8?B?RTFRQXJqcTd0TkNIcS9GTDNUK09NM2F2N091bUxmUUN0ZUtwMGlidUYvS0ZB?=
 =?utf-8?B?aWx2WTNscDU5akFRQXJEMmtYLzlCQTJjTVlvTDFwakRhaFNYTlNFcDM4aHQ0?=
 =?utf-8?B?QlFuVTNGYkFZelVJMEJEUlZEM0lNNk5UbXlIdFhXS2ttYStITks5aG9tRWJu?=
 =?utf-8?B?SFBCWXRpcjBOWUJJNHBMMzVwbUp5VjFjaEg2clJwSzlsb2U1cVRjbkhZWGJJ?=
 =?utf-8?B?eGdrTEFHOGRNUGlNZ3hTWitvd3E3THQwZEZETS9KdWYyY2c0cDlzUlIyU2ZK?=
 =?utf-8?B?Nms3aUlWcmZFYjZQbkRTWUhqamRlY1c0R1diNW5jaVd3cXk0QzJpSmJSOU1s?=
 =?utf-8?B?b203eDZQcEJOTUxjWjlRWk5QNEtwOU0vdUtNSlF1WFRGZHJIRmdaejZFaVlL?=
 =?utf-8?B?N1JXTVJySjdTY3p2STVqNm1CVTg3SU04QVBaQWVXaUdUZWRENkV4ZHpRWVpJ?=
 =?utf-8?B?QVVGT3g0ZVZacC9XcjZZWFZWZWZvUG9tVnMyNThiemkzbXAvV1ZxYmpYQVJB?=
 =?utf-8?B?eS9zSWpHVGJkLzloeTlodFNvZlFRZkd2d1JxeEF5ZG1ueGR0Y3A3Tm5OTTFN?=
 =?utf-8?B?MDBhczUrSExpSmdjalNTTFNaUWtMV1lJS0tidW1GYllmV3l0alRtU2pmWU0w?=
 =?utf-8?B?RW9CSW55TTFtR3VKaDFPUC9SVmRVSlBDRHBoNk1FZzk4elNBV1hRMC9PWFo1?=
 =?utf-8?B?UG9OSHVIazRwNGtBSlJWd0ZvLzl1djdVM2Z5MGRkMmNEdjY1VjhZS1l0dkZ1?=
 =?utf-8?B?NHBoV1F3RjRESHIyNnNRWlBYQ0VEdHdWc0I0MjFXeTJMT2dQZXZkRUc1N2hu?=
 =?utf-8?B?dXFUNHIvRXVwdTc2Q0hDR3VVK3ZwOUtGRjBKTlE1VlM0aHdNeE1OMDlNTStr?=
 =?utf-8?B?VjJCK0xWNkJiSUhwSjQ4NW9rSFZ6ZEV2SExkYmxJSjVJOC96aDYwd2lPOFRk?=
 =?utf-8?B?RTBrckpnK3FnSG1Fak9lZUc2VVVLT3ZPTHF5R3ovMDFselBqTzdSWDZmUXZX?=
 =?utf-8?B?c0k5WmU1bE9KbmhpZDZaOVVxczJqa2lINE4rVkdXdDdNVUVUeTRTOStrTVZV?=
 =?utf-8?B?d0lPeVVsRGlvT2xhbVNueTRTK1NnMjlnY3c4d0hjS2t0cXVWY0NJUDFCWVZZ?=
 =?utf-8?B?NGpLNExsSnRLSmZwMXRiOWt6OVhGaG9xNlpWQ0VLUlJ0aHpnVU9jYmVxV2xM?=
 =?utf-8?Q?XKrro/n587BO96GZ3QTfCKM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f6f4d6d-112d-4b60-846e-08daac64509d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 15:13:27.8366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vBFT76TpY+abRaWsBZ+JXzpptzAcYqgFpRFV1E3IywkSshkVCeJcWR/anEqKAimDQFwUVxkFcLmp+SM4o8b9ri1/q3Kj3TJiYXn1cSWfpnM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6148
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-12_07,2022-10-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210120100
X-Proofpoint-ORIG-GUID: 8svQ_rMm9HO_GHLWQF6Krny2E1q3wwWh
X-Proofpoint-GUID: 8svQ_rMm9HO_GHLWQF6Krny2E1q3wwWh

On 10/8/22 11:12, Borislav Petkov wrote:
> Adding Xen and Jailhouse people and MLs to Cc.
> 
> Folks, thread starts here:
> 
> https://lore.kernel.org/r/1650035401-22855-1-git-send-email-ross.philipson@oracle.com
> 
> On Fri, Apr 15, 2022 at 11:10:00AM -0400, Ross Philipson wrote:
>> There are a number of places where early_memremap is called
>> but the return pointer is not checked for NULL. The call
>> can result in a NULL being returned so the checks must
>> be added.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
>> ---
>>   arch/x86/kernel/devicetree.c | 10 ++++++++++
>>   arch/x86/kernel/e820.c       |  5 +++++
>>   arch/x86/kernel/jailhouse.c  |  6 ++++++
>>   arch/x86/kernel/mpparse.c    | 23 +++++++++++++++++++++++
>>   arch/x86/kernel/setup.c      |  5 +++++
>>   arch/x86/xen/enlighten_hvm.c |  2 ++
>>   arch/x86/xen/mmu_pv.c        |  8 ++++++++
>>   arch/x86/xen/setup.c         |  2 ++
>>   8 files changed, 61 insertions(+)
> 
> Ok, a couple of notes:
> 
> 1. the pr_*("<prefix>:" ... )
> 
> thing is done using pr_fmt() - grep the tree for examples.

I am already using the pr_* macros in the patches. Are you asking me to 
do something or is this just informational?

> 
> 2. I think you should not panic() the machine but issue a the
> warning/error and let the machine die a painful death anyway. But Xen
> folks will know better what would be the optimal thing to do.

When I was working on the patches I asked Andrew Cooper at Citrix what 
action I should take if any of the calls in the Xen code failed. I 
believe he told me it was basically fatal and that panic() would be fine 
there.

Thank you,
Ross Philipson

> 
> Thx.
> 



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 15:26:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 15:26:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421257.666475 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oidcc-0004jB-ND; Wed, 12 Oct 2022 15:26:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421257.666475; Wed, 12 Oct 2022 15:26:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oidcc-0004j4-KV; Wed, 12 Oct 2022 15:26:14 +0000
Received: by outflank-mailman (input) for mailman id 421257;
 Wed, 12 Oct 2022 15:26:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zRMe=2N=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oidca-0004iy-Mt
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 15:26:12 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33853449-4a42-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 17:26:11 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B422221C52;
 Wed, 12 Oct 2022 15:26:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 384FE13ACD;
 Wed, 12 Oct 2022 15:26:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oA0CDJLcRmMMQQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 12 Oct 2022 15:26:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33853449-4a42-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665588370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=W22no4UHHSLq7kZ7HGvm7b6REa1W65pcxdWLEl8piKk=;
	b=PTiQWe3U4bHLPCJI2dxB/KyCoAe4PJy9aRecJ5HW+crqwsRdiISGhSvGeYEpUpCPYGR0GC
	trHaSmrnxgLFY1/rwlqQj7vdVy0ePfHm+axtbmf+zOy15w1PyqD76Cd/k0y+cgbt/vzXUG
	N9wANPYoIFbi+FLljTE6Hx9DxN4ETx4=
Message-ID: <9fcdf79b-8956-b976-704a-3018542cc557@suse.com>
Date: Wed, 12 Oct 2022 17:26:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls
Content-Language: en-US
To: Ross Philipson <ross.philipson@oracle.com>, Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
 hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
 kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
 Jan Kiszka <jan.kiszka@siemens.com>, jailhouse-dev@googlegroups.com,
 xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>
References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
 <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>
 <Y0GTUg1ACpKZYMHY@nazgul.tnic>
 <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0IevKUioMcP602uAHkVuaiL3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0IevKUioMcP602uAHkVuaiL3
Content-Type: multipart/mixed; boundary="------------oasnLHEdbuwWbRHotwxlosfR";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Ross Philipson <ross.philipson@oracle.com>, Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
 hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
 kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
 Jan Kiszka <jan.kiszka@siemens.com>, jailhouse-dev@googlegroups.com,
 xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <9fcdf79b-8956-b976-704a-3018542cc557@suse.com>
Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls
References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
 <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>
 <Y0GTUg1ACpKZYMHY@nazgul.tnic>
 <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>
In-Reply-To: <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>

--------------oasnLHEdbuwWbRHotwxlosfR
Content-Type: multipart/mixed; boundary="------------3wZ5tZFbtS6PNsirNBDZ207T"

--------------3wZ5tZFbtS6PNsirNBDZ207T
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTIuMTAuMjIgMTc6MTMsIFJvc3MgUGhpbGlwc29uIHdyb3RlOg0KPiBPbiAxMC84LzIy
IDExOjEyLCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6DQo+PiBBZGRpbmcgWGVuIGFuZCBKYWls
aG91c2UgcGVvcGxlIGFuZCBNTHMgdG8gQ2MuDQo+Pg0KPj4gRm9sa3MsIHRocmVhZCBzdGFy
dHMgaGVyZToNCj4+DQo+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzE2NTAwMzU0MDEt
MjI4NTUtMS1naXQtc2VuZC1lbWFpbC1yb3NzLnBoaWxpcHNvbkBvcmFjbGUuY29tDQo+Pg0K
Pj4gT24gRnJpLCBBcHIgMTUsIDIwMjIgYXQgMTE6MTA6MDBBTSAtMDQwMCwgUm9zcyBQaGls
aXBzb24gd3JvdGU6DQo+Pj4gVGhlcmUgYXJlIGEgbnVtYmVyIG9mIHBsYWNlcyB3aGVyZSBl
YXJseV9tZW1yZW1hcCBpcyBjYWxsZWQNCj4+PiBidXQgdGhlIHJldHVybiBwb2ludGVyIGlz
IG5vdCBjaGVja2VkIGZvciBOVUxMLiBUaGUgY2FsbA0KPj4+IGNhbiByZXN1bHQgaW4gYSBO
VUxMIGJlaW5nIHJldHVybmVkIHNvIHRoZSBjaGVja3MgbXVzdA0KPj4+IGJlIGFkZGVkLg0K
Pj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogUm9zcyBQaGlsaXBzb24gPHJvc3MucGhpbGlwc29u
QG9yYWNsZS5jb20+DQo+Pj4gLS0tDQo+Pj4gwqAgYXJjaC94ODYva2VybmVsL2RldmljZXRy
ZWUuYyB8IDEwICsrKysrKysrKysNCj4+PiDCoCBhcmNoL3g4Ni9rZXJuZWwvZTgyMC5jwqDC
oMKgwqDCoMKgIHzCoCA1ICsrKysrDQo+Pj4gwqAgYXJjaC94ODYva2VybmVsL2phaWxob3Vz
ZS5jwqAgfMKgIDYgKysrKysrDQo+Pj4gwqAgYXJjaC94ODYva2VybmVsL21wcGFyc2UuY8Kg
wqDCoCB8IDIzICsrKysrKysrKysrKysrKysrKysrKysrDQo+Pj4gwqAgYXJjaC94ODYva2Vy
bmVsL3NldHVwLmPCoMKgwqDCoMKgIHzCoCA1ICsrKysrDQo+Pj4gwqAgYXJjaC94ODYveGVu
L2VubGlnaHRlbl9odm0uYyB8wqAgMiArKw0KPj4+IMKgIGFyY2gveDg2L3hlbi9tbXVfcHYu
Y8KgwqDCoMKgwqDCoMKgIHzCoCA4ICsrKysrKysrDQo+Pj4gwqAgYXJjaC94ODYveGVuL3Nl
dHVwLmPCoMKgwqDCoMKgwqDCoMKgIHzCoCAyICsrDQo+Pj4gwqAgOCBmaWxlcyBjaGFuZ2Vk
LCA2MSBpbnNlcnRpb25zKCspDQo+Pg0KPj4gT2ssIGEgY291cGxlIG9mIG5vdGVzOg0KPj4N
Cj4+IDEuIHRoZSBwcl8qKCI8cHJlZml4PjoiIC4uLiApDQo+Pg0KPj4gdGhpbmcgaXMgZG9u
ZSB1c2luZyBwcl9mbXQoKSAtIGdyZXAgdGhlIHRyZWUgZm9yIGV4YW1wbGVzLg0KPiANCj4g
SSBhbSBhbHJlYWR5IHVzaW5nIHRoZSBwcl8qIG1hY3JvcyBpbiB0aGUgcGF0Y2hlcy4gQXJl
IHlvdSBhc2tpbmcgbWUgdG8gZG8gDQo+IHNvbWV0aGluZyBvciBpcyB0aGlzIGp1c3QgaW5m
b3JtYXRpb25hbD8NCj4gDQo+Pg0KPj4gMi4gSSB0aGluayB5b3Ugc2hvdWxkIG5vdCBwYW5p
YygpIHRoZSBtYWNoaW5lIGJ1dCBpc3N1ZSBhIHRoZQ0KPj4gd2FybmluZy9lcnJvciBhbmQg
bGV0IHRoZSBtYWNoaW5lIGRpZSBhIHBhaW5mdWwgZGVhdGggYW55d2F5LiBCdXQgWGVuDQo+
PiBmb2xrcyB3aWxsIGtub3cgYmV0dGVyIHdoYXQgd291bGQgYmUgdGhlIG9wdGltYWwgdGhp
bmcgdG8gZG8uDQo+IA0KPiBXaGVuIEkgd2FzIHdvcmtpbmcgb24gdGhlIHBhdGNoZXMgSSBh
c2tlZCBBbmRyZXcgQ29vcGVyIGF0IENpdHJpeCB3aGF0IGFjdGlvbiBJIA0KPiBzaG91bGQg
dGFrZSBpZiBhbnkgb2YgdGhlIGNhbGxzIGluIHRoZSBYZW4gY29kZSBmYWlsZWQuIEkgYmVs
aWV2ZSBoZSB0b2xkIG1lIGl0IA0KPiB3YXMgYmFzaWNhbGx5IGZhdGFsIGFuZCB0aGF0IHBh
bmljKCkgd291bGQgYmUgZmluZSB0aGVyZS4NCg0KcGFuaWMoKSBpcyB0aGUgd2F5IHRvIGdv
LiBFdmVyeXRoaW5nIGVsc2Ugd291bGQgbWFrZSB0aGUgZXJyb3IgaGFyZGVyDQp0byBhbmFs
eXplLg0KDQpCVFcsIENDLWluZyB0aGUgbWFpbnRhaW5lcnMgb2YgdGhlIG1vZGlmaWVkIGNv
ZGUgaXMgZ29vZCBwcmFjdGljZS4NCg0KDQpKdWVyZ2VuDQo=
--------------3wZ5tZFbtS6PNsirNBDZ207T
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3wZ5tZFbtS6PNsirNBDZ207T--

--------------oasnLHEdbuwWbRHotwxlosfR--

--------------0IevKUioMcP602uAHkVuaiL3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNG3JEFAwAAAAAACgkQsN6d1ii/Ey/k
lgf+IDHKz+H4WUZuhhBLYi/ie36DnrSYs3Q85onru8DhPm/nkXNghvChcB6XlT7+MJjrdZlkJQap
+WEVoJXXUDDuR+ngE9Ewn2Ua+XApqTW8YfvCz64rpgP1N8sksRf7rfb66/KNlHnmtwLnmVgnNFba
EK4PEjMXBt2k70dNlLxEY7Z03RCahwo/q60L9cHBcRE66uopoKx+COv/HWFeduP8RgZfPA8W3aFb
Rp3/sotWNLIy/oFvPpo/ILyJifzUUnWWn9/l+GyU2oFXsIHYG7F21mbpQfiGK3YUX2LzGILc2JhT
ax7ux5jmcS421T6ek9ozk5lML3l3+Ev38Idr4gUykQ==
=54GQ
-----END PGP SIGNATURE-----

--------------0IevKUioMcP602uAHkVuaiL3--


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 15:31:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 15:31:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421264.666486 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oidho-00068q-CF; Wed, 12 Oct 2022 15:31:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421264.666486; Wed, 12 Oct 2022 15:31:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oidho-00068j-8m; Wed, 12 Oct 2022 15:31:36 +0000
Received: by outflank-mailman (input) for mailman id 421264;
 Wed, 12 Oct 2022 15:31:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oidhn-00068G-LE; Wed, 12 Oct 2022 15:31:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oidhn-0008KY-GN; Wed, 12 Oct 2022 15:31:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oidhn-0002h6-7C; Wed, 12 Oct 2022 15:31:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oidhn-00013N-6T; Wed, 12 Oct 2022 15:31:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6YDh8V0SwwPFVFbOe+hbwO8zMPT3kb9ObuA/ljcI2yo=; b=AXFr0OachRwyW0H7CXD5THLFYS
	aGFmo+4480bJEVwPgUYUCawO7kNSVKrZdui4n3TwrQPFW2HEN3cnsjHfWXFPOeaENsRes+JAlLdyY
	ZG2x6y7SOaIFp3Q9BDWA6Lp/TucwwhlsqEtMi/sW3hMF/MGnAAFD4XyfcyRycAO9cpVg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173525-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173525: trouble: broken/fail/pass
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:<job status>:broken:regression
    xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:<job status>:broken:regression
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug
    xen-unstable:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 15:31:35 +0000

flight 173525 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173525/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm    <job status>      broken
 test-amd64-amd64-qemuu-freebsd11-amd64    <job status>                 broken

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken pass in 173488
 test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken pass in 173488
 test-arm64-arm64-xl           8 xen-boot         fail in 173488 pass in 173525
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 173488 pass in 173525
 test-amd64-amd64-xl-pvhv2-amd 20 guest-localmigrate/x10    fail pass in 173488

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 173488 like 173482
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 173488 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173488
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173488
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173488
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173488
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173488
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173488
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173488
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173488
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173488
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173488
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173488
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173488
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173525  2022-10-12 01:51:47 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           broken  
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       broken  
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken
broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken
broken-step test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm host-install(5)
broken-step test-amd64-amd64-qemuu-freebsd11-amd64 host-install(5)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 15:54:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 15:54:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421285.666513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oie3T-0000bK-Ex; Wed, 12 Oct 2022 15:53:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421285.666513; Wed, 12 Oct 2022 15:53:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oie3T-0000bD-CH; Wed, 12 Oct 2022 15:53:59 +0000
Received: by outflank-mailman (input) for mailman id 421285;
 Wed, 12 Oct 2022 15:53:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ub8z=2N=alien8.de=bp@srs-se1.protection.inumbo.net>)
 id 1oie3I-0000b4-85
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 15:53:58 +0000
Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0db92d63-4a46-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 17:53:46 +0200 (CEST)
Received: from zn.tnic (p200300ea9733e705329c23fffea6a903.dip0.t-ipconnect.de
 [IPv6:2003:ea:9733:e705:329c:23ff:fea6:a903])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 124591EC0725;
 Wed, 12 Oct 2022 17:53:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0db92d63-4a46-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
	t=1665590021;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=n37CuGT72/BdjSCMX/SbC87AZ3K1N+NFaoL8bgbkin4=;
	b=nYK7i3NzdisKMQUmD20WD6kGnXBpnm+PARQn5OMi7eRiexD52OcFK/VHEWa8AAZnhtuEiE
	YFqI1WM7Rhb2wTxZkw8tC9l8+WEokLWEvabMA2JVIdzJv91y9b5zoG8/vjbSrZ1Gwf2pu6
	RXRQepIIFkz4H9wTBqQfxKMvc2/0dvk=
Date: Wed, 12 Oct 2022 17:53:40 +0200
From: Borislav Petkov <bp@alien8.de>
To: Ross Philipson <ross.philipson@oracle.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
	kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
	Jan Kiszka <jan.kiszka@siemens.com>, jailhouse-dev@googlegroups.com,
	xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls
Message-ID: <Y0bjBP6/Eyg8B25k@zn.tnic>
References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com>
 <1650035401-22855-2-git-send-email-ross.philipson@oracle.com>
 <Y0GTUg1ACpKZYMHY@nazgul.tnic>
 <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <201850b3-5126-cd79-637f-79f198dd409d@oracle.com>

On Wed, Oct 12, 2022 at 11:13:20AM -0400, Ross Philipson wrote:
> I am already using the pr_* macros in the patches. Are you asking me to do
> something

Yes. You do

pr_X("prefix_string: msg"

while you should set the prefix string and do

pr_X("msg".

As said, grep the tree for examples where pr_fmt() is set.
arch/x86/kernel/cpu/bugs.c is a good example.

> When I was working on the patches I asked Andrew Cooper at Citrix what
> action I should take if any of the calls in the Xen code failed. I
> believe he told me it was basically fatal and that panic() would be
> fine there.

Yes, that should be confirmed by people who know the code and you should
mention in the commit message at least that panicking is the only viable
thing to do in the respective case. If, as Jürgen says, it is actually
better to panic() in those cases, especially if it otherwise would make
debugging harder, then sure, by all means.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 16:01:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 16:01:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421293.666528 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oieAF-0002hZ-8X; Wed, 12 Oct 2022 16:00:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421293.666528; Wed, 12 Oct 2022 16:00:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oieAF-0002hS-52; Wed, 12 Oct 2022 16:00:59 +0000
Received: by outflank-mailman (input) for mailman id 421293;
 Wed, 12 Oct 2022 16:00:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5J4o=2N=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1oieAD-0002hK-ON
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 16:00:57 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2051.outbound.protection.outlook.com [40.107.247.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d773edc-4a47-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 18:00:55 +0200 (CEST)
Received: from AS9PR06CA0251.eurprd06.prod.outlook.com (2603:10a6:20b:45f::28)
 by DB9PR08MB6395.eurprd08.prod.outlook.com (2603:10a6:10:254::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Wed, 12 Oct
 2022 16:00:53 +0000
Received: from AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45f:cafe::73) by AS9PR06CA0251.outlook.office365.com
 (2603:10a6:20b:45f::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Wed, 12 Oct 2022 16:00:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT008.mail.protection.outlook.com (100.127.141.25) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 12 Oct 2022 16:00:52 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Wed, 12 Oct 2022 16:00:52 +0000
Received: from c90ab0f8abfe.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5638B540-F85C-4277-B113-BB91BBFDE712.1; 
 Wed, 12 Oct 2022 16:00:45 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c90ab0f8abfe.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 12 Oct 2022 16:00:45 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by DU0PR08MB8833.eurprd08.prod.outlook.com (2603:10a6:10:478::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct
 2022 16:00:43 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5709.019; Wed, 12 Oct 2022
 16:00:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d773edc-4a47-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=MdPvL+kpX2h/+ryoEJg9UnIqRWkf2Bz+kTuMSMYZwcwTnK75TIBYtFoKUAk2k5F3/JpQ77dv8+iCYQLToRLO3DTfBGB7fjnSOP5d7dqsOXUOQdnt1ltJrmsoDmaCLFFMEPij63gDa55c/ck7dKoK2hgBcI5sS2yjrmsn+CEI9e6GkWGVLfCcQpWVQwsDyyOIWBSa1sFDw18qpOFcFVBfTmrUrXFuYKdelxl06k7R2hq+dtFEy8Bsn4ANIXQp+htiudx8oJuxcDeGtQUAsqUbiO/OJIN3CsKDUN+oOwaH1l+orhwn1/zy8iTWJYFZZ45F4/6FUt+lP8fKlCeSTJtyVw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LSswIpNmi9PEvZthD1AbpwbfzH8zN6F0xboMfvxc098=;
 b=SRFwN0CklAhFo1qMRzz1/eVl+Hbq05g3BaP9eYUK3kQQaup9Buc6x6QzK9WC2rOE55OcOeC9gNhl4p6EXdIsUTrQ1QXBhvXlbMtLgMlnm32VioMq+8/VFld+SHkJDMLFyvaxTqUD/CgOEQeyHO4GYRIA7xqIF9MBWCvUHSNoCEQtJ5IddEw54HsQRrzXuFLN6iTT4IrFNkR/fUtS30LNN1dXe8ifZdFM8wR3UaAmryLWVj4Ym5SXcAmYPnxCDozEjGQluV8K0fgactNyLUDlPjLvefQSKEQv81KteEF6mxODaWivFwRISolR7XU5b0Z1/r5LVOcI7b2JLrNXxBqCxQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LSswIpNmi9PEvZthD1AbpwbfzH8zN6F0xboMfvxc098=;
 b=5x0qoZjZewrgPRX3VyO7OsQ7h2zJf+pOQSeDxeovkRxfFMfVkyGruzqqarYusqEOIWXHmHQwLm7rLHlztlC8bfjAboOo3jrVY6BmXb30NAtYXoQWc6BYViPQPZzODAbocQgyyRobV5f/6xTdLzDiDxsO3drTac0VVMJz/48ynHA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0e50c923e1d06f4e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IWaffIKvsJ8zEdl1PzyukLSkAdGa3iEz1TmD9hPIXBdJ98BNM6bIhjPfr+JX3b85u1pgQZZZGYIKXZtg72M8wgdOCgiWqzuSx06zDeIP7b+iRMYI5H4l6L2fyfzNl5Q1VhTRAR6k0unXekkCkDLCOFQMY3xyYQR/BGeZUkup7gTI4RQo+8EL4bIHTOWe+LCw/Ph1tFCxAjy/qctB5JZ1Rwm0rpeaEP8ji40B/FyutCkGVgIUBXw+qHdpJx5Lbxnfknm1DGvqF8vZAHunDZ8CnCcuZweIWeXiLx0UpY5aWYgZaAzFmkBzeTWgAvxwmTSw13Z2Rc4Q6NA/k7D5Mn6BNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LSswIpNmi9PEvZthD1AbpwbfzH8zN6F0xboMfvxc098=;
 b=lHW+Q7rnmimhHbQf1hZ4dtmkBdYIauhTzsleDXW5GNuVhr73bhQrcBvibUMVABDphjRYwZwbMvJIkYPSJyA2PH+7oDE+piH8m1cOUwWv6x7i1seAjnIYO88PyoZ2PuilEBvhcHPV/XWfKWSJBnT8aGDvoKY3fclVk6lTN+S0jSvjjzDdFLMABdoRL+/2or9hTVtHG6/sSH+RQfU8SOe4rK7p/OCAXo1rjxSNmiqGrbPkHlRpWKv9aoqOYLbSkjrHmN3B4mAO0/FL+cDa7YQtiXrV8ehO3cM9ra3y9gA6AU470yJVVL34PCO3n0Ds9E1YVm/dt4ypA3Yko5lEAE6WLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LSswIpNmi9PEvZthD1AbpwbfzH8zN6F0xboMfvxc098=;
 b=5x0qoZjZewrgPRX3VyO7OsQ7h2zJf+pOQSeDxeovkRxfFMfVkyGruzqqarYusqEOIWXHmHQwLm7rLHlztlC8bfjAboOo3jrVY6BmXb30NAtYXoQWc6BYViPQPZzODAbocQgyyRobV5f/6xTdLzDiDxsO3drTac0VVMJz/48ynHA=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>
Subject: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index: AQHY3lPHM2Tyba3hCkeKMW07GDOb2Q==
Date: Wed, 12 Oct 2022 16:00:41 +0000
Message-ID: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|DU0PR08MB8833:EE_|AM7EUR03FT008:EE_|DB9PR08MB6395:EE_
X-MS-Office365-Filtering-Correlation-Id: 84592cca-dc7a-4d48-88fc-08daac6af08d
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ZQ7m181cyyhG41gOIyWx1Nx4FRueFXqyZYSmtdDey8H3cStIlGz8OKcw2CM5nrQawFO0+6FDRmkXbijuD3AkQKPOStlgDzXMBo5hfMKwh3s4NZ5xTCDwc08amYc722qQnJhJdG/K921e90y7goVAoB72kad8DPymhNfe5a6pEsMBdJsZS127HZBZ8mY51cxDRBLHEWvnk3bHG8NHPcvM+opEm3WBIS68ioB1FR9nv4br8w4IqUNS0t77w3QZfY3ZETRyMEwZDNfffUVnkBoLXbV/8Hbr2rnbN7VXf/dLmBv+yb2x5ezQopJwBPZZ0zfha1YEyYw7FvC5vEmthkqV+7vsQTpwIDfL0jIIsbKOyB4s1jBaQ/+++wlVaPUNxT5RynGKWNy4ByHp+GNcWgk9u9PjJneNU8ExiD7+MlZCZDFEmSBuSkTm8VoK2L7EoQIGBCKMHG8p4WE6Opau5WCRrJqJVXp2cAPFWl6L+Ps1L0pmNfYG0YQc9mZJ6s6n31cMNpWohGdY8LGVwppd9Kbupl0g2p+J2sqM/p9lh3bQFcTGLGExW9F5/D8IzPM+gkIZNG9myNSVyUmo7bykaL6UZ6Rz9Ml/xaQCEMMLgn4wU3a9MY2dGiIFE5dhKtLoJiZqqf1wHb185SaK7QoIhFa1YRXxV/SmVF/x6sXFCWnFkYi02UAEXt9y29UWTDhXOPqB9tpPD1zp8Pomc9VwhkCUmF5/jIWQxp452hi6LeTNVyuRUjlkuN3byhcwAgB7BAP4Geb5pjAR4AD6e89V/VYsxs7sNNmhwt2feVDVPs2b/Io=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(451199015)(6506007)(6512007)(2616005)(478600001)(71200400001)(83380400001)(6486002)(26005)(38100700002)(86362001)(33656002)(186003)(38070700005)(36756003)(4326008)(66476007)(66446008)(8676002)(122000001)(6916009)(66556008)(54906003)(41300700001)(316002)(76116006)(91956017)(8936002)(5660300002)(64756008)(2906002)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <8C9806828DF30A47BC1A8C15B3940819@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8833
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7289db95-a23b-4fd1-37ba-08daac6ae9d6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JhjYRIOMmRLZtIjpTu6Yr7ubn8Mr4h/XLsZuJ9nR/y/BqwcEtHKLaLOj2+doQ1Zk5qmEzZHo+6QuGCLQskz8bkzInEfOKA9yaSZcvNp3h2VaWKBjpCr2aK4OqXgkTpROwikYTN/YAxgfaq8/xsv+OtPWI5NhZoV3crMJhgRXPDmCamTLoCPH5OW23yHYnvO4eh8B17obs2mbYcF07GD7Yr6zmAHKMcdTthA9f3gzICVrmC3ZxeGYdEMW6qgSGEjD5LhRk8DqXWorKPEctKkTHrA5cAdZBolmKGgMKVm2DlqPrWT4UOPej6x1gU8lrh5R1XHkd46miiPgFWEo6cs8HIWSqQND3PPszUDm9mVq4K39is1RDXpr+UrVXRM+O9rQjwpVqcoxh/NnAt1lLR0S0f4yYKufLpsWcAk0jGF5b6K+qbWQS9UVPkszbbXFETSN94K0KoQflGLb7+8XzEXIErCYYPnc229fCocv5rBt8CjDfZx6ili+i5iSZ9o0++eq5SifmHuGHTsT9vVl/fGDqBb9EXqH3NdL5x5tugfWeXtUUU1LBTB9ehgg2RZyHY6rSQjnQP6ShdV6c82H9nbJzQmm1EIMumFBS00Kzlf3Gtk9AKhlmZ12NWlQbPWQr0ksB0Z/1W1UVVipFToskHpvNMpycHs2VNBWUzFi7As7OXZ3pfYqC4CvXmVYcxomRFEbh75/PnfQD07Vit/rjpJBk+IK3x1aL9N6Ya94xM5AzkH65MdY4IBLPTwMmgr/y7rC0L2HATnR0oMgOczEILn4wQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(40480700001)(33656002)(36756003)(82310400005)(41300700001)(2616005)(6486002)(26005)(6506007)(6512007)(70586007)(70206006)(8676002)(478600001)(4326008)(82740400003)(356005)(81166007)(40460700003)(86362001)(336012)(186003)(5660300002)(8936002)(83380400001)(47076005)(6916009)(54906003)(2906002)(316002)(107886003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 16:00:52.7883
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 84592cca-dc7a-4d48-88fc-08daac6af08d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6395

SGkgYWxsLA0KDQpIZXJlIGlzIGEgcHJvcG9zYWwgdG8gY3JlYXRlIGEgZGV2aWF0aW9uIHN5c3Rl
bSBmb3IgYWxsIHRoZSBzdGF0aWMgYW5hbHlzZXIgZmluZGluZyBmcm9tDQpib3RoIGdlbmVyaWMg
c3RhdGljIGNvZGUgY2hlY2tlcnMgYW5kIE1JU1JBIGNvbXBsaWFuY2UsIGFzIHNhaWQgYmVmb3Jl
LCB0aGVyZSBtaWdodA0KYmUgc29tZSBjYXNlIHdoZXJlIHdlIHdvbuKAmXQgZml4IGEgcGFydCBv
ZiB0aGUgY29kZSBiZWNhdXNlIHRoZSB3YXkgaXQgaXMgd3JpdHRlbiBpcw0Kc2FmZXIgdGhhbiB0
aGUgcHJvcG9zZWQgZml4IGZyb20gdGhlIHRvb2wgb3IgY29kaW5nIGd1aWRhbmNlLg0KDQpUaGUg
cHJvcG9zZWQgdGFncyB3aWxsIGJlIHRyYW5zbGF0ZWQgYnkgYSB0b29sIGR1cmluZyB0aGUgYW5h
bHlzaXMsIHVzaW5nIHRoZSBkYXRhYmFzZSAoSlNPTiBmaWxlKSByZXBvcnRlZCBiZWxvdywNCnRo
ZSBhbmFseXNpcyBzdGVwcyB3aWxsIGJlOg0KMSkgdHJhbnNsYXRlIHRoZSDigJxYZW4gY29kZWJh
c2UgaW4tY29kZSBjb21tZW50IHRhZ3PigJ0gdG8gdGhlIHByb3ByaWV0YXJ5IHN5bnRheCBvZiB0
aGUgY2hvc2VuIHRvb2wgaW4gdGhlIHNvdXJjZSBjb2RlLg0KMikgcGVyZm9ybSB0aGUgYW5hbHlz
aXMgYW5kIHByb2R1Y2UgYSByZXBvcnQNCjMpIHJldmVydCBiYWNrIHRoZSBzb3VyY2UgY29kZSB0
byB0aGUgb3JpZ2luYWwuDQoNClRoZSBwcm9wb3NhbCBpbmNsdWRlcyBhbHNvIGZlZWRiYWNrcyBm
cm9tIHRoZSBkZXNpZ24gc2Vzc2lvbiBhYm91dCBGdVNhIGhlbGQgYXQgdGhlIFhlbiBTdW1taXQg
MjAyMi4NCg0KDQpEb2N1bWVudGluZyB2aW9sYXRpb25zDQo9PT09PT09PT09PT09PT09PT09PT09
DQoNClN0YXRpYyBhbmFseXNlcnMgYXJlIHVzZWQgb24gdGhlIFhlbiBjb2RlYmFzZSBmb3IgYm90
aCBzdGF0aWMgYW5hbHlzaXMgYW5kIE1JU1JBDQpjb21wbGlhbmNlLg0KVGhlcmUgbWlnaHQgYmUg
dGhlIG5lZWQgdG8gc3VwcHJlc3Mgc29tZSBmaW5kaW5ncyBpbnN0ZWFkIG9mIGZpeGluZyB0aGVt
IGFuZA0KbWFueSB0b29scyBwZXJtaXQgdGhlIHVzYWdlIG9mIGluLWNvZGUgY29tbWVudHMgdGhh
dCBzdXBwcmVzcyBmaW5kaW5ncyBzbyB0aGF0DQp0aGV5IGFyZSBub3Qgc2hvd24gaW4gdGhlIGZp
bmFsIHJlcG9ydC4NCg0KWGVuIGluY2x1ZGVzIGEgdG9vbCBjYXBhYmxlIG9mIHRyYW5zbGF0aW5n
IGEgc3BlY2lmaWMgY29tbWVudCB1c2VkIGluIGl0cw0KY29kZWJhc2UgdG8gdGhlIHJpZ2h0IHBy
b3ByaWV0YXJ5IGluLWNvZGUgY29tbWVudCB1bmRlcnN0YW5kYWJsZSBieSB0aGUgc2VsZWN0ZWQN
CmFuYWx5c2VyIHRoYXQgc3VwcHJlc3MgaXRzIGZpbmRpbmcuDQoNCkluIHRoZSBYZW4gY29kZWJh
c2UsIHRoZXNlIHRhZ3Mgd2lsbCBiZSB1c2VkIHRvIGRvY3VtZW50IGFuZCBzdXBwcmVzcyBmaW5k
aW5nczoNCg0KLSBTQUYtWC1zYWZlOiBUaGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxpbmUg
b2YgY29kZSBjb250YWlucyBhIGZpbmRpbmcsIGJ1dA0KICB0aGUgbm9uIGNvbXBsaWFuY2UgdG8g
dGhlIGNoZWNrZXIgaXMgYW5hbHlzZWQgYW5kIGRlbW9uc3RyYXRlZCB0byBiZSBzYWZlLg0KLSBT
QUYtWC1mYWxzZS1wb3NpdGl2ZTogVGhpcyB0YWcgbWVhbnMgdGhhdCB0aGUgbmV4dCBsaW5lIG9m
IGNvZGUgY29udGFpbnMgYQ0KICBmaW5kaW5nLCBidXQgdGhlIGZpbmRpbmcgaXMgYSBidWcgb2Yg
dGhlIHRvb2wuDQoNClNBRiBzdGFuZHMgZm9yIFN0YXRpYyBBbmFseXNlciBGaW5kaW5nLCB0aGUg
WCBpcyBhIHBsYWNlaG9sZGVyIGZvciBhIHBvc2l0aXZlDQpudW1iZXIgdGhhdCBzdGFydHMgZnJv
bSB6ZXJvLCB0aGUgbnVtYmVyIGFmdGVyIFNBRi0gc2hhbGwgYmUgaW5jcmVtZW50YWwgYW5kDQp1
bmlxdWUuDQoNCkVudHJpZXMgaW4gdGhlIGRhdGFiYXNlIHNob3VsZCBuZXZlciBiZSByZW1vdmVk
LCBldmVuIGlmIHRoZXkgYXJlIG5vdCB1c2VkDQphbnltb3JlIGluIHRoZSBjb2RlIChpZiBhIHBh
dGNoIGlzIHJlbW92aW5nIG9yIG1vZGlmeWluZyB0aGUgZmF1bHR5IGxpbmUpLg0KVGhpcyBpcyB0
byBtYWtlIHN1cmUgdGhhdCBudW1iZXJzIGFyZSBub3QgcmV1c2VkIHdoaWNoIGNvdWxkIGxlYWQg
dG8gY29uZmxpY3RzDQp3aXRoIG9sZCBicmFuY2hlcyBvciBtaXNsZWFkaW5nIGp1c3RpZmljYXRp
b25zLg0KDQpUaGUgZmlsZXMgd2hlcmUgdG8gc3RvcmUgYWxsIHRoZSBqdXN0aWZpY2F0aW9ucyBh
cmUgaW4geGVuL2RvY3MvbWlzcmEvIGFuZCBhcmUNCm5hbWVkIGFzIHNhZmUuanNvbiBhbmQgZmFs
c2UtcG9zaXRpdmUuanNvbiwgdGhleSBoYXZlIEpTT04gZm9ybWF0Lg0KDQpIZXJlIGlzIGFuIGV4
YW1wbGUgdG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb246Og0KDQp8ew0KfCAgICAidmVyc2lvbiI6
ICIxLjAiLA0KfCAgICAiY29udGVudCI6IFsNCnwgICAgICAgIHsNCnwgICAgICAgICAgICAiaWQi
OiJTQUYtMC1zYWZlIiwNCnwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQp8ICAgICAgICAgICAg
ICAgICJjcHBjaGVjayI6ICJtaXNyYS1jMjAxMi0yMC43IiwNCnwgICAgICAgICAgICAgICAgImNv
dmVyaXR5IjogIm1pc3JhX2NfMjAxMl9ydWxlXzIwXzdfdmlvbGF0aW9uIiwNCnwgICAgICAgICAg
ICAgICAgImVjbGFpciI6ICJNQzNSMS5SMjAuNyINCnwgICAgICAgICAgICB9LA0KfCAgICAgICAg
ICAgICJuYW1lIjog4oCcUjIwLjcgQyBtYWNybyBwYXJhbWV0ZXJzIG5vdCB1c2VkIGFzIGV4cHJl
c3Npb24iLA0KfCAgICAgICAgICAgICJ0ZXh0IjogIlRoZSBtYWNybyBwYXJhbWV0ZXJzIHVzZWQg
aW4gdGhpcyBb4oCmXSINCnwgICAgICAgIH0sDQp8ICAgICAgICB7DQp8ICAgICAgICAgICAgImlk
IjrigJ1TQUYtMS1zYWZlIiwNCnwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQp8ICAgICAgICAg
ICAgICAgICJjcHBjaGVjayI6ICJ1bnJlYWRWYXJpYWJsZSIsDQp8ICAgICAgICAgICAgICAgICJj
b3Zlcml0eSI6ICJVTlVTRURfVkFMVUUiDQp8ICAgICAgICAgICAgfSwNCnwgICAgICAgICAgICAi
bmFtZSI6IOKAnFZhcmlhYmxlIHNldCBidXQgbm90IHVzZWQiLA0KfCAgICAgICAgICAgICJ0ZXh0
Ijog4oCcSXQgaXMgc2FmZSBiZWNhdXNlIFvigKZdIg0KfCAgICAgICAgfSwNCnwgICAgICAgIHsN
CnwgICAgICAgICAgICAiaWQiOuKAnVNBRi0yLXNhZmUiLA0KfCAgICAgICAgICAgICJhbmFseXNl
ciI6IHt9LA0KfCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCnwgICAgICAgICAgICAi
dGV4dCI6ICIiDQp8ICAgICAgICB9DQp8ICAgIF0NCnx9DQoNClRvIGRvY3VtZW50IGEgZmluZGlu
ZywganVzdCBhZGQgYW5vdGhlciBibG9jayB7Wy4uLl19IGJlZm9yZSB0aGUgc2VudGluZWwgYmxv
Y2ssDQp1c2luZyB0aGUgaWQgY29udGFpbmVkIGluIHRoZSBzZW50aW5lbCBibG9jayBhbmQgaW5j
cmVtZW50IGJ5IG9uZSB0aGUgbnVtYmVyDQpjb250YWluZWQgaW4gdGhlIGlkIG9mIHRoZSBzZW50
aW5lbCBibG9jay4NCg0KSGVyZSBhIGJyaWVmIGV4cGxhbmF0aW9uIG9mIHRoZSBmaWVsZCBpbnNp
ZGUgYW4gb2JqZWN0IG9mIHRoZSAiY29udGVudCIgYXJyYXk6DQotIGlkOiBpdCBpcyBhIHVuaXF1
ZSBzdHJpbmcgdGhhdCBpcyB1c2VkIHRvIHJlZmVyIHRvIHRoZSBmaW5kaW5nLCBtYW55IGZpbmRp
bmcNCiAgY2FuIGJlIHRhZ2dlZCB3aXRoIHRoZSBzYW1lIGlkLCBpZiB0aGUganVzdGlmaWNhdGlv
biBob2xkcyBmb3IgYW55IGFwcGxpZWQNCiAgY2FzZS4NCiAgSXQgdGVsbHMgdGhlIHRvb2wgdG8g
c3Vic3RpdHV0ZSBhIFhlbiBpbi1jb2RlIGNvbW1lbnQgaGF2aW5nIHRoaXMgc3RydWN0dXJlOg0K
ICAvKiBTQUYtMC1zYWZlIFsuLi5dIFwqLw0KLSBhbmFseXNlcjogaXQgaXMgYW4gb2JqZWN0IGNv
bnRhaW5pbmcgcGFpciBvZiBrZXktdmFsdWUgc3RyaW5ncywgdGhlIGtleSBpcw0KICB0aGUgYW5h
bHlzZXIsIHNvIGl0IGNhbiBiZSBjcHBjaGVjaywgY292ZXJpdHkgb3IgZWNsYWlyLiBUaGUgdmFs
dWUgaXMgdGhlDQogIHByb3ByaWV0YXJ5IGlkIGNvcnJlc3BvbmRpbmcgb24gdGhlIGZpbmRpbmcs
IGZvciBleGFtcGxlIHdoZW4gY292ZXJpdHkgaXMNCiAgdXNlZCBhcyBhbmFseXNlciwgdGhlIHRv
b2wgd2lsbCB0cmFuc2xhdGUgdGhlIFhlbiBpbi1jb2RlIGNvbWVudCBpbiB0aGlzIHdheToNCiAg
LyogU0FGLTAtc2FmZSBbLi4uXSBcKi8gLT4gLyogY292ZXJpdHlbY292ZXJpdHktaWRdIFwqLw0K
ICBpZiB0aGUgb2JqZWN0IGRvZXNuJ3QgaGF2ZSBhIGtleS12YWx1ZSwgdGhlbiB0aGUgY29ycmVz
cG9uZGluZyBpbi1jb2RlDQogIGNvbW1lbnQgd29uJ3QgYmUgdHJhbnNsYXRlZC4NCi0gbmFtZTog
YSBzaW1wbGUgbmFtZSBmb3IgdGhlIGZpbmRpbmcNCi0gdGV4dDogYSBwcm9wZXIganVzdGlmaWNh
dGlvbiB0byB0dXJuIG9mZiB0aGUgZmluZGluZy4NCg0KDQoNCkhlcmUgYW4gZXhhbXBsZSBvZiB0
aGUgdXNhZ2Ugb2YgdGhlIGluLWNvZGUgY29tbWVudCB0YWdzOg0KDQovKiBTQUYtMC1zYWZlIFtl
dmVudHVhbCBkZXZlbG9wZXIgbWVzc2FnZSB0aGF0IHNoYWxsIG5vdCBleGNlZWRzIGxpbmUgY2hh
ciBtYXggY291bnQsIGRvbuKAmXQgYnJlYWsgdGhlIGxpbmUhXSAqLw0KI2RlZmluZSBzdHJpbmdf
cGFyYW0oX25hbWUsIF92YXIpIFwNCiAgICBfX3NldHVwX3N0ciBfX3NldHVwX3N0cl8jI192YXJb
XSA9IF9uYW1lOyBcDQogICAgX19rcGFyYW0gX19zZXR1cF8jI192YXIgPSBcDQogICAgICAgIHsg
Lm5hbWUgPSBfX3NldHVwX3N0cl8jI192YXIsIFwNCiAgICAgICAgICAudHlwZSA9IE9QVF9TVFIs
IFwNCiAgICAgICAgICAubGVuID0gc2l6ZW9mKF92YXIpLCBcDQogICAgICAgICAgLnBhci52YXIg
PSAmX3ZhciB9DQoNCkluIHRoZSBleGFtcGxlIGFib3ZlLCB0aGUgdG9vbCBmaW5kaW5nIGZvciB0
aGlzIG1hY3JvIGlzIHN1cHByZXNzZWQuIFdoZW4gdGhlcmUgYXJlIG11bHRpcGxlIGZpbmRpbmdz
IGZvcg0KdGhlIHNhbWUgbGluZSwgbXVsdGlwbGUgaW4tY29kZSBjb21tZW50cyBuZWVkcyB0byBi
ZSBpbnNlcnRlZCwgZXZlcnkgb25lIG9uIGEgZGlmZmVyZW50IGxpbmUuDQoNCkNoZWVycywNCkx1
Y2E=


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 16:57:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 16:57:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421307.666545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oif2z-0008S4-Fq; Wed, 12 Oct 2022 16:57:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421307.666545; Wed, 12 Oct 2022 16:57:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oif2z-0008Rx-CS; Wed, 12 Oct 2022 16:57:33 +0000
Received: by outflank-mailman (input) for mailman id 421307;
 Wed, 12 Oct 2022 16:57:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oif2y-0008Rn-15; Wed, 12 Oct 2022 16:57:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oif2x-00020p-TX; Wed, 12 Oct 2022 16:57:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oif2x-0007xT-Lt; Wed, 12 Oct 2022 16:57:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oif2x-0007LP-LO; Wed, 12 Oct 2022 16:57:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a0F1+s7imOAclgqJEd+9TGb7E+7HNJ8E7m6CIUyrXsc=; b=lFcot+8AX0GFPNDP+AcTpqvQ0T
	PtBw4EGMCL59xZ1LN+6ROkY3O1gLWa78g5Vj17Sdz7iRXmzh+qwYjT4nTb+65esj2NegPIRLRcFfB
	zne2jNQIYELDEzCv+8ygC9d1H2A9ycCRda0D80WxQYvfhJ1s9/t8/X+89/lD7MdP83Yg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173546-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173546: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:build-arm64:xen-build:fail:regression
    xen-4.15-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64-xsm:xen-build:fail:regression
    xen-4.15-testing:build-amd64:xen-build:fail:regression
    xen-4.15-testing:build-i386-xsm:xen-build:fail:regression
    xen-4.15-testing:build-i386:xen-build:fail:regression
    xen-4.15-testing:build-armhf:xen-build:fail:regression
    xen-4.15-testing:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-livepatch:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-migrupgrade:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pair:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-1:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-2:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-3:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-4:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-xtf-amd64-amd64-5:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    xen=9690bb261d5fa09cb281e1fa124d93db7b84fda5
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 16:57:31 +0000

flight 173546 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173546/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172547
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64                   6 xen-build                fail REGR. vs. 172547
 build-i386-xsm                6 xen-build                fail REGR. vs. 172547
 build-i386                    6 xen-build                fail REGR. vs. 172547
 build-armhf                   6 xen-build                fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-amd64-coresched-amd64-xl  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-shadow    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-rtds      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ws16-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qemut-ws16-amd64  1 build-check(1)             blocked n/a
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qcow2     1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvshim    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-intel  1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-intel  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit2   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-amd64-livepatch    1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-intel  1 build-check(1)              blocked n/a
 test-amd64-amd64-migrupgrade  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pair         1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pygrub       1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-freebsd11-amd64  1 build-check(1)           blocked n/a
 test-amd64-amd64-qemuu-freebsd12-amd64  1 build-check(1)           blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-1        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-2        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-3        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-4        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-5        1 build-check(1)               blocked  n/a

version targeted for testing:
 xen                  9690bb261d5fa09cb281e1fa124d93db7b84fda5
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   58 days
Testing same since   173494  2022-10-11 13:38:08 Z    1 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              fail    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64-xtf                                              pass    
 build-amd64                                                  fail    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       blocked 
 test-xtf-amd64-amd64-2                                       blocked 
 test-xtf-amd64-amd64-3                                       blocked 
 test-xtf-amd64-amd64-4                                       blocked 
 test-xtf-amd64-amd64-5                                       blocked 
 test-amd64-amd64-xl                                          blocked 
 test-amd64-coresched-amd64-xl                                blocked 
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        blocked 
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         blocked 
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      blocked 
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            blocked 
 test-amd64-amd64-xl-pvhv2-amd                                blocked 
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              blocked 
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       blocked 
 test-amd64-amd64-qemuu-freebsd12-amd64                       blocked 
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         blocked 
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         blocked 
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  blocked 
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  blocked 
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        blocked 
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          blocked 
 test-amd64-amd64-xl-pvhv2-intel                              blocked 
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   blocked 
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 blocked 
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                blocked 
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        blocked 
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   blocked 
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     blocked 
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   blocked 
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 689 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 17:12:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 17:12:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421320.666567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oifH4-0002ZA-WA; Wed, 12 Oct 2022 17:12:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421320.666567; Wed, 12 Oct 2022 17:12:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oifH4-0002Z3-Td; Wed, 12 Oct 2022 17:12:06 +0000
Received: by outflank-mailman (input) for mailman id 421320;
 Wed, 12 Oct 2022 17:12:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oifH3-0002Yt-T4; Wed, 12 Oct 2022 17:12:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oifH3-0002HU-SG; Wed, 12 Oct 2022 17:12:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oifH3-00007M-Gi; Wed, 12 Oct 2022 17:12:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oifH3-0001Fu-GG; Wed, 12 Oct 2022 17:12:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xIu6gURyVyL8xe+z6ajUlbLFKWS6yyh/9C8mKGdVaaI=; b=ilRkT3pZJLjw0IsYN7YH3Eu1rB
	QPubjYQ5VZ3eUH7G7zCPmNv3jT1nVpuuIyUrB4TzVaXWPm9QnokB1LBLbdVkIZkG9dn62H1IB3yj2
	oTjLF0wzdtvguBBdAyTp54ip/pKK/eRPxKVA5hECGs0o+6u05YISCGObroFlOv5INUVI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173553-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173553: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=03710322893afb4d0efb57781dd07c2aa9cbb9e8
X-Osstest-Versions-That:
    ovmf=f80580f56b267c96f16f985dbf707b2f96947da4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 17:12:05 +0000

flight 173553 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173553/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 03710322893afb4d0efb57781dd07c2aa9cbb9e8
baseline version:
 ovmf                 f80580f56b267c96f16f985dbf707b2f96947da4

Last test of basis   173485  2022-10-10 10:41:48 Z    2 days
Testing same since   173553  2022-10-12 06:10:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Qi Zhang <qi1.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f80580f56b..0371032289  03710322893afb4d0efb57781dd07c2aa9cbb9e8 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 18:26:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 18:26:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421345.666607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oigQs-0002VT-S5; Wed, 12 Oct 2022 18:26:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421345.666607; Wed, 12 Oct 2022 18:26:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oigQs-0002VM-OG; Wed, 12 Oct 2022 18:26:18 +0000
Received: by outflank-mailman (input) for mailman id 421345;
 Wed, 12 Oct 2022 18:26:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7nFe=2N=citrix.com=prvs=277557e37=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oigQq-00020j-Tr
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 18:26:17 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59b6f80e-4a5b-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 20:26:14 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59b6f80e-4a5b-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665599174;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=A8MzLqExStAlbN29a+wsKio2UVeipAQb6TPTHKe3Ju4=;
  b=B3Q3/UB0cQM+If+L59wPyiSB15hYT9PD6mO/xKPBMvt3o8RAIHQUwgmR
   RBDZoIzgQJY6r0Ca456wwkWjSGiaXo/DuBy3qEuTsQekzLLs4AQy1mzq6
   RQYunV+3zE0faXCCh2eomRUXoDruF2LOB4EvtYxBoCQxgSzKW+0dk+yF/
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81698666
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ld4uO6Cu2vJ0JRVW/znjw5YqxClBgxIJ4kV8jS/XYbTApDJ2gTcBm
 2sZCj+DbqmPNGH3LY9xbI21/U4BsJbXyIIwQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2o4GhwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k6IbQ83+d6JFgXy
 vAVFiEQXiijp8yplefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN
 5FxhTlHNXwsZzVmPFsNBY14t+CvnnTlKBVTqU6PpLpx6G/WpOB0+Oi0bouFJILULSlTtm2Vh
 Uv9/l78PhxAZNmZwGa70l+XouCayEsXX6pNTeblp5aGmma75mEVEgxQalK9rtGwkEv4UNVaQ
 2QY8zQjhbI//0uqSp/6RRLQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6cLqScCj
 wHT2YmzXHo27ePTGSn1GqqoQS2aNTQsCUoDaAo9FDQJ7ufyvbELrjLhUYM2eEKqteHdFTb1y
 jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQKDhcusOrp1WbVoU
 JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD327xk5JAVdoKiN2bGKuPGpxdEdMOS
 BaL0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZonwzPBXJgDG9wRFEfUQD1
 XGzK5/E4ZEyUP0P8dZLb71Fje9DKt4Wnws/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0Z5oVD79q
 o8HX/ZmPj0FD4USlAGLrtNIRb3LRFBnba3LRzt/KrbffFI7SD54VZc8A9oJIuRYokicrc+Ql
 lnVZ6OS4AOXaaHvQelSVk1eVQ==
IronPort-HdrOrdr: A9a23:Tntm6KndI+eQmoae1kcQQn6La8bpDfIu3DAbv31ZSRFFG/Fxl6
 iV8sjztCWE8Qr5N0tBpTntAsW9qDbnhPtICOoqTNGftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAs9D4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81698666"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Edwin Torok
	<edvin.torok@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: [PATCH 1/2] tools/ocaml/xc: Fix code legibility in stub_xc_domain_create()
Date: Wed, 12 Oct 2022 19:25:51 +0100
Message-ID: <20221012182552.26866-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221012182552.26866-1-andrew.cooper3@citrix.com>
References: <20221012182552.26866-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

Reposition the defines to match the outer style and to make the logic
half-legible.

No functional change.

Fixes: 0570d7f276dd ("x86/msr: introduce an option for compatible MSR behavior selection")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Edwin Torok <edvin.torok@citrix.com>
CC: Rob Hoes <Rob.Hoes@citrix.com>
CC: Henry Wang <Henry.Wang@arm.com>
---
 tools/ocaml/libs/xc/xenctrl_stubs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index 19335bdf4572..fe9c00ce008a 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -232,22 +232,20 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config
 
         /* Mnemonics for the named fields inside xen_x86_arch_domainconfig */
 #define VAL_EMUL_FLAGS          Field(arch_domconfig, 0)
+#define VAL_MISC_FLAGS          Field(arch_domconfig, 1)
 
 		cfg.arch.emulation_flags = ocaml_list_to_c_bitmap
 			/* ! x86_arch_emulation_flags X86_EMU_ none */
 			/* ! XEN_X86_EMU_ XEN_X86_EMU_ALL all */
 			(VAL_EMUL_FLAGS);
 
-#undef VAL_EMUL_FLAGS
-
-#define VAL_MISC_FLAGS          Field(arch_domconfig, 1)
-
 		cfg.arch.misc_flags = ocaml_list_to_c_bitmap
 			/* ! x86_arch_misc_flags X86_ none */
 			/* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */
 			(VAL_MISC_FLAGS);
 
 #undef VAL_MISC_FLAGS
+#undef VAL_EMUL_FLAGS
 
 #else
 		caml_failwith("Unhandled: x86");
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 18:26:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 18:26:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421343.666585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oigQq-00020v-Ca; Wed, 12 Oct 2022 18:26:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421343.666585; Wed, 12 Oct 2022 18:26:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oigQq-00020o-9Z; Wed, 12 Oct 2022 18:26:16 +0000
Received: by outflank-mailman (input) for mailman id 421343;
 Wed, 12 Oct 2022 18:26:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7nFe=2N=citrix.com=prvs=277557e37=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oigQp-00020d-K4
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 18:26:15 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 58d09f9a-4a5b-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 20:26:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58d09f9a-4a5b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665599173;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=7gcIJHv4jTLn96F6AZo74LCpJ+cpgBI5tr82v/YixPU=;
  b=Gup7k1PJWrpjjyq95oPyIv/3btHyqoD4M/ZbwPwWB4TyfbYYTuqgik2k
   tziK4J3Du8BZ4USsSphJfZuU0EjGr6faWRri/V5UXc4ygi3e8mgpKIz7i
   Fr4poWpyKbBdoqhiuzU2VHNsklGsGsWesACf4H/Kyj6CAAfIdFQrEauHh
   s=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82575650
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Az9EOaxApbVR83qm+I96t+cnxirEfRIJ4+MujC+fZmUNrF6WrkUAy
 WFLCjqGMqzZY2b8fd8ib9+wp0gFvsKBxtM3Hgs//CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB5ARlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5NRbGlpkx
 8wkMh8KNSKYntyS/IyYVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP
 pdHL2o0BPjDS0Qn1lM/IZQyhuq3wFL4dCVVsgm9rqsr+WnDigd21dABNfKFIIHVGJsIxi50o
 Er8+2ulLw4nH+aDyCWkzlaWgvbQnn30Ddd6+LqQqacx3Qz7KnYoID0bU0Gq58awjEGWUshab
 UcT/0IGoaEs+WSxQ9L6Xhn+p2SL1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC6
 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBXEwSTQ/Zzk138PMp9oBlQvxaupdM7Hg27UZBgrM6
 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVrv1uKBwpJ+is8Pdf4PNLwtTA3+N4adO6kok+9U
 G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb5Iei8Axkkfi+F1/ronxezO
 Sc/XisIvPdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxDNgjm2yRd9wfBmU
 Xt+TSpKJSxDYUiA5GPvL9rxLJdxnnxurY8tbcqTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDjoH
 yJkH5LTk31ivBjWOHa/HXg7cQ9XdhDWxPne96RqSwJ0ClY+RD95Vq+OmO1Jlk4Mt/09q9okN
 0qVAidwoGcTT1WeQelWQhiPsI/SYKs=
IronPort-HdrOrdr: A9a23:1q7i56o+COkqduVb15RlxtsaV5ojeYIsimQD101hICG8cqSj9v
 xG/c5rsyMc5wxhO03I9eruBEDiewK6yXcW2/hyAV7KZmCP0wHEQL2KhbGSpwEIcBefygcy78
 ldmtBFebjNMWQ=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82575650"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Edwin Torok
	<edvin.torok@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: [PATCH for-4.17 0/2] Ocaml stub fixes
Date: Wed, 12 Oct 2022 19:25:50 +0100
Message-ID: <20221012182552.26866-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Patch 1 is purely some a tweak to improve legibility.  It's not necessary for
4.17 but it's also 0 risk to take as well.

Patch 2 is a change to an ABI which was newly introduced in 4.17.  It is
suboptimal for two reasons and specifically does want changing before 4.17
ships.  See patch for details.

Andrew Cooper (2):
  tools/ocaml/xc: Fix code legibility in stub_xc_domain_create()
  tools/ocaml/xc: Address ABI issues with physinfo arch flags

 tools/ocaml/libs/xc/xenctrl.ml      | 10 ++++++----
 tools/ocaml/libs/xc/xenctrl.mli     | 11 +++++++----
 tools/ocaml/libs/xc/xenctrl_stubs.c | 28 ++++++++++++++--------------
 3 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 18:26:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 18:26:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421344.666595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oigQr-0002GF-JE; Wed, 12 Oct 2022 18:26:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421344.666595; Wed, 12 Oct 2022 18:26:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oigQr-0002G8-GM; Wed, 12 Oct 2022 18:26:17 +0000
Received: by outflank-mailman (input) for mailman id 421344;
 Wed, 12 Oct 2022 18:26:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7nFe=2N=citrix.com=prvs=277557e37=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oigQq-00020d-1p
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 18:26:16 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 594525bf-4a5b-11ed-8fd0-01056ac49cbb;
 Wed, 12 Oct 2022 20:26:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 594525bf-4a5b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665599172;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=3Qjvk2FsC2aL9utAcIX9UxVQ2DyGvaU7wX3c+UI0SBU=;
  b=XYLwjkQs/OajDfuOCWv/gcHi25mHm9nu0fgmZ/izhk9cSrCRBo9b/Edd
   I10MeGnVSnk+25OXayEYA+1VLtlqmWNmLiMt/DmW5nAyDGcWUZp51l+0j
   str9ZTz2j4bVKI2ki5+IAUvY3+2Y+CCXZ+zTqvJuv47xOLRDK6UlV5gzx
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82599032
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AILbUX61R0z4PK7LKzvbDix16xbzCYnBdZch4h?=
 =?us-ascii?q?dh9DyJ0z/GscokSnZKBI4ySk/ScjpLhhS12IhzijssjrW0y4farjUk4fX+vy?=
 =?us-ascii?q?cz0/4boJhEnr1zCI2gG7gzYZWLLPCORpyD9k8JlqGXvc9aH1vMoz8hiHpjUs?=
 =?us-ascii?q?15WsCX/TMy6HEBfafa+1+CbQpGhXXZnCPipiUYQtFP9HyrjnezApG3JgOzM6?=
 =?us-ascii?q?rm1rSFyQBbgMd90gmYkf6nft1TSJOM/+uYLf8P/MzntOFiBOdpJkV9GAk8cU?=
 =?us-ascii?q?1Rg160lknFhwiLghV38brwctft7jkhbmLGOrKfeFE95aSUdZcp+P4yXjfEJB?=
 =?us-ascii?q?NbqZjD3Wr38ehHUndMDq10ZX7QDVsw0W7NFewUZETuD/It64HTeBhWgE3Fsu?=
 =?us-ascii?q?l9FcLnOBpyQOcaxWR+q2sMoWLKXROolj2Flj2vQoAZbFEnq+QasiP+Vpk73C?=
 =?us-ascii?q?Pm9O/n+laQbJALyYcFUTaaeX+k7GDMYhaYw3qbFVBodN5uSW79UYzAbhnUq+?=
 =?us-ascii?q?p2oiEITIdn7mhu6plCe11P1v1cDocToKk45YhaOUiOR5dEqDiKfG/Oiaptdx?=
 =?us-ascii?q?m7eJ9fIxbWy16+VD9mzG+w5dPprfZ09PgGO8gXBIuFeeKiRfXjGOl2jOgxI9?=
 =?us-ascii?q?2vly59xtw2udID++NhHSee8+/eiPX7+wTAzaEWqN+BPEvm+v6zihRUS918Bm?=
 =?us-ascii?q?mKd/P1cOz1UIqEaumlx6zOWtd5jijCJpQqtFFMUdLYmk0vzhrx9E2623oeMy?=
 =?us-ascii?q?yBkFgZmttc+24WCo9AqXl/W9/rfU2K2Dh8ELNK1HivJ0XpWJ7SVFjMctKSEt?=
 =?us-ascii?q?tWP9raeuv+IGukNlx14qjYXi/Bo9KrB9/hMOj9wqjkaBl0ppwF3HpPCs/9y2?=
 =?us-ascii?q?lJn/yHHRc53mmMjdXO0DWPx+asx8VB6gnGwnXRaHA+V5EpHnPm08IZ/tZC67?=
 =?us-ascii?q?+iMzI2VXyqNqMYYAkXjo7uH2ZmNhoi0Yjvxz/AxljNZFjdr2qamPCTcp3PSq?=
 =?us-ascii?q?vfQGIJwRb1oVxK4zhurOLXiaLgcUsbodEoaSuZdmvKqlKOi1WUKYYNLOxy11?=
 =?us-ascii?q?H9MVqi8vE4cZJyZWtGKzgvrO6ykHK0yA1t8Wl1Tv3yMmjbTc1KUHky1wk7VR?=
 =?us-ascii?q?xq/146kMuAI0oGdEKrMf0f/bR2o0CX8X1+4WPi6PCXHiUoMOVc0DdEW41zfy?=
 =?us-ascii?q?owfxaHLJ2OQbopLvmOFYSHOf5dqusKNIiyuVh7fJeKtDWTBeWfv+NrPH6ruH?=
 =?us-ascii?q?Z+K4mb0RY8Sko423OQeXFRe5FYs5F0ewboUsJVVXO0nTgwYbZVFcD8ZnLFMO?=
 =?us-ascii?q?K+7YSfnVu84tvvMByjOWp4GmpVYut/mTGrPLqjh14Z5nyAdhCbM9FoQcp157?=
 =?us-ascii?q?utDPTAxf0cg6jQi6h0Ywv8kdVkPML9/dYusTfACj3cydN7W+e9KZme0QuZsK?=
 =?us-ascii?q?zGh60KKR15Rs2c6joC9Ro43V4EGM2e5pQ2Vu18N7Xxjqm9LkAU9BBCC5xMcP?=
 =?us-ascii?q?hMhpkUSc2Wkdy2BU7jKZrYNIjV8cv03tXve7bfEWbx46peTTlJFfr3D12/RO?=
 =?us-ascii?q?iC0ZjqDCJa5iVDl/kvPpr3apyyjRdCsd9xGMzyvnoLdmWg7gbb4LdW5y+dVw?=
 =?us-ascii?q?76+Ho4o64gZ7ZrbcTbNGiglCPmYl9Iz15fdZ58zNu4GJxSSUJJk8SBS2pU6S?=
 =?us-ascii?q?OLmSMMaARtozxK0CavUr1PcAueWoi/wptvn++44rovLVfzg30Ic5+HpjNxGy?=
 =?us-ascii?q?tKRd1PstLy2ics/KpaPO0lG6yGkxEQvswpGHN8B4ZhHSECoMxGw81fNShjIr?=
 =?us-ascii?q?SqrFxoJ3s5iwcOnygAHdshl5dEKO7CIemHZqYuFq2/gnasTPAH3IuUSvyk60?=
 =?us-ascii?q?cefyIXfdkc9D1i4XgbtXWAxLLA1lVANYHaouEh+biJpTz10+HmkFvPNqPU3h?=
 =?us-ascii?q?aBa0ChXRqk6JNZlaNHKLXRPB3lvlCyvi0vJJJavc5jpAwsPNM26hLzbE+4Yz?=
 =?us-ascii?q?00wzGC2otlRVb4GLHWkUKV7W3fqSsweRePFPjEqrvwOKG1+PLOFuqnKYHRy2?=
 =?us-ascii?q?w8+i2A2YXIdyLNfxinfY2bZR9Tkb1T2pMGjQN0gwODSQhX3GaGOftAMWnd1a?=
 =?us-ascii?q?+/7xqD0QXWh2WJuCS8zIA03JYHUI7fNCwpi+KS5lJligaStqFWfYhWzFN1EV?=
 =?us-ascii?q?Jq0G6xYOuNuIRxrIdzqIcnGAZrKDEqvDoKjAEEwA/eW/YLIXhWH5/lHTTufH?=
 =?us-ascii?q?d42XXLwve3NWH4bcpAPuvFT0wUshlSiru6ibnHIpCMEf/mcKxW9nioECzbhT?=
 =?us-ascii?q?VqgTCalMAyNx2MyQ70dtEHxPZYbo6lvR6HgbbjjjfxN5/6E2AQlKfVvpLqbk?=
 =?us-ascii?q?YXU1bi0RRVU/YfQG+p09sKZ/Z/jL2BziuSJ8p6rXlCWqqG1c4NPGksX7KXSg?=
 =?us-ascii?q?iPva7BPUxOc1vRPdI/mrCy5JbYCtDdBamn7UhOMNUvnISJh7ETJjYCoSDRS5?=
 =?us-ascii?q?7PbP1Q5bL3mrSaPhA+zzMd97dscd1VsahvEEYhi3b6/9sWBVU7ffIZOqXImo?=
 =?us-ascii?q?eZ4b5k0xiNB43lZy9eZl2iGjADQmOClxyCt18RXg0CA4isZ64YSe//DQ+tnR?=
 =?us-ascii?q?r54yKIOxW7Xn5g4x6hqLy2/+9PMTzzgYIStRgI+Uil9mF9EAJZsNOPIEc+I5?=
 =?us-ascii?q?2vqYURvSbEqxYbZWf/8o0P0trj2R1urXkBtkIc/yWLtq/dIVfO73TYh24glQ?=
 =?us-ascii?q?0ARvfEDmoUPjVMJV8RUtnyg4f0++L22S++8eKr2d9lpuYslMU6vswpOsfNYt?=
 =?us-ascii?q?766dVVHzMoI59s7G+J/iE8PnFcFqWKg+0+I1bUCHfSYww=3D=3D?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82599032"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Edwin Torok
	<edvin.torok@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo arch flags
Date: Wed, 12 Oct 2022 19:25:52 +0100
Message-ID: <20221012182552.26866-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221012182552.26866-1-andrew.cooper3@citrix.com>
References: <20221012182552.26866-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

The current bindings function, but the preexisting

  type physinfo_arch_cap_flag =
         | X86 of x86_physinfo_arch_cap_flag

is a special case in the Ocaml type system with an unusual indirection, and
will break when a second option, e.g. `| ARM of ...` is added.

Also, the position the list is logically wrong.  Currently, the types express
a list of elements which might be an x86 flag or an arm flag (and can
intermix), whereas what we actually want is either a list of x86 flags, or a
list of ARM flags (that cannot intermix).

Rework the Ocaml types to avoid the ABI special case and move the list
primitive, and adjust the C bindings to match.

Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware virtualized APIC")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Edwin Torok <edvin.torok@citrix.com>
CC: Rob Hoes <Rob.Hoes@citrix.com>
CC: Henry Wang <Henry.Wang@arm.com>
---
 tools/ocaml/libs/xc/xenctrl.ml      | 10 ++++++----
 tools/ocaml/libs/xc/xenctrl.mli     | 11 +++++++----
 tools/ocaml/libs/xc/xenctrl_stubs.c | 22 ++++++++++++----------
 3 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
index 0c71e5eef3c7..28ed6422317c 100644
--- a/tools/ocaml/libs/xc/xenctrl.ml
+++ b/tools/ocaml/libs/xc/xenctrl.ml
@@ -130,13 +130,15 @@ type physinfo_cap_flag =
 	| CAP_Gnttab_v1
 	| CAP_Gnttab_v2
 
+type arm_physinfo_cap_flag
 
-type x86_physinfo_arch_cap_flag =
+type x86_physinfo_cap_flag =
 	| CAP_X86_ASSISTED_XAPIC
 	| CAP_X86_ASSISTED_X2APIC
 
-type physinfo_arch_cap_flag =
-	| X86 of x86_physinfo_arch_cap_flag
+type arch_physinfo_cap_flags =
+	| ARM of arm_physinfo_cap_flag list
+	| X86 of x86_physinfo_cap_flag list
 
 type physinfo =
 {
@@ -151,7 +153,7 @@ type physinfo =
 	(* XXX hw_cap *)
 	capabilities     : physinfo_cap_flag list;
 	max_nr_cpus      : int;
-	arch_capabilities : physinfo_arch_cap_flag list;
+	arch_capabilities : arch_physinfo_cap_flags;
 }
 
 type version =
diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli
index a8458e19ca4b..c2076d60c970 100644
--- a/tools/ocaml/libs/xc/xenctrl.mli
+++ b/tools/ocaml/libs/xc/xenctrl.mli
@@ -115,12 +115,15 @@ type physinfo_cap_flag =
   | CAP_Gnttab_v1
   | CAP_Gnttab_v2
 
-type x86_physinfo_arch_cap_flag =
+type arm_physinfo_cap_flag
+
+type x86_physinfo_cap_flag =
   | CAP_X86_ASSISTED_XAPIC
   | CAP_X86_ASSISTED_X2APIC
 
-type physinfo_arch_cap_flag =
-  | X86 of x86_physinfo_arch_cap_flag
+type arch_physinfo_cap_flags =
+  | ARM of arm_physinfo_cap_flag list
+  | X86 of x86_physinfo_cap_flag list
 
 type physinfo = {
   threads_per_core : int;
@@ -133,7 +136,7 @@ type physinfo = {
   scrub_pages      : nativeint;
   capabilities     : physinfo_cap_flag list;
   max_nr_cpus      : int; (** compile-time max possible number of nr_cpus *)
-  arch_capabilities : physinfo_arch_cap_flag list;
+  arch_capabilities : arch_physinfo_cap_flags;
 }
 type version = { major : int; minor : int; extra : string; }
 type compile_info = {
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index fe9c00ce008a..03f4cbf93cd3 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -716,9 +716,10 @@ CAMLprim value stub_xc_send_debug_keys(value xch, value keys)
 CAMLprim value stub_xc_physinfo(value xch)
 {
 	CAMLparam1(xch);
-	CAMLlocal4(physinfo, cap_list, x86_arch_cap_list, arch_cap_list);
+	CAMLlocal2(physinfo, cap_list);
+	CAMLlocal2(arch_cap_flags, arch_cap_list);
 	xc_physinfo_t c_physinfo;
-	int r;
+	int r, arch_cap_flags_tag;
 
 	caml_enter_blocking_section();
 	r = xc_physinfo(_H(xch), &c_physinfo);
@@ -748,18 +749,19 @@ CAMLprim value stub_xc_physinfo(value xch)
 	Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1));
 
 #if defined(__i386__) || defined(__x86_64__)
-	x86_arch_cap_list = c_bitmap_to_ocaml_list
-		/* ! x86_physinfo_arch_cap_flag CAP_X86_ none */
+	arch_cap_list = c_bitmap_to_ocaml_list
+		/* ! x86_physinfo_cap_flag CAP_X86_ none */
 		/* ! XEN_SYSCTL_PHYSCAP_X86_ XEN_SYSCTL_PHYSCAP_X86_MAX max */
 		(c_physinfo.arch_capabilities);
-	/*
-	 * arch_capabilities: physinfo_arch_cap_flag list;
-	 */
-	arch_cap_list = x86_arch_cap_list;
+
+	arch_cap_flags_tag = 1; /* tag x86 */
 #else
-	arch_cap_list = Val_emptylist;
+	caml_failwith("Unhandled architecture");
 #endif
-	Store_field(physinfo, 10, arch_cap_list);
+
+	arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag);
+	Store_field(arch_cap_flags, 0, arch_cap_list);
+	Store_field(physinfo, 10, arch_cap_flags);
 
 	CAMLreturn(physinfo);
 }
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 12 19:10:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 19:10:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421378.666630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oih7L-0000Bi-8d; Wed, 12 Oct 2022 19:10:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421378.666630; Wed, 12 Oct 2022 19:10:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oih7L-0000Bb-5Z; Wed, 12 Oct 2022 19:10:11 +0000
Received: by outflank-mailman (input) for mailman id 421378;
 Wed, 12 Oct 2022 19:10:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oih7K-0000BR-Hh; Wed, 12 Oct 2022 19:10:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oih7K-0004Qd-Da; Wed, 12 Oct 2022 19:10:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oih7K-0008Mw-2D; Wed, 12 Oct 2022 19:10:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oih7K-0001GL-1l; Wed, 12 Oct 2022 19:10:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5QMEWWCiIt7/I6HTNgSUzs2l2+LunOE3jPNUZ5cCaEA=; b=11cs3vhPP3ERhg9TJEWs6j40br
	Oxb10wYGQ5FD+Px1b6zn5BiPLnRXjNbDmVQaj2e4IGHj+2shkJh/+G/96Fww/cF3Yk/44iB6yiWRh
	/MLl9YeLvqDYA5uiTrVp0QUUF9SRcat514RDcGAxo+T4tclvol2wRsPeE5yS7JIEvwio=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173604-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173604: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 19:10:10 +0000

flight 173604 xen-unstable-smoke real [real]
flight 173613 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173604/
http://logs.test-lab.xenproject.org/osstest/logs/173613/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    5 days
Testing same since   173492  2022-10-11 13:01:50 Z    1 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 427 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 20:04:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 20:04:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421398.666652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oihy5-00060I-GX; Wed, 12 Oct 2022 20:04:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421398.666652; Wed, 12 Oct 2022 20:04:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oihy5-00060B-Dt; Wed, 12 Oct 2022 20:04:41 +0000
Received: by outflank-mailman (input) for mailman id 421398;
 Wed, 12 Oct 2022 20:04:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oihy4-000601-KJ; Wed, 12 Oct 2022 20:04:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oihy4-0005Uq-Fx; Wed, 12 Oct 2022 20:04:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oihy4-0004ZT-1P; Wed, 12 Oct 2022 20:04:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oihy4-0000QJ-0N; Wed, 12 Oct 2022 20:04:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A41G2OCPPIa38n+kuSgdvuNnwH3Gt+724vwxjBEt7kw=; b=FPO96KxzxH8c8PY1Y4+yUXGq+J
	hx7flEO2PSpjxDTMeiOu/iocxzcQHPcfrGno2A5XrCwAuES32F9q44fCP+SWU1dZliSN4uRCAZuUn
	PcYClL9s7FuoL1HChWA04hEna1efbedvPWvFr9OqCDe8w8yo4zkiNsEkDA1gWu/0iP6o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173534-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173534: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:build-arm64-pvops:kernel-build:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-coresched-i386-xl:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=42e1e350bffc8d4614e568a03380b2ec34a131bf
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 20:04:40 +0000

flight 173534 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173534/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build   fail in 173497 REGR. vs. 173447

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 173497 pass in 173534
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 173497
 test-amd64-coresched-i386-xl 20 guest-localmigrate/x10     fail pass in 173497

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-xl           1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 173497 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 173497 n/a
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                42e1e350bffc8d4614e568a03380b2ec34a131bf
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z    6 days
Testing same since   173497  2022-10-11 15:38:33 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Hildenbrand <david@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 42e1e350bffc8d4614e568a03380b2ec34a131bf
Merge: f1d33f55c4 94d788408d
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Tue Oct 11 09:31:19 2022 -0400

    Merge tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging
    
    dump patches
    
    Hi
    
    Includes:
    - the first patches from "[PATCH v5 00/18] dump: Add arch section and s390x PV dump"
    - "[PATCH v2 0/2] Fix dumping in kdump format with non-aligned memory"
    
    # -----BEGIN PGP SIGNATURE-----
    #
    # iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmM+9UocHG1hcmNhbmRy
    # ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5aoMD/0eya5IqxX0ke9jjUcB
    # wWhRbsVdiO9yt2oN3gsQVkUtuK98p7/JpWSKHWXsQQjd7vIYPCj8RBHXZ4Cp71+S
    # n+Db/K22fmWvuP0LtCNzYujq1ZxKdQI8KdKmYwHQdGkgy85QwYO+0SgpVgLjRd/2
    # 1IWzHuzIcEmraxkSLvR8N0lmz/Z2CBc7ME5izO1mHSZrs8Ria2tDpXnz5rFxPy+q
    # TDqo+LP0GIapoHbbE+6JWGL2u9mLiP0sg9SclZOPZG3CsPQ5XYEStyZcLw1YYIO1
    # rruom463SbP4NJHIRspC8pADFI+d4uBamj/eUu8/9CUVqetk0UpKyXWiqgEDvmkO
    # /2/yFYS60gEghvd3XVnuZnTNeRSDSE1aUXUmKdGqDjYL4DYcsehIQ9z8ut/tuYIO
    # D+4RuiuCmEyznV/DDecnwHhrv9jWftNwdwjW5GAniEjDBp/DtoouAeMArQw9rE1Z
    # mXqTa5NaeW69VTtzxzN25GzSAjiEzFT7UFRt3bT8fb0NX+UOkluD/agBqRIM5lzh
    # KbUJjqWhqA6TnHtDekbNLlmocDCn+NeBeXxDUIa19C4LICCuuxbFU+MG7cvdjSEg
    # sXRB6/qAdWgv4O3zGw1SHff+qmvtHjKVj0ihrNkrrYrL+31O2splqTMeaCqGdq9C
    # elE/TAS46CcMUSYuWzxy6mAMmA==
    # =O9tr
    # -----END PGP SIGNATURE-----
    # gpg: Signature made Thu 06 Oct 2022 11:33:30 EDT
    # gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
    # gpg:                issuer "marcandre.lureau@redhat.com"
    # gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" [full]
    # gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" [full]
    # Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5
    
    * tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu:
      dump: fix kdump to work over non-aligned blocks
      dump: simplify a bit kdump get_next_page()
      dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note
      dump: Split elf header functions into prepare and write
      dump: Rework dump_calculate_size function
      dump: Rework filter area variables
      dump: Rework get_start_block
      dump: Refactor dump_iterate and introduce dump_filter_memblock_*()
      dump: Rename write_elf_loads to write_elf_phdr_loads
      dump: Replace opaque DumpState pointer with a typed one
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

commit 94d788408d2d5a6474c99b2c9cf06913b9db7c58
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Mon Sep 5 16:06:21 2022 +0400

    dump: fix kdump to work over non-aligned blocks
    
    Rewrite get_next_page() to work over non-aligned blocks. When it
    encounters non aligned addresses, it will try to fill a page provided by
    the caller.
    
    This solves a kdump crash with "tpm-crb-cmd" RAM memory region,
    qemu-kvm: ../dump/dump.c:1162: _Bool get_next_page(GuestPhysBlock **,
    uint64_t *, uint8_t **, DumpState *): Assertion `(block->target_start &
    ~target_page_mask) == 0' failed.
    
    because:
    guest_phys_block_add_section: target_start=00000000fed40080 target_end=00000000fed41000: added (count: 4)
    
    Fixes:
    https://bugzilla.redhat.com/show_bug.cgi?id=2120480
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Acked-by: David Hildenbrand <david@redhat.com>

commit 08df343874fcddd260021a04ce3c5a34f2c48164
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Thu Aug 25 12:40:12 2022 +0400

    dump: simplify a bit kdump get_next_page()
    
    This should be functionally equivalent, but slightly easier to read,
    with simplified paths and checks at the end of the function.
    
    The following patch is a major rewrite to get rid of the assert().
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: David Hildenbrand <david@redhat.com>

commit 2341a94d3a0a8a93a5a977e642da1807b8edaab8
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:11:01 2022 +0000

    dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note
    
    The functions in question do not actually write to the file descriptor
    they set up a buffer which is later written to the fd.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-9-frankja@linux.ibm.com>

commit 670e76998a61ca171200fcded3865b294a2d1243
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:11:00 2022 +0000

    dump: Split elf header functions into prepare and write
    
    Let's split the write from the modification of the elf header so we
    can consolidate the write of the data in one function.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-8-frankja@linux.ibm.com>

commit c370d5300f9ac1f90f8158082d22262b904fe30e
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:59 2022 +0000

    dump: Rework dump_calculate_size function
    
    dump_calculate_size() sums up all the sizes of the guest memory
    blocks. Since we already have a function that calculates the size of a
    single memory block (dump_get_memblock_size()) we can simply iterate
    over the blocks and use the function instead of calculating the size
    ourselves.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Message-Id: <20220811121111.9878-7-frankja@linux.ibm.com>

commit dddf725f70bfe7f5adb41fa31dbd06e767271bda
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:58 2022 +0000

    dump: Rework filter area variables
    
    While the DumpState begin and length variables directly mirror the API
    variable names they are not very descriptive. So let's add a
    "filter_area_" prefix and make has_filter a function checking length > 0.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-6-frankja@linux.ibm.com>

commit 0c2994ac9009577b967529ce18e269da5b280351
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:57 2022 +0000

    dump: Rework get_start_block
    
    get_start_block() returns the start address of the first memory block
    or -1.
    
    With the GuestPhysBlock iterator conversion we don't need to set the
    start address and can therefore remove that code and the "start"
    DumpState struct member. The only functionality left is the validation
    of the start block so it only makes sense to re-name the function to
    validate_start_block()
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Message-Id: <20220811121111.9878-5-frankja@linux.ibm.com>

commit 1e8113032f5b1efc5da66382470ce4809c76f8f2
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:56 2022 +0000

    dump: Refactor dump_iterate and introduce dump_filter_memblock_*()
    
    The iteration over the memblocks in dump_iterate() is hard to
    understand so it's about time to clean it up. Instead of manually
    grabbing the next memblock we can use QTAILQ_FOREACH to iterate over
    all memblocks.
    
    Additionally we move the calculation of the offset and length out by
    introducing and using the dump_filter_memblock_*() functions. These
    functions will later be used to cleanup other parts of dump.c.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-4-frankja@linux.ibm.com>

commit afae6056ea79e2d89fd90867de3a01732eae724f
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:55 2022 +0000

    dump: Rename write_elf_loads to write_elf_phdr_loads
    
    Let's make it a bit clearer that we write the program headers of the
    PT_LOAD type.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Steffen Eiden <seiden@ibm.linux.com>
    Message-Id: <20220811121111.9878-3-frankja@linux.ibm.com>

commit 1af0006ab959864dfa2f59e9136c5fb93000b61f
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:54 2022 +0000

    dump: Replace opaque DumpState pointer with a typed one
    
    It's always better to convey the type of a pointer if at all
    possible. So let's add the DumpState typedef to typedefs.h and move
    the dump note functions from the opaque pointers to DumpState
    pointers.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    CC: Peter Maydell <peter.maydell@linaro.org>
    CC: Cédric Le Goater <clg@kaod.org>
    CC: Daniel Henrique Barboza <danielhb413@gmail.com>
    CC: David Gibson <david@gibson.dropbear.id.au>
    CC: Greg Kurz <groug@kaod.org>
    CC: Palmer Dabbelt <palmer@dabbelt.com>
    CC: Alistair Francis <alistair.francis@wdc.com>
    CC: Bin Meng <bin.meng@windriver.com>
    CC: Cornelia Huck <cohuck@redhat.com>
    CC: Thomas Huth <thuth@redhat.com>
    CC: Richard Henderson <richard.henderson@linaro.org>
    CC: David Hildenbrand <david@redhat.com>
    Acked-by: Daniel Henrique Barboza <danielhb413@gmail.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-2-frankja@linux.ibm.com>


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 20:27:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 20:27:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421420.666685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiiJh-0000P1-Mo; Wed, 12 Oct 2022 20:27:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421420.666685; Wed, 12 Oct 2022 20:27:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiiJh-0000Ou-Ha; Wed, 12 Oct 2022 20:27:01 +0000
Received: by outflank-mailman (input) for mailman id 421420;
 Wed, 12 Oct 2022 20:27:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uNdH=2N=epam.com=prvs=228448a85c=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1oiiJf-0000O3-TG
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 20:27:00 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 363e886e-4a6c-11ed-91b4-6bf2151ebd3b;
 Wed, 12 Oct 2022 22:26:57 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29CJhDtT028835;
 Wed, 12 Oct 2022 20:26:45 GMT
Received: from eur02-am5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k61qurns2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 12 Oct 2022 20:26:44 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by VI1PR03MB6190.eurprd03.prod.outlook.com (2603:10a6:800:131::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 12 Oct
 2022 20:26:41 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022
 20:26:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 363e886e-4a6c-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MFCIzxZnuRWEMatrHwx76hPVpnzWwknZrQATOF6TGnIzhDE450I1oJvBhCoFzlm3/PoPN8vRp9ir+twcHQfgBWpEOokp7y8k5COeDxYhFb/I20iSnhl6hzvcHoUpWKlFEOHR3CPBAx0vjpLjxb/OLNsXYB51lRDs55Y/IqGXaNFBg5z7jCnkLfzU9Pq1xv1ullP1r6zwxNfvqPzokFzjUtNzSWkJUpwJVS+Ru7EAZqVuHr0o4h8BXp30GEnAnaKRZE6Vs60F2hWRrJxJQgN0z4htUXckVjm2CKi07YqwAPbkS2Vy0ksxoBv8ZADLruy1zZjIHE5gNK4w+cwN1vBpUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oeXMF8SDauKTh90gsyerGe6ssmQoACWnM7bnuTZ2WH4=;
 b=cxgp4jFHEq65IbPBwsFD6k3R3UT2+C7OLOd7CIdjj5tQgV/cGnW0t8LHQ7am7cKo0H9YkXdu4+C1HILyIDbpItzsFJ4aklahDWzqKrc0VBwKuLpFUfxkguA3ryC02ADPPdHh6M6qbad++CJYA7RgqPhtSpECEJhjCV1cwUXCD1/Be5diAWRF+hnDEf71ICAcyvpqzEg2w/sXMSLi9PFEM4Yq+S5BBRfnkR0tmfkmnZA4wt8att3jX2JZUZSWsQJd0pReC2DlO70koPvnf1QEr6M0K7pjM5rGrC/Wsk5FkSOpoDuIPvR4B2L1ZEDBQ5DwGdWTKCvuAbcaB+J6r6+pyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oeXMF8SDauKTh90gsyerGe6ssmQoACWnM7bnuTZ2WH4=;
 b=PJ7+5jAjeWNc2f2hwyq7lbuGBNEg9fpprvcrv2dAc+wNSlDx+QNGZvDkj6afL7J06ZHxTF7cvGeY/kn/BVbFIXr8samUoXI57vVtthvR+9ZidOdMNK4DPhTN+i0WpWlfG098eD4HpT6ASCyFBynYGKsR8C7MCqrRIKFzyESAM59CLweWPvG1EmFquOHch23I0pRkAR7vqmokYEtNS2FqV+GAr2d/DWvZi9PXV/Az2gwnfoniueYWzAewTwgp60X7AQue6RIwkX2psIp3qDhaVOQsh2sv4yz2u/2r68ov94oIpJWJQTGaGuyqjpgrMyfDOafoy+mgvcJA0qwFCtUtOQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Topic: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Index: AQHY2avbTqg8YKTBpUCScd7xSfM5Yq4CIOiAgAkdnYA=
Date: Wed, 12 Oct 2022 20:26:41 +0000
Message-ID: <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com>
References: <20221006174804.2003029-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|VI1PR03MB6190:EE_
x-ms-office365-filtering-correlation-id: 69a89e6a-dfa2-4a71-76bb-08daac9012b2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 EDRubUgrali6A/1eAmYPRy8/wfowjqMbxnKbnvZYOpMYcqyLXr8I0WuZjlp8ljxTuG6xiM/Amai4xM2TRbz3An5/ZT6A0GGn6mKC2rIOdIazyxSY1R1C6lldpEQzt55zMi1J/1CAXA52GgbdjNKWBqXnw1Ez7378qfzPdoDLUPXGPjs02JK31SPkIqNRtfCVOgFPAiQiEJ0qQ36+toHx2QZ1NECYWDhq+XqjhJ0zkVsB6M6t0tPWSSjlY1sq8jDYrqekh3FcskcjoHtxygYW5csE48f/RRws6wF8gGtVkPelg+lSHJ0pZcQVdgW0YeGC6RJ2rWGF5BK3roz7lLfLpFJE+ATpM6Z4wZ1gzMSVRwx0Es7EAGPmKb7VcbV3bQNZpIgraOLo3XMIY2Ek0Jx5gdWSttiEsMGZTXahR+9IuwJoIZfapyQAELDexpOFAG8+6HSLyZL7aUq3sDVn3KsWp3LehlUHWwMcciCX4RZHOyVcZdKtjG5lPXF8tNZiunjdW1TgZjsJB4Qae2b07HBetQ1xX6CxQeeF94QTyIwnLkNiME7xjTKIe1CBbRmp8C0phGAvE/AduiNrQeRjRkyiPbpQw1oxo6GYKUQjxi+Xv0nE+lXVoP5r8SQa+2tLonF1IhftdXEpgAexSQbCGoeUFoLJJSDjtSPUsX3oyJyvD8nHrr0l2i3Wx99SmA8d9hdFMsYzVPQxkMhrEWD3lrYYFEePjDmlme2k3xDW7WYZgckMTJpSbjprfTdguAd0wkrdM/ax2sg91/qdtPZrQqQ+Ga8gp3ZpMf38TkN+EY6YXjeAmfwi2XnIgMhiHcyihcJRT2ZepLNL5flVoYLkU9mPoHqbx2pX04pKWAHWq8J2/04=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(451199015)(26005)(31686004)(110136005)(36756003)(66899015)(2906002)(2616005)(122000001)(64756008)(6506007)(4326008)(966005)(8676002)(83380400001)(316002)(478600001)(66446008)(30864003)(186003)(31696002)(71200400001)(55236004)(38100700002)(38070700005)(53546011)(41300700001)(8936002)(91956017)(66556008)(6512007)(5660300002)(76116006)(66946007)(86362001)(6486002)(54906003)(66476007)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TTJxS01QSzFjNXdYY0cvUk9qb0E3QWdTQ2F6NEoyVm9QeWtZWHlaSTVXTEw4?=
 =?utf-8?B?ZW90NmpiSldhMDRMeHBrNlpFcjJSYS9rcjVZK1cwQ2dWOUVjeVcvTXBBQVIv?=
 =?utf-8?B?OG9MRVhDRnF3ckRYSitscnVWUGVPSTVMOXp6VFB4MGlVeHhyUEUva3RvR09D?=
 =?utf-8?B?M0hZNEl5NzdCelVzdVRiM2dVdVpzbG9wSEFVcCs5SzZRU1cwWG9YRW0wdFRX?=
 =?utf-8?B?M29GR2VrbFA2K0lvTGVLNnBjYTBsWXEvQmxnalhZMGpwRUFBUzZzQzVHTkpX?=
 =?utf-8?B?SUd2ekpYNWdxbDBsQkxPRERNckNCdzRtUVZwZWtCbElhR2p5K21RdzBKOXdD?=
 =?utf-8?B?RTlNYmdWWGo4UFZLYjlnLzNyeTF2MEd6enZSSkZndkczUTBXaTE2SmdxRlZk?=
 =?utf-8?B?U3NaVlpwRGE5c0Y1R0t4RjBWejlXNlVWdGtFL0tPSEZiQ1ZQbkhYM1RDT1lp?=
 =?utf-8?B?ZDBoeUNmSHczWEExRjBkVHNYVUROaGpXK0lyRDFZRUxNdTlzcWZZVGZBbmFv?=
 =?utf-8?B?Yk56akdBK0h5bTdlRmRIU0tmNWk4aHQydnZwSUZaalNNLzN3T0FFSWpUbkhj?=
 =?utf-8?B?Uzl1WXE4NDd0Qnd2enFtOW1qU0lrSU1Ba28zbFVjRDlPcWpleUp2TjUvWnVn?=
 =?utf-8?B?N2ZkQmhKNWEvNHBVN1pwc1FIWklFSVN4TEpUSG1yVTkyd05GcFFRZENQbVpC?=
 =?utf-8?B?b0dob2JqRE9qTjQxRjBlUnJKS2YxVUZ3czVTc3RGYVJKRWlPRDlMM1M2eWhE?=
 =?utf-8?B?REZxaUMwU0QrN0VPTXRBQUwrQ2R2MVduY05IUGxHVjZ0ZTM4bHR5YXdIb2k3?=
 =?utf-8?B?UE41OCtoQWY5WFUwV3V6b01CL0NnNVA3ZTV4bkZEQXF5VVlKSzJFSXlKUE90?=
 =?utf-8?B?SzNzQzJsUStnQStXSXBWUjhidUJGd0k5eVdWdlpPVWZkbVFLVVM4eEZrQXlz?=
 =?utf-8?B?NzVaNVQ1MXVyUDhtMlhZZjJpdUxheXpETW9VSXdqcTE5SlBJTjdXNDdCdE82?=
 =?utf-8?B?cWorMFlTNzJBenFrN0NjQWZUMVdaSnY5YmNJWlBHVmo2RWJ4ZFdiZGtZTkFM?=
 =?utf-8?B?UHlRcXJtSnhFWHhMRUZENVlYUkhHd3ZPWTBldFhrYzFTaGNaejMxSE1BT0k5?=
 =?utf-8?B?UDdMempxcWRPWmprRDZ4ZDZqNlR5VDdDeXcxZEpNOUZydmVKSlg4NTVUaUls?=
 =?utf-8?B?UE40ZThsT29uS2VGT3EzYVo3TVk1MEdSeTFMdXNYZ1VPTmt4UzRYdktUL1hD?=
 =?utf-8?B?aXBNcmtkZEhPMHZicnFyWURiQ3N5cG1xWGZzRjEzN2pyZHBIVzFTWnBCWms4?=
 =?utf-8?B?WDVhOU1obGpsTTZ6Q3BqaDhhVlU3dTJOVXk2WFFENXpZOUIwZEU1UTBkVjZr?=
 =?utf-8?B?bGVvaUNYZjdHdXpGV1FaK1dBWTVIMDNqYjVLeGRweURGQ3FoaXcyeDlPbWZH?=
 =?utf-8?B?V0lXWFNzcHFIOHNEanA5bU00S0JETUdsOVdoZERaSU1vTWhYbVRIajIvOHFs?=
 =?utf-8?B?RHBnK25rUE94VFdRdUl2Rkt4ZS8yY0tuNXFpd2NQTXRDd1VCQStRcUpuRkty?=
 =?utf-8?B?UkUrVG9EWjZianhudFJnM0g2bERhTXVvaEJMMk03b2x3SjRYVDA0emRhYTgx?=
 =?utf-8?B?S3k5VURVZnYrTEZHWEVxYy9Dc2p2UGI3cElFRUh3T0w3VHViODF0Sk1MMEUw?=
 =?utf-8?B?UGdCVGxobllZVG9KZDBDRmlDQk9zSGlYaUNQano0eHFvb0RwSzl4LzNBa2ZM?=
 =?utf-8?B?a2lwdHJERFkrTHhzbGxWNEZuc0xoa2pnZElYVzlmc1cyQy8xNGVXQXU1WFV4?=
 =?utf-8?B?SFR0bUM5UlpjNTNpSXVOL1lKWGZpeTRncjBVTUhMTGFCb1VOcjZXZ2tTMS9R?=
 =?utf-8?B?ZzJTNE4xRHJBKzhrSXc0UjdEb1QwdkdjMlk4a2QzcGFpOEJCd2pCRENFb0pk?=
 =?utf-8?B?YjJtenljMS9PVS84MEd5QUxwR0JXMFBPUjk5aE9iWnFSQzkwNnFmVThqQ2g2?=
 =?utf-8?B?VWowVWxucm50Y3gzL2RveTdncnlpWUl1dGRNYWRZRGFMK3NQYUtCRlk2cVVu?=
 =?utf-8?B?R05DbGlqV29OUnB5RVQxNGY3ZllwYy9ZZmZqdUlNMTdTZlA2QkpHYTBlTlN5?=
 =?utf-8?B?cnpzM0hZcERBOWEraXNpVUM5cS9NU3djaUNialhEd1haOVpHTmd6Z09wdjdK?=
 =?utf-8?Q?5TxHOVd0MKyEXEx0hdKcnK8=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <EF9517AC66357840A6243542E91F0129@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69a89e6a-dfa2-4a71-76bb-08daac9012b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 20:26:41.4675
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xtmcOR9hdHrLbdlngp+EjpmYT/jOVA9seYC8233IGwSlJz8QiiWZtnlfQ+c25CnLMSxBF/UElhQ3AKmPbaVAyunoNbLQ012mrKlSWyYXhs4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6190
X-Proofpoint-GUID: X9KVAl1hFAGuRLM06mmt-ZwZ8KTRWVnY
X-Proofpoint-ORIG-GUID: X9KVAl1hFAGuRLM06mmt-ZwZ8KTRWVnY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-12_09,2022-10-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0
 lowpriorityscore=0 impostorscore=0 bulkscore=0 malwarescore=0
 priorityscore=1501 mlxscore=0 mlxlogscore=999 spamscore=0 clxscore=1015
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210120130

DQpPbiAwNy4xMC4yMiAwNDoxNCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNClRoYW5rIHlvdSBmb3IgdGhlIGRldGFpbGVkIGFuYWx5c2lzLiBQbGVhc2Ugc2Vl
IGFuc3dlcnMgYmVsb3cuDQoNCg0KPiBPbiBUaHUsIDYgT2N0IDIwMjIsIE9sZWtzYW5kciBUeXNo
Y2hlbmtvIHdyb3RlOg0KPj4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90
eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+IFVzZSB0aGUgc2FtZSAieGVuLWdyYW50LWRtYSIg
ZGV2aWNlIGNvbmNlcHQgKGJhc2VkIG9uIGdlbmVyaWMgSU9NTVUNCj4+IGRldmljZS10cmVlIGJp
bmRpbmdzKSBmb3IgdGhlIFBDSSBkZXZpY2VzIGJlaGluZCBkZXZpY2UtdHJlZSBiYXNlZA0KPj4g
UENJIEhvc3QgY29udHJvbGxlci4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlz
aGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IFNsaWdo
dGx5IFJGQy4gVGhpcyBpcyBuZWVkZWQgdG8gc3VwcG9ydCBYZW4gZ3JhbnQgbWFwcGluZ3MgZm9y
IHZpcnRpby1wY2kgZGV2aWNlcw0KPj4gb24gQXJtIGF0IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVy
ZS4gVGhlIFhlbiB0b29sc3RhY2sgc2lkZSBpcyBub3QgcHVibGlzaGVkIHlldC4NCj4+IEhlcmUs
IGZvciBQQ0kgZGV2aWNlcyB3ZSB1c2UgdGhlIHNhbWUgd2F5IHRvIHBhc3MgYmFja2VuZCBkb21p
ZCB0byB0aGUgZ3Vlc3QgYXMgZm9yDQo+PiBwbGF0Zm9ybSBkZXZpY2VzLg0KPj4NCj4+IERlcGVu
ZHMgb24gSnVlcmdlbidzIHNlcmllczoNCj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19o
dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDYwNzE1MDAuMTU2ODktMS1q
Z3Jvc3NAc3VzZS5jb20vX187ISFHRl8yOWRiY1FJVUJQQSF3YU9rMkdvYzdxbGhObzUtY3NST2Jy
eWlsX0d6TUZfZTYxRUpSNTAxb0owOGNIMmRuSnVsc1pYV2xlbEJEVEJxYTYzVFZvVWNXUVRCNU5l
Y0oxcDR4Rk5naDJfRXVBJCAgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+PiAtLS0NCj4+ICAgZHJp
dmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysr
KystLS0tLS0tLQ0KPj4gICAxIGZpbGUgY2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMTAgZGVs
ZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMu
YyBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4gaW5kZXggZmY5YmUzYWZmODdlLi43
OWQxMzEyMmVjMDggMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMN
Cj4+ICsrKyBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4gQEAgLTEwLDYgKzEwLDcg
QEANCj4+ICAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgv
ZG1hLW1hcC1vcHMuaD4NCj4+ICAgI2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+PiArI2luY2x1ZGUg
PGxpbnV4L3BjaS5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgvcGZuLmg+DQo+PiAgICNpbmNsdWRl
IDxsaW51eC94YXJyYXkuaD4NCj4+ICAgI2luY2x1ZGUgPGxpbnV4L3ZpcnRpb19hbmNob3IuaD4N
Cj4+IEBAIC0yNzMsMTIgKzI3NCwyOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRtYV9tYXBfb3Bz
IHhlbl9ncmFudF9kbWFfb3BzID0gew0KPj4gICAJLmRtYV9zdXBwb3J0ZWQgPSB4ZW5fZ3JhbnRf
ZG1hX3N1cHBvcnRlZCwNCj4+ICAgfTsNCj4+ICAgDQo+PiAtc3RhdGljIGJvb2wgeGVuX2lzX2R0
X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gK3N0YXRpYyBzdHJ1Y3Qg
ZGV2aWNlX25vZGUgKnhlbl9kdF9nZXRfbm9kZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiArew0K
Pj4gKwlpZiAoZGV2X2lzX3BjaShkZXYpKSB7DQo+PiArCQlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9
IHRvX3BjaV9kZXYoZGV2KTsNCj4+ICsJCXN0cnVjdCBwY2lfYnVzICpidXMgPSBwZGV2LT5idXM7
DQo+PiArDQo+PiArCQkvKiBXYWxrIHVwIHRvIHRoZSByb290IGJ1cyB0byBsb29rIGZvciBQQ0kg
SG9zdCBjb250cm9sbGVyICovDQo+PiArCQl3aGlsZSAoIXBjaV9pc19yb290X2J1cyhidXMpKQ0K
Pj4gKwkJCWJ1cyA9IGJ1cy0+cGFyZW50Ow0KPj4gKw0KPj4gKwkJcmV0dXJuIG9mX25vZGVfZ2V0
KGJ1cy0+YnJpZGdlLT5wYXJlbnQtPm9mX25vZGUpOw0KPj4gKwl9DQo+IElzIGl0IHBvc3NpYmxl
IHRvIGhhdmUgbXVsdGlwbGUgdmlydGlvIGRldmljZXMgdW5kZXIgYSBzaW5nbGUgdmlydGlvLXBj
aQ0KPiByb290IGNvbXBsZXg/DQoNCnllcw0KDQoNCj4gV2hhdCBpZiB2aXJ0aW8tbmV0IGhhcyB0
aGUgYmFja2VuZCBpbiBkb20wIGFuZA0KPiB2aXJ0aW8tYmxvY2sgaGFzIHRoZSBiYWNrZW5kIGlu
IGRvbTE/DQo+DQo+IE9yIGVhY2ggdmlydGlvIFBDSSBkZXZpY2Ugc2hvd3MgdXAgdW5kZXIgYSBk
aWZmZXJlbnQgUENJIHJvb3QgY29tcGxleD8NCg0KDQpHb29kIHF1ZXN0aW9ucy4gVG8gYmUgaG9u
ZXN0LCBpdCBpcyBub3QgMTAwJSBjbGVhciB0byBtZSB5ZXQgaG93IGl0IGlzIA0Kc3VwcG9zZWQg
dG8gYmUuIEJ1dCBsZXQncyBndWVzcy4uLg0KDQpJIHRoaW5rIHRoYXQgaGF2aW5nIGEgUENJIEhv
c3QgYnJpZGdlIHBlciB2aXJ0aW8tcGNpIGRldmljZSBpcyBvdmVya2lsbC4NCg0KU28sIEkgc2Vl
IHR3byBvcHRpb25zIGhlcmU6DQoxLiBXZSBwcm92aWRlIFBDSSBIb3N0IGJyaWRnZSBwZXIgYmFj
a2VuZHMgZG9tYWluIHRvIHRoZSBndWVzdCwgc28gZWFjaCANClBDSSBIb3N0IGJyaWRnZSBjb3Zl
cnMgb25seSB2aXJ0aW8tcGNpIGRldmljZXMgd2hvc2UgYmFja2VuZHMgYXJlIA0KcnVubmluZyB3
aXRoaW4gKnRoZSBzYW1lKiBkb21haW4uDQpXaXRoIHRoYXQgd2Ugd291bGQgYmUgYWJsZSB0byB1
c2UgcHJvcGVydHkgYXQgUENJIEhvc3QgYnJpZGdlIGxldmVsLg0KDQoyLiBXZSBwcm92aWRlIG9u
bHkgYSBzaW5nbGUgUENJIEhvc3QgYnJpZGdlIHRvIHRoZSBndWVzdCwgc28gdGhhdCBzaW5nbGUg
DQpQQ0kgSG9zdCBicmlkZ2UgY292ZXJzIGFsbCB2aXJ0aW8tcGNpIGRldmljZXMgYXNzaWduZWQg
dG8gdGhpcyBndWVzdC4NCk5vIG1hdHRlciB3aGVyZSB0aGUgY29ycmVzcG9uZGluZyBiYWNrZW5k
cyBhcmUgcnVubmluZyAodGhlIA0KdmlydGlvLWRldmljZXMgdW5kZXIgdGhhdCBQQ0kgSG9zdCBi
cmlkZ2UgY2FuIGhhdmUgdGhlIGJhY2tlbmRzIGluIA0KZGlmZmVyZW50IGRvbWFpbnMpLg0KV2l0
aCB0aGF0IHdlIHdvdWxkbuKAmXQgYmUgYWJsZSB0byB1c2UgcHJvcGVydHkgYXQgUENJIEhvc3Qg
YnJpZGdlIGxldmVsLiANCkFuZCB3ZSBuZWVkIGEgbW9yZSBmbGV4aWJsZSBvcHRpb24ocykgdG8g
YmUgYWJsZSBkaXN0aW5ndWlzaCBiZXR3ZWVuIA0KdmlydGlvLXBjaSBkZXZpY2VzLg0KDQpUYWtp
bmcgaW50byBhY2NvdW50IHRoYXQgZm9yIHZpcnRpby1wY2kgb24gQXJtIHdlIG5lZWQgdG8gZW11
bGF0ZSBhIA0Kc3BlY2lmaWMgUENJIEhvc3QgYnJpZGdlIGluIFhlbiB0byBpbnRlcmNlcHQgdGhl
IGd1ZXN0IFBDSSBjb25maWcgc3BhY2UgDQphY2Nlc3Nlcw0KKGRldGVjdCB3aGF0IFBDSSBkZXZp
Y2UgaXMgdGFyZ2V0ZWQpIGFuZCBmb3J3YXJkIHRoZW0gdG8gdGhlIGFwcHJvcHJpYXRlIA0KYmFj
a2VuZCAoSU9SRVEgU2VydmVyKSwNCml0IGZlZWxzIHRvIG1lIHRoYXQgd2UgbGlrZWx5IG5lZWQg
dG8gZ28gd2l0aCB0aGUgc2Vjb25kIG9wdGlvbiBoZXJlIA0KKG9uZSBQQ0kgaG9zdCBicmlkZ2Ug
cGVyIGd1ZXN0KSwgSSBtYXkgbWlzdGFrZSwNCmJ1dCBJIGRvbuKAmXQgdGhpbmsgdGhhdCB3ZSB3
YW50IHRvIGVtdWxhdGUgc2V2ZXJhbCBQQ0kgSG9zdCBicmlkZ2VzIGZvciBhIA0Kc2luZ2xlIGd1
ZXN0IChtb3JlIGNvZGUsIG1vcmUgcmVzb3VyY2VzLCBldGMpLg0KDQoNCg0KPg0KPiBJZiB3ZSBj
YW4gaGF2ZSBtdWx0aXBsZSB2aXJ0aW8gUENJIGRldmljZXMgdW5kZXIgYSBzaW5nbGUgUENJIHJv
b3QNCj4gY29tcGxleCwgdGhlbiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBjaGVjayBm
b3IgYSBwZXItZGV2aWNlDQo+IHByb3BlcnR5LCByYXRoZXIgdGhhbiBhIHNpbmdsZSBwcm9wZXJ0
eSBhdCB0aGUgUENJIHJvb3QgY29tcGxleCBsZXZlbC4NCg0KQ29tcGxldGVseSBhZ3JlZS4NCg0K
DQo+DQo+IFRoZSBmaXJzdCB0aGluZyB0aGF0IGNvbWVzIHRvIG1pbmQgaXMgdG8gZGVzY3JpYmUg
ZWFjaCBQQ0kgZGV2aWNlIHVuZGVyDQo+IHRoZSByb290IGNvbXBsZXggaW4gZGV2aWNlIHRyZWUu
IEFsdGhvdWdoIGl0IGlzIHVuY29tbW9uICh1c3VhbGx5IG9ubHkNCj4gdGhlIFBDSSByb290IGNv
bXBsZXggaXMgZGVzY3JpYmVkIGluIGRldmljZSB0cmVlKSwgaXQgaXMgcG9zc2libGUgdG8NCj4g
YWxzbyBkZXNjcmliZSBpbiBkZXZpY2UgdHJlZSBhbGwgdGhlIGluZGl2aWR1YWwgUENJIGRldmlj
ZXMgdW5kZXIgdGhlDQo+IHJvb3QgY29tcGxleC4NCj4NCj4gR2l2ZW4gdGhhdCB0aGUgZG9tVSBk
ZXZpY2UgdHJlZSBpcyBnZW5lcmF0ZWQgYnkgWGVuIGFuZC9vciB0aGUgWGVuDQo+IHRvb2xzdGFj
aywgaXQgd291bGQgYmUgZWFzeSB0byBhcnJhbmdlIGZvciBpdCB0byBoYXBwZW4uDQoNClRlY2hu
aWNhbGx5IHllcy4gSWYgd2UgZGVjaWRlIHRvIHByb3ZpZGUgb25seSBhIHNpbmdsZSBQQ0kgSG9z
dCBicmlkZ2UgDQp0byB0aGUgZ3Vlc3QsIHdlIHdpbGwgaGF2ZSBoYXZlIHRvIGRlYWwgd2l0aCB0
aGUgdmlydGlvLXBjaSBkZXZpY2VzIHdpdGggDQp2YXJpb3VzIGJhY2tlbmRfZG9taWQsDQpzbyB3
ZSBjYW4gY29uc2lkZXIgdXNpbmcgbW9yZSBmbGV4aWJsZSBwcm9wZXJ0eSANCuKAnGlvbW11LW1h
cOKAnS/igJ1pb21tdS1tYXAtbWFza+KAnSBzcGVjaWFsbHkgaW50cm9kdWNlZCBmb3Igc3VjaCBw
dXJwb3NlczoNCmh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL0RvY3VtZW50YXRpb24vZGV2aWNl
dHJlZS9iaW5kaW5ncy9wY2kvcGNpLWlvbW11LnR4dA0KSSB0aGluaywgd2l0aCB0aGF0IHdlIHdv
dWxkIGJlIGFibGUgdG8gZGVzY3JpYmUsIGkuZSB0aGF0IHZpcnRpby1wY2kgDQpkZXZpY2UgQSBj
b25uZWN0cyB0byBzdHJlYW1faWQgKGJhY2tlbmRfZG9taWQpIFggYW5kIHZpcnRpby1wY2kgZGV2
aWNlIEIgDQp0byBzdHJlYW1faWQgWSwNCmFuZCB2aXJ0aW8tcGNpIGRldmljZSBDIHRvIG5vdGhp
bmcgKHNvIGlzIG5vdCByZXF1aXJlZCB0byB1c2UgZ3JhbnRzKSwgDQp1bmxlc3MgSSBtaXNzZWQg
c29tZXRoaW5nLg0KDQpJIGhhdmUgbG9va2VkIGF0IGl0IGFuZCBJIGRvbuKAmXQgc2VlIGF0IHRo
ZSBtb21lbnQgd2h5IHRoZSBpZGVhIHdvdWxkbuKAmXQgDQp3b3JrLCBidXQgSSBoYXZlbuKAmXQg
ZXhwZXJpbWVudGVkIHdpdGggdGhhdCB5ZXQgaW4gc3VjaCBjb250ZXh0Lg0KDQoNCj4NCj4gVGhh
dCB3b3VsZCBzb2x2ZSB0aGUgaXNzdWUgYXMgZmFyIGFzIEkgY2FuIHRlbGwsIGJ1dCBJIHdvcnJ5
IGl0IG1pZ2h0DQo+IG5vdCBiZSBhIGdvb2QgaWRlYSBiZWNhdXNlIGlmIHdlIHJlbHkgb24gdGhl
IHBlci1kZXZpY2UgZGV2aWNlIHRyZWUgbm9kZQ0KPiB0byBiZSBwcmVzZW50IHRoZW4gaXQgYmVj
b21lcyBoYXJkZXIgdG8gaW1wbGVtZW50IHZpcnRpbyBob3RwbHVnDQo+IChWaXJ0aW8gaG90cGx1
ZyBpcyBpbXBvcnRhbnQgdG8gYWRkIGRvbTBsZXNzIHN1cHBvcnQuKQ0KPg0KPiBMZXQncyBzYXkg
dGhhdCB3ZSBjcmVhdGUgYSBkb20wbGVzcyBkb21VIHdpdGggYW4gZW11bGF0ZWQgUENJIHJvb3QN
Cj4gY29tcGxleCB3aXRob3V0IGFueSBkZXZpY2VzIHVuZGVyIGl0LCB0aGVuIGFmdGVyIERvbTAg
aXMgZnVsbHkgYm9vdGVkLA0KPiB3ZSBhZGQgYSB2aXJ0aW8tbmV0IGVtdWxhdGVkIGRldmljZS4g
SG93IGRvIHdlIHRlbGwgdGhlIGd1ZXN0IHdoYXQgaXMNCj4gdGhlIGJhY2tlbmQgZG9tYWluIGlk
Pw0KPg0KPiBEZXZpY2UgdHJlZSBhbmQgb3RoZXIgZmlybXdhcmUgdGFibGVzIGFyZSBub3QgcmVs
ZXZhbnQgYW55bW9yZS4NCj4NCj4gV2UgY291bGQgcmV1c2UgYSBQQ0kgY29uZmlnIHNwYWNlIHJl
Z2lzdGVyIHRvIGV4cG9zZSB0aGUgYmFja2VuZCBpZC4NCj4gSG93ZXZlciB0aGlzIHNvbHV0aW9u
IHJlcXVpcmVzIGEgYmFja2VuZCBjaGFuZ2UgKFFFTVUpIHRvIGV4cG9zZSB0aGUNCj4gYmFja2Vu
ZCBpZCB2aWEgYW4gZW11bGF0ZWQgcmVnaXN0ZXIgZm9yIGVhY2ggZW11bGF0ZWQgZGV2aWNlLg0K
Pg0KPiBUbyBhdm9pZCBoYXZpbmcgdG8gaW50cm9kdWNlIGEgc3BlY2lhbCBjb25maWcgc3BhY2Ug
cmVnaXN0ZXIgaW4gYWxsDQo+IGVtdWxhdGVkIFBDSSBkZXZpY2VzICh2aXJ0aW8tbmV0LCB2aXJ0
aW8tYmxvY2ssIGV0YykgSSB3b25kZXIgaWYgd2UNCj4gY291bGQgYWRkIGEgc3BlY2lhbCBQQ0kg
Y29uZmlnIHNwYWNlIHJlZ2lzdGVyIGF0IHRoZSBlbXVsYXRlZCBQQ0kgUm9vdA0KPiBDb21wbGV4
IGxldmVsLg0KPg0KPiBCYXNpY2FsbHkgdGhlIHdvcmtmbG93IHdvdWxkIGJlIGFzIGZvbGxvdzoN
Cj4NCj4gLSBMaW51eCByZWNvZ25pemVzIHRoZSBQQ0kgUm9vdCBDb21wbGV4IGFzIGEgWGVuIFBD
SSBSb290IENvbXBsZXgNCj4gLSBMaW51eCB3cml0ZXMgdG8gc3BlY2lhbCBQQ0kgY29uZmlnIHNw
YWNlIHJlZ2lzdGVyIG9mIHRoZSBYZW4gUENJIFJvb3QNCj4gICAgQ29tcGxleCB0aGUgUENJIGRl
dmljZSBpZCAoYmFzaWNhbGx5IHRoZSBCREYpDQo+IC0gVGhlIFhlbiBQQ0kgUm9vdCBDb21wbGV4
IGVtdWxhdGVkIGJ5IFhlbiBhbnN3ZXJzIGJ5IHdyaXRpbmcgYmFjayB0bw0KPiAgICB0aGUgc2Ft
ZSBsb2NhdGlvbiB0aGUgYmFja2VuZCBpZCAoZG9taWQgb2YgdGhlIGJhY2tlbmQpDQo+IC0gTGlu
dXggcmVhZHMgYmFjayB0aGUgc2FtZSBQQ0kgY29uZmlnIHNwYWNlIHJlZ2lzdGVyIG9mIHRoZSBY
ZW4gUENJDQo+ICAgIFJvb3QgQ29tcGxleCBhbmQgbGVhcm4gdGhlIHJlbGV2YW50IGRvbWlkDQo+
DQo+IFdoYXQgZG8geW91IHRoaW5rPw0KDQoNCkkgdGhpbmsgdGhlIGlkZWEgc291bmRzIGluZGVl
ZCBpbnRlcmVzdGluZyBhbmQgd291bGQgcHJvYmFibHkgd29yaywgYnV0IA0Kd291bGQgcmVxdWly
ZSBndWVzdCBtb2RpZmljYXRpb25zIG90aGVyIHRoYW4ganVzdCBpbiBkcml2ZXJzL3hlbiAoYW5k
IA0KbGlrZWx5IHRoZSBzcGVjaWZpY2F0aW9uIGNoYW5nZXMgYXMgd2VsbCkuDQpXaGljaCBpZGVh
bGx5IG9mIGNvdXJzZSBzaG91bGQgYmUgYXZvaWRlZC4NCkFsc28gSSB3YXMgdGhpbmtpbmcgaXQg
d291bGQgYmUgbmljZSBub3QgdG8gZGl2ZXJnZSBtdWNoIGJldHdlZW4gDQpjb21tdW5pY2F0aW5n
IHRoZSBiYWNrZW5kX2RvbWlkIGZvciBwbGF0Zm9ybSBhbmQgUENJIGRldmljZXMgb24gQXJtIHdp
dGggDQpkZXZpY2UgdHJlZS4NCg0KSWYgd2UgbWFuYWdlZCB0byByZS11c2UgZ2VuZXJpYyBJT01N
VSBkZXZpY2UtdHJlZSBiaW5kaW5ncyBmb3IgDQp2aXJ0aW8tbW1pbywgd2Ugd291bGQgbGlrZWx5
IGJlIGFibGUgdG8gcmUtdXNlIFBDSS1JT01NVSBkZXZpY2UtdHJlZSANCmJpbmRpbmdzIGZvciB2
aXJ0aW8tcGNpLA0KYXQgbGVhc3QgZm9yIGJvb3QgUENJIGRldmljZXMgKHdoaWNoIGFyZSBrbm93
biBhdCB0aGUgZG9tYWluIGNyZWF0aW9uIHRpbWUpLg0KVGhlIG1vcmUsIHRoZSBiaW5kaW5ncyBp
cyBhbHJlYWR5IHByZXNlbnQ6IA0KaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4
L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L3RyZWUvRG9jdW1lbnRhdGlvbi9kZXZpY2V0
cmVlL2JpbmRpbmdzL2lvbW11L3hlbixncmFudC1kbWEueWFtbA0KDQpSZWdhcmRpbmcgdGhlIGhv
dHBsdWcgZGV2aWNlcywgeWVzIGl0IGlzIGEgdmFsaWQgdXNlLWNhc2Ugd2hpY2ggc2hvdWxkIA0K
YmUgYWxzbyBzdXBwb3J0ZWQgd2l0aCB2aXJ0aW8tcGNpLCBJIGFzc3VtZSB0aGUgWGVuc3RvcmUg
Y291bGQgYmUgDQpyZS11c2VkIGZvciB0aGF0IHB1cnBvc2UgaWYgaXQgd291bGQgYmUgYXZhaWxh
YmxlLg0KVGhlIFhlbnN0b3JlIGlzIGF2YWlsYWJsZSB3aXRoIHRoZSB1c3VhbCBEb20wIGFuZCB0
b29sc3RhY2ssIGlzIGl0IA0KYXZhaWxhYmxlIHdpdGggZG9tMGxlc3M/DQoNCg0KDQoNCj4NCj4g
T3RoZXIgaWRlYXMgd2VsY29tZSENCj4NCj4NCj4NCj4+ICsJcmV0dXJuIG9mX25vZGVfZ2V0KGRl
di0+b2Zfbm9kZSk7DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyBib29sIHhlbl9pc19kdF9ncmFu
dF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApDQo+PiAgIHsNCj4+ICAgCXN0cnVj
dCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnA7DQo+PiAgIAlib29sIGhhc19pb21tdTsNCj4+ICAgDQo+
PiAtCWlvbW11X25wID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21tdXMiLCAw
KTsNCj4+ICsJaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFuZGxlKG5wLCAiaW9tbXVzIiwgMCk7DQo+
PiAgIAloYXNfaW9tbXUgPSBpb21tdV9ucCAmJg0KPj4gICAJCSAgICBvZl9kZXZpY2VfaXNfY29t
cGF0aWJsZShpb21tdV9ucCwgInhlbixncmFudC1kbWEiKTsNCj4+ICAgCW9mX25vZGVfcHV0KGlv
bW11X25wKTsNCj4+IEBAIC0yODgsOSArMzA1LDE3IEBAIHN0YXRpYyBib29sIHhlbl9pc19kdF9n
cmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgDQo+PiAgIGJvb2wgeGVu
X2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+PiArCXN0
cnVjdCBkZXZpY2Vfbm9kZSAqbnA7DQo+PiArDQo+PiAgIAkvKiBYWFggSGFuZGxlIG9ubHkgRFQg
ZGV2aWNlcyBmb3Igbm93ICovDQo+PiAtCWlmIChkZXYtPm9mX25vZGUpDQo+PiAtCQlyZXR1cm4g
eGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2UoZGV2KTsNCj4+ICsJbnAgPSB4ZW5fZHRfZ2V0X25v
ZGUoZGV2KTsNCj4+ICsJaWYgKG5wKSB7DQo+PiArCQlib29sIHJldDsNCj4+ICsNCj4+ICsJCXJl
dCA9IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKG5wKTsNCj4+ICsJCW9mX25vZGVfcHV0KG5w
KTsNCj4+ICsJCXJldHVybiByZXQ7DQo+PiArCX0NCj4+ICAgDQo+PiAgIAlyZXR1cm4gZmFsc2U7
DQo+PiAgIH0NCj4+IEBAIC0zMDMsMjAgKzMyOCwyMCBAQCBib29sIHhlbl92aXJ0aW9fbWVtX2Fj
YyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KQ0KPj4gICAJcmV0dXJuIHhlbl9pc19ncmFudF9k
bWFfZGV2aWNlKGRldi0+ZGV2LnBhcmVudCk7DQo+PiAgIH0NCj4+ICAgDQo+PiAtc3RhdGljIGlu
dCB4ZW5fZHRfZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiArc3Rh
dGljIGludCB4ZW5fZHRfZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlX25vZGUgKm5w
LA0KPj4gICAJCQkJICAgICAgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGEpDQo+PiAg
IHsNCj4+ICAgCXN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYzsNCj4+ICAgDQo+PiAt
CWlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25vZGUsICJpb21tdXMiLCAi
I2lvbW11LWNlbGxzIiwNCj4+ICsJaWYgKG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKG5wLCAi
aW9tbXVzIiwgIiNpb21tdS1jZWxscyIsDQo+PiAgIAkJCTAsICZpb21tdV9zcGVjKSkgew0KPj4g
LQkJZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+ICsJ
CXByX2VycigiJXM6IENhbm5vdCBwYXJzZSBpb21tdXMgcHJvcGVydHlcbiIsIG5wLT5uYW1lKTsN
Cj4+ICAgCQlyZXR1cm4gLUVTUkNIOw0KPj4gICAJfQ0KPj4gICANCj4+ICAgCWlmICghb2ZfZGV2
aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfc3BlYy5ucCwgInhlbixncmFudC1kbWEiKSB8fA0KPj4g
ICAJCQlpb21tdV9zcGVjLmFyZ3NfY291bnQgIT0gMSkgew0KPj4gLQkJZGV2X2VycihkZXYsICJJ
bmNvbXBhdGlibGUgSU9NTVUgbm9kZVxuIik7DQo+PiArCQlwcl9lcnIoIiVzOiBJbmNvbXBhdGli
bGUgSU9NTVUgbm9kZVxuIiwgaW9tbXVfc3BlYy5ucC0+bmFtZSk7DQo+PiAgIAkJb2Zfbm9kZV9w
dXQoaW9tbXVfc3BlYy5ucCk7DQo+PiAgIAkJcmV0dXJuIC1FU1JDSDsNCj4+ICAgCX0NCj4+IEBA
IC0zMzUsNiArMzYwLDcgQEAgc3RhdGljIGludCB4ZW5fZHRfZ3JhbnRfc2V0dXBfZG1hX29wcyhz
dHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiAgIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3Ry
dWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+PiAgIAlzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRh
ICpkYXRhOw0KPj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4gICANCj4+ICAgCWRhdGEg
PSBmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShkZXYpOw0KPj4gICAJaWYgKGRhdGEpIHsNCj4+IEBA
IC0zNDYsOCArMzcyLDEzIEBAIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRl
dmljZSAqZGV2KQ0KPj4gICAJaWYgKCFkYXRhKQ0KPj4gICAJCWdvdG8gZXJyOw0KPj4gICANCj4+
IC0JaWYgKGRldi0+b2Zfbm9kZSkgew0KPj4gLQkJaWYgKHhlbl9kdF9ncmFudF9zZXR1cF9kbWFf
b3BzKGRldiwgZGF0YSkpDQo+PiArCW5wID0geGVuX2R0X2dldF9ub2RlKGRldik7DQo+PiArCWlm
IChucCkgew0KPj4gKwkJaW50IHJldDsNCj4+ICsNCj4+ICsJCXJldCA9IHhlbl9kdF9ncmFudF9z
ZXR1cF9kbWFfb3BzKG5wLCBkYXRhKTsNCj4+ICsJCW9mX25vZGVfcHV0KG5wKTsNCj4+ICsJCWlm
IChyZXQpDQo+PiAgIAkJCWdvdG8gZXJyOw0KPj4gICAJfSBlbHNlIGlmIChJU19FTkFCTEVEKENP
TkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5UKSkgew0KPj4gICAJCWRldl9pbmZvKGRldiwgIlVz
aW5nIGRvbTAgYXMgYmFja2VuZFxuIik7DQo+PiAtLSANCj4+IDIuMjUuMQ0KPj4NCi0tIA0KUmVn
YXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 21:18:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 21:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421439.666729 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oij6v-00063T-UV; Wed, 12 Oct 2022 21:17:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421439.666729; Wed, 12 Oct 2022 21:17:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oij6v-00063M-OL; Wed, 12 Oct 2022 21:17:53 +0000
Received: by outflank-mailman (input) for mailman id 421439;
 Wed, 12 Oct 2022 21:17:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oij6v-00063C-2q; Wed, 12 Oct 2022 21:17:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oij6v-0006pA-0H; Wed, 12 Oct 2022 21:17:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oij6u-00011f-Ny; Wed, 12 Oct 2022 21:17:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oij6u-0004jq-NY; Wed, 12 Oct 2022 21:17:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xc5FGdYUceZHufvj5drkbdDsFOV/dO84pji1K7hvN+o=; b=c/fWgSFKF9uqezfj2na5ETSdXr
	ZaPXG9V4+FsQJ20kQFrk89tZK57ayL1aHxNf62JFqoXbS7+xuY/Y18iCBTUVYEeqMTes4vOX9ugba
	3T9CkQDvQdTRXIHUt61Iu1Yuam3ap8HBC5jF2zI0T11SpVpQnRrnNpw0tcZ52GsSuZW8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173542-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173542: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=2f856d617b3b4ebbd3fe53a50a856b411f95c462
X-Osstest-Versions-That:
    libvirt=68bf64778846baade8ffcc40cc17b0e9d1d78545
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 21:17:52 +0000

flight 173542 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173542/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173490
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173490
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173490
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              2f856d617b3b4ebbd3fe53a50a856b411f95c462
baseline version:
 libvirt              68bf64778846baade8ffcc40cc17b0e9d1d78545

Last test of basis   173490  2022-10-11 04:20:15 Z    1 days
Testing same since   173542  2022-10-12 04:18:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Peter Krempa <pkrempa@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   68bf647788..2f856d617b  2f856d617b3b4ebbd3fe53a50a856b411f95c462 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 22:33:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 22:33:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421464.666787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oikI4-00066L-Vj; Wed, 12 Oct 2022 22:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421464.666787; Wed, 12 Oct 2022 22:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oikI4-00066E-Sz; Wed, 12 Oct 2022 22:33:28 +0000
Received: by outflank-mailman (input) for mailman id 421464;
 Wed, 12 Oct 2022 22:33:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VHLF=2N=kernel.org=pr-tracker-bot@srs-se1.protection.inumbo.net>)
 id 1oikI3-000668-MY
 for xen-devel@lists.xenproject.org; Wed, 12 Oct 2022 22:33:27 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e24f83f4-4a7d-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 00:33:25 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 13CF661644;
 Wed, 12 Oct 2022 22:33:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id 7B08EC433C1;
 Wed, 12 Oct 2022 22:33:23 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 5B1C6E21EC5; Wed, 12 Oct 2022 22:33:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e24f83f4-4a7d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665614003;
	bh=useAVEG1SCn7DezhXEEy/Oj9mOvG627lbhcokJs58C4=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=YFrBq0OnNPLs8udUx1RN41lWZqUQxhAH+XBRENaNPIJIcQgfu8JwIR93BR38DtwyJ
	 OSwEEqYfbC7YuNckwYygYuVWgzTnn3cb2xiDYsQLufKhNAHlRp2javXbsTbPprTtkd
	 301GAarQ0pqfIaWBQIgvtNMMZf6iBpCP0qPPbhvWzOkCFlAUXF9jCsnY5ybBSj3lZx
	 eNPI8CrEE5yECsmm5q3uiRCHzIydwgoOjJgKZq5s6BH9fSusYmqx4ou3Qae3EumDjB
	 ZCg4DaxHKheHxSrugOXvHpQPMvt6yB26097RaqYUFcSsgtNaTnNUfvmaQ8gzBs1mBz
	 84jzlCcYfXXOw==
Subject: Re: [GIT PULL] xen: branch for v6.1-rc1
From: pr-tracker-bot@kernel.org
In-Reply-To: <20221012071618.8859-1-jgross@suse.com>
References: <20221012071618.8859-1-jgross@suse.com>
X-PR-Tracked-List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
X-PR-Tracked-Message-Id: <20221012071618.8859-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc1-tag
X-PR-Tracked-Commit-Id: 7880672bdc975daa586e8256714d9906d30c615e
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: 778ce723e93ee803ef5883619fe2391e00dbc209
Message-Id: <166561400336.16489.1809685200706007965.pr-tracker-bot@kernel.org>
Date: Wed, 12 Oct 2022 22:33:23 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org

The pull request you sent on Wed, 12 Oct 2022 09:16:18 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc1-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/778ce723e93ee803ef5883619fe2391e00dbc209

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Wed Oct 12 23:18:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 12 Oct 2022 23:18:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421479.666823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oikzv-0002NI-JJ; Wed, 12 Oct 2022 23:18:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421479.666823; Wed, 12 Oct 2022 23:18:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oikzv-0002NB-FU; Wed, 12 Oct 2022 23:18:47 +0000
Received: by outflank-mailman (input) for mailman id 421479;
 Wed, 12 Oct 2022 23:18:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oikzu-0002N1-DP; Wed, 12 Oct 2022 23:18:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oikzu-0000Xk-CL; Wed, 12 Oct 2022 23:18:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oikzu-0000xI-0E; Wed, 12 Oct 2022 23:18:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oikzt-0002Yu-W2; Wed, 12 Oct 2022 23:18:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8c1lBd/y5berhYvz5Zp6NvuyLPaFe/JW32LgFKrcwz4=; b=cXHa0bUCtKd2FNQ3/PlSbtir9G
	KsaJyUFduGsrLVn15SKwMh/SCzEnwELNdm9f1NIqisBvEgewtTTJjEj4KVJ4XgppG3Kj/6Qys0Dqz
	jtFYsjB4JPGmqTL/PbNpcLti75yfhV3kK6B6EuU0cFG3XBqDUN1Rg+JxbW75XVnz0WMI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173619-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173619: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=448d28309f1a966bdc850aff1a637e0b79a03e43
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 12 Oct 2022 23:18:45 +0000

flight 173619 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173619/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  448d28309f1a966bdc850aff1a637e0b79a03e43
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    5 days
Failing since        173492  2022-10-11 13:01:50 Z    1 days    7 attempts
Testing same since   173619  2022-10-12 20:07:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 446 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:01:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:01:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421507.666875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oilf9-0008OT-7A; Thu, 13 Oct 2022 00:01:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421507.666875; Thu, 13 Oct 2022 00:01:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oilf9-0008OM-4S; Thu, 13 Oct 2022 00:01:23 +0000
Received: by outflank-mailman (input) for mailman id 421507;
 Thu, 13 Oct 2022 00:01:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oilf7-0008OB-OL; Thu, 13 Oct 2022 00:01:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oilf7-0001tx-JF; Thu, 13 Oct 2022 00:01:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oilf7-0002kT-4j; Thu, 13 Oct 2022 00:01:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oilf7-0000v7-2F; Thu, 13 Oct 2022 00:01:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DBX0F3Is1YS3wHouMI7KDbfQqzChhR8UAKqVq6gb/9Y=; b=Zmqbnzy7htZ6AYKpEGSfQ94WYt
	QhUEKLucBSYuTTB9VvQMHe38e7YjX2Fdlghh5WMWiNwAy2wzOVR0K0MW0PSfzqCHt/o+OzJ7w0TWo
	BnjyOohv6CTxHPCX2Up3gwETjQEQNtzbq/Utglx1ML2FOQJn1W4Cguvvi1qSQqDCc4fA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173573-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173573: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:build-arm64:xen-build:fail:regression
    xen-4.14-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.14-testing:build-armhf:xen-build:fail:regression
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.14-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=6e5608d1c50e0f91ed3226489d9591c70fa37c30
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 00:01:21 +0000

flight 173573 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173573/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172550
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172550
 build-armhf                   6 xen-build                fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  6e5608d1c50e0f91ed3226489d9591c70fa37c30
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   58 days
Testing same since   173496  2022-10-11 14:08:01 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 436 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:33:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:33:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421521.666905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimAK-0003X7-UI; Thu, 13 Oct 2022 00:33:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421521.666905; Thu, 13 Oct 2022 00:33:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimAK-0003X0-R7; Thu, 13 Oct 2022 00:33:36 +0000
Received: by outflank-mailman (input) for mailman id 421521;
 Thu, 13 Oct 2022 00:33:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oimAK-0003Wu-Fa
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 00:33:36 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab4a8d96-4a8e-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 02:33:34 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 1E477B81CBB;
 Thu, 13 Oct 2022 00:33:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 078B5C433D7;
 Thu, 13 Oct 2022 00:33:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab4a8d96-4a8e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665621211;
	bh=fB7Kglt4Ac9Gyls0KjANZ0nVBsi+/j+BM9SrKkjf97M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=MzjI2WKh8S3kvmoWjHCkRlXV6CHDclSmdjzkFkbWWsuzbRmZmY6ikJ6G9cbONXJJp
	 z7zeUzGyxmPWOSVuJpupmu/vyp2Ogbm5j733f6SEkFbAd94ITUOiYzcx8BczVNijre
	 ezIOnBaLwDRrx4HHExdmvPgPPioTDf0Jd36uPVXIID4mXRQ7hXXOoTCt94rSM8Zh/8
	 VKVOR/M2hx2j8k0d+rhg8+qBO2Rkm2Dn0HDviUU+QMuG1HYEec2D4usmvzMYtZya6h
	 2S4Ov1QAIYQka3hORic6POnJFQ8DlZMa4Bf5req98SJtT0vCgBudLb0nxG6GUfBs98
	 pG14jD6QO7UVA==
Date: Wed, 12 Oct 2022 17:33:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
In-Reply-To: <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
References: <20221006174804.2003029-1-olekstysh@gmail.com> <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop> <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-166717883-1665618677=:3690179"
Content-ID: <alpine.DEB.2.22.394.2210121651510.3690179@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-166717883-1665618677=:3690179
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210121651511.3690179@ubuntu-linux-20-04-desktop>

On Wed, 12 Oct 2022, Oleksandr Tyshchenko wrote:
> > On Thu, 6 Oct 2022, Oleksandr Tyshchenko wrote:
> >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>
> >> Use the same "xen-grant-dma" device concept (based on generic IOMMU
> >> device-tree bindings) for the PCI devices behind device-tree based
> >> PCI Host controller.
> >>
> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> ---
> >> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> >> on Arm at some point in the future. The Xen toolstack side is not published yet.
> >> Here, for PCI devices we use the same way to pass backend domid to the guest as for
> >> platform devices.
> >>
> >> Depends on Juergen's series:
> >> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006071500.15689-1-jgross@suse.com/__;!!GF_29dbcQIUBPA!waOk2Goc7qlhNo5-csRObryil_GzMF_e61EJR501oJ08cH2dnJulsZXWlelBDTBqa63TVoUcWQTB5NecJ1p4xFNgh2_EuA$  [lore[.]kernel[.]org]
> >> ---
> >>   drivers/xen/grant-dma-ops.c | 51 +++++++++++++++++++++++++++++--------
> >>   1 file changed, 41 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> >> index ff9be3aff87e..79d13122ec08 100644
> >> --- a/drivers/xen/grant-dma-ops.c
> >> +++ b/drivers/xen/grant-dma-ops.c
> >> @@ -10,6 +10,7 @@
> >>   #include <linux/module.h>
> >>   #include <linux/dma-map-ops.h>
> >>   #include <linux/of.h>
> >> +#include <linux/pci.h>
> >>   #include <linux/pfn.h>
> >>   #include <linux/xarray.h>
> >>   #include <linux/virtio_anchor.h>
> >> @@ -273,12 +274,28 @@ static const struct dma_map_ops xen_grant_dma_ops = {
> >>   	.dma_supported = xen_grant_dma_supported,
> >>   };
> >>   
> >> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> >> +static struct device_node *xen_dt_get_node(struct device *dev)
> >> +{
> >> +	if (dev_is_pci(dev)) {
> >> +		struct pci_dev *pdev = to_pci_dev(dev);
> >> +		struct pci_bus *bus = pdev->bus;
> >> +
> >> +		/* Walk up to the root bus to look for PCI Host controller */
> >> +		while (!pci_is_root_bus(bus))
> >> +			bus = bus->parent;
> >> +
> >> +		return of_node_get(bus->bridge->parent->of_node);
> >> +	}
> > Is it possible to have multiple virtio devices under a single virtio-pci
> > root complex?
> 
> yes
> 
> 
> > What if virtio-net has the backend in dom0 and
> > virtio-block has the backend in dom1?
> >
> > Or each virtio PCI device shows up under a different PCI root complex?
> 
> 
> Good questions. To be honest, it is not 100% clear to me yet how it is 
> supposed to be. But let's guess...
> 
> I think that having a PCI Host bridge per virtio-pci device is overkill.
> 
> So, I see two options here:
> 1. We provide PCI Host bridge per backends domain to the guest, so each 
> PCI Host bridge covers only virtio-pci devices whose backends are 
> running within *the same* domain.
> With that we would be able to use property at PCI Host bridge level.
> 
> 2. We provide only a single PCI Host bridge to the guest, so that single 
> PCI Host bridge covers all virtio-pci devices assigned to this guest.
> No matter where the corresponding backends are running (the 
> virtio-devices under that PCI Host bridge can have the backends in 
> different domains).
> With that we wouldn’t be able to use property at PCI Host bridge level. 
> And we need a more flexible option(s) to be able distinguish between 
> virtio-pci devices.
> 
> Taking into account that for virtio-pci on Arm we need to emulate a 
> specific PCI Host bridge in Xen to intercept the guest PCI config space 
> accesses
> (detect what PCI device is targeted) and forward them to the appropriate 
> backend (IOREQ Server),
> it feels to me that we likely need to go with the second option here 
> (one PCI host bridge per guest), I may mistake,
> but I don’t think that we want to emulate several PCI Host bridges for a 
> single guest (more code, more resources, etc).
> 
> 
> 
> >
> > If we can have multiple virtio PCI devices under a single PCI root
> > complex, then I think it would be better to check for a per-device
> > property, rather than a single property at the PCI root complex level.
> 
> Completely agree.
> 
> 
> >
> > The first thing that comes to mind is to describe each PCI device under
> > the root complex in device tree. Although it is uncommon (usually only
> > the PCI root complex is described in device tree), it is possible to
> > also describe in device tree all the individual PCI devices under the
> > root complex.
> >
> > Given that the domU device tree is generated by Xen and/or the Xen
> > toolstack, it would be easy to arrange for it to happen.
> 
> Technically yes. If we decide to provide only a single PCI Host bridge 
> to the guest, we will have have to deal with the virtio-pci devices with 
> various backend_domid,
> so we can consider using more flexible property 
> “iommu-map”/”iommu-map-mask” specially introduced for such purposes:
> https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt
> I think, with that we would be able to describe, i.e that virtio-pci 
> device A connects to stream_id (backend_domid) X and virtio-pci device B 
> to stream_id Y,
> and virtio-pci device C to nothing (so is not required to use grants), 
> unless I missed something.
> 
> I have looked at it and I don’t see at the moment why the idea wouldn’t 
> work, but I haven’t experimented with that yet in such context.

I think it would work too
 

> > That would solve the issue as far as I can tell, but I worry it might
> > not be a good idea because if we rely on the per-device device tree node
> > to be present then it becomes harder to implement virtio hotplug
> > (Virtio hotplug is important to add dom0less support.)
> >
> > Let's say that we create a dom0less domU with an emulated PCI root
> > complex without any devices under it, then after Dom0 is fully booted,
> > we add a virtio-net emulated device. How do we tell the guest what is
> > the backend domain id?
> >
> > Device tree and other firmware tables are not relevant anymore.
> >
> > We could reuse a PCI config space register to expose the backend id.
> > However this solution requires a backend change (QEMU) to expose the
> > backend id via an emulated register for each emulated device.
> >
> > To avoid having to introduce a special config space register in all
> > emulated PCI devices (virtio-net, virtio-block, etc) I wonder if we
> > could add a special PCI config space register at the emulated PCI Root
> > Complex level.
> >
> > Basically the workflow would be as follow:
> >
> > - Linux recognizes the PCI Root Complex as a Xen PCI Root Complex
> > - Linux writes to special PCI config space register of the Xen PCI Root
> >    Complex the PCI device id (basically the BDF)
> > - The Xen PCI Root Complex emulated by Xen answers by writing back to
> >    the same location the backend id (domid of the backend)
> > - Linux reads back the same PCI config space register of the Xen PCI
> >    Root Complex and learn the relevant domid
> >
> > What do you think?
> 
> 
> I think the idea sounds indeed interesting and would probably work, but 
> would require guest modifications other than just in drivers/xen (and 
> likely the specification changes as well).
> Which ideally of course should be avoided.
> Also I was thinking it would be nice not to diverge much between 
> communicating the backend_domid for platform and PCI devices on Arm with 
> device tree.
>
> If we managed to re-use generic IOMMU device-tree bindings for 
> virtio-mmio, we would likely be able to re-use PCI-IOMMU device-tree 
> bindings for virtio-pci,
> at least for boot PCI devices (which are known at the domain creation time).
> The more, the bindings is already present: 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml

I think using a special config space register in the root complex would
not be terrible in terms of guest changes because it is easy to
introduce a new root complex driver in Linux and other OSes. The root
complex would still be ECAM compatible so the regular ECAM driver would
still work. A new driver would only be necessary if you want to be able
to access the special config space register.

That said, for sure the fewer changes to the guest the better and I like
the existing xen,grant-dma binding.


> Regarding the hotplug devices, yes it is a valid use-case which should 
> be also supported with virtio-pci, I assume the Xenstore could be 
> re-used for that purpose if it would be available.
> The Xenstore is available with the usual Dom0 and toolstack, is it 
> available with dom0less?

Xenstore is available for dom0less if we have a dom0 running with
xenstored as one of the dom0less domains. We currently rely on it for
Xen PV drivers with dom0less.  After dom0 is fully booted, we use "xl
network-attach" to create a vif interface dynamically in the domU.

That is why I was thinking of using virtio hotplug to solve the same
problem with virtio, I was imagining that after dom0 is fully booted we
would do "xl virtio-attach" and create a new virtio interface in the
domU. But I cannot see an easy way to make virtio hotplug work together
with the xen,grant-dma bindings. I think it would be better if we find a
way to make it work without xenstore (because xenstore would be a
safety-certification dependency).

Maybe we need to think outside the box and find another solution that
doesn't rely on hotplug.

For instance, let's say that we expose the virtio devices in device tree
in a dom0less configuration too but with status = "disabled". When dom0
(or backend domain) is up and running it can signal that it is ready.
Maybe if we had a special Xen-specific PCI Root Complex driver in the
guest, it could wait for the Xen signal and then continue PCI probing at
that point honoring xen,grant-dma bindings if present in device tree
even if the devices had status = "disabled" initially.

It looks like that would require many guest changes unfortunately.


As an alternative I wonder, given that Xen emulates the PCI root
complex, if we can reuse one of the PCI link up/down delays for this
instead, like "pcie_wait_for_link". It looks like the wait time is in
millisec while we would need potentially several seconds here but it
might be possible?

Other ideas?
--8323329-166717883-1665618677=:3690179--


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:56:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:56:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421532.666928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWB-0006Dr-VC; Thu, 13 Oct 2022 00:56:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421532.666928; Thu, 13 Oct 2022 00:56:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWB-0006Dk-Re; Thu, 13 Oct 2022 00:56:11 +0000
Received: by outflank-mailman (input) for mailman id 421532;
 Thu, 13 Oct 2022 00:56:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oimWA-0006Dd-Ou
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 00:56:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d23b32da-4a91-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 02:56:07 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id E61D4B819F4;
 Thu, 13 Oct 2022 00:56:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C1FCC433C1;
 Thu, 13 Oct 2022 00:56:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d23b32da-4a91-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665622565;
	bh=66MHEqgacifMYHlGPJDL6vHpddMit9yKPTRA+6tWWlg=;
	h=Date:From:To:cc:Subject:From;
	b=mPeES/ipOSrGeLo5on6U+JluMoIB8+JWyejBIehMQBz38Vjh68GeegXJ2oE9xC4jE
	 2Qc4DcoK3+7udQyB+kGKd6SN4PiIZX/WWve/z0wK7QWb9qgrwlJ973GHnnJSlbcoVo
	 knSpAf1dCQkgl61G/bg9mMsByCOJkIefHOTQQW4ckp5U385t6XZIIGKRTWL0pJP5yV
	 YYghS8V8iv7FndQoy+y+vA12Goy7zhquAKnIRowt9hv1QyaRQB3PECDaDWqMXucp6C
	 15B1r5yK8rgAqvH+01fqten7OHpnVW/5hIg9wvqNb7nUAtbJsdqBZfRe6SaEXw7J+5
	 hRAKusCgcOuTA==
Date: Wed, 12 Oct 2022 17:56:03 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: xen-devel@lists.xenproject.org
cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org, jbeulich@suse.com, 
    george.dunlap@citrix.com, andrew.cooper3@citrix.com, 
    bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, roger.pau@citrix.com
Subject: [PATCH v4 0/4] introduce SPDX
Message-ID: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi all,

This small series introduces SPDX tags to Xen:

1) add a mention to SPDX in CODING_STYLE
2) add a LICENSES directory with licenses and SPDX tags
3) adds the SPDX single-line comment to arch/arm/*.c

Note that arch/arm/*.c is just a start. Also, to make the changes as
mechanical as possible I restricted myself to:
- adding the single-line comment at the top of the file
- removing the copyright lines (when present) from the top of the file
  header

I purposedly restrained myself to do other cleanups to the headers: this
series already touches many files and I prefer to keep these changes as
mechanical as possible. Further improvements (style improvement,
removing what's left of the header, removing copyright lines, etc.) can
be done with subsequent patches more easily.

License changes are not intentional.

Cheers,

Stefano


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:56:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:56:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421537.666939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWw-0006it-9L; Thu, 13 Oct 2022 00:56:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421537.666939; Thu, 13 Oct 2022 00:56:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWw-0006im-4p; Thu, 13 Oct 2022 00:56:58 +0000
Received: by outflank-mailman (input) for mailman id 421537;
 Thu, 13 Oct 2022 00:56:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oimWu-0006Yy-R2
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 00:56:57 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee414c69-4a91-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 02:56:54 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4916BB81CC6;
 Thu, 13 Oct 2022 00:56:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7EDAC433B5;
 Thu, 13 Oct 2022 00:56:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee414c69-4a91-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665622613;
	bh=lCJuc2Yn8N+0SmuUffclgfsPr81xB/i3BRmYA6p7aq0=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=ObYAp0Lj13o1MTbZZ9iXix3oqOoeVJzkWe+HJoDT6E6sYNt4T3wJSMMSJtelhRYzk
	 +uW/MAbVP/6DESlA4GTFZbtld7MOHfmSDfagyUcGFE2NQvKm0wFEXeGo0U6lLs4NoK
	 UGZtafc+uQm0k0ZhNr8btl4gXNke191u6liAauMfUeT9PbxI7p+xsXok1pHAaehwJo
	 BbitfkmUMfFTqYRvMXYnnpeMD8xZab5UC9sTn0jHVy/mySc0qaE33aZKYPtkTXq+7T
	 U9xTIPalpwxeLiI8Iqv2kpry3wlhUtXebvXl7o7QwEsSNlpTdB4YOk0Z7v01oGE7gy
	 RoUaMwHRJ7VCg==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v4 2/4] Remove extra copies of licenses and license headers
Date: Wed, 12 Oct 2022 17:56:46 -0700
Message-Id: <20221013005648.1444144-2-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Remove the extra copy of the GPL license and license copyright headers
from CONTRIBUTING and the top-level COPYING.

Mention of the LICENSES/ directory and also mention the SPDX tag.

SPDX support is still in progress and COPYING files in subdirectories
still need to be updated.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
Changes in v4:
- add a reference to LICENSES/
- clarify "New components"
- clarify "New files"
- move patch to #2

Patch new in v3
---
 CONTRIBUTING | 151 +++-------------------
 COPYING      | 351 +--------------------------------------------------
 2 files changed, 22 insertions(+), 480 deletions(-)

diff --git a/CONTRIBUTING b/CONTRIBUTING
index 6ec146baf0..5710a8a764 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -19,9 +19,7 @@ Most notably:
  - tools/xl           : LGPL v2.1
  - xen/include/public : MIT license
 
-The COMMON COPYRIGHT NOTICES section of this document contains
-sample copyright notices for the most common licenses used within
-this repository.
+See LICENSES/ for a list of licenses and SPDX tags currently used.
 
 When creating new components, new files, or importing code please follow
 the conventions outlined below. As a general rule, whenever code using a
@@ -35,17 +33,26 @@ New components
 When creating new components and directories that contain a
 significant amount of files that are licensed under licenses other
 than GPLv2 or the license specified in the COPYING file, please
-create a new COPYING file in that directory containing a copy of the
-license text and a rationale for using a different license. This helps
-ensure that the license of this new component/directory is maintained
-consistently with the original intention.
+create a new COPYING file in that directory containing the SPDX tag
+and a rationale for using a different license. This helps ensure that
+the license of this new component/directory is maintained consistently
+with the original intention.
 
 New files
 ---------
 
-If specific files that differ from the license in a directory are introduced,
-exceptions should be highlighted and discussed in the commit message or cover
-letter introducing the file.
+New files should start with a single-line SPDX comment to express the
+license. For instance, if the file is GPLv2, the comment would look
+like:
+
+/* SPDX-License-Identifier... */
+
+The recommended license of a directory will depend on the COPYING file.
+If the new file is using a different license, this should be highlighted
+and discussed in the commit message or cover letter introducing the
+file.
+
+See LICENSES/ for a list of licenses and SPDX tags currently used.
 
 Importing code
 --------------
@@ -105,127 +112,3 @@ For more information on contributing to this repository, see
  - https://wiki.xenproject.org/wiki/Category:Developers
 
 
-COMMON COPYRIGHT NOTICES
-========================
-
-The following section contains sample copyright notice for the most
-common licenses used within the Xen Project that is consistent with the
-projects coding standards.
-
-GPL v2 License
---------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms and conditions of the GNU General Public
- * License, version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
- */
-
-
-LGPL v2.1 License
------------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License, version 2.1, as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library; If not, see <http://www.gnu.org/licenses/>.
- */
-
-BSD-Modified License (also known as BSD-3-Clause)
--------------------------------------------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- *   1. Redistributions of source code must retain the above copyright
- *      notice, this list of conditions and the following disclaimer.
- *   2. Redistributions in binary form must reproduce the above
- *      copyright notice, this list of conditions and the following
- *      disclaimer in the documentation and/or other materials provided
- *      with the distribution.
- *   3. Neither the name of the copyright holder nor the names of its
- *      contributors may be used to endorse or promote products derived
- *      from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
- * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
- * OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-
-MIT License
------------
-
-/*
- * <File name>
- *
- * <One line description of the file and what it does>
- *
- * Copyright (C) <year>  <name of author and/or company>
- *
- * Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without restriction,
- * including without limitation the rights to use, copy, modify, merge,
- * publish, distribute, sublicense, and/or sell copies of the Software,
- * and to permit persons to whom the Software is furnished to do so,
- * subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
- * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
- * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
- * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- */
-
diff --git a/COPYING b/COPYING
index a4bc2b2dd4..824c3aa353 100644
--- a/COPYING
+++ b/COPYING
@@ -3,11 +3,11 @@ GNU General Public License
 --------------------------
 
 Most files in this repository are licensed under the terms of the GNU
-General Public License (GPL), a copy of which is attached at the end
-of this notice. Note that the only valid version of the GPL as far as
-the files in this repository are concerned is _this_ particular
-version of the license (i.e., *only* v2, not v2.2 or v3.x or
-whatever), unless explicitly otherwise stated.
+General Public License (GPL), a copy of which is present under the
+LICENSES/ directory. Note that the only valid version of the GPL as far
+as the files in this repository are concerned is _this_ particular
+version of the license (i.e., *only* v2, not v2.2 or v3.x or whatever),
+unless explicitly otherwise stated.
 
 Some code fragments in the hypervisor and associated subsystems
 include other license stanzas: the most common ones are listed in
@@ -73,344 +73,3 @@ governs the license of its containing directory and its subdirectories.
 
 For more information, see the CONTRIBUTING file.
 
-=====================================================================
-
-		    GNU GENERAL PUBLIC LICENSE
-		       Version 2, June 1991
-
- Copyright (C) 1989, 1991 Free Software Foundation, Inc.
-                       59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- Everyone is permitted to copy and distribute verbatim copies
- of this license document, but changing it is not allowed.
-
-			    Preamble
-
-  The licenses for most software are designed to take away your
-freedom to share and change it.  By contrast, the GNU General Public
-License is intended to guarantee your freedom to share and change free
-software--to make sure the software is free for all its users.  This
-General Public License applies to most of the Free Software
-Foundation's software and to any other program whose authors commit to
-using it.  (Some other Free Software Foundation software is covered by
-the GNU Library General Public License instead.)  You can apply it to
-your programs, too.
-
-  When we speak of free software, we are referring to freedom, not
-price.  Our General Public Licenses are designed to make sure that you
-have the freedom to distribute copies of free software (and charge for
-this service if you wish), that you receive source code or can get it
-if you want it, that you can change the software or use pieces of it
-in new free programs; and that you know you can do these things.
-
-  To protect your rights, we need to make restrictions that forbid
-anyone to deny you these rights or to ask you to surrender the rights.
-These restrictions translate to certain responsibilities for you if you
-distribute copies of the software, or if you modify it.
-
-  For example, if you distribute copies of such a program, whether
-gratis or for a fee, you must give the recipients all the rights that
-you have.  You must make sure that they, too, receive or can get the
-source code.  And you must show them these terms so they know their
-rights.
-
-  We protect your rights with two steps: (1) copyright the software, and
-(2) offer you this license which gives you legal permission to copy,
-distribute and/or modify the software.
-
-  Also, for each author's protection and ours, we want to make certain
-that everyone understands that there is no warranty for this free
-software.  If the software is modified by someone else and passed on, we
-want its recipients to know that what they have is not the original, so
-that any problems introduced by others will not reflect on the original
-authors' reputations.
-
-  Finally, any free program is threatened constantly by software
-patents.  We wish to avoid the danger that redistributors of a free
-program will individually obtain patent licenses, in effect making the
-program proprietary.  To prevent this, we have made it clear that any
-patent must be licensed for everyone's free use or not licensed at all.
-
-  The precise terms and conditions for copying, distribution and
-modification follow.
-
-		    GNU GENERAL PUBLIC LICENSE
-   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
-
-  0. This License applies to any program or other work which contains
-a notice placed by the copyright holder saying it may be distributed
-under the terms of this General Public License.  The "Program", below,
-refers to any such program or work, and a "work based on the Program"
-means either the Program or any derivative work under copyright law:
-that is to say, a work containing the Program or a portion of it,
-either verbatim or with modifications and/or translated into another
-language.  (Hereinafter, translation is included without limitation in
-the term "modification".)  Each licensee is addressed as "you".
-
-Activities other than copying, distribution and modification are not
-covered by this License; they are outside its scope.  The act of
-running the Program is not restricted, and the output from the Program
-is covered only if its contents constitute a work based on the
-Program (independent of having been made by running the Program).
-Whether that is true depends on what the Program does.
-
-  1. You may copy and distribute verbatim copies of the Program's
-source code as you receive it, in any medium, provided that you
-conspicuously and appropriately publish on each copy an appropriate
-copyright notice and disclaimer of warranty; keep intact all the
-notices that refer to this License and to the absence of any warranty;
-and give any other recipients of the Program a copy of this License
-along with the Program.
-
-You may charge a fee for the physical act of transferring a copy, and
-you may at your option offer warranty protection in exchange for a fee.
-
-  2. You may modify your copy or copies of the Program or any portion
-of it, thus forming a work based on the Program, and copy and
-distribute such modifications or work under the terms of Section 1
-above, provided that you also meet all of these conditions:
-
-    a) You must cause the modified files to carry prominent notices
-    stating that you changed the files and the date of any change.
-
-    b) You must cause any work that you distribute or publish, that in
-    whole or in part contains or is derived from the Program or any
-    part thereof, to be licensed as a whole at no charge to all third
-    parties under the terms of this License.
-
-    c) If the modified program normally reads commands interactively
-    when run, you must cause it, when started running for such
-    interactive use in the most ordinary way, to print or display an
-    announcement including an appropriate copyright notice and a
-    notice that there is no warranty (or else, saying that you provide
-    a warranty) and that users may redistribute the program under
-    these conditions, and telling the user how to view a copy of this
-    License.  (Exception: if the Program itself is interactive but
-    does not normally print such an announcement, your work based on
-    the Program is not required to print an announcement.)
-
-These requirements apply to the modified work as a whole.  If
-identifiable sections of that work are not derived from the Program,
-and can be reasonably considered independent and separate works in
-themselves, then this License, and its terms, do not apply to those
-sections when you distribute them as separate works.  But when you
-distribute the same sections as part of a whole which is a work based
-on the Program, the distribution of the whole must be on the terms of
-this License, whose permissions for other licensees extend to the
-entire whole, and thus to each and every part regardless of who wrote it.
-
-Thus, it is not the intent of this section to claim rights or contest
-your rights to work written entirely by you; rather, the intent is to
-exercise the right to control the distribution of derivative or
-collective works based on the Program.
-
-In addition, mere aggregation of another work not based on the Program
-with the Program (or with a work based on the Program) on a volume of
-a storage or distribution medium does not bring the other work under
-the scope of this License.
-
-  3. You may copy and distribute the Program (or a work based on it,
-under Section 2) in object code or executable form under the terms of
-Sections 1 and 2 above provided that you also do one of the following:
-
-    a) Accompany it with the complete corresponding machine-readable
-    source code, which must be distributed under the terms of Sections
-    1 and 2 above on a medium customarily used for software interchange; or,
-
-    b) Accompany it with a written offer, valid for at least three
-    years, to give any third party, for a charge no more than your
-    cost of physically performing source distribution, a complete
-    machine-readable copy of the corresponding source code, to be
-    distributed under the terms of Sections 1 and 2 above on a medium
-    customarily used for software interchange; or,
-
-    c) Accompany it with the information you received as to the offer
-    to distribute corresponding source code.  (This alternative is
-    allowed only for noncommercial distribution and only if you
-    received the program in object code or executable form with such
-    an offer, in accord with Subsection b above.)
-
-The source code for a work means the preferred form of the work for
-making modifications to it.  For an executable work, complete source
-code means all the source code for all modules it contains, plus any
-associated interface definition files, plus the scripts used to
-control compilation and installation of the executable.  However, as a
-special exception, the source code distributed need not include
-anything that is normally distributed (in either source or binary
-form) with the major components (compiler, kernel, and so on) of the
-operating system on which the executable runs, unless that component
-itself accompanies the executable.
-
-If distribution of executable or object code is made by offering
-access to copy from a designated place, then offering equivalent
-access to copy the source code from the same place counts as
-distribution of the source code, even though third parties are not
-compelled to copy the source along with the object code.
-
-  4. You may not copy, modify, sublicense, or distribute the Program
-except as expressly provided under this License.  Any attempt
-otherwise to copy, modify, sublicense or distribute the Program is
-void, and will automatically terminate your rights under this License.
-However, parties who have received copies, or rights, from you under
-this License will not have their licenses terminated so long as such
-parties remain in full compliance.
-
-  5. You are not required to accept this License, since you have not
-signed it.  However, nothing else grants you permission to modify or
-distribute the Program or its derivative works.  These actions are
-prohibited by law if you do not accept this License.  Therefore, by
-modifying or distributing the Program (or any work based on the
-Program), you indicate your acceptance of this License to do so, and
-all its terms and conditions for copying, distributing or modifying
-the Program or works based on it.
-
-  6. Each time you redistribute the Program (or any work based on the
-Program), the recipient automatically receives a license from the
-original licensor to copy, distribute or modify the Program subject to
-these terms and conditions.  You may not impose any further
-restrictions on the recipients' exercise of the rights granted herein.
-You are not responsible for enforcing compliance by third parties to
-this License.
-
-  7. If, as a consequence of a court judgment or allegation of patent
-infringement or for any other reason (not limited to patent issues),
-conditions are imposed on you (whether by court order, agreement or
-otherwise) that contradict the conditions of this License, they do not
-excuse you from the conditions of this License.  If you cannot
-distribute so as to satisfy simultaneously your obligations under this
-License and any other pertinent obligations, then as a consequence you
-may not distribute the Program at all.  For example, if a patent
-license would not permit royalty-free redistribution of the Program by
-all those who receive copies directly or indirectly through you, then
-the only way you could satisfy both it and this License would be to
-refrain entirely from distribution of the Program.
-
-If any portion of this section is held invalid or unenforceable under
-any particular circumstance, the balance of the section is intended to
-apply and the section as a whole is intended to apply in other
-circumstances.
-
-It is not the purpose of this section to induce you to infringe any
-patents or other property right claims or to contest validity of any
-such claims; this section has the sole purpose of protecting the
-integrity of the free software distribution system, which is
-implemented by public license practices.  Many people have made
-generous contributions to the wide range of software distributed
-through that system in reliance on consistent application of that
-system; it is up to the author/donor to decide if he or she is willing
-to distribute software through any other system and a licensee cannot
-impose that choice.
-
-This section is intended to make thoroughly clear what is believed to
-be a consequence of the rest of this License.
-
-  8. If the distribution and/or use of the Program is restricted in
-certain countries either by patents or by copyrighted interfaces, the
-original copyright holder who places the Program under this License
-may add an explicit geographical distribution limitation excluding
-those countries, so that distribution is permitted only in or among
-countries not thus excluded.  In such case, this License incorporates
-the limitation as if written in the body of this License.
-
-  9. The Free Software Foundation may publish revised and/or new versions
-of the General Public License from time to time.  Such new versions will
-be similar in spirit to the present version, but may differ in detail to
-address new problems or concerns.
-
-Each version is given a distinguishing version number.  If the Program
-specifies a version number of this License which applies to it and "any
-later version", you have the option of following the terms and conditions
-either of that version or of any later version published by the Free
-Software Foundation.  If the Program does not specify a version number of
-this License, you may choose any version ever published by the Free Software
-Foundation.
-
-  10. If you wish to incorporate parts of the Program into other free
-programs whose distribution conditions are different, write to the author
-to ask for permission.  For software which is copyrighted by the Free
-Software Foundation, write to the Free Software Foundation; we sometimes
-make exceptions for this.  Our decision will be guided by the two goals
-of preserving the free status of all derivatives of our free software and
-of promoting the sharing and reuse of software generally.
-
-			    NO WARRANTY
-
-  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
-FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
-OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
-PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
-OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
-MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
-TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
-PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
-REPAIR OR CORRECTION.
-
-  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
-WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
-REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
-INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
-OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
-TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
-YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
-PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGES.
-
-		     END OF TERMS AND CONDITIONS
-
-	    How to Apply These Terms to Your New Programs
-
-  If you develop a new program, and you want it to be of the greatest
-possible use to the public, the best way to achieve this is to make it
-free software which everyone can redistribute and change under these terms.
-
-  To do so, attach the following notices to the program.  It is safest
-to attach them to the start of each source file to most effectively
-convey the exclusion of warranty; and each file should have at least
-the "copyright" line and a pointer to where the full notice is found.
-
-    <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) <year>  <name of author>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program; If not, see <http://www.gnu.org/licenses/>.
-
-
-Also add information on how to contact you by electronic and paper mail.
-
-If the program is interactive, make it output a short notice like this
-when it starts in an interactive mode:
-
-    Gnomovision version 69, Copyright (C) year name of author
-    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-    This is free software, and you are welcome to redistribute it
-    under certain conditions; type `show c' for details.
-
-The hypothetical commands `show w' and `show c' should show the appropriate
-parts of the General Public License.  Of course, the commands you use may
-be called something other than `show w' and `show c'; they could even be
-mouse-clicks or menu items--whatever suits your program.
-
-You should also get your employer (if you work as a programmer) or your
-school, if any, to sign a "copyright disclaimer" for the program, if
-necessary.  Here is a sample; alter the names:
-
-  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
-  `Gnomovision' (which makes passes at compilers) written by James Hacker.
-
-  <signature of Ty Coon>, 1 April 1989
-  Ty Coon, President of Vice
-
-This General Public License does not permit incorporating your program into
-proprietary programs.  If your program is a subroutine library, you may
-consider it more useful to permit linking proprietary applications with the
-library.  If this is what you want to do, use the GNU Library General
-Public License instead of this License.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:56:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421538.666949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWx-0006z1-KE; Thu, 13 Oct 2022 00:56:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421538.666949; Thu, 13 Oct 2022 00:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWx-0006ys-Gz; Thu, 13 Oct 2022 00:56:59 +0000
Received: by outflank-mailman (input) for mailman id 421538;
 Thu, 13 Oct 2022 00:56:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oimWu-0006e6-Pd
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 00:56:57 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ece1a66f-4a91-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 02:56:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id AE7B961695;
 Thu, 13 Oct 2022 00:56:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13DCCC433D7;
 Thu, 13 Oct 2022 00:56:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ece1a66f-4a91-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665622611;
	bh=kv0C9i3WZxpoDc6DyzCsPG+n6++3Plq2iYWObiespMw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=dO5FqgyXAJNt3M9hwYJvAn0eBAViI8FERW84S0INtqzGCybxPwMthOzZrU3J2jLla
	 Ad5KdRtVQ0coQGtpYvZDn8XxWV2VsDILxU5I4JQ2PtBmDHHGxZCnJ34vTrSD2uGGT9
	 RqaVH1E20ssA9Bmb95CjcET2Qweg/M3WrRVTW/S0kWxzlnmTAx/mVu6OY1uwmc9T22
	 vObLTA8NT2oxLYagJiFy7eMb31uby4u8g1hQ2LGHFDluW1MosrWgYi3NMrQB4i66XL
	 RLU7JwBwXWblramjH7FPE/cbEjfvkopcwsvOXp8Bhp+bzl43/GFDhoL9QZShmiL6WV
	 zAgJ6JVmiYZ/g==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v4 1/4] Add licenses under LICENSES
Date: Wed, 12 Oct 2022 17:56:45 -0700
Message-Id: <20221013005648.1444144-1-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Add the individual licenses under a new top-level directory named
"LICENSES". Each license file includes its related SPDX tags.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
Changes in v4:
- add ack
- move patch to #1
---
 LICENSES/BSD-2-Clause       |  32 +++
 LICENSES/BSD-3-Clause       |  36 +++
 LICENSES/BSD-3-Clause-Clear |  41 +++
 LICENSES/GPL-2.0            | 359 +++++++++++++++++++++++++
 LICENSES/LGPL-2.0           | 487 ++++++++++++++++++++++++++++++++++
 LICENSES/LGPL-2.1           | 503 ++++++++++++++++++++++++++++++++++++
 LICENSES/MIT                |  30 +++
 7 files changed, 1488 insertions(+)
 create mode 100644 LICENSES/BSD-2-Clause
 create mode 100644 LICENSES/BSD-3-Clause
 create mode 100644 LICENSES/BSD-3-Clause-Clear
 create mode 100644 LICENSES/GPL-2.0
 create mode 100644 LICENSES/LGPL-2.0
 create mode 100644 LICENSES/LGPL-2.1
 create mode 100644 LICENSES/MIT

diff --git a/LICENSES/BSD-2-Clause b/LICENSES/BSD-2-Clause
new file mode 100644
index 0000000000..da366e2ce5
--- /dev/null
+++ b/LICENSES/BSD-2-Clause
@@ -0,0 +1,32 @@
+Valid-License-Identifier: BSD-2-Clause
+SPDX-URL: https://spdx.org/licenses/BSD-2-Clause.html
+Usage-Guide:
+  To use the BSD 2-clause "Simplified" License put the following SPDX
+  tag/value pair into a comment according to the placement guidelines in
+  the licensing rules documentation:
+    SPDX-License-Identifier: BSD-2-Clause
+License-Text:
+
+Copyright (c) <year> <owner> . All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
diff --git a/LICENSES/BSD-3-Clause b/LICENSES/BSD-3-Clause
new file mode 100644
index 0000000000..34c7f057c8
--- /dev/null
+++ b/LICENSES/BSD-3-Clause
@@ -0,0 +1,36 @@
+Valid-License-Identifier: BSD-3-Clause
+SPDX-URL: https://spdx.org/licenses/BSD-3-Clause.html
+Usage-Guide:
+  To use the BSD 3-clause "New" or "Revised" License put the following SPDX
+  tag/value pair into a comment according to the placement guidelines in
+  the licensing rules documentation:
+    SPDX-License-Identifier: BSD-3-Clause
+License-Text:
+
+Copyright (c) <year> <owner> . All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holder nor the names of its
+   contributors may be used to endorse or promote products derived from this
+   software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
diff --git a/LICENSES/BSD-3-Clause-Clear b/LICENSES/BSD-3-Clause-Clear
new file mode 100644
index 0000000000..e53b56092b
--- /dev/null
+++ b/LICENSES/BSD-3-Clause-Clear
@@ -0,0 +1,41 @@
+Valid-License-Identifier: BSD-3-Clause-Clear
+SPDX-URL: https://spdx.org/licenses/BSD-3-Clause-Clear.html
+Usage-Guide:
+  To use the BSD 3-clause "Clear" License put the following SPDX
+  tag/value pair into a comment according to the placement guidelines in
+  the licensing rules documentation:
+    SPDX-License-Identifier: BSD-3-Clause-Clear
+License-Text:
+
+The Clear BSD License
+
+Copyright (c) [xxxx]-[xxxx] [Owner Organization]
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted (subject to the limitations in the disclaimer
+below) provided that the following conditions are met:
+
+ * Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+
+ * Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in the
+   documentation and/or other materials provided with the distribution.
+
+ * Neither the name of [Owner Organization] nor the names of its
+   contributors may be used to endorse or promote products derived from
+   this software without specific prior written permission.
+
+NO EXPRESS OR IMPLIED LICENSES TO ANY PARTY'S PATENT RIGHTS ARE GRANTED BY
+THIS LICENSE. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
+CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
+NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER
+OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
+OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
+OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
+ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/LICENSES/GPL-2.0 b/LICENSES/GPL-2.0
new file mode 100644
index 0000000000..ff0812fd89
--- /dev/null
+++ b/LICENSES/GPL-2.0
@@ -0,0 +1,359 @@
+Valid-License-Identifier: GPL-2.0
+Valid-License-Identifier: GPL-2.0-only
+Valid-License-Identifier: GPL-2.0+
+Valid-License-Identifier: GPL-2.0-or-later
+SPDX-URL: https://spdx.org/licenses/GPL-2.0.html
+Usage-Guide:
+  To use this license in source code, put one of the following SPDX
+  tag/value pairs into a comment according to the placement
+  guidelines in the licensing rules documentation.
+  For 'GNU General Public License (GPL) version 2 only' use:
+    SPDX-License-Identifier: GPL-2.0
+  or
+    SPDX-License-Identifier: GPL-2.0-only
+  For 'GNU General Public License (GPL) version 2 or any later version' use:
+    SPDX-License-Identifier: GPL-2.0+
+  or
+    SPDX-License-Identifier: GPL-2.0-or-later
+License-Text:
+
+		    GNU GENERAL PUBLIC LICENSE
+		       Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.
+                       51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
+			    Preamble
+
+  The licenses for most software are designed to take away your
+freedom to share and change it.  By contrast, the GNU General Public
+License is intended to guarantee your freedom to share and change free
+software--to make sure the software is free for all its users.  This
+General Public License applies to most of the Free Software
+Foundation's software and to any other program whose authors commit to
+using it.  (Some other Free Software Foundation software is covered by
+the GNU Library General Public License instead.)  You can apply it to
+your programs, too.
+
+  When we speak of free software, we are referring to freedom, not
+price.  Our General Public Licenses are designed to make sure that you
+have the freedom to distribute copies of free software (and charge for
+this service if you wish), that you receive source code or can get it
+if you want it, that you can change the software or use pieces of it
+in new free programs; and that you know you can do these things.
+
+  To protect your rights, we need to make restrictions that forbid
+anyone to deny you these rights or to ask you to surrender the rights.
+These restrictions translate to certain responsibilities for you if you
+distribute copies of the software, or if you modify it.
+
+  For example, if you distribute copies of such a program, whether
+gratis or for a fee, you must give the recipients all the rights that
+you have.  You must make sure that they, too, receive or can get the
+source code.  And you must show them these terms so they know their
+rights.
+
+  We protect your rights with two steps: (1) copyright the software, and
+(2) offer you this license which gives you legal permission to copy,
+distribute and/or modify the software.
+
+  Also, for each author's protection and ours, we want to make certain
+that everyone understands that there is no warranty for this free
+software.  If the software is modified by someone else and passed on, we
+want its recipients to know that what they have is not the original, so
+that any problems introduced by others will not reflect on the original
+authors' reputations.
+
+  Finally, any free program is threatened constantly by software
+patents.  We wish to avoid the danger that redistributors of a free
+program will individually obtain patent licenses, in effect making the
+program proprietary.  To prevent this, we have made it clear that any
+patent must be licensed for everyone's free use or not licensed at all.
+
+  The precise terms and conditions for copying, distribution and
+modification follow.
+
+		    GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. This License applies to any program or other work which contains
+a notice placed by the copyright holder saying it may be distributed
+under the terms of this General Public License.  The "Program", below,
+refers to any such program or work, and a "work based on the Program"
+means either the Program or any derivative work under copyright law:
+that is to say, a work containing the Program or a portion of it,
+either verbatim or with modifications and/or translated into another
+language.  (Hereinafter, translation is included without limitation in
+the term "modification".)  Each licensee is addressed as "you".
+
+Activities other than copying, distribution and modification are not
+covered by this License; they are outside its scope.  The act of
+running the Program is not restricted, and the output from the Program
+is covered only if its contents constitute a work based on the
+Program (independent of having been made by running the Program).
+Whether that is true depends on what the Program does.
+
+  1. You may copy and distribute verbatim copies of the Program's
+source code as you receive it, in any medium, provided that you
+conspicuously and appropriately publish on each copy an appropriate
+copyright notice and disclaimer of warranty; keep intact all the
+notices that refer to this License and to the absence of any warranty;
+and give any other recipients of the Program a copy of this License
+along with the Program.
+
+You may charge a fee for the physical act of transferring a copy, and
+you may at your option offer warranty protection in exchange for a fee.
+
+  2. You may modify your copy or copies of the Program or any portion
+of it, thus forming a work based on the Program, and copy and
+distribute such modifications or work under the terms of Section 1
+above, provided that you also meet all of these conditions:
+
+    a) You must cause the modified files to carry prominent notices
+    stating that you changed the files and the date of any change.
+
+    b) You must cause any work that you distribute or publish, that in
+    whole or in part contains or is derived from the Program or any
+    part thereof, to be licensed as a whole at no charge to all third
+    parties under the terms of this License.
+
+    c) If the modified program normally reads commands interactively
+    when run, you must cause it, when started running for such
+    interactive use in the most ordinary way, to print or display an
+    announcement including an appropriate copyright notice and a
+    notice that there is no warranty (or else, saying that you provide
+    a warranty) and that users may redistribute the program under
+    these conditions, and telling the user how to view a copy of this
+    License.  (Exception: if the Program itself is interactive but
+    does not normally print such an announcement, your work based on
+    the Program is not required to print an announcement.)
+
+These requirements apply to the modified work as a whole.  If
+identifiable sections of that work are not derived from the Program,
+and can be reasonably considered independent and separate works in
+themselves, then this License, and its terms, do not apply to those
+sections when you distribute them as separate works.  But when you
+distribute the same sections as part of a whole which is a work based
+on the Program, the distribution of the whole must be on the terms of
+this License, whose permissions for other licensees extend to the
+entire whole, and thus to each and every part regardless of who wrote it.
+
+Thus, it is not the intent of this section to claim rights or contest
+your rights to work written entirely by you; rather, the intent is to
+exercise the right to control the distribution of derivative or
+collective works based on the Program.
+
+In addition, mere aggregation of another work not based on the Program
+with the Program (or with a work based on the Program) on a volume of
+a storage or distribution medium does not bring the other work under
+the scope of this License.
+
+  3. You may copy and distribute the Program (or a work based on it,
+under Section 2) in object code or executable form under the terms of
+Sections 1 and 2 above provided that you also do one of the following:
+
+    a) Accompany it with the complete corresponding machine-readable
+    source code, which must be distributed under the terms of Sections
+    1 and 2 above on a medium customarily used for software interchange; or,
+
+    b) Accompany it with a written offer, valid for at least three
+    years, to give any third party, for a charge no more than your
+    cost of physically performing source distribution, a complete
+    machine-readable copy of the corresponding source code, to be
+    distributed under the terms of Sections 1 and 2 above on a medium
+    customarily used for software interchange; or,
+
+    c) Accompany it with the information you received as to the offer
+    to distribute corresponding source code.  (This alternative is
+    allowed only for noncommercial distribution and only if you
+    received the program in object code or executable form with such
+    an offer, in accord with Subsection b above.)
+
+The source code for a work means the preferred form of the work for
+making modifications to it.  For an executable work, complete source
+code means all the source code for all modules it contains, plus any
+associated interface definition files, plus the scripts used to
+control compilation and installation of the executable.  However, as a
+special exception, the source code distributed need not include
+anything that is normally distributed (in either source or binary
+form) with the major components (compiler, kernel, and so on) of the
+operating system on which the executable runs, unless that component
+itself accompanies the executable.
+
+If distribution of executable or object code is made by offering
+access to copy from a designated place, then offering equivalent
+access to copy the source code from the same place counts as
+distribution of the source code, even though third parties are not
+compelled to copy the source along with the object code.
+
+  4. You may not copy, modify, sublicense, or distribute the Program
+except as expressly provided under this License.  Any attempt
+otherwise to copy, modify, sublicense or distribute the Program is
+void, and will automatically terminate your rights under this License.
+However, parties who have received copies, or rights, from you under
+this License will not have their licenses terminated so long as such
+parties remain in full compliance.
+
+  5. You are not required to accept this License, since you have not
+signed it.  However, nothing else grants you permission to modify or
+distribute the Program or its derivative works.  These actions are
+prohibited by law if you do not accept this License.  Therefore, by
+modifying or distributing the Program (or any work based on the
+Program), you indicate your acceptance of this License to do so, and
+all its terms and conditions for copying, distributing or modifying
+the Program or works based on it.
+
+  6. Each time you redistribute the Program (or any work based on the
+Program), the recipient automatically receives a license from the
+original licensor to copy, distribute or modify the Program subject to
+these terms and conditions.  You may not impose any further
+restrictions on the recipients' exercise of the rights granted herein.
+You are not responsible for enforcing compliance by third parties to
+this License.
+
+  7. If, as a consequence of a court judgment or allegation of patent
+infringement or for any other reason (not limited to patent issues),
+conditions are imposed on you (whether by court order, agreement or
+otherwise) that contradict the conditions of this License, they do not
+excuse you from the conditions of this License.  If you cannot
+distribute so as to satisfy simultaneously your obligations under this
+License and any other pertinent obligations, then as a consequence you
+may not distribute the Program at all.  For example, if a patent
+license would not permit royalty-free redistribution of the Program by
+all those who receive copies directly or indirectly through you, then
+the only way you could satisfy both it and this License would be to
+refrain entirely from distribution of the Program.
+
+If any portion of this section is held invalid or unenforceable under
+any particular circumstance, the balance of the section is intended to
+apply and the section as a whole is intended to apply in other
+circumstances.
+
+It is not the purpose of this section to induce you to infringe any
+patents or other property right claims or to contest validity of any
+such claims; this section has the sole purpose of protecting the
+integrity of the free software distribution system, which is
+implemented by public license practices.  Many people have made
+generous contributions to the wide range of software distributed
+through that system in reliance on consistent application of that
+system; it is up to the author/donor to decide if he or she is willing
+to distribute software through any other system and a licensee cannot
+impose that choice.
+
+This section is intended to make thoroughly clear what is believed to
+be a consequence of the rest of this License.
+
+  8. If the distribution and/or use of the Program is restricted in
+certain countries either by patents or by copyrighted interfaces, the
+original copyright holder who places the Program under this License
+may add an explicit geographical distribution limitation excluding
+those countries, so that distribution is permitted only in or among
+countries not thus excluded.  In such case, this License incorporates
+the limitation as if written in the body of this License.
+
+  9. The Free Software Foundation may publish revised and/or new versions
+of the General Public License from time to time.  Such new versions will
+be similar in spirit to the present version, but may differ in detail to
+address new problems or concerns.
+
+Each version is given a distinguishing version number.  If the Program
+specifies a version number of this License which applies to it and "any
+later version", you have the option of following the terms and conditions
+either of that version or of any later version published by the Free
+Software Foundation.  If the Program does not specify a version number of
+this License, you may choose any version ever published by the Free Software
+Foundation.
+
+  10. If you wish to incorporate parts of the Program into other free
+programs whose distribution conditions are different, write to the author
+to ask for permission.  For software which is copyrighted by the Free
+Software Foundation, write to the Free Software Foundation; we sometimes
+make exceptions for this.  Our decision will be guided by the two goals
+of preserving the free status of all derivatives of our free software and
+of promoting the sharing and reuse of software generally.
+
+			    NO WARRANTY
+
+  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
+OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
+OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
+TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
+PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
+REPAIR OR CORRECTION.
+
+  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
+INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
+OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
+TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
+YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
+PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGES.
+
+		     END OF TERMS AND CONDITIONS
+
+	    How to Apply These Terms to Your New Programs
+
+  If you develop a new program, and you want it to be of the greatest
+possible use to the public, the best way to achieve this is to make it
+free software which everyone can redistribute and change under these terms.
+
+  To do so, attach the following notices to the program.  It is safest
+to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least
+the "copyright" line and a pointer to where the full notice is found.
+
+    <one line to give the program's name and a brief idea of what it does.>
+    Copyright (C) <year>  <name of author>
+
+    This program is free software; you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation; either version 2 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program; if not, write to the Free Software
+    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+
+
+Also add information on how to contact you by electronic and paper mail.
+
+If the program is interactive, make it output a short notice like this
+when it starts in an interactive mode:
+
+    Gnomovision version 69, Copyright (C) year name of author
+    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
+    This is free software, and you are welcome to redistribute it
+    under certain conditions; type `show c' for details.
+
+The hypothetical commands `show w' and `show c' should show the appropriate
+parts of the General Public License.  Of course, the commands you use may
+be called something other than `show w' and `show c'; they could even be
+mouse-clicks or menu items--whatever suits your program.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the program, if
+necessary.  Here is a sample; alter the names:
+
+  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
+  `Gnomovision' (which makes passes at compilers) written by James Hacker.
+
+  <signature of Ty Coon>, 1 April 1989
+  Ty Coon, President of Vice
+
+This General Public License does not permit incorporating your program into
+proprietary programs.  If your program is a subroutine library, you may
+consider it more useful to permit linking proprietary applications with the
+library.  If this is what you want to do, use the GNU Library General
+Public License instead of this License.
diff --git a/LICENSES/LGPL-2.0 b/LICENSES/LGPL-2.0
new file mode 100644
index 0000000000..957d798fe0
--- /dev/null
+++ b/LICENSES/LGPL-2.0
@@ -0,0 +1,487 @@
+Valid-License-Identifier: LGPL-2.0
+Valid-License-Identifier: LGPL-2.0+
+SPDX-URL: https://spdx.org/licenses/LGPL-2.0.html
+Usage-Guide:
+  To use this license in source code, put one of the following SPDX
+  tag/value pairs into a comment according to the placement
+  guidelines in the licensing rules documentation.
+  For 'GNU Library General Public License (LGPL) version 2.0 only' use:
+    SPDX-License-Identifier: LGPL-2.0
+  For 'GNU Library General Public License (LGPL) version 2.0 or any later
+  version' use:
+    SPDX-License-Identifier: LGPL-2.0+
+License-Text:
+
+GNU LIBRARY GENERAL PUBLIC LICENSE
+Version 2, June 1991
+
+Copyright (C) 1991 Free Software Foundation, Inc.
+51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+[This is the first released version of the library GPL. It is numbered 2
+because it goes with version 2 of the ordinary GPL.]
+
+Preamble
+
+The licenses for most software are designed to take away your freedom to
+share and change it. By contrast, the GNU General Public Licenses are
+intended to guarantee your freedom to share and change free software--to
+make sure the software is free for all its users.
+
+This license, the Library General Public License, applies to some specially
+designated Free Software Foundation software, and to any other libraries
+whose authors decide to use it. You can use it for your libraries, too.
+
+When we speak of free software, we are referring to freedom, not price. Our
+General Public Licenses are designed to make sure that you have the freedom
+to distribute copies of free software (and charge for this service if you
+wish), that you receive source code or can get it if you want it, that you
+can change the software or use pieces of it in new free programs; and that
+you know you can do these things.
+
+To protect your rights, we need to make restrictions that forbid anyone to
+deny you these rights or to ask you to surrender the rights. These
+restrictions translate to certain responsibilities for you if you
+distribute copies of the library, or if you modify it.
+
+For example, if you distribute copies of the library, whether gratis or for
+a fee, you must give the recipients all the rights that we gave you. You
+must make sure that they, too, receive or can get the source code. If you
+link a program with the library, you must provide complete object files to
+the recipients so that they can relink them with the library, after making
+changes to the library and recompiling it. And you must show them these
+terms so they know their rights.
+
+Our method of protecting your rights has two steps: (1) copyright the
+library, and (2) offer you this license which gives you legal permission to
+copy, distribute and/or modify the library.
+
+Also, for each distributor's protection, we want to make certain that
+everyone understands that there is no warranty for this free library. If
+the library is modified by someone else and passed on, we want its
+recipients to know that what they have is not the original version, so that
+any problems introduced by others will not reflect on the original authors'
+reputations.
+
+Finally, any free program is threatened constantly by software patents. We
+wish to avoid the danger that companies distributing free software will
+individually obtain patent licenses, thus in effect transforming the
+program into proprietary software. To prevent this, we have made it clear
+that any patent must be licensed for everyone's free use or not licensed at
+all.
+
+Most GNU software, including some libraries, is covered by the ordinary GNU
+General Public License, which was designed for utility programs. This
+license, the GNU Library General Public License, applies to certain
+designated libraries. This license is quite different from the ordinary
+one; be sure to read it in full, and don't assume that anything in it is
+the same as in the ordinary license.
+
+The reason we have a separate public license for some libraries is that
+they blur the distinction we usually make between modifying or adding to a
+program and simply using it. Linking a program with a library, without
+changing the library, is in some sense simply using the library, and is
+analogous to running a utility program or application program. However, in
+a textual and legal sense, the linked executable is a combined work, a
+derivative of the original library, and the ordinary General Public License
+treats it as such.
+
+Because of this blurred distinction, using the ordinary General Public
+License for libraries did not effectively promote software sharing, because
+most developers did not use the libraries. We concluded that weaker
+conditions might promote sharing better.
+
+However, unrestricted linking of non-free programs would deprive the users
+of those programs of all benefit from the free status of the libraries
+themselves. This Library General Public License is intended to permit
+developers of non-free programs to use free libraries, while preserving
+your freedom as a user of such programs to change the free libraries that
+are incorporated in them. (We have not seen how to achieve this as regards
+changes in header files, but we have achieved it as regards changes in the
+actual functions of the Library.) The hope is that this will lead to faster
+development of free libraries.
+
+The precise terms and conditions for copying, distribution and modification
+follow. Pay close attention to the difference between a "work based on the
+library" and a "work that uses the library". The former contains code
+derived from the library, while the latter only works together with the
+library.
+
+Note that it is possible for a library to be covered by the ordinary
+General Public License rather than by this special one.
+
+TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+0. This License Agreement applies to any software library which contains a
+   notice placed by the copyright holder or other authorized party saying
+   it may be distributed under the terms of this Library General Public
+   License (also called "this License"). Each licensee is addressed as
+   "you".
+
+   A "library" means a collection of software functions and/or data
+   prepared so as to be conveniently linked with application programs
+   (which use some of those functions and data) to form executables.
+
+   The "Library", below, refers to any such software library or work which
+   has been distributed under these terms. A "work based on the Library"
+   means either the Library or any derivative work under copyright law:
+   that is to say, a work containing the Library or a portion of it, either
+   verbatim or with modifications and/or translated straightforwardly into
+   another language. (Hereinafter, translation is included without
+   limitation in the term "modification".)
+
+   "Source code" for a work means the preferred form of the work for making
+   modifications to it. For a library, complete source code means all the
+   source code for all modules it contains, plus any associated interface
+   definition files, plus the scripts used to control compilation and
+   installation of the library.
+
+   Activities other than copying, distribution and modification are not
+   covered by this License; they are outside its scope. The act of running
+   a program using the Library is not restricted, and output from such a
+   program is covered only if its contents constitute a work based on the
+   Library (independent of the use of the Library in a tool for writing
+   it). Whether that is true depends on what the Library does and what the
+   program that uses the Library does.
+
+1. You may copy and distribute verbatim copies of the Library's complete
+   source code as you receive it, in any medium, provided that you
+   conspicuously and appropriately publish on each copy an appropriate
+   copyright notice and disclaimer of warranty; keep intact all the notices
+   that refer to this License and to the absence of any warranty; and
+   distribute a copy of this License along with the Library.
+
+   You may charge a fee for the physical act of transferring a copy, and
+   you may at your option offer warranty protection in exchange for a fee.
+
+2. You may modify your copy or copies of the Library or any portion of it,
+   thus forming a work based on the Library, and copy and distribute such
+   modifications or work under the terms of Section 1 above, provided that
+   you also meet all of these conditions:
+
+   a) The modified work must itself be a software library.
+
+   b) You must cause the files modified to carry prominent notices stating
+      that you changed the files and the date of any change.
+
+   c) You must cause the whole of the work to be licensed at no charge to
+      all third parties under the terms of this License.
+
+   d) If a facility in the modified Library refers to a function or a table
+      of data to be supplied by an application program that uses the
+      facility, other than as an argument passed when the facility is
+      invoked, then you must make a good faith effort to ensure that, in
+      the event an application does not supply such function or table, the
+      facility still operates, and performs whatever part of its purpose
+      remains meaningful.
+
+   (For example, a function in a library to compute square roots has a
+   purpose that is entirely well-defined independent of the
+   application. Therefore, Subsection 2d requires that any
+   application-supplied function or table used by this function must be
+   optional: if the application does not supply it, the square root
+   function must still compute square roots.)
+
+   These requirements apply to the modified work as a whole. If
+   identifiable sections of that work are not derived from the Library, and
+   can be reasonably considered independent and separate works in
+   themselves, then this License, and its terms, do not apply to those
+   sections when you distribute them as separate works. But when you
+   distribute the same sections as part of a whole which is a work based on
+   the Library, the distribution of the whole must be on the terms of this
+   License, whose permissions for other licensees extend to the entire
+   whole, and thus to each and every part regardless of who wrote it.
+
+   Thus, it is not the intent of this section to claim rights or contest
+   your rights to work written entirely by you; rather, the intent is to
+   exercise the right to control the distribution of derivative or
+   collective works based on the Library.
+
+   In addition, mere aggregation of another work not based on the Library
+   with the Library (or with a work based on the Library) on a volume of a
+   storage or distribution medium does not bring the other work under the
+   scope of this License.
+
+3. You may opt to apply the terms of the ordinary GNU General Public
+   License instead of this License to a given copy of the Library. To do
+   this, you must alter all the notices that refer to this License, so that
+   they refer to the ordinary GNU General Public License, version 2,
+   instead of to this License. (If a newer version than version 2 of the
+   ordinary GNU General Public License has appeared, then you can specify
+   that version instead if you wish.) Do not make any other change in these
+   notices.
+
+   Once this change is made in a given copy, it is irreversible for that
+   copy, so the ordinary GNU General Public License applies to all
+   subsequent copies and derivative works made from that copy.
+
+   This option is useful when you wish to copy part of the code of the
+   Library into a program that is not a library.
+
+4. You may copy and distribute the Library (or a portion or derivative of
+   it, under Section 2) in object code or executable form under the terms
+   of Sections 1 and 2 above provided that you accompany it with the
+   complete corresponding machine-readable source code, which must be
+   distributed under the terms of Sections 1 and 2 above on a medium
+   customarily used for software interchange.
+
+   If distribution of object code is made by offering access to copy from a
+   designated place, then offering equivalent access to copy the source
+   code from the same place satisfies the requirement to distribute the
+   source code, even though third parties are not compelled to copy the
+   source along with the object code.
+
+5. A program that contains no derivative of any portion of the Library, but
+   is designed to work with the Library by being compiled or linked with
+   it, is called a "work that uses the Library". Such a work, in isolation,
+   is not a derivative work of the Library, and therefore falls outside the
+   scope of this License.
+
+   However, linking a "work that uses the Library" with the Library creates
+   an executable that is a derivative of the Library (because it contains
+   portions of the Library), rather than a "work that uses the
+   library". The executable is therefore covered by this License. Section 6
+   states terms for distribution of such executables.
+
+   When a "work that uses the Library" uses material from a header file
+   that is part of the Library, the object code for the work may be a
+   derivative work of the Library even though the source code is
+   not. Whether this is true is especially significant if the work can be
+   linked without the Library, or if the work is itself a library. The
+   threshold for this to be true is not precisely defined by law.
+
+   If such an object file uses only numerical parameters, data structure
+   layouts and accessors, and small macros and small inline functions (ten
+   lines or less in length), then the use of the object file is
+   unrestricted, regardless of whether it is legally a derivative
+   work. (Executables containing this object code plus portions of the
+   Library will still fall under Section 6.)
+
+   Otherwise, if the work is a derivative of the Library, you may
+   distribute the object code for the work under the terms of Section
+   6. Any executables containing that work also fall under Section 6,
+   whether or not they are linked directly with the Library itself.
+
+6. As an exception to the Sections above, you may also compile or link a
+   "work that uses the Library" with the Library to produce a work
+   containing portions of the Library, and distribute that work under terms
+   of your choice, provided that the terms permit modification of the work
+   for the customer's own use and reverse engineering for debugging such
+   modifications.
+
+   You must give prominent notice with each copy of the work that the
+   Library is used in it and that the Library and its use are covered by
+   this License. You must supply a copy of this License. If the work during
+   execution displays copyright notices, you must include the copyright
+   notice for the Library among them, as well as a reference directing the
+   user to the copy of this License. Also, you must do one of these things:
+
+   a) Accompany the work with the complete corresponding machine-readable
+      source code for the Library including whatever changes were used in
+      the work (which must be distributed under Sections 1 and 2 above);
+      and, if the work is an executable linked with the Library, with the
+      complete machine-readable "work that uses the Library", as object
+      code and/or source code, so that the user can modify the Library and
+      then relink to produce a modified executable containing the modified
+      Library. (It is understood that the user who changes the contents of
+      definitions files in the Library will not necessarily be able to
+      recompile the application to use the modified definitions.)
+
+   b) Accompany the work with a written offer, valid for at least three
+      years, to give the same user the materials specified in Subsection
+      6a, above, for a charge no more than the cost of performing this
+      distribution.
+
+   c) If distribution of the work is made by offering access to copy from a
+      designated place, offer equivalent access to copy the above specified
+      materials from the same place.
+
+   d) Verify that the user has already received a copy of these materials
+      or that you have already sent this user a copy.
+
+   For an executable, the required form of the "work that uses the Library"
+   must include any data and utility programs needed for reproducing the
+   executable from it. However, as a special exception, the source code
+   distributed need not include anything that is normally distributed (in
+   either source or binary form) with the major components (compiler,
+   kernel, and so on) of the operating system on which the executable runs,
+   unless that component itself accompanies the executable.
+
+   It may happen that this requirement contradicts the license restrictions
+   of other proprietary libraries that do not normally accompany the
+   operating system. Such a contradiction means you cannot use both them
+   and the Library together in an executable that you distribute.
+
+7. You may place library facilities that are a work based on the Library
+   side-by-side in a single library together with other library facilities
+   not covered by this License, and distribute such a combined library,
+   provided that the separate distribution of the work based on the Library
+   and of the other library facilities is otherwise permitted, and provided
+   that you do these two things:
+
+   a) Accompany the combined library with a copy of the same work based on
+      the Library, uncombined with any other library facilities. This must
+      be distributed under the terms of the Sections above.
+
+   b) Give prominent notice with the combined library of the fact that part
+      of it is a work based on the Library, and explaining where to find
+      the accompanying uncombined form of the same work.
+
+8. You may not copy, modify, sublicense, link with, or distribute the
+   Library except as expressly provided under this License. Any attempt
+   otherwise to copy, modify, sublicense, link with, or distribute the
+   Library is void, and will automatically terminate your rights under this
+   License. However, parties who have received copies, or rights, from you
+   under this License will not have their licenses terminated so long as
+   such parties remain in full compliance.
+
+9. You are not required to accept this License, since you have not signed
+   it. However, nothing else grants you permission to modify or distribute
+   the Library or its derivative works. These actions are prohibited by law
+   if you do not accept this License. Therefore, by modifying or
+   distributing the Library (or any work based on the Library), you
+   indicate your acceptance of this License to do so, and all its terms and
+   conditions for copying, distributing or modifying the Library or works
+   based on it.
+
+10. Each time you redistribute the Library (or any work based on the
+    Library), the recipient automatically receives a license from the
+    original licensor to copy, distribute, link with or modify the Library
+    subject to these terms and conditions. You may not impose any further
+    restrictions on the recipients' exercise of the rights granted
+    herein. You are not responsible for enforcing compliance by third
+    parties to this License.
+
+11. If, as a consequence of a court judgment or allegation of patent
+    infringement or for any other reason (not limited to patent issues),
+    conditions are imposed on you (whether by court order, agreement or
+    otherwise) that contradict the conditions of this License, they do not
+    excuse you from the conditions of this License. If you cannot
+    distribute so as to satisfy simultaneously your obligations under this
+    License and any other pertinent obligations, then as a consequence you
+    may not distribute the Library at all. For example, if a patent license
+    would not permit royalty-free redistribution of the Library by all
+    those who receive copies directly or indirectly through you, then the
+    only way you could satisfy both it and this License would be to refrain
+    entirely from distribution of the Library.
+
+    If any portion of this section is held invalid or unenforceable under
+    any particular circumstance, the balance of the section is intended to
+    apply, and the section as a whole is intended to apply in other
+    circumstances.
+
+    It is not the purpose of this section to induce you to infringe any
+    patents or other property right claims or to contest validity of any
+    such claims; this section has the sole purpose of protecting the
+    integrity of the free software distribution system which is implemented
+    by public license practices. Many people have made generous
+    contributions to the wide range of software distributed through that
+    system in reliance on consistent application of that system; it is up
+    to the author/donor to decide if he or she is willing to distribute
+    software through any other system and a licensee cannot impose that
+    choice.
+
+    This section is intended to make thoroughly clear what is believed to
+    be a consequence of the rest of this License.
+
+12. If the distribution and/or use of the Library is restricted in certain
+    countries either by patents or by copyrighted interfaces, the original
+    copyright holder who places the Library under this License may add an
+    explicit geographical distribution limitation excluding those
+    countries, so that distribution is permitted only in or among countries
+    not thus excluded. In such case, this License incorporates the
+    limitation as if written in the body of this License.
+
+13. The Free Software Foundation may publish revised and/or new versions of
+    the Library General Public License from time to time. Such new versions
+    will be similar in spirit to the present version, but may differ in
+    detail to address new problems or concerns.
+
+    Each version is given a distinguishing version number. If the Library
+    specifies a version number of this License which applies to it and "any
+    later version", you have the option of following the terms and
+    conditions either of that version or of any later version published by
+    the Free Software Foundation. If the Library does not specify a license
+    version number, you may choose any version ever published by the Free
+    Software Foundation.
+
+14. If you wish to incorporate parts of the Library into other free
+    programs whose distribution conditions are incompatible with these,
+    write to the author to ask for permission. For software which is
+    copyrighted by the Free Software Foundation, write to the Free Software
+    Foundation; we sometimes make exceptions for this. Our decision will be
+    guided by the two goals of preserving the free status of all
+    derivatives of our free software and of promoting the sharing and reuse
+    of software generally.
+
+NO WARRANTY
+
+15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+    FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN
+    OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+    PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER
+    EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE
+    ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE LIBRARY IS WITH
+    YOU. SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL
+    NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+    WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+    REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU FOR
+    DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL
+    DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE LIBRARY
+    (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED
+    INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF
+    THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF SUCH HOLDER OR
+    OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.
+
+END OF TERMS AND CONDITIONS
+
+How to Apply These Terms to Your New Libraries
+
+If you develop a new library, and you want it to be of the greatest
+possible use to the public, we recommend making it free software that
+everyone can redistribute and change. You can do so by permitting
+redistribution under these terms (or, alternatively, under the terms of the
+ordinary General Public License).
+
+To apply these terms, attach the following notices to the library. It is
+safest to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least the
+"copyright" line and a pointer to where the full notice is found.
+
+one line to give the library's name and an idea of what it does.
+Copyright (C) year name of author
+
+This library is free software; you can redistribute it and/or modify it
+under the terms of the GNU Library General Public License as published by
+the Free Software Foundation; either version 2 of the License, or (at your
+option) any later version.
+
+This library is distributed in the hope that it will be useful, but WITHOUT
+ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public
+License for more details.
+
+You should have received a copy of the GNU Library General Public License
+along with this library; if not, write to the Free Software Foundation,
+Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+
+Also add information on how to contact you by electronic and paper mail.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the library, if
+necessary. Here is a sample; alter the names:
+
+Yoyodyne, Inc., hereby disclaims all copyright interest in
+the library `Frob' (a library for tweaking knobs) written
+by James Random Hacker.
+
+signature of Ty Coon, 1 April 1990
+Ty Coon, President of Vice
+
+That's all there is to it!
diff --git a/LICENSES/LGPL-2.1 b/LICENSES/LGPL-2.1
new file mode 100644
index 0000000000..27bb4342a3
--- /dev/null
+++ b/LICENSES/LGPL-2.1
@@ -0,0 +1,503 @@
+Valid-License-Identifier: LGPL-2.1
+Valid-License-Identifier: LGPL-2.1+
+SPDX-URL: https://spdx.org/licenses/LGPL-2.1.html
+Usage-Guide:
+  To use this license in source code, put one of the following SPDX
+  tag/value pairs into a comment according to the placement
+  guidelines in the licensing rules documentation.
+  For 'GNU Lesser General Public License (LGPL) version 2.1 only' use:
+    SPDX-License-Identifier: LGPL-2.1
+  For 'GNU Lesser General Public License (LGPL) version 2.1 or any later
+  version' use:
+    SPDX-License-Identifier: LGPL-2.1+
+License-Text:
+
+GNU LESSER GENERAL PUBLIC LICENSE
+Version 2.1, February 1999
+
+Copyright (C) 1991, 1999 Free Software Foundation, Inc.
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+[This is the first released version of the Lesser GPL. It also counts as
+the successor of the GNU Library Public License, version 2, hence the
+version number 2.1.]
+
+Preamble
+
+The licenses for most software are designed to take away your freedom to
+share and change it. By contrast, the GNU General Public Licenses are
+intended to guarantee your freedom to share and change free software--to
+make sure the software is free for all its users.
+
+This license, the Lesser General Public License, applies to some specially
+designated software packages--typically libraries--of the Free Software
+Foundation and other authors who decide to use it. You can use it too, but
+we suggest you first think carefully about whether this license or the
+ordinary General Public License is the better strategy to use in any
+particular case, based on the explanations below.
+
+When we speak of free software, we are referring to freedom of use, not
+price. Our General Public Licenses are designed to make sure that you have
+the freedom to distribute copies of free software (and charge for this
+service if you wish); that you receive source code or can get it if you
+want it; that you can change the software and use pieces of it in new free
+programs; and that you are informed that you can do these things.
+
+To protect your rights, we need to make restrictions that forbid
+distributors to deny you these rights or to ask you to surrender these
+rights. These restrictions translate to certain responsibilities for you if
+you distribute copies of the library or if you modify it.
+
+For example, if you distribute copies of the library, whether gratis or for
+a fee, you must give the recipients all the rights that we gave you. You
+must make sure that they, too, receive or can get the source code. If you
+link other code with the library, you must provide complete object files to
+the recipients, so that they can relink them with the library after making
+changes to the library and recompiling it. And you must show them these
+terms so they know their rights.
+
+We protect your rights with a two-step method: (1) we copyright the
+library, and (2) we offer you this license, which gives you legal
+permission to copy, distribute and/or modify the library.
+
+To protect each distributor, we want to make it very clear that there is no
+warranty for the free library. Also, if the library is modified by someone
+else and passed on, the recipients should know that what they have is not
+the original version, so that the original author's reputation will not be
+affected by problems that might be introduced by others.
+
+Finally, software patents pose a constant threat to the existence of any
+free program. We wish to make sure that a company cannot effectively
+restrict the users of a free program by obtaining a restrictive license
+from a patent holder. Therefore, we insist that any patent license obtained
+for a version of the library must be consistent with the full freedom of
+use specified in this license.
+
+Most GNU software, including some libraries, is covered by the ordinary GNU
+General Public License. This license, the GNU Lesser General Public
+License, applies to certain designated libraries, and is quite different
+from the ordinary General Public License. We use this license for certain
+libraries in order to permit linking those libraries into non-free
+programs.
+
+When a program is linked with a library, whether statically or using a
+shared library, the combination of the two is legally speaking a combined
+work, a derivative of the original library. The ordinary General Public
+License therefore permits such linking only if the entire combination fits
+its criteria of freedom. The Lesser General Public License permits more lax
+criteria for linking other code with the library.
+
+We call this license the "Lesser" General Public License because it does
+Less to protect the user's freedom than the ordinary General Public
+License. It also provides other free software developers Less of an
+advantage over competing non-free programs. These disadvantages are the
+reason we use the ordinary General Public License for many
+libraries. However, the Lesser license provides advantages in certain
+special circumstances.
+
+For example, on rare occasions, there may be a special need to encourage
+the widest possible use of a certain library, so that it becomes a de-facto
+standard. To achieve this, non-free programs must be allowed to use the
+library. A more frequent case is that a free library does the same job as
+widely used non-free libraries. In this case, there is little to gain by
+limiting the free library to free software only, so we use the Lesser
+General Public License.
+
+In other cases, permission to use a particular library in non-free programs
+enables a greater number of people to use a large body of free
+software. For example, permission to use the GNU C Library in non-free
+programs enables many more people to use the whole GNU operating system, as
+well as its variant, the GNU/Linux operating system.
+
+Although the Lesser General Public License is Less protective of the users'
+freedom, it does ensure that the user of a program that is linked with the
+Library has the freedom and the wherewithal to run that program using a
+modified version of the Library.
+
+The precise terms and conditions for copying, distribution and modification
+follow. Pay close attention to the difference between a "work based on the
+library" and a "work that uses the library". The former contains code
+derived from the library, whereas the latter must be combined with the
+library in order to run.
+
+TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+0. This License Agreement applies to any software library or other program
+   which contains a notice placed by the copyright holder or other
+   authorized party saying it may be distributed under the terms of this
+   Lesser General Public License (also called "this License"). Each
+   licensee is addressed as "you".
+
+   A "library" means a collection of software functions and/or data
+   prepared so as to be conveniently linked with application programs
+   (which use some of those functions and data) to form executables.
+
+   The "Library", below, refers to any such software library or work which
+   has been distributed under these terms. A "work based on the Library"
+   means either the Library or any derivative work under copyright law:
+   that is to say, a work containing the Library or a portion of it, either
+   verbatim or with modifications and/or translated straightforwardly into
+   another language. (Hereinafter, translation is included without
+   limitation in the term "modification".)
+
+   "Source code" for a work means the preferred form of the work for making
+   modifications to it. For a library, complete source code means all the
+   source code for all modules it contains, plus any associated interface
+   definition files, plus the scripts used to control compilation and
+   installation of the library.
+
+    Activities other than copying, distribution and modification are not
+    covered by this License; they are outside its scope. The act of running
+    a program using the Library is not restricted, and output from such a
+    program is covered only if its contents constitute a work based on the
+    Library (independent of the use of the Library in a tool for writing
+    it). Whether that is true depends on what the Library does and what the
+    program that uses the Library does.
+
+1. You may copy and distribute verbatim copies of the Library's complete
+   source code as you receive it, in any medium, provided that you
+   conspicuously and appropriately publish on each copy an appropriate
+   copyright notice and disclaimer of warranty; keep intact all the notices
+   that refer to this License and to the absence of any warranty; and
+   distribute a copy of this License along with the Library.
+
+   You may charge a fee for the physical act of transferring a copy, and
+   you may at your option offer warranty protection in exchange for a fee.
+
+2. You may modify your copy or copies of the Library or any portion of it,
+   thus forming a work based on the Library, and copy and distribute such
+   modifications or work under the terms of Section 1 above, provided that
+   you also meet all of these conditions:
+
+   a) The modified work must itself be a software library.
+
+   b) You must cause the files modified to carry prominent notices stating
+      that you changed the files and the date of any change.
+
+   c) You must cause the whole of the work to be licensed at no charge to
+      all third parties under the terms of this License.
+
+   d) If a facility in the modified Library refers to a function or a table
+      of data to be supplied by an application program that uses the
+      facility, other than as an argument passed when the facility is
+      invoked, then you must make a good faith effort to ensure that, in
+      the event an application does not supply such function or table, the
+      facility still operates, and performs whatever part of its purpose
+      remains meaningful.
+
+   (For example, a function in a library to compute square roots has a
+    purpose that is entirely well-defined independent of the
+    application. Therefore, Subsection 2d requires that any
+    application-supplied function or table used by this function must be
+    optional: if the application does not supply it, the square root
+    function must still compute square roots.)
+
+   These requirements apply to the modified work as a whole. If
+   identifiable sections of that work are not derived from the Library, and
+   can be reasonably considered independent and separate works in
+   themselves, then this License, and its terms, do not apply to those
+   sections when you distribute them as separate works. But when you
+   distribute the same sections as part of a whole which is a work based on
+   the Library, the distribution of the whole must be on the terms of this
+   License, whose permissions for other licensees extend to the entire
+   whole, and thus to each and every part regardless of who wrote it.
+
+   Thus, it is not the intent of this section to claim rights or contest
+   your rights to work written entirely by you; rather, the intent is to
+   exercise the right to control the distribution of derivative or
+   collective works based on the Library.
+
+   In addition, mere aggregation of another work not based on the Library
+   with the Library (or with a work based on the Library) on a volume of a
+   storage or distribution medium does not bring the other work under the
+   scope of this License.
+
+3. You may opt to apply the terms of the ordinary GNU General Public
+   License instead of this License to a given copy of the Library. To do
+   this, you must alter all the notices that refer to this License, so that
+   they refer to the ordinary GNU General Public License, version 2,
+   instead of to this License. (If a newer version than version 2 of the
+   ordinary GNU General Public License has appeared, then you can specify
+   that version instead if you wish.) Do not make any other change in these
+   notices.
+
+   Once this change is made in a given copy, it is irreversible for that
+   copy, so the ordinary GNU General Public License applies to all
+   subsequent copies and derivative works made from that copy.
+
+   This option is useful when you wish to copy part of the code of the
+   Library into a program that is not a library.
+
+4. You may copy and distribute the Library (or a portion or derivative of
+   it, under Section 2) in object code or executable form under the terms
+   of Sections 1 and 2 above provided that you accompany it with the
+   complete corresponding machine-readable source code, which must be
+   distributed under the terms of Sections 1 and 2 above on a medium
+   customarily used for software interchange.
+
+   If distribution of object code is made by offering access to copy from a
+   designated place, then offering equivalent access to copy the source
+   code from the same place satisfies the requirement to distribute the
+   source code, even though third parties are not compelled to copy the
+   source along with the object code.
+
+5. A program that contains no derivative of any portion of the Library, but
+   is designed to work with the Library by being compiled or linked with
+   it, is called a "work that uses the Library". Such a work, in isolation,
+   is not a derivative work of the Library, and therefore falls outside the
+   scope of this License.
+
+   However, linking a "work that uses the Library" with the Library creates
+   an executable that is a derivative of the Library (because it contains
+   portions of the Library), rather than a "work that uses the
+   library". The executable is therefore covered by this License. Section 6
+   states terms for distribution of such executables.
+
+   When a "work that uses the Library" uses material from a header file
+   that is part of the Library, the object code for the work may be a
+   derivative work of the Library even though the source code is
+   not. Whether this is true is especially significant if the work can be
+   linked without the Library, or if the work is itself a library. The
+   threshold for this to be true is not precisely defined by law.
+
+   If such an object file uses only numerical parameters, data structure
+   layouts and accessors, and small macros and small inline functions (ten
+   lines or less in length), then the use of the object file is
+   unrestricted, regardless of whether it is legally a derivative
+   work. (Executables containing this object code plus portions of the
+   Library will still fall under Section 6.)
+
+   Otherwise, if the work is a derivative of the Library, you may
+   distribute the object code for the work under the terms of Section
+   6. Any executables containing that work also fall under Section 6,
+   whether or not they are linked directly with the Library itself.
+
+6. As an exception to the Sections above, you may also combine or link a
+   "work that uses the Library" with the Library to produce a work
+   containing portions of the Library, and distribute that work under terms
+   of your choice, provided that the terms permit modification of the work
+   for the customer's own use and reverse engineering for debugging such
+   modifications.
+
+   You must give prominent notice with each copy of the work that the
+   Library is used in it and that the Library and its use are covered by
+   this License. You must supply a copy of this License. If the work during
+   execution displays copyright notices, you must include the copyright
+   notice for the Library among them, as well as a reference directing the
+   user to the copy of this License. Also, you must do one of these things:
+
+   a) Accompany the work with the complete corresponding machine-readable
+      source code for the Library including whatever changes were used in
+      the work (which must be distributed under Sections 1 and 2 above);
+      and, if the work is an executable linked with the Library, with the
+      complete machine-readable "work that uses the Library", as object
+      code and/or source code, so that the user can modify the Library and
+      then relink to produce a modified executable containing the modified
+      Library. (It is understood that the user who changes the contents of
+      definitions files in the Library will not necessarily be able to
+      recompile the application to use the modified definitions.)
+
+   b) Use a suitable shared library mechanism for linking with the
+      Library. A suitable mechanism is one that (1) uses at run time a copy
+      of the library already present on the user's computer system, rather
+      than copying library functions into the executable, and (2) will
+      operate properly with a modified version of the library, if the user
+      installs one, as long as the modified version is interface-compatible
+      with the version that the work was made with.
+
+   c) Accompany the work with a written offer, valid for at least three
+      years, to give the same user the materials specified in Subsection
+      6a, above, for a charge no more than the cost of performing this
+      distribution.
+
+   d) If distribution of the work is made by offering access to copy from a
+      designated place, offer equivalent access to copy the above specified
+      materials from the same place.
+
+   e) Verify that the user has already received a copy of these materials
+      or that you have already sent this user a copy.
+
+   For an executable, the required form of the "work that uses the Library"
+   must include any data and utility programs needed for reproducing the
+   executable from it. However, as a special exception, the materials to be
+   distributed need not include anything that is normally distributed (in
+   either source or binary form) with the major components (compiler,
+   kernel, and so on) of the operating system on which the executable runs,
+   unless that component itself accompanies the executable.
+
+   It may happen that this requirement contradicts the license restrictions
+   of other proprietary libraries that do not normally accompany the
+   operating system. Such a contradiction means you cannot use both them
+   and the Library together in an executable that you distribute.
+
+7. You may place library facilities that are a work based on the Library
+   side-by-side in a single library together with other library facilities
+   not covered by this License, and distribute such a combined library,
+   provided that the separate distribution of the work based on the Library
+   and of the other library facilities is otherwise permitted, and provided
+   that you do these two things:
+
+   a) Accompany the combined library with a copy of the same work based on
+      the Library, uncombined with any other library facilities. This must
+      be distributed under the terms of the Sections above.
+
+   b) Give prominent notice with the combined library of the fact that part
+      of it is a work based on the Library, and explaining where to find
+      the accompanying uncombined form of the same work.
+
+8. You may not copy, modify, sublicense, link with, or distribute the
+   Library except as expressly provided under this License. Any attempt
+   otherwise to copy, modify, sublicense, link with, or distribute the
+   Library is void, and will automatically terminate your rights under this
+   License. However, parties who have received copies, or rights, from you
+   under this License will not have their licenses terminated so long as
+   such parties remain in full compliance.
+
+9. You are not required to accept this License, since you have not signed
+   it. However, nothing else grants you permission to modify or distribute
+   the Library or its derivative works. These actions are prohibited by law
+   if you do not accept this License. Therefore, by modifying or
+   distributing the Library (or any work based on the Library), you
+   indicate your acceptance of this License to do so, and all its terms and
+   conditions for copying, distributing or modifying the Library or works
+   based on it.
+
+10. Each time you redistribute the Library (or any work based on the
+    Library), the recipient automatically receives a license from the
+    original licensor to copy, distribute, link with or modify the Library
+    subject to these terms and conditions. You may not impose any further
+    restrictions on the recipients' exercise of the rights granted
+    herein. You are not responsible for enforcing compliance by third
+    parties with this License.
+
+11. If, as a consequence of a court judgment or allegation of patent
+    infringement or for any other reason (not limited to patent issues),
+    conditions are imposed on you (whether by court order, agreement or
+    otherwise) that contradict the conditions of this License, they do not
+    excuse you from the conditions of this License. If you cannot
+    distribute so as to satisfy simultaneously your obligations under this
+    License and any other pertinent obligations, then as a consequence you
+    may not distribute the Library at all. For example, if a patent license
+    would not permit royalty-free redistribution of the Library by all
+    those who receive copies directly or indirectly through you, then the
+    only way you could satisfy both it and this License would be to refrain
+    entirely from distribution of the Library.
+
+    If any portion of this section is held invalid or unenforceable under
+    any particular circumstance, the balance of the section is intended to
+    apply, and the section as a whole is intended to apply in other
+    circumstances.
+
+    It is not the purpose of this section to induce you to infringe any
+    patents or other property right claims or to contest validity of any
+    such claims; this section has the sole purpose of protecting the
+    integrity of the free software distribution system which is implemented
+    by public license practices. Many people have made generous
+    contributions to the wide range of software distributed through that
+    system in reliance on consistent application of that system; it is up
+    to the author/donor to decide if he or she is willing to distribute
+    software through any other system and a licensee cannot impose that
+    choice.
+
+    This section is intended to make thoroughly clear what is believed to
+    be a consequence of the rest of this License.
+
+12. If the distribution and/or use of the Library is restricted in certain
+    countries either by patents or by copyrighted interfaces, the original
+    copyright holder who places the Library under this License may add an
+    explicit geographical distribution limitation excluding those
+    countries, so that distribution is permitted only in or among countries
+    not thus excluded. In such case, this License incorporates the
+    limitation as if written in the body of this License.
+
+13. The Free Software Foundation may publish revised and/or new versions of
+    the Lesser General Public License from time to time. Such new versions
+    will be similar in spirit to the present version, but may differ in
+    detail to address new problems or concerns.
+
+    Each version is given a distinguishing version number. If the Library
+    specifies a version number of this License which applies to it and "any
+    later version", you have the option of following the terms and
+    conditions either of that version or of any later version published by
+    the Free Software Foundation. If the Library does not specify a license
+    version number, you may choose any version ever published by the Free
+    Software Foundation.
+
+14. If you wish to incorporate parts of the Library into other free
+    programs whose distribution conditions are incompatible with these,
+    write to the author to ask for permission. For software which is
+    copyrighted by the Free Software Foundation, write to the Free Software
+    Foundation; we sometimes make exceptions for this. Our decision will be
+    guided by the two goals of preserving the free status of all
+    derivatives of our free software and of promoting the sharing and reuse
+    of software generally.
+
+NO WARRANTY
+
+15. BECAUSE THE LIBRARY IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
+    FOR THE LIBRARY, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN
+    OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
+    PROVIDE THE LIBRARY "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER
+    EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE
+    ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE LIBRARY IS WITH
+    YOU. SHOULD THE LIBRARY PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL
+    NECESSARY SERVICING, REPAIR OR CORRECTION.
+
+16. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
+    WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
+    REDISTRIBUTE THE LIBRARY AS PERMITTED ABOVE, BE LIABLE TO YOU FOR
+    DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL
+    DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE LIBRARY
+    (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED
+    INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF
+    THE LIBRARY TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF SUCH HOLDER OR
+    OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.
+
+END OF TERMS AND CONDITIONS
+
+How to Apply These Terms to Your New Libraries
+
+If you develop a new library, and you want it to be of the greatest
+possible use to the public, we recommend making it free software that
+everyone can redistribute and change. You can do so by permitting
+redistribution under these terms (or, alternatively, under the terms of the
+ordinary General Public License).
+
+To apply these terms, attach the following notices to the library. It is
+safest to attach them to the start of each source file to most effectively
+convey the exclusion of warranty; and each file should have at least the
+"copyright" line and a pointer to where the full notice is found.
+
+one line to give the library's name and an idea of what it does.
+Copyright (C) year name of author
+
+This library is free software; you can redistribute it and/or modify it
+under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation; either version 2.1 of the License, or (at
+your option) any later version.
+
+This library is distributed in the hope that it will be useful, but WITHOUT
+ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
+for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with this library; if not, write to the Free Software Foundation,
+Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Also add
+information on how to contact you by electronic and paper mail.
+
+You should also get your employer (if you work as a programmer) or your
+school, if any, to sign a "copyright disclaimer" for the library, if
+necessary. Here is a sample; alter the names:
+
+Yoyodyne, Inc., hereby disclaims all copyright interest in
+the library `Frob' (a library for tweaking knobs) written
+by James Random Hacker.
+
+signature of Ty Coon, 1 April 1990
+Ty Coon, President of Vice
+That's all there is to it!
diff --git a/LICENSES/MIT b/LICENSES/MIT
new file mode 100644
index 0000000000..f33a68ceb3
--- /dev/null
+++ b/LICENSES/MIT
@@ -0,0 +1,30 @@
+Valid-License-Identifier: MIT
+SPDX-URL: https://spdx.org/licenses/MIT.html
+Usage-Guide:
+  To use the MIT License put the following SPDX tag/value pair into a
+  comment according to the placement guidelines in the licensing rules
+  documentation:
+    SPDX-License-Identifier: MIT
+License-Text:
+
+MIT License
+
+Copyright (c) <year> <copyright holders>
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the "Software"),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense,
+and/or sell copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:57:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:57:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421539.666955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWy-00071b-0f; Thu, 13 Oct 2022 00:57:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421539.666955; Thu, 13 Oct 2022 00:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimWx-000715-Pu; Thu, 13 Oct 2022 00:56:59 +0000
Received: by outflank-mailman (input) for mailman id 421539;
 Thu, 13 Oct 2022 00:56:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oimWv-0006e6-Ph
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 00:56:57 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eecd9407-4a91-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 02:56:56 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 21C0E61683;
 Thu, 13 Oct 2022 00:56:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CD5AC433C1;
 Thu, 13 Oct 2022 00:56:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eecd9407-4a91-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665622614;
	bh=Pn0SMEjA4kouOtSJc3+2PqkihW2Mj/UTC9QmDMLz6gU=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=elermjqtwshMiAiqQdTeN7C6vWj/JfY8s+FOi8lTL8oreIpSJJ6CWaL+C/88VKIWT
	 tU7MsM6CUi973ExvRLUDUdgg914x5DFtWMMKc8csbiGNwzfhpvOpkGkWA7Zd2ajNnn
	 EJanYqVd/0i0+ijJNOwT+CoBOQGRm3UKBrMmwI9bccg3zYLyWKEYvIAYM1rvs3m6P+
	 HPNRSvgif2hUrY9LwKHwwD1gDbt8MT5czsh6U3TW2YHzRlzDNs8NWC6pV7ZompCX2V
	 f1IV3/xK6B/aQklD+wowTz8i8S6cJyCPm5ALHmYKlRnlv/78Lh816STu43zYV41KEh
	 NgoNDXwBl0M8g==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>
Subject: [PATCH v4 3/4] Add SPDX to CODING_STYLE
Date: Wed, 12 Oct 2022 17:56:47 -0700
Message-Id: <20221013005648.1444144-3-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 CODING_STYLE | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/CODING_STYLE b/CODING_STYLE
index 3386ee1d90..5faf274b3a 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but often implicitly (Linux
 coding style is fairly common). In general you should copy the style
 of the surrounding code. If you are unsure please ask.
 
+SPDX
+----
+
+New files should start with a single-line SPDX comment to express the
+license, e.g.:
+
+/* SPDX-License-Identifier: GPL-2.0 */
+
+See LICENSES/ for a list of licenses and SPDX tags currently used.
+
 MISRA C
 -------
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:57:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:57:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421540.666971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimX1-0007bE-Ex; Thu, 13 Oct 2022 00:57:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421540.666971; Thu, 13 Oct 2022 00:57:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimX1-0007av-Af; Thu, 13 Oct 2022 00:57:03 +0000
Received: by outflank-mailman (input) for mailman id 421540;
 Thu, 13 Oct 2022 00:57:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oimWz-0006Yy-8Y
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 00:57:01 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f06b07c6-4a91-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 02:56:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id BCA9DB81CC6;
 Thu, 13 Oct 2022 00:56:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0B06C433D6;
 Thu, 13 Oct 2022 00:56:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f06b07c6-4a91-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665622616;
	bh=BsjON2XfMf6xg5j7qh4zCSZKZZ0jj+Sv/jZraOzYmsQ=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=nF1YO0nPv3BmIj8v7Emz528nd+63C8VublSTaKXQbePp7Lp+uE4EE9bY3fkakyLTN
	 JnvA1kFp5byOGDgb3zdft/rHm2TUEwnv0JAP0fgOfvV+R0jJu+X+8waoCXEA5h9lQs
	 IZKpXZ0eKkrQG5hiyswMkjOoYJAIXBHvngmPsZNzYyZK0kf+qqmg6ea1B4WOzBoTLL
	 xGwvRlvyE2mszBHf78qHNT2ygk9gsrxwJiG87uQvr82gzH+Hb7cj806lIpUmCQinKl
	 02/8wy7bgcdqzayneH9OdE1EKtlRAxYQTO7K+IXGTZlCch5vDEECzO/36gOFqKdhuf
	 fUyTUdW00KKIA==
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org,
	julien@xen.org,
	wl@xen.org,
	jbeulich@suse.com,
	george.dunlap@citrix.com,
	andrew.cooper3@citrix.com,
	bertrand.marquis@arm.com,
	Volodymyr_Babchuk@epam.com,
	roger.pau@citrix.com,
	Stefano Stabellini <stefano.stabellini@amd.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v4 4/4] add SPDX to arch/arm/*.c
Date: Wed, 12 Oct 2022 17:56:48 -0700
Message-Id: <20221013005648.1444144-4-sstabellini@kernel.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Stefano Stabellini <stefano.stabellini@amd.com>

Add SPDX license information to all the *.c files under arch/arm.

The SPDX tags added by this patch were chosen based on the existing
copyright headers. When the copyright header was missing we used the
default license which is GPLv2 for Xen (as per the COPYING file).

One exception is domain_page.c which is a split from mm.c so the license
is GPLv2+.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
Changes in v4:
- improve commit message
- add ack

Changes in v3:
- change xen/arch/arm/domain_page.c to GPL-2.0-or-later

Changes in v2:
- use /* */
- actually check use the right license
- remove stale copyright info from top of the file header
---
 xen/arch/arm/alternative.c        | 13 +------------
 xen/arch/arm/bootfdt.c            |  5 +----
 xen/arch/arm/cpuerrata.c          |  1 +
 xen/arch/arm/cpufeature.c         | 13 +------------
 xen/arch/arm/decode.c             | 11 +----------
 xen/arch/arm/device.c             | 11 +----------
 xen/arch/arm/dm.c                 | 13 +------------
 xen/arch/arm/domain.c             | 12 +-----------
 xen/arch/arm/domain_build.c       |  1 +
 xen/arch/arm/domain_page.c        |  1 +
 xen/arch/arm/domctl.c             |  1 +
 xen/arch/arm/early_printk.c       |  5 +----
 xen/arch/arm/gic-v2.c             | 11 +----------
 xen/arch/arm/gic-v3-its.c         | 13 +------------
 xen/arch/arm/gic-v3-lpi.c         | 13 +------------
 xen/arch/arm/gic-v3.c             | 11 +----------
 xen/arch/arm/gic-vgic.c           | 11 +----------
 xen/arch/arm/gic.c                | 11 +----------
 xen/arch/arm/guest_atomics.c      | 13 +------------
 xen/arch/arm/guest_walk.c         | 13 +------------
 xen/arch/arm/guestcopy.c          |  1 +
 xen/arch/arm/hvm.c                | 13 +------------
 xen/arch/arm/io.c                 | 11 +----------
 xen/arch/arm/ioreq.c              | 13 +------------
 xen/arch/arm/irq.c                | 11 +----------
 xen/arch/arm/kernel.c             |  1 +
 xen/arch/arm/livepatch.c          |  1 +
 xen/arch/arm/mem_access.c         | 13 +------------
 xen/arch/arm/mm.c                 | 11 +----------
 xen/arch/arm/monitor.c            | 13 +------------
 xen/arch/arm/p2m.c                |  1 +
 xen/arch/arm/percpu.c             |  1 +
 xen/arch/arm/physdev.c            |  1 +
 xen/arch/arm/platform.c           | 11 +----------
 xen/arch/arm/platform_hypercall.c |  1 +
 xen/arch/arm/processor.c          | 11 +----------
 xen/arch/arm/psci.c               | 11 +----------
 xen/arch/arm/setup.c              | 11 +----------
 xen/arch/arm/shutdown.c           |  1 +
 xen/arch/arm/smp.c                |  1 +
 xen/arch/arm/smpboot.c            | 11 +----------
 xen/arch/arm/sysctl.c             |  1 +
 xen/arch/arm/time.c               | 11 +----------
 xen/arch/arm/traps.c              | 11 +----------
 xen/arch/arm/vcpreg.c             | 11 +----------
 xen/arch/arm/vgic-v2.c            | 11 +----------
 xen/arch/arm/vgic-v3-its.c        | 13 +------------
 xen/arch/arm/vgic-v3.c            | 11 +----------
 xen/arch/arm/vgic.c               | 11 +----------
 xen/arch/arm/vm_event.c           | 13 +------------
 xen/arch/arm/vpci.c               | 11 +----------
 xen/arch/arm/vpl011.c             | 13 +------------
 xen/arch/arm/vpsci.c              | 13 +------------
 xen/arch/arm/vsmc.c               | 10 +---------
 xen/arch/arm/vtimer.c             | 11 +----------
 xen/arch/arm/vuart.c              | 11 +----------
 56 files changed, 56 insertions(+), 438 deletions(-)

diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
index f03cd943c6..f00e3b9b3c 100644
--- a/xen/arch/arm/alternative.c
+++ b/xen/arch/arm/alternative.c
@@ -1,20 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * alternative runtime patching
  * inspired by the x86 version
  *
  * Copyright (C) 2014-2016 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/init.h>
diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
index 6014c0f852..0085c28d74 100644
--- a/xen/arch/arm/bootfdt.c
+++ b/xen/arch/arm/bootfdt.c
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Early Device Tree
  *
  * Copyright (C) 2012-2014 Citrix Systems, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 #include <xen/types.h>
 #include <xen/lib.h>
diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
index ae649d16ef..99bd4a7d38 100644
--- a/xen/arch/arm/cpuerrata.c
+++ b/xen/arch/arm/cpuerrata.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/cpu.h>
 #include <xen/cpumask.h>
 #include <xen/init.h>
diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c
index 62d5e1770a..c4ec38bb25 100644
--- a/xen/arch/arm/cpufeature.c
+++ b/xen/arch/arm/cpufeature.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Contains CPU feature definitions
  *
  * Copyright (C) 2015 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/types.h>
diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
index f5f6562600..2537dbebc1 100644
--- a/xen/arch/arm/decode.c
+++ b/xen/arch/arm/decode.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/decode.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/guest_access.h>
diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c
index 70cd6c1a19..ca8539dee5 100644
--- a/xen/arch/arm/device.c
+++ b/xen/arch/arm/device.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/device.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <asm/device.h>
diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c
index 1b3fd6bc7d..5569efa121 100644
--- a/xen/arch/arm/dm.c
+++ b/xen/arch/arm/dm.c
@@ -1,17 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (c) 2019 Arm ltd.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/dm.h>
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2d6253181a..834857ceac 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1,14 +1,4 @@
-/*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 #include <xen/bitops.h>
 #include <xen/errno.h>
 #include <xen/grant_table.h>
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 40e3c2e119..e363fb4764 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/init.h>
 #include <xen/compile.h>
 #include <xen/lib.h>
diff --git a/xen/arch/arm/domain_page.c b/xen/arch/arm/domain_page.c
index 71182575f9..b7c02c9190 100644
--- a/xen/arch/arm/domain_page.c
+++ b/xen/arch/arm/domain_page.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 #include <xen/mm.h>
 #include <xen/pmap.h>
 #include <xen/vmap.h>
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 1baf25c3d9..ad56efb0f5 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * Arch-specific domctl.c
  *
diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c
index 333073d97e..03cbe0fb88 100644
--- a/xen/arch/arm/early_printk.c
+++ b/xen/arch/arm/early_printk.c
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * printk() for use before the final page tables are setup.
  *
  * Copyright (C) 2012 Citrix Systems, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
 
 #include <xen/init.h>
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index ae5bd8e95f..61802839cb 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic-v2.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/lib.h>
diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index e217c21bf8..1ec9934191 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/gic-v3-its.c
  *
  * ARM GICv3 Interrupt Translation Service (ITS) support
  *
  * Copyright (C) 2016,2017 - ARM Ltd
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; under version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/acpi.h>
diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 61d90eb386..ca7a0ab39a 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/gic-v3-lpi.c
  *
  * ARM GICv3 Locality-specific Peripheral Interrupts (LPI) support
  *
  * Copyright (C) 2016,2017 - ARM Ltd
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; under version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/cpu.h>
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 018fa0dfa0..37eb7ff95e 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic-v3.c
  *
@@ -9,16 +10,6 @@
  *
  * Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Cavium Inc
  * ported to Xen
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/acpi.h>
diff --git a/xen/arch/arm/gic-vgic.c b/xen/arch/arm/gic-vgic.c
index 98c021f1a8..56490dbc43 100644
--- a/xen/arch/arm/gic-vgic.c
+++ b/xen/arch/arm/gic-vgic.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic-vgic.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/errno.h>
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 9b82325442..d922ea67aa 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/gic.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/lib.h>
diff --git a/xen/arch/arm/guest_atomics.c b/xen/arch/arm/guest_atomics.c
index 1b78a062f0..6ba77f082d 100644
--- a/xen/arch/arm/guest_atomics.c
+++ b/xen/arch/arm/guest_atomics.c
@@ -1,17 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/guest_atomics.c
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 #include <xen/cpu.h>
 
diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c
index 87de40d0cb..43d3215304 100644
--- a/xen/arch/arm/guest_walk.c
+++ b/xen/arch/arm/guest_walk.c
@@ -1,18 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Guest page table walk
  * Copyright (c) 2017 Sergej Proskurin <proskurin@sec.in.tum.de>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/domain_page.h>
diff --git a/xen/arch/arm/guestcopy.c b/xen/arch/arm/guestcopy.c
index abb6236e27..225fd343dd 100644
--- a/xen/arch/arm/guestcopy.c
+++ b/xen/arch/arm/guestcopy.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/domain_page.h>
 #include <xen/guest_access.h>
 #include <xen/lib.h>
diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c
index fc1a52767d..0989309fea 100644
--- a/xen/arch/arm/hvm.c
+++ b/xen/arch/arm/hvm.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/hvm.c
  *
  * Arch-specific hardware virtual machine abstractions.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/init.h>
diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index 4ce94243aa..172583df04 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/io.c
  *
  * ARM I/O handlers
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/ioreq.h>
diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 1338c86adb..5585457189 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arm/ioreq.c: hardware virtual machine I/O emulation
  *
  * Copyright (c) 2019 Arm ltd.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/domain.h>
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index fd0c15fffd..0fb924978d 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/irq.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/cpu.h>
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 2556a45c38..23b840ea9e 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Kernel image loading.
  *
diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c
index 57abc746e6..d646379c8c 100644
--- a/xen/arch/arm/livepatch.c
+++ b/xen/arch/arm/livepatch.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  *  Copyright (C) 2016 Citrix Systems R&D Ltd.
  */
diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c
index 3e3620294c..31db846354 100644
--- a/xen/arch/arm/mem_access.c
+++ b/xen/arch/arm/mem_access.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/mem_access.c
  *
  * Architecture-specific mem_access handling routines
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License v2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/mem_access.h>
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 6ccffeaea5..630175276f 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/mm.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/domain_page.h>
diff --git a/xen/arch/arm/monitor.c b/xen/arch/arm/monitor.c
index 8c4a396e3c..6c93a9e993 100644
--- a/xen/arch/arm/monitor.c
+++ b/xen/arch/arm/monitor.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/monitor.c
  *
  * Arch-specific monitor_op domctl handler.
  *
  * Copyright (c) 2016 Tamas K Lengyel (tamas.lengyel@zentific.com)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License v2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/vm_event.h>
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 8449f97fe7..4df5fff42d 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/cpu.h>
 #include <xen/domain_page.h>
 #include <xen/iocap.h>
diff --git a/xen/arch/arm/percpu.c b/xen/arch/arm/percpu.c
index 25442c48fe..f1ef844ef3 100644
--- a/xen/arch/arm/percpu.c
+++ b/xen/arch/arm/percpu.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/percpu.h>
 #include <xen/cpu.h>
 #include <xen/init.h>
diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
index 95a8cdc0ee..7b1682ee10 100644
--- a/xen/arch/arm/physdev.c
+++ b/xen/arch/arm/physdev.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * Arch-specific physdev.c
  *
diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
index 4db5bbb4c5..6701ff77bc 100644
--- a/xen/arch/arm/platform.c
+++ b/xen/arch/arm/platform.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/platform.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <asm/platform.h>
diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c
index 403cc84324..743687a303 100644
--- a/xen/arch/arm/platform_hypercall.c
+++ b/xen/arch/arm/platform_hypercall.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * platform_hypercall.c
  *
diff --git a/xen/arch/arm/processor.c b/xen/arch/arm/processor.c
index acad8b31d6..6de206c07e 100644
--- a/xen/arch/arm/processor.c
+++ b/xen/arch/arm/processor.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/processor.c
  *
@@ -5,16 +6,6 @@
  *
  * Julien Grall <julien.grall@linaro.org>
  * Copyright (C) 2014 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #include <asm/procinfo.h>
 
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 0c90c2305c..695d2fa1f1 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/psci.c
  *
@@ -5,16 +6,6 @@
  *
  * Andre Przywara <andre.przywara@linaro.org>
  * Copyright (c) 2013 Linaro Limited.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 4395640019..1f26f67b90 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/setup.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/compile.h>
diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
index 0606cb84b3..205a5e7f8c 100644
--- a/xen/arch/arm/shutdown.c
+++ b/xen/arch/arm/shutdown.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/console.h>
 #include <xen/cpu.h>
 #include <xen/delay.h>
diff --git a/xen/arch/arm/smp.c b/xen/arch/arm/smp.c
index 5823a69d3e..bb65a08fc1 100644
--- a/xen/arch/arm/smp.c
+++ b/xen/arch/arm/smp.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #include <xen/mm.h>
 #include <asm/system.h>
 #include <asm/smp.h>
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index f7bda3a18b..635977e489 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/smpboot.c
  *
  * Dummy smpboot support
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/cpu.h>
diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c
index f87944e847..b0a78a8b10 100644
--- a/xen/arch/arm/sysctl.c
+++ b/xen/arch/arm/sysctl.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /******************************************************************************
  * Arch-specific sysctl.c
  *
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index dec53b5f7d..92baaf8cb2 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/time.c
  *
@@ -5,16 +6,6 @@
  *
  * Tim Deegan <tim@xen.org>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/console.h>
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 79f9ed0725..061c92acbd 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/traps.c
  *
  * ARM Trap handlers
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/domain_page.h>
diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c
index b5fbbe1cb8..4adfc0a68d 100644
--- a/xen/arch/arm/vcpreg.c
+++ b/xen/arch/arm/vcpreg.c
@@ -1,19 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/arm64/vcpreg.c
  *
  * Emulate co-processor registers trapped.
  *
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/sched.h>
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index b1bd7a46ad..0026cb4360 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vgic-v2.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/bitops.h>
diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
index 58d939b85f..299b384250 100644
--- a/xen/arch/arm/vgic-v3-its.c
+++ b/xen/arch/arm/vgic-v3-its.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/vgic-v3-its.c
  *
@@ -5,18 +6,6 @@
  *
  * Andre Przywara <andre.przywara@arm.com>
  * Copyright (c) 2016,2017 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; under version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 /*
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 7fb99a9ff2..7d2507079d 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vgic-v3.c
  *
@@ -6,16 +7,6 @@
  *
  * Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>
  * Copyright (c) 2014 Cavium Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/bitops.h>
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 83386cf3d5..c61c68870c 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vgic.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/bitops.h>
diff --git a/xen/arch/arm/vm_event.c b/xen/arch/arm/vm_event.c
index eaac92078d..ba99f56eb2 100644
--- a/xen/arch/arm/vm_event.c
+++ b/xen/arch/arm/vm_event.c
@@ -1,21 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/vm_event.c
  *
  * Architecture-specific vm_event handling routines
  *
  * Copyright (c) 2016 Tamas K Lengyel (tamas.lengyel@zentific.com)
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License v2 as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <xen/sched.h>
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index a9fc5817f9..3bc4bb5508 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -1,15 +1,6 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vpci.c
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #include <xen/sched.h>
 #include <xen/vpci.h>
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
index 43522d48fd..f6144da1d7 100644
--- a/xen/arch/arm/vpl011.c
+++ b/xen/arch/arm/vpl011.c
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * arch/arm/vpl011.c
  *
  * Virtual PL011 UART
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
 #define XEN_WANT_FLEX_CONSOLE_RING 1
diff --git a/xen/arch/arm/vpsci.c b/xen/arch/arm/vpsci.c
index 744d43ec27..d1615be8a6 100644
--- a/xen/arch/arm/vpsci.c
+++ b/xen/arch/arm/vpsci.c
@@ -1,15 +1,4 @@
-/*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 #include <xen/errno.h>
 #include <xen/sched.h>
 #include <xen/types.h>
diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c
index 676740ef15..7335276f3f 100644
--- a/xen/arch/arm/vsmc.c
+++ b/xen/arch/arm/vsmc.c
@@ -1,17 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * xen/arch/arm/vsmc.c
  *
  * Generic handler for SMC and HVC calls according to
  * ARM SMC calling convention
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index aeaea78e4c..48f2daa907 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vtimer.c
  *
@@ -5,16 +6,6 @@
  *
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2011 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <xen/lib.h>
diff --git a/xen/arch/arm/vuart.c b/xen/arch/arm/vuart.c
index 80d4755d43..d5ba483f1e 100644
--- a/xen/arch/arm/vuart.c
+++ b/xen/arch/arm/vuart.c
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  * xen/arch/arm/vuart.c
  *
@@ -19,16 +20,6 @@
  * Julien Grall <julien.grall@linaro.org>
  * Ian Campbell <ian.campbell@citrix.com>
  * Copyright (c) 2012 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 #include <xen/lib.h>
 #include <xen/sched.h>
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 00:57:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 00:57:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421550.666983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimXN-0000Nl-VJ; Thu, 13 Oct 2022 00:57:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421550.666983; Thu, 13 Oct 2022 00:57:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimXN-0000Ne-Rh; Thu, 13 Oct 2022 00:57:25 +0000
Received: by outflank-mailman (input) for mailman id 421550;
 Thu, 13 Oct 2022 00:57:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oimXM-0000KY-TT; Thu, 13 Oct 2022 00:57:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oimXM-0002uT-Qn; Thu, 13 Oct 2022 00:57:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oimXM-0006xu-EF; Thu, 13 Oct 2022 00:57:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oimXM-0007Va-Dn; Thu, 13 Oct 2022 00:57:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rhC2On+RR3biPmOak+wIvSp3KZXFclSiHc7asnRn3ro=; b=rAoiEx+ERNxp3zGkXloG6qsNIV
	IsL4ftSLY5gAWJSXG/jJSIYGKQyyjWBHpoO1SZIbDFybck632E2F79TAQ0cF3KrjZ6Dt7HmBMflqZ
	wOHX6bRI9cpfWHftqJ8qf0MW030ol3WGbH10TclRguOa4r4Ed+TOH9O5y92uPcQRBTzM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173587-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173587: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:build-arm64:xen-build:fail:regression
    xen-4.13-testing:build-arm64-xsm:xen-build:fail:regression
    xen-4.13-testing:build-armhf:xen-build:fail:regression
    xen-4.13-testing:test-amd64-i386-libvirt:xen-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=042de0843936b690acbc6dbcf57d26f6adccfc06
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 00:57:24 +0000

flight 173587 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173587/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172549
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172549
 build-armhf                   6 xen-build                fail REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt       7 xen-install                fail pass in 173521

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt     15 migrate-support-check fail in 173521 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  042de0843936b690acbc6dbcf57d26f6adccfc06
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   58 days
Testing same since   173495  2022-10-11 14:08:01 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 436 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 01:04:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 01:04:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421568.666994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimeK-0000ZI-Nn; Thu, 13 Oct 2022 01:04:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421568.666994; Thu, 13 Oct 2022 01:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oimeK-0000ZB-KV; Thu, 13 Oct 2022 01:04:36 +0000
Received: by outflank-mailman (input) for mailman id 421568;
 Thu, 13 Oct 2022 01:04:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oimeJ-0000Z1-FR; Thu, 13 Oct 2022 01:04:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oimeJ-0001OJ-9V; Thu, 13 Oct 2022 01:04:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oimeJ-0007We-1M; Thu, 13 Oct 2022 01:04:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oimeJ-0003gc-0p; Thu, 13 Oct 2022 01:04:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=ZDu9j0xcCaN+eqsCANXUZf327TdCOAbR8gCSqs512vA=; b=BtV9JLc/aE/GmpaEKXfaXx3gxU
	Rv8HBhDyI3shIuPZLd/XRfELcNvEZxnfuoaJ3syajGB6Iq6RNXal37Iir3yHpuKFtduhzTIAY2QU+
	jpXjwyUqDAIaWvzYFetG19aiZv7vL0hMsjAG3P3l9QQB4MD961TiYIChCQjpkp25+PFE=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.15-testing bisection] complete build-amd64-xsm
Message-Id: <E1oimeJ-0003gc-0p@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 01:04:35 +0000

branch xen-4.15-testing
xenbranch xen-4.15-testing
job build-amd64-xsm
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
  Bug not present: 182f8bb503b9dd3db5dd9118dc763d241787c6fc
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173655/


  commit 3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
  Author: Juergen Gross <jgross@suse.com>
  Date:   Tue Oct 11 15:16:53 2022 +0200
  
      xen/gnttab: fix gnttab_acquire_resource()
      
      Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized"
      warning") was wrong, as vaddrs can legitimately be NULL in case
      XENMEM_resource_grant_table_id_status was specified for a grant table
      v1. This would result in crashes in debug builds due to
      ASSERT_UNREACHABLE() triggering.
      
      Check vaddrs only to be NULL in the rc == 0 case.
      
      Expand the tests in tools/tests/resource to tickle this path, and verify that
      using XENMEM_resource_grant_table_id_status on a v1 grant table fails.
      
      Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning")
      Signed-off-by: Juergen Gross <jgross@suse.com>
      Reviewed-by: Jan Beulich <jbeulich@suse.com> # xen
      Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
      master commit: 52daa6a8483e4fbd6757c9d1b791e23931791608
      master date: 2022-09-09 16:28:38 +0100


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.15-testing/build-amd64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.15-testing/build-amd64-xsm.xen-build --summary-out=tmp/173655.bisection-summary --basis-template=172547 --blessings=real,real-bisect,real-retry xen-4.15-testing build-amd64-xsm xen-build
Searching for failure / basis pass:
 173546 fail [host=sabro1] / 172547 [host=himrod1] 172109 [host=himrod2] 171880 [host=himrod0] 171866 [host=himrod1] 171609 [host=himrod1] 171594 [host=himrod0] 171375 [host=himrod1] 171205 [host=himrod2] 170922 [host=himrod2] 170904 [host=godello0] 170870 [host=godello0] 169237 [host=himrod2] 169193 [host=himrod1] 169178 [host=himrod2] 169162 [host=himrod2] 169152 [host=himrod1] 169143 [host=himrod2] 169132 [host=himrod1] 169115 [host=himrod2] 169079 [host=himrod2] 169040 [host=himrod2] 168992 \
 [host=himrod2] 168970 [host=elbling1] 168863 [host=himrod2] 168502 [host=himrod1] 168483 [host=albana0] 168135 [host=himrod1] 168062 [host=himrod2] 168014 [host=himrod1] 167996 [host=himrod1] 167965 [host=fiano0] 167880 [host=fiano1] 167628 [host=godello0] 167416 [host=godello1] 167217 [host=himrod2] 166387 [host=himrod1] 166338 [host=himrod1] 166311 [host=himrod2] 166198 [host=himrod1] 166192 [host=himrod1] 166169 [host=himrod1] 165521 [host=godello1] 165387 [host=himrod1] 164938 [host=himrod1]\
  164889 [host=himrod2] 164636 [host=himrod2] 164564 [host=himrod2] 164511 [host=himrod1] 164495 [host=himrod1] 164455 [host=himrod2] 164390 [host=himrod1] 164304 [host=himrod1] 164262 [host=himrod2] 163759 [host=himrod1] 163727 [host=himrod1] 163710 [host=himrod1] 162882 [host=himrod2] 162561 [host=himrod2] 162546 [host=himrod2] 162366 [host=himrod1] 161772 [host=himrod1] 161322 [host=himrod1] 161049 [host=himrod1] 160774 [host=himrod2] 160455 [host=himrod1] 160422 [host=himrod2] 160394 [host=hi\
 mrod1] template as basis? using template as basis.
Failure / basis pass flights: 173546 / 172547
(tree with no url: minios)
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
Basis pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#444260d45ec2a84e8f8c192b3539a3cd5591d009-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#6503bd6a1b5364ffd346a8a475e1eb91b9f756e5-6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8e\
 b04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#9acedc3c58c31930737edbe212f2ccf437a0b757-9690bb261d5fa09cb281e1fa124d93db7b84fda5
Loaded 10001 nodes in revision graph
Searching for test results:
 172547 [host=himrod1]
 173494 [host=sabro0]
 173498 [host=sabro0]
 173522 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173594 pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173597 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173605 pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173606 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173546 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9690bb261d5fa09cb281e1fa124d93db7b84fda5
 173608 pass e8a537d28d37c092bd03093064264071f2938ca8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173611 pass 7aa06237b856fd6f8187cc1715a3fe08ab4e98ed 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173616 pass a670f12a741a9511d9cedc7257d3693567f8fc43 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757
 173617 pass f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 686c920fa9389fe2b6b619643024ed98b4b7d51f
 173618 pass f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 7923ea47e578bca30a6e45951a9da09e827ff028
 173629 pass f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 19cf28b515f21da02df80e68f901ad7650daaa37
 173631 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
 173639 pass f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 182f8bb503b9dd3db5dd9118dc763d241787c6fc
 173641 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
 173642 pass f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 182f8bb503b9dd3db5dd9118dc763d241787c6fc
 173646 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
 173653 pass f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 182f8bb503b9dd3db5dd9118dc763d241787c6fc
 173655 fail f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
Searching for interesting versions
 Result found: flight 173594 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 182f8bb503b9dd3db5dd9118dc763d241787c6fc, results HASH(0x555b10523030) HASH(0x555b1053d530) HASH(0x555b10542768) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec9\
 3bffa0706e6229c0da2919763c8eb04 19cf28b515f21da02df80e68f901ad7650daaa37, results HASH(0x555b10526260) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 7923ea47e578bca30a6e45951a9da09e827ff028, results HASH(0x555b0fb31c00) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee\
 84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 686c920fa9389fe2b6b619643024ed98b4b7d51f, results HASH(0x555b105140a8) For basis failure, parent search stopping at a670f12a741a9511d9cedc7257d3693567f8fc43 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x555b0fb29de8) For basis failure, parent search stopping at 7aa06237b856\
 fd6f8187cc1715a3fe08ab4e98ed 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x555b0fb31cc0) For basis failure, parent search stopping at e8a537d28d37c092bd03093064264071f2938ca8 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x555b10527c6\
 8) For basis failure, parent search stopping at 444260d45ec2a84e8f8c192b3539a3cd5591d009 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 9acedc3c58c31930737edbe212f2ccf437a0b757, results HASH(0x555b1052eea8) HASH(0x555b10534be8) Result found: flight 173597 (fail), for basis failure (at ancestor ~746)
 Repro found: flight 173605 (pass), for basis pass
 Repro found: flight 173606 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 6503bd6a1b5364ffd346a8a475e1eb91b9f756e5 46de2eec93bffa0706e6229c0da2919763c8eb04 182f8bb503b9dd3db5dd9118dc763d241787c6fc
No revisions left to test, checking graph state.
 Result found: flight 173639 (pass), for last pass
 Result found: flight 173641 (fail), for first failure
 Repro found: flight 173642 (pass), for last pass
 Repro found: flight 173646 (fail), for first failure
 Repro found: flight 173653 (pass), for last pass
 Repro found: flight 173655 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
  Bug not present: 182f8bb503b9dd3db5dd9118dc763d241787c6fc
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173655/


  commit 3ac64b3751837a117ee3dfb3e2cc27057a83d0f7
  Author: Juergen Gross <jgross@suse.com>
  Date:   Tue Oct 11 15:16:53 2022 +0200
  
      xen/gnttab: fix gnttab_acquire_resource()
      
      Commit 9dc46386d89d ("gnttab: work around "may be used uninitialized"
      warning") was wrong, as vaddrs can legitimately be NULL in case
      XENMEM_resource_grant_table_id_status was specified for a grant table
      v1. This would result in crashes in debug builds due to
      ASSERT_UNREACHABLE() triggering.
      
      Check vaddrs only to be NULL in the rc == 0 case.
      
      Expand the tests in tools/tests/resource to tickle this path, and verify that
      using XENMEM_resource_grant_table_id_status on a v1 grant table fails.
      
      Fixes: 9dc46386d89d ("gnttab: work around "may be used uninitialized" warning")
      Signed-off-by: Juergen Gross <jgross@suse.com>
      Reviewed-by: Jan Beulich <jbeulich@suse.com> # xen
      Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
      master commit: 52daa6a8483e4fbd6757c9d1b791e23931791608
      master date: 2022-09-09 16:28:38 +0100

pnmtopng: 165 colors found
Revision graph left in /home/logs/results/bisect/xen-4.15-testing/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173655: tolerable ALL FAIL

flight 173655 xen-4.15-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173655/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64-xsm               6 xen-build               fail baseline untested


jobs:
 build-amd64-xsm                                              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 02:03:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 02:03:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421589.667038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oinZR-0007yp-If; Thu, 13 Oct 2022 02:03:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421589.667038; Thu, 13 Oct 2022 02:03:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oinZR-0007yi-Eg; Thu, 13 Oct 2022 02:03:37 +0000
Received: by outflank-mailman (input) for mailman id 421589;
 Thu, 13 Oct 2022 02:03:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oinZQ-0007yY-AR; Thu, 13 Oct 2022 02:03:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oinZQ-0002uU-7i; Thu, 13 Oct 2022 02:03:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oinZQ-0002TZ-0a; Thu, 13 Oct 2022 02:03:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oinZQ-0005sn-07; Thu, 13 Oct 2022 02:03:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=7s4U+hDuBCP/jdLhojBWsUUIXUQv51Gw1+36ACh6LDc=; b=iEgL6trUCX6mthufv6GUis9sNj
	9BXz6wuJMwSr1+/WYRCC1HKO0MmlbNM2di9fo+SWEnEQXk1clAvld0xO3HxSjAGezFagxTsRfRi8N
	R/3cJjcYvc/QpIazOHOguxxl7bgs2vF52Cfk8BST6gSKrbSQcNeCs9R8XRZMg79AkiNg=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.14-testing bisection] complete build-arm64
Message-Id: <E1oinZQ-0005sn-07@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 02:03:36 +0000

branch xen-4.14-testing
xenbranch xen-4.14-testing
job build-arm64
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  4220eac3799f46ba84316513606a33e1ea33fb4e
  Bug not present: fd688b06a57a327dc5dbda106a104a2af5e1aa2b
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173661/


  commit 4220eac3799f46ba84316513606a33e1ea33fb4e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:42:00 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.14-testing/build-arm64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.14-testing/build-arm64.xen-build --summary-out=tmp/173661.bisection-summary --basis-template=172550 --blessings=real,real-bisect,real-retry xen-4.14-testing build-arm64 xen-build
Searching for failure / basis pass:
 173573 fail [host=rochester0] / 172550 [host=rochester1] 172114 ok.
Failure / basis pass flights: 173573 / 172114
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
Basis pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#83aebe33dc76760f911162f9e7a4b98a4929776b-83aebe33dc76760f911162f9e7a4b98a4929776b git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#261b882f7704515a01f74589f57f0c1303e3b701-6e5608d1c50e0\
 f91ed3226489d9591c70fa37c30
Loaded 10001 nodes in revision graph
Searching for test results:
 172114 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701
 172550 [host=rochester1]
 173496 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173517 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173598 pass 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701
 173621 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173624 pass d82ec90f51f61c914396271d86e64a74121dde24 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173626 pass d97ee3244d806d324a22ea530215a9f10d2b23e2 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173628 pass 710f83b79d6eab641401c054b2f40f6c630f8cd5 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173632 pass 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
 173635 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 9b5a7fd916a74295886a7d473c311e3c7e254e54
 173637 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 e3b66e5cba89fc0b59c9a116e7414388d45e04a0
 173640 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
 173643 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
 173645 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
 173573 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 6e5608d1c50e0f91ed3226489d9591c70fa37c30
 173648 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
 173652 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
 173659 pass f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
 173661 fail f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4220eac3799f46ba84316513606a33e1ea33fb4e
Searching for interesting versions
 Result found: flight 172114 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b, results HASH(0x55beb2e45640) HASH(0x55beb2e5a7f0) HASH(0x55beb2e43638) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 e3b66e5cba89fc0b59c9a116e7414388d45e04a0, results \
 HASH(0x55beb2e45c40) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 9b5a7fd916a74295886a7d473c311e3c7e254e54, results HASH(0x55beb2e42230) For basis failure, parent search stopping at 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55beb2e25a28) F\
 or basis failure, parent search stopping at 710f83b79d6eab641401c054b2f40f6c630f8cd5 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55beb2e23420) For basis failure, parent search stopping at d97ee3244d806d324a22ea530215a9f10d2b23e2 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55beb2e3c6f8) For basis failure, pare\
 nt search stopping at d82ec90f51f61c914396271d86e64a74121dde24 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 4ed063a71bf9ec291a1b71d0b7b36c0416ca544d, results HASH(0x55beb2e372e0) For basis failure, parent search stopping at 0dc9b78a46813d61533b2bb0f7ef897a06a273be 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 261b882f7704515a01f74589f57f0c1303e3b701, results HASH(0x55beb2e23120) HASH(0x55beb2e34cb0) Result found: flight 173\
 496 (fail), for basis failure (at ancestor ~759)
 Repro found: flight 173598 (pass), for basis pass
 Repro found: flight 173621 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 83aebe33dc76760f911162f9e7a4b98a4929776b 46de2eec93bffa0706e6229c0da2919763c8eb04 fd688b06a57a327dc5dbda106a104a2af5e1aa2b
No revisions left to test, checking graph state.
 Result found: flight 173643 (pass), for last pass
 Result found: flight 173645 (fail), for first failure
 Repro found: flight 173648 (pass), for last pass
 Repro found: flight 173652 (fail), for first failure
 Repro found: flight 173659 (pass), for last pass
 Repro found: flight 173661 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  4220eac3799f46ba84316513606a33e1ea33fb4e
  Bug not present: fd688b06a57a327dc5dbda106a104a2af5e1aa2b
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173661/


  commit 4220eac3799f46ba84316513606a33e1ea33fb4e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:42:00 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200

pnmtopng: 163 colors found
Revision graph left in /home/logs/results/bisect/xen-4.14-testing/build-arm64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173661: tolerable ALL FAIL

flight 173661 xen-4.14-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173661/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-arm64                   6 xen-build               fail baseline untested


jobs:
 build-arm64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 02:35:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 02:35:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421600.667058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oio3a-00036L-Vf; Thu, 13 Oct 2022 02:34:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421600.667058; Thu, 13 Oct 2022 02:34:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oio3a-00036E-Si; Thu, 13 Oct 2022 02:34:46 +0000
Received: by outflank-mailman (input) for mailman id 421600;
 Thu, 13 Oct 2022 02:34:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oio3Z-000365-K9
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 02:34:45 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9761e382-4a9f-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 04:34:42 +0200 (CEST)
Received: from AM9P195CA0017.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:21f::22)
 by PA4PR08MB7619.eurprd08.prod.outlook.com (2603:10a6:102:260::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Thu, 13 Oct
 2022 02:34:37 +0000
Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:21f:cafe::70) by AM9P195CA0017.outlook.office365.com
 (2603:10a6:20b:21f::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Thu, 13 Oct 2022 02:34:37 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 02:34:37 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Thu, 13 Oct 2022 02:34:36 +0000
Received: from 6a7b7be8f1e6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F8DFC213-A71F-4FBD-B37E-F78C7DA3FAF2.1; 
 Thu, 13 Oct 2022 02:34:31 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6a7b7be8f1e6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 02:34:31 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV2PR08MB9878.eurprd08.prod.outlook.com (2603:10a6:150:de::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 02:34:28 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 02:34:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9761e382-4a9f-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=CqcWJ47NR0LUc+DBbRt8ATcSYNUkmvkZBOOjYuaivmv+klcYrIDAnoL+aqkA7k4jahzCH21914eBOzZm1YV9yE1JyJpCLSyvBTKPQ+tzPvPXyaAQYDkQO8a5w9zZz1kZ0q4lCEn9EX1bpBMPw2fMoozUnFj/1AvkvWSwBTZxiJNRUhT6bH9MY7jYjY0awLHEntYqQlEcgdbL8CrUSJpwrJQ9SdSCjW+MJ1iw6aA9LOcdlslYtn+1AwwnZPObt01KCW2yW2V/fDJRgNUDkP0ovKqA5ZsunkM7+MSPaswHoq48/oQaQkpbZH80hTDi1J3KtELMYof2Ib8kiTHZRK+M+A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8/vBhluHBfJvmg8HL02zPA+kC0c/OblCjveSpq3/jjc=;
 b=RJNiXc/glVpSXHDdBz1uwrogBHjAFC2IRu9kkp2oyQMty/+DK6uVHvD4SycF1dzisiketIUwtolj8qaHA97fU4FLLNiEkxYTtSQSU1FM4YFAWXCRodKX7JmW4w4WmPIKW9r7MfG2X4XJNWYYxLZDXWGczlsX42zG2KTpFuwru37K+iijn0Q9+hR98dzkQkTNgFEAtseNG2JZIHV7kRcIyb5Ai/WazPiwOTybhoIz6zgR46TG8NlM9WQ+zdS+pdVugDYYqbSpWHo6pg5v3oX0l0FCjCC2wWgsWeYha1m+7tRpSxc3SSfQF+/oaarnLjgUrF30fzl1Y26EIGHWE8tgmQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8/vBhluHBfJvmg8HL02zPA+kC0c/OblCjveSpq3/jjc=;
 b=iFV5E5ODYW7Kn3OXD9Ig/HbR77HA/WPFCq8lnTV2DMlA5aIq7NUKQt7oK+Zctr+0EeV/P6JKAfbteBxr0MHsh+w7hfnR6hpXtwHsIphg6MpnptbVzYGSSDOa4Uq3gQ6+l6tMM8Lya1npfCb6Tdq7o79alJJzMP2JJ40RZZH/BbU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GiZaBPf5BQKWKmrXj5N/V1a7waCQnvmDaLJl8czfIUN1k2pzogftvPGjWf7G/XX8hn3dcsYYcOzCHPS+4tSlKTlRYRQ7kqJUhfmPRZRCY8HlNfyEXMG9+yyRODhtDV+j0iHL/cvrE9lSPvjk9l33YMlcjqX49kDUWSFIHfiLPnlAC4BdUq7iMqlCNvrYakKXKgS4E1B5YQAUpN3+1Z8hB5lLwQ73ttPtemVPvL3Ohf5sSB3Xdcqri+gGftbqh0yXPvY9tWCvDmSq8W2UfWpOW0h+KuwDWQ6dUDN8szCgBD4ehPp7anbznq1NdT+NmrAyOZ5FDEpt/5nEwHyAbzmFJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8/vBhluHBfJvmg8HL02zPA+kC0c/OblCjveSpq3/jjc=;
 b=RE55quByA4H35bq4vghcz+CPYv4TmiVMb9TqL51KAXLjwWdLxaZhZpE1wSk73fZiV9afEK6P5u0CdsIxSViaoSEdJ+o3+/QtqfdQ1IsswZqRcwYZjg4c5xwFmv1H5XLeck1sGgyVJe6kjDkQHqICGgbI1pKZ/dw5NNhDXXATk+X3Ef1J7HLFR8NHbCNRWphDQCAm9mrk/yyNgkbGVKzUfiyy+kvcsTY7KxVi8GB/o8FliIXfwcnCzBDStYjOCFDMlwESEG/qPrdS9lIxF3rV+Ky9jzc+xQQzfrlxPXXZex5WOpzjggkRlNBwAvrF4fpvueTLkMtXpkmJcZ/QjGAPeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8/vBhluHBfJvmg8HL02zPA+kC0c/OblCjveSpq3/jjc=;
 b=iFV5E5ODYW7Kn3OXD9Ig/HbR77HA/WPFCq8lnTV2DMlA5aIq7NUKQt7oK+Zctr+0EeV/P6JKAfbteBxr0MHsh+w7hfnR6hpXtwHsIphg6MpnptbVzYGSSDOa4Uq3gQ6+l6tMM8Lya1npfCb6Tdq7o79alJJzMP2JJ40RZZH/BbU=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
CC: Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Edwin Torok <edvin.torok@citrix.com>, Rob Hoes
	<Rob.Hoes@citrix.com>
Subject: RE: [PATCH 1/2] tools/ocaml/xc: Fix code legibility in
 stub_xc_domain_create()
Thread-Topic: [PATCH 1/2] tools/ocaml/xc: Fix code legibility in
 stub_xc_domain_create()
Thread-Index: AQHY3mgm6d+FJrzJnkaoGa45NVlypq4Lm6Og
Date: Thu, 13 Oct 2022 02:34:27 +0000
Message-ID:
 <AS8PR08MB79917FD4B8EFE62D1D8A900392259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221012182552.26866-1-andrew.cooper3@citrix.com>
 <20221012182552.26866-2-andrew.cooper3@citrix.com>
In-Reply-To: <20221012182552.26866-2-andrew.cooper3@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 9F9D64B6CCB43F4E9628291C773C4127.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV2PR08MB9878:EE_|VE1EUR03FT036:EE_|PA4PR08MB7619:EE_
X-MS-Office365-Filtering-Correlation-Id: dda66362-7cd1-4116-d380-08daacc378f8
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 JCicWNKsddaQZJ0jXH3/Jf/YABXUmtvBz3MADL5gu77vlIjGVrhM0tsC3op4ab3gGj8fveTJz2nrcO0wny4rRr2eUBS1dPUTJvBWeSVjyMApZiLUNHphwO3NM8kN5FyXztT1A9q5e4KNROTOjkMp2w9ibbUJvQXiIAVN3sqtbVlOyVSHFj+g+Xn5mBc2BUUlewbjbKADZVd1vunY2wBKB69oVbM6HWzSz3pZBQLCt0Y+UJyKx0+OtSWEnF/2SH0LrUIqKHVjQNuh95mU7B6l6Nt3U3TLMt2omoddO1WOZIpRbNjQViNbMdDTallhrnCrlSCi/LEGO82ReClktonsMXtk9LF0po1wwIiOB8fHFb0pkddwXgkBuyUJkWekA5PVGOBpLoT0aUW5CrQq8wE8HshzwlCwSlyLU69HrU9hT062zpyw+mxF9RFcgU9vt2FPd0lAWLOsMPuzTI2EC3AI6npWSLhxf3wwUcBpKQicTLVp4/IZvvlKZX240Nq6fbFhw45VKazr6M1wwVpfV0ZTSdR84CEYjJ5qhuOMDuZkFjzby4bl7aCD26LZDAT2WGJyt5hQr6XLP5g07N5lku8PVtNHOJZo5p4EDCfBzIYuisTw36Oje/qZnLkOlyQwedOIIax7nz6d6xxmr6XeGg7TAivYy69nnvVLF9sl7QH7VpQthYBUdtaBpPuSLpu8ZSdw2UjKnNa8Wes5HlC3XjlfaNj/dW6Xs1mVDEvkvbDROh1ZC/OMy+KNNhd9SwzscFlNWjQ723g/iCSQPAlD7GGbvg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(7696005)(52536014)(6506007)(55016003)(41300700001)(110136005)(33656002)(478600001)(54906003)(316002)(186003)(4744005)(9686003)(122000001)(8936002)(26005)(38070700005)(5660300002)(38100700002)(2906002)(83380400001)(66476007)(86362001)(64756008)(66446008)(8676002)(71200400001)(66946007)(76116006)(4326008)(66556008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9878
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	43d57640-ff22-4d09-46a5-08daacc37358
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	by58PlG9gSvS8cM/PYuuTLKC/qHpD7y38356q7C1Hf0lSO+wI/PfLn/HV1gTiul8hX0dq1eCGNlPpMlsSKBoY9vDbVH5WE+nGy0dvqQY9JimcUGCJqR9NJwS1ZD+IFnzTaL0tie/AT1FpycOuNEUKIAIHbTkVYB5nj6o6cXQFVZQDC0hYuqnFgyhnD+7mBrNlv8L6rIRf/DrYPaKVDgQo+efZ7DAlJPWe8mdjmY6/xryxVaOd3RExau5QjKfgfOZAAF4jMFVVmbyqlNSVt+LNLa/lAuS3NoGmuFRAiUObV08cLxhxPSk1DxEI5fzCSCW1TsaCAgX1LOrcUY/bB5kTbgUjUGolKXREk5f6Iir5PUNh+6z0hGdGuiNP6XWL/qYAKgv7Zj7QnaveBtIdPuIIKMtKDhqpdt3Z8rp6Et/Hlujz5hA91gwS1RZqLLeAOwRpeqotD1+TyTNhy6GXEuJ0jjhqGY3w1GdNj1R9YcCQVMViqctfFB+FnOzoRGe8A3K42d/q7eyPqQCpIT+dojxPGEQet6CC1x0zDxQKxo5JzFC1rPRu7e80YUVtJa2ow3P5/HMaQ8X7tT/BwiKlDtBvsIY92/l9cC/jlSyszA5WByEpgn8Gzo9RvsAepO/YhcnAS25enlcRcGRPyBXYPBslL06eqrd4dVfLEgjpg5zBiguceY+g4mWxFV+POSA1OeugshZXcQgFs+xQRccd81dVS4d2zMIBqyicdKfRZZy3OwBksdrAGa4YIKLaGv2VtRnzof6WQP2DFmtB+bzlI7Y5w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(36840700001)(46966006)(40470700004)(356005)(478600001)(82310400005)(82740400003)(110136005)(54906003)(86362001)(40480700001)(4744005)(47076005)(52536014)(336012)(26005)(33656002)(186003)(316002)(55016003)(7696005)(41300700001)(40460700003)(2906002)(36860700001)(83380400001)(81166007)(70586007)(8936002)(9686003)(5660300002)(70206006)(8676002)(4326008)(6506007)(107886003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 02:34:37.3426
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dda66362-7cd1-4116-d380-08daacc378f8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7619

Hi Andrew,

> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@citrix.com>
> Subject: [PATCH 1/2] tools/ocaml/xc: Fix code legibility in
> stub_xc_domain_create()
>=20
> Reposition the defines to match the outer style and to make the logic
> half-legible.
>=20
> No functional change.
>=20
> Fixes: 0570d7f276dd ("x86/msr: introduce an option for compatible MSR
> behavior selection")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 02:35:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 02:35:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421602.667069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oio3w-0003W6-7z; Thu, 13 Oct 2022 02:35:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421602.667069; Thu, 13 Oct 2022 02:35:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oio3w-0003Vz-54; Thu, 13 Oct 2022 02:35:08 +0000
Received: by outflank-mailman (input) for mailman id 421602;
 Thu, 13 Oct 2022 02:35:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oio3t-0003RZ-S7
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 02:35:06 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a364255b-4a9f-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 04:35:02 +0200 (CEST)
Received: from AS9PR06CA0333.eurprd06.prod.outlook.com (2603:10a6:20b:466::12)
 by AS8PR08MB7356.eurprd08.prod.outlook.com (2603:10a6:20b:447::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 02:35:00 +0000
Received: from AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:466:cafe::e3) by AS9PR06CA0333.outlook.office365.com
 (2603:10a6:20b:466::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.25 via Frontend
 Transport; Thu, 13 Oct 2022 02:35:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT057.mail.protection.outlook.com (100.127.140.117) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 02:34:59 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Thu, 13 Oct 2022 02:34:59 +0000
Received: from b8643861a16d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 437F7058-6EEE-4350-B020-ED82840B73F4.1; 
 Thu, 13 Oct 2022 02:34:52 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8643861a16d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 02:34:52 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV2PR08MB9878.eurprd08.prod.outlook.com (2603:10a6:150:de::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 02:34:51 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 02:34:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a364255b-4a9f-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ZarkQoaDxyE2/SmiTZH3JIZZOIY6tEWZATInuvtnlyKwRSd8GSgT5qbh/Lh821iqtYk4tHseUXAB+HLqedKzYrWlS8kR5QtbtJVRBN+oTYVgfx3buTYy4CEDKcG/lMlHS5lcgmzekzMFPuzy23Pfw+1WVWycwyhuV5Du7sjmAbe/XW1C9uK6Djf8bDyoF46A1XBwKo4beYEO7ryKUS95Fr2AYFjRnjOK/z3Qinn4zD2NRuE+pO/LX19I/HTyEogHjVNApov+WPZbHULkomlbkYM8qhNWWNowvWY3C2ka98NrpS3PhCu19iC/3JWZ8214UmRxJteqsQ8cOudaBl14Fw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qKapJyO6y/fadcTC42/DuTDcVTUcOS604Lcc9O5P5O8=;
 b=c9/6Kj7ETZEIC1YccP9zVDWns6PkFuYwcKeBY/4OPcTbO4pReocoQfTEzqPy2drUMzU1BQgVtMspkGxDCBv8R7el8dUB+oL6CSaBS3DewCLR/UBLGBdl4jGkD35K5s31nsAfXpGgekD4eQt0+oNCBoRTx+uOBvrNwgwdQzoZxLgWasfVKdF+3n144IAOyW1kaSzAJnKagYyNjQ2upQuL7Alw164lMQRwis/YiY+39rFvFV6EEZbDOZ/Kow2j9Mp7Lx0logEMttnsDr4r2T1pMx8iliYCCNIpppW2onEXe2dVb8LUcKjYVqLVnGEeOaVDrBV14JSZSS/3E9dKZPpmzg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qKapJyO6y/fadcTC42/DuTDcVTUcOS604Lcc9O5P5O8=;
 b=4TWdjrvxMG6xMdT2Zyw70Jf62dpGt7MtEYpVGc2GiI27Wz5uD2Ar382587wuyB4oNnXiGkslSLJZUHV201fWVl+U2/HMD/I6pZzcskapx2Ztyq888s/L853J3r6VdNuDI3hi/K4PEc5uU2QtawR4k2HaLLXJM8wue0e/NldaSic=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ABZ2jgTRb9vC68mV167Q2q87NYNPUD39/f0poN1JDsVzvzGoTedZGJKixojOJ6TyuaRyHvVc7g5U/vfUNmhKNzj7SbldHb4NnB4+fAiSmms/I95btviefreM/ugF70E8a2k+dgzBK2Y1vyzKyRo+twPNRNzwJX7sNZS7la5Y5/aOqPTHK0Vf0RcR2uk1jM+5e5BACfmqoDSwEGH88hV2EWH4Z65219s48RcDw8WtbzpQD1984alNJJVZlFZm9uvaNdhgCBFSBUcaMWOwkk4Qnsq6NaTxeii8aX2P5izM0k0lFRIX4t7ZythGbhQSjbgZ8J+LYGkG0Cm/gqblAiSdhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qKapJyO6y/fadcTC42/DuTDcVTUcOS604Lcc9O5P5O8=;
 b=LSPVYTeKi8dL4uxpXtr6pCuYS1sTkpHIKOUx5i2M0p3zpWSdh1/n61HMHycWiirqkV5+0C7qMyKsQ3MphMIGU2KwVQ2HVPkwwwG6xXaaehqAbZo/xd5FAN4CJJD/W638vBWGZLqH4eB4pcciO+4hY9xIwUNkSuQFbWQmZNntRKbwVOXDjjDKom+2TmjsIoMokPjgbM9BGN3ZPzDk7nxxcFRyC6g9GAoN05OrS7VGFjH3qqh83FnGFPWTsTzu01po1s/l7o25KMBTSGgfy39J/qt9HDs4aFe1UNdIXeVx5WhZQRu4BjijQ5iWGoG+hj0Lzu5kCHeqE0t3mw7sVdvaOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qKapJyO6y/fadcTC42/DuTDcVTUcOS604Lcc9O5P5O8=;
 b=4TWdjrvxMG6xMdT2Zyw70Jf62dpGt7MtEYpVGc2GiI27Wz5uD2Ar382587wuyB4oNnXiGkslSLJZUHV201fWVl+U2/HMD/I6pZzcskapx2Ztyq888s/L853J3r6VdNuDI3hi/K4PEc5uU2QtawR4k2HaLLXJM8wue0e/NldaSic=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
CC: Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Edwin Torok <edvin.torok@citrix.com>, Rob Hoes
	<Rob.Hoes@citrix.com>
Subject: RE: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo arch
 flags
Thread-Topic: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo
 arch flags
Thread-Index: AQHY3mggOd+/b8rDG0avfRBy32H2Yq4Lm9Sg
Date: Thu, 13 Oct 2022 02:34:50 +0000
Message-ID:
 <AS8PR08MB799143ECFEAD9EE44476E8F092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221012182552.26866-1-andrew.cooper3@citrix.com>
 <20221012182552.26866-3-andrew.cooper3@citrix.com>
In-Reply-To: <20221012182552.26866-3-andrew.cooper3@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B18DD78D47D52545ACA639AB6401C7A1.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV2PR08MB9878:EE_|AM7EUR03FT057:EE_|AS8PR08MB7356:EE_
X-MS-Office365-Filtering-Correlation-Id: 6e3276e6-a5e5-4480-539c-08daacc3860d
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 3brve+I2refB32qxHu7Z8CwV6pOyC+EmVWRwParo3kr9gGj5PbIpoQcYWeJucXy2f4/C29eDnvbtUYJZ32fLvK1ulygz0a3i4gU7aQe8MwRGj1F2bysl59I2Z92e3dsrqaeVauCro70q9mHfHO4X9p3AuHgNlnx9jJeyDAEuYHz8WBPJGiZ0hPOBIUzRRIxLibANGJy0VZD3/S5qzuPQ3ekwQvf3EqY66ne+Yx4cxGA9E+QLrpoBDHJB4vzBMpwUY143rjVVhn4aKjJyysH6IAK42uFKSjlH6KfV/M2F5T7SvWoQ8QB4X5h/e6vwtdDaTN8MPZrV/uXgMAXzzt0iERtArHCTly37pd+3uRRUSFFgY0nF2kg7oRcLyj/ezf/THkvCy7ke9S7+nKF/5gBM8YX2KholnKDZ1PlaqMHO8ADRLwP38IL4iaxRiRY7m8MD4xLDSiaKiiGKy5sqAkS+jsv1WvJIIA/4+aDBAm+N56SCQf21gI9wI+IHyo7z5QmjaXUw/4jGSglJnvAeu47Z27L5AnZKMRraZAJL8Kr/tofVzXg9wRIpHIO5FIhn2LD51McU6bbgZ/Xuac0iGccikcXFzWSuuWFlAsjkoSkXOQh5EV+UT4Ycb6A8dq6/MCtxFu4ezpy4Z5X6MG9phYTg4pFiFdGnClcKeoYdwd0RNawpFp7qDfrfpso0XUYAPPew+7j7K2Rv6iO+IrgfBT/zPY+QAgDzc39PbtHooACjmIBo6h5NAl6mfYOxNV5PbYzWQ0AMIYPmOHwjHYcsdzCu4A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(7696005)(52536014)(6506007)(55016003)(41300700001)(110136005)(33656002)(478600001)(54906003)(316002)(186003)(4744005)(9686003)(122000001)(8936002)(26005)(38070700005)(5660300002)(38100700002)(2906002)(83380400001)(66476007)(86362001)(64756008)(66446008)(8676002)(71200400001)(66946007)(76116006)(4326008)(66556008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9878
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	72b3802c-6b47-4ad9-37ef-08daacc3810f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GYVRFULysOxRgY8H3dH/LNMLuNLvymaqnCT6ZeNsVmxQSDCQv0BS0+GOXla5jhYk8yibrDDoROIxL7CTbSahImQ+Ni6xM4z8+xna3NfJhGbQ1He1LM8i9jxEdwQwIhfw1tS2xG3ladSKlS2Fa3AyMeuZsRK3XEeoJdgqbiu1X2QvqxxZ3krcnpHrUS7RnmgRmKfPrtOL/qReK2tABSLKyTII29fppmrDO8NcF4ScmummeDkjBBRTBbi9iaeZEb8k0EK/vUhmQ2l2e8gb6uEQwxeNfmpZ2KhihsI1D8c9NzyEKQnBWCpiD7DxD7jCs5DLbA+YIOFungaUF+/r6OTnZnA3CO7bTIX6jh7WqfFmZB5UgiEZ5V39jVOtL35bTzisQuu8BsrlaE8Kz69paj5/2g90+EmsRwIzAuk58t3S4AvT6OKS/5tHxrIGXVWYlEQdm+JccnqjbxUmT8sq60buQgimL6+I32i1lbGyrrCV4lmhZlmOddY0v8QcHRUCuQCx3aXyhRBo2Z1FdM8WeG+bGmu2T9guMU2ZhVeu6H0DcxkrjLgVzWoC3bSDOoL6r8lmcBTZZzqUOoRJWjGdFaZo02mzbSd/f8pvaGAsXD3d9/JqSZftu+1nFM+ZmhIBVtLFYYgpW7PgV5s+3r1IgvlBng5jZnDFPxM+xgErFEosYFkLVDvGtNb3HvkKCjd9zBvRY7Bnk1yYReF8hOirtdrtqrJg+m6Fc4mPmr2CQZm0aciMfGwUS0dzKJJw2lEmDl1UAEmX9jmtf+4lJUz1XIta2g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(186003)(336012)(9686003)(26005)(55016003)(2906002)(82740400003)(52536014)(316002)(33656002)(110136005)(8936002)(54906003)(41300700001)(8676002)(4326008)(70586007)(70206006)(86362001)(107886003)(81166007)(356005)(7696005)(6506007)(82310400005)(478600001)(5660300002)(40460700003)(36860700001)(47076005)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 02:34:59.3498
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3276e6-a5e5-4480-539c-08daacc3860d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7356

Hi Andrew,

> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@citrix.com>
> Subject: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo arc=
h
> flags
>=20
> The current bindings function, but the preexisting
>=20
>   type physinfo_arch_cap_flag =3D
>          | X86 of x86_physinfo_arch_cap_flag
>=20
> is a special case in the Ocaml type system with an unusual indirection, a=
nd
> will break when a second option, e.g. `| ARM of ...` is added.
>=20
> Also, the position the list is logically wrong.  Currently, the types exp=
ress
> a list of elements which might be an x86 flag or an arm flag (and can
> intermix), whereas what we actually want is either a list of x86 flags, o=
r a
> list of ARM flags (that cannot intermix).
>=20
> Rework the Ocaml types to avoid the ABI special case and move the list
> primitive, and adjust the C bindings to match.
>=20
> Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware
> virtualized APIC")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 02:57:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 02:57:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421620.667098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioPp-0006QY-CK; Thu, 13 Oct 2022 02:57:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421620.667098; Thu, 13 Oct 2022 02:57:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioPp-0006QR-9S; Thu, 13 Oct 2022 02:57:45 +0000
Received: by outflank-mailman (input) for mailman id 421620;
 Thu, 13 Oct 2022 02:57:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oioPn-0006QE-SY
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 02:57:43 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id cdfe0aa2-4aa2-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 04:57:42 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B82BB15DB;
 Wed, 12 Oct 2022 19:57:47 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 265BC3F792;
 Wed, 12 Oct 2022 19:57:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdfe0aa2-4aa2-11ed-91b4-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 0/2] Static heap follow-up doc changes
Date: Thu, 13 Oct 2022 02:57:20 +0000
Message-Id: <20221013025722.48802-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

The static heap feature requires user to know the minimal size of
heap to make sure the system can work. Since the heap controlled
by Xen is intended to provide memory for the whole system, not only
the boot time memory allocation should be covered by the static
heap region, but also the runtime allocation should be covered.

The main source of runtime allocation is the memory for the P2M.
Currently, from XSA-409, the P2M memory is bounded by the P2M pool.
So make this part as the minimal requirement of static heap. The
amount of memory allocated after all the guests have been created
should be quite limited and mostly predictable.

Also, with the P2M pages pool bounding the domain memory runtime
allocation and the documented minimal size requirement of the static
heap, it is safe to mark static heap feature as supported.

This series handles the above-mentioned doc changes respectively.

Henry Wang (2):
  docs: Document the minimal requirement of static heap
  SUPPORT.md: Mark static heap feature as supported

 SUPPORT.md                            | 2 +-
 docs/misc/arm/device-tree/booting.txt | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 02:57:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 02:57:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421621.667109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioPw-0006ho-JR; Thu, 13 Oct 2022 02:57:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421621.667109; Thu, 13 Oct 2022 02:57:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioPw-0006hf-Go; Thu, 13 Oct 2022 02:57:52 +0000
Received: by outflank-mailman (input) for mailman id 421621;
 Thu, 13 Oct 2022 02:57:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oioPv-0006QE-35
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 02:57:51 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id d2cbf27e-4aa2-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 04:57:50 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B854D15DB;
 Wed, 12 Oct 2022 19:57:55 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 37A333F792;
 Wed, 12 Oct 2022 19:57:46 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2cbf27e-4aa2-11ed-91b4-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.17 1/2] docs: Document the minimal requirement of static heap
Date: Thu, 13 Oct 2022 02:57:21 +0000
Message-Id: <20221013025722.48802-2-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221013025722.48802-1-Henry.Wang@arm.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>

The static heap feature requires user to know the minimal size of
heap to make sure the system can work. Since the heap controlled
by Xen is intended to provide memory for the whole system, not only
the boot time memory allocation should be covered by the static
heap region, but also the runtime allocation should be covered.

The main source of runtime allocation is the memory for the P2M.
Currently, from XSA-409, the P2M memory is bounded by the P2M pool.
So make this part as the minimal requirement of static heap. The
amount of memory allocated after all the guests have been created
should be quite limited and mostly predictable.

This commit adds documentation that explains how a user can size the
static heap region.

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
 docs/misc/arm/device-tree/booting.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 87eaa3e254..046f28ce31 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -531,6 +531,13 @@ Below is an example on how to specify the static heap in device tree:
 RAM starting from the host physical address 0x30000000 of 1GB size will
 be reserved as static heap.
 
+Users should be mindful that the static heap should at least satisfy the
+allocation of the P2M maps for all guests. Currently, the minimal requirement
+of per-domain P2M pages pool is in-sync with function
+libxl__get_required_paging_memory() (for xl-created domUs) and
+domain_p2m_pages() (for dom0less domUs), that is, 1MB per vCPU, plus 4KiB per
+MiB of RAM for the P2M map, and plus 512KiB to cover extended regions.
+
 Static Shared Memory
 ====================
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 02:57:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 02:57:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421622.667120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioQ1-00070m-Re; Thu, 13 Oct 2022 02:57:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421622.667120; Thu, 13 Oct 2022 02:57:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioQ1-00070f-Or; Thu, 13 Oct 2022 02:57:57 +0000
Received: by outflank-mailman (input) for mailman id 421622;
 Thu, 13 Oct 2022 02:57:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oioQ0-0006zV-Hj
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 02:57:56 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id d5fcc967-4aa2-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 04:57:55 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2381015DB;
 Wed, 12 Oct 2022 19:58:01 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C5CC73F792;
 Wed, 12 Oct 2022 19:57:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5fcc967-4aa2-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>
Subject: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as supported
Date: Thu, 13 Oct 2022 02:57:22 +0000
Message-Id: <20221013025722.48802-3-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221013025722.48802-1-Henry.Wang@arm.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>

With the P2M pages pool bounding the domain memory runtime allocation
and the documented minimal size requirement of the static heap, it is
safe to mark static heap feature as supported.

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
 SUPPORT.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index cf2ddfacaf..ddcf8a13a7 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -298,7 +298,7 @@ pre-defined by configuration using physical address ranges.
 Allow reserving parts of RAM through the device tree using physical
 address ranges as heap.
 
-    Status, ARM: Tech Preview
+    Status, ARM: Supported
 
 ### Memory Sharing
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 03:17:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 03:17:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421643.667137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioiT-0001gr-JE; Thu, 13 Oct 2022 03:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421643.667137; Thu, 13 Oct 2022 03:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oioiT-0001gk-F1; Thu, 13 Oct 2022 03:17:01 +0000
Received: by outflank-mailman (input) for mailman id 421643;
 Thu, 13 Oct 2022 03:17:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oioiT-0001fp-11; Thu, 13 Oct 2022 03:17:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oioiS-0004F5-Pp; Thu, 13 Oct 2022 03:17:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oioiS-0006iO-CK; Thu, 13 Oct 2022 03:17:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oioiS-0004iL-Bn; Thu, 13 Oct 2022 03:17:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=z8MOwu9DtIsqdujlJmNXcP5ULLJ4Ko/J6/Oni7HqGGU=; b=WhsxZBFnVIetL/9gQsy+p+y8wq
	U9ndTGdDLL0e2lHWE60AXau9ZuBRAmxmAK+BuYBBF4xZDaHGu6MrxADs9GIemBWdC59XyJJEHjUiw
	Gvma3mJY7myjKr6EWCldmVKDYdBE/Er/TDt9TdKLKYdNYwnyL9ylK1kkkSa4uO9xs/Ik=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173649-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173649: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=448d28309f1a966bdc850aff1a637e0b79a03e43
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 03:17:00 +0000

flight 173649 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173649/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  448d28309f1a966bdc850aff1a637e0b79a03e43
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    5 days
Failing since        173492  2022-10-11 13:01:50 Z    1 days    8 attempts
Testing same since   173619  2022-10-12 20:07:50 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 446 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 04:48:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 04:48:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421657.667165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiq8Y-0002km-75; Thu, 13 Oct 2022 04:48:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421657.667165; Thu, 13 Oct 2022 04:48:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiq8Y-0002kf-4O; Thu, 13 Oct 2022 04:48:02 +0000
Received: by outflank-mailman (input) for mailman id 421657;
 Thu, 13 Oct 2022 04:48:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiq8X-0002kV-8N; Thu, 13 Oct 2022 04:48:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiq8X-0005uw-4z; Thu, 13 Oct 2022 04:48:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiq8W-0003td-Og; Thu, 13 Oct 2022 04:48:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiq8W-0006Vk-OF; Thu, 13 Oct 2022 04:48:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5XjsMx8Ji/DTpHaPLn5Z/o82nr4fNPxkBzbQBQpFkxQ=; b=SqyV8UTysmTWjoHhOJjreql+if
	pKVaoU/pceEPvbF4R/+YQ+y5am4mb0DuNCXohV1tfQi/Oo3SJ6tveR6LZZjQPqeffeoBHbXAyx6tv
	liJJBPkUJzIXUwZMpFlHsCQFOrO0zeUBPTmMQVbFoPGG/lNo7MGMCHQmfmCjhflhRd/w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173564-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173564: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=49da070062390094112b423ba443ea193527b2e4
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 04:48:00 +0000

flight 173564 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173564/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                49da070062390094112b423ba443ea193527b2e4
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    5 days
Failing since        173470  2022-10-08 06:21:34 Z    4 days   14 attempts
Testing same since   173564  2022-10-12 08:49:54 Z    0 days    1 attempts

------------------------------------------------------------
1011 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 99044 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 05:19:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 05:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421673.667194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiqd8-0006sP-Sb; Thu, 13 Oct 2022 05:19:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421673.667194; Thu, 13 Oct 2022 05:19:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiqd8-0006sI-Q1; Thu, 13 Oct 2022 05:19:38 +0000
Received: by outflank-mailman (input) for mailman id 421673;
 Thu, 13 Oct 2022 05:19:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiqd7-0006s8-Mg; Thu, 13 Oct 2022 05:19:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiqd7-0006uL-Hs; Thu, 13 Oct 2022 05:19:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiqd7-0005kF-9B; Thu, 13 Oct 2022 05:19:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiqd7-0005wQ-8l; Thu, 13 Oct 2022 05:19:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4fKKHUfRTpvbwj7dDvfmdUJpCO9W2mbXtLDbX6oXBj8=; b=Wfs9lQmG/FT9cGdSmL2zQjkVFa
	BeZa+qOxQRpyhnQkq+RLVXDE7hH4YqqnEM0qBO1k26Hm2B2xxNTI0WivhDAcMHCNNjNHPJMwpVo5h
	0y1tGLrwtp09nPY6kXJhsyW+8q+nuTfDu9X+Tx/a/smMhGeH0a/L5jUNe1sG7q+FUp8k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173614-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173614: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e7d7f02c8e157e936855a091948757f78c7d0298
X-Osstest-Versions-That:
    ovmf=03710322893afb4d0efb57781dd07c2aa9cbb9e8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 05:19:37 +0000

flight 173614 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173614/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e7d7f02c8e157e936855a091948757f78c7d0298
baseline version:
 ovmf                 03710322893afb4d0efb57781dd07c2aa9cbb9e8

Last test of basis   173553  2022-10-12 06:10:36 Z    0 days
Testing same since   173614  2022-10-12 17:40:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Qi Zhang <qi1.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   0371032289..e7d7f02c8e  e7d7f02c8e157e936855a091948757f78c7d0298 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 06:41:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 06:41:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421693.667241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiruM-0007pu-94; Thu, 13 Oct 2022 06:41:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421693.667241; Thu, 13 Oct 2022 06:41:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiruM-0007pn-6X; Thu, 13 Oct 2022 06:41:30 +0000
Received: by outflank-mailman (input) for mailman id 421693;
 Thu, 13 Oct 2022 06:41:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiruK-0007pd-HL; Thu, 13 Oct 2022 06:41:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiruK-0008Kv-EE; Thu, 13 Oct 2022 06:41:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiruK-00029Y-3H; Thu, 13 Oct 2022 06:41:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiruK-00071M-2o; Thu, 13 Oct 2022 06:41:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NV/bSogk8FQ8Pn7znxHzKrQBWU9aSpRW1jGQlL9hPhc=; b=q8WelRkFsLolHJumFDgQfEEEys
	JLqcm1VvXSn1OhkCK1/hB5yFtDzU3n7gvbyFCJiXS+CyGcJDbBBNP0GsDH22K39ohN41cJvxuTbX5
	gyZTbY2DvfW1b3H6f+hPDPDQ4rP+G6sfR5gkAJbRAukFunkvaU+3pzTCD9tjkOWKdJX4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173670-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173670: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=448d28309f1a966bdc850aff1a637e0b79a03e43
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 06:41:28 +0000

flight 173670 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173670/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  448d28309f1a966bdc850aff1a637e0b79a03e43
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    5 days
Failing since        173492  2022-10-11 13:01:50 Z    1 days    9 attempts
Testing same since   173619  2022-10-12 20:07:50 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 446 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 06:48:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 06:48:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421703.667259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ois15-0000AQ-2j; Thu, 13 Oct 2022 06:48:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421703.667259; Thu, 13 Oct 2022 06:48:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ois14-0000AJ-W8; Thu, 13 Oct 2022 06:48:26 +0000
Received: by outflank-mailman (input) for mailman id 421703;
 Thu, 13 Oct 2022 06:48:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ois14-0000AC-C5
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 06:48:26 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08bc8902-4ac3-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 08:48:24 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7646.eurprd04.prod.outlook.com (2603:10a6:102:f3::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 06:48:22 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 06:48:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08bc8902-4ac3-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L0odZEpW7nICs6RHpA5TnVUOW7lsciLXjdoHAe8BveNll9FhU7mfUf9H5qBGqA6P+xS5rRTUK8U6AK5qS1AHw4yH92MLfLqMRsRwJC+6SqCrj9+4ViwN6/RZtYrCgSkxRXy/itAR5Dq5DmYoMnUcaoXjli4Q7W7+vnWWZ3mrCeq8qTfa4wTfq369IW/7r2HhJAtMBaGFNn2YQUDFiEvj4vHfwiO5MZc5aOfVEDwJAUZxOS48zR+eQ8qfu03FYwM5kp7AIWK1aa0aE4X2EVkFExoEPuZrOuJOg7OsKbVB2JxRLk+2F/pii4Qp1/L0BQMtwsLXeIq82XEl8u2qo29K4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ezaXX3tuWYuuKtIIcFyc3PbRfsPfDcPpzv/X2sTSW/8=;
 b=hapT/jNhLdaUYxXO8uuUL2mK3QagCzll0yQQtt8TnZmma6AzjrMUUGs/crl3bMYKZI7lmH4mv2JjlkFN7a3PPxP2M2xP3z7/Mh9/DXuNWIg2I1dkT0ljy55PdnpOTU4qiqLwSsLNxf1hEMdq2ZirvioHw+0fR8cJdPTHx9fa/z3Vd/gDEx5GwRRDIYrMIz737N28fVTOCU9B229WDxiQumWjeBNZomu9Nq44fODlD1Uo0C1FtC6lhtSGYf0uj9yWDjSEeNJQ157LO8lFRoYxH9nZeiG+nKWpmw2a+TUG3D44B00hRfc+QY9TYUtJh1UFCCSAos0/mlkqtAeEwdq3Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ezaXX3tuWYuuKtIIcFyc3PbRfsPfDcPpzv/X2sTSW/8=;
 b=B3YQz2RT+GgKqR1TF2b8zKEMImE71apxzWjXQdRrbJf14RJfRbf+vDrspFoHTHFfZO36vETy6Jiblzs+7Eo8SANgawjW91NyyY1TiLoRU7dKw0GDmh9EEMslM5A2JSNf1xIgE4SrB4whLVWoprnqPtU22LbdCxvFYtoDdxnCaWk60UOmEJI2mUSf8LkO7IM05izEI+ij3CrwGp7XRGFRJOySPnZAlSZlPEUqYJ/Z7cykH7RqV+IQvIQ0arQpFtLrOBGDS+k3whyGUSi02A7K4EjGVvOQTzMdu8Ggfm5rnpfN3/wXjimD5ug90b15QFG64R2DLE9G95lDJm5+Dtx/7g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
Date: Thu, 13 Oct 2022 08:48:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH][4.17?] x86: also zap secondary time area handles during soft
 reset
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0087.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7646:EE_
X-MS-Office365-Filtering-Correlation-Id: 17470313-8151-4fa4-d87c-08daace6ebea
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QjzX8NnY0KGVfUGLWL50pX/Ksc+2RZCbMqxyiVHFp2TMlabl27Ki5mfg1OhdG/XV1Tw8ZHgTojDy9Mo5JXKAvghDa8oeXFXMiiRcHr2PPNVOPOkQ1DI7w4UPMt4pAMDvD+US2xgoRpgMXrVqsR9x2wkP7ej/JV88V8oThhP+B3qWe8ZVQuZWCzsomFl5UZeVR6V0LEQrI9i2o66J+SlZQ7tQJWRmdfCGmAQJYJfgxj9DpOn4btzSep6sfChMyVsvrzsit7DIdsJuCuhvX0xPRQf3lOWhges5QtT9cEnDClu357oxO5KXiNpXyTs8bSLdw67n/dvLjn7hlQPvpvh8Y3sTxOVLbrDA+d67gX5em2kqnXBahOPF+PzvDMjHsRcm8bLwnTqzkBAvKewGKxqKAm02lgnmz+uxry2A8n/zigvEMZVVPcEWQ7VT6U140ak2Ds64MH2izSVMPTmyA2QX3OsDYBcM23AAZHkvlF6GN1YlFkCpd2g3F8CPg8RiK6BQITyeM75eQ0C+pvI6yIP4zlZJF7+/8qrT6yT9rZMp9+nr6jjwbkQCMKMKKEPBDSnt8GPc9Vdn/AwQrwMBRK55/J8Eby2oGUCYwVA0tEDSjdhE0aCywE1LlsFhD6o04d/4mLPR36U+oweuMAoaYFvnsFvkRecel3R9fL/UP1r2LpiZpT4IaEKtWYklAmLQRvDO1jKJgyDMvZ+IaHqWU8MiCJ5kkT1A9kGO8lXvHzzzXxRimygHga0tiDPfvC99Lt+/1VkklrQNsdwiFBzX20RC353EnmivThugeFUU5j65SP8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199015)(478600001)(6506007)(36756003)(6486002)(31696002)(86362001)(38100700002)(2616005)(6512007)(186003)(4326008)(2906002)(41300700001)(8676002)(316002)(31686004)(54906003)(26005)(66946007)(5660300002)(6916009)(8936002)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0E0SnI5NGZtUWUrdjZKZStkRy9lWGR5d3FjamhyYTR6bWZ3TmVPbEhXTlhh?=
 =?utf-8?B?TWEza2J1L1lKVnI5NzVXZTdhYUFqdnU5enh2T01FN1c0K3NiYnR2aUZMNW9n?=
 =?utf-8?B?bGNiSmFVMTNKOGUyRWVnL0w1ekpUUUdYa2xYVk0wdGNrdzQya05yU2ZzWVFZ?=
 =?utf-8?B?UmZIVEQ0ZzI4VGFjc0xUMTJnSyt0bjQzMVN6YjRaNGxzb0ZtaW90dzlGMy84?=
 =?utf-8?B?bDAxV3FmMGtwUSswQnFNYjRhcFV2bHFtUE5wODVqYWlBKzhLRXRXQ1BVS1VJ?=
 =?utf-8?B?RWN3ejdUN21mNjZjTEtRMzlaR1JqTEo1UHc5S2ZlWENxb0tUMWgvNmJZbnEx?=
 =?utf-8?B?S3BNL25QUnhrQ2NzeVpZWFNhUDhFL21CbHJqbUxIbTM1NVJXZU5NWTdKKzBD?=
 =?utf-8?B?bE1xeHRUalMva0Q3WnpYaXpOdnRKTE4wTlcvaEliN0VjOHFOb3pMWG9laEhN?=
 =?utf-8?B?SnJWV01zZUFCUGxoeWdpc1N0ck9LV2hsMEg3T2VHUGVnaVEyaXRneEYvbmQ5?=
 =?utf-8?B?ZEREL2lLY0RSaW4xT1dHVjliYVh1Nm11V1lNQ09qdXE4em9zWjVFTjRjSVRL?=
 =?utf-8?B?VGFObTRFNlQwZndwek52ZTlORDBEdndGQkRJQ1VsdWwvQ2FBaUVrNE1hVTdR?=
 =?utf-8?B?U3EwQTVibWhHbUxEekJpNlhrMzhoT3hXY2hrdTNxeWFpNDhlL216RHRLTkdN?=
 =?utf-8?B?SXc0cHJEeTQ3YzVvNFoyYytZKzU2Z1JHNUpjNEcramI1OGxWbGZTUW5PMTJW?=
 =?utf-8?B?RkxROGFhS2Zoc1p2SCtiaC9rajZrQWJYaW0wNjFPU3ZlWXEySE5OcmdmMFlV?=
 =?utf-8?B?TnVHUXNIVkxMVGpsUnpzbDUyZERWSEpmZVMzdlpxS25PK2ZBMi9rSjFuaGt3?=
 =?utf-8?B?OW1Qb2hhQTc0QTlQTE83ak5QQjI5L0JGOTdQMzE2eW5RVzF6NUoxVmZBMUhJ?=
 =?utf-8?B?QlRUMjlaRVUwdWlvUy94ZXovMTRKemFla0RVS1g5aFY1T09DMTJSdkQzUk9o?=
 =?utf-8?B?WncwVXRqeWVGem54T29sMjlucEQwTkpEL051WGs5cEh3MDh5UEJCTjRGZUZM?=
 =?utf-8?B?ZHBiaTc1N2gydk9vVjRubjBYdVlZM3pnQUNxQTYrcXpNamRpS3dmalhaY0lT?=
 =?utf-8?B?azc2bDI5RkxkeGVlOGwzRnMrQ29IdDVkUG9YOVFpaENCQjZLWW9HVU53U3ky?=
 =?utf-8?B?dGxwakRjN3pwaFBoMDIxK1VvTFhkWVhIbVMxR2M1L2M3djVrUEhwYjh4Skxi?=
 =?utf-8?B?c3ZRWWpZQ1JJT1B4a1RhbjU2elUyODMzYjB4SGh4aWZMVlRkWkxOT0kyc254?=
 =?utf-8?B?OEVkOGQ0QnhaczFEZG5Pdy9EQnFIM3A3M1FiRmNLWmZZVERWUFJFYkFFaGRB?=
 =?utf-8?B?Z2M0OWRiMzNkWk5ZY1o1c0FiT29vanZNdURqYVFuVHBYaG5JQmtDc2ZJMWVC?=
 =?utf-8?B?K2c1bGw0NnI2S2xETDdVbUtVR3ErSUxUNTEram1rM1laaWdCMHFTbzljaUhn?=
 =?utf-8?B?KzZtSC9RaCt2Y2NpaWdVM0RkOVFkL0l1aUFKQldaVlB4Y1V4ZlA3b2Z1U2NK?=
 =?utf-8?B?aGdHZXFabEhBR0hGUkh1ZGJLczBpbXYxVE5qL01qNkRmb2FWUTQ3SGYzSDlh?=
 =?utf-8?B?ajdZNERsdGJhL2xvSmhac3AyeG01NHdoWmFaMlduQUN4ZExaaldMUHJXenZa?=
 =?utf-8?B?UTVyc2ZFWUlzalhpRU5RekhTTkhJZGMvQnl1WTV1Z0dpUEpSMXZ5aXRDSmdt?=
 =?utf-8?B?c1ZvUHVHVG4zb1hkclNrSkxxUFljenEzOFJpUlZuSW5QaHBJVlFXKzM5cCtY?=
 =?utf-8?B?QTlJNEF5Y043cVhVZXBoV3FSVnJHTndrbVBXS1lTNjdGaXhqR3BWQ3FWVSt0?=
 =?utf-8?B?RWFVdkpSRkRFdHhDSEJuaFB3bEZPV3lmL2Z5WS9SRDBqWE1ETXJ0cVFZVUZC?=
 =?utf-8?B?SUtXc0pjeGt0SVdMdFlwS2VQZW16Y0plNzM3cy9sTzJFVUJIbzNucFRzR1Jx?=
 =?utf-8?B?U2pLMW1LQS9GZlcrWFc0M1NMdEZBNGxXVitSRFo0UXcyaFJqbWVQSDQ3TGRM?=
 =?utf-8?B?SXpvM1ZVdWkyUld4NFAySHp5R3djVXVhUHVyK3NIMldRSFR3M2tHMFBUUWkr?=
 =?utf-8?Q?RngVsEdLc8ldXhGcuyLLz7fNJ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17470313-8151-4fa4-d87c-08daace6ebea
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 06:48:22.8088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BrZcOXHF5EWpNkh85KlDr4ynPJkMB/Cz9wIh6G45ACN8XLPg/Af7qWKTCEV4Tn/ZKk+brr8mWsPjxpwpW7zzlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7646

Just like domain_soft_reset() properly zaps runstate area handles, the
secondary time area ones also need discarding to prevent guest memory
corruption once the guest is re-started.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
To avoid another for_each_vcpu() here, domain_soft_reset() could also
be made call a new arch_vcpu_soft_reset() out of its already present
loop. Yet that would make the change less isolated.

In domain_soft_reset() I wonder whether, just like done here, the
zapping of runstate area handles and vCPU info mappings wouldn't better
be done after all operations which can fail. But perhaps for this to
matter the domain is left in too inconsistent a state anyway if the
function fails ... However, at the very least I wonder whether x86'es
restriction to HVM shouldn't leave PV guests undisturbed if a soft-reset
was attempted on them. Right now they not only have state partially
clobbered, but (if the arch function is reached) they would be crashed
unconditionally.

--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -951,6 +951,7 @@ int arch_domain_soft_reset(struct domain
     struct page_info *page = virt_to_page(d->shared_info), *new_page;
     int ret = 0;
     struct domain *owner;
+    struct vcpu *v;
     mfn_t mfn;
     gfn_t gfn;
     p2m_type_t p2mt;
@@ -1030,7 +1031,12 @@ int arch_domain_soft_reset(struct domain
                "Failed to add a page to replace %pd's shared_info frame %"PRI_gfn"\n",
                d, gfn_x(gfn));
         free_domheap_page(new_page);
+        goto exit_put_gfn;
     }
+
+    for_each_vcpu ( d, v )
+        set_xen_guest_handle(v->arch.time_info_guest, NULL);
+
  exit_put_gfn:
     put_gfn(d, gfn_x(gfn));
  exit_put_page:


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 07:50:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 07:50:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421717.667294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oisz8-0007W8-1p; Thu, 13 Oct 2022 07:50:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421717.667294; Thu, 13 Oct 2022 07:50:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oisz7-0007W1-Sw; Thu, 13 Oct 2022 07:50:29 +0000
Received: by outflank-mailman (input) for mailman id 421717;
 Thu, 13 Oct 2022 07:50:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oisz6-0007Vv-BA
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 07:50:28 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2086.outbound.protection.outlook.com [40.107.104.86])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b2ee0c49-4acb-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 09:50:26 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS4PR04MB9652.eurprd04.prod.outlook.com (2603:10a6:20b:4cf::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 07:50:19 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 07:50:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2ee0c49-4acb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OWGbKS6FTBqsdMQntUDdzWCgCYsfurK8YQ7iYhHQTOdL3Pr/UCqO1s3dInYuQwrNsVVoXZO4jrxpzMw2hVhZgGugfYU7egSQiCaq+NPxptwRbTyaf4PJg5Z3cBQbo2APnM70k3apyxILQJ/dz6MEXnmw2PB1N/7ntOB0gy2nM6Ol/FOGCmfV2WryvIJyn/P8AOfmWDAKIRmAefSJLDK5EusG91MiIh13de3N4lVUnat8TKXR3FnvXYGkecHyRlgBByNrYDbGVcpJ4DaB2MQDTIb2+s78zdCfwJrKgj1ShYwGbWK4UxZ66z/kfibgj7dzzWQdQ0QzmS3Khf/+wH42/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hCdhuOo8PfwjO9SwCbYCLwTfZq8gL2IBG0UP5nKIdTo=;
 b=jSsNjFd3+Zn/EbeTWB18odtwvtc6U/9FNwJW7q50EWYz9jSj8EfZs8bs9BpyNKx0AMyETjtZ5oSg5Lz/cIUDiOZsH+rSNQtHF3CfQ0Jmrayqx/IQGiE2m6tKisc1g+nRBfQVwzftUq/59SuWcMwjHkV0X2P0LY0Xog7IRHGnC6ecgFboJ5jrjKxiNkuIfJN9f9L+quTVe8aSRwR30PKfWav+adYY6aoCG/OFdsVgbhQFdPvEDDiEqphZp1vHulaYndCLcDrIvvdf2LPnC9HNxt1crUljjq8WG58WU9GRkx+QXvtxMKNZYUAakiVSmbaTQ1SEOGEAa2yuEu4D2Ta2YQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hCdhuOo8PfwjO9SwCbYCLwTfZq8gL2IBG0UP5nKIdTo=;
 b=fOPhpl4axbzRv9GMzBLMeZQrc7WLDvUNI/SqkJ64bD8QStaL3gf0+tY5uOBwN0a3tos8FukSuee97Ie8HdmzZKY34Yi1x+pRRopfO/8ezCIifm/OcAu3781zQF4qxqGXvXYeH0u5U1gMFX4ObxLY7+n9TlINoB6U4Z1v8frRiLzU3lh4berhYawLQleE2CMiSO5DrYLCY/itmyRoeB/bv2HMEvnK2CVLZhDAo0ArSgKCo1a3jZpHdPniKbWBi0GtJowyartz+3y7htHf4zEuSLhN5FbP+/DVDbnHEu8UVyV1IQsywiXOMaEXEbqPRNaaIdFnU8lKRR2XoqDxxIIsYQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
Date: Thu, 13 Oct 2022 09:50:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: Proposal for deviations in static analyser findings
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0091.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a9::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9652:EE_
X-MS-Office365-Filtering-Correlation-Id: fcc9dc43-4583-4e02-dc91-08daacef92e5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kjkicChwoPgZC7Nffl3hUz+sVohzKmnAoNuklGiNBpM9h2F3BbwLmhrHL3h5dt4ZmG16Qz4AgBIj9E7FOil/3MJ1IedassYwbhzug6rleh0WDBSHX6tpjoFMEBqpO2Ak70fUkzDfjO/kRv/K1AXnsVtX1rtLjlJzvS6//jhq59UBf/sHGvW8gnRxC5krnH+Ne39/g2jjgS1iaBMTXd6vMlC/dENO/gMBK3fZCizfLDvlwXHYBwQ9r/bQTwdFoaGHbXlNJhMstlg9DGSluI7ibQqfXAb/8kd4TQqgwS9ehQ913iA0Zfv2naac//RRSm3sOYOSOPfPBh8MWJkCo4jzwCQKxxQkWhGF6OX4iWWr47Y15yj/0Nfu8jDsUlsOEiRv88gSQctEDxG8+XcFT1eYD28JpXiFQaV3HXFQgFIudgWyJHh6f5Z5OOAMsIFtx75IiPG5H6tXrSv00Xr9g5g7e2erRGoWQ7bJT4JExEu5eOmoaJq47AYOxhuf0es67kXuPs7rQn7N2O1SV50xL4M/LaP3Nn3SPzDkcgF4nZ/3bzRsmn4f+vPxc8IkhWobslaaJUMCPSgFD0/3lpHdRGprKm2EeYSaTVwlQ/OXLO4fttbu4H4s3F3ZjfqmNpfndJ8yT5NcvWwylRY9hPz3VgSGGd7OhNJ2MTGXTKClR7RRceChJE+XitIza5FnsrkhlcVaXQBPrngNuK72oOweH1g7Z6sA3h5vP27OAElU+9fb8h1wl2/tElTd4LPEgWOn+nEpeAjHt1SR4SeAwjT1dgSd2HlAZBeSCKKcuHCe8cWGeLk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199015)(31686004)(6506007)(36756003)(83380400001)(38100700002)(53546011)(6486002)(186003)(31696002)(478600001)(86362001)(6916009)(6512007)(54906003)(316002)(2906002)(5660300002)(2616005)(41300700001)(8936002)(8676002)(4326008)(26005)(66946007)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WnJTdTBYYjhJZ2JQUmNNQ1R3MkFTYkpmZVo4a0pWU2ljVnpkTG5xRjlFWTRF?=
 =?utf-8?B?QXJab1ViL0JwY3FzUXdwMy9SR0tmREtUU1o3a21PSi9wQzRLMHk4OUpBYVRR?=
 =?utf-8?B?RDIyRExyRmFadDJYYUV0L1lsWVdiQkhpS09HbFJabVRRVmx0TzlOck9wMkR5?=
 =?utf-8?B?aVA5MnFSRzdidWliTnJ2TXBrd1E5MXQ4bzdaaWFoYis5ckZvM1p5eC8xS1RL?=
 =?utf-8?B?elFoNmNGY1NueTBRZU1rbTFsbUxYQnd2Qi9wNDMyR0JibnFvQm8zMjAzM2F5?=
 =?utf-8?B?Tm5DV3NUVk9YeVc5dGRHaHljT2xVTzdEZEFGOEhGY1VJQkxQamJ6b1V4SGNh?=
 =?utf-8?B?azJrbVZNV3dqZXYySlhUT0R1amdtNVJ6NENGN0JpTUVndVM4UFpEdUxsTU9Q?=
 =?utf-8?B?UHV0N29yQnEwL0EweFhMVEJnRElMeDlOdGIrZjF5UHNBNGpSNEFDL1daTE1m?=
 =?utf-8?B?QlZlS004Uk5uRXZ5M3hxaEdNYmR6T2xCU29ZU2JBSGI0anFKWWF6YVlrWVFq?=
 =?utf-8?B?b1FLbE9RMWhyOTVEaXQ2SjBFUnlGcGFDVGRIUkc0Y1ZocmJralh5UmRjSWJp?=
 =?utf-8?B?Nm9LU3ZTRk9RWkd0VEV6ZU5pa0dzbWNGUlByMmloZTBFd2VGRGliM1lZckxS?=
 =?utf-8?B?QWlBMUhpWnNJRE9YQmpKSTZRTm5lK1d6QzJTcWFTMmFVNzNiTU9tWW5HVWZw?=
 =?utf-8?B?Si85bFd0MVlvWWdFTG5Nb0RRUVRxUllIdDlxWTR3WXZSS3Z3SE9wOFFVN3M1?=
 =?utf-8?B?OXdyQllZWFRlbkNBTTZkUzZVU05SR1Vma2MvcFVPL3VkdklKdkx3d056d2Vr?=
 =?utf-8?B?WVI4YWQyR1FvQlgzemJWRHZOVUJQUDE4N0VGQzhRbWRmajBabElKQVU4em92?=
 =?utf-8?B?WFNNSjVPQVkrZ0E5dTk2a0NXKy81a3hpTFppM0hZcFJHcFRnMFMwN0d4ckx5?=
 =?utf-8?B?d2xwTXZhcXVZWHhvT01KVzRJVWtuV2o0eW9sNDlyVWRNUHlQVFhqQmtWb2hZ?=
 =?utf-8?B?UjFSNmRtTFk3RXlyZVdXL2diWTBJQStmMmROaGVPL0FDNExKejJ0MGl2ZlBG?=
 =?utf-8?B?QzJqd1VESGdQVStJcnNMTUp5MXpPdE44cnRIWmdiWFVqY3duZVVGb0hQTGJ5?=
 =?utf-8?B?T3F1b2tjWm1IL2Q3WE1jdHBsOXYwWWNZaEplM2cxR09FQjBBaE1nbUVNM3kr?=
 =?utf-8?B?bFB3UG12RmtFaWk2RjRPdUtZRGlxeDhBT0duTU13eWM0L2hCcDAvTEYrdnJo?=
 =?utf-8?B?NE8xQXVZR2o4WEFTOVpoclVXaEpUS2J0ODFuZDVHTG9ZTlZGc1pFVzE2ekxQ?=
 =?utf-8?B?QkxwVGJuNVp3djNISUtNNDA5U0ZnY1VGc1VFU1hkL2kybytHTXFNOFE1U2x1?=
 =?utf-8?B?aHZtUEc4UFM3SGpVSjZ0bm5Cc1BZcERWSGsvZ1dQQ3lEeE00TDd0U1I2Vlc3?=
 =?utf-8?B?WHI2N1RDVkFTMEIwajdoTDVqcjBCSjdSS3htRzVEV0p4SFYvU0xhQnpjK21T?=
 =?utf-8?B?aXE4Y3QvUTZIUFBIeGVXMW9lemNETzZtRzVHVzFVdndwVVVEdW5qMzA1ZTAv?=
 =?utf-8?B?STRFK3lwQVlxS0ZoUE5DejVEdzVWdlVjenJSbDRKRG5lVzBJQ1dBWXZGK3NU?=
 =?utf-8?B?dlVaZHB1bXlzazB1ZkZGZURqMG44R043cy9Nd2c0bG5GQzZVT0tVeHlBZHFu?=
 =?utf-8?B?cFZwNGIvSFc2RDNJR0xNZ1ZyZVN3cExES29pQWVNWktXVE1UaHpjQzc1TWY5?=
 =?utf-8?B?VTNxRnFnbnlTR3pZaTBYU2tVUWxjRnRocjR6TTVUQlFGQVU5TVVyc3hoK3hZ?=
 =?utf-8?B?eDd1MVB0ZFg0aDAvVUlSUTYyK0M2V2tKTGtsM2FsQ2FMeG9RY01FN1luN0FB?=
 =?utf-8?B?STZxN2s5TnNYQnBGdjh3Q0h4S2VnUHpiZlRxNDNVVkwvWmtUS3F1ZEtsSEVr?=
 =?utf-8?B?R1NBV0hiOU5lTXlUMUM1eHRRL01WN1UxWkp1UFB6N1VnQ2tsOHlkUnhqc01B?=
 =?utf-8?B?cDFDYjJwTnMzMlBiRnhCTk1yRC9ZeHc0OWgrY0YrUllVTlpiM3VBN3VNNUJl?=
 =?utf-8?B?Smx0UWRva0dMTkV3UWlreWZjTk1NL3JnQ0Zub1ZscWFyZzVpZ1U5aEwvZGha?=
 =?utf-8?Q?COhibA/EYadgy+GX9tc3Plxki?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcc9dc43-4583-4e02-dc91-08daacef92e5
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 07:50:18.9607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AwI4DPAak7dyDc+7pZy4HCSmUOb4wFp0QCEobHh7UjKGG19bCBXFN72pAPxk+2pwFZfYJXILDl4TNT74zob2AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9652

On 12.10.2022 18:00, Luca Fancellu wrote:
> Documenting violations
> ======================

I expect this is mean to become an in-tree document at some point?

> Static analysers are used on the Xen codebase for both static analysis and MISRA
> compliance.
> There might be the need to suppress some findings instead of fixing them and
> many tools permit the usage of in-code comments that suppress findings so that
> they are not shown in the final report.
> 
> Xen includes a tool capable of translating a specific comment used in its
> codebase to the right proprietary in-code comment understandable by the selected
> analyser that suppress its finding.

Is that tool in the tree already?

> In the Xen codebase, these tags will be used to document and suppress findings:
> 
> - SAF-X-safe: This tag means that the next line of code contains a finding, but
>   the non compliance to the checker is analysed and demonstrated to be safe.
> - SAF-X-false-positive: This tag means that the next line of code contains a
>   finding, but the finding is a bug of the tool.

We did discuss this: False positives are often specific to just one of the
tools used. I think this wants mentioning here, including the implications
(iirc the plan was to keep the tag generic but make the table entry express
which tool it is that is affected).

> SAF stands for Static Analyser Finding, the X is a placeholder for a positive
> number that starts from zero, the number after SAF- shall be incremental and
> unique.

Nit: "positive number" and "starts from zero" don't really fit together.
I guess you also want to spell out the radix to be used as well as whether
leading zeros are expected (and if so, to pad to how many digits total).

> Entries in the database should never be removed, even if they are not used
> anymore in the code (if a patch is removing or modifying the faulty line).
> This is to make sure that numbers are not reused which could lead to conflicts
> with old branches or misleading justifications.

Can we add provisions for shrinking such entries to e.g. just their "id"
line? Or is the intention to be able to re-use such an entry if a matching
instance appears again later?

> The files where to store all the justifications are in xen/docs/misra/ and are
> named as safe.json and false-positive.json, they have JSON format.

And both use independent ID numbering?

> Here is an example to add a new justification::
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |            "id":"SAF-0-safe",

Is the SAF- prefix really needed here? And with "safe" and "false positive"
being in separate files, is the respective suffix here needed either? I
think the file should be as clutter free as possible, considering that it'll
grow to quite significant size from all I can tell right now.

> |            "analyser": {
> |                "cppcheck": "misra-c2012-20.7",
> |                "coverity": "misra_c_2012_rule_20_7_violation",
> |                "eclair": "MC3R1.R20.7"
> |            },
> |            "name": “R20.7 C macro parameters not used as expression",

What is the second string here supposed to express? The explanation below
doesn't really clarify that, and the example here doesn't seem to fit the
R20.7 subject. Maybe it would have helped if ...

> |            "text": "The macro parameters used in this […]"

... you hadn't left this abridged.

Furthermore both this and ...

> |        },
> |        {
> |            "id":”SAF-1-safe",
> |            "analyser": {
> |                "cppcheck": "unreadVariable",
> |                "coverity": "UNUSED_VALUE"
> |            },
> |            "name": “Variable set but not used",
> |            "text": “It is safe because […]"

... this reminds me that there might be multiple items on the related
subsequent source line, only one of which is actually affected. In the
SAF-0-safe case for example only some of the "_var" uses inside the macro
are not (directly) expressions, whereas "_name" is unaffected.

Taking this example I also dare to ask: Shouldn't tools be aware that
token concatenation necessarily means no use of parentheses? See also
below.

Also two formatting remarks: In the example above you intermix ", ”, and “.
Are these fine to use at will? And can we aim at being consistent with the
use of padding blanks (you have them after some : but not after others)?

> |        },
> |        {
> |            "id":”SAF-2-safe",
> |            "analyser": {},
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}
> 
> To document a finding, just add another block {[...]} before the sentinel block,
> using the id contained in the sentinel block and increment by one the number
> contained in the id of the sentinel block.
> 
> Here a brief explanation of the field inside an object of the "content" array:
> - id: it is a unique string that is used to refer to the finding, many finding
>   can be tagged with the same id, if the justification holds for any applied
>   case.
>   It tells the tool to substitute a Xen in-code comment having this structure:
>   /* SAF-0-safe [...] \*/
> - analyser: it is an object containing pair of key-value strings, the key is
>   the analyser, so it can be cppcheck, coverity or eclair. The value is the
>   proprietary id corresponding on the finding, for example when coverity is
>   used as analyser, the tool will translate the Xen in-code coment in this way:
>   /* SAF-0-safe [...] \*/ -> /* coverity[coverity-id] \*/

In here, where would coverity-id come from? And how does the transformation
here match up with the value of the "coverity": field in the table?

>   if the object doesn't have a key-value, then the corresponding in-code
>   comment won't be translated.

Iirc at least Coverity ignores certain instances of what it might consider
violations (fall-through in switch() statements in particular) in case
_any_ comment is present. Therefore may I suggest that such comments be
deleted (really: replaced by a blank line, to maintain correct line
numbering) if there's no matching key-value pair?

> - name: a simple name for the finding
> - text: a proper justification to turn off the finding.

The distinction between the last two doesn't really become clear. Taking
your “Variable set but not used" example above: Such a "name" will fit
many cases, yet the justification for each might be different. Hence
the question is how unique "name" should be and - if it doesn't need to
be unique - what information it is intended to convey.

> Here an example of the usage of the in-code comment tags:
> 
> /* SAF-0-safe [eventual developer message that shall not exceeds line char max count, don’t break the line!] */
> #define string_param(_name, _var) \
>     __setup_str __setup_str_##_var[] = _name; \
>     __kparam __setup_##_var = \
>         { .name = __setup_str_##_var, \
>           .type = OPT_STR, \
>           .len = sizeof(_var), \
>           .par.var = &_var }
> 
> In the example above, the tool finding for this macro is suppressed. When there are multiple findings for
> the same line, multiple in-code comments needs to be inserted, every one on a different line.

Since this is about parenthesization, would

#define string_param(_name, _var) \
    __setup_str (__setup_str_##_var)[] = _name; \
    __kparam (__setup_##_var) = \
        { .name = (__setup_str_##_var), \
          .type = OPT_STR, \
          .len = sizeof(_var), \
          .par.var = &(_var) }

satisfy the tools? And wouldn't we better not mask detection on this
construct anyway, since the last of the uses of "_var" indeed does
violate the rule (without parentheses added)?

As to the placement of the label: It was repeatedly said that analysis
occurs on pre-processed sources. Is placing a label ahead of a macro
definition therefore going to have any effect at all? Wouldn't the thing
rather need to look like this (assuming a pre-processing mode is used
which retains comments and respects line splits despite the use of line
continuations in the macro definition):

#define string_param(_name, _var) \
    /* SAF-0-safe ... */ \
    __setup_str __setup_str_##_var[] = _name; \
    /* SAF-0-safe ... */ \
    __kparam __setup_##_var = \
        /* SAF-0-safe ... */ \
        { .name = __setup_str_##_var, \
          .type = OPT_STR, \
          .len = sizeof(_var), \
          .par.var = &(_var) }

Finally: Except for its mere mentioning, I didn't spot any word towards
multiple uses (in the sources) of a single label. To avoid long
discussions about whether a new tag is needed vs an existing one to be
re-used, the rules for this need to be as clear and obvious as possible.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 08:09:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 08:09:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421727.667305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oitHh-0001S5-3X; Thu, 13 Oct 2022 08:09:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421727.667305; Thu, 13 Oct 2022 08:09:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oitHh-0001Ry-0m; Thu, 13 Oct 2022 08:09:41 +0000
Received: by outflank-mailman (input) for mailman id 421727;
 Thu, 13 Oct 2022 08:09:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w3Eg=2O=citrix.com=prvs=2782ac179=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1oitHf-0001Rq-Ns
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 08:09:39 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5eff627d-4ace-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 10:09:35 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 04:09:32 -0400
Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by
 BLAPR03MB5474.namprd03.prod.outlook.com (2603:10b6:208:285::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 08:09:30 +0000
Received: from DM6PR03MB4172.namprd03.prod.outlook.com
 ([fe80::fef5:dc53:67d3:3498]) by DM6PR03MB4172.namprd03.prod.outlook.com
 ([fe80::fef5:dc53:67d3:3498%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 08:09:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5eff627d-4ace-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665648575;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=8Lodtgi2+evD3WbDutl8AkkNdWOS/Z/26nDlSKdciN4=;
  b=gb8msSM6sQaCdozTYkNRrU4zCdI1EP16KBEGc5DOE9lku9h9+l7+JQEO
   VYLh1B4mVdOTGwG0y/NMTmx5UyunIHnfTcEDpe9TVP/idxUwOGNcOWQSr
   /2yy8KPr1/JdGnmBL6n+zFvOQPG3eO1S5GDUf+ujUDRQY4vMYaD8/Ep81
   Q=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 82641324
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3Az42X+6CimYCSMBVWkefolCu1gh7EJpYLuyv04?=
 =?us-ascii?q?LjilXXVbZgPvEW2GDUMXjFqUIKe1WXHDttQOy/UMBlt8FzYagv8p5BLFtttQ?=
 =?us-ascii?q?SI+XzvexR355Il+lbzZkNAns2zVKXgEFEBi+gHxvlL2oxoe37FNuc7nW8h/4?=
 =?us-ascii?q?9hb+8tlzoQTc59gBha5l5fG5SehLr0aIfWB+0u35NDp7VMd/a3s3G+vI6FCJ?=
 =?us-ascii?q?+g1IqGYxtVmg9MREeieu/14rT2+A2EHKRxFvepusQjH9NaGu+0Lc2y+PZPji?=
 =?us-ascii?q?6g73XM6zLh9vrf10dffRozvjDkCZQEMwtZbAwWN0mjfIv75x9iAveTgewybT?=
 =?us-ascii?q?zZ9axOdsUVjNCJve+4Q5EYCi6qaVeIA62icYkWXxbZEHHBk+XObcKjYosopR?=
 =?us-ascii?q?Ze5Untf76F1Am9Uw97OE9mRheu2uCc0fIR5JyGUfQOmn/txmmoslnRfVEu4c?=
 =?us-ascii?q?FEVT5IGW3mFmuY36IlFDe3YSdxPtgzbXA3gmU4a4U7CHWKCDlvHgUGQ30Fbu?=
 =?us-ascii?q?CjFxlC54xJfRhBghLnAZaeQ2qQeY7YIllMFpTBJIFcfOgIzZSy5t2VKTGZnu?=
 =?us-ascii?q?8SsEsZAcKTgPrlzieNMaW6l1bhHXhTnDWGo3C/mVhRfIP8PTtJjZGPmR736m?=
 =?us-ascii?q?BkSSrliXKaNUJo/hGgE5LvXcGN47TBYQGxOAY0jtRtXkHSFNoEj8Sf4PpwOV?=
 =?us-ascii?q?MSHVsosSfgN9jUa60DoqeOYewSizEmc7qoZu3cZuhhjGvxy48N2OrUkspFou?=
 =?us-ascii?q?W982YJzyhqReR3+Zl7CyuMEBffnow34mFKPqF1LQXAgygS0cwmYiqdTeC31G?=
 =?us-ascii?q?UhpjurJuOOacI3Dl8BnIl24PrOAAfb7joN/AqH72sztQ8qd8aUt/ADIex22p?=
 =?us-ascii?q?dAfR2dA4N3BE07PhCw/Fvqaw//LEuV4Ip0bzrz/v9lKLNXfSSzJLOc1Mlggx?=
 =?us-ascii?q?Ehzuu44T6psy9LoETIXVICnAVHY+IEFs816mNpADEKW5/3Lqzrn8sCcZnyJV?=
 =?us-ascii?q?wqxrC3mw7rj8mCPHizYQ3Irx91SBoakfOsqWkzs0cQaS2SbrMA8nT/4+ofnc?=
 =?us-ascii?q?5/idlSqRA4K0MZqowIsglYBIUnNCidVwv+QwF3az4YsSF4f17iKIFszvwPsu?=
 =?us-ascii?q?BsXNdqAZE2viqhCNb8edSiGh4AC+957kRUDU/QmSNl85EIRLFoebFDg+b5n0?=
 =?us-ascii?q?eFa8DypCPjqvsV6IXIIgqOdox+9o2dBPZKsPMY5jnZXlYRAIjH2Yv7zYJjct?=
 =?us-ascii?q?WzapuCvw4Q05t8Xn4ohPRBV3ISj4VZwn0A13NybKGeqpQHqFQcl1juxBifgY?=
 =?us-ascii?q?iUE+F9Q+0zIVnwLCNOYf91yDRNAyyMKRrpDtBSly6ydbLrSgqX1tULcJ0tLL?=
 =?us-ascii?q?CqLPvHGw/yW+f175LHfX3tN1VVX+PL+tCi9t48ZZ3nccKX7CWgvbTan6PAz6?=
 =?us-ascii?q?EC/2S6A1OXZ21JyAtFDrN5ftCt3oj6xrwGDs971MclVjhZaM/c3p23gNVTDS?=
 =?us-ascii?q?8Q6JFRT60G/5wlxgvRq6Dl5XHPbiPvoEnM/LZmL66MJ6apOJF4EQJzgEENuB?=
 =?us-ascii?q?ilxrzI2ptlO/KiWBSj6tdIg2VSp6X7+4MSakJXQiCDtesrJ0FzAo0wjRP+ht?=
 =?us-ascii?q?aoX0a+iJ9V1tQ5RxYJQ9PZT64p9BtSIhEyYQpcHNcG1Aa4GAGSNRofGXGwTK?=
 =?us-ascii?q?p1fkNr6XYKMPzHNlcPXzqJBx0ZuTMmz88oLpIYR2VB727yMcFWZoWrPQN4ao?=
 =?us-ascii?q?byBVxm+CWowwuMuwKk+cyjNajOMYLwPqqaP4gS+AkvdI/j1z586VYX6yHUYd?=
 =?us-ascii?q?JhrW9/IokTVNUVeZNvtzLpCym1RfpYRPVvK/9kVVAYBgG32guVuKwyRtGaRZ?=
 =?us-ascii?q?aGCCLd+2JSw6T8YGUR91FEb+XR9IaIXkrm53EobaGYGq+mjrfLtIk1G60Iyy?=
 =?us-ascii?q?KETZKxWANX/qF2jDG1bdOpA3OA+uMkcgb3MU3Ya1b4TKY3NZahRHODvf3maY?=
 =?us-ascii?q?l4RTQY/XwuS4S+RJikPd+lDFr9rl/Pp7SCuph0lufdSgZwwBLnHU+yjTChrO?=
 =?us-ascii?q?tSQ+POto1Sx+Ni0atcCp1eMNGr/+vddJSiVsYoxbmSkJBjxbIp4m16KHgHET?=
 =?us-ascii?q?qIrxoKUq4JmmDT4lZVikgMwPSzP6GllBSk7j0fflCtYxSSKIN95VOjf9mfX3?=
 =?us-ascii?q?GvK6xHI+RZ+L3KC3m220nsG2ENunjTCMZKkTJWOhL1wU6rmWrvSQZKxmyucs?=
 =?us-ascii?q?PPHsZ8YdaFrbWBGRh9E9ukQoGIiB3lhl5Swyre4skm0ww07E6Oncn9HkNZr/?=
 =?us-ascii?q?AnBLdK2YqJ8RjgtNGejkwhMOsQUkN33dWD+jhf8RQwqlDO7q5LNlG28pv7sw?=
 =?us-ascii?q?CUdqq5nn+vn8tnpeaRwdOI4QLp11GmHOZ0fhPm98kbe8mTiczm2OnIRaee17?=
 =?us-ascii?q?HF2Upci7yLn9qSZViMYmLYe?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208,217";a="82641324"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GMQY47y+lgVM1Xny3YVJqYV3saUbKTKoXT/E+2ptMGQx2GS7brhR8S2yLdn6B81XVQ42CgxkIY3xswdT8ph27P2TyJRqXeord4BGaqJ4KH1CUQrS8DRMSHPXY5R2y3gMBMSuB4f7/1g1hJdFlJM2WRy4giQJjk+G33GM7USRKeSDbn+QWfGT6ULJuy3Zk1BOMD4J4d5mcjHoWk8G5BMk0zgBLzJNt2f7DY3zAfp+j3vJW90C0QnjAd38JhrgdXBNnIWDzgOkN/vRCPsJmGwqFqzu+yMmtcLKCd06mysXWyydiWlVzIhKzsjfkArvrqa9Vh8ZWO+hJS22pFVRrezhig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8Lodtgi2+evD3WbDutl8AkkNdWOS/Z/26nDlSKdciN4=;
 b=kqHYzUeJ5BXZ18U1Lz0K3qZdB3B0rCjCloFuyuuycW36jzBqAxKxjk85IpGk/xgOLVL98+6T8ZgAVJUnGoJISgPekQt1i/JMfi42lUWQRwyZDd1SohjAUwHX7rCUNW+y3pWKZtIJEZuHVwdEZSQn1GKUIjQ4fKDpdsbOVP+8mJ1g0el4toiEWpLHaA1g/NQvsG6lDQm8oUwQsbtWwiQC09kx+k4qwyxZJx12a0uQjhE4BTzuyzWZl1vNnGzCZq26xE8aPkdEHpuO7WaB1P8E7r4Xl6ndyyWP4wOP1n9uEqUW9UchJ7oD7vXsU5T/zJeKMMpp7GBazqio+/Gemajerw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8Lodtgi2+evD3WbDutl8AkkNdWOS/Z/26nDlSKdciN4=;
 b=hnJjaf3oaLPU4sH7xfSfTLbMFNwvD0/0ILqqtDNsurz3zphr3XA98bi6BK2qaz5rMb3K74UDimH/Qa0jJzplnpulFiJLRga5atEw1Oo3BKE0uJxfv7w/utx+BDObBxeVsKqnqx3xHVWxNhACaQQpj6fS/Y69DCpRLzaNG8qeXPc=
From: Christian Lindig <christian.lindig@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>,
	Edwin Torok <edvin.torok@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, Henry
 Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH for-4.17 0/2] Ocaml stub fixes
Thread-Topic: [PATCH for-4.17 0/2] Ocaml stub fixes
Thread-Index: AQHY3mgg1a/e5606O0qRvG/7p/Seyq4L+WuA
Date: Thu, 13 Oct 2022 08:09:30 +0000
Message-ID: <C88038C4-CF04-4122-BA4F-C8E515B7735C@citrix.com>
References: <20221012182552.26866-1-andrew.cooper3@citrix.com>
In-Reply-To: <20221012182552.26866-1-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|BLAPR03MB5474:EE_
x-ms-office365-filtering-correlation-id: e5811de3-cfdf-4c22-47fb-08daacf24123
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 G1HDxxa+n7mq90K9baQ8FM9uNw5wETHArImgkvpDGn0QPGeh/GadmAfnhY0XBXqBpBsKHmeXmDUQ3b/DxSKCWYG93q0kvlnRJ8Ewy1Fe3J8cDIlGDapJ0qD0Jvof2vsOct57GodJSr9JNYGUmUc1W7lkFwS718B30ZQrgW0DKhC7FwJR2EQNt2UZ57f2TOhOc3/QP/ZgsFNkveLZbsVbXSQh16j5raxYI/R3NdOp5G5kgw+LvbnUEKS+wpl3RjrbYcmMOWTygrUvWNX9Iftyk63yN7GKoW0HELd5GH4qbjEA+lEXEYE7DuYrj7zQ3NTNYra1JDHN0y8FkxeKNrkMA7bJ2HgBYk6+HaI436b0OFSryQjH/ocEbVxj+iUSkkUgUW1omFkd3gz1CdN9bbE3M/MR7B1Y/JovNBES6b5yfXKxN70pFzfM+nJWQ9MJGIL/1nky9TCNBzZyFxUKenxseUgwyQEXfmlQNOHJ8UDt7R+4/qpsE9oVfLQ91wtZZ/p+whCLbwJ0bLnMdCMFykR5jLjS8S7iJJ1sX9F1Vpa3d2gON7D2zJT5pR0SaJHLAO9DDvPRoeB3DJY5oV4NqX+HGRZWj1qfuH0xFGaSjxt2xCZHx7KPtmDG6z/QXW+9eE5FKrueQ8DNnteeIQ2q4TwfuQ/ib5yWuXc7JPg7FMWwj7eG+6IIBKVM9tiAFXduikxdI7gUOQmGTQbcVYdMb9n5Bmaua1HRmIVUekzgzm5EIrGKFy4hhDmrmtkdpURj38TgqHyu7j6pRzMFSskI14zDtNO5goNMrUIWksXNCXa67lQ=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199015)(4326008)(38070700005)(6486002)(71200400001)(37006003)(54906003)(82960400001)(478600001)(38100700002)(316002)(6636002)(186003)(66446008)(91956017)(66476007)(66946007)(66556008)(76116006)(64756008)(8676002)(122000001)(53546011)(4744005)(5660300002)(44832011)(33656002)(26005)(83380400001)(6506007)(36756003)(41300700001)(6862004)(8936002)(2616005)(2906002)(6512007)(86362001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cmVHN3RLKzFWWTlabWNaY3lYWWdYYllJMnFBeGJ4aGMvSEM1WUNibmNNVkpW?=
 =?utf-8?B?NzNnSDM2aUpDK2EyMkdZd0craVBDTGdjYjRWbFZ2VkNCbm1zMURab3hSSnlr?=
 =?utf-8?B?bnY1NSsyL1loMFVJREtkd2FNRU84QjZYOXFZajdYaXVxZnVzd0k5L29qVU9l?=
 =?utf-8?B?MTlqQ01KRXpyRFRWM2trSzVSdC9OWXRLNXU4V1VqREtMQ3dNd1paT2gzRGFy?=
 =?utf-8?B?NnZjU1pHMklpTTdRbzAwZjV4dXV4ZWsvV1E0UWNhQ2pROEZhV0RJQ3JtVmJY?=
 =?utf-8?B?eGtTamtRWWpHdy82VlBIWk51aXcwb1hHeGYrblkwMHdBZ0o5WWIyZnpKcFE1?=
 =?utf-8?B?a1dIbVpRWGs1Z1VMNkhVUXNMbkhNU1grejhrUTRSWnZQWXh6TjU1Ym9TTnNy?=
 =?utf-8?B?MC9rL25yV3JFWFBGK2gwdmlDTy9OU1VMaStFeUpocmxLeHJUQlg4clBKRSt6?=
 =?utf-8?B?V0xibEY4RHN2djRPYVpUVFUzL1RJcWRqNks5OVdzbHgyb0ZqaGhWUVp0QWY1?=
 =?utf-8?B?Zm5QaWFaNFBLR1BNSllDZ2E0SGs3a3I2b21qM1NvZ0Y2VFRpbCttNkQrMnlV?=
 =?utf-8?B?cDdmamtlYklxd2U3dFdLckZPNE1BQWJBNGNSeGs2WmhCdm5OMFhWelhtL0dO?=
 =?utf-8?B?TWxiTU80TzFGVmdGS2V4cEQ4VlpVeHJZMURNMkkxeFl5WWdDblpXZmluQXhx?=
 =?utf-8?B?bjVveXRlaW5naVJKY2FmNDIwYXI0S1F4Sm56SFovTEJLVjVRR0xaR2NBOGtr?=
 =?utf-8?B?TzVVc1hJZ21QQ0Ywc3E4OE91Y3JsYXhhb1ZzeXVVSzEzc1IwVjByZ25DUmJT?=
 =?utf-8?B?SVEwSjFIVHoyeXI5dUo0K0JIdWR2UUg2KzN0amRSZS9Gb25vR2p6Q1lSL3Ba?=
 =?utf-8?B?aWZDV1Z5N0dxU242eDlLbEp3V0pnUzF2OUc4SnlSejRLQ0pQVTh4MWxzWkFV?=
 =?utf-8?B?SFpuUUNoRHFiQnRsdkRDbzE4c29ld2RQY3lsVnFGa2kzNm5Kd0JtL0JzbEty?=
 =?utf-8?B?MGtCaUpnWjBMVnRnQUlDb0VkNk1pVVcxck5mV0UzUXdMSS9Fb1FmL1JBbWpw?=
 =?utf-8?B?Y2RKelZ4dVREUC9sRFR0VjhxVDdrczVqUWV6aEtlY2ZLMjgxbjdFN1paMnpH?=
 =?utf-8?B?cDRvU05DVkV6M01mdjJKbkdrcmFUVVc4YlpDSGVKbmhzNXpTK0ROZ21jZjQ4?=
 =?utf-8?B?d1VZKzB1TndSa3hpbUJKeG1rRzZCR091eGE0QzQ5OGRiUnV6d21NaDlmVFdJ?=
 =?utf-8?B?NWsyVklzMXBpUlFNL01rSWdPYVl0UDRMWTQ0N2FQQ01PNVIyR0VkSm5BZ2pw?=
 =?utf-8?B?UkFzZ0h1RHNkTGduQ0x0V1pBMWNZTzZHQ2pkUnl2R1hxQWdoakFnR05ZNHNU?=
 =?utf-8?B?eStlWU1QY2RHMkMrcDByUlFFWmxhK25mMFR3Ny9aTkp5SmdGbWhOTmNWUlQz?=
 =?utf-8?B?K2dTdzVjNTBBRHJkSHNxaGNkNFc1dUxqaW5xdndhRWlUVXdpRHpMYitYWmxC?=
 =?utf-8?B?NXNSZ2plMjRVUTBWK0tmZkx6RWdzYnc1cjgwVzdpOEU4c0JSZmZvVWJaRXNy?=
 =?utf-8?B?dm9meHk4blhzaFIxT2l5TDBXWG1ScnVKOEw3RmxMbmhiVG9DTnJDTmsyemNn?=
 =?utf-8?B?ekZxcHNWcDlFTDRxK1M5M0VSVTJVQnRBdGZsdWN2SWZsT0RSMHdsQTVuUGZU?=
 =?utf-8?B?TGF2Qk9QWm03aUtaMUZiYWtSSUNVWTVJLzRHSjgxWmZhVWJVeWhidno3SGlj?=
 =?utf-8?B?aGx6aitFRXhldHRrYTJHdFdRTVl5RzNhY2RaZU1PRFpPcXFETCtYVjRoNHpG?=
 =?utf-8?B?K3oxSUtOZXlaMzd0K3d4aHJ2ZXlUM0hvTnhCZWZqYTV4NzAzdndCRXJpRWsx?=
 =?utf-8?B?Si9xanQ4MlU3U0lPS0xKekJoRUFjZ2ZLN1FId0dhTzZiNHUvNk55NjhmcENk?=
 =?utf-8?B?WmpYU2oycTU2ZEgxUkZkMmU3c0dua21wR2dDN1FSYVVydCtkRFJkVjFrVlRn?=
 =?utf-8?B?MWNBcGtScTBNY2VsV1V5MWllOGVKM2xOcGtvL0x2eHhRcEgvWEJzK0ZjVVZV?=
 =?utf-8?B?K29iTnVNSzMrUWNkdjROcXRrNUY3djdpUHM0TGlobFBsVnVJaG1UOE1PUjJS?=
 =?utf-8?B?VjRWakxhYUVQNmdHcmRUZXhHaGxnZmtRVy9lTENHVWFTSjJrcnl5R0NyNXNO?=
 =?utf-8?Q?pBmn2Tjvs4kMi5MTMTOOfyk=3D?=
Content-Type: multipart/alternative;
	boundary="_000_C88038C4CF044122BA4FC8E515B7735Ccitrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5811de3-cfdf-4c22-47fb-08daacf24123
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 08:09:30.0615
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CN28ziKc3bgeFC15sFwFaK4tbF+tCJMRk9SNNUPkdMmIuxcJp6JgbAEUS22S9cj2OhvIEa/f1Hn7N73pkw5xzr/sEe1JZHU2lGzzTNunzWA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5474

--_000_C88038C4CF044122BA4FC8E515B7735Ccitrixcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

VGhpcyBpcyBhIGdvb2QgdXNlIG9mIHRoZSBPQ2FtbCB0eXBlIHN5c3RlbSB0byBlbnN1cmUgb25s
eSBjb21wYXRpYmxlIGZsYWdzIGFyZSBzaGFyZWQgaW4gYSBsaXN0IGFuZCBub3QgbWl4ZWQgYmV0
d2VlbiBhcmNoaXRlY3R1cmVzLiBUaGUgbWFjcm8gY2hhbmdlcyBhcmUgZ29vZCBob3VzZWtlZXBp
bmcuDQoNCuKAlCBDDQoNCkFja2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGlu
ZGlnQGNpdHJpeC5jb208bWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4+DQoNCg0K
T24gMTIgT2N0IDIwMjIsIGF0IDE5OjI1LCBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0Bj
aXRyaXguY29tPG1haWx0bzpBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPj4gd3JvdGU6DQoNClBh
dGNoIDEgaXMgcHVyZWx5IHNvbWUgYSB0d2VhayB0byBpbXByb3ZlIGxlZ2liaWxpdHkuICBJdCdz
IG5vdCBuZWNlc3NhcnkgZm9yDQo0LjE3IGJ1dCBpdCdzIGFsc28gMCByaXNrIHRvIHRha2UgYXMg
d2VsbC4NCg0KUGF0Y2ggMiBpcyBhIGNoYW5nZSB0byBhbiBBQkkgd2hpY2ggd2FzIG5ld2x5IGlu
dHJvZHVjZWQgaW4gNC4xNy4gIEl0IGlzDQpzdWJvcHRpbWFsIGZvciB0d28gcmVhc29ucyBhbmQg
c3BlY2lmaWNhbGx5IGRvZXMgd2FudCBjaGFuZ2luZyBiZWZvcmUgNC4xNw0Kc2hpcHMuICBTZWUg
cGF0Y2ggZm9yIGRldGFpbHMuDQoNCkFuZHJldyBDb29wZXIgKDIpOg0KIHRvb2xzL29jYW1sL3hj
OiBGaXggY29kZSBsZWdpYmlsaXR5IGluIHN0dWJfeGNfZG9tYWluX2NyZWF0ZSgpDQogdG9vbHMv
b2NhbWwveGM6IEFkZHJlc3MgQUJJIGlzc3VlcyB3aXRoIHBoeXNpbmZvIGFyY2ggZmxhZ3MNCg0K
dG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1sICAgICAgfCAxMCArKysrKystLS0tDQp0b29s
cy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpICAgICB8IDExICsrKysrKystLS0tDQp0b29scy9v
Y2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyB8IDI4ICsrKysrKysrKysrKysrLS0tLS0tLS0t
LS0tLS0NCjMgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0p
DQoNCi0tDQoyLjExLjANCg0KDQo=

--_000_C88038C4CF044122BA4FC8E515B7735Ccitrixcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <FA20C552991C7246A56013B9B5606770@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy
YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0
ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxkaXYgc3R5bGU9Im1hcmdpbjogMHB4OyBmb250
LXN0cmV0Y2g6IG5vcm1hbDsgZm9udC1zaXplOiAxMXB4OyBsaW5lLWhlaWdodDogbm9ybWFsOyBm
b250LWZhbWlseTogTWVubG87IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQt
bGlnYXR1cmVzOiBuby1jb21tb24tbGlnYXR1cmVzIiBjbGFzcz0iIj5UaGlzIGlzIGEgZ29vZCB1
c2Ugb2YgdGhlIE9DYW1sIHR5cGUgc3lzdGVtIHRvIGVuc3VyZSBvbmx5IGNvbXBhdGlibGUgZmxh
Z3MgYXJlIHNoYXJlZCBpbiBhIGxpc3QgYW5kIG5vdCBtaXhlZCBiZXR3ZWVuIGFyY2hpdGVjdHVy
ZXMuIFRoZSBtYWNybyBjaGFuZ2VzIGFyZSBnb29kIGhvdXNla2VlcGluZy48L3NwYW4+PC9kaXY+
DQo8ZGl2IHN0eWxlPSJtYXJnaW46IDBweDsgZm9udC1zdHJldGNoOiBub3JtYWw7IGZvbnQtc2l6
ZTogMTFweDsgbGluZS1oZWlnaHQ6IG5vcm1hbDsgZm9udC1mYW1pbHk6IE1lbmxvOyIgY2xhc3M9
IiI+DQo8c3BhbiBzdHlsZT0iZm9udC12YXJpYW50LWxpZ2F0dXJlczogbm8tY29tbW9uLWxpZ2F0
dXJlcyIgY2xhc3M9IiI+PGJyIGNsYXNzPSIiPg0KPC9zcGFuPjwvZGl2Pg0KPGRpdiBzdHlsZT0i
bWFyZ2luOiAwcHg7IGZvbnQtc3RyZXRjaDogbm9ybWFsOyBmb250LXNpemU6IDExcHg7IGxpbmUt
aGVpZ2h0OiBub3JtYWw7IGZvbnQtZmFtaWx5OiBNZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5
bGU9ImZvbnQtdmFyaWFudC1saWdhdHVyZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIi
PuKAlCBDPC9zcGFuPjwvZGl2Pg0KPGRpdiBzdHlsZT0ibWFyZ2luOiAwcHg7IGZvbnQtc3RyZXRj
aDogbm9ybWFsOyBmb250LXNpemU6IDExcHg7IGxpbmUtaGVpZ2h0OiBub3JtYWw7IGZvbnQtZmFt
aWx5OiBNZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImZvbnQtdmFyaWFudC1saWdhdHVy
ZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPjxiciBjbGFzcz0iIj4NCjwvc3Bhbj48
L2Rpdj4NCjxkaXYgc3R5bGU9Im1hcmdpbjogMHB4OyBmb250LXN0cmV0Y2g6IG5vcm1hbDsgZm9u
dC1zaXplOiAxMXB4OyBsaW5lLWhlaWdodDogbm9ybWFsOyBmb250LWZhbWlseTogTWVubG87IiBj
bGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVzOiBuby1jb21tb24t
bGlnYXR1cmVzIiBjbGFzcz0iIj5BY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyAmbHQ7PGEgaHJl
Zj0ibWFpbHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbSIgY2xhc3M9IiI+Y2hyaXN0aWFu
LmxpbmRpZ0BjaXRyaXguY29tPC9hPiZndDs8L3NwYW4+PC9kaXY+DQo8ZGl2IGNsYXNzPSIiPjxz
cGFuIHN0eWxlPSJmb250LXZhcmlhbnQtbGlnYXR1cmVzOiBuby1jb21tb24tbGlnYXR1cmVzIiBj
bGFzcz0iIj48YnIgY2xhc3M9IiI+DQo8L3NwYW4+PC9kaXY+DQo8ZGl2PjxiciBjbGFzcz0iIj4N
CjxibG9ja3F1b3RlIHR5cGU9ImNpdGUiIGNsYXNzPSIiPg0KPGRpdiBjbGFzcz0iIj5PbiAxMiBP
Y3QgMjAyMiwgYXQgMTk6MjUsIEFuZHJldyBDb29wZXIgJmx0OzxhIGhyZWY9Im1haWx0bzpBbmRy
ZXcuQ29vcGVyM0BjaXRyaXguY29tIiBjbGFzcz0iIj5BbmRyZXcuQ29vcGVyM0BjaXRyaXguY29t
PC9hPiZndDsgd3JvdGU6PC9kaXY+DQo8YnIgY2xhc3M9IkFwcGxlLWludGVyY2hhbmdlLW5ld2xp
bmUiPg0KPGRpdiBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9IiI+UGF0Y2ggMSBpcyBwdXJlbHkgc29t
ZSBhIHR3ZWFrIHRvIGltcHJvdmUgbGVnaWJpbGl0eS4gJm5ic3A7SXQncyBub3QgbmVjZXNzYXJ5
IGZvcjxiciBjbGFzcz0iIj4NCjQuMTcgYnV0IGl0J3MgYWxzbyAwIHJpc2sgdG8gdGFrZSBhcyB3
ZWxsLjxiciBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NClBhdGNoIDIgaXMgYSBjaGFuZ2UgdG8g
YW4gQUJJIHdoaWNoIHdhcyBuZXdseSBpbnRyb2R1Y2VkIGluIDQuMTcuICZuYnNwO0l0IGlzPGJy
IGNsYXNzPSIiPg0Kc3Vib3B0aW1hbCBmb3IgdHdvIHJlYXNvbnMgYW5kIHNwZWNpZmljYWxseSBk
b2VzIHdhbnQgY2hhbmdpbmcgYmVmb3JlIDQuMTc8YnIgY2xhc3M9IiI+DQpzaGlwcy4gJm5ic3A7
U2VlIHBhdGNoIGZvciBkZXRhaWxzLjxiciBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCkFuZHJl
dyBDb29wZXIgKDIpOjxiciBjbGFzcz0iIj4NCiZuYnNwO3Rvb2xzL29jYW1sL3hjOiBGaXggY29k
ZSBsZWdpYmlsaXR5IGluIHN0dWJfeGNfZG9tYWluX2NyZWF0ZSgpPGJyIGNsYXNzPSIiPg0KJm5i
c3A7dG9vbHMvb2NhbWwveGM6IEFkZHJlc3MgQUJJIGlzc3VlcyB3aXRoIHBoeXNpbmZvIGFyY2gg
ZmxhZ3M8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQp0b29scy9vY2FtbC9saWJzL3hjL3hl
bmN0cmwubWwgJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7fCAxMCArKysrKystLS0tPGJy
IGNsYXNzPSIiPg0KdG9vbHMvb2NhbWwvbGlicy94Yy94ZW5jdHJsLm1saSAmbmJzcDsmbmJzcDsm
bmJzcDsmbmJzcDt8IDExICsrKysrKystLS0tPGJyIGNsYXNzPSIiPg0KdG9vbHMvb2NhbWwvbGli
cy94Yy94ZW5jdHJsX3N0dWJzLmMgfCAyOCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tPGJy
IGNsYXNzPSIiPg0KMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlv
bnMoLSk8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQotLSA8YnIgY2xhc3M9IiI+DQoyLjEx
LjA8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9IiI+DQo8L2Rpdj4NCjwvZGl2Pg0KPC9ibG9ja3F1
b3RlPg0KPC9kaXY+DQo8YnIgY2xhc3M9IiI+DQo8L2JvZHk+DQo8L2h0bWw+DQo=

--_000_C88038C4CF044122BA4FC8E515B7735Ccitrixcom_--


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 08:38:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 08:38:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421748.667335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oitjj-000568-It; Thu, 13 Oct 2022 08:38:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421748.667335; Thu, 13 Oct 2022 08:38:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oitjj-000561-G6; Thu, 13 Oct 2022 08:38:39 +0000
Received: by outflank-mailman (input) for mailman id 421748;
 Thu, 13 Oct 2022 08:38:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oitji-00055u-87
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 08:38:38 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6cc26f86-4ad2-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 10:38:35 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DD9415A1;
 Thu, 13 Oct 2022 01:38:41 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1B1D23F67D;
 Thu, 13 Oct 2022 01:38:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cc26f86-4ad2-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Date: Thu, 13 Oct 2022 08:38:18 +0000
Message-Id: <20221013083818.36209-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
and keep a buffer, populate 16 pages as the default value to the P2M
pages pool in arch_domain_create() at the domain creation stage to
satisfy the GICv2 requirement.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
This should also be backported to 4.13, 4.14, 4.15 and 4.16.
---
 xen/arch/arm/domain.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2c84e6dbbb..e40e2bcba1 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
         BUG();
     }
 
+    spin_lock(&d->arch.paging.lock);
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     */
+    if ( (rc = p2m_set_allocation(d, 16, NULL)) != 0 )
+    {
+        p2m_set_allocation(d, 0, NULL);
+        spin_unlock(&d->arch.paging.lock);
+        goto fail;
+    }
+    spin_unlock(&d->arch.paging.lock);
+
     if ( (rc = domain_vgic_register(d, &count)) != 0 )
         goto fail;
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 08:44:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 08:44:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421756.667349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oitou-0006WB-5r; Thu, 13 Oct 2022 08:44:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421756.667349; Thu, 13 Oct 2022 08:44:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oitou-0006W4-34; Thu, 13 Oct 2022 08:44:00 +0000
Received: by outflank-mailman (input) for mailman id 421756;
 Thu, 13 Oct 2022 08:43:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oitos-0006Vy-3j
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 08:43:58 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c5fe3c1-4ad3-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 10:43:56 +0200 (CEST)
Received: from FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::6) by
 PAXPR08MB6653.eurprd08.prod.outlook.com (2603:10a6:102:15f::9) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.26; Thu, 13 Oct 2022 08:43:54 +0000
Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1c:cafe::b5) by FR3P281CA0019.outlook.office365.com
 (2603:10a6:d10:1c::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.6 via Frontend
 Transport; Thu, 13 Oct 2022 08:43:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 08:43:53 +0000
Received: ("Tessian outbound c2c2da38ad67:v128");
 Thu, 13 Oct 2022 08:43:53 +0000
Received: from e0bd9f0fd5e1.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 88D87D27-D322-4EBF-B3AB-E1830405D5A9.1; 
 Thu, 13 Oct 2022 08:43:47 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e0bd9f0fd5e1.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 08:43:47 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM8PR08MB5825.eurprd08.prod.outlook.com (2603:10a6:20b:1d6::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 08:43:45 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 08:43:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c5fe3c1-4ad3-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=iLOzuANRGKzMj/yQopKrZqQcZvBBpMHED6vDx/JMq7YA7dYduKZAQTaCPLTYpaRkG7lE7iZSoulF7AKha5T/NDnhEuJFTDdKrho5zPUhliti0qDt4K+ax7Gaf7YSJgVoF66RTtLQv5gtfYaPim4tLGkXATx2EEhsDA6C5iixH76Cm8m6L0HUmOQmijVUXHasANSoUZ+vmIHwGmhHE2u3s+aCpjf4/tUMKicjBWrnaOO+bdGEO+b5ohSbyaw11rsqcxOGDsmGwLlJNNgbY/CiXJzbOjVfTtTi4PVH7LTlXNGlE23aywNWUtm0anKzLKsDOT1yrlECOgUjhJ8uMHPCXQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=72qxzXZ5v/aB6gik4lK8c7wqzTbAVYb4n6jBP7DEARs=;
 b=IbCfDmiDxKHLQDAUZAtDu9dPq6LSn0ieHW0TJr9oTBVwJhrrRjI0ROUMTbRjGuX3cyhW1skdmova/dUhwwLX6Zehn1MqLuugHp3ypIYbZdCLzaQdz6rCmiJ9tXyNv4SmnOv7uMHK85ISr5Z4zSVvAnUEAKe1uAI9Qdwrr6mul/3zXP/gW4n2MpX9WTn7uOWnSHrkJvkfyw/VwCjAMmi+Zuxm60q0NQMJQjM493wq/BN6TKQ/PS+rc0/WRV6BmxxCGqK6Mr1UrtWL9HjzlogsFoAx0XgKsqKUuqEWGMp1pX4E6zRPPZ8Okif9zj+0FBFYKcLV/xtKkNgxCTmai/oJmQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=72qxzXZ5v/aB6gik4lK8c7wqzTbAVYb4n6jBP7DEARs=;
 b=SdL23j303JC2ceiOJIwpCrflucEF32b5DMH9ilALXYGKwtKubEgKc942n3UGFNrLBR8ZtcrCYJqg4hzOXx/EPhRbC4+ys1lnn+8FqrFK2d/hpmsEIXCVdM6dfWsJbsIL9XIOsdz0H+mDVwgHBpHgPgApfm55TFUqCRwyYfE+tKg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MSOYBSk5NdqWw3Ujv+sTKb1ot51QHwoBXfLeNWOIsaTM6/3gmW9YmJJd9Yzdr+wzzYpPKQ33Wjl78+oIwYhfqheGjLTFfgPmMNFmR0tSRtVdoPNy8ZSxfKIR50YmybJC7UZFS+Uq3bfOEWXNZZJBsQjn9WZQgeMXGfs88uTgv44A3y6DME86QljdFsl/ZQdTDzN7eijH0i+YnLPk9xeZxWqaDrdDlIiDV3OJ6kMsYUNpW1ws9eJK9KPFRplhHbK1Nh1UsNRMSi8ImjlcvVPKxPeLMHOAZ7Llz+gRI++33b7FykgUoRow2bXN7ZRsVE1Vg+gNzrElq7DMLOD2SiLEOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=72qxzXZ5v/aB6gik4lK8c7wqzTbAVYb4n6jBP7DEARs=;
 b=ZYYyKpZlJgKIVnCw/lUR75RmDxEngZU4J0+VL2IUO/6SM9s95nyFCKb0XCFMhPeaLL4b5Q0YmRuzObihaZC6Fxz2gk+fN3t5Tp3f3D4jA4ou9ZHh3CUI63tZP+B4AkANvO5udgtHZd7K7huy/F9JtuR9cTK/qJIlEpMha5gJCcItyG1vLsC5K6+ctGE40zvbIlh2tvAYDpdcOXnZaZEiC6kT1YzJ2K+B5eWnK3/WVINUOZXZ6lOjMFToqDnnOs9Ow3Hk/uo5glp+rp3PmRc+ZRNSasuK+dfYNCjTZ4YKn30Xze5rDi6+teN6RBnKD2EMW39j2Bc51F+uLQiHuoh2Uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=72qxzXZ5v/aB6gik4lK8c7wqzTbAVYb4n6jBP7DEARs=;
 b=SdL23j303JC2ceiOJIwpCrflucEF32b5DMH9ilALXYGKwtKubEgKc942n3UGFNrLBR8ZtcrCYJqg4hzOXx/EPhRbC4+ys1lnn+8FqrFK2d/hpmsEIXCVdM6dfWsJbsIL9XIOsdz0H+mDVwgHBpHgPgApfm55TFUqCRwyYfE+tKg=
From: Henry Wang <Henry.Wang@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
	<rosbrookn@gmail.com>, Wei Liu <wl@xen.org>
Subject: RE: [XEN PATCH v4 32/32] tools/golang/xenlight: Rework gengotypes.py
 and generation of *.gen.go
Thread-Topic: [XEN PATCH v4 32/32] tools/golang/xenlight: Rework gengotypes.py
 and generation of *.gen.go
Thread-Index: AQHYraPN+b7hfd/pvkWBASbwKELmZ64MZAOA
Date: Thu, 13 Oct 2022 08:43:44 +0000
Message-ID:
 <AS8PR08MB799164CA74689972AE96D42792259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20220811164845.38083-1-anthony.perard@citrix.com>
 <20220811164845.38083-33-anthony.perard@citrix.com>
In-Reply-To: <20220811164845.38083-33-anthony.perard@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 9DBD07C18E1CE04F9B77BD2EBEDE302E.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM8PR08MB5825:EE_|VE1EUR03FT064:EE_|PAXPR08MB6653:EE_
X-MS-Office365-Filtering-Correlation-Id: 4739c56d-fe2c-4745-3d36-08daacf70f45
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 t8b60qTlB3Ch4UD6zpSsv5AZ8mScgM/h0TnRFsB4GeYSoF0Ng3tL1bBLNKwz+rEWlS5gWu9e66ZMn6G4YVAEGkN+GUptt8wAkWmqdxuoeXgcCujV6KtYQznuKe8vMqNzimBNDqCLHQ0HYrVnAvbb1u4wbkgKVB/1ySkbf4KuElAa7TLkPsMP11uLAT8gfxUNYeXXMtmVJ4/qky4wONKbn56QPPFbOqPUtqfQ5CoTtHNLIL7F4YuIkmkHETfRKodO9jpqyknZxT0FitDhSt9HM+hIq0ZkXbtodY2GhL07nBxneA9xY8Rm1dUsSUGc15VBmG3m/KEQo8GjL7pNvI1jK15MhjaxlFmVEeiyXD79m0U3qmUlnhk0s2ND1PTn5CtPcYtL+jeMa2zTL5uRkg+mNMrVdPM8CRMIrVb7OiYB5dfmGGFGSR2Yd3TUvQBhkKpvM0zu+CKETiQo+G5Mv/jAdFldIgWJk4fSF2p3k7jnhX/qwAwtNwhguw4LEGgiQbjfOAF9Kv5VRn6DFY4gsPMLGhKOofJevhL1JWLHw1L+qzB6wkIGk1TNan/jNVCEUgi46faYtaxriKp39YD4NBNwc0OkqCLxU6Vy/ZOSJ60Bjivf6LhiNoHARqDaUNa18d/TMIxBnAClPS6JlzPc45pG9MlCDqD89bTLLrYssGmtwks/gfofsr0OzFZKDl9Kb6uWFC4TcHY9dk2qRkqoH0e7qUpDb3duVnqS/XLi+dQd3MCcGe9fUqLjreMAAWwUMSnOOU4iISD+kLp3467dnarSkg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(451199015)(38070700005)(71200400001)(54906003)(110136005)(316002)(478600001)(186003)(38100700002)(66556008)(76116006)(66476007)(66946007)(66446008)(122000001)(64756008)(8676002)(4326008)(55016003)(7696005)(5660300002)(26005)(41300700001)(6506007)(33656002)(4744005)(52536014)(8936002)(9686003)(83380400001)(2906002)(86362001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5825
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3d7961d9-767d-42a4-a359-08daacf709e9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wNKHCkcD76FA5k99gnkuSCn+6x3FD/+1Y+k+XAUapN3B23VJ2lZb/DRx5PKD42GD40py1ujkTchUSvoIC3qWa7GTNRHeB73b4/WYBB5iC5H6Rm/C9z/Iq25ruve0Qy4+3OKwHoqdZOmyOfF5V2OV9xmkC8Owpg1oo9iFDuLAAZZhI334LA668LA2YOjY0J5NdDSz2AScZVwCLPog0i511x6s97qAoiDSG8kb/H+bLir2f54wLg/x0EHzRhL+I2fFjZ1gnMnlnqnkjH0ua2LTjlZeytIE537stXU/XpQsWEieao6piSIU2xK0hRyFscg5Uj2664BhR4yLH1UgMwBJogJZEuLcqp7/8VVGCsPihXd/Gk7itQgErtJbmMyL1D2FQNGZxKLiRFIyhQHMFS6muiD4CAif1maZvaj/0Yn0AdF1eoKgBYyGLr1cWfo6g1snZGVGTDDBJmrhzUQOsifiUHehhuO9cFJP+DU+Fp1QTQBQabadEUnjZV0oO/1s5AwYcKL0Hq2ZIyAX7T+7R6eEfRPddedRz1EZ3Ictc1jEFtcbBw/stNOtM7xLmp+K5qg6kEVwvafHJ8+7Y4b7M5+uw0LP9hmfLsXA1/LXBOC46soRux2VwId6hqtl98o62pFoZ0VBlvyJpQrfqjffKzTkwsjtyuD7EuGtxMfBywA1rTyjjlJbfUk7BgaShAafk24aZJdG6ohGs9DzD6/0eTUVZpLX6kwfXMaknKN+8t2hZjnxkIXIKZFQNckMoH7qM57P7TAorN4geinRSQqC35CU6g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(40480700001)(186003)(336012)(9686003)(26005)(55016003)(2906002)(82740400003)(52536014)(316002)(33656002)(110136005)(8936002)(54906003)(41300700001)(8676002)(4326008)(70586007)(70206006)(86362001)(81166007)(356005)(7696005)(6506007)(82310400005)(478600001)(5660300002)(40460700003)(4744005)(36860700001)(47076005)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 08:43:53.8259
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4739c56d-fe2c-4745-3d36-08daacf70f45
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6653

Hi Anthony,

> -----Original Message-----
> Subject: [XEN PATCH v4 32/32] tools/golang/xenlight: Rework gengotypes.py
> and generation of *.gen.go
>=20
> gengotypes.py creates both "types.gen.go" and "helpers.gen.go", but
> make can start gengotypes.py twice. Rework the rules so that
> gengotypes.py is executed only once.
>=20
> Also, add the ability to provide a path to tell gengotypes.py where to
> put the files. This doesn't matter yet but it will when for example
> the script will be run from tools/ to generate the targets.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

IIUC this is a fix for the occasionally failure in gitlab CI, so:
Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 08:56:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 08:56:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421767.667372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiu0J-0008ID-H6; Thu, 13 Oct 2022 08:55:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421767.667372; Thu, 13 Oct 2022 08:55:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiu0J-0008I6-DS; Thu, 13 Oct 2022 08:55:47 +0000
Received: by outflank-mailman (input) for mailman id 421767;
 Thu, 13 Oct 2022 08:55:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiu0I-0008Hh-H4
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 08:55:46 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2739a3e-4ad4-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 10:55:44 +0200 (CEST)
Received: from DB8PR06CA0014.eurprd06.prod.outlook.com (2603:10a6:10:100::27)
 by AS4PR08MB8072.eurprd08.prod.outlook.com (2603:10a6:20b:58b::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 08:55:42 +0000
Received: from DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:100:cafe::28) by DB8PR06CA0014.outlook.office365.com
 (2603:10a6:10:100::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Thu, 13 Oct 2022 08:55:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT063.mail.protection.outlook.com (100.127.142.255) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 08:55:42 +0000
Received: ("Tessian outbound 99ee3885c6d5:v128");
 Thu, 13 Oct 2022 08:55:42 +0000
Received: from bde6d727145e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AF626BD7-A0BE-4072-977C-E402D8BDA9A9.1; 
 Thu, 13 Oct 2022 08:55:35 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bde6d727145e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 08:55:35 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB8160.eurprd08.prod.outlook.com (2603:10a6:20b:561::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.22; Thu, 13 Oct
 2022 08:55:33 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 08:55:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2739a3e-4ad4-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=kPunFIc2QdTUBDoA+ZVsO1Ail0pG8uptUwwP4/CD0Fiwb0n14FoPHsSj2hgKD2NXx7G3CPXby71Mf7tv4w82QZe5M/QktTLVdMklHNhNhnd49BNYJ7Y9gb3wnvtgbtZHWnma6pY/tbPfKscM+LcfrvoUfUhQRY3Isrii2gLbBOzoRc3cfgaQujL5iIVr+TU2qwG7uoeylhC/iOYgV9M19EwGnIhKCcSnt/CEpUyNqv3Oh2ShvHjszLqoQA10aRndRkQ6TFGcrgipvENw/MNRqI8arcfbmYcR/ea0HpeoXjIcAKPxKZl/SFn5E/4QhK8xE/sP7LbHBqJwQdN2VNqQ9A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=udxGqpiBrSXCbidG3f6nKXeFLhYrO410/IowZ/QFxCw=;
 b=QTHAUEN8wIpnfEoD69SE9O3EekEA783Z0c9XbinbHb9SsOEVpgmxpnnJ9/+bV3Mku0+oX8uDi967OL/a9mdTQLxflSDDYjApQWyR2+gTiTYQYF+jwsA7WATTM0UdQHiNKpg+PyDk0jW1lxyOK4HT+JFQLcKaTF46inANNmzHNHz2Fex3n83CrFmZefr0TvYw0oM1R84i8lR4zLZ9cbVzMOwcmkcyPMYJLx7lc5SbjNnHyU7S9SZYSJhDinabb2GUs2xzXVe1gaQaEs/q/+KP9WpVr4IOeUe5lGlhT351TyyUsufOIuvGxgCHJKIlNM1j94jQjj1uThdOunDv5NH/eA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=udxGqpiBrSXCbidG3f6nKXeFLhYrO410/IowZ/QFxCw=;
 b=SH6bWuM6KO/hmEvIorFPpbXuOzWfBBUQT2Htkt1dek+gmQHnxDyk+DFZLT5I71iyC/yBQ7kl4Yk/DmmDjNHqLy339S35Ql9OwqTHwKjtihn77ndrfIJMM001PYp+GAmkDEMKfOsXMCsTI3NoyVRTl0a2cbyDuuHqQK9h2t+BE0M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EHAqkdZA5Lm47D8bSxiCrp4YDLOj0UACzK9Payn9HJCGy6/cET8oVgg5yEqbWMOoGnOeZ8nG9YntTv8JsjtEEWd1TyqqTLoecJraOd9m2djeUiku6zcyMUOrNwxe2ObuC9QefZ7/lXu9LbrunnLUIgok/4qmtpC2EaUmPCvc+kBh2bBqHFmxODYCYihyXVwwB9qkjyeRrO1ISwK5wqbXN4vn57t6XAo2E6YOLfFrmGz7ykWxgTNhD9xI7Nu63NWljaPt3oKLjZamHFwNXxdZp91I2+Fwx7bDlqR+YQxSnD/xB7oQ3KB61XiVuvKY//ABwN1gI6NFRlmBr+zRFpWmdQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=udxGqpiBrSXCbidG3f6nKXeFLhYrO410/IowZ/QFxCw=;
 b=ggvaCQqMI4Lamfxzp0bq6TGHledWnicJot0keRZ89dbC4GbKSfa2Sa1B5J4K3DZDsEUiH4+kbbZSxcuZMVsEvKhWzkkZuRc6MabmilC+vFv//uoL9G7EB5LQa5adFKEYAILD6L+wlhb1d8lvIDWvSK17jb7T8X7gn7Bnjs3NaKEKwbu393MxKt4Pp2g/rZbPM6Ms1E/Bdei+Zo24+/ekpd2wSruCkc6Od8M/Y9aIZMd8cBDXNktU2PuWDVyVSOfwNl/gskT97SWc/qHVOuIzPaOsZBuHYhvwzRn6CioR0s+MMr444jDOP8kxVk0NNTC70M0Lw8oZ/+Tb3W22RjpT4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=udxGqpiBrSXCbidG3f6nKXeFLhYrO410/IowZ/QFxCw=;
 b=SH6bWuM6KO/hmEvIorFPpbXuOzWfBBUQT2Htkt1dek+gmQHnxDyk+DFZLT5I71iyC/yBQ7kl4Yk/DmmDjNHqLy339S35Ql9OwqTHwKjtihn77ndrfIJMM001PYp+GAmkDEMKfOsXMCsTI3NoyVRTl0a2cbyDuuHqQK9h2t+BE0M=
From: Henry Wang <Henry.Wang@arm.com>
To: Christopher Clark <christopher.w.clark@gmail.com>,
	"christopher.clark@starlab.io" <christopher.clark@starlab.io>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Jason
 Andryuk <jandryuk@gmail.com>
Subject: Ping: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Topic: Ping: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Index: AQHY2oOIAk0kP8Ly4EylVwyMRp/g6q4DWdEAgABVmDCABXKqgIAC6/6Q
Date: Thu, 13 Oct 2022 08:55:33 +0000
Message-ID:
 <AS8PR08MB7991BCBC2BDFE841FDB9D86B92259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221007193124.20322-1-jandryuk@gmail.com>
 <a4524dcc-36ce-267a-afbd-5785eab73882@citrix.com>
 <AS8PR08MB7991432FC3C0643161277930925E9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <CAKf6xpt3LL3tLMEQkxivqVCw-kQhLnZBfjO=kFvim9NwamNkDQ@mail.gmail.com>
In-Reply-To:
 <CAKf6xpt3LL3tLMEQkxivqVCw-kQhLnZBfjO=kFvim9NwamNkDQ@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 445B5E69966C4E469CACB39D6B78C6FD.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB8160:EE_|DBAEUR03FT063:EE_|AS4PR08MB8072:EE_
X-MS-Office365-Filtering-Correlation-Id: 1a6f4d3b-a264-4d48-c70d-08daacf8b56f
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8kO8W6XTkYVBdmJFNHTZRfojbfYXLMWt/+VvXT6xu7c0ZBKdtI26VykjYGV2HHu/IFI/BEjfWVmwXizSLy1yMVeMOg+B/79nEs5w7bWZwFKykgNExrrR+BDEUGUfSOq7ED/hYAouE4n6/OBaqKWXYKdEldPVJeQRgivJdsmKgR8+SONzeLOnYTrgoI+0msMqmLECBEp1YZUHWZMmnVPOJOEb9S7TdAIh8IGKzCsfwyBBm1sqZsFC8Ra1NpQs0LfvCt0/Q+sW1H0kzvGes0saiX+MF+KGdaICQlTFY/6+4T2yZ/VO8JOwBnxvnofByQa0GYkWiWYyMjpgDppKf2J/EmcBd/donHBKLZqQvK6c725SPLWZEuUwOwkVjLJyJd+MKro5FRrW+JAzR8lFyVghmWPPZp6ppL/QcROyrGuhu2fy8T9ODw+Ys7CPung1r7vCby6FwLMfoxS1/Auc5yelixl8bH5Rrk7CVLUZRprawqVZ0S0ROWVVAgw8+jEo5vqi80WvDj53x6a7WHZITTuH75WGW5km06vLN1XFw8Zh/j8ssYMg654/H98zZ8C9BVLTjIi9Ppu+AF0XNDzcOATaq926EkGIyp7lvh/1OdU4ByJDAKAQ73rLD2fXHuK0Iu15W8m77o4NK1GPBpkH3bQH9RHW6L2maNySVMVp6Q5KoILG6mT1HPfMJ/c9y8y0HIhUcuWmYvDXvFfQGGc43Jqsnwrh8lW1LMJG1jw4aZHLQKj/zzzPqg+BnUaUiey2XZB8tzKmZnrkbgcD5g/llEHk3g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199015)(86362001)(33656002)(2906002)(8936002)(38070700005)(5660300002)(52536014)(186003)(83380400001)(478600001)(54906003)(110136005)(7696005)(71200400001)(9686003)(26005)(66946007)(6506007)(53546011)(122000001)(4326008)(66476007)(66446008)(66556008)(8676002)(76116006)(64756008)(55016003)(38100700002)(41300700001)(316002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8160
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ef2f0800-e2a9-4beb-a1d9-08daacf8b039
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u9/bUmoxfBpUSiJhaOv2Spzb2YuFWZd0s8Hhw8ZWWelh3+y3bZQdXj02DjHCwUy9QX5UsOjb3TeUyJeVORUfCePlHznQoMJFYqFjXTwnVY2Zj94Gnlf4V4+bzpwHik+gNizfn91FVnSPsl5gd/UqNh1miwq/tPoDpqVRNnTz8uKEm6d4dAh1+pHzpg2ab2bps33BO2VKcW0wP15c5sBnQvyLDdpEZks7KgKlQMaJmSRzsAk1Hcg6Jt5B4H8EGojVt8BAkZlJiCtvuO26d7Yoo63K4d1PUbxiPQqZ87N7knY1IoX+XbRsQD8ZWMZz1Lcbw1utsd4y2nSQVKK3I04Y7Z0Ag+Xk0iEBDoyzJPzUi0IHvDa4s7wO84aGXxRg9n9gci6v6j0AyfvMX36SgHE02LQhKOh373/eT4obuIxSpcCTYuWRWMuzDAvuVFdNt1dCDE6cMDKxhAS2LBWDPaS1gheGR8RFjyrtdol+9Oa68jyCN5yPrfZY4ImWFrkEjHUljn9bVSdci++bZ+sDvT3ZRixSLyYSI8qHWGelUBMf7Ww93+61WLbcfUMCZGdhpQH85GX4k8UFxrXJ0XsB4sryabYh01PZBwH8C3teS7K8zzv55203cfpTzmeLc/f5xhE5zHjKaHCM8cUMPrvgCJtWxBrwrNV4gvWm15W5kHe9HHj0Ejs8eBGHvGiKHERfkmlhsx5HoNgChglCOApgx3QyT1KxrBpcmg231s5Spe0kuPdv0EU50Tqj5jbizJc6uabCAzJUC9XrAzZrTuImLuOe5w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(46966006)(36840700001)(40470700004)(82310400005)(81166007)(356005)(54906003)(110136005)(478600001)(316002)(82740400003)(186003)(336012)(70586007)(70206006)(8676002)(4326008)(107886003)(55016003)(6506007)(5660300002)(26005)(7696005)(53546011)(41300700001)(33656002)(8936002)(40480700001)(52536014)(9686003)(36860700001)(83380400001)(40460700003)(2906002)(86362001)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 08:55:42.2058
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a6f4d3b-a264-4d48-c70d-08daacf8b56f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB8072

SGkgQ2hyaXN0b3BoZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTog
SmFzb24gQW5kcnl1ayA8amFuZHJ5dWtAZ21haWwuY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENI
XSBhcmdvOiBSZW1vdmUgcmVhY2hhYmxlIEFTU0VSVF9VTlJFQUNIQUJMRQ0KPiANCj4gT24gRnJp
LCBPY3QgNywgMjAyMiBhdCA5OjEyIFBNIEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4g
d3JvdGU6DQo+ID4NCj4gPiBIaSBBbmRyZXcgYW5kIEphc29uLA0KPiA+DQo+ID4gPiAtLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogQW5kcmV3IENvb3BlciA8QW5kcmV3LkNv
b3BlcjNAY2l0cml4LmNvbT4NCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGFyZ286IFJlbW92
ZSByZWFjaGFibGUgQVNTRVJUX1VOUkVBQ0hBQkxFDQo+ID4gPg0KPiA+ID4gT24gMDcvMTAvMjAy
MiAyMDozMSwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gPiA+ID4gSSBvYnNlcnZlZCB0aGlzIEFT
U0VSVF9VTlJFQUNIQUJMRSBpbiBwYXJ0bmVyX3JpbmdzX3JlbW92ZQ0KPiA+ID4gY29uc2lzdGVu
dGx5DQo+ID4gPiA+IHRyaXAuICBJdCB3YXMgaW4gT3BlblhUIHdpdGggdGhlIHZpcHRhYmxlcyBw
YXRjaCBhcHBsaWVkLg0KPiA+ID4gPg0KPiA+ID4gPiBkb20xMCBzaHV0cyBkb3duLg0KPiA+ID4g
PiBkb203IGlzIFJFSkVDVEVEIHNlbmRpbmcgdG8gZG9tMTAuDQo+ID4gPiA+IGRvbTcgc2h1dHMg
ZG93biBhbmQgdGhpcyBBU1NFUlQgdHJpcHMgZm9yIGRvbTEwLg0KPiANCj4gZG9tNyB1c2VkIGEg
d2lsZGNhcmQgcmluZywgYW5kIGRvbTEwIGNvbm5lY3RlZCB0byBpdCB3aXRoIGEgKGRyaXZlcg0K
PiBsZXZlbCkgc3RyZWFtIHNvY2tldC4NCj4gDQo+ID4gPiA+IFRoZSBhcmdvX3NlbmRfaW5mbyBo
YXMgYSBkb21pZCwgYnV0IHRoZXJlIGlzIG5vIHJlZmNvdW50IHRha2VuIG9uDQo+ID4gPiA+IHRo
ZSBkb21haW4uICBUaGVyZWZvcmUgaXQncyBub3QgYXBwcm9wcmlhdGUgdG8gQVNTRVJUIHRoYXQg
dGhlIGRvbWFpbg0KPiA+ID4gPiBjYW4gYmUgbG9va2VkIHVwIHZpYSBkb21pZC4gIFJlcGxhY2Ug
d2l0aCBhIGRlYnVnIG1lc3NhZ2UuDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEph
c29uIEFuZHJ5dWsgPGphbmRyeXVrQGdtYWlsLmNvbT4NCj4gPiA+DQo+ID4gPiBXZSdyZSBpbnRv
IHRoZSA0LjE3IHJlbGVhc2UgcHJvY2VzcyBub3cuICBBIGJ1Z2ZpeCBsaWtlIHRoaXMgb2J2aW91
c2x5DQo+ID4gPiBzaG91bGQgYmUgY29uc2lkZXJlZCwgYnV0IHdpbGwgbmVlZCBhcHByb3ZhbCBm
cm9tIHRoZSByZWxlYXNlIG1hbmFnZXIuDQo+ID4gPiBDQyBIZW5yeS4NCj4gDQo+IFRoYW5rcywg
QW5kcmV3Lg0KPiANCj4gPiBBbmRyZXc6IFRoYW5rcyBmb3IgdGhlIGluZm9ybWF0aW9uIQ0KPiA+
DQo+ID4gSmFzb246IFdvdWxkIHlvdSBtaW5kIGFkZGluZyBhICJGaXhlczoiIHRhZyBmb2xsb3dp
bmcgdGhlIHJ1bGUgZGVzY3JpYmVkDQo+ID4gaW4gWzFdPyBUaGFua3MgdmVyeSBtdWNoISBXaXRo
IHRoaXMgdGFnIGFuZCBwcm9wZXIgcmV2aWV3L2FjayBmcm9tDQo+ID4gbWFpbnRhaW5lcnM6DQo+
IA0KPiBPZiBjb3Vyc2UuICBJdCB3b3VsZCBiZToNCj4gRml4ZXM6IDgyYTgxNzMwN2M1YiAiYXJn
bzogaW5pdCwgZGVzdHJveSBhbmQgc29mdC1yZXNldCwgd2l0aCBlbmFibGUNCj4gY29tbWFuZCBs
aW5lIG9wdCINCj4gDQo+ID4gUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2Fu
Z0Bhcm0uY29tPg0KPiANCj4gVGhhbmtzLCBIZW5yeS4gIFdlJ2xsIHNlZSB3aGF0IGZlZWRiYWNr
IENocmlzdG9waGVyIHByb3ZpZGVzLg0KDQpTaW5jZSB3ZSBhcmUgaW4gdGhlIHByb2Nlc3Mgb2Yg
NC4xNyByZWxlYXNlIGFuZCB0aGUgcmVsZWFzZSBpcyBzdXBwb3NlZCB0bw0KaGFwcGVuIGFmdGVy
IDIgd2Vla3MsIG1heSBJIGhhdmUgeW91ciBmZWVkYmFjayBoZXJlIGZvciB0aGUgcGF0Y2g/DQpU
aGFuayB5b3UgdmVyeSBtdWNoIGZvciB5b3VyIHRpbWUuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5
DQoNCj4gDQo+IFJlZ2FyZHMsDQo+IEphc29uDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:07:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:07:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421773.667382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuBH-0001TD-HF; Thu, 13 Oct 2022 09:07:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421773.667382; Thu, 13 Oct 2022 09:07:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuBH-0001T6-EZ; Thu, 13 Oct 2022 09:07:07 +0000
Received: by outflank-mailman (input) for mailman id 421773;
 Thu, 13 Oct 2022 09:07:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuBF-0001Sw-W8; Thu, 13 Oct 2022 09:07:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuBF-000388-UA; Thu, 13 Oct 2022 09:07:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuBE-0003mQ-P5; Thu, 13 Oct 2022 09:07:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuBE-0008DA-Ob; Thu, 13 Oct 2022 09:07:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=KY76WOn+Y1vdU/hg5V9hciO9hyeyaMSzvIvxrLo+Kxs=; b=tQ/aOW/iLthHE8s9SNaH75sguO
	Y3qWObYcr9q0hTEb3zHOEP3HogRGMkyfHv3LRl5biaxsFb8FIIM8zfgQGrbn7jRjW9wWebxo2UkyL
	snwPOuJ+ZxTUZyZlomVBqkChTRYyCH9HnG0g7OkCOXFd1YODDyleJNGo3fjZ7omQU040=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.13-testing bisection] complete build-arm64
Message-Id: <E1oiuBE-0008DA-Ob@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 09:07:04 +0000

branch xen-4.13-testing
xenbranch xen-4.13-testing
job build-arm64
testid xen-build

Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  e6b1e3892b685346490eded1f6b6f5392b1020b0
  Bug not present: 2ae9bbef0f84a025719382ffcf44882b76316d62
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173696/


  commit e6b1e3892b685346490eded1f6b6f5392b1020b0
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:52:02 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.13-testing/build-arm64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.13-testing/build-arm64.xen-build --summary-out=tmp/173696.bisection-summary --basis-template=172549 --blessings=real,real-bisect,real-retry xen-4.13-testing build-arm64 xen-build
Searching for failure / basis pass:
 173587 fail [host=rochester1] / 172549 ok.
Failure / basis pass flights: 173587 / 172549
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
Basis pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/osstest/ovmf.git#444260d45ec2a84e8f8c192b3539a3cd5591d009-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#7269466a5b0c0e89b36dc9a7db0554ae404aa230-7269466a5b0c0e89b36dc9a7db0554ae404aa230 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#bde3b13043e31fd757c44bcec182b0ff1fe36d22-042de0843936b\
 690acbc6dbcf57d26f6adccfc06
Loaded 10001 nodes in revision graph
Searching for test results:
 172549 pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173495 [host=rochester0]
 173521 [host=rochester0]
 173599 [host=rochester0]
 173622 [host=rochester0]
 173625 [host=rochester0]
 173627 [host=rochester0]
 173633 [host=rochester0]
 173636 [host=rochester0]
 173638 [host=rochester0]
 173644 [host=rochester0]
 173647 [host=rochester0]
 173587 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
 173651 [host=rochester0]
 173658 pass 444260d45ec2a84e8f8c192b3539a3cd5591d009 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173666 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 042de0843936b690acbc6dbcf57d26f6adccfc06
 173668 pass 917a7e3f347adb0721ff161a68309f51f621eec5 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173673 pass 96f3efbd991db83c608909c1c861a77fe26982f1 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173676 pass 710f83b79d6eab641401c054b2f40f6c630f8cd5 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173678 pass 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22
 173681 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 08eec20dc0550316dad64cdc63fee2371702f31f
 173684 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 9992c089de1fbb4d3217d2421ca60295998645d7
 173686 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
 173687 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
 173689 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
 173691 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
 173692 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
 173694 pass f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
 173696 fail f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 e6b1e3892b685346490eded1f6b6f5392b1020b0
Searching for interesting versions
 Result found: flight 172549 (pass), for basis pass
 For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62, results HASH(0x55bebb728e20) HASH(0x55bebb72e0b8) HASH(0x55bebb719f88) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 9992c089de1fbb4d3217d2421ca60295998645d7, results \
 HASH(0x55bebb723ee8) For basis failure, parent search stopping at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 08eec20dc0550316dad64cdc63fee2371702f31f, results HASH(0x55bebb71f5b0) For basis failure, parent search stopping at 8db4e9f9a0c2ec992e28259ceb7a8eb316716b05 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55bebb71d2a8) F\
 or basis failure, parent search stopping at 710f83b79d6eab641401c054b2f40f6c630f8cd5 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55bebb718280) For basis failure, parent search stopping at 96f3efbd991db83c608909c1c861a77fe26982f1 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55bebb710d40) For basis failure, pare\
 nt search stopping at 917a7e3f347adb0721ff161a68309f51f621eec5 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55bebb70b928) For basis failure, parent search stopping at 444260d45ec2a84e8f8c192b3539a3cd5591d009 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 bde3b13043e31fd757c44bcec182b0ff1fe36d22, results HASH(0x55bebb6fb5f8) HASH(0x55bebb70b328) Result found: flight 173\
 587 (fail), for basis failure (at ancestor ~318)
 Repro found: flight 173658 (pass), for basis pass
 Repro found: flight 173666 (fail), for basis failure
 0 revisions at f80580f56b267c96f16f985dbf707b2f96947da4 7269466a5b0c0e89b36dc9a7db0554ae404aa230 46de2eec93bffa0706e6229c0da2919763c8eb04 2ae9bbef0f84a025719382ffcf44882b76316d62
No revisions left to test, checking graph state.
 Result found: flight 173687 (pass), for last pass
 Result found: flight 173689 (fail), for first failure
 Repro found: flight 173691 (pass), for last pass
 Repro found: flight 173692 (fail), for first failure
 Repro found: flight 173694 (pass), for last pass
 Repro found: flight 173696 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  e6b1e3892b685346490eded1f6b6f5392b1020b0
  Bug not present: 2ae9bbef0f84a025719382ffcf44882b76316d62
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173696/


  commit e6b1e3892b685346490eded1f6b6f5392b1020b0
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 15:52:02 2022 +0200
  
      xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
      
      This commit implements the `XEN_DOMCTL_shadow_op` support in Xen
      for Arm. The p2m pages pool size for xl guests is supposed to be
      determined by `XEN_DOMCTL_shadow_op`. Hence, this commit:
      
      - Introduces a function `p2m_domctl` and implements the subops
      `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` and
      `XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION` of `XEN_DOMCTL_shadow_op`.
      
      - Adds the `XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION` support in libxl.
      
      Therefore enabling the setting of shadow memory pool size
      when creating a guest from xl and getting shadow memory pool size
      from Xen.
      
      Note that the `XEN_DOMCTL_shadow_op` added in this commit is only
      a dummy op, and the functionality of setting/getting p2m memory pool
      size for xl guests will be added in following commits.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
      master date: 2022-10-11 14:28:42 +0200

pnmtopng: 144 colors found
Revision graph left in /home/logs/results/bisect/xen-4.13-testing/build-arm64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173696: tolerable ALL FAIL

flight 173696 xen-4.13-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173696/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-arm64                   6 xen-build               fail baseline untested


jobs:
 build-arm64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421785.667403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuHp-0002zS-Ft; Thu, 13 Oct 2022 09:13:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421785.667403; Thu, 13 Oct 2022 09:13:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuHp-0002zL-Cz; Thu, 13 Oct 2022 09:13:53 +0000
Received: by outflank-mailman (input) for mailman id 421785;
 Thu, 13 Oct 2022 09:13:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiuHo-0002zF-EH
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 09:13:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiuHo-0003EY-7X; Thu, 13 Oct 2022 09:13:52 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.240])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiuHo-00040z-14; Thu, 13 Oct 2022 09:13:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=MEbbdfVmcU9+7Rkp3fc7LaJdAUPBHabKoPmsTvtEsWA=; b=JoHfCDH6b7HwXXICcG7xFnjKeQ
	8xZu/1BpuL8VouWLnR/fzYAjMHU9z+kuUwE+WpNYCedIDxKWKCPNKz7BM+EcgquP9BK5hdmwyLdOy
	s41Iu+AQWqWs6ja6HLPJCIGLXziccyQaQKzppHhoa9FnljohSFDhv6/UdiJNinKyHeZg=;
Message-ID: <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
Date: Thu, 13 Oct 2022 10:13:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221013083818.36209-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 13/10/2022 09:38, Henry Wang wrote:
> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> when the domain is created. Considering the worst case of page tables

Can you describe in the commit message what is the worst case scenario?

> and keep a buffer, populate 16 pages as the default value to the P2M
> pages pool in arch_domain_create() at the domain creation stage to
> satisfy the GICv2 requirement.
> 
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> ---
> This should also be backported to 4.13, 4.14, 4.15 and 4.16.
> ---
>   xen/arch/arm/domain.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2c84e6dbbb..e40e2bcba1 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>           BUG();
>       }
>   
> +    spin_lock(&d->arch.paging.lock);
> +    /*
> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area

The wording suggests that this is only necessary for GICv2. But below 
this is done unconditionally. I am happy with this been done 
unconditionally, but I think this should be clarified here.

> +     * when the domain is created. Considering the worst case for page
> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
> +     */
> +    if ( (rc = p2m_set_allocation(d, 16, NULL)) != 0 )
> +    {
> +        p2m_set_allocation(d, 0, NULL);

Shouldn't this be done in p2m_fiinal_teardown() to cover so the pages 
will be freed anything after this call will fail (include in the caller 
domain_create())?

> +        spin_unlock(&d->arch.paging.lock);
> +        goto fail;
> +    }
> +    spin_unlock(&d->arch.paging.lock);
> +
>       if ( (rc = domain_vgic_register(d, &count)) != 0 )
>           goto fail;
>   

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:21:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:21:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421791.667414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuP5-0004Uk-8w; Thu, 13 Oct 2022 09:21:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421791.667414; Thu, 13 Oct 2022 09:21:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuP5-0004Ud-5j; Thu, 13 Oct 2022 09:21:23 +0000
Received: by outflank-mailman (input) for mailman id 421791;
 Thu, 13 Oct 2022 09:21:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiuP3-0004UW-VY
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 09:21:22 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2051.outbound.protection.outlook.com [40.107.249.51])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 65b06104-4ad8-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 11:21:20 +0200 (CEST)
Received: from DB6P193CA0020.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::30) by
 PAXPR08MB6495.eurprd08.prod.outlook.com (2603:10a6:102:dd::7) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5676.23; Thu, 13 Oct 2022 09:21:18 +0000
Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:29:cafe::4e) by DB6P193CA0020.outlook.office365.com
 (2603:10a6:6:29::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Thu, 13 Oct 2022 09:21:18 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 09:21:18 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Thu, 13 Oct 2022 09:21:18 +0000
Received: from dde0b5c46ab0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 83A13626-5EF0-440E-8030-A5BF28B0F14A.1; 
 Thu, 13 Oct 2022 09:21:12 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dde0b5c46ab0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 09:21:12 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM0PR08MB5459.eurprd08.prod.outlook.com (2603:10a6:208:186::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 09:21:10 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 09:21:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65b06104-4ad8-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=CXvJzdRDkgi9y3kBea3OYtmw0n0iIy4dBMyHFkyBbrc6GCFh7zueGgsp4wLjOkZxvzK7/7RDWZDVOpIwjKl4odNewVPQ3sWIm+P4gSIa/4ry4Iivx62OIB1h1AzWjP0A2lkXfIv3kk09LjRXNsTLl2epMAPS8BLDUi+qSbWAqaCpGdVboVQ6USEGN8AofRgU/u0hOOmHtSL47CVmmMxlew6KvNzl9AHNzNXaXzJ2P4p9NS7tWCRwUFBSz1GYRHU1j494cty0WJqXhDnMKKZ/wJfTWHPdfeCRoGHINacQmkUYUF+tngFqZw1Hu+SoWd+hImunvjOPC3NjOe2oMXTqWw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eJV8Jn6ATABpdsHsHCkhHy9K7j3LBcCWjb2s7CdMPQU=;
 b=PcEhfTzjNanQE5ADbmweU81LGQOikt9FbZDICUtAC7mIM6VHPjKeh1VphEbjedvbxIjBf11vk4tdgzadbiXhNbXjeQ3X8gVU+A3YSSnZ3caa4/xf8ViYdQouw2JMomKW+rf90lL05KTzRx1e8R9nxpd52Yv1lUdO/kXfEICA0mtbqEymsRQ/TimXi2Be+1nKqrpoejy7WdO/6yA+7ZtLpCtCaXOMa6nY7oqHTzZNjmkO9Ue+WPyEJPbzKiHDJPRIfgn8bf0Ur4PKpdAULUkB01IV+NtN5ClP0pMwqy1uybfLPUOND/Qg9ECvLjUZoplrr8q0x1eAINjLaz13O5vYVQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eJV8Jn6ATABpdsHsHCkhHy9K7j3LBcCWjb2s7CdMPQU=;
 b=mWsdoScqUN9tkyLd0rD/ynxHqv2MyZQJ3kzzHrk1Hoiqs08bQRlkTMD02pN4YZB7L2Jyzhgm15maGNzHPOTYl1FKii+Jff5OtvnSMLpHM3jPGV5b9lwA9Ijk94i1slV1gJzqoDK0sm6zUZcLovc667CoFBwdF+QnLYcXLUNV7f0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CvY0A4oTwTCMqT/Fm00yBFgbD7pnI8JFVuCqRrmTCz5mWAFxJtNSLp1lum/GKnzFLjbTbeivIbskaTOWQBBu+4K8N+GkGxBbTPj2jW1df9VoXJvRArAvVZnRjeEUJlC8iCmZm/eB/NRk0CuH7FkB7ckLzL/ZLjapJOhWhvLNbclGY8jSN7trlzg5J28MV8QgwuohV4vz68u+YZPNZC95k5ijZjmdn9XSrYvyBAYgGz1qoymrdd7Zn7+DuGOwSXerZwRuF+EbvWLOi9Uw6kbVAmYShT2qUeU3uKAC/Pwj9HnwoJrskR4M53C9z8SWcEMrj90fgbL7/rBcuaCiNY68Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eJV8Jn6ATABpdsHsHCkhHy9K7j3LBcCWjb2s7CdMPQU=;
 b=Z4XcCpQ2gGHpDdX1/Sawqokwwva8YOqt1IMJ1yjUqldw7UP6UQD4H441r8xW8hAx1DarxkRmkWIK3WCud3bXD6ZPvO+fAJh/cBFniPrI3I1VYhTv2m0/z1AYrr+CoOeKxD2ltDhvv+SqGjJZFTXh46Sq0CDCR33GQ6I5pgCWEGq76ghd/R24KAEIB6HaLBga++wXwkQuXtIgS/1nLUdskpWyDEwrWDJ8SZR7H/5BKIoHWBm9J3kSWnhLpfAZePYdLITNXMpVsFDxGHp9bsTkqVf+y4go2mcnmH5ez7mAr8oAPlevc3mYyfwT2B0qsp7kbvEA0RC5ByNS+0s2dHHQ3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eJV8Jn6ATABpdsHsHCkhHy9K7j3LBcCWjb2s7CdMPQU=;
 b=mWsdoScqUN9tkyLd0rD/ynxHqv2MyZQJ3kzzHrk1Hoiqs08bQRlkTMD02pN4YZB7L2Jyzhgm15maGNzHPOTYl1FKii+Jff5OtvnSMLpHM3jPGV5b9lwA9Ijk94i1slV1gJzqoDK0sm6zUZcLovc667CoFBwdF+QnLYcXLUNV7f0=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY3t81xdeRddBbSEGLoF20gErPe64MCngAgAAAYwA=
Date: Thu, 13 Oct 2022 09:21:10 +0000
Message-ID:
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
In-Reply-To: <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 5FC7E0AB37670D45946E321E5D3B773B.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM0PR08MB5459:EE_|DBAEUR03FT025:EE_|PAXPR08MB6495:EE_
X-MS-Office365-Filtering-Correlation-Id: 7b1bb3b4-fdf6-4380-efb3-08daacfc48df
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XNTXYCpSGYoRNCx2O5kIzMnX9ecfxYejoUheeq4QLanfw/yzCKhTOiWvpai45xNAKuTQJlQ6JNoN/ABa8SMDX2e1IQB2/jARD60HyKeNL39HQD1jfrHOhNl0RzZC9NWmQIiGjHzAk+PHW6CZwWeeORqMnMjIAs7lwBfqthfDxA8HjJs7xjEIX3qsfHjWsiNrGDeqpS9EVwjq6XRCrYM9vf89nAcVq1Nej9LVVe8fLCt8HXydFJqQGRbIxcIc3IjDxpftcFa4PD2ldWG8iq9POUu5BrpzWMDMAy8XRRZokJe3cT43+uxriN5edfe/HbjugtMb1rpyKAy4D0zkqXXqrNktJEFr/lZrkqXDDXJBS14LqMZWPbpTu/Q9IaB9cYoAcOZeDHRG48DjNJ6Oq4oBEp3+dLixjMt8ZneVfSoj3Qby5jY39tVXQbDKI/dxdsjMZBByO1S8A1lGpBldC3sKSO1AygfhGZaAv+uHchDFyZ1nK/SnZTIxaokB72m2Z2+ojPTmNltN4rZulSKM4vX3kaopoo2A8kAedcMzppe3822dW7Gg+FVNv+z+Wh8TWpmt4qLrNzffYvD1f2MogNnKfE6blvKUKBYlT4KP9mcCr6Bf88Xn6UWQobalo3g/aD2SHEIaeIPHGmLVWRf1gLNE1pb13xctwlV2lJB1CCSDP1QO+W/+UijbEIwKHFyLzrsxivM7zqBPytz7gjGO1/ZP0w9JtZkvdhENWv3asNEdjYGLFgnxCsTDQVUTIrSQD+V0JIHz39TZ7tD+T85jJ+ty7w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(83380400001)(76116006)(66446008)(64756008)(4326008)(2906002)(8676002)(33656002)(38070700005)(66476007)(66556008)(66946007)(38100700002)(6506007)(110136005)(8936002)(26005)(52536014)(9686003)(86362001)(41300700001)(54906003)(7696005)(5660300002)(71200400001)(478600001)(186003)(122000001)(53546011)(55016003)(316002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5459
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ff4d31bd-5967-4201-6681-08daacfc445e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TGRtwelePAlhUTzRkMHMcB4Qq2lllMIyuU8q5WkS9f7KXRQh2c9MJ64IP/Mrty53tfkk9nGDH+W8eWeyfInJ0xpaHuEqqw3HRW6hRtq5Y1WfKoSLnGBAzC7h8fna0fCL9E4wFL5O2/Bgsw6wiMm440beQJUrsyfN8E7onxALs693L8b+LF+62zLUnQfsARKoMsQEPm/+pPn4PkvOENFYO9TW4CJhOqZV9drwmzjBrGDDtCy2fpyQVoowVF39f9TU41HvWiiCV7dd7CmmYlkef7wwTQe6VC1TxE7Zz/dR8zb5huG6fznjITSzKBdBZmDkxPIJG0s10Q6nW7tvjLsaFrkqfK+1K1vd3M79uFuOKSQUsrE1PzDOVZUvQnkxOKT7i37+wN/lvst945LCJTCW1G5889Tru7UozfX2K7MlD5u5JoZ0LVa72hQFfRkcFxhZQfm83Cf4Vlphsw1pkv/q34c2M9e6NmKR7AzGqkDmXugxYsrZUotslBaTEbf3GcZl+W16cTbULfN0R4aWsuRs6vcYr8o+keZGyJQEBJOKcuWEfDhXyXUmauO9cGFA4JeNnELPG+ZQaJHkyBAZbt8kYMeovTZslpCy25PxFdTp2MFuAuoktBxeD19LokuIB6RqhX+FAQP33R6HWNHfILANlemEFKjmjitioJblnavhhT2+9zUsCPF3bSfmblHrhTPwdGtT+73NJ+9vV4uV1XwO0apaAR1p7PD5rIxbPPzIVSKMjwXlK4AhSzmpkEgSo3c8WwHAPxyKAgIMdOHYCJe7GQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(53546011)(6506007)(82310400005)(356005)(81166007)(54906003)(110136005)(316002)(478600001)(82740400003)(2906002)(9686003)(52536014)(186003)(41300700001)(5660300002)(8676002)(70586007)(107886003)(4326008)(55016003)(86362001)(336012)(40480700001)(83380400001)(7696005)(33656002)(8936002)(47076005)(70206006)(26005)(40460700003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 09:21:18.0718
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1bb3b4-fdf6-4380-efb3-08daacfc48df
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6495

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHhlbi9hcm06
IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4gYXJjaF9kb21haW5f
Y3JlYXRlKCkNCj4gDQo+IEhpIEhlbnJ5LA0KPiANCj4gT24gMTMvMTAvMjAyMiAwOTozOCwgSGVu
cnkgV2FuZyB3cm90ZToNCj4gPiBIYXJkd2FyZSB1c2luZyBHSUN2MiBuZWVkcyB0byBjcmVhdGUg
YSBQMk0gbWFwcGluZyBvZiA4S0IgR0lDdjIgYXJlYQ0KPiA+IHdoZW4gdGhlIGRvbWFpbiBpcyBj
cmVhdGVkLiBDb25zaWRlcmluZyB0aGUgd29yc3QgY2FzZSBvZiBwYWdlIHRhYmxlcw0KPiANCj4g
Q2FuIHlvdSBkZXNjcmliZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2Ugd2hhdCBpcyB0aGUgd29yc3Qg
Y2FzZSBzY2VuYXJpbz8NCg0KVGhlIHR3byBwYWdlcyB3aWxsIGJlIGNvbnNlY3V0aXZlIGJ1dCBu
b3QgbmVjZXNzYXJpbHkgaW4gdGhlIHNhbWUgTDMgcGFnZQ0KdGFibGUgc28gdGhlIHdvcnN0IGNh
c2UgaXMgNCArIDIsIGlzIHRoYXQgY29ycmVjdD8NCg0KPiANCj4gPiBhbmQga2VlcCBhIGJ1ZmZl
ciwgcG9wdWxhdGUgMTYgcGFnZXMgYXMgdGhlIGRlZmF1bHQgdmFsdWUgdG8gdGhlIFAyTQ0KPiA+
IHBhZ2VzIHBvb2wgaW4gYXJjaF9kb21haW5fY3JlYXRlKCkgYXQgdGhlIGRvbWFpbiBjcmVhdGlv
biBzdGFnZSB0bw0KPiA+IHNhdGlzZnkgdGhlIEdJQ3YyIHJlcXVpcmVtZW50Lg0KPiA+DQo+ID4g
Rml4ZXM6IGNiZWE1YTExNDljYSAoInhlbi9hcm06IEFsbG9jYXRlIGFuZCBmcmVlIFAyTSBwYWdl
cyBmcm9tIHRoZSBQMk0NCj4gcG9vbCIpDQo+ID4gU3VnZ2VzdGVkLWJ5OiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5
LldhbmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiBUaGlzIHNob3VsZCBhbHNvIGJlIGJhY2twb3J0
ZWQgdG8gNC4xMywgNC4xNCwgNC4xNSBhbmQgNC4xNi4NCj4gPiAtLS0NCj4gPiAgIHhlbi9hcmNo
L2FybS9kb21haW4uYyB8IDE0ICsrKysrKysrKysrKysrDQo+ID4gICAxIGZpbGUgY2hhbmdlZCwg
MTQgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21h
aW4uYyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiA+IGluZGV4IDJjODRlNmRiYmIuLmU0MGUy
YmNiYTEgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+ID4gKysrIGIv
eGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+ID4gQEAgLTc0MCw2ICs3NDAsMjAgQEAgaW50IGFyY2hf
ZG9tYWluX2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPiA+ICAgICAgICAgICBCVUcoKTsNCj4g
PiAgICAgICB9DQo+ID4NCj4gPiArICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7
DQo+ID4gKyAgICAvKg0KPiA+ICsgICAgICogSGFyZHdhcmUgdXNpbmcgR0lDdjIgbmVlZHMgdG8g
Y3JlYXRlIGEgUDJNIG1hcHBpbmcgb2YgOEtCIEdJQ3YyDQo+IGFyZWENCj4gDQo+IFRoZSB3b3Jk
aW5nIHN1Z2dlc3RzIHRoYXQgdGhpcyBpcyBvbmx5IG5lY2Vzc2FyeSBmb3IgR0lDdjIuIEJ1dCBi
ZWxvdw0KPiB0aGlzIGlzIGRvbmUgdW5jb25kaXRpb25hbGx5LiBJIGFtIGhhcHB5IHdpdGggdGhp
cyBiZWVuIGRvbmUNCj4gdW5jb25kaXRpb25hbGx5LCBidXQgSSB0aGluayB0aGlzIHNob3VsZCBi
ZSBjbGFyaWZpZWQgaGVyZS4NCg0KU3VyZSwgSSB3aWxsIGFkZCAiRm9yIEdJQ3YzLCB0aGUgYWJv
dmUtbWVudGlvbmVkIFAyTSBtYXBwaW5nIGlzIG5vdA0KbmVjZXNzYXJ5LCBidXQgc2luY2UgdGhl
IGFsbG9jYXRlZCAxNiBwYWdlcyBoZXJlIHdvdWxkIG5vdCBiZSBsb3N0LCBoZW5jZQ0KcG9wdWxh
dGUgdGhlc2UgcGFnZXMgdW5jb25kaXRpb25hbGx5IiBpZiBpdCBpcyBvayB0byB5b3UuDQoNCj4g
DQo+ID4gKyAgICAgKiB3aGVuIHRoZSBkb21haW4gaXMgY3JlYXRlZC4gQ29uc2lkZXJpbmcgdGhl
IHdvcnN0IGNhc2UgZm9yIHBhZ2UNCj4gPiArICAgICAqIHRhYmxlcyBhbmQga2VlcCBhIGJ1ZmZl
ciwgcG9wdWxhdGUgMTYgcGFnZXMgdG8gdGhlIFAyTSBwYWdlcyBwb29sDQo+IGhlcmUuDQo+ID4g
KyAgICAgKi8NCj4gPiArICAgIGlmICggKHJjID0gcDJtX3NldF9hbGxvY2F0aW9uKGQsIDE2LCBO
VUxMKSkgIT0gMCApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcDJtX3NldF9hbGxvY2F0aW9u
KGQsIDAsIE5VTEwpOw0KPiANCj4gU2hvdWxkbid0IHRoaXMgYmUgZG9uZSBpbiBwMm1fZmlpbmFs
X3RlYXJkb3duKCkgdG8gY292ZXIgc28gdGhlIHBhZ2VzDQo+IHdpbGwgYmUgZnJlZWQgYW55dGhp
bmcgYWZ0ZXIgdGhpcyBjYWxsIHdpbGwgZmFpbCAoaW5jbHVkZSBpbiB0aGUgY2FsbGVyDQo+IGRv
bWFpbl9jcmVhdGUoKSk/DQoNCkhtbSwgeWVzLCBJIHdpbGwgcmVtb3ZlIHRoaXMgcDJtX3NldF9h
bGxvY2F0aW9uKGQsIDAsIE5VTEwpOyBpbiB2Mi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0K
PiANCj4gPiArICAgICAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7DQo+ID4g
KyAgICAgICAgZ290byBmYWlsOw0KPiA+ICsgICAgfQ0KPiA+ICsgICAgc3Bpbl91bmxvY2soJmQt
PmFyY2gucGFnaW5nLmxvY2spOw0KPiA+ICsNCj4gPiAgICAgICBpZiAoIChyYyA9IGRvbWFpbl92
Z2ljX3JlZ2lzdGVyKGQsICZjb3VudCkpICE9IDAgKQ0KPiA+ICAgICAgICAgICBnb3RvIGZhaWw7
DQo+ID4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:32:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:32:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421799.667431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuaD-00065v-CH; Thu, 13 Oct 2022 09:32:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421799.667431; Thu, 13 Oct 2022 09:32:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuaD-00065o-8t; Thu, 13 Oct 2022 09:32:53 +0000
Received: by outflank-mailman (input) for mailman id 421799;
 Thu, 13 Oct 2022 09:32:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xhTA=2O=citrix.com=prvs=278783dfc=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oiuaC-00065i-68
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 09:32:52 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 009e3379-4ada-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 11:32:50 +0200 (CEST)
Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 05:32:26 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB5822.namprd03.prod.outlook.com (2603:10b6:a03:2ae::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 09:32:25 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 09:32:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 009e3379-4ada-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665653570;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=XAdWOeXMSA1UBIKB6IzgW4koz5qL75/zBBx/4sjKJgo=;
  b=E2PeDWvP4L/rmqMDn4qfbO71E1fKnacWnzzAK/D6D3XLj0Wukoqp54xx
   gJmlAXImfwNF3GgX+6yOYHj0gzmjUU8FnABxAB8gApmP4vsMeVaPW018L
   SZVo1RaD/ca0sSEPJidOh5FiVhBZFBo45vuXf/j4oj/6Nwm9eW3mJYk/+
   0=;
X-IronPort-RemoteIP: 104.47.57.173
X-IronPort-MID: 82267071
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:+FVOOKxvZ/yR67CKq3F6t+e7xyrEfRIJ4+MujC+fZmUNrF6WrkUAm
 DBNCm+BaKmDM2D2ctB1O9zkoU0P7JSBztE3TgY4+SAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB5QRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw+ftOUFESz
 OUkbx9WXzaZ2rLrn5uKc7w57igjBJGD0II3nFhFlGicIdN4BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxuvDO7IA9ZidABNPL8fNCQSNoTtUGfv
 m/cpEzyAw0ANczZwj2Amp6prr+Vx32kAN1LfFG+3tEt3kS3nGVMMzwpV3ijjeO6pkOMSfsKf
 iT4/QJr98De7neDbtT7RQz+n3eCsTYVQd8WGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRty9v+pIA+iDrfQ9AlF7S65vX/FCvs2
 TmMoG47jq8KkM8Q/6yh+BbMhDfEjofET0g+5gjRdmu/60VyY4vNT7Kv7V/X/PNRNrGzR1OKv
 GUHs8WG5eVIBpaI/BFhW80IFbCtovqAbjvVhAc2G4F7rmv2vXm+YYpX/TdyYl9zNdoJciPoZ
 0mVvh5N4JhUPz2haqofj5+NNvnGBJPITbzNPs04pPIXOvCdqCfvEPlSWHOt
IronPort-HdrOrdr: A9a23:ytUhLarKuPQGUTgs5WTnnI8aV5uIL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U
 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK
 Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z
 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdVJsX6t
 M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pWVFZ9l/1pwKpuKuZ3IAvqrIQ8VO
 V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ
 zEFEhVsGYjEnieffFmHKc7hywlbF/NLggFkPsulqSRkoeMNIbDIGmEVE0kldemrrEWHtDbMs
 zDSq5rPw==
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82267071"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=boyfHlLbSUkNLlJdww5HbcVJ0p+35U9TteTTw6+Oym/clcQI4Rb3sCBTE1IJnTEPtTzqhxX64DHe63N6KJ33GELarpJr/VMoby74uT2uTEmVD8B5ItwNQeIPdz61ktMj5TEmQfP5vSDvq06caT6bNgrcKGFHE3+LKo2sk+rUPOJghamISDaj9Rc92D8Zr0GafUeMT067+RzZ5yrBa2lyaXorxQ8KkYGRAGtYIjdVACWZeBl3zFvA3//EW8lMDbQj0Qi6ktleMQwUEAQ8Gp6DtkM9qv6+iv325THx/eFpBXmeYq/y08IWTQRxP5erGoPdafZ+OvcA9IX5b8NeKY7W5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XAdWOeXMSA1UBIKB6IzgW4koz5qL75/zBBx/4sjKJgo=;
 b=e8A+Mes9Xq8q7SGB7t7Foc51AFRUlqi0DelDj2FG9LMcDS/cKiuGP54WThqGDAusOYMMTaHoZ25QKuETSQJEWtw0kUrqiPtvfynYafyqMxxc4EkOhYeVl0kKw/TLKbnp3fyxDjoUQ5rkF1fO9hpQGpGys1vihSKCRc2/6ZskKM70QYT2iGWi2Ds5gIVnCA1CxTCs9tEOqmyAOZnZvZoOIgR06P/YMo6gTNPYCZWgOiwgLzIqu0+gVqhzQpAMK+Q56wI+IZD6tKXgMpauF7QOBunbNhvnosI3ufKv6XiGCLKEXSvSzs+NSpdFUJADwMsdf7MAR6HP3GuooyAhw3coQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XAdWOeXMSA1UBIKB6IzgW4koz5qL75/zBBx/4sjKJgo=;
 b=eekemMo8WPIR1b8hN/uj3q0SaJ4XIrL9ALVRjXnUNABOSJ3p8dZTykODhNKMguYNDcs8ud4x4lUPmk6bije0ygzi67GvAJU0i25IsGIo0kcza7Q7Nw73OAuqXzrcghQXig1Na15zjDdkS2y4xfWPe/9fmiQDvHKVsHzMMFavvF8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen
	<wei.chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY3t89iKUDKPVqKkqXHrrxwpoahK4MD6gA
Date: Thu, 13 Oct 2022 09:32:24 +0000
Message-ID: <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
In-Reply-To: <20221013083818.36209-1-Henry.Wang@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5822:EE_
x-ms-office365-filtering-correlation-id: 32385c53-fcbc-4034-0dce-08daacfdd650
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 j9cmgAQ62PzmH+dL8DFth4cMqXNLR6F8LTwLxNiOlmyyLny8Y+IeZNnOIMLDhXpchoWRwv5aVl/zCWUqQ3I0AVhjwO5UHz364j65HFGua4yFsQQ2JYXAMUHQc51O+bwE7ifgErLaREPI2fjlMsDWoNuSDr6+rxuIwtEw6FWF8r7R304hY5f+qBi9TgPVfUQnd6T9wdUpsG6rdySh32lkFA/NpcpNR0YcjKJ+DrNfIVjI1+MDX6xwTu55hmV/S1vinEFJvqQ7DTALdCL3B3vOsMySzB1tK+aOOX0xDVwEFuUp2Qt6ZZWxXn53xyGNOqr7fLAe/0Y1B6H0lEBVQPI+dRyr4818pFp0oQdXfDJsK27HwqBqm8Md0j54jr+BW7Q1tiO/fU5Cw7A/5FTeNxO6T6IyORPpEqa3RV3nnhPmleSpc+A5WaLGPJWXnd4Pj0njwFR4ccnB+mVrSfJvFJPoX4lcxwTUAWy9bWFAskWJhwmKeq1EaHMFhzDrIct5Kk7Dbq/fYSQTWorB6A/LZFlmcGEGc7flEBjV3De0fPGrkJbtVCVglBS0KY670t0py9Gm63+vsIbGEVSy0PlldpeYEIZ757EGs8tx7Dwp+2NYOmOfKDGAcxOq0W3GSEe8iyR1CuDL9S0NmU+1wIN3E5aRtHCt8fff2HzxbWKyjCKsi0kxnFJqtSKQoKuuer7DQA7n8f7BoLXE8WifFlQ4IesS/rtnFkeLgYS+yd/6CtJxdW1fw059+auZ3CnGN4qQiOqU/FyMTs3ku1hX2hfd3arjbWWn9wVeBryND9eABfU6sQK3hSz5TO88wfsceKSxSSGE38RNJ5IQ9jU5Hl3l3MZFZg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(451199015)(316002)(26005)(186003)(8676002)(91956017)(36756003)(8936002)(76116006)(66446008)(66476007)(66556008)(66946007)(4326008)(53546011)(41300700001)(31686004)(83380400001)(6506007)(6512007)(2616005)(5660300002)(2906002)(64756008)(71200400001)(38070700005)(82960400001)(478600001)(122000001)(54906003)(110136005)(86362001)(31696002)(38100700002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZVJzT0JndzlzNytSTUpENHMzSlNZNVRHd1NqaEx4WkZPU3RPZkJpS29Zazhv?=
 =?utf-8?B?OFJBcHVvYUlzWTdNWkpwM3JyZi80NjIzRzJLZVRFeUFrejhGUnlSeC93M0VB?=
 =?utf-8?B?aXYrZGdScnNWYmszMTcxOTVyUzhoeDNjRzdpSTZzT3hWeGFjcEtFRThhWnZX?=
 =?utf-8?B?RnJ5a1hGQ21ydVZiUU9wR3MwaVBob3g5Uk91OXlsTHpRWlZ2Q2FhNTQvWDEy?=
 =?utf-8?B?ekJIN2FkUkNEOHFycVB6QzdmUDdoWlM2ZDdYMGhOTU9DYnhoSXlHSmhNdmwv?=
 =?utf-8?B?V3RPTEhlckNMa3NxWVNxcTBHSmpzanVnVUhVVjVsdlJrUDR2NWM0RXNQdyts?=
 =?utf-8?B?NTNZay81Tm5OUlBFZUs1VzlTUHpKUGE1MjJLTGxkN2VNRG8vWUZmdUE5eGlT?=
 =?utf-8?B?NEpTN2xJZ0tMa2NkVEI5Q0NtMzlKc1MxaXpvWVY1dDZKOXAzVGcxSkhGMHov?=
 =?utf-8?B?LzB0SE9Va1Z3K1ZRZytsaGx5ajFkRStuYjViZ25NK2E1bUdic3FNKytmcVhU?=
 =?utf-8?B?R1IrS25mLzJ4YVgrd2JwV2Z4d05ESGR0RFUwalhON1kvSzhSWmJNaGdKVG9m?=
 =?utf-8?B?ZmIzNWdpU1EyaUFGenhVdXpqVUp0eHlRdTNHVGpuZUxUTkk3SVZGakY0cHNt?=
 =?utf-8?B?SWZFOGlLMGhkSEVUN0krOVZySklNR0dKSGw0Nm1tdWovNzNBZ3gwSXJaT1pQ?=
 =?utf-8?B?Zy9CdXpkRWJEY2g5ZVdlQkVuSkxhckFhQlN0MWhtNU9RL29Ed0IzbzM0b1Ba?=
 =?utf-8?B?TW9CdjVpVE5pcTVxYndkS3Rrd2RvY1NFRStZUHpLWVBUT3BmaGlaY0EvSWVw?=
 =?utf-8?B?bUlENy9hcTA4L0pVQ0lrSlcvb3cwNUpwd1dKQVVJYW5YRlg0QlR0TDJ3ZjI4?=
 =?utf-8?B?bEZvOTAvWHdVR29oak8ySXdYRVY2SnRTUCt4ZzVtRWFhazZDcHVtSGVOdWE4?=
 =?utf-8?B?UXdMdFMwODJTTXpuVUNkdHZmWHhIOTVxWUVhUjF4eWlqSFdHYmh3eGJ5T0Ry?=
 =?utf-8?B?L3RGdXEweG8yZm1LQXpFMmFDVWd6Tjd5SVVnZUp2bHVZSklucnRsV21EVnRN?=
 =?utf-8?B?OFo0VWd2QU5peEs2QVdzM3BmcFRHRGJ3aUM5akNDa1p3a3hsMjNZNzVyNyto?=
 =?utf-8?B?TEpvdHE3aXFXQVY3TDc2Q3JzZFNxQVZPVXlEYUwrREpYK3hYK2d2eno4WFYw?=
 =?utf-8?B?em5KYXBKamFIMndDL1VnelVxTVpKWWh5RFB4OHprT3lxUWVNTzN5OFJtMnBm?=
 =?utf-8?B?d0FhdFdIdG5JSFdKWTBiaWVBdFkxbkdnaGVIQjA1U0RWS2Jhc215bE43d1lJ?=
 =?utf-8?B?ZE5zZ1FkcWduWjJMT3drSkFRTmhNVWQ4aGZHN3dDazlacFRGT2ZpTkFZNzZE?=
 =?utf-8?B?TmFZUUFNYzR4LzBHaGl6bXRMaGNHWVpWZ1NiTnRZYnpCNXJYTGdmZGh2UW1k?=
 =?utf-8?B?Q0tOamtoMXdsdXNObk9taHprVm10ZjlZYWtOKy9ZVkxIWUhMZXp6NFpYemFS?=
 =?utf-8?B?TVVNVTBpVVRpd2ZTQUFvY2hpSWhtdDhNRHdOemxtM0psOGNTK05lZy9pcS85?=
 =?utf-8?B?VG1QSnlGa0MyMGgwMGJoaHY0RlBzR05Jc2pBWE5xRDR5NzlLUWhTbGZPOHlR?=
 =?utf-8?B?Ly8zYkdtS3lqUTFqajNnNmUrL0lTMkYvc3B6Ti9UTDg2eDA2SkJHNjlCbTRT?=
 =?utf-8?B?TmtkSnl4SkVZVEpoTEJTaXA0eFVRK0hIMjExRVJVMEFaL0Y1dnpjWk1zR2Nw?=
 =?utf-8?B?MThsK1YwMmdSVjlFVEY0TDRtTU9CWlh0OFlzVGtIZzNSOFJNZHRiUVRtS2h5?=
 =?utf-8?B?b1pqV0NRajY3cUMxNVhwdHVzNVV0SE0vUVJHcDNLRWt5MTVyT2R2TnhtVXBT?=
 =?utf-8?B?b3M0Tkw4NnArTXJpSmNHL0JaT0ZpMFRsS1FzcGpJVC8wMFlSdVMyQkQ1dExx?=
 =?utf-8?B?SEhRR2swWXNBOGV4SHp2UDFrRkgzSnRQR3htM1d0dGtZRVdFbUZSQ1ZYNFlJ?=
 =?utf-8?B?cHFSTDJ2aVJ1R0pVZVlpZTBXTXZ0L0gwR0lZWlFhcWZuVDFmUWJWNmd1aEZj?=
 =?utf-8?B?NXZjWVRxMFNGZ0Y4WDdRQ040UU9MbEE1djh3L0x0UTFsRE1BbjhqU1lLQng4?=
 =?utf-8?Q?Z5J0pNKZjNv3uZs/5zXqWgB7E?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CE1D36E29E644141A1FDAC249BD65922@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32385c53-fcbc-4034-0dce-08daacfdd650
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 09:32:24.7995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rcMBIvp549ngEFNvwkxwRv0xRCZK2bbFwnz8fYNxCBArt1aFrDhYe6/gk3ksvUGJKjJ4M8kqmUIHdcucMONCM5ztoJLFjDgSPKEDSmOKFdY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5822

T24gMTMvMTAvMjAyMiAwOTozOCwgSGVucnkgV2FuZyB3cm90ZToNCj4gSGFyZHdhcmUgdXNpbmcg
R0lDdjIgbmVlZHMgdG8gY3JlYXRlIGEgUDJNIG1hcHBpbmcgb2YgOEtCIEdJQ3YyIGFyZWENCj4g
d2hlbiB0aGUgZG9tYWluIGlzIGNyZWF0ZWQuIENvbnNpZGVyaW5nIHRoZSB3b3JzdCBjYXNlIG9m
IHBhZ2UgdGFibGVzDQo+IGFuZCBrZWVwIGEgYnVmZmVyLCBwb3B1bGF0ZSAxNiBwYWdlcyBhcyB0
aGUgZGVmYXVsdCB2YWx1ZSB0byB0aGUgUDJNDQo+IHBhZ2VzIHBvb2wgaW4gYXJjaF9kb21haW5f
Y3JlYXRlKCkgYXQgdGhlIGRvbWFpbiBjcmVhdGlvbiBzdGFnZSB0bw0KPiBzYXRpc2Z5IHRoZSBH
SUN2MiByZXF1aXJlbWVudC4NCj4NCj4gRml4ZXM6IGNiZWE1YTExNDljYSAoInhlbi9hcm06IEFs
bG9jYXRlIGFuZCBmcmVlIFAyTSBwYWdlcyBmcm9tIHRoZSBQMk0gcG9vbCIpDQo+IFN1Z2dlc3Rl
ZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTog
SGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KPiAtLS0NCj4gVGhpcyBzaG91bGQgYWxz
byBiZSBiYWNrcG9ydGVkIHRvIDQuMTMsIDQuMTQsIDQuMTUgYW5kIDQuMTYuDQo+IC0tLQ0KPiAg
eGVuL2FyY2gvYXJtL2RvbWFpbi5jIHwgMTQgKysrKysrKysrKysrKysNCj4gIDEgZmlsZSBjaGFu
Z2VkLCAxNCBpbnNlcnRpb25zKCspDQo+DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9t
YWluLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4gaW5kZXggMmM4NGU2ZGJiYi4uZTQwZTJi
Y2JhMSAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+ICsrKyBiL3hlbi9h
cmNoL2FybS9kb21haW4uYw0KPiBAQCAtNzQwLDYgKzc0MCwyMCBAQCBpbnQgYXJjaF9kb21haW5f
Y3JlYXRlKHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICAgICAgIEJVRygpOw0KPiAgICAgIH0NCj4g
IA0KPiArICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7DQo+ICsgICAgLyoNCj4g
KyAgICAgKiBIYXJkd2FyZSB1c2luZyBHSUN2MiBuZWVkcyB0byBjcmVhdGUgYSBQMk0gbWFwcGlu
ZyBvZiA4S0IgR0lDdjIgYXJlYQ0KPiArICAgICAqIHdoZW4gdGhlIGRvbWFpbiBpcyBjcmVhdGVk
LiBDb25zaWRlcmluZyB0aGUgd29yc3QgY2FzZSBmb3IgcGFnZQ0KPiArICAgICAqIHRhYmxlcyBh
bmQga2VlcCBhIGJ1ZmZlciwgcG9wdWxhdGUgMTYgcGFnZXMgdG8gdGhlIFAyTSBwYWdlcyBwb29s
IGhlcmUuDQo+ICsgICAgICovDQo+ICsgICAgaWYgKCAocmMgPSBwMm1fc2V0X2FsbG9jYXRpb24o
ZCwgMTYsIE5VTEwpKSAhPSAwICkNCj4gKyAgICB7DQo+ICsgICAgICAgIHAybV9zZXRfYWxsb2Nh
dGlvbihkLCAwLCBOVUxMKTsNCj4gKyAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5n
LmxvY2spOw0KPiArICAgICAgICBnb3RvIGZhaWw7DQo+ICsgICAgfQ0KPiArICAgIHNwaW5fdW5s
b2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsNCg0KR2VuZXJhbGx5LCB0aGlzIHdvdWxkIGJlIGJl
dHRlciB3cml0dGVuIGFzDQoNCnNwaW5fbG9jaygpOw0KaWYgKCByYyA9IHAybV9zZXRfYWxsb2Nh
dGlvbigxNikgKQ0KwqDCoMKgIHAybV9zZXRfYWxsb2NhdGlvbigwKQ0Kc3Bpbl91bmxvY2soKTsN
Cg0KaWYgKCByYyApDQrCoMKgwqAgZ290byBmYWlsOw0KDQp0byByZWR1Y2UgdGhlIG51bWJlciBv
ZiBzcGluX3VubG9jaygpIGNhbGxzIGFuZCBtYWtlIHRoZSBlcnJvciBwYXRocw0KbW9yZSBjbGVh
ci7CoCBIb3dldmVyLi4uDQoNCj4gKw0KPiAgICAgIGlmICggKHJjID0gZG9tYWluX3ZnaWNfcmVn
aXN0ZXIoZCwgJmNvdW50KSkgIT0gMCApDQo+ICAgICAgICAgIGdvdG8gZmFpbDsNCj4gIA0KDQou
Li4geW91J3ZlIGdvdCBhIHByb2JsZW0gb24gdGhpcyBlcnJvciBwYXRoLCBzbyB0aGUgc2V0IGFs
bG9jYXRpb24gdG8gMA0KbmVlZHMgdG8gYmUgaW4gdGhlIGZhaWw6IHBhdGggd2l0aCBzdWl0YWJs
ZSBsb2NraW5nLg0KDQpUaGVyZSBhcmUgcGVyaGFwcyBiZXR0ZXIgd2F5cyBvZiBkb2luZyBpdCBp
biA0LjE1KD8pIGFuZCBsYXRlciwgYnV0IG5vdA0KaW4gZWFybGllciB2ZXJzaW9ucy7CoCBBcyB0
aGlzIGlzIGEgZml4IHRvIGEgYnVnIGluIGEgc2VjdXJpdHkgcGF0Y2gsDQpzaW1wbGljaXR5IGlz
IGdlbmVyYWxseSB0aGUgYmV0dGVyIGFwcHJvYWNoLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:40:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:40:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421807.667442 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuhu-0007fC-8R; Thu, 13 Oct 2022 09:40:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421807.667442; Thu, 13 Oct 2022 09:40:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuhu-0007f5-5g; Thu, 13 Oct 2022 09:40:50 +0000
Received: by outflank-mailman (input) for mailman id 421807;
 Thu, 13 Oct 2022 09:40:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiuht-0007ez-4Z
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 09:40:49 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2046.outbound.protection.outlook.com [40.107.247.46])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d284c8d-4adb-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 11:40:46 +0200 (CEST)
Received: from AS9PR06CA0314.eurprd06.prod.outlook.com (2603:10a6:20b:45b::16)
 by AS8PR08MB6021.eurprd08.prod.outlook.com (2603:10a6:20b:23c::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 09:40:44 +0000
Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45b:cafe::67) by AS9PR06CA0314.outlook.office365.com
 (2603:10a6:20b:45b::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.25 via Frontend
 Transport; Thu, 13 Oct 2022 09:40:44 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 13 Oct 2022 09:40:44 +0000
Received: ("Tessian outbound 7761be2ecf00:v128");
 Thu, 13 Oct 2022 09:40:44 +0000
Received: from fe62364efc7f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 23428810-055E-4829-8D4E-313DE47E03CA.1; 
 Thu, 13 Oct 2022 09:40:38 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fe62364efc7f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 09:40:38 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB6601.eurprd08.prod.outlook.com (2603:10a6:10:23e::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 09:40:37 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 09:40:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d284c8d-4adb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ntOsT/G/hcZE5mywaIN84jOR4ncBZnv4mo8ByfV5U0E6K5ViDC2e+0oedFClz6uFL0LQnC/Zbt5SrVj25frVCT/Qu8oB7DMZ7wOoir0ED9Kp0aKBLB7A5TrToKLy3MoJJHviszEwtaQ9fr2v591ndLFG595/x2Z3BuwuYND9nBUqhiXr/uTpButPgmCyQDkRGWHkByfBEa1DaMCBw6KbZrZD6szC4AYyUU2ec7Y9sk2E73IQxbPLD0i63OE2iU2ci1bAjKBWwVobER2rV4sbC+BQjCX7JQE2gND+b+k/f/m762U7JtA1zvkOoepC08OKDuL6F2p6+EeXbOtS8ZYGLw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oC0meC2W1Kz8dB5+yrDcSqlJtevWH88cFRtHoxbjs1s=;
 b=fOTR5VgRa+at2noXeq4Fsx19eO/lBA/jjjYJaduf2X6OosbBD/nZSlRxg29XxqKPDTkkU4xNVZ30PPavhrOvhnlFhmsVQ+hOddn8GGJkoWhigc9+YgDhkc5KySfrPZt5Ry4Rklx1DqQnzTB5feDXdQ9IdIlUgxlvEGYJ9i+Xuj0sm0PJwB1kIny5aYsrLwdR6PKc/ON+XC7dxYU2cu/f/izR4jZOCEAU4VKuu78SDv11DZHc557FNBkYOgJulM4h4BDalqndWJyFvZ8FIFiEL4zxJp/hs+9nIOgbNS82i+cHklyZugUJMIpVFTSY97qe/q22Et0ViViOCg9/w4FPAw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oC0meC2W1Kz8dB5+yrDcSqlJtevWH88cFRtHoxbjs1s=;
 b=Y786WKfk//ZYsjKOk/nVR/3iI3gHycQ7Qd9CSDviA9J3HvaK1IsxaxTmhyjATBGFNh5EhBJsr78E0yTifhQ5Z7OdLHe1LlL6vp56hpqmnen7sLwwecyGX1cvnpC2oC7BcCtfev+PLlrBQjoEq24kNTqYCSG+gnoUuIUld/zYlGI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QVEIwOdxEoKIMz5KWhZHlL2jL6t3dGX0bWHrQjCuo9vwLwhSdHGiYW6NlbMdVc+5ma0e16Vsz24wND87gZ0rlKaSMgNJIz6JvCnix452qk8vSbyBgjQN1hT34n3T1Ne0RDMLbEYYQlMO2r0TSrCbEfeflh208lW+2/aFKGhnASwjvpVgYJzDF4/7qJsvBK9JfvihWSS+LVRIkozxSQB4FLZOQwexwtIc3d3MdIgkEoXaERKG5hnzPrghgqCCVmx/EoswThk41vxvSf6XhTcrX0oywyYttFQl3HVxuQAE8D5+Si3QlfWiOf1j20OR7Brn5/4fj2MxY7RpQG0SAsiXLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oC0meC2W1Kz8dB5+yrDcSqlJtevWH88cFRtHoxbjs1s=;
 b=LiPY6TMKmH3ewUL1CMVbS3NAtYqdGPtedrdR7l9YCdkD4uRYjZbNKKTgvz/LrfRaDz8wtvCvES9WMOeWIBKt74wSb3ctfDQqJiQ3ehspZBp+rh1zO8PUIwlPKUZRcKGx66SlYC7pgMJkCJ5WeRXkjTuUEK76UKSCTooyL5A75oMrudaUeZpQ8/d9A2bw63X7sLxYwwTYbYzFJ9xQulNo2yfki/lA1oTpZRHWz7X+7sCLf9pd3LS/ZO1G/zdDD09gulP+RX2wLAL4p+L508oYE5+j+lspxtldyqe+NfAmc5S36Uq9bSPQJI0VaDABTUSEzsk0bhuITJGJEXi0I2q69A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oC0meC2W1Kz8dB5+yrDcSqlJtevWH88cFRtHoxbjs1s=;
 b=Y786WKfk//ZYsjKOk/nVR/3iI3gHycQ7Qd9CSDviA9J3HvaK1IsxaxTmhyjATBGFNh5EhBJsr78E0yTifhQ5Z7OdLHe1LlL6vp56hpqmnen7sLwwecyGX1cvnpC2oC7BcCtfev+PLlrBQjoEq24kNTqYCSG+gnoUuIUld/zYlGI=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen
	<Wei.Chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY3t81xdeRddBbSEGLoF20gErPe64MD6gAgAAAmHA=
Date: Thu, 13 Oct 2022 09:40:36 +0000
Message-ID:
 <AS8PR08MB7991FF3E7EEA46F11ED4376092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
In-Reply-To: <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: FBFECC74CBEDCB479075D790D106DA26.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB6601:EE_|AM7EUR03FT020:EE_|AS8PR08MB6021:EE_
X-MS-Office365-Filtering-Correlation-Id: d0d44251-8f51-4517-4fb7-08daacff003f
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 lFKdhIPnzSxfb0ufh3A6EE1HeHCI2h3S7ZT9uYfptvZLa6o1LFW/8lCkIHQnzEIH2sD/Ao6y1UFF1nzzH3PNFsCPVJguzyOLYHzvDQVYOMzKl8GitWl8TNul0Wv5x1bP+4QJ9Ane4kje2L79LZRdy99iRytbzxJcUaCE9QxJG5LPGXWVqFEnHZs5/LaXdMAZWuDuATOokbVTrA0DPkZtGqXe87RrtMXyQhQYq0+rCwYY3b5iDNCxRnWMO7oc8jxlZNGpaw+zIvH08+8rI02QrdTFKzid7NZqvayRwnXAdtAPJLAXwlFloUcafTPzy78EuueeggWVerNSKOr4f6RtbrHUSu1eLHZ8yHwLuEyK4ZGon/wbVgiU3dc9hfZjApZgrArKIh7+22HsuUGgo5dIdxZrpG4dYBh6hPbqWyQae3ov0et7i44x9U5EBXv8QEm6+fNR95h3B1MJ1MH1qLG16JqebhHfXDMQ6HHshkQVetln45nuAjrtaRKgQXynIiM2PVqjSiMKXOWANAjJZa+LK94fDQUUm29Y0zpBqwwkRoyTN8x2XQbswi6ZWGws17/B0o17oueSbmj3cr1qgnlQKHcEFZ5Qm2JK9dkIlwjRyg/RbeBftMq5R4hv0aIqa0K6vhfmLjVMbPqirm/ZLG1mNiZRJ1z5uOsqo9L3Fu3yd6NRsDrD0HUA7ILXFyFYMwAyafoxrApmZp4SBVzu14YNUgiH3fTs42H2kNywmpjfmfNEmJaGQ8m4AMnqGDTJJip2U0K+UtRYiK+dXZIX9fSy3A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(451199015)(186003)(9686003)(26005)(53546011)(55016003)(2906002)(122000001)(52536014)(316002)(33656002)(110136005)(8936002)(54906003)(41300700001)(66556008)(66476007)(66446008)(66946007)(64756008)(8676002)(4326008)(76116006)(86362001)(38100700002)(7696005)(6506007)(478600001)(71200400001)(38070700005)(5660300002)(83380400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6601
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b35ea3a7-6255-4fde-d6b3-08daacfefb52
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+xiD91r8LdKPlkzYwolj9sf5uDmwtXMIW3B1VNfSzpuiNinV+PZq24pSyB0oWl7QSSqQxhpuPIaTXGZPkU8UxmpRT07kJ5IaeLDzm0L1GIGeCpeZe0xxipGysVrmObihd8xJvvcw17lWocud4RC9oYopR5Jani713i5vXvsa0YFUOpYmcB0qqFYZVkQxCketLTeYb3mhAhcBETMvFS3VniJM2FCkV6PEeuK8pouBB1tEDot8UaFf0tn3rdDncjFdnI/MgpBlW8YVYUH6wmo7s8Boxnt/c8S3ctal196mW+NVzJRxSJy7iA24Y9e+UHK4jCVOsCAqAU1D4gtYrTtxPCqKkAT1mkohS6VnI7d8oRrs5pLmzLgIZwjJZ/Lpe2/z521qI5+zAnR/TQpdvTn15vJhgxT513fWbjTqJFZxsd8hkVoHiPbCFoZCOr037qFdc7VUbVSsVJJtJFE4OAtDXpsKRnjorOHfJjJgeJW+qL/LJ9jhR6MDDtZymkk/MwrYjnJduR9WjMgJydzmIAy52Efz1GFJ4cFXryOlfYRPtJFHrS9YqQgk5OfqnhtcMAkLBx7xU4S7EiFksY8P22U5emFaBJ+10XVlx1Qk2rAmLBxA1kR771tDUhPMgFU6z8XKjw4lUkehRYNApdG7RCBvcmhj5xMKidxFtPHGpHZoFQ5bpjm8+QqzRtYrrLXmwdCZoNRCrOtdcj6d/PjGQ00J0Hc4bt/qI3jCwkQy+aijk/o39EbwD5EoHSKEg3TSK6WypuH+eUvIzlnqGu7r14E30w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(70206006)(70586007)(107886003)(4326008)(8676002)(186003)(336012)(2906002)(83380400001)(36860700001)(40460700003)(86362001)(47076005)(7696005)(26005)(41300700001)(53546011)(55016003)(6506007)(5660300002)(40480700001)(52536014)(9686003)(33656002)(8936002)(82310400005)(82740400003)(110136005)(81166007)(54906003)(356005)(316002)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 09:40:44.6664
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d0d44251-8f51-4517-4fb7-08daacff003f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6021

SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl
dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFU
Q0hdIHhlbi9hcm06IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4g
YXJjaF9kb21haW5fY3JlYXRlKCkNCj4gDQo+IE9uIDEzLzEwLzIwMjIgMDk6MzgsIEhlbnJ5IFdh
bmcgd3JvdGU6DQo+ID4gSGFyZHdhcmUgdXNpbmcgR0lDdjIgbmVlZHMgdG8gY3JlYXRlIGEgUDJN
IG1hcHBpbmcgb2YgOEtCIEdJQ3YyIGFyZWENCj4gPiB3aGVuIHRoZSBkb21haW4gaXMgY3JlYXRl
ZC4gQ29uc2lkZXJpbmcgdGhlIHdvcnN0IGNhc2Ugb2YgcGFnZSB0YWJsZXMNCj4gPiBhbmQga2Vl
cCBhIGJ1ZmZlciwgcG9wdWxhdGUgMTYgcGFnZXMgYXMgdGhlIGRlZmF1bHQgdmFsdWUgdG8gdGhl
IFAyTQ0KPiA+IHBhZ2VzIHBvb2wgaW4gYXJjaF9kb21haW5fY3JlYXRlKCkgYXQgdGhlIGRvbWFp
biBjcmVhdGlvbiBzdGFnZSB0bw0KPiA+IHNhdGlzZnkgdGhlIEdJQ3YyIHJlcXVpcmVtZW50Lg0K
PiA+DQo+ID4gRml4ZXM6IGNiZWE1YTExNDljYSAoInhlbi9hcm06IEFsbG9jYXRlIGFuZCBmcmVl
IFAyTSBwYWdlcyBmcm9tIHRoZSBQMk0NCj4gcG9vbCIpDQo+ID4gU3VnZ2VzdGVkLWJ5OiBKdWxp
ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEhlbnJ5IFdh
bmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCj4gPiAtLS0NCj4gPiBUaGlzIHNob3VsZCBhbHNvIGJl
IGJhY2twb3J0ZWQgdG8gNC4xMywgNC4xNCwgNC4xNSBhbmQgNC4xNi4NCj4gPiAtLS0NCj4gPiAg
eGVuL2FyY2gvYXJtL2RvbWFpbi5jIHwgMTQgKysrKysrKysrKysrKysNCj4gPiAgMSBmaWxlIGNo
YW5nZWQsIDE0IGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9h
cm0vZG9tYWluLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4gPiBpbmRleCAyYzg0ZTZkYmJi
Li5lNDBlMmJjYmExIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiA+
ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiA+IEBAIC03NDAsNiArNzQwLDIwIEBAIGlu
dCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4gPiAgICAgICAgICBCVUco
KTsNCj4gPiAgICAgIH0NCj4gPg0KPiA+ICsgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5s
b2NrKTsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBIYXJkd2FyZSB1c2luZyBHSUN2MiBuZWVk
cyB0byBjcmVhdGUgYSBQMk0gbWFwcGluZyBvZiA4S0IgR0lDdjINCj4gYXJlYQ0KPiA+ICsgICAg
ICogd2hlbiB0aGUgZG9tYWluIGlzIGNyZWF0ZWQuIENvbnNpZGVyaW5nIHRoZSB3b3JzdCBjYXNl
IGZvciBwYWdlDQo+ID4gKyAgICAgKiB0YWJsZXMgYW5kIGtlZXAgYSBidWZmZXIsIHBvcHVsYXRl
IDE2IHBhZ2VzIHRvIHRoZSBQMk0gcGFnZXMgcG9vbA0KPiBoZXJlLg0KPiA+ICsgICAgICovDQo+
ID4gKyAgICBpZiAoIChyYyA9IHAybV9zZXRfYWxsb2NhdGlvbihkLCAxNiwgTlVMTCkpICE9IDAg
KQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHAybV9zZXRfYWxsb2NhdGlvbihkLCAwLCBOVUxM
KTsNCj4gPiArICAgICAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7DQo+ID4g
KyAgICAgICAgZ290byBmYWlsOw0KPiA+ICsgICAgfQ0KPiA+ICsgICAgc3Bpbl91bmxvY2soJmQt
PmFyY2gucGFnaW5nLmxvY2spOw0KPiANCj4gR2VuZXJhbGx5LCB0aGlzIHdvdWxkIGJlIGJldHRl
ciB3cml0dGVuIGFzDQo+IA0KPiBzcGluX2xvY2soKTsNCj4gaWYgKCByYyA9IHAybV9zZXRfYWxs
b2NhdGlvbigxNikgKQ0KPiDCoMKgwqAgcDJtX3NldF9hbGxvY2F0aW9uKDApDQo+IHNwaW5fdW5s
b2NrKCk7DQo+IA0KPiBpZiAoIHJjICkNCj4gwqDCoMKgIGdvdG8gZmFpbDsNCj4gDQo+IHRvIHJl
ZHVjZSB0aGUgbnVtYmVyIG9mIHNwaW5fdW5sb2NrKCkgY2FsbHMgYW5kIG1ha2UgdGhlIGVycm9y
IHBhdGhzDQo+IG1vcmUgY2xlYXIuwqAgSG93ZXZlci4uLg0KDQpJIHRoaW5rIGluIEFybSdzIGFy
Y2hfZG9tYWluX2NyZWF0ZSgpLCBhbGwgdGhlIGVycm9yIGhhbmRsaW5nIGFyZSB0aGUNCnNhbWUg
c3R5bGUgdXNpbmc6DQoNCmlmICggKHJjID0gPGZ1bmN0aW9uPikgIT0wICkNCiAgICBnb3RvIGZh
aWw7DQoNCmFuZCB3ZSBuZWVkIHRvIGtlZXAgdGhlbSB0aGUgc2FtZT8gQnV0IEkgdGhpbmsgSSB3
aWxsIGRyb3AgdGhlDQpwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwgTlVMTCk7IGFzIHRoZSBhcmNo
X2RvbWFpbl9kZXN0cm95KGQpIGluDQoNCmZhaWw6DQogICAgZC0+aXNfZHlpbmcgPSBET01EWUlO
R19kZWFkOw0KICAgIGFyY2hfZG9tYWluX2Rlc3Ryb3koZCk7DQoNCndpbGwgY2xlYW4tdXAgdGhl
IHBvb2wuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+ID4gKw0KPiA+ICAgICAgaWYg
KCAocmMgPSBkb21haW5fdmdpY19yZWdpc3RlcihkLCAmY291bnQpKSAhPSAwICkNCj4gPiAgICAg
ICAgICBnb3RvIGZhaWw7DQo+ID4NCj4gDQo+IC4uLiB5b3UndmUgZ290IGEgcHJvYmxlbSBvbiB0
aGlzIGVycm9yIHBhdGgsIHNvIHRoZSBzZXQgYWxsb2NhdGlvbiB0byAwDQo+IG5lZWRzIHRvIGJl
IGluIHRoZSBmYWlsOiBwYXRoIHdpdGggc3VpdGFibGUgbG9ja2luZy4NCj4gDQo+IFRoZXJlIGFy
ZSBwZXJoYXBzIGJldHRlciB3YXlzIG9mIGRvaW5nIGl0IGluIDQuMTUoPykgYW5kIGxhdGVyLCBi
dXQgbm90DQo+IGluIGVhcmxpZXIgdmVyc2lvbnMuwqAgQXMgdGhpcyBpcyBhIGZpeCB0byBhIGJ1
ZyBpbiBhIHNlY3VyaXR5IHBhdGNoLA0KPiBzaW1wbGljaXR5IGlzIGdlbmVyYWxseSB0aGUgYmV0
dGVyIGFwcHJvYWNoLg0KPiANCj4gfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:47:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:47:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421813.667453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuo8-0008Q1-VA; Thu, 13 Oct 2022 09:47:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421813.667453; Thu, 13 Oct 2022 09:47:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuo8-0008Pu-Rl; Thu, 13 Oct 2022 09:47:16 +0000
Received: by outflank-mailman (input) for mailman id 421813;
 Thu, 13 Oct 2022 09:47:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gb4P=2O=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1oiuo6-0008Po-Uw
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 09:47:15 +0000
Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com
 [2a00:1450:4864:20::533])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03bff0e3-4adc-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 11:47:13 +0200 (CEST)
Received: by mail-ed1-x533.google.com with SMTP id g27so1797560edf.11
 for <xen-devel@lists.xenproject.org>; Thu, 13 Oct 2022 02:47:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03bff0e3-4adc-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=WMxGgyKSPXgX14QdWonh6vKEYtzJ2E+2hpZMkL1+vAg=;
        b=aOaHX85oqrpq03UkXi4U2jFQnaNHB1n7I9+BIqgtfsk+Lqi2OQZDlVNklGeOG6t7lJ
         sP1jN7xOFfHAXh6/jBBcgxPw1YZNax1bpDclPOBy1h56xgz3gakHFAInqdh2xEo+c4Mv
         3JTfeeCm/dIibBWfs3SGSWqvXT5f8lCfeJF2QWvgy+Qb/TaNTh2Ss8e5wA1CjyFcmzM1
         0Yyf264xXufSLrZ6aT48JCE0RykeWLA5YhcodxMeUn3MWLSQ3JbuqftehSBwXtTs8qvc
         NwlYFZFgObEQ9/nUFwRT2vF+AJFXcPuKzwu24qx2r0tNSg4UtdHR2RtDWubeIPWFNlug
         e1tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=WMxGgyKSPXgX14QdWonh6vKEYtzJ2E+2hpZMkL1+vAg=;
        b=E6x7E+KxtZhCD2rVe6kHtzUEaKoST0NbImCWQYf1JvfDJIUu6+Gn51fuASQkFGZci8
         s1ozgnSC3K04YApxweXV6ZZMXJGb/grbZwAnXvjhML7B85fkK0DzMh1I/V9yMp1bjPZA
         VPET+X31NvXJeWx/PdcXpC5A35zMHNXEGbpVvPlwMOy9AkjkH/WZqP3J1WGVX1jy4nE1
         csvCW9jEgR+vtzwcyg3rI8lHAyjCUxQ4gKgNfOepufMjOtwVTUxYnvohUr2u63HiMV1V
         HGX/qAriP5mYJxlkEVj9RbOzrlx+LXYwYrRlD3sWhWreVoXjjNiefCVdcdWzxIl7u9em
         ouow==
X-Gm-Message-State: ACrzQf2wAFLwy6Od8P0yHt4qVIYpYgp7UU5ZBxxdj2Z7gtcNzoyuZRMb
	hb9lGdWmIKkkt1iWgtPQXfG9OXck7KI0/+DEcC2CZQ==
X-Google-Smtp-Source: AMsMyM6Zyi/ntFev8wMj+LBsEC0fcx3X1rtfq5+XvO7k40Ugy1i63uuPHp8RQoPEjlwlpEob0+4lOPICJBjRVemMurI=
X-Received: by 2002:a05:6402:190f:b0:45b:d959:e2ae with SMTP id
 e15-20020a056402190f00b0045bd959e2aemr23423681edz.187.1665654433167; Thu, 13
 Oct 2022 02:47:13 -0700 (PDT)
MIME-Version: 1.0
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-7-carlo.nonato@minervasys.tech> <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com>
 <CAG+AhRUJ0+CszWjSzO7=v4SmKtjG7VMpZ8P050s-rLz0rgXJBw@mail.gmail.com> <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com>
In-Reply-To: <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com>
From: Carlo Nonato <carlo.nonato@minervasys.tech>
Date: Thu, 13 Oct 2022 11:47:02 +0200
Message-ID: <CAG+AhRWXi8V142aSx_P1cjyaXTb+CnS-EOB_o8c4Y7ZkBt7Gkg@mail.gmail.com>
Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for domains
To: Jan Beulich <jbeulich@suse.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org, 
	stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, 
	andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, 
	Marco Solieri <marco.solieri@minervasys.tech>
Content-Type: text/plain; charset="UTF-8"

Hi Jan


On Mon, Sep 19, 2022 at 8:26 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 16.09.2022 18:05, Carlo Nonato wrote:
> > On Thu, Sep 15, 2022 at 3:13 PM Jan Beulich <jbeulich@suse.com> wrote:
> >> On 26.08.2022 14:51, Carlo Nonato wrote:
> >>> --- a/xen/arch/arm/coloring.c
> >>> +++ b/xen/arch/arm/coloring.c
> >>> @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config,
> >>>      config->num_colors = (uint16_t)num;
> >>>  }
> >>>
> >>> +unsigned int page_to_color(struct page_info *pg)
> >>
> >> The parameter will want to be pointer-to-const and I wonder whether ...
> >>
> >>> +{
> >>> +    return addr_to_color(page_to_maddr(pg));
> >>> +}
> >>
> >> ... the function as a whole wouldn't be a good candidate for being an
> >> inline one (requiring addr_to_color() to be available in outside of
> >> this file, of course).
> >
> > You mean defining it as static inline in the coloring.h header?
>
> That would seem preferable for a simple function like this one.
>

I didn't want to expose that function since I would also have to expose
the addr_col_mask global variable.
Same goes for get_max_colors(): it exist only for the purpose to restrict
the max_colors variable visibility.

> >>> +    page_list_for_each( pos, head )
> >>> +    {
> >>> +        if ( page_to_maddr(pos) < page_to_maddr(pg) )
> >>> +        {
> >>> +            head = &pos->list;
> >>> +            break;
> >>> +        }
> >>> +    }
> >>
> >> Wait - a linear search for every single page insertion? How well
> >> is that going to perform on a multi-terabyte system?
> >
> > For our test cases (embedded systems) the linear search is good enough.
> > I agree with you that in the general case this is bad (even though the main
> > targets are indeed embedded systems).
> > Are there any already available data structures that we can exploit to get
> > better performances?
>
> I'm afraid there aren't any that I would see as a good fit here.
>

Regarding this I can see three options:
1) We leave it as it is and we warn the user in the docs that cache coloring
   is embedded system specific for the moment since it has, probably, bad
   performances with bigger systems.
2) We use some priority queue implementation to replace the actual lists.
   Red/black trees are available in Xen codebase, but I think I would have
   to change the page_info struct to use them.
   Maybe just a binary heap implemented as an array could be viable, but that
   would require me to implement somewhere the logic for insertion,
   extract-min and other operations.
3) I have a working prototype of a buddy allocator that also makes use of
   coloring information. It isn't an extension of the main one, but rather a
   simpler version. This means that nodes, zones, scrubbing, aren't
   supported, but this is true also for the already submitted colored
   allocator. With this, order > 0 pages can be served (up until
   log2(max_colors)) and insertion is no more linear, but constant instead.

>
> Jan

Thanks

- Carlo Nonato


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 09:55:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 09:55:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421822.667470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuve-0001Rp-Po; Thu, 13 Oct 2022 09:55:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421822.667470; Thu, 13 Oct 2022 09:55:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiuve-0001Ri-MB; Thu, 13 Oct 2022 09:55:02 +0000
Received: by outflank-mailman (input) for mailman id 421822;
 Thu, 13 Oct 2022 09:55:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuvd-0001RY-5s; Thu, 13 Oct 2022 09:55:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuvd-0003yQ-2V; Thu, 13 Oct 2022 09:55:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuvc-0005m8-Nj; Thu, 13 Oct 2022 09:55:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiuvc-0005lO-Kb; Thu, 13 Oct 2022 09:55:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=O1Uobu2LJIFOf4IcVynxalihP6/I6ywa+DKjFV14gRM=; b=XctJFR7h3yeK5rPvXlKcIknHMs
	bYWeVDljbk/u6Eqm88J0pmgdoIgSq4p6wjZRUip9Ddw/EuMHrYzlwVYSxFXy8F/uCwewcyO1uIhBI
	E2jDVYEwNppwIN5sTmDSf+urOxfqI9zJH3t1LEx3hsJ5kck6ZQ0dSL3qF46RnDInHfQ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173688-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173688: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=448d28309f1a966bdc850aff1a637e0b79a03e43
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 09:55:00 +0000

flight 173688 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173688/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  448d28309f1a966bdc850aff1a637e0b79a03e43
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    5 days
Failing since        173492  2022-10-11 13:01:50 Z    1 days   10 attempts
Testing same since   173619  2022-10-12 20:07:50 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 446 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 10:09:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 10:09:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421830.667481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiv93-0003Gb-WC; Thu, 13 Oct 2022 10:08:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421830.667481; Thu, 13 Oct 2022 10:08:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiv93-0003GU-TS; Thu, 13 Oct 2022 10:08:53 +0000
Received: by outflank-mailman (input) for mailman id 421830;
 Thu, 13 Oct 2022 10:08:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiv92-0003GK-Ju; Thu, 13 Oct 2022 10:08:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiv92-0004Io-GU; Thu, 13 Oct 2022 10:08:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiv92-00078W-6g; Thu, 13 Oct 2022 10:08:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiv92-000504-6C; Thu, 13 Oct 2022 10:08:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ovTup5Ny+Vc7pCHaiyUo8+/SDVgLCQqvKAP84Te+TWg=; b=ewnek5hk7UnNCN7eLcnTTOaSME
	PQPMn1O0Wv2TG1OoMc53pyPDJy3l2ywsyC/dTu6lp1ijIPtpEM9/+PuPvR0Ht9xBkLkz29HKmjOFy
	QLDZg/IxLzDFm7M1JR8WucXx+SqEmxB4eu8gxDbaNsptG+KvAmu6ZzFwNv3I51q3RKhw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173603-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173603: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 10:08:52 +0000

flight 173603 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173603/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 173603
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl-vhd      17 guest-start/debian.repeat  fail pass in 173511

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   55 days
Testing same since   173493  2022-10-11 13:07:01 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 10:12:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 10:12:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421839.667492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oivC6-0004i6-KJ; Thu, 13 Oct 2022 10:12:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421839.667492; Thu, 13 Oct 2022 10:12:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oivC6-0004hz-GV; Thu, 13 Oct 2022 10:12:02 +0000
Received: by outflank-mailman (input) for mailman id 421839;
 Thu, 13 Oct 2022 10:12:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=peYI=2O=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1oivC5-0004gM-2T
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 10:12:01 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7890a505-4adf-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 12:11:58 +0200 (CEST)
Received: from DB9PR01CA0018.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:1d8::23) by PAXPR08MB6622.eurprd08.prod.outlook.com
 (2603:10a6:102:153::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 10:11:50 +0000
Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d8:cafe::57) by DB9PR01CA0018.outlook.office365.com
 (2603:10a6:10:1d8::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Thu, 13 Oct 2022 10:11:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 10:11:49 +0000
Received: ("Tessian outbound 86cf7f935b1b:v128");
 Thu, 13 Oct 2022 10:11:49 +0000
Received: from a54d251035a6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6A98A14C-18B7-4050-A53A-2C45357DF016.1; 
 Thu, 13 Oct 2022 10:11:38 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a54d251035a6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 10:11:38 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by AM8PR08MB5761.eurprd08.prod.outlook.com (2603:10a6:20b:1d0::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 10:11:36 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 10:11:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7890a505-4adf-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Kzrnl+C+dulUs5ODa3Igh4XHQk2r+Emxa1hr0jqQyLC8zigDKwNJujthudJ8cUb0CldVu8qwRVfLL/091zGnBQdO444Rurp0YFOcLkMtW6IVxNhsRzYSQZMh8tgoBPMAb77R8h6CJHfpTqIyDSvCHY8rYpQaNdbS7nbR0Pm1a1LQZMjMjCoP7jrsJa/L81zeJqAyvf1WtFZCIWcuY4jcclvX32c7yaXEjDJRqOmKPoOiL7Emyf1q2G3rKzjq8h08+pmryC48ozaSxtKck+SiusZbjAlTqCcbourLQ3sqH2j2p0PJZ4hhmbn/Fpz9a1c9l/n5uAZiIbZT4GJpJzeD/g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4D/J+gHHfOy7VYgI8Ai3xwgX82b4PFxb4xxT+U7GhkA=;
 b=YxS/wAjt08JydcQykBe8pWmxa663k0D5K+JgT/LAE8BA2wOFIQbNGIvblmuOUrCE8W6qOCxkxSrQQWCBkPtrmioDfTFusJn3jNQmmfuexk1q4VWZd0AfVjk8s7zPFDwZaXS1MP0F23VU/MbnIBMG/YWIkq1x2/hPBmtBGv10C3Fm/o88iH4XvdjBWLvnIV6spnlaYf/D3nmaVb0F0mv0LGBDLLyhzLPUdU5nP83Qlsz7r8nzsUcVd7BaD3a8CGkMtdDiXAcsqvU/MnNtTtniMZpOQVsT21m82JZPwp+ah/CWpJz9sZTe3D52WwM5gOBzgeuaJu/PrEbvG+1fFbOb+g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4D/J+gHHfOy7VYgI8Ai3xwgX82b4PFxb4xxT+U7GhkA=;
 b=1BbxRIc5+9esZuxC9uvIYD7Lu4LDD5lF1jeodadCIayvOAlWKaeFGLWiK+Txfmz6Uo8IhMmVpnptbdT+5xxmAZcJaSXXrlqN+9tJFfvASsLgE5+d6/bkjxJHCusaGp0lMHlQeC/q7q+Mj5mmW4YnCyvBO7VPdlc4dvqnOPL06Nk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9f3633580c9a18a5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RVT9UMH8fkWiW+Ci8U/50cIhGhlANN/3Qc0YnKuIHRGfQKQ6t0CZHkAe+L9Ufta50L1qDDTDjM28/ogmzn+0XFr44OaMJeXDaUxR6Tma602z0PmkQqDG3Rbd5oVg83GVIaTfcIP+Sng1V/K+Uc/JJlDhY84CMFAwNwystWfr/VPaccXtgrMlq1VSemU9RMapNUkFuxVGlCLe09Wv4/bypS8VCmmjU2dHxEiyx7sYqDWVOkJ0W5EfX9Ey8LyfYP6oBVUQdNrUIgfeHvpY8oEaEMWIa+++emTR4fOfWVDxZC4/w59sqWoht1IQ7V1Tb5UCovarClXBHkg8/jaU4ukSbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4D/J+gHHfOy7VYgI8Ai3xwgX82b4PFxb4xxT+U7GhkA=;
 b=KEmkCHXAp/5aPcHoamuwxnzjjHOLIzgLymxJHwZr3yiB8VKaNPAGBjUqvegURcsabOqE02iD9gxA51Ru0X8lE6jhP11Dc9vxIO0ifpy/xoHhNKX0rjWv8v5ae/ShM5QU4WimELbZr42TzBPUxiHp82RV3IS/u8TCY/BkxQ6A3CEB0J7y2IfFttcnAnrrnLbaizZn/1rHY0iD4WHRDTRhDsUOmUKTlXlcluQkqq3wg+vmXxXZEAVsvXOjm9YI+QK/4t4Lr6GpTUMN9b0m+/EVOWcVujZErMbpcdcy5eJeZWOfGagFignZSycJp8sTOpwMGafg9p0aWt3Xqi+Jf4bH+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4D/J+gHHfOy7VYgI8Ai3xwgX82b4PFxb4xxT+U7GhkA=;
 b=1BbxRIc5+9esZuxC9uvIYD7Lu4LDD5lF1jeodadCIayvOAlWKaeFGLWiK+Txfmz6Uo8IhMmVpnptbdT+5xxmAZcJaSXXrlqN+9tJFfvASsLgE5+d6/bkjxJHCusaGp0lMHlQeC/q7q+Mj5mmW4YnCyvBO7VPdlc4dvqnOPL06Nk=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index: AQHY3lPHTZwvWtdyCU+0K6Hw9nMyM64L9DeAgAAneoA=
Date: Thu, 13 Oct 2022 10:11:36 +0000
Message-ID: <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
In-Reply-To: <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|AM8PR08MB5761:EE_|DBAEUR03FT013:EE_|PAXPR08MB6622:EE_
X-MS-Office365-Filtering-Correlation-Id: bdfc0d3f-056c-4aeb-a550-08daad0357ba
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CNoWUY4dkIDpwfhvc+iVxkT/4yiAasKIYC5VWtrzSEKkWdDyJ9vap2Y85VnbhQi4qAgWOrMlkGWYckFl0XT4PFY5XX6RCiTKPOq3nSVhu6nRn8mH+oQYghcVL9tyXrlrp57kteF60QFLuNUz0ZqTl80a5y+2TRcIOP8LqA0HUE2exXHN95vWeDsEgDmSAa0K3hL30GgaBwtJ3c85Ix3Zg3+LO/TqMpVRSeY6Do7BjiRruXgaLNaPPR8U1rVx3PvVL45vqd6lbhB77ILE9Pn6U/svFZw83CbrpmBWT8trJyMfnHKUL7SEcXYu2kaTAnFEhWD/ZTgrdOTkWYNvz0f7wyy+gRVXg1+020HM+o5EuHk9uz0DjN0H3h+9hEMiwwrUbwNiEStouxRMOtMJnQuyLyyL6gojERmZWWXyASSkD4Hs6oMAiqMLouPVp/XbmkcvgsQ76pmW5lzN3cNenh0M8jzoxaSGfTiFAuSh/z2MDkck8oZHCxpDP2xiuG6lWff2RfoyIGilNX20A8pBBQgqjrXVF0U7BBosuU9S8Vu/y1ysMM/I/lOfi9tM/ZR5Nn5+7akOjuHdD4v+IGZcFjHADDfNZ9lkuRY0v73YroX1k6RF2turWGxl/6L7ESCBgbArqsy+mhFFiyH9Fsz/0fkTVM00ui333dUxBMF7jTOEO7cBbvwnefGcEo8MOQyq8rBKWUB6Agpq8ArA3JOI5CXzUdjbmK/4u8daVPWehSEM6KV2XcZNUelVVyLGcf6RsPFe1BSNCJHS3z+JPCyewzCTjFqSuVZKaVEjklhol49VEuVf+GGYT61EXZ4OiCkmHkAkMeuj1YmqCfDyX75jK9T/+g==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(316002)(478600001)(6916009)(54906003)(71200400001)(6486002)(966005)(91956017)(66556008)(4326008)(8676002)(64756008)(66446008)(66476007)(66946007)(76116006)(6512007)(8936002)(26005)(53546011)(41300700001)(186003)(30864003)(5660300002)(6506007)(2906002)(2616005)(83380400001)(36756003)(122000001)(38100700002)(33656002)(86362001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <73ED9BD221660D42B43D77F17A0E2C75@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5761
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d8791643-7f52-4503-667d-08daad034ff0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CIaB07s700AZ9ifSIU274RIOttHEzzedD15KvZyPbqZsjJD32g6HyJnnXpuG0Gp8dRJOuWfnjvVyD71iwmCWU00lrEtXcChyTIkILabcRF5yqN3PoSw222SRZlu12gOz5aMTC+8+fHEKQS7YMDrahiZrwXyhNHUVbXA0KCzJgmoZhH5eZiB3AQekJk7DaILpgc8BjAeMuUmUWT95X0Ab5nyOBI3Hh4WnKOCATCB0irRXh2Ev4ED8Ro6x7ejdh5dN5bPr2BAPDKqynBUPWyEpy6IVmjqGhpcfQM3TijodQdCNMoSrtXpXMGWppCHjrXVp8cNr6uci7I661NdFUSgBU+A9lUFcNt9gHFnkFwgFU33mHxc6InBo1ybKlD+/8xaLmCk9SHiZp5yCvW7HQ6mJtl7xJIlysR3S3oRuhmWOuCG+5Ugs6HG3NFXZxlTiQND7DYIFYH9H81A+gBPQehwOcRvjMS0YrBsio524xTv9wt/1eDzBV9cgvLHc04MDgHiSXy73D3FZy5znNE4sohHMxsixQYzIWWcSXAO/jqaW/bvsAl7Ta3F1i+bGaDWB65/H2V/yzMKusi7pK+KU7yp7rAF3EyH+nJx9qyzDznW2apYRD9GDV8/Vo989ko3ASa+r6XWRHK5ZJk64UAyVQ10QI7kZi5sReFsR9LzcdJc1dGVp18RzCkpAfasF0KYL41OGuWT3g7BnDtSecds+mTE9kpjR7qOf49OpHhTjeCbUWm2K1Lb+dbWxUouMKAd8Na8mhDpbXVC8ko+CBPb424Wkh520Q0ZLIfMqANLx0Z6bjAw=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(5660300002)(30864003)(336012)(186003)(2906002)(2616005)(41300700001)(6506007)(8936002)(6512007)(26005)(6862004)(36756003)(81166007)(356005)(53546011)(82310400005)(82740400003)(33656002)(86362001)(40460700003)(40480700001)(47076005)(83380400001)(36860700001)(478600001)(6486002)(966005)(316002)(70206006)(54906003)(70586007)(4326008)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 10:11:49.4547
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bdfc0d3f-056c-4aeb-a550-08daad0357ba
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6622

SGkgSmFuLA0KDQo+IE9uIDEzIE9jdCAyMDIyLCBhdCAwODo1MCwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDEyLjEwLjIwMjIgMTg6MDAsIEx1Y2EgRmFu
Y2VsbHUgd3JvdGU6DQo+PiBEb2N1bWVudGluZyB2aW9sYXRpb25zDQo+PiA9PT09PT09PT09PT09
PT09PT09PT09DQo+IA0KPiBJIGV4cGVjdCB0aGlzIGlzIG1lYW4gdG8gYmVjb21lIGFuIGluLXRy
ZWUgZG9jdW1lbnQgYXQgc29tZSBwb2ludD8NCg0KWWVzLCB0aGlzIHdpbGwgYmVjb21lIHBhcnQg
b2YgdGhlIGRvY3VtZW50YXRpb24gYXQgc29tZSBwb2ludC4NCg0KPiANCj4+IFN0YXRpYyBhbmFs
eXNlcnMgYXJlIHVzZWQgb24gdGhlIFhlbiBjb2RlYmFzZSBmb3IgYm90aCBzdGF0aWMgYW5hbHlz
aXMgYW5kIE1JU1JBDQo+PiBjb21wbGlhbmNlLg0KPj4gVGhlcmUgbWlnaHQgYmUgdGhlIG5lZWQg
dG8gc3VwcHJlc3Mgc29tZSBmaW5kaW5ncyBpbnN0ZWFkIG9mIGZpeGluZyB0aGVtIGFuZA0KPj4g
bWFueSB0b29scyBwZXJtaXQgdGhlIHVzYWdlIG9mIGluLWNvZGUgY29tbWVudHMgdGhhdCBzdXBw
cmVzcyBmaW5kaW5ncyBzbyB0aGF0DQo+PiB0aGV5IGFyZSBub3Qgc2hvd24gaW4gdGhlIGZpbmFs
IHJlcG9ydC4NCj4+IA0KPj4gWGVuIGluY2x1ZGVzIGEgdG9vbCBjYXBhYmxlIG9mIHRyYW5zbGF0
aW5nIGEgc3BlY2lmaWMgY29tbWVudCB1c2VkIGluIGl0cw0KPj4gY29kZWJhc2UgdG8gdGhlIHJp
Z2h0IHByb3ByaWV0YXJ5IGluLWNvZGUgY29tbWVudCB1bmRlcnN0YW5kYWJsZSBieSB0aGUgc2Vs
ZWN0ZWQNCj4+IGFuYWx5c2VyIHRoYXQgc3VwcHJlc3MgaXRzIGZpbmRpbmcuDQo+IA0KPiBJcyB0
aGF0IHRvb2wgaW4gdGhlIHRyZWUgYWxyZWFkeT8NCg0KTm90IHlldCwgaXQgd2lsbCBiZSBwYXJ0
IG9mIHRoZSB0cmVlIHdoZW4gSSB3aWxsIHNlbmQgdGhlIGltcGxlbWVudGF0aW9uIHRoYXQgd2ls
bCBiZSBzaGFwZWQNCmJ5IHRoaXMgZGlzY3Vzc2lvbi4gSGVyZSBpdCB3YXMgbXkgZmF1bHQgdG8g
d3JpdGUgc2VudGVuY2Ugd2l0aCBwcmVzZW50IHZlcmJzIGluc3RlYWQgb2YNCmZ1dHVyZS4NCg0K
PiANCj4+IEluIHRoZSBYZW4gY29kZWJhc2UsIHRoZXNlIHRhZ3Mgd2lsbCBiZSB1c2VkIHRvIGRv
Y3VtZW50IGFuZCBzdXBwcmVzcyBmaW5kaW5nczoNCj4+IA0KPj4gLSBTQUYtWC1zYWZlOiBUaGlz
IHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxpbmUgb2YgY29kZSBjb250YWlucyBhIGZpbmRpbmcs
IGJ1dA0KPj4gIHRoZSBub24gY29tcGxpYW5jZSB0byB0aGUgY2hlY2tlciBpcyBhbmFseXNlZCBh
bmQgZGVtb25zdHJhdGVkIHRvIGJlIHNhZmUuDQo+PiAtIFNBRi1YLWZhbHNlLXBvc2l0aXZlOiBU
aGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxpbmUgb2YgY29kZSBjb250YWlucyBhDQo+PiAg
ZmluZGluZywgYnV0IHRoZSBmaW5kaW5nIGlzIGEgYnVnIG9mIHRoZSB0b29sLg0KPiANCj4gV2Ug
ZGlkIGRpc2N1c3MgdGhpczogRmFsc2UgcG9zaXRpdmVzIGFyZSBvZnRlbiBzcGVjaWZpYyB0byBq
dXN0IG9uZSBvZiB0aGUNCj4gdG9vbHMgdXNlZC4gSSB0aGluayB0aGlzIHdhbnRzIG1lbnRpb25p
bmcgaGVyZSwgaW5jbHVkaW5nIHRoZSBpbXBsaWNhdGlvbnMNCj4gKGlpcmMgdGhlIHBsYW4gd2Fz
IHRvIGtlZXAgdGhlIHRhZyBnZW5lcmljIGJ1dCBtYWtlIHRoZSB0YWJsZSBlbnRyeSBleHByZXNz
DQo+IHdoaWNoIHRvb2wgaXQgaXMgdGhhdCBpcyBhZmZlY3RlZCkuDQoNClllcywgaW4gdGhlIGRh
dGFiYXNlIGZvcm1hdCBiZWxvdywgYSBmYWxzZSBwb3NpdGl2ZSBlbnRyeSB3aWxsIGhhdmUgaXRz
IGtleS12YWx1ZSBpdGVtDQppbiB0aGUg4oCcYW5hbHlzZXLigJ0gZGljdGlvbmFyeS4gTW9yZW92
ZXIsIGEgZmFsc2UgcG9zaXRpdmUgZW50cnkgY291bGQgYmUgd3JpdHRlbiBmb3INCmV4YW1wbGUg
YXMgdGhlIGxpbmUgYmVsb3csIHRvIHN1cHByZXNzIGEgY3BwY2hlY2sgZmFsc2UgcG9zaXRpdmUg
Zm9yIE1JU1JBIHJ1bGUgMjAuNzoNCg0KLyogU0FGLTAtZmFsc2UtcG9zaXRpdmUgY3BwY2hlY2sg
ZmFsc2UtcG9zaXRpdmUgZm9yIHJ1bGUgMjAuNyAqLw0KDQpDbGVhcmx5IHRoaXMgY29tbWVudCB3
YW50cyB0aGUgcHJvcGVyIGVudHJ5IGluIGZhbHNlLXBvc2l0aXZlLmpzb24gd2l0aCB0aGUgY29y
cmVjdCBpbnRlcm5hbCBJRA0KZm9yIHRoZSBydWxlIDIwLjcgZ2l2ZW4gYnkgY3BwY2hlY2ssIHRo
YXQgaXMg4oCcbWlzcmEtYzIwMTItMjAuN+KAnSwgYW5kIGEgcHJvcGVyIGp1c3RpZmljYXRpb24g
dGhhdA0KZXhwbGFpbnMgd2h5IGl04oCZcyBhIGJ1ZyBvZiB0aGUgdG9vbCBhbmQgbm90IGEgbm9u
LWNvbXBsaWFuY2Ugb2YgdGhlIGNvZGUuDQoNCj4gDQo+PiBTQUYgc3RhbmRzIGZvciBTdGF0aWMg
QW5hbHlzZXIgRmluZGluZywgdGhlIFggaXMgYSBwbGFjZWhvbGRlciBmb3IgYSBwb3NpdGl2ZQ0K
Pj4gbnVtYmVyIHRoYXQgc3RhcnRzIGZyb20gemVybywgdGhlIG51bWJlciBhZnRlciBTQUYtIHNo
YWxsIGJlIGluY3JlbWVudGFsIGFuZA0KPj4gdW5pcXVlLg0KPiANCj4gTml0OiAicG9zaXRpdmUg
bnVtYmVyIiBhbmQgInN0YXJ0cyBmcm9tIHplcm8iIGRvbid0IHJlYWxseSBmaXQgdG9nZXRoZXIu
DQo+IEkgZ3Vlc3MgeW91IGFsc28gd2FudCB0byBzcGVsbCBvdXQgdGhlIHJhZGl4IHRvIGJlIHVz
ZWQgYXMgd2VsbCBhcyB3aGV0aGVyDQo+IGxlYWRpbmcgemVyb3MgYXJlIGV4cGVjdGVkIChhbmQg
aWYgc28sIHRvIHBhZCB0byBob3cgbWFueSBkaWdpdHMgdG90YWwpLg0KDQpTaW5jZSB3ZSBkaWQg
cHV0IGEgc2VudGluZWwgc3RhcnRpbmcgZnJvbSB6ZXJvLCBJIGd1ZXNzIHdlIGNhbiBqdXN0IHNh
eSDigJxwb3NpdGl2ZSBudW1iZXLigJ0uDQpBIGdvb2QgcG9pbnQgaXMgdGhlIGxlYWRpbmcgemVy
b3MsIEkgZG9u4oCZdCBleHBlY3QgbGVhZGluZyB6ZXJvcyBhbmQgSSB3aWxsIHdyaXRlIGl0IGRv
d24gY2xlYXJseS4NCg0KPiANCj4+IEVudHJpZXMgaW4gdGhlIGRhdGFiYXNlIHNob3VsZCBuZXZl
ciBiZSByZW1vdmVkLCBldmVuIGlmIHRoZXkgYXJlIG5vdCB1c2VkDQo+PiBhbnltb3JlIGluIHRo
ZSBjb2RlIChpZiBhIHBhdGNoIGlzIHJlbW92aW5nIG9yIG1vZGlmeWluZyB0aGUgZmF1bHR5IGxp
bmUpLg0KPj4gVGhpcyBpcyB0byBtYWtlIHN1cmUgdGhhdCBudW1iZXJzIGFyZSBub3QgcmV1c2Vk
IHdoaWNoIGNvdWxkIGxlYWQgdG8gY29uZmxpY3RzDQo+PiB3aXRoIG9sZCBicmFuY2hlcyBvciBt
aXNsZWFkaW5nIGp1c3RpZmljYXRpb25zLg0KPiANCj4gQ2FuIHdlIGFkZCBwcm92aXNpb25zIGZv
ciBzaHJpbmtpbmcgc3VjaCBlbnRyaWVzIHRvIGUuZy4ganVzdCB0aGVpciAiaWQiDQo+IGxpbmU/
IE9yIGlzIHRoZSBpbnRlbnRpb24gdG8gYmUgYWJsZSB0byByZS11c2Ugc3VjaCBhbiBlbnRyeSBp
ZiBhIG1hdGNoaW5nDQo+IGluc3RhbmNlIGFwcGVhcnMgYWdhaW4gbGF0ZXI/DQoNCkkgcHJlZmVy
IHRvIGRvbuKAmXQgc2hyaW5rIGl0LCB0aGUgbmFtZSBpdHNlbGYgaXMgbm90IHZlcnkgbG9uZywg
ZXZlbiB1c2luZyBtYW55IGRpZ2l0cyBvZiB0aGUgaW5jcmVtZW50YWwNCm51bWJlciwgaXQgcmVt
b3ZlcyBhbHNvIHRoZSBkZXBlbmRlbmN5IG9uIHRoZSBmaWxlIG5hbWUuDQoNCj4gDQo+PiBUaGUg
ZmlsZXMgd2hlcmUgdG8gc3RvcmUgYWxsIHRoZSBqdXN0aWZpY2F0aW9ucyBhcmUgaW4geGVuL2Rv
Y3MvbWlzcmEvIGFuZCBhcmUNCj4+IG5hbWVkIGFzIHNhZmUuanNvbiBhbmQgZmFsc2UtcG9zaXRp
dmUuanNvbiwgdGhleSBoYXZlIEpTT04gZm9ybWF0Lg0KPiANCj4gQW5kIGJvdGggdXNlIGluZGVw
ZW5kZW50IElEIG51bWJlcmluZz8NCg0KWWVzLCBJIHdpbGwgYWRkIHRoaXMuDQoNCj4gDQo+PiBI
ZXJlIGlzIGFuIGV4YW1wbGUgdG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb246Og0KPj4gDQo+PiB8
ew0KPj4gfCAgICAidmVyc2lvbiI6ICIxLjAiLA0KPj4gfCAgICAiY29udGVudCI6IFsNCj4+IHwg
ICAgICAgIHsNCj4+IHwgICAgICAgICAgICAiaWQiOiJTQUYtMC1zYWZlIiwNCj4gDQo+IElzIHRo
ZSBTQUYtIHByZWZpeCByZWFsbHkgbmVlZGVkIGhlcmU/IEFuZCB3aXRoICJzYWZlIiBhbmQgImZh
bHNlIHBvc2l0aXZlIg0KPiBiZWluZyBpbiBzZXBhcmF0ZSBmaWxlcywgaXMgdGhlIHJlc3BlY3Rp
dmUgc3VmZml4IGhlcmUgbmVlZGVkIGVpdGhlcj8gSQ0KPiB0aGluayB0aGUgZmlsZSBzaG91bGQg
YmUgYXMgY2x1dHRlciBmcmVlIGFzIHBvc3NpYmxlLCBjb25zaWRlcmluZyB0aGF0IGl0J2xsDQo+
IGdyb3cgdG8gcXVpdGUgc2lnbmlmaWNhbnQgc2l6ZSBmcm9tIGFsbCBJIGNhbiB0ZWxsIHJpZ2h0
IG5vdy4NCj4gDQo+PiB8ICAgICAgICAgICAgImFuYWx5c2VyIjogew0KPj4gfCAgICAgICAgICAg
ICAgICAiY3BwY2hlY2siOiAibWlzcmEtYzIwMTItMjAuNyIsDQo+PiB8ICAgICAgICAgICAgICAg
ICJjb3Zlcml0eSI6ICJtaXNyYV9jXzIwMTJfcnVsZV8yMF83X3Zpb2xhdGlvbiIsDQo+PiB8ICAg
ICAgICAgICAgICAgICJlY2xhaXIiOiAiTUMzUjEuUjIwLjciDQo+PiB8ICAgICAgICAgICAgfSwN
Cj4+IHwgICAgICAgICAgICAibmFtZSI6IOKAnFIyMC43IEMgbWFjcm8gcGFyYW1ldGVycyBub3Qg
dXNlZCBhcyBleHByZXNzaW9uIiwNCj4gDQo+IFdoYXQgaXMgdGhlIHNlY29uZCBzdHJpbmcgaGVy
ZSBzdXBwb3NlZCB0byBleHByZXNzPyBUaGUgZXhwbGFuYXRpb24gYmVsb3cNCj4gZG9lc24ndCBy
ZWFsbHkgY2xhcmlmeSB0aGF0LCBhbmQgdGhlIGV4YW1wbGUgaGVyZSBkb2Vzbid0IHNlZW0gdG8g
Zml0IHRoZQ0KPiBSMjAuNyBzdWJqZWN0LiBNYXliZSBpdCB3b3VsZCBoYXZlIGhlbHBlZCBpZiAu
Li4NCj4gDQo+PiB8ICAgICAgICAgICAgInRleHQiOiAiVGhlIG1hY3JvIHBhcmFtZXRlcnMgdXNl
ZCBpbiB0aGlzIFvigKZdIg0KPiANCj4gLi4uIHlvdSBoYWRuJ3QgbGVmdCB0aGlzIGFicmlkZ2Vk
Lg0KDQpUaGUganVzdGlmaWNhdGlvbiB0ZXh0IGNvdWxkIGJlIGxvbmcsIHNvIHRoZSBuYW1lIGlz
IHN1cHBvc2VkIHRvIGJlIGp1c3QgdGhlIHN1YmplY3QNCm9mIHRoZSBqdXN0aWZpY2F0aW9uLCBh
IHZlcnkgc2hvcnQgaW50cm9kdWN0aW9uIHRoYXQgY291bGQgYmUgcmVjYWxsZWQsIHRoZSB0ZXh0
IGluc3RlYWQgaXMNCnRoZSBhbmFseXNpcyB0aGF0IGxlYWRzIHRvIHRoZSBkZWNpc2lvbiB0byBz
dXBwcmVzcyB0aGUgZmluZGluZy4NClRob3NlIGluZm9ybWF0aW9ucyB3aWxsIGJlIHRha2VuLCBp
biB0aGUgZnV0dXJlLCB0byBwcm9kdWNlIGEgcmVwb3J0IG9mIGV2ZXJ5IGRldmlhdGlvbg0KaW4g
dGhlIGNvZGUuDQoNCg0KPiANCj4gRnVydGhlcm1vcmUgYm90aCB0aGlzIGFuZCAuLi4NCj4gDQo+
PiB8ICAgICAgICB9LA0KPj4gfCAgICAgICAgew0KPj4gfCAgICAgICAgICAgICJpZCI64oCdU0FG
LTEtc2FmZSIsDQo+PiB8ICAgICAgICAgICAgImFuYWx5c2VyIjogew0KPj4gfCAgICAgICAgICAg
ICAgICAiY3BwY2hlY2siOiAidW5yZWFkVmFyaWFibGUiLA0KPj4gfCAgICAgICAgICAgICAgICAi
Y292ZXJpdHkiOiAiVU5VU0VEX1ZBTFVFIg0KPj4gfCAgICAgICAgICAgIH0sDQo+PiB8ICAgICAg
ICAgICAgIm5hbWUiOiDigJxWYXJpYWJsZSBzZXQgYnV0IG5vdCB1c2VkIiwNCj4+IHwgICAgICAg
ICAgICAidGV4dCI6IOKAnEl0IGlzIHNhZmUgYmVjYXVzZSBb4oCmXSINCj4gDQo+IC4uLiB0aGlz
IHJlbWluZHMgbWUgdGhhdCB0aGVyZSBtaWdodCBiZSBtdWx0aXBsZSBpdGVtcyBvbiB0aGUgcmVs
YXRlZA0KPiBzdWJzZXF1ZW50IHNvdXJjZSBsaW5lLCBvbmx5IG9uZSBvZiB3aGljaCBpcyBhY3R1
YWxseSBhZmZlY3RlZC4gSW4gdGhlDQo+IFNBRi0wLXNhZmUgY2FzZSBmb3IgZXhhbXBsZSBvbmx5
IHNvbWUgb2YgdGhlICJfdmFyIiB1c2VzIGluc2lkZSB0aGUgbWFjcm8NCj4gYXJlIG5vdCAoZGly
ZWN0bHkpIGV4cHJlc3Npb25zLCB3aGVyZWFzICJfbmFtZSIgaXMgdW5hZmZlY3RlZC4NCj4gDQo+
IFRha2luZyB0aGlzIGV4YW1wbGUgSSBhbHNvIGRhcmUgdG8gYXNrOiBTaG91bGRuJ3QgdG9vbHMg
YmUgYXdhcmUgdGhhdA0KPiB0b2tlbiBjb25jYXRlbmF0aW9uIG5lY2Vzc2FyaWx5IG1lYW5zIG5v
IHVzZSBvZiBwYXJlbnRoZXNlcz8gU2VlIGFsc28NCj4gYmVsb3cuDQoNClllcyB0aGUgdG9vbCBz
aG91bGQgYmUgYXdhcmUsIGluIHRoZSBleGFtcGxlIGJlbG93LCB0aGUgdG9vbCBpcyBjb21wbGFp
bmluZyBqdXN0DQpmb3IgdGhlIGxpbmVzIDc1IGFuZCA4MCwgaW4gdGhhdCBwYXJ0aWN1bGFyIGV4
YW1wbGUgSSB3b3VsZCBoYXZlIGZpeGVkIHRoZSBmaW5kaW5nDQppbnN0ZWFkIG9mIHVzaW5nIGEg
anVzdGlmaWNhdGlvbiwgYnV0IEnigJl2ZSByZXBvcnRlZCB0aGF0IGV4YW1wbGUganVzdCB0byBz
aG93IGhvdw0KdGhlIGZpbmRpbmcgY2FuIGJlIHN1cHByZXNzZWQuDQoNCkhlcmUgdGhlIGxpbmsg
dG8gZWNsYWlyOiBodHRwczovL2VjbGFpcml0LmNvbTozNzg3L2ZzL3Zhci9saWIvamVua2lucy9q
b2JzL1hFTi9jb25maWd1cmF0aW9ucy9heGlzLVRhcmdldC9BUk02NC9heGlzLWFnZW50L3B1Ymxp
Yy9idWlsZHMvNTQxL2FyY2hpdmUvRUNMQUlSL291dC9QUk9KRUNULmVjZDsvc291cmNlcy94ZW4v
aW5jbHVkZS94ZW4vcGFyYW0uaC5odG1sI0w3NV92aW9sYXRpb24NCg0KVGhlIGNvZGluZyBzdGFu
ZGFyZCB3YW50cyBqdXN0IHRvIGhhdmUgdGhpczoNCg0KI2RlZmluZSBzdHJpbmdfcGFyYW0oX25h
bWUsIF92YXIpIFwNCiBfX3NldHVwX3N0ciBfX3NldHVwX3N0cl8jI192YXJbXSA9IChfbmFtZSk7
IFwNCl9fa3BhcmFtIF9fc2V0dXBfIyNfdmFyID0gXA0KICAgICB7IC5uYW1lID0gX19zZXR1cF9z
dHJfIyNfdmFyLCBcDQogICAgICAgLnR5cGUgPSBPUFRfU1RSLCBcDQogICAgICAgLmxlbiA9IHNp
emVvZihfdmFyKSwgXA0KICAgICAgIC5wYXIudmFyID0gJihfdmFyKSB9DQoNCj4gDQo+IEFsc28g
dHdvIGZvcm1hdHRpbmcgcmVtYXJrczogSW4gdGhlIGV4YW1wbGUgYWJvdmUgeW91IGludGVybWl4
ICIsIOKAnSwgYW5kIOKAnC4NCj4gQXJlIHRoZXNlIGZpbmUgdG8gdXNlIGF0IHdpbGw/IEFuZCBj
YW4gd2UgYWltIGF0IGJlaW5nIGNvbnNpc3RlbnQgd2l0aCB0aGUNCj4gdXNlIG9mIHBhZGRpbmcg
YmxhbmtzICh5b3UgaGF2ZSB0aGVtIGFmdGVyIHNvbWUgOiBidXQgbm90IGFmdGVyIG90aGVycyk/
DQoNCkZvciBjb25zaXN0ZW5jeSBpdCBpcyBleHBlY3RlZCB0byB1c2UgdGhlIHNhbWUgZm9ybWF0
LCBoZXJlIHdhcyBteSBtaXN0YWtlLA0KSSB0ZW5kIHRvIGFncmVlIHRvIGxlYXZlIGEgc3BhY2Ug
YWZ0ZXIgdGhlIHRoZSBjb2xvbiBjaGFyYWN0ZXIuDQoNCj4gDQo+PiB8ICAgICAgICB9LA0KPj4g
fCAgICAgICAgew0KPj4gfCAgICAgICAgICAgICJpZCI64oCdU0FGLTItc2FmZSIsDQo+PiB8ICAg
ICAgICAgICAgImFuYWx5c2VyIjoge30sDQo+PiB8ICAgICAgICAgICAgIm5hbWUiOiAiU2VudGlu
ZWwiLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0IjogIiINCj4+IHwgICAgICAgIH0NCj4+IHwgICAg
XQ0KPj4gfH0NCj4+IA0KPj4gVG8gZG9jdW1lbnQgYSBmaW5kaW5nLCBqdXN0IGFkZCBhbm90aGVy
IGJsb2NrIHtbLi4uXX0gYmVmb3JlIHRoZSBzZW50aW5lbCBibG9jaywNCj4+IHVzaW5nIHRoZSBp
ZCBjb250YWluZWQgaW4gdGhlIHNlbnRpbmVsIGJsb2NrIGFuZCBpbmNyZW1lbnQgYnkgb25lIHRo
ZSBudW1iZXINCj4+IGNvbnRhaW5lZCBpbiB0aGUgaWQgb2YgdGhlIHNlbnRpbmVsIGJsb2NrLg0K
Pj4gDQo+PiBIZXJlIGEgYnJpZWYgZXhwbGFuYXRpb24gb2YgdGhlIGZpZWxkIGluc2lkZSBhbiBv
YmplY3Qgb2YgdGhlICJjb250ZW50IiBhcnJheToNCj4+IC0gaWQ6IGl0IGlzIGEgdW5pcXVlIHN0
cmluZyB0aGF0IGlzIHVzZWQgdG8gcmVmZXIgdG8gdGhlIGZpbmRpbmcsIG1hbnkgZmluZGluZw0K
Pj4gIGNhbiBiZSB0YWdnZWQgd2l0aCB0aGUgc2FtZSBpZCwgaWYgdGhlIGp1c3RpZmljYXRpb24g
aG9sZHMgZm9yIGFueSBhcHBsaWVkDQo+PiAgY2FzZS4NCj4+ICBJdCB0ZWxscyB0aGUgdG9vbCB0
byBzdWJzdGl0dXRlIGEgWGVuIGluLWNvZGUgY29tbWVudCBoYXZpbmcgdGhpcyBzdHJ1Y3R1cmU6
DQo+PiAgLyogU0FGLTAtc2FmZSBbLi4uXSBcKi8NCj4+IC0gYW5hbHlzZXI6IGl0IGlzIGFuIG9i
amVjdCBjb250YWluaW5nIHBhaXIgb2Yga2V5LXZhbHVlIHN0cmluZ3MsIHRoZSBrZXkgaXMNCj4+
ICB0aGUgYW5hbHlzZXIsIHNvIGl0IGNhbiBiZSBjcHBjaGVjaywgY292ZXJpdHkgb3IgZWNsYWly
LiBUaGUgdmFsdWUgaXMgdGhlDQo+PiAgcHJvcHJpZXRhcnkgaWQgY29ycmVzcG9uZGluZyBvbiB0
aGUgZmluZGluZywgZm9yIGV4YW1wbGUgd2hlbiBjb3Zlcml0eSBpcw0KPj4gIHVzZWQgYXMgYW5h
bHlzZXIsIHRoZSB0b29sIHdpbGwgdHJhbnNsYXRlIHRoZSBYZW4gaW4tY29kZSBjb21lbnQgaW4g
dGhpcyB3YXk6DQo+PiAgLyogU0FGLTAtc2FmZSBbLi4uXSBcKi8gLT4gLyogY292ZXJpdHlbY292
ZXJpdHktaWRdIFwqLw0KPiANCj4gSW4gaGVyZSwgd2hlcmUgd291bGQgY292ZXJpdHktaWQgY29t
ZSBmcm9tPyBBbmQgaG93IGRvZXMgdGhlIHRyYW5zZm9ybWF0aW9uDQo+IGhlcmUgbWF0Y2ggdXAg
d2l0aCB0aGUgdmFsdWUgb2YgdGhlICJjb3Zlcml0eSI6IGZpZWxkIGluIHRoZSB0YWJsZT8NCg0K
SSBjYW4gcHV0IGFuIGV4YW1wbGUgb2YgdGhhdCwgYXMgeW91IHBvaW50ZWQgb3V0IGl0IGNvdWxk
IGJlIGRpZmZpY3VsdCB0byBnZXQgd2hlcmUNCnRoaXMgcHJvcHJpZXRhcnkgdG9vbCBJRCBjb21l
cyBmcm9tLg0KDQpUaGUgcHJvcHJpZXRhcnkgSUQgKENvdmVyaXR5IGluIHRoaXMgY2FzZSkgY29t
ZXMgZnJvbSB0aGUgcmVwb3J0IGl0IHByb2R1Y2VzOg0KDQpb4oCmXQ0KPGZpbGUgcGF0aD46PGxp
bmUgbnVtYmVyPjoNCiAgMS4gcHJvcHJpZXRhcnlfSUQ6IFvigKZdDQpb4oCmXQ0KDQphZnRlciB3
ZSBzZWUgdGhlIGZpbmRpbmcsIHdlIHRha2UgdGhhdCBJRCwgd2UgcHV0IGl0IGluIHRoZSDigJxh
bmFseXNlcuKAnSBkaWN0aW9uYXJ5IGFzOg0KDQpb4oCmXQ0KImlkIjrigJ1TQUYtMi1zYWZlIiwN
CuKAnGFuYWx5c2Vy4oCdOiB7DQoJ4oCcY292ZXJpdHnigJ06IOKAnHByb3ByaWV0YXJ5X0lEIg0K
fSwNClvigKZdDQoNClNvIGluIHRoZSBzb3VyY2UgY29kZSB3ZSB3aWxsIGhhdmU6DQoNCi8qIFNB
Ri0yLXNhZmUgW29wdGlvbmFsIHRleHRdICovDQpDIGNvZGUgYWZmZWN0ZWQgbGluZTsNCg0KQW5k
IHdoZW4gdGhlIGFuYWx5c2lzIHdpbGwgYmUgcGVyZm9ybWVkLCB0aGUgdG9vbCAoY292ZXJpdHkg
Zm9yIGV4YW1wbGUpIHdpbGwgcnVuIG9uIHRoaXMgc291cmNlIGNvZGU6DQoNCi8qIGNvdmVyaXR5
W3Byb3ByaWV0YXJ5X0lEXSAqLw0KQyBjb2RlIGFmZmVjdGVkIGxpbmU7DQoNClRoZSB0b29sIHdp
bGwgd3JpdGUgYSByZXBvcnQgYW5kIHdpbGwgc3VwcHJlc3MgdGhlIGZpbmRpbmcgd2l0aCDigJxw
cm9wcmlldGFyeV9JROKAnSB0aGF0IGNvbWVzIGluIHRoZSBDIGNvZGUNCmxpbmUgYWZ0ZXIgdGhl
IGNvbW1lbnQuDQoNCkFmdGVyIHRoZSBhbmFseXNpcywgdGhlIHNvdXJjZSBjb2RlIHdpbGwgcmV0
dXJuIGFzIHRoZSBvcmlnaW5hbCAod2l0aCB0aGUgU0FGLSogdGFnKS4NCg0KPiANCj4+ICBpZiB0
aGUgb2JqZWN0IGRvZXNuJ3QgaGF2ZSBhIGtleS12YWx1ZSwgdGhlbiB0aGUgY29ycmVzcG9uZGlu
ZyBpbi1jb2RlDQo+PiAgY29tbWVudCB3b24ndCBiZSB0cmFuc2xhdGVkLg0KPiANCj4gSWlyYyBh
dCBsZWFzdCBDb3Zlcml0eSBpZ25vcmVzIGNlcnRhaW4gaW5zdGFuY2VzIG9mIHdoYXQgaXQgbWln
aHQgY29uc2lkZXINCj4gdmlvbGF0aW9ucyAoZmFsbC10aHJvdWdoIGluIHN3aXRjaCgpIHN0YXRl
bWVudHMgaW4gcGFydGljdWxhcikgaW4gY2FzZQ0KPiBfYW55XyBjb21tZW50IGlzIHByZXNlbnQu
IFRoZXJlZm9yZSBtYXkgSSBzdWdnZXN0IHRoYXQgc3VjaCBjb21tZW50cyBiZQ0KPiBkZWxldGVk
IChyZWFsbHk6IHJlcGxhY2VkIGJ5IGEgYmxhbmsgbGluZSwgdG8gbWFpbnRhaW4gY29ycmVjdCBs
aW5lDQo+IG51bWJlcmluZykgaWYgdGhlcmUncyBubyBtYXRjaGluZyBrZXktdmFsdWUgcGFpcj8N
Cg0KWWVzIHRoZSBsaW5lIHdvbuKAmXQgYmUgYWx0ZXJlZCBpZiB0aGVyZSBpcyBubyBtYXRjaC4g
VGhpcyB0byBlbnN1cmUgdGhlIGNvcnJlY3QgbGluZQ0KbnVtYmVyaW5nIGlzIG5vdCBhZmZlY3Rl
ZC4NCg0KPiANCj4+IC0gbmFtZTogYSBzaW1wbGUgbmFtZSBmb3IgdGhlIGZpbmRpbmcNCj4+IC0g
dGV4dDogYSBwcm9wZXIganVzdGlmaWNhdGlvbiB0byB0dXJuIG9mZiB0aGUgZmluZGluZy4NCj4g
DQo+IFRoZSBkaXN0aW5jdGlvbiBiZXR3ZWVuIHRoZSBsYXN0IHR3byBkb2Vzbid0IHJlYWxseSBi
ZWNvbWUgY2xlYXIuIFRha2luZw0KPiB5b3VyIOKAnFZhcmlhYmxlIHNldCBidXQgbm90IHVzZWQi
IGV4YW1wbGUgYWJvdmU6IFN1Y2ggYSAibmFtZSIgd2lsbCBmaXQNCj4gbWFueSBjYXNlcywgeWV0
IHRoZSBqdXN0aWZpY2F0aW9uIGZvciBlYWNoIG1pZ2h0IGJlIGRpZmZlcmVudC4gSGVuY2UNCj4g
dGhlIHF1ZXN0aW9uIGlzIGhvdyB1bmlxdWUgIm5hbWUiIHNob3VsZCBiZSBhbmQgLSBpZiBpdCBk
b2Vzbid0IG5lZWQgdG8NCj4gYmUgdW5pcXVlIC0gd2hhdCBpbmZvcm1hdGlvbiBpdCBpcyBpbnRl
bmRlZCB0byBjb252ZXkuDQoNCk5hbWUgaXMgbm90IGVuZm9yY2VkIHRvIGJlIHVuaXF1ZSwgaXTi
gJlzIGNvbnZlbmllbnQgdG8gZ2V0IGEgc3ViamVjdCBmb3IgdGhlIHBhcnRpY3VsYXIganVzdGlm
aWNhdGlvbi4NCklmIHRoZSBuYW1lIG9mIHR3byBqdXN0aWZpY2F0aW9uIGlzIHRoZSBzYW1lLCBi
dXQgdGhlIGp1c3RpZmljYXRpb24gaXMgZGlmZmVyZW50LCB0aGVuIGl0IHdvbuKAmXQgcmVxdWly
ZQ0KbXVjaCBlZmZvcnQgdG8gd3JpdGUgYSBkaWZmZXJlbnQgbmFtZSB0byBxdWlja2x5IHJlY2Fs
bCBhbmQgZGlmZmVyZW50aWF0ZSB0aGUgb25lIGZyb20gdGhlIG90aGVyLg0KDQpIb3dldmVyIGlm
IG5vIG9uZSBmaW5kcyB0aGUg4oCcbmFtZeKAnSBmaWVsZCBuZWNlc3NhcnksIHdlIGNhbiByZW1v
dmUgaXQuIEl0IHdhcyBpbnRyb2R1Y2VkIGhhdmluZw0KSW4gbWluZCB0aGF0IGF0IHNvbWUgcG9p
bnQgYSBkb2N1bWVudCB3aWxsIGJlIGNyZWF0ZWQgd2l0aCBhbGwgdGhlIGp1c3RpZmljYXRpb25z
IHRvZ2V0aGVyLg0KDQpJZiBvdGhlcnMgYXJlIGFnYWluc3QgaXQganVzdCByZXBseSB0byB0aGF0
Lg0KDQo+IA0KPj4gSGVyZSBhbiBleGFtcGxlIG9mIHRoZSB1c2FnZSBvZiB0aGUgaW4tY29kZSBj
b21tZW50IHRhZ3M6DQo+PiANCj4+IC8qIFNBRi0wLXNhZmUgW2V2ZW50dWFsIGRldmVsb3BlciBt
ZXNzYWdlIHRoYXQgc2hhbGwgbm90IGV4Y2VlZHMgbGluZSBjaGFyIG1heCBjb3VudCwgZG9u4oCZ
dCBicmVhayB0aGUgbGluZSFdICovDQo+PiAjZGVmaW5lIHN0cmluZ19wYXJhbShfbmFtZSwgX3Zh
cikgXA0KPj4gICAgX19zZXR1cF9zdHIgX19zZXR1cF9zdHJfIyNfdmFyW10gPSBfbmFtZTsgXA0K
Pj4gICAgX19rcGFyYW0gX19zZXR1cF8jI192YXIgPSBcDQo+PiAgICAgICAgeyAubmFtZSA9IF9f
c2V0dXBfc3RyXyMjX3ZhciwgXA0KPj4gICAgICAgICAgLnR5cGUgPSBPUFRfU1RSLCBcDQo+PiAg
ICAgICAgICAubGVuID0gc2l6ZW9mKF92YXIpLCBcDQo+PiAgICAgICAgICAucGFyLnZhciA9ICZf
dmFyIH0NCj4+IA0KPj4gSW4gdGhlIGV4YW1wbGUgYWJvdmUsIHRoZSB0b29sIGZpbmRpbmcgZm9y
IHRoaXMgbWFjcm8gaXMgc3VwcHJlc3NlZC4gV2hlbiB0aGVyZSBhcmUgbXVsdGlwbGUgZmluZGlu
Z3MgZm9yDQo+PiB0aGUgc2FtZSBsaW5lLCBtdWx0aXBsZSBpbi1jb2RlIGNvbW1lbnRzIG5lZWRz
IHRvIGJlIGluc2VydGVkLCBldmVyeSBvbmUgb24gYSBkaWZmZXJlbnQgbGluZS4NCj4gDQo+IFNp
bmNlIHRoaXMgaXMgYWJvdXQgcGFyZW50aGVzaXphdGlvbiwgd291bGQNCj4gDQo+ICNkZWZpbmUg
c3RyaW5nX3BhcmFtKF9uYW1lLCBfdmFyKSBcDQo+ICAgIF9fc2V0dXBfc3RyIChfX3NldHVwX3N0
cl8jI192YXIpW10gPSBfbmFtZTsgXA0KPiAgICBfX2twYXJhbSAoX19zZXR1cF8jI192YXIpID0g
XA0KPiAgICAgICAgeyAubmFtZSA9IChfX3NldHVwX3N0cl8jI192YXIpLCBcDQo+ICAgICAgICAg
IC50eXBlID0gT1BUX1NUUiwgXA0KPiAgICAgICAgICAubGVuID0gc2l6ZW9mKF92YXIpLCBcDQo+
ICAgICAgICAgIC5wYXIudmFyID0gJihfdmFyKSB9DQo+IA0KPiBzYXRpc2Z5IHRoZSB0b29scz8g
QW5kIHdvdWxkbid0IHdlIGJldHRlciBub3QgbWFzayBkZXRlY3Rpb24gb24gdGhpcw0KPiBjb25z
dHJ1Y3QgYW55d2F5LCBzaW5jZSB0aGUgbGFzdCBvZiB0aGUgdXNlcyBvZiAiX3ZhciIgaW5kZWVk
IGRvZXMNCj4gdmlvbGF0ZSB0aGUgcnVsZSAod2l0aG91dCBwYXJlbnRoZXNlcyBhZGRlZCk/DQoN
ClllcyB0aGlzIHdhcyBqdXN0IGFuIGV4YW1wbGUgb2YgaG93IHRvIHN1cHByZXNzIGEgZmluZGlu
ZywgaW4gdGhpcyBwYXJ0aWN1bGFyDQpjYXNlLCBJIHdvdWxkIGhhdmUgZml4ZWQgdGhlIGVycm9y
IGluc3RlYWQgb2Ygc3VwcHJlc3NpbmcgaXQuDQpUaGUgY2hhbmdlcyB0byBmaXggdGhlIGZpbmRp
bmcgaXMgYWJvdmUuDQoNCj4gDQo+IEFzIHRvIHRoZSBwbGFjZW1lbnQgb2YgdGhlIGxhYmVsOiBJ
dCB3YXMgcmVwZWF0ZWRseSBzYWlkIHRoYXQgYW5hbHlzaXMNCj4gb2NjdXJzIG9uIHByZS1wcm9j
ZXNzZWQgc291cmNlcy4gSXMgcGxhY2luZyBhIGxhYmVsIGFoZWFkIG9mIGEgbWFjcm8NCj4gZGVm
aW5pdGlvbiB0aGVyZWZvcmUgZ29pbmcgdG8gaGF2ZSBhbnkgZWZmZWN0IGF0IGFsbD8gV291bGRu
J3QgdGhlIHRoaW5nDQo+IHJhdGhlciBuZWVkIHRvIGxvb2sgbGlrZSB0aGlzIChhc3N1bWluZyBh
IHByZS1wcm9jZXNzaW5nIG1vZGUgaXMgdXNlZA0KPiB3aGljaCByZXRhaW5zIGNvbW1lbnRzIGFu
ZCByZXNwZWN0cyBsaW5lIHNwbGl0cyBkZXNwaXRlIHRoZSB1c2Ugb2YgbGluZQ0KPiBjb250aW51
YXRpb25zIGluIHRoZSBtYWNybyBkZWZpbml0aW9uKToNCj4gDQo+ICNkZWZpbmUgc3RyaW5nX3Bh
cmFtKF9uYW1lLCBfdmFyKSBcDQo+ICAgIC8qIFNBRi0wLXNhZmUgLi4uICovIFwNCj4gICAgX19z
ZXR1cF9zdHIgX19zZXR1cF9zdHJfIyNfdmFyW10gPSBfbmFtZTsgXA0KPiAgICAvKiBTQUYtMC1z
YWZlIC4uLiAqLyBcDQo+ICAgIF9fa3BhcmFtIF9fc2V0dXBfIyNfdmFyID0gXA0KPiAgICAgICAg
LyogU0FGLTAtc2FmZSAuLi4gKi8gXA0KPiAgICAgICAgeyAubmFtZSA9IF9fc2V0dXBfc3RyXyMj
X3ZhciwgXA0KPiAgICAgICAgICAudHlwZSA9IE9QVF9TVFIsIFwNCj4gICAgICAgICAgLmxlbiA9
IHNpemVvZihfdmFyKSwgXA0KPiAgICAgICAgICAucGFyLnZhciA9ICYoX3ZhcikgfQ0KDQpGcm9t
IHRoZSBleHBlcmllbmNlIG9uIGNwcGNoZWNrIGFuZCBjb3Zlcml0eSwgaXQgaXMgZW5vdWdoIHRv
IHBsYWNlIHRoZQ0KSW4tY29kZSBjb21tZW50IGFib3ZlIHRoZSBmaXJzdCBsaW5lIG9mIHRoZSBt
YWNybyB0byBzdXBwcmVzcyB0aGUgZmluZGluZy4NCg0KPiANCj4gRmluYWxseTogRXhjZXB0IGZv
ciBpdHMgbWVyZSBtZW50aW9uaW5nLCBJIGRpZG4ndCBzcG90IGFueSB3b3JkIHRvd2FyZHMNCj4g
bXVsdGlwbGUgdXNlcyAoaW4gdGhlIHNvdXJjZXMpIG9mIGEgc2luZ2xlIGxhYmVsLiBUbyBhdm9p
ZCBsb25nDQo+IGRpc2N1c3Npb25zIGFib3V0IHdoZXRoZXIgYSBuZXcgdGFnIGlzIG5lZWRlZCB2
cyBhbiBleGlzdGluZyBvbmUgdG8gYmUNCj4gcmUtdXNlZCwgdGhlIHJ1bGVzIGZvciB0aGlzIG5l
ZWQgdG8gYmUgYXMgY2xlYXIgYW5kIG9idmlvdXMgYXMgcG9zc2libGUuDQoNCkkgd2lsbCB3cml0
ZSBpdCBkb3duIHByb3Blcmx5IHRoYXQgaWYgYSBqdXN0aWZpY2F0aW9uIGhvbGRzIGZvciBtdWx0
aXBsZSBmaW5kaW5nIG9mIHRoZQ0Kc2FtZSBub24tY29tcGxpYW5jZSB0byB0aGUgY29kaW5nIHN0
YW5kYXJkLCB0aGUgdGFnIGNhbiBhbmQgbXVzdCBiZSByZXVzZWQuDQoNCg0KPiANCj4gSmFuDQoN
Cg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 10:44:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 10:44:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421846.667503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oivhU-0008Lb-4s; Thu, 13 Oct 2022 10:44:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421846.667503; Thu, 13 Oct 2022 10:44:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oivhU-0008LU-2A; Thu, 13 Oct 2022 10:44:28 +0000
Received: by outflank-mailman (input) for mailman id 421846;
 Thu, 13 Oct 2022 10:44:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oivhS-0008LO-Pg
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 10:44:26 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2083.outbound.protection.outlook.com [40.107.20.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 01223b9f-4ae4-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 12:44:25 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6838.eurprd04.prod.outlook.com (2603:10a6:20b:10a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Thu, 13 Oct
 2022 10:44:23 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 10:44:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01223b9f-4ae4-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IhJjx8Lo49tQNXsbiWd7CYhsd5hK5FNZeOj7JNVKaNFoKvc/AxphlF8eVw8X++3Awv3zkEu/a4bw63Nj1TNmOsUUXmAvwQx1mIsM8uYssavjlOj5bE8/3OAmd1j/M5tVGt2S62s6H8Uox2pYZCM4AK3SAGEzqz7jv4cHG+j30QP4XNw4WQWlHJ3z2cORP4Cj9y+D/kRJBk2/020acFe2E63D3ow74NaRAU4oupri+s4C2UVe3OdQi0acssQnbM8FU+FhfWR9/rfG3kDwGeTepjHy3tGWW5m2zJsyerrZyvhHB6QR33IYuhhs0LhY2wIc7/Vlbr+89li1tRyR6Q1p/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FgNnsIgISvcoAwLgemL6WUhGOiqJYx0k5cHPEE38Ias=;
 b=PpFyoxwr7rqsj2AmgpCV7lGJzvqh1qUiAY7Zy27+aTaCxdAQnwgTqg/zXKCBdrn8JISvZMzds+Py5aKRkLeESReUYXW+q617vEoIOr28MBrrTDpz6QsDvc3NmwW3MW7hgCgjoBGTicVmK2vTKkNDTZXoBNAEQn9DtAfQSsd7kjhLYzxGzJCcayB0heW7yzajxm5ypkZrBIzhPCtTmUSAm5LzTp/p0I+pNRghmXWzv4HCkNaUQY4+1GVfm5MyWsan3cnUXyeHdI2VCj1gS//Tn7A1SLuSTtGcLXRTtNbm6QZLKBjY7822exDxqfLjwAqw934WH3waA/pUT1zAmkF4Kg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FgNnsIgISvcoAwLgemL6WUhGOiqJYx0k5cHPEE38Ias=;
 b=O6KlfgfGtWDxgVM5OeFFl0F5etu20IOXdzMwN44j9bcUGYbqZttocjgl2Wb+N+G3XNtjLh2XGCZWHvzAn/sgcKbJW7IXwwf64jASplf2ZqHjQVqZmVbZxaU9K0+KnL1b71tIbb3AcvD1SwzzJ3GEnRrl+vzutXKntqwfeCwoSbDsTrM3VBD/SsUTf6hUjSoViEx25Acay+r+9DQUNG0xFLz17zj90RxyjkN7FCgeKuFdIJhEn4mhE0PrqzfXCflgSqxgwt0YgoF2QmBnbz8KRIAchDavoLAvSBXOt9ZmPFNh0E6tuq/mKpS82rVrltEwyBy7C6oHPrWO4J6n/Vg56g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <097a6db1-51e4-3b6e-af94-46fef203b27a@suse.com>
Date: Thu, 13 Oct 2022 12:44:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for
 domains
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, julien@xen.org,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-7-carlo.nonato@minervasys.tech>
 <32e2a752-975f-baa6-8d6c-ba27cf516c64@suse.com>
 <CAG+AhRUJ0+CszWjSzO7=v4SmKtjG7VMpZ8P050s-rLz0rgXJBw@mail.gmail.com>
 <5e5ee6f1-a5fc-fcd4-5d61-7f1e4be6b630@suse.com>
 <CAG+AhRWXi8V142aSx_P1cjyaXTb+CnS-EOB_o8c4Y7ZkBt7Gkg@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAG+AhRWXi8V142aSx_P1cjyaXTb+CnS-EOB_o8c4Y7ZkBt7Gkg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0174.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6838:EE_
X-MS-Office365-Filtering-Correlation-Id: 6d5038f9-9a4b-4db8-d29a-08daad07e424
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FYT+Jm7hX+p52axtXQGHu0c22yzLtwV1MMHoZJxvY8wrVQTtitEtcylaw1PIdETNPB2O+0R7u9hsZj4zspeeqTvByMVuea3QagiDImsX7iI4/LBvoDGfqf/yZkeWxKvn2M041MU+pCJu9ao5a8BlVNnUGKpaQI6zkxLqr8g+1/Tv/D2kXENoBs09W00TLunLBs9tCKmsY9gGPxXlyuXWZ3excGgRIhQEoKPatb2CsDB7hBZa2Eu72WmwE9P1g5Hs2kwhh0/FKSvPLFWQZK9iPIek+8tr08tjmintOJBMEUkmE08tZxKIR7Bdm9soM5/3CTxhTh6US6RppH6NwZdOCxAVuYIqYBT9oTYnodmUkChMlj1F8ZSO93TK1FNQWk9MI0suEwuIj6Xl3Y4/yMrDa8/0zLKXYNX1exL/ZHDvnLWKaX/pbL7+yHQ7jmTOg9f8iCReufSVPCW1E+/g0FbuJUHeCSHrNi3cwqz/b2rnTmW3Kh1AX/3wKj7T8JXOUfezQTar5XhCv+J70tstCwfzdDoMG3FksZUYhpv/vnqVafUnwA/ecS4AQvBmjpQudMwwRQ8OlzNVC3Zq96XSdt7mzlBQN4J4IPiT96dVFe4bGTEXtDHrZclDpextfDXin/lzHJ8+jZHm+3B2EUCnE5Ix/W7LzdtK6euBdB/M6twzxDvV8yC9XNZDbru7bSXRxwXzlk33YPZxX4xhk891xzYHswxcglxhXoIVJygcKC1oFyD0lRJS4Jf1nfyPswCA2gYX92+1PmQ4rs4Fl+84kznZBNnl5U2vSW9zap88oYXT1fFEEV21d81JGXRAid3/nQvrstHtAAL1rKWk1mbnXs/CUQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(136003)(396003)(366004)(376002)(346002)(451199015)(26005)(6512007)(6506007)(54906003)(86362001)(316002)(478600001)(6486002)(6916009)(36756003)(38100700002)(8936002)(186003)(2616005)(83380400001)(53546011)(31686004)(7416002)(8676002)(31696002)(66556008)(2906002)(5660300002)(66476007)(66946007)(41300700001)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S2puR2JYYjd4bStWTFR5b0ZpVDMveFBLenptQUNGYUhpUTk4cy9JUXhVVWxj?=
 =?utf-8?B?K25JTnJhV3JNWkFReG85VWxSSVViVzdpR3ByRUQ3UFNzWkJOanQ0ZE1lZkg0?=
 =?utf-8?B?endhM2ZzZlJ0R3B5c1BoekdkdnBLR3grLzUzWmtRaWovMjhWcExJMWk4ZlBF?=
 =?utf-8?B?TXZiaElLZWQ5RFgvelBuZHRqUk1mckQ2NHA1bWNCbThYdzI4SlJNRFQxTUlH?=
 =?utf-8?B?Rm9nbVhBR1lNRXg1aVdTR3IvNG51WjQxZHNucnZMTGt2eGppSVpoSVdlV0FL?=
 =?utf-8?B?WDlLTmsydkhnUVVvMWtaaXBTNUd2WTRPbHVCSStsZlJyMkdzSE1xa2x0Uk5v?=
 =?utf-8?B?dDNoL1QyZzc3R2I0SWROeXo5QlFMMjI3d25kRFhQbTlWa3AwN1RRNWt2RDZI?=
 =?utf-8?B?VGt3dnYzK3VJMS9PWStselRETEc5Slh2eDg4clpudXRSSzh0UWFBM1B3Z0w0?=
 =?utf-8?B?RzY3OGlvaDl2d29KcWZKWFRLOHVKUzJ2RXRtRzVOWUpIa0hqVmVpK0RoVU5N?=
 =?utf-8?B?NUlwdk9GVUpvNzY4aEEvSUQ5WlBLemNiekM3WmZPWkUzd0tYVVB6bllyUWtR?=
 =?utf-8?B?WDNWdjlsVjJqaENPZndBVWRoNWRQdmVoTXhDQ3RrUnIzYTVxRU1lRDFqZmRJ?=
 =?utf-8?B?SWJJd3Z2M0dtZncxZkpNeXBLQUFiOWx3R2M1VjJFdUZZa1lFN1psdTdQMUVR?=
 =?utf-8?B?d3JURi8wclg4VFpjV2xURzB2MlEvMlBrTnRrVnorcW1QeVg4Q0JsU2wyNy9k?=
 =?utf-8?B?Q255UGg5aHE3bVV4RlF6MXl4Tnc3VEdLRnprTUd6dTlXS0s1dlZ2R1hmR1Bq?=
 =?utf-8?B?RWJ1bGdmZmhxMi9VcDB2czlXbEVIQjVHWkZkV1pEUEpuOC9CblN5MFF4Ungz?=
 =?utf-8?B?ekdSZktoekNXVmJobllicjdxbTV4czAxbkJ5NDVndkIzUWpvYUM1WFN2Z3M3?=
 =?utf-8?B?KzlLZ0l1dEZNclV0SDlwbis0Z3ZhMTR2b1JjQjVGYVhMelFCcGY3anl3eUdx?=
 =?utf-8?B?Zkgxc2xmMmhJc1JXbW43TmdmeDVteFQva2tiQ2ZJR2RDeDFVNGhXWkdhWEhG?=
 =?utf-8?B?WFFIL2o2dUZmenBneGxraDg2a2xvNk1mbmxWM1grelMrT0kwQmkyaXhZOTRo?=
 =?utf-8?B?UzhqWklsQkROUUdZK3lyWU1qMWFWNFovSDR3THNSSWMzVnpPSXNuV1JteExU?=
 =?utf-8?B?eHZrWDZYTlErTDFHSEx6dHJsYkxxV1hTWU5mNHc3L0hLRUQ4YWlFL2REQW5p?=
 =?utf-8?B?eXVkZUxJTHBDcytHUEJhOC9rVVh3aS93Y0pEcmJjblhkdHY5L1QvTGtBMFE4?=
 =?utf-8?B?VGtqb2o3ZWdFZWVaNWxVZFNuaWR5QW40b2lveDdJT2Fwb0pZUmpVdm5YY2w2?=
 =?utf-8?B?cUhXRC95aUZ6Mm1TV1pWZU9OdERRbFNzV0xISzZYZ0kxbThjWDFQVGtlRFlK?=
 =?utf-8?B?M1JKNWMwdisvbzJ3QXN2UFVMRGNjVHVrMUtYVER3UlUwbGo5K2hUWmtnMFpN?=
 =?utf-8?B?RUt2alc2eUJHYVBhbU05RU03UEwvc3NPbkQvdnU3dzZ3Um55aUYzSDN3U0Vv?=
 =?utf-8?B?S0ZaNm80bmRHRjNLSXpVak1zeEJjaU5EUEtaZEljZnNlc0pNWGpZUnJrUGJP?=
 =?utf-8?B?ZzFDa3U4aGNpSnBobjdKcHVKL0dFV0xvb2tYSHlyTUNqMWJkRkZMcmZscnVR?=
 =?utf-8?B?UTdsZmxPQUJ2V0YwdmQ4UFl3bFAwZFZ1OVlHZGpsQ0tmQ3A4N3pkUTVNakVO?=
 =?utf-8?B?Uk1jUU9oWStmbWxvMVlkTGNuYW95ZStiMmszWUhPYlRyZ0FsNi92VHFndXo4?=
 =?utf-8?B?TnRsS3F0L2haQmtOKy9tU29pcVFtRlY4cEtDc0NZRW1pQUtpekVSYWNyZEVT?=
 =?utf-8?B?SGUvejFaYkkybjJhWHkweTAwYkJ0TTBXWTE5akdQTm1laWQyU2ZMbnZBd2tr?=
 =?utf-8?B?TWdaeXJ6WnAyNHIrUmhIc1VwcWUrb0kxUkhIZDZwdlhGa2gxV0JSajJ5M085?=
 =?utf-8?B?OEtNcmc1dUp6K1hNVFFHV0dYSjFYaFErR3piVzJnWk9jdWNLNkx3K2NYQXBI?=
 =?utf-8?B?cWlTSXU2Rm9CQkR5VVlVS2ZkT0FWeWppK3owMG4zT2lEY1NpWjJkWVhycUkr?=
 =?utf-8?Q?EGYHIKZKGUT/hKK0jHn/nn/75?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d5038f9-9a4b-4db8-d29a-08daad07e424
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 10:44:23.2841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yFTqcYXPssXuCp5LGg7xbzCdywQPQmFD8EdWc6Vr/wJAUlZnCKZeJIk7jGs+hmx3HFPZeTusEjY7PGmQ/qhDyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6838

On 13.10.2022 11:47, Carlo Nonato wrote:
> On Mon, Sep 19, 2022 at 8:26 AM Jan Beulich <jbeulich@suse.com> wrote:
>> On 16.09.2022 18:05, Carlo Nonato wrote:
>>> On Thu, Sep 15, 2022 at 3:13 PM Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 26.08.2022 14:51, Carlo Nonato wrote:
>>>>> --- a/xen/arch/arm/coloring.c
>>>>> +++ b/xen/arch/arm/coloring.c
>>>>> @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config,
>>>>>      config->num_colors = (uint16_t)num;
>>>>>  }
>>>>>
>>>>> +unsigned int page_to_color(struct page_info *pg)
>>>>
>>>> The parameter will want to be pointer-to-const and I wonder whether ...
>>>>
>>>>> +{
>>>>> +    return addr_to_color(page_to_maddr(pg));
>>>>> +}
>>>>
>>>> ... the function as a whole wouldn't be a good candidate for being an
>>>> inline one (requiring addr_to_color() to be available in outside of
>>>> this file, of course).
>>>
>>> You mean defining it as static inline in the coloring.h header?
>>
>> That would seem preferable for a simple function like this one.
>>
> 
> I didn't want to expose that function since I would also have to expose
> the addr_col_mask global variable.
> Same goes for get_max_colors(): it exist only for the purpose to restrict
> the max_colors variable visibility.

Ah yes, that's a good reason to keep the function out-of-line.

>>>>> +    page_list_for_each( pos, head )
>>>>> +    {
>>>>> +        if ( page_to_maddr(pos) < page_to_maddr(pg) )
>>>>> +        {
>>>>> +            head = &pos->list;
>>>>> +            break;
>>>>> +        }
>>>>> +    }
>>>>
>>>> Wait - a linear search for every single page insertion? How well
>>>> is that going to perform on a multi-terabyte system?
>>>
>>> For our test cases (embedded systems) the linear search is good enough.
>>> I agree with you that in the general case this is bad (even though the main
>>> targets are indeed embedded systems).
>>> Are there any already available data structures that we can exploit to get
>>> better performances?
>>
>> I'm afraid there aren't any that I would see as a good fit here.
>>
> 
> Regarding this I can see three options:
> 1) We leave it as it is and we warn the user in the docs that cache coloring
>    is embedded system specific for the moment since it has, probably, bad
>    performances with bigger systems.

I could live with this as long as it's stated prominently enough, but ...

> 2) We use some priority queue implementation to replace the actual lists.
>    Red/black trees are available in Xen codebase, but I think I would have
>    to change the page_info struct to use them.
>    Maybe just a binary heap implemented as an array could be viable, but that
>    would require me to implement somewhere the logic for insertion,
>    extract-min and other operations.
> 3) I have a working prototype of a buddy allocator that also makes use of
>    coloring information. It isn't an extension of the main one, but rather a
>    simpler version. This means that nodes, zones, scrubbing, aren't
>    supported, but this is true also for the already submitted colored
>    allocator. With this, order > 0 pages can be served (up until
>    log2(max_colors)) and insertion is no more linear, but constant instead.

... this sounds even more promising, not the least because it also eliminates
yet another shortcoming we've talked about already. In fact I would expect
that log2(max_colors) doesn't need to be the limit either, as you'd cycle
back to the first color anyway once you've reached the last one.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 10:58:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 10:58:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421855.667522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oivur-0001h9-DS; Thu, 13 Oct 2022 10:58:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421855.667522; Thu, 13 Oct 2022 10:58:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oivur-0001h2-AP; Thu, 13 Oct 2022 10:58:17 +0000
Received: by outflank-mailman (input) for mailman id 421855;
 Thu, 13 Oct 2022 10:58:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oivuq-0001gw-8F
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 10:58:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oivuq-0005C7-1k; Thu, 13 Oct 2022 10:58:16 +0000
Received: from [15.248.2.148] (helo=[10.24.69.9])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oivup-00013E-T2; Thu, 13 Oct 2022 10:58:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ORjXm5YgZsiXnELeGd3zbzrMFbFUuyptzntA04aNsWY=; b=OauYsndkktlt2sMnZjXx5lit4C
	cWxAjU7QuAUP6M73xczxOLVNxV5ME78Szs8+W2EfLl/BOzTirwPSNVTyRIgKGzTvxuoWqSzZtSmsg
	1gHV/rbfvxR8bqZNm5/dAd7Rg/ZeeAojMQCoX89/btSv8RCgNcADoUHCF7cDF13Y66dM=;
Message-ID: <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
Date: Thu, 13 Oct 2022 11:58:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 13/10/2022 10:21, Henry Wang wrote:
> Hi Julien,

Hi Henry,

> 
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
>> arch_domain_create()
>>
>> Hi Henry,
>>
>> On 13/10/2022 09:38, Henry Wang wrote:
>>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>>> when the domain is created. Considering the worst case of page tables
>>
>> Can you describe in the commit message what is the worst case scenario?
> 
> The two pages will be consecutive but not necessarily in the same L3 page
> table so the worst case is 4 + 2, is that correct?

So I agree that the worse case is 6. But I don't understand what you 
mean by '4 + 2' here.

> 
>>
>>> and keep a buffer, populate 16 pages as the default value to the P2M
>>> pages pool in arch_domain_create() at the domain creation stage to
>>> satisfy the GICv2 requirement.
>>>
>>> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M
>> pool")
>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>>> ---
>>> This should also be backported to 4.13, 4.14, 4.15 and 4.16.
>>> ---
>>>    xen/arch/arm/domain.c | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>> index 2c84e6dbbb..e40e2bcba1 100644
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>>>            BUG();
>>>        }
>>>
>>> +    spin_lock(&d->arch.paging.lock);
>>> +    /*
>>> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2
>> area
>>
>> The wording suggests that this is only necessary for GICv2. But below
>> this is done unconditionally. I am happy with this been done
>> unconditionally, but I think this should be clarified here.
> 
> Sure, I will add "For GICv3, the above-mentioned P2M mapping is not
> necessary, but since the allocated 16 pages here would not be lost, hence
> populate these pages unconditionally" if it is ok to you.

Sounds good to me.

> 
>>
>>> +     * when the domain is created. Considering the worst case for page
>>> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool
>> here.
>>> +     */
>>> +    if ( (rc = p2m_set_allocation(d, 16, NULL)) != 0 )
>>> +    {
>>> +        p2m_set_allocation(d, 0, NULL);
>>
>> Shouldn't this be done in p2m_fiinal_teardown() to cover so the pages
>> will be freed anything after this call will fail (include in the caller
>> domain_create())?
> 
> Hmm, yes, I will remove this p2m_set_allocation(d, 0, NULL); in v2.

Just to clarify, I meant that a call in p2m_final_teardown() *is* 
missing in p2m_final_teardown() (or wherever we decide to add).

This would make this one redundant.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:04:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:04:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421861.667533 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiw16-00038H-4K; Thu, 13 Oct 2022 11:04:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421861.667533; Thu, 13 Oct 2022 11:04:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiw16-00038A-1S; Thu, 13 Oct 2022 11:04:44 +0000
Received: by outflank-mailman (input) for mailman id 421861;
 Thu, 13 Oct 2022 11:04:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiw14-000384-VO
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:04:42 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6445594-4ae6-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 13:04:41 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8711.eurprd04.prod.outlook.com (2603:10a6:10:2de::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 11:04:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 11:04:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6445594-4ae6-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i5zBxPFkpc9m7nzwPbsUgrB1H02RPuYGFPFd19dxZ6xR0zZx0QziY6HwJM6n5/djj9sTxONgKHrziCGOrqmeivt8FMzolGBCoGuDcl4pVbad0I2p/pRH32dGma/fbtnPlBS4HEvj399cm3y1TLdEGpr3XqfmktYB55Cilp3uWOtVmsGd5m0d1CaRgc6xyhGX2va1kcFZx6H4K9KBhtKhKcz6GI2S2HMf2c07UnrXFa6lIHHsK7S/unSjSsP1lSTFXjae3ZQ/nxp5iadGpLropFXFyfT/1SWePAKNr1x4sJoCBXChl2w+QS627H72kDhmNgEguwYu9FmtTbNYMp/Q9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wj9hkEPfZbilBstNTw+St8QZ5chhYXD3rDXCRvKu/H4=;
 b=kbxMBCn1zKKZsz5/xQpijWDIGcdraWONNLCTu8KMVAXjGvAe8vjL1FRu4RrJXsXJozyQDbNTl9DP8VO3Cv/nGFsiqyDf8XbD0kUiojtj8Ae5ajaJQf4wag1DYME7jumqkWk9eu/ncTL2qZkmwmGHJoNEJGi6HJ3z1dTVyR6XcLNUraiNULwOw3uCr3iCUWunQTWR0N+buPixuA91vbwsNJlEdyS6QID+UtUsLGE5EGwcZEuffYIybIhMIUHxbSMz1hvW9oPm77iqKSBZjfrxxJtlJzzy3mDHTtxIAVkGMsLuR38nBhgg6g6Ax1k4t+xZHwiGsxJWcpROloZEhetamA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wj9hkEPfZbilBstNTw+St8QZ5chhYXD3rDXCRvKu/H4=;
 b=ww8f1R4dkdEh3PBrIj/8vQ2DpFgsxcJPL3cgWty9z1udjlw9FMX5XM9R5lYCyYW+oQ8sqF7Odn4NDTUYQqJWpxblc1UgpO4disHU+kB2K2ILfxGZFbGCgZOzPuW4kmA+4XT58WFx3SdP36FsTUFI0QGgcpilwv/ERgK1gD+kFFWS5AtFl9gBunBixF1jlToljLoNCKWInPBfLehrFwISWOohNTEGcymBVmoCI3FtQ7WpM3MHTnKVuVCXDNfdSgSXvtiZIiKxILSUViN/05XH1EuifX/okNW3yu3K3GVuDLzdgOXq8bpAIYbWuzJ47ibKyzXF3Q+PcdRcPIGzuIfVIQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
Date: Thu, 13 Oct 2022 13:04:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0174.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8711:EE_
X-MS-Office365-Filtering-Correlation-Id: 6e7938a9-ef2d-4186-ee43-08daad0ab9b0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	trSEE4qnp+nFXBMoXujS85ullyNb/NQ/sk0X61Id5+iZV19Lpx2rxUbonW6I0osQdYCCB4Xl4aAvXf2HgrIFeFTbYJTYXEMEvLypz9vkwb5qN4YHt8tTC7N7q8dU2lZdKe/xdP6CbEUrx2EDWFdx95IIjk1Kj8IZNf5rFroJ40Ub0YLyMwPQ1+4I9ByfZATxoUTCIO/uf7RwutZRLv0N+/Vavlm3ol13rdHIFsN6nfZ7lA+4DS2G8UrtD/+Ok6AQ+gNLcwbSt+OgqEHljRSXWgfVj6iGykrNhWbPorVVz+TBzLgvTrTncNrBa84BCDfApyuRoxsZmW8jiWoRnd8SvphbABuAcWmTQR76Qx+RETrRNhE5gf/tfg3OzH2brqrN7Efr/KtbQOTRcdT8wWMK7lSS/yo1kllTKPXaQrFb/TLZkeWY6bIQJPfRoyaUPgZSACq66UvHc+kfnx7GKaVydXoqQP19J4+1uNTq3xtXvhII+O9enpisbKK1n5JbinrJPVzvBB1uNf3vNV705MBrL+US6deeST7SSP3UmHDUa69Q6meTNUaQQdSBUqVG4UryxSRcTyI8BtgWLK/Itq1L0Boi7PCt6RvZXRd1+mAU72rYTf9XjG7/i5uHytKJV6H0wzPNluYjffs+xxMi+j2W2b4TKJki+UsGUra2GiZgqk1kT/6QeH+5KV4scW8PaBUtklKEegFIKLzjT/gMwxqhXcmgIB3B9qMmOi9YVffQCk0rmZxd5DFtsaO04VhiGq9mSYZdCbbsagpe0mT5igT3ciQqLVx6pqKg2Ce5GaGzGQg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199015)(31686004)(2906002)(5660300002)(4326008)(316002)(66946007)(86362001)(8676002)(66556008)(66476007)(54906003)(36756003)(4744005)(478600001)(8936002)(31696002)(41300700001)(83380400001)(6512007)(2616005)(110136005)(6506007)(6486002)(53546011)(186003)(38100700002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TjBOUDhjcktKVVhSOWR6WHg0WnVoMjZyV21JVTYwQ2lDS1R2OHZZdzM3cVhK?=
 =?utf-8?B?anRXcVlwME45T0x5a1ZZOE9HWk1UYlozOFlSbDJFUEdPWUhMM0hRZGwvczJ1?=
 =?utf-8?B?NXo2dDdjV1plc1pGQjE4ZWNKTitDSzZVWjk1WCtpNWF0NnpEanZnU3JncVZH?=
 =?utf-8?B?L2xvVitvK0JZS044c2Jhd05vbW5icEJrcGVXbWJvUE51OUZBQkZkOEhMNG1O?=
 =?utf-8?B?QnZCcFFwM3puU2dUY1N1V2MxYmRpd09VS3NqcitoMDVKSUxDY0NhcExlT0lW?=
 =?utf-8?B?SlFBaHgxbHNxbHNKNHlxdDVoeE5oejh4OHBTRVRrZUNtWGx5b1dQZjhJSVFF?=
 =?utf-8?B?d2VGSFozRi9oZ0luOG1CQVRuMEc1Y3ZDMVJwTy9FMGNZZFRXU1l5Ym5kaFVG?=
 =?utf-8?B?UTBxM1RRcWNqcGdTR1g1R1NOMTNCTFQvWGlFQWV2Y2tDUGVjYXlzb25tN2o5?=
 =?utf-8?B?Q3VYTCtnYkY5cE44Q3lLVkxqekc0NUk4cGFnb0F6T1JqOVJVSjF2V1VtN09Z?=
 =?utf-8?B?RTc0WFRYZTBJTVlKbDJQSXhaSXYxUG12YlBpV0tOSTM4MHlvZkhXNng4SjNG?=
 =?utf-8?B?NjBFdHhvdHgveTZnSTQ1bjZKalZEL3Aydy8zNGtZMjNsc2gzSFZyQksrbnJn?=
 =?utf-8?B?amRGUVNCT0FnQUlieURDb3RNZHpjeEcrZWlFUUtpVW5uY1NnUFVCbXk5dS9L?=
 =?utf-8?B?ZHlHdWhyTFJHNlFsK2ltWW5NY0w0SUZ0R29DSEwvaUpXQ1d0S1lNejhhSW0w?=
 =?utf-8?B?QitzQmc5d3lWTFdMZmJ2YVFobDVSTFlxMG5CWXAxMDJ4Q09yUnVCdW5JVlV5?=
 =?utf-8?B?ZkkzL05BU2Nzczc2R1lldWV4bXVpTGhvMUgwVXI5QTRkZFVmSUVOT0QrZTRy?=
 =?utf-8?B?dkVhUzBUMDdnUGhoU0E4bEhHbm9pVTZYUFN1by9sQUg2OTlTN1VDT0pReWl1?=
 =?utf-8?B?RVN0Zi9uTjkydEgyRG9JRURZN05QZVlaNnZnaGM5bGxtNGs2YmFWVStaVEp4?=
 =?utf-8?B?ZkkyeE8yNU5pejRzSi9hZ1I5TU9RMEJsZCtLZTYyT3VwYi82Q3Q5RDBnTWUw?=
 =?utf-8?B?Q0huTHN2dDJlM1hjTHBlUWZta1FNa0lHWE00ZVEvMTZicCtkYW5UWGd2bFA5?=
 =?utf-8?B?Skg4SVRGdG42S2FRSU14akk3eHB2dDh2N0dzV20xU3UyYVJSOEZRaU1ZdWtV?=
 =?utf-8?B?cWtGeDNocWpZblpJUnZQVUNJOG9NQUFVTDdKMlN0NXVCM0RsUHVxdTRxZ0Nm?=
 =?utf-8?B?NXRTeHpYRjRGWHJRSlp4RGVnOHhDd1M4eXJ6NVRRQ0swQ01QcmxYNGQrOFhB?=
 =?utf-8?B?UE1nVkFHVlJOMnlsL0QzZmVDRnZWZ1UzVm90TXVFL0UyTkRuUnV6eEdlaU92?=
 =?utf-8?B?UHI0N1VXNmErUVcybVBldmkwNFArZ2NoZzFYQlBMa2xiTXUzUjJKU1pxcFRa?=
 =?utf-8?B?aVRFa0RqalRZcXdsdk9nMDN1bktJeWg4YXZmV3MvNzZMcy9BWEJtS3ZhTmQz?=
 =?utf-8?B?SEhlbm50Vzh1ekpZd2V2TDIwS2pRMGlSVmlhUGF6bmthNjB3NFYzdHJKYVVP?=
 =?utf-8?B?NjQzZWlWRG9mOWU2aFZySkNaV3BHdy9JRzhoYzMzcEZtYjRSOHhnQzNxbExk?=
 =?utf-8?B?SldkbDIzbk1SeS8wVCt6WldaRnhFT1VDL0o0aEFtekdxVWQyUVBpNVRoUWla?=
 =?utf-8?B?bWd4M3hBUGp3QmxUSGVIdTJUd3V4ZWpWRnRQa0lSeVJFSFlpZk1UK2dBRTQ2?=
 =?utf-8?B?SUhzT1A1citlQVR4WmMxdEgzNmN2Q1BVeEdFRDNnSmFOMEpxS1hNcU1CLzFn?=
 =?utf-8?B?VnUyMHI5QzczWmdpczhtWjgzZXpiUWVmQnA3dG1ubkdPZnB0d1JzT1R4eDBF?=
 =?utf-8?B?TTYvTWJsY3NMb3g0dXFxTHdDUExIMXcyUm9qUG95UUpRVEFuWmtUbktlQWYx?=
 =?utf-8?B?YTZBSjF3UmNvRHdWdlpkQjZXU2hIMmtYYllSREpxSFRoaWhmY1JuYkdLMmFI?=
 =?utf-8?B?dXl4NWpTTkNKaWZ4VzR1eTRMcFk1OWVpVWJERWlkUDRjWUhPRW5zcWhYczJM?=
 =?utf-8?B?YWtFbUlyR00wTFJTTnpGOCszN3pLYS9FRHFxMG13WG4rdlROREFZTzczQ2Ji?=
 =?utf-8?Q?NBPW9gUJ4Dm9FedHhO/bzcEPU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e7938a9-ef2d-4186-ee43-08daad0ab9b0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:04:40.3942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i++u25J0yfnZT3Dt+p0imO0yfIfwCItUhshgxq5XniAO1m5f/UDWeSg5lONgMIbm5oYI7e8msdbvFu5Bnen9JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8711

On 13.10.2022 12:58, Julien Grall wrote:
> On 13/10/2022 10:21, Henry Wang wrote:
>>> -----Original Message-----
>>> From: Julien Grall <julien@xen.org>
>>> Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
>>> arch_domain_create()
>>>
>>> On 13/10/2022 09:38, Henry Wang wrote:
>>>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>>>> when the domain is created. Considering the worst case of page tables
>>>
>>> Can you describe in the commit message what is the worst case scenario?
>>
>> The two pages will be consecutive but not necessarily in the same L3 page
>> table so the worst case is 4 + 2, is that correct?
> 
> So I agree that the worse case is 6. But I don't understand what you 
> mean by '4 + 2' here.

Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N - 1))?
Or is the root table not taken from the p2m pool?

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:06:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:06:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421866.667544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiw2N-0003fc-HA; Thu, 13 Oct 2022 11:06:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421866.667544; Thu, 13 Oct 2022 11:06:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiw2N-0003fV-CM; Thu, 13 Oct 2022 11:06:03 +0000
Received: by outflank-mailman (input) for mailman id 421866;
 Thu, 13 Oct 2022 11:06:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oiw2M-0003fN-Ga
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:06:02 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0521a653-4ae7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 13:06:00 +0200 (CEST)
Received: from DB6PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:4:29::11)
 by DU0PR08MB8953.eurprd08.prod.outlook.com (2603:10a6:10:464::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 11:05:58 +0000
Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:29:cafe::82) by DB6PR0202CA0001.outlook.office365.com
 (2603:10a6:4:29::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Thu, 13 Oct 2022 11:05:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 11:05:58 +0000
Received: ("Tessian outbound d354c7aef2bc:v128");
 Thu, 13 Oct 2022 11:05:57 +0000
Received: from de1d645292fa.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 69F53177-9502-468F-B118-BC4401AAAA9E.1; 
 Thu, 13 Oct 2022 11:05:48 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de1d645292fa.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 11:05:48 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB7860.eurprd08.prod.outlook.com (2603:10a6:10:3b0::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 11:05:44 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 11:05:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0521a653-4ae7-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=PdZrru1UhYcfeMOdAgm56v0zLMg/Qd7U0UhYfFUEDmGfHCHbyz2i+lz0wVv2oy0E27+fPcJVN+4au+OIYt9wCo4JlxjSEyKIqRxv2+J0r+NgW2UZD2PwNCxOEiRDc16iaSLRq25qPd6+P+VrrCOEAoCQq2f2gjM9keZLHPkbVqmpwcJKS/TM3yOFSvvzwkVJUFUmG/qOkPnKQPZlxCaBYXwG03deBllIdFo99qBrvGbcqotr68+umCjMnLDxVuBmAYGMBM1caSezhQ3akaaf95mjC05H67Q49i5UR0x4l6V2jz02t12+x0Zpy+Wp+J2BcOjfgv1WTtN+PkmWg0y9Cw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j2hGsz+tza4BmRvGnFdxEY33BsYLCs575k7h8s43/rk=;
 b=CMnQBn1VchPSHqtr/raxpIkAzhJGtFlDezKlfmR2Kofvm+KyZxYcBxxxHypqlqKGhFEjdEzV1lzaR9+wPIXPFkQE/VbeuJf9K05MLYgk0YzJl6DCt2ZxJOULuH5cYfW3wRmZRM9lghqk9tx/BtCTup0/D0ZeTWR0mH737q299iLNB+EOPxjJ0dqAcC4HXdMCfY2lsniXXDi7SMogZsBM09Mbr0ZGmkdHzUSJmEArYsuD0WV+8f62dIZ92l6089hYMGl//NVqN6NVSVmyk+R7FB3RSxlxO5xA9FuFWn3oKll3o50TkSdvdyKVIH/j4sLVumJImqHtkD1MVnNTxwz9KA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j2hGsz+tza4BmRvGnFdxEY33BsYLCs575k7h8s43/rk=;
 b=qPfJ/uHnhjNjAiDDjWh8F2JmCnPb39scLWnmRYYGZDUeOMXnPx54XJMWImtMLXzf/IMcQDjpXGqZmG3f8GODdM46CXHpy6HugSt2J15G9QR+0h+nLGTa4yypRvMwCBNO8URflRD3WlqcotAU6KPi4V3qXBhbzTMArmdyRvyxKvg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dx95tLzppuoDJ0MD+iby8NeIL8Zjgxd2jbEdQKWaxtkLd+c4naesz2BR0X1wweT1tNeYHOfv+Ib+x6qXEVN8d1lBwfU7mtUYcmd78FxOtkks4EDOtUeSf1ZVrBY2P6ezCcVNzcgQGKfqLvZ/1hLfHpDZiNe46x85ws/CWU/FLsoTeurAXPpCz7HeT81Kk679Jo0KsIt53imOceu167eRGM9hgydWIV9JjoRqCgkXMKoHqrMzvfaZ+OHKIchy5rzOQSBxfsbYDIFJDchWudt3eMw2vnnOLzD6sflBjA3cDLEJ+68gkhL2bd5B/7BtdVaW1uEfB14AH2EcUqBuI0XItw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j2hGsz+tza4BmRvGnFdxEY33BsYLCs575k7h8s43/rk=;
 b=mtBrEILeRxII46+LxOvRnP/QQmkNmYxTKv59PuvTDP2UoUL3KntzyCdoGjKRnwYePExdKOqbyW+QJwSJCN2pso0QTQuzEkXmwDxQmGhfaVWSjCF8zTnxlRbyPsB981wGs3nRwyOXxzCIoDjXpGJhjMDJACTxgIjjrPTywfC2imjzjHIr7UjxGtLVABLn2/Qzax0FtRjhMUK6k+SuJc8cQ0HrH7vx5L7a9ZraJFz8SAo4wJHqv6xh6fozAvYse49tUAffqaWoHUOAByP2I1AGic3UpepgPHC2MPq2KjRPYqps2N/mpe6rfM0Rf75rALJ9MXis5CWGj92W+/kC3rBnYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j2hGsz+tza4BmRvGnFdxEY33BsYLCs575k7h8s43/rk=;
 b=qPfJ/uHnhjNjAiDDjWh8F2JmCnPb39scLWnmRYYGZDUeOMXnPx54XJMWImtMLXzf/IMcQDjpXGqZmG3f8GODdM46CXHpy6HugSt2J15G9QR+0h+nLGTa4yypRvMwCBNO8URflRD3WlqcotAU6KPi4V3qXBhbzTMArmdyRvyxKvg=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY3t81xdeRddBbSEGLoF20gErPe64MCngAgAAAYwCAABzHgIAAAcyAgAAAK9A=
Date: Thu, 13 Oct 2022 11:05:44 +0000
Message-ID:
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
In-Reply-To: <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 808D1175FD59EA4C8046F3CAD74C3793.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB7860:EE_|DBAEUR03FT033:EE_|DU0PR08MB8953:EE_
X-MS-Office365-Filtering-Correlation-Id: 9740cffe-519c-4c2b-2754-08daad0ae80c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jr2E3lS3RPGKfiGecZX3HHJ49297sveXMWj0GHTb5i2E0U7MlfM7armzAvZbkTyJ2STFJa3iUuy60wYGLzBgktW1jj5phqKwBNLaiVBFhnJDNFXYiQXjpZKkmj/YT+XaaAwN12Clsr9K3W8oJr7G+HQqD21CZfuMcYFdediguSzvE9O1uxDoBY6jo4wnL8Nj3Ux5XQXuTYt6kmZEhfZTXt+o6/kuE/7Hyoc+nJGWl7xkvepqOuhCT4SiE8hV3FLFtHjuW60+oBlWS1xgK2gDbc8DGM/dJxpllSHdMXHY1FUovXHcKafdbHznNqk2IRKJ3u59qSXHVO9jl1oD9jxj7ICYfLo5wuT0caKuVix+uSdaNEwSBOQuoiJ5xtoKBs8hLB+GA8WTD4ZEqgdDdpgsHo/LTUw/VMBBVQg8CQubwcClI3ZLe6tm+juf+gSemZxNsvswACusDau5rZOFE75464/jxVAupJSzx1GfzkQhp/KiazD5taKmr3bMLJevPF+JxFGo15uDj+gSTFRNceaXUK2v2kYB6ufjgPeEvamhmcVWbD+ikfuiqmWufVjtMlCn0h6N21xWze1LOYDMZaTZcfq6bQhGLaRDHEHS2v1I+ziCbIRUuUEvZ81QumMFSj0hmbTaJjTDNRzQgkSaid0NnuuBuliiJ4ngIFpscQC+aN2DgbDVhlJZqHGCFRm0fYW/TkZw6SzKXrnN+0tfoVWfj1Tywj+2kULhvrGgY7OmIfj/9BrBSrq0nuEOyLaKgNmXQcRZzq2h5fJYu17FXHrOhw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199015)(26005)(6506007)(53546011)(7696005)(122000001)(38100700002)(4326008)(66556008)(64756008)(316002)(55016003)(8676002)(66446008)(66946007)(71200400001)(76116006)(66476007)(38070700005)(86362001)(33656002)(186003)(83380400001)(478600001)(54906003)(2906002)(41300700001)(5660300002)(8936002)(9686003)(110136005)(52536014);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7860
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f423bf99-b487-4890-b2a9-08daad0ae02c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x3cYjcAc7cimeh+qJpR6xMoJrAk8DQG576TJywpHG+OWECFBJZIyXFot9bkjBvXnBqwtmMEuta0E+11if8rMWZBwD4cyZz/Y9qgh0e9TxAwNmY9e1BGp9QM8Jl65UqnR9QMHOq1xAhbEktKO1zT3+lAWmC3z1tTqEzU22DhahvFM8GZ2P4ZNiRG2LwhTjLUN2Nh77K4dtcFGaAFSYd2mZkXGVHaw7OvIY+y7Nque66yxVbcbJlh6YUyrnLho7BJc1gspAyQPTw8oDc8MTuxoRmW2m+OOnLdta5OBh0+6jNWAub5TkV/hBhgaYpQthCE45Mw2c/VGtgrpuF3pJ4e6WQw6JP7t+048Ku45yJUFnxytHG0KJf0gqIuS1U09tNavFCJ7M3SfmLwkhldnTzEUTViukzJ5RC2LgmRNSNqhPdg+2NeqfLXUOMuqQF11I09oj2VVaqboKXVUE80fvQUEOYBAUR8/3QrvmIMvCtrLeESjrU2OVEvZYV3IqgFqvQmEZ8jOAls6LQYjZmdIIFh9uQ1mLgBMPhfLQRUWRnnzQOzV9dtM9HREme5OpXvwzSvUgjH0Ws0TBapa9kIyL4yir4B7vFM+SRGNAm7nsxIJOLjuJhf0TPfwkInQDiD8CFbqjPC57aXawoxRIcVW9Mdd1sNoKnOsRLQ3NgdHuGUctFYdo45IveOVd4ITrGhQei3pWrnsmuMbTN08iY02F6CA++6nWjYGdnGUB0f0Fdwf6nvhciD7MLM5CMIj+2GA1fAicXgPv1ebooL3Jch6A6UD4Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(33656002)(82310400005)(40460700003)(2906002)(4326008)(5660300002)(41300700001)(52536014)(8676002)(316002)(70206006)(110136005)(86362001)(54906003)(70586007)(81166007)(356005)(8936002)(82740400003)(478600001)(36860700001)(9686003)(53546011)(336012)(83380400001)(40480700001)(26005)(6506007)(55016003)(7696005)(47076005)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:05:58.0735
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9740cffe-519c-4c2b-2754-08daad0ae80c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8953

SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSB4ZW4vYXJtOiBw
Mm06IFBvcHVsYXRlIHBhZ2VzIGZvciBHSUN2MiBtYXBwaW5nIGluDQo+IGFyY2hfZG9tYWluX2Ny
ZWF0ZSgpDQo+IA0KPiBPbiAxMy4xMC4yMDIyIDEyOjU4LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+
ID4gT24gMTMvMTAvMjAyMiAxMDoyMSwgSGVucnkgV2FuZyB3cm90ZToNCj4gPj4+IC0tLS0tT3Jp
Z2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u
b3JnPg0KPiA+Pj4gU3ViamVjdDogUmU6IFtQQVRDSF0geGVuL2FybTogcDJtOiBQb3B1bGF0ZSBw
YWdlcyBmb3IgR0lDdjIgbWFwcGluZw0KPiBpbg0KPiA+Pj4gYXJjaF9kb21haW5fY3JlYXRlKCkN
Cj4gPj4+DQo+ID4+PiBPbiAxMy8xMC8yMDIyIDA5OjM4LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+
Pj4+IEhhcmR3YXJlIHVzaW5nIEdJQ3YyIG5lZWRzIHRvIGNyZWF0ZSBhIFAyTSBtYXBwaW5nIG9m
IDhLQiBHSUN2Mg0KPiBhcmVhDQo+ID4+Pj4gd2hlbiB0aGUgZG9tYWluIGlzIGNyZWF0ZWQuIENv
bnNpZGVyaW5nIHRoZSB3b3JzdCBjYXNlIG9mIHBhZ2UgdGFibGVzDQo+ID4+Pg0KPiA+Pj4gQ2Fu
IHlvdSBkZXNjcmliZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2Ugd2hhdCBpcyB0aGUgd29yc3QgY2Fz
ZSBzY2VuYXJpbz8NCj4gPj4NCj4gPj4gVGhlIHR3byBwYWdlcyB3aWxsIGJlIGNvbnNlY3V0aXZl
IGJ1dCBub3QgbmVjZXNzYXJpbHkgaW4gdGhlIHNhbWUgTDMgcGFnZQ0KPiA+PiB0YWJsZSBzbyB0
aGUgd29yc3QgY2FzZSBpcyA0ICsgMiwgaXMgdGhhdCBjb3JyZWN0Pw0KPiA+DQo+ID4gU28gSSBh
Z3JlZSB0aGF0IHRoZSB3b3JzZSBjYXNlIGlzIDYuIEJ1dCBJIGRvbid0IHVuZGVyc3RhbmQgd2hh
dCB5b3UNCj4gPiBtZWFuIGJ5ICc0ICsgMicgaGVyZS4NCj4gDQo+IEFzc3VtaW5nIHlvdSBoYXZl
IDQgKE4pIHBhZ2UgdGFibGUgbGV2ZWxzLCBpc24ndCBpdCA3ICgxICsgMiAqIChOIC0gMSkpPw0K
PiBPciBpcyB0aGUgcm9vdCB0YWJsZSBub3QgdGFrZW4gZnJvbSB0aGUgcDJtIHBvb2w/DQoNCkNv
cnJlY3QsIG9uIGFybSB0aGUgcm9vdCBpcyBub3QgdGFrZW4gZnJvbSB0aGUgcG9vbC4NCg0KS2lu
ZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:35:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:35:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421880.667561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwUR-0007JI-TF; Thu, 13 Oct 2022 11:35:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421880.667561; Thu, 13 Oct 2022 11:35:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwUR-0007JB-QI; Thu, 13 Oct 2022 11:35:03 +0000
Received: by outflank-mailman (input) for mailman id 421880;
 Thu, 13 Oct 2022 11:35:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiwUQ-0007J5-16
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:35:02 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00058.outbound.protection.outlook.com [40.107.0.58])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 11ad9e11-4aeb-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 13:34:59 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS4PR04MB9482.eurprd04.prod.outlook.com (2603:10a6:20b:4eb::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 11:34:56 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 11:34:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11ad9e11-4aeb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EN1NC+YQTGmjcnD9/NVcC2FlVvpIoxQViYkM6ib+8wKgRkj7i7trYH4NnnVBOl/czWJZ8+re+XkM20AocMmbKARgDDJBS+39UuahDrG7NsWudQcyYRA6E/FL993OmOnNt0+v7mjilwHVGyWDDTVuxJEK0/bkX36bXDoeKsB5BmZKeI3TXUkiEFF72FPyGAd/JT8mZxHY9RQnFJ8RnQq0WE6IJGtPI1q9oC4fBc3+Bb04wbV1RCuS2+arVQiZli1V+oZamPSzUFg0SfmyUpPCjN+8YeGGRFW9u/3RI8kS1jhfnfOPt/i7tOyzA9KjtNKpmGrpaJNCjoshXQwBjB6hxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5YaMyZ/Sm76bOlCWIFmpzJUDd91GPdZ/WxGp7jwyDls=;
 b=MH2gXdSp3451argX+wgYp1RITa6X2+nbVvaAcOdN5ZLq55BuMqo7cuioZHPwagLwPP7xMiq1xAxcaJ9qrRNy/K8lF3UTvgsMzcMvEJfy6x3jJiRDlkbpNx1TfelSjSlCtqrE3uWAKpKwyZdNYwe9bv9OSvKCgVImH4wNM9q7zUKHh/ltvaKJTb0W1XmsSjqwvakRjUGAcqFO/Wvqga2BPEcxLht/BzoKv5RG0+A7jqs1O2ZsQ8fgfPKUk5N8wK5+SnOd/ABiZHIeHmVk6sDUgAPTNGNlK+B+KxCPN959FJjF+6/99rZRQVA/2E+qvYd3O0uuVwgG/qRp2V5JC/p6hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5YaMyZ/Sm76bOlCWIFmpzJUDd91GPdZ/WxGp7jwyDls=;
 b=txs00q6RGVaPv/L4t/Y9LKCH3E1P4o7FXUI5Tk3oSySKLma2m7w2SZMkipmVflwB3W8xGK3tNq3JVXf9VqQ/4v55w+euv//H32K7IEIGFdgyVwi9k3A4hcObNVjOqoAq19JAV5QQxSv4Zbz6P1Qu/+KbXXFKM05DR/Iwkpay+wU7wPrkztWq8zb4qg9U0TaL3CaNbDW/s6iD/cPBsd1y5R3aKv4mUccieyQjANaWGmPX+Wl0MQ63lD52ITWKETQdlY221nZ7PS5ooVo6n2vV6wuPo5mz2FNApkfnE3ba2QFIHdF5PQLSotblhHt6C3pAyPTg26+w7nJT+MOFphvM1Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
Date: Thu, 13 Oct 2022 13:34:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: Proposal for deviations in static analyser findings
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR06CA0706.eurprd06.prod.outlook.com
 (2603:10a6:20b:49f::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9482:EE_
X-MS-Office365-Filtering-Correlation-Id: f9dccc44-991c-40e3-0ccd-08daad0ef40d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lpyLbwv8kgzk7PSJ7o4kHcyeF4w6HSicpb3MZCosYiNjXx4lQDqRBaSReHUf9sR9oNwDw1QmSpqtkJ5HQh0TogwasMoDlxIUAII26IGfbZd9KU34Ft7bwNCaiW9zfLVlRUhu+213I8mHODzU8VuURR0aVMSnk0Hjm7vIMfY14dAwvsUbNoh5g4iubbCr+Ymx77hmYi76LkvOZErmX9KbQckNB8pKlv3potd0Qta+w+kGp7qa6fxGkbh0aVQm0HvB2R2oV/dW1IJ2aozEYA5cRdSvBg04g/ejHpmBnZ00chMmPOfJOLoU9wrThoQ33aR0zD/MdEWPOqgHf9TD3EYeZLdEMMVeAs/WHUSxIS6pjpXSA6A3TPob7n6Q+izgWpLcxmiV/lUxMNoNaLwzAcgWfYaeqKThnhQ7lxiGmHxndUqiITsPJVa4zovfmPBoE+MDu9GF8isH9gMC4fplMrFYSXr/UCc3U9w+Ww7ZnHX3+lpDCfTw0N6fi22aRpox3VRD2jIkDt6uHCrzL13GWG6X15quU5ahvXd/hKzC/Gw40wMwXMIGZq2SlgC8GS5VdN6iUEJMkNDQCMP/1KQCkpkkDDIEsqmHt8pllpZHlRDbJfysiN7bGdQZAmcIiAsWlZ9uJ1OYzw0KrMIX2ue56cFmYlJE++iiCFUITWG3wxZh1ELyxcPOQ9KPDeP3b6FJ3yFV9+zBQgWk431jvXwCKoOuvgHYLrHU99R7+3Ndke75KNsdYtfCwgTtLDTZRFOiygj0mn3KlanP38V9mU3BwAvDbHcEvby2R6iDTQVUcUou5OGorfhE3wqKvECktOgWcEyiltKdA0vbpHDjxI8mNfCVFw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(186003)(36756003)(2906002)(66476007)(316002)(66556008)(38100700002)(66946007)(8676002)(30864003)(5660300002)(41300700001)(8936002)(31696002)(86362001)(83380400001)(478600001)(6486002)(6506007)(4326008)(966005)(53546011)(2616005)(54906003)(6916009)(31686004)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?emxiOEVSUXpwUm5xY2N2NWxjbCsxSS94amFFeFZRQlNsNlNycUVyWnNzcExI?=
 =?utf-8?B?WWJwbGFtbDRDVkd1NHZ0eW56ektqNElrcHJOY2x3WU55WVFYdXV0MXhzRFdy?=
 =?utf-8?B?TGVWZjRNSzQ3anRsNVhvY0EwVDhJNHYyOVdJeloyNVlNelU2dHVCVDQxSzV1?=
 =?utf-8?B?V3pHUUFJMUhoS1JaL2pudGhLV1YxZDlTWkk4U0Z3TkRtR251ZDMrWEVBaGE5?=
 =?utf-8?B?M21RTXZiK3lVaDBrUjFVNkRQcVdIalRMTWVGOVRNNkt2VDNsaUxncE9FZmY4?=
 =?utf-8?B?TXFOd1JKRXN6TkdFaFhpdisxSUFpZ0FjcDJzVWJ3eTFVUm02S0JLa0R5WHNT?=
 =?utf-8?B?UFRIdW9xenEycG9PdTYzQzZBMnRERXJKTDhIeGR4ZmtVbTc4NFJLeXpTUDZG?=
 =?utf-8?B?WVNvbmM0YnVFNUgzSWZaREtReVRpK1dveFA3bWQrUVVFUWVzVHNlb1MrYTlP?=
 =?utf-8?B?Z1MvYXVwb3B4TUpQQXpnNW1pcXpRTmphYVkrZWFXajExK0krWFlIdXZsSnl6?=
 =?utf-8?B?UDR0ekZiTklXVWl2WGZ6dlZXUFlMVkxUT1JIcnRlZmtJcCtWQUVySXBBbFdU?=
 =?utf-8?B?OFJZd0pJRVEwNzRaMEwzK3NtWm1hWHEzTnl2RW9GbUtXUnFrUkZlYUtwN3hV?=
 =?utf-8?B?OWxUVCs4bmFnNERtdnk3Q2poVlkxbHVJY0ZZR0tGREFmUGc1aXpjczZuNHJ0?=
 =?utf-8?B?VTUyVThjSGYrbU1TUVdvVnBRcnh0a0gyY0VMRnVuT1pmeE1xQ0hpVHRKMDNT?=
 =?utf-8?B?YXZGcE5pOXVsSWR1bk1JdzdWRzZGeDBSV05RSGhFU2k5Wk1iMVNQcDA3c2ph?=
 =?utf-8?B?K29XRGZ2U05Ld0lXN3g4YlBvRngyZ2hYQ3JzY3d2NEY3VlVXYlM5L3Rnc1Bn?=
 =?utf-8?B?YStYNkZzbkpCYll6MGNPTFlKMVhhTUd6b01ZTTltWVJEbTR6OTRJQUNjSWJR?=
 =?utf-8?B?NkRJZTRaTVdhRWV0VmZRclRQSXNmYlZPWVhyZnFCZVNCais4c1FhKzE3Zmdl?=
 =?utf-8?B?ZFlFQWtiKytDUDVIOG5wZ0hoRTRQR1k5VEJUbzFISTFOSmdjZkRYTnkvclVv?=
 =?utf-8?B?T0I3bG1TZDFnWFZEZzhrWnplTkNxV1hwZUp6aTU0bG9VeFhvOHN0TkVLYkV3?=
 =?utf-8?B?eE16VzJFMW5lMlgwNVhrK0ZJRWdXajk3dXRodjMzbzAzdXNoeVFLYVNZQjI0?=
 =?utf-8?B?clVEV290TmNzcXFqTldKU0RoeGVWNGVUTlJTb0ZNNzN2ZlpOaHhLRFVhVUk4?=
 =?utf-8?B?UmZ1NlE2RW84Q3BPc0pWNHdtQjlhem5rN0w3eWhmVTJEZ0hJazdGSjcrbmxz?=
 =?utf-8?B?bmVhaVdYV1pjd3YweFBHQXloL09RZStSSUs4OXVYeXlhT3BPNXpkR2MzN0ZP?=
 =?utf-8?B?a25sL2lMdWdCWFdCRWZhUm1yS3dPVGxINVFsT2lxQjdLY0t1bEYrQ1RQeks1?=
 =?utf-8?B?Tkh0MUVFZGJCVzE5U1ltczBQSG5GWTZGV1d3SWZFcjZzNEVxS2hRd2twWFM3?=
 =?utf-8?B?NnpsM0ovRVdBZ09Za1FnaHhjU2p5REU3REVCanpDWFJjSmpWQ3hUSTRxK20x?=
 =?utf-8?B?VFpjUnFKVC85eUVlMEIvRUZFb3JXL0RhZitiU0p3MTNpWWxJV0lLbTFhZmFN?=
 =?utf-8?B?emFaUzZuVmx1NlJ1NXFFd3Z4TXJjalhJQ2lYYU5OS2pwODNJNlZZUmpPVDM1?=
 =?utf-8?B?M0JjR3VZV0l6TEVZT1o0MWYwMW5ESEMyVmRaQlFrT05tT2xyMUtpT0MxY0dw?=
 =?utf-8?B?dUxkYlVjY1hCTkNBTEhoRWNGbm9zOXJCYXNrYmRXZGZjOFovVlJ6Z1FhUkJ0?=
 =?utf-8?B?TnFlUngzamdlSFlBMkNEcUtGTmlpOUExK1FhNDRCNzUzbDJvQ1hoMm84ZmQ0?=
 =?utf-8?B?dXJjdHdsaFFTdmRCeXpsMlRXTnU1NEZBNTMxTlVKUkd3bUQxNlR3RlRNcmoz?=
 =?utf-8?B?bEcvS0llRUlhWHMvWlRWeFlWSVF3L0NoNkl6Y2ljd1BRWGxPb3FBcEJDSWY3?=
 =?utf-8?B?bVpWTHpWL3o1b0EveDRST0M0Zmg1OENRQmlsbkFQbkdHSEp4bi9rYTY5QUhv?=
 =?utf-8?B?bVl4Y05BeVBjV2l5UTNzemNmWllKckM1VTVIRVZGZC95TGxLMi91RDJnR29i?=
 =?utf-8?Q?atnyMJxqu0MTB7DijYXcdkUSp?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9dccc44-991c-40e3-0ccd-08daad0ef40d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:34:56.3552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CVdLLbgy3GkQTzRZFWaW5Yxe0Y+o1nE2mLxaaAMA9fx7zVHBl9hSgPJODS6wKMfUOYi5ryiOZwMAsqJkBRASYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9482

On 13.10.2022 12:11, Luca Fancellu wrote:
>> On 13 Oct 2022, at 08:50, Jan Beulich <jbeulich@suse.com> wrote:
>> On 12.10.2022 18:00, Luca Fancellu wrote:
>>> In the Xen codebase, these tags will be used to document and suppress findings:
>>>
>>> - SAF-X-safe: This tag means that the next line of code contains a finding, but
>>>  the non compliance to the checker is analysed and demonstrated to be safe.
>>> - SAF-X-false-positive: This tag means that the next line of code contains a
>>>  finding, but the finding is a bug of the tool.
>>
>> We did discuss this: False positives are often specific to just one of the
>> tools used. I think this wants mentioning here, including the implications
>> (iirc the plan was to keep the tag generic but make the table entry express
>> which tool it is that is affected).
> 
> Yes, in the database format below, a false positive entry will have its key-value item
> in the “analyser” dictionary. Moreover, a false positive entry could be written for
> example as the line below, to suppress a cppcheck false positive for MISRA rule 20.7:
> 
> /* SAF-0-false-positive cppcheck false-positive for rule 20.7 */
> 
> Clearly this comment wants the proper entry in false-positive.json with the correct internal ID
> for the rule 20.7 given by cppcheck, that is “misra-c2012-20.7”, and a proper justification that
> explains why it’s a bug of the tool and not a non-compliance of the code.

All of your response doesn't really seem to fit my request of making more
explicit that in the common case false positives are expected to be limited
to just one tool. (In fact I was wondering whether, other than for the
"safe" table, there wouldn't better be per-tool false-positives tables. Not
the least because false positives are also liable to be version dependent,
which currently you have no way to express.)

>>> Entries in the database should never be removed, even if they are not used
>>> anymore in the code (if a patch is removing or modifying the faulty line).
>>> This is to make sure that numbers are not reused which could lead to conflicts
>>> with old branches or misleading justifications.
>>
>> Can we add provisions for shrinking such entries to e.g. just their "id"
>> line? Or is the intention to be able to re-use such an entry if a matching
>> instance appears again later?
> 
> I prefer to don’t shrink it, the name itself is not very long, even using many digits of the incremental
> number, it removes also the dependency on the file name.

Name length isn't relevant here, and I have no idea what dependency on a
file name you're thinking of. My question is a scalability one: Over time
the table will grow large. If all entries remain there in full forever,
table size may become unwieldy.

>> Taking this example I also dare to ask: Shouldn't tools be aware that
>> token concatenation necessarily means no use of parentheses? See also
>> below.
> 
> Yes the tool should be aware, in the example below, the tool is complaining just
> for the lines 75 and 80, in that particular example I would have fixed the finding
> instead of using a justification, but I’ve reported that example just to show how
> the finding can be suppressed.
> 
> Here the link to eclair: https://eclairit.com:3787/fs/var/lib/jenkins/jobs/XEN/configurations/axis-Target/ARM64/axis-agent/public/builds/541/archive/ECLAIR/out/PROJECT.ecd;/sources/xen/include/xen/param.h.html#L75_violation
> 
> The coding standard wants just to have this:
> 
> #define string_param(_name, _var) \
>  __setup_str __setup_str_##_var[] = (_name); \
> __kparam __setup_##_var = \
>      { .name = __setup_str_##_var, \
>        .type = OPT_STR, \
>        .len = sizeof(_var), \
>        .par.var = &(_var) }

May I suggest that you pick a real example then rather than one where we
actually want to fix the code? People may derive more than just the
intended information from any examples given here.

>>> Here a brief explanation of the field inside an object of the "content" array:
>>> - id: it is a unique string that is used to refer to the finding, many finding
>>>  can be tagged with the same id, if the justification holds for any applied
>>>  case.
>>>  It tells the tool to substitute a Xen in-code comment having this structure:
>>>  /* SAF-0-safe [...] \*/
>>> - analyser: it is an object containing pair of key-value strings, the key is
>>>  the analyser, so it can be cppcheck, coverity or eclair. The value is the
>>>  proprietary id corresponding on the finding, for example when coverity is
>>>  used as analyser, the tool will translate the Xen in-code coment in this way:
>>>  /* SAF-0-safe [...] \*/ -> /* coverity[coverity-id] \*/
>>
>> In here, where would coverity-id come from? And how does the transformation
>> here match up with the value of the "coverity": field in the table?
> 
> I can put an example of that, as you pointed out it could be difficult to get where
> this proprietary tool ID comes from.
> 
> The proprietary ID (Coverity in this case) comes from the report it produces:
> 
> […]
> <file path>:<line number>:
>   1. proprietary_ID: […]
> […]
> 
> after we see the finding, we take that ID, we put it in the “analyser” dictionary as:
> 
> […]
> "id":”SAF-2-safe",
> “analyser”: {
> 	“coverity”: “proprietary_ID"
> },
> […]
> 
> So in the source code we will have:
> 
> /* SAF-2-safe [optional text] */
> C code affected line;
> 
> And when the analysis will be performed, the tool (coverity for example) will run on this source code:
> 
> /* coverity[proprietary_ID] */
> C code affected line;
> 
> The tool will write a report and will suppress the finding with “proprietary_ID” that comes in the C code
> line after the comment.

Let me add some background to my earlier comment:

If we wanted to add such IDs to the table, then I guess this would result in
a proliferation of entries. If my observations haven't misguided me,
Coverity might re-use the same ID for multiple similar new issues found in a
single run, but it would not re-use them across runs. Hence irrespective of
their similarity, multiple table entries would be needed just because of the
different Coverity IDs.

> After the analysis, the source code will return as the original (with the SAF-* tag).

While you mention something similar also as step 3 in the original document
near the top, I'm afraid I don't understand what this "return as the original"
means. If you want to run the tool on an altered (comments modified) source
tree, what I'd expect you to do is clone the sources into a throw-away tree,
massage the comments, run the tool, and delete the massaged tree.

>>>  if the object doesn't have a key-value, then the corresponding in-code
>>>  comment won't be translated.
>>
>> Iirc at least Coverity ignores certain instances of what it might consider
>> violations (fall-through in switch() statements in particular) in case
>> _any_ comment is present. Therefore may I suggest that such comments be
>> deleted (really: replaced by a blank line, to maintain correct line
>> numbering) if there's no matching key-value pair?
> 
> Yes the line won’t be altered if there is no match. This to ensure the correct line
> numbering is not affected.

"won't be altered" is the opposite of what I've been asking to consider:
Observing that comments _regardless_ of their contents may silence findings,
the suggestion is to remove comments (leaving a blank line) when there's no
entry for the targeted tool in the table entry.

>>> - name: a simple name for the finding
>>> - text: a proper justification to turn off the finding.
>>
>> The distinction between the last two doesn't really become clear. Taking
>> your “Variable set but not used" example above: Such a "name" will fit
>> many cases, yet the justification for each might be different. Hence
>> the question is how unique "name" should be and - if it doesn't need to
>> be unique - what information it is intended to convey.
> 
> Name is not enforced to be unique, it’s convenient to get a subject for the particular justification.
> If the name of two justification is the same, but the justification is different, then it won’t require
> much effort to write a different name to quickly recall and differentiate the one from the other.
> 
> However if no one finds the “name” field necessary, we can remove it. It was introduced having
> In mind that at some point a document will be created with all the justifications together.
> 
> If others are against it just reply to that.

I can't say whether I'm pro or con as long as it's not really clear what
information is to be conveyed by both. If "name" is somewhat like the
subject of an email and identical names are deemed fine, then so be it.
Question though is whether having perhaps dozens (or hundreds) of
identically named entries is very useful.

>>> Here an example of the usage of the in-code comment tags:
>>>
>>> /* SAF-0-safe [eventual developer message that shall not exceeds line char max count, don’t break the line!] */
>>> #define string_param(_name, _var) \
>>>    __setup_str __setup_str_##_var[] = _name; \
>>>    __kparam __setup_##_var = \
>>>        { .name = __setup_str_##_var, \
>>>          .type = OPT_STR, \
>>>          .len = sizeof(_var), \
>>>          .par.var = &_var }
>>>
>>> In the example above, the tool finding for this macro is suppressed. When there are multiple findings for
>>> the same line, multiple in-code comments needs to be inserted, every one on a different line.
>>
>> Since this is about parenthesization, would
>>
>> #define string_param(_name, _var) \
>>    __setup_str (__setup_str_##_var)[] = _name; \
>>    __kparam (__setup_##_var) = \
>>        { .name = (__setup_str_##_var), \
>>          .type = OPT_STR, \
>>          .len = sizeof(_var), \
>>          .par.var = &(_var) }
>>
>> satisfy the tools? And wouldn't we better not mask detection on this
>> construct anyway, since the last of the uses of "_var" indeed does
>> violate the rule (without parentheses added)?
> 
> Yes this was just an example of how to suppress a finding, in this particular
> case, I would have fixed the error instead of suppressing it.
> The changes to fix the finding is above.
> 
>>
>> As to the placement of the label: It was repeatedly said that analysis
>> occurs on pre-processed sources. Is placing a label ahead of a macro
>> definition therefore going to have any effect at all? Wouldn't the thing
>> rather need to look like this (assuming a pre-processing mode is used
>> which retains comments and respects line splits despite the use of line
>> continuations in the macro definition):
>>
>> #define string_param(_name, _var) \
>>    /* SAF-0-safe ... */ \
>>    __setup_str __setup_str_##_var[] = _name; \
>>    /* SAF-0-safe ... */ \
>>    __kparam __setup_##_var = \
>>        /* SAF-0-safe ... */ \
>>        { .name = __setup_str_##_var, \
>>          .type = OPT_STR, \
>>          .len = sizeof(_var), \
>>          .par.var = &(_var) }
> 
> From the experience on cppcheck and coverity, it is enough to place the
> In-code comment above the first line of the macro to suppress the finding.

Interesting. How is the comment then propagated to all expansions of the
macro (in the course of pre-processing)?

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:36:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:36:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421885.667572 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwVu-0007wI-7g; Thu, 13 Oct 2022 11:36:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421885.667572; Thu, 13 Oct 2022 11:36:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwVu-0007wB-4E; Thu, 13 Oct 2022 11:36:34 +0000
Received: by outflank-mailman (input) for mailman id 421885;
 Thu, 13 Oct 2022 11:36:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiwVs-0007w1-Bu
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:36:32 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00067.outbound.protection.outlook.com [40.107.0.67])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4837676e-4aeb-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 13:36:31 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS4PR04MB9482.eurprd04.prod.outlook.com (2603:10a6:20b:4eb::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 11:36:30 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 11:36:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4837676e-4aeb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=buq4+Ld87xb4VrYEiR9MZoYbdBfmyWsAfjW/lpI5Eh6GWef18ED740FG/a4oF6yw2TYWULRrV4+sjNzqKJ/RPxW5MsN4w93RIC++61SkPm5gLdjCqcETzIjnY1p5MfwpDAaDjIrpYJxjuACo4Q6/zTBln6rnNAS9UfI4rtCYJ8QxyLLb6rBnmmVdwtwjtvfPU5OvGXlwRe8d+e15YIe9X1gxkqDEvrv/lp9dDC5JK3aG8JRsOUDJp8EX1jxCQ5qb7rYGknIYc+DWWQfHqXGIdmuGc2j9hpegY7nYg9jB+CpauHqVjQHdbYaZArVa2JuB6KHzo6lNg/xTPH04YitvLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xrD0a6zLarfr8oL8gPj36xX2OAP6I10+pUdEw4s25CI=;
 b=n8PwcME+MBX+EGJURBzh7ThGlDs9fT877V6m4Uk0co55Vp/HsT3nIoR4xvhSuKpMs3n6f/7P6N+IG8S4zI8TwipQSHPYgsCICnm4f9yoU0upJM/O0zWeBIQrIB9K+oWU3Y6huoznLW5NtyJBEWDqgfgyo8djcHbc9x45Bt7A+k8R9CWBaHUm8FGWZbJuQp0Rl2wzRWufz7zFday/8K2AddAqEDJoZJZAuqHTSOE5w1/4Neowl1bkmEWp2S6RDP6Y44NT2jG03jR3XkXFQK6yifNvEZTpdVVR5X2l8SrET64QH8xCMpFO0V6Ydp0KN6YxYKhK/Lw8G52nKfkX48uDAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xrD0a6zLarfr8oL8gPj36xX2OAP6I10+pUdEw4s25CI=;
 b=VOxCK/yvI8taNxfTHXscNU/dUZpo1FeNkaF7eDmF+CBjLywuIdrVHd2GJH5jZYhk0ZISDJqGiJWODxwgCW+K4Wu9SzE19MIvBGyxYtOIN2zg3KOPZF1+dBoGPQ7oFF8MntzRjOQ37kBgyuL0qJAeZ4lw3WiL5n2Vh7WVtX7VofiUy2nCGU0tP+W8Gyubyn1kjCK9BMVMrQRaAvkkx5+O3TEUYhzxsDpgtvURDGE4b7WjrJYdDpO3sAWx08b3CUWDEcA/sdc/rFdQPOYFubLtfpgvZKt+p2soekuSh/iA+rnQKZ2TeNU6iQl0KL+1hrvigVB1Kovz9yf4RGCQy3/NTg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
Date: Thu, 13 Oct 2022 13:36:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0123.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::9) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9482:EE_
X-MS-Office365-Filtering-Correlation-Id: 694c6554-e4b0-4baa-1af6-08daad0f2be6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wTuHGFFLSpugxk9qy5N8hqt0/U9ykDWZAR8TpHnqxzU2P1HCTByeeeNstCNEkT8lIGKnO2CtnmCPOIud5sB0MyjGLjbWikz5hXVg4o2Gjdzr+bKbFdb4wsmlqBfnBgNzDW6UAooYyJNTsfbcV0ysU6LkfSFPiCg0CyYat8fnn9Ewd8T6ny+mWnv5tfoWYSgag8kPiJg+7v3dJfxoghXF9llnZ5tM+YMciGLnc3EItbwvZLkkSqoj+YUHAh+itGc/LGIgIw+krcnfC1CPnU2DCEayTpuYbYjrEKmvA+BmnYzXvcEyseFp4zCFdgyDKKmmmvoiz/zjYuye6srIyMzzWJ+9A0W+ZREc6WFtEBJ7LAKfoVkvq348MIwPf66/XVC4hWe6ghjB4sR8eMYTE6LUjtxEvOhjaSVRSnYH5LwbpbTwK8S87flatQkGqjEPVxbLq0eGFCIqNjVvoec53UbgpCS3jpdJLvXcPuxqLDXEQeUf0t4RN/dNXUk3e3eXiXBrD/dXUSMc+BXiVTNxnObCVqotfQPZ5Alvinon8e+ZpP0/l0cYjpzl2lUUU4KtCv33dU/hDFr1psGdUnw+I5TMngssunkCeaO36NIshv8kmKEbcgmcRFjQcaN1IfIlnqIYtza8J41aDp1ynhKkW/tUzbWzYNnhJmexwreRVaL9qJT6RY/FVrIy64di/jFmwRCOzX1rv46hJGJxzRSdcvsI86dgBURBg7Twy1JR2b5GzyS1WPy/OMSFpzvgnNDQfd2iJRT3/l5s1Cn7dEUkTPSjmiQO2tpR1CUxPBnIGAFJ1Aw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(186003)(36756003)(2906002)(66476007)(316002)(66556008)(38100700002)(66946007)(8676002)(5660300002)(41300700001)(8936002)(31696002)(86362001)(83380400001)(478600001)(6486002)(6506007)(4326008)(53546011)(2616005)(54906003)(6916009)(31686004)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?THk4amdwUGFIcEJybkVGY3ZIWFhwUzBqQ2kvbzN6dHNkTzRrcktMNGx4TC9I?=
 =?utf-8?B?Rk9KQmFRR3l1Y1NZQm9DN2prU1Z2czI3dTRjc3NmeDF6QW16WTAvYS9CN29j?=
 =?utf-8?B?OXVjV3FlaE94M0FyZW5Kamx2aktQY25xbGRTRXZBOXRmbk13aG15MzVoL2FY?=
 =?utf-8?B?dHVPaXFTZ2tyU1EyOHBhTVlGN3M4Ulk1M2JNRFVISnRhZG1OUUxWblZFSTdP?=
 =?utf-8?B?ZEtPaUZKMm1UOXZiaERPTzl4eStrOUEzemg2dXE1MUVoWjkwK1lRUi9vbjFP?=
 =?utf-8?B?bFF2VTlHYVNsa3FmSng3bVphajlZcVBGTU55eHNmWmxKWTliRXZScFUvN09I?=
 =?utf-8?B?TlBLL0F6V2ROVmkwbnhuY0JwTGt6dytTWmVBMWhPNUJBTm84aU5hWC93UE5H?=
 =?utf-8?B?N09LUVRzWk5iUHNVSWQ3ZXd0MGNZUkpwRmpCY0pFSE03WDRTbytNQzZUQUFl?=
 =?utf-8?B?OHJJc2VEUFdyWEMraGlkS0VxODhBN2hPYlgyM1lMY0hNWUlNQzRtODdKRXlI?=
 =?utf-8?B?aTBWK3ZIb1dVbUxkNHF4NEVJRmRoMWZxdittellWU1RSMWphdVhEU1A3aVdz?=
 =?utf-8?B?a2ZONy9TY2tDWWt5M3NrTW5yMkd0akNxRG5jTFpNeDVYUE02UW5RaWx2RXFr?=
 =?utf-8?B?SG9YQkdESUlCUmQ3VTMySnE2SkR3LzhyMXZnRTdqODVWRHZ6c2lNclVZcndG?=
 =?utf-8?B?YWNnRmUyd1ZQZzNsUnY5V3dqb2grN1FpNmlUQ1Myek9xU0lFenFQd3o3Y3hj?=
 =?utf-8?B?TzFacWJ2UGg4ZVVNM2VpTEtHYlBhbUJjVG4wNUZxOWxXdjFTNTR1RnFhZnJw?=
 =?utf-8?B?UVRLZEpUN2c0MEw3MTlQbHFDM1d1VUJRdHdyemYvR2paNmU4d1Y4NGluZGxM?=
 =?utf-8?B?WkNyc3pFanFNVDRHOTZ4d3EyM1ArZWt3NVF5WFEvMWU0S0JlbnRSRkFoNkwr?=
 =?utf-8?B?L09sT1FwY3BwdGc1Q0Nxd1VOdmdIRmtHY3Q4SWk1dUtzZ2xMN1pnMGVUQ01L?=
 =?utf-8?B?YjFTcUd5RjRMRFllc1NhMUlTQjZNNU9tZUJJMzFxa3ViZUM2Kzg0YXU3Z2hX?=
 =?utf-8?B?TmYvMm1Hd1NNK2hzYkVmQ00rYTJaRDFPWHhGYnp1d2JUeGNUUTBtQTlOeGsr?=
 =?utf-8?B?bHZxQXZTNDVGcEY3TC9BYWlxazZZZXF3UUZCd0ZXRzVEeDJYdHpFUEpYREp3?=
 =?utf-8?B?SHZ6TmpSVG5va3BuY09aN2gxeW16SjcwaHdONVZlTngrN2FEcXNUcFlPOE83?=
 =?utf-8?B?Wmp4NVBGZXlzMjQ0Y3VtWFFqMDAwWk1KTldOQjJTZ0dZRUJ6NEpNUTNETkFX?=
 =?utf-8?B?ZTZZc3dhSWhTazRwVzVNOXVXY01adHFkUXhFSXUvNm1mUGlXSk1PUEI5aW14?=
 =?utf-8?B?SGh6THlMVGIxbTBVOFFtSVB2djR2N3N3d3B4N2NzdU8rVjJ0MktzY3MwbFFv?=
 =?utf-8?B?THBQNTNkMnVOblhhMmZmR2Y5Y2xJMTluMTNuT0xQR1EwTEY4dmhIRmNhVnF5?=
 =?utf-8?B?d3dCT0JxaUsyVEV0eVNaVWVnUFRDTEtwR20vRE0rdGVRVFVGLzA0b29LdXdJ?=
 =?utf-8?B?NjNNOCtnQlA0OXlobGxTTWtHT2VNRytvS3p0WHhSUXpINjNEM1BNSGs2N2M0?=
 =?utf-8?B?THFQaVdvcElPbmwzdVA3MWVpbm1LWXhYazQxMm1jSTJBWE1oamkzblNYcjNK?=
 =?utf-8?B?N0VFUVE0WGdLbCtYck9vWFhWMmJOYUU4aXkrNnd2WFVpU1RpV0lnN001UTg2?=
 =?utf-8?B?TllOb1dJdFRyK2Q1TmtIRzBlZmFKZVVZUGlDdmZYbk4xZlN6dG1pZ3VpazZZ?=
 =?utf-8?B?Smw2Snp0dDhrUHB0dVFtcE4rOSt6ZEZENDlkWVArcVJTbHkxRmtWZE1CZ296?=
 =?utf-8?B?c3UyQzNBTEZCVkRaTHBsSmRnTjJ0eDh0WkxpWU1HdWIzUzlKNlBkN2Z2blVa?=
 =?utf-8?B?ZG9wdXpLRFFrQTZxaFFNcnBJQVZtaTJZdCtEV0F6T1MzbXpuOWcySnRna05n?=
 =?utf-8?B?cCthcjlLeExGQVRoNkV6YzF4MlE2SDNZOU9iNjNQdnJzZkx6UkFHTHJMOC9R?=
 =?utf-8?B?U1RCbFpESDNIKzkvRkFWK1FRczFrSG9CMVlIRUZ2ZzIvcktUY09scXRGTUpO?=
 =?utf-8?Q?7AxRvGRW+bki0EYNFboBIptcQ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 694c6554-e4b0-4baa-1af6-08daad0f2be6
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:36:30.0055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r61dZluwNeCPeaDSYkPujBiEExQh02dJv44RVXoU1q9USBCMlGMas6i7cFI2yMZlINtsE0lcsukzQiFbfDXA9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9482

On 13.10.2022 13:05, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
>> arch_domain_create()
>>
>> On 13.10.2022 12:58, Julien Grall wrote:
>>> On 13/10/2022 10:21, Henry Wang wrote:
>>>>> -----Original Message-----
>>>>> From: Julien Grall <julien@xen.org>
>>>>> Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping
>> in
>>>>> arch_domain_create()
>>>>>
>>>>> On 13/10/2022 09:38, Henry Wang wrote:
>>>>>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2
>> area
>>>>>> when the domain is created. Considering the worst case of page tables
>>>>>
>>>>> Can you describe in the commit message what is the worst case scenario?
>>>>
>>>> The two pages will be consecutive but not necessarily in the same L3 page
>>>> table so the worst case is 4 + 2, is that correct?
>>>
>>> So I agree that the worse case is 6. But I don't understand what you
>>> mean by '4 + 2' here.
>>
>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N - 1))?
>> Or is the root table not taken from the p2m pool?
> 
> Correct, on arm the root is not taken from the pool.

Isn't that a (perhaps just minor) mistake?

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:48:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:48:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421899.667601 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwgt-0001Ga-I9; Thu, 13 Oct 2022 11:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421899.667601; Thu, 13 Oct 2022 11:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwgt-0001GT-Eo; Thu, 13 Oct 2022 11:47:55 +0000
Received: by outflank-mailman (input) for mailman id 421899;
 Thu, 13 Oct 2022 11:47:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzGh=2O=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oiwgs-0001GN-Kf
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:47:54 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dde866bb-4aec-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 13:47:52 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by IA1PR12MB6329.namprd12.prod.outlook.com (2603:10b6:208:3e5::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 11:47:46 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836%6]) with mapi id 15.20.5709.019; Thu, 13 Oct 2022
 11:47:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dde866bb-4aec-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DwkRU0fIxBfOtIXYXPBnOL1ps62i71kOd4TWmabXXW8VG/JvHBnIM1dlwpEiPHOICwJpUCKLk3gbfGZLr3PlTXy5uMRCpcIdoNA/DDUtm2IsvsMaD3fFsaFd3LxKFfW3jZMW5M86sn3+h/zYUEE9h0st6eFMLx+TVoZ8YRjkpdejcMXz/MTKtfxMdNzfe4DFkH8oh1DsOkWhWcxOh+xcJQ+dnykrnv/JJyDaz2spVsdMGZjGvlkq7zmvtGcwaLwI0pUdh7v/aUpjEkks2d1ngLmpCJoledMuq9E7R2Jxr9mZOJdQ4Hhz3Bh7Bd/4UfmefoTimfJXmcG5MC+xyoyO9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q51t3g8JHDy475L9KMyzHLlrXzyn638WimG9W/daC24=;
 b=Fd8RGOU3ocI84wuSuStxPtGjgIm28Z9AtT9hcCLkvsSdhp4Io2OcwLqF1GMwWhAxq6XQAOJfKcGEHgxPFeOfSzBaDfuewzQ6aqRR+RbJCynWcjy+/n/lYRJA2U2a48Av2KyXdi/VdqaBdEKg2Ao36f/adnEJXZ91A2ByDwW3iNuTFMkh0KYfVizNpnBQA6KJ9kVNHEuh1oheQ+4Gmbgw7rnurFNZVAuvom7B1E5FqQhu40iz2ZeIHcTR80yfUqzh8DR58eJsPooC+KpB8TS+VtMj3arMIq3HOKRI5x+MOWsEjE0qnKl/9AVm8upC3znWvZcc1mOaC88VA8CEWFowdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q51t3g8JHDy475L9KMyzHLlrXzyn638WimG9W/daC24=;
 b=LjlzzPVuIFCjuAzI2Xk3vL2VM98AniGpxCedcy6PwU5N3U5ccCY/mUHYvnQwXZx4cr26ZY6uM0cRS9kooHXPIPpMPjaBVXyuve0HzidzEyKoVji482waukdLu2OGHB7ummJA0rAEmFSVU5fjN1K25i6VRMqGZFHVk9j/xtRLVXI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
Date: Thu, 13 Oct 2022 12:47:39 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
To: Julien Grall <julien@xen.org>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
Subject: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0434.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::7) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|IA1PR12MB6329:EE_
X-MS-Office365-Filtering-Correlation-Id: 628ff111-5860-422c-a641-08daad10beea
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YeXROy1EX2LbzROMJSaQZz0jx2dcQg5D7sxGE60tgXK+8YsoPUijpuiDQna758p/1RhG9jqlx1wAJSlxapXQZGFGdDGxvacYc5MKIad1JKtCXw/kiE+rzcQ6jtNmzK/hbxoTO6DKUCGhChUt2KLfPjrdYEHiidHI9tk8DsDbXvHA5T9u2gc1WHbeR8b/S3WpRnLiINCzhev142Zi7lNFVCgFIrdSsWhTES1p+ruYfCI/2craeMDiZ0Zk1USnjWKyO7Eg//6yAfLii6JKxlLUzaS3Xzj9aMDshOeoeImG1kiqD8S5yRA2zGKHWfsiUUV73kIH+o4VSySbC+nV27f2USvKm7L+Agqc1covLt7SpVHFKT1T0JKzyhNzcxdmFHjc0kc9X3de66i7HBBapLX4hNRjfhnAIpuAvbM2778AFjT6cOkhVfWsGOMBdjFYeV10zSUgAP++62lLYBf5XReePkjKKv/J+jwLvfJ4VaWEW6Zyzr4EWfrGemehJn+eEL8Pv0tI4jFWtozQoDhXeOD78agrOsVx6kYVcot1txL5vr//n8czhnTrTCcJWiYBN87E3bANSBwVgfRj3+tR8o+sB3gCtvlqnJZadQxdsZ6lXvX26axTsHjgefkSS8546M48GVFXEUlLBsNFHqxH8GpDM8FkaKD556u+nod8Nz65MyHtRgShACcms8+Pll1WYkyrH+trt/Sdt5BslYpCvOrqAkITNGeYz4rGEvYh2hASnP9r+zQWmb08K3E5cHjwPLd0aAYIU7Xg9mltKaTbXgvbuF+zJccA954Ppc4fA/uf+4Bl2h9Cr0+QqoNVqT4iBYZjUfAO6HUYMxC8FImzl51y+w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(38100700002)(4326008)(31696002)(110136005)(54906003)(966005)(6486002)(4744005)(66556008)(478600001)(2906002)(66946007)(186003)(6506007)(316002)(5660300002)(41300700001)(36756003)(8936002)(6666004)(66476007)(2616005)(8676002)(6512007)(31686004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d1YrbjBONUVXYTlXL3lvc1pheXljT0M3UTNNbXJSUkgwK2JQOHA5NURNaU5H?=
 =?utf-8?B?SWtUeW53Y3lhSkkzRzAwWmY1Q3dycnk3cXNEamhqdUx5c3FkZzZzck5DNHV2?=
 =?utf-8?B?a2JYSTVSbHQwMjRoRVB0dHIzdFg0SmhYMzZub3V3WEZIZlVhbC9zUm45SWZz?=
 =?utf-8?B?ZG5YL051UVhLNFlRaHkyOGt4MEkzZUJ0L0QrSkVVYmlhZ3ZDM2Y1YkxyV2J3?=
 =?utf-8?B?dmlCOWVnSUtFQ0xhU2ZtcG5CVXcrQnI3U3JScmtSTmhMQVpwRmVpQm9BRVZC?=
 =?utf-8?B?N1k3MWptVW1RNU1GcnY4ZkcyNDJpdFVuR1p6NGp0c3MvRlBGbm9BRzFGUmlE?=
 =?utf-8?B?ZzFSTStoeEV4bjRZT3Y1VTdmbUxneG4xVExDaUtMMUM4SVBUWDlVdGlIa3RD?=
 =?utf-8?B?RVZGd3lIbEVYbG1hZTFKaVNNdUttUHRzREFZeDdWUlVMQ3E2VklQVzQwdDgr?=
 =?utf-8?B?RDNsTzdPZ094QUZLbS90SlBraFp4ZUgybEhuN0VnQ0hnWlFtc3dDQnZ1Nko0?=
 =?utf-8?B?bGU5dkdpcHNSWjdlM1N4SVFTcXRid0lPZHhYT09pYVpaVmNOMmlXdVVlaTB1?=
 =?utf-8?B?WW1VWm5vUkNDREtZcW1qckpOekVIZ0ZFUEQ4ZFZBQjZRc21CRWJaa29YNS9y?=
 =?utf-8?B?ZXNKU3UzcHIvSnp2MC9oT2QzYkszaXNJWHEvUEJ3LzBiYkFpakRUMkh5QUVF?=
 =?utf-8?B?VWpvRWc0bnFOT3gxYU1IVjAxQVhvQ0VqZGZBbllTOXBwWDhZR2VLOUgvd05O?=
 =?utf-8?B?dEJxWUdVT0x0emFubzZoSVNMUjVyL0NzQXdoNWlBbVZkUTRXYTFaM2x4SC9z?=
 =?utf-8?B?L3hjaWpHK0duR3RsMVBoSXhRU3BFOFJhMUVESUliNFRIN0FFd05vSjNkWlJY?=
 =?utf-8?B?SFZmaTVEcUdjMGxHdUk0bWFWVWhVaHZ6TzNYWHpzM3NjbVo3ekpnOWViUWk3?=
 =?utf-8?B?eW9GQU1aOFc2TE9wWUNIdm93dVJlMGJsOVozR3RuR0QyY3FrcU1jT0s3Z0xO?=
 =?utf-8?B?RkJqSHAwekdnWVU4T0VIYitlNGpOWURoTWVwcHV5T0hhZ2poMXhKOWVJYUp3?=
 =?utf-8?B?eFZhRG1CTk9mSXE0SDRjRlVyQjZRL29MTDgvakgzZ01KdVpPQ0QrdHc4bmdC?=
 =?utf-8?B?YXNJVUZrZitrT0FaTEJBV0FudmVickNpMWd0RUdNbHB5NW5ZeFViWitCUStZ?=
 =?utf-8?B?MVdOSmhNbm1qZzV0R2wvbzJkNUpZMW5yR0ZzVEJuM0NDcUdVNldMeDdHclM2?=
 =?utf-8?B?NEErK29EaEFEL0czZDVDaHJMQU9GZnZCVlpwSUNNVjBkbTZXMXJiS3JFc2NV?=
 =?utf-8?B?SnBaWDJTSk1kVWtpZm1yZVlVNCtySFlZeVN3SHhiajk1VmdUQ0tnSGwyT21B?=
 =?utf-8?B?dlNzSDh6dzZNWWxEUTZqdTNreExNSE54Mkc2ckxKV0w3SVNuRG5zVjI4L0hr?=
 =?utf-8?B?WEV1TTFmaTVZTWh5dDJUY0xHYnlMaGJGWnExUnNsbG5xN2VFVFJaMUtoajBu?=
 =?utf-8?B?SE5ud1Nsd040TFJHZWs0djIrMy95UmllemNVWXRMZkE5eHJsT1Q2M2V4TWJR?=
 =?utf-8?B?dlpCN2VHaTRUMjYvbGFXSVgzczBZSW15dW1LUzc1aUVjWjZjaG9RQjJGRWVa?=
 =?utf-8?B?S09Xa205OVU2L1FrTHRraDlWTU56NGFYNXpvT2YwUFFuZThlejBpOVR6SkUy?=
 =?utf-8?B?ZThQQmQ4NzhuRGtIVHNqSkVlT0pjRVU0TUNOVFB4U1NPM3gxWG9mTTRnaXdJ?=
 =?utf-8?B?ZURuUGZ2Wm1GT2pFSkp6aGRhSlhaUk9EeGhyRnA1NTlrUnJCWnl5N0VjU2M2?=
 =?utf-8?B?M1dLWklxWUpBZno5MDZHaUQvdlY4VWl5a25PRkRQQldLU2x1czh3QTFDTGly?=
 =?utf-8?B?bHFZWE02OENWdGFPbEhpcWk2dWg1UUlkSXJaaWJQWDNIb1Nyem5BelZlTzZm?=
 =?utf-8?B?WlRrOEFFRXRuZmpaRWtLUGlsMEh4cGNTcFdXZm1XOWhZQ3NVa1A3NHZrRkM1?=
 =?utf-8?B?anlvSHdDOXNhSXI1MmR1MnMzcldLaUJDVzFLamU1MG54eFhraUFCMnliMkdm?=
 =?utf-8?B?UHZnM0JuZEtpei94RlVzaENpRVpyWjZoWWo2WHJvRHVZTi9LSzhmbXo0SXBM?=
 =?utf-8?Q?yIiRV/GMmYWwtHcbuUGjl3O9P?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 628ff111-5860-422c-a641-08daad10beea
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:47:46.2508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ObfgA64/Qya0GrSVMAS5NuU0Rg5AwFLUOtZJuIyewTyJJ+DrOmbwAgZwL1YNXMdcyZO664BpGl67Aw/q/y/qUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6329

Hi Arm mantainers/Folks,

Please refer to the discussion 
https://github.com/zephyrproject-rtos/zephyr/pull/51163 .

We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed 
virtual platform.

Zephyr is trying to read GICR_TYPER which is a 64 bit register using 
ldrd instruction.

As GICR is emulated by Xen, so this instruction gets trapped with HSR = 
0x9200000c.

As ISV is 0, so Xen cannot emulate this instruction.

The proposed solution is to use two sys_read32() on GICR_TYPER to return 
the lower and upper 32 bits.

With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.

Now, for Xen to emulate this read, I have proposed the modifications (in 
my last comment).

1. Does the proposed modifications look sane ? Or could there be a 
better alternative ?

2. As there is no 32 bit variant for GICR_TYPER, so does it make sense 
to read this register at all ?

Kind regards,

Ayan



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:53:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:53:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421905.667611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwly-0002fk-3v; Thu, 13 Oct 2022 11:53:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421905.667611; Thu, 13 Oct 2022 11:53:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwly-0002fd-1E; Thu, 13 Oct 2022 11:53:10 +0000
Received: by outflank-mailman (input) for mailman id 421905;
 Thu, 13 Oct 2022 11:53:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiwlw-0002fX-Mt
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:53:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9885bc5b-4aed-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 13:53:06 +0200 (CEST)
Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 07:53:03 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM6PR03MB4987.namprd03.prod.outlook.com (2603:10b6:5:1eb::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 11:53:01 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 11:53:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9885bc5b-4aed-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665661986;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=PkPSzrknOdcb3HnIptMfAJflOpcRYvoZBB+HqlhcL88=;
  b=JXSgEzEXiBQwK9ksz9iAUzOfVFFuiPrjipfpPziVdt/MteKBzuBCPWgm
   DYDlkgzNpMGZ73Jv2XSZ2vCmjUxtRL6i+y92QUTXzsoJcNtse8jNUjWZ1
   7Apimtm5L/IiRsOOXAk7gr4s7ZQpopFHezdRWtn4hBN06ypDOPr4SYQ/C
   U=;
X-IronPort-RemoteIP: 104.47.70.104
X-IronPort-MID: 82654859
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AdNmpv68cLiHKQKiwOAO9DrVtTnXEBe8aBUUsX?=
 =?us-ascii?q?f30WtKx8/RTzJ3v3xIN5G3TbNRwPMuHkG28EylCq5hUTj+5RhKEl9FcpmOwO?=
 =?us-ascii?q?MQtib7y4yM6N6EhTH+PiKyi9oREdP/9qNo93K7lj8nRD9jEzVXhftgwTRdHw?=
 =?us-ascii?q?YF6LTtg88bRqUjkRKHsn+TpnKx3FGI7FY2j7oSDBbb+VhP+mjh/hpslM/nIy?=
 =?us-ascii?q?ZAS6V9yKIVrePuUZHDxqtyoYnq9jkid9nNA7ro41dNe1yepggu4vNSfEyxD7?=
 =?us-ascii?q?InLVNWJkkiyHVdwEnWxb0ymEbOssV89AdkZW5MtdBPHDn53it72ux6DLOYFy?=
 =?us-ascii?q?m1LPdqktSeJDzWtOLw3eKa4r5GiI5G7/I798ns/3KjyX5qYeAZwdkUhxgpOC?=
 =?us-ascii?q?tAMH/mSqMoPTmHNybMJaarYcn2awPuz8gMaoRE6TnyAHHo04SNM2dcHf5dVQ?=
 =?us-ascii?q?IyEFZH4duYrLqrRs0Iou14+Ur5FD1ZiZJ65q+/mYRTdHC2wkk1FeSdT+p0We?=
 =?us-ascii?q?UssDAFRLMvYiyp+fmLwFhP4PwJ1DTbpfc/IR4/IK6AZ81d0bObASgeWGbr5U?=
 =?us-ascii?q?kqj5nnEEoZ8W+QXxKnvwWGSI6u9cngLz0T2SAuUBzbCicciCcZbJwN6Caf5Z?=
 =?us-ascii?q?p2DFJB4ZMT7B9tzdyV9X7tAPDxh+Df+JWLKcPhEeYu6yetDEdNbJQUwAD0iI?=
 =?us-ascii?q?n/NnCyniADufLdhjAPkcmtZZ8LZgHTjzETTvI8TOvi3MxxQFkkAO4zpnnRIm?=
 =?us-ascii?q?MCOlpovouMkoGmIMg2YwqIfv9cew/jTAbb3W1AeddeI6DYRCVUgS6oX+uS/B?=
 =?us-ascii?q?HaiCmlcjgY2wR5RyVi7nZYXqsDmgttaSs3q2FzPMTCef7Gr+BUnQDr7YiEI6?=
 =?us-ascii?q?j5QIJB2dNzwA49sFK0nVvflnm40GFB+0DEuoK54z+Tkj6GzdBq04Os4cN2Hr?=
 =?us-ascii?q?aoIqn2izx0C4yfcF8oyrRImYMdjWm5gIgbZSvduD7vs6Mm/xLIJbUwu7zJZi?=
 =?us-ascii?q?pD9rt/oVZVgUHME7rvhaS5FEOrMekS98Htp7BmoQKeM9RSrwYR3XM0IMe2DH?=
 =?us-ascii?q?ZeeTPSFyBU6S4YNM/hUddldaBWVvcve7Qi2CuZtSfPuGS1d3rPcuXwgUYBI2?=
 =?us-ascii?q?5ARq9k+7SFEht3ML2vFCRtui4wb2R7SxgyNRK+DVyFKuDBbUv3fw0I8GSReI?=
 =?us-ascii?q?z+hjxt9V2P9N3iGPN74ife8P8fKgPCU2k5aoEGS44S24sEm5SALhtqI4Jv36?=
 =?us-ascii?q?/Q2YKv/eoKnhflQ2KR2Ic/BZHn6bEufOqTfoj7Rbpy/EiHw5kuPcIO5QRp6f?=
 =?us-ascii?q?hH4LIzzZmwAvTrkq6RA6Prbc6ntTgB9RjqMNWtIvwD0no0b/T+FWnGQPAWxq?=
 =?us-ascii?q?u/ZeDqf+otB0agL4fA1J8Kt5MJO6lBTiuMuqI6k6eRluRzo8KcUy79gPvfLl?=
 =?us-ascii?q?DH0dEW82JIq869ioavJtic5hE6f/dajuaxUjLvBcfUiIQPV3/NvHGY1dUpAQ?=
 =?us-ascii?q?1cLVeL2fvDfpdmCLnNbt6cNnweii/QFt5//8zoy16tBXRb95EQxvocqETE7G?=
 =?us-ascii?q?G3ni9+R+zL/O52K298akyN2UaQuq3JqU9pUDmOqsn2+VsAOpkTnsjYEf0iCV?=
 =?us-ascii?q?mydOyO05hKIF2T9eRrp9vWLmiVjGRAvypX/qby3sUkJLEy8gMJXcH+p1GSLY?=
 =?us-ascii?q?uOTA3imIQbR04fHRgv2KAFIRKdfOaGRGKvDzxM6HZR6B+KC1ADiSvOi8nryP?=
 =?us-ascii?q?9Ikfy0+hnHBBJRL9evTLwki4ZVmdDwRfPJneNFLsMfY5vm/npgQkhVbT8RaK?=
 =?us-ascii?q?4QYZEAsfpmsBiks4a1ltd35rMEa/uoqe4q0oFmU0Rd9hGo7EM+6foNOPIiAh?=
 =?us-ascii?q?HvL7wyxgaAmwDtXYgf4WKTEBhJpBJQzdmlGjYrPYcvzJ43tcHKU5p51IhULs?=
 =?us-ascii?q?XEblG4n5/g51s3e7bzzcD9FmF0FLzsq8WDBx9HharGOTXDvlgme9ajkhzOBL?=
 =?us-ascii?q?8zJVyqXm5SDeeV6ETSybI1CKz81kvC3+jjeIpMQui1o96aaxSwBHnGhoqg6+?=
 =?us-ascii?q?n7hY1Vh1LJc0vbZDCaMXziZkYcPDHDn/k4BBmkHRZpSpkDB6t8Xl8X08njhW?=
 =?us-ascii?q?bg0A1tU7UP17Xv8isSxVJhvaLCQwuo047edP8CGZKH00LS2zFWxiA6QS5GW8?=
 =?us-ascii?q?wMww53pxynSSUjO3kYCmTh/jBpk4Kie6oIHCgnQlcUAk+zTCETl5YZ/M7bO6?=
 =?us-ascii?q?cuXaWO/5nPwcaKzCd9wycjkNH9Ry3dxA3FjfYPtPXK4pMXRpNX5vFs/XA6Jt?=
 =?us-ascii?q?f5kGrvS5GRCTHNRaIbZBYEMY8kJJuK6QEqbbSmRc2GWBvFGSRekwhqVt5Dg6?=
 =?us-ascii?q?yQSmkIFcTyTgcN+ZMO0ODeoajBz91tYblD3FH84GqUQxrVzGRgFURF00zrxl?=
 =?us-ascii?q?WTtRB3HqKUDkEVn7003Ov8V41g=3D?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82654859"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AIR97GQAGhoUm2e1ZmmqUEAW+0EuXMxCNUmylZzA6in89p0qo1AXCetoFsRx8Tnbl63fKNRkf2RvQ8jlwcWEPyHEzuyp8adB7W984dkNJ6jesf08t5M92lkIeg+xKqOMUmZLG7ozoy2KK6tRdCLuwBYhpFA6UJeW9fhO9KoK15JVklznpXZF7e2FJ1mBqq5htnem5YiR1K3wWTdahbrv40nHu4vyFmDL8lA1qi2d2TIGo9oubCQXvQhE/u2Ce8GrStRLOEHaA9A0IHWFIil3G5xbb5eWPxRO2I4kkGGfY1n6+AcWukurqIV1T3rDDn06lbSQkGaVx5igXVBUzzWuaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=76gElHA2d5iThTDRevOp//4smkK+KLnfA4lsH0LQ4Tg=;
 b=Mb9lxaaSsPafSz9wf2KKd8kI1THThiBbAvPE0JipleUwd7enmqMjsiL3nVUUDjhv0douLu43Sqp1IMR1SxlKhw1HU3Fqms9o4yxw8IguBPmiJxDqPTtGs0YVCWpgRFP1Wyzei84pTLO6gOymC1p9FMVf3qbA9SRs1HViOf3JblrKdQxXXcv+4FTuY3T8BSF9qyMXNosM7spj8342btOkfuDdexCEgReaWhYaJKr0krvgil54pye5rGRJALeC6kL/sMwkA7HTYRFHSJcZ2ZWqDBG/QJI8oql/9GIq+g1/NiB4zaO5sDBz/Z5Y6sCzr7nd5rxMj53gxDGqESAUrqRpIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=76gElHA2d5iThTDRevOp//4smkK+KLnfA4lsH0LQ4Tg=;
 b=O+fOJLE5g7W022UXOYtiFLU8GGZTWprwQt9CICTLjQgI4gRxe/ste+gDE6yrnyovz+o3UkeT30Q+NxG9+W73u+yCD6zIL7RzjvlexIc/hmeA/95h/3dc8GEjSZOzP+SLILYJgFilwbwfn42bdy07i+IY1i8yaBNjjJaR3NX6pt0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 13:52:55 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 1/5] x86/mwait-idle: add 'preferred-cstates' command
 line option
Message-ID: <Y0f8F9yqdct7zy+S@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <0690742b-21c8-e5b6-e8ff-5d4709e0c3ee@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0690742b-21c8-e5b6-e8ff-5d4709e0c3ee@suse.com>
X-ClientProxiedBy: MR1P264CA0170.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:55::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB4987:EE_
X-MS-Office365-Filtering-Correlation-Id: 140def5c-d4f6-4d38-410c-08daad117a95
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2BUmVuxa8bsp6XNh0TvKagEE/aphj1MuQVe1kWTRR7877+g6QfDpjf5y5/JdMsTdPkl/b8oFgfy3Pm/B4FRzvhVq8d4ei+Xcpsma3cBBTwnvpQgf/B5z8ApgFhKKOIxmcaSZgXcRJQ2l9cgbvioxImSzZMJNJm2cE+MnO63XAqQyMy/P3yl4N8P1dBLYHhym5kjBHVuz72zk9NVcPUQ2etIPBrJCGBDork2LaWCc8B0ObuJIJZzF8ntyi6nFSuH7uFMA6Nt+cr7ip3wFAUJ/f/NPxWjOlrMUWLS8OVN8sO7bqYgVHYb1A48rLnJIGBtD4+OXqnXkFypwehJ5z88WthOqDhmm8oZqXwlPLiMK+Fj69YikihJx/jmb11/MAlJvZP1OQ91G0XOWh7ly3MYwps9zpWd+hpJbTRKb4Y/fGU3Ftujk63aAsS2mnI8W19/kYMKpMDDIl4jn8fvtR7PtjK2pK72967YUZbdsH3hpL5TPs6QU+EAr2mY/lXAb31Cl4clOb4+SsASMc51GMPYC+YNvmSk/7i3CI26k6AyRDXiskvW5FT1uwn1KKZQ2XDvbIwDbDAro2xFfbOeSLLN7GIAs4SFGpuRK5B7RiKpo+qxz1a4oqElF82sBZvEI8kyN0DV0iaUAuIg4dhwy4kegfuZBK67PSfhJDTfDktD/H8Rsc4oSWqOumB8rhLT2WTD1t2eaf3f40TW+2y9CSQO0MLn1cE3wd+vr+W27mGSh7epehI/ley/HqPzU/DiJ3pNhPBltNwHMOOMzdeA2k5Ng0g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(39860400002)(376002)(396003)(346002)(366004)(451199015)(6916009)(86362001)(85182001)(66556008)(5660300002)(2906002)(41300700001)(66476007)(8936002)(9686003)(6512007)(4326008)(8676002)(26005)(66946007)(54906003)(38100700002)(316002)(83380400001)(82960400001)(33716001)(478600001)(186003)(6506007)(6666004)(6486002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dUFPZ2c3bWgxNmJHbmg0RXJBUlNCcG5jY0Q2WXBZSnFIMWVZTHBMZ1dWVGQy?=
 =?utf-8?B?N1BTRE5yVjlndnlqQloyenBxc28yS0xpbWtRK3hyNXowNFpMQ2RZRkx5bHlk?=
 =?utf-8?B?ZXRqMnBTZE9tNWh3K1hUNGhEVzZ2ZmE2UUFWRXdNejJpV1ZoOGlOSGhhMzRT?=
 =?utf-8?B?NW1GSmZYOWZSdUNyY0oxQzBVM3hYbFZRSWlMU2dsMmI5S2hNZ29MT3haWHV2?=
 =?utf-8?B?QlFzWlVMTjFPb2lUVGg4QUZUM2V2WUV5VFNLOE1ndGpMZnFVNEZqUFQvUVNZ?=
 =?utf-8?B?RlV6a0RhMUNGdFNDRG1HbSt1YVkydURGeS8xajJQT2FRcUowWDQ5eUJ0MVFS?=
 =?utf-8?B?cjJNdjRva3JGZkdPV3UrU1FkdzJkRUx1UExZeGdXSUluOWdrNWxvVUxCelNJ?=
 =?utf-8?B?UlNmVGxmY3pocjJTeFZQQnVQTkJrQUt5YUhta2plZmZQTkh1NVRIcUNxREpE?=
 =?utf-8?B?VWhPRXJSb2xDdlRmMXlOQ1BrRXE4NWxzQlQyeCtqT1pneFcxZTk4d1BaOHQ5?=
 =?utf-8?B?Z3Q1RHhrVkQzREs3WGg4K0tYK0dsUnNaOUV3cTY1K3Z6Nlk5SHZCYVc1R3M1?=
 =?utf-8?B?MXljd3RpWS9ZVkRpZGNiMm1vckRFeHFXUkR1S3EzZm5lT3dNNyt3K2psQjV6?=
 =?utf-8?B?d1FRSlVRNTQyYzdJVWVjSi9iNFJ3d25UQzEva29ENXMxbmF6clBBeVZTR2Jh?=
 =?utf-8?B?WWtzT1VNL096V3BuMmV5RmNRRWViQ0JsWGRpNG5pYVBCTkdveFlFZGZ6SWJv?=
 =?utf-8?B?YTQyV2wyaExHaERLY1ZBOW9LQ2toNHgxbWF1eTg3WW5IR0QyTVVlT0ltVkxq?=
 =?utf-8?B?Y25hMmN0NTQzRmtyWnUyRTZuL3JSbjZJeUxnSU9aUHViK2hmWjNUWXFRNGYw?=
 =?utf-8?B?SUJlQkJVM2Q1dG5CZ2hFV2lGNUEzUUhRZEVDMU9TdnphYUZIeDV2MEs3VFZr?=
 =?utf-8?B?RTdGM1hBNnZDcUJMYTlmVW8rdE9PeVZicUUyZ0RNUGV4cmhtRTFQQ0lSQldB?=
 =?utf-8?B?bzgxY2NnK3QzckZoa0xVQ2FyYnh5OWprSXNobXAwVFhHays3RTZMbGVRWHFm?=
 =?utf-8?B?WWVrSkNpc09JK21lQy9saGFRcmFPQXcwckcvMkc5OVhLM0ZoR1JKbXNnR1J2?=
 =?utf-8?B?TDh3Vkt6UTFoeGJIL2NyOGR1Lzg0MjFTMFJJR0h5Uk5keWdITXBpSFdpb2JP?=
 =?utf-8?B?VDlFNTYrZFFTZlRwdEVtMzBRN1ZNcUFIdkNISjAvaWRLVVUwajFQODFLendB?=
 =?utf-8?B?YTdMVncxaFB2enZWSEtiUWlHTG5mODdHeTE4RlE0WURjZmU0VFNLVHNDTVNs?=
 =?utf-8?B?amllZG5FdzBpMFhHN3BpQVkyQ1dqWmtEZ1EwVmV5TkxQZFFpWVcyVkUxdm1K?=
 =?utf-8?B?OU5sNTZ3QXpFMDFtamhOUVJYbWZEVWFtQjJYNFlndWFwNkh6eDd5QmpBalFL?=
 =?utf-8?B?VElSaXVBZkd6WnAycVlCNUpFWHlPU3V0N2YyZlA3RjB2dDg3M21pMEJNLzF2?=
 =?utf-8?B?ZTF2Z3pCNVhiK3Erdy91aE5NVjVNcHZKVDZiRWNFejdNUWQ1RXQrWXpUNW5L?=
 =?utf-8?B?RDRobkFXRVFzMkkrL1ZJNC91QUtiZUttdGQ0QXhIMjhKdS9DdFVHS3p2bTAw?=
 =?utf-8?B?cU5qZ2Vackd6dU9Lc1VQNXFFWDhqNWZDRUNRTTlaS1pHTmJJUzA3RDQ5YXMx?=
 =?utf-8?B?TzhWN3lJT0krNWxrWGwvQmFlRm9qYkxLZ2M3RlFWMGJVdldtVFJVaUhJOGhp?=
 =?utf-8?B?QkxLenY1Q2NBUFlrVHArRnpiL2xhRTNVeDdCV3d2NDB2eGlZUnZScnhwY0s3?=
 =?utf-8?B?NWpibXowWHE3SGc0TUtBZWdoK0EzQ3VJeVBZRzBPUitqbnVheG9XdjBjK0tn?=
 =?utf-8?B?SnFQNWt3NVYySFJBV2RPanRUdUFNcGpKV1Y0a2FaSFZsdkkzK0dtZHMyVWlZ?=
 =?utf-8?B?VVQyOUFLQTNXWUM1N2xuSndwNThiZTlLMElJWUUramN4VmdSbTlEbUFhZnZY?=
 =?utf-8?B?RWFhaE1wRDArK2tOOGFOMFRvUUlqZUZJdEhKamdHMHJUY05MNFV6Y0lVREJj?=
 =?utf-8?B?cnFwTktVOXBvMUl1N3NPQndwdkUvak9jazN2WnJrZ1RKTmx3VTNLRGdCZThY?=
 =?utf-8?Q?Wn2BuGnoykipGvQmGufSNgCNH?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 140def5c-d4f6-4d38-410c-08daad117a95
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:53:01.3058
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LEpVkvPWf7zrTA5GiESDUAx7pTjSLJLoSsynm2oU8V91Ea7g5Wsu/EttCEf1R3O69NpoXo27OfkezhJOMsB/Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4987

On Thu, Aug 18, 2022 at 03:03:33PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually
> exclusive - only one of them can be enabled. By default, 'intel_idle' driver
> enables C1 and disables C1E. However, some users prefer to use C1E instead of
> C1, because it saves more energy.
> 
> This patch adds a new module parameter ('preferred_cstates') for enabling C1E
> and disabling C1. Here is the idea behind it.
> 
> 1. This option has effect only for "mutually exclusive" C-states like C1 and
>    C1E on SPR.
> 2. It does not have any effect on independent C-states, which do not require
>    other C-states to be disabled (most states on most platforms as of today).
> 3. For mutually exclusive C-states, the 'intel_idle' driver always has a
>    reasonable default, such as enabling C1 on SPR by default. On other
>    platforms, the default may be different.
> 4. Users can override the default using the 'preferred_cstates' parameter.
> 5. The parameter accepts the preferred C-states bit-mask, similarly to the
>    existing 'states_off' parameter.
> 6. This parameter is not limited to C1/C1E, and leaves room for supporting
>    other mutually exclusive C-states, if they come in the future.
> 
> Today 'intel_idle' can only be compiled-in, which means that on SPR, in order
> to disable C1 and enable C1E, users should boot with the following kernel
> argument: intel_idle.preferred_cstates=4
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da0e58c038e6
> 
> Enable C1E (if requested) not only on the BSP's socket / package. Alter
> command line option to fit our model, and extend it to also accept
> string form arguments.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

With the indentation fixes.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 11:55:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 11:55:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421911.667623 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwoE-0003Fe-H4; Thu, 13 Oct 2022 11:55:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421911.667623; Thu, 13 Oct 2022 11:55:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwoE-0003FW-E8; Thu, 13 Oct 2022 11:55:30 +0000
Received: by outflank-mailman (input) for mailman id 421911;
 Thu, 13 Oct 2022 11:55:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiwoD-0003F7-4M
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 11:55:29 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ecadfd4d-4aed-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 13:55:27 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 07:55:19 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB5056.namprd03.prod.outlook.com (2603:10b6:208:1b2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 11:55:17 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 11:55:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ecadfd4d-4aed-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665662127;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=8u+d48JW0gObJNKEvqc6+r8rrVdSLe8x6z5eIv34PUI=;
  b=H0+SYpYVmIBcRQ9ZZAdFVHmKunpwI2XZ4fTiFudwvHJk44wTt4bpknBA
   36qLuZPoSd0LnBtRaNefqQK68noKf+88/2zFT68DAEClDZmcFFJE3Kh9W
   fTpTGoh/ZxZr8xkZmeYAEyl2vCFO62y5dlPe6J69xW7KmOKUDpTkHAHRl
   I=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 81754575
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:xcKsv68JOQsL0EWdtcPdDrUDmH+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 GAZWDqOPf+DNmLzKo9yaY23pxsB65/SyIVhGVM4q388E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5wdmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0qVtD050y
 dMyFGkyM0iMtu3q5aCBRMA506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzS7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVqy3x2rKQwEsXXqoYKeOE9eNTqmSTz20LNCZNcQKU+fam3xvWt9V3b
 hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz
 FDht8ztLSxitvuSU331y1uPhTa7OCxQKHBYYyYBFFEB+4O7/N11iQ/TRNF+FqLzlsfyBTz73
 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A==
IronPort-HdrOrdr: A9a23:5Pyb0KlFP/U/8esmn9Lux377NuXpDfJP3DAbv31ZSRFFG/Fw9v
 rPoB1/73TJYVkqNU3I9errBEDiexLhHOBOjrX5VI3KNDUO01HFEGgN1+Xf/wE=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81754575"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KOWXsBWzbp5Iyn17n/34qVpldq+6r9kPHJXERKQHumrMJ4jEKfBEGnmg9A4gpXjJjZpu/yaa7K/QPwM8x2MEMdVR912Bzx3Tjah+2jLK4sKe7hd4zMY2lraiyNh0aufLzqHmwUM2JR9vR0fxHkTlyK6RmZZARFobDe4Iq+rD12W4+TxchiH1roWY04wcbf3S356b5B8FAEY7ye1Un5l6gb30AXS7rOrRAOoGDPNhjNIzrSFqwzZ5adrNeO0xNI5vKpbi9YR/ofgtttEj82X3Z+3BGhEuionuvL9WoErSqHrQgkx2b+QPQ8YnWnPKTW5kM+O1z10PtD+plDECtNfSRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i+9bIMeg5CieGeW6gIMgufaEzLGlL6trWJlt4/3nnsI=;
 b=IoAaQTzSkC4UpA5KNndRp3oEPq125tW1soHKA7ZWfo0x/DJJLdKNXwLIH8zKguejBR6OmraiktcBybQYeMtwMXDg3pabUfXtX7zIje82YViUGNXZ9wdBqjtF0fYpaH/9+wwm1TH5a05N+wW8Che9T2ZhmqujhZzTabNwZYLs5Z0QHv9GdJTiMnKlZSqSyzBws3L31gRpAoce6khybiIgoocRdXD+u92fZBx0nmicxygEAKjEajrYztZ7XI3HWbZ2fVUe5MA7wXz06dp2sFHHYgWlgddVD6Y7Bb3baJQssUKrHhbJvbItAOINbK+7EXFF9xc9nLov+kx2CSMahfv0Lw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i+9bIMeg5CieGeW6gIMgufaEzLGlL6trWJlt4/3nnsI=;
 b=oE63eADB7ANy+qui8j8mWaVI75GMi/xpWkvbea8JEc3trtePBv/BvJTpJKRNS/nsgovoCZDrVlpQF2b98U7x/OGeb8lNShKQrsVkBeiPIb0UnMd7qOtskBjTp1pmJ9G2FDHwBp/+2hc/mqyOQKT4yBaABnWFQridDKzQ0jtRT2w=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 13:55:11 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 3/5] x86/mwait-idle: add AlderLake support
Message-ID: <Y0f8n/HXErhx0tN0@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <f1ca24c7-0031-7ed7-d4a6-a5686cc7fcf1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f1ca24c7-0031-7ed7-d4a6-a5686cc7fcf1@suse.com>
X-ClientProxiedBy: PR1P264CA0152.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:346::10) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5056:EE_
X-MS-Office365-Filtering-Correlation-Id: 49fc26ca-2a26-4c8c-c65d-08daad11cb83
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KFtXqmg+BWg3cdae8Oi1GoavBRC12J6sfoqcLo2ZRf+c1wg8wsiVZhMqT1i7T895Ao3J5l7iAn89J6fAPz2baChfYqsNPfkTRW5lnB3OtVSsOYXTmitZhJ50D/ZmlVRF/ZidyKgEbv+t0EOGr00UwV2Mq2yyL3p4V2ub8DbMk3XOPGJSKFMG9qgGhXTkvHYyWyUfVpMp5aLE2QI1WeiW6U+cYcsnzgf2ZXjMpn+yxFBYKIZZbAcmvE3f6xq/krzHVO3uoHzz9WCP4pNixiP5dC4hgxHarIpIawkAlFocQ08Xan3by/6SqbhUoGsYXyCAXN2I+iLhcH2SPQ1RL4Y7XwIwUPm28g9BR5bwb5pR76jMl/a9KppBdwPXGb7QMyqFkvVxH8V+X2bAAbus4yxqmXiT2VjoFztG1QRLSeE/hUMkGheEb6+8EZc766kYi4bKdqhrdYBPpJgwSflmchbmi6u4vNM95BXjLo1GdTRcc1oaPKa8LIwU597YuENmjY5hUbCOthodFaOcQGKz+PyvW4v9oA9n4UCVrWv6/hB/DXG6kX/C/xMoTvTcRO+8bVVKNlJRZiranMF4AiQRO1mO+wnH0TQybTuBV4hruGWOq8FSVpsa/eFnl5IOP1vr5CsT+maG8s3n9aCUrM6AY0z221LXfCayzxDihn+r1FkUjEalt7BC90BjAihW83yV5aPqalVVTf3xPy+XiS0ygSaXjg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(39860400002)(376002)(396003)(136003)(346002)(451199015)(38100700002)(82960400001)(478600001)(33716001)(6486002)(86362001)(6666004)(2906002)(26005)(54906003)(6916009)(6506007)(85182001)(8936002)(6512007)(186003)(66556008)(66476007)(8676002)(4326008)(41300700001)(316002)(66946007)(5660300002)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bXhseW5odmUrcURtbUlYVEJrMlo3aVMzeko1d2k0cFVHNUJqNWxGcUdkbGw3?=
 =?utf-8?B?S1FxdCt4UTM4UlhYOC9oaHp1bStWbCtwQW1qVU4rU3J5L1BCVTBlT0RRdjJ5?=
 =?utf-8?B?NlF4N1Qvb3BCVENDaTNuKzAyOXdiY1hkYlVONDBsTDZsOGxRT0pacmhuTzlO?=
 =?utf-8?B?OHh6M0h1WUtiUnFxMEF2UCsrbDJjL0pEZHBVT0J1OTVQVDVrUlRYY0JNNUhR?=
 =?utf-8?B?dmVacURtbzF5eEM3dlBzUWE0N2w0VzZzVlpyRFpkZHVUNkNKekc0bkdJV3Bi?=
 =?utf-8?B?aThiaDlQWnE1UVkzYkEwMlBhOE8vSy9DOWdpNE5wNndzWDJGN2Rwa1A2a0Fu?=
 =?utf-8?B?K2Y0QzV1S295aGk4TjVxNXhDNzNvSUtPd3k3eGxXSllQYjBWc0QxWU04bytW?=
 =?utf-8?B?ZWd4N0dEYkJyb1QxVmF2eS9SSVJvSmZEV2FHbjhOVG5DSmFGa0F5eDlOK3Zx?=
 =?utf-8?B?RHJkZ2JxSS9JMkNUdlBDMnoxVjNpazVEc25vTE5zZkRhNDA4VXJUWC9rcWxs?=
 =?utf-8?B?bTdiKzh2cWY4THF3dHg5c1BKSTFLMW9ZUGFVUWxvYm8zcFF2Ty94UU5KZlZs?=
 =?utf-8?B?NHdmbUdvMWprVFBCSTZ4NWRtTmFlWmZ6V1BxUmcwWjhiL1hTdUhVeVFEc3BC?=
 =?utf-8?B?Vkttd1VsWlhyRWJaQ2pvOWxxakwvZ3E4TWlyN3BFaTcrbEJtWnZvdGdPZ1Z6?=
 =?utf-8?B?MU9PNmlsZGVnYkRmVFZJU2NYQ2kvMXkvOEJsQitzZVlyODVzSmhUL0l5SWU2?=
 =?utf-8?B?WUNzVVNHYUdxWjFrVFFrc0hZaWxscGlxa0MxMDlBMHhvR1ZIaFc3dFliSUZT?=
 =?utf-8?B?Und1MDUveGxxYll1RHowU1NLS0ErNW0zQ0gvTW9RT1Q5dTQ0Z1hMWlQxdS9x?=
 =?utf-8?B?b1U5M2h5SGVCRk9Yb2NjUEJxQm45VGRjNndYSGdRRFlTWDZ1aDhtVndRc1Av?=
 =?utf-8?B?M3J4Z0ZBWW5vMFRXM1kycFRoVng3VS9wMXAzTnR0ckQyRjNScjZyT2V5VGtI?=
 =?utf-8?B?MVQ0RFVVTThha0lLM3ZxK3hnY0hmZlpydHU2SHNEeHBIdjB5VlNUSGpMcElj?=
 =?utf-8?B?N1crL1dSMFhNemJVNjY3dXNxRmIxNWNMSVNWUXVmRnV3QXJ2Nk5sNE9VeFNH?=
 =?utf-8?B?Y2JpOVVLYUtYNnN0YXZnck1GejU2RlNPZldTTS9UUFIvZVRjRE44QmV4M1U5?=
 =?utf-8?B?dVpaNVFnZXZYV3hyeks3MTR4TENjNXlrMHBPYitSYnd6dFdwWjQ2eHQ4RlEy?=
 =?utf-8?B?UDNlL0N6SlFmbUFsa1E1NDAwQStaYnlkbTV4cGJuY0t3UkxEbzVlZG5tak5Q?=
 =?utf-8?B?cG5CZTB6M0UyMWJYelhrbkh6OTBPVDlZaTZnbEdXUUJxdS9nM0taVjI0ZndM?=
 =?utf-8?B?VU9QWE5yUVdoZEJyTUpOYXZJajZqLzMwRFg5OURuRnJncWdXRnhpQXUrODBK?=
 =?utf-8?B?MG9ub1pPaTB3bkhVTjBuSE1KdzAvLzRvbG1JREZieFROZHUvRGdiZFhtZUdR?=
 =?utf-8?B?Rlh3SFdkdFM3eEE3eUI1bTJkZnhZSjlpam9kT2NaOHR6Y2VzSjVXK1dMYTlz?=
 =?utf-8?B?Rmc0QmRNcTNPYUdibDFYVFhtNnpFRi9aSmNUYjRpU25nYzYxczFFUC9CL3p4?=
 =?utf-8?B?ZDZFNFBmTW4raTNpNno2OXhvVFc5akV2MzdmK21OL1N4YVJLV1lvY0t0KzZt?=
 =?utf-8?B?UWxvdFJCdkYzZVRUNW0wbTdXVkYxOTc4RERiS0ZKbnR1RWlCaHhRNnIzLzFV?=
 =?utf-8?B?T2VTVGwxQXpoYnNxRGdNSXBlL3dlVTBCWTNSdjRWYXpUYUNXMTR4djkrenlW?=
 =?utf-8?B?aXFhays3TWdXT3lURlAvc2FkVTNJODZ2VWtvQTZVaDF5TmNmdmRWUmplT1BG?=
 =?utf-8?B?cVgwQTFlNjYrRjNXTTNZVWt3T3VLalBMeFlGcnlvcFRYbFZBbHFuYkZib3pG?=
 =?utf-8?B?Z2VFYlNaVExTL0ZJTk1YR0dkaXJnckFpdXZvakhZVlhVQmlnZnZXWXFUUzJy?=
 =?utf-8?B?Q1ZjV1daUXU5MXFBZVVheHlwRlJTMzZ4Zk11S3VhcWN3TnVPS1lzSEV5RzZs?=
 =?utf-8?B?eFVydGdTcmw5VFZxUktRcnluam1DMG1LK2hKeE9zU3NEN005QU8rckFzcnlk?=
 =?utf-8?Q?nyT+PtYEmIiKreTP+hi+msTwR?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49fc26ca-2a26-4c8c-c65d-08daad11cb83
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 11:55:16.9462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0cLGPwNCAtdilxbF1NEhZiVDRXFWhuL6OFpPsYyk9/Go9GjSDA4ruAoBkUtdHvH+1eMJP+/V4PQAbQw+gc1GgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5056

On Thu, Aug 18, 2022 at 03:04:28PM +0200, Jan Beulich wrote:
> From: Zhang Rui <rui.zhang@intel.com>
> 
> Similar to SPR, the C1 and C1E states on ADL are mutually exclusive.
> Only one of them can be enabled at a time.
> 
> But contrast to SPR, which usually has a strong latency requirement
> as a Xeon processor, C1E is preferred on ADL for better energy
> efficiency.
> 
> Add custom C-state tables for ADL with both C1 and C1E, and
> 
>  1. Enable the "C1E promotion" bit in MSR_IA32_POWER_CTL and mark C1
>     with the CPUIDLE_FLAG_UNUSABLE flag, so C1 is not available by
>     default.
> 
>  2. Add support for the "preferred_cstates" module parameter, so that
>     users can choose to use C1 instead of C1E by booting with
>     "intel_idle.preferred_cstates=2".
> 
> Separate custom C-state tables are introduced for the ADL mobile and
> desktop processors, because of the exit latency differences between
> these two variants, especially with respect to PC10.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> [ rjw: Changelog edits, code rearrangement ]
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d1cf8bbfed1e
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:03:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:03:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421926.667636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwvy-0004wA-J6; Thu, 13 Oct 2022 12:03:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421926.667636; Thu, 13 Oct 2022 12:03:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwvy-0004w3-GS; Thu, 13 Oct 2022 12:03:30 +0000
Received: by outflank-mailman (input) for mailman id 421926;
 Thu, 13 Oct 2022 12:03:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiwvx-0004vx-8h
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:03:29 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 089cb19f-4aef-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 14:03:25 +0200 (CEST)
Received: from mail-dm3nam02lp2049.outbound.protection.outlook.com (HELO
 NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 08:03:21 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BL1PR03MB6086.namprd03.prod.outlook.com (2603:10b6:208:31c::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Thu, 13 Oct
 2022 12:03:18 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 12:03:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 089cb19f-4aef-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665662605;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=IZu7kORVbAw5KrgckG6GFBCC3blYhRh80B1pT8pN3TQ=;
  b=DAFkepTz21D3YpASz94cLamLLMhHtlEyyA/KM6W8ibJ5CTkAjW4BnX9m
   cEalxbjIDNfTkhz3YcXxpQGqF/ExkWn0Xr/8yw1W2w8YMCV1NlLATvolY
   BwYI3MlwLwim442rNRwSmnjHzotKRwcquBYOXHqh3ei6FeLMLz8BiAJGo
   U=;
X-IronPort-RemoteIP: 104.47.56.49
X-IronPort-MID: 82630622
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:7Utp4a4QEWH9OYbiYwBaQQxRtCDGchMFZxGqfqrLsTDasY5as4F+v
 mRLXTyAaKvYMWH8c9F0Poni8ktXsZbQnddiG1c9/3o3Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gVlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5VPH8X+
 uMiGgtTRU+S2N7x2pCgcOlV05FLwMnDZOvzu1lG5BSBV7MKZMuGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTSCpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toijy3beRx3mTtIQ6SrTj/71Igl6p61czEjkdZ0Dim+mlsxvrMz5YA
 wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9/v2ARR/vbvTTmiSnop4thu3MCkRaGMHPikNSFNf58G5+N1iyBXSUtxkDai5yMXvHi39y
 CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsgDGJ5T+REMWTm0Ms=
IronPort-HdrOrdr: A9a23:kPSUkqu4Gt3VCaAgvT0kTE2E7skC7YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79
 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M
 323Ls7m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w
 3+CNUZqFh/dL5pUUtDPpZxfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou
 WLbG9l
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82630622"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RBnWdcMYrKnOCKuepe6BlRH+DIBKGqQ2SL7A+8E2h8utoa8ca++qGIJ1qy6a7xmqMbJEm3BQQwcn8Onjf2EHbkfi9lpje+3vT6BhX+tiRGvOIEJyvMQ+ojfPuQ0XaWIUVGdb/XkQOwBJ4wBj/kUVav6QxAfB81sYzmNspwhQrilCn58uv+Bfna0hZsQLN47Gaan72KKncP4V1r7hKGjc5RsNrvQg6yiwMHfbqJoN7lOjKDpz5t3IVlecM79FcZVDgMLYt6no/2DH+qrGc3q4HGerjWIpoNWyPG7ZLC/+OkXAf+eLxftvTm4HkzQA9xfR2YTddFXoY47yjhtZNfuFRw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=slvnrnLNONI7rxqmZwiFBSS2wgx8kaPTR+IWnPIqHYY=;
 b=KbYuVofjyjqbvtMzSHqewakpUSeCO8Gpgl8E1/y6x6sDT0MlZevqLJ2XYrjUVHT/Wc37IDu0YEOXz9afApiuxOCpciahdsu/1CUBbMBskSfsP6hkuhRiZ+CHiKrrAo9emKzE2z0crBaJ4lVBW9rfAwDUUV4C7QJqRMu2HUQ+bR6gqyR9XYxeTuk1WOJ4x8HdNmKSauZLIV2U9tqdE/ii8LS0VNOa/PKlIlUuqptd+7ydIsta/7rgCQWsZcnRBCYWqgVRC1HpTYXVm3Z0XRv3Ja0tcnWAPAVkeVuC2XxMTOCmsSH0QorMucSiKqJQdHgEcMTmdw7I8uwx3jbkSJBnGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=slvnrnLNONI7rxqmZwiFBSS2wgx8kaPTR+IWnPIqHYY=;
 b=gtJeOJCPQz5CzqwuuhaszQrtlO7J7nNI1XEgJs+EiLYfkihbgyLJV5wg/ux6QWA9UiQM2Dvm/nAU1LYc92PCPQALTmqTFc+LcrDWeoydLm+bYo7++zaaVd7cwa/GRMVE82quDhKnKYPkvtFyCLtEpcBk7XEXNPFpXZNBNPViwcU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 14:03:12 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle
Message-ID: <Y0f+gL1PfB5lzlDj@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
X-ClientProxiedBy: MR1P264CA0129.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::17) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6086:EE_
X-MS-Office365-Filtering-Correlation-Id: 88cac7fc-8231-409f-1ac9-08daad12ea3d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9xs0Ih/unT4m4ICqxydKt1bMiatrAtmIG5wiPI1NRWrpG+ulm3IbPZ+XPYvt56NSs0wakdfXGHeS1y1/NrhgAgycA0hu4J9jp5r9T1OvXoERJKqOWeRLtWLDFM7G99koo+7G8kCbwoA9Zsg0j4lqc2Fr1vn0JOzTbFldabDNe/WEAzkaa855UnSI1kImo3ZgB1GMUG2wzgfkxKYU5h0f8XG148FAHHuRnmNcUvhjY0utsKoba5Ti05bGhDNEIJ9qnM7uGeNo43OaG4zKlXDPzlN1dS6UvMCQohJDK0avXBGYFJRe8IaWSlThDdKAfIO1l7znEupaNYeR4pysq/UuTdc3R1E6x4EnXotJxt/4KGYTAa6NuMoqd82B58Mv6Ggu8LF9AOcvad6BwLRCHq9h3aW7Mx18MslKLs5R34gcDVDIWSmzK2JVcV9Nr/Hj/ZmkBOEZYpzecItF/neaXNpxG4CYFAhS0CBXx20vtNZbxpOBDhP7ziIr6LAAXlDcuxbQoieQhcGxSwu1noXCd5A+SnG5JEE38BfHm7+3mM2UNpfNaIIIU7D8rgECayeIyR7PM+TwE0A3xGqyW7RE2Y9TOITaK/u0jsI1YGDc4j8t6dIa8OLYO2GKcVWr9tG/PmTx1eSGBSE4gsmp2YWbEJGe65DkiAKyzKaJ9lC0EoFfwR8zVB0q8xm5RQPJtcP17VBVXpi9sC2TYJWOnTsPL03gXw1ecdI+vcM8aPl49MVMZdkgc+juVQTP2o9HdvFSAKQUC8y2pBRLUgWHCK9R4092dg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(366004)(376002)(396003)(39860400002)(136003)(451199015)(2906002)(316002)(85182001)(54906003)(6916009)(66556008)(66946007)(41300700001)(8936002)(8676002)(6486002)(4326008)(478600001)(82960400001)(83380400001)(6666004)(66476007)(5660300002)(186003)(6506007)(33716001)(86362001)(9686003)(6512007)(38100700002)(26005)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?amxPNVdrK2JJanNvOTd5UStiMEhkMXdkMkwxazNUVTk2MVpQdGRWYnJiOURZ?=
 =?utf-8?B?MDRIeUdXMTg2MzIydVJmeDBUbCthWEdodVlnN29mVlZ5UGp1eG9lZ3JwcW9z?=
 =?utf-8?B?MUh0UmxPRDF4a3F5aERMZW1Pekx4bmVFU1pGaEltQVN2Nm4zWEtQTGd2Snc3?=
 =?utf-8?B?VWJjTU95d3lrOTlwUDZlWkoxS3RDS0NxYUE2aTdXREpEQXhMbFM1UTZQbDdJ?=
 =?utf-8?B?TlFvVGNWb0M3eHE2d0IzOFJLQ2t3dXJGWGVBNUhmdk1Ua1c1Q0ZXelFMR1V2?=
 =?utf-8?B?d2lLdjF4YStCSHQ1NHNCTEpJdHRLbXFYSDZ4SStyMExISU93Q0Z6STNPZyts?=
 =?utf-8?B?MHpsSzBPbnNjUGJWM285SVh6WHJkd29FYzJXMzhIeEJ3VkhlUm15TjU3WHFv?=
 =?utf-8?B?RTRJSGdZbFp0SUlkWnRGU2pab1lnaENRb0JkQittTy9VQWRkU09hbkppMnBa?=
 =?utf-8?B?WFRFSndrTzJZV1NzZUJjazVoVEdhR0xCbEE1cU5hNWp4VFROOFMxSWwyN1lQ?=
 =?utf-8?B?REVzQ3pKMERadXBHd0g1a1FhVmZDRnl3V3FxU1ltalRqeXdMb2w3S3k5bity?=
 =?utf-8?B?dEZiMkoyMlg0OXVSVkFBWXRuQW01VzhyTFVRUVltWU8rLzY1RkRMVElzZG4r?=
 =?utf-8?B?YW1nT1pGSFUrc0RTR25TajdzWnVTb1ZHOUNDVWZtWDVqWW90ZVNsWVBtQmlx?=
 =?utf-8?B?SkR5bmgvNS9JZ3ZxbDI5ai8yeG9YckQyMkowTG9MblVUT21pSHBaVy9sQkN2?=
 =?utf-8?B?cEdWWTBvRi8rUFlrZnlEMDJ5QzlqRkJBZEoyTVdERVdreTRXeGpLVXV3akdt?=
 =?utf-8?B?cGRGYkw2NlF3dWxhWWFxak9CTFIrVVpkWURHakN0S1hYZTQ5OHlUWDJvTVBB?=
 =?utf-8?B?a0VKZVBodTlJeDJmUjdvY0xNNGlmS0ZTRjJHQ0wzUllRb2cwTUJMRTJwSnZh?=
 =?utf-8?B?aDFMcjB6Q0dHYUp3bVdZWEJlWHJ5blY4RFNWODBBVE5LY2FqOXkwYStGck04?=
 =?utf-8?B?RUdqVHF6MzZMcUJ0Yk5idXBiMUFtZlNhanlSM2dzNHJaK09jL0hHZzk5MWx2?=
 =?utf-8?B?dGtOSU0xS0FHdWx6RE54T3Fpa0JFNWtqUkR3bWxSZDB0aktxQlFtUFh3V0FE?=
 =?utf-8?B?M21RTmZlNStyeUlGclFoVGVCUHhtQy8vNWpoakZDMFBSVS9oNFNNRnFYdDl4?=
 =?utf-8?B?SWdWVlVNR2FWdzhRRzJnN3BDa3prMEhIK0dzMENsS0dIeUQ1MWMxTk81UEYr?=
 =?utf-8?B?bHNPNENpVlVVVlhiYjF2UERTWURiWXhCVG15Tk1aVmJjMFhYaFRmQnZXK2VU?=
 =?utf-8?B?MitaZHA5VHFtUG9COS96VWVLaWc2MFBETUZtQVU3bU1EbmVOVm1PaXJvRTJV?=
 =?utf-8?B?RlpkOHNtcTVJa0xtTDNRb2YvYmVocHJmcGM0cTNnaG9EOW1ZMnFzdndnd3Va?=
 =?utf-8?B?eFJUaG0xck1SUTN3Wm8yRU1SL3MydHBrY0dZWTE0SFV5K1BMSlJWOWdGYmtB?=
 =?utf-8?B?eHEzTnVpTVpXM1A0MEd2UzZkTW5SZ2tnWFlPeW1TdE1wTFFhalJsRjBaZkFN?=
 =?utf-8?B?SUJOcWVzdjVtWlJuZmdtWWFWaDFMdTY5aGtQRlRaOExFOHJDTzNwbXo3dFdv?=
 =?utf-8?B?NWdSQVgrV0pjcmE5RWNJemhoZjg0K0M2QzhYR0ZrZFRRMzBkdWF0R2MxYWFS?=
 =?utf-8?B?TmRxSERWQnBPLzJ4L3JhTzEwZ3M2T2UzVmN6YW50WnFsemtDdzNNellKUEFp?=
 =?utf-8?B?Wk9YVzIvKzhNVmhMVnc3Njk1ZkFxcm5aajhaQTRpdCtOb09sazBQVXhZUm40?=
 =?utf-8?B?Mjk3cHJoMHAwaExpNm8xYUlRRzJyQVVaM1ZraVRFY3FML3NDTnI5eXRiVUNo?=
 =?utf-8?B?MkhHaW9XVlhPc2NzUmpSTm5sQi92bGtTb21SbUY3QXFqNjhzVHVBNStBSWtD?=
 =?utf-8?B?c1F0bFhWaEdwTmM4SFhKTnkzOERZRHJVNWF3ai9PZkRzVHR4cThNQWtTeGV6?=
 =?utf-8?B?ZkQrV2U1U09EeHVmQ3hyanRqZ1IzajhaMDkycGIxNmRya3F4bkxFYXZUbDg1?=
 =?utf-8?B?S0prc294d1ozV2hCM0VIQnlvOERSeURpZW8zWU90TWgyMHJEZG56Tkg1N0Rq?=
 =?utf-8?Q?16r2o61Ii8w2SeFhm2qKgBGis?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88cac7fc-8231-409f-1ac9-08daad12ea3d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:03:17.9261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vLWH6tR0XUD/1jJ3r+judK2kZbvSVjOEy7m8z9ovheOoNyKz3pW8MHhMhDBZEwEDULUtjhFlVpZmFh4l2z419A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6086

On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote:
> From: Peter Zijlstra <peterz@infradead.org>
> 
> Having IBRS enabled while the SMT sibling is idle unnecessarily slows
> down the running sibling. OTOH, disabling IBRS around idle takes two
> MSR writes, which will increase the idle latency.
> 
> Therefore, only disable IBRS around deeper idle states. Shallow idle
> states are bounded by the tick in duration, since NOHZ is not allowed
> for them by virtue of their short target residency.
> 
> Only do this for mwait-driven idle, since that keeps interrupts disabled
> across idle, which makes disabling IBRS vs IRQ-entry a non-issue.
> 
> Note: C6 is a random threshold, most importantly C1 probably shouldn't
> disable IBRS, benchmarking needed.
> 
> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf5835bcdb96
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

One unrelated comment below.

> ---
> v3: New.
> 
> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -141,6 +141,12 @@ static const struct cpuidle_state {
>  #define CPUIDLE_FLAG_TLB_FLUSHED	0x10000
>  
>  /*
> + * Disable IBRS across idle (when KERNEL_IBRS), is exclusive vs IRQ_ENABLE
> + * above.
> + */
> +#define CPUIDLE_FLAG_IBRS		0x20000
> +
> +/*
>   * MWAIT takes an 8-bit "hint" in EAX "suggesting"
>   * the C-state (top nibble) and sub-state (bottom nibble)
>   * 0x00 means "MWAIT(C1)", 0x10 means "MWAIT(C2)" etc.
> @@ -530,31 +536,31 @@ static struct cpuidle_state __read_mostl
>  	},
>  	{
>  		.name = "C6",
> -		.flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED | CPUIDLE_FLAG_IBRS,
>  		.exit_latency = 85,
>  		.target_residency = 200,
>  	},
>  	{
>  		.name = "C7s",
> -		.flags = MWAIT2flg(0x33) | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.flags = MWAIT2flg(0x33) | CPUIDLE_FLAG_TLB_FLUSHED | CPUIDLE_FLAG_IBRS,
>  		.exit_latency = 124,
>  		.target_residency = 800,
>  	},
>  	{
>  		.name = "C8",
> -		.flags = MWAIT2flg(0x40) | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.flags = MWAIT2flg(0x40) | CPUIDLE_FLAG_TLB_FLUSHED | CPUIDLE_FLAG_IBRS,
>  		.exit_latency = 200,
>  		.target_residency = 800,
>  	},
>  	{
>  		.name = "C9",
> -		.flags = MWAIT2flg(0x50) | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.flags = MWAIT2flg(0x50) | CPUIDLE_FLAG_TLB_FLUSHED | CPUIDLE_FLAG_IBRS,
>  		.exit_latency = 480,
>  		.target_residency = 5000,
>  	},
>  	{
>  		.name = "C10",
> -		.flags = MWAIT2flg(0x60) | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.flags = MWAIT2flg(0x60) | CPUIDLE_FLAG_TLB_FLUSHED | CPUIDLE_FLAG_IBRS,
>  		.exit_latency = 890,
>  		.target_residency = 5000,
>  	},
> @@ -576,7 +582,7 @@ static struct cpuidle_state __read_mostl
>  	},
>  	{
>  		.name = "C6",
> -		.flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED | CPUIDLE_FLAG_IBRS,
>  		.exit_latency = 133,
>  		.target_residency = 600,
>  	},
> @@ -906,6 +912,7 @@ static const struct cpuidle_state snr_cs
>  static void cf_check mwait_idle(void)
>  {
>  	unsigned int cpu = smp_processor_id();
> +	struct cpu_info *info = get_cpu_info();
>  	struct acpi_processor_power *power = processor_powers[cpu];
>  	struct acpi_processor_cx *cx = NULL;
>  	unsigned int next_state;
> @@ -932,8 +939,6 @@ static void cf_check mwait_idle(void)
>  			pm_idle_save();
>  		else
>  		{
> -			struct cpu_info *info = get_cpu_info();
> -
>  			spec_ctrl_enter_idle(info);
>  			safe_halt();
>  			spec_ctrl_exit_idle(info);

Do we need to disable speculation just for the hlt if there's no
C state change?

It would seem to me like the MSR writes could add a lot of latency
when there's no C state change.

Maybe I'm confused.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:05:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:05:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421931.667648 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwxe-0005Vw-UA; Thu, 13 Oct 2022 12:05:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421931.667648; Thu, 13 Oct 2022 12:05:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiwxe-0005Vp-RS; Thu, 13 Oct 2022 12:05:14 +0000
Received: by outflank-mailman (input) for mailman id 421931;
 Thu, 13 Oct 2022 12:05:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiwxe-0005Vj-7y
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:05:14 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 49c140f0-4aef-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 14:05:12 +0200 (CEST)
Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 08:05:10 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by PH0PR03MB6978.namprd03.prod.outlook.com (2603:10b6:510:168::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Thu, 13 Oct
 2022 12:05:08 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 12:05:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49c140f0-4aef-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665662712;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=dcu1VIhrf9Lv6Hmet8N2CMlldpOl5FgUfcZjnzBW3uM=;
  b=YwyszGUEiI1/xdmyudY87t465Tg0XvEEL79pxsOR8v8qw/UlCWNExWP/
   AdmMIn+2ZxZ/3cIUWXDJZVAfEvSiUwL7jek8Z6KAmdlUonRSHAOkDAoKp
   n+0KEaXXG5TGop/df61H88XC4ZmE7TwlRFDAhP4rbN7t3xIPA1Y1XLvph
   8=;
X-IronPort-RemoteIP: 104.47.55.171
X-IronPort-MID: 82655870
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AolESeqgAAt597ugVgYaMDpnVX17brhtdkbtou?=
 =?us-ascii?q?6ucsGbSi6mo8ft2uZtPesM2Ph2Ov8aJ/3J7+ZAiuzu2VEYjOOrE3MaLAtYh/?=
 =?us-ascii?q?s/zv5qi/A6NH9G2nGeJcc1Bpjkd4/DhFxS+EX92VwSgaAVWIa6atagD0P57K?=
 =?us-ascii?q?1fj80te1/M5I6rlXP7R6pjZ30k3dC5dd0nihZtSCa4kUPaAwEIbFU8jkNxIw?=
 =?us-ascii?q?BD9me6xJs/SOqMDNGUXxOGqGgnk0stLv3GET14V+yrNInY4AGjZeFScDpS6R?=
 =?us-ascii?q?1dm3JVMiDZmiB0UZepx7cca85e/mAZzGI2/+eDzWgpHhR7utjbxJJ5Z9YlsF?=
 =?us-ascii?q?sXIBdK8S55AJs2McEDMQTeQdluaVx6UHqdPJ3GBBJtmZAg/ktSC67U67CHty?=
 =?us-ascii?q?OOEe3CsYCuLUc1TFbQ+kI78SPO5+4036mSgfhpSmF5j4K6roNehJHQlL5czl?=
 =?us-ascii?q?h34Gr0ir3/qVvvn/r0wqVBncsIjMmR4yXAH+SixeJ3M5qwl+ETFMDw8A1W08?=
 =?us-ascii?q?WEzo5qlyYWsjWvDbkWZcmAzGQh2Ymv7AV/6FiJklnfCvzKbvyLA8cZ07gtmY?=
 =?us-ascii?q?yJ4AZNvpSyfzo+dqTqbkPu6lC7V1cwCL1bQA4tE0VXrfgXBBIlcoukZapaOi?=
 =?us-ascii?q?0xsV1uFnQOEbgJRIkqNijDLASOhtjFazhBmEG4ZgEFDVPiayw2O69sZWa17n?=
 =?us-ascii?q?CqYJNXh3PSjchO4BGJ1UCnfdVNV/Y2mFKnD0pukj+Ar36W7foDRP0K2msRc7?=
 =?us-ascii?q?2J1CT0g3cF64/4qgdRkRYj6XdzzgudKK1SqVN5ZeooNvEM5vjoR7zLRzICC1?=
 =?us-ascii?q?/LM9eL2aeleozN2aB90gHe8QcJAM12lb2CcXS6x6FpuxtfPVebVqtDbPIkg7?=
 =?us-ascii?q?JtO9rPrbQgoTOREBUrl/WXfpb9AU/Lv9eqGyFRwgxhMwHKjSQWVOozcGXXi9?=
 =?us-ascii?q?Rf/U2Fc4Oev3hf4FeLSIBfuMl6bHs8ycEAjMa+GaEVncJi3YumBXvgFrdKm3?=
 =?us-ascii?q?na65hfcR4ESVjNKTVi0GbM7UdPXzq9vyYvgEidnZcNPRmyyYtmf7aSL3GYPd?=
 =?us-ascii?q?LctTNTEAcvHeg6M528RME7CWwm2u8mRs+Sk3VSGJqdwZkNAsv9bYWz9F53kM?=
 =?us-ascii?q?wcMr24F/G+8L3dgVRYQZEw3EfEEYPcEGd4ydQD95u/FiSi4qyZjCEp9eDMwK?=
 =?us-ascii?q?zy3SVB/nxicUUB1s/0ug8ET8FqREzLB3G8a+btCd+S0EO10dKzFJDWUXkJBE?=
 =?us-ascii?q?SlwVw0lkzxCLK9w4WMNlVdnT9Gmmcy5H8ej89DWdPsKbA+If5fKyPD5C6BHC?=
 =?us-ascii?q?sClGP5G8oG/3dVHJI+/wKFnZCT4FNDPWbg2Jjg90Vblf2hZtU2ENYPQlbw4q?=
 =?us-ascii?q?ObZLS1qR5yMS+sixJmv8dLZQ5YZfs9kvNsgjULt6bIz2pCl4ImmW/lCnaMKc?=
 =?us-ascii?q?HLs7Xr05JdoSW3BHxJ2jkO38YX9hDM2xm9cs5u9F6FTk6f3QuSiXWjyv+cSy?=
 =?us-ascii?q?RQZBnYJMItyTscN60Ce8Ph2faN9JSs7ByYaAc49kFkse52C6jnrNDhel5VZn?=
 =?us-ascii?q?4tMkS0M6GLC9OlpPewuk7jl7WnqoA63YW9KVUN03NpFZD7x3lj/6cfqPpqPQ?=
 =?us-ascii?q?ZatEnT/dQyUCG8/ASrp9uWLmiVjARA/ypQfqjxB9FAo7/nPRxsWb54RGowzq?=
 =?us-ascii?q?Y/mmkZjkm49Lw7CG21krEU3YZgHfijpxRvMT4slDLfsmXfS1/dIniebUEjgN?=
 =?us-ascii?q?yodh/3+mzH+XIjaZpFIE9ypwAYXK76YknxJ4C6wvvNzG/XeHm2YNtST1I5Ol?=
 =?us-ascii?q?U4m/r5HueWYwRLj+2IBKXjNSyTz0ltC60eqgBr63zeZaDKRV07g+pRbjfYse?=
 =?us-ascii?q?tSjFTzB4NL0wFqRJ4p9uJDgrgNpkW2kzBKpOjOBALBszhPRkhOhLmwIqL3fW?=
 =?us-ascii?q?k/IpoewdShJx38kxAP6+nGlZrAGXA/hX9DycwOOwtsrN/1EuxnTsO9ADNm7L?=
 =?us-ascii?q?U2fYXZD7njLIC4YdsRtz03hLHFNebqQBEAtDBWKrbYxoocFYtvA9xyD7ZGAu?=
 =?us-ascii?q?/tCIOglPv7bB6nB2H/WgJKpSSa/IIfR++chdXovSKLCg56EjO/AqJq0fim1e?=
 =?us-ascii?q?pgBXA77Ah93jkX1LQRch+ZBYtuELj2XC+/XxdKu50yKM4GBW8W3H5GEfujpy?=
 =?us-ascii?q?sBSRSbwovHhA9ep5aIijf1MJR2IDUjjlVMIb73oJGUB/1KsyU9FrzB5arBQn?=
 =?us-ascii?q?N3hPkvnXcHwyQlfsX0ZJVzbYZjBk5ZfkDz0Pzj5PtERMjJf3YkEAIzc+djRg?=
 =?us-ascii?q?5JdbWuKnxVSv1E+fk6MheWp8y4ItmgQCv66sDE6icqJ17FPDPaVjyISHXsjm?=
 =?us-ascii?q?+p0/0pyR6fJMeD9zVAxCmo6UlE2EWOeqbQ89jNSt7l9KCsi9oiV/7PR2rjor?=
 =?us-ascii?q?MQsI6hX1A31VKVCOKHb1qjvvIat5SwnTox1?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82655870"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F836vKtLiIXOyQ9be0UUiEa2UdfVcKWuA/Uv9L5if5XQEz4T1RfxcNCS4X4n0QK7WvStCwMJ7+j+uRPiokixOTsEGhWiwGMlz9lzyChRRYK1feGg6GL+2F8769bvnRiN8n50loGFEP4nU8rZLX8TbiXTDb03qrpYwPI19feg7OZvUcQIVqzyPhGLT72+t31fckyMWzZaUhPLzyyZ+gF7LycBJGE332cRdKm68sFRRzxHPxs1An/hNjqt+qHujCrlunrMTFJDw/6GvzenXSqz1yrB0C3V4Ov75TvpSosJjfZsm/HlBL40flzFAbgXtwomX+MZNObHT1iDCf2nHRXx9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eI1a4d+t/3ANeUKBCLySlGMA/VbFUI2jojanCzs/xv8=;
 b=Cbwqa17vREkRaMfqXafufHIeuiz2AuetX4RdeQKqYCZX45zcvynsphzgl0BFKpJgrTaMRVyuxj71B2B7iuyLtsYjVZ0XMkLHrDsq73NI7C1Th0ws2p8gXGYVH17ke8oh5jJJEI/h3unMle66mD4zkLGkNsChEBUPAuqikbWBclxzTmUkWH5OjVjRtCB1k3sUm2KvP9xs1povC2vRn1Zjl0BGgUWUt2fHUGjv75hUMnnHJemC6dIbXJCv0ZaL7p0jYLt/LxUfcDj5XDImHvKy6gB7FJ6SNtob9jiiUMGUtvg2jaUBYuG3vNfCYpEzKtMNwszIZQ5TjY2YgmEzgKbxEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eI1a4d+t/3ANeUKBCLySlGMA/VbFUI2jojanCzs/xv8=;
 b=OPxGyXdHwS5KECBFLybnNXAw5czGyQMxzmPXIAS2fF/LJvN0D15w+yv0hZ7Dfr+cTFr1wd9wzZ4YYzWi00h8UmaGmeDLqLUosz/m8U6VQ5H1cn2JELDfsex5BRKpGHhqtcwiIuxC5cKfCIVgvXatplmeU/DeJCJMH6hQdlwvwXI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 14:05:02 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 5/5] x86/mwait-idle: make SPR C1 and C1E be independent
Message-ID: <Y0f+7pZWOzGD70Gl@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <3bdae38c-1dd4-558e-64a7-886b9bcf771f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3bdae38c-1dd4-558e-64a7-886b9bcf771f@suse.com>
X-ClientProxiedBy: PA7P264CA0003.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:2d3::17) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6978:EE_
X-MS-Office365-Filtering-Correlation-Id: 70cb210b-778f-4284-e1f3-08daad132be0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u7o66tmiWaqVIR+kgbO5Jyk5ja6OS2iJpNzVkLOZhcwbossOvXMalejESzm5pxOX+MQe4FQ9FYWgT7+u8En9raCx3OOn3ux8cIx6yuud1oRkCjhIFOajp++8B3OfmT3/ue9yrYrzKNckscevK6rN4QTv13eIoLW0gXFunQHMWZn7yLNHA8bqq6R6910S/JO0PJprU+Nfe84AIKQ8B/ThjqAcCNNrbZ0uckcqV8aeAFr4B/QlhA4C/AyF2ul+gQdEw9og0ul4fRyBAZoudEixwBsLkoHAJVVfJBJa6Qf7+z2dUm47OM9a/bsW2LdnUtvXV2CnlZ8RcD7x/+W7p1iuiIF+lfsr2zzaVzu4mOL5sytRliIUY0uX/lF4ULDCoTa8iyyZOtmQsGPUlvVlrlTyJduJrljX9pE5C6Gs6CNtmt9kyvZbRPqFp4P5ky9lO0nx9WFUkuLWY6MGoSJAk/l67POq9Eca0v6mcWRuHXuDqj/EJV34ocuSz+iGijDtNPOLS9RIgZCwrVXyyzOXaS/ezQO4EbTgamvixjDuUcFg+TkQVmoxk1lmc5b4rl3Ll64o4kajnVZfiOfP8HES8zVzPAAikEuhHRjki8MSJeZ3NwOczaiYfd50QDD0h5Y/nDZ1Bgri/1R93ClrBiTE0CgCcMt/VCvkQGktZwLB/6dEIPuOXuheaGmFKYZnnvJu0v5O9GsSbPWWWhvUl+C4Soe3esxDQtDYiQCREqficocJcojp1f4c5w+Ggk99dWBqekkDNoJZRPfld9zS+bcyfNAqZw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199015)(6666004)(26005)(8936002)(6512007)(6506007)(86362001)(83380400001)(6916009)(316002)(82960400001)(54906003)(2906002)(9686003)(478600001)(33716001)(4326008)(66556008)(5660300002)(8676002)(66476007)(66946007)(38100700002)(6486002)(186003)(41300700001)(85182001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NFFhN3FNcFQ0a1QrTG5MdFJCNlRDbG1mWHY3U0lWaHoxeHFlL2QxR2NraUVU?=
 =?utf-8?B?ZmpWazdmdHh3UHZOSUQ1NXcyN1ZHd2JlaG9pcTRVVnl4UThUaS8xRFp0Z3ds?=
 =?utf-8?B?cDJhdlp4ZE1OTENkcFl6dGNtNWtrNm85NS9LZ09PNy9pS2lUdWVwTHNtN1NO?=
 =?utf-8?B?ck9TOEFyQy9YWk1GcGRVOHJKekswcDlYZzBjMEszSSsxaG43THJieU84UERv?=
 =?utf-8?B?MkZqVEhYUy9pRFdkckl5M3N3TTk4dzBoRjlzOHM5T0pYOVZFZzFGVUY1TGRF?=
 =?utf-8?B?QW1wQkRuM0lBYm1KcFl1eWJQT1VXNkZ5M0kvY3pjVVVZZHI0VVlaU0RLSnB0?=
 =?utf-8?B?Tkx2bmFHR2JaQ1QxbmkzaDdjWGR1K0VQOFRpeGZ6b1BEYWJzT0EwMm1hdDRu?=
 =?utf-8?B?UDJGQStXbmJFVUFHVnM3WUpuN1FWVC9lSzVDMTgzRGhMQ1ppd0RMcElOT0lV?=
 =?utf-8?B?dlB5anhveGxXVUJjbTgvcUxCYVVqM3FvR25kTkl3dGZIY0ZSZjFUZHAydlpU?=
 =?utf-8?B?bWpZaU45S2VHMlk2enQvblBJK2hMTW9mNkE3YndXczZ4L0gxTi9zVnZpeVFj?=
 =?utf-8?B?UkZzOC93UktmSXZ6ZEMvbWkxeDBId1Z1YlJWeUZSaDV3dUdrZVFydUVjenZq?=
 =?utf-8?B?NW56Y0lXUStJWUZMMEJCYWZrUW5vVlp3ZXhjZXExYXZBa21GdFNCRUQ3aHJq?=
 =?utf-8?B?U0NCcEppdWl4UEZaT1ZZYUI3dXJ1bkZRWmhiczBUbytINnFlSHpxZ2NzTEts?=
 =?utf-8?B?aXQ4anFITHJnVEpZUGJHTlFVRDVpMFFQQTR3NCtEdzhZSFNZdkh6ekpKUExa?=
 =?utf-8?B?ZHNMd2dGemJRSU12aURwUEpBMkhJK1Azekh1WWFDb0dWTU9Ya3puR3ZlZXRM?=
 =?utf-8?B?TWVId2pPdm5iWG10UHJERXlFZE1HV1FLbXFyNXlzSS9NZGF2bGxrMXJTVERL?=
 =?utf-8?B?YVRldGZkLy9tUThTMW5UcEppVGpjQXhIR0xwWE9UYTN5WHFBeDFBdjhxVlRh?=
 =?utf-8?B?UTVsV1J1Z0NCVmtoZXVXdmQxVTZQd0RESlI0MkZkbnRwZExWMWVDa2pTTk5Y?=
 =?utf-8?B?cjYxRml5NmttVnZzVkRXL28xaVh2enB4emY5WlBBWE5ZZlVrUzNSMGdJblBZ?=
 =?utf-8?B?bWVhaXBLWkRaZGhnbHFvZzJhTGVZZmtkUEhBQTdFS0JlM1MrYzhObWNxNk5a?=
 =?utf-8?B?c2pyUUlsTDllSkg5bG1FS09pbW1GazZVdVU4cDhGYWRESG1pSU9tWGczeDkv?=
 =?utf-8?B?WnhyeXI3SExWZmtRc25DL0xCaDBKVW5oN1NHQ2VFdDZ0RW1ocEM4WHNQcXNw?=
 =?utf-8?B?SUN6RkdXYXJ6V1RwY1JTRnVhaWFEUlZ6dlF4L3NoV25qeVRaNXRic2JCM3Bt?=
 =?utf-8?B?anNlYjZxU2ErUUxTRlF5UzMwbGgvMWhTMWFrZUdVMlMvS0NtUzVzSE5lUjlr?=
 =?utf-8?B?TGFYVDZBOGFGWE5Wd0RzS0x2dTFKNWZVZlFta3pWZXBNc2c1dUNmcjdBTmhF?=
 =?utf-8?B?eDhrVGZSL0hUWm8zczZLRHAvbW9WV3FiSGU0NGh1bm9ZUjZ1LzNPL0M0WlR1?=
 =?utf-8?B?QWJ0SDBBTVFybnpqLzE5b0NaYW53Z05CNHFETU5xMFNMTUlyeDJHTEVVcUl5?=
 =?utf-8?B?THl4ZXFtaE5NUU1JZ0tFV3pJa3paNnlHTjJ6ZmFhTWQza1ZsSk16YU1PVFMr?=
 =?utf-8?B?VjRxZU1GWnkvS1B5MDdqY25FaE1na2FBTUd0TVpwMUtMZmlFaVhGM2RmYzE3?=
 =?utf-8?B?UFJydTZlL1dGczVMaXp4eGJwdzJXVmlTUG4xc3ZHM1VtVndUMDd0SitLenl0?=
 =?utf-8?B?ZVNQcjl0cFZ5WlJkMFJJemttQzBXLzV4aXczaFRiTEFpSW5HY2IreS9EcGFz?=
 =?utf-8?B?OG5nL1dUanJwM28wUnArTnBrRmk2cE10OTNweUkvRUh1bVJmOGNHdjJxKzA4?=
 =?utf-8?B?eUMwS0hsbmI4R21Eazc5bzRhYitYemQ5QnlyMGpwTytmUVFUYnBUSjlIeHNU?=
 =?utf-8?B?ZGhSaTJGVGg0NzIwdXpBQVdEUzNZWlFoU29CbGJpVFBhVVRkem5jS2gybHJH?=
 =?utf-8?B?a1YvODlqeks0c21KU1Z5Wkx6RDVoQXZvdGxMZ2M0SFlramtBNC9aNmN6MVl5?=
 =?utf-8?Q?UXG7H8H1ZrUfiEkO5k92/Vms3?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70cb210b-778f-4284-e1f3-08daad132be0
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:05:07.9425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2saAxIludlvsOeQ6M6X2ko3fKM0dFwxqeY0kGwrIfxkFNw1ZWwWMlMjuxJ7a8rU6GcO/bf0ZNYcm9gtbYt3XCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6978

On Thu, Aug 18, 2022 at 03:05:19PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> This patch partially reverts the changes made by the following commit:
> 
> da0e58c038e6 intel_idle: add 'preferred_cstates' module argument
> 
> As that commit describes, on early Sapphire Rapids Xeon platforms the C1 and
> C1E states were mutually exclusive, so that users could only have either C1 and
> C6, or C1E and C6.
> 
> However, Intel firmware engineers managed to remove this limitation and make C1
> and C1E to be completely independent, just like on previous Xeon platforms.
> 
> Therefore, this patch:
>  * Removes commentary describing the old, and now non-existing SPR C1E
>    limitation.
>  * Marks SPR C1E as available by default.
>  * Removes the 'preferred_cstates' parameter handling for SPR. Both C1 and
>    C1E will be available regardless of 'preferred_cstates' value.
> 
> We expect that all SPR systems are shipping with new firmware, which includes
> the C1/C1E improvement.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1548fac47a11
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I guess we need to be careful of running this on pre-production
hardware then?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:18:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421942.667662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixA2-0007I4-8y; Thu, 13 Oct 2022 12:18:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421942.667662; Thu, 13 Oct 2022 12:18:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixA2-0007Hx-4p; Thu, 13 Oct 2022 12:18:02 +0000
Received: by outflank-mailman (input) for mailman id 421942;
 Thu, 13 Oct 2022 12:18:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oixA0-0007Hr-DF
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:18:00 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 076602d2-4af1-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 14:17:39 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9356.eurprd04.prod.outlook.com (2603:10a6:10:36a::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:17:56 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 12:17:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 076602d2-4af1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wi5MTCxbGA/TgCG4juV/wO81k/vJGicc6l1BE+5h+pKcg0+2GtA3UEq8XoPcjHtLkFVZWOT3PB5HoBulISsOJ22MuRNiVANmtonDU9ql5Qj3x9qxEa8rOjyvBUtXVes7PgfkmfyWjICW1x+TcHrMKz18l1oYEi7QsEQxeTpSjrfxXPJjbCPvVmOq0pZiJCKTFgap9h1BkLvlXb2pN9ImGQkQfEhcBPyhEnHfEt1EgbslO1trmLiWKpxjWn/PMZLvZHxhwupd38sMQq/fkp/0yDxpUGqbWoWtzL1p1/r5qCkAUsCmFEj5crEdWWfF+Lh42YHE8klmpT/nPQHwcKEe5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XK8Fk/3t/RkI2EIMqnqBUnpyCz21P1JM5Ws4hQDBe5M=;
 b=lny5LzQ+3Q9XchrBIbZKI5UFr3u0oIpskXlEzHxzLEueqCeJsOpKJwl7CF46knl11zSOFGAFIH3Nw+Jci3h605haw1Qk8rBnmBVSBEbFA8WiuY1oJ1SfXMSPcP76yJt+FdMy5L1UcwZGrbV6WJvuWq16APGoOkiRIr+iWugmtlZqoeYY2j0ALcCajBmLg5Ix6Ez7wGHgx0Rx6GWEQ7+jEyjZvzoFhDoNNzKXjzqjmXheiULFfoappnc7kckvJ0CwQa5RYT40yKdCvZo+T4u/gebKAwVQzR8I/nErXsrM+0imDNSRLDDFC5fjCjfIvzKE1pqYqa9BaEOz7F09xYGoyg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XK8Fk/3t/RkI2EIMqnqBUnpyCz21P1JM5Ws4hQDBe5M=;
 b=KmHVJnlMyndUE1ZMz/sxyw/mVeqSeeXBexDPh0LXxZ+E8QlLo3FWHVkanTALW7wcn+aEVwTYPMZT4LOvI0rylEkWp+P/tu+WikNd8Pc1F9nMM+BL4xSHGpt6ZA1Su/Fmqptc4GiZAPD3P3sNKlTYIxOKt483Gb4ntSzLZ7mL91NJQ+C5NhTSk9tGBjdXFvHb4Aev3bGEzQOLeLDCwn4JuflnLpV/KI7LAokqVW6/KPRT8ElyP7O/PUItXEQpsZ5pt9C33urkHh7yUf5KaiU4Vepwc3pRCCXjGfscNC1LE01qEx+ufhzMaY9jVqmxxxjPx8Koy7ULh+I3BJHZkROquw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1867142e-ee46-daa7-c05c-04045460ba52@suse.com>
Date: Thu, 13 Oct 2022 14:17:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
 <Y0f+gL1PfB5lzlDj@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0f+gL1PfB5lzlDj@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0097.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a9::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9356:EE_
X-MS-Office365-Filtering-Correlation-Id: c476a1ee-caf3-4842-b399-08daad14f5fe
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7P+qqHB/GpV55NXeMdCFFyuHSc51XvxrhRX2pdfb1UTVR31FKyk9gYW93+0FqlTthA5nYIhJLmayHZYu1ygp1X35DY6Ld5hfO6Z6TDOoLqBaZ+8BykNlM+BYDglzY8+VFO/4TT0O6fb+0DEtFisjeetKOWS7TJYA3H27WnRlpAo0o4g6K4SHRFdFONKPvkcXu1OunWONAF1tUjI4HRIF7tVwaME13HQhNgygEYzBWFAmRtzc6lFnQvnEcPaJceX3DCtnqVEY1FQNOMVCa7exJx6vyivJHpgP1jL2mP9GI0qyXNFCAeSyRtSnXlQ6DIaZoV5U8MDd3mdZTmqtu0saMgjQFtJMap9ms2irDNMcUPh/DpuA1k+JBXVKh8YRFLAU3D5RfRaJNoDRJYWVBAFDlAfQOYHQ+a6uCEmPyzF4YrP8BN283V7wBucuNlRjhO5cpqjHZS6Ds7m/pCvZqFgxLKdU4e0+WrIC+jbT7TAeEZxxmXhGeQRWMejldNjHwVh7BwhypycySCIyc2GgGlBfO+GaeF4LWvC6YwN/mnY7pLuJnMvhLTwsxkUk+9g1b+eU9Ol1XA7xp61AU0a/S2Ltl6mfFw5o+pQLjQ+49mHdf/9WdONdH7DxVfK78SpwoLUuqc18SraOUBKtJ61ZdcRPi/+gin96xhijnnoYAumXfqHysKqLHZWe5UUshV3MRrHX/3dYl9Ns31cGPnHJ8to8B4W75sThiR2tiPzA8WoKUueMN06SSM2FfbML0f8wAxqmFUbI4nrm0plZuv9hNUHouLuCb9klMY1dvozaMj6PaFk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(136003)(396003)(346002)(366004)(376002)(451199015)(31686004)(8676002)(41300700001)(4326008)(66476007)(66556008)(66946007)(38100700002)(83380400001)(86362001)(316002)(6916009)(36756003)(31696002)(5660300002)(8936002)(54906003)(2906002)(186003)(6486002)(2616005)(53546011)(6506007)(6512007)(478600001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHdHSVZPanFkRFp4K3lFVVVqeHpackhXQm9KL1JmS2hCTjl1VDYyd1BRWjBS?=
 =?utf-8?B?UVpVc21xQ1gyTzdhWTJiaEtHL1VJb0FsNnp6d1liWnptVi9lTWJNbnlLSW5u?=
 =?utf-8?B?Y2ZDaS9JZUpMQVhXU0tOTm9WQ05lUUliVG9pa0N3cEpKZUJRWFFaQUxQMjAz?=
 =?utf-8?B?dEVPVDRqRVNjbzJSUHROY2UrTXRIaTZHZ3dzV202UUZxd3FqWlpEc2pwODdv?=
 =?utf-8?B?WlY5eXJVYXFOdmE0ZFVyWUNWS1NCbUlQUVk5QTYxcElCYm1wZ3Nyc1Yvb3Ru?=
 =?utf-8?B?SEVOc2Yxby9xQXVFSnBmTVpDWWZsd1RzUGM1Y0R6UGRpTkJHd3lIbWY5K1VT?=
 =?utf-8?B?MWxYL1hROVNudlBNMWtwZ0JnNm5mdWtyOWNtVEtoRC80c3BVTlZ5b01tNGow?=
 =?utf-8?B?MzVENHlsOWJFVmdwRFhmM2VWamZ5ZXFzZWRhbU54eTc1djk2czFwRC9jbVB0?=
 =?utf-8?B?cUljYitWSi9WTWJzVFRtemNYM1JXWkEvT1lXZkxjbEREYnRzRFd3eE83dSt1?=
 =?utf-8?B?M3VObk04U3pCYjRlZnk4V2Z3M1plZ09vYWVIcjJ6OW1ZYUpkTWxmTDF3blFW?=
 =?utf-8?B?WjJGYlpOSGtWVTJPd3FCaUpRYm1qdDJxb01waFRMWEl6WUtIdDJjaWdkblcw?=
 =?utf-8?B?NHY1Z2picXdOZGRiMEROck1NNWQwajZLRlk3a1RzeDZWSUR3b3cxQkRLbWhr?=
 =?utf-8?B?THduMndHYVVQek4wL2JLdEFDd3BTL1YvSEhUZ21EYVZ4dDJyTHZUYzhhczht?=
 =?utf-8?B?cE1Pc3pHWGxqUmkyR3Bhc0V0cGxOMDNZbG9zZXJPZ1FWS090OTI0aTMzbFUr?=
 =?utf-8?B?TFQ4elpYYU5CMzdPemoyZWpCaTRXUzVqcUtUdFhNcWRGMUFOVkRtbFVneHdv?=
 =?utf-8?B?QWc0VU1kQVE2ZDhDRmlGMUlIWHM4am1DNUhwMUljTzZpSVRSTzF6S2orajIw?=
 =?utf-8?B?QWRqRGtiVUxiVGdwM2NFdzlGU01jUS9nUDVLM1NNbFJGc3ZaUktZVGtkVFYr?=
 =?utf-8?B?RUlrZit0WE8vVk5CeUlCdThkTi9lckNETjY4L2FTa1FhQTFYSGdxTWhUeVBx?=
 =?utf-8?B?aXJQcEpXeU42Nis0dmN6d3Rra051czBtS3BMdlRjSmFla3VYcENmSlhTdzlk?=
 =?utf-8?B?R0hMZlhTTnZkRnVmeUdlbE9tcWVReXR5emV2VGxEeWxYWHRWNUZuTkhRblVu?=
 =?utf-8?B?UHJnREVveXFUbmdvWXhmUGVJOWJGcUtWci9UN081MU1tVGNjV1FuT3IxWkdM?=
 =?utf-8?B?RHF5eWxDMW5HMGhnNmNYK3hLQmQrRC82YlpYeVVEbExsWXlROEpvanZlWEZJ?=
 =?utf-8?B?ZjFRdmNsSmZpR2F5dHJQcnNmS3BiQ3YwWkdMWjZ5QTlzazhpeklCeTlzSFBL?=
 =?utf-8?B?b290cmhtZDdueE1nSHAzSEl0R3AvUEhHcXBsZTRLbE01QmhjRGRUVHNoRkk2?=
 =?utf-8?B?VnNRSHVmZmZjZFR1cmFxeXIwcXYrSDhyZ2grWEd6RWNVV2NUNHpvbHQrVlJi?=
 =?utf-8?B?S1IxVUp6d1dUVHMvUG5aYmIwWWlySERrYWFENTJQSUJGTFJNYzFJVVpVRzV2?=
 =?utf-8?B?TFdER0FDbEJqUnZwcmYrNEJsZnA5UjJZZEV3WVUwRzNPeUN6b1YvNHlMVEJ2?=
 =?utf-8?B?bWRmYTgwQm1DRkRBc3VOOUM4QklHUmEyUVRQUFpQMUVHOTFtaTVJR1hQWFpu?=
 =?utf-8?B?dVRWM1REY0hsTXl5RGxwZS9FWTN3MDdIMlY0TGZ1M0pCTkcxSHdrZ3FiVjgz?=
 =?utf-8?B?K09jTzBZUUg2YzdDR2hMYTJmN3pNWXNscXlQWHkyYk5kaGc0MTR4ZklYMnpt?=
 =?utf-8?B?R3FPcUtlc2lLWVc5Vng3dkZRWWlEd0FSK2MveGYrbUhkMGQrN2NrUDMvRzhj?=
 =?utf-8?B?QXk0VXpQcVlsRHhZOGtOQ2RnbzEzSlNXNkszcmRwaXBNUzdwVGZOdHJoZlBF?=
 =?utf-8?B?REl1VHZtZDQ2bUdVSUZIVkpobWIvVnBxZFBMOWpRUUlOS0I5YkwzY21UZWJa?=
 =?utf-8?B?UE11RXFGMmFTZTlTNTZGMW96NDJsNy95OWlaYjBHUlE5RTQzRHFjSjdSbXVl?=
 =?utf-8?B?TS9hZVFzN25nUDVjVngvenBFek1tejNxK1h0VEhWclNsZGx2bWFGQWpEM3FT?=
 =?utf-8?Q?M7RYXMfSjhg8JOPn4/OJXreRv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c476a1ee-caf3-4842-b399-08daad14f5fe
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:17:56.6595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nc+iqkEywo8/GyV39rUhJ7HGIHUb0vjiouoxvbx5gNa0mV1H/BU/F0peUZktgoVddcTmel/P8Om44Nb3XCAafg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9356

On 13.10.2022 14:03, Roger Pau Monné wrote:
> On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote:
>> From: Peter Zijlstra <peterz@infradead.org>
>>
>> Having IBRS enabled while the SMT sibling is idle unnecessarily slows
>> down the running sibling. OTOH, disabling IBRS around idle takes two
>> MSR writes, which will increase the idle latency.
>>
>> Therefore, only disable IBRS around deeper idle states. Shallow idle
>> states are bounded by the tick in duration, since NOHZ is not allowed
>> for them by virtue of their short target residency.
>>
>> Only do this for mwait-driven idle, since that keeps interrupts disabled
>> across idle, which makes disabling IBRS vs IRQ-entry a non-issue.
>>
>> Note: C6 is a random threshold, most importantly C1 probably shouldn't
>> disable IBRS, benchmarking needed.
>>
>> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>> Signed-off-by: Borislav Petkov <bp@suse.de>
>> Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
>> Signed-off-by: Borislav Petkov <bp@suse.de>
>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf5835bcdb96
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

> One unrelated comment below.
> [...]
>> @@ -932,8 +939,6 @@ static void cf_check mwait_idle(void)
>>  			pm_idle_save();
>>  		else
>>  		{
>> -			struct cpu_info *info = get_cpu_info();
>> -
>>  			spec_ctrl_enter_idle(info);
>>  			safe_halt();
>>  			spec_ctrl_exit_idle(info);
> 
> Do we need to disable speculation just for the hlt if there's no
> C state change?
> 
> It would seem to me like the MSR writes could add a lot of latency
> when there's no C state change.

HLT enters (at least) C1, so is a C-state change to me as well. Plus
we may remain there for a while, and during that time we'd like to
not unduly impact the other thread.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:20:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:20:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421948.667672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixCK-0000Ci-KQ; Thu, 13 Oct 2022 12:20:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421948.667672; Thu, 13 Oct 2022 12:20:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixCK-0000Cb-Hl; Thu, 13 Oct 2022 12:20:24 +0000
Received: by outflank-mailman (input) for mailman id 421948;
 Thu, 13 Oct 2022 12:20:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oixCJ-0000CQ-Du
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:20:23 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2050.outbound.protection.outlook.com [40.107.247.50])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d48f1f8-4af1-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 14:20:03 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9356.eurprd04.prod.outlook.com (2603:10a6:10:36a::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:20:20 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 12:20:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d48f1f8-4af1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K04w2s3lLrr7N7Uxk3TUtbpWrT6od+6WUDes995j17tdVhd+YUr2Q5l36dyp3wTg7iMHKpRcvr16XGEmIMOX3L05oaOfV/ktUxFCW0Ffo4uMondgEP1zABmb2jV3GnifrbI3NIxfNN7TBOcudsUoSPWKpFuHQlJw47IABMx4Y0kxNKePQNBjQe++Y8XtRo1kiGOgf12NMqigm6OAMNLp3KhS85fjFZIIoDwu1232cvV9H6jM28UWBWRnutSvNaF++PVTU4eLPW5xJT6OUEIxeH8a62XqnnaE0p8mJIJ9KbsYB6r8eFb+3it2vmr/qxmIwP28rYe+BicPyD76CjDsaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8kEJl75AvkSMZCQz7ztX9awwOVBs46NebKrGHcye7XE=;
 b=mg4szHsBMi+6wzRnqoDUEELFRkYPw/oNDhVHMzPWSx6DYrlJ4BzhYYlHXI3270VSmgJBInih9YgOOy293nuKza/S2AKLDB52AjRc0T0RbBnlYSWmoxt7cu7c2qZvVejFDP+ocdf4lPoEf+ObbOkVUeOn4Xs2J/TAGdHwA5Zvd5ZAgk3CkDam4l/RV4+ni0dgWCyZWfovR8AZDJbXtsqqvPhJTLYuLov7EIISD0NOknFJTKEitZ57/xZLMb6wq2ZcXx34Cjy7wRdkQJQNTwnmXsqjmmrfnO9yY/4c/qYb7wiyaXYTW20+neaZcVsgT/w968AdHrvxHizx3w0gUX2fAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8kEJl75AvkSMZCQz7ztX9awwOVBs46NebKrGHcye7XE=;
 b=j0LbnMO0h8HKqByRtOBE22G50nT1NEv9csKDh7+VUQNBM7FS5cVEXhTKCqCHb2ToK3R8hwFkd5ujEJyxhu44g0f7sD4GNfHau2YKV6bC5lXUdIRIEd3HQ7qloA1dj6AqiHcoHgs+PBwWd6xNogHi/L3+A+ljqmN0M3paXiWIFwulgnhWsrrHeHzkQkaH6dD0+PPtzWrqCOlIDVci+jEoPItoGx2JVtOeT0tvV5fZk9QnkmfgQaB8Z60e7JvVJON7Ot9h3HjXM8VYex31cbicL5AGGLwah3ZAoatnNy49vKl3HpOoIhTJxoOgvcf1xmzSoMjhfKYE6g2ZhMY6JdSyMw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fd359087-05cb-a50a-8d15-501a096d30d0@suse.com>
Date: Thu, 13 Oct 2022 14:20:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v3 5/5] x86/mwait-idle: make SPR C1 and C1E be independent
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <3bdae38c-1dd4-558e-64a7-886b9bcf771f@suse.com>
 <Y0f+7pZWOzGD70Gl@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0f+7pZWOzGD70Gl@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0099.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9356:EE_
X-MS-Office365-Filtering-Correlation-Id: 15ab9bf1-4a9c-46a0-8747-08daad154bcf
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	le2m+ixbTSgSarNmjEiTfgRkn53Yeyh6RPEcXAxyL8UvQh7+Y6+SBc/yUiYJvaVxG0U5q+VmaNV7dflfZrk0OekRzV5gwAavmg1dqmJiuYFtmWblftqjoLS3j5S3FVIuBESj9JWY452RldULrpBPwiy+TmGf7Edt504B38xAdgnb7uBYMk2r6dHcqq2ayjZO5Sj0RC1D90pJnS74Kl6mIKzrOBr/RBBR2fY4yNxyesdQDw0c/ZtERLN2PU6Af1xwiq2Y6QJRoyjM6p/TmlJZ53TXt49Qcpljopoa8/OxfzSteknQkP6r+v3Z5lckiLXEcGZpuQ2RI9g7trjgkUc/SMl4YyaltnINu2LWXZ5FO6ev+0IShjV7a8817KDucnG9+bGX3UKdCgYpceilqlYYeF0VOBjDQLFQ4/eV6LeL72DaNo28WIqQDbQOFgq85I501NQUJpBx3/ORry9ilGSB/pJSkIce8F6y4rz51vBMx75i7z7S52NzbdUVEj8e6/rSsdsDChuewGu9GvRhsBPPsMu6cE/C3TkT5MFBGVflt/FVfICWo9RPX/Ls7TeIDPyEeOaOgQnffeCIUig0ik0E1QFgTWizACIkvbthWjQafs0CNYoUGm9wlXeXNsCjpT5jpPRve7CGEvKBRZNcOcZ2xM9gsq/CTAQ4ZucXogDGkvF6PfBrX0IHl6IcvTR9yAAsPRqwykQefTXiuT/8RxbjwtZNcRf+VCHvmpueH4tjgUZlAdjS98lxebUuTQvBNEYJsvEDZIVhQB6Y5zArPB6VKSHa5Oz5WKvg64Dh/0N2Cu8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199015)(31686004)(8676002)(41300700001)(4326008)(66476007)(66556008)(66946007)(38100700002)(83380400001)(86362001)(316002)(6916009)(36756003)(31696002)(5660300002)(8936002)(54906003)(2906002)(186003)(6486002)(2616005)(53546011)(6506007)(6512007)(478600001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0h2UjZPSElQbDhaK2RBK1RJR3Fqa0VYNUFCVGVZRExWWkM4WnlQRGNzUmYx?=
 =?utf-8?B?cTI1L3E0VWNJa2xkc2FiU2lvWnpPYVlLUW94T1pZalNWWkdUZlY5NitheVlT?=
 =?utf-8?B?UEtDanNsQnhrS1RoMlBLLytiM2o0SEVaSmV1RlNRNEtTcmNpQXV2aG8wMGVa?=
 =?utf-8?B?dS8yQ3RieEY5MXlFdzhzdXR4U3VpbHc1MU0xdFVVL3lYVStoL0prQ20zMHNE?=
 =?utf-8?B?S3hyOE1TQkdTazZxUzkrMFdaZmpKN2lFRFZjNXAxdlZnaEVKL0FHak0zOU82?=
 =?utf-8?B?S0RUT3hZRnMzV0V2QmJjZTlMaE0zczBNZUtmMGpqMDczOGwzNkFxUEdSZ3M2?=
 =?utf-8?B?MStFaGdYSXJiRmdTUS9ZV1NLbGpoV2pVdW9URTlsUVdZc3luNFJvL3ZIcm1p?=
 =?utf-8?B?c2VXSWJ5Y3dXQ3hrbTNqUVVnYWJjR2g5U0RPSXd3N3NacXM5Sm8vMTdrd09v?=
 =?utf-8?B?UmUyRllVdnVnWVM4eFBKQi9DWWxCS2dIQnkyb29oQjZLQjVQVVN2TTZ3R2xw?=
 =?utf-8?B?UlpPb3pId2s5bUVOYXdUMS9HanpJdHFTaS9PNnExKzhEQTMrTUVUK0lCQTNK?=
 =?utf-8?B?eUJKb29PS3pmclJuK2gxMmtwdHNyWU41Q2ZnRzVjZ0pLUlRsOGFQTUhWdnZX?=
 =?utf-8?B?dGxmRWlUaFNnRElyVTh2T3Nqa255RlQrd0VpQUwzSmNUQTBtMWM0VFlob0hO?=
 =?utf-8?B?YTNjSldGTUdLZ3BTRVowS05nSCtKWXl3c1dTQlcycnRmci9RWWdpc2g1MW40?=
 =?utf-8?B?blVqMWlFdllWUGhVd2ZxZzVjOUpTN3ZlM1EvdktZVGt2bitqL2pTbVpVdzVU?=
 =?utf-8?B?amU0QVVSWUlWeGdNR2xCSS96NDF1dHVWbVFpcW9mTG9GQzBpR215QS83OUgz?=
 =?utf-8?B?VzVDZjRRY054RXVjd3lEd1lkcTliRy82NVE5dFhTNUxNbGRQR0l3ajRueDZ3?=
 =?utf-8?B?VWVNUGVIUVJ2S1Z5YXlnM2U4NUp2c1dQMmk5bzZKNTBBdFlSR0lsd1NsT1A3?=
 =?utf-8?B?SVF4cEdtaWhoNEtPM1RKc1lNenNnOTZlYmJVK0V6YmFsbyt0UElBZTlxbk12?=
 =?utf-8?B?U2xXYXVQNEk5bmpKN0RQZFhhUXNmcUNiQWt2V3BheVlwdHJrci8yaUxYeFR1?=
 =?utf-8?B?ajFpSFlMdjVvQ3p5N3ZxdGx6WUVDbXdwZEorc3RDOU41SUtDVDBHNW4zbjcr?=
 =?utf-8?B?cUtOV3Z1WTJGSWViMEFxY3RxME01cUJHUm5SbnFMQmxLWmhOdWhEVHpxRmJz?=
 =?utf-8?B?dWc3NkNDSEorai95cWRXK2NSNTRhaDVvTEdmUkdFS1pFVkJzWDNMblFnVG1r?=
 =?utf-8?B?Y2JrSnRoVzE5Zm1YUDZxK3o0U1R4VFZ2TXB5MnEzVTlsMEpBMVM5Y2xwbGcr?=
 =?utf-8?B?MTFxRCtJSnJHWGZ0TElsRzNyVGFWcmJUeDJVVkFaV0hJcWdrWnF1dGZuV1Jo?=
 =?utf-8?B?SWlEUmlNUlBwR1VrNUhWV1BKa01RejBQL1BIeENoQTVNYndYMUlsckxTZ0Iy?=
 =?utf-8?B?YlI1L0FUTk5nTHo2M0ppOGs1SGJrR3hDL0tjQ2ZaZUhwNVhtWko1U3c0N0lX?=
 =?utf-8?B?MER6UEZnK2lJamc5RVMwQUc4MSs4ejAzeFcrRlBZbHpIS05HVVUvNlREeVVD?=
 =?utf-8?B?QjI3T1FrRWIvemx5OGhMS0ZIajJCWWJTOXpRZm1YZjk5bVRYUXl5Mml4VVow?=
 =?utf-8?B?SlloTW96czcvcEZmVEY3NFR1L1JNSXB0ZFNTREpCYnVaK3ArTE00cFJpMldk?=
 =?utf-8?B?eERYSWNOQU5xaEQ4NWQ2V1dHdUFzeld2UnlmU0Y1U1ZkUy9RclhMczVnVEtC?=
 =?utf-8?B?U0YzVXAwUXFCZDV1L1BWbVd0bVAzOEdrSDFCRWJzTEJwY0hra2lDd3NneDBl?=
 =?utf-8?B?RWp3MUpiR0NTVWFvQjVEM2JJaWNONlZNZ1hEQXJmd3YxcFhNekpKeUFCeVVp?=
 =?utf-8?B?VXcranlPQ2cxSGFFRVgvMElpSTFHUCtQWEo0ckRQL0lGdlJaNGw3MVFDelpL?=
 =?utf-8?B?UDgrQkVuT2FhNEFsUFVLQTJZcFg3Wjh5RDF4SVJhajM5eTRwQlAyTmgxTGgw?=
 =?utf-8?B?UFhNNVhNdjl1aWRWa0MyTTNjZDZNYnBHdzFsSkZYS1JMMXBXOE96SkU1Tlg4?=
 =?utf-8?Q?zQvOIhti5r4VpM89kQ/ebwuIp?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15ab9bf1-4a9c-46a0-8747-08daad154bcf
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:20:20.5406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RT3eKqNV1Bm85ntlgsz6ePIrAMcMWzA4lNaQ6N0/lzyf913T6p3Ih9H9F4mXftC2hIY7PKeLSFGY6BgvwQSE+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9356

On 13.10.2022 14:05, Roger Pau Monné wrote:
> On Thu, Aug 18, 2022 at 03:05:19PM +0200, Jan Beulich wrote:
>> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>>
>> This patch partially reverts the changes made by the following commit:
>>
>> da0e58c038e6 intel_idle: add 'preferred_cstates' module argument
>>
>> As that commit describes, on early Sapphire Rapids Xeon platforms the C1 and
>> C1E states were mutually exclusive, so that users could only have either C1 and
>> C6, or C1E and C6.
>>
>> However, Intel firmware engineers managed to remove this limitation and make C1
>> and C1E to be completely independent, just like on previous Xeon platforms.
>>
>> Therefore, this patch:
>>  * Removes commentary describing the old, and now non-existing SPR C1E
>>    limitation.
>>  * Marks SPR C1E as available by default.
>>  * Removes the 'preferred_cstates' parameter handling for SPR. Both C1 and
>>    C1E will be available regardless of 'preferred_cstates' value.
>>
>> We expect that all SPR systems are shipping with new firmware, which includes
>> the C1/C1E improvement.
>>
>> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1548fac47a11
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

> I guess we need to be careful of running this on pre-production
> hardware then?

Well, power savings may not be as expected there, but beyond that I don't
think there would be much of an observable effect.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:26:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:26:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421954.667683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixHh-0000wv-98; Thu, 13 Oct 2022 12:25:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421954.667683; Thu, 13 Oct 2022 12:25:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixHh-0000wo-6I; Thu, 13 Oct 2022 12:25:57 +0000
Received: by outflank-mailman (input) for mailman id 421954;
 Thu, 13 Oct 2022 12:25:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oixHg-0000wi-I8
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:25:56 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2f2b592a-4af2-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 14:25:55 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8726.eurprd04.prod.outlook.com (2603:10a6:10:2dd::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 12:25:53 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 12:25:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f2b592a-4af2-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WKy7JFFYEBzRohL8f1rQjctU7wOHdv0Rm4NPhvdS6o9ZSNOavyG1orNTZLwfyWMOm6/2ysI8sL+dRAboW23Mu1WOLoaISBOP6+rECx5lLRk/FFOgABcXLbw8NHmtK+jlXfVJZHsqlaGlmk1cHKb740Ourd2gg3meYOENLReO0RRzMGocs9/tC6NfBEejlPrbYmdXGgjtXR/835gDZjVwWYlWbc1RIRcb9GAtKLUERgXUmDmjpBQDx11EdC5i3g3oDgSZRIM3vaH3gYRBvJ6as9LPtxNCIqse2zIg/JI7ZMyTQ6cJDaXHMDsmv++I6bnvasUnFCAxbOk5Ml/N79rYgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vPgNO8OYVwOz7v9x2ZIMijaOw8Llamy2RUbiOwJhtBY=;
 b=Cqhjg6ic4OBkggWfm9KfJLGzB/OdgXh2gEysB62cJ51i15UY0hZo3wPOx9j/FGvoS2vLRNOlr7EtMddKAAJiNhiathc96tVW1yReZy6OLHCMk4Qmi1ZBGW7J7Z1kaTPvV9wnIa429PHAd5jUs0450bhD7fZn4Kf5NS8thTqbA3xBfFYVxxhUfdPbMYSTPcEv7Cng7Z5OU5RbYmU7nkTEXKZja5JXWG0s4Qexxp1XGFTF23SNlNg0AVwmisLp6LVcdavYTJaW5H0lq+M7HhTu0NSgzwWxZ5ZskaQwGuVEpHycnuub8Kq4bLbN4IdM0YKSPkp2e/2bErfXxdgfzrEmLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vPgNO8OYVwOz7v9x2ZIMijaOw8Llamy2RUbiOwJhtBY=;
 b=thAQMEF0FiYHUx66iyrYQEzzDcM4LYwwB9FQv8J1sMtVmvQqTwKaVGLFW+YJGreWptKARAtY5pILoXEjXzxQfrl2nUPGu5lsvxg7/26szvxcMY3WiNBOmGDmD67Cd/+JCkGS7NyILayLqES1aNujm5BCa3sO0D233ft5Bo93fvGAnh6MOi27cnUN3xZSX3r3CtrBdI0mIahcvkwc/RC4Q7bj86C9LFRJVWX6jUB5C2/v/2Z3Ry9q4YiHCQMls0rybRMdNtz8RYNSO94SuN6OHlCe8dedxxF1KnXY5/0j3cemQF1n6saoMHgBqC8q7uSKVlxn6RKp5TCGe9INZJUlIg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1f8fd1b4-e84b-a211-eaef-c0abe9c0056d@suse.com>
Date: Thu, 13 Oct 2022 14:25:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: [4.17?] Re: [PATCH v3 0/5] x86/mwait-idle: (remaining) SPR + (new)
 ADL support
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Henry Wang <Henry.Wang@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
In-Reply-To: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0202CA0009.eurprd02.prod.outlook.com
 (2603:10a6:203:69::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8726:EE_
X-MS-Office365-Filtering-Correlation-Id: efcefc27-11cf-4cfc-53e3-08daad16125b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hlLQ6dVFQPOqrMka/jWopRhTfJG9qdUwvtSKzXB7EvzRzNJ2AkqxlbeGV01a2BOr8ca69TZMxWn8QhuN2jKbDmKrBrJI5NYJ3qnrcFQ3LqaCN7kh/cW2ZqooUcX/KJAUjRtRlXnO0rcxk7OO2ZniYtlILR/nK87Rbi/LLMEXau4D2KNyxqAuG2W6w0CkdOflMjyLIg0tQUJ4xyNgVlnSUZXUY0+w5lqyLx7FbQNLuvpHqaBrxXqiPruwwttFBuHVEPEajcK2otvBRGzWB3VcXbv9DrIdWBiKIz6z5/kUEbmJrv39anT5Gw5b0XVJflWeNdMny7G/T7etYLCIKZMn77EEO8/+iDul4OiByD9XRmx6/sWxZttN2GGaf3nzdRkdmgqYqLjDf6k1IkWY6R29LEqR6aKKsmXNylb4Rd5BJX9FyRGUQ1h2QrzjZ+0Tk7Vd8T8kIhkiPhzv8UPa7GBoTdzFma3kGCnMKxPwyWHGx8vXXVt/FbX4zAblfWAkLP0gCUF4yXSw2RfW95/HDLXJ8Y5DXUECkDzW2T8VNa68c0Js8iK8lCtt+TzbjuKieUqQdWfuwZ6SNpnVhre/P4Gk7338IXExTQNhtdQJ60DUpFTGxLMp8hvhMVRKNMiTg/oNrthF8TzQ7C15079QKFi2M/GxMMPp9yatqD2SrZj+NWaMXrJtQSoMD+Y5JPoo68tIkytRA7uUaO2s4Q3KNNSn4hPU3zWnRhiMNAv616rYbHuyYmu743qX9iOkiFQ/SUT1BiQtqRUNbhscf+2zj0kC0DksvXFaASNSEWgLojC8Qj0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199015)(83380400001)(2616005)(31686004)(2906002)(36756003)(86362001)(8676002)(4326008)(53546011)(6506007)(41300700001)(38100700002)(54906003)(478600001)(5660300002)(186003)(6486002)(26005)(6512007)(6916009)(8936002)(31696002)(4744005)(66946007)(66476007)(316002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bE5tN1pDSWV6SDhlTkNYOE5DV250TitwL09LajBoN2FXLzZya1lDeG5tUzV1?=
 =?utf-8?B?RGtDTUl6NVBFZUxrOGx6TkVhamFmNkw0Ym0wcEdaYndLeVRQclk3azNYaHhV?=
 =?utf-8?B?c3VhNlp3V1Z6bVVva0ovNnZTQm0rZnRMcjhqMHJIK2wyOTJGSkJRY3prOEZw?=
 =?utf-8?B?TFF0aXBBSUpoMm1EUTdDZWlHWjFvOFRFaXN6eWxVRkJOeWh0UGlkK0lWUjh6?=
 =?utf-8?B?K2lpeFh0dzhLRnlVbjN2UjljQ2RkaW54cWJ4UEZ1RjZKQ1VFdlRmZGw2bzhE?=
 =?utf-8?B?VzFodTBQN3QwMW5sQmRnWDBta2E1VXVQcENlRXdlVkd1eUxHQXIvK1ZsRXpI?=
 =?utf-8?B?U01PWG9Nb0d6ckJ0bVhWSGpCbTcxNGdVUTg0VGZiMHNKc2tJNlRSTkh5R2NY?=
 =?utf-8?B?Y0R4UmJDWHlwb1hEdko1b0x6bFZURUpHMEdnMlpIL3FjRkpEaVlFYkpzSzFj?=
 =?utf-8?B?QXp5VFJmRVBtSmpiYTV0WUlxVGE5b0sxVnJGS21FT1lSazI0TUxLWEVGK3lj?=
 =?utf-8?B?MEw1VXdsQmI1NVhHb293NHNQektpbXJSMjAxdjFLcHdqSmxpeDVZVnRQamFJ?=
 =?utf-8?B?V3c1SkZuMHVNdEZ1SjU1SUJkQUN0L25OZnNPc3NoV0kyT3pqL1lDN2tUY202?=
 =?utf-8?B?UE1TS24xMGpOZjhSZndkbFlwbUY0czdoZVNtMFQ0L2laSmoydk9vWGozNDBW?=
 =?utf-8?B?Q1Y0YkdQcjN4Q0RDVmNFbHpVRjlrdFV1dzNDbXBWdWpGWTZqTlZQc1pKbGJm?=
 =?utf-8?B?bUoya2JKVEhkalFYZmhQaW5UNU1hc05WN2ZhYlNqbzhvY3VjR2ZuRCtyaE5p?=
 =?utf-8?B?ekw0RVp0eGErQ2hURGVOdE85eFBqa3VqeFljdTQ1TzIrRTcyTm5NMTluMEMz?=
 =?utf-8?B?UnNxL2k2a0Nka3JYNEdrNTFMb0RLUzNOV2dINHNTbndJQzFHd016SEtLR1pH?=
 =?utf-8?B?VFB5OHVqdHpMeDNwbVBEQ0VhVTY2V0ExRkRwN0dKbk1HM3BqOTF4RGRGeFcz?=
 =?utf-8?B?T01IaEh4eVhQaWIvc3B4S1o2cDdUU1F2V1dkREpybWxveGVMNmxMSUxOekNS?=
 =?utf-8?B?K0pXUzBjZWxyNDZFdDZYVFZCWG9qY0d2WldmTUJmOE9WZ0xteHp4V3FkN1NR?=
 =?utf-8?B?dlQvOXYzRkRseTIvUTF4UE1SRGswaGtGeE95QktkQ1NKa2U1Ymw2WFJqeENI?=
 =?utf-8?B?SW5DZ3JaUkswM3duL1JCU09QRUN2U0s1Ym0xYVFFVUc1OXM5cnRLUDVSRGNM?=
 =?utf-8?B?MldiYmd4VkR4d2FBMFdwaml0UitlZ2J6SjlROE11SmtYOTAwNzhCQmdMa3ZB?=
 =?utf-8?B?ZTRqRkNjU21RR3NTYW1kQ01ZazcrMTNWRVFIMENBcUNzQ0xFY0NTYUV1QnNs?=
 =?utf-8?B?Z1A5eUxFY3VpMlYvWjJWakEwYUN2OEJNQUdwYzlVU3lXSEdJL2JLLzhweG5G?=
 =?utf-8?B?TXNueHFqYVYyRmgwN2F5SDNyMDJwRHlXbzE5NXluVkNsNEVrZEl6cDJwRFlv?=
 =?utf-8?B?SVRKNW1lVkpocnc2eUNlOEx2VnJtbjFaR0R2NnpDRktJUFVIWTFRWmlPeklz?=
 =?utf-8?B?QlJuOTJVYVc5QkM5c0F5WW5GL3JISW1nbXhObXcvVEpiTDNLZTU2MHlLM21o?=
 =?utf-8?B?cCtGelZNMmhKcUVQT01mSktxZ25zNkxOSUVjcmovcU1HN2NnTVpUZFFicmFP?=
 =?utf-8?B?eFJtRE9CN0lMTkpnQW1jbmRsSHA3WU5GSDJvMmdnOTFLM1kxZ2V4VmM0S21Q?=
 =?utf-8?B?aVZrNk8zWlhHd25HeW5TVzRZL1piOVpYUmZmdXBhWmFpbDNQR1VRU1owT1gw?=
 =?utf-8?B?YzZvSmU5N2ptNEpVV3pCL0xKL0lTT1FlYUdhZnpmR2VkUUJRTmZxbGMxMkdz?=
 =?utf-8?B?UzZhMGtKUFNXd0YrVzg2WWdqcjllTWZNZGJxcHRFamtjdW9OQ1JYZ3V4ZExj?=
 =?utf-8?B?SFFsQlZMdFdUR291UUVzRnJzcmdiR3poL2w4aDRmbTVUUEpSdnZKcUxTbG9n?=
 =?utf-8?B?cHZTb1JuRXNFa0FDZ1A3Q3dGajJGRkdwUFYzbkYwOS8veHFWMmlkdGZnVmQy?=
 =?utf-8?B?eE9FRWo5UXI5Uis5VHhobHU5eWF0ek93L1Y2b2FIY1cxNUpvc0xvUiswYzZh?=
 =?utf-8?Q?9f0KQEqZyBHLZyDZkouB7wqk9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efcefc27-11cf-4cfc-53e3-08daad16125b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:25:53.6769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XEuy3vWicyXRQb0hQV2K23rv8tM1ZOTQKqeL4wlyRwgaLT8+rbcxcLQhuQeBeVRXxR/7oo4i60ZQrvNXl5gUOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8726

Henry,

On 18.08.2022 15:02, Jan Beulich wrote:
> New changes have appeared in the meantime, in particular one partly undoing
> what we still haven't merged (patch 1 here).
> 
> 1: add 'preferred_cstates' module argument
> 2: add core C6 optimization for SPR
> 3: add AlderLake support
> 4: disable IBRS during long idle
> 5: make SPR C1 and C1E be independent

just now acks have completed coming in for this series of ports of earlier
Linux commits. This all targets newer hardware which of course we'd like
to properly support with 4.17. Unfortunately the series was kind of lost
with all the security work which had been ongoing. Therefore I'd like to
ask (in part also motivated by Andrew to do so) that you consider still
allowing in this series. In the (I think) not very likely case of problems
(first and foremost because of the changes coming from Linux, rather than
being homegrown) people always have the option of simply turning off the
use of this driver on their systems.

Thanks, Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:30:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:30:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421961.667695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixLm-0002PG-UD; Thu, 13 Oct 2022 12:30:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421961.667695; Thu, 13 Oct 2022 12:30:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixLm-0002P9-RI; Thu, 13 Oct 2022 12:30:10 +0000
Received: by outflank-mailman (input) for mailman id 421961;
 Thu, 13 Oct 2022 12:30:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oixLl-0002P3-W5
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:30:10 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2071.outbound.protection.outlook.com [40.107.104.71])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba2b59aa-4af2-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 14:29:48 +0200 (CEST)
Received: from AM7PR03CA0029.eurprd03.prod.outlook.com (2603:10a6:20b:130::39)
 by AS4PR08MB7429.eurprd08.prod.outlook.com (2603:10a6:20b:4e1::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:30:03 +0000
Received: from AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::70) by AM7PR03CA0029.outlook.office365.com
 (2603:10a6:20b:130::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Thu, 13 Oct 2022 12:30:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT058.mail.protection.outlook.com (100.127.140.247) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 12:30:03 +0000
Received: ("Tessian outbound 937eed45f6ed:v128");
 Thu, 13 Oct 2022 12:30:03 +0000
Received: from c9f94786ab37.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D6B214FC-FB90-48E0-8E23-C194D2F6CCA8.1; 
 Thu, 13 Oct 2022 12:29:57 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c9f94786ab37.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 12:29:57 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DBBPR08MB6249.eurprd08.prod.outlook.com (2603:10a6:10:203::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:29:54 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 12:29:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba2b59aa-4af2-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=UeNV6aHXJr1+nh6w9Mx5jsCk8enV/kZ3zgRnwGFaOYCdpmHcw4dy9cnfRFvxST7+kDdXeGdFJISP2Q8tD7I8foxXDsvvcmZ/yq0tJwjNUHuWcVclp7tGSDYaoyU5rGFn/NNtD/57SkUaSNZ3a0ldIspOTzcTHl6/nb6DwOj3b/e111UirUY5VfD/XLbR2wtKfK5jzLtECOWZ9sRO+ZHZRLC6cSzi20tedVaoZdVbc5vhjsGQ/va/B7IoE0VRe8lcomCnJk/PXcYxm9JIJXDtfdb86e99yZ4mnPC+dqcMaRfX0IC8WyVvDi4CaimfctqFJvjT0yWEvJvgjQTHizdGGA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=80VGvy7d2kxHrODTWZaQh4wvixCx3KfWxSemWDn8P/0=;
 b=X17SHu67VXPj14REDad1XpjQj+vKFzkhe78zAZc53G7Lx5wwvJ1CYEgqiJ19kgAcCmn448Xr/qR/5hFJnhDFKk9aw/vET3ZH6DK5vU7dBuFp7rIadVF50R4iM6Y0dw7oGli30vCMO6dhTYjK9Pyo9CmxS38mqnlnD+f2aymz9Qy2DrsYhEdEMMJbyZ8JDoDUVZUXrvo5JFzuGpAr+G0T4jnwFKh9ODXk5QWKRqN4V95tr8COqQmGrS8TNIc3/1XQBouqBZSk17dPhb5uageoncCGm82MuJZTmQT2kjb1g4DmiPy2mz4HYHVCV8kkPyLKWSkvl3QrtwZrymVtShHNqQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=80VGvy7d2kxHrODTWZaQh4wvixCx3KfWxSemWDn8P/0=;
 b=uVfT2zLnvaWyv5ngfA4QoURrtJuKfiwfBWO71ApFVTSgFL7t19l63GceVADdv1/UrXYprNVc/N46W0jWHDTrRbSCFDg71T+Le6jNyHRkSFJrOUuj0gJhjKfMfkVJKIauCKTXqb5ZGQs0joOdYpGRw41VwVCb5PoLt3xGY2KN7mQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FKHarzTbXSia/GmErKImzCzge8ko6rssMu3LkhL3cuxPw2kWSX6R4hAi0PmWlW6K7fmBaPt1o1iiuHLaZ/ZT/YX0ttvO5YxUoMbn1clbTqUyOpQqi1RVrBvt8i8TwMBJs/MCYrpv4OSMLuowKO++6lC8vZRMsCXWJrBMpoqWscJzqacG6siDaMxp1gVTiDloEA6VL8Q7Z1IYJcCZ1Hwh12WdzExwaNLiw53Lcv9K2l92e0YPObPq+NhhWjfQhldx5RrKv2jZyrGSBNd2iGGJpI8xUAD50aGebP0x2k8DbG+CbL0AiT0M1eLkvF5JqICK8CkLb9LRB+3Rm19n674u/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=80VGvy7d2kxHrODTWZaQh4wvixCx3KfWxSemWDn8P/0=;
 b=VZNdIzrCRM6aphUIWs3U3LT242zltMvqYLuhnmLzObZYRvEcdjC/hH4emYH17T127/SBkVItioQHibYMq15j2AXzd8pAK0N2WyNRfz2oMaPcq+A626qk8xZbnrxpQGYL7OOMAfZ+0+RWuLg6V6dXLW5KgPv9xO5JZ39NVanzIo97pV7191czvaw4arjygN1YWLDw8CqWF+Q+Dn5nXAJmwNA5F0bMSAAMkenD5I+g1MIbQNn14hwRA7OiYM43j9r+RZqb2zhcr1Oxfb72Q90DwHNY52WKeis7rcq68dnvzVjYMgdiSaoyaWP/MHggV5h8hd07jrDXzmT94xNd7P7wCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=80VGvy7d2kxHrODTWZaQh4wvixCx3KfWxSemWDn8P/0=;
 b=uVfT2zLnvaWyv5ngfA4QoURrtJuKfiwfBWO71ApFVTSgFL7t19l63GceVADdv1/UrXYprNVc/N46W0jWHDTrRbSCFDg71T+Le6jNyHRkSFJrOUuj0gJhjKfMfkVJKIauCKTXqb5ZGQs0joOdYpGRw41VwVCb5PoLt3xGY2KN7mQ=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
Subject: RE: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index:
 AQHY3t81xdeRddBbSEGLoF20gErPe64MCngAgAAAYwCAABzHgIAAAcyAgAAAK9CAAAi5AIAADecg
Date: Thu, 13 Oct 2022 12:29:54 +0000
Message-ID:
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
In-Reply-To: <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F6B749C9B5090A49AF7D9A5FA2D4AC6F.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DBBPR08MB6249:EE_|AM7EUR03FT058:EE_|AS4PR08MB7429:EE_
X-MS-Office365-Filtering-Correlation-Id: 8f623462-e94b-4582-d0d4-08daad16a739
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RgFBwPCZ2gBeteaFXn30cbf940bJfklTAwlBQ3aPi1kqoijN+U65c2glneDgNaUgBMR0/NfpEqZ4Zg+uAPsdYUj3qktWwHPTJXlLal9mAgwfoZk36QSW/a89pRr9k8gXHN2P11WBVhXy7SBfv7kUeXKGCn5NBNVUiO4puavcOnRkZwjBmUVmKW/qJqxt9hn2PACPb7HgpxMj9fzEkrSvXMb61biy0MEmZxP+p9SyrsVL/nea9uoe1+US90Jh3mOcf09sT6MCaFYFK3uEt/E9gfhNI4FSMQln80u2ApkGTt8jUAfcllvDuIr1qCuRFA2zqDVEVZA9IbZShcsrU5638X2Otu4JFlpl1XXP/GGdJK+yXKsc8MmYd+sWjDDiHTxZvQV5DOjCvq7Ldn4Cposm6LyrAWVIWnr6VFv0ZB9+Z+bfUQeU6uIErfPoXcJciTnxZbm7KYjyos6i5+CWrCFPwaaAz/ZHFbepbV7K1zM27e4K2etZ4SJHMs4qXh1vL3NuZNkiHC9bpbuLvX1OmFeVW0bSAOgYv1r7sFdGrVlNSkKXmm5ze6BJLFuCYEjbpzkG0623BuaexizPNIglWq4I/cOVPTqXNcJrHBZmH5l4UhV4IKJpNR6VGPUWcXNj0XBWkv9vulxGC4ZhcSWr17MrOgt8qHnenAMwp19YSCIpOQbaKp2Of4Idoh9prBtPvnGlGlQiiwvFTZFKRPSHytjNJUs10dc3uxIrC2TQOGNDtTXh9vABSM7SPKw+ZDCgwTxRw4srbxGSuLEPDra4zlLV4A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199015)(54906003)(6506007)(316002)(38070700005)(71200400001)(8676002)(4326008)(83380400001)(9686003)(7696005)(2906002)(55016003)(26005)(4744005)(41300700001)(38100700002)(6916009)(52536014)(33656002)(8936002)(5660300002)(186003)(64756008)(66446008)(66556008)(66476007)(86362001)(478600001)(66946007)(76116006)(122000001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6249
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	71a403a2-aa20-4952-b078-08daad16a20c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Rv0MfpZ2R7249lHrsmO9k1612O0hCWJ2gd4cgrSoYA99oW6Oz8ZMTewqyWeeSK+E4Odj89GLiAZ3lJE9qEB5MwkFWIstR8CWM2AyjieoITX7f5EHpCpBdp/CTZICaRT37i6xi+BCZi26tLpmNHf86CFEPsn5Rw+WvDTx5aUXRiPds/EANqRK1VbGdxonHC9VDwZDJ1h3CzZLsGYN4ED51coHMCP9KKzYnMnuLAy22HreeKLFvQ6C1D01Z5QGoNyUxvapi0ccOwsoFrUsfIwkPjeOcSldBXNJ++OshFb3wAmbbhijrw8VIL6MxH0b0IxjN01pfBwQp1Zf8qWNv2CuoQQOaZultuTRRMPhoA4oRr9A8EOF5mIMHozsZab6hB7jaBYqr+dIbJhINXoETmZokJ2bxvkVMMYl0ra7irPKQ5rnrL3rmdFM/W+ED7eD64eosKGA7Gd+ysZUTvq2L0RE/rBRTn2A7LtJCWuHjWhahbqaXeuehbu3y2A+MP3fS9IrLWrl6GD+kxb37oEuklAP6X9cIT2whd7jP5WGL8U9YCnrvY8Z3Aflajji1/X/LDBOqwTHHcc9krr3sI2EWz1WX823BONe1yRWtc0Jw7uQCs6OocQHOYQaWNHM8lF+Q8pDLm/IooO+3WupZK1/dQ+SaAy4XP4kLr0edT3jINKuf7mz0J1zjNou+SZRdVDCeWWfPn5X6TMYcqk+6vh1j5bFFHoFqcIx7ys8GBXtCFfuaLIg3PLR57pO5HxBVAKpIT+HFR2APmh+afD4XHFOq9zeYA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(7696005)(9686003)(54906003)(316002)(4326008)(8676002)(82310400005)(356005)(36860700001)(81166007)(82740400003)(41300700001)(70206006)(70586007)(478600001)(6506007)(26005)(4744005)(52536014)(47076005)(336012)(83380400001)(186003)(86362001)(2906002)(5660300002)(8936002)(33656002)(6862004)(40460700003)(55016003)(40480700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:30:03.2191
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f623462-e94b-4582-d0d4-08daad16a739
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7429

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gQXNzdW1pbmcgeW91IGhhdmUgNCAoTikgcGFn
ZSB0YWJsZSBsZXZlbHMsIGlzbid0IGl0IDcgKDEgKyAyICogKE4gLSAxKSk/DQo+ID4+IE9yIGlz
IHRoZSByb290IHRhYmxlIG5vdCB0YWtlbiBmcm9tIHRoZSBwMm0gcG9vbD8NCj4gPg0KPiA+IENv
cnJlY3QsIG9uIGFybSB0aGUgcm9vdCBpcyBub3QgdGFrZW4gZnJvbSB0aGUgcG9vbC4NCj4gDQo+
IElzbid0IHRoYXQgYSAocGVyaGFwcyBqdXN0IG1pbm9yKSBtaXN0YWtlPw0KDQpOb3QgcmVhbGx5
LCBpbiB0aGUgY29kZSByZXZpZXcgcGhhc2UsIHRoZSBxdWVzdGlvbiBvZiB3aGV0aGVyIHdlIGlu
Y2x1ZGUNCnRoZSByb290IGluIHRoZSBwMm0gcG9vbCB3YXMgZGlzY3Vzc2VkIGFuZCB0aGUgY29u
Y2x1c2lvbiBhdCB0aGF0IHRpbWUNCndhcyBub3QgaW5jbHVkaW5nIHRoaXMgcGFnZSBmb3Igbm93
LCBhcyB0aGlzIGlzIHN1cHBvc2VkIHRvIHJlcXVpcmUgYSBsb3QNCm9mIGV4dHJhIHdvcmsvcmVm
YWN0b3IuIFByb2JhYmx5IHRoZXJlIHdpbGwgYmUgYSBzZXJpZXMgZnJvbSBteSBzaWRlIHRvDQph
ZGQgdGhlIHJvb3QgdG8gdGhlIHBvb2wsIGJ1dCBhdCBsZWFzdCBub3Qgbm93Lg0KDQpLaW5kIHJl
Z2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:39:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:39:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421967.667705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixUj-0003CP-QQ; Thu, 13 Oct 2022 12:39:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421967.667705; Thu, 13 Oct 2022 12:39:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixUj-0003CI-Nq; Thu, 13 Oct 2022 12:39:25 +0000
Received: by outflank-mailman (input) for mailman id 421967;
 Thu, 13 Oct 2022 12:39:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oixUh-0003CA-Pr
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:39:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixUd-00073a-Ma; Thu, 13 Oct 2022 12:39:19 +0000
Received: from [15.248.2.148] (helo=[10.24.69.9])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixUd-00069U-Hh; Thu, 13 Oct 2022 12:39:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=eWakhKxC3SXnvMx8Tzw6m9s/73HqJbY1g4SOB5Auz2s=; b=a9Q65JG/xTm4i4yyg6ap+D4cN5
	qFDARU4QWjRTHk27hB7Q4yTmeDCCYJdea1AB9YUIYpRi2KkpgN591/MSoTz/yTxOa/tXprUqBRk4Q
	7MTl9UUnkLZXfLSaOpFk9m/7CMGU9Y9sLTNr6aaf0djPUgt2mHTXKYycmuo07KzCbSiU=;
Message-ID: <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
Date: Thu, 13 Oct 2022 13:39:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 13/10/2022 13:29, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>>>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N - 1))?
>>>> Or is the root table not taken from the p2m pool?
>>>
>>> Correct, on arm the root is not taken from the pool.
>>
>> Isn't that a (perhaps just minor) mistake?
> 
> Not really, in the code review phase, the question of whether we include
> the root in the p2m pool was discussed and the conclusion at that time
> was not including this page for now, as this is supposed to require a lot
> of extra work/refactor. Probably there will be a series from my side to
> add the root to the pool, but at least not now.

The root page tables can be one of multiple concatenated pages (up to 8 
pages). The P2M pool is allocating page by page and therefore wouldn't 
allow us to allocate contiguous pages.

Therefore, we need to handle the root differently. At which point it 
doesn't seem to be worth it to allocate it from the P2M pool.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:43:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:43:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421973.667717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixYH-0004Zx-BF; Thu, 13 Oct 2022 12:43:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421973.667717; Thu, 13 Oct 2022 12:43:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixYH-0004Zq-6n; Thu, 13 Oct 2022 12:43:05 +0000
Received: by outflank-mailman (input) for mailman id 421973;
 Thu, 13 Oct 2022 12:43:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oixYF-0004Zk-B5
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:43:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixYF-00078A-32; Thu, 13 Oct 2022 12:43:03 +0000
Received: from [15.248.2.148] (helo=[10.24.69.9])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixYE-0006Es-UJ; Thu, 13 Oct 2022 12:43:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=Zl6lblYWbiXHkP3SMtuGSxke69bxE+42uQOZFTfd4eY=; b=LxXf/jpzWzQC94WD5mdHUWqcgZ
	Q0C+AGKEKadUmiYLffkI/bywaDSDzSq8Gj1FxZMjsak24IPMu8q/j5epjbUGtNZfDGAgt9/Hdkqv9
	fEr3G2cjQEIvHe3w93p+xp/v5QJzYRgA3lKMyqs5/hsOFtKoED2eaRWxvafu2BwIID/Q=;
Message-ID: <adb0b677-8fd8-1b31-9011-27833da343da@xen.org>
Date: Thu, 13 Oct 2022 13:43:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
From: Julien Grall <julien@xen.org>
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
In-Reply-To: <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Henry,

On 13/10/2022 11:58, Julien Grall wrote:
>>>
>>>> +     * when the domain is created. Considering the worst case for page
>>>> +     * tables and keep a buffer, populate 16 pages to the P2M pages 
>>>> pool
>>> here.
>>>> +     */
>>>> +    if ( (rc = p2m_set_allocation(d, 16, NULL)) != 0 )
>>>> +    {
>>>> +        p2m_set_allocation(d, 0, NULL);
>>>
>>> Shouldn't this be done in p2m_fiinal_teardown() to cover so the pages
>>> will be freed anything after this call will fail (include in the caller
>>> domain_create())?
>>
>> Hmm, yes, I will remove this p2m_set_allocation(d, 0, NULL); in v2.
> 
> Just to clarify, I meant that a call in p2m_final_teardown() *is* 
> missing in p2m_final_teardown() (or wherever we decide to add).
> 
> This would make this one redundant.

While chatting with you on IRC, I realized that a call to 
p2m_set_allocation() will only freed unused P2M pages. If some of them 
are in the P2M then they would be skipped.

This means we also need to call p2m_teardown() (which would need to be 
optionally preemptible).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:46:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421979.667728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixbh-0005I3-Og; Thu, 13 Oct 2022 12:46:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421979.667728; Thu, 13 Oct 2022 12:46:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixbh-0005Hw-Ly; Thu, 13 Oct 2022 12:46:37 +0000
Received: by outflank-mailman (input) for mailman id 421979;
 Thu, 13 Oct 2022 12:46:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oixbh-0005Hm-9I; Thu, 13 Oct 2022 12:46:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oixbh-0007Dz-73; Thu, 13 Oct 2022 12:46:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oixbg-0001NP-PR; Thu, 13 Oct 2022 12:46:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oixbg-0005dn-Ox; Thu, 13 Oct 2022 12:46:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cCPtcVgzWZY9EgvS7kXZ00UHxP+MEHPJm+Uyo4cnnns=; b=bYMUaSq2dP044Q3wh2pXhfL3Uo
	xMflUZBdtvh0DEcNjYamndMYcp3mDZiuBn7s8PakXWPQFFQsKm1YVFN70qjEcRyu5VuQ8J47ZDYQq
	Rf8tlfU2q9POKBKWEYTcGTXmcbqmNbAx8lUCspcBMlNGxtd/nlwaxfONM2ITfobxI0xM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173701-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173701: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=448d28309f1a966bdc850aff1a637e0b79a03e43
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 12:46:36 +0000

flight 173701 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173701/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  448d28309f1a966bdc850aff1a637e0b79a03e43
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    5 days
Failing since        173492  2022-10-11 13:01:50 Z    1 days   11 attempts
Testing same since   173619  2022-10-12 20:07:50 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 446 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:46:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421982.667739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixbm-0005ZW-0o; Thu, 13 Oct 2022 12:46:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421982.667739; Thu, 13 Oct 2022 12:46:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixbl-0005ZP-TX; Thu, 13 Oct 2022 12:46:41 +0000
Received: by outflank-mailman (input) for mailman id 421982;
 Thu, 13 Oct 2022 12:46:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oixbk-0005Yr-M9
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:46:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixbk-0007Eq-8P; Thu, 13 Oct 2022 12:46:40 +0000
Received: from [15.248.2.148] (helo=[10.24.69.9])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixbk-0006YV-12; Thu, 13 Oct 2022 12:46:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7nT95/3FaBYhao44EbQ42lgCinTiuLcbosgyDAzL7vM=; b=5VvJO/sseQzAKqkPtgbtLHhWUH
	xg6ug5ia6asBIkluG7bvqwcp+hUiS57kfj7nrY56E6+wJxwHVA04g7A/f3EY99tCJ0GGR8aLrdIkl
	j4xtEERQIKW28pVrWR8RkORebCsGc2r6ACI0LbxqK4sMqUBlCX7fIlImeR/IBTt/wm1Q=;
Message-ID: <63f5ab77-de4e-7a42-9942-832d8f891a53@xen.org>
Date: Thu, 13 Oct 2022 13:46:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, Andrew Cooper
 <Andrew.Cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
 <AS8PR08MB7991FF3E7EEA46F11ED4376092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991FF3E7EEA46F11ED4376092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 13/10/2022 10:40, Henry Wang wrote:
> Hi Andrew,
> 
>> -----Original Message-----
>> From: Andrew Cooper <Andrew.Cooper3@citrix.com>
>> Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
>> arch_domain_create()
>>
>> On 13/10/2022 09:38, Henry Wang wrote:
>>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>>> when the domain is created. Considering the worst case of page tables
>>> and keep a buffer, populate 16 pages as the default value to the P2M
>>> pages pool in arch_domain_create() at the domain creation stage to
>>> satisfy the GICv2 requirement.
>>>
>>> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M
>> pool")
>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>>> ---
>>> This should also be backported to 4.13, 4.14, 4.15 and 4.16.
>>> ---
>>>   xen/arch/arm/domain.c | 14 ++++++++++++++
>>>   1 file changed, 14 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>>> index 2c84e6dbbb..e40e2bcba1 100644
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>>>           BUG();
>>>       }
>>>
>>> +    spin_lock(&d->arch.paging.lock);
>>> +    /*
>>> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2
>> area
>>> +     * when the domain is created. Considering the worst case for page
>>> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool
>> here.
>>> +     */
>>> +    if ( (rc = p2m_set_allocation(d, 16, NULL)) != 0 )
>>> +    {
>>> +        p2m_set_allocation(d, 0, NULL);
>>> +        spin_unlock(&d->arch.paging.lock);
>>> +        goto fail;
>>> +    }
>>> +    spin_unlock(&d->arch.paging.lock);
>>
>> Generally, this would be better written as
>>
>> spin_lock();
>> if ( rc = p2m_set_allocation(16) )
>>      p2m_set_allocation(0)
>> spin_unlock();
>>
>> if ( rc )
>>      goto fail;
>>
>> to reduce the number of spin_unlock() calls and make the error paths
>> more clear.  However...
> 
> I think in Arm's arch_domain_create(), all the error handling are the
> same style using:
> 
> if ( (rc = <function>) !=0 )
>      goto fail;
> 
> and we need to keep them the same?

We don't have too. I agree with Andrew's point. How about the following:

spin_lock()
rc = ...
spin_unlock()

if ( rc )
   goto fail;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:47:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.421991.667750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixcH-0006Po-CA; Thu, 13 Oct 2022 12:47:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 421991.667750; Thu, 13 Oct 2022 12:47:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixcH-0006Ph-9P; Thu, 13 Oct 2022 12:47:13 +0000
Received: by outflank-mailman (input) for mailman id 421991;
 Thu, 13 Oct 2022 12:47:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oixcF-00060E-Lk
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:47:11 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150049.outbound.protection.outlook.com [40.107.15.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 27178157-4af5-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 14:47:10 +0200 (CEST)
Received: from AM5PR0301CA0034.eurprd03.prod.outlook.com
 (2603:10a6:206:14::47) by AM7PR08MB5333.eurprd08.prod.outlook.com
 (2603:10a6:20b:104::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:46:58 +0000
Received: from AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:14:cafe::9a) by AM5PR0301CA0034.outlook.office365.com
 (2603:10a6:206:14::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend
 Transport; Thu, 13 Oct 2022 12:46:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT018.mail.protection.outlook.com (100.127.140.97) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 12:46:58 +0000
Received: ("Tessian outbound ce981123c49d:v128");
 Thu, 13 Oct 2022 12:46:58 +0000
Received: from dd1327c5c0de.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 25982FFE-D900-42A0-A7BF-E0A141E6C377.1; 
 Thu, 13 Oct 2022 12:46:52 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dd1327c5c0de.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 12:46:52 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU2PR08MB7376.eurprd08.prod.outlook.com (2603:10a6:10:2f4::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:46:50 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 12:46:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27178157-4af5-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=YzA5sjqKk0ztIRFkoy6sw7De1E5719nyMCXLshgK61e/ko+dug6LKruMPbC9JgFq+GNW+/x0vqLVFe9qv8qn4rVXS/GlVN9k6WJTiYY9hJkRmVhp2ZMGLQ/VcGidKXFYvY6lo5yCFqxz/t3P/0rlNaDn6DG8xl07BztYB77t6Xg8yLUtdnF6KchHQQzUoVoHzz6DSYbUhICJ2nkRex+LKYGDkoHdDhLe0gm76iBj7Vqgp6fVjLxpZjEXnODR4hycxj0pc9jHWh3CXh+X55HZ4TL4z9FnMoSuk96euHqh5m+wEi5Xs6ompoffGBZj4lYosOGOZ/nw9T5qzok8+Osocw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=veGR7p+pdePrM5Rn6tpcyvpEjr6EgHPhcZ6kpXeXDK4=;
 b=BjmL4mpejvoYis5eenfY/kg24xTM4zVhKqv3ROXZZjS7JSVr6IWNsKCaCgsbzxVkx8FNGCqW3Mlj96JqUWBegxHY4jWMESgkGc4SwqWq8+Op2oz1kchpC58WvUXv6f5SiXPS1Cu/BV2do+ATXQHcTFRb6HBtamrmcXrguNRn9Nz/Jx9UZro3h4tqPgHiKeVMO9e51fqqmX6trBgVl8qzvfwvzjSVh43rmxzT7UAtGpzm05ybwmrHiVqxDaun+zcfQDAVZitcY2yvwoPSN/Z4gXMHbgXa2sGAhtIFYMet0IrX4MqcoUvzzkShh3FhDxw0B6Q6SlgBgbu3wj8kPbOBog==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=veGR7p+pdePrM5Rn6tpcyvpEjr6EgHPhcZ6kpXeXDK4=;
 b=T32uLHmkuokK6uIqz4lEe8GMecmUyhb5i+38ZIYinnYkHtLt3qoFE8PWEvobHBKzLlXcTTMUVPbHbHthgeip+5zWV1y0PmJtDWHirIND0MovNmJxQdkrkweVjgRj5EGgtB4IcTzfP1Z5pAOCAW2e1A+zSZw/QU3tHxDeN7RCbak=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GVKIP0mNly5F+xTjF9z9xLYS4NL3d8HaZMamh7HKioKsSjVFUZkMwsESXDhBW4CixhQ6yVAciuk6bE8A7qrI3bgBCQUvJCn6cyQgWeGSV1BwEq8Hl3WXCSKhmpkeRMXq8au3jDrwCmKlHBCBscrpIFAptkhZxZ1IXt748Y6Mlu+LeBCwtKmrYcGRw9Gx0tBjYBaKizSpa55I39+JL2gWieoVCAKhO8ImsiWRf/boy7iRljig4L+5gjWqYIjBJ+klVYnzr2DfHPyzFaiy1wGwX8kUUiydR7F0w/1z3MkW+ZFIjg3FqB78ZLFN85YNqebyf/NP9+EU8TO62TDqsTi4/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=veGR7p+pdePrM5Rn6tpcyvpEjr6EgHPhcZ6kpXeXDK4=;
 b=cWJxoW8tu8NiCALsC1ILYOa10sAzOZtaL0gApCWAyIWg3Wl5NjndtZZd9HdIQghdmwrVjY7TtzA26z30RuiDvDXLTk2Qc9xOHDr9a3l2pTIG1chDEvsG+STTlPq1ANBlcwi3YPLvEAcBEGZoXBTEmnDd5cqrU3UcD42AICXKIyYNgwX9/CCztJTOznyj2H4hIz1Lty2EZAO4Hw0WFLHOrbZ8urAF37G7ySyudU3Cb2m0M+j2pm1VVB84u+THI5onnyxFocKCzdpq+vWHFNkBr6bKrC38DUsykoXN7Od1tQ+H5pfdVuWCq9Ka7eAdOTmu5W9d+lN2NstJdr8UCmu+8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=veGR7p+pdePrM5Rn6tpcyvpEjr6EgHPhcZ6kpXeXDK4=;
 b=T32uLHmkuokK6uIqz4lEe8GMecmUyhb5i+38ZIYinnYkHtLt3qoFE8PWEvobHBKzLlXcTTMUVPbHbHthgeip+5zWV1y0PmJtDWHirIND0MovNmJxQdkrkweVjgRj5EGgtB4IcTzfP1Z5pAOCAW2e1A+zSZw/QU3tHxDeN7RCbak=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [4.17?] Re: [PATCH v3 0/5] x86/mwait-idle: (remaining) SPR +
 (new) ADL support
Thread-Topic: [4.17?] Re: [PATCH v3 0/5] x86/mwait-idle: (remaining) SPR +
 (new) ADL support
Thread-Index: AQHYswLgEBgyLJ1ZH0yh+Kjbzu0UFa4Ml9eAgAAEOVA=
Date: Thu, 13 Oct 2022 12:46:50 +0000
Message-ID:
 <AS8PR08MB7991E01945110983DFCB0AEE92259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <1f8fd1b4-e84b-a211-eaef-c0abe9c0056d@suse.com>
In-Reply-To: <1f8fd1b4-e84b-a211-eaef-c0abe9c0056d@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 05730C2E1731564CB34879B34EF485D3.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU2PR08MB7376:EE_|AM7EUR03FT018:EE_|AM7PR08MB5333:EE_
X-MS-Office365-Filtering-Correlation-Id: b37666ed-58b6-44a5-1664-08daad190488
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 d031ef1Iyn4JRZQBNcJB85Ny5SrtkfZ2Qmfa7GEPBEDvaHvhKl49/0IQf8RkzzuuI9l1HMJuamE1HY/PNrRIaEONRzewzMzKMQBVvp8ScJnGforAZn4XKDeIkRaWD/6jE8sayfJmtQjg7Uubxe91gPpIQwLuOVvoGMe58n/bw0cLbJAzQyQmfwv/uOPh7UPZauRoAOA9VYG9QIB6brAiPI0qTifHF+oJxkW24ptCHdNRsPP9tiYaAXLRQMB7eS/GJ2uUcyXh3sGTLxzmf3RxKfP+dSK/P+JqjspwEDKMrz0IZotfpXdZi4kXAKpJoP8un97uG+r2s+25KFtBurYqulrXw7JdqKgeXSsQlZls5WIDhuO0hAAlGL5S3os1Af4o/tR12qlmP/O5VfE6W3cd83FgDdjyuTRlKfV1ReOo2JTj7hX/YhqfYwFpHWYR/Q10tCOUFduWLkEqW6U3uKQwEBe9hh2SqeoCxo+YtRfzDwXh3Hi6SewgS2A3tiwXyDj+RMm3td7PQVGHeykC3ieToGPRNE8cvCdcC9OnkbYcQof80itye6l3QH0Ji+oMWo2PDhFgMHfKBuV/CslIMQlyVAvG+6SExFHSyNPa5pH2BbhhixST/PZPlcSUysa0MnJhur1NFX04SPtiXqHipAW/+P+gUYGd0OHa5bJY9L4OL8+bKj0G/aPyyWuG8swEbknYvsNNhSgbMrNc5S5ER8ltQUY9rY6sfZNgmq9zV5wbLigyFiMbYI7jf7OvB7EDTqEVK78zkSNalpmUEgqSGIlHUg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(76116006)(316002)(478600001)(6916009)(54906003)(71200400001)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(52536014)(9686003)(53546011)(8936002)(26005)(41300700001)(186003)(5660300002)(7696005)(6506007)(2906002)(83380400001)(122000001)(38100700002)(33656002)(55016003)(38070700005)(86362001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7376
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f402c057-f7cd-4a9d-a30a-08daad18ff88
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qDkdRl+tiCQIXdgkHgJvzLD4HiASPgWrxHnR7z6RcoOan4z1+15qicdTA59mSfpU8Qp5tv9nngUnWAE2HkPHerYwtzwwetUxyN0lPqdW8AJS2DIZyijsT+dE3EzBHPt5WdpQ/Dpn4OpxZG8qTEbty/ItHRq7J3ANAxt752Fp7vrCvc8b/XFkbHXKZdLcRtm+cGkg2D79Q6Ok6HlxsqiWMkuj861K3QZphoATf2sEoCT8Xd3ZdHZ2E/AtZrypS+SCFC6Kap5US6HgJynEslO5UMlmL5Lvdmg5J6oJHv+rFApDFH6/fqSIxTGa4D25r2tFx43z8xMJwdBhrVLDQz6WqCEAwVUJmSQOb8Y1ftfkM7/4Awd9XMjjw5cleW9De1xW0jc3Zx6DQZUkORiY/BRZM4MZ56yK5QZr+bX1fzJzlJaV1G2+ExHr45ousdVKZ/6Uo19vHPkcVrkiz1WP+CtlUz51j96CYxET0lXVAdxwhG7GE1rWzq+T2jfCfumx4WjsbrmfxbIBYsL7SEZpvwRBC8YC+wOZDFdL9NbOaOJXrfzD9JhZrum+0Qu5OR7BlAsAzD03f84zmO16y/1jZAz3JkV9dzWo/m3alA4CAd73Ls19CGlheeJqNIFWwaotPgYK9QRa9oSv+I9cDpS1Tl4wjik0TVRICt7RwfUnWVSpTf1BczYojyWUUrfX2PEjoqMu1dKW1NeFlViOoN8WK9OKwQBZhUGGQWuk8h7gqeOUup+HuT6pkJ5a0Y7KfcqXrzLU7KLEFBz33QsKPaeGlek9fQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(478600001)(36860700001)(82310400005)(41300700001)(86362001)(54906003)(83380400001)(70586007)(70206006)(8676002)(7696005)(4326008)(6506007)(356005)(26005)(47076005)(53546011)(40460700003)(336012)(81166007)(55016003)(316002)(186003)(82740400003)(2906002)(40480700001)(8936002)(6862004)(9686003)(52536014)(5660300002)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:46:58.7536
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b37666ed-58b6-44a5-1664-08daad190488
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5333

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogWzQuMTc/XSBSZTogW1BBVENIIHYz
IDAvNV0geDg2L213YWl0LWlkbGU6IChyZW1haW5pbmcpIFNQUiArIChuZXcpDQo+IEFETCBzdXBw
b3J0DQo+IA0KPiBIZW5yeSwNCj4gDQo+IE9uIDE4LjA4LjIwMjIgMTU6MDIsIEphbiBCZXVsaWNo
IHdyb3RlOg0KPiA+IE5ldyBjaGFuZ2VzIGhhdmUgYXBwZWFyZWQgaW4gdGhlIG1lYW50aW1lLCBp
biBwYXJ0aWN1bGFyIG9uZSBwYXJ0bHkNCj4gdW5kb2luZw0KPiA+IHdoYXQgd2Ugc3RpbGwgaGF2
ZW4ndCBtZXJnZWQgKHBhdGNoIDEgaGVyZSkuDQo+ID4NCj4gPiAxOiBhZGQgJ3ByZWZlcnJlZF9j
c3RhdGVzJyBtb2R1bGUgYXJndW1lbnQNCj4gPiAyOiBhZGQgY29yZSBDNiBvcHRpbWl6YXRpb24g
Zm9yIFNQUg0KPiA+IDM6IGFkZCBBbGRlckxha2Ugc3VwcG9ydA0KPiA+IDQ6IGRpc2FibGUgSUJS
UyBkdXJpbmcgbG9uZyBpZGxlDQo+ID4gNTogbWFrZSBTUFIgQzEgYW5kIEMxRSBiZSBpbmRlcGVu
ZGVudA0KPiANCj4ganVzdCBub3cgYWNrcyBoYXZlIGNvbXBsZXRlZCBjb21pbmcgaW4gZm9yIHRo
aXMgc2VyaWVzIG9mIHBvcnRzIG9mIGVhcmxpZXINCj4gTGludXggY29tbWl0cy4gVGhpcyBhbGwg
dGFyZ2V0cyBuZXdlciBoYXJkd2FyZSB3aGljaCBvZiBjb3Vyc2Ugd2UnZCBsaWtlDQo+IHRvIHBy
b3Blcmx5IHN1cHBvcnQgd2l0aCA0LjE3LiBVbmZvcnR1bmF0ZWx5IHRoZSBzZXJpZXMgd2FzIGtp
bmQgb2YgbG9zdA0KPiB3aXRoIGFsbCB0aGUgc2VjdXJpdHkgd29yayB3aGljaCBoYWQgYmVlbiBv
bmdvaW5nLiBUaGVyZWZvcmUgSSdkIGxpa2UgdG8NCj4gYXNrIChpbiBwYXJ0IGFsc28gbW90aXZh
dGVkIGJ5IEFuZHJldyB0byBkbyBzbykgdGhhdCB5b3UgY29uc2lkZXIgc3RpbGwNCj4gYWxsb3dp
bmcgaW4gdGhpcyBzZXJpZXMuIEluIHRoZSAoSSB0aGluaykgbm90IHZlcnkgbGlrZWx5IGNhc2Ug
b2YgcHJvYmxlbXMNCj4gKGZpcnN0IGFuZCBmb3JlbW9zdCBiZWNhdXNlIG9mIHRoZSBjaGFuZ2Vz
IGNvbWluZyBmcm9tIExpbnV4LCByYXRoZXIgdGhhbg0KPiBiZWluZyBob21lZ3Jvd24pIHBlb3Bs
ZSBhbHdheXMgaGF2ZSB0aGUgb3B0aW9uIG9mIHNpbXBseSB0dXJuaW5nIG9mZiB0aGUNCj4gdXNl
IG9mIHRoaXMgZHJpdmVyIG9uIHRoZWlyIHN5c3RlbXMuDQoNCkkganVzdCBjaGVja2VkIHRoZSB4
ODYgZ2l0bGFiIGJvYXJkIGZvciB0aGUgbGlzdCBhbmQgc2F3IHRoaXMgc2VyaWVzIGlzIG9uIGl0
LiBTbw0KeWVzLCBwbGVhc2UgYWRkIG15IHJlbGVhc2UgYWNrLiBGb3Igbm93IHdlIHN0aWxsIGhh
dmUgMiB3ZWVrcyBiZWZvcmUgdGhlIHJlbGVhc2UNCmFuZCBJIHRoaW5rIHRoYXQgd291bGQgYmUg
YSByZWFzb25hYmxlIHRpbWUgZm9yIGJ1Z3MgdG8gZW1lcmdlLg0KDQpUbyBzZXQgZXhwZWN0YXRp
b25zIEkgYW0gcGVyc29uYWxseSBiZSBtb3JlIGNvbnNlcnZhdGl2ZSBpbiBiZXR3ZWVuIHRoZSBS
QzMNCnRvIFJDNCB3ZWVrLCBiZWNhdXNlIHRoZSBmZWFyIG9mIGxhc3QgbWludXRlIGJ1Z3MuDQoN
CktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IFRoYW5rcywgSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:49:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:49:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422001.667764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixeb-000769-Pb; Thu, 13 Oct 2022 12:49:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422001.667764; Thu, 13 Oct 2022 12:49:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixeb-000762-Mk; Thu, 13 Oct 2022 12:49:37 +0000
Received: by outflank-mailman (input) for mailman id 422001;
 Thu, 13 Oct 2022 12:49:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j8+s=2O=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oixea-00075s-Is
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:49:36 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150071.outbound.protection.outlook.com [40.107.15.71])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d91efbb-4af5-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 14:49:35 +0200 (CEST)
Received: from AM5PR0202CA0020.eurprd02.prod.outlook.com
 (2603:10a6:203:69::30) by PAWPR08MB9637.eurprd08.prod.outlook.com
 (2603:10a6:102:2ec::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 12:49:27 +0000
Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:69:cafe::21) by AM5PR0202CA0020.outlook.office365.com
 (2603:10a6:203:69::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19 via Frontend
 Transport; Thu, 13 Oct 2022 12:49:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 13 Oct 2022 12:49:26 +0000
Received: ("Tessian outbound c2c2da38ad67:v128");
 Thu, 13 Oct 2022 12:49:26 +0000
Received: from 891c66ecfef4.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3594B63C-93B6-4D46-96D8-CEF6E40EE23A.1; 
 Thu, 13 Oct 2022 12:49:16 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 891c66ecfef4.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 13 Oct 2022 12:49:16 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by VI1PR08MB5534.eurprd08.prod.outlook.com (2603:10a6:803:135::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 12:49:06 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 12:49:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d91efbb-4af5-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=lYETr7cDWIs6bPL/Yst3SiBX3q3Fy8GwC+5WNLJ4KYmRd3yRicXVPUyVvROVpJlRnr2MhaltidshZeHeh/PIwYZaw3PeyyLrPl7KmkvMppO9t/J9dbGbK/8/15SPDWaAU4quXq2szfF026id71ZFcgyC9S+E0lhqJW/tSajOAY14JoQmPvi4C67wC1yRyWc1SvfeMPA1MprE0kcPPVG6QxFCGzKWa6OaEIX6Ens+wFaLzjBG14afIY3yCe4K6hLAlAnJV3H3vjd3wFeYPICJ8Y6nQ50wJtU8ZQ9I8sJNXCCpakh0E1gQs2rxPoMoeUG9FKs1RR9oy1mVIzQ2ZucPXA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xf+r8Bc3QMJLG5H3ag52ZoXOW4MPEbB9Nsco29WT7sc=;
 b=EFs80SA3mT985AMMg1vZZNVYfNS+a0obURiLf67AUskltTrncSdsU/PuZbKKiz3wqIjf4VSsoSmos3d53qNogTBfmyYkl06HPtlK0L0NEHtF+wSaCeZj0oFAyzqO2+5g3MjeO9Ch61LjEDJ04mTGrDku0FI0v9Hv7kdIyCCchw0fO7cqal8IN3dVnyg8gyHcsPhmV2mag3UmsfYc3SVtWx5f6tmzQo2B7FEyhPRY6CGeGJ2BcS7M4MxrVCaFb100U5Nxn8q513ClP9Q0wTRrH3GN0xKX8PUc/BvAq3M+Z/M8147ZjAy1LuGVOUY4+F1ieCGk88z1qQ6IzzDCcH2xUg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Xf+r8Bc3QMJLG5H3ag52ZoXOW4MPEbB9Nsco29WT7sc=;
 b=CvQRBNLrjWcYcbKEXU21odAQunDIOWWE3ni28QxMplcVKEKoEXRu/Ai9NV4xSGXiRtgPerOdkK+yNhgMXkn81ZYo+T/sD55E4NsC706zwpSiJjdrfrioP+xIezhK+piO/yi+QkBHvfcIQ7JqIuqKszwSVe2WKM6tr24Dw93Dqhg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mHREdVwTHmB/QReUObEjOdarOCM0XfYFE1LnZ3cZDhHWAUyo8fOmNxafRfS4tyUHAOK/SGfecXgf5PpOyd+vMV3Wt8sG+RNKMY7EwjKvX3ZD4C8eclk4pd4OPh2HQiDJjeUKLPeM2xUPjdbfTWpGTYvFF+zcBA2jvXiWx3+lmabDJXNRtKKT+Eknd+p5qaUocE9bULkkq53AQOMHbASYJZ3PtkpIwoGBbt4txwU1iHH83BfijUhxdqHiIxXbCZXRjDEsaPIlIwUiELsxPqiK3T0gIQLMxubRAtkF5sOgAQKc1PjGAQeNXw0NLoH53KXKA80EkKRmkH90YfjTqfpVwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xf+r8Bc3QMJLG5H3ag52ZoXOW4MPEbB9Nsco29WT7sc=;
 b=QQVgJky01nEGDlM3jK11V/GpkxkTXpYy867QGOEnISMoZS29wQfjT3DBqOUj9yw/439KC/ytCvypTU8xeRXNxOkE2zQCpREyW9nTdFA95gkJPBvCfsr1BDI1f1FkIjS4SZqAmsurH+51W9+7TikvTOsd8DJuN9yrjfcwEUE61A+ZDLUbgxhVMcZg7xidW0ficeqLE9lmwzTSkr4ivJMX/1LvLV0z4Us4QNk2WSFmznqJDObu4Wk9intBtW6l8Le3kp7dytIN7OwsQmCvNsE1Id1HccFdOK2UJoq0q7yWmDWGsfchvrRg4r3TzP2kWaukxcrg/pcqY2k0KTmXuUbzLw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Xf+r8Bc3QMJLG5H3ag52ZoXOW4MPEbB9Nsco29WT7sc=;
 b=CvQRBNLrjWcYcbKEXU21odAQunDIOWWE3ni28QxMplcVKEKoEXRu/Ai9NV4xSGXiRtgPerOdkK+yNhgMXkn81ZYo+T/sD55E4NsC706zwpSiJjdrfrioP+xIezhK+piO/yi+QkBHvfcIQ7JqIuqKszwSVe2WKM6tr24Dw93Dqhg=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY3t81xdeRddBbSEGLoF20gErPe64MD6gAgAAAmHCAADWrgIAAAFWw
Date: Thu, 13 Oct 2022 12:49:06 +0000
Message-ID:
 <AS8PR08MB7991FED203D591F95909A8C992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
 <AS8PR08MB7991FF3E7EEA46F11ED4376092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <63f5ab77-de4e-7a42-9942-832d8f891a53@xen.org>
In-Reply-To: <63f5ab77-de4e-7a42-9942-832d8f891a53@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 3ACDFB331A6393439A763E4A7C0FC576.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|VI1PR08MB5534:EE_|VE1EUR03FT007:EE_|PAWPR08MB9637:EE_
X-MS-Office365-Filtering-Correlation-Id: 1b8bd702-9ee5-4b29-dca1-08daad195cc0
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Mcgkh1Cpbs8281c737Ld4JORXXWma8VD0vbuq/1Ue/q1Wl2QPZfa5ShhqdN+8qPfQ3vL5KspbcQGNWbRa7nqP148VFR8ynHtvQlNNAyRZvAAEZ2KLVx5NAui9BbsXyiLMqGp1Oa676L7QzJgt5Dn80EqO/tRS3db57ynzRuCgjFKCQSkE0HCJeGE4Krt+FrQFBAXvDyImNGh2opX/JCKPmPVAJlzibIuc9+HgHXGADnP9LFUbUzusxe7dVpjiwJz2pQVj9MPfz6mCwW0hujA/euxjbZcMa2JxVAiKVQ8wah/hw11D8lsmXYaMNz21bc/Rtd+05W2eBFXMV0ePpWmEED3GlfWSdLYqR4WviTehoDZvi+Paasq1hUSKKICGNr7NO2kH5O6NYHiSe0U6CRvRJ3T6Fc5j57/CqEwBog3CfFiNrxz4Uvjmo4UlI1sMDLCtfCuGcoC5Wl2cYHq/oUlhAUSg8qNMBM9hpHL1Kqel8hAT+XAZ8ob50F7+68xjNPKoUlOmMox06WjdUdn+ktWRkJ4dSfDUz/U2Razi0+ECxCtOIAULkWXitpQvhzK4MVVqKA9R8oPwIpHJ2H1fVFC/EcCljhmhlPvUpumgJtLV5HNMfRFeKz670FWBqy9eI3SridOi/I+Ou2qQaMYvVZsuxkZQUG9oUm0X7/Uw6QzPinnf2HGxDpDprV5nhypeRiLacLdz00qYahRda8fuK1FZexM+Xr/bIwTpzMoJhtWTLcoUErvjwasDOvrxAL6P2FNBNXI+0thlI40ckuvwzF1Jg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199015)(186003)(83380400001)(38070700005)(86362001)(122000001)(38100700002)(4744005)(5660300002)(2906002)(41300700001)(4326008)(8936002)(55016003)(52536014)(8676002)(64756008)(478600001)(9686003)(26005)(6506007)(7696005)(110136005)(316002)(66446008)(66556008)(66476007)(54906003)(71200400001)(66946007)(76116006)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5534
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d045303d-bd38-4c9b-da00-08daad19506d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XaiLDzCgwP2sm0PZNoyVaOeL6I06twF/ToS80SCV8/duQRTrFWGNOVmwMQTy0jckuWsl8kHIbh+JslyQryAntDmWnnLnLkHiqjspNFHubS8r1OT31tJtdPs4kKfCXRvLQCntgtaTOuMZbP1bJKFk5KxdUVoW/r2Ys/D8WXluGek4R+KzXzqNXVhLQsGDMqmD+OEYEVXdo6Vlqae0MiXy1wNGO6VA+xM+Ik8+QbeijKSc4ZAoNL8h4+p6MqQUf8AsiL2rWkaQsoVmc40uwCt9PD8ElVaAeXhAoVEyBF6apbIXFrreaIwhlw/sv8b8sVxh5/pmQ/M0Szj31JgEmFLhhCvjqdGB2zOZHzFsv10ccymKSwGPD+2oRlAsZfs/XRYk5lWrHZMTORkw2IpMTwsIxAEGky0/BzquTAqP7JYgMmS+v6bgxqzxsGerWZRSjTNtT/XrS/ayTTJLIQ5NO2C/lYspohykXKS3nrtdeDRBE714HdAa+rxY9X0Vb781yiF0OfJTPtD2xaZQJPBI4aUP2XmpMC/MtFonIApe63N7VXCBR57dogqg+aMe/dqTAfzGfec8QopghTy/JS2DAey63yoQMvl+z9BOd3CteqXgmIP69zYGWd18Q41XoDyYnrSDsCnMDxQWp2dkRkbKwfpE8fOaz7RxLeiZLFw07oo9ewz3LfV1dKHkIMwSCdf2jMbvnyT68R5MAe8pFaEcJFSFeuEplAlAHjbwHkjY8Lq/xvm2YfmCxbxOdnqVRDqrSiYzPFvzAdU+y6Mu0X4FKJqKQw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(6506007)(40480700001)(356005)(55016003)(7696005)(8676002)(316002)(107886003)(478600001)(70586007)(82310400005)(70206006)(4744005)(2906002)(5660300002)(86362001)(52536014)(4326008)(82740400003)(41300700001)(36860700001)(8936002)(81166007)(40460700003)(54906003)(47076005)(33656002)(110136005)(186003)(83380400001)(9686003)(26005)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 12:49:26.7183
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b8bd702-9ee5-4b29-dca1-08daad195cc0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9637

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHhlbi9hcm06
IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4gYXJjaF9kb21haW5f
Y3JlYXRlKCkNCj4gPiBJIHRoaW5rIGluIEFybSdzIGFyY2hfZG9tYWluX2NyZWF0ZSgpLCBhbGwg
dGhlIGVycm9yIGhhbmRsaW5nIGFyZSB0aGUNCj4gPiBzYW1lIHN0eWxlIHVzaW5nOg0KPiA+DQo+
ID4gaWYgKCAocmMgPSA8ZnVuY3Rpb24+KSAhPTAgKQ0KPiA+ICAgICAgZ290byBmYWlsOw0KPiA+
DQo+ID4gYW5kIHdlIG5lZWQgdG8ga2VlcCB0aGVtIHRoZSBzYW1lPw0KPiANCj4gV2UgZG9uJ3Qg
aGF2ZSB0b28uIEkgYWdyZWUgd2l0aCBBbmRyZXcncyBwb2ludC4gSG93IGFib3V0IHRoZSBmb2xs
b3dpbmc6DQo+IA0KPiBzcGluX2xvY2soKQ0KPiByYyA9IC4uLg0KPiBzcGluX3VubG9jaygpDQo+
IA0KPiBpZiAoIHJjICkNCj4gICAgZ290byBmYWlsOw0KDQpZZXAgdGhpcyBpcyBteSBjdXJyZW50
IG1ldGhvZCBvZiBsb2NhbCB2Mi4gVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbi4NCldvcmtp
bmcgb24gdGhlIHAybV90ZWFyZG93biBwYXJ0IG5vdy4uLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5y
eQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 12:56:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 12:56:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422008.667777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixlI-0000Dh-Gz; Thu, 13 Oct 2022 12:56:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422008.667777; Thu, 13 Oct 2022 12:56:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixlI-0000Da-EG; Thu, 13 Oct 2022 12:56:32 +0000
Received: by outflank-mailman (input) for mailman id 422008;
 Thu, 13 Oct 2022 12:56:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oixlH-0000DU-8W
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 12:56:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixlG-0007Nz-Re; Thu, 13 Oct 2022 12:56:30 +0000
Received: from [15.248.2.148] (helo=[10.24.69.9])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oixlG-0006yv-LN; Thu, 13 Oct 2022 12:56:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DWn+MdcvzDbUQgzj/haSm1RdTR+92+VNpgrkSyq5g+s=; b=0k7DMqxjJo94TZV2qMyeEN6Nzp
	RdGJMz4GCUCwFslbsOf7Ao+j3SDotaexCa/I3JZyOs08IT4+kIO4zinSBwmQcbPJIY5fI21prDheK
	X6CWcqkWvj3VOv3EO6tqvdJ05nOvakLaUDz2Z1OZ6A+jOI+usvhilvb37H3PxgxR91Sc=;
Message-ID: <e1077b48-668f-5c49-d69c-a84100a8a0d3@xen.org>
Date: Thu, 13 Oct 2022 13:56:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
 <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6cf1c4a9-f339-217c-4557-b0a9ff37938a@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 13/10/2022 10:32, Andrew Cooper wrote:
> On 13/10/2022 09:38, Henry Wang wrote:
>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>> when the domain is created. Considering the worst case of page tables
>> and keep a buffer, populate 16 pages as the default value to the P2M
>> pages pool in arch_domain_create() at the domain creation stage to
>> satisfy the GICv2 requirement.
>>
>> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>> ---
>> This should also be backported to 4.13, 4.14, 4.15 and 4.16.
>> ---
>>   xen/arch/arm/domain.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 2c84e6dbbb..e40e2bcba1 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>>           BUG();
>>       }
>>   
>> +    spin_lock(&d->arch.paging.lock);
>> +    /*
>> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>> +     * when the domain is created. Considering the worst case for page
>> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
>> +     */
>> +    if ( (rc = p2m_set_allocation(d, 16, NULL)) != 0 )
>> +    {
>> +        p2m_set_allocation(d, 0, NULL);
>> +        spin_unlock(&d->arch.paging.lock);
>> +        goto fail;
>> +    }
>> +    spin_unlock(&d->arch.paging.lock);
> 
> Generally, this would be better written as
> 
> spin_lock();
> if ( rc = p2m_set_allocation(16) )
>      p2m_set_allocation(0)
> spin_unlock();
> 
> if ( rc )
>      goto fail;
> 
> to reduce the number of spin_unlock() calls and make the error paths
> more clear.  However...
> 
>> +
>>       if ( (rc = domain_vgic_register(d, &count)) != 0 )
>>           goto fail;
>>   
> 
> ... you've got a problem on this error path, so the set allocation to 0
> needs to be in the fail: path with suitable locking.
> 
> There are perhaps better ways of doing it in 4.15(?) and later, but not
> in earlier versions.  As this is a fix to a bug in a security patch,
> simplicity is generally the better approach.

I guess you are referring to domain_teardown()? I think it may end up to 
be quite large because we would have to move other bits of the 
arch_domain_destroy() in domain_teardown().

It is also not clear whether part of domain_relinquish_memory() would 
need to be moved there as well.

So this sounds more like some work for post-4.17.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422019.667801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixts-0001ty-L8; Thu, 13 Oct 2022 13:05:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422019.667801; Thu, 13 Oct 2022 13:05:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixts-0001tr-GW; Thu, 13 Oct 2022 13:05:24 +0000
Received: by outflank-mailman (input) for mailman id 422019;
 Thu, 13 Oct 2022 13:05:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixtr-0001tl-4S
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:23 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a37d5072-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:04:59 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a37d5072-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666321;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=4VD5kqizMtcaU6mhlTqgWMjJnwhwSgll9zXYieTMYuk=;
  b=dgRdw544u5ZZXhOR4TFtV5ytjl9z+nr1knB7SaK3yem27GYMkUgXxV6p
   plT5jhyQjsogT1r8oKXc55Uz3y5Xqzk4Qch97M7Pp8OLxY6HB/Jdw1Rn+
   R36Vf5cE9OKOot5TzZY5ONdUDeJCp4qboTMvgnNZrITOxf/CIZ3Q4MjBx
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 83071467
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:wMtFka5CYAKYEtUENdSysAxRtJXHchMFZxGqfqrLsTDasY5as4F+v
 mpOWW+OaPeLNmPwKNF1aI/n/RgEsZ6DztIxSgRurntmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gVlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5eJFlO0
 fAlNwouURCDuLOvm++jd7hz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP
 oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozRHZoMwhjHz
 o7A1zWlWh0Eatqv8CWM0nD0p+nTtj/0cY1HQdVU8dY12QbOlwT/EiY+V0a/oPS/ol6zXZRYM
 UN80jUqhbg/8gqsVNaVdwG5pVaUsxhaXMBfe8U24R+A4rDZ6AGYAi4DVDEpQMYhr8UsQjsp0
 HeGmtroAXpkt7j9YXCS7LCPthupJDMYa2QFYEcsTwEI/t3iq4EblQ/UQ5BoF6vdps34H3T8z
 i6HqAA6hq4Plogb2qOj51fFjjmw4J/TQWYd6h3MW2O57itwfIO/e5Gz8l/f8OpBK4CCCFKGu
 RAslsyT6ulIEJ+MkTCWTfsENLaz7v2BPXvXhlsHN4I66z2n9nqnfIZRyDJzPkFkNoADYzCBX
 aPIkVoPvtkJZiLsNPIpJdLqYyg38UT+Pf3AbvDwYudRWLtOdA+4rTg1OFatjn+4xSDAjpoDE
 ZucdM+tC1MTBqJm0Ce6So8h7FM7+swt7TiNHM6mlnxLxZLbPSfIEuldbDNie8hjtMu5TBPpH
 8Gz3idg4zFWS6XAbybe6ub/xnhafCFgVfgaRyG6H9NvwzaK+kl7Vpc9Ipt7IeSJepi5cc+Zl
 kxRomcClDLCaYTvcG1mkExLZrL1RopYpnkmJyEqNlvA8yF9P9vxtP9HL8VoJONPGAlfIRlcF
 qBtRil9Kq4XFmSvF8o1N/ERU7COhDz03FnTbkJJkRA0foJ6Rhyhx+IIijDHrXBWZhdbQONk/
 NVMICuHHsdYL+mjZe6KAM+SI6SZ5CRNxb0jARWSf7G+uizEqeBXFsA4tddvS+lkFPkJ7mbyO
 9q+afvAmdTwng==
IronPort-HdrOrdr: A9a23:o7H4OKqzIbRJc/NuHgo9N34aV5rReYIsimQD101hICG9Evb0qy
 lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM
 VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf
 yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="83071467"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "Daniel P.
 Smith" <dpsmith@apertussolutions.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>, Christian Lindig
	<christian.lindig@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Tim Deegan <tim@xen.org>, Nick Rosbrook
	<rosbrookn@gmail.com>, David Scott <dave@recoil.org>
Subject: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles
Date: Thu, 13 Oct 2022 14:04:56 +0100
Message-ID: <20221013130513.52440-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v5

Changes in v5:
- rebased on staging
- added "tools: Rework linking options for ocaml binding libraries"

Changes in v4:
- several new patches
- some changes to other patches listed in their changelogs

Changes in v3:
- rebased
- several new patches, starting with 13/25 "tools/libs/util: cleanup Makefile"
- introducing macros to deal with linking with in-tree xen libraries
- Add -Werror to CFLAGS for all builds in tools/

Changes in v2:
- one new patch
- other changes described in patch notes

Hi everyone,

I've been looking at reworking the build system we have for the "tools/", and
transforming it to something that suit it better. There are a lot of
dependencies between different sub-directories so it would be nice if GNU make
could actually handle them. This is possible with "non-recursive makefiles".

With non-recursive makefiles, make will have to load/include all the makefiles
and thus will have complete overview of all the dependencies. This will allow
make to build the necessary targets in other directory, and we won't need to
build sub-directories one by one.

To help with this transformation, I've chosen to go with a recent project
called "subdirmk". It help to deal with the fact that all makefiles will share
the same namespace, it is hooked into autoconf, we can easily run `make` from
any subdirectory. Together "autoconf" and "subdirmk" will also help to get
closer to be able to do out-of-tree build of the tools, but I'm mainly looking
to have non-recursive makefile.

Link to the project:
    https://www.chiark.greenend.org.uk/ucgi/~ian/git/subdirmk.git/

But before getting to the main course, I've got quite a few cleanup and some
changes to the makefiles. I start the patch series with patches that remove old
left over stuff, then start reworking makefiles. They are some common changes like
removing the "build" targets in many places as "all" would be the more common
way to spell it and "all" is the default target anyway. They are other changes
related to the conversion to "subdirmk", I start to use the variable $(TARGETS)
in several makefiles, this variable will have a special meaning in subdirmk
which will build those target by default.

As for the conversion to non-recursive makefile, with subdirmk, I have this WIP
branch, it contains some changes that I'm trying out, some notes, and the
conversion, one Makefile per commit. Cleanup are still needed, some makefile
not converted yet, but it's otherwise mostly done.

    https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v1-wip-extra

With that branch, you could tried something like:
    ./configure; cd tools/xl; make
and `xl` should be built as well as all the xen library needed.
Also, things like `make clean` or rebuild should be faster in the all tools/
directory.

Cheers,

Anthony PERARD (17):
  tools/debugger/gdbsx: Fix and cleanup makefiles
  tools/xentrace: rework Makefile
  tools: Introduce $(xenlibs-ldflags, ) macro
  tools: Add -Werror by default to all tools/
  tools: Remove -Werror everywhere else
  tools/hotplug: Generate "hotplugpath.sh" with configure
  libs/light/gentypes.py: allow to generate headers in subdirectory
  git-checkout.sh: handle running git-checkout from a different
    directory
  libs: Avoid exposing -Wl,--version-script to other built library
  libs: Fix auto-generation of version-script for unstable libs
  tools/include: Rework Makefile
  libs/light: Rework acpi table build targets
  libs/light: Rework generation of include/_libxl_*.h
  libs/light: Rework targets prerequisites
  libs/light: Makefile cleanup
  tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go
  tools: Rework linking options for ocaml binding libraries

 tools/configure.ac                     |  2 +
 tools/console/client/Makefile          |  1 -
 tools/console/daemon/Makefile          |  1 -
 tools/debugger/gdbsx/Makefile          | 20 +++----
 tools/debugger/gdbsx/gx/Makefile       | 15 +++---
 tools/debugger/gdbsx/xg/Makefile       | 25 +++------
 tools/debugger/kdd/Makefile            |  1 -
 tools/flask/utils/Makefile             |  1 -
 tools/fuzz/cpu-policy/Makefile         |  2 +-
 tools/golang/xenlight/Makefile         |  8 +--
 tools/hotplug/common/Makefile          | 10 +---
 tools/include/Makefile                 | 28 +++++-----
 tools/libs/call/Makefile               |  1 +
 tools/libs/ctrl/Makefile               |  3 --
 tools/libs/devicemodel/Makefile        |  1 +
 tools/libs/evtchn/Makefile             |  1 +
 tools/libs/foreignmemory/Makefile      |  1 +
 tools/libs/gnttab/Makefile             |  1 +
 tools/libs/guest/Makefile              |  3 --
 tools/libs/hypfs/Makefile              |  1 +
 tools/libs/light/Makefile              | 72 +++++++++++++++-----------
 tools/libs/stat/Makefile               |  2 +-
 tools/libs/store/Makefile              |  1 +
 tools/libs/toolcore/Makefile           |  1 +
 tools/libs/toollog/Makefile            |  1 +
 tools/libs/util/Makefile               |  3 --
 tools/libs/vchan/Makefile              |  3 --
 tools/misc/Makefile                    |  1 -
 tools/ocaml/libs/eventchn/Makefile     |  2 +-
 tools/ocaml/libs/xc/Makefile           |  2 +-
 tools/ocaml/libs/xentoollog/Makefile   |  2 +-
 tools/ocaml/libs/xl/Makefile           |  2 +-
 tools/tests/cpu-policy/Makefile        |  2 +-
 tools/tests/depriv/Makefile            |  2 +-
 tools/tests/resource/Makefile          |  1 -
 tools/tests/tsx/Makefile               |  1 -
 tools/tests/xenstore/Makefile          |  1 -
 tools/xcutils/Makefile                 |  2 -
 tools/xenmon/Makefile                  |  1 -
 tools/xenpaging/Makefile               |  1 -
 tools/xenpmd/Makefile                  |  1 -
 tools/xentop/Makefile                  |  2 +-
 tools/xentrace/Makefile                | 29 ++++-------
 tools/xl/Makefile                      |  2 +-
 tools/Rules.mk                         | 20 +++++++
 tools/debugger/gdbsx/Rules.mk          |  2 +-
 tools/firmware/Rules.mk                |  2 -
 tools/libfsimage/common.mk             |  2 +-
 tools/libs/libs.mk                     | 21 +++++---
 tools/libs/light/libxl_x86_acpi.c      |  2 +-
 tools/ocaml/common.make                |  2 +-
 .gitignore                             |  6 ---
 config/Tools.mk.in                     |  1 +
 scripts/git-checkout.sh                |  4 +-
 tools/configure                        | 29 ++++++++++-
 tools/golang/xenlight/gengotypes.py    | 10 +++-
 tools/hotplug/common/hotplugpath.sh.in | 16 ++++++
 tools/libs/light/gentypes.py           |  9 ++--
 tools/xenstore/Makefile.common         |  1 -
 59 files changed, 218 insertions(+), 172 deletions(-)
 create mode 100644 tools/hotplug/common/hotplugpath.sh.in

-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422020.667812 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixty-0002Aq-S1; Thu, 13 Oct 2022 13:05:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422020.667812; Thu, 13 Oct 2022 13:05:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixty-0002Aj-Ow; Thu, 13 Oct 2022 13:05:30 +0000
Received: by outflank-mailman (input) for mailman id 422020;
 Thu, 13 Oct 2022 13:05:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixtx-0001tl-1N
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:29 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7653bf6-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:06 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7653bf6-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666327;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=uMtbT9OvCCyn0S146BCICiBUUfTxeCiBwu/GDB4z7hw=;
  b=Lssi63DSGjkrj0ROCCgtI1fB7YmXSPxdlFhArEI47GMJ9O3jgn9t02sb
   9sUTB2jAbJDhKtBxBFoD0/ineNElZk24qYITcOrLJbI8MWGSUa6ZYu0JE
   eicBxXlbB5G3OQ+QZTJdOHoqJkRmhvoIO9BAr3x7uFmuB00FXqDKwIrXm
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82660695
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ALkY9Va7I9QmVYQHL/35oAAxR2vbMJQZQLiYv2?=
 =?us-ascii?q?9bIXmNSXhzvzPLM5wBkF31ARqiwpsLxTDuk2K5y4Fltw4rHtUhMcdOLQjwCb?=
 =?us-ascii?q?f3UD1utrioGJcIt4OZ/tjYNCi4ujkJMXCU9cPX3Q4OgGBMQFJQAlSrNy4hwQ?=
 =?us-ascii?q?vVPWB7Uzo4IImWWayClEksCRdi/DUdPCvCpCfAc403pIYIdttpLONV2N3mmN?=
 =?us-ascii?q?8/cWy26ntknqBcy/B1vtszfsWR/SfRGHYyHBNlXrldqDpDzSPa/1cgcP4Pne?=
 =?us-ascii?q?fU7Ee3D4eyjPzdc/eGRDowRIxyVcl+Vn0nY+PzCBs/JEBnOLiJgfa2bjfEJf?=
 =?us-ascii?q?NaqRSj3eoX6ehEQntN1XeRD6YFsMOie1hj0KmOCh2YdEVM/5jcg+YMARNIzC?=
 =?us-ascii?q?5LTR0sv2AdYFYZuf7EdjfMoV7KJQPaXVGmO+ddxBIweSIl3KD2BvzSDa9g69?=
 =?us-ascii?q?ij9bHEvgRUWMR2F9jYXKOEhKVgj/rBDSIL5QicT5J5q9RUWm7THJHov8CUlx?=
 =?us-ascii?q?SVEzC5uKaLok41jrHS5gaye/MmG/I/pitUNOG55Lc03ZalB1xLEicoFCzjUh?=
 =?us-ascii?q?JSzc8GUIVAfDyyDQjpnggMXgk6BJSWc+DPA8vKsekCJZRy8Ib9Zx/WnY/MXW?=
 =?us-ascii?q?NycMFpeUNS2ToLWHW1rJwCOojs8VVZ2uY/odHDqtQgwheS/gRl0Vcs0uw+OJ?=
 =?us-ascii?q?6rhaCGae0mpnrXzuy/zEMT5ffmfSNsV1vWksE26Lc4TQ4+VPOFALwbG/4VCW?=
 =?us-ascii?q?UWiZz8gAXp9LHEp+v5S0UbeI0fkZZ4r9WT+5EMDH/KUk1P/YJb89lL/LIMlj?=
 =?us-ascii?q?nAlLof5lRxYJ1qEnfNGP813Z4hZGaYtsziWn8INK9pZ+Pj0d7P3jZBkCwQ9c?=
 =?us-ascii?q?KcW0TIIIkoymCB+bsgXyhSL1t/HNnEt9XkT5N1tNlg1w7DVPKtRGO/yG5mNX?=
 =?us-ascii?q?RwbPTjQrqw1uwRbKdPQ7ffc6Qo7V27qbxBzvkEzHC3eX4e4jbDrCvktxHm5G?=
 =?us-ascii?q?umHE7uQeWcp9pwLl6DMHbHX+LHeIo7kSJVIwr0kamxjxLksxv8EvyDl5sQBJ?=
 =?us-ascii?q?tMHMk1eE2e1GMZMhbnoNRym3yMy6bxzY2s1S10SVfpui7AcK61csq+g6kbVh?=
 =?us-ascii?q?n1miSnr6aByUpn6Wqtff0S/gQQwxPnWtImFJU6ep0cRI4Y7WqRzCpJJq2uXg?=
 =?us-ascii?q?oMav4zoQftC07x0U4iAO2Gg/QO614Z7dIowH92mhVaaYU2ROgCANKhp1xtaK?=
 =?us-ascii?q?s0BK4J3D+7JuuCsj70Son9rJWx/dyM8PPy5W+wVJEm3D6TUyeCaIRO0LttQ+?=
 =?us-ascii?q?jetpcSK5N1fzukUaKZ/B/8qSxyP9uypx8NlsNtkhn/KvpGPCHoKp54nngGDO?=
 =?us-ascii?q?JQ7bElCz2JH2XwsinHpePzeRGkvEeXsFUK4++lC6pRJChW4b+stcquIo1ZNk?=
 =?us-ascii?q?YLvYewPZE8f+YruiLvByL6k0i7NUKRi1DapsFRM013HgnEGrqdUylvHio8jh?=
 =?us-ascii?q?B4rrxybBldOFK2ik/klXnDF7d5+l9e4tC1KLSX7LNN2kP8rMkepUpO7TYEcQ?=
 =?us-ascii?q?9DcD23G994np4Eln0puX21fpUINVkv7CfPzezp3/ZaBpNrbve2Ih/zVcRusn?=
 =?us-ascii?q?GXet0fsa9j1hve9PIZo9fMLnLvhcbybeqknBVKBF+jIl7dfFgZVMPWkCPhCn?=
 =?us-ascii?q?ObC/wzF8gxzXoN7nsOJOQl+34ZVm2uoRHImN0MuWsbDUrJ+5CbGXM9eou/QZ?=
 =?us-ascii?q?voo8XKwWXhMavDHbZnSrbJiK+bnwKw9ADVKP12rHYLdqKLK6HSRJDXvckEJ+?=
 =?us-ascii?q?v+oK1YN2Mm61d1psy+UH3N3xqUwgFkkyJqC0Ie1Q/oo/UA07Riu5vkbiVBMX?=
 =?us-ascii?q?hoApP1/lCJkHEsENUVcF/9y50Jv3BrZzAI4mwwUVzoJX8ug4ysNZrL+mg7cK?=
 =?us-ascii?q?Y/z/CbT33556+7uUKySmpbTWD8P8qM381v/vJtolUGp0iFs0SiKqiVUneSY+?=
 =?us-ascii?q?xfRKNFt8+t5cr9W0Yg5kkpne92cAdSo9lbkDBwOfgTDoeQo1nPFn2f0RuDxs?=
 =?us-ascii?q?556c9xBzmxTX2fKo61+Fzbd9UcEa8zJcYGDT61bbokThd+iYUtiIWd8i8stA?=
 =?us-ascii?q?SwrY5zR6xYTbaRtl2GfN1Ml3C/Nr+0PYUPkntFf99Sv40X5/nlyEseIPpTJE?=
 =?us-ascii?q?tqBjPVcGPfr/KhCIXiwoffGbEXvfYb0YwvJTHxO++dguS+5ZyXKdRzv2ys30?=
 =?us-ascii?q?O5ernjLgpowYARSm7QGNgGtRIMVR7DjPHGjpLy+P18BJlT3DeJ7Ftjehd7bk?=
 =?us-ascii?q?HJREX/2bJz4PTYl1jj7ZiyvUOT1YorRBAKufACs5KHl2Z0iHuvFsAh0OvDQB?=
 =?us-ascii?q?c0vysTksHAzQDAxzZXKnOlzQIuZWVoNADkx/ZLiSKfTDcs1cYoFHB+qDJc/s?=
 =?us-ascii?q?uMDJd5WRGqf2s9SM7DhiJFeCijT23Hj1xmwTFEhrM6qufmkqxOg+Chi377o4?=
 =?us-ascii?q?AkZhLWNVPyQ30RP69y8rp7+iBU3o+pW0vS0wxz65ikgWcCEV/AdqHu2dKlh/?=
 =?us-ascii?q?/RCon8ctUwwQdAyWwD9QqluGFfhXQVNEzpcfnZYbd3rKqt9YCDPlt9kvfUJF?=
 =?us-ascii?q?1n3Y4/AOQox56pMw/oztc7s5PH6JYHEOMP2JdtdbHdDI3dAyYDWp0P/2AC6I?=
 =?us-ascii?q?TACnr4jyL0jGrEVGd1/R4afWietbBXED/VPUbRTrPDoRntDQ4lsTRL6BrWYD?=
 =?us-ascii?q?/Z+CnD0bZFoH5IBilnPMY+Q2mB9JKGznGY3?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82660695"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Luca Fancellu
	<luca.fancellu@arm.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 04/17] tools: Add -Werror by default to all tools/
Date: Thu, 13 Oct 2022 14:05:00 +0100
Message-ID: <20221013130513.52440-5-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

And provide an option to ./configure to disable it.

A follow-up patch will remove -Werror from every other Makefile in
tools/. ("tools: Remove -Werror everywhere else")

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---
 tools/configure.ac |  1 +
 tools/Rules.mk     |  4 ++++
 config/Tools.mk.in |  1 +
 tools/configure    | 26 ++++++++++++++++++++++++++
 4 files changed, 32 insertions(+)

diff --git a/tools/configure.ac b/tools/configure.ac
index 32cbe6bd3c..09059bc569 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -81,6 +81,7 @@ m4_include([../m4/header.m4])
 AX_XEN_EXPAND_CONFIG()
 
 # Enable/disable options
+AX_ARG_DEFAULT_ENABLE([werror], [Build tools without -Werror])
 AX_ARG_DEFAULT_DISABLE([rpath], [Build tools with -Wl,-rpath,LIBDIR])
 AX_ARG_DEFAULT_DISABLE([githttp], [Download GIT repositories via HTTP])
 AX_ARG_DEFAULT_ENABLE([monitors], [Disable xenstat and xentop monitoring tools])
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 26958b2948..a165dc4bda 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -133,6 +133,10 @@ endif
 
 CFLAGS_libxenlight += $(CFLAGS_libxenctrl)
 
+ifeq ($(CONFIG_WERROR),y)
+CFLAGS += -Werror
+endif
+
 ifeq ($(debug),y)
 # Use -Og if available, -O0 otherwise
 dbg_opt_level := $(call cc-option,$(CC),-Og,-O0)
diff --git a/config/Tools.mk.in b/config/Tools.mk.in
index 6c1a0a676f..d0d460f922 100644
--- a/config/Tools.mk.in
+++ b/config/Tools.mk.in
@@ -1,5 +1,6 @@
 -include $(XEN_ROOT)/config/Paths.mk
 
+CONFIG_WERROR       := @werror@
 CONFIG_RUMP         := @CONFIG_RUMP@
 ifeq ($(CONFIG_RUMP),y)
 XEN_OS              := NetBSDRump
diff --git a/tools/configure b/tools/configure
index 41deb7fb96..acd9a04c3b 100755
--- a/tools/configure
+++ b/tools/configure
@@ -716,6 +716,7 @@ ocamltools
 monitors
 githttp
 rpath
+werror
 DEBUG_DIR
 XEN_DUMP_DIR
 XEN_PAGING_DIR
@@ -805,6 +806,7 @@ with_xen_scriptdir
 with_xen_dumpdir
 with_rundir
 with_debugdir
+enable_werror
 enable_rpath
 enable_githttp
 enable_monitors
@@ -1490,6 +1492,7 @@ Optional Features:
   --disable-FEATURE       do not include FEATURE (same as --enable-FEATURE=no)
   --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
   --disable-largefile     omit support for large files
+  --disable-werror        Build tools without -Werror (default is ENABLED)
   --enable-rpath          Build tools with -Wl,-rpath,LIBDIR (default is
                           DISABLED)
   --enable-githttp        Download GIT repositories via HTTP (default is
@@ -4111,6 +4114,29 @@ DEBUG_DIR=$debugdir_path
 
 # Enable/disable options
 
+# Check whether --enable-werror was given.
+if test "${enable_werror+set}" = set; then :
+  enableval=$enable_werror;
+fi
+
+
+if test "x$enable_werror" = "xno"; then :
+
+    ax_cv_werror="n"
+
+elif test "x$enable_werror" = "xyes"; then :
+
+    ax_cv_werror="y"
+
+elif test -z $ax_cv_werror; then :
+
+    ax_cv_werror="y"
+
+fi
+werror=$ax_cv_werror
+
+
+
 # Check whether --enable-rpath was given.
 if test "${enable_rpath+set}" = set; then :
   enableval=$enable_rpath;
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422021.667823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu1-0002Rp-4Q; Thu, 13 Oct 2022 13:05:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422021.667823; Thu, 13 Oct 2022 13:05:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu1-0002Rh-0a; Thu, 13 Oct 2022 13:05:33 +0000
Received: by outflank-mailman (input) for mailman id 422021;
 Thu, 13 Oct 2022 13:05:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixtz-0001tl-Qt
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:31 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8f303d8-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8f303d8-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666330;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Z1eIfm9TeIHBAfveoFRjwLU6/76BD/iLNFWSVEzbNJ4=;
  b=Y5igjEucz41YXW/bLXIG7Y+mq/LMV+UeDdUYVKPpY8b99CrMN6DlylYx
   0+DkEZghdQzWUeYlkdY9tOMN1uQ68gHxIWsGZ0jBi8UiHidEA4/UXxorp
   1fIlpv9XY4ILsknrvBayq+WxN4QoJekbW165vg8mKId0DNtxfmfWONLcP
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82281609
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+t8nVa2adLHgrC3tU/bD5c5xkn2cJEfYwER7XKvMYLTBsI5bpzwOm
 zNODz2BO6veMWbzfYsjYYqwoEgEsJ6GxtVkSQFlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpD5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUI+exxKGIS+
 MYxEzQCdjGZmcLxxL2CH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqPIIzTG50E9qqej
 j/D1ET2XjY6CMyO+Sea736n2v7EoBquDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWQdVEI
 VYT/Skohac3/U2vCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcWSDowx
 xm2ltXmLTV1tfueTnf1y1uPhWrsY25PdzZEPHJaC1teizX+nG0tpgLMRNBKE/K4tPTOHT7o4
 iqUjG86iIxG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5
 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezP
 Sc/WisLvve/2UdGiocmC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyz/xhY
 c/DKZjzVCxy5UFbIN2eHr517FPW7npmmTO7qW7TlXxLLoZylFbKEOxYYTNin8gy7b+eoRW9z
 uuzw/CikkwHONASlwGNrub/23hWciVgbX03wuQLHtO+zv1OQT1xVqCAn+17JuSIXc19z4/1w
 510YWcAoHKXuJENAV/ihqxLAF83YatCkA==
IronPort-HdrOrdr: A9a23:N6/a+qsMkMJW69gRaC2GH9T37skDcNV00zEX/kB9WHVpmszxra
 +TdZMgpHjJYVcqKQgdcL+7WZVoLUmwyXcx2/hyAV7AZniDhILLFuFfBOLZqlWKcREWtNQtsJ
 uIG5IObuEYZmIVsS+V2mWF+q4bsbq6zJw=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82281609"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Nick Rosbrook <rosbrookn@gmail.com>
Subject: [XEN PATCH for-4.17 v5 03/17] tools: Introduce $(xenlibs-ldflags, ) macro
Date: Thu, 13 Oct 2022 14:04:59 +0100
Message-ID: <20221013130513.52440-4-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This avoid the need to open-coding the list of flags needed to link
with an in-tree Xen library when using -lxen*.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Henry Wang <Henry.Wang@arm.com>
---

Notes:
    missing-ack: GOLANG BINDINGS

 tools/golang/xenlight/Makefile | 2 +-
 tools/Rules.mk                 | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
index 64671f246c..00e6d17f2b 100644
--- a/tools/golang/xenlight/Makefile
+++ b/tools/golang/xenlight/Makefile
@@ -27,7 +27,7 @@ GOXL_GEN_FILES = types.gen.go helpers.gen.go
 # so that it can find the actual library.
 .PHONY: build
 build: xenlight.go $(GOXL_GEN_FILES)
-	CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -L$(XEN_libxenlight) -L$(XEN_libxentoollog) $(APPEND_LDFLAGS)" $(GO) build -x
+	CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) $(APPEND_LDFLAGS)" $(GO) build -x
 
 .PHONY: install
 install: build
diff --git a/tools/Rules.mk b/tools/Rules.mk
index ce77dd2eb1..26958b2948 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -105,6 +105,14 @@ define xenlibs-ldlibs
     $(foreach lib,$(1),$(xenlibs-ldlibs-$(lib)))
 endef
 
+# Provide needed flags for linking an in-tree Xen library by an external
+# project (or when it is necessary to link with "-lxen$(1)" instead of using
+# the full path to the library).
+define xenlibs-ldflags
+    $(call xenlibs-rpath,$(1)) \
+    $(foreach lib,$(1),-L$(XEN_ROOT)/tools/libs/$(lib))
+endef
+
 define LIB_defs
  FILENAME_$(1) ?= xen$(1)
  XEN_libxen$(1) = $$(XEN_ROOT)/tools/libs/$(1)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422022.667834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu4-0002lI-Dm; Thu, 13 Oct 2022 13:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422022.667834; Thu, 13 Oct 2022 13:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu4-0002l6-AD; Thu, 13 Oct 2022 13:05:36 +0000
Received: by outflank-mailman (input) for mailman id 422022;
 Thu, 13 Oct 2022 13:05:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu2-0001tl-A9
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:34 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aaab2a2c-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:11 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaab2a2c-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666333;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=T3wLDMvbCGyUm6GzXD79EfIEyV5ODCruMFeaxkCe9VE=;
  b=WsZLPhToWjgrBCg3JpX+NIY3/fxBY3e5nr4mJlYZeT+/PF8aiYppnQiR
   npM4SszcL3ml5VouJ7Fqke1z/U6qpCd9YisulX+7FIorfclxJeHHz8VEx
   mdxogVyhP/0tpfK09uqN87QFk0JhzdXWjQ1IVwG02/Ds3J0cAmBnHEs/M
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81760194
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ObRFwqrMkzW0IdVUJtHsmJ3ByXxeBmI/ZRIvgKrLsJaIsI4StFCzt
 garIBnTaPnYZTf9eYgiYY2yoBhXv5LTnNcwTApo/iFkF3wW9JuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgS5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6
 qYqFXMpNBm6ldmkm56qSNldhNozBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP
 YxDM2MpNUmeJU0UUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0FxxnG/
 juXowwVBDkFKtrE5SCB9Ui8j+3jlyHeZIEWJr2Ro6sCbFq7mTVIVUx+uUGAifS9h0i3Hc9RK
 kkI4ScwpIA17kWgStS7VBq9yFabujYMVtwWFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHmLmIQnvb+L6Spj62PTU9JHUHIyQDSGM4D8LL+d9pyEiVF5A6TfDz3oad9SzML
 y6is3IMuvY318cyxZ6ppnzWgQKdpIbZZ1tgjunIZV6N4gR8bY+jQoWn71nH8PpNRLqkokm9U
 GsswJbHsr1XZX2ZvGnUGbhWQun1jxqQGGeE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O
 RSD0e+9CXI6AZdLUUOVS9jsYyjJ5fK6fTgAahwzRosmX3SJXFXblByCnGbJt4wXrGAikLskJ
 bCQetu2AHARBMxPlWToGrlFiedzmH9nnws/oKwXKDz+iNKjiIO9E+9ZYDNikMhjhE97nOkl2
 4kGbJbbo/mueOb/fjPW4eYuELz+FlBiXMieliCiXrTcSuaQMD1+VqS5LHJIU9ANopm5Yc+Ro
 iHgBR4GlgCi7ZAFQC3TAk1ehHrUdc4XhRoG0eYEYz5EB1BLjV6T0Zoi
IronPort-HdrOrdr: A9a23:rAEvH6zEZS6GO8WNncLpKrPwKr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ
 0QFZSWY+efMbEVt6rHCXGDYrUd/OU=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81760194"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Luca Fancellu
	<luca.fancellu@arm.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, "Wei
 Liu" <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 01/17] tools/debugger/gdbsx: Fix and cleanup makefiles
Date: Thu, 13 Oct 2022 14:04:57 +0100
Message-ID: <20221013130513.52440-2-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

gdbsx/:
  - Make use of subdir facility for the "clean" target.
  - No need to remove the *.a, they aren't in this dir.
  - Avoid calling "distclean" in subdirs as "distclean" targets do only
    call "clean", and the "clean" also runs "clean" in subdirs.
  - Avoid the need to make "gx_all.a" and "xg_all.a" in the "all"
    recipe by forcing make to check for update of "xg/xg_all.a" and
    "gx/gx_all.a" by having "FORCE" as prerequisite. Now, when making
    "gdbsx", make will recurse even when both *.a already exist.
  - List target in $(TARGETS).

gdbsx/*/:
  - Fix dependency on *.h.
  - Remove some dead code.
  - List targets in $(TARGETS).
  - Remove "build" target.
  - Cleanup "clean" targets.
  - remove comments about the choice of "ar" instead of "ld"
  - Use "$(AR)" instead of plain "ar".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---

Notes:
    missing-ack: GDBSX DEBUGGER
    
    v2:
    - also replace plain "ar" by "$(AR)"

 tools/debugger/gdbsx/Makefile    | 20 ++++++++++----------
 tools/debugger/gdbsx/gx/Makefile | 15 +++++++--------
 tools/debugger/gdbsx/xg/Makefile | 25 +++++++------------------
 3 files changed, 24 insertions(+), 36 deletions(-)

diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
index 5571450a89..4aaf427c45 100644
--- a/tools/debugger/gdbsx/Makefile
+++ b/tools/debugger/gdbsx/Makefile
@@ -1,20 +1,20 @@
 XEN_ROOT = $(CURDIR)/../../..
 include ./Rules.mk
 
+SUBDIRS-y += gx
+SUBDIRS-y += xg
+
+TARGETS := gdbsx
+
 .PHONY: all
-all:
-	$(MAKE) -C gx
-	$(MAKE) -C xg
-	$(MAKE) gdbsx
+all: $(TARGETS)
 
 .PHONY: clean
-clean:
-	rm -f xg_all.a gx_all.a gdbsx
-	set -e; for d in xg gx; do $(MAKE) -C $$d clean; done
+clean: subdirs-clean
+	rm -f $(TARGETS)
 
 .PHONY: distclean
 distclean: clean
-	set -e; for d in xg gx; do $(MAKE) -C $$d distclean; done
 
 .PHONY: install
 install: all
@@ -28,7 +28,7 @@ uninstall:
 gdbsx: gx/gx_all.a xg/xg_all.a 
 	$(CC) $(LDFLAGS) -o $@ $^
 
-xg/xg_all.a:
+xg/xg_all.a: FORCE
 	$(MAKE) -C xg
-gx/gx_all.a:
+gx/gx_all.a: FORCE
 	$(MAKE) -C gx
diff --git a/tools/debugger/gdbsx/gx/Makefile b/tools/debugger/gdbsx/gx/Makefile
index 3b8467f799..e9859aea9c 100644
--- a/tools/debugger/gdbsx/gx/Makefile
+++ b/tools/debugger/gdbsx/gx/Makefile
@@ -2,21 +2,20 @@ XEN_ROOT = $(CURDIR)/../../../..
 include ../Rules.mk
 
 GX_OBJS := gx_comm.o gx_main.o gx_utils.o gx_local.o
-GX_HDRS := $(wildcard *.h)
+
+TARGETS := gx_all.a
 
 .PHONY: all
-all: gx_all.a
+all: $(TARGETS)
 
 .PHONY: clean
 clean:
-	rm -rf gx_all.a *.o .*.d
+	rm -f *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
 
-#%.o: %.c $(GX_HDRS) Makefile
-#	$(CC) -c $(CFLAGS) -o $@ $<
-
-gx_all.a: $(GX_OBJS) Makefile $(GX_HDRS)
-	ar cr $@ $(GX_OBJS)        # problem with ld using -m32 
+gx_all.a: $(GX_OBJS) Makefile
+	$(AR) cr $@ $(GX_OBJS)
 
+-include $(DEPS_INCLUDE)
diff --git a/tools/debugger/gdbsx/xg/Makefile b/tools/debugger/gdbsx/xg/Makefile
index acdcddf0d5..05325d6d81 100644
--- a/tools/debugger/gdbsx/xg/Makefile
+++ b/tools/debugger/gdbsx/xg/Makefile
@@ -1,35 +1,24 @@
 XEN_ROOT = $(CURDIR)/../../../..
 include ../Rules.mk
 
-XG_HDRS := xg_public.h 
 XG_OBJS := xg_main.o 
 
 CFLAGS += -D__XEN_TOOLS__
 CFLAGS += $(CFLAGS_xeninclude)
 
+TARGETS := xg_all.a
 
 .PHONY: all
-all: build
+all: $(TARGETS)
 
-.PHONY: build
-build: xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
-# build: mk-symlinks xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
-# build: mk-symlinks xg_all.a
-
-xg_all.a: $(XG_OBJS) Makefile $(XG_HDRS)
-	ar cr $@ $(XG_OBJS)    # problems using -m32 in ld 
-#	$(LD) -b elf32-i386 $(LDFLAGS) -r -o $@ $^
-#	$(CC) -m32 -c -o $@ $^
-
-# xg_main.o: xg_main.c Makefile $(XG_HDRS)
-#$(CC) -c $(CFLAGS) -o $@ $<
-
-# %.o: %.c $(XG_HDRS) Makefile  -- doesn't work as it won't overwrite Rules.mk
-#%.o: %.c       -- doesn't recompile when .c changed
+xg_all.a: $(XG_OBJS) Makefile
+	$(AR) cr $@ $(XG_OBJS)
 
 .PHONY: clean
 clean:
-	rm -rf xen xg_all.a $(XG_OBJS)  .*.d
+	rm -f $(TARGETS) $(XG_OBJS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
+
+-include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422023.667838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu4-0002ok-R3; Thu, 13 Oct 2022 13:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422023.667838; Thu, 13 Oct 2022 13:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu4-0002nt-Kr; Thu, 13 Oct 2022 13:05:36 +0000
Received: by outflank-mailman (input) for mailman id 422023;
 Thu, 13 Oct 2022 13:05:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu2-0002ig-Rg
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:34 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b7dd6bdc-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:33 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7dd6bdc-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666333;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=WWgKKsGpMO0s5/MpdnydWA9yplEqj5PrJ/SuQ+hxLac=;
  b=IbDVdYonQ1rY086uNpaZFRLbchMY59nKYzA0B0/bmIVcyUla2H4rVXt1
   JZNpz4+cV6jl0Ir200+sE5JktsFzVGx19vwrJualU1vMEmP+22KTUH3KC
   JWT9ute2duXzM/KIO7l1V5qjpNLTER0NZCJX3Y2REbmqpQR4gTaSQkpK0
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 83071509
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fniIGqq1F94H0HWV26B5WFdV/DxeBmJyZRIvgKrLsJaIsI4StFCzt
 garIBmPaP6NYWL3eIp1YNyxoUsE7MPcndFjTgBtpC5jH3kRoJuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgS5weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0
 +xIEQofYyG5heON6r+bEsBnu/YMFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP
 YxDM2MpNUmeJU0UUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0FxR7H/
 z+ergwVBDkjE4C74jWO3EiwuerOsTPiBaMKH5uno6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM
 UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BIyw/iYeHREOn9Lavhz6SYQEeEF0tXHpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql
 ChVwpPOhAzi4HzkqcBsfAnvNOv0jxpmGGeG6bKKI3XG32XFxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtzvVppylfC4S4u8DJg4i+aihbAoLWe6ENxGPxbMjwgBbmB2+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHMiT8vhS+eDBDJJjYetabQDmgyFQxP/snTg5B
 P4Ga5vXlEQBDrejCsQVmKZKRW03wbEALcieg6RqmiSreWKKxElJ5yft/I4c
IronPort-HdrOrdr: A9a23:qMlW6a0MORSMniSv4TZrTQqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="83071509"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 06/17] tools/hotplug: Generate "hotplugpath.sh" with configure
Date: Thu, 13 Oct 2022 14:05:02 +0100
Message-ID: <20221013130513.52440-7-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/configure.ac                     |  1 +
 tools/hotplug/common/Makefile          | 10 ++--------
 tools/configure                        |  3 ++-
 tools/hotplug/common/hotplugpath.sh.in | 16 ++++++++++++++++
 4 files changed, 21 insertions(+), 9 deletions(-)
 create mode 100644 tools/hotplug/common/hotplugpath.sh.in

diff --git a/tools/configure.ac b/tools/configure.ac
index 09059bc569..18e481d77e 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -7,6 +7,7 @@ AC_INIT([Xen Hypervisor Tools], m4_esyscmd([../version.sh ../xen/Makefile]),
 AC_CONFIG_SRCDIR([libs/light/libxl.c])
 AC_CONFIG_FILES([
 ../config/Tools.mk
+hotplug/common/hotplugpath.sh
 hotplug/FreeBSD/rc.d/xencommons
 hotplug/FreeBSD/rc.d/xendriverdomain
 hotplug/Linux/init.d/sysconfig.xencommons
diff --git a/tools/hotplug/common/Makefile b/tools/hotplug/common/Makefile
index e8a8dbea6c..62afe1019e 100644
--- a/tools/hotplug/common/Makefile
+++ b/tools/hotplug/common/Makefile
@@ -1,19 +1,14 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-HOTPLUGPATH := hotplugpath.sh
-
 # OS-independent hotplug scripts go in this directory
 
 # Xen scripts to go there.
 XEN_SCRIPTS :=
-XEN_SCRIPT_DATA := $(HOTPLUGPATH)
-
-genpath-target = $(call buildmakevars2file,$(HOTPLUGPATH))
-$(eval $(genpath-target))
+XEN_SCRIPT_DATA := hotplugpath.sh
 
 .PHONY: all
-all: $(HOTPLUGPATH)
+all:
 
 .PHONY: install
 install: install-scripts
@@ -40,7 +35,6 @@ uninstall-scripts:
 
 .PHONY: clean
 clean:
-	rm -f $(HOTPLUGPATH)
 
 .PHONY: distclean
 distclean: clean
diff --git a/tools/configure b/tools/configure
index acd9a04c3b..6199823f5a 100755
--- a/tools/configure
+++ b/tools/configure
@@ -2456,7 +2456,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
 
 
 
-ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/libs/xs/paths.ml ocaml/xenstored/paths.ml ocaml/xenstored/oxenstored.conf"
+ac_config_files="$ac_config_files ../config/Tools.mk hotplug/common/hotplugpath.sh hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/libs/xs/paths.ml ocaml/xenstored/paths.ml ocaml/xenstored/oxenstored.conf"
 
 ac_config_headers="$ac_config_headers config.h"
 
@@ -10947,6 +10947,7 @@ for ac_config_target in $ac_config_targets
 do
   case $ac_config_target in
     "../config/Tools.mk") CONFIG_FILES="$CONFIG_FILES ../config/Tools.mk" ;;
+    "hotplug/common/hotplugpath.sh") CONFIG_FILES="$CONFIG_FILES hotplug/common/hotplugpath.sh" ;;
     "hotplug/FreeBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xencommons" ;;
     "hotplug/FreeBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xendriverdomain" ;;
     "hotplug/Linux/init.d/sysconfig.xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xencommons" ;;
diff --git a/tools/hotplug/common/hotplugpath.sh.in b/tools/hotplug/common/hotplugpath.sh.in
new file mode 100644
index 0000000000..1036b884b8
--- /dev/null
+++ b/tools/hotplug/common/hotplugpath.sh.in
@@ -0,0 +1,16 @@
+sbindir="@sbindir@"
+bindir="@bindir@"
+LIBEXEC="@LIBEXEC@"
+LIBEXEC_BIN="@LIBEXEC_BIN@"
+libdir="@libdir@"
+SHAREDIR="@SHAREDIR@"
+XENFIRMWAREDIR="@XENFIRMWAREDIR@"
+XEN_CONFIG_DIR="@XEN_CONFIG_DIR@"
+XEN_SCRIPT_DIR="@XEN_SCRIPT_DIR@"
+XEN_LOCK_DIR="@XEN_LOCK_DIR@"
+XEN_RUN_DIR="@XEN_RUN_DIR@"
+XEN_PAGING_DIR="@XEN_PAGING_DIR@"
+XEN_DUMP_DIR="@XEN_DUMP_DIR@"
+XEN_LOG_DIR="@XEN_LOG_DIR@"
+XEN_LIB_DIR="@XEN_LIB_DIR@"
+XEN_RUN_STORED="@XEN_RUN_STORED@"
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422024.667848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu5-00032L-GI; Thu, 13 Oct 2022 13:05:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422024.667848; Thu, 13 Oct 2022 13:05:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu5-00030Z-BL; Thu, 13 Oct 2022 13:05:37 +0000
Received: by outflank-mailman (input) for mailman id 422024;
 Thu, 13 Oct 2022 13:05:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu3-0001tl-Ba
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:35 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac1cb305-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:12 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac1cb305-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666334;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=8abatJda7PXTHwPpPZRvwgJsTqH6k0O1FgQ7vtYYApo=;
  b=DHiU92MvGgVd4nu8bXooK/VdZlo511Arig3g7HFdTBMS+uEeet6ZwT22
   tx1O0DWsNWxqeqcrsbDHDQoixLZAqc7XfN4rSxqOi9Wv4U2052YqpdHPS
   jJR9x4kvX5XvONtrM9VnhE+mqvsPaVegbyFE1ZoBuzXNv2wCLuXDV6VHR
   c=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81760196
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Np5mHqssR2UEbPmMGTgT3ARxm+fnVDxeMUV32f8akzHdYApBsoF/q
 tZmKW+Fa/uJYjP8ft4kbI7ioUoC65OBnINrTlQ9+3tkFiwa+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakQ5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklRr
 84laxRXZymRvPDt7KO5ethumNQKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI
 ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUMwRjA/
 zOYl4j/Kk8ZM9zGlAqOy0uLn7Lum2TGB9sRPbLto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ
 CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCopc4+C7AWDJCFGQYLoV76olmHlTGy
 2Nlgfv2Xw5S85nPQEuPzaXPgSKwCRkXM38rMHpsoRQ+3/Hvp4Q6jxTqR9llEbKogtCdJQwc0
 wxmvwBl2exN0JdjO7GTuAme3mny/sShohsdvF2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclRuzBCxWtame0bbtT834JplyQF4aLJ9w43d2HDB4B3jw4UTHoe
 lTPngha+YVeOnCnBYcuPdzsVZxylfC+So2/PhwxUjapSsEoHDJrAQk0PRLAt4wTuBJEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqKHfjGI+GPi+X2iIi9FehYazNjr4kRsMu5neki2
 48DZ5bVmksBCrCWj+u+2dd7EG3m5EMTXfjew/G7vMbdSua6MAnN08Ps/I4=
IronPort-HdrOrdr: A9a23:bZ/OZathSTYiW2Ym2xQiS2ts7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81760196"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 02/17] tools/xentrace: rework Makefile
Date: Thu, 13 Oct 2022 14:04:58 +0100
Message-ID: <20221013130513.52440-3-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove "build" targets.

Use "$(TARGETS)" to list binary to be built.

Cleanup "clean" rule.

Also drop conditional install of $(BIN) and $(LIBBIN) as those two
variables are now always populated.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    missing-ack: XENTRACE
    
    v4:
    - also use := for BIN, SBIN, LIBBIN, SCRIPTS
    
    v2:
    - fix typo in title
    - drop conditional install of $(BIN) and $(LIBBIN)

 tools/xentrace/Makefile | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 9fb7fc96e7..63f2f6532d 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -9,41 +9,36 @@ LDLIBS += $(LDLIBS_libxenevtchn)
 LDLIBS += $(LDLIBS_libxenctrl)
 LDLIBS += $(ARGP_LDFLAGS)
 
-BIN      = xenalyze
-SBIN     = xentrace xentrace_setsize
-LIBBIN   = xenctx
-SCRIPTS  = xentrace_format
+BIN     := xenalyze
+SBIN    := xentrace xentrace_setsize
+LIBBIN  := xenctx
+SCRIPTS := xentrace_format
 
-.PHONY: all
-all: build
+TARGETS := $(BIN) $(SBIN) $(LIBBIN)
 
-.PHONY: build
-build: $(BIN) $(SBIN) $(LIBBIN)
+.PHONY: all
+all: $(TARGETS)
 
 .PHONY: install
-install: build
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(bindir)
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
-	[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-ifneq ($(BIN),)
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
-endif
 	$(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir)
 	$(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
-	[ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
 
 .PHONY: uninstall
 uninstall:
 	rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(LIBBIN))
 	rm -f $(addprefix $(DESTDIR)$(bindir)/, $(SCRIPTS))
 	rm -f $(addprefix $(DESTDIR)$(sbindir)/, $(SBIN))
-ifneq ($(BIN),)
 	rm -f $(addprefix $(DESTDIR)$(bindir)/, $(BIN))
-endif
 
 .PHONY: clean
 clean:
-	$(RM) *.a *.so *.o *.rpm $(BIN) $(SBIN) $(LIBBIN) $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422025.667854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu6-00038o-1p; Thu, 13 Oct 2022 13:05:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422025.667854; Thu, 13 Oct 2022 13:05:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu5-00036z-Po; Thu, 13 Oct 2022 13:05:37 +0000
Received: by outflank-mailman (input) for mailman id 422025;
 Thu, 13 Oct 2022 13:05:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu3-0002ig-Oe
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:35 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b87e2103-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b87e2103-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666334;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=4HJ6zZu2n6v+FIEsm8kbGG2N7wL5T8JT/E4hq3TeoGM=;
  b=PGxxjbx5qpDybNK83Kf/YmGlUbwdBv2nbj4HLTmIRbcY2Nwzp+NZ5lhO
   wWhNAttnBwZdUcvOoOMLC7fi02Ke5Jy0pRXndYagw7MaKC8DX3bLqgBjw
   lpTBSdHjJVaryl24B+wOdd+i4C/FX243/vgjGIrzg0x7IT35ms2xvO0Zf
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82635803
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:26+T5aOR6jYbhSnvrR2gl8FynXyQoLVcMsEvi/4bfWQNrUpw02MDz
 TYZCGrSOPeKZ2vwfNl1a9nj9B8Ou8CBz4JqGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr42tB1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eGM5Gy81YIkx33
 N84DxEVYR+p2OWc+efuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI
 ZpCAdZsRE2ojxlnM1ELCJU4jaGwi2P2aTFwo1OJv6snpWPUyWSd1ZC9aoSOJ4zSHq25mG61j
 VOd80HFWCg8G9fF0hm08GmTv/P2yHaTtIU6S+Tjq68CbEeo7m4cEhoNTnOgvOK0zEW5Xrp3N
 Eg86ico668o+ySDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1q4temlhhyRFBE8Dk8lRDcLQiFa5PPa9dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZRPtbNWmC+1bTMAR+sxq69R0LJg
 nULktP2AAsmXcDUz3zlrAng8diUCxe53N/02wMH83oJrW7FF5ufkWd4sVlDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4q4CKiMNoIQPcErHONiwM2JTRfJt10BbWB2yf1vU
 XtlWZzE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa3GI+Cc+ePHPBaopUItagTmghYRsPzZ+204M
 r93a6O39vmoeLSiMnSIoNBNdw1iwLpSLcmelvG7v9WremJOcFzNwdeIqV/9U+SJR5hoq9o=
IronPort-HdrOrdr: A9a23:kYHX/6jxO7tncbDcChcbUVRMyHBQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82635803"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 07/17] libs/light/gentypes.py: allow to generate headers in subdirectory
Date: Thu, 13 Oct 2022 14:05:03 +0100
Message-ID: <20221013130513.52440-8-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This doesn't matter yet but it will when for example the script will
be run from tools/ to generate files tools/libs/light/.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/libs/light/gentypes.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py
index 9a45e45acc..3fe3873242 100644
--- a/tools/libs/light/gentypes.py
+++ b/tools/libs/light/gentypes.py
@@ -584,6 +584,9 @@ def libxl_C_enum_from_string(ty, str, e, indent = "    "):
         s = indent + s
     return s.replace("\n", "\n%s" % indent).rstrip(indent)
 
+def clean_header_define(header_path):
+    return header_path.split('/')[-1].upper().replace('.','_')
+
 
 if __name__ == '__main__':
     if len(sys.argv) != 6:
@@ -598,7 +601,7 @@ if __name__ == '__main__':
 
     f = open(header, "w")
 
-    header_define = header.upper().replace('.','_')
+    header_define = clean_header_define(header)
     f.write("""#ifndef %s
 #define %s
 
@@ -648,7 +651,7 @@ if __name__ == '__main__':
 
     f = open(header_json, "w")
 
-    header_json_define = header_json.upper().replace('.','_')
+    header_json_define = clean_header_define(header_json)
     f.write("""#ifndef %s
 #define %s
 
@@ -672,7 +675,7 @@ if __name__ == '__main__':
 
     f = open(header_private, "w")
 
-    header_private_define = header_private.upper().replace('.','_')
+    header_private_define = clean_header_define(header_private)
     f.write("""#ifndef %s
 #define %s
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422026.667873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu7-0003d7-LN; Thu, 13 Oct 2022 13:05:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422026.667873; Thu, 13 Oct 2022 13:05:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu7-0003bu-Bn; Thu, 13 Oct 2022 13:05:39 +0000
Received: by outflank-mailman (input) for mailman id 422026;
 Thu, 13 Oct 2022 13:05:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu5-0002ig-8s
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:37 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b86794fd-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b86794fd-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666334;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=fByF2mcq28wVi1Amh4dLPZdKDXEHMuCNAEVl/F7+Z3I=;
  b=Qua84ySrGbww45o2pwJ0DJlISpKg0q09pA9vEmGO/HS7AlnGIAhYZxsF
   +qPjDwRuQ+f2HRk66ZU9wp82t2Fsg0iTaj/U8LzDRVB/ISdZ1GrWfmIkQ
   xP/1WHlhXFO2ICZAtP8bHgg0cduXbmHFgN++DR5bqUfhSlud2pSbePck4
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81760216
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XMomuaCm3E3qlhVW/9fjw5YqxClBgxIJ4kV8jS/XYbTApGwnhTdRy
 mFLUGCFPP2MNmv8L49wa4vlpBsDuJ7cx95iQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2p4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kzbKMl3eJ7BloQt
 u0DEzYSNT2zluyPlefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN
 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oi0b4SNIIXULSlTtmGgu
 TzpomPaOEpELMSe+QaEzmy2peCayEsXX6pNTeblp5aGmma7xGMJDwYNfUCmuvT/gUm7M/pDK
 kk86ico668o+ySDTMT5XhC+iG6JuFgbQdU4O+Ez9gyl0Kff5AedQG8eQVZpZdgrssZwWDIr0
 0OSks3gLTt1ubaRRDSW8bL8hT+qIi0UMW8qbDcJVxcY+MLkpJwvjxXJVZBoF6vdps34H3T8z
 i6HqAA6hq4Plogb2qOj51fFjjmw4J/TQWYd+QH/Tm+jqARja+aNZYal9Fza5vZoN5uCQx+Ku
 31spiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqVs+MaQG8ziqwCDgbJtr5i4lCXd4PP9RLFcFf
 3TvkQ9W4ZZSOl6jYql2f5+9BqwW8ETwKTj2fquKN4QTO/CdYCfCpXgzPhDIgwgBhWB2yckC1
 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59fbTNijchjtstoRTk5F
 P4OX/ZmMz0FDIXDjtD/qOb/12wiI3khHozRoMdKbOOFKQcOMDh/VaKPmet5I9I6xv49egL0E
 paVAxYw9bYCrSefdVXiho5LMtsDoqqTXVpkZHdxbD5EKlAoYJq17bd3SqbbiYIPrbU7pcOYu
 tFfJK1s9NwTFWmck9ncBLGhxLFfmOOD3F7eYnX0PmZlIvaNhWXho7fZQ+cmzwFWZgLfiCf0i
 +fIOt/zKXbbezlfMQ==
IronPort-HdrOrdr: A9a23:QhIfba39i0qA8BqVmK/JHwqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81760216"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, "Daniel P . Smith"
	<dpsmith@apertussolutions.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Tim Deegan
	<tim@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, David Scott <dave@recoil.org>, Julien Grall
	<julien@xen.org>, George Dunlap <george.dunlap@citrix.com>
Subject: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere else
Date: Thu, 13 Oct 2022 14:05:01 +0100
Message-ID: <20221013130513.52440-6-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Patch "tools: Add -Werror by default to all tools/" have added
"-Werror" to CFLAGS in tools/Rules.mk, remove it from every other
makefiles as it is now duplicated.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
Acked-by: Daniel P. Smith <dpsmith@apertussolutions.com> # tools/flask
Acked-by: Jan Beulich <jbeulich@suse.com> # tools/*/cpu-policy
---

Notes:
    missing-ack:
    - GDBSX DEBUGGER
    - KDD DEBUGGER
    - XENTRACE

 tools/console/client/Makefile   | 1 -
 tools/console/daemon/Makefile   | 1 -
 tools/debugger/kdd/Makefile     | 1 -
 tools/flask/utils/Makefile      | 1 -
 tools/fuzz/cpu-policy/Makefile  | 2 +-
 tools/misc/Makefile             | 1 -
 tools/tests/cpu-policy/Makefile | 2 +-
 tools/tests/depriv/Makefile     | 2 +-
 tools/tests/resource/Makefile   | 1 -
 tools/tests/tsx/Makefile        | 1 -
 tools/tests/xenstore/Makefile   | 1 -
 tools/xcutils/Makefile          | 2 --
 tools/xenmon/Makefile           | 1 -
 tools/xenpaging/Makefile        | 1 -
 tools/xenpmd/Makefile           | 1 -
 tools/xentop/Makefile           | 2 +-
 tools/xentrace/Makefile         | 2 --
 tools/xl/Makefile               | 2 +-
 tools/debugger/gdbsx/Rules.mk   | 2 +-
 tools/firmware/Rules.mk         | 2 --
 tools/libfsimage/common.mk      | 2 +-
 tools/libs/libs.mk              | 2 +-
 tools/ocaml/common.make         | 2 +-
 tools/xenstore/Makefile.common  | 1 -
 24 files changed, 9 insertions(+), 27 deletions(-)

diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
index e2f2554f92..62d89fdeb9 100644
--- a/tools/console/client/Makefile
+++ b/tools/console/client/Makefile
@@ -1,7 +1,6 @@
 XEN_ROOT=$(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 CFLAGS += $(CFLAGS_libxenstore)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
diff --git a/tools/console/daemon/Makefile b/tools/console/daemon/Makefile
index 99bb33b6a2..9fc3b6711f 100644
--- a/tools/console/daemon/Makefile
+++ b/tools/console/daemon/Makefile
@@ -1,7 +1,6 @@
 XEN_ROOT=$(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 CFLAGS += $(CFLAGS_libxenstore)
 CFLAGS += $(CFLAGS_libxenevtchn)
diff --git a/tools/debugger/kdd/Makefile b/tools/debugger/kdd/Makefile
index 26116949d4..a72ad3b1e0 100644
--- a/tools/debugger/kdd/Makefile
+++ b/tools/debugger/kdd/Makefile
@@ -1,7 +1,6 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS  += -Werror
 CFLAGS  += $(CFLAGS_libxenctrl)
 CFLAGS  += -DXC_WANT_COMPAT_MAP_FOREIGN_API
 LDLIBS  += $(LDLIBS_libxenctrl)
diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile
index 6be134142a..88d7edb6b1 100644
--- a/tools/flask/utils/Makefile
+++ b/tools/flask/utils/Makefile
@@ -1,7 +1,6 @@
 XEN_ROOT=$(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 
 TARGETS := flask-loadpolicy flask-setenforce flask-getenforce flask-label-pci flask-get-bool flask-set-bool
diff --git a/tools/fuzz/cpu-policy/Makefile b/tools/fuzz/cpu-policy/Makefile
index 41a2230408..6e7743e0aa 100644
--- a/tools/fuzz/cpu-policy/Makefile
+++ b/tools/fuzz/cpu-policy/Makefile
@@ -17,7 +17,7 @@ install: all
 
 .PHONY: uninstall
 
-CFLAGS += -Werror $(CFLAGS_xeninclude) -D__XEN_TOOLS__
+CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__
 CFLAGS += $(APPEND_CFLAGS) -Og
 
 vpath %.c ../../../xen/lib/x86
diff --git a/tools/misc/Makefile b/tools/misc/Makefile
index 0e02401227..1c6e1d6a04 100644
--- a/tools/misc/Makefile
+++ b/tools/misc/Makefile
@@ -1,7 +1,6 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 CFLAGS += $(CFLAGS_libxenevtchn)
diff --git a/tools/tests/cpu-policy/Makefile b/tools/tests/cpu-policy/Makefile
index 93af9d76fa..c5b81afc71 100644
--- a/tools/tests/cpu-policy/Makefile
+++ b/tools/tests/cpu-policy/Makefile
@@ -36,7 +36,7 @@ install: all
 uninstall:
 	$(RM) -- $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/,$(TARGETS))
 
-CFLAGS += -Werror -D__XEN_TOOLS__
+CFLAGS += -D__XEN_TOOLS__
 CFLAGS += $(CFLAGS_xeninclude)
 CFLAGS += $(APPEND_CFLAGS)
 
diff --git a/tools/tests/depriv/Makefile b/tools/tests/depriv/Makefile
index 3cba28da25..7d9e3b01bb 100644
--- a/tools/tests/depriv/Makefile
+++ b/tools/tests/depriv/Makefile
@@ -1,7 +1,7 @@
 XEN_ROOT=$(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror -Wno-declaration-after-statement
+CFLAGS += -Wno-declaration-after-statement
 
 CFLAGS += $(CFLAGS_xeninclude)
 CFLAGS += $(CFLAGS_libxenctrl)
diff --git a/tools/tests/resource/Makefile b/tools/tests/resource/Makefile
index b3cd70c06d..a5856bf095 100644
--- a/tools/tests/resource/Makefile
+++ b/tools/tests/resource/Makefile
@@ -27,7 +27,6 @@ install: all
 uninstall:
 	$(RM) -- $(DESTDIR)$(LIBEXEC_BIN)/$(TARGET)
 
-CFLAGS += -Werror
 CFLAGS += $(CFLAGS_xeninclude)
 CFLAGS += $(CFLAGS_libxenctrl)
 CFLAGS += $(CFLAGS_libxenforeginmemory)
diff --git a/tools/tests/tsx/Makefile b/tools/tests/tsx/Makefile
index d7d2a5d95e..a4f516b725 100644
--- a/tools/tests/tsx/Makefile
+++ b/tools/tests/tsx/Makefile
@@ -26,7 +26,6 @@ uninstall:
 .PHONY: uninstall
 uninstall:
 
-CFLAGS += -Werror
 CFLAGS += -I$(XEN_ROOT)/tools/libs/ctrl -I$(XEN_ROOT)/tools/libs/guest
 CFLAGS += $(CFLAGS_xeninclude)
 CFLAGS += $(CFLAGS_libxenctrl)
diff --git a/tools/tests/xenstore/Makefile b/tools/tests/xenstore/Makefile
index 239e1dce47..202dda0d3c 100644
--- a/tools/tests/xenstore/Makefile
+++ b/tools/tests/xenstore/Makefile
@@ -27,7 +27,6 @@ install: all
 uninstall:
 	$(RM) -- $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/,$(TARGETS))
 
-CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenstore)
 CFLAGS += $(APPEND_CFLAGS)
 
diff --git a/tools/xcutils/Makefile b/tools/xcutils/Makefile
index e40a2c4bfa..3687f6cd8f 100644
--- a/tools/xcutils/Makefile
+++ b/tools/xcutils/Makefile
@@ -13,8 +13,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 TARGETS := readnotes lsevtchn
 
-CFLAGS += -Werror
-
 CFLAGS_readnotes.o  := $(CFLAGS_libxenevtchn) $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest)
 CFLAGS_lsevtchn.o   := $(CFLAGS_libxenevtchn) $(CFLAGS_libxenctrl)
 
diff --git a/tools/xenmon/Makefile b/tools/xenmon/Makefile
index 3e150b0659..679c4b41a3 100644
--- a/tools/xenmon/Makefile
+++ b/tools/xenmon/Makefile
@@ -13,7 +13,6 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS  += -Werror
 CFLAGS  += $(CFLAGS_libxenevtchn)
 CFLAGS  += $(CFLAGS_libxenctrl)
 LDLIBS  += $(LDLIBS_libxenctrl)
diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
index e2ed9eaa3f..835cf2b965 100644
--- a/tools/xenpaging/Makefile
+++ b/tools/xenpaging/Makefile
@@ -12,7 +12,6 @@ OBJS-y   += xenpaging.o
 OBJS-y   += policy_$(POLICY).o
 OBJS-y   += pagein.o
 
-CFLAGS   += -Werror
 CFLAGS   += -Wno-unused
 
 TARGETS := xenpaging
diff --git a/tools/xenpmd/Makefile b/tools/xenpmd/Makefile
index e0d3f06ab2..8da20510b5 100644
--- a/tools/xenpmd/Makefile
+++ b/tools/xenpmd/Makefile
@@ -1,7 +1,6 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenstore)
 
 LDLIBS += $(LDLIBS_libxenstore)
diff --git a/tools/xentop/Makefile b/tools/xentop/Makefile
index 7bd96f34d5..70cc2211c5 100644
--- a/tools/xentop/Makefile
+++ b/tools/xentop/Makefile
@@ -13,7 +13,7 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -DGCC_PRINTF -Werror $(CFLAGS_libxenstat)
+CFLAGS += -DGCC_PRINTF $(CFLAGS_libxenstat)
 LDLIBS += $(LDLIBS_libxenstat) $(CURSES_LIBS) $(TINFO_LIBS) $(SOCKET_LIBS) -lm
 CFLAGS += -DHOST_$(XEN_OS)
 
diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 63f2f6532d..d50d400472 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -1,8 +1,6 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror
-
 CFLAGS += $(CFLAGS_libxenevtchn)
 CFLAGS += $(CFLAGS_libxenctrl)
 LDLIBS += $(LDLIBS_libxenevtchn)
diff --git a/tools/xl/Makefile b/tools/xl/Makefile
index b7f439121a..5f7aa5f46c 100644
--- a/tools/xl/Makefile
+++ b/tools/xl/Makefile
@@ -5,7 +5,7 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += -Werror -Wno-format-zero-length -Wmissing-declarations \
+CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
 CFLAGS += -fPIC
 
diff --git a/tools/debugger/gdbsx/Rules.mk b/tools/debugger/gdbsx/Rules.mk
index 920f1c87fb..0610db873b 100644
--- a/tools/debugger/gdbsx/Rules.mk
+++ b/tools/debugger/gdbsx/Rules.mk
@@ -1,6 +1,6 @@
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS   += -Werror -Wmissing-prototypes 
+CFLAGS   += -Wmissing-prototypes 
 # (gcc 4.3x and later)   -Wconversion -Wno-sign-conversion
 
 CFLAGS-$(clang) += -Wno-ignored-attributes
diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk
index 278cca01e4..d3482c9ec4 100644
--- a/tools/firmware/Rules.mk
+++ b/tools/firmware/Rules.mk
@@ -11,8 +11,6 @@ ifneq ($(debug),y)
 CFLAGS += -DNDEBUG
 endif
 
-CFLAGS += -Werror
-
 $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
 $(call cc-option-add,CFLAGS,CC,-fcf-protection=none)
diff --git a/tools/libfsimage/common.mk b/tools/libfsimage/common.mk
index 77bc957f27..4fc8c66795 100644
--- a/tools/libfsimage/common.mk
+++ b/tools/libfsimage/common.mk
@@ -2,7 +2,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 FSDIR := $(libdir)/xenfsimage
 CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"
-CFLAGS += -Werror -D_GNU_SOURCE
+CFLAGS += -D_GNU_SOURCE
 LDFLAGS += -L../common/
 
 PIC_OBJS = $(patsubst %.c,%.opic,$(LIB_SRCS-y))
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 2b8e7a6128..e47fb30ed4 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -14,7 +14,7 @@ MINOR ?= 0
 
 SHLIB_LDFLAGS += -Wl,--version-script=libxen$(LIBNAME).map
 
-CFLAGS   += -Werror -Wmissing-prototypes
+CFLAGS   += -Wmissing-prototypes
 CFLAGS   += $(CFLAGS_xeninclude)
 CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
 
diff --git a/tools/ocaml/common.make b/tools/ocaml/common.make
index d5478f626f..0c8a597d5b 100644
--- a/tools/ocaml/common.make
+++ b/tools/ocaml/common.make
@@ -9,7 +9,7 @@ OCAMLLEX ?= ocamllex
 OCAMLYACC ?= ocamlyacc
 OCAMLFIND ?= ocamlfind
 
-CFLAGS += -fPIC -Werror -I$(shell ocamlc -where)
+CFLAGS += -fPIC -I$(shell ocamlc -where)
 
 OCAMLOPTFLAG_G := $(shell $(OCAMLOPT) -h 2>&1 | sed -n 's/^  *\(-g\) .*/\1/p')
 OCAMLOPTFLAGS = $(OCAMLOPTFLAG_G) -ccopt "$(LDFLAGS)" -dtypes $(OCAMLINCLUDE) -cc $(CC) -w F -warn-error F
diff --git a/tools/xenstore/Makefile.common b/tools/xenstore/Makefile.common
index 21b78b0538..ddbac052ac 100644
--- a/tools/xenstore/Makefile.common
+++ b/tools/xenstore/Makefile.common
@@ -9,7 +9,6 @@ XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
 XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
 XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
 
-CFLAGS += -Werror
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 CFLAGS += -I./include
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422027.667881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu8-0003nL-Fk; Thu, 13 Oct 2022 13:05:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422027.667881; Thu, 13 Oct 2022 13:05:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixu7-0003kD-Vc; Thu, 13 Oct 2022 13:05:39 +0000
Received: by outflank-mailman (input) for mailman id 422027;
 Thu, 13 Oct 2022 13:05:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu5-0002ig-UJ
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:37 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9d1c306-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:36 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9d1c306-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666336;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=W6vCbrh65CqtneFRPKerc/tF+uYF6bBQ+treqeycw4E=;
  b=SGWnzbWl795oZfchXHCSe88gPRYftZsJ87Kjp2lJaEvtAdXBscoiDmiq
   5pbtffp1MIx0ZqujnKv93cpJtFWC62C9gjgNSCBVh0H+yK8TPQFXN2vnC
   N2hMxrEb5RxQDGHBpAnI4TokM5Fy3PLsPOOUZJQxd5WUFZKwmVAMuycMV
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82660726
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AO8z5oa6QIBiWaU9H14PguAxR2vbMJQxQLiYv2?=
 =?us-ascii?q?ybIWGNS2BzvzP5K+TjmH0vNjFa4fxt22/8FxV2p3KMkOC67Ar4lOsC3atGE9?=
 =?us-ascii?q?cPM/RmyDZ4Y+LPjuR6OhGYfSQBBz2fMjOQdUg4vbJtmBOWi4zEqUdqZzZT0i?=
 =?us-ascii?q?zEmbOWWRMqKXEOmWI3X6JvEkroYIpUU1ZfAZJOWzzG+58wvmrF0hrUns2YH2?=
 =?us-ascii?q?3FhWc6Uk73zQNc5mjFzKovuiuDsx9ZLhp5n3+HHlJqYYwvzSPZ/1NgS0foL4?=
 =?us-ascii?q?XD49D6moxF5Bi50IyxgqwRO082RQGfsqZGASANQ0GDzVJt0Yb59mgdSuZYaX?=
 =?us-ascii?q?eMmk5DwvGjS5qFrtyVJiDdjveR6CwAqOaK1Su1DJLTGNiVYkxvheQE7NLfg3?=
 =?us-ascii?q?py667s6287d6QE0OToROgWwpKIhvxouHLR/sRzY5zVLTpxu7TVCcPM0HX3E+?=
 =?us-ascii?q?DMkLWx+8fx/pT7kNReK4BCqOo0SazDT/ee1cqef4DtNM8Qx8iKBG4CaP72OM?=
 =?us-ascii?q?VO6iYBOAqpS1HOrBHx141T+g1yGGReGdTG95OF/kYB53fkvMt6wqJzskExbr?=
 =?us-ascii?q?YeG37O/4zQnw1elE+Rke2T7GNO44DrWGJo9xYWVqIwjKu/+wZcr/kmTyZvPZ?=
 =?us-ascii?q?A2oS0qUkTPgWCVTvw6DbWnle1YbNlcvWQvJudsenMK4UX2W8r/P048NSTXuE?=
 =?us-ascii?q?iP0ZJV0jOqP1kvaL12MEpYaEurg80RxpObq2UEDpfne8ICG2BeOuTbACopoi?=
 =?us-ascii?q?Fc9b9E9e/4j5/8qsVWmoIVYr8HeUPb1R/RFf4Q9tnGbAZHiV1kdlHRuRUYdv?=
 =?us-ascii?q?+JW63Xd0nCuDOYlM6lULHqGfQ5epJg/v+ObSWl68nlQALeimL2w5hLIkhNva?=
 =?us-ascii?q?Ug17tsxmHHuTpO+ICslC7OFkwbJOtmuC18WaCawQkoAEBvwvf7YMKvmSzPDl?=
 =?us-ascii?q?T9bEuD/53veGrMV6CtQwUd/lGEphsNWKpAQAnH3ciK+bKePBBQURSOOwFizO?=
 =?us-ascii?q?jBFljVS383hzmAHSqR1cV0MFOlqQxaQUgTQ9Y5Y6m+UNzukdG3Mq+ygbP0bM?=
 =?us-ascii?q?suUPLfWAE8ETQWOx/suOERanlifw6Oe4CBKQJCDlx6Jew4eZkHLRDJdV0hLQ?=
 =?us-ascii?q?HBjdRcNHEwS6QVv5ESZoYewz3ukQfJVaKHth7YEJXaqxaYhuF/v6V+oIJnLI?=
 =?us-ascii?q?MMpUFKRVwNjflVUTyUjxpvyF6BJnyG1KM01PohfVvC/HHyLhNwUo35SKrfA2?=
 =?us-ascii?q?1cjVJTg+KWSZbcitdvREc/tB2P4zwwNrRRavHBu8xCX0qCqkXbU6DMkV/tEe?=
 =?us-ascii?q?u+Ex0Rxc6kTQ0j55Nt/3KWFqp1kXvSYRMz2HyMMjmOz3mJTmlDtvFAFNxDJd?=
 =?us-ascii?q?0PcLQysodzojsMwI2bXm4xHELv1+/m41wwCCVtVJQ7XfFx674N72O/ZSk6br?=
 =?us-ascii?q?FcRx2mb/7QSIq2NoaBtq7NYAq7J0mnc6l9keH9l899wLzG28sEheCMEnKLXT?=
 =?us-ascii?q?zbk8RpztC+mFOrxZnB+q0msJj2SD4UKBpVeidwV0MtUWypXkhoyKpugSntda?=
 =?us-ascii?q?6zxWQy7ntM0L6mE34NvXWVZpsIKVEtfYw14fVmQ3/rFo3d1hNHt9cyzvmqoB?=
 =?us-ascii?q?I7BgkindB+ywamvVcEw9+tI5LRhbO4Z9iMrJuxPuaIuECpZXEnzkk2WPfZoo?=
 =?us-ascii?q?d9qIW5U0hzN7I+RyJ/NDcDLPo6yqWPDIkvHTbvQx/Miv9BehPZm4++MHBntq?=
 =?us-ascii?q?BqaaPv/YEdMiJTpZ5PMgY4O9+vpfMuTKfbGlYYgFxhDk9LionlUnIdVaP27t?=
 =?us-ascii?q?A7TZyzkCyVuSj78onzzXlwfP6lSluADUqjj2RQESScmjnfigGpk/78z7jjBM?=
 =?us-ascii?q?94vI+pqp3SWbXrwEu1DEnW9+HOhRLZe1j6xVRiGLyDg9dJ4KF+GI8x3Kbltx?=
 =?us-ascii?q?lWp8lHpOqwvHLAa8v0CyHa6FBTjvDGJqgATppO9QKMALL6UmyBF8GmAyLu8k?=
 =?us-ascii?q?fwQ48tsPPkEu26LZFiZjY4TibAdKv9dUFnVYg4tThfOxbn5P9g/TahHT9v2X?=
 =?us-ascii?q?v/aD+9PpzuVu4C4p4anXajCaw3AZhq1ZBOEp8QbHHMM6orWfXBPYoK6rIQSi?=
 =?us-ascii?q?iegWl2IhqT7FDMeSmcDEs7aQ+KqBWwEvTeApQqN9xi9Lz+GLbfU6iFOg8SOJ?=
 =?us-ascii?q?Ks9swdPWb6bvMyXgtRbhimOnLSC+/vmHi3tRC0B5aCsaLPGULRF1lyClSUXq?=
 =?us-ascii?q?euyZiBG3ebSQBBJkxkRM5qgkWXqYX+SBip+5kjJR3OnK9QjLCQuprQObHvoB?=
 =?us-ascii?q?ugZRR9jNUU+cVl++9wuu6ogzgcZV9Dk/1PbVaDpMbBU0Ol3DjajBk7jGSJDx?=
 =?us-ascii?q?8RlF3K5TbB46mNodQO/xFlhSuF7w7vTdlXkqBowG6S5b5mes8rKIR8+fn/22?=
 =?us-ascii?q?z6BeEivkPnW7eBysE4C22RFBaZD7wsdbZCH9p6EuLsQuA4dr2aAN8Rd2v0ij?=
 =?us-ascii?q?EMXNCZQOAsYu6NUvgGYtWlRodOo+nXCl64k+RrKfJG19HeceiLOB4jXZsOCS?=
 =?us-ascii?q?9zs5A9mmP94O2PoThJKA/k4k+MfhKqCquc+Y2xOkjqddi3NaHH2XO2XkE/eC?=
 =?us-ascii?q?c2Pg1EvXGDN6KKffqNs1LNIrCUKbYkmTHnQfbvPsvN3xfGZOKv/fw4UmLI0Q?=
 =?us-ascii?q?Pnpt/yvwnZ2gDKHoyN8SFe9ZlWq3JuuMlpKTz9QIt7M8jcaro01iqd6je9vI?=
 =?us-ascii?q?Xhy8rtgS1H08PimkIH4Kdn7804f/7+7fj6k5F+LirXglTf1fQRr4NP0U0J/u?=
 =?us-ascii?q?cvh/F9HhZd6IwcxHmKHkFmsiYkGiMrAwaU8c6+UhdkdydemQDhYbv8FB4Lqw?=
 =?us-ascii?q?o9h0VOM?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82660726"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 08/17] git-checkout.sh: handle running git-checkout from a different directory
Date: Thu, 13 Oct 2022 14:05:04 +0100
Message-ID: <20221013130513.52440-9-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

"$DIR" might not be a full path and it might not have `pwd` as ".."
directory. So use `cd -` to undo the first `cd` command.

Also, use `basename` to make a symbolic link with a relative path.

This doesn't matter yet but it will when for example the commands to
clone OVMF is been run from tools/ rather than tools/firmware/.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 scripts/git-checkout.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/git-checkout.sh b/scripts/git-checkout.sh
index 20ae31ff23..fd4425ac4e 100755
--- a/scripts/git-checkout.sh
+++ b/scripts/git-checkout.sh
@@ -19,9 +19,9 @@ if test \! -d $DIR-remote; then
 		cd $DIR-remote.tmp
 		$GIT branch -D dummy >/dev/null 2>&1 ||:
 		$GIT checkout -b dummy $TAG
-		cd ..
+		cd -
 	fi
 	mv $DIR-remote.tmp $DIR-remote
 fi
 rm -f $DIR
-ln -sf $DIR-remote $DIR
+ln -sf $(basename $DIR-remote) $DIR
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422028.667900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuB-0004XQ-0A; Thu, 13 Oct 2022 13:05:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422028.667900; Thu, 13 Oct 2022 13:05:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuA-0004X3-QY; Thu, 13 Oct 2022 13:05:42 +0000
Received: by outflank-mailman (input) for mailman id 422028;
 Thu, 13 Oct 2022 13:05:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixu9-0002ig-7K
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:41 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc1fc814-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:39 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc1fc814-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666339;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=fSnLDaFN3eqPfaJnrSLExq/lPHWyHgAYLE/INZekA2E=;
  b=ZZBbk9BwfzBE5rAHq1K1Hz9isJTRYuJBCDEbu05tOaaSKBoGEbntYOKv
   zDJ3sFPlbZ5n9qk1U8hGnKkLVJ9lvuk2d/wgXXuouZqk+WgZpF0075A12
   06J7EF0IgwQbS92J0d1WtUZ3piWcHpEQJLk127W/RQQ5SduKP1spD+omq
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82635816
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xURsA61h2C0wsxFx8fbD5e1xkn2cJEfYwER7XKvMYLTBsI5bpzNVn
 GIZCzrUM/iMNmX9edFyYdnk9xkA65+DytZgGQtqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpD5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUjqsdQJX9+6
 sYmdjILcB/TobmP+uOCH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqPJIfXFZwL9qqej
 lLn417oMw06DdOk8zGM9iORo+LfujyuDer+E5Xnr6U30TV/3Fc7EwYKXFG2pf24jE+WWN9FL
 UEQvC00osAa60iDXtT7GRqirxasvBEGXMFLO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/HhvYUygxTnXttlVqmvgbXI9SrYm
 m7Q6nJk3vNK0JBNh/7TEU37byyEncjoaSor1hrtYDyn6B12NKj+Xrb50A2OhRpfF7qxQl6Et
 XkCvsGR6uESEJ2A/BCwrPUx8KKBvKjcbmCF6bJ7N9x4rmn2pSb/FWxFyGsmTHqFJProbtMAj
 KX7nQpKrKFeM3KxBUOcS9LgUp96pUQM+DmMaxw1UjasSsIsHONk1Hs0DaJ144wKuBlErE3HE
 c3HGftA9F5DYUid8BK4Rv0GzZggzT0kyGXYSPjTlkr5jOTGPCbNF+hcajNii9zVC4vd+W3oH
 yt3bZPWm32zrsWkCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJbJY3VMNeImOtJRmCQt/4K/gs+1
 i3iBxQwJZuWrSGvFDhmnVg6NOOyAsch8yhmVcHuVH7xs0UejU+UxP93X/MKkXMProSPEdYco
 yE5Rvi9
IronPort-HdrOrdr: A9a23:Cib1kKoY5NRo6t2OBs0jWwcaV5oteYIsimQD101hICG8cqSj+P
 xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U
 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA==
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82635816"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 10/17] libs: Fix auto-generation of version-script for unstable libs
Date: Thu, 13 Oct 2022 14:05:06 +0100
Message-ID: <20221013130513.52440-11-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

When there isn't a version-script for a shared library (like for
unstable libs), we create one based on the current Xen version. But
that version-script became out-of-date as soon as Xen's version
changes and make as no way to regenerate the version-script on
rebuild.

In order to allow regenerating the script, we'll have a different
filename. In order to check if the content is up-to-date, we'll always
generated it and compare.

But we also need to know if there's already an existing version script
or if we need to generate one, for that we introduce $(version-script)
to be used to point to the path of the existing script. (Guessing if a
version script exist for a stable library with for example $(wildcard)
won't work as a file will exist when building the library without this
patch.)

We don't need the version-script unless we are making the shared
library so it is removed from the "all" target.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Alternatively, we could remove the need for to generate a
version-script, but that would mean the exported symbols won't have a
version anymore (like before, a few versions of Xen ago). Or, we could
use --default-symver, but the symboled would be versionned with the
soname (e.g. "libxenctrl.so.4.16.0") instead of "VERS_4.16.0".
---

Notes:
    v4:
    - new patch

 tools/libs/call/Makefile          |  1 +
 tools/libs/ctrl/Makefile          |  3 ---
 tools/libs/devicemodel/Makefile   |  1 +
 tools/libs/evtchn/Makefile        |  1 +
 tools/libs/foreignmemory/Makefile |  1 +
 tools/libs/gnttab/Makefile        |  1 +
 tools/libs/guest/Makefile         |  3 ---
 tools/libs/hypfs/Makefile         |  1 +
 tools/libs/light/Makefile         |  1 -
 tools/libs/stat/Makefile          |  2 +-
 tools/libs/store/Makefile         |  1 +
 tools/libs/toolcore/Makefile      |  1 +
 tools/libs/toollog/Makefile       |  1 +
 tools/libs/util/Makefile          |  3 ---
 tools/libs/vchan/Makefile         |  3 ---
 tools/libs/libs.mk                | 19 +++++++++++++------
 .gitignore                        |  6 ------
 17 files changed, 23 insertions(+), 26 deletions(-)

diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile
index 103f5ad360..56a964b517 100644
--- a/tools/libs/call/Makefile
+++ b/tools/libs/call/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
 MINOR    = 3
+version-script := libxencall.map
 
 include Makefile.common
 
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index 93442ab389..094e84b8d8 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -10,6 +10,3 @@ PKG_CONFIG_NAME := Xencontrol
 NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
-
-clean::
-	rm -f libxenctrl.map
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index b70dd774e4..20d1d112e7 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
 MINOR    = 4
+version-script := libxendevicemodel.map
 
 include Makefile.common
 
diff --git a/tools/libs/evtchn/Makefile b/tools/libs/evtchn/Makefile
index 3dad3840c6..18cdaab89e 100644
--- a/tools/libs/evtchn/Makefile
+++ b/tools/libs/evtchn/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
 MINOR    = 2
+version-script := libxenevtchn.map
 
 include Makefile.common
 
diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makefile
index b70dd774e4..81398e88b1 100644
--- a/tools/libs/foreignmemory/Makefile
+++ b/tools/libs/foreignmemory/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
 MINOR    = 4
+version-script := libxenforeignmemory.map
 
 include Makefile.common
 
diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile
index 3dad3840c6..4528830bdc 100644
--- a/tools/libs/gnttab/Makefile
+++ b/tools/libs/gnttab/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
 MINOR    = 2
+version-script := libxengnttab.map
 
 include Makefile.common
 
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 19d3ff2fdb..93338a9301 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -14,6 +14,3 @@ NO_HEADERS_CHK := y
 include $(XEN_ROOT)/tools/libs/libs.mk
 
 libxenguest.so.$(MAJOR).$(MINOR): LDLIBS += $(ZLIB_LIBS) -lz
-
-clean::
-	rm -f libxenguest.map
diff --git a/tools/libs/hypfs/Makefile b/tools/libs/hypfs/Makefile
index 630e1e6f3e..7fae5c750d 100644
--- a/tools/libs/hypfs/Makefile
+++ b/tools/libs/hypfs/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
 MINOR    = 0
+version-script := libxenhypfs.map
 
 LDLIBS += -lz
 
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 13545654c2..1d5716dbba 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -252,6 +252,5 @@ clean::
 	$(RM) testidl.c.new testidl.c *.api-ok
 	$(RM) $(TEST_PROGS) libxenlight_test.so libxl_test_*.opic
 	$(RM) -r __pycache__
-	$(RM) libxenlight.map
 	$(RM) $(AUTOSRCS) $(AUTOINCS)
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) clean
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 7eaf50e91e..ee5c42bf7b 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -134,4 +134,4 @@ uninstall:: uninstall-perl-bindings
 endif
 
 clean::
-	$(RM) libxenstat.map $(BINDINGS) $(BINDINGSRC)
+	$(RM) $(BINDINGS) $(BINDINGSRC)
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 2334c953bb..300c271eb0 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR = 4
 MINOR = 0
+version-script := libxenstore.map
 
 ifeq ($(CONFIG_Linux),y)
 LDLIBS += -ldl
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index 0d92b68b3b..20671dadd0 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR	= 1
 MINOR	= 0
+version-script := libxentoolcore.map
 
 LIBHEADER := xentoolcore.h
 
diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile
index 2361b8cbf1..d612227c85 100644
--- a/tools/libs/toollog/Makefile
+++ b/tools/libs/toollog/Makefile
@@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR	= 1
 MINOR	= 0
+version-script := libxentoollog.map
 
 include Makefile.common
 
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index 493d2e00be..e016baf888 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -47,6 +47,3 @@ $(OBJS-y) $(PIC_OBJS): $(AUTOINCS)
 %.c %.h:: %.l
 	@rm -f $*.[ch]
 	$(FLEX) --header-file=$*.h --outfile=$*.c $<
-
-clean::
-	$(RM) libxenutil.map
diff --git a/tools/libs/vchan/Makefile b/tools/libs/vchan/Makefile
index ac2bff66f5..a1ef60ac8e 100644
--- a/tools/libs/vchan/Makefile
+++ b/tools/libs/vchan/Makefile
@@ -11,6 +11,3 @@ OBJS-y += io.o
 NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
-
-clean::
-	rm -f libxenvchan.map
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 3eb91fc8f3..cab8e9704a 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -4,6 +4,8 @@
 #   PKG_CONFIG: name of pkg-config file (xen$(LIBNAME).pc if empty)
 #   MAJOR:   major version of lib (Xen version if empty)
 #   MINOR:   minor version of lib (0 if empty)
+#   version-script: Specify the name of a version script to the linker.
+#     (If empty, a temporary one for unstable library is created)
 
 LIBNAME := $(notdir $(CURDIR))
 
@@ -12,6 +14,10 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
 endif
 MINOR ?= 0
 
+ifeq ($(origin version-script), undefined)
+version-script := libxen$(LIBNAME).map.tmp
+endif
+
 CFLAGS   += -Wmissing-prototypes
 CFLAGS   += $(CFLAGS_xeninclude)
 CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
@@ -53,7 +59,7 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_INCLUDE)
 $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR = $(CURDIR)
 
 .PHONY: all
-all: $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map $(LIBHEADERS)
+all: $(TARGETS) $(PKG_CONFIG_LOCAL) $(LIBHEADERS)
 
 ifneq ($(NO_HEADERS_CHK),y)
 all: headers.chk
@@ -71,8 +77,9 @@ headers.lst: FORCE
 	@{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp
 	@$(call move-if-changed,$@.tmp,$@)
 
-libxen$(LIBNAME).map:
-	echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >$@
+libxen$(LIBNAME).map.tmp: FORCE
+	echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >.$@.tmp
+	$(call move-if-changed,.$@.tmp,$@)
 
 lib$(LIB_FILE_NAME).a: $(OBJS-y)
 	$(AR) rc $@ $^
@@ -82,8 +89,8 @@ lib$(LIB_FILE_NAME).so: lib$(LIB_FILE_NAME).so.$(MAJOR)
 lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
 	$(SYMLINK_SHLIB) $< $@
 
-lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
-	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,--version-script=libxen$(LIBNAME).map $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
+lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) $(version-script)
+	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,--version-script=$(version-script) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 # If abi-dumper is available, write out the ABI analysis
 ifneq ($(ABI_DUMPER),)
@@ -122,7 +129,7 @@ TAGS:
 clean::
 	rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS)
 	rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR)
-	rm -f headers.chk headers.lst
+	rm -f headers.chk headers.lst libxen*.map.tmp
 
 .PHONY: distclean
 distclean: clean
diff --git a/.gitignore b/.gitignore
index 418bdfaebf..7febfc224d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -106,8 +106,6 @@ tools/config.cache
 config/Tools.mk
 config/Stubdom.mk
 config/Docs.mk
-tools/libs/ctrl/libxenctrl.map
-tools/libs/guest/libxenguest.map
 tools/libs/guest/xc_bitops.h
 tools/libs/guest/xc_core.h
 tools/libs/guest/xc_core_arm.h
@@ -117,7 +115,6 @@ tools/libs/light/_*.[ch]
 tools/libs/light/*.pyc
 tools/libs/light/_libxl.api-for-check
 tools/libs/light/*.api-ok
-tools/libs/light/libxenlight.map
 tools/libs/light/libxl-save-helper
 tools/libs/light/dsdt*
 tools/libs/light/mk_dsdt
@@ -127,13 +124,10 @@ tools/libs/light/testidl.c
 tools/libs/light/test_timedereg
 tools/libs/light/test_fdderegrace
 tools/libs/light/tmp.*
-tools/libs/stat/libxenstat.map
 tools/libs/store/list.h
 tools/libs/store/utils.h
 tools/libs/store/xs_lib.c
 tools/libs/util/libxlu_cfg_y.output
-tools/libs/util/libxenutil.map
-tools/libs/vchan/libxenvchan.map
 tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/*
 tools/debugger/gdb/gdb-6.2.1/*
 tools/debugger/gdb/gdb-6.2.1.tar.bz2
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422029.667909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuC-0004pr-A0; Thu, 13 Oct 2022 13:05:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422029.667909; Thu, 13 Oct 2022 13:05:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuC-0004oj-3S; Thu, 13 Oct 2022 13:05:44 +0000
Received: by outflank-mailman (input) for mailman id 422029;
 Thu, 13 Oct 2022 13:05:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuA-0002ig-If
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:42 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc557b41-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:41 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc557b41-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666341;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=/gk/zrc7mUau8n7u3084orMZkSKyjao6ioLVB6VKyZU=;
  b=hSmZqwzn5ISahHFWLEg2zgH5M1Z7tuvlpzPbOR4n1zr6XunF8j/QK17d
   Amp4Y2uT2MUCkEfm0kfJ2l4/9H3CQKQqVvM8kYk+Ka6FEDggnNHVHmnvT
   daUg7eEFjolmTvb9ya1zoRC6leMotFLpY1H01/lrQcA5NDCXTqLvbyAna
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 85173820
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Q0ylEKB239wVMxVW/yzjw5YqxClBgxIJ4kV8jS/XYbTApD1z1j1Um
 DQYXmjQM/fcYGv3L9l+b463oUoAup7SmIM2QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2p4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kIYrY8otsqQl1Uy
 uQ0GSoxdxKOv+GflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN
 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+OiwaYWOKobSLSlTtmG+t
 jzIon3LPhM1PtK8ljS5rXSxiNaayEsXX6pNTeblp5aGmma7xGMJDwYNfUCmuvT/gUm7M/pAL
 2QE9yxoqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYUzCzZPMkG7xBTIqNUMzfxMdTwY94PC29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWG3DaD/LF7rVxBHkJPmqgBiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+S4m7DqiMNoQRO8IZmOq7EMZGPBf44owQuBJ0zfFX1
 WmzK65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eK0XOy+PiOPGDEN5vJ9fbzNimMhls/7fyOgUm
 v4DX/a3J+J3CbGuP3aGr9BJcDjn7xETXPjLliCeTcbbSiIOJY3rI6O5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:uMMOjqOXaAcqjcBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy
 nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM
 xbHZSWZuedMbEDt7eY3DWF
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="85173820"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 09/17] libs: Avoid exposing -Wl,--version-script to other built library
Date: Thu, 13 Oct 2022 14:05:05 +0100
Message-ID: <20221013130513.52440-10-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

$(SHLIB_LDFLAGS) is used by more targets that the single targets that
except it (libxenfoo.so.X.Y). There is also some dynamic libraries in
stats/ that uses $(SHLIB_LDFLAGS) (even if those are never built), and
there's libxenlight_test.so which doesn't needs a version script.

Also, libxenlight_test.so might failed to build if the version script
doesn't exist yet.

For these reasons, avoid changing the generic $(SHLIB_LDFLAGS) flags,
and add the flag directly on the command line.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/libs/libs.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index e47fb30ed4..3eb91fc8f3 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -12,8 +12,6 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
 endif
 MINOR ?= 0
 
-SHLIB_LDFLAGS += -Wl,--version-script=libxen$(LIBNAME).map
-
 CFLAGS   += -Wmissing-prototypes
 CFLAGS   += $(CFLAGS_xeninclude)
 CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
@@ -85,7 +83,7 @@ lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
 	$(SYMLINK_SHLIB) $< $@
 
 lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
-	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,--version-script=libxen$(LIBNAME).map $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 # If abi-dumper is available, write out the ABI analysis
 ifneq ($(ABI_DUMPER),)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422032.667922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuE-0005M3-OU; Thu, 13 Oct 2022 13:05:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422032.667922; Thu, 13 Oct 2022 13:05:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuE-0005K5-Is; Thu, 13 Oct 2022 13:05:46 +0000
Received: by outflank-mailman (input) for mailman id 422032;
 Thu, 13 Oct 2022 13:05:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuD-0001tl-Fc
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:45 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b1636fcd-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:22 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1636fcd-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666344;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=6Ciqslkc0BK3uoE16/zRFo3axUefMUHAjqrqHVfnJXw=;
  b=MTvL7uj/wFBa+386lbsujouHQzSdDt+Wm4DJ0WPvix6VdNHGDSgxbS5G
   WamdMXjn0KBO3esfgYYime52EgbrIOmLzaIevM2b04nEpz7bcUfvLZ2xB
   eIdb9YK/zpFNjp8fJDiA1dX3vcUHCa0r1xje9Q+WIq7yrXbwq3WHER5sZ
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81760248
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uZqzra9OpmoW5If2WxCVDrUD6n6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 jQeDG+PMvfbMzekft9+Po2x8E4Cusfdy4NkSAprpH08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5wdmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tdOW3B/x
 NgYExAMSg2Ri9Kdzo+De+Y506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI
 ZNEN3w/N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9KoXVG50PwhbwS
 mTu8mv5MkgTJOejzmCJrlSz2ObyzBOiR9dHfFG/3qEz2wDCroAJMzUJUXOrrP//jVSxM/pPJ
 kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJS1e2W4vOKuUDDXDFCF2MfLox93CMredA0/
 m6wxcLYNBhvi52UbW+P+oe/ow6KCCdAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJszHlJd3j6
 2vU9XZj3t3/meZOjvzmpg6f31pAs7CTFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7
 BDodyVzhd3i7K1hdgTXHY3h/5nzvZ5p1QEwZnY+d6TNDxz3pxaekXl4uVmS3ntBPMceYiPOa
 0TOow5X75I7FCL0M/IpO9rpU5p1lPKI+THZuhf8N4MmX3SMXFXfoHEGibC4hQgBb3TAYYlgY
 MzGIK5A/F4RCLh9zSreetrxJYQDn3lmrV4/sLihkHxLJ5LCOyPOIVrEWXPSBt0EAFSs+VmFr
 okOaZXQln2ykoTWO0HqzGLaFnhSRVBTOHw8g5c/mjKrSua+JFwcNg==
IronPort-HdrOrdr: A9a23:D/M2zaDHodxA2pflHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo8f
 xG/c5rrSMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 5dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81760248"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 11/17] tools/include: Rework Makefile
Date: Thu, 13 Oct 2022 14:05:07 +0100
Message-ID: <20221013130513.52440-12-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Rework "xen-xsm" rules to not have to change directory to run
mkflask.sh, and store mkflask.sh path in a var, and use a full path
for FLASK_H_DEPEND, and output directory is made relative.

Rename "all-y" target to a more descriptive "xen/lib/x86/all".

Removed the "dist" target which was the only one existing in tools/.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/include/Makefile | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/tools/include/Makefile b/tools/include/Makefile
index b488f7ca9f..81c3d09039 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -7,17 +7,20 @@ include $(XEN_ROOT)/tools/Rules.mk
 # taken into account, i.e. there should be no rules added here for generating
 # any tools/include/*.h files.
 
-# Relative to $(XEN_ROOT)/xen/xsm/flask
-FLASK_H_DEPEND := policy/initial_sids
+.PHONY: all
+all: xen-foreign xen-dir xen-xsm/.dir
+ifeq ($(CONFIG_X86),y)
+all: xen/lib/x86/all
+endif
 
-.PHONY: all all-y build xen-dir
-all build: all-y xen-foreign xen-dir xen-xsm/.dir
-all-y:
+.PHONY: build
+build: all
 
 .PHONY: xen-foreign
 xen-foreign:
 	$(MAKE) -C xen-foreign
 
+.PHONY: xen-dir
 xen-dir:
 	mkdir -p xen/libelf acpi
 	find xen/ acpi/ -type l -exec rm '{}' +
@@ -36,16 +39,18 @@ ifeq ($(CONFIG_X86),y)
 	ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/
 endif
 
-all-$(CONFIG_X86): xen-dir
+.PHONY: xen/lib/x86/all
+xen/lib/x86/all: xen-dir
 	$(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON)
 
+MKFLASK := $(XEN_ROOT)/xen/xsm/flask/policy/mkflask.sh
+FLASK_H_DEPEND := $(XEN_ROOT)/xen/xsm/flask/policy/initial_sids
+
 # Not xen/xsm as that clashes with link to
 # $(XEN_ROOT)/xen/include/public/xsm above.
-xen-xsm/.dir: $(XEN_ROOT)/xen/xsm/flask/policy/mkflask.sh \
-	      $(patsubst %,$(XEN_ROOT)/xen/xsm/flask/%,$(FLASK_H_DEPEND))
+xen-xsm/.dir: $(MKFLASK) $(FLASK_H_DEPEND)
 	mkdir -p xen-xsm/flask
-	cd $(XEN_ROOT)/xen/xsm/flask/ && \
-		$(SHELL) policy/mkflask.sh $(AWK) $(CURDIR)/xen-xsm/flask $(FLASK_H_DEPEND)
+	$(SHELL) $(MKFLASK) $(AWK) xen-xsm/flask $(FLASK_H_DEPEND)
 	touch $@
 
 .PHONY: install
@@ -84,8 +89,5 @@ clean:
 	$(MAKE) -C xen-foreign clean
 	rm -f _*.h
 
-.PHONY: dist
-dist: install
-
 .PHONY: distclean
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:05:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:05:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422033.667928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuG-0005XN-0K; Thu, 13 Oct 2022 13:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422033.667928; Thu, 13 Oct 2022 13:05:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixuF-0005Un-Jw; Thu, 13 Oct 2022 13:05:47 +0000
Received: by outflank-mailman (input) for mailman id 422033;
 Thu, 13 Oct 2022 13:05:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuE-0001tl-JP
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:46 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b2c51c1a-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:23 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2c51c1a-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666345;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=V8jWdBRJCxUnfV5R+IMYSD99LmO4hxLhQr7j9mADfWE=;
  b=OM9y8d0OBk7TTNawTP7yIOZ31y9bU8yDWHKaiLLiAPHVflwxTXjVYuBI
   96ewqlCHTONaqnXrlL0biyzN1PuwuR7vBaAePBN95HfPifa5QnwlLdcl1
   PDpR3RuZQGyaGJfyZw1yGi4cvH9qfrUyd/RF+68l7WKxHZtl8lalxSGM3
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81760249
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:X7LWxKAgQqGLDRVW/yzjw5YqxClBgxIJ4kV8jS/XYbTApGxw0DQEn
 WRKCG2EM//ZZGSkeYt0Ptm09xkAsJKDzdFhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2p4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kHBNcJy9dTAVpu9
 NgFOjw9RR6+v9O5lefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN
 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oi0b4SNIIDbLSlTtku9n
 j7jxn7+OxglZdal5yClySqhmcaayEsXX6pNTeblp5aGmma7xGMJDwYNfUCmuvT/gUm7M/pAL
 2QE9yxoqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYUOkrKalnBeyAggUCXIQaR8vQzY90ta29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWG3DaD/LF7rVxBHkJPmqgBiAyS3G8zbq45lcbBO
 Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+S4m7DqiMNoQRO8IZmOq7EMZGPBf44owQuBJ0zfFX1
 WmzK65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eK0XOy+PiOPGDEN5vJ9fbzNimMhls/7fyOgUm
 v4DX/a3J+J3CbGuP3aGr9BJcDjn7xETXPjLliCeTcbbSiIOJY3rI6S5LW8JE2C9o5loqw==
IronPort-HdrOrdr: A9a23:YXhOc63UzmCPpIYOzKXWMQqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81760249"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 12/17] libs/light: Rework acpi table build targets
Date: Thu, 13 Oct 2022 14:05:08 +0100
Message-ID: <20221013130513.52440-13-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Currently, a rebuild of libxl will always rebuild for example
"build.o". This is because the target depends on "acpi" which never
exist. So instead we will have "build.o" have as prerequisites targets
that are actually generated by "acpi", that is $(DSDT_FILES-y).

While "dsdt_*.c" isn't really a dependency for "build.o", a side
effect of building that dsdt_*.c is to also generate the "ssdt_*.h"
that "build.o" needs, but I don't want to list all the headers needed
by "build.o" and duplicate the information available in
"libacpi/Makefile" at this time.

Also avoid duplicating the "acpi" target for Arm, and unique one for
both architecture. And move the "acpi" target to be with other targets
rather than in the middle of the source listing. For the same reason,
move the prerequisites listing for both $(DSDT_FILES-y) and "build.o".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/libs/light/Makefile | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 1d5716dbba..4a8b0f7bcf 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -32,14 +32,10 @@ ACPI_PATH  = $(XEN_ROOT)/tools/libacpi
 DSDT_FILES-$(CONFIG_X86) = dsdt_pvh.c
 ACPI_OBJS  = $(patsubst %.c,%.o,$(DSDT_FILES-y)) build.o static_tables.o
 ACPI_PIC_OBJS = $(patsubst %.o,%.opic,$(ACPI_OBJS))
-$(DSDT_FILES-y) build.o build.opic: acpi
+
 vpath build.c $(ACPI_PATH)/
 vpath static_tables.c $(ACPI_PATH)/
 
-.PHONY: acpi
-acpi:
-	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
-
 OBJS-$(CONFIG_X86) += $(ACPI_OBJS)
 
 CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
@@ -58,8 +54,6 @@ ifeq ($(CONFIG_ARM_64),y)
 DSDT_FILES-y = dsdt_anycpu_arm.c
 OBJS-y += libxl_arm_acpi.o
 OBJS-y += $(DSDT_FILES-y:.c=.o)
-dsdt_anycpu_arm.c:
-	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
 else
 OBJS-$(CONFIG_ARM) += libxl_arm_no_acpi.o
 endif
@@ -191,6 +185,12 @@ all: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
 
 $(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
 
+$(DSDT_FILES-y): acpi
+
+# Depends on the source files generated by the "acpi" target even if "build.o"
+# don't needs them but do need the headers that are also generated by "acpi".
+build.o build.opic: $(DSDT_FILES-y)
+
 libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	$(PERL) $^
 	touch $@
@@ -227,6 +227,10 @@ _libxl_type%.h _libxl_type%_json.h _libxl_type%_private.h _libxl_type%.c: libxl_
 $(XEN_INCLUDE)/_%.h: _%.h
 	$(call move-if-changed,_$*.h,$(XEN_INCLUDE)/_$*.h)
 
+.PHONY: acpi
+acpi:
+	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
+
 libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS)
 	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:10:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:10:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422088.667944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixyp-0001sx-Px; Thu, 13 Oct 2022 13:10:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422088.667944; Thu, 13 Oct 2022 13:10:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oixyp-0001sq-M5; Thu, 13 Oct 2022 13:10:31 +0000
Received: by outflank-mailman (input) for mailman id 422088;
 Thu, 13 Oct 2022 13:10:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oixyn-0001sk-Qe
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:10:29 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6779ff06-4af8-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:10:28 +0200 (CEST)
Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 09:10:25 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DS7PR03MB5381.namprd03.prod.outlook.com (2603:10b6:5:2c2::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 13:10:23 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 13:10:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6779ff06-4af8-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666628;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=y2WOxBk8zlh1ofY51AiW8FfxbydOkZfhVILfV+N02YY=;
  b=fTS11eNwuxcyfHQqY4MsyivxkQDpVuotl5rAHL3WiQSvtcH6hN2AHG92
   uo0P2AEoKWpmSpO/FM5k1dD7irLh3COkUvi+Gxn5VqFpVboRWEBe4ex7k
   3fbnf/ds5oQcOYas9WDKKPclYeXxhK8aC83Gn7p4bs5L/X2fAnnRVgFiB
   A=;
X-IronPort-RemoteIP: 104.47.55.176
X-IronPort-MID: 85174332
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:NCrQgKM1Y1CrLefvrR2+lsFynXyQoLVcMsEvi/4bfWQNrUok0GMBy
 jQdWTiDM63eNzD3eo0jPoSw9xsO6p7Vm9BlQAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr42tB1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4ebLQ4y7h8CE910
 +0/GG5ScheOpMDr6efuIgVsrpxLwMjDGqo64ysl5xeJSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9RTM+vRfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPlGParin33IcjmwvjAYEAFrSa/8RRkXuLz1UdODwVVkGk9KzRZkmWHog3x
 1Yv0igkoLU29UerZsLgRBD+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 kCNt8PkA3poqrL9dJ6G3rKdrDf3My5FK2YHPHUAVVFcvIelp5wvhBXSSNolCLSyktD+BTD3x
 XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjnNAt9RDGJ9W7GV1A==
IronPort-HdrOrdr: A9a23:PwktUKwQc/WQeF7izleAKrPwKr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ
 0QFZSWY+efMbEVt6rHCXGDYrUd/OU=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="85174332"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dWiAuTw88XCfU2n1LVu3wtzR+AYv/SnFnjY7SKKdYd8YgClwLpGcneo6SjUNuGCiqZ+xR2TEdz5xsiaoCt7mQL6y3ro/x7EmDT7DzItfxYUzTgo8UQdCGjOo+3Y14esZTJyMhJEVj3BUlzHF/MBM+b/Y+MyOwpMuEbehLKt50ObYnEt0rm3FhE0Rr985OVm+6DUfl9JJXiG3n+v0hPVfCYsHqDI6CcSh5x8/P+18/+qQ+LmJeSwA/CVQBEmBJpp/b3BSvsYIfMiL0ofRo5SSNGGbVuE00KgI++8Io9W6KswiI8b74Fg01bEBfNat2yYtcyAS/tdWprun2RMkfOXgyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qDqh2Rf1Yz6c8xWjGs5H/0qgjIMDyFMeIaVeWoElRLM=;
 b=PsU7RSLiu56UPdBqd00GnL+4ukr5VLDAYdJ7j5sk4mkuNmqLtufCdN5OiRzYq2iLgT3Gh8Muc/ms3XfNSctPaNRFI26PVYvVJgnjFMV/PpiJHOrq1A43TXgnBjCp0KPN7DA+mTKodKfUK6D+wpsEb71s/ROifnonCIbAYtytF0f5ZbBptABGzUQ8hwuU48wjIkrpTGH3JZZuSwJvD2ApJJ9bqSXj12dCmG2BqcMQqWTHFMp1fMal8AkTfkdiLDGI7dt4q3E7DFeS51dQ48ihxgzhymKKDpDd3rrKc8B155sa17JqV3MExBublnikfjDxF+NAHZ7TaqajiJ5nR1J4+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qDqh2Rf1Yz6c8xWjGs5H/0qgjIMDyFMeIaVeWoElRLM=;
 b=fPY8Eu2eSkd1MiimUfGsTJUbsaKQs9TKtZiFNga1I73mIHxEUuigDcwg9BSTZp5yU0Yb1lVVXxdsTBwGLaQBg4ghlKBHHPa7y0DWLBiYt7kJi9hJgadOMF33hOyXxeyom0Ang8aTwC2tUEu2zm9gYD2aE7z6ZD3LtGzD/3Fj6zI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 15:10:17 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle
Message-ID: <Y0gOOcbw2bebsKAJ@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
 <Y0f+gL1PfB5lzlDj@Air-de-Roger>
 <1867142e-ee46-daa7-c05c-04045460ba52@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1867142e-ee46-daa7-c05c-04045460ba52@suse.com>
X-ClientProxiedBy: MR1P264CA0172.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:55::20) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DS7PR03MB5381:EE_
X-MS-Office365-Filtering-Correlation-Id: a7e2f975-9223-4f79-0686-08daad1c4936
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rlzMTFE6hGyCmVMmuYYyuml6HaVlH1Z7OUSjf6VFEq3hxsuP5q4thG7qipfxNDgBGlOgsBU6rsoOUql6VRl/og8GsWp0aAQBBbjQMuCeybG3DFOeibziSUcFopH+q7Dl/ZsFvg7MMfcBATWoR8iUurD6x2vbA9LDRl53Bltzrp+9brjhZU1adZtTsrs9A+rWvyFEYBl1b3iju97q5BlPviM9WViIFeRSH9UuWtuhu5ZzuZ8n9zgN2SAGzCBR/XahdXAHHsLJgsoAuVWDMZ/jA9bPB6/VUfcGEF+0HNoK1MJaF659HRKJ27DFSvg0lPXPJRVwtOI+xozkUSpf6rLxNTFqSa6iAeySkhT6QdtQzsXfp2xSBl9oCiDVdGagxL/0dOqUhkEXD8bXD+lt21y0JluVn8mRBQEjpXtfV0DxBBDWVgmn/BSZdKPgQTeXNDuJY2pwYUdCDv34idIeJ1VXkdmWudQB2MZYwpHosOWOpCv4E9LNqEzDWfQ22CROXD3+HvPda63w/yWDSdWWBDlqxhe0x77XTXC4ev6tG8OdUCd9+4gLym0QJTflZ82N2Lw3ym8jhcGb3OeJoUDCQALnMmbSYLHe0O5ooppk7Xu1AnTs8Jr01O019tH1k/2pHeK5yoPmb0GPM9+OicBWh9h1d1MeSTZevdRUOOUfbTPuID4F5CBIe1sNmXFiy3pUjZj1Gmd4e9OWvR/fhU6vfpfqLg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(396003)(366004)(346002)(376002)(39860400002)(451199015)(186003)(8676002)(83380400001)(82960400001)(5660300002)(38100700002)(9686003)(33716001)(41300700001)(4326008)(6512007)(26005)(6916009)(6506007)(316002)(53546011)(6486002)(54906003)(6666004)(2906002)(478600001)(66946007)(66476007)(66556008)(8936002)(85182001)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dys1NDBhUEkveEE4dy9EZ25MNk0rT3hvZmI3amV6KzdxYzdSamdrQksxL0w2?=
 =?utf-8?B?emNDM0dTdFBNTUI1WWVBWkltaWd0TVdkNlNTTmNpWVJZVmp4VTFjN2Vrdmwz?=
 =?utf-8?B?UUhtZXNTSUVUNFlzQkcvME8xdklVMmIrNW9vQVphREVpY2t3eExLRmlqOGdq?=
 =?utf-8?B?Q0ttekttTE8vOHRMdmtwbERGWkpuZHJUaFJjekpXbVdOSENGU3VYamRGZzdi?=
 =?utf-8?B?M3hWak9QdVh6U1hCYmIrbGw0Q1h3YXJhenRId2FTMVF1QjFPNnRZYWUzeXpS?=
 =?utf-8?B?bUhVV3M2QjBwSXhOTU1MS3k4RUJNK0h3c2RSWnAwQkYrMGNoem1VeEpJOWsw?=
 =?utf-8?B?ck1jZTlZQXJIcmljcnQvVnhVYmhnNlNLaWhtc2FWeFYrcjBXVTcrTElBRUlW?=
 =?utf-8?B?cGhRNWxQdm1nUzRZdllFeXhTK1BleFhjWjBVN1dCYmlkMytvUUp3S2JKV0xY?=
 =?utf-8?B?S0k1Rit4Z0k5Q0REZm5iWWV0c0J6ZnVueEVsRVcvTWF2bE9BQnFrM1BuZnVZ?=
 =?utf-8?B?UmpTVU1vUkc2S1Jqb3kxdk91TEVkRFRHVlNOcnBmOWRZZ0NJWlNTdlcrUVEx?=
 =?utf-8?B?OHphQjB5SjNHMVdWRmduVk9PbDVPaDExMnZPempOcEpNaExvS0FNTlI0alVU?=
 =?utf-8?B?SXEvUm1OVDJkQnFCdDRmLzZsT0xTYjhUeEVzcVk2N3FGS1BydVhLNlU1bHhm?=
 =?utf-8?B?ZTJndzNBWEpTK1NnOXJaUk1sbldyYUlYYXZKK3loNURpcWIxcmt0QW9BY1Vs?=
 =?utf-8?B?QmEzYXF6WjRrMHJyTWw1VEk2dDg5VVA1bW9RSmQ4WVQ2T3N4aXFFa1FiS25i?=
 =?utf-8?B?d1VnSkl4ZlRwV25yVGlSdGVUeWJiK3k1Tng5TWNUWFJvQmtuRHZCTldQeVI2?=
 =?utf-8?B?UVQxTlBLTnVwNlYvN2ZmQXJiUEtnZjk1d2UvOXJ6U1RCaDdpWVMzRTFyRGJq?=
 =?utf-8?B?amVXZmJVWVBmVTVuTmJkMHNHUXM2ZDlxSGNFbHdNODdKaTRSQmRhVDhLU1FE?=
 =?utf-8?B?cUprbCt0d3F3OFdZeEc4dElpeFRONkE1R3Y2YnNqWEh5d1pwUkRIWS9JQ3hl?=
 =?utf-8?B?R0lQRGdPMU50RUJsWVhzZmFHalFiTEwwcnM0NVlGc1FoZktaSzF2OXFLOU1G?=
 =?utf-8?B?RzVlZXJPZzdwU2FmbDE4TDlGMFAyM1FxNW9XSlpXLzN5b1NkazNFbjJSaUZC?=
 =?utf-8?B?Vk1rTHUwaWZEeWN4SlNSU0E5aDVYOWhkdC9QeHEvM25HeG96MDRLNm8zZjVN?=
 =?utf-8?B?UTlpSzZRb3FLdy9FQUNnOFRVNE5EenZqc1hCL2VxWThxMzYrTDFyLzJHalo3?=
 =?utf-8?B?ZmZ4M2tRNnNiWVViUjRDdmd3ZmpxTWZVVFNKWWk0dmFMaXVBQ3ZMajVGK3Fo?=
 =?utf-8?B?c24wL3p1MWMvcFNENjc2Q1QvTExuSmw3WEFhSktZdW5zd1RDcGtUNTZYZldZ?=
 =?utf-8?B?WHZBeFh5eCt6dFh6SDFkaGpnVFY5TkFvMkNHR09La0pnbEJmcmg1MmhrWWtQ?=
 =?utf-8?B?RlpyZEZKQ0d3WkJQK1hqdmFsbjNQdE5CVS9mZHpnY2R6ejZ1YVh5NEU4VVM0?=
 =?utf-8?B?cnExUDRHSzJPc2d4a2NtNFRGWnBiN1NzaWM0YjR1cTY1bzc4Tmh5Vjkza2tT?=
 =?utf-8?B?a0dmYmdtVUxiVFRoUVVPc1Z6ZlRyc0U0bERmOGFvckkySEFKK09VMDZkZWkr?=
 =?utf-8?B?Uko1NFNXNjJxOWpNRzBGL0dRRUJBZzh6ZG5NajRGOUxsblBlUG91Q3o1dzV5?=
 =?utf-8?B?aWIzVFhNSC9XKzlrMjYraE9jMmxSS3R0UzJJSlVtcmVIRHVtcWNGSmNPVnM4?=
 =?utf-8?B?LzZVMk82enl3cWxKVk5wTjJ3UjhiSmRuMjU3WkM1b0kvN1poM2puSFNuYmps?=
 =?utf-8?B?OFZZS1M4ZXV0MnluMFNuT2ovRzRxQXNKT1pKLzl1U1pkcEUyZEJtSGFqbkwx?=
 =?utf-8?B?SzRaMDdyZnZ1cWR2SGlUNUVxQkx2VzFGQXVoaHg1Q3hCSHp4cUN2a3didUM0?=
 =?utf-8?B?amk0SzVoSjhTZEJYbkUwSWREVksyUnAxV01GSjNQZ0J5STdxd3pMbEdJNjFY?=
 =?utf-8?B?eW5oS0lLL0EzWHBHT1VSdEcxQWdWWDFaWUFCS0kyNmxlT1Q1V3Vxb3BHQTNu?=
 =?utf-8?Q?luvtLgsrJpPc2Bt3s89/LAmjJ?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7e2f975-9223-4f79-0686-08daad1c4936
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 13:10:22.8125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v7fr07QynhlDsUR+cYU0Fg1ddnPSUVTMqjSSnx0tal+kiD7LotmRhUk3gtefo/2wAb6EQDS8qSFohfTX9qnC/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5381

On Thu, Oct 13, 2022 at 02:17:54PM +0200, Jan Beulich wrote:
> On 13.10.2022 14:03, Roger Pau Monné wrote:
> > On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote:
> >> From: Peter Zijlstra <peterz@infradead.org>
> >>
> >> Having IBRS enabled while the SMT sibling is idle unnecessarily slows
> >> down the running sibling. OTOH, disabling IBRS around idle takes two
> >> MSR writes, which will increase the idle latency.
> >>
> >> Therefore, only disable IBRS around deeper idle states. Shallow idle
> >> states are bounded by the tick in duration, since NOHZ is not allowed
> >> for them by virtue of their short target residency.
> >>
> >> Only do this for mwait-driven idle, since that keeps interrupts disabled
> >> across idle, which makes disabling IBRS vs IRQ-entry a non-issue.
> >>
> >> Note: C6 is a random threshold, most importantly C1 probably shouldn't
> >> disable IBRS, benchmarking needed.
> >>
> >> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
> >> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >> Signed-off-by: Borislav Petkov <bp@suse.de>
> >> Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
> >> Signed-off-by: Borislav Petkov <bp@suse.de>
> >> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf5835bcdb96
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Thanks.
> 
> > One unrelated comment below.
> > [...]
> >> @@ -932,8 +939,6 @@ static void cf_check mwait_idle(void)
> >>  			pm_idle_save();
> >>  		else
> >>  		{
> >> -			struct cpu_info *info = get_cpu_info();
> >> -
> >>  			spec_ctrl_enter_idle(info);
> >>  			safe_halt();
> >>  			spec_ctrl_exit_idle(info);
> > 
> > Do we need to disable speculation just for the hlt if there's no
> > C state change?
> > 
> > It would seem to me like the MSR writes could add a lot of latency
> > when there's no C state change.
> 
> HLT enters (at least) C1, so is a C-state change to me as well. Plus
> we may remain there for a while, and during that time we'd like to
> not unduly impact the other thread.

OK, but it's not a "deeper C state" as mentioned in the commit
message.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:15:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:15:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422109.667955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy3U-0002aV-Bf; Thu, 13 Oct 2022 13:15:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422109.667955; Thu, 13 Oct 2022 13:15:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy3U-0002aO-8c; Thu, 13 Oct 2022 13:15:20 +0000
Received: by outflank-mailman (input) for mailman id 422109;
 Thu, 13 Oct 2022 13:15:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuK-0001tl-Vq
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:53 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b5ed4008-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:30 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5ed4008-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666352;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=cMqBsfjjVcDOSywKpK4KZmm9RxQrPRiX94KjnGLwZeE=;
  b=QrKiHGYZ92LDbGYz8shrZVkph82U/Sz3sFrq66uN3CeOodLg3seSDeOn
   svXIqskoes0pwM+CUaI+HDzokBvIkgg4iVuNUo+xJxMJ0m3fmkDpapzoT
   yOBJVYY0pheZOIQWKt70War33hHpZU5nwy6OXnqhGIs58a8TzBin53Mdq
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 82281658
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DAGtNqi4Qrx5uckmXImtJFX+X161ZRAKZh0ujC45NGQN5FlHY01je
 htvXz3XOfyKZDT2KYhwPImxpBkGsJDcmIBiHQc4/y48EXsb9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmPKsT5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KT1Q0
 uUfGGkGUgLdtum08qyDWsdmmf12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP
 ZBAL2MyMlKQOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFZ8Pzh/G+
 zKuE2LRXhcwaM2mwjq+zlWvq/PqxSziXd8IC+jtnhJtqALKnTFCYPEMbnO5ruO+kVWWQM9EJ
 gof/S9Ghbc23FymSJ/6RRLQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6cLqScCj
 wHT2YmzXHo27ePTGSn1GqqoQS2aZTYyNGgyPCQ4X1U06NvRvrkjoBjQd4M2eEKqteHdFTb1y
 jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQKDhcusOrp1WbVoU
 JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD327wk5JAVdoKiN2bGKuOGpdsRNMRS
 BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QQP8YpLFffon43PyZ8OlwBd2B1yMkC1
 WqzK57wXR7294w9pNZJewvt+eBynX1vrY8ibZv60w6mwdKjWZJhcp9caQPmUwzMxPnbyOkj2
 4oAapDiJtQ2eLGWXxQ7BqZKcQBXcillW8qrwyGVH8baSjdb9KgaI6e56dscl0ZNxcy5Ss+gE
 qmBZ3Jl
IronPort-HdrOrdr: A9a23:ZiwMNaFA3YzsrB6TpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q
 aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YYT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82281658"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 13/17] libs/light: Rework generation of include/_libxl_*.h
Date: Thu, 13 Oct 2022 14:05:09 +0100
Message-ID: <20221013130513.52440-14-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Instead of moving the public "_libxl_*.h" headers, we make a copy to
the destination so that make doesn't try to remake the targets
"_libxl_*.h" in libs/light/ again.

A new .PRECIOUS target is added to tell make to not deletes the
intermediate targets generated by "gentypes.py".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/libs/light/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 4a8b0f7bcf..9329055c98 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -215,6 +215,8 @@ libxl_internal_json.h: _libxl_types_internal_json.h
 $(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
 $(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
 
+# This exploits the 'multi-target pattern rule' trick.
+# gentypes.py should be executed only once to make all the targets.
 _libxl_type%.h _libxl_type%_json.h _libxl_type%_private.h _libxl_type%.c: libxl_type%.idl gentypes.py idl.py
 	$(eval stem = $(notdir $*))
 	$(PYTHON) gentypes.py libxl_type$(stem).idl __libxl_type$(stem).h __libxl_type$(stem)_private.h \
@@ -224,8 +226,10 @@ _libxl_type%.h _libxl_type%_json.h _libxl_type%_private.h _libxl_type%.c: libxl_
 	$(call move-if-changed,__libxl_type$(stem)_json.h,_libxl_type$(stem)_json.h)
 	$(call move-if-changed,__libxl_type$(stem).c,_libxl_type$(stem).c)
 
-$(XEN_INCLUDE)/_%.h: _%.h
-	$(call move-if-changed,_$*.h,$(XEN_INCLUDE)/_$*.h)
+.PRECIOUS: _libxl_type%.h _libxl_type%.c
+
+$(XEN_INCLUDE)/_libxl_%.h: _libxl_%.h
+	cp -f $< $@
 
 .PHONY: acpi
 acpi:
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:16:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:16:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422126.667965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy46-0003Al-LJ; Thu, 13 Oct 2022 13:15:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422126.667965; Thu, 13 Oct 2022 13:15:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy46-0003Ae-IZ; Thu, 13 Oct 2022 13:15:58 +0000
Received: by outflank-mailman (input) for mailman id 422126;
 Thu, 13 Oct 2022 13:15:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixui-0002ig-SZ
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:06:16 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cfc32739-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:06:14 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfc32739-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666373;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=CGFwXlrWynx6TK1V9fLINkj8ydS6NN68SzpiLukviOo=;
  b=DxqdkTsXzeCaAMHsGqt6Wc/Jj/DkzkBeyhgVelNDB9rpM5nhy9NIR7OF
   Beoky3gF8ezAhi/56O5Gis+gEBK5c4INg0QUvAvkCrMPTBD9th3rFpLm+
   3zfo743qzM1a+tm6CqEaAHwvnj3tSL9X1z5TNqHGVroQ5CL2HqEkf7deM
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 85173851
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bbyzlaLXB5fQ5GULFE+R1ZUlxSXFcZb7ZxGr2PjKsXjdYENS3j0Dn
 DMbDGyAOf7ZNmCkeNh3bt6+9k8Cv5CDydY2GVdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4WhA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fakh4floBHFwz
 ONCMxUEbi6Oibrrwr3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO
 YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYIeMJYfaGJw9ckCwj
 T7dvEbJPRQhDtGe7WPa9SiMncXWknauMG4VPOLhraM76LGJ/UQRBwcRTkCTuuSihwi1XNc3A
 1MQ0jojq+417kPDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZ8hMcO7ZFsA2Zwj
 xnQwo2vVWcHXKCppWy10o6Psiy3KRYsMjUZQCYEcwYLu4Thr9Rm5v7QdepLHKmwh9zzPDj/x
 TGWsSQz74kuYd43O7aTpg6e3W/1znTdZktsv1iMADr5hu9sTNT9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQQyd3XC3273k5JGQWy3yGAWGauRGpxYEQIFm
 WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq7C66MNoIWPMcoLmdrGR2CgmbJhgjQfLUEy/lja
 f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjG8vhT6pLHPSb9dFvwGAHRBgzPxP/b/V69H
 hc2H5fi9iizp8WnPnmKrt9NcwpXRZX5bLivw/Fqmie4ClIOMAkc5zX5mutJl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:JbBuk6gd5vwMeqsH4M/H4LcbiHBQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="85173851"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets prerequisites
Date: Thu, 13 Oct 2022 14:05:10 +0100
Message-ID: <20221013130513.52440-15-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

No need for $(AUTOSRCS), GNU make can generate them as needed when
trying to build them as needed when trying to build the object. Also,
those two AUTOSRCS don't need to be a prerequisite of "all". As for
the "clean" target, those two files are already removed via "_*.c".

We don't need $(AUTOINCS) either:
- As for both _libxl_savm_msgs*.h headers, we are adding more
  selective dependencies so the headers will still be generated as
  needed.
- "clean" rule already delete the _*.h files, so AUTOINCS aren't needed
  there.

"libxl_internal_json.h" doesn't seems to have ever existed, so the
dependency is removed.

Add few prerequisite for "libxl_internal.h" so all headers that it
depends on should be generated. And have $(SAVE_HELPER_OBJS) depends
on "libxl_internal.h".

Rework objects prerequisites, to have them dependents on either
"libxl.h" or "libxl_internal.h". "libxl.h" is not normally included
directly in the source code as "libxl_internal.h" is used instead. But
we are adding "libxl.h" as prerequisite of "libxl_internal.h", so
generated headers will still be generated as needed.

"testidl.c" doesn't depends on "libxl.h" but "testidl.o" does. Also
use automatic variables $< and $@.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/libs/light/Makefile | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 9329055c98..274e8350bb 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -147,9 +147,6 @@ LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS_INSIDE),libxl_test_$t.opic)
 TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t.o) test_common.o
 TEST_PROGS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t)
 
-AUTOINCS = _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
-AUTOSRCS = _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
-
 CLIENTS = testidl libxl-save-helper
 
 SAVE_HELPER_OBJS = libxl_save_helper.o _libxl_save_msgs_helper.o
@@ -177,13 +174,13 @@ libxl_x86_acpi.o libxl_x86_acpi.opic: CFLAGS += -I$(XEN_ROOT)/tools
 $(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenguest)
 
 testidl.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight)
-testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
-	$(PYTHON) gentest.py libxl_types.idl testidl.c.new
-	mv testidl.c.new testidl.c
+testidl.c: libxl_types.idl gentest.py
+	$(PYTHON) gentest.py $< $@.new
+	mv -f $@.new $@
 
-all: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
+all: $(CLIENTS) $(TEST_PROGS)
 
-$(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
+$(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): libxl.api-ok
 
 $(DSDT_FILES-y): acpi
 
@@ -195,7 +192,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	$(PERL) $^
 	touch $@
 
-_libxl.api-for-check: $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
+_libxl.api-for-check: $(XEN_INCLUDE)/libxl.h
 	$(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \
 		-DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \
 		>$@.new
@@ -207,13 +204,22 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
 	$(PERL) -w $< $@ >$@.new
 	$(call move-if-changed,$@.new,$@)
 
+#
+# headers dependencies on generated headers
+#
 $(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h
 $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
+libxl_internal.h: $(XEN_INCLUDE)/libxl.h $(XEN_INCLUDE)/libxl_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
-libxl_internal_json.h: _libxl_types_internal_json.h
+libxl_internal.h: _libxl_save_msgs_callout.h
 
-$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
+#
+# objects dependencies on headers that depends on generated headers
+#
+$(TEST_PROG_OBJS): $(XEN_INCLUDE)/libxl.h
 $(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
+$(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h _libxl_save_msgs_helper.h
+testidl.o: $(XEN_INCLUDE)/libxl.h
 
 # This exploits the 'multi-target pattern rule' trick.
 # gentypes.py should be executed only once to make all the targets.
@@ -260,5 +266,4 @@ clean::
 	$(RM) testidl.c.new testidl.c *.api-ok
 	$(RM) $(TEST_PROGS) libxenlight_test.so libxl_test_*.opic
 	$(RM) -r __pycache__
-	$(RM) $(AUTOSRCS) $(AUTOINCS)
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:16:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:16:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422129.667977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy49-0003RM-0u; Thu, 13 Oct 2022 13:16:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422129.667977; Thu, 13 Oct 2022 13:16:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy48-0003RD-U0; Thu, 13 Oct 2022 13:16:00 +0000
Received: by outflank-mailman (input) for mailman id 422129;
 Thu, 13 Oct 2022 13:15:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuK-0001tl-1f
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:52 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b5eda9ad-4af7-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:05:29 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5eda9ad-4af7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666350;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Nc4WbeeXR+sXTmS5lu4Ec75pp9DLw9YmC4v+YNyuXWw=;
  b=Tb3KCDrOjpiDjPo+MbrBEQaJW21cfgNCPLnMHJM9T8N/D2TTN6yeCW/d
   Dcct4TzB/m7ZecTQ1bxIoQCnMLdPGd0Jn5UdLqaFhZ2xf4wUcaEE/z36U
   gvfNq5ApbLiXlZ/Nlt2+4YdAR3dW/79jnPge5AjmULp4jzqD+CMVzJcDf
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 81760266
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:X+7m3assN0pMYRB1t+4OpIHSbufnVFNeMUV32f8akzHdYApBsoF/q
 tZmKW3QMvaMNmakf9B/a4y3oB8DsMTSyIU2TlZlq3xnF3tA+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakQ5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkU/
 84xFS5XdyrAiuGY/qyJY9k9qoMaeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI
 ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUMwRjA/
 DyYl4j/KhZEDIedkAqCy1jvmrD0mXLjeJkVCpTto5aGh3XMnzdOWXX6T2CTo/ajjVWlc8lCM
 EFS8S0rxYAt8GS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/
 gbXxZWzX2Up6eDLDyLGnluJkd+sEXIfH0Y/e3Udd0gI4PfdvrMavkPjCe82RcZZkebJMT33x
 jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV
 ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRz3phZPnqgKulmSwXuF1e5VEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPMUvLFffpH8xPBT4M4XRfK8EyPhXB
 HtmWZz0USZy5VpPllJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WUN5vYwtaQLWBt3VGYve/205B
 f4DaJbRo/ieOcWiChTqHXk7dAxacCdqW86s9qS6tIere2JbJY3oMNeJqZtJRmCvt/09ejvgl
 p1lZnJl9Q==
IronPort-HdrOrdr: A9a23:c21tX6xptsK8G+jSPUx4KrPwFL1zdoMgy1knxilNoRw8SKKlfq
 eV7ZImPH7P+U4ssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U
 4JSdkGNDSaNzlHZKjBjzVQa+xQouW6zA==
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81760266"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: [XEN PATCH for-4.17 v5 15/17] libs/light: Makefile cleanup
Date: Thu, 13 Oct 2022 14:05:11 +0100
Message-ID: <20221013130513.52440-16-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Rework "libacpi.h" include in "libxl_x86_acpi.c" as to be more
selective about the include path and only add "tools/libacpi/". Also
"libxl_dom.c" don't use "libacpi.h" anymore. Use "-iquote" for libacpi
headers.

Get rid of the weird "$(eval stem =" in the middle of a recipe and use
a make automatic variable "$(*F)" instead.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v4:
    - new patch

 tools/libs/light/Makefile         | 16 +++++++---------
 tools/libs/light/libxl_x86_acpi.c |  2 +-
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 274e8350bb..250cc3bd2c 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -169,8 +169,7 @@ LDLIBS += $(LDLIBS-y)
 $(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
 $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\"
 $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore)
-libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools  # include libacpi/x86.h
-libxl_x86_acpi.o libxl_x86_acpi.opic: CFLAGS += -I$(XEN_ROOT)/tools
+libxl_x86_acpi.o libxl_x86_acpi.opic: CFLAGS += -iquote $(ACPI_PATH)
 $(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenguest)
 
 testidl.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight)
@@ -224,13 +223,12 @@ testidl.o: $(XEN_INCLUDE)/libxl.h
 # This exploits the 'multi-target pattern rule' trick.
 # gentypes.py should be executed only once to make all the targets.
 _libxl_type%.h _libxl_type%_json.h _libxl_type%_private.h _libxl_type%.c: libxl_type%.idl gentypes.py idl.py
-	$(eval stem = $(notdir $*))
-	$(PYTHON) gentypes.py libxl_type$(stem).idl __libxl_type$(stem).h __libxl_type$(stem)_private.h \
-		__libxl_type$(stem)_json.h  __libxl_type$(stem).c
-	$(call move-if-changed,__libxl_type$(stem).h,_libxl_type$(stem).h)
-	$(call move-if-changed,__libxl_type$(stem)_private.h,_libxl_type$(stem)_private.h)
-	$(call move-if-changed,__libxl_type$(stem)_json.h,_libxl_type$(stem)_json.h)
-	$(call move-if-changed,__libxl_type$(stem).c,_libxl_type$(stem).c)
+	$(PYTHON) gentypes.py libxl_type$(*F).idl __libxl_type$(*F).h __libxl_type$(*F)_private.h \
+		__libxl_type$(*F)_json.h  __libxl_type$(*F).c
+	$(call move-if-changed,__libxl_type$(*F).h,_libxl_type$(*F).h)
+	$(call move-if-changed,__libxl_type$(*F)_private.h,_libxl_type$(*F)_private.h)
+	$(call move-if-changed,__libxl_type$(*F)_json.h,_libxl_type$(*F)_json.h)
+	$(call move-if-changed,__libxl_type$(*F).c,_libxl_type$(*F).c)
 
 .PRECIOUS: _libxl_type%.h _libxl_type%.c
 
diff --git a/tools/libs/light/libxl_x86_acpi.c b/tools/libs/light/libxl_x86_acpi.c
index 57a6b63790..22eb160659 100644
--- a/tools/libs/light/libxl_x86_acpi.c
+++ b/tools/libs/light/libxl_x86_acpi.c
@@ -16,7 +16,7 @@
 #include "libxl_arch.h"
 #include <xen/hvm/hvm_info_table.h>
 #include <xen/hvm/e820.h>
-#include "libacpi/libacpi.h"
+#include "libacpi.h"
 
  /* Number of pages holding ACPI tables */
 #define NUM_ACPI_PAGES 16
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:16:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:16:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422134.667988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy4O-00041g-9U; Thu, 13 Oct 2022 13:16:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422134.667988; Thu, 13 Oct 2022 13:16:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy4O-00041Y-6S; Thu, 13 Oct 2022 13:16:16 +0000
Received: by outflank-mailman (input) for mailman id 422134;
 Thu, 13 Oct 2022 13:16:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuT-0002ig-7w
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:06:01 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c4a10fd2-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4a10fd2-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666354;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=xNKHGKv0xiseesErXwvSTNU3NRH6cY3P70E/A0khyJY=;
  b=JKkLA/3JYRZ57DEFovQrgvxhRHuhWN83fhFNKB3SbqWS7ATffIxyIo0b
   qdBQ4OL3Sl1egie0WwLmZdoiVsoGRf8tOF6PDPSl+Bmh1zvqRbqBT7Tct
   3Pb4aWGMy/YGQwMN8aHOEdO2hwLlQUeL06O5yhmCDulStlX0BimWCpRXL
   4=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 83071582
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:z8VRha29XR4Hg1fS1fbD5dZxkn2cJEfYwER7XKvMYLTBsI5bpzECy
 mobXGyCMvmJNmOhfthxaIvj9htX7MTXnYUwSgZppC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpD5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUeocxpUDl/2
 cc3EzAdKQiPrPK66+O0H7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqOIoPTGJUP9qqej
 n3l7kfcUhcUDsa8+Bq/sW2jtuSMhwquDer+E5Xnr6U30TV/3Fc7BBQIWHOhrPK+i0r4XMhQQ
 2QL/gI+oK5081akJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj
 AbPxo63Q2w02FGIdZ6D3rHPhy3jYRk5FkA5ZT9DVQcu89XI8Y5m23ojUe1fOKKyi9T0HxT5z
 DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip
 zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1QvHNFBz3oRZPmLy8BxkvTHqFyu5eJVfUj
 Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CK2KNoIWOsYuLVXvEMRSiam4hjmFraTRuftnZ
 cfznTiEVx729piLPBLpHrxAgNfHNwg1xH/JRICT8ilLJYG2PSfNIYrpxXPUMYjVGovY/1iOm
 zueXuPWoyhivBrWO3WHrNFCcw5QcBDWx/ne8qRqSwJKGSI+cElJNhMb6e9Jl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:Y6OquKBfZlxZKZLlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq
 GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ
 uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr
 WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="83071582"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>,
	Christian Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>
Subject: [XEN PATCH for-4.17 v5 17/17] tools: Rework linking options for ocaml binding libraries
Date: Thu, 13 Oct 2022 14:05:13 +0100
Message-ID: <20221013130513.52440-18-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Using a full path to the C libraries when preparing one of the ocaml
binding for those libraries make the binding unusable by external
project. The full path is somehow embedded and reused by the external
project when linking against the binding.

Instead, we will use the proper way to link a library, by using '-l'.
For in-tree build, we also need to provide the search directory via
'-L'.

(The search path -L are still be embedded, but at least that doesn't
prevent the ocaml binding from been used.)

Related-to: xen-project/xen#96
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    This patch only partially resolve xen-project/xen#96. At least with this
    patch, the ocaml binding can be used by external project, but those
    project will still "see" and try to use the rpath and lib search path as
    the -L and -W,-rpath-link are still embedded in the ocaml binding.
    
    I'm working on a more involve series of patch which would remove the
    unnecessary flags. (This would mean that oxenstored and the ocaml test
    will need those ldflags, instead of the binding.)
    
    v5:
    - new patch

 tools/ocaml/libs/eventchn/Makefile   | 2 +-
 tools/ocaml/libs/xc/Makefile         | 2 +-
 tools/ocaml/libs/xentoollog/Makefile | 2 +-
 tools/ocaml/libs/xl/Makefile         | 2 +-
 tools/Rules.mk                       | 8 ++++++++
 5 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/tools/ocaml/libs/eventchn/Makefile b/tools/ocaml/libs/eventchn/Makefile
index 7362a28d9e..dc560ba49b 100644
--- a/tools/ocaml/libs/eventchn/Makefile
+++ b/tools/ocaml/libs/eventchn/Makefile
@@ -8,7 +8,7 @@ OBJS = xeneventchn
 INTF = $(foreach obj, $(OBJS),$(obj).cmi)
 LIBS = xeneventchn.cma xeneventchn.cmxa
 
-LIBS_xeneventchn = $(LDLIBS_libxenevtchn)
+LIBS_xeneventchn = $(call xenlibs-ldflags-ldlibs,evtchn)
 
 all: $(INTF) $(LIBS) $(PROGRAMS)
 
diff --git a/tools/ocaml/libs/xc/Makefile b/tools/ocaml/libs/xc/Makefile
index 67acc46bee..3b76e9ad7b 100644
--- a/tools/ocaml/libs/xc/Makefile
+++ b/tools/ocaml/libs/xc/Makefile
@@ -10,7 +10,7 @@ OBJS = xenctrl
 INTF = xenctrl.cmi
 LIBS = xenctrl.cma xenctrl.cmxa
 
-LIBS_xenctrl = $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest)
+LIBS_xenctrl = $(call xenlibs-ldflags-ldlibs,ctrl guest)
 
 xenctrl_OBJS = $(OBJS)
 xenctrl_C_OBJS = xenctrl_stubs
diff --git a/tools/ocaml/libs/xentoollog/Makefile b/tools/ocaml/libs/xentoollog/Makefile
index 9ede2fd124..1645b40faf 100644
--- a/tools/ocaml/libs/xentoollog/Makefile
+++ b/tools/ocaml/libs/xentoollog/Makefile
@@ -13,7 +13,7 @@ OBJS = xentoollog
 INTF = xentoollog.cmi
 LIBS = xentoollog.cma xentoollog.cmxa
 
-LIBS_xentoollog = $(LDLIBS_libxentoollog)
+LIBS_xentoollog = $(call xenlibs-ldflags-ldlibs,toollog)
 
 xentoollog_OBJS = $(OBJS)
 xentoollog_C_OBJS = xentoollog_stubs
diff --git a/tools/ocaml/libs/xl/Makefile b/tools/ocaml/libs/xl/Makefile
index 7c1c4edced..22d6c93aae 100644
--- a/tools/ocaml/libs/xl/Makefile
+++ b/tools/ocaml/libs/xl/Makefile
@@ -15,7 +15,7 @@ LIBS = xenlight.cma xenlight.cmxa
 
 OCAMLINCLUDE += -I ../xentoollog
 
-LIBS_xenlight = $(LDLIBS_libxenlight)
+LIBS_xenlight = $(call xenlibs-ldflags-ldlibs,light)
 
 xenlight_OBJS = $(OBJS)
 xenlight_C_OBJS = xenlight_stubs
diff --git a/tools/Rules.mk b/tools/Rules.mk
index a165dc4bda..34d495fff7 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -113,6 +113,14 @@ define xenlibs-ldflags
     $(foreach lib,$(1),-L$(XEN_ROOT)/tools/libs/$(lib))
 endef
 
+# Flags for linking against all Xen libraries listed in $(1) but by making use
+# of -L and -l instead of providing a path to the shared library.
+define xenlibs-ldflags-ldlibs
+    $(call xenlibs-ldflags,$(1)) \
+    $(foreach lib,$(1), -l$(FILENAME_$(lib))) \
+    $(foreach lib,$(1),$(xenlibs-ldlibs-$(lib)))
+endef
+
 define LIB_defs
  FILENAME_$(1) ?= xen$(1)
  XEN_libxen$(1) = $$(XEN_ROOT)/tools/libs/$(1)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:16:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:16:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422141.667998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy4P-0004L1-Hm; Thu, 13 Oct 2022 13:16:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422141.667998; Thu, 13 Oct 2022 13:16:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy4P-0004Kl-EY; Thu, 13 Oct 2022 13:16:17 +0000
Received: by outflank-mailman (input) for mailman id 422141;
 Thu, 13 Oct 2022 13:16:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d8dk=2O=citrix.com=prvs=278749026=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1oixuQ-0002ig-ME
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:05:58 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c3cfa8c6-4af7-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:05:53 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3cfa8c6-4af7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665666353;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=yZl8f6nskAbfIqIwFywI0ObjvI50ZytLF896MN4MC2E=;
  b=XxnQtvS0tflVy8S9caQQJq0chyqtNj67qLALNnpgj5bkpjD4MxgqS4p/
   GCncRIlG0i5MpNi/3C9iraubyGQqk7MF7Fil1ZuHaBFWxK65ZqKI76oM0
   NWU5HNWe9oLBs81ntKSHoALZaKVJDu9JUL86kOpeqbx9sQX2o/6p8QFTA
   M=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 2.7
X-MesageID: 83071574
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g4V3VKB6T0bjpBVW/zTjw5YqxClBgxIJ4kV8jS/XYbTApG4kg2ZRy
 mseWDuDPvqDN2egetp+Ydiw/EpXusXUm9VrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2p4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k8B4s9q8dORlgR3
 u0pNDYJQEyuvMuflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN
 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oi2aIWMJ4PWLSlTtn7Fh
 D3roEP+OR0hJv+v22a37UCLm/CayEsXX6pNTeblp5aGmma73GsIAgcRUli9ifa8g0+6HdlYL
 iQ85S4GvaU0skuxQbHVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3
 1mGt9rzAHpkt7j9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iIsJiDeeb+8kKfGen+zpHzXen
 x2xhQFr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4
 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJFcFg
 2eJ42u9AaO/21P7BZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzhVyyflnY
 cnEKJzE4ZMm5UNPlWPeegvg+eVzmnBWKZ37H/gXMChLIZLBPSXIGN/pwXOFb/wj7bPsnTg5B
 +13bpLSoyizpcWkPUE7B6ZPcg1RRZX6bLiqw/Fqmhmre1Y2RT5wVaGLnNvMueVNxsxoqwsBx
 VnlMmcw9bY1rSCvxdmiApy7VI7SYA==
IronPort-HdrOrdr: A9a23:pjK8NKspIVwuF3I4bWluNzSI7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpHnJYVcqKQkdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyIMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="83071574"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
	<rosbrookn@gmail.com>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework gengotypes.py and generation of *.gen.go
Date: Thu, 13 Oct 2022 14:05:12 +0100
Message-ID: <20221013130513.52440-17-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

gengotypes.py creates both "types.gen.go" and "helpers.gen.go", but
make can start gengotypes.py twice. Rework the rules so that
gengotypes.py is executed only once.

Also, add the ability to provide a path to tell gengotypes.py where to
put the files. This doesn't matter yet but it will when for example
the script will be run from tools/ to generate the targets.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
---

Notes:
    v5:
    - released-acked to fix occasional CI build issue
    
    v4:
    - new patch

 tools/golang/xenlight/Makefile      |  6 ++++--
 tools/golang/xenlight/gengotypes.py | 10 +++++++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
index 00e6d17f2b..c5bb6b94a8 100644
--- a/tools/golang/xenlight/Makefile
+++ b/tools/golang/xenlight/Makefile
@@ -15,8 +15,10 @@ all: build
 
 GOXL_GEN_FILES = types.gen.go helpers.gen.go
 
-%.gen.go: gengotypes.py $(LIBXL_SRC_DIR)/libxl_types.idl $(LIBXL_SRC_DIR)/idl.py
-	LIBXL_SRC_DIR=$(LIBXL_SRC_DIR) $(PYTHON) gengotypes.py $(LIBXL_SRC_DIR)/libxl_types.idl
+# This exploits the 'multi-target pattern rule' trick.
+# gentypes.py should be executed only once to make all the targets.
+$(subst .gen.,.%.,$(GOXL_GEN_FILES)): gengotypes.py $(LIBXL_SRC_DIR)/libxl_types.idl $(LIBXL_SRC_DIR)/idl.py
+	LIBXL_SRC_DIR=$(LIBXL_SRC_DIR) $(PYTHON) gengotypes.py $(LIBXL_SRC_DIR)/libxl_types.idl $(@D)/types.gen.go $(@D)/helpers.gen.go
 
 # Go will do its own dependency checking, and not actuall go through
 # with the build if none of the input files have changed.
diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.py
index ac1cf060dd..ff4c2ad216 100644
--- a/tools/golang/xenlight/gengotypes.py
+++ b/tools/golang/xenlight/gengotypes.py
@@ -723,7 +723,13 @@ def xenlight_golang_fmt_name(name, exported = True):
     return words[0] + ''.join(x.title() for x in words[1:])
 
 if __name__ == '__main__':
+    if len(sys.argv) != 4:
+        print("Usage: gengotypes.py <idl> <types.gen.go> <helpers.gen.go>", file=sys.stderr)
+        sys.exit(1)
+
     idlname = sys.argv[1]
+    path_types = sys.argv[2]
+    path_helpers = sys.argv[3]
 
     (builtins, types) = idl.parse(idlname)
 
@@ -735,9 +741,11 @@ if __name__ == '__main__':
 // source: {}
 
 """.format(os.path.basename(sys.argv[0]),
-           ' '.join([os.path.basename(a) for a in sys.argv[1:]]))
+           os.path.basename(sys.argv[1]))
 
     xenlight_golang_generate_types(types=types,
+                                   path=path_types,
                                    comment=header_comment)
     xenlight_golang_generate_helpers(types=types,
+                                     path=path_helpers,
                                      comment=header_comment)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:20:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:20:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422173.668010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy8G-0006U2-2B; Thu, 13 Oct 2022 13:20:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422173.668010; Thu, 13 Oct 2022 13:20:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy8F-0006Tv-VN; Thu, 13 Oct 2022 13:20:15 +0000
Received: by outflank-mailman (input) for mailman id 422173;
 Thu, 13 Oct 2022 13:20:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oiy8F-0006Tp-BV
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:20:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiy8E-0007xR-4u; Thu, 13 Oct 2022 13:20:14 +0000
Received: from [15.248.2.148] (helo=[10.24.69.9])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oiy8D-0008AZ-VP; Thu, 13 Oct 2022 13:20:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nkPnIZvevJsTXW7wMoMvuCQk9ans1LbOAtfDtWjqam8=; b=GY4B8CGJn3Cv15/06fvodiPXN/
	75Jfs75+wHGSlR+mAqhnOvkbqEJsnhTpES9oAe34B4l1V3iTXT8B6NQ4XG+MaNPcnqMwbMkW7d+wd
	fNIvpZ6gWC0JwfgiTItNJlVq4KWaDZeihw5o4mbPmMH3siCjLFTwlMwRWGVC8lv6Psbw=;
Message-ID: <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
Date: Thu, 13 Oct 2022 14:20:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 13/10/2022 12:47, Ayan Kumar Halder wrote:
> Hi Arm mantainers/Folks,

Hello,

> Please refer to the discussion 
> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
> 
> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed 
> virtual platform.
> 
> Zephyr is trying to read GICR_TYPER which is a 64 bit register using 
> ldrd instruction.
> 
> As GICR is emulated by Xen, so this instruction gets trapped with HSR = 
> 0x9200000c.
> 
> As ISV is 0, so Xen cannot emulate this instruction.
> 
> The proposed solution is to use two sys_read32() on GICR_TYPER to return 
> the lower and upper 32 bits.
> 
> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
> 
> Now, for Xen to emulate this read, I have proposed the modifications (in 
> my last comment).

I am confused. Looking at the emulation of GICR_TYPER in Xen 
(arch/arm/vgic-v3.c), the code should already be able to handle 32-bit 
access.

I doesn't look like we need to modify Xen. What did I miss?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:21:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:21:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422178.668021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy9e-00072Q-CD; Thu, 13 Oct 2022 13:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422178.668021; Thu, 13 Oct 2022 13:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiy9e-00072J-8z; Thu, 13 Oct 2022 13:21:42 +0000
Received: by outflank-mailman (input) for mailman id 422178;
 Thu, 13 Oct 2022 13:21:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiy9c-00072B-OB
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:21:40 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f7393b48-4af9-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:21:39 +0200 (CEST)
Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 09:21:36 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by CH0PR03MB5988.namprd03.prod.outlook.com (2603:10b6:610:e3::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 13:21:34 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 13:21:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7393b48-4af9-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665667299;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=BdEEJ4TFbjCjankn+sirz249XxLJHfUH4PwHRHJ1dE8=;
  b=Nq0HKtKFYeJjNUghGeyyyFNECApGCsF0ojsoSpuwbf2ND3nPmQNMl3M9
   aY1jBe9IwtWHDjO/dA/Mjb4WDc3ky7VsKfzWR1l+itkRtxldbGlObFRMe
   fPON04B1y7yKn3l4VBuN9aLXbPOIdNGRK6ZOXZDQQRKlorS+rsDwFpxfy
   Y=;
X-IronPort-RemoteIP: 104.47.58.109
X-IronPort-MID: 82283653
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:y1/mOahWdsld2XnPXcNloymQX161VxEKZh0ujC45NGQN5FlHY01je
 htvX22FbqrYNzD9Kox2YNnk8U4A6pLWzd42TQBrry89Fiob9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmPKsT5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KT5p+
 vk3NG0iVDusqfPozo+ZCfJOv9t2eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQguFTuGIO9ltiiX8Jak1zev
 mvb12/4HgsbJJqUzj/tHneE1rWVzXilBdl6+LuQxPFNn0TPnWMqFTYaRVv8iqWfo0OEcocKQ
 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUSyAyL0LuS3A+fCUANVDsHY9sj3OcpQRQ62
 1nPmMnmbRR/vbvQRX+D+7O8qTKpJTNTPWIEfTUDTwYO/5/kuo5bs/7UZtNqEarwgtirHzj1m
 miOtHJn3+RVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg
 ZTOs5L2ADwmZX1VqBGwfQ==
IronPort-HdrOrdr: A9a23:ITFly6mXGVwpnyqKufQ9H0Z7AWbpDfPJimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe
 ChD4d81k2dUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInpy6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zUYIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6R9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF79tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcoa+d
 FVfY7hDcttAB2nhyizhBgv/DXsZAV5Iv6+eDlPhiTPuAIm3EyQzCMjtb8idzk7hdEAoqJ/lp
 X525RT5c5zp/AtHNxA7cc6ML6K4z/2MGbxGVPXB2jbP4c6HF+Ig6LLwdwOlZGXkdozvdMPpK
 g=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82283653"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Tdb8cuD+XtiVo9BxclI6xu+vH66X+aW4JcutRa7HqzsjjsDf4HFyY/C2ppvoaDL3E2ZU4+1PwOnFiZj+IsH4zoV/mLFYLKZXjxbxbQSoIf1GTSSPro8QVhp4V/Grzs1KcY8LEfd4dP5h6qrQJPWbOj+aiFwf9SsKtVnB06N34zSPsTFaEumRnd78pT6HlKRabiDhsDVIc2ANamU7kVBLDUlK/QogNqR/tMccuIQ1hrlKix4zDCN9Aolp4WicsI2TfJtQqzl0+1XbAydxDJmx39pXMr5UESjObAJTA6soN4JjuJNieyBTXskCIFsvwiuLktOoxkLyVSmAomyQ3tGz4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fNS9IxhjXbPraLnCiQ3UlcAVBed+jkBVoJOA3z0D2CA=;
 b=QByp2i//eM5/aCEcx3Ppy3nx0rDwrLQ4rAtT/UDD9PGP9SFYBhiNhq290UbHzwlIl4UC/AdnBUVEnwwvJmIHmW390K8MjK+JYGgvxgCPdDxDatC4LN1mPjNsnOlRo3gmPF1bFjEcx/42EBk0pj7fLdSwvtGtSgySw4R38VdkZQYRMpzZhJZgSM01S/9jI/y+m6DAfwr/pPF5BSLVd+SiFOwVQKBWvS95srZYRtn2z/Fh4rlS+l0iRBpftU9SYm+zgDaD0V+D3hkFNgSRozj3WTGTfPUNgsAqKwpwU+kK9tfyj4GtzONrVNUhARvIxJAgYFKQ79o/UzduvJXeefqphQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fNS9IxhjXbPraLnCiQ3UlcAVBed+jkBVoJOA3z0D2CA=;
 b=KXvl7JWuprl/IE3UXi3Tz4DvWVY2kAOWt9Zbk8RGfLGmb8ZUpbYeGEQjX2b5xvjVrwtBEaiss8AtIQZL8mCdH5irzyvvaprpRpcqIhZkG7MHk7jJS7cYuREyWemOkq0zNEWkeMy5QyK/zM4jTyWKUNPXY2Ay4Bq7geTGZO+TEjY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 15:21:28 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 1/4] amd/virt_ssbd: set SSBD at vCPU context
 switch
Message-ID: <Y0gQ2P5dcUDDdGPS@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-2-roger.pau@citrix.com>
 <0ac3e95f-293e-d395-f69d-846f87edc0ea@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0ac3e95f-293e-d395-f69d-846f87edc0ea@suse.com>
X-ClientProxiedBy: PA7P264CA0082.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:102:349::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CH0PR03MB5988:EE_
X-MS-Office365-Filtering-Correlation-Id: 2edcb0fc-53c8-4a6e-5d01-08daad1dd939
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9Je/Yr01e98GEM5lpxH41mZPNLDmgTygtW1a42XuL77VOJZ2q3+C102gZNMoXApohnJBsRYzWlUphJDv0nADQtEGnN1m4wfZqDAsxrgnGg57idceBXIm71k0K/ElTOZISFIoCRkwbyfoEVGkGwrbIOHRJiBI4A9W6ifPxBqdhOSUGZeKD/+wDsFGNPe33QcEAgWknm1PRrXMrydXkERXOeY0khqWlPhXs/S+olyzvQ11rcEL7rvBtjuyz7v/v6L1btr+bu1D73BO2B6y+1pG2u2URO+pyiB+3BK1F1QjcTxZJO5kKnYdo6l7jz18TqIm4bknat+nUTq+jquP30XfDmQGySCK0WNwmZ3fGYfY49V42G2x6y3Zz1lJ1aPDfktkEjKEeVsG1x1AxYvZGK117+cYqIaMDclgdU8K5ZD/Q3IzOh8muzf2KeZ3hOZ3m6fzFB25wrJGlFKp/wIdU5OSRojeL7cywTZ2+8j9hw6cNzyEH30v69Y2To3U9jnPCAP4rn80RQLVXPRAFwvAb65LV66BHh2TIBAzclInXUw3tvKBr5jppW6tipQfWe3+zrXc+ipgg7teF2qPMn9q/U+sIEbEFJ06nxI7b6U/fbPAtmeWumbMaiRGv+TCLTJqsrmDAXKf+Leps+Nrrfxk76+I26dif78f3/hAQl9hqggb81AOq//7GsN7HrVhiddI/164KGoxrnJs3nt2feVqXgIw9w==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199015)(85182001)(186003)(9686003)(26005)(6512007)(41300700001)(53546011)(2906002)(316002)(33716001)(8936002)(66476007)(6916009)(54906003)(86362001)(66556008)(8676002)(4326008)(66946007)(6666004)(38100700002)(6506007)(82960400001)(478600001)(5660300002)(6486002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEV0bUxMZ0JxbDY4dWxIdFRoZU9PZ2IvRTU0NnJoZlBGUHVEczhxNHQrVDcr?=
 =?utf-8?B?cDROYlpuenNyNXg1NE0yZXhuQTNucWY4UUljeGlGU2kwOFA0RFhQTFhyNXVR?=
 =?utf-8?B?UVFqUWZUeGhkVTNBMGViNGUwdFVSVmV6d2VqaTZURzhqelZ6V0hJN1dpcWtn?=
 =?utf-8?B?aXBBL29YNTdWRjNQKzNkazIrMWhDNFZSN2FINGFWUVF0ZW9WM1VlUGhwcUpm?=
 =?utf-8?B?aFlwa2NWbVBiMzBEd1YybEErWjkxQlE5R2JLa0Z6cE1mNW1lZ2VTWHVJYVFt?=
 =?utf-8?B?cU9xam8ydm1QT1JrcXEzajJsRGFqVEJNbHE2b0QwanhDVnVrKzdZUlZrUVhz?=
 =?utf-8?B?Rk04WDhDL1hUS0xISU84UTNzY0U4RWRFU2o1enh0RFd0elNTSUxYckpBU3pL?=
 =?utf-8?B?N212bVVuQWd4VGxBTlZVeHR6MjJ6Zi9ubUZDS0xVOWhndnFsUk9jcmFzL1pH?=
 =?utf-8?B?QjVmSVZBL1Y4UWFhUzAwSThMQThGYWtFT3Q4bC9WcWxIWFZRVlZFZkQvTWo3?=
 =?utf-8?B?aXFaZmhNWlpZc0hXMzB6Z1NXOGJSeXJEbWVFTk9mT0dMZjQ0US8wVVBOM1c5?=
 =?utf-8?B?SWZBMk1BVzB6QmV6QXA5ZW1DNHI2c1RuNXZRRythazR6RFZyamQ4YW1tR0lq?=
 =?utf-8?B?cXhtamRGL3VUYldYaFdWSmV0SkpUYlVGbUFhOUQ1K0pmQ1hWRlltekZKQVQz?=
 =?utf-8?B?azRmMGl2SnFnQmpIQzBUTlpQcy83MXhMWi9SMmFCYW03L3JmbE94SXFEK25i?=
 =?utf-8?B?ZTFTMXF4dzVGODZqQVRjaER2YndyUkJmYXdrRkZWbVZ4Mng2eGEyVHQyQWZh?=
 =?utf-8?B?cllqTWZxRnhORzhTLzBpSWtjam0yMnB5YW43emJHRi9WekUzVFl5WlVDRWU4?=
 =?utf-8?B?ZUdqL0NiYy93TVhKamFKMGZRWG9BdDJlZEVGTXI0Qk5WNzl3MCt0YWxhczVj?=
 =?utf-8?B?eXp3Q1RoWW9hTnZlVlY4RDE5Ui9lRThZTzdnOUJlTHlYQjNHdXNUSGtNS1di?=
 =?utf-8?B?eDZxcitHczZOeG9YNGJLNkV6N2h0N0F0RFE3OGFxTzhPakdQcms2L3YwNVR3?=
 =?utf-8?B?T0FDSlN2RlNWUmQ0YVBodkttSjg0OXJHa0NBMy9jclNTM2o2MXVCRmdhb25B?=
 =?utf-8?B?b3dtbVk3d2paeE04QzhPZUR1OStXcGxCVUF4YlRtZVJXTllkMUNSNE5ZUFdI?=
 =?utf-8?B?UlBBTmplRm9ZWUNMNGNJUjRUSXd6RlRQOFVSRGRZbW01dE5oTTlGUDNlM1kw?=
 =?utf-8?B?S29uYnNGbElqeDdVdjNqMkVOSEZFenhsaUFqZEN1akE5YVY3SHJ4RXVHcjlB?=
 =?utf-8?B?bFA5OGNkQmZUYVBNR0xwN2luWW9EaXJQeEcrU1FReFdkV2tUSFVVS2RQZUNv?=
 =?utf-8?B?VDZkUEVTVEk4ZmJXaXpZeVBHa2poUU16eGY0cDlQaGNYbVR5Q3FoalM4TXZU?=
 =?utf-8?B?KzM3ZEZNZDFOZzNZMXRVcVBOd2VqenZQN0JTNDFzNTc4RkxTdjZuTWV3MmNt?=
 =?utf-8?B?clc0OUk1dFp1QVRaa1B3cURzdWNNNHdoRUJvRFpVWXRmNjRwR1N6dU5DY0Nr?=
 =?utf-8?B?SEwrN1dpUHFDdDdOZDcrZE85TkdRRmdZUXUybWFiRktkb3ZxRDdxSjRyaTdx?=
 =?utf-8?B?NjF0Unp2RjBaeDB0eTE3eWZxS3JpU1NWVzR6VTduajNRa3phWHlnNVpKQWto?=
 =?utf-8?B?YzFUQU4zYnFBZ3ZHTCtpcE1qRzdWTWhnd2I1d2VJU3BLcW5PRzZqdmF5cVAv?=
 =?utf-8?B?NE1GTE16bytNZTk1TEpIeGljdmNpMXRBcEpOaGMrQnpMejlPaTE4SzZSZE9J?=
 =?utf-8?B?TkppWWhIOVNaVUpPalc0N2JyV01VNUVvWkdJTGxhNURpTU1OYXl5RU9SSTdM?=
 =?utf-8?B?K3Y2Tms0aktOb0tLcEtWNEpuTUs5Mk55dDYvcHFobkRoQ1lDcVRrSncrVE1I?=
 =?utf-8?B?cVNmNWVIcUgyWEl6b0VpbjFrUlY2K1NmdUlCSFlPdDB4c3VmRHk3MG1EajBo?=
 =?utf-8?B?QnpEY0RnVkxOd1hSaU1wcDhpeFJSTUIxNm9KMjFsemk5MzR4MFZOak81ZHBz?=
 =?utf-8?B?ZHNzSGpGa2c3TjJCYnhHd2cyWnNPZ1BBY2tsVkdVUGtIcTBMOXp4Zy95ZjZ0?=
 =?utf-8?Q?RUkYTqLr1UYjDYkUSmeIQo1Os?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2edcb0fc-53c8-4a6e-5d01-08daad1dd939
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 13:21:33.9074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7PfSD+4KE+o2F/6WRlKdNnH0y3ObP6oNF1XHWuN/k/Sp6ZCcbE/INc8eAtrxvTAtLSp+Z/ReO+Jy2Q/Th5+qng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5988

On Wed, Oct 12, 2022 at 10:26:19AM +0200, Jan Beulich wrote:
> On 11.10.2022 18:02, Roger Pau Monne wrote:
> > @@ -140,6 +135,7 @@ __UNLIKELY_END(nsvm_hap)
> >           */
> >          stgi
> >  GLOBAL(svm_stgi_label)
> > +
> >          mov  %rsp,%rdi
> >          call svm_vmexit_handler
> >          jmp  .Lsvm_do_resume
> 
> Seemingly stray change?

Urg, this was a squash of initially two separate patches and I didn't
pay enough attention at the end result not introducing such spurious
changes, sorry.

> > --- a/xen/arch/x86/hvm/svm/svm.c
> > +++ b/xen/arch/x86/hvm/svm/svm.c
> > @@ -973,6 +973,14 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v)
> >  
> >      /* Resume use of ISTs now that the host TR is reinstated. */
> >      enable_each_ist(idt_tables[cpu]);
> > +
> > +    /*
> > +     * Clear previous guest selection of SSBD if set.  Note that SPEC_CTRL.SSBD
> > +     * is already cleared by svm_vmexit_spec_ctrl.
> > +     */
> > +    if ( v->domain->arch.cpuid->extd.virt_ssbd &&
> 
> With this false, can ...
> 
> > +         (v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD) )
> 
> ... this bit ever be set? IOW if the former condition actually needed here?

Hm, right, I guess it's not helpful to gate accessing the field to the
CPUID bit, as it should never be set otherwise.

> > +        amd_set_ssbd(false);
> >  }
> >  
> >  static void cf_check svm_ctxt_switch_to(struct vcpu *v)
> > @@ -1000,6 +1008,11 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v)
> >  
> >      if ( cpu_has_msr_tsc_aux )
> >          wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
> > +
> > +    /* Load SSBD if set by the guest. */
> > +    if ( v->domain->arch.cpuid->extd.virt_ssbd &&
> > +         (v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD) )
> > +        amd_set_ssbd(true);
> >  }
> 
> Same here then.
> 
> > @@ -2518,6 +2531,10 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
> >          vmcb->spec_ctrl = val;
> >          break;
> >  
> > +    case MSR_VIRT_SPEC_CTRL:
> > +        amd_set_ssbd(v->arch.msrs->virt_spec_ctrl.raw);
> 
> Would seem cheaper to pass "val & SPEC_CTRL_SSBD" here.

Yes, a couple less dereferences.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:26:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:26:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422187.668032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiyDo-0007u1-1y; Thu, 13 Oct 2022 13:26:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422187.668032; Thu, 13 Oct 2022 13:26:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiyDn-0007tu-VZ; Thu, 13 Oct 2022 13:25:59 +0000
Received: by outflank-mailman (input) for mailman id 422187;
 Thu, 13 Oct 2022 13:25:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiyDm-0007tk-I9; Thu, 13 Oct 2022 13:25:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiyDm-00083b-FL; Thu, 13 Oct 2022 13:25:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oiyDm-0003Jp-3O; Thu, 13 Oct 2022 13:25:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oiyDm-0005ar-2x; Thu, 13 Oct 2022 13:25:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=I7cP56J+mAyDsNn6Le+Mwb/gtP1aD1yXbcZS5OBx4ZE=; b=QLIgMV51NL2NfWW4CXTV/Tu04D
	uySu9Hs8j2aa1wlk6f0q3L2EED3HenxNcHvDWxlgLLLItQY+IWORb2k8hTOW8fKVcGClfh3mPUogf
	bf4fANxHfN7hKmMNxZahGFWrYKM/Fnlh6YdX3Sc0bMqmWg7kYwPqVCvqoxs1jHjPXFV8=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-arm64-arm64-libvirt-raw
Message-Id: <E1oiyDm-0005ar-2x@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 13:25:58 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-arm64-arm64-libvirt-raw
testid debian-di-install

Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173704/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-arm64-arm64-libvirt-raw.debian-di-install.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-arm64-arm64-libvirt-raw.debian-di-install --summary-out=tmp/173704.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-arm64-arm64-libvirt-raw debian-di-install
Searching for failure / basis pass:
 173603 fail [host=laxton1] / 172623 ok.
Failure / basis pass flights: 173603 / 172623
Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\
 dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#444260d45ec2a84e8f8c192b3539a3cd5591d009-f80580f56b267c96f16f985dbf707b2f96947da4 git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad8-107951211a8d17658e1aaa0c23a8cf29f8806ad8 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#cea5ed49bb5716698a11312a3f38bc8865cd1e67-1bce7fb1f702da4f7\
 a749c6f1457ecb20bf74fca
Loaded 10001 nodes in revision graph
Searching for test results:
 172623 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173493 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173510 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173572 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173584 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fdb4de628120a8736ee47522d1941e3ad3bdf8a 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173511 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173601 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6a2b20ff97e4256970644a07f74a4c5655bf5072 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173607 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4364d661685d4806b8fb66ff76eaece7ea6a4426 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173612 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 f5959ed715e19cf2844656477dbf74c2f576c9d4
 173623 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 e8882bcfe35520e950ba60acd6e67e65f1ce90a8
 173634 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173654 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 32cb81501c8b858fe9a451650804ec3024a8b364
 173667 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173682 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173690 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173603 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173698 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173704 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
Searching for interesting versions
 Result found: flight 172623 (pass), for basis pass
 For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x55b28114ce88) HASH(0x55b28112c100) HASH(0x55b2811537c8) For basis failure, parent search stopping at 2c846fa6b\
 cc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 f5959ed715e19cf2844656477dbf74c2f576c9d4, results HASH(0x55b2811472f0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9b\
 e763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4364d661685d4806b8fb66ff76eaece7ea6a4426 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55b281143dc0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6a2b20ff97e4256970644a07f74a4c5655bf507\
 2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55b28113fd88) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fdb4de628120a8736ee47522d1941e3ad3bdf8a 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb571\
 6698a11312a3f38bc8865cd1e67, results HASH(0x55b281137078) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55b2811257c0) HASH(0x55b281100370) Result found: flig\
 ht 173493 (fail), for basis failure (at ancestor ~607)
 Repro found: flight 173510 (pass), for basis pass
 Repro found: flight 173511 (fail), for basis failure
 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 173634 (pass), for last pass
 Result found: flight 173667 (fail), for first failure
 Repro found: flight 173682 (pass), for last pass
 Repro found: flight 173690 (fail), for first failure
 Repro found: flight 173698 (pass), for last pass
 Repro found: flight 173704 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173704/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 187 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-arm64-arm64-libvirt-raw.debian-di-install.{dot,ps,png,html,svg}.
----------------------------------------
173704: tolerable FAIL

flight 173704 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173704/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 12 debian-di-install       fail baseline untested


jobs:
 build-arm64-libvirt                                          pass    
 test-arm64-arm64-libvirt-raw                                 fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:50:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:50:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422199.668052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiybg-0002vv-5n; Thu, 13 Oct 2022 13:50:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422199.668052; Thu, 13 Oct 2022 13:50:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiybg-0002vo-1k; Thu, 13 Oct 2022 13:50:40 +0000
Received: by outflank-mailman (input) for mailman id 422199;
 Thu, 13 Oct 2022 13:50:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiybe-0002vi-6H
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:50:38 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 02394f84-4afe-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 15:50:35 +0200 (CEST)
Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 09:50:28 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6928.namprd03.prod.outlook.com (2603:10b6:a03:43e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Thu, 13 Oct
 2022 13:50:26 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 13:50:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02394f84-4afe-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665669035;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=6H8TNepMDy1tEC3S7wQ7tXw6bFt8+k41RWcWVl6xt9s=;
  b=Tj1OYEme2/Y5l/jOXoABegQTz5TiJwEPAf3SjLNcww4A6WdUPL/Kqcyu
   1LXht744lOIbGJj2QknqEipUFxuze7DadFmgSgcm3/l0DxOGIka3lmt8F
   sq5yoqouyl5LNdfjR1UYUWhEq69acFOUdQmf0YFYP/ot5fzq/7905erUi
   I=;
X-IronPort-RemoteIP: 104.47.59.168
X-IronPort-MID: 81766386
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Q7JqK6JLZzSUJGNEFE+RDpQlxSXFcZb7ZxGr2PjKsXjdYENShmMOn
 TBLD2iHOK3eY2Txf9tyPYripBkHu56Ex95lGldlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4WhA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbRF9eFsBjBUz
 tJbMBwHZzmEi8jrmZvuH4GAhux7RCXqFKU2nyg6iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QPT/PRni4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWParCz31rGncSXTQbxRSqaqrOxQnlTOhVcZGCA3bQOxrqzs4qK5c5cFQ
 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0e9dWCfx81wiLxYLd+QPfDW8BJhZDddgnuckeVTEsk
 FiTkLvBHidzubeYTXac8La8rj6oPyURa2gYakcsUg8t89Tl5oYpgXrnXttlVaK4kNDxMTXx2
 CyR6jgzga0JiswG3Ln9+krI6w9AvbDMRw8xownSAGSs61ojYJb/PtL4r1/G8fxHMYCVCEGbu
 2QJkNSf6+ZICoyRkCuKQ6MGG7TBC+u5DQAwSGVHR/EJnwlBMVb4FWyMyFmS/HtUD/s=
IronPort-HdrOrdr: A9a23:IGuPYa64la+7oj+ROgPXwUOBI+orL9Y04lQ7vn2ZFiY6TiXIra
 +TdaoguSMc0AxhI03I6urwQpVoIEmsvaKdhLNxAV7MZniehILFFvAB0WKA+UyqJ8SdzJ8k6U
 4IScEXY7ecbSkYsS+Q2njdLz9U+qjgzEnev5a4854Cd3AOV4hQqyNCTiqLGEx/QwdLQbAjEo
 CH28ZBrz28PVwKc8WSHBA+LqL+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwI0l7X
 POn2XCl+ieWrCAu1PhPl3ontprcejau5p+7Qu3+4gowwDX+0mVjUJaKv6/VX4O0aOSAR0R4a
 TxSl8bTrhOAjXqDySISd+H4Xim7N7ogEWSjWNwyEGT3vDRVXY0DdFMipledQac4008vMtk2K
 YOxG6BsYFLZCmw6xgVyuK4Ii2CrHDE1UYKgKoWlThSQIEeYLheocgW+15UCo4JGGb/5Jo8GO
 djAcnA7LIOGGnqJkzxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NY2SoVC5e
 7DLqN0/Ys+OPM+fOZ4HqMMUMG3AmvCTVbFN3+TO03uEOUdN3fEu/fMkccIDSGRCe81JbcJ6e
 T8uQljxBAPkmrVeLyz4KE=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="81766386"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BPuw7TAe5Ae/WNImbz/jrvWN4OIAqMo1oygcY3uSmh9VCKKuBwtYuRtC5eN87Fk+Ki+iP0ARyOhWYK0eyqKhdUSVNb1BUoEKpDFtVocGTRiUPlZmETNJjs/u1SU1p42ES0qXsFKCgLJmuWW8L+MmX2emTx4LGSCXt3DCrD+Kx4Rfg6SHna5vPgEkByJbHC9LI7d8COVrMxzhJny+AYA/qbem6b1wyGBhIxV3aLeMKGPjLJmA7oREHdknMl3JAsdfIh+cVNj9nKqGUdMKDa8yLTou1YKSkS1vUBYlRfiNKIabhWU6PkITmYX889+2MKGWNHwW+LRKCl16RTF9BiiNoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nsxRnJe6PHh0LuWq8mWDdYzXj3FlnsjYLNKKGA6jGI8=;
 b=bJYjLEHbBTaGubukXYQ3x6c58l6KCxv6VXre9DGBJLFUrzk2ejiEV9OqIvoK/VSDTMEIQawWK/E2iltcpaea2Akq+YqXT3X2nZe4lcCO2pZFE4nz7G25VQVQK0AmKQUSGypKOKQSTNYJwW6F0S/wy9kLBc0DU3f5LIAP9WpZyiel9jGa8sAW+Al+LdxUXzhNEtgR3ws08DMa3NZfHsaisCq+aAGb9s72puy1YSOYYj7H0h0J9VTQ1KB3J0r4KMvGsQAZvAARDBwefDaiWw2g9MCLcS/L5sDUPjh2mIfo3cgF1K5FZqihBv1jUA30mkphR9ELT5TlvotpePjrHMGBcw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nsxRnJe6PHh0LuWq8mWDdYzXj3FlnsjYLNKKGA6jGI8=;
 b=lLwFhyOf1x4B5sWIde/WKeMOgNnwd+0t+kc1rrwGXz1sm72/BMwzKGnTKkHMTQWDShr3UY20YXUAum45ZYlLdFfUzbNC+ScRlJAjlzfcnfnbzubR2OCyipERvszDjOW2nRozOFTdZi4x5+dyXZISnTfrgScQ0oU+qSOtczkPPJE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 15:50:20 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Message-ID: <Y0gXnD4jsyIp2kKb@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
 <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
X-ClientProxiedBy: MR2P264CA0172.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::11)
 To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6928:EE_
X-MS-Office365-Filtering-Correlation-Id: ffb6bde9-db24-4a6a-0272-08daad21e1bd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vr4wtlmvw4H7swRTU4GACelfbK31dB0dadyzICVIiyG1Hkodcx3wmEVCn0K1t0ZaJdn37MexZKAUY50HnORa9vDzzVy6UqpG/NT7EFkiU82U91SsKo0J1D1iqVuFGtrJK7JISiwRsRm9RPdh4LE21RzB8uPBQ4e508RIvwqTbEpFidy6OpUNXVYQ3Vp/OrADZbx58r8/0jz4isrKa7FOT0BvazT+zWhpemWHfp+uRhG9lj3702jCzI2o2O9t3/wdpyrYIcb0upSA3+1ClrtdS8U4PzwF+m9qS0ywKwNfIdeLb69zHIoTp/1teiDmjuHfGZEeS4R9FPfomO2dODw8CvvFCjuPLz11IZNRHT7jxNLbQy3mecntGbeFCAqpSnYmwygX8P4ldmK705D+saehD2K5rb/7UTFalDjOsiTdiHSzCtoxKhg7EpVrlTVouSg8xgHvus0X9SQvo20toVK/MgCtyxu7nooGSxFPbVLT/Or+R3413a+zWIdzKKSZV5O9MRju0dRMROZNxV0AtzuL7rl771f2gDNIvq+UAVdJg66VMZawx4RhNYTvaGFKH9f+DBuuGTvBjpiKQ79fqubrIxvaD5QZ2kMtmtO/OYM8dqN7IQ8wlAeXBQw71/rs0KsBu2gg2Xjw9qbLAbQLx4JJ6FUWKbkaSW54CNhNxj1gx3pVum1SAHPT52EkkmzKLTbHByV/kzvPc8evW4In+MMzSg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199015)(8936002)(38100700002)(82960400001)(478600001)(86362001)(316002)(6506007)(54906003)(6916009)(6486002)(5660300002)(2906002)(8676002)(66556008)(66476007)(4326008)(66946007)(41300700001)(6666004)(186003)(83380400001)(53546011)(33716001)(85182001)(6512007)(26005)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K1drTWZDMDdRRVhEbG56em5jVS9YVU05OGd2VVFLWGlsTkp6U1FrSWF1TU0v?=
 =?utf-8?B?S0t4NGkxUCtSVWpsRVYwK3JUcjRtb2RCczJCOGZsZjVRamhqMm9WR1Erdkx6?=
 =?utf-8?B?Y0N4SGg3MGFna29CcUd0N1IyWHdnOGxyRC9COHhRV1MrME5SZkN4czdpcGRk?=
 =?utf-8?B?eEJRYjlDT2MzdnMydkIzZjVEVjlRK0lURTlpeE9NME9XRkFHSm8yckxIU3My?=
 =?utf-8?B?NnM2VGJZVmVRRmIzMHQvMFF4dzdBTnNWZ0I3QnNESXcwSTlWUkdDdnNRaVd3?=
 =?utf-8?B?WEtqVWpHU1dBN1ZWQTE5OGdKT2ZGMGwwdER3ZlEvV0hCdVllRlg0S2k3ZjZQ?=
 =?utf-8?B?MGY3MS9XZTVXejhYaUxMTFNJU2RCUWFBK2J2Q0RQN0UxMllSVEpOckJuQWwy?=
 =?utf-8?B?WUtORTBuSFdaOC9PcnFOcE5HdkhCaFUyRlhMZDF0N3ZueHVtOXFmdGVab1Vk?=
 =?utf-8?B?b3N4MW9HOTRpVVNFRitQSFpFNzZwNVhrdVpRdWxjVk5ZbnJnLzlpZ2pQNDZX?=
 =?utf-8?B?eEY2UzJJTEJhK3V4WFR1SU1wUTNpQ3ZnajdMZXFsWTJqc1FWMVo3Z0o4ZlNp?=
 =?utf-8?B?cExPdElTZ1diRE4vaXY2Zzh4UUxqSFVraGszTHM3cHJjdU9qZGtNQ2EzVkFT?=
 =?utf-8?B?Qi9xcGpmcFNncmI5OHBLSTJzNVN6RjFMOVZja1RWZjRuSEZTL2FZbnNYYWFS?=
 =?utf-8?B?MU1DdTYrQ1dOWGFLc1JDUmNmMC9CcGdBMS84MitYVkFMRVlNQTMzbHBFSDBN?=
 =?utf-8?B?cE1rQy9pSUR0bWRYUm9XQUdHazE4OWE4aWFnT1VkOGpDR3hBOWhxd3RKSUFX?=
 =?utf-8?B?Vk1RaW5BZ3JzNnBJemlZTnZaeTU4WUFkRHVZeDlyaW5PTy93dmNyL05xeU83?=
 =?utf-8?B?RUswcVRLL1JQZ3YxSTQ3dXJRSU5GMnRrN1NVOXpsTmVjVWJ1QnVValNjTmww?=
 =?utf-8?B?Qm9ISm1vYkdpakI3R0g5TnJnb1BWamJ6c0pXeTBxTTJXcWROb1ozSENXWWFR?=
 =?utf-8?B?NUVxTVBQSGIwSWJFN3JidmJEeXhRb1U4M29ESG42Z0Q2NmNDeDFPeUt6dEVn?=
 =?utf-8?B?TUExbFhWLzI5TExmWm5kOTJlVllpVFc3Rzl3UTdFb3czd1h0RGJzbVpHNWwv?=
 =?utf-8?B?Qk5VOUU3bWdFa3l5ZVZmZnBSU2trOUVxbERNMTYxNWZRQkdNd094WDE1MnY0?=
 =?utf-8?B?QnZQVDlRb0Z0Q1hML2ttSmlmSzhCaWlUQnU1V0JTcUFWbnR6S2N3RkhVTFQw?=
 =?utf-8?B?UW4wMGRja1ZEM0syeU93OTZxNzBQNkt4MzNjYUN2YzF3YVE5dzYrT2x0dWJT?=
 =?utf-8?B?Q3BaclNaVWxuRDBGUHpzT3VnUXpkcnI0cUxiY1hwakx5Qy9RMmVYZ2ZwYmJx?=
 =?utf-8?B?c08vTUtZT2ZHRFBRZDQ5WkZLeUpuNXlneUhXTG94ZDVOeFRGSTlpNDdpcm1u?=
 =?utf-8?B?VXp0aWl5b1BQcEFNQkJEZ1dUdGVmemoyS2ZrVnhyRi9HSDVjSlJiOFVkUDg2?=
 =?utf-8?B?N3JQbndoaTFJcFNackpKM3hWdjNHTHNLWmFhSDNtTHN3d0VKR2JaWHBLZVk4?=
 =?utf-8?B?NzJUUzlXa1IzNWJqWHhxVFdCZlJwUlZkQzVyeHRhUllrMXF5RzJ2dFBOQkVt?=
 =?utf-8?B?V01xMFNYOHIrb1VWMUpYR0FlVng5V2RCTnNaYWpsSVoxWllobHZYV3Z4YzJr?=
 =?utf-8?B?bmNKVVIzZklRWU81RHZabmF6ODZTNDZ3QnlyQ3Q4ajNKcU9hdW9sSURMWHRr?=
 =?utf-8?B?eGg3WTlwWjBOOGdiQ1ZBQ3NZdjZRZGxpSlVhb09BV0t0UkxZWDRRNExSczdN?=
 =?utf-8?B?bHl1QjlrSEMxclRodlpGU011NWlIdCtiWmFIcEV4QzhNZGpCeWhZTWNkcE1z?=
 =?utf-8?B?TW1uOW9EcDhMeTF1bEc0bXE4RldVZzhxeTcyMlFRbUpxa3VkMko2TnhuNFhu?=
 =?utf-8?B?Z2p6R1JYSVpJS2RaRGwvU1JmRWQ1aHFGeWJzRWZyQjgzdnNLczlqcDFEbS9o?=
 =?utf-8?B?cXNTb1IxR05BOHhWaEE4WDBTQWljMk9HSlk1K2xsRXBPTkh3S0ZUbjRHVStR?=
 =?utf-8?B?dmtpMGQzYmRmQWJKaHk2dUhtZUpBRnhuZldkU0NjNUgyaE5FMHY5d01STHBB?=
 =?utf-8?Q?qe/rF7MXbHNPx0xGVJOPWWmpx?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffb6bde9-db24-4a6a-0272-08daad21e1bd
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 13:50:26.3351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UW/puOxDIcpdPXGolhtXCMY1rA3VnPk4Z3uSmQ/rZ2aFSGDIFL1uKnvbAPukflX+dH9Xv63q9ww5U9OKIAuHjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6928

On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote:
> On 11.10.2022 18:02, Roger Pau Monne wrote:
> > @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
> >  By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
> >  when hardware hints recommend using it as a blanket setting.
> >  
> > -On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
> > -option can be used to force or prevent Xen using the feature itself.
> 
> Why would we want to take away this level of control? Shouldn't we turn this
> on while in Xen if so requested? Which would then either mean enabling it on
> VMEXIT if a guest has it off, or running with it turned on using the OR of
> guest and host settings.

Right, but then we need to context switch the value on vm{entry,exit}
which is problematic.  I could move the context switch code code out
of the GIF=0 region, and assume that NMIs executing with the guest
selection of SSBD are OK.

Alternatively setting ssbd= on the command line could be taken as a
value to enforce for the whole system and prevent guest attempts to
change it, not exposing VIRT_SSBD, AMD_SSBD or SSBD (haven't
looked at whether not exposing the SSBD CPUID related to
SPEC_CTRL.SSBD will have impact on other features).

I was under the impression that the command line ssbd option was added
to cope with Xen not exposing the feature to guests. Now that the
feature is exposed guests should be free to make use of it, and hence
there's no need to force a value for Xen.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 13:55:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 13:55:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422207.668063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiygQ-0003jB-SB; Thu, 13 Oct 2022 13:55:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422207.668063; Thu, 13 Oct 2022 13:55:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiygQ-0003j4-O2; Thu, 13 Oct 2022 13:55:34 +0000
Received: by outflank-mailman (input) for mailman id 422207;
 Thu, 13 Oct 2022 13:55:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bZiD=2O=oracle.com=dan.carpenter@srs-se1.protection.inumbo.net>)
 id 1oiygP-0003iy-NM
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 13:55:33 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a61d94e0-4afe-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 15:55:09 +0200 (CEST)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29DCX1DU014995;
 Thu, 13 Oct 2022 13:55:30 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k300356wk-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 13 Oct 2022 13:55:29 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5)
 with ESMTP id 29DDBvTU028528; Thu, 13 Oct 2022 13:55:29 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id
 3k2yncktc6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 13 Oct 2022 13:55:29 +0000
Received: from MWHPR1001MB2365.namprd10.prod.outlook.com
 (2603:10b6:301:2d::28) by MN2PR10MB4208.namprd10.prod.outlook.com
 (2603:10b6:208:1d7::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 13:55:27 +0000
Received: from MWHPR1001MB2365.namprd10.prod.outlook.com
 ([fe80::1b8e:540e:10f0:9aec]) by MWHPR1001MB2365.namprd10.prod.outlook.com
 ([fe80::1b8e:540e:10f0:9aec%4]) with mapi id 15.20.5676.031; Thu, 13 Oct 2022
 13:55:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a61d94e0-4afe-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : content-type : mime-version; s=corp-2022-7-12;
 bh=bpSvYUzf1hnen2JnJINY3EOINx560cm6soQcdO2nURQ=;
 b=T46myOM9Zh+V8T8F+Teloqm9y/vDrqK5k99Nv3VfaUc3op2SLKvCgGZZN/0eFkrHLxJm
 F6NYlpy3nwlqhHXop51xWmLJugnMdBEOKHu2hyjQmlupFDiKS9VlyxUgQXXgjZ7L1+Ec
 PST2Iz+n19BSvufzB0ArHo3eRudlg3RMkEuB44xvGG6qDoEftf+tV8W5cmFimYjcsvKH
 4AAAK3fZvURx/sAAkVn+5tqBcmR0p/DUG8b2WSQ4X3puQklzr+frYcMuHUy357KYCfJ1
 +1INmrK/kbo8dP7t5MU5mZFIBQo1gB01EN7g/U4cBH4Y72acRt8ATT/9920PZkNtC+Lk rQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WD+GaC/ERnk3CqUOpLMestIfzelwKrerOi1XO+o0JR4E8GJ5HXPGiOdtYzoMK7Ki6SO+m75f/y2WZHigTr5jUyqBE7rm4jRzdR7ZkIEzXEtnxH4mmExqTRdKOD//0Dn1mj/aiFk4sjL8BVxcve357bdVVyrQojktPtJ9BKRVWHERGC99QzVlH6EpTh95HJ+JKpk/gRHmNM2BFw6p+90sVX0FgjV/oi8E/k9DHN98GCYXEYrVTkhOM8qs2wo99AJ5nasvw0CLGApLCFnehLtH3yt8lVkaDIM3w2xB/Lp/JcBr/hTawW2eJP9TYbgtgVUT03g2CnwTeMWzy/XJ5VCaCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bpSvYUzf1hnen2JnJINY3EOINx560cm6soQcdO2nURQ=;
 b=EJaOIUcDkDLV4/mCsrLTpETshMom7WaHaTyb4IJfpK/8UWPdcKP4UxP7wZjfN/MDbzxqdyLrRwtNTxPc6HxqktzlVVDHUKfIu6fOMHXFsUUF13EStA5w1+zahl5K7hGJSqsXY2btm440haNoRXLQnYhGwq53L+Xxe9cENfzarKcRECu3SH7x9rTTKQ8X+0CEtg8x4sLqZjez35+hf4KUzIwkNXKH6n9Stp+fMVlTE3TKasSqYxdknJSW1ZGR6tUFZ3NhRTyr/K/j+G2g5xBnrp48RcjUMwWHsceU5y8CYk7cFc7dh0mw40usCjw2ERZO77Z1p1lyREj1JsrAcjvKww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bpSvYUzf1hnen2JnJINY3EOINx560cm6soQcdO2nURQ=;
 b=uLYFAhmjrVef1JtQ0aqCDtIMK0M5NyxjXzGEaflpoJCh04mcJaNARwDaRYwBlUcEIBHuMafau4dKqnpSh0qcBs6Go3a0x8HvALvOcYs8WoUbrs6aYLIREjjBxdVITYZLStbFY4J8ppeTiu5gG+55Lzt8ibsusMrLDCtQgwa+T4c=
Date: Thu, 13 Oct 2022 16:55:06 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: jgross@suse.com
Cc: xen-devel@lists.xenproject.org
Subject: [bug report] xen/pv: add fault recovery control to pmu msr accesses
Message-ID: <Y0gYuj9WKF/57zq4@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-ClientProxiedBy: ZR2P278CA0075.CHEP278.PROD.OUTLOOK.COM
 (2603:10a6:910:52::12) To MWHPR1001MB2365.namprd10.prod.outlook.com
 (2603:10b6:301:2d::28)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2365:EE_|MN2PR10MB4208:EE_
X-MS-Office365-Filtering-Correlation-Id: 76f29731-dc2b-4c7b-feb4-08daad2294ea
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	BSqS1+k+PWUAC6Lps0UshVLb17TzcSxynq6/yRv/lvvagivUIm71OksqvZ5cz0sScgvX+Giu0Yp/D3hXS3mSJh6zE8lC3Rzb1UMPtUDwpqEzc9ssjbeA32tjNyw2QPS3ko1qeXYFRv304HtzzghPTahTvfoBf+0KPbSh13ni/8KtOF2Mt9qFNeY7zQj/nOkv09pAz3aVY4LuCNLj5oTeNcPEAlOEADpvGyauMd1HYM8O20gRSD4TPIKHWUf5SA6AkpyxAVXmhlBgdOCrDMJDw8ucbd/VZBoSSumdZP79sAn8IDz5LGB5h0CDnJ41i70n6LKGkUQ6eGwf86XLJk++egEu6QOnjP//YUS6agBy47J/3oo1VTMl25e142RJpINE5SbLN1Ukhz2yxPQ16blLc/fA/clZfmHpA1xdLk/u5o9+0PlK0rxAQfvE7sbbtLKWhkv4G2AhSCuVY5pFMz/3S4m/YtGoana2dzt49dLJzCvAdDGWbfLWbGzS445KLp1G9NAQr02JeSRJWBhU0nJGfOplo3N/rrpZWQ2YsfHhzp6r0xV4RcuCZGdNRunHkJvZmp1mdcoDsY0XpEYAiLJBNqX0dTxRPtxjd8sLAKZcKYa4lCgo/1fX48K8KhaEDZxrwr2gj9tJKPmM6dd5G5OIstaZN2oGHTExwhhtrZowDtEcTDoXCFTZ6VrKuxUEmsmCffhAa9a3nsM47KXnbRkmAw==
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199015)(5660300002)(186003)(44832011)(6506007)(2906002)(41300700001)(9686003)(6512007)(26005)(8936002)(33716001)(38100700002)(86362001)(83380400001)(478600001)(316002)(6916009)(8676002)(4326008)(66556008)(66946007)(66476007)(6666004)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?3AkDDjx6oqAhm2R2p5dFop38CehIWgkk0oUPQMFR/CMfgZVjgu87oi4cPBSw?=
 =?us-ascii?Q?xaFnCBIS7PaxXzjBjyCcrk8WC/6MUewAVwFIvAwAbFqb78CGdkqd7M47WBc5?=
 =?us-ascii?Q?vjaw3lHwa0vyvfnSKJ+T3hOTj5jleKcTCc/zcIqlS/x0ghWVCH5jUU7KgwRW?=
 =?us-ascii?Q?kgObM4ARQCL0OZFWj2CBzjeu3nvOzZq7bRHFS5vfbGJ7JAkmjVJZVm4AePRr?=
 =?us-ascii?Q?OHtNz9R4oIN0RxLhQKVq83JiFkldSSiEN0tpW0VY3LCRVpV9m2v7I29v2zIQ?=
 =?us-ascii?Q?eskgdBadhyu5ruKwN+HKVA6p1t6DUHAIcAoCUWrytLXPR439BYqjUcZvvzjv?=
 =?us-ascii?Q?BTHxGiICeGLLTf27yIAcbrWSr+24nrh+Z9PaKn+T3inYVsda/+PWxlBSsV0y?=
 =?us-ascii?Q?KiOerA1TvAXZ3nDTJ/kBxVtGYYo7EvpQo7pzwjjX0PXNZKk4FTd+jRGgPhxV?=
 =?us-ascii?Q?b2cFQU6su8Q3SIC+dT+q9ZQLGAuGGV2AuJk9goEm4W2n5Z+cBqxF0n2OwANW?=
 =?us-ascii?Q?/KiRWP3irXyMzp/F+8cxqPBBDZgCLph7z3SHLAjlCCE+00diz1SIJVkzHG65?=
 =?us-ascii?Q?8JFzcLq6QfgrVyyGP8LRWSxtYKoQERv/sYMg8Gnrr9sdogG/tQ2LFYgToWe0?=
 =?us-ascii?Q?jaFoerjMO2XalWltLOqv6KHaWwRW100AACyJ6WhYIm1w4WzYJBIc/cIQ0uwm?=
 =?us-ascii?Q?sLI8riuCCDJThRNoLHcAbJPsxTTx8nDjpqRK0X3NEnWqTANfxFzMMy3FwFMA?=
 =?us-ascii?Q?PdKCOgSezMPfzvSVjzcD3KffkEUSwq0BZHCbQ1D8VJZrZ8VvEqEW4vGeezIh?=
 =?us-ascii?Q?gQ9tGz4Jfy96Z7LlWhpzonhF//klyM+aIna5TwcW0Scyeg6Invw3Xtnwu4Pb?=
 =?us-ascii?Q?GqEc6OgNs8iVOVAM+g/r+cuGFZnsDhnsBEic21cGb6zDvP/qH0O9mPyXw1Td?=
 =?us-ascii?Q?y8m2+Hax08QPKUCeDcQZPuw8nFd+XntbfFz7xKdB/rQhw/hqpuZLjpi1CYqo?=
 =?us-ascii?Q?Na8eH6IJu3FnzGheoMA5m+T+CzmCTv8QnwzNHukaGiiBh6WQq76V/imnIGc8?=
 =?us-ascii?Q?VJQMwv4gxU+rDVNflzkqh5Xt2GJatIjkYlFXfXgfSAu6vld6Gx1+Db4ThE5M?=
 =?us-ascii?Q?TRK1Tzf1hl8SSQbDyt1bMIkAhv0tCCVSHBizO5z7HER7aClp3R/pKtvK5TV6?=
 =?us-ascii?Q?fE2zAQhMf4cAz4h5l+CPvKe1jmmpfIcD5/ytJufriPjK45e0uATZ0L5TVVRh?=
 =?us-ascii?Q?lzGkDD5If4Z9jAVz4OFKsSrgcIs0R+iJsU+SAAgD7fIPBWS6jJBDWKanKv2E?=
 =?us-ascii?Q?8+fY0wPi29FDBSOAa2cHcw71p5GU+0JMdj9GMdIv83CWNnOt0Nr+gfIGi9D7?=
 =?us-ascii?Q?2mehAQvXjUgaLbK/lFMtxEGnq8YJz6E/596rJJ6wtdVU6uDvTsOqQU14yaBk?=
 =?us-ascii?Q?wCVyj4rZz5Hsl4XnK/brKhu/I8aXGpXig3MBfeIVYhgle7YDQtvpOnkioKqP?=
 =?us-ascii?Q?dQ/TAPFxGmG8x0mlhLfDFYAAZNy7UZxvi6su2ECJ5GgX10KAp1H8VbB9OtFH?=
 =?us-ascii?Q?g5EGJdRcItFgsoYoR0QltDYD6/hLV+qK57SM5MqUfMCWCnM4J0/qC+YwBVBa?=
 =?us-ascii?Q?8w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76f29731-dc2b-4c7b-feb4-08daad2294ea
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 13:55:26.8705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xcGw6qx4iaV7Rvv4aAu86Gpp2GmKM1Eg6CTlv5EYL6DJVQJNr8FgpAkzDsI9GaZJt03h9I8BmqzTUHLXcUgcLU4YGVPFpmgB+2QpVErt1/E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4208
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-13_08,2022-10-13_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=817
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210130083
X-Proofpoint-ORIG-GUID: LbO0C4y08GV3tNW52E2Y9A6ppRT-Mvu1
X-Proofpoint-GUID: LbO0C4y08GV3tNW52E2Y9A6ppRT-Mvu1

Hello Juergen Gross,

The patch 8714f7bcd3c2: "xen/pv: add fault recovery control to pmu
msr accesses" from Sep 26, 2022, leads to the following Smatch static
checker warning:

	arch/x86/xen/pmu.c:310 pmu_msr_chk_emulated()
	error: uninitialized symbol 'index'.

arch/x86/xen/pmu.c
    302 static bool pmu_msr_chk_emulated(unsigned int msr, uint64_t *val, bool is_read,
    303                                  bool *emul)
    304 {
    305         int type, index;
    306 
    307         if (is_amd_pmu_msr(msr))
    308                 *emul = xen_amd_pmu_emulate(msr, val, is_read);
    309         else if (is_intel_pmu_msr(msr, &type, &index))
--> 310                 *emul = xen_intel_pmu_emulate(msr, val, type, index, is_read);

Smatch is correct that we're passing "index" when it wasn't initialized
but it's not used so it's a false positive.  I think KMSan will print
the same warning as well.  It's technically undefined behavior, but also
we care more about real life GCC than the C standard...

Another thing to consider is that eventually we're going to make zeroing
the stack enabled by default and when we do that the performance hit for
setting index to zero will go away for most people.  (Zeroing the stack
makes uninitialized variable bugs defined behavior and has security
benefits).

    311         else
    312                 return false;
    313 
    314         return true;
    315 }

regards,
dan carpenter


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:07:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:07:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422213.668074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiyru-0005QX-V1; Thu, 13 Oct 2022 14:07:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422213.668074; Thu, 13 Oct 2022 14:07:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiyru-0005QQ-Pw; Thu, 13 Oct 2022 14:07:26 +0000
Received: by outflank-mailman (input) for mailman id 422213;
 Thu, 13 Oct 2022 14:07:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=H/C9=2O=citrix.com=prvs=278604417=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oiyrt-0005QK-Dc
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:07:25 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d9d4606-4b00-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 16:07:01 +0200 (CEST)
Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 10:07:04 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB5357.namprd03.prod.outlook.com (2603:10b6:208:1e0::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 14:06:58 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Thu, 13 Oct 2022
 14:06:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d9d4606-4b00-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665670042;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=7JgzM7mH3y7MvlNDCzKSymbDLRBLSICj41JVKV3zNiM=;
  b=blc21MO/9QHZ9I8UYN0B1z3QbzK/6ZVj5G2WU+nl9QXuG9MHWACdX2cp
   FmHVYmYd7AuXxlzBJRDQf5DzK+W+7h+pQm7YzwRXuhE55s3lSbR28zsib
   U5IgWN84jBRVDmtFZTntwJnIqidggNfth4XvDMGKp8wcek57jS0gQpg6/
   w=;
X-IronPort-RemoteIP: 104.47.58.103
X-IronPort-MID: 82668859
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AxdZ6Aamhti0ZMzB16356vDno5mJPLRPFfQ1M2?=
 =?us-ascii?q?KgaY13mRzABGkScWkptc8ngYBzUGyFykm/wyE+D3Ja0mr1dQsJyx8xlu9CrO?=
 =?us-ascii?q?Ud/HK08XwqWoLOrNI02NE6BQa63M8AfmJr28CW4dSCZRVBU63lCgdePy/uRw?=
 =?us-ascii?q?4lT/srhmdHUsbwFvVfPADaDYqCXPgBffYrCDdtKEVkUXj0hex0Xd8LxH1mq/?=
 =?us-ascii?q?hZPdPMcpX5Y5McrtK+KKX8AXinVOor7AgYLjevKvMUMW2qEDGndgTYAwcqGK?=
 =?us-ascii?q?rUvgNmIL8D1b0o/5cJcG9q0P0pFE4zpvuhBQzsMrTc2gmC5OLlALa4M8OpLv?=
 =?us-ascii?q?G68zUFgSGQljKRabI/d82Pz7kAfE2svRoHt/h2FZgt7vAYbcOV+fP9cbyPoL?=
 =?us-ascii?q?vPq5IXqPecN6lEgfFAA29LPPrWSVZnIjwwKjEtCWs6EwaKrspLaO4OCAvS3g?=
 =?us-ascii?q?iYDcl6SKUeW4x+aEB8ybZNIfsIzQcHJZbSFelBjeaJyIxRrT0EA5NQzOQqit?=
 =?us-ascii?q?Dc6BnrMvjW6nEp4xmIYnBVcQlOT2em5zz0O7klQiuEN2nLdD967amaF7vAPL?=
 =?us-ascii?q?dm2OM03xMZSyK1D0yBuWsYn+2oGa4PnHR8AkLCmeNB9pzjnqPRDSoPrdwFrn?=
 =?us-ascii?q?/7OxdidS0IP5IPSHa4ubtqKuvYeQVeevU3QeHCunQSwRfeKwPB81XkbffNUs?=
 =?us-ascii?q?Ut1242i3rS9dAL4jIre59fd6ro2R7oWTmuzf8amhLyYyMzCDN5aR54Y22bYg?=
 =?us-ascii?q?I3y9agYG0JyocSRvdPA6VVcZxXpE+Zfzr79XrFCRbSbRsHbWv/TROkwZ7Rpa?=
 =?us-ascii?q?mEnSoF76Oi6zCfLCZYOKuEVBPeN6KlxKBPHtaTyP80UKTVNii8nsob0QYWDB?=
 =?us-ascii?q?TMI92GzzLoMxNdmnXVyX9gJu/7FleN3+iEGo3wQ38p02I42kxz0C8UPWnKiN?=
 =?us-ascii?q?fcqpFm1SpM/0Y+5o4CxUx881EFriBQl5FwiTUu+2GBkad++ycMrM8ZVAgZjO?=
 =?us-ascii?q?OpEHkc52s0q2AjiDl6yXPC98xVUno1j9dNM9i4Yv5k4U8BEgXcJYz5nYDA2U?=
 =?us-ascii?q?Fg8x7h+7oF9ZhesEqw0/WfkMkFRtCSgW9u/iIzhO3HwlU6Pd2lXsYMpeIIHs?=
 =?us-ascii?q?ELwgk6xu+Dl9RDkCMaSVJdTfmPRZrCumg0DSKpOoPlIBNzv47xcLu16+J5P5?=
 =?us-ascii?q?85sb7DFy4bKPBFa+KERKa4hp6UWhPKH6uiMk7YVgdLVatXwfGDPb/ZhIZDp2?=
 =?us-ascii?q?OuhjlA8ALKgI/IW4E1IsIckYe2AMHqGjeCvmPFlE2fKT8d7KQxB2p6YCgw8e?=
 =?us-ascii?q?iy2KYQD8Bsd+fWXCCrd09mFug+8R0cc++yFHrVN4gGivn9XDh534B6cN8Fz8?=
 =?us-ascii?q?nFSzJj3GjreQzkCVN9WkkFBolGi5Jhj6hXoFqHrhOhm4YVuXew6xZszCtGSW?=
 =?us-ascii?q?plLAkMzXgzL/h4K9UAFK9cgJDrAG+Y+Z0RLrCcVw9h1buXxw3fUEaLuWQUeI?=
 =?us-ascii?q?mGNNZZjz4fyD9LTxiNE0VXX2/TH+Q7gqtwEVsDT1osdtGXs0XkiwuhhnDdhR?=
 =?us-ascii?q?CQtTXKpWNMNmSZt6upJhEToW7TCqRBKLWapgHs3QXm9+kuO5bbFkfPR+RKVO?=
 =?us-ascii?q?7Cp1IT+VhKKEZ4euHtD7KDlilgvBwPkDEc8ZPnFJ1kJqr2anQ1zSREefUhUm?=
 =?us-ascii?q?/lbxzLa4gFgbsL9EMj01cXP3855LP7uy23DPhxgJnPPT4E95yocUT/eLCTpF?=
 =?us-ascii?q?JMctA/oI5LylxZaH3lmYYKQQlundyj9jFoR0kO57n6V6YLwosc4+5IuMCuK8?=
 =?us-ascii?q?zsPOVfHQFdBzOCz/EjMXrTP56EpgCvh2qjsgYvpiXmMgB8DWFCrKsxb/TIX+?=
 =?us-ascii?q?hGVlOZ5hiv2Ti5Ljq5rr1zpLBjcFouHvDovdfvNjiiFQHNB2wcXjdt3HfBmu?=
 =?us-ascii?q?djbLQofT73arQ47BxNqGTRRAqRtO+3uEafQ8q8uK3X8dGtNAMmZ5Sb2CtQ8O?=
 =?us-ascii?q?B8R7GpKT2mIZ3pQKKvGikhIxj0MtfGpfp/c/aNYFQ7DvrUSPfOR1/7XRfJFH?=
 =?us-ascii?q?x8qquRJSE6QOKpNb/RYY1gsoBQMAKKm1BoohEJpYLeN10nx9xXvB5Nd5BPau?=
 =?us-ascii?q?BKVkgPHjqJadb6eILhbskhm+23lK67vhrDUWXQZzUV37qnxB7IodpSQEo0iF?=
 =?us-ascii?q?lO7vv4cJCYoZU3YLtLHR/5dzopx4IE3Gt6HCSz0VqcK54DIaikHFG1tKYQdB?=
 =?us-ascii?q?IyfvBPIGlQI43AP1AertdAhlDkvGdMAPB7CDLgbzKNPzjxbInhm+6pI0/Wa5?=
 =?us-ascii?q?cd7bqenV8kOFq2egr378C/N1bBVX68n8FkyJYt8qRA/XcmLndeEzZrW+Aaqh?=
 =?us-ascii?q?lve5XVpG7P1QFCcX46nVNKynxgS0R0xd4+OrtEf3wdLBYB+D+lELkVLg63q0?=
 =?us-ascii?q?vGF4+HnvZi+NqvAgyeT6kppJGPs2LNIhudkB6BVqpeEghFrJnAkYUkt+wxwT?=
 =?us-ascii?q?6hkWlcsGQ=3D=3D?=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82668859"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bgIVmSgVnDeKp3F1s25BW4SF/tTGtDKSJKGSLHtUY5kblCtMrNjLxQWcTQyy9Pwui9SZ8tauUD3G9YFjp+DD0V/DbvvZzdvvi/Gtwv5Q5bHa3/BZGjsJaqx83LFPoOTjk3L/GwFnaXwaNkH8ZUaP2gUdc7xKndnWQYfPhk1dhcd3mG5T4tcMGALmcXcYykR41A9hK8h2ZPF6mcBOJ92Cv+QjfMhgkdj9yHGcQgzOS9zZLEzNrE2T00QzYw3NCnQ/yA5RTwWWuNktSigxqzJcTFdacscnISuUqtqGteoby7euyWzPpt5NCEeSjAAMC77Xw+dFxjZhK8BqfrOp+58lDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xi17J4/zjM9vCnKOawrM8zHpxGTKfT8tBrMmDc9pbf4=;
 b=fAzwtTHPe5Dcmo1FA7N1ZjNYTTrKRdoh+brQF59AkIsTbdDBitGTZ1HYlibb9GUVmhGBTc7rSANwPNajJx4yxQI1lrFZsySzT3t1B0BK2iMzl3ALOcQDFiALOXdlxPZb/u2FyFiVeLqGUe9SLg4uNmV1ON7lOvgtN/i0BHku5NkXbrmNBBsP+tbUznyZSIDv1OzRLC2L3d9Bgxd0Ej9/xVgxyks1xhG7z3Af6n4ysk35pyyIgmC6AAHDD47QIiFBF8bKbQMTv1m48SGrEjRHg0S07cAnFlU/WBxAiMM/e1xc/HP7YX7d59Tv6eVwtL+/fz4Iu42D7ez5V6d+lEBhFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xi17J4/zjM9vCnKOawrM8zHpxGTKfT8tBrMmDc9pbf4=;
 b=tpJ3hvM4pqIYf2GjK5RUl1WVkLKj+9I7J95aFOKOUteUcEhECpF+n8MhrKRMier8sp/9FFmUJMg3IELnietlkjAPdqi8MQz7XAG2zZJLXx+kpz0W9GrmHk7K2PkDrWGTqtLujj3cmV4j0YijZlFdaW1JJ/o2dnfnhaQc/I8HbI8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 13 Oct 2022 16:06:52 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 4/4] amd/virt_ssbd: add to max HVM policy when SSB_NO is
 available
Message-ID: <Y0gbfCi5kp2qBxuv@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-5-roger.pau@citrix.com>
 <1f70c472-1b62-7c79-dc31-65fca8040cfa@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1f70c472-1b62-7c79-dc31-65fca8040cfa@suse.com>
X-ClientProxiedBy: MR1P264CA0212.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:56::20) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5357:EE_
X-MS-Office365-Filtering-Correlation-Id: 648a200f-99e0-47c3-37ad-08daad24307b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AVHmmqiB/bq87Xc6LDQXtvA0XmNduosJVQj6rYjYomGdtOJvWEWbRRXAsMR2FCaiBEoQSaQGQYJzAZh9FzuAWKhvnntuXZW4J4WOqCsCsKoLDMfIDy/hffq2eTBv8cvaSQLgPCQCpPFfsfqfchWdh2UYhI9Oq4Ju6Bd/1Oy5wXZ00HWjP96sar8v+vKNHkZ5dl5CNL/HtnuKJzUr26B5G5SYneK2hd9x7+JXpkwEMkZ/Wzkck58YgdL/6D5bjxFRUVbrY9pv65WSn0mNEevjRo5evg3RKdxdqBf4Zcrdl2C7JnUg8eAf2pBpiIuWS8HV9HQBBvTpewBWaFnCrLvoMiWePEEd/+hsZZEUOA9kDBTS+qopRKCaBfR14UxXTKN2XDwwKjqJbrqz3svORlmO6We+BzX00enW64OSZQtf8OguToZpfh6nOjK67QOUCG+uSxQLWnu0Tubx1zK8lJbsAP/JV6Fu7ds5u90QUCJQFykloIzuVaqrb74DSZn2Krwbi6VkifMRNj7GZqGQJXreZDBZ855FIJ3wNKZlxqRiwCzlBraBdAzFy3r36KDyKcQAgBQXgxbKoL7r8TWa0eTQjTaMJAVCbGGoefuGw2qk24HRjP01xBFR45+ljet3isylnq9ec3H8ULWHdxkWZiDutgmTY2QoftT08/pBcg+KKT4LQNVbN8KqDvgz3+06h7jA7sBE5bAgCJAgpJ1KSkjmrg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(451199015)(5660300002)(186003)(2906002)(6506007)(41300700001)(9686003)(6512007)(53546011)(26005)(8936002)(33716001)(82960400001)(38100700002)(86362001)(83380400001)(85182001)(478600001)(316002)(54906003)(6916009)(66556008)(66476007)(66946007)(8676002)(4326008)(6666004)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WkQ0Ym51d1pqS1oralAwU2NkZXJnRjloQkxwbURsbGMza0YvMjBEOUlVaGRU?=
 =?utf-8?B?SUpOTGRzMWN1eml3eUtETjVVQi9EWExvR0ZTRFppMEQzWFZKdFpwREpnZmRL?=
 =?utf-8?B?Mk5QbVJMc2EwR0QwZkJIZVpHSll2NHVad0VxajBJVzNHdFUzVHkvSGw3VFVk?=
 =?utf-8?B?U1hCM0R2OEg0dGc2bXVKVFkzMlJEUjMvaDl6SnhITVhaVlV1RHpob3k1b0sv?=
 =?utf-8?B?K1piMFlxVUZqOFMrak9lS05SMDQ5SHMreFIxVWdERHhxYXp1OHFHdmZraTdw?=
 =?utf-8?B?T1lTL2haejd3bkVqaUIyOUdtNllTK2N6OUdwYkFheDlKcmtCY2x1ZGhoL3BN?=
 =?utf-8?B?NGRiL2FKYVJGWVpXMWtJdlNtOFduQjRWY0kwY2VvdUV4KzV1RGtsRDZaUnRh?=
 =?utf-8?B?b1R1aTRjWEtBTGdjbVZ2MTREZzg3cUpNR1JqL25uM1B2NDZqdnNMblIwMWw2?=
 =?utf-8?B?OEt1eEc5YkRyT3pYQm8zQkJ0aDFUT1hPb2FHVno5UUZ6TFc5Z1U5R0hmUzRQ?=
 =?utf-8?B?VEI5dG1MdGI5ZEhKV3hucWFOZWlUbWcrS3BQcUphMkxxSFZIcmNjc1VLdlNU?=
 =?utf-8?B?OU5jR2swWVZlMGpuQWU0N3ZDbUpLUVZ1MFpGdlVHYjJ1R2RDdzlWRHhyVHIy?=
 =?utf-8?B?WTdEK1dWd1VKd0FZZURMK3pyWlhaR1FRMjB5eGY1NThEZFZ1dUpCc0VQL09U?=
 =?utf-8?B?dHFSYU1xam1sdk95cDdBZWRldHVWbncyb0I3eGptRHdmOGxUSkJnRXd5Wnla?=
 =?utf-8?B?ODRlVnFkUWlCRUsyT3QraGwzcVFtZlN0d0U5VWR4WlQ4alhuczJScUZYVFRN?=
 =?utf-8?B?a1BveWVUQlg0djJiVGZNQUhzUmpZeFREVUhvSWNtSUsvOTdSelVlbmVqVUha?=
 =?utf-8?B?M2Z5TTNnZk5QbUJkQllMSkpMc25LQXFFcjFQOUlmUy9sM3dNMkNJOExmRDFQ?=
 =?utf-8?B?UUsyYVJPbFNBd2hDWGhsWElhTWl1QnRCSTlNL1lpaWI5UDdod3UrclJFQ1pU?=
 =?utf-8?B?a2wvaHdIZ0ZvbGhya1pvSjdVdUxCZm8xbmcwR0d6WnlyNWxaSUFkK25rMFhj?=
 =?utf-8?B?bDJLV3ljSVRWaTNtUDJnRXlNNlhUd25Ba0ErclhUWS92Z3FFNzZ2YmhkTnFX?=
 =?utf-8?B?N3BpUmlRTG1EeGJyT3VYSVBUbzhXWTVFTWdTalY2M1RFMkR2TkFHZlo3Tm12?=
 =?utf-8?B?dFgzeGJxRDBUSFRaaUtRc1V2UzBJczZvU0tiSGpCSzZ2TDdCbmIzNy8reFZ6?=
 =?utf-8?B?RG1XM2NzT2ExemtKV3I4WTl4WGFvMHByNDh0K0c1QU9QZmk4enBjaVhFYlh0?=
 =?utf-8?B?MG96Q0pac01FSzF6OElUVWhIL2lhOFFEYk1lN0xqT3pBNzQwODlXUXFYaUw0?=
 =?utf-8?B?ZXo4OVh6UmpwSWw3bG5vQXlkWW5FZCsrNGpBV0FJOWpNcUZhMFFGS1QyOUJN?=
 =?utf-8?B?eU5tQndJbnhIbXJEVGtEc2lPVUFrZWFIbVh0OCtDajNlMWdyVE5SL1pDNkcr?=
 =?utf-8?B?U2kxMExCc0w5MnZMeVQ3NmZLZWExT2p6cjhINHhQakVQa0p6R0N6U3kzUXZN?=
 =?utf-8?B?Y2FPUEttZk14WXBtNFdMMmM3OHFRcXRFcCtCSER6czBVQ2ZYeWhldnhKaHpC?=
 =?utf-8?B?Yi9nVUtjcXJiTTEwRjFMMHNtNlFkNlBaQlNwUWpXWDJWei84dWgycXVVUzhN?=
 =?utf-8?B?TzV5aWovNDN1WnRseSsvSnptT3UxU25LOHVSM2l0bU9IU01NcjE2dFVWd1lr?=
 =?utf-8?B?V09JQ0d5OFJEbXJDTWZVVm9iOWJidVJXOXpHV0MrWlVDL0NvNnZITDEzWkxX?=
 =?utf-8?B?NHJiZ3pVSitKek1hMnlVSURhT0g1a0lPbExzbkhEcERaUHExcUFmakJQUUZq?=
 =?utf-8?B?U2NxZmJYTWRIdms4RjA2enYxVTVTSDBFTU1ZaUR4b0x6MjE0NDdVQ3h2akF4?=
 =?utf-8?B?Y2ZWd0hqOThUVTRjU2RTd0pSV0pKaml4OFhTdktOenVWTGZreUsxYUZ2ZDJr?=
 =?utf-8?B?ZTVOekVOais3M1NKKy9mRmt0UCtRMzVRK3ZiWXA3VG9KN0kvVDdHQXFFa09i?=
 =?utf-8?B?N0tWeGZhcG1CRUhkUEdZeGxIRWFFMVVnMElQR29WYXA4MmZweGhhTkVCT0FC?=
 =?utf-8?Q?jIWh+ExT5tNzkSFJemeyqhLDM?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 648a200f-99e0-47c3-37ad-08daad24307b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 14:06:57.5155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IAWERPFO/hMiSzJ6XmhYDkd/fBTGcpa5x6Ug1egOnqiTe9NoYSvXvOumGf4iFqfIrV76lfKlUl7Bov51rSn3Bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5357

On Wed, Oct 12, 2022 at 10:36:57AM +0200, Jan Beulich wrote:
> On 11.10.2022 18:02, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/cpu/amd.c
> > +++ b/xen/arch/x86/cpu/amd.c
> > @@ -814,7 +814,9 @@ void amd_set_ssbd(bool enable)
> >  		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
> >  	else if ( amd_legacy_ssbd )
> >  		core_set_legacy_ssbd(enable);
> > -	else
> > +	else if ( cpu_has_ssb_no ) {
> 
> Nit: While already an issue in patch 1, it is actually the combination
> of inner blanks and brace placement which made me spot the style issue
> here.

Oh, indeed, extra spaces.

> > +		/* Nothing to do. */
> 
> How is the late placement here in line with ...
> 
> > --- a/xen/arch/x86/cpuid.c
> > +++ b/xen/arch/x86/cpuid.c
> > @@ -558,11 +558,16 @@ static void __init calculate_hvm_max_policy(void)
> >          __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
> >          __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
> >      }
> > -    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) )
> > +    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ||
> > +              boot_cpu_has(X86_FEATURE_SSB_NO) )
> >          /*
> >           * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed
> >           * and implemented using the former. Expose in the max policy only as
> >           * the preference is for guests to use SPEC_CTRL.SSBD if available.
> > +         *
> > +         * Allow VIRT_SSBD in the max policy if SSB_NO is exposed for migration
> > +         * compatibility reasons.  If SSB_NO is present setting
> > +         * VIRT_SPEC_CTRL.SSBD is a no-op.
> >           */
> >          __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
> 
> ... this comment addition talking about "no-op"?

We need the empty `else if ...` body in order to avoid hitting the
ASSERT, but a guest setting VIRT_SPEC_CTRl.SSBD on a system that has
SSB_NO will not result in any setting being propagated to the
hardware.  I can make that clearer.  In any case I'm unable to test
the patch because there's no hw with the feature that I'm aware of.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:15:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:15:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422220.668084 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiyzO-0006rn-ML; Thu, 13 Oct 2022 14:15:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422220.668084; Thu, 13 Oct 2022 14:15:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiyzO-0006rg-Ja; Thu, 13 Oct 2022 14:15:10 +0000
Received: by outflank-mailman (input) for mailman id 422220;
 Thu, 13 Oct 2022 14:15:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiyzM-0006rZ-U5
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:15:09 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2056.outbound.protection.outlook.com [40.107.105.56])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 637b5030-4b01-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 16:14:45 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8222.eurprd04.prod.outlook.com (2603:10a6:102:1bd::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 14:15:05 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 14:15:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 637b5030-4b01-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B9bcXZXc8z4KSN/7zllDAg+ngV4Q5vOsMmEuXRDBwbpreRZP26OY++ZYr+dgOzODdlHgD9arDnO0GKcf6be4nCxYZBVRxwlx4zmHY5FhrOQUMApOLcciXzOuuvbbHnJDb8/VsbaMNdY9bq7SOB3afo4zYPbsLelPjkTYH1FSEzYsf8woKLvBuRkfmaqHmZ+69GYDk2dfMYHtatGFtnEL6O894y2ZFgorJLpUJQqhmoImr9+s5KzapgxsVOhbPg6i5Cv4oW1eIJOYdiXjQjPIclOVRvOqMOwVnOjiPOkTYSx61JakbpvvExOCJ47Hf1FK/XyuzqrBleTWchd7r05w4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DIRYfl0xNzvF7QruziNHX0SbfOaCQfZwI+YksurZjL4=;
 b=fUkyJyblx3jeNMDQiGg/4rnUgwTBIu/FAd5TKUc6ugukz9JdJgZXH2t6ApK6xDQJU1KGTNtD8szmA3s3vw9say5uLafsGvLOnska5qaB6pBVqzW5bdy1MgGGqmeJs/LSXbEzhmPONpD32GTo/EPbWvyU/G0ZC16ZI8SFpDIqGEBpr45tAoxZYy66Wuyy4xQ761iu37Kzs94OK/UB9sI8cly1eNn14faM8WWU+iWpk2WSqykT4TC/d066YVfbHxYUGpLnVrL0EQBbVFyCiqgly1F7fNlRJqkBDpJPhx9bCoapvOQvH44OHytTZeuqzCLwrBYLEyihZmlU2r6zgNkyow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DIRYfl0xNzvF7QruziNHX0SbfOaCQfZwI+YksurZjL4=;
 b=VdxJ5Z8zB7pAOhac+OicO+SKVU4+MuXsoBzmELmBc50rBP8jVk6eIUf91AtESzOg1c40ryyt1JjEWR6uSRQ05P8seT8bcSwWskcgpOtgZbXCTMoM9LWxklflMxKcF8zu2FTbfdydtvN2ERC+EA2nptl+DX4CH15pIw/l/lSwmEk2pAra/JzrD6ZKsqne+OkWpXUWutQSutwl9529LZo2+iMya52iVfk+QgCnwce0hba/sdtOp8SQ+DNUFqmAezi8A0Aqznq6jzpdhTD/2U0kYs77dAwYtGFSdPYWH1x7O/FZancfmHsedbxu/gl3/4kbtWQ1AjRQBLjF2QCD/KJx0w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dd2ca7b9-f7a3-208d-f757-cf47f37de1ab@suse.com>
Date: Thu, 13 Oct 2022 16:15:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
 <Y0f+gL1PfB5lzlDj@Air-de-Roger>
 <1867142e-ee46-daa7-c05c-04045460ba52@suse.com>
 <Y0gOOcbw2bebsKAJ@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0gOOcbw2bebsKAJ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0016.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8222:EE_
X-MS-Office365-Filtering-Correlation-Id: b08d9191-24de-4a4f-9dd3-08daad2553b1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	G2G3cnOKYzgVMZlYNRvrBwYE5436CvW4S2ZsWdSRw4fIyVPfClzbuYRBwI+R9/rVTWja7AlQZF6U8oM/RQAXzAn0efqTMRH8puXcUqSpIlnWi2h9LPoy+Dcd0BmDZCVbdpY0NQENLWkRGCmvWKagR/oOd74N/uXTO729j+FkCsoysHj4/3JsdDv0oWjFHqoeLsQz7VdgiN2Y9UotLwHOjIrmC/4UHPb7Hx0ops7WBjmxH6EAMPS79kpF2Dq2oI2Cf2wAB16gYR9eaujYo+pog97QuwQvI5zIVbLaCE2Nzn0eEzedD2YNwei9mqOp1RrgRCxADaOKomj/RyH2UQ9Ca3cbZWsKbba7GrnezcMiJDlJHW7ecWHvlFmAdAPLoQIqa28qXd6IY4iQfevD63rSQlj2gEQO9c/KHmofjjhL9dWzx7nE5Cm3SR1coYkHYFKgdvZ0LZvBYu4fkMYlpN46yDUV8R+s5/8xArBf/1NjY0R0sVlp+jfMGx7dCpq5+zqligzBp/Zq8iOWMPo9ycdBqCqrGveYLyPInGu+xTt83Sc0Im0x76Blee6znQMbdocSRTe0ZavWdCFGE0NZ38CBz5qc1H3beQBPhO9SZIl3m4Hblp0RXs9FuErrSKGPjR+JUz/uNdu/NDGZZDJhw86CsZXVF/Cqe5kgCmWn26zbEuPtEjS58Hv7bKTCx17nHTMoY6cXIx7H0xlFI8OTpOnlmTbVgVZWv+siiC2MRvmdL1307Awu1J7kNTE7X59dMfHCPsZ5zRepPJ+pWeydKVSLqSUcDSxi8w7zEFGxnC6+iKM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(346002)(396003)(39850400004)(451199015)(53546011)(26005)(31686004)(316002)(38100700002)(4326008)(8676002)(66556008)(66476007)(66946007)(86362001)(31696002)(36756003)(83380400001)(8936002)(6512007)(2616005)(54906003)(478600001)(6486002)(6916009)(2906002)(186003)(41300700001)(5660300002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VlAxVXhOSUZkcThLYUp6c2djM2loaEJRSVFldjlhTEtlUDRTZmg2ZEZLWmFs?=
 =?utf-8?B?Yi9pU01VcG5EN1J1Zmt2TlBZYTVoMkM1d3IxcEwwQXhnaVhOSDlydnlUYllF?=
 =?utf-8?B?UWRybkcwbkV4Y2FSb2xMclhzS2lXa1R1SjBIcmJmYmVvR0J1cGFNRzFNQm1n?=
 =?utf-8?B?VllHeFF2U2p6VnVJMGZZRy9WTkpFNDM5dWJRN2M2VzlrRGhJNXJnUlRxdDdr?=
 =?utf-8?B?blBEMmtJZmpqemRGSndhUDFSZnBCZjJwYlM2OW1EU2hoeXZmYXhvRzlkUGtl?=
 =?utf-8?B?Q1VWTnBKanFjSTFyYWdReFY4cFNSc3Fmd3VBbzEweFhqelZRYkNLK1NDUkIr?=
 =?utf-8?B?SHBnN3JTYWtQK01MMmpERGV6MjdzcnNEZVd1eVIxcWViOXNlb1NGZk5wTzV5?=
 =?utf-8?B?cFNTeTBJaU1QbTJQTlF6NDBvNDMxQkd5bm9CcVNEcEtpbE9odmZlN0lmblUx?=
 =?utf-8?B?OVlGeFpmVmROcnBZR09tcEtJd3BXOTdMVGZzNm54QjNJRmRqYW40RUFVSHJu?=
 =?utf-8?B?YmpTdFovVXUzSCtHSS9TWDZZUGNhVG96U3p3MnRqYzgxeWIxb0w5enlnWWtG?=
 =?utf-8?B?eWRpU3NsL0paVHVwb1NuZVFZRUFyZXdsemZPOWo4a0lObWJTcHhyRGNIc1Rm?=
 =?utf-8?B?R3licytvRG5yKzQ2bHNISVRROG9EeWIwNC9nWmY1VUFPcDNuN0YyZisrOCt2?=
 =?utf-8?B?aUJUdXplYUhiWjUzTlMxNlhQMjk3TWIvSmlzREtyZmN4OVdFcml0TTJQU0tX?=
 =?utf-8?B?ZkRTajBmcmdOYlVCSHhSamdlQXVHL0l3aWdkUlcyVlk0R1B2NHVUN09mTVNa?=
 =?utf-8?B?VWZjQ1pjWW14aEgySkl1UGVJb2haVHJVS0NwS3p2QmZrb2ZjSWtRbU53Q3l6?=
 =?utf-8?B?UTNMTitwSGtTV3lFaUU5NVk2d0p6bnJzQjNDRnhaZ3JxbmQ3aXBiU2tyS1N4?=
 =?utf-8?B?RVRqSGN2Mmd0N3lsUHhxa2pJOTdvZlllNkFLWE5kZlk1SnRqa0FxL0xJdGta?=
 =?utf-8?B?WjJsT2tGQkVKVmNpb3B3dm1NTmpWeVRLNHlWY2lrTFZ2L3FkcHo3amtkNHJl?=
 =?utf-8?B?ckI2WFFvbW5lY210OUpNbXJJNnJDdVZLMW5KV2JUZThsOW4wNE1JaXdyL25Z?=
 =?utf-8?B?QStmajlTdlhaRFBiS2lUM1B3Mm1hN3p5TnBvVmF4UVdYczlWMEtJUXo3M1ZR?=
 =?utf-8?B?a3RlWEkrb0xyVE5yVUpmZ1FWNG03a0NEUWd2ZTYybmhZNWJIK3Q4SUM5emVH?=
 =?utf-8?B?cDlNcUlxQU9waUhlR1BHOXlKdlg3VWM5d3FTSHpqVVNaYzl2OG1YVHRvaHFT?=
 =?utf-8?B?NUVPeHYxa2pNWjNpSmNxTTZVMzg2dC9QM3RzOTMzOXFNQmlCb08xS3hydHdR?=
 =?utf-8?B?TXhGNjVPbGhpNlhmZGlibUozd1Z6cXBnY0kra21obEhmdmJpdXNMN24xTGxJ?=
 =?utf-8?B?WnBiZk1UY3RGdW8yZElaT2dtWUpSR3FKb2U5SCtFVUxNRkgzWTVpbENJY3hG?=
 =?utf-8?B?ZmM0SjZjYUloUnVCbjVURGN6TDBOUXNGMWtEa01JLzhtbkZ3UllJdzlkcXI0?=
 =?utf-8?B?ZWx0eWt5U1FrcGlvdHhHR2Y0cmU0RjZ0MVpjbTAxS3NoRk1mQzFuemg1L052?=
 =?utf-8?B?T3RsWER4V2xyWVVyaTVVKzIvTnFGTElqZDFjcmZUc0pQa3d5WDBGRlVhNHNi?=
 =?utf-8?B?UDdkWmpTeHdmTVpvT3pLUGdlOHExZVZ3Mit3L1JtVlYxV002VlZQY0Q5T1c3?=
 =?utf-8?B?WHZNY3BuZXpvbkEyM2x5WXJPOFhxYmZDV05MbVFWK0FZNnFIQzhRdW42M2d2?=
 =?utf-8?B?VE53Z0lFT2ZaNWZpK3NnblRTODJQOXcrUXFDK0srZXZWZlhvYjFXQlMyMDlE?=
 =?utf-8?B?M3NwSERIRHk0eXJXd1RqWkRJWGJuaE4yWjg0eklDV0RsY1hDYlV0MncyaVFJ?=
 =?utf-8?B?VDZScVF3U0QvZG1FZ2pMMUNOWlEybXAwbGFHZ0NsQk5ZTjlmTHVaaXFpcU5h?=
 =?utf-8?B?QTFKdUh3OTRtejhwL0twVkVkcnBRVkpNdWRPK0VHM0o0eGRqenJiUzdCYXdJ?=
 =?utf-8?B?RFBsLythcUxHVUlJTFRmLzNIWERlMWFURGxoZlNsQjAwcXY1SGg1eXlucUxm?=
 =?utf-8?Q?/qRsuKiAZQM5kefqKmSmGiieW?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b08d9191-24de-4a4f-9dd3-08daad2553b1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 14:15:05.6984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c165wlhe/2IycoNCpb4jOycFSnY9WVBUSQJPr4cMU05vQbZmbZbHRT1qcPesnG3FVbLIIMd+pvUNRag1T3hEiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8222

On 13.10.2022 15:10, Roger Pau Monné wrote:
> On Thu, Oct 13, 2022 at 02:17:54PM +0200, Jan Beulich wrote:
>> On 13.10.2022 14:03, Roger Pau Monné wrote:
>>> On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote:
>>>> From: Peter Zijlstra <peterz@infradead.org>
>>>>
>>>> Having IBRS enabled while the SMT sibling is idle unnecessarily slows
>>>> down the running sibling. OTOH, disabling IBRS around idle takes two
>>>> MSR writes, which will increase the idle latency.
>>>>
>>>> Therefore, only disable IBRS around deeper idle states. Shallow idle
>>>> states are bounded by the tick in duration, since NOHZ is not allowed
>>>> for them by virtue of their short target residency.
>>>>
>>>> Only do this for mwait-driven idle, since that keeps interrupts disabled
>>>> across idle, which makes disabling IBRS vs IRQ-entry a non-issue.
>>>>
>>>> Note: C6 is a random threshold, most importantly C1 probably shouldn't
>>>> disable IBRS, benchmarking needed.
>>>>
>>>> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
>>>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>>> Signed-off-by: Borislav Petkov <bp@suse.de>
>>>> Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
>>>> Signed-off-by: Borislav Petkov <bp@suse.de>
>>>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf5835bcdb96
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> Thanks.
>>
>>> One unrelated comment below.
>>> [...]
>>>> @@ -932,8 +939,6 @@ static void cf_check mwait_idle(void)
>>>>  			pm_idle_save();
>>>>  		else
>>>>  		{
>>>> -			struct cpu_info *info = get_cpu_info();
>>>> -
>>>>  			spec_ctrl_enter_idle(info);
>>>>  			safe_halt();
>>>>  			spec_ctrl_exit_idle(info);
>>>
>>> Do we need to disable speculation just for the hlt if there's no
>>> C state change?
>>>
>>> It would seem to me like the MSR writes could add a lot of latency
>>> when there's no C state change.
>>
>> HLT enters (at least) C1, so is a C-state change to me as well. Plus
>> we may remain there for a while, and during that time we'd like to
>> not unduly impact the other thread.
> 
> OK, but it's not a "deeper C state" as mentioned in the commit
> message.

Correct. But it's also code not being altered by this commit.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:20:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:20:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422227.668095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiz4t-0008Rr-Dx; Thu, 13 Oct 2022 14:20:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422227.668095; Thu, 13 Oct 2022 14:20:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oiz4t-0008Rk-B9; Thu, 13 Oct 2022 14:20:51 +0000
Received: by outflank-mailman (input) for mailman id 422227;
 Thu, 13 Oct 2022 14:20:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oiz4r-0008RO-Ho
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:20:49 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2eba951d-4b02-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 16:20:26 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8222.eurprd04.prod.outlook.com (2603:10a6:102:1bd::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 14:20:47 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 14:20:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2eba951d-4b02-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m8WoEyX/Q1aSbfVa4rkAAveiprSAoTaOxAsOVCgOSKCZfpl1K4mgp4lCKXNg30SvVuXr95SqWIhD3A0wVn59swyQO9T/il9LaJ/l5y5G4gzNdIHmZ+EE452BLsVRfKbxTo9kTzAUzNTnrgtJLlMtJuuf2IkDWDETNlC3jf6jMPbjoWfPKgik+de7VnR5L4fDenoQSI8TwsQDUDp3jUyZVvK0BVkYcwKeQ87V6ngMojI2ByLvWzjg6/3EEPye59svfkA4QZYnQ4sgldm22Rk+p4Co0jBCGXI2hSlca4mjJy9lK645fpyBEyPJkOo9Z4k37zERrWtEmhqujmO/5lS1Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=veQFpq4mgKJoYEVkuIX/6zOa2CK07IW2mMT67BUJpiU=;
 b=RbIsA2t1DXagkzvwCx1VkSCpiVIRoIfHja+FFzJ7HNyqm1/ZXbhoPp4PLlgg5LK4duGx0s4qUzoWK8SXaqqfycLRRLTu4/XyjJksmyFAtl33D1RD9ergrB589hggLBJgQ+8uxISpHmRzZt841Xxiw81wrFi5YdykGJBMAm75X7o9meMqC90MHVPk/uTH/AHLA5s2dTnqsxmggtClmft45S8kxSAq1cFASXIm58WPoKlUy+tjUYYRhj89nm+1Y+jNKuoQTOwltQgm/O5tLK1urN6PyCesgwLNu60DSdLzHGt+Zi/PacJ1biqCgSmLbKoaz+hqw59ZqBQQxAUHR+vm6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=veQFpq4mgKJoYEVkuIX/6zOa2CK07IW2mMT67BUJpiU=;
 b=X+GcpkGSZZIPx9/ggb3DVp1sJEHSbLYGXZn8wMmnu/4qMVpgRPiAN+9tfTYH5XjYLmZzV85eWNHkgi8AAS4ISlrQt06NkY9ehjvSVIHgeucRV+iGHwxn7846Kr3fAoF+sRD356Ew9TXWJ4BXMs8eKnaHEtmzSDjmEvV8SYcGk2KUhg7K0ZgbK7GYFWlVSQ3TM7EsdRhTANvU8aZpBwxfCrBrA8iBHe+ystCw5oFaCIEpyDaCHBXcNMSAZ2WeGlRjjteDdMsOtkaHRkAJUOEQC9lHtftPxgXQY1nxHdsoIaZ+ozf6YymVa+YC0PQlFNqqXq59OrUSvjTOibEijcQlgw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
Date: Thu, 13 Oct 2022 16:20:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Henry.Wang@arm.com, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
 <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
 <Y0gXnD4jsyIp2kKb@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0gXnD4jsyIp2kKb@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR04CA0163.eurprd04.prod.outlook.com
 (2603:10a6:20b:530::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8222:EE_
X-MS-Office365-Filtering-Correlation-Id: 6f78aa15-2556-4ed9-0df7-08daad261f2f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mMOcRfKjxJJKk7wDwHXvShrVgxlWlSxJU409fnEipwdbXpJi5YRWIjlEYbkEcw8NwHlUXzPcjXOg1z4S0s39gxbiLnDnchFeT/cbP9wdUseM0VgL24kJDkk86ZNzRMsxwW+aJyxslzAG22kalSBE0E0GpBKQaEv6vy7ci1GggRf4HKpckvBTmd7YktPDjnX6v7gIxwDObysV9lilkoXXirWsvS+jMC7RruX4YkO17lniz1nycD4Gf5Fb5hAPqQkslS42QushJvP26O2hiGajCL42Ileq78qY/tENMXyAGh8TnxN12x4QrZPtYvVH8/wzlTagfU2oH19u2m0qYatIWNL8rAwg31sDZRFR3tiCtXytqy8eHVRtbZFXbbtOjIzK6cmMqMs5PqPG+7NL/wNVTldiiq/vyQvOMBogNPPbzibAAkVJ5ALQkmlrORd4PZZh0SaUOQpn8LYqVVPMXHUxu0kEuU17GMyxoVfj7B4LFI67XOC7JKN8apY9axmNjUdlMxV7VFJO3YXEpGnBFS1V2s+QbmknnCJZyli+iZ3tMmN0FyiTKMzKCom5JO0PJSLmsyGa+xjWzUGA9Sw1+5MBVig/GgS++NaGqhqoHXko2iAnFddWoiNnAhdiVliy8A2EqBPRqvKqhlq36HNgx+dSM2/Qcq/v0wMslH28vO5iKaOY1XOCGR6r5AUYudiivPHZUfb39tRUjiITrZiRiZzPFSOFbW7WRuX1o1W6ypTxEJ2tJ9xG1508p/WUYzEnA5W0J8lgrIAvwUuNAMcUjsKG/q0D2jAdKHRjFMLlZnkScRw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(346002)(396003)(39850400004)(451199015)(53546011)(26005)(31686004)(316002)(38100700002)(110136005)(4326008)(8676002)(66556008)(66476007)(66946007)(86362001)(31696002)(36756003)(83380400001)(8936002)(6512007)(2616005)(54906003)(478600001)(6486002)(2906002)(186003)(41300700001)(5660300002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0NHSHpBdWhNcEQxN1FibTducGF1R2JZOE53T0FJMmVaY1FvZDRrWEgrN3lH?=
 =?utf-8?B?RklMc0ZoT1ZCZlQrc3RRN09YVGV3eVpEMkNPOVY2V3pPTTdsd0xqNmpLL3RD?=
 =?utf-8?B?elFVdEhMYTNzWkF2SFJKMkJXZmpmU2V0MHZiV1pkOWhYLzVxaUhGY2lmT3hs?=
 =?utf-8?B?bmJJQUhzdzZHRFZ0b2xLWkNDUllTbEw0Q2hheW81RFBYVHZ1bFFDQ1JYWWNh?=
 =?utf-8?B?ZWRMMUxNdmllU2FiTWUxOVZnRGFRdUFlNUJHYnFLRmhSdlFRMHFCWDA3aTJs?=
 =?utf-8?B?cG1nQmdyc2g3dmZ6V0xvSEtDZnRqcHJQcmJPMk1SWnV0ZUJjbXVBSFdYcjJx?=
 =?utf-8?B?VlVjNElIQmVObC9mM1o2Z3QzNDR0SmJuWGNPRUYzeFpoV056OXg5eGNWc2RY?=
 =?utf-8?B?QW1HTWhjcXU2MXcxMVlMTzZMYVQ5T2NreEFub0Yxek1DR0ZwNWxPa2JTbWVI?=
 =?utf-8?B?NkFCaVJ4M0lFMXEwTDQ0ZVBQVWlwWFlhZXVqZGZSVHl4M05zN1dFMW1HbjVp?=
 =?utf-8?B?RWJ5RWNYNXAva3hHam9GNjRNa2dZb01HN0FDa3ZTaURNS2tvYm8zak12VVI4?=
 =?utf-8?B?V1BUZFNvRGRZVk5JUForenBPR1ZTZUgrdzVNY2FtNFBJZ05JTTZNVzM0QWdz?=
 =?utf-8?B?T050WmJsbm4yNkk2U2pkcVRJV09zRFJXdGV5UkpSZlRCTVBvbmJtODVTN3NP?=
 =?utf-8?B?LzJQQ3ppYnZPUEFjWkszZEVRWWhQMEl4UWJxR1dyOStvQWFaNjQ3VGR3V0FQ?=
 =?utf-8?B?bFhPMUx4bW5PeDNOSEl6MmJIamtMRW9RWXdjTXhoaThQT1pyYkNMYUw1dUdE?=
 =?utf-8?B?b0NmeGV0Y1IvaXp4OFF4aGNkZ0tSU3RSZmk0cnRWemdtNnFjamFUOVFtY0xR?=
 =?utf-8?B?c05NMC84R0JEdlp5Ny9NR2wvb1dVTUNwMDZacHFUOFFEejU5bm1DOWZIbWk5?=
 =?utf-8?B?MnBwKy8wWFFIT2wvV1BpcXg1TE55Nmc2RXJlRGhUR2V0eTRrYWFyZFVyNnA1?=
 =?utf-8?B?Z0VmMnkwS2JicVJqUGNZd3k0ZXNVVGpHdmpKSHg2UHlKd0xCRElPdWtmZitM?=
 =?utf-8?B?NG5adXJLd3FZZEh1YzUrMzMvVHdlcFYvRnlNRXZsQXI0eWw2VnNRQUdvT1hp?=
 =?utf-8?B?T1hFZ3o3MnBhcEhQNktFWVg0MjJYa0owNW9vMEtGNTNvTVBKQ3UvdWxMTGNI?=
 =?utf-8?B?QnNmYWxqZXJYRVZkUGlhTmN6ZlVEeDV0c21vVnJuQVZQenQ5aXE0NnQ1bUdC?=
 =?utf-8?B?d0xzQ1RlNzBOWWpZTko5TFcrQVVPRjVNQ2oxejJVOWtOdFMxWjZjcVMvR0No?=
 =?utf-8?B?b2c5NEY1aG81Vk5La0dYTUs0YVBWMW9aaGhrdk1UTEZSSkQvOFZOVXB1N0xp?=
 =?utf-8?B?VTVZaFNzakc4T2l1djlma1JYNThTOHlXL0U4VFNDeWdwcUxzeWhZYVB1dlB4?=
 =?utf-8?B?ZXZSUmZCU1huRVFEN3pDNXJYUVBwRXpLK2s4TG5VTVBPQi8wOXVrWGVXUEkz?=
 =?utf-8?B?SzVTRE5tT3BHd3NrVDA4RnYzb1FkMkcxeVBHTTk3VldsWHpDb2NYVXY3UTZt?=
 =?utf-8?B?UjAwMU5DcFZDZTJVMTJVL1d0YXYyV3FIWXhZcjIwUXp2QkxjS1JnZmNxai9Z?=
 =?utf-8?B?MHhsRjRTMXFMZkVTTzBQSDhCbTA1QUs3Y0tncmZ0c01rR2FXUVVKa1RVU2wr?=
 =?utf-8?B?Q21tbnh1eENXcmZjU29mU2FnK0c3Tzd1b3V4NFkyNk02WjhtcUlGbXZpS0x1?=
 =?utf-8?B?eHVWa0VpQ1pCUDFBMFJxM05kdVB0V2VDTHB5N3hwR0NFTUdMQjY4ME5ack5E?=
 =?utf-8?B?K0R3T1FaUUlEK0tuRzFoL0hhaWhUdVFpTnk1ZVNxTnBHREc2eStMTWlDL2VV?=
 =?utf-8?B?V3p6SnNJSHhGSk9rN0ZUSzJxTkJ1Qm50T2RaUCtsSU12ZFFSdU1mdUxVTGRB?=
 =?utf-8?B?d2RlQlFnaEc2bDlyb2p5L1Q2aVJhaUg2WWZrcGJxS3l5dXpua0FsQ2ltRTFi?=
 =?utf-8?B?bk0wcnlZczZZb0krUHZ5M0xwYWJRSnFsM3k0dm0rY1AyeWxUT2ttV0N5Y3Ur?=
 =?utf-8?B?K3g1SzlsY3dnZEl5NnNXV1VNNUs3bTA0dDQxSmxLQk9UMlJUMWlrcmRpaUFt?=
 =?utf-8?Q?HWZjFktXzeM1iJNDr0bpakbhd?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f78aa15-2556-4ed9-0df7-08daad261f2f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 14:20:47.1605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1PEvkDvJ4KiCEd7r8zJHTC5BvUqEnVwT1sP4bdgLcveviloRrRau4zPEEUzsWVXZQMQ4UcbjrAYarBbyHSTMDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8222

On 13.10.2022 15:50, Roger Pau Monné wrote:
> On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote:
>> On 11.10.2022 18:02, Roger Pau Monne wrote:
>>> @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
>>>  By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
>>>  when hardware hints recommend using it as a blanket setting.
>>>  
>>> -On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
>>> -option can be used to force or prevent Xen using the feature itself.
>>
>> Why would we want to take away this level of control? Shouldn't we turn this
>> on while in Xen if so requested? Which would then either mean enabling it on
>> VMEXIT if a guest has it off, or running with it turned on using the OR of
>> guest and host settings.
> 
> Right, but then we need to context switch the value on vm{entry,exit}
> which is problematic.  I could move the context switch code code out
> of the GIF=0 region, and assume that NMIs executing with the guest
> selection of SSBD are OK.
> 
> Alternatively setting ssbd= on the command line could be taken as a
> value to enforce for the whole system and prevent guest attempts to
> change it, not exposing VIRT_SSBD, AMD_SSBD or SSBD (haven't
> looked at whether not exposing the SSBD CPUID related to
> SPEC_CTRL.SSBD will have impact on other features).

That would be my preference (albeit I'm uncertain about the "not exposing"
part, as we don't want to misguide guests into thinking they're unsafe or
can't guarantee safety when requested by user mode code), but ...

> I was under the impression that the command line ssbd option was added
> to cope with Xen not exposing the feature to guests. Now that the
> feature is exposed guests should be free to make use of it, and hence
> there's no need to force a value for Xen.

... me not having had this understanding may have been wrong on my part.
Andrew - any chance you could clarify (original) intentions here?

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:30:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:30:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422233.668106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizEU-0001aN-Ab; Thu, 13 Oct 2022 14:30:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422233.668106; Thu, 13 Oct 2022 14:30:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizEU-0001aG-7y; Thu, 13 Oct 2022 14:30:46 +0000
Received: by outflank-mailman (input) for mailman id 422233;
 Thu, 13 Oct 2022 14:30:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzGh=2O=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oizET-0001aA-Ke
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:30:45 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2056.outbound.protection.outlook.com [40.107.223.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9dfedffc-4b03-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 16:30:43 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by MW4PR12MB6899.namprd12.prod.outlook.com (2603:10b6:303:208::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 14:30:40 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836%6]) with mapi id 15.20.5709.019; Thu, 13 Oct 2022
 14:30:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9dfedffc-4b03-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j3UsbTqQZlizYhwp3NU6kZ6J84qPMqjPw5J3M1K3u9aYkghrSpXzEeG1IORfL6cSgXuJNpvC5xJrxfZIsYidNlNXtflw/W4MvRNiYK0KeGwqc1ZH6rblZXf9530bjRYPDe3x1DkdCJvcDlonOgY/MSRW2rYlo2cep0vQr2RrGExVfkmtCnwgQjBmEA06lu6Iywo3DSR0B7CYJn5m/m6IUduBD95kDhV+KgugC9yK5dT0tH88HLvObx41kRk7zyqLsZ0VSo027E4JWEWfIQxYMvFHwRi4RrZM/4Q1DlXkvb96tIR1kJ55sTdMYfb5eURPEni9PT+QPXuuAjb9pQ1bqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fs1zAxQw8tKNOBH5t0SuT4gu1Cpm9Fc5tTfY/cvB80o=;
 b=n9k4Mp8uQEZI+AyKQhza7pBu5sQvjAjN/XjOfyorkPp9lid5KnX6IDXl58qb+c6dHcn1Fa9xbPU6nYBdPfVgAM1MiJ38vGJXg7QprQDxMJRbCRbr+raOU4Pqvfynk09wjE3DpgfmZDWWXqYpNuZGDpw93om+oySUwuT1vJ6854of4l4nFSMc8w/Vl/g/bVFHbaZHHUrABq9DvZbRvr3csBcoyi/VIZBBL/PxqHbhEscEcpAZqdxg+uLj58w2rGZ/GR4D/yHNiN0Els3paBKUZgg3bPNiHN5/B8j700i7H4zySeigSCUosePEZ9KhtgqN8c7TvCimZyFhwkl/KG0+xg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fs1zAxQw8tKNOBH5t0SuT4gu1Cpm9Fc5tTfY/cvB80o=;
 b=Ip5b/sFgXXbVuGG9Qh54fDQwc8MhmEpzVfwXcqO9qX67zv2ikM0jNaODDj3KT1ij6NPH2jpSLzNsFE3hrQN97bg535i8GVFEGG9yqforyOWC+Jm3burHFrVPwNPJQqT5hUaw0tG/ucJBCYUoMbdFnYgDQOmXyQfKVHqoJ1Z4lYc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
Date: Thu, 13 Oct 2022 15:30:31 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
To: Julien Grall <julien@xen.org>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO2P265CA0259.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8a::31) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MW4PR12MB6899:EE_
X-MS-Office365-Filtering-Correlation-Id: e2fd8bd4-3f3d-497a-753e-08daad277fcd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XviIFpF3DTYrwfph2rOqUoZ/VvFoIoi0mSg77j0kb9O5uWas/sKk4ekV1/BboMgRShBgWyJcr/shwwjiLToqoQ76rLv29dAGS4lPRsWMmXuaqz2ev9RPeAsH5Y6riIV0bjHhgdteEvp190bBNdPcq1wuPPw0664Ry2Se+Ta5I6GoP0JB+8xNIihiJf9RJsj7cWAr8Z4FqBeKHN8hYK0u+rgSWKGclLm8DGs8+YcEj95A3HMvOFZYCVswCQvQEVBKOqIGwq1OBjOsiuT88+b/U/asRMNJmwyrUbDtoFzQfz2xErVVc5IsWG3QuLKCDCz+9J5YJaHoo1gBkzYionFafXHxiabKMKHi/e5kDWNGXBO5IK/MLZIGV2+hOgKo+/tuy+0IvP2JEasbQylqKRbmhPqiNDgfPkqw17c7wJnbp59k9+JaoIeIVs1VVNnkx/A8MEGhJvDAla7d8T8aA9PjBXsmJJMCarkqMMbrwokxpnOERIVd4G1V0TSl4varAk+XhqxPqXJcnH+UgTky2joYcZAC9uaD8rf6YobsUMIrPALopswJL1rOykOLadneMXhlSkmMPbGYBSt+UQv4+QhJ1+gfG67ul1XbOWu/MqDUQVvui9tSlR1wIDMGmRDyOclyXR3R2kgQsImnYDBUKX9CMla/VqRt0c4M9WPCJJEgDU90v0yVe8BO0quIIboj890AddBJiWRf2IpMR2VjkRRthrvLg5NvYC9q+N3HxFzZBCzdpGYLdqwI/EpnESc1jg7TqfU1pYQiEX+0ErTvr2kcwYdQ23vgAnCHg9/L5w4dM0ab/2nOJZNG3CIjFcpTgzaP/iSsTu4UZ+3+lF2/uqd5JQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(31686004)(36756003)(41300700001)(5660300002)(8936002)(66476007)(6512007)(2906002)(4326008)(8676002)(31696002)(66946007)(38100700002)(478600001)(54906003)(83380400001)(66556008)(6506007)(6666004)(316002)(186003)(110136005)(2616005)(26005)(53546011)(6486002)(966005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGtwQWZzbVZwNmtDWnpUM1VJVnFIWTN2VC9MSUFRdUhIY2NvVTg5RzFROUlY?=
 =?utf-8?B?UXVkKytPanVIQXQxUUh6K2FXRzVjUGRQc1JSQmYzdVpwYmcvdUhMTDlHZXpZ?=
 =?utf-8?B?MlJpc2tLc3kweis1Ry93bTIyeEx0V0pkNDYwYWlFVHJYUGdKRzdmWkpBN0JP?=
 =?utf-8?B?eUlMWjJOSmFCZFg5MW14a2QyLzdtM3YvUE92R1paMUhzMVplMEhFb0hVT1lE?=
 =?utf-8?B?SG56WFhiTC9YajlqRmlkdUpiaFExVkFwbXJYYnJyODdya2ZORm1Za3RCN09R?=
 =?utf-8?B?Y2Z0aEpaTWR6U3pkY1JPcjk0TWhnd0pZNFVjMUZjRExHR1I4TklPc3RuZU5M?=
 =?utf-8?B?bEsvOFBuMEV1TmRQMDhaRlljaU5NNzZIWExxTnkzSHNuVDNHTkxSTk9wblBV?=
 =?utf-8?B?NzJ0dXRlY081bW5XN1ZkZU8wNlFDN1B3Mm5IdExTRUYvajhCbDFzWUc4dG5z?=
 =?utf-8?B?YkRsL1VIa2dOejUvc0ZrblkrVGdMay92bnhaWHE1bDVRTjYvN1pVQ0JsTUZK?=
 =?utf-8?B?d25KY0hQQXlBOEYybFYvR3NTTld3RDE3MitxWEtlY0dyMnE1c3lsWlZGbVcy?=
 =?utf-8?B?YXJVQ0xPVzVhaXVBQ2N3aSs4QVZPRGVMZ2lwTTJaVUJodzhEbUtSVEZGV2xw?=
 =?utf-8?B?NTdmaHNualVFOVBmT1poZHFLZWtnMkVBN3h1QnJZY1d0SGlFc09PMjUrNUEy?=
 =?utf-8?B?YjFtRDRrRE5XMzBHbEQ3eEJDdHpZTUlNZi9SQjBDMTI1L21jYTRZeHh1Ulhm?=
 =?utf-8?B?YmdmcU1wRTZteFpWU3NUcGtJdElxU2FBMWFRT3RDY1JPaXlmNW80OXV1d2lS?=
 =?utf-8?B?NlRRL2NpdUFBTk5lUlhOdFJoRUFwaVBHVHJZeGNiWnpDdG1jVktsUUpQRDd5?=
 =?utf-8?B?bmwyMnlXNi9pOGVlekg0cG81aG1uUmtwaGJwenBkelQ3OWoxYnhoaElqZHdy?=
 =?utf-8?B?SVYyclpqR2RMemhESXhYTFhSa243V0tqek5xeTZDWEZJeVVuWm9SMzJaQWR2?=
 =?utf-8?B?dURWbVFadGdsdkYrdWs0WTc0elVvTDZSbDFaN0lzdHh3eTZuRThUSm4wdmJG?=
 =?utf-8?B?YUtlVnlEMVNlaDdPbXp5OFR3eTF5QjBnYnRSZUZidmRaSWdCaXpQMkhzeWV1?=
 =?utf-8?B?bkwrMTR4NDNUZjgwLzVFMGxNRjd2eTViSXduSUxaYnVaOWRpMzZsY0d3Qnk4?=
 =?utf-8?B?WG41NFJWVEZNK0VDOHAxdkdVOWh1RlNRbVF0R01pL2RucXBWbU1JakdJTFpI?=
 =?utf-8?B?RmVITExWbFB5emprMDVEVTJpVkZHZHJudmJFMmJEN1l4U2szQkpqQXVZcXAx?=
 =?utf-8?B?M1pkRVJpRHg3VTQ4YnpCVExMWFJNK3ZuWkNnTDJCSlNYSHc3RGRpZldsQ0s0?=
 =?utf-8?B?aVYxcm1HRFB0V3NMdWxTTlVrQmZFNkZUWW9Sb2Y4d0JtaTdYbXpJRldNTXdJ?=
 =?utf-8?B?clppb2MweVFFeU8zV0JhdjRsWllDeUI5Um1hVWI4WVNjSWlTczFaV3NvOHd2?=
 =?utf-8?B?RWcwa0ZsamY4b2Z4ZHVMdHpmQ0lBM0hla2ZIc1NJYTJ4N0ZrZFdJL2dYY3dF?=
 =?utf-8?B?dVVwbzRJbmpWcGxCREt6VDBNNlZQSEk1OU81b3ZKUXFlSW0vL29yR3N0eW5r?=
 =?utf-8?B?YktTUHBXSjNWNUozMVRQKytyVVVQSmZtdXFOWVMwT3c2QXpIMno2cm56N1Ry?=
 =?utf-8?B?TmswQll4dmx6M2xTLzdKTFlneWYyUERvU3hwUEEvRjN3cUlpSWE0dWtXU0sz?=
 =?utf-8?B?aWNEMmNNYUZVdzdEbFd4N3NFZ0lLWmlGS2cyZG9XMWl3aTlkR0tYb2VGenUz?=
 =?utf-8?B?ZkVyMHZVVFVaUmlqMzZxcW9QZUs3NHY0WXVlTjR4YXlWZ3VsWUtSRmdwOHA5?=
 =?utf-8?B?L1d3OGVKNk41aVZSU1J1STI0eWZTbVREckhrekFMdi9XVjdkMHlVMTAxTDdm?=
 =?utf-8?B?em5jYnNYZERMYjVod1U3ZldDd21BYnJzUmV4dXh5enZGU1V1NndsYVZTTnhT?=
 =?utf-8?B?b0ZsSlBES1ZWRm5UNzJHMXZiVjJSQ1hqQ1k1Ymk5aUhrUmFITkp3Ty85T2RF?=
 =?utf-8?B?dm5KQWxHbE1jSXdYelFFK1UyZmRSY0FxMW50TElvZkZPVFVsVGRQbkxMbmdQ?=
 =?utf-8?Q?w+/cG2dR8UbNnN68Pc6si8jPe?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2fd8bd4-3f3d-497a-753e-08daad277fcd
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 14:30:38.8503
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l10edV9pv8LQsw2UQCtd3bwZOmosiozYUhnvpUSQrpDruOAd0U4IWW3P/eJfKIoRRkkpO+g8WpcJ+wqGsvriOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6899


On 13/10/2022 14:20, Julien Grall wrote:
> On 13/10/2022 12:47, Ayan Kumar Halder wrote:
>> Hi Arm mantainers/Folks,
>
> Hello,

Hi Julien,

Appreciate your help as always. :)

>
>> Please refer to the discussion 
>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>
>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed 
>> virtual platform.
>>
>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using 
>> ldrd instruction.
>>
>> As GICR is emulated by Xen, so this instruction gets trapped with HSR 
>> = 0x9200000c.
>>
>> As ISV is 0, so Xen cannot emulate this instruction.
>>
>> The proposed solution is to use two sys_read32() on GICR_TYPER to 
>> return the lower and upper 32 bits.
>>
>> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
>>
>> Now, for Xen to emulate this read, I have proposed the modifications 
>> (in my last comment).
>
> I am confused. Looking at the emulation of GICR_TYPER in Xen 
> (arch/arm/vgic-v3.c), the code should already be able to handle 32-bit 
> access.

When I compile Xen for arm32, vreg_reg64_extract() definitions do not exist.

The reason being 
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/include/asm/vreg.h;h=f26a70d024e2d1f933ea66793ea6e42f81c7a8cf;hb=9029bc265cdf2bd63376dde9fdd91db4ce9c0586#l189 
, BITS_PER_LONG is 32 (Refer xen/arch/arm/include/asm/config.h).

.Thus, the guest need to invoke sys_read32() twice (GICR_TYPER and 
GICR_TYPER+4).


>
> I doesn't look like we need to modify Xen. What did I miss?
>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:43:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:43:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422241.668123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizQe-0003Et-FQ; Thu, 13 Oct 2022 14:43:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422241.668123; Thu, 13 Oct 2022 14:43:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizQe-0003Em-Cg; Thu, 13 Oct 2022 14:43:20 +0000
Received: by outflank-mailman (input) for mailman id 422241;
 Thu, 13 Oct 2022 14:43:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a0LZ=2O=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oizQd-0003Eg-NX
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:43:19 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2045.outbound.protection.outlook.com [40.107.249.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60041091-4b05-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 16:43:18 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7277.eurprd04.prod.outlook.com (2603:10a6:800:1b3::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 14:43:16 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 14:43:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60041091-4b05-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B++1GW0yvL1nbw0v4lJcmRBdpjDdeLAzgRe+w3kN0r+S4qieg+SFybG/htdi8qHi3kAFQ3JTuquJKuNCo8qBvWGS7dQizBQBteiK12DJWSaDg169KfFLqS6Mc+JVoTCpn0F0oArKMo8qKkBZOpa48UtaJzoxiJaZc0ZInxo7bo+/bteoV8Bcj3YTNVamGJgx7Yzx+4ElIsA0fYsItCCNockp1SrLPJiT4IEQiJ+AX/9bS7k2A070t8XFqM5MOGbDgaPQNOSx8kK5cSnD0mSpoxnVlwEC+4F0D797FVN3NX2fkBIq9HybWwOgM7WGzOqHQ8W6iPp2k67xobIJmxcOKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Hq+G0iSYkV+qrVAVCsOyKXcfo+N7nJBx4VPKuCQI7D4=;
 b=lNpPcqxbGvNEmSzc+1p5QM0wAjXM9VejGbzpVgugpEDoqtgAQkcXbYax8lU7WpHlp6NkwKJI546ZWk/BKw4rsMq5Y1YqSdB3lOehN5E5t/+j/p3pRkJLLO5g+5bYbQQ+MeeMmEI1WCaeN6hST9YrI/9R66IZUXyaSJUnpc11n1PHsuNSSaL9d9rtMkh0gDg4LpiEBu0xNJGA6YIUv3B+LD6P8s6rZsiUp0b9i2kbywxOJvXB7bdYvcmdwB2L0f4bRmPFDukhB1MWDaJCa1Mh+a3cJ6UfUUdNNOjpJ0Fs/9Mg5vobUhf0+f+OM5pNWmpr2wjxwqn4N1Innp/QJeTjrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Hq+G0iSYkV+qrVAVCsOyKXcfo+N7nJBx4VPKuCQI7D4=;
 b=wz97EVmZardeukdOnenVCIT2ug2WD3VkKGMKSb1XodGTuUUsq2PtXLBkxzN5moeAn8I1/TIKBmcmqa2nmjWgLxPcQaoWtTza9pj0TZNxTGIJq4dB7aU8LqqTCbS4BDuYAVU4VUWyL9OREjS46+oXI3wsGOLzoJOKIAB9Me0nbfytaMJKDeJWjFxj7XRaLX6UIrf3fh6WOaIZvmg4qwWY7vD6G+1BT158yGs60C1lEUQvzVmnhliXe/4FjLq+8YSpOvytK1pZP8dSG3Nk+4I4/VNFKgiUcL1f7ASZmMP9weJDJQ/mdZJO6XX7cXKamKN1sTIpDTPPQfzG7BVQQ+Ihpg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bcb70302-cc88-0867-9920-2567dad96dce@suse.com>
Date: Thu, 13 Oct 2022 16:43:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH 4/4] amd/virt_ssbd: add to max HVM policy when SSB_NO is
 available
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-5-roger.pau@citrix.com>
 <1f70c472-1b62-7c79-dc31-65fca8040cfa@suse.com>
 <Y0gbfCi5kp2qBxuv@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0gbfCi5kp2qBxuv@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0177.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7277:EE_
X-MS-Office365-Filtering-Correlation-Id: 8c81409c-de46-4868-3347-08daad29437d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	r6oRAuCCJCpXAegcib5vNPmQIih1xl9GkkqbFun6FDyVKpVXYD0QgyS1PzKv8gsKdM2xFsyx0ys/Az/WQ5YcCnGNhhNChKpXo0wOicNO0KBtBKmy05YSPc4+7YQYJBBNg6AopXSu3dFY3BL4jJzbAFdcVxLpqtVFEVG2E22QZKZaT//Gfw1ktmsribuZWEUX5QCfCHkb47PhX0pAZFRoB56aIVBKv8fchrC9r2Vo8VjPU9UD5hCFXSSk7XAnwYKPfjaIQ6O/4YG6FdHnUrqy5ns8YLhxTIW8ePmDenXiFhzmpastQSkW2zjXGqafrvLocAN+o/YHo+DzVftnNdbfd9MYUNUVD8C7YRhNKofvSwRHA/c4Tvt5coZpZTrPnCZcRYXh+GYIlL8RDSIc3j9l7EZ/rsp3MZOnAok2+gr3GxiRy2k/ALHiFkamARRJ27OKmaUoChIv68Ln5yvz5Yg5vhx1FDn+Nv3XGU3LQgb/9jUd8nhBzYtKz3ZjBILJNRlugCfoLur+2pyJHFMHJUFrDo5jwKKVlntFacy7oWQT1iMUxpeotQv8E41ccveWYfzQw/V1KPDynQP48QwV0tr5RCwUcKb2PyVwCRd4uapf9fQ+skXc3CuvqZlnwW8mDU9pVbF7pSRvbschbHloCtWUa0Jn7WjSXtNi/RycKnrqyTwld40AAMvBV8JE49W3cZ2pxIF/sLH/8N/ZNGuKJUACX30vzCvmpeih3IfxAwNFZlKKevAjACTcuG6fRMi3bnvc5Bp9plre2sb0nI4FkV6wUfQL2DI/BIGNVA7J25Qs2Ok=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(346002)(396003)(376002)(136003)(366004)(451199015)(38100700002)(5660300002)(31686004)(53546011)(6486002)(478600001)(4326008)(8676002)(66946007)(54906003)(316002)(6916009)(66476007)(66556008)(6506007)(26005)(41300700001)(86362001)(186003)(6512007)(2906002)(8936002)(2616005)(31696002)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UVoycnBuaGl6TXdGaW9UdFpUZm9FSm4vcHRhZEFMSGhFc2hLWWo1SDBKSXlv?=
 =?utf-8?B?Q0M1amhiaDBEamF0dXIwNS81VHJlR2drUTQ2NzRNVFJqTlh6MnhRWkwwdm4y?=
 =?utf-8?B?Q2ZqcktCc2ZDVVZTVmFsaU9uMVllcld1M3pWcWIwOFI5WTgvYWdPT3R0ek5G?=
 =?utf-8?B?VmpmQU4waW5PTjMyenM4WDdKOVB2Y3VoL1JLYXRMRUdsUHBSUk5SSkVyQ2lW?=
 =?utf-8?B?bXZIQVNWUTRZbXRzNWxwclo1VFI0VmhjU3ZuZ1p3Wlc2Szhsd0pDQnQ3L2pk?=
 =?utf-8?B?WFpGN0JEajlLa056KzR4TDBZQzV3SStzRWY2dHBoVEhyOWxhT2Y5OERJTzBW?=
 =?utf-8?B?eGhHL0xkWTZNdmE4T08zOU8xbDMxQmJDSTRmNlJWR3M1TnU2WHd3eUVjRXhC?=
 =?utf-8?B?TnUxYUNyejRoSDBaTkRIeHdlRE9Ka1NONGVIMDYzMkJmZHBLR1lrY2RLcGND?=
 =?utf-8?B?NjZSMUI3TkhjK0xZSjhyMkFvdGZZQ2Jyd2w4dzkydWFQYUFBWUR4RVRHdFZY?=
 =?utf-8?B?dzJvR2xqNkZHdmhaNDlZRVZGNW5mbzJLTVJIajZsWnd3bEVWVEJSMlNFRHkr?=
 =?utf-8?B?clY4OUREZ1pjYXB0S3Q3bW5ydGlsL0hwNmJEZ3FpbUhZcVk3L0paUDZDN21p?=
 =?utf-8?B?OGZBUUJoNWM3b3UyTUxDaDVpQnZ4VW9FMk5TMFU5eVVTK0JIY1FCV2x5b2RU?=
 =?utf-8?B?L1Z1eGJPSW1sb0hxYWtpRUZDeG1DNE0zdTE3WG94NzYweFVWa1dLL3FkV0dO?=
 =?utf-8?B?aE82eWRmSkhtWCtrWFBJdmd4UDZTcWx2SkdOVkxlbXBBbGFad3lpWFQxTGlt?=
 =?utf-8?B?akE3NDdROXlDYXZhMzFBZm5iTlMwWTg3bjEzeHFMQVJrNmhNSE5lYmRIRk1s?=
 =?utf-8?B?Mi8rZVcyOWdpdHV1d09Ud1JIcThXTDJPZ2I2NDU4ZmVTaVk2alU0S096a0xD?=
 =?utf-8?B?MkZ4cXJLcE1Zd1hsNUgzRm96WmU5aXZXNWFMTUZYM3BrdDdjSk94a1ZmV2FQ?=
 =?utf-8?B?NTBJaWdYUDRRRGxkN05sWjRyQldvamNKQ2hnTnAzNmtrbjkwS0pyK3h3Zm9B?=
 =?utf-8?B?R0YyaWFkUTdyQi84NmZab2Z2Q1owdVNqYitPN05kZWVvUWQ1Vm1EMkc3QXhI?=
 =?utf-8?B?eWhlZGZ5L3hXOGk1MWZqK1IzbXJnWk10ZzcvS1lqdjU0T2h5dVV1M2o4YUp6?=
 =?utf-8?B?TmJjNjM2NmVXM2Nhbk15NE1icCtXZ0wwWkswLy80QTFDV3lPeWU1K3JTMUI5?=
 =?utf-8?B?bllHRXozMjhVZDZaU2RmVGZnaXdSY0hCeUxWbkh1dTRLYUlRby9YeU5VSEQx?=
 =?utf-8?B?WHJvUlR5YXpLTUdWSlJsZW9KSFhLQlZITGRRR0poMlpMcVB0ZnV4NDRGNXYw?=
 =?utf-8?B?NkJodGhwbkFWa3Y0U1RGRldYOSsxV2Q3amVSTWtUVXQwUThtcjJJZ01kS3pQ?=
 =?utf-8?B?Y3Z0Zy9hRUxxK21LWHkrZFRmVGFjNWRSYmt4K0EvYmVGNlBvaysvcVAzZkJ2?=
 =?utf-8?B?Wms4RnFLNkpDZllxdVBkZzUwTlR6RGxKamR3U0dNYUdHWGVBMFhPKzlhSmFV?=
 =?utf-8?B?SVIxbVJqY2JRMlEwZm8xZFNhN3JqZ1lUTXUxei9qKytDdTZZMzlHZDFBZzRw?=
 =?utf-8?B?R2tTMjR3cEd4Rkg5b2N2UHE1SHd1QjNmbzNQbkNxS25vOXZXUVh0WXFXSU9Q?=
 =?utf-8?B?dTVSZjJjVm9VL0kwWTgvTkJ0N0FvR3NVZERLSTJGcHdlay9xZkF0bU5kZHJ6?=
 =?utf-8?B?dEEyWjBYN3NZVit2V3QvdUVRc0xTNmNoakl4ZFZjT0pRQzgxb2k3R1FXYUJU?=
 =?utf-8?B?OHhxWkpBajU1L1ZwV3VsMlRhWjJzdkdab1hGcW1LRFZuOGFFdzltbmlQUHUx?=
 =?utf-8?B?RWFsUVUxRGdod0xXWFBQNFdZQnUwL3VvQzRxcmJLMG94amZneHM1dldjNVg5?=
 =?utf-8?B?VFpZeGg0MGVIRUxzRUs0bzZPSHJlUG1vVzk1NFhGdFhzYlE5MEl2MStBcjlU?=
 =?utf-8?B?K2VDQ0FDZ3I1N0tadStpS0FQYWZrb28vUU5oakhmeU9IbnJuWUJ4TWd6cXpp?=
 =?utf-8?B?OE4yb3FlRTg5YnZvME55SkUyWHUvcWE5WElwUWxoMXNEYWtzNk9CZSsxNWI2?=
 =?utf-8?Q?m9FHXfNmxYHmwmylMlNit6D1B?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c81409c-de46-4868-3347-08daad29437d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 14:43:16.4983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q9ANqUSF3Wu1psaHHtOdKQfX1emHy+epeFtPKkcLCrpDD6Z7Nl5flOu6qPWgtt8L2Et6Zo1lMH9g2q3QuqpEfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7277

On 13.10.2022 16:06, Roger Pau Monné wrote:
> On Wed, Oct 12, 2022 at 10:36:57AM +0200, Jan Beulich wrote:
>> On 11.10.2022 18:02, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/cpu/amd.c
>>> +++ b/xen/arch/x86/cpu/amd.c
>>> @@ -814,7 +814,9 @@ void amd_set_ssbd(bool enable)
>>>  		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
>>>  	else if ( amd_legacy_ssbd )
>>>  		core_set_legacy_ssbd(enable);
>>> -	else
>>> +	else if ( cpu_has_ssb_no ) {
>>
>> Nit: While already an issue in patch 1, it is actually the combination
>> of inner blanks and brace placement which made me spot the style issue
>> here.
> 
> Oh, indeed, extra spaces.
> 
>>> +		/* Nothing to do. */
>>
>> How is the late placement here in line with ...
>>
>>> --- a/xen/arch/x86/cpuid.c
>>> +++ b/xen/arch/x86/cpuid.c
>>> @@ -558,11 +558,16 @@ static void __init calculate_hvm_max_policy(void)
>>>          __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
>>>          __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
>>>      }
>>> -    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) )
>>> +    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ||
>>> +              boot_cpu_has(X86_FEATURE_SSB_NO) )
>>>          /*
>>>           * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed
>>>           * and implemented using the former. Expose in the max policy only as
>>>           * the preference is for guests to use SPEC_CTRL.SSBD if available.
>>> +         *
>>> +         * Allow VIRT_SSBD in the max policy if SSB_NO is exposed for migration
>>> +         * compatibility reasons.  If SSB_NO is present setting
>>> +         * VIRT_SPEC_CTRL.SSBD is a no-op.
>>>           */
>>>          __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
>>
>> ... this comment addition talking about "no-op"?
> 
> We need the empty `else if ...` body in order to avoid hitting the
> ASSERT, but a guest setting VIRT_SPEC_CTRl.SSBD on a system that has
> SSB_NO will not result in any setting being propagated to the
> hardware.  I can make that clearer.

I guess my question was more towards: Shouldn't that check in
amd_set_ssbd() move ahead?

As an aside I notice you use cpu_has_ssb_no there but not here. I
might guess this is because of the adjacent existing
boot_cpu_has(), but it still strikes me as a little odd (as in:
undue open-coding).

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:47:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:47:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422247.668134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizUq-000416-32; Thu, 13 Oct 2022 14:47:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422247.668134; Thu, 13 Oct 2022 14:47:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizUp-00040y-WC; Thu, 13 Oct 2022 14:47:39 +0000
Received: by outflank-mailman (input) for mailman id 422247;
 Thu, 13 Oct 2022 14:47:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oizUp-00040s-2G
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:47:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oizUn-0001Cc-G4; Thu, 13 Oct 2022 14:47:37 +0000
Received: from [15.248.2.148] (helo=[10.24.69.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oizUn-0004HY-8g; Thu, 13 Oct 2022 14:47:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=q95swCBT6GFOa+kBpbLAK6KslQnkO34Keu6rVj3fYlc=; b=kaQ15lYWcZPKpijC85xJyRkr9K
	0ZFKaUAZhGTraZG0+HVag/ikqNh83hhZ4Ddry8ZqACjBp9NSvt564cQU/W5MUHt0PmSwfyjSalKRh
	djCCnjrqMqNcoqbmo0finOTzag3IUEFRfqljcJueDIyf3LZmbRYZEPZMOGHyy12ox/Os=;
Message-ID: <96f989d9-4d55-acc9-a0f7-cbb1212480ad@xen.org>
Date: Thu, 13 Oct 2022 15:47:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
 <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 13/10/2022 15:30, Ayan Kumar Halder wrote:
> 
> On 13/10/2022 14:20, Julien Grall wrote:
>> On 13/10/2022 12:47, Ayan Kumar Halder wrote:
>>> Hi Arm mantainers/Folks,
>>
>> Hello,
> 
> Hi Julien,
> 
> Appreciate your help as always. :)
> 
>>
>>> Please refer to the discussion 
>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>
>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed 
>>> virtual platform.
>>>
>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using 
>>> ldrd instruction.
>>>
>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR 
>>> = 0x9200000c.
>>>
>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>
>>> The proposed solution is to use two sys_read32() on GICR_TYPER to 
>>> return the lower and upper 32 bits.
>>>
>>> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
>>>
>>> Now, for Xen to emulate this read, I have proposed the modifications 
>>> (in my last comment).
>>
>> I am confused. Looking at the emulation of GICR_TYPER in Xen 
>> (arch/arm/vgic-v3.c), the code should already be able to handle 32-bit 
>> access.
> 
> When I compile Xen for arm32, vreg_reg64_extract() definitions do not 
> exist.

Ah. You are building Xen for arm32... This is unsupported by Xen at the 
moment.

> 
> The reason being 
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/include/asm/vreg.h;h=f26a70d024e2d1f933ea66793ea6e42f81c7a8cf;hb=9029bc265cdf2bd63376dde9fdd91db4ce9c0586#l189 , BITS_PER_LONG is 32 (Refer xen/arch/arm/include/asm/config.h).

Right, so that's not an architecture issue (like 'ldrd') but just Xen 
not providing the helper.

As I wrote above, Xen doesn't yet support GICv3 on arm32. I expect that 
implementing vreg_reg64_extract() will be one of the step.

> 
> .Thus, the guest need to invoke sys_read32() twice (GICR_TYPER and 
> GICR_TYPER+4).

I don't understand how you came to this conclusion with what you wrote. 
If we had implemented vreg_reg64_extract(), then Zephyr would still need 
to issue two 32-bit read because Xen doesn't emulate 'ldrd'.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 14:58:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 14:58:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422254.668146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizfL-0005Ze-2T; Thu, 13 Oct 2022 14:58:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422254.668146; Thu, 13 Oct 2022 14:58:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizfK-0005ZX-Vl; Thu, 13 Oct 2022 14:58:30 +0000
Received: by outflank-mailman (input) for mailman id 422254;
 Thu, 13 Oct 2022 14:58:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xhTA=2O=citrix.com=prvs=278783dfc=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oizfJ-0005ZR-1k
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 14:58:29 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7bef20f3-4b07-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 16:58:25 +0200 (CEST)
Received: from mail-sn1anam02lp2041.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 10:58:22 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA2PR03MB5948.namprd03.prod.outlook.com (2603:10b6:806:115::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 14:58:18 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 14:58:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7bef20f3-4b07-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665673106;
  h=from:to:subject:date:message-id:content-id:
   content-transfer-encoding:mime-version;
  bh=ahQ3Rfen9RhIqcV1rxlddnZ1tP4GYDAn6VnCDOLTQMc=;
  b=HgGgzwFxo49yDMXx8h5qJE6OnC5vF3H/VM2CDz1P5lSoRlboZ7MJXcG2
   HDwkggBs+NWGvf9KBCWYvIpu91uzqljAqZ80OD2IVLf3CbRfyfH0rBnQJ
   IgVHecbkFkqhVeZ7KfFgT+3OQfa984kJYdVcWSs3UOj0Z5BWzIPmW++wR
   Q=;
X-IronPort-RemoteIP: 104.47.57.41
X-IronPort-MID: 82650312
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:QU29aqlQRAlBRuC10lbChzbo5gycJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMCmiHM/mNYzehfI0na97k9U4FsJSGmIUyHVBupCw3RCMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfH2Vtr
 tAGEW43cxndpfPv0u3rT9Vur5F2RCXrFNt3VnBI6xj8VaxjeraaBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6PlWSd05C0WDbRUvWMSd9YgQCzo
 WXe8n6iKhobKMae2XyO9XfEaurnzXmlBdpJTefQGvhC22S62VcRUyAsehilp/zo0GmdHOhdJ
 BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0
 FChlsnsQzdotdWopWm1876VqXapP3EcK2YHPXUAVVFdv4Clp5wvhBXSSNolCLSyktD+BTD3x
 XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjvNAt9RDGJ9W7GV1A==
IronPort-HdrOrdr: A9a23:evMPhqhmPWIZnaWfJD0Lcv+9s3BQX2p13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwXpVp2RvnhNZICPoqTM6ftW7dySCVxeBZnMLfKljbdxEWmdQtsZ
 uIH5IeNDSSNykxsS+Z2njeLz9I+rDun86VbIzlvhRQpHRRGsRdBnBCe2Sm+yNNJDVuNN4cLt
 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9q1CC+yReTrJLqGRmR2RkTFxlVx605zG
 TDmwvloo2+rvCAzAPG3WO71eUYpDKh8KoMOCW/sLlUFtzesHfqWG2nYczBgNkBmpDv1L/tqq
 iIn/5vBbU215qbRBDMnfKk4Xia7N9p0Q6u9bbQuwqfnSSyLghKcfZplMZXdADU5FEnu8w52K
 VX33iBv54SFh/Ymj/hjuK4Iy2Cu3DE00bKq9Rj+kB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK
 1rANvH7PhbfFuGZzSB11MftuCETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76
 DPM7hulrtJUsgKBJgNc9spUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCe81JVsJ6e
 T8uX9jxBAPkhjVeLGzNbVwg2/waXT4WyjxwcdD4JU8sqHgRdPQQFy+dGw=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="82650312"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W9OCLpNExtOAvpo483m4eEuZ46oRO2ixO5sJKpI4TUxWdPPmkKZ14ErnsPEq4mBIFmCyrC5faBUbf1trKySkIlu55S1hMBXOi+2MDvqMklyJ5SOIFnUHh7SdfK493MPVOObbWDYfxwYxetrTgeTMHM4gNnuSsaY8S8TooRcZIUIpULSpv8cSgdD6BcbzoCR2wdbQ0Ux4igScfaoI/KAZCx3EwdGkCxJ9c5JREClWuVng7yIPPeY+JP/zEOx+SvYOWPsgr/GShn6JW8r6Rp5LVIi8x4HPxete+cVfS2nkT64wdneo/S9YCdIgxoWv43W6cWHDXBSXM7FTrtgtOvSCxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ahQ3Rfen9RhIqcV1rxlddnZ1tP4GYDAn6VnCDOLTQMc=;
 b=oNsQQq/XuWgj1s7ZnIeaqorSFQvMT40rm1Z8pprG8X0SU2j3tDfWz5FmYXkbmNcVbIWBYBusCXXr0TfKALc7qjz8guk1OepxDexYUKDiQEv/7GiFfo3EAQGstb7+mciktJnAR92q0CT7dLGrwuH0eNMagAPR5qz0nUIZAg7JQRAfFgOEDStTShC3d6JuXiGCg0wOg986pe34Gf7c+lCfxwtsa+hAsta1/3PDAk2ePcRK9pQ3repfARinbf3QpQ5tHF4q8Tx5rpJOknwxRjAdrxcsps0mUKNMH3WEPPOj7EBccgryyOvQ5h/VUeG3GQpHloQajt+RIa+oARDB8SEtmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ahQ3Rfen9RhIqcV1rxlddnZ1tP4GYDAn6VnCDOLTQMc=;
 b=FIxwQT/WuKUhpgBMFRq5cjs+YNs9BIVg4m+nsZ7Az3VAx3E3C0CwEG2MSwB0lwBCgwG8htDR8reS7BsficGLao70IYrzX9EZWTCmF8ho7Oy4P6HnSZnys9WruCXXTp2yz2TA7dk5Os1XP7sWibCz4sB9unM4Q1iNxVQIdf3XZIM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>, Anthony Perard
	<anthony.perard@citrix.com>, Henry Wang <Henry.Wang@arm.com>
Subject: [4.17 nice-to-have] Remaining Xen build output
Thread-Topic: [4.17 nice-to-have] Remaining Xen build output
Thread-Index: AQHY3xQ6C+YspYbxIkKvIHBrdOccOg==
Date: Thu, 13 Oct 2022 14:58:18 +0000
Message-ID: <c4b91289-82ea-dd97-a1f5-b168252eb826@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA2PR03MB5948:EE_
x-ms-office365-filtering-correlation-id: 74987207-a1be-4de0-ba80-08daad2b5d14
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 uUV2qxfuVK2O3Htoor4USw/TeXCp3w9v3EiTNCS7pFJ9L44NB//KAxbClsKkBGHeXw1hAhOwUVMlifGCFIgIwTgvQ69hyqjVpEPRm6FDShxYMgj6Yx9FZfxuYK6hX4nAkX6/459i9f3Qjf2JIgGEok+mGEqYHhfOgG/C+81vbItkcd//xd9qBhme3ZLdYWkDKboLNfecjB2vBqoMQcJsfYEM2gyerGnBZCNi+9q9CudMWbReZJWhxigkHqnld2fjhQQd9zoNGIXpoQDcf8c5IhxRHT4nQGFuog4VBNGtWedccnE41eDErr4Fe6W8Sppz+59NDzPotUDguUr0SrNvjLYJrC/1yc3491oic/Yr8TT7v3wT9ECfDg33fexcYr2fhqeK1ISlwOiCP9WciZLsiJemNFK4zDk+ZqPDCR7j0snns2bimCGkbyIMckYHdwu8kKwVxC8LtwbRD9n0yaYa7hUq5FGTJxxlKaJhEvRv85a+bpEeS9weaDXIsRjSHh9/Nkm7OgfRalAeYOuG+zLmNW/07Ung7YSxehtfXjM3e/2pmyiqKXYSFucgj25kEiTbelGguy35d9bOGNtFSuoaQJzarpDO/GPLiQQg7JJ/1SzXvlA5CBNPJXj0P4ZCEk7heZLx58WAc8B+JcSh+TkR4HWqrEvtpt6R5x+TlQMvLC01t5ENf65zLmBkGe7x8WOCtKVIstmkloia966hl3p/fK4mFPFrw3/lC0MVEmc7GizUxpsLYbhtW0aA6vQONUja1EYwXI5+wZSFnQlT0lWcUwOWVaRPG0vAWTmTa5S7PBNDH28PWQLnyizF+WQxDiJeV8STISSN7RgMAmpqVP2Zgw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199015)(31686004)(110136005)(66476007)(8936002)(316002)(31696002)(66446008)(76116006)(86362001)(66946007)(91956017)(8676002)(64756008)(66556008)(186003)(2616005)(36756003)(2906002)(122000001)(41300700001)(6512007)(26005)(6486002)(38100700002)(71200400001)(5660300002)(38070700005)(6506007)(478600001)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?NjFWbGlwNDM1cTVBK21vdGtPayt0Yjg3c1JRRUFlM3NPZ1VGUHgzT2VsWUtX?=
 =?utf-8?B?eU1mOEh3Smx3L0R4VjcySE9OZHNsUFVwSUpGTEk1cUV3eWZWVCtMcnNsYmla?=
 =?utf-8?B?WTdmVUkrVWVWN2FhU05STmh0QUhqRUlTVVVxL0dWbjljS1JtbTNUYzdLUnZ5?=
 =?utf-8?B?RXdBa0tQTFU5UVcvT25zbkRjb0kxa2F5ZGgzR0lLSlpYaklWS1ZzUWpLdWRx?=
 =?utf-8?B?TXhkS3JSZkpLaVREOWJ5cUdUVC9WdVo1VFVqRk55dHNwYmZvNDZSNWh1RVJO?=
 =?utf-8?B?bmxHd3BlMURGbUl6R2RGZlJWdjR5amVRVmJhYUpwcklZeHNVc3RHUGwxSHBW?=
 =?utf-8?B?ZVphR2FBeE1xRktTMk1ycmhJbDhyVVlOTTJVNTJsS3RSUGhpR1V1Q1RnSXJX?=
 =?utf-8?B?Qm11REtpRlRBNVhjaUU2NC9ETW0zMW51WTBPdExjTkJNU2xQalRBQ0pJV0oz?=
 =?utf-8?B?Q09ETk9jbFNrYk1qcXBkcU5JdldNZWd0Qy9QWGd0b3poQ3crT1RGZXBMSEtl?=
 =?utf-8?B?TXYvRGR4R2dwT0FISkU3U1J1VEFqd2NxRFhvTFl6MWVTZ1F2ZExpQUVoMG1Z?=
 =?utf-8?B?SnovWHNGVDN5a2VlNHZmOENFWG5mbzV5VHVsT3FTQW53QStncUVYMnNJSmZm?=
 =?utf-8?B?MHgxVGhFamtPa0k2ZDYwdDBWWVhsanJlYlhOb1BraVZib3QrVWNoUUdRemk1?=
 =?utf-8?B?RFRjL0N3TkhyTGozcVJPb1RvVkxCUHJYUzVML2NFdm51OGxtd0NQaXQxeUd2?=
 =?utf-8?B?ZzR0MVN1SXBXMTh0M1Q4RDdZeE5UeXh3MnJZbE80Lzl3UXAvTVIyMlNNQlIw?=
 =?utf-8?B?dUFOUURIVUQ1UHZLWVRCUmQwSHM0dzV1NHBwT0hJOXBvZ2Q4Zm9WTnZFb3Fm?=
 =?utf-8?B?U2NXY25rNHhRRE9ITjdnOGh2MzFlSTNCVGVHZU9nQzZNY2VhZlB4ajFmZjFH?=
 =?utf-8?B?aXZqbE9zUUVzL1dCTnZVQzhzcC83MEduM1I0QXVibXBvYlA3TTNkVHRhWk1C?=
 =?utf-8?B?eWdhMzlkaCtKdWw2aHljdVpIazhxQlB0VmRzaGEwNTJEMGF0SGRvYjA3Z2hm?=
 =?utf-8?B?b0pRTHhjWmtVSVFzb0ViejVkNUJZZnpKcVNnZkRJSEJHVVFJRnF0STkvOUhy?=
 =?utf-8?B?MG1rQUNCcXlTWnQvbFMveDVzZWoxNGJmWXg3b3JlT2Q3M29COU9xT2NaNWo1?=
 =?utf-8?B?ZXg2OFZrK284K1ZtZkVOeEsvT0ptYlQyMldWdi9HWjJibUU1TCtZcG5PSlZW?=
 =?utf-8?B?VnFmYVZGMGZidlZyT1ZyanUvRzVhNnUvZFprTExBY0IzNGxIOFRwRkc1ZENa?=
 =?utf-8?B?b0VhZHhiY1FYYW1VVFB1SVFzL0RLK2JGTm1HZkRBdEVzbGpnQ1JsdktQNW9O?=
 =?utf-8?B?dXczb2VGcHpjSFVtdzB4Rnc5QTFtVm9NVlF3UXdTSVNEY3pZUi8rVGtZK2Y1?=
 =?utf-8?B?WUdsbm5nLzVIRlBzSmhPbDB5Si85UTkxVGlSZ1V5UEMvYjVacXhKWC9wTmJE?=
 =?utf-8?B?M3k2QTlHdExNTWhicWZVbENsaW5PenR6NWlyaWN1ZjJ1UnVqZHlQaExicERB?=
 =?utf-8?B?MkpWSno5L1RaQmhxKzl3SzdQMWxRZ2FaeHlMVDB5L1RFK2JYbEJRT1hXOFpF?=
 =?utf-8?B?WFlTWkxOVWRMSXZ2b0szTjV2dHVUbXVMZjg5SkFJaGtVUHZodDZvYTh5cDNa?=
 =?utf-8?B?bVB2Z0lmVXBjUHVlMDk3azQvMmZHMUNqRW5Ja0Rnd1NzREo0TUgxMm5aS1lJ?=
 =?utf-8?B?QnIwV3kzdS9LNjdlYUtJTGFDQWdHTk1WQW5nSTE4dHZ2THVDK2kwWE00ZTl6?=
 =?utf-8?B?WTZiYVNFbzJuUisvL1JxbElvYzZOd0tVWlhvR3VSYzNhOG9LUXZyZ0dmWWxm?=
 =?utf-8?B?bFBvd09IYlc4K08wbjFGczhXR2kwT0pIbStyQmNiQUtRdW9rL2JZbCtSZHhB?=
 =?utf-8?B?TXhhNkVFRTh5ZWpHbXcvbnl6Y1daeVl5a1lTWjQwQjUydXVUN3ZoSUdRREhz?=
 =?utf-8?B?cUtxNTJwTFVodnFMYmFjYlFDQTgzQ1NVbU1CNFVwL3p6ZHR3VXVWK1dURnBU?=
 =?utf-8?B?WkZaNXdNTGRvYWtsN3d2ZmNNZC9qRmYwMzZNVjZTeGxpQVRZN0NON0IzWEZo?=
 =?utf-8?Q?8wQtA2VF3QOx5z46/Qkp2+yZf?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <8752E7C4E0948E44B81558842D0E27ED@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74987207-a1be-4de0-ba80-08daad2b5d14
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 14:58:18.2716
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LhRPkUEFisEG8MkJr84Nr0otWuBHgcQ7nF8AwZYN2a5Mmyg3DofHyid5wnE3H4b30ErU+L8ju7Si3ouqNtWL6nZEvRWHzC1ro92uzplxLe4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5948

SGksDQoNCkhhdmluZyBnb3QgS2J1aWxkIGFsbW9zdCBpbnRlZ3JhdGVkLCB0aGVyZSBhcmUgYSBm
ZXcgYXJ0ZWZhY3RzIHJlbWFpbmluZw0Kd2hpY2ggaXQgd291bGQgYmUgbmljZSB0byBhZGRyZXNz
IHNlZWluZyBhcyBvdXQtb2YtdHJlZSBidWlsZHMgaXMgYSBiaWcNCmZlYXR1cmUgZm9yIDQuMTcu
wqAgUGlja2luZyBhdCBwYXJ0cyBvZiBhIGJ1aWxkLCB3ZSd2ZSBnb3Q6DQoNCsKgIENIS8KgwqDC
oMKgIGluY2x1ZGUvaGVhZGVycysrLmNoaw0KL3Vzci9iaW4vbWFrZSAtQyBpbmNsdWRlL3hlbi9s
aWIveDg2IC1mDQovYnVpbGRkaXIvYnVpbGQvQlVJTEQveGVuLTQuMTcuMC94ZW4vaW5jbHVkZS94
ZW4vbGliL3g4Ni9NYWtlZmlsZSBhbGwNCsKgIENQUMKgwqDCoMKgIGluY2x1ZGUvY29tcGF0L2Fy
Y2gteDg2XzMyLmkNCsKgIENQUMKgwqDCoMKgIGluY2x1ZGUvY29tcGF0L2ZlYXR1cmVzLmkNCi91
c3IvYmluL3B5dGhvbg0KL2J1aWxkZGlyL2J1aWxkL0JVSUxEL3hlbi00LjE3LjAveGVuLy4uL3hl
bi90b29scy9nZW4tY3B1aWQucHkgLWkNCi9idWlsZGRpci9idWlsZC9CVUlMRC94ZW4tNC4xNy4w
L3hlbi8uLi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oDQotbyBj
cHVpZC1hdXRvZ2VuLmgubmV3DQrCoCBDUFDCoMKgwqDCoCBpbmNsdWRlL2NvbXBhdC9ubWkuaQ0K
aWYgISBjbXAgLXMgY3B1aWQtYXV0b2dlbi5oLm5ldyBjcHVpZC1hdXRvZ2VuLmg7IHRoZW4gbXYg
LWYNCmNwdWlkLWF1dG9nZW4uaC5uZXcgY3B1aWQtYXV0b2dlbi5oOyBlbHNlIHJtIC1mIGNwdWlk
LWF1dG9nZW4uaC5uZXc7IGZpDQrCoCBDUFDCoMKgwqDCoCBpbmNsdWRlL2NvbXBhdC9waHlzZGV2
LmkNCsKgIENQUMKgwqDCoMKgIGFyY2gveDg2L2FzbS1tYWNyb3MuaQ0KwqAgQ0PCoMKgwqDCoMKg
IGFyY2gveDg2L2Jvb3QvY21kbGluZS5vDQrCoCBCSU5GSUxFIGNvbW1vbi9jb25maWdfZGF0YS5T
DQpnemlwIC1uIC1jIC5jb25maWcgPmNvbW1vbi9jb25maWcuZ3oNCsKgIENDwqDCoMKgwqDCoCBj
b21tb24vY29yZV9wYXJraW5nLm8NCsKgIFVQRMKgwqDCoMKgIGFyY2gveDg2L2luY2x1ZGUvYXNt
L2FzbS1tYWNyb3MuaA0KZ2NjIC1NTUQgLU1QIC1NRiAuLy5hc20tb2Zmc2V0cy5zLmQgLW02NCAt
REJVSUxEX0lEIC1mbm8tc3RyaWN0LWFsaWFzaW5nDQotc3RkPWdudTk5IC1XYWxsIC1Xc3RyaWN0
LXByb3RvdHlwZXMgLVdkZWNsYXJhdGlvbi1hZnRlci1zdGF0ZW1lbnQNCi1Xbm8tdW51c2VkLWJ1
dC1zZXQtdmFyaWFibGUgLVduby11bnVzZWQtbG9jYWwtdHlwZWRlZnMgLU8xDQotZm5vLW9taXQt
ZnJhbWUtcG9pbnRlciAtbm9zdGRpbmMgLWZuby1idWlsdGluIC1mbm8tY29tbW9uIC1XZXJyb3IN
Ci1XcmVkdW5kYW50LWRlY2xzIC1Xbm8tcG9pbnRlci1hcml0aCAtV3ZsYSAtcGlwZSAtRF9fWEVO
X18gLWluY2x1ZGUNCi4uL2luY2x1ZGUveGVuL2NvbmZpZy5oIC1nIC1taW5kaXJlY3QtYnJhbmNo
PXRodW5rLWV4dGVybg0KLW1pbmRpcmVjdC1icmFuY2gtcmVnaXN0ZXIgLWZuby1qdW1wLXRhYmxl
cyAtSS4vaW5jbHVkZQ0KLUkuL2FyY2gveDg2L2luY2x1ZGUgLUkuLi9pbmNsdWRlIC1JLi4vYXJj
aC94ODYvaW5jbHVkZQ0KLUkuLi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tYWNoLWdlbmVyaWMNCi1J
Li4vYXJjaC94ODYvaW5jbHVkZS9hc20vbWFjaC1kZWZhdWx0IC1EWEVOX0lNR19PRkZTRVQ9MHgy
MDAwMDANCi1tc29mdC1mbG9hdCAtZm5vLXBpZSAtZm5vLXN0YWNrLXByb3RlY3RvciAtZm5vLWV4
Y2VwdGlvbnMNCi1mbm8tYXN5bmNocm9ub3VzLXVud2luZC10YWJsZXMgLVduZXN0ZWQtZXh0ZXJu
cyAtREhBVkVfQVNfVk1YDQotREhBVkVfQVNfU1NFNF8yIC1ESEFWRV9BU19FUFQgLURIQVZFX0FT
X1JEUkFORCAtREhBVkVfQVNfRlNHU0JBU0UNCi1ESEFWRV9BU19YU0FWRU9QVCAtREhBVkVfQVNf
UkRTRUVEIC1ESEFWRV9BU19DTEFDX1NUQUMgLURIQVZFX0FTX0NMV0INCi1ESEFWRV9BU19RVU9U
RURfU1lNIC1ESEFWRV9BU19JTlZQQ0lEIC1ESEFWRV9BU19NT1ZESVIgLURIQVZFX0FTX0VOUUNN
RA0KLURIQVZFX0FTX05FR0FUSVZFX1RSVUUgLURIQVZFX0FTX05PUFNfRElSRUNUSVZFIC1tbm8t
cmVkLXpvbmUgLWZwaWMNCi1tbm8tbW14IC1tbm8tc3NlIC1tc2tpcC1yYXgtc2V0dXAgLWZjZi1w
cm90ZWN0aW9uPW5vbmUNCictRF9fT0JKRUNUX0xBQkVMX189YXNtLW9mZnNldHMucycgLW1wcmVm
ZXJyZWQtc3RhY2stYm91bmRhcnk9MyAtUyAtZzANCi1vIGFzbS1vZmZzZXRzLnMubmV3IC1NUSBh
c20tb2Zmc2V0cy5zIC4uL2FyY2gveDg2L3g4Nl82NC9hc20tb2Zmc2V0cy5jDQppZiAhIGNtcCAt
cyBhc20tb2Zmc2V0cy5zLm5ldyBhc20tb2Zmc2V0cy5zOyB0aGVuIG12IC1mDQphc20tb2Zmc2V0
cy5zLm5ldyBhc20tb2Zmc2V0cy5zOyBlbHNlIHJtIC1mIGFzbS1vZmZzZXRzLnMubmV3OyBmaQ0K
wqAgQ0PCoMKgwqDCoMKgIGNvbW1vbi9zeW1ib2xzLWR1bW15Lm8NCsKgIENDwqDCoMKgwqDCoCBs
aWIveDg2L2NwdWlkLm8NCmxkIC1tZWxmX2kzODbCoCAtTiAtVCAuLi9hcmNoL3g4Ni9ib290L2J1
aWxkMzIubGRzIC1vDQphcmNoL3g4Ni9ib290L2NtZGxpbmUubG5rIGFyY2gveDg2L2Jvb3QvY21k
bGluZS5vDQpsZCAtbWVsZl9pMzg2wqAgLU4gLVQgLi4vYXJjaC94ODYvYm9vdC9idWlsZDMyLmxk
cyAtbw0KYXJjaC94ODYvYm9vdC9yZWxvYy5sbmsgYXJjaC94ODYvYm9vdC9yZWxvYy5vDQpvYmpj
b3B5IC1qIC50ZXh0IC1PIGJpbmFyeSBhcmNoL3g4Ni9ib290L2NtZGxpbmUubG5rDQphcmNoL3g4
Ni9ib290L2NtZGxpbmUuYmluDQpvYmpjb3B5IC1qIC50ZXh0IC1PIGJpbmFyeSBhcmNoL3g4Ni9i
b290L3JlbG9jLmxuayBhcmNoL3g4Ni9ib290L3JlbG9jLmJpbg0KwqAgQ0PCoMKgwqDCoMKgIGFy
Y2gveDg2L2Jvb3QvaGVhZC5vDQrCoCBDQ8KgwqDCoMKgwqAgZHJpdmVycy9hY3BpL3RhYmxlcy90
YmZhZHQubw0Kcm0gYXJjaC94ODYvYm9vdC9jbWRsaW5lLmxuayBhcmNoL3g4Ni9ib290L3JlbG9j
Lmxuaw0KwqAgQ0PCoMKgwqDCoMKgIGNvbW1vbi9tZW1vcnkubw0KwqAgTETCoMKgwqDCoMKgIHBy
ZWxpbmsubw0KbGTCoMKgwqAgLW1lbGZfeDg2XzY0wqAgLVQgYXJjaC94ODYveGVuLmxkcyAtTiBw
cmVsaW5rLm8gLS1idWlsZC1pZD1zaGExIFwNCsKgwqDCoCAuL2NvbW1vbi9zeW1ib2xzLWR1bW15
Lm8gLW8gLi8ueGVuLXN5bXMuMA0KwqAgSE9TVENDwqAgYXJjaC94ODYvYm9vdC9ta2VsZjMyDQpu
bSAtcGEgLS1mb3JtYXQ9c3lzdiAuLy54ZW4tc3ltcy4wIFwNCsKgwqAgwqB8IC4vdG9vbHMvc3lt
Ym9sc8KgIC0tc3lzdiAtLXNvcnQgXA0KwqDCoCDCoD4uLy54ZW4tc3ltcy4wLlMNCi91c3IvYmlu
L21ha2UgLWYgLi4vUnVsZXMubWsgb2JqPS4gLi8ueGVuLXN5bXMuMC5vDQrCoCBDQ8KgwqDCoMKg
wqAgLnhlbi1zeW1zLjAubw0KbGTCoMKgwqAgLW1lbGZfeDg2XzY0wqAgLVQgYXJjaC94ODYveGVu
LmxkcyAtTiBwcmVsaW5rLm8gLS1idWlsZC1pZD1zaGExIFwNCsKgwqDCoCAuLy54ZW4tc3ltcy4w
Lm8gLW8gLi8ueGVuLXN5bXMuMQ0Kbm0gLXBhIC0tZm9ybWF0PXN5c3YgLi8ueGVuLXN5bXMuMSBc
DQrCoMKgIMKgfCAuL3Rvb2xzL3N5bWJvbHPCoCAtLXN5c3YgLS1zb3J0IC0td2Fybi1kdXAgXA0K
wqDCoCDCoD4uLy54ZW4tc3ltcy4xLlMNCi91c3IvYmluL21ha2UgLWYgLi4vUnVsZXMubWsgb2Jq
PS4gLi8ueGVuLXN5bXMuMS5vDQrCoCBDQ8KgwqDCoMKgwqAgLnhlbi1zeW1zLjEubw0KbGTCoMKg
wqAgLW1lbGZfeDg2XzY0wqAgLVQgYXJjaC94ODYveGVuLmxkcyAtTiBwcmVsaW5rLm8gLS1idWls
ZC1pZD1zaGExIFwNCsKgwqDCoCAtLW9ycGhhbi1oYW5kbGluZz13YXJuIC4vLnhlbi1zeW1zLjEu
byAtbyB4ZW4tc3ltcw0Kbm0gLXBhIC0tZm9ybWF0PXN5c3YgLi94ZW4tc3ltcyBcDQrCoMKgIMKg
fCAuL3Rvb2xzL3N5bWJvbHMgLS1hbGwtc3ltYm9scyAtLXhlbnN5bXMgLS1zeXN2IC0tc29ydCBc
DQrCoMKgIMKgPi4veGVuLXN5bXMubWFwDQpybSAtZiAuLy54ZW4tc3ltcy5bMC05XSogLi8uLnhl
bi1zeW1zLlswLTldKg0KYXJjaC94ODYvYm9vdC9ta2VsZjMyIC0tbm90ZXMgeGVuLXN5bXMgLi8u
eGVuLmVsZjMyIDB4MjAwMDAwIFwNCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYG5tIHhl
bi1zeW1zIHwgc2VkIC1uZSAncy9eXChbXiBdKlwpIC4NCl9fMk1fcndkYXRhX2VuZCQvMHhcMS9w
J2ANCm9kIC10IHg0IC1OIDgxOTIgLi8ueGVuLmVsZjMywqAgfCBncmVwIDFiYWRiMDAyID4gL2Rl
di9udWxsIHx8IFwNCsKgwqAgwqB7IGVjaG8gIk5vIE11bHRpYm9vdDEgaGVhZGVyIGZvdW5kIiA+
JjI7IGZhbHNlOyB9DQpvZCAtdCB4NCAtTiAzMjc2OCAuLy54ZW4uZWxmMzIgfCBncmVwIGU4NTI1
MGQ2ID4gL2Rldi9udWxsIHx8IFwNCsKgwqAgwqB7IGVjaG8gIk5vIE11bHRpYm9vdDIgaGVhZGVy
IGZvdW5kIiA+JjI7IGZhbHNlOyB9DQptdiAuLy54ZW4uZWxmMzIgeGVuDQpnemlwIC1uIC1mIC05
IDwgeGVuID4geGVuLmd6Lm5ldw0KeyBubSAtbiB4ZW4tc3ltcyB8IGdyZXAgLXYgJ1woY29tcGls
ZWRcKVx8XChcLm8kXClcfFwoIFthVXddDQpcKVx8XChcLlwubmckXClcfFwoTEFTSFtSTF1ESVwp
JzsgXA0KYXdrIDwgYXJjaC94ODYvaW5jbHVkZS9hc20vYXNtLW9mZnNldHMuaCBcDQonL14jZGVm
aW5lIF9fQVNNX09GRlNFVFNfSF9fLyB7IG5leHQgfSA7IC9eI2RlZmluZSAvIHsgcHJpbnRmICIl
MDE2eCAtDQorJXNcbiIsICQzLCAkMiB9JzsgfSA+IFN5c3RlbS5tYXANCm12IHhlbi5nei5uZXcg
eGVuLmd6DQoNCg0KUHJlc3VtYWJseSBhbGwgb2YgdGhlc2UgZXhhbXBsZXMgd2FudCBzd2l0Y2hp
bmcgZnJvbSB0aGVpciBjdXJyZW50DQphZC1ob2MgbG9naWMgdG8gYSBjbWRfKiBiYXNlZCB2ZXJz
aW9uP8KgIEFyZSB0aGVyZSBzb21lIHNpbXBsZQ0KaW5zdHJ1Y3Rpb25zIGZvciBob3cgdG8gY29u
dmVydD8NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 15:00:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 15:00:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422259.668157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizhJ-0006vc-F7; Thu, 13 Oct 2022 15:00:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422259.668157; Thu, 13 Oct 2022 15:00:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizhJ-0006vV-Bt; Thu, 13 Oct 2022 15:00:33 +0000
Received: by outflank-mailman (input) for mailman id 422259;
 Thu, 13 Oct 2022 15:00:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xhTA=2O=citrix.com=prvs=278783dfc=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oizhI-0006vP-Pl
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 15:00:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c6eca9aa-4b07-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 17:00:30 +0200 (CEST)
Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 11:00:28 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BLAPR03MB5569.namprd03.prod.outlook.com (2603:10b6:208:287::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 15:00:20 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 15:00:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6eca9aa-4b07-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665673231;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=hIzasv3oIUd/MAb+jyBuxyPRM1xYyg9mJUItM2ggxvE=;
  b=T7Wz3qoa1WB0UlVP9MQM4IbnnGTvCVJRak2kAWzinlYrUpmBFDewZodn
   vWTN/FFwBpw0y5AhUERvzDnpI1++efYTYewTar9vX3X76o645uLDa9w8E
   HLmKvQ8ydCXcxd0nlmDsDGcHf9V3HSZShSaOQSb6FXo0M62LMu5HI1QAU
   Y=;
X-IronPort-RemoteIP: 104.47.55.176
X-IronPort-MID: 83086112
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:sNa9vKJ5DTEwUwkDFE+R7ZQlxSXFcZb7ZxGr2PjKsXjdYENS0zcOz
 zBMWzvTO6mCYGL8c9wiPYrk9EtUuJPXmoJgGgRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4WhA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fb0Gvb59Blpxz
 t0RLQIvLQmnpcfs3q3uH4GAhux7RCXqFKU2nyg6iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q/T/PVpi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv
 Dnu9GXlGBAKcteYzFJp91r83befw3qiAur+EpWXsc9xgHCyxlAPESY9e2CjsNiryXSXDoc3x
 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbjNHcs1gi8YwShQjz
 FrPlNTsbRR1t6afU3Wa9bG8oja7OCxTJmgHDQcbSSMV7t+lp5s85i8jVf5mGa+xy9fzSTf5x
 mnQqDBk3upNy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1
 EXoUeDHhAzSJflhTBCwfdg=
IronPort-HdrOrdr: A9a23:4krwhKEl6FjJLT10pLqFS5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq
 iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO
 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46
 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ
 HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8
 o=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="83086112"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h7D92FzVU5BaKWqblZJXioBxEqMFOl7FY85aXLHucVxnS2WZ4OgXNeZXsf8ylSpldyc0QQEkfu7D9AgbeqZsEh3aznrlfZ1VQTqcSVuASXaJ5SBVNN8er1ry+GFKNhY4fi5SFa6EsTcjCRARe2YQ9/4qHdx4qKh9nUXDCu1GlJ66H0rg4QYYkYuvNP7vg3mnhrw99lhpRuz1gdebmNRdl8le1tBgkGZ2or5Ra8omBp+ChGIkE6EmxLlQlvPakVh4N/bcBIxt/Y2SC3eqF78XjFjs6LFKbEElseC6IE2L1Ha1fBTpD5b/Gp97/iaNxv3a4Jk13jkUJzHoY7atHcw5RQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hIzasv3oIUd/MAb+jyBuxyPRM1xYyg9mJUItM2ggxvE=;
 b=IqV31rniVEJNiiOhrNr3lNZoMx1hHGMo5oWtZ9lrRHUL9pWgXynJDEoid1M2xvxm9sBoG6I22DAGUSH39y4fA/Z6qGTVj9cuSxDICqcRmipYc+DeaIDQLIKjqMzk+8Lcsfp/IHXjWF7VMkLJsotuJMYWVn3y7nFs+44M844LPVXrvdxWlSV7qThA9newabQKzK0bcwouRtbQpjtBGut1oQwivmiGsgbnnn3zF3MCwf2wS2nRbWiDTneC3YKue18wiP8vzpPmGUXMD9V6kI/pau++c7TG4xwKLZIlx2aKD+CiWexYILqOnSsfwKIeV7WIqPqlusdrQjaAyBeknRr1QA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hIzasv3oIUd/MAb+jyBuxyPRM1xYyg9mJUItM2ggxvE=;
 b=Kr5bIqzen+4bDGbNZoBP4HeZQa3+LS/G3EAqxlj4VsSZUr/wW3W+w5eXvt8KZgLRl3Q8SxgkJWMxIuKg4czt7BEIIOdIk0YGGd4vAvgU9f2bu3d028UEV1uZh6UntOPXFmzHmVmD+0FQoZbSq6/l/tY7X3F97pYACVNNO/QVsvg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Henry Wang <Henry.Wang@arm.com>, George Dunlap <George.Dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Topic: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Index: AQHY3wYExc++jpfrd0yvyakMPv5Mw64MavoA
Date: Thu, 13 Oct 2022 15:00:20 +0000
Message-ID: <3d5e662c-91b5-a390-c21e-90391961bd45@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-17-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-17-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5569:EE_
x-ms-office365-filtering-correlation-id: 774804e9-8708-4bac-91ca-08daad2ba5ff
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 0qt9dZjjlZNAjk0fCvfpzhEBjz6h9l2FUQfCRif6ibQkbYox4gjctaCvjlWdrh9AN5a7ycewOQuNKGUl9s1MhnU8Zx4AuckdM6g5U1Ehex0JR56EDsuKt9WcVTrKWoamaD9uSuCWkn8i5R1OwPGUCOtYAuWwn8Q6y8uTYiiDX0rWsuhsUqtl/ywdOHDiNxkmlMNGW0/QSC9Fvf6pikDC95zRXd1YiAvSitq4Rj/YhJ8hQWnPvx+ooRkwjSH+dSn7M35t3SZmR9mFK2tyOOCxjjeFNJJ8H9c+cOvGuu5kbUDAZd02b06wcb+FLRAPvPVCc1peBSxlu90paSooo8tIJa0EiFTbEX508nXWhcezjNvEScNWVwarw8D0paPiRJTS5ow97IY/DabfjRLChlLwpSWpqP+Gn0jgCSeDB+2tHjX527Uf/2+EsV7EFSev6hQfFnjDAJaMVtyleJLk4q4lXkirFXucW4p1njcN0VfShoy+39q3XItt8haapOXbgaUKPx/NmanrBSp/9FBGjN4FwNp2LS06C/cTIRoqnOS/yW4MaBG2YQO8zAppfMkgG/I/RX9OahKWclRrkut0JS8for7NCXV4peqEDWMThEnmy5giNIzWEju2ofUV+EPulqNf2I05P0yJMUfWX84rGT7V7SiB2OvCuUT9etmAu56M9YGVGUs6/FSM0/22w5kDRyNlVAPsFoeLM3VBjnM8PfxF0ZuM3IAvj2dvATP1jn0T7Vk90CiUdkmI/WBt+mJ8EnkKs0HZscY4OwcS2PtPibbV7WqBA9dqRSHJIMtH3pgZFCrh7Czfw9h4Eid3OtgjuOShSApIaZrlHSAVdfJ2oRoZ6w==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199015)(36756003)(2616005)(186003)(26005)(6512007)(53546011)(91956017)(2906002)(122000001)(316002)(110136005)(66446008)(54906003)(41300700001)(66476007)(66946007)(31696002)(66556008)(86362001)(8936002)(8676002)(4326008)(64756008)(76116006)(38100700002)(82960400001)(478600001)(6506007)(71200400001)(5660300002)(38070700005)(6486002)(4744005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SWZQZFdrVWdBbVEydE52VXJ1MzFLUnJXZHZ4UjBuUVR0RkFkVDVDazNhbEpl?=
 =?utf-8?B?KzF4OXg5MnYxQTZzQ0QzQkwvdHBESy8xMzBJb2FYK0JOR1ZNTUl6SkNtRDJE?=
 =?utf-8?B?TkMvK0FWSjM5eHV0dzBUZHlpNEU4QnhmbktrQWZOLzFpYVkzdnJBVVJCM3By?=
 =?utf-8?B?ZDMwSEdxR0xGZUpKNVJGV2dtaU5wQ2lsbm00a0RnNnRGR0JlVktFd0ZwZ2ly?=
 =?utf-8?B?NE5RaU1ab3ppWFkzUEtGQUNtVzIrb3JlTEQxSytVUlpnUFNWcjBMa3NMSXZn?=
 =?utf-8?B?cXlEdnVQTmFIbE9YNUJuZTRSS3ZxT3l5MUU0MGVjbW81Z24xSG1lYXFUaXd1?=
 =?utf-8?B?ekRDS2pOMFBrWFFrMGVGU0xGT1ptM0lReFM3T2hDa3YxcXRwNHgvNjYzOGdi?=
 =?utf-8?B?Z0ttdEJ6TmlrbTVaMkJLSWFaNFd5R1EzNldRenRwdXZiRWMxcnp6RHMxeWx0?=
 =?utf-8?B?cjhidUlPNHZ5cXpIOWZWWVNhOGtNanduYU90TUF3TDJLQ2tqVGJrVnpWVE12?=
 =?utf-8?B?R09LSGR3bTFRcUEzTmEvbSs0QS9ZaHVTN1RjVjB1QlByQWJsc1dlYVNXUnMv?=
 =?utf-8?B?NGF6STROaUlMR1g5VjJkU0lHckRHNTVRYlNZb1Rub2lPYlZmVm5yalNqWnpJ?=
 =?utf-8?B?Q1Q0MHpFcDh3SStYN2FDZVozaXVOQk1WNEZzc3pwUEtGWDlXdXJVN0p4WW9G?=
 =?utf-8?B?NEtnczcxYUdPUFIxdzdtVFYrYmtYdUhvMUJxTVpXZW1aMTNGazBrUW5jaGtO?=
 =?utf-8?B?eXJKaXV0MkcwMlNYemM4d1hxY3BrV0QrTHYwdUZjU0JONllHRXJvQ3JMK1I0?=
 =?utf-8?B?bVhONHozbjJqeFNMMVZMZ2tBb0E5ZnE3czhZb3BnVVdPVVNRNjRWbU95YkI2?=
 =?utf-8?B?K2JraHJrcXUwMFF1M2YxUE8venV2VEMwc0tHRlBSblFJRjBSbEtXVUg0V3Ex?=
 =?utf-8?B?TlFOMENDTmpHVk5ML0FuRnNBb3JNN3FiSW5TNVNoa3loZG5ZOGxBVExwdWY3?=
 =?utf-8?B?bHVSbnVqWkRsUEJTd2tpL0dHYkdsa2ZZeHdWSWVKLzNzOWJKVFVNTkZQZHAz?=
 =?utf-8?B?MUx2R3pCY2lXWERTczFHTEpVVkN2WElSai8xUmphNHBGeW9renJneVM1VFRJ?=
 =?utf-8?B?VkpXQjR6dHpnNGljdkNEM3VUV1ZNM1NFK3NuK0Nna2tUS0lIN2FQSWxFbUQr?=
 =?utf-8?B?dXFvVVB4U1ltRTUyeWRseS95TEJXZUtjVEVmSlI5anpwVTZGeTlRdnUyT0V6?=
 =?utf-8?B?eU5rUi9BbXphN3BmNWhwSHNxY2RObkhiMmJFL2lySjFYb2ZTdTBSMHBxd1Nz?=
 =?utf-8?B?TUtiYWxoMi90Q21mTElQRjVCNFBZLzdoUTM3RGZkWkhRckVvOG5mQUdUUWhZ?=
 =?utf-8?B?ajJuYlFDcjZ2VmtldzNidENVcVVhc20zMGpUVFByQ3JLWnNtZDV0K3JYdHk4?=
 =?utf-8?B?b3pHbWhtUHJoRkEwendleGRpTUZQMFFIS2crWjJJeFdCNUlucEJFd3A0aDJh?=
 =?utf-8?B?eXpkTExtcFUzMG5aTXg0VllCTEwzSEcvcWZqeUF2UTkwMnAwSWdPWlBkSU1T?=
 =?utf-8?B?VDg3TSt5UzI3dUFUWHp3bjB5U2E0bE1DN09US1NOK3dGSW9FSDdyRW91ZHg0?=
 =?utf-8?B?QnA0ZnBKNEdPMC9FRE5OdHVXZHFBUVVCTzloMENBcFo0REN0NWVFRzZCS216?=
 =?utf-8?B?b2l4YTdnN3JiRGVTei91VUxZMkU0R05QNUZQUG04TEVzR2xJTXpvUllMYnhY?=
 =?utf-8?B?TUtvdjFXWWltWkZ2Z0w1Ykl6UUxSMVNYR1k5VytCL3dXV09MOTIxdktaZHpT?=
 =?utf-8?B?WHozd3RmMXM4bVR5N041cHZOQU53enIzc3dLdURleGNWOXZRNGRPdmk0M3Rx?=
 =?utf-8?B?LzYvUGlad2hYd0xuNkkxd1Y3M0xCUUJnTzFGUkNTTTFlYmVvNndxbm9QTCth?=
 =?utf-8?B?MWN0cUNHZWE2VTExQzYrSkJXUnVuRm5BN3NaWkhFakJyZU5TZ3d0Ty9tdVdK?=
 =?utf-8?B?V1NHVVpwODN4WjhIR3pyQXAyWVpDVEpTWThTZ0o4cEhRQXBiakI2US9LazJq?=
 =?utf-8?B?NEt4ODJ5SlpYQ2ZkTHVsY1ZIeXNqdi90aHNnZ2tIM05qSXhncWR3dlA5Zkpw?=
 =?utf-8?Q?mhO/oevYKN2BP2v/OsKes+xmi?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <660E231B33CD8C499D43BB1F9A1521B6@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 774804e9-8708-4bac-91ca-08daad2ba5ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 15:00:20.6066
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UzuQvwoqPjclGXrBo3h/1xvZ4irVNp7J4ZJ80j6wywgXd+p83MftNKARtBciwdG4H4eZhwYUQdi8OTdUUS/yRJU5ieQt7i9zrHe59fcclsQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5569

T24gMTMvMTAvMjAyMiAxNDowNSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IGRpZmYgLS1naXQg
YS90b29scy9nb2xhbmcveGVubGlnaHQvZ2VuZ290eXBlcy5weSBiL3Rvb2xzL2dvbGFuZy94ZW5s
aWdodC9nZW5nb3R5cGVzLnB5DQo+IGluZGV4IGFjMWNmMDYwZGQuLmZmNGMyYWQyMTYgMTAwNjQ0
DQo+IC0tLSBhL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5DQo+ICsrKyBiL3Rv
b2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5DQo+IEBAIC03MjMsNyArNzIzLDEzIEBA
IGRlZiB4ZW5saWdodF9nb2xhbmdfZm10X25hbWUobmFtZSwgZXhwb3J0ZWQgPSBUcnVlKToNCj4g
ICAgICByZXR1cm4gd29yZHNbMF0gKyAnJy5qb2luKHgudGl0bGUoKSBmb3IgeCBpbiB3b3Jkc1sx
Ol0pDQo+ICANCj4gIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6DQo+ICsgICAgaWYgbGVuKHN5
cy5hcmd2KSAhPSA0Og0KPiArICAgICAgICBwcmludCgiVXNhZ2U6IGdlbmdvdHlwZXMucHkgPGlk
bD4gPHR5cGVzLmdlbi5nbz4gPGhlbHBlcnMuZ2VuLmdvPiIsIGZpbGU9c3lzLnN0ZGVycikNCg0K
VGhpcyBicmVha3Mgd2l0aCBQeTIuNy7CoCBOZWVkcyBhDQoNCmZyb20gX19mdXR1cmVfXyBpbXBv
cnQgcHJpbnRfZnVuY3Rpb24NCg0KaW5zZXJ0aW5nIGF0IHRoZSB0b3AuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 15:14:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 15:14:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422267.668167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizuF-0000CU-Oh; Thu, 13 Oct 2022 15:13:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422267.668167; Thu, 13 Oct 2022 15:13:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizuF-0000CN-Lt; Thu, 13 Oct 2022 15:13:55 +0000
Received: by outflank-mailman (input) for mailman id 422267;
 Thu, 13 Oct 2022 15:13:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xhTA=2O=citrix.com=prvs=278783dfc=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oizuE-0000CH-KP
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 15:13:54 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4b4de17-4b09-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 17:13:52 +0200 (CEST)
Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 11:13:34 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB5840.namprd03.prod.outlook.com (2603:10b6:a03:2d0::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct
 2022 15:13:32 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 15:13:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4b4de17-4b09-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665674032;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Kzobd9ofSwAjqBK2rHCoIxcXnftEy8smg0J8wQGSSSs=;
  b=fp+kL/Tq3m3h0KjtDzeTCyMf6LdofnCjSyY1lGeH/u8rb4IZhge5gVL/
   qK7u+KYZTPTTwiSD/PK4xQYis6CExz2bPoeUHeiEtKJUBY3EOYlHF7YUW
   sewjix+XmceqwUGuwsExrSN+4kmKO6gvJuDEBHNDCdr4fr4h0OIC/QMMP
   U=;
X-IronPort-RemoteIP: 104.47.55.172
X-IronPort-MID: 85190391
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:43CJlanartauVNfo0hU8t83o5gwYJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLC2uDOamOZ2T8cookbtjj8BxXscOGy9U1TgtoqSk0RiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDnxX5
 7sDGAk3fBmvotvoz62dW9grmZF2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1YZPLvFabI5fvSjQ8lPk1nej
 WXB52njWTkRNcCFyCrD+XWp7gPKtXOmAdNKT+zhnhJsqHGU4XwOKSVMbEv4j+DnkEOxZI57L
 WVBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqrNQzRCAq/
 laRksn1GCd0t7mIVXOa8KzSpjS3UQAXJ2IfYS4PTSMe/sLu5oo0i3rnUdJLAKOzyNrvFlnYz
 jSHqiF4mrsSiNIQ2ruy1Vfdijmoq97CSQtdzhnWW0q14wU/Y5SqD6Sq5kLc9u1oN5uCQx+Ku
 31ss8SX8u0mF5yGky2JBuIXE9mB5euBMTDaqU5iGd8m7TvFxpK4VYVZ4TU7LkE5NM8BIGXte
 BWK5lkX44JPNny3a6Mxe5i2F8kh0annE5LiS+zQad1NJJN2cWdr4R1TWKJZ5Ei1+GBErE31E
 c7znRqEZZrCNZla8Q==
IronPort-HdrOrdr: A9a23:7hi6eqyxHpsTn2JPNzUwKrPxdegkLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD
 AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2x4Uh37D30XklZqvoJhiKobwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66
 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4
 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7JjDsJCy8zBrZLQQF2+YUFrlde8qPMCBcCeU+
 qvOfttcoreEVc=
X-IronPort-AV: E=Sophos;i="5.95,180,1661832000"; 
   d="scan'208";a="85190391"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XRuuoB/FBaJZ0lsj3HSUEi5hHW4t/ue1vh0c0Fa1yPxqsfnpE3iE6BGsIY49PZPSkCqeB4dq/e6lVOGbZfpWAzlpQZSwOuDX4FcmwK9IXHBWcxSi9amB5S7B8sfpvc3BFaxFpSfSHiZ+EdRF8ayUz9opZaxq3JGFXtH8vRIJD58vDouMLrxj8sRw1/deCuVsEOUuaRzE3pZce24v7F9fOTmEuaMrs40nYL0suIWoiA7diX0Uosf3YTZp8fZBBZ6YPdvCiTZdpP0saBl0ajxTW2WrGRnJgt5q+KkYNE7KajyK8M7CT4eiFj9txiWQGan86si/N/HLUI+Xq2hClZNC1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kzobd9ofSwAjqBK2rHCoIxcXnftEy8smg0J8wQGSSSs=;
 b=m3NjSdHtJAQdTEaLLRjcU5qf27GgfuK9mPS4S0gjXL4SN1zBUsMLuBvtrDrYE/HFg+G94STclAyg01IGVdO/c7DCeP3ZUzryW6ISEqx2TvFRVKzpxSB5pCQj8DoW3kT3q58em2/j+ZH6zQkLUh+sUoFA5nTlFGD8hTCg9xsG080LtPHZRLwGPeEZOFxors3VodDk33fjHBXXLRBYb+87b71f2A79Tb4qx9YQlg0QavepA7q/X5V7GF4HAJrzMsT4w/ffwaNO8G91cHAHn/2z9oongXtWbpZ484zRlxgWBDAKiYkSDXe0GDCX36k7K1uHW9+LJ1D4A7Uu5vjuJldqNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Kzobd9ofSwAjqBK2rHCoIxcXnftEy8smg0J8wQGSSSs=;
 b=cg313ul/bPApQ98f9nDLsVpi4nGVS3lbZUCYRHTwqfomxs4PQnfUKpxwKXcg8ZYsFkcpz0o2wlYKBegPasqfrKJDcus4zRQaIQR/lc+oa5Nqf0KUjQvLkK1bbEoUbBkHxaMZq4UCKyXRxcKGLAWHFtWI3o/u9QzLGLBpoWdi+MM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Christian Lindig <christian.lindig@citrix.com>, "Daniel P . Smith"
	<dpsmith@apertussolutions.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, "Tim (Xen.org)"
	<tim@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, David Scott <dave@recoil.org>, Julien Grall
	<julien@xen.org>, George Dunlap <George.Dunlap@citrix.com>
Subject: Re: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere
 else
Thread-Topic: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere
 else
Thread-Index: AQHY3wSKbtadNN9MxUWVvxvJ2AO7864Mbq0A
Date: Thu, 13 Oct 2022 15:13:32 +0000
Message-ID: <b38e17b3-a4d5-c95e-1cbb-71b5ede8c51f@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-6-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-6-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5840:EE_
x-ms-office365-filtering-correlation-id: ca05ba7f-a9c1-4d8a-3725-08daad2d7e0d
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 wWEuN2uQtivmYFWA/nvYFMC5l1NAyyioHWxW96wKhynJpv3vNeaHXOTFKXnbl9sJFeYGuuS85hyli4Dy77tWjM81Dk3xkd6NfBJVOFTNIBkjw/uL/wwHfnG03jaqIHmBnOPq4jwMBOwD9QlHh5m0YYn7WQbls/SmwaHVxccD9nfKfMcbVPS6bRYGfpNGgfIwfFRAMmwgL7C5IsECaRB+rj0Fa+57fcpjpxfvkjVhRh4urrHlxAeBHHmiBVbQzWVEy2d4rkyMPucngRHHxkChhBR4bAfHrxKQsKKXUpU0SuwJpXJk3Ebxd+HoNU/AR724wGiA54qzVmoReHHsn6Ik0SGdpU4iHk0A9HLP5zoWL53anJ1eUZWA4TBGyo3owiLM1lBZq94sIqfFMgOX91GZEEai9FQVhWFQhWlEctuU9lwayI/X3T2YV3JzdeI/SpmzksxZFoqo6T7z+W5cp7nbpXCwL4dfAZTq1Wv7V7M8CePYNZZ0pH3IxhnfypOEIwMM9WXIwY1hxhHn8wNJ4mJA2iVBHTg4zDqbhub2hYsqucLfEM247kXnF4U0tHGa1sBBewALP8b/dasPY7jji40h5lVB+Jud5+/Gvq6PbAr1GK1zQVqhLnEWdaKGoi+64lqGCLBFIu9v76P+8/8KDkU3WGq/Tx51lFDe1WfoJtZvmd2iAauz8rMW4gKz7EcIjVOD7qBpN3AEeEqIiFaaDWBXOqCo8s/BbMBwWNNgJCw2IAl9vH8XRYjv3BMpInMZ7S6PbJ57VV7k+fc5qOVMWcb2JgJsLegTnyMKrNFJsMAThHkjzc906ua8drbRy6hOKQACFXNauUUYf+iBEORUMnqcxQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(36756003)(31686004)(86362001)(31696002)(38100700002)(2906002)(4744005)(5660300002)(82960400001)(122000001)(186003)(2616005)(38070700005)(6506007)(26005)(6486002)(53546011)(110136005)(478600001)(6512007)(71200400001)(54906003)(76116006)(66946007)(66476007)(316002)(66446008)(91956017)(66556008)(41300700001)(4326008)(8936002)(107886003)(64756008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WExJWjQrYlkrYU9PNUp0RXlNL1NZSEc5Mi9jYTZGdk1xcm1EMDRCWWorNDlI?=
 =?utf-8?B?RmM3MFZkeWk2SGM3L1ZESXdYTTZFOTc0S3RZNmo4bE5zL2F2bldrL0dYOFA4?=
 =?utf-8?B?SUYreE5FU2tmeFhJNGp1c1RTeVVYMFRBUnk5Vmppb0tzd0xFdHg3eWpZdllm?=
 =?utf-8?B?WXZjL05xVlJYZ3VzNnhHMHRYVnNtZVorMVN3WVcrSXNtREtRemk2bmgwdlRE?=
 =?utf-8?B?WmkwWTlzbVV2bWJtSkhEWFFJbDVYRjlBWGttYWYrVlNUTFlXTmY3NnV0Q3lT?=
 =?utf-8?B?Nk5iZ3FPaFpRcHRHR3BqNXBEWkw2ZmlHOHZLZ0VUSEJNckw2cTludDl5QXRv?=
 =?utf-8?B?Si82MXV4ZjZLaldsNWUyM1owM05CMTVNZk1qc0xmUUlSYjFldE5RSldxOFFu?=
 =?utf-8?B?YUdKTzdLNlVuL3FQd0J5OWFJOENGN1R5ZDJlMm82L0ZzS010TDlUeXdaY0p2?=
 =?utf-8?B?VllWc2FlSFdqYjcxME5xL2MwbXRmMVRROTR1QkcwU0ZieDVudHBuRGNSUTZo?=
 =?utf-8?B?UTdNQWFoUkc3QnIvN1doRUNxc1BhT1dPcDFVTm1ZbkJteVFYWlJLdDF3SjZR?=
 =?utf-8?B?QWFXN0RSRXZPQjZEa0dlN01ROXYwbW1HMERMNTRNS1ZWbnN1ZDZ2d3JPVzhr?=
 =?utf-8?B?dVkwZWtXNUZRckYxdkp6cWc1aUR5RndwclI2RzhzZFVEUG9tUWhwSGI1bjFx?=
 =?utf-8?B?cmN1UU1JMFN3ZHlDR3FpVldBZjRtZzVpNnFCc3MyR1BhdGtsWHVLc001ZitB?=
 =?utf-8?B?K2RuSlRpRjdGT0Z2OEdnSjhRZ2VqaFEzYlIwSS91SGQxNlhvelRnUWkrT3JK?=
 =?utf-8?B?N1Y5S3pPOUpLTUJReW9UMFJMOWJMVkpiN3ZwZ1ZCS1hac1ZYcFFZbDJNUEVo?=
 =?utf-8?B?clE1V3RXKzhTYU1MRU8wRXYzQTJwOW5DVmtVdWU1RjdhVUJKQmF6OHdUWGl6?=
 =?utf-8?B?TGsrQTlXb3ZNRUR2eTR6MGhZUzJncEdUc2VPTzU2bEVsMHIwUy9xT3htU1l2?=
 =?utf-8?B?bHFNdStWUHRMK3l5NlVjVHVIWXk2eWlYWFY3R1JPUDhkcjNGdUg3U0t0VkJW?=
 =?utf-8?B?YmVsaU5uNHdsQ1o4Mm1EOE5GWE1nZ1czcWdIQW1aUTkrL3prMWxuT0tyNFo0?=
 =?utf-8?B?ZGlSL3gxOWRrYlVrS2Z0TEREdksrcXFZUk9BbDQrMmNicWZYMHZmc09CNk5v?=
 =?utf-8?B?SlNXejdwYW1UWW1yT0JFa2JYK25kRFkzbkRLT09Od3M0ZXJEUXhncjV6WHA4?=
 =?utf-8?B?dVhGRE53MTlzTzJIcHY2OS9CREpHV2ZIZUdJMHppdWNMSEVhTnNUSndZL2Zh?=
 =?utf-8?B?VmdLN2hMUEdhOUhsVUtkUGlkNFliN0F4TEpnQjFTZk5RY0R4MTRsWjR3UlQz?=
 =?utf-8?B?WThpRmxvS3k0aCsydzRGTFNmcDd5QzZRaTM2TzFvK21Bc2hENVpWRi9FOCtQ?=
 =?utf-8?B?Tk9VUkpWTXQ0TUVDRFExK3Nlc0hpSE5kdmpHWjI4MHR6SzA2RTA1OFQvUkor?=
 =?utf-8?B?YVJWdEJKb1grTHQ1emhmVE54bTYxdkc5OGFVZk5Iang2cFY0NWxHUzNGaDJQ?=
 =?utf-8?B?VGZ5ellkaTcvRjgyU0tWMEhkekc4MVdxZG1qVUJoRktpSGNib3VTS1NMUEo2?=
 =?utf-8?B?NXpsQmkyaFVxVDArejBaVG50dEgzVXkyR3kvR2hBcmNLSHBBbTdtN2NpYUQ5?=
 =?utf-8?B?VnZUU3JVWElwVVdxTWlxUG9PYm1tZ2FOY21wWHZoLzlRaExIbEZpSG02K1FI?=
 =?utf-8?B?M3huM1Bza1ViN0NXWVBrdGxlQmh4WlJIMkJhbWhCMElYbkZNODhhVGNyanIr?=
 =?utf-8?B?UEF0eHhlcm5xYy9XbFhaZDUxK0djMWplR3JON3dJaysrU1hCK3dmaG1FQUNn?=
 =?utf-8?B?UjJrdFBUM29OMUJOczFLUGpxQ0phM3BmOU52WTRPbmFRQzZBSTBidW9uQUEy?=
 =?utf-8?B?aGw2TkZYaDBPaVJxZXlEZ3dHdzg1Zy9tcmtYdHJCa1F5RWJ1VWU5TUJzNDlT?=
 =?utf-8?B?QlJ2c2YvdDk2UTVlL1p6RnhhckJoTW9pSFJRdnU0ck9YcCtGeEdSazlTRC9u?=
 =?utf-8?B?TkNHVldaMXl1aSs5TWxVSGh4aTFaQ1RvQjhnMFg5OTF5V1ovOW9IRm00ek92?=
 =?utf-8?Q?m0vhi3aj5pjHzTJJxQsO5G0Aj?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B9964E338AB6AD4AB21303582A851249@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca05ba7f-a9c1-4d8a-3725-08daad2d7e0d
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 15:13:32.6119
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kY0UneJJt8NxTY/NnAce8BSLz6Jwi/1fqQDXyhyYreW/PF605pbEAFKpiLLhrEtRdKzDDE/hBCP2ztMYAULDl+8RbpOOHLWZeIKcyKTZc88=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5840

T24gMTMvMTAvMjAyMiAxNDowNSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IGRpZmYgLS1naXQg
YS90b29scy9kZWJ1Z2dlci9nZGJzeC9SdWxlcy5tayBiL3Rvb2xzL2RlYnVnZ2VyL2dkYnN4L1J1
bGVzLm1rDQo+IGluZGV4IDkyMGYxYzg3ZmIuLjA2MTBkYjg3M2IgMTAwNjQ0DQo+IC0tLSBhL3Rv
b2xzL2RlYnVnZ2VyL2dkYnN4L1J1bGVzLm1rDQo+ICsrKyBiL3Rvb2xzL2RlYnVnZ2VyL2dkYnN4
L1J1bGVzLm1rDQo+IEBAIC0xLDYgKzEsNiBAQA0KPiAgaW5jbHVkZSAkKFhFTl9ST09UKS90b29s
cy9SdWxlcy5taw0KPiAgDQo+IC1DRkxBR1MgICArPSAtV2Vycm9yIC1XbWlzc2luZy1wcm90b3R5
cGVzIA0KPiArQ0ZMQUdTICAgKz0gLVdtaXNzaW5nLXByb3RvdHlwZXMgDQo+ICAjIChnY2MgNC4z
eCBhbmQgbGF0ZXIpICAgLVdjb252ZXJzaW9uIC1Xbm8tc2lnbi1jb252ZXJzaW9uDQo+ICANCj4g
IENGTEFHUy0kKGNsYW5nKSArPSAtV25vLWlnbm9yZWQtYXR0cmlidXRlcw0KPg0KDQpUaGlzIGh1
bmsgaW50cm9kdWNlcyB0cmFpbGluZyB3aGl0ZXNwYWNlLsKgIEFsbCBvdGhlciBodW5rcyBhcmUg
ZmluZS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 15:14:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 15:14:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422268.668179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizuR-0000UV-0n; Thu, 13 Oct 2022 15:14:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422268.668179; Thu, 13 Oct 2022 15:14:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oizuQ-0000UM-Tt; Thu, 13 Oct 2022 15:14:06 +0000
Received: by outflank-mailman (input) for mailman id 422268;
 Thu, 13 Oct 2022 15:14:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzGh=2O=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oizuP-0000Tn-Fz
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 15:14:05 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id abc4be57-4b09-11ed-91b4-6bf2151ebd3b;
 Thu, 13 Oct 2022 17:14:03 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by MW4PR12MB6950.namprd12.prod.outlook.com (2603:10b6:303:207::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Thu, 13 Oct
 2022 15:14:00 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836%6]) with mapi id 15.20.5709.019; Thu, 13 Oct 2022
 15:14:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abc4be57-4b09-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SrmCHU981nb/tB5zDyuLxTIKTLU+WQ6zE1Lpcmj1OQJvE7OoW37AK/1dhGTSb4701nFuW1jjqAR7ftJP9NhnKSTcyWEtnRUkFiObcyJKauIHIIWdzJ0XG3zMgUELuSnn+vf5DnhKscMcvQW40By3KDn9eBMSl8VCxM3jDcYY60bGqpi1NbEvANs/cFBZ2segdkCqHYDv2qjxh5427dh011xfpqWf2E9CeN/dMMCzhZeXct8jKWN9PLYXD5zR0wKPasHg/A2x9I14uZEFNz6uAuAYWtW4ovXl4cjpwYL8GnxG9sSgeh0KpRNhB/AJ9g0KD65KyDnEE3x6cuK5erdNLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZjUPQmvnvCJTrhGMnTfyBxzK++N4OPIj3vEFLRWZiY0=;
 b=a3pglpA/Qz4dlZW2YXfAwG2gmb6T8D/OQNkWeLBA7EWU2ufhNQpSepZdRcqMv9sK5pU24DECdLjYNkLzPpaTAt8DVKjRbEHAJJPBDuSBl5hhynOpeqLLvXrOlOb9PQ5ao0KyIOKLrRjcK7c+b4fNalcLn/v4vNZIpqdnXdrG7w7wf4Hof7lNsThDko6+wa7jeVfFppRZK9nBxucmK52pPNYol87IlxmbfqvKg7eb486qIKu6k4a5nVS4Uzc1RMycDqcz330lYQRjjOt/zEyEfBiDJUqqv/Gt5KtKl8gdQwQQeZK38OjGK61wdoJ8YJa0dCv4VCWDHSOaaunTUdhXnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZjUPQmvnvCJTrhGMnTfyBxzK++N4OPIj3vEFLRWZiY0=;
 b=DC5A6b6eQawKEaFuv0hKeg0L+/aSzYObmCfchZP5SynaKfThj00K9TvvkOJxMwjLqla6z9mSaMS5ZattsdhWHJaJm20LgzB5EHbQsb4zWe23wrhL8ECk88UBjGMm8hptbCpIUZ0NhZkZ89+xuEg2QsvuzDQw+TsfwCMZZ/7rCrM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <28a406b7-0b9d-3c4b-4db4-67af6729e35f@amd.com>
Date: Thu, 13 Oct 2022 16:13:53 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
To: Julien Grall <julien@xen.org>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
 <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
 <96f989d9-4d55-acc9-a0f7-cbb1212480ad@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <96f989d9-4d55-acc9-a0f7-cbb1212480ad@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO6P123CA0023.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:313::9) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MW4PR12MB6950:EE_
X-MS-Office365-Filtering-Correlation-Id: 8dd915f0-b574-4de7-eb97-08daad2d8e87
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QiTzQk9pzGSq1efIKy8D8Fx+BA3+OB9QEs4EqZssONzymrfAFEcrG40dCRzpoNxN1yyVcBo3cYzIBSLPOc1K69b1WnL+yZBPH7h/q2NJHR/9jDo9wD2xDIVDVhM6rNkQKawnP3uxZSXPS178dn7Wz6qjsE7ep/1fHyWzSPkFybNORAHDmawvQCL/3l4J+T+J5/R6//8ClMjKb9zvpA92jAn5qmYQZgnEy996sDS8q9MEn9lxbxtNLF3Loh6SKttiM78/pvtMWan65GytUVJCwPTBtHeUBr07vyuXUjKtqUZ6g7Js/mVi2TWbOR+RVqvl0Q806SSA7wIoHXoWt2qp4rgzzPVmNijiIhoRYq7gMLSaRnpr/N7Cony67ohaLxqO80E5nZWcZlzeOyUG8C/LUHkuw27BqEVgjsuYTz7S8mgtjNtu6I38kVSJ1MoW1wA8kuTnPWbD5tMOlQURW1TCQBDePa64UyoeLdo5M9/ko9JxECSch6hT7hHK/vFFTS1qkSbtWsXFgosAaLi61SeMUzFXHYnl9WqNSZDpXbOrZJNo3wKUJl6q3a//d6A1gk3CG+Eazm75LBxMpoK7bEVpYZMHvMdrLdKTRy4KCsl1BmQGBNydYO0zxXxco+Fcp0M54Ehy8HELEsbi8/45g3LnaSfwTF/hCu6ODQvsoHXQfRfNPm1kPju305UGrzNaZ3VKvRfVsz3l/xyhW3bItwihLUWX0+6Qjszd7nhXNVr8LeziCCUcOB21XWGXrUfgtXdJTsLQNwKOy2CBhEYPWTeGnmlXoXvWcWkThCmxC8H6cozQtVY1O+6bJ7GJXAQpv60qakr67KjX0YVq/13SKbHpvw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(6486002)(83380400001)(36756003)(38100700002)(186003)(31696002)(316002)(8676002)(4326008)(66556008)(66476007)(66946007)(2906002)(6506007)(2616005)(41300700001)(8936002)(5660300002)(6666004)(26005)(966005)(54906003)(6512007)(53546011)(31686004)(478600001)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YmhwTER6a3hHNnpzOG5TUkg0Smg1Tk1odzdUdmN0ZkpmWWFITnJvdFRTeHYy?=
 =?utf-8?B?MFpCQW5rQ29ZTVhyQy9IVVJpc3lEbVFtUHFQVG95enlmTVI4MzFtYmRUUjEx?=
 =?utf-8?B?WmQvRE5CekxOc1M0ckN1ejdRTHhlWCtubllDa3FHdjVSdTd5TGRLUVBRTnBQ?=
 =?utf-8?B?V2RUanZIemYvU25TZDU2blNyK0dkV01wa0JTYVMzMmlXZDA5b2VYYmFkU0la?=
 =?utf-8?B?bTNiUmdBVmp3emtsbjR4Zy9adEw5UFc4WFB5WGo3cWxHT0QycE9LYi9zYTJr?=
 =?utf-8?B?MGZTVndybS9NSFl4Tk9UQWR0am9Bc1hrcGRJVjZYMkFSZHEzaGFvL1A2NERK?=
 =?utf-8?B?bVBXenY5YmdYdEFpajNQZTdXc3BVS1hIZUdGeFR0elpBMURZQmRpRy9Wcnh4?=
 =?utf-8?B?YmNYU0NWODk4LzNYNzJYNjB6MG5jKzdnZWgvdnpsMy9IZDFMVWYvRFVYQi9R?=
 =?utf-8?B?aHpLTStsNUtoV0lSd282Z2xwQWhKUjR2bTFJenpBK3VzYmMxaCtobXpRZ1JF?=
 =?utf-8?B?L3dOd3lETDhNRFN3WUZrdlBKZ2tDREFTMUowZ2tDOXZ5QWgweTdCT3J2eTVG?=
 =?utf-8?B?UncwODlBcjlvSlIrbnVSL1Y4UnJKSDJSRm52Y0wwODMzT005dTBUa3h3eVJo?=
 =?utf-8?B?a3Z0MHdqYjdCMGc1cVpQdk9ZcEk0VHdNK1R5cVpCU0xtdUlTYk93VW9iUS9K?=
 =?utf-8?B?Q0NteVYyWkRacy9iZUVQYTlQeDQybjgydjhPcFF6cmtnbm55dDM3U1NNVHpK?=
 =?utf-8?B?UEt4ZVBrMXRZRXBlbXI3dys0dmtCM2hPK0JGRDZpUzNiR0I2V2FCWEYrcmUy?=
 =?utf-8?B?eUlKZ056eEIyeXNRWHNZWnVlNzFrWk1haVZPVU8wWXNBdGt6VnFsZnd6Z3dr?=
 =?utf-8?B?SHlmNHhacFloT1p1T0ZYbGlOb3FQdXZ1UStnRHFLVk5DMDFQL3lUNEpoVWp2?=
 =?utf-8?B?NGNIRDRIdklOTWlqZnlPdUhQSElpbUdUd1Fwd09tazZWRllTbTVaSTI5ZnNq?=
 =?utf-8?B?d1VIaGFBT0cwcmppanFpYWdJNVRvb01UdEh2YkRyL012ZGVyWUUrUjNaYVVk?=
 =?utf-8?B?UUYzeTRXSk1hNEV3SmVWYzVwTGliQlZBdFd0TWQvVzNWNDFMQlNtZGlDZjBv?=
 =?utf-8?B?TkJKWitGVXN4ejBwelZ0dVNLQS9UdTExVUMrdk9vVXVicFV4VE1FRk53ZTVk?=
 =?utf-8?B?RnRpSHgzbUw0ZDgxWStaaUhObngxK1laVnlsUzEzUnh3WkdGSko4TEsxRDMv?=
 =?utf-8?B?bmlvS2tNZ1NxQit6dHdFQ3lqUU5rRHFkNW5wbHNVdkRSOSs0UzFaeHZUR1Bo?=
 =?utf-8?B?QmxrNGkzMTBEWGp4b1dEU0VuR0Nqc3VEdnBsM3dRM1NhMU40dmxiY0VyY3Rh?=
 =?utf-8?B?UnExYmVoVCtOU01ZaDRXN0RqZUpDa0xpeFozYytZbFh3czZ4WjNEVUFKN3Va?=
 =?utf-8?B?RFo3cmMzaEJMZEpvZVkwaGM4QzczQllESko4VVpVNVFPZDVCSE5TUkoyRGNh?=
 =?utf-8?B?TjMwNldBWlJ5QzJqdm5YMUE5dXFkT1g1YUdFSnR0SkMyNm94ckNPRlFGdElT?=
 =?utf-8?B?U2h5d21SNDlzNk5lajNJUThCNmN0OElHTDhRRm1HcS9FWlprZTdBQUF1bldq?=
 =?utf-8?B?MXhLL1dXVUVwMEpIbWZWODQyVG1VWWlSZ2JLUGlsTXV1ZFlnanpZTG1yYjd4?=
 =?utf-8?B?L2p6UWhrYUJGa2s5RFFocllxTkRvdFEzZExEc20zaXB6Sy9jRGs5cUF3Mko0?=
 =?utf-8?B?SDBTK09pZTJUeTB3TGYrWlBpenEzSnFEeEpDeXpkMDI1K3RGNHhxYXZRMFM4?=
 =?utf-8?B?UG4vSjRHRWNnbnpxT1dZVU9zRWRBcVJHS1BzTnJwdjRWRFZJRExOcWV2TWFU?=
 =?utf-8?B?MzRiSlhBZmFMZEVMaFR2T2FCMWFOWEhxdy9tKytzQlI5S2VmRGFPUk0xVGJL?=
 =?utf-8?B?ek1FbExjSHErZUhQeGdNcFNqWFBKMWJtTlQwVmRpRjJjTk9qVnEwS1BURkFK?=
 =?utf-8?B?NSt4SU9PNy9VaHRoZ2JoZTNLUWM3RXkxMXVvbi94VENQVkxzdGxoMVhBTlpi?=
 =?utf-8?B?SUJzVlZOdnQ4VE02eGEvRC9WeUZpZEFMOGQySDlsUlMyaGhjRXZqSWx0M1JT?=
 =?utf-8?Q?oqZcl56jdvPIrLcpxrDr2bC6x?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dd915f0-b574-4de7-eb97-08daad2d8e87
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 15:14:00.4939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tEMQrBTXkgDtKvulLwOug0Vdl5leQ0y+hVwCbZrxRkZYrdjmx5DMVR0QEZP8984zqV87nLZxcfZ2WY38mKPJcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6950


On 13/10/2022 15:47, Julien Grall wrote:
> Hi Ayan,
Hi Julien,
>
> On 13/10/2022 15:30, Ayan Kumar Halder wrote:
>>
>> On 13/10/2022 14:20, Julien Grall wrote:
>>> On 13/10/2022 12:47, Ayan Kumar Halder wrote:
>>>> Hi Arm mantainers/Folks,
>>>
>>> Hello,
>>
>> Hi Julien,
>>
>> Appreciate your help as always. :)
>>
>>>
>>>> Please refer to the discussion 
>>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>>
>>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed 
>>>> virtual platform.
>>>>
>>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register 
>>>> using ldrd instruction.
>>>>
>>>> As GICR is emulated by Xen, so this instruction gets trapped with 
>>>> HSR = 0x9200000c.
>>>>
>>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>>
>>>> The proposed solution is to use two sys_read32() on GICR_TYPER to 
>>>> return the lower and upper 32 bits.
>>>>
>>>> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
>>>>
>>>> Now, for Xen to emulate this read, I have proposed the 
>>>> modifications (in my last comment).
>>>
>>> I am confused. Looking at the emulation of GICR_TYPER in Xen 
>>> (arch/arm/vgic-v3.c), the code should already be able to handle 
>>> 32-bit access.
>>
>> When I compile Xen for arm32, vreg_reg64_extract() definitions do not 
>> exist.
>
> Ah. You are building Xen for arm32... This is unsupported by Xen at 
> the moment.
Yes.
>
>>
>> The reason being 
>> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/include/asm/vreg.h;h=f26a70d024e2d1f933ea66793ea6e42f81c7a8cf;hb=9029bc265cdf2bd63376dde9fdd91db4ce9c0586#l189 
>> , BITS_PER_LONG is 32 (Refer xen/arch/arm/include/asm/config.h).
>
> Right, so that's not an architecture issue (like 'ldrd') but just Xen 
> not providing the helper.

Sorry, I was not very clear.

With ldrd, HSR=0x9200000c. As ISV=0, Xen cannot emulate the instruction.

So even if Xen had implemented vreg_reg64_extract() for arm32 GICv3, it 
would not have helped here. Unless, we decide to decode the instruction 
which may not be correct thing to do (as you explained in the comment on 
https://github.com/zephyrproject-rtos/zephyr/pull/51163).

>
> As I wrote above, Xen doesn't yet support GICv3 on arm32. 
> I expect that implementing vreg_reg64_extract() will be one of the step.
I don't think it is required in this particular scenario. I have 
explained below.
>
>>
>> .Thus, the guest need to invoke sys_read32() twice (GICR_TYPER and 
>> GICR_TYPER+4).
>
> I don't understand how you came to this conclusion with what you wrote. 

Sorry for confusion. I was trying to explain that the code does not 
handle 32 bit access of GICR_TYPER on arm32.


> If we had implemented vreg_reg64_extract(), then Zephyr would still 
> need to issue two 32-bit read because Xen doesn't emulate 'ldrd'.

Yes. So what we need here is not the implementation of 
vreg_reg64_extract() for GICR_TYPER.

Zephyr will issue two 32 bit read access for GICR_TYPER and (GICR_TYPER 
+ 4). So Xen needs to emulate 32 bit read for GICR_TYPER and GICR_TYPER + 4.

So, we will need to modify the Xen code as follows :-

|#ifdef AARCH32 case VREG32(GICR_TYPER_L32) : { read and return lower 32 
bits of GICR_TYPER return 1; } case VREG32(GICR_TYPER_H32) : { read and 
return the upper 32 bits of GICR_TYPER return 1; } #else /* For AARCH64 
*/ case VREG64(GICR_TYPER): { do as existing; } #endif Let me know if 
this looks sane. I can then submit a single patch to add support for this. |

>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 15:37:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 15:37:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422281.668190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0Gt-0003P1-SN; Thu, 13 Oct 2022 15:37:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422281.668190; Thu, 13 Oct 2022 15:37:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0Gt-0003Ou-Oq; Thu, 13 Oct 2022 15:37:19 +0000
Received: by outflank-mailman (input) for mailman id 422281;
 Thu, 13 Oct 2022 15:37:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0Gs-0003Ok-9m; Thu, 13 Oct 2022 15:37:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0Gs-00026b-6D; Thu, 13 Oct 2022 15:37:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0Gr-0003Pj-PX; Thu, 13 Oct 2022 15:37:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0Gr-0007Mr-N1; Thu, 13 Oct 2022 15:37:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dq6leJw1jEmMbuRjjkDRPG5HfBFjsTjxrKj/FBTZLOs=; b=ZHgjDhhXnZF4Jhv7uzzFf0MVFP
	xJAesU5o77ugqbgnxLztya1nOgfAMQbmV+sPGKUUnm+OS0P8tq5H2Sht6u01PULoCrmNI2qTTm58N
	RdE4tBiKuWkDHMBiP5QvxedH37ZaxsXcaEX72yT8H3MQwBlsynTI8a8Rp5rbA7dPEaE0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173610-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173610: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-amd64-xl-rtds:debian-fixup:fail:allowable
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 15:37:17 +0000

flight 173610 xen-4.15-testing real [real]
flight 173708 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173610/
http://logs.test-lab.xenproject.org/osstest/logs/173708/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     13 debian-fixup             fail REGR. vs. 172547
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   59 days
Failing since        173494  2022-10-11 13:38:08 Z    2 days    5 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 15:38:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 15:38:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422290.668203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0Hp-00040F-9y; Thu, 13 Oct 2022 15:38:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422290.668203; Thu, 13 Oct 2022 15:38:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0Hp-000408-7L; Thu, 13 Oct 2022 15:38:17 +0000
Received: by outflank-mailman (input) for mailman id 422290;
 Thu, 13 Oct 2022 15:38:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oj0Hn-0003yl-DR
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 15:38:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oj0Hl-00027S-IE; Thu, 13 Oct 2022 15:38:13 +0000
Received: from [15.248.2.148] (helo=[10.24.69.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oj0Hl-0006dv-Cc; Thu, 13 Oct 2022 15:38:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=uO2FZZ7HV9sKiQWbFbi3Yj8E3T9QzxMm0a2QNHMOYYc=; b=h5K9jOFdNr9I8EsP9ZLGBbzK+v
	BOr3RgEsYpFE3h2xTamdD7mUZkfmxW3ZBYJQN+Emv8PUoqiRt9GYQ6YZUasva8aZ0QatyC7XXEvvd
	uqjRgdMqkGEVNnwG/Xbd9fvB1o3LI/WpFc7rFmqj6833Cr95S3YLjB/gREiL90s9inBs=;
Message-ID: <28525ef4-4ecf-e55f-682c-93eeffbc09b5@xen.org>
Date: Thu, 13 Oct 2022 16:38:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.1
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
 <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
 <96f989d9-4d55-acc9-a0f7-cbb1212480ad@xen.org>
 <28a406b7-0b9d-3c4b-4db4-67af6729e35f@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <28a406b7-0b9d-3c4b-4db4-67af6729e35f@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 13/10/2022 16:13, Ayan Kumar Halder wrote:
> 
> On 13/10/2022 15:47, Julien Grall wrote:
>>> .Thus, the guest need to invoke sys_read32() twice (GICR_TYPER and 
>>> GICR_TYPER+4).
>>
>> I don't understand how you came to this conclusion with what you wrote. 
> 
> Sorry for confusion. I was trying to explain that the code does not 
> handle 32 bit access of GICR_TYPER on arm32.
> 
> 
>> If we had implemented vreg_reg64_extract(), then Zephyr would still 
>> need to issue two 32-bit read because Xen doesn't emulate 'ldrd'.
> 
> Yes. So what we need here is not the implementation of 
> vreg_reg64_extract() for GICR_TYPER.
Why not? Your GICR_TYPER is a 64-bit and the helper is the right way to 
hide whether the low/high 32-bit are accessed.

> 
> Zephyr will issue two 32 bit read access for GICR_TYPER and (GICR_TYPER 
> + 4). So Xen needs to emulate 32 bit read for GICR_TYPER and GICR_TYPER 
> + 4.
> 
> So, we will need to modify the Xen code as follows :-
> 
> |#ifdef AARCH32 case VREG32(GICR_TYPER_L32) : { read and return lower 32 
> bits of GICR_TYPER return 1; } case VREG32(GICR_TYPER_H32) : { read and 
> return the upper 32 bits of GICR_TYPER return 1; } #else /* For AARCH64 
> */ case VREG64(GICR_TYPER): { do as existing; } #endif Let me know if 
> this looks sane. I can then submit a single patch to add support for 
> this. |

This is a bit difficult to read. So I looked at your answer on the 
Zephyr thread.

You will end up to duplicate code for emulating TYPER and there are 
quite a few other use of vreg_reg64_extract() in the code.

So I am afraid this is not an option for me. If you implement 
vreg_reg64_* then you will not need to implement.

I would be open to other suggestion so long we don't end up with 
duplication or any other kind of open-coding.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 15:52:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 15:52:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422299.668221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0VW-0006SZ-LU; Thu, 13 Oct 2022 15:52:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422299.668221; Thu, 13 Oct 2022 15:52:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0VW-0006SS-Hx; Thu, 13 Oct 2022 15:52:26 +0000
Received: by outflank-mailman (input) for mailman id 422299;
 Thu, 13 Oct 2022 15:52:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0VV-0006SI-FT; Thu, 13 Oct 2022 15:52:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0VV-0002Ob-AK; Thu, 13 Oct 2022 15:52:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0VU-0004Zv-Ut; Thu, 13 Oct 2022 15:52:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0VU-0006IF-UO; Thu, 13 Oct 2022 15:52:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qablQYa6fRX6DITHYmyVX0o/Lbe2bTG92dRPIBlMsBA=; b=y2oHFqWSfxDteESfSGUTztCqQs
	JS7vet/RokG9fjCuXb0jmCzThHoVmrA1/3n7cTyQPuhjSgYYeYMO0RWDu94tI5/AOjhOCveij9voz
	N1hs92aotonro+if1tcZV4vIWzlGYJhuYADAlalMwgwpGMCzz6UHNvMYU0fPsx5n8yhI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173710-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173710: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0823d57d71c7023bea94d483f69f7b5e62820102
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 15:52:24 +0000

flight 173710 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173710/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  0823d57d71c7023bea94d483f69f7b5e62820102
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    6 days
Failing since        173492  2022-10-11 13:01:50 Z    2 days   12 attempts
Testing same since   173710  2022-10-13 13:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 489 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 16:05:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 16:05:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422312.668252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0iS-0000Qh-1D; Thu, 13 Oct 2022 16:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422312.668252; Thu, 13 Oct 2022 16:05:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0iR-0000Qa-U9; Thu, 13 Oct 2022 16:05:47 +0000
Received: by outflank-mailman (input) for mailman id 422312;
 Thu, 13 Oct 2022 16:05:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mzGh=2O=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oj0iQ-0000QU-BO
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 16:05:46 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2084.outbound.protection.outlook.com [40.107.95.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e361776a-4b10-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 18:05:43 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DS0PR12MB7655.namprd12.prod.outlook.com (2603:10b6:8:11e::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 16:05:40 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836%6]) with mapi id 15.20.5709.019; Thu, 13 Oct 2022
 16:05:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e361776a-4b10-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dcXOLYUc9UUgFBacejQVrBAvoZQPMmcc4xEFP3gkKurfhrq2btOKBrdaNkh6q2i/OJNMQnPOPWiu1CZeZxe35EWdAxB4SBWUSlhzq1q47J8bhMljyHyIAUm0H28BhOZUUrkB/vnycEuU78ZPZpXTv7ZFkR28Qy5w2YQgCICVeNgS8vD3gR6smpNAPZ/FLdtp2FK5QB/P1aR+aAjSv0IvS7JVXV0vsTarWZfrAcjEnCG9+S3PcGTJ+2BTGJe505RRYEGKtUAENuLmBCxWoNLv9dcWmVjiBXis/27JRa8HFG7LQvOs4toKYVjdTA/VQV0Idrvv0ygLpdtCwsT2XluOIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ghb5Oa2pH50R2fze3OMD0bqlb7Lg/17nTDRJVRVWXxQ=;
 b=merlTggRJ2JuW6aMuKlPCOodvlgVjvg95inaXHucdYpP59dUoG5x9k0xkdw7gPyjljooBkXIXHlKlmnP6EuEPfbOrddXCCvcUO1BHNN8XtpeLBOr9JVqaqkL75euij6BmyL2bTzIcHGnjCi9/9BbyrF1VplZnjgSWQbz6m0Ibj6kEguR3WS6TwwjTq1H1RIGMO0b8u1My8UpUp5u9E7ggRmC2dzlHrfhyMSC4djsQH+f1r0GLrw2QVm75sUQRGWuujsICB+IozH+cSJaZSih7dZtXMZGHHGXdO3GCXsrJPHukKE5mgD8ZZIZYtT6DtuRVGDXHRMuaZeoEFdYFw+HiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ghb5Oa2pH50R2fze3OMD0bqlb7Lg/17nTDRJVRVWXxQ=;
 b=JvqMYEIUV8rto2sFeBNKWHh5GONHMiU0+Y9UEpjmQzSClJyKRvK3AXIl4JhGggRZWUZcOzm2CYAPKBiJsHbBYHkHdA5LwqK4ihu3i63zP89nlZxvV9yCLCP7pXUlaDkQv+be8qmE3rfiyHdJFhpi7D5mDZfw5vipYGFVp02i7kA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <8fda8e62-bc95-0506-da67-ddef0b1f73f6@amd.com>
Date: Thu, 13 Oct 2022 17:05:35 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
To: Julien Grall <julien@xen.org>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
 <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
 <96f989d9-4d55-acc9-a0f7-cbb1212480ad@xen.org>
 <28a406b7-0b9d-3c4b-4db4-67af6729e35f@amd.com>
 <28525ef4-4ecf-e55f-682c-93eeffbc09b5@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <28525ef4-4ecf-e55f-682c-93eeffbc09b5@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P265CA0005.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::17) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS0PR12MB7655:EE_
X-MS-Office365-Filtering-Correlation-Id: 9065ad43-f3b4-4f37-8ff7-08daad34c63c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JAgSpsOqcgSAjJDIAovURnqlamNoeV21RSBxAkrvn88/cWIE//7YUMSKGsDoxRh+FO4wuP0CDz2cGiLuuNGibm2XSTk8VmfvIdnWluuUeG653E1/PnPWc/BBpV6gvrzfttNYVNciO7wb/Wegf2ibdKE6wpEm3hahNjfVuDeEHaT7qrTLfoBY3OqSgOZmegykSv/SibivoSmmx97/0EGCQlgCCM0eue+7o6gbnnxt/g63bvtCWBb1h2BElJjvwts2xRT3p0t2iplu+KEEbbCkBHfedrAsC3WyNpTnVKow66OEArft567DKukEsEQIlAw3PxQL2/tn9THs8dAKWgWVCYORKUVv/4w30F3jif4X/KX4k8dOOEh1X4xp6c2+ddXzLgYwHO8lNn6fMrFwVzIAbVYJzD/LkTtBZq8Xy8q0NsRVdIwh/FzJZSKDxCCih/xzTl5yOnvSbDbq1EHYsowAr3T1EvYsGOzx/Or+GsSWNoc9EA8oopytsChyrC/FKF1pDRrXH0K14sUqCL2ntnuJubw1ZekFZIWqEeygiBOGnw6Xv5Bsd0kdpXFVbY1j+qXLPOzD47KPnl1Y64oJcdxbVnsfEyl45Hn/To7WbNynDq6aWWtiYPqQUhdXni+m2GWzb8HateiTzDfXLwLm5Zu3NrWhHPmkVJfVaWdUB2slrUnJd28nGU+gJ27tx0kmxPuw4UZ+rouDoI31JLHDKXgLw0AGihls0RW3+ByP1OBt+2Cg6bbxm3DNw8DtdEEdRmG4JdLFF5XUncxgo3QscByKoFv7e7t5Hjys1/MKqwlgt34=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(451199015)(6666004)(36756003)(4326008)(8676002)(66556008)(53546011)(41300700001)(54906003)(110136005)(316002)(31696002)(5660300002)(8936002)(26005)(83380400001)(6512007)(6506007)(2906002)(2616005)(66946007)(66476007)(186003)(38100700002)(478600001)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0ZHK0hsKy9zNkFsYkRnWUZrNzBadDh0UWppdUMxdk9TRWY1SWRaaUFXa1VF?=
 =?utf-8?B?UUZWSTk3WnZ1MEg3ZDU1WFE3WVlDL2tGN3VrdTNYUkRNV0VtYTZRQXpBWjNV?=
 =?utf-8?B?Q3M2bEdtY3IyS2hSckdlcTFIVGtVS2V4am1TaW0wY3FQT2EyWTJQczVGUkxh?=
 =?utf-8?B?MFNvdHhYbkw3SEt2OXpnN2NSWHVkMlhrTUdmd3k1Ry96dVgrZWF3UVBnZ29S?=
 =?utf-8?B?anRKQjNHRDhkb3h4bkpGeDJTbklwR2dzWDVUZkFxcWNYbHlIcEMxd3pSemI1?=
 =?utf-8?B?T3VJNjJDVFJEVE5LcGRIeUViWXloQnFzUDVKNTBJckRYbWtGc0FGZW80T0dS?=
 =?utf-8?B?Umk4NGVvRzBqemJTVm5FWmVJcFluenAwdmhKbi9vVGpHQ3RBdUcyNG01MWRt?=
 =?utf-8?B?OS9DZU1tOTVkbnIwMFZKbFljNUlIMHZIK2NLbnNiQmxJZkNRQmlEM3ZIWUR6?=
 =?utf-8?B?aVY0V2I4czM3dHUvd1daQzE0ek43bHgydHluZE5BTHFkMHV4YmszVlFkS1Jq?=
 =?utf-8?B?QmlIWUl0c3Z0SW0rQVFMN1pmNktTOUZyYXlka05lU0tINURia3dBVlJhWnZh?=
 =?utf-8?B?WjdIV09oQ2UwNE51dDlscFYvLzZ6bkNsWHp6U3hzWFNBUHA2N2JSVVhTRnRS?=
 =?utf-8?B?Y1Y3STdGZ3dLZGh3Y2FZczNGdDhyYVVOajNIbnJ4bXB0QmZVekdheHkwN2NO?=
 =?utf-8?B?NnUrVnFJOGtTUWtLMml3Q05GbHd4WWRzZG5jdXFUcUo4dFNicFp0TFAzWEFE?=
 =?utf-8?B?bmp3YWw5WU1ZZnNsa2xQQTVkK3p4VCs0eDV1Nm1mVTlwMDFwOXM3U2FvZWoy?=
 =?utf-8?B?aENMb3pOdUl1OVdYSjFVMEp5RkRXM2QwQkdmVHM5TWFobXVmQ3NFeCtXSzlL?=
 =?utf-8?B?UVpsRzh1MlJ2aWhIMnR2dlE3aFg5VitDK2JQOTBVanAzNzlqNUQ3anhMeFFJ?=
 =?utf-8?B?WWloVS9RVFVzdE4vTERzWUI0N1dxNXpnU1lkd3l0UW1aL3dFYjFBb0djVTRT?=
 =?utf-8?B?ZldyNmc2VU9hUHJWWXRscTZWUDdOOXVPb2hHY3IyNXMxY3VLc3N1RjRrVlo2?=
 =?utf-8?B?TW8xdVgycVZ4M1p2VkhIaHRGNzRiWTJWL3pJTXdOcmVQVzJYMUZCU3E1N0NH?=
 =?utf-8?B?bGxzWGFyM2VhVm4zbGd1M0JhNnlXeDZRMEZEZUFTV05BNjNxa2tJY0trUDNM?=
 =?utf-8?B?TU5CM0ZOQmI5RjRsSlBNZVRjSEs5MzVKaURNclFSRkdCak5OZlYySmp0VGor?=
 =?utf-8?B?REVuc0lTL0FrbEVHNjVUVzh5R3ZhQ0NHalRFNnE3OTdtMGVQQW1hWDdOMXRU?=
 =?utf-8?B?TG91QlYxaUZ5dWNCV2I1WGpETXFMOVVhcUNHZkxhM0RIc3RHNUtDNFRpNTdF?=
 =?utf-8?B?NHFPVGcwTmNib28xWFVicWcyc3lhdHEwZVlzS0FpR01GekpYSWlCWnVYMzVT?=
 =?utf-8?B?WFpoQkxVL1ZlQ3VnMlVYME1NUm9jelZFakQzTjFaQnppbzU1QzFFdzBSc0VD?=
 =?utf-8?B?K3lJVTdhRjhuVytKOEFOK3lZUlJDK0xpSEtxbGV5OWdEcmxSeU5rMkdXVk5U?=
 =?utf-8?B?UVBxdENxcVJQaTU1R0VXS0NkZ01MODA1ODVGZUpFWWc3SkMzcmpQelJ1R01E?=
 =?utf-8?B?MWNZY0d3aisrQlV1VGZuRGFBME9KeWlGREp6ZExOcDR4b0RwQk1uRWVKbExY?=
 =?utf-8?B?UjhFRDZHNFBhZkNndjRyQWRkam1XaCtmSHF1bHI2TFRxL2ZjWm9odXVMWGM2?=
 =?utf-8?B?KzNmZlVtbDZxdWNDdjBjbTEzaThsYmxPblNqVm15OCtMY2JUNFA3d1ZMRXF2?=
 =?utf-8?B?OVJkcU9sNXpYbVZ3eVUzVDhDWjNKQjRGQlY5YkRNZ0t4UGRSZjhYOWJGdGhr?=
 =?utf-8?B?U2RhMjJDRU9qcitCbnJuWTA3c0VJbGNqQWEwOXlwcjhtcVlQanBwS0t2NnBI?=
 =?utf-8?B?K0xId2FvMVJldVFZZHRSbUp6bTg1L1NXVnpWdkEyZitUN2xKMHJLNHNTNTJ6?=
 =?utf-8?B?MXBxUlBJS1ZiZHV4V0h6b3BFQnZrMkNzeXVVVlNCcTNiTGhuK1FCU3ZvQXZl?=
 =?utf-8?B?aUJjV1JINFNuZDZ2M2hMR3gvaXRWazdLUU9ac3M3VE44OEZTRmhXZGFad3JV?=
 =?utf-8?Q?I+9HL1Q3sYb9oZSkPtgICQ+R9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9065ad43-f3b4-4f37-8ff7-08daad34c63c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 16:05:40.4608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g47bfFSfdNjTkQvHNLSYeGlvxdHIzF2cCeJHBNRKbUpg/ubwVgifccRV/hhrdxZFb+QpNRdn5ScDnikKLCAIMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7655


On 13/10/2022 16:38, Julien Grall wrote:
> Hi,
Hi Julien,
>
> On 13/10/2022 16:13, Ayan Kumar Halder wrote:
>>
>> On 13/10/2022 15:47, Julien Grall wrote:
>>>> .Thus, the guest need to invoke sys_read32() twice (GICR_TYPER and 
>>>> GICR_TYPER+4).
>>>
>>> I don't understand how you came to this conclusion with what you wrote. 
>>
>> Sorry for confusion. I was trying to explain that the code does not 
>> handle 32 bit access of GICR_TYPER on arm32.
>>
>>
>>> If we had implemented vreg_reg64_extract(), then Zephyr would still 
>>> need to issue two 32-bit read because Xen doesn't emulate 'ldrd'.
>>
>> Yes. So what we need here is not the implementation of 
>> vreg_reg64_extract() for GICR_TYPER.
> Why not? Your GICR_TYPER is a 64-bit and the helper is the right way 
> to hide whether the low/high 32-bit are accessed.

When Zephyr issues 32 bit reads for GICR_TYPER for GICR_TYPER + 4, it 
traps to Xen two times.

So, my understanding is that Xen needs to read two 32 bit values.

We can modify the vreg_reg64_extract() so that it can return the lower 
32 bits in one case and upper 32 bits in the second case.

Is this what you are suggesting ?

- Ayan

>
>>
>> Zephyr will issue two 32 bit read access for GICR_TYPER and 
>> (GICR_TYPER + 4). So Xen needs to emulate 32 bit read for GICR_TYPER 
>> and GICR_TYPER + 4.
>>
>> So, we will need to modify the Xen code as follows :-
>>
>> |#ifdef AARCH32 case VREG32(GICR_TYPER_L32) : { read and return lower 
>> 32 bits of GICR_TYPER return 1; } case VREG32(GICR_TYPER_H32) : { 
>> read and return the upper 32 bits of GICR_TYPER return 1; } #else /* 
>> For AARCH64 */ case VREG64(GICR_TYPER): { do as existing; } #endif 
>> Let me know if this looks sane. I can then submit a single patch to 
>> add support for this. |
>
> This is a bit difficult to read. So I looked at your answer on the 
> Zephyr thread.
>
> You will end up to duplicate code for emulating TYPER and there are 
> quite a few other use of vreg_reg64_extract() in the code.
>
> So I am afraid this is not an option for me. If you implement 
> vreg_reg64_* then you will not need to implement.
>
> I would be open to other suggestion so long we don't end up with 
> duplication or any other kind of open-coding.
>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 16:06:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 16:06:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422316.668263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0jK-0000wS-AQ; Thu, 13 Oct 2022 16:06:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422316.668263; Thu, 13 Oct 2022 16:06:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj0jK-0000wL-7M; Thu, 13 Oct 2022 16:06:42 +0000
Received: by outflank-mailman (input) for mailman id 422316;
 Thu, 13 Oct 2022 16:06:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0jI-0000w7-HB; Thu, 13 Oct 2022 16:06:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0jI-0003C6-Cp; Thu, 13 Oct 2022 16:06:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0jH-0005jT-Qw; Thu, 13 Oct 2022 16:06:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj0jH-0001su-QR; Thu, 13 Oct 2022 16:06:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A9zjKdZ8sf6QZ+X6S9n2NTzh19VF1sP46y1g1ubU6GE=; b=1wPf89MqZ0CYXrRa/waQKYuEju
	5eHCMa0QtCLfX4baV0HrnnJd51OV4CMk/ZJ4o+laY36FKYnaBzcIBoBOZQFLUP/ciNY0dnGE5GjXy
	0WLYDrLZSoS/CHOTWV5xM4ae0rWBO/CLuLOI/O1Ks4FaaKpPrZ4z07gquZ5xQszGvPrs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173620-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173620: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-raw:xen-install:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=ab44ea1059242ff2dbbde44e94468f6c6e5f87be
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 16:06:39 +0000

flight 173620 qemu-mainline real [real]
flight 173717 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173620/
http://logs.test-lab.xenproject.org/osstest/logs/173717/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-libvirt-raw   7 xen-install              fail REGR. vs. 173447

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                ab44ea1059242ff2dbbde44e94468f6c6e5f87be
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z    7 days
Failing since        173497  2022-10-11 15:38:33 Z    2 days    3 attempts
Testing same since   173620  2022-10-12 20:10:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  David Hildenbrand <david@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit ab44ea1059242ff2dbbde44e94468f6c6e5f87be
Merge: 42e1e350bf fde10960ed
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Tue Oct 11 15:31:27 2022 -0400

    Merge tag 'pull-testing-gdbstub-plugins-gitdm-111022-1' of https://github.com/stsquad/qemu into staging
    
    testing:
    
      - revert patch to stop always building pc-bios roms
    
    # -----BEGIN PGP SIGNATURE-----
    #
    # iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmNFw8YACgkQ+9DbCVqe
    # KkT40wf+JTJSu9yashD38isN26LtW/Ie7+D0lhBCpmHlQy256Qumc4kaMotC6da5
    # iU58rfDzN6EUjfbZSPfbLQTVnmH6om5/ejJoEWZIeoYtcgBHdzHYGpHxOf68r/BA
    # 1y5GlahyG0rtR80J9vjAIqlQswBgklZIomqQj2VyAy3I7fFcYKIW14FyY6by/cZU
    # b7YVn8esZ/+6q6KirrX/zksf04uek8twoOZ4oBRNW1aeApvs73NUXmIXd1IidlgW
    # qxDOCm2IGZ1skRoaWH8kOjsYXfE/w4DFt+vOAKmSHnnYLAEYjfA+J4TUfoqmaOQ1
    # LhEm/v0rDvteX8hEErBvXAsXdm3HqA==
    # =ux3j
    # -----END PGP SIGNATURE-----
    # gpg: Signature made Tue 11 Oct 2022 15:28:06 EDT
    # gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
    # gpg: Good signature from "Alex Bennée (Master Work Key) <alex.bennee@linaro.org>" [unknown]
    # gpg: WARNING: This key is not certified with a trusted signature!
    # gpg:          There is no indication that the signature belongs to the owner.
    # Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44
    
    * tag 'pull-testing-gdbstub-plugins-gitdm-111022-1' of https://github.com/stsquad/qemu:
      Revert "configure: build ROMs with container-based cross compilers"
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

commit fde10960ed6a6435d89315d4fd3af9d0b51aebb6
Author: Alex Bennée <alex.bennee@linaro.org>
Date:   Tue Oct 11 12:34:16 2022 +0100

    Revert "configure: build ROMs with container-based cross compilers"
    
    This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f.
    
    Unconditionally building all the bios for all arches was a little too
    far too fast.
    
    Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
    Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
    Message-Id: <20221011113417.794841-4-alex.bennee@linaro.org>

commit 42e1e350bffc8d4614e568a03380b2ec34a131bf
Merge: f1d33f55c4 94d788408d
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Tue Oct 11 09:31:19 2022 -0400

    Merge tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging
    
    dump patches
    
    Hi
    
    Includes:
    - the first patches from "[PATCH v5 00/18] dump: Add arch section and s390x PV dump"
    - "[PATCH v2 0/2] Fix dumping in kdump format with non-aligned memory"
    
    # -----BEGIN PGP SIGNATURE-----
    #
    # iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmM+9UocHG1hcmNhbmRy
    # ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5aoMD/0eya5IqxX0ke9jjUcB
    # wWhRbsVdiO9yt2oN3gsQVkUtuK98p7/JpWSKHWXsQQjd7vIYPCj8RBHXZ4Cp71+S
    # n+Db/K22fmWvuP0LtCNzYujq1ZxKdQI8KdKmYwHQdGkgy85QwYO+0SgpVgLjRd/2
    # 1IWzHuzIcEmraxkSLvR8N0lmz/Z2CBc7ME5izO1mHSZrs8Ria2tDpXnz5rFxPy+q
    # TDqo+LP0GIapoHbbE+6JWGL2u9mLiP0sg9SclZOPZG3CsPQ5XYEStyZcLw1YYIO1
    # rruom463SbP4NJHIRspC8pADFI+d4uBamj/eUu8/9CUVqetk0UpKyXWiqgEDvmkO
    # /2/yFYS60gEghvd3XVnuZnTNeRSDSE1aUXUmKdGqDjYL4DYcsehIQ9z8ut/tuYIO
    # D+4RuiuCmEyznV/DDecnwHhrv9jWftNwdwjW5GAniEjDBp/DtoouAeMArQw9rE1Z
    # mXqTa5NaeW69VTtzxzN25GzSAjiEzFT7UFRt3bT8fb0NX+UOkluD/agBqRIM5lzh
    # KbUJjqWhqA6TnHtDekbNLlmocDCn+NeBeXxDUIa19C4LICCuuxbFU+MG7cvdjSEg
    # sXRB6/qAdWgv4O3zGw1SHff+qmvtHjKVj0ihrNkrrYrL+31O2splqTMeaCqGdq9C
    # elE/TAS46CcMUSYuWzxy6mAMmA==
    # =O9tr
    # -----END PGP SIGNATURE-----
    # gpg: Signature made Thu 06 Oct 2022 11:33:30 EDT
    # gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
    # gpg:                issuer "marcandre.lureau@redhat.com"
    # gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" [full]
    # gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" [full]
    # Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5
    
    * tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu:
      dump: fix kdump to work over non-aligned blocks
      dump: simplify a bit kdump get_next_page()
      dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note
      dump: Split elf header functions into prepare and write
      dump: Rework dump_calculate_size function
      dump: Rework filter area variables
      dump: Rework get_start_block
      dump: Refactor dump_iterate and introduce dump_filter_memblock_*()
      dump: Rename write_elf_loads to write_elf_phdr_loads
      dump: Replace opaque DumpState pointer with a typed one
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

commit 94d788408d2d5a6474c99b2c9cf06913b9db7c58
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Mon Sep 5 16:06:21 2022 +0400

    dump: fix kdump to work over non-aligned blocks
    
    Rewrite get_next_page() to work over non-aligned blocks. When it
    encounters non aligned addresses, it will try to fill a page provided by
    the caller.
    
    This solves a kdump crash with "tpm-crb-cmd" RAM memory region,
    qemu-kvm: ../dump/dump.c:1162: _Bool get_next_page(GuestPhysBlock **,
    uint64_t *, uint8_t **, DumpState *): Assertion `(block->target_start &
    ~target_page_mask) == 0' failed.
    
    because:
    guest_phys_block_add_section: target_start=00000000fed40080 target_end=00000000fed41000: added (count: 4)
    
    Fixes:
    https://bugzilla.redhat.com/show_bug.cgi?id=2120480
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Acked-by: David Hildenbrand <david@redhat.com>

commit 08df343874fcddd260021a04ce3c5a34f2c48164
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date:   Thu Aug 25 12:40:12 2022 +0400

    dump: simplify a bit kdump get_next_page()
    
    This should be functionally equivalent, but slightly easier to read,
    with simplified paths and checks at the end of the function.
    
    The following patch is a major rewrite to get rid of the assert().
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: David Hildenbrand <david@redhat.com>

commit 2341a94d3a0a8a93a5a977e642da1807b8edaab8
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:11:01 2022 +0000

    dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note
    
    The functions in question do not actually write to the file descriptor
    they set up a buffer which is later written to the fd.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-9-frankja@linux.ibm.com>

commit 670e76998a61ca171200fcded3865b294a2d1243
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:11:00 2022 +0000

    dump: Split elf header functions into prepare and write
    
    Let's split the write from the modification of the elf header so we
    can consolidate the write of the data in one function.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-8-frankja@linux.ibm.com>

commit c370d5300f9ac1f90f8158082d22262b904fe30e
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:59 2022 +0000

    dump: Rework dump_calculate_size function
    
    dump_calculate_size() sums up all the sizes of the guest memory
    blocks. Since we already have a function that calculates the size of a
    single memory block (dump_get_memblock_size()) we can simply iterate
    over the blocks and use the function instead of calculating the size
    ourselves.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Message-Id: <20220811121111.9878-7-frankja@linux.ibm.com>

commit dddf725f70bfe7f5adb41fa31dbd06e767271bda
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:58 2022 +0000

    dump: Rework filter area variables
    
    While the DumpState begin and length variables directly mirror the API
    variable names they are not very descriptive. So let's add a
    "filter_area_" prefix and make has_filter a function checking length > 0.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-6-frankja@linux.ibm.com>

commit 0c2994ac9009577b967529ce18e269da5b280351
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:57 2022 +0000

    dump: Rework get_start_block
    
    get_start_block() returns the start address of the first memory block
    or -1.
    
    With the GuestPhysBlock iterator conversion we don't need to set the
    start address and can therefore remove that code and the "start"
    DumpState struct member. The only functionality left is the validation
    of the start block so it only makes sense to re-name the function to
    validate_start_block()
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Message-Id: <20220811121111.9878-5-frankja@linux.ibm.com>

commit 1e8113032f5b1efc5da66382470ce4809c76f8f2
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:56 2022 +0000

    dump: Refactor dump_iterate and introduce dump_filter_memblock_*()
    
    The iteration over the memblocks in dump_iterate() is hard to
    understand so it's about time to clean it up. Instead of manually
    grabbing the next memblock we can use QTAILQ_FOREACH to iterate over
    all memblocks.
    
    Additionally we move the calculation of the offset and length out by
    introducing and using the dump_filter_memblock_*() functions. These
    functions will later be used to cleanup other parts of dump.c.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-4-frankja@linux.ibm.com>

commit afae6056ea79e2d89fd90867de3a01732eae724f
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:55 2022 +0000

    dump: Rename write_elf_loads to write_elf_phdr_loads
    
    Let's make it a bit clearer that we write the program headers of the
    PT_LOAD type.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
    Reviewed-by: Steffen Eiden <seiden@ibm.linux.com>
    Message-Id: <20220811121111.9878-3-frankja@linux.ibm.com>

commit 1af0006ab959864dfa2f59e9136c5fb93000b61f
Author: Janosch Frank <frankja@linux.ibm.com>
Date:   Thu Aug 11 12:10:54 2022 +0000

    dump: Replace opaque DumpState pointer with a typed one
    
    It's always better to convey the type of a pointer if at all
    possible. So let's add the DumpState typedef to typedefs.h and move
    the dump note functions from the opaque pointers to DumpState
    pointers.
    
    Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
    CC: Peter Maydell <peter.maydell@linaro.org>
    CC: Cédric Le Goater <clg@kaod.org>
    CC: Daniel Henrique Barboza <danielhb413@gmail.com>
    CC: David Gibson <david@gibson.dropbear.id.au>
    CC: Greg Kurz <groug@kaod.org>
    CC: Palmer Dabbelt <palmer@dabbelt.com>
    CC: Alistair Francis <alistair.francis@wdc.com>
    CC: Bin Meng <bin.meng@windriver.com>
    CC: Cornelia Huck <cohuck@redhat.com>
    CC: Thomas Huth <thuth@redhat.com>
    CC: Richard Henderson <richard.henderson@linaro.org>
    CC: David Hildenbrand <david@redhat.com>
    Acked-by: Daniel Henrique Barboza <danielhb413@gmail.com>
    Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <20220811121111.9878-2-frankja@linux.ibm.com>


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 16:24:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 16:24:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422328.668276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj102-0003WQ-0k; Thu, 13 Oct 2022 16:23:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422328.668276; Thu, 13 Oct 2022 16:23:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj101-0003WJ-UC; Thu, 13 Oct 2022 16:23:57 +0000
Received: by outflank-mailman (input) for mailman id 422328;
 Thu, 13 Oct 2022 16:23:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oj100-0003WD-AD
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 16:23:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oj0zy-0003VM-Oh; Thu, 13 Oct 2022 16:23:54 +0000
Received: from [15.248.2.148] (helo=[10.24.69.5])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oj0zy-0000Z6-Ht; Thu, 13 Oct 2022 16:23:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=FPpnaVvAN4PsmzhJaH2gc9mOOkm9k6x3hCsQuhZuV4Y=; b=q63MFJBTsvccRJeKibxbNGUyVq
	cw+BMc50le8f1UE0N3zTzWQM6N3GAe90k/sIOK4GGlTP+uz0fiQhnhlZb65rRxhJr97ht8jlB+2Y5
	9z2mht96tk9gPq5cp/xLUHo1BVOwhcFGx8+OV77ZuhgKen5XOgAio2iEScTb0utmrpBI=;
Message-ID: <053a8892-b6c2-8518-94f5-cc6487a88ca2@xen.org>
Date: Thu, 13 Oct 2022 17:23:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
To: Ayan Kumar Halder <ayankuma@amd.com>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>
Cc: Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <9b4a9bbf-eb5c-3d13-f796-c6bf5704d85b@xen.org>
 <e94b7c65-1c38-024f-6a91-16098045574a@amd.com>
 <96f989d9-4d55-acc9-a0f7-cbb1212480ad@xen.org>
 <28a406b7-0b9d-3c4b-4db4-67af6729e35f@amd.com>
 <28525ef4-4ecf-e55f-682c-93eeffbc09b5@xen.org>
 <8fda8e62-bc95-0506-da67-ddef0b1f73f6@amd.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <8fda8e62-bc95-0506-da67-ddef0b1f73f6@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 13/10/2022 17:05, Ayan Kumar Halder wrote:
> 
> On 13/10/2022 16:38, Julien Grall wrote:
>> Hi,
> Hi Julien,
>>
>> On 13/10/2022 16:13, Ayan Kumar Halder wrote:
>>>
>>> On 13/10/2022 15:47, Julien Grall wrote:
>>>>> .Thus, the guest need to invoke sys_read32() twice (GICR_TYPER and 
>>>>> GICR_TYPER+4).
>>>>
>>>> I don't understand how you came to this conclusion with what you wrote. 
>>>
>>> Sorry for confusion. I was trying to explain that the code does not 
>>> handle 32 bit access of GICR_TYPER on arm32.
>>>
>>>
>>>> If we had implemented vreg_reg64_extract(), then Zephyr would still 
>>>> need to issue two 32-bit read because Xen doesn't emulate 'ldrd'.
>>>
>>> Yes. So what we need here is not the implementation of 
>>> vreg_reg64_extract() for GICR_TYPER.
>> Why not? Your GICR_TYPER is a 64-bit and the helper is the right way 
>> to hide whether the low/high 32-bit are accessed.
> 
> When Zephyr issues 32 bit reads for GICR_TYPER for GICR_TYPER + 4, it 
> traps to Xen two times.
> 
> So, my understanding is that Xen needs to read two 32 bit values.
> 
> We can modify the vreg_reg64_extract() so that it can return the lower 
> 32 bits in one case and upper 32 bits in the second case.
> 
> Is this what you are suggesting ?

Well... The helper is already doing that. It was introduced to support 
32-bit guest using GICv3 on 64-bit Xen.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 16:55:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 16:55:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422337.668294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj1UO-00077X-H3; Thu, 13 Oct 2022 16:55:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422337.668294; Thu, 13 Oct 2022 16:55:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj1UO-00077Q-DP; Thu, 13 Oct 2022 16:55:20 +0000
Received: by outflank-mailman (input) for mailman id 422337;
 Thu, 13 Oct 2022 16:55:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1UN-00077G-CC; Thu, 13 Oct 2022 16:55:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1UN-00041x-1F; Thu, 13 Oct 2022 16:55:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1UM-0008Jn-GU; Thu, 13 Oct 2022 16:55:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1UM-0000p0-Fn; Thu, 13 Oct 2022 16:55:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0SbdMmmBqCo3ezlQ2782bPHIPp5CL5JznjnVMjJJsTw=; b=kLkK2If3EZFDG2WyoGxBflzKhz
	HhTbiyf/X/Vx+vZWhJz/vm4HGBCun1Vfshbfq0cbZN7EasyApMYNsVFCTjbZ3jHQGgh3UDOiNhXfQ
	U7qr2cjeSvPvwnBIW9xzxlKOX9NdOIUyPPKvk9r/hZnacKXloB5Zg0hQOpIKG05j9tbc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173650-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173650: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:regression
    xen-4.14-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 16:55:18 +0000

flight 173650 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173650/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-amd64-i386-migrupgrade  10 xen-install/src_host     fail REGR. vs. 172550
 test-amd64-i386-migrupgrade  11 xen-install/dst_host     fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   59 days
Failing since        173496  2022-10-11 14:08:01 Z    2 days    4 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 17:19:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 17:19:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422348.668304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj1rY-0001JQ-Ff; Thu, 13 Oct 2022 17:19:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422348.668304; Thu, 13 Oct 2022 17:19:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj1rY-0001JJ-D2; Thu, 13 Oct 2022 17:19:16 +0000
Received: by outflank-mailman (input) for mailman id 422348;
 Thu, 13 Oct 2022 17:19:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1rX-0001J9-Q2; Thu, 13 Oct 2022 17:19:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1rX-0004Yc-OD; Thu, 13 Oct 2022 17:19:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1rX-0000r3-Df; Thu, 13 Oct 2022 17:19:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj1rX-0008To-D9; Thu, 13 Oct 2022 17:19:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t/ZUXEYBL5nxLqyt9CN08emTkzf+ggv8G4jKlFeae+4=; b=rffWMXNdvQbIaSf/Si887lybC6
	yJK6nym/+jJRJInKLZLtxQLa+l9Qq2WXHNMJrs4jBJiROxdPwq414B8hOCSoxco+lM1xYV7PDRjKS
	/j+UeT64rymEs/zq7ptLL/d4bW059Ua0QTNDhaOF0kTLNIjzbx9Ka78dTN/y4YkOU2hQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173679-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173679: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=5bd2dbc6982734132debd8311a417f5a51daa644
X-Osstest-Versions-That:
    ovmf=e7d7f02c8e157e936855a091948757f78c7d0298
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 17:19:15 +0000

flight 173679 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173679/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 5bd2dbc6982734132debd8311a417f5a51daa644
baseline version:
 ovmf                 e7d7f02c8e157e936855a091948757f78c7d0298

Last test of basis   173614  2022-10-12 17:40:37 Z    0 days
Testing same since   173679  2022-10-13 05:20:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gua Guo <gua.guo@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e7d7f02c8e..5bd2dbc698  5bd2dbc6982734132debd8311a417f5a51daa644 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 18:03:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 18:03:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422358.668321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj2Xx-0006iz-Px; Thu, 13 Oct 2022 18:03:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422358.668321; Thu, 13 Oct 2022 18:03:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj2Xx-0006is-MV; Thu, 13 Oct 2022 18:03:05 +0000
Received: by outflank-mailman (input) for mailman id 422358;
 Thu, 13 Oct 2022 18:03:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xhTA=2O=citrix.com=prvs=278783dfc=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oj2Xw-0006im-LE
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 18:03:04 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 44c42913-4b21-11ed-8fd0-01056ac49cbb;
 Thu, 13 Oct 2022 20:03:01 +0200 (CEST)
Received: from mail-bn8nam04lp2047.outbound.protection.outlook.com (HELO
 NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 13 Oct 2022 14:02:44 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DS7PR03MB5623.namprd03.prod.outlook.com (2603:10b6:5:2cf::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct
 2022 18:02:37 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 18:02:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44c42913-4b21-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665684182;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=4pUbOcAIP7fshJ+9IZXMnaZaYwUzC/2SnfYUgMXbHmc=;
  b=fDFJdUw30au/4xIbzr+tLeN46uwURLkW7eLnWV32tIkkXpe+K9aORyOO
   fmYK/4OXmW/mNXqv7MFhUQZLmdOmsE5wahOWTgabkTO583T/6UDLdfXKI
   WXyx/wwWBdufiQz2oyf7XSSWpaO4db8nnqCqiKIsIOuIMkhv+h5Mg6T0h
   Y=;
X-IronPort-RemoteIP: 104.47.74.47
X-IronPort-MID: 85208381
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:2D3DBKpWUIBAnOhqbDWiAKayx+teBmIKZBIvgKrLsJaIsI4StFCzt
 garIBmPb/qIM2D0fdt0b97noE9UusTdmoJgGQc6qSpkQSJH9JuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgS5weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m/
 tgDFhsSUSy5h/OKh4DqFLMwnc0pFZy+VG8fkikIITDxK98DGcyGaYOaoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MkEotj9ABM/KMEjCObexTklyVu
 STt+GPhDwtBHNee1SCE4jSngeqncSbTCN9ITO3jpqcCbFu7+zUZIyYQcGuCvMKlkRSve/1hJ
 kcE9X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k
 GCAmdzBDCZq9raSTBqgGqy8qDqzPW0fKz8EbCpcEQ8duYG//8c0kw7FSctlHOitlNrpFDrsw
 jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm
IronPort-HdrOrdr: A9a23:jQDPda67NRrIBobjiwPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.95,182,1661832000"; 
   d="scan'208";a="85208381"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JKEq5K2F50HKVdob4llxP1660bhKj9isnRRwQXiFCLOkpWwO2BE89WJVOL/DnS2YB5I9ByS5Pktmr0ErrcNAl4Me4Cka/MnMtpg54f4qua4blZFFeeOvPFqg3kfiOYCSgNbyBpFKr4wDBUCe6ozCJX6Tf5e8stew3kkbA0akLNZR94I1FvikfX2w3bYlsJTkzD1d9bmmksN2U/xb9gydSDokSCqA9lQUogLkGb9oFH1AOkTh5mExI5rjHS+XagT98xRkmjkUjmXku+9nvnqwd/Di7tn5F5b9jLkzhqIQm8X5jqNQuW6O7lVUbHqLfYI18pfBA4f5X5RAgl8XvPABqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4pUbOcAIP7fshJ+9IZXMnaZaYwUzC/2SnfYUgMXbHmc=;
 b=e3QmtQmPSDzUESBgbmfbBfmC4VaOUITa/tWSAn0IyAfzv6/5sC9oV6YBOv0ZAYbDFCFkLhcmjGudXxI87iXtCSVMEdiynluyzAeoCVC7ypLYSt1mS/8xnyj4qBHHQ/1gOvyWMAq2H7U6Rrxh9jxav7uP0Jha7ijIylHTwpxwMFkl7oswVaH4tUXz92bgybXY72N80P1weG18rwnYyfdEfMVGBjW5Ro7tQGQ7u3I9dA9Kg4UK6vRsi+jeMrYDwElXbv6NhPAyr/+OompIxgicbfuF9fhvIvjwN9sP3gmHAhREIpHMfRFPXJcu1QA8SjmLgT640ESyTg4ofobTZx5Wig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4pUbOcAIP7fshJ+9IZXMnaZaYwUzC/2SnfYUgMXbHmc=;
 b=w9zJwbawvcD3w9KnHYWygqrNZXOzoNYxirwKMku/xLfGrTQ34pYD59942e6GHHXjRfpH0N31+FUKm5bbAkCL55FQEvo6dZ9dwB0K1qB/kasjYtrMVaQpEhYz6QqBLmNCZY0EGUfR6xGWo4Ht115Zb5oKT6zQIndQMG//gNpj4vw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Henry Wang <Henry.Wang@arm.com>
Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement,
 toward non-recursive makefiles
Thread-Topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Thread-Index: AQHY3wR19l5fPoXHX0uqLO79kk12za4MneoA
Date: Thu, 13 Oct 2022 18:02:37 +0000
Message-ID: <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5623:EE_
x-ms-office365-filtering-correlation-id: ee30d404-9a94-4fc8-2454-08daad451cc4
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 nVvQALgPOjBTKwwyQGMELT4YrSldLLY6MeZCx9v9sSxTbAi8UpmiAAvOoD0ak+AfL29VjtnRmOr2GltH+iJhzvadHjG3ovpMHeVarIZbDi58x6pUf1eQXJ7tO0C/8wndHJObSebDaSVV5MtZQ9wJDaozW//mf/wq470DNDMSNtl9EeD5avp6qWermaxGl9PiMvVx2ZwawMtBN8gefowh4v4Xa6EVSZX4sOprOhdiOilKdGCH5yWRMBxuF89WAQJdcy4/NpY712uWdEyaG5bnNqFs4GHuLe01NdiRymqh2xUdoa4r5oVAEMU69euGz4YQfvQBepNbsA30ZvsZQ4JVXekF5TC03qll5biHwuFgv7mk+PI0tb+bnYC670/8dTo700StbukmC1ByKRMntc9yyxvSgI2HarwcnK36t3ry+bxHWZ3fjcjU9MyAcdUp5Yyr0FcPiHsoq2ptsKyPQJZY3XaBhkERz2sRiJUKAlvta7F9zsHJczj2x4RXTvWGMXwT+38Lc8LlNAfO7bVbv4CR/AmAnSi5kwQ2p7W1+v7puk0+haRVNL16dIWkhvdQ+y3rF/xggp5pogCjPEfqNujVZZDOiBreIde6jB/imgbfn0bvN2zADxLCVxC6a1kaV9ZRDHSoDqwq4CxSwkJ8BJ6cbLkxDNDx4je6nv50PjJorkk+oX/jhdFblPpF3ooUxNj3QZGqa2jvxjojuW6wBLVz2kkkOXSFma0ZpmpkOlTlowydDewma243xXWTo8cTj2gUSx0n3F7KcE7LNJWLxPdmFoK/7s6xzOKTdiTl/OFJUlEFfCEUQwbPXB6xtwzFECmIKUwYhbabFUxZuScbfbO+GOXtkobCDA2JElVK9FpDVn8=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199015)(31686004)(36756003)(83380400001)(6506007)(6486002)(26005)(6512007)(186003)(122000001)(2616005)(53546011)(82960400001)(2906002)(478600001)(110136005)(66946007)(76116006)(66556008)(38100700002)(966005)(41300700001)(4326008)(38070700005)(4744005)(31696002)(66476007)(86362001)(66446008)(91956017)(8936002)(71200400001)(316002)(5660300002)(64756008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?OGpyRUZKQ2JSWmxsRlNiK2ovdE43SCtjSHJBZ0k5L1BnaDNGY1JuUU1CTXBa?=
 =?utf-8?B?SmowWGhSZlNrQ0FTMldXS1NCbUlDWjdSOXZnV0NIcXZwcm9LTFlaOFNucWNU?=
 =?utf-8?B?dS84Wlc0djZnTUlnTzFOZlJvcHVvU2FNRTE1b3R1eC9YcFd4Wmo1anZ3UXdE?=
 =?utf-8?B?WC8yT1hQMk9ER2FEb0gyc3VQdjhPVG5EdFBNRGpzSVNaOEhKQUJTZHZsK1Nx?=
 =?utf-8?B?UFBkNy90SGVOU0NEVnJKdU8yeGtDWWRtZ2lZQ1F4YlM3ZEtjczBCaVM3MVhC?=
 =?utf-8?B?UWE2Ulg0Qzd6VXVlN1hpZWJHNlp5RkMwR2NhRXNGWTJzSDZ6OUpUZmVTVmNQ?=
 =?utf-8?B?M20vUlpWQWwrWU1IN1h4b1Mrclh1cGdFaG1GbTUzb3hIVm5MeG8vKzFhQVNo?=
 =?utf-8?B?VEpQc2dJRzBGNmlITTEzSjVEdFNYRDcyK1RyT1dLTmc5Q3dPRVFGbHpWM1g5?=
 =?utf-8?B?QUtxNHVmemdlZXBxdFVIQWswbVRveVppZHpJa1ZRQUlRS3hVeFM5aURlWUo2?=
 =?utf-8?B?Z0JvRVliTy9LZXVaYXhCc3Jub3BTY0RCR1lJRHJZSC9seWI5U0dWcnVkZnp1?=
 =?utf-8?B?RDAwV2FZWkw1eDdOb3dka2M5ZG9SNXdBY2VXMW5mb2M3anVtbTlEWEFBSnhT?=
 =?utf-8?B?b2Eyd2E2cHo0Sk82b214TzlYcmo0YkxMQjNPcE4wTHBHYWhyTmc1eGl6Z3JF?=
 =?utf-8?B?NXBhMTNhcllGN1Z6L0l1dnNNdyt6dGNteFV6R2RaUE1tbFZOWTl3SmQxbmFI?=
 =?utf-8?B?U3hRRUxaalNjcTMxc1IwRStrbWRWMENsSDdqS3VYcFlZNEJVWENkdzRSbG9S?=
 =?utf-8?B?Nm9WM0tNRHNQWUFRQ2taUVhNSGJ1cWVsV1hoK1Rnb05JVys4RkdmK2RuWGxV?=
 =?utf-8?B?dXlEMzJycTNYWTZoekwxakxrU2Y3YzREYzlDZi8vazY1dURSNEhhejVKak41?=
 =?utf-8?B?RGZCZEhrMEhBT3ZQVUlHb2hrTytCNU9qRXpoQXhuUnRqNVNMNXc0UzltTm1H?=
 =?utf-8?B?cVJXNWwybS85SzNFcEc3ZWVEVVNxNFYyMlFPc0dsU2R2a1lRSmJ4UHJtOEVL?=
 =?utf-8?B?d2hmdENrcGd3RWVLTkZBWW9KaUsySUZjNEJlcTVRS1BQQ3RIekM3eitrRlo1?=
 =?utf-8?B?NW5SVjlsOHF2MkY2bE85aDZIOHdoODhiSVVIMlljdWx2bjJ5eTZwYjlESlBS?=
 =?utf-8?B?Y3RJNWlkY01vditrTEQ0NUVsUkNwQ2pQN2FzSGpGaUFZSmU1cFJNVUl6R2Z3?=
 =?utf-8?B?Q0RyTHNPTFBudmhkdzAySTJpUzBRcTRPaFErWXBHWHFpRW9rTGZOVXowTWRF?=
 =?utf-8?B?bzJKU3R6VElObHdIVXhUc1dYMEU1YWY1a3pyOFBsSEdOVkVTNkxhb01xZkFy?=
 =?utf-8?B?Q2pNT2VOb0R1UGdNMDAwVFVNc3JWSlJPT09IRlBYblJWU0RRWUpvQUdZU1Zz?=
 =?utf-8?B?ck92Y2VmRSs5UFgxQ1lLNUl0R0c3WVducW9wYS8wZlNxanhHSjNubFlRckJS?=
 =?utf-8?B?WThLc0JQSkJYZHZWaHBjemYvczBsUS9KVXlxNEtwZ1FCMng4VUpXUTJJeTh5?=
 =?utf-8?B?TTFmdm5CRjFveE5HRldBSTV2MG4zYng5SmROZTl5d2x6azhrMndNZlVGVTVn?=
 =?utf-8?B?dTcwdlYrTUlLY2xvVlc5aUdkMW9PZGlsR0FVYzhKdm5RMXZBRHJoMCtCVHZs?=
 =?utf-8?B?UHQvb2xZTVZ4cXNrSjY2bjU3MlAxSGprWGIwZy9aQWxzODJHdmZ4cy9uency?=
 =?utf-8?B?cVFUN2lNZ0tBM0U5V204OGhNLy9URGhjZGVqT1RiRWtNZCs0SHF3cjd1clRM?=
 =?utf-8?B?MGdvTVlLOGJWeDIzKzErSXFZekZ4K3BTTm42K0pQWmh0dGpsOTg5OFBad0pL?=
 =?utf-8?B?NVJsOEhBQkdmNE1IYitrZUZiaW5qMFB4M29lUlhBeGRlTHdVaGZRWGcvQTRm?=
 =?utf-8?B?dHJFOE1Hd1VwMUVYQTJHMDMrck56MXlIL0ZYdjRua2xKcURpc3lESXFrQXIz?=
 =?utf-8?B?L0huRlFsdW5kYkVEcXZabUV6ejZzQk50aG5RdVhsaS95dkFUeC9YUm40d1No?=
 =?utf-8?B?aUc5elNLYndET29wOXh1eGRxaUY4TTBZelp0MzFaalJtVHdjRzZ2ZTAxQ0xW?=
 =?utf-8?Q?9OU3oXLj37helyzVDluBDGaK6?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4F9F22E6CE3AA14C88398E47F85CDA6A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee30d404-9a94-4fc8-2454-08daad451cc4
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 18:02:37.3155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c51vPWsQG9kRIAIEv70zXn1+1tAYPN5gaKw5PAVhOJl+ljkZ2AAlEan3twUKtEA0Uni3lm+4dPYSUc9eaD74119xHS1ET31xmBc7PJD7O0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5623

T24gMTMvMTAvMjAyMiAxNDowNCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IFBhdGNoIHNlcmll
cyBhdmFpbGFibGUgaW4gdGhpcyBnaXQgYnJhbmNoOg0KPiBodHRwczovL3hlbmJpdHMueGVuLm9y
Zy9naXQtaHR0cC9wZW9wbGUvYXBlcmFyZC94ZW4tdW5zdGFibGUuZ2l0IGJyLnRvb2xzdGFjay1i
dWlsZC1zeXN0ZW0tdjUNCg0KSSd2ZSBkb25lIGEgZnVsbCByZWJ1aWxkIG9mIHRoaXMgKHdpdGgg
dGhlIDIgbm90ZWQgZml4ZXMpIHdpdGggWGFwaSwgYW5kDQppdCBkb2VzIHJlc29sdmUgdGhlIE9j
YW1sIGxpYnJhcnkgbGlua2luZyBpc3N1ZXMuwqAgVGhhbmtzLg0KDQpTbyBULWJ5LsKgIElmIGFu
IGFsbG93YW5jZSBmb3IgNC4xNyBhcHBlYXJzLCBJIGNhbiBzZWUgYWJvdXQgZ2V0dGluZyBzb21l
DQpvZiB0aGUgbW9yZSBvYnZpb3VzbHktdHJpdmlhbCBhcmVhcyByZXZpZXdlZCBhbmQgY29tbWl0
dGVkLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 18:29:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 18:29:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422365.668333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj2xE-0000zP-1I; Thu, 13 Oct 2022 18:29:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422365.668333; Thu, 13 Oct 2022 18:29:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj2xD-0000zI-Tw; Thu, 13 Oct 2022 18:29:11 +0000
Received: by outflank-mailman (input) for mailman id 422365;
 Thu, 13 Oct 2022 18:29:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj2xC-0000z8-T5; Thu, 13 Oct 2022 18:29:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj2xC-0005s9-RI; Thu, 13 Oct 2022 18:29:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj2xC-0004iK-K9; Thu, 13 Oct 2022 18:29:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj2xC-0005cI-Jf; Thu, 13 Oct 2022 18:29:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bsUapyTScCai0hFSzYMdnYRNG7gbYCF3DggTAjoDqoQ=; b=cn7Wic2a7O7sZ14gsJUKi9C2Xw
	h8VzC8N5lV2yew9H6ygAWW7wmTl59QTFPGxZMn3DKIuMAG0WyVyYCOX4OJGl3tzwHNZEpEkG1zlDh
	t5sXld5H8hjO44bKKp0buWHY3UxrCxBhY3x+dLZt8r97hdloLwAQvixry6zhkyK/cPqs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173721-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173721: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=171d4d24f829075cac83b6fafe7a4ed7c93935a6
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 18:29:10 +0000

flight 173721 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173721/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  171d4d24f829075cac83b6fafe7a4ed7c93935a6
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    6 days
Failing since        173492  2022-10-11 13:01:50 Z    2 days   13 attempts
Testing same since   173721  2022-10-13 16:00:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 654 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 22:32:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 22:32:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422383.668370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj6kZ-0000fq-6O; Thu, 13 Oct 2022 22:32:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422383.668370; Thu, 13 Oct 2022 22:32:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj6kZ-0000fj-3f; Thu, 13 Oct 2022 22:32:23 +0000
Received: by outflank-mailman (input) for mailman id 422383;
 Thu, 13 Oct 2022 22:32:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj6kY-0000fZ-G3; Thu, 13 Oct 2022 22:32:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj6kY-0001oV-AI; Thu, 13 Oct 2022 22:32:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj6kX-00037w-OR; Thu, 13 Oct 2022 22:32:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj6kX-0001Il-Nz; Thu, 13 Oct 2022 22:32:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tUlLsrQMmCz94GSzTJHmMpYh++qrtqGRf9dyYNQNXUs=; b=hp0tfkrVjHYyIiW2wPbYq6uPO/
	t4QyfFCzdgNoWcyEgaa5mPU+HgXwtFZo38g36a1QtM4t6YoHIIGkH1FwnLZUFSAEa8YQ6prIg6v6f
	8tiBmX2wYbHAoQjKvDOTqrotA+NAi7H/4ImtjjCSFcHrUc+J9GFihznFgMNTgn0ouItw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173728-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173728: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=171d4d24f829075cac83b6fafe7a4ed7c93935a6
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 22:32:21 +0000

flight 173728 xen-unstable-smoke real [real]
flight 173732 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173728/
http://logs.test-lab.xenproject.org/osstest/logs/173732/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  171d4d24f829075cac83b6fafe7a4ed7c93935a6
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    6 days
Failing since        173492  2022-10-11 13:01:50 Z    2 days   14 attempts
Testing same since   173721  2022-10-13 16:00:32 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 654 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 23:05:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 23:05:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422393.668388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj7GT-0004KQ-SS; Thu, 13 Oct 2022 23:05:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422393.668388; Thu, 13 Oct 2022 23:05:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj7GT-0004KJ-OM; Thu, 13 Oct 2022 23:05:21 +0000
Received: by outflank-mailman (input) for mailman id 422393;
 Thu, 13 Oct 2022 23:05:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj7GT-0004K9-1e; Thu, 13 Oct 2022 23:05:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj7GS-0002NH-Sj; Thu, 13 Oct 2022 23:05:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj7GS-0005TY-Jz; Thu, 13 Oct 2022 23:05:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj7GS-0000P0-JY; Thu, 13 Oct 2022 23:05:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ePma7IxYkUrJLB3zUyWUyTDixm5oHLUrB4AIHu8ELXs=; b=A5aLLb6SxqfL+FI85j6Z/uZ8IW
	/3MH4/81qqYPC9vly0ldVsO7dccED6884nFe2T3QH0SW78gmmpV42NDJ1MaOv/eQWukdQH4WcALoH
	qdLIgdHsXQ3hD3wh795kOODHRSGS2NMIhrS/DHGD7I+/4NpOwvBiK6KKKGDd7erBrnTQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173657-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173657: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-amd64-i386-libvirt-raw:xen-install:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 23:05:20 +0000

flight 173657 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173657/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-amd64-i386-libvirt-raw   7 xen-install              fail REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   59 days
Failing since        173495  2022-10-11 14:08:01 Z    2 days    4 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 23:55:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 23:55:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422408.668405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj832-0001JY-N9; Thu, 13 Oct 2022 23:55:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422408.668405; Thu, 13 Oct 2022 23:55:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj832-0001JR-IX; Thu, 13 Oct 2022 23:55:32 +0000
Received: by outflank-mailman (input) for mailman id 422408;
 Thu, 13 Oct 2022 23:55:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj831-0001JH-Bl; Thu, 13 Oct 2022 23:55:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj831-0003DL-6t; Thu, 13 Oct 2022 23:55:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj830-0001Qq-RO; Thu, 13 Oct 2022 23:55:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj830-0002nF-Qy; Thu, 13 Oct 2022 23:55:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wTfixGscXy3Cfjy3CcoAw3FmJZuggbwNeptFcTerv+k=; b=Vpcz6dljqvfz/Uvxrg1qffTP3D
	KjMxIH8OuVV6xHQj+0kRza7dpzy3LO9l2EKIUjP0+ku+XbowMwQwxueDmarK+uuHELt8i4Bj9//35
	G4GeCEQn0yVNLLet9qXewwXy2/jx2kMzhaP4TVWFZ3FkGPUbkYebL3UUSLUFsOGeBGw4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173663-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173663: FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:<job status>:broken:regression
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:<job status>:broken:regression
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 13 Oct 2022 23:55:30 +0000

flight 173663 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173663/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-freebsd11-amd64    <job status>        broken in 173525
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm <job status> broken in 173525

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken in 173525 pass in 173663
 test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken in 173525 pass in 173663
 test-amd64-amd64-xl-pvhv2-amd 20 guest-localmigrate/x10 fail in 173525 pass in 173663
 test-amd64-i386-examine-uefi  6 xen-install                fail pass in 173525

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173525
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173525
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173525
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173525
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173525
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173525
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173525
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173525
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173525
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173525
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173525
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173525
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173663  2022-10-13 01:51:51 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken
broken-job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Oct 13 23:56:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 23:56:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422416.668416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj83g-0001pa-42; Thu, 13 Oct 2022 23:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422416.668416; Thu, 13 Oct 2022 23:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj83g-0001pT-1J; Thu, 13 Oct 2022 23:56:12 +0000
Received: by outflank-mailman (input) for mailman id 422416;
 Thu, 13 Oct 2022 23:56:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oj83e-0001pH-NA
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 23:56:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 97f0c871-4b52-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 01:56:03 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2FF9DB81FBC;
 Thu, 13 Oct 2022 23:56:02 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77412C433D6;
 Thu, 13 Oct 2022 23:55:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97f0c871-4b52-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665705361;
	bh=LOLUKF02ecnKr3pk5r6GXQSRCfUivqRkBUE1M1qa5+s=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=aALrG8tZs39ujQH8X4IDKj6FLTP8LM8PF4bn/HJscofeZPMvbNjBHwdqEw2y/FOfX
	 7i/x3DXdYIad7v+CoZNPTulws5sgsq0qmK73NYPNcwfnxSl/M7JVW+JAiXiPF8iEMz
	 eje3GltkOOUiV66YWum5+WGafUUHD28M6zgzJ9VW5dYFqEvtQKOTmgl1SptIGQ87RU
	 Ch2tusoKoNFmuQOZRZgCfZyUEBITFi+wyvxmIRJ+LWlh4HrR54KxECPvcSCGJVz0AC
	 kqpqkybWs86kLOAH9hKtDSu85eW+lXzyu00BIgMfFJpoM3F/YXgd/X0+V4yGe9SHoo
	 Ncbd6dcJ3zvQQ==
Date: Thu, 13 Oct 2022 16:55:58 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Henry Wang <Henry.Wang@arm.com>
cc: xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Wei Chen <wei.chen@arm.com>
Subject: Re: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as
 supported
In-Reply-To: <20221013025722.48802-3-Henry.Wang@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210131655530.3690179@ubuntu-linux-20-04-desktop>
References: <20221013025722.48802-1-Henry.Wang@arm.com> <20221013025722.48802-3-Henry.Wang@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 13 Oct 2022, Henry Wang wrote:
> With the P2M pages pool bounding the domain memory runtime allocation
> and the documented minimal size requirement of the static heap, it is
> safe to mark static heap feature as supported.

Usually we wait at least one release cycle before marking a feature as
supported. However, I can see that this case is a bit different because
effectively static heap memory is a safety/security feature.

Julien, Bertrand, I'll let you know decide on this one




> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> ---
>  SUPPORT.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index cf2ddfacaf..ddcf8a13a7 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -298,7 +298,7 @@ pre-defined by configuration using physical address ranges.
>  Allow reserving parts of RAM through the device tree using physical
>  address ranges as heap.
>  
> -    Status, ARM: Tech Preview
> +    Status, ARM: Supported
>  
>  ### Memory Sharing
>  
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Oct 13 23:58:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 13 Oct 2022 23:58:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422423.668427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj85w-0002Y3-HQ; Thu, 13 Oct 2022 23:58:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422423.668427; Thu, 13 Oct 2022 23:58:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj85w-0002Xw-Dt; Thu, 13 Oct 2022 23:58:32 +0000
Received: by outflank-mailman (input) for mailman id 422423;
 Thu, 13 Oct 2022 23:58:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=r8Z/=2O=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oj85u-0002Xk-AI
 for xen-devel@lists.xenproject.org; Thu, 13 Oct 2022 23:58:30 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee89d6bb-4b52-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 01:58:29 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8AE1661988;
 Thu, 13 Oct 2022 23:58:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5F99C43470;
 Thu, 13 Oct 2022 23:58:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee89d6bb-4b52-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665705506;
	bh=X+5mTGaWSkKspZ2p1yeZgonBVH4jAhn1p5y/6rzvMwI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=SyEZOdyZfrBeot/kQ5eK4zADFZME2aw5B/s6s2zycdEv0flvPla7Sq3/W1he7qTU3
	 7rE9yY/GTa5YrYZ4VuCLNpjhFvY7gFwDdA915NOmbWuZ5lhGWrpViRRYjGHodceCkX
	 oMUVTuF9TAltN3QnJ6qqHTj+FDa0UyciQxF089qyr8fdJO2VBhqOL4dooeMu3jdYsX
	 QoLtlr8x/qdio+MdM2I5Vzc0AMv7lz8GiRAeni1pEZpje/3VFTk7uYJbuGWpEXFlv8
	 1gIiawDteMoWY+D1dGXaRtSw3/dPy4SE/WPKp2D+im1wt9JBFuKYjHYq3KdSqBTMWh
	 Ug2KQq3n4yZ6Q==
Date: Thu, 13 Oct 2022 16:58:25 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Henry Wang <Henry.Wang@arm.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
In-Reply-To: <20221013025722.48802-2-Henry.Wang@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210131658150.3690179@ubuntu-linux-20-04-desktop>
References: <20221013025722.48802-1-Henry.Wang@arm.com> <20221013025722.48802-2-Henry.Wang@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 13 Oct 2022, Henry Wang wrote:
> The static heap feature requires user to know the minimal size of
> heap to make sure the system can work. Since the heap controlled
> by Xen is intended to provide memory for the whole system, not only
> the boot time memory allocation should be covered by the static
> heap region, but also the runtime allocation should be covered.
> 
> The main source of runtime allocation is the memory for the P2M.
> Currently, from XSA-409, the P2M memory is bounded by the P2M pool.
> So make this part as the minimal requirement of static heap. The
> amount of memory allocated after all the guests have been created
> should be quite limited and mostly predictable.
> 
> This commit adds documentation that explains how a user can size the
> static heap region.
> 
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>



> ---
>  docs/misc/arm/device-tree/booting.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 87eaa3e254..046f28ce31 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -531,6 +531,13 @@ Below is an example on how to specify the static heap in device tree:
>  RAM starting from the host physical address 0x30000000 of 1GB size will
>  be reserved as static heap.
>  
> +Users should be mindful that the static heap should at least satisfy the
> +allocation of the P2M maps for all guests. Currently, the minimal requirement
> +of per-domain P2M pages pool is in-sync with function
> +libxl__get_required_paging_memory() (for xl-created domUs) and
> +domain_p2m_pages() (for dom0less domUs), that is, 1MB per vCPU, plus 4KiB per
> +MiB of RAM for the P2M map, and plus 512KiB to cover extended regions.
> +
>  Static Shared Memory
>  ====================
>  
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 00:23:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 00:23:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422429.668438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj8Td-0006Xi-V7; Fri, 14 Oct 2022 00:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422429.668438; Fri, 14 Oct 2022 00:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj8Td-0006Xb-Rt; Fri, 14 Oct 2022 00:23:01 +0000
Received: by outflank-mailman (input) for mailman id 422429;
 Fri, 14 Oct 2022 00:22:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cdf0=2P=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oj8Tb-0006XV-OQ
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 00:22:59 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5ac83c8f-4b56-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 02:22:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 56AA4B8091A;
 Fri, 14 Oct 2022 00:22:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09B50C433C1;
 Fri, 14 Oct 2022 00:22:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ac83c8f-4b56-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665706976;
	bh=Ff1BF7LSPAhz412OPTKrZbCVDW8pPmUf/xYI7GplSUg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=KL9HUHAhlho4iWCQ5qYncwYFT/2xZat5NUswgsVHQQVxcPagVSUnMEBEGHy+9P4uu
	 ZVUnU7aJo5UkQZpigKDqTA16Kqw2vnqT94CMCt/W/vyaLWXRoAAs49JUnRcRqjHS4r
	 KSILW5yCHvZDrZwDVGjWBPB2e6fcmLqdGIVKfQN275W2UXbkVE90gflRDZsUiaGWkB
	 gBPxtQFQZEHwBHBfHiZcUlSerr1KUyPjlaC+6ZRnBjZEchsAKs6saf+V3aMELlvALp
	 quscZDBjqYutrQN2Ufro5uSeVPpcN9H0J9YkXCEu6oVcl3pEZ0K5ApjqOyzZRU2lCv
	 +JIwy6TvJ75hg==
Date: Thu, 13 Oct 2022 17:22:54 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V2 1/2] xen/virtio: Handle cases when page offset >
 PAGE_SIZE properly
In-Reply-To: <20221008151013.2537826-2-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210131722080.3690179@ubuntu-linux-20-04-desktop>
References: <20221008151013.2537826-1-olekstysh@gmail.com> <20221008151013.2537826-2-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 8 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Passed to xen_grant_dma_map_page() offset in the page
> can be > PAGE_SIZE even if the guest uses the same page granularity
> as Xen (4KB).
> 
> Before current patch, if such case happened we ended up providing
> grants for the whole region in xen_grant_dma_map_page() which
> was really unnecessary. The more, we ended up not releasing all
> grants which represented that region in xen_grant_dma_unmap_page().
> 
> Current patch updates the code to be able to deal with such cases.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> Changes V1 -> V2:
>    - s/gfn_offset/pfn_offset
>    - clarify gfn calculation when granting a page
> 
> Previous discussion is at:
> https://lore.kernel.org/lkml/20221007132736.2275574-1-olekstysh@gmail.com/
> ---
>  drivers/xen/grant-dma-ops.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index c66f56d24013..1d018e3a68a0 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -168,7 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>  					 unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned long dma_offset = offset_in_page(offset),
> +			pfn_offset = PFN_DOWN(offset);
> +	unsigned int i, n_pages = PFN_UP(dma_offset + size);
>  	grant_ref_t grant;
>  	dma_addr_t dma_handle;
>  
> @@ -187,10 +189,11 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>  
>  	for (i = 0; i < n_pages; i++) {
>  		gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
> -				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
> +				pfn_to_gfn(page_to_xen_pfn(page) + i + pfn_offset),
> +				dir == DMA_TO_DEVICE);
>  	}
>  
> -	dma_handle = grant_to_dma(grant) + offset;
> +	dma_handle = grant_to_dma(grant) + dma_offset;
>  
>  	return dma_handle;
>  }
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 00:25:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 00:25:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422435.668449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj8VZ-00076M-DL; Fri, 14 Oct 2022 00:25:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422435.668449; Fri, 14 Oct 2022 00:25:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj8VZ-00076F-8s; Fri, 14 Oct 2022 00:25:01 +0000
Received: by outflank-mailman (input) for mailman id 422435;
 Fri, 14 Oct 2022 00:24:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cdf0=2P=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oj8VX-000769-Rz
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 00:24:59 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a1b4554c-4b56-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 02:24:58 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D5074B82178;
 Fri, 14 Oct 2022 00:24:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FB86C433D6;
 Fri, 14 Oct 2022 00:24:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1b4554c-4b56-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665707095;
	bh=/23VSTNLYqmIWscuKhGhxVVaLvk1lahcvAz0t7UyFSQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=DOmniJWJR564x1ZOxEyQENlrjEcyVUDUE4aV0qeDC4E7W1NPd4Smk1M72wHSNjNb+
	 zfkmxfm626kykQNeN3zmlDfxc1nn9PYzDBwWDu16GPJDZl3IB23VFZwYiZN+CWMZIs
	 JrnlTrylfmy8u+j0M/2PiOqzwlFjxUjyQanrsOllIXpYGJD1T+pEaHha+8dk+8UToW
	 S87QUA8FlhpS7hgs6aG2joppsT692IGOjONOonPvzcbhLY13BvqeQsQu2Z3AmpDWzF
	 h/R/EXWcjFTgFsBaytsP9t0IsPHU0UgnbHvDTBiuulnrYyOPzRxrQ/G5F0pV6fwD0q
	 UzxkM0aw/O00w==
Date: Thu, 13 Oct 2022 17:24:53 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V2 2/2] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP
 to Xen counterparts
In-Reply-To: <20221008151013.2537826-3-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210131724440.3690179@ubuntu-linux-20-04-desktop>
References: <20221008151013.2537826-1-olekstysh@gmail.com> <20221008151013.2537826-3-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 8 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Currently, a grant ref is always based on the Xen page granularity
> (4KB), and guest commonly uses the same page granularity.
> But the guest may use a different page granularity (i.e 64KB).
> So adopt the code to be able to deal with it.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> Changes V1 -> V2:
>    - update commit description
>    - rebase
>    - use xen_offset_in_page() in xen_grant_dma_map(unmap)_page()
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006120912.1948459-1-olekstysh@gmail.com/
> ---
>  drivers/xen/grant-dma-ops.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 1d018e3a68a0..aff0f95ed954 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
>  
>  static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>  {
> -	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
> +	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << XEN_PAGE_SHIFT);
>  }
>  
>  static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>  {
> -	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
> +	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> XEN_PAGE_SHIFT);
>  }
>  
>  static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
> @@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>  				 unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = XEN_PFN_UP(size);
>  	unsigned long pfn;
>  	grant_ref_t grant;
>  	void *ret;
> @@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>  	if (unlikely(data->broken))
>  		return NULL;
>  
> -	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
> +	ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
>  	if (!ret)
>  		return NULL;
>  
>  	pfn = virt_to_pfn(ret);
>  
>  	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
> -		free_pages_exact(ret, n_pages * PAGE_SIZE);
> +		free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
>  		return NULL;
>  	}
>  
> @@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
>  			       dma_addr_t dma_handle, unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = XEN_PFN_UP(size);
>  	grant_ref_t grant;
>  
>  	data = find_xen_grant_dma_data(dev);
> @@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
>  
>  	gnttab_free_grant_reference_seq(grant, n_pages);
>  
> -	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
> +	free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
>  }
>  
>  static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
> @@ -168,9 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>  					 unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned long dma_offset = offset_in_page(offset),
> -			pfn_offset = PFN_DOWN(offset);
> -	unsigned int i, n_pages = PFN_UP(dma_offset + size);
> +	unsigned long dma_offset = xen_offset_in_page(offset),
> +			pfn_offset = XEN_PFN_DOWN(offset);
> +	unsigned int i, n_pages = XEN_PFN_UP(dma_offset + size);
>  	grant_ref_t grant;
>  	dma_addr_t dma_handle;
>  
> @@ -203,8 +203,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>  				     unsigned long attrs)
>  {
>  	struct xen_grant_dma_data *data;
> -	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned long dma_offset = xen_offset_in_page(dma_handle);
> +	unsigned int i, n_pages = XEN_PFN_UP(dma_offset + size);
>  	grant_ref_t grant;
>  
>  	if (WARN_ON(dir == DMA_NONE))
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 00:53:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 00:53:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422441.668460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj8xR-000285-KE; Fri, 14 Oct 2022 00:53:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422441.668460; Fri, 14 Oct 2022 00:53:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oj8xR-00027y-He; Fri, 14 Oct 2022 00:53:49 +0000
Received: by outflank-mailman (input) for mailman id 422441;
 Fri, 14 Oct 2022 00:53:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj8xQ-00027o-1I; Fri, 14 Oct 2022 00:53:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj8xP-0004rE-Ux; Fri, 14 Oct 2022 00:53:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oj8xP-0003oH-CG; Fri, 14 Oct 2022 00:53:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oj8xP-0001b8-Bq; Fri, 14 Oct 2022 00:53:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VZBhgcK70SqYPdiUG3OhcXUus+ng7sRJZgnYXYdOrNE=; b=MvqFvCSklaEyy2BJbxkj1Ga9ii
	odSO1PvCQ/ek12H+NR12mZHo1pWrLhZmff1/nJSUZyEI+dTLZAXt9uuaFZqnPhHJONOqRVSLaOud/
	LLfNy1VLOqgbMJnWjBpSuidBChGuYlPdtLxdp493b5hqo7yq6LB8o1CiQ5gxTqhXETkk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173671-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173671: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=2fb71217f9d25436b72a78c5d91f015623eb7ef4
X-Osstest-Versions-That:
    libvirt=2f856d617b3b4ebbd3fe53a50a856b411f95c462
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 00:53:47 +0000

flight 173671 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173671/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173542
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173542
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173542
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              2fb71217f9d25436b72a78c5d91f015623eb7ef4
baseline version:
 libvirt              2f856d617b3b4ebbd3fe53a50a856b411f95c462

Last test of basis   173542  2022-10-12 04:18:58 Z    1 days
Testing same since   173671  2022-10-13 04:18:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cole Robinson <crobinso@redhat.com>
  Jens Petersen <petersen@redhat.com>
  Jiang Jiacheng <jiangjiacheng@huawei.com>
  Michal Privoznik <mprivozn@redhat.com>
  Pierre LIBEAU <pierre.libeau@corp.ovh.com>
  Zhenyu Zhang <zhenyzha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   2f856d617b..2fb71217f9  2fb71217f9d25436b72a78c5d91f015623eb7ef4 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 02:54:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 02:54:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422452.668477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojAqC-0004cC-Dr; Fri, 14 Oct 2022 02:54:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422452.668477; Fri, 14 Oct 2022 02:54:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojAqC-0004c5-AD; Fri, 14 Oct 2022 02:54:28 +0000
Received: by outflank-mailman (input) for mailman id 422452;
 Fri, 14 Oct 2022 02:54:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bPLM=2P=amd.com=Stewart.Hildebrand@srs-se1.protection.inumbo.net>)
 id 1ojAqA-0004bz-Vz
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 02:54:27 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2052.outbound.protection.outlook.com [40.107.237.52])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80c3dbf2-4b6b-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 04:54:24 +0200 (CEST)
Received: from DS7PR07CA0014.namprd07.prod.outlook.com (2603:10b6:5:3af::17)
 by IA0PR12MB7627.namprd12.prod.outlook.com (2603:10b6:208:437::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Fri, 14 Oct
 2022 02:54:17 +0000
Received: from DM6NAM11FT114.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:3af:cafe::7c) by DS7PR07CA0014.outlook.office365.com
 (2603:10b6:5:3af::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Fri, 14 Oct 2022 02:54:17 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT114.mail.protection.outlook.com (10.13.172.206) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 02:54:15 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 13 Oct
 2022 21:54:16 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 13 Oct
 2022 21:54:12 -0500
Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Thu, 13 Oct 2022 21:54:10 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80c3dbf2-4b6b-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fFVoCVWMBIwJtbleO1SJY2p7QsuXqzKDGNhNh4xchYcycS9IqBsT3pZMbPWtVt71d/jRASseIr3ZWF6UKxdJ+WINKQzz0dsObVwEs6NaCYP6i7AxTRLLR1tv0BHwFJagpQcCIvJ5fO5mUsztDnIziR/b0PEdcyq28jgMBsP/RFZxre6L0Jx8QOLDHJlL6A+M682/pJX+kQK+HWnmlQ8oYvWLEBIWwNJCsEKHtO5L/gAVwChazS9CLpiypKQsuoPO10O9L5yeC8eSPMOo2a78YaGj6n+frAtCZF9I8U0JdCyvUzx0W6gOZVuckY9I5sphSDdqpRk23zihCu30/b71pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zULvW+JkD+An25jpZLbA8r94kG4X0+wBMjtFrTztGg0=;
 b=kKQfAuyVtV+rTOq/MP+qu6nZXlsDQjnn1egZ1qB3SOlPY1KIJRl6jnxm8w86AvFjNEMgAOIJlu4kPxa1UsEkUg0kglvaKxXU+Qfgj4z4KYNPilKffh3EUjyErxfEzLLQCqMcGREsObg6tY1wgPY5ffeelpx3DHGUg/G3ci5lO8MR4p6tJVeDPDvRwvKnkWN1OZlyMMe+x9DrrXfZtW5tHmCGkoOdtyV1VNyJN+EjdKHwxtm/gaB5ZaIJBEhJxRzWu9uE/F4ZEZKN4eHs997VcAtuAhP/O1fe3J/qcaeBjyxC0P1k/PZQnl8DWJnEozNAqi3GjLN7phyKFh4ugs5f0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zULvW+JkD+An25jpZLbA8r94kG4X0+wBMjtFrTztGg0=;
 b=D0lyL8IdZcsQ/miUbwMnrIPGWpN6fLG59riQ/SuOcjtrkwSGO+nwVZJy5r3i0y4TwTrw4waenJj8+G+2ab1nVI6bxlSteiGQ7lc4jU/i9/8YsA30FRbXSCRflZFLtzY3ffWrPtJ/DFvAF1BWhuypZ2wfVkE5t+6lGFp2ek2rvOI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Stewart Hildebrand <stewart.hildebrand@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Stewart Hildebrand <stewart.hildebrand@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH] xen/arm: mark handle_linux_pci_domain() __init
Date: Thu, 13 Oct 2022 22:53:54 -0400
Message-ID: <20221014025354.30248-1-stewart.hildebrand@amd.com>
X-Mailer: git-send-email 2.38.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT114:EE_|IA0PR12MB7627:EE_
X-MS-Office365-Filtering-Correlation-Id: 327d6dde-de34-4e90-b5c8-08daad8f61d5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sEMl27HmOze/5XkQfX+5fI1pthshkgR0fwxaZDlm4tLNXkZfSmYwtfjRcuN/d07XMkluRunhpTj9uYun3YAgylBxRrx1We3D6rqdaGNhmRQi7x8rmdPEIlO0mShkNmWCR4PPBPvDdHufp4mIMEWIzbbyss4wdauV09rHRxF8vsYvXdXUvZbZXShhANpAwjWodyhGH6U4wGMLKY+8cLsxXt0SX/sPaeATrtDOVSJdWMeCNAIY6QtwtWRFAnkgzm9far5nVZ8u0XwOv5onCIUChv90eTLc8k8xkMwi3/ZIGUlwSMF12qGYjsaIldFt3GQvwq9z6iH6A9qJ7pdhKNE3Y/Fdlk1uJkyTAWbIoKpF8gxIRactZE3JCyH+OrZ2Ox/EIVnD8ihxpHXLTaM7Bf3tO8U3KouNPOUvy8clxbhbG4bAJYGRPDy5K0kXRHttNOneAmuCeoGFthgr9vGskoGB7I5r2Nk2Uc4+xktywcsTlHVyBckpMeftL9gXbuhaXi/1RQFI38k4loFg383YLKqqGuRA0yeREE6XQzxLxOIQ6mhqDVsMGHVm5pc8GPAe0vfG6U6XCdEqj9GUZeIayZwZ21jyxo3xffAe5vWr+CmeHcKcO53ak82HNouEfRAESYWaZZ6LM1JCAJylZcadaGSYlDUpGRwwymVvmCyo0J/FmOuu2Fo6JrwIcwW+r1JISwQ0XjzzHihafUpQFfag6SEPWhn6dHJRX+hJVJHZMo1FeX/Zpm6gZ8BMOxWjjNcSfn1o/sybj5KCc8X3L3B025v3H7tYylx1e7X1U56//kgPS0vZtLtbQ6KvcjwQSkNFbh/E
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(36860700001)(426003)(83380400001)(47076005)(44832011)(2616005)(1076003)(40480700001)(4744005)(356005)(70206006)(86362001)(70586007)(8676002)(4326008)(82740400003)(8936002)(26005)(186003)(36756003)(40460700003)(6916009)(2906002)(336012)(478600001)(316002)(81166007)(41300700001)(5660300002)(54906003)(6666004)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 02:54:15.8889
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 327d6dde-de34-4e90-b5c8-08daad8f61d5
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT114.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7627

Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
---
 xen/arch/arm/domain_build.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index b975d0b309..9fa283d694 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1051,8 +1051,8 @@ static void __init assign_static_memory_11(struct domain *d,
  * The current heuristic assumes that a device is a host bridge
  * if the type is "pci" and then parent type is not "pci".
  */
-static int handle_linux_pci_domain(struct kernel_info *kinfo,
-                                   const struct dt_device_node *node)
+static int __init handle_linux_pci_domain(struct kernel_info *kinfo,
+                                          const struct dt_device_node *node)
 {
     uint16_t segment;
     int res;
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 14 04:14:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 04:14:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422460.668493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojC5K-0004lE-6g; Fri, 14 Oct 2022 04:14:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422460.668493; Fri, 14 Oct 2022 04:14:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojC5K-0004l7-41; Fri, 14 Oct 2022 04:14:10 +0000
Received: by outflank-mailman (input) for mailman id 422460;
 Fri, 14 Oct 2022 04:14:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojC5I-0004kx-Fg; Fri, 14 Oct 2022 04:14:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojC5I-0007Kp-Du; Fri, 14 Oct 2022 04:14:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojC5I-0007fB-5A; Fri, 14 Oct 2022 04:14:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojC5I-0002ib-4i; Fri, 14 Oct 2022 04:14:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LDwwojMSma+EscMagFLwzfCm+513PKpiE3S93/1OmUA=; b=qm5jUOhOXGHTfEZpTpd3jKQxP5
	2Twf6oM7hKokHx1c+4VXEFTasIyPyVAgF1k7IBgqW6qOyt+V7PRvIE83WLRARcaqzUVzJND/jKHmX
	Oi73j5O7PHWVIfbbWDIPYh3t1s/4lLIzF0dGd/oGJDUhmkV3gsHNtgu1gSWDhiEr4wFE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173734-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173734: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=171d4d24f829075cac83b6fafe7a4ed7c93935a6
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 04:14:08 +0000

flight 173734 xen-unstable-smoke real [real]
flight 173740 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173734/
http://logs.test-lab.xenproject.org/osstest/logs/173740/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  171d4d24f829075cac83b6fafe7a4ed7c93935a6
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    6 days
Failing since        173492  2022-10-11 13:01:50 Z    2 days   15 attempts
Testing same since   173721  2022-10-13 16:00:32 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 654 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 04:55:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 04:55:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422468.668504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojCix-0000oY-7i; Fri, 14 Oct 2022 04:55:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422468.668504; Fri, 14 Oct 2022 04:55:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojCix-0000oR-51; Fri, 14 Oct 2022 04:55:07 +0000
Received: by outflank-mailman (input) for mailman id 422468;
 Fri, 14 Oct 2022 04:55:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5+2g=2P=gmail.com=christopher.w.clark@srs-se1.protection.inumbo.net>)
 id 1ojCiu-0000lE-U8
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 04:55:05 +0000
Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com
 [2607:f8b0:4864:20::92d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d20f10e-4b7c-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 06:55:03 +0200 (CEST)
Received: by mail-ua1-x92d.google.com with SMTP id f4so1534788uav.3
 for <xen-devel@lists.xenproject.org>; Thu, 13 Oct 2022 21:55:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d20f10e-4b7c-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=5D1Hoxeb3D8WWJwzAf/bk2+jIKQPC662C1zmp8xwPGk=;
        b=gLXLHt/qG4aVDH4wkS0NOaCemP1JUFlrXUHgIGc/wMpq2PtqQybGu0iA43fz+MEkQt
         MfWRwEeyQDCDyr8Rq6EF2sVpLqw9+Y6NbFyrYKdtfY3kDGORcF/CidXwkNhUiLz02ckK
         u3bSCvgVfolrA56HetgF1F6IUqM8we1muaQkMSR+oZwNu9iX004DakiiVfssJk5qTd1C
         YpoJdmRvCt51pukLct0ip2K7/HZinsCYfc0xtt3zrOskVDSaXRXjFuH3OvHRWeHeM8mW
         OORncsQkPG5O7n/lm9w3ejq/QcjgAo2kN4mUqp6DAm41SbYrO9loyuAhmeVvRfJtQr5u
         s+Xg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=5D1Hoxeb3D8WWJwzAf/bk2+jIKQPC662C1zmp8xwPGk=;
        b=BeyxPi1u6HmTbg88xAY9RpUqDChqsjri+rcyuFhxXKi+t6cbVBBuL+PikgKk7Dtu5O
         O/+uhAevf6eUVP+rgl6eY/L5QHvlRT8um2px7E9reFIjJo01ffluQv8eD6QcrAVBwTCA
         h1a+q6/xtvBd02c7h+SZn7ekUgE3fgZ6hy6mbR2eEhtxrDggbdw91zgq2ZTrFyVByol9
         XFTQuct/0NnBhGHNJdFD6u3HaUs1ie7t/TgCRqWbLRsKFl7M5ZW7yH4vA4wZyTolSbmK
         /RptBtIMbpchZYEHDisBeneiHlbb9Quo4Q+3yyZbMnDpfvSfvv79LsAvFI0R0z4h0Z8Q
         I+NA==
X-Gm-Message-State: ACrzQf2Awah6SuICNftszyc51Tuptdb+8jbDLu660/cU00kg5XR+JlCQ
	QMEAP+Oc8o38X0e20dco4WU/chftGYNX4xLFucM=
X-Google-Smtp-Source: AMsMyM4/lqKUMS8eZRWIIaStIvlrIG17E837br1X3bHPTJDAe3JbqP5xH+Dao2aeW6eWWBJGcn2KH5Tu05HGn922F08=
X-Received: by 2002:ab0:634a:0:b0:3d7:495b:88fd with SMTP id
 f10-20020ab0634a000000b003d7495b88fdmr1691647uap.108.1665723302498; Thu, 13
 Oct 2022 21:55:02 -0700 (PDT)
MIME-Version: 1.0
References: <20221007193124.20322-1-jandryuk@gmail.com> <a4524dcc-36ce-267a-afbd-5785eab73882@citrix.com>
 <AS8PR08MB7991432FC3C0643161277930925E9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <CAKf6xpt3LL3tLMEQkxivqVCw-kQhLnZBfjO=kFvim9NwamNkDQ@mail.gmail.com>
In-Reply-To: <CAKf6xpt3LL3tLMEQkxivqVCw-kQhLnZBfjO=kFvim9NwamNkDQ@mail.gmail.com>
From: Christopher Clark <christopher.w.clark@gmail.com>
Date: Thu, 13 Oct 2022 21:54:51 -0700
Message-ID: <CACMJ4GYbMCHbFR7tqdpOvniX=vZ6JHkfoP4PNYQBjoJOUUSS+w@mail.gmail.com>
Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Henry Wang <Henry.Wang@arm.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: multipart/alternative; boundary="000000000000bd54bf05eaf76dfb"

--000000000000bd54bf05eaf76dfb
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 11, 2022 at 5:18 AM Jason Andryuk <jandryuk@gmail.com> wrote:

> On Fri, Oct 7, 2022 at 9:12 PM Henry Wang <Henry.Wang@arm.com> wrote:
> >
> > Hi Andrew and Jason,
> >
> > > -----Original Message-----
> > > From: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > > Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
> > >
> > > On 07/10/2022 20:31, Jason Andryuk wrote:
> > > > I observed this ASSERT_UNREACHABLE in partner_rings_remove
> > > consistently
> > > > trip.  It was in OpenXT with the viptables patch applied.
> > > >
> > > > dom10 shuts down.
> > > > dom7 is REJECTED sending to dom10.
> > > > dom7 shuts down and this ASSERT trips for dom10.
>
> dom7 used a wildcard ring, and dom10 connected to it with a (driver
> level) stream socket.
>
> > > > The argo_send_info has a domid, but there is no refcount taken on
> > > > the domain.  Therefore it's not appropriate to ASSERT that the domain
> > > > can be looked up via domid.  Replace with a debug message.
>

I follow this - thanks for the explanation.


> > > >
> > > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>

Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>


> > >
> > > We're into the 4.17 release process now.  A bugfix like this obviously
> > > should be considered, but will need approval from the release manager.
> > > CC Henry.
>
> Thanks, Andrew.
>
> > Andrew: Thanks for the information!
> >
> > Jason: Would you mind adding a "Fixes:" tag following the rule described
> > in [1]? Thanks very much! With this tag and proper review/ack from
> > maintainers:
>
> Of course.  It would be:
> Fixes: 82a817307c5b "argo: init, destroy and soft-reset, with enable
> command line opt"
>
> > Release-acked-by: Henry Wang <Henry.Wang@arm.com>
>
> Thanks, Henry.  We'll see what feedback Christopher provides.
>

I agree - include for 4.17.

thanks

Christopher


>
> Regards,
> Jason
>

--000000000000bd54bf05eaf76dfb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Oct 11, 2022 at 5:18 AM Jason=
 Andryuk &lt;<a href=3D"mailto:jandryuk@gmail.com">jandryuk@gmail.com</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri=
, Oct 7, 2022 at 9:12 PM Henry Wang &lt;<a href=3D"mailto:Henry.Wang@arm.co=
m" target=3D"_blank">Henry.Wang@arm.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Hi Andrew and Jason,<br>
&gt;<br>
&gt; &gt; -----Original Message-----<br>
&gt; &gt; From: Andrew Cooper &lt;<a href=3D"mailto:Andrew.Cooper3@citrix.c=
om" target=3D"_blank">Andrew.Cooper3@citrix.com</a>&gt;<br>
&gt; &gt; Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE<br=
>
&gt; &gt;<br>
&gt; &gt; On 07/10/2022 20:31, Jason Andryuk wrote:<br>
&gt; &gt; &gt; I observed this ASSERT_UNREACHABLE in partner_rings_remove<b=
r>
&gt; &gt; consistently<br>
&gt; &gt; &gt; trip.=C2=A0 It was in OpenXT with the viptables patch applie=
d.<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; dom10 shuts down.<br>
&gt; &gt; &gt; dom7 is REJECTED sending to dom10.<br>
&gt; &gt; &gt; dom7 shuts down and this ASSERT trips for dom10.<br>
<br>
dom7 used a wildcard ring, and dom10 connected to it with a (driver<br>
level) stream socket.<br>
<br>
&gt; &gt; &gt; The argo_send_info has a domid, but there is no refcount tak=
en on<br>
&gt; &gt; &gt; the domain.=C2=A0 Therefore it&#39;s not appropriate to ASSE=
RT that the domain<br>
&gt; &gt; &gt; can be looked up via domid.=C2=A0 Replace with a debug messa=
ge.<br></blockquote><div><br></div><div>I=C2=A0follow this - thanks for the=
=C2=A0explanation.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex">
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Signed-off-by: Jason Andryuk &lt;<a href=3D"mailto:jandryuk@=
gmail.com" target=3D"_blank">jandryuk@gmail.com</a>&gt;<br></blockquote><di=
v><br></div><div>Reviewed-by: Christopher Clark &lt;<a href=3D"mailto:chris=
topher.w.clark@gmail.com">christopher.w.clark@gmail.com</a>&gt;</div><div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; &gt;<br>
&gt; &gt; We&#39;re into the 4.17 release process now.=C2=A0 A bugfix like =
this obviously<br>
&gt; &gt; should be considered, but will need approval from the release man=
ager.<br>
&gt; &gt; CC Henry.<br>
<br>
Thanks, Andrew.<br>
<br>
&gt; Andrew: Thanks for the information!<br>
&gt;<br>
&gt; Jason: Would you mind adding a &quot;Fixes:&quot; tag following the ru=
le described<br>
&gt; in [1]? Thanks very much! With this tag and proper review/ack from<br>
&gt; maintainers:<br>
<br>
Of course.=C2=A0 It would be:<br>
Fixes: 82a817307c5b &quot;argo: init, destroy and soft-reset, with enable<b=
r>
command line opt&quot;<br>
<br>
&gt; Release-acked-by: Henry Wang &lt;<a href=3D"mailto:Henry.Wang@arm.com"=
 target=3D"_blank">Henry.Wang@arm.com</a>&gt;<br>
<br>
Thanks, Henry.=C2=A0 We&#39;ll see what feedback Christopher provides.<br><=
/blockquote><div><br></div><div>I agree -=C2=A0include=C2=A0for 4.17.</div>=
<div><br></div><div>thanks</div><div><br></div><div>Christopher</div><div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Regards,<br>
Jason<br>
</blockquote></div></div>

--000000000000bd54bf05eaf76dfb--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 06:26:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 06:26:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422474.668516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojE9L-0002um-Pu; Fri, 14 Oct 2022 06:26:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422474.668516; Fri, 14 Oct 2022 06:26:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojE9L-0002uf-Mz; Fri, 14 Oct 2022 06:26:27 +0000
Received: by outflank-mailman (input) for mailman id 422474;
 Fri, 14 Oct 2022 06:26:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojE9K-0002uP-Ii
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 06:26:26 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2045.outbound.protection.outlook.com [40.107.104.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1fa34d14-4b89-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 08:26:23 +0200 (CEST)
Received: from AM5PR0701CA0020.eurprd07.prod.outlook.com
 (2603:10a6:203:51::30) by PAXPR08MB7624.eurprd08.prod.outlook.com
 (2603:10a6:102:242::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 14 Oct
 2022 06:26:20 +0000
Received: from VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:51:cafe::19) by AM5PR0701CA0020.outlook.office365.com
 (2603:10a6:203:51::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.6 via Frontend
 Transport; Fri, 14 Oct 2022 06:26:20 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT034.mail.protection.outlook.com (10.152.18.85) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 06:26:20 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Fri, 14 Oct 2022 06:26:19 +0000
Received: from cdc5913d47ce.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 42E7E598-853B-4FA2-BE53-0E545B0430BD.1; 
 Fri, 14 Oct 2022 06:26:13 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cdc5913d47ce.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 06:26:13 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9361.eurprd08.prod.outlook.com (2603:10a6:20b:5a8::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 06:26:09 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 06:26:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fa34d14-4b89-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OB+dzMXWRRpbwp5G4a6RT67JpPhTSwVdAnoe6PPefBU4y0SPxtbqwM9MYsEFqIEs2wDbGjW5etwYHv4tGs7V9qomnbcmOQZYZhD2xi5/KYLK1KeIDbjiymXR3syVS3ggKdvADfl64bPjLNbxFWdxijSvn2qSdi499BCsxXddaoBq25oH4wKUdoL7fO/PF3zOUkBOO1UTVMFE5C5WPZ2Mi6IfPL6vQcVEnbIjyuG2rirxNSB2xM0pQluBi6SxIo7gvgXdOLTCCXHQdVEF1qy6MhwuEdoq5KkvgRlGLRkRDu19cXsDrWGUDkLC7gsLpDcurpOQjVpYY9FSuJGbVjN9rA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V8miSsCz/DfV7aiM14+M93ez+u0Y6bItyhsWaxgylbw=;
 b=McbhBtzrsHy7eiu4hT4uUyBs2VPXSPs37ZPpGQ+0rZWRRjkawFFVuaME2M1ugZ7KhU6Wa9HWDpp4D0Wpr8lGmq+ODp87xnSRnoC/3fp9iQl2uLm5ZUHXlg/BrmbrGCJ9yun00QofCMp/R/MS8ZCaTTfIbXVnYxzfVM9m2zwyiiaBTi/GP2RGeQVcu6inaCItIWpBU0u6UC5nEpih8UZQa4LjuEOFeZcA6IYLbA7VsUbEyKx2R1Kh/5ZHbdijWRH3GferfQaG/Cnv4yXX5WaRd7YLToAMqwbi7Omqsik1AanCuH3mWGuJyLCmsQwwKMVIu+PXND7sn+6caxfIBGUqxg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V8miSsCz/DfV7aiM14+M93ez+u0Y6bItyhsWaxgylbw=;
 b=rjBW9t6Ky3X6+6GmrTJ34Zi+/YbDNb8a8rrFRMKMghcPIVRzecVVOxmJ+ANrMTiTgNAvAiziq7V14hOV7ykCiZMuvULRsmYPpH2x5ybNWj1QFSQdhtFY/uGGsldOtF8Fg635O1MzY02aXuRge/F+KmCbFCjhH7Er2t8cvqycflU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N9YhB1PS0ADlT8uX6dRLMQw2CYZnEx5RwycYsgSNhySdHry0t1PddFnghWc8+49hBAihK15EYWK2fw0NL0NTnGfv9D3EsxyDxB4Z9L5TDEf09DHZPztvKdo4tTn+8C79roXeadbGosB3tYxjLKoq21D0hBGo3CmbB1UozPzpEQiYZBHikR5ogzqvQ9XcPNaah0kx/yicxEHG3dDB0AWU41xR9tCQelPTfo1xmBdKQEDfpeUWiHud1oiWeQcC9Wy8RpAieuI4jUnmpMMQNuOxm7kQvkKA32dL2EVil7fTlRaEko9ciN5ABrtx6zLu6L42NkZUyrluc0adjn5r/yL+fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V8miSsCz/DfV7aiM14+M93ez+u0Y6bItyhsWaxgylbw=;
 b=TZq76SRm4D874Y6soAHWpERiXBl96RtBH1ghOxq2wBJnQo695fcKHluuCUmwuSWGvZgXCtcgeFbMzvVi9WOwBqyjuURdHQKUj6ZNd8ItWK589rsRtgevM/pytBoQdbL0ZEUEBw7DS0dIfqHkDCyPKfoVxJrwTnjSZxYK6L7kc8PsACtUS4VgqarbxF+3cF8SQn+lN8eRULET38kZbXYCUX8bGNx3KZKTp5f86NdPSA53kT8PueQOy53E4qdjrJKRKH0z83R8b3bxRiNcpdqTAeVLHsa8hkFNaRaACeLo2TGdkQ1lSsClWGHYlviAkwVvj4nuu/3J0veEmzgS2lmQKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V8miSsCz/DfV7aiM14+M93ez+u0Y6bItyhsWaxgylbw=;
 b=rjBW9t6Ky3X6+6GmrTJ34Zi+/YbDNb8a8rrFRMKMghcPIVRzecVVOxmJ+ANrMTiTgNAvAiziq7V14hOV7ykCiZMuvULRsmYPpH2x5ybNWj1QFSQdhtFY/uGGsldOtF8Fg635O1MzY02aXuRge/F+KmCbFCjhH7Er2t8cvqycflU=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Anthony Perard
	<anthony.perard@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement,
 toward non-recursive makefiles
Thread-Topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Thread-Index: AQHY3wSf1tDccsob1U2UzC8OPggTyq4MneqAgADO4WA=
Date: Fri, 14 Oct 2022 06:26:09 +0000
Message-ID:
 <AS8PR08MB79916265D28F1533ECC538F992249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
In-Reply-To: <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 3E1B684AC6B68B489FA3EB189D90FF05.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9361:EE_|VE1EUR03FT034:EE_|PAXPR08MB7624:EE_
X-MS-Office365-Filtering-Correlation-Id: a056d62c-6a83-44de-3ed7-08daadad0214
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5W9QviUvFTwnYuBm31i2a6FWoPG8OwW00n3ovPWldf6nLIBlGo1wBgfP5uzhKH3kqRtJqrYC0QGNbDlEIZK+fX5WrxNBQEp/u7R8YVo98ANbUlHQmLwU81cQHcSp6KLKLhftKOG6BPAUm2qns56eK9VAU/53qj7iKUS2EXXaNB9Dqth2fqwcl5vQVprrB2R9GqBA2N5hrf2rgzusorgppytJGwWX2NZP4mXIb8rJHIw0WLqMTErNcRr72GDYMX13j/73LMKTct0unhp0SE8uubKqj1wjEobkIRLA84CymDx+YE/K2f/chVWyb4jXA4hH6x9w7Qs63fd0v9AApMgHVR8tAE+xyOg3xhtTeTbJ8Xb3EXcfMCO8sdeMaXEi2wpfaFtB2JDQSp9HMf/lwWAm8LwvhWFVRCseXrSxSpOYWvbgXtuRJ5zyO2aLmkGEHp3HTWoT1XiLY+viJZwvUkKGkKG5Uo5iAHE/f5GkcYOMvKE4sLDzqc43YiE2z4mBTxilcZSi3EmobQwTtyZ1pyEVprNS39eOoF73F5bfVTIK5+93IOB5qhj35rY9LUX5OISA3d2rAJssi7AzRYGzkjtLvNG3AzO/o4/jfNvojU6lPS3VtiAhcJ8FXBATzK021MuHEnkXvDdzCee34Cy6jidmrSanKsUjKG0dd/9VkAiJ3/H+RJAf71Ms4SAXQH77C4jyLUUTRjpNfNT6/e8Web567bhR7yfTlffxxsxajbbHsNVxt0tq1q4t2yGTXpUA3vW1Rr7+w9t/TqE2gmWV3pT/Q1n2rbLOUUzSiQP07fOV7k0=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(86362001)(38100700002)(38070700005)(966005)(53546011)(71200400001)(26005)(66446008)(41300700001)(76116006)(66946007)(9686003)(66556008)(8676002)(478600001)(64756008)(66476007)(122000001)(186003)(2906002)(5660300002)(316002)(8936002)(52536014)(110136005)(4744005)(83380400001)(55016003)(6506007)(33656002)(7696005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9361
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	07835307-3b59-4656-ed8a-08daadacfbf9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XzCEDAhjO8+W6I3lRfMvQ9ZA2RPXi2ZXCRL08kQnCsBERPJym6z5sB3ni0XDlMmgsjn33ItCg7CAmOuVbHKKAfGf95T/aaKXXQQHRSEShorlaDhfWdBb591kTx3Vu6hn3MiI+hn3+8JO1BHXeJt6CThYmLvg16qyK9CTqSc6Ljug0aebj1ZUe/9wJ7mftoxOxftSV+Jn35EWfrW35fLZ3wECqZRJNPxvDOpUH9BUbas6bTtv8/ubfFHmhes+XNZ+Iam2W7v0C3oXBn6t84JQvRYeEhx+ZviOumSKDuXRFToSGMBSciSyJWYL4Du29zqALv10uwq1nzxLDCBxfIwLEt1k5/dJ85PJSUCJzAQrAI91HBDW7JjlKYGXFS5qsJAk0fYNl5NFEPereJN+QayvrIXNL56BBxpwZsSd535TnbkexQawz+As2ciAV+PYc5q5nqoTM9DDyb83CWwcgv5Iptk2fG6tG2JBaaBCrCH291KT15biq04+bMTsFRfnqC8IgWgMf+p5yTnZNzymj8jYc5Osds9XsiNTHKepSJKOZfAPb1pdUu8KGxBMULziMghQK84bJg4KeLdC0MMT09V2heu/6Nx1jZV4I5eA9jQhWXc2qy4ru9vOLMd0+TpkAqYSt0xWK4mIXVg09Ld8yRFfnG1NYzqsIcpM4OsEdzXVfvUSnlUFIEjUjGv0NepiPnQTbcosVhdLMGabVJy8H21JbCoT6iGl+5sR2cwhCq62/bvKz/5fkVHk91vkcr6MzY6avy0+XgUhIODyuhsYTBynVsMtCTEYfZvWYHFpspVkNYU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199015)(40470700004)(46966006)(36840700001)(81166007)(70206006)(82310400005)(83380400001)(82740400003)(356005)(70586007)(110136005)(40460700003)(8676002)(53546011)(40480700001)(6506007)(47076005)(7696005)(9686003)(55016003)(26005)(33656002)(2906002)(336012)(8936002)(186003)(478600001)(86362001)(316002)(966005)(41300700001)(52536014)(36860700001)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 06:26:20.1087
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a056d62c-6a83-44de-3ed7-08daadad0214
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7624

SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl
dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbWEVO
IFBBVENIIGZvci00LjE3IHY1IDAwLzE3XSBUb29sc3RhY2sgYnVpbGQgc3lzdGVtDQo+IGltcHJv
dmVtZW50LCB0b3dhcmQgbm9uLXJlY3Vyc2l2ZSBtYWtlZmlsZXMNCj4gDQo+IE9uIDEzLzEwLzIw
MjIgMTQ6MDQsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiA+IFBhdGNoIHNlcmllcyBhdmFpbGFi
bGUgaW4gdGhpcyBnaXQgYnJhbmNoOg0KPiA+IGh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdC1o
dHRwL3Blb3BsZS9hcGVyYXJkL3hlbi11bnN0YWJsZS5naXQNCj4gYnIudG9vbHN0YWNrLWJ1aWxk
LXN5c3RlbS12NQ0KPiANCj4gSSd2ZSBkb25lIGEgZnVsbCByZWJ1aWxkIG9mIHRoaXMgKHdpdGgg
dGhlIDIgbm90ZWQgZml4ZXMpIHdpdGggWGFwaSwgYW5kDQo+IGl0IGRvZXMgcmVzb2x2ZSB0aGUg
T2NhbWwgbGlicmFyeSBsaW5raW5nIGlzc3Vlcy7CoCBUaGFua3MuDQo+IA0KPiBTbyBULWJ5LsKg
IElmIGFuIGFsbG93YW5jZSBmb3IgNC4xNyBhcHBlYXJzLCBJIGNhbiBzZWUgYWJvdXQgZ2V0dGlu
ZyBzb21lDQo+IG9mIHRoZSBtb3JlIG9idmlvdXNseS10cml2aWFsIGFyZWFzIHJldmlld2VkIGFu
ZCBjb21taXR0ZWQuDQoNClJlbGVhc2UtYWNrZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdA
YXJtLmNvbT4NCg0KU2luY2UgdGhpcyBzZXJpZXMgaXMgcXVpdGUgbGFyZ2UgYW5kIGp1c3Qgb3V0
IG9mIGN1cmlvc2l0eSwgZG8gd2UgaGF2ZSBhDQpwaXBlbGluZSBvciBDSSBqb2JzIHRvIHRlc3Qg
YWxsIHRoZSBtb2R1bGVzIHRoYXQgYWZmZWN0ZWQgYnkgdGhlIG1ha2VmaWxlDQp0b3VjaGVkIGJ5
IHRoaXMgc2VyaWVzPyBXb3VsZCBiZSBnb29kIHRvIGhhdmUgc29tZSB0ZXN0IHJlc3VsdHMgdG8N
CmJvb3N0IG91ciBjb25maWRlbmNlIG9mIGNvbW1pdHRpbmcgdGhlIHNlcmllcy4NCg0KS2luZCBy
ZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 07:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 07:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422482.668529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojEvi-0008SW-LE; Fri, 14 Oct 2022 07:16:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422482.668529; Fri, 14 Oct 2022 07:16:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojEvi-0008SP-If; Fri, 14 Oct 2022 07:16:26 +0000
Received: by outflank-mailman (input) for mailman id 422482;
 Fri, 14 Oct 2022 07:16:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojEvg-0008S9-Pj; Fri, 14 Oct 2022 07:16:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojEvg-0002SB-Nz; Fri, 14 Oct 2022 07:16:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojEvg-0002vN-3n; Fri, 14 Oct 2022 07:16:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojEvg-0004jO-3P; Fri, 14 Oct 2022 07:16:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4Tuw0fJB+a/wbGjZ7d+W/j0F3EpPCLShzot7z+c2UVM=; b=FOfxvjT+FtlpF7iG6aWbfEVoaX
	/oc8WKJpM8B52eweP6QxeboM1R3TSQVFyCu0D7dNGAXOODbjYe8vgdLY9udQ+MAE0xHb14NxKWT10
	vQGGNLuZbYbppj7bR4Nqf7FUwEVPREebhlOkVh+6ZfPhqJaKpr5DFs385ps2tBIMouuY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173675-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173675: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a185a0995518a3355c8623c95c36aaaae489de10
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 07:16:24 +0000

flight 173675 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173675/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                a185a0995518a3355c8623c95c36aaaae489de10
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    6 days
Failing since        173470  2022-10-08 06:21:34 Z    6 days   15 attempts
Testing same since   173675  2022-10-13 04:51:15 Z    1 days    1 attempts

------------------------------------------------------------
1069 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 105177 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 07:16:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 07:16:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422485.668541 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojEvz-0000Lg-UW; Fri, 14 Oct 2022 07:16:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422485.668541; Fri, 14 Oct 2022 07:16:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojEvz-0000LZ-Rn; Fri, 14 Oct 2022 07:16:43 +0000
Received: by outflank-mailman (input) for mailman id 422485;
 Fri, 14 Oct 2022 07:16:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojEvy-0000Ky-2a
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 07:16:42 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 25dc1d20-4b90-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 09:16:40 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9452.eurprd04.prod.outlook.com (2603:10a6:10:367::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 07:16:37 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 07:16:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25dc1d20-4b90-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uuv7iC4zqaTKCf8fAfcDen3d4/EJyRDIRHWRExSRbTwvbn5Bwiw4z7M051htjH8yVEgo5pUKZ7n5CYuETd1bzb4G0Sd1ZZve24vAJMYhf5NlKkP5f8WNZdACfW79xsDf1/liUMj/T38Q15fx7Ix08NwCL+95Ch6fyg7j5Lb2E7XxaRKV2KI2Lin/Jpm5DuHZvhlk6CHmytttb+GgBwx+qUL449M8xtbuDP2qV/uxzJ9SzeXUBkXWXb4SE8eZnTgFVZ7vuXvBl2u+nURDqUtHnLdvwjCGhpR91A1BbJmj30W0hn7ZgBz1G+mSpBAoCYJn6fKmBxSWlqtNn+m0ae6S9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Fz4UN0Cnuxb/BfFeNdsBtbD6w11fgvQFBiLcoH1yywM=;
 b=XRzheaQWmVrqP0GinWWnjPXIf8Z4Phb5JryBMEw9MX32SiIJdJDdICzygAeYnBn5IhTg/N8q3kGm6Q1VDMvQxCzWIKxZcgkwu6tknzrRxzm/MdwJuo6rTRgrDIkG26dr/U+i3fq6yjuZ7UtOyoPoMNPkArb4Bj6hD/UZI5BFB3ZR+wFFM38F/XzHNMU4ZVRP6aGyB6XSZR2916q7oDyYQ4cPzEid4EQnAYs7SuZr1r2nEnRUB46/MlxJOqcWLHjE65qfByq4VNRdcviFH0ux+T5S9K4POSLXV9hPArDt1YIF5ctPOJWta0HWnErFJNQP1kzw7SNShB1IAf9YtR/OWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Fz4UN0Cnuxb/BfFeNdsBtbD6w11fgvQFBiLcoH1yywM=;
 b=E1feUjD23aJmvZUNu1sFjnDdVOZ9xH7/EaY/d89roGBxcskYhS8eh3qYNo2Z74Y4zXnLPLwakX/VsD3ZpH9tEtlP1J7m3K9Cny6F+765XOJpX2FEiD6saQ1ZHToSlrptMOLACsxCXrCEyW4aeiNE7gQI0Peww+JRPsgiAVqvv6hCSb067irx119wE/OcrAu299rtturyAGR8bUr1aGWQ+ykoXO7SqPYLCQif5g72lFuZp+wsE7eJO9v1T3GgzQjjThW3ib0sSmOM+aJ9MHm20Hh4C4wnXqvtFms9sowie473+QJSkcaA3WpXfbIrP5Yjuim6Bou44WHnC0/1fN3fdA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0ade954c-5741-754c-fc59-177feb67ddf4@suse.com>
Date: Fri, 14 Oct 2022 09:16:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init
Content-Language: en-US
To: Stewart Hildebrand <stewart.hildebrand@amd.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221014025354.30248-1-stewart.hildebrand@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0023.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::31) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9452:EE_
X-MS-Office365-Filtering-Correlation-Id: e21ab535-ea58-42d5-411d-08daadb40893
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	APJXQSgwkCDyLZlP4UNrTIo4EcW/Akto5Y6aoTLw2frUcRVPTZLTsW2e/AqAS9UN/fgBizsybN+/R5V4qDKAW54ylFvVUttoi2oW+Gz69mERg4RLt5dTCNRxWfh4O/Bt12dB6ZGOPluhizMN/MsedEFC0WtXoiAGcQA7yIJGEGSrqHTaAFCjo/x1G6jBAG9nlfiuPsBuPQFSeoOwD/IE02jE6O8Mtttx1sCVKsvsP46prGJIoFZRBVZI5LvEKxfDZGF6WRkrSVrxq/2FuChvg/C1krFsDQ7WtWejRiGkKA4YtwP6Bqv5EGL7M2fng+ZDlUxSWQzpF6eflU/neMhmmHDCxMVMLjoJmuMkHAKqTWtEOYVruOBCwdMQytBj3Qr+0C3CfN0nMrh1hfGa4F1oT0nSsQsYhIkIayEhD6V68ZP60nZdfwWdduWIMsDiPgeY/Fokmj2kM0NxBW5U9nA9Kp63Un8H+rba3cjyEAz0eTj97bLHFMq9irQYjTp317Un3fDNXOsoa3Kr+kxZhhxe2NtdvSXr+WuzMcsZ5Ww3+uqvYnp/sAwantkjdWt27UcPbwmSUETQbCO/alTGOhzdGfd1t/uCliLrQbUHKWpTOkMwM4dDeCBoW64XR4yFqksmgVxIT6CB73mOI7NCt2fGlUCaqI2Xy0GMpZ6Ks8f6gfQtTYxrV860xDC557AVSXh4f5aIhR5yJRWQnExES+HLHVOlysRzwnxshtu0YmIwIwwTBEh7Hh8oqN3hs0MchxqgSyFO8dZPm9Iif5/QewYEuNdkI5wFZ1VDoEUhFSv3zO4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199015)(2906002)(66946007)(36756003)(8676002)(4326008)(8936002)(66556008)(66476007)(31696002)(53546011)(26005)(6512007)(41300700001)(5660300002)(38100700002)(558084003)(86362001)(6506007)(2616005)(54906003)(6916009)(186003)(316002)(31686004)(478600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXNPemxabFFpbWIrcjNVcmhvU0F6TSt5Q016eTJoanBOWU1ya0NZWG40enZa?=
 =?utf-8?B?c1VJQzZpSHYwYXNmVjFtVUVscGd1ZUZXU1JGT1JZU1ZGYkltc3kzcVF1a1c5?=
 =?utf-8?B?aS9EU21aUm9FekgvL2RkQXlkaFZVRjdYTUw5Yk11SzZDSVJKN3ZZaXZGLzY3?=
 =?utf-8?B?TXpjK3NUaWJkTUhnUEsva3RDM2hnTUwyMFFnSTlpVkxsNUUzTmlWNWhxQlhx?=
 =?utf-8?B?bHRjOFRYaFNaOVovWmlmRUNsa1h4d2dWZ0RJdzVtTEVTVlFsc2UrUFg4RWRH?=
 =?utf-8?B?TkdnbkI1Sk9Fem96NWZxcnYvTHY1akwwMENMWnBnMHU4VjBONUVSYzBObnJo?=
 =?utf-8?B?Q09DdEM3c2JxOXNrRHRXdlhmMjRPeDduTG1HTUt1Kzc3cEt2am1yRTV3Z2U0?=
 =?utf-8?B?OWttMk5nVC93dzNmRWxQYmlQRDVmT2cyb0VVNFNYOG9GajNEZnVGeTZNcVZ5?=
 =?utf-8?B?d1FDSnEvRVJKK2JleCs5WldJZjhHeUJEbnd6b1pOY3BIMlg2bytWZU9NVFg1?=
 =?utf-8?B?TzZ5Sk1QYytIVlZrbW9BeGUwNUZ0MndQQTlWSGh5aTRDc29oSFJuUGJ2c2JF?=
 =?utf-8?B?UUhJTlYwc01uV1hSVWplWHpMZmVwcW9JdlBTOWhMMDJlbWsyRlVUaVV3U2hu?=
 =?utf-8?B?dENXekY3N2ZHRDFaRFJJSVd1WFF5bW9LUjdROHpjelovTWFTT3dWN242bHpM?=
 =?utf-8?B?azdQcjN5aG5WYTB2SU0xYmtxQldqU055U29iY3czeWVhZ0pXSytvQjZwZTBP?=
 =?utf-8?B?RTlvbFd3WDBxeExUOFk1Mzc3WnJqMS91blhVclhYaHVIOWNhMHBLYVYxakx4?=
 =?utf-8?B?U3F4cGZRR01pZytVaXZKb1daQnhNd2drOE9QbVZXN2pYaFRmbWdkL21Gd3Fp?=
 =?utf-8?B?eG1pNkVOMlJnSXAybjZNaFBJNW1lN1RieDkwYm9lU0hmNzRmNXlSUWRwbGxS?=
 =?utf-8?B?NDZLSGlFN2thRUJQdXlKREc3S0FOKzJqeXh6WnJ0RHlBb05OVEtiNk5yc0ZH?=
 =?utf-8?B?Ni9jTEJFd014aDF3RnV3Y1VrUSttSGhTZnBqemhEaDM4L0x1TUE0S2djdkVs?=
 =?utf-8?B?NlZnaUFtSlZ6eWNwRDlqb0tOZzVST29WcjZUNGZHUzFYL24yYUFMUFM3NU5O?=
 =?utf-8?B?WS9OckhDcFpCZjg2MHNDU0NsZnBuNCsrWk0vaE15cVpPN2N0d2xhU1BEWFJB?=
 =?utf-8?B?dHdsMy9PN3drSjAzaDZ4S0libzljMU9oNER0bzE2RndGZ1A2cmRkblRrbVJw?=
 =?utf-8?B?TFZ4TlhCYkozNlJVa1ZBc3d6TjhpQzJhVVgzVXZUa3k2WUF3VjV6UnJMWU9o?=
 =?utf-8?B?dkF3WkNKNFJMRGhFNnNTOHNjaTVpNFZhQ0VZNHpScXRoOHNKTHFQa0pYbU5G?=
 =?utf-8?B?K1JUbTFqcnRtdjR1dVZHRHUzdkVLT3E5SzgvQUFtZ29WdkhtWGdwK21aTHFL?=
 =?utf-8?B?MzVBZ2FDVndEdWdiMlNEMW9jVEhocXhsd0RWSHZzUXF4R1RTLytoNTZMakNN?=
 =?utf-8?B?dXhFOXIzbVZxdVZqaEFwMmxkYzlsRE5Yakt1VCtSTjFCSGZmU2dFcTZqWTlw?=
 =?utf-8?B?dXdkeW5INEMvMWVha05sU3liMXIvSmVmUitydEtLdEFZbHF0QzU1ZjQ4RG1R?=
 =?utf-8?B?MFBqanMwRXNacmlEc0w5YjcwbHFDcUEwWTN0bkg0RS9CLyszNDFQUE5HMWVX?=
 =?utf-8?B?dHB4eTJCRmdUOHNQY21jVG9XanEzeU5QR1RaL09pOU13TDlIR2ZpOHhsc2Yw?=
 =?utf-8?B?d0N5Mkp0WGNEWittOEk1V29SbE9IUVhvQjlkclZ4R0ZNMEVycFBmRHRWUVMz?=
 =?utf-8?B?L3o3ekwvL3J5TUpyNHVPTVZrT2hkY3pOeFFWek9DaWVjT0xLY1h4a0ovRCtm?=
 =?utf-8?B?ZmRVY1hWUnYzSFpZdXYvZDVldzhlcTl6VUd1OEdyWUMySWd0a2hkVDEvYXU4?=
 =?utf-8?B?dGh4eE4xbEd1dkQyWXVlaVp3VkVDZ1dmaWUyN3pzQ1FkYW03RWhxQTM5dlNP?=
 =?utf-8?B?ZjFUZ3lacFFNRGp2MDdQTXBSOGM4WUE1ZnU4MUtMeUg2aTdzRmZxSDhtUDdw?=
 =?utf-8?B?d3R5R2Noa25WWUtzc3JWWnR4SENvWWJFVmtEekdDYmFvNHdXZkJ6WXlhNTNZ?=
 =?utf-8?Q?mkhTRBV0QTC+wx3A9bk3T/5S0?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e21ab535-ea58-42d5-411d-08daadb40893
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 07:16:37.7651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FQpEcAQIZab3gLFPFgdpso62kJTY6AFSkXtQMc3/28zDdlv1tR0yTt9D+XKdBTX7VghXdMLgqgn+50J4CDe4sA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9452

On 14.10.2022 04:53, Stewart Hildebrand wrote:
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

I guess a non-empty description and a Fixes: tag would be nice.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 07:35:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 07:35:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422497.668555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFE9-00036g-Hx; Fri, 14 Oct 2022 07:35:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422497.668555; Fri, 14 Oct 2022 07:35:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFE9-00036Z-F4; Fri, 14 Oct 2022 07:35:29 +0000
Received: by outflank-mailman (input) for mailman id 422497;
 Fri, 14 Oct 2022 07:35:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d1R5=2P=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ojFE8-00036T-V4
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 07:35:29 +0000
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com
 [2a00:1450:4864:20::62c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c5994d46-4b92-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 09:35:27 +0200 (CEST)
Received: by mail-ej1-x62c.google.com with SMTP id r17so8654737eja.7
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 00:35:27 -0700 (PDT)
Received: from [192.168.1.93] (adsl-9.109.242.227.tellas.gr. [109.242.227.9])
 by smtp.gmail.com with ESMTPSA id
 p13-20020a17090653cd00b0078d175d6dc5sm1040479ejo.201.2022.10.14.00.35.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 14 Oct 2022 00:35:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5994d46-4b92-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=IH2CpfxEnRPwyicRs6j2xX+M8g2xRDD94KWbgPm56UQ=;
        b=WTM16MpNXdwQMpkJIl9siCRyn8/P6hXgvjHqcZ4wHq5Ylr095mkKLwo1MssyAHb7T7
         AZ5gQWH3xEMbjuplmB1Uid8GIqzqZfEXRK8/iMRtKGULNKpCsrObFi7WT4rwGIFJUdY3
         amOeedWqg0fJzgTFTD8EwKoqNV7lQdmQoJAURykshfJQenO8eOMtFzB9YXutzL3aChr9
         xyfeKZNWy/8vpE+6OIFyve7NhEBlAywrTSC/npVIJYX+OPuX4svHHSWXxPPWbKnu4sUA
         HJZAKXcR17CXxJolDRAO0v9IHKe0QPMMGaYqMRopo5bUynVUGtt7bmljiTj751SQiGk7
         MeAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=IH2CpfxEnRPwyicRs6j2xX+M8g2xRDD94KWbgPm56UQ=;
        b=mot5r5OajY7/7Z2A5HBUL415h6UI2uyvV/ICiiCi3+RJcVcEMAxDC3KunsOLKSLFMl
         KTwXpX9KgbwCjx/obO4VbeFxmQ6e+dUIqMr5n68nNF2LVd5AC4zFN5KCMRS687jYVnMw
         NPRLosG4rqkGjnp2nx+U+U3FC1BDHaQKDMILKJ1b2NQd64E50H7jsDupIEf9FmIpcrUp
         drbCx2014xarZbeQ1Jmwg+uPkYpAhcsUbuoVzdeyV0vBWNTQA2C3R8GVi+vjQcdRZmKz
         Q5R3fvhlkcGtIn5VD+0HldmfO9gxwmnqM/D9Yl2Pbwii58KGLcuUl9GB5xdqUEWnQ4vN
         obXQ==
X-Gm-Message-State: ACrzQf3YFG+0vT/ONeCwSKMOUu1+sDB+/C/WYQ9LPrJgvyog34xdXRoN
	CBey6WjJlc35SVk8/nwxDFw=
X-Google-Smtp-Source: AMsMyM5tm2UqwC7RYDcv5cU9uJmlRMFT3E8NR+6T0bg+FpAoctHGfjZtODhQ0PuioODwiwWi3zZivQ==
X-Received: by 2002:a17:906:9c82:b0:781:5752:4f2b with SMTP id fj2-20020a1709069c8200b0078157524f2bmr2483158ejc.561.1665732926818;
        Fri, 14 Oct 2022 00:35:26 -0700 (PDT)
Message-ID: <ae26a54b-ece5-f8a3-2331-f7e495ecceea@gmail.com>
Date: Fri, 14 Oct 2022 10:35:24 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2 1/2] xen/virtio: Handle cases when page offset >
 PAGE_SIZE properly
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221008151013.2537826-1-olekstysh@gmail.com>
 <20221008151013.2537826-2-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221008151013.2537826-2-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/8/22 18:10, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Passed to xen_grant_dma_map_page() offset in the page
> can be > PAGE_SIZE even if the guest uses the same page granularity
> as Xen (4KB).
> 
> Before current patch, if such case happened we ended up providing
> grants for the whole region in xen_grant_dma_map_page() which
> was really unnecessary. The more, we ended up not releasing all
> grants which represented that region in xen_grant_dma_unmap_page().
> 
> Current patch updates the code to be able to deal with such cases.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Xenia Ragiadakou <burzalodowa@gmail.com>

> ---
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> Changes V1 -> V2:
>     - s/gfn_offset/pfn_offset
>     - clarify gfn calculation when granting a page
> 
> Previous discussion is at:
> https://lore.kernel.org/lkml/20221007132736.2275574-1-olekstysh@gmail.com/
> ---
>   drivers/xen/grant-dma-ops.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index c66f56d24013..1d018e3a68a0 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -168,7 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   					 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned long dma_offset = offset_in_page(offset),
> +			pfn_offset = PFN_DOWN(offset);
> +	unsigned int i, n_pages = PFN_UP(dma_offset + size);
>   	grant_ref_t grant;
>   	dma_addr_t dma_handle;
>   
> @@ -187,10 +189,11 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   
>   	for (i = 0; i < n_pages; i++) {
>   		gnttab_grant_foreign_access_ref(grant + i, data->backend_domid,
> -				xen_page_to_gfn(page) + i, dir == DMA_TO_DEVICE);
> +				pfn_to_gfn(page_to_xen_pfn(page) + i + pfn_offset),
> +				dir == DMA_TO_DEVICE);
>   	}
>   
> -	dma_handle = grant_to_dma(grant) + offset;
> +	dma_handle = grant_to_dma(grant) + dma_offset;
>   
>   	return dma_handle;
>   }

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 07:35:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 07:35:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422499.668566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFEU-0003Xu-TA; Fri, 14 Oct 2022 07:35:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422499.668566; Fri, 14 Oct 2022 07:35:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFEU-0003Xn-QJ; Fri, 14 Oct 2022 07:35:50 +0000
Received: by outflank-mailman (input) for mailman id 422499;
 Fri, 14 Oct 2022 07:35:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d1R5=2P=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ojFET-00036T-Ci
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 07:35:49 +0000
Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com
 [2a00:1450:4864:20::632])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d246361e-4b92-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 09:35:48 +0200 (CEST)
Received: by mail-ej1-x632.google.com with SMTP id a26so8699094ejc.4
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 00:35:48 -0700 (PDT)
Received: from [192.168.1.93] (adsl-9.109.242.227.tellas.gr. [109.242.227.9])
 by smtp.gmail.com with ESMTPSA id
 kx22-20020a170907775600b00738795e7d9bsm1138971ejc.2.2022.10.14.00.35.46
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 14 Oct 2022 00:35:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d246361e-4b92-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=VCPRZPimy1jhKBoGPGG0+X9sDq3h3O7tAPxelD7f+No=;
        b=oP4Eynge3Xwu3n7mPW7fEyfo4HONe5tc2NiQWhi65iJ6tg0w66pwIlZXsWv3JOguT+
         T1IVGUBrzmbhQ1ptGs+Y5olPhewrE+jI8xrTzJrjFhaj7mJEe2sisCrAhk+4swVyz0dC
         mdjopwiXEGTEuc/Ox4rtfhisH2zHbCgEVyhVckCy76EhZ5FYGBpnj9DCw+avwOXSesDb
         UgXcC9osox1zEy03CeYfRa/qU6z2qKcXPUGLyeTDSc0dMxdHSkmwp4/g+uj41LZKj2TN
         2ZudF4UrNiJ5wcA32xCcAlOnKPPwdFjx4dC76QEOdCgP3uAqiWjJGoTwYRJUOS9lA8Sr
         j3Wg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=VCPRZPimy1jhKBoGPGG0+X9sDq3h3O7tAPxelD7f+No=;
        b=c5JPTEGPTDvdo74a6z5PZ5U41jxrXxN9AK1Yz9QXF2jds0daz1YYjRofc8LDbDpw0E
         YMbz1EDfsTI9u69P4pRzNlBf/rF5nmAx5oD58Qmw4T/o93NPc2VsIxyoyqjhjIod2N+5
         Qqi4ISdGB1iBJYIhuCgKxU4vc4sp05kxkqVh0knAczmQ6eqpK/4/7grX6vwtHbrA3LmL
         yvyFyqbT15qHi4BsWFXG+4Ug9Be9p0dZjpTeoK8NiioncP85QQsLe1M1dDwNKjJjeGpi
         NUJGhoL48HJVtJrjGDHQPSoFoBp1DoAAfvJuMiAa9uad2Q0xdM5GO3hY28Qf4KeSW79x
         Zxrw==
X-Gm-Message-State: ACrzQf32OmwP37XgDiaPQgkgS77Kluj3TGgBGGZjt2qu8GCiv3afEbJ1
	TpUFy27ndMBy+6YBkztOlmE=
X-Google-Smtp-Source: AMsMyM7Msvwm+JCWrbOjkGwWYLVbCwYItTXEbA6DFbHuzSJTsvZqlE5dCqRtecgcQe4shNB6I4pZ5Q==
X-Received: by 2002:a17:907:168c:b0:78d:8b6c:a209 with SMTP id hc12-20020a170907168c00b0078d8b6ca209mr2746472ejc.185.1665732948046;
        Fri, 14 Oct 2022 00:35:48 -0700 (PDT)
Message-ID: <bb45c1fa-5f6e-05f5-eba6-8dedb9270a98@gmail.com>
Date: Fri, 14 Oct 2022 10:35:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2 2/2] xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to
 Xen counterparts
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221008151013.2537826-1-olekstysh@gmail.com>
 <20221008151013.2537826-3-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221008151013.2537826-3-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/8/22 18:10, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Currently, a grant ref is always based on the Xen page granularity
> (4KB), and guest commonly uses the same page granularity.
> But the guest may use a different page granularity (i.e 64KB).
> So adopt the code to be able to deal with it.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Xenia Ragiadakou <burzalodowa@gmail.com>

> ---
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> Changes V1 -> V2:
>     - update commit description
>     - rebase
>     - use xen_offset_in_page() in xen_grant_dma_map(unmap)_page()
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006120912.1948459-1-olekstysh@gmail.com/
> ---
>   drivers/xen/grant-dma-ops.c | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 1d018e3a68a0..aff0f95ed954 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -31,12 +31,12 @@ static DEFINE_XARRAY_FLAGS(xen_grant_dma_devices, XA_FLAGS_LOCK_IRQ);
>   
>   static inline dma_addr_t grant_to_dma(grant_ref_t grant)
>   {
> -	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << PAGE_SHIFT);
> +	return XEN_GRANT_DMA_ADDR_OFF | ((dma_addr_t)grant << XEN_PAGE_SHIFT);
>   }
>   
>   static inline grant_ref_t dma_to_grant(dma_addr_t dma)
>   {
> -	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> PAGE_SHIFT);
> +	return (grant_ref_t)((dma & ~XEN_GRANT_DMA_ADDR_OFF) >> XEN_PAGE_SHIFT);
>   }
>   
>   static struct xen_grant_dma_data *find_xen_grant_dma_data(struct device *dev)
> @@ -79,7 +79,7 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>   				 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = XEN_PFN_UP(size);
>   	unsigned long pfn;
>   	grant_ref_t grant;
>   	void *ret;
> @@ -91,14 +91,14 @@ static void *xen_grant_dma_alloc(struct device *dev, size_t size,
>   	if (unlikely(data->broken))
>   		return NULL;
>   
> -	ret = alloc_pages_exact(n_pages * PAGE_SIZE, gfp);
> +	ret = alloc_pages_exact(n_pages * XEN_PAGE_SIZE, gfp);
>   	if (!ret)
>   		return NULL;
>   
>   	pfn = virt_to_pfn(ret);
>   
>   	if (gnttab_alloc_grant_reference_seq(n_pages, &grant)) {
> -		free_pages_exact(ret, n_pages * PAGE_SIZE);
> +		free_pages_exact(ret, n_pages * XEN_PAGE_SIZE);
>   		return NULL;
>   	}
>   
> @@ -116,7 +116,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
>   			       dma_addr_t dma_handle, unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned int i, n_pages = PFN_UP(size);
> +	unsigned int i, n_pages = XEN_PFN_UP(size);
>   	grant_ref_t grant;
>   
>   	data = find_xen_grant_dma_data(dev);
> @@ -138,7 +138,7 @@ static void xen_grant_dma_free(struct device *dev, size_t size, void *vaddr,
>   
>   	gnttab_free_grant_reference_seq(grant, n_pages);
>   
> -	free_pages_exact(vaddr, n_pages * PAGE_SIZE);
> +	free_pages_exact(vaddr, n_pages * XEN_PAGE_SIZE);
>   }
>   
>   static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size,
> @@ -168,9 +168,9 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page,
>   					 unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned long dma_offset = offset_in_page(offset),
> -			pfn_offset = PFN_DOWN(offset);
> -	unsigned int i, n_pages = PFN_UP(dma_offset + size);
> +	unsigned long dma_offset = xen_offset_in_page(offset),
> +			pfn_offset = XEN_PFN_DOWN(offset);
> +	unsigned int i, n_pages = XEN_PFN_UP(dma_offset + size);
>   	grant_ref_t grant;
>   	dma_addr_t dma_handle;
>   
> @@ -203,8 +203,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
>   				     unsigned long attrs)
>   {
>   	struct xen_grant_dma_data *data;
> -	unsigned long offset = dma_handle & (PAGE_SIZE - 1);
> -	unsigned int i, n_pages = PFN_UP(offset + size);
> +	unsigned long dma_offset = xen_offset_in_page(dma_handle);
> +	unsigned int i, n_pages = XEN_PFN_UP(dma_offset + size);
>   	grant_ref_t grant;
>   
>   	if (WARN_ON(dir == DMA_NONE))

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:03:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:03:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422516.668586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFfX-0007it-KR; Fri, 14 Oct 2022 08:03:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422516.668586; Fri, 14 Oct 2022 08:03:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFfX-0007im-HG; Fri, 14 Oct 2022 08:03:47 +0000
Received: by outflank-mailman (input) for mailman id 422516;
 Fri, 14 Oct 2022 08:03:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qaRP=2P=citrix.com=prvs=27923c854=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ojFfW-0007ig-9Q
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:03:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b7dca0c8-4b96-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 10:03:44 +0200 (CEST)
Received: from mail-sn1anam02lp2041.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 04:03:41 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM4PR03MB5999.namprd03.prod.outlook.com (2603:10b6:5:38a::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 08:03:36 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 08:03:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7dca0c8-4b96-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665734624;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=NI4x89Xi/2TBGkfScpxZmNkhe/Q3gyNLVSLr5yiOAGk=;
  b=IX8+gi+32OKAJa+eOmG+TJwEc2R/DDnje0o4Okjsmmt3DZ5WHLIqygjg
   1RWB/3efdv8sAIxt/dZ6y3CMue3KHx0IYz8KYC+sa9gLQL8I9vqtHpNYX
   dhEAf2spkvFh4KHDYkXQejOX2pB/MRMjPNm7nGY7/j3PdQYUXAorHzhQ1
   A=;
X-IronPort-RemoteIP: 104.47.57.41
X-IronPort-MID: 82734330
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3Ab5vil6/Cy1IwklMwbPjWDrVtTnXE+AQUBUUsX?=
 =?us-ascii?q?f3Cpuox9vdTzo0SJWKXQww3xtKpvFycd/pdrF8U6HfgqX9rwR6pjUk4BYJen?=
 =?us-ascii?q?BXZgbeA2AY+f/LqHPO7FUIptKp4mmJ9IXoGkdpOwkJNaImnSNg8UnzzxMjFk?=
 =?us-ascii?q?EWfXhf+HC/HLh6XaA1v0rgsl3S3Er4TZ8haNlKW4lGcYUPamvKcBgNvE9HgF?=
 =?us-ascii?q?KNAbilWs6q/7s7kCmhaMj9lYhppNIr+L8YIB9Z9DBEr3fprrLFoYuVy2CH6f?=
 =?us-ascii?q?EBbmCEcR5UyJvkdGanj8yVOffuwt/caEx5SZO1zrj6Hk8UYnVV/64ktnoNEm?=
 =?us-ascii?q?GQx3SQjbxF7fdl5i0+CZam6j2W6I5F7ANJ7G2ISY/WQuYsLYBYx4ww/MSpbz?=
 =?us-ascii?q?q27HswBGmWn+zFnxufjpt2pCXJdlDk1Ao9OGMsx7bgxH8p44n0OtdjFJ+8al?=
 =?us-ascii?q?5xPfGYd9xn4rAIT0x5fsg1rlppSLqKMVQXSpdN7RWx+p6Jd3h85w5WZSQ0bk?=
 =?us-ascii?q?tHXcUC+pIZ1q4BdVAkJVm5ZL6chdDeTLueRyPhkKVZZAWA6t5nYNo3qN6Vwn?=
 =?us-ascii?q?AMu4kGYP7LC35F2L9wl6C+dyYLII/jT4w7JfJ+Q12ThE0rfFE3SEIdGq9YfO?=
 =?us-ascii?q?K/vtz4KnYrB0HYWteOb8pSte735Uu6CFtyX88nijPHOEe4g269qoehlJCiFB?=
 =?us-ascii?q?2viKhB4+hA+xjsWO7Nplyigtz8PHhEt7FKpThH5e7JyF94EcDyk3h2ICIZbT?=
 =?us-ascii?q?0Huc7LKrBE3vXIbqXpQIld2GV85D2yQPDgvTJkMfG/dm2m9hRoEW/rdusQh6?=
 =?us-ascii?q?HL9lss9F/Xo7z/JAKb2nHV/29gx97jYmXN598t3aK7fgS8FxokowU4MN3gQj?=
 =?us-ascii?q?wnBZAzcX58pCwzK5/yxu4PdubToz+jXx7bLv7Aan3hyJS4NnQpKLI+9/PUWo?=
 =?us-ascii?q?YxW/f/hBGj9Vsfcs5J1A9ykTPmuv3CbZGH8/v3QOYC+gSgmCr03fnTkryPqv?=
 =?us-ascii?q?HsMG7L+OLUZbHCJgQgsTK8wvuRLthfsiSuI36Y9Ur0A5w7CQ9RHi317SgHZE?=
 =?us-ascii?q?fhWbGJfmv05XrsL7dyuKaMOQ9kkop990lWaxUAWhzCdklmyUzNIey5+JgIAG?=
 =?us-ascii?q?UxYcoV5lvgDdn8MT2sw8lF0EuT19A65j3FksQGGYHRL+3M4CQ7E2VJRpWr8j?=
 =?us-ascii?q?zMV1eM5Ivzbk9oUzehAPxayNPeI0q1BvY/BoEB6dQQUU/IGD81TE2xNDIMB/?=
 =?us-ascii?q?orvMFeSzl5YeAeI2mTdr/xaMsR2J2l3qSfRLXQvk4G0dSGt0zxG0ZaaSQ+bz?=
 =?us-ascii?q?sE7/ikwGeJAxQvlEixhj6X71yW3NCH9UbjTgFNwo/pGP1hp4OAfIhHmAAGzm?=
 =?us-ascii?q?vxVBlFWE1gpkQjCbZMRCIb7fKDOUaJzmiQ+ZvrqaptwK9orfs9B4nmaK+sjs?=
 =?us-ascii?q?i29GCw9WZHoD6Bggae5c/aCBJbNiUMtlDweDmHDTaAYThKYm1uV3QXuhYdFN?=
 =?us-ascii?q?mxCL6EjVPOsMKgbuw/2I0mjut2ML2oLN5oAdbr72CtqApijl4Wb2lt0vppjj?=
 =?us-ascii?q?bZ+H/n0VfkKdoGjH8CdE5sNa0GtVgRuIeuhmJucjIMCRV5r2Mo8AMJzLZ+37?=
 =?us-ascii?q?SorK+qSo3EIKIjSJ4/VpWq/llClihamlxV7QyIZDqXYLjwQW6Bt9j57JIcD0?=
 =?us-ascii?q?7GAcyjQcnQnn5BFT9ZKUNboz/HAA4klbov/54idGLbBepfOtX/wgp8WEFm26?=
 =?us-ascii?q?iBRBBeQ07SdyEMPfI7oycsqUidmz4gjgmhSvsA+blYUqce/LgrjLHdaa1Gpr?=
 =?us-ascii?q?oUY1WQsaPTWx+g9f18uSjrTzMPPLa9Lok7PXtYcBzurNNM2hDTHLJFwQ7XR0?=
 =?us-ascii?q?GmP5HYQzfugnkBAHuji61mLJgcNsucn4imuO9OZCmrHk2gbOb00x5LxlQQRC?=
 =?us-ascii?q?uVNseajeLx7hlbtyh2D9EZQiqltDJN7KUIIUvyZX0A93qWMliUfuOSnZmmvn?=
 =?us-ascii?q?r21sMO/uT2R7awXoPdEqlTPKthxgnsmBEN9vzMaffc/rJQG3Z1tgehBDDTZ5?=
 =?us-ascii?q?n7TEYxJkGezE6pM95f0Zzm6uQl2DXFqcMZVCe26eMPp4T1Kb55Mg6zV6JnJ0?=
 =?us-ascii?q?/LLXgL9gp0mTg2XQYFUigIGLK9sytSwgT7JMrAcY9SDoi0AP8zUht3Tr2kyt?=
 =?us-ascii?q?0IBB5sUtccaPNNFuDSZdr32gOXF8+5eFWD2BzGh59wYaGiIGe0dw0ZXMDO49?=
 =?us-ascii?q?ufPN1VWAEM1ujur+Z5JrMikJd2EXp8JOWvt53Vo6Rpv36st0eWnc6mc5BtFg?=
 =?us-ascii?q?XQS4OorePEyyLw3bs6DL6G+YhNQekmEYbk7m9Pm3LJp3rMcJnKgmh4gm3Hme?=
 =?us-ascii?q?LuHkvbskEx/mtp0XvRSwDyyqKnJr/3ed5hvSkffpnecwnRg5f0jB6vkAwZLA?=
 =?us-ascii?q?i/BHbLBm269Bofdiyqat28Wdi//hs7RRY7PT2Uvafk8?=
X-IronPort-AV: E=Sophos;i="5.95,182,1661832000"; 
   d="scan'208";a="82734330"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OfdpqsAYHyc+vfXd4yQrZTJuqvO5c7v+wxBGCPSy6ItbqFBLK9GnPeEqESdZK3+LILfN79I42cmnuh3AJKmu+R6nPq0XUGgUomPzYdGWNjn529LqmMtNTit9trO3SaZwq6TFl5VCOXSUT5+7vaiSiEowIMoR8P1yB1gavJLA/4qSR1dVq/aYop4ULZN7aa2R2jb4bSvgtyTHYsBdh/45fLT2ltrde9lcJYCjgB0vFHC0aMaFHtpovaJxYDm8fo4sZ2hI7oMr8UvJXNEh9bvK5Qz9Rsot08mnkDtKxn9I1+tw1nOPkuahhFJ90eKeCF2i7thijoIKCX2GbJ8GOSDa7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1Mt/24a6Tr+BU7pmDHNjy49cBDJ7c1U4GVoTq1Sp9fY=;
 b=LbOFcFFk59n8WHZniVBjP0xT9N7rKnDh/A57F2rmZhjP5lbWfnEvjNbSbEeU2yM08jUbiognF1+LJJE6/qlDTIogPkUcVoTeGkmivdRLiMxUcGww2H8PzBXD/vvyT9xhbGNY6Iuphc06n3rpghksg2C1/7VkJ6r9P252PjpIxG839QT0lbZVozF3kMqCo++b9UCnwYaE/D6Ur+lu/NnCzMu5/lSsmCVN3gY56oOBajUAqJR704Wzm6s2cLAFDmA7bY7tliHGp/1kKUfrFtx/pRLkP7RSkf/J2XLPPiR7XgCkBf5svVCY9Vq20WKz0P9/dHvoHg1BVqYjgWWrqbuQ6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1Mt/24a6Tr+BU7pmDHNjy49cBDJ7c1U4GVoTq1Sp9fY=;
 b=i+PIHCcfPMjd1nuTzSFYVKsnxmhr4yDEJjEnJvFIGez9JazrCYpooNoEnqqP9NnYfHdpup28/OCyMq1GNHfwJ+Vf9NztZauoxv4OT+T9a4ayH7+K09bwHG+lKJ66NZUEQ+JksHDYOocY/gMDX9vkw+daIBhao2gWWoVtPINpxgk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 14 Oct 2022 10:03:31 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle
Message-ID: <Y0ggOLWa7onsacmb@Air-de-Roger>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
 <Y0f+gL1PfB5lzlDj@Air-de-Roger>
 <1867142e-ee46-daa7-c05c-04045460ba52@suse.com>
 <Y0gOOcbw2bebsKAJ@Air-de-Roger>
 <dd2ca7b9-f7a3-208d-f757-cf47f37de1ab@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <dd2ca7b9-f7a3-208d-f757-cf47f37de1ab@suse.com>
X-ClientProxiedBy: LO2P265CA0388.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:f::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB5999:EE_
X-MS-Office365-Filtering-Correlation-Id: 29e10911-72f9-42d9-dedd-08daadba9851
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e6mZvY12GeQ4RbmSIh1sIp9a/s6ghIy6RpcfFztnxIaaYqOoaul8HkBp+cXVikzv+OI64JYF0N8KR+DEsm5085JuRAZh8vT9AL0GE0/Z0GY4r5xPrqumkH3sircqdDItM9xML4Z8wD58Dj56SIkma19cA3wi7NPIn+4LD5AIQcjK28dzc0jir++5hB5kviJO4zf27wT1Ve/HHb0A81zWLVnwm+8RmbNZyVwb4GkM5TtoKxTFIChrNMXO43sVo6tHpEFt8IOuCcL8PjCUgSD4Cje+zFjEaQvncIvKypqgA8bDVDz+6DruX5JaNSkRnvkq2bnTQypWEdoYP934vWngobICLXxIwC26B3o8kiJjl1CEdkKvbSjDfCwajDyIBHnShKwgtmveRRrwBtPNMMZ+lnzMS/dPYEXLch0PPoR02U4bQECiWNd2Cxo4WG3OvGimdVtHHwDqytBfnh2p2EDDfeS9JPV5dBMPbpi79lDxtO68xUmXelCCp/cdrXZlt53oX74DsGRpbP4rex3YW7xkCG81sEm+5eaEqoDfOxNpAMo8viRwU9vurZhD//k7Fi+OPFUDJZKPa1CjzE8/6MdL6YZLUb/JQ453Tu4YuMt/bwML61+vGWC0enfdhfSFAcIxiOVnqlTSVkqblvnS91RrQvpQITjLNs7rUnJScBfxvVvIlky2RfJD3mli7CMkz1M4NjAirc44bqo9i+QgCh2Yrg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199015)(33716001)(2906002)(6486002)(478600001)(83380400001)(6666004)(82960400001)(8936002)(53546011)(6506007)(5660300002)(86362001)(186003)(54906003)(41300700001)(316002)(26005)(38100700002)(6512007)(4326008)(9686003)(8676002)(6916009)(66476007)(66946007)(66556008)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDl2K0FkdU16OUlCUjlLWExHbEdvTUhjdHQwbSs0YzFyVTViWitQY2lFU1Zx?=
 =?utf-8?B?ejY5WnhwWWtNVXVQcmZTUWczdWtBaFZXT1hCMDBBZkJmNlJ3bmVIVUszanBq?=
 =?utf-8?B?MkQrVzZqMzF4aW1jM1FGd3RobEJ3UjhwNjd4OUVhVVJiV3ozTmdCUDkyd1dN?=
 =?utf-8?B?R0tjMGNLb0EzQXcxaGVoUHpXZ0VoRzdFd1dZMGhLeEhJMDF0N0hRMmw1V0d5?=
 =?utf-8?B?Tm44L0J2dlJiR1dXY1B2WlVncFNBQkphUjVDQkEydVk1d0hYMlJsMkFXT09x?=
 =?utf-8?B?SmpKOW5oZWMzZXZaOFcrWTlROEh5UjVHOVpDanhmNkttYlpJaEdGNTMzb0Vi?=
 =?utf-8?B?bUVTblVnTDg0dzY0eGtjM1dCbnNxbkZJeThndWh4RXNITWdRREJ4UzJObGJB?=
 =?utf-8?B?enRWSFZFR0RrT2NNMmE0bXZyd2pKVk1sUC8yNzRtQm0yOVhwNS8vejRZait6?=
 =?utf-8?B?M1ZFcDFwN09VeEZnQWZtY0dkOGUrc1U3OHJER1JlcUpsMjRqS3A1a1N3M0lV?=
 =?utf-8?B?Wk1MKzRPS1JWYm1WZXJ1b25LSU1BYVJjbEl5cUV3WmZ3SFoycmRoRHY1YTd2?=
 =?utf-8?B?Z21JcTRMSHFLMkYrMDNOSGp3NWhkOVlWYUUwT2YzeG5UbXpTL2NSR28xQ2ZY?=
 =?utf-8?B?azZ6SHZsaVF2YUtPSVMrSnU4M3lGZGh3WTIxT3I3c1JJVlhtdS9ibHJvck04?=
 =?utf-8?B?ajltZE9FdEV3TmdCK25hVExBL3BqUGlUWE9BYWRDc0dzQ0ZuaWljd2JSYmxM?=
 =?utf-8?B?Zm1hZGd5TFp0N0JJbnVqU2MrcG5sYXlmU2VTbWQrUFUreTVGQmFjZ0srZDdH?=
 =?utf-8?B?VXdYNGpQbWdscm9yNlFkMUFPS3lMa3ArUVoybXgreS8vVjI2bnlJOWtBcVFv?=
 =?utf-8?B?RVlyZHdXRkZNeHpabjMrU3Z1amNSdDFvKzVmVkhGZ2VuajJOYmtVNE9rZHRi?=
 =?utf-8?B?OXZYem5Ob3hGY2FJRjFXWGVvaUtoQmk5ZDQ0Y0liS0lRaXpLSUN6RnBHL0c5?=
 =?utf-8?B?UlA5bks0T0xuVzQwdld6RS9OM2FzOS92elRvM0MzakRBOXF0cEFHV0tPcXRC?=
 =?utf-8?B?bUd3VW5MZXZ4ZDA1U3BEeldHcUhZL3ZoL0hBZWtkaVhtbXA4bUswV3dMTG5Q?=
 =?utf-8?B?WCtIMktNWU14aXBuQjVKNkVaMjdSd1ZiaU9xcHh6T0JWUTVNSjNxREM2R3VE?=
 =?utf-8?B?MmgxOGF5YXAzSUs2bzZOVDVBUVo4ZURZdDFxSVVxeDM5blJiTGpNU3FrbHZm?=
 =?utf-8?B?bGJvMTVLejRURDA2WXgxbWx4THJwbVNHRzRERVZoWXM2S3JHZHJTUUNoR1li?=
 =?utf-8?B?RFNNdFNSZjJBcjhQQVFZL1pocmFvV0cyRzR0K2Y3QUw1U3ZmQWVjcnFOREdS?=
 =?utf-8?B?SThyVGZ4QVR2RGo3TTdPMzNhZjdwb05NUTgvb2k3WWZaQXNCdTVFVnhSRlBn?=
 =?utf-8?B?VUpHUkVEZHB4NjBKWjh6WFpVM2JITk5jU045ZHFqbS9jcHowMVNMMStmVHBH?=
 =?utf-8?B?Y1ZYbytObkJ4OWFPYXV1QjBNZDJ5RUhOYyt6TVVGRlBXdVVpSW5tenFKSnVP?=
 =?utf-8?B?aGdjazZzaGhWV1kzRm8wcWVxUnpZaVdpUXpncC9RME1JeTAyZHVCcE9BdXZD?=
 =?utf-8?B?TDVXZWVOWnJISDI4S0FpM2lDR2RzY2pCL0JiaUE5elROSGF5TW1UOEdnMFZs?=
 =?utf-8?B?SEw2UVk5a08vQmRiS3FHcitUVkhoRVkvSnhrS01DSWFKb2RBRm95ZXNsOGlV?=
 =?utf-8?B?S1IxVkZUUUk1cExkNVVEcGVoNUxCNVlUWkcyV0RpNnZBTFZKR216WjRQMWhm?=
 =?utf-8?B?cWp5bUxGa0lkRno2N0xRL2g3SlRMQVh6WDE5QVF2NHpLbTBhNWtBWTd6YXJT?=
 =?utf-8?B?bDFSdFhMcFZWRVRIbU5tUEhhOTRmYjlVWnF3ZlV0dzFZa1J1YjN6T3VKT3RG?=
 =?utf-8?B?UGQ5dkJ6TFFBU0R4cjdOT21WOFowUElPNktFN2VoSW9rQ1Z3VVJWY0pMRFp1?=
 =?utf-8?B?WU4xVDdtL3BzRXVUc3ZQcVJxTVBwZEdDSjRGNGFyd1dEdUZMaHdZcHh5WXhQ?=
 =?utf-8?B?R1lxcFVtRklPMmExY09mSjJ5U3hqWUFCVXlZRFIzK3JzNXFKRks1cXBBREtS?=
 =?utf-8?Q?adD7G5uWLfxZyg7UznYjd94ZC?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29e10911-72f9-42d9-dedd-08daadba9851
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:03:36.0495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Fo+i+AvXoagyCK4hhTOtbAWX2Zc+ggBPhYldzIf9iOsPEZZfm2PCNH0PNBLGUwd87V5lxqGuQUrP9SD6CsUCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5999

On Thu, Oct 13, 2022 at 04:15:04PM +0200, Jan Beulich wrote:
> On 13.10.2022 15:10, Roger Pau Monné wrote:
> > On Thu, Oct 13, 2022 at 02:17:54PM +0200, Jan Beulich wrote:
> >> On 13.10.2022 14:03, Roger Pau Monné wrote:
> >>> On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote:
> >>>> From: Peter Zijlstra <peterz@infradead.org>
> >>>>
> >>>> Having IBRS enabled while the SMT sibling is idle unnecessarily slows
> >>>> down the running sibling. OTOH, disabling IBRS around idle takes two
> >>>> MSR writes, which will increase the idle latency.
> >>>>
> >>>> Therefore, only disable IBRS around deeper idle states. Shallow idle
> >>>> states are bounded by the tick in duration, since NOHZ is not allowed
> >>>> for them by virtue of their short target residency.
> >>>>
> >>>> Only do this for mwait-driven idle, since that keeps interrupts disabled
> >>>> across idle, which makes disabling IBRS vs IRQ-entry a non-issue.
> >>>>
> >>>> Note: C6 is a random threshold, most importantly C1 probably shouldn't
> >>>> disable IBRS, benchmarking needed.
> >>>>
> >>>> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
> >>>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >>>> Signed-off-by: Borislav Petkov <bp@suse.de>
> >>>> Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
> >>>> Signed-off-by: Borislav Petkov <bp@suse.de>
> >>>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf5835bcdb96
> >>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >>>
> >>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >>
> >> Thanks.
> >>
> >>> One unrelated comment below.
> >>> [...]
> >>>> @@ -932,8 +939,6 @@ static void cf_check mwait_idle(void)
> >>>>  			pm_idle_save();
> >>>>  		else
> >>>>  		{
> >>>> -			struct cpu_info *info = get_cpu_info();
> >>>> -
> >>>>  			spec_ctrl_enter_idle(info);
> >>>>  			safe_halt();
> >>>>  			spec_ctrl_exit_idle(info);
> >>>
> >>> Do we need to disable speculation just for the hlt if there's no
> >>> C state change?
> >>>
> >>> It would seem to me like the MSR writes could add a lot of latency
> >>> when there's no C state change.
> >>
> >> HLT enters (at least) C1, so is a C-state change to me as well. Plus
> >> we may remain there for a while, and during that time we'd like to
> >> not unduly impact the other thread.
> > 
> > OK, but it's not a "deeper C state" as mentioned in the commit
> > message.
> 
> Correct. But it's also code not being altered by this commit.

Indeed, that's why it's an unrelated comment.  I was just wondering
whether we should drop those or not in a separate patch.  I'm
concerned over hitting that path on a virtualized environment, where
changing the spec controls is likely not that cheap.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:09:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:09:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422523.668600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFlA-0008RF-8x; Fri, 14 Oct 2022 08:09:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422523.668600; Fri, 14 Oct 2022 08:09:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFlA-0008R8-6E; Fri, 14 Oct 2022 08:09:36 +0000
Received: by outflank-mailman (input) for mailman id 422523;
 Fri, 14 Oct 2022 08:09:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojFl8-0008R1-RC
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:09:34 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 887923b6-4b97-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 10:09:32 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBFFD1424;
 Fri, 14 Oct 2022 01:09:37 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4A78E3F67D;
 Fri, 14 Oct 2022 01:09:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 887923b6-4b97-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Date: Fri, 14 Oct 2022 08:09:17 +0000
Message-Id: <20221014080917.14980-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
which requires 6 P2M pages as the two pages will be consecutive but not
necessarily in the same L3 page table and keep a buffer, populate 16
pages as the default value to the P2M pages pool in arch_domain_create()
at the domain creation stage to satisfy the GICv2 requirement. For
GICv3, the above-mentioned P2M mapping is not necessary, but since the
allocated 16 pages here would not be lost, hence populate these pages
unconditionally.

With the default 16 P2M pages populated, there would be a case that
failures would happen in the domain creation with P2M pages already in
use. To properly free the P2M for this case, firstly support the
optionally preemption of p2m_teardown(), then call p2m_teardown() and
p2m_set_allocation(d, 0, NULL) in p2m_final_teardown() if needed.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
This should also be backported to 4.13, 4.14, 4.15 and 4.16.
v2 changes:
- Move the p2m_set_allocation(d, 0, NULL); to p2m_final_teardown().
- Support optionally preemption of p2m_teardown(), and make the calling of
  p2m_teardown() preemptively when relinquish the resources, non-preemptively
  in p2m_final_teardown().
- Refactor the error handling to make the code use less spin_unlock.
- Explain the worst case of page tables and the unconditional population
  of pages in commit message.
- Mention the unconditional population of pages in in-code comment.
---
 xen/arch/arm/domain.c          | 16 +++++++++++++++-
 xen/arch/arm/include/asm/p2m.h | 11 +++++++----
 xen/arch/arm/p2m.c             | 15 +++++++++++++--
 3 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2c84e6dbbb..831e248ad7 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
         BUG();
     }
 
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
+     * the allocated 16 pages here would not be lost, hence populate these
+     * pages unconditionally.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+    if ( rc != 0 )
+        goto fail;
+
     if ( (rc = domain_vgic_register(d, &count)) != 0 )
         goto fail;
 
@@ -1064,7 +1078,7 @@ int domain_relinquish_resources(struct domain *d)
             return ret;
 
     PROGRESS(p2m):
-        ret = p2m_teardown(d);
+        ret = p2m_teardown(d, true);
         if ( ret )
             return ret;
 
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index 42bfd548c4..480d65e95e 100644
--- a/xen/arch/arm/include/asm/p2m.h
+++ b/xen/arch/arm/include/asm/p2m.h
@@ -194,14 +194,17 @@ int p2m_init(struct domain *d);
 
 /*
  * The P2M resources are freed in two parts:
- *  - p2m_teardown() will be called when relinquish the resources. It
- *    will free large resources (e.g. intermediate page-tables) that
- *    requires preemption.
+ *  - p2m_teardown() will be called preemptively when relinquish the
+ *    resources, in which case it will free large resources (e.g. intermediate
+ *    page-tables) that requires preemption.
  *  - p2m_final_teardown() will be called when domain struct is been
  *    freed. This *cannot* be preempted and therefore one small
  *    resources should be freed here.
+ *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
+ *  free the P2M when failures happen in the domain creation with P2M pages
+ *  already in use. In this case p2m_teardown() is called non-preemptively.
  */
-int p2m_teardown(struct domain *d);
+int p2m_teardown(struct domain *d, bool allow_preemption);
 void p2m_final_teardown(struct domain *d);
 
 /*
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3..707bd3e2e3 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1685,7 +1685,7 @@ static void p2m_free_vmid(struct domain *d)
     spin_unlock(&vmid_alloc_lock);
 }
 
-int p2m_teardown(struct domain *d)
+int p2m_teardown(struct domain *d, bool allow_preemption)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long count = 0;
@@ -1716,7 +1716,7 @@ int p2m_teardown(struct domain *d)
         p2m_free_page(p2m->domain, pg);
         count++;
         /* Arbitrarily preempt every 512 iterations */
-        if ( !(count % 512) && hypercall_preempt_check() )
+        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
         {
             rc = -ERESTART;
             break;
@@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
+    if ( !page_list_empty(&p2m->pages) )
+        p2m_teardown(d, false);
+
+    if ( d->arch.paging.p2m_total_pages != 0 )
+    {
+        spin_lock(&d->arch.paging.lock);
+        p2m_set_allocation(d, 0, NULL);
+        spin_unlock(&d->arch.paging.lock);
+        ASSERT(d->arch.paging.p2m_total_pages == 0);
+    }
+
     ASSERT(page_list_empty(&p2m->pages));
     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:11:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:11:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422531.668610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFnK-0001QK-Ov; Fri, 14 Oct 2022 08:11:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422531.668610; Fri, 14 Oct 2022 08:11:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFnK-0001QD-ME; Fri, 14 Oct 2022 08:11:50 +0000
Received: by outflank-mailman (input) for mailman id 422531;
 Fri, 14 Oct 2022 08:11:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojFnJ-0001Q3-IF; Fri, 14 Oct 2022 08:11:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojFnJ-000416-FK; Fri, 14 Oct 2022 08:11:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojFnJ-00063p-25; Fri, 14 Oct 2022 08:11:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojFnJ-0002AG-1b; Fri, 14 Oct 2022 08:11:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=P3Zv0ELbptEOtD8clQz/Y3qjbh3//0nlBLsrVNQz96A=; b=tdKaOsXSwHuIFsHA7R4rxNuxjG
	9ZwRMwjE91Ja7FhF1OIwDh7obNBMAuH65rma01depzsD0AmM0tS517BgwFqul9M629msjJD/tR7dC
	z8un1XPm8mB9mXq21Ozc2UNERnA1pDxs6HVNS6azgODXwFlJ2crV1yhVdfYmDtPBWupQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173743-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173743: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=171d4d24f829075cac83b6fafe7a4ed7c93935a6
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 08:11:49 +0000

flight 173743 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173743/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173734

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173734 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173734 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  171d4d24f829075cac83b6fafe7a4ed7c93935a6
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    6 days
Failing since        173492  2022-10-11 13:01:50 Z    2 days   16 attempts
Testing same since   173721  2022-10-13 16:00:32 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 654 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:12:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:12:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422537.668622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFnd-0001tO-2N; Fri, 14 Oct 2022 08:12:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422537.668622; Fri, 14 Oct 2022 08:12:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFnc-0001tD-Uv; Fri, 14 Oct 2022 08:12:08 +0000
Received: by outflank-mailman (input) for mailman id 422537;
 Fri, 14 Oct 2022 08:12:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qaRP=2P=citrix.com=prvs=27923c854=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ojFnb-0001oX-Py
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:12:08 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e36d0237-4b97-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 10:12:06 +0200 (CEST)
Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 04:12:01 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6651.namprd03.prod.outlook.com (2603:10b6:303:12e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 08:11:59 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 08:11:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e36d0237-4b97-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665735126;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=wp+bJSByGOYteHx1kJI2WdCm+Wu/paW8z/MiEQKBehM=;
  b=fxm4MT5EDNWJBHzozQGTs4/2+HGQSw2I2uiBlO+5sYy57EO0Vkli0XRa
   HXf1sOE45FnTqc2Q76jDOxshRBfJ62xaX8z4/i4T8svP8VoTIPSG++vnI
   u6F2Ojgz50qC+VTnb0Xa6o3SSbFTF2UL2bJqj6q3hvUaH7jaavSQK0+r8
   M=;
X-IronPort-RemoteIP: 104.47.73.168
X-IronPort-MID: 82358081
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:iszwiK+4AIXYgDgEzFXZDrUDt3+TJUtcMsCJ2f8bNWPcYEJGY0x3n
 WNNXW6HM/aJYGT0f413aNnlp0wGupeAnYQyQVA+qS88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5wdmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0ulVA0UW6
 PknESBTTiuahOapy7TrEeY506zPLOGzVG8ekldJ6GmFSNMZG9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxujaDpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toij327+XzXqTtIQ6CbiC6udWrE+vmGESIyEcUmGauqGjhRvrMz5YA
 wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4M+A88hDL9aPS7C6QHG1CRTlEAPQ5sOcmSDps0
 UWG9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLnW0ophfGT9ImFbHviNTwQW302
 2rT8nh4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl
 CNsdxS2hAzWMaywqQ==
IronPort-HdrOrdr: A9a23:k+A/HKA08qn8YjPlHelx55DYdb4zR+YMi2TDj3oBLiC8cqSj+P
 xG785rsyMc6QxhIk3I9urwW5VoLUmwyXcx2/h0AV7AZniahILLFvAB0WKK+VSJcEfDH6xmpM
 JdmsNFZuEYeGIbsS+M2miF+rgbrOVvu5rY/Ns2h00dNT1CeuVq9AF8ChqeVkltSglKbKBJb6
 ah2g==
X-IronPort-AV: E=Sophos;i="5.95,182,1661832000"; 
   d="scan'208";a="82358081"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VRbcfoioVDPhlfFkFi8/DO76m4kVQOp3qnsPIT5dtLl669BPyiOksCD7C8NfqwtLsSms4CxVVK74R6z1Yx9B55IjxGton9j15ZdSlckD8EOFhRzk7Tp95F5Hhq2Ll14pn9D2b9TUZ4gogc23LuhnN+rZVQsYmeFgC5durhj65WLvmKapczp6JgjJreaJC4QvIB9hLtbgf6M/Z/R1eY6FEqFQ1XfRr/u7ayLJ/msewDE0NyDuZqcGz0POEUbPjiCcUAdRD9RTiWaWQDyzlL0h5dzcJlYPAV1XSe8Mhg/ndsuZXA5Ejxu/bLKYxgaQ4qYQKvwa02thq2bwh1MkkUfx7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NqbzFO+otW8dxCElDI1uhSFmo9Hh56qrw56hNcVnSw8=;
 b=XkWRnfqVyJOboqlRsmkSqUm6nR9l6ALpZqx6V9UWjumS2LWQcuuYucJDzsxUf3g0Q0QaNGrlUqG3VEsnwan4+xNP5ST0YmwpApiGUJv5GiqNd07S4uTHXjz/NFDJ6fzU0eBQQO84aDUs40+hVR/Fdx8a0aEAbSYu/MP+RCNk0VvC0JpL8z50oSPYq7fKcSpKogg+YD2UBl2TFi31svFr4eUD8TcFAIam1or6apeBZDelwhLpkCaMxyAVdjPXYojetwof7cNXxN8TCMhAVIARoBLWB8EIIfIYbNaLtp64l5EBFrbiyV1LUEwVz8LtnaeY2xVW/eu7fdcBR2uorFH1RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NqbzFO+otW8dxCElDI1uhSFmo9Hh56qrw56hNcVnSw8=;
 b=YZFvMGbdp/ZI8yPmpS608t/Q3V+DrogyDnKM+HOKPdEi0QjCi7inlNDxMqOzbQGoKGfuXgpZyBsfEUPS/ToUeUcs6xj2vNiYu32IpV7UJ8lzQUFhkRVYI9t9oFbc08MyR+nfaAgXQR6qe//BjFXlzGx+ZiJvqUqJFzNIDzL/suM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 14 Oct 2022 10:11:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 4/4] amd/virt_ssbd: add to max HVM policy when SSB_NO is
 available
Message-ID: <Y0kZyiPTnafzKv8l@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-5-roger.pau@citrix.com>
 <1f70c472-1b62-7c79-dc31-65fca8040cfa@suse.com>
 <Y0gbfCi5kp2qBxuv@Air-de-Roger>
 <bcb70302-cc88-0867-9920-2567dad96dce@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bcb70302-cc88-0867-9920-2567dad96dce@suse.com>
X-ClientProxiedBy: LNXP265CA0002.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5e::14) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6651:EE_
X-MS-Office365-Filtering-Correlation-Id: afb17ae0-515b-43e2-b905-08daadbbc3e1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	B4J+eC+HQDaFez/PS1rdgW+Y69536hBWPvYX9ba+aQ/u6nXK3JeoCM0zT7y4nN5bEGL7Y7cZlpvh0KIeoy98ot7zf/+lpQUuDvLRhyw9RZua/jWjT2DQz/IBDhcYG5GMCpWTyvqKw63b08pVRh966SUSyuKntZjNuQREON/ZcgDv8R7QbgNRVS0P8Ld3M1bwvsV7ufm0PJpFtV1VkOMiizioSAzPguQR21/5tc2NujYNDqxwNZqj8oWEn7CI9XQuu3jI3suzOeYuFh4TjKF2OZCZQJyg88S4k4KVIz9LrI3OUIQpwwzEf4K/LjLbrF8/SiVaH+pA8W9sKPNGhRMYVNkRhicVKHiB2JMgFG5NmOM6CkZ+j33SQS4dmODHXXwrSB03mwWstmI6f0lj8xXdURvCuJTH58lJOUqwe2ubZkeSVyD+qPmHY/2Fw4qu+XmCG/SzNcjeSt7Jap6fld9uqpANT6uFHo79TxI6N15HOw229m5zEFtni/p0r7tqV/YJTfmt6SFzZy/HExSkAdobtGYXAgfgOfar21/I37JqqE8mE997Ojb4MGrTmAcHw46axms/PdJgCn0+OV6YC3rwP39EoiOZ9Hcl43eisHQGfjgUqQ1r7kOACx5hUAowoA7KVCxz22rFRpWn7iMzaVHbMN8KRiWhAC1+I0NfXvrIFoWoFmuV4/v/a3KuVRGnVbyLrNCM7xih2oWDY+JCUOcz+A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199015)(5660300002)(186003)(2906002)(8936002)(41300700001)(53546011)(6506007)(26005)(6512007)(9686003)(33716001)(82960400001)(38100700002)(86362001)(83380400001)(85182001)(316002)(478600001)(6916009)(54906003)(6666004)(66556008)(8676002)(4326008)(66946007)(6486002)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R0phakhjdTNZT1JBSnIvcEpBbmxMNDJKdFNMU0JsZXNZUDgwRXROWXpuMWgx?=
 =?utf-8?B?bGFNVTl4UjNWWm9GTE82UTJPMHNCc0QyTWQwdkdIdG9Gc3BCS2gydlh3Vkkr?=
 =?utf-8?B?aVVCQW9yZFB4ZVJRK0ZFc3IvbndnUmZ2cWJmOFVxSE1YU3VQRFcvZDJrTXdi?=
 =?utf-8?B?Zm42Mlk2TjQ4VWhDK2tkbll1MnJlTjYzVTBmbWVTNkJPRU5OL1o1cjdwc1Vu?=
 =?utf-8?B?ZzVGbGpESVdxaUdrN2RkUFZha0MrRHhyVDlkalc1K1JCMkdFbFg3Um4wc0dT?=
 =?utf-8?B?eE9jWXZsUkRDOXNXdmhINkZvYm52ZVpmbWJzcnlBcmV3SmFCSW5BaTF6dnU1?=
 =?utf-8?B?YzdSZkNkQ3NoUXpPWHZrK1hXMmhtc0lkeHNNZW5MUjE2SVBQZEpFUkZKdktZ?=
 =?utf-8?B?WjAyOFFZYUMyTGRpZmFOVWFFdHhqQVJLZm1GOW12aC8xK29Dbzg0Lyt3MWJF?=
 =?utf-8?B?Qm9EaGlqeHpTb2pjTzNZQXM3ejZMcEtvT3RrTFgxWGFZcy80RzlBWGlnTThZ?=
 =?utf-8?B?bGFybnpkQk5YSVFxUk0wNU5JL041a2xaRXNVOFRpNXZtK2drVE54Mm9MU2FQ?=
 =?utf-8?B?UHB1Vmthd0V1UG1kdmxMTjIyT3J4QkRPQ282eU9ENXppb3d3VE16anVNWEYy?=
 =?utf-8?B?bzBzb0o5cEo0OXltOGM2enNSVG9hSW1BYWJDUVdtQXU3ZDJMQWs2VWJyMS9x?=
 =?utf-8?B?OEt6aWNHbHJEc1JPQkoxdTI1dGgzMC9IcXBQOGRzQ2FZQXplNCtzOEtqUUs3?=
 =?utf-8?B?OWxpcmVZYnpKVFJqakhZS0JhVm1vdmJKY2dmQVdsWjR0dnVNRGhDMkJDTXlT?=
 =?utf-8?B?d3k3TWYzSmc3czN4SDd1RTFaSGJXRXJsaVVjKzExbDdVRldkTWJLaFlhQTVX?=
 =?utf-8?B?cW1nSkRLK0lEWU8wU1ZaVWVweTQ2Vy94ZC9uNTBTM1d0QmNhQXhTY2hNczZ0?=
 =?utf-8?B?V3phbjVFcC9ZeVA3SUVtblNTd0pjRkM1b2FNc3BTbzNCT0oyVXpjR0NWWS9i?=
 =?utf-8?B?aHRteWlrYS9oQncwYWFCeUZJNkVhZHp5SkMxbkgwVXc4OUdNeTBMWWJ2VllD?=
 =?utf-8?B?K081S2lXL1dDK3BZcnppcXFCQ0UxZTVrZjZKbzc0aXl4eWhKZTlvVFZYQXFQ?=
 =?utf-8?B?UUlmSy9ENkF5VFRwVlNDTUwvSU9BYVN1Uk9qbVVKS254VlBVUDhpQ2xWZmVE?=
 =?utf-8?B?d2N1K3pNQnQzaHNCTWdLclhYcW50Y043SnNZTjZFOTJrcy8xbk90T3dIcVNl?=
 =?utf-8?B?aUp2cVMyNHJmNm1EczhKSFlMaGZjQ1NOQ2VhcUFhUFVyTTlsT2hTWk5ESmFB?=
 =?utf-8?B?S1lNejVVNHRBMitpWkZ4akNkQ25jYmZzVG52bDc2YkpNVU14K0dlOHB6bG5O?=
 =?utf-8?B?TWs2c3ZHQzRtdCsvUC9sOVIyZUdqR2IweEgxa2QxVWNjMCs2VGRtRm9BME9M?=
 =?utf-8?B?aWU1YVRBNnJaT1QrQmhoZnc2NDBvUUhvWTBhWjZlc2R1a3JiTzR2aFVDaVZk?=
 =?utf-8?B?a0pZaFJNYUREUGoyMDdnN3JNaUVleUt4VXhKaFg3ZGpHSnFPMlRQM09TeXdT?=
 =?utf-8?B?S2hZUW0vZzc4WFd6Y0ZrV2dDcE5ONVRxZ2p6RXFiWjU0SUtDaFQyNzd4b1Vk?=
 =?utf-8?B?bVc5TkljNkNoTjZIZlNQMzZLalc2OTg3Ni9RS2krL29hbTF0eGRMS3Zkb2Ex?=
 =?utf-8?B?Zkt1SEhXVnd5SFlDMDdrcUR3Z1NIa2NMZ1dIcnNPZkVnT1A0NDVGMWJWZFdZ?=
 =?utf-8?B?OEZtVnZiTnZDdHRFTEtPZG5HV1FnMFJ0VVFPUGIxUG5xclIrSVV6MFdCUUhl?=
 =?utf-8?B?NVNyVFFIWTZCY2g5dXZCbTMvaXhlVGxwcUt6aUJkbFBuTDBlM2tvQzc1YW1U?=
 =?utf-8?B?VUU1YVZuc3ExRXR1c0hMOFFmQ05CVkpTdzR6d25rdy9idnp2TDB2ZU9HODdh?=
 =?utf-8?B?Z1dwOEhBbE1OMjc0cTZubUl2RE9xS0NJZUNDVGgxN2w5THdvK05KM3l3WDA3?=
 =?utf-8?B?S21zREN3bW8zMURheTUvMk1hWGV0YUN0dCtSQ2hQclR1d1IzL25iM3UxVm52?=
 =?utf-8?B?MjhMQ3hvdkNMQzcwa2JXZlgxQWNNcTNBa29OTVM2cFNqTWZycFZXc0lVSHNs?=
 =?utf-8?B?QWdmaC9CbjNtTWRNSWZNbFBGN0FVcE81YThTYldrT3lxZ3BCSnRmelRVdW80?=
 =?utf-8?B?QlE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afb17ae0-515b-43e2-b905-08daadbbc3e1
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:11:58.6467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gl95H7IYH278nl8cYHtjv6+drlvH40hh5XicZUFOprB0hHhtJ+LWoopyftjGIPsvh+XlKOt8LtfY5JiFsdTkWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6651

On Thu, Oct 13, 2022 at 04:43:15PM +0200, Jan Beulich wrote:
> On 13.10.2022 16:06, Roger Pau Monné wrote:
> > On Wed, Oct 12, 2022 at 10:36:57AM +0200, Jan Beulich wrote:
> >> On 11.10.2022 18:02, Roger Pau Monne wrote:
> >>> --- a/xen/arch/x86/cpu/amd.c
> >>> +++ b/xen/arch/x86/cpu/amd.c
> >>> @@ -814,7 +814,9 @@ void amd_set_ssbd(bool enable)
> >>>  		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
> >>>  	else if ( amd_legacy_ssbd )
> >>>  		core_set_legacy_ssbd(enable);
> >>> -	else
> >>> +	else if ( cpu_has_ssb_no ) {
> >>
> >> Nit: While already an issue in patch 1, it is actually the combination
> >> of inner blanks and brace placement which made me spot the style issue
> >> here.
> > 
> > Oh, indeed, extra spaces.
> > 
> >>> +		/* Nothing to do. */
> >>
> >> How is the late placement here in line with ...
> >>
> >>> --- a/xen/arch/x86/cpuid.c
> >>> +++ b/xen/arch/x86/cpuid.c
> >>> @@ -558,11 +558,16 @@ static void __init calculate_hvm_max_policy(void)
> >>>          __clear_bit(X86_FEATURE_IBRSB, hvm_featureset);
> >>>          __clear_bit(X86_FEATURE_IBRS, hvm_featureset);
> >>>      }
> >>> -    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) )
> >>> +    else if ( boot_cpu_has(X86_FEATURE_AMD_SSBD) ||
> >>> +              boot_cpu_has(X86_FEATURE_SSB_NO) )
> >>>          /*
> >>>           * If SPEC_CTRL.SSBD is available VIRT_SPEC_CTRL.SSBD can be exposed
> >>>           * and implemented using the former. Expose in the max policy only as
> >>>           * the preference is for guests to use SPEC_CTRL.SSBD if available.
> >>> +         *
> >>> +         * Allow VIRT_SSBD in the max policy if SSB_NO is exposed for migration
> >>> +         * compatibility reasons.  If SSB_NO is present setting
> >>> +         * VIRT_SPEC_CTRL.SSBD is a no-op.
> >>>           */
> >>>          __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
> >>
> >> ... this comment addition talking about "no-op"?
> > 
> > We need the empty `else if ...` body in order to avoid hitting the
> > ASSERT, but a guest setting VIRT_SPEC_CTRl.SSBD on a system that has
> > SSB_NO will not result in any setting being propagated to the
> > hardware.  I can make that clearer.
> 
> I guess my question was more towards: Shouldn't that check in
> amd_set_ssbd() move ahead?

Right, I assumed that cpu_has_ssb_no would be exclusive with any other
SSBD mechanism, but that doesn't need to be true.

> As an aside I notice you use cpu_has_ssb_no there but not here. I
> might guess this is because of the adjacent existing
> boot_cpu_has(), but it still strikes me as a little odd (as in:
> undue open-coding).

Indeed, the whole function uses boot_cpu_has() so it seemed clearer to
also use it for SSB_NO.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:18:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:18:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422545.668633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFtU-0002kX-Lv; Fri, 14 Oct 2022 08:18:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422545.668633; Fri, 14 Oct 2022 08:18:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFtU-0002kQ-Ip; Fri, 14 Oct 2022 08:18:12 +0000
Received: by outflank-mailman (input) for mailman id 422545;
 Fri, 14 Oct 2022 08:18:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qaRP=2P=citrix.com=prvs=27923c854=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ojFtT-0002kK-41
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:18:11 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bc1ca8de-4b98-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 10:18:09 +0200 (CEST)
Received: from mail-bn8nam04lp2046.outbound.protection.outlook.com (HELO
 NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.46])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 04:18:06 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by PH0PR03MB6707.namprd03.prod.outlook.com (2603:10b6:510:112::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 14 Oct
 2022 08:18:04 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 08:18:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc1ca8de-4b98-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665735489;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=4jyx/AObIsj50tmPt62GgwWyVO2DPfwXL6gDvX46iIU=;
  b=LmpGYgPFvRo42/U8YERuq5GEa+OgpvRnNWqMYGcE+WuHPRwF6uwXFgEZ
   IUh7wAr8yeX2RqDXOdH/Kg0Fk7VrBi/N+2LxJmrrA3cbQmhDev1pJyNrj
   xy/vSjVM0XfGjPhOjIk+1shJmsPeYMmKr2+l2cTFISb9h5xcOzZaALCLd
   w=;
X-IronPort-RemoteIP: 104.47.74.46
X-IronPort-MID: 82735091
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AGwi9+qimyW/++j4BdbAoKco8X17brhtdWV5mu?=
 =?us-ascii?q?6ucuGbUl+iq9fh2pTMDcFHA35ufnh6Jk+R9yDHLOZikrGOzboqUZ7KlaGJhR?=
 =?us-ascii?q?0l5uglbU/B30HVF8LDmH4j3m4S3p2kRb3rQKsyNEE36syHTNfqalk688f8NV?=
 =?us-ascii?q?j5fV+GWd1ZQKN4p/ju1B2oyEBVmzF9Hutc95u7GD/nNscv9DWiYHx+EgqHaL?=
 =?us-ascii?q?zFPIddPzukIWmGu+60GRFH6EYfVnXWu1LbpUJXr2c9Cs5W1GXHsXqv2CUJ1B?=
 =?us-ascii?q?P5kyK7MxigM0fPW5cofyO6o8Plqx2lnBGrmTE4zQaySS7KAtcQtWSUBgOJLv?=
 =?us-ascii?q?GnolsRGmx0m9/hM7SQWMWUz7/gcI+OzBQHs/h2FZgt7vA5rcOXNZCF2jfl0u?=
 =?us-ascii?q?fzyPPZV/jOLe46eE7/5o29wNXEkylX3cDQKjEtCW8Zk0aaroFehplQt3DJwH?=
 =?us-ascii?q?OCdv8TsawgxCy56n/suSk+RtctuOyw+Z2zNSwjx5c8NO6ruBS18xj41NZzNT?=
 =?us-ascii?q?VxzBX4/vp3hChoqrFBZiyhTUMXk/G7wY3Ndaq/iFRXFXS9G91TEjRqI88dRh?=
 =?us-ascii?q?4x3uCS/H0dVjwLGjqhZ/9yjNs8wt3ZFM75VMt0Wj/D8EI4PR9Ye33rqnfcsI?=
 =?us-ascii?q?IDpZl9269pc7X6ELxwPZIxtuj5V3xwtyAItEJCSMw5kkeWnsYB9XxpTPv2fU?=
 =?us-ascii?q?oDWwjDL+ImcO2veb12MEhA+0ob0PSeAGJZUBMCUb/yVNF5zHdqSfYWCSY2I0?=
 =?us-ascii?q?8h+gDzIm6LXVfN4DlljTOwP4BkY2jHZo4IvQMU82ORdYZaWQ0waLkKSjUhBJ?=
 =?us-ascii?q?qfnkCdjVmaHCXDC/j49pmK2xeo4+e4iMhScFmPf5L0maAo7QjVeCoSnPYC49?=
 =?us-ascii?q?O5XQ5vSprc44v9BCceQYgpAMJeoJZ1qR2WxYmEkVEjZKJFCeHpcvjDx8pigR?=
 =?us-ascii?q?RdrrQx70PMYJ4k/LX3xKCvmRyC5bBwcmEzZYViGDAGyWF6ifi82RsA8hk0pw?=
 =?us-ascii?q?1GJmg/cV4qn1TGeJ2mcyaOmBFU8ggDkOIGVlSVH3VsBc7kGH4xKm9FCbq503?=
 =?us-ascii?q?kZPwRLp5nLI3RSFjfw+2IGce53ieKWMSm+lnto4YbOuNsL69KXL9s99FC9wY?=
 =?us-ascii?q?g/MrjydzxTJz4LXtCE/SpZEwAm1t3weSSD+elaHs/Ja9aCNki2/NtezfPOLU?=
 =?us-ascii?q?zkSeap7NNKLUpi9N3U+iJtyFb9+UPIPCdrEotMF6FdBPRbZ8EG+imXNUEgh/?=
 =?us-ascii?q?K4JDkbxiQflUh64z3iuysBMwaZWFjF82MndLH+OyitCuRJ6n4OqreV56hFkp?=
 =?us-ascii?q?ZEztdz0KySvGF7MXAmitS88uOhgWPeRm4CsmID35CHpuT3UpJfd+r4UEQTZ8?=
 =?us-ascii?q?lnNvSEKxlrsWrtnrmC9u61cSNZB/t9WgSeTF8CNDqKVBlDQa/npzlvzfdpzj?=
 =?us-ascii?q?eIspfJ090bdXJeXw5ZVglNUbAJvr6u9gHu2QRX8YA8iiKrQzLOgmzpOoilET?=
 =?us-ascii?q?5kv4ftI01+yDWNRVAQdhyAktrb30eR5f8Bw8mchwqsLqmUtzhY7VXVLVGhri?=
 =?us-ascii?q?7u0QHJQ4gjA7HXbQguWGCCdABeltn9OsW9Xb6ExYoi1ug36bbEyIKF6XOAvy?=
 =?us-ascii?q?AiTnj6igeJs1Cb8REw2ZHpsZbhei+QED6zMe4ZBlb9rzGoVC1eV8axHjP/Ud?=
 =?us-ascii?q?bwbiW5aawJtC9fCzPiFVokcLhIasByid9WmmyZfGIgeMEL7OfSbjQiZbMTI4?=
 =?us-ascii?q?635xfTHX94m1fUJXFLK14VKTpVc39N2Bi23G6pzQGcPu5TKXvR/T1XaXLfZA?=
 =?us-ascii?q?XtlLNrBWMCW2Z37yDB0XCex1s6Kg+hXIi+2e6QY7ErikVpRRAVhof5TBzqHQ?=
 =?us-ascii?q?+YjzafvBACO7t0DkyEFddLoKqN8cot3/VKGcBUB3C/dv48JSMkm3Dy/qqMU/?=
 =?us-ascii?q?f4L4naMGTeDusAW5V5NtJEffzpjmQQrurb8zKHG07/5N9prCkmbNCkcqJu04?=
 =?us-ascii?q?zyN/YzvvjOYJU8cd6o3/8zEISxapW66MUlnALa3IyRLnrW3Bm5K3YtFPOEEv?=
 =?us-ascii?q?12dhiDqXx5YxxuSIQJqubU76hHuJV/483fzbS2guB6TqByH+FXxL6wsdukgQ?=
 =?us-ascii?q?C+e71btBB6IAYiXEoGksftN/SYib9lJBJrJLM7ZorwfodLmnjUw68vRrZ4u8?=
 =?us-ascii?q?0zUBj8AH1eW+y4I6jjX5zZwbyj+k8dusEt0smJC0ykpDk56cgcQwfxa0aLX1?=
 =?us-ascii?q?UrvR2ecAI0KP+kvjNt+vgwTEXu1wv7dUyVWLHVobMHB2Pjl7pDHWrgUBKdg2?=
 =?us-ascii?q?T+qFhIBG0q+eX3jg+uRYUffxuYphHK6juwtMR+CF2bDG2/Vy+Qamqc/LGZ8k?=
 =?us-ascii?q?ktbxqgyEOHIkN770SY2z/aUH0gL7BRw0EWG9M14591GbBotnW07cGb+vIrBM?=
 =?us-ascii?q?KLSa6EIPit42gPVMddo3Axr+96QPeaDCSbDx22Pq0d1cR1bMMpGGSxj1/zQZ?=
 =?us-ascii?q?KEFbzxmTOiJ3zg/BfAvRxf66RKgKmz/ioUMuXjGLHlnJqX7opjRYgmZqCVrY?=
 =?us-ascii?q?3j+RHMsusuu3lMmqJ5aOlJkgpTT?=
X-IronPort-AV: E=Sophos;i="5.95,182,1661832000"; 
   d="scan'208";a="82735091"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IhKHrYg2oBBOysni504evTu4cz/P6+mO1Y6t24sptElJ1tVve/YSlt5xC8QyD8CKTflim0IKqDJuom1CQ5uBGyUV6TnkGE/D78kMKwNgFveIjvCHJyTPrEDQVEG/z/ggcvD/tsMloM6xf4H+SXKCsvyyzAxcofLMulHB0sfyAEguWmczeWMLZL1hlvHhtxSbHMzwStq887AfOeQ6AYcgpsmEe3eFkZ2fDb3Cp+w8ldnCioeMTeFpqynzcjaAwmHtnDMVQoq5+0qhvgdlxy7DjVyqONacwGMRrmxE7ckOpIi4RSfT7LmOA1OVuwLGCzOX56HL5NOwSmCtMFtE9bsTsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SlnNNg6TyD5S9ZbHSyaEVYakE2qCZoQhS55Ro3auFTc=;
 b=I3xj0ZhB21SXFolg/5+TefRLAsflrP3k8+ZKcT6aa/XxVANVzUV0D1HWTXoMJgFfXpQmEV8omeo3Y6QjXxXGSrJvMCP5Aar665WTbBtDaWbLyu2SHCWuYfg5Fw4+fDCyy/aJjwOQJza9k2hk8OidjIw51NXZ47i3mNZj17EmiMdCAJqbzkCsGjOI+sXpe+6E+zxa2oxA60Y+KXv4QbclTqdRgfG2Antk33nSnZdUZrTbKgtAqJxrLHep13WqyyW3BpF145uOuhW+7vWvIDssjBb7eTDyqCHYaq8YOByd2Y02MACFxhZQd7rJfSJgUfDH2QEHrHgpwhDpkLZSjjhZkw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SlnNNg6TyD5S9ZbHSyaEVYakE2qCZoQhS55Ro3auFTc=;
 b=vd2NDrubQO62eZHUSb2RkoTW/D71kb0KRNh3u8DA0d33wsadWP7f7rnc+fSYNsSFcoH4rzE5pKkU3M0SF7GOxCyWWcGEMXnyKQlo4KzSCcQq+ahQXyIblUMMD+gI4aSIEwOWH/h98/V2SZu+FN5oEqnutK+8zC4svfY+EK76dJI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 14 Oct 2022 10:17:59 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Henry.Wang@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Message-ID: <Y0kbN+Zp6F2kBFGz@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
 <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
 <Y0gXnD4jsyIp2kKb@Air-de-Roger>
 <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
X-ClientProxiedBy: LO2P265CA0231.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:b::27) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH0PR03MB6707:EE_
X-MS-Office365-Filtering-Correlation-Id: 253555e9-c20c-4503-c8f8-08daadbc9d74
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IH2j81NtTHp8LKQMVVyA1GgMR75e9GO4QiOwhGYBgVi9OVrnzCVdRiPSZVx1dYni8QUjWgIbabmzU8IqRWZ/PrJBaDzJwulV32C6NKVXAqpi5rm7uJ37EBVnaiujDjWvznHJ9iYlZMfSlyw20lzYOEzKKq6SZ20+DyELTpHd83q/RT/jhOsBvC0iideBfnLvlu0wiDOLBHdaKgzOvE8Pjv64yHNmDLtKT6XQhXqkXGAY+RKcQRPQS+7cxQs4RdJPj62lJO1hVrwLYDhnxbOxrMfuuBXxdEo7idVIdT1aWGqIPp8aAKCo6qXEGFXZUkbnGZ9xHbRYJOOm9essJNf76fy5HOZHaP9wLzQ7bNl8NfHrgb9m+a69kCXaFEHuA+F9mrLLThgVEQ47B8xFU90JC9YtvEX7HaM16xc241KJv+BPyhAnVjlzPzMx2zfZOWp1p7i7LXF5I375SO7bwsrqyt2A8p1skj/37d4ssdwiBgdeCH1RiuCSfLQAENyBcx2kK7zb5ElMOFjeJRnclGFmOQiesJr2gev7puSFYsX9ejKkQpULTneicGANU3wbPacqnS/v5Is4JncdfBhdesqwpoPttMx1UrleS5vnMecCXlSTv9wQWWYKrR3288m/vugm9sKL1Zqr3CsJsYiQFYR/s0lZetgWnElCvzbfV3Y5KTB6W1uhYSkFoQiAt2LsLYil/sP9V7+Fne/KsC4J4WDYbIiSU9ByzeultSt4Of98NmRG3r3hWEln7InY8CBp7yll2YJ64pPPRWTyi6snfhDxmg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(66476007)(53546011)(26005)(8936002)(6512007)(86362001)(33716001)(4326008)(6666004)(85182001)(2906002)(8676002)(41300700001)(83380400001)(38100700002)(6506007)(5660300002)(9686003)(186003)(82960400001)(66556008)(478600001)(316002)(6916009)(54906003)(66946007)(6486002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RjB4VHA3YTczNjFwRHRsajhpeXQ0VG04SU9oMnNCN0t3THUxUXVBMllvMVFZ?=
 =?utf-8?B?cXFOUWRRMGFXdFY4clQrbjBZK3QzUG9ENVRLYWprUGgzQWY5WDRXalZDTnFq?=
 =?utf-8?B?VW1PbXdjcHFydk1xL1pzbXhQM3VVYlFoRnl2SjcrYWNMWEhxS2tDNmRLOEtX?=
 =?utf-8?B?T0MrYmhnU2Nub1ZuOTJ6YXNGZTFhNkQrM0RMMHZ6azZ5aE1UUkdOUTdMM3Uy?=
 =?utf-8?B?SkRSWWZDaHhYZzh3UkxEaW1NYmJEaWZhTmEvaWRWaFBvcWhoWk9DU3VWZTV2?=
 =?utf-8?B?QW1XdStjMTlIOHFZb1VXby8yRkxGZk1FOUpyTUhrK3l2b3poZS8xTktTZmQr?=
 =?utf-8?B?NjRQRjdyS0IrOTVEZWFCZTZubFpIUEVuRGxRMVNVZ3o2cTQvRUJjN3pMV1Yw?=
 =?utf-8?B?Z0xLNUY5ZlNHZk44OWt6WS9jK21XWDZHdUtSSndHc014eDVLdDFzYWdhT1BG?=
 =?utf-8?B?c2kxU3RCOFJ4UEhRWXJpTFVUM0kyR0ttS2krMHBsUlJBenZTZTNGQkZnN0lV?=
 =?utf-8?B?UTFtZG50STZpeGZ5RU81YVdYVU52RlRjeTlvd3dJMktBbmZ5bUlWRk1TR2xr?=
 =?utf-8?B?c0ZyN2UvMGZkdWFYU0VMYklHNkxlRW9PVE1wK2ZCSDl2cUhPYjRjOFljdWJT?=
 =?utf-8?B?ZDBna3JzQ05uQmxrMmNmZ1A5NTJYRUZudHJGSXE0ZitkNGY5REFydGl6VHFZ?=
 =?utf-8?B?aXJ4VTFyU2JYNEpjMlBoQnlrU1lsK3pNckYzQ0NxTlA2QmVHSWJ6ZHNwU2NI?=
 =?utf-8?B?L3ZXNzgyYmp3NmlMcm1YRGdJc3NQaVVqVWFLWW9TaFN2bFoxcXF3VVV5YXl0?=
 =?utf-8?B?ckhEMUVCSkp1NFphOWRlem5tWXJnakpnSjdGUGI0YjlXZ0tGQXN5TitCNERm?=
 =?utf-8?B?NkNNRTZITUZyc0g5cGZPdFd6K0xHRUw3djFlTm5lSDkvOE55RlI0M2VLR3ln?=
 =?utf-8?B?dEtLbEJEQ0ZnbVlDUSt4ZDA1ZTczTDFBL25BZVlkai9YRnZaRzV0NGVCY1ZF?=
 =?utf-8?B?M3JZb3B0UTRVTjJsVHNqeFJDU2NxZEtTVDl6VDFmc0RFUUE1Q2s3V1N6cmo3?=
 =?utf-8?B?VEZxRkdmSVhnazVsVkZxbWlvdy9SS2sxM0xoOFZBNlNTUUhIQ3R2MW02cEZs?=
 =?utf-8?B?SGlzMFV0ejhSQ3dkVVhRNjFZdmtjNTZnMWwzT1FWVkpnQjBjTWQ1NXhpZjFH?=
 =?utf-8?B?WDJ6SUliL1EwemozWGZaSnhSSGwzekFkeXV4bmpiMHBCak5VRU4zSXRzbE5x?=
 =?utf-8?B?d0VRb3plTklnZmlGZHhGQStoR0dqZVg0VjJqRURVUW9NRGlVd1BndmxVamkv?=
 =?utf-8?B?VzE1NjFRYmlYbEE4ckdwaFVGU1lHamdwREE4dGF1NGNjd1lMN3ExYlZDelVp?=
 =?utf-8?B?UTN3Wm13cXdWM0djSXVTWkxwVm9hajdROWNVWmswMVk3dkZkS09CTFRxVlNx?=
 =?utf-8?B?SHk3VkNxeE0yTzE0SlNUMENleHFHOEswRVFLNzhRZGVkVXNHQm12aXJPa01H?=
 =?utf-8?B?QmplZjNzOC93Q3paM28wejV0enVlN2diaFNCMnNWVU40cVQyenJUOU5lMVJL?=
 =?utf-8?B?TW9LVlhEaitiNXNDMS9iU1RGVTdnL0kvcTVtS2Vybkl5K1UvT3NXbWw0cEJQ?=
 =?utf-8?B?Yjc4L2tXcnQxQjZZL2NXVlNiSCtEVStScG4zejJ4OVBDbm9mRXM3NzRpTWdj?=
 =?utf-8?B?MnFGZHlySDRPdU4wVXptZm44cCtuVFhlMDBsTnIvemlsNVREZlVNSG11RXly?=
 =?utf-8?B?OUZQb3VLUEM4RW4wK2ZsVXlCOUF6bGxvcXlyeEdncVNoM3FYNWNPa3pGTVo1?=
 =?utf-8?B?Q2hFNllYbFFWV3hTNndTc01tTU9yQ0YrQy9ra1pIK2l1Rm01dFhkekhManlN?=
 =?utf-8?B?V2FGRnRpelZJYXd6eW54V3ZMSFI5QVBaVTlTRkQ4N0ZndGE0Y2VrUnpidHRw?=
 =?utf-8?B?aElVR00rUnNCZVVFL3huSkhUVUdQbVBlTkNmbDk3VWM0NVBvYTdWc0ZERXRX?=
 =?utf-8?B?YytCQjB6ZFl3d2QveDFBQkFhaFRZSWJkQUpReFdDWFd2TVdCQ3U0MnZtWkpJ?=
 =?utf-8?B?U25aMktVQ3FjSXV4S2lRVVVOMnlIczBZRFZuVFFIdzFReVY0Y2MxaUxBeHdh?=
 =?utf-8?B?d2owamQ5MFRUS3NsVnA5UEFaZDBFaDhod2lFODdDa01vN0c0akFoMVFuaExi?=
 =?utf-8?B?VUE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 253555e9-c20c-4503-c8f8-08daadbc9d74
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:18:03.6760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 66Q7k6zXRCYxC/aNnpBJM9m2T+xJ9rSdYx9qXtC0tgctRnjIs5G9MbyYc3azqxVW+jMegRCj5DWDs+XLWFJH7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6707

On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote:
> On 13.10.2022 15:50, Roger Pau Monné wrote:
> > On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote:
> >> On 11.10.2022 18:02, Roger Pau Monne wrote:
> >>> @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
> >>>  By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
> >>>  when hardware hints recommend using it as a blanket setting.
> >>>  
> >>> -On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
> >>> -option can be used to force or prevent Xen using the feature itself.
> >>
> >> Why would we want to take away this level of control? Shouldn't we turn this
> >> on while in Xen if so requested? Which would then either mean enabling it on
> >> VMEXIT if a guest has it off, or running with it turned on using the OR of
> >> guest and host settings.
> > 
> > Right, but then we need to context switch the value on vm{entry,exit}
> > which is problematic.  I could move the context switch code code out
> > of the GIF=0 region, and assume that NMIs executing with the guest
> > selection of SSBD are OK.
> > 
> > Alternatively setting ssbd= on the command line could be taken as a
> > value to enforce for the whole system and prevent guest attempts to
> > change it, not exposing VIRT_SSBD, AMD_SSBD or SSBD (haven't
> > looked at whether not exposing the SSBD CPUID related to
> > SPEC_CTRL.SSBD will have impact on other features).
> 
> That would be my preference (albeit I'm uncertain about the "not exposing"
> part, as we don't want to misguide guests into thinking they're unsafe or
> can't guarantee safety when requested by user mode code), but ...

For ssbd=1 we could expose the SSBD controls, as the guest trying to
turn it off would have no effect and it would still be protected.

OTOH if the user sets ssbd=0 on the command line then exposing the
SSBD controls to the guest would be misleading, as the guest setting
SSBD will have no effect and thus it won't be protected when it thinks
it is.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:22:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:22:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422552.668644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFxU-0004DF-AY; Fri, 14 Oct 2022 08:22:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422552.668644; Fri, 14 Oct 2022 08:22:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojFxU-0004D8-78; Fri, 14 Oct 2022 08:22:20 +0000
Received: by outflank-mailman (input) for mailman id 422552;
 Fri, 14 Oct 2022 08:22:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojFxT-0004D2-A7
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:22:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojFxQ-0004F0-7e; Fri, 14 Oct 2022 08:22:16 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojFxP-0008FO-UC; Fri, 14 Oct 2022 08:22:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Nzd/rJw4tROs083lJjBEgOt4IXOzidyElLr1agx4fUc=; b=k2kqJC5w3prWlY1xlbG47tejTH
	6t2mPwOYVe2RShh59j+cJtaC4ODpBkDiNFsS9wxCOLuXr+J7nq0rQpae8xuB4RYUrLM+ZQ3o2tYYG
	PfsXGMvZctAiRA2BcWNiBSTjvusy+3VC16JR8m2YX5gpjGKQwcUaitYtz3EP7YWgbvXU=;
Message-ID: <5f985e76-e817-5d44-3463-ffc0a98c407c@xen.org>
Date: Fri, 14 Oct 2022 09:22:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 Stewart Hildebrand <stewart.hildebrand@amd.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <0ade954c-5741-754c-fc59-177feb67ddf4@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <0ade954c-5741-754c-fc59-177feb67ddf4@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 14/10/2022 08:16, Jan Beulich wrote:
> On 14.10.2022 04:53, Stewart Hildebrand wrote:
>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
> 
> I guess a non-empty description and a Fixes: tag would be nice.

+1. I am actually quite interested to understand how this was spotted.

The build system should check that any function/data in domain_build.c 
are part of the __init section. So I guess the compiler you are using 
doesn't inline the function?

If so, I am actually surprised you are the first one spotted this... We 
are building on various distribution without any issues (?). I would be 
interested to know the compiler version and maybe we could add it in the 
CI.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:35:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:35:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422558.668655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGAA-0005rd-Em; Fri, 14 Oct 2022 08:35:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422558.668655; Fri, 14 Oct 2022 08:35:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGAA-0005rW-Bn; Fri, 14 Oct 2022 08:35:26 +0000
Received: by outflank-mailman (input) for mailman id 422558;
 Fri, 14 Oct 2022 08:35:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojGA8-0005rQ-U5
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:35:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojGA6-0004RP-DN; Fri, 14 Oct 2022 08:35:22 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojGA6-0000LB-74; Fri, 14 Oct 2022 08:35:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=MLU3um5FtNsxGU7b3TCOORnq16lZtaM/jUFycCMHrY8=; b=ub04MmmndVrdMibdQ95PLPEEXV
	K9is6znfvBhxhpOD1YWf8GxyuiW2Ai9DfIp7TJPOtU8YJl9xUsMbanzPAd5IVQY2DtxU2/lYlqup3
	o9irPbDhjIt8iGklezsqVG4AfFx5PFVVX6jbl9vkqHLCU0oO7M3B8hqth7RR36p/aBCs=;
Message-ID: <a4a8fa5b-afff-0a49-7c06-b9be82669aac@xen.org>
Date: Fri, 14 Oct 2022 09:35:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as
 supported
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 Henry Wang <Henry.Wang@arm.com>
Cc: xen-devel@lists.xenproject.org, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-3-Henry.Wang@arm.com>
 <alpine.DEB.2.22.394.2210131655530.3690179@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2210131655530.3690179@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 14/10/2022 00:55, Stefano Stabellini wrote:
> On Thu, 13 Oct 2022, Henry Wang wrote:
>> With the P2M pages pool bounding the domain memory runtime allocation
>> and the documented minimal size requirement of the static heap, it is
>> safe to mark static heap feature as supported.
> 
> Usually we wait at least one release cycle before marking a feature as
> supported. However, I can see that this case is a bit different because
> effectively static heap memory is a safety/security feature.

Even with patch #1 merged, we are still missing some information on how 
to size the heap. But see below...

> 
> Julien, Bertrand, I'll let you know decide on this one

It doesn't seem to make sense to security support the static heap when 
allocating statically memory for domains are still in tech preview.

That's because if you want to have your system security supported, then 
you will need all the allocations to come from the heap. At which point, 
restricting the heap seems pointless.

So I think it would be better to wait until the static memory is fully 
supported.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:40:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:40:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422564.668665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGF0-0007JA-27; Fri, 14 Oct 2022 08:40:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422564.668665; Fri, 14 Oct 2022 08:40:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGEz-0007J3-V1; Fri, 14 Oct 2022 08:40:25 +0000
Received: by outflank-mailman (input) for mailman id 422564;
 Fri, 14 Oct 2022 08:40:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojGEy-0007Ix-FW
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:40:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojGEy-0004Wa-85; Fri, 14 Oct 2022 08:40:24 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojGEy-0000XM-1u; Fri, 14 Oct 2022 08:40:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=59aBtbK0SShx/lXL0eXqY2HWTS+Vxh7xLezeI3iC1dc=; b=YcoEhIcVkGm23ZOKFyWIue9Btq
	Ge3Wjm60qPX6ctZG6oxqdhynKBI145lFG7x5Eu9ncQ+NHESIaMFa67lER/bITY6zpgqfrh3TdRGP3
	rDO3PoRFPhR+PLM1K0Xllzy6TDTL5TG1xBI7ZdbNN80D4SmpCffC2QpwolZiBnvJUwmQ=;
Message-ID: <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
Date: Fri, 14 Oct 2022 09:40:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-2-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221013025722.48802-2-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 13/10/2022 03:57, Henry Wang wrote:
> The static heap feature requires user to know the minimal size of
> heap to make sure the system can work. Since the heap controlled
> by Xen is intended to provide memory for the whole system, not only
> the boot time memory allocation should be covered by the static
> heap region, but also the runtime allocation should be covered.
> 
> The main source of runtime allocation is the memory for the P2M.
> Currently, from XSA-409, the P2M memory is bounded by the P2M pool.
> So make this part as the minimal requirement of static heap. The
> amount of memory allocated after all the guests have been created
> should be quite limited and mostly predictable.
> 
> This commit adds documentation that explains how a user can size the
> static heap region.
> 
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> ---
>   docs/misc/arm/device-tree/booting.txt | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 87eaa3e254..046f28ce31 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -531,6 +531,13 @@ Below is an example on how to specify the static heap in device tree:
>   RAM starting from the host physical address 0x30000000 of 1GB size will
>   be reserved as static heap.
>   
> +Users should be mindful that the static heap should at least satisfy the
> +allocation of the P2M maps for all guests. Currently, the minimal requirement
> +of per-domain P2M pages pool is in-sync with function
> +libxl__get_required_paging_memory() (for xl-created domUs) and
> +domain_p2m_pages() (for dom0less domUs), that is, 1MB per vCPU, plus 4KiB per
> +MiB of RAM for the P2M map, and plus 512KiB to cover extended regions.

I think this wording is OK if the feature is a tech preview. However, if 
this is security supported, we need to provide some more details about 
the size.

In particular, this doesn't tell a user how they can find the size that 
would fit them. Can this be decided with a formula?

If not, could a user configure his system without the reserved heap and 
find out the memory usage from dom0 (or a debug keys)?

Cheers,


-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:45:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:45:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422570.668677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGK8-00080m-LX; Fri, 14 Oct 2022 08:45:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422570.668677; Fri, 14 Oct 2022 08:45:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGK8-00080f-Io; Fri, 14 Oct 2022 08:45:44 +0000
Received: by outflank-mailman (input) for mailman id 422570;
 Fri, 14 Oct 2022 08:45:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qaRP=2P=citrix.com=prvs=27923c854=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ojGK6-00080Y-MJ
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:45:42 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 941aba8b-4b9c-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 10:45:40 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 04:45:35 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB5165.namprd03.prod.outlook.com (2603:10b6:208:1e4::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 08:45:32 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 08:45:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 941aba8b-4b9c-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665737140;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/bTDZ7G8znZ9G/6LrV35LIIGbmiT/3QBoDX+iT+Lixw=;
  b=QGNOzEhX7o0ZAdLjgNIGfHpHtg1Yc8S3bgIM3RJOdM+UWMJnsuJ4+TLF
   yPIHXHCwFgfANI8DqMbeLK1/1Cr68ptiz1Rp5VxYHTx3O+CdSQQtFSLz0
   q9sGLJDXqaVeY1ciwEFg1SBM8R/NzNrP7lSl7Zgs/6U862YGv0WIcoZ4m
   w=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 81838837
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:raRhi6lyZtVdz42hiGsK+4ro5gxeJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeCj3Sb/iPYzShLop0aN/i80MFu8PSndJqG1NppXowHiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnPqgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfXl9g9
 eY6cC83NiuOhO6o4Km+ZeNCv5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6Kkl0ZPLvFabI5fvSQQspYhACAr
 3/u9GXlGBAKcteYzFJp91r837+UzXOgB+r+EpWz7qBnh1zNxFUpFS8QeVCcmtekt3yHDoc3x
 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ua5QeX2+zr6gCWLmEeS3hKb9lOnM0rQT0n0
 HeZktWvAiZg2JWOUm6U/LqQqTK0OAAWIHUEaCtCShEKi/H8pKkjgxSJScxseIalg9uwFTzuz
 jSiqCklm65VncMNz7+8/13Mn3SrvJehc+IuzgDeX2bg5AUpYoegPtWs8QKCs6cGK5uFRF6cu
 nRCg9KZ8O0FEZCKkmqKXfkJG7aqof2CNVUwnGJSInXozBz1k1bLQGyayGgWyJtBWircRQLUX
 Q==
IronPort-HdrOrdr: A9a23:JMlvnqqwnB9rDMCsJqVYbbEaV5uwL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM
 Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/
 Gnl7d6TnebCAIqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP8f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aiSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7svVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wU9HdwGOtt5Dt
 //Q9RVfYF1P7ErhJ1GdZY8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d
 /8bG8=
X-IronPort-AV: E=Sophos;i="5.95,182,1661832000"; 
   d="scan'208";a="81838837"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z2cHmbXntJcJLgMqv5OhhI2uW3P1R5Aybh+xDG65lGjt3AsjJCepo1jahsRIvF3TTHhyBxWuTAJNwj7SigQIrkDE51NM86M3XFd6hcMIUhzZlHmgJ15S4dS2KCVIiW7pKKUss2Vj+S8+QaJFDtVcxOR9j9nbjR+yk/nkl6Jfq9hvgHfXUo1i5qie6f2i+H6YfyAx29sOJdgU+GlUDHH6RRfE9ITRXFnQBO9CuEfUzvr+voaLj4Q8GYg/izCzSKcaYKimB0NeSPSq24GUcAaonu8d18B2NM2h8lePE3B/DBdrhtEwLCHqshnJ+syF/PLL1Q0s5Y4tQlR0iCevEq31vg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D4qUQpWRWCcsZXxVbDAetC3SRE2eelJiDgZ8ZkH7UI0=;
 b=l+RdtCPpUZXxPRaGg2vNgLilQ07aiSOz0EQyIR5NrmI+2Djuv3KhoXJMfMp2PmgoNyakSHCUoe0bBNPamiDeXXlhI8+rP7gISDF4BQOZEAnxDOaBFO3tBoZndEA/BaAj1jwtO6f0PxWzauUNTQJCbDV1n0jFqQW0VOCP49lC5erSYiqabLi2hHB8DNnSWvRHXIiu4y9HdWRr9CVRDhKw2YiPC0TJ6Q42mrhfCl7Aoa5EV/1uNS3SSF7z3VhEi2JBt0s2kGaBrLtFDNAPIc/ty3zsVuLUYXOi/rXqKy6GOEqtX60zxA4qVSc8SeIixq8U75gZPSmY9L1EPTGJChDCkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D4qUQpWRWCcsZXxVbDAetC3SRE2eelJiDgZ8ZkH7UI0=;
 b=uLMJTy8Cu2ZB/YQYENM121aCtizF9DkLafT0b5W5FFnWv/ArhSWSs89FbwSU2XHdaJ+vHIEBTqNL7t/DuTEmtTsG2PeWNPt7KpRs4Uwk3U2bZAMTLjlnm4sQAqW+OUjewhbKyEZh92Nh8RUKIyRrsfnCVHYJkWwNgUyM0HFlUW4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 14 Oct 2022 10:45:28 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Henry.Wang@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Message-ID: <Y0khqPp09vAfD4Si@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
 <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
 <Y0gXnD4jsyIp2kKb@Air-de-Roger>
 <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
X-ClientProxiedBy: LO4P123CA0404.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5165:EE_
X-MS-Office365-Filtering-Correlation-Id: b111065e-a47d-44f1-bb77-08daadc07419
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	y1B7/wgyluR9Cc0rJW1tKhoT1Q3TM3zFizOBr91pki78w9ghAmgF4Sza+DZmJp00+klQrReEU6UMwar7G3u0xbpubzrhmx/AlKee/mohNy26E3cNAwBi9xfKsgvc+BCl77Mnc7A6FRLeHHmCkOLzvLlqZ44Suk0FvhYfofwTXmeW5SMwwQ5i9BI9sEseL63/DazlTJ0d6sDMT4Jm3lqVEtdOXU8S1C5m2+jNTTB5oRLGwK52z5VwFXqJP1/4r4XkFf26A/z7fM25LBgsOBG7WhvluZZt8CUosPmbWqDIwpXiyZ23+nzeo41KcOT0EsAd7fQAgOHy/CVUp3jcrbIlOdNyegcTqY1lgOsp36xFAgFwhc4FM4j4eFfIZDdVS9F/TVsupXAfwM3Nq0pfDGaUw6xRiFltqoLxvfjY0eKwX88J77zsd6xZ4tHBevbH2HOyD3wrCjqkf2ogS0C1Y7/NWByuhj0F0+zVx1oPry2VtqmObIJnJ2jkiLCJ/hVRkmEGheu3vxMF+rwSXofKGPzS7I7W1MUxIzwG73+BNz35JD+7BgOMstqcDwCbsgiEFiRgzS+6ly94XG/Hm6gXDqKglkirS6vEI/m/yePoCplac+dcb5ukv0cQftzevw2c95dOIdkxa9J8QzDpYCdrPakhiMO0pY2RV3dp2eBdx6ohimO1ngChzYyhfX/XX0WoJxKSo/cuo0LtLa2NSuTzZSRJ8g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199015)(4744005)(5660300002)(186003)(6506007)(2906002)(8936002)(9686003)(26005)(53546011)(33716001)(41300700001)(6512007)(86362001)(83380400001)(82960400001)(85182001)(38100700002)(316002)(54906003)(478600001)(6916009)(66946007)(8676002)(66476007)(66556008)(4326008)(6666004)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WnNjSE5ycHNCNmhITGpxUk1kRGRvbHg5MEF2YkN1R29BenZVbDhsVm8vYWNt?=
 =?utf-8?B?ekJMWWV6NzYvNUNyN2NLVjJCSkNvZ0d1c0RzdjQydUNPTGE5RFB4a3MyRlAy?=
 =?utf-8?B?NHpxUzJwVHRVeUw2NThWbE9WMUtCMU9WcFlKL2dVcjZUOGwvUkxBZEREU0g0?=
 =?utf-8?B?UVJBRUNxL1VXZDRQZjlaRnZpZmpkVXhGampmRkZuRm9kNUs3Y2dqWXh6TG5X?=
 =?utf-8?B?SzlpaEJMVlZMTG5jZGpjK1lyWTR1WlVlbDQ1a2t5SkNOdnBDN3Y4cElMdzNr?=
 =?utf-8?B?clNkSjB6VGZXbHJ4Y1hYVnBrU1ZDVE83N0F5cXVDN0s3N294YTRPQ0RKUnI3?=
 =?utf-8?B?LzZYYTM4cFhhYjZkQ1FYdU1lMldocVNQSldqWlVieTl4K3haSVNqWUp1RzBQ?=
 =?utf-8?B?VHhmTmtYQnJ2QytmTHFic1ZOamNXMmN0RWhWV3ZUSmh5QTcvMDkwM0NMSThl?=
 =?utf-8?B?alM0M3dzWWl2dk9heG9Lc1c2NUVMd2RGRURPWC9wT3NVaVZBZVVDcDlBSTlG?=
 =?utf-8?B?OHdITkFZYTRNeHdOUEpxYUF1Zm5QalkwKy8wNUxWZm5neVlCQ0Fma2hqYmtz?=
 =?utf-8?B?UlhUeGkvSjlwU2hnNmpWS1hyVjRiVGhNeFB0YUoxRmRUWVBsTWdmV1RTN3Fk?=
 =?utf-8?B?TW95RmNJLzQ1Z3hIVk5NQklmU0FsOWU3UFVucjcySlMweFhEZWtJNkZ2akJ3?=
 =?utf-8?B?ZkZTZFZWV1RPSlFSMUJ1SjMwcm5RS2xrVW1vY3E3MVBteEpBbjlENVZzd2Fq?=
 =?utf-8?B?ZXEyYnlmZmdUVXV5a2gyUFhNdW5nTGhEbUEwMnN4YnNobyt6ekVBcytFd0Yz?=
 =?utf-8?B?czVvdXErSWRiTFlSbHBsL0hXYkFYTk9XRHhXNXMxMXVITmR0ZGo0MnI4TkJh?=
 =?utf-8?B?cG1DUjI3bkd6N0hDRE1SSUdHOWhORlV2eFQ2VG9GUGxYaWZPV1YzaXV5VEVX?=
 =?utf-8?B?U09ML1YrZW43WEdLaVRLWjRkQ05tSi9kMGdzbHEvMnM1Q2tlNUNtVWNvVXVw?=
 =?utf-8?B?bjRvUTIyNG5tSlZZcys0bnoxRzdnT0tVbERnSFg3bHVSY245MHVkaTVGekJV?=
 =?utf-8?B?R09CN25KT1hWU0h3eFdKMmRXQUl5cUdrams1ZWFOVjd2N2ZQTUNGT2Z3KzhM?=
 =?utf-8?B?cDEyMzhOS1hvMVpOUFlCTWtBbVE1clFXaXRVUDJoREIvTndmbVBiM09JbURK?=
 =?utf-8?B?QjFGK3lSbVo4ZDk0cElIclhmaFU5c2ZZR1E3QXVsYjVkNGlRTFBDZjJ2Z3k4?=
 =?utf-8?B?Z1Q2eUFhaWVUQ2VhZG53Q2U1K1MwYWYrbEl4YThsZVg3WG5hdW5DR3pMckov?=
 =?utf-8?B?YXNrRVRpYjVQdnZWTTZuR0NVeTJuNWhoWmZyQW9yZzA5U24yVnJDVHBjSzJm?=
 =?utf-8?B?N0N5bkNZM3pYK1BLRTYwTktwMVhkYjFDNE0xYm5QcDVWQjAxT3BqVlVsV0k4?=
 =?utf-8?B?dTI0VGtHN3RVcFVDNnZmbVFZQmZmMGFxdk1pWDhRcHVOOWRyU0dzWUNvbU5v?=
 =?utf-8?B?RWZVZjBDaGlFLzFiU3lyVEVQZWpsclA3am9TZzFkWEp2cU1meURFYWliK3Js?=
 =?utf-8?B?ZTYzNlUvS1hsL0xjRjVORm90c1JmTFZCMHoxTTI3OWh3MkpNK3lzeFBrc1VZ?=
 =?utf-8?B?SFdmNktFWHp6YjM4VDhQV1MvTDgzNExoWGRER24wcUlUSVNsa3NQRDFMRHN0?=
 =?utf-8?B?ZC9KNDFlL1JSejVEUWx5cW5HaWNhT2U0SG1JbStCakZkZGVWUC8zV01rbGhW?=
 =?utf-8?B?eDFYYzNiZVpCNFhxK2sxaitPekU0V1ZVUXVlcU5xWWRRSkFnOGdEenlhZ3lu?=
 =?utf-8?B?WVM4Nm1GOFdFejR0eC9vOWdWd3htM09Bc2lJbzlVUzVGd2FwSkp4Nm50VHF6?=
 =?utf-8?B?ZjlId0tZT0RoRlJkNWFta1Y3elUwZ3Zod3RXTVFoS2tDNWpwZXRuUTFpQURR?=
 =?utf-8?B?N2lyejNxYTFBcmpFUFFNSFhwNHBEV2VoTStVbFV5VEx1WUJWQkdlRk5FaUh6?=
 =?utf-8?B?V0lTamRHc3U2Qnd1WTdsb1RoREFOYW1oblpxdDh0MStyRVVaOFdDdHhoNDJI?=
 =?utf-8?B?SVBvZzc0VHRJZDJ0WVVRNFdGd3Q4OU1mcVlxQy9FellaWTM1RHdoRWtKT2tS?=
 =?utf-8?B?T0xaV1RTM3FIN3o4QitXU1Q3eG9XVlpiVTQ2ME5wd0doTUc5Wk1SdGljUUlY?=
 =?utf-8?B?K3c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b111065e-a47d-44f1-bb77-08daadc07419
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:45:32.2967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DFSQvEv8B5e1gSoGaUFlRkV+PMtqTV1CWRwtJG6eDE5LTRfYPjBt9Jvit8/mW9c8RkhH+WObvM7ELSLApkX4yA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5165

On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote:
> On 13.10.2022 15:50, Roger Pau Monné wrote:
> > I was under the impression that the command line ssbd option was added
> > to cope with Xen not exposing the feature to guests. Now that the
> > feature is exposed guests should be free to make use of it, and hence
> > there's no need to force a value for Xen.
> 
> ... me not having had this understanding may have been wrong on my part.
> Andrew - any chance you could clarify (original) intentions here?

I realized I wasn't taking PV into account, and PV guests on AMD
cannot set ssbd, so the option cannot be removed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:50:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:50:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422576.668687 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGOI-0000KK-6S; Fri, 14 Oct 2022 08:50:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422576.668687; Fri, 14 Oct 2022 08:50:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGOI-0000Je-36; Fri, 14 Oct 2022 08:50:02 +0000
Received: by outflank-mailman (input) for mailman id 422576;
 Fri, 14 Oct 2022 08:50:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojGOG-0000CF-MV
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:50:00 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2067.outbound.protection.outlook.com [40.107.21.67])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f3fd1ac-4b9d-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 10:49:59 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8485.eurprd04.prod.outlook.com (2603:10a6:20b:418::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 08:49:57 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 08:49:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f3fd1ac-4b9d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j9pzo7zwr1xe4G/8wybFUI+TjMlpyH/9uQHgK7gWPT3iDube8YrO8mgTd78I5V1wyKMiKDJHatiYLXqsRw3iEVztxldcX3TbovB25O30sIlpa4apI5t3i/56KpZ6XK1og4pY3QoVhZtkx6K6JD+Q4G9ax2b8tRXK9YfKAy4LoDtGFWrzayRjs3WNiN3cuWw6eRTiYV/WBAHa15MTrAHsmGyAA46lz88J/9EUrxo402v7pcNXPa2sDXgPZCLhnyhEUHo1I7AujbdnltBj16W7EAmJVfB6RAYafM13ld8y369JmP/8XfJ+72iqCMkpyvgpznqTyHT/TDszlsTLNMo7aQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=poZy3Fj+sfjLDpJyyPbFWFcXUIdvNScSz2arcNdyaZo=;
 b=NEq89zTdHMsue53lv6fMlwfMg2pJqtbXe1rFvelhQ1CheBtnMW6mxFVnQiML1tuUPQeJkyNgjuKduYGP1JhmZLS4crgmD6GmILuIFlHk/VC/vVPRauz0snbmCEkTjXpQk0rwX3zhSipjV9WX3ZdbTEY3LVSsrnyfFEEMeX/osBdyHQNBZhhi9nMRDa/artapubWJbhuaeNWaBCHi39HwOEZG+PuyM9q4zo3dnLTO4pBRW1fIl0gdYAmpaxOe5oNgVj4nAF7BvRVeC1MtSOkVGycaDHfCl5mSuOrqfXOPqd3yd5WWa8WffFhYKczWDXFS/P71V1AKgKvhXmrzdqCaow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=poZy3Fj+sfjLDpJyyPbFWFcXUIdvNScSz2arcNdyaZo=;
 b=CTUYqM6CdZc6O4GEmQJ8CeU4mNkuOo87Ga6qgQpXrIIXnjBTHQXRqe9deBXypYLcKDRBdSUHFCd4kjUF29YKCw7qKPETHeA5kzqlIc89WZF3tJEfV3W/XHN4u6lO/0hBKo8Yt+IDxd8/rWeSykphKe21G6IBM2kqaLBJanyTHSnympyF7bnKuK/pjQ7Ue9JJSjo4QkBcjYGsI221gX+SOUJaEtnTdjxD0qeWsERWn0E/pgmwR0FpWmWY5ME/Kzbaats4OAkKC/2F+Kqn9BVpkO4C4DujqTv6UquFJ/WYc3tRzQEpPvlO6BtjFe2TV6tFXbUcNamW/0kFPWi1TIiPNw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
Date: Fri, 14 Oct 2022 10:49:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tim Deegan <tim@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0005.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8485:EE_
X-MS-Office365-Filtering-Correlation-Id: 4752880f-2031-4015-5037-08daadc11240
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nDWITlxl9WE4V2TZQEOU1xGzwI1/lXEMSTc/YwYI8yQomBgilkPAgr5gKYXs82Zz7tgQsszOsYDBjW1ydAzaxaMdHWAG2ytNUJLSRJExLnCOE8SFEsNj6ZXzpPrX9JHmVWExpkTgLLmEyFT7Hk1lZlYyK0np2V/alyxwBJqqOc6DUyWkMdz2D6IM04orr1Nnry49hAXt+TLdBw4Fo7bZjTuttdGkavVdFJDUcnEJRjGjztSUOKdp6VKwFNeg9YqbZOgpjnvup/mq1weKMZ388WVr3rcc9H0x1TRxIBULHOlOlB5hPOkOZER0Mn61aWTHcmU4VlCuvRvKUxHTrJAMdNkLSYbtk0qgELMPGkd5MYV+TYUwNxZl7jT8EvM45XUciDLP8zD+YU6CSkYHAG4s3/xlmffO63sHp00SSHPPFGt7JJ5Bnlgd4jFaFHQIkSltcA+WK88MPak+6zUeHjsjucHnEg6jubdGIXEVIRRtnL26FRoB6w2uM2x2VW9GoIIOm/He8f0QPqSL4fQJSduFdSBotyhZ3xEHCj711hm5vQLZDH/EbTqwwy04TKGHYNgFP7zW/P6Wa2xpFPeq4Ek46nxBSbxnUtUohO1ibpsUSbqI0kQx4Cqhzgo/NZhJxYlzxe4/T0ZlDHbdf7PzvKxFUUnRibmTKMZknftsdv/+w1mwKFveJKoXlkt2XXUAYAl9pqCRZNP4G+9juiaN17dSiCuiXKU3F7G8JnYC3qEEiHQjsAHBXvUsjw6tgYEmnk+4SypHVb5ll4gI7Frzex14XmAqwT0mwhc44ACyoI8vZK8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(136003)(366004)(346002)(376002)(451199015)(478600001)(6486002)(54906003)(86362001)(38100700002)(6916009)(83380400001)(36756003)(66476007)(8676002)(6506007)(66946007)(4326008)(31696002)(26005)(66556008)(41300700001)(316002)(186003)(31686004)(2906002)(6512007)(5660300002)(8936002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?THdseFBNQlJHSXNCNlNUU3VoK0hKZ3hGRlNLOHNrcHRYNGJLMjY0WVl5cDJm?=
 =?utf-8?B?bHhGSG1DUmJKenVYVVc4N1g5SXEyTGRKaDF1UWYzaWdFUm9NS3VyR01GMFRl?=
 =?utf-8?B?UDZjam8yaFhZMlI3czJKQTRmUkxDUWxiUFJsT3ZHckMrWGFHaFRoWjlZVHIx?=
 =?utf-8?B?STNsTklrYlFMNjZLZXJSNkUzSVo0SEJOY0NuMHlRUXR4U2xGT1YwSGNwMk44?=
 =?utf-8?B?ck5lV2U0UjJZb012cnRBS1Q4cXpTcE5LWTNldW9vbks2cUcyWVRSc3U4cXdB?=
 =?utf-8?B?S3pjV3o2NHZZWUpFUEhhUlhJd3YxbmpON0xHOVRVT0trMmhINFlPaVJjcVlj?=
 =?utf-8?B?TWhOci85VzJqaEJRb1dkYmZFbkdGaFgzRFpyWkxXaHpFTU5OTVptMm15bmsr?=
 =?utf-8?B?QnBPd2g0Vk9veENpYzFTdDdpRytqcWszV1laY1Y2T3RQTXp5cFd5SnUzd09Q?=
 =?utf-8?B?bmFVS3RvYlhuaUZWbzZYb2VrWW94NG9CdTdQa0tiSXArdDk4WXFVRjk2cGJU?=
 =?utf-8?B?cTZjRkJ3cG9CZ2Y2RW5aNkpUcVF1a2ZJblpjTGRHcHBqY2I0V1M0Ymh4RWRr?=
 =?utf-8?B?VzBLZlpSS0draU4yNnRLRk5nT0xaMmM1QWVHcU1UUDhadFAwNTQrNG80Q2Fr?=
 =?utf-8?B?QjRiVnk1VHVPK1JOYzQ4NVA3QTI4Q3ovRHBibjBpOXdjelFlWGFyUUhkcDVN?=
 =?utf-8?B?cHF3Nm5LbXl1SGpzSmNld2FBMDRlSzJwZ0pUaXZHb1JxTUh3QWhMTUxPa1NF?=
 =?utf-8?B?WitsTk95L01rT1R0TWdnbTlWSzNrR3M0Vm44d1djL3NuSnFiN3E2WkF2VWJG?=
 =?utf-8?B?aHRhdk05ZlhVWVZVOTRFMkhVQlNabEZRY2pRTStJZndTaW1Xbk53SjFPaCt3?=
 =?utf-8?B?Q3V5bHN3RVlOeEtnWkc4TjhHTzU4a1lFckZHb010UXBCVXBwb1RDWWdFQUdm?=
 =?utf-8?B?dWR6d25ONE03QzZOQzdpYURtZnNmUllYYk9yblRraXl5YXh2di8xMm5WVmF2?=
 =?utf-8?B?dG9NVGlKVk9zNVJtQ0RwM2k1S3phKzg3T2M4cWNkTVI2SHZOT1JiUlJ4MFR2?=
 =?utf-8?B?K1hnUFY0Sm1TQjJKVzRreTIycFN4eDVnRTFNMnZkcjVGOTZWb3VCaVVVNkM1?=
 =?utf-8?B?TUt3d08zcGtPTW15bGNaaStCWGR6cXlBMkxvWnFpS0E1eERwMUdtSDRPZllv?=
 =?utf-8?B?R1ZIeDk4WENzcmpnU3dNTzlPQ3F5bW9vcHZZM0NCWk95aTJvMFRvVENWL015?=
 =?utf-8?B?TzFyZVYxSEliaFRRL040enVESEQ3Y1VtM1BwWjBGOTJTVjFsaERFWUJicFp4?=
 =?utf-8?B?T2o4R1YyV09ZTGM4WkhXRGYva0xVTUNiM0tRL2VncGxyZEp2bElBNlF5OE5l?=
 =?utf-8?B?NW9CRFMwQWtabFRvNGI2SDJKQ1JQdFZjT3hxVTY5cHY3VEdMZlBhY21WWlBG?=
 =?utf-8?B?N09ONTZxV3dHTjg2NVd2SUJzNWViN005cE1TcWxCQUI0VmgvUTNJcVhaQjVj?=
 =?utf-8?B?SGZxTTlDVnpYVUpPUWxGOVJ2QVBvc2l1bTBQQ01Ua3ZmS29rY1pPakFIVzU3?=
 =?utf-8?B?SVVPRlFZeXVUTEtsU1lWY0FZMEJJYXZnL29jQjkvb2krWHp5VEppNHJqNzlt?=
 =?utf-8?B?VnVaZ05uak1yR0ZyUmNHRm5GZ0pidm14RVovZkljbFV5VGRsSS9UUUpkWUhY?=
 =?utf-8?B?b1diTTdDdm1HMkk4cm11eWwraExsMmh3T1JqL3FFSlk5MUZtMEpzc2ZRL0d1?=
 =?utf-8?B?TkRLSDZtK043TXBUMDN1Tk9hN1AvUk5Sa2hnNFMvNXJmYmg4TUxBWHJldUlX?=
 =?utf-8?B?dkxmTmNUcXZTU2hYbm9lV1NSbGJYVkpTWWt0SEE0MU1hei9udUhEN2k0bDQ4?=
 =?utf-8?B?NVI1M3k0Z2l2d2lpWFkyYWJTdFJmTDhZRENwVXg2clFzaHNmL0JLekRsS0F3?=
 =?utf-8?B?VnNMRHc2S0ZEOHQ2VFZKSkdFVTVFK25iQ1hpd1NQKzZUQjUwbkFoa1VUSUlq?=
 =?utf-8?B?VHg5RkpVZ0N3UEY2aXBYL3F5amlhcHl4ZnRWaHNoNlpPd2NqZ0NsU3Zmak9w?=
 =?utf-8?B?WG80bGFvVk1KSHBEcFNTWVdTWDVxK05aT1ZhSEIzT1NrMUpIaHJxc1ZjalB1?=
 =?utf-8?Q?TI7Vb8kGKHlnQha/u+in+us+F?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4752880f-2031-4015-5037-08daadc11240
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:49:57.4094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lGtVTp0nOI5g5YrEXQ6sE7cnj1aBeEPnWXZ8PP10jW/naSMXWvlvRn5IHkosqe/fKkDpYHUwHPddxAYHv0M8Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8485

The addition of a call to shadow_blow_tables() from shadow_teardown()
has resulted in the "no vcpus" related assertion becoming triggerable:
If domain_create() fails with at least one page successfully allocated
in the course of shadow_enable(), or if domain_create() succeeds and
the domain is then killed without ever invoking XEN_DOMCTL_max_vcpus.

The assertion's comment was bogus anyway: Shadow mode has been getting
enabled before allocation of vCPU-s for quite some time. Convert the
assertion to a conditional: As long as there are no vCPU-s, there's
nothing to blow away.

Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>

A similar assertion/comment pair exists in _shadow_prealloc(); the
comment is similarly bogus, and the assertion could in principle trigger
e.g. when shadow_alloc_p2m_page() is called early enough. Replace those
at the same time by a similar early return, here indicating failure to
the caller (which will generally lead to the domain being crashed in
shadow_prealloc()).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While in shadow_blow_tables() the option exists to simply remove the
assertion without adding a new conditional (the two loops simply will
do nothing), the same isn't true for _shadow_prealloc(): There we
would then trigger the ASSERT_UNREACHABLE() near the end of the
function.

--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -943,8 +943,9 @@ static bool __must_check _shadow_preallo
         /* No reclaim when the domain is dying, teardown will take care of it. */
         return false;
 
-    /* Shouldn't have enabled shadows if we've no vcpus. */
-    ASSERT(d->vcpu && d->vcpu[0]);
+    /* Nothing to reclaim when there are no vcpus yet. */
+    if ( !d->vcpu[0] )
+        return false;
 
     /* Stage one: walk the list of pinned pages, unpinning them */
     perfc_incr(shadow_prealloc_1);
@@ -1034,8 +1035,9 @@ void shadow_blow_tables(struct domain *d
     mfn_t smfn;
     int i;
 
-    /* Shouldn't have enabled shadows if we've no vcpus. */
-    ASSERT(d->vcpu && d->vcpu[0]);
+    /* Nothing to do when there are no vcpus yet. */
+    if ( !d->vcpu[0] )
+        return;
 
     /* Pass one: unpin all pinned pages */
     foreach_pinned_shadow(d, sp, t)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:53:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:53:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422583.668699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGRy-0001fD-PN; Fri, 14 Oct 2022 08:53:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422583.668699; Fri, 14 Oct 2022 08:53:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGRy-0001f6-Mh; Fri, 14 Oct 2022 08:53:50 +0000
Received: by outflank-mailman (input) for mailman id 422583;
 Fri, 14 Oct 2022 08:53:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojGRx-0001ez-92
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:53:49 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00045.outbound.protection.outlook.com [40.107.0.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7996d40-4b9d-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 10:53:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8457.eurprd04.prod.outlook.com (2603:10a6:102:1d8::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 14 Oct
 2022 08:53:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 08:53:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7996d40-4b9d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l9ph5jJGIbQk0jhro0ITmQDfOR666SsOi8bXcPRo5Q/BYTeLNSbA2cpI6U5B0U34e7iK+h8SZEND/eQGADWOchxHC2HIYGE6f9kOO6NZRCiD7kHZMdJyNXHea1KSVAHAJb+QNpxPwOrI8GBBjOUkobad8hT/aspUM8UoZ1C33zw22/F2hUAY16OYknz0NMlCMSXRzjTlNsrMyIqLnI/zpZIjJpyneK20LHYWz0JtobZjA92D0mUMLpOszQtOnmL81J4xNSJnIL/R5+O9SkRGVhJ/owE1ZNjat7jNKaf75pWANi/R3bJEswcVY4ID7BwiB5qKBqHMROEed3uY7VdKng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KLLl86NHmJ9KVDGDtDCnKOQpHqdA7n87l0s3nS2sLII=;
 b=WNcgNteEqlhG9STS6UExXwkI5De06tW6ntiaBrV5KjphzF1pkdzItaXvIVL93Jc1keTesIwZD6s3U8GFcebk1yBgr09UAVVXGVk79FP/n83zRkp0pz2XYlkU6HdKRbowXu7h7in3cHB577/LITFLyuvKe3ZlD1B12z8L2NxOjkYgdANYyVxhLGp1Bd0GSTCBbwJQQK5RibJG6Ybu7dtRTPfQV0s4StDEAMlW2M7zfDsvOyLKrx9Vy8xgikr0ciCdlw3xZXsqu5K/HE+/C9xmToa0Mhx7dK1dk8S4PIExBNj5aU2LI2vXyWWxgn6vUxiBMXytOhmZkCiCdSBKdLF1aw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KLLl86NHmJ9KVDGDtDCnKOQpHqdA7n87l0s3nS2sLII=;
 b=Lfrf8RE535VdRD8hVHmOiTj2ZrYEno0nYGDrg4Tr/OvmZvaf+hA3J+PjEtHsJAud2jPevJOOFQoTtGLmc0kONaFMrhT+AM0qmyX1AUHw6sXJWu6Bqc+zcJC1K2plN4uDQZLiEkcgnblI4rahhErJ2lY9lZshAX3+fOJCuFIJP/i7nhMsem45QjLNo1e3N8zou012fyS+EVI25p7o2fl51azEthG8f/gzor2MVbL5t/6zLOvOlyrmNp8mOd9eph8ycAoHi/DOyEA2DBaDkeHR/guHX5Guzf4CVOwWr0EfKqSLT27ZRFkEMWfcd4VmwTk/cf+XEDhagwWakXU4BfcD2Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2108f29d-3ac0-7243-d496-f1535e7dd5c4@suse.com>
Date: Fri, 14 Oct 2022 10:53:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v3 4/5] x86/mwait-idle: disable IBRS during long idle
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>
References: <84200e9c-ee22-c240-826f-6c7006c0ef57@suse.com>
 <38839202-426f-eb31-2997-ef557ab1583e@suse.com>
 <Y0f+gL1PfB5lzlDj@Air-de-Roger>
 <1867142e-ee46-daa7-c05c-04045460ba52@suse.com>
 <Y0gOOcbw2bebsKAJ@Air-de-Roger>
 <dd2ca7b9-f7a3-208d-f757-cf47f37de1ab@suse.com>
 <Y0ggOLWa7onsacmb@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0ggOLWa7onsacmb@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8457:EE_
X-MS-Office365-Filtering-Correlation-Id: 67d2a2c0-8eb8-4cb5-f1fd-08daadc19a09
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m9UieLslEWtIVSuozy0PKdvfYf0KCxEZ9wWJ/Cqm5RdZMj3xZI8Ulon8v7lj9HZl4Nrt6H0yjz62xbFFf29QZM5vHYtJOmhU52PYh66aI4agHC/+pbDdQGa/95sldeW7p57HOcSy/lJsf0OuspAdI8xeSv7bgw/cBOEOTlp3+XUG/Df5iBSRmL7LJXJHNQjTVbkdsixqi0Wuyz1GtAMb8f7VpPORzpNcErLaVwIrTFaib4yacyTl9HCQO4tZ1d6waml/vlBG78YdnUbDgN3jSA8LdBTXQOznbvSAuu2ebmzDJpbTXdJ9XYq6ShMu0abNXSzr7xd+3LkNTpc9kPEVl0WPDXefsUqrSpiKuz/i2dNaejYewG4C6ujVFVaBQa/RGng1kTtGZhgRmkFmJl6yrHzgCPwdL0IqIPoQ+2QdbXnIDKkv+VINTlrSFtFxCe6lkmpK+UPFcGyP7SlqCoBnCIaqy6FssjBeJILxop7N0E8xENqNdDuf+2wUcfedz88nHhZH5grDM5XZiHf5xs4yfwCe4ZR0sI0QXka8Wgt6oE9E5FtvTY6n2n23uPWgQa1Xx0nTsP/YD4n8GtWStlXjqLjf79poa9/MJmzwFHdSdam3eUDInpBNSw1fZfLyRRYCNmlRYpiGNCAfnHnHjGiVCm8XDX2daay3FMoNdBdouJwrjlAbYNMIO7EJQvjgixSfIG4+eNdTxeC5ZK909e9wL9tcTRTqB4z/Q6yNVAnbvHRYoTHS9zINtmEr6Gb1B4eRCr3Z9CnFxotmBAWbjgfMtKtEQtoiU6y0IpYa0QyJ6Ac=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(39860400002)(366004)(396003)(451199015)(66556008)(6512007)(2616005)(53546011)(83380400001)(5660300002)(186003)(2906002)(6506007)(110136005)(316002)(26005)(41300700001)(478600001)(6486002)(8936002)(66946007)(4326008)(66476007)(54906003)(8676002)(31686004)(36756003)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NnJHeUUxTE1BRnBCNElFQlhWQnI4NzV6M240TXFqR3pRcWRReC9iTW8waHNp?=
 =?utf-8?B?SVdCYmR2U1EzUkpKQkxkVll0elhzdDNJVFBIMVYrVGNpT0lmUDZZQXF2NTJS?=
 =?utf-8?B?elhsc3RLcVpMcGpOYnU3WXNiTVQyNTEyR2U3WEQ3L0ZkN3Z5cG9NVDZTbHZs?=
 =?utf-8?B?MnRtRVFFVm41SVRHSSs3N0lQNlBVdlRIWXE1RGtlam9xVnJWSTBwVTZXc2Vm?=
 =?utf-8?B?djhaQXl0WERxUURoa0Zud0R0clM2VGdoNGU3K0xYb1V1WjVNdzRSWFJFdG1o?=
 =?utf-8?B?Zy81S1JJRjVwZTN2elVkc3lpT2xyQVNrNGEvUUt3aC80d3V5MlVRNFZwOFln?=
 =?utf-8?B?YnMvNnhIUmRaMkpjRk53LzBTeGNRN0RvK20wbjZLb3NGdDhBQ3RoYTZpeFJ4?=
 =?utf-8?B?ZDczdlAwY1dVSTlCMjZWRGVnU2JHbTVPQTdZR2kyK2g5K1BPTHpKVW90clZF?=
 =?utf-8?B?M3AyalMvQ3NQUFVaT3UrbG02QUIxbElQdFF2b2s1blJ4QTlocndwV3c5b2k5?=
 =?utf-8?B?R0pMTFdOd0dnRXFVcUJzMTBjYkpOV203TGFqWVdRRk9XeFY2elRnRXY3aUQw?=
 =?utf-8?B?N054SWthZm5iekFrTjVUdHFOZm1XS0habmJzcU9JbXRKZWs5d1NtMURyeWRw?=
 =?utf-8?B?YUVqM3U3RWY0UFZBdTNtd0tld0NsUHY0dGxaMFJjMFcwWjlLcElrcXN1TDg3?=
 =?utf-8?B?VHZkZFNtNmoyaWc0NXNHUE9WdXBRQ3hKQ2dhSnNpN0JnVWs4SWlTM1J1OU5D?=
 =?utf-8?B?MFdFQlBERkdHUmNlN1o3eDU4UG5iR25ISzN4a284SThWRUdQV3ZYZVplQkc4?=
 =?utf-8?B?K1V4THNLQmhlWExTaGYrN0QvVzd6UmFOemo0Szc5Q3ZnOHo4cGlhMXNZSlJK?=
 =?utf-8?B?VmJ0aEJQRWdrMjlQbzNqeDJLM3ZxTEN5TU53bGxNN1EydUM0MmNubWRKR3dW?=
 =?utf-8?B?Zk82bkF5Um01Q3NxRWV4ZW1jQkhUM20wMFU5aFlWS1ZFdWgwU2xtYmJvRG03?=
 =?utf-8?B?YWNnbDE1ZEorUUtBQ2FxTlZlL29RVVB2aWY3a0hTSEJWbmdDNjRSeUhVR0lo?=
 =?utf-8?B?Q0NqR09WRW9wRGVIUXJqRGpNWU5YTG05Y2JhQXBjVlhnY1g1VXYySnhrdEFh?=
 =?utf-8?B?bTFpNFdVZm5VWGhVdzhJcU5La0RIS05aY0UzUkpYMWRYMGNsMmMyWGJHdE43?=
 =?utf-8?B?bldJQTBBR0hkbXF4bXpYQW9yV2hRVlk0UGlDb1ppc1daTy9RZmEvdThXQjRu?=
 =?utf-8?B?dEhONFZTb3hUNHpKclkrSSt4ajRUZEM0M09mYldSVlNlOFdZaVEyQVQ3aVF2?=
 =?utf-8?B?Q1UyUENQaXFzdHlMRkN4Q2lKUE4yLy9ERGcvdFkrdWJ0WHNHZGcwbXYvV3k1?=
 =?utf-8?B?YUVpSWxhc2NpRVZRTEM0MGJ2amM5K3hGcW4wbEtvV3hQUDhxRTltdTk2ZGdW?=
 =?utf-8?B?dk8renJkSHRlKzB6ZExicVF5Z3dHRStVUUpYSmJ4V3FjcmVRQ0ZwdlhJS2M1?=
 =?utf-8?B?RGc0d3lvNUlvWTFuTUxJYTF2cDExSzdLZEppaUdVRGZlRWxZWm94UnR3RCtl?=
 =?utf-8?B?RVJHRTV4eXc1TUNMRzRvVkJvWUZibVBTYVIxMk50NUJMeWtoQWpJd2pjMm1h?=
 =?utf-8?B?KzJFMS9VQVRRT25nSXNnT2xsaWpjdCtsNjFyQlIvR3hYRmJpQXVEOFIrK0xE?=
 =?utf-8?B?OSt2MG1rUG5jWHIvWWY2R2k0V01Tdk0vbWE1c2JLSFhCWlQwUldDekxXa05m?=
 =?utf-8?B?RUhYL0lubWxYcVZzcGY3N2dNSVFTL3hWeUFva01pZ2owVzMreXAxWWh2aHA3?=
 =?utf-8?B?S0s3RUFmWWZZZlUvQkxXM0ErRVNWMmJJVjFHajU4T0p0NjBzdFZocDdVcmhN?=
 =?utf-8?B?RjlmcnZpdWY2R3VUNW82U21jVjE3TzRMNS9tNTIrUjlzZE5kNld0N3N6RkI3?=
 =?utf-8?B?OHBCYjY0dElaRjErYlhmUFpjWU5jM2R2VTBNc1FLRTcvbzQxbG1oZWIyNnc1?=
 =?utf-8?B?dzk5cSs4Ukg0RWUrelIxNGI5TU9neWJkYzRSdnU4bUNzSkkxYjdGbTZJaTNZ?=
 =?utf-8?B?NWt3eHdwbEhtSHpSVFFHTzJ6alhRa0tieFVDYUJxM2NjTnpYdU1ndlhEMHZy?=
 =?utf-8?Q?B7wVojW4CnLG03GBvBIPHgZTj?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67d2a2c0-8eb8-4cb5-f1fd-08daadc19a09
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:53:45.1920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lWpA/8vGmriDyNSv4LBXogmqReTOS5ek9vkydCnqo//SEfeDobkVjxaR/u9BtdTDt2njnq33lNi2OncfWjSc+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8457

On 14.10.2022 10:03, Roger Pau Monné wrote:
> On Thu, Oct 13, 2022 at 04:15:04PM +0200, Jan Beulich wrote:
>> On 13.10.2022 15:10, Roger Pau Monné wrote:
>>> On Thu, Oct 13, 2022 at 02:17:54PM +0200, Jan Beulich wrote:
>>>> On 13.10.2022 14:03, Roger Pau Monné wrote:
>>>>> On Thu, Aug 18, 2022 at 03:04:51PM +0200, Jan Beulich wrote:
>>>>>> From: Peter Zijlstra <peterz@infradead.org>
>>>>>>
>>>>>> Having IBRS enabled while the SMT sibling is idle unnecessarily slows
>>>>>> down the running sibling. OTOH, disabling IBRS around idle takes two
>>>>>> MSR writes, which will increase the idle latency.
>>>>>>
>>>>>> Therefore, only disable IBRS around deeper idle states. Shallow idle
>>>>>> states are bounded by the tick in duration, since NOHZ is not allowed
>>>>>> for them by virtue of their short target residency.
>>>>>>
>>>>>> Only do this for mwait-driven idle, since that keeps interrupts disabled
>>>>>> across idle, which makes disabling IBRS vs IRQ-entry a non-issue.
>>>>>>
>>>>>> Note: C6 is a random threshold, most importantly C1 probably shouldn't
>>>>>> disable IBRS, benchmarking needed.
>>>>>>
>>>>>> Suggested-by: Tim Chen <tim.c.chen@linux.intel.com>
>>>>>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>>>>> Signed-off-by: Borislav Petkov <bp@suse.de>
>>>>>> Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
>>>>>> Signed-off-by: Borislav Petkov <bp@suse.de>
>>>>>> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf5835bcdb96
>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>
>>>>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>
>>>> Thanks.
>>>>
>>>>> One unrelated comment below.
>>>>> [...]
>>>>>> @@ -932,8 +939,6 @@ static void cf_check mwait_idle(void)
>>>>>>  			pm_idle_save();
>>>>>>  		else
>>>>>>  		{
>>>>>> -			struct cpu_info *info = get_cpu_info();
>>>>>> -
>>>>>>  			spec_ctrl_enter_idle(info);
>>>>>>  			safe_halt();
>>>>>>  			spec_ctrl_exit_idle(info);
>>>>>
>>>>> Do we need to disable speculation just for the hlt if there's no
>>>>> C state change?
>>>>>
>>>>> It would seem to me like the MSR writes could add a lot of latency
>>>>> when there's no C state change.
>>>>
>>>> HLT enters (at least) C1, so is a C-state change to me as well. Plus
>>>> we may remain there for a while, and during that time we'd like to
>>>> not unduly impact the other thread.
>>>
>>> OK, but it's not a "deeper C state" as mentioned in the commit
>>> message.
>>
>> Correct. But it's also code not being altered by this commit.
> 
> Indeed, that's why it's an unrelated comment.  I was just wondering
> whether we should drop those or not in a separate patch.  I'm
> concerned over hitting that path on a virtualized environment, where
> changing the spec controls is likely not that cheap.

Perhaps we want to make spec_ctrl_{enter,exit}_idle() a no-op when
we're running virtualized ourselves?

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 08:58:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 08:58:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422591.668716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGWV-0002Of-Ag; Fri, 14 Oct 2022 08:58:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422591.668716; Fri, 14 Oct 2022 08:58:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGWV-0002OY-7x; Fri, 14 Oct 2022 08:58:31 +0000
Received: by outflank-mailman (input) for mailman id 422591;
 Fri, 14 Oct 2022 08:58:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojGWT-0002OR-Ou
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 08:58:29 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e408ea6-4b9e-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 10:58:28 +0200 (CEST)
Received: from AM6PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:f0::48)
 by AS8PR08MB6389.eurprd08.prod.outlook.com (2603:10a6:20b:33e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 08:58:25 +0000
Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::36) by AM6PR04CA0071.outlook.office365.com
 (2603:10a6:20b:f0::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.25 via Frontend
 Transport; Fri, 14 Oct 2022 08:58:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 08:58:24 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Fri, 14 Oct 2022 08:58:24 +0000
Received: from f57c6c489b5a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5A3837B2-6B75-43EF-B9DC-5442B93845FE.1; 
 Fri, 14 Oct 2022 08:58:18 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f57c6c489b5a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 08:58:18 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DBAPR08MB5622.eurprd08.prod.outlook.com (2603:10a6:10:1af::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 08:58:15 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 08:58:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e408ea6-4b9e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=eSgI+VNfGKvnYVLGG5yEo5QGYDCU3qbsgp1mPksy/ETVynQHrDzcQ7adE8NVlPhLaJW2/tKZ6guJWJA2PfRHsHZSj4NLH9bGvcH8rYKwqhq9wYa2v+JByVxoHc2wxYiX0UbmBUDmYf81wbPD5puCETOYHRu+L5gJg7/TFvy5ZqHA2bUeYcDhICSleeoXhOtosryLbzMu4f6WsQz8z4Ie9a7GLYdsdYyDbNTxmQMZpE8TXVIFtOlcyinMThMKPJBTk+KXiJylQdqhqwXACl1/RJcC8UCld+CiNkNUsi2qsFEE6J2j5fQFyoPX2dsffM3ahgyInW95gOwj0cq75xoJ1A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2wb5r6reTnNDlEtTPWq9l4CeLPdCvnAggvKIf7zFl2U=;
 b=CccaOGj84fn6qNDUTVm50iPC/bPZ5SZILNmG0bYpLMJzf/BF+zJn3Av4Gmgc+bSgzJeEY2nMtQzMkvrF8GsuxZ3go2GooOuHdR1OoMCpPN+gSDpS6xs3n/Tn5hm6aUycvK3LXY+tme003VjbWyz1XxLq0oih5SdyylCL7vRmtk1EGTXyVyhVUwFo3texOC4H4lw+PIfbDMgqpGh6Y17V8PW1KoVnzy6J2XsIRUoX02vPSNLxwzehjtYNZtrefxs54vofuxrjAIBf50AP1nwDeCQyr6w8kjRAJKniYxCQmAacxSqvbkX4ExcJy4Nx7RjID/qAmCJCBw2mIFtEAoWU2g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2wb5r6reTnNDlEtTPWq9l4CeLPdCvnAggvKIf7zFl2U=;
 b=hwi4t5hqUa6TAo5mj7Jn8Xv9GMV3IAhm5WS9bI9aCK9WhWxn38A7YgQl+IQsxhCuq0XWX/7uJOW90oBtWQcn5dUH5pt+KJbfHt0Ev+tLR174JmNr9u3Ds7pvhp91uBp9uWe5qABiKacUtD9AXvwpXVptk3wVFSbxYK6RSaZOhAQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jlozsO6I/z8+6b8Ud04WgUPJ5OOjuT16E9pAqCObTOzD3tGbWyxla/OvNuW39ho66fwkGoRKO5a3VUjGSdH9ot7y0ATE30eGqilbZWe+mpBmEhW2PhLhdts4ODrJi5jT4QszsHmMy2EGUVNP16gpIHALgbidd1vhX2MGbsIGz+aLrr3klQ8/1En7PBGRXbR/8xWJlcKfAZN4HmJ6/Bpx2NOKTB+7CvJ/dp6rzHPXIJ+pIWc4nTpKc4rsrVn7dyG2AWfmvoC0xSW8DyErQPIFqp2APd9SPt1BjUx5DJWGkm4EjAGbgqHSGGBcsG/eZnqfuoRgv0td4Mz4/ZtU/pqupA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2wb5r6reTnNDlEtTPWq9l4CeLPdCvnAggvKIf7zFl2U=;
 b=MKNu/pnqZl9iWnseqoRQXl75TVpnISzyZR1VTO8ZsOsIkjKikjMeRJ/KSPKSjwdHnQjaW5YJ7eU/olPJ79W1/mhdqzfvNB70y95bPkomHT+UpofAQg5wIRmYLbX1l0EeJHjvWv4OXTo5usHIhrivdZLhDXVwaqYvZdxeAmqWnVSZRt+++rZaTTSORGq3BrvKZr6m92P6sXURGpdV1nuTfXVCGPifNNRk0NUD6iTh4JoRay0UD0H2DfpN8RcrzlBtING6jtlF1BeLU9510MgWMsCRp2NSciwXfwWf5/yBqfEwLIshsqtL/VON2+DdS5Rm7i4YUHD7p9nz9xEKBYMC+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2wb5r6reTnNDlEtTPWq9l4CeLPdCvnAggvKIf7zFl2U=;
 b=hwi4t5hqUa6TAo5mj7Jn8Xv9GMV3IAhm5WS9bI9aCK9WhWxn38A7YgQl+IQsxhCuq0XWX/7uJOW90oBtWQcn5dUH5pt+KJbfHt0Ev+tLR174JmNr9u3Ds7pvhp91uBp9uWe5qABiKacUtD9AXvwpXVptk3wVFSbxYK6RSaZOhAQ=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Thread-Topic: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Thread-Index: AQHY3q+bU7An58kRd0C18nD7mqtwpK4Nk9IAgAAAuGA=
Date: Fri, 14 Oct 2022 08:58:14 +0000
Message-ID:
 <AS8PR08MB799119B54A5FE419CDDB9C1592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-2-Henry.Wang@arm.com>
 <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
In-Reply-To: <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 193FE62B250BB2468D760A950D2F3A02.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DBAPR08MB5622:EE_|VE1EUR03FT005:EE_|AS8PR08MB6389:EE_
X-MS-Office365-Filtering-Correlation-Id: 48c75b1b-8986-4238-81ba-08daadc2408f
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GjqHsnltdA+cfc1NyVlItHwBlSGzMRaf2RXCZnD1mRCmT0k5c4ggdbreULCjzfA7O35rfyr54l4YEgDUrsz1ZkIc+RpzZP2SKzL15rKHTglGPZylpkRwdeYmnfZmeV2/SfT0hCsKRAAhpuJOhMwq1bYTylWssMo6XknAjLuurzsjK6cWgire0M+Fn+1qjds1MtOLrorApWVf9k9tfkRN9um/fzwYKg1dxUtd4N3ue2/uw2B2pxlZCrNWVySDKlhbG9F6rI+ln0sWtDd0OOWPGRmonCL6JBCbbDI6fy/wkSJL+LUPzeGtX6XrdZn2Tx3cwSfdCg4OVR5Eq88nSKg3zRX4JOuRtkzN/PXFplU8sHbkiCmaJ9r1FF6oM429pNWS2OLFMA0g4tVQAVuQqR4H+SV2mh6Y1ODqzVQ7AqYp4I5KwECBfSiP+iW53jkAmnyPBUgbvXI2LHpoTa1mA5KbQgxnhxXvaMFcASSiItScUoKSMORtazq2IBQ0GtfjZ+H6S7RFcoZmA20mpOSYG/FLz/zSVpvJf4Ds9xygOOCMgrH2KwLq8txvAr0dEAQdD82kP/UgVMtkLynanZC6q3/3olSEdqLP31UXuPvsHXjPn+d/Mo57ggR0m/dGaYj3W+QDPYI6hWuFEyTNwJmJEqHBt9rTLzjeMqYVwZCZnqOHbzpDQECIGesCHhFuQD3PsBLrit85dQAu4eleeQFqFDnjwOOms+7GN2Xlbae/7am2wc7thJQrejuO833CVVYMDjV9hyyBiYg375h6CMUDRIEC+A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199015)(26005)(9686003)(6506007)(186003)(83380400001)(7696005)(2906002)(5660300002)(55016003)(71200400001)(54906003)(110136005)(478600001)(316002)(41300700001)(8936002)(52536014)(76116006)(4326008)(8676002)(66446008)(66556008)(66946007)(66476007)(64756008)(86362001)(33656002)(122000001)(38070700005)(38100700002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5622
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fc8ecd20-ebb7-43a8-51dc-08daadc23a8e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tMYnJmDFKIP0EHJFrFmJwbHWTqIhMXBF3dvosCIedZm3FOI+ddMp5LAQa8GldWbzPn43c/kzKpbVwQUnBRY98auCwjYIAh4sjSDrPKu1JUHNilpqo8CLURPTTPPfpg4PmZgl3p6tLszUakTKJtWmDlvBugCWPVW3SDV/cIKeREiG06siYdpVyCvOc2rHq5n0PGZUZ3uq5gbxx54uCxk7Nv19ivgP4+LXDvApZwirGTGBYSe5EfYgnbMsYc/ILKWPBBIhlyDuCmgihseTKBJSryhECJ0hTzwRWxjQ1usP6fLZFsULKV8ZOwQXJdMgBvhAUEPYbFFUZQvEEeRKewC9xvDYhjC/A9hAiSFQ3o6PeMHpe9rWwCx+q/3OLU7Kl3vxSD2KNUaxrd8ld3C+ptXSMI7Mu+ztThn9pNbil7NquqZej11iaA7J/bR09xtN/9sWv5qDvj1Sy6KwaHEpjZofd41RPJtR+I4ShseYjlZQLHjb2Vj/I8JbLZWvCU7/izXdvAZELpv+7ws6Uq2ub3MyMor5IFi4RsdYzh5EViJhZyX9W95vmIBc9N0Ps4kWnOvaRTbPYjgHJCxettq9DHHATrtAFn74NCRLPuzg99Q64wzqNp8m9MXDeaBi4iuugM0lbf5/Qh3EQlRYkbkSU5so76eEAHgWsgo+egKThAkIFx8Xp47UDl06kFo9k1lX3AqnWzKS4lXRe5FHY0xFLlBQOPbEoptjQAav+vmK02pWGJWKNmCSc4lvQ6+cEc2uMVNcn/a+Owtmv3t+29kcwSGtbQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(33656002)(7696005)(6506007)(8936002)(478600001)(41300700001)(5660300002)(52536014)(316002)(54906003)(36860700001)(107886003)(110136005)(4326008)(8676002)(336012)(186003)(356005)(55016003)(82740400003)(81166007)(86362001)(26005)(83380400001)(9686003)(40460700003)(47076005)(40480700001)(82310400005)(70586007)(2906002)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 08:58:24.3503
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 48c75b1b-8986-4238-81ba-08daadc2408f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6389

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcg
MS8yXSBkb2NzOiBEb2N1bWVudCB0aGUgbWluaW1hbCByZXF1aXJlbWVudA0KPiBvZiBzdGF0aWMg
aGVhcA0KPiANCj4gSGkgSGVucnksDQo+IA0KPiA+ICtVc2VycyBzaG91bGQgYmUgbWluZGZ1bCB0
aGF0IHRoZSBzdGF0aWMgaGVhcCBzaG91bGQgYXQgbGVhc3Qgc2F0aXNmeSB0aGUNCj4gPiArYWxs
b2NhdGlvbiBvZiB0aGUgUDJNIG1hcHMgZm9yIGFsbCBndWVzdHMuIEN1cnJlbnRseSwgdGhlIG1p
bmltYWwNCj4gcmVxdWlyZW1lbnQNCj4gPiArb2YgcGVyLWRvbWFpbiBQMk0gcGFnZXMgcG9vbCBp
cyBpbi1zeW5jIHdpdGggZnVuY3Rpb24NCj4gPiArbGlieGxfX2dldF9yZXF1aXJlZF9wYWdpbmdf
bWVtb3J5KCkgKGZvciB4bC1jcmVhdGVkIGRvbVVzKSBhbmQNCj4gPiArZG9tYWluX3AybV9wYWdl
cygpIChmb3IgZG9tMGxlc3MgZG9tVXMpLCB0aGF0IGlzLCAxTUIgcGVyIHZDUFUsIHBsdXMNCj4g
NEtpQiBwZXINCj4gPiArTWlCIG9mIFJBTSBmb3IgdGhlIFAyTSBtYXAsIGFuZCBwbHVzIDUxMktp
QiB0byBjb3ZlciBleHRlbmRlZCByZWdpb25zLg0KPiANCj4gSSB0aGluayB0aGlzIHdvcmRpbmcg
aXMgT0sgaWYgdGhlIGZlYXR1cmUgaXMgYSB0ZWNoIHByZXZpZXcuIEhvd2V2ZXIsIGlmDQo+IHRo
aXMgaXMgc2VjdXJpdHkgc3VwcG9ydGVkLCB3ZSBuZWVkIHRvIHByb3ZpZGUgc29tZSBtb3JlIGRl
dGFpbHMgYWJvdXQNCj4gdGhlIHNpemUuDQo+IA0KPiBJbiBwYXJ0aWN1bGFyLCB0aGlzIGRvZXNu
J3QgdGVsbCBhIHVzZXIgaG93IHRoZXkgY2FuIGZpbmQgdGhlIHNpemUgdGhhdA0KPiB3b3VsZCBm
aXQgdGhlbS4gQ2FuIHRoaXMgYmUgZGVjaWRlZCB3aXRoIGEgZm9ybXVsYT8NCg0KTXkgZmVlbGlu
ZyBvZiB0aGUgZm9ybXVsYSB3b3VsZCBiZToNCg0KTXkgZmVlbGluZyBvZiB0aGUgZm9ybXVsYSB3
b3VsZCBiZToNCg0KVG90YWwgaGVhcCBzaXplIG5lZWRlZCBwZXIgZ3Vlc3QgPSAgMU1CICogbnVt
X2d1ZXN0X3ZjcHUgKw0KICAgIDRLQiAqIGd1ZXN0X3JhbV9zaXplX2luX21iICsgNTEyS0IgKw0K
ICAgIHRoZSBtZW1vcnkgYWxsb2NhdGVkIGZyb20gaGVhcCBieSB4emFsbG9jL3h6YWxsb2NfYXJy
YXkgZm9yCXZhcmlvdXMgdXNlcw0KICAgIGZvciBleGFtcGxlIGFsbG9jX2RvbWFpbl9zdHJ1Y3Qo
KSwgZC0+c2hhcmVkX2luZm8sIGV2dGNobl9idWNrZXQsIGV0Yy4NCg0KSXMgdGhpcyBmb3JtdWxh
IHNvbWVob3cgbWFrZSBzZW5zZSB0byB5b3U/IEkgdGhpbmsgd2UgbmVlZCB0byBoYXZlIGENCnJv
dWdoIGVzdGltYXRpb24gb2YgdGhlIGxhc3QgcGFydCAoYm9vdCB0aW1lIGFsbG9jYXRpb24pIHRo
b3VnaC4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSWYgbm90LCBjb3VsZCBhIHVz
ZXIgY29uZmlndXJlIGhpcyBzeXN0ZW0gd2l0aG91dCB0aGUgcmVzZXJ2ZWQgaGVhcCBhbmQNCj4g
ZmluZCBvdXQgdGhlIG1lbW9yeSB1c2FnZSBmcm9tIGRvbTAgKG9yIGEgZGVidWcga2V5cyk/DQo+
IA0KPiBDaGVlcnMsDQo+IA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:00:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:00:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422597.668727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGYD-0003lH-N3; Fri, 14 Oct 2022 09:00:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422597.668727; Fri, 14 Oct 2022 09:00:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGYD-0003lA-JS; Fri, 14 Oct 2022 09:00:17 +0000
Received: by outflank-mailman (input) for mailman id 422597;
 Fri, 14 Oct 2022 09:00:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojGYC-0003l4-Bd
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:00:16 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e0ef6bc-4b9e-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 11:00:15 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB8058.eurprd04.prod.outlook.com (2603:10a6:10:1e7::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 09:00:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 09:00:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e0ef6bc-4b9e-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NaN2wjQQOZVEHJZ71X/vI07Fg9G+51Pq76RWskmumBKrMvtqdbv5rwgr7IMg+CAVPXhS8lMM2ALv8sG7XCYjyGap1AmVlTryrLVTPlp9KR6MQfRY+WaTeXDv8QzFT2mWolXevJ3rK8a3hW+tkqrnhu1v3nBqkboc1bOPSPyG/WjlmMEhr3KvZ/BvxrDnJd2BcW4v04Kw3bSqJja25tHXdDZDp09DKsF+pt1GXVVb1OZfScs3Yc2NLmT2Zy6cQVaw0iEvRsBey2aHeItSzWxYRZnsdC19Al5+1BYCpjwOdntSD8oz0Hhx9hrycFp1mtWYmZiWB7yAPO4XszjfMoSb8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CjplBNW+RgXUi+BL/4Ogjbzs6ieH+wtWMYCTOnWjWzg=;
 b=fp55HboPLeXVK8XmzVh2cCzDKRaMuIns+snUsiBxCoeVaBHtmf0eyg8D/gr1jXfdw+WGDUJsWzngpuu27eJ/KVwnyZ8EFW5vbxQ6+NJTa2haAwjDnJjoPMW0Q6mATeivP0Z+Th+1V/8fHEbjva3HWGT74gk656kIhv86ggozApFL3vfe9AX4i4uT8LjjbKwIZThr8tyNHAJzkAk20x/v56OjXkt+Zo/TzrX9PUlqDXQcI2lznaPKJhPFlenn6qPsbZOeu5C9pBE1r4YELV5Bzgy8L0+RR8bQRSX2nGy7ivT8I7zgOcti0zllOEOpGAr3WfrpcFy0YMmEwrKO2AVJeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CjplBNW+RgXUi+BL/4Ogjbzs6ieH+wtWMYCTOnWjWzg=;
 b=Xvj3IBWX8n8UNPEIo/dheXUkkdqZiFo3P7UF2MlkRRtuqdgl91h90IEJI5MVcU85YIiaKI8F0bBeJTabsYFqnD0bAwfgRgBObwaofdBQPktquU/ScTm+dEGfZvGZAyjqVymSW0+jP5+Smq+c0Tpx5gXo9X94vck2+MULEAicZo4Sz0POEcmFtd7+sA1hWhLEqz94FL/ISCxrRq92og6clH8PK0HdM+SPXR3TXq4lMBKsBE2HowN7OSUCb1EIuwL7qTtMl2eFriNyuVVQ+H65+6spmlr2zHMbnSVZELfxgCKhHa/ivh7czsHb68MtGu2MFO326tcRTF50eGYxVV/irA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5220f340-5380-0b77-86bb-323898efc208@suse.com>
Date: Fri, 14 Oct 2022 11:00:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Henry.Wang@arm.com,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
 <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
 <Y0gXnD4jsyIp2kKb@Air-de-Roger>
 <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
 <Y0kbN+Zp6F2kBFGz@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0kbN+Zp6F2kBFGz@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS8PR04CA0005.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB8058:EE_
X-MS-Office365-Filtering-Correlation-Id: a3af985e-3666-4e6a-7d40-08daadc280d5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LxOJJIWSiv2xRnshwIsUmY0CCpET+5O588ualW7Gf5bkgnBH8iyJuLzTSgT7upuBSZqGlijA9O2HQo4OdpJwjJ3Z3OaaXxoK6MLuIEOB50TCEeinwhmGQ8+MvcQa/iNbMkrZeFmU3M2ev514X4a50WmjxxzhNPLM4BcvhjfVw1ZC3/rHagHHeX0t0l0vcduYfOi0KD3nxUaa03G4nEGRSYiPK7sDibBqdizNjsxuHqFTv8rY7yy9W+LOcvUU4s7DVbex/26AyDyzc+A8OP33NDc5cwXAYUpTsdhjlLUV5nPAkK28yPhmAW6jQnBc40TSi9aKedaUK3S6wMTVyfQZ+xtSd/JGbQt6TQ/sjiTQMRT1Z4hS1uIFTd50PWcDdbi8KJAcqOtRN+U3qocyPG0ODzXCyREyPpfO2gx4s235muZ6Ugx2BDdgIA5+NQkyRwp6DITAptVs6Fis5OndkT+NbbylwMgLwSQ1kjKb680uoAtxVe78LL5eOm585W/x5GIjdex2oN6t6ThB07GeoT4wf4XsPKrYw1vueVj+WBoYv6LfI9f8T6v2rUvj84HJ5tjipTsTe5AIXNARjf99LwfB835szESKUrprsNr4CFxLvVx8rbQYBGXS0Gxns3k/MPuq0MSuvHd5dDyH9GKb9gbbLb23grRVgRgSsUiZj6neaSh/kPjt0RxzhYL5IYRZbOs1Cyq5g9vxwnpvyQ4ASnk2AJWFx7r9uhT2hA8EsllR5a4Baax5cMJEC58oOu5ru4iWk/t8x54N1gNup0IckBXAmRzK0Rz5l9fyNobMl0b/PAA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(376002)(346002)(136003)(451199015)(2906002)(8936002)(41300700001)(5660300002)(316002)(54906003)(478600001)(6916009)(6486002)(38100700002)(6506007)(26005)(6512007)(2616005)(36756003)(53546011)(8676002)(66476007)(66556008)(66946007)(4326008)(31686004)(86362001)(31696002)(186003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SFVjaUY3M3RMY1YwZVYvakVtNWlZV1Vld3R5cWdYWjFXTTZaZWdRSTk3TGtu?=
 =?utf-8?B?SUQwdUhLb2U5Vi9najQvV0xsMFpFY1NESjdKcktHTE9nU04wWnlLR3VYbnhI?=
 =?utf-8?B?RlUxUkZ0azVmd2hxeGtLY3grSUZIcHF4cGE5dE1EZm1NdDRVSGZSL3ZjdUcx?=
 =?utf-8?B?WHlEZDJUK3prOUg0VVdyQnJja0piU21WYU1OSXhPNkN1NWVsazZLVHUzOExr?=
 =?utf-8?B?QS9JdjY3STFLL2ptV1k0R3ZzZGd0TmJXUEUyeld4aDBpbmJycFdLaDF4dHpB?=
 =?utf-8?B?K1V4UXVYOUVXVlVkR0hMSUVwTThJNWtvdGQweWszY2tBYmE1Z2IxeXl5ZzZo?=
 =?utf-8?B?b09Hc0xvZ0VEOVpNQzJCaTZ5b0ZuVEZxTHh3TmxEOHZkN0Z5TjRzRyswaUlP?=
 =?utf-8?B?Sm9KSVVyVkxxeXBxMW1xOStEUDkxRGNpemxkOW9UNjZwRWg3QVY1NmlZV2k3?=
 =?utf-8?B?MldxMXhuYnZpaWJreDZ2c0svc1EvOVZqWVBDWmZDd01oYkRmNHZzWTV2YlN4?=
 =?utf-8?B?aFJUTnh4ZVNtUE5VRXRHMHhVTkJ1eVBFdVRUZU5ScDl1blJPd01LM1YxMjRy?=
 =?utf-8?B?b0xnbzZ5bVBEWllhcHYzVDdQQTRvanYySlEwY2tQRndhbzNYaE8yOGhiM25x?=
 =?utf-8?B?UWlmMjBsYzgxQ3MwQ3lHQmRMSDZPY3BtQjFMeTVaWjRVNldvWmpzcGtsWjQz?=
 =?utf-8?B?R3pqck1mN09ISFZFNVQyM2NIRjJ0cnhjMzNjekFaUXlMV1NMVnQvTDVGb2l1?=
 =?utf-8?B?dmpnMWJ5SEQ1ZEVzTStxY250U1FGZHczSEF3cHJLbHJiSWFqNmYrVUcwYndO?=
 =?utf-8?B?Y3EzcXRFRWpHVEgyOWZWcGk4eUVpZVFQY2I3blo0UVFoVVZCT1A5ZkpSL2g0?=
 =?utf-8?B?UmQxL2NMM3RVZTJaSnBoY2VKR2ZDaHFoK2tETjByZWlnb3Rlc3o1RW5ET3VI?=
 =?utf-8?B?RmFRaDRBZ0U5QXhEWGFJaDRNZGR0ejJCWkVuZ0RrQUJOMmdKcm9qcHdvYS9p?=
 =?utf-8?B?RStJenpESklDV091ZlU0U2pXL04vTmlKc0hYaWI3VWYvVCtac1YxdlUrYkFE?=
 =?utf-8?B?czFyWjdZZXp4RGJ4cldQcEg5WUxXN1F2eWRFdXhOTGx1U3VpL1kxWFNVYzdh?=
 =?utf-8?B?dE95STcvOGhTbFVGMlVvQnNQMm4wM0hBbFI0ejU3TlhrcEVvakQ3R1h1emNw?=
 =?utf-8?B?WmpuUXZQUktuRnlEWW11RFRQcjJDY09FOGwyUTJ2ejRxQVV1b2FLb2o4d2Fa?=
 =?utf-8?B?UWwxU1dSbndrMW1lZkpQb1pMUEhEWG90TWhKSUV3dFB1K29ocVBtVXp4WExV?=
 =?utf-8?B?WXBDYUJIc25EMlQvQi95bjYzRVlYNEdhMmhHck9UcG9zckF6cHRRbHpJek9D?=
 =?utf-8?B?TXRtNmNDbGhKMm5xbGVzUE1xbEVsS2JmMUkzWGZiandHbGVLNnB1NW82L3Er?=
 =?utf-8?B?QXgyY2prZ3dkSTdrNFpCVGRjaHBVdUJBbW9RSDhIcVNpTE9zelBmZWFUUDk4?=
 =?utf-8?B?cGpsck82MEpZRitxYnpvRnNMQVZFTGs4Q3JiWk9NVFAwSTZvbE9mUmM5L2R0?=
 =?utf-8?B?VXlBUk1XOVpPbUZYL0EwRkhaQlp0U2lRWStKRWlvbjdBZGU5VHVySEllY0pa?=
 =?utf-8?B?Y3E1UnAwOTA4cXB5VGVHbjk2RE4wRUYxYW1uT09jMlZrYUdVd2cxZUFBY0My?=
 =?utf-8?B?T0NKcXFsUHlkT2oySjFQc1AzUm1Tak5jYzFtSUFxUmVzc0s2VUY2UExiY1ZH?=
 =?utf-8?B?UmRhR2NLMXBDc3VXYnJHYzhRRDVKTVNNVlBqcFJnUDI2aHJkbW5DYTFIUHdS?=
 =?utf-8?B?T0p3eGZHTnF2SUdCdmJ1cVlNcUM5YkxxT0lFU3VoaEJVQ1hGMXBsNDgrbDdY?=
 =?utf-8?B?c3d2d1JtVkg3M0FmcHJsTHYxd0Y0a2M3LytFWHhQWG9hYS9jMmVXU2Y1K0Zt?=
 =?utf-8?B?U2g1MXp1MkdtVlZucGpkUVpFUzFqc0QwVkUyK3FuY3BOR2NzcjBwRGtPQ1VF?=
 =?utf-8?B?SmlHS0tNVFgybGhCT0VHSXJPS3ZqNXFUZG4wbWhzRHNLVjZTSDFLczhXQU9j?=
 =?utf-8?B?NFE5WWc5MmY0M2JJOXY3ZEhneHJ6UllMeEtpSkt5THQzNFVnTHpIbzU2WWIv?=
 =?utf-8?Q?KCOySxNlSoF1S5x1+7pZ5jxYf?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3af985e-3666-4e6a-7d40-08daadc280d5
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:00:12.4331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fvnfcz1BlM63PEW+gV/QEy2BhgddvQbT8hbGiMEBn+xiufYnhGbJaxryZFJdzbnS3+02puOhfqeIfrvp8JnsVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8058

On 14.10.2022 10:17, Roger Pau Monné wrote:
> On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote:
>> On 13.10.2022 15:50, Roger Pau Monné wrote:
>>> On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote:
>>>> On 11.10.2022 18:02, Roger Pau Monne wrote:
>>>>> @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
>>>>>  By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
>>>>>  when hardware hints recommend using it as a blanket setting.
>>>>>  
>>>>> -On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
>>>>> -option can be used to force or prevent Xen using the feature itself.
>>>>
>>>> Why would we want to take away this level of control? Shouldn't we turn this
>>>> on while in Xen if so requested? Which would then either mean enabling it on
>>>> VMEXIT if a guest has it off, or running with it turned on using the OR of
>>>> guest and host settings.
>>>
>>> Right, but then we need to context switch the value on vm{entry,exit}
>>> which is problematic.  I could move the context switch code code out
>>> of the GIF=0 region, and assume that NMIs executing with the guest
>>> selection of SSBD are OK.
>>>
>>> Alternatively setting ssbd= on the command line could be taken as a
>>> value to enforce for the whole system and prevent guest attempts to
>>> change it, not exposing VIRT_SSBD, AMD_SSBD or SSBD (haven't
>>> looked at whether not exposing the SSBD CPUID related to
>>> SPEC_CTRL.SSBD will have impact on other features).
>>
>> That would be my preference (albeit I'm uncertain about the "not exposing"
>> part, as we don't want to misguide guests into thinking they're unsafe or
>> can't guarantee safety when requested by user mode code), but ...
> 
> For ssbd=1 we could expose the SSBD controls, as the guest trying to
> turn it off would have no effect and it would still be protected.
> 
> OTOH if the user sets ssbd=0 on the command line then exposing the
> SSBD controls to the guest would be misleading, as the guest setting
> SSBD will have no effect and thus it won't be protected when it thinks
> it is.

Irrespective of your subsequent reply: Unlike "cpuid=no-ssbd",
"spec-ctrl=no-ssbd" ought to affect only Xen itself:

"On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
 option can be used to force or prevent Xen using the feature itself."

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:17:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:17:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422604.668738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGoZ-0005Zx-7t; Fri, 14 Oct 2022 09:17:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422604.668738; Fri, 14 Oct 2022 09:17:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGoZ-0005Zq-4S; Fri, 14 Oct 2022 09:17:11 +0000
Received: by outflank-mailman (input) for mailman id 422604;
 Fri, 14 Oct 2022 09:17:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojGoY-0005Zk-Gf
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:17:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojGoY-0005F3-AC; Fri, 14 Oct 2022 09:17:10 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojGoY-0002Cl-3J; Fri, 14 Oct 2022 09:17:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=8+LKRJHWyAN3iPT3jkXl2MGacacw2AlJCHt1FqrQQtY=; b=nXbfnN9hbWCu2sDoK4Hh/roaHN
	lSqVF1rYqEwO+w12m9mLhXJM8yfS/uBozxeSl6oJsyHmp3de1D5qevodPa9IJ1TR52l3vHhXZXYm5
	oEKqoEdPYQWfkSuW1AodYEr+djQntCgIQ4yqRkbOJfMnMeGGQ3xZ7TuKTijUGTrmSv3A=;
Message-ID: <3cfdcd2b-cc18-0585-d837-f5932d9eeb0f@xen.org>
Date: Fri, 14 Oct 2022 10:17:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-2-Henry.Wang@arm.com>
 <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
 <AS8PR08MB799119B54A5FE419CDDB9C1592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB799119B54A5FE419CDDB9C1592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 14/10/2022 09:58, Henry Wang wrote:
> Hi Julien,
> 
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement
>> of static heap
>>
>> Hi Henry,
>>
>>> +Users should be mindful that the static heap should at least satisfy the
>>> +allocation of the P2M maps for all guests. Currently, the minimal
>> requirement
>>> +of per-domain P2M pages pool is in-sync with function
>>> +libxl__get_required_paging_memory() (for xl-created domUs) and
>>> +domain_p2m_pages() (for dom0less domUs), that is, 1MB per vCPU, plus
>> 4KiB per
>>> +MiB of RAM for the P2M map, and plus 512KiB to cover extended regions.
>>
>> I think this wording is OK if the feature is a tech preview. However, if
>> this is security supported, we need to provide some more details about
>> the size.
>>
>> In particular, this doesn't tell a user how they can find the size that
>> would fit them. Can this be decided with a formula?
> 
> My feeling of the formula would be:
> 
> My feeling of the formula would be:
> 
> Total heap size needed per guest =  1MB * num_guest_vcpu +
>      4KB * guest_ram_size_in_mb + 512KB +
>      the memory allocated from heap by xzalloc/xzalloc_array for	various uses
>      for example alloc_domain_struct(), d->shared_info, evtchn_bucket, etc.

There are also some pages allocated using alloc_{xen,dom}heap_pages(). 
We also need to take into account runtime allocation done by some 
hypercalls (I can't remember which one) or subsystem like OPTee.

In addition to that, you also have memory for the system. E.g 
frametables, Xen page-tables, various driver allocations...

> 
> Is this formula somehow make sense to you? I think we need to have a
> rough estimation of the last part (boot time allocation) though.

That's going to be hard. It will vary depending on your system and this 
could change in the future as we add more features. For instance, I 
expect the PCI passthrough will need some memory to keep track of all 
the devices.

I am worry the formula will become complex. Ideally we need to have a 
very simple formula. If that's not possible, then we need to provide a 
way for the user to estimate it at runtime (like what I suggested before).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:21:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:21:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422610.668749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGsU-0006wz-Ng; Fri, 14 Oct 2022 09:21:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422610.668749; Fri, 14 Oct 2022 09:21:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGsU-0006ws-Ka; Fri, 14 Oct 2022 09:21:14 +0000
Received: by outflank-mailman (input) for mailman id 422610;
 Fri, 14 Oct 2022 09:21:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojGsT-0006wm-Pm
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:21:13 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8ba7c610-4ba1-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 11:21:12 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PR3PR04MB7226.eurprd04.prod.outlook.com (2603:10a6:102:8e::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Fri, 14 Oct
 2022 09:21:10 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 09:21:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ba7c610-4ba1-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LmBjyOZdWnrSonQfF/WZcFhJsTa4WrvQLlXBTHGIrmUgQLVQJBYLaxWSCQJW/i0xfyJ2dCLegQSgAOo5UhndIK+zK9kIfSFlUzbLLC4fMtG5nWgBmbDYV+RIQ/RSg6QZ24pBwcxX09kKjoWZGAfyJCUnUkOaJSZdUAbUkQv+/U4e+vFaob7HW4hSDJVat4eNd9FgGmGGI1EZDpUT9GhqAif4hCQqzcnb62h/qMPFmkOfdF1PflteYpklR766WNBGt9gMAt9ELXAy4zAYVt1uyslRH/1sjWe+sdtfqPLahyo5o+b8UJjqma+nd2C3YGfPz3sRuMNWuOABDyhMhu0F8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=03wwF/dVQjIzfT260xxVyDdVXv1EHXZkwy2odbHHj3M=;
 b=IupBgLlWXgprui/vuvyw+2mqUYC8GyLNJoZQWxASd0KxY2O0OG09/gyoaAr+364AMkdBUCT2XyJm3HzCA7cVUiu1Xgy0ijF7OEAWevU+Iwr023WJdO+wcWboOjxJA06jXjAW0mFBnQ/WPI3tX8OJPjqFb2MlOTGKE5cs5aYOxZrZDaV1ZJSEJ4AMJblIWuAK/Wg0BbNDFfDrsH1zK4wj0H3liX2nfWl39Dk1lXXxyLQ1JAumSg5+w5EF9SCvBYr7UcryliLjVfYVsLNk0UA8YnohBY3CtY9PmniqVfV6DmzdmXadKxtPKc6GBAZKzCblzCzG2t5TG1uvbT5otyHDaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=03wwF/dVQjIzfT260xxVyDdVXv1EHXZkwy2odbHHj3M=;
 b=GEeAYQlVsHcYYZnR3lCbJC4AynX5MUxLpGTMQ6IBchMacv1tGaQvXUwA2LXfT0/W7zeT69R9OhKB4nnHYUCv2abrca4HGsDDm69xtbe5SO68LTzoWmN1SQxo6QcOi8qgNUB1XnnTuuRz2KwmqygX2QRTjyFsfxzW1K3Tpai2BM8vezfcOctEgz1wljKVQg1aPDEFnAiJMnaNDGhPy6aBTkDzCck34nAu/Tt8zeRIhT0J0DPzaDnauUCivJ/ihyFbKfcTmV7P3ZLfVE+DcOzdpOgVC6MD73k/ODIxAHQuCsQ21E7CN1jM+zJGNb2Eh2X0mj0m/Fv3MUnTg+/RpzO05A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
Date: Fri, 14 Oct 2022 11:21:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Wei Chen <wei.chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 xen-devel@lists.xenproject.org
References: <20221014080917.14980-1-Henry.Wang@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221014080917.14980-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0093.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7226:EE_
X-MS-Office365-Filtering-Correlation-Id: 9a00e155-6c35-4164-2a07-08daadc56e6d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	j4RE54uDWCdo5l2vm9qryOva9h3ZMM5y2V8tfLEjuCSY1ExbDk0GiynAKi/osy6gV1v8jnMkfEsYRLvJkVZMFprFkseIIQ/mCMewSGRrHOO/dZ0/gF3uZ0RppSOcYwdSzPIN/LDyIwlrXmBYmMo+6KjrGz7hpBHfl4is/yZINnTvBiI5Kqvz5JZZlsa/HyoX4M7YWALw6Tz7gHGVl6khOPGk5XsesU8GqqzvNHW69+asL5YaZWBdEILd2jlfYBpXY8me75GrX8jm3+kNLraZs/LQMxWkSq17h6lOpP1oWvcTTneWlP+ZwLMp2Ltx5TRykKWQKv3rhwIInK5f4VMK7H0mXZAPtgA9HTlI2d18R2eDoMYIboFhpNZwDFOZiPkTb/U7rdF/sXlEvubwZuAB0CX8VXAIlXSl57iiaa7/tiCcjjb2I9B9K5rDtyzeF5OiVZAdvWRTM20PPk+n/JiMc/0NWmelaXUOJSuKO0wQUiPKyBcIdu2w63Hp4OTVqnxSf9LdY8YgCDjSuVOdLMOoneW23LEBEc76r+OcST+39c87zwEhDRC8JfRcue29s3RHT1hF9Acl4pgjvP2YGp2QWsYLxfUsOZSoo2DctQSEddVaOLvSw48eSo44bzhdUwqtLy+hUxTfwbvkX7LEWsdcuXDw5UMpmODeO4XP6z0ZQ5KMq2fG4ejq3hzmUoaDbhlAmHMMIfWBy46AkiSENHvMOvewgo6dPJNuv3Rfhqp4K5wSbfzORiTjnc55+XoH5c5hvyJSCpnTF9SM6DhvPVFPVp5bzQrYOywewF3eyX/ALQc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(346002)(39860400002)(136003)(396003)(451199015)(31696002)(86362001)(36756003)(31686004)(38100700002)(2906002)(5660300002)(83380400001)(2616005)(6506007)(26005)(478600001)(53546011)(6512007)(186003)(6486002)(54906003)(6916009)(66946007)(4326008)(41300700001)(66476007)(8676002)(66556008)(316002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V2oyZ1UrZGlzUmRiRkFIR01TT3ZYdENTOE9NTkZPV3U5UFFwSXF2Z25xZGZQ?=
 =?utf-8?B?TFBBUkQzVkdMdTViTnJTUVdyYmRPT2FoK2k5QUtzM0tYNm1JTHFNaTNkSmdI?=
 =?utf-8?B?a3ovQ2tuQ1Z6UzVMd0psK3Y2bWNYOEJheU1lZWkzWFc4cU1HNzJkNjh5Z2FM?=
 =?utf-8?B?ZVdrSzE1clV2SmVQRnp5cmFlT1ZNT0p5WWduc1cwckJhbGc1b2d6a0xpaDJE?=
 =?utf-8?B?MC9XYnl6OEhhTWVicXJranVreTVBR2lCZ1FlclpzZW1IUm9scW4wMUQ1dXFT?=
 =?utf-8?B?clFiQzliM0VIVTR4cTRwQVpvWEJvWUUzSXQ1YytOTVFnQ01ucUtoblo0VHVR?=
 =?utf-8?B?U25HSm81czR1b1R5ekJSY2YyVFJwblg1eXN4S1FPS095UVpqTGhPaUpJb0sw?=
 =?utf-8?B?QXl6YjVQV1hJMkdwTEhLbCs3Ujh3Z2k0aU15OHp6Z2xNQ1prZVdhZTZKYnBP?=
 =?utf-8?B?NWx1QktEd21XdDNsYmsyTVVXL2hLeGZuYkZNUVY2ZDlRcmgwTkZNSUUzTjQ1?=
 =?utf-8?B?ZFhqcm5SdUN4L3NvYjYrdy9TaGVSNDU5ZHB3dVMrbjN6bmNndVgxTko1czlu?=
 =?utf-8?B?T21KdVJSMllieUhhMldxdTRjeTh5Vk1kMnRlKzR1cTNQVWtjdjJ4ZklEZVRE?=
 =?utf-8?B?dmhOMk4rUXUvM3VwM1hPUmh1MlRHSXRwWVVHVjZiR0NxckNpWG1nRlFVYTJ1?=
 =?utf-8?B?MVpYRkQ0U2pVVnpaYU8zYlM0aDR4UUVCMkp2OUhNcWFESjU2bXVaK3RaYXRH?=
 =?utf-8?B?c1FyN1V4bmFVK0FqTkFyamtmM1dSRFFvMnpma3BmZHZxR2xxZk96WTBnN2ZK?=
 =?utf-8?B?QitMNjFJbnlWa2ZmTHZpOVZzM3J5WkQ3ZmR0MW40YlAvK3c3RTN2YWpZQVl6?=
 =?utf-8?B?QlR3b0l1QmZQUmFKekU5YWpIZUxEdnc0WW1OTzlUUjg3YjlCK2FCQldCbWZi?=
 =?utf-8?B?RmRzWW5SNEpLRFFhL1hmd0dIcjMxN2ZHbmZ1K292TE9jV0Zob1NxUG5nTUpl?=
 =?utf-8?B?SW1IdFJ0S3V6NTJkUlI5QkdQNWJXd2dhRWJtTnl6YktEQWdBcjJsbVAzMlZG?=
 =?utf-8?B?TGtSNTdZWWMwMEdTcmxRdlg0MTltdWxiaTk3MC9uQ1FqWlA1RGl5cTdteE5B?=
 =?utf-8?B?UFpEUC9KTWpaMWFob3JxWko3UlNYVVgrSmtxQUFPV1YrU0pOT2JxUGpNMmQ0?=
 =?utf-8?B?bWNiREQ1di8zc1V3TlhCOGNlYlNjV2dLSFA2dk5HaGJPOGQyRU4xRVdwcm91?=
 =?utf-8?B?RE5CejErdW9oMlhlZ1phQnBZM1hybmh6NGZGZkZxYit6WnhvQVVyTjY0RC91?=
 =?utf-8?B?QjZvenAwaHZFemF4azh5bW1JRVlKTEZmd2xzRk42Ynl0UFFvY1JheUlRRk0y?=
 =?utf-8?B?SHdVRmxRbzNSTU0xbktkLzY1OUtPL0pjVGFBS1BwSWxWemZmQ0JsU29LME8r?=
 =?utf-8?B?dm1xKy9Sd3BDZEFvQmFsSEJGVHAzM3M2OXNQVFdUeDFKSmNKUlE4T3FLa1lk?=
 =?utf-8?B?elFQOTR2bkdVU1JmVFhQdnUxbDVrZWluM0NKbDdaNzl1L095V2todk8zRU9q?=
 =?utf-8?B?cFF4U1diQzgxVFpEMmZnYXVpaXdrTUVYZE1INmMwSVFmVE5pbEtISDg2eW4z?=
 =?utf-8?B?djFOaVJYVWVGdndXQ2tSaWtKQUlRVnlOM3V3Yk5BNkd5UmRtZzBoQ3V4aGNn?=
 =?utf-8?B?M1daWUlHaHVsbVJ4dGJpbFdJZnk0d1o1K3BVMzFBSk5qMS9jMEJES2REcVRW?=
 =?utf-8?B?K2xzVU5IYk9jWXNPdWNUZHZ2MlZvbzJEUENoLzJaSGhNTVg5TmdSNHFzT3I5?=
 =?utf-8?B?NU9MaVdqVkJvdnBTZWJ6K0V4QTVOSHdBanVSK2NkeXJDWjFEd1Bvdjc4d3V0?=
 =?utf-8?B?dEdVa2owNjlZYllYTHZHTDJPMjYyK0ZFc3hNRm5OR2hzSk12aTA3WkdyWWpY?=
 =?utf-8?B?Y0ZLcUpady80WEpGQ2RpZG5QTi91OWRDcUlSQTJpd0t4WkM5akQ4MVJqUThO?=
 =?utf-8?B?MTlGai9yMXVWejY0NWtZRHJCMnpLeDBoemhiczdmUGVVTUVyUk0vVG41SUVB?=
 =?utf-8?B?T0kxNW9kaVNwYk05WjVOVWl3K2JOUkRVdGlrL3JnUGlTWTlrcEJLZHVvNGYw?=
 =?utf-8?Q?z0Iyz6o6vQdbx3FtnKXuKECgn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a00e155-6c35-4164-2a07-08daadc56e6d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:21:09.9938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LjG3wEAcCZOpfmxkhZ4a0jMo0u/UI9AVo+pdq0k8+qZGR5F7Ko+Ql87iweoEWUQ86Pgo01M7ulqhD+ZuD3tg8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7226

On 14.10.2022 10:09, Henry Wang wrote:
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>          BUG();
>      }
>  
> +    /*
> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> +     * when the domain is created. Considering the worst case for page
> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
> +     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
> +     * the allocated 16 pages here would not be lost, hence populate these
> +     * pages unconditionally.
> +     */
> +    spin_lock(&d->arch.paging.lock);
> +    rc = p2m_set_allocation(d, 16, NULL);
> +    spin_unlock(&d->arch.paging.lock);
> +    if ( rc != 0 )
> +        goto fail;

Putting this level of knowledge here feels like a layering violation to
me. My first suggestion would be to move this call somewhere under
p2m_init(). If that's not possible for some reason, I'd like to suggest
passing 1 here as the count and then adding a min-acceptable check to
p2m_set_allocation() along the lines of x86'es shadow_set_allocation().
That way you'd also guarantee the minimum number of pages in case a
subsequent tiny allocation request came in via domctl.

> @@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d)
>      if ( !p2m->domain )
>          return;
>  
> +    if ( !page_list_empty(&p2m->pages) )
> +        p2m_teardown(d, false);
> +
> +    if ( d->arch.paging.p2m_total_pages != 0 )
> +    {
> +        spin_lock(&d->arch.paging.lock);
> +        p2m_set_allocation(d, 0, NULL);
> +        spin_unlock(&d->arch.paging.lock);
> +        ASSERT(d->arch.paging.p2m_total_pages == 0);
> +    }

Is it intentional to largely open-code p2m_teardown_allocation() here?

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:28:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:28:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422616.668760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGzr-0007hi-Ho; Fri, 14 Oct 2022 09:28:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422616.668760; Fri, 14 Oct 2022 09:28:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojGzr-0007hb-Dd; Fri, 14 Oct 2022 09:28:51 +0000
Received: by outflank-mailman (input) for mailman id 422616;
 Fri, 14 Oct 2022 09:28:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojGzq-0007hV-Hf
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:28:50 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20057.outbound.protection.outlook.com [40.107.2.57])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ae65a4d-4ba2-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 11:28:47 +0200 (CEST)
Received: from FR3P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::6) by
 GV2PR08MB8437.eurprd08.prod.outlook.com (2603:10a6:150:c3::16) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.29; Fri, 14 Oct 2022 09:28:44 +0000
Received: from VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4a:cafe::16) by FR3P281CA0053.outlook.office365.com
 (2603:10a6:d10:4a::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.11 via Frontend
 Transport; Fri, 14 Oct 2022 09:28:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT015.mail.protection.outlook.com (10.152.18.176) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 09:28:43 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Fri, 14 Oct 2022 09:28:43 +0000
Received: from 2b037f28070a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 43EC78BA-DF87-4BA3-9543-6832F9E5A635.1; 
 Fri, 14 Oct 2022 09:28:32 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b037f28070a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 09:28:32 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB7463.eurprd08.prod.outlook.com (2603:10a6:10:356::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Fri, 14 Oct
 2022 09:28:30 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 09:28:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ae65a4d-4ba2-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=G12+kTDfzZpJ2BH9SWvJqwcVTgGfUtUGqHCZRRzwtwE51N0GvSmSkPDO3NFpCwn+0xZmSm6s2NJSewppUVb89mxDrwsbwwSaRfyIqIQNH6MyW1kyV58VYbxT2e+pahDNB7aIuIy0ELB0hq5c6O+OPtfuz7+B6J/KucNU2Wu/0G21E5RDBgUk1nTWcO6bBm13IQ9g52p1DhvqCa88SHiOjcyggn3aSHWTC4pfFLAEnDyY3sMiL7Gil9kzx8PGhCgi3UmRx6O3bdAZ1O9OnNJXSip6/LLQMd2GjT/zeZ14TVbWhEAQnc+EcvzE9A3nN8eRgMuYe0mujHkPtTdgNRo5xA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LBWfPjwQmtuWDY3ksijI4H40WjzGzbvm6P9YpHb9phQ=;
 b=BJ5/g2Lgyj3u7byRDJ2jrCy2rgEYm2hwk7Fr2ngw9slDasXvwq5DS6VgieRWqxL2aRD9xaHaTnPLze06BNCLDISotRofSt8zOllB4mPg8Wz13yBBFihjAKeuG4inWo6zpoUQbjAWQ9eKerCuBe5pkWIG2O5eeQCs0EfSAFSUdWUwN8WEIG4S67uR1g+pzK9lsLN2xCMbcRJ2hLP1yoKO74RclrtiKIkNx8bEVrxW3iYlAlIux3s6RbgCOnAMBYIcaa21vKthyV/ix5KL/uL9wNZO118EzWasyQ7YzjuZ5fUOSawl6bWTOt71Tq2T1tCJ+8A/y5NI1Fzyeb/7vI9SxA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LBWfPjwQmtuWDY3ksijI4H40WjzGzbvm6P9YpHb9phQ=;
 b=LYReN2QCYtX+3zVnS10v0l9PxjIIgKKxlw0cX9NMqEzZauTspjsKW5C9+nQ5nCqMesiWYF7eETdo53uOdPBUQW8eW0OpxJlrpaeLOokjN9v5SVHJhOEaN2v78lNSLJldR+oemFyeAFxqPHDV7zQO8awxg+BJPZyeK3bTm+4Exl4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gURWTbtE4wQ4ZEeGzJfIkSwpIzoL56snikmSfl+vdHxRRhO8yzRi7WZydXPJ14ZhbxDqpzIUCDrNF0FakMdXd8E56MHDCzSB4g/QZyhTLOyxMUmrP7tR/EGg+7y6xU2wBBTdvUtyU5h1u4VKsUQTc3DYyMIrSNX+DluGgBzXtd/BeD4cQwrgp8kLxvTtz6xe0mj1fqG+E6g9U8/JDVOHREY98xwOmiUGxOkVbjnETSEb6aOqY7mUAk832z3ylZoHUG9sn09JIyVJ3Ht4Tw9hRp4mhTCwDWuQnyK+PSQU1cNRgb0fg1sVIrJPhC4g+AnZGqmh04kZQLN7MfSNaaguQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LBWfPjwQmtuWDY3ksijI4H40WjzGzbvm6P9YpHb9phQ=;
 b=b2ZGkGlvdvfqgs3W79KheFgPfio/JOc5u71Xyg2EDGs+mJGmaa9S2gJI/DDFPZlV3X03UMsceyDV5WtwAA2QeDmaOTxlb9u5vC6fIT1jgU6qvW/gRVIFMKVF8qYf5aPHj+Q9oEOWxAlDQCOiOavAKkUOfwWo6T2WgwCxZYEC/nsHdVYDkFzkDqEj41h8dibS940GQnnpm8/HlKHlINf0SxIHacGOgYCxrEsd9MODW11ix9rSc2XIF8JqfIGpk7qUug/aFilskNW3piHJ7zmMNUU+wpJdPhdatmHiwHwhgFf3TnEcFAXCA0c27zMGOsUKYCrdyePZpE+CWjc3bHi+1g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LBWfPjwQmtuWDY3ksijI4H40WjzGzbvm6P9YpHb9phQ=;
 b=LYReN2QCYtX+3zVnS10v0l9PxjIIgKKxlw0cX9NMqEzZauTspjsKW5C9+nQ5nCqMesiWYF7eETdo53uOdPBUQW8eW0OpxJlrpaeLOokjN9v5SVHJhOEaN2v78lNSLJldR+oemFyeAFxqPHDV7zQO8awxg+BJPZyeK3bTm+4Exl4=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen
	<Wei.Chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NnUwAgAAAd5A=
Date: Fri, 14 Oct 2022 09:28:29 +0000
Message-ID:
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
In-Reply-To: <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F690A591F4C21F498352633B3F53378C.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB7463:EE_|VE1EUR03FT015:EE_|GV2PR08MB8437:EE_
X-MS-Office365-Filtering-Correlation-Id: 2f0d06b2-31a9-4f70-549a-08daadc67cc7
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ijLNaHAYBhebMr2Gjp2yVZzHxbyeeA6VPgABju3UGUZfektGSkuPI82p5ylCn1Vab21UPi7fKESd08GLX5A+svzln6JwOQftMOikXeCHd1MmmJomNQs4FxAJe6tSNWukkANfcP9gazGUf6rHAXIP9B/ajgcjkhPH/T4ohryLf1BFOIUq7Yptt7RCyV9433khP/VRavA9i4p47xNlF5NEEz/1yC1Sgbf1z+vEWRq5K8h+43uaNCCpf+EvvyyXx2boW0ix2vTIYm7lUbaNzyLlSEB6W729J3y/n/qvECYA765OrsfdOnCfwe+G/4AAYxI7CNChJQVCk9O04wUEe+y07VtIoRP6DyXVuGiFH1z0hZfplCHCNhoDVeGx8Bg7LeH0IN9tl/0DLtb/6PgwqA3KXoyj45znEu27mhWC3PgmDO/u/32/4lawy+9d9NeobN/lTPpU6lGHnKbXN4J5XJ+fIDOgUojWquDNqUGCPu+9S+WzCuHW5HmJLmr8C7TRLfdfWoHSekcDnegH3813HmFiXHFCqZ3tXwuJ9249tLpliSwnq9rKZ4qRa+bPwniQddeNz5JC08Sd05c2ZdTDIwFvnyuaZfDfNIO/gEXZmf29e1MPETekQ1fpDm6OG/UoU0YJKOWRAnmZCMW7i0106AWpL0mgu4ValLLr71UkNLjyzJHD/xt+FAo4OOUqNaPf3vV6Kva8Aq6lcPQc5rK59uOwSFELkWcygBiVMFGKD8iwGIT9GhU9dmZDvVc9yZfNTbIa3/sTxybLUGlM9Ix4NmDcRQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(396003)(366004)(376002)(451199015)(86362001)(33656002)(2906002)(8936002)(54906003)(38070700005)(5660300002)(186003)(83380400001)(6916009)(478600001)(71200400001)(38100700002)(7696005)(122000001)(66446008)(66476007)(53546011)(8676002)(66946007)(66556008)(4326008)(64756008)(41300700001)(76116006)(55016003)(52536014)(9686003)(26005)(6506007)(316002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7463
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	65fa23e7-c328-4a41-ccbb-08daadc674af
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6s+Nqwk+OIPcRCS6q9RwOfP3w0bnSnENwIH9u96BHzTPSeQkIrZ5vBm/eYro7+7Z1xwdE73X90L6mxK/T91oqCl6MnFy6jwShU29jhqIBrNyudvG8iNbhXEh4VdR6oAMQj82HuIt5xZ3Z3j5eLYOfEHvd5EW/+wPVS0ljYANr8seBxLL7CgvD6QB51uy6+pXpiABD59CskU/RWL4WuzfbHGrwGMQjcKmc+aVn9VWR/6p65luX0ck+xaUiDtrRDIQ599mCVpZfKTcN3PEtvAIh3mRot0HqvYloRkMl5SP52j+wLOt9nc3lb3yFyjHqVUsO+4Qe5JJnoFRmNVeoylhOqcROB++IDq0LAVuKhPymBkaKGLst9zhFOtX7OUaffUddMKTbCCPrjdVcNajKzcpGtbaaaxGndN9syi3UEiW6pCOdBr7b+9WPWfBohAh//RxcQ4xkfhujnFN5VtilNZhSnFoC5XzceVxQwkw/T66Zk6I51sffofB6Ze7zU1OpvVF6GM+RFPeE0XD/61ioYClAp4oLnFXnZrbrLXgg/XNjp7cpLsL0x88YQF9rjmzrB0mmj7TMXaF7mCN8SO9LCUGdFnto6aRLUdjc5ym8/6a65GRrdYnVRTCtOoxFAjZaSucyFe6kFGmkU4j0uoh7ju9o8YbzVavmp0nzb+khIoE0jmCR4sj7MoayCBoowP5Uzv+W1RSHTitt9gh0NohIcOHfqQa6R9l8fyJCgUjUexSXBnEZoiys5nbUbD1Q3j3/qIqTBmpPfVsMUWcVpUby7HIhQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(81166007)(356005)(82740400003)(478600001)(54906003)(47076005)(8936002)(6862004)(40460700003)(52536014)(36860700001)(316002)(86362001)(26005)(83380400001)(33656002)(53546011)(41300700001)(70206006)(70586007)(9686003)(7696005)(6506007)(40480700001)(82310400005)(186003)(5660300002)(2906002)(8676002)(55016003)(336012)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:28:43.3701
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f0d06b2-31a9-4f70-549a-08daadc67cc7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8437

SGkgSmFuLA0KDQpUaGFua3MgZm9yIHRoZSByZXZpZXcuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIIHYyXSB4ZW4vYXJtOiBwMm06IFBvcHVsYXRlIHBhZ2VzIGZvciBHSUN2
MiBtYXBwaW5nIGluDQo+IGFyY2hfZG9tYWluX2NyZWF0ZSgpDQo+IA0KPiBPbiAxNC4xMC4yMDIy
IDEwOjA5LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4u
Yw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiA+IEBAIC03NDAsNiArNzQwLDIw
IEBAIGludCBhcmNoX2RvbWFpbl9jcmVhdGUoc3RydWN0IGRvbWFpbiAqZCwNCj4gPiAgICAgICAg
ICBCVUcoKTsNCj4gPiAgICAgIH0NCj4gPg0KPiA+ICsgICAgLyoNCj4gPiArICAgICAqIEhhcmR3
YXJlIHVzaW5nIEdJQ3YyIG5lZWRzIHRvIGNyZWF0ZSBhIFAyTSBtYXBwaW5nIG9mIDhLQiBHSUN2
Mg0KPiBhcmVhDQo+ID4gKyAgICAgKiB3aGVuIHRoZSBkb21haW4gaXMgY3JlYXRlZC4gQ29uc2lk
ZXJpbmcgdGhlIHdvcnN0IGNhc2UgZm9yIHBhZ2UNCj4gPiArICAgICAqIHRhYmxlcyBhbmQga2Vl
cCBhIGJ1ZmZlciwgcG9wdWxhdGUgMTYgcGFnZXMgdG8gdGhlIFAyTSBwYWdlcyBwb29sDQo+IGhl
cmUuDQo+ID4gKyAgICAgKiBGb3IgR0lDdjMsIHRoZSBhYm92ZS1tZW50aW9uZWQgUDJNIG1hcHBp
bmcgaXMgbm90IG5lY2Vzc2FyeSwgYnV0DQo+IHNpbmNlDQo+ID4gKyAgICAgKiB0aGUgYWxsb2Nh
dGVkIDE2IHBhZ2VzIGhlcmUgd291bGQgbm90IGJlIGxvc3QsIGhlbmNlIHBvcHVsYXRlIHRoZXNl
DQo+ID4gKyAgICAgKiBwYWdlcyB1bmNvbmRpdGlvbmFsbHkuDQo+ID4gKyAgICAgKi8NCj4gPiAr
ICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7DQo+ID4gKyAgICByYyA9IHAybV9z
ZXRfYWxsb2NhdGlvbihkLCAxNiwgTlVMTCk7DQo+ID4gKyAgICBzcGluX3VubG9jaygmZC0+YXJj
aC5wYWdpbmcubG9jayk7DQo+ID4gKyAgICBpZiAoIHJjICE9IDAgKQ0KPiA+ICsgICAgICAgIGdv
dG8gZmFpbDsNCj4gDQo+IFB1dHRpbmcgdGhpcyBsZXZlbCBvZiBrbm93bGVkZ2UgaGVyZSBmZWVs
cyBsaWtlIGEgbGF5ZXJpbmcgdmlvbGF0aW9uIHRvDQo+IG1lLiBNeSBmaXJzdCBzdWdnZXN0aW9u
IHdvdWxkIGJlIHRvIG1vdmUgdGhpcyBjYWxsIHNvbWV3aGVyZSB1bmRlcg0KPiBwMm1faW5pdCgp
Lg0KDQpUaGF0IGlzIGRlZmluaXRlbHkgcG9zc2libGUuIElmIEp1bGllbiBvciBvdGhlciBBcm0g
bWFpbnRhaW5lcnMgYXJlIG5vdA0KYWdhaW5zdCB0aGF0IEkgYW0gaGFwcHkgdG8gbW92ZSB0aGlz
IHRvIHAybV9pbml0KCkgaW4gdjMuDQoNClRoZSByZWFzb24gd2h5IHRoZSBhYm92ZSBibG9jayBp
cyBwbGFjZWQgaGVyZSBpcyBqdXN0IEkgdGhvdWdodCB0byB1c2UNCmQtPmFyY2gudmdpYy52ZXJz
aW9uIHRvIG9ubHkgcG9wdWxhdGUgdGhlIDE2IHBhZ2VzIGZvciBHSUN2MiBpbiB0aGUNCmJlZ2lu
bmluZywgYW5kIGQtPmFyY2gudmdpYy52ZXJzaW9uIGlzIGZpcnN0IGFzc2lnbmVkIGxhdGVyIGFm
dGVyIHAybV9pbml0KCksDQpidXQgbGF0ZXIgd2UgZGVjaWRlZCB0byBwb3B1bGF0ZWQgdGhlIHBh
Z2VzIHVuY29uZGl0aW9uYWxseSBzbyBhY3R1YWxseQ0Kbm93IHdlIGNhbiBtb3ZlIHRoZSBwYXJ0
IHRvIHAybV9pbml0KCkuDQoNCj4gSWYgdGhhdCdzIG5vdCBwb3NzaWJsZSBmb3Igc29tZSByZWFz
b24sIEknZCBsaWtlIHRvIHN1Z2dlc3QNCj4gcGFzc2luZyAxIGhlcmUgYXMgdGhlIGNvdW50IGFu
ZCB0aGVuIGFkZGluZyBhIG1pbi1hY2NlcHRhYmxlIGNoZWNrIHRvDQo+IHAybV9zZXRfYWxsb2Nh
dGlvbigpIGFsb25nIHRoZSBsaW5lcyBvZiB4ODYnZXMgc2hhZG93X3NldF9hbGxvY2F0aW9uKCku
DQo+IFRoYXQgd2F5IHlvdSdkIGFsc28gZ3VhcmFudGVlIHRoZSBtaW5pbXVtIG51bWJlciBvZiBw
YWdlcyBpbiBjYXNlIGENCj4gc3Vic2VxdWVudCB0aW55IGFsbG9jYXRpb24gcmVxdWVzdCBjYW1l
IGluIHZpYSBkb21jdGwuDQo+IA0KPiA+IEBAIC0xNzM2LDYgKzE3MzYsMTcgQEAgdm9pZCBwMm1f
ZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkNCj4gPiAgICAgIGlmICggIXAybS0+ZG9t
YWluICkNCj4gPiAgICAgICAgICByZXR1cm47DQo+ID4NCj4gPiArICAgIGlmICggIXBhZ2VfbGlz
dF9lbXB0eSgmcDJtLT5wYWdlcykgKQ0KPiA+ICsgICAgICAgIHAybV90ZWFyZG93bihkLCBmYWxz
ZSk7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMg
IT0gMCApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2lu
Zy5sb2NrKTsNCj4gPiArICAgICAgICBwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwgTlVMTCk7DQo+
ID4gKyAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5nLmxvY2spOw0KPiA+ICsgICAg
ICAgIEFTU0VSVChkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPT0gMCk7DQo+ID4gKyAg
ICB9DQo+IA0KPiBJcyBpdCBpbnRlbnRpb25hbCB0byBsYXJnZWx5IG9wZW4tY29kZSBwMm1fdGVh
cmRvd25fYWxsb2NhdGlvbigpIGhlcmU/DQoNClllcywgQUZBSUNUIHAybV90ZWFyZG93bl9hbGxv
Y2F0aW9uKCkgaXMgcHJlZW1wdGlibGUgYW5kIHdlIGRvbid0IHdhbnQNCmFueSBwcmVlbXB0aW9u
IGhlcmUuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEphbg0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:31:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:31:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422623.668771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojH2C-0000gR-1L; Fri, 14 Oct 2022 09:31:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422623.668771; Fri, 14 Oct 2022 09:31:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojH2B-0000gK-Ut; Fri, 14 Oct 2022 09:31:15 +0000
Received: by outflank-mailman (input) for mailman id 422623;
 Fri, 14 Oct 2022 09:31:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojH2A-0000gE-N0
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:31:14 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2075.outbound.protection.outlook.com [40.107.21.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f10d63b9-4ba2-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 11:31:12 +0200 (CEST)
Received: from AS9PR06CA0602.eurprd06.prod.outlook.com (2603:10a6:20b:46e::7)
 by GV2PR08MB7932.eurprd08.prod.outlook.com (2603:10a6:150:7f::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Fri, 14 Oct
 2022 09:31:08 +0000
Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46e:cafe::30) by AS9PR06CA0602.outlook.office365.com
 (2603:10a6:20b:46e::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Fri, 14 Oct 2022 09:31:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 09:31:08 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 14 Oct 2022 09:31:08 +0000
Received: from 02957bd9d5fd.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C4CE1846-BCF3-4581-9439-283CDC038883.1; 
 Fri, 14 Oct 2022 09:31:02 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02957bd9d5fd.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 09:31:02 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB6693.eurprd08.prod.outlook.com (2603:10a6:20b:39c::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 09:31:00 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 09:31:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f10d63b9-4ba2-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Sz3YIqKaEeveRotiNahZbRgZvQuWbSuE9/AMz10Edy3WACFu5clYXVaWdJorVykUY8qh5dIPOXeInnKdye9mWVCQQTO2/4WIGplojFxP3WP616DiuUrUBR1UaO20iUORikb4vypm0ewi2MoVrU8zPv+wHrXUC8De/qnHzW2aAyN7yk3w7yglm02Ai1wH7G3hnqAkENwcB42hFiENKy2FKTPO7WHxg5y0mPZCYCNwlCFqHODH5pIbJcRYx88Podckbck0malaYK9HB2pVYqtLMLdKSpkFPfwMbIohaykS2HB6bH143VCBV+LOwOAAj6qMkA7GMjxU2pNhAf0MQ5Prgw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jw+mE+hCGbWjo8enhFRs1cPf2DOpUeCL5aMaK943Lmg=;
 b=FSh+dOtW8qBzmfPKwGuRS2Favd6Fzxt4dDHswETEx4vvEfK+21PlSSsZSCCokW1EPrtq1qHEh/YAIqCnGE1XeFhfTqIAKkaoiWpgFaZ2E6JNidz+TjaXohYknDivfE6Fn/QnBqhW/fR+S5MIwaDJb9vTowqTk+uH+eks+jhHlQusORzzgdtnPF9wfsXfP/1zsoOPHV3NjjtMvQH5o4k/QO8cllhlTT+mpTPV9UouVsToX5/2gdCa4nLNZ6WscOpEveb72AurVH13FyDM29MGlYC0vg1Vs/7WqTF8YHoK0drt5gPd0ZNjKDEV9K4KimiRTL34HBCoH4sc6maBwgWG9w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jw+mE+hCGbWjo8enhFRs1cPf2DOpUeCL5aMaK943Lmg=;
 b=X4o245/wVSSdvFH7eD2mWWd2/ys+mUSenk/fauwWnT+t3IF1CTxaoz1p+KqIofgC5/uJkOyABC4CoqyFEvDPS4sPlu3W/Gkia6L+mEBUKg4STw4K2uL2/JyIKdt0UfkdpWcp6Z6A8YD7+AeaYGp67OSrQs1rG8EowphK0mbOgqc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PMeVErN05XAkl0M5YUWBE589guIfpd2PZQ3mz4e1evlKgFt789TSVCP2zDoe4IkE8OzFdVgWYJseTDkj2pap+eJ0YUnj4QKvi7vEPFZVptb2jIHRhRycy+2IZz6X4334VWrqfI9KmGl+Q7anSxPYX8UQ218u9LGIVfrlQ3JrO8/JQ2EGJmBGqMp+BYhoh1T6GvLdSlqfwEcxwO1y+Hw68xPPoBFwXhUy3EZqG2kXxPFuNUY7dB1tASAlKYAo3uEpB9VCHldGNmPq4PnPFRMajI5JhXpKUqJt1yuCqKBRcchX3RLrUo4xFjP2YNZQT1SZpVBxpSmFsODsI6LGrXAqbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jw+mE+hCGbWjo8enhFRs1cPf2DOpUeCL5aMaK943Lmg=;
 b=gEREg+8BmAnLVch0VS8ZLgRZ3HyYb4HYnSd+jGt7mji00nCZHDkpqPcEYpO+TOi4oR7ykxuWrB2obD4M286h6pGT5GMnfQ7+YSmd1p84S4q2QfYBrfB5nq5woQMz0kaEFYKdh7bPwXLVbkFq1nKn838AnpF9CkuUxqIpxE8DwvA0Xp7fns0/05jMSnMBpm/Axjc+J5WCuPoZRIsELId3/d6PQxml+riYxkW6qk/WjyHDtMeE46jzXcRBWFlYg1ZOtNGisUEHalL43J2bz9AxzZHJ7gmEDFnacMQF+r5qJalsINuOrR3AxVZGN29rOF/DBxrqXBLFNL01DqJ3KsZHgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jw+mE+hCGbWjo8enhFRs1cPf2DOpUeCL5aMaK943Lmg=;
 b=X4o245/wVSSdvFH7eD2mWWd2/ys+mUSenk/fauwWnT+t3IF1CTxaoz1p+KqIofgC5/uJkOyABC4CoqyFEvDPS4sPlu3W/Gkia6L+mEBUKg4STw4K2uL2/JyIKdt0UfkdpWcp6Z6A8YD7+AeaYGp67OSrQs1rG8EowphK0mbOgqc=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Thread-Topic: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Thread-Index: AQHY3q+bU7An58kRd0C18nD7mqtwpK4Nk9IAgAAAuGCAAAmOAIAAAGRg
Date: Fri, 14 Oct 2022 09:31:00 +0000
Message-ID:
 <AS8PR08MB7991508880001B08C602881692249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-2-Henry.Wang@arm.com>
 <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
 <AS8PR08MB799119B54A5FE419CDDB9C1592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <3cfdcd2b-cc18-0585-d837-f5932d9eeb0f@xen.org>
In-Reply-To: <3cfdcd2b-cc18-0585-d837-f5932d9eeb0f@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 7D9C695FC404CE4BA803EE34E357151F.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB6693:EE_|AM7EUR03FT009:EE_|GV2PR08MB7932:EE_
X-MS-Office365-Filtering-Correlation-Id: 9f5ab7b4-5b1f-4da3-2542-08daadc6d30e
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wG+HVa1iYWnw3yXS+LlUHcghHIMo2pXWixNllI4sfKwX94Bnvdhts+ZmopBfe71q21utpVZyWr33l/DEiuexq+2dYlu6CNXErQnAmDlCskWIZo+hyR9fiS97ggA6Wz7C2VEAUKlVGQt2p3PwqNMNDDaawlKivhc81ghDVVrs89PNCNunaaFdEh47BiJcmr61PEN+6Ua3gpDd/THtHtjblekbYD6noCuuWwPP1X62ObOqUgLROOg2L/kiprd048+SYt2/lNM0WuByKGO1at9VL+Fmrt/4pBlsVwst4iRXdWHDCqUyAJz7K6mNqWvwVQGlyKHWtw18vdtQeCVLtWR2pJRIFmovL3I7WP1KHjjvUNl8HTMZZ+sbaRkR8CSA3FVCvojKgGDfK/KS6mqAGa1uDB+Z/MsAesaVIA2bL6WAu5e71gyl/U8XMTG9svTDj0FaYI6Sguy9DbwfOnoaTFtf1OF1EqZEVPLTq8kAXTir2slF0KzpcmDXz1IkXT4ZiTgLBJ3E9Z5rIIJpWuwb1NQZgYEcSWBnYhJY4Ab3ot+UDrgMNeUqNmUXVHXigEJgZ4vNGXDlvDGH0rEvwfVR79+fdYbDJfQJEpPjVRdk5lQrHWI2+EWuaYXbcv+E3Tl/BtFMMoTP/ZKatJ6RcD+dHYuuFwEUiqQDqe1ZrwRfyCL8IPCLcUFcar2nAa7QJdSppAOOKQJ3yXMNMFhRsR3llHgqUpRktNs/2D03XmHSlJzu+Fvhe10GKojfZPA2HlWiFiQ6eSrWaqJ1NsGSYDrhySEoCA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(38070700005)(71200400001)(54906003)(110136005)(122000001)(66899015)(38100700002)(478600001)(8936002)(2906002)(52536014)(316002)(86362001)(33656002)(26005)(66946007)(76116006)(66476007)(83380400001)(66446008)(64756008)(7696005)(9686003)(66556008)(8676002)(5660300002)(186003)(41300700001)(4326008)(55016003)(6506007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6693
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bd4d199b-ed1e-4b73-3b35-08daadc6ce8b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	d+4rrfachkf9s7pbFgSEyanhezZir5a1SQ+/tPDdp0XfYliDP6vXsQT6Zl3OJRkpafKV2kVmcRPwLb9Yw8s0fq/gN46RjwE1f8kKB8N1yW9vGDYvn8frmSlhFpeyOdf1sPbhdzxZNxCxGuGWq65//tlGbKqGJ9OmRfRpBAG7wDc2MimIGx4x2sJUJDHZ6kTvmkeznZoQ+WcowrXR4zywLF015nEl2SY1NTuaAq6MPi6rYztCoA6EnhOSwa7ySO6P4j2dAXMvNCrQas/brCO10UnovYZ8388Ve3s45/JuTsWC7jW3aj7v5xnBpj467iA38Ac6AzcwRVdxpIHgGff52/KffbCjhhumSo5ePEypAgjd0+jwWnpfKbkrD73HilrV3rGdWoOWbQTq/zwXvyP4+ecXqSh1ImUUWR/q4X+CFDsb+/sWPDLacReMHbLRDVQQ8W0VSqCE7UcloQKzKXvv6uywZ6k9pDFFpO0l6Qz9RzXOSwXcTnsJJJRpDQ83x1R9xwme887xuDWAocZp8laTUSEGj1MrsdR2P67fL52XlS7GB6wLCq3sY4hRdZYI64GVYcanVu8CGDEqfhnZEdXKn15UV/2FBKcPY5P5otodXQxu0gahcaMdW7kdTPkanILGbm3XXtswLtGBgSTmlzt0YoyCALpR5oG9Uc1WWHUinjPKAeCqOCbVhJYMyBsSUfDRxFuxwpQf03SMDBm3gcc5baNDdtj5JtLLPfDLIl6ttfiOOh4tlMZKhKxHx4NTdO66UHlR4d20lPDskYHqSnOWbw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(54906003)(66899015)(107886003)(7696005)(110136005)(316002)(8676002)(70206006)(478600001)(70586007)(4326008)(5660300002)(26005)(81166007)(47076005)(9686003)(8936002)(336012)(6506007)(2906002)(356005)(186003)(36860700001)(83380400001)(82740400003)(55016003)(40480700001)(82310400005)(33656002)(40460700003)(41300700001)(52536014)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:31:08.1771
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f5ab7b4-5b1f-4da3-2542-08daadc6d30e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB7932

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+PiArVXNlcnMgc2hvdWxkIGJlIG1pbmRmdWwg
dGhhdCB0aGUgc3RhdGljIGhlYXAgc2hvdWxkIGF0IGxlYXN0IHNhdGlzZnkgdGhlDQo+ID4+PiAr
YWxsb2NhdGlvbiBvZiB0aGUgUDJNIG1hcHMgZm9yIGFsbCBndWVzdHMuIEN1cnJlbnRseSwgdGhl
IG1pbmltYWwNCj4gPj4gcmVxdWlyZW1lbnQNCj4gPj4+ICtvZiBwZXItZG9tYWluIFAyTSBwYWdl
cyBwb29sIGlzIGluLXN5bmMgd2l0aCBmdW5jdGlvbg0KPiA+Pj4gK2xpYnhsX19nZXRfcmVxdWly
ZWRfcGFnaW5nX21lbW9yeSgpIChmb3IgeGwtY3JlYXRlZCBkb21VcykgYW5kDQo+ID4+PiArZG9t
YWluX3AybV9wYWdlcygpIChmb3IgZG9tMGxlc3MgZG9tVXMpLCB0aGF0IGlzLCAxTUIgcGVyIHZD
UFUsDQo+IHBsdXMNCj4gPj4gNEtpQiBwZXINCj4gPj4+ICtNaUIgb2YgUkFNIGZvciB0aGUgUDJN
IG1hcCwgYW5kIHBsdXMgNTEyS2lCIHRvIGNvdmVyIGV4dGVuZGVkDQo+IHJlZ2lvbnMuDQo+ID4+
DQo+ID4+IEkgdGhpbmsgdGhpcyB3b3JkaW5nIGlzIE9LIGlmIHRoZSBmZWF0dXJlIGlzIGEgdGVj
aCBwcmV2aWV3LiBIb3dldmVyLCBpZg0KPiA+PiB0aGlzIGlzIHNlY3VyaXR5IHN1cHBvcnRlZCwg
d2UgbmVlZCB0byBwcm92aWRlIHNvbWUgbW9yZSBkZXRhaWxzIGFib3V0DQo+ID4+IHRoZSBzaXpl
Lg0KPiA+Pg0KPiA+PiBJbiBwYXJ0aWN1bGFyLCB0aGlzIGRvZXNuJ3QgdGVsbCBhIHVzZXIgaG93
IHRoZXkgY2FuIGZpbmQgdGhlIHNpemUgdGhhdA0KPiA+PiB3b3VsZCBmaXQgdGhlbS4gQ2FuIHRo
aXMgYmUgZGVjaWRlZCB3aXRoIGEgZm9ybXVsYT8NCj4gPiBNeSBmZWVsaW5nIG9mIHRoZSBmb3Jt
dWxhIHdvdWxkIGJlOg0KPiA+DQo+ID4gVG90YWwgaGVhcCBzaXplIG5lZWRlZCBwZXIgZ3Vlc3Qg
PSAgMU1CICogbnVtX2d1ZXN0X3ZjcHUgKw0KPiA+ICAgICAgNEtCICogZ3Vlc3RfcmFtX3NpemVf
aW5fbWIgKyA1MTJLQiArDQo+ID4gICAgICB0aGUgbWVtb3J5IGFsbG9jYXRlZCBmcm9tIGhlYXAg
YnkgeHphbGxvYy94emFsbG9jX2FycmF5IGZvcg0KPiAJdmFyaW91cyB1c2VzDQo+ID4gICAgICBm
b3IgZXhhbXBsZSBhbGxvY19kb21haW5fc3RydWN0KCksIGQtPnNoYXJlZF9pbmZvLCBldnRjaG5f
YnVja2V0LCBldGMuDQo+IA0KPiBUaGVyZSBhcmUgYWxzbyBzb21lIHBhZ2VzIGFsbG9jYXRlZCB1
c2luZyBhbGxvY197eGVuLGRvbX1oZWFwX3BhZ2VzKCkuDQo+IFdlIGFsc28gbmVlZCB0byB0YWtl
IGludG8gYWNjb3VudCBydW50aW1lIGFsbG9jYXRpb24gZG9uZSBieSBzb21lDQo+IGh5cGVyY2Fs
bHMgKEkgY2FuJ3QgcmVtZW1iZXIgd2hpY2ggb25lKSBvciBzdWJzeXN0ZW0gbGlrZSBPUFRlZS4N
Cj4gDQo+IEluIGFkZGl0aW9uIHRvIHRoYXQsIHlvdSBhbHNvIGhhdmUgbWVtb3J5IGZvciB0aGUg
c3lzdGVtLiBFLmcNCj4gZnJhbWV0YWJsZXMsIFhlbiBwYWdlLXRhYmxlcywgdmFyaW91cyBkcml2
ZXIgYWxsb2NhdGlvbnMuLi4NCj4gDQo+ID4NCj4gPiBJcyB0aGlzIGZvcm11bGEgc29tZWhvdyBt
YWtlIHNlbnNlIHRvIHlvdT8gSSB0aGluayB3ZSBuZWVkIHRvIGhhdmUgYQ0KPiA+IHJvdWdoIGVz
dGltYXRpb24gb2YgdGhlIGxhc3QgcGFydCAoYm9vdCB0aW1lIGFsbG9jYXRpb24pIHRob3VnaC4N
Cj4gDQo+IFRoYXQncyBnb2luZyB0byBiZSBoYXJkLiBJdCB3aWxsIHZhcnkgZGVwZW5kaW5nIG9u
IHlvdXIgc3lzdGVtIGFuZCB0aGlzDQo+IGNvdWxkIGNoYW5nZSBpbiB0aGUgZnV0dXJlIGFzIHdl
IGFkZCBtb3JlIGZlYXR1cmVzLiBGb3IgaW5zdGFuY2UsIEkNCj4gZXhwZWN0IHRoZSBQQ0kgcGFz
c3Rocm91Z2ggd2lsbCBuZWVkIHNvbWUgbWVtb3J5IHRvIGtlZXAgdHJhY2sgb2YgYWxsDQo+IHRo
ZSBkZXZpY2VzLg0KPiANCj4gSSBhbSB3b3JyeSB0aGUgZm9ybXVsYSB3aWxsIGJlY29tZSBjb21w
bGV4LiBJZGVhbGx5IHdlIG5lZWQgdG8gaGF2ZSBhDQo+IHZlcnkgc2ltcGxlIGZvcm11bGEuIElm
IHRoYXQncyBub3QgcG9zc2libGUsIHRoZW4gd2UgbmVlZCB0byBwcm92aWRlIGENCj4gd2F5IGZv
ciB0aGUgdXNlciB0byBlc3RpbWF0ZSBpdCBhdCBydW50aW1lIChsaWtlIHdoYXQgSSBzdWdnZXN0
ZWQgYmVmb3JlKS4NCg0KSSBhZ3JlZSwgSSB0aGluayB0aGUgc2ltcGxlIGZvcm11bGEgY2FuIG9u
bHkgYmUgYWNoaWV2ZWQgaXMgd2UgaGF2ZSBhbg0KZXN0aW1hdGlvbiBvZiB0aGUgd29yc3QgY2Fz
ZSBzY2VuYXJpbyBvZiB0aG9zZSBzY2F0dGVyZWQgbWVtb3J5IHVzYWdlcy4NCkkgcmVtZW1iZXIg
SSBvbmNlIGhhZCBhIHRyeSBzbyBsZXQgbWUgdHJ5IHRvIGZpbmQgdGhlIHJlc3VsdHMgYmFjayB0
aGF0IHRpbWUuLi4NCg0KSSBhbSBhbHNvIHZlcnkgaW50ZXJlc3RlZCBpbiB0aGUgbWV0aG9kIHRo
YXQgeW91IHByb3Bvc2VkIHRvIHByb3ZpZGUgYQ0KbWVjaGFuaXNtIGZvciB1c2VycyB0byBnZXQg
dGhlIHN5c3RlbSBtZW1vcnkgYWxsb2NhdGlvbiBhdCBydW50aW1lLiBCdXQNCklJVUMgdGhpcyBu
ZWVkcyBzb21lIHdvcmsgaW4gYW5vdGhlciBzZXJpZXMuIENvdWxkIHlvdSBwbGVhc2UgY29uZmly
bSBpZiBJDQphbSB1bmRlcnN0YW5kaW5nIGNvcnJlY3RseT8gT3IgcHJvYmFibHkgWGVuIGhhcyBz
b21lIG1lY2hhbmlzbXMgdGhhdA0KSSBhbSBsaWtlbHkgdW5hd2FyZT8gVGhhbmtzIQ0KDQpLaW5k
IHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3Jh
bGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:40:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:40:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422629.668782 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHAu-0002FA-Uk; Fri, 14 Oct 2022 09:40:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422629.668782; Fri, 14 Oct 2022 09:40:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHAu-0002F3-R2; Fri, 14 Oct 2022 09:40:16 +0000
Received: by outflank-mailman (input) for mailman id 422629;
 Fri, 14 Oct 2022 09:40:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nnxB=2P=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ojHAt-0002Ex-Hc
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:40:15 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 346a7221-4ba4-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 11:40:14 +0200 (CEST)
Received: from DB6P18901CA0018.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::28)
 by AM0PR08MB5427.eurprd08.prod.outlook.com (2603:10a6:208:183::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 09:40:12 +0000
Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:16:cafe::66) by DB6P18901CA0018.outlook.office365.com
 (2603:10a6:4:16::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21 via Frontend
 Transport; Fri, 14 Oct 2022 09:40:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 09:40:11 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Fri, 14 Oct 2022 09:40:12 +0000
Received: from c2227076e082.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 88BFE35B-FE27-42D0-9E68-4C24590FF5CA.1; 
 Fri, 14 Oct 2022 09:40:00 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2227076e082.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 09:40:00 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAXPR08MB7317.eurprd08.prod.outlook.com (2603:10a6:102:230::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 09:39:58 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 09:39:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 346a7221-4ba4-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=BZDnt/SDAXaFpMAo0YPmyd4U+hc8H+AoDOr04uoZa8S+3+Rj6n7fJIkf8CBL10I2okNGGBvLNS8vS4xreQuz6JqNLK544r20p8Cv5RyJ1SMMfwDfWIbn81XZ6MHZ3tR/kHzq0FQVhcGAWU5Lt1zuuFjS/jidXqIGcZvVY3dF9QyQTBjQW7gfknm1vKmTdlq+6aPfybjD1ueNWu6KCd4mI1zRx8nrzz7jI1VHAEtqwVB2jYkIiHBv6E0BhRi7FGTMJYAj65gvfL1SEGS2No4JmLXGos1tBpeJy0bYrJg4mkhYYMv5kA830uSK1UUovPA6EwaTyBfOVgOI/4plI/YOfA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KQ9chkcFUsaOmkM+wxDS+JJ/mHrbcr14BRFM6DtU0vs=;
 b=NpCN/WwGTXIzJ5QI0Cjff9exnHs87s/e74LSF0viGT75dGpQ2ZMqgivyQq8ICk2ibupm0eaUfiVZT2R/tRKd4D6FeLn20B1lQHq8qb8Bo7df0C85KF5oRrUx8KZpq56eyMvHn5XM0eFSxDz1Rulkj1gJvvXiX49WJbJ/ly+AJ4bQC0sjnrSxJLGVsReXRfwXxpJahARNa/cgIf4zh04i7AG3p7O3YYxbpi/AaT4N+kXbOKUnkldknTl3oaRZuny5bbpYIEK/9cEsI+dMYWatrz/vAcFqhGwC1gvPQeVFlMQufnWMm6hNC7VNcMYUQAG9WhGt1QvWdG9lr0hTklfTvg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KQ9chkcFUsaOmkM+wxDS+JJ/mHrbcr14BRFM6DtU0vs=;
 b=PsDFiYgtPItOLrvdMw/cAwPFmKp6/zTEOAACVDBF4KtuwnCucEn0RZgxIFuB2ZeAkfMQBpSgDAGQeUpCp6q4+LoOgk4pjRC/loxc5ttS3lG5w7iJ3ip8a11Tb8rN0GhOkpX1dL9NbFzNhvIkWMs82MOucFEVlIWwCb+cDQzkUnQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: ba42a7961afbda02
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nazn238hr+Jt+PtNi34GFC6rwyO3E4eP0HXq7H8hA7juXrSJedMKa+LGirAXh5nrH0piJ8ScAaUTa041uv30XzYriLfN0m3eZn4gfQoBGGI3HaLa0tESANeCa/OhawzHQV9B+PE3Wb8f9h24924Sse4Lsu3eJ/MJr8GxpXf2ZfFA9cwQ+uw6njcUGw/r1nppC0fgkmsvR75PX/G27zHT3EAHmXdITdjL8eFpPBLbxcNhTeq6W+pzlQ9aYPA6lG9MnshfhyyoYwfeNeWACXr9YaBYszU2XWDVV4j+gJowD1ly1WmuVmhdmPNPIc5Fo0rOLLpir0dW4lrFTN1EGZgrHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KQ9chkcFUsaOmkM+wxDS+JJ/mHrbcr14BRFM6DtU0vs=;
 b=YJV0G9AoicI8D3cy58Q4qasJPRFoQyWYYtY4EYE3gATzxclPcYPbwAxihilR378iWcJot0eJB9UPMWpgh3UfOJ7LxpleEcPhrrfMkcFdZ/HKTSIayjkW1DMDaw9LCnnQ8y3tyY0wpMGssaqjrp3dlt0fyb4Gq2fLzaUXoHU482GMtgBTwI4gGfji+m841mCdI1YVz9wI20LKrGAZ3uzLG3ez847CBPTCWqW+xy8KaeCiuOCF+k/9migsAhBW/Jdk5Q2JJdiWf5SKZlqj6V8TC0aC2nBQhw1+OmaM4BgsW0lBYifndMNwcsYGbFpWaIGN+5SwLCltZvn0N4GKIfwCww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KQ9chkcFUsaOmkM+wxDS+JJ/mHrbcr14BRFM6DtU0vs=;
 b=PsDFiYgtPItOLrvdMw/cAwPFmKp6/zTEOAACVDBF4KtuwnCucEn0RZgxIFuB2ZeAkfMQBpSgDAGQeUpCp6q4+LoOgk4pjRC/loxc5ttS3lG5w7iJ3ip8a11Tb8rN0GhOkpX1dL9NbFzNhvIkWMs82MOucFEVlIWwCb+cDQzkUnQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Henry Wang
	<Henry.Wang@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>, Wei Chen <Wei.Chen@arm.com>
Subject: Re: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as
 supported
Thread-Topic: [PATCH for-4.17 2/2] SUPPORT.md: Mark static heap feature as
 supported
Thread-Index: AQHY3q+gq+iAwC+K3kK6Akvdo+Mt6q4NAU4AgACRG4CAABIQAA==
Date: Fri, 14 Oct 2022 09:39:58 +0000
Message-ID: <FE2B710E-E3D7-41E0-8BB7-31F59AB16D2C@arm.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-3-Henry.Wang@arm.com>
 <alpine.DEB.2.22.394.2210131655530.3690179@ubuntu-linux-20-04-desktop>
 <a4a8fa5b-afff-0a49-7c06-b9be82669aac@xen.org>
In-Reply-To: <a4a8fa5b-afff-0a49-7c06-b9be82669aac@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAXPR08MB7317:EE_|DBAEUR03FT036:EE_|AM0PR08MB5427:EE_
X-MS-Office365-Filtering-Correlation-Id: 50dacc02-9026-4ff1-03d4-08daadc8170c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 QuzgxiL79P3vlnsj/2aNg/huaXSWP5Lp154PJ5rPdmr1oIa4yUSFrhMYsvELK4pyEduI5FuNWMo3swIz69diuqcmL2Dg4W3/FaW1oB5Gfyau9eHePQa39X9I/xcpU/CVqvcoY5gsf5uhWuIE0EqyKpSycNUxLATnuua5h8DjVHDBCe2GAdOafbKjPuhidkTRm6vv2afw+nMQtbsE9Fp9TpyeyKNbMFYFrjRb9oWFWE4h55yCxbDpm6c3V1HZ1hw2XXa4rZkCHFVhTi2Y0ecAwgKWixW0EHXmmFIZ9Zdb/wi8KKeT+d8HpJL4WyUg3PkjgSjxB9P7mkzsSA8LzEqlUf5YOXFoVHMavucWlZbso4rjvG45pFwqX8HUa6ni6eKIcMARipJ6g3ZUcW12+vykrYlGqZDmHS776JkmF86t88Hg265VhcCyVrnDmDt9nue1Q4baV6Nmdjf3kFhl3ucEMEIYfsJlcJ86/rwYb7sGhU6pI8FtQjmebUACLUsx7r2Vml74cOME02h20I2PlqNGp4c0zh+B/QuCZPUE+k7LJZb7xTK7JNtya83317eLzH731UkmzMgqasSxezt52/94QIX7n0dz+ASrYW1BMSQDDHzSoU2Lumu+tz1CpLd1RC8V0aLkv7tuwJxBkmT3WVMgBUWPGHV4aIiy4G4tYvkcSbKNhI+eFY439BKFNrZ+M3pOvUMUMtPk65gCp96rD5SZNuzNf2xGqN7p/dKDDnDSchJ75m1YXvEnIxkaBdXPdWKJlXkYz7x7xvW6mq/tgxCkt9R8MRW0lmIpno/oo5dQjlY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(366004)(451199015)(4326008)(64756008)(66446008)(66946007)(66476007)(66556008)(38100700002)(8676002)(91956017)(122000001)(76116006)(83380400001)(5660300002)(33656002)(186003)(2616005)(2906002)(36756003)(6506007)(53546011)(6512007)(26005)(8936002)(41300700001)(478600001)(6486002)(86362001)(71200400001)(38070700005)(6916009)(316002)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <758CE40540686449B0E1E961819032E5@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7317
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	407a3699-800a-4d02-66cf-08daadc80f36
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OiYWwi1nueNqDZKyyRH2Kh+ru5n9mZyua7JqrqFDD7ASgSm0S1dYiiK9u//3wnaUscFMHOIxJSZDY2T27li6M6x4If3iCmZEKYGt5tE0mNG2WN8nZHN+XJv8QdZ+B5ovZZ3Ifwq8QTXaftfUxGLuEeV4Swy3BbRPMka7OtQ+HoKb58q7o1czb0ePo/igNOoYK82eDmYSlk3cNxuUDqQJm5arANM75A0gYsdCoHg3onwaL+8WQ5e6P2RvRO7DjFZi15x7bbGwCr1u+4jwDPYryRaueCspbIsGbfXIcuIqd/W9RPSL5ORNEiJKxbWh00LzdpNFa5b6FgAHwyUT0iYkb9EaF6fo5JIv4Q+7zTX/7KuPUzZUzKLgtMO4u8ll8SZUMiz0hq/2QErOj9j4kNLkNiHYqu69SOckhVsAjTlVNhMZWWIYqNMwQzr2aeL+PtJDcWFDmL9eLrEMAAL/XzRZ9X3wA+MZyvlDnS0iOCVM6MoxWaujj9gfIG+c6InY52USwbGnhgUJIdpjJnAZrvdXiJ609Fbm76BNpkNdDKtACdB7ra4aGsrizr6MhlDke3lXmnYXqDQwEN1FMJEhsR1NlX0HlkdepGvX4CISSSx/rYQW2GMWhtg+V8BuK4JcGfxR/4Bl5ZNqbUyeivPFxTtx52O0Dtorahxa9W3Fi2ftP1qFoW128QXca+F0ezHyL6OD/aIkViYedtu8uYCIpdp1OyPfZt1sS7u145N675+93MyeM24MKTXM8u1og+cNAPrdJqEVodR0UpXa8xQHWOqRig==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(186003)(2906002)(2616005)(86362001)(40480700001)(40460700003)(33656002)(8676002)(4326008)(36756003)(6506007)(26005)(41300700001)(53546011)(82310400005)(81166007)(356005)(47076005)(82740400003)(36860700001)(316002)(70586007)(8936002)(6862004)(54906003)(6512007)(70206006)(5660300002)(336012)(478600001)(6486002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:40:11.7918
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 50dacc02-9026-4ff1-03d4-08daadc8170c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5427

Hi,

> On 14 Oct 2022, at 09:35, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Stefano,
>=20
> On 14/10/2022 00:55, Stefano Stabellini wrote:
>> On Thu, 13 Oct 2022, Henry Wang wrote:
>>> With the P2M pages pool bounding the domain memory runtime allocation
>>> and the documented minimal size requirement of the static heap, it is
>>> safe to mark static heap feature as supported.
>> Usually we wait at least one release cycle before marking a feature as
>> supported. However, I can see that this case is a bit different because
>> effectively static heap memory is a safety/security feature.
>=20
> Even with patch #1 merged, we are still missing some information on how t=
o size the heap. But see below...
>=20
>> Julien, Bertrand, I'll let you know decide on this one
>=20
> It doesn't seem to make sense to security support the static heap when al=
locating statically memory for domains are still in tech preview.
>=20
> That's because if you want to have your system security supported, then y=
ou will need all the allocations to come from the heap. At which point, res=
tricting the heap seems pointless.
>=20
> So I think it would be better to wait until the static memory is fully su=
pported.
>=20

I think this should stay a tech preview in 4.17.

Cheers
Bertrand

> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:46:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:46:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422636.668793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHGz-00031d-NH; Fri, 14 Oct 2022 09:46:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422636.668793; Fri, 14 Oct 2022 09:46:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHGz-00031W-KI; Fri, 14 Oct 2022 09:46:33 +0000
Received: by outflank-mailman (input) for mailman id 422636;
 Fri, 14 Oct 2022 09:46:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d1R5=2P=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ojHGx-00031Q-RM
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:46:32 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1467aa27-4ba5-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 11:46:30 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id d26so9294472ejc.8
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 02:46:30 -0700 (PDT)
Received: from [192.168.1.93] (adsl-33.176.58.192.tellas.gr. [176.58.192.33])
 by smtp.gmail.com with ESMTPSA id
 k13-20020a17090627cd00b0077826b92d99sm1287627ejc.12.2022.10.14.02.46.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 14 Oct 2022 02:46:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1467aa27-4ba5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=Y/QgieFe04Q2SJKx9LehzMnVWzkhikXB3a9E3m0cIns=;
        b=K1HIsHX2VT1jItBGMSIsj6MT1z56SADs0lNYo+hnTLpkQbdBGVGw5vXDrk/vBmpKZY
         5AdEzMvMzd3xKjvubpbAvNIqgZ9Fl64+Q8AQ2fy1i+vynq8xf1CqOsD2/2W13KUgkpAs
         uzJqO+LoEC6Obxu638S3wyTu0xDcz2I8dKk+8+xQ8iVD2Bun4wx8pUipqeQccz9sMMjp
         wrE4CsqWrSQjUXaPAf96/ldFM7AoT4Ye0iQd2nDf29FVGi5sX8gSY91MA2bYPWm+Zbk5
         pCUAPb3FMUV4ZghqIQfOrG+6631KprF5xxapf3ehJMEs85/3cSNSUXAwckSAbBcDYkfh
         VGHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Y/QgieFe04Q2SJKx9LehzMnVWzkhikXB3a9E3m0cIns=;
        b=gXuzBe4BtZVuMsFTW6FTSBhEs+tzuXYkrkSI5C2w/KmsSe+k02KbEi5Ssq4z89QHc0
         ivYx/mKZkZlte2vE2gOh2Ua+15Ov2PeK79Mm48lKABzWi563nGowHV50iBh09Gop32Wo
         N43X0clR+7M5AOhKuzgt33IYtyjr8H9O6/nRieIuHPAgomJvIveM44F/oED+11bWK0cz
         FvxLO3AvEcW+9+aP0ssGjyw2T7otc2tWCJInFDxh7Tq04tdwOd2XeJ6uTF+xyIikR4f7
         kKgbhPO61BpIVeBqLAUsnFmV4h9O/e7e0IbnbGCPLonWSdmK04HRde+jBTkD0LZPOgfk
         U1VA==
X-Gm-Message-State: ACrzQf2eeTj+YQBbYhR8cgLWQUxxQ8/FfF35ajKbbjH2rVgSHjGI2kh+
	Gus2isMUFfEKtLqzNJTr3vc=
X-Google-Smtp-Source: AMsMyM7Qe2slz11VfgUKivecRlyC7KjU1tt4NB0PoyTrtT078o3/loMsTrnp5qOX4eP7vPo0YLYd8Q==
X-Received: by 2002:a17:906:c152:b0:78d:9dbb:150b with SMTP id dp18-20020a170906c15200b0078d9dbb150bmr2838450ejc.542.1665740789890;
        Fri, 14 Oct 2022 02:46:29 -0700 (PDT)
Message-ID: <db3a487d-8330-fc68-8659-b6974352e7bc@gmail.com>
Date: Fri, 14 Oct 2022 12:46:27 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/13/22 15:39, Julien Grall wrote:
> Hi,
> 
> On 13/10/2022 13:29, Henry Wang wrote:
>>> -----Original Message-----
>>> From: Jan Beulich <jbeulich@suse.com>
>>>>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N - 
>>>>> 1))?
>>>>> Or is the root table not taken from the p2m pool?
>>>>
>>>> Correct, on arm the root is not taken from the pool.
>>>
>>> Isn't that a (perhaps just minor) mistake?
>>
>> Not really, in the code review phase, the question of whether we include
>> the root in the p2m pool was discussed and the conclusion at that time
>> was not including this page for now, as this is supposed to require a lot
>> of extra work/refactor. Probably there will be a series from my side to
>> add the root to the pool, but at least not now.
> 
> The root page tables can be one of multiple concatenated pages (up to 8 
> pages). The P2M pool is allocating page by page and therefore wouldn't 
> allow us to allocate contiguous pages.

Sorry that I 'm asking this so late (I was just going through the 
thread) but why 8?

> 
> Therefore, we need to handle the root differently. At which point it 
> doesn't seem to be worth it to allocate it from the P2M pool.
> 
> Cheers,
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 09:57:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 09:57:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422642.668804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHRK-0004cH-MA; Fri, 14 Oct 2022 09:57:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422642.668804; Fri, 14 Oct 2022 09:57:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHRK-0004cA-JF; Fri, 14 Oct 2022 09:57:14 +0000
Received: by outflank-mailman (input) for mailman id 422642;
 Fri, 14 Oct 2022 09:57:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojHRI-0004c4-Oe
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 09:57:12 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140043.outbound.protection.outlook.com [40.107.14.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 924f9dff-4ba6-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 11:57:11 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9646.eurprd04.prod.outlook.com (2603:10a6:10:30a::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 09:57:08 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 09:57:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 924f9dff-4ba6-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jGlYY9MpyJ+gor9nnYYsDU4JisuEY5r0b51D18fUSa525OCkCN4brY0S8n/EfKE4mEhwtjLBkqnVGbuV2YtG1mj/Qgqntrfkdbf31unaURYLNYQOHkLO2juwVdBIneXSAnv/kv67o+09ucKmtylREMwFmRRaIYhGi01VQHdSUpC7Ux+bBhfV1FWns44jV7cIQDU0BYpqwPzm6FXYYUuArEAHf3zM2bhQlh0PgesffstN8EAsepkRYX9iLe8VJ0EmeAweUdh77s84+Rh7V3sWMm1yJvacaImR9NwuVMscE1pDr0R/XWP+QU2vbPxstAyoCxFhpHj7PJwW9d8ONQywJg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=flqInWQZxGRF0ioNLqiyj9BRYh9uxf1z2FRcSHpWxow=;
 b=jBDHHuFe7E86GYUAGBfPs8yyN21qE4vsMNo4VhBGcChqQg/tp0H0iu4sIE1gGWtqjvDz2cz96ANYk3KJ2Zo+McQQWuiokleyCNsyScOxI1ax9ABPMhQgDa1lfiZOMtrftunhS0Yi6ghL33+cmmLCRUUrIG5vM6ODquMNZRBGsNaXvqbU/nLkpooA/+kvB9zGQFitt1ssI1K5mQ9Kx6VKFsN9apgrz3G4etVDCcgLPXJffS0qV+g0mgQyYPo1TAJSoSDiYOB/NCloUp+gcS26UDmpX6dpuOmig0R74suljlp49BdjTLPDilFcpdmsR97YFD9nfyFwCD4ftNv+gmPt8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=flqInWQZxGRF0ioNLqiyj9BRYh9uxf1z2FRcSHpWxow=;
 b=vrXGkPpgqKYVVQL4f1QNn9p0nBq1hlS7fM3ea1uAFJrLcloed2+AOcZGQ8ViDZZEkQKLSMssokh0IZsHNLXyZYxX+ZgF+YqDMpl2WsHxYVud0R4tK3tUcQ+H50eKzN90uc2SQWQep/FfSaKxhZpPboFoIo/gHSZwm15aZRehpxji56OO2Pdj99UDLRDMcjlQf3pDQ9anEtuNDjQBnsdH+/c8h2brexbmF7JsvjVqIGR85nZYy6go0xUZNqFyL8jvs6Dfl0cxrz3MDhgP1FMZQhrdZgX4VMUWFLibzbQcWuJGQ0qKvj6TozoN8B0z+BYyQEI/S1OrP9tDb6XEGqmE5Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <48741b73-8755-5a10-e1c4-d684aec2135b@suse.com>
Date: Fri, 14 Oct 2022 11:57:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0176.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9646:EE_
X-MS-Office365-Filtering-Correlation-Id: bf5b004d-f878-411d-80ad-08daadca731f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FBv6dItVC89lTKvihAP3D680QwOKScnAngII56wb7FA3P8grVXMIKxwwPIuJ9qVta/Y1kUvUr3sg79aEtwMr4syZ3q0q5moCVqrfJ+hc+wquf5aJ+Q/06szhbderzZLM0vJGHOgBFNteqMHg99MfL51xW0SRQCpzyzfmy7xnv/QoRzH5M6ghjdKnPMfepZAsrfgCTQo4/Iev6zoUcw/SxQOZwjDLtm1kxar1AAhe0rQVM//m+Ui+KbiQsrbT9MgTFbSVSz5bwsA+lt6Qx3wiUOWHHgBKoBX6PuajbPpY6PqKT8ouIPf9924jr5XffFoFOZLnQoHtzh4MXM59eYdaGxyLfwTbgmI72DXrQK6fX8TVucCcZN834XK4FH4X/C+OipJxI0fqh7rxOlSRBNKWv0G2xoHWccIU8oN8k5i0u9mMGmOQGBTMnx+3DBUdSlv554B5jvQVyi4bUJrVWJl9Avdvjb36h/6iRAsm22AdfT3WVdemMB+Q0CnJzx0n0lEViu13VDEzFhJ6TxqoqSQw1q6BGTDr+0M/+in90rhXs5WEWBUtcsOsfY6O98QZSOxZPT9LV3w95zwj1E53KmzebnsArTZ+tmAicbrzfYbjA3Gq+U3fymky/LKdzPETEl53w8KDdkEKP9hmDvu3niwi6YxLFqW3a2hTtn0+EwsxFz4B20nW+jdwRKRqcfc3+XdsIFPjh6KbE9HR9ofiExoOCxVVPuF3FM6NOHQFwhxP/yvs/G0FNPOx/gl2JFmOUqGdg1/ndPmeHp4KWczIhf0NyLJRsaGgFfOQ/PUpGo4ZiI4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199015)(2616005)(36756003)(6512007)(26005)(41300700001)(86362001)(316002)(66556008)(66476007)(6916009)(54906003)(8676002)(8936002)(31696002)(186003)(4326008)(66946007)(38100700002)(53546011)(6506007)(478600001)(2906002)(6486002)(5660300002)(66899015)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?azUvTVRaa3FDbGNaWlZSTnU3NnVwVm5Kd0lEWGVITm9ycVBFVjA3b3NWN1Ex?=
 =?utf-8?B?VlZYemlGWmJrTTQrOUNYeEY5N0pYSWJLTldMaCtEZEVmS2tuekt2eC84MnA5?=
 =?utf-8?B?cnI2Q09FdU5qQkdxYk1uNmxJSkphNUFwQzMwejhSVVlqaDJtSXlqS3NXSkZZ?=
 =?utf-8?B?TXBqUGRvOWhRSWtJMXcrajU2L3hKWlFjbHlRTitlaGZMQ0V4dSt5cng2Ui9x?=
 =?utf-8?B?SGw5R3BaNUluWFdEZi91MlB5cml5ZUhVUE5TemlPb2ExMzBESXJKVTV2Wkcz?=
 =?utf-8?B?SkRhbVBNRldCRXNFRXZJNVd5Rk9jMk9UREpwODUvZUVFVDBQTVN5RXUzWUE4?=
 =?utf-8?B?UTc4d1ZUVWp3ekpOekVJaStlZkJyZElCTzRzN1lNVUZMSEZxWUNCZXROa0pn?=
 =?utf-8?B?TlNZcFNLQVRyUDdLMmdHRThMemNFNXI2TjJzZGY2QnZnU1BvcEk5RGRHSGhV?=
 =?utf-8?B?Z0pXNS9ONUZtb1UrU0FGc1dsa3hEdGxVMHJJbFlXb0EyZUwwdlh4c1JHenpq?=
 =?utf-8?B?NWo0UkdBK2NmNUd6bWxxZXdYcU8xOENKS05XbGJWZisrSEdDRGk5NkQrZUg0?=
 =?utf-8?B?Vm9NQUhlR2FNaTVZYlp5ZnFpQ2hWWXpuR0FVSkI0NTMyQVJ3V2xjaEJ4Sk1l?=
 =?utf-8?B?b1NiYWxONWxGNVFsejdBeWFaTWQ2TVFiVk1ndldpMUVlRnQvMjZwUGx6bmpQ?=
 =?utf-8?B?dG1SV3ozcE9uVlNYRXAxcFVjZ0VEYUIrMStTMnhiZUk4ZndON2lYUnpoQ1Aw?=
 =?utf-8?B?NVFOQjRjR2U2ZWZpSXlnNEZzNmZDTHVQa1ROTHA2TGRPK2pyUkxwQUVvdW1r?=
 =?utf-8?B?a1RMVFFVYkhLTkowa0t6UU1VLy9jWHF2YmJDMHhQVUNHR0o4bGdQU3FHOTRX?=
 =?utf-8?B?dDh0RHdTTmFYV3BVdi92YzZoM0N3THpEYmFicUJRQXB3SWpncmlNUUpjMjNS?=
 =?utf-8?B?RFV6ZEtDUzlYa1pyNHZidmF6NWNoTklCMkRMclF5NXluKzg2U1hVMGt2YWox?=
 =?utf-8?B?Qm5uQ2c0Y1lsbkVMSWFuWFFjNGFDaDNzYXNmU01mVFV5TkxpbURwaHZEeGNW?=
 =?utf-8?B?b1dNR2hXbGxyMzIwNnZmYkR5cWF1ZjYzOWIwZ1ZhM1FFQlBST1E3SUlmVnYx?=
 =?utf-8?B?clFqaStUbjRkS2UzUEJCT0JkeEczenNSKzRYOVorTkRJR3pwNjNtQmFjZTdD?=
 =?utf-8?B?aWRMRzV3SWtQeHdlZlRKamk4SlZxNktXZXRQL3d1dFA4alVrS1FmNHJsazdm?=
 =?utf-8?B?STBFWVgxNm9GaWVZVVRFTjIyM0NIY3U5Tkkwa1YzcVJwRjJGK3NOKzlGcXdy?=
 =?utf-8?B?d081UUcrNHlKVnplQ1hzakkvd3A3dXIrSVdhZHh1SnptSExhbWMxcC8zUzNl?=
 =?utf-8?B?UHB1a1gvKzZQY1A5MWl0L1VSMDkxZnJtUWxrN0FWZ3BIcWRSdG8zWTdqOVF5?=
 =?utf-8?B?MSt3bUxaY1NXU0gzN1hEWnRqU0VuR1lKa3hlZjZnSDJ4MHIzeDdPai9YRitQ?=
 =?utf-8?B?MWZ2SEpVQ1JibEVpczEvT1hNV2tKQ2UvaFNOZ042RUljSm4zcmlxRUdIdkhk?=
 =?utf-8?B?aklRRlFoZG5uaUJPY1l0UHM4N0JnUlY1b3BmSldlczlwV0dWZm5LTURJSlNx?=
 =?utf-8?B?M3Y4R3ZFNUhmRFJGOHlldy9JTnVDU3lFV1U2cUtlZlRGU3dUd250cExWUFFQ?=
 =?utf-8?B?QXB4NVBiMDBNMW5hOW5WMnVZczRrWTdNT0RRWGxOVnBkQzZITktSeGhhMDVl?=
 =?utf-8?B?RDhhaTNJaGNQNGN5cHViWGoySGNZK0VLL0M1dUF1ZjQ5aWlzWXBPSEN6VEh4?=
 =?utf-8?B?ejkrZkU0VjY4cVdOeVMyaWh5YUFVTVBISHdvWlJTZ1RNR24ybDRQUG9nK0FP?=
 =?utf-8?B?ZGxTNHQ2c1ZMVVA2bFhpRExXRjZ4aXdBS1h4QlpLcyt0MkQ1VzI5QkdGdXdY?=
 =?utf-8?B?KzZ3Rmw0b3VjaGx5aCtoek9nLzVXKzRvU21rYjkvRncwazV0enVqTWl0VGcw?=
 =?utf-8?B?TUtQbGhraCtRb2g0WjlhK1p1MVA1NXZsbG02dTVBa0JpRjlZK25WT1NBZGw0?=
 =?utf-8?B?MDgreW5HbmNwRkZLbGxnNnNoWnVuVER0Um1PU3g5Qm41ZkViRUZLK2tPeVhs?=
 =?utf-8?Q?wnQvN3Yr1itkh4HBeIOIyXfzi?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf5b004d-f878-411d-80ad-08daadca731f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:57:05.3571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k3vA0DAUFN/kzPtoM0bL/PRkUaE8IxGb34QqfRQrebYFgAyFYsL9qhC8w8CzsC7pLLPTA9exMjr02RALEmsDqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9646

On 14.10.2022 11:28, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>>
>> On 14.10.2022 10:09, Henry Wang wrote:
>>> @@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d)
>>>      if ( !p2m->domain )
>>>          return;
>>>
>>> +    if ( !page_list_empty(&p2m->pages) )
>>> +        p2m_teardown(d, false);
>>> +
>>> +    if ( d->arch.paging.p2m_total_pages != 0 )
>>> +    {
>>> +        spin_lock(&d->arch.paging.lock);
>>> +        p2m_set_allocation(d, 0, NULL);
>>> +        spin_unlock(&d->arch.paging.lock);
>>> +        ASSERT(d->arch.paging.p2m_total_pages == 0);
>>> +    }
>>
>> Is it intentional to largely open-code p2m_teardown_allocation() here?
> 
> Yes, AFAICT p2m_teardown_allocation() is preemptible and we don't want
> any preemption here.

Well, this can be dealt with by adding a parameter to the function, or
by looping over it until it returns other than -ERESTART. Both would
seem better to me than this duplication of functionality (but I'm not
a maintainer of this code, as you know).

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:02:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:02:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422648.668815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHWn-00066A-Aa; Fri, 14 Oct 2022 10:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422648.668815; Fri, 14 Oct 2022 10:02:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHWn-000663-7i; Fri, 14 Oct 2022 10:02:53 +0000
Received: by outflank-mailman (input) for mailman id 422648;
 Fri, 14 Oct 2022 10:02:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojHWl-00065x-FG
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:02:51 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5af9b2cf-4ba7-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:02:49 +0200 (CEST)
Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 06:02:40 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB5919.namprd03.prod.outlook.com (2603:10b6:a03:2d8::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:02:37 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 10:02:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5af9b2cf-4ba7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665741769;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=c7LG7/wLOFe8/Mu52FLx9+uc+gxfDHeQDPJap9EXJEk=;
  b=da4LySFhxlDHOFDl5cJHV2zfh8zVD+pcyup9ylcfrqT3p6TxU16PEWST
   hvFzzlPur5NzGpUIgeb0QGuJjSkZM8HIX8fN8wWqGyv14Srtn7InAcFoM
   rGq2e0U8qJHzzRUFnvg5Sv6VfUczwbe6PLUiCy+JhWkmwNdf39XHhYuKb
   g=;
X-IronPort-RemoteIP: 104.47.55.175
X-IronPort-MID: 81843246
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:S7GJCqnFRAtul+fOsAUpKyXo5gxAJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXXTiFOqyNNDD0KtElbIXi8UpV656Dn4QyGwY9pC40FiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfL0JDp
 KwlBm4xKRG8lebu7LaKU/M0mZF2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1EZPLvFabI5fvSjQ8lPk1nej
 WXB52njWTkRNcCFyCrD+XWp7gPKtXOiCN5JTuHmnhJsqAXC30tJFS8JbH6mkeao1VyRRu1fA
 WVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9W9Vna15rqS6zSoNkA9MW4HTT8JS00C+daLiKE+iAjeCOlqFqGdh8fwXzr3x
 li3QDMWgrwSiYsB0fW99FWe2Ta0/MGWE0gy+xndWX+j4kVhfom5aoe06F/dq/FdMIKeSVrHt
 38B8ySD0N0z4Vi2vHTlaI0w8HuBvp5p7BW0bYZTIqQc
IronPort-HdrOrdr: A9a23:P4jFv611TxmwsPQHa7NwlwqjBetxeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hcAV7QZnidhILOFvAs0WKC+UysJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQjuVvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEw9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyTpAJb4RGYFqjgpF5N1H22xa1+
 UkZC1Qefib3kmhO11dZyGdgjUIngxes0MKgmXo/EcL6faJOA7STfAxxL6xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMMjgRBq3P4iFW5uYeE99RjBmckaOf
 grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATxRlCvgEl7d1amm1F+IM2SpFC6e
 iBOqN0lKtWRstTaa5mHu8OTca+F2SISxPRN2CZJ0jhCcg8Sjnwgo+y5K9w6PCheZQOwpd3kJ
 PdUElAvWp3YE7qAd3m5uw9zvkMehTIYd3A8LAs23EigMyMeFPCC1zydHk+1829vv4YHsrXH/
 6uJZM+OY6XEVfT
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="81843246"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PIlLaGHjdMVJQdecwYnBCrr36ibCowFE+jujJ5uTQWYmDJ+SbZQGFimMe1FwLdCFAZnVQoJB0u3SMn3x5Xslz6eGiT/BT9YrL2R2LpYAraF6+FNFCwpJlVHlMxW2K0AWM9joaPw56ArMFmEikuns3Jcp8E0rODPSDoIFzSk9b3rYwQmuTg03UUixjKVFLlQrvjx6KCVbaQrtPcWyl4BhH2Wn0vTCSqKb6+LhHAxdwJW00Vm3NJdaYowSMkLTHdL/2Zxou/OkcnhlLgmQ2R7ctmiLx46FBX0TYyxcza+QWGoFzXa9nRKJ74z0YjtcGU+By3PXSmHJ+G6L3Voe9rw/Iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c7LG7/wLOFe8/Mu52FLx9+uc+gxfDHeQDPJap9EXJEk=;
 b=hs3rIHDMfoeqJjj70rcsxy6ZPdSbPo6kn536nkndV+iIggaakPK4MGtwalW+p1C4C07XCSbYYqSbFtrZleC9vpGfkodEiWnSrSJ3rA2uG5BEx0Hz3XkhKUpzhVtcPg1I2DzbAL2hAYjAz7W+z/Pk1JSLoiU9pfco74+a/LLhLPqb/k5YE3BITHNZPAi71p76BSfZCA89qtb03k043slo2+/HvBrXdzNf12rB7AH4qaiTJrsK1LxTwlyJNuXef311CZywByrOGa4+rDjkDdAJnZtCY1O8eOhgEltB4hVVqtOLFao1MJQ/pCRcKCLXOnb/t2B7TR7wxx0OfLc566OPbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=c7LG7/wLOFe8/Mu52FLx9+uc+gxfDHeQDPJap9EXJEk=;
 b=q/jx2Jr8cDR6DfS0ShR+iQJXi/IP2xRnWOG5LOg5Nk3fNkvM+bO78RVUoTCDbal7nWdT6lG9MbXqY3mUkrBMZnZEUydGfy3CdqlAmrX7tDN783ormr33nTxuZbwpSxbNU1RdEozjIj6uEP52cM/8XP3ZfqXiZPNO6LYq2uMuHBM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, "Tim
 (Xen.org)" <tim@xen.org>, Henry Wang <Henry.Wang@arm.com>, George Dunlap
	<George.Dunlap@citrix.com>
Subject: Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Thread-Topic: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Thread-Index: AQHY36n1ImS1A0wmBkizaWL20LNyZ64NqNcA
Date: Fri, 14 Oct 2022 10:02:36 +0000
Message-ID: <79dc0e1a-8f8e-a05a-3db1-5163537c66e7@citrix.com>
References: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
In-Reply-To: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5919:EE_
x-ms-office365-filtering-correlation-id: 651fdb18-0dfa-44fc-f242-08daadcb38e2
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 BIO2HwqNv1x5YBj2zhUQCgXqnUpi+zYPnNRJCtp1PSqtqjMFhKgh6Ff0FU6T6ITcVkOTHkRH1hQ5gBhiqwgFKGtqbbmMQMXwYjMIJXTsh7x7waeUMqsg+yGevxFYdb1LpKEqgbAgUvsspOtab60RuAfUqXbRjoXGDdaPljsA4I1h7alKyHdDCaDL5V44qaajPqdwatJqtuWqsnYbICxVsqyIYDhd6ZbmihQb2lPyy+3ABnGQmlk7OPnVNDUcsNT9Z9E1OBc+9GAH+emxJvvW8X1/taVER6SolVlxaMR2fVeeBgW/xKIFdo8HDhfKkJrzV48ADPvv7YXj/wV8DFhFilPMnFblgVbdE9iSMuWNFNIb0A42xZKuF42Tf6d8Wo++rwWUdiMZlAMwvXi6SGoNhILZ1ygT3i598lKtipwBTSbNKaXVVwPJM1ThCmZEfZjJq8Kl4EpgD4AQwrGLnh1ruILS68NtBPVmBvZ8c3PxghuhlOYieqBkUv6IkgJIOvcJw0/vpmGUpr0GoMWX1X1Ys32GTsVdYcYseSWaSe+YwVXbjF7LT4dn1B22M8DSQSd4T6aPyGrTyhAfmw2VjfpVLUmGkHVfZ/26vPiGa2sVRIgsqvQmHlWPMFACttRg3irHSnYHcdmNDXlJKT2eb1hX60B4mhZzQyf05mM3E8vFA4IlGhnXpXuBhBVcmEsvrcrPPjZnZ4ZBUj1Tefj9luYsG3VoDI0/VdlfQso93ApTINB2Py57waKochXA5tKYi3n+Xro8PngFRE4nY8FnxO7DzDE+SyuNsbs9ZXb2rKv4CJClL76owbf7ms7QOt8FRL+bHS9odSpoVQJuP2bDAkEKWA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199015)(5660300002)(2616005)(2906002)(6506007)(8936002)(186003)(26005)(53546011)(41300700001)(31696002)(86362001)(6512007)(82960400001)(38070700005)(36756003)(83380400001)(38100700002)(122000001)(316002)(66899015)(54906003)(110136005)(478600001)(76116006)(66946007)(31686004)(91956017)(6486002)(64756008)(66556008)(66446008)(4326008)(8676002)(66476007)(71200400001)(107886003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZDIycFVOOEJqWFZkTXo1Mkc1V2RydE1QeU5TdnJMejBUYjBVZzgxV3BDclJj?=
 =?utf-8?B?VEU4VWdJYUZaek1CSGwwSThpV0t3eUg3ZEY3eXNWSldaZ0RpLzVpWlM1N1RM?=
 =?utf-8?B?WDhxU0xGWktrZFVDdnE1Nm10RXVnTHp6V2xraTlzT0RtVjd1dnlnRDIxL3FO?=
 =?utf-8?B?dHJDTHdWTmFzV2hwS2ozK0M5aXRpckE1cElxQnpOai9hcTJMdWRKUW9KWDZo?=
 =?utf-8?B?WE0zYnptd0NvWHBBTksyK2ppcC8wODR5Q0s4Z0duU1FRdEtrQU5pR2l0MGJy?=
 =?utf-8?B?b1dZT0F0eGQyZGJqZW12bnlKcGVYb2RLL1JQTm9udU5XVUN4em8yWGhjbzlk?=
 =?utf-8?B?ZUgrRnlsWjlEVGp4TC9McldvMFMvUjQ1TEh6eTRVdmY4QTMwNnBKNm0rYjlv?=
 =?utf-8?B?S09wYVV2aXpYUE5ORCtRWEJyMlNXU2svaFF4UC85Ti8yYVRvMGh1NXJpQkx5?=
 =?utf-8?B?dDEzbFpiRFZrU1BqWlIxNmhmUDRUeG1aM0xlOWhhWUNBcTFvYkVPdDBVUE5R?=
 =?utf-8?B?UmRXZHBBckF1QzlzMk5vZkZkaTkrNTFnUjZsTFJMSmpGVXp6dFpFcmFPYUFI?=
 =?utf-8?B?WC9ReGR5RlFKUXRvVWs0YVlva2IySit4MzhrS3J4TGwwaWxGWkNHL0JGYXhV?=
 =?utf-8?B?UHNlWi96VmNVQmYzMmdSS1laMkxHYlRzRS9XaFZVWnIvWjA2NWUzbWdMN3Yz?=
 =?utf-8?B?N2QzMlpKTjA5R0FlMEE2YWMzT3lKemJLTTVzNkpwck9WbGNMRXAxSTEvVzcw?=
 =?utf-8?B?TmtKa24wZzdPMVo0UGpsN3MraWthTUhhN1NzZnd5Mk4zN1NyQ2tMczBrZDEz?=
 =?utf-8?B?RHVxTmRVc3NWWWZJV1A4SFdIQkRtdXZUN3RRWFRVN01MY3QxOGRhV01zK0ow?=
 =?utf-8?B?UTN5YU9VbDlJZ3Fuc014aVVSTnN6OGt5WFAxSEZkUXpLVHlwa1FKalliajE2?=
 =?utf-8?B?Wjk4NWUxeHovVnJhT1JodnJPQTRYUVVGd2pFOExaUXB0WmFJSWVSODU4cnZp?=
 =?utf-8?B?WEtUekMveWJydHh5aFVLVXNlQkFBK1ZwUEhUT0RsY1hhVkU0SUticDc1aFJH?=
 =?utf-8?B?NWhVQ2xFaG44U0ErY0lHckxVSjNJTGpHZmcxakZTM2pjR1owVXpCdm0vcGdw?=
 =?utf-8?B?NElIZHZVem82Kyt3bVF0V0hzSUtueG82N0FyTVlIYVMyTVYrUlFrTE5ydWpT?=
 =?utf-8?B?M0xFczMyUEJiYTA2ZHViNXltUGRETi91SHV5OW95OFVaekR2bnBDbjVjR2J6?=
 =?utf-8?B?Uis3WDBsdG13MnVLZmZLZE53cXhrc2I5ZzluUjgwSzR1RGsyOVE4NytPalJ0?=
 =?utf-8?B?S3BRU0swcWtoTUkwYUgvMURnUjc2d0NLU1pCSlVReEFXTXRsTTJWK2NPRzJ6?=
 =?utf-8?B?Wnk3SW1kc1JQcitWMUxNWHdQczJrY0x5UTg3VnFDeE9oNFdHNWl4cER6MVQv?=
 =?utf-8?B?c0RoYkk0WnlBQWlIUE4vdU94T1pVeTd5WGlDKzd3dVhpZmpoZ2xmbWRaSXdC?=
 =?utf-8?B?SFEwNzN0VytkSUxoUVpWelVvSHY1OFl5WEFaU1dQUmVLbTRzc3JmTkFvczFP?=
 =?utf-8?B?QWgzbVhEUU9xb1duMVN6eTJSK214SUFXSnUxR05ZWEpDaTZDb3hKd3pZNlZT?=
 =?utf-8?B?dGZ0MER4eFMzSHRJanRVV0JxZWs1ek92TlBlRG40OEttdjNTSUNmZldXZHlZ?=
 =?utf-8?B?bmVZdENaM3liR3lQendEUS81bXFoL1lRM25oSUx0YU9Qdk9WYkpCTEEzc3Jl?=
 =?utf-8?B?SUE5a1ZxUHBwTGN2UFM1MFp5NmZaN0NleURwdk0wOWN0a29JRW5pajhrZTVZ?=
 =?utf-8?B?UlgzTzBYUWdlUHFSOHVrZWtMMForVllRMGMyc2NjSHJVMU5iQm1Cd0NhVmVO?=
 =?utf-8?B?RzE3VVl4bmcxNGk3c29OVW5tNFBtV3hwbFBVSW9xeVVFZHBKMXA3TElrd3Vw?=
 =?utf-8?B?QkJqK2tNTkZmY0tXRitRMTQrcU9uR0ZHTmg5QnptYkszWUQ4RFFUTTdCblBB?=
 =?utf-8?B?UUlvMFJBOHNtcUh5UENTcG5lTFRPSmNJd0E4Sk53NVdUeXVtVHNuNERUUDdF?=
 =?utf-8?B?MzhBRk5PNVJiSnR1N3hjV3MxbCtvaGQvWjBXWkV1ekpFdGdnaXcyYkgwRVgv?=
 =?utf-8?Q?23e7pibmgTQVXRq3czrfLYa/2?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2F4C113223F0EC4DBD7858320196EA90@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 651fdb18-0dfa-44fc-f242-08daadcb38e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 10:02:37.0397
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NKQu5Y8y5v1EMc9WTPOCL9yaVZcOyb4lQXGNQSN5Vk/ou/Mtepzisj053a6n+Ddx4qqipvX+Hosjmp7iE5VUxAPoaXKrfK1SencmIYBYaRI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5919

T24gMTQvMTAvMjAyMiAwOTo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZSBhZGRpdGlvbiBv
ZiBhIGNhbGwgdG8gc2hhZG93X2Jsb3dfdGFibGVzKCkgZnJvbSBzaGFkb3dfdGVhcmRvd24oKQ0K
PiBoYXMgcmVzdWx0ZWQgaW4gdGhlICJubyB2Y3B1cyIgcmVsYXRlZCBhc3NlcnRpb24gYmVjb21p
bmcgdHJpZ2dlcmFibGU6DQo+IElmIGRvbWFpbl9jcmVhdGUoKSBmYWlscyB3aXRoIGF0IGxlYXN0
IG9uZSBwYWdlIHN1Y2Nlc3NmdWxseSBhbGxvY2F0ZWQNCj4gaW4gdGhlIGNvdXJzZSBvZiBzaGFk
b3dfZW5hYmxlKCksIG9yIGlmIGRvbWFpbl9jcmVhdGUoKSBzdWNjZWVkcyBhbmQNCj4gdGhlIGRv
bWFpbiBpcyB0aGVuIGtpbGxlZCB3aXRob3V0IGV2ZXIgaW52b2tpbmcgWEVOX0RPTUNUTF9tYXhf
dmNwdXMuDQoNCkl0IHdhcnJhbnRzIHBvaW50aW5nIG91dCB0aGF0IGFyZSB1bml0IHRlc3RzIGlu
IHRoZSB0cmVlIHdoaWNoIGRvDQpleGFjdGx5IHRoaXMuDQoNCj4gVGhlIGFzc2VydGlvbidzIGNv
bW1lbnQgd2FzIGJvZ3VzIGFueXdheTogU2hhZG93IG1vZGUgaGFzIGJlZW4gZ2V0dGluZw0KPiBl
bmFibGVkIGJlZm9yZSBhbGxvY2F0aW9uIG9mIHZDUFUtcyBmb3IgcXVpdGUgc29tZSB0aW1lLg0K
DQpJIGFncmVlIHdpdGggdGhlIHByaW5jaXBsZSBvZiB3aGF0IHlvdSdyZSBzYXlpbmcsIGJ1dCBJ
IGRvbid0IHRoaW5rIGl0J3MNCmFjY3VyYXRlLg0KDQpTaGFkb3cgKHZzIGhhcCkgaGFzIGFsd2F5
cyBiZWVuIHBhcnQgb2YgZG9tYWluIGNyZWF0ZS7CoCBCdXQgd2UndmUgYWx3YXlzDQpoYWQgYSBw
cm9ibGVtIHdoZXJlIHdlIG5lZWQgdG8gd2FpdCBmb3IgYSBzaGFkb3cgb3AgdG8gYWxsb2NhdGUg
c29tZQ0Kc2hhZG93IG1lbW9yeSBiZWZvcmUgdmFyaW91cyBkb21haW4tY2VudHJpYyBvcGVyYXRp
b25zIGNhbiBwcm9jZWVkLg0KDQpBcyB3aXRoIHRoZSBBUk0gR0lDdjIgaXNzdWVzLCB3ZSBkbyB3
YW50IHRvIGFkZHJlc3MgdGhpcyBhbmQgbGV0DQpkb21haW5fY3JlYXRlKCkgKG9yIHNvbWUgY29u
dGludWFibGUgdmVyc2lvbiBvZiBpdCkgYWxsb2NhdGUgdGhlIGJhcmUNCm1pbmltdW0gc2hhZG93
IHBvb2wgc2l6ZSwgd2hpY2ggc2ltcGxpZmllcyBhIGxvYWQgb2Ygb3RoZXIgY29kZXBhdGhzLg0K
DQo+ICBDb252ZXJ0IHRoZQ0KPiBhc3NlcnRpb24gdG8gYSBjb25kaXRpb25hbDogQXMgbG9uZyBh
cyB0aGVyZSBhcmUgbm8gdkNQVS1zLCB0aGVyZSdzDQo+IG5vdGhpbmcgdG8gYmxvdyBhd2F5Lg0K
Pg0KPiBGaXhlczogZTdhYTU1YzBhYWIzICgieDg2L3AybTogZnJlZSB0aGUgcGFnaW5nIG1lbW9y
eSBwb29sIHByZWVtcHRpdmVseSIpDQo+IFJlcG9ydGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy
ZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPg0KPiBBIHNpbWlsYXIgYXNzZXJ0aW9uL2NvbW1lbnQg
cGFpciBleGlzdHMgaW4gX3NoYWRvd19wcmVhbGxvYygpOyB0aGUNCj4gY29tbWVudCBpcyBzaW1p
bGFybHkgYm9ndXMsIGFuZCB0aGUgYXNzZXJ0aW9uIGNvdWxkIGluIHByaW5jaXBsZSB0cmlnZ2Vy
DQo+IGUuZy4gd2hlbiBzaGFkb3dfYWxsb2NfcDJtX3BhZ2UoKSBpcyBjYWxsZWQgZWFybHkgZW5v
dWdoLiBSZXBsYWNlIHRob3NlDQo+IGF0IHRoZSBzYW1lIHRpbWUgYnkgYSBzaW1pbGFyIGVhcmx5
IHJldHVybiwgaGVyZSBpbmRpY2F0aW5nIGZhaWx1cmUgdG8NCj4gdGhlIGNhbGxlciAod2hpY2gg
d2lsbCBnZW5lcmFsbHkgbGVhZCB0byB0aGUgZG9tYWluIGJlaW5nIGNyYXNoZWQgaW4NCj4gc2hh
ZG93X3ByZWFsbG9jKCkpLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp
Y2hAc3VzZS5jb20+DQo+IC0tLQ0KPiBXaGlsZSBpbiBzaGFkb3dfYmxvd190YWJsZXMoKSB0aGUg
b3B0aW9uIGV4aXN0cyB0byBzaW1wbHkgcmVtb3ZlIHRoZQ0KPiBhc3NlcnRpb24gd2l0aG91dCBh
ZGRpbmcgYSBuZXcgY29uZGl0aW9uYWwgKHRoZSB0d28gbG9vcHMgc2ltcGx5IHdpbGwNCj4gZG8g
bm90aGluZyksIHRoZSBzYW1lIGlzbid0IHRydWUgZm9yIF9zaGFkb3dfcHJlYWxsb2MoKTogVGhl
cmUgd2UNCj4gd291bGQgdGhlbiB0cmlnZ2VyIHRoZSBBU1NFUlRfVU5SRUFDSEFCTEUoKSBuZWFy
IHRoZSBlbmQgb2YgdGhlDQo+IGZ1bmN0aW9uLg0KDQpJTU8sIGJsb3dfdGFibGVzKCkgaGFzIG5v
IGJ1c2luZXNzIGNhcmluZyBhYm91dCB2Y3B1cy7CoCBJdCBzaG91bGQgYmUNCmlkZW1wb3RlbnQs
IGFuZCBpZGVhbGx5IHdhbnRzIHRvIGJlIGxlZnQgaW4gYSBzdGF0ZSB3aGVyZSBpdCBkb2Vzbid0
DQpuZWVkIG1vZGlmeWluZyB3aGVuIHRoZSBhZm9ybWVudGlvbmVkIGNyZWF0ZSBjaGFuZ2VzIGhh
cHBlbi4NCg0KRm9yIHByZWFsbG9jKCksIEknZCBhcmd1ZSB0aGF0IGl0IHNob3VsZG4ndCBjYXJl
LCBidXQgYXMgdGhpcyBpcyBhDQpidWdmaXggdG8gYW4gWFNBLCBsZWF2aW5nIGl0IGluIHRoaXMg
Zm9ybSBmb3Igbm93IGlzIHRoZSBzYWZlciBjb3Vyc2Ugb2YNCmFjdGlvbi7CoCBXaG9tZXZlciBj
bGVhbnMgdXAgdGhlIGNyZWF0ZSBwYXRoIGNhbiBkbyB0aGUgd29yayB0byBlbnN1cmUNCnRoYXQg
YWxsIHByZWFsbG9jKCkgcGF0aHMgYXJlIHNhZmUgYmVmb3JlIHZjcHVzIGFyZSBhbGxvY2F0ZWQu
DQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:04:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:04:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422654.668825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHYS-0006iK-OG; Fri, 14 Oct 2022 10:04:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422654.668825; Fri, 14 Oct 2022 10:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHYS-0006iD-Lb; Fri, 14 Oct 2022 10:04:36 +0000
Received: by outflank-mailman (input) for mailman id 422654;
 Fri, 14 Oct 2022 10:04:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojHYR-0006i7-NO
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:04:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojHYO-00069h-Ra; Fri, 14 Oct 2022 10:04:32 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojHYO-0004Es-L8; Fri, 14 Oct 2022 10:04:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=TYSZNoNBPzD7xiPWASZMfBjV8Nwz6zVqvcvEkTGzgjo=; b=BrlpYZdDl1baMRkPwkh6NUBsiJ
	pccJxIcjHAiSqu5VDIlzwifzg/shdjASUBFL+9yXcF57H2NcdL+fen9Puc65XALnS43Qc1XnE6ArJ
	xhrxuNyy2GCTD5Kq3+qeWgmvHU5COgVlpimztaNpyMFc3U7tZg+cAsDmGpHWafi3iO7A=;
Message-ID: <b11427d2-f25f-b303-bf1c-db5be4806f4b@xen.org>
Date: Fri, 14 Oct 2022 11:04:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, Henry Wang
 <Henry.Wang@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
 <db3a487d-8330-fc68-8659-b6974352e7bc@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <db3a487d-8330-fc68-8659-b6974352e7bc@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Xenia,

On 14/10/2022 10:46, Xenia Ragiadakou wrote:
> 
> On 10/13/22 15:39, Julien Grall wrote:
>> Hi,
>>
>> On 13/10/2022 13:29, Henry Wang wrote:
>>>> -----Original Message-----
>>>> From: Jan Beulich <jbeulich@suse.com>
>>>>>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N 
>>>>>> - 1))?
>>>>>> Or is the root table not taken from the p2m pool?
>>>>>
>>>>> Correct, on arm the root is not taken from the pool.
>>>>
>>>> Isn't that a (perhaps just minor) mistake?
>>>
>>> Not really, in the code review phase, the question of whether we include
>>> the root in the p2m pool was discussed and the conclusion at that time
>>> was not including this page for now, as this is supposed to require a 
>>> lot
>>> of extra work/refactor. Probably there will be a series from my side to
>>> add the root to the pool, but at least not now.
>>
>> The root page tables can be one of multiple concatenated pages (up to 
>> 8 pages). The P2M pool is allocating page by page and therefore 
>> wouldn't allow us to allocate contiguous pages.
> 
> Sorry that I 'm asking this so late (I was just going through the 
> thread) but why 8?
Rather than providing an extra level of page-tables, the architecture 
allows you to provide multiple pages at the root level.

The number of concatenated pages depend on the maximum physical address 
and the start level. You can look at the table in setup_virt_paging() 
for more details.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:13:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:13:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422662.668837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHgm-0008Ht-J1; Fri, 14 Oct 2022 10:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422662.668837; Fri, 14 Oct 2022 10:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHgm-0008Hm-G4; Fri, 14 Oct 2022 10:13:12 +0000
Received: by outflank-mailman (input) for mailman id 422662;
 Fri, 14 Oct 2022 10:13:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojHgl-0008Hg-0e
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:13:11 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojHgh-0006Iw-Mt; Fri, 14 Oct 2022 10:13:07 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojHgh-0004iR-GC; Fri, 14 Oct 2022 10:13:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=XE/CvncOhDKZE/zf+AXzu82N8vm/UN3MSgLt3cuZ0Ts=; b=mLXQgbJeQ12aOnaB2Z6LMaS1T2
	Xmv7dfCpUWi/ngET3QcFSRmSiJvtoECgAncTgqZ+/EL2J5u5st06JR5iPasXJVd2vKOD8Ijcbyhnq
	WkCoXbejW8csGtS+rLpHOocoAwhmVBBAZyYrtVVunwYOIU4+H5hZed08+N4uib0D89jg=;
Message-ID: <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
Date: Fri, 14 Oct 2022 11:13:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 14/10/2022 10:28, Henry Wang wrote:
> Hi Jan,
> 
> Thanks for the review.
> 
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
>> arch_domain_create()
>>
>> On 14.10.2022 10:09, Henry Wang wrote:
>>> --- a/xen/arch/arm/domain.c
>>> +++ b/xen/arch/arm/domain.c
>>> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>>>           BUG();
>>>       }
>>>
>>> +    /*
>>> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2
>> area
>>> +     * when the domain is created. Considering the worst case for page
>>> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool
>> here.
>>> +     * For GICv3, the above-mentioned P2M mapping is not necessary, but
>> since
>>> +     * the allocated 16 pages here would not be lost, hence populate these
>>> +     * pages unconditionally.
>>> +     */
>>> +    spin_lock(&d->arch.paging.lock);
>>> +    rc = p2m_set_allocation(d, 16, NULL);
>>> +    spin_unlock(&d->arch.paging.lock);
>>> +    if ( rc != 0 )
>>> +        goto fail;
>>
>> Putting this level of knowledge here feels like a layering violation to
>> me. My first suggestion would be to move this call somewhere under
>> p2m_init().
> 
> That is definitely possible. If Julien or other Arm maintainers are not
> against that I am happy to move this to p2m_init() in v3.
I understand both of Jan and your concern. I don't really have a strong 
opinion either way.

You are the author of the patch, so I will let you chose.

> 
> The reason why the above block is placed here is just I thought to use
> d->arch.vgic.version to only populate the 16 pages for GICv2 in the
> beginning, and d->arch.vgic.version is first assigned later after p2m_init(),
> but later we decided to populated the pages unconditionally so actually
> now we can move the part to p2m_init().
> 
>> If that's not possible for some reason, I'd like to suggest
>> passing 1 here as the count and then adding a min-acceptable check to
>> p2m_set_allocation() along the lines of x86'es shadow_set_allocation().
>> That way you'd also guarantee the minimum number of pages in case a
>> subsequent tiny allocation request came in via domctl.

I really dislike this. If the user ask for 1 pages and we only allow 16. 
Then this should be rejected (not bumped to 16).

However, the code in p2m_set_allocation() will only look at the free 
pages (like x86 does). So what you suggest would not do what you want.

>>
>>> @@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d)
>>>       if ( !p2m->domain )
>>>           return;
>>>
>>> +    if ( !page_list_empty(&p2m->pages) )
>>> +        p2m_teardown(d, false);
>>> +
>>> +    if ( d->arch.paging.p2m_total_pages != 0 )
>>> +    {
>>> +        spin_lock(&d->arch.paging.lock);
>>> +        p2m_set_allocation(d, 0, NULL);
>>> +        spin_unlock(&d->arch.paging.lock);
>>> +        ASSERT(d->arch.paging.p2m_total_pages == 0);
>>> +    }
>>
>> Is it intentional to largely open-code p2m_teardown_allocation() here?
> 
> Yes, AFAICT p2m_teardown_allocation() is preemptible and we don't want
> any preemption here.

Like Jan, I would prefer if we can avoid the duplication. The loop 
suggested by Jan should work.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:14:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:14:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422667.668848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHhu-0000Ol-Sx; Fri, 14 Oct 2022 10:14:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422667.668848; Fri, 14 Oct 2022 10:14:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHhu-0000Oe-QI; Fri, 14 Oct 2022 10:14:22 +0000
Received: by outflank-mailman (input) for mailman id 422667;
 Fri, 14 Oct 2022 10:14:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ux67=2P=citrix.com=prvs=2791c07bb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ojHht-0000OU-ME
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:14:21 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6a5c36c-4ba8-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 12:14:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a5c36c-4ba8-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665742460;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=0kT25RmYnvKUKZpKsUBruywIQT4oL5Aw//QHvfay6ik=;
  b=huRUsvo/b5EOBbmED943oKnpeuIqbliERZJWh4TXLdVX4qcCjIfC9Ayy
   QrBgEMA8YHCssadSDl2xf5cyhjvOrpBqUowOM/35uQb6rTdDib0ksQ6PN
   q8Orap6pZ9z/VDbf5XYSdQQThwsWHKx1dSwLeFXdmVsgWChtXdID3SnNe
   I=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82364989
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2pPxBKNJNTVo09zvrR2il8FynXyQoLVcMsEvi/4bfWQNrUog0DxUm
 jZNDWGCO6yMNmWhKtxxPNix80NQuZDRn9FjGwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr5GtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eIdwipsRVIk9y8
 sdDByofUUGcovOn+efuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI
 ZpCAdZsRE2ojxlnM1ELCJU4jaGwi2P2aTFwo1OJv6snpWPUyWSd1ZC9aoGLJo3aFK25mG6Zq
 nn98HjrPSo1PcPD8xuH92uDn8bAyHaTtIU6S+Tjq68CbEeo7nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVfxC+um/CgRcaVPJZCeh84waIopc4+C7AWDJCFGQYLoV76olmHlTGy
 2Nlgfv1VAYzkp+2Z06azey7tyGNaDcwPH47MHpsoRQ+3/Hvp4Q6jxTqR9llEbKogtCdJQwc0
 wxmvwBl2exN0JdjO7GTuAme3mny/sShohsdvF2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7
 CldwJj2AAzj4PiweM2xrAclRuzBCxWtame0bbtT834Jrm3FxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtzvVpp6k/S5Tom4Dpg4i+aihbAoLme6ENxGPxbMjwgBbmB2+U3AB
 XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHcqT503+idK2PSfFIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWOHWLqdNNdQBbcRDWx/ne8qRqSwJKGSI+cElJNhMb6epJl1BN90iNqtr1w
 w==
IronPort-HdrOrdr: A9a23:RPOPLqDivZTT0SblHemq55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG+85rsiMc6QxhPU3I9ursBEDtex/hHNtOkO8s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U
 4JSdkGNDSaNzlHZKjBjzWFLw==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="82364989"
Date: Fri, 14 Oct 2022 11:14:09 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Message-ID: <Y0k2cQu8a3sHKSkf@perard.uk.xensource.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
 <AS8PR08MB79916265D28F1533ECC538F992249@AS8PR08MB7991.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AS8PR08MB79916265D28F1533ECC538F992249@AS8PR08MB7991.eurprd08.prod.outlook.com>

On Fri, Oct 14, 2022 at 06:26:09AM +0000, Henry Wang wrote:
> > -----Original Message-----
> > From: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
> > improvement, toward non-recursive makefiles
> > 
> > On 13/10/2022 14:04, Anthony PERARD wrote:
> > > Patch series available in this git branch:
> > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> > br.toolstack-build-system-v5
> > 
> > I've done a full rebuild of this (with the 2 noted fixes) with Xapi, and
> > it does resolve the Ocaml library linking issues.� Thanks.
> > 
> > So T-by.� If an allowance for 4.17 appears, I can see about getting some
> > of the more obviously-trivial areas reviewed and committed.
> 
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks.

> Since this series is quite large and just out of curiosity, do we have a
> pipeline or CI jobs to test all the modules that affected by the makefile
> touched by this series? Would be good to have some test results to
> boost our confidence of committing the series.

I did push my branch to Gitlab, and that the pipeline:
    https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/665987083
    (private to xen-project members)
Only failures are I think the same one as on staging, test failure on
arm, but no build issues.

I'm not sure that everything is tested, but most of it is.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:16:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:16:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422674.668858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHjl-0000zX-7y; Fri, 14 Oct 2022 10:16:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422674.668858; Fri, 14 Oct 2022 10:16:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHjl-0000zQ-5I; Fri, 14 Oct 2022 10:16:17 +0000
Received: by outflank-mailman (input) for mailman id 422674;
 Fri, 14 Oct 2022 10:16:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ux67=2P=citrix.com=prvs=2791c07bb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ojHjj-0000zK-DU
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:16:15 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3ad9b528-4ba9-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:16:14 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ad9b528-4ba9-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665742574;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=jQLaiJm3SpCLNIkC9bypqQU9EPoKcDb3PoId3J3oczA=;
  b=fkK7E/HwEohlopFFAPpjDDlpetVbF83EsA8aCTvftbGn/Km0H9WDlOps
   ToZsxLFcgbKAvmwQN4pUHFWrjuoGNdIFf+ZGRXuMpSE6k25R8irzTVLU5
   iaesYAx+paYMvPDyJ925nSZF/Dd6rsiOnnreh+1Xw/8VCdXBLnVfLDC/5
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 81844070
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:B/H7oa5N7R7PmkTGmVeUVgxRtLvHchMFZxGqfqrLsTDasY5as4F+v
 mVNXDuDO6uDZGP9e4h0YIy38kJTsMWGmtJiSQVv/3xmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gViPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5sE1hqq
 PgyCApdNBGRqPOVmOOQF6pj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP
 oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozTFZkJxhnAz
 o7A1zXAWQMfO8ek8muM0n+BgMX92gngc7tHQdVU8dY12QbOlwT/EiY+V1ShpuKiolWjQN8ZI
 EsRkgIyrK0a5EGtCN7nUHWQomOAvxMac8pdFas98g7l4qbd/QuxHGUPST9FLts8u6ceSDgn0
 FbPgt3oACB0vaOcYXWH/7yQoHW5Pi19BWMafioFUQst6sHuup0ulQnISst/EamzlZv+HjSY6
 yCHqm0yiqseieYP1r6n5hbXjjS0vJ/LQwUpoALNUQqN8QdRdIOjIYuy5jDz7/xNMYKYRVmpp
 2Uflo6V6+VmMH2WvHXTGqNXRujvvqvbdm2H6bJyI3U/3y+/wlr+eapw2mEkJVVGI+VcKBS0I
 0CG7Gu9+6RvFHetaKZ2Zae4BMIr0bXsGLzZaxzEUjZdSsMvLVHapUmCcWbVhjmwyxZ0zcnTL
 L/BKa6R4WAm5bOLJdZcb8MUyvcVyy833gs/rrirnk38gdJyiJN4IIrp0WdijMhjsctoQy2Pq
 b6z0vdmLD0GCYXDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdI4wfQLyr6To
 yzlMqO99LYYrSSdQThml1g5MO+/NXqBhShT0dMQ0aaAhCF4PNfHAFY3fJorZ7g3nNFeIQpPZ
 6BdIa2oW60XIhyeomR1UHUIhNE7HPhdrVnVZHTNjflWV8MIejElDfe+Ile3qXdWXnvr3Sb8y
 pX5vj7mrVM4b1wKJK7rhDiHljtdYVB1dDpOYnb1
IronPort-HdrOrdr: A9a23:I7/FP6H2RusG4lL0pLqE6seALOsnbusQ8zAXP0AYc31om+ij5q
 eTdZUgpHvJYVkqNE3I9eruBEDEewK7yXcX2/h1AV7BZniEhILAFugLhuGO/9SjIVydygc079
 YYT0EUMr3N5DZB4/rH3A==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="81844070"
Date: Fri, 14 Oct 2022 11:16:04 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Christian Lindig <christian.lindig@citrix.com>, "Daniel P . Smith"
	<dpsmith@apertussolutions.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, "Tim (Xen.org)"
	<tim@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, David Scott <dave@recoil.org>, Julien Grall
	<julien@xen.org>, George Dunlap <George.Dunlap@citrix.com>
Subject: Re: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere
 else
Message-ID: <Y0k25FFsREuri6Qx@perard.uk.xensource.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-6-anthony.perard@citrix.com>
 <b38e17b3-a4d5-c95e-1cbb-71b5ede8c51f@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b38e17b3-a4d5-c95e-1cbb-71b5ede8c51f@citrix.com>

On Thu, Oct 13, 2022 at 03:13:32PM +0000, Andrew Cooper wrote:
> On 13/10/2022 14:05, Anthony Perard wrote:
> > diff --git a/tools/debugger/gdbsx/Rules.mk b/tools/debugger/gdbsx/Rules.mk
> > index 920f1c87fb..0610db873b 100644
> > --- a/tools/debugger/gdbsx/Rules.mk
> > +++ b/tools/debugger/gdbsx/Rules.mk
> > @@ -1,6 +1,6 @@
> >  include $(XEN_ROOT)/tools/Rules.mk
> >  
> > -CFLAGS   += -Werror -Wmissing-prototypes 
> > +CFLAGS   += -Wmissing-prototypes 
> >  # (gcc 4.3x and later)   -Wconversion -Wno-sign-conversion
> >  
> >  CFLAGS-$(clang) += -Wno-ignored-attributes
> >
> 
> This hunk introduces trailing whitespace.

No, but it would be a good opportunity to remove it, I agree.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:22:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:22:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422679.668870 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHq3-0002Xa-VP; Fri, 14 Oct 2022 10:22:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422679.668870; Fri, 14 Oct 2022 10:22:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHq3-0002XT-S5; Fri, 14 Oct 2022 10:22:47 +0000
Received: by outflank-mailman (input) for mailman id 422679;
 Fri, 14 Oct 2022 10:22:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d1R5=2P=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ojHq1-0002XN-NB
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:22:45 +0000
Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com
 [2a00:1450:4864:20::533])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 245642e5-4baa-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:22:44 +0200 (CEST)
Received: by mail-ed1-x533.google.com with SMTP id m16so6230232edc.4
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 03:22:44 -0700 (PDT)
Received: from [192.168.1.93] (adsl-33.176.58.192.tellas.gr. [176.58.192.33])
 by smtp.gmail.com with ESMTPSA id
 f19-20020a056402195300b00459cd13fd34sm1547838edz.85.2022.10.14.03.22.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 14 Oct 2022 03:22:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 245642e5-4baa-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=SBZUM/Jv1MdF2Bh+mA9y2+o4wBcaHGU1MnQFABLd7uo=;
        b=AUMrIHLVHO5ZM+MGHsDetmM2D/2TkyEAJ4niDE4WITdsMpBIDNLC1nC4+zau+jVURn
         Bh2JNDfyTAYB2q02Dob79WvG1ucRDQJBVbLY8OC6TxPTZPUFIyMi+lpYNXkFydIUc87E
         4blFBf/1nRUgO63Ao6wyDBowEEqraOo6ptlKZG5beAmjo4v5R1XbbLzjJrZhcOQV4eMs
         vCADou5CdHTz4RtcMB+jmVe81fPsnP7mimsPa9sgPhtHVPQyQiTo/HEqCON3sU8opZBh
         tMPK/T/nEm81UZRqEMzHfrM/hiQ6az9DUfIK2qisPZh9f7OcJXmY22MY8snnp1h9Vs2n
         3l2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=SBZUM/Jv1MdF2Bh+mA9y2+o4wBcaHGU1MnQFABLd7uo=;
        b=IED4x1ENpWuaTh+NHS8OEU3aixO2nOUor7WsQTMEEfvW+JtAKqF1a6DGxjbYoDX8sB
         SYx3qDUOYVDMtL/pTmF/GMNAKFYcbDnP2zxzHk8odLPx+iKeSylDtlFTKxIatgbpEPg6
         /KAgIV7JlZnUMdurCtdmmYWeH5uj1MeW2tZcx9nLrCp+8AnSUFozni2NqKgTtHXzL7ma
         8FrWeDN8rft+QCydWwrUV/LZ+yPU66A9PqpBaZUgeS2M5zuM4tfGS5l8LTlwJz5J+Ewr
         ZsFZkhH0taHU5Etqbjon3qlSmeqKwVcN1ZTmikj4h993qTsfW+B5uVA8ZnnGVR1p77sm
         w99w==
X-Gm-Message-State: ACrzQf2M814RJkqAUNg0OARk+RBb9ywnt1fLPutFm0wuAm4sQWLaizW1
	qqVj4G0+cetqMK9LQO08TTU=
X-Google-Smtp-Source: AMsMyM4tZ8IbyjhLoMg3v03Aujjc8Dj1AV7xbi7058g8FXBZ9l94GmA1GjkvLjwq/YEOuZvkxLfLEA==
X-Received: by 2002:a05:6402:28a1:b0:458:81c0:a379 with SMTP id eg33-20020a05640228a100b0045881c0a379mr3634359edb.388.1665742964062;
        Fri, 14 Oct 2022 03:22:44 -0700 (PDT)
Message-ID: <c1b82073-08a5-033f-86aa-3a318f596ef0@gmail.com>
Date: Fri, 14 Oct 2022 13:22:41 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
 <db3a487d-8330-fc68-8659-b6974352e7bc@gmail.com>
 <b11427d2-f25f-b303-bf1c-db5be4806f4b@xen.org>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <b11427d2-f25f-b303-bf1c-db5be4806f4b@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 10/14/22 13:04, Julien Grall wrote:
> Hi Xenia,
> 
> On 14/10/2022 10:46, Xenia Ragiadakou wrote:
>>
>> On 10/13/22 15:39, Julien Grall wrote:
>>> Hi,
>>>
>>> On 13/10/2022 13:29, Henry Wang wrote:
>>>>> -----Original Message-----
>>>>> From: Jan Beulich <jbeulich@suse.com>
>>>>>>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * (N 
>>>>>>> - 1))?
>>>>>>> Or is the root table not taken from the p2m pool?
>>>>>>
>>>>>> Correct, on arm the root is not taken from the pool.
>>>>>
>>>>> Isn't that a (perhaps just minor) mistake?
>>>>
>>>> Not really, in the code review phase, the question of whether we 
>>>> include
>>>> the root in the p2m pool was discussed and the conclusion at that time
>>>> was not including this page for now, as this is supposed to require 
>>>> a lot
>>>> of extra work/refactor. Probably there will be a series from my side to
>>>> add the root to the pool, but at least not now.
>>>
>>> The root page tables can be one of multiple concatenated pages (up to 
>>> 8 pages). The P2M pool is allocating page by page and therefore 
>>> wouldn't allow us to allocate contiguous pages.
>>
>> Sorry that I 'm asking this so late (I was just going through the 
>> thread) but why 8?
> Rather than providing an extra level of page-tables, the architecture 
> allows you to provide multiple pages at the root level.
> 
> The number of concatenated pages depend on the maximum physical address 
> and the start level. You can look at the table in setup_virt_paging() 
> for more details.

I think you are referring to this:
[6] = { 52,      12/*12*/,  3,          3 },
Still I cannot understand why the maximum number of concatenated level 0 
translation tables for t0sz 12 and 4KB granule is 8 and not 16?

> 
> Cheers,
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:28:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:28:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422685.668880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHvp-0003H8-Iv; Fri, 14 Oct 2022 10:28:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422685.668880; Fri, 14 Oct 2022 10:28:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHvp-0003H1-GF; Fri, 14 Oct 2022 10:28:45 +0000
Received: by outflank-mailman (input) for mailman id 422685;
 Fri, 14 Oct 2022 10:28:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojHvo-0003Gv-Bp
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:28:44 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9a16cc3-4baa-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 12:28:42 +0200 (CEST)
Received: from AS8P251CA0018.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::25)
 by GV1PR08MB7874.eurprd08.prod.outlook.com (2603:10a6:150:5d::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 14 Oct
 2022 10:28:35 +0000
Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f2:cafe::28) by AS8P251CA0018.outlook.office365.com
 (2603:10a6:20b:2f2::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Fri, 14 Oct 2022 10:28:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 10:28:33 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Fri, 14 Oct 2022 10:28:33 +0000
Received: from d7ede52d05c0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DAFE02A7-CCF5-4D6A-8F8E-B4E6E4E34E3F.1; 
 Fri, 14 Oct 2022 10:28:27 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d7ede52d05c0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 10:28:27 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV1PR08MB8691.eurprd08.prod.outlook.com (2603:10a6:150:85::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:28:24 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 10:28:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9a16cc3-4baa-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=co/ydTdkXnuD8lnFE6iNDk9jAJEJafQHtBr8psqk1Ot8+FEObHq8mNxEIAZwwevoBSZGuD/Y59+U1wj4V60qVxA4vnVFjRl4nyIitrq5WeJwG+H196StF5cpaAJKWXR26xi3rIt+sr9oRKfEBTiOBvI5amVEn2iPm5mi5V35H3uNoouwqcJ9eR4/GHjx3xKEqSwCpEONH5hJCvf8d8oMwnF6ZPmA8PR2qYFt48FNjtWWPqwXhm5avSaiCxjxrE/sHU5xPMzU6qPSQZf/atj0g2jntImt62amf62T1JzTI9+Ev++HEkjqkqYsPoxVy8Zfu9armvgoEL74soFEFtxVaQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WXFItBA4ng3GKzEsgRIez/mUlHcsivWZppKhdzPm/Dk=;
 b=QDS/PD3yL8EmOUjwyS0d7JLhHpOTie8CKc6UpXyFnLQAfgi42HwnmRAcyHURuqatjsW7noxEvITjkgKutoNMaV22IBTJwQL7AW55FIAREbQUQTQrJAJA/bzpGBuuka8C5UARj6AhIvT9dJreoORt2C7lmEzgfNXrmUDnjDHxJY25X8l9MjeynUoVSaaVSrsgUWJGalYtafEbbpyRJNDLXR+UtZgrzh8Kpwu1a0sOPvzFdVwH2LqkZhWPdPnJAgRYh0Bd2ve/qNlDd1Kt6/QHLw8Xw8SfmHR1nmJee4zA/1hwrg4YTR+w6Y9RVwJzLOgHlujA64hBv8JM+UFw48US0g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WXFItBA4ng3GKzEsgRIez/mUlHcsivWZppKhdzPm/Dk=;
 b=EFqyNKEIwhzjMAPOJwROSu07n2bHOhsCOFKeHA4TRy1dBuwHB6Ki4e99YIy+C0XbzeQ5vhsZLloJo6upFQJoJk4glCCJsBn/6fleGqDYGXcneOvNCv+gDfC8wP+XT5YpYElo17GD1Y6MvEmlkP5098otoKpcAeUkvDK4aFvl0W0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a/1yXXIJCyt12+ZiA6nVSCtiHS3slou9zKfVvTaGFtFddjK9PH766VIy96wFsdNGtWbCSTCbUz3uCNtCbkB57JuXdpZfOkKJQeRjSnz9yUGjruFM+emml1pXaFQ9+nPC2imQkecdYraDisbNJQXgdJhQzGBNhfwV3VPTI4NV/uD7aO0FsYJ2oISRwptDIelLzwXVz4UdNgjfwLRbrYvx3La3ccIJUQL1+EgrHMmdC6Q0CutFE5u75ffGaT1sEwigzssgt/aXi/1L8wyIYbFRcpVuVn4lLaNHQrQB1zL6adI7HfTheo4tSeUriXZ+OAnzxYgemHQRCt0n2IzVwzmJtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WXFItBA4ng3GKzEsgRIez/mUlHcsivWZppKhdzPm/Dk=;
 b=biKiG3kAlagJaYInTdmslvnso1CLM2HGh137Cwz1XY6gwsL4/TcnzuerAI/myVOsix8g1Jt1JvSblE9AVdPms25LdhU0o7GlID3kJPGroSGNnDPb53DiUAIjXCpJZ9MeoOPPMLSNfSzsZaK0ZxeBvNdW4JKl2O9wmHcSAmVGVyI1g5LL2FlKH8G0DuS9SlopuC2QrV0OYC4nfwVZCtidEnPWimlHi+SXl3xv9m1L9eXs7jfYAxpTQi7tkh/oOJp0Y6HlFvug3kecivlY5RYtazPPETta4zW5k/VXNKzVZuKAkIv0DFCl1s3J/RZAwJzq4qHRXhKmsude/I0hPXBXfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WXFItBA4ng3GKzEsgRIez/mUlHcsivWZppKhdzPm/Dk=;
 b=EFqyNKEIwhzjMAPOJwROSu07n2bHOhsCOFKeHA4TRy1dBuwHB6Ki4e99YIy+C0XbzeQ5vhsZLloJo6upFQJoJk4glCCJsBn/6fleGqDYGXcneOvNCv+gDfC8wP+XT5YpYElo17GD1Y6MvEmlkP5098otoKpcAeUkvDK4aFvl0W0=
From: Henry Wang <Henry.Wang@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement,
 toward non-recursive makefiles
Thread-Topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Thread-Index: AQHY3wSf1tDccsob1U2UzC8OPggTyq4MneqAgADO4WCAAECRgIAAA4iA
Date: Fri, 14 Oct 2022 10:28:23 +0000
Message-ID:
 <AS8PR08MB7991AF5A4FCE5C063F854B6492249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
 <AS8PR08MB79916265D28F1533ECC538F992249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <Y0k2cQu8a3sHKSkf@perard.uk.xensource.com>
In-Reply-To: <Y0k2cQu8a3sHKSkf@perard.uk.xensource.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 60ECE8307B92304383F343A27633E081.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV1PR08MB8691:EE_|VE1EUR03FT046:EE_|GV1PR08MB7874:EE_
X-MS-Office365-Filtering-Correlation-Id: af437635-f9cb-433c-43ad-08daadced8ac
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 U0TV7OwqIxPlsDZFs5lS5oXoyHGNkP0P5+9A5x+ATMU/dgz3U1J0jLk1kcaI3p2d7x2dAN7T3Q+S/I9pNablsCqd5pFZt79ynugOhFZ78ITbemcnuaP81+daOfIUMNejTbKcPUbrmEEJNnVOBmd1RyGkIvRDQhi9cC9D5vlaJIsiJHvI21UiSM3QyfumZcSFPDcf2xabCbUn3liRbgTTma7BI+RT+pAoOqVv3ShMeX92IUxMW8lHWQeXXxWhgVDNORu8wQnDSvWcfuiJB9oS6SCwcSjM23GP/5l+OIwmLCUMdoXmoKQf6M4cxJN6Nilyz4B2sCo7ZJ9TJEFXpKtOPUcnlZbl+4AMbKIT8OEqyGPksJDlF2FOHlA+F8eVAydZj+kmF1a2PX0p80FL73HGDv8baaHPABTkBrs5pG7Wk6qQv4IXcgcioGkoU4o4Cv3s7/HSwsjJwvjfoaq8bYnVt8+V+QPbXOvkAyUG+qqusn5/P+5oFxw1Ck6p5NQ992WVgUHqKruDI996AypvWwOqo0R0ekgD9OL6HnZdXTbgoJmG8c++vwgdnSgoDAcdybL1cQ0LJHX/5Sp8i1G+SfLQZ4R2dpQloLlDCfkU0d20Gtl+Dj7yPZe1qyC/dpa3U5P+9zPcQ3SZyOP+oRz6HfWmsem+CcPAaKFDG28pKaQliLWilLNxuTcrlDs/jMoNB2gpB4KyAHhdn1WRWvXF+HapRgOWtDYWIej8KImTv+4UzY7Yj4yAjkIXbR4mvHODeXXhprT51bKg1Fy59AosKx3GSWPTKljhLumLvMHqqpXz1QE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(346002)(396003)(136003)(451199015)(53546011)(26005)(66556008)(83380400001)(86362001)(6916009)(38100700002)(7696005)(4326008)(64756008)(66476007)(8676002)(66446008)(66946007)(6506007)(76116006)(2906002)(33656002)(9686003)(8936002)(5660300002)(55016003)(52536014)(41300700001)(316002)(186003)(71200400001)(478600001)(966005)(122000001)(54906003)(38070700005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8691
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8928b0f0-fa98-4138-6a41-08daadced2e5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N2gj6rnQSCUv7n3FRVFyC4K/3UruWh9ZNOvmlKGo/0LTJu1sP4GfqK8IgVlD/pIW9XlVLD0lODm8ie/an8AEWiG2614MWRkyr54lKVB3gIvq9Ec/UDRvVTMY/mMMo2rpemXfFKuP12bJoSPwJ08KU8z8Cy5BHUW+Z6KlbspfggvZrWlzH30scNzDPoQ+ZPg/6IqyIQ7MGSHWuP7iJb37t9NYFKkTCxDS6WXR+7FOKofTUSAhSWw+Yz6Gq5wGyynUurzOpEKO4d2P080A9zyapCgbTJ+4NdwpGfD0yiDU/LNkP15EYwYdHDhNYGq8sjn4EntYgxMoyAXriKHvrl89Q9tOV9VSVKHAJi2K3YMnUMfWwbSlRJInBN5dwN3q+5gb9uTzIRw7fgYm8zouigUcPRUclzVnBh4r0YmZqKIuogi0wuV3AXL/ztA6bx2WubOfztqrIFNik5Q5fLUfr0wZjoZyB+tNLmhx8KcW2OZEHsfLhIqLjMe/Hh1OV4ztVe+lnRW0H4Hk4016RNqU6Tzf35u9sYqB7O6x969XzF+40z1nxT+dqH6qJnbqhhmaN2VVm3Xj85FTu8/v/vnaqBCf2jAzC7pw3lUgfe1vuWAA2uQd/dVuDxb4TjDMVbjGypMdMHAQ8LKx80g3Z8+ghdhAEF6CffyD5PoGeOEJc/NqEevQ/DfWPyfcPt87yLxuS+XPcR1w/kx5yzBk9aBF/UZDdyj3By+c1HdPwN8YCEAEniNWTmSbDy5Qfu9E84aqQCoK8SOIvEi7E4/9Wt8zjJSRfQVU5OpZ3/m1Pwp5+Ki4FdE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(9686003)(83380400001)(186003)(336012)(26005)(82310400005)(70206006)(2906002)(70586007)(86362001)(52536014)(4326008)(5660300002)(53546011)(7696005)(55016003)(356005)(966005)(6506007)(40480700001)(33656002)(316002)(478600001)(8676002)(47076005)(54906003)(41300700001)(6862004)(8936002)(82740400003)(81166007)(40460700003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:28:33.5132
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: af437635-f9cb-433c-43ad-08daadced8ac
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7874

Hi Anthony,

> -----Original Message-----
> From: Anthony PERARD <anthony.perard@citrix.com>
> Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
> improvement, toward non-recursive makefiles
>=20
> On Fri, Oct 14, 2022 at 06:26:09AM +0000, Henry Wang wrote:
> > > -----Original Message-----
> > > From: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > > Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
> > > improvement, toward non-recursive makefiles
> > >
> > > On 13/10/2022 14:04, Anthony PERARD wrote:
> > > > Patch series available in this git branch:
> > > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> > > br.toolstack-build-system-v5
> > >
> > > I've done a full rebuild of this (with the 2 noted fixes) with Xapi, =
and
> > > it does resolve the Ocaml library linking issues.=EF=BF=BD Thanks.
> > >
> > > So T-by.=EF=BF=BD If an allowance for 4.17 appears, I can see about g=
etting some
> > > of the more obviously-trivial areas reviewed and committed.
> >
> > Release-acked-by: Henry Wang <Henry.Wang@arm.com>
>=20
> Thanks.

No problem, my pleasure.

>=20
> > Since this series is quite large and just out of curiosity, do we have =
a
> > pipeline or CI jobs to test all the modules that affected by the makefi=
le
> > touched by this series? Would be good to have some test results to
> > boost our confidence of committing the series.
>=20
> I did push my branch to Gitlab, and that the pipeline:
>     https://gitlab.com/xen-project/people/anthonyper/xen/-
> /pipelines/665987083
>     (private to xen-project members)
> Only failures are I think the same one as on staging, test failure on
> arm, but no build issues.

Sorry for the arm failure, I will try to respin the patch ASAP and hopefull=
y
the CI will be unblocked soon.

Kind regards,
Henry

>=20
> I'm not sure that everything is tested, but most of it is.
>=20
> Cheers,
>=20
> --
> Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:30:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:30:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422692.668891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHxk-0004gh-3L; Fri, 14 Oct 2022 10:30:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422692.668891; Fri, 14 Oct 2022 10:30:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHxk-0004ga-0R; Fri, 14 Oct 2022 10:30:44 +0000
Received: by outflank-mailman (input) for mailman id 422692;
 Fri, 14 Oct 2022 10:30:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qaRP=2P=citrix.com=prvs=27923c854=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ojHxi-0004gS-EP
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:30:42 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e990f9c-4bab-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:30:40 +0200 (CEST)
Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 06:30:36 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB4944.namprd03.prod.outlook.com (2603:10b6:208:1b2::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Fri, 14 Oct
 2022 10:30:34 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 10:30:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e990f9c-4bab-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665743440;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=l/yY1pnpQ8B7x9nC2Mo08GJ+F20sE4qw2VAD19w/qRo=;
  b=Vrot/IdWCHh7HtVU24w9akNVLWa8qYIhuAVC6UWsWXYFPs8hw1lXO6vl
   2LhP0yZv9DksNluGvUeohYIE5CWq/K25xDt/LUopryu8y7AYxJH+0BIqO
   HY/YzZBOBHNBHuNjXnN2l09Fc4NdEXtAEFE2Yi40KQzJgFAhZuyaRM9aX
   g=;
X-IronPort-RemoteIP: 104.47.70.101
X-IronPort-MID: 82365720
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:eXUAJqDY2l4bqhVW/xPiw5YqxClBgxIJ4kV8jS/XYbTApDN002BWy
 TAbUGmCOPeKYzTwc9h2ao+29RkG7MeEzoRiQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2u4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kfBIs9/Nt9UFhq8
 NwGCwoMXz2v26GplefTpulE3qzPLeHNFaZG4jRK626cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWIA7gvN/MLb4ECKpOB1+KLqP9fPPMSDWO1en1qCp
 3KA9GP8av0fHIzFkmTYrSj07gPJtTPjZY4/Eu2Vzcw0vlSC7WkJVyQ0UVTu9JFVjWb7AbqzM
 Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy
 Vuhj97vQzt1v9W9VXOY3qeZq3W1Iyd9BU8PYzUVCzQM5dbLqZs2yBnIS75e/LWdi9T0HXT6x
 W+MpS1n37EL15dTjuO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l
 CBss6CjAComVvlhSATlrD0xIYyU
IronPort-HdrOrdr: A9a23:xqBmF6A6v+4iyRTlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN
 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d
 enl4N6T33KQwVlUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w
 3+CNUZqFh/dL5pUUtDPpZxfSKWMB27ffueChPlHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou
 WKbG9l
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="82365720"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PD957D75Yrdf9lmPvUcVwG+E7bQaaZSSOdzVZXsr7Haeq3Xv/uApNjY8w/QcOXfg7xdhnWlRxR0437E+NA8SmHS4Xfju+bZ2A98X6/pL8EKdfv3VyGLGxcDmCi2C7yvBg5Q3s0l8uIGHOf5BAJ1ZfXOGf3J4UY9QBTWRKo8PEL8XlLiYwYmemfrAng3u1usZcSqdwqQQVwSnV3VcAek9kRJafIhw2uPg7a7+ipx/fbegXtF8mcCQHOZ9GrFW4oh7zH/kQEb3u/HmBVTWIctvtAPv52gnLTvE2AQJK+GOBdiUnClYmti5nw291IVjpvm0J+SasAkfg1llJ8f5J77q5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/O70qrqLleir06Q+TDztBUljEHDJW+cZ4CXvcP9Rx8Q=;
 b=HVcJl3ombemQION7NQlSI027RlB1SjreaDk8DjTFCwWrvAEGtegYf94NUcd7w3HMPg+/65HcSQIJse2q4LeBFlU02KR/JBfkkKtKUtunkJKrNgFcrJMrh/AYYr75OcPf/8nAH9yUhrLfIZlpaYhVwb5FDu4w6O4ng77D1ErVevFOTB6EHX+Adj3rowf5RX0hkW/zVv8loycXtWMV3r+z6FdUypSS0sEI28DzuIkPL91eBEHcJyEEeWryXVNn4OS0T1TrsmIEqFuXoFqHR3fmolkk1/1zGN8INVO1GMHc73oF0rE/JWB2kB0cUjYgRO6TVS51I4mFoSZtzFnscLppAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/O70qrqLleir06Q+TDztBUljEHDJW+cZ4CXvcP9Rx8Q=;
 b=Lvpa1WwUdvaBdfB0aHuEScih++pH/IrtxJjbT2YbOz62rqIZce8AP+/7nBpA528vQWAiuq+uhe28PfzP3wtK0bkcR4OJxc20AMYqMEbJeFrfPVODNgxFZezYOjlmypZcGdVcQTPChu/23EAXO6tP24UsTe4tcWW0aORdqX3yK3U=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 14 Oct 2022 12:30:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Tim Deegan <tim@xen.org>, Henry Wang <Henry.Wang@arm.com>,
	George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Message-ID: <Y0k6RSI0VJhTVmEi@Air-de-Roger>
References: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
X-ClientProxiedBy: LO4P123CA0656.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:316::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB4944:EE_
X-MS-Office365-Filtering-Correlation-Id: 0bd5a149-b3d5-419e-09f0-08daadcf204f
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q4PGnVqkyvAvyA5TRZ9ijZWzS7AAp5H6bIbnwvqe3czZFiXYIDZJFyXDIOIBrKofbyUHrWjj6AAVPZl83etik4yk6UsAWhwtzj5GUoqPfnZ28CKjOWJZntJZkFcM+3zu+pLHL79T6YWHtCo9gVJYMWL8lrGs6Fq18zdDH7z+f0SM//XmOQREYyI6Tfrhv2lavQ/PSi0azMuU5M7gdVrHYdXFtMEP+drGr8k6uaorn2UxZdV18gQK45/466Mk/VjfqbONNqJYDdnkkVXrnz0EXx6EiHkub1Qa1PZ6TDdTcTJ6yZ+378//ne7bEYdj/C7nzoSPTRgi0KcqWtMZfeVBXbDHQ5wPlhaGJcjxMQbapAHGNHd1h7EDVa6gCZYjuHxM2LjzbJG9/FvNn90nAtjL4mpVwfcvKnaOrAC1JiHzsvrF7ZJEWSZy/N1ZFZ6RmU7p3ZqeuX3FqDAzqvEhcX7EDZSHsSPM2A+gvzzjukC0hhjBgzVOnJyTJCXjLSb/0KVNHZMUodQ3dyXkGirhjgBXNygZSzLN5r8IwQgzCz2VNBGic0VzLgO2SgU/7ustR2yYbccW34xN6SKPKFeAhgATV5HgAXgZhe0HbuSCf60cT75cxXGCr8jhKtesUSN/ZS9EbbmtX5ZdyWO+pnaRgg2PwSBroRiHmavn+kft5svDrZ0Us4b9hUVzLmd4At7ermUnOLwmtizPvZ/a3iI3NMOkQKrJGA8B2TiIHs7Vu3CUo53aL85iv81RCLCynXYUDG6D
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(86362001)(8936002)(85182001)(6506007)(6666004)(5660300002)(2906002)(478600001)(186003)(33716001)(83380400001)(54906003)(6916009)(4326008)(6486002)(26005)(66556008)(66946007)(66476007)(8676002)(107886003)(41300700001)(82960400001)(38100700002)(316002)(9686003)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a3pTZ1NVbXoxODlNL3M5U2xYSnpqTk1PTmREOFRpc1VGcy9rMVQ2WlNGKzFo?=
 =?utf-8?B?YnNiSnlRSkZFV1k3V1ROOGErQlp4RG16czNUSWxkOHBCMzdWR1Bpck16QzRX?=
 =?utf-8?B?dmE4cGZaeXIyd1JPZCtDSEJiQjFrSkJXK2swNG5oOWRMQnNiUWtJcCtlcmhr?=
 =?utf-8?B?eWFrR2hOOHJKdGdsWk9uUncrQXBCZ2FabUhWUTMxZThlM3lzV3U3UXdmYlli?=
 =?utf-8?B?QURDM1R6dEk1aFVzRFNTaHp5YjVoaktveGxQcE1oUjBkRE1JK09iWUg5OEJj?=
 =?utf-8?B?WnB4bGtlNWlZUFpLaEFTa2JFb2JQa1Zqa1Rsc0U3YmxPVUlXR0FRSVRMTnZP?=
 =?utf-8?B?T2RsR1dhL2Q5aEhoV1J5QmtVSkZ5MHFISTNDaXB3WlFZNnZMcXZVbUtvOWpj?=
 =?utf-8?B?eG9PMlRJbGo3VHVhQXpOR2pOeW11TVp2Y2h6WVBRc1R5SlY1RzdZeFRwUHRU?=
 =?utf-8?B?SE1vWDV4NlhQcDZQK1EwUlhEclR2TXVUYnZoTzVnS0xTN1MrbU5BdkhjbERo?=
 =?utf-8?B?UjNyckRZWDhManNKY05jNmxrajNnVTAzelJkbW1xd3NqUWlxRnV4S0RGam5w?=
 =?utf-8?B?bHc2bWJILzR2SzAyOXR0ci9jWGVqTW1RUWhoSnluVmRnRU9DZmZ5L1h0ZlN4?=
 =?utf-8?B?c2dsS1Y3TmgrZHJXamp4Zzk3a29CcjhXY2doOEVCYm56aFM2NkV1V3FUMmhy?=
 =?utf-8?B?WVlRckQySmtONi9CL2taVlYyWWVMcUl6K1RJUW8yNlRCamMreDFBbkJaTFhU?=
 =?utf-8?B?YXpubllhMjVsYjU3c1JkQXd2WVRzMlZqaXVpUDRQbWxSMUdxbXAwTGpKc0hw?=
 =?utf-8?B?M2NhM2NDeWdLbEtNTHpmcXp6S2F6Ni9PamhiY0RSdzJSblRUbDFvUzhrSWpv?=
 =?utf-8?B?dmhXZE1hWjZFOFVCUFdMRy9EK2FHc2ZYcnZKL2M2SkhzR3hvVjFKTnFqaGhq?=
 =?utf-8?B?bzZIUSt5Vnp1dDE4UUMxOVA5VTNHVmpRSjhrTzdyTTVxVTk4VER3ZE1aM1FS?=
 =?utf-8?B?clJkVXJYa1lyaGFDeGZmSU9vRXk5ZU93WHdwcC9hUG1nWEcraFMreFl2ZXJ2?=
 =?utf-8?B?dmJRVExHaVdOUHlacXJhYmVjTkd4Y0VNejJ0Z3o1MlQyWlR4OHNTY0RUOXNK?=
 =?utf-8?B?YUNTN3Y3QXRyQkZlbXRBekhPdWdLZDBXWndhUnMyV1FzeTMwVXZUUnhRNC9v?=
 =?utf-8?B?UnZDaERlRzN5SXhiekNPUE9Wd21DaDYwU1JtbnVzZTRJdFVHd2RwZ0ExM3Uv?=
 =?utf-8?B?ejNXMk5XSkJLa3hMK1JyVUZjYVFSNG1paTNhMUFsVENGWGUwMDJkVVpZY0ZU?=
 =?utf-8?B?WmR2dVp1ekFWSzBFTkxLSy9OLzRMOVc2WTBCMjdSWGxOT3c2czN6bDZlTmEy?=
 =?utf-8?B?dS9mYjd2cW8wUmNUNnpSZDFYRmhMalpWa1pRNDB4d1pXd0o3WmxCUUczUE9H?=
 =?utf-8?B?N3ZjN2tYMFFQeE1pOERSdHdERmRTU3JRSGdDYTFMQ3dxeFEzT21RVnM0YU9S?=
 =?utf-8?B?OHFIcXVkbFRsOFp1cVJ4SndaVEhwSXVBeFdqQ29MTkJrWUkxaHBLeTJXUmpG?=
 =?utf-8?B?RTlMM3YvcXFwbWZVTE9iZHBSWDQvMnV2em9CREhaekZjMTNrc1dHNnZVM3Ba?=
 =?utf-8?B?NlBSVzNlS0RKRWpqOTB2L2R0L01OYVRFN09NaWpSYzZIZTVNaDA3T05NZkJG?=
 =?utf-8?B?MHhLQ1N5NXFSMHFNNkdYb010NTlIOGpTb0tkMy9DQlNoVzVERDJWN3R2Rkl6?=
 =?utf-8?B?aWIvdHdua0FBRzFhUUlDZHRBVUd6dFF5ZGhSN25IS1VUUU5ERmRXU0p3T2s4?=
 =?utf-8?B?bUdkQ01xVWMwc1JiMk5Tc1ZaZUNjL2VLd0d3Y2YyV2hnNGMyVGJ1cUs4VHdP?=
 =?utf-8?B?dlVqdEg4UzJPU2NBZC9CaktNd3VTY3UybEo3bzVmNHh2RlJCcXpxdlpyUGNa?=
 =?utf-8?B?V0pweGVCaEI0S3h3YVY4YjBoVnQxeEJQS2ZwVWpmalN1bEtUTkhkZWI3eUE5?=
 =?utf-8?B?NWp0dVFId1dnNm1CV081TmxoWWJRdHN0dlNiL25qNkVqZ1pSQ3drL1ZpMUY5?=
 =?utf-8?B?NEtYNXFEQUx5N1o2WkZPSkpDNHN4YUxRZFZxZGovUG9QNHpNWmNKVk1LejRm?=
 =?utf-8?Q?0V5JPEULf9VMBisDQrA4zvypM?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd5a149-b3d5-419e-09f0-08daadcf204f
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:30:34.1215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Hh4Sr+od9fy1D+8CL6N46m0PAWK4DRYP2F2jEB6X+Q5jhk8+ZC3/0o+f2yWsG1lJUa+VYExyRBI20reP1TdpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4944

On Fri, Oct 14, 2022 at 10:49:55AM +0200, Jan Beulich wrote:
> The addition of a call to shadow_blow_tables() from shadow_teardown()
> has resulted in the "no vcpus" related assertion becoming triggerable:
> If domain_create() fails with at least one page successfully allocated
> in the course of shadow_enable(), or if domain_create() succeeds and
> the domain is then killed without ever invoking XEN_DOMCTL_max_vcpus.
> 
> The assertion's comment was bogus anyway: Shadow mode has been getting
> enabled before allocation of vCPU-s for quite some time. Convert the
> assertion to a conditional: As long as there are no vCPU-s, there's
> nothing to blow away.
> 
> Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> A similar assertion/comment pair exists in _shadow_prealloc(); the
> comment is similarly bogus, and the assertion could in principle trigger
> e.g. when shadow_alloc_p2m_page() is called early enough. Replace those
> at the same time by a similar early return, here indicating failure to
> the caller (which will generally lead to the domain being crashed in
> shadow_prealloc()).

It's my understanding we do care about this because a control domain
could try to populate the p2m before calling XEN_DOMCTL_max_vcpus, and
hence could trigger the ASSERT, as otherwise asserting would be fine.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> While in shadow_blow_tables() the option exists to simply remove the
> assertion without adding a new conditional (the two loops simply will
> do nothing), the same isn't true for _shadow_prealloc(): There we
> would then trigger the ASSERT_UNREACHABLE() near the end of the
> function.

I think it's fine to exit early.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:31:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:31:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422697.668903 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHyS-0005Dv-C9; Fri, 14 Oct 2022 10:31:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422697.668903; Fri, 14 Oct 2022 10:31:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHyS-0005Do-9Y; Fri, 14 Oct 2022 10:31:28 +0000
Received: by outflank-mailman (input) for mailman id 422697;
 Fri, 14 Oct 2022 10:31:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojHyQ-0005DW-EP
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:31:26 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojHyQ-0006dF-4B; Fri, 14 Oct 2022 10:31:26 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojHyP-0005Ok-UV; Fri, 14 Oct 2022 10:31:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7BeKFaTkbHyH46PIG8dWbxa+e15SOWdJco5+qrwqVmo=; b=vWN1Ul6hUY4WHRLdlc9+dN740M
	ndF+EcSUmoU56Lssq5Y6Yu9rpbRqCTwvKaFrJ7sPGwvUI+zKHV690A5hAu3WPa6bKuXDyVH/1fpKk
	uYEadnzQaJXx6hDC787VXsQxZ2bkT5RkX53ax4SwN/dlIZHdjcIoT5g8RMsuo889jVV4=;
Message-ID: <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
Date: Fri, 14 Oct 2022 11:31:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221014080917.14980-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 14/10/2022 09:09, Henry Wang wrote:
> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> when the domain is created. Considering the worst case of page tables
> which requires 6 P2M pages as the two pages will be consecutive but not
> necessarily in the same L3 page table and keep a buffer, populate 16
> pages as the default value to the P2M pages pool in arch_domain_create()
> at the domain creation stage to satisfy the GICv2 requirement. For
> GICv3, the above-mentioned P2M mapping is not necessary, but since the
> allocated 16 pages here would not be lost, hence populate these pages
> unconditionally.
> 
> With the default 16 P2M pages populated, there would be a case that
> failures would happen in the domain creation with P2M pages already in
> use. To properly free the P2M for this case, firstly support the
> optionally preemption of p2m_teardown(), then call p2m_teardown() and
> p2m_set_allocation(d, 0, NULL) in p2m_final_teardown() if needed.
> 
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> ---
> This should also be backported to 4.13, 4.14, 4.15 and 4.16.
> v2 changes:
> - Move the p2m_set_allocation(d, 0, NULL); to p2m_final_teardown().
> - Support optionally preemption of p2m_teardown(), and make the calling of
>    p2m_teardown() preemptively when relinquish the resources, non-preemptively
>    in p2m_final_teardown().
> - Refactor the error handling to make the code use less spin_unlock.
> - Explain the worst case of page tables and the unconditional population
>    of pages in commit message.
> - Mention the unconditional population of pages in in-code comment.
> ---
>   xen/arch/arm/domain.c          | 16 +++++++++++++++-
>   xen/arch/arm/include/asm/p2m.h | 11 +++++++----
>   xen/arch/arm/p2m.c             | 15 +++++++++++++--
>   3 files changed, 35 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2c84e6dbbb..831e248ad7 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -740,6 +740,20 @@ int arch_domain_create(struct domain *d,
>           BUG();
>       }
>   
> +    /*
> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> +     * when the domain is created. Considering the worst case for page
> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
> +     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
> +     * the allocated 16 pages here would not be lost, hence populate these
> +     * pages unconditionally.
> +     */
> +    spin_lock(&d->arch.paging.lock);
> +    rc = p2m_set_allocation(d, 16, NULL);
> +    spin_unlock(&d->arch.paging.lock);
> +    if ( rc != 0 )
> +        goto fail;
> +
>       if ( (rc = domain_vgic_register(d, &count)) != 0 )
>           goto fail;
>   
> @@ -1064,7 +1078,7 @@ int domain_relinquish_resources(struct domain *d)
>               return ret;
>   
>       PROGRESS(p2m):
> -        ret = p2m_teardown(d);
> +        ret = p2m_teardown(d, true);
>           if ( ret )
>               return ret;
>   
> diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
> index 42bfd548c4..480d65e95e 100644
> --- a/xen/arch/arm/include/asm/p2m.h
> +++ b/xen/arch/arm/include/asm/p2m.h
> @@ -194,14 +194,17 @@ int p2m_init(struct domain *d);
>   
>   /*
>    * The P2M resources are freed in two parts:
> - *  - p2m_teardown() will be called when relinquish the resources. It
> - *    will free large resources (e.g. intermediate page-tables) that
> - *    requires preemption.
> + *  - p2m_teardown() will be called preemptively when relinquish the
> + *    resources, in which case it will free large resources (e.g. intermediate
> + *    page-tables) that requires preemption.
>    *  - p2m_final_teardown() will be called when domain struct is been
>    *    freed. This *cannot* be preempted and therefore one small
>    *    resources should be freed here.
> + *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
> + *  free the P2M when failures happen in the domain creation with P2M pages
> + *  already in use. In this case p2m_teardown() is called non-preemptively.
>    */
> -int p2m_teardown(struct domain *d);
> +int p2m_teardown(struct domain *d, bool allow_preemption);
>   void p2m_final_teardown(struct domain *d);
>   
>   /*
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index f17500ddf3..707bd3e2e3 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1685,7 +1685,7 @@ static void p2m_free_vmid(struct domain *d)
>       spin_unlock(&vmid_alloc_lock);
>   }
>   
> -int p2m_teardown(struct domain *d)
> +int p2m_teardown(struct domain *d, bool allow_preemption)
>   {
I think the part to clean & invalidate the root should not be necessary 
if the domain is not scheduled. Similarly, I think we might only need to 
do once by domain (rather than for every call). So I would consider to 
move the logic outside of the function.

That's not for 4.17 thought.

>       struct p2m_domain *p2m = p2m_get_hostp2m(d);
>       unsigned long count = 0;
> @@ -1716,7 +1716,7 @@ int p2m_teardown(struct domain *d)
>           p2m_free_page(p2m->domain, pg);
>           count++;
>           /* Arbitrarily preempt every 512 iterations */
> -        if ( !(count % 512) && hypercall_preempt_check() )
> +        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
>           {
>               rc = -ERESTART;
>               break;
> @@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d)
>       if ( !p2m->domain )
>           return;
>   
> +    if ( !page_list_empty(&p2m->pages) )

Did you add this check to avoid the clean & invalidate if the list is empty?

> +        p2m_teardown(d, false);

Today, it should be fine to ignore p2m_teardown(). But I would prefer if 
we add an ASSERT()/BUG_ON() (or else) to make confirm this is the case.

This also wants to be documented on top of p2m_teardown() as it would be 
easier to know that the function should always return 0 when 
!allow_preemption is not set.

I also noticed that relinquish_p2m_mapping() is not called. This should 
be fine for us because arch_domain_create() should never create a 
mapping that requires p2m_put_l3_page() to be called.

I think it would be good to check it in __p2m_set_entry(). So we don't 
end up to add such mappings by mistake.

I would have suggested to add a comment only for version and send a 
follow-up patch. But I don't exactly know where to put it.

> +
> +    if ( d->arch.paging.p2m_total_pages != 0 )
> +    {
> +        spin_lock(&d->arch.paging.lock);
> +        p2m_set_allocation(d, 0, NULL);
> +        spin_unlock(&d->arch.paging.lock);
> +        ASSERT(d->arch.paging.p2m_total_pages == 0);
> +    }
> +
>       ASSERT(page_list_empty(&p2m->pages));

I would move this assert between the two ifs you added.

>       ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
>   

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:32:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:32:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422703.668913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHz9-0005oE-Kd; Fri, 14 Oct 2022 10:32:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422703.668913; Fri, 14 Oct 2022 10:32:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojHz9-0005o7-Hq; Fri, 14 Oct 2022 10:32:11 +0000
Received: by outflank-mailman (input) for mailman id 422703;
 Fri, 14 Oct 2022 10:32:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojHz8-0005nv-BH
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:32:10 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 739f56a0-4bab-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:32:08 +0200 (CEST)
Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 06:32:05 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CH2PR03MB5366.namprd03.prod.outlook.com (2603:10b6:610:96::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:31:49 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 10:31:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 739f56a0-4bab-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665743528;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=PE86i4T4FUCEJzA1ciNQcL/ZBkq9E4Hd28jjXeVn9ZY=;
  b=ST5R4B1wDcNQjQXfSsqPQ6GxbNABAO82sVGuHFBmfPbRqs5tkHFrTEpq
   qIrjQrASwLI9kWRb00NGReJ6WHWgN+vklnxCDlUUFWOvQMIuBFdUGF3c7
   9FoXr0F9Yk2o8FbevLhuU0CP4MAtidZA6NVQO/n+n836Vkkpcg62UwdP5
   4=;
X-IronPort-RemoteIP: 104.47.55.169
X-IronPort-MID: 83153999
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:9EcmFKyg2w/FXndpvFd6t+cqxyrEfRIJ4+MujC+fZmUNrF6WrkVVm
 jNLWTiAa/uMNmejftt/atjk8kgPuZLcy9AxSlFp+yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw895cBX186
 sAhJnMpfx+nqcWT+KuKY7w57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvTm7IA9ZidABNPL8fNCQSNoTtUGfv
 m/cpEzyAw0ANczZwj2Amp6prr+UxH6gCdNDfFG+3s9wpgaw/3NQNAE5fEOnp/+9sV7gGN0Kf
 iT4/QJr98De7neDbtT7RQz+n3eCsTYVQd8WGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHjVGOYXeU97PRpzXiPyEQdDUGfXVdE1pD5MT/qoYuiB6JVsxkDKO+ktzyH3f33
 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zl6/sr6Nhu+hWLOYWg==
IronPort-HdrOrdr: A9a23:Ukf8ka4Lbgav9wgNAAPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="83153999"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=On+jnMSuSWwtIrh+kLDEvKZKK+H0mI0vMjDS/FqV6ly6ybAogsN1NuH6QUEba3/qaDr8Jdor4JDKpA2JW5USJguio4Mdbg05et9OdSj62INx1s1x0HanCZ8ssolI4K05K9LBySgRluB4A36pfyFm4IpJyNLNg7YZAIfAx/Zg9aEPAlgNN/bIb5tb5PbMfE6zlnQ3GDP3+LyuzKfgcRWJF5idSagkMBP5SXeqD/UfoLcDZo8ho8nfSPjbfNFh7KxZtxYNW+p/fsvNxD7XcrYjj4iuJRkg+qFkrp0F7xW8WX6SB0n5YL2hsGIkTLNhHx2NNq7iR9GhcSXM7un9DzmPkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PE86i4T4FUCEJzA1ciNQcL/ZBkq9E4Hd28jjXeVn9ZY=;
 b=b4Vz5nTntq2ipw2tFTynenDCQUrYd8ZlO7P71AGhNDZzfKa88tb11V/Spc6qtORFIZtl2w93yAzwc2DHvPJ7ABZh4B7nNX73onmuYDu8sWzC95+wug0319oZwBRdIPH8iW96yzMNtaSIxigNwXt+eafLg7R91b3McoL1NRIFVRmAwnIW/rXH3bloz3mguNAGQA51lXLKdrO1LGd3f1A70UvaAEiOxtcV4QtQAwkHbUkNPw0ZRPt+Hm7MaDbqJ+ia6maskdHFyqxCvRIM1dbry/BkQLtCUw/TN0DD72sa70mqozegjv+cs/Al9actQV04I7LCsZDWJfWCZHrQM0qwXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PE86i4T4FUCEJzA1ciNQcL/ZBkq9E4Hd28jjXeVn9ZY=;
 b=mb2k1iyZPchAXaVwaNIFtk3l+GmR/gN7FT1haQkqCIStWsC2ooAJ0KoeNRD8JnWtNOlplz2jDE6Knkj6nU038ESP4T665MeIG6hHg2FYKdaW4RTaCuake+hC05fus0TFzyoB3rbUqRe2AriR3JQD+Rzp3j7ga+GFQGYr2EdJYd8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement,
 toward non-recursive makefiles
Thread-Topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Thread-Index: AQHY3wR19l5fPoXHX0uqLO79kk12za4MneoAgADPvoCAAD+0gIAABO8A
Date: Fri, 14 Oct 2022 10:31:48 +0000
Message-ID: <0faa9a33-e3a2-1a8b-b0a5-581a14175c2e@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
 <AS8PR08MB79916265D28F1533ECC538F992249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <Y0k2cQu8a3sHKSkf@perard.uk.xensource.com>
In-Reply-To: <Y0k2cQu8a3sHKSkf@perard.uk.xensource.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH2PR03MB5366:EE_
x-ms-office365-filtering-correlation-id: 46444bf2-fe6a-496a-70af-08daadcf4d07
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 vNJmc7CJGrBwoiom0eNeLUqN1f74XJbznHOtf8r3DWUgMUjDOnPQDBj0iEtzeneJgeT4oZKiSua/EMYeLwxuYqd6QOwg1VHrHYmyzq0aJTJ2qUq60/mtpFAMVEfmsJ3K6xrr3tq9nVLUeQFxAUsXSHwYzYvumn7ezMa8J+mwgVIXmjzoYFS/RHvWBwo1DqOhIADnspE38kWRA4RaLejnYTUdWRQ0Tu5VxC6QrXRPFC4idUsM3Cu5ST2UTFQA5FOXcuwPM6NyADUBsrD+aK/ERsXGVu6UeG1mP8Jow8Ko4LuYin6uc8xXr4y7fWRBQ4XP6hbcnV3XoOafqCG6qdx3/nYyxwYpHHpeY3ufnO7k/22sI/87sA8OEeqv9D06fK1DzEEFkteMfBJkJN3qTZ08VL04u7WElK9cWt29FzgrfeIKjVZSlSR4k3KiYwXzImTU8Q/frvEJQIAdtY50tGWfOJ8iyifzoEyNbf2A+ahnHBD6IdB2XIub73UqT8q1pw5vqiDVCrXqQXsBzA8AMAK/PV0VjlNGLArD5RyUW6UxtvFGKzQqdHZliI7sshERcwxFblYgxM7RtiDEGo/0Ki4Ys7t4jhfZ6YlWHafe7GwPRL2dL+Vi1IbY1k3b8qEDYoU+gLWGF7kDITWCgjBfyNz65cISWF7Wp+Usde46OJVMO/1XW1em7gSC5iGkM+ixMZ6GzZXHnif/HS+Uxf7at8QDGS0YkV8RTy9SB5799o9rAKq4qST97onwQeUGQ31wztigT8akNi9U2zsaYJKP8OT9BKAGNV8XYimbYwFa9cY1AuYTfCGAApwaoKdFmnijvCmyLhf9pwdlOqjtt66OGEqv9PCtnKfOllHdv3f3yibT/WQ=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199015)(110136005)(316002)(76116006)(4326008)(66476007)(66556008)(66446008)(66946007)(8676002)(64756008)(91956017)(6486002)(966005)(31686004)(478600001)(71200400001)(6512007)(26005)(53546011)(41300700001)(8936002)(6506007)(5660300002)(186003)(2906002)(2616005)(38070700005)(36756003)(83380400001)(38100700002)(82960400001)(86362001)(122000001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VUhQZ1lHcE1tZlpWaXJ5aVAzMVlxZnVnMG1JQm85dVlnMmk2Vnp2YUVMdmxO?=
 =?utf-8?B?OEsrZ3RJTGFDTkptb0dlWEkvbGNDMFBINVh6eG9ybGxBNlFUOG5XTUhOczFI?=
 =?utf-8?B?ZnhRRW1Ra29kNTUxZEZXdHFqOUtsKzd3Uk9xU0twcTRZUG5ZVTFYOVlVd3Zl?=
 =?utf-8?B?QXpYaGYxWElpajBQUE9nQVo2bFQvSFlnbnQvNHhJcVJlSmRTOVZyUEVoRit1?=
 =?utf-8?B?WEtUVDZ2M2dZWDVGbFVKYWZCU0FhM0tucDVlbnNmVHZCanVDUENDcnR6U0FV?=
 =?utf-8?B?SEs5NGoyd2ZtQkord3dRcTBxN3V5S0FCV2FPT0tQN3BMbTNnMFlxM1ZHa2tM?=
 =?utf-8?B?OGZUVjgwbDNmbW1YMXZybDN5S2JWTmZKY1FaV244akIxL1d3VkJDVit3bmJ1?=
 =?utf-8?B?ejJ2dGtWZlZYNmtqR1MxYnlQd1l0T2hSN2tLN1g1V29uUk5iY3E0enExeDFy?=
 =?utf-8?B?dHVmUGs1emNyT2pwTENPVjJHZHByZzZ5S3RKUVRTd1Y3WkcwaEQ5T3FpcWpk?=
 =?utf-8?B?UVJyZ1VPNEk2UE5aR0wvNlY1L3lReGEwSk1DTkhPQ2Qvc29LbFBpc2ZkQVRl?=
 =?utf-8?B?dXprdk1VNkpUcWlGRUp6SHVtSXd6SVA3encyQ2pHK1BrcTYweTdCTWdTZVVp?=
 =?utf-8?B?U2k0TlVMU0d1ODlTNE1vTGJtZG52VWJCMWZaYmowODFSd1o0VE9pRmpPVUlt?=
 =?utf-8?B?SEFKb2ZTdjZmeUg5WndqVnVKUzl3UlRZZ01pK2UvcE9qLzd4cCtQdjIvYmRu?=
 =?utf-8?B?eWFEbksyVGR0TzltMEFYdVp0eXZIV25IZUhNR2xKT25oK3NIUjdtb1E0S3c0?=
 =?utf-8?B?eXVvNzZWaUxVQlcrTEhNbWI2dVdGV3JMbm9neEZneUh0U3RaKzBxVmg0a3Q3?=
 =?utf-8?B?Y3JYRnZJZTlhdzRmTzdzOUxibXdwVlE3KzZScmZkUXhNMTFrM24vMzhpb3dU?=
 =?utf-8?B?Wmc4ejBDQ0hxTVl2MlVoWnRVUHRnYmlsQXpEcXB1Vko2Y0UxQ3dqMUljUlVw?=
 =?utf-8?B?Qm9xRjRaQkhLSzhQV0FwNjlYMUpDS3ZCV1pSajdlRmNEMk9xeWJ3RlJNdTlF?=
 =?utf-8?B?Q0xwZktWcVVKRE5GS200aUYvOE8vSnFyWFhVVzhmT1RRdThpQTlhSWNYMkVa?=
 =?utf-8?B?OVFEUldhSnVRUXlyK0Vya2l3ZFRnQTRMbnZUdndRalM0Z29jQmVvdzJRSkkx?=
 =?utf-8?B?K2Y0UC9Nck5BeXppQXg2MStodSsyNVBnaGRDaVlhVVNaVmwvQ2llcHVLcDRE?=
 =?utf-8?B?dWIwTnc2S3Vqb1J3dkZ1ek1zbkx1dHFwQWl3dG5lcWwwSzJIUVZVcmdTZVp3?=
 =?utf-8?B?bUQzS0o0NlRPUnllZVF6dDkxQTJjTk94cEVKdnVNd1hKMzBvK1FpdzFrWTJo?=
 =?utf-8?B?REp5Vm5Wb2JWRXU1Z0pKTWczNzcvYWpVQzZTMVd2K0ZKZUhQNHloQS9uM0x2?=
 =?utf-8?B?enZwSEpKck43aSt2YjF5Q1NManJZZzJoWXhmVjk5alcxdG5aM0VnWkFHNUVY?=
 =?utf-8?B?d1orWW02YVYyT0RTcU8rRjNYN1lxUCs0MVByaEF3T1dKbk9ZZEJnRDhUMFM2?=
 =?utf-8?B?akY0Y1RYZWxRelMwaFBCV1gxWjA3SFBpbnc1MGJ1Mlc5djhzb3libGk2cHJW?=
 =?utf-8?B?U3hhQkdPTXg2UklhMjdvdlR3N3h4US9QVzhaODFhWldwbTNNcHRDeGFxYWli?=
 =?utf-8?B?QnowNEhLa2E4TzZ4UWtUNjVPNUV4cHZHUkdYVjRReHJadURJQlVsWEkvTUZ4?=
 =?utf-8?B?SkhLRVBMMVZiWnVNMDdtNWxjZzVORFplTytQMDlMR2J1TXJMQW04ejNOMDh5?=
 =?utf-8?B?VDd5VW8ybEkwVElaWWFkNXV3MVBqc3NWa0RDWDA3c3FqRStHOW4wNEpyNFFu?=
 =?utf-8?B?MHlBYkEwWjNOSllnT3lvQWVyTVNJTGVvdVFCLzNucjQ4MnpTNVRaa3M0eDFN?=
 =?utf-8?B?T0xhdllaL2ZWVTlEZnJPMFA0ZVQ2K3E4SlBHeHlrRUdIN1BHM3dDeTEveFpn?=
 =?utf-8?B?eGZNUDZXNDgvNUVNN0RsaXRzTzFZQnRGazAyaUptdlJwdUlnbWxhMUNvdUwv?=
 =?utf-8?B?V3Z2cjVSSXFMTG12WU5jU05zNmNHaW1kU1QwMTZabGxHQ0gwZFc5U09lZ0dl?=
 =?utf-8?Q?BKzp1w5VQw0K4UzJ6TVAj4iKB?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <390DF663F318ED4781E294322F0B732B@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46444bf2-fe6a-496a-70af-08daadcf4d07
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 10:31:48.8359
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZwBjewd2P4IahzjyC6qFbK9jwuceif70Ap1AkpcSxmftoTem2eoRnke2LEIQG63D39A3vi0d943OM1znfeIkaZuirSrEFTgYzDTCGBnZARg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5366

T24gMTQvMTAvMjAyMiAxMToxNCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIEZyaSwgT2N0
IDE0LCAyMDIyIGF0IDA2OjI2OjA5QU0gKzAwMDAsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+Pj4gLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+PiBGcm9tOiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcu
Q29vcGVyM0BjaXRyaXguY29tPg0KPj4+IFN1YmplY3Q6IFJlOiBbWEVOIFBBVENIIGZvci00LjE3
IHY1IDAwLzE3XSBUb29sc3RhY2sgYnVpbGQgc3lzdGVtDQo+Pj4gaW1wcm92ZW1lbnQsIHRvd2Fy
ZCBub24tcmVjdXJzaXZlIG1ha2VmaWxlcw0KPj4+DQo+Pj4gT24gMTMvMTAvMjAyMiAxNDowNCwg
QW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+Pj4+IFBhdGNoIHNlcmllcyBhdmFpbGFibGUgaW4gdGhp
cyBnaXQgYnJhbmNoOg0KPj4+PiBodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXQtaHR0cC9wZW9w
bGUvYXBlcmFyZC94ZW4tdW5zdGFibGUuZ2l0DQo+Pj4gYnIudG9vbHN0YWNrLWJ1aWxkLXN5c3Rl
bS12NQ0KPj4+DQo+Pj4gSSd2ZSBkb25lIGEgZnVsbCByZWJ1aWxkIG9mIHRoaXMgKHdpdGggdGhl
IDIgbm90ZWQgZml4ZXMpIHdpdGggWGFwaSwgYW5kDQo+Pj4gaXQgZG9lcyByZXNvbHZlIHRoZSBP
Y2FtbCBsaWJyYXJ5IGxpbmtpbmcgaXNzdWVzLsKgIFRoYW5rcy4NCj4+Pg0KPj4+IFNvIFQtYnku
wqAgSWYgYW4gYWxsb3dhbmNlIGZvciA0LjE3IGFwcGVhcnMsIEkgY2FuIHNlZSBhYm91dCBnZXR0
aW5nIHNvbWUNCj4+PiBvZiB0aGUgbW9yZSBvYnZpb3VzbHktdHJpdmlhbCBhcmVhcyByZXZpZXdl
ZCBhbmQgY29tbWl0dGVkLg0KPj4gUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnku
V2FuZ0Bhcm0uY29tPg0KPiBUaGFua3MuDQo+DQo+PiBTaW5jZSB0aGlzIHNlcmllcyBpcyBxdWl0
ZSBsYXJnZSBhbmQganVzdCBvdXQgb2YgY3VyaW9zaXR5LCBkbyB3ZSBoYXZlIGENCj4+IHBpcGVs
aW5lIG9yIENJIGpvYnMgdG8gdGVzdCBhbGwgdGhlIG1vZHVsZXMgdGhhdCBhZmZlY3RlZCBieSB0
aGUgbWFrZWZpbGUNCj4+IHRvdWNoZWQgYnkgdGhpcyBzZXJpZXM/IFdvdWxkIGJlIGdvb2QgdG8g
aGF2ZSBzb21lIHRlc3QgcmVzdWx0cyB0bw0KPj4gYm9vc3Qgb3VyIGNvbmZpZGVuY2Ugb2YgY29t
bWl0dGluZyB0aGUgc2VyaWVzLg0KPiBJIGRpZCBwdXNoIG15IGJyYW5jaCB0byBHaXRsYWIsIGFu
ZCB0aGF0IHRoZSBwaXBlbGluZToNCj4gICAgIGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVj
dC9wZW9wbGUvYW50aG9ueXBlci94ZW4vLS9waXBlbGluZXMvNjY1OTg3MDgzDQo+ICAgICAocHJp
dmF0ZSB0byB4ZW4tcHJvamVjdCBtZW1iZXJzKQ0KPiBPbmx5IGZhaWx1cmVzIGFyZSBJIHRoaW5r
IHRoZSBzYW1lIG9uZSBhcyBvbiBzdGFnaW5nLCB0ZXN0IGZhaWx1cmUgb24NCj4gYXJtLCBidXQg
bm8gYnVpbGQgaXNzdWVzLg0KPg0KPiBJJ20gbm90IHN1cmUgdGhhdCBldmVyeXRoaW5nIGlzIHRl
c3RlZCwgYnV0IG1vc3Qgb2YgaXQgaXMuDQoNClRoZSBYZW5TZXJ2ZXIgc3BlY2ZpbGUgbGlzdHMg
YWxsIGJ1aWxkIGFydGVmYWN0cyBzcGVjaWZpY2FsbHksIGJlY2F1c2UNCndlJ3ZlIGhhZCB0b28g
bWFueSBidWdzIHdoZXJlIHRoaW5ncyBoYXZlIHNpbGVudGx5IGRpc2FwcGVhcmVkLg0KDQpNeSB0
ZXN0aW5nIGNvbmZpcm1zIHRoYXQgbm90aGluZyBoYXMgYXBwZWFyZWQgb3IgZGlzYXBwZWFyZWQg
YXMgYSByZXN1bHQNCm9mIHRoZXNlIGNoYW5nZXMsIGFuZCB0aGUgZnVuY3Rpb25hbCBsb29rcyBw
cmV0dHkgZ29vZC7CoCAoZXhjZXB0IGZvciB0aGUNCmxhdGVzdCBzaGFkb3cgYXNzZXJ0aW9uIGZv
dW5kLCB3aGljaCB3YXMgYSByZWdyZXNzaW9uIGluIFhTQS00MTAuwqAgRml4DQppcyBpbiByZXZp
ZXcgZWxzZXdoZXJlLikNCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:34:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:34:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422712.668925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojI1a-0006Vr-4v; Fri, 14 Oct 2022 10:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422712.668925; Fri, 14 Oct 2022 10:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojI1a-0006Vk-1i; Fri, 14 Oct 2022 10:34:42 +0000
Received: by outflank-mailman (input) for mailman id 422712;
 Fri, 14 Oct 2022 10:34:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qaRP=2P=citrix.com=prvs=27923c854=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ojI1Z-0006Ve-It
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:34:41 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce029be8-4bab-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:34:40 +0200 (CEST)
Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 06:34:34 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB4944.namprd03.prod.outlook.com (2603:10b6:208:1b2::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Fri, 14 Oct
 2022 10:34:32 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::861e:b46c:1acc:c576%6]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 10:34:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce029be8-4bab-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665743679;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=xDBNWwJwiZmRteu6HzD6/WKK+M+5jJgCr/RR1pdvPWc=;
  b=UeTCT5TsfqfUyLAa/zZR/jL5AaLAz5MNz2+Tx2jBgJJLuIojfhJSPExM
   EiO7NhSyUofHw0Wnlc0+8n5H9rZp7jcJoOMZe5GnqAMT3KV9EGO3PKyYC
   Bboxq429XdoDJ75amYQhEiBvQaY5p/cjID13hhenNj2TSwf1LhNsIRSo1
   A=;
X-IronPort-RemoteIP: 104.47.70.101
X-IronPort-MID: 81844862
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:RqlUV6NG+0JkgInvrR16lsFynXyQoLVcMsEvi/4bfWQNrUp0gWNRx
 jdLXmyHPPiLM2Wketp1YYSypx8EucTRy4dlGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr5GtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eFpMFxKVVAk90/
 O0qDT0Kdjugh+fv6efuIgVsrpxLwMjDGqo64ykl5xeGSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsH8BTM/fNfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPkGrZriLy3IcjmwvDe90WFr2op8dTu0ei5mATVAEoa3KS9KzRZkmWHog3x
 1Yv0igkoLU29UerZsLgRBD+q3mB1jY8VtxKAqsF4QeC4qPO5kCSAW1sZjxcbN0rsucmSDps0
 UWG9/vyHiBmurCRTXOb95+XoCm0NCxTKnUNDQcbSSMV7t+lp5s85jrfQ9AmHKOrg9ndHTDr3
 yvMvCU4n68Uj8MAy+O851+vvt63jp3ATwpw7AOIWGugt1t9fNT8P9Xu7kXH5/FdKorfVkOGo
 HUPh8mZ6qYJEI2JkyuOBu4KGdlF+sq4DdEVunY3d7FJythn0yTLkVx4iN2mGHpUDw==
IronPort-HdrOrdr: A9a23:u5XtLK9s7honZd4S/7Fuk+FDdb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe
 ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d
 FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp
 T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK
 g=
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="81844862"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AKesxqDXvwFdTOJP/WVDkg+fUbPTt1JeiigTuBYLDOKCnKmMHsxU/QBrUX7C8RwG2asoq8eXO5YUx3Fdtc6mJij3oi0E6Hh/5ygFG5RTUWQKZvuu3T56a6tqRCo7YQalYazUT4i/jgwc3N+xC3GtKMqYKQ97AH+jveIvgxOAWwORFeQ2AovU+Cl/3QTJXSQblraBK26QsOoD6v7Vk7j3sdDSz1pImMDsMvs/WtIIE1iTxPyIUQ7IGCDI1KXMSOhtEbSsE1wD0zqzGhQBPtNQV2ZQ9XU/Lflj5O/x8MnypzmQOBkm+12OV0YTl9d7wRB+X0YIKGbvKke61keRIAmIlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Al+wj885iQ4kSEujsp3hPPJiciOI+cKJD0CQ1H7TwtU=;
 b=glAjNyulStSqbQZmsI8zmeOQNHilhqzCjRefN7jBLdvFfww3sXKf6H4tsjvpvMTlA/vBHuQKAqUPz85RhHCKjzxEAMgX9AEUuAeoeYUpKhDvtfedo2LLPhEIqeb6k1dkXi8nGQ3JUg7r68CjmF6wUms8CjET+tJf6XhOS2LBkQoiMXFK6mjMkroB8nMM3i5Fn79V9b6lB51qLibkutC46+c9Wyf5ti6lqTKHFfo4HaD/+O2RIBvxA9Z0l1gOuFm6iEn7Y+uJ3RYRp66QSYTAitmtC0KhBgyc5lHVCtbMvsx60J5c//GfG5xfMHbNizE6zLGHv+wzBz4N3EZazZWRnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Al+wj885iQ4kSEujsp3hPPJiciOI+cKJD0CQ1H7TwtU=;
 b=GUvWKC82rjHx99fnkGDeufF5viEiYrIV4BHacg3EGEAuMBFzmBm5VEFb04+nUF2OVEf6sKTxg5dSjpqzAAVbSgmkzV+TEf8x1tdp3UE2vGWEi3Z1kVsz3+ksKShGOz1SykJiQGmche+dwPD6sloh5I3LMhi/l5HGRtUU3R6n2WY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Fri, 14 Oct 2022 12:34:28 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Henry.Wang@arm.com,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 3/4] amd/ssbd: remove hypervisor SSBD selection
Message-ID: <Y0k7NCFbZuMCHc/6@Air-de-Roger>
References: <20221011160245.56735-1-roger.pau@citrix.com>
 <20221011160245.56735-4-roger.pau@citrix.com>
 <ce274b68-4f9b-0b1a-6b1d-faf002ecbb54@suse.com>
 <Y0gXnD4jsyIp2kKb@Air-de-Roger>
 <870d5cf9-26f7-f4c7-4fa2-5a18bfa163bd@suse.com>
 <Y0kbN+Zp6F2kBFGz@Air-de-Roger>
 <5220f340-5380-0b77-86bb-323898efc208@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5220f340-5380-0b77-86bb-323898efc208@suse.com>
X-ClientProxiedBy: LO2P265CA0298.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a5::22) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB4944:EE_
X-MS-Office365-Filtering-Correlation-Id: bb3b76b1-62b8-46e8-35df-08daadcfae2a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3ISisqUHeiFizerrQ52Hvumw0FIYPvT2m0a5a7/f/RMFAip63rDgOg7/NMM42yMKIoRHVIdcKJvMIp2Z1suEMOYo3d7KY1g6UPT5dNd30jTAUbdexCBlVdZR6UmlCoOxHszd505+upoKX8+coKjTRWcIW+tdN6k8yub1GoP+hPbMHf9DkoSABVpxaf/g/tkZPMRQXF+A1j+eQnhk3nvRtBZhd0P/rgi4WvCHuXkppvVrLocyDUJJX7cXyDDZxz5CEimcXXv1TuS1XAHd6df+WIe2RZNqqC5gmviQ2OVmyuQyF6uN263EQwNlTnZEljmSsT6Zd2TsZ0Wp5ZB4nRothqeuE6h57qBSa/Y2em8Sv8bQldNJMfPIILK/QoYJ+4lYXPKyAHhhIdObk7AM5iIMbX2px1nGh8hwlgrY3MdhoEph3/yaDkV7sVtFRbKIsMm1o01btu5yBxa+IEU46L6wbTaFoUpfKQlxq6rK68Dn19PRHlLjKQmXcnpd7nDxvGuwhQwvKVZXajMWWXG7eXER+6yBPEgxbVwFm8X6SfFl8BlMITPxmUcyYLwqaPaa4I51tjxY+15kxMjrp/GNrihPvYn15gHlhwbZ1EVPq3uM/RsY6YmjqSy9RW8XtXYv+MTGtNtc8Wo/biZWLq4cxO9WepkVLUUsuKiEfuRbpKf8Ts3504Tfp6oAKmn61/HXEpwbHL7feNzsAUjb01MfU39rTEzI/n6EpY3R/vIa5/vFOykQRUcMlq2N07rNbFhlz270
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(86362001)(8936002)(85182001)(6506007)(6666004)(5660300002)(2906002)(478600001)(186003)(33716001)(83380400001)(54906003)(6916009)(4326008)(6486002)(26005)(53546011)(66556008)(66946007)(66476007)(8676002)(41300700001)(82960400001)(38100700002)(316002)(9686003)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VFhIbCsxdXRPZ1k4MGJnRSs4blNKWG9kMEtrUDAxVTdGeXNFQ1VGWGUvQjB0?=
 =?utf-8?B?dngwMnY2dGNNT3orcXEwaGNQSTBvQUJYME5sbDFDTDRZeEV3S1owejFxeGRx?=
 =?utf-8?B?NjZjeUVZcVQxc2xsUlROVUg1TmNTU2drcTR4cmZBbS84cGVwN1pVNVhWeFNN?=
 =?utf-8?B?aWxacm9JclV1bWx0NS9jMGphSDVmV3hPREYyQjZjZSt1U0puWjVqNnBPOG9s?=
 =?utf-8?B?MEkxWWFMQktYTTczN212MDJ5cUI5TnNScWptbGtDUHM0c1FGNzZmM3JXL1BB?=
 =?utf-8?B?YUtOV3BpNVU0d0JzZTdqYkZ6VFJ0aWhQekZyQ0R4dUJreXdyUUlFdFJjOHpk?=
 =?utf-8?B?SnpxRXN6UGcwaWc0d1JnK2dHZEZUSHB1MUI5bVhaUVJWazh6ZTFBaGs3YkpL?=
 =?utf-8?B?dHQ1N2lkbDRlZndpMDNnTzNQVGVjRDRMVnhwSnpwYjVSd2MvRmFhbzFsZXRF?=
 =?utf-8?B?czEzck1kUXR4QnhxYjVFQUorZWIzanZCZm9sQUlkbVZRVkthQVNYcy9tRG5V?=
 =?utf-8?B?V3Q0K3BQenNUVmp4YUxtaDFBTkwxK2F4YUt3QmdWR2x5a0l3L1owV0VDNDhq?=
 =?utf-8?B?am9jaUlKRHdXWjh6cVg5SjkrMVQyRWhKQXlVdXRVNHRBdHBJaGVWa1JvQ0RK?=
 =?utf-8?B?czZSdU80em03bzF3Y3RycmpyTEJoeUM5bDVyT2RuNU8vZUQ3VERmNk92WTZi?=
 =?utf-8?B?bmswNmViVytzUGdEaWdBSnZkUlFGM3d6bSs5VTFWazM3cS9XclVjZi9uSzds?=
 =?utf-8?B?SUh3UkdFSXRGeE5vbkZObzhMbmJpclFzMVhMVkFVQktnV1JkWFNkNjlmbHJX?=
 =?utf-8?B?NkpmV3ZLZW53SjdwKzQzUGRacHM1WVAwRTdNQUtuZVhMemttT1h4YUx5Q3JS?=
 =?utf-8?B?QytOYm92clVlRytmRUV4UFdjRWRKMUJzREx2TmhWTDNmcDc3N29uWnN0V3o2?=
 =?utf-8?B?THdkV1JLUWJSNnh3a1J0OStmaWVSVXFyS2QzUk9xQzIrTkVmR3dEMzY0RzYx?=
 =?utf-8?B?QkRmSld4VXc2dzhJUFpSSGxrckdWcTFlQnF6STY4Z1hpYzJhNWJaOVRoa1Ft?=
 =?utf-8?B?Ry9xVXNoSVRJUzQ5OEVyVmIzcEtKVytRTnJ1U0tTc2VkUjlYcHl2ek9ZaHll?=
 =?utf-8?B?UU5pSjVQOFNVUFI4a2lueUNaQmRvT1gvamdLYVNJeWdTbkE1cytkcDBiajlw?=
 =?utf-8?B?c0pRUmh6UWh3WlR0TG1ld09Jb3MxRWI0cWdvZkZIaVJvMjFOaHBhSmJYMjRC?=
 =?utf-8?B?M29DY1NOOWZFbnhJZi96RENGa2ZFRVJqa05vT1NhRXdvNi9zcmhBL01OeDdV?=
 =?utf-8?B?RE8rd0VNUlFud0QydTMxOTFUd3dMWndQV1RLNVI4ZXRFdDBEVG44cVVIVWVS?=
 =?utf-8?B?S3NjdFlrbkNIKzRIblBaZ05CWkJmeThFRys4Zkpla0lQc2lNZy9Wcno0aEEw?=
 =?utf-8?B?bzYyZWNONjE1Y0dTcHRMNld3TDY2cTg0SU9ydUZqdkRTNTVwSHRRdmJoRy8w?=
 =?utf-8?B?MzVzK2lML0lBczMxYzVudEpmdG5RczlKSFhacDlTODYxaWdFT2k1MTB4clJI?=
 =?utf-8?B?ZFQvd0s5a3RqcVcxRnlvankvMHhES2hzayt3VjFBaVBzenFRMCtHeUlJdVhT?=
 =?utf-8?B?L0dBY0tQYS8xaFp0QWRqMUFUOStDREFUeXNVZDE2NlQ5VXFUOFJLZlA4MjU3?=
 =?utf-8?B?NjBzWnI1bWVQdlZNWitSanRPQzUrM00vR2NqalJnSmxGUEtzRFBqZGRvSVRW?=
 =?utf-8?B?RDIrazFTNEtraGZvb2dwd09SZlpxc0hJYVM4ajBHNnFWVjk1aURxMVhvdEl3?=
 =?utf-8?B?RDV5YkxVaG9CNXIvQUdPU0dHdVA3OC9FNzdUWEFTbFVKbjFFZ1VUQzVLdE5k?=
 =?utf-8?B?Vm5ndXJQcUNMb2EzTHB3L25laW9EckY5N2M1bVFMNFIrRjUwc1dmUE8vRXJy?=
 =?utf-8?B?dzNubkx3T2M2TmZpNDVzblc4ZzNZa1J4V1FqMFREdmZrMGdsaEo2TzBJcFpI?=
 =?utf-8?B?WisrVzlKcGJKMHdNREt2T2ppcmFCTW9JL2cxSXJVakpjcDd1dUtScTBhOWJo?=
 =?utf-8?B?Vk96VDlGd3YvU1NFT0RYWG5XTzdRUEpjZG5paHlORVQrUGNpM2hCdXBxMXBw?=
 =?utf-8?B?K004cHZHdFp5Z0w1eFgyZTMva3ZaY0VVd2RISURpRTlsbSs5MXdjQ0ROMHh1?=
 =?utf-8?B?SGc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb3b76b1-62b8-46e8-35df-08daadcfae2a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:34:32.2415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 47Um99FYxvmGC2KkX3BYn7WdJufkvZhNxKj22ENx6kykxj9lgRZOVW6bOTx2afhVy7/mEUE42MtbKL+Xsbku9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4944

On Fri, Oct 14, 2022 at 11:00:10AM +0200, Jan Beulich wrote:
> On 14.10.2022 10:17, Roger Pau Monné wrote:
> > On Thu, Oct 13, 2022 at 04:20:45PM +0200, Jan Beulich wrote:
> >> On 13.10.2022 15:50, Roger Pau Monné wrote:
> >>> On Wed, Oct 12, 2022 at 10:30:45AM +0200, Jan Beulich wrote:
> >>>> On 11.10.2022 18:02, Roger Pau Monne wrote:
> >>>>> @@ -2365,12 +2365,6 @@ On hardware supporting STIBP (Single Thread Indirect Branch Predictors), the
> >>>>>  By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
> >>>>>  when hardware hints recommend using it as a blanket setting.
> >>>>>  
> >>>>> -On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
> >>>>> -option can be used to force or prevent Xen using the feature itself.
> >>>>
> >>>> Why would we want to take away this level of control? Shouldn't we turn this
> >>>> on while in Xen if so requested? Which would then either mean enabling it on
> >>>> VMEXIT if a guest has it off, or running with it turned on using the OR of
> >>>> guest and host settings.
> >>>
> >>> Right, but then we need to context switch the value on vm{entry,exit}
> >>> which is problematic.  I could move the context switch code code out
> >>> of the GIF=0 region, and assume that NMIs executing with the guest
> >>> selection of SSBD are OK.
> >>>
> >>> Alternatively setting ssbd= on the command line could be taken as a
> >>> value to enforce for the whole system and prevent guest attempts to
> >>> change it, not exposing VIRT_SSBD, AMD_SSBD or SSBD (haven't
> >>> looked at whether not exposing the SSBD CPUID related to
> >>> SPEC_CTRL.SSBD will have impact on other features).
> >>
> >> That would be my preference (albeit I'm uncertain about the "not exposing"
> >> part, as we don't want to misguide guests into thinking they're unsafe or
> >> can't guarantee safety when requested by user mode code), but ...
> > 
> > For ssbd=1 we could expose the SSBD controls, as the guest trying to
> > turn it off would have no effect and it would still be protected.
> > 
> > OTOH if the user sets ssbd=0 on the command line then exposing the
> > SSBD controls to the guest would be misleading, as the guest setting
> > SSBD will have no effect and thus it won't be protected when it thinks
> > it is.
> 
> Irrespective of your subsequent reply: Unlike "cpuid=no-ssbd",
> "spec-ctrl=no-ssbd" ought to affect only Xen itself:
> 
> "On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
>  option can be used to force or prevent Xen using the feature itself."

So that brings us back to having to context switch SSBD on guest entry
and exit, and we could only do the SSBD switch at context switch if no
ssbd= option is used.

That would also prevent us from dropping the synthetic feature leaf.

I will wait for Andrews opinion on this one, I would like to make sure
we have reached consensus before I send a new version.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:38:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:38:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422718.668936 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojI5T-0007Fe-Mb; Fri, 14 Oct 2022 10:38:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422718.668936; Fri, 14 Oct 2022 10:38:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojI5T-0007FX-JM; Fri, 14 Oct 2022 10:38:43 +0000
Received: by outflank-mailman (input) for mailman id 422718;
 Fri, 14 Oct 2022 10:38:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojI5S-0007FR-FK
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:38:42 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e65f1dd-4bac-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 12:38:41 +0200 (CEST)
Received: from FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14)
 by DU0PR08MB9438.eurprd08.prod.outlook.com (2603:10a6:10:42e::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.30; Fri, 14 Oct
 2022 10:38:38 +0000
Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4b:cafe::af) by FR3P281CA0067.outlook.office365.com
 (2603:10a6:d10:4b::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.6 via Frontend
 Transport; Fri, 14 Oct 2022 10:38:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 10:38:37 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Fri, 14 Oct 2022 10:38:37 +0000
Received: from 9ed0489979c6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 032564F8-BB43-45C9-B5DC-31E7B258416A.1; 
 Fri, 14 Oct 2022 10:38:31 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ed0489979c6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 10:38:31 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9195.eurprd08.prod.outlook.com (2603:10a6:20b:57f::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:38:29 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 10:38:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e65f1dd-4bac-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=J2HKeOxmrYKsvTCikh9EMN/jW4mh4LRhp9ybBoyhvV2xkkqJtV+NnV58MNFY1vwp4MGdlwM9Q0uPg50WCX8sgujUSFhEtuWSaGCNni3Tbtp3MOYW9fe6MQ6KTy9QUq42OA6EQl5k8HtMA9deGliP0EDorwzhFw3KJzKA8Zki9ZHnokje8Hl2VEW/QKfQuwUWNkO2whZPUWizo9/Dec7muSPH54Cky1eMSKhDfCCoLN7nqIQ/tKde3aaXV5YHnWfS59q8a8r7YhuwD4BKM4eSFW4pErY2eVFXjK/wH1cPy+VrdEKx5gHLnCZjiiBqEJmq97aTyfx6fs/HkMAz1um6hA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mlL8+1BvEfMN6YB6D3qMgFFOOzmaFnpxC4LRI1A/U/k=;
 b=L+a01MSDQe16Jmk/Mp0I5x2+EhvXqSqHwZUkMq/SNe18q2EdTmS5LpGxXXoXjZg7+wHhmlOhSjHjRP1be5f8kvXFvO15fdF0wzbhPB99lhgmPEjxxoDlm1tnn+s/IPm+czPbSXS97WoyjKD4QZe00yayAU1xDwz70g7R+Kxsis2BW5NP9XechUm6Qre7hjxsi2XB3ZInBRt8ICteRGTkdgQbnZWyOK1oKgT3+Dd3lATjwQB+D2uJRIPIqDpUMOfwQ/N3wxsc2L4JUIUXUHXMvVqrVgq4/7S+SAmeODM7eZ/woWYyhYeWLdeCXxtH5dR9TZmLDUgP0kxfo36URXQMzA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mlL8+1BvEfMN6YB6D3qMgFFOOzmaFnpxC4LRI1A/U/k=;
 b=YfCtSkTn0VRqi6ufx8oMa1yzy+t0JChHd1fcGb/woDL4zrRv6n7lJBWHbzufhZwGce727N/KPppD6kq1TUuEJN6rltrdyqH5lwOk1etiJQwKALlmcD/zdgHKmZ7f3/t4ILVhpIgpprEkBtCtpC9XtTYk85vlg+8TBiHumnsyroo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=THBJsdJ+Ur/JT9IqWuJ5225KIR5RadCENEH1NXR+aT0h5hNefRgK9Vc/RP5tLTIgw/b/HN4XCI/ZsPCHwsQzmGA6j9giiPbC+mXRBudO80A0auqe4CQ6lfsXVpVrYa7uqdlL/KK20rUegIHsh96Gw6dSIRk1Z8bB8la1VCcuWl261FAMnM1gX249JOIGYtbXnQ+pS05Wamed/zpjt5mgyEklZgwxIH2Q90hpC6W1nkskEQbbBn8JcD3yV2K14xgzD5lsSTw5yiLyln+WhwPrPlqMP5TA+rIoTohYUexFZTK5N8pqilp1s8yenfH0qRe3sQfmCChQJEnZA0SRopkbeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mlL8+1BvEfMN6YB6D3qMgFFOOzmaFnpxC4LRI1A/U/k=;
 b=I/p4BvycdOJFq8xPLh+YkZiF3+H6/DF8/JQa2HjIn/lSMNV3fKHANj7Mvd+pkshsY6XqCOMuRf6xvr5e6hMxlrIl4QpXr/3URPmsWarjTpnxWWju0iLyY+MYh9vHXsVQt+qMMCVgTXgptRSYxQmV8rCMUXjBlroZ4f1Hz2cUL6ELJCGMET0j85b5Sh1qyVydJS9SAVYY+tAuFKbz//ze2Dfn/XjRhrzRfkqktb+yKv9HoiZDW2bUquTkcr8YaqE9lOFyMr6AnR6qjnn/kWp8fsrzIxiHOzbSMltl2AG8/vwsB1XtDAr48WDOpV6EeAU6qV+9k9XQD9f86WDbcFQ2aQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mlL8+1BvEfMN6YB6D3qMgFFOOzmaFnpxC4LRI1A/U/k=;
 b=YfCtSkTn0VRqi6ufx8oMa1yzy+t0JChHd1fcGb/woDL4zrRv6n7lJBWHbzufhZwGce727N/KPppD6kq1TUuEJN6rltrdyqH5lwOk1etiJQwKALlmcD/zdgHKmZ7f3/t4ILVhpIgpprEkBtCtpC9XtTYk85vlg+8TBiHumnsyroo=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NnUwAgAAAd5CAAA4NgIAAAPkw
Date: Fri, 14 Oct 2022 10:38:29 +0000
Message-ID:
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
In-Reply-To: <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 2E6B81E99331B344897E250B2EC5A775.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9195:EE_|VE1EUR03FT030:EE_|DU0PR08MB9438:EE_
X-MS-Office365-Filtering-Correlation-Id: 0a579f33-f7cf-4e02-5648-08daadd040d3
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RBiDjzO3Sk54rJa31Mqer3zRl+8Wgz9uykAV19FpKEqlzoT1hwhpj8Li5nxJiDzBFyxPWLjBzITA0qxhdnl/KyMAuU08ETnUVuhIIqpHjXAm4ok2ScfAniiZZ2/b6qWYr5WHai1fqmCm3idNyr8VnN1N6aMvAizW3LfrAUEt/ThSOU9Nhuolgovhdp0JP5eaglSRq85ynqCL5J94C3TcJj1rg6Uw2NA9+SVvgU4jjVbav38lofRVDm7mX742c5q6M3xbpkvW+JuF0mzcdwtogQwNxskSqqkJTl7e6Q+f9cPcujkOlKO10U36sRfaDvDwWWsyqf6QUAIb1PuXhrs8MUhsv54hafHwVgcjLyTBYhihnhKrlmm878qciIpEZNCPPT4plYG0ga18ksYjozNpJ8ONP4SfPMFoQRVA8ezWIlg/jAj5DZg39zo/yhjh0gp+E0Mpl9aS98QhWwddHvDCea5mp/0T2AvS5cYwYY5e/N3ssAu1lVZtPscVGNVAHk8ju9gRr2crRnjWeJxEhptpQGUicZn9i7M8j6dxkHPXuf3dBe5FVmjmcbbLNlEe6MbFFjZJpmZp0ub1uHmTs8RB5qRqvgsBWvN4XiSeR7gvj8xXg5lxarGzfMuu7f8oWrUUzJQYZHJYVO3ra8aQTn+paXxXRBxrQW4hV62Qc8cH1KMIsnzuZG8RBOSeEC4HJamEZf5rY4JExNQj5KWFteBnPYwKfJ6VZy8LUanswZuk3+ymoJq5ofIVbVmlMyYkGLZNRaI8ZoTZnLcMMdYaIl3GVg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(451199015)(478600001)(54906003)(316002)(110136005)(71200400001)(66476007)(64756008)(66556008)(66446008)(8676002)(66946007)(4326008)(76116006)(186003)(52536014)(9686003)(26005)(8936002)(41300700001)(5660300002)(122000001)(6506007)(7696005)(2906002)(38100700002)(83380400001)(55016003)(38070700005)(33656002)(86362001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9195
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	89378802-0091-4de4-7f75-08daadd03bee
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5Qy1Fv4PfS/mghpkAVWgljTto5VVR3NBujWsTWcvdkiq8hX3fzoWfswHY6pb4XZ4/GTeA/ntQnA7toByRkn3gw1cxnlx1Q9PkuiZv0PrshLeP3eD/s1I5Eg3GB7gDxhivLPBErnbt/YZ7LctGlXZF+qDJkz4z31LHraBBet+lZDPmkYw0vDt+tMHpMsAg/KcE55oCfFHVNKnPQJ/B+iom7Xne3JXIaSCGOdbLp3fYBlrVKilHS1CWwdxxmrWyQ1K0pTn/qNMhjIAsa2XJDod0qn/UYYKSASDaW8VTO4OVQg1fUTD75fSczs39EjDgx55BBl8N3k4K6oH3slvZAbP5E550GfVKRS4VRgoGHQmJEm8Gv1V7FQEupBDOZ4ugw5+P1/r5lQ4EXZ2TPLHF8qjDATWuruhc/1LzEq3YHGm5fbZZawnGps6pGqlf9nCWsmGtXEgDS/f1y5kFgQRxLDv0ItzADYgoUTNzWk2fXeyFQP6Y3brb40P3Kz789PTwgT8w3V7RP1eMkJs0717mll/XAwZT54F3Y3u4mWH9rDuC8NFLIzbLWLOwz5hgKb71D+Wbk41/pTBDeBSS5x5g7wci/U5AfZIiOCU2c9tAYzPVajsrrg4JZVqJZCKX6Y4K6r6JqBlCdRsWIQguwNCPi9yBZFZxYaF/iz96zO0RsCk2MI7DZtyE+SBGQz8MYx0Vr8tpnk0mDUJSIdo3NV7pfHc9rXQ20jKUnTXpv0Hd2BSOSEiKe6meGhzKoG+Z8ZTDlSBRz9+YbWGYGEdxkW1XJDZ9A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(82740400003)(36860700001)(81166007)(356005)(40460700003)(33656002)(41300700001)(110136005)(186003)(478600001)(26005)(8936002)(55016003)(2906002)(4326008)(70206006)(316002)(5660300002)(54906003)(70586007)(9686003)(83380400001)(86362001)(7696005)(336012)(6506007)(40480700001)(52536014)(47076005)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:38:37.7648
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a579f33-f7cf-4e02-5648-08daadd040d3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9438

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIHhlbi9h
cm06IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4gYXJjaF9kb21h
aW5fY3JlYXRlKCkNCj4gPj4+ICsgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsN
Cj4gPj4+ICsgICAgcmMgPSBwMm1fc2V0X2FsbG9jYXRpb24oZCwgMTYsIE5VTEwpOw0KPiA+Pj4g
KyAgICBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7DQo+ID4+PiArICAgIGlmICgg
cmMgIT0gMCApDQo+ID4+PiArICAgICAgICBnb3RvIGZhaWw7DQo+ID4+DQo+ID4+IFB1dHRpbmcg
dGhpcyBsZXZlbCBvZiBrbm93bGVkZ2UgaGVyZSBmZWVscyBsaWtlIGEgbGF5ZXJpbmcgdmlvbGF0
aW9uIHRvDQo+ID4+IG1lLiBNeSBmaXJzdCBzdWdnZXN0aW9uIHdvdWxkIGJlIHRvIG1vdmUgdGhp
cyBjYWxsIHNvbWV3aGVyZSB1bmRlcg0KPiA+PiBwMm1faW5pdCgpLg0KPiA+DQo+ID4gVGhhdCBp
cyBkZWZpbml0ZWx5IHBvc3NpYmxlLiBJZiBKdWxpZW4gb3Igb3RoZXIgQXJtIG1haW50YWluZXJz
IGFyZSBub3QNCj4gPiBhZ2FpbnN0IHRoYXQgSSBhbSBoYXBweSB0byBtb3ZlIHRoaXMgdG8gcDJt
X2luaXQoKSBpbiB2My4NCj4gSSB1bmRlcnN0YW5kIGJvdGggb2YgSmFuIGFuZCB5b3VyIGNvbmNl
cm4uIEkgZG9uJ3QgcmVhbGx5IGhhdmUgYSBzdHJvbmcNCj4gb3BpbmlvbiBlaXRoZXIgd2F5Lg0K
PiANCj4gWW91IGFyZSB0aGUgYXV0aG9yIG9mIHRoZSBwYXRjaCwgc28gSSB3aWxsIGxldCB5b3Ug
Y2hvc2UuDQoNClRoZW4gcDJtX2luaXQoKSwganVzdCB3YW50IHRvIG1ha2UgZXZlcnlvbmUgaGFw
cHkgOikpKQ0KDQo+IA0KPiA+Pj4gKyAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9w
YWdlcyAhPSAwICkNCj4gPj4+ICsgICAgew0KPiA+Pj4gKyAgICAgICAgc3Bpbl9sb2NrKCZkLT5h
cmNoLnBhZ2luZy5sb2NrKTsNCj4gPj4+ICsgICAgICAgIHAybV9zZXRfYWxsb2NhdGlvbihkLCAw
LCBOVUxMKTsNCj4gPj4+ICsgICAgICAgIHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2Nr
KTsNCj4gPj4+ICsgICAgICAgIEFTU0VSVChkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMg
PT0gMCk7DQo+ID4+PiArICAgIH0NCj4gPj4NCj4gPj4gSXMgaXQgaW50ZW50aW9uYWwgdG8gbGFy
Z2VseSBvcGVuLWNvZGUgcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oKSBoZXJlPw0KPiA+DQo+ID4g
WWVzLCBBRkFJQ1QgcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oKSBpcyBwcmVlbXB0aWJsZSBhbmQg
d2UgZG9uJ3Qgd2FudA0KPiA+IGFueSBwcmVlbXB0aW9uIGhlcmUuDQo+IA0KPiBMaWtlIEphbiwg
SSB3b3VsZCBwcmVmZXIgaWYgd2UgY2FuIGF2b2lkIHRoZSBkdXBsaWNhdGlvbi4gVGhlIGxvb3AN
Cj4gc3VnZ2VzdGVkIGJ5IEphbiBzaG91bGQgd29yay4NCg0KSSBhbSBhIGxpdHRsZSBiaXQgd29y
cmllZCBhYm91dCB0aGUgLUVOT01FTSwgaWYgLUVOT01FTSBpcw0KcmV0dXJuZWQgZnJvbSBwMm1f
dGVhcmRvd25fYWxsb2NhdGlvbihkKSwgSSB0aGluayB3ZSBhcmUgaW4NCnRoZSBpbmZpbml0ZSBs
b29wLCBvciBkaWQgSSBtaXNzIHVuZGVyc3Rvb2QgdGhlIGxvb3AgdGhhdCBKYW4gcmVmZXJyZWQN
CnRvPw0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0K
PiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:40:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:40:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422724.668947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojI6i-0007rS-4c; Fri, 14 Oct 2022 10:40:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422724.668947; Fri, 14 Oct 2022 10:40:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojI6i-0007rL-1p; Fri, 14 Oct 2022 10:40:00 +0000
Received: by outflank-mailman (input) for mailman id 422724;
 Fri, 14 Oct 2022 10:39:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojI6h-0007rD-3i
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:39:59 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130055.outbound.protection.outlook.com [40.107.13.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c528136-4bac-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 12:39:58 +0200 (CEST)
Received: from AS9PR04CA0146.eurprd04.prod.outlook.com (2603:10a6:20b:48a::19)
 by AM8PR08MB5745.eurprd08.prod.outlook.com (2603:10a6:20b:1c5::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 10:39:52 +0000
Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:48a:cafe::79) by AS9PR04CA0146.outlook.office365.com
 (2603:10a6:20b:48a::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Fri, 14 Oct 2022 10:39:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 10:39:52 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Fri, 14 Oct 2022 10:39:52 +0000
Received: from 4da4eab61a33.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F1E8F0F1-6A94-480D-BC08-FC4E0E5C8C26.1; 
 Fri, 14 Oct 2022 10:39:46 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4da4eab61a33.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 10:39:46 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB8650.eurprd08.prod.outlook.com (2603:10a6:10:3d2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 14 Oct
 2022 10:39:40 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 10:39:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c528136-4bac-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=kNUuJUaPNN/78oi/aInYMdhUKrxiWqiooMrK1TKya4ibXj1QzdzyUs0g1GCO8vw6qe6qt54P2QHEQAs0wqN/Q7R4+z/JomZ2+Jk9KQTDyfdCuKqI53FJT4zVXlIxF+ns1ZwxT6STlrCyGdDzKcioNXfT7UR0xMNs5XX3RcubgIaEKirq5zHr+VSH6J+cCvsbA4hTWupLTxEfVELHApKVldQAUzPRCD0cx5aCeow24nI6Kqf94YSZnv6//J4V2iuTztdEDIG/vZLM0fe2fkS6GZaKY/LKGqscZVrsBhbq1C4NWXQKyMFyEzd48WBtcVSng7Sv2Xkdj6d1XZNyGm/G6A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U7E1wiQH65i3X5Gff51xUzVsC7jolGBG4OLTRZecPec=;
 b=R9ClbrliImXOqgxRWW0461Q/RtSkSeVWwfdMLATV53pVq6mMNAKCx4fwqg1s3/80KtWqB8xGd27yVl/TtD628+SrZsTM0c4XZd11sJ8/eTzs9qs/hDHDcvxzEi48mOs+JY6IuXRJwiXFuuU2iN56oynfTOIgRnoVStQRnQokfwhsWLyremBrxLtH/JcapGKTOBXZDBXELuqkd+58IWr331L32HMz5ZOKD9XSPyqZ64KhfPFg/+I23CQAunHaTRiwHX6WtJBPVVbyqHSWKIEISqGU26jHiaOGbDBD/qEzgJr39trumFp8T4+gOMhrGOLsB8QJTxfbZ/wp1OjteqWzDg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U7E1wiQH65i3X5Gff51xUzVsC7jolGBG4OLTRZecPec=;
 b=ukhPdD/ItOVWboBiPDE427+8qOLmh5ESK4eEpy1nMEOA4MiGnUoH2oLNw3PjwHAtP0V61kkOVbuYdBTlq/jQFhyq8VZefygtaVNU3SU+QXsRscx1FH/+rj/iZQiajWccn4ASf53lmw56adWYUHo9qLNgNv21RG0KJSAJKGsG0K4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eKrBpG0Nh6k8uOekRYeiKR2DGXVFMlYXIU5XIFHWs68gZ2CUZOrj7uhlV4ofLBQVmMMnsi0d1lK13ia3r7z7v4ueKcRAhhWHPioC2TqAJ41lcT0QAK/p8iKcxgaeP1Bn8Z6iMetPpJqOGzvDK87NGTlfu/urOIeBTABoz6fuqWgZKu2O+irQ/m5yvnbNVczd89VMdetE7Cn1t6Z32abmV3nm3RwMiG+5+p40tWt11i3AkXeYG2SU6oUF6MxTf0FYl6U6dmgZ/x9qTrZTLIOU2ZzT4J813Vq5yFQhh4BgVOZgzHf/kwNF235FDZo6KMY7InLdGKfjFVbopdMxLV2u6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U7E1wiQH65i3X5Gff51xUzVsC7jolGBG4OLTRZecPec=;
 b=gNMFOJSq9ojysedR6CruILPPYSfIQXuARLN5Ch8pcbYoV9b0QQIJUsOlrEH1RyF4J1fkWb3zjZaQQlCsdC+25BPq9+zXvkkSKMvGx36pDAgJxjQCgDMMrl+RZtqznrBFqWk4vsE7S8+mwPJhMpq+9jg2aYY5sz7eQ28psPPfDz06eLSooXHL6hFniqhiaiJjYSez6iooeOxwzL6m6KPD8xWC2ghVWDLL5TKp/MQKJm17Mn4GdEBzrftpzDRitgxPHQSnrmn2YHgk2RBgv7C7+cT7AoTdXm91op+96EnbVoLe8mEjkAHuze5wbA186wvpoGdSte+MdRlrFs/v5fp+lg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U7E1wiQH65i3X5Gff51xUzVsC7jolGBG4OLTRZecPec=;
 b=ukhPdD/ItOVWboBiPDE427+8qOLmh5ESK4eEpy1nMEOA4MiGnUoH2oLNw3PjwHAtP0V61kkOVbuYdBTlq/jQFhyq8VZefygtaVNU3SU+QXsRscx1FH/+rj/iZQiajWccn4ASf53lmw56adWYUHo9qLNgNv21RG0KJSAJKGsG0K4=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Anthony Perard
	<anthony.perard@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement,
 toward non-recursive makefiles
Thread-Topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Thread-Index: AQHY3wSf1tDccsob1U2UzC8OPggTyq4MneqAgADO4WCAAECRgIAABO4AgAACA/A=
Date: Fri, 14 Oct 2022 10:39:41 +0000
Message-ID:
 <AS8PR08MB79919BF19B6FD82FAA7B320F92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <381f1ae6-d539-ad52-79da-e44e9dfd5066@citrix.com>
 <AS8PR08MB79916265D28F1533ECC538F992249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <Y0k2cQu8a3sHKSkf@perard.uk.xensource.com>
 <0faa9a33-e3a2-1a8b-b0a5-581a14175c2e@citrix.com>
In-Reply-To: <0faa9a33-e3a2-1a8b-b0a5-581a14175c2e@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: D0CED4A2F3CA7843A44BC707FD185EA8.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB8650:EE_|AM7EUR03FT020:EE_|AM8PR08MB5745:EE_
X-MS-Office365-Filtering-Correlation-Id: 1f06e856-a8ff-4ae0-2cec-08daadd06d3d
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WOiRK/WLsesmBNf0Ylg4IGSlMNxSvTjigL/obd1zsaD3hNFKVn6JcGqf6IemwfmoyZe7GVo38FA5SDplwnF3EM2kJgjB8WD77w+tUZxCS9SWay88AiRiONcxS4W5e05j8NV4Elf3iMafukN2Z9lM7W360ogK9myVmje9rbA+BKPbp4u25EEXPG9BQ91NkIOOwlC0fGTj+wxhMhCMtBWZwWk54lRAWtSuQQxG7wsEB4x58dJuvB2MwrJ0g1h1cW0URLeQjpK4T5yeMndiRl2vHCKAqCJkUxtIigVjwulvVwsIDN0Nni+YG+N+qKu80g7k999bLghAQKq9AylxejJnxj0l6phCqfCmSLY02G6MwL1RHb4xKAFVj/jyOfkKTffyB7lxYH/e1PFKiXkmyozJBpTNyBI70wrHOrYu0+5Cmpv5pIYszNeEJId+CsZQLNVSUmK88Wp9pAcbCBOsgVep7XjE3xn4+e9kdu4rC/IcAhReGgCGf7VbBjsN4POd301eRAaWGwDi5jvHMKPEhR9Hj44LocTQXykgtq4HxLSpGTDiOLhauovmsa67tOvTLvfZwh3WzVA5mSxBDTUmBjUwOlGHWTP6gqVTnG8wVwHLHljSh1hRWRPB6VxPVM+1O4CwZOztPrvO4r6XSWjyA8uCWUn62QbrE2qe8OKOlg86GWO06Ujdu8LCa7ibHcTrzM/AY1cH/YYFl73z0lZ4TyFkvx3D9QuCgTUkkjjeKkH57sPeStkox7x4DX4s8/zwlLG3XJizy7A/3G1h57JC2hMQ9qFDaxCy0+iVR3p0SOCooqYX8gPGR05WkSh6XzepwRl6
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(451199015)(5660300002)(478600001)(6506007)(64756008)(316002)(66946007)(66446008)(110136005)(33656002)(66556008)(83380400001)(66476007)(186003)(41300700001)(4326008)(55016003)(38070700005)(71200400001)(8676002)(76116006)(8936002)(86362001)(7696005)(2906002)(9686003)(52536014)(26005)(122000001)(38100700002)(4744005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8650
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ae73b4df-728f-4b95-e27d-08daadd0668d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nXIui2EzavqKf7NPNNF8Jh5cAt4ZTjUe5fjE3L2CDOpWLWOyr9X5BcPH6PWB3b4VUhGFavfz++tXdrtjKx76+2Aw2zJZH/zNbDv1PHHnYpKY25jPKnJ/9/wM6aQzA7qVSPVqM3XQXdBxBKolFh8GMBjB2Myb4z+fu7eSRy49wQWBaAVMHIXiPT7L+iSjWAwvEyatOdV7hk8TFVqUStgtr++9f6Wr9fJZe6uEIcLUpBnlmp+kBZnF+qqT334BCKzmVtqkyxSvme6usVkW1lTN+a8hgBw1Rn/39GRRRoAgFIGBToiqGwrxn7B1ymYJ2+hKq3Hxwjp+eHOG3PSnqFJjRm/Ymmfd15RhwLFIN95L7ZWwFKpQ1NMyeeqLUjYYKmxDPRUqBW16q7SCX+kR4iJjHdF0vPT7fvENTGCZS9xCTtMzDIkKQ/gm1/qOO4g52DZmh2GFSS1BAm66So+0NDl//SuRgFtQNfUr73tVuAZ79uvwSP29HA8RphK5RUMrv3azXT6mAx30zf8D6dfpgr1QoQ3GzustqACBe0HAapysxfAFyKtSYE0IzjzgqQwpBwdldrZ0SEm1z3BVVeugUg/wC6ouZDiU6YpeR9lWUtwbANczLpwPFtMET729W8mfAJZ1JrDYeCkmQWEF4/u/OK41v0hegjN5wQifK08VJGsUwPXSCaS42Hrt44qHhD9MGhMXGNBgNL+lDdDoaL8deJjL4v/HSStbqzN+oKpcLHC4F/FbTkSYjt5O0Ky9BloEFjjPeWEcFQMlMJJfDgSpXxommQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(110136005)(316002)(478600001)(70206006)(8676002)(70586007)(4326008)(26005)(9686003)(6506007)(7696005)(41300700001)(33656002)(52536014)(186003)(8936002)(5660300002)(2906002)(336012)(4744005)(47076005)(83380400001)(36860700001)(82740400003)(82310400005)(356005)(55016003)(40480700001)(86362001)(81166007)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:39:52.3250
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f06e856-a8ff-4ae0-2cec-08daadd06d3d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5745

SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFuZHJl
dyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFN1YmplY3Q6IFJlOiBbWEVO
IFBBVENIIGZvci00LjE3IHY1IDAwLzE3XSBUb29sc3RhY2sgYnVpbGQgc3lzdGVtDQo+IGltcHJv
dmVtZW50LCB0b3dhcmQgbm9uLXJlY3Vyc2l2ZSBtYWtlZmlsZXMNCj4gVGhlIFhlblNlcnZlciBz
cGVjZmlsZSBsaXN0cyBhbGwgYnVpbGQgYXJ0ZWZhY3RzIHNwZWNpZmljYWxseSwgYmVjYXVzZQ0K
PiB3ZSd2ZSBoYWQgdG9vIG1hbnkgYnVncyB3aGVyZSB0aGluZ3MgaGF2ZSBzaWxlbnRseSBkaXNh
cHBlYXJlZC4NCj4gDQo+IE15IHRlc3RpbmcgY29uZmlybXMgdGhhdCBub3RoaW5nIGhhcyBhcHBl
YXJlZCBvciBkaXNhcHBlYXJlZCBhcyBhIHJlc3VsdA0KPiBvZiB0aGVzZSBjaGFuZ2VzLCBhbmQg
dGhlIGZ1bmN0aW9uYWwgbG9va3MgcHJldHR5IGdvb2QuwqAgKGV4Y2VwdCBmb3IgdGhlDQo+IGxh
dGVzdCBzaGFkb3cgYXNzZXJ0aW9uIGZvdW5kLCB3aGljaCB3YXMgYSByZWdyZXNzaW9uIGluIFhT
QS00MTAuwqAgRml4DQo+IGlzIGluIHJldmlldyBlbHNld2hlcmUuKQ0KDQpUaGlzIGlzIGdvb2Qg
dG8ga25vdy4gVGhhbmtzIGZvciB0aGUgY29uZmlybWF0aW9uLiBObyBwcm9ibGVtIGZyb20NCm15
IHNpZGUgdGhlbi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:43:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:43:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422731.668958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIA7-0000rF-Kf; Fri, 14 Oct 2022 10:43:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422731.668958; Fri, 14 Oct 2022 10:43:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIA7-0000r8-GO; Fri, 14 Oct 2022 10:43:31 +0000
Received: by outflank-mailman (input) for mailman id 422731;
 Fri, 14 Oct 2022 10:43:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojIA5-0000qy-7U
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:43:29 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 092de5b2-4bad-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:43:27 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8546.eurprd04.prod.outlook.com (2603:10a6:20b:421::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:43:25 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 10:43:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 092de5b2-4bad-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CRkQbzGNJv8jQEhzWst8HIWtN5WFPnMjqhf/1WmSt0PINXlIZICx3zuLgz9i8GQ67aB+poDzrJRRRcPrTsgak5shnYgUHoDXKpJlSshspZulQm0EJcHmx260Kl6N+BKQlCpX/ZcrRffmhZ7LqME37UZpovBPAmE9FKPTWUllffJSfhLXhiwYc/oq5CEFbpHG1BeGjSWg6W7f9KRFZHO3JqTACZgmC+txWt4jGVPr1nZhEY1QW4kovDGZb6VLxEtUFQHe7BZ+I9m8/bY8z4zQBgHLzlTSxJ32TqO0LsYtpJSwH1J8Xwtu+XvI8W7JmoxMLAddM02+ZKo7m14fE0RuUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bLkag60ksws4ZogeaVrwHFNaxn+T1aigRmkyakPW4eo=;
 b=oUKT+/brvy3dPDbqWoGx/4bnIeWYJFhsHkiaDMgFPN6IyxCCV7FAZNgHWSsgdSQ1dxYm0NsgHOFQi/EWGGdZyszxnSIOUBrakDt1uRy1RlpBXBxrUqnkLY9OsAMypgDp1fmRYw28a2S2k3OQXfTtBRxD1anRHnUssTA83a4B5YL5v+1HntyJEMJkUjBPMDier/5mq6fFiwYbFAfQho8NljLPeD3/4zkJCXHqFLElPJJ7FJ+fgomf59cl5dElbw/h/R6Zkqeq+itAk7wBejr+YHKOUKNL+TxMXdr9Jqs4YlCYTpOMQJAjS+G32xyT0jfs41XvhJm1r4FzF/CKFmXDVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bLkag60ksws4ZogeaVrwHFNaxn+T1aigRmkyakPW4eo=;
 b=zlf0bAJNQhgPSDJoWvf1R4S5Hb6HN9Bq0Tvi8vaSaUIKFRjjNNEx25w2bVw5M22SaH0u8uoZGyyQKY+fVJnGSYm7RTaxD0GSpXMFTpVM1GZLngWQ/k9TcxLKWN2T6sQ3LI7qbX/igNV8gxspVTx2QvCc9lmxdAXTmbM2Fo8nCOEhwngoU/VOL4qBhEFVmQR/RvxBd3IfGh47GkEQszVoO3pvvIm/17TpHM3nruhh3XAWr04hJQlfw8g92emF+77+msYTblgySDopbvuzz4FVEHudeIeoBwsLxyJ5InaaratXkBGSkOKXMN8cAJEOyHRFQwVUeV3WXzntfQrpr+vEng==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <54c1cfc7-cffd-6d36-6044-1d2e9945a663@suse.com>
Date: Fri, 14 Oct 2022 12:43:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 "Tim (Xen.org)" <tim@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 George Dunlap <George.Dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
 <79dc0e1a-8f8e-a05a-3db1-5163537c66e7@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <79dc0e1a-8f8e-a05a-3db1-5163537c66e7@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0093.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8546:EE_
X-MS-Office365-Filtering-Correlation-Id: b4711479-60e4-49ff-ef60-08daadd0ec5c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0H77CYLIQ5t//tGjnqrXP6xXLYWucxyczzv+yY+DfqWmlS62xJfJfVTLnCmmaxQ0Fx60tm0MSSWC+pOXo3sPmatE6rT9KFp3LSMD8zapnmetQwAqIGHTBnaCcEvQOvbSU1Kz8Vs8J2P0wPB59tB4zPK8gF7zQhbDq2fweGBtVyk2EFoVC4Q7Cs4pZtaYoYbJd6e5hoJhy3182HxTFwesA4MYEOLlfHIK/NSQo6Ff6TGSfkgdmGMYNlNsD075Qj0QhqK9MGbLKYPWukmmIkWTluDb9ZsWvQ7DsFa4jZtHdIdywQ8NLZ16RDtSuGymkSZMqH96SMJlOuB69UlRmE+zzocpbrcbJnRzcMSBFPO3cxhUoUFVwm7TN9/Gzm5/gTgvj7/KTaEExtq3JnFJ4ASKQj48lVT//naxvfJxoiWI12FXD8E/dxtw0BsDNN8WZy/JYRRKVWt2OXtAWQO9GzHIoX2xhoNq7cAvQfbIpLfIdQwsp/F1stjFAJLTa+0RLfzaKJxGjmUPLYvXspM51zqScpitWQPPUPQ9AixQlE21VqimToUkmNpKfhrkYaddIz5wDbMAQBVVGMz2T73R5bYSK1t0oSU0yFBJxBQclKp21qV1FQEcKxOcygK19JT6sFeFHkoCzHBjXG8+78pSGsvOCoAfeWOmuDmKjTPJxs8YpEJEHRfQsHhnzQXLsc6hbpmDrUnD68K8atBZtXQfvFbQp1r41gCqCHK9Je/Dl0+FcuQk/909s0t1JNt77BM/pNKNr5srkoVhbIAV7fdu0KidZ+7xfsdqxBEwHX1KVBo6U9Y=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(136003)(376002)(396003)(39860400002)(451199015)(31686004)(66899015)(36756003)(53546011)(2616005)(41300700001)(26005)(6506007)(6512007)(478600001)(6486002)(66556008)(66476007)(8676002)(4326008)(66946007)(186003)(38100700002)(86362001)(31696002)(316002)(83380400001)(8936002)(5660300002)(54906003)(6916009)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDJzR3dQMTBRdjdXVXEybmNacWtwazNGK1c3YjVxcmNPRmdjaDZqTWk3eTJr?=
 =?utf-8?B?OExLdlQwN2orV1g5UHJrenIveTcrcHhMMzJnaGVyS0gxbFVaSDM2d0sxMkJB?=
 =?utf-8?B?N3hRV0ZGeVZsSEZBQ1lKSzUrMmw1bkNvaU1nc3pTR0VmM1hnMnZUK3VXSWdt?=
 =?utf-8?B?YlgwOWUrSU5RbVg0cklSZDNEV1Y4OWN1WFlkZHd2V0xramZHVG14VFpMTFdB?=
 =?utf-8?B?RUZ1SXNLZ05ub0pBK3ovWENQa21hcGhJOVhvalIzYjVkVXZ6bncyYWljaXBr?=
 =?utf-8?B?U1hreXQzbkFaYWl5T2FEdFd4QlgwenhSbHYrTVJCTmRjYWxETUJlWkZrbU5u?=
 =?utf-8?B?ZmI5eHpOd0t6SUNDRGJKTEFrbW9rQkFZMDlRMExESmlqaTJNdmZ2elY4eEQv?=
 =?utf-8?B?MXhhNUtrdWJndHNUNXJQbG8rQzJPR21adXR5RlVsd0JMUmFLQjdCK0lUc3hL?=
 =?utf-8?B?ZmNsclo0SjcrYXNoRFV5TklnSC9abkNjenZ3cU9IejA3WkJLN0tZSmNHKzFq?=
 =?utf-8?B?YXVvcnNGa05acjlLODBzbjZTSHF5NDBjYW5JT3N4dmJwR1hoajdGL28vVjM1?=
 =?utf-8?B?ME42VzhIdFpjTGE2NXFJdWFaNk9xd3RPYmtLVWJRelo1L0liRWZTZVV2V256?=
 =?utf-8?B?QWpqRHF6TW1uL0ovL00zQW9DbkIrbmNQKzZONWc2VkpCY0xsSE5LV1lIVzZP?=
 =?utf-8?B?N25jaXYzQUdDalFBY2ZqZ2tNMVpranF6N2VLNkw0WXNOcXk1aU55NFhTWGZF?=
 =?utf-8?B?eHBhNWI2RWZYTTlYWXBZbUlHY21hR1gzNjJyS3Z3M3JJOWdkQktNTW1FaWpI?=
 =?utf-8?B?OEhYNU5hSk1Sd0o3Zng3RkFqYWVMWUxnLzlRVk5wTlcydlFERUJEVVlPaEx0?=
 =?utf-8?B?dURHT1hPaTB0NDJPaUl3NlJRUVVjL3k3eE9jYmk4RElsVXkzQzcybVUzelkz?=
 =?utf-8?B?MHg1M2hXbnY4djdscTNFRndZYXFOVU5zQTM4RmwzdTBxZUR0elFEL1dUZFI1?=
 =?utf-8?B?NXZKNzcwbDcrdDNva1UzendiWWxHOXZXVUJnMTI3dUt6MHlpZFJ2MlJnMHY3?=
 =?utf-8?B?YmNIT3FTd2FQdWR0ZDkwT1lDTGRGYit4a1dCS0Q4eFpKV1IrakdKTWJKUnlu?=
 =?utf-8?B?b0hlM1NmMnNEWXJsTFlCUkFmWWpkOFQybUxSV3NzOFVrQ3Q5WFdKZjQ1UXVZ?=
 =?utf-8?B?eXVxSXJ2T3UyRzI5UUwydzUyOGJQbXBBK0kyYURNZlFjKzBxQVB3ajA0ZFNI?=
 =?utf-8?B?NDdia3lMRnRKQUZGSWdHallLa2NEbGVkNFJOUW5mbk05MERXNFpkd3l2bkZZ?=
 =?utf-8?B?Z05sTEx6UEdSTEMvOTJFcGg1SnVleml2SzBjRHFRSGg5T2Z1Znl5SlVWTzF1?=
 =?utf-8?B?THR6RSsxeG9WeUx6aVlCU21TWTZ2YlJYbGtUeHBsdk1rc0U0YVZhWWNRM285?=
 =?utf-8?B?L2dndFQxRVh4ejRCZDc2NFJoSHZKTWR1Wkd5clZYTFpKNmFyWkxJNm1VRkk1?=
 =?utf-8?B?ZVlOVmpXTW0yRWhSL2RNRld0Rmd5R3MrT1ZmOGIvNTcvMUhZNXFWNlhtV0J4?=
 =?utf-8?B?eENxSlFtVFQ0S0w0aDFGY2R2YWhXWFFtNC9OUlljYU1MMVFCSXdJN0l4YjEw?=
 =?utf-8?B?N204Y1pjWlM5U2hVazhUa3dYKzdmcWd5dGU4WFNub2g1ajZ0L0I2UzZDbzB6?=
 =?utf-8?B?VWlobjB4d09Ic21sNXpoekVTS3RUamJheHgvWUNGR1V4ZjRZS0FGTjc5R044?=
 =?utf-8?B?Y3V0TmF2R1RnQU9sVXlRcFVvZnkyazJteWFmcnBLRGNSVUF1Umx5djFHZmhY?=
 =?utf-8?B?dVRZQUQzWWlMSFdLRytxSDNZUHU5RWNoeGp1UHdJR3Y4dVJCdWg2aFQ2dStm?=
 =?utf-8?B?d1pqVmgyV0M2SFBZblAvbmxkMWpJcVZRd2ZWVnFsNHVHdzBJUEp5RVBWOCta?=
 =?utf-8?B?UDIvUHRKU1JlbG1uTDgvbzVjWVhhazlLVEdJZVdpQlQvcGZQNkRlZFBmWlFJ?=
 =?utf-8?B?S3JqM2VrcDdaY2xXVzJKdzFrNmk3K2p0WWFueE9yOXEwYVdwWXJ1ZmU3bk5M?=
 =?utf-8?B?UDBLYXgrcjFMeGpqcUZRWVhVTExhVElLMy9sQkd1NDRUS0N4QmRKQ3hxU0NF?=
 =?utf-8?Q?aewG5l3VMO8en4VAYKv3F2Sbw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4711479-60e4-49ff-ef60-08daadd0ec5c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:43:25.7600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 88hd3op0LO8oFMj2VC9pLMm397n3amUxJFLv4mQPKjuRZb6/Z9RhcQqGp9ed/A0xscRHw0IWjMrEz7xErbKj8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8546

On 14.10.2022 12:02, Andrew Cooper wrote:
> On 14/10/2022 09:49, Jan Beulich wrote:
>> The addition of a call to shadow_blow_tables() from shadow_teardown()
>> has resulted in the "no vcpus" related assertion becoming triggerable:
>> If domain_create() fails with at least one page successfully allocated
>> in the course of shadow_enable(), or if domain_create() succeeds and
>> the domain is then killed without ever invoking XEN_DOMCTL_max_vcpus.
> 
> It warrants pointing out that are unit tests in the tree which do
> exactly this.

Can do.

>> The assertion's comment was bogus anyway: Shadow mode has been getting
>> enabled before allocation of vCPU-s for quite some time.
> 
> I agree with the principle of what you're saying, but I don't think it's
> accurate.

I'm afraid I can't derive from ...

> Shadow (vs hap) has always been part of domain create.  But we've always
> had a problem where we need to wait for a shadow op to allocate some
> shadow memory before various domain-centric operations can proceed.
> 
> As with the ARM GICv2 issues, we do want to address this and let
> domain_create() (or some continuable version of it) allocate the bare
> minimum shadow pool size, which simplifies a load of other codepaths.

... this why the statement isn't accurate. What both functions are trying
to do is reclaim pages from in-use shadows. None can exist without vCPU-s.
Yet still shadow mode has been getting enabled before vCPU-s are allocated.

>> ---
>> While in shadow_blow_tables() the option exists to simply remove the
>> assertion without adding a new conditional (the two loops simply will
>> do nothing), the same isn't true for _shadow_prealloc(): There we
>> would then trigger the ASSERT_UNREACHABLE() near the end of the
>> function.
> 
> IMO, blow_tables() has no business caring about vcpus.  It should be
> idempotent, and ideally wants to be left in a state where it doesn't
> need modifying when the aformentioned create changes happen.

First: Both the change as done by the patch as well as the alternative
pointed out fulfill this requirement, afaict at least. Hence what you
say doesn't make clear whether you agree with the change as done or
whether you'd prefer the alternative (and if so, why).

Then the two functions do about the same thing, just with prealloc
having an early exit condition (once having reached the intended
count of available pages). Therefore ...

> For prealloc(), I'd argue that it shouldn't care, but as this is a
> bugfix to an XSA, leaving it in this form for now is the safer course of
> action.  Whomever cleans up the create path can do the work to ensure
> that all prealloc() paths are safe before vcpus are allocated.

... I think the two functions want to remain as closely in sync as
possible (I'm afraid I didn't fully have this in mind when writing
the remark - it should have been worded a little differently); really
I think it would be best if the duplicate code was folded. Hence to
me leaving alone that function (which is what I understand you
suggest) is not a good option, yet as explained in the post-commit-
message remark not replacing the assertion by an if() would have an
unwanted consequence.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:46:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:46:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422737.668969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojICV-0001Uw-1u; Fri, 14 Oct 2022 10:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422737.668969; Fri, 14 Oct 2022 10:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojICU-0001Up-Ue; Fri, 14 Oct 2022 10:45:58 +0000
Received: by outflank-mailman (input) for mailman id 422737;
 Fri, 14 Oct 2022 10:45:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojICU-0001Ui-GR
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:45:58 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62807c5c-4bad-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 12:45:57 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8546.eurprd04.prod.outlook.com (2603:10a6:20b:421::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:45:56 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 10:45:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62807c5c-4bad-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SGpxUOIA0iu0Xv+YdQlPtRNT1OBNf+qiW9uT3PZbws+GtmqFr5pTHo+eQlA7qSI+TvGOA/zUjpZYg0jru2Mf4vrXL1PTjJb1SBGFp7XGuKNIq0mHWrHEg0TUR2VsNAvHhkh292llIT774B0DfUSIr/IkVgmrDARQp5P20X1oDjA8SjC442z5E+c0PADS+i5r2vramzcZ9CzXtFyK3eCOUrBCL8pVkl+QNtbHkH9Da06A7Wf8ikYqWqr0CFJVMEIKh7Ek0bWEm6bMtSAvjH9ao81pPswbVPOl17wuv4bID2sVbINjVXDHU0GE3NFdH1pm4oOE4TNE/qIE+C+HO1uZKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TgQ2wrU8Ch7wfwAdiTSrgmW0AQveNp6rsVxf8bjn4AQ=;
 b=P7OUddb60iGfnzdKqCn4mJ87WnX+SzqbLRjpMKu+nkVKJbaq3V1YjKC16F9hkaWYK5dd3GwqfqgLFLIwH+nP2PoRT9eJfEu6EKe8OSCTFCXpbuiENh22O/1JXJb5m0lx63/uHGVnysRJH/Z6HTVHJH5oxKRGVV+7+/dL5VxOnlS79BNkDW8ZTKYZrTubJ7kI9pvN8Miih9uwvM0H9RXNM3aULZDEzPjUbMU5796P5x7gBDPtOthtmwEg8Movo0SdTGNsh1RE+Xo2Mvi6B12j5M4u7EQhrXeZrVoyDvwSEoWbVnkJb+W9uPkZnWrHbj/hdS9MNEg0pr6Fh49iC2fEOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TgQ2wrU8Ch7wfwAdiTSrgmW0AQveNp6rsVxf8bjn4AQ=;
 b=5Rt1m4/+acOh2IcyB1mMUuLFRZc/EN7K5kksaohDzRJP2FOUmE0Tudk5wATk/s6NFa03KTggFkcf/uRWnomiEIjqHWlJU1JflJW33q8bXAWTGkiMFpaYi2lCdb4qsww4Uhm1CiXVrzohAsNin9JTedYeCtEEOy0P+z8feMBeBZgZ429hkP4AlZAzs9gOKxQcYKeZ8ZmocpCczTKRA1EiRet7KZrhL4PqF4JYFBy/gMj1Q/fbFeZ8YdA6b1to7Ykcv61Cy9c5gJgvYM2QEIqhOOPch2iLQGnMKwnERITetKFyGxRRy9ZU6Gqbt8FUbuarX7HBDy6Aniu71iZp0ifINg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
Date: Fri, 14 Oct 2022 12:45:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8546:EE_
X-MS-Office365-Filtering-Correlation-Id: 685be64d-f821-4495-6916-08daadd14606
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WO0BMzbcR6Mp15+kmQ87MH762CAWLIKaEyBt4BpTs2z49sfT9QKmXVMf2gB8aJJtut3YHZh0KWo7is9+AAmt+G6iY/7XbID8H4f8jvodGEMh/PA5YVEHrQ2NjzH8LopdsiSNrB1G64jrX1Xg5EV0BKw06ItIr+3kfbnY13Ox3JxEk1UmYJJYrcHZgXoGWOI4RQSroYbFtTtRXbeZ9JHEZc7OkWT69atmpm4bHp4Xb36sSxfCRlHr/2K4/k79IAL7GJWA1GiudGiHK1m8lWfErDSWxfN5DCbo8a+XP2+xeZewipwlTC0GtXoX56O7H1JRY9SR2WKohsqUB2iXJ/PBOOy6A6q7IxdIOme0oXkH3065xGyUctc6CNwOWb8jTIOFRGcGh2uv+7T4LcDkYgHpEX7yymo3zoBCvIapeFoUV57T/13PouiDSWxP3hLauOLUeyblP011UK6pKNotLh6T/2dCs9+oZyZwPnyRG8hCZIMfLaWQ2v68xQBTwB2/r+ejazu6z6M3ZoYIbs7zRUnlTmDNMFq7iMJVYqahNuUJP6eiNn0OTKp0ibzy6jMrRcNbK+WYydoZ2sHQ3sB16Xcbn3KKSovaV7RlyjYbKCb+JjsIzepgXMEAE4vhv+mn1WwAX2C/6PfzptBU0Cez33XXE3SYyiNfDMr/16ip4eek19MI5PoMrQKXRjNojggRHx6ERCVOnSOl1iDX8X6hj4/3HY7KLgW2yL0HXM68+lzJnmbvXCQI12uDDCggrtc+7xRUwbl/0Uf/cnNoTJ+8EBo7QPdX2iG0ZMVn568bYdwye8k=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(136003)(376002)(396003)(39860400002)(451199015)(31686004)(36756003)(53546011)(2616005)(41300700001)(26005)(6506007)(6512007)(478600001)(6486002)(66556008)(66476007)(8676002)(4326008)(66946007)(186003)(38100700002)(86362001)(31696002)(316002)(83380400001)(8936002)(5660300002)(4744005)(54906003)(6916009)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cnNrclNhN3Y5U0FFTm5JSm15Ny91bkpsQXVUTlZhQkxIMkRSVDQraVZLa0ow?=
 =?utf-8?B?aDJOQTdlRGhHTlNETW5nbmJxcG5VSjB0NkJmZ3J2N1VKVThLRENUcGxSMSs4?=
 =?utf-8?B?MG9DL1NxcTIxdngveXFQQlk1eHNFRGhsY2grVzBMMSszcFA3OG8yT01qT1h6?=
 =?utf-8?B?dXA4RkdsN3hzNmZDa2Z6WFo3Q3VmMkViN0N1K3JpNWF5R3o1WE1wWEN6N3ds?=
 =?utf-8?B?K3FQa3ArTW9uVGU0cjU4aWdCVWFvTHIrcnlIUkNvSkRHQ0dLelZXdjA3ZHNx?=
 =?utf-8?B?S1E1ejdIQ1RPcng5bmVia3hmWkVaUmM0aVFSVGwxZzVZK2FwZlREQVEyTHBF?=
 =?utf-8?B?aXc1YjBYTHpqUlFOMlZUMDBob3ZmSlZmd3F6YlhJMzZqVzJQTEpCQ3U2ejNo?=
 =?utf-8?B?dzI1M0x1dnJzZTREeU1sOGIydFhQbGZndEtDV0tOMWJObEdJVVNqR1E2blFV?=
 =?utf-8?B?VFFtenplSEwydG1qbjl2TG5hWmlnSlpySk9wRDVVaHFENTQxL3I1VitGbzFW?=
 =?utf-8?B?MTI3bXRPdVkrY0ZxZW5uRmxCcWYzYXA3MWthTE9kcVd0Z0Yzc0liNTZmYjdp?=
 =?utf-8?B?aXZYOEs1STJ4VHcyT3k0UnB0N2ZqYlZCS3lyT1RvaEJjNDl5ZkNjQzVZTTgv?=
 =?utf-8?B?KzFkMUw0WUJOaFZ2dlZraEt1TGxaZzF5cWNscTlMWGNiNDlUNHc3SFU3QTlv?=
 =?utf-8?B?WjdvM1Qrd1B6RlVMMHIvVlAzeTFtK2hGaTRHdDVpc281OFZOOTVUcGlaQWdP?=
 =?utf-8?B?TlorSlk0UTl4TTlUUm9aVzV2Y1Bib3gxaUk2OC80NGhzYlNWdGlLczFlb09X?=
 =?utf-8?B?SVkxcE5IbzVvSzY4d1psd1kzNytQc3BHbDBWdFpJZGZMcU0xVWFveUVrM1FS?=
 =?utf-8?B?MzUwK3F2OUJwT0NLcGJ1bHN3N3dTQ0VJL0tNTVNpQ0h2NSt1bHZBUzFQL0ds?=
 =?utf-8?B?bjhNZkJGT1EzVTdDQ21HTzZMRjU1WUJRcmFiQ1RuK2l2Ky9LYmgzMXhrV2ZF?=
 =?utf-8?B?OXdOUEZGWll5T3ZNS0QzVDdsQ29hV0FGTy9sd1owZkpEOXJodkVKTkhyMXBQ?=
 =?utf-8?B?RzRvamE3bnA5WDZoMS9tNGw1eWF4TmF1Qit6NDJvSHFjRDl2Zi9xclNiNnFW?=
 =?utf-8?B?c1Fpdk9jeUJnSUdaSHVCakFndjQ5dFhyOHY5WEk5Q2FnQVJ5b1E4TmhKODU5?=
 =?utf-8?B?KzFlTzVBVi80QmhMRjM1ZHl3WDhTR29BNXFnaWNKcG1TbGtKTXRTZjM2dEM1?=
 =?utf-8?B?MEl0dGpMWmVFTDlJWWFFUmxnK0IxSFBrSXQxZWREWnpJY3lOc1ZzM2xEaXhT?=
 =?utf-8?B?VGxCQ2tqck40eDhzNzVMNVpoN0swb2FmNy8zcm40ejEzeXZGL0RHREgzRk1n?=
 =?utf-8?B?VnRNR2x5U1J3cTBKcGpueGV5SEpZSE1kenovUDUraFZxZXVYU3h5V21aaFVq?=
 =?utf-8?B?eUp0YVZPQjJJMndzZUFoSzBIUmM2cldOYnIvaGkzRHlRVWNuWFB5V3pFMGsx?=
 =?utf-8?B?a2VFK0d4R0R2cG1mVU1KTHVwaVFueHZYNWpiSVJwUmhGNFNySlhZU01RZEUz?=
 =?utf-8?B?dW05dzI1Sit4QW13YmZCM2VXMHNYRzRhS0xlcDMxK1JmZDA3b2F5NTl2T2xQ?=
 =?utf-8?B?c3RWNUoweUdNbUM1VGJjMURkSTFCdDBVZ1Y4M0Z5OW10dGUyN1huZTdROXVj?=
 =?utf-8?B?VHFjOGpDTmovcTRzOFc4K1d2SDMrd0V4Z05mSVhwbExtYlRuMGlyQklwZ0dC?=
 =?utf-8?B?bytYZWtHOHZDU2lrbE9oZ2VSSXZhb2hHMkw4TlVxa01Gd3ozVzBNTERDRkor?=
 =?utf-8?B?T05RNWNzV2F0d1dCTUlrWmQra2VYb3o1RjQzZUNJbU55Vy8rTExtNjZHMktO?=
 =?utf-8?B?Z0dkOFlmZ2xWOFh5UDJXVmZuM3VLQUlzM3duNWo3aHdOeE5sdU83VHVleEQ2?=
 =?utf-8?B?RHdIbExIWlBIOU4rcUJ3UXltS3ZLdUJtVnFmU0FlSFRLc2lxZkJFT1lsUWpp?=
 =?utf-8?B?d3JpT0VNVXVXZWNnbzc5eWdhUE9NS0NJQ0ZlaHArbEtqYmpSS0hQdnJCd3M5?=
 =?utf-8?B?RjgyRHpKcnBLVTdKc1lMcmIvdDk1aE55OGZlN1hPMW9RU0paaWRaL3VQY3dO?=
 =?utf-8?Q?Ot53CPVhjJ0SZV3qC/FDfErj4?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 685be64d-f821-4495-6916-08daadd14606
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:45:56.2348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RGqasZqM8vzBkakyJPrrMHUeHfNvqzMd4vt8WkZnyoscd3ozHXy+tcdyWt0yMOrw9b90epdM9Ka819JPn7xqGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8546

On 14.10.2022 12:38, Henry Wang wrote:
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>>>>> +    if ( d->arch.paging.p2m_total_pages != 0 )
>>>>> +    {
>>>>> +        spin_lock(&d->arch.paging.lock);
>>>>> +        p2m_set_allocation(d, 0, NULL);
>>>>> +        spin_unlock(&d->arch.paging.lock);
>>>>> +        ASSERT(d->arch.paging.p2m_total_pages == 0);
>>>>> +    }
>>>>
>>>> Is it intentional to largely open-code p2m_teardown_allocation() here?
>>>
>>> Yes, AFAICT p2m_teardown_allocation() is preemptible and we don't want
>>> any preemption here.
>>
>> Like Jan, I would prefer if we can avoid the duplication. The loop
>> suggested by Jan should work.
> 
> I am a little bit worried about the -ENOMEM, if -ENOMEM is
> returned from p2m_teardown_allocation(d), I think we are in
> the infinite loop, or did I miss understood the loop that Jan referred
> to?

Where would -ENOMEM come from? We're firmly freeing memory here. -ENOMEM
can only occur for a non-zero 2nd argument.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:50:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:50:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422744.668980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIGn-0002yI-Lf; Fri, 14 Oct 2022 10:50:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422744.668980; Fri, 14 Oct 2022 10:50:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIGn-0002yB-Iw; Fri, 14 Oct 2022 10:50:25 +0000
Received: by outflank-mailman (input) for mailman id 422744;
 Fri, 14 Oct 2022 10:50:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojIGm-0002y5-3m
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:50:24 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00a0c6cc-4bae-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:50:22 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7644.eurprd04.prod.outlook.com (2603:10a6:10:20c::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:50:20 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 10:50:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00a0c6cc-4bae-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZZH+BpDGJw6WX4J+SV5OXvjWR6ZicvuCvJ8pxStYMc9hxFpLFolusykdee+1fMO6SB8/Fvu91EfjxEIfHIkdHZVgWexquhWQBfCH9eEZRiGkNtobwQ9O/6NXNaHDI8pNUuO5RzD/GO22szZzPVguGDZlmOZl+DrBCURdAvbmHRTcDWQkITPRuQDN1O31gxQUyxYSgs99mzNDGw1djRfm1Pa2S2RLeFJqfEY+mljrF+MoYBYWgMXl4Y+cm+HEGuzvnr1msWLwOsmAazH/bKVOZtg3b5qFPKyJqqZHP417RQNCc5tv6SuXZHa90DWI289wrO/Ci8KRhAqAOOLhtPQu6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sv0yEyOILgtKWPOKreoq0TNzXam1SklXEY/x6lVR8mU=;
 b=GYXYEfjNYVtYaPeqgZmVR8xlZ1stUnEJV+AMfDYfdKEsuo1+OZV7FovY3l2iLUZqrbf56vWWaA4cV0jE0IYbFg7GsRB1ZAsC6XERw7WFrCDuSTBEwo7Z2f9NTrU92+od7T/0AQiIAQ1Ovle8b4ysB7AnDmPHS6mGLnO53MXcfS6AOjMzDHFRh0rMsS8QvBHishIyRyH1PYaybmVfrfqwnzUzK7xt7PkLZZKnRWl/b0KWLYBhAlfVj+pm27KoFphqzAZBd/NtnTEx16exbPK81mYSkW9kiKD2pCilYCYalMdR8/7tK3sCa1+gsnrRx+X/uYKpSaMr8WGffpfl72QJAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sv0yEyOILgtKWPOKreoq0TNzXam1SklXEY/x6lVR8mU=;
 b=WatwEWLOwuimyC0Q1/osgL+fsKIq6N9ctGaqd93FHeuO2Sr2Q7Z3xg6MuvBIpoo5NvRvhAfFRa5QxEc5isa/5Ht8yjF5YkmnMk/m1PsAOFxlX1fZkhbQXuUuoh1PJfLfUSm1YJ5eEBnlOWZtDRUyHBz2aJnfXqrC1Do1KEMWDkKOfrL2rDdfmor3eTjrLy9kCOhDY20yBWnpUQSLGxhJ1PHdDq6hneTg7/d7lyGsjs0A6ZGn9XT04C0wKhKxzyYa6KSnsOBTotFBCCtKodbHkdQoZ0KH5XZldCBa0gxGzN48GJZTIuShG/y7uYSBcyywgNC2amPgO4yPSTvJMRf8jg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4e0c6a59-0d78-d926-3928-ea06f0120bbe@suse.com>
Date: Fri, 14 Oct 2022 12:50:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Tim Deegan <tim@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
 <Y0k6RSI0VJhTVmEi@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0k6RSI0VJhTVmEi@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P194CA0050.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::27) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7644:EE_
X-MS-Office365-Filtering-Correlation-Id: 9ad5a60b-2823-42b6-16ff-08daadd1e3b0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q7t0HsrXFpZA0Zl2szBasM8z7bBpTOuN1hLV7WNWPcl1WoCjdEGlJHyIqgad7xepmjfeWcH8OlWHP6S3xqm96ux2cj2QIUTJmIL+84m7S88fBS3jj7dCmwnCH83U95pQYqUgBujAnVS9xyMo8rudNSFjX2wv8IvX/yyQBMoqWM4rZzjNAo6PMdUZuj3jf14Wr8y9DHUk1JDFS0NJP7O0Imp/Ya6NlkDtNtFBGT9++RXh+U3cvppyRpb5K0AQ6kbJTxpZ0hbFVTBSBn19tFC8uNwfezEc/0+GWGHTylLgB285fX0mQgjGv0mU+ok0gLRa70mDwJ2BLPwbPaulhV8C4qi9vgQUFK49ceR1oOKKl6BUUkvvrFRSnYkpUWrkOoj4BAfW4hwCqOCtindv6gBYH45w/SfqK5HMxcC1ea9brsKHDPvpX9LYxa6AxkWGiEHoFCoDiHCFsP4Vh34zWSQRbYS/BHhkFqXmXNycpRC3FSdxTWiClncLCIp5HMKWjTURZQuoaAjP55sYAC6LgKkw5r1cN4eSr9yX6vHyFRjUcx2r//cucZqYsIbjr7ZjRvKzxaDOpi9v9NaJ6hSaFo+DKArWt1h6riqzSO7mXfEAo5+v5G953Z0qUFDgS2F2JPkuKpMXKptnDMJMH0ugMCVbRUeGeJ0o0eKuZKy136HeHj7PPipfoQv5qHI9zChtOKvX39TLUVZbvIQNPGMrZ+5+y6COFlNMWvB/0xeSZiSt+219Tdrzmwj2q3gr3x82dI7NwkMZ6KFwQ9kdri9J+ToOGzInEZLqqfcXMW9ZvmcX2I8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199015)(36756003)(2616005)(4326008)(53546011)(2906002)(6512007)(86362001)(66476007)(316002)(8936002)(26005)(6916009)(54906003)(186003)(31696002)(66556008)(8676002)(66946007)(6506007)(5660300002)(478600001)(38100700002)(6486002)(31686004)(41300700001)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MGl3czNwMDJjcnMwTFpROUdUQWdsMW1jYTRiZm5KRDJYZTFTU0FQbk8vVVpN?=
 =?utf-8?B?VzBQNjhiVlhCSUNob29XRENQOHZxZWVwdzNzVVRmelFlRDVxWE5kdkdKUWF0?=
 =?utf-8?B?eDhjakV2bnNsQmtJYVFzaEFBMzVpanNySEFydzY5Y1dTbjJjendYRUwwRHBW?=
 =?utf-8?B?US9xVXVGNVcrL09ibWZ0Z1NHVTA5U2xZR1RMMDBHZFZlRWpQTXlYSXEwNnJW?=
 =?utf-8?B?RG9XNWdZU3EwUmtIaHl5WUtaUDJlMnUxNHhaUHRva1BOTTlmbFlRRUMyc3pR?=
 =?utf-8?B?K1pHUzNRM1FmOFB0alpRdFBMWTV0RVRGV2ZOM01BQlp3STFqalZVNU5VdTQy?=
 =?utf-8?B?dHN5OTNHMHRrVVAweEJudHQ0ckY4eFFZM1ZSa01hWHJCYkhkckluYjRBeFJX?=
 =?utf-8?B?U1djb2lyK0lhUUlid2dqblM5TkZmUVJKbUh0dkE3ZTRNK1VpTXRzbUh3bkRY?=
 =?utf-8?B?VHYxYzl0OXRxMklCT2ZUQm5SSlVKMUxXRFpkNVpIUjRUcWZJUnVVVjFJb0JI?=
 =?utf-8?B?d3ViYWJpSllIYzArVkg1eUQzNlpFdHcySFlkVEFLL0pMNHFYby9jN0hkRkhF?=
 =?utf-8?B?aWs3VTg3OExZa3ZYQ2VjK1FDcjg4SlI4NGFtc2lWT01rOVdYQm95TzVucmZY?=
 =?utf-8?B?N1FLNG42MjBZSi9PaHZMY2t6dHdlMHhIdnh4Ty9yK3R2UVczNTBHWm9KTkZ5?=
 =?utf-8?B?TDJLSXRGMWRTalVTeXUvY25lbnltNzhDaUdHWlI2enJFRGpsTFl6d0w0RC9M?=
 =?utf-8?B?ZmF0N3dpQzk2RHZRNHdhUVN3MUhEcVU2dVRFbStNT2NseG4wc1JTd1F2ZVVN?=
 =?utf-8?B?ZzBvU0RPOHU0R0M1Q0hTSEN0YlF6bWJVcTNCUmp3WXdpOFVNQkE4RHkvUzdQ?=
 =?utf-8?B?QlZvcElzQ0JPTVhpb2NPUXFBTUo0UWcwajcrSUdkRUk3L3ZDNU1mVlVTMWRi?=
 =?utf-8?B?eUNtSi9SUzRGNzRVQ3Z6dUhsOHhmWGxnLzVuUlZVTHNXc2h4VWpaMTY3TCti?=
 =?utf-8?B?QnlEUk9NVWhkekpMekVNcjNjdkxLMDJCczlhV29ad0pzV2hrbFhhcHMyTHpT?=
 =?utf-8?B?dGVqcm9EYllib3d2QlA3emZLbUpJYUFIZkRySnFkQkRHQ2E1UWd0K0UvTW9Q?=
 =?utf-8?B?WkU5ZGE5b2dHaFcxQUozQXk3d3pKOFo0bHRLckZOaHRZaTdrSDJ2aklBVGRy?=
 =?utf-8?B?V0NXcVRNWjF1d1dlcjJVdC9RQmNZdWJNY1JYckZyS1ZYc2N4Sm10cnZ2bnlY?=
 =?utf-8?B?RndPbU1CU3FQTEQrdk5rc2JRTG9rajhmS3JGUDZzV3RJMEt2ZktLWWpmWS91?=
 =?utf-8?B?d255ZU9NeEI2dUsyck5keDdQSWkzNERtRFBETkVkTm5yR3lDbjZKcTNlZGF6?=
 =?utf-8?B?Z2U5a2ZZMGErbU9ETW5janFWa3RGZHlpNDRXbVM0YjhOUzNQazBKY2pTYkhG?=
 =?utf-8?B?c3VEOFRVWXlldGpUM1hrQU1tTkNMcU5DUnhjTTBPVFljdXNCd0lYTkJSa2li?=
 =?utf-8?B?RVE4R3R3YUlaY3JRYzZWN3JWQkZka1Biam5SWndudWxvOTZXWkZvbW42bUhN?=
 =?utf-8?B?aU5hMVhXb25yN0loamZZeUJsRWpWSjQ5QVFKTEM1dk1FcWtnOWZJYXpIVzBC?=
 =?utf-8?B?dHJRQy9oWkZWdkV5S3RDN3dqdVBBenc1MkRLNjNQcjE5a3lpSHJKK3NYMkc3?=
 =?utf-8?B?OEZSRkk5czdkcmR3YkFEd0lsZjBxWGE4RGRKaTF5SUpWeEE1czNjUlY3b3Nj?=
 =?utf-8?B?YkFrV0dhZTlUQ0NpVGZQdTBvWXFiNmU5M0laSDNBcTF1Uk1jdmVDNWJsa2NC?=
 =?utf-8?B?dkZEc2JoNjc0NmI5MU9Ram5XMFRvV3BLem9rZGI4OUlsU29rNDlTZjhKUXE1?=
 =?utf-8?B?bDc4QXpCL2d3U2hIK3QxVTFVc1k2V2ltajVWR09EUXBxWUxOZVJYc3I5RG9H?=
 =?utf-8?B?MW9UYUJnd0pHMXVhdlRqUlJibHJGNTloOTlwMzVXSzZ4Uzdidmd4TGE2TEFC?=
 =?utf-8?B?aWwzZ1pkd3pUYy8wSWM0d1M1RWtvTHBNQ1pFSlByaDJFTUY0MGZnRW4rNFBP?=
 =?utf-8?B?bkhiZFJvMENBdnlNc01ZMExNdEdyOEgwekVuS2dEQVAyZUFTRjlOREhwVXZk?=
 =?utf-8?Q?+yukD0702RlHCTmQ86HrA4pVn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad5a60b-2823-42b6-16ff-08daadd1e3b0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:50:20.7334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TK3BwU1svZMd76q0fTABBM/lIhy8B4CFT9UciTXu2xKvXAZw1/CjDirPIoprOG/pR0+moyNbglimeSSaLoFLDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7644

On 14.10.2022 12:30, Roger Pau Monné wrote:
> On Fri, Oct 14, 2022 at 10:49:55AM +0200, Jan Beulich wrote:
>> The addition of a call to shadow_blow_tables() from shadow_teardown()
>> has resulted in the "no vcpus" related assertion becoming triggerable:
>> If domain_create() fails with at least one page successfully allocated
>> in the course of shadow_enable(), or if domain_create() succeeds and
>> the domain is then killed without ever invoking XEN_DOMCTL_max_vcpus.
>>
>> The assertion's comment was bogus anyway: Shadow mode has been getting
>> enabled before allocation of vCPU-s for quite some time. Convert the
>> assertion to a conditional: As long as there are no vCPU-s, there's
>> nothing to blow away.
>>
>> Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively")
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> A similar assertion/comment pair exists in _shadow_prealloc(); the
>> comment is similarly bogus, and the assertion could in principle trigger
>> e.g. when shadow_alloc_p2m_page() is called early enough. Replace those
>> at the same time by a similar early return, here indicating failure to
>> the caller (which will generally lead to the domain being crashed in
>> shadow_prealloc()).
> 
> It's my understanding we do care about this because a control domain
> could try to populate the p2m before calling XEN_DOMCTL_max_vcpus, and
> hence could trigger the ASSERT, as otherwise asserting would be fine.

Yes, that's the scenario I had in mind.

>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, but Andrew and I will need to reach agreement before I can put
this (or whatever alternative) in.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:53:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:53:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422751.668991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIJo-0003ZX-6R; Fri, 14 Oct 2022 10:53:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422751.668991; Fri, 14 Oct 2022 10:53:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIJo-0003ZQ-2J; Fri, 14 Oct 2022 10:53:32 +0000
Received: by outflank-mailman (input) for mailman id 422751;
 Fri, 14 Oct 2022 10:53:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojIJm-0003Z3-Lu
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:53:30 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f6ea996-4bae-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:53:28 +0200 (CEST)
Received: from DU2P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::25)
 by DU0PR08MB9679.eurprd08.prod.outlook.com (2603:10a6:10:445::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 10:53:26 +0000
Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:230:cafe::69) by DU2P251CA0010.outlook.office365.com
 (2603:10a6:10:230::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Fri, 14 Oct 2022 10:53:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 10:53:25 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Fri, 14 Oct 2022 10:53:25 +0000
Received: from f2c80caf7ee3.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CD105B67-B80E-4108-BACA-5682235EAB03.1; 
 Fri, 14 Oct 2022 10:53:15 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2c80caf7ee3.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 10:53:15 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB6715.eurprd08.prod.outlook.com (2603:10a6:10:26f::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.28; Fri, 14 Oct
 2022 10:53:12 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 10:53:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f6ea996-4bae-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=PAkSMaqF55FZsRB4EYzeGeq6HX9u5vWUN5GIc4vzPuQbRqELkAKetOdcMo7xqhAbmzoTqO+ML7JPEElpKL2jckxIdVCQNdcYRjT68+9o3h6aIkTUwOs7/Ettqb0dpQkwlnsRrmW1H1O58oNOIcDb23jHx4lc1gqDndQtB0fU7vQfeAt2O0e4p9PLE8wj1Mlbp9OExzGOmcAiZhPy5GGnnp6m/QBZYudiQR8xzambLugDUsqXzCKsMX7ub2tI7h6QluBPJK91k2kjg36aSfKDBaT5PzmgW9IuwfT4ilwggq+ZhG5EbUZc4a0oqFT0xNEzx8eW8o9Cc+dQUyBLfzCWAw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zeCrEx6uxBpFQnoMQNaF/5FHws6SrBOtz2IWoU8HGnM=;
 b=a4PD5OAsZrHKQ/kBeip+Mj7Xpnor+ojwNAd2+zRwCzOj+2PqVf5IEtNEDAXBDxR9ss6S8iElslpnDonKjv7YUZsoodhHVQndWNNYYgX3vePJYDQcnOCntyaj0lX3G3XwUrl9uIQOCMg+TKruI49lTuTwILMsGZH3fpq8M9/ZPqwQhaDpuHR3TT93xHkKLZ6/XqmmUV3eGFQzpZeRRjwZSMueJCqn34Tc5fwdGnjxPXdbrYhO6X2bSqZ7t1HM+gYKdMy27wE+A/zM+L+2zEdYrd6UR3JiPpfGHeoeozrn1U32Z1pQuIwLs4TMy2KpWfJWr4qhvbgKIbIR4Ntl1UGElQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zeCrEx6uxBpFQnoMQNaF/5FHws6SrBOtz2IWoU8HGnM=;
 b=qTsl4ZaGXFMiFVkAyFJ5hVJ0mmYvX4+J4G5awSaNxtrqatGqTL5Ez5XU6I5MUNX7KKgnZYzRlAcBr5a524ekdgmnfsPLez9lfY/nr5dr/9CKGyZJW1zPpBVrKJwVYMGjJuZtsPFPR0rQb9szQ39LOxTP+wq4mX7Q3P6AC5kflFw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EewzD0sNSGK7hsKBvibS1GMP+AEdkjgL8ToxO5VlMZ/R6YImocQJWdqTWv7VPWCHumzWWJqXFxijai7htVE7GZQQETDOszky700uNqaLhcBXUZYLRg6ne0lkrcbHlRsbV4m16wgAOZ/dm2m710vJBz+wXmhKpnxfmzr3KuI4msYqwhjzRWT5nD2lbUZw8ZDBkBn/igjK/G/pM+/VHKCQoHw7jCeo12p0clvGJrkTRjqnjdDRM1Z/M7dhHc8U1B8s7zzHZi7APVmOyFarghDFBPgbYyO9XpsfH3e5b2YxaZeRFrq9P7YmBqEsaZ95Yvz1jiniVcFwldGG7hX/aoz1LQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zeCrEx6uxBpFQnoMQNaF/5FHws6SrBOtz2IWoU8HGnM=;
 b=KmxoIhkdWjTESamg2iRJKDb72lvKz6UObePkMQ4ABT0UE4N6ivZ0QfzDOGv8b7U1Y4oF4KNIKdlodRmsP+lJQla6WSTn6GCU840jIlmkOaJLcurmJ2IQ8lOsejWAbXihKSGF3UuuZAs5bYN5UimcWx8pPYNqA8UkbiRSXs1pqGDFtHopg9FkCT2gohbA09nzoKJvX5FPNKR8Jd86BDg6rkR0pZTHIZV3D9SeZI6ea1hR5bhEdvFN/1rZf39a+WU8Cn/unU1xoajOKnKRqRQ5yIc5YaoCrF44ZpIYATai5eiP0fS84a0/OKZdqHFCIJLPPT2+bKqvCbKn+EY9/uOjNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zeCrEx6uxBpFQnoMQNaF/5FHws6SrBOtz2IWoU8HGnM=;
 b=qTsl4ZaGXFMiFVkAyFJ5hVJ0mmYvX4+J4G5awSaNxtrqatGqTL5Ez5XU6I5MUNX7KKgnZYzRlAcBr5a524ekdgmnfsPLez9lfY/nr5dr/9CKGyZJW1zPpBVrKJwVYMGjJuZtsPFPR0rQb9szQ39LOxTP+wq4mX7Q3P6AC5kflFw=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index:
 AQHY36RSrOIThkYtnEq9RrtWc+uYX64NnUwAgAAAd5CAAA4NgIAAAPkwgAAIMgCAAAAtcA==
Date: Fri, 14 Oct 2022 10:53:12 +0000
Message-ID:
 <AS8PR08MB79919FFC44E975825EE9CB3392249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
In-Reply-To: <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: C6BEBE2E5341CB41A42D74335C7B4CB4.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB6715:EE_|DBAEUR03FT010:EE_|DU0PR08MB9679:EE_
X-MS-Office365-Filtering-Correlation-Id: ea854d5a-8e49-4b28-6c64-08daadd251d8
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 MvDhQlPEKCs4SC02tXwejwWGblIQgXEk/deU7wNNHvSUzk3SIo8YWOEdfXz3izd/npdUQq7XnSZEmM8/D0pjV0DZ188zrfyCXJBdmpj6DGAkYT/8DaG75VOZi+G97uek0KETJmf7GZppmCyKNuDKw+ZsgAsvU23nxM3MYt8ugXpsAaO2qLYUZxJbYE98Dk/GuHq+H/9qtab4SULrGZU+pqskdw7OXrW2vtkTppSu6v62WtPgB6wGK86IKcKQruYCrTpFUOOpVuTGKVsNxZ9ez4t0EssjeXpxU6X8Z/INOXenNnbHPGP18PzDf79B+CvYUiVFUjRt+/a0GtSCxpIr1rEMIjV9Qnr9lNF4N4qTlGz7nPxLCNrnzUXYwSnM45OnzgbJixgMDq5OzudK9JDHS7Zcb4TjZr6r+i8GenoFHEMdYpFsCbKQXp9rFyPLw1usrA0MBcZVWKkDd62Y6UJl7TyPWyVOi1Co9MRB109vlpovucqaHPoIfkpHVp2JePETtiuQMRJqlTxMNESVYC+d5ozIB0r5Jmt6/OWolPJot54Ka7p+ftoGZsoHvdueGkZ6pXkGgYnEx8zhkf31kWq2t2422SKkLDPoy5IBSZNVT8QZx83ugds012cTEhryalWCrJokjvPsHeOKC6CbudNHym7oBg+/fjnLI/5wKIJnQoyKTUmJZDkLwr1L9mw+4GXojKhTTVCCyIWR70AYSbcZGf+d5OEnvn2eK2HM1FANo2/0r8bdHJ4yQCD3JokFT3/f2gXdmQDvoXvrTKxRg/7Y1w==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(76116006)(64756008)(53546011)(66446008)(7696005)(66946007)(83380400001)(66476007)(66556008)(6506007)(33656002)(6916009)(71200400001)(54906003)(86362001)(478600001)(316002)(8676002)(38100700002)(52536014)(38070700005)(5660300002)(2906002)(8936002)(9686003)(4326008)(26005)(55016003)(122000001)(186003)(41300700001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6715
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b1ccef96-821e-42c5-9ee5-08daadd249fa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eheoMpIOlNyP1jSOALvCpysGcaNi2rP3HLuMlrKOINNxEwFzmkPw7unrwTSPb8BZ2hyHFEErq/3TF38uek4k+yR2/9F+E6+6CyL2XIp03xkTdF0MHNPp+i99zSQMHlN2BSlqu3Yz7jlJwlyhnWY45W+Dlt32E9FZSrg82VLpgtMoZJcHpW0tM80PD/p/bK9XdWC4nyRENfkuOzDSscFJTp7tnGrBakww/2M/c2VnacS2eAn0+QVthGrXgmwG++HGGxcH9qNo6n2rWA4s+FLI0pxanC2bAhA9na9pCd2aqcWV+hrg3w0OUMQI7b5X/8OirHx5cwmMBdz+NN/vnOzePDVw3DdzdLNjF1GY1T3g5tN/R6NlZ+4Tc01iFs9g42wKmILepZ1+LLiGZvNdey5yqiJgeg+MDxAaJK46UMNbjpTC0IMhz6qW6dwsduFe7MqSq37Jm64wjlQ91OekIpI4pqZMwh/lTbUhDfoFagH+2KBe9qAEVQTGOaqCVC7LwHnOe8ajNBQbbs0hykGtKaK2Fk1C9iVHBcq6ix/kijFKslSllugX8fHDxvDZOZRR0boYxJkYLDzzCcyYTHcJ8HZB3oRTiwR4EFORy1DYWcOIQmXB9HnXro7b++L8/T5Eei1/BDpTWFPswiIuRg7p7MgMmY/0psOtrdrwZTvNaF/JpdYQfzGgU++tz2BzDj47YZ7VENO/kOxRknhDiUTbp1z9qa8/wQsKSnp1kBHVFL6hTWK2/fXj0xcjIWz3CUY7frKVNbFP/g67+rraHFhdUz2OGQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(26005)(186003)(9686003)(7696005)(6506007)(53546011)(47076005)(36860700001)(83380400001)(336012)(2906002)(5660300002)(40480700001)(55016003)(40460700003)(6862004)(8936002)(54906003)(478600001)(316002)(82310400005)(41300700001)(52536014)(70206006)(4326008)(8676002)(70586007)(33656002)(86362001)(81166007)(82740400003)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:53:25.4221
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ea854d5a-8e49-4b28-6c64-08daadd251d8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9679

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2Ml0geGVuL2Fy
bTogcDJtOiBQb3B1bGF0ZSBwYWdlcyBmb3IgR0lDdjIgbWFwcGluZyBpbg0KPiBhcmNoX2RvbWFp
bl9jcmVhdGUoKQ0KPiANCj4gT24gMTQuMTAuMjAyMiAxMjozOCwgSGVucnkgV2FuZyB3cm90ZToN
Cj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSnVsaWVuIEdyYWxs
IDxqdWxpZW5AeGVuLm9yZz4NCj4gPj4+Pj4gKyAgICBpZiAoIGQtPmFyY2gucGFnaW5nLnAybV90
b3RhbF9wYWdlcyAhPSAwICkNCj4gPj4+Pj4gKyAgICB7DQo+ID4+Pj4+ICsgICAgICAgIHNwaW5f
bG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7DQo+ID4+Pj4+ICsgICAgICAgIHAybV9zZXRfYWxs
b2NhdGlvbihkLCAwLCBOVUxMKTsNCj4gPj4+Pj4gKyAgICAgICAgc3Bpbl91bmxvY2soJmQtPmFy
Y2gucGFnaW5nLmxvY2spOw0KPiA+Pj4+PiArICAgICAgICBBU1NFUlQoZC0+YXJjaC5wYWdpbmcu
cDJtX3RvdGFsX3BhZ2VzID09IDApOw0KPiA+Pj4+PiArICAgIH0NCj4gPj4+Pg0KPiA+Pj4+IElz
IGl0IGludGVudGlvbmFsIHRvIGxhcmdlbHkgb3Blbi1jb2RlIHAybV90ZWFyZG93bl9hbGxvY2F0
aW9uKCkgaGVyZT8NCj4gPj4+DQo+ID4+PiBZZXMsIEFGQUlDVCBwMm1fdGVhcmRvd25fYWxsb2Nh
dGlvbigpIGlzIHByZWVtcHRpYmxlIGFuZCB3ZSBkb24ndA0KPiB3YW50DQo+ID4+PiBhbnkgcHJl
ZW1wdGlvbiBoZXJlLg0KPiA+Pg0KPiA+PiBMaWtlIEphbiwgSSB3b3VsZCBwcmVmZXIgaWYgd2Ug
Y2FuIGF2b2lkIHRoZSBkdXBsaWNhdGlvbi4gVGhlIGxvb3ANCj4gPj4gc3VnZ2VzdGVkIGJ5IEph
biBzaG91bGQgd29yay4NCj4gPg0KPiA+IEkgYW0gYSBsaXR0bGUgYml0IHdvcnJpZWQgYWJvdXQg
dGhlIC1FTk9NRU0sIGlmIC1FTk9NRU0gaXMNCj4gPiByZXR1cm5lZCBmcm9tIHAybV90ZWFyZG93
bl9hbGxvY2F0aW9uKGQpLCBJIHRoaW5rIHdlIGFyZSBpbg0KPiA+IHRoZSBpbmZpbml0ZSBsb29w
LCBvciBkaWQgSSBtaXNzIHVuZGVyc3Rvb2QgdGhlIGxvb3AgdGhhdCBKYW4gcmVmZXJyZWQNCj4g
PiB0bz8NCj4gDQo+IFdoZXJlIHdvdWxkIC1FTk9NRU0gY29tZSBmcm9tPyBXZSdyZSBmaXJtbHkg
ZnJlZWluZyBtZW1vcnkgaGVyZS4gLQ0KPiBFTk9NRU0NCj4gY2FuIG9ubHkgb2NjdXIgZm9yIGEg
bm9uLXplcm8gMm5kIGFyZ3VtZW50Lg0KDQpNeSBpbml0aWFsIHRob3VnaHQgaXMgdGhlICJlbHNl
IGlmIiBwYXJ0IGluIHAybV9zZXRfYWxsb2NhdGlvbi4gSXQgbWlnaHQgYmUNCndyb25nLiBXb3Vs
ZCB0aGUgY29kZSBiZWxvdyBzZWVtcyBvayB0byB5b3U/DQoNCmludCBlcnI7DQoNCmRvIHsNCiAg
ICBlcnIgPSBwMm1fdGVhcmRvd25fYWxsb2NhdGlvbihkKQ0KfSB3aGlsZSAoIGVyciA9PSAtRVJF
U1RBUlQgKQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:53:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:53:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422752.669002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIK3-0003yU-D1; Fri, 14 Oct 2022 10:53:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422752.669002; Fri, 14 Oct 2022 10:53:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIK3-0003yN-9s; Fri, 14 Oct 2022 10:53:47 +0000
Received: by outflank-mailman (input) for mailman id 422752;
 Fri, 14 Oct 2022 10:53:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p7Vh=2P=linaro.org=jens.wiklander@srs-se1.protection.inumbo.net>)
 id 1ojIK1-0003Z3-8I
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:53:45 +0000
Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com
 [2607:f8b0:4864:20::1031])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7821b7c6-4bae-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:53:43 +0200 (CEST)
Received: by mail-pj1-x1031.google.com with SMTP id
 q10-20020a17090a304a00b0020b1d5f6975so4492390pjl.0
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 03:53:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7821b7c6-4bae-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=5vsiJalDbjby2om3CQm0IH1msjjCaXJq8bt03niS5qI=;
        b=TlduGKO8Bh7thwB4rCCy1azM4v9Lze3+t+rbIj2CbcShSSs+QiOGJlabCe00k/fxx3
         G+Pg5yHqZPfSnDSoNeDTJ9+e/g7UphKSnmLwprQpbP5MXUlmP/9pLtQOGtPOp7Mz86mY
         cDNVfl6TBZgyItxXLXqGcvX8EePiFrW50ZoZJpA/YZHjZtNYKM1Tz+tH1+v1EOxzW+NL
         obkccgCqgFMJSTNJHAoxtk5LIJfheZVR8beQ2LjuZ1Whvnj7NFBOLgq7W7qhuhEpgxlx
         Gb0kN5azoh2E3vZEx2rAooH0nATorfAiU8vybph+VAswcclx/iHcst+lyehhcrK+pI87
         fJRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=5vsiJalDbjby2om3CQm0IH1msjjCaXJq8bt03niS5qI=;
        b=g6gtnANi8VMUHeJ3X8NmityYQoScxzciEUOX0tK96SessFcvhfi7i+SPHBIKj03rO2
         uZE28Aa3KsjKM+fhC8NKYV2tMZ8oGhZZLcwUvSi8ImkWFnZe2oSyhjy6EjsW4UDvd0fC
         oIKkvZpEAd97PCSRRP6l0MKMZxcyh+1SHhwiztPlylkqjIYPY8i9EdArPgsgswM7FkjQ
         vV4ZARvKV6uPiQktmH0wAai6LrxJe9hUsd5EheanWdfuJOx3n4Cl/J38p5ayr/ZhX8vk
         sv96g69mYr/tZ1Z1K1UYGGth0WKsmmifAmIM241Kn7ez7UXAus0km8NaAK+M49tSLYjw
         CxXQ==
X-Gm-Message-State: ACrzQf23gqB12eDDvdu08SRRTV2thZIl7ATV7MXZDPAibUI4X5FA1jBs
	5UCVVYs71BDXffodJBlfBBNw/YuiTRhJXmAGBc4jvJvwfqw6vw==
X-Google-Smtp-Source: AMsMyM4ZjWVlcTIf7ju6WsADtB9wdbDsBTeVYqn4jrnWU0/ZZKH4eMqmXgOpcHvG6RnQr3U3o6dsK/3MU2d5+n9eFUw=
X-Received: by 2002:a17:902:cf11:b0:178:29d7:4fbd with SMTP id
 i17-20020a170902cf1100b0017829d74fbdmr4560873plg.174.1665744822237; Fri, 14
 Oct 2022 03:53:42 -0700 (PDT)
MIME-Version: 1.0
References: <20220919091238.2068052-1-jens.wiklander@linaro.org>
In-Reply-To: <20220919091238.2068052-1-jens.wiklander@linaro.org>
From: Jens Wiklander <jens.wiklander@linaro.org>
Date: Fri, 14 Oct 2022 12:53:31 +0200
Message-ID: <CAHUa44G9cFOy=s7+zfZQ=XJ0FrqHd2bcx9B11Hn7ZHB9+9AM2g@mail.gmail.com>
Subject: Re: [PATCH v6 0/9] Xen FF-A mediator
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand.Marquis@arm.com, 
	Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>, 
	Marc Bonnici <marc.bonnici@arm.com>, Achin Gupta <achin.gupta@arm.com>
Content-Type: text/plain; charset="UTF-8"

Hi,

I understand that you're busy with the Xen release. When you have time
to resume reviewing this patch set please let me know if I should
rebase it first.

Thanks,
Jens

On Mon, Sep 19, 2022 at 11:12 AM Jens Wiklander
<jens.wiklander@linaro.org> wrote:
>
> Hi,
>
> This patch sets add a FF-A [1] mediator modeled after the TEE mediator
> already present in Xen. The FF-A mediator implements the subset of the FF-A
> 1.1 specification needed to communicate with OP-TEE using FF-A as transport
> mechanism instead of SMC/HVC as with the TEE mediator. It allows a similar
> design in OP-TEE as with the TEE mediator where OP-TEE presents one virtual
> partition of itself to each guest in Xen.
>
> The FF-A mediator is generic in the sense it has nothing OP-TEE specific
> except that only the subset needed for OP-TEE is implemented so far. The
> hooks needed to inform OP-TEE that a guest is created or destroyed is part
> of the FF-A specification.
>
> It should be possible to extend the FF-A mediator to implement a larger
> portion of the FF-A 1.1 specification without breaking with the way OP-TEE
> is communicated with here. So it should be possible to support any TEE or
> Secure Partition using FF-A as transport with this mediator.
>
> [1] https://developer.arm.com/documentation/den0077/latest
>
> Thanks,
> Jens
>
> v5->v6:
> * Updated "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h"
>   commit message and moved the patch right before the patch which needs it.
>   Applied Michal Orzel's R-B tag.
> * Renamed the guest configuration option "ffa_enabled" to "ffa" and
>   updated the description.
> * More tools update in "xen/arm: add a primitive FF-A mediator" with the "ffa"
>   option, including golang and ocaml.
> * Update ffa_domain_init() to return an error if communication with
>   the SPMC can't be established.
> * Factored out a ffa_domain_destroy() from ffa_relinquish_resources().
> * Added ffa_get_call_count() to give an accurate number of FF-A function,
>   updated in each patch as new FF-A functions are added.
> * Added a flags field in struct xen_arch_domainconfig that replaces the
>   ffa_enabled field.
> * Made check_mandatory_feature() __init
> * Replaced a few printk() calls with gprintk() where needed.
> * Rebased on staging as of 2022-09-14
>
> V4->v5:
> * Added "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h"
> * Added documentation for the "ffa_enabled" guest config flag
> * Changed to GPL license for xen/arch/arm/ffa.c
> * Added __read_mostly and const where applicable
> * Added more describing comments in the code
> * Moved list of shared memory object ("ffa_mem_list") into the guest context
>   as they are guest specific
> * Simplified a few of the simple wrapper functions for SMC to SPMC
> * Added a BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE) since the mediator
>   currently depends on the page size to be same as FFA_PAGE_SIZE (4k).
> * Added max number of shared memory object per guest and max number of
>   size of each shared memory object
> * Added helper macros to calculate offsets of different FF-A data structures
>   in the communication buffer instead of relying on pointer arithmetic
> * Addressed style issues and other comments
> * Broke the commit "xen/arm: add FF-A mediator" into multiple parts, trying
>   to add a few features at a time as requested
> * Added a missing call to rxtx_unmap() in ffa_relinquish_resources()
> * Assignment of "ffa_enabled" is kept as is until I have something definitive
>   on the type etc.
> * Tested with CONFIG_DEBUG=y
>
> v3->v4:
> * Missed v3 and sent a v4 instead by mistake.
>
> v2->v3:
> * Generates offsets into struct arm_smccc_1_2_regs with asm-offsets.c in
>   order to avoid hard coded offsets in the assembly function
>   arm_smccc_1_2_smc()
> * Adds an entry in SUPPORT.md on the FF-A status
> * Adds a configuration variable "ffa_enabled" to tell if FF-A should be
>   enabled for a particular domu guest
> * Moves the ffa_frag_list for fragmented memory share requests into
>   struct ffa_ctx instead to keep it per guest in order to avoid mixups
>   and simplify locking
> * Adds a spinlock to struct ffa_ctx for per guest locking
> * Addressing style issues and suggestions
> * Uses FFA_FEATURES to check that all the needed features are available
>   before initializing the mediator
> * Rebased on staging as of 2022-06-20
>
> v1->v2:
> * Rebased on staging to resolve some merge conflicts as requested
>
> Jens Wiklander (9):
>   xen/arm: smccc: add support for SMCCCv1.2 extended input/output
>     registers
>   xen/arm: add a primitive FF-A mediator
>   xen/arm: ffa: add direct request support
>   xen/arm: ffa: map SPMC rx/tx buffers
>   xen/arm: ffa: send guest events to Secure Partitions
>   xen/arm: ffa: support mapping guest RX/TX buffers
>   xen/arm: ffa: support guest FFA_PARTITION_INFO_GET
>   xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h
>   xen/arm: ffa: support sharing memory
>
>  SUPPORT.md                           |    7 +
>  docs/man/xl.cfg.5.pod.in             |   15 +
>  tools/golang/xenlight/helpers.gen.go |    6 +
>  tools/golang/xenlight/types.gen.go   |    1 +
>  tools/include/libxl.h                |    6 +
>  tools/libs/light/libxl_arm.c         |    6 +
>  tools/libs/light/libxl_types.idl     |    1 +
>  tools/ocaml/libs/xc/xenctrl.ml       |    1 +
>  tools/ocaml/libs/xc/xenctrl.mli      |    1 +
>  tools/xl/xl_parse.c                  |    1 +
>  xen/arch/arm/Kconfig                 |   11 +
>  xen/arch/arm/Makefile                |    1 +
>  xen/arch/arm/arm64/asm-offsets.c     |    9 +
>  xen/arch/arm/arm64/smc.S             |   42 +
>  xen/arch/arm/domain.c                |   11 +
>  xen/arch/arm/domain_build.c          |    1 +
>  xen/arch/arm/ffa.c                   | 1827 ++++++++++++++++++++++++++
>  xen/arch/arm/include/asm/domain.h    |    4 +
>  xen/arch/arm/include/asm/ffa.h       |   78 ++
>  xen/arch/arm/include/asm/regs.h      |   12 +
>  xen/arch/arm/include/asm/smccc.h     |   40 +
>  xen/arch/arm/tee/optee.c             |   11 -
>  xen/arch/arm/vsmc.c                  |   19 +-
>  xen/include/public/arch-arm.h        |    4 +
>  24 files changed, 2100 insertions(+), 15 deletions(-)
>  create mode 100644 xen/arch/arm/ffa.c
>  create mode 100644 xen/arch/arm/include/asm/ffa.h
>
> --
> 2.31.1
>


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 10:59:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 10:59:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422767.669022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIPn-0004xj-9k; Fri, 14 Oct 2022 10:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422767.669022; Fri, 14 Oct 2022 10:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIPn-0004xc-6F; Fri, 14 Oct 2022 10:59:43 +0000
Received: by outflank-mailman (input) for mailman id 422767;
 Fri, 14 Oct 2022 10:59:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojIPm-0004xW-Ia
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 10:59:42 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80042.outbound.protection.outlook.com [40.107.8.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d760819-4baf-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 12:59:41 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PR3PR04MB7212.eurprd04.prod.outlook.com (2603:10a6:102:8c::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 10:59:39 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 10:59:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d760819-4baf-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gdwqBLsGR6z0unlWkQ2kiJX72FXwn6uJ8fkOqzYxCs9rgpvAzBdfkdzKCSwa/gRLeCUtUDuR8W6yrW0jxk7E0TURepjRh8W5BFzFClZTrsBckDkUYHqdgKtJHH7rctENVV2Rj0Nj/0vpYHwUStyIPrLR0tL6LddMxikWthhlB3VLs2mQphtsXwBK3x5TgGhgDSXNiKJG/ISG6kNkMAEIvF2vZJkIQiTVeNzfC2KEU2kveTR0xdD1GGpfIQY9GG+2NDLZ/yuQHZUOijGXKmOFI6L+u6Yx/89kbYAG/cv1USGigDGjcBABjHQKbYFj23Y3ipQn0oF4gKcAZn+JjbC+cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6iqmbL5oucMnsSVY5xfcBr49F+PoJ5RNN4o392i2tN0=;
 b=dpLUDSlPOsv8wVpyWeDMbuk5HxbtmQsv8bMuXrUJClKWfxsjDx7kuESd1x2Zz+VdYIxFXE+V98kCK5GLgjnA+/lOCNxobWcaj5plQGwqtSl/ITKPfRBim4zPuqt7gBbOqfhuUX7VABnoHzRacjRMI86Sq8DYNnYnZpU5aawkPG1k/hUTvGw/E35MMGvxo8Fwo++Vr8IhHbt5fQvYw+7SKxiJQK1+k9PoZ1e44N5/KB57Mht0q79U5Ryd40mFEIVUCuXpvShtW1YErF6PMDU8Kujz0hAqASKs1XhTeYoafQoamypvl4GsvHopZ/uclHX1RPpkckEVK9bPtjFqLWmVBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6iqmbL5oucMnsSVY5xfcBr49F+PoJ5RNN4o392i2tN0=;
 b=iZGlTlaWYjjuGD7/d+juIG1JQKVPuosZ5PS6U+Y2TY1xrtVvm8y3GuYXx45iMBRsj7XonxOi6N4StYSmCvFnttX1QI+uOScDNXeXpItGL1DUEcKR0Zf8C91uQrOrrpGZMye+tCpRdiLTIur16Y1z/7K+VF4StH/xHLObCu7enXukPlWuToXXcnbN3LRcMTB5lSk97BrX/K8YEO9tSLtWVFWEtPM5MHdP0HixwVWkXyMnYHPRwN10UE7sAFjf7uUCNDOcq5uXAzabxzn1LAPcpFPxs0/1E3T1QJIu3ffqD80F4/mQjnklcu3/tht7UOT/82tLRmKqGtk/Ohs9pDOX6g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e60803a6-44c5-9d22-88b5-c924ee854fca@suse.com>
Date: Fri, 14 Oct 2022 12:59:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
 <AS8PR08MB79919FFC44E975825EE9CB3392249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB79919FFC44E975825EE9CB3392249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0111.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7212:EE_
X-MS-Office365-Filtering-Correlation-Id: c53fecb2-b769-4e6b-55c7-08daadd330bc
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Is8WYn8m8UmhqmZ1op8bzPhwi8jA0jE8TDt5abyByXEIfCigkKCN+JocHW7RL4Cu1mUhBf4kGAbrS3zYh2qB2GSCLPnc32uaRb8AV74HbNJvRH6ILVJHilLHn066ROML1ScY/9W9vdKVr/ncFPL2DQk4TN3XihH5+zMhhDlklAXcUK5tiZ+/Rc/8t+T5oROxycqyzzJOKv2dW282/0kkkOYhgIaDGs4W8OsiTK82eDk1Oee5tvK6dv8vuXSXqirxj4qajnI620q4P8vQcSniiJ2Z/ye7R0PrutUZuWhmPqDvYx1/UX+wbQFUUqVhc/gXKLGzupkQe04+y7igXwu9mCpqecQtyidDNhR4p8J7V++vuhUUxxCUrZ7yGuxwVeuFliNx0TZFLKBdiJHS71Pzowwr4AkMosSByUwQQXoHKutQipgGmURjpQnEbAY+7sCrmbdAwzUcUD1ZFYYU/ghY1voh1x2t3om5dfgPAI2Y7jxf4Q6sLXn4NmSjUy8UM8Qr+zQe+u2gelT2K4krFTIo7lYX151r+8ZyQlZ1by0WI9+EZkrjTtllHAZZ+BCTOlDjuPzoiZ+apgowueVzyGeOc5QfCEvCsh6j0A2Rr4drrwPT30450EOMyDTZAtezNNx3LzkcSUZCZltj+aH/DMjnlAVYyVBayL7izL0BKDtxlo5TMZ386i3Aipad8ynxmcP5zJPDraYAwRxwlXrqINLsV6BpL0jEFspYX0fuj3rN26ag5hPpM+M424QxGRY2at1GrPuOpz/AaaPZxEsxwYqKDJkxhpt13lf95U0DJ97tvNA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199015)(6916009)(54906003)(316002)(66946007)(6486002)(8676002)(66556008)(66476007)(4326008)(31686004)(478600001)(41300700001)(6506007)(53546011)(6512007)(5660300002)(8936002)(86362001)(26005)(31696002)(2906002)(36756003)(83380400001)(186003)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXdsZEhUU3FFdXVXcGNUQ1VabEdheDhJVDNvQ1c2ZGc2cUNwUzViZUJZS2Uy?=
 =?utf-8?B?OHJISlNWV3hDNDEwQm02T21rekpKRGh4OVkrWmNIMjFyblBRcjJxVmVXSlB0?=
 =?utf-8?B?QWo0VmJqWFdXQXdLZzNDVjhTVHc2eE9vU3NBZUQ3VTV4Y2ZvWjlKTTg2cllo?=
 =?utf-8?B?RUExWDNsT2JpdlI5L2xmYTdSZlpOWllKbU9jNFVNc3VVM2NUY1F5b0QzQm42?=
 =?utf-8?B?bE1uN1lZS3dIR0MzNVZWakFGUHlTclpSMXBIWFM2R2l5bTlNVHNpMnVqMC9t?=
 =?utf-8?B?cEJ2TTZNamRIZ2lxelJrNmdka0E3RDd0VStJRlFSSUdaZFNZQmZ4WE10ajhL?=
 =?utf-8?B?NGRJM3hwaS9iN3B6WnBjMk5Rb2svdG5DL2FwT25JMkdRSnRtUkhuczYwRGxK?=
 =?utf-8?B?bGZQeHFwNVZJTFNGVHRvcE5uWGlOazBNVk9NRGZZUEZrVnhKU0QxMjF1RVRt?=
 =?utf-8?B?d0ZrSkZWeHFIV2gzR1l3Q3BlZ3dYN3N2cC9ZU2FDcytKTjVYVHZweW9Ddjh5?=
 =?utf-8?B?ZDVoTGNGd05uL1NZc3ZwV21PYmY4eXJoRnpYVEErMmpHeGJuMG1zLzJkdUhE?=
 =?utf-8?B?eG9xb3hBSHRRNTBOTDIzV3R5VFhLeFZ3MytEZ0s4cXUyQmVpdS9uMTVWcElU?=
 =?utf-8?B?ZzRKTGY1VXFVTEM4UmY1ZGZTSWN6TDRnSitHZzlrK29pNGEvM2dyNmZuNTdj?=
 =?utf-8?B?Nk1jRGpkUUtVTFhINzR6TVYwM1lEa21RZi9rcm4yTmhUYmRPdDFEMkg2aDBG?=
 =?utf-8?B?NG1sY2I1cXZ5VHNxVXJ2bTZLT3JXaUhMN21aWkhISnhmc1B6Ym5Qa1UzN0Qx?=
 =?utf-8?B?RkM3RmxsOHlPSnQrQll5NmVsQVcyYkQxL2VKYUxVS3pnd3k3dUpXZkpFek1O?=
 =?utf-8?B?SnI2bVpOQm9BbVMzS1MwK284SUdNNmNuN0Jac2trdzE3QWE3anZGQzlwYmFn?=
 =?utf-8?B?ejNPdTlxV0prMmV2V1M1OHdLUUx5ZStGUENmend3dklhRkM0Y3pTMkY1TGVV?=
 =?utf-8?B?OWhHZTIrWG5xUkFKQmRrd1REejFzWGdTUEttYTRFejhJWEo0TlRKZmxubGJG?=
 =?utf-8?B?SGxycGgyTEI0dElEY1RFZzg1RzQ1cGV5cHlickEyMjFqU1FPVTJ1L0FCczRV?=
 =?utf-8?B?dDZaK2Z0bDdpT1FtSnBSY2k2OGpROUxNMWREY1dORlRsUTlUSHVJZHFaR2dT?=
 =?utf-8?B?OEZDSmtpeUd1dGNRNUJjSjBld2VLKzYrNWVpelI5ckhCclZ0QkVlazNENk1F?=
 =?utf-8?B?c0IzRUNwdThsUVlmWW1IWldJdHE5ck5yV29vTXk1eS80dFdrNmMxdU80NWlF?=
 =?utf-8?B?N1hBNnhyNE9Pdy96NnVVYWd4Ykp4b0pyOHhDaXkxK2V0TDQzZTExL25vK012?=
 =?utf-8?B?UjNPcUFzV3l5WmpaeSs0dEVLdTBRT1hyRVlLdmhaaVRnbmZueDJyYzArVDJX?=
 =?utf-8?B?OGgwSHJNSG5EdG9CZUtGdVM5L0ljcDdtVnMyeXh1MWRwUFQvOG5uZFdUbFpR?=
 =?utf-8?B?U2NObXMyYytJZXZ2cTZvNldFYkF1TjM4Nzd3K05UN3g3emthMWVDZEpLUnpW?=
 =?utf-8?B?V2dUQ3p0NVlLeGNON1JFcEdIR2lwWllhNzROMGdKNkI1VU9kL0NWZ251WlRo?=
 =?utf-8?B?eFVIUFpiaXFETjRTYWp5QUJMNmkvQlp1TGtrRkd4OTlHSVRKZ0tsMkE4UlN0?=
 =?utf-8?B?SUVPalFISVNvVEdadWRrd3FHYnpXWk80K2h6WnJDeEFTbU8yWHdPR0l1bCt3?=
 =?utf-8?B?eWJjTVdNMWFCSUpZa3haQ1lOcFl1U29OT3ppT1hNUGdUdlJjS2U1dnBuMDFr?=
 =?utf-8?B?VmJrYVBPT0pvL2RlUmwvbDZlVThxNFRFRVJCTkJoVFpLbXoxTHMwRTZoL1hQ?=
 =?utf-8?B?MDNNN2N6dUlkckRPTjBJTW83YTFLb1doOGtGSGZieGh3N25CNjMvcXQ2Z3o2?=
 =?utf-8?B?Q0hkTUJkNHpxUm1NNURaemFlbERQWXJZZEg5V0EwNUUyL1VzSjRpbTVSTmM1?=
 =?utf-8?B?WVFibmFoQ2NUWGJYUDNEbVZGUG5JZWxSQ1VzSzhIMTlPZkMraHppK0w0RXZq?=
 =?utf-8?B?S0YxNE5QL2dOZWovNElmaXNtTTJ6U0toVlpzdjZCNUwxbEt5U21Rb1RBZjBE?=
 =?utf-8?Q?d5PuPUY1brqzQwgMWblRiHE0d?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c53fecb2-b769-4e6b-55c7-08daadd330bc
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 10:59:39.4637
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7Q8RH0K4Xxbp+tHv1L37vNF2gNyGhHLR34wk7YDPtgLRwQWBh6HeWoGIsv6+h6P2M3lEolF278V52rZoPn/cOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7212

On 14.10.2022 12:53, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>>
>> On 14.10.2022 12:38, Henry Wang wrote:
>>>> -----Original Message-----
>>>> From: Julien Grall <julien@xen.org>
>>>>>>> +    if ( d->arch.paging.p2m_total_pages != 0 )
>>>>>>> +    {
>>>>>>> +        spin_lock(&d->arch.paging.lock);
>>>>>>> +        p2m_set_allocation(d, 0, NULL);
>>>>>>> +        spin_unlock(&d->arch.paging.lock);
>>>>>>> +        ASSERT(d->arch.paging.p2m_total_pages == 0);
>>>>>>> +    }
>>>>>>
>>>>>> Is it intentional to largely open-code p2m_teardown_allocation() here?
>>>>>
>>>>> Yes, AFAICT p2m_teardown_allocation() is preemptible and we don't
>> want
>>>>> any preemption here.
>>>>
>>>> Like Jan, I would prefer if we can avoid the duplication. The loop
>>>> suggested by Jan should work.
>>>
>>> I am a little bit worried about the -ENOMEM, if -ENOMEM is
>>> returned from p2m_teardown_allocation(d), I think we are in
>>> the infinite loop, or did I miss understood the loop that Jan referred
>>> to?
>>
>> Where would -ENOMEM come from? We're firmly freeing memory here. -
>> ENOMEM
>> can only occur for a non-zero 2nd argument.
> 
> My initial thought is the "else if" part in p2m_set_allocation. It might be
> wrong. Would the code below seems ok to you?
> 
> int err;
> 
> do {
>     err = p2m_teardown_allocation(d)
> } while ( err == -ERESTART )

Sure, one of several ways of doing it.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:01:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:01:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422772.669032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIRF-0006KA-JX; Fri, 14 Oct 2022 11:01:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422772.669032; Fri, 14 Oct 2022 11:01:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIRF-0006K3-Gh; Fri, 14 Oct 2022 11:01:13 +0000
Received: by outflank-mailman (input) for mailman id 422772;
 Fri, 14 Oct 2022 11:01:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ux67=2P=citrix.com=prvs=2791c07bb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ojIRE-0006Jx-45
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:01:12 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 817a7295-4baf-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 13:01:09 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 817a7295-4baf-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665745269;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=IGFSSV1d7Ae6FTnu5GW6JuROhwpvMg8zftHSuhF01vQ=;
  b=O13lJvuygk0au1gqK5apveOCOAaXssMiWiLogff+wO7HOZ0tVBNPu+Gu
   P4AM6K6UPeHr8uA03jXmuks/pmjP7Dnu1uMuT8sigMG3nMkjxOMJW8Aie
   uXnDiRNrMRtXDOme7gRjGRqPHcvJ5Zh0NVBI0oG6XxI72KXpGLPXlolKh
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83155405
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0A7vs604Ry8WL9h69vbD5dRxkn2cJEfYwER7XKvMYLTBsI5bpzUEm
 DccWGCEPfqMNjP2KYpzPIyw/UwFv5+HmIBrHABvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpE5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUX2sR4H2htx
 cc4DzwTdyzfrMC/h5GCH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqOI4HXGZ0I9qqej
 ljI/GXdWxQfCIOC+2eM0y6uu8iTgTyuDer+E5Xnr6U30TV/3Fc7KBAQT0r9nvC/hWa3QdcZI
 EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW83uqCLjFaFHgbMoVg7ZJoA2xxv
 rOUoz/3LTNPkrKLQFGtzZezoS2rBXQ+D2ZFRhZRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnM/
 tyakMQtr+5N1JBWjs1X6XiC2mvx/caREmbZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV
 1BUypHFvIji4Xxg/RFhodnh/pnzup5p0xWG2zaD+qXNEBz0ohaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZp3k/i+SY2+C62MBjarXnSWXFbdlByCmGbKhzy9+KTSuftX1
 WinnTaEUi9BVPUPIMueTOYBy747rh0DKZfobcmjlXyPiOPGDFbMEOdtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGNrdJLcA5SfSlnbX00wuQOHtO+zsNdMDlJI5fsLXkJIuSJQ4w9ej/0w
 0yA
IronPort-HdrOrdr: A9a23:jlJziaolOvUrly9uL0QVVKwaV5oteYIsimQD101hICG8cqSj+f
 xGuM5rsSMc7wxhP03I+OrwXZVoLkmwyXcY2+Us1PKZLW/bUQiTXeNfBOnZowEIcheWnoU26U
 4jSdkcNDSZNykCsS+Q2miF+rgbr+W6zA==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="83155405"
Date: Fri, 14 Oct 2022 12:01:00 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [4.17 nice-to-have] Remaining Xen build output
Message-ID: <Y0lBbJB5XbfeusEA@perard.uk.xensource.com>
References: <c4b91289-82ea-dd97-a1f5-b168252eb826@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c4b91289-82ea-dd97-a1f5-b168252eb826@citrix.com>

On Thu, Oct 13, 2022 at 02:58:18PM +0000, Andrew Cooper wrote:
> Hi,
> 
> Having got Kbuild almost integrated, there are a few artefacts remaining
> which it would be nice to address seeing as out-of-tree builds is a big

Those would be nice to address indeed, but can those wait for the next
release? Out-of-tree still works fine without fixing those. The down
size is some output that doesn't seems to belong, and those command
aren't actually check for changes in the command line.

> feature for 4.17.� Picking at parts of a build, we've got:
> 
> � CHK���� include/headers++.chk
> /usr/bin/make -C include/xen/lib/x86 -f
> /builddir/build/BUILD/xen-4.17.0/xen/include/xen/lib/x86/Makefile all

I guess we could just hide this line with $(Q)

> /usr/bin/python /builddir/build/BUILD/xen-4.17.0/xen/../xen/tools/gen-cpuid.py -i /builddir/build/BUILD/xen-4.17.0/xen/../xen/include/public/arch-x86/cpufeatureset.h -o cpuid-autogen.h.new

> if ! cmp -s cpuid-autogen.h.new cpuid-autogen.h; then mv -f cpuid-autogen.h.new cpuid-autogen.h; else rm -f cpuid-autogen.h.new; fi

Those two cpuid related commands can't really use Kbuild infrastructure,
because the ./xen/include/xen/lib/x86/Makefile is also used by the
toolstack.

> � CPP���� include/compat/physdev.i
> � CPP���� arch/x86/asm-macros.i
> � CC����� arch/x86/boot/cmdline.o
> � BINFILE common/config_data.S
> gzip -n -c .config >common/config.gz
> � CC����� common/core_parking.o
> � UPD���� arch/x86/include/asm/asm-macros.h
> gcc -MMD -MP -MF ./.asm-offsets.s.d -m64 -DBUILD_ID -fno-strict-aliasing
> -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
> -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O1
> -fno-omit-frame-pointer -nostdinc -fno-builtin -fno-common -Werror
> -Wredundant-decls -Wno-pointer-arith -Wvla -pipe -D__XEN__ -include
> ../include/xen/config.h -g -mindirect-branch=thunk-extern
> -mindirect-branch-register -fno-jump-tables -I./include
> -I./arch/x86/include -I../include -I../arch/x86/include
> -I../arch/x86/include/asm/mach-generic
> -I../arch/x86/include/asm/mach-default -DXEN_IMG_OFFSET=0x200000
> -msoft-float -fno-pie -fno-stack-protector -fno-exceptions
> -fno-asynchronous-unwind-tables -Wnested-externs -DHAVE_AS_VMX
> -DHAVE_AS_SSE4_2 -DHAVE_AS_EPT -DHAVE_AS_RDRAND -DHAVE_AS_FSGSBASE
> -DHAVE_AS_XSAVEOPT -DHAVE_AS_RDSEED -DHAVE_AS_CLAC_STAC -DHAVE_AS_CLWB
> -DHAVE_AS_QUOTED_SYM -DHAVE_AS_INVPCID -DHAVE_AS_MOVDIR -DHAVE_AS_ENQCMD
> -DHAVE_AS_NEGATIVE_TRUE -DHAVE_AS_NOPS_DIRECTIVE -mno-red-zone -fpic
> -mno-mmx -mno-sse -mskip-rax-setup -fcf-protection=none
> '-D__OBJECT_LABEL__=asm-offsets.s' -mpreferred-stack-boundary=3 -S -g0
> -o asm-offsets.s.new -MQ asm-offsets.s ../arch/x86/x86_64/asm-offsets.c
> if ! cmp -s asm-offsets.s.new asm-offsets.s; then mv -f
> asm-offsets.s.new asm-offsets.s; else rm -f asm-offsets.s.new; fi
> � CC����� common/symbols-dummy.o
> � CC����� lib/x86/cpuid.o
> ld -melf_i386� -N -T ../arch/x86/boot/build32.lds -o
> arch/x86/boot/cmdline.lnk arch/x86/boot/cmdline.o
> ld -melf_i386� -N -T ../arch/x86/boot/build32.lds -o
> arch/x86/boot/reloc.lnk arch/x86/boot/reloc.o
> objcopy -j .text -O binary arch/x86/boot/cmdline.lnk
> arch/x86/boot/cmdline.bin
> objcopy -j .text -O binary arch/x86/boot/reloc.lnk arch/x86/boot/reloc.bin
> � CC����� arch/x86/boot/head.o
> � CC����� drivers/acpi/tables/tbfadt.o
> rm arch/x86/boot/cmdline.lnk arch/x86/boot/reloc.lnk
> � CC����� common/memory.o
> � LD����� prelink.o
> ld��� -melf_x86_64� -T arch/x86/xen.lds -N prelink.o --build-id=sha1 \
> ��� ./common/symbols-dummy.o -o ./.xen-syms.0
> � HOSTCC� arch/x86/boot/mkelf32
> nm -pa --format=sysv ./.xen-syms.0 \
> �� �| ./tools/symbols� --sysv --sort \
> �� �>./.xen-syms.0.S
> /usr/bin/make -f ../Rules.mk obj=. ./.xen-syms.0.o
> � CC����� .xen-syms.0.o
> ld��� -melf_x86_64� -T arch/x86/xen.lds -N prelink.o --build-id=sha1 \
> ��� ./.xen-syms.0.o -o ./.xen-syms.1
> nm -pa --format=sysv ./.xen-syms.1 \
> �� �| ./tools/symbols� --sysv --sort --warn-dup \
> �� �>./.xen-syms.1.S
> /usr/bin/make -f ../Rules.mk obj=. ./.xen-syms.1.o
> � CC����� .xen-syms.1.o
> ld��� -melf_x86_64� -T arch/x86/xen.lds -N prelink.o --build-id=sha1 \
> ��� --orphan-handling=warn ./.xen-syms.1.o -o xen-syms
> nm -pa --format=sysv ./xen-syms \
> �� �| ./tools/symbols --all-symbols --xensyms --sysv --sort \
> �� �>./xen-syms.map
> rm -f ./.xen-syms.[0-9]* ./..xen-syms.[0-9]*
> arch/x86/boot/mkelf32 --notes xen-syms ./.xen.elf32 0x200000 \
> �������������� `nm xen-syms | sed -ne 's/^\([^ ]*\) .
> __2M_rwdata_end$/0x\1/p'`
> od -t x4 -N 8192 ./.xen.elf32� | grep 1badb002 > /dev/null || \
> �� �{ echo "No Multiboot1 header found" >&2; false; }
> od -t x4 -N 32768 ./.xen.elf32 | grep e85250d6 > /dev/null || \
> �� �{ echo "No Multiboot2 header found" >&2; false; }
> mv ./.xen.elf32 xen
> gzip -n -f -9 < xen > xen.gz.new
> { nm -n xen-syms | grep -v '\(compiled\)\|\(\.o$\)\|\( [aUw]
> \)\|\(\.\.ng$\)\|\(LASH[RL]DI\)'; \
> awk < arch/x86/include/asm/asm-offsets.h \
> '/^#define __ASM_OFFSETS_H__/ { next } ; /^#define / { printf "%016x -
> +%s\n", $3, $2 }'; } > System.map
> mv xen.gz.new xen.gz
> 
> 
> Presumably all of these examples want switching from their current
> ad-hoc logic to a cmd_* based version?� Are there some simple
> instructions for how to convert?

There is "Custom commands" in "./docs/misc/xen-makefiles/makefiles.rst".
But sometime one wants to use "filechk" instead, which is documented in
"./xen/scripts/Kbuild.include", not sure it applies here.
As for the last part of linking xen all together from prelink.o to xen,
Linux have a separate script for that and don't really use the Makefile,
so maybe it's something we could look into but Arm and x86 have
different way to build the binary which make writing a script annoying.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:05:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:05:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422781.669047 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIV0-00072u-4o; Fri, 14 Oct 2022 11:05:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422781.669047; Fri, 14 Oct 2022 11:05:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIV0-00072n-1S; Fri, 14 Oct 2022 11:05:06 +0000
Received: by outflank-mailman (input) for mailman id 422781;
 Fri, 14 Oct 2022 11:05:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojIUy-0006zg-JE
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:05:04 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d655ebe-4bb0-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 13:05:03 +0200 (CEST)
Received: from AM6P195CA0070.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::47)
 by AS2PR08MB9341.eurprd08.prod.outlook.com (2603:10a6:20b:59a::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 14 Oct
 2022 11:05:00 +0000
Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:87:cafe::e0) by AM6P195CA0070.outlook.office365.com
 (2603:10a6:209:87::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Fri, 14 Oct 2022 11:05:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 11:05:00 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Fri, 14 Oct 2022 11:05:00 +0000
Received: from 1a001a0ea954.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 058FCDEC-C182-432A-BA59-BEA4D8624984.1; 
 Fri, 14 Oct 2022 11:04:50 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1a001a0ea954.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 11:04:50 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB9106.eurprd08.prod.outlook.com (2603:10a6:10:470::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 11:04:46 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 11:04:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d655ebe-4bb0-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=URDv07kzyKn++dAAhjm0guzY3IKUWavkt2EWoXVzHkG/DJldoFNRdPKZHDqL0CYvQA/9zsVnr0GDUyDgfjdcHv5P1XH/C6mq4j52fobmtcqNwCtyJ3nSx+STGQr2cWmqOwY19qe8m1ul5Igw6f12fP/ZnT+CvqnIliXuUqyVaQ0ilVBTbAZu5P/WlrnmmfyEOF8sNW2EmJaKUUn7HO9t9+TyNIpjZdm4dO9POR0rx/+laVS+k4oYWkaGhiuj+8OF1Vq38AGb/sQ7DsK0G+0Xrmn1RpueibPqBKIES1Jt479FoxIX+1a84wpev8c2l/LepjidTeBOVVL3tqiNpXlAVQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1WIx7+9Kmj0jZaJfjK06rhnidXq+sl8u1mnTolCGvrc=;
 b=DCHPbfVV8j8tbRMC3ZAcd/3dUF1+nVdapH7m+uvmB48T/TFTGY5R/d2Pi5tH4fuyN0Hu/eyzibElKUBdC6vrBvm3z2uaDaMq11YHiOxsSOyDGoeFH8Dt/4sAxuDf++rwyi9yvEY0ahoqi29zy77tGbwC7EZHZ2kvYg7B5w1/yHI2EVk/iO7UpYiQ/rrmoAQ7Rd2R96HzL+/axUkLMTK8mpbALcwUCFfM7rUiFn+ZyA9MGb1JmLPV4n+SNGsDrqLUApCXDak2YCaFVAAyIFBa/lcKqyM6vdydOOOX/8lHuY9rss8lx2KVg5aZlis5oUzfECoCzpqsmsCXCqOvRbYUPQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1WIx7+9Kmj0jZaJfjK06rhnidXq+sl8u1mnTolCGvrc=;
 b=Z2nqP4qsP9k2KQ9yVZrIyowetpN19UkQRd8OMrFiT9j+Qx/BLdt9es2L7rJ47gxtJNniTN6jiqGGyMUcmPv+wDNtn3BhtGm+pxAsdLuh9dcY566agi6rtweuAd7b5IVY22tB8j3rR1iizXiyaLOHU+1vD7u+IC/LQNzXN/v1VaI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UGfIh1GmoaNURPzh6anAQQ7Hl0mDuqQF0H5YBqJMwZ9NxzZLPis8inyKNxaGbY/z2hI3RwFqYElKYse8D2nmFV4MN3C4UJiTFpVQNkw3SL8uBiiWZihNQ9fZsAUvtsjfvdjXjyqeXpfQYenFIywE+nlcUh0RANuKCaURXmt7M+mY66UePxLniPRryE5Jy62eCL8OWcuKZzHpMZsU5UtGfj/pTEE11PSqCCzpJ3z5yZ0Lk2NtcvOhzQ4SrHfVkF2bPeVTRiUNn/xzzX6MICHQz4qd/rY0dG24qFOP7qGV9oPfnNtGgiHdZhKNGM/RNjqtaY7vPNvU2iOgqdHCAch8GA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1WIx7+9Kmj0jZaJfjK06rhnidXq+sl8u1mnTolCGvrc=;
 b=e3S2nkkoirzFPaXy8UPekxVUUYh3bBEcVFVc/Ik0OV7NSUhzUPgBzg+Ox9/6RVU4k20MXfVhJTALqWW9uWELZoSpYLF+8657/tsno1JA3bej7EnnZyTys53pzuPaiYP4nla3P+7Ht2LGfVxGfsr/fGs7xHVVdi0wzYAAyAh45WTnWqQedvRx+cSm96SKUA8uV1Zm8pj/HQ9myK+zGOH88YAQ4vYPzcdFg6s4/EDotMg46N+PlhaaSrHTBhTCM195HY/oxI3RESpNnJuVfESakUyoT2kveTKtMBXiMKp7XY/ZJ0nu6XTBT3AhRoRrEqHX7oRRTFsms6uLqoEaLCigTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1WIx7+9Kmj0jZaJfjK06rhnidXq+sl8u1mnTolCGvrc=;
 b=Z2nqP4qsP9k2KQ9yVZrIyowetpN19UkQRd8OMrFiT9j+Qx/BLdt9es2L7rJ47gxtJNniTN6jiqGGyMUcmPv+wDNtn3BhtGm+pxAsdLuh9dcY566agi6rtweuAd7b5IVY22tB8j3rR1iizXiyaLOHU+1vD7u+IC/LQNzXN/v1VaI=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index:
 AQHY36RSrOIThkYtnEq9RrtWc+uYX64NnUwAgAAAd5CAAA4NgIAAAPkwgAAIMgCAAAAtcIAAA6oAgAAAMLA=
Date: Fri, 14 Oct 2022 11:04:46 +0000
Message-ID:
 <AS8PR08MB7991A81D931E20A000FEFE0092249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
 <AS8PR08MB79919FFC44E975825EE9CB3392249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e60803a6-44c5-9d22-88b5-c924ee854fca@suse.com>
In-Reply-To: <e60803a6-44c5-9d22-88b5-c924ee854fca@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: D5726570D288FA40BC2055DEE1488B4F.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB9106:EE_|VE1EUR03FT009:EE_|AS2PR08MB9341:EE_
X-MS-Office365-Filtering-Correlation-Id: 100f8650-d8f6-4a69-eb89-08daadd3f00a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 909RvsrqfQq0BhfKXT+x7fMzVcBeTcGImn58xkaS2NLgOCWFyQK8Df1lUkbZEKaOuRR/qvu9UPKRSSrm+0BkchtWKIGGDVL80F3O8faX4r5db+ig4GEp8D51GIGFX1209my99w2ezV8ohsVTdgSvFPOH1ydhVqpAmCVrmXfNVfx7cO5S37ggYYTndvo5mEV8RRLH/XLauN/oI3w7nR/WKaUMNtnXsNYidcBPHm442D982bPm4Mr2YNV6QtyePZ8qI1mkUcB8Or8SLg+Vjwz1wzqGjTrhwBzqjye8tp3FfIN6zeO7KWOYTW5Sw6OPMQdy0Ecdte17W/FKTlxHc3MzMJICoskgUad7fXvX7E09FBqFuV1R6LPLQPOJLyN/WKilbXKS6ijmZazcMXsPPAqgOfEA20dUHFvQ7TA435mbvXvJbySXjR+ojiH0ZhvhffSnkbruJDYDm+voe7hxnUQctmP+9ZMIBvoS4bmZBAbWcWtWJCpRO8yUxPYZun5SOhxAtNFR2rDB9P77C3PkIwTpSKZOaJh1ougYcdYXrgYxaKnpUWp9CIZoGX+cHcbXlN2kC+Z139C1PMKrc51F06gO/Nc8krG+uRPI7/v1ib3Ji2FRkPLGNebDaHd89Mf+3R44TFwPPGPJ2tF0W61UKj3RZr3jLBCsHkw8W9OCkLbGFXKpi7IfVhQtKqY4pU89wkoQZV2D/ihN3xkDWm8q0HTB5O1wlbgkd7es3ijuBI6t0wf/9/XkDEJ5zxwzxm3R3kLKHqxIAW9HrTUeJLyaMrjTeg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199015)(54906003)(6506007)(71200400001)(9686003)(316002)(38070700005)(4326008)(83380400001)(7696005)(55016003)(4744005)(41300700001)(8676002)(26005)(2906002)(38100700002)(6916009)(52536014)(33656002)(76116006)(122000001)(186003)(66556008)(66446008)(64756008)(86362001)(66476007)(478600001)(66946007)(5660300002)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9106
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	13ba4365-38ee-4f9d-096a-08daadd3e79e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	r3iJVpfUTKOdCA1CZ9YZmyhH/5JXE8lmOLJN1kL3rLV9DG9W1W+EzNemKwMmQRw7JyCO2gFOzQ4RwbNu6PCtRfDvKq5uy+3mp+eowWEIXTXNWwFn5k2a4fkXyGbz+W6RCu68bZvOcoBKW8p6pE5Bi42lL+64Izc8R719CrgCiBGph1wphyxZ+e47w21Kb+FoFVdEi9ig40DQnFmvNoveMilV828VuYyUAAy/WgML9/SN48hTm9IcYsMKidxJSvVJE8VsdPbU5YmigKgcv10sJC/Gaag/PFrAdCKEuOrI33v0ogqrwiKPvPNawjEo/+GbswrJ5swsNJaI/Pw/UVjuKSOX+1dj61eDsekKyKmBpSFQxMSpFMRitK0OpM+NKwmObU+MISoY+f8f5aN5GyMRBxUmWGnMiJlbhxIskfjyKIUYP2ldmfaYCrUWuXaCOIFAKe1FtUnboeMiyIUhYlXUsDl4+92nNgJcKhepf4LApDxe0qYWutrNjdj0b556iRAciKwDoP292ULKql5artj9ZLNvCsfmoy7mdOeRf62a0AUHUXH4W5rykj/qfSh9EwvMpPbvabuBdnITM2HCOmwiVTOnBAUUYuQdTS/Ubz33Tq2RfDwcMeuV4NSMkD1oNjdJ1s5VKJeT5wYdBREKtiWuM+DuiAeut/VXGs+rD0+WYhK00/w+A6FC9bMa2qKIec2IXvpCe5MUWGjOsCg6CweXFUywLWv0lOxTuKsVFA8haQ+zlILTW11tBQSPun4WRpA8zNTyuMlwz7ywOSx0yYGtzg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(9686003)(8936002)(6862004)(2906002)(47076005)(81166007)(26005)(40460700003)(52536014)(70206006)(478600001)(186003)(86362001)(33656002)(41300700001)(356005)(336012)(8676002)(6506007)(70586007)(82740400003)(7696005)(4326008)(54906003)(55016003)(82310400005)(40480700001)(83380400001)(316002)(36860700001)(4744005)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 11:05:00.2205
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 100f8650-d8f6-4a69-eb89-08daadd3f00a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9341

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2Ml0geGVuL2Fy
bTogcDJtOiBQb3B1bGF0ZSBwYWdlcyBmb3IgR0lDdjIgbWFwcGluZyBpbg0KPiBhcmNoX2RvbWFp
bl9jcmVhdGUoKQ0KPiANCj4gPiBNeSBpbml0aWFsIHRob3VnaHQgaXMgdGhlICJlbHNlIGlmIiBw
YXJ0IGluIHAybV9zZXRfYWxsb2NhdGlvbi4gSXQgbWlnaHQgYmUNCj4gPiB3cm9uZy4gV291bGQg
dGhlIGNvZGUgYmVsb3cgc2VlbXMgb2sgdG8geW91Pw0KPiA+DQo+ID4gaW50IGVycjsNCj4gPg0K
PiA+IGRvIHsNCj4gPiAgICAgZXJyID0gcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oZCkNCj4gPiB9
IHdoaWxlICggZXJyID09IC1FUkVTVEFSVCApDQo+IA0KPiBTdXJlLCBvbmUgb2Ygc2V2ZXJhbCB3
YXlzIG9mIGRvaW5nIGl0Lg0KDQpUaGFua3MgZm9yIHlvdXIgY29uZmlybWF0aW9uLiBKdXN0IHRv
IHBsYXkgc2FmZSBpZiB5b3UgaGF2ZSBtb3JlIHNpbXBsZQ0KU29sdXRpb25zIHBsZWFzZSBkbyBy
YWlzZSBpdC4gSXQgaXMgYSBnb29kIG9wcG9ydHVuaXR5IGZvciBtZSB0byBsZWFybiBhbmQNCnBl
cnNvbmFsbHkgSSBhbSBub3QgYSBiaWcgZmFuIG9mIGVpdGhlciBkby13aGlsZSBvciB0aGUgaW50
cm9kdWNlZCAiZXJyIg0Kd2hpY2ggaXMgdXNlZCBvbmx5IGJ5IHAybV90ZWFyZG93bl9hbGxvY2F0
aW9uKGQpLCBjb25zaWRlcmluZyB0aGUNCnAybV9maW5hbF90ZWFyZG93bihkKSBoYXMgYSB2b2lk
IHJldHVybiB0eXBlLi4uDQoNClRoYW5rcyBmb3IgeW91ciBwYXRpZW5jZSBpbiBhZHZhbmNlIDop
DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KPiANCj4gSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:05:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:05:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422782.669057 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIV6-0007Kv-Gs; Fri, 14 Oct 2022 11:05:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422782.669057; Fri, 14 Oct 2022 11:05:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIV6-0007Ko-Dz; Fri, 14 Oct 2022 11:05:12 +0000
Received: by outflank-mailman (input) for mailman id 422782;
 Fri, 14 Oct 2022 11:05:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIV4-0007Jv-Jx; Fri, 14 Oct 2022 11:05:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIV4-0007Io-JA; Fri, 14 Oct 2022 11:05:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIV4-0000aw-7E; Fri, 14 Oct 2022 11:05:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIV4-0004gP-6l; Fri, 14 Oct 2022 11:05:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bobBMnfG9OzB91eoY7cg/qaGakdOx2naQY1VEMBbAUc=; b=SW3safl8nV7cLXZdzFaVq1JI9I
	uQqaqAb/VGUf3g81V9hlI9KL3kvKoKw/iuwAeazNS1i0zHLVv5JY2i/T/965LI77MGe1XMXAmvuU1
	AmNnE69A5GbGTTyywM50b2IAb1Es8V2p16uj2g4G27QdLRj2kTEcCc5xHIuhOB3SY+ME=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173739-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173739: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e0200cc47a691291ce1ad0207678a2db12d6503f
X-Osstest-Versions-That:
    ovmf=5bd2dbc6982734132debd8311a417f5a51daa644
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 11:05:10 +0000

flight 173739 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173739/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e0200cc47a691291ce1ad0207678a2db12d6503f
baseline version:
 ovmf                 5bd2dbc6982734132debd8311a417f5a51daa644

Last test of basis   173679  2022-10-13 05:20:12 Z    1 days
Testing same since   173739  2022-10-14 02:40:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chao Li  <lichao@loongson.cn>
  Chao Li <lichao@loongson.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   5bd2dbc698..e0200cc47a  e0200cc47a691291ce1ad0207678a2db12d6503f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:19:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:19:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422796.669069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIjE-0000pn-Re; Fri, 14 Oct 2022 11:19:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422796.669069; Fri, 14 Oct 2022 11:19:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIjE-0000pg-Om; Fri, 14 Oct 2022 11:19:48 +0000
Received: by outflank-mailman (input) for mailman id 422796;
 Fri, 14 Oct 2022 11:19:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojIjD-0000pa-Qx
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:19:47 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20086.outbound.protection.outlook.com [40.107.2.86])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1b57c6ba-4bb2-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 13:19:45 +0200 (CEST)
Received: from AS9P250CA0009.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::18)
 by AS8PR08MB9119.eurprd08.prod.outlook.com (2603:10a6:20b:5b0::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 11:19:39 +0000
Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:532:cafe::a2) by AS9P250CA0009.outlook.office365.com
 (2603:10a6:20b:532::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Fri, 14 Oct 2022 11:19:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 11:19:39 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 14 Oct 2022 11:19:39 +0000
Received: from ed5cc8a2ff1c.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3C2B00A2-8B63-4F35-86F5-332C17DDC97F.1; 
 Fri, 14 Oct 2022 11:19:33 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ed5cc8a2ff1c.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 11:19:33 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PA4PR08MB6239.eurprd08.prod.outlook.com (2603:10a6:102:ef::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 11:19:31 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 11:19:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b57c6ba-4bb2-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=bUbA4VRLYaUMdCuev2kIgYvjoAe24wWFzinxQGSKE5o+vtnhlM2UlDbydns0wQEaEoaMpybS53gi749IxbXkSd+WF04DebA9Ch9otpUCFlmKXUwScYHnDYwrDwM9IUMp9RjGHCF3V5fS1BdtohhDcG88/yCUYVcUcHk2aApcCmd3XHjRNH3ime4r9Smw0s+WcNBE9X+3LBqQplMym3mSNvVJ9UBoaHsLsqVHGn3eGztoOFoD0qguTiVXxVOaL5coUNDATYv6fmIo/oCwy9cTkmPXHkPJMJoSJf2RfDMZnMjjo/AYZFpAa5ABreAquoathwOLtjMqh/UL4yaYIt+0wQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VKeH86N2pPjp35fhhl/nBPKsW6jJKRt2H1dEOdWCLaM=;
 b=YlQAe6420+HWKXbPp8HY7TwczGK/6lxFECD4Zya7k60ZcmxM+/yKO/1TX0MzG/s46KpiX7GClmWHOUGbHX85X2AzCg2TinxrDjV8yCGkAHA+7ktajODHZfgvC0/VcWL14eucKD3lNMv1zYZTmiFieCoCJpQCKRSwAnPUtU4vlYa4HTWfXMUQewt4W5E1Er7vK/03sMkqYFn3oRdf8ZW9w7SlCEWZGsY1qvP3OsP3mJ5/Tsiuo74kuijjZaAMDnn5l903bFSovW43BnGS41sBr3/qdoomGVy3UzCVEm2seYQjLxPW7WegJgQMzC2abBGSEQ3UGpC7MFmWMTxHK/oi1g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VKeH86N2pPjp35fhhl/nBPKsW6jJKRt2H1dEOdWCLaM=;
 b=quTWPgrCGhvazWSNbUcHt+Mp9pwaQnVe0I5YiCZyuzZnO9g6cUIIOirl7Oa9Xg3qlYBBTeGEbf1SD/2QUHW4CtsedaQcG4FX0iQ1kbsrIWGUPvVBCWUi/bleec8Iw/hhHJvxvUm8pkdXxsKvymn7TSroXVFbBksrYn8gdmg5sP8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JYR1CNtoq3osnDAwwDEpfxQQGdZ+E4SVpg7iI71Kin2OnU2yUTEZbjbwtIBBaACncJO9yA8CAQh050nPCDzOd3Nt+ms6j/6FbcBoi2Kpb9GNjN7R9ZFrfhUW1wY5dTxkF+LWcvllsX3f+C+2t02I8wAkVscRrYI0eoufdRNLQ7XtPHny4i2BsfuWoZShNZSXxYQRKEalevYNuDQMchibVGRpCZFXXWBS3Ml5wNOtBmWZ8c8yyelljsqHSY6Yl7BWTBptDsbf+HJ/q/ymxn3PZGHwRSbWP07DBZVa2/Dm+oJUVYovUGS00T7VT7jSW8SW7Z7xWBs7FzN5oDA/pEFECw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VKeH86N2pPjp35fhhl/nBPKsW6jJKRt2H1dEOdWCLaM=;
 b=K1wtFNkKo0Pg6SwypyJQyXLYjfdnK9WQ5i3V3qiJNHbb8Q1iXNvA9ScPH7SbEAX6kZxnJOE1l951ETBVkJ+4bwqamKQXorp9QoyBVj3hBkYv9aZCdDw7rIpvb5DhiBbJnF453mfouvNf4BaEZ4j9UEMQuZ4GLIlmL/9dIxdDUSdYl2IZkhPfzzMiyLl2bt27qlvum16VTd/Bcdy49UIIugH9obwUX9nic+BZgNX9NNS5C1DU2droQ3zrNetev+AiwzcQ7alzcMLLP8cmP1blP8MsRPKb00wNJohD2ulREUWab944uPYxjGVaS5Z/4Upz+JZT7ezu20CxfzF0/t9pqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VKeH86N2pPjp35fhhl/nBPKsW6jJKRt2H1dEOdWCLaM=;
 b=quTWPgrCGhvazWSNbUcHt+Mp9pwaQnVe0I5YiCZyuzZnO9g6cUIIOirl7Oa9Xg3qlYBBTeGEbf1SD/2QUHW4CtsedaQcG4FX0iQ1kbsrIWGUPvVBCWUi/bleec8Iw/hhHJvxvUm8pkdXxsKvymn7TSroXVFbBksrYn8gdmg5sP8=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NsO2AgAACdYA=
Date: Fri, 14 Oct 2022 11:19:31 +0000
Message-ID:
 <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
In-Reply-To: <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 7ECF97F8DFD8F64A88FB34C0BC660E96.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PA4PR08MB6239:EE_|AM7EUR03FT031:EE_|AS8PR08MB9119:EE_
X-MS-Office365-Filtering-Correlation-Id: a2b433eb-bafb-4da1-f312-08daadd5fc00
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 u8Nl8QtlIuCyAWqqU7hcTbod7Bt0MNfGT4fC1+M846GDGuJMSWkh/HLoyJAD1ChB/UuOZ/9+hqLY+s29xe6TJUWbQ8QhVCaVYYoAhJ1mFJCUYXKBxVCJfi9W6Gm539sZw/afglj1d1MeDhR0AN/9Sb/n4hvpPOWEgWygP+YaoJ+ke+9EnNYUrRf/WpGMgrCykuIrG6v084Tgp0SYfIX50G/TLAZP59THViQR8L0Buxb8MK1tVMvGUh4ULUFQ7n9+V+mWutlxn0W9vYYdSHi5VdJjZePNd/pm8fUm5gFN6YvoVPVsTO+0MKKbUkK/q2NxLRE1uhNDCDYnCcwSEg8b0bL6zoVtwkl0zgYFVTbCRWTgJK78aaPjkpi/8984q2Eo7JEG50HVXexKpGcLCGmDd7uB3kKeYxSYwQVv5TyHwCqKMaog+HPZVEENdvE8zHnjd+lgj7ci3wjqO2WTAQq3RJjY6UL51Lm9ATpNRkbj2iFDCsCMQK5opfw/Nr3VDH0VoF/jNI4RNTkH42/+OoxsjW9cEzgdK+eY/HP5dHolSSug5TmYyrcVvFghj275IrLDjqummZ5cyDuMy9nGAqWlAoNZOhjiPpKb0XQhXewPmQW4g3jSfzcFoiQL0QS8j1JF8No+UDoG82GnCbxNrhjna+/YcPQpiWZSaIRg8HVwvwGQeRVWByfyWFbZBm8Q/LaYvflLV6uAZFeXXSPruAHm8/uysQH0f+qLEmJMyuByVLyJgcLGku4AoEV3rCkwtj+cRLQm5U2B+Slitw2Zdfyaug==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(136003)(396003)(376002)(451199015)(38100700002)(52536014)(5660300002)(2906002)(41300700001)(38070700005)(122000001)(4326008)(8676002)(66446008)(55016003)(66556008)(76116006)(66946007)(86362001)(186003)(66476007)(316002)(33656002)(64756008)(478600001)(8936002)(9686003)(6506007)(71200400001)(7696005)(83380400001)(26005)(110136005)(54906003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6239
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a3b49dee-1bd8-460c-39dd-08daadd5f766
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GhoYNRHfSDfMZErI9g/kOCv+LotqgTSY4qMvZAB84P3oNAHXi00GamSnblodUweCjwC6nMGMc+77veDVq3dqQaNcDyHGfwNwZQer93wkE2FDqFYCvpEOjx1v+NbJ1hlKNfuVOG3bvve7e+H+ECogbZ6QXJaLl0tvdTX39nAKSU49YaIMgxMLdcN/KBRsYY0lG97+ZS6k74X/endoB+O7vAuxQQzgH75kcmEXHzmusuedwy4SRG1vJiDcOJr+5Va/2oOcKvVlOfYGZ4sgj0Q5Ce3VrsfN4uO7NbGPjyNHsSp+iG5cBe5o1w2s6J07XPInivfUGYfQzxdtRIuYAxLAjiOIrqNY6W22cCx5SpU1/ABxWUeg+EqFsenrmDGk0PU3ue5CUjb49cuLHvs84AfC3MOPZJyErFagoz1uBXBoz01g6AjS96tSLUtDItQkI2tJCRAa0zK8NfZFPh1RovjJY6QkjhcAdCI5t8QVFuIuVvuYF+XlfXEgRgjKHSqTferUx98RaVzfyzOEkRLzk4l7pVWZRBp6QTrmVQglGQaEaMYl39vZ2BK2RrSLc8ItNMEUEMdHhw6y4mUfwdGoIFneBm2bGb62MWzh/1au3fhomwymC9RoQCQdMfjOKjmorCeDTKDFl/cBq5kfIpW89x6YBYbv2Uy1rno1aC65OupXViELb17Mn5peG4FHElKWDrl/x8p4djMo85KWg5EFxPRsCHYDr7Usq3/t7FpBXb7tn2aKpeA/GJHD60vWtVe6MOOp0l1CAKP8DREfURd/NW+NRA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(336012)(47076005)(83380400001)(186003)(26005)(52536014)(8936002)(5660300002)(33656002)(2906002)(40460700003)(40480700001)(55016003)(86362001)(36860700001)(81166007)(107886003)(82740400003)(316002)(82310400005)(110136005)(7696005)(8676002)(4326008)(9686003)(54906003)(70586007)(478600001)(6506007)(70206006)(41300700001)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 11:19:39.3437
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a2b433eb-bafb-4da1-f312-08daadd5fc00
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9119

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIHhl
bi9hcm06IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4gYXJjaF9k
b21haW5fY3JlYXRlKCkNCj4gDQo+IEhpIEhlbnJ5LA0KPiANCj4gPg0KPiA+IC1pbnQgcDJtX3Rl
YXJkb3duKHN0cnVjdCBkb21haW4gKmQpDQo+ID4gK2ludCBwMm1fdGVhcmRvd24oc3RydWN0IGRv
bWFpbiAqZCwgYm9vbCBhbGxvd19wcmVlbXB0aW9uKQ0KPiA+ICAgew0KPiBJIHRoaW5rIHRoZSBw
YXJ0IHRvIGNsZWFuICYgaW52YWxpZGF0ZSB0aGUgcm9vdCBzaG91bGQgbm90IGJlIG5lY2Vzc2Fy
eQ0KPiBpZiB0aGUgZG9tYWluIGlzIG5vdCBzY2hlZHVsZWQuIFNpbWlsYXJseSwgSSB0aGluayB3
ZSBtaWdodCBvbmx5IG5lZWQgdG8NCj4gZG8gb25jZSBieSBkb21haW4gKHJhdGhlciB0aGFuIGZv
ciBldmVyeSBjYWxsKS4gU28gSSB3b3VsZCBjb25zaWRlciB0bw0KPiBtb3ZlIHRoZSBsb2dpYyBv
dXRzaWRlIG9mIHRoZSBmdW5jdGlvbi4NCj4gDQo+IFRoYXQncyBub3QgZm9yIDQuMTcgdGhvdWdo
dC4NCg0KU3VyZSwgSSBjYW4gcHJlcGFyZSB0aGUgZm9sbG93IHVwIHBhdGNoIGFmdGVyIDQuMTcg
YXMgKDEpIEkgYW0gYWxzbyB3b3JyaWVkDQphYm91dCBpZiB0aGlzIHBhdGNoIHdvdWxkIGJlY29t
ZSBiaWdnZXIgYW5kIGJpZ2dlciAoMikgSSBjaGVja2VkIHlvdSBhbHNvDQp3YW50IG90aGVyIHRo
aW5ncyBpbiB5b3VyIGJlbG93IGNvbW1lbnQuDQoNCj4gDQo+ID4gICAgICAgc3RydWN0IHAybV9k
b21haW4gKnAybSA9IHAybV9nZXRfaG9zdHAybShkKTsNCj4gPiAgICAgICB1bnNpZ25lZCBsb25n
IGNvdW50ID0gMDsNCj4gPiBAQCAtMTcxNiw3ICsxNzE2LDcgQEAgaW50IHAybV90ZWFyZG93bihz
dHJ1Y3QgZG9tYWluICpkKQ0KPiA+ICAgICAgICAgICBwMm1fZnJlZV9wYWdlKHAybS0+ZG9tYWlu
LCBwZyk7DQo+ID4gICAgICAgICAgIGNvdW50Kys7DQo+ID4gICAgICAgICAgIC8qIEFyYml0cmFy
aWx5IHByZWVtcHQgZXZlcnkgNTEyIGl0ZXJhdGlvbnMgKi8NCj4gPiAtICAgICAgICBpZiAoICEo
Y291bnQgJSA1MTIpICYmIGh5cGVyY2FsbF9wcmVlbXB0X2NoZWNrKCkgKQ0KPiA+ICsgICAgICAg
IGlmICggYWxsb3dfcHJlZW1wdGlvbiAmJiAhKGNvdW50ICUgNTEyKSAmJg0KPiBoeXBlcmNhbGxf
cHJlZW1wdF9jaGVjaygpICkNCj4gPiAgICAgICAgICAgew0KPiA+ICAgICAgICAgICAgICAgcmMg
PSAtRVJFU1RBUlQ7DQo+ID4gICAgICAgICAgICAgICBicmVhazsNCj4gPiBAQCAtMTczNiw2ICsx
NzM2LDE3IEBAIHZvaWQgcDJtX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpDQo+ID4g
ICAgICAgaWYgKCAhcDJtLT5kb21haW4gKQ0KPiA+ICAgICAgICAgICByZXR1cm47DQo+ID4NCj4g
PiArICAgIGlmICggIXBhZ2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykgKQ0KPiANCj4gRGlkIHlv
dSBhZGQgdGhpcyBjaGVjayB0byBhdm9pZCB0aGUgY2xlYW4gJiBpbnZhbGlkYXRlIGlmIHRoZSBs
aXN0IGlzIGVtcHR5Pw0KDQpZZXAuIEkgdGhpbmsgd2Ugb25seSBuZWVkIHRoZSBwMm1fdGVhcmRv
d24oKSBpZiB3ZSBhY3R1YWxseSBoYXZlIHNvbWV0aGluZw0KaW4gcDJtLT5wYWdlcyBsaXN0Lg0K
DQo+IA0KPiA+ICsgICAgICAgIHAybV90ZWFyZG93bihkLCBmYWxzZSk7DQo+IA0KPiBUb2RheSwg
aXQgc2hvdWxkIGJlIGZpbmUgdG8gaWdub3JlIHAybV90ZWFyZG93bigpLiBCdXQgSSB3b3VsZCBw
cmVmZXIgaWYNCj4gd2UgYWRkIGFuIEFTU0VSVCgpL0JVR19PTigpIChvciBlbHNlKSB0byBtYWtl
IGNvbmZpcm0gdGhpcyBpcyB0aGUgY2FzZS4NCg0KU29ycnkgSSBkbyBub3QgcmVhbGx5IHVuZGVy
c3RhbmQgd2h5IHdlIGNhbiBpZ25vcmUgdGhlIHAybV90ZWFyZG93bigpDQpwcm9iYWJseSBiZWNh
dXNlIG9mIG15IEVuZ2xpc2guIExldCdzIHRhbGsgYSBiaXQgbW9yZSBpbiBDIGlmIHlvdSBkb24n
dCBtaW5kIDopKQ0KRG8geW91IG1lYW4gcDJtX3RlYXJkb3duKCkgc2hvdWxkIGJlIGNhbGxlZCBo
ZXJlIHVuY29uZGl0aW9uYWxseSB3aXRob3V0DQp0aGUgaWYgKCAhcGFnZV9saXN0X2VtcHR5KCZw
Mm0tPnBhZ2VzKSApIGNoZWNrPw0KDQo+IA0KPiBUaGlzIGFsc28gd2FudHMgdG8gYmUgZG9jdW1l
bnRlZCBvbiB0b3Agb2YgcDJtX3RlYXJkb3duKCkgYXMgaXQgd291bGQgYmUNCj4gZWFzaWVyIHRv
IGtub3cgdGhhdCB0aGUgZnVuY3Rpb24gc2hvdWxkIGFsd2F5cyByZXR1cm4gMCB3aGVuDQo+ICFh
bGxvd19wcmVlbXB0aW9uIGlzIG5vdCBzZXQuDQoNCk9rLCB3aWxsIGRvLg0KDQo+IA0KPiBJIGFs
c28gbm90aWNlZCB0aGF0IHJlbGlucXVpc2hfcDJtX21hcHBpbmcoKSBpcyBub3QgY2FsbGVkLiBU
aGlzIHNob3VsZA0KPiBiZSBmaW5lIGZvciB1cyBiZWNhdXNlIGFyY2hfZG9tYWluX2NyZWF0ZSgp
IHNob3VsZCBuZXZlciBjcmVhdGUgYQ0KPiBtYXBwaW5nIHRoYXQgcmVxdWlyZXMgcDJtX3B1dF9s
M19wYWdlKCkgdG8gYmUgY2FsbGVkLg0KPiANCj4gSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIHRv
IGNoZWNrIGl0IGluIF9fcDJtX3NldF9lbnRyeSgpLiBTbyB3ZSBkb24ndA0KPiBlbmQgdXAgdG8g
YWRkIHN1Y2ggbWFwcGluZ3MgYnkgbWlzdGFrZS4NCg0KSSB0aG91Z2h0IGZvciBhIHdoaWxlIGJ1
dCBmYWlsZWQgdG8gdHJhbnNsYXRlIHRoZSBhYm92ZSByZXF1aXJlbWVudHMNCnRvIHByb3BlciBp
ZiBjb25kaXRpb25zIGluIF9fcDJtX3NldF9lbnRyeSgpLi4uDQoNCj4gDQo+IEkgd291bGQgaGF2
ZSBzdWdnZXN0ZWQgdG8gYWRkIGEgY29tbWVudCBvbmx5IGZvciB2ZXJzaW9uIGFuZCBzZW5kIGEN
Cj4gZm9sbG93LXVwIHBhdGNoLiBCdXQgSSBkb24ndCBleGFjdGx5IGtub3cgd2hlcmUgdG8gcHV0
IGl0Lg0KDQouLi5ob3cgYWJvdXQgcDJtX2ZpbmFsX3RlYXJkb3duKCksIHdlIGNhbiB1c2UgYSBU
T0RPIHRvIGV4cGxhaW4gd2h5DQp3ZSBkb24ndCBuZWVkIHRvIGNhbGwgcmVsaW5xdWlzaF9wMm1f
bWFwcGluZygpIGFuZCBhIGZvbGxvd2luZyBwYXRjaA0KY2FuIGZpeCB0aGlzPw0KDQo+IA0KPiA+
ICsNCj4gPiArICAgIGlmICggZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzICE9IDAgKQ0K
PiA+ICsgICAgew0KPiA+ICsgICAgICAgIHNwaW5fbG9jaygmZC0+YXJjaC5wYWdpbmcubG9jayk7
DQo+ID4gKyAgICAgICAgcDJtX3NldF9hbGxvY2F0aW9uKGQsIDAsIE5VTEwpOw0KPiA+ICsgICAg
ICAgIHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsNCj4gPiArICAgICAgICBBU1NF
UlQoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzID09IDApOw0KPiA+ICsgICAgfQ0KPiA+
ICsNCj4gPiAgICAgICBBU1NFUlQocGFnZV9saXN0X2VtcHR5KCZwMm0tPnBhZ2VzKSk7DQo+IA0K
PiBJIHdvdWxkIG1vdmUgdGhpcyBhc3NlcnQgYmV0d2VlbiB0aGUgdHdvIGlmcyB5b3UgYWRkZWQu
DQoNClN1cmUsIHdpbGwgZG8gaW4gdjMuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+
ID4gICAgICAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVs
aXN0KSk7DQo+ID4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:23:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:23:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422801.669079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIn5-0002EN-Bj; Fri, 14 Oct 2022 11:23:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422801.669079; Fri, 14 Oct 2022 11:23:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIn5-0002EG-8w; Fri, 14 Oct 2022 11:23:47 +0000
Received: by outflank-mailman (input) for mailman id 422801;
 Fri, 14 Oct 2022 11:23:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIn4-0002E6-Pm; Fri, 14 Oct 2022 11:23:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIn4-0007dj-NV; Fri, 14 Oct 2022 11:23:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIn4-0001AA-CV; Fri, 14 Oct 2022 11:23:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojIn4-0002DQ-C7; Fri, 14 Oct 2022 11:23:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0Y8RcOPkPI59uBFcEDfvvF89HNfoIAHTo6DrDl+jqh8=; b=Caun2FWv3McWx+2NE0PS9OiKOW
	1C8ryas8mO904h7lj/N8upnTg7e8dy1BubijGyD0uJtM8Oq1XodJyG8KO3wz8TPfxVAuTFMEFRZw+
	79sxdbg97liUzuigtbUcDTSLYrFV37HSmZe3mvJ8yacbTLRJmqaJLh+r9zDAUaBa7SSs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173749-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173749: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=171d4d24f829075cac83b6fafe7a4ed7c93935a6
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 11:23:46 +0000

flight 173749 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173749/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173734

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173734 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173734 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  171d4d24f829075cac83b6fafe7a4ed7c93935a6
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    6 days
Failing since        173492  2022-10-11 13:01:50 Z    2 days   17 attempts
Testing same since   173721  2022-10-13 16:00:32 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 654 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:24:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:24:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422808.669091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojInf-0002kP-MN; Fri, 14 Oct 2022 11:24:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422808.669091; Fri, 14 Oct 2022 11:24:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojInf-0002kI-JW; Fri, 14 Oct 2022 11:24:23 +0000
Received: by outflank-mailman (input) for mailman id 422808;
 Fri, 14 Oct 2022 11:24:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mVin=2P=citrix.com=prvs=2797e9ea4=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ojIne-0002iY-Lm
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:24:22 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be3d8df0-4bb2-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 13:24:21 +0200 (CEST)
Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 07:24:17 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by PH0PR03MB5864.namprd03.prod.outlook.com (2603:10b6:510:38::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 11:24:15 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%6]) with mapi id 15.20.5723.029; Fri, 14 Oct 2022
 11:24:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be3d8df0-4bb2-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665746661;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=fQEj08gaD01M9JSTVcCtLRrvb0mgsY4Auxz3QsW4L3o=;
  b=F1I/unDrvEs2vg257Hh/OusBWRTGJ26qCZDSgWY2fq97ibsT93VQItXf
   IXNOmZunJbJam7eX6HU/s3f6neeEasGKhk04Oar29KGqtmpG40vqQ+Wbe
   O65a7WMCfeiK5ejE1qUlxkq9HD0dfAQ0ih9YAIGeZdSv14jPNwoNRGw+b
   E=;
X-IronPort-RemoteIP: 104.47.58.101
X-IronPort-MID: 82722715
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:awBAGqPD2efrFCHvrR0IlsFynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem
 TxOHSzEb+HbITHFz+oGPNy380NS7ZHWmIRgGwtv/CE2QngV8cCYVN3Ecx6qY33LcpebFRg2s
 JtFNNSecp1oRy+Aq0/8buK8/XIl3KvTStIQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKl4
 d+rrpaBaAT9i2cvPD8dtqvf8B8x4f6t5T9EswVua/wa4FOGm3crV59OfqvZw1kU4GV3NrXjG
 7ucluHREkfxpUpF5gaNy+6jGqEyaueOe1LI0hK6YoD66jBavCs+z60nA/QVbEZTml2hkst4j
 d5ArvRccy9wVkH3sLlbAkQw/x1WZ/UcouafeCTn66R/8mWdG5fS66Q2ZK0JFdVwFtZfWQlm6
 fEeITYRWRGP78reLGWTE7QEamwLdaEHDatH0p1S5Wix4cUOGPgvd57i995AtArcs+gVdRroi
 2j1XhI0BPjIS0Un1l76k/vSls/w7pX0W2UwRF54OcPbSoUcpeB8+OGFDTbbRjCFbfp7oR+Zg
 VCFw3mnKw1GK/mG8QjY/33504cjnQujMG4TPJuR06cyxXG2mCkUAhBQUkanq/6kjEL4Q8hYN
 0Ef5ispq+416VCvSd7+GRa/pRZovDZFA4YWT7J8tVHLk/KNi+qaLjFsojppR9EhrsA7AxA30
 FuAh/viBCB1sa3TQnWYnluRhWPoZnJPcjZfDcMCZQ4j08PDkd8itBfCXs5cHLLop/T2NS6ll
 lhmqwB73d3/l/Ujx6i9uFzKnT+ojpzIVRIuoBXaWHq/6QF0b5LjYJangXD74PBaPcCmR1+Ol
 HEeno6V6+VmJYuKjyaXR+IOGpmm4v+ENHvXhlsHN4Yl3ySg/TikZ4843d1lDEJgM8JBdTq3Z
 kbW4FtV/MUKZCLsarJraYWsDchs1bLnCdnuSvHTaJxJf4R1cwiEuippYCZ8wlzQraTlqolnU
 b/zTCpmJS9y5XhPpNZue9og7A==
IronPort-HdrOrdr: A9a23:RR45Aq4bRGuEHfapzQPXwX6BI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTP2ftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U
 4CSdkyNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt
 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG
 TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq
 iJn/5vBbU115qbRBDJnfKk4Xid7N9p0Q6v9bbQuwqcneXpAD09EMZPnoRfb1/Q7Fchpsh11O
 ZR03uerIc/N2KIoMxsj+K4KC2Cu3DE1kbKq9Rj+UB3QM8bcvtcvIYf9ERaHNMJGz/78pkuFK
 1rANvH7PhbfFuGZzSB11Mfi+CETzA2BFOLU0ICssua33xfm2141VIRwIgakm0b/JwwRpFY76
 DPM7hulrtJUsgKBJgNTNspUI+yECjAUBjMOGWdLRDuE7wGIWvEr9rt7LA89IiRCeg1JVsJ6e
 H8uX9jxB0PkhjVeLyzNbVwg2DwaXT4WyjxwcdD4JU8sqHgRdPQQF++dGw=
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="asc'?scan'208";a="82722715"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ov7NIXuPeD1tu64Ftg3H3O7D9/UsC30pwMiR2wFLPgyaUgOqilbc2UoZ1ooHINW/ouGauDxxh7vqJZb6eLtA40H606VjFtUkOEQNfDW6thb7Vxx5gGbEqvaJrH2Tf9Lbh32gjHp4H1ay44KjhD5de625phvpuxQwYVbqEqrsjAN2v0fdWImRZ2OuzDhy1qxD+OZzylCpYGu0iuVOfp3B3md+ntiWQQPz1GWpZEJeaJNi7/TkWnuDvAp3jB1buZUaSjl2FmX7wJHbVJ8BbzYwwlMMObpBiOSX38C331uEmJEhgXWB3QHbo3DGB76kf4HvsXvIv1l0odbvY3kn/4yiUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YO82JN/k5JwpSbIr+NkjYIYpYUlo64z7IT00WZCFuNo=;
 b=gc0XmZrC1o1oKzHAQziM7zf6Vl5BiHPWMg2oPI6SjOLZadS0XDKaUA12G/revVOauI+NfraCk9srxRTL4yXKMcBEinMsw0yovOl9BzZ7Pq3xOUDo+bSyA2EgWaADX0lzdfdp9D2NlmOw1vFETxC6HNnwQd8RO/3WLUbfYpQwtH/HbNsmutfwvFSpwfTiS6uPCG9YQCnYRQLWJLFoUBAeq3IcbFM1ON6dg6BoL167nUH2Mi6vjH+p//WLYSfQa2W1AvmPExPRwkZBMFSPBx4KRjHYIUTX7iCkT2tPcxiix2L/8bjAo0Yvm6QCjwqxlAmB+L5jKDx0DDkiDFrtyAa1Og==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YO82JN/k5JwpSbIr+NkjYIYpYUlo64z7IT00WZCFuNo=;
 b=hliL+cCMeHZHPT83xe0mKXt3OYSttC+Jty0OzaGyhTY6jffxjU4Z/hq7vcoJPYo+jvbBwqWp+iZKCQE8iE4oU/KyEQ875yUGcU+nt9yH/LA/wiDKf/eDp0kkXfTlYXBZkPTNwX/nqh/xjEN9x0IZOF2iH3wiV+v5gxa9o83nv+o=
From: George Dunlap <George.Dunlap@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Henry Wang
	<Henry.Wang@arm.com>, Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Topic: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Index: AQHY3wTwBw4XcUEnKkOCwbXR47HHg64MavwAgAFV8IA=
Date: Fri, 14 Oct 2022 11:24:15 +0000
Message-ID: <C3A38BD5-E338-43BD-9EA1-3600378EE3B4@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-17-anthony.perard@citrix.com>
 <3d5e662c-91b5-a390-c21e-90391961bd45@citrix.com>
In-Reply-To: <3d5e662c-91b5-a390-c21e-90391961bd45@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|PH0PR03MB5864:EE_
x-ms-office365-filtering-correlation-id: 2eb598ec-5e86-4622-76a4-08daadd6a063
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 SjU4tggBum3yhDfYQhBMTDi4Wf2Crwgl1834iUMXRLBuEll4bI1dc0BjhRAfh/5pjx6JYhUkQNia6DFGfK+m5PkGjD/dmQmOFA2+bcHkkjqnrdGFGZNGyD78V6vjNfL+ysGxWaRO575GBM/3n4JqzUqFUnRuZ/KcfhFE4ca6PhXXZmO3gD/RYeU3ZsuKc0ZVpmwPRUt+g6XFU0M1SiJI2mY7UpHGRIS9fxXxFQOcDzuad8Aw0cbQXV9A1tbK0Wdf79A79nbgfQr1WLIuNBxmAcz/dHTwQ4DE6amOTMe26xvt+4vR24NSOreZIcA/tVhce1MHJVUGf/s+Z6zT0cTKyHSS6hKKjP8g146akmQacXlW1Pybacc2fM1WbY97BzDtZK2Ak4zUCKPNDcm/2k5wS1dds6w3EXHme/CirnLGPBXg7rOR3oQMvWc7o1hoQv0eXkLsStZnY59SB2A/QZOlkcNWs2//wpOlnNzxI24j2cxdPqFD/a58sdFCL98xHDMBiu9SUiL460hXiDrD+ZvUTto5mGGf5shyzsp3rxZz/Ly9DkYm2Fh9s6W41vrPRX4M2CBL8Y/dwaLRFkzjK9oekgNOl9Ktg13JOczv/TWj4q3Lnb6b3WlG8NPA5LES1YxAQ+/MAdgzVtEaROGJIGlpnfQ+vLMMF0t/FsmBNLKjJrI4lrdnyRd7APAGBJZFZSqagmX2e4jNDHdr+qBKu3cKhzUe70L2ONrLMandnGuTIaG3ZGi5EZB0zbiqujsGuWU54cJJ16/8/Pvp62t8fr3MxVAhgenYceQUNAjn0Co1ZZoRwsdwm9WcL7d/Y55sa/qv
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(346002)(396003)(136003)(451199015)(36756003)(33656002)(26005)(86362001)(37006003)(4744005)(2906002)(38100700002)(5660300002)(82960400001)(99936003)(186003)(2616005)(122000001)(83380400001)(6506007)(53546011)(6512007)(6636002)(66556008)(6486002)(71200400001)(66476007)(66446008)(478600001)(64756008)(76116006)(91956017)(54906003)(316002)(38070700005)(6862004)(4326008)(8936002)(8676002)(41300700001)(66946007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?rWfz6L0cguBxFRa9DGIlokKiRdhVsLAq/2SshFc4fc/ge84sunKOC4T0J7kR?=
 =?us-ascii?Q?ifxhrSmH18pmzyOWw1cvKbHDj6/ElDrp0+IUDR5Ezm3F3++PCB/0dsY6aQ67?=
 =?us-ascii?Q?dMhjz2uBJT3pFnh31rT93o4KmA8n1sVASH09OoHDwLg/EpxwxJpfNsro0WEL?=
 =?us-ascii?Q?H/CokqPRMI56+T5JOoNl5KButlqIhtRk2iGUgHoJQVuE+v+r/fssazaV/OYf?=
 =?us-ascii?Q?8E+91tt8k8l89Hbb5ozM1zqd7AM4uicgLhfPsbNC3Ozx1e884cIzVBkykkYw?=
 =?us-ascii?Q?NKjUsWxcmnErJxwYuu+O4Arkcf2+lHlxrnr0TuqxIRowp4n3OxqXY+/ijo9H?=
 =?us-ascii?Q?3aM1dYb9TPV75wAjXenZsuSsqgljDhLtQs+YZ6zp00DYTvjhvwaBGjJptAhO?=
 =?us-ascii?Q?2s8Jej3cvDGchZRSs8pRgNcM2eUrg9fa9iDAPDxxp3mRiA8JK8fC57ChrAr+?=
 =?us-ascii?Q?GXB6YfBkBkcue3P5OoXlwOZY2lxcvKrM6c/GD/gLrNb4xYRfPJyA5Nt/yLjE?=
 =?us-ascii?Q?HU3vCmXvZOH6inu+rBxG/RILXtDlluVyfvoN9By2YZneDoNMmK+MJYDBJ9QO?=
 =?us-ascii?Q?eYPdIeJsIjQMvEyfqRZWQK+8l8P8J8IADH2Veki7cMFeXZHhQzBGdHSTXnIn?=
 =?us-ascii?Q?EFJmB/s4lQpK2/Qqm6q8gfm9qt+8k2GVriL9ccssvtkxGtQaZc3GbcB0maWn?=
 =?us-ascii?Q?pWlrnp9XaiUDfmMaAAWMrzJ4gdjEMHHAwaa8QYq0qBP4xDH0MvhnygfkM4wW?=
 =?us-ascii?Q?+E2Y20STeBCkeQSILCzAik7InMTMMb7KqxLYJmxZ0MlA73SlTw8o6G2Jqfx1?=
 =?us-ascii?Q?mA9NzhkPzefB+Kn26GrMxqnngZjzyu4HzPs8YNyDgefysk+5TJfxS9WZ7QKv?=
 =?us-ascii?Q?3rG3iXDFGSkXW4/8PE7HKbUu7JcvcgwkGYXp7+VzpPH3lleGDd0ksyV+LVEX?=
 =?us-ascii?Q?nq6sIQU80ZliQ8R4POQIztMKaSmSyAa/GIy8bfqDd1iqjTMKaODQtL0WfjuU?=
 =?us-ascii?Q?wmcVB1gInlZoFfLOJthKee3T4+B7fW+6QqaVo7/UtuUAQveJB2rldysHnIIP?=
 =?us-ascii?Q?vVxWP0zqPFBA7wfX+YjKh3RM8J4QKDVSNJIr7aMSYDzLBeMsjuU3V/LDs17x?=
 =?us-ascii?Q?YS//GXYT6995dRVpWwAXXhWYZ4ygFBRVZuGx0NpJD7RETZBoUFW9lQLCe2zY?=
 =?us-ascii?Q?DGX1lfgPasPgaJGTAopsU5+tQoiV/6Idj3C/MgBDbRxVpuVntZWHeN7ybOa8?=
 =?us-ascii?Q?dUd6DVM+DyiQ9fJv1UupQoXcOfyoOCCqIddoO9ViVt+JZUnXVt7DYxz4CsNE?=
 =?us-ascii?Q?Ii8rYt8AY+T71cFLXGjA0dkYXrlw5mvqOVSzawXBFKQA2FTje4ZmPxY9YvOx?=
 =?us-ascii?Q?ss9YklOBtKlw9zPvhir8U5EaV5Fno6SfCaTYQWXQzJVtsjQdmhpO343bjYdR?=
 =?us-ascii?Q?5TefxAGwU4zJ1Bwv84cBfZ53h+wWFnQs4eWS2/vGozoA8hv8cV5LZda9xmuQ?=
 =?us-ascii?Q?midtzbhzycY00PSzsvVSe+w5+ooxifLCU5dw/Gk4f4dCJuKAESqhgHQYgwLW?=
 =?us-ascii?Q?6sZjm4T5wC2aAxQ4rKG2zoDLQXaM4uCpzo+6Tret3lVTkII84woGrm45BGV1?=
 =?us-ascii?Q?VA=3D=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_57BF37BF-0760-42A3-AD2A-18B3ABB8B75B";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb598ec-5e86-4622-76a4-08daadd6a063
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 11:24:15.1669
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qAk1zIHkkRgb2C3fDkOpGNMHMros7QezZoUzlB3DXey1RiCdWO+cznCM5zxUWYC8sCk/3loeLForhRb+yXB0FkYZL3xNUVAYRQZgTpz6nPs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5864

--Apple-Mail=_57BF37BF-0760-42A3-AD2A-18B3ABB8B75B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On 13 Oct 2022, at 16:00, Andrew Cooper <Andrew.Cooper3@citrix.com> =
wrote:
>=20
> On 13/10/2022 14:05, Anthony Perard wrote:
>> diff --git a/tools/golang/xenlight/gengotypes.py =
b/tools/golang/xenlight/gengotypes.py
>> index ac1cf060dd..ff4c2ad216 100644
>> --- a/tools/golang/xenlight/gengotypes.py
>> +++ b/tools/golang/xenlight/gengotypes.py
>> @@ -723,7 +723,13 @@ def xenlight_golang_fmt_name(name, exported =3D =
True):
>>     return words[0] + ''.join(x.title() for x in words[1:])
>>=20
>> if __name__ =3D=3D '__main__':
>> +    if len(sys.argv) !=3D 4:
>> +        print("Usage: gengotypes.py <idl> <types.gen.go> =
<helpers.gen.go>", file=3Dsys.stderr)
>=20
> This breaks with Py2.7.  Needs a
>=20
> from __future__ import print_function
>=20
> inserting at the top.

Out of curiosity, did you notice this by inspection, or  because you =
specifically tested Python 2.7, or because a system you were using is =
still actually using Python 2.7?

 -George



--Apple-Mail=_57BF37BF-0760-42A3-AD2A-18B3ABB8B75B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNJRtsACgkQshXHp8eE
G+2wFQf/YJ+iOL0r3IPhk0aJ3t8Pm7+Nd3vHucfpD0yhnkQ3S0d/gERP3FixZLWY
vdfv7s8RpxzXuaZZhvUTXrZhzcIZIz87GMb+Nm/nZs5VvJh1YQjwsayopobCUbZ8
hNefjD6C6aa5fAXxgJcGtBdkB45lMdNz77fF4kcx7716jlOKNY+PvnNRzRXpBktq
+h7AQ34BTJSnaywZ/TwdEL4/lw8W186TO4Y/voczF/i+1bSPBlN6rmctSHu8ecut
cqGIpB0QwptbHw0vBHPbw7yXIHVt15DEor6m+Z5BTlmOvjBAO3J6H7qHgY4g0Bxz
vgUpx6GDmuNSB2sjeLZ901to5pm7Nw==
=V68H
-----END PGP SIGNATURE-----

--Apple-Mail=_57BF37BF-0760-42A3-AD2A-18B3ABB8B75B--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:26:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:26:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422815.669102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIpI-0003Te-70; Fri, 14 Oct 2022 11:26:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422815.669102; Fri, 14 Oct 2022 11:26:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojIpI-0003TX-3h; Fri, 14 Oct 2022 11:26:04 +0000
Received: by outflank-mailman (input) for mailman id 422815;
 Fri, 14 Oct 2022 11:26:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mVin=2P=citrix.com=prvs=2797e9ea4=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ojIpG-0003TQ-VK
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:26:02 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id faa07eec-4bb2-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 13:26:01 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 07:25:59 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by PH0PR03MB5864.namprd03.prod.outlook.com (2603:10b6:510:38::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 11:25:57 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%6]) with mapi id 15.20.5723.029; Fri, 14 Oct 2022
 11:25:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: faa07eec-4bb2-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665746761;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=v9/uOs5FfQ+wACWRofrVrFNQyLNEmwuWfPW4jCmCjKI=;
  b=SknF2SBieOArB+YluF6tSKtIZRh50njNDKRZ5/nGsaWEC/6KG//+Oi1l
   R8+2kNyaGgCRex/myZe58w7doBzxI+NhOTHyTGAoQSkCT/6r6FFAOqO2x
   ZqpursvlPx3hFGfdcGuQItjtQ0CHn9Xn8HhKDxX0/hzBaAtvR1I7kTd9U
   c=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 82722802
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:D3DOKK1z0BUEcQsoOfbD5XFwkn2cJEfYwER7XKvMYbSIYQITYwd3j
 TtIBzjCf73ffDO2KOnCW/2x8hkGuJaAn4JkTQZuqS4wEi1B8sGcVIWVc0uvMn3IJ8bJFks55
 ckXOoWRIppvRyPW+Bn1brS88CEn2KvUH+ukYAKo1lidYCc9IMt2oU4zy4bV+7JVvOVVIz9hm
 Pujr5WAZAf8hDV+OTpFsv3T8E5itqr/tm5G7wY0PqgU4g6CmyEZAqxEKPDqJRMUYGX28s2SH
 L+fke7jrgs12z93V7tJR56iKhVirob6ZFTI0DwOM0SbqkAqjjQo1aomP+YrZ05SijGY9/h80
 9wIvpGrIesTFvSkdN81Dl8JTkmSAYUcoOWdeCDm7ZTJp6H7WyCEL8tGXRle0bIwoo6bMUkWn
 dQEJTYEaAy0hu7e6NpXncE126zPhOGyVG8ukikIIQPxVJ7KcriaK0n+3vdK3S9Yuyx7Na22i
 /z1y9ZYRE+ojxVnYj/7AX+l9QuiriGXnzZw8Dp5qUerioR6IcMYPLXFabLoltK2qcp9wEOTo
 0+f5G7AOCpBM8OEkxrG0Hedv7qa9c/7cNp6+LyQ0NdP2QfW41NJTRocWB28vOWzjVO4V5RHM
 UsI9yEyrK80sku2Ut36WB7+q3mB1vIec4MIT6tmt0fTlOyIv251BUBdJtJFQPMrs9U5SHoGy
 1mNlsvBDj1zqryFD3ma8994qBviY3dPdz9aP0foSyMqyP38p6AajiufEOhIP6K/i9HPBWzvl
 mXiQC8Wwu97YdQw/7W2+xXLjiyhorDNTxUp/UPHU2S99AR7aYW5IYuy5jDzzftGNpffcVCHs
 1ANgc3Y5+cLZbmXkzeHWuIKH7eB6POMMTmaillqd7E+8xy99njleppfiAySP29sO8cAPDr2O
 knavFoL4IcJZCf2K6hqf4i2FsImi7D6EsjoXezVadwIZYVtcAiA/2dlYkv4M33RrXXAWJoXY
 f+zGftAx15AYUi75FJan9sg7II=
IronPort-HdrOrdr: A9a23:gzjc6KGbxIpNqpjxpLqFXpHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhd4tKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM
 RbAuVD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL
 aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlEawTjLqQntxK/xEhCe0BtbeShI260e/W
 /MlBG8zrm/ssu81gTX2wbontprcZrau5p+7f63+4sowwbX+0SVjUNaKvi/VQUO0aGSAZAR4Z
 3xSlkbToNOAjjqDxyISFPWqnXdOXAVmjPfIBaj8AXeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL
 lGxmSDqvNsfFr9dLSU3am2a/hGrDvCnZMZq59ks1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO
 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+
 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a
 gpfGkoxlLaIXieePFm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="asc'?scan'208";a="82722802"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Soajgz6PGK4cCF5GQ9pZvEIoC2ojycIbNt5yBVSv9pvyi4o4p+nrbt8jUeSNlLEO9qE8TAQox4qlONVoCbQ3Du6Yl1dqrzlpzL9FwEMN/tdlH7ya0NQWxfOLyYLWKbo/lY9j5LKXsh9SKD4OZq1IUzQtP1EzQH7dAOWP1Ano7PGx5TzrAaAah6dvXPBt5GdIdBq/whwr/PE8Wp9O2kjAmDAWYlKz+HNryRWNDiSW+Q0cL8dFaAVEVYtWBJET40CdGzVxJfADJd452dfBxYrWFuTq+KREK8TWgpcPKRFSL6eK4Tw81mZbuSIgf2/R9XeoczChZIznDJa5CUyYbrBNtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xREnVDX/284KzvnVRT5d00Z3GCtm2zmaxAyQa1BmCSA=;
 b=BMO+9fl66hTXsaU6tuKWqDYu9cQiGGfmELQkFKM3kDJLPKL2a3EonIjqn9HOrZGpPwXI4rYbL0OzTblGW99eirskEaQJ7GIdevmhOtbMdDzPoG3MUF0cyw1zCMiEiX2aXulGzhY5PEK297gTEUaTSq8vr20jQj+lDpAm5y3Svd7d0NwvGjW7hqhTKKxjd9GPAJJxN/KIQKZiuSXu77433thFcB6yNYCDxnr3VT5qy9XGtVPwvyzEGHf8S8RdUdlDvH4Mnmu/fsm1D2rwlIhbvx25l4y/anPtnZKSXvnbLf3PIN/JLa53J4OWrYhPOomOWcXV6b011pfpESp1YlKeaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xREnVDX/284KzvnVRT5d00Z3GCtm2zmaxAyQa1BmCSA=;
 b=D2jeEWeK8Ux2R66ZwkGB9uZguJMDzYan7ewbaEJXoHdrwt+AcyKZMqjuXxY7Qv0NmhzRy8Wfvyzg+Kkp3u+1NXaFqaaiTk65Rc4a+zuIX6RIwbIsP2A58bg0VAwjTbj9t8V/BuRQOQCziaiXcsg3awwMKN51cRIGmO1VfcZIHtk=
From: George Dunlap <George.Dunlap@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Henry Wang
	<Henry.Wang@arm.com>, Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Topic: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Index: AQHY3wTwBw4XcUEnKkOCwbXR47HHg64NwWoA
Date: Fri, 14 Oct 2022 11:25:56 +0000
Message-ID: <6507371D-CE8B-4DD5-AFF3-9D99069BAD55@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-17-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-17-anthony.perard@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|PH0PR03MB5864:EE_
x-ms-office365-filtering-correlation-id: bd45f0de-d4c8-4f75-d947-08daadd6dd08
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 K+KoOPkw6K2y41GpKaeeC45VVVp9QYq+Fri3Bg4/39jg5BF6SoPnp3oxsVNxa9zPdzh0RYDy+jTDuEEG5nh5QEWCBHQQKeKGxDFHagc7oIji/Fx2gmdiCdx+PsyrzsYcWj/J3Ne43arVZetXpzruauyfUZ1XtDyYAd9g8xtX38xLgcfx4HnpU4SdrrIZoA8twuIW54EwVpwx7OTi4p3QDixS2cmJNVO2pF7NmhW35HCZRdDcFbKHcWNprSbkv4nZoSAz7TGjxsSkMNT68HIJdD84XMR9mBaLnr3g5zl6MPeNWOROZetFl9mz86aXWZAPLuL1kLyIalwPfMrVhdFdMBNaV38DGT8qT8nToKJV+zwiFsENH8p1g7Eqm29u8MGe4uZwzIPoIkHB1Otq9MMOaXSyPpgJhazNvDtXE6A1JLo69RNHSn8yEZEVrPC5Ib7QysAC43+mu2gf+yBDxmq6K1qcX5t/1OFOzzNzvyyXu053jHcBmi4CjmxHyFlEjO17aPivgd6hd8Go2HKN0riVpuj8kUs11untge3qDigRLa9+2B+Z48z7DxaEUjC9SHDV4sA8Y+fjdzOajz1B7xYBWb3WCO6CqPzK9bsWGWfbFAGaiX9yf5dL/Fs7tXuGl5cqCXX8pZk7DTSkdWMqlwrXUfEzlpUzCbATGf2O5pn5PbkK2Kt+cuCStSWGf8PR3x3TpXR9mhU3LqBmi6YWVtMQ+xSQKJARlzjhWMTnrMiaZ1HWIpdSU8kwRIG1K19mLrFxKfsXUrhLmF05ySZ66chXPnhZpKr4qmjb7wC3aPA6sO+oguoXjHBXCb9Vd4hE3gPH
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199015)(2616005)(186003)(6506007)(122000001)(86362001)(4744005)(37006003)(26005)(99936003)(38100700002)(2906002)(82960400001)(5660300002)(8936002)(38070700005)(4326008)(6862004)(66946007)(41300700001)(8676002)(6512007)(53546011)(316002)(54906003)(91956017)(76116006)(66556008)(6636002)(64756008)(478600001)(66446008)(66476007)(71200400001)(6486002)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?rx6C+P6nf5m1HrslhHyyxkSCTEr6LI8aoaj7GaSxmBv1ImucdRG9msHe1RmB?=
 =?us-ascii?Q?rvLdYcxOPMaFa7vJWurH2GArFCQqh8sGIgfQRoafHz+m9T6FDQxMfxEHcX3J?=
 =?us-ascii?Q?UEhfPTT4khkFKZBrHmRIicqXoFwNKvDj6G8gJBFhuYsXt+GwF7/MYbRx5XOb?=
 =?us-ascii?Q?eQ15rIeXxE0rfimrBaTX/c5gnX6imj408bBxa8EBgcw3S94C5mInYuL1FRzG?=
 =?us-ascii?Q?hEyvYjvjk49vtzF6N93L5Nfhw+eZkx/0JdJ2/UvFUM1Xj+k5dxeGadXq1iob?=
 =?us-ascii?Q?hBqTh0Dfni5elaIyGUlSyCzB28uBI3jNlgquC4Ny+PrtkFja44NEiA4Nc9xt?=
 =?us-ascii?Q?RJlnJ+MRNTFAR6zYg/t5zeHcU8Rp6y38HnbTyu7yHDsqaA9P6nzfSqXwLY5r?=
 =?us-ascii?Q?Viz8/bJGIyEcTcblG1QmUqqbMASH9a5s+ULheUb1QPnVGu65CiwoSdcD5TsT?=
 =?us-ascii?Q?o0tTlAZjvmIOWKP8WPGUZXo3S3ltV3t4rGTngkH0a/CYjNtZfEvvCs2o1MDq?=
 =?us-ascii?Q?tV4ycl7pctq5C7Kk4VZbHccjt6u5kdq3/MYifjTfiVl+y2dCwFEraYpvaJ96?=
 =?us-ascii?Q?EPVqzhM+DLfbRHkJ8PTLPHMlvQY+1TBKdmwyyWa65LtftQled9ipfk4oDMHt?=
 =?us-ascii?Q?LuG05dhhxp+tggkmPQFtIMH9rTvEXkEgPbL2jRtnXHlH46Vsjd41LiXt3uFN?=
 =?us-ascii?Q?+HV4Hc+ghzwBCn4Y0DEBM9weEBjx80SEc2lWpmCvSQ1lE2gRMuwwaaF1jht0?=
 =?us-ascii?Q?CFg7kpoOVw0749rNX5OgaBz8G2gNLv7nRUNA8vg+RVtd+4WLYtOtM+bcpc4/?=
 =?us-ascii?Q?pE7RubtfWrzycX7jYyIYOWPKJw2e2ObnsxSIlUv4zJMx76NmunuZiPbfkmGx?=
 =?us-ascii?Q?YZZoYwtb1wFH9M7Vk7f+Di2dXTFHqv9NC1/HN37SBjnk2zsqgFtSBaPeCPSQ?=
 =?us-ascii?Q?Fzqpo4Ed5awSwPDG52kCa/3QCGYlXjd7K19D+iAX98rZ7UeDp6CxIFp7BpIn?=
 =?us-ascii?Q?0H5I92NniqouHr1jmdXF+4Pmulf3Pj07y8EY5VtnrAv5lAXj8we1W2MWcTZ1?=
 =?us-ascii?Q?k42thegbHStDX1rrn3Erzuu9+C+7BEWpb9AXIXMUbjQHjgjiKFG21O3lX6PO?=
 =?us-ascii?Q?6vlb4xKAq7XKxuN/lygW7noUVXKcAe4t+ovmywtxlX2/toriJSC3XS+vy5rC?=
 =?us-ascii?Q?7SJEOj7sA1JdWFKI1kgWneY5pcF+DNicTK5zuUt/zzs53T+spRPYNn/xf8KW?=
 =?us-ascii?Q?7MhW3fYfZ56QV7ZwRhNvcVJ//vhX/wz49Pi4doIltqCDmoTu6re0PdakDCDl?=
 =?us-ascii?Q?AeWd0qpgkutjp0qX57Coxwa64qRhYVoG1V5THUFiLaxP1BHAPNnRFUfFfwn5?=
 =?us-ascii?Q?/TbOvSJ2zPL5bF7lZNFoLRPK1piwNhb3ToGSMPLDueVPDW8JazRKQGmYLCQd?=
 =?us-ascii?Q?ZAxPpAd8WDw6inVHoEssckvwZbMMEKMjE7yz/frsS3n+8/vVTzrSB7RFBVmI?=
 =?us-ascii?Q?R/mrGppBPb0dNDkhfD6by4S/t5IB6/axY7aDYxGfg3Lpmkk2rfbgj0oJDM8F?=
 =?us-ascii?Q?nhrYuGR1WqtgniL/arQ39HW+q9U/a73jXyWqVMWo4G6XsEjWUnGQBPnR2r5u?=
 =?us-ascii?Q?Hw=3D=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_F57FA467-812F-469A-816A-B3715FD37ACA";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd45f0de-d4c8-4f75-d947-08daadd6dd08
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 11:25:56.8985
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0+IlTuCK4Ax8XfUY9yh5CKgdRFFTPJSdjUm1EigngOZuFT0rbRibzKyC8q8QbIIi8xuNcLuGcRqjF2Kcy+6ySUAlmUNCU9DvL7EnM7GfB7g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5864

--Apple-Mail=_F57FA467-812F-469A-816A-B3715FD37ACA
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



> On 13 Oct 2022, at 14:05, Anthony PERARD <anthony.perard@citrix.com> wrote:
> 
> gengotypes.py creates both "types.gen.go" and "helpers.gen.go", but
> make can start gengotypes.py twice. Rework the rules so that
> gengotypes.py is executed only once.
> 
> Also, add the ability to provide a path to tell gengotypes.py where to
> put the files. This doesn't matter yet but it will when for example
> the script will be run from tools/ to generate the targets.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Acked-by: George Dunlap <george.dunlap@citrix.com>

And you can keep the ack when you address the Python 2.7 problem.

 -George


--Apple-Mail=_F57FA467-812F-469A-816A-B3715FD37ACA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNJR0QACgkQshXHp8eE
G+0gCAf+NM3R6ROSBG+Tv72aFTSqO9tAYm40VbRXlVTa4jKCNQq64cDu3Ot17hTK
mtUihsuIzSKsAFLA7kLzrQm5PhFDRbJZ45WiAKFJXvAmLcusu5rBaW8IycvVigRv
QxqD6oGJiJ3YwlDpgVUo6+208hRCbl1OWchGhDFqFLLrhVtE2hvp5i2OHkezMoqM
LZ0CAsNgPEPPZmK0elgzQlYQ/Nc4cGBRq0x4MOZpAyx2oz4Kqz/6MV5d1YEMU4As
aM9eIc8lyl6dd9/fPAlCYgwxRvbNd293pWtqSa7JPMXFkK6yjKW53liLFy0R6Gfe
1McT0qI2BWfHZH9A00eXH+cC9xrU5g==
=Ne8p
-----END PGP SIGNATURE-----

--Apple-Mail=_F57FA467-812F-469A-816A-B3715FD37ACA--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:37:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:37:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422823.669113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJ0Q-00056c-94; Fri, 14 Oct 2022 11:37:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422823.669113; Fri, 14 Oct 2022 11:37:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJ0Q-00056V-6B; Fri, 14 Oct 2022 11:37:34 +0000
Received: by outflank-mailman (input) for mailman id 422823;
 Fri, 14 Oct 2022 11:37:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojJ0O-00056P-KL
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:37:32 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95934cdb-4bb4-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 13:37:31 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 07:37:24 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DS7PR03MB5592.namprd03.prod.outlook.com (2603:10b6:5:2c2::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.22; Fri, 14 Oct
 2022 11:37:20 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 11:37:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95934cdb-4bb4-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665747450;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=xexaGvKf7M9a2R/drz2m64q0kubX8NKk+tLk12Wzn2M=;
  b=Bd9DBQZ4W1TKgYpEgACq+9UEmJ0avQgxFTXhaYcxI42JVLtyaVPtRs8X
   DnJgAeu2xlv8cUxA5yHXBcw7XJcUQhHPWf7raFU7SctzZlI2se1uvWi8X
   aFPJ628XNvPUp/sROygetnh2ArCgek6HNVr5sIkumPENFdOzl+50Mdsid
   A=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 82369435
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:nBcILq28+QCIzqJhyfbD5e5wkn2cJEfYwER7XKvMYLTBsI5bp2RSy
 DYWCjrVbq3eZGahLtx3at6w9EIHvZ7QzYdiTQtkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpE5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUW6OgtGiZSz
 8dAOWsyYD2suuab0py0H7wEasQLdKEHPas5k1Q5l3T8MqxjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7gzL4/Zri4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv
 Dnu9GXlGBAKcteYzFJp91r83LSRzH+gBer+EpWy295AgHat4FAsBUc5aFylgMuFoUyHDoc3x
 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsbjNHcs1gi8YwShQjz
 FrPlNTsbRR1t6afU3Wa9bG8oja7OCxTJmgHDQcbSSMV7t+lp5s85i8jVf5mGa+xy9jqQzf5x
 mnQqDBk3+lPy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1
 EXoUeDHhAzSJflhTBCwfdg=
IronPort-HdrOrdr: A9a23:/YCAWK6AKwlWr76nKgPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="82369435"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EmRreud4cKgfseT+BdayHcVAiOo80o8JH9l03bwU8WKZHLHZI/AKZHcRqLaJGTwU8RZg1DYnEKRH2t4aGmNtS5SPThATT7Q73agwAJkxjV0AKVRRjJ/cOSOe7CMjSujH4sbuW7oTINqYTjdqRYXEV2cZVxsNIajLfrD6uB04b3/eQsG8HP8dGQ/gXDEr26XBMfh3/XaFT2jsVEmrEU+OBNKyNjh/zridVuPN3LJijAjo2+wkk26o7vQySGw/rieazSJie5ERiE+lNwM/57moUHdOfSvcBvnyxe+ELqy2a+TyoLr+FORHsnYRx1PCQ36dTMKv/YQjMsCmRx37nINg8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xexaGvKf7M9a2R/drz2m64q0kubX8NKk+tLk12Wzn2M=;
 b=Ydrsc8OX1U/4CaFCXnxoRj47tK19L6GKN4RjZpZf9z0AfmPryjkPvgqXSird7OtpveCvTrUJa8utLrTCbnnTY1iAbO+pAXfBuu55DJXgLTibnnZZRjkDR2S9704UTbnEW4njtSdHiQZEY4h4iDclN+QjTOx9EJi/Kt0mfh9bq2R1I9aU4+DDg6I7hLrubWk3cAChnyX1t3NDrEzJJXxfeYBUgfsKeHBn+reHaGp3OYr6HAP7rEP40W5oxtRiRWkYZLgMPraXNZp0ZaMFf7bqPG8Az3T/zZ2jkz01lV5zYG237LzCEpkAOgBH5HysDzuJTuMiT3KhVvb58hwvEPrmvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xexaGvKf7M9a2R/drz2m64q0kubX8NKk+tLk12Wzn2M=;
 b=buT+yutr0Xj5F/4lw9/6XHnB3Z5ObtqCD3SOcgFj0uwqcKFpuK7nEH4SHtx72wuz7CSsLwWvj3TKoYlyl+Mso8ULRiIAl/FUqAso1JfdJq8Qj6SdFCxLGxDq0tCQX6jGcCRcCZptnHEb4Rn7ddUiVRUoYc0vQ62bRTH1rJrXk1Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: George Dunlap <George.Dunlap@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Henry Wang
	<Henry.Wang@arm.com>, Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Topic: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Index: AQHY3wYExc++jpfrd0yvyakMPv5Mw64MavoAgAFV9YCAAAOmAA==
Date: Fri, 14 Oct 2022 11:37:18 +0000
Message-ID: <532f15c0-8615-5196-e555-86a2d1094335@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-17-anthony.perard@citrix.com>
 <3d5e662c-91b5-a390-c21e-90391961bd45@citrix.com>
 <C3A38BD5-E338-43BD-9EA1-3600378EE3B4@citrix.com>
In-Reply-To: <C3A38BD5-E338-43BD-9EA1-3600378EE3B4@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5592:EE_
x-ms-office365-filtering-correlation-id: 5e0523af-0a2e-4fab-35d8-08daadd87379
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 bkHdFPbt9YC/D0N8Z4ikhSHt+6SWVo8yhvuV+qzYP/dQ3C7uc+mzcSiytXOi1m74EC8068q/LjtZUXmn3W5G3qEe9dCLTeEP9CFnu2Z+HjRe957kFjQJv2AnZvOWhIWVUNioktynpLIvcmUI4o648B02/AHFXGEdLBSFMGbHcBbHeaFkmmD2sQz438FMya36Qe2d0gV/KDG4IeBrFVaCmx3OdsLyorb1k1zSdt6ZMgIuMJNdkFZzTsi7T7d4yOnI7UzF4PmJA5xwxXRp/cmJlge0ortfCMWmHu8nLCLrrlj7INyf4ofYsCphJ3Ho+fDjVPe9rHo1sD8ll1E8xB88koUWmzNmUTvpmQbyRro13iShPunWpvqeZBq897EW3ozWPfJvN/YrjKrIZmEn3zk6Uxppyxq7sfMv/gDifdSQQqVj7LsNeZU5KQwfgG+agj0rFHq2ikldo4m1IcCMp7wXIsfdZT5KP1IJGV8S45988+vupzOSknnMIwm3UTsjrDfp5WVPcylCLEfbacufKsKCLuiuYpGc2hyDfu16W5zotBZLT8ZKdENDF38t3Aj1lXJJAL858mnVQxYUNydQ1nyM/zyH4pF0YVrfwtuOxx3PpTMibagLnoFsFcvBsAvvZBUgcH2Jd1YwEB3ryaF5E/HH7NcBIXC1R34sd7jHbSDzH3ZjJDi6stO7Dv+UM199Gh6DSGnoGSF9aUB6XPIBvf1tMP+q4TDnEmNk8XB2eTcLSw3BuvdtnL8vk2krHEfiS4KhwAkXT5AwqLGTlFUAc6Ob669WErzBLosd7O1aM1rWrwzO3rC1cSZe1o48N+Dd3/y7G6eAXvO97+Dz+8DysbqTtg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199015)(36756003)(86362001)(38070700005)(31696002)(8936002)(6862004)(6506007)(5660300002)(2906002)(478600001)(2616005)(186003)(83380400001)(37006003)(54906003)(6636002)(4326008)(6486002)(26005)(122000001)(71200400001)(53546011)(66556008)(66946007)(66446008)(66476007)(76116006)(8676002)(82960400001)(41300700001)(64756008)(38100700002)(316002)(6512007)(91956017)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MzVkaTN6NFd6blFHTE5vdTJ3a3IyTkxxeTc2OHFodGZ1WnlGbnNJeUI4TnpS?=
 =?utf-8?B?UGRQRU9pUjRPSzh4YUZRaEdaQWkydG01N3JKcEVNb3VFMmhEYkNpNndkTUx6?=
 =?utf-8?B?TjRJS1JpeHE1SCtKRTZoQ2Z4NnkvWitRYWN3M1RNR0NYRVZISXI4Qlc0SDlR?=
 =?utf-8?B?U3I4QUJEanRUT3VPU21ocFpNejh0RFFoSG9uZnFtY3ZDdlI1S3BtK0RjMlBL?=
 =?utf-8?B?VC83empwS0F6cWV0S0V3WG03QWZJYWhvWW5TOEVsOXV4N0lHa1BwVUQxSlll?=
 =?utf-8?B?MG5pWXFTd3hyTlVFRWtSZ1M1UG0yT1hYVklGT2lzWkwzRW9aUm9uTGVwR3Iy?=
 =?utf-8?B?Q0h6VnhncjVBMkJrV0QrdkZ4UFNCU2lWTzRkWk1PSUs1ZFk5UEJxeUN0TUxm?=
 =?utf-8?B?S0I3ZjJtTW10Vm4wTWdJTk44dmxiUHJzb0xKb2h0NERxTDBscHhLY2VPK2xP?=
 =?utf-8?B?bmxHWnlhbTdQSTRORXdoTkFVMFJ6bHFDcEhTOHk4MGo3MWkzV1ZUM0ZMcEZw?=
 =?utf-8?B?MjVONUlhVXNVZWhhWkhEak5JMDlDR1ZtSlF3SC8vRTVMVk9BbmRvajFWNU5k?=
 =?utf-8?B?UnZvTjFRa2x4aWdEVHd0Ykc4Y0JYcnBrZFdzY1M3MncrMmZKYlcvUFcvNkFN?=
 =?utf-8?B?ZVA3TXNKbU5CbVFkRy80bWdHNDJGOE9pK3Z4dThzTDdMMmlhc0t2VEo5akd0?=
 =?utf-8?B?cmJCRDJoOWNUa0doNDIzT0tJdDlRbHB0eVRZa01TYnVZZlBoRmtjSk41TGZH?=
 =?utf-8?B?Sjh1Nlc1RjlocjBZRHNCNXhkUXJ2VWhPVSszOXl4Y3gzRTAyRTZPTGVEOXlD?=
 =?utf-8?B?QU9VaktOeFBpSWJxa1lyb1lJeE1OMGFxUU1LVlRvY1V4SzhVRitCejdvQ3R4?=
 =?utf-8?B?WDYraktrM3dyOEgyTjF5OHYxQTYxMUtYdmhod2lXZXBMMjVYZlZCZ0ZuU0FY?=
 =?utf-8?B?Z3pVZzhUTlZEMEhPOSsvOUIyKzhQY1VvS3JSYVhEK3Z6ZHBqRXRCR1Noa3pQ?=
 =?utf-8?B?dHQyUVd4RHJKVFIyYlpPamhPbVZtMDdlVUJRQkxUeTJacW9EL0F3RTZTbXNr?=
 =?utf-8?B?VzU5dUR1MFduZ1BTRnVpRHNEbW1oSzVOYWhEOTBsNm9OYnlSb05VbHBOc29Q?=
 =?utf-8?B?cUpoNi8wYlFMenFIb3VaSzFDWlgvdFZraGRkcGRrTzNta21NT0c0NWFwSHh2?=
 =?utf-8?B?Y1V5cUdpV3p4aXRGM01qS3dKamhJYk9uY0ptRWpNekJaSUxPRzZ5Ykh3aVVn?=
 =?utf-8?B?T2VJL1RCeEI3NWdlY1N6ak1kU2lDZzZVd3BXSDcrMm5DNkJTWm1ZSUdzV21E?=
 =?utf-8?B?SGdCZUxKbk14UTI1amlmVGxqa3hCZW92Sk5CUEt5b1pic2pXSGZNcGhPYjRC?=
 =?utf-8?B?ZGhxRld0S3RZbmFJUEc5c0ZiVDNjbEtGVnJNKzVPN0NuR2EvRVFYZnVPTnlQ?=
 =?utf-8?B?SFlIcnpXUGFKTStXQkE0VFZpWGthUDdnMWtJS1Z6YjFoOHpianhObEFTNmZa?=
 =?utf-8?B?b0o0TXFKMDV3Vnk1OURQUElMeWh3eXdHc2djVXdDUFZlL2s2ZGhENEhHTTRN?=
 =?utf-8?B?ZlFacFdzV1RpdlBmOWNESEhIdmxvSEY4YTE2dXY2RFVGYjQvUUkvSnlNTGo1?=
 =?utf-8?B?UU9PNkl0ZSs0K3EwMWE4bDhvSnArVTNoa2Z4L2k5aGZ5R2RZS1dsSHBCU2lN?=
 =?utf-8?B?ZVJnd0lwdm5CYnU3dDZVY3Y1MlpBcTdSb2h6L0JkbXZvS3Zqa2hIQVpoTVhx?=
 =?utf-8?B?RFlIM0J0UzdBeUIyRXpsY1dXd2ZHREpETEdxRG54VmlTRnIyajRkdGpsVlhh?=
 =?utf-8?B?U2JuU3h4QXlSUjJZREJzUk4rVTJYS2FqdkJtTUMwN1dGd3pidmZqMFE5YU5P?=
 =?utf-8?B?VVdJUUtybjJockdPMHE4SFRFNzh1MkRneFRWM0JRRU14NjJJZDlxUTdjMUdp?=
 =?utf-8?B?dDNLRWV0TzdPa0U0dG9rc2ZCeFlva1MxTTZhQTltLy9vdEFEODc2YnFNMjRt?=
 =?utf-8?B?dUgzOWNRSUNDSTAvZzFRV1A4Q0xqaUVWcEhYQytCWXZ5bmsrSyt6Q01ZQXVQ?=
 =?utf-8?B?TFpQOEwwV1hCT1EwVEpnTDNEWUF4MG5nckxNbVZTNE9OanM2alNUT2pJVG5E?=
 =?utf-8?Q?7IoCSP6XOqHfe/tcVwGO13tWJ?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <5D0233C191724944977C2791FC064A08@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e0523af-0a2e-4fab-35d8-08daadd87379
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 11:37:18.7898
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mhuu2w6evgjqfdS7c4VTcVcSYp9u+RywBS2xXoJXA4JMgL6TRJCZ2poVJS7pS57rW5GRsMS3vJG4DVTa5wzuAN89lcIsVc+nrxeWCtCzeBM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5592

T24gMTQvMTAvMjAyMiAxMjoyNCwgR2VvcmdlIER1bmxhcCB3cm90ZToNCj4+IE9uIDEzIE9jdCAy
MDIyLCBhdCAxNjowMCwgQW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4g
d3JvdGU6DQo+Pg0KPj4gT24gMTMvMTAvMjAyMiAxNDowNSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6
DQo+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5IGIv
dG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2dlbmdvdHlwZXMucHkNCj4+PiBpbmRleCBhYzFjZjA2MGRk
Li5mZjRjMmFkMjE2IDEwMDY0NA0KPj4+IC0tLSBhL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5n
b3R5cGVzLnB5DQo+Pj4gKysrIGIvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2dlbmdvdHlwZXMucHkN
Cj4+PiBAQCAtNzIzLDcgKzcyMywxMyBAQCBkZWYgeGVubGlnaHRfZ29sYW5nX2ZtdF9uYW1lKG5h
bWUsIGV4cG9ydGVkID0gVHJ1ZSk6DQo+Pj4gICAgIHJldHVybiB3b3Jkc1swXSArICcnLmpvaW4o
eC50aXRsZSgpIGZvciB4IGluIHdvcmRzWzE6XSkNCj4+Pg0KPj4+IGlmIF9fbmFtZV9fID09ICdf
X21haW5fXyc6DQo+Pj4gKyAgICBpZiBsZW4oc3lzLmFyZ3YpICE9IDQ6DQo+Pj4gKyAgICAgICAg
cHJpbnQoIlVzYWdlOiBnZW5nb3R5cGVzLnB5IDxpZGw+IDx0eXBlcy5nZW4uZ28+IDxoZWxwZXJz
Lmdlbi5nbz4iLCBmaWxlPXN5cy5zdGRlcnIpDQo+PiBUaGlzIGJyZWFrcyB3aXRoIFB5Mi43LiAg
TmVlZHMgYQ0KPj4NCj4+IGZyb20gX19mdXR1cmVfXyBpbXBvcnQgcHJpbnRfZnVuY3Rpb24NCj4+
DQo+PiBpbnNlcnRpbmcgYXQgdGhlIHRvcC4NCj4gT3V0IG9mIGN1cmlvc2l0eSwgZGlkIHlvdSBu
b3RpY2UgdGhpcyBieSBpbnNwZWN0aW9uLCBvciAgYmVjYXVzZSB5b3Ugc3BlY2lmaWNhbGx5IHRl
c3RlZCBQeXRob24gMi43LCBvciBiZWNhdXNlIGEgc3lzdGVtIHlvdSB3ZXJlIHVzaW5nIGlzIHN0
aWxsIGFjdHVhbGx5IHVzaW5nIFB5dGhvbiAyLjc/DQoNClhlbidzIGJ1aWxkIHN5c3RlbSBjYW4n
dCBhY3R1YWxseSBjcmVhdGUgYSBidWlsZCB3aGljaCBzdXBwb3J0cyBQeTIgYW5kDQpQeTMsIGJl
Y2F1c2UgeGVuLmxvd2xldmVsLnt4Yyx4c30gb25seSBnZXQgYnVpbHQgb25jZS7CoCBJdCB3b3Vs
ZCBiZSBuaWNlDQp0byBmaXggdGhpcywgYnV0IC1FVFVJVFMsIHNvIHdlIHN0YXRlIGEgc3BlY2lm
aWMgdmVyc2lvbiBpbiB0aGUgc3BlY2ZpbGUNCmFuZCBtb2NrIGVuc3VyZXMgdGhlcmUgaXMgbm8g
dHJhY2Ugb2YgdGhlIG90aGVyIG9uZS4NCg0KWGVuU2VydmVyIGlzIGluIHRoZSBwcm9jZXNzIG9m
IHRyeWluZyB0byByZXRpcmUgUHkyLCBidXQgaXQgdHVybnMgb3V0DQp0aGF0IFhlbiBpc24ndCBh
Y3R1YWxseSBmdWxseSBQeTMgY2xlYW4geWV0LCBzbyB3ZSB1c2UgUHkyIGZvciBYZW4uDQoNClRo
ZSBidWlsZCBicmVha3MgYmVjYXVzZSB0aGUgbGlieGwgYnVpbGQgd3JpdGVzIHRoZSAuZ28gZmls
ZXMgZXZlbiB3aGVuDQp3ZSBkb24ndCBhY3R1YWxseSB3YW50IGdvIGJpbmRpbmdzIGluIHRoZSBl
bmQuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:42:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:42:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422829.669124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJ5I-0006Vp-Tu; Fri, 14 Oct 2022 11:42:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422829.669124; Fri, 14 Oct 2022 11:42:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJ5I-0006Vi-QB; Fri, 14 Oct 2022 11:42:36 +0000
Received: by outflank-mailman (input) for mailman id 422829;
 Fri, 14 Oct 2022 11:42:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mVin=2P=citrix.com=prvs=2797e9ea4=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ojJ5H-0006Vc-G2
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:42:35 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49c0da31-4bb5-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 13:42:33 +0200 (CEST)
Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 07:42:30 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by DM4PR03MB6032.namprd03.prod.outlook.com (2603:10b6:5:393::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 11:42:28 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%6]) with mapi id 15.20.5723.029; Fri, 14 Oct 2022
 11:42:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49c0da31-4bb5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665747753;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=TOZrasQg1zEFX7/yUjKWSpiyNeStJzzDFA1QgGgDeoY=;
  b=dWMAW1qAhIcv282+3T8ea6p+7SJgbS8L8ISZsMQnSsRdtnckX9gSXUW7
   M8+uUYdM9uUS/PzHPsKO7eoBRoL5mNVvV+m5cbFJRS97R73FwyV1izsgq
   fPMbl3NfCLDncTT5DVZtzDelF0JxsJ7c6LU1AHghCWVTUeZ4odOIiEGbk
   E=;
X-IronPort-RemoteIP: 104.47.59.175
X-IronPort-MID: 83157726
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:cKopqqAjlZRsZxVW/4Tiw5YqxClBgxIJ4kV8jC+esDiIYAhSlGxQk
 DNbHCvTJK7JMVJBSKl1O9izoU8GsJWExtJlGgBo+ShgFi1H8MadC93AIk2pZXrMf5edRU42s
 Z5BZIedcp5pQHaG+kyhauS+/CciiK/ZLlaQ5JYoHwgoLeMzYHtx2XqP4tIEv7OEoeRVIiuE6
 Ij/+sDWNACr12Z5YmxJs6zZph0xsP+ssmsV4QRmNKEXsAfSmUdOAcNEL8ldDZdarqp8RbfmG
 rmZnNlV2kuDon/B3/v8yu6TnnUiG+KUZ07W4pZvc/DKqgBYoSAv2boMOvMZaENG4x2EhNk0w
 9hW3XCKYV5B0pbkxaJMDnG0LwkkZfccoeeefSDl2SCu5xaun0XEkq0G4H4eZeX0ys4vaUlS+
 PoRLiw6bxzrr4paF5riF4GALux6RCXaFNt3VkNIlFk1Pt5/KXz3eI3Y5Mcw4dsFrpsm8cAyx
 SYuQWEHgBzoO3WjM7qMYX40tL/AanLXK1W0pL8JzEaeDqe6IAFZidDQ3NTpltOiR+d8tAWdl
 Ez8uDr3Ii9LFdGDzjff2yf57gPPtXuTtIM6MpSdr6QvrHjNg2sZBVsRSEexpuS/hgimQdVDJ
 kcI+y0o668v6EisSdq7VBq9yJKGlkdEB5wMTKtnuUfUlfe8DwWxXwDoShZuZds8u8JwaSEs0
 laRt9joGSZuoPueTnf1GrK8/WjrZHdKdzFqiSksbTAYzvi+ht8PkAPQHthfV4+4nIzrMGSlq
 9yNhG1k71kJtuYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPAwXjW6+xRarmQSFapt
 WIB3cOZ6YgmF5aWnjaKR+YLNL6s7veBdjbbhDZHAJ0J5zmrvXm5cuhtDCpWIU5oNoMIfGHva
 UqK4wdJvsYMYT2tcLN9ZJ+3B4Iy16/8GN/5V/fSKN1Tfpx2cwzB9yZrDaKN413QfIEXuflXE
 f+mnQyEVB721YwPIOKKetog
IronPort-HdrOrdr: A9a23:r7Pej6GDaJkwHOpqpLqFXpHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhd4tKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM
 RbAuVD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL
 aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlEawTjLqQntxK/xEhCe0BtbeShI260e/W
 /MlBG8zrm/ssu81gTX2wbontprcZrau5p+7f63+4sowwbX+0SVjUNaKvi/VQUO0aGSAZAR4Z
 3xSlkbToNOAjjqDxyISFPWqnXdOXAVmjPfIBaj8AXeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL
 lGxmSDqvNsfFr9dLSU3am2a/hGrDvCnZMZq59ks1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO
 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+
 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a
 gpfGkoxlLaIXieePFm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="asc'?scan'208,217";a="83157726"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Qkw3G1IXhOLIHkVfwcDjfnXdIlEYYYliU+l2UYfNKTdAzdnWvyvchR0uacid3p3oTZuQ+Mg0Et/7P4V259F/G5lxQMlsdKZdTyECy6n5ajIRRmAyStxGNu+S9g/iY7S9u4P10VUHrPB4y9ghWAy/xRPTUMAIQJ9Im5zZVMKALaBUHRuWE2c63k6NurEUGMLOjw9cyRLvfRTIf38XBxibC7+DIgot4xN6/q0vipHaRG/XEL/zD8LpwR+jU2nSk4ann43DiOozs3osQEvthbAdJcusx/CrxXA+0h/bb8pxwjybDLX5c9hyaS6tU5sPcajpO0OT0On7T673n2ADvM1txw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YUYAnCOl6FJHCAvCkNgS7MLqmz1eDvRsP4Ci0ztpp5k=;
 b=lwJTflCUAqzei4TGMCVs4eBZR9bWFCyW7GNlbQDxvNCebat/zKA5rxN5CS23JtfULIga4G3vjDAEBifKtaD0RWRSzXjX21OnZDHJlfhOcHLGfVDwihYDk2D8n82tRmcn6fNErULLQvoS056oCAdMEAvgBOsYgVyfQHcPNfcgtA/QomqsDUfecxd9ifGRtMeHWg1mW8rVvBtihC45cIZUHYH9Hv/2AhSo/qBq9gpojPbFAAjMXzaOSB8tdf4joogjeZKrw2TJp3WjW7MxnZBjmdILFZ/c1FSCimCA/gBKZxIymyGrAiPbA7fDplfpGh4V2c5SJ5FFPht8bIkqhOFFFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YUYAnCOl6FJHCAvCkNgS7MLqmz1eDvRsP4Ci0ztpp5k=;
 b=qUKqn3n5mNyEsqNvgp48EgUW81IOtBQgIwkP+GfaKZPoIHfP9MhzwMqBkfDllooqsDjaw590urEiK+491F1h805AhfQ9hEw35LmUqsT3w7Kobx9ov962SIgBdl/Vehl/pyPlrwh0DYHdAJJCrX3ywrKnacNSbkwor2+ppsXZAWg=
From: George Dunlap <George.Dunlap@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Henry Wang
	<Henry.Wang@arm.com>, Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Topic: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Index: AQHY3wTwBw4XcUEnKkOCwbXR47HHg64MavwAgAFV8ICAAAOrAIAAAWwA
Date: Fri, 14 Oct 2022 11:42:27 +0000
Message-ID: <AAAE12CB-696B-4736-93F8-0F8F81BE3687@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-17-anthony.perard@citrix.com>
 <3d5e662c-91b5-a390-c21e-90391961bd45@citrix.com>
 <C3A38BD5-E338-43BD-9EA1-3600378EE3B4@citrix.com>
 <532f15c0-8615-5196-e555-86a2d1094335@citrix.com>
In-Reply-To: <532f15c0-8615-5196-e555-86a2d1094335@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|DM4PR03MB6032:EE_
x-ms-office365-filtering-correlation-id: 6b1b7c93-48a9-4a13-49fc-08daadd92bb3
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 kDRMjZhyMrcofIwYY5VB2eSNs+QdypCgryinmLbr9FoMXqnriG5pthI2c1o37b92yMLRLnLS3CJrEclxhhuDBSab2WTbsv+bB4YDCSXd6+kxrNCh8gV5F6jnHWxz09rw+Tjp2H1Fia1kQjGH5QBKuJ1faG8O1qYOeH9cg/XQn2ARNWawRWUaGHCYwuH0hWZ8+53ZvJqRSzKe2oHCCsc1EXzdU7YuopYlLtn9skKCBq2+W9wrw+JPsNzGL9ooWX9owcwRhhpy+YzshNEWfjmg1f8AJ4P/PdjhNKi3KOrRtFIRm5qBvWl/oXkQjku3AGWMPZzIN9MQ9y2Woq8inu1asA6XPLb9z6zQd7lAkultI3zXjAvmRAcPb8rPAeeMt4enWJY4HS2qdNri27yCOosX3Tr4UixktwbPvbJlb4uavGfc3/3qKNOp7EcFHZFiu9wQcXJF0rO8SJXZQJ8+ssxQvuR+bCA3vXD71Lrr6QWhUAkXW15bBJ15zhRPZs8rXg4CmmX18Wd5Tz/9nn6KXbipet6zqzDxEpt5FXLGKBWFq0zvqEfxMCaLJY1L2U0AbOfu4q9zhn6p8C1j10/dYweILtYKk+gbG2FTejCE8wc4y0N5uu2nFDSubdlX2HM4T1tRCARvQTwmkap56lxFIvny//NSkDThKo38li5NjriGxzHGVMixPVxjptaEHc92jP/+c9Y4EF6DFI0dpoS09ZIP4Vgn4smoTnIfZBHxPeX3VkDYefO1EL4abmrV1dLSNA4Y/KH9FFws5Vn3tlJ5DIFx/eXkact89RCiazxNEgvT94PI31K8GrOfAV+2rnUvaNOr
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199015)(66446008)(83380400001)(6636002)(33656002)(316002)(66556008)(8936002)(64756008)(8676002)(76116006)(4326008)(6862004)(66476007)(41300700001)(54906003)(86362001)(36756003)(2616005)(122000001)(186003)(99936003)(91956017)(66946007)(6512007)(26005)(53546011)(37006003)(6486002)(5660300002)(38100700002)(478600001)(6506007)(82960400001)(71200400001)(38070700005)(2906002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WXVKa1FiTjJmSzNoK0w3eVkvODVmdWVqcE9wdCtPRXEzem14QUh1eXMvVld2?=
 =?utf-8?B?S2tDaUJXb20vVDFGSXF0Wk93SmVkWk1ldEJydlh6RXdMbHFxYUdsM1A2SHI1?=
 =?utf-8?B?NnZSSUxoOGI2RU9OUjhTbEVhblJqQ3g1dXhRSW14TThBcTNTZ2N1WDBTdHFj?=
 =?utf-8?B?K3RLWUxkV05PNUMreDRZcGl4aW45OU5IdFlSZFpSM2RoenI3WVczL3ZCeWRa?=
 =?utf-8?B?dUEvSm11dWgvbU1Nd1ErMGp1aU5jS1pmbDRlM0Q2bW9VQjF0M3RodDJjWkF3?=
 =?utf-8?B?cDBZU0lIRk1jYlczQXFyTzN4RHh4R0sxQloxZkJYRTJ4R29NeVNSUG1kdWNw?=
 =?utf-8?B?TnArL1F6aU5NelkxYVVJVytZU1dYOG9yT2tpc3YvcVk1LzEvUjFvczNYKzFF?=
 =?utf-8?B?NU9xQVZvb3lzQ1lIejNwUmJiekQvV2hWSFZ3eS9MZ011aWtrZmllUVNsY1Jr?=
 =?utf-8?B?SjQ4bWRBdDFXTXRFd09vK1Fxb3lKQW5vOElmdTFoemhEREFMSE54bm5PMWF0?=
 =?utf-8?B?UW9lTm5kbU1jNDZtUDdHdW1UWjlpQmcvQmZIZnhzcmxIQUQ3TXpxRHNhckpx?=
 =?utf-8?B?VkdRTXNyNjBRZ2ZLejMyS3IrUjNJZkRmbjdoT2oybDBTOW0rdFZLcWY3OGZu?=
 =?utf-8?B?ZTZwMm1OOW1RSkE4SE42OWJQU1dsRTRuajBuVUJVUEdoRHNTVW5YaVJpdWVn?=
 =?utf-8?B?SWp3NGpQaGlYZzdmUlVXeVlsejFFSUdSd1dqTHk3NDF6ZWQ2aGQzV1VtSzZD?=
 =?utf-8?B?RWVKL2hSM2pRVG9XMTl0Wm1EQTVoODZ0a1g0NWZwSXErc2VCVDlTVm93dTBH?=
 =?utf-8?B?R1dUdi9pTjRPUzQ2bHpvb3lqdDNHb2VQVDBqcHFMb0wwTXU2bUh2Y1lTR1BO?=
 =?utf-8?B?bUNXMFgzWElwL1ltVEZ3eUlwbDZaR2ZDY21UTmZxZ0VhVGdQNk01RmR4YUtz?=
 =?utf-8?B?RFdDaFdQb2RYWHNjYkgvY1drMXFzdUR4WWNEaEFMZU5leTRFb1NGQ0RVazA2?=
 =?utf-8?B?RldBWjNZaTZxZHRRYnIyQnhuWk5XSE5pNWVqWFU2V2VhVFpIeGpoM0FmUDh3?=
 =?utf-8?B?UTluRHBTNUh6c1hoQXhvVTlDQlp2amFRdEFUY2FFUHhBSmdjcmFreTBoZFZh?=
 =?utf-8?B?UEp5MUk2THFzQlNCS1VrVWNpV3pzZUh1Rzd4bGtuVXdlbFE0M1hsRXp0WVJP?=
 =?utf-8?B?d3FRZHg3ekJtR0pWYzBKNlFBczBnS3BuZFN5NGdISFlMbUxZWlh5V1d4REE0?=
 =?utf-8?B?a0Vhb2t2U05LdnNaWkt1eExNbWtCUGkramlKZy9yYjZEcngraVlVUVB4V2lo?=
 =?utf-8?B?L3oxK3RhcTA0UENwaXQ2Q2FFS2hJaVVSUzF6VXFYMTlUVit0QjZFSjFlbXZK?=
 =?utf-8?B?dGJsQUdEQlc0ZzZSTWs4bkhudUpGdm9PQ21SUWw3d1IvUU9mVGZTUXJaMk9O?=
 =?utf-8?B?RnZHdElPU2RwNyszYitFcmN6dkxEaGV3NGllWVZrSjZOTDQ3TTFQN3ZLZXM2?=
 =?utf-8?B?Y2tTSllZVnV4dU1Pa0ZBNU5nUENtSTdIUGgyNWoybmlndEpVVE5BOWtPN1g3?=
 =?utf-8?B?aFkwSVlvUkxhVjJqK1JtRjJucEVOM3h0OWlsd2xuQ2xzSVIwRHVKektsczFv?=
 =?utf-8?B?eXNtRVhwV1I1L1NFRHJHN0luWjg2OGk4RjU0VEhxZnlJVGwxcnNJMkhvZEZ4?=
 =?utf-8?B?Slk4T0Z3V2VRMFJFUVBpZ3MvWGs0Mkt5RnBEK2VZVzA2eUwzdzNUSW04N2VP?=
 =?utf-8?B?UU11UlJBaGpjbk1HM0QxcnFGZVRXb0kyVkNkWTRSU1hjVTNnMkkxWmhDckFw?=
 =?utf-8?B?TUF2SEZOSk5QelRXZ0szRFQ2UVg3Nitnalh5NFcyQURGMVk1SWRBWUVmbGhE?=
 =?utf-8?B?djNzc0Q1Qm5tZEp3aFhSekpYK1BFQXFDL3pEYnVMZnZZdm4zS1hkL1RtZVJP?=
 =?utf-8?B?TUg0SWYvdkxkRUlkaEQvYTdtQ3JJMEo5Tk0xcGtmMVg5OGF4MVBZZDVGV2Ix?=
 =?utf-8?B?SHFsUUxyOXhSaE96V0ZNR21lKzBEU0VZN1NrclplNnUxblRSeENpa2VydU5w?=
 =?utf-8?B?VzRCdzdKb2xiNnJHZ3J3YjN1UFczSWR6RUROVzVyV1pDZTJnbW1CZVlPMHgz?=
 =?utf-8?B?eDZKSFRqSC9UeCt6STFMa3RxeVRzUE9KNGZzZ1VOR0ltNUZYSWZlM1JrWTND?=
 =?utf-8?B?ZFE9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_042BFC7D-79A6-43FB-9A8A-A73E92828C28";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b1b7c93-48a9-4a13-49fc-08daadd92bb3
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 11:42:27.8712
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W+gjcM6UuvMKQ8XRPNNdp4Nan2PpZjZWjU97+FwBzbpvYK/ENmfKMJ1O/vpaEw/28+qSGrch0P3ByZrDkZtHg/6OlG/xrqps8eVNYCccpn0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6032

--Apple-Mail=_042BFC7D-79A6-43FB-9A8A-A73E92828C28
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_EBAF3AA4-D6F4-4329-9B97-EA1E8F467C95"


--Apple-Mail=_EBAF3AA4-D6F4-4329-9B97-EA1E8F467C95
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On 14 Oct 2022, at 12:37, Andrew Cooper <Andrew.Cooper3@citrix.com> =
wrote:
>=20
> On 14/10/2022 12:24, George Dunlap wrote:
>>> On 13 Oct 2022, at 16:00, Andrew Cooper <Andrew.Cooper3@citrix.com> =
wrote:
>>>=20
>>> On 13/10/2022 14:05, Anthony Perard wrote:
>>>> diff --git a/tools/golang/xenlight/gengotypes.py =
b/tools/golang/xenlight/gengotypes.py
>>>> index ac1cf060dd..ff4c2ad216 100644
>>>> --- a/tools/golang/xenlight/gengotypes.py
>>>> +++ b/tools/golang/xenlight/gengotypes.py
>>>> @@ -723,7 +723,13 @@ def xenlight_golang_fmt_name(name, exported =3D =
True):
>>>> return words[0] + ''.join(x.title() for x in words[1:])
>>>>=20
>>>> if __name__ =3D=3D '__main__':
>>>> + if len(sys.argv) !=3D 4:
>>>> + print("Usage: gengotypes.py <idl> <types.gen.go> =
<helpers.gen.go>", file=3Dsys.stderr)
>>> This breaks with Py2.7. Needs a
>>>=20
>>> from __future__ import print_function
>>>=20
>>> inserting at the top.
>> Out of curiosity, did you notice this by inspection, or because you =
specifically tested Python 2.7, or because a system you were using is =
still actually using Python 2.7?
>=20
> Xen's build system can't actually create a build which supports Py2 =
and
> Py3, because xen.lowlevel.{xc,xs} only get built once.  It would be =
nice
> to fix this, but -ETUITS, so we state a specific version in the =
specfile
> and mock ensures there is no trace of the other one.
>=20
> XenServer is in the process of trying to retire Py2, but it turns out
> that Xen isn't actually fully Py3 clean yet, so we use Py2 for Xen.
>=20
> The build breaks because the libxl build writes the .go files even =
when
> we don't actually want go bindings in the end.

I think the generation code is looped in even when golang is disabled so =
that we can detect IDL changes during development, even on systems which =
don=E2=80=99t have golang installed.  In theory if libxl.idl doesn=E2=80=99=
t change, it shouldn=E2=80=99t trigger the build?  Alternately we could =
consider skipping the code generation on non-debug builds, since we only =
really need to detect changes during development.

 -George

--Apple-Mail=_EBAF3AA4-D6F4-4329-9B97-EA1E8F467C95
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br =
class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div =
class=3D"">On 14 Oct 2022, at 12:37, Andrew Cooper &lt;<a =
href=3D"mailto:Andrew.Cooper3@citrix.com" =
class=3D"">Andrew.Cooper3@citrix.com</a>&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div class=3D""><meta =
charset=3D"UTF-8" class=3D""><span style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">On 14/10/2022 12:24, George Dunlap wrote:</span><br =
style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><blockquote type=3D"cite" =
style=3D"font-family: JetBrainsMonoRoman-Thin; font-size: 14px; =
font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-size-adjust: auto; =
-webkit-text-stroke-width: 0px; text-decoration: none;" =
class=3D""><blockquote type=3D"cite" class=3D"">On 13 Oct 2022, at =
16:00, Andrew Cooper &lt;<a href=3D"mailto:Andrew.Cooper3@citrix.com" =
class=3D"">Andrew.Cooper3@citrix.com</a>&gt; wrote:<br class=3D""><br =
class=3D"">On 13/10/2022 14:05, Anthony Perard wrote:<br =
class=3D""><blockquote type=3D"cite" class=3D"">diff --git =
a/tools/golang/xenlight/gengotypes.py =
b/tools/golang/xenlight/gengotypes.py<br class=3D"">index =
ac1cf060dd..ff4c2ad216 100644<br class=3D"">--- =
a/tools/golang/xenlight/gengotypes.py<br class=3D"">+++ =
b/tools/golang/xenlight/gengotypes.py<br class=3D"">@@ -723,7 +723,13 @@ =
def xenlight_golang_fmt_name(name, exported =3D True):<br =
class=3D"">return words[0] + ''.join(x.title() for x in words[1:])<br =
class=3D""><br class=3D"">if __name__ =3D=3D '__main__':<br class=3D"">+ =
if len(sys.argv) !=3D 4:<br class=3D"">+ print("Usage: gengotypes.py =
&lt;idl&gt; &lt;types.gen.go&gt; &lt;helpers.gen.go&gt;", =
file=3Dsys.stderr)<br class=3D""></blockquote>This breaks with Py2.7. =
Needs a<br class=3D""><br class=3D"">from __future__ import =
print_function<br class=3D""><br class=3D"">inserting at the top.<br =
class=3D""></blockquote>Out of curiosity, did you notice this by =
inspection, or because you specifically tested Python 2.7, or because a =
system you were using is still actually using Python 2.7?<br =
class=3D""></blockquote><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">Xen's build system can't actually create a build which =
supports Py2 and</span><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">Py3, because xen.lowlevel.{xc,xs} only get built once.&nbsp; =
It would be nice</span><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">to fix this, but -ETUITS, so we state a specific version in =
the specfile</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">and mock ensures there is no trace of the other =
one.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><br style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">XenServer is in the process of trying to retire Py2, but it =
turns out</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">that Xen isn't actually fully Py3 clean yet, so we use Py2 =
for Xen.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><br style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">The build breaks because the libxl build writes the .go files =
even when</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">we don't actually want go bindings in the end.</span><br =
style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""></div></blockquote></div><br =
class=3D""><div class=3D"">I think the generation code is looped in even =
when golang is disabled so that we can detect IDL changes during =
development, even on systems which don=E2=80=99t have golang installed. =
&nbsp;In theory if libxl.idl doesn=E2=80=99t change, it shouldn=E2=80=99t =
trigger the build? &nbsp;Alternately we could consider skipping the code =
generation on non-debug builds, since we only really need to detect =
changes during development.</div><div class=3D""><br class=3D""></div><div=
 class=3D"">&nbsp;-George</div></body></html>=

--Apple-Mail=_EBAF3AA4-D6F4-4329-9B97-EA1E8F467C95--

--Apple-Mail=_042BFC7D-79A6-43FB-9A8A-A73E92828C28
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNJSyAACgkQshXHp8eE
G+0yjgf+OaSSNFBJmDgR7mHzcUKvQRrYjWA361FUNk9P861rSxg3GE6ST4eyHjVX
58dQ2JyGVkt227R/5WmTDrzsaidPQrU+HG5OOTb+8xZh9fGakYxxVCSyPwPfwave
Y+XE0tNT7JkgmEmlTEkypC8DBDZacT/JO1HVfsMKejgboWgFdJXyBPLoGeXXiUfs
PGB95sCI6urWgqrN+1/ZnAfGF5wbWJZ9toK8QULiqigbJCGX4KycOF6UQS1cJpOs
D2yjStRQlG403D8TNssl+m24eIdshGGZAvmcnvdq7ygETgBJHfeub6XcA4Iomopt
jsAR5xdnBpAn2wtx+J+Lw2qVtu60aA==
=tW+q
-----END PGP SIGNATURE-----

--Apple-Mail=_042BFC7D-79A6-43FB-9A8A-A73E92828C28--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 11:51:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 11:51:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422838.669141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJE9-00085p-Tl; Fri, 14 Oct 2022 11:51:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422838.669141; Fri, 14 Oct 2022 11:51:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJE9-00085i-R0; Fri, 14 Oct 2022 11:51:45 +0000
Received: by outflank-mailman (input) for mailman id 422838;
 Fri, 14 Oct 2022 11:51:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojJE8-00085c-0e
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 11:51:44 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90469724-4bb6-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 13:51:41 +0200 (CEST)
Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 07:51:33 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CO1PR03MB5844.namprd03.prod.outlook.com (2603:10b6:303:9c::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 11:51:31 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 11:51:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90469724-4bb6-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665748301;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=7tJ3oaM3I3DHrV/kwEG9eudAEl4Y4kaFHd4Y00Al7BQ=;
  b=eC3DTz4y2BzHLUkR75xA5zPGLhiHOm2mNLK47L+8uSilBQzNOL6t0lLO
   a+1yfHwzn9RJuJpHLtRyhVPtkqXvcKecJvqZMF03Wgqu+YLd0iQEbUmP0
   QySP4BJIokBt4Ujtv9eV+YVa35whVdQdd7v+RSACgOBzl7Y8Vdpicr2bf
   I=;
X-IronPort-RemoteIP: 104.47.70.102
X-IronPort-MID: 81848817
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:9QwFf60D/h9h4JtsnvbD5e9wkn2cJEfYwER7XKvMYLTBsI5bp2MFz
 WMdX2iBPf3eNDT1c40lbIiz80sHvZTVzYQ3HQc9pC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GpE5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUK3NpxIGZn7
 McnayoGRReguuuczq6kH7wEasQLdKEHPas5k1Q5lXTzK6ljRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g3N4/NvuQA/zyQouFTpGPPTdsaHWoN+mUGAq
 3id12/4HgsbJJqUzj/tHneE1rafwXOrAd16+LuQydx7rQOPxkEoLyYHRQGwv+GSlFOfRIcKQ
 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZh5MbsY38vA/QzMC3
 0WM2djuAFRHqrqOQ2ia8bSShTy3MCkRa2QFYEcsUg8t89Tl5oYpgXryos1LFae0ipj/H272y
 jXT9Cwm3exL14gMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl
 BA5dwK2tYji0bnlePSxfdgw
IronPort-HdrOrdr: A9a23:3SSBSKxWSGcNPuusIiFuKrPxmuskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFjUO3VHFEGgM1/qE/9SNIUzDH6tmpN
 9dmstFeZDN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL
 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63
 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR
 /30lMd1opImjTslyqO0GbQMkHboUoTAjnZuBOlaDLY0LLErHhRMbs/uatJNhTe8EYup9d6ze
 ZC2H+YrYNeCVfakD36/MWgbWAiqqOYmwtUrQcotQ0obaIOLLtK6YAP9kJcF5kNWCr89YA8Ce
 FrSMXR/uxff1+WZ23Q+jAH+q3mYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/
 nNdq5oiLZNRMkLar8VPpZIfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4uKfaWK
 6xJW+wmVRCCH4GU/f+raGj2iq9MFmVTHDq1txU4YR/t/n1WKfrWBfzOmwTrw==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208,217";a="81848817"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cmzje8WrT5qm7JnXdYBL+6oT4Tu8M5S0PxvaK0O3Rd/46A+TfShKeIlFRO7U9+eENN4SGTKSS2Z/8b0rBFKjpUFOfo5THV9a6BYirzcq3UNuBZx8KkFyUfya3mMEh8Ze5Wj8Cscv0d0Bho8QN1BGsEhwjegXA7VKVZQ6+2RFQUUo/4CXG3mOsbjxVRG4bmc1PnBzecURtXCfDRB597Q1I9uJh4vW4TQ5HIVIJWK6etSIMHCz7KIoKAkMALVUqCT+TQCpBxONXyQnYuzo9LbzBmAWmT1vJwT4cfsvjJgJyb7BtlSDcn/j6kA8m/6k9eCnToLTPOZ0Eg5PnCA8juoFdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7tJ3oaM3I3DHrV/kwEG9eudAEl4Y4kaFHd4Y00Al7BQ=;
 b=SVS95ieKrzIA/L2iDPaFqkujwKQA3mQbHMdCXlOgyrKpu53YnBxKLu7BBcOzq4RKSulshQVXKPHVgj/7iEngmqND1tz1kA+6oCuHZpl9sR2bJNqfqLjKbCIjMco48Vw9Z7h9VliElOPNb67c7o8M3gvJLcxSmROB4dBqUTT/eA7oGU3G+BwS6bzi2q+zknO/tBQLQqHDbm+QxwXIYqpK1cl+Mw3QdQR5zl4RjkfpUTyci8BslUo4Zzoui9nmfuE6hp9qyqZgGT3CRrvQC91Xk8mtlscYteaAeYdfwcGhzuYDT35fuumBOQM0O+D4sCkeSt/3fv0L1Y8fWmWLl+criQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7tJ3oaM3I3DHrV/kwEG9eudAEl4Y4kaFHd4Y00Al7BQ=;
 b=KZu2AuuvPRhcEvFPXE3abeZXdVTkK4hoE2QoT5RlPIDBWy/jmIY7uFEB9/C+DKBemvlfvL1QBs88VdbW0Xiv8qPcn7OdVbHHIWbuzoJrlaaLd6Zz4PNdRONxxbaeZVWONwaqcq1apmNYTNWa9PKCahNxgGITQuof/z1hlHK8qj8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: George Dunlap <George.Dunlap@citrix.com>
CC: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Henry Wang
	<Henry.Wang@arm.com>, Nick Rosbrook <rosbrookn@gmail.com>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Topic: [XEN PATCH for-4.17 v5 16/17] tools/golang/xenlight: Rework
 gengotypes.py and generation of *.gen.go
Thread-Index: AQHY3wYExc++jpfrd0yvyakMPv5Mw64MavoAgAFV9YCAAAOmAIAAAXCAgAAChwA=
Date: Fri, 14 Oct 2022 11:51:30 +0000
Message-ID: <799df150-24de-fca8-d4a1-88aa2ab973ab@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-17-anthony.perard@citrix.com>
 <3d5e662c-91b5-a390-c21e-90391961bd45@citrix.com>
 <C3A38BD5-E338-43BD-9EA1-3600378EE3B4@citrix.com>
 <532f15c0-8615-5196-e555-86a2d1094335@citrix.com>
 <AAAE12CB-696B-4736-93F8-0F8F81BE3687@citrix.com>
In-Reply-To: <AAAE12CB-696B-4736-93F8-0F8F81BE3687@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO1PR03MB5844:EE_
x-ms-office365-filtering-correlation-id: 8001c940-367d-4087-630b-08daadda6f64
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Zfw1xomV7gbnZ6cJFlNzRUwu8dIaQc/W47bpAlssE9rBtU3W8hRXdduEXzLaFJUi0jZcpHK6C9CDsBYfXGDjPCZwcHGIIdBiZJzHyIhM/L4dIimKnXS4C/P2PPdXYjBNGnlRRSKdbUE2D9QQKw8OxRCcxubz5m9Olw8HcRYyxsuwTrE+e0u4/06wt3S7fRy+Lrt+o0oX/bffdpuTHAvM6h2RojKuOfK740TioH+5i6HC3th76Anf1vPpMEhY3zmOXKaBPXzAaXhYs3mjrGtpIKzGQeE1Xy4ThVTPtyF6RV9rCpTORJPpEpvYdHjIphoTwa8ZRxu3vcRh9mg/CIosPgUWsop6ipLA2NaWfbRPNAHY2Qh3+R7/VoyJRuVV2dF6ggRdZx4bYRiIQVtNodD6Lwlp751210ZXxf6czaFhDM8GDBKP3ENuPqjLP7xs00lFw3Yv4gXE4+9e4OuyHFMDDFDWnC1eAqRD2RDnrTQh73c9ffovmZqfanp4hcLSR8Zfhg0bGPz34jVVRK6RsiV30pvnjsMfS/BgFBksYJrPkQBzkKqYVLKTgt8J9AfD58gm/+m5iI3S9lvy0vqI0RU5ARpCyu1Nh58s4HbmAALsXfMVW5a2c/eMLkp2IPhVyw1V1kXWIZvKeKw1VuV80oKSgiK2jevXd+WT8EtLXTDok8l71xxTxPmB7ByhKcRtGntz4kRbZsFzXQSmlegKWZFJ8gqmCvsfcBn5q5yqDWaXooohyW7yqhd2clhyWuTCL/eKkhqRjOHgUT9OPdDmNm5qjqzGYc9LoBePOWuR3yUJR7jjD7t+wxkFo0soRRSQ2jwOe7O01MPL15Nt8GRwd+owUw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(366004)(451199015)(6512007)(2616005)(53546011)(26005)(6506007)(71200400001)(6486002)(478600001)(82960400001)(122000001)(38100700002)(86362001)(31696002)(38070700005)(83380400001)(186003)(36756003)(5660300002)(8936002)(31686004)(6862004)(2906002)(66446008)(66476007)(66556008)(66946007)(91956017)(4326008)(54906003)(6636002)(37006003)(8676002)(316002)(76116006)(64756008)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Sk5WSVhUZ29LTElkc0Z4dDFlZTh5QmgwQmczbHRSYm1hekE4bWJlVUhJN1Rm?=
 =?utf-8?B?cy83QmdEbzc4cXZhNmZ4ZUJjcC9pcnpYMzVGY3l4VGNjQ281Yzl6bnprUytO?=
 =?utf-8?B?ZEtkZnV5UVFZL1NYam41c0RSQnpaNXRPbllrdkt4N2dSNlNaL3Z3SENpU3BE?=
 =?utf-8?B?MW11dG9MTmIxVVhQSURwVHFFdGI0MkMrNlRyZGRYd3Vzc1lKVTVmYWxhTWdO?=
 =?utf-8?B?MWt5S0FsZGNuNDFWMFBucnlZT2ZEbUdMU25HT203R01rRkFzbEtMcUNGTnVB?=
 =?utf-8?B?aStjaElwSkxrMEVtUElJcVhncFdkUWpBNUFQZjRxelAvRkJQM1VUYk1xc2xk?=
 =?utf-8?B?QlJPYjk1ajBZSWJoL2UvTGcra3E4S1VvLzllWWJHMmNwbjdOK3dxN3dYTEE3?=
 =?utf-8?B?VkZqRDg2clJjbFpwZXpoRjYyMk5nbEdPSzdLbWVndDgxYXVuM2l2bzNXMXd0?=
 =?utf-8?B?ZlJ5YjRndktYa1JyQUxOMUc2TTlBNGxQVzBabmcwVDFZM3U0TEJKelVsMld5?=
 =?utf-8?B?MW94WXNkYVJGL2thYXAwYVlrTzhhc09FeXByQW16eDVGWUEwYzhoUmJjQitC?=
 =?utf-8?B?S2ZIS3RaUExSYjU1eEk5cG05YlRQb3hscVoxU3Frc1QrZkxoM3BLV29DMHdm?=
 =?utf-8?B?YlFCUWZ4NURTeFRWRzh0Mk1vVVI4ZnFGZW1zZ0hLdFJuWFBTaGRyNVRHQ2g5?=
 =?utf-8?B?U1c0OVIvL3VKYTJQb2JxYllCdkVEbWxIYlNCVGdFYythL09JTTR2VVkxWlQy?=
 =?utf-8?B?d0JmTUhBdmszS2UwbnB4TERPeE9RVmpGV1h0Mk5iVi9FUi9ZVzgvaGVTRUg1?=
 =?utf-8?B?bGpYR2hyR1JOTHh1NEZPNkhvZVV5djR4bWh5cXRSVDZySXRQNWwrdUhqblN3?=
 =?utf-8?B?elA4NVN3Rm96VzlWMWM5bm1TUStuSVpGWk8yWTNneVg0dU9EVGk5N2hYRlVa?=
 =?utf-8?B?bVVrOXNHN1V3eFptZFVSZnFUZ1BlMXI5RmNaSG90dGtKaFdmT3BNY1R6U2pC?=
 =?utf-8?B?RzdpT1hyaHpRbjRIdE1BSkdNTnFiM3IvaDN6UmoxejdMb1FCam1JeXEzVzYv?=
 =?utf-8?B?SVFEUVFNVkZ4bWZKa04zNUlTMTJwa3ZEMFU0djRNaXlud2U5cWdjVThIOGZF?=
 =?utf-8?B?UHduZ0JGUzBETW9vQUUyQTh2VVZRRFhmSUVoSkRXb0psSFFJdm44cS9jRGNN?=
 =?utf-8?B?ZCtyTndjeXJJUGxlY25MZG55b3I2N29EazBuRGlLbVVSK0FXQm5rKzlpSUhM?=
 =?utf-8?B?M2owSFF3ZkRyeUFjcG1nN2pxVCs1Q1BWWGJMWERwU014bjlJK2NibWE4WUsw?=
 =?utf-8?B?ZDd1dmtzRURVS2NONGtqdVBnRXRHLzV2RFl6WGtaeExCZ3BLTi9ERVB5dEI0?=
 =?utf-8?B?a1Q3ZjEwT0x3Mkp4NlF2REd1cHZMN0VwZisxZ0dGL2lBb0lYZUFxaklZRE5D?=
 =?utf-8?B?d1pYNWxvbjBSUm5oU3B4ZWo5Mk5VTk5xWlpDbnpmNkpyRjZXbXpHS3luR2xI?=
 =?utf-8?B?UjlmMjJUdlhrbld4RzNpZ2YvSDhaVDVJc1dBLzhFaXhsTHB4UzNsZnpDNjRT?=
 =?utf-8?B?aTVxc01HN2hrL2hGVG9Lams4UlY3Y1IzUzVZVjkyN1JySmxrN2lFdXIvUWJ5?=
 =?utf-8?B?ZEdZakJiSjFyclNsUjRXM005RjAwaE9WR3hmYjAyK0pKUnN5L3hod0ZraGRY?=
 =?utf-8?B?SlN1eDlwKzRONUVEV1d5Z040Q3l5Rm1vOUxXdXBvc0xsVEJLNzhRei81a0ZB?=
 =?utf-8?B?UXpvK01yczQ1UFpJa3F3eGJGdkI4MTBqUzYvTk5maHdoYzV1YkNzc2x6aWpa?=
 =?utf-8?B?QmZHd2xHS2E4QS9ianJ3WldPWEJ4eE1xcHdPY1VoSi9NbVptS3hMekF0TWk1?=
 =?utf-8?B?Q2wrQWxyZjJic3NGZG5mTUkwa05FRVplMDNUTzVxZy8wMWdyQkE4Si9nUTJz?=
 =?utf-8?B?azBnYTNFbkpxV2dNc2pyYVlhWFVvOG9HSHgzaTg2MVVpK1JLcGFQZEI0aVhF?=
 =?utf-8?B?Q0JmT1hkdVNPRTIwb2t2ZUxRbmtlZDF6eDNDd211dnVXY3B5VUZ3RzZNbVAy?=
 =?utf-8?B?c2hoNkRvNUthN0t2Y1VtK2I2UlJNY1ZlUmh2NE56ZFBwTjFOb0pnUStKeDNR?=
 =?utf-8?B?QlRQd2x6V2E2VGtDM1hvb1JPdXZzQUI0KzFCd1E3Z1dCb2p1V1Z1ZStYdmtj?=
 =?utf-8?B?OXc9PQ==?=
Content-Type: multipart/alternative;
	boundary="_000_799df15024defca8d4a188aa2ab973abcitrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8001c940-367d-4087-630b-08daadda6f64
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 11:51:30.9359
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Tq6Un5OuD/rwdigqBTOqRYxOCM6BsHeamQ41otsgmeUtQEqbo70MabrokV8TUvXCDH8lO1jHOIK1uyFlzz2gDoLasL/zq/prg0C0Jo108TY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5844

--_000_799df15024defca8d4a188aa2ab973abcitrixcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

T24gMTQvMTAvMjAyMiAxMjo0MiwgR2VvcmdlIER1bmxhcCB3cm90ZToNCg0KDQpPbiAxNCBPY3Qg
MjAyMiwgYXQgMTI6MzcsIEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb208
bWFpbHRvOkFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+PiB3cm90ZToNCg0KT24gMTQvMTAvMjAy
MiAxMjoyNCwgR2VvcmdlIER1bmxhcCB3cm90ZToNCk9uIDEzIE9jdCAyMDIyLCBhdCAxNjowMCwg
QW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbTxtYWlsdG86QW5kcmV3LkNv
b3BlcjNAY2l0cml4LmNvbT4+IHdyb3RlOg0KDQpPbiAxMy8xMC8yMDIyIDE0OjA1LCBBbnRob255
IFBlcmFyZCB3cm90ZToNCmRpZmYgLS1naXQgYS90b29scy9nb2xhbmcveGVubGlnaHQvZ2VuZ290
eXBlcy5weSBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5DQppbmRleCBhYzFj
ZjA2MGRkLi5mZjRjMmFkMjE2IDEwMDY0NA0KLS0tIGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2dl
bmdvdHlwZXMucHkNCisrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5DQpA
QCAtNzIzLDcgKzcyMywxMyBAQCBkZWYgeGVubGlnaHRfZ29sYW5nX2ZtdF9uYW1lKG5hbWUsIGV4
cG9ydGVkID0gVHJ1ZSk6DQpyZXR1cm4gd29yZHNbMF0gKyAnJy5qb2luKHgudGl0bGUoKSBmb3Ig
eCBpbiB3b3Jkc1sxOl0pDQoNCmlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6DQorIGlmIGxlbihz
eXMuYXJndikgIT0gNDoNCisgcHJpbnQoIlVzYWdlOiBnZW5nb3R5cGVzLnB5IDxpZGw+IDx0eXBl
cy5nZW4uZ28+IDxoZWxwZXJzLmdlbi5nbz4iLCBmaWxlPXN5cy5zdGRlcnIpDQpUaGlzIGJyZWFr
cyB3aXRoIFB5Mi43LiBOZWVkcyBhDQoNCmZyb20gX19mdXR1cmVfXyBpbXBvcnQgcHJpbnRfZnVu
Y3Rpb24NCg0KaW5zZXJ0aW5nIGF0IHRoZSB0b3AuDQpPdXQgb2YgY3VyaW9zaXR5LCBkaWQgeW91
IG5vdGljZSB0aGlzIGJ5IGluc3BlY3Rpb24sIG9yIGJlY2F1c2UgeW91IHNwZWNpZmljYWxseSB0
ZXN0ZWQgUHl0aG9uIDIuNywgb3IgYmVjYXVzZSBhIHN5c3RlbSB5b3Ugd2VyZSB1c2luZyBpcyBz
dGlsbCBhY3R1YWxseSB1c2luZyBQeXRob24gMi43Pw0KDQpYZW4ncyBidWlsZCBzeXN0ZW0gY2Fu
J3QgYWN0dWFsbHkgY3JlYXRlIGEgYnVpbGQgd2hpY2ggc3VwcG9ydHMgUHkyIGFuZA0KUHkzLCBi
ZWNhdXNlIHhlbi5sb3dsZXZlbC57eGMseHN9IG9ubHkgZ2V0IGJ1aWx0IG9uY2UuICBJdCB3b3Vs
ZCBiZSBuaWNlDQp0byBmaXggdGhpcywgYnV0IC1FVFVJVFMsIHNvIHdlIHN0YXRlIGEgc3BlY2lm
aWMgdmVyc2lvbiBpbiB0aGUgc3BlY2ZpbGUNCmFuZCBtb2NrIGVuc3VyZXMgdGhlcmUgaXMgbm8g
dHJhY2Ugb2YgdGhlIG90aGVyIG9uZS4NCg0KWGVuU2VydmVyIGlzIGluIHRoZSBwcm9jZXNzIG9m
IHRyeWluZyB0byByZXRpcmUgUHkyLCBidXQgaXQgdHVybnMgb3V0DQp0aGF0IFhlbiBpc24ndCBh
Y3R1YWxseSBmdWxseSBQeTMgY2xlYW4geWV0LCBzbyB3ZSB1c2UgUHkyIGZvciBYZW4uDQoNClRo
ZSBidWlsZCBicmVha3MgYmVjYXVzZSB0aGUgbGlieGwgYnVpbGQgd3JpdGVzIHRoZSAuZ28gZmls
ZXMgZXZlbiB3aGVuDQp3ZSBkb24ndCBhY3R1YWxseSB3YW50IGdvIGJpbmRpbmdzIGluIHRoZSBl
bmQuDQoNCkkgdGhpbmsgdGhlIGdlbmVyYXRpb24gY29kZSBpcyBsb29wZWQgaW4gZXZlbiB3aGVu
IGdvbGFuZyBpcyBkaXNhYmxlZCBzbyB0aGF0IHdlIGNhbiBkZXRlY3QgSURMIGNoYW5nZXMgZHVy
aW5nIGRldmVsb3BtZW50LCBldmVuIG9uIHN5c3RlbXMgd2hpY2ggZG9u4oCZdCBoYXZlIGdvbGFu
ZyBpbnN0YWxsZWQuICBJbiB0aGVvcnkgaWYgbGlieGwuaWRsIGRvZXNu4oCZdCBjaGFuZ2UsIGl0
IHNob3VsZG7igJl0IHRyaWdnZXIgdGhlIGJ1aWxkPyAgQWx0ZXJuYXRlbHkgd2UgY291bGQgY29u
c2lkZXIgc2tpcHBpbmcgdGhlIGNvZGUgZ2VuZXJhdGlvbiBvbiBub24tZGVidWcgYnVpbGRzLCBz
aW5jZSB3ZSBvbmx5IHJlYWxseSBuZWVkIHRvIGRldGVjdCBjaGFuZ2VzIGR1cmluZyBkZXZlbG9w
bWVudC4NCg0KVGhpcyBpcyBhICJjbGVhbiIgbW9jayBidWlsZCwgZnJvbSBhIGdpdCBhcmNoaXZl
J2QgdGFyYmFsbC4gIEFueSBsb2dpYyBsaWtlIHRoaXMgaXMgZ29pbmcgdG8gdHJpZ2dlciB1bmNv
bmRpdGlvbmFsbHkuDQoNCkl0J3Mgbm90IGEgcHJvYmxlbSBJTU8gLSB3cml0aW5nIG91dCBvbmUg
ZXh0cmEgdGV4dCBmaWxlIGlzIG5vdCB0aGUgc2xvdyBiaXQgb2YgYSBYZW4gYnVpbGQuDQoNCn5B
bmRyZXcNCg==

--_000_799df15024defca8d4a188aa2ab973abcitrixcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <92655CBA5E2F524CB7958334A63A7E0A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
bW96LWNpdGUtcHJlZml4Ij5PbiAxNC8xMC8yMDIyIDEyOjQyLCBHZW9yZ2UgRHVubGFwIHdyb3Rl
Ojxicj4NCjwvZGl2Pg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0ZT0ibWlkOkFBQUUxMkNC
LTY5NkItNDczNi05M0Y4LTBGOEY4MUJFMzY4N0BjaXRyaXguY29tIj4NCjxiciBjbGFzcz0iIj4N
CjxkaXY+PGJyIGNsYXNzPSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8
ZGl2IGNsYXNzPSIiPk9uIDE0IE9jdCAyMDIyLCBhdCAxMjozNywgQW5kcmV3IENvb3BlciAmbHQ7
PGEgaHJlZj0ibWFpbHRvOkFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20iIGNsYXNzPSJtb3otdHh0
LWxpbmstZnJlZXRleHQiIG1vei1kby1ub3Qtc2VuZD0idHJ1ZSI+QW5kcmV3LkNvb3BlcjNAY2l0
cml4LmNvbTwvYT4mZ3Q7IHdyb3RlOjwvZGl2Pg0KPGJyIGNsYXNzPSJBcHBsZS1pbnRlcmNoYW5n
ZS1uZXdsaW5lIj4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2Io
MCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAgICBKZXRCcmFpbnNNb25vUm9tYW4t
VGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0KICAgICAgICAgICAgICBub3JtYWw7
IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7DQogICAgICAgICAg
ICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVu
dDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6
IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1z
dHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBm
bG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lDQogICAgICAgICAgICAgICFpbXBvcnRhbnQ7IiBj
bGFzcz0iIj5Pbg0KIDE0LzEwLzIwMjIgMTI6MjQsIEdlb3JnZSBEdW5sYXAgd3JvdGU6PC9zcGFu
PjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsNCiAgICAgICAgICAgICAgZm9u
dC1mYW1pbHk6IEpldEJyYWluc01vbm9Sb21hbi1UaGluOyBmb250LXNpemU6IDE0cHg7DQogICAg
ICAgICAgICAgIGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsN
CiAgICAgICAgICAgICAgZm9udC13ZWlnaHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsg
dGV4dC1hbGlnbjoNCiAgICAgICAgICAgICAgc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7IHRleHQt
dHJhbnNmb3JtOiBub25lOw0KICAgICAgICAgICAgICB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3Jk
LXNwYWNpbmc6IDBweDsNCiAgICAgICAgICAgICAgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog
MHB4OyB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxibG9ja3F1b3RlIHR5cGU9
ImNpdGUiIHN0eWxlPSJmb250LWZhbWlseToNCiAgICAgICAgICAgICAgSmV0QnJhaW5zTW9ub1Jv
bWFuLVRoaW47IGZvbnQtc2l6ZTogMTRweDsgZm9udC1zdHlsZToNCiAgICAgICAgICAgICAgbm9y
bWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOw0KICAgICAg
ICAgICAgICBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyBvcnBoYW5zOiBhdXRvOyB0ZXh0LWFsaWdu
OiBzdGFydDsNCiAgICAgICAgICAgICAgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06
IG5vbmU7IHdoaXRlLXNwYWNlOg0KICAgICAgICAgICAgICBub3JtYWw7IHdpZG93czogYXV0bzsg
d29yZC1zcGFjaW5nOiAwcHg7DQogICAgICAgICAgICAgIC13ZWJraXQtdGV4dC1zaXplLWFkanVz
dDogYXV0bzsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDoNCiAgICAgICAgICAgICAgMHB4OyB0
ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxibG9ja3F1b3RlIHR5cGU9ImNpdGUi
IGNsYXNzPSIiPk9uIDEzIE9jdCAyMDIyLCBhdCAxNjowMCwgQW5kcmV3IENvb3BlciAmbHQ7PGEg
aHJlZj0ibWFpbHRvOkFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20iIGNsYXNzPSJtb3otdHh0LWxp
bmstZnJlZXRleHQiIG1vei1kby1ub3Qtc2VuZD0idHJ1ZSI+QW5kcmV3LkNvb3BlcjNAY2l0cml4
LmNvbTwvYT4mZ3Q7IHdyb3RlOjxiciBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCk9uIDEzLzEw
LzIwMjIgMTQ6MDUsIEFudGhvbnkgUGVyYXJkIHdyb3RlOjxiciBjbGFzcz0iIj4NCjxibG9ja3F1
b3RlIHR5cGU9ImNpdGUiIGNsYXNzPSIiPmRpZmYgLS1naXQgYS90b29scy9nb2xhbmcveGVubGln
aHQvZ2VuZ290eXBlcy5weSBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5PGJy
IGNsYXNzPSIiPg0KaW5kZXggYWMxY2YwNjBkZC4uZmY0YzJhZDIxNiAxMDA2NDQ8YnIgY2xhc3M9
IiI+DQotLS0gYS90b29scy9nb2xhbmcveGVubGlnaHQvZ2VuZ290eXBlcy5weTxiciBjbGFzcz0i
Ij4NCisrKyBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9nZW5nb3R5cGVzLnB5PGJyIGNsYXNzPSIi
Pg0KQEAgLTcyMyw3ICs3MjMsMTMgQEAgZGVmIHhlbmxpZ2h0X2dvbGFuZ19mbXRfbmFtZShuYW1l
LCBleHBvcnRlZCA9IFRydWUpOjxiciBjbGFzcz0iIj4NCnJldHVybiB3b3Jkc1swXSArICcnLmpv
aW4oeC50aXRsZSgpIGZvciB4IGluIHdvcmRzWzE6XSk8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9
IiI+DQppZiBfX25hbWVfXyA9PSAnX19tYWluX18nOjxiciBjbGFzcz0iIj4NCisgaWYgbGVuKHN5
cy5hcmd2KSAhPSA0OjxiciBjbGFzcz0iIj4NCisgcHJpbnQoJnF1b3Q7VXNhZ2U6IGdlbmdvdHlw
ZXMucHkgJmx0O2lkbCZndDsgJmx0O3R5cGVzLmdlbi5nbyZndDsgJmx0O2hlbHBlcnMuZ2VuLmdv
Jmd0OyZxdW90OywgZmlsZT1zeXMuc3RkZXJyKTxiciBjbGFzcz0iIj4NCjwvYmxvY2txdW90ZT4N
ClRoaXMgYnJlYWtzIHdpdGggUHkyLjcuIE5lZWRzIGE8YnIgY2xhc3M9IiI+DQo8YnIgY2xhc3M9
IiI+DQpmcm9tIF9fZnV0dXJlX18gaW1wb3J0IHByaW50X2Z1bmN0aW9uPGJyIGNsYXNzPSIiPg0K
PGJyIGNsYXNzPSIiPg0KaW5zZXJ0aW5nIGF0IHRoZSB0b3AuPGJyIGNsYXNzPSIiPg0KPC9ibG9j
a3F1b3RlPg0KT3V0IG9mIGN1cmlvc2l0eSwgZGlkIHlvdSBub3RpY2UgdGhpcyBieSBpbnNwZWN0
aW9uLCBvciBiZWNhdXNlIHlvdSBzcGVjaWZpY2FsbHkgdGVzdGVkIFB5dGhvbiAyLjcsIG9yIGJl
Y2F1c2UgYSBzeXN0ZW0geW91IHdlcmUgdXNpbmcgaXMgc3RpbGwgYWN0dWFsbHkgdXNpbmcgUHl0
aG9uIDIuNz88YnIgY2xhc3M9IiI+DQo8L2Jsb2NrcXVvdGU+DQo8YnIgc3R5bGU9ImNhcmV0LWNv
bG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAgICBKZXRCcmFpbnNN
b25vUm9tYW4tVGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0KICAgICAgICAgICAg
ICBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7DQog
ICAgICAgICAgICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0
ZXh0LWluZGVudDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hp
dGUtc3BhY2U6IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJr
aXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4dC1kZWNvcmF0aW9u
OiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAw
KTsgZm9udC1mYW1pbHk6DQogICAgICAgICAgICAgIEpldEJyYWluc01vbm9Sb21hbi1UaGluOyBm
b250LXNpemU6IDE0cHg7IGZvbnQtc3R5bGU6DQogICAgICAgICAgICAgIG5vcm1hbDsgZm9udC12
YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsNCiAgICAgICAgICAgICAgbGV0
dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50Og0KICAg
ICAgICAgICAgICAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFs
Ow0KICAgICAgICAgICAgICB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13
aWR0aDogMHB4Ow0KICAgICAgICAgICAgICB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBu
b25lOyBkaXNwbGF5OiBpbmxpbmUNCiAgICAgICAgICAgICAgIWltcG9ydGFudDsiIGNsYXNzPSIi
PlhlbidzDQogYnVpbGQgc3lzdGVtIGNhbid0IGFjdHVhbGx5IGNyZWF0ZSBhIGJ1aWxkIHdoaWNo
IHN1cHBvcnRzIFB5MiBhbmQ8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs
IDApOyBmb250LWZhbWlseToNCiAgICAgICAgICAgICAgSmV0QnJhaW5zTW9ub1JvbWFuLVRoaW47
IGZvbnQtc2l6ZTogMTRweDsgZm9udC1zdHlsZToNCiAgICAgICAgICAgICAgbm9ybWFsOyBmb250
LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBmb250LXdlaWdodDogNDAwOw0KICAgICAgICAgICAgICBs
ZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6DQog
ICAgICAgICAgICAgIDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3Jt
YWw7DQogICAgICAgICAgICAgIHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tl
LXdpZHRoOiAwcHg7DQogICAgICAgICAgICAgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNz
PSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5
Og0KICAgICAgICAgICAgICBKZXRCcmFpbnNNb25vUm9tYW4tVGhpbjsgZm9udC1zaXplOiAxNHB4
OyBmb250LXN0eWxlOg0KICAgICAgICAgICAgICBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBu
b3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7DQogICAgICAgICAgICAgIGxldHRlci1zcGFjaW5nOiBu
b3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDoNCiAgICAgICAgICAgICAgMHB4
OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsNCiAgICAgICAgICAg
ICAgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsNCiAg
ICAgICAgICAgICAgdGV4dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTog
aW5saW5lDQogICAgICAgICAgICAgICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj5QeTMsDQogYmVjYXVz
ZSB4ZW4ubG93bGV2ZWwue3hjLHhzfSBvbmx5IGdldCBidWlsdCBvbmNlLiZuYnNwOyBJdCB3b3Vs
ZCBiZSBuaWNlPC9zcGFuPjxiciBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9u
dC1mYW1pbHk6DQogICAgICAgICAgICAgIEpldEJyYWluc01vbm9Sb21hbi1UaGluOyBmb250LXNp
emU6IDE0cHg7IGZvbnQtc3R5bGU6DQogICAgICAgICAgICAgIG5vcm1hbDsgZm9udC12YXJpYW50
LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsNCiAgICAgICAgICAgICAgbGV0dGVyLXNw
YWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50Og0KICAgICAgICAg
ICAgICAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOw0KICAg
ICAgICAgICAgICB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDog
MHB4Ow0KICAgICAgICAgICAgICB0ZXh0LWRlY29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxz
cGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseToNCiAgICAg
ICAgICAgICAgSmV0QnJhaW5zTW9ub1JvbWFuLVRoaW47IGZvbnQtc2l6ZTogMTRweDsgZm9udC1z
dHlsZToNCiAgICAgICAgICAgICAgbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm
b250LXdlaWdodDogNDAwOw0KICAgICAgICAgICAgICBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0
ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6DQogICAgICAgICAgICAgIDBweDsgdGV4dC10
cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7DQogICAgICAgICAgICAgIHdvcmQt
c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7DQogICAgICAgICAg
ICAgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsgZmxvYXQ6IG5vbmU7IGRpc3BsYXk6IGlubGluZQ0K
ICAgICAgICAgICAgICAhaW1wb3J0YW50OyIgY2xhc3M9IiI+dG8NCiBmaXggdGhpcywgYnV0IC1F
VFVJVFMsIHNvIHdlIHN0YXRlIGEgc3BlY2lmaWMgdmVyc2lvbiBpbiB0aGUgc3BlY2ZpbGU8L3Nw
YW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseToNCiAg
ICAgICAgICAgICAgSmV0QnJhaW5zTW9ub1JvbWFuLVRoaW47IGZvbnQtc2l6ZTogMTRweDsgZm9u
dC1zdHlsZToNCiAgICAgICAgICAgICAgbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFs
OyBmb250LXdlaWdodDogNDAwOw0KICAgICAgICAgICAgICBsZXR0ZXItc3BhY2luZzogbm9ybWFs
OyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6DQogICAgICAgICAgICAgIDBweDsgdGV4
dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7DQogICAgICAgICAgICAgIHdv
cmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7DQogICAgICAg
ICAgICAgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNh
cmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAgICBKZXRC
cmFpbnNNb25vUm9tYW4tVGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0KICAgICAg
ICAgICAgICBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0
MDA7DQogICAgICAgICAgICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0
YXJ0OyB0ZXh0LWluZGVudDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9u
ZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5nOiAwcHg7
IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4dC1kZWNv
cmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lDQogICAgICAgICAgICAg
ICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj5hbmQNCiBtb2NrIGVuc3VyZXMgdGhlcmUgaXMgbm8gdHJh
Y2Ugb2YgdGhlIG90aGVyIG9uZS48L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAs
IDAsDQogICAgICAgICAgICAgIDApOyBmb250LWZhbWlseTogSmV0QnJhaW5zTW9ub1JvbWFuLVRo
aW47IGZvbnQtc2l6ZTogMTRweDsNCiAgICAgICAgICAgICAgZm9udC1zdHlsZTogbm9ybWFsOyBm
b250LXZhcmlhbnQtY2Fwczogbm9ybWFsOw0KICAgICAgICAgICAgICBmb250LXdlaWdodDogNDAw
OyBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOg0KICAgICAgICAgICAgICBzdGFy
dDsgdGV4dC1pbmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7DQogICAgICAgICAgICAg
IHdoaXRlLXNwYWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4Ow0KICAgICAgICAgICAgICAt
d2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNs
YXNzPSIiPg0KPGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWls
eToNCiAgICAgICAgICAgICAgSmV0QnJhaW5zTW9ub1JvbWFuLVRoaW47IGZvbnQtc2l6ZTogMTRw
eDsgZm9udC1zdHlsZToNCiAgICAgICAgICAgICAgbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczog
bm9ybWFsOyBmb250LXdlaWdodDogNDAwOw0KICAgICAgICAgICAgICBsZXR0ZXItc3BhY2luZzog
bm9ybWFsOyB0ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6DQogICAgICAgICAgICAgIDBw
eDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7DQogICAgICAgICAg
ICAgIHdvcmQtc3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7DQog
ICAgICAgICAgICAgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5
bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAg
ICBKZXRCcmFpbnNNb25vUm9tYW4tVGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0K
ICAgICAgICAgICAgICBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp
Z2h0OiA0MDA7DQogICAgICAgICAgICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxp
Z246IHN0YXJ0OyB0ZXh0LWluZGVudDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9y
bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5n
OiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4
dC1kZWNvcmF0aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lDQogICAgICAg
ICAgICAgICFpbXBvcnRhbnQ7IiBjbGFzcz0iIj5YZW5TZXJ2ZXINCiBpcyBpbiB0aGUgcHJvY2Vz
cyBvZiB0cnlpbmcgdG8gcmV0aXJlIFB5MiwgYnV0IGl0IHR1cm5zIG91dDwvc3Bhbj48YnIgc3R5
bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAg
ICBKZXRCcmFpbnNNb25vUm9tYW4tVGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0K
ICAgICAgICAgICAgICBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2Vp
Z2h0OiA0MDA7DQogICAgICAgICAgICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxp
Z246IHN0YXJ0OyB0ZXh0LWluZGVudDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9y
bTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5n
OiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4
dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3BhbiBzdHlsZT0iY2FyZXQtY29sb3I6
IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6DQogICAgICAgICAgICAgIEpldEJyYWluc01vbm9S
b21hbi1UaGluOyBmb250LXNpemU6IDE0cHg7IGZvbnQtc3R5bGU6DQogICAgICAgICAgICAgIG5v
cm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsNCiAgICAg
ICAgICAgICAgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt
aW5kZW50Og0KICAgICAgICAgICAgICAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1z
cGFjZTogbm9ybWFsOw0KICAgICAgICAgICAgICB3b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10
ZXh0LXN0cm9rZS13aWR0aDogMHB4Ow0KICAgICAgICAgICAgICB0ZXh0LWRlY29yYXRpb246IG5v
bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUNCiAgICAgICAgICAgICAgIWltcG9ydGFu
dDsiIGNsYXNzPSIiPnRoYXQNCiBYZW4gaXNuJ3QgYWN0dWFsbHkgZnVsbHkgUHkzIGNsZWFuIHll
dCwgc28gd2UgdXNlIFB5MiBmb3IgWGVuLjwvc3Bhbj48YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiBy
Z2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAgICBKZXRCcmFpbnNNb25vUm9t
YW4tVGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0KICAgICAgICAgICAgICBub3Jt
YWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7DQogICAgICAg
ICAgICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWlu
ZGVudDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3Bh
Y2U6IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4
dC1zdHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4dC1kZWNvcmF0aW9uOiBub25l
OyIgY2xhc3M9IiI+DQo8YnIgc3R5bGU9ImNhcmV0LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQt
ZmFtaWx5Og0KICAgICAgICAgICAgICBKZXRCcmFpbnNNb25vUm9tYW4tVGhpbjsgZm9udC1zaXpl
OiAxNHB4OyBmb250LXN0eWxlOg0KICAgICAgICAgICAgICBub3JtYWw7IGZvbnQtdmFyaWFudC1j
YXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7DQogICAgICAgICAgICAgIGxldHRlci1zcGFj
aW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0OyB0ZXh0LWluZGVudDoNCiAgICAgICAgICAg
ICAgMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsgd2hpdGUtc3BhY2U6IG5vcm1hbDsNCiAgICAg
ICAgICAgICAgd29yZC1zcGFjaW5nOiAwcHg7IC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBw
eDsNCiAgICAgICAgICAgICAgdGV4dC1kZWNvcmF0aW9uOiBub25lOyIgY2xhc3M9IiI+DQo8c3Bh
biBzdHlsZT0iY2FyZXQtY29sb3I6IHJnYigwLCAwLCAwKTsgZm9udC1mYW1pbHk6DQogICAgICAg
ICAgICAgIEpldEJyYWluc01vbm9Sb21hbi1UaGluOyBmb250LXNpemU6IDE0cHg7IGZvbnQtc3R5
bGU6DQogICAgICAgICAgICAgIG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9u
dC13ZWlnaHQ6IDQwMDsNCiAgICAgICAgICAgICAgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4
dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50Og0KICAgICAgICAgICAgICAwcHg7IHRleHQtdHJh
bnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOw0KICAgICAgICAgICAgICB3b3JkLXNw
YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4Ow0KICAgICAgICAgICAg
ICB0ZXh0LWRlY29yYXRpb246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUNCiAg
ICAgICAgICAgICAgIWltcG9ydGFudDsiIGNsYXNzPSIiPlRoZQ0KIGJ1aWxkIGJyZWFrcyBiZWNh
dXNlIHRoZSBsaWJ4bCBidWlsZCB3cml0ZXMgdGhlIC5nbyBmaWxlcyBldmVuIHdoZW48L3NwYW4+
PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseToNCiAgICAg
ICAgICAgICAgSmV0QnJhaW5zTW9ub1JvbWFuLVRoaW47IGZvbnQtc2l6ZTogMTRweDsgZm9udC1z
dHlsZToNCiAgICAgICAgICAgICAgbm9ybWFsOyBmb250LXZhcmlhbnQtY2Fwczogbm9ybWFsOyBm
b250LXdlaWdodDogNDAwOw0KICAgICAgICAgICAgICBsZXR0ZXItc3BhY2luZzogbm9ybWFsOyB0
ZXh0LWFsaWduOiBzdGFydDsgdGV4dC1pbmRlbnQ6DQogICAgICAgICAgICAgIDBweDsgdGV4dC10
cmFuc2Zvcm06IG5vbmU7IHdoaXRlLXNwYWNlOiBub3JtYWw7DQogICAgICAgICAgICAgIHdvcmQt
c3BhY2luZzogMHB4OyAtd2Via2l0LXRleHQtc3Ryb2tlLXdpZHRoOiAwcHg7DQogICAgICAgICAg
ICAgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImNhcmV0
LWNvbG9yOiByZ2IoMCwgMCwgMCk7IGZvbnQtZmFtaWx5Og0KICAgICAgICAgICAgICBKZXRCcmFp
bnNNb25vUm9tYW4tVGhpbjsgZm9udC1zaXplOiAxNHB4OyBmb250LXN0eWxlOg0KICAgICAgICAg
ICAgICBub3JtYWw7IGZvbnQtdmFyaWFudC1jYXBzOiBub3JtYWw7IGZvbnQtd2VpZ2h0OiA0MDA7
DQogICAgICAgICAgICAgIGxldHRlci1zcGFjaW5nOiBub3JtYWw7IHRleHQtYWxpZ246IHN0YXJ0
OyB0ZXh0LWluZGVudDoNCiAgICAgICAgICAgICAgMHB4OyB0ZXh0LXRyYW5zZm9ybTogbm9uZTsg
d2hpdGUtc3BhY2U6IG5vcm1hbDsNCiAgICAgICAgICAgICAgd29yZC1zcGFjaW5nOiAwcHg7IC13
ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweDsNCiAgICAgICAgICAgICAgdGV4dC1kZWNvcmF0
aW9uOiBub25lOyBmbG9hdDogbm9uZTsgZGlzcGxheTogaW5saW5lDQogICAgICAgICAgICAgICFp
bXBvcnRhbnQ7IiBjbGFzcz0iIj53ZQ0KIGRvbid0IGFjdHVhbGx5IHdhbnQgZ28gYmluZGluZ3Mg
aW4gdGhlIGVuZC48L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAsIDApOw0K
ICAgICAgICAgICAgICBmb250LWZhbWlseTogSmV0QnJhaW5zTW9ub1JvbWFuLVRoaW47IGZvbnQt
c2l6ZTogMTRweDsNCiAgICAgICAgICAgICAgZm9udC1zdHlsZTogbm9ybWFsOyBmb250LXZhcmlh
bnQtY2Fwczogbm9ybWFsOw0KICAgICAgICAgICAgICBmb250LXdlaWdodDogNDAwOyBsZXR0ZXIt
c3BhY2luZzogbm9ybWFsOyB0ZXh0LWFsaWduOg0KICAgICAgICAgICAgICBzdGFydDsgdGV4dC1p
bmRlbnQ6IDBweDsgdGV4dC10cmFuc2Zvcm06IG5vbmU7DQogICAgICAgICAgICAgIHdoaXRlLXNw
YWNlOiBub3JtYWw7IHdvcmQtc3BhY2luZzogMHB4Ow0KICAgICAgICAgICAgICAtd2Via2l0LXRl
eHQtc3Ryb2tlLXdpZHRoOiAwcHg7IHRleHQtZGVjb3JhdGlvbjogbm9uZTsiIGNsYXNzPSIiPg0K
PC9kaXY+DQo8L2Jsb2NrcXVvdGU+DQo8L2Rpdj4NCjxiciBjbGFzcz0iIj4NCjxkaXYgY2xhc3M9
IiI+SSB0aGluayB0aGUgZ2VuZXJhdGlvbiBjb2RlIGlzIGxvb3BlZCBpbiBldmVuIHdoZW4gZ29s
YW5nIGlzIGRpc2FibGVkIHNvIHRoYXQgd2UgY2FuIGRldGVjdCBJREwgY2hhbmdlcyBkdXJpbmcg
ZGV2ZWxvcG1lbnQsIGV2ZW4gb24gc3lzdGVtcyB3aGljaCBkb27igJl0IGhhdmUgZ29sYW5nIGlu
c3RhbGxlZC4gJm5ic3A7SW4gdGhlb3J5IGlmIGxpYnhsLmlkbCBkb2VzbuKAmXQgY2hhbmdlLCBp
dCBzaG91bGRu4oCZdCB0cmlnZ2VyIHRoZSBidWlsZD8NCiAmbmJzcDtBbHRlcm5hdGVseSB3ZSBj
b3VsZCBjb25zaWRlciBza2lwcGluZyB0aGUgY29kZSBnZW5lcmF0aW9uIG9uIG5vbi1kZWJ1ZyBi
dWlsZHMsIHNpbmNlIHdlIG9ubHkgcmVhbGx5IG5lZWQgdG8gZGV0ZWN0IGNoYW5nZXMgZHVyaW5n
IGRldmVsb3BtZW50LjwvZGl2Pg0KPC9ibG9ja3F1b3RlPg0KPGJyPg0KVGhpcyBpcyBhICZxdW90
O2NsZWFuJnF1b3Q7IG1vY2sgYnVpbGQsIGZyb20gYSBnaXQgYXJjaGl2ZSdkIHRhcmJhbGwuJm5i
c3A7IEFueSBsb2dpYyBsaWtlIHRoaXMgaXMgZ29pbmcgdG8gdHJpZ2dlciB1bmNvbmRpdGlvbmFs
bHkuPGJyPg0KPGJyPg0KSXQncyBub3QgYSBwcm9ibGVtIElNTyAtIHdyaXRpbmcgb3V0IG9uZSBl
eHRyYSB0ZXh0IGZpbGUgaXMgbm90IHRoZSBzbG93IGJpdCBvZiBhIFhlbiBidWlsZC48YnI+DQo8
YnI+DQp+QW5kcmV3PGJyPg0KPC9ib2R5Pg0KPC9odG1sPg0K

--_000_799df15024defca8d4a188aa2ab973abcitrixcom_--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 12:00:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 12:00:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422845.669151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJMt-0001Ih-V7; Fri, 14 Oct 2022 12:00:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422845.669151; Fri, 14 Oct 2022 12:00:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJMt-0001Ia-Ra; Fri, 14 Oct 2022 12:00:47 +0000
Received: by outflank-mailman (input) for mailman id 422845;
 Fri, 14 Oct 2022 12:00:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojJMs-0001IU-8w
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 12:00:46 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60059.outbound.protection.outlook.com [40.107.6.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d552ea0c-4bb7-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 14:00:45 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6966.eurprd04.prod.outlook.com (2603:10a6:20b:109::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 12:00:43 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 12:00:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d552ea0c-4bb7-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jFXccE0uBKmhsjoa7gGON9nN7t8wT8tjyMPgTf7hI4+lwBOkFpJ6oeqXzXSAsR4dn56U/Z3x5CyrwjbCp+7xzOYQK/0+IEdh9Z68+KAkS6nSB3iilRU2xNHVAfC2RnGoeo5Bm3Hx3yN6rXwsMsziKFm/W6PpXRRSuGJk2xGCC5WL4ouBIFAKYPE843Y7GkHQAn3lSmJwIuZvjQSedPVk2aBuN4axGU+Diw3CK8XhM25njXZ7e5Clh3L3Ucg318bApX2gXnks26jlL134sqsbrMDw2lEJGlLzMOuOh4hwkvbA8IQfwiwCk0eXBbXR16J7RP4/mbQxu3RqNMxuWE7OCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OBiTkr1oxxv/4yoo989+RzrA1PdxQINdACqpm1fb1kA=;
 b=gJZ5mhQZhGqpx3BLYYxy7e6KnRT89acTvSl1VbYHlP4hjs/he/0ezbDk6C4Exq3gbkG8wungToxJ0S/o8v2f5LfknDNcujc6OaxJEKHtD+7ipx/tHuIoA1e01HyL977KaeAKQYssQZwR1cLMQcyuLTjydKTnGXEsWrjjhoJnpAtFVwWL/hh9CnPCYem+kIN7c6Gf7Qpmd1JQER3fsZ2ljGaL0FAWfNgksY62119BQN183kRisyAKm4x8wHFtD492f+YsofUWY0RRpAHRr0TlkU0GLkhvuPp5zwn99hsVDuXEwlMu3ISPpi0EIKYGqeZqYtlQW15s6/r/nexBtW9myg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OBiTkr1oxxv/4yoo989+RzrA1PdxQINdACqpm1fb1kA=;
 b=Jofm+8tct/6hlILHUUrgQrnWHBzrn6bOByAgvW8Gx4b4RJrxIk4vyUJZusiJjYYGbKCjiZGkGhP3zVgSRnSsJ3VQiVtAIRZozYM4d7YAtQTH85WGdFGZGTVzP+leHrAGM+nVq0BBAa4Vvl67ihgZ1Vq9Uzp679lnCrFjQG1BxV0Dz9xXa5LcSjfXgv80jvoP17nZuG6+nUFr4vtRIZNaqgcd0Cz5/w7mgPtIRfoSDnpeU4aJUAUSHDZKs+fDp/uPwWEfRAgSKrCCchPVvu5i3cciB9bNQV1Bb1AC1PAGaJvFXU1GP62Qdm5TpJIKVjfE12bpQ5vS7N06Ar24Tk6RMQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9adb1562-236e-2856-5977-0c563b0af024@suse.com>
Date: Fri, 14 Oct 2022 14:00:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
 <AS8PR08MB79919FFC44E975825EE9CB3392249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e60803a6-44c5-9d22-88b5-c924ee854fca@suse.com>
 <AS8PR08MB7991A81D931E20A000FEFE0092249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991A81D931E20A000FEFE0092249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0014.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6966:EE_
X-MS-Office365-Filtering-Correlation-Id: 7fb1c089-dc79-46db-a043-08daaddbb836
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EKmeY/Rl+xrPR05MhpRz89ddbsyuT7OoWrMpAsyKsJWBOhrZJb8cr0nvNUfetkYS9g2/k+64VyUhKnceo9ftvQvt4GSJ/jrMJxPTsETI0gS3naW02m4T12vF6o+OOfOl32bUmZMF2asO8AbUdUZE8+qxZwyGlih587+OCESWtXJisteXzKR/uKkDIMPxy6bj13yApIx6t32583e4352qJoZ5tZkBT57wES5PYbAA+avn6iOWo2xM4SesSBuEZcx7ucwmqoVWtnJv8JGjnU8/1kdEyPpmQWhNtOqPMNx1iGwFQsSjZuvhoTTJdAHI53kw7JgiVf5YggJkW9JtCinItTTKq+RD8s2CTFhHb5fMU9mgsUTHfvygIBs8YfHCAn0+Bb3WKlolG0DV8e1HH/RkMelCpIzofbBEfjFtJGXz3whcxbs5x2QVztYzAJhpRr5vAMg6o/1TdRDWGep3w5b/2e6k76oyNAZtusYAhI+ahKTp7RpMpavsQJZjIsEhok38CqDjep/zhFKus2yBr2OP2nlW2k86BSUMY6Twpxd4DJ0muCUiq9O5/uJAEE/VKEqPpYNlwcwGng8O8CKMStR9x8wWTDMQGvgNr/fpgHDid4bzEBHARajBpoa0VbD+QgOQLO6MpZVdnTMIo4hmHQ7tt4qiSgzYcxJ8Ghbd/Gq5Xmzo08d/0d0HGEic7cThJqe44J/vP1sm56VtWFM7pHiTJdBbAN9ZVadHj21b4uHJ6wNsRrDkcSsrfGeI9uUgrIkMONdibLaoaBbSnJSFe0Ihm0/mlMKS9OCSLktP+WfQhRE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(2906002)(5660300002)(186003)(6506007)(6512007)(2616005)(8936002)(26005)(41300700001)(53546011)(38100700002)(86362001)(31696002)(83380400001)(36756003)(316002)(8676002)(478600001)(6916009)(54906003)(31686004)(6486002)(66476007)(66556008)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0YvVVdLQnVPc3BweE9zVThtSWVJbk9hVjA3aDArbmt1clk5MUF6d1NnNzZN?=
 =?utf-8?B?cnYrNUVpS3ZFV2JQbXNFenFNRVRrQ3J6dHRKSlYrcUdrOEhydGpWbWpjRTZ5?=
 =?utf-8?B?SmxuV0ZkMmZic2tkS0tTRzVjQmlUdGFiM2FEWTdUdlZXNDlBY29nOVdYbXJr?=
 =?utf-8?B?UTZhNEF2QTZLcTBFWE9CallZNGFIcEljeVRNZTJUM0prOTNOQnJ6SzFPTXVo?=
 =?utf-8?B?d2tDWmlLeHh1djZlUnRybVNEYWQzSm4yT0JkeExkOUZUOVoyNmRKNWRld0h1?=
 =?utf-8?B?aVVDZGk4RndRTGJzR1pNN1g4cEF3RmI4anhxQlJmS3R5ZE9jWUdEbWp5V1BN?=
 =?utf-8?B?VWR5WDBlNCswWmFiZXVRQWJiWlZRU3BBRzM2TDA0aGJRUm4wVUhJZUcwVEw5?=
 =?utf-8?B?eldsUHNpNWdJeDRybWIzSWRnZjVLVjRlWWxsNHVheng4MWlqSVFEUnYyWmVm?=
 =?utf-8?B?c3N6Y3dWZ2h6bWp4SWI4eWZ4WFRYaWRibHVZamJrYkdvNHE0VXBSUzhvSXJo?=
 =?utf-8?B?MldFRUVmcDA3emZPOTRKL1ZZNFFDM3BBZnltbnB2TXZSMWhOOGZSWFpnR0tL?=
 =?utf-8?B?TGlWaVc1RWhEaGhIbUhXczVGYVAzK05oSFRyUFBpTWx1SlFGbDFRUHU1SXli?=
 =?utf-8?B?SVR5bWwyTG1HS3BadTl3RjZ0ei9sdUNXMGMrWFlmS0ptQVlwbllZWnFZTysr?=
 =?utf-8?B?ZTZRWi9kNVhDMDZXcXAxRUFGV01EcitHK3UyZzN5d2xZNzBOZW5pb0dRUVJE?=
 =?utf-8?B?TmdFYy9RSHJlR1BQNEJ2OS96OGN4RTlaeVN0bWMwdFRMZEhyczNGUXBVVlhn?=
 =?utf-8?B?UkpkdndmdFN5M0pLU3ZWdmIwL3ErMm9BK1ZSR25UL0FlVzJJN2hRczMyZDBj?=
 =?utf-8?B?UHVZOEJwR0dXRGFXbko4NUVUd1IyMHVFV0h4NVU4V1BCWk1vSDNiaC9wYVBC?=
 =?utf-8?B?Mzlhelp3aXVVRWViY3h4U1hjZmpablF0UHdXYnZtdS80cldwdExiYW5BZjJO?=
 =?utf-8?B?cTlqSkhlVGRDNWNXK1A0MVN5YzBROFhPaU5JTlpCTzF2ZHhibS9RU3BxS3RL?=
 =?utf-8?B?ZE4ycGNWWGZVUnJKMGdlZmVpOXVWNU9XQTJvdlUwMzNLUHY1V0JhTzkrSkZi?=
 =?utf-8?B?c05NTkJoZ1dqUE9iRTJaWGpjODVtVTNxU3E2NExOZzNXVDcya1hwVjRzcGJ1?=
 =?utf-8?B?WitkVzliMXpKL2lQVldMWHZTT1hYMyt4d1pjS2R4Nk9RMkFlZU5jSFdJUDZ5?=
 =?utf-8?B?L2Jta1RPUEo5M09VQXNTQ3NmTzllMDlZeVcyYnBVdzVhcFVtdFpnUGVLNk52?=
 =?utf-8?B?dHU5TUNKNmRjTkU4SG9rQlVzNjVzYTVBa2QxUjIvTlVyT3QwdVduUmZ2Vm00?=
 =?utf-8?B?OXV4cHZYQzVxRnptTVFuN3lETUwwMEthUTZzK1dIb1NCNENMZERjTG1leDR6?=
 =?utf-8?B?TGV2MGNYMFQ3MklXSmtJTDErdjZ2K0Z2VVEzM3dNaC9uZFZCZkIwSE9OczQ5?=
 =?utf-8?B?MkRQczVTSnJORXlRRlQvaFJvMUs5TEZQYzRxemp5Q0k3QUNzbG8ybmRiWG5t?=
 =?utf-8?B?M3RoUjNqUXh0TDkxWjNUeHZnKzdOSFhQZWdTQTM5bXYwRGs3cjBxTnpua1NU?=
 =?utf-8?B?c0V1QUxLd2F2U2JNTkpWOUVnbGk0RWgzRG1DVFNRMDg4dkdBREF1WDYvVEU0?=
 =?utf-8?B?bEQ1V2VtMjNGMGpZUVI3akNlYXR0ZDFWQ0hEQlBpUG50ZllERUxBbmJmSHFV?=
 =?utf-8?B?aUk4TjZPM01YaWlBNHlJK1d6Sk1XT2RSbHNCd1VyWC9RSXR2Q05FVmpOanYw?=
 =?utf-8?B?aVhQTThNK0JhZXZxL2NHZWhzWk9qZzhaOE94UVRoOGZsN3FxWUxHYy9TeDNW?=
 =?utf-8?B?ckxNaGdOSWhBTUIzeU9vcFlCWEQycEE4WENLYzBUVHZOKzVZNzkxQWhYY3dI?=
 =?utf-8?B?QmNEUklLNDdTS0lvTWpKTjBlQ2VKcHJjamJFS2M5L3I1MDRyVW5GbUNCV2hU?=
 =?utf-8?B?aGVtdGlxd0VGU21XNEhsbFhkaElZTnlnMzQvOW1VU1hEWGpIRHk5bWN6WFR5?=
 =?utf-8?B?bU9ETHZseDJrMGFyb3ppbEw0YmIwbzdyT2FDaFpxeld0UFRMNmV4b0J0cTFo?=
 =?utf-8?Q?vAH5RseRuHwu+gcAMS+28XmFV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb1c089-dc79-46db-a043-08daaddbb836
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 12:00:42.8095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vCKCAwhBeFclciHHjX4Rr96OvzmX/fjiaw5c+U7IhYm9U5TpP9jjh5AbRzs41XI384wwkCv5Bnj/fqbQ55jZBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966

On 14.10.2022 13:04, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>>
>>> My initial thought is the "else if" part in p2m_set_allocation. It might be
>>> wrong. Would the code below seems ok to you?
>>>
>>> int err;
>>>
>>> do {
>>>     err = p2m_teardown_allocation(d)
>>> } while ( err == -ERESTART )
>>
>> Sure, one of several ways of doing it.
> 
> Thanks for your confirmation. Just to play safe if you have more simple
> Solutions please do raise it. It is a good opportunity for me to learn and
> personally I am not a big fan of either do-while or the introduced "err"
> which is used only by p2m_teardown_allocation(d), considering the
> p2m_final_teardown(d) has a void return type...

Personally I would probably have written

    while ( p2m_teardown_allocation(d) == -ERESTART )
        /* Nothing - no preemption support here. */;

or

    while ( p2m_teardown_allocation(d) == -ERESTART )
        continue; /* No preemption support here. */

. Otoh with the "err" variable you could ASSERT(!err) after the loop.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 12:11:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 12:11:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422851.669162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJWx-0002pz-UV; Fri, 14 Oct 2022 12:11:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422851.669162; Fri, 14 Oct 2022 12:11:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojJWx-0002ps-RD; Fri, 14 Oct 2022 12:11:11 +0000
Received: by outflank-mailman (input) for mailman id 422851;
 Fri, 14 Oct 2022 12:11:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+Pkr=2P=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojJWx-0002pm-35
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 12:11:11 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 46254805-4bb9-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 14:11:04 +0200 (CEST)
Received: from DB7PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:10:52::16)
 by PAXPR08MB6591.eurprd08.prod.outlook.com (2603:10a6:102:150::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Fri, 14 Oct
 2022 12:10:53 +0000
Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:52:cafe::ff) by DB7PR02CA0003.outlook.office365.com
 (2603:10a6:10:52::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Fri, 14 Oct 2022 12:10:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 14 Oct 2022 12:10:52 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 14 Oct 2022 12:10:52 +0000
Received: from 82e858498529.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3DFE2B90-6492-470E-8445-64B2BCC284A9.1; 
 Fri, 14 Oct 2022 12:10:41 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 82e858498529.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 14 Oct 2022 12:10:41 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB8PR08MB5355.eurprd08.prod.outlook.com (2603:10a6:10:11f::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 12:10:39 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%7]) with mapi id 15.20.5709.015; Fri, 14 Oct 2022
 12:10:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46254805-4bb9-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=kNrnunlGyrYJWDtvWrsRUag5bCic1XyTgDtdgz4yWfuVWhYFiqX7Ze5aCYBYn92oIrPhur6vPqeWvcQTe0qKsnZhHvBVxZWffyBMa3M04YY3eHFHEsWTCbiIntYsJ+tqK8ovYBUNyvhqAX8rwR+dVBiuBDgEjTviX9skuFVzXDzcKuuHjZ/lkWoiuRxnI+/McwJ6lLgPwldVjDjYcL8GLOVSV/1nD+Z5sFZOnujmt7mofKE9zXyj7jqPLYRIZj8FkR7VGwZ7IAF2nfJidsu1SiB2FojfY7b81ociu1/fCxIDUTkJ+4LPP+i3mPIwMbWXbWvAWziqx3khH0m70X76iw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DhGkMGBtWQoFDpTCLjROZmvmBwHuk6kZyrUC2Qf9RXk=;
 b=Y0JfrWKVFC72ZXEu219i7ZOZaBazyhqAe1U5oeFEcdWme5kJeYLLlreVjzuoUvcsyrTAQBUpbWAjOmLweWSohm9cqljoVQOJMuTFtGuOhW0bXLMGNzQ2FX33rc0n7wpB2CQFTBGi9GuAVxiJikRIy+60dzrvtG6VoNdhgEpMAidlwSMf5O/7m3jsPpQpqn1oKctol7Uyn4csls9Own9oPsOHM53aHXLmi++4SEuHAg7bhsCZZE7vAG7I/WOIRgRUAVJ4VT1h9SoPvVIElw/jfyOd7otFLDcnc4aI8vcuADSIvuw+Af6ZyKJiQJPVBM444E4WaxqzWZv5YmUiGsH9rg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DhGkMGBtWQoFDpTCLjROZmvmBwHuk6kZyrUC2Qf9RXk=;
 b=kLYzCRm1T3SWedhULpwgfZX+0XIyMQI0xn7pXjBG/RdPTEb3PF2yIV7tWTF9W5Lx+fj4GrYySSrNMYDT9xvC5TDNmfRz1u1crTVvVbjZxiLNPXFxkEBm5eFjrIfJfrKdRTncCrYbZJol43uNDerqAU58Atb0nY780WO4x1g5Yog=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TtywUq3tbC3scmkUCyWWNIoWIrDSAZJOAbA/EIfcimEDNMPGJrXa72NhCxQN0HhDThFjbSy7I/BDFj2RT329kIk+wwLUoVGe0UJbAOX38fZq697lhOKBJ4x9RLzpsO3t1RuVL/W/AEEHV7urEwOVOIsrdOO1wrKFPhUwgCOikMAA5Rta8Hvs0pLimg9Ai/shxF3G4GfVNh7FaY3Mwz+uysLWbrSl8b0GA+Yhtr1n1YEpUngCGWB0SI0LBiliN601fVwoKDnjwOABlSU4c/iUcmnhNmzl1KQ6Z9QRAY7DCq9pDKfA6ybjZIxDmQ3DzRZQE3sBgCA7u+FleFOEvknkKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DhGkMGBtWQoFDpTCLjROZmvmBwHuk6kZyrUC2Qf9RXk=;
 b=ZrboU0cdIASj5WW1D5s3sU8jnMT5h49S4FKyFB2FcJYrGu0Zbyiei4F10IL1aPqdpnaBpI+jHqrRnDOrlY7q1722gZCjilOa/oTFUatxcmPEewTTexBFunDVvbT45uGMdH9XHZzvonhcH4GiNqEWTHTMOItbDBT67goKucUR0odfDrYq6pNibKYseF1QgjWSBmVcn/hQ5SuSzjJdFWSTFOA5h1ETq1gUf4EJJP6eYuEtKDuuK8rwEuGJQ8JevpRSeD4nrMalP5LntRQ04MtVZQlGsYEcabye9Qb3lhGa8/1QUuZP4scZbKu8qRXuYHEl2FOr2dGktzgA+1XeVkU+rA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DhGkMGBtWQoFDpTCLjROZmvmBwHuk6kZyrUC2Qf9RXk=;
 b=kLYzCRm1T3SWedhULpwgfZX+0XIyMQI0xn7pXjBG/RdPTEb3PF2yIV7tWTF9W5Lx+fj4GrYySSrNMYDT9xvC5TDNmfRz1u1crTVvVbjZxiLNPXFxkEBm5eFjrIfJfrKdRTncCrYbZJol43uNDerqAU58Atb0nY780WO4x1g5Yog=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index:
 AQHY36RSrOIThkYtnEq9RrtWc+uYX64NnUwAgAAAd5CAAA4NgIAAAPkwgAAIMgCAAAAtcIAAA6oAgAAAMLCAABDdAIAAAGAA
Date: Fri, 14 Oct 2022 12:10:38 +0000
Message-ID:
 <AS8PR08MB79917BE687706A4DF51860DA92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <70670b7c-e87d-9eb7-691f-48c44e9d57db@suse.com>
 <AS8PR08MB79913CFDD2388EA05ADD187D92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7e24a21-1ebb-ede0-efed-275bbf503021@xen.org>
 <AS8PR08MB7991B0B2400B1B9D0E6B1C4592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <db3e4568-edf4-c5c6-4f99-3444a38cc40a@suse.com>
 <AS8PR08MB79919FFC44E975825EE9CB3392249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e60803a6-44c5-9d22-88b5-c924ee854fca@suse.com>
 <AS8PR08MB7991A81D931E20A000FEFE0092249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9adb1562-236e-2856-5977-0c563b0af024@suse.com>
In-Reply-To: <9adb1562-236e-2856-5977-0c563b0af024@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 52DB0AE3EEFAD8469DB7538CD94C362A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB8PR08MB5355:EE_|DBAEUR03FT032:EE_|PAXPR08MB6591:EE_
X-MS-Office365-Filtering-Correlation-Id: 221c4c78-2a81-4380-76c6-08daaddd23c1
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 d3IcYc+fnsv80ENaOtDXFxZSPPO+i/4GibcHLL/FmlUQYes1z1M9g7nQbwMrYIYgfpQ1+7g2rellQkAZhEWJ/d4DXBOn0/3/JcZK5oZEG8A4lvERG6XptdDAGuv1rZz6bdAwCGjntldC6g8V1zQuWMvJNFdSzMGDOk0ovQ5coW3gZSMfiB7HMIwjrR1FZold8Vuf4qCjpp5kU/LgbltpYAWbbwnKQYob8GXfsC2EwBDPauJWgtSSgpZnhUyjDP+V24iYJA49ZiUH6vFDOySFvKPcDmsNUOXGrUy81xQFn4uY/pzvHdC94CwbPJvmFpETniVxwXv2WBi/Rph3MywliLnXZgeX2EMv4U4HEne9pAUSGSR2H8oAPNTwvTY5t5gaznDMRwrTwietTaMXHxxx19imsktLOLk0eG8UE83KJmuse5rSi4bBz6Ps4fAm2Gx/q/IaSHxqRkdPxPZ4Qy/njMU0NbZH6h8mVzL7kp/R6tY+XZ20BnlXZH63sf2hzyetFqSJEDlQ5zyHEpvXa7isbE6D9MlPITOcZ6npY3Lm46fMnv580x1fIp6+Z4RihX6OUASP3wx5eM4ckDATeUrvLYvJ3/RuGyTkjFBvPUQpxzKuAb5C1kRaN1PepWEBR7vcSs2BbQ9yQl4TCp6nZG/oCfrFfg9NliKb3mVMBDspYXeXWZFCxf4/BIjyEJVQINIAnyYLQuZX5rC7/2pyPiabrCXz6upn5zVZdZRC3oqRdunPshKg4OcQx4xsTOAh0AZVoZi94Ss/p33q/M8/t2IbJwi3P8yiS3yB1bRVaqJS7Ow=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199015)(71200400001)(55016003)(38070700005)(26005)(66446008)(4326008)(8676002)(53546011)(64756008)(9686003)(66946007)(66556008)(66476007)(76116006)(33656002)(2906002)(6506007)(966005)(38100700002)(8936002)(86362001)(122000001)(478600001)(316002)(52536014)(7696005)(54906003)(41300700001)(6916009)(83380400001)(186003)(5660300002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5355
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	52d2377d-b09f-4241-feac-08daaddd1b5b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Yha1NP7KYYIpcpVE/jstYRDJEbRGtwqNzzr87wS3r5+M9Pr5ZjW00W/4seHyRJDJmgGOz3EjibS2PaXd7P3RQW5G5HyHCljFIe+pN7b/xJHL1VY+J1iRoho7RxQhaU0a426vRTbo/9Gnf5ggJHHvBo+bguk5P6J5yGjgXQ7SsgrRWDAWktI2G3Jiv6Dor0PSzLXjzldQ5sGtjbsRQbJqzuD2lmRAFaxhGfotfzPEeW6pSR9eE35JQxkiT+vEfn7bQG35bMLh5Z0+/nKRKbgGEKKyvi0beTtELH6ocIwGKDGrY1SM60Cjpk5rRxkRJDC3ls4WH5RgMnCfw+Ydh9nt1yu5GR0aBj78oe8SBC0WFPAhDmTcTvEcHIVa78kHJsE3np8ioE+TidR8dQBK4dm4NiOGhWHlTkJoz/k8YY/J8hIOXM3unA5gHlVPkHGmUQlUwJt9F6H3/HRa3fL1/YmIwyO41QsqV8/04Jx7QRvDpkz0XK/QkwxQquboTGth4Savye0BszhO42hk2IU4l2uZQLjohYXa6K9MO0xpoaT60R6gfkmiiamVqWa3KQz/9Je7WzwswPmBID/69GaQGVe+5mpAsuxsG9khuu9NyWvsZyuy4Gp7JF371E4j7eWP4tW6zXxLnTmdYhHc8eNro0JZ5Lb9nzw8A0CWfxeItAMOkO/mcJiaKgGypIzinnoho3Qxf1T36uuCE0pK61Oo4rGCKKaspCDdsmaxei7n1MuL6a9W+HrZ7xL4fb+/KJK/Ao9fEBe/RnhrZG28RltS4HL5WXwwNHwwiVAEZjZAHnmJ2BM=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(52536014)(86362001)(33656002)(2906002)(81166007)(82740400003)(356005)(6862004)(336012)(186003)(47076005)(8936002)(40460700003)(55016003)(40480700001)(5660300002)(83380400001)(26005)(7696005)(36860700001)(6506007)(9686003)(53546011)(54906003)(316002)(478600001)(82310400005)(70206006)(41300700001)(70586007)(4326008)(966005)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 12:10:52.5449
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 221c4c78-2a81-4380-76c6-08daaddd23c1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6591

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2Ml0geGVuL2Fy
bTogcDJtOiBQb3B1bGF0ZSBwYWdlcyBmb3IgR0lDdjIgbWFwcGluZyBpbg0KPiBhcmNoX2RvbWFp
bl9jcmVhdGUoKQ0KPiANCj4gT24gMTQuMTAuMjAyMiAxMzowNCwgSGVucnkgV2FuZyB3cm90ZToN
Cj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+Pg0KPiA+Pj4gTXkgaW5pdGlhbCB0aG91Z2h0IGlzIHRo
ZSAiZWxzZSBpZiIgcGFydCBpbiBwMm1fc2V0X2FsbG9jYXRpb24uIEl0IG1pZ2h0IGJlDQo+ID4+
PiB3cm9uZy4gV291bGQgdGhlIGNvZGUgYmVsb3cgc2VlbXMgb2sgdG8geW91Pw0KPiA+Pj4NCj4g
Pj4+IGludCBlcnI7DQo+ID4+Pg0KPiA+Pj4gZG8gew0KPiA+Pj4gICAgIGVyciA9IHAybV90ZWFy
ZG93bl9hbGxvY2F0aW9uKGQpDQo+ID4+PiB9IHdoaWxlICggZXJyID09IC1FUkVTVEFSVCApDQo+
ID4+DQo+ID4+IFN1cmUsIG9uZSBvZiBzZXZlcmFsIHdheXMgb2YgZG9pbmcgaXQuDQo+ID4NCj4g
PiBUaGFua3MgZm9yIHlvdXIgY29uZmlybWF0aW9uLiBKdXN0IHRvIHBsYXkgc2FmZSBpZiB5b3Ug
aGF2ZSBtb3JlIHNpbXBsZQ0KPiA+IFNvbHV0aW9ucyBwbGVhc2UgZG8gcmFpc2UgaXQuIEl0IGlz
IGEgZ29vZCBvcHBvcnR1bml0eSBmb3IgbWUgdG8gbGVhcm4gYW5kDQo+ID4gcGVyc29uYWxseSBJ
IGFtIG5vdCBhIGJpZyBmYW4gb2YgZWl0aGVyIGRvLXdoaWxlIG9yIHRoZSBpbnRyb2R1Y2VkICJl
cnIiDQo+ID4gd2hpY2ggaXMgdXNlZCBvbmx5IGJ5IHAybV90ZWFyZG93bl9hbGxvY2F0aW9uKGQp
LCBjb25zaWRlcmluZyB0aGUNCj4gPiBwMm1fZmluYWxfdGVhcmRvd24oZCkgaGFzIGEgdm9pZCBy
ZXR1cm4gdHlwZS4uLg0KPiANCj4gUGVyc29uYWxseSBJIHdvdWxkIHByb2JhYmx5IGhhdmUgd3Jp
dHRlbg0KPiANCj4gICAgIHdoaWxlICggcDJtX3RlYXJkb3duX2FsbG9jYXRpb24oZCkgPT0gLUVS
RVNUQVJUICkNCj4gICAgICAgICAvKiBOb3RoaW5nIC0gbm8gcHJlZW1wdGlvbiBzdXBwb3J0IGhl
cmUuICovOw0KDQpUaGFua3MgdmVyeSBtdWNoIGZvciB0aGUgc3VnZ2VzdGlvbnMhIEkgZGlkbid0
IHRoaW5rIG9mIHRoZSAvKiAqLw0KcGFydCBhbmQgSSByZWFsbHkgbGlrZSB0aGlzIGlkZWEuIFRo
aXMgc2FpZCwgYSBxdWljayBzZWFyY2ggb2YgZGlmZmVyZW50DQpjb2Rpbmcgc3R5bGVzIGFuZCBJ
IGZvdW5kIFsxXSBtZW50aW9uZWQ6DQoiRW1wdHkgbG9vcCBib2RpZXMgc2hvdWxkIHVzZSBlaXRo
ZXIgZW1wdHkgYnJhY2VzIG9yIGNvbnRpbnVlLiAiDQpTbyBJIHdpbGwgcHJvYmFibHkgZm9sbG93
Li4uDQoNCj4gDQo+IG9yDQo+IA0KPiAgICAgd2hpbGUgKCBwMm1fdGVhcmRvd25fYWxsb2NhdGlv
bihkKSA9PSAtRVJFU1RBUlQgKQ0KPiAgICAgICAgIGNvbnRpbnVlOyAvKiBObyBwcmVlbXB0aW9u
IHN1cHBvcnQgaGVyZS4gKi8NCg0KLi4udGhpcyB3YXkuIEdyZWF0IGV4cGVyaWVuY2Ugb2YgbGVh
cm5pbmcsIHRoYW5rcyENCg0KWzFdIGh0dHBzOi8vZ29vZ2xlLmdpdGh1Yi5pby9zdHlsZWd1aWRl
L2NwcGd1aWRlLmh0bWwNCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gLiBPdG9oIHdp
dGggdGhlICJlcnIiIHZhcmlhYmxlIHlvdSBjb3VsZCBBU1NFUlQoIWVycikgYWZ0ZXIgdGhlIGxv
b3AuDQo+IA0KPiBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 12:55:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 12:55:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422859.669179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKDy-0007OW-9Y; Fri, 14 Oct 2022 12:55:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422859.669179; Fri, 14 Oct 2022 12:55:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKDy-0007OP-6k; Fri, 14 Oct 2022 12:55:38 +0000
Received: by outflank-mailman (input) for mailman id 422859;
 Fri, 14 Oct 2022 12:55:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fnPT=2P=citrix.com=prvs=279a3d32c=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1ojKDw-0007OE-HB
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 12:55:36 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7c5d0d69-4bbf-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 14:55:33 +0200 (CEST)
Received: from mail-dm3nam02lp2047.outbound.protection.outlook.com (HELO
 NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 08:55:29 -0400
Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by
 BLAPR03MB5617.namprd03.prod.outlook.com (2603:10b6:208:292::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.26; Fri, 14 Oct 2022 12:55:27 +0000
Received: from DM6PR03MB4172.namprd03.prod.outlook.com
 ([fe80::fef5:dc53:67d3:3498]) by DM6PR03MB4172.namprd03.prod.outlook.com
 ([fe80::fef5:dc53:67d3:3498%6]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 12:55:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c5d0d69-4bbf-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665752133;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=mTBarqtrDCb/DvyjGWDhhj8F6tbPQuF8qTMC0BR50Jo=;
  b=QfN16EiHuZeAkcN37xxur7++QpokYkAAbIZn9JcvKSwkRCVCklvYXpXn
   633vw7PzfDW5JjVnp4SZfpXotAlNIkX+VUxjvzDV7BOlTIMx0iA2zSqWb
   hCeurXWR1VhCDkZRUZ1cxWNKk23lyPo0QqmEKz3OoBzun9JONBAPkcRnb
   4=;
X-IronPort-RemoteIP: 104.47.56.47
X-IronPort-MID: 83162753
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:rG7SaKKaj4hEuAMsFE+RnpUlxSXFcZb7ZxGr2PjKsXjdYENS1DRVn
 2BODWGHMvffNDekL493a4zgoRxQuJ7XmtExSlZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4W9A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYQx5cJMG2FRz
 McJcgkhUhvaxM2czovuH4GAhux7RCXqFKU2nyk6iB38VrMhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QzT+fVfD2v7lWSd1JDmMMDUYcCLTMMTmkeeq
 mPJ12/4HgsbJJqUzj/tHneE1rSWw3mkBdl6+LuQ19FXiXyD/0MpGBAqbX6w5vWSoHy7YocKQ
 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxLZcEitcQ2bSc3z
 VLPlNTsbRRjqKaQSG6d3r6MoCmuJDMOKmsfeS4DSxBD6N7myKkolQ7GRNtnFK+zj/X2FCv2z
 jTMqzIx750eicMN3uOm81HCnymhuJHhSRQ87QHaGGmi62tRZoG/YJezwUPG9vsGJ4GcJnGeu
 FAUls7Y6/oBZbmPiSiMTeMlDLyvofGfP1X0nV9qN4ks8XKq4XHLVZpX+ztkI0BqNO4LfDboZ
 AnYvgY5zJNaInaCd6J8ZIO1TcMwwsDd+c/NU/nVap9CZ8N3fQrfpiV2PxbMgCbqjVQmlrw5N
 dGDa8GwAH0GCKNhij2rW+Ma1rxtzSc7rY/Oea3GI92c+eL2TBaopX0tajNisshRAHu4nTjo
IronPort-HdrOrdr: A9a23:EvW2K66vPS6N13tlDQPXwWSBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTPqftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U
 4CSdkzNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt
 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9o1CC+yReTrJLqGRmR2RkTFxlVx605zG
 TDmwvloo2+rvCAzAPG3WO71eUWpDKh8KoCOCW/sLlWFtzesHfsWG2nYczHgNkBmpDt1L/tqq
 iKn/5vBbU015qbRBDJnfKk4Xid7N9p0Q6s9bbQuwqcneXpAD09EMZPnoRfb1/Q7Fchpsh11O
 ZR03uerIc/N2KJoM1T3am7a/n7/nDE3kbKvNRj+UC3a7FuIYN5vMga5gdYAZ0AFCX15MQuF/
 RvFtjV4LJTfUmBZ37Us2FzyJj0N05DVCuuUwwHoIiYwjJWlHd2ww8Rw9EehG4J8NY4R4Nf7+
 rJP6x0nPVFT9MQb6h6GOAdKPHHQVDlUFbJKiafMF7nHKYINzbErIP2+qw84KWwdJkB3PIJ6e
 P8uZNjxBoPkm7VeL6zNcdwg2HwqU2GLETQ49Ab4YRlsbvhQ7euOTGfSTkV4r6dn8k=
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208,217";a="83162753"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rw8aE+02MrZbvbBdqW/+soKQrUoIt3vD0xvaTTLQwvv10S9jDfhfD9LWaMiQAMd9tmXroS4Ds2D2bHdqaxikdYPxaELcG35FU+vGFwE8mEKC5M2/nm23VejhO6zf59lgphNjJf3t6vTRekkDz+3PVpQODNzZ6t4Sr04YZg/vZX4sf1T8Jf/SzOO3RK5CdNf7NS/nuFw2ndN0i9yIrEMQsPpWssB8+F/cLESP5DInIaREDz8NQAyfdNnNaTCs/kSKpkgr7hE1Qo4OJqUT7aFs/U+l8avjDueK2Mc2AlbVIessLIj/A9gADOCDMcMAgxFz7kcBjZI4izlFjEFl6suqKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mTBarqtrDCb/DvyjGWDhhj8F6tbPQuF8qTMC0BR50Jo=;
 b=NyJOTVkbS3TtrFFIG3MBeKUkG19Fjh5FvtkY+YWMRSZ7rQrdyN0tcRtrT6F0SKEhCQVAewdbnHA4Qr09v/X6xW/AzcdvHW+Sc4LWOcGZZKcRwhQ70gR2SyCvKluzBrXzAdYNmeeWQGpP3WNvw69gylda2Qzbahd39jyt3FwnpNUszP1mU/nqlEvGUysyiirtTRvi0FPegbP1+F0Si46t1SZj0RYkANN6m2XmWwuU5Kh4Arm8hv5RgLbeAjzZid+YHg10EDpl7wRlNAUndg63UsRuS6FbCKIrbCD9vqnFEK/KfSW6e9Mk5td9Sl7C7tiCtGi/CBDaheZdEmwbqaDnfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mTBarqtrDCb/DvyjGWDhhj8F6tbPQuF8qTMC0BR50Jo=;
 b=usNYRaBy4A+tRzTBAMho8CO6nKW1IVePd3iN/u5qwqPiInrH4u6s7vOktgoAJIn6JmEr5VAApOUQRMSejqX9XNsNIlzai4gntlrurPrU4nC/ZIKWdeOxSCO1tZdVQ0EzFXtUfetK1BYacouU7+K5xi1FoBwEgyu+eWw6/+dVYDA=
From: Christian Lindig <christian.lindig@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Elena Ufimtseva <elena.ufimtseva@oracle.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>, George Dunlap
	<George.Dunlap@citrix.com>, Julien Grall <julien@xen.org>, "Tim (Xen.org)"
	<tim@xen.org>, Nick Rosbrook <rosbrookn@gmail.com>, David Scott
	<dave@recoil.org>
Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement,
 toward non-recursive makefiles
Thread-Topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
 improvement, toward non-recursive makefiles
Thread-Index: AQHY3wR29Q+LQ29BdEevnfwWhUHbC64N2muA
Date: Fri, 14 Oct 2022 12:55:26 +0000
Message-ID: <D34C95DD-C6D1-4DE5-A180-F35FC7BA9C72@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-1-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|BLAPR03MB5617:EE_
x-ms-office365-filtering-correlation-id: d7414de8-8c5e-4b51-6612-08daade35db0
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 hC/Jys2bXVkSftsow5wczF2vxO0SBW9+pMkpFee9OBCGrxx93/qmKYvCYZ6uSiTmjFlT8+20Y7F0P8s5pfDztPoDqfcFr8kyv7tJy6Wze+C9qQiORFGx6ae+M1J3zD5S+aAWupgr0S+UNB7GA6wKQ3gDNdEBN68Bj7BJtIUqJnpPzWX6/ktTPXBIHtns5pW320lPoRd7PnETa4b+iK+HQjdiWYffqpQ2DlYAQ5gpPGhkC94P0H+qc2BhmvoqVrB1GWH6uom5i8gpUeuYb+mVR+mpTOhZa4tt9giv6IyFDCcEdq1URe6+pDQPvjHBTmRhn8x1Sov+bk9ZcLsHNJc/ZGpZcjHvvtfBqqdC8q9UNxwdpTzqg5bAa0RlC/5VOpISZb7r/Dg2JXdvTevn8qIiOLoGKB9LCJ2iXAohcumV6mKk9A/ZNMOCXiNsc4W4X07+Wa1FdwMtCM2kQVdByG1JP2Q31DY1yUN9lwSDnCXfQ7U7HVvifu5ShdWBabrzYbPUp5e9IDLIr+9mR9QVNJTQqzapfuUj5qHgXXNPeyPhx6JDkhrHkSzqNz0E5UGzKx/AtjNXXJgLd712K1yItnPLxcCFeRMksAWWVuBSzV2Fo6qMqGQS5iKG8VBpjCq5erzRYZ262T2SzA8DZcHdjpGkqzk6f5bVKDzJ+P2ranus6/7wPBZWh7GIvfQ90p4NEbjZhlG1DB0nV8F0CkX/PuHGioaqxHCeWbQFaUWVwGwTL/ULo55LA2J8P+YvyEMmspPZ+iSl99HEXhmBRtOYKtz3uR5w91FBfCPv5p6RAAhlQSdrSGXt78q5WV12UQfd9+kjzgdQUckegC7elwilm4jvYQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(39860400002)(136003)(346002)(451199015)(66446008)(66899015)(6636002)(33656002)(316002)(66556008)(6862004)(8936002)(64756008)(8676002)(76116006)(4326008)(66476007)(41300700001)(54906003)(86362001)(122000001)(36756003)(2616005)(186003)(91956017)(66946007)(6512007)(26005)(53546011)(37006003)(44832011)(6486002)(4744005)(5660300002)(38100700002)(478600001)(6506007)(82960400001)(71200400001)(38070700005)(166002)(966005)(2906002)(7416002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?nGEdcaxcgeG1+FdKnOaaJRsOxvXDe60tzS9Piz8CyLjZebKdQ6CtgGqMZvrU?=
 =?us-ascii?Q?e6eYI0UkamlmXNUqDVjVPLEmbEGFKMcllzwH5ZzRwGsnmv4YPiZC4yiS3Vpk?=
 =?us-ascii?Q?immEDCO7Y4+FYAGgqohyLVrkMweAo8H94Y3Z0HFPFXjlF4u67H223J8CJdfm?=
 =?us-ascii?Q?QQiT4GGduCZJB2J2L5rlRQZ3IjPrHIueA9zAwGjjwwUBefRskSit+fPl3bsH?=
 =?us-ascii?Q?X2qsD/VaywDsCCw4p5f4C9raopDWVySMWi3N794Vpwtv3Y+0z1EY0PpSgNhZ?=
 =?us-ascii?Q?Im9Ar2W4e3NcXZM6A36Eo83m2UoOi1t4jHDbvfkI4nx4QC2VjLog5+gb2bAI?=
 =?us-ascii?Q?xRlO6RsC5i6NvXmktPadeILjXoLzsVEcONfzS/kG/u/B3piBeqHtsRt4M1NE?=
 =?us-ascii?Q?07f4LrxGWGeKyi6alW7O+N1kxwAhtNaQ5t5IcbtQGuaEWgiKrgGv5gA32cYz?=
 =?us-ascii?Q?Na26rRSlnyaIDFzqAx76TN3Q+Y7TkCjSVv6YJPENqLhyYkSxIMjRUdCYvdiC?=
 =?us-ascii?Q?rgH5mXpvy9No5wu3PpZycoimRdKFSnq0/Um5VeEvYcXOggzK/O1muMF9+Gok?=
 =?us-ascii?Q?I2PR8x3PqNYtVNwxuv7Ph92UJP55qaeS/UlphkxpWYilNoHsBmJWxqPt+nXq?=
 =?us-ascii?Q?apSVdAhKFx9XpMtLmsVrnkhF9ah4BO62Vonhzbs9bWYgqGyM8HyLNNc+L6Tm?=
 =?us-ascii?Q?tzhNYO4AK3HbaBPQJ8fHpNg/XoF/n3vQrYrB7ZOglxm7QCsyHBpOzNfyKmlq?=
 =?us-ascii?Q?mwlYpDSuyBy9OBnci+h7yfl7Oj7ho+RxwBW7EsVofG9wONp0NC33rskyiJMJ?=
 =?us-ascii?Q?qV6UAStpxB3YvZ6WQJxh0YKgLVg7YmTrJBgk0VqIMFlkqn7qNCFbU9jVXco9?=
 =?us-ascii?Q?b7/k8JjXEeJf18EcrNM+A5l6UpMF4X/EOQN1UwuoaMd18kYjWS686eaSJGrH?=
 =?us-ascii?Q?8JRqaQ0KEHjuZM+ox8TXrjTEmow1dMZ61u0XYSwRmDh7wUsuFwgBW6QiIhSg?=
 =?us-ascii?Q?P+5+0zHuFiGm3BCU3cldBVGjdGvuI30NNqq3+E0qcbbi+W3AV6EmsOBH5Uo0?=
 =?us-ascii?Q?iq5gqCl+Iqk9LBX2hSlyFFfPNmIplc6i9De8yWWrLlMJ9LYg8OYt4zP/JdmR?=
 =?us-ascii?Q?L/2aayYlQdbJgCJIVccD+dMVLCIKVpH9es3RfATSIm6wnWi2NDpHsyM+P1YP?=
 =?us-ascii?Q?9A570AIwk+akvK8n0fLlMzmg4zb+oROJOOXGlVfTxZ96bY/etGdUM+caLIAr?=
 =?us-ascii?Q?E8bnzsINsYQ8jq2vn0uNdj7PxdooAcSyukRqPTlGaIJab6WHAx7cIl+der04?=
 =?us-ascii?Q?4AiWmDeWLT7+WuySYer9W5oXKVl1hz48fOwoHrQ8+7X0ZabiUQF+rdiiF2cO?=
 =?us-ascii?Q?g7mmCHB4CSzCh3spvJH50EhfK1yrRVg0WSnlWEIcOSiO8HybOTZkNVlgLxmx?=
 =?us-ascii?Q?XpKUSKU4hVcJdPqRQIiu+ENIkONQK0uMPhs+Gnn2wvzNNo59Qx/BWA8e/xER?=
 =?us-ascii?Q?/z8inQ4nSGskS/+ZCr2iv5cTIUa/YsSAGidW+dkAr8efBAv3Qhtngnl1RP+Q?=
 =?us-ascii?Q?x6Xrla9maWaeSj7uuH3ceVgXpAXtDhpU295wmoeRSg1t1y5XpLhiAUif/fP4?=
 =?us-ascii?Q?9LjU1MzdH26yYvzuRmjALlo=3D?=
Content-Type: multipart/alternative;
	boundary="_000_D34C95DDC6D14DE5A180F35FC7BA9C72citrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7414de8-8c5e-4b51-6612-08daade35db0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 12:55:26.7213
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X92WTIgjURKrNuEMQg+mktDAW/bndjsR/cGpyZyXNghDVXNZBPTP285NBSvRcDsdlEkWZ0R8bl9dlZzvbHwZerq8r+qDchO3rvO881wcjpc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5617

--_000_D34C95DDC6D14DE5A180F35FC7BA9C72citrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 13 Oct 2022, at 14:04, Anthony PERARD <anthony.perard@citrix.com<mailto:=
anthony.perard@citrix.com>> wrote:

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolsta=
ck-build-system-v5

Changes in v5:
- rebased on staging
- added "tools: Rework linking options for ocaml binding libraries"

Changes in v4:
- several new patches
- some changes to other patches listed in their changelogs

Changes in v3:
- rebased
- several new patches, starting with 13/25 "tools/libs/util: cleanup Makefi=
le"
- introducing macros to deal with linking with in-tree xen libraries
- Add -Werror to CFLAGS for all builds in tools/

Changes in v2:
- one new patch
- other changes described in patch notes

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>


--_000_D34C95DDC6D14DE5A180F35FC7BA9C72citrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <EA6D8D5900A7A043808EF3154E573380@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 13 Oct 2022, at 14:04, Anthony PERARD &lt;<a href=3D"mai=
lto:anthony.perard@citrix.com" class=3D"">anthony.perard@citrix.com</a>&gt;=
 wrote:</div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Menl=
o-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0=
px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-t=
ext-stroke-width: 0px; text-decoration: none; float: none; display: inline =
!important;" class=3D"">Patch
 series available in this git branch:</span><br style=3D"caret-color: rgb(0=
, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; f=
ont-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-al=
ign: start; text-indent: 0px; text-transform: none; white-space: normal; wo=
rd-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" cl=
ass=3D"">
<a href=3D"https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git=
" style=3D"font-family: Menlo-Regular; font-size: 11px; font-style: normal;=
 font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orpha=
ns: auto; text-align: start; text-indent: 0px; text-transform: none; white-=
space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: a=
uto; -webkit-text-stroke-width: 0px;" class=3D"">https://xenbits.xen.org/gi=
t-http/people/aperard/xen-unstable.git</a><span style=3D"caret-color: rgb(0=
, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: normal; f=
ont-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-al=
ign: start; text-indent: 0px; text-transform: none; white-space: normal; wo=
rd-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; flo=
at: none; display: inline !important;" class=3D""><span class=3D"Apple-conv=
erted-space">&nbsp;</span>br.toolstack-build-system-v5</span><br style=3D"c=
aret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font=
-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing=
: normal; text-align: start; text-indent: 0px; text-transform: none; white-=
space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-deco=
ration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Changes
 in v5:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Re=
gular; font-size: 11px; font-style: normal; font-variant-caps: normal; font=
-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-=
stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 rebased on staging</span><br style=3D"caret-color: rgb(0, 0, 0); font-fami=
ly: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: =
normal; font-weight: 400; letter-spacing: normal; text-align: start; text-i=
ndent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -=
webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 added &quot;tools: Rework linking options for ocaml binding libraries&quot=
;</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular;=
 font-size: 11px; font-style: normal; font-variant-caps: normal; font-weigh=
t: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-t=
ransform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke=
-width: 0px; text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Changes
 in v4:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Re=
gular; font-size: 11px; font-style: normal; font-variant-caps: normal; font=
-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-=
stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 several new patches</span><br style=3D"caret-color: rgb(0, 0, 0); font-fam=
ily: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps:=
 normal; font-weight: 400; letter-spacing: normal; text-align: start; text-=
indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 some changes to other patches listed in their changelogs</span><br style=
=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px;=
 font-style: normal; font-variant-caps: normal; font-weight: 400; letter-sp=
acing: normal; text-align: start; text-indent: 0px; text-transform: none; w=
hite-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text=
-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Changes
 in v3:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Re=
gular; font-size: 11px; font-style: normal; font-variant-caps: normal; font=
-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-=
stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 rebased</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-R=
egular; font-size: 11px; font-style: normal; font-variant-caps: normal; fon=
t-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px;=
 text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text=
-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 several new patches, starting with 13/25 &quot;tools/libs/util: cleanup Ma=
kefile&quot;</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Men=
lo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal;=
 font-weight: 400; letter-spacing: normal; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-=
text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 introducing macros to deal with linking with in-tree xen libraries</span><=
br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-siz=
e: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 Add -Werror to CFLAGS for all builds in tools/</span><br style=3D"caret-co=
lor: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style:=
 normal; font-variant-caps: normal; font-weight: 400; letter-spacing: norma=
l; text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration:=
 none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Changes
 in v2:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Re=
gular; font-size: 11px; font-style: normal; font-variant-caps: normal; font=
-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-=
stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 one new patch</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: M=
enlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: norma=
l; font-weight: 400; letter-spacing: normal; text-align: start; text-indent=
: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webki=
t-text-stroke-width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">-
 other changes described in patch notes</span></div>
</blockquote>
</div>
<br class=3D"">
<div class=3D"">
<div style=3D"margin: 0px; font-stretch: normal; font-size: 11px; line-heig=
ht: normal; font-family: Menlo;" class=3D"">
<span style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">Acke=
d-by: Christian Lindig &lt;<a href=3D"mailto:christian.lindig@citrix.com" c=
lass=3D"">christian.lindig@citrix.com</a>&gt;</span></div>
</div>
<div class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures"=
 class=3D""><br class=3D"">
</span></div>
</body>
</html>

--_000_D34C95DDC6D14DE5A180F35FC7BA9C72citrixcom_--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 13:22:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 13:22:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422867.669191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKdu-0002Py-JO; Fri, 14 Oct 2022 13:22:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422867.669191; Fri, 14 Oct 2022 13:22:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKdu-0002Pr-GB; Fri, 14 Oct 2022 13:22:26 +0000
Received: by outflank-mailman (input) for mailman id 422867;
 Fri, 14 Oct 2022 13:22:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojKdt-0002Pl-Ns
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 13:22:25 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c79f251-4bc3-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 15:22:24 +0200 (CEST)
Received: from mail-bn1nam07lp2044.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 09:22:15 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by PH0PR03MB6542.namprd03.prod.outlook.com (2603:10b6:510:bc::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Fri, 14 Oct
 2022 13:22:12 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 13:22:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c79f251-4bc3-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665753743;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=ZGxDAQVcrS8OJBF0jrpOCiQmZSbeKaLWnWg10+pSlds=;
  b=HWrC/RIOo+xwucCA1TBUotYco3vj4fyaP50nvoZnUA1+mBgBIrs+aX5t
   VHxruQm9DI8/XcreGcWPLMM5uUEsJQqL5Giou1a2inlwCv+lAB8Y9oCGY
   7dxIEAiXW4jFAcZuvSwonnrFmlG1SDUQ5a5Hx589Bzg203xn4IcfL7R8b
   Q=;
X-IronPort-RemoteIP: 104.47.51.44
X-IronPort-MID: 81855401
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ybEoIawB7NtO4hKUT/56t+cExyrEfRIJ4+MujC+fZmUNrF6WrkVWy
 mZJWDiBOayIYWf1etB3PYmx8RlU6p7SyoM2SlBuqyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwob4rLjtQ1
 eMjFhcBMh2jpumf6aznVbw57igjBJGD0II3nFhFlWucJ9B/BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI/OxrvwA/zyQouFTpGPPTdsaHWoN+mUGAq
 3id12/4HgsbJJqUzj/tHneE1rafwH6nANt6+LuQ2tF0hVSowEgpUEMud0q5iuaIplzucocKQ
 6AT0m90xUQoz2SpR9/xRQylo1aLuxcdX5xbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2
 1SV2dTzClRHu72PSGmB8a+UoCn0Jm4eKWYYZgcLSAIE55/op4Rbs/7UZtNqEarwhNusHzj1m
 2+OtHJm2+lVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg
 ZTOs5L2ADwmZX1VqBGwfQ==
IronPort-HdrOrdr: A9a23:7VcKDqnuGnzDAfeLaRA6TT4lZlbpDfOPimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee
 r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+
 uzUagmccPeEQ==
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="81855401"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BmlVQAjUh7KBliSxzacb81Rc7aAf36MKWSsYb/IHxIM2NSJf49cN6Z/Ci42Zfxdf77Ve47pj80cugu61jshhnVLHC7Q1EesaDVL7Pvwl9SEEsLuKAnIz7+XFYxbliZH8GzzqG/5/b1fOBuuAqgpj/dWXwiikbE33SdSMvmC8OLCWPmqgQSk/svINijoujFmWMFOd2IoF1OIpLeeuXVTybfJjtxXH3Umkg4os5LFvr4UTLK05XFZoEWczzlHIW+mmRliJy025eJoyIt8pcYdDDi5i+R125URd8fMEsZptkpKlZQZ/0PVUai0YYXGxBPAC87235aCjqZHxI3q6way+IA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZGxDAQVcrS8OJBF0jrpOCiQmZSbeKaLWnWg10+pSlds=;
 b=d2brQohAtIHrBKATnzqHXdfeHeWGaOUsVCfNo9+iWGRZwUakDzDDZoddV4cfMeJXba06Bjv7NDzkXtUJ1xqPeq5jv+lHnnzzp5slli6GHhz6CDsGNhnjrGsGvzXBGeDgRAcIiHcsGn4mFSif30haGqJgwqK6mJmiOMWMzBIVx2RoSJroPQgiWxGfP9y546ugUOP2Cy5WpNCf93eT047joFtg15XmbIDiNSJL4bfQFDn1vex8M0PvJ7hwS5RuJt7z5t1QdDbetORnOyw7viu1hrDxXbA1SyAnLD1R6/wx2Zz+CPvCKRSJMPyTAAtYpNzeiFLkIMwe4Z7xc7LxRafp0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZGxDAQVcrS8OJBF0jrpOCiQmZSbeKaLWnWg10+pSlds=;
 b=C5JpQvo6bfBQZhZLCviS5F4oxTfvBZXNZD0VsJ2hzftyWKI69IMhRXf12MQIOsN9gR7lYTNRYlW+sKRPTUrN9kXk+judyV90EOa6qWqdKFqIKNxeLRrs1HhR/qZt7xvP95Me8MLc5XfCR61KhLBLQCPSiicCFlxY10ckOPY/zfo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Topic: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
Thread-Index: AQHY2oN8A4y+jZE/1ESf3tQREpmAra4N6ukA
Date: Fri, 14 Oct 2022 13:22:12 +0000
Message-ID: <d12f3e75-db44-c7a5-958d-06ea99f881f0@citrix.com>
References: <20221007193124.20322-1-jandryuk@gmail.com>
In-Reply-To: <20221007193124.20322-1-jandryuk@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6542:EE_
x-ms-office365-filtering-correlation-id: d606dbc2-c807-4edd-230d-08daade71adb
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 jnNen2zF4lx+HkKqVmA5RQbexL0qVbeuKc0RhERTmN7DP6O6VzlE+tbPvhv6KTMx0cN6pd5D0v58pSt3lPRgVuWf7u1uUb+Y5lSF8z51pVDwCG/CVfLLPkmXAiqr3TRXsLRvV1GLgrke3i+AHEudHtrGcmPBFHguBtWv+9LWL925D0IAveXe9trvzpJyqkAOUuuATpZJb9kJqVEJQODB4zBBsP7uh8r7+dWtxLkruX+ZS8q+bsgyaOxhTVr9l5B0oE9CRskhHKi2F5JakgP1l/ckamwWFRpOloztbuQoWOxWE8tfuwlDP7hwdrZ7MckIEdEdxkK81Pu43RFfr2Vx08isGGSXUbtwy64D3zjtqjOxnlaKRjUT0tVPu5TtgpydTAuIsldgqg4PAAyYJS3lvcsysw13iuqwipQUH2h6qrLOAPET1yB7Xy4yxFzRWEUNOiRNoDsmqk83HN2+VEgTVYVTcjHO9nVQMG38dKKP7P4YJy8n8UEwCCEPPVaayBuQr5vAra5Bsm4wll2KFwahjYBncgpBsUWjBRj7qyodC22PaL5RsomkokmykP+/iJpmx1xh+coZnKiRzLk5wJ9ZcNvdhLvTbev87GlX791/5L9RRrKGRHUsejnU41vkMlk4I3ZShHprMJPSlpyXvFGZ52jTcFqr9TaPG9INomRc5KUXhIO4z1ThUNhN0gTiCT0H+GzVC8fuUg1sSAWEcjkUEAdYSq3EFha2wnNgwN8QF6KaO7Bpc+yLHJBuLHjc8nsSs2fEmeQ2nLTZPQh9jZViiUTXvyL0p1bquciLLyzD9tO3/7H8b6ayHmjp5C6PH2PqrX1pg5BfgeM/UXBGT9lkGQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(451199015)(38070700005)(31696002)(86362001)(83380400001)(478600001)(6486002)(31686004)(71200400001)(8936002)(110136005)(41300700001)(64756008)(316002)(82960400001)(6506007)(76116006)(66476007)(66946007)(38100700002)(66556008)(53546011)(36756003)(66446008)(122000001)(2906002)(26005)(186003)(6512007)(8676002)(4326008)(2616005)(91956017)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?LzlRSjM5THpNWW1kWUJlbCt5WktmcWpOa28rTlJJUUNNYkp5a2VwSEY4MnJI?=
 =?utf-8?B?SHpyRTdwRmFrNHp5Y3FMbWVUc1cwRFNLWlJTR0pvOWtKbUEwUHVwMGY1OS8r?=
 =?utf-8?B?WlNSSFhXbU82NENZOHoySnEvSERmSXF5SEIvYzlqdXF5Y2xLUzFLeW12SFNl?=
 =?utf-8?B?dTZsbHJmNi9ySW9TeWZ6MzhnVTJaTEFQbGVpQXdTNTR3OVpJMkgxd3plNnls?=
 =?utf-8?B?Y3BuOWdoQTJnaVEzVURnNzdqai9KK2YwNHc4Tk5ZbFh0REpsck5aVHFWTnRX?=
 =?utf-8?B?ays1NzhQK0hYSHJQV1VLdEthWW44cHJIS2FDR1p1UmJ4QU1UTTdIUVZuYkNr?=
 =?utf-8?B?UGJBM1JqVzZ6bm5jR0hJc1JnV3hXSlpQdEtmYTNtenNCdTFjTW15SDJLbmFN?=
 =?utf-8?B?ZFp0Y2FKUzhzS2Q1V21kQ3BzOGs5TFVRVmhaYzNzeVFpM2NTV3JhR0sxdmtl?=
 =?utf-8?B?Wlc1S1R2NWI2Yk9rNmhPcWFnL0VTcU1MbkxHc2ozR0tzeVJjTjBwQks2TklZ?=
 =?utf-8?B?akwxQjl3MEVKNEt2THNuVTU0eDlIV2ZRSUpad2NDQmhzemdRdE5tcnJIeTBK?=
 =?utf-8?B?bzFpVEZPamVHdXZwVWdBWHRVeXl1ZVlQU1lWT2t4T3RVa0M1OHJld2Noem5M?=
 =?utf-8?B?Y3FNTG82L3o0VUg2c1hPZFlhbVlBVDBsU1pUdkZGMzJYeEFPMU41YUtCdVNO?=
 =?utf-8?B?YWQva2taMkpFbVExQkl3ajFUOFJucWVaZkYyRXhvL0d1dTJNK1NqVlpRUnNT?=
 =?utf-8?B?WlM0Sys3MXhqQzJoelE5R0NIOThJYVkvY0l6R2dia0sxVnFWNStsNXovMlAz?=
 =?utf-8?B?QW1rSmZZTnovRHpvcnJCQ1kyckttYUNzMnJ2SGNsOFlQT01ER080WU13Tncy?=
 =?utf-8?B?VHVUTnB5dFQ5Z1BpYVN2TXVrc0lsY1p6ZC9oYkowbFN1NzRuaEpqTWxGOUk4?=
 =?utf-8?B?T2lkOHlSM29WWTlBREtPanZLNDRMZ2h6RXhidlJObXZqRVRtbzBNMFFmUTJq?=
 =?utf-8?B?cUI2eFQ1UmFhVWRpZmhJckJBRERUcm14NVZWeEk3bXpBbWVSU2tmajBNU3lB?=
 =?utf-8?B?NFNUcTZ5QkRqOXBFWFVRd3A4OGcrYm1Zcm44ZC9SSEZHRERjK2YwUzl3Tk04?=
 =?utf-8?B?ZWh2T1Fpa1NoMFkxRVJYbWZId1loQnNmK0J3cjZybjFXZjYwK054ay9yejFv?=
 =?utf-8?B?c2ZyRFhUSEZpTnQ2R1ljN0R6enRUMkRpa3ZSVThYajQ5akpGWkJabFlvNHpQ?=
 =?utf-8?B?K0NmZXdreGtLUVhEWTcrV0xmVHRIL3l5dHlGbU1FTmQvMmtlakZra2pUWHgx?=
 =?utf-8?B?NlJrRHBVZUI2dTl3VVBOYThxeTdCYkJ4N3laWmVvQnRWTkVvQWsrdVFub3pS?=
 =?utf-8?B?cXZIZFNiYXBKUHdBVjRYMjFPZnlaeThONUtERHVFNVNxbkhBNitHd2lmRnN0?=
 =?utf-8?B?YWZsTGtyYTdRQmdDcUhMbnZwM3djQjZvZFJPMnB5b25KVGI3eXpuSktCbktt?=
 =?utf-8?B?ZG8zblJ2SFBLaE85MjY3RFlpWTJtT3h4TXB2NHhLQUltTnV4YTFrMkZWdDF6?=
 =?utf-8?B?OW90QzZRZE9SU0Npdy9UVHJub3UydTUyWjZUV3EzbUpwSGlDb0tyMGtML1NZ?=
 =?utf-8?B?akNGcUtZMUtCaEw1b1pwMldMZmsyU3R3VDAxRkVxQnkraHkwbWF2YmFoYzhx?=
 =?utf-8?B?WjJRdUJnT01PcmlwY0RWME1sTkcyUTRlcWZXZ05UMnhpRFNpZEgySmdENDFp?=
 =?utf-8?B?RkVZQmxURTlCVTlmanNmcWNab2lZMjlha0Z5OVBzTUpFQWlGRGZ6cjhIZXJ3?=
 =?utf-8?B?NG85SzFORzhwZ1lqbXNReDFlSW5qMGY1SkRRL0JSd2xpN1h4SHp0NWI3MUpv?=
 =?utf-8?B?b1Nhek91Ukt5cmlUWmdYZlZjeVhpbFMxTzA5YmJjU25OTlZPR3J5VFRuWHRS?=
 =?utf-8?B?TEcyRFNWR0JEditwVkwvTzlIbDRWd0Zad2hMd0M3WVJ5T3JPQ1pHWUViQ01q?=
 =?utf-8?B?aDRsZlFNLzZtdDI0U1BDVTc4M0tFU1FJd3hwYWFDeExSNkZZNnpTaDNMcXor?=
 =?utf-8?B?eWJFeW9ueXNBNFFTc2k2aTUyVlNTREJtenNvMm1LNzZsOFZpTkoxT2pNaGgr?=
 =?utf-8?B?cE94cU11dVFEODNpWEgzRnZQZEthbUdkUzU4WGxVdmE1dGFGaGlINTB5YVFB?=
 =?utf-8?B?R3c9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <36A62646188E0544B091C7CAF1A151CD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d606dbc2-c807-4edd-230d-08daade71adb
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 13:22:12.5341
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kXeQU0IDxNAwo/uTJRuo5OzDzCx1LkohYUUzASO2dpTTqncz3nZeY9J2k207n7hawCETX2rA9/Wk5xo1mx5ZUTRaocXZY3kDx9z09MweQVo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6542

T24gMDcvMTAvMjAyMiAyMDozMSwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gSSBvYnNlcnZlZCB0
aGlzIEFTU0VSVF9VTlJFQUNIQUJMRSBpbiBwYXJ0bmVyX3JpbmdzX3JlbW92ZSBjb25zaXN0ZW50
bHkNCj4gdHJpcC4gIEl0IHdhcyBpbiBPcGVuWFQgd2l0aCB0aGUgdmlwdGFibGVzIHBhdGNoIGFw
cGxpZWQuDQo+DQo+IGRvbTEwIHNodXRzIGRvd24uDQo+IGRvbTcgaXMgUkVKRUNURUQgc2VuZGlu
ZyB0byBkb20xMC4NCj4gZG9tNyBzaHV0cyBkb3duIGFuZCB0aGlzIEFTU0VSVCB0cmlwcyBmb3Ig
ZG9tMTAuDQo+DQo+IFRoZSBhcmdvX3NlbmRfaW5mbyBoYXMgYSBkb21pZCwgYnV0IHRoZXJlIGlz
IG5vIHJlZmNvdW50IHRha2VuIG9uDQo+IHRoZSBkb21haW4uICBUaGVyZWZvcmUgaXQncyBub3Qg
YXBwcm9wcmlhdGUgdG8gQVNTRVJUIHRoYXQgdGhlIGRvbWFpbg0KPiBjYW4gYmUgbG9va2VkIHVw
IHZpYSBkb21pZC4gIFJlcGxhY2Ugd2l0aCBhIGRlYnVnIG1lc3NhZ2UuDQo+DQo+IFNpZ25lZC1v
ZmYtYnk6IEphc29uIEFuZHJ5dWsgPGphbmRyeXVrQGdtYWlsLmNvbT4NCj4gLS0tDQo+ICB4ZW4v
Y29tbW9uL2FyZ28uYyB8IDMgKystDQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp
LCAxIGRlbGV0aW9uKC0pDQo+DQo+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2FyZ28uYyBiL3hl
bi9jb21tb24vYXJnby5jDQo+IGluZGV4IDc0OGI4NzE0ZDYuLjk3M2UxZTk5NTYgMTAwNjQ0DQo+
IC0tLSBhL3hlbi9jb21tb24vYXJnby5jDQo+ICsrKyBiL3hlbi9jb21tb24vYXJnby5jDQo+IEBA
IC0xMjk4LDcgKzEyOTgsOCBAQCBwYXJ0bmVyX3JpbmdzX3JlbW92ZShzdHJ1Y3QgZG9tYWluICpz
cmNfZCkNCj4gICAgICAgICAgICAgICAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+ICAg
ICAgICAgICAgICB9DQo+ICAgICAgICAgICAgICBlbHNlDQo+IC0gICAgICAgICAgICAgICAgQVNT
RVJUX1VOUkVBQ0hBQkxFKCk7DQo+ICsgICAgICAgICAgICAgICAgYXJnb19kcHJpbnRrKCIlcGQg
aGFzIGVudHJ5IGZvciBzdGFsZSBwYXJ0bmVyIGRvbWlkICVkXG4iLA0KPiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzcmNfZCwgc2VuZF9pbmZvLT5pZC5kb21haW5faWQpOw0KDQpJIHdh
cyBqdXN0IGFib3V0IHRvIGNvbW1pdCB0aGlzLCBidXQgaXQgb3VnaHQgdG8gYmUNCg0KIiVwZCBo
YXMgZW50cnkgZm9yIHN0YWxlIHBhcnRuZXIgZCV1XG4iDQoNCnNvIHRoZSB0d28gZG9tYWlucyBh
cmUgcmVuZGVyZWQgYWxpa2UgaW4gdGhlIG1lc3NhZ2UuDQoNCkNhbiBmaXggb24geW91ciBiZWhh
bGYgaWYgeW91IGFncmVlLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 13:27:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 13:27:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422873.669202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKix-00036q-6M; Fri, 14 Oct 2022 13:27:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422873.669202; Fri, 14 Oct 2022 13:27:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKix-00036j-3O; Fri, 14 Oct 2022 13:27:39 +0000
Received: by outflank-mailman (input) for mailman id 422873;
 Fri, 14 Oct 2022 13:27:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojKiv-00036Z-NP; Fri, 14 Oct 2022 13:27:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojKiv-0001Mb-LD; Fri, 14 Oct 2022 13:27:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojKiv-0004oV-Dn; Fri, 14 Oct 2022 13:27:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojKiv-0006TJ-DI; Fri, 14 Oct 2022 13:27:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fZfCS7Bgf66tVnzUKpa48okBIb5jw884X5w3Rd65AaU=; b=SN2KK2AW516pWWrFmMLrP2NCN1
	4WOZRdulnx99CN2+4481OfJpFNGr40qsQNRc3gNRb8PBLpvoBR6N8Zwi19bN7v8tru0Op7BRt8uwR
	N7ldEEBRWMUzozkKOJVb01B/O4FxFbj1jsnz0fbDZtfKBxMFQbL5M5Q63El+0Do2twh4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173752-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173752: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=8fc06b6e19e3df93cc989b4f85877d8a7783e5bf
X-Osstest-Versions-That:
    ovmf=e0200cc47a691291ce1ad0207678a2db12d6503f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 13:27:37 +0000

flight 173752 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173752/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf
baseline version:
 ovmf                 e0200cc47a691291ce1ad0207678a2db12d6503f

Last test of basis   173739  2022-10-14 02:40:34 Z    0 days
Testing same since   173752  2022-10-14 11:10:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Foster Nong <foster.nong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e0200cc47a..8fc06b6e19  8fc06b6e19e3df93cc989b4f85877d8a7783e5bf -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 13:30:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 13:30:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422881.669212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKm9-0004U8-M6; Fri, 14 Oct 2022 13:30:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422881.669212; Fri, 14 Oct 2022 13:30:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojKm9-0004U1-JT; Fri, 14 Oct 2022 13:30:57 +0000
Received: by outflank-mailman (input) for mailman id 422881;
 Fri, 14 Oct 2022 13:30:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OdXR=2P=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ojKm8-0004Tv-Nh
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 13:30:56 +0000
Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com
 [2a00:1450:4864:20::534])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6e657b16-4bc4-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 15:30:55 +0200 (CEST)
Received: by mail-ed1-x534.google.com with SMTP id a67so6807383edf.12
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 06:30:55 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e657b16-4bc4-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=fCFJXDLeiHDdW21MT0i61+McsH45sDgzEF/fG3LGrfs=;
        b=lZfE/j1sUplFb2uwpGf9l2Ts7qs8NBF80rd96B8ykdF67+AUT4ynJOYpQYm0Q5TD4C
         GMrbkNzNhVnWAGoeN0qCX9pPpQ2xU9HaVLwCzxzaXQOPtNpP+aRGv/lKpeisFi9yulIt
         cejnHfgpK5JdXUw9heD0QH9C+fDOkT/tbQTuX/5/l0eWq1aZODtyi5ScJXqdGju5TKZM
         OnD55RwwjWw6m2C5vKr3JbnS4CeUESU1EGyiVBTboMrH9AtkHCd5De7xtj99Td3FTtOs
         GGsN49gfB3g3diTZcPJp4eG7mnzqsoLbaKYuy/eD1IMg6KNkJo1QHpnxRj8VpzwJCM6J
         ooBQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=fCFJXDLeiHDdW21MT0i61+McsH45sDgzEF/fG3LGrfs=;
        b=44w0O0IAxLnlw2PDcam19N+yM52latJJfJ9JZucj/5ntUp9sPOR7YgasEJ4+xxaLU9
         ++zkG3dcZ9ev6k9lcSMkknwVlK20dn2oWHWH9b4CGBHfUqBULuygYOt36ZJmHLOJ5q0N
         Q1Vqpngvm5Svg/dfgN2629knnC5B7M8In/QmIgaRm8jyq4STkbn+NtUhOh2tsTNybyTE
         BWhv1RGnbUcY9cn4G/0XfZk+0E6ZB+ZZLNrlWDWLnHyzc1Ml0sWP+pKXWUPwFmv640UW
         /gndQRDcBKqCNN6eNcm4tnRGs2pPG9N+tWWmn8gVbHSNvwzZbaUOC9ZhDibbtgPCKHN0
         +Uow==
X-Gm-Message-State: ACrzQf3jynmcYz5I0akRUcpHiMzmpEH/fK8HAi82hKJxByM+3HW4xxnW
	RzzwQa5P7J4d97hkYTgMyxLoqWwgL8uSEb3M7CE=
X-Google-Smtp-Source: AMsMyM6KjgMhqNOUtX9PIbyKY44l3FpupTIIyQStxef4h2Dkojb3mlEo3qveS7QcbmECt8jpsFJgzshBQPS5GMP7H8s=
X-Received: by 2002:a05:6402:524d:b0:459:3619:9cfa with SMTP id
 t13-20020a056402524d00b0045936199cfamr4370961edd.227.1665754255190; Fri, 14
 Oct 2022 06:30:55 -0700 (PDT)
MIME-Version: 1.0
References: <20221007193124.20322-1-jandryuk@gmail.com> <d12f3e75-db44-c7a5-958d-06ea99f881f0@citrix.com>
In-Reply-To: <d12f3e75-db44-c7a5-958d-06ea99f881f0@citrix.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 14 Oct 2022 09:30:43 -0400
Message-ID: <CAKf6xpuz4C3KzR-RR_KdSn7z0sR6swbh-pNdG0QgPpQt0fW1pw@mail.gmail.com>
Subject: Re: [PATCH] argo: Remove reachable ASSERT_UNREACHABLE
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 14, 2022 at 9:22 AM Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
>
> On 07/10/2022 20:31, Jason Andryuk wrote:
> > I observed this ASSERT_UNREACHABLE in partner_rings_remove consistently
> > trip.  It was in OpenXT with the viptables patch applied.
> >
> > dom10 shuts down.
> > dom7 is REJECTED sending to dom10.
> > dom7 shuts down and this ASSERT trips for dom10.
> >
> > The argo_send_info has a domid, but there is no refcount taken on
> > the domain.  Therefore it's not appropriate to ASSERT that the domain
> > can be looked up via domid.  Replace with a debug message.
> >
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> > ---
> >  xen/common/argo.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/common/argo.c b/xen/common/argo.c
> > index 748b8714d6..973e1e9956 100644
> > --- a/xen/common/argo.c
> > +++ b/xen/common/argo.c
> > @@ -1298,7 +1298,8 @@ partner_rings_remove(struct domain *src_d)
> >                      ASSERT_UNREACHABLE();
> >              }
> >              else
> > -                ASSERT_UNREACHABLE();
> > +                argo_dprintk("%pd has entry for stale partner domid %d\n",
> > +                             src_d, send_info->id.domain_id);
>
> I was just about to commit this, but it ought to be
>
> "%pd has entry for stale partner d%u\n"
>
> so the two domains are rendered alike in the message.
>
> Can fix on your behalf if you agree.

Yes, that sounds better.

Thank you.

-Jason


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 14:03:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 14:03:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422890.669234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLH9-00087y-8b; Fri, 14 Oct 2022 14:02:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422890.669234; Fri, 14 Oct 2022 14:02:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLH9-00087r-4h; Fri, 14 Oct 2022 14:02:59 +0000
Received: by outflank-mailman (input) for mailman id 422890;
 Fri, 14 Oct 2022 14:02:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojLH7-00087l-Li
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 14:02:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e5d077f5-4bc8-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 16:02:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5d077f5-4bc8-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665756175;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=HWk1ODYaHW4RCEOZ2LKRRBh8e1VmfzBj+8lRtugVTC4=;
  b=ZuNXc9UYESBHi1kpATnD4m2uI9E406yUmd8eVXJC90DWY7wz+cSWSaR3
   skupHYqHsQkwd6ReEQuBIsYMnvOWfoikB3udUEIH8gRmPdORjRTscd/M3
   wrOR/Vs+f7jt1YPdJ7dlH9b9Il6SCsHIWvMuCggQc/Ad/3wx8BsvsW9D/
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82735017
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Jo/s06K6QYRDr6m/FE+R9ZUlxSXFcZb7ZxGr2PjKsXjdYENS1WZTz
 2MYWTuDM/yONzP8KdEnb9y18RwFvMeBx9YyGQVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4W9A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbMp6OtyI01lz
 vM/BAIMRR+ut9mp/IvuH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO
 YxJMlKDbzyZC/FLEn4RBIgzg6GDgX7nficDgFmUubA28y7YywkZPL3FYICKIYHSHJo9ckCw+
 Wb48k/8EhgmKcWU8hSJ0mOivtbSpHauMG4VPOLhraM76LGJ/UQYCAcXTke8ufm0kAihHdlbI
 lYX0iUrpKk2skesS7HVXRS+rGSVox00VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iL8CnB/KbPpIK6GSou/0Mj7d8
 wuVkBFr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4
 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJFcFg
 2eJ42u9AaO/21PzNMdKj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhZxz/FhZ
 c7ALJv0ZZr/NUiA5GPsL9rxLJdxnnxurY8tbcqTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDjoH
 yJkH5LSkX13CbSmCgGOqN57ELz/BSVibXwAg5cMLbDrz8sPMDxJNsI9Npt4K9A7wfoKzb2Tl
 px/M2cBoGfCabT8AV3iQhhehHnHBP6TcVpT0fQQAGuV
IronPort-HdrOrdr: A9a23:4YA7bq+6hezIds8hRRpuk+DQI+orL9Y04lQ7vn2YSXRuE/Bw9v
 re+sjzuiWE6wr5NEtOpTniAtjmfZq/z+8W3WB5B97LN2OK1FdARLsSibcKqAeBJ8SRzIBgPN
 9bAs1DNOE=
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="82735017"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jason Andryuk
	<jandryuk@gmail.com>, Christopher Clark <christopher.w.clark@gmail.com>
Subject: [PATCH] argo: Fixes to argo_dprintk()
Date: Fri, 14 Oct 2022 15:02:21 +0100
Message-ID: <20221014140221.31966-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Rewrite argo_dprintk() so printk() format typechecking can always be
performed.  This also fixes the evaluation of parameters.  Emit the messages
at XENLOG_DEBUG.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jason Andryuk <jandryuk@gmail.com>
CC: Christopher Clark <christopher.w.clark@gmail.com>
---
 xen/common/argo.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/xen/common/argo.c b/xen/common/argo.c
index 9ad2ecaa1e42..f29fa720fc48 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -313,14 +313,12 @@ static DEFINE_RWLOCK(L1_global_argo_rwlock); /* L1 */
     ((LOCKING_Read_L1 && spin_is_locked(&(d)->argo->send_L2_lock)) || \
      LOCKING_Write_L1)
 
-/* Change this to #define ARGO_DEBUG here to enable more debug messages */
-#undef ARGO_DEBUG
-
-#ifdef ARGO_DEBUG
-#define argo_dprintk(format, args...) printk("argo: " format, ## args )
-#else
-#define argo_dprintk(format, ... ) ((void)0)
-#endif
+#define ARGO_DEBUG 0
+#define argo_dprintk(fmt, args...)                      \
+    do {                                                \
+        if ( ARGO_DEBUG )                               \
+            printk(XENLOG_DEBUG "argo: " fmt, ##args);  \
+    } while ( 0 )
 
 /*
  * This hash function is used to distribute rings within the per-domain
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 14 14:06:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 14:06:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422896.669245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLKv-0000Lt-OU; Fri, 14 Oct 2022 14:06:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422896.669245; Fri, 14 Oct 2022 14:06:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLKv-0000Lm-Kq; Fri, 14 Oct 2022 14:06:53 +0000
Received: by outflank-mailman (input) for mailman id 422896;
 Fri, 14 Oct 2022 14:06:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OdXR=2P=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ojLKu-0000Le-04
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 14:06:52 +0000
Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com
 [2a00:1450:4864:20::634])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7269a247-4bc9-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 16:06:50 +0200 (CEST)
Received: by mail-ej1-x634.google.com with SMTP id b2so10744131eja.6
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 07:06:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7269a247-4bc9-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=szfsHn58qlHosBTktmeFDMRXO20yhh1xMRQGpNfQKLo=;
        b=LK8FVPQZa2uAs5x5SMA3Bsep+SoyM+1HEybKOxCssY6T6er7ovHem6Aom+dHFNxN5Q
         l3eRuq4RN9iagGtuGYMR+1VIWqKNT3Gu6+c++aFARVJjwZ+4JeoN8Ax/7/IFqOzyAXxK
         28dOWRuVfp32sc/qKW2a1OA4SYG57v7u+TIMd14Sl3WU+dMxN2EdXbNYPUOmYKypsLvz
         y9LDoKPn/2nS4r/ytQ0EtxrC9Yk+pcTZ7Aj5aAlw40AYVGpvOUWyD6MCj/AdCs/35a9D
         RZEHsyq4/59F1BMwdCKYIu+bRLjaWS6z7h5HCU3BxWWEkQVvgfA26t3Zde0qeLDLPalX
         Y5EA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=szfsHn58qlHosBTktmeFDMRXO20yhh1xMRQGpNfQKLo=;
        b=E5rRgBwmrle2JRMlmNEim/31/DRaW81n+3EmVEPzKa9U+KQ1G4kDR4VUwKq/yyDm+a
         d1LWJTsi+HFMaX3fL+KxtTA07sTtLrBA+KziA+FuBSum1AzxBpggoBCf82+rVfk2wu4p
         PfzDb3TOEBU904BlVxxXfyIN7aqGqnmJwSu+7m985Yngq3zOtl67E8m0XL51tJGCqExH
         csr8lk/A5sh7bTYlnxRf7fQOpDFuOLUjU+4oKSkV+oGyh++EXG2lfnzRvDvDvYdbCfxN
         hJSiUepnp5eEzZAP8wNApRzrAMeJk9uT2l8QRlc+mN3zqZ7bp6AYvZ6aA2mT5y34MOKq
         ilBQ==
X-Gm-Message-State: ACrzQf2RfGWwGndTezchhPYoWbJRmMYxl0EvF/xxpv5QYhQYRlCq9paF
	xhkShaPX2Klvjak/kOoJpyy8T3eFPmUo9nzO5g4=
X-Google-Smtp-Source: AMsMyM7nm5Em1bmOKPfIllS/6qEfOZiuU3e/o7/7xeXZY65Xddt8E9V4IsEMAxssFT2ZX+B5tRnvERCRvRhiyJAX4/E=
X-Received: by 2002:a17:907:d03:b0:78e:16da:e4ae with SMTP id
 gn3-20020a1709070d0300b0078e16dae4aemr3804854ejc.202.1665756409410; Fri, 14
 Oct 2022 07:06:49 -0700 (PDT)
MIME-Version: 1.0
References: <20221014140221.31966-1-andrew.cooper3@citrix.com>
In-Reply-To: <20221014140221.31966-1-andrew.cooper3@citrix.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Fri, 14 Oct 2022 10:06:37 -0400
Message-ID: <CAKf6xpuh5sdnNvrY_J+=7pYR6i6SgEf2QHPx0_LHJBMi+m_urA@mail.gmail.com>
Subject: Re: [PATCH] argo: Fixes to argo_dprintk()
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, 
	Christopher Clark <christopher.w.clark@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 14, 2022 at 10:02 AM Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
>
> Rewrite argo_dprintk() so printk() format typechecking can always be
> performed.  This also fixes the evaluation of parameters.  Emit the messages
> at XENLOG_DEBUG.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jason Andryuk <jandryuk@gmail.com>

Thanks,
Jason


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 14:16:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 14:16:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422903.669256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLUL-0001xD-Oa; Fri, 14 Oct 2022 14:16:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422903.669256; Fri, 14 Oct 2022 14:16:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLUL-0001x6-Lc; Fri, 14 Oct 2022 14:16:37 +0000
Received: by outflank-mailman (input) for mailman id 422903;
 Fri, 14 Oct 2022 14:16:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojLUK-0001ww-UF; Fri, 14 Oct 2022 14:16:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojLUK-0002Ho-RD; Fri, 14 Oct 2022 14:16:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojLUK-00062e-Jg; Fri, 14 Oct 2022 14:16:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojLUK-0003E2-JD; Fri, 14 Oct 2022 14:16:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pZXQsfwTrg3Cz1sJ780MguYxuT5M5TEjnC2PU566QiY=; b=UHZG9vHHfF300YkxWcFPuCYcmQ
	bz2MWceDqgA1tK1jNOV5emSuE45JQ63lYpIbyAFfxsgNJVSChFWztlL/sz1+EEMXwDYD9APXCisSa
	uSe8YnP50Asn4MtbK9fb31XmiZ/yjckeO8Obl20kiGxcYO/4NyxTL9gAI9daEnPMrcSw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173754-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173754: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=171d4d24f829075cac83b6fafe7a4ed7c93935a6
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 14:16:36 +0000

flight 173754 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173754/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173734

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173734 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173734 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  171d4d24f829075cac83b6fafe7a4ed7c93935a6
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    7 days
Failing since        173492  2022-10-11 13:01:50 Z    3 days   18 attempts
Testing same since   173721  2022-10-13 16:00:32 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 654 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 14:18:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 14:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422910.669267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLVo-0002XL-3g; Fri, 14 Oct 2022 14:18:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422910.669267; Fri, 14 Oct 2022 14:18:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojLVo-0002XE-0o; Fri, 14 Oct 2022 14:18:08 +0000
Received: by outflank-mailman (input) for mailman id 422910;
 Fri, 14 Oct 2022 14:18:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=F+Di=2P=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ojLVm-0002Wh-G9
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 14:18:06 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2083.outbound.protection.outlook.com [40.107.21.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04bee5ea-4bcb-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 16:18:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB9126.eurprd04.prod.outlook.com (2603:10a6:20b:449::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Fri, 14 Oct
 2022 14:18:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 14:18:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04bee5ea-4bcb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mXPTAhxxRm7OytTH/jwND1CrIEj9hWRtfLLzjnUs7dbZOj48UNsde/J4fyND8JqrJUMqeGDAAxaVLbtyA8ar64aJH4OCbqKJsMXQ2v+AxlIn4IRPQL3bwmOTEx+PokRZxMC0d4G0inlKh1ZhkaUtm3EtugcTNVqPvwGqUeyYnlYz+Rh7cRy7J0X0cALqzaFv87LmEq5ubjdG2hhBbkqyW2GUH8HqneVLxdiG5BRaH+T7zFR/UU809O0ANpJaeJSnGegzvXozJMd+Ifn7JIx9++66OCCVKIA/M3GSrsBgOLTWSsOSyfcD+J+/1BB4mAWBCfbHud6OPoDjM4IyC2amfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r+JBZO2UZ1F3kgYUn6aOyopHji/OhRvLI4eE7O5gQrg=;
 b=C6PkphRHizheNpWIEhb3x4cO4pR+JEGcqE1UIDkQk+KbJiojrVi84xUtSnZpeHsz90piOOeroT58Hg66p0VoAI2KfQ/RWUQvihZBY5kob623V2GHmQZxmvW1+VK9LTnK3uVypflbBv/O1om3Q3FrflYg5/DSy4Je/9OB7+9hUYlmjPWQU9KlMv55baMmePRTTczqP3rxF+8pvd0TTnncc72PKnzQd34E7zmgHJ2IPhLcqDLHUEZRalHCLTxDoftSew4JTJpzem9eLKc8CR/Rm4Zvd4+uuNI5l3k3+PfoEpuiwfOvWiS9oIK6nfROLJWXYH1YqDj61iCo1kgfxgQXYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r+JBZO2UZ1F3kgYUn6aOyopHji/OhRvLI4eE7O5gQrg=;
 b=L8AOiEJshJlgilqTJ3PaEhfAUI1P6jGTnJkM0EM7jGDKeTVeYXvZk5i8H0J245J+8jyRkThD8KjxzTqVFIK9kCuC9m38WKUbMC7O2iAu0edrddzNtDcRzrbS5El77HeOVsheoynDKPpbInrhYdO+u2Ivkrs8TlPWFiwNsSbE5714WqiNRG6vvuD2pRtwBdrwPTf5ULt/8hbbZwxxzgeP7RMucOQPxYAqJIpTa859WuA/ogAOtHXdtUyy2rUaZAs3rqs71Hzcpz/uEqcasirOpR0iM8LAFMK/vei3jGgK+ZOQtx2mzjUhTGPp2DwN/SxMYbcYG65Il9pCOJbFGoyO8A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b2ed1bc1-a2db-068e-3293-5b449395d844@suse.com>
Date: Fri, 14 Oct 2022 16:18:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH] argo: Fixes to argo_dprintk()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jason Andryuk <jandryuk@gmail.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221014140221.31966-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221014140221.31966-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P250CA0012.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9126:EE_
X-MS-Office365-Filtering-Correlation-Id: 9f58f192-6ea0-4b77-f6b4-08daadeee81f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7wKW+G6PYt0xheIT73CVPHPyZdQ55FUykH0qqKn4g641h0nYssAVrRp/xDvZMjpNkLGtRJgemLaOITn74HQD04NNU5PV2caDMeUthyETNzYO8AD08LIIJeRxQmA87ktsAxuw3JA++ES1KzSIl90qNfJedeTCITOwmZ3tTo4Tps3NNjrJsv/dWvjQ2Hb7qrZ0IYvSkzlzDLRvJyk9JusNxDLUeQEPDVWAKeUwwFlr5yhL8ojySNXNx07W4KFl9S4Rxl8XMBQsE1ycCwEGKRlHiH2rCvGXVm9GxRe8TYFIRE7i6t0J+58hSVvLB2A1G7cVb7coLeinxLlS1wo+G1KAKklDPLF70CIrxXu79Clec3uPBgXUyUpGt8tUgiiPcUntCu6sdaFjTxbd5ofVJ+HIYKyQWnWWXzcPJzcaATpL+44Fwb1EwG2P+P46r2HVDZShp43cRnrWPva+G+y89D2fhrArjon+gBRmp1dMTOT3SD8Cf/4Bx7nBOTWP7JNQtgnIddwNk83mqjon+uWMD2RzzEFVALPLXmFzJCyvUPm9+ebAOcMEWvMrKFWAfd0awssPlzqdaNH+oJChTme4aV9fAIouiSj23L7xz79EvZ52b/ii4GJuH8AW7thV3Ks4GuZwlMruCa3M4CiT1be/k/D5Yat8zUwQjsCLliNtQk6MklC/kf2ojxH3D91Ix49p0D2ZLhMUm6sOaJYsunZDjZ6f2ekp2sGcgqQa7MnAzHfHxsgz29ctN6Vat1IaG/0FIGU8GN2/xILl1ZDR/2kXikWhQb7aFSG0tZ7OS0qVJGWGsCc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(366004)(136003)(39860400002)(376002)(451199015)(8936002)(54906003)(316002)(6916009)(66946007)(2906002)(38100700002)(4326008)(41300700001)(66476007)(66556008)(4744005)(8676002)(5660300002)(26005)(186003)(6506007)(6512007)(53546011)(83380400001)(478600001)(2616005)(6486002)(31686004)(86362001)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eDNUT0JJT2ZmMHo0RWYxdUVJNk85Ri95bExjMHhuVW43ZHdBY28xWGRuMHlC?=
 =?utf-8?B?UWg4OHVkU05jbXJaeEdIalh2RVF1S3ErbEVVa1dkdWJDeG1UZ2hmYXNBQ1NF?=
 =?utf-8?B?UXRFcDZLeVluUnQ5OWhzOExDd29LVDIrTTBkdUZkd0s4VVl2cVNMOFVqOW1v?=
 =?utf-8?B?bDNLZzJzUm5PMkxLNS9DZ3hkV3dobG5SRWRiZXZ2VDA4c2NzVFF6aUdoRks4?=
 =?utf-8?B?czE5VkNNSC93aXl4MnVRQjRrV2had2hXK29heHppdXo3WDlEK3NSTHY1Mktq?=
 =?utf-8?B?SUo3d29PMjFlY1JzSUdtZ2NpYVlNaC9TRnVGMjNrbzYvMU1kclNWM1p1eXFK?=
 =?utf-8?B?Q0s5TFF1UUJSamM2TDdGSXpmR1gyQzFBZUI4NkllR21YVldYM1JRMnQ4ZS9z?=
 =?utf-8?B?RDVEa0Z1UUpoTDZkSUJENWVFbXExeG1LdGdsSHB4aEJIeGF6TWtMbmF0VE1M?=
 =?utf-8?B?UzBKOUZzSllNb24yQ3lCTGtqZ2VUcTBvTEJFelZBOGVtM0htOXdXWWkrY1d6?=
 =?utf-8?B?VHQ1aUFRb3lxd2RsL1FSbFA3aXFFa2daSWVpRHR0VkhwK3gwWE5udm9pL2gv?=
 =?utf-8?B?THAzRWVGcHU1QUV3R0FMZUQ1N2lwek4vME1uY2luUjQxQ1NCSEowYSsyQXox?=
 =?utf-8?B?akc3a3VGUWtmeGh1T20vTzBnM2I5VEJWc1REWFdORy9tMytTaVdJYURQRllQ?=
 =?utf-8?B?QUFXWmlrcEdxcllzSUZBazVyOGJFU0s0emk0a3crYXNwcEEyQ2xiY3Y1bm5J?=
 =?utf-8?B?cDZDWnkwZ29JMlJXcFRVZXdrZ3k1Q05lYlJabnpra0ZNOThIVW81bWw1SWlK?=
 =?utf-8?B?OU5vSndyUm5uRC8zdCtiQ2I0dXVsNzhpWkQrRjhmNEdnaktYYmdiQ2F3N1pI?=
 =?utf-8?B?SStmTUF5R0hoNWRtSUxqUmx5R0t5UHVTN3pnY2Jlaks3Ri9BRXNWam4xT1VS?=
 =?utf-8?B?bHhleExtOWY4aTdIL2lmOElwYWU3NE01VGJ6NHE1dVNRbkpEWlViM0FnaExV?=
 =?utf-8?B?by9RNk5BQTkvb2lJZ0txekluRmhiTUlaajZhM0R1K2hrUVNWcnlGeUZ0bjFC?=
 =?utf-8?B?OVdHZHJ0MzVoZEpLSVpZY2VMNm1DZzV0cXM5WjFqVDc4WWE4Ymk5Yk53RUk4?=
 =?utf-8?B?NmQ3clRvdHVNVkFHSU8ySU4zRnA3ZnQ1MkVNd2dpU2ZET0s2cVJOZzk2TkYy?=
 =?utf-8?B?OFJwdHpIWTJyR25URkZRM3R1c3M3VDlvemIwTHpxdTJBdUhFaHltU2tjN3dx?=
 =?utf-8?B?QmhVVG9NaUFVV0U1OGdYTUIrcndlWXUxUSs4YXFhUGhBOHQ0MU9hczhlTDU4?=
 =?utf-8?B?TlNoelM5Y0YrYjkwOGc5dHF3bndZakNVbkxXVm15eWZpT0VjUmZGdG9oSHd5?=
 =?utf-8?B?c3ZZbWYwUWNMbkZscGxlYUV5NzA1d1BIWklCWDNLL2FGd1ZwZzREM0xaMm4z?=
 =?utf-8?B?V1M4OXNyZm9aVjRkZmJ0d1ZJUmtOQ2xCdEJHMGVRaEgyOXBoSENXRHZXQlh2?=
 =?utf-8?B?eDFYenVoSVM4YlpNSXFpdkM0ZnJlbk02MEliYTBwNUxPeGh5ZUtMUENCWnQ3?=
 =?utf-8?B?MFc0R1RiUDlDOGlYSEhxa3dKeS9peWFxcUx6Z2VzcXcvbldsSkF4bE9UYitw?=
 =?utf-8?B?RmppbTJ4a1QyaFVHb3JQYVlVTG42Nmg3cjRVTUVVUFBqUFk1RExXaGw4QjZh?=
 =?utf-8?B?ZjNGV1dTcjllandCenNkR1FTRmU0V2xvN0xOdHJaNG1qZTJvTmt5R3JZWTl5?=
 =?utf-8?B?Y01PcGU1NjBDQWgzL0pSUXFzWEtxZjZFMG5HNmxZK2M1a1JmRFpkc21UQzJW?=
 =?utf-8?B?bVE5UTNsSXYremhxdGZ2T3UybTI0SzdUbFlhZ1RudXF6cWMzZHE5cm5FUkpa?=
 =?utf-8?B?OVlVVzc2WEpXTTVQVGhwWTBOT0pic1pOam1uTm5ESkFnZUV3TFBVRStVRmZS?=
 =?utf-8?B?YU9ZRTFpRk1rVGIrUkxNOUVUanM2ZHE1TTdvck0wT3dhRGFib29ITWY4eVhQ?=
 =?utf-8?B?UmE2VDJjcVArSytwRkZ5OTJBSnZwc0ZzS2NPeDdQek5nNEF0cjE5enB3eG0v?=
 =?utf-8?B?cm9WaXhkVDZscnJRZnpUSHZ1aHMyZWY4MnQ2WkQzYlZGVUdQTWR3U1RlNnkw?=
 =?utf-8?Q?z8wGHmkO+n4emBmU3CWKwLwsn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f58f192-6ea0-4b77-f6b4-08daadeee81f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 14:18:03.6608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /W6OVgWN91mkxJG/bL28aL3CqlseK6kwK9I20L2GIDIpkWpnynTRX9pqT8tiAeqB7oVT1uEkq4i9vsLhlYJ2fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9126

On 14.10.2022 16:02, Andrew Cooper wrote:
> Rewrite argo_dprintk() so printk() format typechecking can always be
> performed.  This also fixes the evaluation of parameters.  Emit the messages
> at XENLOG_DEBUG.

I guess I don't really understand the "fixes the evaluation of parameters"
aspect: What is it that works differently now compared to before? If
ARGO_DEBUG is 0, none of the arguments will be evaluated, just like was
the case already.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 14:59:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 14:59:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422921.669290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojM9z-00072f-DG; Fri, 14 Oct 2022 14:59:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422921.669290; Fri, 14 Oct 2022 14:59:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojM9z-00072Y-AF; Fri, 14 Oct 2022 14:59:39 +0000
Received: by outflank-mailman (input) for mailman id 422921;
 Fri, 14 Oct 2022 14:59:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojM9y-00072O-1l; Fri, 14 Oct 2022 14:59:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojM9x-0002zC-Te; Fri, 14 Oct 2022 14:59:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojM9x-00074z-Ie; Fri, 14 Oct 2022 14:59:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojM9x-00026m-IC; Fri, 14 Oct 2022 14:59:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CBbgyQq6cbYA1h0G+k5SkzTdUOY+4ThtbM1fgPENW/s=; b=NohgINMra3meGu5kPx1sSSDVK1
	nyQ5CIp+UjbxJWC+y0jgtsSgvT+9bAo59V04d4v1dhuV+97eEQHwk2azhVwjqBV0nRPoiPvhpuM60
	oDKSO+mMXbmmCQfNN0RClOL9oZSgVZVJDD2g3fJKhcg4jV2gqKXm/4Thficsqr1aAwmo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173702-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173702: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:xen-boot:fail:heisenbug
    xen-4.16-testing:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 14:59:37 +0000

flight 173702 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173702/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 173702
 test-arm64-arm64-xl          14 guest-start      fail in 173603 pass in 173493
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 173603 pass in 173702
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl           8 xen-boot                   fail pass in 173603
 test-amd64-amd64-xl-qcow2    21 guest-start/debian.repeat  fail pass in 173603
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173603

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   57 days
Testing same since   173493  2022-10-11 13:07:01 Z    3 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 15:05:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 15:05:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422930.669300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojMFf-0000An-53; Fri, 14 Oct 2022 15:05:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422930.669300; Fri, 14 Oct 2022 15:05:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojMFf-0000Ab-2M; Fri, 14 Oct 2022 15:05:31 +0000
Received: by outflank-mailman (input) for mailman id 422930;
 Fri, 14 Oct 2022 15:05:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d1R5=2P=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ojMFd-0000AU-Lm
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 15:05:29 +0000
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com
 [2a00:1450:4864:20::62f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a3ab1582-4bd1-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 17:05:28 +0200 (CEST)
Received: by mail-ej1-x62f.google.com with SMTP id bj12so11051473ejb.13
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 08:05:28 -0700 (PDT)
Received: from [192.168.1.93] (adsl-33.176.58.192.tellas.gr. [176.58.192.33])
 by smtp.gmail.com with ESMTPSA id
 qu16-20020a170907111000b00780982d77d1sm1614506ejb.154.2022.10.14.08.05.26
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 14 Oct 2022 08:05:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3ab1582-4bd1-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:references:cc:to:from
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=0XM/vEqY1i+CYCuAeKwNPHkDv23eUhhqmEnHw/Wdu+4=;
        b=ZFBHc6Pc8vK64Vu9U7uObXS2R1rpQjckhizS42yiHK1KfBleFM0f/dfwzcvll1Geb8
         kmJvVwaRxhOdN2RLoLtG0jL3nWwu64Up6YFJyC9hyOAoLG9DBZ819/rZytEWDK+rOPCr
         GF6S4VhtDZrELzO8M3THX8kcWNfkZo/SMhIDZm6GIyWvEyuhMPsBedMaPpQG2IOpwqFI
         oz45Z6SEcSA29ChvmDWh+f09s8zkbrv5C4UoBDwk8smBJVdSPTRVOVinb/dVetWtNSw+
         EUsnyPh5cth08K5ykA3TUxWwNgZXB0Zig4geFDHBT2RfAphOLwg+wOrUX31nEezx7kZs
         O9EA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:references:cc:to:from
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=0XM/vEqY1i+CYCuAeKwNPHkDv23eUhhqmEnHw/Wdu+4=;
        b=kd4uEUDiVB4S18Pg/vHf8PhidcRiTnqp2teCvJjfPbW3wB47ulhiVrgouJO5btcq0M
         qrSe1BAZzuGjJCKX93ziZbuTAZP1/jxhv87AGzBpfciy25uibbv2E+SHe3iWmWiWW8Pe
         DK+7EeKr8S20v411ZB8LLXzzJNlzAYY7doAdI9HpGZLN/fRuKR8pqPBXcwIv4lLdOd2c
         6uqS/9R5I6ujqKX2fv/DRlCPwq2tafsyfYMo/UfC2IN7GF5gjvbY0g7B02ZIRC7xd1zq
         AblUKnYZ/MdAJh3NOtAWBCrtBQAR/zesadVJLOoFV4mHcpiD5NpNcC713LYa9Y6fWFyp
         nIWw==
X-Gm-Message-State: ACrzQf29Z+ct+4v2OOFuPGmxDvqcNlAHcQEJrLvD/2XS/g5RpmkyGMTh
	85cVDMZbeoLjZcvUzc34jPs=
X-Google-Smtp-Source: AMsMyM4MnFnJlQVOvRfGXpd0LC7tze/1eZObXZQzXNNiz4fWLJNUZIEFa4MNPsB7xB3kRdG7KxTGZw==
X-Received: by 2002:a17:906:6a8d:b0:741:6a3b:536e with SMTP id p13-20020a1709066a8d00b007416a3b536emr3966452ejr.11.1665759928064;
        Fri, 14 Oct 2022 08:05:28 -0700 (PDT)
Message-ID: <f99f9c39-c374-7d9b-c293-cbc683187698@gmail.com>
Date: Fri, 14 Oct 2022 18:05:25 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
From: Xenia Ragiadakou <burzalodowa@gmail.com>
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
 <db3a487d-8330-fc68-8659-b6974352e7bc@gmail.com>
 <b11427d2-f25f-b303-bf1c-db5be4806f4b@xen.org>
 <c1b82073-08a5-033f-86aa-3a318f596ef0@gmail.com>
In-Reply-To: <c1b82073-08a5-033f-86aa-3a318f596ef0@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/14/22 13:22, Xenia Ragiadakou wrote:
> 
> On 10/14/22 13:04, Julien Grall wrote:
>> Hi Xenia,
>>
>> On 14/10/2022 10:46, Xenia Ragiadakou wrote:
>>>
>>> On 10/13/22 15:39, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> On 13/10/2022 13:29, Henry Wang wrote:
>>>>>> -----Original Message-----
>>>>>> From: Jan Beulich <jbeulich@suse.com>
>>>>>>>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * 
>>>>>>>> (N - 1))?
>>>>>>>> Or is the root table not taken from the p2m pool?
>>>>>>>
>>>>>>> Correct, on arm the root is not taken from the pool.
>>>>>>
>>>>>> Isn't that a (perhaps just minor) mistake?
>>>>>
>>>>> Not really, in the code review phase, the question of whether we 
>>>>> include
>>>>> the root in the p2m pool was discussed and the conclusion at that time
>>>>> was not including this page for now, as this is supposed to require 
>>>>> a lot
>>>>> of extra work/refactor. Probably there will be a series from my 
>>>>> side to
>>>>> add the root to the pool, but at least not now.
>>>>
>>>> The root page tables can be one of multiple concatenated pages (up 
>>>> to 8 pages). The P2M pool is allocating page by page and therefore 
>>>> wouldn't allow us to allocate contiguous pages.
>>>
>>> Sorry that I 'm asking this so late (I was just going through the 
>>> thread) but why 8?
>> Rather than providing an extra level of page-tables, the architecture 
>> allows you to provide multiple pages at the root level.
>>
>> The number of concatenated pages depend on the maximum physical 
>> address and the start level. You can look at the table in 
>> setup_virt_paging() for more details.
> 
> I think you are referring to this:
> [6] = { 52,      12/*12*/,  3,          3 },
> Still I cannot understand why the maximum number of concatenated level 0 
> translation tables for t0sz 12 and 4KB granule is 8 and not 16?
> 

Let me explain. Initially I got confused because according to the manual 
up to 16 translation tables can be concatenated. Then, looking at the 
code you have pointed out, I understood that you were referring to the 
maximum root order in the table below.

pa_range_info[] = {
         /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */
         /*      PA size, t0sz(min), root-order, sl0(max) */
         [0] = { 32,      32/*32*/,  0,          1 },
         [1] = { 36,      28/*28*/,  0,          1 },
         [2] = { 40,      24/*24*/,  1,          1 },
         [3] = { 42,      22/*22*/,  3,          1 },
         [4] = { 44,      20/*20*/,  0,          2 },
         [5] = { 48,      16/*16*/,  0,          2 },
         [6] = { 52,      12/*12*/,  3,          3 },
         [7] = { 0 }  /* Invalid */
     };

I think that the pa range info for the 52-bit pa range is wrong.
IMO, it could be either
[6] = { 52,      12/*12*/,  0,          3 } i.e single level -1 table
or
[6] = { 52,      12/*12*/,  4,          2 } i.e 16 concatenated level 0 
tables
Hope I am not totally out of context.

>>
>> Cheers,
>>
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 15:06:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 15:06:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422936.669311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojMGm-0000hy-Fa; Fri, 14 Oct 2022 15:06:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422936.669311; Fri, 14 Oct 2022 15:06:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojMGm-0000hr-Cr; Fri, 14 Oct 2022 15:06:40 +0000
Received: by outflank-mailman (input) for mailman id 422936;
 Fri, 14 Oct 2022 15:06:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ux67=2P=citrix.com=prvs=2791c07bb=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1ojMGl-0000hh-5p
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 15:06:39 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c9b187a8-4bd1-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 17:06:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9b187a8-4bd1-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665759994;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Ip0UWpQYpO1WzkjZXotVq07QzgOtRWSU7x0wB6dvT8U=;
  b=Mz4L577d0O2yOSJXUTYjm+9mtg2XvJ6bqU/KGgbFyRrl26rUKHZyHP9r
   7HhkThgnf/ZCqnmeVtLeQS0/Pjq0KJYoqSbOkGN+ZRNI7VzhLMzNlLNx/
   qOJL3ijGXm1kgcWtNVHocRyN8aZOVGs/0Jqw3Nuiu+33nIezs47HBkEZD
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82385662
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:W441b6umYy9lZ1LzA4qtcTMgK+fnVNVeMUV32f8akzHdYApBsoF/q
 tZmKW+OP/qDYmD1LdlxYd/j8h8DvMPVm99iHFRt+ylgFCMW+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakX5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkUp
 fIKcyImVCvbhvDtney0c8VpvOcKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI
 ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUPxRbF+
 Dycl4j/KgsEONO1kCiry36xrN6UwALUSpgsHpTto5aGh3XMnzdOWXX6T2CTo/ajjVWlc8lCM
 EFS8S0rxYAu9UmDXtT7GRqirxasvAMYWtdWO/037keK0KW8ywqQGGUsVDNKb90i8sgsSlQC2
 1uEmdqvGDJutaGORGyU3rCOpDi2NG4eKmpqTSMcVg4E/9nLqZk+lA7SVc1kFLOpj9rzAnf7x
 DXihDgzgfAfgNAG042//EvbmHS8q57RVAk36w7LGGW/4WtRe4qNd4Gur1/B4p5oLoyUU12At
 3gsgNWF4aYFCpTlqcCWaLxTRvfzva/DaWCCxw40d3U8y9iz0yTzc5IL8hpEHx9oIJ1ZJzDQT
 ErpmioEsfe/I0CWRaNwZouwDeEjwq7hCcnpW5joUzZeXnRiXFTZpX8zPCZ8y0ioyRFxyv9nZ
 f93ZO72VR4n5bJbIC1argv3+Zsi3WgAyGzaXvgXJDz3gOPFNBZ5pVroWWZij9zVDove/W05E
 P4FbaNmLimzt8WnO0HqHXY7dwxiEJTCLcmeRzZrXuCCOBF6P2oqFuXcx7gsE6Q8wfoIyLeWo
 ijmBxIAoLYauZEgAVzQAk2PlZu1BcovxZ7FFXZE0amUN4gLPt/0sfZ3m2ofdrg77u1zpcNJo
 w0+U5zYWJxnE22fkxxENMmVkWCXXEny7e54F3H+O2ZXkl8Jb1Ghx+IIiSO0pHNTU3Pt6ZFjy
 1BivyuCKac+q81ZJJ6+QJqSI5mZ5xDxRMoas5P0H+Ru
IronPort-HdrOrdr: A9a23:ihcCLKgGL9GeUFBDqlvsGIu323BQXtoji2hC6mlwRA09TySZ//
 rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFebvN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="82385662"
Date: Fri, 14 Oct 2022 16:06:17 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Christian Lindig <christian.lindig@citrix.com>, "Daniel P . Smith"
	<dpsmith@apertussolutions.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Tim Deegan
	<tim@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Juergen Gross
	<jgross@suse.com>, David Scott <dave@recoil.org>, Julien Grall
	<julien@xen.org>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere
 else
Message-ID: <Y0l66TN/w05EQr91@perard.uk.xensource.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-6-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221013130513.52440-6-anthony.perard@citrix.com>

On Thu, Oct 13, 2022 at 02:05:01PM +0100, Anthony PERARD wrote:
> Patch "tools: Add -Werror by default to all tools/" have added
> "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other
> makefiles as it is now duplicated.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Christian Lindig <christian.lindig@citrix.com>
> Acked-by: Daniel P. Smith <dpsmith@apertussolutions.com> # tools/flask
> Acked-by: Jan Beulich <jbeulich@suse.com> # tools/*/cpu-policy
> ---
> 
> Notes:
>     missing-ack:
>     - GDBSX DEBUGGER
>     - KDD DEBUGGER
>     - XENTRACE
> 
>  tools/console/client/Makefile   | 1 -
>  tools/console/daemon/Makefile   | 1 -
>  tools/debugger/kdd/Makefile     | 1 -
>  tools/flask/utils/Makefile      | 1 -
>  tools/fuzz/cpu-policy/Makefile  | 2 +-
>  tools/misc/Makefile             | 1 -
>  tools/tests/cpu-policy/Makefile | 2 +-
>  tools/tests/depriv/Makefile     | 2 +-
>  tools/tests/resource/Makefile   | 1 -
>  tools/tests/tsx/Makefile        | 1 -
>  tools/tests/xenstore/Makefile   | 1 -
>  tools/xcutils/Makefile          | 2 --
>  tools/xenmon/Makefile           | 1 -
>  tools/xenpaging/Makefile        | 1 -
>  tools/xenpmd/Makefile           | 1 -
>  tools/xentop/Makefile           | 2 +-
>  tools/xentrace/Makefile         | 2 --
>  tools/xl/Makefile               | 2 +-
>  tools/debugger/gdbsx/Rules.mk   | 2 +-
>  tools/firmware/Rules.mk         | 2 --
>  tools/libfsimage/common.mk      | 2 +-
>  tools/libs/libs.mk              | 2 +-
>  tools/ocaml/common.make         | 2 +-
>  tools/xenstore/Makefile.common  | 1 -
>  24 files changed, 9 insertions(+), 27 deletions(-)

Missing hunk as pointed out by Andrew:

diff --git a/tools/pygrub/setup.py b/tools/pygrub/setup.py
index b8f1dc4590..0e4e3d02d3 100644
--- a/tools/pygrub/setup.py
+++ b/tools/pygrub/setup.py
@@ -3,7 +3,7 @@ from distutils.ccompiler import new_compiler
 import os
 import sys

-extra_compile_args  = [ "-fno-strict-aliasing", "-Werror" ]
+extra_compile_args  = [ "-fno-strict-aliasing" ]

 XEN_ROOT = "../.."

diff --git a/tools/python/setup.py b/tools/python/setup.py
index 8c95db7769..721a3141d7 100644
--- a/tools/python/setup.py
+++ b/tools/python/setup.py
@@ -8,7 +8,7 @@ SHLIB_libxenctrl = os.environ['SHLIB_libxenctrl'].split()
 SHLIB_libxenguest = os.environ['SHLIB_libxenguest'].split()
 SHLIB_libxenstore = os.environ['SHLIB_libxenstore'].split()

-extra_compile_args  = [ "-fno-strict-aliasing", "-Werror" ]
+extra_compile_args  = [ "-fno-strict-aliasing" ]

 PATH_XEN      = XEN_ROOT + "/tools/include"
 PATH_LIBXENTOOLLOG = XEN_ROOT + "/tools/libs/toollog"


We can see the change, or duplicate of "-Werror" in commands run by
setup.py by running `setup.py build --verbose`.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 15:21:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 15:21:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422944.669325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojMVK-00038j-Qw; Fri, 14 Oct 2022 15:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422944.669325; Fri, 14 Oct 2022 15:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojMVK-00038c-OB; Fri, 14 Oct 2022 15:21:42 +0000
Received: by outflank-mailman (input) for mailman id 422944;
 Fri, 14 Oct 2022 15:21:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojMVJ-00038W-KY
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 15:21:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojMVF-0003QC-Pv; Fri, 14 Oct 2022 15:21:37 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojMVF-0002cN-J5; Fri, 14 Oct 2022 15:21:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0XY7gnFKukmCg55DLHHtzdVWwC4EG5VOzE+czI5yn/I=; b=zXuJ8DcMtiiFTojgvLzogElW8K
	YqBsQJwLYNDE5bgBsqUF2BCI3PdUhcgrWsnGgvYpXKj55oemZ+/nOPQCML4RprlefuhSyc2ta3wzt
	rp+8fhJ9GMjrU7gVBj0BKvj2iku0KBCn9UTjm3jiIDzC/+48x4Du+6A2iti/QioGNtV8=;
Message-ID: <99d8ebc7-28d4-5569-1fdf-6600e2dd2504@xen.org>
Date: Fri, 14 Oct 2022 16:21:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, Henry Wang
 <Henry.Wang@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221013083818.36209-1-Henry.Wang@arm.com>
 <c1020b65-491f-e1c5-3ef3-7edb99e0435c@xen.org>
 <AS8PR08MB7991F3222D1C616AEF9C771092259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <2c2b3e8f-34fc-1ef2-c086-233964e29e43@xen.org>
 <03419318-275a-1f9d-6e00-1a3489659f22@suse.com>
 <AS8PR08MB79917792FD8A7695C969020992259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <05c4def0-321e-c864-7d92-b4dfe110d030@suse.com>
 <AS8PR08MB7991AD5D30E4EBADD0A7582592259@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <ccca7922-513d-3a9d-c994-f15c23e40812@xen.org>
 <db3a487d-8330-fc68-8659-b6974352e7bc@gmail.com>
 <b11427d2-f25f-b303-bf1c-db5be4806f4b@xen.org>
 <c1b82073-08a5-033f-86aa-3a318f596ef0@gmail.com>
 <f99f9c39-c374-7d9b-c293-cbc683187698@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f99f9c39-c374-7d9b-c293-cbc683187698@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Xenia,

On 14/10/2022 16:05, Xenia Ragiadakou wrote:
> On 10/14/22 13:22, Xenia Ragiadakou wrote:
>>
>> On 10/14/22 13:04, Julien Grall wrote:
>>> Hi Xenia,
>>>
>>> On 14/10/2022 10:46, Xenia Ragiadakou wrote:
>>>>
>>>> On 10/13/22 15:39, Julien Grall wrote:
>>>>> Hi,
>>>>>
>>>>> On 13/10/2022 13:29, Henry Wang wrote:
>>>>>>> -----Original Message-----
>>>>>>> From: Jan Beulich <jbeulich@suse.com>
>>>>>>>>> Assuming you have 4 (N) page table levels, isn't it 7 (1 + 2 * 
>>>>>>>>> (N - 1))?
>>>>>>>>> Or is the root table not taken from the p2m pool?
>>>>>>>>
>>>>>>>> Correct, on arm the root is not taken from the pool.
>>>>>>>
>>>>>>> Isn't that a (perhaps just minor) mistake?
>>>>>>
>>>>>> Not really, in the code review phase, the question of whether we 
>>>>>> include
>>>>>> the root in the p2m pool was discussed and the conclusion at that 
>>>>>> time
>>>>>> was not including this page for now, as this is supposed to 
>>>>>> require a lot
>>>>>> of extra work/refactor. Probably there will be a series from my 
>>>>>> side to
>>>>>> add the root to the pool, but at least not now.
>>>>>
>>>>> The root page tables can be one of multiple concatenated pages (up 
>>>>> to 8 pages). The P2M pool is allocating page by page and therefore 
>>>>> wouldn't allow us to allocate contiguous pages.
>>>>
>>>> Sorry that I 'm asking this so late (I was just going through the 
>>>> thread) but why 8?
>>> Rather than providing an extra level of page-tables, the architecture 
>>> allows you to provide multiple pages at the root level.
>>>
>>> The number of concatenated pages depend on the maximum physical 
>>> address and the start level. You can look at the table in 
>>> setup_virt_paging() for more details.
>>
>> I think you are referring to this:
>> [6] = { 52,      12/*12*/,  3,          3 },
>> Still I cannot understand why the maximum number of concatenated level 
>> 0 translation tables for t0sz 12 and 4KB granule is 8 and not 16?
>>
> 
> Let me explain. Initially I got confused because according to the manual 
> up to 16 translation tables can be concatenated. Then, looking at the 
> code you have pointed out, I understood that you were referring to the 
> maximum root order in the table below.
> 
> pa_range_info[] = {
>          /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */
>          /*      PA size, t0sz(min), root-order, sl0(max) */
>          [0] = { 32,      32/*32*/,  0,          1 },
>          [1] = { 36,      28/*28*/,  0,          1 },
>          [2] = { 40,      24/*24*/,  1,          1 },
>          [3] = { 42,      22/*22*/,  3,          1 },
>          [4] = { 44,      20/*20*/,  0,          2 },
>          [5] = { 48,      16/*16*/,  0,          2 },
>          [6] = { 52,      12/*12*/,  3,          3 },
>          [7] = { 0 }  /* Invalid */
>      };
> 
> I think that the pa range info for the 52-bit pa range is wrong.

I was about to say the same and note that in Xen we don't support 
52-bits. So effectively those values are ignored for now.

> IMO, it could be either
> [6] = { 52,      12/*12*/,  0,          3 } i.e single level -1 table

I don't think Xen is ready to support -1 for the root level. So...

> or > [6] = { 52,      12/*12*/,  4,          2 } i.e 16 concatenated level 0
> tables


... this would be better. But this is not related to this patch 
directly. So any fix should be sent separately.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 16:43:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 16:43:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422958.669365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojNlx-0003nA-Q1; Fri, 14 Oct 2022 16:42:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422958.669365; Fri, 14 Oct 2022 16:42:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojNlx-0003n3-N5; Fri, 14 Oct 2022 16:42:57 +0000
Received: by outflank-mailman (input) for mailman id 422958;
 Fri, 14 Oct 2022 16:42:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=y2dk=2P=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1ojNlv-0003mx-Qk
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 16:42:56 +0000
Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com
 [2607:f8b0:4864:20::e36])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f172810-4bdf-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 18:42:53 +0200 (CEST)
Received: by mail-vs1-xe36.google.com with SMTP id p7so5469861vsr.7
 for <xen-devel@lists.xenproject.org>; Fri, 14 Oct 2022 09:42:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f172810-4bdf-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=wt+V0AcGUrkJBrd79DUopZc6pHSzx6aJRfDTWLn7cSc=;
        b=oo4KrEuoZ3NrkSg+MhFPpK6gOj0yNiatXyHzLv+IfdUhKtLhxxX3JJ3EHgsSAzDPbH
         8p1XuOnwX6B+odUyZCSTLnQGFV3KXzS/7C2rlO42o4jSc0hLQxbjBAgS6tWjBBTtgB/t
         b1k9nkbdg8xxAs4js9PHEsz+LFZBI9u7Df5O4OpYGtIT5G6uuAb5CeH0z6bjVN2x3XDx
         JH3wzSYhAy6tarQYJ9Q2FAFb5m3l0a3rBExfPbK68szGYY7XVp3CvgGK/QVBf1L0Ofj0
         zXB9Yk59BYRF3t2jN+ghUsCHctQNgW/jO5vT2f21iSs/ra6fVBE+jlfq6bk3+TIi9v5l
         xqTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=wt+V0AcGUrkJBrd79DUopZc6pHSzx6aJRfDTWLn7cSc=;
        b=aKO75/qZZNa71Oi859MbDwWI7JDEF9O72i2Bjvy227VdJ9c9R10Q70TSTCM+5E7sDY
         Dbp2EygOJ+64hDKRnyV+oGUApuXI7IsRPVd5eqWeJ3T0ZAap/Awejhrw3H/JbTV0l6Ja
         Qqc2T4KFUJouiVEYyyeRYJSGR00Jj7N44jNU1Ov/dKPStx+zXwUZiZbRIBfQRemuULci
         m0PYv3sRFPQfGoFR85GWOMj1QbsbSo7wcCYGOchHYyYFD2qE2VX+eSajkLkU7ONJQtqg
         USkUuoj+rxz4TNvk0ZSoIItYalQvKmXMQsv/iGjiEGOu/4S6Myjcj5wZ3IwHT4/7qwBa
         b87w==
X-Gm-Message-State: ACrzQf1Y/8UX59eLv8dTSKcAcR0tqy62SjEmLQ0MTaLHvE01RP4ePIRn
	PIjGWLsDIyfXbKHPadDBbs2NN6qasjWdtOnrTZY=
X-Google-Smtp-Source: AMsMyM50XvsG6U43Q6xZNb7s/q9oFPAnd8MKy+6yvokZChN+au6TXK0wWikh0H7YxTYRvGpbrBCA5DdFPCpqEbFopTE=
X-Received: by 2002:a67:c891:0:b0:398:a7ff:e0f0 with SMTP id
 v17-20020a67c891000000b00398a7ffe0f0mr3240416vsk.22.1665765772147; Fri, 14
 Oct 2022 09:42:52 -0700 (PDT)
MIME-Version: 1.0
References: <20200323000946.GH18599@mail-itl> <20200929142730.GA25731@mail-itl>
 <d243c1b5-712d-a958-0b6c-b232eb4edc80@suse.com> <20200929151627.GE1482@mail-itl>
 <ea53b845-5edf-a61e-62ae-7ababc30b3e0@suse.com> <20210131021526.GB6354@mail-itl>
 <YWHDIQC3K8J3LD8+@mail-itl> <YwJZ3X0HpT9w6Veh@mail-itl> <b1df84d5-a1ca-3019-16a7-36d0bb568779@suse.com>
 <YwNTu1fL7uITg0OZ@mail-itl> <YymUZCfLZRWl6xr5@mail-itl>
In-Reply-To: <YymUZCfLZRWl6xr5@mail-itl>
From: George Dunlap <dunlapg@umich.edu>
Date: Fri, 14 Oct 2022 17:42:40 +0100
Message-ID: <CAFLBxZZUknp80CQx9rhQhD=hzqV+eOR5Me=eyU1sJUHMaMUybg@mail.gmail.com>
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer
To: =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.de>, 
	Dario Faggioli <dfaggioli@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	xen-devel <xen-devel@lists.xenproject.org>, =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= <jgross@suse.com>
Content-Type: multipart/alternative; boundary="00000000000020c10005eb015106"

--00000000000020c10005eb015106
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 20, 2022 at 11:23 AM Marek Marczykowski-G=C3=B3recki <
marmarek@invisiblethingslab.com> wrote:

>
> I have two (non exclusive) ideas here:
> 1. If old_cpu is actually still available, do not move it at all.
> 2. Use sched_migrate() instead of sched_set_res().
>

Other possibilities:

3.  Make sure that svc->rqd is set to null when the affinity is broken.

Currently on vcpu creation, sched_init_vcpu() expects to set the pcpu; and
it looks like for credit2, the svc->rqd may not be set until the first time
it's woken up (that's the 'if' part of the 'if/else' clause whose 'else'
contains the ASSERT() you're hitting).  If when we broke the CPU affinity
on suspend, we set the runqueues to NULL, then on wake it would "take" the
runqueue assigned by restore_vcpu_affinity().

4. Make sched2_unit_wake() tolerant of pcpus changing under its feet.

#3 would potentially make things more robust, but would require adding some
sort of call-back to notify schedulers that affinity had been broken.  ATM
this might only be used by credit2.

#4 would potentially be dangerous: if some other bit of credit2 code which
assumes the svc->rq is valid.


> Here is the patch that fixes it for me:
> ---8<---
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 83455fbde1c8..dcf202d8b307 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -1246,19 +1246,29 @@ void restore_vcpu_affinity(struct domain *d)
>              }
>          }
>
> -        res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)));
> +        /* Prefer old cpu if available. */
> +        if ( cpumask_test_cpu(old_cpu, cpumask_scratch_cpu(cpu)) )
> +            res =3D get_sched_res(old_cpu);
> +        else
> +            res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)))=
;
>          sched_set_res(unit, res);
>
>          spin_unlock_irq(lock);
>
> -        /* v->processor might have changed, so reacquire the lock. */
> -        lock =3D unit_schedule_lock_irq(unit);
> -        res =3D sched_pick_resource(unit_scheduler(unit), unit);
> -        sched_set_res(unit, res);
> -        spin_unlock_irq(lock);
> -
> +        /*
> +         * If different cpu was chosen, it was random, let scheduler do
> proper
> +         * decision.
> +         */
>          if ( old_cpu !=3D sched_unit_master(unit) )
> +        {
> +            /* v->processor might have changed, so reacquire the lock. *=
/
> +            lock =3D unit_schedule_lock_irq(unit);
> +            res =3D sched_pick_resource(unit_scheduler(unit), unit);
> +            sched_migrate(unit_scheduler(unit), unit, res->master_cpu);
> +            spin_unlock_irq(lock);
> +
>              sched_move_irqs(unit);
> +        }
>      }
>
>      rcu_read_unlock(&sched_res_rculock);
> ---8<---
>
> I have several doubts here:
>
> 1. If old_cpu is available, is sched_set_res() needed at all?
> 2. Should both calls be changed to sched_migrate()? Currently I changed
>    only the second one, in case scheduler could be confused about
>    old_cpu not being available anymore.
> 3. Are there any extra locking requirements for sched_migrate() at this
>    stage? The long comment above sched_unit_migrate_start() suggests
>    there might be, but I'm not sure if that's really the case during
>    resume.
> 4. Related to the above - should thaw_domains() be modified to call
>    restore_vcpu_affinity() for all domains first, and unpause only
>    later? That could reduce locking requirements, I guess.
>

Unfortunately this code has had a lot of churn since the last time I really
engaged with it; I'm going to have to come back to this on Monday.

J=C3=BCrgen / Dario, any thoughts?

 -George

--00000000000020c10005eb015106
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Sep 20, 2022 at 11:23 AM Mare=
k Marczykowski-G=C3=B3recki &lt;<a href=3D"mailto:marmarek@invisiblethingsl=
ab.com">marmarek@invisiblethingslab.com</a>&gt; wrote:<br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex"><br>
I have two (non exclusive) ideas here:<br>
1. If old_cpu is actually still available, do not move it at all.<br>
2. Use sched_migrate() instead of sched_set_res().<br></blockquote><div><br=
></div><div>Other possibilities:</div><div><br></div><div>3.=C2=A0 Make sur=
e that svc-&gt;rqd is set to null when the affinity is broken.</div><div><b=
r></div><div>Currently on vcpu creation, sched_init_vcpu() expects to set t=
he pcpu; and it looks like for credit2, the svc-&gt;rqd may not be set unti=
l the first time it&#39;s woken up (that&#39;s the &#39;if&#39; part of the=
 &#39;if/else&#39; clause whose &#39;else&#39; contains the ASSERT() you&#3=
9;re hitting).=C2=A0 If when we broke the CPU affinity on suspend, we set t=
he runqueues to NULL, then on wake it would &quot;take&quot; the runqueue a=
ssigned by restore_vcpu_affinity().</div><div><br></div><div>4. Make sched2=
_unit_wake() tolerant of pcpus changing under its feet.</div><div><br></div=
><div>#3 would potentially make things more robust, but would require addin=
g some sort of call-back to notify schedulers that affinity had been broken=
.=C2=A0 ATM this might only be used by credit2.</div><div><br></div><div>#4=
 would potentially be dangerous: if some other bit of credit2 code which as=
sumes the svc-&gt;rq is valid.</div><div>=C2=A0</div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex">Here is the patch that fixes it for me:<br>
---8&lt;---<br>
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c<br>
index 83455fbde1c8..dcf202d8b307 100644<br>
--- a/xen/common/sched/core.c<br>
+++ b/xen/common/sched/core.c<br>
@@ -1246,19 +1246,29 @@ void restore_vcpu_affinity(struct domain *d)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D get_sched_res(cpumask_any(cpumask_scra=
tch_cpu(cpu)));<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* Prefer old cpu if available. */<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( cpumask_test_cpu(old_cpu, cpumask_scratch=
_cpu(cpu)) )<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D get_sched_res(old_cpu);<=
br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D get_sched_res(cpumask_an=
y(cpumask_scratch_cpu(cpu)));<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sched_set_res(unit, res);<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0spin_unlock_irq(lock);<br>
<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* v-&gt;processor might have changed, so reac=
quire the lock. */<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 lock =3D unit_schedule_lock_irq(unit);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D sched_pick_resource(unit_scheduler(uni=
t), unit);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 sched_set_res(unit, res);<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 spin_unlock_irq(lock);<br>
-<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 /*<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* If different cpu was chosen, it was ra=
ndom, let scheduler do proper<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* decision.<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( old_cpu !=3D sched_unit_master(unit)=
 )<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 {<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* v-&gt;processor might have ch=
anged, so reacquire the lock. */<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 lock =3D unit_schedule_lock_irq(=
unit);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 res =3D sched_pick_resource(unit=
_scheduler(unit), unit);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sched_migrate(unit_scheduler(uni=
t), unit, res-&gt;master_cpu);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 spin_unlock_irq(lock);<br>
+<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sched_move_irqs(unit);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0}<br>
<br>
=C2=A0 =C2=A0 =C2=A0rcu_read_unlock(&amp;sched_res_rculock);<br>
---8&lt;---<br>
<br>
I have several doubts here:<br>
<br>
1. If old_cpu is available, is sched_set_res() needed at all?<br>
2. Should both calls be changed to sched_migrate()? Currently I changed<br>
=C2=A0 =C2=A0only the second one, in case scheduler could be confused about=
<br>
=C2=A0 =C2=A0old_cpu not being available anymore.<br>
3. Are there any extra locking requirements for sched_migrate() at this<br>
=C2=A0 =C2=A0stage? The long comment above sched_unit_migrate_start() sugge=
sts<br>
=C2=A0 =C2=A0there might be, but I&#39;m not sure if that&#39;s really the =
case during<br>
=C2=A0 =C2=A0resume.<br>
4. Related to the above - should thaw_domains() be modified to call<br>
=C2=A0 =C2=A0restore_vcpu_affinity() for all domains first, and unpause onl=
y<br>
=C2=A0 =C2=A0later? That could reduce locking requirements, I guess.<br></b=
lockquote><div><br></div><div>Unfortunately this code has had a lot of chur=
n since the last time I really engaged with it; I&#39;m going to have to co=
me back to this on Monday.</div><div><br></div><div>J=C3=BCrgen / Dario, an=
y thoughts?<br></div><div><br></div><div>=C2=A0-George=C2=A0</div></div></d=
iv>

--00000000000020c10005eb015106--


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 17:40:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 17:40:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422970.669392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojOfv-0001nP-D5; Fri, 14 Oct 2022 17:40:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422970.669392; Fri, 14 Oct 2022 17:40:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojOfv-0001nI-A2; Fri, 14 Oct 2022 17:40:47 +0000
Received: by outflank-mailman (input) for mailman id 422970;
 Fri, 14 Oct 2022 17:40:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojOft-0001nC-Ez
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 17:40:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojOft-0006M4-6f; Fri, 14 Oct 2022 17:40:45 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.21.194]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojOfs-0005dj-WF; Fri, 14 Oct 2022 17:40:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=RK4/JrJrs2TnS03PnU1cHiEPWzNKJM3EZ2vbkQuF3Hk=; b=iKmosFfMUv+7tlYdblvniIlCCd
	0HgdWC+aKjGCXFiN0ioLXqY5GIMYfO57I//CDhBDyA4LZYtPdsLElYwylYzzop5OIL8ZWK3+3vDgS
	qOOWvjUCeafHQlgZcazD3iN4sVYAFvPGYnQ4Wb9sLBPjB7f548XGOt4U8TR/S7exFuqE=;
Message-ID: <e53601a1-a5ac-897a-334d-de45d96e9863@xen.org>
Date: Fri, 14 Oct 2022 18:40:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-2-Henry.Wang@arm.com>
 <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
 <AS8PR08MB799119B54A5FE419CDDB9C1592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <3cfdcd2b-cc18-0585-d837-f5932d9eeb0f@xen.org>
 <AS8PR08MB7991508880001B08C602881692249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991508880001B08C602881692249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 14/10/2022 10:31, Henry Wang wrote:
> Hi Julien,

Hi,

> 
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>>>>> +Users should be mindful that the static heap should at least satisfy the
>>>>> +allocation of the P2M maps for all guests. Currently, the minimal
>>>> requirement
>>>>> +of per-domain P2M pages pool is in-sync with function
>>>>> +libxl__get_required_paging_memory() (for xl-created domUs) and
>>>>> +domain_p2m_pages() (for dom0less domUs), that is, 1MB per vCPU,
>> plus
>>>> 4KiB per
>>>>> +MiB of RAM for the P2M map, and plus 512KiB to cover extended
>> regions.
>>>>
>>>> I think this wording is OK if the feature is a tech preview. However, if
>>>> this is security supported, we need to provide some more details about
>>>> the size.
>>>>
>>>> In particular, this doesn't tell a user how they can find the size that
>>>> would fit them. Can this be decided with a formula?
>>> My feeling of the formula would be:
>>>
>>> Total heap size needed per guest =  1MB * num_guest_vcpu +
>>>       4KB * guest_ram_size_in_mb + 512KB +
>>>       the memory allocated from heap by xzalloc/xzalloc_array for
>> 	various uses
>>>       for example alloc_domain_struct(), d->shared_info, evtchn_bucket, etc.
>>
>> There are also some pages allocated using alloc_{xen,dom}heap_pages().
>> We also need to take into account runtime allocation done by some
>> hypercalls (I can't remember which one) or subsystem like OPTee.
>>
>> In addition to that, you also have memory for the system. E.g
>> frametables, Xen page-tables, various driver allocations...
>>
>>>
>>> Is this formula somehow make sense to you? I think we need to have a
>>> rough estimation of the last part (boot time allocation) though.
>>
>> That's going to be hard. It will vary depending on your system and this
>> could change in the future as we add more features. For instance, I
>> expect the PCI passthrough will need some memory to keep track of all
>> the devices.
>>
>> I am worry the formula will become complex. Ideally we need to have a
>> very simple formula. If that's not possible, then we need to provide a
>> way for the user to estimate it at runtime (like what I suggested before).
> 
> I agree, I think the simple formula can only be achieved is we have an
> estimation of the worst case scenario of those scattered memory usages.
> I remember I once had a try so let me try to find the results back that time...
> 
> I am also very interested in the method that you proposed to provide a
> mechanism for users to get the system memory allocation at runtime. But
> IIUC this needs some work in another series. Could you please confirm if I
> am understanding correctly? Or probably Xen has some mechanisms that
> I am likely unaware? Thanks!

It will depend the way you account memory statically allocated to 
domains in Xen.

We already provide the total amount of memory in the system and how much 
is free. The values can be retrieved using ``xl info``.

  * When not allocated, is this considered free or used?
  * Are they included in the total memory?

If the answer is no for both (possibly just one), then we will need to 
provide extra hypercalls to expose the size of the xenheap and how much 
is free.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 18:03:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 18:03:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.422979.669412 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojP1i-0004SN-7L; Fri, 14 Oct 2022 18:03:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 422979.669412; Fri, 14 Oct 2022 18:03:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojP1i-0004SG-44; Fri, 14 Oct 2022 18:03:18 +0000
Received: by outflank-mailman (input) for mailman id 422979;
 Fri, 14 Oct 2022 18:03:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojP1g-0004SA-PL
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 18:03:17 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77c9b746-4bea-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 20:03:14 +0200 (CEST)
Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 14:03:11 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA1PR03MB6642.namprd03.prod.outlook.com (2603:10b6:806:1cd::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 18:03:08 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 18:03:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77c9b746-4bea-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665770594;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=a4c9qt6aF2LtXKGOFUoqdx54OpH6S4n66TKVp+mnZXo=;
  b=DHg+UAd1zZ7qA7XrNhFcKSD3MWAUewh7/qMrw5sve9hsctuhVuY0xpxS
   A7sYG3vvWx6d4hnleAbfDNpf1FYDbU89Ep+Ylw7nJPnX3DO/aWJacg2ZX
   YduRATuP1Y6imIQZxquhlyGDH4Pvmk7OyiizEAAV5aGiayMxxOq2wVF65
   U=;
X-IronPort-RemoteIP: 104.47.51.47
X-IronPort-MID: 82753914
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:oS4s/K/q8IwmwwncXuBLDrUDin+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 mQfWGrUaauIa2L1ftFzbNyy8khSu57dm9M1QQVv/388E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5wBmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uNFHUtDy
 +0mE2EicC+/jMeK0LOZdeY506zPLOGzVG8ekldJ6GmDSNwAGNXESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PNxvze7IA9ZidABNPL8fNCQSNoTtUGfv
 m/cpEzyAw0ANczZwj2Amp6prr+Vwn6gCdtOfFG+3vhun02u+HQoMjE9bXen4terhhCQSd0Kf
 iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZebPQ2uclwQiYlv
 mJlhPvsDD1r9beTEHSU8+/LqSvoYXRKa2gfeSUDUA0JpcH5p50+hQ7OSdAlF7OpitryGnf7x
 DXiQDUCuoj/RPUjj82TlW0rSRr1znQVZmbZPjnqY18=
IronPort-HdrOrdr: A9a23:kUQ8pq5iecnOZ7yH+wPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM
 BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu
 v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G
 LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+
 O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b
 MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe
 FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+
 CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5
 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8
 qO
X-IronPort-AV: E=Sophos;i="5.95,184,1661832000"; 
   d="scan'208";a="82753914"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NbRy7KEq/PBV7QikRWJ1Uk7PrYzJZma8zs8cFOHWirXc0lWelu7VH5bPBq2Lxq2i7TFs/Is9mzMdpFs4SobO6h6i/cOgICgvySgHjlyc26VyxICRHF0rD20iyEH0cafZPAVgM6ccn8v+mjYy6vrMU2SzTcDIskVtR9oBttq1VLZM7Af2IsMdCbsN+FBoAycPniHr9NnmctaPj6RGAQSvzo+mOeYsg4rb1mH00Vrbe8sOQlQKWE2P10n2R8pnx9y+lyvk6U4aN7e9wgq0o/eSnZDdk6ncfdvLgF5/3rEK1iZa0Cj7q+Nhqq3CTgdUdTbraeaAyFdL2bmSFKKEOwoggg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a4c9qt6aF2LtXKGOFUoqdx54OpH6S4n66TKVp+mnZXo=;
 b=DqKou5VChbCBxZ2pZWptSL94+QRdlDZbqmp6Br2xyhAMZJdWJiZSphkIS3x2KmMTj7PjehZhmUN2jXA5DgeqWHrrrsyZttPTyDjmhTvS2QET6unHuiV7lUM1KLcjIF5mJr8wUQyo6UEC+9GuRALRtXrep0GgzkgZTu7VOAJ1DXQ0aYTxvlavgl1UHAOByiAMkerdR6L+3nkBsIQfUWNP4ZEUh+l6ueZrJ+w9icpW0toQ3sWR7TDrYQXoAbVUh6y4S0T92PYFo8sCUYNTXjxGB1y5Ltrr8PoRvpYOmWtrYdAk2iwWqwc0en7vlQsWRl/YngipmNJAO0ZOtJYlY6lM1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a4c9qt6aF2LtXKGOFUoqdx54OpH6S4n66TKVp+mnZXo=;
 b=Kj9w+bMgVfBBNQ/SDXz9aHgpBA3tGtjnVWosWM8WMuBqnfO00u+9Pa/m58PI0oKEZlH87GsfztsUmzRYqhU76y6aScNnt/yk89p2KH51PETIRiUXdMFShbz64ATDd3uB689RLzcSOZJ+J3ZM2VO4Vq4wrWijc6+PQKWvvw563RE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH for-4.17 v5 06/17] tools/hotplug: Generate
 "hotplugpath.sh" with configure
Thread-Topic: [XEN PATCH for-4.17 v5 06/17] tools/hotplug: Generate
 "hotplugpath.sh" with configure
Thread-Index: AQHY3wSVK5RceuxC50av0rrVPsGtWa4OMGQA
Date: Fri, 14 Oct 2022 18:03:08 +0000
Message-ID: <0b14827d-28c0-26ae-e13c-cc24219e41fd@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-7-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-7-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA1PR03MB6642:EE_
x-ms-office365-filtering-correlation-id: 1ca43385-1929-4284-940b-08daae0e59da
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 0ItzKFt+KKwttr4WY3orEmR0zFUOoN1rEtum92S4HRNLpQl8UgM5cLjQhZ/Cb2nUtvUCxnJn5bINnEVgpdsDe2tDwkxmK4oylLk8sozmy5uS1imfCdEsg4za2/FS25AFXsvRkwAsyZa5XiuFhhf1G18JnBpXve1IaAIRdo5C8w5SyvJLw+XvQrH2H09x9ew04oM76ewB7MlY77aqrMinFvBwG2iPtNhpxDlw4XcbC/KgByv8M0Lg2RUCYNToX6QS+DnIovcHTJxttgJoqVIm1uWYiMyjr4uGvai5xx+ulqWTbn8ZMvP1VL8rsxN4GIGBRmD8QkfcDqG3xzBrA/ETPeYlysIy6Jvwdi1zBizto0obQCuoLcQYRyENj6Z7y5QTNk31XMlnFRKAN+dWO2/LZvHY0H45IkFmYgjyqqPP/VFrz/WnBDOCi9rb8DlBTyruy8wQ2Kpx/g/fs5jPiCmhgJ+RKIJJD1fZ8gvaiXPR2O1Qdpu2xDXpo7GS/S6Fb72cLfTUrYEO8rMReCjJQ5Bp028mlYTE6G3BpBSoaq41HCQsMO1rcWxHQB/9nYy/UzRxI+1utmqyCoFM8IR1R50k0J7JgyPCRLAlyI5kGj+hYUNDupLFUcCuLPQjVKNGba2OaOaTk5XbmywRzU09k6vQdqBDtt7GrArNUTZnl+KwybrAHp3h7ZdZ7VoaxDiE090pqQbSMjrSyS8VPRzUG91pg77cATATkwh5jf3QCu/3gnBaueYclf6WFfZwjIKGRiSMWfa2E6r61RVHG0fPUvMX/ny0+uHv/fY2EYyoqZT7DT2LFGA+OmGouqsLKxuAOikYULOPKhm0xbMTEOL6KiH99A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(39860400002)(136003)(346002)(451199015)(478600001)(71200400001)(122000001)(38070700005)(6486002)(41300700001)(86362001)(36756003)(38100700002)(110136005)(66946007)(66446008)(66476007)(76116006)(66556008)(64756008)(91956017)(31696002)(6506007)(8676002)(53546011)(4326008)(26005)(31686004)(2616005)(186003)(316002)(2906002)(82960400001)(6512007)(8936002)(558084003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VHJoenR6WUQrK09DK2MyZEZOdDJ4c3huVGJ6aXhpRlo0am9ENk1LSkpDWHdD?=
 =?utf-8?B?YVNXandGTmpmYytJRUF0QVpncFRGU2ZKT1ArNEg4am5sUWwyUmtsa1JhWW5h?=
 =?utf-8?B?QWp0WXlxWjRXVkI2QjIrS3ltL2gyMVhzZ2Q3K3FFRjBqMEs5ektXb0pMdVlr?=
 =?utf-8?B?bUwrMFBxZ1E1OE1PV1Yyb2Q3M01xTW00cXd4Vk1kN282dzViOXpvcm12MXRq?=
 =?utf-8?B?QnBFWXdDODRkOUtrNzg2cDVTakMvKzdzTTlzYkhBaHBOMEUrVlVETTBkcVJB?=
 =?utf-8?B?N2h1ckE5K25yMVRtTlNjc2hkUW1ZYjdtNjQrUzZDWXp0UU9tcWtZSHJmcWNE?=
 =?utf-8?B?c3FBUlJtbWp4dG0rNWtTaE4zUW5Qa2tRMFAxSDk4NmxPb3N0dVppNzNmcHJY?=
 =?utf-8?B?ZFNTMGhjRHFiM0NxRWxUNHhKOUhEYlJBekg1VVd4ZXhDZ0FnWGZlZTBDdFVN?=
 =?utf-8?B?amEyaXR4REtpQzY5MFU1SDhJSVNqRXVwNDIxRWhXUFJhd09QSlc0dzkwVElZ?=
 =?utf-8?B?QVJ2WWxrNE1PdUNYbUNPbjdubHdRb2pYT1BWVGhGUzBwRnkzUG54bm1XdDZy?=
 =?utf-8?B?ZkdEdWljbnFRUGpWNkxyMGJrV3lzR1g1Y3dXQkpWT3ZkWXlIYlRHeVA0SWdN?=
 =?utf-8?B?ZTlWbU5hK2ZQbk1KandlZDdyZmRBanRBZ09xNEs5VGN3b1RhaFRKUEFud1Vl?=
 =?utf-8?B?YVJZOW5CeW9RYWU0bVlyYXRhNWd2ZmxKNUw4TEYrUk1OVXdhUjFjZC9yV2FZ?=
 =?utf-8?B?SGRJU1lydGRnTDQ5UWJkRkNGU1VpUVZsVnlGaHZpcjdSdWdtaWVYZHhmT3Y5?=
 =?utf-8?B?c1M3S1ByMUNOT1YrM2E2Y3VUVUM4cWpKMDlxd1Fmd2crenhJVzdQOFVOYURp?=
 =?utf-8?B?V0xackxIUUE4bHdyaGIwcEFQTlBSbmtXT0hRSEE4RTZCMHVtUkJjUWI3ckZV?=
 =?utf-8?B?ZGxqb0U0L01KbU9GMW1qdElUTk1XcGdmV3RGQXJQT1FBZmtNZTE2Sjh1azNL?=
 =?utf-8?B?QlU2aDFnODUzVSszMUtGd25JUGFtME9DUjJnZTVXRnVKQWZ0bzJtVXlqc2NS?=
 =?utf-8?B?Sjd4THp2YVcrVlFwZ1dLcGtiRndvcUdCL2hqMjE5WmkzTkF1STZ1SUxad1Q2?=
 =?utf-8?B?cGNTSElRMHBxK0dmbUE5THVwa1FENTN0ODNTVXhITktmT09YY2JyYjh1ZXVp?=
 =?utf-8?B?eVplKy91Y3VsVlFuSi96MW4zejV2dW1tMk8ya25KSFZyL2tjVFEvWnBTN05s?=
 =?utf-8?B?WkV0Z0ZKRnFmWDRNS1pacGFDQjdBS0U3bVhyK3lKd3RhaFRwQkpjVE53aTB5?=
 =?utf-8?B?VTdJSVZ1WGwybVY5Z3MyRmFHR0pVUGpEbmNjcVJabmE1UngvMlNRSXUvTWEw?=
 =?utf-8?B?YVJKUS9RUTkyQUNBRTZqUlNycnpMUERRSWZ3SHRpelV5WDZqQ1FkeUZQakVB?=
 =?utf-8?B?YmgzbjNNeG5heDB4RURCelpqTmY0aVd6N2I2SnNSS0lvS1I3dmxYK24vNXdG?=
 =?utf-8?B?T09zTVNVWTBWblQ3WmVxUGZ6OHFXQUt5S3ZaeHIzTTdqeW1KNWtXTXRObHFT?=
 =?utf-8?B?ODRDRFFEMml1VHNIaU1SRnNqVE8xNnhwcmNacTZ6YVF1ZEZRTHR1emQ1RGFq?=
 =?utf-8?B?QTF4SGxrajRVcFdqZkRETkRkbTR6U3hxUWFaOFZOeS9lL2FubnNEOWNHMWxE?=
 =?utf-8?B?WlVrd2VEY0JKTHJ2eEJGUnVGRnJkQk45L3k4TFcvWEFDRW1OWXVFYzcvOXJH?=
 =?utf-8?B?dTFDTGVjeXROUEkySG9lY0M4YjM1M3NSYy9oS2N4L1VNR3B3Ym9rZ2FNTmZM?=
 =?utf-8?B?dzBlQkV3K01zK3J0TWRwWUdlQm9EamlrTGIwVjk0M0REdU5xbktoQ0Yydi8y?=
 =?utf-8?B?d1lTMy9ybnFlWHk4cHV4THp1OVQwZDBrOWJkTUVVOTJMckFPUkpwVEdpdXE3?=
 =?utf-8?B?VWhVRHEzZS9mQm5RVXp3S1hISTBXU1NiWndYSGhYSDBQeFJzOWtmWmVSbWxq?=
 =?utf-8?B?akJwbzlzditIbWc3ZUU3NTRjSHBvbzR4K095dnVxQ1MrSG5FWFFXY3luWUtR?=
 =?utf-8?B?NTd2U2JVQkNqVlU4SW0zRFNvNTlFVVA0ZVhGaVlhNVhCRC9sMnJIZXNjdkhN?=
 =?utf-8?Q?N8gewXzN+OIPHxl7VY2/KBHaf?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <10D855B40856C24786C4B46816C5BB2F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ca43385-1929-4284-940b-08daae0e59da
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 18:03:08.6149
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: do4lahdYgB1EvbC4004a8rKF7XWCgPUeVmibHEDgqSbFk2YQdaA6hg0IdRYxWUtyKldJnWqJ69+AOMZL6Hwq37R5wtPAbZHwprw6rXP0HNA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6642

T24gMTMvMTAvMjAyMiAxNDowNSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IFNpZ25lZC1vZmYt
Ynk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpJdCBvY2N1
cnMgdG8gbWUgdGhhdCB3aXRoIHRoaXMgc29ydGVkLCB0aGVyZSdzIG9ubHkgYSBzaW5nbGUgcmVt
YWluaW5nDQp1c2VyIG9mIGJ1aWxkbWFrZXZhcnMyZmlsZSwgYW5kIHRoYXQncyBmb3Igc3R1YmRv
bXBhdGguc2guwqAgSXQgd291bGQgYmUNCmdyZWF0IGlmIHdlIGNvdWxkIGNvbnZlcnQgdGhhdCBm
aW5hbCB1c2VyIHRvby4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 18:09:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 18:09:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423003.669459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojP88-0006QL-Lr; Fri, 14 Oct 2022 18:09:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423003.669459; Fri, 14 Oct 2022 18:09:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojP88-0006QE-JA; Fri, 14 Oct 2022 18:09:56 +0000
Received: by outflank-mailman (input) for mailman id 423003;
 Fri, 14 Oct 2022 18:09:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cdf0=2P=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ojP87-0005eS-AS
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 18:09:55 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66709368-4beb-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 20:09:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 19D1EB82356;
 Fri, 14 Oct 2022 18:09:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DA21C433C1;
 Fri, 14 Oct 2022 18:09:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66709368-4beb-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665770990;
	bh=XO5TiSWYMq7NjAj7dKmtww+z1k3itqzkGcU6pgxClM0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mcZLStp+f1oQDQKV20TouypDs5gfaooqg4ttNIIEBpmryRcFS3xVYaziKcHZ/1elt
	 X+AYLkT4KDafNxSCFb/iEf9ehxLiXnCt9Qur2Atv6s4/MWf7a1lwYEpuQqOXyaTO/d
	 Gf29TDMld6XTW+3TVWZMZiZ+6L9imwMq9Xyn61VNrNqqC+QYM1oGfYlNyAPJmjBisM
	 A6O4Xqo15WIcB7S9vccgAEu7R+hxd85hbopzhouMfK1bGsRACjhJXWb/OhYJI/me/X
	 YrpUMLtiH/Tw5hsZA9ez3JmwqDZBGfVQXDI3uG9VIStPPmrklWXv/DXZ3Syzjdp9h4
	 UeZKyUY6XgFxQ==
Date: Fri, 14 Oct 2022 11:09:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Ayan Kumar Halder <ayankuma@amd.com>
cc: Julien Grall <julien@xen.org>, 
    "Stabellini, Stefano" <stefano.stabellini@amd.com>, 
    bertrand Marquis <Bertrand.Marquis@arm.com>, 
    "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, 
    Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, 
    Jaxson Han <jaxson.han@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register)
 on Aarch32_v8r
In-Reply-To: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
> Hi Arm mantainers/Folks,
> 
> Please refer to the discussion
> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
> 
> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed virtual
> platform.
> 
> Zephyr is trying to read GICR_TYPER which is a 64 bit register using ldrd
> instruction.
> 
> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
> 0x9200000c.
> 
> As ISV is 0, so Xen cannot emulate this instruction.
> 
> The proposed solution is to use two sys_read32() on GICR_TYPER to return the
> lower and upper 32 bits.
> 
> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.

Hi all,

I wanted to take a step back on this issue before we jump into the
details.


Differently from other instructions we discussed in the past, strd and ldrd
are not deprecated and are not "unusual corner cases". There is no
statements such as "please don't use this" on the ARM ARM. If I were to
write an register read/write function in assembly for an RTOS, it would
be reasonable to use them.

So, I struggle to see how we'll be able to deal with all the possible
RTOSes out there that might have them in the code. We can fix Zephyr,
but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
etc.)?

Unless we can get ARM to issue a clear guidance that strd and ldrd are
deprecated, I think it would be better to attempt to decode them rather
than just fail. I don't like to have this kind of code in Xen, but I
don't see a way to support R52s without it.

That said, of course if Zephyr was to use two 32-bit reads instead of
one 64-bit read, it would be better for Xen. And we have more important
things to deal with right now in terms of R52 support (it is not even
upstream yet). So it is totally fine to change Zephyr and move forward
for now.

But medium term it doesn't seem to me that we can get away without a
solution in Xen for this (or a change in the ARM ARM).


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 18:16:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 18:16:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423064.669469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojPEY-0000KN-Br; Fri, 14 Oct 2022 18:16:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423064.669469; Fri, 14 Oct 2022 18:16:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojPEY-0000KG-9D; Fri, 14 Oct 2022 18:16:34 +0000
Received: by outflank-mailman (input) for mailman id 423064;
 Fri, 14 Oct 2022 18:16:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojPEX-0000KA-QS
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 18:16:33 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 538b1fe8-4bec-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 20:16:32 +0200 (CEST)
Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 14:16:29 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MW5PR03MB6880.namprd03.prod.outlook.com (2603:10b6:303:1ca::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 18:16:27 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 18:16:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 538b1fe8-4bec-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665771391;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=uIONNLrXBpAeoEaP+No6PhZbzwu4shbsAq2JsBllwwU=;
  b=EasAoRZasWBKwdoaRRMTmxZ4JhGzvN2JQyfikS5ie1qM97s73kqHy/sV
   /eB9XYBqN080B8yodkfLGV3ScN0MNVVOQq+m4MekvIihbCem0qm2DHxoV
   w8KqCwDoW92UJEdxfxUuFS/xTbN8zLYeUqTdojsQFoUWEb92+WzDjF7iR
   w=;
X-IronPort-RemoteIP: 104.47.66.48
X-IronPort-MID: 83187959
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:h+3oSqxTasGdesSa/Yd6t+fpxyrEfRIJ4+MujC+fZmUNrF6WrkVSy
 jdMD2GOafnZMzb8e9B0Odm+pE4P7ZHQy4cwGQU4/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB4gRiDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwvp8DGZI0
 fsiOiEETwmRpt6fmoOkRbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrswA/zyQouFTpGPPTdsaHWoN+mUGAq
 3id12/4HgsbJJqUzj/tHneE1rSWzXyqBdN6+LuQ59JW3nORlk8qFxwvZVHlvaiet1zgYocKQ
 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjxLZcEitcQ2bSc3z
 VLPlNTsbRRtrbmURHS15rqS6zSoNkA9NnQebCUJSQ8E5djLo4wpiB/LCNF5H8adkdndCTz2h
 TeQo0AWhboJitUQ/76m5l2BiDWpzqUlVSYw7wTTG2e6tAVwYdf/Y5TysQSLq/FdMIyeU1+N+
 mAenNST5/wPCpfLkzGRROIKH/ei4PPt3CDgvGOD1qIJr1yFk0NPt6gKiN2iDC+F6vo5RAI=
IronPort-HdrOrdr: A9a23:RP9Gi6NybBfppcBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+
 Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu
 UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+
 jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI
 SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
X-IronPort-AV: E=Sophos;i="5.95,185,1661832000"; 
   d="scan'208";a="83187959"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SlUKrPbsk+YijX+B+1ohxyctAmTR1TNlqc2YmWKw06JOeQnT7z6NNBYci4DPFOBQbE9cPS+G+jjliLBCNjCRR36SdCUmvie92qBULQVinaC/wdIIfN05czqbtfAHgm4aB2j1h8C49+uB/INFEh2tgH8qviFvL6gGSmsjGNggSsfbAGZgn8Yaii9/jOd3I+fherbN9JdJqp7+nh3J2X6GXybQU98AUyDaLFqRN9ijCbTtsIE1I3TKgodA4MAWkbDsqDaEEZ+EapRKR33IYQ3w4RMmKgOPqRykLz1DUPk2cxGOof5htxel+IRtdlkjaS6tKZRvqU0PoKAj0m6CZk5plw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uIONNLrXBpAeoEaP+No6PhZbzwu4shbsAq2JsBllwwU=;
 b=Uo4CQLyV/VUE+qEdKkuVi05ZDOq45B1NT7EcHJgFymZAKn+kh62Oc0+a5gEoYcofblA0qHWNTjpBsVeDaA3Ea/wrELltpdTakgHR4XPURebmBU9Wn7rE3qYZW13k7wEVmdM2Y+cQbvNmUwaHTimE2pvexLJlcV6DjEPiHH4I0hqH/HDWpPmrFU3QUZ9oUFUPFqmpHq6i1b9xFvqT2B4AGQZ2ILhxzLz7EOVMWKkkcpE3uW8jUzvb++VNMJjpgZb/J7WHdiyZ9kI8xBa3jQ/0pTZZEsCLD1gmr7nGrm+09aCHMr1Z5QzKat7v2Q4Zl9hVUlkjPUNZSR7bq4QlyYhaIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uIONNLrXBpAeoEaP+No6PhZbzwu4shbsAq2JsBllwwU=;
 b=Fdsg97PStZBoSIcTwI64COOklV5enSAx5vSMpbv+F8UH98f65QRPCxoP1MJn87EYjdwTHzTQNM4U+f2yF/1gBq10WnHuwVhcPdIWmp9wWX0VoUQ+gHYhOjx5D6TuvAN5RzAnp93W6b5lW3RsO2q0TszG5vD9/tzP2x26PlOZLm4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: George Dunlap <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH for-4.17 v5 10/17] libs: Fix auto-generation of
 version-script for unstable libs
Thread-Topic: [XEN PATCH for-4.17 v5 10/17] libs: Fix auto-generation of
 version-script for unstable libs
Thread-Index: AQHY3wSN2AAamVElMkOHboggsVYl7a4ONB2A
Date: Fri, 14 Oct 2022 18:16:27 +0000
Message-ID: <05589025-a3cd-8a8c-491e-089fd6d89c6c@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-11-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-11-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW5PR03MB6880:EE_
x-ms-office365-filtering-correlation-id: 8c484567-6a76-4ec2-5df5-08daae1035e5
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 r52INNKYPwduIzdtpaTaz5JXYlmGxEkpt4JuwzObHqyW4HYDP6nrTCguTMQlsDnAzn/C7v3y/M/pVmV4IzYD9x3SVmohrqyikJlxwo3vSt2Hxn9qbmxho/2NsUk1tYdtqbULD1ypobL4DIR6LTax8FXbDjm/Ifa+k1wuJDe4H1bKSlLuo9t9BtqHz4aGYRFrxi62D8AUsYGgvOEFLS9d+epDk9WBD7MMXo+R3t/q5i9g3/E63Hs+CT+KUn/TyXQMlvqy6B5Dtlo6FMo+DTL58y6BNUomokixCrQ64NKIfQ81ER3T67DmPuiMskSbfSLk5O/tRcs0J2ILDiOSwF8BrGKRF2cXmCpKm/+2r7JbUxZDiF0201RrCDrbKy3tezIL4EDi2ag0jlOPib2ZkDOe1t+pneWJZ1TpqIJknz/SKN084h8+BqiFQ8OxOv/tm5xLIM5DR7rFiLNmpqlJ/XgR57pEqaj/fyPuw/cq0yxr50dkRpvbj03XdLqInSxmwJcpZIeb+7ZVLzLGtApd7Y3CjebeIjjpWuOlZIDLPLQ7jkxWfvJqz8TUyQYfYTb8sBNgMAgV6+064ef/dp0JxCRMgimYZro8nuGcjPf6DIWmWVbBV9r3aYb8RtonsKDTIXY6vRiG4yh6zWpWesrBWkRrdUbIJsGUChWIwdBsZcOJ8K9Vo+6Qt2pz1f4WyjbXBQiOsnnzWBplrLEHALMzZjG1HrKswNncnP8JnTYcvev7O1RnYFiINfanQrXZ0U1t0fv+dlpUs6VV7HmhhJbPUvZ9SFvigPggsNUqUvh1DM0QZqbfeLky125ZS8PgDG1eaaQr+XDxEAw8qb7ZIuFCzl+sbg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(316002)(110136005)(478600001)(66899015)(54906003)(71200400001)(6486002)(76116006)(8676002)(64756008)(31686004)(91956017)(66946007)(66446008)(66556008)(4326008)(66476007)(83380400001)(8936002)(26005)(41300700001)(186003)(5660300002)(6506007)(2906002)(2616005)(38100700002)(6512007)(36756003)(38070700005)(82960400001)(31696002)(53546011)(122000001)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?b3BqbjMvWHBUUG1BLzIyMnZDc2VMamd4QkhGMFZyYkkyU21EMkxsQXAvUkVZ?=
 =?utf-8?B?b3dmVnJZaGk1aGlwU1h2OTljZGloYjN0T2h2QmUvR1BMNmJWQ0pPcTZYMnNj?=
 =?utf-8?B?aVFZVUdwMmZZSlliMUtPOVhaZWFoZkFDZFFkL3JUdmNGcEh4WmhlSXg4bzgx?=
 =?utf-8?B?MW1CTWtJTWp5Z3plTE80UlZtRmpsQ0tZNHFnbmNmQWZ3L1N0VHljdUNycG5r?=
 =?utf-8?B?WVU3Ykh6Wi9nb1lnLzUrM213eUNpRVJNTlZFSVlvZjZheEpjSEtzUWQyZzNu?=
 =?utf-8?B?WDhmUXczbGNNRHpENW94OHVZUzRSR3lsY2IxNUFmUVFPalRROEpFWk9IVUtO?=
 =?utf-8?B?eWR6Z0NLMitjUDZDRGd5Wk1Yd0xnWitSOFhkSFJrdUhieWtxWS9MdkFVWWVR?=
 =?utf-8?B?SmtBeVhScnhSMVg3dTdJL0VaYzFkMTl4V21Nc3VhWlo1K05hTllwNml2ak1u?=
 =?utf-8?B?TWdOZW9aWnd2T1QyS0xOOWhUZmNTWEtzdTNxOWx2TnpKK1phRWlnZElmUkEr?=
 =?utf-8?B?QVROU0RBUVRqcThsV2RuZU9MeWVUSHNpQkZEMGFpZVVOSnpJVmE4Ujh5S2s3?=
 =?utf-8?B?UC9DUnhSclBWRGVWb2NjODBzWDRLUXp2RVJLK3NaNXR4WWxLTE5MMWhNVUVz?=
 =?utf-8?B?cktxWlp3QjVHTGR0SWxMaWF5NEl0bFB4M0R2Q2JtTTMyWGZHNCtGNzJnZnZZ?=
 =?utf-8?B?Z1duaEZENEJaSEgxU3NvaXUzUEdCSW9xSFJvREFMcmRRVWNwOTJ2eFUvY2Jr?=
 =?utf-8?B?dTJLdWgzLzMwYTBhSlNVc2NtVSs1bW9Md05JNEhZVlhpSHlEM0U3V2U5WmdT?=
 =?utf-8?B?Y0dvOUdRb2Vob3JXa3F1S0JibkE5RmtpUTkrdW5Ta1k5bmQzNEpGZmxMOGQz?=
 =?utf-8?B?clVIU2g5VmswMmlPNVpneU55alJWRVR3KzdVNmNvcDNiOTVMeXhwMVlGdXZw?=
 =?utf-8?B?b1lVSk1wVlhiR2xVSFU4RmxRNkdwMnczdGJMeVFTNW11eVlkbGZ6RHp2MGgx?=
 =?utf-8?B?SGlEVHBTYlkyTHVwL240eW5kMUpVallFVmxHbWxOcXFtdmdQZ1dYanVodVFN?=
 =?utf-8?B?VGIxaGJSOFZDWERaWERTc0NBL3U4c2piZjRaSVdyT1ArVGQ2OGFFekRqZlFi?=
 =?utf-8?B?bDgxNHZvUVo3Tzk2VU5QaVRpcHc4dHJQUnRBV2hIalgxc202L2xFVjBHcEhC?=
 =?utf-8?B?eXh2OUVEZGlvczMzM2xqandjWWR0dGV4dXpYOUNvZHcvbzZBMXAxMEhvMnRR?=
 =?utf-8?B?ZTgzVEdGRUlJU2txR042SjZ0TllLTmthNC9TZWRWMUx0bEk1dVRYZDYrZ0Nz?=
 =?utf-8?B?L3doNTVMNCs1OVRKUHdpZW42RFpraDNpaEhuejhBWjhLTVFvdmJHTUZnc0Fj?=
 =?utf-8?B?d2xQZDd3cHIyK3dUUnVSSTVSUDBwVmZ0eXJiN2VoU3ZqWmZCUHcwRkUyQjdV?=
 =?utf-8?B?YWVFV1NBT05QQmcwZnBtSTk0V2pLWDRpaEZCQWN3c2QxeXQ3bFJRL3Q5SzFX?=
 =?utf-8?B?VXNkNXJVanJwZW5waERka0hXUCs4OWhOY1NGNXIzVjZsRHBZb3RpZm5MdXA0?=
 =?utf-8?B?K2JaMmVzd0VicjB2ZS81MEJ5N3RoZ2l2RHhyc3dHaE5kSkh0cGdramdPS1Nz?=
 =?utf-8?B?SDFxNEkyR1o3SVlpRE4rcHVHZUNtdDBYeSt0T3hsaFVOL0F3cERzaU1qWDZM?=
 =?utf-8?B?ck9LSm9Ib2NnMUxhc2IwTjZxRVJ2RGdiUzVrTWh4cnlrQjJDNHVnVG9Mak9Q?=
 =?utf-8?B?dCs0b1EwKzlMajVjY21zcXl5TVpwSS9HbkYxc05KQW9MOTJYUHBnSGhlRndW?=
 =?utf-8?B?NXBWSVJ3STAvb0FCT2s2aktFWjBZZStMYWZCOGNRVzZyWWlpaERlZTV2ay9O?=
 =?utf-8?B?VXM1RS9Icmk0UlBkU2M3WkoxcjB5TkpqYmJOUXdwWXJGMXRERVlLYWN6NEpC?=
 =?utf-8?B?VnVSeFhQTHl5Q2FWWkIxc2ZySXR0NkRJVll4NjNQa1lSakdOS1NIQ3RmaTRO?=
 =?utf-8?B?NE52aW03T2JlalpDQVFlNFY5MFhPNTM1eHphVkhvUmNiVnJjUE85TnRNTWwr?=
 =?utf-8?B?OE5keS9qUDd3MlJQeU8vTDJkY05qUmcyU1pkS3JFL3hIR3YxMGFja2hrSzFl?=
 =?utf-8?Q?Gg9HKTHIqsFMgwDuVMzfWVqi+?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E5036850BC80DC47A3FC5F5F6B238A90@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c484567-6a76-4ec2-5df5-08daae1035e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 18:16:27.2655
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ptd+m2Oa9I4ztZOCWifHje5rdLf8TOk/EuJ2OzOxALWSwb9ncEWLkbb9GIwFuWcU41BlL5XeINg3ae+VuluQpoPhu1gaA8paQV3XvQSQ37w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6880

T24gMTMvMTAvMjAyMiAxNDowNSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IFdoZW4gdGhlcmUg
aXNuJ3QgYSB2ZXJzaW9uLXNjcmlwdCBmb3IgYSBzaGFyZWQgbGlicmFyeSAobGlrZSBmb3INCj4g
dW5zdGFibGUgbGlicyksIHdlIGNyZWF0ZSBvbmUgYmFzZWQgb24gdGhlIGN1cnJlbnQgWGVuIHZl
cnNpb24uIEJ1dA0KPiB0aGF0IHZlcnNpb24tc2NyaXB0IGJlY2FtZSBvdXQtb2YtZGF0ZSBhcyBz
b29uIGFzIFhlbidzIHZlcnNpb24NCj4gY2hhbmdlcyBhbmQgbWFrZSBhcyBubyB3YXkgdG8gcmVn
ZW5lcmF0ZSB0aGUgdmVyc2lvbi1zY3JpcHQgb24NCj4gcmVidWlsZC4NCj4NCj4gSW4gb3JkZXIg
dG8gYWxsb3cgcmVnZW5lcmF0aW5nIHRoZSBzY3JpcHQsIHdlJ2xsIGhhdmUgYSBkaWZmZXJlbnQN
Cj4gZmlsZW5hbWUuIEluIG9yZGVyIHRvIGNoZWNrIGlmIHRoZSBjb250ZW50IGlzIHVwLXRvLWRh
dGUsIHdlJ2xsIGFsd2F5cw0KPiBnZW5lcmF0ZWQgaXQgYW5kIGNvbXBhcmUuDQo+DQo+IEJ1dCB3
ZSBhbHNvIG5lZWQgdG8ga25vdyBpZiB0aGVyZSdzIGFscmVhZHkgYW4gZXhpc3RpbmcgdmVyc2lv
biBzY3JpcHQNCj4gb3IgaWYgd2UgbmVlZCB0byBnZW5lcmF0ZSBvbmUsIGZvciB0aGF0IHdlIGlu
dHJvZHVjZSAkKHZlcnNpb24tc2NyaXB0KQ0KPiB0byBiZSB1c2VkIHRvIHBvaW50IHRvIHRoZSBw
YXRoIG9mIHRoZSBleGlzdGluZyBzY3JpcHQuIChHdWVzc2luZyBpZiBhDQo+IHZlcnNpb24gc2Ny
aXB0IGV4aXN0IGZvciBhIHN0YWJsZSBsaWJyYXJ5IHdpdGggZm9yIGV4YW1wbGUgJCh3aWxkY2Fy
ZCkNCj4gd29uJ3Qgd29yayBhcyBhIGZpbGUgd2lsbCBleGlzdCB3aGVuIGJ1aWxkaW5nIHRoZSBs
aWJyYXJ5IHdpdGhvdXQgdGhpcw0KPiBwYXRjaC4pDQo+DQo+IFdlIGRvbid0IG5lZWQgdGhlIHZl
cnNpb24tc2NyaXB0IHVubGVzcyB3ZSBhcmUgbWFraW5nIHRoZSBzaGFyZWQNCj4gbGlicmFyeSBz
byBpdCBpcyByZW1vdmVkIGZyb20gdGhlICJhbGwiIHRhcmdldC4NCj4NCj4gU2lnbmVkLW9mZi1i
eTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQo+IC0tLQ0KPg0K
PiBBbHRlcm5hdGl2ZWx5LCB3ZSBjb3VsZCByZW1vdmUgdGhlIG5lZWQgZm9yIHRvIGdlbmVyYXRl
IGENCj4gdmVyc2lvbi1zY3JpcHQsIGJ1dCB0aGF0IHdvdWxkIG1lYW4gdGhlIGV4cG9ydGVkIHN5
bWJvbHMgd29uJ3QgaGF2ZSBhDQo+IHZlcnNpb24gYW55bW9yZSAobGlrZSBiZWZvcmUsIGEgZmV3
IHZlcnNpb25zIG9mIFhlbiBhZ28pLiBPciwgd2UgY291bGQNCj4gdXNlIC0tZGVmYXVsdC1zeW12
ZXIsIGJ1dCB0aGUgc3ltYm9sZWQgd291bGQgYmUgdmVyc2lvbm5lZCB3aXRoIHRoZQ0KPiBzb25h
bWUgKGUuZy4gImxpYnhlbmN0cmwuc28uNC4xNi4wIikgaW5zdGVhZCBvZiAiVkVSU180LjE2LjAi
Lg0KDQpJdCB0dXJucyBvdXQgdGhhdCB0aGUgdXNlIG9mIFZFUlNfKiBldmVyeXdoZXJlIGlzIGJ1
Z2d5LsKgIFdlIHNob3VsZCBoYXZlDQpoYWQgJ1hFTiRGT08nIGluIHRoZSBzb25hbWUgZm9yIGxp
YnJhcmllcy7CoCBCdXQgaXQncyB0b28gbGF0ZSBmb3IgdGhlDQpzdGFibGUgb25lcy4NCg0KQXMg
ZmFyIGFzIHRoZSB1bnN0YWJsZSBsaWJyYXJpZXMgZ28sIGl0IHJlYWxseSBkb2Vzbid0IG1hdHRl
ci7CoCBUaGUgb25seQ0KdGhpbmcgd2UgY2FyZSBhYm91dCAocmlnaHRseSBvciB3cm9uZ2x5KSBp
cyB0aGF0IHlvdSBjYW4ndCBtaXN0YWtlIHRoZQ0KbGlicmFyaWVzIGZyb20gZGlmZmVyZW50IHZl
cnNpb25zIG9mIFhlbi4NCg0KLS1kZWZhdWx0LXN5bXZlciBzb3VuZHMgbGlrZSBpdCB3b3VsZCBi
ZSBpZGVhbCwgYW5kIGF2b2lkIHdyaXRpbmcgb3V0DQp0ZW1wb3JhcnkgdmVyc2lvbiBzY3JpcHRz
Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 19:23:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 19:23:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423078.669499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojQH8-0007kT-Li; Fri, 14 Oct 2022 19:23:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423078.669499; Fri, 14 Oct 2022 19:23:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojQH8-0007kM-In; Fri, 14 Oct 2022 19:23:18 +0000
Received: by outflank-mailman (input) for mailman id 423078;
 Fri, 14 Oct 2022 19:23:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bPLM=2P=amd.com=Stewart.Hildebrand@srs-se1.protection.inumbo.net>)
 id 1ojQH6-0007kG-AS
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 19:23:16 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2050.outbound.protection.outlook.com [40.107.223.50])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4d32d7b-4bf5-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 21:23:13 +0200 (CEST)
Received: from DM6PR02CA0068.namprd02.prod.outlook.com (2603:10b6:5:177::45)
 by PH7PR12MB6441.namprd12.prod.outlook.com (2603:10b6:510:1fb::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Fri, 14 Oct
 2022 19:23:09 +0000
Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:177:cafe::9f) by DM6PR02CA0068.outlook.office365.com
 (2603:10b6:5:177::45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Fri, 14 Oct 2022 19:23:08 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 19:23:08 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 14:23:07 -0500
Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Fri, 14 Oct 2022 14:23:06 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4d32d7b-4bf5-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K+BRjNjFNa/JbaApXBrLlKjSTWm6MWFC589x/OtVVos9cg26QiScuuF8Vx3/qRGnmjjkpqRih/eyRsQRLwTuNJe9xUCd0ZYB2b7Jo5XwpGINW9PBVb3ynyopWAXNArc2T7eWhh8JV1+8+bKZ6oODpXfxuSPSJLcKTXqQUqlv/YpqpIVOfIt0f0oPzPdIuoQvdE77cxCkch+RgkDoQLQw/NNbia9SpTD0Ekw4Bs0UfnaP/HnCcwtV0mBnozrtgUNga7OLxnTXGtScYDxKGKLkLrlwEq8OVn8UDktwiWD8J0K5muM7hqT8SLfIS/LxqD/LXjwWAJr8iEIUcM38sbR48w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=68HpaOmUzeR4ND0qN+hUef0LVVc5NazVcmHrSQKZrew=;
 b=VgoQkD+V+cWNTN5vhARK3HKAJj874JjEEWb1VevAGdKl6AoQ6Z+4JjiFITdSlUGoUzpb0GFdYw1mgTFlyp0Ja722Z+DgOM8u9uomu+v6wWcLi7dwQwzLipu/KmJ4MlTg3HCt0KzMSkuCln84v4VwX0EU9dJWvTaa311macQI+5RCwN/i6JHkqTFBYyqilNqlEfZNp0ndBSQ6noI9TopOnwVG7Q91r36kznzcS6gz+6XJj+rt1EG/WkeFz0w0x6YekNQM0rgyUY5PlGLJyY1/7RmLMg2HdtMCGIPN34+ZR8PkhQYxgzJ5sVpkrCXhBIpbyKf7ynBLoXrAphaEh9JFBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=68HpaOmUzeR4ND0qN+hUef0LVVc5NazVcmHrSQKZrew=;
 b=2FP1SuiT3MvM95w5tMH2tizUlViptaPHYxNy21CgUk0FjMSZGCF25p5WvHeiKTZhWESDIXzw9xLQRxjJrYJTvUG39ijZlWYrlaY6A5C2kyc3IegHakbmxCNjRy4fDT2Zj4+FB3p0h+kGlJPTtN61KOAbPtobQbmrKPe2eKO2/1s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <728f2beb-dc28-9140-0fec-0a67bc49f3f4@amd.com>
Date: Fri, 14 Oct 2022 15:23:05 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Henry Wang <Henry.Wang@arm.com>, <xen-devel@lists.xenproject.org>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <0ade954c-5741-754c-fc59-177feb67ddf4@suse.com>
 <5f985e76-e817-5d44-3463-ffc0a98c407c@xen.org>
From: Stewart Hildebrand <stewart.hildebrand@amd.com>
In-Reply-To: <5f985e76-e817-5d44-3463-ffc0a98c407c@xen.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|PH7PR12MB6441:EE_
X-MS-Office365-Filtering-Correlation-Id: 05e152c5-c590-4305-bd98-08daae1986ad
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Fs/qxZVH47WK1AMWXownBfwgZbuDUwp994MDyY5nzF9+RdS+6SLaqZZXQXjKYCbfztmGI+r5ks5+GfSxwPjsDqARdoAMlBlleqS3+0a1tB5WD3Ur2yijT1Dn9IrP/DBo+39eyAmnrX03sPiai/NmK7EMzNAQ/YcY3gc+/gS8X2YrmT8AB22saUq5JOv0hxV1rZOvflbYqHcT/+jROrWQJ9mncHi3eDstDBw9ZKSkZBCPF3bRkf+2mWTatRI5xvxuuMc5fEguhpVKYgovlksDH1OvQqWksub2mmSCDqX8rJWV8yXvQvDX4BOvl9FYgtO4fiLkUJKnCorz/6cFZFkNnwxgVyAz/0Wt/qv8UzRPloOddHPoLq+rgFM6KfbNv2eEFn/pOT+IyNZmgSvmCcTi9jvT7RC2agd6IqaFd4FpV6n2Be3iqm5FYrTiM5V3V5xoGtZcmZwfBtcVnyK7Wwhwy+OhJj+0kaKH4SyHOXwe7x6ZKomvBo1AFOmpadOPAzNzCorXMIfoZvQRriDw08dOMvvssvvOFOAyXqZ6quZcbXsKupAoFyXCzWSZ2coCMgqPZyTElJz2r8N+R9Enf3D9a3UuXkEqWc9eCEGlT3jSntXxlx/fZiTk1GK9qIBI4WG1jSP2pDmexQ18EyMvfMBM151nLBkB4p4dOHvff7hv/wqynnOSdODO3prj9nQ4f4kdByUJszF32guSgCha9zf+e+6Gut/Tp/IoOsWdX/l3AhnvE/THwQegfe05CvLSNxl6BpmDOFVY4gzZI8UfmtkUplxZotopAK2gxeGg/0HsWj3/fygI08w/f6vZQ61GDETGSqm/UAiMtbXMpYqtFaLT7BfwJZdDt2fyjv4C6mqXRhislC4qujkEif6MYu5nOfIX
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(53546011)(26005)(31686004)(40460700003)(356005)(36860700001)(4326008)(82740400003)(316002)(81166007)(70206006)(16576012)(31696002)(36756003)(2616005)(86362001)(41300700001)(40480700001)(70586007)(8676002)(8936002)(47076005)(186003)(82310400005)(83380400001)(54906003)(2906002)(478600001)(966005)(44832011)(5660300002)(336012)(426003)(110136005)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 19:23:08.2513
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 05e152c5-c590-4305-bd98-08daae1986ad
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT069.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6441

On 10/14/22 04:22, Julien Grall wrote:
> Hi,
>
> On 14/10/2022 08:16, Jan Beulich wrote:
>> On 14.10.2022 04:53, Stewart Hildebrand wrote:
>>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
>>
>> I guess a non-empty description and a Fixes: tag would be nice.

Okay, I will send a v2 with the following description:
All functions in domain_build.c should be marked __init. This was 
spotted when building the hypervisor with -Og.

Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

> +1. I am actually quite interested to understand how this was spotted.
>
> The build system should check that any function/data in domain_build.c
> are part of the __init section. So I guess the compiler you are using
> doesn't inline the function?
>
> If so, I am actually surprised you are the first one spotted this... We
> are building on various distribution without any issues (?). I would be
> interested to know the compiler version and maybe we could add it in the
> CI.

I added -Og to the make command line so it takes precedence over the 
default -O1/-O2:

$ make EXTRA_CFLAGS_XEN_CORE="-Og" XEN_TARGET_ARCH=arm64 
CROSS_COMPILE=aarch64-none-linux-gnu- dist-xen -j $(nproc)

Indeed, I did observe the build error:
Error: size of arch/arm/domain_build.o:.text is 0x00000008

I used this rune to reveal the culprit:

$ aarch64-none-linux-gnu-objdump -d xen/arch/arm/domain_build.o | head

xen/arch/arm/domain_build.o:     file format elf64-littleaarch64


Disassembly of section .text:

0000000000000000 <handle_linux_pci_domain>:
     0:   52800000        mov     w0, #0x0                        // #0
     4:   d65f03c0        ret

I am using this toolchain: 
https://developer.arm.com/-/media/Files/downloads/gnu/11.3.rel1/binrel/arm-gnu-toolchain-11.3.rel1-x86_64-aarch64-none-linux-gnu.tar.xz

Further, there were two more build errors observed when building with -Og:
arch/arm/domain_build.c: In function ‘make_cpus_node’:
arch/arm/domain_build.c:2013:12: error: ‘clock_valid’ may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
  2013 |         if ( clock_valid )
       |            ^

arch/arm/efi/boot.c: In function ‘efi_start’:
arch/arm/efi/boot.c:1464:9: error: ‘argc’ may be used uninitialized in 
this function [-Werror=maybe-uninitialized]
  1464 |         efi_arch_handle_cmdline(argc ? *argv : NULL, options, 
name.s);
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I assume these uninitialized use errors can simply be fixed by 
initializing the respective variables to false/0, but a second opinion 
would certainly be helpful.


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 19:35:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 19:35:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423086.669516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojQT9-0000xn-RV; Fri, 14 Oct 2022 19:35:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423086.669516; Fri, 14 Oct 2022 19:35:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojQT9-0000xg-Ok; Fri, 14 Oct 2022 19:35:43 +0000
Received: by outflank-mailman (input) for mailman id 423086;
 Fri, 14 Oct 2022 19:35:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JttC=2P=citrix.com=prvs=279f68966=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ojQT8-0000xV-I5
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 19:35:42 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61926fd9-4bf7-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 21:35:40 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 14 Oct 2022 15:35:24 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5040.namprd03.prod.outlook.com (2603:10b6:208:1a2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct
 2022 19:35:21 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022
 19:35:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61926fd9-4bf7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665776140;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=lvyclAa417B571VbYbZTVvqoRQ47YJifB9NMzfX9DK8=;
  b=h3ge4Y6+GFitKyZiU1LxHVC6NLazzRNaLR00q2JcWdSSBEK1E7VCg6NQ
   Xe2kA7WLTE2O1DUeF+MvMD+KoyQqGLf9VPBn42fTTGWm6M0J72yx0f+MX
   6P+t4x6za97kOOWCpfAshTGeAwBpCMBSpwtbpUjoS0Ca+p1iHEQsPoPKM
   s=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 83192730
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:PDVjOqMlGK/uyGbvrR2ClsFynXyQoLVcMsEvi/4bfWQNrUoq1jFTz
 GIXDGnSOq6MMGCke4h1Po3g/B4Avp7SndQyQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr5GtE1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eIYkb3rdOPkh1x
 e1bAxs3Tjqfobq0z+fuIgVsrpxLwMjDGqo64ygl5xeJSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF+BTM+/tfD2v7lWSd1JDENtbPd8PMbsJShkuC/
 UrN/njjAwFcP9uaodaA2iL3376VwnijMG4UPLag1v9Qg2+w/GAoDAxMVl+YrsbhrlHrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAbShZRZdpgs9U5LRQo2
 UWOhMjBHiF0vfueTnf1y1uPhTa7OCxQJ2lSYyYBFFIB+4O6/tB1iQ/TRNF+FqLzlsfyBTz73
 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxlolDGJ5T+REMWTm0Ms=
IronPort-HdrOrdr: A9a23:F7M+iKzVZcmTIqns0godKrPxj+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD
 AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo
 SOBK4=
X-IronPort-AV: E=Sophos;i="5.95,185,1661832000"; 
   d="scan'208";a="83192730"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bWh4hsNodgBipeaD4puDzowQlDzIpx3iZ22wrlKoW5WXOv6mfGnt2WQV3G9oxLW5TnxdHm6bd8mpMr4KFMoy3K84mQZaYwlO3vZOofvwb+mcUih0vFOttMe60CLtdOKhwiv4mFJx+52HMZQBMk1iThym1XygrMbXUTc9swwjQctQZIk/TGAYIajCtbWYLO7UjUsF0MpkFT8HHDxDVXquR3u5lfSkVfzu9KiPP/eBOLzgtHAxGadf9aatzQ5woy+j0cLEYas89aTTUec9gNV61bVnkEFaRygJzWWDNjU6ieLstUlP6oGfwSL2MiwkQqN668E+RrcYTbXNfPyT8c/+Zw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lvyclAa417B571VbYbZTVvqoRQ47YJifB9NMzfX9DK8=;
 b=LxmeKlPNqc32q7TrCrQbbS8QD8p541M4mpNdz4ViyS8HkIKSTPUZYDLYsVB4K9jCBNVmLjjVztMqxf/uMNwo8ZKV3fIKbplJILtqilKt7i7sMTNBBvAbzprQa+ZtvNnuMGPDoLT6UYa+MaCOLPXKos+d8KIAr790uEDIRiN30u2tKOUszaadkuIHUEUj6GFfOnCmEKVGMqRwtNfXTLcxbtGPvPwDbtJd6PrFQxhzhPJ90BJZkJhirnDM20B/yDlFAbXICTlbx+oaGBjESVO2CPH9fBFgh5S+wkcvty77EjnqPOlLGAcY7sL/c0r1bQEQHgg8xscJkwhgyUMVGxVWKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lvyclAa417B571VbYbZTVvqoRQ47YJifB9NMzfX9DK8=;
 b=ISzj4/8KnsaGyu8dG5cYxr3BEHhgIqK0atRUPp7pbz5a07NJqKH5VLEyL3+iZWrwTCa5F/UDQZf7XO3cMC01WluIqpxMxOSoFa5QtwHeOqcD5TwU+P5HuNMSgH1SDcHC6jJbjZm+ntXKgW1dJh5HKPMAN1hXHyyQviTWx9CiwFg=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets
 prerequisites
Thread-Topic: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets
 prerequisites
Thread-Index: AQHY3wX69onYif2p90CqYm9dW0vHXa4OSiQA
Date: Fri, 14 Oct 2022 19:35:20 +0000
Message-ID: <d6e4825f-6fd3-b48b-7a7b-e4f62acadd38@citrix.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-15-anthony.perard@citrix.com>
In-Reply-To: <20221013130513.52440-15-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5040:EE_
x-ms-office365-filtering-correlation-id: 8391b82d-47bf-456b-eee2-08daae1b3ba1
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 aQiWKlzCl3aSPyAmdZR/cO0+mygQb7efjmP46Cbph+Wxt01Dao9IopPwkLgvgkWS6AffDfJPF3ScoFKpGsV6TMM1gWBgTYTQZXF3Fkhgl0z/pPEb8uE9bVQGHn0KZm8riBgHMGlbyEaw6xmG7T2zGgiVnxBeEUiKR6tq7jntIfLlKOzYKSWxt4pgoaoLRdvNPqPRfQm6RUp2afl0VeufeEu7v9h30cMRZAWJk4YxkK1hL6WwVgukFSFM4TIqo3z4Nxvaypkntlljv8neIXQsPJ/P24cL5A0F07QN1GzxmPX5P7hm4Fun+IFH4y/hbVKhkfTbDApGG6Zo3mWgawrqt6n7oWv4IsXDMcEuBkouckJ2c7H97zVyveC2WYxB8qelME8r2KeFYD6vVEYpH4NMwmkgcY9UnL7gagj4Q2jqJT7rD+NJ6Z6RiZ0FiX6VUZeMNXWIewT1SkLik0kU8FCIcvfApIACAL0M0lN3Ib1xcDrk6Hz64+DWKEx8hnzQm7UTookEX97m+OBmVUPI+qLaOfOlTyD7Klw3/VWxwIwZmABFNRZxtWUmcW3w6kOe+BGdOn50q7bEi4eFbtjamdo3sGL8wnhrqgJneOITY1m6KsRE/aRpGBcieeNFrx8ArGf/0DGIHiM+EJztG6vdklnSz256WG8IHD0ie05KUyjn0AjRVLzaw9Utzr1xHO4vmKq5VOISrfm4Ph65EbVJdZcFzNpqLMBNcefFJKW/VST8WSnmWkQcVcvcaU8vJgoxVfdyg2nM0Io555b6mSJXiOWH/Mm8csRKcKTI5ZP+MRFin3dnuzDjTXxY4fAY4oBApZRjxIvokf1u8ejMhP0+xj3cTg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(366004)(451199015)(6506007)(6512007)(2616005)(53546011)(26005)(478600001)(6486002)(71200400001)(82960400001)(122000001)(38100700002)(86362001)(31696002)(38070700005)(83380400001)(36756003)(186003)(5660300002)(76116006)(8936002)(31686004)(2906002)(8676002)(66446008)(66476007)(66556008)(66946007)(91956017)(4326008)(54906003)(110136005)(316002)(64756008)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Zk5ybE5BalkvZGZ2Q2Q2OWI3K3FhTlNMK1JZMXM0M3g5L1RwaEg0TE5XYzlF?=
 =?utf-8?B?NGg4d09XK0ZxaEhRK0lFazZvTTNDMXB2SkJYeUdWL3l3LzNyOXE0SDQzbmZC?=
 =?utf-8?B?dHZ2TC9BOFBiQ0VKV2lXUDlidnJTQ3A2TnFOZ0ltZG44VWdTRkx4WVhqVXBX?=
 =?utf-8?B?b2RxNVBsZ1Vsc3lxQjJ4T2YwTytiR2tYbFpYZG1pSTl5OVBZck4xZGVqVVYw?=
 =?utf-8?B?TUExNmlqejRZa01yRlhaa2FUcGlTVEU2bFNJUTZRUnJ6M3lPdVpmbEZTV3Zk?=
 =?utf-8?B?ck1ZYVVuR0krbXpHa1NEVmpheHhqeU94V0tyMXMzZXdUalkyak04bkxOOGNS?=
 =?utf-8?B?K1BVT2tHY21qL0hzcTJubWZWTWlrM2V0OGVEeUVWdlh1RnBjbkdYM0Z4YU94?=
 =?utf-8?B?Y2l0UzNjVWtDOVZGaElPR21TNkJEOW1Ja0kyOE9CTHhKdFN3ZU1Ta3lDZkx4?=
 =?utf-8?B?b2toTFpYT005NHVJeGVMZEJSY3BXWmNDazVYeWJ3T2JIVENKdWJlb0I1a3ZB?=
 =?utf-8?B?czN1cUFaQ3hiOUh3V0ZwR0VtVjNsdS9TQkpXUUg2R0lWbXdIMFU5TmF6WW9G?=
 =?utf-8?B?emVYYyswVjRYNHJZZ1NUelJYdnl1dzRPMC83cDR0NGh6b0p3Zi8yWC9GMnRF?=
 =?utf-8?B?MnprcWJ0KzNUTVc0VTFiT1VoTkJvQmlwbjRDYndTREE0TGJwUndBdzhienox?=
 =?utf-8?B?VllacmJHZktLeCtieVJIcDlFMVFqWVdRMXRsN21zRFdIUnZIeHBpc29sV2NR?=
 =?utf-8?B?dlkycUtCVVVlNFJsZWhJMlJIdGdFQ0JKNXpFYmJrQ1BtdTlKWk1BNVk4bk16?=
 =?utf-8?B?TDBmVXB4eHpPTUZudlp1dlVHR3JjTStyUnNhS0JMUHRld0lqLzN0MEg3U2tX?=
 =?utf-8?B?aFljRzROZTFZbHUwVmdmOGtnOTJxSWZ0REk0WlYzS2pqZ0MrQ296NERTR1Ja?=
 =?utf-8?B?Q3hvQWVnZzlVUmt3N2YzTkRITFkwMGNsdTVvSENDL1kxR1AvVnBIWUtKclBy?=
 =?utf-8?B?WitHeldPWDlzbllWVTBKUFpFQ3luZVNuZld4bjlhbWlqL0pwbmRaczVlNU90?=
 =?utf-8?B?TGw1dS9GSUhMWC8vdjVXNFZCME85NStrNThDeTZjeVhyV1ZoSk9mSnljby93?=
 =?utf-8?B?WklGSTFneEtSeEhLTVFneFBYb0xiZ2c2TVFPckxVY0VJY0hVQlVTQmFjOVRF?=
 =?utf-8?B?SXVKbzlTWHJnSENrenVsK29rRTJrN1BzcHlQRFhsRkVMRUp0dkx3Tmx4K1RL?=
 =?utf-8?B?b1hkT3h0eXZyd3NwRmV1OHc2UGRjUWN2SHJ6VUpGc080U3F6dE9NYUIyN0Ey?=
 =?utf-8?B?a1BHU0l2OWREdlBnazE3dS9SNXQ4czV2VUJjOWNyZTVURVE0Z2FZUFNiT0tv?=
 =?utf-8?B?c2xqQTBLQmRFSGViMkdmeG1kbjJXaHljVXIwWDZ0SENUVGhXTlk4anhGWFh1?=
 =?utf-8?B?SGhIYzFPVVRvd0YvdXcrSWhscEdab0ZULzFLZ1VXTkJMNlJBNTNaV2tSRTd3?=
 =?utf-8?B?M2tleXI0NSs5YXh0alFTQUtheFovYjZXdVhDYWFySjAvYU1DU3ZhNGl1MEpN?=
 =?utf-8?B?WTM1K240cGE2Y0xmeGhHTFZXRFZXa29nSmpHbW1XR3JyeElGbXFwNmd3T0dy?=
 =?utf-8?B?bnZ1TzZaUVcwUXBrK2FiTFRTTFgrbW5Ddlk0WlVuT1dLZEVVWEVFeW43MnE0?=
 =?utf-8?B?ZDgvdWxIOUdNWCtsTzhGSTJKeTBrOVAxSWRETG43Q3R4UXYwSnlmaWpXZHFu?=
 =?utf-8?B?eG1KU1Bya2tEbEFDd2tpbG1Yd2FoNjkxRWFFQ25TbkkxUnBOVUJpbTN5cWs4?=
 =?utf-8?B?ZEFNcmI0ZDVtbDVvTDBIUHJkYW9XWFFOY2pSRkc2WHhpNlcrV3NEbW9iVi85?=
 =?utf-8?B?Vk1PSXRIMHdJVmlpa2Vta2o4VTg5NXFKRTIwaHpXQWwvY0FxN0VucGhTZXpa?=
 =?utf-8?B?ejFPVkN5OFRoVmh4Vk9RMHVBaVdlMmxmN2FmU3dpMmFWaDRiRTNSUE85RHh6?=
 =?utf-8?B?L1lMdWNZcVRhOERMNWJvdVgyMjR6cTlrQ3hVOFlQVDBCTW85MGpvSTdrbmk2?=
 =?utf-8?B?VHVtTkRGU0hzV2srbTRSNk1nY1krMUQzVTg4WUUwb3BBaUNqcDJreHg5dXVt?=
 =?utf-8?Q?oLBznjiAjb35pH6nwcHmbCTKy?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3FFBA34DC1D38A43B6194D859DFEDED4@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8391b82d-47bf-456b-eee2-08daae1b3ba1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 19:35:21.3539
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: khbLhujiltZ7MnxSWnwdZCUgMl0YOc+auMM8i/LZvHS+SC3lV7dQdDz1jQXQYhiPEVqDJxORF6HaexHhHsHpG6Ko8vPZVgp3FUA/lrpjR7w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5040

T24gMTMvMTAvMjAyMiAxNDowNSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IE5vIG5lZWQgZm9y
ICQoQVVUT1NSQ1MpLCBHTlUgbWFrZSBjYW4gZ2VuZXJhdGUgdGhlbSBhcyBuZWVkZWQgd2hlbg0K
PiB0cnlpbmcgdG8gYnVpbGQgdGhlbSBhcyBuZWVkZWQgd2hlbiB0cnlpbmcgdG8gYnVpbGQgdGhl
IG9iamVjdC4gQWxzbywNCj4gdGhvc2UgdHdvIEFVVE9TUkNTIGRvbid0IG5lZWQgdG8gYmUgYSBw
cmVyZXF1aXNpdGUgb2YgImFsbCIuIEFzIGZvcg0KPiB0aGUgImNsZWFuIiB0YXJnZXQsIHRob3Nl
IHR3byBmaWxlcyBhcmUgYWxyZWFkeSByZW1vdmVkIHZpYSAiXyouYyIuDQo+DQo+IFdlIGRvbid0
IG5lZWQgJChBVVRPSU5DUykgZWl0aGVyOg0KPiAtIEFzIGZvciBib3RoIF9saWJ4bF9zYXZtX21z
Z3MqLmggaGVhZGVycywgd2UgYXJlIGFkZGluZyBtb3JlDQo+ICAgc2VsZWN0aXZlIGRlcGVuZGVu
Y2llcyBzbyB0aGUgaGVhZGVycyB3aWxsIHN0aWxsIGJlIGdlbmVyYXRlZCBhcw0KPiAgIG5lZWRl
ZC4NCj4gLSAiY2xlYW4iIHJ1bGUgYWxyZWFkeSBkZWxldGUgdGhlIF8qLmggZmlsZXMsIHNvIEFV
VE9JTkNTIGFyZW4ndCBuZWVkZWQNCj4gICB0aGVyZS4NCj4NCj4gImxpYnhsX2ludGVybmFsX2pz
b24uaCIgZG9lc24ndCBzZWVtcyB0byBoYXZlIGV2ZXIgZXhpc3RlZCwgc28gdGhlDQo+IGRlcGVu
ZGVuY3kgaXMgcmVtb3ZlZC4NCj4NCj4gQWRkIGZldyBwcmVyZXF1aXNpdGUgZm9yICJsaWJ4bF9p
bnRlcm5hbC5oIiBzbyBhbGwgaGVhZGVycyB0aGF0IGl0DQo+IGRlcGVuZHMgb24gc2hvdWxkIGJl
IGdlbmVyYXRlZC4gQW5kIGhhdmUgJChTQVZFX0hFTFBFUl9PQkpTKSBkZXBlbmRzDQo+IG9uICJs
aWJ4bF9pbnRlcm5hbC5oIi4NCj4NCj4gUmV3b3JrIG9iamVjdHMgcHJlcmVxdWlzaXRlcywgdG8g
aGF2ZSB0aGVtIGRlcGVuZGVudHMgb24gZWl0aGVyDQo+ICJsaWJ4bC5oIiBvciAibGlieGxfaW50
ZXJuYWwuaCIuICJsaWJ4bC5oIiBpcyBub3Qgbm9ybWFsbHkgaW5jbHVkZWQNCj4gZGlyZWN0bHkg
aW4gdGhlIHNvdXJjZSBjb2RlIGFzICJsaWJ4bF9pbnRlcm5hbC5oIiBpcyB1c2VkIGluc3RlYWQu
IEJ1dA0KPiB3ZSBhcmUgYWRkaW5nICJsaWJ4bC5oIiBhcyBwcmVyZXF1aXNpdGUgb2YgImxpYnhs
X2ludGVybmFsLmgiLCBzbw0KPiBnZW5lcmF0ZWQgaGVhZGVycyB3aWxsIHN0aWxsIGJlIGdlbmVy
YXRlZCBhcyBuZWVkZWQuDQo+DQo+ICJ0ZXN0aWRsLmMiIGRvZXNuJ3QgZGVwZW5kcyBvbiAibGli
eGwuaCIgYnV0ICJ0ZXN0aWRsLm8iIGRvZXMuDQoNCkknbSBhZnJhaWQgSSBkb24ndCBmb2xsb3cg
aGVyZS7CoCBIb3cgY2FuIHRoaXMgYmUgdHJ1ZT8NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 20:10:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 20:10:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423096.669539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojR0x-0005Pi-NY; Fri, 14 Oct 2022 20:10:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423096.669539; Fri, 14 Oct 2022 20:10:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojR0x-0005Pb-Jg; Fri, 14 Oct 2022 20:10:39 +0000
Received: by outflank-mailman (input) for mailman id 423096;
 Fri, 14 Oct 2022 20:10:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bPLM=2P=amd.com=Stewart.Hildebrand@srs-se1.protection.inumbo.net>)
 id 1ojR0w-0005PV-Hr
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 20:10:38 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 431a2249-4bfc-11ed-91b4-6bf2151ebd3b;
 Fri, 14 Oct 2022 22:10:36 +0200 (CEST)
Received: from BN9PR03CA0295.namprd03.prod.outlook.com (2603:10b6:408:f5::30)
 by MN2PR12MB4206.namprd12.prod.outlook.com (2603:10b6:208:1d5::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct
 2022 20:10:33 +0000
Received: from BN8NAM11FT054.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:f5:cafe::b0) by BN9PR03CA0295.outlook.office365.com
 (2603:10b6:408:f5::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Fri, 14 Oct 2022 20:10:33 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT054.mail.protection.outlook.com (10.13.177.102) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 20:10:32 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 15:10:32 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 15:10:31 -0500
Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Fri, 14 Oct 2022 15:10:29 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 431a2249-4bfc-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bl4dkVEeo4/PvqwfzBVUPz/7e/2LmbPZ4PU+mtZzxMMpoORI6yhg+TYo9wnsnVN9qk5bZIxjbjXiwUq8HXV8pkMfe20ZY6fC9xkdwMqR/hPa4S2bY9X2MlFqkB3YiGzvbljNobFAf6xDpXsINbzfuM6VF6c1QdxJDTGxFpt2D6R0kGR2VI2XjixqtmPlgPyJh5OO6ZKh2AaXBdw59h2W1Ml5i9eC7GETfpVl3S2wJ6e/UEtWwQprcdgQm4zdvcYP/mhUyCdWBDwOAhCLAMVSpYVHocBQ1g7Tn36RhHg+Gi+oaR9muMV3LifSrdIU22pkj+GyX3APutTZ8C+y1OZEZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LaslOf9gtbGfA3c9R1C88IUpEPk+IJWusye9AlidDAA=;
 b=mQ7Nt5MqKjeuO6I1IG8k4HLBDrYNkIVkKnojGkJyYFBGMIe9EfJdOe1zgi4iuPbucGLjFBukZfB/hdyOMColCSM91f1lhT11bv96OUGQgaudfQCSlwDEh05DWAEQEIAQgNEeChXZLLIZZKadi6kgi9Z19w83WvMu7ShyzD4J0rurA7c/cobTXTUHocJpSP5++2VCQvOSr6KQlol9KzrV3V2CJx/wKprkwwAZa79TNOhwIwJSe+sMyWPEp/nXNJe7YxW4YhS0bmi0QgdTbb9zU4FkAAsvNo4YaNSTssBUKOssfGKCJ/nevad3UZ28eLwbI383Wcdi8hDaMT5aUCg1/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LaslOf9gtbGfA3c9R1C88IUpEPk+IJWusye9AlidDAA=;
 b=SrU2zmpK08YxVL534oMNLjfo0YdUSINtfK3OpoqENPHqS0uNhQlXhmODOvHlvLfnKoROT4kYdZj7shUTDhbPvuQP3gfGCxhKi8w1xXIZc2jh9Wtrm6pblX0FbTiPFlP39/850CcilpmZUjVrTNOTQ/4tzLT0lzFZ3S0jew3FY18=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Stewart Hildebrand <stewart.hildebrand@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Stewart Hildebrand <stewart.hildebrand@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
Date: Fri, 14 Oct 2022 16:09:26 -0400
Message-ID: <20221014200926.15250-1-stewart.hildebrand@amd.com>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221014025354.30248-1-stewart.hildebrand@amd.com>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT054:EE_|MN2PR12MB4206:EE_
X-MS-Office365-Filtering-Correlation-Id: 5ce85e39-73cc-4ab0-59ce-08daae2025fa
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VD+ZOLSFb4hFvZdLmqXO0/HG97LmXt3m8MZ6OB68WNvMGA9rQvsyxd5MjbB8lI3y6jVcEAMHcU4T7oxpVWIyFshWeBF8x3H/qLeznMOzlrLgFK2fQwKtLfFus4k4U9KLzh6ZwtVrziAkCWNktAx2VxYYyO3x10GK7dBJ3RcmerW2YLga1s1w9xnbT2ZDNPj5/W7O7+kumwipNFMek+HCLbOyqC44n2y0A9prxwBIbOdWXusKlOlnN/wMhg1TdUIiR7lmXTyfF6Tqhr1i4zzIhrT/FD7CmdV0mJ5O2p526PSfI6I6exBj58Ep2otadWWUj8ZRonhCT4PAi3u1jQ6UjJOkerevZ3Unyq3duWF6r6FtlN+AP0RiGK9agBXzFCkJMwrwTGAlDI7ozCyTuyd+qXIxyIRG/Czv8S2ZigIyALAekcrIazzfd8v4khARWFNFuKd8noDmHV8NB5FT/BZMCK4tCvjojWgLouxT2Fif/cd4koQUwzbEP5EiwxZ+22DhJv+EmeWrPZhBpE0FHOnp7qQe6HRHg2Zcycs9ujIWs0UemmwKcUPkFcIL+mKrnb/9pdKu/W7QOnRyOxBtStJmIIe+yxMkrxX1qO57CSMFS2yl2lZg2Ie+QZGf7VOjKFaWSI3WgD9clsvPoYPNs7RMwfgCRDlb1piDBTdC31QalbygRV22HiDZjmdz30hwUudCkyQ9q8EO8C0FQ0YSMGK+gdQ6xnAOorrCbLN85BGzeAfv72RAXX5J7pZzNw2HMUYxr+A5Dsr89Om04Xhn5UG/syIBdXZhD1WxXKi4CsUDP1RhTGEkFWS6wAT5PYFekbV/
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(70586007)(8676002)(70206006)(316002)(2906002)(8936002)(54906003)(41300700001)(4326008)(6916009)(356005)(81166007)(82740400003)(26005)(40460700003)(40480700001)(82310400005)(478600001)(6666004)(5660300002)(44832011)(36860700001)(2616005)(426003)(86362001)(47076005)(336012)(83380400001)(1076003)(36756003)(186003)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 20:10:32.5384
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce85e39-73cc-4ab0-59ce-08daae2025fa
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT054.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4206

All functions in domain_build.c should be marked __init. This was
spotted when building the hypervisor with -Og.

Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

---
v1 -> v2:
  Add Fixes: tag
  Add patch description
---
 xen/arch/arm/domain_build.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 61cda8e843..fc2961895b 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1051,8 +1051,8 @@ static void __init assign_static_memory_11(struct domain *d,
  * The current heuristic assumes that a device is a host bridge
  * if the type is "pci" and then parent type is not "pci".
  */
-static int handle_linux_pci_domain(struct kernel_info *kinfo,
-                                   const struct dt_device_node *node)
+static int __init handle_linux_pci_domain(struct kernel_info *kinfo,
+                                          const struct dt_device_node *node)
 {
     uint16_t segment;
     int res;
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Fri Oct 14 20:12:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 20:12:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423112.669586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojR36-0006So-JG; Fri, 14 Oct 2022 20:12:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423112.669586; Fri, 14 Oct 2022 20:12:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojR36-0006Sh-GW; Fri, 14 Oct 2022 20:12:52 +0000
Received: by outflank-mailman (input) for mailman id 423112;
 Fri, 14 Oct 2022 20:12:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojR35-0006SV-Cm; Fri, 14 Oct 2022 20:12:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojR35-0000jl-C1; Fri, 14 Oct 2022 20:12:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojR35-0004Hq-0L; Fri, 14 Oct 2022 20:12:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojR34-0001oN-W5; Fri, 14 Oct 2022 20:12:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=21cMqAYANGHhHUjQw0MmkOwhKqy/vJPDGeMSD0820A4=; b=1e31dG/D+NBnP79CiUaZVzb+Qj
	cQjWT3cyuz7dzC9dzewuA+HwkOuzLmtuNapup0O4Yj0jAM578K4yIbf79A97E9gLeX3pjQ8DqC43F
	hzfqXDMadjVsNfF8N8Xa9PsI/NCas9KOqF0g6ELkLRjnuGMzYAjB5BgXskWygXbcXNog=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173760-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173760: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=197f612b77c5afe04e60df2100a855370d720ad7
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 20:12:50 +0000

flight 173760 xen-unstable-smoke real [real]
flight 173770 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173760/
http://logs.test-lab.xenproject.org/osstest/logs/173770/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  197f612b77c5afe04e60df2100a855370d720ad7
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    7 days
Failing since        173492  2022-10-11 13:01:50 Z    3 days   19 attempts
Testing same since   173760  2022-10-14 15:01:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 675 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 20:15:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 20:15:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423120.669597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojR5l-00078y-24; Fri, 14 Oct 2022 20:15:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423120.669597; Fri, 14 Oct 2022 20:15:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojR5k-00078r-VF; Fri, 14 Oct 2022 20:15:36 +0000
Received: by outflank-mailman (input) for mailman id 423120;
 Fri, 14 Oct 2022 20:15:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojR5k-00078e-4o
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 20:15:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojR5h-0000mB-4D; Fri, 14 Oct 2022 20:15:33 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojR5g-0004Pi-V7; Fri, 14 Oct 2022 20:15:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=wNWWhMBvBmeb140clZPL3vn64juCKjyuEISDfRUrMN4=; b=JtfRn1eRfkntpwsZtOLE1c5tQK
	D4ec9XrbVunfizm/b2iM/EWkYvem8HGHCU9i5Qlf8oZGHF6gEj4IcNs8Y9NrL+Gqg/gGmeWfJv0dX
	wuEu+A4YRqeOwKk1vdnDOzL8jB64vEOF/noY0xuM0FGEu1nvsrknpzIlzWGL7WVMR/aY=;
Message-ID: <456e5a86-a875-bc30-cf8b-e4497afc530d@xen.org>
Date: Fri, 14 Oct 2022 21:15:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
To: Stewart Hildebrand <stewart.hildebrand@amd.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <0ade954c-5741-754c-fc59-177feb67ddf4@suse.com>
 <5f985e76-e817-5d44-3463-ffc0a98c407c@xen.org>
 <728f2beb-dc28-9140-0fec-0a67bc49f3f4@amd.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init
In-Reply-To: <728f2beb-dc28-9140-0fec-0a67bc49f3f4@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Stewart,

On 14/10/2022 20:23, Stewart Hildebrand wrote:
> On 10/14/22 04:22, Julien Grall wrote:
>> Hi,
>>
>> On 14/10/2022 08:16, Jan Beulich wrote:
>>> On 14.10.2022 04:53, Stewart Hildebrand wrote:
>>>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
>>>
>>> I guess a non-empty description and a Fixes: tag would be nice.
> 
> Okay, I will send a v2 with the following description:
> All functions in domain_build.c should be marked __init. This was 
> spotted when building the hypervisor with -Og.
> 
> Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
> 
>> +1. I am actually quite interested to understand how this was spotted.
>>
>> The build system should check that any function/data in domain_build.c
>> are part of the __init section. So I guess the compiler you are using
>> doesn't inline the function?
>>
>> If so, I am actually surprised you are the first one spotted this... We
>> are building on various distribution without any issues (?). I would be
>> interested to know the compiler version and maybe we could add it in the
>> CI.
> 
> I added -Og to the make command line so it takes precedence over the 
> default -O1/-O2:
> 
> $ make EXTRA_CFLAGS_XEN_CORE="-Og" XEN_TARGET_ARCH=arm64 
> CROSS_COMPILE=aarch64-none-linux-gnu- dist-xen -j $(nproc)
> 
> Indeed, I did observe the build error:
> Error: size of arch/arm/domain_build.o:.text is 0x00000008
> 
> I used this rune to reveal the culprit:
> 
> $ aarch64-none-linux-gnu-objdump -d xen/arch/arm/domain_build.o | head
> 
> xen/arch/arm/domain_build.o:     file format elf64-littleaarch64
> 
> 
> Disassembly of section .text:
> 
> 0000000000000000 <handle_linux_pci_domain>:
>      0:   52800000        mov     w0, #0x0                        // #0
>      4:   d65f03c0        ret
> 
> I am using this toolchain: 
> https://developer.arm.com/-/media/Files/downloads/gnu/11.3.rel1/binrel/arm-gnu-toolchain-11.3.rel1-x86_64-aarch64-none-linux-gnu.tar.xz

Thanks for the details. I guess the '-Og' is the culprint.

> 
> Further, there were two more build errors observed when building with -Og:
> arch/arm/domain_build.c: In function ‘make_cpus_node’:
> arch/arm/domain_build.c:2013:12: error: ‘clock_valid’ may be used 
> uninitialized in this function [-Werror=maybe-uninitialized]
>   2013 |         if ( clock_valid )
>        |            ^

I think this is a false positive because 'clock_valid' is set at the 
same time as 'compatible'. The latter is check that is not NULL just 
after it is set.

In general, I tend to prefer if variable are not initialized (unless 
strictly necessary) because we can take advantage of the compiler to 
spot any issue.

In this case, it should not be a big problem because the default value 
(false) would be sensible here.

> 
> arch/arm/efi/boot.c: In function ‘efi_start’:
> arch/arm/efi/boot.c:1464:9: error: ‘argc’ may be used uninitialized in 
> this function [-Werror=maybe-uninitialized]
>   1464 |         efi_arch_handle_cmdline(argc ? *argv : NULL, options, 
> name.s);
>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I am a bit puzzled why it warn on this line but not few lines above 
where it is already used.

This function is a bit difficult to read. AFAIU, the code look like:

if ( use_cfg_file )
{
    argc = ...
}

/* do something common */

if ( use_cfg_file )
   efi_arch_handle_cmd(argc, ...);

The GCC with -Og is probably not capable to detect that argc will always 
be used when 'use_cfg_file'.

The "do something common" is two lines. So I am tempted to suggest to 
just duplicate those two lines. This could also allow us to move all the 
code in the ifs (nearly 100 lines over the two ifs!) in a separate function.

But I think Jan (the maintainer of the code) may not be happy with 
that). So short of a second better suggestion, initializing 'argc' to 0 
(?) and a comment explaining this is to silence the compiler may be the 
way to go.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 20:28:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 20:28:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423128.669614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojRHk-0000Jp-8D; Fri, 14 Oct 2022 20:28:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423128.669614; Fri, 14 Oct 2022 20:28:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojRHk-0000Ji-3r; Fri, 14 Oct 2022 20:28:00 +0000
Received: by outflank-mailman (input) for mailman id 423128;
 Fri, 14 Oct 2022 20:27:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cdf0=2P=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ojRHi-0000Jc-OS
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 20:27:58 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af533c48-4bfe-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 22:27:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A84F7B818B2;
 Fri, 14 Oct 2022 20:27:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0DB8C433C1;
 Fri, 14 Oct 2022 20:27:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af533c48-4bfe-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665779273;
	bh=rhXfl9tYWrC7olZgnEtU52Lf8/82r8LP+/hrcfkJZbo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Mb6lK8QS4+I7BHspOHkFU6XGqCJOyBGjXgu5nkA/wI3Pg8Jan/3q2CP4pD8S2OX3o
	 f/4ROk3mT+egVlE9x+NNKq25EdH2mvGxYbu7f7/LlZl9sMwXJ+GnQGVrVvHsNZM3zA
	 z4z9LAtxPJHAx8LjMKzfcWuWx4x+1ssHopzd8nNH6utPVbZSyzeCcjh01dozCpQ2jU
	 sxQh44VMLmRzqG+h4sCdDPP4nFrOyAdvu4DLSPBYe7FCYss6yBRM0skxid4NjDIyve
	 XvVFtzw2bXP9NuZVArlUaqZfkvNsMy9rN8PdSZ+YJtR5WwsRhpHheht1e5sS6JgjxJ
	 ljyJbn9uWQlcg==
Date: Fri, 14 Oct 2022 13:27:51 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <bertrand.marquis@arm.com>
cc: xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
In-Reply-To: <cover.1665561024.git.bertrand.marquis@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 12 Oct 2022, Bertrand Marquis wrote:
> This patch series is a first attempt to check if we could use Yocto in
> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
> 
> The first patch is creating a container with all elements required to
> build Yocto, a checkout of the yocto layers required and an helper
> script to build and run xen on qemu with yocto.
> 
> The second patch is creating containers with a first build of yocto done
> so that susbsequent build with those containers would only rebuild what
> was changed and take the rest from the cache.
> 
> The third patch is adding a way to easily clean locally created
> containers.
> 
> This is is mainly for discussion and sharing as there are still some
> issues/problem to solve:
> - building the qemu* containers can take several hours depending on the
>   network bandwith and computing power of the machine where those are
>   created
> - produced containers containing the cache have a size between 8 and
>   12GB depending on the architecture. We might need to store the build
>   cache somewhere else to reduce the size. If we choose to have one
>   single image, the needed size is around 20GB and we need up to 40GB
>   during the build, which is why I splitted them.
> - during the build and run, we use a bit more then 20GB of disk which is
>   over the allowed size in gitlab
> 
> Once all problems passed, this can be used to build and run dom0 on qemu
> with a modified Xen on the 3 archs in less than 10 minutes.

The build still doesn't work for me. I found the reason:

  create archive failed: cpio: write failed - Cannot allocate memory

It is a "silly" out of memory error. I tried to solve the problem by
adding:

  export RPM_BUILD_NCPUS=8

at the beginning of build-yocto.sh but it didn't work. I realize that
this error might be considered a workstation configuration error at my
end but I cannot find a way past it. Any suggestions?


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 21:04:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 21:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423142.669631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojRqx-0004ii-27; Fri, 14 Oct 2022 21:04:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423142.669631; Fri, 14 Oct 2022 21:04:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojRqw-0004ib-VI; Fri, 14 Oct 2022 21:04:22 +0000
Received: by outflank-mailman (input) for mailman id 423142;
 Fri, 14 Oct 2022 21:04:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cdf0=2P=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1ojRqu-0004iV-Pk
 for xen-devel@lists.xenproject.org; Fri, 14 Oct 2022 21:04:20 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c479d68c-4c03-11ed-8fd0-01056ac49cbb;
 Fri, 14 Oct 2022 23:04:19 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id AF82A61C4E;
 Fri, 14 Oct 2022 21:04:17 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FD77C433C1;
 Fri, 14 Oct 2022 21:04:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c479d68c-4c03-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1665781457;
	bh=1ZrwVK602de+t7ntxwWXDkV4lHPteu8Ep7nu8tc5WHg=;
	h=Date:From:To:cc:Subject:From;
	b=Fze4aERgwE32h5auE1NygK3vuEGxYTRGPJ0w51tDhxgooqN1qLddmZcf5WCRVh+V7
	 QE71eljzumYdpyT1uzaf6gEG4M0fNkMtMMPT4EicrlT7CwPUo6McODBETDjL062MTm
	 6iUCgoePFcDeTdR0v4kgjutuiPp9NKool4WQckdvqcPOElFWNsbV7ghjv1/iv0/hO4
	 5qxrCOqpv9IAqxcUstqwysb3nUfpO5yilFsfmZn68BaftKdTrkMS/NveiGlYBmsmlH
	 bQoILR8fv8ce5/XtPrzb78GtPm+aNoImIoiLxlKZ51afD6Y3qhXxToxiLrI27u3F85
	 IrOUwGuS0gRNA==
Date: Fri, 14 Oct 2022 14:04:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: jgross@suse.com, boris.ostrovsky@oracle.com
cc: sstabellini@kernel.org, jbeulich@suse.com, xen-devel@lists.xenproject.org, 
    JESHWANTHKUMAR.NK@amd.com
Subject: privcmd.c not calling set_phys_to_machine
Message-ID: <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

Hi Juergen and all,

I am writing again to ask a question about privcmd.c in PV dom0 x86.
This is related to the previous pin_user_pages_fast issue:

https://marc.info/?l=xen-devel&m=166268914727630
https://marc.info/?l=xen-devel&m=166322385912052


In summary this is the situation:

1. domU (HVM) kernel space:
    a. pages allocation with get_free_pages()
    b. get dma_handle by calling dma_map_page() on the pages allocated in (1.a)
    c. send dma_handle to dom0 (PV) using virtio queue

2. dom0 userspace (QEMU):
        a. read dma_handle from virtio queue
        b. map dma_handle using QEMU dma_memory_map(), which calls
           xenforeignmemory_map2, which is IOCTL_PRIVCMD_MMAPBATCH_V2,
           which ends up calling drivers/xen/privcmd.c:privcmd_ioctl_mmap_batch
           [this is verified to work correctly, the mapping works]
        c. open /dev/tee node and make an ioctl call to register the
           virtual address (from step 2.b) with TEE.

3. dom0 kernel space:
        a. AMD TEE driver get the virtual address passed by userspace
        b. AMD TEE driver get the list of pages corresponding to the
           virtual address (3.a) and calls dma_map_page() on them

The last step (3.b) misbehaves as dev_addr at the beginning of
xen_swiotlb_map_page (which implements dma_map_page() in dom)) is 0.

  dma_addr_t dev_addr = xen_phys_to_dma(dev, phys);
  /* dev_addr here is zero */


Could it be that the original mapping of the foreign pages in Dom0, done
by step 2.b, is not complete? Looking into
privcmd_ioctl_mmap_batch, for PV guests, it is calling mmap_batch_fn:

	BUG_ON(traverse_pages_block(m.num, sizeof(xen_pfn_t),
				    &pagelist, mmap_batch_fn, &state));

mmap_batch_fn calls xen_remap_domain_gfn_array, which calls
xen_remap_pfn.

xen_remap_pfn only changes the VA->PA mapping and does nothing else.
Specifically, nobody seems to call set_phys_to_machine in this code
path. Isn't set_phys_to_machine required?

Don't we need a call to set_phys_to_machine so that the next time a
driver tries to call:

  /* address is the virtual address passed by QEMU userspace */
  dma_map_page(virt_to_page(address))

it will behave correctly? Or am I missing something?


How is xen_phys_to_dma expected to work correctly for:

  /* address is the virtual address passed by QEMU userspace and mapped
   * in 2.b */
  phys_addr = virt_to_phys(address);
  xen_phys_to_dma(dev, phys_addr);


My guess would be that we need to add:

  set_phys_to_machine(pfn, FOREIGN_FRAME(mfn));

in mmap_batch_fn or xen_remap_pfn?

Thanks for any help or suggestions.

Cheers,

Stefano


From xen-devel-bounces@lists.xenproject.org Fri Oct 14 21:48:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 21:48:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423152.669654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojSX6-00010F-Gs; Fri, 14 Oct 2022 21:47:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423152.669654; Fri, 14 Oct 2022 21:47:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojSX6-000108-DP; Fri, 14 Oct 2022 21:47:56 +0000
Received: by outflank-mailman (input) for mailman id 423152;
 Fri, 14 Oct 2022 21:47:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojSX5-0000zy-Fs; Fri, 14 Oct 2022 21:47:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojSX5-0002R9-Cw; Fri, 14 Oct 2022 21:47:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojSX4-0006fW-UN; Fri, 14 Oct 2022 21:47:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojSX4-0003jH-Ts; Fri, 14 Oct 2022 21:47:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=eiAD1vlvoYDiUCnr3nkj9yy3rfycv4fSNKU58rkBPHo=; b=xBZz2teGtQCc6LaOC/oGIErEwY
	BVBfAxnYBMGD2nYexB0y+ZuFBxERQjI8MfOzmdkKaH7i2wwQfxyh4Qk4ZlyM1QPXHM4dqd2lm7Ng+
	dxxRLI+zMPKJJYyspVoy1xCodbSLYytbxIMmoQF63JFLLJoVfAPnmDBClJ7H0RL3H9Vw=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-arm64-arm64-xl-seattle
Message-Id: <E1ojSX4-0003jH-Ts@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 21:47:54 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-arm64-arm64-xl-seattle
testid guest-start

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173775/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-arm64-arm64-xl-seattle.guest-start.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-arm64-arm64-xl-seattle.guest-start --summary-out=tmp/173775.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-arm64-arm64-xl-seattle guest-start
Searching for failure / basis pass:
 173702 fail [host=laxton1] / 172623 ok.
Failure / basis pass flights: 173702 / 172623
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#444260d45ec2a84e8f8c192b3539a3cd5591d009-e7d7f02c8e157e936855a091948757f78c7d0298 git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad\
 8-107951211a8d17658e1aaa0c23a8cf29f8806ad8 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#cea5ed49bb5716698a11312a3f38bc8865cd1e67-1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Loaded 10001 nodes in revision graph
Searching for test results:
 173755 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 e8882bcfe35520e950ba60acd6e67e65f1ce90a8
 173756 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173758 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 32cb81501c8b858fe9a451650804ec3024a8b364
 173761 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173763 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173766 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173769 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173773 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173775 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 172623 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173493 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173511 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173702 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173603 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173753 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 f5959ed715e19cf2844656477dbf74c2f576c9d4
 173714 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173744 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173747 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fdb4de628120a8736ee47522d1941e3ad3bdf8a 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173748 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6a2b20ff97e4256970644a07f74a4c5655bf5072 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173750 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4364d661685d4806b8fb66ff76eaece7ea6a4426 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
Searching for interesting versions
 Result found: flight 172623 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x55f613ec3870) HASH(0x55f613ecb8b8) HASH(0x55f613e6a420) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56\
 b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 f5959ed715e19cf2844656477dbf74c2f576c9d4, results HASH(0x55f613ee5220) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4364d661685d4806b8fb66ff76eaece7ea6a4426 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55f613ea\
 d6a8) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6a2b20ff97e4256970644a07f74a4c5655bf5072 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55f613ed9828) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fdb4de628120a8736ee47522d1941e3ad3bdf8a 10795\
 1211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55f613ed0df0) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55f613ee25f0) HASH(0x55f613ee79a8) Result fou\
 nd: flight 173493 (fail), for basis failure (at ancestor ~614)
 Repro found: flight 173714 (pass), for basis pass
 Repro found: flight 173761 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 173756 (pass), for last pass
 Result found: flight 173763 (fail), for first failure
 Repro found: flight 173766 (pass), for last pass
 Repro found: flight 173769 (fail), for first failure
 Repro found: flight 173773 (pass), for last pass
 Repro found: flight 173775 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173775/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 192 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-arm64-arm64-xl-seattle.guest-start.{dot,ps,png,html,svg}.
----------------------------------------
173775: tolerable ALL FAIL

flight 173775 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173775/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start             fail baseline untested


jobs:
 test-arm64-arm64-xl-seattle                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Oct 14 23:30:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 14 Oct 2022 23:30:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423166.669680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojU7k-0003Am-91; Fri, 14 Oct 2022 23:29:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423166.669680; Fri, 14 Oct 2022 23:29:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojU7k-0003Af-69; Fri, 14 Oct 2022 23:29:52 +0000
Received: by outflank-mailman (input) for mailman id 423166;
 Fri, 14 Oct 2022 23:29:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojU7i-0003AV-Ij; Fri, 14 Oct 2022 23:29:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojU7i-000490-F5; Fri, 14 Oct 2022 23:29:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojU7i-0000cC-1x; Fri, 14 Oct 2022 23:29:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojU7i-0005Rd-1W; Fri, 14 Oct 2022 23:29:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ikbB/OwVwplXM5j3fPM85sDVO4jpTGRFkXfSXUq6GXA=; b=weak61BlpeP5Lo7Rap7bLEu7KN
	EC4SRsYxNdl7hDHDUr7RanDfVQ/OafiO9qaj5pxDS7pxlZzmxPu7F1JCdoqS2uVmq6eqlnLaHBMpZ
	XyezlVYVcjFNc73AaQ875HQWlDD1OYptkfNhXRYinkS2v9XtB8jeOTdCj9o2rYlR3dHk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173720-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173720: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-amd64-xl-rtds:debian-fixup:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 14 Oct 2022 23:29:50 +0000

flight 173720 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173720/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-rtds     13 debian-fixup     fail in 173610 pass in 173720
 test-amd64-i386-xl-xsm       22 guest-start/debian.repeat  fail pass in 173610

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 172547
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   60 days
Failing since        173494  2022-10-11 13:38:08 Z    3 days    6 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 00:06:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 00:06:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423176.669697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojUh0-00088c-7C; Sat, 15 Oct 2022 00:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423176.669697; Sat, 15 Oct 2022 00:06:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojUh0-00088V-44; Sat, 15 Oct 2022 00:06:18 +0000
Received: by outflank-mailman (input) for mailman id 423176;
 Sat, 15 Oct 2022 00:06:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojUgy-00088L-6N; Sat, 15 Oct 2022 00:06:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojUgy-0005My-58; Sat, 15 Oct 2022 00:06:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojUgx-0001Ra-RS; Sat, 15 Oct 2022 00:06:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojUgx-0001VX-Qz; Sat, 15 Oct 2022 00:06:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kmmfv+uxxTzxIIBPGmvk27Vh+hNUQnPVH5RGF7PxSUc=; b=L6vbCP6b/usxWn9sHHhXPLGphU
	HDchNNEeBmr5o5yYJqBp4AvuJJNNPUi/hvofp0W3rrc6+EdjOwhPK2RO1ypW/RhhpeltSj4lJDekn
	Oh3qVGVfMzGXnVEz8LmXnf0i+F8HNR3UfmdLoPbYLxQEaV2Q0a/SzAJkwNLhn0VykdZw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173776-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173776: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 00:06:15 +0000

flight 173776 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173776/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    7 days
Failing since        173492  2022-10-11 13:01:50 Z    3 days   20 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 01:53:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 01:53:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423190.669726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojWMR-0000r2-0t; Sat, 15 Oct 2022 01:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423190.669726; Sat, 15 Oct 2022 01:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojWMQ-0000qu-RL; Sat, 15 Oct 2022 01:53:10 +0000
Received: by outflank-mailman (input) for mailman id 423190;
 Sat, 15 Oct 2022 01:53:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojWMP-0000qk-Nd; Sat, 15 Oct 2022 01:53:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojWMP-0005UO-8p; Sat, 15 Oct 2022 01:53:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojWMO-00075d-Rk; Sat, 15 Oct 2022 01:53:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojWMO-0003oe-RH; Sat, 15 Oct 2022 01:53:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0bHKsqtAQ0bpdT2BQC1HrQHs6/NDVtB4iBox48NkMug=; b=H9aaWgrzy4kybxTl+IboF7JIqL
	wHrsdPwo/8rZfUqFMFNfC4m/EYCA9MrUSe9HHZy1+RM+JpbqiozfmL1XHjY4YywGpORl8p2fMTdxr
	Hr0YiDgQRACKUygw6JDOUljTCgAAyoWRtzxxdDcM+Q/pV1OWgCzCkGvSUmahCwfN8oZ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173742-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173742: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=06ebad7c783fc44b23284c86cbaf4052f99834fd
X-Osstest-Versions-That:
    libvirt=2fb71217f9d25436b72a78c5d91f015623eb7ef4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 01:53:08 +0000

flight 173742 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173742/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173671
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173671
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173671
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              06ebad7c783fc44b23284c86cbaf4052f99834fd
baseline version:
 libvirt              2fb71217f9d25436b72a78c5d91f015623eb7ef4

Last test of basis   173671  2022-10-13 04:18:51 Z    1 days
Testing same since   173742  2022-10-14 04:18:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Peter Krempa <pkrempa@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   2fb71217f9..06ebad7c78  06ebad7c783fc44b23284c86cbaf4052f99834fd -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 03:16:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 03:16:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423205.669754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojXeO-0001Od-6j; Sat, 15 Oct 2022 03:15:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423205.669754; Sat, 15 Oct 2022 03:15:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojXeO-0001OW-3z; Sat, 15 Oct 2022 03:15:48 +0000
Received: by outflank-mailman (input) for mailman id 423205;
 Sat, 15 Oct 2022 03:15:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojXeM-0001OM-Ux; Sat, 15 Oct 2022 03:15:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojXeM-0007JH-SD; Sat, 15 Oct 2022 03:15:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojXeM-0003xH-Ar; Sat, 15 Oct 2022 03:15:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojXeM-0004gV-AN; Sat, 15 Oct 2022 03:15:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ML5nL27AkKnw5XYqX7yLU0TqgbwcnyU055REvTApmPU=; b=4FsDeuMYiJKqWN/bugVB9/3Xgp
	8Zair+bj8Gapv51ABkJJRgl6b4Y86QmvlcPBJR+tKWRFaA/sqUrSAddU2AWC9lbA35/xZ4WAjqPfs
	xcWP3kOaN9XkNqlBUcxydr4u8joctoFufhFKAe6Iryx4VeKqJbIs1tIubFQywKVJvIG4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173722-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173722: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=cdcb7dcb401757b5853ca99c1967a6d66e1deea5
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 03:15:46 +0000

flight 173722 qemu-mainline real [real]
flight 173788 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173722/
http://logs.test-lab.xenproject.org/osstest/logs/173788/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-vhd      21 guest-start/debian.repeat fail REGR. vs. 173447

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 173788-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                cdcb7dcb401757b5853ca99c1967a6d66e1deea5
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z    8 days
Failing since        173497  2022-10-11 15:38:33 Z    3 days    4 attempts
Testing same since   173722  2022-10-13 16:09:43 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alberto Faria <afaria@redhat.com>
  Alex Bennée <alex.bennee@linaro.org>
  Ani Sinha <ani@anisinha.ca>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniil Tatianin <d-tatianin@yandex-team.ru>
  David Hildenbrand <david@redhat.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Greg Kurz <groug@kaod.org>
  Hal Martin <hal.martin@gmail.com>
  Igor Mammedov <imammedo@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Jerome Forissier <jerome.forissier@linaro.org>
  Joel Stanley <joel@jms.id.au>
  Jonah Palmer <jonah.palmer@oracle.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Kevin Wolf <kwolf@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>
  Miguel Luis <miguel.luis@oracle.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Viresh Kumar <viresh.kumar@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3318 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 04:28:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 04:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423220.669788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojYmy-0000jK-Rs; Sat, 15 Oct 2022 04:28:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423220.669788; Sat, 15 Oct 2022 04:28:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojYmy-0000jD-N5; Sat, 15 Oct 2022 04:28:44 +0000
Received: by outflank-mailman (input) for mailman id 423220;
 Sat, 15 Oct 2022 04:28:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojYmw-0000j3-V0; Sat, 15 Oct 2022 04:28:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojYmw-0000Bg-Tv; Sat, 15 Oct 2022 04:28:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojYmw-00064o-JF; Sat, 15 Oct 2022 04:28:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojYmw-0006MY-Im; Sat, 15 Oct 2022 04:28:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pfZt7lWoCq+6tqTPm4IgwDdn8GI4v4HFB3imUQ09/S0=; b=Epbe7F9VN6MVSdk7DBjgKWIjmb
	SCVokgW1ROjMR9lRqcRyhuJU6hOTTLlD6jQ0SO8djoJsekTu+GEjK1ESHBlwpAOLULlNM4vp0kswW
	WwcQvKrZxnGXlcNcthhLspayQ5zRhxYX3jqdz0ZL86LpwBpemxRfWYAwYWrt9+byxfMw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173786-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173786: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 04:28:42 +0000

flight 173786 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173786/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173776

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173776 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173776 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    7 days
Failing since        173492  2022-10-11 13:01:50 Z    3 days   21 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 04:59:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 04:59:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423230.669804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZGo-0004F6-9T; Sat, 15 Oct 2022 04:59:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423230.669804; Sat, 15 Oct 2022 04:59:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZGo-0004Ez-6S; Sat, 15 Oct 2022 04:59:34 +0000
Received: by outflank-mailman (input) for mailman id 423230;
 Sat, 15 Oct 2022 04:59:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojZGm-0004Ep-MA; Sat, 15 Oct 2022 04:59:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojZGm-0000hd-HF; Sat, 15 Oct 2022 04:59:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojZGm-0006ne-4R; Sat, 15 Oct 2022 04:59:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojZGm-0000MU-3y; Sat, 15 Oct 2022 04:59:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=s35jehzkUomqlItiOBHXBg67Xd2tjzlA8QTTQVDcmJY=; b=Hi7fvc7WSQSS6hdoLAV4tceSOZ
	bnVbhdWDH0RAuyTKLDkq9NjUkiM0GTrULr0rc2mgaTtdBVmO9k9rFiTNiRxZAUEccuR8Jv0qbkkuj
	hd7oPPwdsM27orv6MharjG0d0zPy1dYtfK/1a28pwwa75JC3xpzH/GSdtC8B0nyXdXsA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173725-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173725: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 04:59:32 +0000

flight 173725 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173725/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2   5 host-install(5)          broken pass in 173650
 test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 173650 pass in 173725
 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 173650 pass in 173725
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173650

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   60 days
Failing since        173496  2022-10-11 14:08:01 Z    3 days    5 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  broken  
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken
broken-step test-amd64-amd64-xl-credit2 host-install(5)

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423240.669818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPL-0006AH-BE; Sat, 15 Oct 2022 05:08:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423240.669818; Sat, 15 Oct 2022 05:08:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPL-0006AA-7p; Sat, 15 Oct 2022 05:08:23 +0000
Received: by outflank-mailman (input) for mailman id 423240;
 Sat, 15 Oct 2022 05:08:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPK-00069z-1E
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:22 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61f22745-4c47-11ed-8fd0-01056ac49cbb;
 Sat, 15 Oct 2022 07:08:20 +0200 (CEST)
Received: from DM6PR03CA0026.namprd03.prod.outlook.com (2603:10b6:5:40::39) by
 CH2PR12MB4907.namprd12.prod.outlook.com (2603:10b6:610:68::20) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.29; Sat, 15 Oct 2022 05:08:16 +0000
Received: from DM6NAM11FT060.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:40:cafe::29) by DM6PR03CA0026.outlook.office365.com
 (2603:10b6:5:40::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:16 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT060.mail.protection.outlook.com (10.13.173.63) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Sat, 15 Oct 2022 05:08:16 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:16 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 22:08:15 -0700
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:14 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61f22745-4c47-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NMpGNDz5MJGBTsQNgOAbOkw1N3Q3yQ/FImJIQ7DBy+jzFSnE0aoUPDoe3f/pW2fRuwVuHmMP/o146u4qru4ovMWP0fJIJ/6Zvieeo6dk27uXeYGyiSRQDILQDamWV0QF2CWVPYoOsauHUxigrnYe44f0BUbhcGBInOaHb8J9MyNSPUAIowo3BVvX5HUTzur+dWA9eDEDFB73fFtHjbQG+1YCv/jB8boqeC+vFBaV5GearUGOyh6eiX8x2bhnn7cMtKmwGrAqFwnReqVzyM8ikQdOCJ10ZEWEY08dN4F21CU/g4bZSZHtXkqmgDjF/ceWkx88e5YP0ZE7XwBIxqWAmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z7qBBSFtT16dKo24xhhVW2fFUFVUWqNupyxQmZ/Rxf8=;
 b=Ue/Sid5p2QRLbRtLRuWP5IHoMz9uxKGi3pckspLkuoRn6r9XrYQWmWoNBfd4uZ0SNuAKTOgcODLX+BvghCvRPK/u5g4aaIKpCM8H+rN/odzlnHx8e3N4Vl8N/qBMK9OZy92qyX2TXs4qhoojVpafYVMBRG53o4g3HWX+yFy4WjgiQeJ+UG85t2kEir8w0WEnNw1J6SQH+0W/DTXVpKQf65PnJmCq+eRflSuv5+r1mSeqgvwOAyjp8pgbn049mwcRL/5P8VqVYarX0IEiQenvPBoeHHOqah7wSJpNRTd1I9J9gZUaC9obE96a4kgtoHEtsWQh8ijOsdCJHzTC/RZs5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z7qBBSFtT16dKo24xhhVW2fFUFVUWqNupyxQmZ/Rxf8=;
 b=qTo6dPVUM/hSVw7RpifwHoSTyL70JsSNk0QMqWEcAf1I1Lp7Uuz1zdxUdMW9bCLYqv7fD8jxh9khz++AMa+EC3YL2k9bJ6zRxJXuz6CY57YIaGDoU5o7ki2kbLWRHOGpvbqiaA+JVgTmjYMQdKq7jwfVetWoJW0Lg6zg2nj8Bxk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, "Michael S.
 Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson
	<richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>,
	Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard
	<anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, "open list:X86 Xen
 CPUs" <xen-devel@lists.xenproject.org>
Subject: [PATCH v1 02/12] hw/i386/xen/: move xen-mapcache.c to hw/xen/
Date: Fri, 14 Oct 2022 22:07:40 -0700
Message-ID: <20221015050750.4185-3-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT060:EE_|CH2PR12MB4907:EE_
X-MS-Office365-Filtering-Correlation-Id: 47dfa116-68cc-4c3b-ef12-08daae6b44d0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D1Fa0Vvl0/ewbsVHO1VAeiZhRtribXwC+6BCt3LOdnntiDIPNe+hFNgF5McuecoeuGTAXVpUMVblWislvtqCzzIS40k2WRDH9p2tHR2TJqXrw5SXiQ4f4FjrNCfBeQpSVWXZ5LrgGkrGUJI7SAoF0cZ4V/RrvJ7wbdrMAgLxsDxFImFGRei1VszIPb3l9ptkZbh73jv4Zy+T/dvRwkU7EeuovtHGHJfslXCkAz/kKgNXejwxkfuHwwPxuEeEyUBQszv0Z4eK2LirO3KQwFUIlQduZ4mGtEgXF0PGvP1+pl30jM6OhPh4hoLtY8Y5BGvSngHjUcarJmkrf6/8o+JmFHJrpoR5Hng9mhXPBJfV9C/GHzC4/tXCKFew9QJVGOFUDfkOg9MuLwXobrSNvwj+r7FHooY7Qyr2T5oDrRHMHLg3l5weWt5D8JGYnHR08GsBEdgkTD2KVm3KxHqEE63zDTsXLjnVhDwRMU+HMJphCaZcYgd350/0SY0s+w/fdLqm66TZJu4XGxow9BGMkJfJmsd8JnyfntKqbHijtOaGz9Wwj3GNVfJOBO03q0uqn3o6HJ0I9wKqWreYK9f/Q93zUqw92hBH+F+IQlAXdyUOpDs35i+7jZCOuQ0K2AWBu0qnTddEogG3oRd8eRfZfCtbSfq4g4AXE8BCb0W+J7IVL4c4ZELEUY3ybxCTnD4JVIX7kVoQsKr/4o8HW80i/2xuRVEpkzm6l0RihMaiChtzPMBFFwg45kfn+wPbyqkIeDHHzy3dz3Z11Nq9jC0alV3GeMXAu1E9mdcd45FkGCf0dImEl8nXtFwGxoH72gBBZfUA
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(478600001)(54906003)(316002)(6916009)(6666004)(4326008)(70586007)(70206006)(40480700001)(8676002)(41300700001)(26005)(7416002)(82310400005)(8936002)(36756003)(5660300002)(426003)(356005)(86362001)(186003)(81166007)(1076003)(336012)(82740400003)(83380400001)(47076005)(2906002)(44832011)(40460700003)(2616005)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:16.4686
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 47dfa116-68cc-4c3b-ef12-08daae6b44d0
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT060.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4907

xen-mapcache.c contains common functions which can be used for enabling Xen on
aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it
accessible for both aarch64 and x86.

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 hw/i386/meson.build              | 1 +
 hw/i386/xen/meson.build          | 1 -
 hw/i386/xen/trace-events         | 5 -----
 hw/xen/meson.build               | 4 ++++
 hw/xen/trace-events              | 5 +++++
 hw/{i386 => }/xen/xen-mapcache.c | 0
 6 files changed, 10 insertions(+), 6 deletions(-)
 rename hw/{i386 => }/xen/xen-mapcache.c (100%)

diff --git a/hw/i386/meson.build b/hw/i386/meson.build
index 213e2e82b3..cfdbfdcbcb 100644
--- a/hw/i386/meson.build
+++ b/hw/i386/meson.build
@@ -33,5 +33,6 @@ subdir('kvm')
 subdir('xen')
 
 i386_ss.add_all(xenpv_ss)
+i386_ss.add_all(xen_ss)
 
 hw_arch += {'i386': i386_ss}
diff --git a/hw/i386/xen/meson.build b/hw/i386/xen/meson.build
index be84130300..2fcc46e6ca 100644
--- a/hw/i386/xen/meson.build
+++ b/hw/i386/xen/meson.build
@@ -1,6 +1,5 @@
 i386_ss.add(when: 'CONFIG_XEN', if_true: files(
   'xen-hvm.c',
-  'xen-mapcache.c',
   'xen_apic.c',
   'xen_platform.c',
   'xen_pvdevice.c',
diff --git a/hw/i386/xen/trace-events b/hw/i386/xen/trace-events
index 5d6be61090..a0c89d91c4 100644
--- a/hw/i386/xen/trace-events
+++ b/hw/i386/xen/trace-events
@@ -21,8 +21,3 @@ xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p"
 cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
 cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
 
-# xen-mapcache.c
-xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64
-xen_remap_bucket(uint64_t index) "index 0x%"PRIx64
-xen_map_cache_return(void* ptr) "%p"
-
diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index ae0ace3046..19d0637c46 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -22,3 +22,7 @@ else
 endif
 
 specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
+
+xen_ss = ss.source_set()
+
+xen_ss.add(when: 'CONFIG_XEN', if_true: files('xen-mapcache.c'))
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 3da3fd8348..2c8f238f42 100644
--- a/hw/xen/trace-events
+++ b/hw/xen/trace-events
@@ -41,3 +41,8 @@ xs_node_vprintf(char *path, char *value) "%s %s"
 xs_node_vscanf(char *path, char *value) "%s %s"
 xs_node_watch(char *path) "%s"
 xs_node_unwatch(char *path) "%s"
+
+# xen-mapcache.c
+xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64
+xen_remap_bucket(uint64_t index) "index 0x%"PRIx64
+xen_map_cache_return(void* ptr) "%p"
diff --git a/hw/i386/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c
similarity index 100%
rename from hw/i386/xen/xen-mapcache.c
rename to hw/xen/xen-mapcache.c
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423241.669829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPM-0006Pg-IR; Sat, 15 Oct 2022 05:08:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423241.669829; Sat, 15 Oct 2022 05:08:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPM-0006PT-FW; Sat, 15 Oct 2022 05:08:24 +0000
Received: by outflank-mailman (input) for mailman id 423241;
 Sat, 15 Oct 2022 05:08:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPK-00069z-Pv
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:22 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 614f132d-4c47-11ed-8fd0-01056ac49cbb;
 Sat, 15 Oct 2022 07:08:20 +0200 (CEST)
Received: from DS7PR05CA0102.namprd05.prod.outlook.com (2603:10b6:8:56::22) by
 PH8PR12MB6938.namprd12.prod.outlook.com (2603:10b6:510:1bd::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.21; Sat, 15 Oct 2022 05:08:14 +0000
Received: from DM6NAM11FT034.eop-nam11.prod.protection.outlook.com
 (2603:10b6:8:56:cafe::65) by DS7PR05CA0102.outlook.office365.com
 (2603:10b6:8:56::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.8 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:14 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT034.mail.protection.outlook.com (10.13.173.47) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Sat, 15 Oct 2022 05:08:14 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:14 -0500
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:13 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 614f132d-4c47-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UnAPJgoGSTmlEeb/+g+WCQZsuL15QSKDzRod2J7y3PmuwhWOR/wgVXFZExIRdDbnlH4nTEErhlwHRVRUGh76A6mQPnhVtKdZIy0ICk2nBNNaoPZZaW2EyyiK2d1GgBbAgCtik1J6LSUmu1Ss3+rnYwmIVSIU3aEbV2pNTX1TcTDzbqC0iVmLhf8owFMUl4c/SCmrMPgivFY8khtP1klpjpW3ef/QpW4XroEhjA87nLQ6ZwVXwKQ4evFIXwk6IgcGEs518PByFJwRLIdtsi1UAs5MBm0bwIRMGlfiqMoAM7skniWEzracEO3rtD462VPPPpFU3KGGdTY0RyCw8GNGJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pAQjlB7HyLijB3e709Vr7QvA7lbuariOB/trgP6DhHw=;
 b=I7lu8yLutpyjXyCOWt+FvnOW0wjMx7fSw1w+JirPX5QvRyoVd9LDiK0dfF1dHH98xvBVxvkXeLOT0G4U7KFouNTw4wf7dd6cFXMADXIKhRHXQ4NKM7vmRiXNJj9B3iK8aMwPuguJQGOZoOnwOuKosFhemkjbeOcBPJtEEGF+fQG84RzaAhlBLWPvjTQaeUK062P5p0A8TSE6Qfsq+8BGDPtUCZYWLwq6oSkhakpjb68uQtSlabh7su8KLgqyHHIGKCMRiOLCnSnfVXGSuj/6yYbRjdRiQdI57s47uE4WuEMAn697POkCbR9dcBuPVs0qV5Bt62lvSCQi0+f67UBv2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pAQjlB7HyLijB3e709Vr7QvA7lbuariOB/trgP6DhHw=;
 b=gNWpTTc2X0P77XawvBXjyo5bABbjESp8JCHWQ46dhoOEEd0z8sxBRgPO7uWGqO1/7F9VIWnMx4Jow39RDjjBREdn3K1FrCKKOMb6A3WkZKCnttllWvXVF8EzKw3SgWka2i+FbL9mxG/Wq9IXVGYdcxbuE0cDP2oaP+jPH2NHdiI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub
Date: Fri, 14 Oct 2022 22:07:39 -0700
Message-ID: <20221015050750.4185-2-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT034:EE_|PH8PR12MB6938:EE_
X-MS-Office365-Filtering-Correlation-Id: 12cca009-9216-4280-9b60-08daae6b43c4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0Rnh+Q9j0NujYd4j95jGB26ZG+JYfjQE2/aLWnA+rA27CTHSEqvquEdHWVAyQBG6koPEv4pP4m4m/BG9C8nFkQ7sG+K2TInaoWdRCncVG37U14OJ6tqobO2PNCddWRj97FVw4TC25sD4fdq02THcDpcpBBr5Id29knpfHoK37Rh2ViQGEfd4UrioX9UmmkUP5h2J8GI1SWwyqgNJA/mzGFchDbusQK1GY+pr0ejk3fDw9+tlEGnSRIMzFpCsO/kYp0i1FFSXquBfSDYx2+KYI8B8aRFbMOP97B3lcIrNbmcXGnwx/4oA4xN/TljP128ahE2+rnJHCKBkoUftiSxvVkRMxfABTs2M0Fv8a2TB57s6xDkqKVIiAhr+xlXO9ZuSDq4ZKhHXaCgWv6KrryvsdUsImy6FzhYdd0LTc09jxkHDoJWoKh6Un/En21EbmUSnzS4w7kr9Rxqqu9Rz1LfXAaCzjRm6TlIaNYDLDjf6Z7m2DfynmICL3Xt4aQznC+HJmHEjoq7O8DGz9FAoqj+HcdlOilI+6qeWoucJvVMnuNrXKQAT3Ko8t7qc+yruTFA4hFZkXyFHueIC5dshuVeljyUa5L6two0yWJKqDLG48Udw9bKYHl5+icT9NhDRoTdGSJ6bzR12r9VdHsB6Z8ebyUWsZ4TZS+JL9Vq5u3tctD54/8QD8BpCHYqj3KNWVb4ffhWqIV8biSBWCpE05eSjEs4fkU4Hck4UNPaLj6frUQPfyoMs0uABqGWrhVDnz2lF4eSDnEofuVGEI5QkeMD46z7yFsfQRFv1ryrdeyHzvYtVbldSF3ZsRmFyar9l21o9
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(2616005)(336012)(186003)(1076003)(83380400001)(356005)(81166007)(426003)(36860700001)(82740400003)(47076005)(5660300002)(4744005)(40460700003)(41300700001)(40480700001)(2906002)(8676002)(26005)(6916009)(70586007)(6666004)(8936002)(82310400005)(316002)(4326008)(54906003)(70206006)(44832011)(478600001)(36756003)(86362001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:14.7101
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 12cca009-9216-4280-9b60-08daae6b43c4
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT034.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6938

Build fails when have_xen_pci_passthrough is disabled. This is because of
incorrect build configuration for xen_pt_stub.c.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
---
 hw/xen/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index 08dc1f6857..ae0ace3046 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -18,7 +18,7 @@ if have_xen_pci_passthrough
     'xen_pt_msi.c',
   ))
 else
-  xen_specific_ss.add('xen_pt_stub.c')
+  xen_specific_ss.add(files('xen_pt_stub.c'))
 endif
 
 specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423244.669840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPe-00072L-TW; Sat, 15 Oct 2022 05:08:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423244.669840; Sat, 15 Oct 2022 05:08:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPe-00072E-QR; Sat, 15 Oct 2022 05:08:42 +0000
Received: by outflank-mailman (input) for mailman id 423244;
 Sat, 15 Oct 2022 05:08:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPd-00070V-3e
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:41 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2046.outbound.protection.outlook.com [40.107.95.46])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d42b266-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:39 +0200 (CEST)
Received: from DS7PR07CA0002.namprd07.prod.outlook.com (2603:10b6:5:3af::8) by
 BL1PR12MB5047.namprd12.prod.outlook.com (2603:10b6:208:31a::6) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.29; Sat, 15 Oct 2022 05:08:35 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::ad) by DS7PR07CA0002.outlook.office365.com
 (2603:10b6:5:3af::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:35 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:34 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:33 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 22:08:16 -0700
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:16 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d42b266-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U+AE3OkgPbwBfj3t38zglfg/PDpZgKrbjJ0KLaYq1QYXjtcBvCq/kTFbd3vVeYiP7e+MFm2yCNd3lBF6gfGqjUaF3ceYMF6k3/buQYJWxrdhZQWElrL0y0/V1bKmXv3xIQZT6a83ljaJsvR/IBFHaaHhKLVUKvLKONJEuZpCp7jY59+z7MbfmEwu2gwoqela1hU8f4t5Vmbd6aBp6iGd7JW+D85U7d7NF3tm9RBB4tLdC7KlYt+88uUvBMZJkFQmsfc1BdAe7Qiu54D5L58oOhfh6GFMyFAF7pLz7Gb2bvZmGJTiR1e2kc57pMsaW9qQJkOOceVLG2NklJhQ4Za3NQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LGGPbwlxtXacFwh2uK/QMY1MogeH7b96FjloSfMq4Q8=;
 b=m1E/ZGdAAjc275Ev1alZUXLG6u+5oLL/A9zn6Bo7Z7fr2Mq8m7hOCQSm2nZcd7KYeBO2qjeuxa52wfqMeZXtBKG2C11cJn6k/eAadTn0WwL1YRjYnXAnzp5zvkl60fgJTjbV9bhQL6hWKEwUqbt/pW9rFQOl+S6/w5Xts2ljuokkPoMuz5q4LuppHAypv7Mlc47Y4+BvR/PkjVhOhoxFDHNnSCICy2VKXeRtfdAN9ng3l6JyXKleSa9FW9EiPKQumXIJRT5qfkKn0W40bkxb47acDIb988EysAsjPQIQ9CDp/AmVj7T7fetTrKHNb4zVHTqqoijRqUb5BiLFrWD8mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LGGPbwlxtXacFwh2uK/QMY1MogeH7b96FjloSfMq4Q8=;
 b=CAFrhLZ0X1uuFuuzW4EiU2BkQPg87AQvelymr6lx8v0ci65rV8WDw1sFro1E6TzlXO+rhw+5UZwl2bumpVUSkfq83junuZF5+2oWpbQUuSPIioJMGZJo0WiRXjxXKKMQmetEP2+U16CbmXveRNUxIh+tuZdqaqyivk9IAym43HM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, Paolo Bonzini <pbonzini@redhat.com>, "Richard
 Henderson" <richard.henderson@linaro.org>, Eduardo Habkost
	<eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, "Marcel
 Apfelbaum" <marcel.apfelbaum@gmail.com>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 03/12] hw/i386/xen: rearrange xen_hvm_init_pc
Date: Fri, 14 Oct 2022 22:07:41 -0700
Message-ID: <20221015050750.4185-4-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|BL1PR12MB5047:EE_
X-MS-Office365-Filtering-Correlation-Id: 4a8883f7-e004-4919-c63c-08daae6b4faa
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o9TV7nhnl0o+h+uJL8TgzZBIceQA5JP0h5HTBdDcx3jk2o0jWbcRTzoFDqtFh5VJm0ox7kULqFxsNlQaENR8t6EjpeqOeb6C2fJHqOU/ZN5SmwGm/gag5WENXNVHV9mXU11HibAWFoI8ulIPyvFU06NYndX4vNk33c0zpZ4J7PXzseKntcC6MwyPS219ThW+B8TQCxyh8NG+xxEz4oP+wFBDjxHx80iLsXJQ5Gw1kRfg2YAfXq4VL8KsJ4SvnhlMi9vmR+FNEuoKPVdKl4NFZjbVsw5pBXYQz9bElc2++q9ApgiV1u1BnA77/rkESrJirOsTeDlGrvHlll4C1q/SzshULTPuZ5MNZB/YadHSXVsQvGWGNjyOQDjXq9wDluVXm8Z8iRo0Pi1nES50a1BbSeI2FgCK+P4ewn8o+NLbPV0AU4ywjbvFjIuejTFBpy6l1VtcDSEKbmJOooKSJwrU8n33rroZR7hKpqkA9P782nCA6Y2INiVlAvSh+pynf+cuMYoFEhOuX4moTQPmBaLDE0y9UqAJLeZSp2UT2R7OwtkQTOS6+202jQc/jObgHG8MNpr/zrdy3+C2HjTbJz3pTjXkV1IbSi3If63fRBcD0JvCdMw4WcEg5CgxGRCBMYfywxOG+gHK4VvuNEtBsW3JW/y2I8AZLnC46G1pOGbj96099eYwABE9Za85chPsxANX9nn5kVHLobrRu69VXV6URbWb2rVmxEfswVHuf3iyHumfFmEyWqC+tfWIFXY9UtepYaSQJm9oxFNR98Hrzedf06p1LG7mqrbC8Nq3ukXZ7ZaUJoKxFK3BWebz72INkKOi
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(40470700004)(36840700001)(46966006)(5660300002)(1076003)(336012)(7416002)(426003)(44832011)(186003)(2616005)(2906002)(41300700001)(8936002)(356005)(47076005)(81166007)(82740400003)(82310400005)(40480700001)(86362001)(36756003)(40460700003)(26005)(83380400001)(36860700001)(54906003)(478600001)(316002)(6916009)(6666004)(4326008)(8676002)(70206006)(70586007)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:34.5953
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a8883f7-e004-4919-c63c-08daae6b4faa
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5047

In preparation to moving most of xen-hvm code to an arch-neutral location,
move non IOREQ references to:
- xen_get_vmport_regs_pfn
- xen_suspend_notifier
- xen_wakeup_notifier
- xen_ram_init

towards the end of the xen_hvm_init_pc() function.

This is done to keep the common ioreq functions in one place which will be
moved to new function in next patch in order to make it common to both x86 and
aarch64 machines.

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 hw/i386/xen/xen-hvm.c | 49 ++++++++++++++++++++++---------------------
 1 file changed, 25 insertions(+), 24 deletions(-)

diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index e4293d6d66..b27484ad22 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -1416,12 +1416,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
     state->exit.notify = xen_exit_notifier;
     qemu_add_exit_notifier(&state->exit);
 
-    state->suspend.notify = xen_suspend_notifier;
-    qemu_register_suspend_notifier(&state->suspend);
-
-    state->wakeup.notify = xen_wakeup_notifier;
-    qemu_register_wakeup_notifier(&state->wakeup);
-
     /*
      * Register wake-up support in QMP query-current-machine API
      */
@@ -1432,23 +1426,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
         goto err;
     }
 
-    rc = xen_get_vmport_regs_pfn(xen_xc, xen_domid, &ioreq_pfn);
-    if (!rc) {
-        DPRINTF("shared vmport page at pfn %lx\n", ioreq_pfn);
-        state->shared_vmport_page =
-            xenforeignmemory_map(xen_fmem, xen_domid, PROT_READ|PROT_WRITE,
-                                 1, &ioreq_pfn, NULL);
-        if (state->shared_vmport_page == NULL) {
-            error_report("map shared vmport IO page returned error %d handle=%p",
-                         errno, xen_xc);
-            goto err;
-        }
-    } else if (rc != -ENOSYS) {
-        error_report("get vmport regs pfn returned error %d, rc=%d",
-                     errno, rc);
-        goto err;
-    }
-
     /* Note: cpus is empty at this point in init */
     state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus);
 
@@ -1486,7 +1463,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
 #else
     xen_map_cache_init(NULL, state);
 #endif
-    xen_ram_init(pcms, ms->ram_size, ram_memory);
 
     qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
 
@@ -1513,6 +1489,31 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
     QLIST_INIT(&xen_physmap);
     xen_read_physmap(state);
 
+    state->suspend.notify = xen_suspend_notifier;
+    qemu_register_suspend_notifier(&state->suspend);
+
+    state->wakeup.notify = xen_wakeup_notifier;
+    qemu_register_wakeup_notifier(&state->wakeup);
+
+    rc = xen_get_vmport_regs_pfn(xen_xc, xen_domid, &ioreq_pfn);
+    if (!rc) {
+        DPRINTF("shared vmport page at pfn %lx\n", ioreq_pfn);
+        state->shared_vmport_page =
+            xenforeignmemory_map(xen_fmem, xen_domid, PROT_READ|PROT_WRITE,
+                                 1, &ioreq_pfn, NULL);
+        if (state->shared_vmport_page == NULL) {
+            error_report("map shared vmport IO page returned error %d handle=%p",
+                         errno, xen_xc);
+            goto err;
+        }
+    } else if (rc != -ENOSYS) {
+        error_report("get vmport regs pfn returned error %d, rc=%d",
+                     errno, rc);
+        goto err;
+    }
+
+    xen_ram_init(pcms, ms->ram_size, ram_memory);
+
     /* Disable ACPI build because Xen handles it */
     pcms->acpi_build_enabled = false;
 
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423246.669851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPh-0007L1-9u; Sat, 15 Oct 2022 05:08:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423246.669851; Sat, 15 Oct 2022 05:08:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPh-0007Kr-5X; Sat, 15 Oct 2022 05:08:45 +0000
Received: by outflank-mailman (input) for mailman id 423246;
 Sat, 15 Oct 2022 05:08:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPe-00070V-VK
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:42 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2046.outbound.protection.outlook.com [40.107.95.46])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6eb883b0-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:41 +0200 (CEST)
Received: from DS7PR07CA0024.namprd07.prod.outlook.com (2603:10b6:5:3af::6) by
 MN2PR12MB4189.namprd12.prod.outlook.com (2603:10b6:208:1d8::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Sat, 15 Oct
 2022 05:08:37 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::35) by DS7PR07CA0024.outlook.office365.com
 (2603:10b6:5:3af::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:37 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:36 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:34 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 22:08:19 -0700
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:18 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6eb883b0-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jjuDUwzM4P8rdlW/Q59R3VctBTf3fSxrkjAaDuyfIIOPHgNyuE8aiajZ3pfS+IPQ/oDBwOSJhwkyX1HvGqPYOCf0TRzwcNAX1uSkeX1BGV2tLGjzZKTzcuU4UnStnJi0lIJIpujAYtzF5KYucblHCFdi9/jtTYZuRLCEN7RmZtOag36l10t7iA5VjToKZDSBoAhk2zxWSOB3XU3/fNM7zBgGh/J5bt5mZ66Eql4FaEN4ORbHFaOjlDrvo+7HK4eMvpuTQM2zjtmF1SPpfpJk61sm8sRAZcm7W8L5i+ECZeFuEdMtGVwS/D19RfnMO0WiBZ04LWmgHZUTK07NSIRY3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X1NjHZ0yK62G8GNTviz6TNax2Ydr/8jixQjnLhYwxRk=;
 b=b6KRnSiF04SkRJHWN0y8HaSpfmgjPMl+ue+BHfKFkGWVluDdfnFw5EgO88WU9NfRoncW1SRkBitkzfg3KXij9D/0xdPPXEgTIrzl8wBA9CEsnyn94+9oQ62+k5d3B7Z5zQICkFsIeHdk+zGk9hpRdrahABQ22cItApSR68QqPQ6SQp9XOPvS4LlqDNzafQuZZ3hgNVu5dTuA+oO3HobL2yNUKpV6VcQH1YINz9Yl8P/M8lrenHpuHfmh/tAj6NX/ORHsJGg64DCzSntreCip6oBU93o5mApQvE+C++Wb7/xIrcEYG+47nV3CNZPCIo34VfUJGQFk0OCXXtVcMo3jkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=X1NjHZ0yK62G8GNTviz6TNax2Ydr/8jixQjnLhYwxRk=;
 b=VyHrTKyxgfHrV7MfmlaMcln28pd8M6hHs5jNvzd1xYOGkHkKrQ6y05Kvegwo+ce1GCSzmRcqh37wfER0igSRaiI+0mx0ObGvPwMZAw4fz6aTKDYdJ1SjHI7zTtP5Qxy5jk13aHk4BaSpzZXldBDP9BoPBe1EkQHpUkAiP0Z1IGs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Marcel
 Apfelbaum" <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost
	<eduardo@habkost.net>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq and arch_xen_set_memory
Date: Fri, 14 Oct 2022 22:07:43 -0700
Message-ID: <20221015050750.4185-6-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|MN2PR12MB4189:EE_
X-MS-Office365-Filtering-Correlation-Id: 6b0db0a7-9113-42c1-03d1-08daae6b510e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OpAkJZDynduWIcH8nKIzHHqOevCssvJYuJ7dOPT+tivdqhoButvdm8LsQKaMOmVXWJeEJH9fOyX+2XDih8/6NN8yqbovlH9VnLKsX78F+CmTI3gCJA2dlFlRK3+/nR9dVfBv7/MQMi9GOLvjrrAxGLV//6lpaem2bp4aCJVKa0PnSJUEScNaLqew1wz8Q10KYoNFlCSXN3t8sc/Q95/LIEUNlsQ8Rmx8IUOdJCFM4Z2G5uEWf+qmL6tGT0WpZP31cYDd6DhQBsa8d7psqeFHHMaSv9nBqMcX0XtnULriK1ECgOq8gJXoxkXNj1NFNAj+FA2kiwyCubdmUBhzEv53XkUn69Twbw4R1v5cvq+CYLG4DNRGW64ihzOnQAlL6EAHqQLQSIWPeCRhpJZknS1ZcgN8/nSYPVpgM3rO6FuzyB+Atx5C2XIkpakSs9TOsBfQkNM7dYbjISgX20wtWgzVC1PAeztXm467cSDUU5I5TeF3E6u3kyK+PaGLwS1R/6AW7832t9D7N2t1cSELZuEjBAeh21y9b4VgF8eJSj3z+Wjr4dgLt/J4gJkocXC6iXGIOdpT0UZmSV8Wfxu4noxfG+HvNr3DAjRRcsHZSTJcwKjYhKlfTqZPe5MIzZCkwQ9wedlbai6+kS4DyOKKaI0K45cBU9FOg4sHQXh7i2zFevovOYetlGyWJZIaEua0gSJJUMv+jWDEKhhcmjnnw7VToX42T2zMrsXwZ4QBKcHWan7I0rODMR4w5yyPLacfrRKenK05vCUIdPGR5eq7j3nMHFbxDcqQ4CzRoUS4P2i/xBWvcV4n1zRHBI8zziYMCQLi
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(336012)(44832011)(7416002)(186003)(5660300002)(8936002)(2906002)(2616005)(1076003)(26005)(41300700001)(356005)(82310400005)(81166007)(82740400003)(86362001)(40460700003)(40480700001)(83380400001)(47076005)(426003)(36756003)(36860700001)(316002)(478600001)(6916009)(54906003)(6666004)(8676002)(4326008)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:36.9234
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b0db0a7-9113-42c1-03d1-08daae6b510e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4189

From: Stefano Stabellini <stefano.stabellini@amd.com>

In preparation to moving most of xen-hvm code to an arch-neutral location,
move the x86-specific portion of xen_set_memory to arch_xen_set_memory.

Also move handle_vmport_ioreq to arch_handle_ioreq.

NOTE: This patch breaks the build. Next patch fixes the build issue.
Reason behind creating this patch is because there is lot of new code addition
and pure code movement done for enabling Xen on ARM. Keeping the this patch
separate is done to make it easier to review.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
---
 hw/i386/xen/xen-hvm.c          | 97 ++++++++++++++++++++--------------
 include/hw/i386/xen_arch_hvm.h | 10 ++++
 include/hw/xen/arch_hvm.h      |  3 ++
 3 files changed, 70 insertions(+), 40 deletions(-)
 create mode 100644 include/hw/i386/xen_arch_hvm.h
 create mode 100644 include/hw/xen/arch_hvm.h

diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index e169de16c4..3cd1808f9d 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -34,6 +34,7 @@
 #include "trace.h"
 
 #include <xen/hvm/ioreq.h>
+#include "hw/xen/arch_hvm.h"
 #include <xen/hvm/e820.h>
 
 //#define DEBUG_XEN_HVM
@@ -476,10 +477,6 @@ static void xen_set_memory(struct MemoryListener *listener,
                            bool add)
 {
     XenIOState *state = container_of(listener, XenIOState, memory_listener);
-    hwaddr start_addr = section->offset_within_address_space;
-    ram_addr_t size = int128_get64(section->size);
-    bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA);
-    hvmmem_type_t mem_type;
 
     if (section->mr == &ram_memory) {
         return;
@@ -492,38 +489,7 @@ static void xen_set_memory(struct MemoryListener *listener,
                                      section);
         }
     }
-
-    if (!memory_region_is_ram(section->mr)) {
-        return;
-    }
-
-    if (log_dirty != add) {
-        return;
-    }
-
-    trace_xen_client_set_memory(start_addr, size, log_dirty);
-
-    start_addr &= TARGET_PAGE_MASK;
-    size = TARGET_PAGE_ALIGN(size);
-
-    if (add) {
-        if (!memory_region_is_rom(section->mr)) {
-            xen_add_to_physmap(state, start_addr, size,
-                               section->mr, section->offset_within_region);
-        } else {
-            mem_type = HVMMEM_ram_ro;
-            if (xen_set_mem_type(xen_domid, mem_type,
-                                 start_addr >> TARGET_PAGE_BITS,
-                                 size >> TARGET_PAGE_BITS)) {
-                DPRINTF("xen_set_mem_type error, addr: "TARGET_FMT_plx"\n",
-                        start_addr);
-            }
-        }
-    } else {
-        if (xen_remove_from_physmap(state, start_addr, size) < 0) {
-            DPRINTF("physmapping does not exist at "TARGET_FMT_plx"\n", start_addr);
-        }
-    }
+    arch_xen_set_memory(state, section, add);
 }
 
 static void xen_region_add(MemoryListener *listener,
@@ -1051,9 +1017,6 @@ static void handle_ioreq(XenIOState *state, ioreq_t *req)
         case IOREQ_TYPE_COPY:
             cpu_ioreq_move(req);
             break;
-        case IOREQ_TYPE_VMWARE_PORT:
-            handle_vmport_ioreq(state, req);
-            break;
         case IOREQ_TYPE_TIMEOFFSET:
             break;
         case IOREQ_TYPE_INVALIDATE:
@@ -1063,7 +1026,7 @@ static void handle_ioreq(XenIOState *state, ioreq_t *req)
             cpu_ioreq_config(state, req);
             break;
         default:
-            hw_error("Invalid ioreq type 0x%x\n", req->type);
+            arch_handle_ioreq(state, req);
     }
     if (req->dir == IOREQ_READ) {
         trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr,
@@ -1604,3 +1567,57 @@ void qmp_xen_set_global_dirty_log(bool enable, Error **errp)
         memory_global_dirty_log_stop(GLOBAL_DIRTY_MIGRATION);
     }
 }
+
+void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section,
+                                bool add)
+{
+    hwaddr start_addr = section->offset_within_address_space;
+    ram_addr_t size = int128_get64(section->size);
+    bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA);
+    hvmmem_type_t mem_type;
+
+    if (!memory_region_is_ram(section->mr)) {
+        return;
+    }
+
+    if (log_dirty != add) {
+        return;
+    }
+
+    trace_xen_client_set_memory(start_addr, size, log_dirty);
+
+    start_addr &= TARGET_PAGE_MASK;
+    size = TARGET_PAGE_ALIGN(size);
+
+    if (add) {
+        if (!memory_region_is_rom(section->mr)) {
+            xen_add_to_physmap(state, start_addr, size,
+                               section->mr, section->offset_within_region);
+        } else {
+            mem_type = HVMMEM_ram_ro;
+            if (xen_set_mem_type(xen_domid, mem_type,
+                                 start_addr >> TARGET_PAGE_BITS,
+                                 size >> TARGET_PAGE_BITS)) {
+                DPRINTF("xen_set_mem_type error, addr: "TARGET_FMT_plx"\n",
+                        start_addr);
+            }
+        }
+    } else {
+        if (xen_remove_from_physmap(state, start_addr, size) < 0) {
+            DPRINTF("physmapping does not exist at "TARGET_FMT_plx"\n", start_addr);
+        }
+    }
+}
+
+void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
+{
+    switch (req->type) {
+    case IOREQ_TYPE_VMWARE_PORT:
+            handle_vmport_ioreq(state, req);
+        break;
+    default:
+        hw_error("Invalid ioreq type 0x%x\n", req->type);
+    }
+
+    return;
+}
diff --git a/include/hw/i386/xen_arch_hvm.h b/include/hw/i386/xen_arch_hvm.h
new file mode 100644
index 0000000000..1b2c71ba4f
--- /dev/null
+++ b/include/hw/i386/xen_arch_hvm.h
@@ -0,0 +1,10 @@
+#ifndef HW_XEN_ARCH_I386_HVM_H
+#define HW_XEN_ARCH_I386_HVM_H
+
+#include <xen/hvm/ioreq.h>
+
+void arch_handle_ioreq(XenIOState *state, ioreq_t *req);
+void arch_xen_set_memory(XenIOState *state,
+                         MemoryRegionSection *section,
+                         bool add);
+#endif
diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
new file mode 100644
index 0000000000..26674648d8
--- /dev/null
+++ b/include/hw/xen/arch_hvm.h
@@ -0,0 +1,3 @@
+#if defined(TARGET_I386) || defined(TARGET_X86_64)
+#include "hw/i386/xen_arch_hvm.h"
+#endif
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423248.669857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPh-0007OZ-MF; Sat, 15 Oct 2022 05:08:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423248.669857; Sat, 15 Oct 2022 05:08:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPh-0007NY-GB; Sat, 15 Oct 2022 05:08:45 +0000
Received: by outflank-mailman (input) for mailman id 423248;
 Sat, 15 Oct 2022 05:08:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPf-00070V-SC
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:43 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2075.outbound.protection.outlook.com [40.107.94.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6eae5015-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:41 +0200 (CEST)
Received: from DS7PR07CA0002.namprd07.prod.outlook.com (2603:10b6:5:3af::8) by
 CH2PR12MB4053.namprd12.prod.outlook.com (2603:10b6:610:7c::10) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.30; Sat, 15 Oct 2022 05:08:36 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::ad) by DS7PR07CA0002.outlook.office365.com
 (2603:10b6:5:3af::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:35 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:35 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:34 -0500
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:34 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6eae5015-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QQwig5LE3qYkyH+Zs4g5Yf5AJ8bz0H1fZbOcCf2bYYtwpKXKe+SwjhAug1SyR9eOOn/SU08ZuBH3MR8XStTZVoOvUrP+WwcVgVs0dGRhbu2XsyrMZAMDpo8v/E3gnDlCJzQJN/iREu7CXIBVs9ulZR2/X43K8qBaQLdn0p49N0RpkUyrADQtUoCG515kdr/oW8BqnwbBsWZ4FVk6wkjSdT+eEbXyl4kj7uvz+BMm/gR3JLdTciO1BJME8FNUETIobT9uoVLqvZs3QrHjAUiRtXk60TpSZsZuf6x4pLPRC6PGSpLkJqGSqiKlyKCLGhI3WrEtsNWWbhJ/Bdb+imqlDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QFQAI2p5Tya+5yrK89aiCN3h+euzdMm2LiqHr9x0Cpc=;
 b=FPLkwTlDlTkvAlihRWiRfBICU+tLhO+0F6BkExYesAkQSEnbsI8ylPyI9r5hGBiVTubPfTMAOWa8r8oeAf+ueju9aGV7O0nr/xeJuNYVaYJJKoM+OdrEaIJb1FcfuTQbOm2OVSvnO4hUtbsbtROne69za73mU4y1YlfINeo2IWy/s3jGshqDjrJcscB06r4R7OMucmW6QfW6iE2Ke4umaDwBdUTiFBvCg6SjmQdefiMViEm8M68YhgDjd7PrtWFC7+3uBmy2BrBa82OVvb3cbvSFOQP9vTdmEC90FyjmAeBsmRP9SmAOBK/XGB94PNKZVFbxZi1MJCIJfgE/caNkmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QFQAI2p5Tya+5yrK89aiCN3h+euzdMm2LiqHr9x0Cpc=;
 b=AD/v2pdEmH3z92Go3umdS1ZwEdytJR3K6iW3Bqj0dKyF4ysAmOasTHLxNKp9dL8LMc7i8zKmH2Be1jrFPeblW4nICFcCaOn9kJhuv4eiSZuAdNrJbmHnhX2KzhJ+4vJRzh5MOq90UqAJe55Xnc25uPZqDDBd37tIYc+rwycgQLc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 07/12] include/hw/xen/xen_common: return error from xen_create_ioreq_server
Date: Fri, 14 Oct 2022 22:07:45 -0700
Message-ID: <20221015050750.4185-8-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|CH2PR12MB4053:EE_
X-MS-Office365-Filtering-Correlation-Id: 544ca10f-8663-44a2-6e96-08daae6b5056
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	g1U/jh2twbv/U7qA+o2amqNk7CbY3U65s03Lo7Wt4Tu3ZnrW5j93TtMyJ2cmy5/ErYC7x22HX5Y2VxXK507v79TIJ6qavGvvQqWPIpN1rAcSrnCOn0y4tXf3fUMED7f+0tLVILAZ6mOEKyWk+/tAyG0jrmjfaEHuZLHbpohXvltkbnwE/yKCM7yx3NmJGhtso7FPfJnJVpHSfiBn5rDnLjpXwKVb0kMxvjsFBsREpWr+0Gs0F8zGT18yP2bJ7ZfESwRCwK08K/oKKx6O5c/mDbTfLScAnTjKuEOhWGTjX/21pb15CDzijuP5SRQYjdGrwCAo38tbDYdDvHb55KuwJuljhwyzHD/L3mTXgLtJaxQ+wstHqnJ+MDopHrMZ2kE5Thff0wszVR1kLRYOMq7y+YN2Fp+I7LPGkXlJ0jAiLw8zi+yyV3e+HAjCghXrcx1Lcaxj7p+1BxgNqfEGTKfwE0fyIPyfTDOzyg1RksaaUFtI3uV9hJUe/ib4CFKRvgo7GNcNojTJnSCKpRVl1dclKoiwD2oqMiefmCI2vBq9uCwfC4sUtrGqeBSjsT4XyWCB1bh8AfN6FVJbSOzc1Y0iNsDURnvLu+MihNWtoDESTWyTupm0hL9xmnF865UU9RXV/ZayFT3GZiNV9CrFN5kZeb7g11uvwwIvm/bP4ZdNQEzNC29vAvDZQs5ygi0DLurw7cCh1do3rukBM2CWaAm8Agh/nYO657SjmJB0/9iUdYV++ndPdEsuw5u51nHfCbdsN+MEhwnMbEvpkhjpKvEsqJqMkegngXYr8AtJeuHJltSrLiGtz04gCXs+3L7gZXeJ
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(86362001)(36756003)(356005)(81166007)(82740400003)(2906002)(47076005)(426003)(40460700003)(186003)(6666004)(5660300002)(40480700001)(44832011)(1076003)(26005)(2616005)(36860700001)(336012)(83380400001)(82310400005)(316002)(478600001)(4326008)(54906003)(6916009)(70206006)(70586007)(8676002)(41300700001)(8936002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:35.7203
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 544ca10f-8663-44a2-6e96-08daae6b5056
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4053

From: Stefano Stabellini <stefano.stabellini@amd.com>

This is done to prepare for enabling xenpv support for ARM architecture.
On ARM it is possible to have a functioning xenpv machine with only the
PV backends and no IOREQ server. If the IOREQ server creation fails,
continue to the PV backends initialization.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 include/hw/xen/xen_common.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
index 77ce17d8a4..c2d2f36bde 100644
--- a/include/hw/xen/xen_common.h
+++ b/include/hw/xen/xen_common.h
@@ -467,8 +467,8 @@ static inline void xen_unmap_pcidev(domid_t dom,
 {
 }
 
-static inline void xen_create_ioreq_server(domid_t dom,
-                                           ioservid_t *ioservid)
+static inline int xen_create_ioreq_server(domid_t dom,
+                                          ioservid_t *ioservid)
 {
 }
 
@@ -600,8 +600,8 @@ static inline void xen_unmap_pcidev(domid_t dom,
                                                   PCI_FUNC(pci_dev->devfn));
 }
 
-static inline void xen_create_ioreq_server(domid_t dom,
-                                           ioservid_t *ioservid)
+static inline int xen_create_ioreq_server(domid_t dom,
+                                          ioservid_t *ioservid)
 {
     int rc = xendevicemodel_create_ioreq_server(xen_dmod, dom,
                                                 HVM_IOREQSRV_BUFIOREQ_ATOMIC,
@@ -609,12 +609,14 @@ static inline void xen_create_ioreq_server(domid_t dom,
 
     if (rc == 0) {
         trace_xen_ioreq_server_create(*ioservid);
-        return;
+        return rc;
     }
 
     *ioservid = 0;
     use_default_ioreq_server = true;
     trace_xen_default_ioreq_server();
+
+    return rc;
 }
 
 static inline void xen_destroy_ioreq_server(domid_t dom,
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423250.669875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPj-0007qO-Ap; Sat, 15 Oct 2022 05:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423250.669875; Sat, 15 Oct 2022 05:08:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPj-0007pZ-0D; Sat, 15 Oct 2022 05:08:47 +0000
Received: by outflank-mailman (input) for mailman id 423250;
 Sat, 15 Oct 2022 05:08:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPg-00070V-SV
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:45 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ee54926-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:42 +0200 (CEST)
Received: from DS7PR07CA0020.namprd07.prod.outlook.com (2603:10b6:5:3af::12)
 by BL3PR12MB6380.namprd12.prod.outlook.com (2603:10b6:208:3b3::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sat, 15 Oct
 2022 05:08:36 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::64) by DS7PR07CA0020.outlook.office365.com
 (2603:10b6:5:3af::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:36 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:36 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:33 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 22:08:18 -0700
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:17 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ee54926-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hbTZoC9qo361KOmshfmjFTjFOiVfJ+rRC2Ad5Ei3wfxSm7gYYFSLZcgAPikg7QrikaleAgBDJ0/LURS7ZsU2M9kMY/N8R6E+DDlQWImycWY0AtrP69Gv7EBXOjiXDiVtR4fw/VdwcYfKcN3GJTe4KYGhCcxQTms1hgjRW/Wu1sfEVex9zH+g2RwFCW00csBrNZVJeaqshXf/sMl9x7ruJhZuvKmy4JRDvnHHpxTVpiyELInQrmBdidBY+ZIChXTJZSimwN46HIetexvcJkJba+gSPbroA39QSlh8x2u8d4de9VqSf+gQrr6L24mAjDOsKdQ+BmoZROVLQa0h+oLojw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JBycLvC7LfB4SZEL+ZgccbN3If0EIaDUN/ArGkdJ54Q=;
 b=BQXYcXEXqCnYhwPUfKv47+VMYkY8ny3loZRabuXJAGxHuQXOXF86K+B0cB/trlHGO3vBYyGvuucE859ovKi77iPsIUrqK0Iz/iMgJ44pYw4KxuwT3kBmohYZ1jJFDYMkYlaBjE7b+hpamzza4Jr8mLDoNmhmXb5S0WEOmq/hqDoFY1S3Xs3S/PS1QxTuIJb6vrRSZnIUY/C4agQ9t/UM0WXqnvSJnAckBr3XM2qBkDq9anLjmF18eHGXtqGYgNGGIiS6AqE8NGMXBjtzNvimQ+wfnMu3C24kMgSyrmx310O01tWaUAumxqaWLRneIY3FGJIzUMrzmB+xSH01WGhsGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JBycLvC7LfB4SZEL+ZgccbN3If0EIaDUN/ArGkdJ54Q=;
 b=Dn1GUUDac1z4o3ZQp9pjf7lV8SeziXBOsoP62j/7N1q3xa/B/6ualCDxbMx4XVvkNij2LNcDMpIRp6BQKf/UsnBs7MQchTAgDMkqkJved0uMbpVUjQOaL7eMraU6MeDbPipritMcwnfU+4IAg1FdrZBSGi43Bvs2bmORVIU8L4g=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Marcel
 Apfelbaum" <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost
	<eduardo@habkost.net>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState
Date: Fri, 14 Oct 2022 22:07:42 -0700
Message-ID: <20221015050750.4185-5-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|BL3PR12MB6380:EE_
X-MS-Office365-Filtering-Correlation-Id: a97f6924-b7f1-4fd8-e0e4-08daae6b50a9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	d/9dTt3/7dgKZBt4Hyt7p4YeP6377EqTF6lI2L2c/IZCIxQTg9OPfRHBzUDvUFCXnOeb415G+2oYK8Z9IWT4d1U1NgxcHzYcU/QVo5V47FRHCIp+WOxJ2gkP95Ab+Zor4Cj7j/2wmKlsBY26G2t+yVwbRpG+wNLNtgCrBzoSNgOTXiBOmK1f+oOX9zF8fZKvWZLvrs5ZF5+mAWy1nRJ2o3HyM/LIcPzY758EnMuJvb+j6aZSQ8zRT/SJ1fMhCAIDMgpJt5zreqQJfwSOv+Or4dJ2VVfKSn3RE0TZXHTCrXKmffF+Q8ohaBdN95fG/RmpF4ZXLzJw5OMQB2nbhSI8ignaTV4rFj9nR9YG8lhzf/hoQ3/wlFrTAsWgJcMghpGgJ3JmvUQkeohNle82/SjRrJ9coj3zZVg4YEWy5h7ahthRr0hWUAJFyXATk2fC2nWUoq61PgFXB8kjEsbdR4acVm+dN+/0Gnj1yw8N1blSQFhp9HLbE6uWjQdv76GikYcMl3F2s6GCQCt1HbsqZIa6PoWgrVJEztsFYlIHUNU3z+74V2mYwq2TUsAPaT/VzzXKhT40u6mrWgURX8G328Ic6zzRhLGlV2R0fKyVY4c77t1mjaXCELLnjdCMdEd+e0AkIso//8pVhzAcX1HJnkWWyd76fPYxkeZW8jTjLvxx1/jGPuoTQKcuFHMvwuAB1MdGvlofQXGuwJMtx1LtcmqbLP06iPh440CNq0aCv1RgjcuU2l4tqUIybMCaeu6fK12c3aiE3ljz1Ch4VJ9AjqkgpqsuwhJu+LD5t7EsAFv0LZc8yh15rcTnI1ZfBzUVnRq6
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(6916009)(426003)(7416002)(5660300002)(40480700001)(40460700003)(54906003)(186003)(1076003)(8936002)(356005)(81166007)(26005)(82310400005)(2906002)(86362001)(2616005)(41300700001)(336012)(478600001)(36756003)(82740400003)(4326008)(316002)(83380400001)(8676002)(70586007)(70206006)(44832011)(6666004)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:36.2672
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a97f6924-b7f1-4fd8-e0e4-08daae6b50a9
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6380

From: Stefano Stabellini <stefano.stabellini@amd.com>

In preparation to moving most of xen-hvm code to an arch-neutral location, move:
- shared_vmport_page
- log_for_dirtybit
- dirty_bitmap
- suspend
- wakeup

out of XenIOState struct as these are only used on x86, especially the ones
related to dirty logging.
Updated XenIOState can be used for both aarch64 and x86.

Also, remove free_phys_offset as it was unused.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
---
 hw/i386/xen/xen-hvm.c | 58 ++++++++++++++++++++-----------------------
 1 file changed, 27 insertions(+), 31 deletions(-)

diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index b27484ad22..e169de16c4 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -73,6 +73,7 @@ struct shared_vmport_iopage {
 };
 typedef struct shared_vmport_iopage shared_vmport_iopage_t;
 #endif
+static shared_vmport_iopage_t *shared_vmport_page;
 
 static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i)
 {
@@ -95,6 +96,11 @@ typedef struct XenPhysmap {
 } XenPhysmap;
 
 static QLIST_HEAD(, XenPhysmap) xen_physmap;
+static const XenPhysmap *log_for_dirtybit;
+/* Buffer used by xen_sync_dirty_bitmap */
+static unsigned long *dirty_bitmap;
+static Notifier suspend;
+static Notifier wakeup;
 
 typedef struct XenPciDevice {
     PCIDevice *pci_dev;
@@ -105,7 +111,6 @@ typedef struct XenPciDevice {
 typedef struct XenIOState {
     ioservid_t ioservid;
     shared_iopage_t *shared_page;
-    shared_vmport_iopage_t *shared_vmport_page;
     buffered_iopage_t *buffered_io_page;
     xenforeignmemory_resource_handle *fres;
     QEMUTimer *buffered_io_timer;
@@ -125,14 +130,8 @@ typedef struct XenIOState {
     MemoryListener io_listener;
     QLIST_HEAD(, XenPciDevice) dev_list;
     DeviceListener device_listener;
-    hwaddr free_phys_offset;
-    const XenPhysmap *log_for_dirtybit;
-    /* Buffer used by xen_sync_dirty_bitmap */
-    unsigned long *dirty_bitmap;
 
     Notifier exit;
-    Notifier suspend;
-    Notifier wakeup;
 } XenIOState;
 
 /* Xen specific function for piix pci */
@@ -462,10 +461,10 @@ static int xen_remove_from_physmap(XenIOState *state,
     }
 
     QLIST_REMOVE(physmap, list);
-    if (state->log_for_dirtybit == physmap) {
-        state->log_for_dirtybit = NULL;
-        g_free(state->dirty_bitmap);
-        state->dirty_bitmap = NULL;
+    if (log_for_dirtybit == physmap) {
+        log_for_dirtybit = NULL;
+        g_free(dirty_bitmap);
+        dirty_bitmap = NULL;
     }
     g_free(physmap);
 
@@ -626,16 +625,16 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
         return;
     }
 
-    if (state->log_for_dirtybit == NULL) {
-        state->log_for_dirtybit = physmap;
-        state->dirty_bitmap = g_new(unsigned long, bitmap_size);
-    } else if (state->log_for_dirtybit != physmap) {
+    if (log_for_dirtybit == NULL) {
+        log_for_dirtybit = physmap;
+        dirty_bitmap = g_new(unsigned long, bitmap_size);
+    } else if (log_for_dirtybit != physmap) {
         /* Only one range for dirty bitmap can be tracked. */
         return;
     }
 
     rc = xen_track_dirty_vram(xen_domid, start_addr >> TARGET_PAGE_BITS,
-                              npages, state->dirty_bitmap);
+                              npages, dirty_bitmap);
     if (rc < 0) {
 #ifndef ENODATA
 #define ENODATA  ENOENT
@@ -650,7 +649,7 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
     }
 
     for (i = 0; i < bitmap_size; i++) {
-        unsigned long map = state->dirty_bitmap[i];
+        unsigned long map = dirty_bitmap[i];
         while (map != 0) {
             j = ctzl(map);
             map &= ~(1ul << j);
@@ -676,12 +675,10 @@ static void xen_log_start(MemoryListener *listener,
 static void xen_log_stop(MemoryListener *listener, MemoryRegionSection *section,
                          int old, int new)
 {
-    XenIOState *state = container_of(listener, XenIOState, memory_listener);
-
     if (old & ~new & (1 << DIRTY_MEMORY_VGA)) {
-        state->log_for_dirtybit = NULL;
-        g_free(state->dirty_bitmap);
-        state->dirty_bitmap = NULL;
+        log_for_dirtybit = NULL;
+        g_free(dirty_bitmap);
+        dirty_bitmap = NULL;
         /* Disable dirty bit tracking */
         xen_track_dirty_vram(xen_domid, 0, 0, NULL);
     }
@@ -1021,9 +1018,9 @@ static void handle_vmport_ioreq(XenIOState *state, ioreq_t *req)
 {
     vmware_regs_t *vmport_regs;
 
-    assert(state->shared_vmport_page);
+    assert(shared_vmport_page);
     vmport_regs =
-        &state->shared_vmport_page->vcpu_vmport_regs[state->send_vcpu];
+        &shared_vmport_page->vcpu_vmport_regs[state->send_vcpu];
     QEMU_BUILD_BUG_ON(sizeof(*req) < sizeof(*vmport_regs));
 
     current_cpu = state->cpu_by_vcpu_id[state->send_vcpu];
@@ -1468,7 +1465,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
 
     state->memory_listener = xen_memory_listener;
     memory_listener_register(&state->memory_listener, &address_space_memory);
-    state->log_for_dirtybit = NULL;
 
     state->io_listener = xen_io_listener;
     memory_listener_register(&state->io_listener, &address_space_io);
@@ -1489,19 +1485,19 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
     QLIST_INIT(&xen_physmap);
     xen_read_physmap(state);
 
-    state->suspend.notify = xen_suspend_notifier;
-    qemu_register_suspend_notifier(&state->suspend);
+    suspend.notify = xen_suspend_notifier;
+    qemu_register_suspend_notifier(&suspend);
 
-    state->wakeup.notify = xen_wakeup_notifier;
-    qemu_register_wakeup_notifier(&state->wakeup);
+    wakeup.notify = xen_wakeup_notifier;
+    qemu_register_wakeup_notifier(&wakeup);
 
     rc = xen_get_vmport_regs_pfn(xen_xc, xen_domid, &ioreq_pfn);
     if (!rc) {
         DPRINTF("shared vmport page at pfn %lx\n", ioreq_pfn);
-        state->shared_vmport_page =
+        shared_vmport_page =
             xenforeignmemory_map(xen_fmem, xen_domid, PROT_READ|PROT_WRITE,
                                  1, &ioreq_pfn, NULL);
-        if (state->shared_vmport_page == NULL) {
+        if (shared_vmport_page == NULL) {
             error_report("map shared vmport IO page returned error %d handle=%p",
                          errno, xen_xc);
             goto err;
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423251.669882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPk-00082h-4N; Sat, 15 Oct 2022 05:08:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423251.669882; Sat, 15 Oct 2022 05:08:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPj-00080G-S0; Sat, 15 Oct 2022 05:08:47 +0000
Received: by outflank-mailman (input) for mailman id 423251;
 Sat, 15 Oct 2022 05:08:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPh-00070V-SU
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:45 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f988b0b-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:42 +0200 (CEST)
Received: from DS7PR07CA0024.namprd07.prod.outlook.com (2603:10b6:5:3af::6) by
 IA0PR12MB7532.namprd12.prod.outlook.com (2603:10b6:208:43e::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.29; Sat, 15 Oct 2022 05:08:39 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::35) by DS7PR07CA0024.outlook.office365.com
 (2603:10b6:5:3af::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:39 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:39 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:36 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:36 -0500
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:36 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f988b0b-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IvBHOM1Hpg9Nwm4DOTOn4Cl8GOiNRNzlr+kiJVFn44okbA6Rre/DmoF3MUIN5XHa23aGXfreW5KEHkWtWD/9Wxui43n6tqmFpDKgMlRSL8PRJxI3IzCs4XN42wfuEoTEkXn6AdPg8jgKqnLMD26AOJgekHz5KlQhgfVNA79kXAdv0b1FepLB+5wSAge8LQtclMxASDn2gjiNJQXZb0cmZIj7RnZMRmLem9yDDn4O9d7RTnvv8re6bTDmHgtf1byzX6GpD+E2BvbageAthz/5Ny6XLVnAGCN7fDct0kTqhj46FyQ4fxjw0DKUz5AhPHj7NswAYJVKRjZBJ7s7jzPslg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uhw1D9fisV1HIckd/2LLnvLHG5KTlFvgBHEiq7MpJv0=;
 b=OYLDfwhjLswkQQCAt4pS8ZtynCdOL/HqbsPgYC8ArmQDQgoFxZLTomHg+VeWGSLaMX9pym/04/Pi8BH+l1KRmGoNxYyAAT/djf7yjnL0+hrz290Jqu6whRjR/CnO7weE7f6+AM6n0+y3B5QNkN1XaULprc31985jNHty0ojYHpHNA1vHF9dpclzOzOWGbYD1fQfkpfMwKl4kr11XDUm2ZvNLzn2f+CchgD1ETSqhk99P8ABeuWn/OEuhes2l/lUZeqIMoLgGA8RfQsf42kEIoU6gErit+xyGtNqJApyp3ZcViQzw5gNXAGIXXpWATBsqk+tvQ4PCGkuCghJPcfTZ2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uhw1D9fisV1HIckd/2LLnvLHG5KTlFvgBHEiq7MpJv0=;
 b=dnhLWQXQzsgHZFxAMZ8PAgB9NKRGc87eHTXUkGM7aJxIIhMmx+7/LqklZWlZ4XEvIEQDAQE/YFUsUq72i0Ti1WxHXtxgRIcnnfS8wDLMmGrw4KmHsyisVtpPAtOWwdd5GtVpJh6hTug/KDPpEmi0pMJVhewdoW0hRxzexobp5ak=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state
Date: Fri, 14 Oct 2022 22:07:47 -0700
Message-ID: <20221015050750.4185-10-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|IA0PR12MB7532:EE_
X-MS-Office365-Filtering-Correlation-Id: 03fd6ca3-7f9f-4040-b8f7-08daae6b5267
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p7HnUH894kyYgOxvDCAEeDMoEwQradaoF6HaQmVcEaIM36zSAc66850n0R/+obhERSQT15bX0N3FrY5iGEVUNADSYhNDEI8fvu916U+YAodDJt5BWgS40NQbSYasPZ0KwqrzPb3PE6Kj8u8BaLtAyJUFdBue/jGk2fLn7h6GJuVh8SW7oI/BE0r3URpr8lrSYeBbKH1ZF7ejO9UJmAyPh6NlhW3yOYKzh30+AVXHmLWrWbDLPSJjE7zPO3y2j5yUYHN3cXIu/KiDGu42LFxB4+CUaTW8B9Xg8LmVsvOS7bDjWsgLMh524OU0ba7XJ4PsXGBYRoQyRoiYFS6s/VjNgLfrMJ8uYX7/GfYDLE60Gson+FMFxZqAQceOp5VXEHxfMucMW7R0y94QjN9rNUHhiNtSvD21sE+MeMbLfXka2kp7VlKsFpt5f3PGY7pNADQ2A1w/pnHrI8FgmD3lAXE/IIXKNZkx+JG53Cvs0mwsX/kjArSfr+lUIJ9tMYnxvoeldxpizPP2dNzV0s2NEcz+36r75CcadDr/+PUz13n1OU/mvqWulbGNqAtDxo+v294fugtMEz/A+lt4sm1zC5mhy92hn6+wQgseJUXC3uaLJIs4Q6MuZgK4gGgS39g07112QWeDjr+A0nzP2IWt3htN0ztxiRmLVrlfsDMFRvYVV9LxEuSn5rhytbDhgxQKRX1rt/avny38i8kGQ88TPKZ3FYrWIrdbQPJ/8tiOoYO25CKKAdn70DGAMpa5zH5D18N8eA6umhGELQXP8tsNH5VB8wLGC/29zCuOD2t17AgpbY3UuKZm5rqWlkyd3dRylbEv
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(478600001)(54906003)(316002)(6916009)(4326008)(40480700001)(70206006)(8676002)(6666004)(41300700001)(70586007)(26005)(82310400005)(36756003)(8936002)(5660300002)(44832011)(86362001)(83380400001)(1076003)(81166007)(186003)(336012)(82740400003)(426003)(47076005)(2906002)(40460700003)(356005)(2616005)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:39.1890
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 03fd6ca3-7f9f-4040-b8f7-08daae6b5267
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7532

xenstore_record_dm_state() will also be used in aarch64 xenpv machine.

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 accel/xen/xen-all.c  | 2 +-
 include/hw/xen/xen.h | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
index 69aa7d018b..276625b78b 100644
--- a/accel/xen/xen-all.c
+++ b/accel/xen/xen-all.c
@@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev *chr)
 }
 
 
-static void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
+void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
 {
     char path[50];
 
diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
index afdf9c436a..31e9538a5c 100644
--- a/include/hw/xen/xen.h
+++ b/include/hw/xen/xen.h
@@ -9,6 +9,7 @@
  */
 
 #include "exec/cpu-common.h"
+#include <xenstore.h>
 
 /* xen-machine.c */
 enum xen_mode {
@@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);
 void xenstore_store_pv_console_info(int i, Chardev *chr);
 
 void xen_register_framebuffer(struct MemoryRegion *mr);
+void xenstore_record_dm_state(struct xs_handle *xs, const char *state);
 
 #endif /* QEMU_HW_XEN_H */
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423253.669888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPk-0008AX-O5; Sat, 15 Oct 2022 05:08:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423253.669888; Sat, 15 Oct 2022 05:08:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPk-00087W-Fe; Sat, 15 Oct 2022 05:08:48 +0000
Received: by outflank-mailman (input) for mailman id 423253;
 Sat, 15 Oct 2022 05:08:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPi-00070V-SX
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:46 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f4e0e41-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:43 +0200 (CEST)
Received: from DS7PR07CA0016.namprd07.prod.outlook.com (2603:10b6:5:3af::18)
 by DM4PR12MB7504.namprd12.prod.outlook.com (2603:10b6:8:110::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 15 Oct
 2022 05:08:38 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::2f) by DS7PR07CA0016.outlook.office365.com
 (2603:10b6:5:3af::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:38 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:38 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:35 -0500
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:35 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f4e0e41-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jifEHGNqERbztNNgNTNYc7ipxn+PIuMCLCs7nKtpdKHy8LSrdY5RdnDzvh1klNPd+msnPZIzRzNZeCiRHa1wKNXMdR/4HqNGFpXzKAXDShxAgnhvqZQTC32wS4etKCM9mY3cR56Yvii27zGxjNJjSJQrBrxXeVZjYx9Y9KPr/gTZTNGJTggMbl4AFV5RHiU25juYNTDRlwKprMp9eI1uXeQ41hn2mgamhnTpXD/zxEZi++KFu2Cl1zxaRJsT6DMYCRVOpfHsXgzy2Njo3qpT8Kha+Yzvoa7YIznKgCgY5rrL9Es3DAXZk81xM//oCrUtQ4RYbkBWf11dRo1HvNhbNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vpNswOJaJTvoQnEp4VKG3t3Oool7KkMpjFedov6r4QE=;
 b=MmkVYj9DAk7EMD+Oh28VQq5fXg19TaMFECBybTMqSq67yhUrfGSCv77dMkKwMOrq6YMiTf0RVEW9euTLI4lsQDLDSqouextGmOHBL5ok1ipHMiRn6ATPKIKhincV89w01QSS+KkK0kuH30zsGD8qD4NA7/rrab06+IFXlVrsTbvQ7qZdxTPz0QdQo5lJL/EAI+uNFitAa9HRKPDD59xCPlyNWDw6aSWxDxk7uZuzJSPvGimLzcXNVBsBviKdxAIiPgWHomhPLfDxDdcOTF34SEncuFjtOrzBi3GltaKSfmPoqhXUFU+9HiSTo4Y9xpqMk9PQ9hBUEZGMZovEWr94yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vpNswOJaJTvoQnEp4VKG3t3Oool7KkMpjFedov6r4QE=;
 b=Iz9JceDqu9u9WD1HlenDMVCtpdyHXw89fzV8Qd0eId5tK06YyRYiKRiUNpM8qvkS+1Dz/iSPRn5Dxsd5dK5kHgnglDshpaq53pQOqnBUDKZ+7uXg9FyiL2LO11oGGvfUWZdXxIBgkP27yV31rd4sWm8wEFOsS3YmxL+42AQ4O9U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 08/12] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure
Date: Fri, 14 Oct 2022 22:07:46 -0700
Message-ID: <20221015050750.4185-9-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|DM4PR12MB7504:EE_
X-MS-Office365-Filtering-Correlation-Id: cfcdd5c9-d184-4163-5c1c-08daae6b5208
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ayGk3wzHF76voTX3eVmgKUvFV4APK3101zaH/G7X9LqItm5zX7y2AeffY6fPJ6Ziw8ApjrpFnwfkCWJL7wwcRA8GDn4gRdR4Gx9LK5YgXhqtxQlbbcpCTSgIVNH1pQqM3tMNVJQoGJQ3maBIMo8a/7qobBGMDb+s4teoSGZsRa+Vu+oLJGEWCoqt1+5duZGsMYzPhiblUEjwDlYQ9/Dh1zRbslGR0d1cLI0YpPLBPLeRSc/zBboT3TZtXzF02huOZC+NA+jDT+SfPWStyGBHex0nI/mj+zv0/gMu0W4/tScwXQnERuC0DwJxmpjH8d0kowJRll76imkr7GRnVCJZFI5CIYgKY9EcIdk+o/pGwiD7YufBXOcdbAlF4PIQQJxXZXHZvqpyNo1XW/T6lsw9aKObdD+JbXuJ17NPfOKbVHh7RUhE1MwqhBV9tGPDRZR2LU/zcDxRfO5W/XQQfX7xjhHJAQcPgRgGVstaAu/KZ7Li9A0T9B0Ns7QlYpajz+Xoni8jzUpxVeT47BdHz0JomNOnccUj9jsjqwhgJB+y78z0YaEsf7WqcRLF1ZIA/EAki3QA/568KYz750EUFK0vEdAeL6vzS5dIRSUGh85Ho2CtUCLNMF/fa3oHsWYT4Hmgg5g/dFWepuMQM/CUKLTPAds0Bi4SbuQrQvnQCCYwW/lqtPETiJM7v+p6kYtZFcmuaLgGaincOq+yTqxLgG9NOyHLcflNYvMNkPYuXMMe7OPpG48c2FM/PdWUKvN6Nx7qga1YTP0k4fxR0+uSCIUjSfqsN3RZtuZpVGw6CMquLgupdFDv72JJ7u0c6q/afoIU
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(186003)(40480700001)(82740400003)(2616005)(86362001)(1076003)(2906002)(5660300002)(316002)(8936002)(54906003)(70206006)(70586007)(44832011)(40460700003)(82310400005)(81166007)(4326008)(47076005)(6916009)(356005)(83380400001)(26005)(36756003)(336012)(8676002)(6666004)(478600001)(41300700001)(36860700001)(426003)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:38.5640
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cfcdd5c9-d184-4163-5c1c-08daae6b5208
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7504

From: Stefano Stabellini <stefano.stabellini@amd.com>

On ARM it is possible to have a functioning xenpv machine with only the
PV backends and no IOREQ server. If the IOREQ server creation fails continue
to the PV backends initialization.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 hw/xen/xen-hvm-common.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
index f848f9e625..7bccf595fc 100644
--- a/hw/xen/xen-hvm-common.c
+++ b/hw/xen/xen-hvm-common.c
@@ -777,7 +777,11 @@ void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
         goto err;
     }
 
-    xen_create_ioreq_server(xen_domid, &state->ioservid);
+    rc = xen_create_ioreq_server(xen_domid, &state->ioservid);
+    if (rc) {
+        DPRINTF("xen: failed to create ioreq server\n");
+        goto no_ioreq;
+    }
 
     state->exit.notify = xen_exit_notifier;
     qemu_add_exit_notifier(&state->exit);
@@ -842,6 +846,7 @@ void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
     QLIST_INIT(&state->dev_list);
     device_listener_register(&state->device_listener);
 
+no_ioreq:
     xen_bus_init();
 
     /* Initialize backend core & drivers */
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423254.669897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPl-0008Kn-Cr; Sat, 15 Oct 2022 05:08:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423254.669897; Sat, 15 Oct 2022 05:08:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPl-0008I1-4W; Sat, 15 Oct 2022 05:08:49 +0000
Received: by outflank-mailman (input) for mailman id 423254;
 Sat, 15 Oct 2022 05:08:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPj-00069z-0c
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:47 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on2069.outbound.protection.outlook.com [40.107.212.69])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f96e632-4c47-11ed-8fd0-01056ac49cbb;
 Sat, 15 Oct 2022 07:08:42 +0200 (CEST)
Received: from DS7PR07CA0016.namprd07.prod.outlook.com (2603:10b6:5:3af::18)
 by MW4PR12MB6778.namprd12.prod.outlook.com (2603:10b6:303:1e8::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Sat, 15 Oct
 2022 05:08:38 +0000
Received: from CY4PEPF0000B8EB.namprd05.prod.outlook.com
 (2603:10b6:5:3af:cafe::2f) by DS7PR07CA0016.outlook.office365.com
 (2603:10b6:5:3af::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:37 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EB.mail.protection.outlook.com (10.167.241.7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5676.13 via Frontend Transport; Sat, 15 Oct 2022 05:08:37 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:34 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 22:08:20 -0700
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:20 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f96e632-4c47-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SIbjUIrZfqWcgfRSwu0RZDMu7lT3txi/VwInbaK8h+1010XdsgTRgMHv/1GWmRmJ9LT2IdvO2h5GCH+uo6aTRamxL9FRMbEupZdgBwB1KrojngrNL+ywKYzbIScl87BhHAPPWGi0u8IVhu7CPm68tHt9MTmez4afUBm7vCgCpWXDEbW5so+7CJ4xBC/REedVhH1/KhVSVjn/Ql1nb9L3kimd4Y3/HShAgoV0yBVrXeeGLVe4HnTVWPxZUVKbUSpttSDwPN0josf1/wUHqjry57ru09rcBqPEC8e9ChC9gNKEhYryHTM5YtdyD40KwH5RWx/lvSzS1GlmPMRqV0Oj6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bSPCw7o+yxos/RT4fp3FBWtMrt+x0eWdJDWjyf9JYrA=;
 b=ZeiIXUZ80QYsDkih6qss0Sr0CSSybIHl3h+50wSReaJaxgXIog8BWKBDbVTJgjm6iIYs0lAnOqmLPzi4tfWgnorLWNsV1IWcLrD8+l+NyMpPP2CP1D3eFHhMWQdnhoseCFXOPu+YMCL53Qyfjx8icwD9Dy0dbiOu4efOmvAaMMQVYgkfJhoSZh2EvO8byEGdDrIgSinCsmNxC2D/fsEmoGGfQq91qOxH2KeR116ysSJ4jzRskQ/5LZ+xdEcY21FLbaWZ5jQB6a661lpwJLE0mDt1gkyGH2fnFlkdGApbB1/YfsRwBtzhBRlhRxH1UR0JptGbAolKfQhFmZCRylZ07Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bSPCw7o+yxos/RT4fp3FBWtMrt+x0eWdJDWjyf9JYrA=;
 b=qOvEJFOuq7d+8afzqzH988FDQ14V77IX0XTUjvZAdZSvhN4JHSmVxk45pYGk6xobDkoDYL5sydur051rIDStdWhDnlgbfnCotqkv+Q2TE/3rSBTd04d7zxtJwaDKqeH8BWkfUSiMrdLlK4PCrBfdkou49ULqdZAqDlA64xF+o3M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "Paul
 Durrant" <paul@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Marcel
 Apfelbaum" <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost
	<eduardo@habkost.net>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c
Date: Fri, 14 Oct 2022 22:07:44 -0700
Message-ID: <20221015050750.4185-7-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EB:EE_|MW4PR12MB6778:EE_
X-MS-Office365-Filtering-Correlation-Id: 3aff2840-a08c-4044-0007-08daae6b516b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mGV0qu8kaOYm9NAwUo0JavbdDPJRLABBPlbzSSyUhkrttswDD/86lQfn7SzRvi8ZHkm3yhN9YeJZYc0KBfvQ/7M1eSjP/eyraSfoeRrHMLPr//bBoIfuVkSd8B9922IrAFYE4FvPD4c8g0aZSsJaPx/weWArLs5ml6+8WHH+uYtB6ONIea5K4edST1ly6LIESfd4PaM6RkurCnesYuf11fpmMcW9iEz7mgY8f8yPCKPPKMsekKt7j7nOrwulFvgJxSltO1oXjM2Em6XIbzN+Fk/AahKgGjN8HlF3UwmCRpFh7Uya8/x01cj1RPYbpxlSEBBTHPVoxwulfjDBrHQ5VT+of7podLWS7WDNhfjuAeMIyImVv1Uwe6w54dzBd7pAJXQYKFMjVatSge2gYBPSh/daOkV85WoxjbMeJsLnGNEwB2uL/jNqsEtgUFfUiH4GTD4VtolrNX9KqDjgVKm4xoDasHxhNScARjJ+kKO4h2a9dcZtbcrWRNpigjs9n/qX2omu2LOhYxG27OrKSChSYv8bKp1O5HWFQ0J1Z6W/OdzBm7c1J1vg+D+8ZXvS6Ij+X/o4fJrmP7L/IplMXEDsvAFFjzhW+Y4K/041VAW/FevyEWLzAgGCgAkrZXeX47J+pCtEx44NaLrS/w/OzfdB1hQm4zw6OvlzeBgKXDyoTbLB6KkmCkbmuRbVnWIQEseNHMiUfTtoTG5idc3+1doEoG7HVUoehqhNPbpAgCyecZtczK8ChS+0rNeOgW0U/vp7OMu/f7yQJx75SW3r4npwEt61yxH/iFydCgKQw5mw48GFuOJICkQNv5LFr2GN0sN8
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(478600001)(82310400005)(86362001)(54906003)(41300700001)(36756003)(6916009)(44832011)(83380400001)(7416002)(70206006)(30864003)(8676002)(4326008)(356005)(47076005)(26005)(70586007)(6666004)(40460700003)(336012)(8936002)(2616005)(186003)(81166007)(316002)(2906002)(40480700001)(1076003)(82740400003)(426003)(5660300002)(36900700001)(579004)(559001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:37.5327
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3aff2840-a08c-4044-0007-08daae6b516b
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EB.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6778

Extract common functionalities from hw/i386/xen/xen-hvm.c and move them to
hw/xen/xen-hvm-common.c. These common functions are useful for creating
an IOREQ server.

xen_hvm_init_pc() contains the arch independent code for creating and mapping
a IOREQ server, connecting memory and IO listeners, initializing a xen bus and
registering backends. Moved this common xen code to a new function
xen_register_ioreq() which can be used by both x86 and ARM machines.

Following functions are moved to hw/xen/xen-hvm-common.c:
    xen_vcpu_eport(), xen_vcpu_ioreq(), xen_ram_alloc(), xen_set_memory(),
    xen_region_add(), xen_region_del(), xen_io_add(), xen_io_del(),
    xen_device_realize(), xen_device_unrealize(),
    cpu_get_ioreq_from_shared_memory(), cpu_get_ioreq(), do_inp(), do_outp(),
    rw_phys_req_item(), read_phys_req_item(), write_phys_req_item(),
    cpu_ioreq_pio(), cpu_ioreq_move(), cpu_ioreq_config(), handle_ioreq(),
    handle_buffered_iopage(), handle_buffered_io(), cpu_handle_ioreq(),
    xen_main_loop_prepare(), xen_hvm_change_state_handler(),
    xen_exit_notifier(), xen_map_ioreq_server(), destroy_hvm_domain() and
    xen_shutdown_fatal_error()

Removed static type from below functions:
1. xen_region_add()
2. xen_region_del()
3. xen_io_add()
4. xen_io_del()
5. xen_device_realize()
6. xen_device_unrealize()
7. xen_hvm_change_state_handler()
8. cpu_ioreq_pio()
9. xen_exit_notifier()

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 hw/i386/xen/trace-events        |  14 -
 hw/i386/xen/xen-hvm.c           | 930 +-------------------------------
 hw/xen/meson.build              |   5 +-
 hw/xen/trace-events             |  14 +
 hw/xen/xen-hvm-common.c         | 858 +++++++++++++++++++++++++++++
 include/hw/i386/xen_arch_hvm.h  |   1 +
 include/hw/xen/xen-hvm-common.h |  97 ++++
 7 files changed, 983 insertions(+), 936 deletions(-)
 create mode 100644 hw/xen/xen-hvm-common.c
 create mode 100644 include/hw/xen/xen-hvm-common.h

diff --git a/hw/i386/xen/trace-events b/hw/i386/xen/trace-events
index a0c89d91c4..5d0a8d6dcf 100644
--- a/hw/i386/xen/trace-events
+++ b/hw/i386/xen/trace-events
@@ -7,17 +7,3 @@ xen_platform_log(char *s) "xen platform: %s"
 xen_pv_mmio_read(uint64_t addr) "WARNING: read from Xen PV Device MMIO space (address 0x%"PRIx64")"
 xen_pv_mmio_write(uint64_t addr) "WARNING: write to Xen PV Device MMIO space (address 0x%"PRIx64")"
 
-# xen-hvm.c
-xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: 0x%lx, size 0x%lx"
-xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty) "0x%"PRIx64" size 0x%lx, log_dirty %i"
-handle_ioreq(void *req, uint32_t type, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p type=%d dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
-handle_ioreq_read(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p read type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
-handle_ioreq_write(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p write type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
-cpu_ioreq_pio(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p pio dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
-cpu_ioreq_pio_read_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio read reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d"
-cpu_ioreq_pio_write_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio write reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d"
-cpu_ioreq_move(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p copy dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
-xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p"
-cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
-cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
-
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index 3cd1808f9d..0406f13b35 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -10,47 +10,20 @@
 
 #include "qemu/osdep.h"
 #include "qemu/units.h"
+#include "qapi/error.h"
+#include "qapi/qapi-commands-migration.h"
+#include "trace.h"
 
-#include "cpu.h"
-#include "hw/pci/pci.h"
-#include "hw/pci/pci_host.h"
 #include "hw/i386/pc.h"
 #include "hw/irq.h"
-#include "hw/hw.h"
 #include "hw/i386/apic-msidef.h"
-#include "hw/xen/xen_common.h"
-#include "hw/xen/xen-legacy-backend.h"
-#include "hw/xen/xen-bus.h"
 #include "hw/xen/xen-x86.h"
-#include "qapi/error.h"
-#include "qapi/qapi-commands-migration.h"
-#include "qemu/error-report.h"
-#include "qemu/main-loop.h"
 #include "qemu/range.h"
-#include "sysemu/runstate.h"
-#include "sysemu/sysemu.h"
-#include "sysemu/xen.h"
-#include "sysemu/xen-mapcache.h"
-#include "trace.h"
 
-#include <xen/hvm/ioreq.h>
+#include "hw/xen/xen-hvm-common.h"
 #include "hw/xen/arch_hvm.h"
 #include <xen/hvm/e820.h>
 
-//#define DEBUG_XEN_HVM
-
-#ifdef DEBUG_XEN_HVM
-#define DPRINTF(fmt, ...) \
-    do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-    do { } while (0)
-#endif
-
-static MemoryRegion ram_memory, ram_640k, ram_lo, ram_hi;
-static MemoryRegion *framebuffer;
-static bool xen_in_migration;
-
 /* Compatibility with older version */
 
 /* This allows QEMU to build on a system that has Xen 4.5 or earlier
@@ -76,26 +49,9 @@ typedef struct shared_vmport_iopage shared_vmport_iopage_t;
 #endif
 static shared_vmport_iopage_t *shared_vmport_page;
 
-static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i)
-{
-    return shared_page->vcpu_ioreq[i].vp_eport;
-}
-static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu)
-{
-    return &shared_page->vcpu_ioreq[vcpu];
-}
-
-#define BUFFER_IO_MAX_DELAY  100
-
-typedef struct XenPhysmap {
-    hwaddr start_addr;
-    ram_addr_t size;
-    const char *name;
-    hwaddr phys_offset;
-
-    QLIST_ENTRY(XenPhysmap) list;
-} XenPhysmap;
-
+static MemoryRegion ram_640k, ram_lo, ram_hi;
+static MemoryRegion *framebuffer;
+static bool xen_in_migration;
 static QLIST_HEAD(, XenPhysmap) xen_physmap;
 static const XenPhysmap *log_for_dirtybit;
 /* Buffer used by xen_sync_dirty_bitmap */
@@ -103,38 +59,6 @@ static unsigned long *dirty_bitmap;
 static Notifier suspend;
 static Notifier wakeup;
 
-typedef struct XenPciDevice {
-    PCIDevice *pci_dev;
-    uint32_t sbdf;
-    QLIST_ENTRY(XenPciDevice) entry;
-} XenPciDevice;
-
-typedef struct XenIOState {
-    ioservid_t ioservid;
-    shared_iopage_t *shared_page;
-    buffered_iopage_t *buffered_io_page;
-    xenforeignmemory_resource_handle *fres;
-    QEMUTimer *buffered_io_timer;
-    CPUState **cpu_by_vcpu_id;
-    /* the evtchn port for polling the notification, */
-    evtchn_port_t *ioreq_local_port;
-    /* evtchn remote and local ports for buffered io */
-    evtchn_port_t bufioreq_remote_port;
-    evtchn_port_t bufioreq_local_port;
-    /* the evtchn fd for polling */
-    xenevtchn_handle *xce_handle;
-    /* which vcpu we are serving */
-    int send_vcpu;
-
-    struct xs_handle *xenstore;
-    MemoryListener memory_listener;
-    MemoryListener io_listener;
-    QLIST_HEAD(, XenPciDevice) dev_list;
-    DeviceListener device_listener;
-
-    Notifier exit;
-} XenIOState;
-
 /* Xen specific function for piix pci */
 
 int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num)
@@ -247,42 +171,6 @@ static void xen_ram_init(PCMachineState *pcms,
     }
 }
 
-void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr,
-                   Error **errp)
-{
-    unsigned long nr_pfn;
-    xen_pfn_t *pfn_list;
-    int i;
-
-    if (runstate_check(RUN_STATE_INMIGRATE)) {
-        /* RAM already populated in Xen */
-        fprintf(stderr, "%s: do not alloc "RAM_ADDR_FMT
-                " bytes of ram at "RAM_ADDR_FMT" when runstate is INMIGRATE\n",
-                __func__, size, ram_addr);
-        return;
-    }
-
-    if (mr == &ram_memory) {
-        return;
-    }
-
-    trace_xen_ram_alloc(ram_addr, size);
-
-    nr_pfn = size >> TARGET_PAGE_BITS;
-    pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn);
-
-    for (i = 0; i < nr_pfn; i++) {
-        pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i;
-    }
-
-    if (xc_domain_populate_physmap_exact(xen_xc, xen_domid, nr_pfn, 0, 0, pfn_list)) {
-        error_setg(errp, "xen: failed to populate ram at " RAM_ADDR_FMT,
-                   ram_addr);
-    }
-
-    g_free(pfn_list);
-}
-
 static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size)
 {
     XenPhysmap *physmap = NULL;
@@ -472,109 +360,6 @@ static int xen_remove_from_physmap(XenIOState *state,
     return 0;
 }
 
-static void xen_set_memory(struct MemoryListener *listener,
-                           MemoryRegionSection *section,
-                           bool add)
-{
-    XenIOState *state = container_of(listener, XenIOState, memory_listener);
-
-    if (section->mr == &ram_memory) {
-        return;
-    } else {
-        if (add) {
-            xen_map_memory_section(xen_domid, state->ioservid,
-                                   section);
-        } else {
-            xen_unmap_memory_section(xen_domid, state->ioservid,
-                                     section);
-        }
-    }
-    arch_xen_set_memory(state, section, add);
-}
-
-static void xen_region_add(MemoryListener *listener,
-                           MemoryRegionSection *section)
-{
-    memory_region_ref(section->mr);
-    xen_set_memory(listener, section, true);
-}
-
-static void xen_region_del(MemoryListener *listener,
-                           MemoryRegionSection *section)
-{
-    xen_set_memory(listener, section, false);
-    memory_region_unref(section->mr);
-}
-
-static void xen_io_add(MemoryListener *listener,
-                       MemoryRegionSection *section)
-{
-    XenIOState *state = container_of(listener, XenIOState, io_listener);
-    MemoryRegion *mr = section->mr;
-
-    if (mr->ops == &unassigned_io_ops) {
-        return;
-    }
-
-    memory_region_ref(mr);
-
-    xen_map_io_section(xen_domid, state->ioservid, section);
-}
-
-static void xen_io_del(MemoryListener *listener,
-                       MemoryRegionSection *section)
-{
-    XenIOState *state = container_of(listener, XenIOState, io_listener);
-    MemoryRegion *mr = section->mr;
-
-    if (mr->ops == &unassigned_io_ops) {
-        return;
-    }
-
-    xen_unmap_io_section(xen_domid, state->ioservid, section);
-
-    memory_region_unref(mr);
-}
-
-static void xen_device_realize(DeviceListener *listener,
-                               DeviceState *dev)
-{
-    XenIOState *state = container_of(listener, XenIOState, device_listener);
-
-    if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
-        PCIDevice *pci_dev = PCI_DEVICE(dev);
-        XenPciDevice *xendev = g_new(XenPciDevice, 1);
-
-        xendev->pci_dev = pci_dev;
-        xendev->sbdf = PCI_BUILD_BDF(pci_dev_bus_num(pci_dev),
-                                     pci_dev->devfn);
-        QLIST_INSERT_HEAD(&state->dev_list, xendev, entry);
-
-        xen_map_pcidev(xen_domid, state->ioservid, pci_dev);
-    }
-}
-
-static void xen_device_unrealize(DeviceListener *listener,
-                                 DeviceState *dev)
-{
-    XenIOState *state = container_of(listener, XenIOState, device_listener);
-
-    if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
-        PCIDevice *pci_dev = PCI_DEVICE(dev);
-        XenPciDevice *xendev, *next;
-
-        xen_unmap_pcidev(xen_domid, state->ioservid, pci_dev);
-
-        QLIST_FOREACH_SAFE(xendev, &state->dev_list, entry, next) {
-            if (xendev->pci_dev == pci_dev) {
-                QLIST_REMOVE(xendev, entry);
-                g_free(xendev);
-                break;
-            }
-        }
-    }
-}
-
 static void xen_sync_dirty_bitmap(XenIOState *state,
                                   hwaddr start_addr,
                                   ram_addr_t size)
@@ -682,277 +467,6 @@ static MemoryListener xen_memory_listener = {
     .priority = 10,
 };
 
-static MemoryListener xen_io_listener = {
-    .name = "xen-io",
-    .region_add = xen_io_add,
-    .region_del = xen_io_del,
-    .priority = 10,
-};
-
-static DeviceListener xen_device_listener = {
-    .realize = xen_device_realize,
-    .unrealize = xen_device_unrealize,
-};
-
-/* get the ioreq packets from share mem */
-static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu)
-{
-    ioreq_t *req = xen_vcpu_ioreq(state->shared_page, vcpu);
-
-    if (req->state != STATE_IOREQ_READY) {
-        DPRINTF("I/O request not ready: "
-                "%x, ptr: %x, port: %"PRIx64", "
-                "data: %"PRIx64", count: %u, size: %u\n",
-                req->state, req->data_is_ptr, req->addr,
-                req->data, req->count, req->size);
-        return NULL;
-    }
-
-    xen_rmb(); /* see IOREQ_READY /then/ read contents of ioreq */
-
-    req->state = STATE_IOREQ_INPROCESS;
-    return req;
-}
-
-/* use poll to get the port notification */
-/* ioreq_vec--out,the */
-/* retval--the number of ioreq packet */
-static ioreq_t *cpu_get_ioreq(XenIOState *state)
-{
-    MachineState *ms = MACHINE(qdev_get_machine());
-    unsigned int max_cpus = ms->smp.max_cpus;
-    int i;
-    evtchn_port_t port;
-
-    port = xenevtchn_pending(state->xce_handle);
-    if (port == state->bufioreq_local_port) {
-        timer_mod(state->buffered_io_timer,
-                BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
-        return NULL;
-    }
-
-    if (port != -1) {
-        for (i = 0; i < max_cpus; i++) {
-            if (state->ioreq_local_port[i] == port) {
-                break;
-            }
-        }
-
-        if (i == max_cpus) {
-            hw_error("Fatal error while trying to get io event!\n");
-        }
-
-        /* unmask the wanted port again */
-        xenevtchn_unmask(state->xce_handle, port);
-
-        /* get the io packet from shared memory */
-        state->send_vcpu = i;
-        return cpu_get_ioreq_from_shared_memory(state, i);
-    }
-
-    /* read error or read nothing */
-    return NULL;
-}
-
-static uint32_t do_inp(uint32_t addr, unsigned long size)
-{
-    switch (size) {
-        case 1:
-            return cpu_inb(addr);
-        case 2:
-            return cpu_inw(addr);
-        case 4:
-            return cpu_inl(addr);
-        default:
-            hw_error("inp: bad size: %04x %lx", addr, size);
-    }
-}
-
-static void do_outp(uint32_t addr,
-        unsigned long size, uint32_t val)
-{
-    switch (size) {
-        case 1:
-            return cpu_outb(addr, val);
-        case 2:
-            return cpu_outw(addr, val);
-        case 4:
-            return cpu_outl(addr, val);
-        default:
-            hw_error("outp: bad size: %04x %lx", addr, size);
-    }
-}
-
-/*
- * Helper functions which read/write an object from/to physical guest
- * memory, as part of the implementation of an ioreq.
- *
- * Equivalent to
- *   cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i,
- *                          val, req->size, 0/1)
- * except without the integer overflow problems.
- */
-static void rw_phys_req_item(hwaddr addr,
-                             ioreq_t *req, uint32_t i, void *val, int rw)
-{
-    /* Do everything unsigned so overflow just results in a truncated result
-     * and accesses to undesired parts of guest memory, which is up
-     * to the guest */
-    hwaddr offset = (hwaddr)req->size * i;
-    if (req->df) {
-        addr -= offset;
-    } else {
-        addr += offset;
-    }
-    cpu_physical_memory_rw(addr, val, req->size, rw);
-}
-
-static inline void read_phys_req_item(hwaddr addr,
-                                      ioreq_t *req, uint32_t i, void *val)
-{
-    rw_phys_req_item(addr, req, i, val, 0);
-}
-static inline void write_phys_req_item(hwaddr addr,
-                                       ioreq_t *req, uint32_t i, void *val)
-{
-    rw_phys_req_item(addr, req, i, val, 1);
-}
-
-
-static void cpu_ioreq_pio(ioreq_t *req)
-{
-    uint32_t i;
-
-    trace_cpu_ioreq_pio(req, req->dir, req->df, req->data_is_ptr, req->addr,
-                         req->data, req->count, req->size);
-
-    if (req->size > sizeof(uint32_t)) {
-        hw_error("PIO: bad size (%u)", req->size);
-    }
-
-    if (req->dir == IOREQ_READ) {
-        if (!req->data_is_ptr) {
-            req->data = do_inp(req->addr, req->size);
-            trace_cpu_ioreq_pio_read_reg(req, req->data, req->addr,
-                                         req->size);
-        } else {
-            uint32_t tmp;
-
-            for (i = 0; i < req->count; i++) {
-                tmp = do_inp(req->addr, req->size);
-                write_phys_req_item(req->data, req, i, &tmp);
-            }
-        }
-    } else if (req->dir == IOREQ_WRITE) {
-        if (!req->data_is_ptr) {
-            trace_cpu_ioreq_pio_write_reg(req, req->data, req->addr,
-                                          req->size);
-            do_outp(req->addr, req->size, req->data);
-        } else {
-            for (i = 0; i < req->count; i++) {
-                uint32_t tmp = 0;
-
-                read_phys_req_item(req->data, req, i, &tmp);
-                do_outp(req->addr, req->size, tmp);
-            }
-        }
-    }
-}
-
-static void cpu_ioreq_move(ioreq_t *req)
-{
-    uint32_t i;
-
-    trace_cpu_ioreq_move(req, req->dir, req->df, req->data_is_ptr, req->addr,
-                         req->data, req->count, req->size);
-
-    if (req->size > sizeof(req->data)) {
-        hw_error("MMIO: bad size (%u)", req->size);
-    }
-
-    if (!req->data_is_ptr) {
-        if (req->dir == IOREQ_READ) {
-            for (i = 0; i < req->count; i++) {
-                read_phys_req_item(req->addr, req, i, &req->data);
-            }
-        } else if (req->dir == IOREQ_WRITE) {
-            for (i = 0; i < req->count; i++) {
-                write_phys_req_item(req->addr, req, i, &req->data);
-            }
-        }
-    } else {
-        uint64_t tmp;
-
-        if (req->dir == IOREQ_READ) {
-            for (i = 0; i < req->count; i++) {
-                read_phys_req_item(req->addr, req, i, &tmp);
-                write_phys_req_item(req->data, req, i, &tmp);
-            }
-        } else if (req->dir == IOREQ_WRITE) {
-            for (i = 0; i < req->count; i++) {
-                read_phys_req_item(req->data, req, i, &tmp);
-                write_phys_req_item(req->addr, req, i, &tmp);
-            }
-        }
-    }
-}
-
-static void cpu_ioreq_config(XenIOState *state, ioreq_t *req)
-{
-    uint32_t sbdf = req->addr >> 32;
-    uint32_t reg = req->addr;
-    XenPciDevice *xendev;
-
-    if (req->size != sizeof(uint8_t) && req->size != sizeof(uint16_t) &&
-        req->size != sizeof(uint32_t)) {
-        hw_error("PCI config access: bad size (%u)", req->size);
-    }
-
-    if (req->count != 1) {
-        hw_error("PCI config access: bad count (%u)", req->count);
-    }
-
-    QLIST_FOREACH(xendev, &state->dev_list, entry) {
-        if (xendev->sbdf != sbdf) {
-            continue;
-        }
-
-        if (!req->data_is_ptr) {
-            if (req->dir == IOREQ_READ) {
-                req->data = pci_host_config_read_common(
-                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
-                    req->size);
-                trace_cpu_ioreq_config_read(req, xendev->sbdf, reg,
-                                            req->size, req->data);
-            } else if (req->dir == IOREQ_WRITE) {
-                trace_cpu_ioreq_config_write(req, xendev->sbdf, reg,
-                                             req->size, req->data);
-                pci_host_config_write_common(
-                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
-                    req->data, req->size);
-            }
-        } else {
-            uint32_t tmp;
-
-            if (req->dir == IOREQ_READ) {
-                tmp = pci_host_config_read_common(
-                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
-                    req->size);
-                trace_cpu_ioreq_config_read(req, xendev->sbdf, reg,
-                                            req->size, tmp);
-                write_phys_req_item(req->data, req, 0, &tmp);
-            } else if (req->dir == IOREQ_WRITE) {
-                read_phys_req_item(req->data, req, 0, &tmp);
-                trace_cpu_ioreq_config_write(req, xendev->sbdf, reg,
-                                             req->size, tmp);
-                pci_host_config_write_common(
-                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
-                    tmp, req->size);
-            }
-        }
-    }
-}
-
 static void regs_to_cpu(vmware_regs_t *vmport_regs, ioreq_t *req)
 {
     X86CPU *cpu;
@@ -996,223 +510,6 @@ static void handle_vmport_ioreq(XenIOState *state, ioreq_t *req)
     current_cpu = NULL;
 }
 
-static void handle_ioreq(XenIOState *state, ioreq_t *req)
-{
-    trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr,
-                       req->addr, req->data, req->count, req->size);
-
-    if (!req->data_is_ptr && (req->dir == IOREQ_WRITE) &&
-            (req->size < sizeof (target_ulong))) {
-        req->data &= ((target_ulong) 1 << (8 * req->size)) - 1;
-    }
-
-    if (req->dir == IOREQ_WRITE)
-        trace_handle_ioreq_write(req, req->type, req->df, req->data_is_ptr,
-                                 req->addr, req->data, req->count, req->size);
-
-    switch (req->type) {
-        case IOREQ_TYPE_PIO:
-            cpu_ioreq_pio(req);
-            break;
-        case IOREQ_TYPE_COPY:
-            cpu_ioreq_move(req);
-            break;
-        case IOREQ_TYPE_TIMEOFFSET:
-            break;
-        case IOREQ_TYPE_INVALIDATE:
-            xen_invalidate_map_cache();
-            break;
-        case IOREQ_TYPE_PCI_CONFIG:
-            cpu_ioreq_config(state, req);
-            break;
-        default:
-            arch_handle_ioreq(state, req);
-    }
-    if (req->dir == IOREQ_READ) {
-        trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr,
-                                req->addr, req->data, req->count, req->size);
-    }
-}
-
-static bool handle_buffered_iopage(XenIOState *state)
-{
-    buffered_iopage_t *buf_page = state->buffered_io_page;
-    buf_ioreq_t *buf_req = NULL;
-    bool handled_ioreq = false;
-    ioreq_t req;
-    int qw;
-
-    if (!buf_page) {
-        return 0;
-    }
-
-    memset(&req, 0x00, sizeof(req));
-    req.state = STATE_IOREQ_READY;
-    req.count = 1;
-    req.dir = IOREQ_WRITE;
-
-    for (;;) {
-        uint32_t rdptr = buf_page->read_pointer, wrptr;
-
-        xen_rmb();
-        wrptr = buf_page->write_pointer;
-        xen_rmb();
-        if (rdptr != buf_page->read_pointer) {
-            continue;
-        }
-        if (rdptr == wrptr) {
-            break;
-        }
-        buf_req = &buf_page->buf_ioreq[rdptr % IOREQ_BUFFER_SLOT_NUM];
-        req.size = 1U << buf_req->size;
-        req.addr = buf_req->addr;
-        req.data = buf_req->data;
-        req.type = buf_req->type;
-        xen_rmb();
-        qw = (req.size == 8);
-        if (qw) {
-            if (rdptr + 1 == wrptr) {
-                hw_error("Incomplete quad word buffered ioreq");
-            }
-            buf_req = &buf_page->buf_ioreq[(rdptr + 1) %
-                                           IOREQ_BUFFER_SLOT_NUM];
-            req.data |= ((uint64_t)buf_req->data) << 32;
-            xen_rmb();
-        }
-
-        handle_ioreq(state, &req);
-
-        /* Only req.data may get updated by handle_ioreq(), albeit even that
-         * should not happen as such data would never make it to the guest (we
-         * can only usefully see writes here after all).
-         */
-        assert(req.state == STATE_IOREQ_READY);
-        assert(req.count == 1);
-        assert(req.dir == IOREQ_WRITE);
-        assert(!req.data_is_ptr);
-
-        qatomic_add(&buf_page->read_pointer, qw + 1);
-        handled_ioreq = true;
-    }
-
-    return handled_ioreq;
-}
-
-static void handle_buffered_io(void *opaque)
-{
-    XenIOState *state = opaque;
-
-    if (handle_buffered_iopage(state)) {
-        timer_mod(state->buffered_io_timer,
-                BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
-    } else {
-        timer_del(state->buffered_io_timer);
-        xenevtchn_unmask(state->xce_handle, state->bufioreq_local_port);
-    }
-}
-
-static void cpu_handle_ioreq(void *opaque)
-{
-    XenIOState *state = opaque;
-    ioreq_t *req = cpu_get_ioreq(state);
-
-    handle_buffered_iopage(state);
-    if (req) {
-        ioreq_t copy = *req;
-
-        xen_rmb();
-        handle_ioreq(state, &copy);
-        req->data = copy.data;
-
-        if (req->state != STATE_IOREQ_INPROCESS) {
-            fprintf(stderr, "Badness in I/O request ... not in service?!: "
-                    "%x, ptr: %x, port: %"PRIx64", "
-                    "data: %"PRIx64", count: %u, size: %u, type: %u\n",
-                    req->state, req->data_is_ptr, req->addr,
-                    req->data, req->count, req->size, req->type);
-            destroy_hvm_domain(false);
-            return;
-        }
-
-        xen_wmb(); /* Update ioreq contents /then/ update state. */
-
-        /*
-         * We do this before we send the response so that the tools
-         * have the opportunity to pick up on the reset before the
-         * guest resumes and does a hlt with interrupts disabled which
-         * causes Xen to powerdown the domain.
-         */
-        if (runstate_is_running()) {
-            ShutdownCause request;
-
-            if (qemu_shutdown_requested_get()) {
-                destroy_hvm_domain(false);
-            }
-            request = qemu_reset_requested_get();
-            if (request) {
-                qemu_system_reset(request);
-                destroy_hvm_domain(true);
-            }
-        }
-
-        req->state = STATE_IORESP_READY;
-        xenevtchn_notify(state->xce_handle,
-                         state->ioreq_local_port[state->send_vcpu]);
-    }
-}
-
-static void xen_main_loop_prepare(XenIOState *state)
-{
-    int evtchn_fd = -1;
-
-    if (state->xce_handle != NULL) {
-        evtchn_fd = xenevtchn_fd(state->xce_handle);
-    }
-
-    state->buffered_io_timer = timer_new_ms(QEMU_CLOCK_REALTIME, handle_buffered_io,
-                                                 state);
-
-    if (evtchn_fd != -1) {
-        CPUState *cpu_state;
-
-        DPRINTF("%s: Init cpu_by_vcpu_id\n", __func__);
-        CPU_FOREACH(cpu_state) {
-            DPRINTF("%s: cpu_by_vcpu_id[%d]=%p\n",
-                    __func__, cpu_state->cpu_index, cpu_state);
-            state->cpu_by_vcpu_id[cpu_state->cpu_index] = cpu_state;
-        }
-        qemu_set_fd_handler(evtchn_fd, cpu_handle_ioreq, NULL, state);
-    }
-}
-
-
-static void xen_hvm_change_state_handler(void *opaque, bool running,
-                                         RunState rstate)
-{
-    XenIOState *state = opaque;
-
-    if (running) {
-        xen_main_loop_prepare(state);
-    }
-
-    xen_set_ioreq_server_state(xen_domid,
-                               state->ioservid,
-                               (rstate == RUN_STATE_RUNNING));
-}
-
-static void xen_exit_notifier(Notifier *n, void *data)
-{
-    XenIOState *state = container_of(n, XenIOState, exit);
-
-    xen_destroy_ioreq_server(xen_domid, state->ioservid);
-    if (state->fres != NULL) {
-        xenforeignmemory_unmap_resource(xen_fmem, state->fres);
-    }
-
-    xenevtchn_close(state->xce_handle);
-    xs_daemon_close(state->xenstore);
-}
-
 #ifdef XEN_COMPAT_PHYSMAP
 static void xen_read_physmap(XenIOState *state)
 {
@@ -1272,178 +569,17 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data)
     xc_set_hvm_param(xen_xc, xen_domid, HVM_PARAM_ACPI_S_STATE, 0);
 }
 
-static int xen_map_ioreq_server(XenIOState *state)
-{
-    void *addr = NULL;
-    xen_pfn_t ioreq_pfn;
-    xen_pfn_t bufioreq_pfn;
-    evtchn_port_t bufioreq_evtchn;
-    int rc;
-
-    /*
-     * Attempt to map using the resource API and fall back to normal
-     * foreign mapping if this is not supported.
-     */
-    QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_bufioreq != 0);
-    QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_ioreq(0) != 1);
-    state->fres = xenforeignmemory_map_resource(xen_fmem, xen_domid,
-                                         XENMEM_resource_ioreq_server,
-                                         state->ioservid, 0, 2,
-                                         &addr,
-                                         PROT_READ | PROT_WRITE, 0);
-    if (state->fres != NULL) {
-        trace_xen_map_resource_ioreq(state->ioservid, addr);
-        state->buffered_io_page = addr;
-        state->shared_page = addr + TARGET_PAGE_SIZE;
-    } else if (errno != EOPNOTSUPP) {
-        error_report("failed to map ioreq server resources: error %d handle=%p",
-                     errno, xen_xc);
-        return -1;
-    }
-
-    rc = xen_get_ioreq_server_info(xen_domid, state->ioservid,
-                                   (state->shared_page == NULL) ?
-                                   &ioreq_pfn : NULL,
-                                   (state->buffered_io_page == NULL) ?
-                                   &bufioreq_pfn : NULL,
-                                   &bufioreq_evtchn);
-    if (rc < 0) {
-        error_report("failed to get ioreq server info: error %d handle=%p",
-                     errno, xen_xc);
-        return rc;
-    }
-
-    if (state->shared_page == NULL) {
-        DPRINTF("shared page at pfn %lx\n", ioreq_pfn);
-
-        state->shared_page = xenforeignmemory_map(xen_fmem, xen_domid,
-                                                  PROT_READ | PROT_WRITE,
-                                                  1, &ioreq_pfn, NULL);
-        if (state->shared_page == NULL) {
-            error_report("map shared IO page returned error %d handle=%p",
-                         errno, xen_xc);
-        }
-    }
-
-    if (state->buffered_io_page == NULL) {
-        DPRINTF("buffered io page at pfn %lx\n", bufioreq_pfn);
-
-        state->buffered_io_page = xenforeignmemory_map(xen_fmem, xen_domid,
-                                                       PROT_READ | PROT_WRITE,
-                                                       1, &bufioreq_pfn,
-                                                       NULL);
-        if (state->buffered_io_page == NULL) {
-            error_report("map buffered IO page returned error %d", errno);
-            return -1;
-        }
-    }
-
-    if (state->shared_page == NULL || state->buffered_io_page == NULL) {
-        return -1;
-    }
-
-    DPRINTF("buffered io evtchn is %x\n", bufioreq_evtchn);
-
-    state->bufioreq_remote_port = bufioreq_evtchn;
-
-    return 0;
-}
-
 void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory)
 {
     MachineState *ms = MACHINE(pcms);
     unsigned int max_cpus = ms->smp.max_cpus;
-    int i, rc;
+    int rc;
     xen_pfn_t ioreq_pfn;
     XenIOState *state;
 
     state = g_new0(XenIOState, 1);
 
-    state->xce_handle = xenevtchn_open(NULL, 0);
-    if (state->xce_handle == NULL) {
-        perror("xen: event channel open");
-        goto err;
-    }
-
-    state->xenstore = xs_daemon_open();
-    if (state->xenstore == NULL) {
-        perror("xen: xenstore open");
-        goto err;
-    }
-
-    xen_create_ioreq_server(xen_domid, &state->ioservid);
-
-    state->exit.notify = xen_exit_notifier;
-    qemu_add_exit_notifier(&state->exit);
-
-    /*
-     * Register wake-up support in QMP query-current-machine API
-     */
-    qemu_register_wakeup_support();
-
-    rc = xen_map_ioreq_server(state);
-    if (rc < 0) {
-        goto err;
-    }
-
-    /* Note: cpus is empty at this point in init */
-    state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus);
-
-    rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true);
-    if (rc < 0) {
-        error_report("failed to enable ioreq server info: error %d handle=%p",
-                     errno, xen_xc);
-        goto err;
-    }
-
-    state->ioreq_local_port = g_new0(evtchn_port_t, max_cpus);
-
-    /* FIXME: how about if we overflow the page here? */
-    for (i = 0; i < max_cpus; i++) {
-        rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid,
-                                        xen_vcpu_eport(state->shared_page, i));
-        if (rc == -1) {
-            error_report("shared evtchn %d bind error %d", i, errno);
-            goto err;
-        }
-        state->ioreq_local_port[i] = rc;
-    }
-
-    rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid,
-                                    state->bufioreq_remote_port);
-    if (rc == -1) {
-        error_report("buffered evtchn bind error %d", errno);
-        goto err;
-    }
-    state->bufioreq_local_port = rc;
-
-    /* Init RAM management */
-#ifdef XEN_COMPAT_PHYSMAP
-    xen_map_cache_init(xen_phys_offset_to_gaddr, state);
-#else
-    xen_map_cache_init(NULL, state);
-#endif
-
-    qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
-
-    state->memory_listener = xen_memory_listener;
-    memory_listener_register(&state->memory_listener, &address_space_memory);
-
-    state->io_listener = xen_io_listener;
-    memory_listener_register(&state->io_listener, &address_space_io);
-
-    state->device_listener = xen_device_listener;
-    QLIST_INIT(&state->dev_list);
-    device_listener_register(&state->device_listener);
-
-    xen_bus_init();
-
-    /* Initialize backend core & drivers */
-    if (xen_be_init() != 0) {
-        error_report("xen backend core setup failed");
-        goto err;
-    }
-    xen_be_register_common();
+    xen_register_ioreq(state, max_cpus, xen_memory_listener);
 
     QLIST_INIT(&xen_physmap);
     xen_read_physmap(state);
@@ -1483,59 +619,11 @@ err:
     exit(1);
 }
 
-void destroy_hvm_domain(bool reboot)
-{
-    xc_interface *xc_handle;
-    int sts;
-    int rc;
-
-    unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff;
-
-    if (xen_dmod) {
-        rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason);
-        if (!rc) {
-            return;
-        }
-        if (errno != ENOTTY /* old Xen */) {
-            perror("xendevicemodel_shutdown failed");
-        }
-        /* well, try the old thing then */
-    }
-
-    xc_handle = xc_interface_open(0, 0, 0);
-    if (xc_handle == NULL) {
-        fprintf(stderr, "Cannot acquire xenctrl handle\n");
-    } else {
-        sts = xc_domain_shutdown(xc_handle, xen_domid, reason);
-        if (sts != 0) {
-            fprintf(stderr, "xc_domain_shutdown failed to issue %s, "
-                    "sts %d, %s\n", reboot ? "reboot" : "poweroff",
-                    sts, strerror(errno));
-        } else {
-            fprintf(stderr, "Issued domain %d %s\n", xen_domid,
-                    reboot ? "reboot" : "poweroff");
-        }
-        xc_interface_close(xc_handle);
-    }
-}
-
 void xen_register_framebuffer(MemoryRegion *mr)
 {
     framebuffer = mr;
 }
 
-void xen_shutdown_fatal_error(const char *fmt, ...)
-{
-    va_list ap;
-
-    va_start(ap, fmt);
-    vfprintf(stderr, fmt, ap);
-    va_end(ap);
-    fprintf(stderr, "Will destroy the domain.\n");
-    /* destroy the domain */
-    qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR);
-}
-
 void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
 {
     if (unlikely(xen_in_migration)) {
diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index 19d0637c46..008e036d63 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -25,4 +25,7 @@ specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
 
 xen_ss = ss.source_set()
 
-xen_ss.add(when: 'CONFIG_XEN', if_true: files('xen-mapcache.c'))
+xen_ss.add(when: 'CONFIG_XEN', if_true: files(
+  'xen-mapcache.c',
+  'xen-hvm-common.c',
+))
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 2c8f238f42..02ca1183da 100644
--- a/hw/xen/trace-events
+++ b/hw/xen/trace-events
@@ -42,6 +42,20 @@ xs_node_vscanf(char *path, char *value) "%s %s"
 xs_node_watch(char *path) "%s"
 xs_node_unwatch(char *path) "%s"
 
+# xen-hvm.c
+xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: 0x%lx, size 0x%lx"
+xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty) "0x%"PRIx64" size 0x%lx, log_dirty %i"
+handle_ioreq(void *req, uint32_t type, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p type=%d dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
+handle_ioreq_read(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p read type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
+handle_ioreq_write(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p write type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
+cpu_ioreq_pio(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p pio dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
+cpu_ioreq_pio_read_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio read reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d"
+cpu_ioreq_pio_write_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio write reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d"
+cpu_ioreq_move(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p copy dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d"
+xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p"
+cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
+cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
+
 # xen-mapcache.c
 xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64
 xen_remap_bucket(uint64_t index) "index 0x%"PRIx64
diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
new file mode 100644
index 0000000000..f848f9e625
--- /dev/null
+++ b/hw/xen/xen-hvm-common.c
@@ -0,0 +1,858 @@
+#include "qemu/osdep.h"
+#include "qemu/units.h"
+#include "qapi/error.h"
+#include "trace.h"
+
+#include "hw/pci/pci_host.h"
+#include "hw/xen/xen-hvm-common.h"
+#include "hw/xen/xen-legacy-backend.h"
+#include "hw/xen/xen-bus.h"
+#include "hw/boards.h"
+#include "hw/xen/arch_hvm.h"
+
+MemoryRegion ram_memory;
+
+void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr,
+                   Error **errp)
+{
+    unsigned long nr_pfn;
+    xen_pfn_t *pfn_list;
+    int i;
+
+    if (runstate_check(RUN_STATE_INMIGRATE)) {
+        /* RAM already populated in Xen */
+        fprintf(stderr, "%s: do not alloc "RAM_ADDR_FMT
+                " bytes of ram at "RAM_ADDR_FMT" when runstate is INMIGRATE\n",
+                __func__, size, ram_addr);
+        return;
+    }
+
+    if (mr == &ram_memory) {
+        return;
+    }
+
+    trace_xen_ram_alloc(ram_addr, size);
+
+    nr_pfn = size >> TARGET_PAGE_BITS;
+    pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn);
+
+    for (i = 0; i < nr_pfn; i++) {
+        pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i;
+    }
+
+    if (xc_domain_populate_physmap_exact(xen_xc, xen_domid, nr_pfn, 0, 0, pfn_list)) {
+        error_setg(errp, "xen: failed to populate ram at " RAM_ADDR_FMT,
+                   ram_addr);
+    }
+
+    g_free(pfn_list);
+}
+
+
+static void xen_set_memory(struct MemoryListener *listener,
+                           MemoryRegionSection *section,
+                           bool add)
+{
+    XenIOState *state = container_of(listener, XenIOState, memory_listener);
+
+    if (section->mr == &ram_memory) {
+        return;
+    } else {
+        if (add) {
+            xen_map_memory_section(xen_domid, state->ioservid,
+                                   section);
+        } else {
+            xen_unmap_memory_section(xen_domid, state->ioservid,
+                                     section);
+        }
+    }
+    arch_xen_set_memory(state, section, add);
+}
+
+void xen_region_add(MemoryListener *listener,
+                           MemoryRegionSection *section)
+{
+    memory_region_ref(section->mr);
+    xen_set_memory(listener, section, true);
+}
+
+void xen_region_del(MemoryListener *listener,
+                           MemoryRegionSection *section)
+{
+    xen_set_memory(listener, section, false);
+    memory_region_unref(section->mr);
+}
+
+void xen_io_add(MemoryListener *listener,
+                       MemoryRegionSection *section)
+{
+    XenIOState *state = container_of(listener, XenIOState, io_listener);
+    MemoryRegion *mr = section->mr;
+
+    if (mr->ops == &unassigned_io_ops) {
+        return;
+    }
+
+    memory_region_ref(mr);
+
+    xen_map_io_section(xen_domid, state->ioservid, section);
+}
+
+void xen_io_del(MemoryListener *listener,
+                       MemoryRegionSection *section)
+{
+    XenIOState *state = container_of(listener, XenIOState, io_listener);
+    MemoryRegion *mr = section->mr;
+
+    if (mr->ops == &unassigned_io_ops) {
+        return;
+    }
+
+    xen_unmap_io_section(xen_domid, state->ioservid, section);
+
+    memory_region_unref(mr);
+}
+
+void xen_device_realize(DeviceListener *listener,
+                               DeviceState *dev)
+{
+    XenIOState *state = container_of(listener, XenIOState, device_listener);
+
+    if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
+        PCIDevice *pci_dev = PCI_DEVICE(dev);
+        XenPciDevice *xendev = g_new(XenPciDevice, 1);
+
+        xendev->pci_dev = pci_dev;
+        xendev->sbdf = PCI_BUILD_BDF(pci_dev_bus_num(pci_dev),
+                                     pci_dev->devfn);
+        QLIST_INSERT_HEAD(&state->dev_list, xendev, entry);
+
+        xen_map_pcidev(xen_domid, state->ioservid, pci_dev);
+    }
+}
+
+void xen_device_unrealize(DeviceListener *listener,
+                                 DeviceState *dev)
+{
+    XenIOState *state = container_of(listener, XenIOState, device_listener);
+
+    if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
+        PCIDevice *pci_dev = PCI_DEVICE(dev);
+        XenPciDevice *xendev, *next;
+
+        xen_unmap_pcidev(xen_domid, state->ioservid, pci_dev);
+
+        QLIST_FOREACH_SAFE(xendev, &state->dev_list, entry, next) {
+            if (xendev->pci_dev == pci_dev) {
+                QLIST_REMOVE(xendev, entry);
+                g_free(xendev);
+                break;
+            }
+        }
+    }
+}
+
+MemoryListener xen_io_listener = {
+    .region_add = xen_io_add,
+    .region_del = xen_io_del,
+    .priority = 10,
+};
+
+DeviceListener xen_device_listener = {
+    .realize = xen_device_realize,
+    .unrealize = xen_device_unrealize,
+};
+
+/* get the ioreq packets from share mem */
+static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu)
+{
+    ioreq_t *req = xen_vcpu_ioreq(state->shared_page, vcpu);
+
+    if (req->state != STATE_IOREQ_READY) {
+        DPRINTF("I/O request not ready: "
+                "%x, ptr: %x, port: %"PRIx64", "
+                "data: %"PRIx64", count: %u, size: %u\n",
+                req->state, req->data_is_ptr, req->addr,
+                req->data, req->count, req->size);
+        return NULL;
+    }
+
+    xen_rmb(); /* see IOREQ_READY /then/ read contents of ioreq */
+
+    req->state = STATE_IOREQ_INPROCESS;
+    return req;
+}
+
+/* use poll to get the port notification */
+/* ioreq_vec--out,the */
+/* retval--the number of ioreq packet */
+static ioreq_t *cpu_get_ioreq(XenIOState *state)
+{
+    MachineState *ms = MACHINE(qdev_get_machine());
+    unsigned int max_cpus = ms->smp.max_cpus;
+    int i;
+    evtchn_port_t port;
+
+    port = xenevtchn_pending(state->xce_handle);
+    if (port == state->bufioreq_local_port) {
+        timer_mod(state->buffered_io_timer,
+                BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
+        return NULL;
+    }
+
+    if (port != -1) {
+        for (i = 0; i < max_cpus; i++) {
+            if (state->ioreq_local_port[i] == port) {
+                break;
+            }
+        }
+
+        if (i == max_cpus) {
+            hw_error("Fatal error while trying to get io event!\n");
+        }
+
+        /* unmask the wanted port again */
+        xenevtchn_unmask(state->xce_handle, port);
+
+        /* get the io packet from shared memory */
+        state->send_vcpu = i;
+        return cpu_get_ioreq_from_shared_memory(state, i);
+    }
+
+    /* read error or read nothing */
+    return NULL;
+}
+
+static uint32_t do_inp(uint32_t addr, unsigned long size)
+{
+    switch (size) {
+        case 1:
+            return cpu_inb(addr);
+        case 2:
+            return cpu_inw(addr);
+        case 4:
+            return cpu_inl(addr);
+        default:
+            hw_error("inp: bad size: %04x %lx", addr, size);
+    }
+}
+
+static void do_outp(uint32_t addr,
+        unsigned long size, uint32_t val)
+{
+    switch (size) {
+        case 1:
+            return cpu_outb(addr, val);
+        case 2:
+            return cpu_outw(addr, val);
+        case 4:
+            return cpu_outl(addr, val);
+        default:
+            hw_error("outp: bad size: %04x %lx", addr, size);
+    }
+}
+
+/*
+ * Helper functions which read/write an object from/to physical guest
+ * memory, as part of the implementation of an ioreq.
+ *
+ * Equivalent to
+ *   cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i,
+ *                          val, req->size, 0/1)
+ * except without the integer overflow problems.
+ */
+static void rw_phys_req_item(hwaddr addr,
+                             ioreq_t *req, uint32_t i, void *val, int rw)
+{
+    /* Do everything unsigned so overflow just results in a truncated result
+     * and accesses to undesired parts of guest memory, which is up
+     * to the guest */
+    hwaddr offset = (hwaddr)req->size * i;
+    if (req->df) {
+        addr -= offset;
+    } else {
+        addr += offset;
+    }
+    cpu_physical_memory_rw(addr, val, req->size, rw);
+}
+
+static inline void read_phys_req_item(hwaddr addr,
+                                      ioreq_t *req, uint32_t i, void *val)
+{
+    rw_phys_req_item(addr, req, i, val, 0);
+}
+static inline void write_phys_req_item(hwaddr addr,
+                                       ioreq_t *req, uint32_t i, void *val)
+{
+    rw_phys_req_item(addr, req, i, val, 1);
+}
+
+
+void cpu_ioreq_pio(ioreq_t *req)
+{
+    uint32_t i;
+
+    trace_cpu_ioreq_pio(req, req->dir, req->df, req->data_is_ptr, req->addr,
+                         req->data, req->count, req->size);
+
+    if (req->size > sizeof(uint32_t)) {
+        hw_error("PIO: bad size (%u)", req->size);
+    }
+
+    if (req->dir == IOREQ_READ) {
+        if (!req->data_is_ptr) {
+            req->data = do_inp(req->addr, req->size);
+            trace_cpu_ioreq_pio_read_reg(req, req->data, req->addr,
+                                         req->size);
+        } else {
+            uint32_t tmp;
+
+            for (i = 0; i < req->count; i++) {
+                tmp = do_inp(req->addr, req->size);
+                write_phys_req_item(req->data, req, i, &tmp);
+            }
+        }
+    } else if (req->dir == IOREQ_WRITE) {
+        if (!req->data_is_ptr) {
+            trace_cpu_ioreq_pio_write_reg(req, req->data, req->addr,
+                                          req->size);
+            do_outp(req->addr, req->size, req->data);
+        } else {
+            for (i = 0; i < req->count; i++) {
+                uint32_t tmp = 0;
+
+                read_phys_req_item(req->data, req, i, &tmp);
+                do_outp(req->addr, req->size, tmp);
+            }
+        }
+    }
+}
+
+static void cpu_ioreq_move(ioreq_t *req)
+{
+    uint32_t i;
+
+    trace_cpu_ioreq_move(req, req->dir, req->df, req->data_is_ptr, req->addr,
+                         req->data, req->count, req->size);
+
+    if (req->size > sizeof(req->data)) {
+        hw_error("MMIO: bad size (%u)", req->size);
+    }
+
+    if (!req->data_is_ptr) {
+        if (req->dir == IOREQ_READ) {
+            for (i = 0; i < req->count; i++) {
+                read_phys_req_item(req->addr, req, i, &req->data);
+            }
+        } else if (req->dir == IOREQ_WRITE) {
+            for (i = 0; i < req->count; i++) {
+                write_phys_req_item(req->addr, req, i, &req->data);
+            }
+        }
+    } else {
+        uint64_t tmp;
+
+        if (req->dir == IOREQ_READ) {
+            for (i = 0; i < req->count; i++) {
+                read_phys_req_item(req->addr, req, i, &tmp);
+                write_phys_req_item(req->data, req, i, &tmp);
+            }
+        } else if (req->dir == IOREQ_WRITE) {
+            for (i = 0; i < req->count; i++) {
+                read_phys_req_item(req->data, req, i, &tmp);
+                write_phys_req_item(req->addr, req, i, &tmp);
+            }
+        }
+    }
+}
+
+static void cpu_ioreq_config(XenIOState *state, ioreq_t *req)
+{
+    uint32_t sbdf = req->addr >> 32;
+    uint32_t reg = req->addr;
+    XenPciDevice *xendev;
+
+    if (req->size != sizeof(uint8_t) && req->size != sizeof(uint16_t) &&
+        req->size != sizeof(uint32_t)) {
+        hw_error("PCI config access: bad size (%u)", req->size);
+    }
+
+    if (req->count != 1) {
+        hw_error("PCI config access: bad count (%u)", req->count);
+    }
+
+    QLIST_FOREACH(xendev, &state->dev_list, entry) {
+        if (xendev->sbdf != sbdf) {
+            continue;
+        }
+
+        if (!req->data_is_ptr) {
+            if (req->dir == IOREQ_READ) {
+                req->data = pci_host_config_read_common(
+                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
+                    req->size);
+                trace_cpu_ioreq_config_read(req, xendev->sbdf, reg,
+                                            req->size, req->data);
+            } else if (req->dir == IOREQ_WRITE) {
+                trace_cpu_ioreq_config_write(req, xendev->sbdf, reg,
+                                             req->size, req->data);
+                pci_host_config_write_common(
+                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
+                    req->data, req->size);
+            }
+        } else {
+            uint32_t tmp;
+
+            if (req->dir == IOREQ_READ) {
+                tmp = pci_host_config_read_common(
+                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
+                    req->size);
+                trace_cpu_ioreq_config_read(req, xendev->sbdf, reg,
+                                            req->size, tmp);
+                write_phys_req_item(req->data, req, 0, &tmp);
+            } else if (req->dir == IOREQ_WRITE) {
+                read_phys_req_item(req->data, req, 0, &tmp);
+                trace_cpu_ioreq_config_write(req, xendev->sbdf, reg,
+                                             req->size, tmp);
+                pci_host_config_write_common(
+                    xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE,
+                    tmp, req->size);
+            }
+        }
+    }
+}
+
+static void handle_ioreq(XenIOState *state, ioreq_t *req)
+{
+    trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr,
+                       req->addr, req->data, req->count, req->size);
+
+    if (!req->data_is_ptr && (req->dir == IOREQ_WRITE) &&
+            (req->size < sizeof (target_ulong))) {
+        req->data &= ((target_ulong) 1 << (8 * req->size)) - 1;
+    }
+
+    if (req->dir == IOREQ_WRITE)
+        trace_handle_ioreq_write(req, req->type, req->df, req->data_is_ptr,
+                                 req->addr, req->data, req->count, req->size);
+
+    switch (req->type) {
+        case IOREQ_TYPE_PIO:
+            cpu_ioreq_pio(req);
+            break;
+        case IOREQ_TYPE_COPY:
+            cpu_ioreq_move(req);
+            break;
+        case IOREQ_TYPE_TIMEOFFSET:
+            break;
+        case IOREQ_TYPE_INVALIDATE:
+            xen_invalidate_map_cache();
+            break;
+        case IOREQ_TYPE_PCI_CONFIG:
+            cpu_ioreq_config(state, req);
+            break;
+        default:
+            arch_handle_ioreq(state, req);
+    }
+    if (req->dir == IOREQ_READ) {
+        trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr,
+                                req->addr, req->data, req->count, req->size);
+    }
+}
+
+static int handle_buffered_iopage(XenIOState *state)
+{
+    buffered_iopage_t *buf_page = state->buffered_io_page;
+    buf_ioreq_t *buf_req = NULL;
+    ioreq_t req;
+    int qw;
+
+    if (!buf_page) {
+        return 0;
+    }
+
+    memset(&req, 0x00, sizeof(req));
+    req.state = STATE_IOREQ_READY;
+    req.count = 1;
+    req.dir = IOREQ_WRITE;
+
+    for (;;) {
+        uint32_t rdptr = buf_page->read_pointer, wrptr;
+
+        xen_rmb();
+        wrptr = buf_page->write_pointer;
+        xen_rmb();
+        if (rdptr != buf_page->read_pointer) {
+            continue;
+        }
+        if (rdptr == wrptr) {
+            break;
+        }
+        buf_req = &buf_page->buf_ioreq[rdptr % IOREQ_BUFFER_SLOT_NUM];
+        req.size = 1U << buf_req->size;
+        req.addr = buf_req->addr;
+        req.data = buf_req->data;
+        req.type = buf_req->type;
+        xen_rmb();
+        qw = (req.size == 8);
+        if (qw) {
+            if (rdptr + 1 == wrptr) {
+                hw_error("Incomplete quad word buffered ioreq");
+            }
+            buf_req = &buf_page->buf_ioreq[(rdptr + 1) %
+                                           IOREQ_BUFFER_SLOT_NUM];
+            req.data |= ((uint64_t)buf_req->data) << 32;
+            xen_rmb();
+        }
+
+        handle_ioreq(state, &req);
+
+        /* Only req.data may get updated by handle_ioreq(), albeit even that
+         * should not happen as such data would never make it to the guest (we
+         * can only usefully see writes here after all).
+         */
+        assert(req.state == STATE_IOREQ_READY);
+        assert(req.count == 1);
+        assert(req.dir == IOREQ_WRITE);
+        assert(!req.data_is_ptr);
+
+        qatomic_add(&buf_page->read_pointer, qw + 1);
+    }
+
+    return req.count;
+}
+
+static void handle_buffered_io(void *opaque)
+{
+    XenIOState *state = opaque;
+
+    if (handle_buffered_iopage(state)) {
+        timer_mod(state->buffered_io_timer,
+                BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME));
+    } else {
+        timer_del(state->buffered_io_timer);
+        xenevtchn_unmask(state->xce_handle, state->bufioreq_local_port);
+    }
+}
+
+static void cpu_handle_ioreq(void *opaque)
+{
+    XenIOState *state = opaque;
+    ioreq_t *req = cpu_get_ioreq(state);
+
+    handle_buffered_iopage(state);
+    if (req) {
+        ioreq_t copy = *req;
+
+        xen_rmb();
+        handle_ioreq(state, &copy);
+        req->data = copy.data;
+
+        if (req->state != STATE_IOREQ_INPROCESS) {
+            fprintf(stderr, "Badness in I/O request ... not in service?!: "
+                    "%x, ptr: %x, port: %"PRIx64", "
+                    "data: %"PRIx64", count: %u, size: %u, type: %u\n",
+                    req->state, req->data_is_ptr, req->addr,
+                    req->data, req->count, req->size, req->type);
+            destroy_hvm_domain(false);
+            return;
+        }
+
+        xen_wmb(); /* Update ioreq contents /then/ update state. */
+
+        /*
+         * We do this before we send the response so that the tools
+         * have the opportunity to pick up on the reset before the
+         * guest resumes and does a hlt with interrupts disabled which
+         * causes Xen to powerdown the domain.
+         */
+        if (runstate_is_running()) {
+            ShutdownCause request;
+
+            if (qemu_shutdown_requested_get()) {
+                destroy_hvm_domain(false);
+            }
+            request = qemu_reset_requested_get();
+            if (request) {
+                qemu_system_reset(request);
+                destroy_hvm_domain(true);
+            }
+        }
+
+        req->state = STATE_IORESP_READY;
+        xenevtchn_notify(state->xce_handle,
+                         state->ioreq_local_port[state->send_vcpu]);
+    }
+}
+
+static void xen_main_loop_prepare(XenIOState *state)
+{
+    int evtchn_fd = -1;
+
+    if (state->xce_handle != NULL) {
+        evtchn_fd = xenevtchn_fd(state->xce_handle);
+    }
+
+    state->buffered_io_timer = timer_new_ms(QEMU_CLOCK_REALTIME, handle_buffered_io,
+                                                 state);
+
+    if (evtchn_fd != -1) {
+        CPUState *cpu_state;
+
+        DPRINTF("%s: Init cpu_by_vcpu_id\n", __func__);
+        CPU_FOREACH(cpu_state) {
+            DPRINTF("%s: cpu_by_vcpu_id[%d]=%p\n",
+                    __func__, cpu_state->cpu_index, cpu_state);
+            state->cpu_by_vcpu_id[cpu_state->cpu_index] = cpu_state;
+        }
+        qemu_set_fd_handler(evtchn_fd, cpu_handle_ioreq, NULL, state);
+    }
+}
+
+
+void xen_hvm_change_state_handler(void *opaque, bool running,
+                                         RunState rstate)
+{
+    XenIOState *state = opaque;
+
+    if (running) {
+        xen_main_loop_prepare(state);
+    }
+
+    xen_set_ioreq_server_state(xen_domid,
+                               state->ioservid,
+                               (rstate == RUN_STATE_RUNNING));
+}
+
+void xen_exit_notifier(Notifier *n, void *data)
+{
+    XenIOState *state = container_of(n, XenIOState, exit);
+
+    xen_destroy_ioreq_server(xen_domid, state->ioservid);
+
+    xenevtchn_close(state->xce_handle);
+    xs_daemon_close(state->xenstore);
+}
+
+static int xen_map_ioreq_server(XenIOState *state)
+{
+    void *addr = NULL;
+    xenforeignmemory_resource_handle *fres;
+    xen_pfn_t ioreq_pfn;
+    xen_pfn_t bufioreq_pfn;
+    evtchn_port_t bufioreq_evtchn;
+    int rc;
+
+    /*
+     * Attempt to map using the resource API and fall back to normal
+     * foreign mapping if this is not supported.
+     */
+    QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_bufioreq != 0);
+    QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_ioreq(0) != 1);
+    fres = xenforeignmemory_map_resource(xen_fmem, xen_domid,
+                                         XENMEM_resource_ioreq_server,
+                                         state->ioservid, 0, 2,
+                                         &addr,
+                                         PROT_READ | PROT_WRITE, 0);
+    if (fres != NULL) {
+        trace_xen_map_resource_ioreq(state->ioservid, addr);
+        state->buffered_io_page = addr;
+        state->shared_page = addr + TARGET_PAGE_SIZE;
+    } else if (errno != EOPNOTSUPP) {
+        error_report("failed to map ioreq server resources: error %d handle=%p",
+                     errno, xen_xc);
+        return -1;
+    }
+
+    rc = xen_get_ioreq_server_info(xen_domid, state->ioservid,
+                                   (state->shared_page == NULL) ?
+                                   &ioreq_pfn : NULL,
+                                   (state->buffered_io_page == NULL) ?
+                                   &bufioreq_pfn : NULL,
+                                   &bufioreq_evtchn);
+    if (rc < 0) {
+        error_report("failed to get ioreq server info: error %d handle=%p",
+                     errno, xen_xc);
+        return rc;
+    }
+
+    if (state->shared_page == NULL) {
+        DPRINTF("shared page at pfn %lx\n", ioreq_pfn);
+
+        state->shared_page = xenforeignmemory_map(xen_fmem, xen_domid,
+                                                  PROT_READ | PROT_WRITE,
+                                                  1, &ioreq_pfn, NULL);
+        if (state->shared_page == NULL) {
+            error_report("map shared IO page returned error %d handle=%p",
+                         errno, xen_xc);
+        }
+    }
+
+    if (state->buffered_io_page == NULL) {
+        DPRINTF("buffered io page at pfn %lx\n", bufioreq_pfn);
+
+        state->buffered_io_page = xenforeignmemory_map(xen_fmem, xen_domid,
+                                                       PROT_READ | PROT_WRITE,
+                                                       1, &bufioreq_pfn,
+                                                       NULL);
+        if (state->buffered_io_page == NULL) {
+            error_report("map buffered IO page returned error %d", errno);
+            return -1;
+        }
+    }
+
+    if (state->shared_page == NULL || state->buffered_io_page == NULL) {
+        return -1;
+    }
+
+    DPRINTF("buffered io evtchn is %x\n", bufioreq_evtchn);
+
+    state->bufioreq_remote_port = bufioreq_evtchn;
+
+    return 0;
+}
+
+void destroy_hvm_domain(bool reboot)
+{
+    xc_interface *xc_handle;
+    int sts;
+    int rc;
+
+    unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff;
+
+    if (xen_dmod) {
+        rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason);
+        if (!rc) {
+            return;
+        }
+        if (errno != ENOTTY /* old Xen */) {
+            perror("xendevicemodel_shutdown failed");
+        }
+        /* well, try the old thing then */
+    }
+
+    xc_handle = xc_interface_open(0, 0, 0);
+    if (xc_handle == NULL) {
+        fprintf(stderr, "Cannot acquire xenctrl handle\n");
+    } else {
+        sts = xc_domain_shutdown(xc_handle, xen_domid, reason);
+        if (sts != 0) {
+            fprintf(stderr, "xc_domain_shutdown failed to issue %s, "
+                    "sts %d, %s\n", reboot ? "reboot" : "poweroff",
+                    sts, strerror(errno));
+        } else {
+            fprintf(stderr, "Issued domain %d %s\n", xen_domid,
+                    reboot ? "reboot" : "poweroff");
+        }
+        xc_interface_close(xc_handle);
+    }
+}
+
+void xen_shutdown_fatal_error(const char *fmt, ...)
+{
+    va_list ap;
+
+    va_start(ap, fmt);
+    vfprintf(stderr, fmt, ap);
+    va_end(ap);
+    fprintf(stderr, "Will destroy the domain.\n");
+    /* destroy the domain */
+    qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR);
+}
+
+void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
+                        MemoryListener xen_memory_listener)
+{
+    int i, rc;
+
+    state->xce_handle = xenevtchn_open(NULL, 0);
+    if (state->xce_handle == NULL) {
+        perror("xen: event channel open");
+        goto err;
+    }
+
+    state->xenstore = xs_daemon_open();
+    if (state->xenstore == NULL) {
+        perror("xen: xenstore open");
+        goto err;
+    }
+
+    xen_create_ioreq_server(xen_domid, &state->ioservid);
+
+    state->exit.notify = xen_exit_notifier;
+    qemu_add_exit_notifier(&state->exit);
+
+    /*
+     * Register wake-up support in QMP query-current-machine API
+     */
+    qemu_register_wakeup_support();
+
+    rc = xen_map_ioreq_server(state);
+    if (rc < 0) {
+        goto err;
+    }
+
+    /* Note: cpus is empty at this point in init */
+    state->cpu_by_vcpu_id = g_malloc0(max_cpus * sizeof(CPUState *));
+
+    rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true);
+    if (rc < 0) {
+        error_report("failed to enable ioreq server info: error %d handle=%p",
+                     errno, xen_xc);
+        goto err;
+    }
+
+    state->ioreq_local_port = g_malloc0(max_cpus * sizeof (evtchn_port_t));
+
+    /* FIXME: how about if we overflow the page here? */
+    for (i = 0; i < max_cpus; i++) {
+        rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid,
+                                        xen_vcpu_eport(state->shared_page, i));
+        if (rc == -1) {
+            error_report("shared evtchn %d bind error %d", i, errno);
+            goto err;
+        }
+        state->ioreq_local_port[i] = rc;
+    }
+
+    rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid,
+                                    state->bufioreq_remote_port);
+    if (rc == -1) {
+        error_report("buffered evtchn bind error %d", errno);
+        goto err;
+    }
+    state->bufioreq_local_port = rc;
+
+    /* Init RAM management */
+#ifdef XEN_COMPAT_PHYSMAP
+    xen_map_cache_init(xen_phys_offset_to_gaddr, state);
+#else
+    xen_map_cache_init(NULL, state);
+#endif
+
+    qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
+
+    state->memory_listener = xen_memory_listener;
+    memory_listener_register(&state->memory_listener, &address_space_memory);
+
+    state->io_listener = xen_io_listener;
+    memory_listener_register(&state->io_listener, &address_space_io);
+
+    state->device_listener = xen_device_listener;
+    QLIST_INIT(&state->dev_list);
+    device_listener_register(&state->device_listener);
+
+    xen_bus_init();
+
+    /* Initialize backend core & drivers */
+    if (xen_be_init() != 0) {
+        error_report("xen backend core setup failed");
+        goto err;
+    }
+    xen_be_register_common();
+
+    return;
+err:
+    error_report("xen hardware virtual machine initialisation failed");
+    exit(1);
+}
diff --git a/include/hw/i386/xen_arch_hvm.h b/include/hw/i386/xen_arch_hvm.h
index 1b2c71ba4f..1000f8f543 100644
--- a/include/hw/i386/xen_arch_hvm.h
+++ b/include/hw/i386/xen_arch_hvm.h
@@ -2,6 +2,7 @@
 #define HW_XEN_ARCH_I386_HVM_H
 
 #include <xen/hvm/ioreq.h>
+#include "hw/xen/xen-hvm-common.h"
 
 void arch_handle_ioreq(XenIOState *state, ioreq_t *req);
 void arch_xen_set_memory(XenIOState *state,
diff --git a/include/hw/xen/xen-hvm-common.h b/include/hw/xen/xen-hvm-common.h
new file mode 100644
index 0000000000..c16057835f
--- /dev/null
+++ b/include/hw/xen/xen-hvm-common.h
@@ -0,0 +1,97 @@
+#ifndef HW_XEN_HVM_COMMON_H
+#define HW_XEN_HVM_COMMON_H
+
+#include "qemu/osdep.h"
+#include "qemu/units.h"
+
+#include "cpu.h"
+#include "hw/pci/pci.h"
+#include "hw/hw.h"
+#include "hw/xen/xen_common.h"
+#include "sysemu/runstate.h"
+#include "sysemu/sysemu.h"
+#include "sysemu/xen.h"
+#include "sysemu/xen-mapcache.h"
+
+#include <xen/hvm/ioreq.h>
+
+extern MemoryRegion ram_memory;
+extern MemoryListener xen_io_listener;
+extern DeviceListener xen_device_listener;
+
+//#define DEBUG_XEN_HVM
+
+#ifdef DEBUG_XEN_HVM
+#define DPRINTF(fmt, ...) \
+    do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0)
+#else
+#define DPRINTF(fmt, ...) \
+    do { } while (0)
+#endif
+
+static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i)
+{
+    return shared_page->vcpu_ioreq[i].vp_eport;
+}
+static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu)
+{
+    return &shared_page->vcpu_ioreq[vcpu];
+}
+
+#define BUFFER_IO_MAX_DELAY  100
+
+typedef struct XenPhysmap {
+    hwaddr start_addr;
+    ram_addr_t size;
+    const char *name;
+    hwaddr phys_offset;
+
+    QLIST_ENTRY(XenPhysmap) list;
+} XenPhysmap;
+
+typedef struct XenPciDevice {
+    PCIDevice *pci_dev;
+    uint32_t sbdf;
+    QLIST_ENTRY(XenPciDevice) entry;
+} XenPciDevice;
+
+typedef struct XenIOState {
+    ioservid_t ioservid;
+    shared_iopage_t *shared_page;
+    buffered_iopage_t *buffered_io_page;
+    QEMUTimer *buffered_io_timer;
+    CPUState **cpu_by_vcpu_id;
+    /* the evtchn port for polling the notification, */
+    evtchn_port_t *ioreq_local_port;
+    /* evtchn remote and local ports for buffered io */
+    evtchn_port_t bufioreq_remote_port;
+    evtchn_port_t bufioreq_local_port;
+    /* the evtchn fd for polling */
+    xenevtchn_handle *xce_handle;
+    /* which vcpu we are serving */
+    int send_vcpu;
+
+    struct xs_handle *xenstore;
+    MemoryListener memory_listener;
+    MemoryListener io_listener;
+    QLIST_HEAD(, XenPciDevice) dev_list;
+    DeviceListener device_listener;
+
+    Notifier exit;
+} XenIOState;
+
+void xen_exit_notifier(Notifier *n, void *data);
+
+void xen_region_add(MemoryListener *listener, MemoryRegionSection *section);
+void xen_region_del(MemoryListener *listener, MemoryRegionSection *section);
+void xen_io_add(MemoryListener *listener, MemoryRegionSection *section);
+void xen_io_del(MemoryListener *listener, MemoryRegionSection *section);
+void xen_device_realize(DeviceListener *listener, DeviceState *dev);
+void xen_device_unrealize(DeviceListener *listener, DeviceState *dev);
+
+void xen_hvm_change_state_handler(void *opaque, bool running, RunState rstate);
+void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
+                        MemoryListener xen_memory_listener);
+
+void cpu_ioreq_pio(ioreq_t *req);
+#endif /* HW_XEN_HVM_COMMON_H */
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 05:08:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 05:08:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423255.669907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPm-0000CU-KK; Sat, 15 Oct 2022 05:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423255.669907; Sat, 15 Oct 2022 05:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojZPm-000096-7F; Sat, 15 Oct 2022 05:08:50 +0000
Received: by outflank-mailman (input) for mailman id 423255;
 Sat, 15 Oct 2022 05:08:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q/I2=2Q=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ojZPj-00070V-SY
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 05:08:48 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 709c7ba9-4c47-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 07:08:44 +0200 (CEST)
Received: from DM6PR06CA0102.namprd06.prod.outlook.com (2603:10b6:5:336::35)
 by CY8PR12MB7339.namprd12.prod.outlook.com (2603:10b6:930:51::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Sat, 15 Oct
 2022 05:08:40 +0000
Received: from DM6NAM11FT042.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:336:cafe::48) by DM6PR06CA0102.outlook.office365.com
 (2603:10b6:5:336::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Sat, 15 Oct 2022 05:08:39 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT042.mail.protection.outlook.com (10.13.173.165) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Sat, 15 Oct 2022 05:08:39 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sat, 15 Oct
 2022 00:08:38 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 14 Oct
 2022 22:08:37 -0700
Received: from xsjfnuv50.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend
 Transport; Sat, 15 Oct 2022 00:08:36 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 709c7ba9-4c47-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=COgY6/WsweW7TxMKsZHUiHg1OGNGlRmXQHeJSTYnNbFvok4cpx1WgCOXqV6YqSbOBpGUELAeggzwBEsBcApdU0FO7coInlynqPrUCStNulffkHHWcjWb2ud2sQfaFgQh2k8sX0oqJc/OKcfzbWsgFzAGGxaGzYkAyYhkrvGnwc7ZAobhzlHmC2z131HsVIWSBxTBY0da6m5n+AZv1ZiX+Jpd1cLJIx2A2sDAi3NZortiVihydy9PRDzob0av+brA2NzqJPT0N3I49chaAITUgg8EEPt3yl8a6+xxCQugvHzJSoV5a2kifIroG8I1leAIVDuHSDYS+NtE5ywFsPwbQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5CEATXZaI6umGGfkvA0WXkPnboEbXOEtyJhSWhppcG4=;
 b=OVsgh8g2q9gPeejRSIUUQHg24dY/zvqXUnyKs0d7Pg3rrTQJydB2Q92cT1JVCvttiBJcu/BoWKPVGMq8VGn/SwOiyMfzEO5JtHEeQ0NWdLB+GObzKtHkOcvn6N9J+KOvy2qe/VR2e2d4D5YLSXm3OsfoEgVwolg/ndHQvU5Y5+Nw0w3ANg+UOeVMqO3GlEpiXnt9p8BHWuBp9rpj2G8+abmkzz3OnNbLKpoMP7Sss+w2pKQsyINuRGvzug48ngrJXvx6qwPG12QYYO072vxxdv7oXvi8c2EAQETcZaZrhaMMJxt8zU7gFYCkD/lx1mYv0ofSjxcYekDpN2BziHqZyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5CEATXZaI6umGGfkvA0WXkPnboEbXOEtyJhSWhppcG4=;
 b=bCLZFLrKcP3oYsZo2MTCi5uZmCIUe15AaU47ebRt5Fc/ZKuqHf3H6IGjTRHohznUWEl5rgZYXyxnoArsV4P7T/ykXkgP32+OY6aCsLYJDDLnrWlwG0djsJEyTsRnKFWkANqbf6h1+WvurLtnMoqtLHZ3BMBaJXX8qKeTKVoiAuw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Vikram Garhwal <vikram.garhwal@amd.com>
To: <qemu-devel@nongnu.org>
CC: <vikram.garhwal@amd.com>, <stefano.stabellini@amd.com>, Peter Maydell
	<peter.maydell@linaro.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
	"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Date: Fri, 14 Oct 2022 22:07:48 -0700
Message-ID: <20221015050750.4185-11-vikram.garhwal@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221015050750.4185-1-vikram.garhwal@amd.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT042:EE_|CY8PR12MB7339:EE_
X-MS-Office365-Filtering-Correlation-Id: ef28c65d-b6c9-4dd6-c49e-08daae6b5293
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Cw6BE2WvYbEM/RcM4ry6VYtOSiys0o/6pDPo2n1BD6oOti2BfWPOkmmdBcc+17s08FbWM+gG2BZA7UVLP3eL7pbto5T495FSKUSRmFirh7jD6aZo0oZRZ7Zjv2qtFL9BS49G1VFL1VTPmYTWQEPR4lVNYk6hyGyYWam/epYx24k6jb6q6wK41Am6x7jKgfvenlLa/FRm4xLJUBBWlecg8yvzTY++pygppBCkhH8a8rnAKoi3R1oUYVbMsAJ/FerldKD+UOWFUaMaK2F7O0v2XedBBP0ufU4jZqMoHjSdF5t1tbDlTpYq/jtC88q5xg55U82bLANadtzcEA1wnp3hozDRP3vuBr9digsSgaPC8lXiF1aUyeBVJNV4SHjy+vdAeu3LtoFMOMMNJkYw+m8kyjNYDqJk7C6YdetPAlrxPECJog1Gcfz/DQVSBaFhs41QbWn++fiiVp3KX1x8gOccYRkpFJix/F6lc2LQQuOe5qCPcZiw4Z9U1KEWkI1r5atKJ0lLsKHnRWcDOKcByT84mdek2Xpa0ac0rsaxkDiwuROUth+Eud6co8r8/s7MSC3XXySqAvbziLbQm0yioVO+3y+tP4NvK29fnuOjP/oLQR5lBapFB2AjgrwgCntSYjZWxMk1h7eT39Jxok/xrlfsuS56Z7hItrHEJ09UABzfMt4lYkvp/DkPO21W6kteoo1fugGC0RviFxdJnJEpkEc4ZsnYKfcobYyOb2bdo5+aDpAui7ktLO5Gf3OptPxkr0rWAm5TRR4MExlrO33XVBP3GNT16wfPtpMaI07Yh2GW2kYDhMTWyJutPHA7DHoSjO8ApvrzUxyCEVTPR7Y8X4r1QQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(40460700003)(40480700001)(2616005)(2906002)(4326008)(82740400003)(86362001)(26005)(8936002)(6916009)(70206006)(1076003)(186003)(54906003)(336012)(8676002)(6666004)(5660300002)(82310400005)(478600001)(356005)(81166007)(44832011)(316002)(966005)(70586007)(36860700001)(426003)(66899015)(47076005)(41300700001)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 05:08:39.5714
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ef28c65d-b6c9-4dd6-c49e-08daae6b5293
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT042.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7339

Add a new machine xenpv which creates a IOREQ server to register/connect with
Xen Hypervisor.

Xen IOREQ connection expect the TARGET_PAGE_SIZE to 4096, and the xenpv machine
on ARM will have no CPU definitions. We need to define TARGET_PAGE_SIZE
appropriately ourselves.

Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a
TPM emulator and connects to swtpm running on host machine via chardev socket
and support TPM functionalities for a guest domain.

Extra command line for aarch64 xenpv QEMU to connect to swtpm:
    -chardev socket,id=chrtpm,path=/tmp/myvtpm2/swtpm-sock \
    -tpmdev emulator,id=tpm0,chardev=chrtpm \

swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on libtpms and
provides access to TPM functionality over socket, chardev and CUSE interface.
Github repo: https://github.com/stefanberger/swtpm
Example for starting swtpm on host machine:
    mkdir /tmp/vtpm2
    swtpm socket --tpmstate dir=/tmp/vtpm2 \
    --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock &

Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
 hw/arm/meson.build            |   2 +
 hw/arm/xen_arm.c              | 163 ++++++++++++++++++++++++++++++++++
 include/hw/arm/xen_arch_hvm.h |  12 +++
 include/hw/xen/arch_hvm.h     |   2 +
 4 files changed, 179 insertions(+)
 create mode 100644 hw/arm/xen_arm.c
 create mode 100644 include/hw/arm/xen_arch_hvm.h

diff --git a/hw/arm/meson.build b/hw/arm/meson.build
index 92f9f6e000..0cae024374 100644
--- a/hw/arm/meson.build
+++ b/hw/arm/meson.build
@@ -62,5 +62,7 @@ arm_ss.add(when: 'CONFIG_FSL_IMX7', if_true: files('fsl-imx7.c', 'mcimx7d-sabre.
 arm_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmu-common.c', 'smmuv3.c'))
 arm_ss.add(when: 'CONFIG_FSL_IMX6UL', if_true: files('fsl-imx6ul.c', 'mcimx6ul-evk.c'))
 arm_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_soc.c'))
+arm_ss.add(when: 'CONFIG_XEN', if_true: files('xen_arm.c'))
+arm_ss.add_all(xen_ss)
 
 hw_arch += {'arm': arm_ss}
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c
new file mode 100644
index 0000000000..0b900314cc
--- /dev/null
+++ b/hw/arm/xen_arm.c
@@ -0,0 +1,163 @@
+/*
+ * QEMU ARM Xen PV Machine
+ *
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+#include "qemu/osdep.h"
+#include "qemu/error-report.h"
+#include "qapi/qapi-commands-migration.h"
+#include "hw/boards.h"
+#include "hw/sysbus.h"
+#include "sysemu/block-backend.h"
+#include "sysemu/tpm_backend.h"
+#include "sysemu/sysemu.h"
+#include "hw/xen/xen-legacy-backend.h"
+#include "hw/xen/xen-hvm-common.h"
+#include "sysemu/tpm.h"
+#include "hw/xen/arch_hvm.h"
+
+#define TYPE_XEN_ARM  MACHINE_TYPE_NAME("xenpv")
+OBJECT_DECLARE_SIMPLE_TYPE(XenArmState, XEN_ARM)
+
+static MemoryListener xen_memory_listener = {
+    .region_add = xen_region_add,
+    .region_del = xen_region_del,
+    .log_start = NULL,
+    .log_stop = NULL,
+    .log_sync = NULL,
+    .log_global_start = NULL,
+    .log_global_stop = NULL,
+    .priority = 10,
+};
+
+struct XenArmState {
+    /*< private >*/
+    MachineState parent;
+
+    XenIOState *state;
+};
+
+void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
+{
+    hw_error("Invalid ioreq type 0x%x\n", req->type);
+
+    return;
+}
+
+void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section,
+                         bool add)
+{
+}
+
+void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
+{
+}
+
+void qmp_xen_set_global_dirty_log(bool enable, Error **errp)
+{
+}
+
+static int xen_init_ioreq(XenIOState *state, unsigned int max_cpus)
+{
+    xen_dmod = xendevicemodel_open(0, 0);
+    xen_xc = xc_interface_open(0, 0, 0);
+
+    if (xen_xc == NULL) {
+        perror("xen: can't open xen interface\n");
+        return -1;
+    }
+
+    xen_fmem = xenforeignmemory_open(0, 0);
+    if (xen_fmem == NULL) {
+        perror("xen: can't open xen fmem interface\n");
+        xc_interface_close(xen_xc);
+        return -1;
+    }
+
+    xen_register_ioreq(state, max_cpus, xen_memory_listener);
+
+    xenstore_record_dm_state(xenstore, "running");
+
+    return 0;
+}
+
+static void xen_enable_tpm(void)
+{
+/* qemu_find_tpm_be is only available when CONFIG_TPM is enabled. */
+#ifdef CONFIG_TPM
+    Error *errp = NULL;
+    DeviceState *dev;
+    SysBusDevice *busdev;
+
+    TPMBackend *be = qemu_find_tpm_be("tpm0");
+    if (be == NULL) {
+        DPRINTF("Couldn't fine the backend for tpm0\n");
+        return;
+    }
+    dev = qdev_new(TYPE_TPM_TIS_SYSBUS);
+    object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp);
+    object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
+    busdev = SYS_BUS_DEVICE(dev);
+    sysbus_realize_and_unref(busdev, &error_fatal);
+    sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);
+
+    DPRINTF("Connected tpmdev at address 0x%lx\n", GUEST_TPM_BASE);
+#endif
+}
+
+static void xen_arm_init(MachineState *machine)
+{
+    XenArmState *xam = XEN_ARM(machine);
+
+    xam->state =  g_new0(XenIOState, 1);
+
+    if (xen_init_ioreq(xam->state, machine->smp.cpus)) {
+        return;
+    }
+
+    xen_enable_tpm();
+
+    return;
+}
+
+static void xen_arm_machine_class_init(ObjectClass *oc, void *data)
+{
+
+    MachineClass *mc = MACHINE_CLASS(oc);
+    mc->desc = "Xen Para-virtualized PC";
+    mc->init = xen_arm_init;
+    mc->max_cpus = 1;
+    machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);
+}
+
+static const TypeInfo xen_arm_machine_type = {
+    .name = TYPE_XEN_ARM,
+    .parent = TYPE_MACHINE,
+    .class_init = xen_arm_machine_class_init,
+    .instance_size = sizeof(XenArmState),
+};
+
+static void xen_arm_machine_register_types(void)
+{
+    type_register_static(&xen_arm_machine_type);
+}
+
+type_init(xen_arm_machine_register_types)
diff --git a/include/hw/arm/xen_arch_hvm.h b/include/hw/arm/xen_arch_hvm.h
new file mode 100644
index 0000000000..f645dfec28
--- /dev/null
+++ b/include/hw/arm/xen_arch_hvm.h
@@ -0,0 +1,12 @@
+#ifndef HW_XEN_ARCH_ARM_HVM_H
+#define HW_XEN_ARCH_ARM_HVM_H
+
+#include <xen/hvm/ioreq.h>
+void arch_handle_ioreq(XenIOState *state, ioreq_t *req);
+void arch_xen_set_memory(XenIOState *state,
+                         MemoryRegionSection *section,
+                         bool add);
+
+#undef TARGET_PAGE_SIZE
+#define TARGET_PAGE_SIZE 4096
+#endif
diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
index 26674648d8..c7c515220d 100644
--- a/include/hw/xen/arch_hvm.h
+++ b/include/hw/xen/arch_hvm.h
@@ -1,3 +1,5 @@
 #if defined(TARGET_I386) || defined(TARGET_X86_64)
 #include "hw/i386/xen_arch_hvm.h"
+#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
+#include "hw/arm/xen_arch_hvm.h"
 #endif
-- 
2.17.0



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 07:58:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 07:58:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423319.669975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojc3c-0003VD-B1; Sat, 15 Oct 2022 07:58:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423319.669975; Sat, 15 Oct 2022 07:58:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojc3c-0003V6-8J; Sat, 15 Oct 2022 07:58:08 +0000
Received: by outflank-mailman (input) for mailman id 423319;
 Sat, 15 Oct 2022 07:58:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojc3a-0003Ut-Sb; Sat, 15 Oct 2022 07:58:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojc3a-0004Dc-Rm; Sat, 15 Oct 2022 07:58:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojc3a-00077Q-FX; Sat, 15 Oct 2022 07:58:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojc3a-0006NF-F0; Sat, 15 Oct 2022 07:58:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zpRnINP3Q4O7lR2npt6JT79KU/h1G4qXdSVP/Ukwp+Q=; b=pXZLsr99b6DINc7btqp5dRYDVE
	cgu0GozjhTGV5ndpwhokNKTISgWnQe3LvD9Aycmv8Jht4K9TPoFmyltJlI1NxOyFjDEZfSdpBROtm
	ys/sPq1dB2bcR6vr6jO4qWVCOiy0L+ShIwfG6Fu0yCBGF1n1MqowXQF1gGGALKNrUh1g=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173800-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173800: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 07:58:06 +0000

flight 173800 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173800/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    7 days
Failing since        173492  2022-10-11 13:01:50 Z    3 days   22 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 08:09:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 08:09:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423329.669987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojcEv-0005b5-OS; Sat, 15 Oct 2022 08:09:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423329.669987; Sat, 15 Oct 2022 08:09:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojcEv-0005ay-Kz; Sat, 15 Oct 2022 08:09:49 +0000
Received: by outflank-mailman (input) for mailman id 423329;
 Sat, 15 Oct 2022 08:09:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcEu-0005ao-B4; Sat, 15 Oct 2022 08:09:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcEu-0004xa-65; Sat, 15 Oct 2022 08:09:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcEt-0007p1-Rp; Sat, 15 Oct 2022 08:09:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcEt-0004cR-RM; Sat, 15 Oct 2022 08:09:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ciNN6QQKBhQKPTj7wX/seDZIhwSJYechQtC7CN/cAwM=; b=HwYpHgedtqebVYr9/WgI7pHlgl
	0N+3PVMvEqyoJZhk1GPIhYpnmSx1UoFOeCSzZM6JZvB1D+473yWFuoRvY4qzK+lc0+hHfs9IvLtyD
	ZQenl2jP622GVP/3+0NiKdbokC7kQGlyT+pNMkuCbMN8CVtHJilGqWEyxRUMNWiYIGoo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173738-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173738: tolerable trouble: fail/pass/starved
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 08:09:47 +0000

flight 173738 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173738/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-examine-uefi  6 xen-install      fail in 173663 pass in 173738
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173663

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 173663 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 173663 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173663
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173663
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173663
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173663
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173663
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173663
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173663
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173663
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173663
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173663
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173663
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173663
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle   3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173738  2022-10-14 01:51:47 Z    1 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  starved 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 08:41:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 08:41:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423342.670010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojcjW-0001cW-Fp; Sat, 15 Oct 2022 08:41:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423342.670010; Sat, 15 Oct 2022 08:41:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojcjW-0001cP-D2; Sat, 15 Oct 2022 08:41:26 +0000
Received: by outflank-mailman (input) for mailman id 423342;
 Sat, 15 Oct 2022 08:41:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcjV-0001c9-Pg; Sat, 15 Oct 2022 08:41:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcjV-0005T3-N0; Sat, 15 Oct 2022 08:41:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcjV-0001a8-98; Sat, 15 Oct 2022 08:41:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojcjV-00072y-8e; Sat, 15 Oct 2022 08:41:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NxDKKSqi0oZ9NDN8JrpNm25ZGaH1doJ/3HQxzVEeJiQ=; b=GwMT3+tAYjo+CLTd6B4q3eI9FM
	RpeIcXeSVLFuXyi540f6Bm9NgvymAVEJsavl9vW2GVAvcmTp0wa90vV3Puly4PnseTew/EH28sXT+
	/a475sD0Hji6DF6lfQ+T5Vujcsy1wuzFxttpgXwzqyhbkrnTFksU+gsezPAZEvrxWOyU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173735-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173735: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 08:41:25 +0000

flight 173735 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173735/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   60 days
Failing since        173495  2022-10-11 14:08:01 Z    3 days    5 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 09:28:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 09:28:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423361.670039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojdSu-0006Ml-9Y; Sat, 15 Oct 2022 09:28:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423361.670039; Sat, 15 Oct 2022 09:28:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojdSu-0006Me-6g; Sat, 15 Oct 2022 09:28:20 +0000
Received: by outflank-mailman (input) for mailman id 423361;
 Sat, 15 Oct 2022 09:28:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojdSs-0006MF-Su
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 09:28:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojdSo-0006GA-3b; Sat, 15 Oct 2022 09:28:14 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojdSn-0006y8-Sd; Sat, 15 Oct 2022 09:28:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=EU66632BftsRItb1s5d2r5oE8T7yAs3KaKi+4rjg774=; b=YsHcfO41OUwjOaFeZuugufad3N
	taM7Uuj9R2huez26eES+WFxkRYXQ4Duh5XEC9Oa7pwLdduYsAyrEeLucwK/CWWfbhwcFvfuDK42QI
	+bA9fgb7W9QKTv4HG5bn9uryTpt93CwOrwtkcjSU1rqCrZLippBShFZtk0UEJNr0e/9A=;
Message-ID: <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
Date: Sat, 15 Oct 2022 10:28:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Stefano Stabellini <sstabellini@kernel.org>,
 Ayan Kumar Halder <ayankuma@amd.com>
Cc: "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>,
 Jaxson Han <jaxson.han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
In-Reply-To: <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 14/10/2022 19:09, Stefano Stabellini wrote:
> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
>> Hi Arm mantainers/Folks,
>>
>> Please refer to the discussion
>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>
>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed virtual
>> platform.
>>
>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using ldrd
>> instruction.
>>
>> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
>> 0x9200000c.
>>
>> As ISV is 0, so Xen cannot emulate this instruction.
>>
>> The proposed solution is to use two sys_read32() on GICR_TYPER to return the
>> lower and upper 32 bits.
>>
>> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
> 
> Hi all,
> 
> I wanted to take a step back on this issue before we jump into the
> details.
> 
> 
> Differently from other instructions we discussed in the past, strd and ldrd
> are not deprecated and are not "unusual corner cases". There is no
> statements such as "please don't use this" on the ARM ARM. If I were to
> write an register read/write function in assembly for an RTOS, it would
> be reasonable to use them.

Just to be clear it is fine to use the ldrd/strd for accessing non MMIO 
area. The problem comes with MMIO access because they can be emulated by 
the hypervisor and we don't have the syndrome. At the moment, this is 
only a problem when accessing some of the GICv3 (including ITS) registers.

> 
> So, I struggle to see how we'll be able to deal with all the possible
> RTOSes out there that might have them in the code. We can fix Zephyr,
> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
> etc.)?

This is not an Xen issue but architecture issue. The RTOSes will face 
the exact same issue on any hypervisors unless they decided to decode 
the instruction.

As we discussed before decoding an instruction correctly is quite 
difficult to do (what we have in Xen for pos-increment store/load is 
just a band-aid). So I would expect the other hypervisors to have made 
the decision to not implement it. AFAIK KVM doesn't suppor them,
Note that looking at ID_ISAR2, it seems that ldrd/strd is technically 
optional. Therefore, the RTOS would have to assume it is targeting a 
processor that supports them.

> 
> Unless we can get ARM to issue a clear guidance that strd and ldrd are
> deprecated, 

Arm Arm cannot say that because ldrd/strd are necessary to modify the 
LPAE page-tables atomically. What we need to know is which instructions 
can be allowed on MMIO accesses.

I think I already raised that when Ayan added decoding for 
post-increment instructions. There are plenty of instructions (or 
combinations) that doesn't provide a syndrome and yet the processor 
doesn't prevent anyone to use them on MMIO.

I was worry we are going to have to continue to decode instructions in a 
non-compliant way in Xen just to please a few RTOs that may not even run 
anywhere else.

This would also reduce our leverage to request a change in the RTOes or 
the Arm Arm (maybe there is already a statement I haven't spotted) 
because Xen will already (badly) support the instruction.

> I think it would be better to attempt to decode them rather
> than just fail. I don't like to have this kind of code in Xen, but I
> don't see a way to support R52s without it.
That's not specific to R52. This is anyone using GICv3 on Arm32 core.

> 
> That said, of course if Zephyr was to use two 32-bit reads instead of
> one 64-bit read, it would be better for Xen. And we have more important
> things to deal with right now in terms of R52 support (it is not even
> upstream yet). So it is totally fine to change Zephyr and move forward
> for now.
> 
> But medium term it doesn't seem to me that we can get away without a
> solution in Xen for this (or a change in the ARM ARM).

See above. This is an architecture problem and we should discuss with 
Arm first before continuing to add more decoding in Xen.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 10:55:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 10:55:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423375.670073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojeoe-0007IG-PJ; Sat, 15 Oct 2022 10:54:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423375.670073; Sat, 15 Oct 2022 10:54:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojeoe-0007I9-Mk; Sat, 15 Oct 2022 10:54:52 +0000
Received: by outflank-mailman (input) for mailman id 423375;
 Sat, 15 Oct 2022 10:54:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojeod-0007Hz-VM; Sat, 15 Oct 2022 10:54:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojeod-0007hy-UI; Sat, 15 Oct 2022 10:54:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojeod-0001MI-N1; Sat, 15 Oct 2022 10:54:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojeod-0003Lx-MX; Sat, 15 Oct 2022 10:54:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Z3LPoSiYkUMfVsxUKX49GBlg92w2tF7RvkW4q0aY7Co=; b=npLdaE7WiqrV45AC6CJNIf2lCm
	1/xyQuWTtxhHEnrlMehnAkA043zQS3rWj+744z77YqCEUt7FUxygGClzrrTCUMcgw7T8CY8Dzd8O4
	FYwmRoqWbLpg5wkyYCh/3p9hEDAf+AMNUVIPeME2Z7JduMSi4k7dUOMPCtIsC+lMcYgo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173810-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173810: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 10:54:51 +0000

flight 173810 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173810/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    7 days
Failing since        173492  2022-10-11 13:01:50 Z    3 days   23 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 10:58:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 10:58:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423384.670084 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojesW-00082z-DO; Sat, 15 Oct 2022 10:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423384.670084; Sat, 15 Oct 2022 10:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojesW-00082s-AT; Sat, 15 Oct 2022 10:58:52 +0000
Received: by outflank-mailman (input) for mailman id 423384;
 Sat, 15 Oct 2022 10:58:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ojesV-00082m-8z
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 10:58:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojesV-0007mR-0M; Sat, 15 Oct 2022 10:58:51 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ojesU-0002P4-Qv; Sat, 15 Oct 2022 10:58:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=Bo71Qu2V1PLwI6LPnJOP9xQaEnMSMOyVj95DghF2hAo=; b=eoVHQc427+Ijov0jxvFj6FPLli
	K20URcp/lwtr+lJqFS0d/QHbihI5f4oLZtfTdzkKIGTFMwviMsOXOZzz1bCecPxUmX/Asuk2UXkZ2
	cq+tGdffVi411J6kCUpkEOjlVXYDWU9QkcaNoLGmuEakLuXZ6azGOnUKXJpAh+eOB+k0=;
Message-ID: <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org>
Date: Sat, 15 Oct 2022 11:58:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
 <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
In-Reply-To: <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 14/10/2022 12:19, Henry Wang wrote:
> Hi Julien,

Hi Henry,

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>>>        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>>>        unsigned long count = 0;
>>> @@ -1716,7 +1716,7 @@ int p2m_teardown(struct domain *d)
>>>            p2m_free_page(p2m->domain, pg);
>>>            count++;
>>>            /* Arbitrarily preempt every 512 iterations */
>>> -        if ( !(count % 512) && hypercall_preempt_check() )
>>> +        if ( allow_preemption && !(count % 512) &&
>> hypercall_preempt_check() )
>>>            {
>>>                rc = -ERESTART;
>>>                break;
>>> @@ -1736,6 +1736,17 @@ void p2m_final_teardown(struct domain *d)
>>>        if ( !p2m->domain )
>>>            return;
>>>
>>> +    if ( !page_list_empty(&p2m->pages) )
>>
>> Did you add this check to avoid the clean & invalidate if the list is empty?
> 
> Yep. I think we only need the p2m_teardown() if we actually have something
> in p2m->pages list.

How about adding the check in p2m_teardown()? So it will be easier to 
remember that the check can be dropped if we move the zeroing outside of 
the function.

> 
>>
>>> +        p2m_teardown(d, false);
>>
>> Today, it should be fine to ignore p2m_teardown(). But I would prefer if
>> we add an ASSERT()/BUG_ON() (or else) to make confirm this is the case.
> 
> Sorry I do not really understand why we can ignore the p2m_teardown()
> probably because of my English.

No, I forgot a word in my sentence. I was meant to say that the return 
of p2m_teardown() can be ignored in our situation because it only return 
0 or -ERESTART. The latter cannnot happen when the preemption is not 
enabled.

But I would like to add some code (either ASSERT() or BUG_ON()) to 
confirm that p2m_teardown() will always return 0.

> Let's talk a bit more in C if you don't mind :))
> Do you mean p2m_teardown() should be called here unconditionally without
> the if ( !page_list_empty(&p2m->pages) ) check?

See above.

> 
>>
>> This also wants to be documented on top of p2m_teardown() as it would be
>> easier to know that the function should always return 0 when
>> !allow_preemption is not set.
> 
> Ok, will do.
> 
>>
>> I also noticed that relinquish_p2m_mapping() is not called. This should
>> be fine for us because arch_domain_create() should never create a
>> mapping that requires p2m_put_l3_page() to be called.
>>
>> I think it would be good to check it in __p2m_set_entry(). So we don't
>> end up to add such mappings by mistake.
> 
> I thought for a while but failed to translate the above requirements
> to proper if conditions in __p2m_set_entry()...

For checking the mapping, we can do:

if ( !removing_mapping && (p2m_is_foreign(t) || (p2m_is_ram(t) && 
is_xenheap_mfn(mfn) )
     return -EINVAL;

We also need a way to check whether we are called from 
arch_domain_create(). I think we would need a field in the domain 
structure to indicate whether it is still initializating.

This is a bit ugly though. Any other suggestions?

> 
>>
>> I would have suggested to add a comment only for version and send a
>> follow-up patch. But I don't exactly know where to put it.
> 
> ...how about p2m_final_teardown(), we can use a TODO to explain why
> we don't need to call relinquish_p2m_mapping() and a following patch
> can fix this?

To me the TODO would make more sense on top of p2m_set_entry() because 
this is where the issue should be fixed. This is also where most of the 
reader will likely look if they want to understand how p2m_set_entry() 
can be used.

We could also have a comment in p2m_final_teardown() stating that the 
relinquish function is not called because the P2M should not contain any 
mapping that requires specific operation when removed. This could point 
to the comment in p2m_set_entry().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 13:15:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 13:15:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423464.670120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojh0H-00064l-H7; Sat, 15 Oct 2022 13:15:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423464.670120; Sat, 15 Oct 2022 13:15:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojh0H-00064e-E5; Sat, 15 Oct 2022 13:15:01 +0000
Received: by outflank-mailman (input) for mailman id 423464;
 Sat, 15 Oct 2022 13:14:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DPIc=2Q=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ojh0F-00064Y-Gh
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 13:14:59 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2086.outbound.protection.outlook.com [40.107.22.86])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d2b37bb-4c8b-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 15:14:57 +0200 (CEST)
Received: from AS8PR05CA0023.eurprd05.prod.outlook.com (2603:10a6:20b:311::28)
 by DB9PR08MB9442.eurprd08.prod.outlook.com (2603:10a6:10:458::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sat, 15 Oct
 2022 13:14:54 +0000
Received: from AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:311:cafe::d0) by AS8PR05CA0023.outlook.office365.com
 (2603:10a6:20b:311::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Sat, 15 Oct 2022 13:14:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT039.mail.protection.outlook.com (100.127.140.224) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Sat, 15 Oct 2022 13:14:53 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Sat, 15 Oct 2022 13:14:53 +0000
Received: from b69eba9a8df3.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3AEF203E-23CA-4D7A-820C-F50D99C3DD48.1; 
 Sat, 15 Oct 2022 13:14:47 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b69eba9a8df3.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 15 Oct 2022 13:14:47 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV2PR08MB9879.eurprd08.prod.outlook.com (2603:10a6:150:de::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sat, 15 Oct
 2022 13:14:44 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.029; Sat, 15 Oct 2022
 13:14:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d2b37bb-4c8b-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=BzyDuTdNRoSHLffTEzqb6KVzzHvngJwjj2JMBENGN79ENuVG+ejhHI8Oh0kQzbzQ8agZqh+eJMNrZtumpRZRMmmvAeuGS83AXfK822jF1RWSiC8CbOh5NwuZBOi8eBe66lShIeXymacjQhHlZo37cRm1ESn2Qymd6hyvI9QpsQtO20SA9s/Mr2Jhw8YiImM0HEDZWiNpk7KdvVMvqgf10/ftxgoEgn8IxhkqB3LTycuwwCvFxjFblACf6AJymRfCSVWx0wA8To4SgBqRWQOXpW0CYxsEGBVSYoxDYZnzN/Kuyd3E24WrcDBFoS9akERW7vWaK3MijU3mGRxU3+Gm+w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l7XP1jibOmnC8B6gmAGNYfyQ+uFUyvyw7XPGM2uHVS8=;
 b=Qap7oucwy//SlzzjdVKFUU1V6OdlUZpqeMy7HSsd1b2tDBGOujSkk7J8obSs2o/rc/T0k0mIrsoakk0uxLTigyyHCuhm+wiqstXm8PMGrujm5Ue5HASGt/kkHgGgHz7+4y0cvkUXl2pskdcr5ADCLrGHKX1xDnX4ooQkkhkyRh7rEw72J8czev7X1mJMShu4n+kbPJfaM++fTMt8JoLnKSDs/Y6KthQUHeM8CLTC+3p5l/jYABdS8x+Ytdx85oTdbkm5/PpvJlDJMUwgcDG1ur9JqHhWwg8IUKuMUbmrKUaH5eEcIllmzQzUKqsBzid8zgeM7OtnEa1lDnXLwSM5qw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=l7XP1jibOmnC8B6gmAGNYfyQ+uFUyvyw7XPGM2uHVS8=;
 b=R8iLK1P3nse9kr7a1FSJp5wGA7C323XRB39VrADWyR2qFgZ0ozW7DeulZVdDkyNmanZ7LmszRIvroPD4tarl7R5tiw770bZbdqgVRJ84eBEsFfcxJEfj9eZFyO7btQwndSpsGyIE0afn/ijgQ68JCR/NrV5ZmGFYgetpgseKj0g=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bt6suVxt8G5cbDOE3qXshTkDuk6mZCfM+uokwC9WA57K0Z0cCiUmWRLJsCRvV/4n8hlTRiTCXaTRAewTfHYrSBzrkErd7Tyj19vukQOHTlNt7uIuoMpdPqwawYKEsPuq82JlQ8jOHSGHQd8DbrQpnXdL7m3IWG4QBwVbNJGiUbtSb0/x4DC1keyZnbf1O2uvKpN8EMW6SiP2m6PbDfsRcNVxesZgUODbKcomY6R3/cl8CiB+CMyi48bsfI8NEcEtCbZF+7xr3oz+rqghYlTIDuxa2SmkCiyQooPT1P4BihGJOGtgzZdulU5i2qmuunaeBPOwNq8SA0oGw4GESo7Hrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l7XP1jibOmnC8B6gmAGNYfyQ+uFUyvyw7XPGM2uHVS8=;
 b=gSsD52Xm1ZJ8FBVtybV7pebVfJoIHsiw68U7Hmc4Qo34XVzS25Zr0y1Qn7ELueb7PuprMHmXINQT6cadRqYvWQz3VJN3TXCm2GQjnVDpCFrKbNmqWgeBQ1A3MnsMlb0I9jgD6wgidAjTDNYRJn/Fg+JJOS0dV9T5ODtxiTtA+9ijtn9SPlYpA6CSs/KQPVg/5mqT1ksRC9AYvc/j1HSTnWBP8atnOM8JyrAprBZph7wGxOL+U+MVqeigGUkFVYcDJMicVJ/vaTPblx+l2H4LqkRoBRq2FuhBk1h/ZTW4VKYXJ9OlAHFgIUGaoYrhJra1fcpRpnGmvHezfDoIR8lFeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=l7XP1jibOmnC8B6gmAGNYfyQ+uFUyvyw7XPGM2uHVS8=;
 b=R8iLK1P3nse9kr7a1FSJp5wGA7C323XRB39VrADWyR2qFgZ0ozW7DeulZVdDkyNmanZ7LmszRIvroPD4tarl7R5tiw770bZbdqgVRJ84eBEsFfcxJEfj9eZFyO7btQwndSpsGyIE0afn/ijgQ68JCR/NrV5ZmGFYgetpgseKj0g=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NsO2AgAACdYCAAZeJAIAAAyvQ
Date: Sat, 15 Oct 2022 13:14:44 +0000
Message-ID:
 <AS8PR08MB7991976335ACE7B47A3FCB9792279@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
 <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org>
In-Reply-To: <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 47B477FFB382264FAA6A03814C453EDB.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV2PR08MB9879:EE_|AM7EUR03FT039:EE_|DB9PR08MB9442:EE_
X-MS-Office365-Filtering-Correlation-Id: 6018f37b-c20b-4da4-9e5e-08daaeaf3f8c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 a+piy5ieQNSX7+/lzhBWGCzMD1NQ3Q1NCrxnmtAgG0JvGGCyRW+VZ4quppKw6tuLThJEzVvFe4dbIIKa+0MnFdGHtOiWLMd1CE1Cn5X9Txs4wV5V9K1NqV8itUnW1EQyfR6+XKCkinLvPzfUV/MLM0BebToyYb/1YY2Zs+muP+B7A+AphEtKaGXDMe4UvLxo1zs9Cd3KtemGvzbm1oKTLprYiwXJ5T8pv6nrogCZBIRvVxsL7WDOput354znxQmCj7f87mHIfKDuthEhBdwrgwzI26G5q8GpboHjqVD+rxtGuH6ZiRmvoqXuKsnJinUHCt90jE18lPWSOsOCrm2xZI9j4pRu0TqWSXZ4azGONDuHPoGjM+1RaPcz2ONI/vFyAt0rsQMzCSmv6Ov85U2lCg5d/EW0MwrBqbJUEaZ7Fb2ByHrXwCiZE6v7AVVBHmDFqF16khsWXGPMvj9HooduuO/y8jdRLWB28LcZO/6iwQhjLCp3EAwT031wxJM1c/nEuZKw4rUnNGussHH9VFT3F5yYoDkafaVgLb/v9QN1CpwnQFvU4YhdxLVWL92KIjNBNo4edx58xcIfwsXJbJHUZFPuaNKV5WsUiVBQACrWSrHW7fr/JbG1YQq4Km+0E7JN/MNrU6k3VADAkBfnWXYDef9jIfoFD3MeqycO4OKFxe6GJgzjCOsTAT9Jm7K5mYQinaUhTPvSxVIzDMlZQ+zUM5eQkn3cAZp4PCxXsC0S9bLYwLIvWNbZ947vjkhLxuR0Pc5sL3K9XgQlyl+f6zqE9A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(451199015)(38070700005)(71200400001)(316002)(478600001)(110136005)(54906003)(38100700002)(66946007)(186003)(4326008)(55016003)(8676002)(122000001)(66476007)(66446008)(76116006)(64756008)(66556008)(5660300002)(53546011)(7696005)(9686003)(6506007)(41300700001)(26005)(8936002)(33656002)(2906002)(86362001)(52536014)(83380400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9879
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b3db4ea0-ef80-4080-3cd7-08daaeaf3a15
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	n8LBe2y1H+FDt5766sFW4EasCK8l8h6Xj6oTFqR52oX2KFoXOrIHqJ/ho/gZfDJfA3PZsdsHkPsXk9HxU+S/Fh96LuiLNE2bGzWIM0v+B8L42IxR8on0vD6SgBMjuqqaoKpnSjg91QR0ObYink8oasIm4agULDJ87fNOpxOvUvhdBeNG/QnDrpBHTg9bTUJP7EFei0arzLgf5ztYToRxwkkUvdAm8FPPrOzqXnEpiqd4NgKdfg8uRM2t/x9POqXkNgBZUjYBWE9b+Mq/Y+F62ZyseMK3AV0BEDhQ8C233P5clwlEeTfMH3b2N9WiMcIkXdhCtz6N3HhnnlbQ9w9NKVxppUDZg1Cys6t0xdRKuNQFGwx2SE9YnX3mDxlPhZSIispdKhpEXEwZzGgKN5PaoKLAa4SoB9NAq7g0+/xnKrWT71og7uoFOyQvplZen6Zg2ju7SVBg7wmfbOaRkl1lx3mmtIZ175rXhkgpUCoqUSc3yIRdhEWP9seyFLxAL5dCev1NEVbMbhSLRKoRXpZ9Cw36QnMShOjAo/3fB2nkpT8DoC0jbvJzXfQjdlMrrnNkjeF5BRmEBedeSzAx7UHUOTybO9Vd5oHbUTxJFtiHuzE9YaDVxxp9QLaipXjFf/Hopk7zNlgj/D2Ffe8joZgcJUxpq+ZAt08/RuFWqh/BMhNOHlnTxOG9cD86weKDSy0HYUN4s/p6ZsfDuTRoFQaVx2wjwvaEtThows1Ipe4pwIdxtdzIOR+njprRbUCmcx9qI/Xd8QGX5Bzl/dZO/V1jgQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(9686003)(40460700003)(52536014)(26005)(33656002)(316002)(5660300002)(8676002)(4326008)(8936002)(70586007)(70206006)(81166007)(110136005)(6506007)(7696005)(356005)(86362001)(41300700001)(186003)(82310400005)(53546011)(2906002)(55016003)(40480700001)(82740400003)(336012)(54906003)(478600001)(83380400001)(107886003)(36860700001)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2022 13:14:53.4255
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6018f37b-c20b-4da4-9e5e-08daaeaf3f8c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9442

SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHJlcGx5IGFuZCBzaGFyaW5nIHlvdXIgb3BpbmlvbnMh
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2Ml0geGVuL2FybTogcDJtOiBQ
b3B1bGF0ZSBwYWdlcyBmb3IgR0lDdjIgbWFwcGluZyBpbg0KPiBhcmNoX2RvbWFpbl9jcmVhdGUo
KQ0KPiBPbiAxNC8xMC8yMDIyIDEyOjE5LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IEhpIEp1bGll
biwNCj4gDQo+IEhpIEhlbnJ5LA0KPiANCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N
Cj4gPj4gRnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gPj4+ICAgICAgICBz
dHJ1Y3QgcDJtX2RvbWFpbiAqcDJtID0gcDJtX2dldF9ob3N0cDJtKGQpOw0KPiA+Pj4gICAgICAg
IHVuc2lnbmVkIGxvbmcgY291bnQgPSAwOw0KPiA+Pj4gQEAgLTE3MTYsNyArMTcxNiw3IEBAIGlu
dCBwMm1fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkNCj4gPj4+ICAgICAgICAgICAgcDJtX2Zy
ZWVfcGFnZShwMm0tPmRvbWFpbiwgcGcpOw0KPiA+Pj4gICAgICAgICAgICBjb3VudCsrOw0KPiA+
Pj4gICAgICAgICAgICAvKiBBcmJpdHJhcmlseSBwcmVlbXB0IGV2ZXJ5IDUxMiBpdGVyYXRpb25z
ICovDQo+ID4+PiAtICAgICAgICBpZiAoICEoY291bnQgJSA1MTIpICYmIGh5cGVyY2FsbF9wcmVl
bXB0X2NoZWNrKCkgKQ0KPiA+Pj4gKyAgICAgICAgaWYgKCBhbGxvd19wcmVlbXB0aW9uICYmICEo
Y291bnQgJSA1MTIpICYmDQo+ID4+IGh5cGVyY2FsbF9wcmVlbXB0X2NoZWNrKCkgKQ0KPiA+Pj4g
ICAgICAgICAgICB7DQo+ID4+PiAgICAgICAgICAgICAgICByYyA9IC1FUkVTVEFSVDsNCj4gPj4+
ICAgICAgICAgICAgICAgIGJyZWFrOw0KPiA+Pj4gQEAgLTE3MzYsNiArMTczNiwxNyBAQCB2b2lk
IHAybV9maW5hbF90ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKQ0KPiA+Pj4gICAgICAgIGlmICgg
IXAybS0+ZG9tYWluICkNCj4gPj4+ICAgICAgICAgICAgcmV0dXJuOw0KPiA+Pj4NCj4gPj4+ICsg
ICAgaWYgKCAhcGFnZV9saXN0X2VtcHR5KCZwMm0tPnBhZ2VzKSApDQo+ID4+DQo+ID4+IERpZCB5
b3UgYWRkIHRoaXMgY2hlY2sgdG8gYXZvaWQgdGhlIGNsZWFuICYgaW52YWxpZGF0ZSBpZiB0aGUg
bGlzdCBpcyBlbXB0eT8NCj4gPg0KPiA+IFllcC4gSSB0aGluayB3ZSBvbmx5IG5lZWQgdGhlIHAy
bV90ZWFyZG93bigpIGlmIHdlIGFjdHVhbGx5IGhhdmUNCj4gc29tZXRoaW5nDQo+ID4gaW4gcDJt
LT5wYWdlcyBsaXN0Lg0KPiANCj4gSG93IGFib3V0IGFkZGluZyB0aGUgY2hlY2sgaW4gcDJtX3Rl
YXJkb3duKCk/IFNvIGl0IHdpbGwgYmUgZWFzaWVyIHRvDQo+IHJlbWVtYmVyIHRoYXQgdGhlIGNo
ZWNrIGNhbiBiZSBkcm9wcGVkIGlmIHdlIG1vdmUgdGhlIHplcm9pbmcgb3V0c2lkZSBvZg0KPiB0
aGUgZnVuY3Rpb24uDQoNClllcywgSSB3aWxsIHR1cm4gYWJvdmUgaWYgY2hlY2sgdG8gYQ0KDQpp
ZiAoIHBhZ2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykgKQ0KICAgIHJldHVybiAwOw0KDQppbiB0
aGUgYmVnaW5uaW5nIG9mIHRoZSBwMm1fdGVhcmRvd24oKSwgYW5kIGRvIHRoZSBjbGVhbiAmIGlu
dmFsaWRhdGUNCmZvbGxvdy11cCBhZnRlciB0aGUgcmVsZWFzZS4NCg0KPiANCj4gPg0KPiA+Pg0K
PiA+Pj4gKyAgICAgICAgcDJtX3RlYXJkb3duKGQsIGZhbHNlKTsNCj4gPj4NCj4gPj4gVG9kYXks
IGl0IHNob3VsZCBiZSBmaW5lIHRvIGlnbm9yZSBwMm1fdGVhcmRvd24oKS4gQnV0IEkgd291bGQg
cHJlZmVyIGlmDQo+ID4+IHdlIGFkZCBhbiBBU1NFUlQoKS9CVUdfT04oKSAob3IgZWxzZSkgdG8g
bWFrZSBjb25maXJtIHRoaXMgaXMgdGhlIGNhc2UuDQo+ID4NCj4gPiBTb3JyeSBJIGRvIG5vdCBy
ZWFsbHkgdW5kZXJzdGFuZCB3aHkgd2UgY2FuIGlnbm9yZSB0aGUgcDJtX3RlYXJkb3duKCkNCj4g
PiBwcm9iYWJseSBiZWNhdXNlIG9mIG15IEVuZ2xpc2guDQo+IA0KPiBObywgSSBmb3Jnb3QgYSB3
b3JkIGluIG15IHNlbnRlbmNlLiBJIHdhcyBtZWFudCB0byBzYXkgdGhhdCB0aGUgcmV0dXJuDQo+
IG9mIHAybV90ZWFyZG93bigpIGNhbiBiZSBpZ25vcmVkIGluIG91ciBzaXR1YXRpb24gYmVjYXVz
ZSBpdCBvbmx5IHJldHVybg0KPiAwIG9yIC1FUkVTVEFSVC4gVGhlIGxhdHRlciBjYW5ubm90IGhh
cHBlbiB3aGVuIHRoZSBwcmVlbXB0aW9uIGlzIG5vdA0KPiBlbmFibGVkLg0KPiANCj4gQnV0IEkg
d291bGQgbGlrZSB0byBhZGQgc29tZSBjb2RlIChlaXRoZXIgQVNTRVJUKCkgb3IgQlVHX09OKCkp
IHRvDQo+IGNvbmZpcm0gdGhhdCBwMm1fdGVhcmRvd24oKSB3aWxsIGFsd2F5cyByZXR1cm4gMC4N
Cg0KSSBhZGRlZCB0aGUgZG9jIGFza2VkIGluIHlvdXIgcHJldmlvdXMgZW1haWwuIEFsc28sIEkg
d2lsbCB1c2UgYQ0KDQpBU1NFUlQocDJtX3RlYXJkb3duKGQsIGZhbHNlKSA9PSAwKTsNCg0KaW4g
cDJtX2ZpbmFsX3RlYXJkb3duKCkgaGVyZS4NCg0KPiANCj4gPiBMZXQncyB0YWxrIGEgYml0IG1v
cmUgaW4gQyBpZiB5b3UgZG9uJ3QgbWluZCA6KSkNCj4gPiBEbyB5b3UgbWVhbiBwMm1fdGVhcmRv
d24oKSBzaG91bGQgYmUgY2FsbGVkIGhlcmUgdW5jb25kaXRpb25hbGx5DQo+IHdpdGhvdXQNCj4g
PiB0aGUgaWYgKCAhcGFnZV9saXN0X2VtcHR5KCZwMm0tPnBhZ2VzKSApIGNoZWNrPw0KPiANCj4g
U2VlIGFib3ZlLg0KDQpUaGFua3MuDQoNCj4gDQo+ID4NCj4gPj4NCj4gPj4gVGhpcyBhbHNvIHdh
bnRzIHRvIGJlIGRvY3VtZW50ZWQgb24gdG9wIG9mIHAybV90ZWFyZG93bigpIGFzIGl0IHdvdWxk
DQo+IGJlDQo+ID4+IGVhc2llciB0byBrbm93IHRoYXQgdGhlIGZ1bmN0aW9uIHNob3VsZCBhbHdh
eXMgcmV0dXJuIDAgd2hlbg0KPiA+PiAhYWxsb3dfcHJlZW1wdGlvbiBpcyBub3Qgc2V0Lg0KPiA+
DQo+ID4gT2ssIHdpbGwgZG8uDQo+ID4NCj4gPj4NCj4gPj4gSSBhbHNvIG5vdGljZWQgdGhhdCBy
ZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgaXMgbm90IGNhbGxlZC4gVGhpcyBzaG91bGQNCj4gPj4g
YmUgZmluZSBmb3IgdXMgYmVjYXVzZSBhcmNoX2RvbWFpbl9jcmVhdGUoKSBzaG91bGQgbmV2ZXIg
Y3JlYXRlIGENCj4gPj4gbWFwcGluZyB0aGF0IHJlcXVpcmVzIHAybV9wdXRfbDNfcGFnZSgpIHRv
IGJlIGNhbGxlZC4NCj4gPj4NCj4gPj4gSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIHRvIGNoZWNr
IGl0IGluIF9fcDJtX3NldF9lbnRyeSgpLiBTbyB3ZSBkb24ndA0KPiA+PiBlbmQgdXAgdG8gYWRk
IHN1Y2ggbWFwcGluZ3MgYnkgbWlzdGFrZS4NCj4gPg0KPiA+IEkgdGhvdWdodCBmb3IgYSB3aGls
ZSBidXQgZmFpbGVkIHRvIHRyYW5zbGF0ZSB0aGUgYWJvdmUgcmVxdWlyZW1lbnRzDQo+ID4gdG8g
cHJvcGVyIGlmIGNvbmRpdGlvbnMgaW4gX19wMm1fc2V0X2VudHJ5KCkuLi4NCj4gDQo+IEZvciBj
aGVja2luZyB0aGUgbWFwcGluZywgd2UgY2FuIGRvOg0KPiANCj4gaWYgKCAhcmVtb3ZpbmdfbWFw
cGluZyAmJiAocDJtX2lzX2ZvcmVpZ24odCkgfHwgKHAybV9pc19yYW0odCkgJiYNCj4gaXNfeGVu
aGVhcF9tZm4obWZuKSApDQo+ICAgICAgcmV0dXJuIC1FSU5WQUw7DQoNClRoYW5rcyBmb3IgdGhp
cywgSSBndWVzcyB3aXRob3V0IHlvdXIgaGludCBpdCB3aWxsIHRha2UgYWdlcyBmb3IgbWUgdG8N
CnRoaW5rIG9mIHRoaXMuLi4uIA0KDQo+IA0KPiBXZSBhbHNvIG5lZWQgYSB3YXkgdG8gY2hlY2sg
d2hldGhlciB3ZSBhcmUgY2FsbGVkIGZyb20NCj4gYXJjaF9kb21haW5fY3JlYXRlKCkuIEkgdGhp
bmsgd2Ugd291bGQgbmVlZCBhIGZpZWxkIGluIHRoZSBkb21haW4NCj4gc3RydWN0dXJlIHRvIGlu
ZGljYXRlIHdoZXRoZXIgaXQgaXMgc3RpbGwgaW5pdGlhbGl6YXRpbmcuDQo+IA0KPiBUaGlzIGlz
IGEgYml0IHVnbHkgdGhvdWdoLiBBbnkgb3RoZXIgc3VnZ2VzdGlvbnM/DQoNCk15IGZpcnN0IHRo
b3VnaHQgaXMgY2hlY2tpbmcgdGhlIGltcGxlbWVudGF0aW9uIG9mIGRvbWFpbl9jcmVhdGUoKQ0K
YW5kIGFyY2hfZG9tYWluX2NyZWF0ZSgpIChhcyBib3RoIHdpbGwgY2FsbCBhcmNoX2RvbWFpbl9k
ZXN0cm95KCkNCndoZW4gZmFpbCkgdG8gc2VlIGlmIHRoZXJlIGFyZSBzb21lIGZpZWxkcyBpbiBz
dHJ1Y3QgZG9tYWluIG9yDQpzdHJ1Y3QgYXJjaF9kb21haW4gdGhhdCBhcmUgc2V0L2NoYW5nZWQg
aW4gdGhpcyBzdGFnZSBzbyBwcm9iYWJseSB3ZQ0KY2FuIHJldXNlLiBPdGhlcndpc2UgSSB0aGlu
ayBhZGRpbmcgYSBuZXcgZmllbGQgc291bmRzIGEgZ29vZCBpZGVhLg0KDQo+IA0KPiA+DQo+ID4+
DQo+ID4+IEkgd291bGQgaGF2ZSBzdWdnZXN0ZWQgdG8gYWRkIGEgY29tbWVudCBvbmx5IGZvciB2
ZXJzaW9uIGFuZCBzZW5kIGENCj4gPj4gZm9sbG93LXVwIHBhdGNoLiBCdXQgSSBkb24ndCBleGFj
dGx5IGtub3cgd2hlcmUgdG8gcHV0IGl0Lg0KPiA+DQo+ID4gLi4uaG93IGFib3V0IHAybV9maW5h
bF90ZWFyZG93bigpLCB3ZSBjYW4gdXNlIGEgVE9ETyB0byBleHBsYWluIHdoeQ0KPiA+IHdlIGRv
bid0IG5lZWQgdG8gY2FsbCByZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgYW5kIGEgZm9sbG93aW5n
IHBhdGNoDQo+ID4gY2FuIGZpeCB0aGlzPw0KPiANCj4gVG8gbWUgdGhlIFRPRE8gd291bGQgbWFr
ZSBtb3JlIHNlbnNlIG9uIHRvcCBvZiBwMm1fc2V0X2VudHJ5KCkNCj4gYmVjYXVzZQ0KPiB0aGlz
IGlzIHdoZXJlIHRoZSBpc3N1ZSBzaG91bGQgYmUgZml4ZWQuIFRoaXMgaXMgYWxzbyB3aGVyZSBt
b3N0IG9mIHRoZQ0KPiByZWFkZXIgd2lsbCBsaWtlbHkgbG9vayBpZiB0aGV5IHdhbnQgdG8gdW5k
ZXJzdGFuZCBob3cgcDJtX3NldF9lbnRyeSgpDQo+IGNhbiBiZSB1c2VkLg0KDQpHb29kIGlkZWEs
IHRoYW5rcyBmb3IgdGhlIHN1Z2dlc3Rpb24hDQoNCj4gDQo+IFdlIGNvdWxkIGFsc28gaGF2ZSBh
IGNvbW1lbnQgaW4gcDJtX2ZpbmFsX3RlYXJkb3duKCkgc3RhdGluZyB0aGF0IHRoZQ0KPiByZWxp
bnF1aXNoIGZ1bmN0aW9uIGlzIG5vdCBjYWxsZWQgYmVjYXVzZSB0aGUgUDJNIHNob3VsZCBub3Qg
Y29udGFpbiBhbnkNCj4gbWFwcGluZyB0aGF0IHJlcXVpcmVzIHNwZWNpZmljIG9wZXJhdGlvbiB3
aGVuIHJlbW92ZWQuIFRoaXMgY291bGQgcG9pbnQNCj4gdG8gdGhlIGNvbW1lbnQgaW4gcDJtX3Nl
dF9lbnRyeSgpLg0KDQpZZXMsIG15IGN1cnJlbnQgd29yZGluZyBmb3IgdGhpcyB3b3VsZCBiZToN
CisgICAgLyoNCisgICAgICogTm8gbmVlZCB0byBjYWxsIHJlbGlucXVpc2hfcDJtX21hcHBpbmco
KSBoZXJlIGJlY2F1c2UNCisgICAgICogcDJtX2ZpbmFsX3RlYXJkb3duKCkgaXMgY2FsbGVkIGVp
dGhlciBhZnRlciBkb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoKQ0KKyAgICAgKiB3aGVyZSBy
ZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgaGFzIGJlZW4gY2FsbGVkLCBvciBmcm9tIGZhaWx1cmUg
cGF0aCBvZg0KKyAgICAgKiBkb21haW5fY3JlYXRlKCkvYXJjaF9kb21haW5fY3JlYXRlKCkgd2hl
cmUgbWFwcGluZ3MgdGhhdCByZXF1aXJlDQorICAgICAqIHAybV9wdXRfbDNfcGFnZSgpIHNob3Vs
ZCBuZXZlciBiZSBjcmVhdGVkLg0KKyAgICAgKi8NCg0KSSB3aWxsIGFkZCB0aGUgd29yZHMgcG9p
bnRpbmcgdG8gcDJtX3NldF9lbnRyeSgpLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQoNCj4g
DQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 14:04:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 14:04:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423472.670137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojhle-0002yv-9S; Sat, 15 Oct 2022 14:03:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423472.670137; Sat, 15 Oct 2022 14:03:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojhle-0002yo-6n; Sat, 15 Oct 2022 14:03:58 +0000
Received: by outflank-mailman (input) for mailman id 423472;
 Sat, 15 Oct 2022 14:03:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=asFJ=2Q=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ojhld-0002yi-0c
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 14:03:57 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 343a2f52-4c92-11ed-8fd0-01056ac49cbb;
 Sat, 15 Oct 2022 16:03:55 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EA5292188F;
 Sat, 15 Oct 2022 14:03:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B2864139F3;
 Sat, 15 Oct 2022 14:03:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GamPKcm9SmNVQQAAMHmgww
 (envelope-from <jgross@suse.com>); Sat, 15 Oct 2022 14:03:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 343a2f52-4c92-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665842633; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TGyPksAXnV2jtAP6FfUhm/2POnqJYgklllRaGArfe4E=;
	b=ULXwswezUCphZWW/db50WY59mumyqvtMy97G9fl5pZknNv6JjGrnjby1R2Y1wEam2LW4YP
	87YydfBNCrRH5XpJHb2kKc6tVhXLX+wyYyDokEPTj3fBwrLtGOX6FcxMUutPQlSvYeeTXn
	Aeb3k8pAt24YTf0LX/ZMiAjXNgVkFjg=
Message-ID: <f6918108-01db-6232-dfed-48b288dc2854@suse.com>
Date: Sat, 15 Oct 2022 16:03:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH V2 0/2] Other misc fixes for Xen grant DMA-mapping layer
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
References: <20221008151013.2537826-1-olekstysh@gmail.com>
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221008151013.2537826-1-olekstysh@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------OeieXWXVTqu81zQgSRYSEdaA"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------OeieXWXVTqu81zQgSRYSEdaA
Content-Type: multipart/mixed; boundary="------------Lesnbvd9TdY7cIVfEpMuttXX";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Xenia Ragiadakou <burzalodowa@gmail.com>
Message-ID: <f6918108-01db-6232-dfed-48b288dc2854@suse.com>
Subject: Re: [PATCH V2 0/2] Other misc fixes for Xen grant DMA-mapping layer
References: <20221008151013.2537826-1-olekstysh@gmail.com>
In-Reply-To: <20221008151013.2537826-1-olekstysh@gmail.com>

--------------Lesnbvd9TdY7cIVfEpMuttXX
Content-Type: multipart/mixed; boundary="------------5qRwEWviQKbHG4KAYZSOidAj"

--------------5qRwEWviQKbHG4KAYZSOidAj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMDguMTAuMjIgMTc6MTAsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t
OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+IA0KPiBIZWxsbyBhbGwuDQo+IA0KPiBUaGVzZSBhcmUgb3RoZXIgc2V2ZXJhbCBmaXhl
cywgd2hpY2ggd2VyZSBpZGVudGlmaWVkIGFuZCBzZW50IHNlcGFyYXRlbHksDQo+IGJ1dCBu
b3cgdGhleSBhcmUgcHV0IHRvZ2V0aGVyIGluIGNvbXBsZXRlbmVzcyBoZXJlLg0KPiANCj4g
Q3VycmVudCBzZXJpZXMgZGVwZW5kcyBvbiB0aGUgc2VyaWVzIHdoaWNoIGhhcyBiZWVuIGFs
cmVhZHkgcHVzaGVkDQo+IHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy02LjE6DQo+IGh0dHBz
Oi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIyMTAwNTE3NDgyMy4xODAwNzYxLTEt
b2xla3N0eXNoQGdtYWlsLmNvbS8NCj4gDQo+IE9sZWtzYW5kciBUeXNoY2hlbmtvICgyKToN
Cj4gICAgeGVuL3ZpcnRpbzogSGFuZGxlIGNhc2VzIHdoZW4gcGFnZSBvZmZzZXQgPiBQQUdF
X1NJWkUgcHJvcGVybHkNCj4gICAgeGVuL3ZpcnRpbzogQ29udmVydCBQQUdFX1NJWkUvUEFH
RV9TSElGVC9QRk5fVVAgdG8gWGVuIGNvdW50ZXJwYXJ0cw0KPiANCj4gICBkcml2ZXJzL3hl
bi9ncmFudC1kbWEtb3BzLmMgfCAyNyArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0NCj4g
ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pDQo+
IA0KDQpTZXJpZXMgcHVzaGVkIHRvIHhlbi90aXAuZ2l0IGZvci1saW51cy02LjENCg0KDQpK
dWVyZ2VuDQo=
--------------5qRwEWviQKbHG4KAYZSOidAj
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------5qRwEWviQKbHG4KAYZSOidAj--

--------------Lesnbvd9TdY7cIVfEpMuttXX--

--------------OeieXWXVTqu81zQgSRYSEdaA
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNKvckFAwAAAAAACgkQsN6d1ii/Ey+r
2gf/beNL0ZfFOxyxjGRyA7nxjMwrATwOY6kF9Bd6uSsJEwr9kiug1NCAecdGGKGdk+5HuoBC/JP2
LIdzo2hqFYa4IFhWKrgtUrMvjMoxb80yXtGcVLPKtHuFz9rhqHIuQY3h+/gnVjkpcUCSi9sRrKAQ
Yas0DgCLR4drl8rCsPovC2jKtjPUolHLsz4NTmEGPu4mGblrR70DKMIMgonxLtquZ1T5H82ESgbj
18RUpN3Qm8B9Mq2r0/nBJ8UyoEXzNsTCxZUNlZHUu+qohuvpZHR9uWO8lKT+PYDT5+BEvsu+Sl1B
lvSimVD3jyJoN6CSnp5vM4rvpowSaVzQt/6selapOg==
=/AU/
-----END PGP SIGNATURE-----

--------------OeieXWXVTqu81zQgSRYSEdaA--


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 15:13:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 15:13:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423487.670172 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojiqT-0001sG-Qf; Sat, 15 Oct 2022 15:13:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423487.670172; Sat, 15 Oct 2022 15:13:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojiqT-0001s9-LU; Sat, 15 Oct 2022 15:13:01 +0000
Received: by outflank-mailman (input) for mailman id 423487;
 Sat, 15 Oct 2022 15:13:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojiqS-0001rz-FX; Sat, 15 Oct 2022 15:13:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojiqS-0003i2-Ek; Sat, 15 Oct 2022 15:13:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojiqS-0001se-7z; Sat, 15 Oct 2022 15:13:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojiqS-0001yM-7T; Sat, 15 Oct 2022 15:13:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oESgGmH2y8I6912a104jInh353tyMMBWAiZXVl0WQww=; b=eGI1laVEzhGw6lfvIeOf4+cSYx
	8Ij4zilUgLs+WehdFcevy0alUkrl9k3ImpQ+X/L8urFpyyTjUZik9Ce+NqVOHqFU/MUpIQHtstxKG
	Cno/Mwd+/yhUwEONP9bxMr56nYkKMzeAOfpMOw8GZIH+n9YEYhfD3Np3JqgQ5OTQvLrw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173822-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173822: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 15:13:00 +0000

flight 173822 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173822/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173810

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173810 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173810 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   24 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 15:34:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 15:34:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423497.670189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojjBR-0004Sf-Hp; Sat, 15 Oct 2022 15:34:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423497.670189; Sat, 15 Oct 2022 15:34:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojjBR-0004SY-ER; Sat, 15 Oct 2022 15:34:41 +0000
Received: by outflank-mailman (input) for mailman id 423497;
 Sat, 15 Oct 2022 15:34:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SHf/=2Q=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ojjBR-0004SS-1B
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 15:34:41 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e1fa5463-4c9e-11ed-91b4-6bf2151ebd3b;
 Sat, 15 Oct 2022 17:34:39 +0200 (CEST)
Received: by mail-lj1-x234.google.com with SMTP id h8so9230949lja.11
 for <xen-devel@lists.xenproject.org>; Sat, 15 Oct 2022 08:34:39 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 i11-20020a0565123e0b00b00497a3e2a191sm773548lfv.112.2022.10.15.08.34.37
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 15 Oct 2022 08:34:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1fa5463-4c9e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=ihOcqD/n8ZbX79lkXyTkddNqF22IgCuKxZEVGwB7Rsg=;
        b=WxtdSw3RVuokIk3VH0NlorLEv9hGbzMu1BXjJPFPg6tTUBAUACrJhaEons33ymTpay
         fsFTwfQbxQXLaSloPF8amM8JbNWOvBoQDVDLQP4T3JaPpsQauZT0geTwDcC7UyPymBz8
         jnssWruJPe8g8dSeLpOrsbUEq2F3+WhotoQAeYxn0ytN33tQlg/cXg0w2K8+0o7dJ1lQ
         Fw9775uiwSMOsdy4oI1MLmDmKbuLHlD4bukfDsQASTZnmUa4nWgMHliZqbE9lx5bNeLn
         A/CtiP/rcDTETgtCh/oXjOsYxKX/0caViUXXDHU/1f9YJjOsTyTeiIU09NDlUTGoeKfL
         QZpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=ihOcqD/n8ZbX79lkXyTkddNqF22IgCuKxZEVGwB7Rsg=;
        b=1fneCdfk1S1eZpt16s9sg1dDijkEvtej51rhz31HMLNH0NDWr/RDjax5u52vaCQvMF
         ciMk2VXgpnACs1eoRTC4HDRKPbH/w/egE94IBfz4B1U3RWXlqZlIxDEgg0lp5AQ+bjPT
         Q33XbBLVl0cts65J4AkT0pklgTmLyXw2peM5SMblIFAvoFGfXhBojGrKJ6/h311wKy9o
         v6ddGBgFlRTKmx8PQLg/XsKBUkeLgcIyCz5WVi7vyNu6JhPX9rRwiSr9/YR1jb9FDga3
         Q3uHodDkCieP58SCaf54AAsvLd7kz/3Tad6ii7raGttYZsoMEpQ1F61n/B8U2Fh6F17W
         lrdw==
X-Gm-Message-State: ACrzQf3hU3zDYXvMHfkYdhfDX28HzzsqYdKN895XSVkSNI0aj59ly1LB
	aIFOrF6HPhL3VnI970cWh6WOgtRkC3BjHQ==
X-Google-Smtp-Source: AMsMyM4cTx61Y6kV/OX5Wcl7kFX+mFhoVOm1PT3Oovb9gJ2D7Wkm7T2AtGUh6I1wmhv3Ee7UT1Dz3w==
X-Received: by 2002:a05:651c:158f:b0:26b:dd9c:dca5 with SMTP id h15-20020a05651c158f00b0026bdd9cdca5mr1153297ljq.400.1665848078845;
        Sat, 15 Oct 2022 08:34:38 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH V2] xen/virtio: Handle PCI devices which Host controller is described in DT
Date: Sat, 15 Oct 2022 18:34:09 +0300
Message-Id: <20221015153409.918775-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Use the same "xen-grant-dma" device concept for the PCI devices
behind device-tree based PCI Host controller, but with one modification.
Unlike for platform devices, we cannot use generic IOMMU bindings
(iommus property), as we need to support more flexible configuration.
The problem is that PCI devices under the single PCI Host controller
may have the backends running in different Xen domains and thus have
different endpoints ID (backend domains ID).

So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
properties) which allows us to describe relationship between PCI
devices and backend domains ID properly.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
Here, for PCI devices we use more flexible way to pass backend domid to the guest
than for platform devices.

Changes V1 -> V2:
   - update commit description
   - rebase
   - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings

Previous discussion is at:
https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/

Based on:
https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
---
 drivers/xen/grant-dma-ops.c | 87 ++++++++++++++++++++++++++++++++-----
 1 file changed, 76 insertions(+), 11 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index daa525df7bdc..b79d9d6ce154 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/dma-map-ops.h>
 #include <linux/of.h>
+#include <linux/pci.h>
 #include <linux/pfn.h>
 #include <linux/xarray.h>
 #include <linux/virtio_anchor.h>
@@ -292,12 +293,55 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
+static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
+{
+	struct pci_dev *pdev = to_pci_dev(dev);
+	struct pci_bus *bus = pdev->bus;
+
+	/* Walk up to the root bus to look for PCI Host controller */
+	while (!pci_is_root_bus(bus))
+		bus = bus->parent;
+
+	return of_node_get(bus->bridge->parent->of_node);
+}
+
+static struct device_node *xen_dt_get_node(struct device *dev)
+{
+	if (dev_is_pci(dev))
+		return xen_dt_get_pci_host_node(dev);
+
+	return of_node_get(dev->of_node);
+}
+
+static int xen_dt_map_id(struct device *dev, struct device_node **iommu_np,
+			 u32 *sid)
+{
+	struct pci_dev *pdev = to_pci_dev(dev);
+	u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
+	struct device_node *host_np;
+	int ret;
+
+	host_np = xen_dt_get_pci_host_node(dev);
+	if (!host_np)
+		return -ENODEV;
+
+	ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask", iommu_np, sid);
+	of_node_put(host_np);
+
+	return ret;
+}
+
 static bool xen_is_dt_grant_dma_device(struct device *dev)
 {
-	struct device_node *iommu_np;
+	struct device_node *iommu_np = NULL;
 	bool has_iommu;
 
-	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
+	if (dev_is_pci(dev)) {
+		if (xen_dt_map_id(dev, &iommu_np, NULL))
+			return false;
+	} else
+		iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
+
 	has_iommu = iommu_np &&
 		    of_device_is_compatible(iommu_np, "xen,grant-dma");
 	of_node_put(iommu_np);
@@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
 
 bool xen_is_grant_dma_device(struct device *dev)
 {
+	struct device_node *np;
+
 	/* XXX Handle only DT devices for now */
-	if (dev->of_node)
-		return xen_is_dt_grant_dma_device(dev);
+	np = xen_dt_get_node(dev);
+	if (np) {
+		bool ret;
+
+		ret = xen_is_dt_grant_dma_device(dev);
+		of_node_put(np);
+		return ret;
+	}
 
 	return false;
 }
@@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
 static int xen_dt_grant_init_backend_domid(struct device *dev,
 					   struct xen_grant_dma_data *data)
 {
-	struct of_phandle_args iommu_spec;
+	struct of_phandle_args iommu_spec = { .args_count = 1 };
 
-	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
-			0, &iommu_spec)) {
-		dev_err(dev, "Cannot parse iommus property\n");
-		return -ESRCH;
+	if (dev_is_pci(dev)) {
+		if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
+			dev_err(dev, "Cannot translate ID\n");
+			return -ESRCH;
+		}
+	} else {
+		if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
+				0, &iommu_spec)) {
+			dev_err(dev, "Cannot parse iommus property\n");
+			return -ESRCH;
+		}
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
@@ -354,6 +413,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
 void xen_grant_setup_dma_ops(struct device *dev)
 {
 	struct xen_grant_dma_data *data;
+	struct device_node *np;
 
 	data = find_xen_grant_dma_data(dev);
 	if (data) {
@@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	if (!data)
 		goto err;
 
-	if (dev->of_node) {
-		if (xen_dt_grant_init_backend_domid(dev, data))
+	np = xen_dt_get_node(dev);
+	if (np) {
+		int ret;
+
+		ret = xen_dt_grant_init_backend_domid(dev, data);
+		of_node_put(np);
+		if (ret)
 			goto err;
 	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
 		dev_info(dev, "Using dom0 as backend\n");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 15:47:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 15:47:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423503.670200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojjNw-00062j-My; Sat, 15 Oct 2022 15:47:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423503.670200; Sat, 15 Oct 2022 15:47:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojjNw-00062c-Ip; Sat, 15 Oct 2022 15:47:36 +0000
Received: by outflank-mailman (input) for mailman id 423503;
 Sat, 15 Oct 2022 15:47:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=caCr=2Q=epam.com=prvs=2287b79f1b=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ojjNv-00062W-2J
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 15:47:35 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id adf37e3e-4ca0-11ed-8fd0-01056ac49cbb;
 Sat, 15 Oct 2022 17:47:32 +0200 (CEST)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29F3pSvt002897;
 Sat, 15 Oct 2022 15:47:21 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k7mvn10s3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 15 Oct 2022 15:47:20 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM9PR03MB6755.eurprd03.prod.outlook.com (2603:10a6:20b:2de::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Sat, 15 Oct
 2022 15:47:17 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.029; Sat, 15 Oct 2022
 15:47:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adf37e3e-4ca0-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hRgdl1AsuhpOBx5tEj48z6ac3AgXDpHfE32aecnDqqFcND3nvd5j8QiTqhxhYz4V4ovDSHwVTwys+aALbP2IlrZIM9jvE+dzub8qCPEPDA/ioKLTYNH/Y6tTU2Ss0l2yK+ba8jzyBSLL1A9bKbsAjLjuOY+WBmPGkZBT8cZgU1fbi/TMJAYwMNFQly9h1NoizIZjJC7IBTuYx2MdKT+FFPSzIERiHrUl8FCS+ak2Uv7EK2mJcfh1NBb+/2rs6Ah18r5vFvEDPUfJi9c4cPj17xvB+mUl78aRCBAMPnlR0uHVPq5iM99D0LmBCWT36+qTBjuINCnATEhHcjPzZEgIDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m/IiSCY8nMZpbHYji191Mgg8/7QXWRdgVHdRmWENPns=;
 b=eIG2WqrwjH9Nzst4cyh127VVw+FVhCNnyNTETWOX5tQ+8ieti0VuaDRAYCitMBtFhklfMkBGN1VETxx8XlZSk+Wex6Q8PNXX4wmoXtn4SmLJXncF2QFo0W8SXn5k3x/jRFCkoRUNZ0SbrMryrPRxESmM9+NgO9U0xQ9Jf50CAV09ztFtEIDlVj3XH6yWqba7KSHk0HKiRHmN3ZSTYGKgSDCwS/Sct/kbx4LYYtVJsIuWoi5HzP8BxboXvuc1hhSsEMhp6+pVWX0wKZ67//TkKOWTt2ROs32ZiTJ6K9B3jON8S1vRfVQvGO+5tiLl1Xa3pI1PtwiMEb89jyJslsaQXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m/IiSCY8nMZpbHYji191Mgg8/7QXWRdgVHdRmWENPns=;
 b=QQl3RtQHKjOuDSNB5OLPK9qcNrhFQrmmhFIWIV0lszzkxoRQtvoCtOEwE5icMlRt7Pd5m4hC8ZH6kJEHqZ02Qljaz7tfKteFM5wOogkvzJAaZZ4L08fSB0Jld1w4VRgiaECz05KnmevNghU+axJssRTS4wBFmH/nlrTyohU63lEOcHe6pxqwuftcUo2QLWcSt6BGLMkIWHM7JAcoBbLrj8Ddn3XhXvrpBju+e2PDCavZceZX+Bt7cwnfWeo/yG9Ivx/J9BN3MOqO2INmxxLqWAGDbAgDng/7bP5v/pPye4a44DSK6UxnKj+6ZhM1EmoqeRxKMxhkHJhqDgSyqIQfUw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Topic: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Index: AQHY2avbTqg8YKTBpUCScd7xSfM5Yq4CIOiAgAkdnYCAAET3gIAEI/OA
Date: Sat, 15 Oct 2022 15:47:16 +0000
Message-ID: <16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com>
References: <20221006174804.2003029-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop>
 <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com>
 <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AM9PR03MB6755:EE_
x-ms-office365-filtering-correlation-id: 40d02e63-0fb6-40a4-63b7-08daaec48980
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FPgMLQUEW5zdVvAjxfSd6oXRCgFMzYgc05CDJbcclc06u9nkfrxaf/C8v9t9NO81/ctQPDsnGhz/8wXdNJehsWASS4IK3xTkR5JjW9+julSxrR9xDQj/pT9zDPdvXeV8pXN7Ib34IXnl91RaDZmsM9ODLJ9bIW4yUeuJ4qDOu3Vtao+QfdSxsNqr4mbCdO2yFTdoKfxLja7cemihmJktNgGjPl9HH82NsVOKNLhpHFefkbHSS1FsO5Cz34BoywjXIWn9C8uFVifMU0iQnskaDzmR9c9pui8+WVChs16vaVzbgkabVK38VTECwtD0CL57X3xi6nUS34qwhdws1vMHHozq9k8OUxlaolKXbuuOYuoRY2KjsB2YncA6Zy8Km5YLCXQUccPoEjy9ZuXqJ6ZVjklASiNxAah18D9U2xSw6RGZELeTE4QDefqMWO5QCAGtiYUHl7JXJp5TgucDKcCVbosgzM4DAzXJcSuvzZPiMdYQdP6m9LXH20JMG3aX8BB/5b5dOQV6xsM8LLl9DtVne1MGWNy8SRDTcvDhr88Bfg4f9UdQ8pTYHmEPtijmg0trS/f9PDgxZfeSQuRhwyxsFy/aJAb++Nu8/zLkJ2a/psJ9diAL1KOH/C8OWhK4LDXyfPkrze2g+pUpI/bz1aB6woaTOgsiey1p0vsgW9pPqpLdQIEcUvMI2MWG5FELrzcW2YHlEBRCytQfUYZPDZqQjnXIiGAH400hV4AEBUF+x1p6eQ0r/qqllXuZOBll7+OymMN5Ar8afa1I6w8ZBjpVC0RBwNZ05f5FuVVIlDlQa0k2zuemPW/xM/sOQPbvTVOp
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199015)(66946007)(66899015)(478600001)(71200400001)(122000001)(966005)(38070700005)(6486002)(38100700002)(86362001)(83380400001)(66446008)(54906003)(31696002)(4326008)(76116006)(66476007)(6506007)(30864003)(36756003)(64756008)(6916009)(53546011)(55236004)(26005)(66556008)(316002)(8676002)(186003)(41300700001)(31686004)(91956017)(6512007)(2616005)(2906002)(5660300002)(8936002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?QU0zbDBGQlVMTnBSRWxKNjY4UThnNFZiRGZmbXg0Z1FYY3lHaW9obUJFUm5V?=
 =?utf-8?B?T2lrVTFHRHhRTS9xVWpMZFZtU3ZwbGVyWGEzbW03bzFLV25RVHZvV1FLN3pH?=
 =?utf-8?B?QXJaL1h3QnJ4eGJUWXE2TUtEc1lEWFRNb1N4bVNxWGpLT0k2SDBCK3BOL2Z6?=
 =?utf-8?B?WU5oSFFOK0NXMGY1VTZNVG5ZbTc5TkpybzcvTGo1NDA1S3cwaldQZjllQUpQ?=
 =?utf-8?B?N2U2cEExQUZIa0xRbmxSVDRZN2FvcHlCcTR3K003amJXY1dKNmc1Wm4yNCsz?=
 =?utf-8?B?WDg1cWVIRVE1YUlJSUFzSXRIYk1Pd3NDTk8rME1qd1BMaUV0VHMyeFNUVmh5?=
 =?utf-8?B?cDEzKzk2OERFeHJncDlBeVVGaGV2eWphS1NxTXRrZlpLZjRUMU9oSzJRbllm?=
 =?utf-8?B?aGtKWUd3ZUFJMWVhL1I4TlkzdnpsMGdjSWFNS1liMVVxYUdEZHY2UWt3TWh5?=
 =?utf-8?B?eFNBRDVZYXRoV09MWDRNSjMwckY0R1drRGJuc3AxZVhDbW1ZZnpZWFpmSjRK?=
 =?utf-8?B?YjQ0Q3laNC9WemoxOGdqV1F0RFdqdENvdWFKUDVKYmxxUlhWWDIxUGNOeDJl?=
 =?utf-8?B?T3FCQWNOMmNacGZyNFR2Nk1UN3haNFIxUkFXLzVGdm5pdmVSTFRHS1pISTFw?=
 =?utf-8?B?M3hKd1ZBdUhoVzRYSUVOSHY1YjROMG11eVlPSkMvOEIxcDJiSFRUc3J6M0Rv?=
 =?utf-8?B?ODEyTnBjc1FrUEtxYnZZT2ZTR1FEM3dYdDRHUEJJa0ZLNzVQbElkTE5veVBR?=
 =?utf-8?B?TXlkZ28vYytZdUh4SklCSDdxb0JLUklaYkF4MTlYV3FGUmZrRStnaExFVGRY?=
 =?utf-8?B?UFdTMTRMbE50L3o0VkxUbEJUQmxORmVXeDRRcjY2SjlpVFdid3M2bUlaTzcw?=
 =?utf-8?B?clJnN083TkNkNzFrWGd3anEvdWhxejZ6MTlhYVI5azI3bzNsOTFQMG03TXBu?=
 =?utf-8?B?eXFGZUg0N0tSNzk0RjUwZ25VajJOK3JjV2NFRm5Fa0FtUE8yWHBqajZqMHFo?=
 =?utf-8?B?L3FSeGpJSUFpTHgxbVh6dE1sMlFyTEpjYmxWUTJKZ0ZZY0ZrYW14VnJLQVp4?=
 =?utf-8?B?NXFOdzdnQU5uM2VuYnJDZ2hMeDQwZDcvZWw4STdlWEcwQ1pKREJiWGZtOE0r?=
 =?utf-8?B?U3FGeVJ1b1p0UFpMVk1Zb1Rnc3ByRzRNSytGRkhXbzBLR05MSXpCYWVqKysy?=
 =?utf-8?B?dUg0QmNYSWV6aExNUi90aHVOL0R4VjJpenJoNmgrTUhiL3J2cUNndkYxSWZM?=
 =?utf-8?B?UitvQlN5YWU0MENLTDJVWGRuNCtMZm0xUmhEYXA3UUQvMlFUckZUKzBSTlRT?=
 =?utf-8?B?RWtHdEF2VTNiMnkvM1UrL0NFQmU5SDFJOFBqbzMvM3R3RFprZ0ExVFBENlEw?=
 =?utf-8?B?UVFPMEFrMGdtODR1eWtac0k3N000cWxwMWpqSU8xSExNeWdaNG9FUkszakk3?=
 =?utf-8?B?TEpRTHBWd1NVNnI2S0xPblpvSm1NRmtKaGRTNUQ0Sm8rTjlhM3lpbUx3UUY0?=
 =?utf-8?B?YUt0Y1RCNG9qZUpPS2ZpbFJnUTUrM05hZU9pSlZJdlplVVcwZFRSL0JSL3Zs?=
 =?utf-8?B?VXprT3FxSWpCc1c1V2RzOTN5akJxMjZDOE9Wa056Ty9XRFJ0c1IyVmhSVXUw?=
 =?utf-8?B?SEhJcFhQQUplcnRpTFhEWkRiWjRGMFNINWVHaTZPcngxczJoTU9lUW1wNk4y?=
 =?utf-8?B?Z0JVOFBrNUZCYkx3NW9aN01yU0Z4YmtiaUFlT1FuZFlCdEpBOFZGNVVMb3Ey?=
 =?utf-8?B?aFlQODBaUy93YWV3ZW5UUGg3VW43dGdtWmFKcEtxTklRcDRtWUE3amxCSWlC?=
 =?utf-8?B?bVFuUDFWRHRzdEs4MmRLUzRKNG5zNEU5aEN5NWpBYVVLMUpzMVFWUyt1MnB0?=
 =?utf-8?B?NG4rSkFrTStQTXNkczlYbUZvTGlGZWYyNnBjMVJUZEhsWVZBazV1Qmp4cWhL?=
 =?utf-8?B?RGZhL0JzVFlnRXl3akxSVUs4RWxPZ05NNWtDRkFSbmk0U3RvbFIzTVZqcjhj?=
 =?utf-8?B?aHlmeStOSE9rdlpoNlU5TFBkYVhIYjU2NjVXbmpjWFdBVmtCcm9Rb0dBUUtO?=
 =?utf-8?B?N0ZCTFpFRVRwaG1JV0gyNjZOK0k5UGNGOXFyU3pjUnd4YzlzYURMV0FsRVNt?=
 =?utf-8?B?YnZrQ2hyL2h6V08xSW43UTlFY09NK3JKdkpXZGxIeUROREN5UnV5cDZqV3Bq?=
 =?utf-8?Q?Eq4CtSUbQcO9EU8h7jOi30g=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <938C44169C049B4987801F0F46BBA412@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40d02e63-0fb6-40a4-63b7-08daaec48980
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2022 15:47:16.9906
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IVszAMB7xtQPMqUw7HeoD7SUYGCKF8cybF3UoUgT6o650VAis57Q4tQi67xtemjjRBki1dAPW1fiWBCTw7TBx7DO2kOC+rEzFaK9O77te0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6755
X-Proofpoint-GUID: D6Kn1JwypycZJrk4_fgrpBnLpzyn0ntf
X-Proofpoint-ORIG-GUID: D6Kn1JwypycZJrk4_fgrpBnLpzyn0ntf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-15_10,2022-10-14_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 impostorscore=0
 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210150094

DQpPbiAxMy4xMC4yMiAwMzozMywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gT24gV2VkLCAxMiBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3Jv
dGU6DQo+Pj4gT24gVGh1LCA2IE9jdCAyMDIyLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4+Pj4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVw
YW0uY29tPg0KPj4+Pg0KPj4+PiBVc2UgdGhlIHNhbWUgInhlbi1ncmFudC1kbWEiIGRldmljZSBj
b25jZXB0IChiYXNlZCBvbiBnZW5lcmljIElPTU1VDQo+Pj4+IGRldmljZS10cmVlIGJpbmRpbmdz
KSBmb3IgdGhlIFBDSSBkZXZpY2VzIGJlaGluZCBkZXZpY2UtdHJlZSBiYXNlZA0KPj4+PiBQQ0kg
SG9zdCBjb250cm9sbGVyLg0KPj4+Pg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlz
aGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+IC0tLQ0KPj4+PiBT
bGlnaHRseSBSRkMuIFRoaXMgaXMgbmVlZGVkIHRvIHN1cHBvcnQgWGVuIGdyYW50IG1hcHBpbmdz
IGZvciB2aXJ0aW8tcGNpIGRldmljZXMNCj4+Pj4gb24gQXJtIGF0IHNvbWUgcG9pbnQgaW4gdGhl
IGZ1dHVyZS4gVGhlIFhlbiB0b29sc3RhY2sgc2lkZSBpcyBub3QgcHVibGlzaGVkIHlldC4NCj4+
Pj4gSGVyZSwgZm9yIFBDSSBkZXZpY2VzIHdlIHVzZSB0aGUgc2FtZSB3YXkgdG8gcGFzcyBiYWNr
ZW5kIGRvbWlkIHRvIHRoZSBndWVzdCBhcyBmb3INCj4+Pj4gcGxhdGZvcm0gZGV2aWNlcy4NCj4+
Pj4NCj4+Pj4gRGVwZW5kcyBvbiBKdWVyZ2VuJ3Mgc2VyaWVzOg0KPj4+PiBodHRwczovL3VybGRl
ZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIxMDA2
MDcxNTAwLjE1Njg5LTEtamdyb3NzQHN1c2UuY29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhd2FPazJH
b2M3cWxoTm81LWNzUk9icnlpbF9Hek1GX2U2MUVKUjUwMW9KMDhjSDJkbkp1bHNaWFdsZWxCRFRC
cWE2M1RWb1VjV1FUQjVOZWNKMXA0eEZOZ2gyX0V1QSQgIFtsb3JlWy5da2VybmVsWy5db3JnXQ0K
Pj4+PiAtLS0NCj4+Pj4gICAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgNTEgKysrKysr
KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQ0KPj4+PiAgICAxIGZpbGUgY2hhbmdlZCwg
NDEgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQg
YS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMNCj4+Pj4gaW5kZXggZmY5YmUzYWZmODdlLi43OWQxMzEyMmVjMDggMTAwNjQ0DQo+Pj4+IC0t
LSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+PiArKysgYi9kcml2ZXJzL3hlbi9n
cmFudC1kbWEtb3BzLmMNCj4+Pj4gQEAgLTEwLDYgKzEwLDcgQEANCj4+Pj4gICAgI2luY2x1ZGUg
PGxpbnV4L21vZHVsZS5oPg0KPj4+PiAgICAjaW5jbHVkZSA8bGludXgvZG1hLW1hcC1vcHMuaD4N
Cj4+Pj4gICAgI2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+Pj4+ICsjaW5jbHVkZSA8bGludXgvcGNp
Lmg+DQo+Pj4+ICAgICNpbmNsdWRlIDxsaW51eC9wZm4uaD4NCj4+Pj4gICAgI2luY2x1ZGUgPGxp
bnV4L3hhcnJheS5oPg0KPj4+PiAgICAjaW5jbHVkZSA8bGludXgvdmlydGlvX2FuY2hvci5oPg0K
Pj4+PiBAQCAtMjczLDEyICsyNzQsMjggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkbWFfbWFwX29w
cyB4ZW5fZ3JhbnRfZG1hX29wcyA9IHsNCj4+Pj4gICAgCS5kbWFfc3VwcG9ydGVkID0geGVuX2dy
YW50X2RtYV9zdXBwb3J0ZWQsDQo+Pj4+ICAgIH07DQo+Pj4+ICAgIA0KPj4+PiAtc3RhdGljIGJv
b2wgeGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4+PiAr
c3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZpY2Ug
KmRldikNCj4+Pj4gK3sNCj4+Pj4gKwlpZiAoZGV2X2lzX3BjaShkZXYpKSB7DQo+Pj4+ICsJCXN0
cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPj4+PiArCQlzdHJ1Y3QgcGNp
X2J1cyAqYnVzID0gcGRldi0+YnVzOw0KPj4+PiArDQo+Pj4+ICsJCS8qIFdhbGsgdXAgdG8gdGhl
IHJvb3QgYnVzIHRvIGxvb2sgZm9yIFBDSSBIb3N0IGNvbnRyb2xsZXIgKi8NCj4+Pj4gKwkJd2hp
bGUgKCFwY2lfaXNfcm9vdF9idXMoYnVzKSkNCj4+Pj4gKwkJCWJ1cyA9IGJ1cy0+cGFyZW50Ow0K
Pj4+PiArDQo+Pj4+ICsJCXJldHVybiBvZl9ub2RlX2dldChidXMtPmJyaWRnZS0+cGFyZW50LT5v
Zl9ub2RlKTsNCj4+Pj4gKwl9DQo+Pj4gSXMgaXQgcG9zc2libGUgdG8gaGF2ZSBtdWx0aXBsZSB2
aXJ0aW8gZGV2aWNlcyB1bmRlciBhIHNpbmdsZSB2aXJ0aW8tcGNpDQo+Pj4gcm9vdCBjb21wbGV4
Pw0KPj4geWVzDQo+Pg0KPj4NCj4+PiBXaGF0IGlmIHZpcnRpby1uZXQgaGFzIHRoZSBiYWNrZW5k
IGluIGRvbTAgYW5kDQo+Pj4gdmlydGlvLWJsb2NrIGhhcyB0aGUgYmFja2VuZCBpbiBkb20xPw0K
Pj4+DQo+Pj4gT3IgZWFjaCB2aXJ0aW8gUENJIGRldmljZSBzaG93cyB1cCB1bmRlciBhIGRpZmZl
cmVudCBQQ0kgcm9vdCBjb21wbGV4Pw0KPj4NCj4+IEdvb2QgcXVlc3Rpb25zLiBUbyBiZSBob25l
c3QsIGl0IGlzIG5vdCAxMDAlIGNsZWFyIHRvIG1lIHlldCBob3cgaXQgaXMNCj4+IHN1cHBvc2Vk
IHRvIGJlLiBCdXQgbGV0J3MgZ3Vlc3MuLi4NCj4+DQo+PiBJIHRoaW5rIHRoYXQgaGF2aW5nIGEg
UENJIEhvc3QgYnJpZGdlIHBlciB2aXJ0aW8tcGNpIGRldmljZSBpcyBvdmVya2lsbC4NCj4+DQo+
PiBTbywgSSBzZWUgdHdvIG9wdGlvbnMgaGVyZToNCj4+IDEuIFdlIHByb3ZpZGUgUENJIEhvc3Qg
YnJpZGdlIHBlciBiYWNrZW5kcyBkb21haW4gdG8gdGhlIGd1ZXN0LCBzbyBlYWNoDQo+PiBQQ0kg
SG9zdCBicmlkZ2UgY292ZXJzIG9ubHkgdmlydGlvLXBjaSBkZXZpY2VzIHdob3NlIGJhY2tlbmRz
IGFyZQ0KPj4gcnVubmluZyB3aXRoaW4gKnRoZSBzYW1lKiBkb21haW4uDQo+PiBXaXRoIHRoYXQg
d2Ugd291bGQgYmUgYWJsZSB0byB1c2UgcHJvcGVydHkgYXQgUENJIEhvc3QgYnJpZGdlIGxldmVs
Lg0KPj4NCj4+IDIuIFdlIHByb3ZpZGUgb25seSBhIHNpbmdsZSBQQ0kgSG9zdCBicmlkZ2UgdG8g
dGhlIGd1ZXN0LCBzbyB0aGF0IHNpbmdsZQ0KPj4gUENJIEhvc3QgYnJpZGdlIGNvdmVycyBhbGwg
dmlydGlvLXBjaSBkZXZpY2VzIGFzc2lnbmVkIHRvIHRoaXMgZ3Vlc3QuDQo+PiBObyBtYXR0ZXIg
d2hlcmUgdGhlIGNvcnJlc3BvbmRpbmcgYmFja2VuZHMgYXJlIHJ1bm5pbmcgKHRoZQ0KPj4gdmly
dGlvLWRldmljZXMgdW5kZXIgdGhhdCBQQ0kgSG9zdCBicmlkZ2UgY2FuIGhhdmUgdGhlIGJhY2tl
bmRzIGluDQo+PiBkaWZmZXJlbnQgZG9tYWlucykuDQo+PiBXaXRoIHRoYXQgd2Ugd291bGRu4oCZ
dCBiZSBhYmxlIHRvIHVzZSBwcm9wZXJ0eSBhdCBQQ0kgSG9zdCBicmlkZ2UgbGV2ZWwuDQo+PiBB
bmQgd2UgbmVlZCBhIG1vcmUgZmxleGlibGUgb3B0aW9uKHMpIHRvIGJlIGFibGUgZGlzdGluZ3Vp
c2ggYmV0d2Vlbg0KPj4gdmlydGlvLXBjaSBkZXZpY2VzLg0KPj4NCj4+IFRha2luZyBpbnRvIGFj
Y291bnQgdGhhdCBmb3IgdmlydGlvLXBjaSBvbiBBcm0gd2UgbmVlZCB0byBlbXVsYXRlIGENCj4+
IHNwZWNpZmljIFBDSSBIb3N0IGJyaWRnZSBpbiBYZW4gdG8gaW50ZXJjZXB0IHRoZSBndWVzdCBQ
Q0kgY29uZmlnIHNwYWNlDQo+PiBhY2Nlc3Nlcw0KPj4gKGRldGVjdCB3aGF0IFBDSSBkZXZpY2Ug
aXMgdGFyZ2V0ZWQpIGFuZCBmb3J3YXJkIHRoZW0gdG8gdGhlIGFwcHJvcHJpYXRlDQo+PiBiYWNr
ZW5kIChJT1JFUSBTZXJ2ZXIpLA0KPj4gaXQgZmVlbHMgdG8gbWUgdGhhdCB3ZSBsaWtlbHkgbmVl
ZCB0byBnbyB3aXRoIHRoZSBzZWNvbmQgb3B0aW9uIGhlcmUNCj4+IChvbmUgUENJIGhvc3QgYnJp
ZGdlIHBlciBndWVzdCksIEkgbWF5IG1pc3Rha2UsDQo+PiBidXQgSSBkb27igJl0IHRoaW5rIHRo
YXQgd2Ugd2FudCB0byBlbXVsYXRlIHNldmVyYWwgUENJIEhvc3QgYnJpZGdlcyBmb3IgYQ0KPj4g
c2luZ2xlIGd1ZXN0IChtb3JlIGNvZGUsIG1vcmUgcmVzb3VyY2VzLCBldGMpLg0KPj4NCj4+DQo+
Pg0KPj4+IElmIHdlIGNhbiBoYXZlIG11bHRpcGxlIHZpcnRpbyBQQ0kgZGV2aWNlcyB1bmRlciBh
IHNpbmdsZSBQQ0kgcm9vdA0KPj4+IGNvbXBsZXgsIHRoZW4gSSB0aGluayBpdCB3b3VsZCBiZSBi
ZXR0ZXIgdG8gY2hlY2sgZm9yIGEgcGVyLWRldmljZQ0KPj4+IHByb3BlcnR5LCByYXRoZXIgdGhh
biBhIHNpbmdsZSBwcm9wZXJ0eSBhdCB0aGUgUENJIHJvb3QgY29tcGxleCBsZXZlbC4NCj4+IENv
bXBsZXRlbHkgYWdyZWUuDQo+Pg0KPj4NCj4+PiBUaGUgZmlyc3QgdGhpbmcgdGhhdCBjb21lcyB0
byBtaW5kIGlzIHRvIGRlc2NyaWJlIGVhY2ggUENJIGRldmljZSB1bmRlcg0KPj4+IHRoZSByb290
IGNvbXBsZXggaW4gZGV2aWNlIHRyZWUuIEFsdGhvdWdoIGl0IGlzIHVuY29tbW9uICh1c3VhbGx5
IG9ubHkNCj4+PiB0aGUgUENJIHJvb3QgY29tcGxleCBpcyBkZXNjcmliZWQgaW4gZGV2aWNlIHRy
ZWUpLCBpdCBpcyBwb3NzaWJsZSB0bw0KPj4+IGFsc28gZGVzY3JpYmUgaW4gZGV2aWNlIHRyZWUg
YWxsIHRoZSBpbmRpdmlkdWFsIFBDSSBkZXZpY2VzIHVuZGVyIHRoZQ0KPj4+IHJvb3QgY29tcGxl
eC4NCj4+Pg0KPj4+IEdpdmVuIHRoYXQgdGhlIGRvbVUgZGV2aWNlIHRyZWUgaXMgZ2VuZXJhdGVk
IGJ5IFhlbiBhbmQvb3IgdGhlIFhlbg0KPj4+IHRvb2xzdGFjaywgaXQgd291bGQgYmUgZWFzeSB0
byBhcnJhbmdlIGZvciBpdCB0byBoYXBwZW4uDQo+PiBUZWNobmljYWxseSB5ZXMuIElmIHdlIGRl
Y2lkZSB0byBwcm92aWRlIG9ubHkgYSBzaW5nbGUgUENJIEhvc3QgYnJpZGdlDQo+PiB0byB0aGUg
Z3Vlc3QsIHdlIHdpbGwgaGF2ZSBoYXZlIHRvIGRlYWwgd2l0aCB0aGUgdmlydGlvLXBjaSBkZXZp
Y2VzIHdpdGgNCj4+IHZhcmlvdXMgYmFja2VuZF9kb21pZCwNCj4+IHNvIHdlIGNhbiBjb25zaWRl
ciB1c2luZyBtb3JlIGZsZXhpYmxlIHByb3BlcnR5DQo+PiDigJxpb21tdS1tYXDigJ0v4oCdaW9t
bXUtbWFwLW1hc2vigJ0gc3BlY2lhbGx5IGludHJvZHVjZWQgZm9yIHN1Y2ggcHVycG9zZXM6DQo+
PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2Mv
RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9wY2ktaW9tbXUudHh0X187ISFH
Rl8yOWRiY1FJVUJQQSExN0RrX3M4Y181UUNRRG1MTTFGWXA2OTVMdVVNU1RyVVY2SFBmUkE5Qmdt
Vno5VFJSRFpCT3V6c2Rad19jNkcwb2dreTFQMTFncWw5Q0hBT3NodWtXbXY3eldTMGRRJCAgW2tl
cm5lbFsuXW9yZ10NCj4+IEkgdGhpbmssIHdpdGggdGhhdCB3ZSB3b3VsZCBiZSBhYmxlIHRvIGRl
c2NyaWJlLCBpLmUgdGhhdCB2aXJ0aW8tcGNpDQo+PiBkZXZpY2UgQSBjb25uZWN0cyB0byBzdHJl
YW1faWQgKGJhY2tlbmRfZG9taWQpIFggYW5kIHZpcnRpby1wY2kgZGV2aWNlIEINCj4+IHRvIHN0
cmVhbV9pZCBZLA0KPj4gYW5kIHZpcnRpby1wY2kgZGV2aWNlIEMgdG8gbm90aGluZyAoc28gaXMg
bm90IHJlcXVpcmVkIHRvIHVzZSBncmFudHMpLA0KPj4gdW5sZXNzIEkgbWlzc2VkIHNvbWV0aGlu
Zy4NCj4+DQo+PiBJIGhhdmUgbG9va2VkIGF0IGl0IGFuZCBJIGRvbuKAmXQgc2VlIGF0IHRoZSBt
b21lbnQgd2h5IHRoZSBpZGVhIHdvdWxkbuKAmXQNCj4+IHdvcmssIGJ1dCBJIGhhdmVu4oCZdCBl
eHBlcmltZW50ZWQgd2l0aCB0aGF0IHlldCBpbiBzdWNoIGNvbnRleHQuDQo+IEkgdGhpbmsgaXQg
d291bGQgd29yayB0b28NCg0KDQpJIGhhdmUgZXhwZXJpbWVudGVkIHdpdGggdGhhdCwgaXQgd29y
a3MuIEFuZCBJIGhhdmUgYWxyZWFkeSBjcmVhdGVkIGEgcGF0Y2guDQoNCmh0dHBzOi8vbG9yZS5r
ZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIyMTAxNTE1MzQwOS45MTg3NzUtMS1vbGVrc3R5c2hAZ21h
aWwuY29tLw0KDQoNCldoYXQgSSB3YXMgdGhpbmtpbmcgaXMgYWx0aG91Z2ggZ2VuZXJpYyBQQ0kt
SU9NTVUgYmluZGluZ3MgDQooInhlbi1ncmFudC1kbWEiKSB3b3VsZG4ndCBsaWtlbHkgYmUgc3Vp
dGFibGUgZm9yICpmdXR1cmUqIGhvdHBsdWcgc3VwcG9ydCwNCml0IHdvdWxkIGFsbG93IHVzIHRv
IGhhdmUgdGhlIHdvcmtpbmcgc29sdXRpb24gb24gQXJtICh3aXRoIGEgbWluaW1hbCANCmNoYW5n
ZXMsIG9ubHkgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGlzIHRvdWNoZWQpDQphdCBsZWFz
dCBmb3IgUENJIGRldmljZXMgd2hpY2ggYXJlIGtub3duIGF0IHRoZSBkb21haW4gY3JlYXRpb24g
dGltZS4gT2YgDQpjb3Vyc2UsIHRoaXMgbmVlZHMgdGhlIHByb3BlciBzdXBwb3J0IGluIHRoZSB0
b29sc3RhY2suDQoNCg0KPiAgIA0KPg0KPj4+IFRoYXQgd291bGQgc29sdmUgdGhlIGlzc3VlIGFz
IGZhciBhcyBJIGNhbiB0ZWxsLCBidXQgSSB3b3JyeSBpdCBtaWdodA0KPj4+IG5vdCBiZSBhIGdv
b2QgaWRlYSBiZWNhdXNlIGlmIHdlIHJlbHkgb24gdGhlIHBlci1kZXZpY2UgZGV2aWNlIHRyZWUg
bm9kZQ0KPj4+IHRvIGJlIHByZXNlbnQgdGhlbiBpdCBiZWNvbWVzIGhhcmRlciB0byBpbXBsZW1l
bnQgdmlydGlvIGhvdHBsdWcNCj4+PiAoVmlydGlvIGhvdHBsdWcgaXMgaW1wb3J0YW50IHRvIGFk
ZCBkb20wbGVzcyBzdXBwb3J0LikNCj4+Pg0KPj4+IExldCdzIHNheSB0aGF0IHdlIGNyZWF0ZSBh
IGRvbTBsZXNzIGRvbVUgd2l0aCBhbiBlbXVsYXRlZCBQQ0kgcm9vdA0KPj4+IGNvbXBsZXggd2l0
aG91dCBhbnkgZGV2aWNlcyB1bmRlciBpdCwgdGhlbiBhZnRlciBEb20wIGlzIGZ1bGx5IGJvb3Rl
ZCwNCj4+PiB3ZSBhZGQgYSB2aXJ0aW8tbmV0IGVtdWxhdGVkIGRldmljZS4gSG93IGRvIHdlIHRl
bGwgdGhlIGd1ZXN0IHdoYXQgaXMNCj4+PiB0aGUgYmFja2VuZCBkb21haW4gaWQ/DQo+Pj4NCj4+
PiBEZXZpY2UgdHJlZSBhbmQgb3RoZXIgZmlybXdhcmUgdGFibGVzIGFyZSBub3QgcmVsZXZhbnQg
YW55bW9yZS4NCj4+Pg0KPj4+IFdlIGNvdWxkIHJldXNlIGEgUENJIGNvbmZpZyBzcGFjZSByZWdp
c3RlciB0byBleHBvc2UgdGhlIGJhY2tlbmQgaWQuDQo+Pj4gSG93ZXZlciB0aGlzIHNvbHV0aW9u
IHJlcXVpcmVzIGEgYmFja2VuZCBjaGFuZ2UgKFFFTVUpIHRvIGV4cG9zZSB0aGUNCj4+PiBiYWNr
ZW5kIGlkIHZpYSBhbiBlbXVsYXRlZCByZWdpc3RlciBmb3IgZWFjaCBlbXVsYXRlZCBkZXZpY2Uu
DQo+Pj4NCj4+PiBUbyBhdm9pZCBoYXZpbmcgdG8gaW50cm9kdWNlIGEgc3BlY2lhbCBjb25maWcg
c3BhY2UgcmVnaXN0ZXIgaW4gYWxsDQo+Pj4gZW11bGF0ZWQgUENJIGRldmljZXMgKHZpcnRpby1u
ZXQsIHZpcnRpby1ibG9jaywgZXRjKSBJIHdvbmRlciBpZiB3ZQ0KPj4+IGNvdWxkIGFkZCBhIHNw
ZWNpYWwgUENJIGNvbmZpZyBzcGFjZSByZWdpc3RlciBhdCB0aGUgZW11bGF0ZWQgUENJIFJvb3QN
Cj4+PiBDb21wbGV4IGxldmVsLg0KPj4+DQo+Pj4gQmFzaWNhbGx5IHRoZSB3b3JrZmxvdyB3b3Vs
ZCBiZSBhcyBmb2xsb3c6DQo+Pj4NCj4+PiAtIExpbnV4IHJlY29nbml6ZXMgdGhlIFBDSSBSb290
IENvbXBsZXggYXMgYSBYZW4gUENJIFJvb3QgQ29tcGxleA0KPj4+IC0gTGludXggd3JpdGVzIHRv
IHNwZWNpYWwgUENJIGNvbmZpZyBzcGFjZSByZWdpc3RlciBvZiB0aGUgWGVuIFBDSSBSb290DQo+
Pj4gICAgIENvbXBsZXggdGhlIFBDSSBkZXZpY2UgaWQgKGJhc2ljYWxseSB0aGUgQkRGKQ0KPj4+
IC0gVGhlIFhlbiBQQ0kgUm9vdCBDb21wbGV4IGVtdWxhdGVkIGJ5IFhlbiBhbnN3ZXJzIGJ5IHdy
aXRpbmcgYmFjayB0bw0KPj4+ICAgICB0aGUgc2FtZSBsb2NhdGlvbiB0aGUgYmFja2VuZCBpZCAo
ZG9taWQgb2YgdGhlIGJhY2tlbmQpDQo+Pj4gLSBMaW51eCByZWFkcyBiYWNrIHRoZSBzYW1lIFBD
SSBjb25maWcgc3BhY2UgcmVnaXN0ZXIgb2YgdGhlIFhlbiBQQ0kNCj4+PiAgICAgUm9vdCBDb21w
bGV4IGFuZCBsZWFybiB0aGUgcmVsZXZhbnQgZG9taWQNCj4+Pg0KPj4+IFdoYXQgZG8geW91IHRo
aW5rPw0KPj4NCj4+IEkgdGhpbmsgdGhlIGlkZWEgc291bmRzIGluZGVlZCBpbnRlcmVzdGluZyBh
bmQgd291bGQgcHJvYmFibHkgd29yaywgYnV0DQo+PiB3b3VsZCByZXF1aXJlIGd1ZXN0IG1vZGlm
aWNhdGlvbnMgb3RoZXIgdGhhbiBqdXN0IGluIGRyaXZlcnMveGVuIChhbmQNCj4+IGxpa2VseSB0
aGUgc3BlY2lmaWNhdGlvbiBjaGFuZ2VzIGFzIHdlbGwpLg0KPj4gV2hpY2ggaWRlYWxseSBvZiBj
b3Vyc2Ugc2hvdWxkIGJlIGF2b2lkZWQuDQo+PiBBbHNvIEkgd2FzIHRoaW5raW5nIGl0IHdvdWxk
IGJlIG5pY2Ugbm90IHRvIGRpdmVyZ2UgbXVjaCBiZXR3ZWVuDQo+PiBjb21tdW5pY2F0aW5nIHRo
ZSBiYWNrZW5kX2RvbWlkIGZvciBwbGF0Zm9ybSBhbmQgUENJIGRldmljZXMgb24gQXJtIHdpdGgN
Cj4+IGRldmljZSB0cmVlLg0KPj4NCj4+IElmIHdlIG1hbmFnZWQgdG8gcmUtdXNlIGdlbmVyaWMg
SU9NTVUgZGV2aWNlLXRyZWUgYmluZGluZ3MgZm9yDQo+PiB2aXJ0aW8tbW1pbywgd2Ugd291bGQg
bGlrZWx5IGJlIGFibGUgdG8gcmUtdXNlIFBDSS1JT01NVSBkZXZpY2UtdHJlZQ0KPj4gYmluZGlu
Z3MgZm9yIHZpcnRpby1wY2ksDQo+PiBhdCBsZWFzdCBmb3IgYm9vdCBQQ0kgZGV2aWNlcyAod2hp
Y2ggYXJlIGtub3duIGF0IHRoZSBkb21haW4gY3JlYXRpb24gdGltZSkuDQo+PiBUaGUgbW9yZSwg
dGhlIGJpbmRpbmdzIGlzIGFscmVhZHkgcHJlc2VudDoNCj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5j
b20vdjMvX19odHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90
b3J2YWxkcy9saW51eC5naXQvdHJlZS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv
aW9tbXUveGVuLGdyYW50LWRtYS55YW1sX187ISFHRl8yOWRiY1FJVUJQQSExN0RrX3M4Y181UUNR
RG1MTTFGWXA2OTVMdVVNU1RyVVY2SFBmUkE5QmdtVno5VFJSRFpCT3V6c2Rad19jNkcwb2dreTFQ
MTFncWw5Q0hBT3NodWtXbXZwZkY4R21BJCAgW2dpdFsuXWtlcm5lbFsuXW9yZ10NCj4gSSB0aGlu
ayB1c2luZyBhIHNwZWNpYWwgY29uZmlnIHNwYWNlIHJlZ2lzdGVyIGluIHRoZSByb290IGNvbXBs
ZXggd291bGQNCj4gbm90IGJlIHRlcnJpYmxlIGluIHRlcm1zIG9mIGd1ZXN0IGNoYW5nZXMgYmVj
YXVzZSBpdCBpcyBlYXN5IHRvDQo+IGludHJvZHVjZSBhIG5ldyByb290IGNvbXBsZXggZHJpdmVy
IGluIExpbnV4IGFuZCBvdGhlciBPU2VzLiBUaGUgcm9vdA0KPiBjb21wbGV4IHdvdWxkIHN0aWxs
IGJlIEVDQU0gY29tcGF0aWJsZSBzbyB0aGUgcmVndWxhciBFQ0FNIGRyaXZlciB3b3VsZA0KPiBz
dGlsbCB3b3JrLiBBIG5ldyBkcml2ZXIgd291bGQgb25seSBiZSBuZWNlc3NhcnkgaWYgeW91IHdh
bnQgdG8gYmUgYWJsZQ0KPiB0byBhY2Nlc3MgdGhlIHNwZWNpYWwgY29uZmlnIHNwYWNlIHJlZ2lz
dGVyLg0KDQoNClRoaXMgbmVlZHMgYW4gYWRkaXRpb25hbCBpbnZlc3RpZ2F0aW9uLg0KDQoNCj4N
Cj4gVGhhdCBzYWlkLCBmb3Igc3VyZSB0aGUgZmV3ZXIgY2hhbmdlcyB0byB0aGUgZ3Vlc3QgdGhl
IGJldHRlciBhbmQgSSBsaWtlDQo+IHRoZSBleGlzdGluZyB4ZW4sZ3JhbnQtZG1hIGJpbmRpbmcu
DQo+DQo+DQo+PiBSZWdhcmRpbmcgdGhlIGhvdHBsdWcgZGV2aWNlcywgeWVzIGl0IGlzIGEgdmFs
aWQgdXNlLWNhc2Ugd2hpY2ggc2hvdWxkDQo+PiBiZSBhbHNvIHN1cHBvcnRlZCB3aXRoIHZpcnRp
by1wY2ksIEkgYXNzdW1lIHRoZSBYZW5zdG9yZSBjb3VsZCBiZQ0KPj4gcmUtdXNlZCBmb3IgdGhh
dCBwdXJwb3NlIGlmIGl0IHdvdWxkIGJlIGF2YWlsYWJsZS4NCj4+IFRoZSBYZW5zdG9yZSBpcyBh
dmFpbGFibGUgd2l0aCB0aGUgdXN1YWwgRG9tMCBhbmQgdG9vbHN0YWNrLCBpcyBpdA0KPj4gYXZh
aWxhYmxlIHdpdGggZG9tMGxlc3M/DQo+IFhlbnN0b3JlIGlzIGF2YWlsYWJsZSBmb3IgZG9tMGxl
c3MgaWYgd2UgaGF2ZSBhIGRvbTAgcnVubmluZyB3aXRoDQo+IHhlbnN0b3JlZCBhcyBvbmUgb2Yg
dGhlIGRvbTBsZXNzIGRvbWFpbnMuIFdlIGN1cnJlbnRseSByZWx5IG9uIGl0IGZvcg0KPiBYZW4g
UFYgZHJpdmVycyB3aXRoIGRvbTBsZXNzLiAgQWZ0ZXIgZG9tMCBpcyBmdWxseSBib290ZWQsIHdl
IHVzZSAieGwNCj4gbmV0d29yay1hdHRhY2giIHRvIGNyZWF0ZSBhIHZpZiBpbnRlcmZhY2UgZHlu
YW1pY2FsbHkgaW4gdGhlIGRvbVUuDQo+DQo+IFRoYXQgaXMgd2h5IEkgd2FzIHRoaW5raW5nIG9m
IHVzaW5nIHZpcnRpbyBob3RwbHVnIHRvIHNvbHZlIHRoZSBzYW1lDQo+IHByb2JsZW0gd2l0aCB2
aXJ0aW8sIEkgd2FzIGltYWdpbmluZyB0aGF0IGFmdGVyIGRvbTAgaXMgZnVsbHkgYm9vdGVkIHdl
DQo+IHdvdWxkIGRvICJ4bCB2aXJ0aW8tYXR0YWNoIiBhbmQgY3JlYXRlIGEgbmV3IHZpcnRpbyBp
bnRlcmZhY2UgaW4gdGhlDQo+IGRvbVUuIEJ1dCBJIGNhbm5vdCBzZWUgYW4gZWFzeSB3YXkgdG8g
bWFrZSB2aXJ0aW8gaG90cGx1ZyB3b3JrIHRvZ2V0aGVyDQo+IHdpdGggdGhlIHhlbixncmFudC1k
bWEgYmluZGluZ3MuIEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIGlmIHdlIGZpbmQgYQ0KPiB3
YXkgdG8gbWFrZSBpdCB3b3JrIHdpdGhvdXQgeGVuc3RvcmUgKGJlY2F1c2UgeGVuc3RvcmUgd291
bGQgYmUgYQ0KPiBzYWZldHktY2VydGlmaWNhdGlvbiBkZXBlbmRlbmN5KS4NCg0KSSBnb3QgeW91
ciBjb25jZXJuIHJlZ2FyZGluZyB0aGUgdXNhZ2Ugb2YgeGVuc3RvcmUgaW4gZ2VuZXJhbC4NCkFs
c28gSSBnb3QgdGhhdCBob3RwbHVnIGlzIHRoZSBvbmx5IHdheSB0byBnZXQgdmlydHVhbCBkZXZp
Y2VzIChlaXRoZXIgDQpQViBvciB2aXJ0aW8pIHdvcmtpbmcgZm9yIHRoZSBkb20wbGVzcyBzeXN0
ZW0sIGlzIG15IHVuZGVyc3RhbmRpbmcgY29ycmVjdD8NCg0KVGhlIHZpcnRpbyBob3RwbHVnIGNv
dWxkICpwcm9iYWJseSogd29yayB0b2dldGhlciB3aXRoIHRoZSANCiJ4ZW4sZ3JhbnQtZG1hIiBi
aW5kaW5ncyB3aXRoIHNvbWUgcHJlcmVxdWlzaXRlcyAoYmFja2VuZCBkb21pZCBzaG91bGQgDQpi
ZSBrbm93biBpbiBhZHZhbmNlKSwNCmJ1dCBJIGFtIG5vdCBxdWl0ZSBhcyBJIGFtIG5vdCB0b28g
ZmFtaWxpYXIgd2l0aCBkb20wbGVzcyBkZXRhaWxzLiBCdXQgDQphbnl3YXksIEkgd2lsbCB0cnkg
dG8gZGVzY3JpYmUgaXQuLi4NCg0KQXMgZmFyIGFzIEkga25vdyB0aGUgZG9tMGxlc3MgRG9tVXMg
YXJlIGNvbmZpZ3VyZWQgZnJvbSB0aGUgZGV2aWNlLXRyZWUuIA0KU28gdGhlIGNvbmZpZ3VyYXRp
b24gaXMga25vd24gYW5kIHByZXBhcmVkIGJlZm9yZWhhbmQuDQpJIG1heSBndWVzcyB0aGF0IHdl
IGtub3cgaW4gd2hhdCBEb21VMSB3ZSBhcmUgZ29pbmcgdG8gcnVuIHRoZSB2aXJ0aW8gDQpiYWNr
ZW5kcyBhbmQgd2hhdCBQQ0kgZGV2aWNlcyB3ZSBhcmUgZ29pbmcgdG8gYXNzaWduIHRvIERvbVUy
LiBTbyB3aGVuIA0KWGVuIGdlbmVyYXRpbmcgZGV2aWNlLXRyZWUNCmZvciBEb21VMiBpdCBjb3Vs
ZCBjcmVhdGUgcHJvcGVyIGlvbW11LW1hcCBmb3IgdGhlIFBDSSBIb3N0IGJyaWRnZSBub2RlLiAN
CkFsdGhvdWdoIGZvciB0aGlzIHRvIHdvcmsgd2Ugd291bGQgbmVlZCBhbiBhYmlsaXR5IHRvIGNv
bmZpZ3VyZSBkb21haW4gDQpJRCAoZC0+ZG9tYWluX2lkKSB2aWEgZGV2aWNlLXRyZWUNCmFuZCBs
aWtlbHkgcmVzZXJ2ZSBzb21lIHJhbmdlIG9mIGRvbWFpbiBJRHMgKHRvIG5vdCBjcm9zcyB3aXRo
IA0KbWF4X2luaXRfZG9taWQpLiBCdXQsIGl0IHdvdWxkbid0IGJlIDEwMCUgaG90cGx1ZyB0aGVu
Lg0KDQoNCj4NCj4gTWF5YmUgd2UgbmVlZCB0byB0aGluayBvdXRzaWRlIHRoZSBib3ggYW5kIGZp
bmQgYW5vdGhlciBzb2x1dGlvbiB0aGF0DQo+IGRvZXNuJ3QgcmVseSBvbiBob3RwbHVnLg0KPg0K
PiBGb3IgaW5zdGFuY2UsIGxldCdzIHNheSB0aGF0IHdlIGV4cG9zZSB0aGUgdmlydGlvIGRldmlj
ZXMgaW4gZGV2aWNlIHRyZWUNCj4gaW4gYSBkb20wbGVzcyBjb25maWd1cmF0aW9uIHRvbyBidXQg
d2l0aCBzdGF0dXMgPSAiZGlzYWJsZWQiLiBXaGVuIGRvbTANCj4gKG9yIGJhY2tlbmQgZG9tYWlu
KSBpcyB1cCBhbmQgcnVubmluZyBpdCBjYW4gc2lnbmFsIHRoYXQgaXQgaXMgcmVhZHkuDQo+IE1h
eWJlIGlmIHdlIGhhZCBhIHNwZWNpYWwgWGVuLXNwZWNpZmljIFBDSSBSb290IENvbXBsZXggZHJp
dmVyIGluIHRoZQ0KPiBndWVzdCwgaXQgY291bGQgd2FpdCBmb3IgdGhlIFhlbiBzaWduYWwgYW5k
IHRoZW4gY29udGludWUgUENJIHByb2JpbmcgYXQNCj4gdGhhdCBwb2ludCBob25vcmluZyB4ZW4s
Z3JhbnQtZG1hIGJpbmRpbmdzIGlmIHByZXNlbnQgaW4gZGV2aWNlIHRyZWUNCj4gZXZlbiBpZiB0
aGUgZGV2aWNlcyBoYWQgc3RhdHVzID0gImRpc2FibGVkIiBpbml0aWFsbHkuDQo+DQo+IEl0IGxv
b2tzIGxpa2UgdGhhdCB3b3VsZCByZXF1aXJlIG1hbnkgZ3Vlc3QgY2hhbmdlcyB1bmZvcnR1bmF0
ZWx5Lg0KDQoNCkl0IGxvb2tzIGxpa2UgeWVzLCBhbHNvIHlvdSBtZW50aW9uZWQgIml0IGNhbiBz
aWduYWwgdGhhdCBpdCBpcyByZWFkeSIsDQp0aGUgcXVlc3Rpb24gaXMgYnkgd2hhdCBtZWFucyAo
eGVuc3RvcmUgd291bGQgYmUgYSBnb2QgZml0IGhlcmUuLi4pPw0KDQpBbmQgSSBoYXZlbid0IHNl
ZW4gdGhhdCB2aXJ0aW8tcGNpIGRldmljZXMgYXJlIGRlc2NyaWJlZCBpbiBkZXZpY2UtdHJlZSAN
CnNvbWV3aGVyZSwgb25seSBnZW5lcmljIFBDSSBob3N0IGJyaWRnZSBub2RlDQppcyBkZXNjcmli
ZWQuIFRoZSB2aXJ0aW8tcGNpIGRldmljZXMgd2lsbCBiZSBkZXRlY3RlZCB0aGUgc2FtZSB3YXkg
YXMgDQp1c3VhbCBQQ0kgZGV2aWNlcyBkdXJpbmcgYm9vdC4gVW5sZXNzIEkgbWlzc2VkIHNvbWV0
aGluZy4NCg0KUmVnYXJkaW5nIHRoZSB2aXJ0aW8tbW1pbyAocGxhdGZvcm0pIGRldmljZXMsIHll
cywgd2UgY291bGQgZXhwb3NlIHRoZW0gDQp3aXRoIHN0YXR1cyAiZGlzYWJsZWQiLCBhbmQgdGhl
eSB3b24ndCBnZXQgcHJvYmVkIGJ5IGRlZmF1bHQuDQpUbyBiZSBob25lc3QsIEkgaGF2ZSBleHBl
cmltZW50ZWQgd2l0aCB0aGF0LCB3aGVuIEkgd2FzIHRoaW5raW5nIG9mIA0KcG9zc2libGUgaG90
cGx1ZyBmb3IgdmlydGlvLW1taW8gZGV2aWNlcyAoSSBrbm93LCB0aGlzIHNvdW5kcyB1bmNvbW1v
biANCmFuZCBzdHJhbmdlKS4NCkkgdXNlZCBMaW51eCBmZWF0dXJlIChDT05GSUdfT0ZfRFlOQU1J
Qywgb3ZlcmxheXMpIHRvIHVwZGF0ZSB0aGUgDQpkZXZpY2UtdHJlZSBvbiBydW5uaW5nIGd1ZXN0
LCBzbyB0aGUgdG9vbHN0YWNrIGluaXRpYWxseSBpbnNlcnRzIA0KdmlydGlvLW1taW8gZGV2aWNl
IG5vZGVzIGZvciBub24tYm9vdCBkZXZpY2VzDQp3aXRoIHN0YXR1cyAiZGlzYWJsZWQiLCBhbmQg
YXQgdGhlIHJ1bnRpbWUsIG9uY2Ugd2UgcmVjZWl2ZSBhbiBldmVudCBmb3IgDQpleGFtcGxlLCB3
ZSBjaGFuZ2UgdGhlIHN0YXR1cyB0byAib2siIGFuZCB0aGUgY29ycmVzcG9uZGluZyB2aXJ0aW8t
bW1pbyANCmRldmljZSBnZXRzIHByb2JlZC4NCkJ1dCBhZ2FpbiwgaXQgaXMgbm90IGEgMTAwJSBo
b3RwbHVnLCBhcyB3ZSBuZWVkIHRvIHByZS1hbGxvY2F0ZSBtZW1vcnkgDQpyYW5nZSBhbmQgaW50
ZXJydXB0IGluIGFkdmFuY2UgKHdoZW4gZ2VuZXJhdGluZyBndWVzdCBkZXZpY2UgdHJlZSkuDQoN
Cg0KPg0KPg0KPiBBcyBhbiBhbHRlcm5hdGl2ZSBJIHdvbmRlciwgZ2l2ZW4gdGhhdCBYZW4gZW11
bGF0ZXMgdGhlIFBDSSByb290DQo+IGNvbXBsZXgsIGlmIHdlIGNhbiByZXVzZSBvbmUgb2YgdGhl
IFBDSSBsaW5rIHVwL2Rvd24gZGVsYXlzIGZvciB0aGlzDQo+IGluc3RlYWQsIGxpa2UgInBjaWVf
d2FpdF9mb3JfbGluayIuIEl0IGxvb2tzIGxpa2UgdGhlIHdhaXQgdGltZSBpcyBpbg0KPiBtaWxs
aXNlYyB3aGlsZSB3ZSB3b3VsZCBuZWVkIHBvdGVudGlhbGx5IHNldmVyYWwgc2Vjb25kcyBoZXJl
IGJ1dCBpdA0KPiBtaWdodCBiZSBwb3NzaWJsZT8NCg0KSSBhbSBub3Qgc3VyZSB0aGF0IEkgdW5k
ZXJzdGFuZCB0aGlzIGFsdGVybmF0aXZlIGlkZWEuDQoNCg0KPg0KPiBPdGhlciBpZGVhcz8NCg0K
QW5vdGhlciAoY3Jhenk/KSBpZGVhIGlzIHRvIHJldXNlIENPTkZJR19YRU5fVklSVElPX0ZPUkNF
X0dSQU5UIGZvciANCmRvbTBsZXNzIHN5c3RlbSAoSSBtZWFuIHdpdGhvdXQgInhlbixncmFudC1k
bWEiIGJpbmRpbmdzIGF0IGFsbCkuDQpJZiB2aXJ0aW8gYmFja2VuZHMgYXJlIGFsd2F5cyBnb2lu
ZyB0byBydW4gaW4gRG9tMCB3aGVuIHdlIGhhdmUgaXQgdXAgDQphbmQgcnVubmluZywgdGhlbiBp
dCBzaG91bGQgd29yayBhcyBkb21pZCA9PSAwIGlzIHJlc2VydmVkIGZvciBEb20wLg0KSWYgdGhl
cmUgaXMgYSBuZWVkIHRvIHJ1biB2aXJ0aW8gYmFja2VuZHMgaW4gb3RoZXIgKmJhY2tlbmQqIGRv
bWFpbiAoZm9yIA0KdGhlIGRvbWFpbiBJRCB0byBiZSBhbHdheXMga25vd24gd2UgY291bGQgcmVz
ZXJ2ZSBhbiBJRCBmb3IgaXQsIHNvIGl0IA0Kd291bGQgYmUgYSBjb25zdCB2YWx1ZSksDQp3ZSBj
b3VsZCBwcm9iYWJseSBpbnRyb2R1Y2Ugc29tZXRoaW5nIGNvbmZpZ3VyYWJsZSBsaWtlIA0KQ09O
RklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlRfQkVfRE9NSUQgd2l0aCAwIGJ5IGRlZmF1bHQgKG9y
IGNtZCBsaW5lIA0Kb3B0aW9uKS4NCg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNo
ZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 18:39:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 18:39:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423538.670289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojm4H-0006uW-SN; Sat, 15 Oct 2022 18:39:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423538.670289; Sat, 15 Oct 2022 18:39:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojm4H-0006uP-PZ; Sat, 15 Oct 2022 18:39:29 +0000
Received: by outflank-mailman (input) for mailman id 423538;
 Sat, 15 Oct 2022 18:39:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojm4G-0006uF-Dx; Sat, 15 Oct 2022 18:39:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojm4G-0007lH-6o; Sat, 15 Oct 2022 18:39:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojm4F-0007ob-QZ; Sat, 15 Oct 2022 18:39:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojm4F-00069o-Q7; Sat, 15 Oct 2022 18:39:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WF1sO55O3oaaffgdWILXW9oPlWIsAFDIMtVOLVZgmO4=; b=kTu4jygWXATI2lFbDBs99wUwFz
	L/6jJ9E01sm3WoXZVpHzdwS0UP7TAWqCW+S3SnAy330Dr96Shs6hilq8STsaPLPJe8ciulUAL3pou
	IZspRAz0T6d+axgYdUaWAh3dEjBBFNrA+JMAIFAaFLXSm8UwSRLWwG3TI/smR282XGtk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173792-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173792: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    qemuu=2ba341b3694cf3cff7b8a1df4cc765900d5c4f60
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 18:39:27 +0000

flight 173792 qemu-mainline real [real]
flight 173837 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173792/
http://logs.test-lab.xenproject.org/osstest/logs/173837/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-vhd      21 guest-start/debian.repeat fail REGR. vs. 173447

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 173837-retest
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 173837-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-seattle   3 hosts-allocate               starved  n/a

version targeted for testing:
 qemuu                2ba341b3694cf3cff7b8a1df4cc765900d5c4f60
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z    9 days
Failing since        173497  2022-10-11 15:38:33 Z    4 days    5 attempts
Testing same since   173792  2022-10-15 03:18:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akihiko Odaki <akihiko.odaki@daynix.com>
  Alberto Faria <afaria@redhat.com>
  Alex Bennée <alex.bennee@linaro.org>
  Alexander Graf <agraf@csgraf.de>
  Ani Sinha <ani@anisinha.ca>
  Bin Meng <bin.meng@windriver.com>
  Bryce Mills <brycemills@proton.me>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniil Tatianin <d-tatianin@yandex-team.ru>
  David Hildenbrand <david@redhat.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dongwon Kim <dongwon.kim@intel.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Hal Martin <hal.martin@gmail.com>
  Helge Konetzka <hk@zapateado.de>
  Igor Mammedov <imammedo@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Jerome Forissier <jerome.forissier@linaro.org>
  Joel Stanley <joel@jms.id.au>
  John Millikin <john@john-millikin.com>
  Jonah Palmer <jonah.palmer@oracle.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Juan Quintela <quintela@redhat.com>
  Kevin Wolf <kwolf@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  lu zhipeng <luzhipeng@cestc.cn>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Michael Labiuk <michael.labiuk@virtuozzo.com>
  Michael S. Tsirkin <mst@redhat.com>
  Miguel Luis <miguel.luis@oracle.com>
  Pankaj Gupta <pankaj.gupta@amd.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Sebastian Mitterle <smitterl@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Volker Rümelin <vr_qemu@t-online.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  starved 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4908 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 19:04:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 19:04:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423548.670306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojmS1-0001oz-Re; Sat, 15 Oct 2022 19:04:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423548.670306; Sat, 15 Oct 2022 19:04:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojmS1-0001os-Mz; Sat, 15 Oct 2022 19:04:01 +0000
Received: by outflank-mailman (input) for mailman id 423548;
 Sat, 15 Oct 2022 19:04:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojmS0-0001oi-2j; Sat, 15 Oct 2022 19:04:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojmS0-0008Bd-0y; Sat, 15 Oct 2022 19:04:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojmRz-0000G1-QK; Sat, 15 Oct 2022 19:03:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojmRz-0003A6-Pw; Sat, 15 Oct 2022 19:03:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aTDzdvNYgKQ+2btLAjf9zjgnlCX0hcCaePHvH7BW7gg=; b=AzlLA/CaH22mXO8drKWw+Eq5N5
	grwrseneDVdDP/BgK8X733fZY3mI5PQgiFGt/8tIR8jraSKrVuz5cjPphpKwA0DEPIdXeD5txf6/f
	opa16wFOVYlZuSJAhhdyIxS6tc0YofDTQrpF91FABelkT/JmryCezAygkPZ0ttwwWwXk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173835-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173835: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 19:03:59 +0000

flight 173835 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173835/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   25 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 21:21:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 21:21:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423578.670376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojoaS-0007FN-9j; Sat, 15 Oct 2022 21:20:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423578.670376; Sat, 15 Oct 2022 21:20:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojoaS-0007FG-78; Sat, 15 Oct 2022 21:20:52 +0000
Received: by outflank-mailman (input) for mailman id 423578;
 Sat, 15 Oct 2022 21:20:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojoaR-0007F6-4x; Sat, 15 Oct 2022 21:20:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojoaQ-00027R-UT; Sat, 15 Oct 2022 21:20:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojoaQ-00072V-KS; Sat, 15 Oct 2022 21:20:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojoaQ-00015a-K3; Sat, 15 Oct 2022 21:20:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=I4avpkJDjvSLdlBLe3qoT0fd8xQ4u0ydsVXUKElveXk=; b=CNDKacd4KoAt6/7U7Tft15sSdT
	JZ54U5UI3wdkx8BnOJQgV928Soaq1ohNoi/aUo1xsmsclIqYeJpjnaSs5RxTbqpc/Ue3nTU7t/P48
	iSfZZmQpxj4Lk8Jhm4KZ94PpNMgpKEdKaALeUegXUCm6AIESz0bEsJA99/PCSCeSBGpM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173745-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173745: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9c9155a3509a2ebdb06d77c7a621e9685c802eac
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 21:20:50 +0000

flight 173745 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173745/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                9c9155a3509a2ebdb06d77c7a621e9685c802eac
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    8 days
Failing since        173470  2022-10-08 06:21:34 Z    7 days   16 attempts
Testing same since   173745  2022-10-14 07:20:33 Z    1 days    1 attempts

------------------------------------------------------------
1209 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 112556 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 22:06:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 22:06:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423595.670411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojpIz-0003VQ-7s; Sat, 15 Oct 2022 22:06:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423595.670411; Sat, 15 Oct 2022 22:06:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojpIz-0003VJ-4m; Sat, 15 Oct 2022 22:06:53 +0000
Received: by outflank-mailman (input) for mailman id 423595;
 Sat, 15 Oct 2022 22:06:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpIy-0003V9-OP; Sat, 15 Oct 2022 22:06:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpIy-0002um-Md; Sat, 15 Oct 2022 22:06:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpIy-0000Ki-9O; Sat, 15 Oct 2022 22:06:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpIy-0006Oe-8p; Sat, 15 Oct 2022 22:06:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=zIK1k/lNoeoINVS8MXCuhre9ydx0LyQ52eiNzaUlSKQ=; b=cTXjJKCAOAGcPX8KJUKAm8Wv2H
	KEHOJryZtl4JMpwAP+ITIu3/2VonpLj4XfjSOCmrL4LoeAqNIwoY3ko11uijs267O7nQe45Zjxi/o
	uGTQgFBaR7hedif2Ddw+3+0kRq/kGNGNTm2NyMHQ0aOVluAbZBA954ifVM8370H55TZM=;
To: xen-devel@lists.xenproject.org
Subject: [xen-unstable-smoke bisection] complete test-armhf-armhf-xl
Message-Id: <E1ojpIy-0006Oe-8p@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 22:06:52 +0000

branch xen-unstable-smoke
xenbranch xen-unstable-smoke
job test-armhf-armhf-xl
testid guest-start

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
  Bug not present: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173859/


  commit cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Mon Jun 6 06:17:30 2022 +0000
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/test-armhf-armhf-xl.guest-start.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/test-armhf-armhf-xl.guest-start --summary-out=tmp/173859.bisection-summary --basis-template=173457 --blessings=real,real-bisect,real-retry xen-unstable-smoke test-armhf-armhf-xl guest-start
Searching for failure / basis pass:
 173835 fail [host=cubietruck-braque] / 173457 ok.
Failure / basis pass flights: 173835 / 173457
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#9029bc265cdf2bd63376dde9fdd91db4ce9c0586-5310a3a\
 a5026fb27d6834306d920d6207a1e0898
Loaded 5001 nodes in revision graph
Searching for test results:
 173757 [host=arndale-metrocentre]
 173760 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 197f612b77c5afe04e60df2100a855370d720ad7
 173765 [host=arndale-metrocentre]
 173772 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
 173776 [host=cubietruck-picasso]
 173777 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
 173784 [host=cubietruck-picasso]
 173787 [host=cubietruck-picasso]
 173786 [host=arndale-lakeside]
 173789 [host=cubietruck-picasso]
 173791 [host=cubietruck-picasso]
 173795 [host=cubietruck-picasso]
 173800 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173801 [host=arndale-lakeside]
 173804 [host=arndale-lakeside]
 173809 [host=arndale-lakeside]
 173810 [host=cubietruck-picasso]
 173815 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
 173819 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
 173822 [host=arndale-metrocentre]
 173826 [host=cubietruck-picasso]
 173831 [host=cubietruck-picasso]
 173835 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173834 [host=arndale-metrocentre]
 173842 [host=arndale-metrocentre]
 173852 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
 173859 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
 173457 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586
 173492 [host=cubietruck-gleizes]
 173501 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
 173504 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586
 173506 [host=cubietruck-gleizes]
 173518 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
 173538 [host=cubietruck-picasso]
 173545 [host=cubietruck-gleizes]
 173574 [host=cubietruck-picasso]
 173583 [host=arndale-lakeside]
 173600 [host=cubietruck-picasso]
 173602 [host=arndale-lakeside]
 173604 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 87a20c98d9f0f422727fe9b4b9e22c2c43a5cd9c
 173609 [host=arndale-lakeside]
 173615 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f50a2c0e1d057c00d6061f40ae24d068226052ad
 173619 [host=arndale-lakeside]
 173630 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 55914f7fc91a468649b8a3ec3f53ae1c4aca6670
 173649 [host=cubietruck-gleizes]
 173660 [host=arndale-lakeside]
 173670 [host=cubietruck-picasso]
 173672 [host=cubietruck-gleizes]
 173688 [host=arndale-metrocentre]
 173695 [host=cubietruck-picasso]
 173701 [host=arndale-westfield]
 173707 [host=arndale-metrocentre]
 173754 [host=arndale-metrocentre]
 173751 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
 173709 [host=arndale-westfield]
 173710 [host=cubietruck-picasso]
 173721 [host=arndale-lakeside]
 173718 [host=arndale-westfield]
 173728 [host=arndale-lakeside]
 173730 [host=arndale-lakeside]
 173734 [host=cubietruck-picasso]
 173736 [host=arndale-lakeside]
 173741 [host=cubietruck-picasso]
 173743 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 171d4d24f829075cac83b6fafe7a4ed7c93935a6
 173746 [host=cubietruck-picasso]
 173749 [host=arndale-westfield]
Searching for interesting versions
 Result found: flight 173457 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, results HASH(0x55ce5fdcbfb8) HASH(0x55ce5fdd4900) HASH(0x55ce5fdd1670) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 55914f7fc91a468649b8a3ec3f53ae1c4aca6670, results \
 HASH(0x55ce5fdcbcb8) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f50a2c0e1d057c00d6061f40ae24d068226052ad, results HASH(0x55ce5fdc51f8) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 9029bc265cdf2bd63376dde9fdd91db4ce9c0586, results HASH(0x55ce5fdd90b8) H\
 ASH(0x55ce5fddb0c0) Result found: flight 173501 (fail), for basis failure (at ancestor ~623)
 Repro found: flight 173504 (pass), for basis pass
 Repro found: flight 173800 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
No revisions left to test, checking graph state.
 Result found: flight 173772 (pass), for last pass
 Result found: flight 173777 (fail), for first failure
 Repro found: flight 173815 (pass), for last pass
 Repro found: flight 173819 (fail), for first failure
 Repro found: flight 173852 (pass), for last pass
 Repro found: flight 173859 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
  Bug not present: cf2a68d2ffbc3ce95e01449d46180bddb10d24a0
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173859/


  commit cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Mon Jun 6 06:17:30 2022 +0000
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/test-armhf-armhf-xl.guest-start.{dot,ps,png,html,svg}.
----------------------------------------
173859: tolerable ALL FAIL

flight 173859 xen-unstable-smoke real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173859/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start             fail baseline untested


jobs:
 test-armhf-armhf-xl                                          fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Sat Oct 15 22:39:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 22:39:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423606.670432 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojpoV-0006zG-T4; Sat, 15 Oct 2022 22:39:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423606.670432; Sat, 15 Oct 2022 22:39:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojpoV-0006z9-Q6; Sat, 15 Oct 2022 22:39:27 +0000
Received: by outflank-mailman (input) for mailman id 423606;
 Sat, 15 Oct 2022 22:39:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpoV-0006yj-4j; Sat, 15 Oct 2022 22:39:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpoV-0003QX-2U; Sat, 15 Oct 2022 22:39:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpoU-0001nG-Ri; Sat, 15 Oct 2022 22:39:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojpoU-0005eQ-PD; Sat, 15 Oct 2022 22:39:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yr1n0GWZEqtSNVSJNW2A/6Vw+m7vUvF0TA55tBStuvU=; b=F7g/4KLFFGKAIU+pwmMT9fwHeL
	fsqI7jFSJzfETM+VSXlqnLAEHBYl+ZVIBQ+mNkXWNV4MJXNn3tHb8NlQEyLnvsz+dTWw1qUVVsR8q
	AbRH765hmiax47m6EHMgWShhPmm0GEAVi4UQlF8Bq6eRd1qBIST40f+p0zOhlYxOCXZY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173853-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173853: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 15 Oct 2022 22:39:26 +0000

flight 173853 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173853/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   26 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 15 22:51:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 15 Oct 2022 22:51:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423616.670448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojq00-0000u3-1N; Sat, 15 Oct 2022 22:51:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423616.670448; Sat, 15 Oct 2022 22:51:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojpzz-0000tw-Ux; Sat, 15 Oct 2022 22:51:19 +0000
Received: by outflank-mailman (input) for mailman id 423616;
 Sat, 15 Oct 2022 22:51:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yrUq=2Q=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ojpzy-0000tq-TU
 for xen-devel@lists.xenproject.org; Sat, 15 Oct 2022 22:51:19 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df3e24c9-4cdb-11ed-91b4-6bf2151ebd3b;
 Sun, 16 Oct 2022 00:51:16 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 212975C0085;
 Sat, 15 Oct 2022 18:51:14 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sat, 15 Oct 2022 18:51:14 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 15 Oct 2022 18:51:12 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df3e24c9-4cdb-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1665874274; x=
	1665960674; bh=lsI8o0/jCX1U87MykaqU47R3cuckKUOpHIcL/iH88/U=; b=l
	qTlx3V1TemcLGhEh+jRUhJmv9DgLttLKDTf+wxOAWk2yOgp9c7+iAu1cldyQdulp
	TeyIrGYtqdTqyoDlBHWrySGztzS1zHVQimg3yFIyT746OgQBlPvtIB04mc9jHaw/
	LHN603cRAeFQUZ76fji+y+M2TstfxTeVIIwVd55oe07hyYOK/Oaftd6FEzTBDGSO
	kODYRdDAUf1Q34zNPM38plVQEAjnhE8TpRg6O6Qu6NQzZrAWQmpSjdC0opilS5xp
	OtFBUnWGMZ1u5B5hTN5BUQleU+6jL45vSLva8jQcfDo46Fn/zk4eX7yBB0hgWM5M
	FwgwS3ECoWsjW9CSxOIGw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1665874274; x=1665960674; bh=lsI8o0/jCX1U87MykaqU47R3cuck
	KUOpHIcL/iH88/U=; b=jcWax2nmSOHREI/NPgclIDYqi+NClKoJ0DmsqiNhHENJ
	4dCXeaHymJO/GHnSJVa2Y5N+ZUxLk9DqV7gHwekvfnB2eoiCHO9bZbNxTiEyp/sp
	0GEKX8UEjK5SXfeaA01S9S+3NV9tPq0kxwELNX+gbciP8d2G7NZSIvsjAslxgFil
	38B+U3NxSjqXOVfBvki/XsM2NalrXXNUijtLboq14C5GyIznLTQlFz7t8BIZVXYi
	cbF416uPV2g2Sd5qG6NbXlVQi5e5uFgYXafp+ma595MGnG+7uaPSmTs5s0pHCZXb
	M3XR1BrTBuh9DYs+jTtLQeovfpXjdURvNB97HThEUQ==
X-ME-Sender: <xms:YTlLYwEbxxODFvhq8_MFM9hVj8DH8NuU3-gV12uCK4Fa_rhHIgRdfQ>
    <xme:YTlLY5WB61jNwKK7adDhRpI-gEgRBxaRGnam8Zk4CnARj1jWDAstazH9d50PvzlQJ
    a-xKGXZu0rlfw>
X-ME-Received: <xmr:YTlLY6JibhVD-xE4yEmigQ73ScjLeGQcJvTqKhVQF23w7m2UaIJn3uRD9nsxxJyIXOjG4S1HyxhLg2EiHyMsxV8iPJ_gtg2v80yZ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeekhedguddvucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:YTlLYyH32PoIDYfCaIy_rxQA9DnW4lXMW-kaWO230kZu-KhtRwBLPQ>
    <xmx:YTlLY2WjGGmVshP4L9FTJ7Rf23gGbASOYfJ1Gm8gIzeN8ujoF05ILQ>
    <xmx:YTlLY1PsTJo9CE3xq3zX1hvEpfH4A-h7_olCTCEnZaW_JE3ix5y-uw>
    <xmx:YjlLY_dxNFrEIG3MaAgogzviyGOHsUDxKWffWgdzY-qk2GYZMpXLDw>
Feedback-ID: i1568416f:Fastmail
Date: Sun, 16 Oct 2022 00:51:10 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org, Henry Wang <Henry.Wang@arm.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API
Message-ID: <Y0s5Xvr5PBQq5pVB@mail-itl>
References: <cover.9762b1190a6fd8f0232c26cbace1b2c4f8555818.1664458360.git-series.marmarek@invisiblethingslab.com>
 <ecee2217151efd08b2bae58166efcdd319ec82c8.1664458360.git-series.marmarek@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="K73I/ysDr9ud1QeM"
Content-Disposition: inline
In-Reply-To: <ecee2217151efd08b2bae58166efcdd319ec82c8.1664458360.git-series.marmarek@invisiblethingslab.com>


--K73I/ysDr9ud1QeM
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sun, 16 Oct 2022 00:51:10 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org, Henry Wang <Henry.Wang@arm.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API

On Thu, Sep 29, 2022 at 03:33:12PM +0200, Marek Marczykowski-G=C3=B3recki w=
rote:
> Re-use rmrr=3D parameter handling code to handle common device reserved
> memory.
>=20
> Move MAX_USER_RMRR_PAGES limit enforcement to apply only to
> user-configured ranges, but not those from internal callers.
>=20
> Signed-off-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingsl=
ab.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Henry, can this be included in 4.17? The AMD counterpart went in
earlier, but due to late review on Intel part, this one didn't.=20

> ---
> Changes in v8:
> - move add_one_user_rmrr() function earlier
> - extend commit message
> Changes in v3:
> - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR
> ---
>  xen/drivers/passthrough/vtd/dmar.c | 196 +++++++++++++++++-------------
>  1 file changed, 114 insertions(+), 82 deletions(-)
>=20
> diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough=
/vtd/dmar.c
> index 367304c8739c..78c8bad1515a 100644
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -861,113 +861,136 @@ static struct user_rmrr __initdata user_rmrrs[MAX=
_USER_RMRR];
> =20
>  /* Macro for RMRR inclusive range formatting. */
>  #define ERMRRU_FMT "[%lx-%lx]"
> -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn
> +#define ERMRRU_ARG base_pfn, end_pfn
> =20
> -static int __init add_user_rmrr(void)
> +/* Returns 1 on success, 0 when ignoring and < 0 on error. */
> +static int __init add_one_user_rmrr(unsigned long base_pfn,
> +                                    unsigned long end_pfn,
> +                                    unsigned int dev_count,
> +                                    uint32_t *sbdf)
>  {
>      struct acpi_rmrr_unit *rmrr, *rmrru;
> -    unsigned int idx, seg, i;
> -    unsigned long base, end;
> +    unsigned int idx, seg;
> +    unsigned long base_iter;
>      bool overlap;
> =20
> -    for ( i =3D 0; i < nr_rmrr; i++ )
> +    if ( iommu_verbose )
> +        printk(XENLOG_DEBUG VTDPREFIX
> +               "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\=
n",
> +               dev_count, sbdf[0], ERMRRU_ARG);
> +
> +    if ( base_pfn > end_pfn )
>      {
> -        base =3D user_rmrrs[i].base_pfn;
> -        end =3D user_rmrrs[i].end_pfn;
> +        printk(XENLOG_ERR VTDPREFIX
> +               "Invalid RMRR Range "ERMRRU_FMT"\n",
> +               ERMRRU_ARG);
> +        return 0;
> +    }
> =20
> -        if ( base > end )
> +    overlap =3D false;
> +    list_for_each_entry(rmrru, &acpi_rmrr_units, list)
> +    {
> +        if ( pfn_to_paddr(base_pfn) <=3D rmrru->end_address &&
> +             rmrru->base_address <=3D pfn_to_paddr(end_pfn) )
>          {
>              printk(XENLOG_ERR VTDPREFIX
> -                   "Invalid RMRR Range "ERMRRU_FMT"\n",
> -                   ERMRRU_ARG(user_rmrrs[i]));
> -            continue;
> +                   "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n",
> +                   ERMRRU_ARG,
> +                   paddr_to_pfn(rmrru->base_address),
> +                   paddr_to_pfn(rmrru->end_address));
> +            overlap =3D true;
> +            break;
>          }
> +    }
> +    /* Don't add overlapping RMRR. */
> +    if ( overlap )
> +        return 0;
> =20
> -        if ( (end - base) >=3D MAX_USER_RMRR_PAGES )
> +    base_iter =3D base_pfn;
> +    do
> +    {
> +        if ( !mfn_valid(_mfn(base_iter)) )
>          {
>              printk(XENLOG_ERR VTDPREFIX
> -                   "RMRR range "ERMRRU_FMT" exceeds "\
> -                   __stringify(MAX_USER_RMRR_PAGES)" pages\n",
> -                   ERMRRU_ARG(user_rmrrs[i]));
> -            continue;
> +                   "Invalid pfn in RMRR range "ERMRRU_FMT"\n",
> +                   ERMRRU_ARG);
> +            break;
>          }
> +    } while ( base_iter++ < end_pfn );
> =20
> -        overlap =3D false;
> -        list_for_each_entry(rmrru, &acpi_rmrr_units, list)
> -        {
> -            if ( pfn_to_paddr(base) <=3D rmrru->end_address &&
> -                 rmrru->base_address <=3D pfn_to_paddr(end) )
> -            {
> -                printk(XENLOG_ERR VTDPREFIX
> -                       "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n",
> -                       ERMRRU_ARG(user_rmrrs[i]),
> -                       paddr_to_pfn(rmrru->base_address),
> -                       paddr_to_pfn(rmrru->end_address));
> -                overlap =3D true;
> -                break;
> -            }
> -        }
> -        /* Don't add overlapping RMRR. */
> -        if ( overlap )
> -            continue;
> +    /* Invalid pfn in range as the loop ended before end_pfn was reached=
=2E */
> +    if ( base_iter <=3D end_pfn )
> +        return 0;
> =20
> -        do
> -        {
> -            if ( !mfn_valid(_mfn(base)) )
> -            {
> -                printk(XENLOG_ERR VTDPREFIX
> -                       "Invalid pfn in RMRR range "ERMRRU_FMT"\n",
> -                       ERMRRU_ARG(user_rmrrs[i]));
> -                break;
> -            }
> -        } while ( base++ < end );
> +    rmrr =3D xzalloc(struct acpi_rmrr_unit);
> +    if ( !rmrr )
> +        return -ENOMEM;
> =20
> -        /* Invalid pfn in range as the loop ended before end_pfn was rea=
ched. */
> -        if ( base <=3D end )
> -            continue;
> +    rmrr->scope.devices =3D xmalloc_array(u16, dev_count);
> +    if ( !rmrr->scope.devices )
> +    {
> +        xfree(rmrr);
> +        return -ENOMEM;
> +    }
> =20
> -        rmrr =3D xzalloc(struct acpi_rmrr_unit);
> -        if ( !rmrr )
> -            return -ENOMEM;
> +    seg =3D 0;
> +    for ( idx =3D 0; idx < dev_count; idx++ )
> +    {
> +        rmrr->scope.devices[idx] =3D sbdf[idx];
> +        seg |=3D PCI_SEG(sbdf[idx]);
> +    }
> +    if ( seg !=3D PCI_SEG(sbdf[0]) )
> +    {
> +        printk(XENLOG_ERR VTDPREFIX
> +               "Segments are not equal for RMRR range "ERMRRU_FMT"\n",
> +               ERMRRU_ARG);
> +        scope_devices_free(&rmrr->scope);
> +        xfree(rmrr);
> +        return 0;
> +    }
> =20
> -        rmrr->scope.devices =3D xmalloc_array(u16, user_rmrrs[i].dev_cou=
nt);
> -        if ( !rmrr->scope.devices )
> -        {
> -            xfree(rmrr);
> -            return -ENOMEM;
> -        }
> +    rmrr->segment =3D seg;
> +    rmrr->base_address =3D pfn_to_paddr(base_pfn);
> +    /* Align the end_address to the end of the page */
> +    rmrr->end_address =3D pfn_to_paddr(end_pfn) | ~PAGE_MASK;
> +    rmrr->scope.devices_cnt =3D dev_count;
> =20
> -        seg =3D 0;
> -        for ( idx =3D 0; idx < user_rmrrs[i].dev_count; idx++ )
> -        {
> -            rmrr->scope.devices[idx] =3D user_rmrrs[i].sbdf[idx];
> -            seg |=3D PCI_SEG(user_rmrrs[i].sbdf[idx]);
> -        }
> -        if ( seg !=3D PCI_SEG(user_rmrrs[i].sbdf[0]) )
> -        {
> -            printk(XENLOG_ERR VTDPREFIX
> -                   "Segments are not equal for RMRR range "ERMRRU_FMT"\n=
",
> -                   ERMRRU_ARG(user_rmrrs[i]));
> -            scope_devices_free(&rmrr->scope);
> -            xfree(rmrr);
> -            continue;
> -        }
> +    if ( register_one_rmrr(rmrr) )
> +        printk(XENLOG_ERR VTDPREFIX
> +               "Could not register RMMR range "ERMRRU_FMT"\n",
> +               ERMRRU_ARG);
> =20
> -        rmrr->segment =3D seg;
> -        rmrr->base_address =3D pfn_to_paddr(user_rmrrs[i].base_pfn);
> -        /* Align the end_address to the end of the page */
> -        rmrr->end_address =3D pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAG=
E_MASK;
> -        rmrr->scope.devices_cnt =3D user_rmrrs[i].dev_count;
> +    return 1;
> +}
> =20
> -        if ( register_one_rmrr(rmrr) )
> -            printk(XENLOG_ERR VTDPREFIX
> -                   "Could not register RMMR range "ERMRRU_FMT"\n",
> -                   ERMRRU_ARG(user_rmrrs[i]));
> -    }
> +static int __init add_user_rmrr(void)
> +{
> +    unsigned int i;
> +    int ret;
> =20
> +    for ( i =3D 0; i < nr_rmrr; i++ )
> +    {
> +        ret =3D add_one_user_rmrr(user_rmrrs[i].base_pfn,
> +                                user_rmrrs[i].end_pfn,
> +                                user_rmrrs[i].dev_count,
> +                                user_rmrrs[i].sbdf);
> +        if ( ret < 0 )
> +            return ret;
> +    }
>      return 0;
>  }
> =20
> +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong=
_t nr, u32 id, void *ctxt)
> +{
> +    u32 sbdf_array[] =3D { id };
> +    return add_one_user_rmrr(start, start+nr, 1, sbdf_array);
> +}
> +
> +static int __init add_extra_rmrr(void)
> +{
> +    return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NU=
LL);
> +}
> +
>  #include <asm/tboot.h>
>  /* ACPI tables may not be DMA protected by tboot, so use DMAR copy */
>  /* SINIT saved in SinitMleData in TXT heap (which is DMA protected) */
> @@ -1010,7 +1033,7 @@ int __init acpi_dmar_init(void)
>      {
>          iommu_init_ops =3D &intel_iommu_init_ops;
> =20
> -        return add_user_rmrr();
> +        return add_user_rmrr() || add_extra_rmrr();
>      }
> =20
>      return ret;
> @@ -1108,6 +1131,15 @@ static int __init cf_check parse_rmrr_param(const =
char *str)
>          else
>              end =3D start;
> =20
> +        if ( (end - start) >=3D MAX_USER_RMRR_PAGES )
> +        {
> +            printk(XENLOG_ERR VTDPREFIX
> +                    "RMRR range "ERMRRU_FMT" exceeds "\
> +                    __stringify(MAX_USER_RMRR_PAGES)" pages\n",
> +                    start, end);
> +            return -E2BIG;
> +        }
> +
>          user_rmrrs[nr_rmrr].base_pfn =3D start;
>          user_rmrrs[nr_rmrr].end_pfn =3D end;
> =20
> --=20
> git-series 0.9.1
>=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--K73I/ysDr9ud1QeM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNLOV4ACgkQ24/THMrX
1yxJIgf/UertV8nQx+ovAyl6sMltNkkw8Rbm5wCXIiLCB0eR2gvnZRRr4kCBxaqT
Vd4LR9+AmOvFjc/o+lqNOorSUvyztcgmyxhP1xPqrEx9Ty2R39gfCfSj+r2aGTnl
/NuVd7c+SpUwwpfFveZrfTc5Wn9cxM0QRqEcOwXDdHZDqcap6cYPn/Ctqf9X2d8z
TNPFIOVishHVx39P1FMDo4quhmziVbmR95ws19tUKbgxm2EkRlScYp3P5UMWgCuo
LvMEcpOldhHV3fI46piWvGqvGjNdnHf7GybKzkZof5BqNPcyoTPg3idsMUo2bfzZ
wBKa7qSx3emXYevOLrhQpWpRYeMgcg==
=fvUY
-----END PGP SIGNATURE-----

--K73I/ysDr9ud1QeM--


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 00:22:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 00:22:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423638.670499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojrQ6-0002Ru-WC; Sun, 16 Oct 2022 00:22:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423638.670499; Sun, 16 Oct 2022 00:22:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojrQ6-0002Rn-TT; Sun, 16 Oct 2022 00:22:22 +0000
Received: by outflank-mailman (input) for mailman id 423638;
 Sun, 16 Oct 2022 00:22:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojrQ4-0002Rd-P4; Sun, 16 Oct 2022 00:22:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojrQ4-0005ko-Lv; Sun, 16 Oct 2022 00:22:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojrQ4-0007Iu-BO; Sun, 16 Oct 2022 00:22:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojrQ4-0001Jr-Av; Sun, 16 Oct 2022 00:22:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Xs8FdlG6mwaEhfs9NUgJJGoDNnCo8QVp3GelYLPca/0=; b=2+goN0ZyNAmWKl+FqiRGzKnU5W
	V0RHCB1v4l1J2/d+prHcng+DwEvbtSkgcq8oBik07VMtBmHgYPNL15jgVsV2cEMKRmoRa4ueaNQh2
	Uxqip6ffXMofF842WG20+TyA0xU7qHU7iCaAN/uXkPWXIqH1La6VZ5whyb4o7kwcGu0E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173796-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 173796: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=e7d6f2d958705bf3298cbe7c1e7d9ded772a643c
X-Osstest-Versions-That:
    libvirt=06ebad7c783fc44b23284c86cbaf4052f99834fd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 00:22:20 +0000

flight 173796 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173796/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173742
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173742
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173742
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              e7d6f2d958705bf3298cbe7c1e7d9ded772a643c
baseline version:
 libvirt              06ebad7c783fc44b23284c86cbaf4052f99834fd

Last test of basis   173742  2022-10-14 04:18:49 Z    1 days
Testing same since   173796  2022-10-15 04:18:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jim Fehlig <jfehlig@suse.com>
  Peter Krempa <pkrempa@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   06ebad7c78..e7d6f2d958  e7d6f2d958705bf3298cbe7c1e7d9ded772a643c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 01:42:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 01:42:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423664.670543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojsfe-0000VF-6O; Sun, 16 Oct 2022 01:42:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423664.670543; Sun, 16 Oct 2022 01:42:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojsfe-0000V7-1i; Sun, 16 Oct 2022 01:42:30 +0000
Received: by outflank-mailman (input) for mailman id 423664;
 Sun, 16 Oct 2022 01:42:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsfd-0000Ue-AX; Sun, 16 Oct 2022 01:42:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsfd-00011m-7X; Sun, 16 Oct 2022 01:42:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsfc-00020g-U2; Sun, 16 Oct 2022 01:42:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsfc-0007OV-TY; Sun, 16 Oct 2022 01:42:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XvEbUTi4XC1AcqjvRMMTH9OBsJ2dTXmOwwiio4xWrHE=; b=nJH7uk4HxwPJs51Bt6k+Jwfa7P
	8gkLqaFCqObf2uk+5xoX1mZdZBV0gwtBBk9GfZYE/TQbQrJRnMk6b8UPoxRHP/TNiAk41/+40tBo6
	EEkokhyKIWMFc5pMOHs4VVv9Oc6SlU1XHMu5F1/S1VNOIM1OE+BK1wk3wZRM6sln+45I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173869-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173869: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 01:42:28 +0000

flight 173869 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173869/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173853

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173853 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173853 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   27 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 01:59:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 01:59:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423672.670554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojsvk-00026v-HR; Sun, 16 Oct 2022 01:59:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423672.670554; Sun, 16 Oct 2022 01:59:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojsvk-00026o-EO; Sun, 16 Oct 2022 01:59:08 +0000
Received: by outflank-mailman (input) for mailman id 423672;
 Sun, 16 Oct 2022 01:59:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsvj-00026e-F6; Sun, 16 Oct 2022 01:59:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsvj-0002P6-Bb; Sun, 16 Oct 2022 01:59:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsvi-0002Qd-VF; Sun, 16 Oct 2022 01:59:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojsvi-0002sw-Um; Sun, 16 Oct 2022 01:59:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+SEFkXdKJqDRYuIiRLxUw55a57ag8YezO1bnVQx+Ptk=; b=l2YMy/hK+UWW7DBlpkmFTyPghr
	aAG9UyZc6jZAMkwxy+VPNfrxRkvwE5N2LdYUQMNRLm+HsH7lqzudQAmRzGakh7O4uDxeqfmYKLVKU
	+Dyf2l7+T+5oV6cPmAA0Itcf8T15NQhrHjyP0KPw+7PtQETu4PbrM83Y2gKFdLd8ydkE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173759-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173759: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 01:59:06 +0000

flight 173759 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173759/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 173759
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   58 days
Testing same since   173493  2022-10-11 13:07:01 Z    4 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 04:18:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 04:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423699.670619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojv61-00083C-9i; Sun, 16 Oct 2022 04:17:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423699.670619; Sun, 16 Oct 2022 04:17:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojv61-000835-75; Sun, 16 Oct 2022 04:17:53 +0000
Received: by outflank-mailman (input) for mailman id 423699;
 Sun, 16 Oct 2022 04:17:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojv60-00082v-FB; Sun, 16 Oct 2022 04:17:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojv60-0005CT-Cb; Sun, 16 Oct 2022 04:17:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojv5z-0007ui-VF; Sun, 16 Oct 2022 04:17:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojv5z-0005O9-UT; Sun, 16 Oct 2022 04:17:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=f4ydXRVVEi8s9YM30BeAEjHTF33yu9OZwWta1xq/FLw=; b=R4AZZW9dUousK2ifxRks7d6mM9
	1L0DtO+rxKQlFTqFc9HqceboyJjYQzNJr4NA7jtWAwiDz9UC/GVdl+LD+D1SE12TAUGSu719bRLs0
	zMbXbvlw1jV6q0YrWWTf6P6SL622gqurKDMLRl+7dio516FzUrusOAkMCi5uZrNniRoM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173885-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173885: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 04:17:51 +0000

flight 173885 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173885/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173853

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173853 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173853 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   28 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 06:32:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 06:32:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423736.670677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojxCB-0005JJ-14; Sun, 16 Oct 2022 06:32:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423736.670677; Sun, 16 Oct 2022 06:32:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojxCA-0005JC-UP; Sun, 16 Oct 2022 06:32:22 +0000
Received: by outflank-mailman (input) for mailman id 423736;
 Sun, 16 Oct 2022 06:32:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxC9-0005J2-Tc; Sun, 16 Oct 2022 06:32:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxC9-0007sd-QU; Sun, 16 Oct 2022 06:32:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxC9-0006U2-8b; Sun, 16 Oct 2022 06:32:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxC9-0006oN-86; Sun, 16 Oct 2022 06:32:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0fN7xeZNrd99O5mMICY/R9DBI98eDtTZSwoLFUZad0U=; b=N2WuNxNAKzlhKAnekUIyAmYbn+
	L6dT7MK2BfwBbSOJ7gvRwgDmuF9M+Qfjog17Ing3KA2adCdLqXtd4VysgZIV2jTzNTznG+bx/Iuh1
	m+2FGAX/G2VBYuDARDE6W+6qO7t7SfZgl6gVSVKJ5eNUCRyrF9nbE2OATf3I9XPFsqyg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173782-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173782: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 06:32:21 +0000

flight 173782 xen-4.15-testing real [real]
flight 173893 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173782/
http://logs.test-lab.xenproject.org/osstest/logs/173893/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   61 days
Failing since        173494  2022-10-11 13:38:08 Z    4 days    7 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    3 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 07:02:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 07:02:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423746.670695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojxf5-0000KK-EB; Sun, 16 Oct 2022 07:02:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423746.670695; Sun, 16 Oct 2022 07:02:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojxf5-0000KD-B5; Sun, 16 Oct 2022 07:02:15 +0000
Received: by outflank-mailman (input) for mailman id 423746;
 Sun, 16 Oct 2022 07:02:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxf4-0000K3-Bz; Sun, 16 Oct 2022 07:02:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxf4-0008OX-9E; Sun, 16 Oct 2022 07:02:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxf3-0007y8-Uu; Sun, 16 Oct 2022 07:02:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxf3-0000Zg-UQ; Sun, 16 Oct 2022 07:02:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HZz6wNN6/GYIPpxAO9/Y9xlAcTav/8QLkwZm/rmYunM=; b=KwfFJFUZ5dUcGrLow5ZiWMaZnd
	m/JP2WUUzcwuV2z8DxOxOurTSDlJx1djsFHf5JLJdfN+uN9MWijmaFqXNTUlWLk33YvlLqSPOgAde
	7K36WVSTx50mQeS16NN1zm3XjnsHlwGtsG3qh0S6q1ZIcrpeosQM2CJJvQO5tVi6gYx4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173799-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173799: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 07:02:13 +0000

flight 173799 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173799/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 173799
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 173799
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-amd64-i386-xl-qemuu-win7-amd64 12 windows-install     fail pass in 173725

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop   fail in 173725 like 172550
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173725 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1   3 hosts-allocate               starved  n/a
 test-arm64-arm64-libvirt-raw  3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   61 days
Failing since        173496  2022-10-11 14:08:01 Z    4 days    6 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    3 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  starved 
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 starved 
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 07:05:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 07:05:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423755.670705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojxiQ-00010N-0c; Sun, 16 Oct 2022 07:05:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423755.670705; Sun, 16 Oct 2022 07:05:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojxiP-00010G-UI; Sun, 16 Oct 2022 07:05:41 +0000
Received: by outflank-mailman (input) for mailman id 423755;
 Sun, 16 Oct 2022 07:05:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxiO-000106-QZ; Sun, 16 Oct 2022 07:05:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxiO-0008R8-Ph; Sun, 16 Oct 2022 07:05:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxiO-000857-JL; Sun, 16 Oct 2022 07:05:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojxiO-00041Z-It; Sun, 16 Oct 2022 07:05:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Fs3iBf8I+2IQM8SGNB+LxuAJ1JFH9c6dKc3goJpWo2k=; b=V3BcpQw7DwafYPO+VTp6CSDpiK
	uel/lKwPloDW+3Wq8kwCJn1u8nR9doJaeZ7c++14mqHPFLLDKu1I1PP4TYA06n5839tAl5AfVF559
	FRnVqhor5JAU54GPulnKHSr3sPPjZjzbsCYEq5MKajQJOVaIXdnlMNa2M1y0svBF9rEM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173897-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173897: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 07:05:40 +0000

flight 173897 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173897/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173853

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173853 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173853 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   29 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 07:29:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 07:29:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423770.670738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojy5Y-0003Xz-5K; Sun, 16 Oct 2022 07:29:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423770.670738; Sun, 16 Oct 2022 07:29:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojy5Y-0003Xs-1D; Sun, 16 Oct 2022 07:29:36 +0000
Received: by outflank-mailman (input) for mailman id 423770;
 Sun, 16 Oct 2022 07:29:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojy5W-0003Xi-Mh; Sun, 16 Oct 2022 07:29:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojy5W-0000Ov-LZ; Sun, 16 Oct 2022 07:29:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojy5W-0000Lc-Ar; Sun, 16 Oct 2022 07:29:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojy5W-0005kx-AU; Sun, 16 Oct 2022 07:29:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YoWW4WvO5IRXB/sRplCSqE6/XAT53MwiAfgIoDsjIWY=; b=Eq/pGzDNQwpfiinRCWNJ2qm8mY
	nVGkdGqecMbjI/Prw9BQ7Nl1/t16ohO4qQuhDlqsDTzrOJhkpY5mPPxqQC3pyKXmbe5srMlCGfWSi
	f6WQjSCjkkOSynr72Xw8qU5tYdWZOIRxHwpoyW4XKWBRCtOpEr1LBltMvXTmXrgyIt1A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173896-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173896: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=d618fe05bf93a8884619e9362bfc5636da55e347
X-Osstest-Versions-That:
    ovmf=8fc06b6e19e3df93cc989b4f85877d8a7783e5bf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 07:29:34 +0000

flight 173896 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173896/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 d618fe05bf93a8884619e9362bfc5636da55e347
baseline version:
 ovmf                 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf

Last test of basis   173752  2022-10-14 11:10:29 Z    1 days
Testing same since   173896  2022-10-16 04:41:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pierre Gondois <pierre.gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   8fc06b6e19..d618fe05bf  d618fe05bf93a8884619e9362bfc5636da55e347 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 08:24:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 08:24:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423784.670762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojywK-0001lm-Ne; Sun, 16 Oct 2022 08:24:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423784.670762; Sun, 16 Oct 2022 08:24:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ojywK-0001lf-Iw; Sun, 16 Oct 2022 08:24:08 +0000
Received: by outflank-mailman (input) for mailman id 423784;
 Sun, 16 Oct 2022 08:24:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojywJ-0001lV-9l; Sun, 16 Oct 2022 08:24:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojywJ-0001or-5v; Sun, 16 Oct 2022 08:24:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ojywI-00026h-Qw; Sun, 16 Oct 2022 08:24:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ojywI-00040C-QT; Sun, 16 Oct 2022 08:24:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=WDqbX4adQB93dTw57jbYK1+avNCRHZHqOSyNRoK4F8Y=; b=xeqKV4BMivv8E2OdRLAK1hqQEq
	U1GOA05SCu2kk2pLk5zzlTVwk+po6SN8BXFeE3MQpNPWljnQXgj5aSbRDXuU0R6/V0/kupfmGqZ5h
	y4HIMCEdXNwpT3WBfyhuWky7RbsUCHZSZ7hs+uV9eY81fltxzBerxdn10DLzkJulHAdo=;
To: xen-devel@lists.xenproject.org
Subject: [xen-unstable-smoke bisection] complete build-amd64
Message-Id: <E1ojywI-00040C-QT@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 08:24:06 +0000

branch xen-unstable-smoke
xenbranch xen-unstable-smoke
job build-amd64
testid xen-build

Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  e4f5949c446635a854f06317b81db11cccfdabee
  Bug not present: fcdb9cdb953d6c1f893286c3619e74f72e1327fc
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173913/


  commit e4f5949c446635a854f06317b81db11cccfdabee
  Author: Anthony PERARD <anthony.perard@citrix.com>
  Date:   Thu Oct 13 14:05:00 2022 +0100
  
      tools: Add -Werror by default to all tools/
      
      And provide an option to ./configure to disable it.
      
      A follow-up patch will remove -Werror from every other Makefile in
      tools/.
      
      Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
      Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
      Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
      Release-acked-by: Henry Wang <Henry.Wang@arm.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/build-amd64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/build-amd64.xen-build --summary-out=tmp/173913.bisection-summary --basis-template=173457 --blessings=real,real-bisect,real-retry xen-unstable-smoke build-amd64 xen-build
Searching for failure / basis pass:
 173897 fail [host=huxelrebe0] / 173760 [host=pinot1] 173754 [host=albana0] 173749 [host=sabro0] 173743 [host=italia1] 173734 [host=sabro1] 173728 [host=sabro1] 173721 [host=sabro0] 173710 [host=sabro1] 173701 [host=pinot1] 173688 [host=albana0] 173670 [host=sabro1] 173649 [host=sabro1] 173619 ok.
Failure / basis pass flights: 173897 / 173619
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
Basis pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 448d28309f1a966bdc850aff1a637e0b79a03e43
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#448d28309f1a966bdc850aff1a637e0b79a03e43-5310a3aa5026fb27d6834306d920d6207a1e0898
Loaded 5001 nodes in revision graph
Searching for test results:
 173760 [host=pinot1]
 173776 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173786 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173800 [host=sabro1]
 173810 [host=italia1]
 173822 [host=italia1]
 173835 [host=italia1]
 173853 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173867 [host=italia1]
 173868 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 448d28309f1a966bdc850aff1a637e0b79a03e43
 173874 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173869 [host=italia1]
 173880 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fcdb9cdb953d6c1f893286c3619e74f72e1327fc
 173885 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173886 [host=italia1]
 173889 [host=italia1]
 173892 [host=italia1]
 173895 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4834dd5521a36cec118ed84b7c09a509edaafa6b
 173900 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 40d96f0c7d5399f9b824926279d41ead974fbe39
 173901 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 e4f5949c446635a854f06317b81db11cccfdabee
 173897 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 5310a3aa5026fb27d6834306d920d6207a1e0898
 173903 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fcdb9cdb953d6c1f893286c3619e74f72e1327fc
 173907 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 e4f5949c446635a854f06317b81db11cccfdabee
 173910 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fcdb9cdb953d6c1f893286c3619e74f72e1327fc
 173913 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 e4f5949c446635a854f06317b81db11cccfdabee
 173619 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 448d28309f1a966bdc850aff1a637e0b79a03e43
 173649 [host=sabro1]
 173670 [host=sabro1]
 173688 [host=albana0]
 173701 [host=pinot1]
 173754 [host=albana0]
 173710 [host=sabro1]
 173721 [host=sabro0]
 173728 [host=sabro1]
 173734 [host=sabro1]
 173743 [host=italia1]
 173749 [host=sabro0]
Searching for interesting versions
 Result found: flight 173619 (pass), for basis pass
 For basis failure, parent search stopping at 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fcdb9cdb953d6c1f893286c3619e74f72e1327fc, results HASH(0x55d31a4755d8) HASH(0x55d31a48ff58) HASH(0x55d31a47c698) For basis failure, parent search stopping at 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 448d28309f1a966bdc850aff1a637e0b79a03e43, results HASH(0x55d31a47f928) HASH(0x55d31a472e28) Result found: flight 173776 (fail), for \
 basis failure (at ancestor ~623)
 Repro found: flight 173868 (pass), for basis pass
 Repro found: flight 173874 (fail), for basis failure
 0 revisions at 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 fcdb9cdb953d6c1f893286c3619e74f72e1327fc
No revisions left to test, checking graph state.
 Result found: flight 173880 (pass), for last pass
 Result found: flight 173901 (fail), for first failure
 Repro found: flight 173903 (pass), for last pass
 Repro found: flight 173907 (fail), for first failure
 Repro found: flight 173910 (pass), for last pass
 Repro found: flight 173913 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  e4f5949c446635a854f06317b81db11cccfdabee
  Bug not present: fcdb9cdb953d6c1f893286c3619e74f72e1327fc
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173913/


  commit e4f5949c446635a854f06317b81db11cccfdabee
  Author: Anthony PERARD <anthony.perard@citrix.com>
  Date:   Thu Oct 13 14:05:00 2022 +0100
  
      tools: Add -Werror by default to all tools/
      
      And provide an option to ./configure to disable it.
      
      A follow-up patch will remove -Werror from every other Makefile in
      tools/.
      
      Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
      Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
      Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
      Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/build-amd64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
173913: tolerable ALL FAIL

flight 173913 xen-unstable-smoke real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173913/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64                   6 xen-build               fail baseline untested


jobs:
 build-amd64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Sun Oct 16 10:22:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 10:22:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423802.670802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok0mH-00057O-Hp; Sun, 16 Oct 2022 10:21:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423802.670802; Sun, 16 Oct 2022 10:21:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok0mH-00057H-FA; Sun, 16 Oct 2022 10:21:53 +0000
Received: by outflank-mailman (input) for mailman id 423802;
 Sun, 16 Oct 2022 10:21:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok0mG-000577-FL; Sun, 16 Oct 2022 10:21:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok0mG-0003ph-99; Sun, 16 Oct 2022 10:21:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok0mG-0002Ku-2q; Sun, 16 Oct 2022 10:21:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ok0mG-0003kN-19; Sun, 16 Oct 2022 10:21:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qMD6nSico0z0Oj4RX6KDkyAJZi/5ZuLVg4/DRNLFWmM=; b=mwQP2eKC53mGT2dGW0Jz/GcZ+H
	RNXCRi4fx5vpee7kp11EdmtwhhzNa+GxY1TJhLsAb48CxRiVT9RZ3tRZhfY1ufd4lCn6oFrW+FElS
	PRMmj09NuuGzG57b2mykvkPSv6ok1erQsN9CkL4HSlv2tz6dwmqNVIKAGf7YzzW+ZMyo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173812-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173812: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 10:21:52 +0000

flight 173812 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173812/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173738 pass in 173812
 test-amd64-i386-examine       6 xen-install                fail pass in 173738
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 173738

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173738
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173738
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173738
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173738
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173738
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173738
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173738
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173738
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173738
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173738
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173738
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173738
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle   3 hosts-allocate           starved in 173738 n/a

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173812  2022-10-15 08:16:48 Z    1 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      fail    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 16 11:09:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 11:09:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423813.670818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok1Vr-0001HG-88; Sun, 16 Oct 2022 11:08:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423813.670818; Sun, 16 Oct 2022 11:08:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok1Vr-0001H9-5O; Sun, 16 Oct 2022 11:08:59 +0000
Received: by outflank-mailman (input) for mailman id 423813;
 Sun, 16 Oct 2022 11:08:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dQ1r=2R=leemhuis.info=regressions@srs-se1.protection.inumbo.net>)
 id 1ok1Vq-0001H3-Ry
 for xen-devel@lists.xenproject.org; Sun, 16 Oct 2022 11:08:58 +0000
Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de
 [2a01:488:42:1000:50ed:8234::])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ece6ad99-4d42-11ed-8fd0-01056ac49cbb;
 Sun, 16 Oct 2022 13:08:57 +0200 (CEST)
Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated
 by wp530.webpack.hosteurope.de running ExIM with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
 id 1ok1Vm-0004V4-1l; Sun, 16 Oct 2022 13:08:54 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ece6ad99-4d42-11ed-8fd0-01056ac49cbb
Message-ID: <e2cf3207-e9e9-5585-1a6e-9b39d96b4b54@leemhuis.info>
Date: Sun, 16 Oct 2022 13:08:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Content-Language: en-US, de-DE
Cc: Denis Chancogne <denis.chancogne@free.fr>,
 "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
 LKML <linux-kernel@vger.kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Bug 216581 - Kernel panic on /init as busybox symbolic link with xen
 efi
To: Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1665918537;ab641a8f;
X-HE-SMSGID: 1ok1Vm-0004V4-1l

Hi, this is your Linux kernel regression tracker speaking.

I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developer don't keep an eye on it, I decided to forward it by
mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216581 :

>  Denis Chancogne 2022-10-13 22:00:19 UTC
> 
> Created attachment 302995 [details]
> /proc/cpuinfo, .config
> 
> Hi,
> 
> when I start Xen 4.15.3 in efi with kernel 5.18.19, all works well;
> but since kernel 5.19, I have a kernel panic on my /init process as
> busybox symbolic link inside initramfs.
> 
> This is the kernel log :
> ...
> [    6.265122] Run /init as init process
> [    6.266027] traps: init[1] trap invalid opcode ip:5855d1 sp:7ffe5ceddeb0 error:0 in busybox[401000+1db000]
> [    6.266553] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004
> [    6.267039] CPU: 3 PID: 1 Comm: init Tainted: G        W         5.19.0-dch #1
> [    6.267522] Hardware name: Micro-Star International Co., Ltd. MS-7B84/B450M PRO-M2 (MS-7B84), BIOS 2.E0 06/12/2020
> [    6.268010] Call Trace:
> [    6.268495]  <TASK>
> [    6.268974]  dump_stack_lvl+0x45/0x5e
> [    6.269455]  panic+0x107/0x285
> [    6.269923]  do_exit.cold+0x15/0x45
> [    6.270389]  do_group_exit+0x28/0x90
> [    6.270852]  get_signal+0x9f1/0xa40
> [    6.271313]  arch_do_signal_or_restart+0x57/0x7b0
> [    6.271771]  ? _raw_spin_unlock+0x10/0x30
> [    6.272223]  ? finish_task_switch.isra.0+0x8e/0x270
> [    6.272674]  ? __switch_to+0x186/0x400
> [    6.273118]  exit_to_user_mode_prepare+0xc8/0x150
> [    6.273564]  irqentry_exit_to_user_mode+0x5/0x20
> [    6.274003]  asm_exc_invalid_op+0x16/0x20
> [    6.274441] RIP: 0033:0x5855d1
> [    6.274877] Code: f6 48 89 ef e8 90 79 03 00 48 c7 05 cd 2e 0c 00 01 00 00 00 48 89 2d 26 a2 0c 00 4c 8d 74 24 20 4c 8d 6c 24 40 4c 8d 64 24 18 <c5> f9 ef c0 48 b8 f6 75 ae 03 01 00 00 00 4c 8d 3d 8c 02 0a 00 c5
> [    6.275776] RSP: 002b:00007ffe5ceddeb0 EFLAGS: 00010202
> [    6.276221] RAX: 0000000000000000 RBX: 00000000004006c8 RCX: 0000000000000001
> [    6.276670] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000648400
> [    6.277116] RBP: 00000000009e0060 R08: 00007ffe5cfdf178 R09: 00000000effffef5
> [    6.277561] R10: 0000000070000022 R11: 0000000000000032 R12: 00007ffe5ceddec8
> [    6.278003] R13: 00007ffe5ceddef0 R14: 00007ffe5cedded0 R15: 000000006ffffeff
> [    6.278442]  </TASK>
> [    6.278903] Kernel Offset: disabled
> 
> I try to decode it :
> 
> All code
> ========
>    0:   f6 48 89 ef             testb  $0xef,-0x77(%rax)
>    4:   e8 90 79 03 00          call   0x37999
>    9:   48 c7 05 cd 2e 0c 00    movq   $0x1,0xc2ecd(%rip)        # 0xc2ee1
>   10:   01 00 00 00 
>   14:   48 89 2d 26 a2 0c 00    mov    %rbp,0xca226(%rip)        # 0xca241
>   1b:   4c 8d 74 24 20          lea    0x20(%rsp),%r14
>   20:   4c 8d 6c 24 40          lea    0x40(%rsp),%r13
>   25:   4c 8d 64 24 18          lea    0x18(%rsp),%r12
>   2a:*  c5 f9 ef c0             vpxor  %xmm0,%xmm0,%xmm0                <-- trapping instruction
>   2e:   48 b8 f6 75 ae 03 01    movabs $0x103ae75f6,%rax
>   35:   00 00 00 
>   38:   4c 8d 3d 8c 02 0a 00    lea    0xa028c(%rip),%r15        # 0xa02cb
>   3f:   c5                      .byte 0xc5
> 
> Code starting with the faulting instruction
> ===========================================
>    0:   c5 f9 ef c0             vpxor  %xmm0,%xmm0,%xmm0
>    4:   48 b8 f6 75 ae 03 01    movabs $0x103ae75f6,%rax
>    b:   00 00 00 
>    e:   4c 8d 3d 8c 02 0a 00    lea    0xa028c(%rip),%r15        # 0xa02a1
>   15:   c5                      .byte 0xc5
> 
> Regards,
> Denis
> PS:
>    denis@srv2 ~ $ gcc --version
>    gcc (Gentoo 11.3.0 p4) 11.3.0

See the ticket for more details.

BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:

#regzbot introduced: v5.18..v5.19
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 11:12:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 11:12:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423821.670833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok1ZI-0002ft-OU; Sun, 16 Oct 2022 11:12:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423821.670833; Sun, 16 Oct 2022 11:12:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok1ZI-0002fm-L6; Sun, 16 Oct 2022 11:12:32 +0000
Received: by outflank-mailman (input) for mailman id 423821;
 Sun, 16 Oct 2022 11:12:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1ZH-0002fc-Og; Sun, 16 Oct 2022 11:12:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1ZH-0004fO-LH; Sun, 16 Oct 2022 11:12:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1ZH-00056H-7p; Sun, 16 Oct 2022 11:12:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1ZH-0008JW-7I; Sun, 16 Oct 2022 11:12:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4mZ+TA/rHaCSRGDCDgYi8JGP5s2bTNJoEpIKJwtzis8=; b=oRdeNfsk3S/UjTuI/j8AyjiK3z
	Ic9TxMNzi9NiipQ/uyxIC+ZBAAvmD7em+zCvsSqp/a12p6ndCJym+DrnJ7IXw+33DEgSJaSPhS8s7
	Ltimy2kCl/Waz117TgAxJf3bw6gA2edlDaS8APpPjHw8yDj/464OVNzY0YY9lk1imMO8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173806-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173806: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1d0da8674c23e8d65398c33a4d5018eaf02e1c64
X-Osstest-Versions-That:
    linux=6e150d605c9e21dbe939875c13e82da33fb59ed0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 11:12:31 +0000

flight 173806 linux-5.4 real [real]
flight 173918 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/173806/
http://logs.test-lab.xenproject.org/osstest/logs/173918/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail in 173918 REGR. vs. 173461

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-qcow2 13 guest-start       fail pass in 173918-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173461

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 173918 like 173461
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 173918 never pass
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat    fail like 173461
 test-armhf-armhf-xl-credit1  14 guest-start                  fail  like 173461
 test-armhf-armhf-xl-credit2  18 guest-start/debian.repeat    fail  like 173461
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173461
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173461
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173461
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173461
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173461
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173461
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173461
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173461
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173461
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173461
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173461
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1d0da8674c23e8d65398c33a4d5018eaf02e1c64
baseline version:
 linux                6e150d605c9e21dbe939875c13e82da33fb59ed0

Last test of basis   173461  2022-10-07 17:40:12 Z    8 days
Testing same since   173806  2022-10-15 06:14:51 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
  Alexey Dobriyan <adobriyan@gmail.com>
  Andrew Chernyakov <acherniakov@astralinux.ru>
  Andrew Morton <akpm@linux-foundation.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Brian Norris <briannorris@chromium.org>
  Cameron Gutman <aicommander@gmail.com>
  ChanWoo Lee <cw9316.lee@samsung.com>
  Cleber de Mattos Casali <clebercasali@gmail.com>
  Cristian Marussi <cristian.marussi@arm.com>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Haimin Zhang <tcs.kernel@gmail.com>
  Haimin Zhang <tcs_kernel@tencent.com>
  Hu Weiwen <sehuww@mail.scut.edu.cn>
  Ilya Dryomov <idryomov@gmail.com>
  Jann Horn <jannh@google.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jasper Poppe <jgpoppe@gmail.com>
  Jeremy Palmer <jpalmer@linz.govt.nz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kyle Gospodnetich <me@kylegospodneti.ch>
  Letu Ren <fantasquex@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lukas Straub <lukasstraub2@web.de>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mimi Zohar <zohar@linux.ibm.com>
  Namhyung Kim <namhyung@kernel.org>
  Orlando Chamberlain <redecorating@protonmail.com>
  Paul Webb <paul.x.webb@oracle.com>
  Pavel Rojtberg <rojtberg@gmail.com>
  Randy Dunlap <rdunlap@infradead.org> # build-tested
  Richard Weinberger <richard@nod.at>
  Ruineka <ruinairas1992@gmail.com>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Samuel Jiang <chyishian.jiang@gmail.com>
  Sasha Levin <sashal@kernel.org>
  Saurav Kashyap <skashyap@marvell.com>
  Sergei Antonov <saproj@gmail.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Soenke Huster <shuster@seemoo.tu-darmstadt.de>
  Steven Price <steven.price@arm.com>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Swati Agarwal <swati.agarwal@xilinx.com>
  Sönke Huster <shuster@seemoo.tu-darmstadt.de>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Ulf Hansson <ulf.hansson@linaro.org>
  Vinod Koul <vkoul@kernel.org>
  Wende Tan <twd2.me@gmail.com>
  Xiubo Li <xiubli@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1099 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 11:13:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 11:13:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423827.670844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok1Zm-0003Ei-7o; Sun, 16 Oct 2022 11:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423827.670844; Sun, 16 Oct 2022 11:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok1Zm-0003Eb-3u; Sun, 16 Oct 2022 11:13:02 +0000
Received: by outflank-mailman (input) for mailman id 423827;
 Sun, 16 Oct 2022 11:13:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1Zl-0003EP-C3; Sun, 16 Oct 2022 11:13:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1Zl-0004fl-B7; Sun, 16 Oct 2022 11:13:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1Zl-0005Aj-3x; Sun, 16 Oct 2022 11:13:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ok1Zl-0000it-3V; Sun, 16 Oct 2022 11:13:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3SaE7WJb4cgLGjl5fD6t4QX5JDGtcfscF8K+pmXke20=; b=YI6NKpSye02k0kq0Qo9PhAfDoV
	XsJSabgBpy9NCceFv3Y6XwxC4tBQPIozyEy5e+p/tKaBQEEnEc6ocSNJGwD5041KmZvRB/U2am0Y4
	P8A0VOC7eennKMpyYlxbO0EXHulVQFMf1TAmVE/e4iH3YXX6yHV14t10USqbcdtCXaEk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173911-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173911: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 11:13:01 +0000

flight 173911 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173911/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    8 days
Failing since        173492  2022-10-11 13:01:50 Z    4 days   30 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 14:51:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 14:51:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423855.670891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok4yX-0007dD-44; Sun, 16 Oct 2022 14:50:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423855.670891; Sun, 16 Oct 2022 14:50:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok4yX-0007d6-1J; Sun, 16 Oct 2022 14:50:49 +0000
Received: by outflank-mailman (input) for mailman id 423855;
 Sun, 16 Oct 2022 14:50:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok4yV-0007cw-Mz; Sun, 16 Oct 2022 14:50:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok4yV-0008I9-KX; Sun, 16 Oct 2022 14:50:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok4yV-0002Pt-8X; Sun, 16 Oct 2022 14:50:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ok4yV-0003Wr-82; Sun, 16 Oct 2022 14:50:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Y+HxuglfIGdlPV6PXMOmtyNGAgDJiNCJwhU/MtRVuW4=; b=xq8N2o+T4F8gF9NvX6pYnujB0H
	YpgSVMvI3BfqWn+3CnKMPK+OpSE8n2X6AwDXlHqK64mXVa87FWEsh2ElmB4stENIU3Zf6hnkz+c7q
	AYWqMPXQP5NkBW3jJkQ7gkEtmOYEkDqjfOlNa/6bWedYbD+zluzHJ8dOGx1knF8LdXIc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173925-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173925: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 14:50:47 +0000

flight 173925 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173925/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173911

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173911 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173911 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   31 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 15:40:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 15:40:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423867.670914 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok5k1-0003fF-V6; Sun, 16 Oct 2022 15:39:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423867.670914; Sun, 16 Oct 2022 15:39:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok5k1-0003f8-SU; Sun, 16 Oct 2022 15:39:53 +0000
Received: by outflank-mailman (input) for mailman id 423867;
 Sun, 16 Oct 2022 15:39:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok5k0-0003ey-AB; Sun, 16 Oct 2022 15:39:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok5k0-0000gN-6n; Sun, 16 Oct 2022 15:39:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok5jz-0005jL-P9; Sun, 16 Oct 2022 15:39:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ok5jz-0000Cu-Og; Sun, 16 Oct 2022 15:39:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a/JwsOBSQ6NBbGQZj+yEBcicosh+K2yYrAho5KweZEY=; b=KCb4RUQxXlqX9NLBPNPP2k7A2H
	01Tvy8seAKqJWsewzDc5x/I+67djTAlxlT6q1MSUrTFtkLvFkf1d63mx46Wwro7M7c0X+teTio4pR
	CbnV6dF9aJJ0JjuvWcMlvkS1KcsO9dg33fspMmTwydpnX/CU+WCaZVrR3Hn1yiG7Ns+8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173814-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173814: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:build-arm64-pvops:kernel-build:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 15:39:51 +0000

flight 173814 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173814/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 172549
 test-arm64-arm64-xl-xsm      14 guest-start    fail in 173735 REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start    fail in 173735 REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start    fail in 173735 REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 173735

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl         15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173735 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   62 days
Failing since        173495  2022-10-11 14:08:01 Z    5 days    6 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    3 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 17:48:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 17:48:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423885.670954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok7kB-0008Q7-Ub; Sun, 16 Oct 2022 17:48:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423885.670954; Sun, 16 Oct 2022 17:48:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok7kB-0008Q0-Rz; Sun, 16 Oct 2022 17:48:11 +0000
Received: by outflank-mailman (input) for mailman id 423885;
 Sun, 16 Oct 2022 17:48:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ok7k9-0008Pu-RS
 for xen-devel@lists.xenproject.org; Sun, 16 Oct 2022 17:48:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ok7k2-0003KP-Pk; Sun, 16 Oct 2022 17:48:02 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.141])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ok7k2-0002PU-Hd; Sun, 16 Oct 2022 17:48:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mXglPGHiPe5q3CHx27YFdei2t2Cv9ep68EGI7/Nw+zQ=; b=Ea8+iCd9f1V/VxiUYrfaPkYw1x
	U+GwNCEagFGhBRCy294gY06ayqPNKvvQvchxC/H9wGQ1zeRnk17wKUj5Ioh9Vdwuh2w7gmFOUyhev
	i87S73CNwfeYrPEF79HNTHLtHwIuAXb2jF5Z6fHTvTkzZI0fdk49LKoARw1EqqogDnxc=;
Message-ID: <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
Date: Sun, 16 Oct 2022 18:47:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Peter Maydell <peter.maydell@linaro.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221015050750.4185-11-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

There seem to be some missing patches on xen-devel (including the cover 
letter). Is that expected?

On 15/10/2022 06:07, Vikram Garhwal wrote:
> Add a new machine xenpv which creates a IOREQ server to register/connect with
> Xen Hypervisor.

I don't like the name 'xenpv' because it doesn't convey the fact that 
some of the HW may be emulated rather than para-virtualized. In fact one 
may only want to use for emulating devices.

Potential name would be 'xen-arm' or re-using 'virt' but with 
'accel=xen' to select a Xen layout.

> 
> Xen IOREQ connection expect the TARGET_PAGE_SIZE to 4096, and the xenpv machine
> on ARM will have no CPU definitions. We need to define TARGET_PAGE_SIZE
> appropriately ourselves.
> 
> Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a
> TPM emulator and connects to swtpm running on host machine via chardev socket
> and support TPM functionalities for a guest domain.
> 
> Extra command line for aarch64 xenpv QEMU to connect to swtpm:
>      -chardev socket,id=chrtpm,path=/tmp/myvtpm2/swtpm-sock \
>      -tpmdev emulator,id=tpm0,chardev=chrtpm \
> 
> swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on libtpms and
> provides access to TPM functionality over socket, chardev and CUSE interface.
> Github repo: https://github.com/stefanberger/swtpm
> Example for starting swtpm on host machine:
>      mkdir /tmp/vtpm2
>      swtpm socket --tpmstate dir=/tmp/vtpm2 \
>      --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock &

I see patches for QEMU but not Xen. How can this be tested with existing 
Xen? Will libxl ever create QEMU?

[...]

> +static int xen_init_ioreq(XenIOState *state, unsigned int max_cpus)
> +{
> +    xen_dmod = xendevicemodel_open(0, 0);
> +    xen_xc = xc_interface_open(0, 0, 0);
> +
> +    if (xen_xc == NULL) {

You are checking xen_xc but not xen_dmod. Why?

> +        perror("xen: can't open xen interface\n");
> +        return -1;
> +    }
> +
> +    xen_fmem = xenforeignmemory_open(0, 0);
> +    if (xen_fmem == NULL) {
> +        perror("xen: can't open xen fmem interface\n");
> +        xc_interface_close(xen_xc);
> +        return -1;
> +    }
> +
> +    xen_register_ioreq(state, max_cpus, xen_memory_listener);
> +
> +    xenstore_record_dm_state(xenstore, "running");
> +
> +    return 0;
> +}
> +
> +static void xen_enable_tpm(void)
> +{
> +/* qemu_find_tpm_be is only available when CONFIG_TPM is enabled. */
> +#ifdef CONFIG_TPM
> +    Error *errp = NULL;
> +    DeviceState *dev;
> +    SysBusDevice *busdev;
> +
> +    TPMBackend *be = qemu_find_tpm_be("tpm0");
> +    if (be == NULL) {
> +        DPRINTF("Couldn't fine the backend for tpm0\n");
> +        return;
> +    }
> +    dev = qdev_new(TYPE_TPM_TIS_SYSBUS);
> +    object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp);
> +    object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
> +    busdev = SYS_BUS_DEVICE(dev);
> +    sysbus_realize_and_unref(busdev, &error_fatal);
> +    sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);

I can't find where GUEST_TPM_BASE is defined. But then the guest memory 
layout is not expected to be stable. With your current approach, it 
means QEMU would need to be rebuilt for every Xen version. Is it what we 
want?

> +
> +    DPRINTF("Connected tpmdev at address 0x%lx\n", GUEST_TPM_BASE);
> +#endif
> +}
> +
> +static void xen_arm_init(MachineState *machine)
> +{
> +    XenArmState *xam = XEN_ARM(machine);
> +
> +    xam->state =  g_new0(XenIOState, 1);
> +
> +    if (xen_init_ioreq(xam->state, machine->smp.cpus)) {
> +        return;

In another patch, you said the IOREQ would be optional. IHMO, I think 
this is a bad idea to register it by default because one may only want 
to use PV drivers. Registering IOREQ will add unnecessary overhead in Xen.

Furthermore, it means that someone selecting TPM but Xen is not built 
with CONFIG_IOREQ=y (BTW This is still a tech preview but there are 
security holes on Arm...) will not get an error. Instead, the OS will 
until it crashes when trying to access the TPM.

Overall I think it would be better if IOREQ is only registered when a 
device requires (like TPM) it *and* throw an error if there is a problem 
during the initialization.

> +    } > +
> +    xen_enable_tpm();
> +
> +    return;
> +}
> +
> +static void xen_arm_machine_class_init(ObjectClass *oc, void *data)
> +{
> +
> +    MachineClass *mc = MACHINE_CLASS(oc);
> +    mc->desc = "Xen Para-virtualized PC";
> +    mc->init = xen_arm_init;
> +    mc->max_cpus = 1;
> +    machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);

Shouldn't this be protected with #ifdef CONFIG_TPM?

> +}
> +
> +static const TypeInfo xen_arm_machine_type = {
> +    .name = TYPE_XEN_ARM,
> +    .parent = TYPE_MACHINE,
> +    .class_init = xen_arm_machine_class_init,
> +    .instance_size = sizeof(XenArmState),
> +};
> +
> +static void xen_arm_machine_register_types(void)
> +{
> +    type_register_static(&xen_arm_machine_type);
> +}
> +
> +type_init(xen_arm_machine_register_types)
> diff --git a/include/hw/arm/xen_arch_hvm.h b/include/hw/arm/xen_arch_hvm.h
> new file mode 100644
> index 0000000000..f645dfec28
> --- /dev/null
> +++ b/include/hw/arm/xen_arch_hvm.h
> @@ -0,0 +1,12 @@
> +#ifndef HW_XEN_ARCH_ARM_HVM_H
> +#define HW_XEN_ARCH_ARM_HVM_H
> +
> +#include <xen/hvm/ioreq.h>
> +void arch_handle_ioreq(XenIOState *state, ioreq_t *req);
> +void arch_xen_set_memory(XenIOState *state,
> +                         MemoryRegionSection *section,
> +                         bool add);
> +
> +#undef TARGET_PAGE_SIZE

I am a bit puzzled with this #undef. In the commit message you said that 
there will be no CPU definition. So the implications is this should not 
be defined.

If it is defined, then what guarantees that all the source will use the 
correct value?


> +#define TARGET_PAGE_SIZE 4096

It would be better to use XC_PAGE_SIZE (or similar) rather than 
hardcoding it.

> +#endif
> diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h
> index 26674648d8..c7c515220d 100644
> --- a/include/hw/xen/arch_hvm.h
> +++ b/include/hw/xen/arch_hvm.h
> @@ -1,3 +1,5 @@
>   #if defined(TARGET_I386) || defined(TARGET_X86_64)
>   #include "hw/i386/xen_arch_hvm.h"
> +#elif defined(TARGET_ARM) || defined(TARGET_ARM_64)
> +#include "hw/arm/xen_arch_hvm.h"
>   #endif

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 17:51:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 17:51:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423892.670966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok7mv-0001PA-Gk; Sun, 16 Oct 2022 17:51:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423892.670966; Sun, 16 Oct 2022 17:51:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok7mv-0001P3-CN; Sun, 16 Oct 2022 17:51:01 +0000
Received: by outflank-mailman (input) for mailman id 423892;
 Sun, 16 Oct 2022 17:51:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok7mu-0001Or-QP; Sun, 16 Oct 2022 17:51:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok7mu-0003Ma-PY; Sun, 16 Oct 2022 17:51:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ok7mu-0005kU-I7; Sun, 16 Oct 2022 17:51:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ok7mu-000864-Hg; Sun, 16 Oct 2022 17:51:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3STeXF6aoAQxk/VHcsvOFx/dnGS9UN7tyPDtaTxmbWA=; b=XViy2J4BW8yAIWQV3pzP7tQovQ
	qQclOnhijOmuP3RCW04aPyj0fQVCznJKpnQ62Q4EPxu8/Pf/oPD3uUVDtVjwslv8Gb8f+9Maev0jW
	waZnV8N5FmCkcxxNSmMOjlPdTqcB+2DQHYZeDDPrBmdxdSAtga/VQ847yq+oiQ5+E/x8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173931-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173931: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 17:51:00 +0000

flight 173931 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173931/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173911

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173911 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173911 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   32 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    1 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 17:53:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 17:53:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423900.670976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok7p8-000219-TF; Sun, 16 Oct 2022 17:53:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423900.670976; Sun, 16 Oct 2022 17:53:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok7p8-000212-Qh; Sun, 16 Oct 2022 17:53:18 +0000
Received: by outflank-mailman (input) for mailman id 423900;
 Sun, 16 Oct 2022 17:53:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ok7p7-00020w-IJ
 for xen-devel@lists.xenproject.org; Sun, 16 Oct 2022 17:53:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ok7p3-0003Px-Rp; Sun, 16 Oct 2022 17:53:13 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.141])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ok7p3-00030k-Ky; Sun, 16 Oct 2022 17:53:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=UDBmlnzgtdCje0DtWepmdbJUxUQTxMSyPzW8sUlZpIU=; b=KkiiteRmmJp0iKe7sVImkRwXxS
	jiPYGq9v0/po9gtZsFiWhhtk3Pb8bmJFrwRx96Jdj6/USdVkfGbcxXONm1MAhp//Oos4GvolPnxN4
	F9AqTqXWM9+rfzVPNdXbg4N2uTGUfh9ptzBnNPRfEv46EOgQcLcV9e8l6D9VXjepSLz4=;
Message-ID: <78881214-c8a1-0156-e279-6c2598348a87@xen.org>
Date: Sun, 16 Oct 2022 18:53:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v1 07/12] include/hw/xen/xen_common: return error from
 xen_create_ioreq_server
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-8-vikram.garhwal@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221015050750.4185-8-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 15/10/2022 06:07, Vikram Garhwal wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> This is done to prepare for enabling xenpv support for ARM architecture.
> On ARM it is possible to have a functioning xenpv machine with only the
> PV backends and no IOREQ server. If the IOREQ server creation fails,
> continue to the PV backends initialization.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
>   include/hw/xen/xen_common.h | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
> index 77ce17d8a4..c2d2f36bde 100644
> --- a/include/hw/xen/xen_common.h
> +++ b/include/hw/xen/xen_common.h
> @@ -467,8 +467,8 @@ static inline void xen_unmap_pcidev(domid_t dom,
>   {
>   }
>   
> -static inline void xen_create_ioreq_server(domid_t dom,
> -                                           ioservid_t *ioservid)
> +static inline int xen_create_ioreq_server(domid_t dom,
> +                                          ioservid_t *ioservid)
>   {

I think there is a return missing here.

>   }
>   
> @@ -600,8 +600,8 @@ static inline void xen_unmap_pcidev(domid_t dom,
>                                                     PCI_FUNC(pci_dev->devfn));
>   }
>   
> -static inline void xen_create_ioreq_server(domid_t dom,
> -                                           ioservid_t *ioservid)
> +static inline int xen_create_ioreq_server(domid_t dom,
> +                                          ioservid_t *ioservid)
>   {
>       int rc = xendevicemodel_create_ioreq_server(xen_dmod, dom,
>                                                   HVM_IOREQSRV_BUFIOREQ_ATOMIC,
> @@ -609,12 +609,14 @@ static inline void xen_create_ioreq_server(domid_t dom,
>   
>       if (rc == 0) {
>           trace_xen_ioreq_server_create(*ioservid);
> -        return;
> +        return rc;
>       }
>   
>       *ioservid = 0;
>       use_default_ioreq_server = true;
>       trace_xen_default_ioreq_server();
> +
> +    return rc;
>   }
>   
>   static inline void xen_destroy_ioreq_server(domid_t dom,

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 18:08:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 18:08:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423908.670993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok83H-0003hr-7Z; Sun, 16 Oct 2022 18:07:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423908.670993; Sun, 16 Oct 2022 18:07:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ok83H-0003hk-56; Sun, 16 Oct 2022 18:07:55 +0000
Received: by outflank-mailman (input) for mailman id 423908;
 Sun, 16 Oct 2022 18:07:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ok83G-0003he-0x
 for xen-devel@lists.xenproject.org; Sun, 16 Oct 2022 18:07:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ok839-0003kh-GA; Sun, 16 Oct 2022 18:07:47 +0000
Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.141])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ok839-0003qH-9L; Sun, 16 Oct 2022 18:07:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=CuGOnrDMtV5vDQ/7F1e9NAArcg8H+cC0WxXQP5snmQs=; b=wlR1SUifYbJbzN0B+SnCKsa/jD
	IFHUcR1/0r26ctoxccVcK3/juFMuqM32llxWh/hgPFD3eKVPtVxXH9+Vx3S45DQkyUO65rsXIWP8x
	PNCwMLXk9ORoZ6A6uaPTjSJbkoWUnVNp8aahibDNBecoz/FYfotN6aEv79yzaD49AxhE=;
Message-ID: <31c4102e-372e-85f9-301e-7fdc18b29bd7@xen.org>
Date: Sun, 16 Oct 2022 19:07:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to
 hw/xen/xen-hvm-common.c
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-7-vikram.garhwal@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221015050750.4185-7-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 15/10/2022 06:07, Vikram Garhwal wrote:
> +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
> +                        MemoryListener xen_memory_listener)
> +{


[...]

> +
> +    xen_bus_init();
> +
> +    /* Initialize backend core & drivers */
> +    if (xen_be_init() != 0) {
> +        error_report("xen backend core setup failed");
> +        goto err;
> +    }
> +    xen_be_register_common();

Calling xen_be_init() and xen_be_register_common() from 
xen_register_ioreq() sounds wrong to me. There are no dependency between 
the two. I think it would be better to create a new function to register 
backends.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 16 21:15:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 16 Oct 2022 21:15:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423944.671059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okAyf-0005Hh-C9; Sun, 16 Oct 2022 21:15:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423944.671059; Sun, 16 Oct 2022 21:15:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okAyf-0005Ha-9Q; Sun, 16 Oct 2022 21:15:21 +0000
Received: by outflank-mailman (input) for mailman id 423944;
 Sun, 16 Oct 2022 21:15:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okAye-0005HQ-32; Sun, 16 Oct 2022 21:15:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okAye-0006uE-25; Sun, 16 Oct 2022 21:15:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okAyd-0001OG-OJ; Sun, 16 Oct 2022 21:15:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okAyd-0000Ec-Nk; Sun, 16 Oct 2022 21:15:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tQAo4L4hVOYkKKpkKFSsOBodAPd8OQ31bY7JmHjBlHY=; b=VuhNs4HwiImAM7E/eM71OVrk4m
	ruV5/IqzxvEgIymEPlw5pKm04twbdijGOmWsCPNLjTeGUW2W97NI+U90Dja0j3kyn14Cyc9NtUi3/
	xFWF1fObunqOGEo5nPTLygFJjiaEUNDtraoKHmkW5WGM0mibjk2GvvmnJHpEUAmQKYss=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173940-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173940: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 16 Oct 2022 21:15:19 +0000

flight 173940 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173940/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173911

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173911 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173911 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   33 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    2 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 00:07:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 00:07:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423982.671160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okDfG-0005k4-AJ; Mon, 17 Oct 2022 00:07:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423982.671160; Mon, 17 Oct 2022 00:07:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okDfG-0005jx-6Y; Mon, 17 Oct 2022 00:07:30 +0000
Received: by outflank-mailman (input) for mailman id 423982;
 Mon, 17 Oct 2022 00:07:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okDfE-0005jn-Td; Mon, 17 Oct 2022 00:07:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okDfE-0001v7-M8; Mon, 17 Oct 2022 00:07:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okDfE-0006uN-Bq; Mon, 17 Oct 2022 00:07:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okDfE-0005P9-BL; Mon, 17 Oct 2022 00:07:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RxKrK+uFNdEi203rPIsLIDXjyXzbubz6o9gVLCT/q9s=; b=cspjsv6fA6yuBAhA1KIr/WKDHu
	8P53TtHMTjjpBShJsFKuirlMWT5V4GbAbUG6p+191+wnmWuswQ+aILP+ZC+5m22B77S07RqmNKz4b
	Zp8vsL8hUTgsE7usw4U+ymqO/bB8CxQZPWvL0FY95fNaGfaYaSzIosmhnJxVwARYwmjI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173849-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173849: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    qemuu=2ba341b3694cf3cff7b8a1df4cc765900d5c4f60
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 00:07:28 +0000

flight 173849 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173849/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-vhd      21 guest-start/debian.repeat fail REGR. vs. 173447

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail in 173792 pass in 173849
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 173792 pass in 173849
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat  fail pass in 173792

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-xl-seattle   3 hosts-allocate           starved in 173792 n/a

version targeted for testing:
 qemuu                2ba341b3694cf3cff7b8a1df4cc765900d5c4f60
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z   10 days
Failing since        173497  2022-10-11 15:38:33 Z    5 days    6 attempts
Testing same since   173792  2022-10-15 03:18:02 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akihiko Odaki <akihiko.odaki@daynix.com>
  Alberto Faria <afaria@redhat.com>
  Alex Bennée <alex.bennee@linaro.org>
  Alexander Graf <agraf@csgraf.de>
  Ani Sinha <ani@anisinha.ca>
  Bin Meng <bin.meng@windriver.com>
  Bryce Mills <brycemills@proton.me>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniil Tatianin <d-tatianin@yandex-team.ru>
  David Hildenbrand <david@redhat.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dongwon Kim <dongwon.kim@intel.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Eric Auger <eric.auger@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Hal Martin <hal.martin@gmail.com>
  Helge Konetzka <hk@zapateado.de>
  Igor Mammedov <imammedo@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Jerome Forissier <jerome.forissier@linaro.org>
  Joel Stanley <joel@jms.id.au>
  John Millikin <john@john-millikin.com>
  Jonah Palmer <jonah.palmer@oracle.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Juan Quintela <quintela@redhat.com>
  Kevin Wolf <kwolf@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  lu zhipeng <luzhipeng@cestc.cn>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Michael Labiuk <michael.labiuk@virtuozzo.com>
  Michael S. Tsirkin <mst@redhat.com>
  Miguel Luis <miguel.luis@oracle.com>
  Pankaj Gupta <pankaj.gupta@amd.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Sebastian Mitterle <smitterl@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Volker Rümelin <vr_qemu@t-online.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 4908 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 00:23:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 00:23:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.423991.671170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okDv4-00088e-QZ; Mon, 17 Oct 2022 00:23:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 423991.671170; Mon, 17 Oct 2022 00:23:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okDv4-00088X-O0; Mon, 17 Oct 2022 00:23:50 +0000
Received: by outflank-mailman (input) for mailman id 423991;
 Mon, 17 Oct 2022 00:23:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2Yn=2S=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1okDv3-00088R-4c
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 00:23:49 +0000
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f4cce49f-4db1-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 02:23:46 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 58A5732000E5;
 Sun, 16 Oct 2022 20:23:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sun, 16 Oct 2022 20:23:41 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 16 Oct 2022 20:23:39 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4cce49f-4db1-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1665966220; x=
	1666052620; bh=ZIUfdLEJM0ESSCfpLb2R/9KS4n4WMO0lvEA3/NHP6A8=; b=T
	hYdeYXKl560bjMe3OlyucaVWmv/AjIGzk4nkOTXEmwX8LK47QAvg1q7VsMu3oVPG
	1dG9xwZCpCbfm9MPZ5ug0p41OPKOnWDOqc6o+qZVOfbO/woQyVOx5Z6QzKO0ipX0
	qQZ8+bo0V5O8GbHbAcM0I2m+cBp8Ne7FoAXZ1Dm+FpIDonoRJ++7jdPQ+watgM9w
	F1W/ZWcIPXoNhrBFDHd+1eat1KDXCAxDCZWa008F5atJopgjh3qBda6Fi+7si1ly
	lEJhqh+CopaNdnyoVy5ngOEMKLZfP+3Z3Z9giaW2WoHwYulQ9A6VXwex9NZQhImv
	thW9R3PBviY0LqPwcfI+A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1665966220; x=1666052620; bh=ZIUfdLEJM0ESSCfpLb2R/9KS4n4W
	MO0lvEA3/NHP6A8=; b=Ro0CozzNteOPB+Mq8IJ+ZTYksRC3E2G+n6a6PMxe4uSO
	KfQXUJ6V4WuTrPBbZsoHwOK7g+JvaE/18u3CTtqH3iufAPgCkB7G3eIlKiIdOu9G
	4gO1aOW1gMfUzZDMHGQ5S4U65otiychfYTsDfS9hY57C1yfLyQ6z+cs61otqAXPF
	GDO4YPIrtDDPtDxmWZxvUqQduSUf4g+jJWRDncnrlVWYWz7P/rnAu/3SPThX7HWw
	VIBOjD+BZD9YPF9cfMIBifB4eASZIO2q7P3WT6BVFpxSM8gW9rXZ/PTcdJ8y0RYb
	EQRc/zERa8HPhfPHeIoBQc5kR9Kgb6OdM7mxQR5JVA==
X-ME-Sender: <xms:jKBMY-6xzOUCJS1IE-LTLb1klukxYROoQ9mtJ7HTdU82P4h_4q6S7Q>
    <xme:jKBMY36yYXN7akIQ8XvO_os_rjvtyoKnzSliZBU6_qEUb16k5WEQpkwrPIou5qGwA
    EoqOcFUw86IEA>
X-ME-Received: <xmr:jKBMY9eLfq7jbZll3ZpX2YUIsAh5aZi3O29bbkJnQKq7sUyJFA9twxNh5FCTR824csfnQdSGtRziPbV7q028Ts72WVQaKY6qe2El>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeekkedgfeeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfff
    vdduieefueeiteeuleefhefhhffhheefvefhleekheevgfeludefuddvgfehnecuffhomh
    grihhnpehorhhgrdgrshdpkhgvrhhnvghlrdhorhhgpdigvghnrdhorhhgnecuvehluhhs
    thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghkse
    hinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:jKBMY7IgnJ4npWQSoElk5FtBjNQLce4vm74SBBY6K7-EotlepdWa0Q>
    <xmx:jKBMYyKcNYrsYdIAUQUYaO_QWrSXmyxVNw6Q1GWedF8c4qkdRDVD0g>
    <xmx:jKBMY8yiWO8Z-XYp8zrhrjgOJ22JfyvyP4E87IG6He_DWDu0SAnO6g>
    <xmx:jKBMY3Hj4a5HlIiejK0FiLP2UfCQgvLU-kBabu-fL2OsA3_om_3lnw>
Feedback-ID: i1568416f:Fastmail
Date: Mon, 17 Oct 2022 02:23:35 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Denis Chancogne <denis.chancogne@free.fr>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	LKML <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Bug 216581 - Kernel panic on /init as busybox symbolic link with
 xen efi
Message-ID: <Y0ygiO3kuazXWSfZ@mail-itl>
References: <e2cf3207-e9e9-5585-1a6e-9b39d96b4b54@leemhuis.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="dkVdQrOLWpDCDP3c"
Content-Disposition: inline
In-Reply-To: <e2cf3207-e9e9-5585-1a6e-9b39d96b4b54@leemhuis.info>


--dkVdQrOLWpDCDP3c
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 17 Oct 2022 02:23:35 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Denis Chancogne <denis.chancogne@free.fr>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	LKML <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Bug 216581 - Kernel panic on /init as busybox symbolic link with
 xen efi

On Sun, Oct 16, 2022 at 01:08:53PM +0200, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker speaking.
>=20
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=3D216581 :
>=20
> >  Denis Chancogne 2022-10-13 22:00:19 UTC
> >=20
> > Created attachment 302995 [details]
> > /proc/cpuinfo, .config
> >=20
> > Hi,
> >=20
> > when I start Xen 4.15.3 in efi with kernel 5.18.19, all works well;
> > but since kernel 5.19, I have a kernel panic on my /init process as
> > busybox symbolic link inside initramfs.
> >=20
> > This is the kernel log :
> > ...
> > [    6.265122] Run /init as init process
> > [    6.266027] traps: init[1] trap invalid opcode ip:5855d1 sp:7ffe5ced=
deb0 error:0 in busybox[401000+1db000]
> > [    6.266553] Kernel panic - not syncing: Attempted to kill init! exit=
code=3D0x00000004
> > [    6.267039] CPU: 3 PID: 1 Comm: init Tainted: G        W         5.1=
9.0-dch #1
> > [    6.267522] Hardware name: Micro-Star International Co., Ltd. MS-7B8=
4/B450M PRO-M2 (MS-7B84), BIOS 2.E0 06/12/2020
> > [    6.268010] Call Trace:
> > [    6.268495]  <TASK>
> > [    6.268974]  dump_stack_lvl+0x45/0x5e
> > [    6.269455]  panic+0x107/0x285
> > [    6.269923]  do_exit.cold+0x15/0x45
> > [    6.270389]  do_group_exit+0x28/0x90
> > [    6.270852]  get_signal+0x9f1/0xa40
> > [    6.271313]  arch_do_signal_or_restart+0x57/0x7b0
> > [    6.271771]  ? _raw_spin_unlock+0x10/0x30
> > [    6.272223]  ? finish_task_switch.isra.0+0x8e/0x270
> > [    6.272674]  ? __switch_to+0x186/0x400
> > [    6.273118]  exit_to_user_mode_prepare+0xc8/0x150
> > [    6.273564]  irqentry_exit_to_user_mode+0x5/0x20
> > [    6.274003]  asm_exc_invalid_op+0x16/0x20
> > [    6.274441] RIP: 0033:0x5855d1
> > [    6.274877] Code: f6 48 89 ef e8 90 79 03 00 48 c7 05 cd 2e 0c 00 01=
 00 00 00 48 89 2d 26 a2 0c 00 4c 8d 74 24 20 4c 8d 6c 24 40 4c 8d 64 24 18=
 <c5> f9 ef c0 48 b8 f6 75 ae 03 01 00 00 00 4c 8d 3d 8c 02 0a 00 c5
> > [    6.275776] RSP: 002b:00007ffe5ceddeb0 EFLAGS: 00010202
> > [    6.276221] RAX: 0000000000000000 RBX: 00000000004006c8 RCX: 0000000=
000000001
> > [    6.276670] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000=
000648400
> > [    6.277116] RBP: 00000000009e0060 R08: 00007ffe5cfdf178 R09: 0000000=
0effffef5
> > [    6.277561] R10: 0000000070000022 R11: 0000000000000032 R12: 00007ff=
e5ceddec8
> > [    6.278003] R13: 00007ffe5ceddef0 R14: 00007ffe5cedded0 R15: 0000000=
06ffffeff
> > [    6.278442]  </TASK>
> > [    6.278903] Kernel Offset: disabled
> >=20
> > I try to decode it :
> >=20
> > All code
> > =3D=3D=3D=3D=3D=3D=3D=3D
> >    0:   f6 48 89 ef             testb  $0xef,-0x77(%rax)
> >    4:   e8 90 79 03 00          call   0x37999
> >    9:   48 c7 05 cd 2e 0c 00    movq   $0x1,0xc2ecd(%rip)        # 0xc2=
ee1
> >   10:   01 00 00 00=20
> >   14:   48 89 2d 26 a2 0c 00    mov    %rbp,0xca226(%rip)        # 0xca=
241
> >   1b:   4c 8d 74 24 20          lea    0x20(%rsp),%r14
> >   20:   4c 8d 6c 24 40          lea    0x40(%rsp),%r13
> >   25:   4c 8d 64 24 18          lea    0x18(%rsp),%r12
> >   2a:*  c5 f9 ef c0             vpxor  %xmm0,%xmm0,%xmm0               =
 <-- trapping instruction
> >   2e:   48 b8 f6 75 ae 03 01    movabs $0x103ae75f6,%rax
> >   35:   00 00 00=20
> >   38:   4c 8d 3d 8c 02 0a 00    lea    0xa028c(%rip),%r15        # 0xa0=
2cb
> >   3f:   c5                      .byte 0xc5
> >=20
> > Code starting with the faulting instruction
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >    0:   c5 f9 ef c0             vpxor  %xmm0,%xmm0,%xmm0
> >    4:   48 b8 f6 75 ae 03 01    movabs $0x103ae75f6,%rax
> >    b:   00 00 00=20
> >    e:   4c 8d 3d 8c 02 0a 00    lea    0xa028c(%rip),%r15        # 0xa0=
2a1
> >   15:   c5                      .byte 0xc5
> >=20
> > Regards,
> > Denis
> > PS:
> >    denis@srv2 ~ $ gcc --version
> >    gcc (Gentoo 11.3.0 p4) 11.3.0
>=20
> See the ticket for more details.

Thanks for forwarding.

This is already fixed on the Xen side: https://xenbits.xen.org/gitweb/?p=3D=
xen.git;a=3Dcommit;h=3Dc3bd0b83ea5b7c0da6542687436042eeea1e7909
The commit is also in 4.15 branch already:
https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D7923ea47e578bca3=
0a6e45951a9da09e827ff028,
to be included in 4.15.4 rather soon.

> BTW, let me use this mail to also add the report to the list of tracked
> regressions to ensure it's doesn't fall through the cracks:
>=20
> #regzbot introduced: v5.18..v5.19
> #regzbot ignore-activity
>=20
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>=20
> P.S.: As the Linux kernel's regression tracker I deal with a lot of
> reports and sometimes miss something important when writing mails like
> this. If that's the case here, don't hesitate to tell me in a public
> reply, it's in everyone's interest to set the public record straight.
>=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--dkVdQrOLWpDCDP3c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNMoIgACgkQ24/THMrX
1yzOPwgAmgb1Jv7o6emM9Sph12uByVIwpSzX34Ssad33eaHD4V2AtdeZoT4ZN321
znX7WcK/ThI+lHkfPGdyKnNHrSNMLL/NXbT25XJ6UKduSPmky633Zb8JbN+lSKIE
kQpFs3FwJ3Oen/78ct0FjhkpCgsIvXNvEz6yXlQ42qn5KBT0R+p4e+XQRMr/WSFu
FyRziMOe4e3zhGbpmZCd2SEKZk5i2EiiqOeF+bI2KS6yyx9HztpTYKn1WdafqjYo
fWdH32ZvSA5K53B1TiWFmB+qbvjsyS97U88cxiFEcQrqK0QNF5dvZEQhtZSac/7y
KTwLUTIY8ad6uBSxPJgFQpW532aIoQ==
=MEPX
-----END PGP SIGNATURE-----

--dkVdQrOLWpDCDP3c--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 01:05:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 01:05:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424004.671200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okEZK-0002Ot-6N; Mon, 17 Oct 2022 01:05:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424004.671200; Mon, 17 Oct 2022 01:05:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okEZK-0002Om-2R; Mon, 17 Oct 2022 01:05:26 +0000
Received: by outflank-mailman (input) for mailman id 424004;
 Mon, 17 Oct 2022 01:05:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okEZI-0002Oc-K8; Mon, 17 Oct 2022 01:05:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okEZI-0001D9-Go; Mon, 17 Oct 2022 01:05:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okEZI-0000Ng-63; Mon, 17 Oct 2022 01:05:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okEZI-0008M6-5W; Mon, 17 Oct 2022 01:05:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dBvijQaRnE/4sWbFasc/V/UvcJMVoFjD9lwbsAoPrEI=; b=FJe3pWapr+sqxmIIduIGqvkFku
	MLkkbOCzOs+vth5I6YMAmWivUIRC65vYHlhqvip7Aar3IVs0zqf50K/qc8NYOC3hjX60T1+j+kl47
	sZPXgSJX/lYTL+XhM5Z/HIFxLYsr5NIEMQcGd597xYFDCXq1mh17aLY6dsbY7buPIvMw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173959-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173959: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 01:05:24 +0000

flight 173959 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173959/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173911

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173911 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173911 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   34 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    2 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 01:20:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 01:20:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424014.671216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okEnk-0004lu-FH; Mon, 17 Oct 2022 01:20:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424014.671216; Mon, 17 Oct 2022 01:20:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okEnk-0004ln-Ch; Mon, 17 Oct 2022 01:20:20 +0000
Received: by outflank-mailman (input) for mailman id 424014;
 Mon, 17 Oct 2022 01:20:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okEni-0004lh-5f
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 01:20:18 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00074.outbound.protection.outlook.com [40.107.0.74])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id da5c3a9b-4db9-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 03:20:14 +0200 (CEST)
Received: from FR0P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::7) by
 PR3PR08MB5721.eurprd08.prod.outlook.com (2603:10a6:102:84::21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.30; Mon, 17 Oct 2022 01:20:11 +0000
Received: from VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:a8:cafe::82) by FR0P281CA0106.outlook.office365.com
 (2603:10a6:d10:a8::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.11 via Frontend
 Transport; Mon, 17 Oct 2022 01:20:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT040.mail.protection.outlook.com (100.127.145.25) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 01:20:11 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Mon, 17 Oct 2022 01:20:10 +0000
Received: from 0d1c0b26cf2d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 48234B8C-CDD0-4712-9908-B17F112A62F8.1; 
 Mon, 17 Oct 2022 01:20:05 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0d1c0b26cf2d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 01:20:05 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB9372.eurprd08.prod.outlook.com (2603:10a6:10:422::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 01:20:02 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.032; Mon, 17 Oct 2022
 01:20:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da5c3a9b-4db9-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=i32NPsmMmKHrqxffGg+mQz++eczoGC9qoNWd50hEjTU8G8zh5O/Atk3rv2bn5DgE4AD74LmkQYA9tcbwEg3WqiZjR0ABcie+jVq7wlg90ifOBVzVxxJ91NSS91s0rSaWzJ7yoe0KSvs7nslOBgHVxMZYIZAj3Rrbe1iJ4dj0WeXWD2eXWlRxdvB50FtbN4PQFYLbLgdePl3XUyyTCc/YKFTVRK973zCC4I+RRpTNCnQOOS5jp5JeF1of2n2q7QE6FUQPln1Uo8+7YJghuEcDgCR2N2LXWkBDmQwl51Qy3lIdee1tFtzJLAb5giNGH4hg63cm7SMlLRyhbpg2BJx0qQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uMVfwCMTa6hADqBJ7X+oJkbnQ7zM2WKTFKjj92Cu6tc=;
 b=LWzqBIsOPDDZePNUn5HTjfHtML8HrfSivdfcOQf/u7wCbnAD0o/mb8qEWx0DGo4yeYytub4Xm+Jvhd7ADnqnHyT3mnckTD+e3/ND1H2VdvMlzHhErsBhp14jvsdU+9R6g8axKFji+nB0OUsakRgwHQ6RXDpVgc0QtchQ+ObhjkCuNZNqoAAbxgoM7URiI/PCgOXUun2/p6uo7ss+WEVwEUcMqbbDAFvAI0YbmZuX7oPut83YhKu9uMy9HUKE2VuqpbJXRM9gfL6vh7PcaYA/Jc+JHxeBPLS4MTrSMw/MmbryowYPTQeEvhQEE76hOjOuzdMux9+pIX8udH0QNktLlA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uMVfwCMTa6hADqBJ7X+oJkbnQ7zM2WKTFKjj92Cu6tc=;
 b=Nj8zZeoX9Bf1QYwiw8VHOtA0vXIYYIs7ctWg9P0h8v9HXVLEengQvigN/aeXVGc+q6tbAgPSoOBvHdrn5gJkyj5mNcTFp82AcroN1EJUG3LDSLum6JGBZK6neP8uwv1SFoIOfXDgLLVjqRuuWq3DlZ9T3FL/h31PZYMRAB0MCek=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MmdHk7w/Xf/M9guvDXd2HRjAmuQufzANxQbdjyxgNd1R9ylm55sPggjQtMFZKK81QAnkqU2wQkRJNT2AEOhH7wPuOhzJ4IWAnYM3ViTRQXsBv+qXaHsLH1JPq9i68svZZWImGz7ivfSHdklBY8iE9X22g1Z39wA2uo2K1B4zbAqJcilkhmbmZpHHP4oDW6LM4d/Dj9RcFrMx76IQuQRktJ+1w6Ry/oh6PmDkgCcaocP6vMpG2WUkgHPrnZDiFmnzn4yixnfklTdTiPeI0dewFpD9f6Kdh3ZQVdbPDizrOQwGLmWDRZsoAi3E8ulnQdqr3fhriK02jeHt7yrVGyf6Fw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uMVfwCMTa6hADqBJ7X+oJkbnQ7zM2WKTFKjj92Cu6tc=;
 b=XAhxGR/j6vUsX+SWOpWFXaSMtlMSX/ZFVqf9x4Bu44TbOxBXPw7lN2C6sVU+lTCN4alRaGz33Xh7VuY4eYcO23d6H4mEkw3IoZNRyr9bim32dmnGoeoAqgM9KHX4xMPzv/B9aQnHt1yfxxX2g2FI7XvFg857gecHZnAzL7fk7OZryjqmf1yvYetwrxErAboTNHoR9OhdWOvlLpBxe3mwj/3IrfatcQL1OjELCrEJelKHKMpzU/8YreOuZZG46qdzTne4ouWsGK51Rp47sPnySuJa3km073nAXvNxv1LFa9pQR9rNJ8ihRF3zwE15M+Qe4paHEJF46IDasdnLjhjMSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uMVfwCMTa6hADqBJ7X+oJkbnQ7zM2WKTFKjj92Cu6tc=;
 b=Nj8zZeoX9Bf1QYwiw8VHOtA0vXIYYIs7ctWg9P0h8v9HXVLEengQvigN/aeXVGc+q6tbAgPSoOBvHdrn5gJkyj5mNcTFp82AcroN1EJUG3LDSLum6JGBZK6neP8uwv1SFoIOfXDgLLVjqRuuWq3DlZ9T3FL/h31PZYMRAB0MCek=
From: Henry Wang <Henry.Wang@arm.com>
To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Kevin Tian <kevin.tian@intel.com>, Jan Beulich <jbeulich@suse.com>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>
Subject: RE: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API
Thread-Topic: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory
 API
Thread-Index: AQHY1AgeJwq4WhKefkGyVS1JhkdRo64QKSwAgAG7SUA=
Date: Mon, 17 Oct 2022 01:20:02 +0000
Message-ID:
 <AS8PR08MB7991A2F3DE5A5B55ED3D09F492299@AS8PR08MB7991.eurprd08.prod.outlook.com>
References:
 <cover.9762b1190a6fd8f0232c26cbace1b2c4f8555818.1664458360.git-series.marmarek@invisiblethingslab.com>
 <ecee2217151efd08b2bae58166efcdd319ec82c8.1664458360.git-series.marmarek@invisiblethingslab.com>
 <Y0s5Xvr5PBQq5pVB@mail-itl>
In-Reply-To: <Y0s5Xvr5PBQq5pVB@mail-itl>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 2305602B2D5B3041AC65E2FF83A7CA51.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB9372:EE_|VI1EUR03FT040:EE_|PR3PR08MB5721:EE_
X-MS-Office365-Filtering-Correlation-Id: fc171aa5-78bb-4c8e-6fdd-08daafddbca1
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 F/tDhwpBDhAzhU9KjQmqd3pZKLfJ8V5Z+bhTKF1XEzKw4m4K8xGnB0oBPEwsFCzjBVXDsB3q8DgZwqVfw5OIIbyexMTCqxawrEoFJXbn51NyPfAz5lPBeEEb/hm4Q1prcwa8Rpe0vr1qi2k8zVRoaFV240N78TjWujQCnyvgo+HpTVJljbWMZCEhfEFBAUiRg+WxZD17KRVRHZai3fOSchXuPcZgSToUYkH4tLw8PDiHEjuUpHHzLFv9qDQDj1BLo1Ar5oZjnJ5EGQSxbTg+l/5mdMaqTA86ZByfk+Z+Cs4KR6FimN1+OCHMFY/KsFyG+ftZVC+/MPWyVtdihJrNRFOy6DL+lqI29lCqvMny3iHN9cNIdd1yTOvFI2h8XNh5ZsMP4kxfUMSENFdDP84fc3Sf3UboM+NALTxIn3/dTUZKeXiBJIc3NOvdFlgP8jxAViKGP+Ye9NYsxwTB1Q8wgGQVyUfUfZ2kb3n10+oyIjYFuey4b0n/Zk0RUm8bDUWgZeXbwf8d5iDKMX2OQgAWxR4lPKtg0YuUFrkVsfCvdqER93EhBiYLo0+kVtWXUSOzwgUTQ2u9L+lg/hcRBuCGX4UC+FTcr+q6FhDkGKo2c09PLrc1BgH4+vlGTM9bLucqVOstPs3e5dCexuliaD086OhkMswQlAJFXlRWBwX0+i7S0yHjDhPwFtAoUw8a2WQa4SaLGzyPNaKRVjUvuFh6vc4gTq0g/AHphHiFoRpIwLZY0myvqkNW76KNgE68uwBE9O2VqKEsIJPnBaIZ9ansVA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199015)(71200400001)(54906003)(186003)(38070700005)(66574015)(83380400001)(86362001)(122000001)(38100700002)(5660300002)(2906002)(41300700001)(4326008)(52536014)(55016003)(8936002)(64756008)(8676002)(478600001)(9686003)(6506007)(7696005)(26005)(316002)(76116006)(66476007)(66556008)(66946007)(110136005)(66446008)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9372
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9fc80161-91e6-4037-4a7b-08daafddb74c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5SrLqw3AotK5wV/QdfDzlZy+uG7oXvF2Vh3d7WmqVX5uevcE01IqWLyEDoMu3L0MTNR0JkkjXnU8UWm828UEyslqZZ70kvRJ8tCTWIio1aWe4Rwk/LgnLhlz/XMR7pMCMGHQXEAGrTXhTc0YdZBlDmX/pIcdmx9CowjPccrSrItuV7wVMN3DU7qD7sgc90eQ6GUJOD4M8jJmGCclafuAP5JXkIaPeh8ixtNMkcF52Pu+AIPB+iHRCKOe0DxjDxTAvc+vSCT8rfxbXuLXNqJXLHkbgNtY3hUz5xMlARGRYX9OhykyC5W3PwWcSg6vbUmau2wjUlUWGyCWqB8reSmpmmEvj+pEu0Sgs27J6FE/8NKwEKBf7lKV245R/PhlonAqUi+hpb0ezuL9BW3z3I9lIfihqaXfQE7vtxK8p29kCHRNPmYzIECWoFOeBsnrjQE+D7sMtRFAy6K+q0UrEoIGMPoL2jf6xTZ3WJxOUeDXEZ9cKya4Um5R+CCvXoC6VvxgkkmCBE6bHygvT4JIYfWxz9cSpSi8rkA46FL4+uloyEJs9SsAFrozqnbLQ757KUD+VYehgMKhnrE3d2719RXwrqN1Ww74NxUQVybEQCgMax31UAAM0WQMwjHAED1ziFT1yBWmN81mjj7+9XC2hLsB6nSPliuAiNXBOVHfEWIYi/MR9MwbQpEOboZ2fEOxxGEdUgZ1S5y+n5VH2ba4KeqdyZvS5IVPBChR2mu6KRu0/1GSG+/J1hSn7BZhJvsvxCKV
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(36840700001)(46966006)(33656002)(36860700001)(86362001)(5660300002)(2906002)(82740400003)(336012)(47076005)(186003)(81166007)(356005)(66574015)(83380400001)(7696005)(6506007)(316002)(26005)(478600001)(9686003)(110136005)(54906003)(70586007)(70206006)(82310400005)(55016003)(40480700001)(41300700001)(52536014)(4326008)(8936002)(107886003)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 01:20:11.2113
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fc171aa5-78bb-4c8e-6fdd-08daafddbca1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5721

SGkgTWFyZWssDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWFyZWsg
TWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJtYXJla0BpbnZpc2libGV0aGluZ3NsYWIuY29tPg0K
PiBTdWJqZWN0OiBSZTogW1BBVENIIHY4IDEvMl0gSU9NTVUvVlQtZDogd2lyZSBjb21tb24gZGV2
aWNlIHJlc2VydmVkDQo+IG1lbW9yeSBBUEkNCj4gDQo+IE9uIFRodSwgU2VwIDI5LCAyMDIyIGF0
IDAzOjMzOjEyUE0gKzAyMDAsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraQ0KPiB3cm90ZToN
Cj4gPiBSZS11c2Ugcm1ycj0gcGFyYW1ldGVyIGhhbmRsaW5nIGNvZGUgdG8gaGFuZGxlIGNvbW1v
biBkZXZpY2UgcmVzZXJ2ZWQNCj4gPiBtZW1vcnkuDQo+ID4NCj4gPiBNb3ZlIE1BWF9VU0VSX1JN
UlJfUEFHRVMgbGltaXQgZW5mb3JjZW1lbnQgdG8gYXBwbHkgb25seSB0bw0KPiA+IHVzZXItY29u
ZmlndXJlZCByYW5nZXMsIGJ1dCBub3QgdGhvc2UgZnJvbSBpbnRlcm5hbCBjYWxsZXJzLg0KPiA+
DQo+ID4gU2lnbmVkLW9mZi1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpDQo+IDxtYXJt
YXJla0BpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiA+IFJldmlld2VkLWJ5OiBLZXZpbiBUaWFu
IDxrZXZpbi50aWFuQGludGVsLmNvbT4NCj4gDQo+IEhlbnJ5LCBjYW4gdGhpcyBiZSBpbmNsdWRl
ZCBpbiA0LjE3PyBUaGUgQU1EIGNvdW50ZXJwYXJ0IHdlbnQgaW4NCj4gZWFybGllciwgYnV0IGR1
ZSB0byBsYXRlIHJldmlldyBvbiBJbnRlbCBwYXJ0LCB0aGlzIG9uZSBkaWRuJ3QuDQoNClRoYW5r
cyBmb3IgdGhlIGluZm9ybWF0aW9uLiBJIGFncmVlIHRoaXMgaXMgYSB2YWxpZCByZWFzb24sIGJ1
dCB0byBiZQ0Kc2FmZSBJIHdvdWxkIGxpa2UgdG8gaGVhciBvcGluaW9ucyBmcm9tIHRoZSB4ODYg
bWFpbnRhaW5lcnMgKGFkZGVkDQppbiBDQykuDQoNCkFuZHJldy9KYW4vUm9nZXI6IE1heSBJIGhh
dmUgeW91ciBmZWVkYmFjayBhYm91dCB0aGlzPyBUaGFua3MhDQoNCktpbmQgcmVnYXJkcywNCkhl
bnJ5DQoNCj4gDQo+ID4gLS0tDQo+ID4gQ2hhbmdlcyBpbiB2ODoNCj4gPiAtIG1vdmUgYWRkX29u
ZV91c2VyX3JtcnIoKSBmdW5jdGlvbiBlYXJsaWVyDQo+ID4gLSBleHRlbmQgY29tbWl0IG1lc3Nh
Z2UNCj4gPiBDaGFuZ2VzIGluIHYzOg0KPiA+IC0gbWFrZSBNQVhfVVNFUl9STVJSX1BBR0VTIGFw
cGxpY2FibGUgb25seSB0byB1c2VyLWNvbmZpZ3VyZWQgUk1SUg0KPiA+IC0tLQ0KPiA+ICB4ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZG1hci5jIHwgMTk2ICsrKysrKysrKysrKysrKysrLS0t
LS0tLS0tLS0tLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTE0IGluc2VydGlvbnMoKyksIDgyIGRl
bGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo
L3Z0ZC9kbWFyLmMNCj4gYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvZG1hci5jDQo+ID4g
aW5kZXggMzY3MzA0Yzg3MzljLi43OGM4YmFkMTUxNWEgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2Ry
aXZlcnMvcGFzc3Rocm91Z2gvdnRkL2RtYXIuYw0KPiA+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL3Z0ZC9kbWFyLmMNCj4gPiBAQCAtODYxLDExMyArODYxLDEzNiBAQCBzdGF0aWMgc3Ry
dWN0IHVzZXJfcm1yciBfX2luaXRkYXRhDQo+IHVzZXJfcm1ycnNbTUFYX1VTRVJfUk1SUl07DQo+
ID4NCj4gPiAgLyogTWFjcm8gZm9yIFJNUlIgaW5jbHVzaXZlIHJhbmdlIGZvcm1hdHRpbmcuICov
DQo+ID4gICNkZWZpbmUgRVJNUlJVX0ZNVCAiWyVseC0lbHhdIg0KPiA+IC0jZGVmaW5lIEVSTVJS
VV9BUkcoZXJ1KSBlcnUuYmFzZV9wZm4sIGVydS5lbmRfcGZuDQo+ID4gKyNkZWZpbmUgRVJNUlJV
X0FSRyBiYXNlX3BmbiwgZW5kX3Bmbg0KPiA+DQo+ID4gLXN0YXRpYyBpbnQgX19pbml0IGFkZF91
c2VyX3JtcnIodm9pZCkNCj4gPiArLyogUmV0dXJucyAxIG9uIHN1Y2Nlc3MsIDAgd2hlbiBpZ25v
cmluZyBhbmQgPCAwIG9uIGVycm9yLiAqLw0KPiA+ICtzdGF0aWMgaW50IF9faW5pdCBhZGRfb25l
X3VzZXJfcm1ycih1bnNpZ25lZCBsb25nIGJhc2VfcGZuLA0KPiA+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGVuZF9wZm4sDQo+ID4gKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBkZXZfY291bnQsDQo+ID4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90ICpzYmRmKQ0KPiA+
ICB7DQo+ID4gICAgICBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnIsICpybXJydTsNCj4gPiAt
ICAgIHVuc2lnbmVkIGludCBpZHgsIHNlZywgaTsNCj4gPiAtICAgIHVuc2lnbmVkIGxvbmcgYmFz
ZSwgZW5kOw0KPiA+ICsgICAgdW5zaWduZWQgaW50IGlkeCwgc2VnOw0KPiA+ICsgICAgdW5zaWdu
ZWQgbG9uZyBiYXNlX2l0ZXI7DQo+ID4gICAgICBib29sIG92ZXJsYXA7DQo+ID4NCj4gPiAtICAg
IGZvciAoIGkgPSAwOyBpIDwgbnJfcm1ycjsgaSsrICkNCj4gPiArICAgIGlmICggaW9tbXVfdmVy
Ym9zZSApDQo+ID4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19ERUJVRyBWVERQUkVGSVgNCj4gPiAr
ICAgICAgICAgICAgICAgIkFkZGluZyBSTVJSIGZvciAlZCBkZXZpY2UgKFswXTogJSN4KSByYW5n
ZSAiRVJNUlJVX0ZNVCJcbiIsDQo+ID4gKyAgICAgICAgICAgICAgIGRldl9jb3VudCwgc2JkZlsw
XSwgRVJNUlJVX0FSRyk7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCBiYXNlX3BmbiA+IGVuZF9wZm4g
KQ0KPiA+ICAgICAgew0KPiA+IC0gICAgICAgIGJhc2UgPSB1c2VyX3JtcnJzW2ldLmJhc2VfcGZu
Ow0KPiA+IC0gICAgICAgIGVuZCA9IHVzZXJfcm1ycnNbaV0uZW5kX3BmbjsNCj4gPiArICAgICAg
ICBwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgNCj4gPiArICAgICAgICAgICAgICAgIkludmFs
aWQgUk1SUiBSYW5nZSAiRVJNUlJVX0ZNVCJcbiIsDQo+ID4gKyAgICAgICAgICAgICAgIEVSTVJS
VV9BUkcpOw0KPiA+ICsgICAgICAgIHJldHVybiAwOw0KPiA+ICsgICAgfQ0KPiA+DQo+ID4gLSAg
ICAgICAgaWYgKCBiYXNlID4gZW5kICkNCj4gPiArICAgIG92ZXJsYXAgPSBmYWxzZTsNCj4gPiAr
ICAgIGxpc3RfZm9yX2VhY2hfZW50cnkocm1ycnUsICZhY3BpX3JtcnJfdW5pdHMsIGxpc3QpDQo+
ID4gKyAgICB7DQo+ID4gKyAgICAgICAgaWYgKCBwZm5fdG9fcGFkZHIoYmFzZV9wZm4pIDw9IHJt
cnJ1LT5lbmRfYWRkcmVzcyAmJg0KPiA+ICsgICAgICAgICAgICAgcm1ycnUtPmJhc2VfYWRkcmVz
cyA8PSBwZm5fdG9fcGFkZHIoZW5kX3BmbikgKQ0KPiA+ICAgICAgICAgIHsNCj4gPiAgICAgICAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYDQo+ID4gLSAgICAgICAgICAgICAgICAg
ICAiSW52YWxpZCBSTVJSIFJhbmdlICJFUk1SUlVfRk1UIlxuIiwNCj4gPiAtICAgICAgICAgICAg
ICAgICAgIEVSTVJSVV9BUkcodXNlcl9ybXJyc1tpXSkpOw0KPiA+IC0gICAgICAgICAgICBjb250
aW51ZTsNCj4gPiArICAgICAgICAgICAgICAgICAgICJPdmVybGFwcGluZyBSTVJSczogIkVSTVJS
VV9GTVQiIGFuZCBbJWx4LSVseF1cbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICBFUk1SUlVf
QVJHLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgcGFkZHJfdG9fcGZuKHJtcnJ1LT5iYXNlX2Fk
ZHJlc3MpLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgcGFkZHJfdG9fcGZuKHJtcnJ1LT5lbmRf
YWRkcmVzcykpOw0KPiA+ICsgICAgICAgICAgICBvdmVybGFwID0gdHJ1ZTsNCj4gPiArICAgICAg
ICAgICAgYnJlYWs7DQo+ID4gICAgICAgICAgfQ0KPiA+ICsgICAgfQ0KPiA+ICsgICAgLyogRG9u
J3QgYWRkIG92ZXJsYXBwaW5nIFJNUlIuICovDQo+ID4gKyAgICBpZiAoIG92ZXJsYXAgKQ0KPiA+
ICsgICAgICAgIHJldHVybiAwOw0KPiA+DQo+ID4gLSAgICAgICAgaWYgKCAoZW5kIC0gYmFzZSkg
Pj0gTUFYX1VTRVJfUk1SUl9QQUdFUyApDQo+ID4gKyAgICBiYXNlX2l0ZXIgPSBiYXNlX3BmbjsN
Cj4gPiArICAgIGRvDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgaWYgKCAhbWZuX3ZhbGlkKF9t
Zm4oYmFzZV9pdGVyKSkgKQ0KPiA+ICAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICAgcHJpbnRr
KFhFTkxPR19FUlIgVlREUFJFRklYDQo+ID4gLSAgICAgICAgICAgICAgICAgICAiUk1SUiByYW5n
ZSAiRVJNUlJVX0ZNVCIgZXhjZWVkcyAiXA0KPiA+IC0gICAgICAgICAgICAgICAgICAgX19zdHJp
bmdpZnkoTUFYX1VTRVJfUk1SUl9QQUdFUykiIHBhZ2VzXG4iLA0KPiA+IC0gICAgICAgICAgICAg
ICAgICAgRVJNUlJVX0FSRyh1c2VyX3JtcnJzW2ldKSk7DQo+ID4gLSAgICAgICAgICAgIGNvbnRp
bnVlOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgIkludmFsaWQgcGZuIGluIFJNUlIgcmFuZ2Ug
IkVSTVJSVV9GTVQiXG4iLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgRVJNUlJVX0FSRyk7DQo+
ID4gKyAgICAgICAgICAgIGJyZWFrOw0KPiA+ICAgICAgICAgIH0NCj4gPiArICAgIH0gd2hpbGUg
KCBiYXNlX2l0ZXIrKyA8IGVuZF9wZm4gKTsNCj4gPg0KPiA+IC0gICAgICAgIG92ZXJsYXAgPSBm
YWxzZTsNCj4gPiAtICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KHJtcnJ1LCAmYWNwaV9ybXJy
X3VuaXRzLCBsaXN0KQ0KPiA+IC0gICAgICAgIHsNCj4gPiAtICAgICAgICAgICAgaWYgKCBwZm5f
dG9fcGFkZHIoYmFzZSkgPD0gcm1ycnUtPmVuZF9hZGRyZXNzICYmDQo+ID4gLSAgICAgICAgICAg
ICAgICAgcm1ycnUtPmJhc2VfYWRkcmVzcyA8PSBwZm5fdG9fcGFkZHIoZW5kKSApDQo+ID4gLSAg
ICAgICAgICAgIHsNCj4gPiAtICAgICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSIFZURFBS
RUZJWA0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICJPdmVybGFwcGluZyBSTVJSczogIkVS
TVJSVV9GTVQiIGFuZCBbJWx4LSVseF1cbiIsDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg
RVJNUlJVX0FSRyh1c2VyX3JtcnJzW2ldKSwNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBw
YWRkcl90b19wZm4ocm1ycnUtPmJhc2VfYWRkcmVzcyksDQo+ID4gLSAgICAgICAgICAgICAgICAg
ICAgICAgcGFkZHJfdG9fcGZuKHJtcnJ1LT5lbmRfYWRkcmVzcykpOw0KPiA+IC0gICAgICAgICAg
ICAgICAgb3ZlcmxhcCA9IHRydWU7DQo+ID4gLSAgICAgICAgICAgICAgICBicmVhazsNCj4gPiAt
ICAgICAgICAgICAgfQ0KPiA+IC0gICAgICAgIH0NCj4gPiAtICAgICAgICAvKiBEb24ndCBhZGQg
b3ZlcmxhcHBpbmcgUk1SUi4gKi8NCj4gPiAtICAgICAgICBpZiAoIG92ZXJsYXAgKQ0KPiA+IC0g
ICAgICAgICAgICBjb250aW51ZTsNCj4gPiArICAgIC8qIEludmFsaWQgcGZuIGluIHJhbmdlIGFz
IHRoZSBsb29wIGVuZGVkIGJlZm9yZSBlbmRfcGZuIHdhcyByZWFjaGVkLg0KPiAqLw0KPiA+ICsg
ICAgaWYgKCBiYXNlX2l0ZXIgPD0gZW5kX3BmbiApDQo+ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+
ID4NCj4gPiAtICAgICAgICBkbw0KPiA+IC0gICAgICAgIHsNCj4gPiAtICAgICAgICAgICAgaWYg
KCAhbWZuX3ZhbGlkKF9tZm4oYmFzZSkpICkNCj4gPiAtICAgICAgICAgICAgew0KPiA+IC0gICAg
ICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklYDQo+ID4gLSAgICAgICAgICAg
ICAgICAgICAgICAgIkludmFsaWQgcGZuIGluIFJNUlIgcmFuZ2UgIkVSTVJSVV9GTVQiXG4iLA0K
PiA+IC0gICAgICAgICAgICAgICAgICAgICAgIEVSTVJSVV9BUkcodXNlcl9ybXJyc1tpXSkpOw0K
PiA+IC0gICAgICAgICAgICAgICAgYnJlYWs7DQo+ID4gLSAgICAgICAgICAgIH0NCj4gPiAtICAg
ICAgICB9IHdoaWxlICggYmFzZSsrIDwgZW5kICk7DQo+ID4gKyAgICBybXJyID0geHphbGxvYyhz
dHJ1Y3QgYWNwaV9ybXJyX3VuaXQpOw0KPiA+ICsgICAgaWYgKCAhcm1yciApDQo+ID4gKyAgICAg
ICAgcmV0dXJuIC1FTk9NRU07DQo+ID4NCj4gPiAtICAgICAgICAvKiBJbnZhbGlkIHBmbiBpbiBy
YW5nZSBhcyB0aGUgbG9vcCBlbmRlZCBiZWZvcmUgZW5kX3BmbiB3YXMgcmVhY2hlZC4NCj4gKi8N
Cj4gPiAtICAgICAgICBpZiAoIGJhc2UgPD0gZW5kICkNCj4gPiAtICAgICAgICAgICAgY29udGlu
dWU7DQo+ID4gKyAgICBybXJyLT5zY29wZS5kZXZpY2VzID0geG1hbGxvY19hcnJheSh1MTYsIGRl
dl9jb3VudCk7DQo+ID4gKyAgICBpZiAoICFybXJyLT5zY29wZS5kZXZpY2VzICkNCj4gPiArICAg
IHsNCj4gPiArICAgICAgICB4ZnJlZShybXJyKTsNCj4gPiArICAgICAgICByZXR1cm4gLUVOT01F
TTsNCj4gPiArICAgIH0NCj4gPg0KPiA+IC0gICAgICAgIHJtcnIgPSB4emFsbG9jKHN0cnVjdCBh
Y3BpX3JtcnJfdW5pdCk7DQo+ID4gLSAgICAgICAgaWYgKCAhcm1yciApDQo+ID4gLSAgICAgICAg
ICAgIHJldHVybiAtRU5PTUVNOw0KPiA+ICsgICAgc2VnID0gMDsNCj4gPiArICAgIGZvciAoIGlk
eCA9IDA7IGlkeCA8IGRldl9jb3VudDsgaWR4KysgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAg
IHJtcnItPnNjb3BlLmRldmljZXNbaWR4XSA9IHNiZGZbaWR4XTsNCj4gPiArICAgICAgICBzZWcg
fD0gUENJX1NFRyhzYmRmW2lkeF0pOw0KPiA+ICsgICAgfQ0KPiA+ICsgICAgaWYgKCBzZWcgIT0g
UENJX1NFRyhzYmRmWzBdKSApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcHJpbnRrKFhFTkxP
R19FUlIgVlREUFJFRklYDQo+ID4gKyAgICAgICAgICAgICAgICJTZWdtZW50cyBhcmUgbm90IGVx
dWFsIGZvciBSTVJSIHJhbmdlICJFUk1SUlVfRk1UIlxuIiwNCj4gPiArICAgICAgICAgICAgICAg
RVJNUlJVX0FSRyk7DQo+ID4gKyAgICAgICAgc2NvcGVfZGV2aWNlc19mcmVlKCZybXJyLT5zY29w
ZSk7DQo+ID4gKyAgICAgICAgeGZyZWUocm1ycik7DQo+ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+
ID4gKyAgICB9DQo+ID4NCj4gPiAtICAgICAgICBybXJyLT5zY29wZS5kZXZpY2VzID0geG1hbGxv
Y19hcnJheSh1MTYsIHVzZXJfcm1ycnNbaV0uZGV2X2NvdW50KTsNCj4gPiAtICAgICAgICBpZiAo
ICFybXJyLT5zY29wZS5kZXZpY2VzICkNCj4gPiAtICAgICAgICB7DQo+ID4gLSAgICAgICAgICAg
IHhmcmVlKHJtcnIpOw0KPiA+IC0gICAgICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gPiAtICAg
ICAgICB9DQo+ID4gKyAgICBybXJyLT5zZWdtZW50ID0gc2VnOw0KPiA+ICsgICAgcm1yci0+YmFz
ZV9hZGRyZXNzID0gcGZuX3RvX3BhZGRyKGJhc2VfcGZuKTsNCj4gPiArICAgIC8qIEFsaWduIHRo
ZSBlbmRfYWRkcmVzcyB0byB0aGUgZW5kIG9mIHRoZSBwYWdlICovDQo+ID4gKyAgICBybXJyLT5l
bmRfYWRkcmVzcyA9IHBmbl90b19wYWRkcihlbmRfcGZuKSB8IH5QQUdFX01BU0s7DQo+ID4gKyAg
ICBybXJyLT5zY29wZS5kZXZpY2VzX2NudCA9IGRldl9jb3VudDsNCj4gPg0KPiA+IC0gICAgICAg
IHNlZyA9IDA7DQo+ID4gLSAgICAgICAgZm9yICggaWR4ID0gMDsgaWR4IDwgdXNlcl9ybXJyc1tp
XS5kZXZfY291bnQ7IGlkeCsrICkNCj4gPiAtICAgICAgICB7DQo+ID4gLSAgICAgICAgICAgIHJt
cnItPnNjb3BlLmRldmljZXNbaWR4XSA9IHVzZXJfcm1ycnNbaV0uc2JkZltpZHhdOw0KPiA+IC0g
ICAgICAgICAgICBzZWcgfD0gUENJX1NFRyh1c2VyX3JtcnJzW2ldLnNiZGZbaWR4XSk7DQo+ID4g
LSAgICAgICAgfQ0KPiA+IC0gICAgICAgIGlmICggc2VnICE9IFBDSV9TRUcodXNlcl9ybXJyc1tp
XS5zYmRmWzBdKSApDQo+ID4gLSAgICAgICAgew0KPiA+IC0gICAgICAgICAgICBwcmludGsoWEVO
TE9HX0VSUiBWVERQUkVGSVgNCj4gPiAtICAgICAgICAgICAgICAgICAgICJTZWdtZW50cyBhcmUg
bm90IGVxdWFsIGZvciBSTVJSIHJhbmdlICJFUk1SUlVfRk1UIlxuIiwNCj4gPiAtICAgICAgICAg
ICAgICAgICAgIEVSTVJSVV9BUkcodXNlcl9ybXJyc1tpXSkpOw0KPiA+IC0gICAgICAgICAgICBz
Y29wZV9kZXZpY2VzX2ZyZWUoJnJtcnItPnNjb3BlKTsNCj4gPiAtICAgICAgICAgICAgeGZyZWUo
cm1ycik7DQo+ID4gLSAgICAgICAgICAgIGNvbnRpbnVlOw0KPiA+IC0gICAgICAgIH0NCj4gPiAr
ICAgIGlmICggcmVnaXN0ZXJfb25lX3JtcnIocm1ycikgKQ0KPiA+ICsgICAgICAgIHByaW50ayhY
RU5MT0dfRVJSIFZURFBSRUZJWA0KPiA+ICsgICAgICAgICAgICAgICAiQ291bGQgbm90IHJlZ2lz
dGVyIFJNTVIgcmFuZ2UgIkVSTVJSVV9GTVQiXG4iLA0KPiA+ICsgICAgICAgICAgICAgICBFUk1S
UlVfQVJHKTsNCj4gPg0KPiA+IC0gICAgICAgIHJtcnItPnNlZ21lbnQgPSBzZWc7DQo+ID4gLSAg
ICAgICAgcm1yci0+YmFzZV9hZGRyZXNzID0gcGZuX3RvX3BhZGRyKHVzZXJfcm1ycnNbaV0uYmFz
ZV9wZm4pOw0KPiA+IC0gICAgICAgIC8qIEFsaWduIHRoZSBlbmRfYWRkcmVzcyB0byB0aGUgZW5k
IG9mIHRoZSBwYWdlICovDQo+ID4gLSAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3MgPSBwZm5fdG9f
cGFkZHIodXNlcl9ybXJyc1tpXS5lbmRfcGZuKSB8DQo+IH5QQUdFX01BU0s7DQo+ID4gLSAgICAg
ICAgcm1yci0+c2NvcGUuZGV2aWNlc19jbnQgPSB1c2VyX3JtcnJzW2ldLmRldl9jb3VudDsNCj4g
PiArICAgIHJldHVybiAxOw0KPiA+ICt9DQo+ID4NCj4gPiAtICAgICAgICBpZiAoIHJlZ2lzdGVy
X29uZV9ybXJyKHJtcnIpICkNCj4gPiAtICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgVlRE
UFJFRklYDQo+ID4gLSAgICAgICAgICAgICAgICAgICAiQ291bGQgbm90IHJlZ2lzdGVyIFJNTVIg
cmFuZ2UgIkVSTVJSVV9GTVQiXG4iLA0KPiA+IC0gICAgICAgICAgICAgICAgICAgRVJNUlJVX0FS
Ryh1c2VyX3JtcnJzW2ldKSk7DQo+ID4gLSAgICB9DQo+ID4gK3N0YXRpYyBpbnQgX19pbml0IGFk
ZF91c2VyX3JtcnIodm9pZCkNCj4gPiArew0KPiA+ICsgICAgdW5zaWduZWQgaW50IGk7DQo+ID4g
KyAgICBpbnQgcmV0Ow0KPiA+DQo+ID4gKyAgICBmb3IgKCBpID0gMDsgaSA8IG5yX3JtcnI7IGkr
KyApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcmV0ID0gYWRkX29uZV91c2VyX3JtcnIodXNl
cl9ybXJyc1tpXS5iYXNlX3BmbiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICB1c2VyX3JtcnJzW2ldLmVuZF9wZm4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgdXNlcl9ybXJyc1tpXS5kZXZfY291bnQsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgdXNlcl9ybXJyc1tpXS5zYmRmKTsNCj4gPiArICAgICAgICBpZiAoIHJldCA8
IDAgKQ0KPiA+ICsgICAgICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsgICAgfQ0KPiA+ICAgICAg
cmV0dXJuIDA7DQo+ID4gIH0NCj4gPg0KPiA+ICtzdGF0aWMgaW50IF9faW5pdCBjZl9jaGVjayBh
ZGRfb25lX2V4dHJhX3JtcnIoeGVuX3Bmbl90IHN0YXJ0LA0KPiB4ZW5fdWxvbmdfdCBuciwgdTMy
IGlkLCB2b2lkICpjdHh0KQ0KPiA+ICt7DQo+ID4gKyAgICB1MzIgc2JkZl9hcnJheVtdID0geyBp
ZCB9Ow0KPiA+ICsgICAgcmV0dXJuIGFkZF9vbmVfdXNlcl9ybXJyKHN0YXJ0LCBzdGFydCtuciwg
MSwgc2JkZl9hcnJheSk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgX19pbml0IGFk
ZF9leHRyYV9ybXJyKHZvaWQpDQo+ID4gK3sNCj4gPiArICAgIHJldHVybg0KPiBpb21tdV9nZXRf
ZXh0cmFfcmVzZXJ2ZWRfZGV2aWNlX21lbW9yeShhZGRfb25lX2V4dHJhX3JtcnIsIE5VTEwpOw0K
PiA+ICt9DQo+ID4gKw0KPiA+ICAjaW5jbHVkZSA8YXNtL3Rib290Lmg+DQo+ID4gIC8qIEFDUEkg
dGFibGVzIG1heSBub3QgYmUgRE1BIHByb3RlY3RlZCBieSB0Ym9vdCwgc28gdXNlIERNQVIgY29w
eSAqLw0KPiA+ICAvKiBTSU5JVCBzYXZlZCBpbiBTaW5pdE1sZURhdGEgaW4gVFhUIGhlYXAgKHdo
aWNoIGlzIERNQSBwcm90ZWN0ZWQpICovDQo+ID4gQEAgLTEwMTAsNyArMTAzMyw3IEBAIGludCBf
X2luaXQgYWNwaV9kbWFyX2luaXQodm9pZCkNCj4gPiAgICAgIHsNCj4gPiAgICAgICAgICBpb21t
dV9pbml0X29wcyA9ICZpbnRlbF9pb21tdV9pbml0X29wczsNCj4gPg0KPiA+IC0gICAgICAgIHJl
dHVybiBhZGRfdXNlcl9ybXJyKCk7DQo+ID4gKyAgICAgICAgcmV0dXJuIGFkZF91c2VyX3JtcnIo
KSB8fCBhZGRfZXh0cmFfcm1ycigpOw0KPiA+ICAgICAgfQ0KPiA+DQo+ID4gICAgICByZXR1cm4g
cmV0Ow0KPiA+IEBAIC0xMTA4LDYgKzExMzEsMTUgQEAgc3RhdGljIGludCBfX2luaXQgY2ZfY2hl
Y2sNCj4gcGFyc2Vfcm1ycl9wYXJhbShjb25zdCBjaGFyICpzdHIpDQo+ID4gICAgICAgICAgZWxz
ZQ0KPiA+ICAgICAgICAgICAgICBlbmQgPSBzdGFydDsNCj4gPg0KPiA+ICsgICAgICAgIGlmICgg
KGVuZCAtIHN0YXJ0KSA+PSBNQVhfVVNFUl9STVJSX1BBR0VTICkNCj4gPiArICAgICAgICB7DQo+
ID4gKyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWA0KPiA+ICsgICAgICAg
ICAgICAgICAgICAgICJSTVJSIHJhbmdlICJFUk1SUlVfRk1UIiBleGNlZWRzICJcDQo+ID4gKyAg
ICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnkoTUFYX1VTRVJfUk1SUl9QQUdFUykiIHBhZ2Vz
XG4iLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgIHN0YXJ0LCBlbmQpOw0KPiA+ICsgICAgICAg
ICAgICByZXR1cm4gLUUyQklHOw0KPiA+ICsgICAgICAgIH0NCj4gPiArDQo+ID4gICAgICAgICAg
dXNlcl9ybXJyc1tucl9ybXJyXS5iYXNlX3BmbiA9IHN0YXJ0Ow0KPiA+ICAgICAgICAgIHVzZXJf
cm1ycnNbbnJfcm1ycl0uZW5kX3BmbiA9IGVuZDsNCj4gPg0KPiA+IC0tDQo+ID4gZ2l0LXNlcmll
cyAwLjkuMQ0KPiA+DQo+IA0KPiAtLQ0KPiBCZXN0IFJlZ2FyZHMsDQo+IE1hcmVrIE1hcmN6eWtv
d3NraS1Hw7NyZWNraQ0KPiBJbnZpc2libGUgVGhpbmdzIExhYg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 02:55:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 02:55:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424030.671240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okGH9-0005uY-Iv; Mon, 17 Oct 2022 02:54:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424030.671240; Mon, 17 Oct 2022 02:54:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okGH9-0005uQ-DO; Mon, 17 Oct 2022 02:54:47 +0000
Received: by outflank-mailman (input) for mailman id 424030;
 Mon, 17 Oct 2022 02:54:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okGH7-0005uD-QM; Mon, 17 Oct 2022 02:54:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okGH7-0003TF-ME; Mon, 17 Oct 2022 02:54:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okGH7-00052R-DW; Mon, 17 Oct 2022 02:54:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okGH7-000320-Cz; Mon, 17 Oct 2022 02:54:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vraShTr59sUncz07aebT9tIzzuYgMZXMjGqOt8WxC5g=; b=rUTBGA6SKDw/B9KjYMH8uZFUV0
	h4Cwz5KjZ53MJ3VAaUGqJSGWHqVB4flRE8Bz4J20bvSKkVUXSH9Yl7FsdEAg4gvUgcQV6IFVD+8za
	sRrl1C2//xu4AazLGGck/kh6i9nRL5FueV4cAwWVr0030te3ZignaCc+33rTLYzapA2E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173861-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173861: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=19d17ab7c68b62180e0537f92400a6f798019775
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 02:54:45 +0000

flight 173861 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173861/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                19d17ab7c68b62180e0537f92400a6f798019775
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z    9 days
Failing since        173470  2022-10-08 06:21:34 Z    8 days   17 attempts
Testing same since   173861  2022-10-15 21:24:30 Z    1 days    1 attempts

------------------------------------------------------------
1253 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 117171 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 03:27:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 03:27:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424040.671258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okGma-0001OM-56; Mon, 17 Oct 2022 03:27:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424040.671258; Mon, 17 Oct 2022 03:27:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okGma-0001OF-0S; Mon, 17 Oct 2022 03:27:16 +0000
Received: by outflank-mailman (input) for mailman id 424040;
 Mon, 17 Oct 2022 03:27:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okGmZ-0001O5-BR; Mon, 17 Oct 2022 03:27:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okGmZ-0004VU-74; Mon, 17 Oct 2022 03:27:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okGmY-0006Wa-SW; Mon, 17 Oct 2022 03:27:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okGmY-0003H9-Rv; Mon, 17 Oct 2022 03:27:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=Mjk5E9vA2c+Ypk+hUqssSycffucXT2dsKR9cB3j3KrQ=; b=fB4Fi5PE3gtEzkjcuFttsVca6A
	NT8W1tgh4QtD9VZ0f0E9At+UIb1omVOEsk7qyMDbVprFnIVx2heWpcTocVwI7pHJKS91kfN8gCTv/
	tVuLn+Xzsg6UfhvtNERTzabMC9xPKD9JXZjRGal/OdihRehmO/dOG8DAGzqc0g0JIYVo=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-armhf-armhf-xl-vhd
Message-Id: <E1okGmY-0003H9-Rv@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 03:27:14 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-armhf-armhf-xl-vhd
testid debian-di-install

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173974/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-vhd.debian-di-install.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-vhd.debian-di-install --summary-out=tmp/173974.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-armhf-armhf-xl-vhd debian-di-install
Searching for failure / basis pass:
 173759 fail [host=arndale-metrocentre] / 172623 [host=arndale-lakeside] 172548 [host=arndale-westfield] 172130 ok.
Failure / basis pass flights: 173759 / 172130
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-8fc06b6e19e3df93cc989b4f85877d8a7783e5bf git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad\
 8-107951211a8d17658e1aaa0c23a8cf29f8806ad8 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#48b67651746f3124b0d5d30147180f1238d2e9c6-1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Loaded 10001 nodes in revision graph
Searching for test results:
 173759 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173779 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6
 173793 blocked f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173797 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173816 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 917a7e3f347adb0721ff161a68309f51f621eec5 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173825 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d63242bd69a0e3eaa39afd644b634f60f384b278 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173846 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 406ad0582a3df7af498ec4f0adee1a95ceeae64f 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173866 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 943635d8f8486209e4e48966507ad57963e96284
 173883 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173898 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 e85e2a3c17b6cd38de041cdaf14d9efdcdabad1a
 173915 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 914fc8e8b4cc003e90d51bee0aef54687358530a
 173927 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173933 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173949 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173950 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173966 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 173969 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 173974 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 172130 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6
 172548 [host=arndale-westfield]
 172623 [host=arndale-lakeside]
 173493 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173511 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173702 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173603 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Searching for interesting versions
 Result found: flight 172130 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca, results HASH(0x5642dc125b90) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a\
 8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x5642dc152310) HASH(0x5642dc2137e0) HASH(0x5642dc11cf20) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 914fc8e8b4cc003e90d51bee0aef54687358530a, results HASH(0x5642dc1f\
 0ac8) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 943635d8f8486209e4e48966507ad57963e96284, results HASH(0x5642dc145090) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 406ad0582a3df7af498ec4f0adee1a95ceeae64f 10795\
 1211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x5642dc141080) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d63242bd69a0e3eaa39afd644b634f60f384b278 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x5642dc1321e8) For basis failure, parent searc\
 h stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 917a7e3f347adb0721ff161a68309f51f621eec5 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x5642dc135e08) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 4\
 6de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6, results HASH(0x5642dc11d848) HASH(0x5642da957200) Result found: flight 173493 (fail), for basis failure (at ancestor ~654)
 Repro found: flight 173779 (pass), for basis pass
 Repro found: flight 173883 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 173933 (pass), for last pass
 Result found: flight 173949 (fail), for first failure
 Repro found: flight 173950 (pass), for last pass
 Repro found: flight 173966 (fail), for first failure
 Repro found: flight 173969 (pass), for last pass
 Repro found: flight 173974 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/173974/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 157 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-vhd.debian-di-install.{dot,ps,png,html,svg}.
----------------------------------------
173974: tolerable ALL FAIL

flight 173974 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/173974/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-armhf-armhf-xl-vhd      12 debian-di-install       fail baseline untested


jobs:
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 04:48:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 04:48:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424052.671276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okI2o-0001JA-6i; Mon, 17 Oct 2022 04:48:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424052.671276; Mon, 17 Oct 2022 04:48:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okI2o-0001J3-48; Mon, 17 Oct 2022 04:48:06 +0000
Received: by outflank-mailman (input) for mailman id 424052;
 Mon, 17 Oct 2022 04:48:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okI2m-0001It-VJ; Mon, 17 Oct 2022 04:48:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okI2m-00066Y-St; Mon, 17 Oct 2022 04:48:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okI2m-0002ZL-GP; Mon, 17 Oct 2022 04:48:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okI2m-00087g-Fx; Mon, 17 Oct 2022 04:48:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pJdqaIC+XfkJzWSTgktB1crXYQmNuNtV4sC/Cl4K+U4=; b=6HPFmrJcdJPjzxbERvfmY3hx3u
	9qeYebNuLGE01oRt4eXb6ZqWeiAWWKKLYubn3zC8ONRrkbz1eGc8mHK//8xk0Utcnm9UpjQG0PsAM
	62AsC66D4CS40UZ5h/NnTH8hb6RfDkB8dXK54E4B/amiEZQNzGx5gt8lUuOz+OsvCBI0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173973-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173973: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 04:48:04 +0000

flight 173973 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173973/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   35 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    2 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 06:18:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 06:18:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424101.671306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okJSW-00039Z-6R; Mon, 17 Oct 2022 06:18:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424101.671306; Mon, 17 Oct 2022 06:18:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okJSW-00039S-1w; Mon, 17 Oct 2022 06:18:44 +0000
Received: by outflank-mailman (input) for mailman id 424101;
 Mon, 17 Oct 2022 06:18:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=z+Xv=2S=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okJSU-00038a-Rs
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 06:18:43 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2089.outbound.protection.outlook.com [40.107.104.89])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8bba5e86-4de3-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 08:18:42 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8943.eurprd04.prod.outlook.com (2603:10a6:102:20e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 06:18:39 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 06:18:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bba5e86-4de3-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KR3AUdNVKShookLBErG2y1EAb7rySwLnw/uQCjAHjWtfvvh8SX3hQtev+r9PKHZKK4DI50+TJlXfRjA7xXG0vgl9fzcDpc4gaSgEJ6ppzJBcJuCWZw4fd3DiWUWvmODLYfffzsqbf8UCYqKhn+dMlSrvMDeHScd3fTKXRJLqTtKebOdpnAfehjzDxU16acIGORXUqCVjGep/A+0RTJnhXYnjFZelEfa5p4K8Cb5t1xL5CnbPa07HarPDHwGlLAH1oiBhLvPH18hIi1sngzHzeHNuTEc7PugeIygrDkVCXxYDXB2ZbU+obKeik5MRtssrC5aSLLG1uUjlKh28TCi2GA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4UI+Td8eue2PWUl764XmnwIdpSUjsrLQmd+fwdyuvZg=;
 b=hSqyMB5U2aTjdN3z7M8F0EMj6pRSGgglR68Manes91s97k2bEi+lfNM+C5V6un11DPQTgfHXkRGFCx0I8zi622k0krEhCmbaTBf1KHmVWO2CWJIYj1uDwcHH/QjGJYahRhqInyaMyW4ZdOa+bDc0ZukvPGDbXWvRr91d34vvjaz4whuViVroQT8y5jb3tticO+Dkshm9wvcapnZZ1iVY0k9bSOzKf7c9twdWhdrTxzW34cvYOBGcKJFFpff1u7rxRvjbS41UectPoFy4LFLPMSNR10dM6VtPSM7mHRb+Zklg866HOJaIN5Aj6rAkJt3w6BiKffS247fLvyL7SWzkUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4UI+Td8eue2PWUl764XmnwIdpSUjsrLQmd+fwdyuvZg=;
 b=WcdTiceNvFD1+APRRow1Q4EMtQ2L2bLnSBosKjd6RTiuWK6v8PgUqpeRGBd12GYgWkb0Bjozg4GT3XFkF/gJi7ncVp8CP+h5wel53uXmCqTxMzlxMQQgMmz6mXd38ARDvs8ypcrs4FhRtuD0eQI56Rip/XV3NTu33pVztVulQP82P51smWL5r+dRgWwqrcBJzuXWHP0ztD3TkLUxjIGLjJ5Nkyos9sChNehpqq/EIu2l+NwXSq+0tEMibRLWGSHn4xDkc4/Wk3YoOGi+DIYiQ8tDP5ybD/tLXM8SYrGXPxFstjmccecnwH0jMSTyu3aIxUPjnH9JdUGSSQL6J1U9kg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fa699a9e-b967-2453-c53c-de96c2c1ebcb@suse.com>
Date: Mon, 17 Oct 2022 08:18:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init
To: Julien Grall <julien@xen.org>,
 Stewart Hildebrand <stewart.hildebrand@amd.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <0ade954c-5741-754c-fc59-177feb67ddf4@suse.com>
 <5f985e76-e817-5d44-3463-ffc0a98c407c@xen.org>
 <728f2beb-dc28-9140-0fec-0a67bc49f3f4@amd.com>
 <456e5a86-a875-bc30-cf8b-e4497afc530d@xen.org>
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <456e5a86-a875-bc30-cf8b-e4497afc530d@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8943:EE_
X-MS-Office365-Filtering-Correlation-Id: 6fc01ce4-e666-4d42-0dcc-08dab0076e74
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YqPMhbRlMypLzPDyxRDtlKyhn+zhdvJ5X9HKskJR4yuYEC21fcodQVC6FQx5Op8tllRVz7T9MgUFTajFFRMm8v7IbGtzLyZPMVsbvuGm73dOBHvZrrFMeW9/yNxm3TXQQENbckCji+FxVd6m/E229y7kHJfZMWWE/rIb/5V68ejR/AxVowFeh7YDE8ZJwmLNKoUzL1WZfieLNdQmLEJxr0vHWhkdn1LKzHlqLTuMgmjYCi7slzdX30V9tBF1AyC8GE22FUz9gtUu5rBnqNGXoqVkZ0nkPOgFxEmkm95RkDubpD1TiGPtgYBP+hIu5nnhXjI7ZV1UftZdsa1dYKT0X7XWtWWqPtYdZ7wGjM7qwPNeQN6NxYZhRZPluwPXgTDV+eit1wT5uNeAiv3y5heUjpaebb9QtFkqV2ge+zV0ojmfDDDoENZ9bObqs+w1nV9P5zcePIttV8lNH7X3Si836Kgzy8KeL6LuLYNIMEVdGCfo4fcBxrDdOcv9W9bgNLa/Ntk+tljG2c/Q1qUxje0ZM6LZ5s1oxpor2MvL5cLmPFt/Yvj5m/1tlM71E6vpc3D/bXjedGOydrUPEAvBrAiUJiuwJBFcPDiZHFIaPzggQKiEiHvirWmQ3U6p7kk9WkmbydV42UuE5o0H1URcZBszK66GgjjC98gNtImUXPBYohBUjmmYD4pZOZiLhJ+sSmO8QrtLieVy8pBY/DLqn37Fp4sVFDovCp5uNhZrTl8sKpnrCJICJKUWydbNr96QipmKJ0tlTZzSt/CwdaWRbJAAalYJ3wjgKklVELNVbPTprfw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199015)(36756003)(31686004)(38100700002)(8936002)(5660300002)(83380400001)(31696002)(86362001)(26005)(6512007)(110136005)(54906003)(186003)(2616005)(478600001)(6486002)(316002)(4326008)(66556008)(66476007)(66946007)(41300700001)(8676002)(53546011)(6506007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WWlXdEs5aFBWVEU2ZTVEQkErdlhyWWs1dWRoVG9BVStFKzFsUlllL1YwN0Fn?=
 =?utf-8?B?cU9jRHRYS0ZpOVNidTlUL0NBdURvbW5sc3hvNlY0UW1rYVR2MG5hRUJlVUh2?=
 =?utf-8?B?Z3NVYWNsM3UwMmNmWnRwVU5xWEZEOStYd0U3UDFUTThyeXZhdGM5ZnhMN0FY?=
 =?utf-8?B?ZUVDcHFqTGd2Z1NpSTdXcWM4SlNVaHJjbkhVRDZZOTNxTm1mZXNuTkdLZ09n?=
 =?utf-8?B?M3ROVFlvYlowWU5GUTNEbjdWR1FGYW1HTWNGY1V0NUwwbFFacFF1UHQrV3NX?=
 =?utf-8?B?dHJMN1crQUlzaWc0L0h4UFYybnU0c1cyeno1MVdZSFk5NitjQWI5cjlxVHZX?=
 =?utf-8?B?YzFnQm5oY3ZmQjdweG9VZXhkaTQ4RGNEV0RDcUwrU2lQNENQVDRTbVNIenJQ?=
 =?utf-8?B?MnI2Y1ZxY2lzeWIvTWUyMklLYWhjZmQrSG9tSDYwOXNwVStVMnJOV3N1TThC?=
 =?utf-8?B?T1hDbU1tejJ3N1FBRzlxTVFZenpUcCs1cCtUS3c3VjBxWWlYVXJyOFh3b1lV?=
 =?utf-8?B?T3lwaTROdnF1L2JqSnhZaGxRWlJzeHhUdGtId3pMUjdzQkd3VU5wVGNLcHFp?=
 =?utf-8?B?dDhmTGxSTUhCU24zUStzMFlwV0tmcVpxUldZU1JuUUgyRDdxV1FETjVhVk96?=
 =?utf-8?B?T016cStDYStiNUxDTjgvT3p5Tlc1MjV2YU1nYUFjTVNMUWZXazV1STJvKzU0?=
 =?utf-8?B?djZoQzJSYlpIV1E1OEtPaW1ZYVlNWmdwVVNkMlE2UDVsTEMwS2VSdVBUUjVU?=
 =?utf-8?B?WHY1QlgwR0Izck5HUC9GdXRzcFVvRVVTZnFOKzliRUFIRERSUmJCdHdvbnFs?=
 =?utf-8?B?djVQLzhFMlBMdXpDY3NYaG9PTjkwTGhWRXRSMW1TOEFML2V1S0hac1hlVGo1?=
 =?utf-8?B?eFdDeXRtRUoxYVdZM2lmcTdIOWVFMlFoNS91QUZqM3NGcWZ5MUNPL3J4Q1lB?=
 =?utf-8?B?eXFVMUtSVi9tc2hQeGxqS2FKRmRVZFdSWjJUUHVhT2dkS3BsUmZnM2Jadzh3?=
 =?utf-8?B?VnRSRkxrZzkwSzBtSTRoS0NXTjgzK0hrSHlNTnpCekNENW90MjBrbXJaemM4?=
 =?utf-8?B?bkVXRElOM1dHY1JtdjdiYWhOR2lZRzIyRm15S0d0S3UrTjhBdUdJZE1iUkx6?=
 =?utf-8?B?L09tbVNwY3ZReEJSb2R2aHBScDNxTFU2SmhWUjBvNTROUmsvaU1LVkNvT0RQ?=
 =?utf-8?B?ck5ZMEJEenFFK2NrSnllVVhNWi8xUE5EUVZoTXo4djI4V0NTNG1heHhhSUor?=
 =?utf-8?B?TlZ3TE02d2V6SldtU2JyUWNhaFVpU3oyTUx0WFhwSnY0RTZ0QnorVitFUEJD?=
 =?utf-8?B?dDhrUDgvRG1mcWhGVlVZRjluWnlSUDQ2Kyt1WVgrZU11aE05akNrYng4M1Zp?=
 =?utf-8?B?ellrRFhZeHdNM3Z0aWw2S2Y2eGw2ZVF2K0RTOTN0RWh4SEJyZXJ1OXZLUS80?=
 =?utf-8?B?Qzl0MENOTmI3YkwwSzU3YkVqcm1LOWZTVm90ckhjTEVxM003T2pOM3lPSmZU?=
 =?utf-8?B?WEh0d2p2cjZyc1J6RURjKzA3eGh5aUdDTUs0aXE3YUhFY1oxOXZuZFlqTk04?=
 =?utf-8?B?RTJJbzdJbHRiaE9nYzRYV3IrQXN5VW1vd2RwRGIvemNsZmxXZkp4czdMeFdk?=
 =?utf-8?B?cCtQelFZM3E1NGpLajIyUXdkSTdnN29jOEtJb3d1UG1ZNzBML0RJN1hQa3Ry?=
 =?utf-8?B?NWRuZ0hHMENjd1NSSlV2dEN5S29Vckg5bWdyTC95VkZFQXlsUXMyTXhtVjFk?=
 =?utf-8?B?dWVNbEU4VFI2dkRzZ0FLMUJKdjV5OTJLc29pZzBwbGZlOXdXODF2TzJjNmJ3?=
 =?utf-8?B?M3lROWIvQTFpWW1tK0N0NjhOWE9IY0xlTk1qQ0c3NmhXL0VqM21kQmZ1SGIy?=
 =?utf-8?B?ZnFKZVRUZG5PN2lScDlZTyszNVhNWm1abmxyOGVkdXhBNjRzbzZFdVlGdWFT?=
 =?utf-8?B?WGNTbEZjemd6QWdjYkorcDVCVDc4T1VwSE4vS2kyZFpQQVJLL09NMFliUVRG?=
 =?utf-8?B?QlFBc2ZhVzZzdG5pM05LcGluMllnTWx3eUNUS1VicjhFZHJwK0pxbkUybTgv?=
 =?utf-8?B?Y3ZVUldhSjlDOUhobmIzS1U5WHIzYkFidWRvNDZNeEh1N1g1NUQ5Sk9zSHkw?=
 =?utf-8?Q?PwYleWUh97YPf1YNeEPAhlocW?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc01ce4-e666-4d42-0dcc-08dab0076e74
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 06:18:39.3049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PHoLb8CvsFc39yx6IZK8R3vz+KZW9mp4Qku4Sf3uOGZ0VAYugyC17+VTFhmjhVV8HCJY/kFgXIqSqTTnB7UjHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8943

On 14.10.2022 22:15, Julien Grall wrote:
> On 14/10/2022 20:23, Stewart Hildebrand wrote:
>> arch/arm/efi/boot.c: In function ‘efi_start’:
>> arch/arm/efi/boot.c:1464:9: error: ‘argc’ may be used uninitialized in 
>> this function [-Werror=maybe-uninitialized]
>>   1464 |         efi_arch_handle_cmdline(argc ? *argv : NULL, options, 
>> name.s);
>>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I am a bit puzzled why it warn on this line but not few lines above 
> where it is already used.

Same here. Plus it ought to warn for argv then too, I think.

> This function is a bit difficult to read. AFAIU, the code look like:
> 
> if ( use_cfg_file )
> {
>     argc = ...
> }
> 
> /* do something common */
> 
> if ( use_cfg_file )
>    efi_arch_handle_cmd(argc, ...);
> 
> The GCC with -Og is probably not capable to detect that argc will always 
> be used when 'use_cfg_file'.
> 
> The "do something common" is two lines. So I am tempted to suggest to 
> just duplicate those two lines. This could also allow us to move all the 
> code in the ifs (nearly 100 lines over the two ifs!) in a separate function.
> 
> But I think Jan (the maintainer of the code) may not be happy with 
> that).

Indeed. Even if it's only two statements now, my view is that we ought to
avoid such code duplication.

Further I wonder whether the call to efi_check_dt_boot() shouldn't
actually live in an "else" to the 2nd if(). It would be at least
questionable if parts of the modules were described by the .cfg file and
other parts by DT (which in turn makes assumptions about the relative
placement of those modules wrt xen.efi on the EFI partition, when I'd
expect it to be self-contained).

> So short of a second better suggestion, initializing 'argc' to 0 
> (?) and a comment explaining this is to silence the compiler may be the 
> way to go.

I'd prefer if we avoided that, not the least because this could then trip
(good) static checkers to report written-but-never-used instances. What I
might accept (albeit that doesn't address said concern) is an "else" to
the first if() setting argc and argv (accompanied by a suitable comment,
down the road perhaps including a SAF-<nnn>-false-positive marker).

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 06:21:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 06:21:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424113.671317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okJVM-0004ah-K1; Mon, 17 Oct 2022 06:21:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424113.671317; Mon, 17 Oct 2022 06:21:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okJVM-0004aa-G9; Mon, 17 Oct 2022 06:21:40 +0000
Received: by outflank-mailman (input) for mailman id 424113;
 Mon, 17 Oct 2022 06:21:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okJVL-0004aQ-6i; Mon, 17 Oct 2022 06:21:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okJVL-00086R-39; Mon, 17 Oct 2022 06:21:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okJVK-0006ct-IQ; Mon, 17 Oct 2022 06:21:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okJVK-0005GX-Hz; Mon, 17 Oct 2022 06:21:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=v3KknfqyO1ODVu9yvgGoHkWzDLZzW8JjEH9r0QX7Q50=; b=LWFpWpVpKpBa8x9zYLloWySkqy
	QNeni90n7HDEt7tGyD7v7El5X5NBO+aiGoaaWPdAvY7RKv0DSw/RFOI76ycZmfVURbIwWt9IKgZ5v
	FcnFn75XgWoGR3thRZ81Avnzws+QrNKTy0dVR7lCI6eyYSx+KLIsUN4E0qvAl9pt4+Ho=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173920-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173920: tolerable trouble: fail/pass/starved
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 06:21:38 +0000

flight 173920 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173920/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173812
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173812
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173812
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173812
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173812
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173812
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173812
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173812
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173812
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173812
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173812
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173812
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle   3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173920  2022-10-16 10:24:22 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  starved 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 07:06:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 07:06:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424128.671331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okKCm-0000hM-4Y; Mon, 17 Oct 2022 07:06:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424128.671331; Mon, 17 Oct 2022 07:06:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okKCl-0000hF-WF; Mon, 17 Oct 2022 07:06:32 +0000
Received: by outflank-mailman (input) for mailman id 424128;
 Mon, 17 Oct 2022 07:06:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Rj3b=2S=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1okKCk-0000h7-OY
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 07:06:31 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2083.outbound.protection.outlook.com [40.107.93.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 379042ed-4dea-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 09:06:28 +0200 (CEST)
Received: from DS7PR06CA0025.namprd06.prod.outlook.com (2603:10b6:8:54::31) by
 BL1PR12MB5286.namprd12.prod.outlook.com (2603:10b6:208:31d::6) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.30; Mon, 17 Oct 2022 07:06:24 +0000
Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com
 (2603:10b6:8:54:cafe::24) by DS7PR06CA0025.outlook.office365.com
 (2603:10b6:8:54::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Mon, 17 Oct 2022 07:06:24 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 07:06:24 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct
 2022 02:06:23 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 17 Oct 2022 02:06:21 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 379042ed-4dea-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G5M6on/F5SLfWXjDOV0S84R9UK+GM2ZP1Bk5QeKkGKOXOgfsrkCYHm5/AM0DvmTDgqHXSf0aWO74xug/oet9yrI5oS5u9sznL+19GqYimEZ9IxqNZK6Eb9hpzyQQ49AWxZCD6fuI39vUo06/wzYwLyzBeV1Ic0jdNULA4l3M2YhQ0rigevnFuN0k2GbS8bG6579/rsu6/GXhw3m5ItWKdQvVnSlBVd4zkoZjsPjiUhUMIY3bx2Kb2q1DNqq9EHPY5vGRm2l2Zc5glhv77DIe8NKRIkZ/KNUqj3NNEgbSjui2yzJM+1gJaRfjSmOehtws+Oja2U9yaDqS1pAwkusQnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7r0qS7YFuLWxFPw7XXPeYNjzI0Fwv5ULVPgOadXXCYs=;
 b=MXdtxkprpy7A7mmooQcuq/z3IkBYIZ41S0gNX/OU7fo/rNpojZ9VvQJzPfjaZpR+ZJRple+VwmheY8yX+yu5HenxyJs8upWMYfS4yqa/HkGkcNmdKknFDkK7iHPHwrch7Pv21M9C6GlIjVtfdjKAp7YPcGW+s7KvEJX2nEOgb7k1urkcbZYuSvFueFx2cS1ImfVJhJUGh3xhUqYU7ffZ+25Nqdw7j8uUzWlRAJq4spL6JYSayH9VQ+ELOpX9M+238JXFhfHsagMfouSt/+gRNFC1iiFw9EkiaJqYnRCVslHrG4p2KHlnhnHeTmJza9lA053j4o3+6pAnppkUDuxuVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=minervasys.tech smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7r0qS7YFuLWxFPw7XXPeYNjzI0Fwv5ULVPgOadXXCYs=;
 b=RocuIhQHk2XQyFfz5KcR+/HVkNf3gInlF0tjbqVoszt+Vlfk4DCiR2rJVIu4z5N8zRUFcDz/7aPJK1hRj7Jeo+cq12iCQLSnlgHAHPlSqw0CzkcMrc2uiJMHVkC33M2+LIdUrDvktpa83WOOCxctTrptFXJ0EOfxuyxDpIH77bg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <ff6a5e85-0867-2e22-e173-15805bfc7843@amd.com>
Date: Mon, 17 Oct 2022 09:06:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for
 domains
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
	<xen-devel@lists.xenproject.org>
CC: <andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>,
	<jbeulich@suse.com>, <julien@xen.org>, <stefano.stabellini@amd.com>,
	<wl@xen.org>, <marco.solieri@unimore.it>, <andrea.bastoni@minervasys.tech>,
	<lucmiccio@gmail.com>, Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-7-carlo.nonato@minervasys.tech>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20220826125111.152261-7-carlo.nonato@minervasys.tech>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT014:EE_|BL1PR12MB5286:EE_
X-MS-Office365-Filtering-Correlation-Id: 1fcdbca6-4540-4c6e-3d20-08dab00e1a53
X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zewh0yR3UGnUNEPng4/qzjd6hGfPI4cxJ3TcSBKqDtYZg5/8cGeagwmucNhd/imkA/JoYMqm2q2IFLcYWfgVmd3daBOLG3FMRisfA5d7AOANXBpxPMgumDdMfa6QXj7OKvouwkZ8iocBJwWSVLfyq5p2bVl10hH698kB3lUHrGCnKAgSL/xHmNzqbBVFLaFNVZJV0lRjzP92PeRLjy/dhT++BsiNPfQ1ge4GOLpdnu/sTjCmc3cRyAl+5TTQ++b5tMamEuMwOK1P+O4OyHCHoY3EnCMtxo97OagC9dbE/ZelGMD3umIHpoFtr7AAx3s2UJMEjxInt9Ia4k1FxECfBz0wLXjgIyZP5jDrwCM4OUlVGGAME6BIaPGJfZGC+RXYiNVrDn2/qBnS3LrhuDXl7ljNc9Uu/A3/H/fz9XYLU2aOcZeVccGa4DJyJwibxKA7Fw5XAzEPW3wmSbXRMwpVRxdRWYfY8v2F0LlNHVcnnoUWYKE3DwefcfnVzcUSFE1eBpaoGSvJzV+SnwE1TPjLVoc9KsbdPV7IBZYGViaFgIlp9Mvl/vEF3lYlTVzo15Bq4foW2bG9H5FqD/B4wthaP+Ma/yGIYcwySssGfXnyABE+YDx2CrzLvX/4XprJrYbDSUksuG9ZggwasGF+hJn49lNHsTYR3Thb6YojcLI+syXjrXMRsjC9QMZYKExybNJU4PAnCWCx0ENlMH5aaloDPEnm+ptkwUDKNpU+FXL0AjYVSKNBZzmlBbCuG65tSe1DGRxSE/0F+zWckB1Tu0YpUNDhj1CmPo1zDmGmA7aZTjRKaLFyy7FbtOk4+YFjAqyCotITsAdYBRdurkuu7L6ZaQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(31686004)(478600001)(81166007)(356005)(82740400003)(82310400005)(2616005)(186003)(316002)(16576012)(8676002)(4326008)(54906003)(110136005)(70206006)(70586007)(40460700003)(5660300002)(36756003)(26005)(53546011)(36860700001)(41300700001)(8936002)(7416002)(30864003)(426003)(86362001)(40480700001)(44832011)(2906002)(31696002)(47076005)(83380400001)(336012)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 07:06:24.3415
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fcdbca6-4540-4c6e-3d20-08dab00e1a53
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT014.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5286

Hi Carlo,

On 26/08/2022 14:51, Carlo Nonato wrote:

> 
> This commit adds a new memory page allocator that implements the cache
> coloring mechanism. The allocation algorithm follows the given color
> configuration of the domain and maximizes contiguity in the page selection.
> 
> Pages are stored in a color-indexed data structure of lists, sorted by their
> machine addresses, that are collectively called the colored heap. A simple
> initialization function computes the color of any available page and inserts
> it in the corresponding list. When a domain requests a page, the allocator
> takes one from the subset of lists whose colors equals the domain
> configuration. It chooses the page with the highest machine address such that
> contiguous pages are sequentially allocated, if this is made possible by a
> color assignment which includes adjacent colors.
> 
> The allocator can handle only requests with order equals to 0 since the
> single color granularity is represented in memory by one page.
> 
> The buddy allocator must coexist with the colored one because the Xen heap
> isn't colored. For this reason a new Kconfig option and a command line
> parameter are added to let the user set the amount of memory reserved for
> the buddy allocator. Even when cache coloring is enabled, this memory isn't
> managed by the colored allocator.
> 
> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> ---
>  docs/misc/arm/cache-coloring.rst    |  43 +++++-
>  docs/misc/xen-command-line.pandoc   |  14 ++
>  xen/arch/arm/Kconfig                |  12 ++
>  xen/arch/arm/coloring.c             |  10 ++
>  xen/arch/arm/include/asm/coloring.h |   6 +
>  xen/arch/arm/include/asm/mm.h       |   3 +
>  xen/common/page_alloc.c             | 213 ++++++++++++++++++++++++++--
>  7 files changed, 290 insertions(+), 11 deletions(-)
> 
> diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
> index 763acd2d3f..5f9132e525 100644
> --- a/docs/misc/arm/cache-coloring.rst
> +++ b/docs/misc/arm/cache-coloring.rst
> @@ -13,6 +13,9 @@ In order to enable and use it, few steps are needed.
>    (refer to menuconfig help for value meaning and when it should be changed).
> 
>          CONFIG_MAX_CACHE_COLORS=<n>
> +- If needed, change the amount of memory reserved for the buddy allocator either
> +  from the Xen configuration file, via the CONFIG_BUDDY_ALLOCATOR_SIZE value,
> +  or with the command line option. See `Colored allocator and buddy allocator`.
>  - Assign colors to domains using the `Color selection format`_ (see
>    `Coloring parameters`_ for more documentation pointers).
> 
> @@ -157,4 +160,42 @@ Please refer to the relative documentation in
>  "docs/misc/arm/device-tree/booting.txt".
> 
>  Note that if no color configuration is provided for domains, they fallback to
> -the default one, which corresponds simply to all available colors.
> \ No newline at end of file
> +the default one, which corresponds simply to all available colors.
> +
> +Colored allocator and buddy allocator
> +*************************************
> +
> +The colored allocator distributes pages based on color configurations of
> +domains so that each domains only gets pages of its own colors.
> +The colored allocator is meant as an alternative to the buddy allocator because
> +its allocation policy is by definition incompatible with the generic one. Since
> +the Xen heap systems is not colored yet, we need to support the coexistence of
> +the two allocators and some memory must be left for the buddy one.
> +The buddy allocator memory can be reserved from the Xen configuration file or
> +with the help of a command-line option.
> +
> +Known issues and limitations
> +****************************
> +
> +Colored allocator can only make use of order-0 pages
> +####################################################
> +
> +The cache coloring technique relies on memory mappings and on the smallest
> +amount of memory that can be mapped to achieve the maximum number of colors
> +(cache partitions) possible. This amount is what is normally called a page and,
> +in Xen terminology, the order-0 page is the smallest one. The fairly simple
> +colored allocator currently implemented, makes use only of such pages.
> +It must be said that a more complex one could, in theory, adopt higher order
> +pages if the colors selection contained adjacent colors. Two subsequent colors,
> +for example, can be represented by a order-1 page, four colors correspond to
> +a order-2 pages, etc.
> +
> +Fail to boot colored DomUs with large memory size
> +#################################################
> +
> +If the Linux kernel used for Dom0 does not contain the upstream commit
> +3941552aec1e04d63999988a057ae09a1c56ebeb and uses the hypercall buffer device,
> +colored DomUs with memory size larger then 127 MB cannot be created. This is
> +caused by the default limit of this buffer of 64 pages. The solution is to
> +manually apply the above patch, or to check if there is an updated version of
> +the kernel in use for Dom0 that contains this change.
> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
> index 910ebeb2eb..4e85c4dfe4 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -299,6 +299,20 @@ can be maintained with the pv-shim mechanism.
>      cause Xen not to use Indirect Branch Tracking even when support is
>      available in hardware.
> 
> +### buddy-alloc-size (arm64)
> +> `= <size>`
> +
> +> Default: `64M`
> +
> +Amount of memory reserved for the buddy allocator when colored allocator is
> +active. This options is parsed only when cache coloring support is enabled.
> +The colored allocator is meant as an alternative to the buddy allocator,
> +because its allocation policy is by definition incompatible with the
> +generic one. Since the Xen heap systems is not colored yet, we need to
> +support the coexistence of the two allocators for now. This parameter, which is
> +optional and for expert only, it's used to set the amount of memory reserved to
> +the buddy allocator.
> +
>  ### clocksource (x86)
>  > `= pit | hpet | acpi | tsc`
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 8acff9682c..abce4bfc25 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -147,6 +147,18 @@ config MAX_CACHE_COLORS
>           colors at boot. Note that if, at any time, a color configuration with more
>           colors than the maximum will be employed an error will be produced.
> 
> +config BUDDY_ALLOCATOR_SIZE
> +       string "Buddy allocator reserved memory size" if CACHE_COLORING
> +       default "64M" if CACHE_COLORING
> +       default "0M" if !CACHE_COLORING
> +       help
> +         Amount of memory reserved for the buddy allocator to work alongside
> +         the colored one. The colored allocator is meant as an alternative to the
> +         buddy allocator because its allocation policy is by definition
> +         incompatible with the generic one. Since the Xen heap systems is not
> +         colored yet, we need to support the coexistence of the two allocators and
> +         some memory must be left for the buddy one.
> +
>  config TEE
>         bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED
>         default n
> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
> index 87e20b952e..3fb86043d1 100644
> --- a/xen/arch/arm/coloring.c
> +++ b/xen/arch/arm/coloring.c
> @@ -300,6 +300,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config,
>      config->num_colors = (uint16_t)num;
>  }
> 
> +unsigned int page_to_color(struct page_info *pg)
> +{
> +    return addr_to_color(page_to_maddr(pg));
> +}
> +
> +unsigned int get_max_colors(void)
> +{
> +    return max_colors;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
> index b7fa323870..0982bc9853 100644
> --- a/xen/arch/arm/include/asm/coloring.h
> +++ b/xen/arch/arm/include/asm/coloring.h
> @@ -29,6 +29,8 @@
> 
>  #include <public/arch-arm.h>
> 
> +struct page_info;
> +
>  bool __init coloring_init(void);
> 
>  int domain_coloring_init(struct domain *d,
> @@ -39,4 +41,8 @@ void domain_dump_coloring_info(struct domain *d);
>  void prepare_color_domain_config(struct xen_arch_domainconfig *config,
>                                   const char *colors_str);
> 
> +unsigned int page_to_color(struct page_info *pg);
> +
> +unsigned int get_max_colors(void);
> +
>  #endif /* !__ASM_ARM_COLORING_H__ */
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index da25251cda..a59fc3791a 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -143,6 +143,9 @@ struct page_info
>  #define PGC_count_width   PG_shift(10)
>  #define PGC_count_mask    ((1UL<<PGC_count_width)-1)
> 
> +#define _PGC_colored      PG_shift(11)
> +#define PGC_colored       PG_mask(1, 11)
> +
>  /*
>   * Page needs to be scrubbed. Since this bit can only be set on a page that is
>   * free (i.e. in PGC_state_free) we can reuse PGC_allocated bit.
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index bfd4150be7..4ae3cfe9a7 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -150,6 +150,9 @@
>  #define p2m_pod_offline_or_broken_hit(pg) 0
>  #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL)
>  #endif
> +#ifdef CONFIG_CACHE_COLORING
> +#include <asm/coloring.h>
> +#endif
> 
>  #ifndef PGC_static
>  #define PGC_static 0
> @@ -231,6 +234,9 @@ static bool __read_mostly scrub_debug;
>  #define scrub_debug    false
>  #endif
> 
> +/* Memory required for buddy allocator to work with colored one */
> +static unsigned long __initdata buddy_alloc_size;
> +
>  /*
>   * Bit width of the DMA heap -- used to override NUMA-node-first.
>   * allocation strategy, which can otherwise exhaust low memory.
> @@ -440,7 +446,172 @@ mfn_t __init alloc_boot_pages(unsigned long nr_pfns, unsigned long pfn_align)
>      BUG();
>  }
> 
> +static DEFINE_SPINLOCK(heap_lock);
> 
> +/* Initialise fields which have other uses for free pages. */
> +static void init_free_page_fields(struct page_info *pg)
> +{
> +    pg->u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
> +    page_set_owner(pg, NULL);
> +}
> +
> +static bool is_page_colored(struct page_info *pg)
> +{
> +    return pg->count_info & PGC_colored;
> +}
> +
> +#ifdef CONFIG_CACHE_COLORING
> +/*************************
> + * COLORED SIDE-ALLOCATOR
> + *
> + * Pages are stored by their color in separate lists. Each list defines a color
> + * and it is initialized during end_boot_allocator, where each page's color
> + * is calculated and the page itself is put in the correct list.
> + * After initialization there will be N lists where N is the number of maximum
> + * available colors on the platform.
> + */
> +typedef struct page_list_head colored_pages_t;
> +static colored_pages_t __ro_after_init *color_heap;
> +
> +#define colored_pages(color) &color_heap[(color)]
> +
> +static void color_heap_insert_page(struct page_info *pg)
> +{
> +    struct page_info *pos;
> +    struct page_list_head *head = colored_pages(page_to_color(pg));
> +
> +    pg->count_info |= PGC_colored;
> +
> +    /* Insert page in list in ascending machine address order */
> +    page_list_for_each( pos, head )
> +    {
> +        if ( page_to_maddr(pos) < page_to_maddr(pg) )
> +        {
> +            head = &pos->list;
> +            break;
> +        }
> +    }
> +
> +    page_list_add_tail(pg, head);
> +}
> +
> +static void color_heap_remove_page(struct page_info *pg)
> +{
> +    page_list_del(pg, colored_pages(page_to_color(pg)));
> +}
> +
> +static void __init init_col_heap_pages(struct page_info *pg,
> +                                       unsigned long nr_pages)
> +{
> +    unsigned int i;
> +
> +    if ( !color_heap )
> +    {
> +        unsigned int max_colors = get_max_colors();
> +        color_heap = xmalloc_array(colored_pages_t, max_colors);
> +        BUG_ON(!color_heap);
> +
> +        for ( i = 0; i < max_colors; i++ )
> +            INIT_PAGE_LIST_HEAD(colored_pages(i));
> +
> +        if ( !buddy_alloc_size )
> +            buddy_alloc_size = parse_size_and_unit(CONFIG_BUDDY_ALLOCATOR_SIZE,
> +                                                   NULL);
> +    }
> +
> +    printk(XENLOG_INFO "Init color heap with %lu pages\n", nr_pages);
> +    printk(XENLOG_INFO "Paging starting from: 0x%"PRIx64"\n",
> +           page_to_maddr(pg));
> +
> +    for ( i = 0; i < nr_pages; i++ )
> +        color_heap_insert_page(pg++);
> +}
> +
> +/* Alloc one page based on domain color configuration */
> +static struct page_info *alloc_col_heap_page(unsigned int memflags,
> +                                             const unsigned int *colors,
> +                                             unsigned int num_colors)
> +{
> +    struct page_info *pg = NULL;
> +    unsigned int i;
> +    bool need_tlbflush = false;
> +    uint32_t tlbflush_timestamp = 0;
> +
> +    spin_lock(&heap_lock);
> +
> +    for ( i = 0; i < num_colors; i++ )
> +    {
> +        struct page_info *tmp;
> +
> +        if ( page_list_empty(colored_pages(colors[i])) )
> +            continue;
> +
> +        tmp = page_list_first(colored_pages(colors[i]));
> +        if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) )
> +            pg = tmp;
> +    }
> +
> +    if ( !pg )
> +    {
> +        spin_unlock(&heap_lock);
> +        return NULL;
> +    }
> +
> +    pg->count_info = PGC_state_inuse;
> +
> +    if ( !(memflags & MEMF_no_tlbflush) )
> +        accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp);
> +
> +    init_free_page_fields(pg);
> +    flush_page_to_ram(mfn_x(page_to_mfn(pg)),
> +                      !(memflags & MEMF_no_icache_flush));
> +    color_heap_remove_page(pg);
> +
> +    spin_unlock(&heap_lock);
> +
> +    if ( need_tlbflush )
> +        filtered_flush_tlb_mask(tlbflush_timestamp);
> +
> +    return pg;
> +}
> +
> +static void free_col_domheap_page(struct page_info *pg)
> +{
> +    pg->count_info = PGC_state_free;
> +    page_set_owner(pg, NULL);
> +    color_heap_insert_page(pg);
> +}
> +
> +static struct page_info *alloc_col_domheap_page(struct domain *d,
> +                                                unsigned int memflags)
> +{
> +    struct page_info *pg;
> +
> +    ASSERT(!in_irq());
> +
> +    pg = alloc_col_heap_page(memflags, d->arch.colors, d->arch.num_colors);
> +    if ( !pg )
> +    {
> +        printk(XENLOG_ERR "Colored page is null for domain %pd\n", d);
> +        return NULL;
> +    }
> +
> +    if ( d && !(memflags & MEMF_no_owner) && assign_page(pg, 0, d, memflags) )
> +    {
> +        free_col_domheap_page(pg);
> +        return NULL;
> +    }
> +
> +    return pg;
> +}
> +
> +size_param("buddy-alloc-size", buddy_alloc_size);
> +#else
> +static void free_col_domheap_page(struct page_info *pg)
> +{
> +    return;
> +}
> +#endif /* CONFIG_CACHE_COLORING */
> 
>  /*************************
>   * BINARY BUDDY ALLOCATOR
> @@ -462,7 +633,6 @@ static unsigned long node_need_scrub[MAX_NUMNODES];
>  static unsigned long *avail[MAX_NUMNODES];
>  static long total_avail_pages;
> 
> -static DEFINE_SPINLOCK(heap_lock);
>  static long outstanding_claims; /* total outstanding claims by all domains */
> 
>  unsigned long domain_adjust_tot_pages(struct domain *d, long pages)
> @@ -1027,10 +1197,7 @@ static struct page_info *alloc_heap_pages(
>              accumulate_tlbflush(&need_tlbflush, &pg[i],
>                                  &tlbflush_timestamp);
> 
> -        /* Initialise fields which have other uses for free pages. */
> -        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
> -        page_set_owner(&pg[i], NULL);
> -
> +        init_free_page_fields(&pg[i]);
>      }
> 
>      spin_unlock(&heap_lock);
> @@ -1926,6 +2093,7 @@ static unsigned long avail_heap_pages(
>  void __init end_boot_allocator(void)
>  {
>      unsigned int i;
> +    unsigned long buddy_pages = PFN_DOWN(buddy_alloc_size);
> 
>      /* Pages that are free now go to the domain sub-allocator. */
>      for ( i = 0; i < nr_bootmem_regions; i++ )
> @@ -1939,11 +2107,24 @@ void __init end_boot_allocator(void)
>              break;
>          }
>      }
> -    for ( i = nr_bootmem_regions; i-- > 0; )
> +
> +    for ( i = 0; i < nr_bootmem_regions; i++ )
>      {
>          struct bootmem_region *r = &bootmem_region_list[i];
> +
> +        if ( buddy_pages && (r->s < r->e) )
> +        {
> +            unsigned long pages = MIN(r->e - r->s, buddy_pages);
> +            init_heap_pages(mfn_to_page(_mfn(r->s)), pages);

When cache coloring is enabled we have 2 allocators: colored and buddy.
The amount of memory for buddy allocator comes from the config (64MB by default).
So what about the first block of code at the beginning of end_boot_allocator
that calls init_heap_pages for the first free boot memory region?
There are two issues:
1. Buddy will end up having the buddy_pages + pages from the first free bootmem region.
   This is already incorrect as buddy should have the amount of memory set by the user.
2. Allowing the first free memory bank to go to buddy without imposing any restrictions
   on the size, can significantly lower the amount of memory available to colored allocator.
   If we load the images near the end of memory bank, the first free region can actually
   occupy most of the system memory and lead to issues with not enough colored memory for domains allocations.

I cannot see a reason for you to use that block of code. Before your series there was a split
to prefer allocations from higher memory with the exception of inserting one region residing on
the boot CPU node first (4280d3ee4cb1). Because your series modifies this behavior to prefer allocations
from lower memory in ascending order (and also allowing user to set a buddy size) I think this block
of code should not be executed when cache coloring is enabled.


Apart from that, the memory coming from the buddy is of any color. Shouldn't it be that the memory
allocated for domains comes from colored memory of the colors assigned to them and anything else
should come from colors given to Xen? At the moment, the memory for e.g. allocating P2M tables comes
from the buddy which means it can be of any color and might cause some cache interference.


~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 07:07:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 07:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424133.671342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okKDq-0001Fx-Dd; Mon, 17 Oct 2022 07:07:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424133.671342; Mon, 17 Oct 2022 07:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okKDq-0001Fq-9h; Mon, 17 Oct 2022 07:07:38 +0000
Received: by outflank-mailman (input) for mailman id 424133;
 Mon, 17 Oct 2022 07:07:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=qIJJ=2S=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1okKDo-0001Fe-Kd
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 07:07:36 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6014e15a-4dea-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 09:07:35 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EB268225E8;
 Mon, 17 Oct 2022 07:07:34 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C0B7A13398;
 Mon, 17 Oct 2022 07:07:34 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LS1KLTb/TGN3bgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 17 Oct 2022 07:07:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6014e15a-4dea-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1665990454; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=nQWbV7dO/f2Ds+mzbc1CPb/Q/HnPyC/nUshCSTjfA7Q=;
	b=i6parxQi0WD1x3prQGQmwYRGOeCpqX/4q98IyhOqunc9dkE1tk5+EUsZZCs/EUrUvifQzW
	6+zKuyes22DFvvcG6F/HgeQdDOplUNwmWH/wFxvI1YMk/6bXrKoGC1WKKc+03ky23ssDBR
	W41GYNVgF10wcuNtB/AEKzk+5t8nlnE=
Message-ID: <4907e079-0001-dbc6-dbfc-ee737882fc4c@suse.com>
Date: Mon, 17 Oct 2022 09:07:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>, boris.ostrovsky@oracle.com
Cc: jbeulich@suse.com, xen-devel@lists.xenproject.org,
 JESHWANTHKUMAR.NK@amd.com
References: <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop>
From: Juergen Gross <jgross@suse.com>
Subject: Re: privcmd.c not calling set_phys_to_machine
In-Reply-To: <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------RYqb83ORAVnLa2hZ9SVFf6PQ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------RYqb83ORAVnLa2hZ9SVFf6PQ
Content-Type: multipart/mixed; boundary="------------qxAfc9fn6JjaOdIpkrrK0eY7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>, boris.ostrovsky@oracle.com
Cc: jbeulich@suse.com, xen-devel@lists.xenproject.org,
 JESHWANTHKUMAR.NK@amd.com
Message-ID: <4907e079-0001-dbc6-dbfc-ee737882fc4c@suse.com>
Subject: Re: privcmd.c not calling set_phys_to_machine
References: <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop>

--------------qxAfc9fn6JjaOdIpkrrK0eY7
Content-Type: multipart/mixed; boundary="------------CFzExf8Cj4r3aK3j2rfsB2J7"

--------------CFzExf8Cj4r3aK3j2rfsB2J7
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTQuMTAuMjIgMjM6MDQsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gSGkgSnVl
cmdlbiBhbmQgYWxsLA0KPiANCj4gSSBhbSB3cml0aW5nIGFnYWluIHRvIGFzayBhIHF1ZXN0
aW9uIGFib3V0IHByaXZjbWQuYyBpbiBQViBkb20wIHg4Ni4NCj4gVGhpcyBpcyByZWxhdGVk
IHRvIHRoZSBwcmV2aW91cyBwaW5fdXNlcl9wYWdlc19mYXN0IGlzc3VlOg0KPiANCj4gaHR0
cHM6Ly9tYXJjLmluZm8vP2w9eGVuLWRldmVsJm09MTY2MjY4OTE0NzI3NjMwDQo+IGh0dHBz
Oi8vbWFyYy5pbmZvLz9sPXhlbi1kZXZlbCZtPTE2NjMyMjM4NTkxMjA1Mg0KPiANCj4gDQo+
IEluIHN1bW1hcnkgdGhpcyBpcyB0aGUgc2l0dWF0aW9uOg0KPiANCj4gMS4gZG9tVSAoSFZN
KSBrZXJuZWwgc3BhY2U6DQo+ICAgICAgYS4gcGFnZXMgYWxsb2NhdGlvbiB3aXRoIGdldF9m
cmVlX3BhZ2VzKCkNCj4gICAgICBiLiBnZXQgZG1hX2hhbmRsZSBieSBjYWxsaW5nIGRtYV9t
YXBfcGFnZSgpIG9uIHRoZSBwYWdlcyBhbGxvY2F0ZWQgaW4gKDEuYSkNCj4gICAgICBjLiBz
ZW5kIGRtYV9oYW5kbGUgdG8gZG9tMCAoUFYpIHVzaW5nIHZpcnRpbyBxdWV1ZQ0KPiANCj4g
Mi4gZG9tMCB1c2Vyc3BhY2UgKFFFTVUpOg0KPiAgICAgICAgICBhLiByZWFkIGRtYV9oYW5k
bGUgZnJvbSB2aXJ0aW8gcXVldWUNCj4gICAgICAgICAgYi4gbWFwIGRtYV9oYW5kbGUgdXNp
bmcgUUVNVSBkbWFfbWVtb3J5X21hcCgpLCB3aGljaCBjYWxscw0KPiAgICAgICAgICAgICB4
ZW5mb3JlaWdubWVtb3J5X21hcDIsIHdoaWNoIGlzIElPQ1RMX1BSSVZDTURfTU1BUEJBVENI
X1YyLA0KPiAgICAgICAgICAgICB3aGljaCBlbmRzIHVwIGNhbGxpbmcgZHJpdmVycy94ZW4v
cHJpdmNtZC5jOnByaXZjbWRfaW9jdGxfbW1hcF9iYXRjaA0KPiAgICAgICAgICAgICBbdGhp
cyBpcyB2ZXJpZmllZCB0byB3b3JrIGNvcnJlY3RseSwgdGhlIG1hcHBpbmcgd29ya3NdDQo+
ICAgICAgICAgIGMuIG9wZW4gL2Rldi90ZWUgbm9kZSBhbmQgbWFrZSBhbiBpb2N0bCBjYWxs
IHRvIHJlZ2lzdGVyIHRoZQ0KPiAgICAgICAgICAgICB2aXJ0dWFsIGFkZHJlc3MgKGZyb20g
c3RlcCAyLmIpIHdpdGggVEVFLg0KPiANCj4gMy4gZG9tMCBrZXJuZWwgc3BhY2U6DQo+ICAg
ICAgICAgIGEuIEFNRCBURUUgZHJpdmVyIGdldCB0aGUgdmlydHVhbCBhZGRyZXNzIHBhc3Nl
ZCBieSB1c2Vyc3BhY2UNCj4gICAgICAgICAgYi4gQU1EIFRFRSBkcml2ZXIgZ2V0IHRoZSBs
aXN0IG9mIHBhZ2VzIGNvcnJlc3BvbmRpbmcgdG8gdGhlDQo+ICAgICAgICAgICAgIHZpcnR1
YWwgYWRkcmVzcyAoMy5hKSBhbmQgY2FsbHMgZG1hX21hcF9wYWdlKCkgb24gdGhlbQ0KDQpJ
J20gcmF0aGVyIHN1cmUgIkFNRCBURUUgZHJpdmVyIGdldCB0aGUgbGlzdCBvZiBwYWdlcyBj
b3JyZXNwb25kaW5nIHRvIHRoZQ0KdmlydHVhbCBhZGRyZXNzIiBpcyB0aGUgcHJvYmxlbS4g
VGhlIFBURXMgc2hvdWxkIGhhdmUgdGhlICJzcGVjaWFsIiBmbGFnDQpzZXQsIG1lYW5pbmcg
dGhhdCB0aGVyZSBpcyBubyBzdHJ1Y3QgcGFnZSBhc3NvY2lhdGVkIHdpdGggdGhpcyB2aXJ0
dWFsIGFyZWEuDQoNCj4gVGhlIGxhc3Qgc3RlcCAoMy5iKSBtaXNiZWhhdmVzIGFzIGRldl9h
ZGRyIGF0IHRoZSBiZWdpbm5pbmcgb2YNCj4geGVuX3N3aW90bGJfbWFwX3BhZ2UgKHdoaWNo
IGltcGxlbWVudHMgZG1hX21hcF9wYWdlKCkgaW4gZG9tKSkgaXMgMC4NCj4gDQo+ICAgIGRt
YV9hZGRyX3QgZGV2X2FkZHIgPSB4ZW5fcGh5c190b19kbWEoZGV2LCBwaHlzKTsNCj4gICAg
LyogZGV2X2FkZHIgaGVyZSBpcyB6ZXJvICovDQo+IA0KPiANCj4gQ291bGQgaXQgYmUgdGhh
dCB0aGUgb3JpZ2luYWwgbWFwcGluZyBvZiB0aGUgZm9yZWlnbiBwYWdlcyBpbiBEb20wLCBk
b25lDQo+IGJ5IHN0ZXAgMi5iLCBpcyBub3QgY29tcGxldGU/IExvb2tpbmcgaW50bw0KPiBw
cml2Y21kX2lvY3RsX21tYXBfYmF0Y2gsIGZvciBQViBndWVzdHMsIGl0IGlzIGNhbGxpbmcg
bW1hcF9iYXRjaF9mbjoNCj4gDQo+IAlCVUdfT04odHJhdmVyc2VfcGFnZXNfYmxvY2sobS5u
dW0sIHNpemVvZih4ZW5fcGZuX3QpLA0KPiAJCQkJICAgICZwYWdlbGlzdCwgbW1hcF9iYXRj
aF9mbiwgJnN0YXRlKSk7DQo+IA0KPiBtbWFwX2JhdGNoX2ZuIGNhbGxzIHhlbl9yZW1hcF9k
b21haW5fZ2ZuX2FycmF5LCB3aGljaCBjYWxscw0KPiB4ZW5fcmVtYXBfcGZuLg0KPiANCj4g
eGVuX3JlbWFwX3BmbiBvbmx5IGNoYW5nZXMgdGhlIFZBLT5QQSBtYXBwaW5nIGFuZCBkb2Vz
IG5vdGhpbmcgZWxzZS4NCj4gU3BlY2lmaWNhbGx5LCBub2JvZHkgc2VlbXMgdG8gY2FsbCBz
ZXRfcGh5c190b19tYWNoaW5lIGluIHRoaXMgY29kZQ0KPiBwYXRoLiBJc24ndCBzZXRfcGh5
c190b19tYWNoaW5lIHJlcXVpcmVkPw0KDQpOb3QgZm9yIHNwZWNpYWwgbWVtb3J5IHBhZ2Vz
Lg0KDQo+IERvbid0IHdlIG5lZWQgYSBjYWxsIHRvIHNldF9waHlzX3RvX21hY2hpbmUgc28g
dGhhdCB0aGUgbmV4dCB0aW1lIGENCj4gZHJpdmVyIHRyaWVzIHRvIGNhbGw6DQo+IA0KPiAg
ICAvKiBhZGRyZXNzIGlzIHRoZSB2aXJ0dWFsIGFkZHJlc3MgcGFzc2VkIGJ5IFFFTVUgdXNl
cnNwYWNlICovDQo+ICAgIGRtYV9tYXBfcGFnZSh2aXJ0X3RvX3BhZ2UoYWRkcmVzcykpDQo+
IA0KPiBpdCB3aWxsIGJlaGF2ZSBjb3JyZWN0bHk/IE9yIGFtIEkgbWlzc2luZyBzb21ldGhp
bmc/DQo+IA0KPiANCj4gSG93IGlzIHhlbl9waHlzX3RvX2RtYSBleHBlY3RlZCB0byB3b3Jr
IGNvcnJlY3RseSBmb3I6DQo+IA0KPiAgICAvKiBhZGRyZXNzIGlzIHRoZSB2aXJ0dWFsIGFk
ZHJlc3MgcGFzc2VkIGJ5IFFFTVUgdXNlcnNwYWNlIGFuZCBtYXBwZWQNCj4gICAgICogaW4g
Mi5iICovDQo+ICAgIHBoeXNfYWRkciA9IHZpcnRfdG9fcGh5cyhhZGRyZXNzKTsNCj4gICAg
eGVuX3BoeXNfdG9fZG1hKGRldiwgcGh5c19hZGRyKTsNCj4gDQo+IA0KPiBNeSBndWVzcyB3
b3VsZCBiZSB0aGF0IHdlIG5lZWQgdG8gYWRkOg0KPiANCj4gICAgc2V0X3BoeXNfdG9fbWFj
aGluZShwZm4sIEZPUkVJR05fRlJBTUUobWZuKSk7DQo+IA0KPiBpbiBtbWFwX2JhdGNoX2Zu
IG9yIHhlbl9yZW1hcF9wZm4/DQoNCkkgdGhpbmsgdGhpcyBtaWdodCBiZSBhIGxpdHRsZSBi
aXQgbW9yZSBjb21wbGljYXRlZC4NCg0KVGhpcyBjb3VsZCB3b3JrLCBpZiB0aGVyZSBpcyBy
ZWFsbHkgYSBzdHJ1Y3QgcGFnZSBhdmFpbGFibGUgZm9yIHRoZSBQRk4uDQpPVE9IIHRoaXMg
bWlnaHQgYmUgbm90IHRoZSBjYXNlIHF1aXRlIG9mdGVuLCBhcyB3ZSBhcmUgdXNpbmcgem9u
ZSBkZXZpY2UNCm1lbW9yeSBmb3IgZm9yZWlnbiBtYXBwaW5ncyBwZXIgZGVmYXVsdCBmb3Ig
c29tZSB0aW1lIG5vdy4NCg0KU29sdmluZyB0aGlzIG1pZ2h0IHJlcXVpcmUgc29tZXRoaW5n
IGxpa2UgZG1hX21hcF9wZm4oKSBpbnN0ZWFkIG9mDQpkbWFfbWFwX3BhZ2UoKSwgd2hpY2gg
c291bmRzIGEgbGl0dGxlIGJpdCBsaWtlIGRtYV9kaXJlY3RfbW1hcCgpLg0KDQoNCkp1ZXJn
ZW4NCg==
--------------CFzExf8Cj4r3aK3j2rfsB2J7
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------CFzExf8Cj4r3aK3j2rfsB2J7--

--------------qxAfc9fn6JjaOdIpkrrK0eY7--

--------------RYqb83ORAVnLa2hZ9SVFf6PQ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNM/zYFAwAAAAAACgkQsN6d1ii/Ey+g
UwgAkeN0SYgJkBog5nzIlrdh/sI14PXIHal9BHTsATZ8W9HYe+BjcpCaLPZXJQTotthO7R1vSWVb
foi+JU8u+0KBJ7v5XCQKJO1t5NeJow0fh6RZC7qa0dKSKDR+hzotlLi0OjSFzCDwzLD0E+kJlm2M
TEiRIUezw/Gqa8kAEKAp5kOk8tZsM/bMAmQ3sSZSbr4S1jO/xt9khTZknP4zS2KtGUBCoju8Fi/5
aayYk+dfIh3hebikpKEITRiiIIRSWEi7rnN9Po8mZFCaSpymd81Ee6UbByDAD7WJ34MLQDr0y+DX
WBhLI4zJcodW18bH0OX73GGAUoulOkP38zDOyFpLHA==
=zugx
-----END PGP SIGNATURE-----

--------------RYqb83ORAVnLa2hZ9SVFf6PQ--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 07:46:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 07:46:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424144.671356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okKpW-0005cK-Gg; Mon, 17 Oct 2022 07:46:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424144.671356; Mon, 17 Oct 2022 07:46:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okKpW-0005cD-D1; Mon, 17 Oct 2022 07:46:34 +0000
Received: by outflank-mailman (input) for mailman id 424144;
 Mon, 17 Oct 2022 07:46:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okKpU-0005c7-F9
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 07:46:32 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id cec7af96-4def-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 09:46:28 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B11471042;
 Mon, 17 Oct 2022 00:46:33 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 30E433F792;
 Mon, 17 Oct 2022 00:46:24 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cec7af96-4def-11ed-91b4-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Date: Mon, 17 Oct 2022 07:46:18 +0000
Message-Id: <20221017074618.36818-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
which requires 6 P2M pages as the two pages will be consecutive but not
necessarily in the same L3 page table and keep a buffer, populate 16
pages as the default value to the P2M pages pool in arch_domain_create()
at the domain creation stage to satisfy the GICv2 requirement. For
GICv3, the above-mentioned P2M mapping is not necessary, but since the
allocated 16 pages here would not be lost, hence populate these pages
unconditionally.

With the default 16 P2M pages populated, there would be a case that
failures would happen in the domain creation with P2M pages already in
use. To properly free the P2M for this case, firstly support the
optionally preemption of p2m_teardown(), then call p2m_teardown() and
p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
As non-preemptive p2m_teardown() should only return 0, use a
BUG_ON to confirm that.

Since p2m_final_teardown() is called either after
domain_relinquish_resources() where relinquish_p2m_mapping() has been
called, or from failure path of domain_create()/arch_domain_create()
where mappings that require p2m_put_l3_page() should never be created,
relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
in-code comments to refer this.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
This should also be backported to 4.13, 4.14, 4.15 and 4.16.
v3 changes:
- Move the population of default pages to p2m_init().
- Use a loop over p2m_teardown_allocation() to implement the
  non-preemptive p2m_teardown_allocation() and avoid open-coding.
- Reorder assertions in p2m_final_teardown().
- Add p2m_teardown() will always return 0 if called non-preemptively in
  doc, move the page_list_empty(&p2m->pages) check to p2m_teardown()
  and use a BUG_ON to confirm p2m_teardown() will return 0 in
  p2m_final_teardown().
- Add a comment in p2m_final_teardown() to mention relinquish_p2m_mapping()
  does not need to be called, also update commit message.
v2 changes:
- Move the p2m_set_allocation(d, 0, NULL); to p2m_final_teardown().
- Support optionally preemption of p2m_teardown(), and make the calling of
  p2m_teardown() preemptively when relinquish the resources, non-preemptively
  in p2m_final_teardown().
- Refactor the error handling to make the code use less spin_unlock.
- Explain the worst case of page tables and the unconditional population
  of pages in commit message.
- Mention the unconditional population of pages in in-code comment.
---
 xen/arch/arm/domain.c          |  2 +-
 xen/arch/arm/include/asm/p2m.h | 14 ++++++++++----
 xen/arch/arm/p2m.c             | 34 ++++++++++++++++++++++++++++++++--
 3 files changed, 43 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2c84e6dbbb..38e22f12af 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1064,7 +1064,7 @@ int domain_relinquish_resources(struct domain *d)
             return ret;
 
     PROGRESS(p2m):
-        ret = p2m_teardown(d);
+        ret = p2m_teardown(d, true);
         if ( ret )
             return ret;
 
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index 42bfd548c4..c8f14d13c2 100644
--- a/xen/arch/arm/include/asm/p2m.h
+++ b/xen/arch/arm/include/asm/p2m.h
@@ -194,14 +194,18 @@ int p2m_init(struct domain *d);
 
 /*
  * The P2M resources are freed in two parts:
- *  - p2m_teardown() will be called when relinquish the resources. It
- *    will free large resources (e.g. intermediate page-tables) that
- *    requires preemption.
+ *  - p2m_teardown() will be called preemptively when relinquish the
+ *    resources, in which case it will free large resources (e.g. intermediate
+ *    page-tables) that requires preemption.
  *  - p2m_final_teardown() will be called when domain struct is been
  *    freed. This *cannot* be preempted and therefore one small
  *    resources should be freed here.
+ *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
+ *  free the P2M when failures happen in the domain creation with P2M pages
+ *  already in use. In this case p2m_teardown() is called non-preemptively and
+ *  p2m_teardown() will always return 0.
  */
-int p2m_teardown(struct domain *d);
+int p2m_teardown(struct domain *d, bool allow_preemption);
 void p2m_final_teardown(struct domain *d);
 
 /*
@@ -266,6 +270,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
 /*
  * Direct set a p2m entry: only for use by the P2M code.
  * The P2M write lock should be taken.
+ * TODO: Add a check in __p2m_set_entry() to avoid creating a mapping in
+ * arch_domain_create() that requires p2m_put_l3_page() to be called.
  */
 int p2m_set_entry(struct p2m_domain *p2m,
                   gfn_t sgfn,
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3..8c9ddf58e1 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1685,7 +1685,7 @@ static void p2m_free_vmid(struct domain *d)
     spin_unlock(&vmid_alloc_lock);
 }
 
-int p2m_teardown(struct domain *d)
+int p2m_teardown(struct domain *d, bool allow_preemption)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long count = 0;
@@ -1693,6 +1693,9 @@ int p2m_teardown(struct domain *d)
     unsigned int i;
     int rc = 0;
 
+    if ( page_list_empty(&p2m->pages) )
+        return 0;
+
     p2m_write_lock(p2m);
 
     /*
@@ -1716,7 +1719,7 @@ int p2m_teardown(struct domain *d)
         p2m_free_page(p2m->domain, pg);
         count++;
         /* Arbitrarily preempt every 512 iterations */
-        if ( !(count % 512) && hypercall_preempt_check() )
+        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
         {
             rc = -ERESTART;
             break;
@@ -1736,7 +1739,20 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
+    /*
+     * No need to call relinquish_p2m_mapping() here because
+     * p2m_final_teardown() is called either after domain_relinquish_resources()
+     * where relinquish_p2m_mapping() has been called, or from failure path of
+     * domain_create()/arch_domain_create() where mappings that require
+     * p2m_put_l3_page() should never be created. For the latter case, also see
+     * comment on top of the p2m_set_entry() for more info.
+     */
+
+    BUG_ON(p2m_teardown(d, false));
     ASSERT(page_list_empty(&p2m->pages));
+
+    while ( p2m_teardown_allocation(d) == -ERESTART )
+        continue; /* No preemption support here */
     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
 
     if ( p2m->root )
@@ -1762,6 +1778,20 @@ int p2m_init(struct domain *d)
     INIT_PAGE_LIST_HEAD(&p2m->pages);
     INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist);
 
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
+     * the allocated 16 pages here would not be lost, hence populate these
+     * pages unconditionally.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+    if ( rc != 0 )
+        return rc;
+
     p2m->vmid = INVALID_VMID;
 
     rc = p2m_alloc_vmid(d);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:05:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:05:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424153.671367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okL7a-00008Q-BR; Mon, 17 Oct 2022 08:05:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424153.671367; Mon, 17 Oct 2022 08:05:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okL7a-00008J-8B; Mon, 17 Oct 2022 08:05:14 +0000
Received: by outflank-mailman (input) for mailman id 424153;
 Mon, 17 Oct 2022 08:05:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okL7Y-00008C-Vd
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 08:05:13 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bf85e5a-4df2-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 10:05:11 +0200 (CEST)
Received: from FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22)
 by AM8PR08MB6626.eurprd08.prod.outlook.com (2603:10a6:20b:367::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 08:05:08 +0000
Received: from VI1EUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:1e:cafe::29) by FR0P281CA0086.outlook.office365.com
 (2603:10a6:d10:1e::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.11 via Frontend
 Transport; Mon, 17 Oct 2022 08:05:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT023.mail.protection.outlook.com (100.127.144.226) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 08:05:07 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Mon, 17 Oct 2022 08:05:07 +0000
Received: from 01b07d4b827f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1097AD82-6D22-4A04-A9F2-57A0F61CAA18.1; 
 Mon, 17 Oct 2022 08:04:58 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 01b07d4b827f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 08:04:57 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM9PR08MB5889.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 08:04:54 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.032; Mon, 17 Oct 2022
 08:04:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bf85e5a-4df2-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=M8vIbddhpuqbKtMvtf9jzoBxBYM21QC7lH32oPIeSQMFdnj6jWufyExg2S49ZJCwowAViNkFnIK/KsziFwBN8ZexHMqsFJlELdREAjkZnEKg9Z4kuSJzGDB6TRp+tYsRKgIj1P1V+b8RtXTGUPlL6x+bIrgHXoyA5uGzyk35zuM9FS/XENpKA/i4NQdtAjqvl4CFZvBcOIXB2/Pvz+CzdznY+hdUmtREjqlPBGipbvM28waTMg/l8URPi4LR0BbjHGGF7YSYjdkdIYokU0Z9GrVgZ9NrK7FEHjxLcZMN2Xcc0/iaOH2Us5095v9jLPsJZ+NG3YHwQSc/XL+fX1kY+A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QUQTYAAYg6BMKxnHHqfWjbSgA50vz4v+e8fI+kvGXmo=;
 b=JnWBjaFknS8DEMcK0RCWXxWSjYbZVTtWKCKuVF4iHCtcsSW5DBhZ+t/Ia9s42pMhXLaYeynaw4YiOdNjaLk//6XF1APuUJ2E9yhmLobg5J8FFXP27sBxT15WDcu8Yj1GoN+vrBzdEZyQxkylJFOMO/ORZVGM8KfU8lBOceR+CU+32cdGpiLeMzAbR53DJiUoNDEuxbTZ23wYmlk9UwZrI9u6ci1kmrTXbAjiqkQ2Nuo8AbTPGp9xwObUUQPqXp6lnMTXfYaXgGOLyXdX6dcO1Ib2Y6I9X6udzEls19yhxLH2zQEEoQQZUIW3AFUZAs/b7JdBLkg+tYpeSqNESbwyfg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QUQTYAAYg6BMKxnHHqfWjbSgA50vz4v+e8fI+kvGXmo=;
 b=wnXz09Ec4cLN1IUH5pGaEgo2uckSglcbeqC2olTFad/5VzYPbWfeYr4DkI/ufYeKPgasxDqIIbM5/7EVE5+QL17JH5vbE8DxHBPeluJc3FI5f09QNZ0Z4/la3ZjonHG7RpFriOSRNI1IAZXACNvox0CYloGjGMZnrVWprFP/Fww=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hnyXGUDReWYO5F4fa7JlJBK22gGYEvzWFWQpErYgZugd4+Oxym6m+59wzZU8rTqWnN3URjanGe3b0+35WBqnZii2do1mm+NJQVbq7t84P5vXqkSzOEUfTN7xB+M/NY2HHFF99d3raD+9/PnD8gwy+1Pv2FzFgn9v5qEF/Pf1Xq0YHwG/6qZY6fB8yawtQtbtWQV62sB44hwbVBtz8wrVnjazSwnrXHgxTj9oA/oAWgRBrvStKw+DKVH9X3TYN0Pko9ip5cySiu1xETPagCbmRfWSYIrLFs/8lwrZCnrtPYxIseLJWI+xJXekD5R9SX7lcGAnFBmia2KKdqJeaT0k7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QUQTYAAYg6BMKxnHHqfWjbSgA50vz4v+e8fI+kvGXmo=;
 b=bF7V7neZ5XoZA6i226XsHZdRVvbJh4+QuU6N10Jskt5LuKrFoYbxz3brKFNWUfaKBxN4wvhB9d/t9wexDG42u4SaTE9/hKNMWLmHtwSWsn/RiEmb134PMHLYcaV3Dq5Le1ked6CBCxFJBLtyzYh7SXnmrigcr/96HV5xACrwkNpU71DEbK2k/1F2myDyeRNrYQdQk2V8zBGWGzT7YAsc4eRM8NzVcDd/dzk5UD+eZymKnhVXMR3CMyLmf+/iy5PMr7mvWD0r9KqYLEtG9QEp9AS7WmtjnPBK1HRBW65PH4WuF1Po3ib2B4ucWp2LHzkdTfzPPm1LH60ek+sj/OUIGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QUQTYAAYg6BMKxnHHqfWjbSgA50vz4v+e8fI+kvGXmo=;
 b=wnXz09Ec4cLN1IUH5pGaEgo2uckSglcbeqC2olTFad/5VzYPbWfeYr4DkI/ufYeKPgasxDqIIbM5/7EVE5+QL17JH5vbE8DxHBPeluJc3FI5f09QNZ0Z4/la3ZjonHG7RpFriOSRNI1IAZXACNvox0CYloGjGMZnrVWprFP/Fww=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Thread-Topic: [PATCH for-4.17 1/2] docs: Document the minimal requirement of
 static heap
Thread-Index:
 AQHY3q+bU7An58kRd0C18nD7mqtwpK4Nk9IAgAAAuGCAAAmOAIAAAGRggACMTgCABBWckA==
Date: Mon, 17 Oct 2022 08:04:53 +0000
Message-ID:
 <AS8PR08MB79913E2ABF9CB8D9C60EC40292299@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221013025722.48802-1-Henry.Wang@arm.com>
 <20221013025722.48802-2-Henry.Wang@arm.com>
 <00c6e7fc-7441-95bb-b7ff-dc78137df0f3@xen.org>
 <AS8PR08MB799119B54A5FE419CDDB9C1592249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <3cfdcd2b-cc18-0585-d837-f5932d9eeb0f@xen.org>
 <AS8PR08MB7991508880001B08C602881692249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e53601a1-a5ac-897a-334d-de45d96e9863@xen.org>
In-Reply-To: <e53601a1-a5ac-897a-334d-de45d96e9863@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 1020805F993F104EA07AE7D48A832AB3.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM9PR08MB5889:EE_|VI1EUR03FT023:EE_|AM8PR08MB6626:EE_
X-MS-Office365-Filtering-Correlation-Id: 2002c154-7b48-4137-f8dd-08dab0164e61
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 YIBDo786MSlfq+ARRu9+37kRvx7tc0r0Akc3v5xks03mr0CP2+O+BOjN2KkAZM7n5pIoYLcusbC9EB946YAyP+4y0zFdBmm08ogruHs/jHpP5FWvphtOtagfwhLTlOzZHfil1lHZzlvmqBM6EU6YefPzSMwMvEVTA8cnBcvS+c7Z/9bXvooYR9Oyl27foH5ws9epRkRvoa5J4A2XdTdxux5ZkznOzrbdTzTJHVd9krRRtvL6jc0qbG6P2bC2rZLalFk2iA8uuJmcTDUZSFoyb2icyaa3zGnai52dykuaYF3iMVxAIeIHTXMsvHPoDU75AUxI90oMvVXaTjLo/mq3KaVdbCCTElLCoiB4jpETTijV9hZLuTsef5aNmunHl/+GGQGYwnyPcRKkSUir/dHeH3u+7I0pfRxJXGg20TfcKajSowjbXBjqMvwSAnicdmVJ42mHoJ3ygkGljb56SxskVZnfLJEjvdkEAfkmFtce/fH5baQ40RW8coaMcliXYYJ+PDgsTbc001o2t6srNzjzDWQm6pw1ECOnUKT3UZSkR5m9TmKEtbltxTP0wUWGYohdj/S4pbtulcq5GXw+Ov3T5SbdVDCX/XZzF48Pk4eUSZvG1m+cHBMLgKDk+HR1HA0S2t/aAozg5h5BQoismMVp06+v9N27h5mg8X8c0ePBAXmAe+zbeeomvTqIMk7vBEbil9nj3ESNWuJr1vhsLJL+Khu9i5B36EBBmDdjnBbv7pYOYihB6w2UWwhXQ3Jd1C1+a8Qut1003rts5q1eqEGbfg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199015)(38070700005)(478600001)(66899015)(71200400001)(38100700002)(122000001)(186003)(33656002)(316002)(4326008)(64756008)(66446008)(66556008)(66476007)(66946007)(110136005)(54906003)(8676002)(76116006)(6506007)(5660300002)(7696005)(26005)(41300700001)(9686003)(52536014)(8936002)(55016003)(86362001)(2906002)(83380400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5889
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	84c3c269-025c-4f8d-14ad-08dab0164638
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZvuNFAYRPmOfboB0XEIRbpOLqaihawwUDxvq6GYpkV8KQy8BoS6EMdLft8zj78ZQ19PLR6pxLW46Ij1dEu4SCmUp8LVpB2Yftc2l704y4pB7L2A0YA3bpOVo2oZoGspWJAwLv83ElSOh/f5trCWZ8X+z4io1QovCT6KD9Z/ZZRQjec3WMoO/goDaJx15Sp2wtkjrZBQoCIS9OKzrx3Vllhk3r596dkGpKorhAdSldiGv2uRaNTnqwu5tdqgE2KeUbg4IeRzE0TV6I56WA2JcTtbvJxPBMMUM607Q0CicqkSrVnNzN0AtHZQNh1CweLdWS1dD5dkhpXcm0Be1LQDUcjNcMMWyy45jlBBgEuTpFNVPklT3t2k+EcbYVNxSYxNPlf1uwNEzoo333UIrN5X01ebowLtS/izRc/7Q37e7S04JrqKPilehw/hWowyD0kMrsYifIPj9e7eu0pfewqzPExzdwDRgEK5926WLx0cumsJYH05r3PpoHBcg7dcWn1eU50cc2Gh2zNkqhUqg2t4oVIEl3031CdEuSNUPXczK70eEZoKKD8o+4ZE0i3ROISoEgkqNoZtulFdoO8mYqh8skuBg9ZONa4c1seYLknSjeDGgLbWbef2bQPDcyrkpZEnqITcPyV29J0cRDgua/oIpDU0oyOsf7+rV3x+9727oxCavdMyyFR2kjC6UrSms4QBpbEDshpjFvJQJ+n1c1ik+UGVlz3IIozkgfT9Q71RwLufpH2ZsTEGeKLMjZXlMa3KZIU0BjBHQJbQnO2yUcsNLqg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(478600001)(81166007)(356005)(66899015)(82740400003)(82310400005)(40460700003)(186003)(33656002)(316002)(8676002)(4326008)(54906003)(110136005)(107886003)(70206006)(70586007)(6506007)(5660300002)(7696005)(36860700001)(26005)(41300700001)(52536014)(8936002)(55016003)(86362001)(40480700001)(9686003)(2906002)(47076005)(83380400001)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:05:07.6065
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2002c154-7b48-4137-f8dd-08dab0164e61
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6626

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTcg
MS8yXSBkb2NzOiBEb2N1bWVudCB0aGUgbWluaW1hbCByZXF1aXJlbWVudA0KPiBvZiBzdGF0aWMg
aGVhcA0KPiA+Pj4gSXMgdGhpcyBmb3JtdWxhIHNvbWVob3cgbWFrZSBzZW5zZSB0byB5b3U/IEkg
dGhpbmsgd2UgbmVlZCB0byBoYXZlIGENCj4gPj4+IHJvdWdoIGVzdGltYXRpb24gb2YgdGhlIGxh
c3QgcGFydCAoYm9vdCB0aW1lIGFsbG9jYXRpb24pIHRob3VnaC4NCj4gPj4NCj4gPj4gVGhhdCdz
IGdvaW5nIHRvIGJlIGhhcmQuIEl0IHdpbGwgdmFyeSBkZXBlbmRpbmcgb24geW91ciBzeXN0ZW0g
YW5kIHRoaXMNCj4gPj4gY291bGQgY2hhbmdlIGluIHRoZSBmdXR1cmUgYXMgd2UgYWRkIG1vcmUg
ZmVhdHVyZXMuIEZvciBpbnN0YW5jZSwgSQ0KPiA+PiBleHBlY3QgdGhlIFBDSSBwYXNzdGhyb3Vn
aCB3aWxsIG5lZWQgc29tZSBtZW1vcnkgdG8ga2VlcCB0cmFjayBvZiBhbGwNCj4gPj4gdGhlIGRl
dmljZXMuDQo+ID4+DQo+ID4+IEkgYW0gd29ycnkgdGhlIGZvcm11bGEgd2lsbCBiZWNvbWUgY29t
cGxleC4gSWRlYWxseSB3ZSBuZWVkIHRvIGhhdmUgYQ0KPiA+PiB2ZXJ5IHNpbXBsZSBmb3JtdWxh
LiBJZiB0aGF0J3Mgbm90IHBvc3NpYmxlLCB0aGVuIHdlIG5lZWQgdG8gcHJvdmlkZSBhDQo+ID4+
IHdheSBmb3IgdGhlIHVzZXIgdG8gZXN0aW1hdGUgaXQgYXQgcnVudGltZSAobGlrZSB3aGF0IEkg
c3VnZ2VzdGVkIGJlZm9yZSkuDQo+ID4NCj4gPiBJIGFncmVlLCBJIHRoaW5rIHRoZSBzaW1wbGUg
Zm9ybXVsYSBjYW4gb25seSBiZSBhY2hpZXZlZCBpcyB3ZSBoYXZlIGFuDQo+ID4gZXN0aW1hdGlv
biBvZiB0aGUgd29yc3QgY2FzZSBzY2VuYXJpbyBvZiB0aG9zZSBzY2F0dGVyZWQgbWVtb3J5IHVz
YWdlcy4NCj4gPiBJIHJlbWVtYmVyIEkgb25jZSBoYWQgYSB0cnkgc28gbGV0IG1lIHRyeSB0byBm
aW5kIHRoZSByZXN1bHRzIGJhY2sgdGhhdCB0aW1lLi4uDQo+ID4NCj4gPiBJIGFtIGFsc28gdmVy
eSBpbnRlcmVzdGVkIGluIHRoZSBtZXRob2QgdGhhdCB5b3UgcHJvcG9zZWQgdG8gcHJvdmlkZSBh
DQo+ID4gbWVjaGFuaXNtIGZvciB1c2VycyB0byBnZXQgdGhlIHN5c3RlbSBtZW1vcnkgYWxsb2Nh
dGlvbiBhdCBydW50aW1lLiBCdXQNCj4gPiBJSVVDIHRoaXMgbmVlZHMgc29tZSB3b3JrIGluIGFu
b3RoZXIgc2VyaWVzLiBDb3VsZCB5b3UgcGxlYXNlIGNvbmZpcm0gaWYgSQ0KPiA+IGFtIHVuZGVy
c3RhbmRpbmcgY29ycmVjdGx5PyBPciBwcm9iYWJseSBYZW4gaGFzIHNvbWUgbWVjaGFuaXNtcyB0
aGF0DQo+ID4gSSBhbSBsaWtlbHkgdW5hd2FyZT8gVGhhbmtzIQ0KPiANCj4gSXQgd2lsbCBkZXBl
bmQgdGhlIHdheSB5b3UgYWNjb3VudCBtZW1vcnkgc3RhdGljYWxseSBhbGxvY2F0ZWQgdG8NCj4g
ZG9tYWlucyBpbiBYZW4uDQo+IA0KPiBXZSBhbHJlYWR5IHByb3ZpZGUgdGhlIHRvdGFsIGFtb3Vu
dCBvZiBtZW1vcnkgaW4gdGhlIHN5c3RlbSBhbmQgaG93DQo+IG11Y2gNCj4gaXMgZnJlZS4gVGhl
IHZhbHVlcyBjYW4gYmUgcmV0cmlldmVkIHVzaW5nIGBgeGwgaW5mb2BgLg0KPiANCj4gICAqIFdo
ZW4gbm90IGFsbG9jYXRlZCwgaXMgdGhpcyBjb25zaWRlcmVkIGZyZWUgb3IgdXNlZD8NCj4gICAq
IEFyZSB0aGV5IGluY2x1ZGVkIGluIHRoZSB0b3RhbCBtZW1vcnk/DQo+IA0KPiBJZiB0aGUgYW5z
d2VyIGlzIG5vIGZvciBib3RoIChwb3NzaWJseSBqdXN0IG9uZSksIHRoZW4gd2Ugd2lsbCBuZWVk
IHRvDQo+IHByb3ZpZGUgZXh0cmEgaHlwZXJjYWxscyB0byBleHBvc2UgdGhlIHNpemUgb2YgdGhl
IHhlbmhlYXAgYW5kIGhvdyBtdWNoDQo+IGlzIGZyZWUuDQoNClRoYW5rcyBmb3Igc2hhcmluZyB5
b3VyIHRob3VnaHRzLiBJIHdpbGwgYWRkIGEgZm9sbG93LXVwIHNlcmllcyBmb3IgdGhpcw0Kd29y
ay4gQmVmb3JlIHdlIGhhdmUgdGhpcyBtZWNoYW5pc20sIEkgdGhpbmsgdGhlIHBhdGNoIDIvMiBz
aG91bGQgYmUNCmRyb3BwZWQuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KPiANCj4gQ2hl
ZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:13:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:13:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424159.671377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLFG-0001bR-5H; Mon, 17 Oct 2022 08:13:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424159.671377; Mon, 17 Oct 2022 08:13:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLFG-0001bK-1p; Mon, 17 Oct 2022 08:13:10 +0000
Received: by outflank-mailman (input) for mailman id 424159;
 Mon, 17 Oct 2022 08:13:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a+MA=2S=gmail.com=arthurborsboom@srs-se1.protection.inumbo.net>)
 id 1okLFE-0001bE-Qy
 for xen-devel@lists.xen.org; Mon, 17 Oct 2022 08:13:08 +0000
Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com
 [2607:f8b0:4864:20::634])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86cb9991-4df3-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 10:13:07 +0200 (CEST)
Received: by mail-pl1-x634.google.com with SMTP id k9so9662629pll.11
 for <xen-devel@lists.xen.org>; Mon, 17 Oct 2022 01:13:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86cb9991-4df3-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
         :date:message-id:reply-to;
        bh=G+LMEQuyp9Kc6brexe+iAWaP1CuuHDUAFC/qtpZ7ejA=;
        b=eHY3L9JBx2SGftDjSLn31qcB/JsKI+9HTyHvect9hKYZNbUomo/WTKc/lGbm9ztBVT
         0exu9MasIJJ9MXRLCKLsZuAhgPtp//EkvU+J0GwSq0Ceb0dXlp0IavCrrR8Ly+C9uZ48
         TByazcalosZPHGZ6F4GZHt51+YUH/8o81GuHI56A/0oq+e98eR5a0BJ/oMQ4KcL8IsU7
         7k0TUl9yx1GjmDrbM4BJiW9q7mx1ryohDy9Vo4pniLXGfPSBKGcGL1R2zCRCM0duhqlE
         +RcPCxg17BAwvmWGPjh9jdbyeHLQPkpHKqkAAJoMCZJu4wEkewCt1d/MWK6nujuJUX3i
         Bgww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=to:subject:message-id:date:from:mime-version:x-gm-message-state
         :from:to:cc:subject:date:message-id:reply-to;
        bh=G+LMEQuyp9Kc6brexe+iAWaP1CuuHDUAFC/qtpZ7ejA=;
        b=vhpKwTKVWNAUXCJKuF4zWy3fJn4dFeJ2wNv74GTjtAVcSMIH7Sw085oAJtF8c/taIV
         xosbosakB+BHll6skE7+oQ5+jfuV/d3un1ifz1NLhdcnV46Q+BlTDHjhRvfhA4i79gte
         O9rDLBXhu21uNpqLVBuuP6ab9BzUCMOjVIuY7COcrb3DTA1LPqkHJQrwS4TKREnqg5/W
         NnHX3RA7cWcTlTvx6iTGTJWgrpsd8GQm6+gLRVweSG3TzJWgQpTlET6Fg0ndi6usiO+K
         1Wt2ZusPfL/yKFDyADXySirDGa1itO9DeVLp4x2jsfEvlhNMKOlIS+2dtl9sdiG2/XZ+
         PG/A==
X-Gm-Message-State: ACrzQf3/tKTQ7EvVjtZA2KldsP1iUMog/lHHCcCCLoiLpG3oXIsEMTqh
	v9rwcdVYKOdXpYXU2WE//0MGn8/pjlLLR2FOlSrCTaPyccyaXQ==
X-Google-Smtp-Source: AMsMyM4AZmMAYiw7p/p2pNkJZMn34rxrPjEGRa4xEi09D2P9PWqHyv3ndENShvOmUCkQyU/L6gPigy2W8m1KZpd76xs=
X-Received: by 2002:a17:902:820b:b0:185:b9a:8ac1 with SMTP id
 x11-20020a170902820b00b001850b9a8ac1mr10788326pln.111.1665994384244; Mon, 17
 Oct 2022 01:13:04 -0700 (PDT)
MIME-Version: 1.0
From: Arthur Borsboom <arthurborsboom@gmail.com>
Date: Mon, 17 Oct 2022 10:12:48 +0200
Message-ID: <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
Subject: [BUG] Xen build error - undefined reference to bpf_program__set_socket_filter
To: xen-devel <xen-devel@lists.xen.org>
Content-Type: multipart/alternative; boundary="0000000000007884a705eb368bf9"

--0000000000007884a705eb368bf9
Content-Type: text/plain; charset="UTF-8"

Xen 4.16.1, 4.16.2 and 4.17.0-rc1 don't build anymore in Arch Linux.

I believe it is caused by the missing function
bpf_program__set_socket_filter provided by libbpf.
This function has been deprecated in v0.8 and has been removed in v1.0.

Arch Linux uses libbpf v1.0.1 since October 2022.
A downgrade to libbpf v0.8.1 fixes the Xen build problem.

Source about the deprecation:
https://libbpf-test.readthedocs.io/en/latest/api.html

Build error:

/bin/ld: libcommon.fa.p/ebpf_ebpf_rss.c.o: in function `ebpf_rss_load':
/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools/qemu-xen-build/../qemu-xen/ebpf/ebpf_rss.c:52:
undefined reference to `bpf_program__set_socket_filter'
collect2: error: ld returned 1 exit status
...
...
ninja: build stopped: subcommand failed.
make: *** [Makefile:156: run-ninja] Error 1
make: Leaving directory
'/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools/qemu-xen-build'
make[3]: *** [Makefile:212: subdir-all-qemu-xen-dir] Error 2
make[3]: Leaving directory
'/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools'
make[2]: ***
[/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools/../tools/Rules.mk:161:
subdirs-install] Error 2
make[2]: Leaving directory
'/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools'
make[1]: *** [Makefile:66: install] Error 2
make[1]: Leaving directory
'/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools'
make: *** [Makefile:140: install-tools] Error 2
==> ERROR: A failure occurred in build().
Aborting...
-> error making: xen

--0000000000007884a705eb368bf9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Xen 4.16.1, 4.16.2 and 4.17.0-rc1 don&#39;t build anymore =
in Arch Linux.<br><br><div>I
 believe it is caused by the missing function=20
bpf_program__set_socket_filter provided by libbpf.</div><div>This function =
has been=20
deprecated in v0.8 and has been removed in v1.0.</div><br><div>Arch Linux u=
ses libbpf v1.0.1 since October 2022.</div><div>A downgrade to libbpf v0.8.=
1 fixes the Xen build problem.</div><div><br></div><div>Source about the de=
precation: <a rel=3D"nofollow" target=3D"_blank" href=3D"https://libbpf-tes=
t.readthedocs.io/en/latest/api.html">https://libbpf-test.readthedocs.io/en/=
latest/api.html</a><br></div><div><br></div>Build error:<br><br>/bin/ld: li=
bcommon.fa.p/ebpf_ebpf_rss.c.o: in function `ebpf_rss_load&#39;:<br><div>/h=
ome/arthur/.cache/yay/xen/src/xen-4.16.1/tools/qemu-xen-build/../qemu-xen/e=
bpf/ebpf_rss.c:52: undefined reference to `bpf_program__set_socket_filter&#=
39;</div>collect2: error: ld returned 1 exit status<br>...<br>...<br>ninja:=
 build stopped: subcommand failed.<br>make: *** [Makefile:156: run-ninja] E=
rror 1<br>make: Leaving directory &#39;/home/arthur/.cache/yay/xen/src/xen-=
4.16.1/tools/qemu-xen-build&#39;<br>make[3]: *** [Makefile:212: subdir-all-=
qemu-xen-dir] Error 2<br>make[3]: Leaving directory &#39;/home/arthur/.cach=
e/yay/xen/src/xen-4.16.1/tools&#39;<br>make[2]: *** [/home/arthur/.cache/ya=
y/xen/src/xen-4.16.1/tools/../tools/Rules.mk:161: subdirs-install] Error 2<=
br>make[2]: Leaving directory &#39;/home/arthur/.cache/yay/xen/src/xen-4.16=
.1/tools&#39;<br>make[1]: *** [Makefile:66: install] Error 2<br>make[1]: Le=
aving directory &#39;/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools&#39;<=
br>make: *** [Makefile:140: install-tools] Error 2<br>=3D=3D&gt; ERROR: A f=
ailure occurred in build().<br>    Aborting...<br><div> -&gt; error making:=
 xen</div></div>

--0000000000007884a705eb368bf9--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:40:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:40:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424167.671391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLg5-0004xa-Hn; Mon, 17 Oct 2022 08:40:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424167.671391; Mon, 17 Oct 2022 08:40:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLg5-0004xT-Et; Mon, 17 Oct 2022 08:40:53 +0000
Received: by outflank-mailman (input) for mailman id 424167;
 Mon, 17 Oct 2022 08:40:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=z+Xv=2S=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okLg4-0004xN-Rf
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 08:40:52 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 67ba5960-4df7-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 10:40:51 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB6830.eurprd04.prod.outlook.com (2603:10a6:803:132::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 08:40:50 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 08:40:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67ba5960-4df7-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TZ5wn7LXQSgMLJgAVzsJUY9M+t3NCoizJd6KKRDwqsDOJQ57lcmnH/ZTuL6/NHPg0m36BtNISZFii26DxVnSsMHUnLmNEbZ1Lv1Ah1+iI/0+7gVgHCwtzkZ7+qXur7zWOYPmZnd4kNkPDleeFV7/OPMTOaSoma9nej2jd0VBq3w9C5NDaLvLEJ9AbClWi2AtQEr0RTADNMk5ruRAm8016Eb99xrrJIJU245K9q6Wy0jJx5ZEsIYmas5BlqM/uZ/dxDSFBnQQITNqiqToICdpdTdY6VbcuYkwHblaDXerf8TW6EikZUf4FOuC2jiil+p1OKqth7QnMgMKw0/GRNT3ZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lilq9s/yizeDzbYvu/Q0GRC29vCyzeA8REdcQymakko=;
 b=MiB/eoixS4YDEKXiOwixcZIKG+/Aji5Pjkn9LbCZCKRDCyIEEPlAklHEgukZoYQJ6edEHEa7m6xc7cvfhludCL8DC9vBoV5+VohLr+zAhdNTPR+wR9kZ/e558fyVRexcwBH2iW8Wh2DaqfdXeP3hfi3zvifNyqq9nDEdzk2eysx4Dds/cA4dYQn8iIqyZjqm/nla+hCDsjSQM+ob9kl9gAESCyTuY1pI38xu0wLsIdR/0xACdohWRT59ae0kvhp6yPNPsqLkO9Hxj7MukNDle/B95cbbfdCpxE5A5btRWyVysvuQ9+dvhzVJYWcfyEiVaE3B/N4ht5gUlOJ8nWC6qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lilq9s/yizeDzbYvu/Q0GRC29vCyzeA8REdcQymakko=;
 b=o6FrvTJJqKZjsetIYE+74ImIfTxoQ1eKiaNi+Nqo1fOtTagncHv8jriezcCdT8wW8YAgTc9k/s2ItQRyaZSGnZ4dMSH19wLUvokQ9O8uJsBRCJfW52ge5RbSVBWqnn+l4e2Lo50RWZgARKQ+TAY/02h1yQSv8ZH9akcVqUVqV6Wgggk6G00FuDU4PQj/IB3FYED4vCStfsagVUBmlpUSGgtEAc346nf8g1hvC7+HZoCbpPsSAKm6+sPefEiO9PFTtVNkkQWhf4LMAXBcHkqfZMlFE8cmBzHQDbwrpo/H5NvlTaYCSi71fsCCxNj7kupAyiNv8r0qJyxFPcxdV3+W0Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9c82cde3-fe46-3a3c-20c1-70bd99eb28f2@suse.com>
Date: Mon, 17 Oct 2022 10:40:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Julien Grall
 <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
 <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org>
 <AS8PR08MB7991976335ACE7B47A3FCB9792279@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991976335ACE7B47A3FCB9792279@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0101.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a9::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6830:EE_
X-MS-Office365-Filtering-Correlation-Id: 153fad55-18f1-497c-fe63-08dab01b4b43
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PzZpGwT44BxZKhmkSFeWYTZ7w9cNC8RJdC4PhsSS1IoNMZ7FZpUQBRKnjG9g5el7KMToQh47X5UQqB5gzqe4d8eJRu4ZXwBT3jM8hg/HT9tBZZqtI9LU/4Hxr8N4+gg7W0J7fLl/uz3bNg3tIaXUoR0KcmPJ8FGv6DtTfVI0qITZaeDcL0jUHL84PXXHQkFg9VliEF5/BiCOviXM8bxfxAf23zKF/iTZ2WKL6l6TMj/5aieY3lIU750o2MDCSqOizha0pdG0thkWMYfYlbychpSSDjcDjoZA32AsuHvDxZrxcCKAoSvc26Dyt4+8P2wP+JbreuVc6FFBqkLu8CynyE40qe+OpgKJF2Hawq8rlJD9cDyrXSWpjHKFmH9bxu47uehEA35bqhQYyTHw/juxewxsC48iD1Wj22iuGgcZdqR5TGwIhfcrRLoJNxoW7bT3kvpBNnll2zkFq2vWJluObmUJYw6B++Y4AZ2Od1YOzoBGI/rFJQ6UW7an6pLrhLWaxirpSdgOOSJuL+0NnsdZpYsuvrFSQmx+D31pdJ9I37xWWCAG5P3wydmKotF3NXP3VuNRSzE2sykgvpydHkru3mSU+tnLShiC2YN2ng9K5rDHlqtDZ8fqHxbU6kIrfsozWc2n4QxG39EwCkddvp5dcA6/m7UoU9v/m3p9b8KwRIuN/IF79trdUg/wpDPa99RZpq727WPvIb+ntMIue7Q6kwyhbumU01TudrYZ7eYqYNroYcnc5jpFWbEpc4S0Jr1fSwyv1HG2eXF/kr9OAxsnvOGrbcyeC9cFTbiij/hbi88=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(136003)(39850400004)(451199015)(53546011)(83380400001)(41300700001)(36756003)(8936002)(6506007)(5660300002)(2616005)(38100700002)(186003)(6512007)(2906002)(26005)(31696002)(31686004)(6486002)(478600001)(66556008)(66476007)(54906003)(6916009)(316002)(66946007)(4326008)(8676002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d0YrVy9OcG15Y3BOUTRZcG1aUnRvK2RaanlvNmRFMzYxOXo3V1RNU2syWkVT?=
 =?utf-8?B?b2FGU3kyOHkxVzV3RnhGRnByWkMydVpXeTRBcjhJcythNWZIa0p3VTg2WTFp?=
 =?utf-8?B?d0l0R1VsS25YS3hpTHZFV2JWOVMxcnVhSXhmSlo2Z1M5a3BTOXIzWCtiT2dU?=
 =?utf-8?B?QXVWWG1mWjB2WlFVSDJkU3pWTFBUT01leVBRdXc5ODBjMG1SK0JXUjRBWlR2?=
 =?utf-8?B?ZjIxWHVjNGFOK1JLN1lVcjJlS0czTGxXVDFtWFhEYXFSMWJ5OVUxZHZFL1Vs?=
 =?utf-8?B?WXlFT3dWdWt6a21yNWtnMWloYWJ6Q3JRNXo4eG5WcHozRWU1S29SbTdkYjQz?=
 =?utf-8?B?a2dKc0dqZ2pxYkJNMG1UL29CWWtSc084c28xbG1MalVjSjR4TklHdVNOU21X?=
 =?utf-8?B?TmNoU3VTRS9wK1o2VVdPd2ErUGJtVzFPdDcvTVhOejdkd3Yxc2duTllKNUt1?=
 =?utf-8?B?dVllTDVpWUN6cFFtaDh1VVZPdEJPQUxvV09nU1dXdFBRSmlFVzF1aDQ5bnBk?=
 =?utf-8?B?NDNUUDFzWTJXT1dMYUZBVE9LMDlUVVo2OUUrM0wxdkNrbGswNVZhSXBBQzUr?=
 =?utf-8?B?WFc2UlhQWFVGTUd3ajQxYXJNelZ2V2JnVGNYVEJZeWRBbUR2TjR3Z1Nxb1Bl?=
 =?utf-8?B?Rll5N3F5cGhpOCtOdXdoQzF2NFY0YXp4UVM3bUFEQWpoU25oWTAvcmJzL0tT?=
 =?utf-8?B?MWxDUjZObm93Qml0VndhRnlWZ1VLTVFYL2xKd2ZGc3FCMndObmZTSzhCZzBq?=
 =?utf-8?B?MlBpVjlQSU1IbHB6dlJERDlIcEJ6VDJrejB5SnNVR29ORDhuN0hzRFR6NHF3?=
 =?utf-8?B?MTdOc05icjBLOS9lWER4clB0MDd6T1htdDFyckRDbEVXbktzanRMZm1mbFM4?=
 =?utf-8?B?MXdETnJTVlR3by9Wb3l2MmxHaGwwVWdZcGozQ2tGVnErTWlCTHBTSGtiQzRu?=
 =?utf-8?B?TEhhQlRNZG5lS1p6aFZFSmRPVUpsRGxxMlRScDVBT2ROaVJDY2VXbVF5YmFn?=
 =?utf-8?B?eDBCUkJrb2dMYUprMzJrU04wWktZNGNDamorTm5yWkljVG1HN1ZGVmtEQlFn?=
 =?utf-8?B?RzdhT0QwWmRBMmRrSUFyUTBzWDBvMVVlVFRUMWdHK0tTc0pxS2dtUlprZ1BX?=
 =?utf-8?B?bGFHeUlxZ0pwaTBGYitkRklyajRoRXU1UkFmS3hZTFdidldVK2NLZHZpQzBG?=
 =?utf-8?B?T3hTNWdOeHlOa0JTdTBNUWlPMmVEa1ViUW81anEwUXZ6OWZNcG0wTVdhTFAx?=
 =?utf-8?B?eWtZUzdiM2lmTnR6eThpdWJ3SldUOUJ6bUVMZGlhRHVIMEFMZGlxMjNmY0Nk?=
 =?utf-8?B?K0ZyNDF2TGtnMFpOK09ocm9ZTlpGM0FVOThNb3lwWE5aUjFpQ2hqZGNhSjEy?=
 =?utf-8?B?NXpuMFNlTEFjQTlxek5idEF0b0RaZkFHeThUajNXcWJvaHY2Y2xxK1UyRzFq?=
 =?utf-8?B?azlVVUNmdFR6aU9IUnNOZWtRVTlXME83M09VVEIwUURHUGd2anFLQ0ZFY2w0?=
 =?utf-8?B?NSs0cFhvY3JGYlZtZFN4WFFrU3Z1dko3N3ZwQit6MzZRd0NCaUQ0ek9ydkJV?=
 =?utf-8?B?VXAzc0dBazVoejlrZkhrajdTN1ArMEdVRHBkeFh0dkhwdnp3SjNkVjFmTzBI?=
 =?utf-8?B?bmdWdUhhZU1wdjZaOVBQWGwwQVpsaHUzR2JPTkpzZlRyUmxZWGdkaWdEWjdG?=
 =?utf-8?B?NEloMkxMck5odS9TL1hmeWt0dXhnSERiRXFGZjUzVWVwdkc2OTVaR2MySWpa?=
 =?utf-8?B?cTQ0OWR2VTFYZlNCWThZTmg0QkFtM3V4SkdwdXEzRzNIQVNIRjM3Slhvd0ZO?=
 =?utf-8?B?Rm81WmIzMTZkWXdIT0xXN0JjbG10Z29taHFkVmRJRm5IVDR3RmZmZUF5MVBG?=
 =?utf-8?B?a3hpYjQ1Uzc2aGp5UytOb0JhRWRmVWpZMEEvOFg0NWN1TzZTTEFnWGdoMkh3?=
 =?utf-8?B?REp5OEh5OEZaV1N2b0dWUW50cjM4T2VmRy9CTnlGRElYU3E2T1duTVZjZXFC?=
 =?utf-8?B?SHJaWEZ3Z0VVYnJEWktnR2dxV0dCQ3BvTW43MFJabVo0NmcxMHRUQ0pQN1FF?=
 =?utf-8?B?WHh3NzR3UkJqSytpUkEweVdCdUZLc2NGS2pXTDZHTW9aQXNQRTM3TUdNWHdT?=
 =?utf-8?Q?e9KuRPQPFCvG+zTW8NG+ppFss?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 153fad55-18f1-497c-fe63-08dab01b4b43
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:40:50.1105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XmPgrudy7HskKQTuJtIo4tG/b5gMAAcFT4t2w6/xTBeU7Qbq4H6a78igPsggyGXkzbAAa4Q7ZLcFRWkWoK7KBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6830

On 15.10.2022 15:14, Henry Wang wrote:
> 
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> On 14/10/2022 12:19, Henry Wang wrote:
>>
>>>> -----Original Message-----
>>>> From: Julien Grall <julien@xen.org>
>>>>> +        p2m_teardown(d, false);
>>>>
>>>> Today, it should be fine to ignore p2m_teardown(). But I would prefer if
>>>> we add an ASSERT()/BUG_ON() (or else) to make confirm this is the case.
>>>
>>> Sorry I do not really understand why we can ignore the p2m_teardown()
>>> probably because of my English.
>>
>> No, I forgot a word in my sentence. I was meant to say that the return
>> of p2m_teardown() can be ignored in our situation because it only return
>> 0 or -ERESTART. The latter cannnot happen when the preemption is not
>> enabled.
>>
>> But I would like to add some code (either ASSERT() or BUG_ON()) to
>> confirm that p2m_teardown() will always return 0.
> 
> I added the doc asked in your previous email. Also, I will use a
> 
> ASSERT(p2m_teardown(d, false) == 0);
> 
> in p2m_final_teardown() here.

Hopefully this was meant only as an abstract plan, not the exact code
you mean to add? ASSERT() expressions generally should not have side
effects (which includes function calls).

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:43:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:43:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424174.671405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLik-0005Zd-W6; Mon, 17 Oct 2022 08:43:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424174.671405; Mon, 17 Oct 2022 08:43:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLik-0005ZW-TZ; Mon, 17 Oct 2022 08:43:38 +0000
Received: by outflank-mailman (input) for mailman id 424174;
 Mon, 17 Oct 2022 08:43:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=z+Xv=2S=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okLik-0005ZQ-1F
 for xen-devel@lists.xen.org; Mon, 17 Oct 2022 08:43:38 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c9d107c3-4df7-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 10:43:36 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB6830.eurprd04.prod.outlook.com (2603:10a6:803:132::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 08:43:35 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 08:43:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9d107c3-4df7-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H8avUDc30eKOL4QlEhe2aqH74Bbxm/pCUSUBgfcYoYjv9V3zx8XCsmnMtmONVPfPftzcTiLbQHK+4h95OP4AZsh8kEyXfchx2wahiyC2hmdSwYxfVW3kvDzJyL8QZCD2i+Voy19zoxWNcOgtdYu4+OKRWmnd8RhknyPvZ4QIVgdo5T+4pn0r1Fs6qc1vCTu55+83TsyzsvSCJwKQE+gq80/FChXvMubi89tYRxDe9qMoscyP4Kzxz7MHpRMuEcuDz2xG+RwHuOM4kDcBfvf2RnimAhCRn88iREJQtF8Ov5eJ85LF4nPKWS/yqFmus9sx+5zCCPRaVOrHv0tdl3klOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=my6NE2jctkUT5juoBWQqP9FyXBIIo4bZ4t/oX3Q0Jxk=;
 b=DluDQJBP7AbnutYGmZCCwfUY3oZzI2PGDhVghB4Yez9O9eVkSH2OFXUa3MTfgFHLntQHXIrXvU1jdCG++zYlIrK+SWNFZgPTFhviverRu4QnBXeo/zMIekcgtjBldDNYnfER/GZMn2oBlBDmPA1RRqs+bUeGT+kA5+dnSE8tgedCXw7RJCS1mXUjrzkp+i0XfOA9ht4GTdDV8I+12O9K0KSWqyuwFiEvbXf+iZ052R3vWtYFOgVnO5oipkysOSddtD2K54Tn4jNWu0ZHG11zdg9+URL2rK/CXQ7I253cQIl0CvuNUKToSHEcXTCqk0IjogoJMRYbY9EBpcWuXNYwKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=my6NE2jctkUT5juoBWQqP9FyXBIIo4bZ4t/oX3Q0Jxk=;
 b=q4593l3bk27UeEu+9vqOtpaFAudM2PtfDzR3jTJLHXIgnoRbwCbpGjauz19rqTdNAS9efWU7nQ9G4r93MiTeE//8q3wHo4AgbmLZBe47TU1ZHhX1OIOy4tHwoOW5jvo4df1S3iHzaDF4GQ6+8xzJXA+aqKkum4SdQy9h/XSPjZv3YN7u6TaG27G6J2zsFIWLnf0ZG4NrsYrZoqGgsMYXhHgheMEZzQa0Hj+ENH2o3niSceTx4eDWSFaFon/dX1NxAMgIuyArmm9xSOThqvGUB8JkUFJ+EaE51XL3F/XcXujlVGBexu1Fo5Q4IHXLFturhgHvxVSB6VdW2s+oQvmPSw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1b3d21a2-9029-6f3a-0579-e08682814222@suse.com>
Date: Mon, 17 Oct 2022 10:43:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [BUG] Xen build error - undefined reference to
 bpf_program__set_socket_filter
Content-Language: en-US
To: Arthur Borsboom <arthurborsboom@gmail.com>,
 "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
References: <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
Cc: xen-devel <xen-devel@lists.xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6830:EE_
X-MS-Office365-Filtering-Correlation-Id: a2cff02f-076d-4810-69ad-08dab01bad7c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Hz7VQKp7kQd0K3jXNA9nHVGrzGKZOLUlDvqDIpfxe+qi71ahnwGyvuzGBIOnDTS2ZhZ6MHrZxBULycmBPsBWZ86+CNKMJo546VgurpTPxvQ1iohsL1MuO4RpblGDdhQyJdkmsVDGJX1nmmAJTGXiA8hJnIqp6BzJhUzZ+nB0CgoooYH+gAk4Y8xFkboKOWe4Rek2Hu3+tilkX6Tzc9BFyVMycnrJbcpXoMTgQhZmYbXRiiNmzkx3+G8/HBZmLweYcNYTzRbiSg743ArCXAQUMQPV/gYzBh3IUl7L48qo4gasIbKXFMBSbsJprjhIh4JNlSTSWGWylj85Etd4bQd1JNTDMY0X+Bn4l2wt/W/YsLoXmOk3l6K0HYS6NoJXbhR3yXG2IzfppXtVmRh63NihNRg1Ltgm07UI8M+fsM025RSt7LZ6VZtNodPCEu6+2ipMRqUfRKOG3zl9NGhxlhiglC+od2l84/O1rj8tWr9NPlysCVf2y10fQTgpShceb4meocjHjj05agaR8SmpShHbMokdYyX0bdJq3FLiP3X/jJQ6bD3qjzAYvv5okzl/E+yDsxHyL73OSinsWzlg/SX8TyRNQqh/2/Pbsh2D6VaIKBJ9+LqDtS8MsJXkGcNG+qgh/soJY2z0Hi7s2KF7IqPPFtFzXH4K7sF0x5KFML+3X7vNHz03nCUT+cvIoSiMgydg7BL16qXRRk1FHwmyMWxvqlgcOcTXA5b2BVobdFVYlFg7uZDva7aQqg24CGsbrcRbn7GIIrUJrWMAYVHc/2lPXg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(136003)(39850400004)(451199015)(53546011)(83380400001)(41300700001)(36756003)(8936002)(6506007)(5660300002)(2616005)(38100700002)(186003)(6512007)(2906002)(26005)(31696002)(31686004)(966005)(6486002)(478600001)(66556008)(66476007)(316002)(66946007)(4326008)(8676002)(86362001)(110136005)(101420200003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MXVlbzlTR3JpT0dtSHNIM1VaR2NVMkJMWFlOWko0U2IwTWdRRitIV3pPamhP?=
 =?utf-8?B?THlwVFF3eVNYUUQxM1FxeFozMXZSRFBXU09QTkZaR0NpeVhiYzlSQ3Q5a01U?=
 =?utf-8?B?ZCtvVEJXMS9lMVlLRFV1TlpUMk5ReXhHSTVZOGFwQm5JQlN6RUpqK2FiMXh5?=
 =?utf-8?B?UDBndXE1bVZxTkR5aWtuTTlIZ0lDMUFSdlRocjZYMUwySktwMVFDQjYvNWxl?=
 =?utf-8?B?UE5ZbE5peE5zYlVqUGxLa2QzeEZkTkd1UUpwSWpxMGFoTjEya1lNL1Z3WkRC?=
 =?utf-8?B?L3NUT3VFZXN5U1Vzblg5akJHL21UNkorUXZtblZTOFNQN0xKK0xPVnlZN3Vt?=
 =?utf-8?B?MDNXbEcxcHFtRVN0bURiL2huNVVtY1FsRTUveWdrTWZra0p5aDVoSkVmRXNQ?=
 =?utf-8?B?azI1WVlCRnNtZjBsa3RNd2NmZFRjQUhUcjB3WW1iZUZ0eFBZUEFabjZremlu?=
 =?utf-8?B?ZGlaa2xhYmI1cFU5MHU0UW1YU2wwK0RWMTdjdkMrNnAvWG1Zd1V0dWUwTDBu?=
 =?utf-8?B?VDFSbEs0WmgvRUJXRjVxdklDOG1rMFhVV1FVSnFyWnF4MGp6OXQ0Rkp4RVR1?=
 =?utf-8?B?OHNaM1VlTzFPNzhMblViRlpKYk1yWkpkTnJ6OHBxNDZla0VrRnFkSzN5KytC?=
 =?utf-8?B?NTRxa0c2c2dRdnNjSHdtV09RVDlzYW5veXgyRW16TUsrTWRGaHZyWE5yYkha?=
 =?utf-8?B?dStWU0tCQkRkQ3NXdTFlMW1KY0pBYkdpUEx6NUtUK1VCblFWOTJpaWM5TGdN?=
 =?utf-8?B?QUordWJqMm1wcklURmVqbUtEeGwwRnNyam1maS9jeUl3azY1YlFlbHMzRGI1?=
 =?utf-8?B?OUk1dlZuTGZka3hzR203NWx0cmZuMW5iTjNucEV4cVRwMVp0UlRGTHh3OGZ3?=
 =?utf-8?B?UDRKUnA1elQwZzZrQmNNS1VOellveU01ZVpNTStpSjlSQVZGaXlCMjZubUUy?=
 =?utf-8?B?TkIzMVV5TVhlZGpzdUtodVhXK1JpQkRCVWIzRW9BckpGM0paZHhucGdXTkJy?=
 =?utf-8?B?cjlFK3JsTHdPU2RjeWdzQnVaVlBxSS9hWVZTYnBabTNkUTZEcnhNenhnYmR4?=
 =?utf-8?B?UFhSbnBYQ2NDUVQ1dUlRc1NhSWkzN0k0NFJWbkt2bkRWbTBzV2tDTG1Cd0RT?=
 =?utf-8?B?NnFXV2JrUzhFaXdyaXdWQ3FUcTgyYklWaU13clZQUkhjbjhhbmJJdTZrNVZW?=
 =?utf-8?B?RXgvR2R6SHpVbmpSaGw2N0tSSHVDakN5NTg3a3dFaDZ6UjZKZmd3Wm8xTHhy?=
 =?utf-8?B?ZEFMU3lyL2Z3d1FOQXFOTG0zeU5xNUwyaUY1YXMxTG54dHBXdjI2RWdhNzNp?=
 =?utf-8?B?OUZxc1prMWJUSml3YnBXUzNwMmRMem9nRFd0TFQ3NlkxKzU4VTk3K091T0p3?=
 =?utf-8?B?MnVRL0FWVklYcHRRdEw0M3pmZXg1OUwxMSsya2FBUm1RamhiVmxsRmxwajlE?=
 =?utf-8?B?R0p5ek45bGpybjQ2TUNpSmtqV1VIMG93Y0draHgyY3pjcmN4SEd6eHBVUy82?=
 =?utf-8?B?bFk5NkpBejJqamZzekxWMmErVGJSRU1JQ0FQL1Y4dm9OUFdhcnlLN3FqYndj?=
 =?utf-8?B?NjNzbmxiU1dWWFlsaWs2YWQzUWdMWWJEdlI0R0swdUZ3WGFRK0tkMkZaaGhQ?=
 =?utf-8?B?aGV4T2xsb1R6UnB0dlZBWWlHUk84SEJEaU1PSW83N0MxdUxuRmRKZUllV2gv?=
 =?utf-8?B?amd5K09LV0V4WVUydHhQSmJ1TFRRQXc4U3Y5WG5lQm90YkZvOEhJVXh1RTFt?=
 =?utf-8?B?alNVWlQ5c3o4OXFIQWs1allQYUs5Wlgzc0R0YWxJT3hGbnRVcitFK0NnOVhx?=
 =?utf-8?B?SGVzcjkrcTY1WG9CV1haeTJra1JBazNkT1NFUVNtT3hDUnNtbVFwcFQ2dDZn?=
 =?utf-8?B?TjEzeUNQcG9wdVhZQTZsSzhpcnEvMk1QcHE3M3hQamFrVkl6QXVmOVFLUHNT?=
 =?utf-8?B?OEpHZjE4cmVwZzg3blgzM0lpWWtPTXY4alRweHJYWFdEMG9TY2FEbWc3OUZj?=
 =?utf-8?B?R3MzYlZ2WVNBWjI4QUJwMnhkMnJML0h6ZDc3NU0vNWxoYjZjeE9YUElRbkt4?=
 =?utf-8?B?V0o0L1ZpVW8rMkFpcjJ0TzN6NUxJeFA5eDdaMnRXc0pUQ2YzNXVHMlZhVEpY?=
 =?utf-8?Q?J/t6tCzTKWeKjefCB12kFfkCh?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2cff02f-076d-4810-69ad-08dab01bad7c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:43:34.8657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bu9sZN2OIkvKGs58IguQlBxySAszoUQakjjWCo47nvCBV5qQl7idnZl8R89X97tPZqfYvAUDC3DDBC7oWXF4kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6830

On 17.10.2022 10:12, Arthur Borsboom wrote:
> Xen 4.16.1, 4.16.2 and 4.17.0-rc1 don't build anymore in Arch Linux.

That is, qemu doesn't build. That's something to be taken care of there,
not in Xen, I think.

Jan

> I believe it is caused by the missing function
> bpf_program__set_socket_filter provided by libbpf.
> This function has been deprecated in v0.8 and has been removed in v1.0.
> 
> Arch Linux uses libbpf v1.0.1 since October 2022.
> A downgrade to libbpf v0.8.1 fixes the Xen build problem.
> 
> Source about the deprecation:
> https://libbpf-test.readthedocs.io/en/latest/api.html
> 
> Build error:
> 
> /bin/ld: libcommon.fa.p/ebpf_ebpf_rss.c.o: in function `ebpf_rss_load':
> /home/arthur/.cache/yay/xen/src/xen-4.16.1/tools/qemu-xen-build/../qemu-xen/ebpf/ebpf_rss.c:52:
> undefined reference to `bpf_program__set_socket_filter'
> collect2: error: ld returned 1 exit status
> ...
> ...
> ninja: build stopped: subcommand failed.
> make: *** [Makefile:156: run-ninja] Error 1
> make: Leaving directory
> '/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools/qemu-xen-build'
> make[3]: *** [Makefile:212: subdir-all-qemu-xen-dir] Error 2
> make[3]: Leaving directory
> '/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools'
> make[2]: ***
> [/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools/../tools/Rules.mk:161:
> subdirs-install] Error 2
> make[2]: Leaving directory
> '/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools'
> make[1]: *** [Makefile:66: install] Error 2
> make[1]: Leaving directory
> '/home/arthur/.cache/yay/xen/src/xen-4.16.1/tools'
> make: *** [Makefile:140: install-tools] Error 2
> ==> ERROR: A failure occurred in build().
> Aborting...
> -> error making: xen
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:43:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:43:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424175.671417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLir-0005rI-AD; Mon, 17 Oct 2022 08:43:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424175.671417; Mon, 17 Oct 2022 08:43:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLir-0005rB-5a; Mon, 17 Oct 2022 08:43:45 +0000
Received: by outflank-mailman (input) for mailman id 424175;
 Mon, 17 Oct 2022 08:43:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okLip-0005qH-GE
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 08:43:43 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60050.outbound.protection.outlook.com [40.107.6.50])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd826545-4df7-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 10:43:42 +0200 (CEST)
Received: from DU2PR04CA0184.eurprd04.prod.outlook.com (2603:10a6:10:28d::9)
 by AS8PR08MB8899.eurprd08.prod.outlook.com (2603:10a6:20b:5b6::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 08:43:39 +0000
Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28d:cafe::86) by DU2PR04CA0184.outlook.office365.com
 (2603:10a6:10:28d::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Mon, 17 Oct 2022 08:43:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 08:43:39 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Mon, 17 Oct 2022 08:43:39 +0000
Received: from d1bec5c5ff8d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CA95BB1B-0DF5-43FB-9716-BE63709C4001.1; 
 Mon, 17 Oct 2022 08:43:29 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1bec5c5ff8d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 08:43:29 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DBAPR08MB5703.eurprd08.prod.outlook.com (2603:10a6:10:1ad::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 08:43:25 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.032; Mon, 17 Oct 2022
 08:43:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd826545-4df7-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=PP8uce3Zx10pkIM9quo2C6wweLsQhpJPXyxTu5BkVriFCEpiwEVYpDyOm9QHRjXnV24ziu4vBjXRqwCMj18Tk2DHwYMXddIUfNK4RQw1WAWDeP8Woie47Rp1zaS61EPUSBK4sJbmo8OBIZE4eGDUHIObIRaK5Pzo/0cXV8TGKbfP2ZTejmSpeaN0OHYuhU5OuvP/Yoyf/vwgoGzaOcuVrwfiwu4TIGaqG2Msb/zg1m6KmDtpuD7KFRfGDmpGhg4GycxCy+PgLyNByGUL6CYOA1FIlZpAC2HjVKfnh87DKh+7rMctbybmx17J4aEOtzQzlNBa7F6KiE/lELWZC1OH5w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K7t2ZzJlBiNTtLVHmLpMV3QEkEAT7aLIzdqvyTDY8mA=;
 b=N1i3NJnUBis55iE1nxQlM20WbbJtYthgc/XaRYA4Fr68wuVh+x/kMr3he7lrXxGO7BTwTcsZO3NLg5GXlodKHsHzco5+52/Mu8IVgMI5UY59m+tN54bUTgiZXPkUDIWBS3wPqq6kKL0m0cdW//t5Bqk0dWuRIu7W6K0Vpr+qytlBhRb/nYYBOCWilHA17CIpByWnVCro0c3YqjVU9G1Z6lXyTi7V54BCh9GybERnuq0nDjQWw5mmz2pUVkJiehPmOWC/IUF+aXOg2Y66TjLQOG1ZBSL5TtMAgkRGH8d4jQsHPPHX0LH7XrnvVFK8a0R95LQChTvfK0q7dPiPc5x7eg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K7t2ZzJlBiNTtLVHmLpMV3QEkEAT7aLIzdqvyTDY8mA=;
 b=VxmnIDIxQiVv4Ttu6w4ZJ9XzBC+9Pk7Ytvauj1U1rlNUKBNa5Mbu7Xk9PWxp0Lof1bm1GRDKSNMbfW7O0tBz7xsMi2LJq97dA/v+wMeNTKBO2p7LQmoZXx1K6GTtmqVkKyjnqi9RfVFnOkyuE25ai3oGlaJELpFPjluvsKKNmm8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cmqykeYNBgdPO30Yet95nSFAKQdPNxqraFkxNubeju3x2sUgKPsgqGa3Al/fpDmOgRw3OF4tP5twXdZfW1Bj54eZ29lxaQjeQh+sFkPhM8TJQSxFBMTw/md+59+IZgkL11PC26dOwTFWlo5J1IQwISh6KrjsVDgiegcSU1crFoU2C1AT7HNWdyHynmUktoJ6sQE0ylN/UbJprbpBQ0DyhIlAdCc5jYBCMM9N0gZC9vlVONh/ut7xsJevvCEKgWxombijN0iBZ6QGyD8KaFhV7eZ69Eu3QE+HTK+KZ5+WuupG3wlseaDsx4v9PMTmvPwlNtEgJ7KND4H9PbAS1MdQqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K7t2ZzJlBiNTtLVHmLpMV3QEkEAT7aLIzdqvyTDY8mA=;
 b=MArEMaaFBPxX5YE01+Jr1QHHdw96uHVELtSHvMkL8QW8Nx5SRjvH5OF1s+FqQ8OOaglT4VdWPYOZdPJyt6VzOgIXtCmjGpHTrsZMNLXlZG3mjD0t/OgfkFzSn20BIkkU0CFRCMgHgsc9qhGmNaMURkr1b4Ke6YTsce/lo1by8YwQ2yXJHf1z0Xp6YXx6YftisibtfIzyAIScPk8t5BujjZuDnVC6fnTn2DqH6db+9BT0OQ0mBQmW7yBz9T644A+TXm1WNuhrRAG4ZQAXPO1rwjUjTC+HfUlMDe3ShuGI8HsDlWroS5oYCLT0eMOrtqWIn8s9T1hFblZHXcg26YLGCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K7t2ZzJlBiNTtLVHmLpMV3QEkEAT7aLIzdqvyTDY8mA=;
 b=VxmnIDIxQiVv4Ttu6w4ZJ9XzBC+9Pk7Ytvauj1U1rlNUKBNa5Mbu7Xk9PWxp0Lof1bm1GRDKSNMbfW7O0tBz7xsMi2LJq97dA/v+wMeNTKBO2p7LQmoZXx1K6GTtmqVkKyjnqi9RfVFnOkyuE25ai3oGlaJELpFPjluvsKKNmm8=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Julien Grall <julien@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index:
 AQHY36RSrOIThkYtnEq9RrtWc+uYX64NsO2AgAACdYCAAZeJAIAAAyvQgAL68gCAAABLsA==
Date: Mon, 17 Oct 2022 08:43:25 +0000
Message-ID:
 <AS8PR08MB7991A3DF126C3B68E198AD2792299@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
 <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org>
 <AS8PR08MB7991976335ACE7B47A3FCB9792279@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9c82cde3-fe46-3a3c-20c1-70bd99eb28f2@suse.com>
In-Reply-To: <9c82cde3-fe46-3a3c-20c1-70bd99eb28f2@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 74C8657F287BD74FA36B03CE775C962B.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DBAPR08MB5703:EE_|DBAEUR03FT040:EE_|AS8PR08MB8899:EE_
X-MS-Office365-Filtering-Correlation-Id: f7488095-cae1-4ed9-b0ff-08dab01bb048
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 d497Ng4/r5ylmxQzfHlE2yE+/PK2Ql/D36wKNYHq/AJPeaRPzm/MsV9fkGsGUygOvQvwrnahVEO6XohiZnEtwCnF45ahplowJzAWpcUC9eWLsNzOQMy5P/wPMw7oJe/jIu1gDrL0RX0oioS9/fJKu0cWZxOXU9JGLp7VrzgpTLayeq0Qwh2HKtXXGdvfcDnRaXM2hgptPFGXzuZU+EO8eQg1kF1NpyYeXhLQDGiUCPCdTZXuzsBJWN/jo6c/fF5QMYZLACBoQmDxbF61pOUWrA5Ids6SgoDJOIBUkam9CU4CF7FaLeEgT77DkygZ2pfqKsHfwI6vQ/mvkUJu8bKrd2uoSTj1hXIxj1aB014sX8AgmfqWH5iqzHSfsRNLc/k3yGDyuGHD6xHEIwJHmMcrZuN0chwx6/o7hpOZLIkGl10D73n2gG5wmeo1/zW4uYF+vrJ0wEW+6mY6ENcmsuAFeYdE5e9mFEL9z6DSsQUqhVV7Uckm3CGUmSl8c1TeyRQYCg+nxMOzlDpGbaztfyGggT7l4lqB/LQ6qe4VUwkJgKt54027rjBg08/yjj6RVcT8W8zD1fpzRCUDkdCaj58IrruRXWq1EaoTYPi+qCb0qhbw8Lkvd5ETS4f+qyzp+m94to0aEZLdc2v29OYYeLhMy1uckiw/Wj0IMe83y9Zjhkahk7H9cyB7NzDqLhF5iKROsaW0F/ikNrsPNNvDkIUJJXLIgAJ+HJWPBTD9Ik6H6/18zsLiHXS8MO3I5WYRt8/DwSopdcpm60tajfPwx1mgrw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(366004)(136003)(451199015)(6916009)(4744005)(66556008)(54906003)(66446008)(8676002)(66476007)(76116006)(64756008)(316002)(478600001)(9686003)(7696005)(6506007)(4326008)(41300700001)(26005)(52536014)(186003)(71200400001)(2906002)(5660300002)(8936002)(38070700005)(83380400001)(38100700002)(66946007)(55016003)(122000001)(86362001)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5703
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	29f607de-a8fa-4f22-4615-08dab01ba800
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LDgf4U2UJbhS69n0UhXrcKLU7umvq9FVagFJdr+rzqHwWA7Wl15Mzi2RFwYcToptuBG3OEq/DaJZMxtlTiSfltBJZ/YD6F7DoaKZMk5NzHKqla7qYStLgt3YYO/Io96n/BTojjsEDuNgy2MfF8pWOckGjinKTyhudjjmaCOMOUxNyKaePaARBEbl6dZMDth8peUB+5rW/CVnIaP1BZzlKTODvZLbGgYch7Ea5jEEiORkKiSpDdr9PkIst0FcPPB02uIQUZil5Q5J19PW5LYxT3s8wQRNhqZVpW7RdkNKpCfU1JchH+fsK2pEPKGaRS2rtx27gzz+AK3EZ+fNahIEM//g1y6x3svaFDDZdyG67LVmOGkai3PAcFwgp3teQeGbEAGJIG4VYqDkUzQ9ti1BgW0lS5AqmBkhlkqgLIyu1z1ihK6uiAx80kSkY2Z+6F1dtQiVyUWyUq16uxR+rsbq6eiGmz8qCmbjh3CJR5l75fPIRFruJS39VV09Ibp8+PKNic8Mu4e0vtpfOYinWezf9G1QxtVfEcbJ9LiEoUBcx5e8TmlfUB2BQy2WKQ8cpUYATj1yk0dbgBo6VfuathDZ21otaZyznV4zpOcAqvsEIXDZcZCWLvDkL2jX5OU8tUbLoTKYf1o+LX6JnMQPXMmodS4yPWWEfmXYwyeLV4h/mTe4CcWd5OZPVB2crf1yOE9wVDFmYTJ/D6g4iNx1SEBy6mDu+4Agny5BNwfo457lWPSpJRrqMQcBPbOrm+NdqWq/uhCwyWonw+0UO8IWSpiFDw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199015)(36840700001)(46966006)(40470700004)(4744005)(54906003)(8676002)(316002)(478600001)(9686003)(7696005)(6506007)(4326008)(41300700001)(26005)(52536014)(186003)(336012)(2906002)(6862004)(5660300002)(8936002)(82740400003)(356005)(81166007)(82310400005)(47076005)(36860700001)(83380400001)(70586007)(70206006)(40480700001)(55016003)(86362001)(33656002)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:43:39.4349
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f7488095-cae1-4ed9-b0ff-08dab01bb048
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8899

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPiBJIGFkZGVkIHRoZSBkb2MgYXNrZWQgaW4geW91
ciBwcmV2aW91cyBlbWFpbC4gQWxzbywgSSB3aWxsIHVzZSBhDQo+ID4NCj4gPiBBU1NFUlQocDJt
X3RlYXJkb3duKGQsIGZhbHNlKSA9PSAwKTsNCj4gPg0KPiA+IGluIHAybV9maW5hbF90ZWFyZG93
bigpIGhlcmUuDQo+IA0KPiBIb3BlZnVsbHkgdGhpcyB3YXMgbWVhbnQgb25seSBhcyBhbiBhYnN0
cmFjdCBwbGFuLCBub3QgdGhlIGV4YWN0IGNvZGUNCj4geW91IG1lYW4gdG8gYWRkPyBBU1NFUlQo
KSBleHByZXNzaW9ucyBnZW5lcmFsbHkgc2hvdWxkIG5vdCBoYXZlIHNpZGUNCj4gZWZmZWN0cyAo
d2hpY2ggaW5jbHVkZXMgZnVuY3Rpb24gY2FsbHMpLg0KDQpZZWFoLCB3aGVuIEkgd3JvdGUgdGhl
IHYzIGNvZGUgSSBub3RpY2VkIHRoYXQgQVNTRVJUIG1pZ2h0IGJlIGxpbWl0ZWQNCnRvIHRoZSBD
T05GSUdfREVCVUcgc28gaW4gdGhlIHYzIEkgc3dpdGNoZWQgdG8gQlVHX09OIHdoaWNoIElJVUMN
CmNhbiBtYWtlIHN1cmUgdGhlIGZ1bmN0aW9uIGNhbGwgaXMgdmFsaWQgYWxsIHRoZSB0aW1lLg0K
DQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQoNCg0KPiANCj4gSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:44:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:44:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424184.671428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLjM-0006fw-Om; Mon, 17 Oct 2022 08:44:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424184.671428; Mon, 17 Oct 2022 08:44:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLjM-0006fo-KU; Mon, 17 Oct 2022 08:44:16 +0000
Received: by outflank-mailman (input) for mailman id 424184;
 Mon, 17 Oct 2022 08:44:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okLjL-0006fZ-H0
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 08:44:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okLjL-0002eQ-1k; Mon, 17 Oct 2022 08:44:15 +0000
Received: from [15.248.2.148] (helo=[10.24.69.10])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okLjK-0002ye-Rg; Mon, 17 Oct 2022 08:44:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=d9ifgK0FuIvjPrL8CGD0oqifqyGE2vSmVhEoda0/Fiw=; b=DLwVL08rjG26SIc2lOe/zQ38zI
	ugMua3epuF+6BS/yEqJNeJAAUbPIOaewbnxWpQeaalKweRIbhhVimpb2wcjiBKxtHfxFHttoQCZpc
	k0CwPlSu1Jk9TqHaYCWV8/exRNBfIS1NQadJM7v0Z9+H+obRN0KZlWxXk7cSRO67me8U=;
Message-ID: <b61624ad-f631-b09a-0e3e-598b8982a0ee@xen.org>
Date: Mon, 17 Oct 2022 09:44:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for
 domains
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>,
 Carlo Nonato <carlo.nonato@minervasys.tech>, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-7-carlo.nonato@minervasys.tech>
 <ff6a5e85-0867-2e22-e173-15805bfc7843@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <ff6a5e85-0867-2e22-e173-15805bfc7843@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 17/10/2022 08:06, Michal Orzel wrote:
> On 26/08/2022 14:51, Carlo Nonato wrote:
> Apart from that, the memory coming from the buddy is of any color. Shouldn't it be that the memory
> allocated for domains comes from colored memory of the colors assigned to them and anything else
> should come from colors given to Xen? At the moment, the memory for e.g. allocating P2M tables comes
> from the buddy which means it can be of any color and might cause some cache interference.

Somewhat related. IIUC what you are saying, the P2M pool will still be 
allocated from the buddy. I would expect we want to instead allocate the 
P2M pool from the same color as the domain to prevent interference when 
the TLBs are loaded. Or is the interference negligible?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:45:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:45:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424189.671439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLkF-0007K4-30; Mon, 17 Oct 2022 08:45:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424189.671439; Mon, 17 Oct 2022 08:45:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLkE-0007Jx-Us; Mon, 17 Oct 2022 08:45:10 +0000
Received: by outflank-mailman (input) for mailman id 424189;
 Mon, 17 Oct 2022 08:45:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okLkE-0007Ji-4U
 for xen-devel@lists.xen.org; Mon, 17 Oct 2022 08:45:10 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff86cc4f-4df7-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 10:45:08 +0200 (CEST)
Received: from mail-dm6nam10lp2106.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.106])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 17 Oct 2022 04:45:04 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB5565.namprd03.prod.outlook.com (2603:10b6:a03:27a::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 08:45:02 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 08:45:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff86cc4f-4df7-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1665996308;
  h=from:to:subject:date:message-id:references:in-reply-to:
   content-id:content-transfer-encoding:mime-version;
  bh=agiom/3uGv4zFX2KKYUW3GwRs/WMFEWoNh3uCmaUleg=;
  b=UHUMwzaEOPvhvZ+Y2+QS13qCKtxBuz3t8t4HPUfiJOWqZh61Eyopw/C5
   neqNinaYBSHDloP50JBeKj1xF9A+yT30DIBfOo2wWaq9pcpokDTDLbfIJ
   o+m+tUTxnQDm2/0/UCWY7jCNII/x9lGSbigfwSODFczUM+kAfvLvSlIk5
   A=;
X-IronPort-RemoteIP: 104.47.58.106
X-IronPort-MID: 82866916
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:RVhl86AnfhVZmxVW/zviw5YqxClBgxIJ4kV8jS/XYbTApDgk1zZSy
 zNJCz/VOqveNmune9F/aI+zp04OsZ7dx9NgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2t4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kVPcpf8cplCFpW6
 PlbL3M/NxOPmtyplefTpulE3qzPLeHNFaZG4jRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvN+8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toij82LGexH2TtIQ6MpG36/N42Uav+zIOFEApW1K1ouThsxvrMz5YA
 wlOksY0loA77lCrU8P3WAejqnmDuzYTXtNRF6sx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDps0
 UWG9+4FHhRqubyRDH6YqLGdqGrqPTBPdDdcIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w
 HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCQJuLpzm07hl6Y0z4=
IronPort-HdrOrdr: A9a23:uWijSKFn9NkDBeBwpLqFRJHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdoZJm58erwcpVoMkmsjqKdhrNhcItKPTOW81dASbsP0WKM+UyFJ8STzI9gPO
 JbAtFD4b7LfBRHZKTBkW6F+r8bqbHpnpxAx92uqUuFJjsaCJ2Imj0JbzpzZXcGJjWua6BYKL
 Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/H2VwY+/NyLd8gYVUjtJz7tn23
 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5p+7Y23+4gowwfX+0SVjbdaKvi/VfcO0aWSAWMR4Z
 rxStEbToNOAj3qDyeISFDWqnPdOX4VmgLfIBmj8DTeSIXCNU0H44Aqv/MkTjLJr0Unp91yy6
 RNwiaQsIdWFwrJmGDn68HPTAwCrDvDnZMOq59ms5Vka/poVJZB6YgEuE9FGpYJGyz3rIghDe
 l1FcnZoPJba0mTYXzVtnRmhIXEZAV6Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e
 jIOrlh0LtOUsgVZ6RgA/ppe7r/NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woPqnfZQZpaFC7a
 gpkGkox1LaV3ieefFmhqc7jCwlaF/NLAjF24VZ+4VzvKH6Sf7iLTCDIWpe4Pednw==
X-IronPort-AV: E=Sophos;i="5.95,191,1661832000"; 
   d="scan'208";a="82866916"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bBikRUClswlDVIE1VNRpZMpJLO7LGQbpprNJjnx8kcaYtmWAgHitrLLmZyDiwsx20ISjNM3WMYlAEHpQEKPG97IuRK2xlcbQxYpGNGXM7ypHrN7JdKzFhgYiVDzIfny8QBnmbMvjW/JlrKPU6vC8Sg8ywRaDu6u4xKs1nY/eW24PE7c3SRRbYP2y7oDBw3T5uvujcjwFydWo7atY1aFeKut6us1QcTvpeFRcvEDqJXjCMDgVT7x+tMKCAy+OapgtC1OgMZrJo6Y+A6MAMp+NXhDKqIEdORmxl1sRp26gDz1AWZEPfPzzEKhMkMm+C3Np1ePVdnSNqsLhFBPND+0IHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=agiom/3uGv4zFX2KKYUW3GwRs/WMFEWoNh3uCmaUleg=;
 b=FqRuXd2nR2a85bAwfBQp+NKSft1gBWAmZhwxAjvJARBh0W4/mdQsOOplXwFe9/r9BT7cehSktGC5jnNPf+LrCPwvhUQgNaBUe/JeC7UDxcvmXSyn5DgQApbWwsB6yx3fUSlZJkw9Eps3PPSYg0pkef/bulWzF4h7cHaijoK/FSyF6tQAxQXpLe74x1mTf/fGOlLk+nGx3TouDQu0kLV3b42j6/cqYWkmeld4gvlKEi0TDa9FPskZOAoHLtumTWce1NpUAmhMrSFWAXJy/VSgOvvRI/HvvDCv35CIShAl73aPhvQQwdXwyp6CFroewlyM2mJaRa0wnBDRvd9h3GA+Bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=agiom/3uGv4zFX2KKYUW3GwRs/WMFEWoNh3uCmaUleg=;
 b=kc8ejqZqHaM9QnN0vNo+kEZedBp8mJQci6pifAMCHReK1niSPgZyDP/A0uAepDGVnRBKHoyzJ6znhsQrJd4JYHf/fE7sOr7yIAz2bFOP/zPm3rzSpTo98L2aAliiHWfFxlb04fqUmAjGDqvCKg4/mLzTml2Mt6oR+C9rPOVnMjM=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Arthur Borsboom <arthurborsboom@gmail.com>, xen-devel
	<xen-devel@lists.xen.org>
Subject: Re: [BUG] Xen build error - undefined reference to
 bpf_program__set_socket_filter
Thread-Topic: [BUG] Xen build error - undefined reference to
 bpf_program__set_socket_filter
Thread-Index: AQHY4gBZi66fKRuOSUytRGSa5NRyQK4SRXyA
Date: Mon, 17 Oct 2022 08:45:01 +0000
Message-ID: <e25a9c12-92f3-936b-82fd-cf7319592a6e@citrix.com>
References:
 <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
In-Reply-To:
 <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5565:EE_
x-ms-office365-filtering-correlation-id: c85357f7-fcbb-4fa6-cab8-08dab01be178
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 TC4QRfrJQ/RpG0tw0eIsABOuBgqgmrdAGVjAnk840rtgovLQpN3K+OLrmGG1amBylxN3M3SyYY4BmcyweTDCnt+jnVcnAV4g8pdkvbaIS4rSqiSotWIkzMYGkNBny15fVbkVQ4PbDb1LBbxreWcEtpb66OIY0VvmxoQiegwaP+miXIPheIGf3pX8WV5eMRMoypdCv3A60qYy4gA56b2TDJkITbiuhE3LhzpiJbGPjXax3JQwbcK/pQNJJbCNLrc/wSr5Jiv9ZyEvsMUr3qe1/hs+o7NrHBGd4wbml1KUqnLbIlO5zksRwoPlQCo+sSKanfiRmwBKzP1l8qYY7pUIinZzfo0V1fkzhQpiCCZKWnziuI6RsYS9SXOQraTRJOn/j3sE/MN3L9TswekUr8XL2d6KGnxPepV+plnS/AVYpbKMJK3mrKFtwkfFQnf5D/K1gJ79RLBa1SQQ8Brv917h7wILmh2yJr/x1j1hREZlSOLAtyveN3Mrr7MXeCvfjj1B8uMhQdbqP2BW1vg5pVrRVxjZeIWRti3EVABWLpFc2LyK9mI6qkYhn3ea/tcw/1q5VomY0+xq30sBktHB7j6XsAV4S+UzYFrhSttGx94rVRbMj4f+6AY1SX3TfGd6NYE0QrhZzgW2j8Qsy28z+AdFeHZBfd2j7bzqTH8TZP3QxcvKQcyInxl/VZZMzHTaa8h8oOlvhMW99Q1R9jn4RvzFJBRrzNQpzGc/oIjYJeUjMVUAVSFAaZ9cPRQV3lhg/7vvGiW/yC3tAS+zToynAbqtOL6FzIHFxLh586h7A3i/BiOkaYzYMhiSkTXzgb4bocbX
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199015)(36756003)(31686004)(86362001)(31696002)(2906002)(5660300002)(82960400001)(38100700002)(122000001)(2616005)(186003)(83380400001)(38070700005)(26005)(6506007)(316002)(53546011)(966005)(478600001)(6512007)(71200400001)(6486002)(66556008)(66476007)(66446008)(76116006)(66946007)(91956017)(8936002)(41300700001)(64756008)(110136005)(8676002)(101420200003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cytZRm9BcDFrRVc2QXFlY04zRHFrWHVwdVp2dFZ0VnlJMjNuYmF3eXBoTzdK?=
 =?utf-8?B?bSswWlM0YU9YdkdCYUdqeTRxMWFZT29RNnFnSUYvRm0vNXlEUHpDbjAwWlhF?=
 =?utf-8?B?MTBxL0lmL2RzUXYyelBBSTZFbVdVZ0RrWlo4MTlMcERmNEY3T0d5U2hlb1Bk?=
 =?utf-8?B?TWFvcDdVbjZtemNHUVRwL1RxOUd3SVlPYlBYUzNQZ0x0c3E0dlJTaUlXNlJO?=
 =?utf-8?B?NkVxK3lLQWltdjRXU1g4VGdPZEJ1QnlORzkrZ1JOUVR0WTFpQWRQMUE3eHd4?=
 =?utf-8?B?ajU5TVFCamY5SDhPNmkzaDNuS0RETXFTVHBBZkUrdUFoamJ3NnRhTm1GUkpr?=
 =?utf-8?B?ODh4UEN6ZUJFUE8va1Z3NmtiYmZZNWVKTlgzVm9DUE5PMXlua1FsVUdaR3Zw?=
 =?utf-8?B?TlNFYlM4ZzRGN095Rk0zV2lHeUNoODZJMXA1YTVSV0ZKemRBdmdxUGtyZHA1?=
 =?utf-8?B?M1VmUjl1czFTZjBWUnp0b2JBK3lzeGxUekxhem8vWlhJTUlJZUlFbm45MEhK?=
 =?utf-8?B?c01EaGNrQnluR2NqZjJhU0V6Y0Mxekdhdk5BVTFJK0F4VmtOSVFFQVdXa3A5?=
 =?utf-8?B?Q3l0ZzEvdlpVbzMvR2tVdk1Xc1dCN0tlbTZsTnJ1NnIrOTNEQTIwYzl1eVRL?=
 =?utf-8?B?NGVmbCs3VzVoMWVIK1l2SjNlL2V1bk1BeUlHRGF2dnRFYkdib2lLcUlQS3Iw?=
 =?utf-8?B?MWg4YXcxVG9ZWlA5QitmaGVJY2pVVHdYeFdWWSs4SFE1OVd1ZWtZODVsQ2lW?=
 =?utf-8?B?cjU1bnNoU0lxQ3FFdWNLY0UxVlJuekxycWhuRUJZRXhuOVdIQ1kvNDVWTmJo?=
 =?utf-8?B?eDNGaGVTUjIrcUF3MTdpZjBYNlNjMDJhaGRBOFBZWk5GMTNIMGZrOUVURFFn?=
 =?utf-8?B?ak5GazN1QU9QU293bGpQU3pSQU84aUJpaGt2UUp2Zkt6NkJzcm1EYmJWQXRw?=
 =?utf-8?B?bmc0NSs4cWFjZlJONnFnbGJCRFFaeHlnWjFudEVEWWt1alY2b1N1cWlob2Zy?=
 =?utf-8?B?OFdBLzVsWTNKYVRRRU44OEl4K2ZqdmFGN29RWXZteVlDUGo4QzlvbzNoWXJP?=
 =?utf-8?B?b0dvSVZUWUNXTzBZcHcyVkl5OWkzVUZwbUtuUkYwSDFXR25HVWVISkRtNVRj?=
 =?utf-8?B?YU9JWm03RzdTdjFOb3c5bGIwZWJTMlZ5bjJ3S3hYc1JMU1JFYnBXY0lweHNl?=
 =?utf-8?B?aUdJcGxEZUZrTnhHMGRGQWVjZUxlREVsc0RKV2JJZjY4L1FlV3ZqMEV6ZkJ0?=
 =?utf-8?B?VmpibmF5UDlVNkxBS1YrVStEUllzZkF5dzdRaEhnWENDUDJPS1lYQlU2QzM2?=
 =?utf-8?B?T20xS21BK3RhUTB2R0xRWndBT1h1MlZ6c1JlVDBhNXJQUjBPWjBORUNaVnFj?=
 =?utf-8?B?MEF5eGlSOTVqUFZaWTRoQ3NOcUVVMm9wZ3dGUFowc1BmSlZuQUNYRVhsMyto?=
 =?utf-8?B?UHR1cHk1UjM2K0pOMy9kMEZaK0xadllDemttM0JlclduZThjb1JTSWNMWTd5?=
 =?utf-8?B?TytJaG9OVkdsVkFZdGw4NnoyelExSXgydTZDdkszRWtiOWJ6YnhKbXNWdEd0?=
 =?utf-8?B?bFRZaXB5cHFCYWFDOTlJeW1Dd2lPcWFtdHZmY1ZYYjJzeTJsN2FjM2krM3ZX?=
 =?utf-8?B?TXFOUUw3YklSRWt6NDFkMXNTM211NWVxZTFHSXNHRGlCcHA2WEl4NlJGdkhI?=
 =?utf-8?B?SGZYYTZWaGtMaXhpNXRZc0NRL2lYSElmOXRUU1FwSm5ka3pBREVBT0NraXVG?=
 =?utf-8?B?RkNtWDJ0Y3NCWlM4Ujc1TUpobEpualhKOVRXNnVsd0tVZi9DNjFPbXBhQ2Q4?=
 =?utf-8?B?SGVwUUFCaXIyZEYreEdOZnIzb0Uvb2VFb3EySjJwTGhOZ3ZiQ0xscEVmVnlm?=
 =?utf-8?B?dzhDZlpoaTBXa3lBZmNpOWRNTWVMd3BHSE9hYjZGcURxODN5b1ZBejB0Tks3?=
 =?utf-8?B?R2hOcllvYlYvbURjeG1ybDJsMVZEVnlYa3djQXNtVFFyUTlIUmFpcTNnY3J3?=
 =?utf-8?B?ak9KWGRhejRPZDNUK3N2NnIzK055OHNMcVc1aFlGSW1FSXRJYVFpckdyeTBH?=
 =?utf-8?B?bmJaaG5Eb29rdU5Qb25xSzBaZEFHZ2s3d0hVSXZOcWJGcW5wSGo5TityVzVI?=
 =?utf-8?Q?Ai18d9H0wra+aSSzQmFC2k8aF?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2B6F7D854649B24085372E0705C10B7A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c85357f7-fcbb-4fa6-cab8-08dab01be178
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 08:45:01.9116
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fHVl5YoC/C5udwZdbdY4JkHIaZ8Z9qiBz8PNymwEYu/Mpt502UJNOQhDORTPXVHMyPLUwNZII73X2XsmWqWmdr9TbxUs5SGkKBid3Y7t3dw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5565

T24gMTcvMTAvMjAyMiAwOToxMiwgQXJ0aHVyIEJvcnNib29tIHdyb3RlOg0KPiBYZW4gNC4xNi4x
LCA0LjE2LjIgYW5kIDQuMTcuMC1yYzEgZG9uJ3QgYnVpbGQgYW55bW9yZSBpbiBBcmNoIExpbnV4
Lg0KPg0KPiBJIGJlbGlldmUgaXQgaXMgY2F1c2VkIGJ5IHRoZSBtaXNzaW5nIGZ1bmN0aW9uDQo+
IGJwZl9wcm9ncmFtX19zZXRfc29ja2V0X2ZpbHRlciBwcm92aWRlZCBieSBsaWJicGYuDQo+IFRo
aXMgZnVuY3Rpb24gaGFzIGJlZW4gZGVwcmVjYXRlZCBpbiB2MC44IGFuZCBoYXMgYmVlbiByZW1v
dmVkIGluIHYxLjAuDQo+DQo+IEFyY2ggTGludXggdXNlcyBsaWJicGYgdjEuMC4xIHNpbmNlIE9j
dG9iZXIgMjAyMi4NCj4gQSBkb3duZ3JhZGUgdG8gbGliYnBmIHYwLjguMSBmaXhlcyB0aGUgWGVu
IGJ1aWxkIHByb2JsZW0uDQo+DQo+IFNvdXJjZSBhYm91dCB0aGUgZGVwcmVjYXRpb246DQo+IGh0
dHBzOi8vbGliYnBmLXRlc3QucmVhZHRoZWRvY3MuaW8vZW4vbGF0ZXN0L2FwaS5odG1sDQo+DQo+
IEJ1aWxkIGVycm9yOg0KPg0KPiAvYmluL2xkOiBsaWJjb21tb24uZmEucC9lYnBmX2VicGZfcnNz
LmMubzogaW4gZnVuY3Rpb24gYGVicGZfcnNzX2xvYWQnOg0KPiAvaG9tZS9hcnRodXIvLmNhY2hl
L3lheS94ZW4vc3JjL3hlbi00LjE2LjEvdG9vbHMvcWVtdS14ZW4tYnVpbGQvLi4vcWVtdS14ZW4v
ZWJwZi9lYnBmX3Jzcy5jOjUyOg0KPiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBicGZfcHJvZ3Jh
bV9fc2V0X3NvY2tldF9maWx0ZXInDQo+IGNvbGxlY3QyOiBlcnJvcjogbGQgcmV0dXJuZWQgMSBl
eGl0IHN0YXR1cw0KPiAuLi4NCj4gLi4uDQo+IG5pbmphOiBidWlsZCBzdG9wcGVkOiBzdWJjb21t
YW5kIGZhaWxlZC4NCj4gbWFrZTogKioqIFtNYWtlZmlsZToxNTY6IHJ1bi1uaW5qYV0gRXJyb3Ig
MQ0KPiBtYWtlOiBMZWF2aW5nIGRpcmVjdG9yeQ0KPiAnL2hvbWUvYXJ0aHVyLy5jYWNoZS95YXkv
eGVuL3NyYy94ZW4tNC4xNi4xL3Rvb2xzL3FlbXUteGVuLWJ1aWxkJw0KPiBtYWtlWzNdOiAqKiog
W01ha2VmaWxlOjIxMjogc3ViZGlyLWFsbC1xZW11LXhlbi1kaXJdIEVycm9yIDINCj4gbWFrZVsz
XTogTGVhdmluZyBkaXJlY3RvcnkNCj4gJy9ob21lL2FydGh1ci8uY2FjaGUveWF5L3hlbi9zcmMv
eGVuLTQuMTYuMS90b29scycNCj4gbWFrZVsyXTogKioqDQo+IFsvaG9tZS9hcnRodXIvLmNhY2hl
L3lheS94ZW4vc3JjL3hlbi00LjE2LjEvdG9vbHMvLi4vdG9vbHMvUnVsZXMubWs6MTYxOg0KPiBz
dWJkaXJzLWluc3RhbGxdIEVycm9yIDINCj4gbWFrZVsyXTogTGVhdmluZyBkaXJlY3RvcnkNCj4g
Jy9ob21lL2FydGh1ci8uY2FjaGUveWF5L3hlbi9zcmMveGVuLTQuMTYuMS90b29scycNCj4gbWFr
ZVsxXTogKioqIFtNYWtlZmlsZTo2NjogaW5zdGFsbF0gRXJyb3IgMg0KPiBtYWtlWzFdOiBMZWF2
aW5nIGRpcmVjdG9yeQ0KPiAnL2hvbWUvYXJ0aHVyLy5jYWNoZS95YXkveGVuL3NyYy94ZW4tNC4x
Ni4xL3Rvb2xzJw0KPiBtYWtlOiAqKiogW01ha2VmaWxlOjE0MDogaW5zdGFsbC10b29sc10gRXJy
b3IgMg0KPiA9PT4gRVJST1I6IEEgZmFpbHVyZSBvY2N1cnJlZCBpbiBidWlsZCgpLg0KPiBBYm9y
dGluZy4uLg0KPiAtPiBlcnJvciBtYWtpbmc6IHhlbg0KDQpTbyB3aGlsZSB0aGlzIGlzIGEgYnVp
bGQgb2YgWGVuLCBpdCdzIGFjdHVhbGx5IHFlbXUgd2hpY2ggaXMgZmFpbGluZy4NCg0KVGhpcyBj
YW4gYmUgZml4ZWQgYnkgY2hhbmdpbmcgdGhlIHZlcnNpb24gb2YgcWVtdSwgb3IgZHJvcHBpbmcg
cWVtdQ0KZW50aXJlbHkgYnkgdXNpbmcgLi9jb25maWd1cmUgLS13aXRoLXN5c3RlbS1xZW11PSB0
byBwb2ludCBhdCB0aGUgbWFpbg0KZGlzdHJvIHFlbXUgcGFja2FnZSAoc28gbG9uZyBhcyBpdCBp
cyBidWlsdCB3aXRoIFhlbiBzdXBwb3J0KS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:55:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:55:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424200.671450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLuM-0000TF-2R; Mon, 17 Oct 2022 08:55:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424200.671450; Mon, 17 Oct 2022 08:55:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLuL-0000T8-U5; Mon, 17 Oct 2022 08:55:37 +0000
Received: by outflank-mailman (input) for mailman id 424200;
 Mon, 17 Oct 2022 08:55:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=z+Xv=2S=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okLuK-0000Sx-Ia
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 08:55:36 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80055.outbound.protection.outlook.com [40.107.8.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 765b2a1a-4df9-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 10:55:35 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6984.eurprd04.prod.outlook.com (2603:10a6:20b:de::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 08:55:33 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 08:55:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 765b2a1a-4df9-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VBPM3sSys4y6h7re5Wihw3XmxPz5CuJpBRDs1XKyUKDgFfxLm8foL16Uok5W7uniAOsYkO6veSKCeV1fx/FXJOgt6BExBXT62W+94fpxKiNoJ0e7AgJrynrdx9NjA9Vk0KDTe3qkYiOIdealSK1OXyf8+XtHlsqw8g/Q/lcLp+IDGS87/O+VFaMX0lunW3/v3rEq0AfVzJ1ZRNphGCUsy3lzuMez6qMmciB0jJgdCqn0PlUVioq/4CPdNxWWlvENN3B/08bzBwG9Ljjv4IXFz/0L6BROb0KLv539E8iOQT1Q/rFncrKNfKHotC+eXXlp7flVQ1vB6pITlbl7UVoniQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7DHxrCnKMCK7Ld609K3m/CjFfyYBY1XExiR573qMtMs=;
 b=H6BufnOk0GwTIttlKHGoZaPPcd7y87m6aouXJ+wpG/cYD70ga3IqKiAd82MF4hcv5sZ86w60Ofppu4MmatJC+kRF0ijLA4Okag7uyv92ihCwV3f6WpwqABFjZzZHmGjiECOdVSyedbqlN+mhBaby48J0eAdPvfwEQvh2e0HG04+LYYk0Kr59JNjhliYwqaa7uyn7oVpd8zkaHh7dtVaU7scqeM6TdA0isPiHx0l0pVm3vJE/FKKN2aXXcOam5xWwcweiCa+MtXQxxhEpcYjr93Xg93tJ7ApOl1Q2gT9Fnxg4Wuuxac+Hh9D7UHVX3cDWGzX5qk2ClnsWDOYy5AKphA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7DHxrCnKMCK7Ld609K3m/CjFfyYBY1XExiR573qMtMs=;
 b=MHQWocAJX1aVWftgl0KIZKlOkd3k8ZHKGU4lafX4y1ulWw2STRDuoXHBLkXeovP9kfBuir/T449OdNZdjnKkHgyFM3gpdsM5gUraPEEMcDAeRuP4nF7OR8feXyN6dgW3mGQSS76z66rMLNTjlUWxwDWosHeTjZ07Ke6WLZItz/2HgXNecWr9CRrDuK/matkIXOdJ6/XVlbdVKFLeo8ZhRBypo5NN4DWEbbOpZdhjSsJJTycyLEHEoK97dCqq0WijCfa7d47lt04LyIyJYuW9Zgs4Tp7trc8ee1avaS9NNImN+csQ+0L+PBkXd86XSFjuntL8YiBsU3iHZ19BqvAx/w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2214fd86-0cfa-58ef-39db-6f913a9de75e@suse.com>
Date: Mon, 17 Oct 2022 10:55:33 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.9762b1190a6fd8f0232c26cbace1b2c4f8555818.1664458360.git-series.marmarek@invisiblethingslab.com>
 <ecee2217151efd08b2bae58166efcdd319ec82c8.1664458360.git-series.marmarek@invisiblethingslab.com>
 <Y0s5Xvr5PBQq5pVB@mail-itl>
 <AS8PR08MB7991A2F3DE5A5B55ED3D09F492299@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991A2F3DE5A5B55ED3D09F492299@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6PR0202CA0060.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::37) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6984:EE_
X-MS-Office365-Filtering-Correlation-Id: cb62d52d-53e3-4d9d-eec9-08dab01d59e9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hmN/2kFXsxZZxNawwz354ZYeQ8D2wjCQ7Udx+OIQBT+8a5Z4qXTBkKHkzHgvLouJ7SFycmX1MAjHNH6RFcfNC3tFDuLOy7r76ESx1OSbaitv5t30srIhG5TPXUz02GnNE3uoh6rg8e1UT0xo8u5HHcnMK9Ing4VZc9vlcZoM/IFdjc73EPTk1Tkd8PSl3YQg0at/2QJFFx8EvbrKRRX012c17RjuRRUJ+XKab6+Q7oD3jPvREnH90wx27FFH+sZOf5oRETu9ZDBu0wz6mKjtVo80N1WxrmpEm63enwKj3P3d3nYlfpzgYK5/S+fxuRVnoeSGCtUeJhzhd6BPSGMaG2xSWFUjyio2VYTjFGn7k3myAqBKTVGxyLS5Mw2E/C7uwJMpdpyEJiQ+ObRQJjLqaCkPxBKpd8p7BjC19cGpZk4+e/E2II0vI80fsMZtJ1Q+Ibvikqh/oJZV9w7+oosXKO3KhV7cILmx7xnZryjCb8+obSOh16GO2fP3N9fU3HCRn8Ms0ydCFXd06DAvFQEPkTx0RvcN3EGN/ay+Oi9mZ1sbvBmvRUCnpzhHPmZFcW3CR0DdL24f2R1FSlVmeX3wsxHNcu8lLVVRW72ywQJ8NVD8bFjfFXxfHchCeXQIMZ0HdvbKua5yH8I3KMqrcdMG69JVDcV8HUfF3FyXPuvelxCXCrS2E5N8fazU87wYPPffsj7RqsABPS9U3vgofw33gt2BS5yQMPwQnqtd42dHjgumbA4m/OodqFMEwoYWao0VEWshTJsYJ+i+bqrhZxZpHWJ7oWfUcxkqn0s5synOS3Y=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39850400004)(366004)(346002)(396003)(451199015)(36756003)(31686004)(8936002)(86362001)(31696002)(5660300002)(54906003)(2906002)(38100700002)(2616005)(186003)(6916009)(66574015)(83380400001)(6506007)(53546011)(316002)(478600001)(6512007)(6486002)(66556008)(66476007)(66946007)(41300700001)(4326008)(26005)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M2tkd25HeHBuYmhFelV3eXRsdUg4OW5kbVRvaFVudlpOVUNoMUpPUjdyQWM5?=
 =?utf-8?B?dHl3OGlMeHR3eHoyTTZwOUR4b3JvdDdEQzVjaVc2aklUZ25CaWNTZnYzckNR?=
 =?utf-8?B?bVpjSGhjdTdvOFVXSGhqakMyM1ZzejZxalUrRW9FS3JVTzFlTmQ0WklZUHRP?=
 =?utf-8?B?LzhtOE40cjRnS2ZJNG95bUh3NS9MU1JKY2x6aEQ4OFNkVDlrOXlVakRsTE5Y?=
 =?utf-8?B?VHdqemE5QUdacThMcVYrT2RIZmwveFRYdndNL25LOGVtYXZWK1c1R01oZGJP?=
 =?utf-8?B?anVrWmlXaHlld3RROWk3SjBKQUVGcENLdmE3SXpoZUk3TVRraVNudkw5UWY1?=
 =?utf-8?B?U2pRYnpRcjVmbVJKcHJrV1JucWFmOElHOFRCMEM3UXI4dTM0SmFDQzdWMENi?=
 =?utf-8?B?ZmdqbmFvOXVEUCtoa0lITTRpdWQxTUV4K25LQlYzeU16dzJZR0RxbTVhcWZa?=
 =?utf-8?B?cWJ0Zy81cTR0NS8wOUI0YStRdDU5aFlTWjFySkUxSlJwdTl2dWxLNEtzYUpB?=
 =?utf-8?B?S2FoVE1uRy9pT0daSVNMLzBzbW1KaDl6cDE4SXptdEtacmlWdWV5QmkrRTFl?=
 =?utf-8?B?TGI5OG16RmlrVnlNZTJ0aUpvb2ZNK0pBNXNuMFVHS2NaSllFdUxtb2VLTkpj?=
 =?utf-8?B?enhHWjZwdCtkUitUdVBnOFJOcWxNTVdXMVI3QnAxRzlrYXZkallLZ3ZQaGhF?=
 =?utf-8?B?WVZrN2U0aHhmczZaUHFydDFtQmM0aFVTL051YVQ2ZEczSUJhZjBUME9rMHRi?=
 =?utf-8?B?Y29DVDdNR2ljWDZOelJta3dmVzVwcGZLTjJlWkJlb0dNVFdaanU4RjJlczgr?=
 =?utf-8?B?MFR0QnlQenRpSEQ1d3RpdHJONGVBSjdBWTFQM3JXOGRIZ2dJbVFkcjNtQ3kv?=
 =?utf-8?B?b0hwRHFoVlhJV2sxVGtVbnJGdDBveVBialZQRDVxTklxcVpLbkZJUmRWTWRr?=
 =?utf-8?B?d00vV1hxUEY0b0pZdWE5NlFIYTBSS0lEeDNmd0lHZjZVM1QvNWE4V3JjZ3Fk?=
 =?utf-8?B?bVRLRURNdDBtTHVjY0lwNHhHTXlNM3h4dVRybWN2cHViMGkxelJPcndTc0Zi?=
 =?utf-8?B?SVllZ2F1UDF6U1A0YXFOQlFVTUdqTTNMd2t1RGNydkJLTlo4QkNscDNGajJF?=
 =?utf-8?B?bWFibHEvZS9rSy9Id3pzMS9oYTM2SjMwVnJQVmdWZHdYemdDSGV5Mk5GMHFp?=
 =?utf-8?B?VlE1aFNrS1RZSUJCdUFRMVdPam1vYjFSZDBqU2NLa09ZQlRtaEg1Umt3L1pP?=
 =?utf-8?B?UzNSSGdJQWVRZjRGbXY1LzV2NnYvcEdQVW5rMk9VenpnT0I1RHNuQ3Zmb0RZ?=
 =?utf-8?B?QWI4SEM3MVdJLzZvN3ZUQTRjVmI0Z01BZWFlaUdyRlVvcW9mQ3hvUEdDWS9R?=
 =?utf-8?B?MW41RjUwenhYRlRrZGlCcWhTMjlCVWVKQUVXMFVyYUFJeDBHaVZSVDE3d1RB?=
 =?utf-8?B?VkRzQXk4S0s0eHRUb0dlSE1XNWtMdDRWZXpZWU4zQ0lZTkVOazVZbnJQY0JX?=
 =?utf-8?B?NjFaeThocmprYUpoaXJsQ3h5QlNudXdONjZVQ0QwTDZUT2taYTBmTXBGbzFl?=
 =?utf-8?B?MVRjZjhKYlNURFFmRUFFMjlOZ0dzcldwV1d2RnB4VG45Tmp6dEs0V21STXRt?=
 =?utf-8?B?c2hVTXZEdGkvbzJkdlFNTHI3dFNQZlVYb2QreHUrZW1tZzJxTzI3NlgwODNN?=
 =?utf-8?B?TXN3cnVKVVp1S2h4Z1Zmb25YZVJnN0lKTExVM0NIZGVaQmFuWDlMRkdEb0Q4?=
 =?utf-8?B?dWxRYkl0bTh4VkJQWm83OG1paTB4V0FqSjB2R1dYT0pVejNDTHFpRkFWWlE2?=
 =?utf-8?B?bmV1WGs3K2wwclFoeU01azlHMWdTMDcrNVI5eUFpaGNOSW9PZysrMzZsYlhh?=
 =?utf-8?B?MHdJdkd5b1diZ3hDWTJndTZBdWJRcHBPSElLamM2WTlMV1JzaTFaL0RnelU3?=
 =?utf-8?B?Y1V2S2ovWC9uQnNJbXRrNkg4amNWeU9NMFRZZ1FiM0s2bnJPeE1qL0Vndjhi?=
 =?utf-8?B?UEt4R2E1SE5VcGZvSWtvc3BtdjVTRURhZ0Fob1RyL0k1dk4wQWo1dTVQUEVW?=
 =?utf-8?B?eXFBaFlzNURHNkNUYmNmOGRJUGhBdU9pY2hFWW1TcElRUnMyUVd2ci9ZeG11?=
 =?utf-8?Q?L9EgrwfuiFi1l4UMTr6JIAt+s?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb62d52d-53e3-4d9d-eec9-08dab01d59e9
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:55:33.6796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RKVEaW2/1M30dms9OAqByTPoarQLdDVOrhEuCtUkA245lg0J7nDOaX0kn8AYYHIkijcBde2bDVogLFGopzfsvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6984

On 17.10.2022 03:20, Henry Wang wrote:
>> -----Original Message-----
>> From: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>>
>> On Thu, Sep 29, 2022 at 03:33:12PM +0200, Marek Marczykowski-Górecki
>> wrote:
>>> Re-use rmrr= parameter handling code to handle common device reserved
>>> memory.
>>>
>>> Move MAX_USER_RMRR_PAGES limit enforcement to apply only to
>>> user-configured ranges, but not those from internal callers.
>>>
>>> Signed-off-by: Marek Marczykowski-Górecki
>> <marmarek@invisiblethingslab.com>
>>> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
>>
>> Henry, can this be included in 4.17? The AMD counterpart went in
>> earlier, but due to late review on Intel part, this one didn't.
> 
> Thanks for the information. I agree this is a valid reason, but to be
> safe I would like to hear opinions from the x86 maintainers (added
> in CC).
> 
> Andrew/Jan/Roger: May I have your feedback about this? Thanks!

Hmm, not sure what to say here. Yes, it would be nice for things to end
up consistent across vendors. And yes, the change here is largely
mechanical (afaics) and to code most of which shouldn't typically be in
use on systems anyway, and so should not pose an undue risk. But still
it is quite a bit of code churn ...

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:57:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:57:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424205.671460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLvv-00013H-BL; Mon, 17 Oct 2022 08:57:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424205.671460; Mon, 17 Oct 2022 08:57:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLvv-00013A-8g; Mon, 17 Oct 2022 08:57:15 +0000
Received: by outflank-mailman (input) for mailman id 424205;
 Mon, 17 Oct 2022 08:57:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okLvt-00012w-Hz; Mon, 17 Oct 2022 08:57:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okLvt-0002uD-Ev; Mon, 17 Oct 2022 08:57:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okLvt-000704-3Q; Mon, 17 Oct 2022 08:57:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okLvt-0007aZ-2p; Mon, 17 Oct 2022 08:57:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jheD/ljqMBmBsq/nkClWr6CStJFxlWk0rIo/I+XQDGo=; b=kf12wRXOiobomSCP2Fg0wk0xd3
	hwaYAGnOkY/s+wFeEfbktUZ8laAimowI/FdXRuy6qERLIUkHDweFX/lMCvbcwWtB+3cqwaQp6HbGi
	U/ZNoG7aVHwWokn2MZYuk7ANiEXNVk9qdE87bF/1vVNuUQut7bm2jka4R8+M9dkOtVQA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173979-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173979: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 08:57:13 +0000

flight 173979 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173979/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173973

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173973 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173973 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   36 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    2 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 08:58:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 08:58:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424214.671472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLwl-0001ez-Ou; Mon, 17 Oct 2022 08:58:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424214.671472; Mon, 17 Oct 2022 08:58:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okLwl-0001es-M7; Mon, 17 Oct 2022 08:58:07 +0000
Received: by outflank-mailman (input) for mailman id 424214;
 Mon, 17 Oct 2022 08:58:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=z+Xv=2S=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okLwj-0001WJ-Kj
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 08:58:05 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2086.outbound.protection.outlook.com [40.107.104.86])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cfa193ea-4df9-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 10:58:04 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU0PR04MB9227.eurprd04.prod.outlook.com (2603:10a6:10:352::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Mon, 17 Oct
 2022 08:58:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 08:58:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfa193ea-4df9-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l171V+zMgIAFQLvOSU6YiKpsQzKQsbamBzv9vt71gPmxTBMeV6N6NKas4krQHWohbDB1ftUEt35JfiWeuWq+mpOlHKGULANPThzmPGLo9y2xeba5DQSbYLmF1zPBaLnAA8zivrm8lma7dED2LO4vnckAqjJx3bK9ncIc4z4snXsTJ4oLIQqLwj+nkfQkbCcESY3X5o0MsPJdWUmwMjLzw8t1Y3nzOvkcv9oAx1UQbHENao0NbRpQdNd8GF2MuS/xdVbn8BOnmzXUdmEoMyiME+s92rSqL4CHTvqDnoNCL024JkrpnSBW9HleeytZOx+s3sdClkauL4axOTECtbeQ7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r8ZPteuKXnMCvcc9aLo97gd0lWtGPEbdX+3VRAr4tlI=;
 b=OtxgFWkfeOx7RpQKwsAlJQdYstE0RUFkMAzfOiVmZ7gmLu6fa9zBqGj5SWAq5LOqvorqdx+2rv6aHtgQvkq0ccZEXywEAe1zXFabhq8sc26mnQhMyUIUBFK755XfzMIfZr9vWMYlcUca8aK9l6sCPtp8gtGO2HNhR2nVNW+KM8y5PRAt0Tuhe/cljk3sf5dhUPsVQGnCt6bSX0DKK3X+CHu8mcDtWNDWrSSqjkMSZLeqM51AOrq9f210FhtsbVOmldMCbvOKnYvkNt+nSyY3VlkSB8Hga+VVBItf8XSr+CVMTOlZSUPcTf+kJDsO+4Io/tzGPy/Ga8gRMPaSdXsD4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r8ZPteuKXnMCvcc9aLo97gd0lWtGPEbdX+3VRAr4tlI=;
 b=XGgRdcNeRi1JRYYf19n6cV5F6k7eVTu25mRS2sRLcYsnE4cauweexxkJNcbIoqeJMw3jROHoya2sfqKkXn4j68tPOZo6smwjRmuT7yAdahJ4coWKTQK6JPD09eCQTMOF/3pLe2uydaSzUA4JR08FPODcjIh/zoZhCMC+A0zgxfgOeXntU0OZUEFC774TOTRB6phffPW/t9S5nmy5fG4K94NzUJLym+cxMrJkIsDaqgrFVGNPbtAXFutmbm9aa/5umTWgj6uggLy5EKEL2YLvF6m2r71ivUxGoDv1HZg3CjnE9/7YGi/fXcJGM9eDklOJWO2ZQ6ND9UDwavmvBEprzw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a2af81fe-c227-21c1-8ff0-c1fbc2013eca@suse.com>
Date: Mon, 17 Oct 2022 10:57:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Julien Grall
 <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221014080917.14980-1-Henry.Wang@arm.com>
 <a947e0b4-8f76-cea6-893f-abf30ff95e0d@xen.org>
 <AS8PR08MB7991FD5994497D812FE3AE2E92249@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9d5ab09e-650f-118d-0233-d7988f1504f1@xen.org>
 <AS8PR08MB7991976335ACE7B47A3FCB9792279@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <9c82cde3-fe46-3a3c-20c1-70bd99eb28f2@suse.com>
 <AS8PR08MB7991A3DF126C3B68E198AD2792299@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991A3DF126C3B68E198AD2792299@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0301.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::7) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9227:EE_
X-MS-Office365-Filtering-Correlation-Id: 810c0547-d941-4874-39b2-08dab01db2fd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7fC1aOVVsQjQDVAJO8Se/K0alT5S8KV30DYKjWerfuXvdzxgWni7kHFLEsxEOAq0p6bYST24JZYj11jNhR013aXT87HqTdie0jtDYLScFSk+/+b4dqIdghfmahhmeK/BF1WGha6Xg+qwoyVr5SgcRRTn39KJWGImUfiufgOElNa7m3HJa37CcW7Y1FQ+utuFFAjnEhAIYDEQDEkKDYkTb2AmDYDdcNJOPWXfLO1d1WSM16EK6VEr9ci+T+1eSiQ0bDhauVE4UQUES3RCE4bjqvLMmKcFFIlD0Rf6N7wq49wHoM4oH+XsvfjQianAuI58DqIpv12XESyR0z4rLL3JG4E5gAHqkyG56671c2wEWAWZoVD+Ui3adC3WXwekL8jshVNGgXI5M+xWhwa4l+JLla314i0J/H+Ha1aP/8plXQADztLqogF13vqGN+tLrP1vMlWCcdpB6J++lZVDkPULhYv1NFOweGAPRLw87yaV+sH1SDvS2rhnYSIaI2kc922XYysON7kVc1sAZbQaZJOj5QelEEP4ZnRFPFUm4gczYtGJM6P9F41jdywI2c+S2KdrCNe0D+Bsc7zmSPDOfIGycGIr5nZgGjC8MLMNwZAe/PXFSIv7sgsTQ+IpGDc0zzvL0RP4gM+ML8uobIAY4O0U5l0san2aVGOICAas5KNNWyDO+2AaFFmvTSkD+/ARfb6szkqBaMuDI/D+eID8GL5PzzNTjD1FY+4U2zU5mDzhoj6WT4FpG7Q4WZATi3YBv6xR+XNP1j7jXzJ5ZW1ubnCCo+/p09aoksnG2vKLH1WqWQI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(396003)(366004)(346002)(451199015)(53546011)(478600001)(6486002)(31686004)(186003)(66946007)(66556008)(66476007)(8676002)(4326008)(2616005)(41300700001)(8936002)(5660300002)(6916009)(2906002)(83380400001)(26005)(6666004)(38100700002)(316002)(6512007)(6506007)(31696002)(86362001)(36756003)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dXBnRmkwa0FhQU5VK21jZm15SXFCa0pPM1I4NklLRGs0NkZIL3lHWEVvcVBh?=
 =?utf-8?B?WkxKcGMwcnRsRFhCN1JTOXgwcGhDNFFCMVJWVnEyWXIxUjErWkxQUG1EUVpy?=
 =?utf-8?B?Q2VYK0pvZktLQWtmcDZIY3Bpc0JNdmRORW5aTitOWDljcVU5b3RTVW5FYVhV?=
 =?utf-8?B?K0pQaEVtTnZGbjdSU1hmdWRiUnV0UnMwTXNOOGJmM2t0b25KWUxnQlhhelBB?=
 =?utf-8?B?MkJaM3ZOV0owZFZrc1k4YjgxZVJuQkwybUdTTG9KUTl2SzRYS2dnUTR3bENq?=
 =?utf-8?B?eWdmVUNhZXVtTTFZcm9TaDJxNXQ2Q05WN2p0dkJWK09CTUpPV2dIM01mY1JQ?=
 =?utf-8?B?S3dDSDFFelhyZzlYaEZTSkFUMC9OOEFkTFZveHJRNDNtQ2tDQ0Yvb1htb2d2?=
 =?utf-8?B?YW91ZmFEdzdNd3F0MTZmQ1dlS0xJa2JtdHlLQmRNTUFrSFlWclgybXdBZUsr?=
 =?utf-8?B?cloyUHltaXZFOTZLMlNOSkxjOWN6bnN1Z3BueUJrbWtXOEs4bkxyUDIzdXJ6?=
 =?utf-8?B?TjBwT3FJOHRnNFBYUVlkTnc5clVrT0FDMUtpT2w3TjdtY0o0UWhCMCtZVlpj?=
 =?utf-8?B?dkxrWTlTVVc5T05pZU9LNmpiYzlDY0FjR0xRcXg4dWFpSnFqM0xhSi96YUNu?=
 =?utf-8?B?ZUo2L2RQeWNoNzZiT296YmpWTFUzREwzektwNGUzVElqazNiWVRmYmhmUGcw?=
 =?utf-8?B?enlIbERDUTVkU2VkZEw3WXVqQWlVY0Rrc2JlNXc2bXJEbERRSU9nREpReTN4?=
 =?utf-8?B?OWVFeVRCeUxsVnFRMG5nNmZkaGpMN1pUVDhGL0RrNW55aU5KcDRpZjhvUUxT?=
 =?utf-8?B?QWJSVTIrZDhGVnFhSGU3WUplL1MwbkR6MitHRWRCdmIrNS9UUzdJYUhuMTE3?=
 =?utf-8?B?NUtQL2Y3VGlIWm5BdnFkUW85cE9xZWlRRDRDWjRLOWFVUWplOEV2Vmk1cWkw?=
 =?utf-8?B?Vm1GWUNCQ21HN014NmowM0dNM1FWRXlkdllRVE1ITUdVTnFjUEJlYlVNM2hr?=
 =?utf-8?B?T3A5QUNqN292QnJlcW1DeThaTklhelpPMlluWTR2NXNZa2M2dnFLZEl6V3NN?=
 =?utf-8?B?eHpOVXg1OVpuN3RMd094T2hIdHFUOFJMWUFMaWMrK3dxQkRUSmVUQzAxV0d2?=
 =?utf-8?B?UjQwaENPbzNJdC80Umd3bjhEWjg5b1REZE1sd3RYTlg5VmRRcitqOWwvTW42?=
 =?utf-8?B?ZjY2WWVXWCtxczRpRjdXMVZsaXVZTzJTekI5aTVTbnJkS2RzLzBMZHNPcldE?=
 =?utf-8?B?dGdEVXZnQUZYSVNCYW5QUUxPeEVsWDRwOWQwTTRRcldIN1NzMWJCVko3ZjI3?=
 =?utf-8?B?VWZsdm50SHZJMHdOZWdrRTJHeUNVQVJtTXgwbnNpTndFaHhwTlhsNW1hM2V6?=
 =?utf-8?B?elZmMlIzTlFBbGRzbDdoR0V2VlVVRlIrVHNqby9VRDJXV2hHSU4waTRrckQ5?=
 =?utf-8?B?QkJveWVWWlpsMG5HQjM1SVhWbFdPUk5uVElRTWltQS92WWJueWs3R2hON0lu?=
 =?utf-8?B?NHIvb1l6RXMzK0JQaXRtSTVBQjU2Zk05TzYzbjB2azNQQk9seHEyVXk2MnIz?=
 =?utf-8?B?MVFTdUVhMkdKN2pXVVMrSWEvUXRhNEtRdWg5d0cvY3B0anlSWVFMNnA2bXFX?=
 =?utf-8?B?d3ZJZHlxckt4eUtxTldQN3I0b0dzcW1rZ0RZQ1B3WjIyOFMvOGtTbm9RRDU1?=
 =?utf-8?B?cTNnQ3ZrUkZFemJvY25HYWwyZ2RmRUh1TWhTNkJvcC96SFNtTXhoaSsxWWZM?=
 =?utf-8?B?QTMxWFM0K2d4M0NIR2Q2VmdZMXJNK0V5RHg2Ulg4VUh0WEhOM3lGQ2ovSUtF?=
 =?utf-8?B?dGZjNzM2aGl0dUZuSmRVS2dUdmRMbDU3MkNKSDUvMVJJbnBMSzg5MFhxeHg1?=
 =?utf-8?B?ZGM3RWErV1U0aEkxR290clVCM0lPTjlwZU1FMmY4Ulp1bW9wbmpqTmEydzBH?=
 =?utf-8?B?ZmRSdmNqNU5rSkM4TUpFbmhWZjBUZERJQU50MlhnTS95NHowZDBSTWdING5I?=
 =?utf-8?B?NitNbHJpbnFSV09uZHJvWjA1a1RtV0p3QmVKVWQ4UjBrVmhJcE5NdXMzeGcx?=
 =?utf-8?B?Y3ZZMDNPZ1RaL3Rzb3FaNHRwN3lJWnVKQStZZGVEVmxGZXZ1VGgwM29FU2M2?=
 =?utf-8?Q?vFzvBh0G1iMbNSWGjhk/RN+R5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 810c0547-d941-4874-39b2-08dab01db2fd
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:58:03.1232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZsCNdCDKzRj1sRZ0RjZWCchQRS9bv98XblHF38IQfz2KNxv6r6z1kDx/ZTDmTvfwujBlU9yFVbaRP+n4FDpf6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9227

On 17.10.2022 10:43, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>>> I added the doc asked in your previous email. Also, I will use a
>>>
>>> ASSERT(p2m_teardown(d, false) == 0);
>>>
>>> in p2m_final_teardown() here.
>>
>> Hopefully this was meant only as an abstract plan, not the exact code
>> you mean to add? ASSERT() expressions generally should not have side
>> effects (which includes function calls).
> 
> Yeah, when I wrote the v3 code I noticed that ASSERT might be limited
> to the CONFIG_DEBUG so in the v3 I switched to BUG_ON which IIUC
> can make sure the function call is valid all the time.

But in the past we still recommended against doing so even with BUG_ON().
More recently Andrew (iirc) has voiced an opinion in the opposite
direction, but I'm not aware of us actually having changed direction in
this regard. Apart from that ASSERT() and BUG_ON() aren't meant to be
freely interchanged - the the respective part of ./CODFING_STYLE.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:04:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:04:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424222.671482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okM2Q-0003AI-Fp; Mon, 17 Oct 2022 09:03:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424222.671482; Mon, 17 Oct 2022 09:03:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okM2Q-0003AB-D6; Mon, 17 Oct 2022 09:03:58 +0000
Received: by outflank-mailman (input) for mailman id 424222;
 Mon, 17 Oct 2022 09:03:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a+MA=2S=gmail.com=arthurborsboom@srs-se1.protection.inumbo.net>)
 id 1okM2P-0003A5-Uk
 for xen-devel@lists.xen.org; Mon, 17 Oct 2022 09:03:58 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a136f446-4dfa-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 11:03:57 +0200 (CEST)
Received: by mail-pj1-x1029.google.com with SMTP id
 d7-20020a17090a2a4700b0020d268b1f02so13633105pjg.1
 for <xen-devel@lists.xen.org>; Mon, 17 Oct 2022 02:03:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a136f446-4dfa-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=nzj+jkiTKIXkymGOxQlOiKZpAMfEDnJH3v97ZK7JO2s=;
        b=PJ3Ulk4pXYm9AmwniJN//p76KuxnUvToHEdYLDq6AZA5uF6Yu6zOTN8wbGnfhJjUz5
         rXeFyJJSP50NUl27i6vWeyxGiGjHYJv1AexvsHtfOF7xTE2nymvLBv1GZYK8JBZXqMSv
         Kl21dI6Qci33WNG4lqdq2/7YCEurCLqvaRHb5M0QNO7e3PB6MyRAV/OXTJkOPQaogcHp
         GBER4pmEkvyTvDWmm73/AhqG2NRrC/cMMYuIhBcFycZNEjUzy/0tkJ41TdY3XnKIBoor
         2/Q973GIWIXmI6o20BlQ93Ga75u13kUoZzue6vb5FdFDFi+oI1Cd0FHzwuff5agwSjZ7
         GqLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=nzj+jkiTKIXkymGOxQlOiKZpAMfEDnJH3v97ZK7JO2s=;
        b=qgnIjpJ+e8hdVN6p3WzZ9g3T4O+XwjTLpcPDUiiZFxMYRR8njhwW8gj/8nVjlt2FGv
         W6YdlM9h7jj5cHTLl3nI+YwhM8oUZ0eRCtx22gD38XAN4yZlvhEc80MNVIWwreXlThal
         jEvIypZklgx9yvgF6aJeXKejLzqzi6KybXe1k0O9yOJSGadKkG13nQCxYpNUiBMdt5x5
         cNLWXLE4o61Jit2DtZ0cft6BfHD3ObQRfvYAVdk4zC2Q8VdWzVoNDdCELs3L/pRDoD67
         YRNAeA82KTeEkz5QTwkzMpzCVPkR680SRAz0TPq389WVmed9r4+mC6AEUxHz7oC9672W
         ynmw==
X-Gm-Message-State: ACrzQf0kh3n5lUvibAxn0hbSODr4s1VCtRq7Ij4iO8E0dazzeksYoB24
	N8fPsExcnW+lKiAn6H2rra7xaSEclA08ZYZFNfM=
X-Google-Smtp-Source: AMsMyM64TM9ip8DJPS1IIfAf8ByjkhssmLsjTNIHSSS5ZUckOURygqgl1f2XxOoHz1v6loeWufop87bNIsO6F/Ai7t8=
X-Received: by 2002:a17:902:ef96:b0:17e:e7f3:31db with SMTP id
 iz22-20020a170902ef9600b0017ee7f331dbmr10916218plb.127.1665997435356; Mon, 17
 Oct 2022 02:03:55 -0700 (PDT)
MIME-Version: 1.0
References: <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
 <e25a9c12-92f3-936b-82fd-cf7319592a6e@citrix.com>
In-Reply-To: <e25a9c12-92f3-936b-82fd-cf7319592a6e@citrix.com>
From: Arthur Borsboom <arthurborsboom@gmail.com>
Date: Mon, 17 Oct 2022 11:03:39 +0200
Message-ID: <CALUcmUnMX1gmaiw72Z9z3WNsQoB85-uhe03YUjTibZCOPQcZPA@mail.gmail.com>
Subject: Re: [BUG] Xen build error - undefined reference to bpf_program__set_socket_filter
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Content-Type: multipart/alternative; boundary="00000000000054cbae05eb37412e"

--00000000000054cbae05eb37412e
Content-Type: text/plain; charset="UTF-8"

>
> So while this is a build of Xen, it's actually qemu which is failing.
>
> This can be fixed by changing the version of qemu, or dropping qemu
> entirely by using ./configure --with-system-qemu= to point at the main
> distro qemu package (so long as it is built with Xen support).
>

Thanks for the quick responses.
I will share this info with the Arch Linux package maintainer.

https://aur.archlinux.org/packages/xen

--00000000000054cbae05eb37412e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">So while this is a build of Xen, it&#39;s actually qemu =
which is failing.<br>
<br>
This can be fixed by changing the version of qemu, or dropping qemu<br>
entirely by using ./configure --with-system-qemu=3D to point at the main<br=
>
distro qemu package (so long as it is built with Xen support).<br></blockqu=
ote><div><br></div><div>Thanks for the quick responses.</div><div>I will sh=
are this info with the Arch Linux package maintainer.</div><div><br></div><=
div><a href=3D"https://aur.archlinux.org/packages/xen">https://aur.archlinu=
x.org/packages/xen</a>=C2=A0</div></div></div>

--00000000000054cbae05eb37412e--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:16:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:16:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424228.671494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMEj-0004gt-Ir; Mon, 17 Oct 2022 09:16:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424228.671494; Mon, 17 Oct 2022 09:16:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMEj-0004gm-FR; Mon, 17 Oct 2022 09:16:41 +0000
Received: by outflank-mailman (input) for mailman id 424228;
 Mon, 17 Oct 2022 09:16:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Rj3b=2S=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1okMEi-0004gg-Oj
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:16:40 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2068.outbound.protection.outlook.com [40.107.95.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6731b0f7-4dfc-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:16:38 +0200 (CEST)
Received: from MW4PR04CA0169.namprd04.prod.outlook.com (2603:10b6:303:85::24)
 by IA0PR12MB7553.namprd12.prod.outlook.com (2603:10b6:208:43f::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 09:16:34 +0000
Received: from CO1NAM11FT093.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:85:cafe::70) by MW4PR04CA0169.outlook.office365.com
 (2603:10b6:303:85::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Mon, 17 Oct 2022 09:16:34 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT093.mail.protection.outlook.com (10.13.175.59) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 09:16:33 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct
 2022 04:16:31 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct
 2022 04:16:30 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 17 Oct 2022 04:16:28 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6731b0f7-4dfc-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=og48GawsKTm/RFj4IiO94dHPxogyA7UYoBuYwZmEDGDAvpzhoWk6gbc006QWDH9KtYr8q7QLVrOHGlYa87r6hRAfs4NQWOe1lg3J73todZUDvf6rZQ4PYTtEoIiiE7grNCdl0cKHN5y37WEaz1ZmAIctnuy1Mym7gkwdK0c/XiSEV9dYzr94mPJ4cQG3V2HOBpRyufJcKuPku9WKS2DOubUOquid2t3IeRgnlXNdv4mKON3+YVOqiUdpIas1ryF3FfFf3AWeeEZ9Orz88v68mrWwm4vMlPtTcdvTOLc3CGtmvSJ9viJP6roFmVubT9cOMlxUIOJn/Pz0JzQ5hCoHYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D6mYxFMc5KCEh5tkDNBekcfoPxP5pY6m79Nwlt66Pqs=;
 b=U+dvpD4/OTcFxjc3xBm9NbD4eEFHe7xp7Z/f5qK2Q6hJa5893bLCeCKCEmMgej9EsNW8+eCxjyAlTCuZ435jJoERcVfgrrxIm9J7yfbUddvcHDaEzNb93u6DgWsV7ZYOIG7wOPZ1tmQxDe6j9ICdBMGTYe3J7ufJdF+72F8kH6nK3OqTZvIUb2zmelMrdwMx6nY/a+v9JtanjcAvocIm470DqyLbW9Qhw4ab6b6zwnYnJWbAUnVQqxQZRaRALf7ILkvJ9XdCNdufFx8qQDTnr2b2AdszKJTR3ifsz6R5D+4l/YMEmt0sQNsEOuBV2EdnTzRogVEjvhXRMLkHhG2tUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D6mYxFMc5KCEh5tkDNBekcfoPxP5pY6m79Nwlt66Pqs=;
 b=M7v3xmSxzAuzja5GXm5TuxoZpQanF7EMq+5Hn4KeEuEhd7kmZwq42ucRalVuw42FId0dIDFWllZkCRIzIdRvFP95SZRBiOltOZnkhfEWDEB4A/2uMZy4rjk4I6X9O5daYXJl5HBpkoqf0zAbjEhq3XyDOQLtrsn1zIQTsyu4q9g=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <cf57a263-c0a5-2fe3-e12b-84d86d8e65b9@amd.com>
Date: Mon, 17 Oct 2022 11:16:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 06/12] xen/common: add cache coloring allocator for
 domains
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Carlo Nonato
	<carlo.nonato@minervasys.tech>, <xen-devel@lists.xenproject.org>
CC: <andrew.cooper3@citrix.com>, <george.dunlap@citrix.com>,
	<jbeulich@suse.com>, <stefano.stabellini@amd.com>, <wl@xen.org>,
	<marco.solieri@unimore.it>, <andrea.bastoni@minervasys.tech>,
	<lucmiccio@gmail.com>, Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-7-carlo.nonato@minervasys.tech>
 <ff6a5e85-0867-2e22-e173-15805bfc7843@amd.com>
 <b61624ad-f631-b09a-0e3e-598b8982a0ee@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <b61624ad-f631-b09a-0e3e-598b8982a0ee@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT093:EE_|IA0PR12MB7553:EE_
X-MS-Office365-Filtering-Correlation-Id: 593084aa-ba0b-42dd-e13d-08dab0204945
X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4/i6+Pap1mKYxILPKdA0zXqfnTM+XiMFe8uGhWkxfqSnxiyMoYV9bOC35UtPSM+0/v4U8m9rtVa2snzo2gDEsQQq9R1f7o2OOdfxsG32P33hqYLhNDV15UNUD1IeHTIpCz1i3lVV56ZyGr/8w3CEQSfsKFlQvPrEMVTZQ4/jWUrxOfRruD+wqk41IFQ61Cx+9sh9oJv/Klnjdnaac4poNoxf0CGulCyDTMBaObNYd0Vh8RjFdSKyY4Qe99bxTk+jFLMh++rDkAYlKrSWnGsSrkalwtln+oJdqeL037yQu4b5TxceGhMpH/1gVeboB6IhuNghKIshy6eeDznHLopWtQUOrfUF47X+9K944101P/NHDrpgdceMo4kyoliWANxilKLwjHY9hpJHTp/t1tpcjRZLEpcu60swoL66eYbp8MlSUV0gXEHT6/7kSHDmIc3U2mJfCszk3483PoTyH0e6aefSSiHIDhKg07yy2n9TpZ+dXXCCVofexJNgxJtwaiib7PMxN9XuS/08EPD9KcdqPTgXbO4FI+/pWZh4r6B5G7OqhRTiSmIGAaV94/b5pJCAEu2ySVj7BuvpxM6KmqSmkAeMtX5B7g9JQh9G4ZM2nVMvl+ajxCUaBWNoM2mAwlRt4bJ5YHylbrMzzggpywe0CBk9mzy0vCOYzZpEhD5MqKGtzrfzhUx1eoGo8xz2V5vsWL0i4IG5W0J7MQl7/zlQGXj3MK2j9LtcwD3m+WC76JOIwODAQLxb+jGsRbnddHMCHton/uQnPrMHewZ0c1J8jIcHVu5EEAwxgbifMIvyxWHTCoODSd9WFLZY3Mv2lNATwYGlLFgXdzka6FgcwvWoYA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(86362001)(336012)(186003)(2616005)(426003)(47076005)(356005)(81166007)(31696002)(36860700001)(82740400003)(44832011)(2906002)(41300700001)(5660300002)(7416002)(8936002)(82310400005)(40480700001)(40460700003)(478600001)(26005)(53546011)(4326008)(8676002)(70586007)(70206006)(16576012)(316002)(110136005)(54906003)(36756003)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:16:33.9386
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 593084aa-ba0b-42dd-e13d-08dab0204945
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT093.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7553

Hi Julien,

On 17/10/2022 10:44, Julien Grall wrote:
> 
> 
> Hi,
> 
> On 17/10/2022 08:06, Michal Orzel wrote:
>> On 26/08/2022 14:51, Carlo Nonato wrote:
>> Apart from that, the memory coming from the buddy is of any color. Shouldn't it be that the memory
>> allocated for domains comes from colored memory of the colors assigned to them and anything else
>> should come from colors given to Xen? At the moment, the memory for e.g. allocating P2M tables comes
>> from the buddy which means it can be of any color and might cause some cache interference.
> 
> Somewhat related. IIUC what you are saying, the P2M pool will still be
> allocated from the buddy. I would expect we want to instead allocate the
> P2M pool from the same color as the domain to prevent interference when
> the TLBs are loaded. Or is the interference negligible?
> 
Good point and I agree. I do not think it is negligible.
All in all, allocating this memory from buddy which is of any color is incorrect.
When cache coloring is enabled, it should not be possible to allocate memory of any color.
If we can do this so that this memory comes from either Xen or domain colors, the
intereference will be reduced. When it comes to P2M tables, if the memory comes from
the colors assigned to a domain, there will be even less interference.


> Cheers,
> 
> --
> Julien Grall
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:17:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:17:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424233.671505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMFx-0005Gv-TW; Mon, 17 Oct 2022 09:17:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424233.671505; Mon, 17 Oct 2022 09:17:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMFx-0005Go-PR; Mon, 17 Oct 2022 09:17:57 +0000
Received: by outflank-mailman (input) for mailman id 424233;
 Mon, 17 Oct 2022 09:17:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CpyK=2S=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okMFw-0005GW-8n
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:17:56 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2045.outbound.protection.outlook.com [40.107.22.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94e25754-4dfc-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:17:54 +0200 (CEST)
Received: from AS9PR04CA0119.eurprd04.prod.outlook.com (2603:10a6:20b:531::15)
 by AS2PR08MB8718.eurprd08.prod.outlook.com (2603:10a6:20b:55e::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 09:17:52 +0000
Received: from AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:531:cafe::bf) by AS9PR04CA0119.outlook.office365.com
 (2603:10a6:20b:531::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Mon, 17 Oct 2022 09:17:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT042.mail.protection.outlook.com (100.127.140.209) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 17 Oct 2022 09:17:51 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Mon, 17 Oct 2022 09:17:51 +0000
Received: from 4cf0a4961ca5.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1C5F861D-F8F6-4FF8-B897-E10E63C27766.1; 
 Mon, 17 Oct 2022 09:17:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4cf0a4961ca5.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 09:17:45 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by VI1PR08MB5520.eurprd08.prod.outlook.com (2603:10a6:803:135::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 17 Oct
 2022 09:17:43 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 09:17:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94e25754-4dfc-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=N2XPB9x+ClvVxti1EbiC/YUciq6DIf1vbIg9vp7zFeZvaW0uMJdJ5Tgwx2SlFj2kami0sKbSAUOa4V9hn2y3PAjxQJioKoEWyEgvkM+Sv8goTPowew5ZC04rDCf81EvPh2BabeuAm1pSDoQ/T3d58UjCht0b1RAmSdTlov1qts8w/Tddf4C8dLjDfGBjs3heb/BWI7qTRBs/vYGoOs5ddi0inoR3yClwsY2epxfnu5B2vuhlQpbKKrkH74gxFCCHuQejdf3CicnuwA0tCIfhxmPfgmlLn+sZN8UMuhmCPUzdfz909oRCy/9E2K0s1pI4hwaSg6RRI5GMQApG+ZUxfg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Rqj6bNA0Hyqnzx2dS4iINL/TzqaVpGrU1oBbeVg54g=;
 b=YMPCwFevDAk6XNQcWjUyqe0pdUbX2b5OlxKEssKhgPU7W6SDTp5oMKGufzr93eYWcemtVuMLyjhK5FvEhxSvhIB56hu3xJqIkHdC5oK3n7sjvW6OA+4pP/4zZEU6e+RgXDLdlYBYMWZyHD9jy7IjsuE9daVQ/lFo65ekMzsas8LERNOW7F/QzNi4HMt54Bk5nfybVePQcC0o8f/5hpkTQ3If+BUX3wPziWezr/rmoeFMI5jxiUPJSr7DRrLcPLy/sWNUtxvs8yeD4bOhCXQO04C8DY0ek6geG78NwWj2i5vKLUT/6ve0zG8cMti3xpU33TIs5V/jFXKolohoVNh+lA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Rqj6bNA0Hyqnzx2dS4iINL/TzqaVpGrU1oBbeVg54g=;
 b=OdQx0ThPSHlyn2yLvV0Mfbi+A5Xpgjmbio5xCwg9jO6aYsWMnxqkoD+Q5QfqnYiMu36OGR6AonZpHAhoEgoLPGLDcwYC13uUScrz7hlNFWylLT93/HONmnf9wziW74vAsTfyTTeCeYs12oHyvgxMHTLh+TcjoDah8ii+a3+ppi8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1585a0b62c31aed7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MZefKxlikl8kO00MI3PpJb2l0JebFbvVB4G5johF2WiIfyU9+UqV2fQDSqn96oAM1DbI4BB9eA1TKDI7yGG6+fnPJ7ct1hYc8Gpl+SvyWfueRRqYfvcK/MktHIAPP6dDZXR8xUKthsYA8w8PjgxUk+mWXzlxmSyV5RLp3oi1DcK0poWwqC/XDF/Iwwc1SE2vYUilKEZSiwL2+7GDndBsOCdlxT3fU4USH//QHxEMJZ/Orc1ISpnlmlDgGz3bJO3InS9HofJwyExCjpQDX6Cnob8mQ/qbvRZxwxw/nXEQ1SEF4UMcbQGWRXEa8ahxu0GfYpqf+KiZsmT/8pwY7CcAxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Rqj6bNA0Hyqnzx2dS4iINL/TzqaVpGrU1oBbeVg54g=;
 b=Ac0phueeVwIoLs9wYTQbHkvT2/VFIsWPy5a0ML/2WXamyyHy5EbvYWv0ZqhnftXv/u/Mt7wWbHWqIxjHDUyAttk7G8gqrTAUIb/vqRSy6EGbLrusiUbXEIcHvD4T6YpTGUWVrRYngPqpAYvtpwzLtAgBpQGTGqbXoaSx2SQzxBq/thL59g7MeZuF0AItUXRdek86SK36Tae+/jfVkF4CpM6saFImvsQEQI7dHEZbGLjMU9z+JcCW1MO8qkqcKGawZAxZm95Yu9s8+8MmN0IHA/W++DgRfrEGIXFWPJLd56cOtoJzxD0UAwDbj8L8+vQIdQieilcalUHDiNdPbQr7EQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Rqj6bNA0Hyqnzx2dS4iINL/TzqaVpGrU1oBbeVg54g=;
 b=OdQx0ThPSHlyn2yLvV0Mfbi+A5Xpgjmbio5xCwg9jO6aYsWMnxqkoD+Q5QfqnYiMu36OGR6AonZpHAhoEgoLPGLDcwYC13uUScrz7hlNFWylLT93/HONmnf9wziW74vAsTfyTTeCeYs12oHyvgxMHTLh+TcjoDah8ii+a3+ppi8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Ayan Kumar Halder
	<ayankuma@amd.com>, "Stabellini, Stefano" <stefano.stabellini@amd.com>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, Henry Wang
	<Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Jaxson Han
	<Jaxson.Han@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Topic: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Index: AQHY3vmtdKYr9F2nyUuznJvSQYcvHq4OMlaAgAEAmYCAAyG8AA==
Date: Mon, 17 Oct 2022 09:17:42 +0000
Message-ID: <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
 <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
In-Reply-To: <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|VI1PR08MB5520:EE_|AM7EUR03FT042:EE_|AS2PR08MB8718:EE_
X-MS-Office365-Filtering-Correlation-Id: 57f1ac74-d9fd-4ae5-bfc7-08dab02077ba
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 pGRaWcTNRZYpg30ll92EZDYjoElP9uOR6qL8wTvT7Nk69QfmJ9MJoCwV2/ZFJZ2Eg4fBLnA0zsAOSPtuyCVl+ijw2bKn3B0LPLiOfxdpnxa0XRw5fybo70xG6p9oc5QUjBefmC4Iw1hKJlAUxLVe3kaDuy3O3EwvYCgHcvpGQuqFcaRv4uWz1MeylLypFa6ZjAcmP4cUiCjf2Nq5ncB22LWzA0SapVzCGIJaiTQo1i3yIhF/r1ZH8pT8yFvjMj5rud+ibmWzQ7y/GCAyOkuB5XkEsVFriptg9izvKQfHCeZrJVOcBjBHzTYVbngQFom0fK2hQnLsPDOybf4UjFQgyeHvicKLCYVxNGXPHGpVjkm76ZYDAx99IxFHw7KTM0k3Z4FHnIn5mkZrU3OP7IO8J07zf2U78P8z1C5tnil2bxQ18b2qdvdOak5oOeaCnpVbS+A9TMxy6n1yXvtskN3VDfYS9ZSYYSwRBETyK3egFCBmwfP8Xug3pYr4ciFEftpj0p3KoPgTC/wlJXYnSEu0BXvKSCzBhHCC8ChctqKrqY3eVcUTfXAdPOGoDhh3Y9XbUw6wT4D351H1axt4YdXzCRx3/KfPm5J0mP7YShezd2CkRGtK7H8y3LOfKsMrq9/TSFVGoKxeNlzLE9fFFhvTobGDlXasr9M4r1cLc1D9saeVEJHoxmTE43w8jU4c57QuYN8mH2tRxW+Pplm3QUY29SxmgJTgsgBRNpKFPG4HcQvioJJq6CNHOiA9LbZ5764u+LdrM9oeOy4sfNcZZUIh6YmYGsx9w5N9yuk/OfA9XoQeehlZghW95OQyjk2ytU6/y85j7UoYM+pHiaVYI0ka/A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199015)(966005)(6486002)(478600001)(66899015)(54906003)(86362001)(316002)(71200400001)(6916009)(4326008)(76116006)(66556008)(66946007)(38070700005)(66476007)(91956017)(66446008)(64756008)(8676002)(6506007)(41300700001)(53546011)(33656002)(122000001)(26005)(6512007)(8936002)(36756003)(186003)(2906002)(2616005)(83380400001)(5660300002)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1FDB516BDB264640A9654F86B1032DDB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5520
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	52c36070-edd0-44fa-afc9-08dab0207255
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nPoDnuBKKDvCgFmHIzgGOVYvLe1w8huQzP/iMUEwzBryBpSFm+cVKPv9PJTxNU3u68iIaTdxxTmoneq66jptKdnm9Vl14+wIqbsyBtbhEcg+xW3mHKOyrwy3ddLyIXQ7nOCwsNhOiXaoVy04lO/zxANiDbw4GaFCdrHaLmYBKUjeeoIxj6z/t0LYauxp4fpAtKIw+j0ckbcWTzCQsYanlhcJGHsinDTe/SkXGW457tf7n4RagjxjBCO3+GuBFgRQQQVERdnKk6/DcFkQEoKi4JtSihkxg46lZTwZje/46EjgzR3meunAC0VhmJG6NKJICS4RfhyN8wIrTiLkhzF0WU6E/u3QdYaQAHU60jB5oeYfSS3ei+VWO/Av/4nx5k4KO2B3mt18zNa6HP1kC1KTttfq92KdmCysd8Ms9+UgGsr6M09QQ3OLet/vqLkELfoG5JsEU3KPyO6jJfOGhHJBvt3su6dRhTFiBpuDDVD1jIUc9GK3GxvyRoCI1CqphIR8HMJQPepvGKHMGmp6O70IGJWuM068kA+L8ohzQiDjSHJqzRAHCwFGHMn2dZ/ucp5JNboF6O/MtngZhgtPcXhD2AXbRL5A27owOWKvbEolgVlT0rHLyXJx1JDGrLsGnDleYsb4PtGgxyvKa7a99yNEbOLROlTdQ8Ow6wX7v8nyoe0PIqI0Dlc2ThMM/BDCB75p7cLmNU0Y4Zlx85wjJ+9HGYBr8QnZqoRPgeqELuaIgLqRJqn8jInBxA4Y0AVGby5vRUgXhGiPzkWYLmzrf/uLxvxGp0c9O14lzB7gFQRaT7o=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(336012)(47076005)(2616005)(186003)(83380400001)(356005)(81166007)(86362001)(36860700001)(82740400003)(5660300002)(2906002)(41300700001)(8936002)(4326008)(6862004)(82310400005)(40480700001)(8676002)(40460700003)(478600001)(6512007)(26005)(53546011)(6506007)(966005)(316002)(70586007)(70206006)(54906003)(6486002)(66899015)(36756003)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:17:51.9734
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 57f1ac74-d9fd-4ae5-bfc7-08dab02077ba
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8718

Hi,

> On 15 Oct 2022, at 10:28, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Stefano,
>=20
> On 14/10/2022 19:09, Stefano Stabellini wrote:
>> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
>>> Hi Arm mantainers/Folks,
>>>=20
>>> Please refer to the discussion
>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>=20
>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed vir=
tual
>>> platform.
>>>=20
>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using ld=
rd
>>> instruction.
>>>=20
>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
=3D
>>> 0x9200000c.
>>>=20
>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>=20
>>> The proposed solution is to use two sys_read32() on GICR_TYPER to retur=
n the
>>> lower and upper 32 bits.
>>>=20
>>> With this, HSR =3D 0x9383 000c, ISV=3D1 so ISS is valid.
>> Hi all,
>> I wanted to take a step back on this issue before we jump into the
>> details.
>> Differently from other instructions we discussed in the past, strd and l=
drd
>> are not deprecated and are not "unusual corner cases". There is no
>> statements such as "please don't use this" on the ARM ARM. If I were to
>> write an register read/write function in assembly for an RTOS, it would
>> be reasonable to use them.
>=20
> Just to be clear it is fine to use the ldrd/strd for accessing non MMIO a=
rea. The problem comes with MMIO access because they can be emulated by the=
 hypervisor and we don't have the syndrome. At the moment, this is only a p=
roblem when accessing some of the GICv3 (including ITS) registers.
>=20
>> So, I struggle to see how we'll be able to deal with all the possible
>> RTOSes out there that might have them in the code. We can fix Zephyr,
>> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
>> etc.)?
>=20
> This is not an Xen issue but architecture issue. The RTOSes will face the=
 exact same issue on any hypervisors unless they decided to decode the inst=
ruction.
>=20
> As we discussed before decoding an instruction correctly is quite difficu=
lt to do (what we have in Xen for pos-increment store/load is just a band-a=
id). So I would expect the other hypervisors to have made the decision to n=
ot implement it. AFAIK KVM doesn't suppor them,
> Note that looking at ID_ISAR2, it seems that ldrd/strd is technically opt=
ional. Therefore, the RTOS would have to assume it is targeting a processor=
 that supports them.
>=20
>> Unless we can get ARM to issue a clear guidance that strd and ldrd are
>> deprecated,=20
>=20
> Arm Arm cannot say that because ldrd/strd are necessary to modify the LPA=
E page-tables atomically. What we need to know is which instructions can be=
 allowed on MMIO accesses.

Definitely this is something that arm arm cannot fully answer as it is also=
 down to the full platform. MMIO accesses are going out of the CPU and henc=
e wether or not 64bit MMIO accesses can be properly done might also depend =
on the bus or the IP on the other side (some peripherals might just refuse =
64bit accesses or some bus might only be 32bit so the operations would need=
 to be divided).

>=20
> I think I already raised that when Ayan added decoding for post-increment=
 instructions. There are plenty of instructions (or combinations) that does=
n't provide a syndrome and yet the processor doesn't prevent anyone to use =
them on MMIO.
>=20
> I was worry we are going to have to continue to decode instructions in a =
non-compliant way in Xen just to please a few RTOs that may not even run an=
ywhere else.
>=20
> This would also reduce our leverage to request a change in the RTOes or t=
he Arm Arm (maybe there is already a statement I haven't spotted) because X=
en will already (badly) support the instruction.

Going back on the ID_ISAR2, if Xen is properly setting the value seen by th=
e guests, there is not reason for us to actually emulate those instructions=
.
The emulation code inside Xen cost a lot in matter of lines of code and wou=
ld need a lot of testing (which is missing at the moment).
So as we have a standard way to inform the guest that this is not supported=
, we should stick to that.

>=20
>> I think it would be better to attempt to decode them rather
>> than just fail. I don't like to have this kind of code in Xen, but I
>> don't see a way to support R52s without it.
> That's not specific to R52. This is anyone using GICv3 on Arm32 core.

Agree.

>=20
>> That said, of course if Zephyr was to use two 32-bit reads instead of
>> one 64-bit read, it would be better for Xen. And we have more important
>> things to deal with right now in terms of R52 support (it is not even
>> upstream yet). So it is totally fine to change Zephyr and move forward
>> for now.
>> But medium term it doesn't seem to me that we can get away without a
>> solution in Xen for this (or a change in the ARM ARM).
>=20
> See above. This is an architecture problem and we should discuss with Arm=
 first before continuing to add more decoding in Xen.

I will discuss it internally to have an answer but I think that the answer =
cannot only come from Arm as there are for sure hardware implementations th=
at cannot support this, as explain before.

Cheers
Bertrand

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:21:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:21:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424242.671518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMJR-0006m8-Ga; Mon, 17 Oct 2022 09:21:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424242.671518; Mon, 17 Oct 2022 09:21:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMJR-0006m1-Dv; Mon, 17 Oct 2022 09:21:33 +0000
Received: by outflank-mailman (input) for mailman id 424242;
 Mon, 17 Oct 2022 09:21:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CpyK=2S=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okMJP-0006lv-Dl
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:21:31 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80083.outbound.protection.outlook.com [40.107.8.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 157cfc30-4dfd-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:21:30 +0200 (CEST)
Received: from DU2PR04CA0087.eurprd04.prod.outlook.com (2603:10a6:10:232::32)
 by VI1PR08MB5374.eurprd08.prod.outlook.com (2603:10a6:803:12f::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 09:21:28 +0000
Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:232:cafe::86) by DU2PR04CA0087.outlook.office365.com
 (2603:10a6:10:232::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Mon, 17 Oct 2022 09:21:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 09:21:28 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Mon, 17 Oct 2022 09:21:28 +0000
Received: from a04aa8ddf531.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0CE9B491-1720-4928-855E-40E45C269205.1; 
 Mon, 17 Oct 2022 09:21:21 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a04aa8ddf531.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 09:21:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM0PR08MB5379.eurprd08.prod.outlook.com (2603:10a6:208:182::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 09:21:20 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 09:21:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 157cfc30-4dfd-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Zbzp3Hfs6Ob2IGa5htWrDOzeOYWkJtDZlPcDBUPcfCr6jkVtFfYHv8lL500mc8qmfABQf8/f8UWtb23T3K6YrAJI6DyeYzzedn5nau8nPkfdwq19u1lZvNAUdnxrdwg43MXI5Yzk/FUMVEs9edVAv2Mu5dZyXxCCTXlC3dAoLgSSrMKV+CRWAimyg6YXcwbTDCYIZYbsiyg02UClTPoXG9ejJBFJRzE4yP4mqjOq8HL/NywXIerI4TWgQw92b4KZtyxPyWMmq1qxyhbIP4toZOqBVF0XB3tRUp3ugTeydBpbEHdl8/t2AwlwP9vmbuJ18zqlDUhpjGeijYOzebqlbg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BJRFfvC9WKJ61OarQi9PJR/eubBtRm/bRs9ihoNyWl0=;
 b=LadueYw4PbVhs/zQyZ6MuzPCz310zgKXErfNGPQIU9C4GIWADNyMVe3PvZ1JFHAHDkobAfDnpvU2GyWthD6a4xg6nPuUV/gd1qKaRo7AM9NLpYAXEoogBUhxKqgDGNGtLZREkbZkjKP9k2mI2CuOR/h90xmjX/9uXtLJTzRIJ7LvapulSwHHGlc4/Fta1TIfFVU8S4IzCSWkeWc1uIIa+qSuqezG7AleXAXTg+un2pIr0hlnmxSLq9CPSsVcxLgM4FpHgLsgbrrPcKDIuMpXod4gOAVKNUtI7oJxCqfwSzvUFqQhLQP2D6dUPvyzEDGn1JNg05UjK0uSiiu6+q1bsw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BJRFfvC9WKJ61OarQi9PJR/eubBtRm/bRs9ihoNyWl0=;
 b=6mK21ldBUi/sXfRzxCruVgxV4UzxcYdINfZAgLpWcmbOnTmQtOGQ4GGGt5POPhzzff7j60WUz/hq4t/pdZSF6rc+rikGkcUPUj91XyhnSS/Vf+iJpvF8ON2DEB0HDkM2kTAOc0phzS5oo7aqRNx5O0itl6YYv0EhFkAcOrPIya0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5a9d3e1fc4a09ef6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aVRZ8SRCK/UH7JBSmR+qmDv8syWuqYRJKk5b8++sM9D/tUB+nI8CN8umm7dAL33vJFI25q5owtAYrxwQh02tgCRfQnfcKCESFcdgxcScnmZYbrapuWg/ZUeHZBJzB0s6huh+2kZRzYCK75gETwdThxECOqMQzs7GPb0h15oOfH3PSWTrO3dqMBuLfZm7eCbI+68igxluK3wem+UxzupHoLtiop6bjiy4Pa/aKwiKW15lT9B5gBZUN5TUsDjie0AvKL8vdgrEts2KwP1Uh6qSYMgGG2agxuTXAydXFUTvIefk6Ryofow70JGAlHakNg7BCpV9qW1eGtEn7Fonhs+9Qg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BJRFfvC9WKJ61OarQi9PJR/eubBtRm/bRs9ihoNyWl0=;
 b=R7SVsa+FzigXuzmWar0tqzCK3mSFrFNe9UnbaCokG6QXN1OSMaa+P5R9FUU2DtfSJTE7y0m4oZihvrU/rnEPr10IUUwH2TnWCf0d97zRgbSBOH/Cl67+OMvjwRxMPyuZ3G3w5Rg3oYoBB/G3hBxOshM965rNtTg2kzItJl8O6bXp6igMXwAzbBJP53CO9YOsTvu+rEOPq0P4fzA3l1C3UsXV0nYu2rTLqLqXZxs68q4icMTJo/3qdZK31qqANuhy87yNeqQtRowdJ6g+7E5z+4COfW4k02EjAOeWEl0w4zATqKbuMvoCKSTHVri0BwXCJkq9QgOj2EM9tbEiwbTTzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BJRFfvC9WKJ61OarQi9PJR/eubBtRm/bRs9ihoNyWl0=;
 b=6mK21ldBUi/sXfRzxCruVgxV4UzxcYdINfZAgLpWcmbOnTmQtOGQ4GGGt5POPhzzff7j60WUz/hq4t/pdZSF6rc+rikGkcUPUj91XyhnSS/Vf+iJpvF8ON2DEB0HDkM2kTAOc0phzS5oo7aqRNx5O0itl6YYv0EhFkAcOrPIya0=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
Thread-Topic: [PATCH v2 0/3] Yocto Gitlab CI
Thread-Index: AQHY3hEMDLhOM5SRDUy6m8XkPQoc/64OWrqAgAP8xgA=
Date: Mon, 17 Oct 2022 09:21:20 +0000
Message-ID: <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AM0PR08MB5379:EE_|DBAEUR03FT060:EE_|VI1PR08MB5374:EE_
X-MS-Office365-Filtering-Correlation-Id: a69d175b-657f-4e1b-6d20-08dab020f891
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CS8HQLhhc6e59ZZxKh8CoRfMHX7a2N7XwgxT++tSWxVCvGM6P+IK52aaT49gJcl25Po9Ip7/YDv3hVHeoaw5olfPH7EKIY0C3TxzrNQbdRdyIbafqJTL7bk3l2CYoYUmLP/wSRKdRs3otO1YYG2DivAgMOcpgxG+trvDIQulKff/TmP/kdYJRScLCn7ZIcp1KiUElwJSOrlECxDCcJyy7s3tp10fPXO76b7reRCGY6Sax60xUTrMzv3ar0a4e/oXBVycZOJZzvfgmp00b0JIA99MsIxxqCs997h5VsY9d0dd2eZR0ksawvHLQFcPy4hEzelGy9UTAB99jeY3Mv7Kqce06RsX1qFnhmOMBpnvz7L/NKQdJQAH76WZRGM/UfWaiWKQ0pArb6IphBhX6yf/D8cFUKYw3rQNGHD7UO7eHpcKY8TZ0bcqwchxosbDCUm69KP+vE0I6bUe0p5WawQOmL+LY3N4YMR79eJoWD5rtfa81gTKP1EMczHnDlZGSFWmdx5XhuxFNGS69IyIFZAT1EbPPPWr7Bl42yApPvtZRrCS0BYmSfUPmzs/WcFzxB6JEehgM8r1mlj5BVgG2QTAymFPPkAK8xOuG3JDP558DlOz2Br33w9i5BO+8ZuVl+lIbzJNjlbsIF8yXHP6Z+4KzCUBM/YoPC3AcoB+beOgziNqJdKOx3EaRGYA5UAOOzNsBO5XlcSJ5F6yfOhSZUbMDzCas2KtISV31uN/WCjNZ8BDys7Naf0VVbTxW6SP85HKKVkiNxC3jWfqCub7rXFUMY5eR/fTbIVj8X+71iSJP2Q=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(2616005)(186003)(38070700005)(86362001)(122000001)(5660300002)(38100700002)(2906002)(41300700001)(8936002)(4326008)(8676002)(64756008)(26005)(478600001)(6512007)(6506007)(53546011)(316002)(91956017)(66446008)(66476007)(66556008)(66946007)(76116006)(6486002)(6916009)(54906003)(71200400001)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8C1F4522F23201479A95B537A44D3169@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5379
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	549e736e-9880-4eae-e51a-08dab020f41b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f3Dw2lins8qIjXFlteHMsXMbyr3VJzfezwvI/e7/Jp+n0Gn8lpl1z25GKc22ds+6auRyOCLlJzcjCgCyPHBUFPPpWw6OtWc69zRBgBASDMV0F+ksMra5onf3e8u+pP2SYK6/hkAK32KeT1aabstNwAdoIcLawBfH957bov8RZaeuWFB9JABa82ncetl30oV0bU6QbOxCMUAaIrwLQM/HxoiweC1SSDVN3HGFVKZBo864CuBhMunRRRj5dyjAlNGy/1JsJPyge+qv88cdXyEhfHsh8US2vwhvJSCfmevTYoUWzBudoNMPl/otAvX0ryc9b4OTF56gvMpN26KiINv2uUORNzLdSxpjtcOQO2A9mi09rE01wk5CIEOX51eHOkpYbMZ7Bm5AEzVQp81RTEUjwqdHVZywnSKLjbLHqKiWmTGVPey9FAltH58ErB9w5jirOQiQOd5RX4V6ZEbJGEJHb69EiR1bDfNGzbevT5/b47uCp0e1S6gcYxrokWTqSyyTJu/Zf94OP7zykn1xZ8rQGnwlD19KbmzFqm+1SWHpv42QwZIIlKXbUWmisIil/uCuHY58odRNbRFmL0XlNBMx/TqP0mOXIVRD5Bgvcdavy/G/6cd/RRjbeREfHXrdjMIBfAGdSEIRHG5+Kny+GNp11DsZKiMlaM6dzXhVpqvru4PXV4PHmshv3UPpccnf8TxLgcvmb+LavPsK7vRXCO43yICT6GaHwcWlGDWUIw3sM9W34CVjAIZhxH7V7SYlSf6L
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(46966006)(36840700001)(478600001)(54906003)(6486002)(6512007)(26005)(8676002)(4326008)(107886003)(70206006)(70586007)(41300700001)(53546011)(6862004)(8936002)(2616005)(5660300002)(6506007)(82740400003)(82310400005)(316002)(47076005)(186003)(2906002)(336012)(36756003)(356005)(40480700001)(81166007)(33656002)(86362001)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:21:28.2068
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a69d175b-657f-4e1b-6d20-08dab020f891
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5374

Hi Stefano,

> On 14 Oct 2022, at 21:27, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Wed, 12 Oct 2022, Bertrand Marquis wrote:
>> This patch series is a first attempt to check if we could use Yocto in
>> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
>>=20
>> The first patch is creating a container with all elements required to
>> build Yocto, a checkout of the yocto layers required and an helper
>> script to build and run xen on qemu with yocto.
>>=20
>> The second patch is creating containers with a first build of yocto done
>> so that susbsequent build with those containers would only rebuild what
>> was changed and take the rest from the cache.
>>=20
>> The third patch is adding a way to easily clean locally created
>> containers.
>>=20
>> This is is mainly for discussion and sharing as there are still some
>> issues/problem to solve:
>> - building the qemu* containers can take several hours depending on the
>>  network bandwith and computing power of the machine where those are
>>  created
>> - produced containers containing the cache have a size between 8 and
>>  12GB depending on the architecture. We might need to store the build
>>  cache somewhere else to reduce the size. If we choose to have one
>>  single image, the needed size is around 20GB and we need up to 40GB
>>  during the build, which is why I splitted them.
>> - during the build and run, we use a bit more then 20GB of disk which is
>>  over the allowed size in gitlab
>>=20
>> Once all problems passed, this can be used to build and run dom0 on qemu
>> with a modified Xen on the 3 archs in less than 10 minutes.
>=20
> The build still doesn't work for me. I found the reason:
>=20
>  create archive failed: cpio: write failed - Cannot allocate memory
>=20
> It is a "silly" out of memory error. I tried to solve the problem by
> adding:
>=20
>  export RPM_BUILD_NCPUS=3D8
>=20
> at the beginning of build-yocto.sh but it didn't work. I realize that
> this error might be considered a workstation configuration error at my
> end but I cannot find a way past it. Any suggestions?


Can you give me more details on when this is happening ? Ie the full logs.

Can you try to apply the following:
--- a/automation/build/yocto/build-yocto.sh
+++ b/automation/build/yocto/build-yocto.sh
@@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal =3D " ssh-pre=
gen-hostkeys"
 # Save some disk space
 INHERIT +=3D "rm_work"

+# Reduce number of jobs
+BB_NUMBER_THREADS=3D2
+
 EOF

     if [ "${do_localsrc}" =3D "y" ]; then

This should reduce the number of parallel jobs during Yocto build.

Cheers
Bertrand



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:27:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424249.671532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMP1-0007UL-5p; Mon, 17 Oct 2022 09:27:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424249.671532; Mon, 17 Oct 2022 09:27:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMP1-0007UE-3I; Mon, 17 Oct 2022 09:27:19 +0000
Received: by outflank-mailman (input) for mailman id 424249;
 Mon, 17 Oct 2022 09:27:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okMP0-0007U8-GF
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:27:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okMOx-0003SR-EV; Mon, 17 Oct 2022 09:27:15 +0000
Received: from [15.248.2.148] (helo=[10.24.69.10])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okMOx-0004hZ-97; Mon, 17 Oct 2022 09:27:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=YOZZRABNYOgULx6i2hitNWcfVDjms9ZvYk61U1py+PY=; b=SvRnTl7DUqgq+IES8vmwhG2/Dj
	kZ4H+h++mS2pTfcfhcCIIe7Eu1cUfZpCxD+IJJudjPPWMnTxi/Q41aiiar56X+iWnSI3eBdBlxHtf
	4j1KGuEixwsK+4Wy5Rq/RlNifSlmwS9YPqMh6MNYcYRTforAsYIUVCRkyMbiDXepQRCw=;
Message-ID: <746da4d0-36c9-55e0-ecb6-185ba0a60ef3@xen.org>
Date: Mon, 17 Oct 2022 10:27:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Ayan Kumar Halder <ayankuma@amd.com>,
 "Stabellini, Stefano" <stefano.stabellini@amd.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>,
 Jaxson Han <Jaxson.Han@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
 <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
 <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 17/10/2022 10:17, Bertrand Marquis wrote:
> Hi,

Hi,

>> On 15 Oct 2022, at 10:28, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Stefano,
>>
>> On 14/10/2022 19:09, Stefano Stabellini wrote:
>>> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
>>>> Hi Arm mantainers/Folks,
>>>>
>>>> Please refer to the discussion
>>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>>
>>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed virtual
>>>> platform.
>>>>
>>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using ldrd
>>>> instruction.
>>>>
>>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
>>>> 0x9200000c.
>>>>
>>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>>
>>>> The proposed solution is to use two sys_read32() on GICR_TYPER to return the
>>>> lower and upper 32 bits.
>>>>
>>>> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
>>> Hi all,
>>> I wanted to take a step back on this issue before we jump into the
>>> details.
>>> Differently from other instructions we discussed in the past, strd and ldrd
>>> are not deprecated and are not "unusual corner cases". There is no
>>> statements such as "please don't use this" on the ARM ARM. If I were to
>>> write an register read/write function in assembly for an RTOS, it would
>>> be reasonable to use them.
>>
>> Just to be clear it is fine to use the ldrd/strd for accessing non MMIO area. The problem comes with MMIO access because they can be emulated by the hypervisor and we don't have the syndrome. At the moment, this is only a problem when accessing some of the GICv3 (including ITS) registers.
>>
>>> So, I struggle to see how we'll be able to deal with all the possible
>>> RTOSes out there that might have them in the code. We can fix Zephyr,
>>> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
>>> etc.)?
>>
>> This is not an Xen issue but architecture issue. The RTOSes will face the exact same issue on any hypervisors unless they decided to decode the instruction.
>>
>> As we discussed before decoding an instruction correctly is quite difficult to do (what we have in Xen for pos-increment store/load is just a band-aid). So I would expect the other hypervisors to have made the decision to not implement it. AFAIK KVM doesn't suppor them,
>> Note that looking at ID_ISAR2, it seems that ldrd/strd is technically optional. Therefore, the RTOS would have to assume it is targeting a processor that supports them.
>>
>>> Unless we can get ARM to issue a clear guidance that strd and ldrd are
>>> deprecated,
>>
>> Arm Arm cannot say that because ldrd/strd are necessary to modify the LPAE page-tables atomically. What we need to know is which instructions can be allowed on MMIO accesses.
> 
> Definitely this is something that arm arm cannot fully answer as it is also down to the full platform. MMIO accesses are going out of the CPU and hence wether or not 64bit MMIO accesses can be properly done might also depend on the bus or the IP on the other side (some peripherals might just refuse 64bit accesses or some bus might only be 32bit so the operations would need to be divided).
> 
>>
>> I think I already raised that when Ayan added decoding for post-increment instructions. There are plenty of instructions (or combinations) that doesn't provide a syndrome and yet the processor doesn't prevent anyone to use them on MMIO.
>>
>> I was worry we are going to have to continue to decode instructions in a non-compliant way in Xen just to please a few RTOs that may not even run anywhere else.
>>
>> This would also reduce our leverage to request a change in the RTOes or the Arm Arm (maybe there is already a statement I haven't spotted) because Xen will already (badly) support the instruction.
> 
> Going back on the ID_ISAR2, if Xen is properly setting the value seen by the guests, there is not reason for us to actually emulate those instructions.
> The emulation code inside Xen cost a lot in matter of lines of code and would need a lot of testing (which is missing at the moment).
> So as we have a standard way to inform the guest that this is not supported, we should stick to that.

Thanks for the feedback. AFAIU, the bit in ID_ISAR2 indicates whether 
ldrd/strd is present. If we decide to clear the bit, then it would mean 
the guest should not use them even when modifying LPAE page-tables.

This could be a problem because AFAIK those instructions are necessary 
to modify the page-tables atomically. Therefore, I don't Xen should 
clear the bit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:27:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:27:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424250.671544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMPF-0007qU-F1; Mon, 17 Oct 2022 09:27:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424250.671544; Mon, 17 Oct 2022 09:27:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMPF-0007qN-BY; Mon, 17 Oct 2022 09:27:33 +0000
Received: by outflank-mailman (input) for mailman id 424250;
 Mon, 17 Oct 2022 09:27:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=O24q=2S=gmail.com=vsuneja63@srs-se1.protection.inumbo.net>)
 id 1okMPE-0007nU-Cl
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:27:32 +0000
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com
 [2a00:1450:4864:20::62d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ecc49422-4dfd-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:27:31 +0200 (CEST)
Received: by mail-ej1-x62d.google.com with SMTP id k2so23508799ejr.2
 for <xen-devel@lists.xenproject.org>; Mon, 17 Oct 2022 02:27:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ecc49422-4dfd-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
         :date:message-id:reply-to;
        bh=NRvAeIU2zHo3eaeWipFFyokuAQvh8SGGjYzCxFApbaQ=;
        b=cgi4Dsf9tAzbRx9Rr4K/AP4Rb/RfdZfx78qcZOjDVSlKZcROm/EyialG3nGiyvOzio
         wmc2WLhYYJ3lcXKBhpF+xpQ0TBfD+qEDg7SIxr2jvKqGk1We65+rHScWavglqEKOs2DN
         c8f4nnAioXvO0G0xGvfVd8ReYeUH3f0c04YbIqmehDPrfbLTo4IlhtGwvFb8B2PCuUYM
         l/0v4MKUHRivJkNDVm5cZSgiPTroQLJus5MEBOvtG248t+n4eVx6BqoO9kHNvhjN9Jbj
         OnZ7rrZj+EQYNeGxMW0STPpntnzClRfcwYLROQVe+a28U48jvOH12GdzC2Yy5zBCJkJD
         pZ0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=to:subject:message-id:date:from:mime-version:x-gm-message-state
         :from:to:cc:subject:date:message-id:reply-to;
        bh=NRvAeIU2zHo3eaeWipFFyokuAQvh8SGGjYzCxFApbaQ=;
        b=vrp/utqhnzpTH71L17V9OS//+AyRFDryZtQrUl4124b3JvxcGvbAIjowuriZuL/s3V
         +kzWfoZ6HGr1IqeyN4WL4Z/5iCbuNaH0i2VCZH/CFpKWWMIBnf5USy5uB8CF3+YoeCE3
         RVWBer/wkE6XtdiOpPSMdhF5K9P8puvoDO+THP1kI1Q6KCGUZM0mjRSMkEPM7EKPr/wo
         F8Tvgage7ne0LvXBXputRRF7YuqmLjvvAnpn/dAWIJjsxqSN0VKtojY9d6b4D9PYd6ED
         69123ZRd+yaYSkcg1JkbxY6FYJI2iDj3xemW49KTZx9eyOhygyU6C1ubAW5PfGPP67PF
         7/rg==
X-Gm-Message-State: ACrzQf0So4EiWZy6165JgKWMKl45ocwvSJ0g6ERPgNvt+h4i4MfLBosd
	NxcGYRyW00P+aPR7zdyi+N+SYBs9LmviCY/yRZiMLAkq0Ww=
X-Google-Smtp-Source: AMsMyM6ZIzD7KufpSpivJbHIdgYZ6/T4Kj7fYOexDxjKpJvFr10g4BM7IFOwuJ1pZb5LMkIWuSi5mH41xkTz0wRq8EI=
X-Received: by 2002:a17:906:dc89:b0:78d:5616:4c24 with SMTP id
 cs9-20020a170906dc8900b0078d56164c24mr7956357ejc.118.1665998850323; Mon, 17
 Oct 2022 02:27:30 -0700 (PDT)
MIME-Version: 1.0
From: Vipul Suneja <vsuneja63@gmail.com>
Date: Mon, 17 Oct 2022 14:57:18 +0530
Message-ID: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com>
Subject: Porting Xen in raspberry pi4B
To: xen-devel@lists.xenproject.org, 
	Stefano Stabellini <sstabellini@kernel.org>
Content-Type: multipart/alternative; boundary="000000000000ab78ab05eb379568"

--000000000000ab78ab05eb379568
Content-Type: text/plain; charset="UTF-8"

Hi,

Thanks!

I have ported xen minimal image as DOM0 & custom wayland GUI based image as
DOMU in raspberry pi4B. I am trying to make GUI display up for guest
machine. I tried using sdl, included below line in guest.conf file
*vfb= [ 'sdl=1' ]*

But it is throwing below error:










*root@raspberrypi4-64:~/guest1# xl create -c guest1.cfgParsing config from
guest1.cfglibxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error
on QMP socket: Connection reset by peerlibxl: error:
libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP
connection to QEMUlibxl: error:
libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup
configs failed, rc=-26libxl: error:
libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did
not start: -26libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device
Model already exitedlibxl: error: libxl_domain.c:1183:libxl__destroy_domid:
Domain 3:Non-existant domainlibxl: error:
libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy
guestlibxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain
3:Destruction of domain failed*

Another way is VNC, i could install tigervnc in DOM0 but same i couldn't in
guest machine because it doesn't support x11(supports wayland only). I am
completely blocked here, Need your support to enable the display up.
Any alternative of VNC which could work in both x11 & wayland supported
images?

Any input on VNC, SDL or any other way to proceed on this? Looking forward
to hearing from you.

Regards,
Vipul Kumar

--000000000000ab78ab05eb379568
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>Thanks!</div><div><br></div><div>I =
have ported xen minimal image as DOM0 &amp; custom wayland GUI based image =
as DOMU in raspberry pi4B. I am trying to make GUI display up for=C2=A0gues=
t machine. I tried using=C2=A0sdl, included below line in guest.conf file</=
div><div><b><i>vfb=3D [ &#39;sdl=3D1&#39; ]</i></b></div><div><b><i><br></i=
></b></div><div>But it is throwing below error:</div><div><br></div><div><b=
><i>root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg<br>Parsing confi=
g from guest1.cfg<br>libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Dom=
ain 3:error on QMP socket: Connection reset by peer<br>libxl: error: libxl_=
qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connect=
ion to QEMU<br>libxl: error: libxl_dm.c:3351:device_model_postconfig_done: =
Domain 3:Post DM startup configs failed, rc=3D-26<br>libxl: error: libxl_cr=
eate.c:1867:domcreate_devmodel_started: Domain 3:device model did not start=
: -26<br>libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Mode=
l already exited<br>libxl: error: libxl_domain.c:1183:libxl__destroy_domid:=
 Domain 3:Non-existant domain<br>libxl: error: libxl_domain.c:1137:domain_d=
estroy_callback: Domain 3:Unable to destroy guest<br>libxl: error: libxl_do=
main.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed</i></b=
><br></div><div><b><i><br></i></b></div><div>Another way is VNC, i could in=
stall tigervnc in DOM0 but same i couldn&#39;t in guest machine because it =
doesn&#39;t support x11(supports wayland only). I am completely blocked her=
e, Need your support to enable the display up.</div><div>Any alternative of=
 VNC which could work in both x11 &amp; wayland supported images?</div><div=
><br></div><div>Any input on VNC, SDL or any other way to proceed on this? =
Looking forward to hearing from you.</div><div><br></div><div>Regards,</div=
><div>Vipul Kumar</div></div>

--000000000000ab78ab05eb379568--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:29:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424261.671555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMQp-0000A5-Of; Mon, 17 Oct 2022 09:29:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424261.671555; Mon, 17 Oct 2022 09:29:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMQp-00009t-M4; Mon, 17 Oct 2022 09:29:11 +0000
Received: by outflank-mailman (input) for mailman id 424261;
 Mon, 17 Oct 2022 09:29:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sEel=2S=linaro.org=peter.maydell@srs-se1.protection.inumbo.net>)
 id 1okMQo-00009i-Nq
 for xen-devel@lists.xen.org; Mon, 17 Oct 2022 09:29:10 +0000
Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com
 [2607:f8b0:4864:20::102c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 26edc1b1-4dfe-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:29:09 +0200 (CEST)
Received: by mail-pj1-x102c.google.com with SMTP id
 l1-20020a17090a72c100b0020a6949a66aso10438109pjk.1
 for <xen-devel@lists.xen.org>; Mon, 17 Oct 2022 02:29:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26edc1b1-4dfe-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=GxEGpiSzBHt9BqiFkOcZ5zlKXWHEoNLLevXAafowxWo=;
        b=Kpc5sZNJnO9CwwdgqFNc7oKQBcYHT9ae/Bjl1u46ikkM4MH4bF6j+GshmNjQCXZlPy
         IHaucVX/62ciBC9Ja6LunhhQduPYLU2u38vKKC5TaTKM2DnSNsQexWuDAykvzQIrKqqh
         olSpA8JEHTEhhrusl/LGt97MVy7cLSRhupU5rqK5i64xr2W8QYg2r4hn0qEQ9wR1ERwk
         2rXsUIqMaLkTNET7BYATlpSg4j5BfIsmAh8b051UGrc6hjdmKejnru59MS1gmLLAKMyi
         rZu9xIIu0uAEKwlZHkNMH67W6AZ0584s6w2X/waNFfXRF9i4pgg642PQJklBtfmp3k18
         oklA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=GxEGpiSzBHt9BqiFkOcZ5zlKXWHEoNLLevXAafowxWo=;
        b=6El07fQ0GYSlTgZn8c5ko/lS98o/g4fOXnBD5TBD7DhVwL2VDJIjSl9g+HUrjkhO3R
         oeNVrHqIIilb0d8ksUzlkUIFDL3e17dATflU2m/5tDJ+hBqdw9qkv+v4feHKx2DNIBnU
         r3HmH9otToGBix3/3fYZZ5RmxEooMqXW1FXUo7TC39XgaZU+HDbgc/aw+UBz7+Uc7df/
         l47d1CmAq/PuJxpty1YJN8X83oXL/eRWXI6vNxY7BtPriw1OJMzVGyOrON05vQlGXSKV
         hei2mJ9DACXvQd2RaTfRXM1SaGbU3cmir1011FQJPL+zVppQmc6oPH7YcYlFc0Z8gkOu
         XMow==
X-Gm-Message-State: ACrzQf0FHMsWVlqb5eGII0dARJ/XBNdvNyImJt6PqEGDWPkI6wED/DU3
	ujEKl4EQx167bgAP+ZFuJP26aJw//ugCfre5t3MGDA==
X-Google-Smtp-Source: AMsMyM51AOB0WrRXL+jvrgmy+L/8DCtcmAXW0tHJVZjJrm/ib0nHzR9TOPXF/xVX0dvyivuGdBaWmZ91P+MwGAXuG9s=
X-Received: by 2002:a17:90a:fe92:b0:20a:daaf:75ea with SMTP id
 co18-20020a17090afe9200b0020adaaf75eamr31450109pjb.221.1665998948362; Mon, 17
 Oct 2022 02:29:08 -0700 (PDT)
MIME-Version: 1.0
References: <CALUcmU=x3Vok0oaR-ic3djkgnVG9rxWa3KjWC1xq1KwMXpBBGw@mail.gmail.com>
 <1b3d21a2-9029-6f3a-0579-e08682814222@suse.com>
In-Reply-To: <1b3d21a2-9029-6f3a-0579-e08682814222@suse.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 17 Oct 2022 10:28:56 +0100
Message-ID: <CAFEAcA-PqE4p9vJo3TWmfBdYkGiYfCnxNDJhCAWCM2Y0txGTLA@mail.gmail.com>
Subject: Re: [BUG] Xen build error - undefined reference to bpf_program__set_socket_filter
To: Jan Beulich <jbeulich@suse.com>
Cc: Arthur Borsboom <arthurborsboom@gmail.com>, 
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, 17 Oct 2022 at 10:02, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 17.10.2022 10:12, Arthur Borsboom wrote:
> > Xen 4.16.1, 4.16.2 and 4.17.0-rc1 don't build anymore in Arch Linux.
> > I believe it is caused by the missing function
> > bpf_program__set_socket_filter provided by libbpf.
>
> That is, qemu doesn't build. That's something to be taken care of there,
> not in Xen, I think.

This should be fixed in QEMU by commit a495eba03c31c96 (May 2022).
Are you using an older QEMU version? If so, then either move forward
or else cherry-pick the fix.

thanks
-- PMM


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:37:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:37:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424268.671565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMYn-0001l5-Nh; Mon, 17 Oct 2022 09:37:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424268.671565; Mon, 17 Oct 2022 09:37:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMYn-0001ky-L6; Mon, 17 Oct 2022 09:37:25 +0000
Received: by outflank-mailman (input) for mailman id 424268;
 Mon, 17 Oct 2022 09:37:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okMYm-0001ko-HZ; Mon, 17 Oct 2022 09:37:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okMYm-0003dV-CT; Mon, 17 Oct 2022 09:37:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okMYm-00017v-0x; Mon, 17 Oct 2022 09:37:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okMYm-0007eF-0N; Mon, 17 Oct 2022 09:37:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KzpoqTBJb//XLIXxqamCHnqBkVYmDrU8V15fXlsWsrE=; b=2a7PGz1B0K7zc0cYnKfDpRx5IR
	lQuUdYDvgtThwvKjTsrDqXWp9bubDlrnfLTShZ8Y07xPmetPGNFn3yT/TDQ0CwLsoxZ11ouTM8pT4
	CgyUfJj0y8AS7T2W94Y3/kkrkXz8Rw+lLTWPHfJiovsMJXsuNzyjxbk9L+gjbvJFbxmk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173882-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173882: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 09:37:24 +0000

flight 173882 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173882/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 173882
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   59 days
Testing same since   173493  2022-10-11 13:07:01 Z    5 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:50:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:50:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424276.671576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMli-00043f-VX; Mon, 17 Oct 2022 09:50:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424276.671576; Mon, 17 Oct 2022 09:50:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMli-00043Y-Sq; Mon, 17 Oct 2022 09:50:46 +0000
Received: by outflank-mailman (input) for mailman id 424276;
 Mon, 17 Oct 2022 09:50:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CpyK=2S=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okMlg-00043R-TW
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:50:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2a02ebea-4e01-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:50:43 +0200 (CEST)
Received: from AS9PR06CA0720.eurprd06.prod.outlook.com (2603:10a6:20b:49f::31)
 by DB3PR08MB8963.eurprd08.prod.outlook.com (2603:10a6:10:42b::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 09:50:26 +0000
Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:49f:cafe::de) by AS9PR06CA0720.outlook.office365.com
 (2603:10a6:20b:49f::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31 via Frontend
 Transport; Mon, 17 Oct 2022 09:50:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 09:50:26 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Mon, 17 Oct 2022 09:50:25 +0000
Received: from b22b9f0567e0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1F0F695A-4188-4E78-8D00-AB1BBA3563D0.1; 
 Mon, 17 Oct 2022 09:50:15 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b22b9f0567e0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 09:50:15 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DU0PR08MB7763.eurprd08.prod.outlook.com (2603:10a6:10:3b9::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.28; Mon, 17 Oct
 2022 09:50:11 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 09:50:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a02ebea-4e01-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ENKEhc975Y0EGve9CDbybTTXZ9LRC7C+tnUBPWSB/ZNH/IgdDMxhM6cbgQpyxX/CVgeSUiEWaWg6K/g2Lados/TKQccrSoTUS3VPOS3rRa9nkIGabuh+3UNfaXc35T0Y/TVp8GN+M7LFRBsxcMzOazk9lkYBpo9B1OQ4pzEoy6cczu7Ixs46ISNlRfF2TPMXielL4F3JRwcbCyRpGcBzVOd2yOAiclRp81OgQB7y6PEbPHLMRO0+zLU8j0Mf2PecNeD5yRkjnVRzmdle24Hyo2Tp+SO8l+9PdKcZBIFcC87cDiYO8bJPK9IjSCpcQIp+738L2Re7rraigY98TBCsaw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hln1HqoRAY9j8vSTiaOQNbP/esfHGm+SlAueQ9hWhsg=;
 b=A/KZpCH4RatmfvUSZo9r43MngC1eEDfBT90HIPpm+dxHCG+au5wlBS5MjHqhec/wMo0+0XPTsm6pAwhD7GkvKF3sVLzns3sLcXWFQOf3mpx4BEYkud54PmGHfDyUlCMky6c10+Oox+15th0NN2yYDBwnsZKCEasE5OoBipnji0KtKClBIXZuxzlbdgMqSQBv9ItqDFMp3TzFJDGHC4b66aHtDPhujWuKvm9qd8ngfpo52cDPK5aQx0k7qV1VKYJ++QpHbOVAFnrwnC+5cziul/QezwtINXWYZUMcJkmT6JX5HZ5UYbPWFX75Ix1iepBPPu00yD/NFm+6uOGN+98m1A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hln1HqoRAY9j8vSTiaOQNbP/esfHGm+SlAueQ9hWhsg=;
 b=VeScpkmFUNrYQxHXm+CFImou6Z8AwLpFS2PMU5+e5jJKLwUxPXIs0vKdf43Xs16OzriRxkK0yNi7oQo3On5enaNCK2V50yqUYIvQJcnqa9LJDWg0DisaNLE4ioc6C41qDcMfGtNodPgEDult5mCpi/Nev78TKDgiZPucXJfcM8c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 04d89ae35d4ae77e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WvXTojj93wOo4lsZpn7XM5gi07YRL9mp2Dka81aK+SapsFotx3Q28PFL4Zdkr2/BSR6zJV6wehBJn4iMpd/U2U3XDviKhyuUWOKy3t2hIqvuGs8+Xr02mo85otX4I4lNaQBs9cE2M+tAIvk52GebDVg/jNYvMXPGayYjRfJL7fY5ZoAP4taP+J6mTIvI6Dp4yOU755WMWE/lDQH5YAVd6D0vEFHnaUC3A5vftBqNJJfvkS3smmJl63VYjGQ2f4qqOEdzPdzuMaENPkbHQz0slfGS8ZVU07aXRI0nx4sSPMUk02+Plzkp51bOA9c/VeptO5Qz7c3qCKpj9MdBoBqFpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hln1HqoRAY9j8vSTiaOQNbP/esfHGm+SlAueQ9hWhsg=;
 b=cG13RTo/tiO3+Uu/5PQ4CB4gB+v6vMfnrTYeGfeqOhkPMLbkMxMwZGtFjegf1ThAMVjbbl5TLWeUruNG33bjJ7A8/SoICgdFL+RJ4/9W0gA4fbVoyksZSENnooXeFE9z4zo/WLfJQoHoA3YMc/PoSkaUsXNEo98Ib0r4I3530RCvf4nlyftLXAsgc0C/ZxEj58bAdXmsRRPisaCWPkLGn8e9Fd5dzHbDbCtGgbzNBUtJOQj7QH1n+kHf/WQgYHtO1gxKXhYI1Ddg9cCW2POx25QJ54H0fAkKExvZy4VVECx4tXbE4l8UywrPXs6tSBby7EBnr7nyoaT4S7S2U4525Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hln1HqoRAY9j8vSTiaOQNbP/esfHGm+SlAueQ9hWhsg=;
 b=VeScpkmFUNrYQxHXm+CFImou6Z8AwLpFS2PMU5+e5jJKLwUxPXIs0vKdf43Xs16OzriRxkK0yNi7oQo3On5enaNCK2V50yqUYIvQJcnqa9LJDWg0DisaNLE4ioc6C41qDcMfGtNodPgEDult5mCpi/Nev78TKDgiZPucXJfcM8c=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Ayan Kumar Halder
	<ayankuma@amd.com>, "Stabellini, Stefano" <stefano.stabellini@amd.com>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, Henry Wang
	<Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Jaxson Han
	<Jaxson.Han@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Topic: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Index: AQHY3vmtdKYr9F2nyUuznJvSQYcvHq4OMlaAgAEAmYCAAyG8AIAACRAA
Date: Mon, 17 Oct 2022 09:50:09 +0000
Message-ID: <5A261DDB-992F-4290-BC0C-05B8508896DC@arm.com>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
 <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
 <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
In-Reply-To: <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|DU0PR08MB7763:EE_|AM7EUR03FT005:EE_|DB3PR08MB8963:EE_
X-MS-Office365-Filtering-Correlation-Id: 794d9059-3e04-4e8d-2a79-08dab0250473
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 aV3PAPEmBax1ji+ZDASmiZ+61QCc6zQG2t9x6be5xnz+YSRf/lVCBrNmBIUaQtEOxn98/8m8Vlb8iqVGHzFR/OPywdPH6Q9Jx+QZX0qOQfoBl6ZP7pCBULeYizzV/pr9DwSFSpDNjMME+MLIyimcd2AZTlNKv5NyztgqxF4ykKU4R1T9lqO4TkWud0Tl1hQX9DqzGm45vF86qTlx+U8U9a88PMzUGsT0FjBz8ZHM4KuHaeNYZo22HaBTSwA7tsaKJiSvRp7N4QbF1ZJoi1nystmq6PqNbTYDetg4tj0LmOowN/0MIfKe9OukMXxLeFL4e2M/l6o5e/2ETAJf8Rf8HDK9/tKN/RLLJqKINc17pfw8Hd1PdZiY/SM6tyKvUCWc6Tu81MB87QedyqqUaKBBJPDBsqG1et7bUArTchY3tzk1rGWQNddZnnpQfdm3Qh67gVtXWW4ZqI2pTXz8euoqAf5K2NuO17lq/25Zarfu8R0D9WGzbE5K0P07YdW59A8ZmvClb8K1dq2qMOyFhC038beqyKhua2c6cIFhsaQXGmoeNjeCzQf+enGaDAPXwDoKv49lfdPn16M85VrbgVtSFViF/nfGiFXElb1bJTHSh9HZ9HSeB3dBJobbHfYLh1/QD9LP2oiatYCmIIXdDAS4dOtTY+hj1pqpbxckbWNtlKl5f32Ofb9jFHzkkDUbuO06DoxCvh1oKXsdsRxoq5d/l0z1kl0LAczv3AyED2RoZaapTRzai0mNBnaZsLA5piQSjSKqJNqvlOWtXrDqENm0aZLzYro2Mv9GvLCuK7EDWRSvUeSwDc+/TsE1ZlHXzc28H4MGiU1qkwjHkyr4860RIQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199015)(66899015)(6506007)(36756003)(2906002)(33656002)(8936002)(5660300002)(53546011)(86362001)(186003)(6512007)(26005)(41300700001)(38070700005)(2616005)(478600001)(4326008)(8676002)(64756008)(66446008)(6486002)(966005)(71200400001)(66946007)(76116006)(66476007)(66556008)(83380400001)(91956017)(38100700002)(6916009)(54906003)(122000001)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9EA681C8C0FFBF4E871FD70B1F2D3225@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7763
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c2452fe9-e34a-4f9d-e18d-08dab024fa6e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0yTW4KTZdigHTP/O0kfFKjoPbkL3SdsIY+/yuLJeRrRBMKw0liyWQqwdBNICRYqc4jJyGcyOQ9ZRlFpZSbo/f5Fu+k6XN6ZnPYut+fdGMGaZQv3aUnt5Ti/a5CyMJYxtofof4FQ8md8dXl+IYjoIbpmIPd9yIxvh9iRdGlTDQSLG56Bs4O3+kMWrpIb0hDm/kKNF6scyAJCcaY/e7FyXZME7ijUxjSC+q/7VEfjhwq3cYxaTO/T+6rGCaVL5mMjqLaiMlMSZ2PiRrjIUD9mHyp4ApaW+T+M/MSQPj5vvALVXoDvhPQmbKGJZvK1P+PJ7SHfsgNb3ZOZ3Bs7Nq0TNAsZvDdiPQG0yZU8Kqckqv7BgArz3Kb1bRrDUz0o7w6b2VGjrF/T1xfu9BI+AOfSYQiDS3+8pKZEMSxNCSPsWpFqopVTwO+2SpEaPWBwCTGD6mch+U87nRn+JS/kDGT9ve4EKMwQwq4TMpeuK19u2NAhBEgOVHMie/SPWek/EUlUSeY5rvMEt2bwWoMjXpjA8ijPP6A30SlY7RevucqxMXu/jISq5/DSJhrNVnrTb5FfH3/OTbQRUWlgpL1mPWF9wX7gu4baqyKRf5s8Ss9Yu5CmfceZJsQ5VXf8lYNEwcP9dbw48Gbb0WOQvFZSRGG2HdgAlp6pOh+xu2vXZ/zWpEb+ww8VLbClz3xAAGP6VW4LwWfBNGOMMVZxNnSutn5NtKg8s5GrcsX9weswzXuKhk6JYpj69yCcTiqX9dLA1WOZujOpxHuMsvLbrIaB9+58vGg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(46966006)(36840700001)(66899015)(36756003)(33656002)(86362001)(2906002)(5660300002)(82740400003)(336012)(2616005)(186003)(47076005)(81166007)(356005)(83380400001)(26005)(53546011)(6506007)(316002)(966005)(478600001)(6512007)(54906003)(6486002)(70586007)(70206006)(8936002)(36860700001)(40480700001)(82310400005)(6862004)(41300700001)(4326008)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:50:26.0656
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 794d9059-3e04-4e8d-2a79-08dab0250473
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8963



> On 17 Oct 2022, at 10:17, Bertrand Marquis <Bertrand.Marquis@arm.com> wro=
te:
>=20
> Hi,
>=20
>> On 15 Oct 2022, at 10:28, Julien Grall <julien@xen.org> wrote:
>>=20
>> Hi Stefano,
>>=20
>> On 14/10/2022 19:09, Stefano Stabellini wrote:
>>> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
>>>> Hi Arm mantainers/Folks,
>>>>=20
>>>> Please refer to the discussion
>>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>>=20
>>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed vi=
rtual
>>>> platform.
>>>>=20
>>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using l=
drd
>>>> instruction.
>>>>=20
>>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
=3D
>>>> 0x9200000c.
>>>>=20
>>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>>=20
>>>> The proposed solution is to use two sys_read32() on GICR_TYPER to retu=
rn the
>>>> lower and upper 32 bits.
>>>>=20
>>>> With this, HSR =3D 0x9383 000c, ISV=3D1 so ISS is valid.
>>> Hi all,
>>> I wanted to take a step back on this issue before we jump into the
>>> details.
>>> Differently from other instructions we discussed in the past, strd and =
ldrd
>>> are not deprecated and are not "unusual corner cases". There is no
>>> statements such as "please don't use this" on the ARM ARM. If I were to
>>> write an register read/write function in assembly for an RTOS, it would
>>> be reasonable to use them.
>>=20
>> Just to be clear it is fine to use the ldrd/strd for accessing non MMIO =
area. The problem comes with MMIO access because they can be emulated by th=
e hypervisor and we don't have the syndrome. At the moment, this is only a =
problem when accessing some of the GICv3 (including ITS) registers.
>>=20
>>> So, I struggle to see how we'll be able to deal with all the possible
>>> RTOSes out there that might have them in the code. We can fix Zephyr,
>>> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
>>> etc.)?
>>=20
>> This is not an Xen issue but architecture issue. The RTOSes will face th=
e exact same issue on any hypervisors unless they decided to decode the ins=
truction.
>>=20
>> As we discussed before decoding an instruction correctly is quite diffic=
ult to do (what we have in Xen for pos-increment store/load is just a band-=
aid). So I would expect the other hypervisors to have made the decision to =
not implement it. AFAIK KVM doesn't suppor them,
>> Note that looking at ID_ISAR2, it seems that ldrd/strd is technically op=
tional. Therefore, the RTOS would have to assume it is targeting a processo=
r that supports them.
>>=20
>>> Unless we can get ARM to issue a clear guidance that strd and ldrd are
>>> deprecated,=20
>>=20
>> Arm Arm cannot say that because ldrd/strd are necessary to modify the LP=
AE page-tables atomically. What we need to know is which instructions can b=
e allowed on MMIO accesses.
>=20
> Definitely this is something that arm arm cannot fully answer as it is al=
so down to the full platform. MMIO accesses are going out of the CPU and he=
nce wether or not 64bit MMIO accesses can be properly done might also depen=
d on the bus or the IP on the other side (some peripherals might just refus=
e 64bit accesses or some bus might only be 32bit so the operations would ne=
ed to be divided).
>=20
>>=20
>> I think I already raised that when Ayan added decoding for post-incremen=
t instructions. There are plenty of instructions (or combinations) that doe=
sn't provide a syndrome and yet the processor doesn't prevent anyone to use=
 them on MMIO.
>>=20
>> I was worry we are going to have to continue to decode instructions in a=
 non-compliant way in Xen just to please a few RTOs that may not even run a=
nywhere else.
>>=20
>> This would also reduce our leverage to request a change in the RTOes or =
the Arm Arm (maybe there is already a statement I haven't spotted) because =
Xen will already (badly) support the instruction.
>=20
> Going back on the ID_ISAR2, if Xen is properly setting the value seen by =
the guests, there is not reason for us to actually emulate those instructio=
ns.

We need those instructions for page table access and it is mandatory to sup=
port that on armv8, so not the solution definitely.

> The emulation code inside Xen cost a lot in matter of lines of code and w=
ould need a lot of testing (which is missing at the moment).
> So as we have a standard way to inform the guest that this is not support=
ed, we should stick to that.
>=20
>>=20
>>> I think it would be better to attempt to decode them rather
>>> than just fail. I don't like to have this kind of code in Xen, but I
>>> don't see a way to support R52s without it.
>> That's not specific to R52. This is anyone using GICv3 on Arm32 core.
>=20
> Agree.
>=20
>>=20
>>> That said, of course if Zephyr was to use two 32-bit reads instead of
>>> one 64-bit read, it would be better for Xen. And we have more important
>>> things to deal with right now in terms of R52 support (it is not even
>>> upstream yet). So it is totally fine to change Zephyr and move forward
>>> for now.
>>> But medium term it doesn't seem to me that we can get away without a
>>> solution in Xen for this (or a change in the ARM ARM).
>>=20
>> See above. This is an architecture problem and we should discuss with Ar=
m first before continuing to add more decoding in Xen.
>=20
> I will discuss it internally to have an answer but I think that the answe=
r cannot only come from Arm as there are for sure hardware implementations =
that cannot support this, as explain before.
>=20
> Cheers
> Bertrand
>=20
>>=20
>> Cheers,
>>=20
>> --=20
>> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 09:52:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 09:52:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424283.671587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMnL-0004hV-Dg; Mon, 17 Oct 2022 09:52:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424283.671587; Mon, 17 Oct 2022 09:52:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMnL-0004hO-Ay; Mon, 17 Oct 2022 09:52:27 +0000
Received: by outflank-mailman (input) for mailman id 424283;
 Mon, 17 Oct 2022 09:52:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CpyK=2S=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okMnK-0004hG-8u
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 09:52:26 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150074.outbound.protection.outlook.com [40.107.15.74])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 67419b83-4e01-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 11:52:25 +0200 (CEST)
Received: from DB9PR01CA0018.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:1d8::23) by AS8PR08MB8086.eurprd08.prod.outlook.com
 (2603:10a6:20b:54b::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 17 Oct
 2022 09:52:09 +0000
Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d8:cafe::19) by DB9PR01CA0018.outlook.office365.com
 (2603:10a6:10:1d8::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31 via Frontend
 Transport; Mon, 17 Oct 2022 09:52:09 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 17 Oct 2022 09:52:08 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Mon, 17 Oct 2022 09:52:08 +0000
Received: from e430d728d7dd.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 26E75044-943D-421D-8CFC-C29B57CCD33A.1; 
 Mon, 17 Oct 2022 09:52:01 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e430d728d7dd.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 09:52:01 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS1PR08MB7611.eurprd08.prod.outlook.com (2603:10a6:20b:476::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 09:52:00 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 09:52:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67419b83-4e01-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=hMJaHYGRtBUkovyMpfVZDFeD0/BNHYush0dxLyuE7Pews5JuJd+rh1pCV/jh01iKqGwYKHV6oFdSwQvIQ57SA+z7RtH4fmoi5Him3CiumD8dvu9nkDIKSpyLhMNNMkKwYuq3/oh8xKNPEz4o+rueI59i/bdbKmNCvub3rn2YXdfD00+1z44plVyUZ+4YqJdDTgFKAgvGMSBAFzG5yJ5M3FdZxaS3TEwKAfW+RlxFFNiL7KdY+ausTTq5AVHUQ/6YtPyfPAJm4SNIrqTNKptbbakpGAGLULA59bH40wEkKsCTiYGwWJ7V6RhFudpMKC8FdiHus6iz6GUPxI4Ocvl6Bw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c7fIctafsmzH1UfMVRSQkdOlGHKdJJ8GrFavTfzm+GQ=;
 b=Kc7BmsuHOC3swIQ6zLkEMC1q8lOgNrJ0elpnarpyYsE64gLv69nXp/8Mc1MjXm03EbOBJfdyUwoOn+wnMyn/OP2Vq7h1JgpXG63FNfZcI7ufjzvzHEThE4n9iXxs8bb8SmjYM60sSWeDcsEc4x52cOKf6HT+tVOl5gdpqQgdj2sipSyiGdifIeIFejjnv4X0zHpgcZEQnZLuTt431jhSs4Al3vtjnafqd1OK+nHEOesWaH+RGPdQuNicFwPORd8mut1eFylXYEJe4UZmOJPK/VMPfFyrtaHVeX/ld6NzopWGPoehDgg3M98RROHSzn12xjZJx8lS/QleZSuW8lRt3g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=c7fIctafsmzH1UfMVRSQkdOlGHKdJJ8GrFavTfzm+GQ=;
 b=n8+O0iiOFeSMRe2eLTDEN7XHKdB+/y26apzMTIVQs8g2bvunrRJuO89QSQb9BwxCv+fWohKpmeC9P49/wGKmN75/kxMjBL4lZD8iKkYHZvflHUQfojeXdrZ4yQTRjFcc42/hHGOS03LzchkKpXRHC7o7vOPpj7jVqAEXURrfpXM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: a327fce7d2d2a01d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cH/4c6vZ/cf5s4qI9I7h8ITl+jbpk7SOrgrQEsOktimvTDaWLjfdV6zESDdzU/6jHiFNHICRRk2zFR6mFFi6Wcm0oe+AjyIYrPyurU15wNhLKX7buX9q6CRAw8coxjKsWFBSMOs+mqiSLN0/rmSiudTDDfhaSb8oXKM1cN15StneCHYngUOoyLCGdJOHPbmtmIHLuKqJ8m8tsksQvhsdJufvk8vFIZexZmx6ZaiVnZxH0TnIrRzlLT93VahXLNYUFmRoEDovvtRpiauEZkbU35AEx3PdxT/26os+riwD1/ETjdIoPLh9WFBXOx0TXabiM1/GrtJxzqpEcBtCutTSpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c7fIctafsmzH1UfMVRSQkdOlGHKdJJ8GrFavTfzm+GQ=;
 b=Q21e55cHZwmAy4v+KB1+trt40WIUP6j5w/d8aru2Gjf56qHqMyRk6TskzvfuzJZRKzbRHpcn2a6bL3uaGr5chkvrl/qg0tEF0uZTME+yc9qAozbTW+j41pkCOtFfsaJjSnwgdZ57COcXZNhyw256XP5D3UCrXzTs55/r0Wf6PrQr0t/ewa/KUjnZzJ6GH/eIlw6tbXaNtTf5eq1O/db1UBnmy8qpTlFXC1lyTNtgpzPbI5/FG5X27Mf8Z5tPP6G/Ypn1o+2b8vZWgW0VIQFA0DAolMZFMpXAotixurG+lhmULaDYHK90uMenoMv5ehBlA2cQ2j7jLQ/X6O8VD2745g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=c7fIctafsmzH1UfMVRSQkdOlGHKdJJ8GrFavTfzm+GQ=;
 b=n8+O0iiOFeSMRe2eLTDEN7XHKdB+/y26apzMTIVQs8g2bvunrRJuO89QSQb9BwxCv+fWohKpmeC9P49/wGKmN75/kxMjBL4lZD8iKkYHZvflHUQfojeXdrZ4yQTRjFcc42/hHGOS03LzchkKpXRHC7o7vOPpj7jVqAEXURrfpXM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Ayan Kumar Halder
	<ayankuma@amd.com>, "Stabellini, Stefano" <stefano.stabellini@amd.com>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, Henry Wang
	<Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Jaxson Han
	<Jaxson.Han@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Topic: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Index: AQHY3vmtdKYr9F2nyUuznJvSQYcvHq4OMlaAgAEAmYCAAyG8AIAAAqcAgAAG7YA=
Date: Mon, 17 Oct 2022 09:52:00 +0000
Message-ID: <78B6710C-42AE-4889-8D2C-C1A12F1548D8@arm.com>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
 <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
 <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
 <746da4d0-36c9-55e0-ecb6-185ba0a60ef3@xen.org>
In-Reply-To: <746da4d0-36c9-55e0-ecb6-185ba0a60ef3@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS1PR08MB7611:EE_|DBAEUR03FT009:EE_|AS8PR08MB8086:EE_
X-MS-Office365-Filtering-Correlation-Id: d78a2a73-4164-4ee0-d4b6-08dab02541b5
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 BCvzPqG9Jdv2qoTKhxG7VBiZnAMCc6MCzaLhdLmk28UFTrEtRJfap5qVqOUjoTY+4kYCftOdWY4nTdDlAPUku1E7uZm7W9pC9T38zVfzvff+YBzPQkBkbDhfPk0ebi+CvGkHll9ZYCz6ErMoH/N6wfW6mB1whWNsfZtOxOpT6qJGL7kntIUlh3z3pE/TFHXaidzgIyJot8NLBiwQaOVdpzFZRyyVVKnb5VLl/hcp39G81J7C2LTlFwxgbLCHwSbbbFuXkTWGU7DiVd7fkgZcCJDVmyEc13ioWdKaHVnuQ1RtaK70Y4HnnWU2jQ6z6Kwn3zfOdhqgPdtD2Zc5quVu69owp3vZm5gUXTTo47QK7ij9fm+ahNumdMi2gZt4KmRBapcUEofHXjMpIbpeOLk4Xu5I5Mwef/rFWSNLjv4rEjkmJodj17aU//Nj6xQtbfzpuf/FzEaHtU9GpDZ6wCHNmrNlMo9psasPhOuV06vAKxTvFmDrlcspoDCIxpWOOxAl3Q6xHw7usXhyJi5CQZIiSzIupB24JOfNGcoTMhEDSWDrf1Z01bS58B3PVX57WmPU4+j3+iNJmjYIv9elng8tmgYIS0p9ycWE4N1Zm6+uOjhH8XNMv/wskHGNHGSqB9GKTSC98DBw08uo+GFVPyjEswdtBUoU+G0EfpvrOPeTtgfyhYVeLz0JHNVlopnMYlFSt0NbasrMTUSv175g9MndNm7dN6E8yzM6R4cPRfoa3s5lPq9mUcVkrY/FTnam/a6zYf5+Ba2kDaocoPyyn+6qg5CqTtDSXGHe+C+7lEk143oR12m2deeqTNoFzGMqCvxyohCyvfTvOJ60E3i5eVWdmg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199015)(966005)(6486002)(478600001)(66899015)(71200400001)(38070700005)(38100700002)(122000001)(2616005)(186003)(33656002)(316002)(4326008)(66556008)(64756008)(66946007)(66476007)(66446008)(6916009)(54906003)(76116006)(91956017)(8676002)(6506007)(5660300002)(36756003)(26005)(53546011)(41300700001)(6512007)(8936002)(86362001)(2906002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FDB0585602E27D41964BC426BBAAAAD9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7611
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b0ad702a-e96b-4cd1-3ae5-08dab0253c71
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	emv95fWu3yF1iwhzDg9eZGfnaJWoDI3uYpofzrdUXTx4PCXUFEmZRctTHkedCv9zJg2lCTabFOf/feNs2q9pnIPsSMVDKbzAMJxyxlXtgjPjGFyZp5y6EfaEOg/q1zvjtFJLE0NRtnk/8yRAdXjpEKQyxVBbSy50Xi3G+uzDfZ7XoYzEjYjis7UKSbeEFdqxeYb856MuL7z+jGeduQd0fjIcs5zLMc4Sojb73LGTSPeAd5q5UEg2iI3H/7KendIW6MCAjy43KLsqj2G9B9VQ+SoTCBKydQ+aEPOotJkasmPP6cg8wEkLbqPYZOuEgYpMK+nRY4QogWLuDH/d6z7wZ+UO099pkQIAmgY1kbYJ/5/A0YPv5y8ci2LQL2EcIqrSMoVTAYjRBtmLdYkdotijMKbuAE59fD9CBk4hM72+8pS45/n937TLWMEUU+nYBOq8hM7OggvCI15l31rlp/80iDzp1g6YPBBmiGzyCCFnC/mFzlJfVFfr1HmEI8/onINWP/1yV/sButd5y2yXW6bUt5JLStATQd0rXyXzi7Qep0etHbQslFoNfaxz7l4VxXifLkA6FEaoImRC999b6I9Fb6fz3D7dsd4ckLIXZvVQJdxliexhMLrs/mhFd1XNOzIQKRum9rxkkYMaWchNopQZi0fi+G1zlfm4kHqGEFqwU4e8Z3lLyS2dF13r8iSrbqQBzKJYcn0bxi5VUcQcrZ2KLa1kGM0HwR0kTh+o1VnRHmjhgGme5APizIAZuf5GqTsQD/D/N3l6YlQClDGRcTtLn+1HO81zVpbughM5TVH0wDc=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(40470700004)(46966006)(36840700001)(66899015)(36756003)(33656002)(36860700001)(86362001)(5660300002)(2906002)(82740400003)(336012)(2616005)(47076005)(186003)(54906003)(6486002)(356005)(81166007)(83380400001)(6506007)(53546011)(316002)(966005)(478600001)(6512007)(70206006)(70586007)(26005)(40480700001)(82310400005)(41300700001)(4326008)(8936002)(6862004)(40460700003)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:52:08.9060
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d78a2a73-4164-4ee0-d4b6-08dab02541b5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8086



> On 17 Oct 2022, at 10:27, Julien Grall <julien@xen.org> wrote:
>=20
>=20
>=20
> On 17/10/2022 10:17, Bertrand Marquis wrote:
>> Hi,
>=20
> Hi,
>=20
>>> On 15 Oct 2022, at 10:28, Julien Grall <julien@xen.org> wrote:
>>>=20
>>> Hi Stefano,
>>>=20
>>> On 14/10/2022 19:09, Stefano Stabellini wrote:
>>>> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
>>>>> Hi Arm mantainers/Folks,
>>>>>=20
>>>>> Please refer to the discussion
>>>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>>>=20
>>>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed v=
irtual
>>>>> platform.
>>>>>=20
>>>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using =
ldrd
>>>>> instruction.
>>>>>=20
>>>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR=
 =3D
>>>>> 0x9200000c.
>>>>>=20
>>>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>>>=20
>>>>> The proposed solution is to use two sys_read32() on GICR_TYPER to ret=
urn the
>>>>> lower and upper 32 bits.
>>>>>=20
>>>>> With this, HSR =3D 0x9383 000c, ISV=3D1 so ISS is valid.
>>>> Hi all,
>>>> I wanted to take a step back on this issue before we jump into the
>>>> details.
>>>> Differently from other instructions we discussed in the past, strd and=
 ldrd
>>>> are not deprecated and are not "unusual corner cases". There is no
>>>> statements such as "please don't use this" on the ARM ARM. If I were t=
o
>>>> write an register read/write function in assembly for an RTOS, it woul=
d
>>>> be reasonable to use them.
>>>=20
>>> Just to be clear it is fine to use the ldrd/strd for accessing non MMIO=
 area. The problem comes with MMIO access because they can be emulated by t=
he hypervisor and we don't have the syndrome. At the moment, this is only a=
 problem when accessing some of the GICv3 (including ITS) registers.
>>>=20
>>>> So, I struggle to see how we'll be able to deal with all the possible
>>>> RTOSes out there that might have them in the code. We can fix Zephyr,
>>>> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
>>>> etc.)?
>>>=20
>>> This is not an Xen issue but architecture issue. The RTOSes will face t=
he exact same issue on any hypervisors unless they decided to decode the in=
struction.
>>>=20
>>> As we discussed before decoding an instruction correctly is quite diffi=
cult to do (what we have in Xen for pos-increment store/load is just a band=
-aid). So I would expect the other hypervisors to have made the decision to=
 not implement it. AFAIK KVM doesn't suppor them,
>>> Note that looking at ID_ISAR2, it seems that ldrd/strd is technically o=
ptional. Therefore, the RTOS would have to assume it is targeting a process=
or that supports them.
>>>=20
>>>> Unless we can get ARM to issue a clear guidance that strd and ldrd are
>>>> deprecated,
>>>=20
>>> Arm Arm cannot say that because ldrd/strd are necessary to modify the L=
PAE page-tables atomically. What we need to know is which instructions can =
be allowed on MMIO accesses.
>> Definitely this is something that arm arm cannot fully answer as it is a=
lso down to the full platform. MMIO accesses are going out of the CPU and h=
ence wether or not 64bit MMIO accesses can be properly done might also depe=
nd on the bus or the IP on the other side (some peripherals might just refu=
se 64bit accesses or some bus might only be 32bit so the operations would n=
eed to be divided).
>>>=20
>>> I think I already raised that when Ayan added decoding for post-increme=
nt instructions. There are plenty of instructions (or combinations) that do=
esn't provide a syndrome and yet the processor doesn't prevent anyone to us=
e them on MMIO.
>>>=20
>>> I was worry we are going to have to continue to decode instructions in =
a non-compliant way in Xen just to please a few RTOs that may not even run =
anywhere else.
>>>=20
>>> This would also reduce our leverage to request a change in the RTOes or=
 the Arm Arm (maybe there is already a statement I haven't spotted) because=
 Xen will already (badly) support the instruction.
>> Going back on the ID_ISAR2, if Xen is properly setting the value seen by=
 the guests, there is not reason for us to actually emulate those instructi=
ons.
>> The emulation code inside Xen cost a lot in matter of lines of code and =
would need a lot of testing (which is missing at the moment).
>> So as we have a standard way to inform the guest that this is not suppor=
ted, we should stick to that.
>=20
> Thanks for the feedback. AFAIU, the bit in ID_ISAR2 indicates whether ldr=
d/strd is present. If we decide to clear the bit, then it would mean the gu=
est should not use them even when modifying LPAE page-tables.
>=20
> This could be a problem because AFAIK those instructions are necessary to=
 modify the page-tables atomically. Therefore, I don't Xen should clear the=
 bit.

Agree

>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 10:03:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 10:03:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424289.671599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMxQ-0006KR-D7; Mon, 17 Oct 2022 10:02:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424289.671599; Mon, 17 Oct 2022 10:02:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okMxQ-0006KK-AE; Mon, 17 Oct 2022 10:02:52 +0000
Received: by outflank-mailman (input) for mailman id 424289;
 Mon, 17 Oct 2022 10:02:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okMxP-0006KA-N3; Mon, 17 Oct 2022 10:02:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okMxP-0004Aa-Jj; Mon, 17 Oct 2022 10:02:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okMxP-0002Vu-2G; Mon, 17 Oct 2022 10:02:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okMxP-0000rQ-1l; Mon, 17 Oct 2022 10:02:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jvvwvTEtc68edz0Ji7d+5zY1luvRdSoZ1DICstFMRSQ=; b=dqRWYdVSYrwYJYDsbUuW8n7wuv
	zK3FpWVOV3jJrNlhw+0QilOcsBsgYArii4w6aaU0/If5PYz5lFnhNOpKwfYIYi08RhPLo22Uj6Kh2
	zNk0lFV/5+LTrIEyzbqyDFUbIm+Q4JE3P5MDDgqq7csZ1jSJTCaHVCVtiRrRpI8c+tpA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173904-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173904: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 10:02:51 +0000

flight 173904 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173904/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-raw   7 xen-install                fail pass in 173782

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 173782 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   62 days
Failing since        173494  2022-10-11 13:38:08 Z    5 days    8 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    4 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 10:11:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 10:11:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424299.671613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okN5R-0007sH-Bb; Mon, 17 Oct 2022 10:11:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424299.671613; Mon, 17 Oct 2022 10:11:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okN5R-0007sA-8w; Mon, 17 Oct 2022 10:11:09 +0000
Received: by outflank-mailman (input) for mailman id 424299;
 Mon, 17 Oct 2022 10:11:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okN5P-0007s0-QT; Mon, 17 Oct 2022 10:11:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okN5P-0004I2-Pd; Mon, 17 Oct 2022 10:11:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okN5P-0002m4-8m; Mon, 17 Oct 2022 10:11:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okN5P-0005Oe-8G; Mon, 17 Oct 2022 10:11:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BggJXCiTOpRtLIRFNPZtOEevUIUDYTy4ndzj3ypfxP8=; b=jFWpN1HzFuvFAVzlC6mNUtaEQw
	LhAYhmRop7KHUsByrkACNwVMBDWc/Cl88LGhdg6f7vv630qoaOBMH5f17UAb4X3vdMkP5mggBtdbE
	OZxoj0uMm74ejg3kgV10JhvWqbiDEXlaCqIUigv3hr6B+wFlgu5cGFS6JWvr+HypJMyU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173982-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 173982: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=9d6915ca91519271a79bc6190a31f0af89e339b2
X-Osstest-Versions-That:
    ovmf=d618fe05bf93a8884619e9362bfc5636da55e347
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 10:11:07 +0000

flight 173982 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173982/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 9d6915ca91519271a79bc6190a31f0af89e339b2
baseline version:
 ovmf                 d618fe05bf93a8884619e9362bfc5636da55e347

Last test of basis   173896  2022-10-16 04:41:26 Z    1 days
Testing same since   173982  2022-10-17 08:12:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dun Tan <dun.tan@intel.com>
  Jason Lou <yun.lou@intel.com>
  Liu, Zhiguang <Zhiguang.Liu@intel.com>
  Tan, Dun <dun.tan@intel.com>
  Zhiguang Liu <zhiguang.liu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   d618fe05bf..9d6915ca91  9d6915ca91519271a79bc6190a31f0af89e339b2 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 10:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 10:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424308.671627 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNGJ-000103-EY; Mon, 17 Oct 2022 10:22:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424308.671627; Mon, 17 Oct 2022 10:22:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNGJ-0000zw-Bi; Mon, 17 Oct 2022 10:22:23 +0000
Received: by outflank-mailman (input) for mailman id 424308;
 Mon, 17 Oct 2022 10:22:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CpyK=2S=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okNGI-0000zq-8j
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 10:22:22 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2060.outbound.protection.outlook.com [40.107.105.60])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94f17010-4e05-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 12:22:20 +0200 (CEST)
Received: from DB6PR07CA0115.eurprd07.prod.outlook.com (2603:10a6:6:2c::29) by
 GV1PR08MB7780.eurprd08.prod.outlook.com (2603:10a6:150:58::6) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.26; Mon, 17 Oct 2022 10:22:17 +0000
Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2c::4) by DB6PR07CA0115.outlook.office365.com
 (2603:10a6:6:2c::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.11 via Frontend
 Transport; Mon, 17 Oct 2022 10:22:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 17 Oct 2022 10:22:16 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Mon, 17 Oct 2022 10:22:16 +0000
Received: from 9d2546b8ec30.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 43940249-2CA7-41FC-B8EF-42E569EA5667.1; 
 Mon, 17 Oct 2022 10:22:07 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9d2546b8ec30.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 10:22:07 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by GV1PR08MB8716.eurprd08.prod.outlook.com (2603:10a6:150:86::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 10:22:03 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 10:22:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94f17010-4e05-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OvptQdfGkKraWNrlZhJ/fiEmO61vU/LK6lvcO9y7/KFO9A6e36+CRMjPgHImIplmtuw+wls9qTiEBn4JajBR5/lwYdjMqddaowWN8LYyLOI8PHGKottDz3hslweHBhBLriaDhGCFbCMczJgtbRR5gYbw+nFxfEjh5lOfjBETm5XLwndWB1V1N60hBIwCPc+43N+nLp4EH0sIcRDpqRhORyVY8OmTI7SxKCni5OAOs5HgH6RVCZ1RJ1RG/XzKq3482EJM63qLh3GDwIfWUEPLqPtLd7qda7TtneVoQa60tpmeX6mERpjczrPpfa459kWuqMBlSKA72SaRLV88h60hDA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EjgYRXZ2eKw7mJKiP/3t7P0aktt7VzvirkBLOefd5jw=;
 b=jilwzIfBUOvvy/WTnyaL9x40njGcEIQcrZSyJrlcs0/2BdP54p4c2+k2RQqqgLG14ZVUABtfOtleTQLyObUc0XTWLY1BQ9c0m13OWS5bs210Fsi92upJmaOIybuXAei5B3HOdnEtIa9WUIYiISUaIroSZcaQzq7G1g6SbNdrN3wv330rrVM1jaVGeoBe5d5lenjHR6/qNxq17hhe6ZHiHOsKCgXWgZYmiUsyyMXpB6g6Rg+QWp0EJr+soFwrNeAtBRUiJSuvpHUt2PFB3tUHSaf/eS98dCFR5cMa/TQ0DdXEtYKtlrN0jHZULVPYIc04XtOtAWiDnzzHp5HZjKqpaQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EjgYRXZ2eKw7mJKiP/3t7P0aktt7VzvirkBLOefd5jw=;
 b=h5OvBpxCnVUMU8GklUB09GQjnEMwRQzbdWi8dqZ08BSgFQyEFTwW6eA9wf4SMeyHvBLoiySZyOI4Dr6AnvATu1w+3K7iqFPwQPPynOT9V4K4jhrfeyVMh6HS7RxDd63RhchWTw2iL1YJLIX4QzUAMEJumeGgZoZiYEBCehnuEBY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5f840a435bc7d5e9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gQEWCpgF5cW2G2mwzVfC1DE5xb88/cTeuV4/WB4ekR7Hm2J3TCD0F07OAnj6nco+LJXzW+gmbnilEoF5ImvPSZyeqjYKfQ/wzY3XlVl11aRneHgKYEebmnBbK+daBcbF5quOAYkhlQjDE1XVCbBIeWNTXEH/GRAhsqBQqJm4H2n6/eBaT+i/90gBdGvqFok3BuwE3j4a1usy88iVZAvAHNdoTHJUpvtaZzX37g+Edv/lcR145B8CZrjZyan4uTQkrbFpMUiE6xpvh7IdQe08ewt1lr9Z5rVjUV0aCjxd7NrfYhzgdzjft7Sf2oNj9xRPF1As2PMh9RF5UFsTp3qt2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EjgYRXZ2eKw7mJKiP/3t7P0aktt7VzvirkBLOefd5jw=;
 b=jB3h/nYQJ214P4lYF7JLXMKC2OqiPPqixDVUF3Ek/o2y/MqBb3xAtlL7zirHCijW5u0ZklXrVjMYPzor+54yckFjpI7E5c8fYeM9+lVQq/GzoTxzCYPBtfeQzE9UUBg2zHRK5AMVcHve9Zj7sfX/SDJrSC80ph2lqBsTbfhJC5PVc00tMwxWtztwKcKQOP1qAv6/vadguIwqiyj504a+ov1tCC4+mUf8+sB8eKd4fFlU5DFP2SaiQ5RqNDHlqnwxzHh7AZKsevh7z4EuGGz0+Y4gVLedA18xsMiXa91IspUA2fAhTWlEZiRI+0J9vH8VKKfeja2/pihw6bRh4lPduA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EjgYRXZ2eKw7mJKiP/3t7P0aktt7VzvirkBLOefd5jw=;
 b=h5OvBpxCnVUMU8GklUB09GQjnEMwRQzbdWi8dqZ08BSgFQyEFTwW6eA9wf4SMeyHvBLoiySZyOI4Dr6AnvATu1w+3K7iqFPwQPPynOT9V4K4jhrfeyVMh6HS7RxDd63RhchWTw2iL1YJLIX4QzUAMEJumeGgZoZiYEBCehnuEBY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Ayan Kumar Halder
	<ayankuma@amd.com>, "Stabellini, Stefano" <stefano.stabellini@amd.com>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, Henry Wang
	<Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, Jaxson Han
	<Jaxson.Han@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Topic: Need guidance to support reading GICR_TYPER (64 bit register) on
 Aarch32_v8r
Thread-Index: AQHY3vmtdKYr9F2nyUuznJvSQYcvHq4OMlaAgAEAmYCAAyG8AIAAEfiA
Date: Mon, 17 Oct 2022 10:22:02 +0000
Message-ID: <6D2FD203-04D9-4CDD-B57D-E90F5BC5CC3A@arm.com>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com>
 <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop>
 <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org>
 <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
In-Reply-To: <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|GV1PR08MB8716:EE_|DBAEUR03FT058:EE_|GV1PR08MB7780:EE_
X-MS-Office365-Filtering-Correlation-Id: d7fb464a-0c28-4cdb-38fe-08dab0297761
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9mYf0PCzMCBH3AOMGf7atIRK96jm05Ej3Y0KNtdFpBdvhlVRSHVtrquNt/ZcXrhaUM/67yi18jSxNx3iWxhd6nLC55YboQJ+pUUqw/cYKvyYSNyRh2DxYA++hCbVwv7JAp0PFPtORG33G3qpnSxRuESHVk1btaLKKtPP96uthmsXcHa23yamBcC9ienNDJWlFI7sTtzA83A55mHDG3VLoS9QpzRq12HuxrPGJmJT0pBOZPhJJQsi4DkygbssQATqEBmgP4hD3LfwewveJtEUaOeCnDGLxyuWQP8k4b1JCzNBRbxSPqtW1oo6twKoXrJjuAiAwRTwyVC8cEos4c0H9HAqc+ba/oubublrTk6DkBfwy2Je28bWkPgXHQP5kgXVqR7HtupPco78fz5PdyKwUgrKQnIYdVeNYM0uyOkftIANmDh1WVH3/TqgkmoV62st/E908aaepSA7bN4qaPgbx9AtszmqG4Z8D8FweB5XDRwY04d6imyBencxReyN9AjHHRr/AQUaW9sp/PklSPp7Oj0WBVpcZ19DSGuII3mxTFcJ9X8/VMRuj3taRS9dWjQsNYWIbBMhyJp7aTOlNuKmn39yQ2eMAS+dvvqF4vx/grhTFcsf5oRMr6d7pOEWV13erDr4XglyXMuVydLsuRi138P2/mv43nIHgCyRLHpY3cMjBKWdxGyrqhkVoY4R0iWzfEWLpvE5rxW3r+UDVERx6m+76M1LFg11JSkpsNNkL9V/JNY4M+WM4agsMaZGW+Koy6Pc7LvNlb0W4J5qlFcymJXZ9zzAFWnKu2okju9gKN+k/p3hBVxV8FP16yFxj8EYfgVPsflDUEqWZGSDQzL77Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(451199015)(38100700002)(122000001)(66899015)(71200400001)(38070700005)(966005)(6486002)(478600001)(54906003)(6916009)(36756003)(6506007)(41300700001)(186003)(2906002)(53546011)(2616005)(316002)(64756008)(66446008)(66476007)(8676002)(4326008)(86362001)(76116006)(66946007)(66556008)(91956017)(8936002)(6512007)(33656002)(26005)(5660300002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D7787E83003DA741B5B5F5F561C95979@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8716
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	de71c839-0e7e-4d4d-c42b-08dab0296e84
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4kzR/UP4g+enp+67XdrQ0xRBztjbgjyBbeKn/YNNZRaBYMdV4YN2ZUrwYW2LanEyCoz8tak+VQX3B74QuZzj805TPNGt4SxLPf1QlBC1mkd+mtRU5fy3qeNnTL2251XbaFqv6scVdxE1+8B38pXBLiE/8qBZEmc0j12dBJq/at2w0Zlr6sbLQfmHjzZv2tZ8++lzNROUv446VzkJYot9ExetAMKpw9XWQlyA01ahZ+k3KiLQ1EHRlmKnX9cztz9uTYlt6KYnBTaTDSqY8bNNg/ax1Jjg4R7DPF4KpxGFGi7Hvi7idqbWrrD5OrMUzouwYZYTfsJq2rhGPOY+ZiT+L6P3sw8RAhKBE0P9ZZkp8nzw5Oc6mUpR8caoPvQy70WBghBhfOQaHxz3JY1KSG5j57WHdpfuRQR2PNCUUycmUNUGKp78sJmKRTUg5bTrrOjjv+R7zbxqZKYmsriof5l423Gm5L+FIi5/g8GRryBZp/d30dhIMvCBUHWi9MN2AQZQwNicLViURiZzNWFExzhyRSrYDwZFIb4y24MFudvDWidG8Z1ELox18fxpi2lPPhhVgU4hXMo1ER/3A8lbC405YIFO3h5WgzW56Dy2lA/U86DlaJ13Nwma5p5njVEqMpu4PL3CcxjGWMBT0wC4TqAWURT1CBaHOqIsYpZmQgwzu0nGE/uOx6iNRMjNl/7w8Cu6bvouVB+37JUiE2Rk1Tx9vf/9yB8MYtHlWO9oGmBZIDT3lvWBHyTGE7LoRJ3OKnTGCefhbc/SICIyYzx19fUaG8bwG/HXdyo+XMY6mD+x47c=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(40470700004)(36840700001)(46966006)(6486002)(478600001)(6506007)(33656002)(41300700001)(966005)(8936002)(316002)(54906003)(8676002)(4326008)(36756003)(6862004)(36860700001)(40480700001)(356005)(81166007)(82740400003)(2616005)(86362001)(336012)(82310400005)(40460700003)(70586007)(26005)(6512007)(83380400001)(2906002)(47076005)(186003)(53546011)(70206006)(66899015)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 10:22:16.9354
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d7fb464a-0c28-4cdb-38fe-08dab0297761
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7780

Hi,

> On 17 Oct 2022, at 10:17, Bertrand Marquis <Bertrand.Marquis@arm.com> wro=
te:
>=20
> Hi,
>=20
>> On 15 Oct 2022, at 10:28, Julien Grall <julien@xen.org> wrote:
>>=20
>> Hi Stefano,
>>=20
>> On 14/10/2022 19:09, Stefano Stabellini wrote:
>>> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
>>>> Hi Arm mantainers/Folks,
>>>>=20
>>>> Please refer to the discussion
>>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
>>>>=20
>>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed vi=
rtual
>>>> platform.
>>>>=20
>>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using l=
drd
>>>> instruction.
>>>>=20
>>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
=3D
>>>> 0x9200000c.
>>>>=20
>>>> As ISV is 0, so Xen cannot emulate this instruction.
>>>>=20
>>>> The proposed solution is to use two sys_read32() on GICR_TYPER to retu=
rn the
>>>> lower and upper 32 bits.
>>>>=20
>>>> With this, HSR =3D 0x9383 000c, ISV=3D1 so ISS is valid.
>>> Hi all,
>>> I wanted to take a step back on this issue before we jump into the
>>> details.
>>> Differently from other instructions we discussed in the past, strd and =
ldrd
>>> are not deprecated and are not "unusual corner cases". There is no
>>> statements such as "please don't use this" on the ARM ARM. If I were to
>>> write an register read/write function in assembly for an RTOS, it would
>>> be reasonable to use them.
>>=20
>> Just to be clear it is fine to use the ldrd/strd for accessing non MMIO =
area. The problem comes with MMIO access because they can be emulated by th=
e hypervisor and we don't have the syndrome. At the moment, this is only a =
problem when accessing some of the GICv3 (including ITS) registers.
>>=20
>>> So, I struggle to see how we'll be able to deal with all the possible
>>> RTOSes out there that might have them in the code. We can fix Zephyr,
>>> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
>>> etc.)?
>>=20
>> This is not an Xen issue but architecture issue. The RTOSes will face th=
e exact same issue on any hypervisors unless they decided to decode the ins=
truction.
>>=20
>> As we discussed before decoding an instruction correctly is quite diffic=
ult to do (what we have in Xen for pos-increment store/load is just a band-=
aid). So I would expect the other hypervisors to have made the decision to =
not implement it. AFAIK KVM doesn't suppor them,
>> Note that looking at ID_ISAR2, it seems that ldrd/strd is technically op=
tional. Therefore, the RTOS would have to assume it is targeting a processo=
r that supports them.
>>=20
>>> Unless we can get ARM to issue a clear guidance that strd and ldrd are
>>> deprecated,=20
>>=20
>> Arm Arm cannot say that because ldrd/strd are necessary to modify the LP=
AE page-tables atomically. What we need to know is which instructions can b=
e allowed on MMIO accesses.
>=20
> Definitely this is something that arm arm cannot fully answer as it is al=
so down to the full platform. MMIO accesses are going out of the CPU and he=
nce wether or not 64bit MMIO accesses can be properly done might also depen=
d on the bus or the IP on the other side (some peripherals might just refus=
e 64bit accesses or some bus might only be 32bit so the operations would ne=
ed to be divided).
>=20
>>=20
>> I think I already raised that when Ayan added decoding for post-incremen=
t instructions. There are plenty of instructions (or combinations) that doe=
sn't provide a syndrome and yet the processor doesn't prevent anyone to use=
 them on MMIO.
>>=20
>> I was worry we are going to have to continue to decode instructions in a=
 non-compliant way in Xen just to please a few RTOs that may not even run a=
nywhere else.
>>=20
>> This would also reduce our leverage to request a change in the RTOes or =
the Arm Arm (maybe there is already a statement I haven't spotted) because =
Xen will already (badly) support the instruction.
>=20
> Going back on the ID_ISAR2, if Xen is properly setting the value seen by =
the guests, there is not reason for us to actually emulate those instructio=
ns.
> The emulation code inside Xen cost a lot in matter of lines of code and w=
ould need a lot of testing (which is missing at the moment).
> So as we have a standard way to inform the guest that this is not support=
ed, we should stick to that.
>=20
>>=20
>>> I think it would be better to attempt to decode them rather
>>> than just fail. I don't like to have this kind of code in Xen, but I
>>> don't see a way to support R52s without it.
>> That's not specific to R52. This is anyone using GICv3 on Arm32 core.
>=20
> Agree.
>=20
>>=20
>>> That said, of course if Zephyr was to use two 32-bit reads instead of
>>> one 64-bit read, it would be better for Xen. And we have more important
>>> things to deal with right now in terms of R52 support (it is not even
>>> upstream yet). So it is totally fine to change Zephyr and move forward
>>> for now.
>>> But medium term it doesn't seem to me that we can get away without a
>>> solution in Xen for this (or a change in the ARM ARM).
>>=20
>> See above. This is an architecture problem and we should discuss with Ar=
m first before continuing to add more decoding in Xen.
>=20
> I will discuss it internally to have an answer but I think that the answe=
r cannot only come from Arm as there are for sure hardware implementations =
that cannot support this, as explain before.

I had some discussions internally and here is the official view:

>From the architecture point of view this should always work but this is not=
 virtualisable (as there is no syndrome register) and not recommended as de=
ferencing a pointer accessing MMIO registers is not safe, so it should not =
be done for MMIO.

Linux is not doing those kind of accesses and KVM does not support guest do=
ing them.

So I think we should not try to emulate this.

Cheers
Bertrand


>=20
> Cheers
> Bertrand
>=20
>>=20
>> Cheers,
>>=20
>> --=20
>> Julien Grall



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 10:34:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 10:34:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424314.671638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNRr-0002W2-Ge; Mon, 17 Oct 2022 10:34:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424314.671638; Mon, 17 Oct 2022 10:34:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNRr-0002Vv-Cs; Mon, 17 Oct 2022 10:34:19 +0000
Received: by outflank-mailman (input) for mailman id 424314;
 Mon, 17 Oct 2022 10:34:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JD8j=2S=citrix.com=prvs=282fc9ee0=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1okNRp-0002Vp-FO
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 10:34:17 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3e8addec-4e07-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 12:34:15 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e8addec-4e07-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666002855;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=zuRl5uDWWEC+LzOlFFzqCUms5TW9MwdybAmeZKgC3pM=;
  b=A/Y3LYeanDJ0NUkOKm8lDuuo+GJM2C9gxTEJhrZLuvEWk/ius4xRFSxS
   t8i+T+R+Qc/aPLw5nw70XKp19zrzt4uzsWU2pq4LfB6xeNxynQONF4cpC
   UCu0dlhSKINpa1coeEVw2PQ7YggRxDhV1pnUNoej/jY9P9re29mVarzmb
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 81995746
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nILxCqB97j/FFRVW/yLjw5YqxClBgxIJ4kV8jS/XYbTApGgi1DVSm
 mIcCD+BOfyKZjH0L9FzPoyzoxsEu5eGy9RkQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2t4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2ksP4YH2dctHVhS9
 PwkLjsHcjCNrOCflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN
 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oi0YYuIJYDULSlTtnrE+
 VjF4TTTPg4XLYy1yAW03E+GpuCayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRqkO4QcMZF
 EUS9QInt610/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj
 AbPxo63Q2w02FGIdZ6D3q2WpiyRCHIJFHMDZRMCRgEZw9fIoqhm23ojUe1fOKKyi9T0HxT5z
 DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip
 zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1Q/HNFBz3oRZPmLy8BxknfS9U3j4sI2OBX
 aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CK6JP4YTP8YtKFLblM2LWaJ39zm3+HXAbIllY
 cvLGSpSJSxy5VtbIMqeGL5GjO5DKtEWzmLPX5HrpymaPU6lTCfNE98taQLWBshgtfPsnekg2
 4sGXyd8404EC7OWj+i+2dN7EG3m2lBhXs6p85UJLb7SSuekcUl4Y8LsLXoaU9QNt8xoei3gp
 xlRhmcwJILDuED6
IronPort-HdrOrdr: A9a23:Ww4ngK1FKhXIRgRgS+/OIwqjBL4kLtp133Aq2lEZdPRUGvb3qy
 nIpoV+6faUskd2ZJhOo7C90cW7LU80lqQFhLX5X43SPzUO0VHAROoJgLcKqweQfBEWndQ96U
 4PScdD4aXLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.95,191,1661832000"; 
   d="scan'208";a="81995746"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Anthony PERARD <anthony.perard@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH for-4.17] tools: Workaround wrong use of tools/Rules.mk by qemu-trad
Date: Mon, 17 Oct 2022 11:34:03 +0100
Message-ID: <20221017103403.63218-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

qemu-trad build system, when built from xen.git, will make use of
Rules.mk (setup via qemu-trad.git/xen-setup). This mean that changes
to Rules.mk will have an impact our ability to build qemu-trad.

Recent commit e4f5949c4466 ("tools: Add -Werror by default to all
tools/") have added "-Werror" to the CFLAGS and qemu-trad start to use
it. But this fails and there's lots of warning that are now turned
into error.

We should teach qemu-trad and xen.git to not have to use Rules.mk when
building qemu-trad, but for now, avoid adding -Werror to CFLAGS when
building qemu-trad.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    for 4.17:
        - fix the build, as detected by the push-gate

 tools/Makefile | 1 +
 tools/Rules.mk | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/tools/Makefile b/tools/Makefile
index 0c1d8b64a4..9e28027835 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -159,6 +159,7 @@ qemu-traditional-recurse = \
 	set -e; \
 		$(buildmakevars2shellvars); \
 		export CONFIG_BLKTAP1=n; \
+		export BUILDING_QEMU_TRAD=y; \
 		cd qemu-xen-traditional-dir; \
 		$(1)
 
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 34d495fff7..6e135387bd 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -141,9 +141,12 @@ endif
 
 CFLAGS_libxenlight += $(CFLAGS_libxenctrl)
 
+# Don't add -Werror if we are used by qemu-trad build system.
+ifndef BUILDING_QEMU_TRAD
 ifeq ($(CONFIG_WERROR),y)
 CFLAGS += -Werror
 endif
+endif
 
 ifeq ($(debug),y)
 # Use -Og if available, -O0 otherwise
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 10:41:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 10:41:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424319.671649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNYR-0003z5-A2; Mon, 17 Oct 2022 10:41:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424319.671649; Mon, 17 Oct 2022 10:41:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNYR-0003yy-6W; Mon, 17 Oct 2022 10:41:07 +0000
Received: by outflank-mailman (input) for mailman id 424319;
 Mon, 17 Oct 2022 10:35:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4hsD=2S=gmail.com=liu.denton@srs-se1.protection.inumbo.net>)
 id 1okNTI-00036Z-SE
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 10:35:48 +0000
Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com
 [2607:f8b0:4864:20::636])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 75cd54d1-4e07-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 12:35:47 +0200 (CEST)
Received: by mail-pl1-x636.google.com with SMTP id c24so10369549pls.9
 for <xen-devel@lists.xenproject.org>; Mon, 17 Oct 2022 03:35:47 -0700 (PDT)
Received: from archbookpro.localdomain (136-25-1-99.cab.webpass.net.
 [136.25.1.99]) by smtp.gmail.com with ESMTPSA id
 c21-20020a63da15000000b00439c6a4e1ccsm5864885pgh.62.2022.10.17.03.35.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 17 Oct 2022 03:35:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75cd54d1-4e07-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=eUNXt67D6mOAKVzyM5X4gMewzqvBTPXGcDZl2PRJvi4=;
        b=YqDLgnOutaiweFaxkHAjSMA4pjWCgikLi6H52TBohM5oHCA+jVZ39tv6btQxf+M9J4
         UH+Pu4/wxIMrmFcUWhAUZar4DwXrhE1hsyRv+hqu3lBSyLI3aXZz+sfuP9peMsMHVMtY
         XkZxoSRz34SD9sPKn+SKFxfrX+84Lo3IV8CyJdfIdQ/AfuR2Q/btTq8kcQoMWs3CZlqj
         uam1819Y6sxBhHm5x/2Uoc9C7bFwDfkXYX0+Apt2pv4lxgKXgfpQ25QJRN81RK6xRYkb
         4wuitv0R7XeQr1ahcAex7w3HJFiPjtmwcmV9zHXCIbsC7Pb0MWabE+XvNbK11IMThpTV
         fUUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=eUNXt67D6mOAKVzyM5X4gMewzqvBTPXGcDZl2PRJvi4=;
        b=Hs41ZEKYIAQT6MsOKCmKn3Vl/DPwLs4UUHIAJPF60m2XudiTCc0faRR8/7ICCPfpKw
         qhjQ3mv1yTRN2pi9ooBu7hFAvoxpM1oS0pFiW1/fhvBJZYZdJo3IIg7YOYXeisPZKkaI
         3b4zBRWNVuBXiZD/CQjeKKIhHW2Y1rT8qDASnPHyqlaHE/WP1PRXjA5M2nv99+4GKrwl
         34C6o+AKd3NNWhSGEnXFWq12mhxCy7a1SmcdJLG8/y9rhz7eGbHDj9COmGjyUrRWfL7a
         woBt9LbBIbGq/Mkrx8J+hAnVq+brcapkL3mJ4B3eKvzJy4gscjV+VkjLHKS8ZikknBy9
         Hgpw==
X-Gm-Message-State: ACrzQf1WaSXX5w8FnJOF9w9rkNt4S6DNLuTjhqiJ8CSBqAwxZb6Jh2hl
	bw1y1xtpy5EHmrPJlsIDjQA=
X-Google-Smtp-Source: AMsMyM45QIYyKq57hAG1FUqfvWbRo3Uxgf6U3aZchyEUhSe8Ng24GPE+JA3s1PajCC1AuB5QfroOZg==
X-Received: by 2002:a17:902:e848:b0:180:c732:1e52 with SMTP id t8-20020a170902e84800b00180c7321e52mr11554957plg.83.1666002945778;
        Mon, 17 Oct 2022 03:35:45 -0700 (PDT)
From: Denton Liu <liu.denton@gmail.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com,
	rharwood@redhat.com,
	samuel.thibault@ens-lyon.org,
	debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org
Subject: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Date: Mon, 17 Oct 2022 03:35:32 -0700
Message-Id: <20221017103532.845293-1-liu.denton@gmail.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A user may wish to use an image that is not sorted as the "latest"
version as the top-level entry. For example, in Arch Linux, if a user
has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts`
gets sorted as the "latest" compared to `/boot/vmlinuz-linux`. However,
a user may wish to use the regular kernel as the default with the LTS
only existing as a backup.

Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
top-level entry.

Create grub_move_to_front() as a helper function which moves entries to
the front of a list. This function does the heavy lifting of moving
the menu entry to the front in each script.

In 10_netbsd, since there isn't an explicit list variable, extract the
items that are being iterated through into a list so that we can
optionally apply grub_move_to_front() to the list before the loop.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---

Notes:
    The only file that was tested is 10_linux. I do not have access to any
    of the other images or systems so they remain untested.
    
    Changes since v3:
    
    * Fix if formatting nit
    
    * Rebase on top of latest 'master'
    
    Changes since v2:
    
    * Added more detail to GRUB_TOP_LEVEL docs
    
    * Moved GRUB_TOP_LEVEL_OS_PROBER to separate section in docs
    
    * Renamed grub_move_entry_to_front() to grub_move_to_front() and added
      code comment
    
    * Give 10_netbsd an intermediate list of images to interact with

Range-diff against v3:
1:  3684d8fe2 ! 1:  d3a693804 templates: introduce GRUB_TOP_LEVEL_* vars
    @@ Notes
         The only file that was tested is 10_linux. I do not have access to any
         of the other images or systems so they remain untested.
     
    +    Changes since v3:
    +
    +    * Fix if formatting nit
    +
    +    * Rebase on top of latest 'master'
    +
         Changes since v2:
     
         * Added more detail to GRUB_TOP_LEVEL docs
    @@ util/grub-mkconfig_lib.in: version_sort ()
     +    echo "$item"
     +  fi
     +  for i in "$@"; do
    -+    if [ "x$i" = "x$item" ]; then continue; fi
    ++    if [ "x$i" = "x$item" ]; then
    ++      continue
    ++    fi
     +    echo "$i"
     +  done
     +}

 docs/grub.texi              | 10 ++++++++++
 util/grub-mkconfig.in       |  3 +++
 util/grub-mkconfig_lib.in   | 26 ++++++++++++++++++++++++++
 util/grub.d/10_hurd.in      |  4 ++++
 util/grub.d/10_kfreebsd.in  |  4 ++++
 util/grub.d/10_linux.in     |  4 ++++
 util/grub.d/10_netbsd.in    |  8 +++++++-
 util/grub.d/20_linux_xen.in |  7 +++++++
 util/grub.d/30_os-prober.in |  4 ++++
 9 files changed, 69 insertions(+), 1 deletion(-)

diff --git a/docs/grub.texi b/docs/grub.texi
index 0dbbdc374..5d41219ac 100644
--- a/docs/grub.texi
+++ b/docs/grub.texi
@@ -1444,6 +1444,16 @@ for all respectively normal entries.
 The values of these options replace the values of @samp{GRUB_CMDLINE_LINUX}
 and @samp{GRUB_CMDLINE_LINUX_DEFAULT} for Linux and Xen menu entries.
 
+@item GRUB_TOP_LEVEL
+@item GRUB_TOP_LEVEL_XEN
+This option should be a path to a kernel image. If provided, the image
+specified will be made the top-level entry if it is found in the scan.
+
+@item GRUB_TOP_LEVEL_OS_PROBER
+This option should be a line of output from @command{os-prober}. As
+@samp{GRUB_TOP_LEVEL}, if provided, the image specified will be made the
+top-level entry if it is found in the scan.
+
 @item GRUB_EARLY_INITRD_LINUX_CUSTOM
 @itemx GRUB_EARLY_INITRD_LINUX_STOCK
 List of space-separated early initrd images to be loaded from @samp{/boot}.
diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
index 62335d027..32c480dae 100644
--- a/util/grub-mkconfig.in
+++ b/util/grub-mkconfig.in
@@ -233,6 +233,9 @@ export GRUB_DEFAULT \
   GRUB_CMDLINE_NETBSD \
   GRUB_CMDLINE_NETBSD_DEFAULT \
   GRUB_CMDLINE_GNUMACH \
+  GRUB_TOP_LEVEL \
+  GRUB_TOP_LEVEL_XEN \
+  GRUB_TOP_LEVEL_OS_PROBER \
   GRUB_EARLY_INITRD_LINUX_CUSTOM \
   GRUB_EARLY_INITRD_LINUX_STOCK \
   GRUB_TERMINAL_INPUT \
diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in
index 634bc8a50..08953287c 100644
--- a/util/grub-mkconfig_lib.in
+++ b/util/grub-mkconfig_lib.in
@@ -218,6 +218,32 @@ version_sort ()
    esac
 }
 
+# Given an item as the first argument and a list as the subsequent arguments,
+# returns the list with the first argument moved to the front if it exists in
+# the list.
+grub_move_to_front ()
+{
+  item="$1"
+  shift
+
+  item_found=false
+  for i in "$@"; do
+    if [ "x$i" = "x$item" ]; then
+      item_found=true
+    fi
+  done
+
+  if [ "x$item_found" = xtrue ]; then
+    echo "$item"
+  fi
+  for i in "$@"; do
+    if [ "x$i" = "x$item" ]; then
+      continue
+    fi
+    echo "$i"
+  done
+}
+
 # One layer of quotation is eaten by "" and the second by sed; so this turns
 # ' into \'.
 grub_quote () {
diff --git a/util/grub.d/10_hurd.in b/util/grub.d/10_hurd.in
index a021d02c2..b317a4b14 100644
--- a/util/grub.d/10_hurd.in
+++ b/util/grub.d/10_hurd.in
@@ -229,6 +229,10 @@ submenu_indentation=""
 
 reverse_sorted_kernels=$(echo ${kernels} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_kernels=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_kernels})
+fi
+
 is_top_level=true
 
 for kernel in ${reverse_sorted_kernels}; do
diff --git a/util/grub.d/10_kfreebsd.in b/util/grub.d/10_kfreebsd.in
index 0a67decaa..83e9636e8 100644
--- a/util/grub.d/10_kfreebsd.in
+++ b/util/grub.d/10_kfreebsd.in
@@ -164,6 +164,10 @@ submenu_indentation=""
 
 reverse_sorted_list=$(echo ${list} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_list})
+fi
+
 is_top_level=true
 
 for kfreebsd in ${reverse_sorted_list}; do
diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
index c6a1ec935..7263f2983 100644
--- a/util/grub.d/10_linux.in
+++ b/util/grub.d/10_linux.in
@@ -202,6 +202,10 @@ submenu_indentation=""
 
 reverse_sorted_list=$(echo $list | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_list})
+fi
+
 is_top_level=true
 for linux in ${reverse_sorted_list}; do
   gettext_printf "Found linux image: %s\n" "$linux" >&2
diff --git a/util/grub.d/10_netbsd.in b/util/grub.d/10_netbsd.in
index dc0cd1b17..3154e9e15 100644
--- a/util/grub.d/10_netbsd.in
+++ b/util/grub.d/10_netbsd.in
@@ -146,8 +146,14 @@ pattern="^ELF[^,]*executable.*statically linked"
 # yet, so it's empty. In a submenu it will be equal to '\t' (one tab).
 submenu_indentation=""
 
+list="/netbsd $(ls -t /netbsd?* 2>/dev/null)"
+
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${list})
+fi
+
 is_top_level=true
-for k in /netbsd $(ls -t /netbsd?* 2>/dev/null) ; do
+for k in ${list}; do
   if ! grub_file_is_not_garbage "$k" ; then
     continue
   fi
diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_linux_xen.in
index 626aed40c..386bfb9be 100644
--- a/util/grub.d/20_linux_xen.in
+++ b/util/grub.d/20_linux_xen.in
@@ -245,6 +245,13 @@ submenu_indentation=""
 reverse_sorted_xen_list=$(echo ${xen_list} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 reverse_sorted_linux_list=$(echo ${linux_list} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL_XEN" != x ]; then
+  reverse_sorted_xen_list=$(grub_move_to_front "$GRUB_TOP_LEVEL_XEN" ${reverse_sorted_xen_list})
+fi
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_linux_list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_linux_list})
+fi
+
 is_top_level=true
 
 for current_xen in ${reverse_sorted_xen_list}; do
diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in
index daa603778..656301eaf 100644
--- a/util/grub.d/30_os-prober.in
+++ b/util/grub.d/30_os-prober.in
@@ -113,6 +113,10 @@ EOF
 
 used_osprober_linux_ids=
 
+if [ "x$GRUB_TOP_LEVEL_OS_PROBER" != x ]; then
+  OSPROBED=$(grub_move_to_front "$GRUB_TOP_LEVEL_OS_PROBER" ${OSPROBED})
+fi
+
 for OS in ${OSPROBED} ; do
   DEVICE="`echo ${OS} | cut -d ':' -f 1`"
   LONGNAME="`echo ${OS} | cut -d ':' -f 2 | tr '^' ' '`"
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 10:52:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 10:52:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424329.671663 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNit-0005Zk-Eq; Mon, 17 Oct 2022 10:51:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424329.671663; Mon, 17 Oct 2022 10:51:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okNit-0005Zd-Bt; Mon, 17 Oct 2022 10:51:55 +0000
Received: by outflank-mailman (input) for mailman id 424329;
 Mon, 17 Oct 2022 10:51:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6pfM=2S=leemhuis.info=regressions@srs-se1.protection.inumbo.net>)
 id 1okNis-0005ZX-OQ
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 10:51:54 +0000
Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de
 [2a01:488:42:1000:50ed:8234::])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b5b69ef8-4e09-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 12:51:53 +0200 (CEST)
Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated
 by wp530.webpack.hosteurope.de running ExIM with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
 id 1okNin-0000rH-GA; Mon, 17 Oct 2022 12:51:49 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5b69ef8-4e09-11ed-91b4-6bf2151ebd3b
Message-ID: <402ab0ef-8bea-6210-1585-2e0e217a2e08@leemhuis.info>
Date: Mon, 17 Oct 2022 12:51:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: Bug 216581 - Kernel panic on /init as busybox symbolic link with
 xen efi
Content-Language: en-US, de-DE
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Denis Chancogne <denis.chancogne@free.fr>,
 "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
 LKML <linux-kernel@vger.kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e2cf3207-e9e9-5585-1a6e-9b39d96b4b54@leemhuis.info>
 <Y0ygiO3kuazXWSfZ@mail-itl>
From: Thorsten Leemhuis <regressions@leemhuis.info>
In-Reply-To: <Y0ygiO3kuazXWSfZ@mail-itl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1666003913;670af1f6;
X-HE-SMSGID: 1okNin-0000rH-GA

On 17.10.22 02:23, Marek Marczykowski-Górecki wrote:
> On Sun, Oct 16, 2022 at 01:08:53PM +0200, Thorsten Leemhuis wrote:

>>>  Denis Chancogne 2022-10-13 22:00:19 UTC
>>>
>>> when I start Xen 4.15.3 in efi with kernel 5.18.19, all works well;
>>> but since kernel 5.19, I have a kernel panic on my /init process as
>>> busybox symbolic link inside initramfs.
>>>
>>> This is the kernel log :
> [...]
> 
> Thanks for forwarding.
> 
> This is already fixed on the Xen side: https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=c3bd0b83ea5b7c0da6542687436042eeea1e7909
> The commit is also in 4.15 branch already:
> https://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=7923ea47e578bca30a6e45951a9da09e827ff028,
> to be included in 4.15.4 rather soon.

Hmmm. Well, strictly speaking this is still a kernel regression that
should be fixed (or worked around) on the kernel level. But 5.19 is out
for a while already and this afaics was the first report of this problem
in kernel land. Maybe it's not worth it, so let's leave everything as it
is for now, if that's okay for Denis. We IMHO will need to reconsider if
more users run into this.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

#regzbot introduced: 8ad7e8f69695
#regzbot invalid: it is a kernel regression, but one that can be worked
around by updating Xen hypervisor



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 11:42:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 11:42:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424339.671683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOVC-0002RU-7w; Mon, 17 Oct 2022 11:41:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424339.671683; Mon, 17 Oct 2022 11:41:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOVC-0002RN-4M; Mon, 17 Oct 2022 11:41:50 +0000
Received: by outflank-mailman (input) for mailman id 424339;
 Mon, 17 Oct 2022 11:41:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=stwC=2S=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1okOVA-0002RH-4q
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 11:41:48 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ad2c1344-4e10-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 13:41:47 +0200 (CEST)
Received: by mail-pj1-x1029.google.com with SMTP id
 o9-20020a17090a0a0900b0020ad4e758b3so10690883pjo.4
 for <xen-devel@lists.xenproject.org>; Mon, 17 Oct 2022 04:41:45 -0700 (PDT)
Received: from leoy-yangtze.lan (211-75-219-199.hinet-ip.hinet.net.
 [211.75.219.199]) by smtp.gmail.com with ESMTPSA id
 mn7-20020a17090b188700b00205f013f275sm9513088pjb.22.2022.10.17.04.41.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 17 Oct 2022 04:41:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad2c1344-4e10-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=EpPLAJ9p4aPiwkX3h5bt/H+fQzqZ+4hUtG4/MmuXR0M=;
        b=eY6snNuG/nvSLWZ2fcNSwF6+NaR5HG/zxAm9DobnnEp9bth8deSE3j/MmkgfnZa1u2
         G9RDMznXT9x2jKOQsflRZn8K9VVlNWJo33qAFaYgeemo4D8I0DoCBQZGCuvzALvTd30y
         +Ak22LaG9377g2GB5/Qsz2M5+o2+3AjZ/3wMfCiD45ZmudzrPMZ5e2f0F2SgIUkJYfEK
         dzel3IGks59W8N/yfk6v19CZOwntjeSxmYCG70bbUMZMLqElCNJ6ctsQXageiIcA+TP2
         atm/ZivdMLaDYilAKEjhJaAWZ3L6e6VtS6j1T8cWP5mDbZ2hDhmnRXu3LWG1lALR7Meh
         uiUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=EpPLAJ9p4aPiwkX3h5bt/H+fQzqZ+4hUtG4/MmuXR0M=;
        b=BH2bVcMNjZ/uuTB02Y0mK4nyozZ5RWv2f5qAmYKbOi3oFKurq483tJZxnYozHf1b2d
         tjpuRKwe4LSxhUwO7o2pPOJCbYuLI391OGYJ4Xnp86aThIYV3g7CYOghYu9hmHIw7IhS
         OfsnBdR721WwtiPs/HG6apd/1PpKXvHuZTwH7J+HV43lKtTCl2azou93ZPWMXViRcg6K
         R+HWaTfk2fbwN1lTqp4nhe6eYl3nfmeNGimpwyDN+OYpenk+mtnvGRTlTyPOwXZAt/1w
         UCJKfSlt3tCig1dWCflfVNoYPRE5ETor8lDciyhs6IuBboB+8cwKlj4vQtDR4Fc6cekI
         Jn6w==
X-Gm-Message-State: ACrzQf0g/WmvumxHHEBtfbGqh0/oDn4Eh8/sD/49NX3AxR70ze4+Nk/T
	CAqeOgejjv5tI2SMbcCL7Yrq9A==
X-Google-Smtp-Source: AMsMyM6nhSMINRaN8640salY6NUpARC0Tb8BaSqZUCu0+SML804xMHTu7gOpFU852VVyhHbc/FF0+Q==
X-Received: by 2002:a17:90b:4d90:b0:20d:7f17:5983 with SMTP id oj16-20020a17090b4d9000b0020d7f175983mr33351430pjb.197.1666006904121;
        Mon, 17 Oct 2022 04:41:44 -0700 (PDT)
Date: Mon, 17 Oct 2022 19:41:36 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>

Hi Stefano,

Sorry for late response.  Please see below comments.

On Tue, Oct 11, 2022 at 02:47:00PM -0700, Stefano Stabellini wrote:
> On Tue, 11 Oct 2022, Leo Yan wrote:
> > > > The second question is how to mitigate the long latency when send data
> > > > from DomU.  A possible solution is the Xen network forend driver copies
> > > > skb into mediate (bounce) buffer, just like what does in Xen net
> > > > backend driver with gnttab_batch_copy(), in this way the forend driver
> > > > doesn't need to wait for backend driver response and directly return
> > > > back.
> > > 
> > > About this, I am not super familiar with drivers/net/xen-netfront.c but
> > > I take you are referring to xennet_tx_buf_gc? Is that the function that
> > > is causing xennet_start_xmit to wait?
> > 
> > No.  We can take the whole flow in xen-netfront.c as:
> > 
> >   xennet_start_xmit()
> >              ----------> notify Xen Dom0 to process skb
> >              <---------  Dom0 copies skb and notify back to DomU
> >   xennet_tx_buf_gc()
> >   softirq/NET_TX : __kfree_skb()
> 
> Let me premise again that I am not an expert in PV netfront/netback.
> However, I think the above is only true if DomU and Dom0 are running on
> the same physical CPU. If you use sched=null as I suggested above,
> you'll get domU and dom0 running at the same time on different physical
> CPUs and the workflow doesn't work as described.
> 
> It should be:
> 
> CPU1: xennet_start_xmit()             ||  CPU2: doing something else
> CPU1: notify Xen Dom0 to process skb  ||  CPU2: receive notification
> CPU1: return from xennet_start_xmit() ||  CPU2: Dom0 copies skb
> CPU1: do something else               ||  CPU2: notify back to DomU
> CPU1: receive irq, xennet_tx_buf_gc() ||  CPU2: do something else

Yes, I agree this is ideal case.  I tried to set option "sched=null" but
I can observe the latency in the second step when CPU1 notify Xen Dom0,
Dom0 takes 500us+ to receive the notification.

Please see below detailed log:

DomU log:

4989078512              pub-321   [003]   101.150966: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 4989078512
4989078573              pub-321   [003]   101.150968: bprint:               xennet_tx_setup_grant: id=24 ref=1816 offset=2 len=1514 TSC: 4989078573
4989078592              pub-321   [003]   101.150969: bprint:               xennet_start_xmit: xennet_notify_tx_irq: TSC: 4989078592

Dom0 log:

4989092169           <idle>-0     [013]   140.121667: bprint:               xenvif_tx_interrupt: xenvif_tx_interrupt: TSC: 4989092169
4989092331           <idle>-0     [013]   140.121673: bprint:               xenvif_tx_build_gops.constprop.0: id=24 ref=1816 offset=2 len=1514 TSC: 4989092331

We can see DomU sends notification with timestamp (raw counter) is
4989078592 and Dom0 receives the interrupt with timestamp 4989092169.
Since Dom0 and DomU use the same time counter and the counter
frequency is 25MHz, so we can get the delta value (in macroseconds):

    (4989092169 - 4989078592) / 25000000 * 1000 * 1000
  = 543us

Which means it takes 543us to let Dom0 to receive the notification.
You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
not have contention for CPU resources.  Seems to me, it's likely Xen
hypervisor takes long time to deliver the interrupt, note, it's not
take so long time for every skb transferring, sometimes the time for
response a notification is short (about ~10us).

> > > I didn't think that waiting for the backend is actually required. I
> > > mean, in theory xennet_start_xmit could return without calling
> > > xennet_tx_buf_gc, it is just an optimization. But I am not sure about
> > > this.
> > 
> > The function xennet_start_xmit() will not wait and directly return
> > back, but if we review the whole flow we can see the skb is freed until
> > the softirq NET_TX.
> 
> Is it an issue that the skb is not freed until later? Is that affecting
> the latency results? It shouldn't, right?

I did an extra experiment in Xen net forend driver, I enabled the flag
"info->bounce = true" so the forend driver will use bounce buffer to
store data and release the skb immediately to network core layer.

The throughput can be boosted significantly for this: the netperf
result can be improved from 107.73 Mbits/s to 300+ Mbits/s.

> What matters is when dom0 is
> getting those packets on the physical network interface and that happens
> before the skb is freed. I am just trying to figure out if we are
> focusing on the right problem.

Good point.  I agree that releasing skb earlier only can benefit for
throughput, but we still cannot resolve the latency issue if Dom0
takes long time to relay packets to phusical network interface.

> > In this whole flow, it needs DomU and Dom0 to work
> > together (includes two context switches) to process skb.
> 
> There are not necessarily 2 context switches as things should run in
> parallel.
> 
> > Here I mean the optimization is to allow Dom0 and DomU to work in
> > parallel.  It could be something like blow, the key point is DomU
> > doesn't need to wait for Dom0's notification.
> 
> I think it is already the case that domU doesn't need to wait for dom0's
> notification?

Agree.  domU doesn't need to wait for dom0's notification until it uses
out the skb can be allocated by the network core layer.  This is why I
also can tweak core layer's parameters for buffer size (see
/proc/sys/net/core/wmem_default and /proc/sys/net/core/wmem_max).

> It is true that domU is waiting for dom0's notification to
> free the skb but that shouldn't affect latency?

Yeah.  I will focus on the elaberated issue above that Dom0 takes long
time to receive the notification.

Will keep posted if have any new finding.

Thanks,
Leo


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 11:52:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 11:52:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424345.671694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOfA-0003y7-52; Mon, 17 Oct 2022 11:52:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424345.671694; Mon, 17 Oct 2022 11:52:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOfA-0003y0-2K; Mon, 17 Oct 2022 11:52:08 +0000
Received: by outflank-mailman (input) for mailman id 424345;
 Mon, 17 Oct 2022 11:52:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okOf8-0003xq-7H; Mon, 17 Oct 2022 11:52:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okOf8-00060w-48; Mon, 17 Oct 2022 11:52:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okOf7-0000XW-QQ; Mon, 17 Oct 2022 11:52:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okOf7-0007hW-Ps; Mon, 17 Oct 2022 11:52:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qsV7kW1hM1eKpyAjHH6AilJtixeEseXO1gnpcCVv2J0=; b=qIg4OX3C1f+wDLjTFt1uaYpyiK
	4u5DnOttX8o2OPknJFAStuaxqZRs7fGstwfcDAnNIZ8Vs0M5KEQuSpQijqqp3lp0oMhofJfIljE49
	6t2+cLHMwNn2i5Zw1S7/RlhocYBZ14Rk6qTTvj96f0dR+S27SQYLQMguORTLx4HV464o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173984-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173984: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 11:52:05 +0000

flight 173984 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173984/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173973

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173973 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173973 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z    9 days
Failing since        173492  2022-10-11 13:01:50 Z    5 days   37 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    2 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 12:03:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 12:03:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424361.671704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOpw-0005kg-GP; Mon, 17 Oct 2022 12:03:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424361.671704; Mon, 17 Oct 2022 12:03:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOpw-0005kZ-DZ; Mon, 17 Oct 2022 12:03:16 +0000
Received: by outflank-mailman (input) for mailman id 424361;
 Mon, 17 Oct 2022 12:03:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okOpv-0005kT-KX
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 12:03:15 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a793cf9f-4e13-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 14:03:05 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 17 Oct 2022 08:03:00 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by PH0PR03MB6801.namprd03.prod.outlook.com (2603:10b6:510:118::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 12:02:58 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 12:02:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a793cf9f-4e13-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666008194;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=/5ggrce/QHUTCx7MXmqe/YGr+Ap2etTSkjFEU7hGmqU=;
  b=U+S0BoUesI+oW4FU/nTvHJSd2R7LOEF/D/7XHQ0x/I8RdlpmZUTTzkpS
   0npVCk2WiVJjwZNI8nj4vrUkRIryCFX57CBmyCgC4G/+1G/xZdfWi6vsF
   RXhQqrviAPCy6iZI8V5ObTRdpPY6GFfkeXsU2Xjcce56m2wZEwB44y0Sd
   Y=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 82520829
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:YF7k/alM4HD1K1vl+ZCVsZ3o5gygJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXCDvUOPfYYGHzKIt0PdzkpktV78XSnNNrHlQ6qCgwRiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRnOqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHUEV8
 MMHJgA2QD+hvaW4mpyVesAzr5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KklwZPLvFabI5fvSjQ8lPk1nej
 WXB52njWTkRNcCFyCrD+XWp7gPKtXOhBdhKROfpnhJsqEeCllYwCSQub3a2nvr6pGG9dv4Ad
 GVBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQGucksVHoV3
 1mGt9rzAHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A6d+zpog210vLVow6Tv7zicDpEzbtx
 TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g
 Q==
IronPort-HdrOrdr: A9a23:/eWmxqFqv9+WaK8RpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq
 iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO
 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46
 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ
 HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8
 o=
X-IronPort-AV: E=Sophos;i="5.95,191,1661832000"; 
   d="scan'208";a="82520829"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Phv3npqMFHgloSU///MMdEGGrAqWCu030ZEGO77SBRwbEBi+woGvI9Qwny/SxmE2iZicm6Uz/rzvLMpIrRRCAwO4UYifZxAt+uSGt062adX7nl+zI914cvEqODbm3uvMpzp3WFCMn8FklkEpk4cEKIiypyi+2nppJ3sv4Yjp25eZ+1sWkqY8luI8T1Wq4FuuF6IWQQY541S7hpukojMPkgKglf91CyXovpPBZfxepG/DW8myXjaOVuxKDxGaaJrz1cjfOUX+ejG7RBs8e4eWCP2MIIV+4HZmnaIX5L1K6bvJKNcoPm3T2Ra2vizn9WfnVCWcAmV42WDcdJWbiTGRsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/5ggrce/QHUTCx7MXmqe/YGr+Ap2etTSkjFEU7hGmqU=;
 b=QhdxyZOEN1hf4xSFIOU0aaQjjRLyXHyNv6/84N1qZjZcdw7fc3niUnLZq5wIZdma0esfePsMw2WDtFymcw9zeOyyvagJ0K3hcvJH2q5UWBGXdgeQhzAAQpCBAYua1UDeMd2NN+LHBWssJcsZRPg14/g5DYS9NUzatEuwcgbfh9Ti+h0HrMPAQyhUhDsILcmf5VFk5fYZ0sfrwQTw1Wj1U4w5dZ+uD0UqllPtyqvU2dgbbC+t8J0OguWunSVu2XzXzrkkF1C+kcn7wwLDrhOYqhwud2p9pzak/wStrrykwXHqLXJXyUCQkvaBmmXIYYvbHT4Ee6U8RmDU9xbQ+sBLJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/5ggrce/QHUTCx7MXmqe/YGr+Ap2etTSkjFEU7hGmqU=;
 b=ukfGaIXOc+giyQO6mXxWZzvzd+8aLfzq3AuqIGPuiFceUGwUGwsaXeF6FDJipa4zpCTCNYPStLz6MMQA943FOocgn/+ZH3m0yS/yQ7IboQuVDwgrROKMzrxNAiP/oEAceJ9/CRUgFetDn0aCL+hGOsj8CFGhVnOm/fZEvFStKZs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Anthony Perard <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Henry Wang <Henry.Wang@arm.com>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH for-4.17] tools: Workaround wrong use of
 tools/Rules.mk by qemu-trad
Thread-Topic: [XEN PATCH for-4.17] tools: Workaround wrong use of
 tools/Rules.mk by qemu-trad
Thread-Index: AQHY4hQGpCiXp3RqNU+NZuzB/jW9aq4SfKKA
Date: Mon, 17 Oct 2022 12:02:57 +0000
Message-ID: <e4ea8113-9d93-995d-ad7a-d75fedfe1aaa@citrix.com>
References: <20221017103403.63218-1-anthony.perard@citrix.com>
In-Reply-To: <20221017103403.63218-1-anthony.perard@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6801:EE_
x-ms-office365-filtering-correlation-id: 66ab6bbb-c3d5-43c3-b290-08dab0378829
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 fd7ah8SyoAo4wKhCChBMO2K8Ql6dVNdLrcB0madPCuHOQtjyXS/62ku5p/U5ajnaLeC6AUM4wWTxlI+7etXKem2D2XtYr1Bf13BZseyhVHjhS1ZI5RbtD2BjMKA9QdmZdoLZTxekq5Xbn7qfiNTSgI4sCF9e5NuvHUhzXYbYcr0Ssa6CiyGQm1bsety+QuPzMajCr3Ol42cweEAvw8v5ea1frC+BEeBs+kXja7x6gmJI89t2Etaq5cGUFyIXDkkgfi5rOqJlJHekoStCvD5XGnM000GnflfiMt3QPgdi3QFfHMbaOyr0hTgTx8TEBeZ+Qgu0cGAq6ho5FcmqkvOT1TLzfSy++UXU5gzvHvtAypi5FhHPKanuZZDvu9kxTwlrBTwPuKkpDrKqaXdxmpRIpxVSLDIQnY3hHUOmGInA3tKoJLctlhihtrD1LeWMAeoOw1Uq25JKZ8C39w95FXC5HGKkKCWOPteLxINTkQm2mDNJHPoANJ5YlI45xpWaz+dOnbJfNuNdYVyx2mg9Nj8p94JT6cV7nEj+y2Gmjr7vdcnJSmrcrZRXgT/c1GklwPOMJU4VPdVCSlzllns+aiOD//iSDUbZVouHa7qUUAyFupJK+YTUnxH2T6vlxPpyFxPhkeM1s7GMU6j6R0+DX+SyWe8ViPoGElTMsmAPrwKtO0UcTnalBpbeK1KlsOZJw6BVfTGR0oJ6Rkk0bJxNq8edsCGitMSWFB7EnApbv35Ek/gEPh47eIDkm+AHVncm6o5NF9b+//FzpkfvTQ2QmX80kKDZ1Pa45+uFtSVTMs3bmEaNOTKlff4SgqrqsANXWjSobm9E/5iswUNi0FjoGOHLxQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(451199015)(2616005)(186003)(83380400001)(38070700005)(31696002)(86362001)(38100700002)(82960400001)(122000001)(5660300002)(4744005)(2906002)(53546011)(41300700001)(8936002)(4326008)(8676002)(64756008)(478600001)(26005)(6512007)(6506007)(316002)(91956017)(66446008)(66476007)(66556008)(66946007)(76116006)(54906003)(71200400001)(110136005)(6486002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?a1p6YzJlZzQ5UzRacGJISU5GcnN1NGllaGJUbzJDZVBsN0oySDEvNEZqVnZY?=
 =?utf-8?B?QzRrbTFlQUxSREFzZFQ0aEo1akszZmQxa2h2MzNmZkYzczZpNzgxOHBIbjFv?=
 =?utf-8?B?TVIwRDRNRTR5TFVIOUhEaXY5TWhDaE8zd2tldDBWbE1OYlhySTFqQS81UVpH?=
 =?utf-8?B?NmxKU0hWWEtSVUg5SzYweTlSR0lFcXNqVXNKZUVsQzJmUDY3QTd0R0ZPUGxj?=
 =?utf-8?B?WlZQSXZYNkNDTWpoK3JFU0lDOS8xSjYyWDNGeGRBa1RXdnRLTEE1NC9neXFT?=
 =?utf-8?B?ODhIQlFxYmZuMVdaZVhqUXpNTmE0ZWhlQUtrR0pTQUZLUHEvcUYrd0o1RUI0?=
 =?utf-8?B?b3BKdFBOUEFDcWtkRWRyZGlGSGMwQVU3WnQ2OUNKTzNBSG1GcEFMNmN0cmF2?=
 =?utf-8?B?TFFTS0EwSDdFRTFnaXkxb3dGbmdxOWNRMFJBK3Y4bjEveUdmeVRyTGtOY1Ay?=
 =?utf-8?B?ZEczdFVWY1lsQzU0azU0ZWQ4UStSeEN2emxRbmlsQytLajVqK0hENjc4SUsy?=
 =?utf-8?B?QjU0TEJQOVJBQWFNRWtOaFNnK3FhdzBKRDJaYndkaUN3cW4rMDF1QzVpU3VG?=
 =?utf-8?B?Rm9Ma0JQQmEyeldlUGUvSEx6bk84RzFXZUVsU3dlNlJKSEY1REFvTWN5U2Ir?=
 =?utf-8?B?MWJSTmdYVlFod1BXMVJIU1hwajJldGYzb2t3bG9kcXZoekRoYVhDT3ZTc0RL?=
 =?utf-8?B?anJuZ1FJOEVkOTFsU1l2WndDWFY1TlkzOWhvSG1NM2V4ZzdkNDY1ZDhibWE2?=
 =?utf-8?B?Mk9DNW84RFU5T2V1MHRORDQ5UFRZT3FWN2tra3RqeG5pQXdEQ2cxSVlBNU1L?=
 =?utf-8?B?cG0rSzc5ajdFNllqVUllOHgyYkFDbkRCZnhRRlVQN0NYY25aYU5qR0VwL3Vz?=
 =?utf-8?B?a2UvQnNmUjZ5a09KS3ptcTE0cGFzaFdIWHUraFlyNVliMlBpdFJXbUVoQUFx?=
 =?utf-8?B?RWJGQ0drZUw2ajRRT2ExcUl3b2w3aWhiM1Z1aWNuR1hXMkJCbVVHbEs5enJW?=
 =?utf-8?B?bzFkTEY3anNSVTB0SVc5d1MyRjBvbnhzWm45M0dBTDJsSEVFZkxBeGN0eEVp?=
 =?utf-8?B?MGFNdnVFWUZEQlZ4YzZ6cFhCMCtsM2JZVjFlRllXYnhhdXRpZzIwaUlnR3pQ?=
 =?utf-8?B?VTlzZzg3c3hVQ0h0QS9yTHl6NXljdTFGMkxvQ3g3eWRVTFJEYkJPK1VkYUFS?=
 =?utf-8?B?N2pERVpHR1BNbVBCaUQ0M3Y2UENBdFZhc0xTdWRMdm5xb21MMjZ1TEFLeDY4?=
 =?utf-8?B?ak5lYmJFYzk3TUlJQ2VhMjVlMzArc0Nwck83MnZkUnRkVldicnUrVG1pdjJw?=
 =?utf-8?B?RkVyRVhTaEtUUnpwd3NNUHNLQitJNUt1Qkdyc0FobHdlQ2wrVHQ5SDhkeDhj?=
 =?utf-8?B?d1EvaVFRdVE2THBWK1MrV1ZJb1pKR0piaW1pMmpVZExtYm95UDZ4Rm9mUm5O?=
 =?utf-8?B?cTdhTDZQWXJVU3ZlT0tOeVZIcXo0WUZQaysxRm1yRG53aDZBbVpmR3dZYnFr?=
 =?utf-8?B?VlMrVUhYZ1hDN3lSVk1XRWVWOG9MMnNoNm9STEtmZURxVEsvRXl6bFYzZXpu?=
 =?utf-8?B?dHZja0N5TEsrRTZvT2RtMmUyVG4zUmFqbFV3S1R3THhXNkwzdzFmN0c4N2Uy?=
 =?utf-8?B?enp4UlVUMDBreHNlN2NrN2dyQzgrdW9QS1BpWW41RUczTTVzRkx3YjhIY2Nv?=
 =?utf-8?B?anltTk1sai9XL1pXT1pJTlVnZFg4Q1FGOEltZGpFZUV2Nzg4bm4rYTUwcXpN?=
 =?utf-8?B?QWh0MjRiWG9abFFHVHJxRDNWbTVSeG4wYzRIVHdDMHVkVUYwbm5IdEhhZ2s1?=
 =?utf-8?B?OEVEYzZ3SHVXdUdpY3BvMnlyNGluK04zdUgvanFIbitPbzNSM3ZKWDMyaEtV?=
 =?utf-8?B?WFlwWEtwRlAzV01yb0JLMDZDMWExQTRiZW13ZXI4M2tKMC9FNXJGYTRPQjNl?=
 =?utf-8?B?MVF6bjAvRnFwR0tGNzkzakw0blFjOGhxb3hVeXdVVjBnRGJacXZGRy91SGVi?=
 =?utf-8?B?NnpzQlhQeUk2NUs3WkZ2UkVHeDArT2Fybis0WDYvYzIvcnRQSjFzMmlxb1JG?=
 =?utf-8?B?RWxVNFVTNVA5b0lkT3RZWlZ4eGJqOFcxRDhBa045UENIUmx5Tm80WXlJRFFK?=
 =?utf-8?Q?jwHejQAgFO4FYR6u44TNP27xj?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2264191DCEB54442969680C84C721873@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66ab6bbb-c3d5-43c3-b290-08dab0378829
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 12:02:58.0001
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0QSIyX43JKaPhyhrmxSvWiHzzov0p7+X4lR9RFnlZKl9aaehjF0yLPUahF13WpgA1FpfBWNxd7lML93OLCDgSWFrm3Snrxr5dHar+5y4BqY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6801

T24gMTcvMTAvMjAyMiAxMTozNCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IHFlbXUtdHJhZCBi
dWlsZCBzeXN0ZW0sIHdoZW4gYnVpbHQgZnJvbSB4ZW4uZ2l0LCB3aWxsIG1ha2UgdXNlIG9mDQo+
IFJ1bGVzLm1rIChzZXR1cCB2aWEgcWVtdS10cmFkLmdpdC94ZW4tc2V0dXApLiBUaGlzIG1lYW4g
dGhhdCBjaGFuZ2VzDQo+IHRvIFJ1bGVzLm1rIHdpbGwgaGF2ZSBhbiBpbXBhY3Qgb3VyIGFiaWxp
dHkgdG8gYnVpbGQgcWVtdS10cmFkLg0KPg0KPiBSZWNlbnQgY29tbWl0IGU0ZjU5NDljNDQ2NiAo
InRvb2xzOiBBZGQgLVdlcnJvciBieSBkZWZhdWx0IHRvIGFsbA0KPiB0b29scy8iKSBoYXZlIGFk
ZGVkICItV2Vycm9yIiB0byB0aGUgQ0ZMQUdTIGFuZCBxZW11LXRyYWQgc3RhcnQgdG8gdXNlDQo+
IGl0LiBCdXQgdGhpcyBmYWlscyBhbmQgdGhlcmUncyBsb3RzIG9mIHdhcm5pbmcgdGhhdCBhcmUg
bm93IHR1cm5lZA0KPiBpbnRvIGVycm9yLg0KPg0KPiBXZSBzaG91bGQgdGVhY2ggcWVtdS10cmFk
IGFuZCB4ZW4uZ2l0IHRvIG5vdCBoYXZlIHRvIHVzZSBSdWxlcy5tayB3aGVuDQo+IGJ1aWxkaW5n
IHFlbXUtdHJhZCwgYnV0IGZvciBub3csIGF2b2lkIGFkZGluZyAtV2Vycm9yIHRvIENGTEFHUyB3
aGVuDQo+IGJ1aWxkaW5nIHFlbXUtdHJhZC4NCj4NCj4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQ
RVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29v
cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpxZW11LXRyYWQgaXMgYSB2ZXJ5IG9i
c29sZXRlIGNvZGViYXNlLsKgIFdlIGRvbid0IHdhbnQgdG8gaGF2ZSB0byBiZQ0KZml4aW5nIGl0
IHVwIHRvIGNvbXBpbGUgd2l0aCBuZXcgY29tcGlsZXJzLg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 12:05:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 12:05:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424367.671716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOs5-0006MM-TZ; Mon, 17 Oct 2022 12:05:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424367.671716; Mon, 17 Oct 2022 12:05:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okOs5-0006MF-QX; Mon, 17 Oct 2022 12:05:29 +0000
Received: by outflank-mailman (input) for mailman id 424367;
 Mon, 17 Oct 2022 12:05:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okOs4-0006M9-D1
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 12:05:28 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140087.outbound.protection.outlook.com [40.107.14.87])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb96896c-4e13-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 14:05:25 +0200 (CEST)
Received: from DB9PR06CA0021.eurprd06.prod.outlook.com (2603:10a6:10:1db::26)
 by DB8PR08MB5436.eurprd08.prod.outlook.com (2603:10a6:10:111::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 12:05:22 +0000
Received: from DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1db:cafe::c3) by DB9PR06CA0021.outlook.office365.com
 (2603:10a6:10:1db::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Mon, 17 Oct 2022 12:05:22 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT016.mail.protection.outlook.com (100.127.142.204) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 17 Oct 2022 12:05:22 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Mon, 17 Oct 2022 12:05:22 +0000
Received: from bb36d0fe130a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 77E54F86-0531-470A-993E-DA014D386CB6.1; 
 Mon, 17 Oct 2022 12:05:15 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bb36d0fe130a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 12:05:15 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB6341.eurprd08.prod.outlook.com (2603:10a6:20b:33f::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 12:05:12 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.032; Mon, 17 Oct 2022
 12:05:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb96896c-4e13-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=CCtVHFg2VP0b4FSPVPjGA/SJEUmDGbUw8tgOZh/yTO270yfUDz5xc0+PYTIGq/nxnJsnXzJb516LesbHqfelrijLsiQxpJqOXDlOcobzzDjjZ7EDbnlVsfjZcpxXKsg0GK+ZicBFRL9BRshbz5NOPUM5oXIFTFpXPjWdpSF5CrqMSrJ69eDqWKwpxsb0cJtB2mBDcuYbTz1YySj/EjNkZ2BlIVzMukbB4LxeEB/qOM5ZhCW8kZf8+Vaiw3WiGjmyvja1t8sfLHWTK8L5Nnws7qNa61n565oFYYzPxQWldFtY/6u8cWeJWCHbSqbPO7aOX4fS0WO1GwTJHuLWApE6pw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ViaYpkJ285S/ToBE3N07VDT25bvHeP+Y0SXdvjcaVpQ=;
 b=SazsJT0d4Xc258wDAe0IBEx40A4BzzaICahQFa6za1f5Zu6Gk8PZXVURlGqvqGIJ8uMvoHn2TGBA6yw86ELV6O4g3HpxC6PbverB0DGIDnSvmTGJ+FGwh2DdFKTv5Z1ZwmdS+D3ad5xllLORQBb07aqNyX9U+e+o9xgqWRc/83mu1UY753Irf4GvfkeDx9y/713fNAAcJatI2vHBcqLO6Hif/MIrVcioOP7hGQko2cpY9Hwpkm1jkrL9a3tli6tGn5JW0JSCvO+SW6kX534i2OxJy5RAe4bZpI9u/3do7uOB5m8rRb8P6xbRQawlnXFCjcxb4/g4FyNBLa6deVNFYg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ViaYpkJ285S/ToBE3N07VDT25bvHeP+Y0SXdvjcaVpQ=;
 b=Gtgm7DCkUJbAwBTyu96M8gZ/7wYaD/KsT8dDbnuKgM9xd+6t6DJ6R+LN9tK9Gdec9UYitcBLxxPbLxsnQgBroqLz5uLWaQqtQurafPZfcrSEKLxRCYqWaQS3hs4pwGqXs+r3oEAVHT+YBW4Z85KgstX3nLV7P/DbQ9GYAAVMlNQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wa1KX1HeBkJD3X0Zu1+og/9sXtKhrStJID+AjgwNnJoa3VgObioJOkfJfrLWdTOafbTTiQKv/WLw2ENDAV8LMAIN5WcNRzsksceZfXtNGt5OQa92U0Wf+kf3z6uhEr3iIhYbMDmQ6oPLDYDiOT9RuhSnR/n07/hooFswmu3D3TAOb8zTcWkpdqu3mJ52X9M5/s+71+G1Pg/lydy+4GUDyovyuEKnPJzIcUATNJdCgY6pMchvqO9lamu71Vke8/um0mKHO78bo5FBptcDcU5/M+zQr2NSCIxeDUgtAc8UkWLTEsrcJLTbihtQ5cjmlBpaYjRj6Dn64Yjl/amsFVS8dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ViaYpkJ285S/ToBE3N07VDT25bvHeP+Y0SXdvjcaVpQ=;
 b=Lq6PqG0NcECQQKWpcRdH6fmt+v1pozZC5GOIPLNjgtWX3LBylGWCEalhhdOJR2oRl/okqSmU47V9yERWznBncxvsqAXM9n361yJJACcifd/LGROBNRzsM5PjQlWZ1DUdXJ0Y1vn2qXIRb3N+gUOWZdGgkl0LYAi5VXFsEtjsoyG3MLOYZYHfNwoGpb2CvB4l7Cdj5kzs4lLalxJr1xLzqDQkQObDE4ZVoSBqlvMdkHFYRYFSMb6kkfc/+tb4X+8mfqLGyzrsCtWUIU+6HF8buobwaHH3MRZGcxMjS9Eu3+vOyzOe6S54Mnu38SSc6HibwIDTHBwdRtIUkxp2rwOUfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ViaYpkJ285S/ToBE3N07VDT25bvHeP+Y0SXdvjcaVpQ=;
 b=Gtgm7DCkUJbAwBTyu96M8gZ/7wYaD/KsT8dDbnuKgM9xd+6t6DJ6R+LN9tK9Gdec9UYitcBLxxPbLxsnQgBroqLz5uLWaQqtQurafPZfcrSEKLxRCYqWaQS3hs4pwGqXs+r3oEAVHT+YBW4Z85KgstX3nLV7P/DbQ9GYAAVMlNQ=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Anthony Perard
	<anthony.perard@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>
Subject: RE: [XEN PATCH for-4.17] tools: Workaround wrong use of
 tools/Rules.mk by qemu-trad
Thread-Topic: [XEN PATCH for-4.17] tools: Workaround wrong use of
 tools/Rules.mk by qemu-trad
Thread-Index: AQHY4hQDzkROwGW/ykyC81UfQCv+564SfKKAgAAAfKA=
Date: Mon, 17 Oct 2022 12:05:11 +0000
Message-ID:
 <AS8PR08MB7991985DA4CCC9BBDD4A28F492299@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221017103403.63218-1-anthony.perard@citrix.com>
 <e4ea8113-9d93-995d-ad7a-d75fedfe1aaa@citrix.com>
In-Reply-To: <e4ea8113-9d93-995d-ad7a-d75fedfe1aaa@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 5503CEBFAC40D549B05396E498364E21.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB6341:EE_|DBAEUR03FT016:EE_|DB8PR08MB5436:EE_
X-MS-Office365-Filtering-Correlation-Id: 52581ca7-59f2-42d1-79e1-08dab037de57
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 J2+HXOzMo1tDI52c1uD1zo9XaElXXAGjMHW32NKWCLxIAUyIi3XJohGEx2DFqvZHwyulEtjuAG8uoqscwO/67I6Izj/vEPfT+m/nfdkWvSEYbTASdYBhVZxjCyetlvWw5mEukETGVr4FdPR1BFIudZiBNIB0sAfSNrgDPjusuW6X2EJaUYgGENg12VE/CCJ/SGRej0jEeljwjZ+73Kq1aycIAhdTR4Ca+IFWJu0zwajBB2uOkmgx4sSrslZ00UC/9dUXvtAZ2VYmnE7EMA9N/qUDe4zYCvrED3poyaianwz1QNu9i4AasLIE2V7g2S+b4qz0735m8KMgHaxbIMGvjy/EZe55U+Tp+qx1SIcN69lY11xPLP/yVh34086Fdr1Wav2bkMMPBZ+Bv37rJ5SyrzhEB0I/sz26plTKndT8VpVQ7AIr5NEPi+LF0uPlkquNaWWTSXLL0/xi4etbJBV/1MYOrC8EZ008ZCM38Mt9v4QjvQOisFtiuNGeBAuqtG7DQKSG//PVMQTz7G+gNz+Vq7ayqesWsm3hXbwX5Gioz7+hQ6bO7Q9MGsY1Qvt0jKzXmoyuv00R/An4XSQ9QSzxHbEQvX/UYlHmALIBUq6a1Y9p64dWn5++b8n0KP7nmkwYRahEIBjjyheeObYHu2I4UOyq2sSLbIPG52QS9MrZBKoRtfxtjDbCBZlvsaz81/kSbPoyIepUjCUuGvdDEwvfULu/VQMScYFJ3BG5HkAXaRcYriSX3ciwm/JlVVNuUfXuD1zku1010k9rXmlno7DIlg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199015)(38070700005)(122000001)(55016003)(33656002)(86362001)(38100700002)(83380400001)(66946007)(110136005)(76116006)(64756008)(66476007)(316002)(8676002)(66446008)(66556008)(5660300002)(186003)(2906002)(71200400001)(8936002)(6506007)(7696005)(4326008)(478600001)(9686003)(26005)(53546011)(52536014)(41300700001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6341
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	de2d8057-c47a-4502-e8cb-08dab037d7f3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EsA29tplxF9muoNsbqtSbWChXQSt9FqG9KNLyF8v62EWRrHSjCxQzCyMgUwZ4fjXT+hX7cxN+U+7W0AL6XEH/5qKx7PiZqoxJI0evI3lQQo5eWOlYAz+SHEjpsLqU2Y7OTmeP7OxIrH4CbxFdbZ/rEH/JHc66+kOOsUVPH8P8WeUc2ZwijCRoBcPDTehTYG4iBfwUO7omkiyh8LttLa/k1T4+WgB+8wuDVFPLLMHxuwckUpSwR5lkSUo8QXPRhUt+9x5RUjS07g/oGEO7KW3e9qbjV6ltUuG5Ioyvql1h8sDCmW3GB66tEL7DHupifPN8bdd2A+U6opO27jEfYo+uhQx+5iQWCGore5rdsvRJ0WYGSQtGzmoGFDaotzxGn2dvfC5kj3AtLQS8y6eSBDz5UKi9jxPsN+nOP741ViRfpErQ58DmOW8iJLcbuhGRDlt4sRo04PkluaBSSjKSr1pqGVI90cbRH8R2SceTnCknN7/2VeD1pFW8DPu0ewBHZVR5jGMVEfhc9WOC+c7vLSzwKeEhaQsCEcu8aMHDOI8rIAfVu1nPkkq0JweBbNNidrro2/q1TigmAkjSIr4k9l6h3ZeiSqSiMJz0nb508pa7E2XRZgtJw26CqQpBqVBKY/8b/qMJowL1BFB2CXgZh8Ld/FfdMfX2AqFImd35tvSWERpxMxU07/RqmJGCBRnvbMnWyItzUfRHTHoahSbwBjgjr6QpvSPxXaw+bc5Xz0kmCVWL+gMSGPcfpk4osY/pVXBy9P9pEsjXrIFixEctqzUnw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(53546011)(478600001)(186003)(4326008)(70586007)(70206006)(47076005)(8676002)(336012)(41300700001)(52536014)(8936002)(5660300002)(82740400003)(356005)(81166007)(82310400005)(36860700001)(2906002)(83380400001)(9686003)(7696005)(26005)(110136005)(316002)(6506007)(86362001)(55016003)(40480700001)(33656002)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 12:05:22.6154
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 52581ca7-59f2-42d1-79e1-08dab037de57
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5436

SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQW5kcmV3IENvb3Bl
ciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogUmU6IFtYRU4gUEFUQ0gg
Zm9yLTQuMTddIHRvb2xzOiBXb3JrYXJvdW5kIHdyb25nIHVzZSBvZg0KPiB0b29scy9SdWxlcy5t
ayBieSBxZW11LXRyYWQNCj4gDQo+IE9uIDE3LzEwLzIwMjIgMTE6MzQsIEFudGhvbnkgUEVSQVJE
IHdyb3RlOg0KPiA+IHFlbXUtdHJhZCBidWlsZCBzeXN0ZW0sIHdoZW4gYnVpbHQgZnJvbSB4ZW4u
Z2l0LCB3aWxsIG1ha2UgdXNlIG9mDQo+ID4gUnVsZXMubWsgKHNldHVwIHZpYSBxZW11LXRyYWQu
Z2l0L3hlbi1zZXR1cCkuIFRoaXMgbWVhbiB0aGF0IGNoYW5nZXMNCj4gPiB0byBSdWxlcy5tayB3
aWxsIGhhdmUgYW4gaW1wYWN0IG91ciBhYmlsaXR5IHRvIGJ1aWxkIHFlbXUtdHJhZC4NCj4gPg0K
PiA+IFJlY2VudCBjb21taXQgZTRmNTk0OWM0NDY2ICgidG9vbHM6IEFkZCAtV2Vycm9yIGJ5IGRl
ZmF1bHQgdG8gYWxsDQo+ID4gdG9vbHMvIikgaGF2ZSBhZGRlZCAiLVdlcnJvciIgdG8gdGhlIENG
TEFHUyBhbmQgcWVtdS10cmFkIHN0YXJ0IHRvIHVzZQ0KPiA+IGl0LiBCdXQgdGhpcyBmYWlscyBh
bmQgdGhlcmUncyBsb3RzIG9mIHdhcm5pbmcgdGhhdCBhcmUgbm93IHR1cm5lZA0KPiA+IGludG8g
ZXJyb3IuDQo+ID4NCj4gPiBXZSBzaG91bGQgdGVhY2ggcWVtdS10cmFkIGFuZCB4ZW4uZ2l0IHRv
IG5vdCBoYXZlIHRvIHVzZSBSdWxlcy5tayB3aGVuDQo+ID4gYnVpbGRpbmcgcWVtdS10cmFkLCBi
dXQgZm9yIG5vdywgYXZvaWQgYWRkaW5nIC1XZXJyb3IgdG8gQ0ZMQUdTIHdoZW4NCj4gPiBidWls
ZGluZyBxZW11LXRyYWQuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8
YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCj4gDQo+IEFja2VkLWJ5OiBBbmRyZXcgQ29vcGVy
IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBX
YW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KPiAN
Cj4gcWVtdS10cmFkIGlzIGEgdmVyeSBvYnNvbGV0ZSBjb2RlYmFzZS7CoCBXZSBkb24ndCB3YW50
IHRvIGhhdmUgdG8gYmUNCj4gZml4aW5nIGl0IHVwIHRvIGNvbXBpbGUgd2l0aCBuZXcgY29tcGls
ZXJzLg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 13:17:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 13:17:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424385.671757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okPzu-0005HA-GT; Mon, 17 Oct 2022 13:17:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424385.671757; Mon, 17 Oct 2022 13:17:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okPzu-0005H3-DF; Mon, 17 Oct 2022 13:17:38 +0000
Received: by outflank-mailman (input) for mailman id 424385;
 Mon, 17 Oct 2022 13:17:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9T87=2S=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1okPzs-0005Gx-N8
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 13:17:36 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f80445a-4e1e-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 15:17:34 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-664-HpNHLWnmNwKShTKTz4_PFg-1; Mon, 17 Oct 2022 09:17:29 -0400
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E49381C0E127;
 Mon, 17 Oct 2022 13:17:28 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.193.46])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 79350200B419;
 Mon, 17 Oct 2022 13:17:28 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 7030021E691D; Mon, 17 Oct 2022 15:17:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f80445a-4e1e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666012653;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=K3Z5z6UTtIEHTPJFqUwyOpIjWsyYay3MJKRhggMStCI=;
	b=OtXxely8IWj7p1HMu66Jvhpo7ShpZrIfWlHw7gxG2ZHfeiwj68T4vUWxAZSa5+pqp01yTV
	seqSxMc0N0XKD4adXSzU8NdnqZ5d9kSmNXjn3m4kWL22VpmGExhQSWQjblyUiJP3yZJQ+P
	dTiIvfG7NJ8OVaoITBG3kx2iyE/wnV8=
X-MC-Unique: HpNHLWnmNwKShTKTz4_PFg-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Stefano Stabellini <sstabellini@kernel.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David
 Alan Gilbert"
 <dgilbert@redhat.com>,  Jason Wang <jasowang@redhat.com>,  "Michael S.
 Tsirkin" <mst@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Anthony
 Perard <anthony.perard@citrix.com>,  Greg Kurz <groug@kaod.org>,  Eric
 Blake <eblake@redhat.com>,  Stefan Weil <sw@weilnetz.de>,  Thomas Huth
 <thuth@redhat.com>,  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Paul
 Durrant <paul@xen.org>,  David Gibson <david@gibson.dropbear.id.au>,
  xen-devel@lists.xenproject.org,  Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v11 09/17] net: stream: add unix socket
References: <20221011200539.1486809-1-lvivier@redhat.com>
	<20221011200539.1486809-10-lvivier@redhat.com>
Date: Mon, 17 Oct 2022 15:17:27 +0200
In-Reply-To: <20221011200539.1486809-10-lvivier@redhat.com> (Laurent Vivier's
	message of "Tue, 11 Oct 2022 22:05:31 +0200")
Message-ID: <87v8oi4mjc.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4

Laurent Vivier <lvivier@redhat.com> writes:

> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 13:18:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 13:18:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424391.671768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQ1C-0005t8-VN; Mon, 17 Oct 2022 13:18:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424391.671768; Mon, 17 Oct 2022 13:18:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQ1C-0005t1-SR; Mon, 17 Oct 2022 13:18:58 +0000
Received: by outflank-mailman (input) for mailman id 424391;
 Mon, 17 Oct 2022 13:18:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9T87=2S=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1okQ1B-0005st-Cx
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 13:18:57 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b0a8bf9-4e1e-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 15:18:47 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-499-ssZCpTwiOh-ZqUAIGcsi1g-1; Mon, 17 Oct 2022 09:18:50 -0400
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
 [10.11.54.7])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D918832D9B;
 Mon, 17 Oct 2022 13:18:33 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.193.46])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 04FB91468226;
 Mon, 17 Oct 2022 13:18:22 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id F1BF621E691D; Mon, 17 Oct 2022 15:18:19 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b0a8bf9-4e1e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666012735;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fv+H1HfBuuaSSU9ZqnF7RzUaR12fVhwYkvfJvFZE4jo=;
	b=IVCnZ3AbJh9UP//5w/VAuclTIXvngx28mAbBPGLky89iPUGpRG2BD8YIF5/6KSVI6yl8rA
	/Fv1xMCEvqDM55u/f8M8cXPlxPusv4sPEuVJe0K5sQpkEr+jH2atsYSA+5Hc4MK2I+2/6H
	6FRCat7aORi/eDYMmmfptVBZJbNIy6o=
X-MC-Unique: ssZCpTwiOh-ZqUAIGcsi1g-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Stefano Stabellini <sstabellini@kernel.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David
 Alan Gilbert"
 <dgilbert@redhat.com>,  Jason Wang <jasowang@redhat.com>,  "Michael S.
 Tsirkin" <mst@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Anthony
 Perard <anthony.perard@citrix.com>,  Greg Kurz <groug@kaod.org>,  Eric
 Blake <eblake@redhat.com>,  Stefan Weil <sw@weilnetz.de>,  Thomas Huth
 <thuth@redhat.com>,  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Paul
 Durrant <paul@xen.org>,  David Gibson <david@gibson.dropbear.id.au>,
  xen-devel@lists.xenproject.org,  Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v11 12/17] net: dgram: add unix socket
References: <20221011200539.1486809-1-lvivier@redhat.com>
	<20221011200539.1486809-13-lvivier@redhat.com>
Date: Mon, 17 Oct 2022 15:18:19 +0200
In-Reply-To: <20221011200539.1486809-13-lvivier@redhat.com> (Laurent Vivier's
	message of "Tue, 11 Oct 2022 22:05:34 +0200")
Message-ID: <87r0z64mhw.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7

Laurent Vivier <lvivier@redhat.com> writes:

> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 13:23:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 13:23:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424398.671779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQ5g-0007KX-Gg; Mon, 17 Oct 2022 13:23:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424398.671779; Mon, 17 Oct 2022 13:23:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQ5g-0007KQ-Dw; Mon, 17 Oct 2022 13:23:36 +0000
Received: by outflank-mailman (input) for mailman id 424398;
 Mon, 17 Oct 2022 13:23:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9T87=2S=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1okQ5f-0007KK-0y
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 13:23:35 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e5b54c9b-4e1e-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 15:23:33 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-371-CRqCwp25Oc6MqzgD10q8nw-1; Mon, 17 Oct 2022 09:23:28 -0400
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 169002800467;
 Mon, 17 Oct 2022 13:23:28 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.193.46])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id B64AD2027063;
 Mon, 17 Oct 2022 13:23:27 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id A895421E691D; Mon, 17 Oct 2022 15:23:26 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5b54c9b-4e1e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666013012;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6LHpPs+irzkXe85yd4/kosVsQIrZAQ/OsKy5vMtWSLo=;
	b=FR0LJDbelsRcV9PEicefmfDJbXSSDyF5lFSmHx+wWNHmZgT1KEIN998RSWNYDt7kjdngis
	OygZtmmVk6Ss764wEFFy1eP6EbUKhz7Uad1zQvq+cQ0mIXXDwY/fy+xo29tS/uCXqAFRiT
	z4+48NVlu9tcJWf4wyscJc8KDW73Az0=
X-MC-Unique: CRqCwp25Oc6MqzgD10q8nw-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Stefano Stabellini <sstabellini@kernel.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David
 Alan Gilbert"
 <dgilbert@redhat.com>,  Jason Wang <jasowang@redhat.com>,  "Michael S.
 Tsirkin" <mst@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Anthony
 Perard <anthony.perard@citrix.com>,  Greg Kurz <groug@kaod.org>,  Eric
 Blake <eblake@redhat.com>,  Stefan Weil <sw@weilnetz.de>,  Thomas Huth
 <thuth@redhat.com>,  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Paul
 Durrant <paul@xen.org>,  David Gibson <david@gibson.dropbear.id.au>,
  xen-devel@lists.xenproject.org
Subject: Re: [PATCH v11 17/17] net: stream: add QAPI events to report
 connection state
References: <20221011200539.1486809-1-lvivier@redhat.com>
	<20221011200539.1486809-18-lvivier@redhat.com>
Date: Mon, 17 Oct 2022 15:23:26 +0200
In-Reply-To: <20221011200539.1486809-18-lvivier@redhat.com> (Laurent Vivier's
	message of "Tue, 11 Oct 2022 22:05:39 +0200")
Message-ID: <87mt9u4m9d.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4

Laurent Vivier <lvivier@redhat.com> writes:

> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> is connected, and NETDEV_STREAM_EOC when it is disconnected.
>
> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
> address.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  net/stream.c  | 11 +++++++++--
>  qapi/net.json | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 55 insertions(+), 2 deletions(-)
>
> diff --git a/net/stream.c b/net/stream.c
> index 0293e38e5b57..821ae3265356 100644
> --- a/net/stream.c
> +++ b/net/stream.c
> @@ -38,6 +38,7 @@
>  #include "io/channel.h"
>  #include "io/channel-socket.h"
>  #include "io/net-listener.h"
> +#include "qapi/qapi-events-net.h"
>  
>  typedef struct NetStreamState {
>      NetClientState nc;
> @@ -168,6 +169,8 @@ static gboolean net_stream_send(QIOChannel *ioc,
>          s->nc.link_down = true;
>          qemu_set_info_str(&s->nc, "");
>  
> +        qapi_event_send_netdev_stream_eoc(s->nc.name);
> +
>          return G_SOURCE_REMOVE;
>      }
>      buf = buf1;
> @@ -243,9 +246,10 @@ static void net_stream_listen(QIONetListener *listener,
>      g_assert(addr != NULL);
>      uri = socket_uri(addr);
>      qemu_set_info_str(&s->nc, uri);
> -    g_free(uri);
>      qapi_free_SocketAddress(addr);
>  
> +    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
> +    g_free(uri);
>  }
>  
>  static void net_stream_server_listening(QIOTask *task, gpointer opaque)
> @@ -317,12 +321,12 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>      g_assert(addr != NULL);
>      uri = socket_uri(addr);
>      qemu_set_info_str(&s->nc, uri);
> -    g_free(uri);
>  
>      ret = qemu_socket_try_set_nonblock(sioc->fd);
>      if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
>          qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
>                            addr->u.fd.str, -ret);
> +        g_free(uri);
>          qapi_free_SocketAddress(addr);
>          goto error;
>      }
> @@ -338,6 +342,9 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>                                              s, NULL);
>      s->nc.link_down = false;
>  
> +    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
> +    g_free(uri);
> +
>      return;
>  error:
>      object_unref(OBJECT(s->ioc));
> diff --git a/qapi/net.json b/qapi/net.json
> index 6a1a49749294..69f83bceff3f 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -895,3 +895,49 @@
>  ##
>  { 'event': 'FAILOVER_NEGOTIATED',
>    'data': {'device-id': 'str'} }
> +
> +##
> +# @NETDEV_STREAM_CONNECTED:
> +#
> +# Emitted when the netdev stream backend is connected
> +#
> +# @netdev-id: QEMU netdev id that is connected
> +# @uri: The Uniform Resource Identifier identifying the destination address

Is an URI the appropriate representation here?  It's not how we specify
such addresses elsewhere in QAPI/QMP...

> +#
> +# Since: 7.2
> +#
> +# Example:
> +#
> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
> +#      'data': {'uri': 'tcp:::1:1234', 'netdev-id': 'netdev0'},
> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
> +#
> +# or
> +#
> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
> +#      'data': {'uri': ''unix:/tmp/qemu0', 'netdev-id': 'netdev0'},
> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
> +#
> +##
> +{ 'event': 'NETDEV_STREAM_CONNECTED',
> +  'data': { 'netdev-id': 'str',
> +            'uri': 'str' } }
> +
> +##
> +# @NETDEV_STREAM_EOC:

What does "EOC" mean?

Could this be named NETDEV_STREAM_DISCONNECTED, for symmetry with
NETDEV_STREAM_CONNECTED?

> +#
> +# Emitted when the netdev stream backend is disconnected
> +#
> +# @netdev-id: QEMU netdev id that is disconnected
> +#
> +# Since: 7.2
> +#
> +# Example:
> +#
> +# <- { 'event': 'NETDEV_STREAM_EOC',
> +#      'data': {'netdev-id': 'netdev0'},
> +#      'timestamp': {'seconds': 1663330937, 'microseconds': 526695} }
> +#
> +##
> +{ 'event': 'NETDEV_STREAM_EOC',
> +  'data': { 'netdev-id': 'str' } }



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 13:46:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 13:46:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424404.671790 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQRb-0001P9-9t; Mon, 17 Oct 2022 13:46:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424404.671790; Mon, 17 Oct 2022 13:46:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQRb-0001P2-6C; Mon, 17 Oct 2022 13:46:15 +0000
Received: by outflank-mailman (input) for mailman id 424404;
 Mon, 17 Oct 2022 13:46:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=z+Xv=2S=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okQRZ-0001Ow-H8
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 13:46:13 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2067.outbound.protection.outlook.com [40.107.105.67])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0fd4d781-4e22-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 15:46:12 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9581.eurprd04.prod.outlook.com (2603:10a6:20b:470::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Mon, 17 Oct
 2022 13:46:09 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 13:46:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fd4d781-4e22-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V29v2/F5Kxrasr2fVeo1VdOunl+S7QhYK8ALKZnjzHi5l0VgR8376RGIWpG+uTB5zmIoOhMeR/uPi4TxdJPgvcT+lWCziHf7g8O24hPAiO4q0FJsAXoZgH64OoJPUsMsz5vnZhvLD42SC6CW44YO89vyYgU9zmnog+asmPnb8ULxIp8TRbLdHzok/9E569xGFwr6H3u9zsEOAh4opiqLqn+TIQmRyXOhq6LNDs42pspdElnilxuXT0YiJZFUZ12yRn6JU6QswG+jhHL2mLwG3DvwwAVITPO21xkaOG+4sPN0JQMBTO8hKdnsjRM04z4yFP9XxdqqiYAGhw42YTK8VQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=10dkC5RrwW9w0NQDW4sC5vJnO/FKco350v19QrmcmD4=;
 b=jviU1BNNv3yzN88cuRQXJOtakwGdBYYFMUFSdKhnuh/qgWr7HRMNlIaOP24VObDrvXZzL0ogK9pb8o+G+1WP9BSYrD++SM376GgwYFPMVJbcm9z5v9c5tYGYk4MNud87PAM8TL8xERg4XWqjDC0WiidIJBuAmmjDahPYE1aMkCv2//R25115/LDfbmT99CLwk9FmG3e7QlQIN9w1f6l4pnrWpcBf3rv7q2ARN8ZDGOFANeTfs1tHMNNl5FzyBiR7GAqRSTs+dB+LFTHd09uwxbeqPeRuD4VHQDwYBLIthbLSB5uzbIRPC2E9J+1eVOPGBwbpx1EEkG68rmBxxM6KeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=10dkC5RrwW9w0NQDW4sC5vJnO/FKco350v19QrmcmD4=;
 b=XlXlSRwEckePU5LUuAGGvIE2ya+YkmpfXi7eh94BX8TXZUR8Jz7QXl9zKC2pUIfACKREaKuV1puvlnQdWSmJlZ+rdLB+V3FK0chdvgzQ6Sb3JMerf/twdsCOnZrDUlkrLhUqTD9uvSvpPsSl7SVj8QodzK9JqzMNFudr1ZAHVxRPpe+Jk9xwf0NJTlbUuhXuiw1YtwNgLH2rqr923lQpGduxigXvTHT0UxPOi6jwZF6SNSIfEF3+Q9fBzAYw53vPWXO9Sp2HZp+ltmu3Je69GD8k+/E8x0Ypw+UTR3tLcXLg2QkssiTLbYObEb8yUsC5xsVMqx8E4ZPsfRagbBAntA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fc706330-d014-0fd6-4e99-27773f1d78af@suse.com>
Date: Mon, 17 Oct 2022 15:46:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
 <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
 <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
 <77349d2b-de72-3e68-362a-493f350eeec4@suse.com>
 <d297735d-771e-22f2-1b46-9c390ebb5afd@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d297735d-771e-22f2-1b46-9c390ebb5afd@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0153.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a2::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9581:EE_
X-MS-Office365-Filtering-Correlation-Id: 96653702-cbaf-40ec-a59b-08dab045f296
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bo3ptLWG9Ie2RctyknGWzZkddjVFaRrS1KCd599hJAuTb6akxCWcNw77mBACqZazJ/7FBdoIA+BZ5Qm99B6ZuvTI+L3o/dA+/0ko83Gnknvgdg8+aVHeY0yITuN2wbHmj2HHJRPFXiQDzY6YqwNLgTLLmMtD8IWQEJGDY14ZwmFzBrvDlDccX30SxcUGznDfH9kNp6LlcYObzMIPRfJJPmC9wyKsjoVfbcly2+x8VJq1PZGVittN0VlAIlbnw9WFrwGCmcT1GsLQsn5D79ZNdvniJhIMFAIlJY53S/+cx2ErLfQBTQhopxpbf11lLQ7FuPiWi2VZcPctG8BfdmDwSWYQJJ94RD677f/VXu8nZWCv76klPZ0Hr61GUSfC+IaiU01CWEDiihf7BHNLoEfWZRC/gQvhAGcsNPiGDdx6WeFAw+OBk9u4OSDJdyH3mddh1/uOMuzwoiePg+SPZ5iAj2RGR8MBqiaI/X7R99+Gj5Nl/rgpowk1DlEV/+xVO/MspgK7d328yEolCgrHL3nAjGs18XEwlqtSSL7wPU6Ati7GPJNIVP58lEJ/8+c0NCigKmp4EBz/PrGEnJMmR1xxomcwSiE9qKBCBEFCk7zhZUIVN4D0oa7IpUc++zIaCLyn6jS883UCggKzu+H838bSQAZTfn2Gbj2ClpDgfUjo4d1sS1PEb6QXOwjtg7YLC7bXJrPD/0pOIOswfIAS78B+8Tlj/3ujAwuWTpU8PkCRxD9D3MMnEYqHdMKIgOGN6jlFNdnb6xb9X4tICNiK7aaipUPRN3HYIDXmp1VUJkLj4Yw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199015)(83380400001)(4326008)(41300700001)(2616005)(31696002)(186003)(316002)(5660300002)(38100700002)(2906002)(66476007)(6506007)(54906003)(53546011)(478600001)(6486002)(8676002)(26005)(8936002)(6512007)(7416002)(66946007)(66556008)(6916009)(36756003)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDl5Q1NwS0FpUVJ5aXgvTVhCQlFidEEzbDRHWEZwNFdmQURBUVc0MUlLaWRr?=
 =?utf-8?B?QkpyR0ZyYWFpaS9Bc3hZTVREaDNNdWtxWkxySEJ3elFvY2FjT0V0SkpoVWhn?=
 =?utf-8?B?UWFoV29oVjBlaGVadlllS0xvM1Jhcm8wV0pWd3FWUkl3NmpKNGNVM3cwd3Bo?=
 =?utf-8?B?TS9ZcEVsOHIwR3lySnJaSDZuSFZCUzFWRE1paGhXdnNoZFhrNzJGWjgwRHRV?=
 =?utf-8?B?aEgwNDkzL3lWUzhOczArL2Z6N2lnQUFUdzN6WERjdjNRUk9oQUVJeHU5akM3?=
 =?utf-8?B?eFZGcUFWdzlsM3d4RjZEckpUc2lQbXU0bGR6eWJLOWpRTlFuNitqRkdJUVpr?=
 =?utf-8?B?WW0zelFLY2FRN1hNTFlvb0NBRXJRWC9KdUxhVktyQ3k2S0U3SnczRjRYUEtF?=
 =?utf-8?B?RVQ3M2VSeTdKb002eldKVXFqb3IvN2hTUWlOb0tlOHV2MUZEMWtTSGNnTTg1?=
 =?utf-8?B?THZjcG5YOGczQjgxRWhQTVFKeERUTHdmcnlLQWEyajQ0OVIvTFJGMktFK2pO?=
 =?utf-8?B?bGtZblI1M3R2UURGYjRBcU9OM3M4RUgrOWdRYnVFZGJPcTBTWUFPY05uQThV?=
 =?utf-8?B?S2ZjdlJGS2tKWFcrZVM5c3ZVanZvUGpuYytpMTV5MFpzeWtUZ1BWbnJqMGl0?=
 =?utf-8?B?VWNtTkxqYURNbEZUdTMwWC9MWVJhM0tXbWFyUzdWM20ra2xlWHZFWTMwczhw?=
 =?utf-8?B?SGtoeEVuS2RRY2w5Mmx5QnYyMlJMTXpSOFNIKzdoVmNCbUR3N2FuWS9Vd0Ry?=
 =?utf-8?B?V2xSamtjM1h2TnU1TENFc1ovdDlvRWZIVVF3b3FWR3F3clJhQzZGajNuc3N4?=
 =?utf-8?B?SzY1TXNNN0VqcTc3TU9ROHNmQUI4SEFjbFNBWmNjTHVmS24xQ3RhVHdxbnJK?=
 =?utf-8?B?eVJGNnNxdEZFM01uNi9vekhVRHptRGt2eGIrd09rWGZRaHZuclRodnJYaDMv?=
 =?utf-8?B?MzFCV2sxdDlYc1pEWDlCSmpmQmRyZGh2aVp5RUs5RU93UWxkVXVhaWwzaW5P?=
 =?utf-8?B?TkYzZ2JneEQxRGxlUmhnMEFtTGJJSVJWRnEydVY5M0xET0J2ZnlGRTlWS2Rx?=
 =?utf-8?B?d1BmRlpyZ0tOcnhHY2FBTXo1YThQc2dqdURpZjY4ekdhYUd2STAwSWlzVUtx?=
 =?utf-8?B?Z1hzNkVzQjM4R1pWelRieHRwRG9pdlNTQ0lDejV6enhacDl0b2pFSzM1MmFJ?=
 =?utf-8?B?dXJtUVNacG51bFpSYUk0bkRwUGhzRG4yR3dmVXlReVd4RXR4UGZnc0JjN2R6?=
 =?utf-8?B?a1pLdll3cklaMXJsT2hHbnZ5V1pWbHNOd01INEIyaDFLVHRUWWRqNEF2dmZ3?=
 =?utf-8?B?bVlXRVFiVEx5S2F2aXYwZGNUWWNFVlk1N2dvWmZFc3FqMHdCZENDTzE4aWlk?=
 =?utf-8?B?dGNaNEt4V1F6aGRKd01EelNGU0xIVU9GVlBGcnVZRnl5RE1ZUFFxWUZrcXpv?=
 =?utf-8?B?bi9qaTFGQWZYcjR5OVQ3N1NCMUdUQXRrdm5TMFpkZGQrZDhvUW1NZzRRQ29x?=
 =?utf-8?B?M3JzcDkzdGgvMmVOaE9STVdRQkc3K1NxcExQalIzRHNLRDA4akt2OUtIdVlt?=
 =?utf-8?B?bEJzZ1hqOWZOeEZuWCszeHVUaDFDZjlzaEZRU0hsM1lSa1ZpTlhkWkplV3BY?=
 =?utf-8?B?anNieWJDOXF2Qmh3a3FNWVkrbmdMVE42OE5adnNNOXFOVnIzTTB4SjFwbjBS?=
 =?utf-8?B?dm9YMGlPZjFqQXFNamV4cmkweEtNbnlxQlFjaUg0Vmc0UTlIekdOaDF3U0lC?=
 =?utf-8?B?QXZEdXNhVVVxQzlMYk9vaHE3WkhVVlU2YVd0MmJKS2EybTJaQXRrbEVjLzM3?=
 =?utf-8?B?TjFKNnZVM3YxbkFGcmZyRGRTUkNKZmpnejgxRElBcEhtdGp0N08vdkIzeUhX?=
 =?utf-8?B?ZGVMOXM5MVoraTdUclFqR0JzS0p0MXMxM3ZqR0V5YlZaZ0JsMlRhd1BIWFdM?=
 =?utf-8?B?NUNGYnVRd29tb3NzS3pHbmJTbk1GaE1ERU5JcVlLUGVVRU5CYjN0OUhOeG91?=
 =?utf-8?B?djc4aHEzTGFkU0tOTVJLZkI3RGYxUDVJSllEekNUeEFUbms3b2t1Y2NtVGNp?=
 =?utf-8?B?czg3YkU3QzVpMFVPMHp0bkJRc2EzTVhTN2ZWbFZYRkV1MWRQajdaTjBST0hh?=
 =?utf-8?Q?bk/MPe9wbhI1U1AG9Nu2L9cJ5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96653702-cbaf-40ec-a59b-08dab045f296
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 13:46:09.7099
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lZ0MeAhOhibs251cmg/3k/LMtbrSF8bWbTDFIYtzsYc/HcHYUVb99aqi+olf8RgjJI5NJ1BLzde+KHj0g6ctXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9581

On 11.10.2022 15:33, Julien Grall wrote:
> On 11/10/2022 14:28, Jan Beulich wrote:
>> On 11.10.2022 15:01, Julien Grall wrote:
>>> On 11/10/2022 12:59, Jan Beulich wrote:
>>>> On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> Rework Arm implementation to store grant table frame GFN
>>>>> in struct page_info directly instead of keeping it in
>>>>> standalone status/shared arrays. This patch is based on
>>>>> the assumption that a grant table page is a xenheap page.
>>>>>
>>>>> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
>>>>> to hold 52-bit/28-bit + extra bit value respectively. In order
>>>>> to not grow the size of struct page_info borrow the required
>>>>> amount of bits from type_info's count portion which current
>>>>> context won't suffer (currently only 1 bit is used on Arm).
>>>>
>>>> I'm afraid this isn't true: There's no requirement for a guest to pass
>>>> all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
>>>> tries to obtain a reference for every vCPU.
>>>
>>> AFAIU, this would be a reference of the **count_info** not **type_info**
>>> (which BTW will never be incremented on Arm because we have no type
>>> support).
>>
>> I should have said "obtain a writable type reference".
> 
> Thanks for the clarification.
> 
>>
>>> The commit message is only referring to the 'type_info's count'. So...
>>>
>>>> With my adding of GFN
>>>> (really gaddr) based registration of the runstate area (already
>>>> looking towards 4.18) the maximum possible count is to further grow.
>>>
>>> ... I am not sure which problem you are referring too.
>>
>> Wow - a mere stub (but not inline) function to make the build happy.
>> Then why is the description talking about one bit that's needed on
>> Arm?
> 
> Because share_xen_page_with_guest() will always set the type info's 
> count to 1.
> 
> TBH I don't exactly know why we set it. I always assumed this was a 
> requirement for the common code but never checked.

So my first thought was that this type-ref handling all being no-ops
would be an issue with gnttab v2, but besides that not being security
supported on Arm the code also passes SHARE_rw (for a reason that
escapes me) when sharing the status pages.

It does however mean that Dom0 can map the trace buffers r/w (unless
there's some special code in Arm preventing that), despite them being
shared with SHARE_ro. Not a big problem considering all the power Dom0
has, but still against the intentions.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 14:03:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 14:03:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424422.671819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQid-00041E-AM; Mon, 17 Oct 2022 14:03:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424422.671819; Mon, 17 Oct 2022 14:03:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQid-000417-78; Mon, 17 Oct 2022 14:03:51 +0000
Received: by outflank-mailman (input) for mailman id 424422;
 Mon, 17 Oct 2022 14:03:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NITi=2S=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1okQic-000411-HD
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 14:03:50 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8571e25f-4e24-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 16:03:49 +0200 (CEST)
Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com
 [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-657-BTdRU3eOOXilKDYgDHMWrg-1; Mon, 17 Oct 2022 10:03:47 -0400
Received: by mail-qt1-f199.google.com with SMTP id
 ff6-20020a05622a4d8600b0039cbf66e8b5so8514653qtb.19
 for <xen-devel@lists.xenproject.org>; Mon, 17 Oct 2022 07:03:47 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 g3-20020a05620a40c300b006eed14045f4sm8067755qko.48.2022.10.17.07.03.37
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 17 Oct 2022 07:03:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8571e25f-4e24-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666015428;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1wsrYdoZKYaMd0e3vhZfGJW60dLJna9JuS/wPJsmy1U=;
	b=hX3WFSA2Rt4YqbCPH2XRTiOs2eZ8TEwYVMSW6yDLNzEGNMeGadBHFXGzg1AmKSNFRq9Jqr
	QdEVycPEfyeNyZIT/RbJwTmrPYJeqa/pvnTwteIWmzj6E/PvfUGfpkA2Q2Ahix678Edag0
	GkY5ggA7Q0GyN5mSX/LRr30lfneJ5dU=
X-MC-Unique: BTdRU3eOOXilKDYgDHMWrg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=1wsrYdoZKYaMd0e3vhZfGJW60dLJna9JuS/wPJsmy1U=;
        b=ctC1maBvzaz7ikMWFrjDXM6lzz/OVYpCKKNrbhxiRvzDCmf8yRq06gCqs5oKZITZdC
         EysCf8pOh9dMdlbiPM0PvC9ILsFLqTTYl+JYkumyeIO53usLmeDiWI1J5kZn3n+GLQBb
         GsXQrZxgJFGLIUh421RJE2+uhvkxlCwMFjo6MWMgaECnm9VstD2z3qKnVMjeuxBfoHRw
         l5pVLO/Kw8U5QMbwAqP9q32nkiHxMpYvleUoxP2N1ZSfp3429aB2+1VkLQTFfL85ZOz9
         rWjaBuzsd5zTOFpvloph1wqG1SOGeZV9Of0jibvT6DKTQoCP72V086PUqLhxFRlWsxcU
         U4pw==
X-Gm-Message-State: ACrzQf2uW4JXHRxceEGwmAwfr/FUM6rpBX7ylpVEHCDx4ANu1Z5RGBcv
	UksknpzLjXB5eVRZrvCzBpUHMsALF90ZnpuIaUWAjisJmu0RwB4OVvgBv0cFq5t8Iz1q/szWc8W
	DSBSJ42WzCGOVink+kvtE2Trk7to=
X-Received: by 2002:a37:f50b:0:b0:6cb:be4d:6ce8 with SMTP id l11-20020a37f50b000000b006cbbe4d6ce8mr7686464qkk.135.1666015421470;
        Mon, 17 Oct 2022 07:03:41 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4u/YeakeV18+4BITTwq9fc/lh0NkQ58t6fwHnLwPvtzPwpZEHppmatLFZkzJtc37r2pYbT0Q==
X-Received: by 2002:a37:f50b:0:b0:6cb:be4d:6ce8 with SMTP id l11-20020a37f50b000000b006cbbe4d6ce8mr7686418qkk.135.1666015421085;
        Mon, 17 Oct 2022 07:03:41 -0700 (PDT)
Message-ID: <7eaa3255-7580-7e06-8b28-ae60ed5e1be6@redhat.com>
Date: Mon, 17 Oct 2022 16:03:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v11 17/17] net: stream: add QAPI events to report
 connection state
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>, Greg Kurz <groug@kaod.org>,
 Eric Blake <eblake@redhat.com>, Stefan Weil <sw@weilnetz.de>,
 Thomas Huth <thuth@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Paul Durrant <paul@xen.org>,
 David Gibson <david@gibson.dropbear.id.au>, xen-devel@lists.xenproject.org
References: <20221011200539.1486809-1-lvivier@redhat.com>
 <20221011200539.1486809-18-lvivier@redhat.com> <87mt9u4m9d.fsf@pond.sub.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <87mt9u4m9d.fsf@pond.sub.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/17/22 15:23, Markus Armbruster wrote:
> Laurent Vivier <lvivier@redhat.com> writes:
> 
>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>> is connected, and NETDEV_STREAM_EOC when it is disconnected.
>>
>> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
>> address.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   net/stream.c  | 11 +++++++++--
>>   qapi/net.json | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 55 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/stream.c b/net/stream.c
>> index 0293e38e5b57..821ae3265356 100644
>> --- a/net/stream.c
>> +++ b/net/stream.c
>> @@ -38,6 +38,7 @@
>>   #include "io/channel.h"
>>   #include "io/channel-socket.h"
>>   #include "io/net-listener.h"
>> +#include "qapi/qapi-events-net.h"
>>   
>>   typedef struct NetStreamState {
>>       NetClientState nc;
>> @@ -168,6 +169,8 @@ static gboolean net_stream_send(QIOChannel *ioc,
>>           s->nc.link_down = true;
>>           qemu_set_info_str(&s->nc, "");
>>   
>> +        qapi_event_send_netdev_stream_eoc(s->nc.name);
>> +
>>           return G_SOURCE_REMOVE;
>>       }
>>       buf = buf1;
>> @@ -243,9 +246,10 @@ static void net_stream_listen(QIONetListener *listener,
>>       g_assert(addr != NULL);
>>       uri = socket_uri(addr);
>>       qemu_set_info_str(&s->nc, uri);
>> -    g_free(uri);
>>       qapi_free_SocketAddress(addr);
>>   
>> +    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
>> +    g_free(uri);
>>   }
>>   
>>   static void net_stream_server_listening(QIOTask *task, gpointer opaque)
>> @@ -317,12 +321,12 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>>       g_assert(addr != NULL);
>>       uri = socket_uri(addr);
>>       qemu_set_info_str(&s->nc, uri);
>> -    g_free(uri);
>>   
>>       ret = qemu_socket_try_set_nonblock(sioc->fd);
>>       if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
>>           qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
>>                             addr->u.fd.str, -ret);
>> +        g_free(uri);
>>           qapi_free_SocketAddress(addr);
>>           goto error;
>>       }
>> @@ -338,6 +342,9 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>>                                               s, NULL);
>>       s->nc.link_down = false;
>>   
>> +    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
>> +    g_free(uri);
>> +
>>       return;
>>   error:
>>       object_unref(OBJECT(s->ioc));
>> diff --git a/qapi/net.json b/qapi/net.json
>> index 6a1a49749294..69f83bceff3f 100644
>> --- a/qapi/net.json
>> +++ b/qapi/net.json
>> @@ -895,3 +895,49 @@
>>   ##
>>   { 'event': 'FAILOVER_NEGOTIATED',
>>     'data': {'device-id': 'str'} }
>> +
>> +##
>> +# @NETDEV_STREAM_CONNECTED:
>> +#
>> +# Emitted when the netdev stream backend is connected
>> +#
>> +# @netdev-id: QEMU netdev id that is connected
>> +# @uri: The Uniform Resource Identifier identifying the destination address
> 
> Is an URI the appropriate representation here?  It's not how we specify
> such addresses elsewhere in QAPI/QMP...

I put in the event the same information we have in info_str and displayed by the HMP 
command 'info network'. What would be a more appropriate reprensation?

> 
>> +#
>> +# Since: 7.2
>> +#
>> +# Example:
>> +#
>> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
>> +#      'data': {'uri': 'tcp:::1:1234', 'netdev-id': 'netdev0'},
>> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
>> +#
>> +# or
>> +#
>> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
>> +#      'data': {'uri': ''unix:/tmp/qemu0', 'netdev-id': 'netdev0'},
>> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
>> +#
>> +##
>> +{ 'event': 'NETDEV_STREAM_CONNECTED',
>> +  'data': { 'netdev-id': 'str',
>> +            'uri': 'str' } }
>> +
>> +##
>> +# @NETDEV_STREAM_EOC:
> 
> What does "EOC" mean?

End-Of-Connection, this is the nomenclature used in the code when the socket is disconnected.
> 
> Could this be named NETDEV_STREAM_DISCONNECTED, for symmetry with
> NETDEV_STREAM_CONNECTED?

Yes, it can. EOC is shorter, it's why I used it, but if you prefer "disconnected"...

Thanks,
Laurent

> 
>> +#
>> +# Emitted when the netdev stream backend is disconnected
>> +#
>> +# @netdev-id: QEMU netdev id that is disconnected
>> +#
>> +# Since: 7.2
>> +#
>> +# Example:
>> +#
>> +# <- { 'event': 'NETDEV_STREAM_EOC',
>> +#      'data': {'netdev-id': 'netdev0'},
>> +#      'timestamp': {'seconds': 1663330937, 'microseconds': 526695} }
>> +#
>> +##
>> +{ 'event': 'NETDEV_STREAM_EOC',
>> +  'data': { 'netdev-id': 'str' } }
> 



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 14:09:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 14:09:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424429.671831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQnl-0004lP-48; Mon, 17 Oct 2022 14:09:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424429.671831; Mon, 17 Oct 2022 14:09:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQnl-0004lI-1K; Mon, 17 Oct 2022 14:09:09 +0000
Received: by outflank-mailman (input) for mailman id 424429;
 Mon, 17 Oct 2022 14:09:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OxM8=2S=amd.com=JESHWANTHKUMAR.NK@srs-se1.protection.inumbo.net>)
 id 1okQnj-0004lC-0p
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 14:09:07 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 41c82c40-4e25-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 16:09:05 +0200 (CEST)
Received: from DM6PR12MB4564.namprd12.prod.outlook.com (2603:10b6:5:2a9::18)
 by DS0PR12MB6488.namprd12.prod.outlook.com (2603:10b6:8:c3::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct
 2022 14:09:01 +0000
Received: from DM6PR12MB4564.namprd12.prod.outlook.com
 ([fe80::e64f:1647:9309:e3f7]) by DM6PR12MB4564.namprd12.prod.outlook.com
 ([fe80::e64f:1647:9309:e3f7%9]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 14:09:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41c82c40-4e25-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oBYx0odbknFAAH3fgsHA96NmUaVcQFn2dTTVXrv05ON/A+Z7XMoXnXUDw/m/XZIm5nsQEDPB6GRJ5BqBrV16kCKM32gz8tGCPGYjAwQkTCdqSRV2yjqG8Zf90r7yTve2HNquSNSKAX9b04maxRE1S0yNkMVMpc1f3bOkrN1cZXHMCojAuF10i4g76xKDmsweAW0tKMllxi7ixEZuPN7WlOOpDcUwAgkvaeQeoI6hIfjjY0jrkla2yf5jYAWKfu25QsJ5rGbNZ6qxl8nGR9KN+36rRCFK4qcnm8F1osg+OwxPuHfYQW4cSNPYuvHIrnmdd2M+c7KPJBQCYw3EunckOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1HPPNHf2pilwiFiyaraxvdFEuOe9FSEUTnUIubE2b8o=;
 b=K7UTMuOjByyugTOcmeMnOK9HMNiu9ZmRLIJgX+SoeKdHHfs/MNUql2wlP/+GyBQAOqzR+VwGiEwkDI23gN9+UHo3nAnBIJs75CGF/GbLazLq8t3ugG4JYSNk1ac3h0tH7wJHbzk6CGiAXobAuY/4jLtFC2PrOyc2mYcn2NTA6056H4Icy5a4l6+XC/Ulv9rfMeOYPfpPgEiqBBO12LGPOjzncVXkVnBav1yPOv9yqEW1MCPjMruUfdkvj6nM6Ucbm2xG7mxjtu6R2qYdHDWS4GQSYA1kw5rx4XUo9qO/ut1ADtnI/XRUWkxhyEaz+TWqn0W1skKFUUM5xaMki69pHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1HPPNHf2pilwiFiyaraxvdFEuOe9FSEUTnUIubE2b8o=;
 b=OmhnLrXzCq7QtZC7ElfKrlURUUZ8zY9eecsVF7QYfJxMh7O3iuoPB5BiZ8WQuI4WA44IzZvqqIO4F4Osht1WFXuAN2u/8CgGnVKYpV0tCrcZ263xw1gxvxyZ1DhqUnQ/Ddc3FGk656xL2MM5RbsSZmjX89CWKnVzQKKYVZD2kx0=
From: "NK, JESHWANTHKUMAR (JESHWANTH KUMAR)" <JESHWANTHKUMAR.NK@amd.com>
To: Juergen Gross <jgross@suse.com>, Stefano Stabellini
	<sstabellini@kernel.org>, "boris.ostrovsky@oracle.com"
	<boris.ostrovsky@oracle.com>
CC: "jbeulich@suse.com" <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "Thomas, Rijo-john"
	<Rijo-john.Thomas@amd.com>, "Rangasamy, Devaraj" <Devaraj.Rangasamy@amd.com>,
	"SK, SivaSangeetha (Siva Sangeetha)" <SivaSangeetha.SK@amd.com>
Subject: RE: privcmd.c not calling set_phys_to_machine
Thread-Topic: privcmd.c not calling set_phys_to_machine
Thread-Index: AQHY4BCJ7DwxaYBeYEW9c+uqhEENDa4SLiEAgABq0VA=
Date: Mon, 17 Oct 2022 14:09:01 +0000
Message-ID:
 <DM6PR12MB45642B7AC946ACAA9A010762E6299@DM6PR12MB4564.namprd12.prod.outlook.com>
References:
 <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop>
 <4907e079-0001-dbc6-dbfc-ee737882fc4c@suse.com>
In-Reply-To: <4907e079-0001-dbc6-dbfc-ee737882fc4c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-17T13:29:52Z;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=0c274a3c-e8a0-48b9-9b7c-17bd7c41fc03;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_enabled: true
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_setdate: 2022-10-17T14:08:56Z
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_method: Standard
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_name: General
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_siteid:
 3dd8961f-e488-4e60-8e11-a82d994e183d
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_actionid:
 adaf20a8-6c47-4db1-a700-9eb96fb013d5
msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_contentbits: 0
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR12MB4564:EE_|DS0PR12MB6488:EE_
x-ms-office365-filtering-correlation-id: 9099566b-1324-4965-2ddb-08dab0492485
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 wPDPAUQr7axnToSY3B3Vtg4upMGAkXX8eq8Y2KzrZRkz7H8iTCSAKxuvLI+q0pzfXkv0ZExWxWV7SJBRZpV7x2vvMqPVN4ZpgK77BiqXZ0QroVs7vCvWRJbwxO/K9ldSJlEnGzTMKvnhk7jv5qPsRkQNcmpfDYU9WiReT2eMHGOpd8WxUE4ihTB5nNjS5HMsCMe0yQqGB9wtq5EHwfQwZqEslyv5SYF0xszWLZ1QZblByk9fnK0eQw95WkOdMShueEmgwpleTUJmJQmhJDagBpzUJ91oDvJH4/QP16YzEkDv00dsbYJq23ZSjT7OboY+WNboEm4nhUqElV0y8l7CW1z04XOVe0M/EdTYGss+9lVXNUsL3hN1N44+1K1bTi0YwMWm/TbHaNJekPnXWujZVY2aHQ5+ozOA9QCrqOIwhszxn9pQzYJoCboRRMlftb2G0ijeFA9AUm/0K47DRlOGZu7Pd+sx0KaUxwegLEi7EtTi5+EKOyfNyEYWeF39DojL6thHO7YwrBUJmOVf0OFdh0Tkjk//YVwkjy69bwEwu+ImT27QPWN9agVZtVfoMXrD/o1LP0hM93yq41d5JHaRCjCkco+LaAOxkBaU4065gjrBcimdyix+Ckfo8YIJkYjZVMfPamw+N9GaysRF58QPhxYUwD3dGjb3wMXLgOYV980a7ST1+ShwVKH1FNR1cjlOc383rclfYItw1EOXcOyBYfQdikx6/adybTLL3tJQBuGS8pfhuusNayfQoEl2c0/17g3ND1Urun1j8ero9FG4L7Msg/kkXMgzYsZReB3XoTc=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4564.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(451199015)(38070700005)(478600001)(71200400001)(122000001)(966005)(38100700002)(4326008)(186003)(33656002)(316002)(66946007)(66476007)(64756008)(66446008)(66556008)(110136005)(54906003)(8676002)(76116006)(6506007)(5660300002)(7696005)(53546011)(26005)(41300700001)(9686003)(52536014)(8936002)(55016003)(86362001)(2906002)(83380400001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?cTEyMjE4UEpnTHc5K3RaVlZlS0tCRk02cEpsRmtydFFEalQ5czhhcmVleExj?=
 =?utf-8?B?NStEVmFzck9EWm9PTlVkaFo2Z0JOdVhjZGdrYi9PWXJKc3FZOVQyRnVnSlRS?=
 =?utf-8?B?ekRwajZOdldGQWx1dE9vZSt1QXRaaVFUcUpmWGtReFJDUnFzelo1aGFHRXpt?=
 =?utf-8?B?NHdnMU5xU3dsUHZmUllkdkxpeE1oKzhLWFhaM2tESDVDTkdTSlpSSXdrTHI4?=
 =?utf-8?B?VXovcmF5QlJwOXdISmJzZ1FvL21KNDhvZWZHU3NsM3N0SkdsUDlhUTAxSG5t?=
 =?utf-8?B?dkdRbG9mMWViZExMNTlaTGZlalJUVjFjbDBSQ21rSkN2ekcxUExpeGlSZTkw?=
 =?utf-8?B?bTBKR0ZYMk45NnArdVdFVmFaQXJBTkJGaHZNelZqazk2OUJweThVc0dxeXky?=
 =?utf-8?B?RS9jVHVCM0VRNlR2ZzF0Y1hlOXpjRjh1eG43UWluTmJFU052SVNLRGh0bGZ3?=
 =?utf-8?B?MjVpSm1raGpRVWVLUGp3cXJCeGhZUENRQ0NvREJDMmxWS3hYYzVEN3gxWnps?=
 =?utf-8?B?NEVxby9abnB3QzFMOGhCcWlQbExRVFNaV1kvditJQXUyS05XNms4Nkwxa09o?=
 =?utf-8?B?TGpOcmlaZk9tb1NUOXVWWkljR09CT0I4Y0NKeVZSOFZHcm1BUmdnaks5WC9J?=
 =?utf-8?B?TFN0bGVvZEJZU280R0pIQlJmQm10MVJWVENMZ29CRlY3U2NCVzEzZ05IVlJB?=
 =?utf-8?B?eEdBaVl5MDNUd2VRdmdwdTRRYzV0dG0vakFhQ0JobWhLbGRjVGhFSmFxN2xG?=
 =?utf-8?B?SFBnTis4NzBPT1RPOHRtMURJNk85L3ZyZWVZZXZuNnNoZGxRV2F5dE50SkdW?=
 =?utf-8?B?Y2J0OGRqcENINzBDQ2JrbkdCeDhCOWlLdXpUaTVlNjdramp5cGlleXlRSnZj?=
 =?utf-8?B?dWZQaDRyWWsvZnBtL3FpNnp2MjdpeGNPUExoVU9IY1l1ektlNGhxeUlQMHd1?=
 =?utf-8?B?R1BLWUNBdWZEWi9nYUpVTXhiRGhPTWZ6ZFRjNktpd3ZzVEhaSXdMT256NEVR?=
 =?utf-8?B?WUFGTTJyenBqQmhmYVpZVFRpU0ZOU1VkTk85OENJUFloampOdm8rdENEMkky?=
 =?utf-8?B?QVJZMDNyOVdEVGsreFAxY29DMDVCSkZ4WUQ3b3NtSkt4a2tpZllmZkpNNGZl?=
 =?utf-8?B?YUtBMzYyb2gvVGhVemtheUMrRTY5THpDZ1VOaFhPdWpwUUxTMEEwSEpSakFY?=
 =?utf-8?B?NnlZWlhpR2VoRUd3eDI1ZE1vTU53U1lXZHVqTVFnRzVQL1F6OWpQaXFOcG5Q?=
 =?utf-8?B?T1NjU1ZyWUFSbklKa0J1WFkyUkplNEFFcHZNOC9DWmMzbElpRVo0RlJlUUNh?=
 =?utf-8?B?UWsrOGphcUdwNEh4M3pHc0xid1hjaHJaVXdISGQ3MnQxcmlic2pZWEtLVDcw?=
 =?utf-8?B?ZFVLVExRakJiYm9LQm9MQTJBdUZGaGtibzRpbmFYejNpWjNoemc3NzBMOEt4?=
 =?utf-8?B?NkxSeHRwTkVtMmczdzFQVVFoZ3lORzJVdnFmUkxQcTdxV3VudWtoMC9CSmkx?=
 =?utf-8?B?QVhpYzRuejNIWHV0OGZkMHkzcEZLVkJYbVFmWG03MmQzenVwMUk2MnB3WUVw?=
 =?utf-8?B?NEU3OVlQR2pacXFuMjdKTFFmZURhUitqc2I4MW9GTFl6UlZtODljRjRQNHd4?=
 =?utf-8?B?bko4VlJNY1lOOEFjT1RRTVRlZ1hjQUQ3L0Q3RmZOSUlybUtEVjBBWHZqbDZM?=
 =?utf-8?B?LzZBMTZGKzhrZ3pkZjVsNDF3RWdCS0NmeSt3ditPT0J6VjNnYWhGNnpCVnN3?=
 =?utf-8?B?UGlYZnI2NDd4ajZBaFFnb08rZlRnelEwZUZRZ3BlelVGWUcxUE9PTnY2RThq?=
 =?utf-8?B?NU56VlgvOGRUTmQvVkVFMDZjRXZ1R2p2N2MzTkUrUmNwdVI3SHhEbXF5Rlpo?=
 =?utf-8?B?N01YVGN4ekFxWDFuU21UeFhJT1htcmxnYzZTcjNDdnNJMlkyK2ZZSVFReE1y?=
 =?utf-8?B?a0kvUkNJZ3F2QmJpZ2hETmxoZVVLRG03NFgxczdvdTJabVZ2M2FsZFNUS3VW?=
 =?utf-8?B?M3dBb21kNnRwL0ZaQThUWGhPTE5ZSkQwWmpuYVNJR2xtYnFROVhBV3JLOWI3?=
 =?utf-8?B?dnFBa21JZU1OYk9Ba2ZRd3dlaXQ4ZldURUxKMUxCbEtYRWZKNEdUTWx3VWJF?=
 =?utf-8?Q?ERQF9HNpLrTrY96hxpuIMiwxW?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4564.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9099566b-1324-4965-2ddb-08dab0492485
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 14:09:01.7999
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4yXHUIZbEAnLDFs9KlOB6ihnJxnKqezxJkXb2F0FpBXyIlntTZR6twKQwJy1sw7UxtFUQI+9bW54mGKfYtzjSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6488

W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEdlbmVyYWxdDQoNCkhpIEp1ZXJnZW4sDQoNCj4+IEkn
bSByYXRoZXIgc3VyZSAiQU1EIFRFRSBkcml2ZXIgZ2V0IHRoZSBsaXN0IG9mIHBhZ2VzIGNvcnJl
c3BvbmRpbmcgdG8gdGhlIHZpcnR1YWwgYWRkcmVzcyIgaXMgdGhlIHByb2JsZW0uIFRoZSBQVEVz
IHNob3VsZCBoYXZlIHRoZSAic3BlY2lhbCIgZmxhZyBzZXQsIG1lYW5pbmcgdGhhdCB0aGVyZSBp
cyBubyBzdHJ1Y3QgcGFnZSBhc3NvY2lhdGVkIHdpdGggdGhpcyB2aXJ0dWFsIGFyZWEuDQoNClll
cywgeW91IGFyZSByaWdodCwgVG9kYXkgSSBoYXZlIG9ic2VydmVkIHRoYXQgcGFnZXMgcmV0dXJu
aW5nIGZyb20gInBpbl91c2VyX3BhZ2VzX2Zhc3QoKSAtIGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4u
Y29tL2xpbnV4L3Y1LjE2L3NvdXJjZS9kcml2ZXJzL3RlZS90ZWVfc2htLmMjTDE5NiIgaXMgemVy
by4gIChzaG0tPnBhZ2VzWzBdIGlzIHplcm8sIHdoZW4gc2htLT5udW1fcGFnZXMgaXMgMSkuDQoN
Cg0KUmVnYXJkcywNCkplc2h3YW50aA0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJv
bTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KU2VudDogTW9uZGF5LCBPY3RvYmVy
IDE3LCAyMDIyIDEyOjM4IFBNDQpUbzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr
ZXJuZWwub3JnPjsgYm9yaXMub3N0cm92c2t5QG9yYWNsZS5jb20NCkNjOiBqYmV1bGljaEBzdXNl
LmNvbTsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBOSywgSkVTSFdBTlRIS1VNQVIg
KEpFU0hXQU5USCBLVU1BUikgPEpFU0hXQU5USEtVTUFSLk5LQGFtZC5jb20+DQpTdWJqZWN0OiBS
ZTogcHJpdmNtZC5jIG5vdCBjYWxsaW5nIHNldF9waHlzX3RvX21hY2hpbmUNCg0KT24gMTQuMTAu
MjIgMjM6MDQsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gSGkgSnVlcmdlbiBhbmQgYWxs
LA0KPiANCj4gSSBhbSB3cml0aW5nIGFnYWluIHRvIGFzayBhIHF1ZXN0aW9uIGFib3V0IHByaXZj
bWQuYyBpbiBQViBkb20wIHg4Ni4NCj4gVGhpcyBpcyByZWxhdGVkIHRvIHRoZSBwcmV2aW91cyBw
aW5fdXNlcl9wYWdlc19mYXN0IGlzc3VlOg0KPiANCj4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9eGVu
LWRldmVsJm09MTY2MjY4OTE0NzI3NjMwDQo+IGh0dHBzOi8vbWFyYy5pbmZvLz9sPXhlbi1kZXZl
bCZtPTE2NjMyMjM4NTkxMjA1Mg0KPiANCj4gDQo+IEluIHN1bW1hcnkgdGhpcyBpcyB0aGUgc2l0
dWF0aW9uOg0KPiANCj4gMS4gZG9tVSAoSFZNKSBrZXJuZWwgc3BhY2U6DQo+ICAgICAgYS4gcGFn
ZXMgYWxsb2NhdGlvbiB3aXRoIGdldF9mcmVlX3BhZ2VzKCkNCj4gICAgICBiLiBnZXQgZG1hX2hh
bmRsZSBieSBjYWxsaW5nIGRtYV9tYXBfcGFnZSgpIG9uIHRoZSBwYWdlcyBhbGxvY2F0ZWQgaW4g
KDEuYSkNCj4gICAgICBjLiBzZW5kIGRtYV9oYW5kbGUgdG8gZG9tMCAoUFYpIHVzaW5nIHZpcnRp
byBxdWV1ZQ0KPiANCj4gMi4gZG9tMCB1c2Vyc3BhY2UgKFFFTVUpOg0KPiAgICAgICAgICBhLiBy
ZWFkIGRtYV9oYW5kbGUgZnJvbSB2aXJ0aW8gcXVldWUNCj4gICAgICAgICAgYi4gbWFwIGRtYV9o
YW5kbGUgdXNpbmcgUUVNVSBkbWFfbWVtb3J5X21hcCgpLCB3aGljaCBjYWxscw0KPiAgICAgICAg
ICAgICB4ZW5mb3JlaWdubWVtb3J5X21hcDIsIHdoaWNoIGlzIElPQ1RMX1BSSVZDTURfTU1BUEJB
VENIX1YyLA0KPiAgICAgICAgICAgICB3aGljaCBlbmRzIHVwIGNhbGxpbmcgZHJpdmVycy94ZW4v
cHJpdmNtZC5jOnByaXZjbWRfaW9jdGxfbW1hcF9iYXRjaA0KPiAgICAgICAgICAgICBbdGhpcyBp
cyB2ZXJpZmllZCB0byB3b3JrIGNvcnJlY3RseSwgdGhlIG1hcHBpbmcgd29ya3NdDQo+ICAgICAg
ICAgIGMuIG9wZW4gL2Rldi90ZWUgbm9kZSBhbmQgbWFrZSBhbiBpb2N0bCBjYWxsIHRvIHJlZ2lz
dGVyIHRoZQ0KPiAgICAgICAgICAgICB2aXJ0dWFsIGFkZHJlc3MgKGZyb20gc3RlcCAyLmIpIHdp
dGggVEVFLg0KPiANCj4gMy4gZG9tMCBrZXJuZWwgc3BhY2U6DQo+ICAgICAgICAgIGEuIEFNRCBU
RUUgZHJpdmVyIGdldCB0aGUgdmlydHVhbCBhZGRyZXNzIHBhc3NlZCBieSB1c2Vyc3BhY2UNCj4g
ICAgICAgICAgYi4gQU1EIFRFRSBkcml2ZXIgZ2V0IHRoZSBsaXN0IG9mIHBhZ2VzIGNvcnJlc3Bv
bmRpbmcgdG8gdGhlDQo+ICAgICAgICAgICAgIHZpcnR1YWwgYWRkcmVzcyAoMy5hKSBhbmQgY2Fs
bHMgZG1hX21hcF9wYWdlKCkgb24gdGhlbQ0KDQpJJ20gcmF0aGVyIHN1cmUgIkFNRCBURUUgZHJp
dmVyIGdldCB0aGUgbGlzdCBvZiBwYWdlcyBjb3JyZXNwb25kaW5nIHRvIHRoZSB2aXJ0dWFsIGFk
ZHJlc3MiIGlzIHRoZSBwcm9ibGVtLiBUaGUgUFRFcyBzaG91bGQgaGF2ZSB0aGUgInNwZWNpYWwi
IGZsYWcgc2V0LCBtZWFuaW5nIHRoYXQgdGhlcmUgaXMgbm8gc3RydWN0IHBhZ2UgYXNzb2NpYXRl
ZCB3aXRoIHRoaXMgdmlydHVhbCBhcmVhLg0KDQo+IFRoZSBsYXN0IHN0ZXAgKDMuYikgbWlzYmVo
YXZlcyBhcyBkZXZfYWRkciBhdCB0aGUgYmVnaW5uaW5nIG9mIA0KPiB4ZW5fc3dpb3RsYl9tYXBf
cGFnZSAod2hpY2ggaW1wbGVtZW50cyBkbWFfbWFwX3BhZ2UoKSBpbiBkb20pKSBpcyAwLg0KPiAN
Cj4gICAgZG1hX2FkZHJfdCBkZXZfYWRkciA9IHhlbl9waHlzX3RvX2RtYShkZXYsIHBoeXMpOw0K
PiAgICAvKiBkZXZfYWRkciBoZXJlIGlzIHplcm8gKi8NCj4gDQo+IA0KPiBDb3VsZCBpdCBiZSB0
aGF0IHRoZSBvcmlnaW5hbCBtYXBwaW5nIG9mIHRoZSBmb3JlaWduIHBhZ2VzIGluIERvbTAsIA0K
PiBkb25lIGJ5IHN0ZXAgMi5iLCBpcyBub3QgY29tcGxldGU/IExvb2tpbmcgaW50byANCj4gcHJp
dmNtZF9pb2N0bF9tbWFwX2JhdGNoLCBmb3IgUFYgZ3Vlc3RzLCBpdCBpcyBjYWxsaW5nIG1tYXBf
YmF0Y2hfZm46DQo+IA0KPiAJQlVHX09OKHRyYXZlcnNlX3BhZ2VzX2Jsb2NrKG0ubnVtLCBzaXpl
b2YoeGVuX3Bmbl90KSwNCj4gCQkJCSAgICAmcGFnZWxpc3QsIG1tYXBfYmF0Y2hfZm4sICZzdGF0
ZSkpOw0KPiANCj4gbW1hcF9iYXRjaF9mbiBjYWxscyB4ZW5fcmVtYXBfZG9tYWluX2dmbl9hcnJh
eSwgd2hpY2ggY2FsbHMgDQo+IHhlbl9yZW1hcF9wZm4uDQo+IA0KPiB4ZW5fcmVtYXBfcGZuIG9u
bHkgY2hhbmdlcyB0aGUgVkEtPlBBIG1hcHBpbmcgYW5kIGRvZXMgbm90aGluZyBlbHNlLg0KPiBT
cGVjaWZpY2FsbHksIG5vYm9keSBzZWVtcyB0byBjYWxsIHNldF9waHlzX3RvX21hY2hpbmUgaW4g
dGhpcyBjb2RlIA0KPiBwYXRoLiBJc24ndCBzZXRfcGh5c190b19tYWNoaW5lIHJlcXVpcmVkPw0K
DQpOb3QgZm9yIHNwZWNpYWwgbWVtb3J5IHBhZ2VzLg0KDQo+IERvbid0IHdlIG5lZWQgYSBjYWxs
IHRvIHNldF9waHlzX3RvX21hY2hpbmUgc28gdGhhdCB0aGUgbmV4dCB0aW1lIGEgDQo+IGRyaXZl
ciB0cmllcyB0byBjYWxsOg0KPiANCj4gICAgLyogYWRkcmVzcyBpcyB0aGUgdmlydHVhbCBhZGRy
ZXNzIHBhc3NlZCBieSBRRU1VIHVzZXJzcGFjZSAqLw0KPiAgICBkbWFfbWFwX3BhZ2UodmlydF90
b19wYWdlKGFkZHJlc3MpKQ0KPiANCj4gaXQgd2lsbCBiZWhhdmUgY29ycmVjdGx5PyBPciBhbSBJ
IG1pc3Npbmcgc29tZXRoaW5nPw0KPiANCj4gDQo+IEhvdyBpcyB4ZW5fcGh5c190b19kbWEgZXhw
ZWN0ZWQgdG8gd29yayBjb3JyZWN0bHkgZm9yOg0KPiANCj4gICAgLyogYWRkcmVzcyBpcyB0aGUg
dmlydHVhbCBhZGRyZXNzIHBhc3NlZCBieSBRRU1VIHVzZXJzcGFjZSBhbmQgbWFwcGVkDQo+ICAg
ICAqIGluIDIuYiAqLw0KPiAgICBwaHlzX2FkZHIgPSB2aXJ0X3RvX3BoeXMoYWRkcmVzcyk7DQo+
ICAgIHhlbl9waHlzX3RvX2RtYShkZXYsIHBoeXNfYWRkcik7DQo+IA0KPiANCj4gTXkgZ3Vlc3Mg
d291bGQgYmUgdGhhdCB3ZSBuZWVkIHRvIGFkZDoNCj4gDQo+ICAgIHNldF9waHlzX3RvX21hY2hp
bmUocGZuLCBGT1JFSUdOX0ZSQU1FKG1mbikpOw0KPiANCj4gaW4gbW1hcF9iYXRjaF9mbiBvciB4
ZW5fcmVtYXBfcGZuPw0KDQpJIHRoaW5rIHRoaXMgbWlnaHQgYmUgYSBsaXR0bGUgYml0IG1vcmUg
Y29tcGxpY2F0ZWQuDQoNClRoaXMgY291bGQgd29yaywgaWYgdGhlcmUgaXMgcmVhbGx5IGEgc3Ry
dWN0IHBhZ2UgYXZhaWxhYmxlIGZvciB0aGUgUEZOLg0KT1RPSCB0aGlzIG1pZ2h0IGJlIG5vdCB0
aGUgY2FzZSBxdWl0ZSBvZnRlbiwgYXMgd2UgYXJlIHVzaW5nIHpvbmUgZGV2aWNlIG1lbW9yeSBm
b3IgZm9yZWlnbiBtYXBwaW5ncyBwZXIgZGVmYXVsdCBmb3Igc29tZSB0aW1lIG5vdy4NCg0KU29s
dmluZyB0aGlzIG1pZ2h0IHJlcXVpcmUgc29tZXRoaW5nIGxpa2UgZG1hX21hcF9wZm4oKSBpbnN0
ZWFkIG9mIGRtYV9tYXBfcGFnZSgpLCB3aGljaCBzb3VuZHMgYSBsaXR0bGUgYml0IGxpa2UgZG1h
X2RpcmVjdF9tbWFwKCkuDQoNCg0KSnVlcmdlbg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 14:19:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 14:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424438.671851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQxy-0006MG-6r; Mon, 17 Oct 2022 14:19:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424438.671851; Mon, 17 Oct 2022 14:19:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okQxy-0006M9-4D; Mon, 17 Oct 2022 14:19:42 +0000
Received: by outflank-mailman (input) for mailman id 424438;
 Mon, 17 Oct 2022 14:19:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JD8j=2S=citrix.com=prvs=282fc9ee0=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1okQxw-0006M1-6W
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 14:19:40 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4c602cf-4e26-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 16:19:28 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4c602cf-4e26-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666016377;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=3iTyJ2KaT2U2ZXqQqQdrj69OKJePCfOzU8l4HGwnN6s=;
  b=QVh6+FGVxnUrlPEKpfVfWHVKseD9bfwlQIHvgYjJ5hMlCvpOTk4YpCP8
   NsMagaax6Yom+/LcwrVZGE+04A0LXlCfpNU9QMiZHBc8QmD9mWQt+JNTd
   2CJRC+1Vnc0ushE7MjtkaEcHfTN+VJgGSMSJrkdcz57TjySw/n1yybTsF
   A=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82916933
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AimnpTaKd9OGnQKFrFE//H55yshmJRhNe4xJyi?=
 =?us-ascii?q?0ilI8yiH7QXhM5G7Omlw1jQegf0YDIFSlbiPPRe58jS4n/sN0mM7nHaNIReU?=
 =?us-ascii?q?AWC40vRmYVWU1rgR/z3pRu094SsKwfz7B26pzBF2z3/8PF8dlVkg7KM+SjUp?=
 =?us-ascii?q?vQYLENoWeqJqksg5uzA3myk53ny+xH4gqZZQ0OtwXAcEZBSC16ACAlHHP+mS?=
 =?us-ascii?q?Ul7BPAhqtSeIdRW40kJ2lp5jr0VvvHypvPlSbc1iS3hhxpqr/Px9R0WgHjxd?=
 =?us-ascii?q?2vkj8G6kWc6xl9B8LfMnXQPh4iXDp3w+nndLwWF9K068xbfvjRBvUjiGcg3p?=
 =?us-ascii?q?VU+EQ3RUf3TTqSa4xUQoA4+5LCG3eCakJsHJe+qV9U2oLABRsz6Ssgpjurzd?=
 =?us-ascii?q?sslqyGDF2Ha36jTB8HyLTxF+phTgQZLNQbZO4AO10KSmpcBIeUrxsLGFVOwQ?=
 =?us-ascii?q?MUVc8/hCXiFLw8zmrKKlhkZ+M9IVbvC6MlyIxfJ8Tvd85SgfU70rdyU4gVEY?=
 =?us-ascii?q?z5u8SBDK6rfKbDWtYp6Az+J1BDcY7AIllOFU1aXZH1rzRlVbaD6lQSq11goi?=
 =?us-ascii?q?nWcErZpJvesUj78twItGRl9HFw+xwq6p2/7SPvwbnJA+ccuUMHgiWpw8dT5s?=
 =?us-ascii?q?3vwiZA4plsIVwk8tlAekVimB2wtVu2LSGlWAo9AbqVmwG7SumztlDCzZZIyr?=
 =?us-ascii?q?gWs+gYNifVeTJLKCLvPZ2kt4nEqoHTjSIWDeQ19go0TMeGatO59R+KgcKX4e?=
 =?us-ascii?q?h7kJDRoMnlJaXm6gOLlJhEK5rgHIsXKcVQ/z8HR5UFGNXEH3wUvgGsizes1+?=
 =?us-ascii?q?nFxljRjPj4Cdaq8BuxGrznnKFDl4kQqHG+HjeCt2ofj96a/WrRAZTeonz7i7?=
 =?us-ascii?q?Xj7aXufuFJk8LJqbIS8kgVAMSJPeJSK0d8Ay0VlmjSE2cjYHq/qJ2CUDA3ec?=
 =?us-ascii?q?W+oXjN/JW3vlGF4Zw5GJfbt4GtU4hcaBHah9kSHDlO5dJyBToToqYmqx8lPk?=
 =?us-ascii?q?yAJoBNqXWZFQHwvYCuSOr/I17dMi87AVNAf8i2zI8mljLuTMPgd/C54FgMLF?=
 =?us-ascii?q?yEEo+LZIU1N1zPPpiou7HvEUpMxN2ob6b4ffJijiFkDV3HSg1QyCV6wD3nYR?=
 =?us-ascii?q?CqcQRVUoSt0GmpQu1Ffx5tOqYDqs0JUwznkehRG3sqo3vjsf7EgyNU4wIFzl?=
 =?us-ascii?q?8UymTj+TbTtS/Thv+VECoJw3joHYRHKHbgKkxSYhXdP2n42YmjSV4c2fKHDs?=
 =?us-ascii?q?vVJwXzu0UuAn+HsMZSWvh6Aa62y0QOJfj1m9MW+7inVQAkmgzC+dFs0iFmSQ?=
 =?us-ascii?q?beyokdgSscMe0UUKN2S12bHP+mzpAlWvbjImQUxs8OkJjNeuJylhyGjVFHX5?=
 =?us-ascii?q?MnNSzwiuYhbauBfE46H5SZJ5m6BbeYAkeN06wTvo3b9djfxLZcQwYSFsddTW?=
 =?us-ascii?q?2zUg/XxUoopkIaB6c3/c54BwSYuT586Gd51WvVc+NAKSpBWa7I6ByvDfL3oS?=
 =?us-ascii?q?/RZMtIPy62/r6zlxlmwPjdL8gOdxwQn+22KlXf9QzJAump+pIZ1cnHa9UtVd?=
 =?us-ascii?q?UlnfLLQ/ndT7TMaZOdLmzeu8+2zlMh0WKGA5ylpqHtZqluA+LhzDi+3sm1mx?=
 =?us-ascii?q?y2H9ARPFup8LZxFUcbHJggff1hkvS4z1vaW2eoN1UoalSGazkPSIB0jpJGm/?=
 =?us-ascii?q?Z8ca03nTOLgKFRq+Qhk9zNFgkO+eajbywOZPZ6iVpm4yEM5Slo05ea4yN/SN?=
 =?us-ascii?q?UMdUjOp3I9M6Pf7COPS+noWQ+VodsLsfV7FkaU/WTv6sBC7Vnn5K9GxBgLHR?=
 =?us-ascii?q?Irmy7EAm8bRB2wuSVd9C1qi3t4eQ8usGbeGwlqwXIn65cbe25a6aGBSCzktb?=
 =?us-ascii?q?PzTF4b1orfeGPdeDnDDNmHCxMGsQBikdGRsqw4YFObu7EljWPeSW2eHO0FE+?=
 =?us-ascii?q?LILxoQ1ko5ZqCdCznWBlC8FAjkMNth5uwcHl40vCvIduIJ4Ir3jsLPFdOHMN?=
 =?us-ascii?q?Ly1GDl+tqH5WPipsu1zL8RSW4NDkZ2OhCMwDksIMDjKaI0efPGfFgTMHghaR?=
 =?us-ascii?q?4yz0LYywOLY9ONb0DG4bd6VnAuQtvh9aGgSxgqrQmb7QRbgQyPW+N8kggGP3?=
 =?us-ascii?q?dUnxYRa+WhHiL3yQrIW34XEvTuFZyp51WOTHvHzLhisrrTiCM6r6a5JC0bql?=
 =?us-ascii?q?A633jOTbtrtpoFRro3cKB1fHg+uwkhRWxb9ewZOkbCXDpGCQ+BvYHeqeZgtJ?=
 =?us-ascii?q?1J4MsgOgPRCZEp0/6DyjHwSy+6GJlVyoNqrFKPa9/XYM5MKslK1ClGPKpGLj?=
 =?us-ascii?q?JBHMLullZAGN0jPfaHtZLDwzBeYoCz0b8ctKNPPKqGRdlUjWXe7jM/vNOMYT?=
 =?us-ascii?q?r2d2MSi6QLJT8HNdFlXcnYcoL1NRoL/aGKBNGU/AlB9UAdmECUwqfu4X1ohA?=
 =?us-ascii?q?c6WQ/Thn/PxJXabdsb4gxZ35sucFkcpTCuQSQzpW/eutUQua6QrK6h2xxcre?=
 =?us-ascii?q?Rgn7hvdFhdrHTUZbHv5H103J9KxC/PQiGehQaOqjoyTv0kkekfcdU1yO/SlG?=
 =?us-ascii?q?p8Sjw3tyejybuT+L0WEuXUumoSZCw8+Z0AmxD2iWAjXtfG5DhNWKgm8Ze5HR?=
 =?us-ascii?q?0NEYjQWZqP8rJbSbOD5YLKZAYmT5moEodYIvbdo38vECRRBXQtAmrsgS46tV?=
 =?us-ascii?q?gyLkI9vXwEaX1Dv5Qpd03QMwaTcoGO8uz7cZXeJyP0asUDU16hXkEB2onswP?=
 =?us-ascii?q?03ev4zRlvo4dEOqAk3A4/yIY2mbkImKdR3ZpG+NG9sHNQtQj4xpw0JP4sujj?=
 =?us-ascii?q?yNCnHioCSfOtEYvMS6Px7bCojAPd5aK7e5SmhTBDDro10TFZtLW2ZQ6CKoZ0?=
 =?us-ascii?q?GxR4wuE+LjT8J2nU7E9NVas9k+wP/S7PwiTK/Tl10L+WZvKqsHtq3XQux0ir?=
 =?us-ascii?q?u0=3D?=
X-IronPort-AV: E=Sophos;i="5.95,191,1661832000"; 
   d="scan'208";a="82916933"
Date: Mon, 17 Oct 2022 15:19:30 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "George
 Dunlap" <George.Dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, "Julien
 Grall" <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH for-4.17 v5 10/17] libs: Fix auto-generation of
 version-script for unstable libs
Message-ID: <Y01kcsWEhPVhsYfR@perard.uk.xensource.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-11-anthony.perard@citrix.com>
 <05589025-a3cd-8a8c-491e-089fd6d89c6c@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <05589025-a3cd-8a8c-491e-089fd6d89c6c@citrix.com>

On Fri, Oct 14, 2022 at 06:16:27PM +0000, Andrew Cooper wrote:
> On 13/10/2022 14:05, Anthony Perard wrote:
> > Alternatively, we could remove the need for to generate a
> > version-script, but that would mean the exported symbols won't have a
> > version anymore (like before, a few versions of Xen ago). Or, we could
> > use --default-symver, but the symboled would be versionned with the
> > soname (e.g. "libxenctrl.so.4.16.0") instead of "VERS_4.16.0".
> 
> It turns out that the use of VERS_* everywhere is buggy.� We should have
> had 'XEN$FOO' in the soname for libraries.� But it's too late for the
> stable ones.
> 
> As far as the unstable libraries go, it really doesn't matter.� The only
> thing we care about (rightly or wrongly) is that you can't mistake the
> libraries from different versions of Xen.
> 
> --default-symver sounds like it would be ideal, and avoid writing out
> temporary version scripts.

Sounds good to me, I'll rewrite the patch to use --default-symver.
Hopefully, that's an old enough option.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 14:31:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 14:31:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424444.671863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okR9h-0000FC-8N; Mon, 17 Oct 2022 14:31:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424444.671863; Mon, 17 Oct 2022 14:31:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okR9h-0000F5-5j; Mon, 17 Oct 2022 14:31:49 +0000
Received: by outflank-mailman (input) for mailman id 424444;
 Mon, 17 Oct 2022 14:31:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okR9f-0000Ev-Ps; Mon, 17 Oct 2022 14:31:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okR9f-0000aU-OE; Mon, 17 Oct 2022 14:31:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okR9f-0001SL-9x; Mon, 17 Oct 2022 14:31:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okR9f-0007Eg-9W; Mon, 17 Oct 2022 14:31:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6qN7NTgn71HX/N6Ol3y7T6KH8QXjDW28ejlsryIBLnA=; b=Sb9f20Bqm/DP7E6sa3wbQEO/hz
	C6chJrsqSDs4Jo4tLfTTDvm9Ty+J+5kiq1Al5CWuCuaEXKXmu/GYqMF2OfCuomNXIQofEcYgCr4g9
	gF35IArOw2F4IlJ1BDkidoiBYbMZpAfH8eGDARSL+aX6fJ6Xd0ZfmHFw8PAK+1uX/f2c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173991-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 173991: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:build-amd64:xen-build:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5310a3aa5026fb27d6834306d920d6207a1e0898
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 14:31:47 +0000

flight 173991 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173991/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 173457
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173973

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173973 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173973 never pass

version targeted for testing:
 xen                  5310a3aa5026fb27d6834306d920d6207a1e0898
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   38 attempts
Testing same since   173776  2022-10-14 21:00:25 Z    2 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  fail    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-amd64-libvirt                                     blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 938 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 14:37:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 14:37:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424453.671874 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okRFB-0000yk-1L; Mon, 17 Oct 2022 14:37:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424453.671874; Mon, 17 Oct 2022 14:37:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okRFA-0000yd-U8; Mon, 17 Oct 2022 14:37:28 +0000
Received: by outflank-mailman (input) for mailman id 424453;
 Mon, 17 Oct 2022 14:37:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okRFA-0000yX-DQ
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 14:37:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okRF6-0000fo-LA; Mon, 17 Oct 2022 14:37:24 +0000
Received: from [15.248.2.60] (helo=[10.24.67.16])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okRF6-000200-Ew; Mon, 17 Oct 2022 14:37:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=8b037JLSQJc43HxROy4cDNwcV4xuknK+443YRIWVIC4=; b=mfMh9HPqDCq2jwLngJbDyPqJ7M
	E4QtFETu7F7H9XKz4/0vsJQ673lzKx4mOYwjsc6yaRLW9PKODAPcegR79EOtwAUXYoNQJqp6XE/Yi
	hVQUn+XbWIBdmAiSES+YY/mkIQq22S2kTyQNwTiaVCG0Fa/P1zK5d5kQRzlYeZbHe3Ug=;
Message-ID: <4060025b-c155-c4e3-1a40-bb772d772d8d@xen.org>
Date: Mon, 17 Oct 2022 15:37:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on
 Arm
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <jgrall@amazon.com>, xen-devel@lists.xenproject.org,
 Henry Wang <Henry.Wang@arm.com>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20220716145658.4175730-1-olekstysh@gmail.com>
 <20220716145658.4175730-2-olekstysh@gmail.com>
 <df56f268-59d8-4b9a-52a6-40bfd0b91414@suse.com>
 <acedd354-9050-5340-ffd8-259aeb95b101@xen.org>
 <77349d2b-de72-3e68-362a-493f350eeec4@suse.com>
 <d297735d-771e-22f2-1b46-9c390ebb5afd@xen.org>
 <fc706330-d014-0fd6-4e99-27773f1d78af@suse.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <fc706330-d014-0fd6-4e99-27773f1d78af@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 17/10/2022 14:46, Jan Beulich wrote:
> On 11.10.2022 15:33, Julien Grall wrote:
>> On 11/10/2022 14:28, Jan Beulich wrote:
>>> On 11.10.2022 15:01, Julien Grall wrote:
>>>> On 11/10/2022 12:59, Jan Beulich wrote:
>>>>> On 16.07.2022 16:56, Oleksandr Tyshchenko wrote:
>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>
>>>>>> Rework Arm implementation to store grant table frame GFN
>>>>>> in struct page_info directly instead of keeping it in
>>>>>> standalone status/shared arrays. This patch is based on
>>>>>> the assumption that a grant table page is a xenheap page.
>>>>>>
>>>>>> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
>>>>>> to hold 52-bit/28-bit + extra bit value respectively. In order
>>>>>> to not grow the size of struct page_info borrow the required
>>>>>> amount of bits from type_info's count portion which current
>>>>>> context won't suffer (currently only 1 bit is used on Arm).
>>>>>
>>>>> I'm afraid this isn't true: There's no requirement for a guest to pass
>>>>> all different GFNs to VCPUOP_register_vcpu_info, yet map_vcpu_info()
>>>>> tries to obtain a reference for every vCPU.
>>>>
>>>> AFAIU, this would be a reference of the **count_info** not **type_info**
>>>> (which BTW will never be incremented on Arm because we have no type
>>>> support).
>>>
>>> I should have said "obtain a writable type reference".
>>
>> Thanks for the clarification.
>>
>>>
>>>> The commit message is only referring to the 'type_info's count'. So...
>>>>
>>>>> With my adding of GFN
>>>>> (really gaddr) based registration of the runstate area (already
>>>>> looking towards 4.18) the maximum possible count is to further grow.
>>>>
>>>> ... I am not sure which problem you are referring too.
>>>
>>> Wow - a mere stub (but not inline) function to make the build happy.
>>> Then why is the description talking about one bit that's needed on
>>> Arm?
>>
>> Because share_xen_page_with_guest() will always set the type info's
>> count to 1.
>>
>> TBH I don't exactly know why we set it. I always assumed this was a
>> requirement for the common code but never checked.
> 
> So my first thought was that this type-ref handling all being no-ops
> would be an issue with gnttab v2, but besides that not being security
> supported on Arm the code also passes SHARE_rw (for a reason that
> escapes me) when sharing the status pages.

Probably because grant-table v2 was never tested on Arm.

> 
> It does however mean that Dom0 can map the trace buffers r/w (unless
> there's some special code in Arm preventing that), despite them being
> shared with SHARE_ro. Not a big problem considering all the power Dom0
> has, but still against the intentions.

We don't use the refcounting but still use the flag PGT_writable_page to 
indicate whether the mapping is writeable or read-only.

The code to map the trace buffers will look at the flag and decide the 
attribute in the P2M.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 14:39:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 14:39:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424459.671884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okRGx-0001Zw-Cp; Mon, 17 Oct 2022 14:39:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424459.671884; Mon, 17 Oct 2022 14:39:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okRGx-0001Zp-AD; Mon, 17 Oct 2022 14:39:19 +0000
Received: by outflank-mailman (input) for mailman id 424459;
 Mon, 17 Oct 2022 14:39:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JD8j=2S=citrix.com=prvs=282fc9ee0=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1okRGv-0001Zj-TD
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 14:39:17 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 73e87f16-4e29-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 16:39:07 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73e87f16-4e29-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666017556;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=Udr5xcBpuMhUREWroW8bbC3VlmW0ewDShnmLc5/hScQ=;
  b=J/NsQrPGPP8NV+TeKPebA0pvj74dpKxgMszZyF4sTzE7lWuuMBv3rQOe
   DitMUp5bN2zOOFR/bHL/WTiR3ASRpG2tbCSvJdbJrHdXAy5+hJ8093TeF
   ph3vT66i9ZOJMDCqgTmJ1wyXSOFRddQe5WHIVZCk/f3uFbMDDBVrcMuG/
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 85434405
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Oc6VNavGiIBJghUiMDrHEZn06+fnVFheMUV32f8akzHdYApBsoF/q
 tZmKWrUO62CazekKt4iO4uy8xwOup/UzdNjQANo/ng1QSsa+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakU5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklI+
 8QpdXMObCveoLOL5aOndNhgofQKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI
 ZBDMHw2MUqGM0Yn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZUIwh3E+
 jqbl4j/KiEzJv6D42ClyG29uM3IhRnjRN5PKoTto5aGh3XMnzdOWXX6T2CTo/ajjVWlc8lCM
 EFS8S0rxYAt8GS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/
 gbXxZWzX2Up6eDLDyLGnluJkd+sES4bFV5fJiwGdlYisuTGsZ0Nvx7ofv82RcZZkebJMT33x
 jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV
 ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRz3pxZPnqgKulmSwXuF1e5dIFfUj
 Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMYsJVPaoX8yORPMt4wIrKTLufhlU
 ap3jO72VSpKYUiZ5GDeqxghPU8DmXllmDK7qWHTxBW7y7uODEOopUM+GALWNIgRtfrcyC2Mq
 oY3Cid/40gGOAEISnKMqtB7wJFjBSVTOK0aXOQOKbfdclc7RDp8YxITqJt4E7FYc21uvr+g1
 hmAtoVwkjITWVWvxd22V01e
IronPort-HdrOrdr: A9a23:F7tK7qBcPv6Xg8PlHemU55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P
 xG+85rsyMc6QxhPE3I9urtBEDtexzhHNtOkPAs1NSZLWzbUQmTXeJfBOLZqlWKcUDDH6xmpM
 VdmsBFeaXN5DNB7foSjjPXL+od
X-IronPort-AV: E=Sophos;i="5.95,191,1661832000"; 
   d="scan'208";a="85434405"
Date: Mon, 17 Oct 2022 15:39:06 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH for-4.17 v5 14/17] libs/light: Rework targets
 prerequisites
Message-ID: <Y01pCiLyPPEXVtVp@perard.uk.xensource.com>
References: <20221013130513.52440-1-anthony.perard@citrix.com>
 <20221013130513.52440-15-anthony.perard@citrix.com>
 <d6e4825f-6fd3-b48b-7a7b-e4f62acadd38@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d6e4825f-6fd3-b48b-7a7b-e4f62acadd38@citrix.com>

On Fri, Oct 14, 2022 at 07:35:20PM +0000, Andrew Cooper wrote:
> On 13/10/2022 14:05, Anthony Perard wrote:
> > No need for $(AUTOSRCS), GNU make can generate them as needed when
> > trying to build them as needed when trying to build the object. Also,
> > those two AUTOSRCS don't need to be a prerequisite of "all". As for
> > the "clean" target, those two files are already removed via "_*.c".
> >
> > We don't need $(AUTOINCS) either:
> > - As for both _libxl_savm_msgs*.h headers, we are adding more
> >   selective dependencies so the headers will still be generated as
> >   needed.
> > - "clean" rule already delete the _*.h files, so AUTOINCS aren't needed
> >   there.
> >
> > "libxl_internal_json.h" doesn't seems to have ever existed, so the
> > dependency is removed.
> >
> > Add few prerequisite for "libxl_internal.h" so all headers that it
> > depends on should be generated. And have $(SAVE_HELPER_OBJS) depends
> > on "libxl_internal.h".
> >
> > Rework objects prerequisites, to have them dependents on either
> > "libxl.h" or "libxl_internal.h". "libxl.h" is not normally included
> > directly in the source code as "libxl_internal.h" is used instead. But
> > we are adding "libxl.h" as prerequisite of "libxl_internal.h", so
> > generated headers will still be generated as needed.
> >
> > "testidl.c" doesn't depends on "libxl.h" but "testidl.o" does.
> 
> I'm afraid I don't follow here.� How can this be true?

>From make point-of-view, in order to generate "testidl.c", we only need
to execute "gentest.py" which takes "libxl_types.idl" as input. It
doesn't even matter if "libxl.h" exist when generating "testidl.c" via
`make testidl.c`.

"libxl.h" is only used later when compiling "testidl.c" into
"testidl.o".

I can probably expand the commit message to better explain this.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 15:22:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 15:22:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424467.671901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okRvx-0006pt-Ku; Mon, 17 Oct 2022 15:21:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424467.671901; Mon, 17 Oct 2022 15:21:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okRvx-0006pm-He; Mon, 17 Oct 2022 15:21:41 +0000
Received: by outflank-mailman (input) for mailman id 424467;
 Mon, 17 Oct 2022 15:21:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okRvv-0006pg-Kh
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 15:21:39 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6287fee4-4e2f-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 17:21:36 +0200 (CEST)
Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 17 Oct 2022 11:21:24 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA0PR03MB5658.namprd03.prod.outlook.com (2603:10b6:806:c0::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct
 2022 15:21:21 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 15:21:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6287fee4-4e2f-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666020095;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=0IcUiJORuMDR/agsdZ1gz2t5aO2YlUAO+ABXp8idr2g=;
  b=BXWA5YTobYAZJo6gkxI7k3Yk0TTBdWnplljorzoez4K7FJo5N+9a1qZL
   l6VoZxBkDlj3AUPkgjawRm2uXwefMqKQumgr/5A90f4IuByPmylpGxxz0
   2j+09bPYMRnhNXS1rf1zMqDIDrw0Lee67CBi+wOip7LDTYpzbG/KybZpG
   I=;
X-IronPort-RemoteIP: 104.47.55.100
X-IronPort-MID: 85438512
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:GDaHWaCYlbsbBRVW/6Tiw5YqxClBgxIJ4kV8jS/XYbTApDMn0jAEx
 2QeXWGOa67YYjHwc4gjPIm/9R4F6J+ExoJnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K2t4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kONKkV2rgpBFhFt
 t4dJGFKSQ+7u7KPlefTpulE3qzPLeHNFaZG4jRF8mucCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAF7gvN/cLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toi/w3b+SxHmTtIQ6BZ+k36A2gGWpmUMQCF47aXGds+mpoxvrMz5YA
 wlOksY0loAS+UqxX5/CVhu3iHeeu1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvBHidzubeYTXac8La8rj6oPyURa2gYakcsTxYB4tTliJE+iFTIVNkLOKS4lMHvEDf8h
 TWDtjEjhq47hNQOka68+DjvnD+t4JPJQwgd7x/SGGmi62tRWomhYIC57EnB2txJJo2ZU1qps
 WANno6V6+VmMH2WvCmEQeFIGa7z4f+AaWXYmQQ2R8Fn8Cmx8Xm+e4wW+Ct5OEpiLscDf3nuf
 VPXvgRSopRUORNGcJNKXm54MOxypYCIKDgvfqm8ggZmCnSpSDK6wQ==
IronPort-HdrOrdr: A9a23:I/973aGpXB3HFi4spLqFS5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq
 iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO
 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46
 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ
 HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8
 o=
X-IronPort-AV: E=Sophos;i="5.95,191,1661832000"; 
   d="scan'208";a="85438512"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CbLKSRKFY1FEJvA4IM1rPrNDZ44MRWUe0ibr0Tyn9IkZXZ8o1jxW0VNxZzYBeSaB1+cb5R2uPwvrPRdJX+RVqeooiMcqikoUB7OEM5JQVJzWyLb18A6Exn+XaiZDiCnUkuiuutxdCog4Mtj9p37KfRHM3C5TIzcSGSgN+CsgSHqXaDX8OZ8hyvyG3pyS7fsZtyRo7k0rsY2k+s+QoM5Krt1SFNe0Ex6ItZlA2tIDCegP4dCs2wWu1rTiei/4yDC2KEI1A4KuvWZAglEVWhF/2nQiFdaI34QzjmKQPnHPMIJg8vHnrPU4O2KOQsVF9Q8KQ3GehGYwyKr+LlRpLNq3eQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0IcUiJORuMDR/agsdZ1gz2t5aO2YlUAO+ABXp8idr2g=;
 b=LFc04CgiWX6KhauzfRDBhByPfxYyoOxrkImxZTRd3OPXsZiTrMQTuUe8piIPL6Y7J7AsxDGOreH1XyqCt1Yn3Kedzi2ZUhGq/P8Pu4OMTIJsLSJ0LdCFqtAT+kUWLlJ7wVtQ2w94VUR443sfMtCCFHgKlvufMknEX/VFMmnI1FJrmTsg2Nfy8c4W2dcFhgn2uUEQitWeIRzyfkO5FB67nE39jbHha4cjzNkUqXuVFBbMivpUxkivaIuupedCqddlQzKbjEqNNhXTXjTCffJQTdTFy8lOINa8/QzRbIoiYewSFC6ugHzxaYdIi6XInhqY6HdhAe6ADoEye1wEiBUEQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0IcUiJORuMDR/agsdZ1gz2t5aO2YlUAO+ABXp8idr2g=;
 b=JLfXXjIgIOGta8IAuknTNOjOySRYofJeE5ekajLpD+lsyOAGhOTdwfQGgfTOGT2cOygxNn+L5X/EqIupqON9VZ3nUtHF9RmL+hdOlkTEhVl2U/weNKCsoY+zBOei+6dqe4DnrX6ZaINmkvBX/DsGbMG/CZqDqdnD6MoWDFBMf8Q=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen
	<wei.chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4fyisutH9MvwK0CzzXPj4djvUK4StD+A
Date: Mon, 17 Oct 2022 15:21:21 +0000
Message-ID: <394c1a33-9549-77b2-6981-65e69c292954@citrix.com>
References: <20221017074618.36818-1-Henry.Wang@arm.com>
In-Reply-To: <20221017074618.36818-1-Henry.Wang@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5658:EE_
x-ms-office365-filtering-correlation-id: ff414571-4771-40a4-28d9-08dab0533f25
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 TaQh1AyBxwaad1t6ZBWjYFoDimTqfXCMD+FLMjXOmuctmDQHZ5ZwClXw0on+CgR99abQEAN1wcc7x7BZFZo88VYKzmtAJt0O48lmmLoE3nflIm5mE2T1Rmn91S+2l4+6yVAo+L3/aJUrQzjMdQqzaJJcrWWH1s3MILaRl8e0/8hAY7IMetnCFeeaGASYDPfNsewPKMROcFWGfTVSNt/DigaLnP+Hx3J5vS4C/qEYu6ySGDdZViuzrIJiWM2qWKWvQhx0rqLOALerSXYq2L2mZE7vBG1BCbjrYKCOAGGOuNyCgbyFMfZ0rclfMzOttPV7DmYGfwGcb7jopLXR8xB+LS22fd7/PVRZHjIK7CVToVO4b14SowVbjykeu2txaK0E0lU7vjfWNfVHy+IRf2Uh3U0+nmjeIse02urgp7F7wsxitSXKz5qJNH7UlhXlErd75yJHW1dma5nlInUFUJ7TEhhAkgdtePtiPvupH7BtdNIa7wFcI3EUvoZ61ZtQLnszZJW0dVW8X/mvb+g9WOAwown5BgmE79ub5dlln4D5gQxw/6wFauzn2wDtD77zDiuvUrAed2MER1bFfclxkDRoLhuj+9TPqJgoqQF6jNri+PuSsPEKuHQxmIZ/d84lujG700SK78t6YldMOzeXKQep0oiCNFVEEEGRbvs9V83eLlVcjBQU1MJjgEQAyFpcZtyoADlB0Tf886YMtmBD58aKtcrSeCFPC6VZ6hbhdVWDpz0Ane1+jDG1/pTeK8DcP4VaD3kVMjpjQNNEKmurC7QqM/URCy5sWhEnm6W9NxqMLceoI3UFYmf3Q6C4b7S/af25gp+lOIBggd9XhtNNAheLgA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199015)(8676002)(91956017)(316002)(8936002)(66556008)(66946007)(4326008)(110136005)(41300700001)(66476007)(76116006)(31686004)(54906003)(64756008)(66446008)(5660300002)(38100700002)(2906002)(122000001)(71200400001)(38070700005)(6506007)(53546011)(6512007)(36756003)(31696002)(2616005)(82960400001)(26005)(86362001)(83380400001)(6486002)(478600001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?TUNkcVBzUmJ1d1lpQVl5RC90V0tVQUJZWjh6V1RidDJlV0JQbFFabGRyZkRO?=
 =?utf-8?B?MlFIU1NFZTMva1l1QUF0bWh2UEdCaFVxTk5DOGZDTVNZbGpMeFFlZzdMQ2t4?=
 =?utf-8?B?eVpkUkNIdHNTN1haZGN3UGJrNStoN3FodTQzU1Y2ZXhKMHI1THg5Q1JMemFJ?=
 =?utf-8?B?WDFHSTZiSlF2L0U3djVmMlM2cTF6OUF1SDNXelNhT3p4RzdUald5elhYY1VT?=
 =?utf-8?B?VFdKU0xVTEptTE80UUNCdjMzSjFSckhlSVl3S01YWmlGbldtY1hxZDhuMExa?=
 =?utf-8?B?Rml1bXdYcEVqSkdUZ2F6RGZ1T3VPeFJZbUNmeTI0NWtoTkxuQjhzNGlrYlFV?=
 =?utf-8?B?eTBzdzZQbFY4cjlYRmRld003L1RwYTRBejR4RVpqUDZCMDRlT2RJWjEwRVBD?=
 =?utf-8?B?bXFpUHUvNkJMYXpRb0kyWWtueTZTaXNnUThTWGd6QXVXYkcvWXN0ZTRHQkxO?=
 =?utf-8?B?WFM1cG5UWHNYQk8vU2hOWGFwUGJuckdvN0R1ZFZuYnRBUjFhSVBQeE9DejJw?=
 =?utf-8?B?OHU4Y3VicDdZWjgwYnFyYnhJTDlnRHI2NHYrNXF2d3RqSEd3Zkxtc3NDeXNn?=
 =?utf-8?B?TFBaR3NIamJaTGU2cXFPcy9Vd0FpYk4xNnFlRXFEbUt3Wnc2c1dwaFRWdDAv?=
 =?utf-8?B?VVRJK1JIa2ZOU0l0dy83b2svclBobm44dHgxdUhkMkE1bzRBMjBHTm5WVUtT?=
 =?utf-8?B?d3dTK3MwQjJobTFmQmhlUWQ0cEs5MldtZC9IbFpWV1RlK3pneXczNGhKNUNm?=
 =?utf-8?B?WU9pbWExSFVSVUpBWUw1d2tab2dPbjZNMVZKZmtHY1E0YmxtUW5TbTRTYlQ4?=
 =?utf-8?B?MkZsU3MxU0h2RDhyY20zSW5ONkg4YjRmUTJmcFhhaXdLMHM0MkI5WjM3ODB5?=
 =?utf-8?B?Y0tRVmF0N0ZWS3J0TGdCZGgrcmJaR01aZDB0bWJlZ0pjcHFtdkJKQ1MzbWtl?=
 =?utf-8?B?ZjVkQ2lNM3NoeW5zdzFrdXFoWndIY282SU82U3M2djVMT0syYVc0UVErMEdL?=
 =?utf-8?B?YkV4SUpia3c3NmROSGRqRjNSRGdxK2hkWFFNaVNNQkJIcHN3UEZFaml2MWZu?=
 =?utf-8?B?Nld6MGE3YlZzWWgvSnQ3N0I5bzd0ZU0xZUIrVzVCWUV4dzlwTVZuYk01MkFt?=
 =?utf-8?B?UU4zSGM0YnI1OGJKTHJQS2gxUmt4TFk1RkFKU2dyajhvMXpNdlBNc3lObDAw?=
 =?utf-8?B?Mk5sdEY2czZkNDZNRCtsZWUwNFhhZ29tNm5mS25FUzFGNCtWbVFoNmtjRHk5?=
 =?utf-8?B?ajBicUhoV3pNdlVtbEE2ODk3VURnOWMrWGFIM1Mwc0duZVE4eHVkUC9Nanc5?=
 =?utf-8?B?VW8rMk9iV1o5UXlCWnIxVkU3U04wbW13UGlVZ0F0ZERqT2dlL28zcXIyVlhU?=
 =?utf-8?B?WGZCWGlRWUQ1bWlxMGNtYWJXS0ZYc2V5RTVIMWppZ2RIdk0ra1kxa2dqRlhW?=
 =?utf-8?B?OUFUakpnNjJjZGljNnVENmhleGJjL2VVU0pwR2dEQncvNm9rQWlmWWt5Kzds?=
 =?utf-8?B?YXZiYWRidGo3bThXZHp0K2ZQY3dTUVc5MEIraVM3bVdna0srU09mQ1dDUHBC?=
 =?utf-8?B?ZHVSVVVWbzhpRVcydVcrTitRMUZJRTZwcDlhUlE0VTdiZUlwYzhVWncvWjNT?=
 =?utf-8?B?MGt1UWluUTZ6bC9TMm41ZjFMSEVvRTFSZysrV2pVWlBQYzVpOVVZVlhiRjZN?=
 =?utf-8?B?QTFSQkYyZFJObWRWdFV1RHZSbmt5OWNlazBhMW4xMnBuUHRoeFBSK1VrK1dK?=
 =?utf-8?B?Y1Vtd0c4cElTbGpUTWlMMzhlZVZFY3Q0d0ZQVTdndzBIWm81NUFwK0JVU2c1?=
 =?utf-8?B?ZEFrTjI3YW0yOE5VZUtKTzROa2RsR2RjdFBaY1NvQXovYklDZWl2bVJUaWJG?=
 =?utf-8?B?T2Nxdy9mNEVrOVg3RktndzUvNHpqaVJlZDVMQ1B0NUxSaHBRMEN5ZVZKTWZD?=
 =?utf-8?B?eEoxZVhDc2FwRWovMVdSclczVTRLZTcybVdJbmpqczJMeXJDV0pmZDJ1RXF6?=
 =?utf-8?B?M2dpL0dMYVZjdVpkU0hydUdoekpNeXE1SDhiRHdJa1Niek04eXl2MUZuUFVI?=
 =?utf-8?B?ajFaQ0xRK0xidC9IM2lLd2JFR3c3ZWg1NFpsanlVMm9PMkVYOUpHeW9yNGdP?=
 =?utf-8?Q?PULAY6JaWQDtAPlN4MG5ICNkV?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4330D1ABC1093146BD282BC3EBF9B305@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff414571-4771-40a4-28d9-08dab0533f25
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 15:21:21.3895
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vObA4/AhNqfNgm8+jHsE+/Rs1vlonPz5MCvS4jyjTICCSFrz0SGwHcVVwl49sHiCQtHcE/njNivWZqhUkj249AUX02Vz6F7n/5HTVQHymPw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5658

T24gMTcvMTAvMjAyMiAwODo0NiwgSGVucnkgV2FuZyB3cm90ZToNCj4gZGlmZiAtLWdpdCBhL3hl
bi9hcmNoL2FybS9wMm0uYyBiL3hlbi9hcmNoL2FybS9wMm0uYw0KPiBpbmRleCBmMTc1MDBkZGYz
Li44YzlkZGY1OGUxIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMNCj4gKysrIGIv
eGVuL2FyY2gvYXJtL3AybS5jDQo+IEBAIC0xNzM2LDcgKzE3MzksMjAgQEAgdm9pZCBwMm1fZmlu
YWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkNCj4gICAgICBpZiAoICFwMm0tPmRvbWFpbiAp
DQo+ICAgICAgICAgIHJldHVybjsNCj4gIA0KDQpFdmVyeXRoaW5nIGJlbG93IGhlcmUgaXMgImRl
YWQiIGNvZGUsIGJlY2F1c2UuLi4NCg0KDQo+ICsgICAgLyoNCj4gKyAgICAgKiBObyBuZWVkIHRv
IGNhbGwgcmVsaW5xdWlzaF9wMm1fbWFwcGluZygpIGhlcmUgYmVjYXVzZQ0KPiArICAgICAqIHAy
bV9maW5hbF90ZWFyZG93bigpIGlzIGNhbGxlZCBlaXRoZXIgYWZ0ZXIgZG9tYWluX3JlbGlucXVp
c2hfcmVzb3VyY2VzKCkNCj4gKyAgICAgKiB3aGVyZSByZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkg
aGFzIGJlZW4gY2FsbGVkLCBvciBmcm9tIGZhaWx1cmUgcGF0aCBvZg0KPiArICAgICAqIGRvbWFp
bl9jcmVhdGUoKS9hcmNoX2RvbWFpbl9jcmVhdGUoKSB3aGVyZSBtYXBwaW5ncyB0aGF0IHJlcXVp
cmUNCj4gKyAgICAgKiBwMm1fcHV0X2wzX3BhZ2UoKSBzaG91bGQgbmV2ZXIgYmUgY3JlYXRlZC4g
Rm9yIHRoZSBsYXR0ZXIgY2FzZSwgYWxzbyBzZWUNCj4gKyAgICAgKiBjb21tZW50IG9uIHRvcCBv
ZiB0aGUgcDJtX3NldF9lbnRyeSgpIGZvciBtb3JlIGluZm8uDQo+ICsgICAgICovDQo+ICsNCj4g
KyAgICBCVUdfT04ocDJtX3RlYXJkb3duKGQsIGZhbHNlKSk7DQo+ICAgICAgQVNTRVJUKHBhZ2Vf
bGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOw0KPiArDQo+ICsgICAgd2hpbGUgKCBwMm1fdGVhcmRv
d25fYWxsb2NhdGlvbihkKSA9PSAtRVJFU1RBUlQgKQ0KPiArICAgICAgICBjb250aW51ZTsgLyog
Tm8gcHJlZW1wdGlvbiBzdXBwb3J0IGhlcmUgKi8NCj4gICAgICBBU1NFUlQocGFnZV9saXN0X2Vt
cHR5KCZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxpc3QpKTsNCj4gIA0KPiAgICAgIGlmICggcDJt
LT5yb290ICkNCj4gQEAgLTE3NjIsNiArMTc3OCwyMCBAQCBpbnQgcDJtX2luaXQoc3RydWN0IGRv
bWFpbiAqZCkNCj4gICAgICBJTklUX1BBR0VfTElTVF9IRUFEKCZwMm0tPnBhZ2VzKTsNCj4gICAg
ICBJTklUX1BBR0VfTElTVF9IRUFEKCZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxpc3QpOw0KPiAg
DQo+ICsgICAgLyoNCj4gKyAgICAgKiBIYXJkd2FyZSB1c2luZyBHSUN2MiBuZWVkcyB0byBjcmVh
dGUgYSBQMk0gbWFwcGluZyBvZiA4S0IgR0lDdjIgYXJlYQ0KPiArICAgICAqIHdoZW4gdGhlIGRv
bWFpbiBpcyBjcmVhdGVkLiBDb25zaWRlcmluZyB0aGUgd29yc3QgY2FzZSBmb3IgcGFnZQ0KPiAr
ICAgICAqIHRhYmxlcyBhbmQga2VlcCBhIGJ1ZmZlciwgcG9wdWxhdGUgMTYgcGFnZXMgdG8gdGhl
IFAyTSBwYWdlcyBwb29sIGhlcmUuDQo+ICsgICAgICogRm9yIEdJQ3YzLCB0aGUgYWJvdmUtbWVu
dGlvbmVkIFAyTSBtYXBwaW5nIGlzIG5vdCBuZWNlc3NhcnksIGJ1dCBzaW5jZQ0KPiArICAgICAq
IHRoZSBhbGxvY2F0ZWQgMTYgcGFnZXMgaGVyZSB3b3VsZCBub3QgYmUgbG9zdCwgaGVuY2UgcG9w
dWxhdGUgdGhlc2UNCj4gKyAgICAgKiBwYWdlcyB1bmNvbmRpdGlvbmFsbHkuDQo+ICsgICAgICov
DQo+ICsgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsNCj4gKyAgICByYyA9IHAy
bV9zZXRfYWxsb2NhdGlvbihkLCAxNiwgTlVMTCk7DQo+ICsgICAgc3Bpbl91bmxvY2soJmQtPmFy
Y2gucGFnaW5nLmxvY2spOw0KPiArICAgIGlmICggcmMgIT0gMCApDQo+ICsgICAgICAgIHJldHVy
biByYzsNCg0KLi4uIHRoaXMgZWFybHkgZXhpdCBpcyBhaGVhZCBvZiBwMm1faW5pdCgpIHNldHRp
bmdzIHAybS0+ZG9tYWluID0gZC4NCg0KSW4gcGFydGljdWxhciwgeW91IGludHJvZHVjZSBhIGJ1
ZyB3aGVyZWJ5IC4uLg0KDQo+ICsNCj4gICAgICBwMm0tPnZtaWQgPSBJTlZBTElEX1ZNSUQ7DQo+
ICANCj4gICAgICByYyA9IHAybV9hbGxvY192bWlkKGQpOw0KDQouLi4gdGhpcyBlcnJvciBwYXRo
IG5vdyBsZWFrcyB0aGUgMTYgcGFnZSBwMm0gYWxsb2NhdGlvbi4NCg0KDQpUaGlzIGNoYW5nZSBp
cyBvdmVybHkgY29tcGxleC7CoCBZb3UgYWRkIGEgc2V0X2FsbG9jYXRpb24oMTYpIHBhdGggaW4N
CnAybV9pbml0KCksIHNvIHNob3VsZCBvbmx5IGJlIGFkZGluZyBhIHNpbmdsZSBzZXRfYWxsb2Nh
dGlvbigwKSB0bw0KY29tcGVuc2F0ZS4NCg0KVGhlIGB3aGlsZSAoIHAybV90ZWFyZG93bl9hbGxv
Y2F0aW9uKGQpID09IC1FUkVTVEFSVCApIGNvbnRpbnVlO2AgaXMNCmVzcGVjaWFsbHkgc2lsbHkg
YmVjYXVzZSB5b3UncmUgc3BlY2lmaWNhbGx5IHdhc3RpbmcgdGltZSBpZ25vcmluZyB0aGUNCnBy
ZWVtcHRpb24gd3JhcHBlciBhcm91bmQgdGhlIG5vbi1wcmVlbXB0aWJsZSBmdW5jdGlvbiB0aGF0
IHlvdSBhY3R1YWxseQ0Kd2FudCB0byB1c2UuDQoNCkxvb2tpbmcgYXQgYmV0d2VlbiA0LjEzIGFu
ZCBzdGFnaW5nLCB5b3Ugd2FudCB0byBiZSBjYWxsaW5nDQpzZXRfYWxsb2NhdGlvbigwKSBpbiBw
Mm1fZmluYWxfdGVhcmRvd24oKSBhaGVhZCBvZiBvZiB0aGUgcC0+ZG9tYWluDQpjaGVjay7CoCBF
eGNlcHQgaWRlbXBvdGVuY3kgd2hpY2ggaXMgZ29pbmcgdG8gYmUgaXJyaXRhdGluZyBoZXJlLg0K
DQpJdCB3aWxsIGJlIGEgbm8tb3AgZnJvbSB0aGUgbm9ybWFsIGRvbWFpbiBkZXN0cm95IHBhdGgg
KGFzIHJlbGlucXVpc2gNCnJlc291cmNlIHdpbGwgaGF2ZSBlbXB0aWVkIHRoZSB3aG9sZSBwb29s
KSwgd2hpbGUgaW4gZG9tYWluX2NyZWF0ZSBlcnJvcg0KcGF0aCwgaXQgaGFzIGEgbWF4aW11bSBv
ZiAxNiBwYWdlcyB0byByZWxlYXNlLg0KDQpJJ2xsIGRyYWZ0IGEgcGF0Y2guDQoNCn5BbmRyZXcN
Cg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 15:30:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 15:30:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424475.671919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okS4X-0008Na-I9; Mon, 17 Oct 2022 15:30:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424475.671919; Mon, 17 Oct 2022 15:30:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okS4X-0008NT-FI; Mon, 17 Oct 2022 15:30:33 +0000
Received: by outflank-mailman (input) for mailman id 424475;
 Mon, 17 Oct 2022 15:30:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okS4V-0008NN-Ix
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 15:30:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okS4V-0001cV-5h; Mon, 17 Oct 2022 15:30:31 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.28.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okS4U-0004gi-TF; Mon, 17 Oct 2022 15:30:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=RQWPAod5zPYOTu0wfDlA767sF3cSMeGzOoDOveLZvqg=; b=LhwmVUejmnxmQ5bdxarhyPo52Q
	NBBkVqYVlW1HzULyUpYn0WUECN9atdcVMBZwK8WX9vhNbSb9kEpsXJYSISOLLkUeeMH2WjR5YU98t
	jZaYrB8UVMP4nlOn92xzyBJfvHUpBBxlqbajiJyZbLoN41YeqJXjyahMMuFU8JLaWrXg=;
Message-ID: <69fbbfef-b91a-25cd-bf72-017f1f789f77@xen.org>
Date: Mon, 17 Oct 2022 16:30:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
 <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017074618.36818-1-Henry.Wang@arm.com>
 <394c1a33-9549-77b2-6981-65e69c292954@citrix.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <394c1a33-9549-77b2-6981-65e69c292954@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andrew,

On 17/10/2022 16:21, Andrew Cooper wrote:
> On 17/10/2022 08:46, Henry Wang wrote:
> Looking at between 4.13 and staging, you want to be calling
> set_allocation(0) in p2m_final_teardown() ahead of of the p->domain
> check.

Hmm... IIUC, you are suggesting the following code:

p2m_set_allocation(0);

if ( p->domain )
   return;

If yes, this is in theory not safe because 'p2m' is technically not 
initialized. All the list use are thankfully protected with zeroed 
field. But this is quite fragile.

I think it would be better if p->domain is set ahead of the first error 
returned in p2m_init().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 15:38:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 15:38:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424482.671930 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSCU-0000lC-HN; Mon, 17 Oct 2022 15:38:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424482.671930; Mon, 17 Oct 2022 15:38:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSCU-0000l5-DQ; Mon, 17 Oct 2022 15:38:46 +0000
Received: by outflank-mailman (input) for mailman id 424482;
 Mon, 17 Oct 2022 15:38:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okSCT-0000kv-Mk; Mon, 17 Oct 2022 15:38:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okSCT-0001lW-D8; Mon, 17 Oct 2022 15:38:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okSCS-0006gF-UH; Mon, 17 Oct 2022 15:38:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okSCS-0005Ea-Tp; Mon, 17 Oct 2022 15:38:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GrMtodu0drNA+sOeAYnwgpPBlVAt8c6UD+EFuE6BCks=; b=FaseUg/a+ZuKsuW/d2FK7IOnps
	HqUBGTFRUmSAHMBW/NMJhPnQbVU8Le5HixJA9BtUysc/kaOgfkG4GnVIMFSvusc/YXjP9l1/5jdhy
	3tPlQg2RFBWk4toAwL+59INV+diMIvNOHGfufeGiMFZoWcS01NEbdVorqmplRXuplqb8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173906-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 173906: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:windows-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 15:38:44 +0000

flight 173906 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173906/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 173906
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 173906
 test-amd64-i386-xl-qemuu-win7-amd64 12 windows-install fail in 173799 pass in 173906
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  7 xen-install fail pass in 173799
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 173799
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 173799

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1   3 hosts-allocate           starved in 173799 n/a
 test-arm64-arm64-libvirt-raw  3 hosts-allocate           starved in 173799 n/a

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   63 days
Failing since        173496  2022-10-11 14:08:01 Z    6 days    7 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    4 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 15:44:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 15:44:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424492.671947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSI8-0002CU-88; Mon, 17 Oct 2022 15:44:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424492.671947; Mon, 17 Oct 2022 15:44:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSI8-0002CN-4z; Mon, 17 Oct 2022 15:44:36 +0000
Received: by outflank-mailman (input) for mailman id 424492;
 Mon, 17 Oct 2022 15:44:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okSI7-0002CH-4n
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 15:44:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okSI6-0001r3-RR; Mon, 17 Oct 2022 15:44:34 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.28.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okSI6-0005YK-Kw; Mon, 17 Oct 2022 15:44:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=/xuBuoMqB4hdz+Ie3uwYj/llYSc2NJLicPHD7Cw+eKs=; b=BurSefkm63mghCCJCeuPIZq1Sr
	bzGPN9qtQ7IASBhuF3hR+SvsewYQnktK6jyuOJ5VUNYORRs+y6nAvLnPqWlEBBr4JFnptod46mtLD
	sUE1Zpk1Xg+DFhcVMp67mkIJW9tueXraKFbaiD1QHJac8ASv7hd/UEVPr48KYCJRO+bg=;
Message-ID: <a03729ef-0883-c535-d971-3c265de6b69e@xen.org>
Date: Mon, 17 Oct 2022 16:44:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017074618.36818-1-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221017074618.36818-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 17/10/2022 08:46, Henry Wang wrote:
>       if ( p2m->root )
> @@ -1762,6 +1778,20 @@ int p2m_init(struct domain *d)
>       INIT_PAGE_LIST_HEAD(&p2m->pages);
>       INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist);
>   
> +    /*
> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> +     * when the domain is created. Considering the worst case for page
> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
> +     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
> +     * the allocated 16 pages here would not be lost, hence populate these
> +     * pages unconditionally.
> +     */
> +    spin_lock(&d->arch.paging.lock);
> +    rc = p2m_set_allocation(d, 16, NULL);
> +    spin_unlock(&d->arch.paging.lock);
> +    if ( rc != 0 )
> +        return rc;


p2m_set_allocation() wants to be called after 'p->domain' is set. So 
p2m_teardown_final() will not return early and leak memory (as Andrew 
pointed out).

For simplicity I would move the code right at the end of the function. 
But if you want to keep it here then...

> +
>       p2m->vmid = INVALID_VMID;

... this needs to be done first as well.

>   
>       rc = p2m_alloc_vmid(d);

Note that if you move the code at the end. Then you will need to add:

if ( rc )
   return rc;

after the call to p2m_alloc_table();

Other than that the code looks good to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 15:54:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 15:54:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424500.671964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSRb-0003lH-A0; Mon, 17 Oct 2022 15:54:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424500.671964; Mon, 17 Oct 2022 15:54:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSRb-0003lA-6U; Mon, 17 Oct 2022 15:54:23 +0000
Received: by outflank-mailman (input) for mailman id 424500;
 Mon, 17 Oct 2022 15:54:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okSRZ-0003l4-Mb
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 15:54:21 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20063.outbound.protection.outlook.com [40.107.2.63])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f59aec8f-4e33-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 17:54:19 +0200 (CEST)
Received: from DB7PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:10:36::37)
 by AS8PR08MB6022.eurprd08.prod.outlook.com (2603:10a6:20b:295::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 15:54:17 +0000
Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:36:cafe::bf) by DB7PR05CA0024.outlook.office365.com
 (2603:10a6:10:36::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Mon, 17 Oct 2022 15:54:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 15:54:17 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Mon, 17 Oct 2022 15:54:17 +0000
Received: from c2de487274a2.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 750FC7A4-B222-47F3-8FEF-EBC52EDEE1C6.1; 
 Mon, 17 Oct 2022 15:54:06 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2de487274a2.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 17 Oct 2022 15:54:06 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9868.eurprd08.prod.outlook.com (2603:10a6:20b:5ac::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct
 2022 15:54:05 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.032; Mon, 17 Oct 2022
 15:54:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f59aec8f-4e33-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=XsQaHp1wAKtAbsjgDIbxubearosftaXWUWc1fT3HOOAqGeNyfHLkKatutRtYlDLCFgKc0vle+IHmJDF0b5rfwyAhNiw4tqTLDR1gN+WtkRlHf2ukNZ6vSmhrDnHT3jkrM5qEsvU8WGyNrkxYdazzU0Biv7r+cbNbIHJPY5doZZrLl6cd0IYfKhwSzAis0T3xlWDY5BuKRtNi7ChdGjgIZT3kacwBpCIWPpZ28FR2eKnuCJ6/Dq9rcIU/IU+7CLqBWPnM1sy8KKt3xLABg6VI4LxL5k6l+OXpq7MwGRBmACsT4w3UDquTxn+B/6lRNuG7imz94UuTGuiKAZs7vv3KrA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CFdxsbDalMzwVZO0L318eW7ifMyVW7uS8kLd+vdvrl4=;
 b=H4DAkZHvxBFdDjSdO97m5/ppHoMcw4+IJFDnwiioWCJ8In8oHf95pE4Us/OHbeFIGVj1v0VPPFEt3qhcC9rYenjYIV8wmE+9W24ODvlo2LblEzqP4f48av4Kr2nrrYnERgXa14Z1nbSz3GZVw85f2sKZGEMMnITH4Gxo3+yCLDVmustCbH4D+G7mRxsEooFHV/eyLFvpAK3fyA2llgKw5L8nHzLf9Pixoqz40Np68C6J+I6WzznDuUK0Kn11QEFzbXjTHBWP36e0VPmD9PeQZysb8YgpTgvnD7zytMCL5pwvhOdJWR98r0LBnWv3cXBOb43OZ+oEUs09cvlpEGujvA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CFdxsbDalMzwVZO0L318eW7ifMyVW7uS8kLd+vdvrl4=;
 b=wZ4vhKE/0JAZF6XzK1dkfnjpIIwPoJZcsLoOTP8jxOdrQvioAvbgAU5ozV/1F0adZlFMR6qGWn0yQL5jut9ywaYPRvaCnhbqMxEKbjhfDmnXWqzrSMqqV11oDAzdnAkFJLstpmpJcZOMFq1HyYuCYyBkSihWN0MO7fsexpdzseU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jkY9N/OJLiCnfETbHwecTAEO0ZdnPXTupz1ueKgRScBPrL/XM1MctzrlLuHsY3aNb9aRLctd+Kg7l4l4FfyFVUcC8Z/Z/8wI3hXUQk5PcVTQ8Wdxu+r4hyDLViwinTraA7vePRpvpbUa+8dDCyyupzaeAcJOzrflYLWRa71S/7x4j4A71Q/k2yfKgF5neJq41dIHAc55vE3h+3IYlyamfAbhK6sxc2EedvvYi7oWwBTzwFT/yzbKph0oH1mYh8IV9yLF99Bvn65YfGph5tLy3z/0oQ3O63Rsd/YLqFLqH3OMl3JqwLwHgvQvvXTS9kSA5tlr749mUV50eNYD8DDZxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CFdxsbDalMzwVZO0L318eW7ifMyVW7uS8kLd+vdvrl4=;
 b=Saz9qO69JNiNoYcBm663qr5Go5SlPUHh9r4IZitK39y83WlmoHRMRMc+sk6xPsvHCITlPqHSI3S+z6fSDEkMotukUQvI+rjhqObER738r1DdpMkerepNZKVOtFcqeF1jbUH11WNuNn2H/97vKeMrKzJOKdMty5blXOhhHoIDR2u+Q8AREojNhsKRi1lQvCyIU/awKNR0vCClKmyubC54cXP6vBBZ6Q32Tmb1PXf8nojWxXlsQNWON+EBzqxLSCWozEBMbLLgkUnhYXLJs9ZaXxX21oTJ3/O7Sm9tKoMaoZd1KvNQQ/BXNFvkt5KYXcX1m1wdijjSQB0lMi/twT1OUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CFdxsbDalMzwVZO0L318eW7ifMyVW7uS8kLd+vdvrl4=;
 b=wZ4vhKE/0JAZF6XzK1dkfnjpIIwPoJZcsLoOTP8jxOdrQvioAvbgAU5ozV/1F0adZlFMR6qGWn0yQL5jut9ywaYPRvaCnhbqMxEKbjhfDmnXWqzrSMqqV11oDAzdnAkFJLstpmpJcZOMFq1HyYuCYyBkSihWN0MO7fsexpdzseU=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v3] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4fyZYp3iu3IBsEeHODWajPdDU64SurkAgAABF9A=
Date: Mon, 17 Oct 2022 15:54:04 +0000
Message-ID:
 <AS8PR08MB79912598D9CF655D2B68C0E092299@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221017074618.36818-1-Henry.Wang@arm.com>
 <a03729ef-0883-c535-d971-3c265de6b69e@xen.org>
In-Reply-To: <a03729ef-0883-c535-d971-3c265de6b69e@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 68FEDEB3A00BC8489DECB1E642E8EBB6.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9868:EE_|DBAEUR03FT036:EE_|AS8PR08MB6022:EE_
X-MS-Office365-Filtering-Correlation-Id: 48b166e4-f0fa-4e7c-7fde-08dab057d8c7
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 foYUqy00+BIcvfKjsS/zXb3Vic0n2tnOBfQNBZDxSg9C5qd1OT3EwrO8J3Vawu2BO+cORd9ub+kwe9eM3LOCKUbpkTVsKZv99kVLEMrM0JiztGMwK65M6Bm5sXxhbpECKbTwZ1AbuIXwGvhk2W1LIT+bLNRVRw30kMD7lYZx92TjogEuh+tIwKgxRckP68U2ncLyDmxREeutEaBA3ra7sxRIMIy5t/3BglrCPjMFyKjTfvzwXJzN5QZggmG1oJ3ZuSXITpoHS8w7HKnEBAdNrJ9WgPJLPhEFQsHYRa1ZxAk4/QUgu6IYfknp/aNkW5nKn9Z8UHPORp4Eq5rpMnISZ720pVp44Wbp/+r0Bh+/GbS8eeVPu2Wjm6PmWxAG8NOAmRgNoreeCgU/13uJJIaTFF89d6ugZ83HeHA6Wgcz+9V6ZdK/+syBkwRfhRmux8ZfKLO4K6WffqcHxxCECBmoX0hoez1/KXNdVVSyvbot1Z54CKx1bpBDNKwB34F45vY9B3fehvOn48i8kcYg89RlqLn7WRv/vwbrR/t9KD+5Z42VgmKuo1zfxea1heZpeI1lSAsoDcjH01+nncqvckl8jN2NbbiccSRWM9gcTuQfpo+WNwUhic8e97KK3F+IldMmrm+drI4XPUppOwaEeYrYAK0R8Jqloy/KAx0mSR+EMwOWmaTMi0at1dP5fevf6iTSrLv91gd4YuE2s16GWkl/t1or+tLS3Yq3/Y5nCXBHHreun5TGHDEC3+IhVwpo3hT6stRGc549/3/8goMF7hwJLw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(86362001)(186003)(83380400001)(38070700005)(38100700002)(122000001)(52536014)(41300700001)(5660300002)(55016003)(8936002)(26005)(478600001)(71200400001)(6506007)(9686003)(53546011)(7696005)(4326008)(8676002)(76116006)(66556008)(66476007)(66446008)(64756008)(66946007)(2906002)(316002)(110136005)(54906003)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9868
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	51b1247d-25d9-496a-63b8-08dab057d181
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ROcMG9XHv2vIFEInhm8tVrRT26VhbomWautSmiuqT2fGuSqHBEy0O8Bnr3AOxCWKunO2x2lnoI0TR8VFj9tQXabCtm4BstEtT0AcCAuHxp1oN0mSKCZv65n3JnKb8YYzTZjpEjWBm4+sGIm5QmLJ5ragx+Q2QvzmKptKyR3z5FBIIPOcdC1t4oe/RDhZOSVQa3G6NNbzBVxF0jo6AG49/d2hRB0nOJMBL1JDtnTN8xxfDi9qND3G/RC6LLxpfNo/cv4CfMlr3Im5XvEYnx0fT21LZJeeqSskaWoRuymdh7cXoQjK5kfH7Jvdh7UgBBF+0ViEwgDKpO1BT+Zs6Efrr9wNkcFWoARPUW/Kh06lWH3mUG4eLSbe5NMjrbi4zwwmfZEHppkQPTELhERQeVPP7uN/2q4UAPNkfhR4ykHGijaBwp9X1LXdbUr1Gu1jTRMgWxqhrTK/ppNGoys3yDTVMxFz2iDTVAcrViJN0nJ/BAKtCipt+2nbIOGyyVZ0jfajGtJzrWYLlgjL69Hg7/IvlahcjvmvzXFTx2q4FaYGbR8skYK4QXxDDlJO/NVHZdVxgnADUIoUccCfalVGKu1gG5p6LZgfUa9Lg1P+sMWiKl/S3t1x9dCZaYtn5RHmeSR+9jK8FXYttoWFfzJe3XTNmIoXBpBs0O0tFyJO0IBsJY8aUp/fOWTX7ShASDQQKtlo4BJN7gBny5FPvwpB90w5MM8/WDvrGRX39FdBnBQCb4BeEoBy1RBPtfFuirJOCJAeEaFCjwvpGql8sjcqyOpAUg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(40470700004)(46966006)(36840700001)(336012)(186003)(47076005)(83380400001)(356005)(81166007)(86362001)(36860700001)(82740400003)(5660300002)(2906002)(41300700001)(52536014)(8936002)(4326008)(82310400005)(55016003)(40480700001)(107886003)(8676002)(40460700003)(478600001)(9686003)(53546011)(6506007)(7696005)(26005)(316002)(70206006)(70586007)(54906003)(110136005)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 15:54:17.1786
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 48b166e4-f0fa-4e7c-7fde-08dab057d8c7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6022

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjNdIHhlbi9h
cm06IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4gYXJjaF9kb21h
aW5fY3JlYXRlKCkNCj4gDQo+IEhpIEhlbnJ5LA0KPiANCj4gT24gMTcvMTAvMjAyMiAwODo0Niwg
SGVucnkgV2FuZyB3cm90ZToNCj4gPiAgICAgICBpZiAoIHAybS0+cm9vdCApDQo+ID4gQEAgLTE3
NjIsNiArMTc3OCwyMCBAQCBpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFpbiAqZCkNCj4gPiAgICAg
ICBJTklUX1BBR0VfTElTVF9IRUFEKCZwMm0tPnBhZ2VzKTsNCj4gPiAgICAgICBJTklUX1BBR0Vf
TElTVF9IRUFEKCZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxpc3QpOw0KPiA+DQo+ID4gKyAgICAv
Kg0KPiA+ICsgICAgICogSGFyZHdhcmUgdXNpbmcgR0lDdjIgbmVlZHMgdG8gY3JlYXRlIGEgUDJN
IG1hcHBpbmcgb2YgOEtCIEdJQ3YyDQo+IGFyZWENCj4gPiArICAgICAqIHdoZW4gdGhlIGRvbWFp
biBpcyBjcmVhdGVkLiBDb25zaWRlcmluZyB0aGUgd29yc3QgY2FzZSBmb3IgcGFnZQ0KPiA+ICsg
ICAgICogdGFibGVzIGFuZCBrZWVwIGEgYnVmZmVyLCBwb3B1bGF0ZSAxNiBwYWdlcyB0byB0aGUg
UDJNIHBhZ2VzIHBvb2wNCj4gaGVyZS4NCj4gPiArICAgICAqIEZvciBHSUN2MywgdGhlIGFib3Zl
LW1lbnRpb25lZCBQMk0gbWFwcGluZyBpcyBub3QgbmVjZXNzYXJ5LCBidXQNCj4gc2luY2UNCj4g
PiArICAgICAqIHRoZSBhbGxvY2F0ZWQgMTYgcGFnZXMgaGVyZSB3b3VsZCBub3QgYmUgbG9zdCwg
aGVuY2UgcG9wdWxhdGUgdGhlc2UNCj4gPiArICAgICAqIHBhZ2VzIHVuY29uZGl0aW9uYWxseS4N
Cj4gPiArICAgICAqLw0KPiA+ICsgICAgc3Bpbl9sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsN
Cj4gPiArICAgIHJjID0gcDJtX3NldF9hbGxvY2F0aW9uKGQsIDE2LCBOVUxMKTsNCj4gPiArICAg
IHNwaW5fdW5sb2NrKCZkLT5hcmNoLnBhZ2luZy5sb2NrKTsNCj4gPiArICAgIGlmICggcmMgIT0g
MCApDQo+ID4gKyAgICAgICAgcmV0dXJuIHJjOw0KPiANCj4gDQo+IHAybV9zZXRfYWxsb2NhdGlv
bigpIHdhbnRzIHRvIGJlIGNhbGxlZCBhZnRlciAncC0+ZG9tYWluJyBpcyBzZXQuIFNvDQo+IHAy
bV90ZWFyZG93bl9maW5hbCgpIHdpbGwgbm90IHJldHVybiBlYXJseSBhbmQgbGVhayBtZW1vcnkg
KGFzIEFuZHJldw0KPiBwb2ludGVkIG91dCkuDQoNClllcyB0aGlzIGlzIGEgcmVhbGx5IHNpbGx5
IG1pc3Rha2UgdGhhdCBJIG1hZGUsIGFuZCBJIGFtIHJlYWxseSBzb3JyeSBmb3IgdGhhdC4NCg0K
PiANCj4gRm9yIHNpbXBsaWNpdHkgSSB3b3VsZCBtb3ZlIHRoZSBjb2RlIHJpZ2h0IGF0IHRoZSBl
bmQgb2YgdGhlIGZ1bmN0aW9uLg0KDQpEZWZpbml0ZWx5Lg0KDQo+IEJ1dCBpZiB5b3Ugd2FudCB0
byBrZWVwIGl0IGhlcmUgdGhlbi4uLg0KPiANCj4gPiArDQo+ID4gICAgICAgcDJtLT52bWlkID0g
SU5WQUxJRF9WTUlEOw0KPiANCj4gLi4uIHRoaXMgbmVlZHMgdG8gYmUgZG9uZSBmaXJzdCBhcyB3
ZWxsLg0KDQpJIGFncmVlIG1vdmluZyB0aGF0IHBhcnQgdG8gdGhlIGVuZCB3b3VsZCBiZSBhIGJl
dHRlciBzb2x1dGlvbi4NCg0KPiANCj4gPg0KPiA+ICAgICAgIHJjID0gcDJtX2FsbG9jX3ZtaWQo
ZCk7DQo+IA0KPiBOb3RlIHRoYXQgaWYgeW91IG1vdmUgdGhlIGNvZGUgYXQgdGhlIGVuZC4gVGhl
biB5b3Ugd2lsbCBuZWVkIHRvIGFkZDoNCj4gDQo+IGlmICggcmMgKQ0KPiAgICByZXR1cm4gcmM7
DQo+IA0KPiBhZnRlciB0aGUgY2FsbCB0byBwMm1fYWxsb2NfdGFibGUoKTsNCg0KWWVzLCB0aGFu
a3MgdmVyeSBtdWNoIGZvciB0aGUgcmVtaW5kZXIuDQoNCj4gDQo+IE90aGVyIHRoYW4gdGhhdCB0
aGUgY29kZSBsb29rcyBnb29kIHRvIG1lLg0KDQpBcyBBbmRyZXcgc3RhdGVkIGluIGhpcyBlbWFp
bCB0aGF0IGhlIHdpbGwgZHJhZnQgYSBwYXRjaCwgVEJIIEkgYW0gbm90DQpzdXJlIGlmIG15IHBh
dGNoIHdvdWxkIGJlIHN1cGVyc2VkZWQgYnkgaGlzLCBidXQgSSB3aWxsIHRyeSB0byBzZWUgaWYg
aXQNCmlzIHBvc3NpYmxlIGZvciBtZSB0byBzZW5kIGEgdjQgdG9kYXkuDQoNCktpbmQgcmVnYXJk
cywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 16:16:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 16:16:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424507.671975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSn6-0006wV-8L; Mon, 17 Oct 2022 16:16:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424507.671975; Mon, 17 Oct 2022 16:16:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okSn6-0006wO-3z; Mon, 17 Oct 2022 16:16:36 +0000
Received: by outflank-mailman (input) for mailman id 424507;
 Mon, 17 Oct 2022 16:16:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okSn4-0006wE-8R; Mon, 17 Oct 2022 16:16:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okSn4-00030U-4W; Mon, 17 Oct 2022 16:16:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okSn3-0000Dy-Qa; Mon, 17 Oct 2022 16:16:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okSn3-00009o-O0; Mon, 17 Oct 2022 16:16:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=c1xFJHCoNsdeqa3DKz4fUk+tB7ShuHHPQaQUH1T8p5c=; b=wagZP+1wszX7nVqQ4QDPjX8wh7
	CRqt4MGp6bTue7TDx51/K9LbAlKgYoJkywOZvdA//KsBij7gcByztMt4IzgRGKUQLWNDvucIkZgnz
	IKRC0XALVLt/3MYZFWMrP4iyiBs5BWVhbuX0HJkTv4SVkzztZQJPS+lyYYigtkkP7mpk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173923-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 173923: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1d0da8674c23e8d65398c33a4d5018eaf02e1c64
X-Osstest-Versions-That:
    linux=6e150d605c9e21dbe939875c13e82da33fb59ed0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 16:16:33 +0000

flight 173923 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173923/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-qcow2 13 guest-start    fail in 173806 pass in 173923
 test-armhf-armhf-xl-credit2  14 guest-start                fail pass in 173806
 test-armhf-armhf-xl-multivcpu 14 guest-start               fail pass in 173806

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 173461

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 173461
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 173806 like 173461
 test-armhf-armhf-xl-credit1  14 guest-start         fail in 173806 like 173461
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 173806 like 173461
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 173806 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 173806 never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 173806 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 173806 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173461
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173461
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173461
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173461
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173461
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173461
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173461
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173461
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173461
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173461
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173461
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173461
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                1d0da8674c23e8d65398c33a4d5018eaf02e1c64
baseline version:
 linux                6e150d605c9e21dbe939875c13e82da33fb59ed0

Last test of basis   173461  2022-10-07 17:40:12 Z    9 days
Testing same since   173806  2022-10-15 06:14:51 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Viro <viro@zeniv.linux.org.uk>
  Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
  Alexey Dobriyan <adobriyan@gmail.com>
  Andrew Chernyakov <acherniakov@astralinux.ru>
  Andrew Morton <akpm@linux-foundation.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Brian Norris <briannorris@chromium.org>
  Cameron Gutman <aicommander@gmail.com>
  ChanWoo Lee <cw9316.lee@samsung.com>
  Cleber de Mattos Casali <clebercasali@gmail.com>
  Cristian Marussi <cristian.marussi@arm.com>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Wunderlich <frank-w@public-files.de>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Haimin Zhang <tcs.kernel@gmail.com>
  Haimin Zhang <tcs_kernel@tencent.com>
  Hu Weiwen <sehuww@mail.scut.edu.cn>
  Ilya Dryomov <idryomov@gmail.com>
  Jann Horn <jannh@google.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jasper Poppe <jgpoppe@gmail.com>
  Jeremy Palmer <jpalmer@linz.govt.nz>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Jon Hunter <jonathanh@nvidia.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kyle Gospodnetich <me@kylegospodneti.ch>
  Letu Ren <fantasquex@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lukas Straub <lukasstraub2@web.de>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mimi Zohar <zohar@linux.ibm.com>
  Namhyung Kim <namhyung@kernel.org>
  Orlando Chamberlain <redecorating@protonmail.com>
  Paul Webb <paul.x.webb@oracle.com>
  Pavel Rojtberg <rojtberg@gmail.com>
  Randy Dunlap <rdunlap@infradead.org> # build-tested
  Richard Weinberger <richard@nod.at>
  Ruineka <ruinairas1992@gmail.com>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Samuel Jiang <chyishian.jiang@gmail.com>
  Sasha Levin <sashal@kernel.org>
  Saurav Kashyap <skashyap@marvell.com>
  Sergei Antonov <saproj@gmail.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Soenke Huster <shuster@seemoo.tu-darmstadt.de>
  Steven Price <steven.price@arm.com>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Swati Agarwal <swati.agarwal@xilinx.com>
  Sönke Huster <shuster@seemoo.tu-darmstadt.de>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Ulf Hansson <ulf.hansson@linaro.org>
  Vinod Koul <vkoul@kernel.org>
  Wende Tan <twd2.me@gmail.com>
  Xiubo Li <xiubli@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   6e150d605c9e..1d0da8674c23  1d0da8674c23e8d65398c33a4d5018eaf02e1c64 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 16:52:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 16:52:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424519.671998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okTLB-0002tS-28; Mon, 17 Oct 2022 16:51:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424519.671998; Mon, 17 Oct 2022 16:51:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okTLA-0002tL-Vr; Mon, 17 Oct 2022 16:51:48 +0000
Received: by outflank-mailman (input) for mailman id 424519;
 Mon, 17 Oct 2022 16:51:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rSUT=2S=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okTL9-0002tF-HN
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 16:51:47 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id fb50595b-4e3b-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 18:51:44 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3481C113E;
 Mon, 17 Oct 2022 09:51:50 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A64573F792;
 Mon, 17 Oct 2022 09:51:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb50595b-4e3b-11ed-91b4-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <wei.chen@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Date: Mon, 17 Oct 2022 16:51:33 +0000
Message-Id: <20221017165133.17066-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
which requires 6 P2M pages as the two pages will be consecutive but not
necessarily in the same L3 page table and keep a buffer, populate 16
pages as the default value to the P2M pages pool in arch_domain_create()
at the domain creation stage to satisfy the GICv2 requirement. For
GICv3, the above-mentioned P2M mapping is not necessary, but since the
allocated 16 pages here would not be lost, hence populate these pages
unconditionally.

With the default 16 P2M pages populated, there would be a case that
failures would happen in the domain creation with P2M pages already in
use. To properly free the P2M for this case, firstly support the
optionally preemption of p2m_teardown(), then call p2m_teardown() and
p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
As non-preemptive p2m_teardown() should only return 0, use a
BUG_ON to confirm that.

Since p2m_final_teardown() is called either after
domain_relinquish_resources() where relinquish_p2m_mapping() has been
called, or from failure path of domain_create()/arch_domain_create()
where mappings that require p2m_put_l3_page() should never be created,
relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
in-code comments to refer this.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
This should also be backported to 4.13, 4.14, 4.15 and 4.16.
v4 changes:
- Move the initial population of 16 default pages to the end of
  p2m_init(), add if(rc) return rc; after p2m_alloc_table()
v3 changes:
- Move the population of default pages to p2m_init().
- Use a loop over p2m_teardown_allocation() to implement the
  non-preemptive p2m_teardown_allocation() and avoid open-coding.
- Reorder assertions in p2m_final_teardown().
- Add p2m_teardown() will always return 0 if called non-preemptively in
  doc, move the page_list_empty(&p2m->pages) check to p2m_teardown()
  and use a BUG_ON to confirm p2m_teardown() will return 0 in
  p2m_final_teardown().
- Add a comment in p2m_final_teardown() to mention relinquish_p2m_mapping()
  does not need to be called, also update commit message.
v2 changes:
- Move the p2m_set_allocation(d, 0, NULL); to p2m_final_teardown().
- Support optionally preemption of p2m_teardown(), and make the calling of
  p2m_teardown() preemptively when relinquish the resources, non-preemptively
  in p2m_final_teardown().
- Refactor the error handling to make the code use less spin_unlock.
- Explain the worst case of page tables and the unconditional population
  of pages in commit message.
- Mention the unconditional population of pages in in-code comment.
---
 xen/arch/arm/domain.c          |  2 +-
 xen/arch/arm/include/asm/p2m.h | 14 ++++++++++----
 xen/arch/arm/p2m.c             | 34 ++++++++++++++++++++++++++++++++--
 3 files changed, 43 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2c84e6dbbb..38e22f12af 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1064,7 +1064,7 @@ int domain_relinquish_resources(struct domain *d)
             return ret;
 
     PROGRESS(p2m):
-        ret = p2m_teardown(d);
+        ret = p2m_teardown(d, true);
         if ( ret )
             return ret;
 
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index 42bfd548c4..c8f14d13c2 100644
--- a/xen/arch/arm/include/asm/p2m.h
+++ b/xen/arch/arm/include/asm/p2m.h
@@ -194,14 +194,18 @@ int p2m_init(struct domain *d);
 
 /*
  * The P2M resources are freed in two parts:
- *  - p2m_teardown() will be called when relinquish the resources. It
- *    will free large resources (e.g. intermediate page-tables) that
- *    requires preemption.
+ *  - p2m_teardown() will be called preemptively when relinquish the
+ *    resources, in which case it will free large resources (e.g. intermediate
+ *    page-tables) that requires preemption.
  *  - p2m_final_teardown() will be called when domain struct is been
  *    freed. This *cannot* be preempted and therefore one small
  *    resources should be freed here.
+ *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
+ *  free the P2M when failures happen in the domain creation with P2M pages
+ *  already in use. In this case p2m_teardown() is called non-preemptively and
+ *  p2m_teardown() will always return 0.
  */
-int p2m_teardown(struct domain *d);
+int p2m_teardown(struct domain *d, bool allow_preemption);
 void p2m_final_teardown(struct domain *d);
 
 /*
@@ -266,6 +270,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
 /*
  * Direct set a p2m entry: only for use by the P2M code.
  * The P2M write lock should be taken.
+ * TODO: Add a check in __p2m_set_entry() to avoid creating a mapping in
+ * arch_domain_create() that requires p2m_put_l3_page() to be called.
  */
 int p2m_set_entry(struct p2m_domain *p2m,
                   gfn_t sgfn,
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3..0b4e24218e 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1685,7 +1685,7 @@ static void p2m_free_vmid(struct domain *d)
     spin_unlock(&vmid_alloc_lock);
 }
 
-int p2m_teardown(struct domain *d)
+int p2m_teardown(struct domain *d, bool allow_preemption)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long count = 0;
@@ -1693,6 +1693,9 @@ int p2m_teardown(struct domain *d)
     unsigned int i;
     int rc = 0;
 
+    if ( page_list_empty(&p2m->pages) )
+        return 0;
+
     p2m_write_lock(p2m);
 
     /*
@@ -1716,7 +1719,7 @@ int p2m_teardown(struct domain *d)
         p2m_free_page(p2m->domain, pg);
         count++;
         /* Arbitrarily preempt every 512 iterations */
-        if ( !(count % 512) && hypercall_preempt_check() )
+        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
         {
             rc = -ERESTART;
             break;
@@ -1736,7 +1739,20 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
+    /*
+     * No need to call relinquish_p2m_mapping() here because
+     * p2m_final_teardown() is called either after domain_relinquish_resources()
+     * where relinquish_p2m_mapping() has been called, or from failure path of
+     * domain_create()/arch_domain_create() where mappings that require
+     * p2m_put_l3_page() should never be created. For the latter case, also see
+     * comment on top of the p2m_set_entry() for more info.
+     */
+
+    BUG_ON(p2m_teardown(d, false));
     ASSERT(page_list_empty(&p2m->pages));
+
+    while ( p2m_teardown_allocation(d) == -ERESTART )
+        continue; /* No preemption support here */
     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
 
     if ( p2m->root )
@@ -1784,6 +1800,8 @@ int p2m_init(struct domain *d)
         !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK);
 
     rc = p2m_alloc_table(d);
+    if ( rc != 0 )
+        return rc;
 
     /*
      * Make sure that the type chosen to is able to store the an vCPU ID
@@ -1803,6 +1821,18 @@ int p2m_init(struct domain *d)
      */
     p2m->domain = d;
 
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
+     * the allocated 16 pages here would not be lost, hence populate these
+     * pages unconditionally.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+
     return rc;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 17:32:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 17:32:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424531.672020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okTyV-0007YP-Cs; Mon, 17 Oct 2022 17:32:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424531.672020; Mon, 17 Oct 2022 17:32:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okTyV-0007YI-A4; Mon, 17 Oct 2022 17:32:27 +0000
Received: by outflank-mailman (input) for mailman id 424531;
 Mon, 17 Oct 2022 17:32:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7GYT=2S=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1okTyT-0007YC-GC
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 17:32:25 +0000
Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com
 [2a00:1450:4864:20::629])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a977500e-4e41-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 19:32:24 +0200 (CEST)
Received: by mail-ej1-x629.google.com with SMTP id q9so26674552ejd.0
 for <xen-devel@lists.xenproject.org>; Mon, 17 Oct 2022 10:32:24 -0700 (PDT)
Received: from uni.router.wind (adsl-214.109.242.138.tellas.gr.
 [109.242.138.214]) by smtp.googlemail.com with ESMTPSA id
 cq6-20020a056402220600b00458cc5f802asm7705824edb.73.2022.10.17.10.32.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 17 Oct 2022 10:32:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a977500e-4e41-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=1FhMqU6o+OmI9sNxvKM4/FjFziffLBpWtVI66KBPbI0=;
        b=BJ+rzIblhdV+Z2Ns4ttV2aBanT0/zvkcOb6Ye7/8HmXYpEMBvG4mvI2Gm5fiGEIzE5
         SdBU6ftV4vBg2dZPg3NTSBBiTjcbnUOkLf+jOpiACuGFa5mchNkHizQflou8MMTCjc0D
         7ulCF054GIAPzKxJz1tvpdunhXzMlQzP/d8c8hUzdNbuVLqjJi3AhHkXkJREGRQ+hkz6
         liD7aSyEGzmEcNTgegXoKWSY/d7x2puMwzGseTy4wzupgTDkPOxCLgSwQ0B0QGDR6adU
         soOt2zDyLfzZ0LHpfHi2/yHw3suWZQoc0o5G5zzdRQyO0c2VNi/g2JdQuXlk7JvfLyP9
         BuOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=1FhMqU6o+OmI9sNxvKM4/FjFziffLBpWtVI66KBPbI0=;
        b=HtCmU3FmToFNDo7zWCDnBSTvWSDojyFXFXydhM/g/XnaGY0VoemV0XAzo5aKbxFN2X
         oWH8RRgDQyVyGDn9dcdPOUyfy7FVSnNMdNlkNCLyw63heATb4WspkZEDMRfivIW2jkaA
         +kFoRXKrbnEa3Nvr2OqQq7RvSosQ7q7G2XHKo8HZEAHME+kbdL8ZQmt+U2khM18mpvCB
         CXatfCot+tgen5J+JSFGxS+JwXef7d8mbIOUzZQpLXyOExWtDCVN2tS3Toqp0C+CrLlR
         wYgnDn2GKDMKaDgJsiQPqjABuLqqAYnj3MZWx7PmFz4xbhScbIAfXslG4RDDj7jCrv4V
         8Vlg==
X-Gm-Message-State: ACrzQf3uJvm29PweexUO0T4UhTYUeRYMdnezG/OWfNRhyW0/PN6uVtGJ
	6IkHFCkt5ugIHmB3GNdg35DMw9GaqTE=
X-Google-Smtp-Source: AMsMyM5SlrDYpZHdKXPSkpaHxNfCE/fOi6lJk15YnTAFboEyJMwUXmXynJ/sw/AZ8XaK+JvJ3YdjZA==
X-Received: by 2002:a17:907:969e:b0:782:6b92:6b1f with SMTP id hd30-20020a170907969e00b007826b926b1fmr9205827ejc.140.1666027943555;
        Mon, 17 Oct 2022 10:32:23 -0700 (PDT)
From: Xenia Ragiadakou <burzalodowa@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Date: Mon, 17 Oct 2022 20:32:09 +0300
Message-Id: <20221017173209.236781-1-burzalodowa@gmail.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the pa_range_info for the 52-bit pa range advertizes that the
p2m root table consists of 8 concatenated tables at level 3, which does
not make much sense.
In order to support the 52-bit pa size with 4KB granule, the p2m root
table needs to be configured either as a single table at level -1 or
as 16 concatenated tables at level 0.
Since, currently there is not support for level -1, set the
root_order and sl0 fields of the corresponding pa_range_info according
to the second approach.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
 xen/arch/arm/p2m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3..c824d62806 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -2251,7 +2251,7 @@ void __init setup_virt_paging(void)
         [3] = { 42,      22/*22*/,  3,          1 },
         [4] = { 44,      20/*20*/,  0,          2 },
         [5] = { 48,      16/*16*/,  0,          2 },
-        [6] = { 52,      12/*12*/,  3,          3 },
+        [6] = { 52,      12/*12*/,  4,          2 },
         [7] = { 0 }  /* Invalid */
     };
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 18:09:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 18:09:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424541.672043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okUY0-0002rF-9w; Mon, 17 Oct 2022 18:09:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424541.672043; Mon, 17 Oct 2022 18:09:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okUY0-0002r8-7O; Mon, 17 Oct 2022 18:09:08 +0000
Received: by outflank-mailman (input) for mailman id 424541;
 Mon, 17 Oct 2022 18:09:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okUXy-0002qy-Ec; Mon, 17 Oct 2022 18:09:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okUXy-00052f-Ad; Mon, 17 Oct 2022 18:09:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okUXx-0006C4-R8; Mon, 17 Oct 2022 18:09:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okUXx-0003Da-Qf; Mon, 17 Oct 2022 18:09:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZHvFwtHRv+fIuzZLnM+Xm3v2AOJWY/ZTJiUCTJKnFcI=; b=MfVi4pEH1vU5REuNvFADtygd0u
	HKeOUBSbM+EUVL0KpDdrOV0Bf3ld9StYqZh7/gjdqv3+jKxgdNUddAQbs9LJmnamvCLyQGT0UQFn/
	YhfB9PtchN7JaKIrFb+akb3wY/4/5fk55Me5LxxyUYG+9l4hpXciMWyuWZNz5ey/yFx8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174001-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174001: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 18:09:05 +0000

flight 174001 xen-unstable-smoke real [real]
flight 174015 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174001/
http://logs.test-lab.xenproject.org/osstest/logs/174015/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   39 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 19:08:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 19:08:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424553.672060 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVTG-0000sO-Q2; Mon, 17 Oct 2022 19:08:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424553.672060; Mon, 17 Oct 2022 19:08:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVTG-0000sH-NK; Mon, 17 Oct 2022 19:08:18 +0000
Received: by outflank-mailman (input) for mailman id 424553;
 Mon, 17 Oct 2022 19:08:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okVTF-0000sB-HO
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 19:08:17 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09264442-4e4f-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 21:08:14 +0200 (CEST)
Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 17 Oct 2022 15:07:34 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Mon, 17 Oct
 2022 19:07:33 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 19:07:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09264442-4e4f-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666033693;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=QuAvrJvYXucoKIMO8EkIU6VL6cY3WHerJ0IxHPEf9Mc=;
  b=bt2NiWUFzeYAtajdF+bOTIHEupwXoxOjSZ576Bi0s+ZvJZ9QhvJhEXZU
   NVNYIhgEht2V6xft72kepq5Z4uyi3hQ0g9mSCxNwR4vOH5x5wHzA9ydz0
   9wLOUwHq0VpTNyW37+FCFDTF1BZCBPDwMGW4bY2IeMjosI6Z+uCk06u97
   A=;
X-IronPort-RemoteIP: 104.47.56.176
X-IronPort-MID: 85457342
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:wPSmh6uzAQaw7MUhO67Mhewj3efnVNtfMUV32f8akzHdYApBsoF/q
 tZmKW+Ab6yCNmD8Ld9xbNu28BwFuMKHzoc3GVY5pX0wF39G+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakU5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklu7
 eMnLS4wRCm9oMGr8KzrcO5LgvQKeZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUujtABM/KMEjCObexTklyVu
 STt+GPhDwtBHNee1SCE4jSngeqncSbTCN9OSeLjqqQCbFu74nEjUCMOX0SBjd69iFHnfdtiB
 2cG5X97xUQ13AnxJjXnZDWYrXier1gjUtxfO+Qg7UeGza+8yxaUAC0IQyBMbPQitdQqXno62
 1mRhdTrCDdz9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbjA/LT9tlOL64iJvyAz6Y6
 zqHtjQkjrMfy8sCzbym/Evviiip4JPOS2Yd+QjWGGml4wVRbZSgIYev7DDz0/FEK4qIS0ibi
 1INkcOe8eMmAImEkWqGR+BlIV2yz/OMMTmZilk2GZAkrm2p4yT6It4W5yxiLkB0NMpCYSXuf
 ELYpQJW4tlUIWeuaqh0JYm2DqzG0JTdKDgsbdiMBvImX3S7XFPvEP1GDaJI413QrQ==
IronPort-HdrOrdr: A9a23:NYvlbK2r7a8zQdkSaox/uwqjBRFyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O
 UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTObNSRP5uw/zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY
 fABK5r
X-IronPort-AV: E=Sophos;i="5.95,192,1661832000"; 
   d="scan'208";a="85457342"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y0Avv6VNM7W+mjkt6To68Brsi8xo3pgb9EMC/yQpjNsGNYeNdiUquNgnZhRA8Ruukp2f8Kl+yYMNWV8RbBDQrpI3e2P4MFgh0tuqdz4if1pLb9l2/JyF/giT/lECoHf6EpRQYIeoUvjw+idh5Zpu7LaXSYbFjF74Y18ehjHw1IMkWoQowas0HMw6Yyr5vJpm3jPV/Zx2pKZ8TVcOdEL1C3angsnlPtLSn38gKbJ7ccdmzdVIHaWRPLRLaoistkZfdpR5+0d5YR0t8iBOBumOxgYZD8ukwC70LYVEsI1WMYe6Fz1dK9wGyI1LvdYl135aW/mcie1AXD9KjC1OFIu7jg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QuAvrJvYXucoKIMO8EkIU6VL6cY3WHerJ0IxHPEf9Mc=;
 b=jVEjfsuxBPArUCWODoAkrr4vg4OvkCya355NTXmSijZ7Ua5MR8S/Wp15BRLF4ax+3jlJrdUFNS36N4psJCNkvccXeRs35gcfaVMnynPNd36wu69hoMGU3E5jFucGphtCN5y831kt+uBZmArTp9fA7j6xplKG06ZyEc+k13KAWwvIThf0J6lvyvhnr+WWVXXokYVUfDOYJ/UlciHJLAw+cNSzwjNzbZGG7v9YgyQQxXbLysFIQDf+IeSYnPj050hp2WjZjRfxa2RQVkjCyESysrMTuboxoN9il/w7zdjBOJxRpsVUnXUaN+7IsdVq7WioZuVFWc8V6g1dOFtUQ7X7Eg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QuAvrJvYXucoKIMO8EkIU6VL6cY3WHerJ0IxHPEf9Mc=;
 b=lZdZJ0kWpunxdMpCTOEjjdaWdHGGkT3u4Qjt7jhcl7ljFOoD9/7n7mF1QlilPJ+jr8tAqYVGVDe5qAgCrdDsSOgHBpL3QEpFH5OB7ZziDyfUluuwoXzugB/n3+hI5R1wrP0SdM1UE7k11bLsC5iR9JBRNi9vTil5yhU2ePayPm4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen
	<wei.chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4kjMT/hxO9gc1E6OcnjJPjKrQq4S8teA
Date: Mon, 17 Oct 2022 19:07:32 +0000
Message-ID: <fcb69acd-2985-1c84-07b4-94cff742a18c@citrix.com>
References: <20221017165133.17066-1-Henry.Wang@arm.com>
In-Reply-To: <20221017165133.17066-1-Henry.Wang@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6423:EE_
x-ms-office365-filtering-correlation-id: ba60c863-959d-428d-60a0-08dab072d850
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 YfSgWVUzL2uMHi9aclMoQbgq3luhjqZOypbvjuYfApZQkPdNLRfq8DViJtKEMsuV8mDGYWi6G0w9QF+2aaynQWrK7OoImn0uGhV7N2xOPdMc+WgE3J28boxnfJnfWVr60bdXckywV5V2OXB8h/QNEAAVeRdFTaYVHq2QcxGMbVtqH6KcJFmBIGFLp0UOHJ5Scvog9TwFCytyLBpDQFrhBb7NH3Jvxbz8wQ/Vs465ZI1NgneegCa/7c+DToEX6CNvwIPblIxTU5F76uE+TjTq3D05Uk/f3j3FGi7tXZkx5KKrwMHWf0iXqXgEgyhZAHjRDz7/g8mtObBHtZXF+gTF64ao9rfwNY96yIQeFoI4eiHUX9XzflJIUqTFhuZ2neWD0G2384Y9f0gcqvlLsaYx/eqHG9OWpiA+mrrpYdCn2pfj3TMdVsGnD1mwE7s2TuwhPDl/MZvIVKqhuIm7FRmlVkZpsIc91qRlbW5Wi+OBLvOeyrQSgOAJUPkVZauZrUY96v+cjRYdkEni/3/2j72w4R8zc9Kd/yLRAgvFcmbTAz2zldanPZNOE25B9wraNBi8TgTATfBz/A4oc+gXkwCjo4P9mPR/XTtUkGCY/R49NK4Wf5RN5sUF4vw/A/DLGTOmJJC2PjKIItvedUsRNApWytmjtmIf/R2ze4ULW6p47tiWxlvCHh3R9kn+gNbITxu2KD6N3swqCHH8D2F/f7LvSoda/6qMiMXP8v0ds48+55z350OYnny5VxehfQGDoGBeBG+0kkuJGjho/Zv6DurKGFtqmXGb0iI6gmQ2i947pLmIpuu1TVakjuBoZOkqcQnff/I00ovPlo5KXV7yqAMtcA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(376002)(39860400002)(346002)(451199015)(6486002)(316002)(110136005)(31686004)(54906003)(8676002)(4326008)(91956017)(66946007)(76116006)(66556008)(66476007)(66446008)(64756008)(71200400001)(478600001)(4744005)(5660300002)(186003)(2616005)(41300700001)(2906002)(53546011)(6512007)(6506007)(26005)(8936002)(36756003)(82960400001)(31696002)(122000001)(86362001)(38070700005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?alo2RnpaUFFmQzAxWEM2M0VnWkdKVEwwM29FUHdxdjB6a04xekRyeENQdHds?=
 =?utf-8?B?Njc1YnFCSTFzeTdvQ1F3dmN0YVMzU2J4MklvK2R6Tm9BenlnV3BGRmdWa20w?=
 =?utf-8?B?RGlSRHl2TDE1NytaUWVGWkhiWUVoRi92K0IvQWw0NGNJTTVhY3lTcnpsL2RD?=
 =?utf-8?B?Zy9PSnRtMTltS1ZrSW8wNzdIQkVMZkZYUy8vK0xzTzdTWmI4ejRaOE45ZTZP?=
 =?utf-8?B?VDN0V1VkWmtnTEllMDlmZHRtbUNvY3VCRDFDNzZ4bVJXb1Z0N0hqRVVrM2dO?=
 =?utf-8?B?OVcvSzdDeENRblBrejQ0UG9SSWFYSFIyL3pVcTgrK1NqbEdvcmtNaUF1UmRu?=
 =?utf-8?B?SEpFQlNCckp3aWRxR1U3T1pZMlRtMjBvMEdyZW9QVzhtdS9PbnhYYkl2dmNJ?=
 =?utf-8?B?ajNjK2hsMzgySlpFVS9ZVlZqdXhWSHhLWW5RQ0hBUmMxYjFkLythcEJZN3NT?=
 =?utf-8?B?NTF2QVB2N2FjenhISzE3ZkYxTWFPYkdDNG9ONk9UVjdtYnBuVUExc0tjbVNs?=
 =?utf-8?B?UXMzZ1cxb1lTempKd3M3Uk1lbzg5OXF4UlBsdWZXcDZ0VFp0ZlI3d3U3N3R6?=
 =?utf-8?B?MG5TRWpOdmJPOE91aG0zZm1SWXFuNG9aSS8vbnJhanY0RTBpVDJ0alk1TXZs?=
 =?utf-8?B?SWdkTTEzcE5RQnVreHFIZFJOYnVtbE1JRkFQclptVFNyQk44TWJJWXY2czRY?=
 =?utf-8?B?a1lMRHRBdHo4L2xyQ3FYQjlHa3l4QTlTNXJETk81ZVZiMnllYjRTNGRQLytZ?=
 =?utf-8?B?ZEc2Q3liRnVjR2tjV2lnWFk1eUU2Yk53cUR5UTdWSEFHQTlzb2FGOG9mdXJy?=
 =?utf-8?B?eEV1ODFvemZ0S0NrUWhWL3NyRWpRQjdyWXNSSUhyZ1M0eTNzVUxaZklNdlFm?=
 =?utf-8?B?d3ZJYWIvNXp2Skt3WFpKYXFPM055emgwRFVxeS9uZ250UFpXQU4xSnkrYUtx?=
 =?utf-8?B?VExwWmlhMG1DblU3U3N3Tyt1d3NtUStNbmRBWTJGTXB2aGRMbW80RTdpSWJz?=
 =?utf-8?B?b0dQV0Yzcnd4ckhhNStzUHNoU1VFWHZBZ1krS0RxLzVCVEtxU205Z3p6dzVv?=
 =?utf-8?B?ZS9BTFR6S3kxQkhqeEJ0UXRzU2JGelBpOXRDYU5qNWRGWTZieTdaeFd5R0Ev?=
 =?utf-8?B?M3R4bzhiN0FaWVRjODNNRnRWaEdWSThmTC9DU0JUWnNLaFBYUFkvNlkyR1NW?=
 =?utf-8?B?YnBEZ2lwa2NNYWdUbUY3dUpOSVNqOFJ0Ty92ejZ4b3NiT1FJdlk1TDNhVWM5?=
 =?utf-8?B?WHZIdHRaaVpYVTZZalpZb3NicWJxcEdncWhpR3U1R0JyUm9pUDBOSkE3VEwv?=
 =?utf-8?B?SzJ4THVuNFhzQjArZUlNNUorM2VlSm5jK3B3QSszRnZ3T1dhb3BZZTRyU2Rw?=
 =?utf-8?B?WDhhUXRjRFVubW5VcGF3c01nQzJWakRYdk5WT3V3UFZhYm5mUDVHNUM3Kzk4?=
 =?utf-8?B?WnZYS3UxcXMyQUkzUzVmWW93VUJpbVM0WmJTNy9MS2dCSzVrbm1uR1F1OUZN?=
 =?utf-8?B?Y0dIUUx3U0pDVVg4WEE0dTN6N1pyYlZGaEpjUFkzOFhZNVFhSEwzMnY5d1lx?=
 =?utf-8?B?THBmYlA2K2dTSGYxVG5WVzdzNXIya3VXbGJRMitBOW1EbDFWTEpyNlFMK1VI?=
 =?utf-8?B?SDkyLzJsa2dwUEptUE40SFpRKyt5anVLc3I0UkFKTTQrRjlpbzBMWDlCQlBy?=
 =?utf-8?B?dVdoQkFDK2pBbmRPc1QvbEhpekVWSkYwdVg2K1FsY0c0elk4UFhMNUFTWUZB?=
 =?utf-8?B?V3dtTUI2YUFmM29EU1o3UzZjSHBuOG5Ga0NFYlpCNWxBL245QlU5NmxlalVU?=
 =?utf-8?B?dDQ4M3JEQ0xaZldMelZSVHFoeHNhenkvVFBpY3ZHZ0RHOWd4VStPbWJjdExs?=
 =?utf-8?B?dFdVdzZhNkdJRnNKZzFSRE5jcGpTdFBTWmJzY2liZEdzWTI2bW5VUkt6OE55?=
 =?utf-8?B?N3JjS0Q5WmRDTGxweFRxMXFzNk9QYktUS2JrT0t4amhzTmJLZ2tLT3ZpdW9m?=
 =?utf-8?B?QWFFTXRkRmRhZ3VOaUdVUVYxZHJZZUFHQUl3dThKTi85RUprd1lBbVRTRGls?=
 =?utf-8?B?QUVBWW1DR1RlcU9tUDdGdW1mTzBaNmg5VHFocndmcktvTDc5RlBDYk1MQjJs?=
 =?utf-8?Q?UtVgm0x7wYtisPsr1vgAlbuc1?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C63F35935CAC6349A1B7EB13A598D6A7@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba60c863-959d-428d-60a0-08dab072d850
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 19:07:32.7628
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /OmSjHew5hbq93gxyw8mEtY6w7FxarlTTL1/LPDpsXzmHATww7mI64V3aVOzFkcqOpbJ9lRcSo+8PDJtrDj/Wg7IasV2ief/Ke3qDfzOuNI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6423

T24gMTcvMTAvMjAyMiAxNzo1MSwgSGVucnkgV2FuZyB3cm90ZToNCj4gZGlmZiAtLWdpdCBhL3hl
bi9hcmNoL2FybS9wMm0uYyBiL3hlbi9hcmNoL2FybS9wMm0uYw0KPiBpbmRleCBmMTc1MDBkZGYz
Li4wYjRlMjQyMThlIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMNCj4gKysrIGIv
eGVuL2FyY2gvYXJtL3AybS5jDQo+IEBAIC0xNzg0LDYgKzE4MDAsOCBAQCBpbnQgcDJtX2luaXQo
c3RydWN0IGRvbWFpbiAqZCkNCj4gICAgICAgICAgIWlvbW11X2hhc19mZWF0dXJlKGQsIElPTU1V
X0ZFQVRfQ09IRVJFTlRfV0FMSyk7DQo+ICANCj4gICAgICByYyA9IHAybV9hbGxvY190YWJsZShk
KTsNCj4gKyAgICBpZiAoIHJjICE9IDAgKQ0KPiArICAgICAgICByZXR1cm4gcmM7DQoNClRoaXMg
ZXJyb3IgcGF0aCBub3cgbGVha3MgdGhlIFZNSUQuDQoNCkFuZCB0byBwcmVlbXB0IHRoZSBvYnZp
b3VzIGNoYW5nZSwgaWYgeW91IHNpbXBseSBtb3ZlIHRoaXMgbG93ZXIsIHlvdSdsbA0KaW50cm9k
dWNlIGEgcGF0aCB3aGVyZSBwMm1fdGVhcmRvd24oKSBmYWxscyBvdmVyIGEgTlVMTCBwb2ludGVy
Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 19:13:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 19:13:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424559.672072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVXp-0002HW-Cn; Mon, 17 Oct 2022 19:13:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424559.672072; Mon, 17 Oct 2022 19:13:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVXp-0002HP-9f; Mon, 17 Oct 2022 19:13:01 +0000
Received: by outflank-mailman (input) for mailman id 424559;
 Mon, 17 Oct 2022 19:12:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okVXn-0002HE-UW
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 19:12:59 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b512acd5-4e4f-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 21:12:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b512acd5-4e4f-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666033977;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=nHhP4CicGwE1po6u8WtjJ1vEAs6NcxGF1strgPp5D+M=;
  b=XZU56Zzs4g+Xsobk89R2/HtYaNRW2Kj8lS5KqnGePUlAXy0tUYNfrrRW
   aFahyO73mZc7rCrM71+bM1yUqu0AvZcpzszZCnYvbm6cwHgKEnPAUhiuV
   rpqL0A0VHdeuzZ3Lb3BGJkDKjJBBGShRTtHcwDmaRjbpkpaEyJu+7pf8A
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82918876
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fvkMXKOJtPE0YYLvrR1Al8FynXyQoLVcMsEvi/4bfWQNrUp2hjMGy
 zYfXzjUb/2LMWH0KNp3YYm3o0oC6J/Sx95hHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr52tC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eMrY747t6E3F0p
 b87EAEBclearPOd+efuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI
 ZpCAdZsRE2ojxlnE1EbEp8h2syvgWHyaWZwo1OJv6snpWPUyWSd1ZC9aouMKozVG625mG6Gj
 zzMxU/CMCo2JeSh7yiv23CTl+vQyHaTtIU6S+Tjq68CbEeo7lIUDBoaRF6qu86Tg0S1W89cA
 0EM8y9opq83nGShQ8PhRRS+rDiBtwQFRttLO+Qg7UeGza+8yyaUAHIVCAFIbtMOvdUzAzct0
 zehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/H4u506hB/LStdlEYa2g8fzFDW2x
 CqFxAA8mrESgMgjx6i9u1fdjFqRSoPhF1BvoF+NByT8s10/NNXNi5GUBUbz4s1jNduUXEm77
 Dsno/mS8KcXJoCmrXnYKAkSJ42B6/GAOTzapFdgGZg96jigk0KekZBsDCJWfxkwbJtdEdP9S
 AqK4F4KuscPVJe/RfUvC79dHfjG2kQJ+T7NcvnPJuRDbZFqHONs1HE/PBXAt4wBfaVFrE3eB
 Xt5WZzwZZr5If49pNZTewv6+eZyrh3SPUuJGfjGI+2PiNJynkK9R7YfK0epZesk9q6Cqwi92
 48BaZbbl0gCDrGiP3W/HWsvwbcidCJTOHwLg5YPKr7rzvROQgnN9MM9MZt+Itc4zsy5Z8/D/
 22nW18w9WcTcUbvcF3QAlg6MeuHdc8m/RoG0dkEYA/AN44LOt30ss/ytvIfINEayQCU5aQsE
 qBaJJjRU64np/au0211UKQRZbdKLHyD7T9i9QL8CNTjV/aMnzD0x+I=
IronPort-HdrOrdr: A9a23:Da73vq+p2S7amNtlXhZuk+DQI+orL9Y04lQ7vn2YSXRuE/Bw9v
 re+sjzuiWE6wr5NEtOpTniAtjmfZq/z+8W3WB5B97LN2OK1FdARLsSibcKqAeBJ8SRzIBgPN
 9bAs1DNOE=
X-IronPort-AV: E=Sophos;i="5.95,192,1661832000"; 
   d="scan'208";a="82918876"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH 0/2] arm/p2m: XSA-409 fix
Date: Mon, 17 Oct 2022 20:12:35 +0100
Message-ID: <20221017191237.11079-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

My attempt at a more simple fix than any proposed thus far.  Sadly not as
simple as I was hoping, but it does resolve the bugs according to Gitlab:

  https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/669072903

In particular, it addresses every buggy error path I've spotted in previous
patches.  The preemptible helpers can't safely be rewrapped to work in an
idempotent teardown context.

Andrew Cooper (1):
  arm/p2m: Rework p2m_init()

Henry Wang (1):
  xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

 xen/arch/arm/p2m.c | 67 ++++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 53 insertions(+), 14 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 19:13:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 19:13:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424560.672078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVXp-0002L5-Nq; Mon, 17 Oct 2022 19:13:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424560.672078; Mon, 17 Oct 2022 19:13:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVXp-0002Ks-Ii; Mon, 17 Oct 2022 19:13:01 +0000
Received: by outflank-mailman (input) for mailman id 424560;
 Mon, 17 Oct 2022 19:13:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okVXo-0002HD-Ho
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 19:13:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4fe2e1e-4e4f-11ed-8fd0-01056ac49cbb;
 Mon, 17 Oct 2022 21:12:58 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4fe2e1e-4e4f-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666033977;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=3xz6EapRYQ8Fq100GycK8t7tBLACDmNaRcneaz+jMYU=;
  b=WcFgxBqMVFotnGy+6pgnZFuwpAXUUgK7MZB9MnbBhshm6qyaYQU22BHU
   rV8YpJxD1RQsqMSnnl/Y6x5nHqzyfyKgi5xBYN20Gqw82xWrAwxil21Du
   PaRCeBICPxKsSXJh7Mzsmu6Wp7mHrcuzuFw50NH6HqRwFp9OnSJyNlCT2
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82941464
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ASbhN46gKFI9U3uHyKlbXEaNMX17brhtdUexiu?=
 =?us-ascii?q?6ucsGfUl6mq9fgcCa95VXk6Z2cg+JsCT87dIK/hR2lo1aTMpqcRdC0qbbba9?=
 =?us-ascii?q?ML8jXdDsEdh0got7YTDm+eGxa96EqShD8hztsQ/Qs6ClDEHlkbm7waH7WG8G?=
 =?us-ascii?q?D/sfEhyUH/qkf4XmNGi54QvZhV9d5/T3i7rKkFnYMtekEl+kHxUpPyWbWFSN?=
 =?us-ascii?q?WBatcRp5sI0y+7nXA2X2W26sNl3O+Hy0Ws6jrqgd+NMm95ZRW9rDiPWRoOmI?=
 =?us-ascii?q?2VnAtMKlDE0aCcQT08n1SHPghHCSouinHd4hOQH6eVhpH/CTxbS0oIdu1fXF?=
 =?us-ascii?q?AizDVWXqwkerL28YlGpz0cRuKy9056ksWy40m6r8qECH5JjbHCHVJ1DCqIMG?=
 =?us-ascii?q?P5h+I+uJuU64SZFM3c+XX44IRTBgVwH7rxW0CXv82reKfUo4rlyUtsG1hRmM?=
 =?us-ascii?q?awlIKS7HWBvu8eYBiqbow0zN6WEB/mRK3uLF8YbG4HwiOXdyyz7xl22Q2Pq+?=
 =?us-ascii?q?Ro7dZYr0U4CgssW2SdzfIrFWH/cSXc/XBdW26Jyr3qufZ6vXu1txVp/zfFQ6?=
 =?us-ascii?q?rXu15oBBh0QPJn8vQoC51z1ObJK7LmOp0iQXHz+hughbEXGWKtwjgIf2KOi/?=
 =?us-ascii?q?X3xyQ9EEhoqUa6d5W+XUpzoU65fRLjr45vRqbXVBtxd+ocw1nzV8lEFtw1xC?=
 =?us-ascii?q?tFwE1fendfXTcE8QdtOvsPSWufl4D4cx0JL2qQf026t48JAdMl+pZioVZByc?=
 =?us-ascii?q?0TugxuoCQEm3gY5EAiAaYqa9flre5OMPrXP+5wZxY91HFPtk9Onlqw513aNs?=
 =?us-ascii?q?hzTSk5tng+PxwOvOc4dL0rHk2zAUlS9RVWtCYUYHafvVHBfnJuitCI3ZlLm1?=
 =?us-ascii?q?UfeL7S2TG/FPt+sYQWrMSGHRjbt68fGrlyP+20o7w3DLZFMni0BE2JrrCzmy?=
 =?us-ascii?q?pqReXVL3nYZIRxnC0pJdESiYM1CIjtxUQJxMb19BrGraofPXi0yiFgO4EA6D?=
 =?us-ascii?q?PKuPtnSWYen0ZeqbliyhbaYXuxCwM6iHTWxYy4n3SnivIZ+s+jeK5+/73KUB?=
 =?us-ascii?q?+HrUnERIJc19mcylj0k87xB5RHY+hBxY2rif122IFObQjRvJ/7CHGWjAqvmE?=
 =?us-ascii?q?5L9//cb4O7HLkZcQNgNI4y1tsFPyURPZbV5sD3Ntz1SvgXTqeDHOGi0DSC9c?=
 =?us-ascii?q?0+XBxhhsYZurJfKabWeLsi3AN9E9WAFoLpDJwVeKdcWjb9fZjH2uOl1MoA0k?=
 =?us-ascii?q?W/aBiI0NCYvYwYPg2FR537m9wWr4lZDmjtW3l8D3bjkwSL5Nwul7pOoLEluE?=
 =?us-ascii?q?mHO2IGDP4SNakCfSrzl+1DIlN2dZE9Rxfm/V0dZtUvZyUuuVtLNCzZ/Fguqc?=
 =?us-ascii?q?qAZEJPoSWjdRNmDN8hN05FMCWuEww+PVSkI344kbqbNSnBzyMPsSnXOLQIHo?=
 =?us-ascii?q?i+9THd+ZMHzhoeXwd8FJbf2psjTIjbjVpm5CbhFdg8rtBrfxtNV48TL8tkkD?=
 =?us-ascii?q?elPwTlWuDzVcUSiuTQev4LRizkE8o7x/8omJFwS1lTKQAkDEghUl2Bb12xtD?=
 =?us-ascii?q?7ouiyHudhji9C8c6ticegu9H3oIPfC2gOlvaQNyQy2QVUYiVEhDVYupEGX9I?=
 =?us-ascii?q?i0o1y8Nm/imah04QiLvU7CKls0/P5lPLk1v+lYCoWw+e9tGkIU4V2UUK8Tfd?=
 =?us-ascii?q?OEh9netU6ByLPhN49yIj5v9AqxVeB/UTK83Y5D+vxuGAWfP3zVxM78jYZ6Ru?=
 =?us-ascii?q?bUfukDRQW1h02O6Mt89Y4BB0qm+XmJ+FHhxuLH93ykK7Zsc7rMPI+QhhDZGa?=
 =?us-ascii?q?ZeYatgfj+oCmCCKN0DUgwmvNfkGAU+EXXiruh5SKxVtMQVTJ27Gxn9YoQXyk?=
 =?us-ascii?q?C37D9zexqmgrBg1wmPViEAH4wjiQ6HPGyFLDK8KP4PcH4EvNSwaj+HsayvuD?=
 =?us-ascii?q?QIz4iDifk8SfghnDwzWjc7ZTYDLiU/5tyEN7RcWi5ZxzRWrzYlj9R8DFV3nu?=
 =?us-ascii?q?2Wh/5g/nK8c0E/IWwyfF56s6Teuz8WH5p42GcK4raFhi00SLFHA+pwhBZCqK?=
 =?us-ascii?q?8y4y6KtcQ+CzDgfSmrXf//2wyaP11ht11ZldD7DdFj4RUl23gkyqxRHlDtn/?=
 =?us-ascii?q?OpOVfDYqAKzIaEYnHEAvEclh7MfYv1qKwBNMs8qPzNIZtjYruG0Yq0a0SXiS?=
 =?us-ascii?q?FnEKiEYpgeg2zxCrRkBFVi2igYj/df+Zy/p6byTpsf12uIN11Q1uGKi6rwS+?=
 =?us-ascii?q?Qo3J0qJ6l3eahMHvoCdEmYlgJ9/n8o8wjXUhDVg2l8Q8PwpHPIWJKAgwtNXL?=
 =?us-ascii?q?ycJKtzWwjC9gbEza2JtlNaBplrYV7jk7rInQCX7dgJjRymKyNBSluiidCT5G?=
 =?us-ascii?q?jZ5si8vxDB8YPHd/cLipc2iyj+D0vByC7iD/QLZIJOseZDtW1EY56UALRiUS?=
 =?us-ascii?q?MF0FQCqsuFhsrbgh/3fMYhcg6VhOY6Q+Nft3QhO0V8auRzGThytwxJwckFAv?=
 =?us-ascii?q?bcsgeTJcqwE3zFP5q38dNqhA2FV06ypTdesWDtU00Z00X3m09M5l0ur3ke+1?=
 =?us-ascii?q?2EfZcz/Ym3/WVnP+fns5ziV12wv3QyUIvBnWFsYVrNqP5Z9ZvbVBLDbAqBhB?=
 =?us-ascii?q?gVdLoiHW8//BY7d5e1LoAbyOSJqxKQKhvy+KE0qR5zqwbPunkcnMcaYObz1F?=
 =?us-ascii?q?uWrAsGV5C9HaTs6B+zaQuQBh6DFVqnqhhimSybr2C9raCQMkpTxQHPXDCnnY?=
 =?us-ascii?q?tSad63os+URZyOVV0G0dGDQr0D4Vo5Zr37MhV+JCJY7nZ1bveYjnHyuKHtTB?=
 =?us-ascii?q?+PxqpnJpASC2AqGElLDjvS2YxeVumhL0N+Ru19fbkE5hBZbSDxQvJjI19y/o?=
 =?us-ascii?q?wmkxCM1w6yNl3b6f+xaKstx9y5Y2bwIpjFz05paFybmPwdy/IzfPwSt/E7vX?=
 =?us-ascii?q?dCT/g2yvh0o59A6tcs27Ig76ZhyXd4K5tUMpKtBp0hrEG4DA9Bbop1usC1Mf?=
 =?us-ascii?q?uLfzu+O4KgXwKz5D/WiB7MUXmvT34p7VFoN0w=3D=3D?=
X-IronPort-AV: E=Sophos;i="5.95,192,1661832000"; 
   d="scan'208";a="82941464"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH 1/2] arm/p2m: Rework p2m_init()
Date: Mon, 17 Oct 2022 20:12:36 +0100
Message-ID: <20221017191237.11079-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221017191237.11079-1-andrew.cooper3@citrix.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

p2m_init() is mostly trivial initialisation, but has two failable operations
which are on either side of the backpointer trigger for teardown to take
actions.

p2m_free_vmid() is idempotent with a failed p2m_alloc_vmid(), so rearrange
p2m_init() to perform all trivial setup, then set the backpointer, then
perform all failable setup.

This will simplify a future bugfix which needs to add a third failabile
operation.

No practical change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Henry Wang <Henry.Wang@arm.com>
---
 xen/arch/arm/p2m.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3a3..6826f6315080 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1754,7 +1754,7 @@ void p2m_final_teardown(struct domain *d)
 int p2m_init(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
-    int rc = 0;
+    int rc;
     unsigned int cpu;
 
     rwlock_init(&p2m->lock);
@@ -1763,11 +1763,6 @@ int p2m_init(struct domain *d)
     INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist);
 
     p2m->vmid = INVALID_VMID;
-
-    rc = p2m_alloc_vmid(d);
-    if ( rc != 0 )
-        return rc;
-
     p2m->max_mapped_gfn = _gfn(0);
     p2m->lowest_mapped_gfn = _gfn(ULONG_MAX);
 
@@ -1783,8 +1778,6 @@ int p2m_init(struct domain *d)
     p2m->clean_pte = is_iommu_enabled(d) &&
         !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK);
 
-    rc = p2m_alloc_table(d);
-
     /*
      * Make sure that the type chosen to is able to store the an vCPU ID
      * between 0 and the maximum of virtual CPUS supported as long as
@@ -1797,13 +1790,20 @@ int p2m_init(struct domain *d)
        p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID;
 
     /*
-     * Besides getting a domain when we only have the p2m in hand,
-     * the back pointer to domain is also used in p2m_teardown()
-     * as an end-of-initialization indicator.
+     * "Trivial" initialisation is now complete.  Set the backpointer so
+     * p2m_teardown() and friends know to do something.
      */
     p2m->domain = d;
 
-    return rc;
+    rc = p2m_alloc_vmid(d);
+    if ( rc )
+        return rc;
+
+    rc = p2m_alloc_table(d);
+    if ( rc )
+        return rc;
+
+    return 0;
 }
 
 /*
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 19:13:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 19:13:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424561.672094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVY0-0002ta-3P; Mon, 17 Oct 2022 19:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424561.672094; Mon, 17 Oct 2022 19:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVXz-0002tN-WD; Mon, 17 Oct 2022 19:13:12 +0000
Received: by outflank-mailman (input) for mailman id 424561;
 Mon, 17 Oct 2022 19:13:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okVXy-0002HE-Qw
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 19:13:10 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc0341f8-4e4f-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 21:13:09 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc0341f8-4e4f-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666033989;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=zg8npnhOVrxpSfiRTibSjk6fhmpTfF4qsEdQGzlDU0g=;
  b=bw48FFOOVtoT6llrXOBKc300kDCiTK0ZA4d7mKBbt7u1kKoRRyTmNQrV
   O08vt2K5QLU3+5BfmCyk5oajc8E91EVBZbaX9WI1xOLfm88VQRmjKu0oM
   Rmu1/dNjKnlDvibA74G9XSPOx4U1BRyEMKfWVKD1hmZ9JqJBbN/Zdk4lO
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82918898
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:58o5TKuhagTXl6UGUPTi3QI+9efnVLNeMUV32f8akzHdYApBsoF/q
 tZmKW3VPPjbN2ajL9wgPI+/pk4EvZ/VnIdlGlNtrH0yE3lB+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPakU5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklO8
 tAyGjoLTyrYjsmk2e2dUvhRvZs8eZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI
 ZBDMHw2MUqGM0Yn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZUPzx/I9
 jOWl4j/Ki84JYGlmR/Yy261pMLRkxKlc6IbRaLto5aGh3XMnzdOWXX6T2CTn/69jUKvXsNFH
 GYd8CEusKsa+VSiS5/2WBjQiF6JuAQNHeVZFeIS4RuIjKHT5m6xDGUeUiRIbtBgscYsXCErz
 XeAhdavDjtq2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZs14DKe/g9nxGDfx6
 zOHti4zg/MUl8Fj/6em+VHKhRq8q56PSRQ6jjg7RUr8sFk/PtT8IdX1tx6Ltp6sMbp1UHGBu
 1QuqcKYzdpVBLqfjXOrWPQwJ+62sqPt3CLnvXZjGJwo9jKI8nGlfJxN7DwWGHqFIvroaheyP
 haN5Fo5CIt7eSLzMPQpO97Z59ECl/CIKDjzahzDgjOiiLBVfRTPwixhbFX4M4vFwBl1yvFX1
 Xt2nK+R4Zcm5UZPlmbeqwQ1i+VDKsUCKYT7HMmT8vhf+eDCDEN5sJ9cWLd0Usg37bmfvCLe+
 MtFOs2Bxn13CbOgP3iLrNNNcQxXcRDX4KwaTOQOLIa+zvdOQjl9W5c9P5t7E2Cao0ilvriRp
 SzsMqOp4FH+mWfGOW23V5yXU5u2BcwXhStiZUQEZA/4s0XPlK7ytc/zgbNsJuJ5nAGipNYpJ
 8Q4lzKoWKwSE2uYpmVMN/EQbuVKLXyWuO5HBAL9CBBXQnKqb1ahFgPMFuc3yBQzMw==
IronPort-HdrOrdr: A9a23:rb2NaK/REOfo9q74cWZuk+DQI+orL9Y04lQ7vn2YSXRuE/Bw9v
 re+sjzuiWE6wr5NEtOpTniAtjmfZq/z+8W3WB5B97LN2OK1FdARLsSibcKqAeBJ8SRzIBgPN
 9bAs1DNOE=
X-IronPort-AV: E=Sophos;i="5.95,192,1661832000"; 
   d="scan'208";a="82918898"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Henry Wang <Henry.Wang@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Date: Mon, 17 Oct 2022 20:12:37 +0100
Message-ID: <20221017191237.11079-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221017191237.11079-1-andrew.cooper3@citrix.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

From: Henry Wang <Henry.Wang@arm.com>

The XSA-409 fixes discovered that the GICv2 path tries to create P2M mappings
in the domain_create() path.  This fails, as the P2M pool is empty before a
XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION hypercall.

As a stopgap, automatically give domains 16 pages of P2M memory.  This is
large enough to allow the GICv2 case to work, but small enough to not
introduce a continuation worry.

A consequence is that, for later error paths domain_create(), we end up in
p2m_final_teardown() with a nonzero P2M pool.  Such a domain has no vCPUs, and
has never been scheduled, so free the memory directly.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Henry Wang <Henry.Wang@arm.com>
---
 xen/arch/arm/p2m.c | 43 +++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 41 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 6826f6315080..76a0e31c6c8c 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1736,8 +1736,36 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
-    ASSERT(page_list_empty(&p2m->pages));
-    ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
+    /*
+     * On the domain_create() error path only, we can end up here with a
+     * non-zero P2M pool.
+     *
+     * At present, this is a maximum of 16 pages, spread between p2m->pages
+     * and the free list.  The domain has never been scheduled (it has no
+     * vcpus), so there is TLB maintenance to perform; just free everything.
+     */
+    if ( !page_list_empty(&p2m->pages) ||
+         !page_list_empty(&d->arch.paging.p2m_freelist) )
+    {
+        struct page_info *pg;
+
+        /*
+         * There's no sensible "in the domain_create() error path" predicate,
+         * so simply sanity check that we don't have unexpected work to do.
+         */
+        ASSERT(d->arch.paging.p2m_total_pages <= 16);
+
+        spin_lock(&d->arch.paging.lock);
+
+        while ( (pg = page_list_remove_head(&p2m->pages)) )
+            free_domheap_page(pg);
+        while ( (pg = page_list_remove_head(&d->arch.paging.p2m_freelist)) )
+            free_domheap_page(pg);
+
+        d->arch.paging.p2m_total_pages = 0;
+
+        spin_unlock(&d->arch.paging.lock);
+    }
 
     if ( p2m->root )
         free_domheap_pages(p2m->root, P2M_ROOT_ORDER);
@@ -1803,6 +1831,17 @@ int p2m_init(struct domain *d)
     if ( rc )
         return rc;
 
+    /*
+     * Hardware using GICv2 wants to create an 8KB MMIO mapping during
+     * domain_create(), which requires some P2M pagetables.  Allocate 16 page
+     * which is good enough for now.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+    if ( rc )
+        return rc;
+
     return 0;
 }
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 17 19:33:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 19:33:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424578.672105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVrp-00062S-Ot; Mon, 17 Oct 2022 19:33:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424578.672105; Mon, 17 Oct 2022 19:33:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okVrp-00062L-Lh; Mon, 17 Oct 2022 19:33:41 +0000
Received: by outflank-mailman (input) for mailman id 424578;
 Mon, 17 Oct 2022 19:33:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okVro-00062B-Qn; Mon, 17 Oct 2022 19:33:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okVro-0006bt-Kr; Mon, 17 Oct 2022 19:33:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okVro-00032X-2R; Mon, 17 Oct 2022 19:33:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okVro-0005an-20; Mon, 17 Oct 2022 19:33:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UbYjAPTLfdP1p8XwJeF5SmqznPqjMQJRTKDMfMdxH2E=; b=pWHUVaYoaEZjbpg0Nby//HpfyB
	pMMVaMPAvyc9Bqyh/k1i3svYCkViZYwoa/aH98QtsINXeqy9mcFZZF6jMRkCnI+9fyg/WiicMykvp
	RJgyEWf+//nlRxW3Hiejy7ZX2QMILnZfpw255nRSL6ig9sqcOwBzm4AlaUgQJQ9oZN+4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173935-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 173935: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:build-arm64-pvops:kernel-build:fail:regression
    xen-4.13-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 19:33:40 +0000

flight 173935 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173935/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549
 build-arm64-pvops             6 kernel-build   fail in 173814 REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173814 pass in 173935
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot              fail pass in 173814

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-xl           1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 173814 n/a
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   63 days
Failing since        173495  2022-10-11 14:08:01 Z    6 days    7 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    4 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 20:25:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 20:25:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424586.672116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okWfS-0003Bi-Jo; Mon, 17 Oct 2022 20:24:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424586.672116; Mon, 17 Oct 2022 20:24:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okWfS-0003Bb-H5; Mon, 17 Oct 2022 20:24:58 +0000
Received: by outflank-mailman (input) for mailman id 424586;
 Mon, 17 Oct 2022 20:24:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okWfR-0003BV-Sz
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 20:24:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okWfR-0007ap-HS; Mon, 17 Oct 2022 20:24:57 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okWfR-0006rZ-A6; Mon, 17 Oct 2022 20:24:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=GNKtICVhLR/BEOpNfwnGX3ujSH6r7CPVHqIBmsq5yGQ=; b=V3L3XOptCVxIkxb85AlYWTdhaj
	zKoc3TVNRvsgAANK7obu5njTYjK+c1VvuyD6zFHCk1HB5Dv6QiNfHTm3WskxylfZyNUzmLEZi99yJ
	OAaVXQ61ulR3azAWLkmR3zTBzwzntjil6s00qkuISIA9BZh983j2+Qdr7v38ZA5kVIao=;
Message-ID: <3cd9f882-090a-b4ba-df87-663a9a375737@xen.org>
Date: Mon, 17 Oct 2022 21:24:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 1/2] arm/p2m: Rework p2m_init()
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-2-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221017191237.11079-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andrew,

On 17/10/2022 20:12, Andrew Cooper wrote:
> p2m_init() is mostly trivial initialisation, but has two failable operations
> which are on either side of the backpointer trigger for teardown to take
> actions.
> 
> p2m_free_vmid() is idempotent with a failed p2m_alloc_vmid(), so rearrange
> p2m_init() to perform all trivial setup, then set the backpointer, then
> perform all failable setup.
> 
> This will simplify a future bugfix which needs to add a third failabile

Typo:  s/failabile/fallible?

> operation.
> 
> No practical change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 20:36:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 20:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424593.672127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okWqD-0004o5-Ng; Mon, 17 Oct 2022 20:36:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424593.672127; Mon, 17 Oct 2022 20:36:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okWqD-0004ny-KL; Mon, 17 Oct 2022 20:36:05 +0000
Received: by outflank-mailman (input) for mailman id 424593;
 Mon, 17 Oct 2022 20:36:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okWqC-0004ns-5d
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 20:36:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okWqB-0007ob-I7; Mon, 17 Oct 2022 20:36:03 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okWqB-0007IS-Cs; Mon, 17 Oct 2022 20:36:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=ZDoKRqdEUVIZJRdouTDUvuzP9UoNdQH+aHz7DhW9VJ8=; b=2aZXz2OArnFvYWQh0lYmsK4cDc
	gP3z0gxyRWv4fGeE1yWyAYmQ+VdPvKl4qyozXe6RZo6wF+1+tjBOvHLQ9JcFb0s2C2vNqO2CRUWBp
	4olBnmMFnxZKimdW5QXBtpQsznBiyUBKqi6N+gUq/nW2hDQzdRzdVj1nNwGnL1VNfHcQ=;
Message-ID: <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
Date: Mon, 17 Oct 2022 21:36:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
In-Reply-To: <20221017191237.11079-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Andrew,

On 17/10/2022 20:12, Andrew Cooper wrote:
> From: Henry Wang <Henry.Wang@arm.com>
> 
> The XSA-409 fixes discovered that the GICv2 path tries to create P2M mappings
> in the domain_create() path.  This fails, as the P2M pool is empty before a
> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION hypercall.
> 
> As a stopgap, automatically give domains 16 pages of P2M memory.  This is
> large enough to allow the GICv2 case to work, but small enough to not
> introduce a continuation worry.
> 
> A consequence is that, for later error paths domain_create(), we end up in
> p2m_final_teardown() with a nonzero P2M pool.  Such a domain has no vCPUs, and
> has never been scheduled, so free the memory directly.
> 
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
> Suggested-by: Julien Grall <jgrall@amazon.com>

This is not really in the spirit of my original suggestion anymore... In 
fact, you drop all the explanations regarding how the code is fragile 
(e.g. we are relying on early mapping to not take any extra reference). 
Maybe you don't care, but I do as Henry and I spent ages to figure out 
all the corner cases. In addition to that...

> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: Bertrand Marquis <bertrand.marquis@arm.com>
> CC: Henry Wang <Henry.Wang@arm.com>
> ---
>   xen/arch/arm/p2m.c | 43 +++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 6826f6315080..76a0e31c6c8c 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1736,8 +1736,36 @@ void p2m_final_teardown(struct domain *d)
>       if ( !p2m->domain )
>           return;
>   
> -    ASSERT(page_list_empty(&p2m->pages));
> -    ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
> +    /*
> +     * On the domain_create() error path only, we can end up here with a
> +     * non-zero P2M pool.
> +     *
> +     * At present, this is a maximum of 16 pages, spread between p2m->pages
> +     * and the free list.  The domain has never been scheduled (it has no
> +     * vcpus), so there is TLB maintenance to perform; just free everything.
> +     */
> +    if ( !page_list_empty(&p2m->pages) ||
> +         !page_list_empty(&d->arch.paging.p2m_freelist) )
> +    {
> +        struct page_info *pg;
> +
> +        /*
> +         * There's no sensible "in the domain_create() error path" predicate,
> +         * so simply sanity check that we don't have unexpected work to do.
> +         */
> +        ASSERT(d->arch.paging.p2m_total_pages <= 16);
> +
> +        spin_lock(&d->arch.paging.lock);
> +
> +        while ( (pg = page_list_remove_head(&p2m->pages)) )
> +            free_domheap_page(pg);
> +        while ( (pg = page_list_remove_head(&d->arch.paging.p2m_freelist)) )
> +            free_domheap_page(pg);
> +
> +        d->arch.paging.p2m_total_pages = 0;
> +
> +        spin_unlock(&d->arch.paging.lock);
> +    }

... you are hardcoding both p2m_teardown() and p2m_set_allocation().
IMO this is not an improvement at all. It is just making the code more 
complex than necessary and lack all the explanation on the assumptions.

So while I am fine with your patch #1 (already reviewed it), there is a 
better patch from Henry on the ML. So we should take his (rebased) 
instead of yours.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 20:39:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 20:39:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424599.672137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okWtj-0005UY-5A; Mon, 17 Oct 2022 20:39:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424599.672137; Mon, 17 Oct 2022 20:39:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okWtj-0005UR-2Y; Mon, 17 Oct 2022 20:39:43 +0000
Received: by outflank-mailman (input) for mailman id 424599;
 Mon, 17 Oct 2022 20:39:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vX9e=2S=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okWth-0005UL-EB
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 20:39:41 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d24ef2b5-4e5b-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 22:39:39 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CD82CB818FD;
 Mon, 17 Oct 2022 20:39:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD13BC433C1;
 Mon, 17 Oct 2022 20:39:36 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d24ef2b5-4e5b-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666039177;
	bh=C/1urEwT1MQW3c0dXTb82hFUdZvc8s1IQQMSysyWdxg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=HsVUxEnHd7/9J3CCBOwP8X+xE1E51KYL217vQFmjogKVehV4KJIiPiOUNOYrXwZfn
	 h1WwdV6L5rR5X5uspFyTQ4IXFog3J9SqLU44AKPZN6b5lT4iD0U5xpSz7oDgx4W5BX
	 daJFUt4jETG6qmNnHRx+Zkd0SjxmeuYvf0KjyvMAL8it6/TOjxK9ezBDFALxjriG0H
	 86GMYMjrVtCMACYbCMjHPzVo9XTj8g7nVTmWd/yc2cvw/7TELx/M1vuf7EeCkEFP9L
	 7GW9Xvjn5A6PRBxX76jkcrJBaTqMJH/u6cNprvjaNtAyopl3A4GzqiAhN8Y8GMPDfW
	 qWq+w6vF1uGgg==
Date: Mon, 17 Oct 2022 13:39:35 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
In-Reply-To: <16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210171323450.2351079@ubuntu-linux-20-04-desktop>
References: <20221006174804.2003029-1-olekstysh@gmail.com> <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop> <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com> <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
 <16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1581651934-1666038339=:2351079"
Content-ID: <alpine.DEB.2.22.394.2210171326490.2351079@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1581651934-1666038339=:2351079
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210171326491.2351079@ubuntu-linux-20-04-desktop>

On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
> On 13.10.22 03:33, Stefano Stabellini wrote:
> 
> Hello Stefano
> 
> > On Wed, 12 Oct 2022, Oleksandr Tyshchenko wrote:
> >>> On Thu, 6 Oct 2022, Oleksandr Tyshchenko wrote:
> >>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>>>
> >>>> Use the same "xen-grant-dma" device concept (based on generic IOMMU
> >>>> device-tree bindings) for the PCI devices behind device-tree based
> >>>> PCI Host controller.
> >>>>
> >>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>>> ---
> >>>> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> >>>> on Arm at some point in the future. The Xen toolstack side is not published yet.
> >>>> Here, for PCI devices we use the same way to pass backend domid to the guest as for
> >>>> platform devices.
> >>>>
> >>>> Depends on Juergen's series:
> >>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006071500.15689-1-jgross@suse.com/__;!!GF_29dbcQIUBPA!waOk2Goc7qlhNo5-csRObryil_GzMF_e61EJR501oJ08cH2dnJulsZXWlelBDTBqa63TVoUcWQTB5NecJ1p4xFNgh2_EuA$  [lore[.]kernel[.]org]
> >>>> ---
> >>>>    drivers/xen/grant-dma-ops.c | 51 +++++++++++++++++++++++++++++--------
> >>>>    1 file changed, 41 insertions(+), 10 deletions(-)
> >>>>
> >>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> >>>> index ff9be3aff87e..79d13122ec08 100644
> >>>> --- a/drivers/xen/grant-dma-ops.c
> >>>> +++ b/drivers/xen/grant-dma-ops.c
> >>>> @@ -10,6 +10,7 @@
> >>>>    #include <linux/module.h>
> >>>>    #include <linux/dma-map-ops.h>
> >>>>    #include <linux/of.h>
> >>>> +#include <linux/pci.h>
> >>>>    #include <linux/pfn.h>
> >>>>    #include <linux/xarray.h>
> >>>>    #include <linux/virtio_anchor.h>
> >>>> @@ -273,12 +274,28 @@ static const struct dma_map_ops xen_grant_dma_ops = {
> >>>>    	.dma_supported = xen_grant_dma_supported,
> >>>>    };
> >>>>    
> >>>> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> >>>> +static struct device_node *xen_dt_get_node(struct device *dev)
> >>>> +{
> >>>> +	if (dev_is_pci(dev)) {
> >>>> +		struct pci_dev *pdev = to_pci_dev(dev);
> >>>> +		struct pci_bus *bus = pdev->bus;
> >>>> +
> >>>> +		/* Walk up to the root bus to look for PCI Host controller */
> >>>> +		while (!pci_is_root_bus(bus))
> >>>> +			bus = bus->parent;
> >>>> +
> >>>> +		return of_node_get(bus->bridge->parent->of_node);
> >>>> +	}
> >>> Is it possible to have multiple virtio devices under a single virtio-pci
> >>> root complex?
> >> yes
> >>
> >>
> >>> What if virtio-net has the backend in dom0 and
> >>> virtio-block has the backend in dom1?
> >>>
> >>> Or each virtio PCI device shows up under a different PCI root complex?
> >>
> >> Good questions. To be honest, it is not 100% clear to me yet how it is
> >> supposed to be. But let's guess...
> >>
> >> I think that having a PCI Host bridge per virtio-pci device is overkill.
> >>
> >> So, I see two options here:
> >> 1. We provide PCI Host bridge per backends domain to the guest, so each
> >> PCI Host bridge covers only virtio-pci devices whose backends are
> >> running within *the same* domain.
> >> With that we would be able to use property at PCI Host bridge level.
> >>
> >> 2. We provide only a single PCI Host bridge to the guest, so that single
> >> PCI Host bridge covers all virtio-pci devices assigned to this guest.
> >> No matter where the corresponding backends are running (the
> >> virtio-devices under that PCI Host bridge can have the backends in
> >> different domains).
> >> With that we wouldn’t be able to use property at PCI Host bridge level.
> >> And we need a more flexible option(s) to be able distinguish between
> >> virtio-pci devices.
> >>
> >> Taking into account that for virtio-pci on Arm we need to emulate a
> >> specific PCI Host bridge in Xen to intercept the guest PCI config space
> >> accesses
> >> (detect what PCI device is targeted) and forward them to the appropriate
> >> backend (IOREQ Server),
> >> it feels to me that we likely need to go with the second option here
> >> (one PCI host bridge per guest), I may mistake,
> >> but I don’t think that we want to emulate several PCI Host bridges for a
> >> single guest (more code, more resources, etc).
> >>
> >>
> >>
> >>> If we can have multiple virtio PCI devices under a single PCI root
> >>> complex, then I think it would be better to check for a per-device
> >>> property, rather than a single property at the PCI root complex level.
> >> Completely agree.
> >>
> >>
> >>> The first thing that comes to mind is to describe each PCI device under
> >>> the root complex in device tree. Although it is uncommon (usually only
> >>> the PCI root complex is described in device tree), it is possible to
> >>> also describe in device tree all the individual PCI devices under the
> >>> root complex.
> >>>
> >>> Given that the domU device tree is generated by Xen and/or the Xen
> >>> toolstack, it would be easy to arrange for it to happen.
> >> Technically yes. If we decide to provide only a single PCI Host bridge
> >> to the guest, we will have have to deal with the virtio-pci devices with
> >> various backend_domid,
> >> so we can consider using more flexible property
> >> “iommu-map”/”iommu-map-mask” specially introduced for such purposes:
> >> https://urldefense.com/v3/__https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt__;!!GF_29dbcQIUBPA!17Dk_s8c_5QCQDmLM1FYp695LuUMSTrUV6HPfRA9BgmVz9TRRDZBOuzsdZw_c6G0ogky1P11gql9CHAOshukWmv7zWS0dQ$  [kernel[.]org]
> >> I think, with that we would be able to describe, i.e that virtio-pci
> >> device A connects to stream_id (backend_domid) X and virtio-pci device B
> >> to stream_id Y,
> >> and virtio-pci device C to nothing (so is not required to use grants),
> >> unless I missed something.
> >>
> >> I have looked at it and I don’t see at the moment why the idea wouldn’t
> >> work, but I haven’t experimented with that yet in such context.
> > I think it would work too
> 
> 
> I have experimented with that, it works. And I have already created a patch.
> 
> https://lore.kernel.org/xen-devel/20221015153409.918775-1-olekstysh@gmail.com/
> 
> 
> What I was thinking is although generic PCI-IOMMU bindings 
> ("xen-grant-dma") wouldn't likely be suitable for *future* hotplug support,
> it would allow us to have the working solution on Arm (with a minimal 
> changes, only drivers/xen/grant-dma-ops.c is touched)
> at least for PCI devices which are known at the domain creation time. Of 
> course, this needs the proper support in the toolstack.

Yeah, it is hard to argue against this, as we don't have a good
alternative :-)


> >>> That would solve the issue as far as I can tell, but I worry it might
> >>> not be a good idea because if we rely on the per-device device tree node
> >>> to be present then it becomes harder to implement virtio hotplug
> >>> (Virtio hotplug is important to add dom0less support.)
> >>>
> >>> Let's say that we create a dom0less domU with an emulated PCI root
> >>> complex without any devices under it, then after Dom0 is fully booted,
> >>> we add a virtio-net emulated device. How do we tell the guest what is
> >>> the backend domain id?
> >>>
> >>> Device tree and other firmware tables are not relevant anymore.
> >>>
> >>> We could reuse a PCI config space register to expose the backend id.
> >>> However this solution requires a backend change (QEMU) to expose the
> >>> backend id via an emulated register for each emulated device.
> >>>
> >>> To avoid having to introduce a special config space register in all
> >>> emulated PCI devices (virtio-net, virtio-block, etc) I wonder if we
> >>> could add a special PCI config space register at the emulated PCI Root
> >>> Complex level.
> >>>
> >>> Basically the workflow would be as follow:
> >>>
> >>> - Linux recognizes the PCI Root Complex as a Xen PCI Root Complex
> >>> - Linux writes to special PCI config space register of the Xen PCI Root
> >>>     Complex the PCI device id (basically the BDF)
> >>> - The Xen PCI Root Complex emulated by Xen answers by writing back to
> >>>     the same location the backend id (domid of the backend)
> >>> - Linux reads back the same PCI config space register of the Xen PCI
> >>>     Root Complex and learn the relevant domid
> >>>
> >>> What do you think?
> >>
> >> I think the idea sounds indeed interesting and would probably work, but
> >> would require guest modifications other than just in drivers/xen (and
> >> likely the specification changes as well).
> >> Which ideally of course should be avoided.
> >> Also I was thinking it would be nice not to diverge much between
> >> communicating the backend_domid for platform and PCI devices on Arm with
> >> device tree.
> >>
> >> If we managed to re-use generic IOMMU device-tree bindings for
> >> virtio-mmio, we would likely be able to re-use PCI-IOMMU device-tree
> >> bindings for virtio-pci,
> >> at least for boot PCI devices (which are known at the domain creation time).
> >> The more, the bindings is already present:
> >> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml__;!!GF_29dbcQIUBPA!17Dk_s8c_5QCQDmLM1FYp695LuUMSTrUV6HPfRA9BgmVz9TRRDZBOuzsdZw_c6G0ogky1P11gql9CHAOshukWmvpfF8GmA$  [git[.]kernel[.]org]
> > I think using a special config space register in the root complex would
> > not be terrible in terms of guest changes because it is easy to
> > introduce a new root complex driver in Linux and other OSes. The root
> > complex would still be ECAM compatible so the regular ECAM driver would
> > still work. A new driver would only be necessary if you want to be able
> > to access the special config space register.
> 
> 
> This needs an additional investigation.
> 
> 
> >
> > That said, for sure the fewer changes to the guest the better and I like
> > the existing xen,grant-dma binding.
> >
> >
> >> Regarding the hotplug devices, yes it is a valid use-case which should
> >> be also supported with virtio-pci, I assume the Xenstore could be
> >> re-used for that purpose if it would be available.
> >> The Xenstore is available with the usual Dom0 and toolstack, is it
> >> available with dom0less?
> > Xenstore is available for dom0less if we have a dom0 running with
> > xenstored as one of the dom0less domains. We currently rely on it for
> > Xen PV drivers with dom0less.  After dom0 is fully booted, we use "xl
> > network-attach" to create a vif interface dynamically in the domU.
> >
> > That is why I was thinking of using virtio hotplug to solve the same
> > problem with virtio, I was imagining that after dom0 is fully booted we
> > would do "xl virtio-attach" and create a new virtio interface in the
> > domU. But I cannot see an easy way to make virtio hotplug work together
> > with the xen,grant-dma bindings. I think it would be better if we find a
> > way to make it work without xenstore (because xenstore would be a
> > safety-certification dependency).
> 
> I got your concern regarding the usage of xenstore in general.
> Also I got that hotplug is the only way to get virtual devices (either 
> PV or virtio) working for the dom0less system, is my understanding correct?

In a dom0less system domains boot in parallel. The backend is typically
in a larger and slower domain to boot (Linux). So to solve the problem
with Xen PV drivers, we hotplug Xen PV devices after dom0 is booted ("xl
network-attach" for instance).

With virtio, we could either do the same (use virtio hotplug) or find a
way to tell the frontend to delay initialization. The point is that we
don't want to frontend to try to access backend resources before the
backend is up and running.


> The virtio hotplug could *probably* work together with the 
> "xen,grant-dma" bindings with some prerequisites (backend domid should 
> be known in advance),
> but I am not quite as I am not too familiar with dom0less details. But 
> anyway, I will try to describe it...
> 
> As far as I know the dom0less DomUs are configured from the device-tree. 
> So the configuration is known and prepared beforehand.
> I may guess that we know in what DomU1 we are going to run the virtio 
> backends and what PCI devices we are going to assign to DomU2. So when 
> Xen generating device-tree
> for DomU2 it could create proper iommu-map for the PCI Host bridge node. 
> Although for this to work we would need an ability to configure domain 
> ID (d->domain_id) via device-tree
> and likely reserve some range of domain IDs (to not cross with 
> max_init_domid). But, it wouldn't be 100% hotplug then.

That's fine it doesn't have to be 100% hotplug. In reality, this is a
static configuration so we know all the information beforehand (which VM
is the backend, which is the frontend, which devices are
shared/emulated). The only issue is that we need a way to tell VM2 to
wait for the backend in VM1 to come online. But the device tree could
contain all information from the start.
 

> > Maybe we need to think outside the box and find another solution that
> > doesn't rely on hotplug.
> >
> > For instance, let's say that we expose the virtio devices in device tree
> > in a dom0less configuration too but with status = "disabled". When dom0
> > (or backend domain) is up and running it can signal that it is ready.
> > Maybe if we had a special Xen-specific PCI Root Complex driver in the
> > guest, it could wait for the Xen signal and then continue PCI probing at
> > that point honoring xen,grant-dma bindings if present in device tree
> > even if the devices had status = "disabled" initially.
> >
> > It looks like that would require many guest changes unfortunately.
> 
> 
> It looks like yes, also you mentioned "it can signal that it is ready",
> the question is by what means (xenstore would be a god fit here...)?

Maybe xenstore, yes. The problem is that we want something that works
with minimal drivers changes, and the problem is that if we present the
virtio devices in device tree from boot, the drivers will try to probe
them immediately. We need a way to delay that.


> And I haven't seen that virtio-pci devices are described in device-tree 
> somewhere, only generic PCI host bridge node
> is described. The virtio-pci devices will be detected the same way as 
> usual PCI devices during boot. Unless I missed something.

Yes exactly, and that is the problem. How do we make those driver "wait"
before probing.


> Regarding the virtio-mmio (platform) devices, yes, we could expose them 
> with status "disabled", and they won't get probed by default.
> To be honest, I have experimented with that, when I was thinking of 
> possible hotplug for virtio-mmio devices (I know, this sounds uncommon 
> and strange).
> I used Linux feature (CONFIG_OF_DYNAMIC, overlays) to update the 
> device-tree on running guest, so the toolstack initially inserts 
> virtio-mmio device nodes for non-boot devices
> with status "disabled", and at the runtime, once we receive an event for 
> example, we change the status to "ok" and the corresponding virtio-mmio 
> device gets probed.
> But again, it is not a 100% hotplug, as we need to pre-allocate memory 
> range and interrupt in advance (when generating guest device tree).

Actually this is really cool! Does it work? It doesn't matter to me if
the virtio devices are pci or mmio as long as we can solve the "wait"
problem. So this could be a good solution.


> > As an alternative I wonder, given that Xen emulates the PCI root
> > complex, if we can reuse one of the PCI link up/down delays for this
> > instead, like "pcie_wait_for_link". It looks like the wait time is in
> > millisec while we would need potentially several seconds here but it
> > might be possible?
> 
> I am not sure that I understand this alternative idea.

The PCI subsystem has already a concept of wait times. Just have a look
at pcie_wait_for_link under drivers/pci. The question was whether we can
find a way to reuse one of the existing wait times to deal with our
"wait" problem.

 
> >
> > Other ideas?
> 
> Another (crazy?) idea is to reuse CONFIG_XEN_VIRTIO_FORCE_GRANT for 
> dom0less system (I mean without "xen,grant-dma" bindings at all).
> If virtio backends are always going to run in Dom0 when we have it up 
> and running, then it should work as domid == 0 is reserved for Dom0.
> If there is a need to run virtio backends in other *backend* domain (for 
> the domain ID to be always known we could reserve an ID for it, so it 
> would be a const value),
> we could probably introduce something configurable like 
> CONFIG_XEN_VIRTIO_FORCE_GRANT_BE_DOMID with 0 by default (or cmd line 
> option).

The problem in a dom0less system is not much how to tell which is the
backend domid, because that is known in advance and could be added to
device tree at boot somehow. The issue is how to ask the frontend to
"wait" and then how to tell the frontend to "proceed" after the backend
comes online.
--8323329-1581651934-1666038339=:2351079--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 21:10:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 21:10:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424605.672149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okXNM-0001MY-IJ; Mon, 17 Oct 2022 21:10:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424605.672149; Mon, 17 Oct 2022 21:10:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okXNM-0001MR-Df; Mon, 17 Oct 2022 21:10:20 +0000
Received: by outflank-mailman (input) for mailman id 424605;
 Mon, 17 Oct 2022 21:10:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vX9e=2S=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okXNK-0001ML-Vp
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 21:10:18 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 19ae7b92-4e60-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 23:10:17 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 86C9CB81681;
 Mon, 17 Oct 2022 21:10:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4458CC433C1;
 Mon, 17 Oct 2022 21:10:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19ae7b92-4e60-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666041015;
	bh=suD0QuASoqrCJuGlyIYi9GSAY3zAJmoaFv3ILy/1xxA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mDqLIHZJd27yJN1psmO7yTMhHt6BYiB7ud/SbtHDRShclACvQu2CO7PHSJTHY8fQu
	 QYBHO5zysPWKS+puaE2393OSSKt2jQtcbPPZP0btyoZiH1uKY1KaSGy2HsiW9W8JLt
	 Z4TWov6dofoSuf9HYA0EyvNuP4d87Xzs88KPZRzIPZaifXX2jqCazdfWVdktt/OEW4
	 xnGvg8L6geE5AYQZ3OkIsruCqL+I65qxKKFzLPL2lymXnydXrOkVsILFoE8AaE3oRn
	 CdHBjbR0/7kGHzZNKRoHEnzlzNNAD5k2iCsOovM1+b8iUZyTjlR7c8w3gEHCroheA1
	 9HoZ35yqTyJIQ==
Date: Mon, 17 Oct 2022 14:10:12 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Vipul Suneja <vsuneja63@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, 
    jgross@suse.com, boris.ostrovsky@oracle.com
Subject: Re: Porting Xen in raspberry pi4B
In-Reply-To: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop>
References: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-113100523-1666040577=:2351079"
Content-ID: <alpine.DEB.2.22.394.2210171403360.2351079@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-113100523-1666040577=:2351079
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210171403361.2351079@ubuntu-linux-20-04-desktop>

VNC is typically easier to setup, because SDL needs extra libraries at
build time and runtime. If QEMU is built without SDL support it won't
start when you ask for SDL.

VNC should work with both x11 and wayland in your domU. It doesn't work
at the x11 level, it exposes a special fbdev device in your domU that
should work with:
- a graphical console in Linux domU
- x11
- wayland (but I haven't tested this so I am not 100% sure about it)

When you say "it doesn't work", what do you mean? Do you get a black
window?

You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
(drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text
console up and running in your domU before attempting x11/wayland.

Cheers,

Stefano

On Mon, 17 Oct 2022, Vipul Suneja wrote:
> Hi,
> Thanks!
> 
> I have ported xen minimal image as DOM0 & custom wayland GUI based image as DOMU in raspberry pi4B. I am trying to make GUI display up
> for guest machine. I tried using sdl, included below line in guest.conf file
> vfb= [ 'sdl=1' ]
> 
> But it is throwing below error:
> 
> root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
> Parsing config from guest1.cfg
> libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection reset by peer
> libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connection to QEMU
> libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed, rc=-26
> libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not start: -26
> libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited
> libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain
> libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy guest
> libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed
> 
> Another way is VNC, i could install tigervnc in DOM0 but same i couldn't in guest machine because it doesn't support x11(supports wayland
> only). I am completely blocked here, Need your support to enable the display up.
> Any alternative of VNC which could work in both x11 & wayland supported images?
> 
> Any input on VNC, SDL or any other way to proceed on this? Looking forward to hearing from you.
> 
> Regards,
> Vipul Kumar
--8323329-113100523-1666040577=:2351079--


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 21:42:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 21:42:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424614.672165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okXsZ-0004wX-8I; Mon, 17 Oct 2022 21:42:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424614.672165; Mon, 17 Oct 2022 21:42:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okXsZ-0004wQ-5c; Mon, 17 Oct 2022 21:42:35 +0000
Received: by outflank-mailman (input) for mailman id 424614;
 Mon, 17 Oct 2022 21:42:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okXsX-0004wG-Rc; Mon, 17 Oct 2022 21:42:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okXsX-0000b0-PC; Mon, 17 Oct 2022 21:42:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okXsX-0003CD-Ek; Mon, 17 Oct 2022 21:42:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okXsX-0006jQ-EK; Mon, 17 Oct 2022 21:42:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=b6IthfnPvpBi1wpeJHqA9fqiWhQqxxaUoS95fYBp4KI=; b=Vv1ftBJAz9W8wxCkv81BUiQzYd
	PmzteJ6boE0uMVQSBCT9F82zxhXpqQAT2JdSkZwHMMpcoiqeB3V68Axx4lfSPEWKF50HZNR/MokY7
	E58Bj7cI389CCGE5x1syUz/8W3YQFeZ/l3qzyiRuNhk5LSp5+Uiom8ZOWBE/AZCA9wgw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174019-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174019: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 17 Oct 2022 21:42:33 +0000

flight 174019 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174019/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174001

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174001 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174001 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   40 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 21:51:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 21:51:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424623.672188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okY0w-0006i7-CT; Mon, 17 Oct 2022 21:51:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424623.672188; Mon, 17 Oct 2022 21:51:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okY0w-0006i0-8v; Mon, 17 Oct 2022 21:51:14 +0000
Received: by outflank-mailman (input) for mailman id 424623;
 Mon, 17 Oct 2022 21:51:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okY0u-0006S4-CJ
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 21:51:12 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cee7734d-4e65-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 23:51:10 +0200 (CEST)
Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 17 Oct 2022 17:50:47 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA1PR03MB6595.namprd03.prod.outlook.com (2603:10b6:806:1ca::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 17 Oct
 2022 21:50:44 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 21:50:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cee7734d-4e65-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666043470;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=R7edvmSZZq3qVoN3yhQXeokM7ol1GAXlsxTkm2pEaxM=;
  b=Lx/PsjG+KbtGvpYscnAWkahfiCD8NDG448QERZaN+mJDJgKzzEMo35Uq
   aJwR1xmpvz8Gm6Q5mywIu2pWC+Py8TBtH3ibd4vj+Mdo5Ccwygj2dlhz7
   p9Dz22ztsqaEdp5Yb9chHVgWPoVYIAmeBkwPhTx1vuWBizIoF/ZTlWDRd
   Y=;
X-IronPort-RemoteIP: 104.47.56.168
X-IronPort-MID: 82927419
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:179yz6x09kFfFckN8eB6t+fExyrEfRIJ4+MujC+fZmUNrF6WrkVUz
 TdNUWuCbqzZYDHwe9lyOYW//E1Tu5LcztYxHQA9/CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3bdIOGd36
 PwhNi1cdkDdrfK2yeKrY7w57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvTi7IA9ZidABNPL8fNCQSNoTtUGfv
 m/cpEzyAw0ANczZwj2Amp6prr+VzHmkBNtDfFG+3txA3EW0y3UaMhA5XEWSsdqniVajXfsKf
 iT4/QJr98De7neDTMT5XhC+iG6JuFgbQdU4O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvBJTFpqqzTdnub+Z+dtzb0Mi8QRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vXLHjX3z
 yGPvTIJrbwZhs4W1I225VnCxTmro/DhRAMv+h/eWG7j6wpjfZOkfKSh812d5vFFRLt1VXGEt
 XkA3sOZteYHCMjUkDTXGbtdWra0+/yCLTvQx0Z1GIUs/Cis/Hjlep1M5DZ5JwFiNcNslSLVX
 XI/cDh5vPd7VEZGp4cuC25tI6zGFZTdKOk=
IronPort-HdrOrdr: A9a23:VYtSy6HteNi6BY9mpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq
 iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO
 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46
 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ
 HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8
 o=
X-IronPort-AV: E=Sophos;i="5.95,192,1661832000"; 
   d="scan'208";a="82927419"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MCKJIi0GnrfLhTmVgP6N6UKXzmBNHtgONUv6ht9uESPnA/AugSVnuTVpa9dJVN6IUyLBsqBfq+Q8T1cT+BhtR1cFO1K6BSKd7G7Zdw6YdugeC1DF31VwDDUCOaTCZ/9EIwk14tnsZbMfqY4J0HcWx0tRmR8D35ZzOg9gsmjYJ/HFtv8K0nJFGBUMCdmcktt+Ih3V5JHbIl453ezzt/detA5ZW2WnmMwBo0aB9o7FunWTbzrKc0Gvwt2WRl5rZqaSsdn5jMNd2tMcORmxBTJv5e5BMPjzjBrl0li0oL47tnLhunllew06mQp3L0yt8Lz4hrD0dcHpinNrjpysWAjqmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R7edvmSZZq3qVoN3yhQXeokM7ol1GAXlsxTkm2pEaxM=;
 b=SO7WZOgXxXauLcyqxRzdfAUqHfi3vUGklEhgHh42kP53kCeeQmTxf9bzYoh6KN9JsmsSBV0S3haADJeFbHsr0ZJig2mRxDkMgAoxCnymNSHTv/SAgARCfZRv8l+k2m9AhCre250t9/CkyF8A6+zBir46q7Fitu5O47szVqJe6+O+qpRl03yFrhH1a7BxbYBqilNAw3OclDeSymiALD3QMceT+Ff9/b9zeebwg0wjbEJynJsfyJqLSzwWNZe6y+aX/EW4lpeifrd5KCLodVWiyY1AcwhhFyDHSI07+Q1XUeXldL5iy3EIUXsiuP7hTiH9kCw1A8aH0KyKccW/hcl7QQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R7edvmSZZq3qVoN3yhQXeokM7ol1GAXlsxTkm2pEaxM=;
 b=Yni05VXbANBsYIKOmDJRmY8pknFnV0jHFvkXYWH4ZJ+7r8yTUJJhCiCqZTdNNZ4MVXXY2liXtAu85/nO10LJ4lU5WqlA7aAEdX8GB2EQ+Lf3SWKtG1U5qlPlYh7GZ78mFbxl+rpbureVoeFNbr8GJWrQiZeVSwn0nWUreD7t2t8=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
CC: Henry Wang <Henry.Wang@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4lyBiWnfx+vnUkmAUdSmWjh5Xq4TC2qAgAAU4AA=
Date: Mon, 17 Oct 2022 21:50:44 +0000
Message-ID: <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
 <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
In-Reply-To: <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA1PR03MB6595:EE_
x-ms-office365-filtering-correlation-id: 240486ec-303e-40de-98bd-08dab089a48e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 QKYM2JbKV2EBwioCs4wuMPiHn8bJqgy+SvKHigyJChfPcSqOOA5lwanltybXA8A4jOnusIl0pUWF5vhlImOE0Awpkc7SRLT70R9T/jqx5T/z/dz8LOo2hV8WBGZdwd5B57EBDF+ptUhKPQtBFVE73LM7bxCMOxT6eN4xpmlzAO8RhQIVS/Op+MKv4O5/cS87dX5ITvcr6EEKjU/z2P7cma+HLed94AqCl961eFQswJL8ViHsIESxPpYjzDO2remumJjNkHkVeud7S/wmkFp+KcKRk7QIOhAPAeGrtVoU/TqfCDk4voia44Ln04F6ZsGBA1v9dw1PRSAgVNFYbXmjx2Fptyr20KujyzFTMi9wXdPlOv3FFgvSQ2RyoVlJtkJfbOWk5EExoU/6/ug+IVjbyMEDJJ4c24HxXF4mwgsK+gsFm3Ma2l93KGzDogyJpY/9ach7xM5mFRqNgdEsDTLbyuoRaH5uKRWbopJMS6WwwwhI0JrycgsFB4k7OAm0gnbT+lHk48kkRvgZbUCuW8boLyNkcC9GEAiP4252mgseM3VBeO7XVv5RTKZLsR94tV3EzSv8c3y7AogZIZhOpsx5JzbDm73raN1kAYKQsC8XfZKqBHaNm5yJ+kONRQ14Gfj9FaUWIvVcptvQYPPrM9JVWlGQqJ3pA58qn6NczOTG4axTinpo+pYEZtTfHMlAxF2ALNIAELljjVz8j5Q6n152KEcR+gpRGVPStd5Ak1JuMRT2xpIFRGGKuOlJCF6e+sQodAGNeiDKhjKTlmX6HdrZySDkQVy/PdR12vc4fO1b2JDQgZLK+j/kOkU73KhFZZoyP1oyD8a2TYI/mza7FTGR3g==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(66899015)(186003)(31686004)(2616005)(2906002)(6506007)(26005)(54906003)(5660300002)(316002)(53546011)(6512007)(86362001)(38100700002)(41300700001)(82960400001)(110136005)(64756008)(8676002)(91956017)(66446008)(66476007)(76116006)(66556008)(66946007)(83380400001)(122000001)(4326008)(8936002)(31696002)(38070700005)(478600001)(36756003)(6486002)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?NkxZMUhNRnl6Mnh3eU1DSUFNRTI2MGEyK0ZNbkdHV0I0ZlAzNHh6S05ST2lu?=
 =?utf-8?B?RUpocUE1MFZEaUIwYVNUZWY2U1huRmNyVmZneXpEbmtMYzBnRSt6dEQ0K0ZT?=
 =?utf-8?B?K2NXSHBRWnFxMndxZGQrV2RxajRZUzgyVVVHMlFNTit5MnZYWSsrS0NaN0Rx?=
 =?utf-8?B?dFRtOXRjY2EvVEplelpLeHVoYXNaWVpFQXNuaDY1b0JsbFVSeHo1TnUwU211?=
 =?utf-8?B?QmdQbUJLZlVVVzdIaVdPYlpyMEZqOXQ2WWg3MGUrM3VHK2NIanQ5eDRmcWpt?=
 =?utf-8?B?L3lFcXBMVW1GcWttQmFMbmJ2RlBDcG5paEVUaFVwYWR3MU1iSGRncWtNQ0Fs?=
 =?utf-8?B?dXc4REZwVGJGdHhxcmwzRWhqcWZTZVF6ZnYxdzV3MFZlWE5sY01Sb0RwMWg5?=
 =?utf-8?B?aXpLWjBYb2k0TEh4V1RKcG8xS2RPOXFwWnh5VXVMOW4rV05uYk1oSzB4b3Z2?=
 =?utf-8?B?N3pFZy81cFVIbGhpMVBFNVA0TjBreTdPWGkwazllRlBKVm9KMDdxT25VQWRn?=
 =?utf-8?B?OUc0clpHV1BwZ1dVd2tvazFWM3BzV2dVeldXdXhQS2l4UEpKNTNQb1dJdjcw?=
 =?utf-8?B?TkZBU3BYa291OUU3dGdVMW9EdWtxa1FmVk5Xb2ZXb3NYQzV0SE4wZFlwL2Uw?=
 =?utf-8?B?NEZRZUc0aVhLZkk1TzB5bEduZUx3d1BwYllrQWVtQkc0ZmN4RnU1RndWR3Fp?=
 =?utf-8?B?L0dTaHpXL01xaXJqbzZpL0ZLOGhKWUJOQUFQRHVZTDFrakpacWU1VGVDL0hp?=
 =?utf-8?B?RGtwRmgrK1VZeUtMRzlmMVJSWGtiSWlSWWxZT0diTTlsK20yZTFscGMvNTgv?=
 =?utf-8?B?VmcxNzRueGhCY0RuTnJmMjRFVVh1TnBKLzcrc0lMa3IrUU1zcmVXVit4YWhV?=
 =?utf-8?B?cEZ2OGI0MThzNTFwZGNLR3FZVW9YcjM2WGhiTXUyc1hsZ0JJSENPREdUUU44?=
 =?utf-8?B?eGVDUjhwSE5Ga0FrdGpQY1dlWXd3UFI1SjQvdkhwOHFwRXFHaWxYcllLWUVv?=
 =?utf-8?B?NElsYTd0K051WkhQWktPNFhSNkJIb2xYK3Blam5sRXl5RnNKdjFhUmptMlRR?=
 =?utf-8?B?UVd5bE0vdjk1ekJyVklHVEVHUitWVnJlZkVrYVFORXNRbklJcFMvWC8rQ0Ey?=
 =?utf-8?B?bVMyTFlpc3lhL1pUQ2czUWp3VWRGN1VPN0lYWTBpK0J3ZWFTaG5oajFFNWd6?=
 =?utf-8?B?RlRjZUg3SUVaTWVHOGl0eDlXU0NSMDlQM3BuNzFYK1J4MzUzMGtzcGxYWThY?=
 =?utf-8?B?NmFjNDFPOFRMREk2b0hoay9NWE5uL1dRTy9qT0R5T2FmeGNTbnVIdFY4Rklh?=
 =?utf-8?B?Z1R1b1prVnRpSmNmMzRBYTBIemxoaDZ5Z3lNMGhoMzRWanJTNXVGeE1jZk9t?=
 =?utf-8?B?NXE5R0lKNXMxTUVCN3Q3bDFxOHdxTDY0SzVYWWZOeXk3c2haL3JrUVc1aUlF?=
 =?utf-8?B?VUtRajhTMi9sRFIxVmIyNUdscFFXRjBIbStRaEpELzJqWUQvNC9NNDJZOUZo?=
 =?utf-8?B?c1RnZXIyb3lzeTZwN0tvZnZvMldRUC9uOThrNXA1MFNpNlJjd3R5YjRWOEVI?=
 =?utf-8?B?RHc1M2lBZUFOT085ekVTTGdEVlQwb1Q3Tm4xT2VXTGtNVmlFZVBQanJXTXFN?=
 =?utf-8?B?ekl1elJaOGtsN0psVDE1ZXkzQUt3NFBEdUJMeGgyREFnaVlDOFJBVFRTL21S?=
 =?utf-8?B?NlVaRVZRQWtQMWFYTFRhVWdSLzFZWkVZYXpET0dLQmdxUHBrVEJzUThQQ1M5?=
 =?utf-8?B?bklJZjlKaWRLTGpUcFU5cWo0U3VSdERnWjhBNUZKaW4yN2RCNjUwRWJ6YTJG?=
 =?utf-8?B?Tnoxc2NiRjk0M1pqaGd2aVRwbHVhTHZpUjY1bXN3S1BUQUpkQ2Y5WEpOQmhT?=
 =?utf-8?B?SUVtellGSTZ3V3R5MTh6b2hwZTJ4bGxNRmJpYisrNUlTV2lCTVcvejU4V3FZ?=
 =?utf-8?B?ajFlUzZ6S0FPVWN5a0QxWGlieGpUaXdSYWJZNko0NE9Od2QrRXd2dUhUZFND?=
 =?utf-8?B?VmNRT0N5dXZQQ0RRbHhLNGpzRWlMbUh6VVlucWpJTVE5UzQ0bFJ3RmRLY1JW?=
 =?utf-8?B?R0ZmVm04ZDBoZWZkLzZkYW84YkhnT3JLUS9hNkRxQTFqZ3pnTXZCSklCYzJ2?=
 =?utf-8?Q?7N1iQoD2yMrp4CDvFVEJ1tILb?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0BE2ABBAF372AB45BBD751FE5A076C5F@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 240486ec-303e-40de-98bd-08dab089a48e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 21:50:44.3694
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TrtYH91+RDf/5gG2luTg32AAaDa+38B0MtBFUu9i/8Lshf/spiNE7e80lLw8KqTR3wSTN1TN9Aeh7AU3k17SYF6lCo5CpNmn40418mXkuZs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6595

T24gMTcvMTAvMjAyMiAyMTozNiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBBbmRyZXcsDQo+
DQo+IE9uIDE3LzEwLzIwMjIgMjA6MTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBGcm9tOiBI
ZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+Pg0KPj4gVGhlIFhTQS00MDkgZml4ZXMg
ZGlzY292ZXJlZCB0aGF0IHRoZSBHSUN2MiBwYXRoIHRyaWVzIHRvIGNyZWF0ZSBQMk0NCj4+IG1h
cHBpbmdzDQo+PiBpbiB0aGUgZG9tYWluX2NyZWF0ZSgpIHBhdGguwqAgVGhpcyBmYWlscywgYXMg
dGhlIFAyTSBwb29sIGlzIGVtcHR5DQo+PiBiZWZvcmUgYQ0KPj4gWEVOX0RPTUNUTF9TSEFET1df
T1BfU0VUX0FMTE9DQVRJT04gaHlwZXJjYWxsLg0KPj4NCj4+IEFzIGEgc3RvcGdhcCwgYXV0b21h
dGljYWxseSBnaXZlIGRvbWFpbnMgMTYgcGFnZXMgb2YgUDJNIG1lbW9yeS7CoA0KPj4gVGhpcyBp
cw0KPj4gbGFyZ2UgZW5vdWdoIHRvIGFsbG93IHRoZSBHSUN2MiBjYXNlIHRvIHdvcmssIGJ1dCBz
bWFsbCBlbm91Z2ggdG8gbm90DQo+PiBpbnRyb2R1Y2UgYSBjb250aW51YXRpb24gd29ycnkuDQo+
Pg0KPj4gQSBjb25zZXF1ZW5jZSBpcyB0aGF0LCBmb3IgbGF0ZXIgZXJyb3IgcGF0aHMgZG9tYWlu
X2NyZWF0ZSgpLCB3ZSBlbmQNCj4+IHVwIGluDQo+PiBwMm1fZmluYWxfdGVhcmRvd24oKSB3aXRo
IGEgbm9uemVybyBQMk0gcG9vbC7CoCBTdWNoIGEgZG9tYWluIGhhcyBubw0KPj4gdkNQVXMsIGFu
ZA0KPj4gaGFzIG5ldmVyIGJlZW4gc2NoZWR1bGVkLCBzbyBmcmVlIHRoZSBtZW1vcnkgZGlyZWN0
bHkuDQo+Pg0KPj4gRml4ZXM6IGNiZWE1YTExNDljYSAoInhlbi9hcm06IEFsbG9jYXRlIGFuZCBm
cmVlIFAyTSBwYWdlcyBmcm9tIHRoZQ0KPj4gUDJNIHBvb2wiKQ0KPj4gU3VnZ2VzdGVkLWJ5OiBK
dWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPg0KPiBUaGlzIGlzIG5vdCByZWFsbHkg
aW4gdGhlIHNwaXJpdCBvZiBteSBvcmlnaW5hbCBzdWdnZXN0aW9uIGFueW1vcmUNCg0KT2ssIEkg
aGF2ZSBkcm9wcGVkIGl0Lg0KDQo+IC4uLiBJbiBmYWN0LCB5b3UgZHJvcCBhbGwgdGhlIGV4cGxh
bmF0aW9ucyByZWdhcmRpbmcgaG93IHRoZSBjb2RlIGlzDQo+IGZyYWdpbGUgKGUuZy4gd2UgYXJl
IHJlbHlpbmcgb24gZWFybHkgbWFwcGluZyB0byBub3QgdGFrZSBhbnkgZXh0cmENCj4gcmVmZXJl
bmNlKS4gTWF5YmUgeW91IGRvbid0IGNhcmUsIGJ1dCBJIGRvIGFzIEhlbnJ5IGFuZCBJIHNwZW50
IGFnZXMNCj4gdG8gZmlndXJlIG91dCBhbGwgdGhlIGNvcm5lciBjYXNlcy4NCg0KSSBwcmVzdW1l
IHlvdSdyZSByZWZlcnJpbmcgdG8gdGhlIHRvZG8/wqAgSWYgc28sIHRoYXQncyBhbiBzdGF0ZW1l
bnQsIG5vdA0KYW4gZXhwbGFuYXRpb24gb2Ygd2hhdCBpcyBzdWRkZW5seSBkaWZmZXJlbnQgYWJv
dXQgaXQuDQoNCldoYXQgaGFzIFhTQS00MDkgY2hhbmdlZCBpbiB0aGlzIHJlZ2FyZD/CoCBCZWNh
dXNlIGl0IGxvb2tzIGxpa2UgdGhlDQphbnN3ZXIgaXMgbm90aGluZyBhbmQgdGhlIEdJQ3YyIHBh
dGggd2FzIHNpbWlsYXJseSBmcmFnaWxlIGJlZm9yZWhhbmQuwqANCkluIHdoaWNoIGNhc2UsIHdo
eSBpdCBpcyBhcHByb3ByaWF0ZSBjb250ZW50IGZvciBhIHNlY3VyaXR5IHBhdGNoPw0KDQo+DQo+
PiBTaWduZWQtb2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+PiBTaWdu
ZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPj4g
LS0tDQo+PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0K
Pj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBDQzogVm9sb2R5bXlyIEJh
YmNodWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPj4gQ0M6IEJlcnRyYW5kIE1hcnF1
aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4+IENDOiBIZW5yeSBXYW5nIDxIZW5yeS5X
YW5nQGFybS5jb20+DQo+PiAtLS0NCj4+IMKgIHhlbi9hcmNoL2FybS9wMm0uYyB8IDQzICsrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0NCj4+IMKgIDEgZmlsZSBjaGFu
Z2VkLCA0MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQg
YS94ZW4vYXJjaC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0vcDJtLmMNCj4+IGluZGV4IDY4MjZm
NjMxNTA4MC4uNzZhMGUzMWM2YzhjIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3AybS5j
DQo+PiArKysgYi94ZW4vYXJjaC9hcm0vcDJtLmMNCj4+IEBAIC0xNzM2LDggKzE3MzYsMzYgQEAg
dm9pZCBwMm1fZmluYWxfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkNCj4+IMKgwqDCoMKgwqAg
aWYgKCAhcDJtLT5kb21haW4gKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybjsNCj4+IMKg
IC3CoMKgwqAgQVNTRVJUKHBhZ2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOw0KPj4gLcKgwqDC
oCBBU1NFUlQocGFnZV9saXN0X2VtcHR5KCZkLT5hcmNoLnBhZ2luZy5wMm1fZnJlZWxpc3QpKTsN
Cj4+ICvCoMKgwqAgLyoNCj4+ICvCoMKgwqDCoCAqIE9uIHRoZSBkb21haW5fY3JlYXRlKCkgZXJy
b3IgcGF0aCBvbmx5LCB3ZSBjYW4gZW5kIHVwIGhlcmUNCj4+IHdpdGggYQ0KPj4gK8KgwqDCoMKg
ICogbm9uLXplcm8gUDJNIHBvb2wuDQo+PiArwqDCoMKgwqAgKg0KPj4gK8KgwqDCoMKgICogQXQg
cHJlc2VudCwgdGhpcyBpcyBhIG1heGltdW0gb2YgMTYgcGFnZXMsIHNwcmVhZCBiZXR3ZWVuDQo+
PiBwMm0tPnBhZ2VzDQo+PiArwqDCoMKgwqAgKiBhbmQgdGhlIGZyZWUgbGlzdC7CoCBUaGUgZG9t
YWluIGhhcyBuZXZlciBiZWVuIHNjaGVkdWxlZCAoaXQNCj4+IGhhcyBubw0KPj4gK8KgwqDCoMKg
ICogdmNwdXMpLCBzbyB0aGVyZSBpcyBUTEIgbWFpbnRlbmFuY2UgdG8gcGVyZm9ybTsganVzdCBm
cmVlDQo+PiBldmVyeXRoaW5nLg0KPj4gK8KgwqDCoMKgICovDQo+PiArwqDCoMKgIGlmICggIXBh
Z2VfbGlzdF9lbXB0eSgmcDJtLT5wYWdlcykgfHwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgICFwYWdl
X2xpc3RfZW1wdHkoJmQtPmFyY2gucGFnaW5nLnAybV9mcmVlbGlzdCkgKQ0KPj4gK8KgwqDCoCB7
DQo+PiArwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBhZ2VfaW5mbyAqcGc7DQo+PiArDQo+PiArwqDC
oMKgwqDCoMKgwqAgLyoNCj4+ICvCoMKgwqDCoMKgwqDCoMKgICogVGhlcmUncyBubyBzZW5zaWJs
ZSAiaW4gdGhlIGRvbWFpbl9jcmVhdGUoKSBlcnJvciBwYXRoIg0KPj4gcHJlZGljYXRlLA0KPj4g
K8KgwqDCoMKgwqDCoMKgwqAgKiBzbyBzaW1wbHkgc2FuaXR5IGNoZWNrIHRoYXQgd2UgZG9uJ3Qg
aGF2ZSB1bmV4cGVjdGVkIHdvcmsNCj4+IHRvIGRvLg0KPj4gK8KgwqDCoMKgwqDCoMKgwqAgKi8N
Cj4+ICvCoMKgwqDCoMKgwqDCoCBBU1NFUlQoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2Vz
IDw9IDE2KTsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoCBzcGluX2xvY2soJmQtPmFyY2gucGFn
aW5nLmxvY2spOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgIHdoaWxlICggKHBnID0gcGFnZV9s
aXN0X3JlbW92ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIHdoaWxlICggKHBn
ID0NCj4+IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0
KSkgKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOw0K
Pj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgIGQtPmFyY2gucGFnaW5nLnAybV90b3RhbF9wYWdlcyA9
IDA7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAgc3Bpbl91bmxvY2soJmQtPmFyY2gucGFnaW5n
LmxvY2spOw0KPj4gK8KgwqDCoCB9DQo+DQo+IC4uLiB5b3UgYXJlIGhhcmRjb2RpbmcgYm90aCBw
Mm1fdGVhcmRvd24oKSBhbmQgcDJtX3NldF9hbGxvY2F0aW9uKCkuDQo+IElNTyB0aGlzIGlzIG5v
dCBhbiBpbXByb3ZlbWVudCBhdCBhbGwuIEl0IGlzIGp1c3QgbWFraW5nIHRoZSBjb2RlIG1vcmUN
Cj4gY29tcGxleCB0aGFuIG5lY2Vzc2FyeSBhbmQgbGFjayBhbGwgdGhlIGV4cGxhbmF0aW9uIG9u
IHRoZSBhc3N1bXB0aW9ucy4NCj4NCj4gU28gd2hpbGUgSSBhbSBmaW5lIHdpdGggeW91ciBwYXRj
aCAjMSAoYWxyZWFkeSByZXZpZXdlZCBpdCksIHRoZXJlIGlzDQo+IGEgYmV0dGVyIHBhdGNoIGZy
b20gSGVucnkgb24gdGhlIE1MLiBTbyB3ZSBzaG91bGQgdGFrZSBoaXMgKHJlYmFzZWQpDQo+IGlu
c3RlYWQgb2YgeW91cnMuDQoNCklmIGJ5IGJldHRlciwgeW91IG1lYW4gc29tZXRoaW5nIHRoYXQg
c3RpbGwgaGFzIGVycm9ycywgdGhlbiBzdXJlLg0KDQpUaGVyZSdzIGEgcmVhbGx5IGdvb2QgcmVh
c29uIHdoeSB5b3UgY2Fubm90IHNhZmVseSByZXB1cnBvc2UNCnAybV90ZWFyZG93bigpLsKgIEl0
J3Mgd3JpdHRlbiBleHBlY3RpbmcgYSBmdWxseSBjb25zdHJ1Y3RlZCBkb21haW4gLQ0Kd2hpY2gg
aXMgZmluZSBiZWNhdXNlIHRoYXQncyBob3cgaXQgaXMgdXNlZC7CoCBJdCBkb2Vzbid0IGNvcGUg
c2FmZWx5DQp3aXRoIGFuIHBhcnRpYWxseSBjb25zdHJ1Y3RlZCBkb21haW4uDQoNCg0KWWVzLCB0
aGlzIGNvZGUgaXMgYSBiaXQgbmFzdHksIGJ1dCBpdCdzIGxlc3MgYnVnZ3kgdGhhbiBhbGwgYXR0
ZW1wdHMNCnByZXNlbnRlZCB0aHVzIGZhciwgc3BlY2lmaWNhbGx5IGJlY2F1c2UgaXQgYXZvaWRz
IGluYXBwcm9wcmlhdGUNCnJlcHVycG9zaW5nIG9mIGluZnJhc3RydWN0dXJlLg0KDQpBdCB0aGlz
IHBvaW50LCB3ZSdyZSBhIHdlZWsgYWZ0ZXIgdGhlIHB1Ymxpc2hpbmcgb2YgWFNBLTQwOSBhbmQg
Q0kgaXMNCnN0aWxsIHJlZCBhY3Jvc3MgdGhlIGJvYXJkLsKgIFRoZXJlIHdlcmUgbXVsdGlwbGUg
ZmFpbGluZ3Mgd2hpY2ggaGF2ZQ0KbGVhZCB0byB0aGlzIHNpdHVhdGlvbiwgdGhhdCB0aGUgc2Vj
dXJpdHkgdGVhbSBuZWVkIHRvIGRlYWwgd2l0aCwgYnV0DQpyaWdodCBub3csIHdlIG5lZWQgYSBj
b3JyZWN0IGZpeCBhbmQgd2UgbmVlZCBpdCB5ZXN0ZXJkYXkuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 21:51:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 21:51:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424622.672177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okY0v-0006SM-4D; Mon, 17 Oct 2022 21:51:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424622.672177; Mon, 17 Oct 2022 21:51:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okY0v-0006SF-12; Mon, 17 Oct 2022 21:51:13 +0000
Received: by outflank-mailman (input) for mailman id 424622;
 Mon, 17 Oct 2022 21:51:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A/1i=2S=citrix.com=prvs=2822150b0=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1okY0t-0006S4-Kj
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 21:51:11 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cdf27a50-4e65-11ed-91b4-6bf2151ebd3b;
 Mon, 17 Oct 2022 23:51:09 +0200 (CEST)
Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 17 Oct 2022 17:51:05 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA1PR03MB6595.namprd03.prod.outlook.com (2603:10b6:806:1ca::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 17 Oct
 2022 21:51:02 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022
 21:51:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdf27a50-4e65-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666043469;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=x1uUXB+R4E6QSAhWQhgc0QXbuS4zW7vt6yZNjAdIajE=;
  b=U3qBSG2sRVb1Gimu5WxcDrez9Tc15ClmFNtG4G3/hb75OooH8oddziyc
   ZDm5F9kfv8IgrJK2KdxXA5Gz2N8H5q5K09xKtiodw04yFWoajnruSjQwo
   JZQo9wzIdqWMi/f+A1pxYgW8cFvQ1qIdE/InC5QdfG2MYMU/qKTi63P9T
   o=;
X-IronPort-RemoteIP: 104.47.55.171
X-IronPort-MID: 82950221
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3A3kihwK3A6+R5Q2rEvvbDix16xTcKaHBdZcB5N?=
 =?us-ascii?q?8R9jSZ0Z1x39YIjduZ9IuK7yVSIAfTWEZbPRGaj6wykQKmNBg2MwTOCMcepk?=
 =?us-ascii?q?wWycd/QEFLIgeHNFh+tFFzVAPBZT3GfoNwE+iY4f6stY8VLzgljYwybnvAVi?=
 =?us-ascii?q?EzAwRR1FsScuf5qQznk4lzJOl7OJCDKut+YywykFzlSnwf+1e1WFfrn7pvey?=
 =?us-ascii?q?9GYFP1+ZxWF4paMhbxFEjHwmRQABQVtnBkHj2/jtzDK0WQXm+wJixsFiyhXE?=
 =?us-ascii?q?5E01CsTyEU6jwFgLm8RcUdUIL1+UKqwzzFCZ8xzKn6BoEw2TKH6q5VrfjEyw?=
 =?us-ascii?q?FmVTZq0szBN9WI3YW/qha1HkOTBcj9FA7z38LnEQ22e5So5dgla2NguvtCdf?=
 =?us-ascii?q?myrZwMLbEp8s/6EO4Ze1eHzPWuD0LJTA2jij1hv3a9fMjvo7k2lYDx4FvHYL?=
 =?us-ascii?q?gdtiGnCCJHHgDnGQHMybwOGFiJ+kORZPudivZcCv0BpxWIUnGq8UwqaubjX3?=
 =?us-ascii?q?ut2JISBTvZ13iB7rqDP8KcbtmivUweDXa/X5RHEGhV84Vj9CfqaNJ7KuPRaN?=
 =?us-ascii?q?1/1IpyhSoLq4RHmv0AaImPl1cuS4alUWnGZDDm4uB9IvKmf8VHEt4VKP1wi8?=
 =?us-ascii?q?z/B8deZrUeZ4s4Q8NkSHJL7GmEMQeFn7DB8opg0oZQFh1OHjBk+hhB7VLhri?=
 =?us-ascii?q?IgDdLQvcWLeh0dlBFl/tTP+G0ejZi8BSIW7lBiQ5iUQ2jbDkEbMp2eiG41J6?=
 =?us-ascii?q?9P0hNVhzRbPIpFK6hiGcuJRDazvjv3tfKWmbtAcQKOutKXHXGKkPN+U4gID6?=
 =?us-ascii?q?iQ23PrEM6bGB+uwP+JHePS+YFDRJjdSV5a7/lFezRFhTa2+pXVVzvTVp4Iwz?=
 =?us-ascii?q?XBaoUYkOqrSkJbQ19jjJo2LGOUc3nOy5/p/62gOd9YOrBXVaPjIJ2U/kIi5o?=
 =?us-ascii?q?wzjSUdvOacme9UmeO8WuniTWkgWCq+xOvfFynET2H/SMfr7Z5UQ2IQr6EE3i?=
 =?us-ascii?q?uIXvKvySbMv1FcOBQg2Ib/hdqxfnIbZ+Y10ZCyuIOEh+FlSz+jBybZu/RjKe?=
 =?us-ascii?q?aaZsOjJNBKYNLMtxln6lZ38DCNIGuX1ntewgBn1/IsHTTsx4iAbuTJmtRsKd?=
 =?us-ascii?q?UhnPFcNFAnnGX4acTUMm9/zUvdFLs382vi3idz6eD322TPP3/n2LknWy4V8f?=
 =?us-ascii?q?EgVC6HuZsCTVCl+y2TBi43ovmg9xOSskBgL5usF7NPFAEtHXWQNL9WkOH/d+?=
 =?us-ascii?q?jACpNNyH0u3npGtd0A/Gvh1lhaA4Fy5yj4WT9QD64oIg4scTW78zekdRqADU?=
 =?us-ascii?q?2QSiWBZnvxSDFN8WhAKneQF8ladv64ue6Xa2uDdOknLgXBOTZdjKq/kkSlNE?=
 =?us-ascii?q?iFbs4rs9kiHGZf9/B8EhxGpuuN1qYB818jmIoIDCDIpiuzO4EGxypJ6ZGnJj?=
 =?us-ascii?q?K9WbSElH0O1hh8XQjn8WJDMlGbmimH3kTb96yY7iBSgyDx8zP8mnsH9EKimP?=
 =?us-ascii?q?S4lJo0KhV3U3zuUKAEzubtozubbH6f3gu6WD72JLwue+/oEmvJ6Ei6EiDLVo?=
 =?us-ascii?q?tuo3f5fL4kPiFVMj6FR9f/ZOmK4FYo2tRDn0llzFTNMomg+jQbJZ8xbZVk4R?=
 =?us-ascii?q?E6+QAHkYwXzpJwhsMH+wihFL7xf4WQTBMPUuwKcic8A5P0vP7fpZaOl6RGia?=
 =?us-ascii?q?A/0Z5nSjkHBLYhxrYj8KAKKG2QozGibSnTSzLotwjOu+AmR/HSNHKH9Vd70U?=
 =?us-ascii?q?UFvOBJFByeny3E2QJESlU6KC2cGls/KgExIO46wAeRKOEq+I09si/zlh1+Y9?=
 =?us-ascii?q?hfR94B5eBhyvvklYVnYQ0M1Qzb9UE6bW//uL+YV29iYK0bOyAAyZ1ZQrcF5y?=
 =?us-ascii?q?VaPT5kOjr8akR5WzzwAWsb3jTlS2zq/2FpqtqrLVCJlboZBhvfX6GRWFyREl?=
 =?us-ascii?q?9xVxaRUPqTbnq88A1d2MUjtewCUHm1XfkiwyftSA7dRusSHcDalRBvev+/EV?=
 =?us-ascii?q?hqs8yWMMybjzJq6P9X6aXpH/L/5G+Zc0qX2qNM/ilyF9F/WVYeH0tujB7lFO?=
 =?us-ascii?q?SDrxfYuvc676/pkvjTJ4BIpMALlBqUBVGrwVes88iOiKJwNHbWnaNiUvWRBu?=
 =?us-ascii?q?OxQUCF8TO0SA9s02bI+i7z0ClctX/A0G+3XyKcRwpdPYbvgsnh8rpK9g4mBI?=
 =?us-ascii?q?WLlRZkZiZuBj6a1pG5JNWdurvmmt/6f97EEwORwwbplYtDVShWRjJzSEaiC9?=
 =?us-ascii?q?uYbr8jWRgFI67eV9JLHhxo/7LJFrOrJTORajP47tNEZtS/g/Tf0tiv5hTt3M?=
 =?us-ascii?q?QNVvBn062tLPTTteXXAZps2ikZJB0soTHE0mLfnNfmrpJBUszK1kua2jHR2Z?=
 =?us-ascii?q?R5xiu6JRfJomIq7cF6EBCJti+Uln6N0gWiThF4860Fi8F91wMJY3KDiI/Lup?=
 =?us-ascii?q?T+2/P0mjaXl9EQWYjKgIfQRbdc4H0GDjUHyn2rRvFtfO/uxGQ5K0gF2sM5CA?=
 =?us-ascii?q?jmS2rQiMX2hvfGgBAImTh79zxGaI9NE61C3iEEHmZ7Sf0rFJZKFTchnendN9?=
 =?us-ascii?q?S8k968ep4kwKQZ/E+j0nQr16zVYU5Bi6ioP4hQ9PQZlYusx3XCLyBjadp5gV?=
 =?us-ascii?q?f7qUYF/81X+D2/+eJrM+Vz4dwCebIxDYDmWV6bV+sX5bhqzhVB6o7uAD4XKu?=
 =?us-ascii?q?alauUKODojzoKsvF289Qhpvvj6ZL36ttgA1hwj+?=
X-IronPort-AV: E=Sophos;i="5.95,192,1661832000"; 
   d="scan'208";a="82950221"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oMZGmTix9IHvnC2Lt8sMkaCub1sy3cCKA3Kg8sLWR0EBLKGgOPK10tynYKVf9GXLX3YdMgKtzvOAW/ljPwWXngkHXk7oOH33grUDPb7zWczMIrliPZjnH+UOXP5Njwk2pjFJZipyQ7xz7bG7cQ3Ngkou98LY/tsRWzy63RcnYzfgQ+U8NUz3HbpKpSFJ3etuMKMxI+PvM/vObo9Jjo9X9fR/2Hcm6yjYvpe5DjR38tfvExX05ba0XzMytBsl8yKoteTgDlDPOunPVbZrfbJOfXVhGYb08d7kU5GYGVA40F5aKa203Y1M8ENVg7Sju7TfdKMWR/l72CGuhr9MXiZtyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x1uUXB+R4E6QSAhWQhgc0QXbuS4zW7vt6yZNjAdIajE=;
 b=PFu8rWabdN8Oqli5rBf8nisclhV2XGff4ZYv9ZVbS4lOzrdbxwcuuo5jrpz6fEaB+t7QeXZibBsv8l+AVbafK2NrwJSXdLSDL6CkxTy0+j086C19DAK7PaB/6z5HZC1WnnLrk2nxVKgB3KxI7qaFu3zE6hOmPAHAQD5LU/ZjC/7GyDi1TechEtufV7hEi+WyLmgCwI2etrsEtKeyGVty7scEN7PDNbYgDJuwLgzPlkwSouxPT5CgNo+E7WPU3+utp5jLln5EMN8TPbV8PJL6iZ7HZPV24UkGKuSiRceu1rYzYRLpFYHLR7Qj0yAvQJ9r/GdVQTTsNvZYaiXrV17GuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x1uUXB+R4E6QSAhWQhgc0QXbuS4zW7vt6yZNjAdIajE=;
 b=hRKU/5LlODQUXQYr4kJfZ3/df14LW/C6yxX8a1G7plD0kuOlYfBwg6f1opAN2VQAJzTR2OrPDfbC+JtTTGTEqQygYdRo8C3XrvJ4DSn/aDYZLFqnjnmqRF0JQtfal/ahIcEz6aDB+sOMket3nY61bkhL9qrODwVXWnyWGIuMWuE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH 1/2] arm/p2m: Rework p2m_init()
Thread-Topic: [PATCH 1/2] arm/p2m: Rework p2m_init()
Thread-Index: AQHY4lx4FOMRDEiHEUC2Eqcrjw6xi64TCE8AgAAYEQA=
Date: Mon, 17 Oct 2022 21:51:02 +0000
Message-ID: <87f07673-4a3f-5971-1cc7-3bde637f34e8@citrix.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-2-andrew.cooper3@citrix.com>
 <3cd9f882-090a-b4ba-df87-663a9a375737@xen.org>
In-Reply-To: <3cd9f882-090a-b4ba-df87-663a9a375737@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA1PR03MB6595:EE_
x-ms-office365-filtering-correlation-id: e6b43c10-2b23-4eda-72ba-08dab089af3f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 U+0P2tkp6jzYQ3nTY6JxyQIO2yeG/MpZ6SNXg52EgTWhkgd4Mpu5QJHl4oONWgS0BCSfiV46IDWhb6qYJn8cuJX9oysVmG6v6c0o+t+1MYqmAjSf/3oxWfiSWrikPRjcabLYhu0W74rxmN7vofpFMcr/wTXhKBHKHh+gmBeuh1Hg66DR7e6WuuuajwTKTlH3YpaQl8d/3dCVhYU6NT3ekJR/lLhIskzFE9XxTd+I9HZZXU4j0rBC/9PptLW2eF2c1X3vRKNT6XQZ3BY/YGdADv5PLSUGCMixYcKG0iNTBBTvssichU6auLX0TpEdTD46ehhOf436y1/J1NWSlB0Yn+ArmKKISi5i8pYwRNGFbOzHZB2lxc7R4K4qunjOmM6EPxrNnmAYo0P6df+nUzvysYUWHIxUubMuC+usbDTIPJRs5nXRmP13iSxvlpzddHl1hkQFvZeRMEnnS1EWGPYcH4MzPUUTY8xuKhhSAZjdQj2eLOe1Q2lfbCAeTA5crUd1FIEB0Gm5OQhVI4KfKR+EL2uuzbjg0y9xH+od2LifBGnUDIkKhoWu7YDJCXMty2wiKdaZHOH6PwjjwvlwAvqNItsNTfNGsWZj6XbaorUOBpFSNGUgtBTkGDMyEoD5REPOCpSbNKbzW4YgmHF9N3WQHoqJJQR3aghKjtHy19AxirHfQ5cdY/b9umNC6NwnMxa3QoTS8r7i0kUvxAnVcpMFA959l2LBqAyFQSp18T6cIPVI8iu792o6s50ubbWEP1hPAKXsaR1jAFGK0DjwfxpFPbRLxIQDt13J/cBXWy9S3ICPv2wCaPshiCVwZEECm1OSWQsnIFMizNb3GmxZ4yDcWg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(186003)(31686004)(2616005)(2906002)(6506007)(26005)(54906003)(5660300002)(316002)(53546011)(6512007)(86362001)(38100700002)(41300700001)(82960400001)(110136005)(64756008)(8676002)(91956017)(66446008)(66476007)(4744005)(76116006)(66556008)(66946007)(122000001)(4326008)(8936002)(31696002)(38070700005)(478600001)(36756003)(6486002)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dTRySEFQRVd2UUs1b29sNHh4OGlpRm1CdEcwaHFjVVpFZWRScERWN1FuYmNY?=
 =?utf-8?B?RGxPV3RkOXhyWngvQUVpM0htcHpTMUoyUFk5ditueDUyNmUzUE9iem1WbDhY?=
 =?utf-8?B?R2dqakxNR0dUTUpOWml1NEpET3Q3RzJIYWRFdFAwMWxMUzR3MkFoaXh5LzNK?=
 =?utf-8?B?QjBOOTgvSlZGeTQydGlnN3BGR3FBMXp0cW5SaDhITktIVFc3WDhyUWlkWmFU?=
 =?utf-8?B?SGR6S3JPWTZ1NXN2bk5xSkpCVE1TalBOK1dWYWxWOHZIUUxpYU5LSGtNSWdm?=
 =?utf-8?B?QkNuako2Y2Z3bEkwWkplQVR4S3doWUZyQkxQdHRnN21yMG9Kdis0c1pFcGpL?=
 =?utf-8?B?Z1hDNS9PQmdkanI3TDI2YVBLSDlLdTV3RHJjUEVjcU5sNVV6Y0tBdzN3QW9M?=
 =?utf-8?B?OTcrZG9iYXZXdDcwOURHdjgrR1h0VXNTVThpVEEreFhSa01lWUg2aGhqdUhw?=
 =?utf-8?B?ek1QQ2ZIeURXdy8zcHpoQngrZCtORVQ2L1RxSHpIdm9rcTZQR2FQVDlWeEFM?=
 =?utf-8?B?OWJvdUEzVW44ZENVZHFHWHdYclBqVE55dHBFeXZWcExuaDI0NFdrV3BCYVRP?=
 =?utf-8?B?RHZnZnVJWCtmbllUNGtFb2FpUWRWLy9jUEpYTTg0Y1NraU1IajdudkxaWUMx?=
 =?utf-8?B?cEgySDFiZGxSNkhIMThLOWYxZFg3anNmTjl3TXRobk1Yb05mMm1qcjRYekkw?=
 =?utf-8?B?UFRLV3J4SjZyWWxRcWdRc2JNalJZelo5encySE4zaFQ1TDBoT1lrZEx4RDM1?=
 =?utf-8?B?ZDhvRUdKSy9ZRnBkaHFVRjZGNEVBQUNJbVhjczg0aTNKTnExVHdvUi9IUURy?=
 =?utf-8?B?OWM4WnN4L29HTEJWUU9ZYjRJUEFlTkxqdGNSdWhPVlZaRUJiOENoM0NOdytk?=
 =?utf-8?B?dWYzK3B5Qk9tWEc5WFhRVXc1ckRIOG14UzNCUHo4aHA2WFppZXJKUEdaSEY3?=
 =?utf-8?B?anZqZTV1Z0V5UzhkOGV2T2lHK1Byem5TSWNLWnkzTzVTTHg0aDhtZGFVYy9v?=
 =?utf-8?B?Nk1OWGVoN2tUL3I4WHZNVE5lbTl3b1JZdDdhVldpMXV6VGkweUtLa1B4S2pO?=
 =?utf-8?B?bnFRTzQ4Mng2dEhMeHBudWsrZ01Qb3F2TUMzSWVUQmloeVFnK1RWNGF2ek1o?=
 =?utf-8?B?eUtiMW1YeTBiRnNoREJnWlNOQVZJa3dQdThOVU1GU0pCSEs2WnIxU0FRN0pZ?=
 =?utf-8?B?VDM3aE01MU9xcUJlM1J5TjFKUzVFS0VFUWFVTkVmdWx5L3VJc2VXa2VLQ0dU?=
 =?utf-8?B?cVdBL2xEemt5MnFTMUVvd0x5djU1V2pPUFZJTTVKUHRKalVxOVZMVFNBa2xp?=
 =?utf-8?B?QzFXOWZXQUZRTTlOME10L0VTYW1Zdmk1eTkwVGVEWUNkZ1hmSnhOYkJOeTJy?=
 =?utf-8?B?RXA2S2NXMUpZTVpBZWFqNG1RNHJHY1RsSDJheFp6ZjVXR0hINzJVSFpkTmI5?=
 =?utf-8?B?ZVhka2NpcnkxNzJVSVZ1QXkwc2dMamR2OFgwTVRaV09KZU5FMlVEa2F1dWVi?=
 =?utf-8?B?alVTU3BjdXllZXFjT1hOWFRSa3VqK2IyZk5ZVEFONFdoQ1hEQnIxZWZnYmNn?=
 =?utf-8?B?TERLOGhUYnpNR2lBVXNiZzAyR2NtOENDd3hRNUNCL3psSmFxSmltYXk1WEE4?=
 =?utf-8?B?WnZNUGRxblBvaS9NeDFaVVAzeUk5bDVPaFJpeEVjbmpDZDYrRzhXNVJ1YzlH?=
 =?utf-8?B?bXhjb1dRRjEwWW13Y3Z1eEVCZjhPRGpQazZzeUN1NGplNzJYVEdLSmZDSldJ?=
 =?utf-8?B?WjB6V0RQRUJ2QTZ0bDVSYkxkZUFPeEZNb0RJcE5aZkpzT0hNMEhmYzBHaVRO?=
 =?utf-8?B?d1RNVXNSZEE4VzFsdEptMVNQajZ3VTRwQVFXbktHY1FSZWEzWGRoWjJFTmYw?=
 =?utf-8?B?UEdpWmdaOEkyUUtSWDFPK2lLSWpBWVcreGZCcjZTd3RDeGdMTW1vWU9OM3Zv?=
 =?utf-8?B?TVBiNWRMZWZBdXpmMzE0U1UxNndxY3k1RFlEVHFQbmx4TW14di9wZnpEbjhk?=
 =?utf-8?B?MUkvL0NWYitkaGczYW1uL25haFhWOEpDMzRNUlZXeGZZdndRK2xSK1JRN2Ru?=
 =?utf-8?B?Tm9KLzBobWx0VTF0MjF3RmdVZnJPK0F5V25BQmRsOFE1N1ROWHcvSFY2aG1m?=
 =?utf-8?Q?LO0emmwgpMJ2zj1lOfE5LpiTL?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <48E71F54266F29409ADCF0316588DB64@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6b43c10-2b23-4eda-72ba-08dab089af3f
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 21:51:02.3056
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WnHOTbBqF/J+QhFimeVRfYw+TjEIeNt9Ij3AmMcfrgrFCBKzWTBC6wirLF4BFCOupkHwAWHVVZHWd6cOeTb90U1t0WWUWsH4NnMUOTQMwYc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6595

T24gMTcvMTAvMjAyMiAyMToyNCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBBbmRyZXcsDQo+
DQo+IE9uIDE3LzEwLzIwMjIgMjA6MTIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBwMm1faW5p
dCgpIGlzIG1vc3RseSB0cml2aWFsIGluaXRpYWxpc2F0aW9uLCBidXQgaGFzIHR3byBmYWlsYWJs
ZQ0KPj4gb3BlcmF0aW9ucw0KPj4gd2hpY2ggYXJlIG9uIGVpdGhlciBzaWRlIG9mIHRoZSBiYWNr
cG9pbnRlciB0cmlnZ2VyIGZvciB0ZWFyZG93biB0byB0YWtlDQo+PiBhY3Rpb25zLg0KPj4NCj4+
IHAybV9mcmVlX3ZtaWQoKSBpcyBpZGVtcG90ZW50IHdpdGggYSBmYWlsZWQgcDJtX2FsbG9jX3Zt
aWQoKSwgc28NCj4+IHJlYXJyYW5nZQ0KPj4gcDJtX2luaXQoKSB0byBwZXJmb3JtIGFsbCB0cml2
aWFsIHNldHVwLCB0aGVuIHNldCB0aGUgYmFja3BvaW50ZXIsIHRoZW4NCj4+IHBlcmZvcm0gYWxs
IGZhaWxhYmxlIHNldHVwLg0KPj4NCj4+IFRoaXMgd2lsbCBzaW1wbGlmeSBhIGZ1dHVyZSBidWdm
aXggd2hpY2ggbmVlZHMgdG8gYWRkIGEgdGhpcmQgZmFpbGFiaWxlDQo+DQo+IFR5cG86wqAgcy9m
YWlsYWJpbGUvZmFsbGlibGU/DQoNClllcywgZml4ZWQuDQoNCj4NCj4+IG9wZXJhdGlvbi4NCj4+
DQo+PiBObyBwcmFjdGljYWwgY2hhbmdlLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD
b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+DQo+IFJldmlld2VkLWJ5OiBKdWxp
ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KDQpUaGFua3MuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 23:01:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 23:01:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424641.672214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okZ71-00068h-O6; Mon, 17 Oct 2022 23:01:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424641.672214; Mon, 17 Oct 2022 23:01:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okZ71-00068a-Ji; Mon, 17 Oct 2022 23:01:35 +0000
Received: by outflank-mailman (input) for mailman id 424641;
 Mon, 17 Oct 2022 23:01:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okZ70-00068U-TC
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 23:01:34 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okZ70-00022t-Du; Mon, 17 Oct 2022 23:01:34 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okZ70-00057b-7c; Mon, 17 Oct 2022 23:01:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=t8/Cw47LJ6fZbiYZI37iKW/Zbp9Be+z15qnNcXSA3Ng=; b=tfV5vDuD7McGWCAC/PTOQ/84qw
	VRUL7jJrtZ8CMDakyxpl0rMPePOf5F6BuxmKUpBzjRVGGW/QBChyXORVNf66PvI17o7/N1agMvU2x
	VByxKxs7qBmehoQql4zAAgEi942lQsFh72umdPrmcdUwRxty1In2jZY/QlEo4MrEEiUU=;
Message-ID: <5587f5bd-1694-a843-9e80-ad477527a576@xen.org>
Date: Tue, 18 Oct 2022 00:01:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
 <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
 <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
In-Reply-To: <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 17/10/2022 22:50, Andrew Cooper wrote:
> On 17/10/2022 21:36, Julien Grall wrote:
>> Hi Andrew,
>>
>> On 17/10/2022 20:12, Andrew Cooper wrote:
>>> From: Henry Wang <Henry.Wang@arm.com>
>>>
>>> The XSA-409 fixes discovered that the GICv2 path tries to create P2M
>>> mappings
>>> in the domain_create() path.  This fails, as the P2M pool is empty
>>> before a
>>> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION hypercall.
>>>
>>> As a stopgap, automatically give domains 16 pages of P2M memory.
>>> This is
>>> large enough to allow the GICv2 case to work, but small enough to not
>>> introduce a continuation worry.
>>>
>>> A consequence is that, for later error paths domain_create(), we end
>>> up in
>>> p2m_final_teardown() with a nonzero P2M pool.  Such a domain has no
>>> vCPUs, and
>>> has never been scheduled, so free the memory directly.
>>>
>>> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the
>>> P2M pool")
>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>
>> This is not really in the spirit of my original suggestion anymore
> 
> Ok, I have dropped it.
> 
>> ... In fact, you drop all the explanations regarding how the code is
>> fragile (e.g. we are relying on early mapping to not take any extra
>> reference). Maybe you don't care, but I do as Henry and I spent ages
>> to figure out all the corner cases.
> 
> I presume you're referring to the todo?  If so, that's an statement, not
> an explanation of what is suddenly different about it.
> 
> What has XSA-409 changed in this regard?  Because it looks like the
> answer is nothing and the GICv2 path was similarly fragile beforehand.
> In which case, why it is appropriate content for a security patch?

This is explaining why the current logic (and the one you add) is still 
OK. It is not entirely related to XSA-409, but relevant to the fix 
itself (and why the issue is now "properly" closed).

> 
>>
>>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Stefano Stabellini <sstabellini@kernel.org>
>>> CC: Julien Grall <julien@xen.org>
>>> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
>>> CC: Bertrand Marquis <bertrand.marquis@arm.com>
>>> CC: Henry Wang <Henry.Wang@arm.com>
>>> ---
>>>    xen/arch/arm/p2m.c | 43 +++++++++++++++++++++++++++++++++++++++++--
>>>    1 file changed, 41 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>>> index 6826f6315080..76a0e31c6c8c 100644
>>> --- a/xen/arch/arm/p2m.c
>>> +++ b/xen/arch/arm/p2m.c
>>> @@ -1736,8 +1736,36 @@ void p2m_final_teardown(struct domain *d)
>>>        if ( !p2m->domain )
>>>            return;
>>>    -    ASSERT(page_list_empty(&p2m->pages));
>>> -    ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
>>> +    /*
>>> +     * On the domain_create() error path only, we can end up here
>>> with a
>>> +     * non-zero P2M pool.
>>> +     *
>>> +     * At present, this is a maximum of 16 pages, spread between
>>> p2m->pages
>>> +     * and the free list.  The domain has never been scheduled (it
>>> has no
>>> +     * vcpus), so there is TLB maintenance to perform; just free
>>> everything.
>>> +     */
>>> +    if ( !page_list_empty(&p2m->pages) ||
>>> +         !page_list_empty(&d->arch.paging.p2m_freelist) )
>>> +    {
>>> +        struct page_info *pg;
>>> +
>>> +        /*
>>> +         * There's no sensible "in the domain_create() error path"
>>> predicate,
>>> +         * so simply sanity check that we don't have unexpected work
>>> to do.
>>> +         */
>>> +        ASSERT(d->arch.paging.p2m_total_pages <= 16);
>>> +
>>> +        spin_lock(&d->arch.paging.lock);
>>> +
>>> +        while ( (pg = page_list_remove_head(&p2m->pages)) )
>>> +            free_domheap_page(pg);
>>> +        while ( (pg =
>>> page_list_remove_head(&d->arch.paging.p2m_freelist)) )
>>> +            free_domheap_page(pg);
>>> +
>>> +        d->arch.paging.p2m_total_pages = 0;
>>> +
>>> +        spin_unlock(&d->arch.paging.lock);
>>> +    }
>>
>> ... you are hardcoding both p2m_teardown() and p2m_set_allocation().
>> IMO this is not an improvement at all. It is just making the code more
>> complex than necessary and lack all the explanation on the assumptions.
>>
>> So while I am fine with your patch #1 (already reviewed it), there is
>> a better patch from Henry on the ML. So we should take his (rebased)
>> instead of yours.
> 
> If by better, you mean something that still has errors, then sure.
> 
> There's a really good reason why you cannot safely repurpose
> p2m_teardown().  It's written expecting a fully constructed domain -
> which is fine because that's how it is used.  It doesn't cope safely
> with an partially constructed domain.

It is not 100% clear what is the issue you are referring to as the VMID 
is valid at this point. So what part would be wrong?

But if there are part of p2m_teardown() that are not safe for partially 
constructed domain, then we should split the code. This would be much 
better that the duplication you are proposing.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 17 23:50:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 17 Oct 2022 23:50:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424651.672236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okZs6-000351-E5; Mon, 17 Oct 2022 23:50:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424651.672236; Mon, 17 Oct 2022 23:50:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okZs6-00034u-B9; Mon, 17 Oct 2022 23:50:14 +0000
Received: by outflank-mailman (input) for mailman id 424651;
 Mon, 17 Oct 2022 23:50:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vX9e=2S=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okZs5-00034o-3Q
 for xen-devel@lists.xenproject.org; Mon, 17 Oct 2022 23:50:13 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f8dd325-4e76-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 01:50:11 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id BC6196121C;
 Mon, 17 Oct 2022 23:50:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56DA9C433D6;
 Mon, 17 Oct 2022 23:50:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f8dd325-4e76-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666050609;
	bh=XwfLY3p0u0+pgPsKAtWmTrdmX+myDEgJR7HDl0Wg+ds=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Bf8nEPlNMoPFztCDZMMqESltcSILaXMSupIzld78WWf2qVXERHdRl6dmQkNIOQzhh
	 TOgB2qeLzFTFoojWOi5Resay+4ifiVFyOU9smGLCblG9iNrGKooooJFtwBkKkn9aVM
	 ag5JTIOCJiJDc9xl7/2fSfBuB4zMFHaH4a4SrQzYN3imnGDzhiY68QbsA2K3t+XOps
	 m5tUGU1OshemHRYxsWFI5/dQAhRxYEHBf9ULqdVLDq9ya/1ZrN8ri1+6T/Dv2sPE1G
	 qz9PuMYcASyQluqdH6Kbkw5A2EozMgjN3gS9ULZXMZCFthNI6fCD/vWcCoWV5da8ua
	 zagxQVCK+8Q9Q==
Date: Mon, 17 Oct 2022 16:50:05 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Leo Yan <leo.yan@linaro.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Xen Develop <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Mathieu Poirier <mathieu.poirier@linaro.org>, 
    Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>, 
    jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, 
    wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
Message-ID: <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop> <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 17 Oct 2022, Leo Yan wrote:
> Hi Stefano,
> 
> Sorry for late response.  Please see below comments.
> 
> On Tue, Oct 11, 2022 at 02:47:00PM -0700, Stefano Stabellini wrote:
> > On Tue, 11 Oct 2022, Leo Yan wrote:
> > > > > The second question is how to mitigate the long latency when send data
> > > > > from DomU.  A possible solution is the Xen network forend driver copies
> > > > > skb into mediate (bounce) buffer, just like what does in Xen net
> > > > > backend driver with gnttab_batch_copy(), in this way the forend driver
> > > > > doesn't need to wait for backend driver response and directly return
> > > > > back.
> > > > 
> > > > About this, I am not super familiar with drivers/net/xen-netfront.c but
> > > > I take you are referring to xennet_tx_buf_gc? Is that the function that
> > > > is causing xennet_start_xmit to wait?
> > > 
> > > No.  We can take the whole flow in xen-netfront.c as:
> > > 
> > >   xennet_start_xmit()
> > >              ----------> notify Xen Dom0 to process skb
> > >              <---------  Dom0 copies skb and notify back to DomU
> > >   xennet_tx_buf_gc()
> > >   softirq/NET_TX : __kfree_skb()
> > 
> > Let me premise again that I am not an expert in PV netfront/netback.
> > However, I think the above is only true if DomU and Dom0 are running on
> > the same physical CPU. If you use sched=null as I suggested above,
> > you'll get domU and dom0 running at the same time on different physical
> > CPUs and the workflow doesn't work as described.
> > 
> > It should be:
> > 
> > CPU1: xennet_start_xmit()             ||  CPU2: doing something else
> > CPU1: notify Xen Dom0 to process skb  ||  CPU2: receive notification
> > CPU1: return from xennet_start_xmit() ||  CPU2: Dom0 copies skb
> > CPU1: do something else               ||  CPU2: notify back to DomU
> > CPU1: receive irq, xennet_tx_buf_gc() ||  CPU2: do something else
> 
> Yes, I agree this is ideal case.  I tried to set option "sched=null" but
> I can observe the latency in the second step when CPU1 notify Xen Dom0,
> Dom0 takes 500us+ to receive the notification.
> 
> Please see below detailed log:
> 
> DomU log:
> 
> 4989078512              pub-321   [003]   101.150966: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 4989078512
> 4989078573              pub-321   [003]   101.150968: bprint:               xennet_tx_setup_grant: id=24 ref=1816 offset=2 len=1514 TSC: 4989078573
> 4989078592              pub-321   [003]   101.150969: bprint:               xennet_start_xmit: xennet_notify_tx_irq: TSC: 4989078592
> 
> Dom0 log:
> 
> 4989092169           <idle>-0     [013]   140.121667: bprint:               xenvif_tx_interrupt: xenvif_tx_interrupt: TSC: 4989092169
> 4989092331           <idle>-0     [013]   140.121673: bprint:               xenvif_tx_build_gops.constprop.0: id=24 ref=1816 offset=2 len=1514 TSC: 4989092331
> 
> We can see DomU sends notification with timestamp (raw counter) is
> 4989078592 and Dom0 receives the interrupt with timestamp 4989092169.
> Since Dom0 and DomU use the same time counter and the counter
> frequency is 25MHz, so we can get the delta value (in macroseconds):
> 
>     (4989092169 - 4989078592) / 25000000 * 1000 * 1000
>   = 543us
> 
> Which means it takes 543us to let Dom0 to receive the notification.
> You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
> not have contention for CPU resources.  Seems to me, it's likely Xen
> hypervisor takes long time to deliver the interrupt, note, it's not
> take so long time for every skb transferring, sometimes the time for
> response a notification is short (about ~10us).

Good find. I think this is worth investigating further. Do you have
vwfi=native in your Xen command line as well?

After that, I would add printk also in Xen with the timestamp. The event
channel notification code path is the following:

# domU side
xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
xen/arch/arm/vgic.c:vgic_to_sgi
xen/arch/arm/vgic.c:vgic_inject_irq
xen/arch/arm/vgic.c:vcpu_kick
xen/arch/arm/gic-v2.c:gicv2_send_SGI

# dom0 side
xen/arch/arm/gic.c:do_sgi
xen/arch/arm/traps.c:leave_hypervisor_to_guest

It would be good to understand why sometimes it takes ~10us and some
other times it takes ~540us


> > > > I didn't think that waiting for the backend is actually required. I
> > > > mean, in theory xennet_start_xmit could return without calling
> > > > xennet_tx_buf_gc, it is just an optimization. But I am not sure about
> > > > this.
> > > 
> > > The function xennet_start_xmit() will not wait and directly return
> > > back, but if we review the whole flow we can see the skb is freed until
> > > the softirq NET_TX.
> > 
> > Is it an issue that the skb is not freed until later? Is that affecting
> > the latency results? It shouldn't, right?
> 
> I did an extra experiment in Xen net forend driver, I enabled the flag
> "info->bounce = true" so the forend driver will use bounce buffer to
> store data and release the skb immediately to network core layer.
> 
> The throughput can be boosted significantly for this: the netperf
> result can be improved from 107.73 Mbits/s to 300+ Mbits/s.
> 
> > What matters is when dom0 is
> > getting those packets on the physical network interface and that happens
> > before the skb is freed. I am just trying to figure out if we are
> > focusing on the right problem.
> 
> Good point.  I agree that releasing skb earlier only can benefit for
> throughput, but we still cannot resolve the latency issue if Dom0
> takes long time to relay packets to phusical network interface.
> 
> > > In this whole flow, it needs DomU and Dom0 to work
> > > together (includes two context switches) to process skb.
> > 
> > There are not necessarily 2 context switches as things should run in
> > parallel.
> > 
> > > Here I mean the optimization is to allow Dom0 and DomU to work in
> > > parallel.  It could be something like blow, the key point is DomU
> > > doesn't need to wait for Dom0's notification.
> > 
> > I think it is already the case that domU doesn't need to wait for dom0's
> > notification?
> 
> Agree.  domU doesn't need to wait for dom0's notification until it uses
> out the skb can be allocated by the network core layer.  This is why I
> also can tweak core layer's parameters for buffer size (see
> /proc/sys/net/core/wmem_default and /proc/sys/net/core/wmem_max).
> 
> > It is true that domU is waiting for dom0's notification to
> > free the skb but that shouldn't affect latency?
> 
> Yeah.  I will focus on the elaberated issue above that Dom0 takes long
> time to receive the notification.
> 
> Will keep posted if have any new finding.

Thanks, this is very interesting


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 00:28:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 00:28:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424657.672247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okaSv-0007N2-7s; Tue, 18 Oct 2022 00:28:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424657.672247; Tue, 18 Oct 2022 00:28:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okaSv-0007Mv-5A; Tue, 18 Oct 2022 00:28:17 +0000
Received: by outflank-mailman (input) for mailman id 424657;
 Tue, 18 Oct 2022 00:28:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okaSt-0007Mp-0x
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 00:28:15 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id beafca98-4e7b-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 02:28:13 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2028E611EB;
 Tue, 18 Oct 2022 00:28:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 979B1C433B5;
 Tue, 18 Oct 2022 00:28:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: beafca98-4e7b-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666052889;
	bh=64+ZmKFNnh5ijUTvPl/3DoDnfk2wOm0SWdujOej0lZk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=KreqRGzzndTizzKF2t/8EzxTWTmjOfeccgDxKTiMeMRqvt6Lqdhx+Xh9+t1sF7gmO
	 hbVwvxWH6WV/FJjt/rqVZpbFuJOegQc2wuN46ckDlkFJVWpx64Nr4sniBtxtBl9RBO
	 6NiP3QcKbyYQKvEcaCH7VOybdDrTnzI//AFsJOUnslwP6q59ghw2t9a0XDGekignTL
	 ve9DMZOBtGWRylkL8e9BPxQnTHqL/+W3GkhS7sw3OAihHuuo/pul2hyr+R0cLxTX3T
	 YuAJueHEWZAxkuflEeMF+AL6+N5XZJCzfGJMLzZagPUxrANbZIKa06ZQoeWHsa0ny7
	 FiXL4ZK2HX1bg==
Date: Mon, 17 Oct 2022 17:28:06 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, boris.ostrovsky@oracle.com, 
    jbeulich@suse.com, xen-devel@lists.xenproject.org, 
    JESHWANTHKUMAR.NK@amd.com
Subject: Re: privcmd.c not calling set_phys_to_machine
In-Reply-To: <4907e079-0001-dbc6-dbfc-ee737882fc4c@suse.com>
Message-ID: <alpine.DEB.2.22.394.2210171701460.4587@ubuntu-linux-20-04-desktop>
References: <alpine.DEB.2.22.394.2210141341120.3690179@ubuntu-linux-20-04-desktop> <4907e079-0001-dbc6-dbfc-ee737882fc4c@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 17 Oct 2022, Juergen Gross wrote:
> On 14.10.22 23:04, Stefano Stabellini wrote:
> > Hi Juergen and all,
> > 
> > I am writing again to ask a question about privcmd.c in PV dom0 x86.
> > This is related to the previous pin_user_pages_fast issue:
> > 
> > https://marc.info/?l=xen-devel&m=166268914727630
> > https://marc.info/?l=xen-devel&m=166322385912052
> > 
> > 
> > In summary this is the situation:
> > 
> > 1. domU (HVM) kernel space:
> >      a. pages allocation with get_free_pages()
> >      b. get dma_handle by calling dma_map_page() on the pages allocated in
> > (1.a)
> >      c. send dma_handle to dom0 (PV) using virtio queue
> > 
> > 2. dom0 userspace (QEMU):
> >          a. read dma_handle from virtio queue
> >          b. map dma_handle using QEMU dma_memory_map(), which calls
> >             xenforeignmemory_map2, which is IOCTL_PRIVCMD_MMAPBATCH_V2,
> >             which ends up calling
> > drivers/xen/privcmd.c:privcmd_ioctl_mmap_batch
> >             [this is verified to work correctly, the mapping works]
> >          c. open /dev/tee node and make an ioctl call to register the
> >             virtual address (from step 2.b) with TEE.
> > 
> > 3. dom0 kernel space:
> >          a. AMD TEE driver get the virtual address passed by userspace
> >          b. AMD TEE driver get the list of pages corresponding to the
> >             virtual address (3.a) and calls dma_map_page() on them
> 
> I'm rather sure "AMD TEE driver get the list of pages corresponding to the
> virtual address" is the problem. The PTEs should have the "special" flag
> set, meaning that there is no struct page associated with this virtual area.
> 
> > The last step (3.b) misbehaves as dev_addr at the beginning of
> > xen_swiotlb_map_page (which implements dma_map_page() in dom)) is 0.
> > 
> >    dma_addr_t dev_addr = xen_phys_to_dma(dev, phys);
> >    /* dev_addr here is zero */
> > 
> > 
> > Could it be that the original mapping of the foreign pages in Dom0, done
> > by step 2.b, is not complete? Looking into
> > privcmd_ioctl_mmap_batch, for PV guests, it is calling mmap_batch_fn:
> > 
> > 	BUG_ON(traverse_pages_block(m.num, sizeof(xen_pfn_t),
> > 				    &pagelist, mmap_batch_fn, &state));
> > 
> > mmap_batch_fn calls xen_remap_domain_gfn_array, which calls
> > xen_remap_pfn.
> > 
> > xen_remap_pfn only changes the VA->PA mapping and does nothing else.
> > Specifically, nobody seems to call set_phys_to_machine in this code
> > path. Isn't set_phys_to_machine required?
> 
> Not for special memory pages.
> 
> > Don't we need a call to set_phys_to_machine so that the next time a
> > driver tries to call:
> > 
> >    /* address is the virtual address passed by QEMU userspace */
> >    dma_map_page(virt_to_page(address))
> > 
> > it will behave correctly? Or am I missing something?
> > 
> > 
> > How is xen_phys_to_dma expected to work correctly for:
> > 
> >    /* address is the virtual address passed by QEMU userspace and mapped
> >     * in 2.b */
> >    phys_addr = virt_to_phys(address);
> >    xen_phys_to_dma(dev, phys_addr);
> > 
> > 
> > My guess would be that we need to add:
> > 
> >    set_phys_to_machine(pfn, FOREIGN_FRAME(mfn));
> > 
> > in mmap_batch_fn or xen_remap_pfn?
> 
> I think this might be a little bit more complicated.
> 
> This could work, if there is really a struct page available for the PFN.
> OTOH this might be not the case quite often, as we are using zone device
> memory for foreign mappings per default for some time now.
> 
> Solving this might require something like dma_map_pfn() instead of
> dma_map_page(), which sounds a little bit like dma_direct_mmap().

It is actually dma_mmap_attrs and looking at its description it would
have to be step 2.b to call dma_mmap_attrs instead of
xen_remap_domain_gfn_array? Also, we would need an implementation of
.mmap in xen_swiotlb_dma_ops.


I think that's fine but I am not clear on how to implement
xen_swiotlb_dma_ops.mmap for PV guests. I can imagine that on HVM/PVH it
would just be similar to xen_xlate_remap_gfn_array. How do you see it
implemented for PV?



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 00:28:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 00:28:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424660.672259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okaTZ-0007rm-H8; Tue, 18 Oct 2022 00:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424660.672259; Tue, 18 Oct 2022 00:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okaTZ-0007rf-E6; Tue, 18 Oct 2022 00:28:57 +0000
Received: by outflank-mailman (input) for mailman id 424660;
 Tue, 18 Oct 2022 00:28:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okaTY-0007rU-20; Tue, 18 Oct 2022 00:28:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okaTY-0004DJ-0E; Tue, 18 Oct 2022 00:28:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okaTX-0005Js-G7; Tue, 18 Oct 2022 00:28:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okaTX-0000iH-Ff; Tue, 18 Oct 2022 00:28:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JU/DQ2Fv7MI9sCzttfgIHPtTS/2/CezI6eQxsvel8oo=; b=01isy9YDTk+9Z5EpHMqn6skZmw
	IOXvHnL7uNZlmvc7YQiVbU5SS+NZ6eZPY7JJOBxvQFH3YA+H/IA9zh7qcxtI+GF+kyDIMrrum3eo7
	XsJgGSQoITEvLNEyw/R12CCl8lY7CzM3XkSw4WQQV9JyzyUCxoaUJHvNJkofPd1c2S2Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174023-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174023: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 00:28:55 +0000

flight 174023 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174023/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174001

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174001 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174001 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   41 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 00:33:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 00:33:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424672.672270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okaYM-0000zM-7F; Tue, 18 Oct 2022 00:33:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424672.672270; Tue, 18 Oct 2022 00:33:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okaYM-0000zE-4S; Tue, 18 Oct 2022 00:33:54 +0000
Received: by outflank-mailman (input) for mailman id 424672;
 Tue, 18 Oct 2022 00:33:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okaYL-0000z6-Dr
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 00:33:53 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a43216d-4e7c-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 02:33:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D1588B81A09;
 Tue, 18 Oct 2022 00:33:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9069AC433D6;
 Tue, 18 Oct 2022 00:33:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a43216d-4e7c-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666053230;
	bh=s8Ob3Xrk7tyLWJ7Xn4reoQ1dzzjGxajI/oJLYN0+MuE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Xj5Ux9KgDYEZGY6LVpo7mp1bwA/gxjzQhEEUR60vl/f83SfM3nPTo0XHlINhnXG/Z
	 BhhcYyrzLjQEr0Z+JpiwxrGfb6Bt/veMiczXkUi1PQBAcR3FSWq87KbulLA6bfTZG3
	 tYje0HlpPAeqTzKWGNoMmE1KM/zq24qJohlstfmRtimWJo6GXF4w3GoaSUEyqsqfCD
	 q80F/en95pj3E2Q0sSxMuEOib0pgBukCd/E2pNe3YTzijSU0wvuEpJ/zEQ2BhHnEWg
	 EdtDOKQmjBQ0Pp7JPPwlR8KASO0kjD+JJnQCwVcgIxSAGyt3zBOHKX/hYcTE9j6aRg
	 O8U7lfdIxVmlA==
Date: Mon, 17 Oct 2022 17:33:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
In-Reply-To: <20221015153409.918775-1-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210171731110.4587@ubuntu-linux-20-04-desktop>
References: <20221015153409.918775-1-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the same "xen-grant-dma" device concept for the PCI devices
> behind device-tree based PCI Host controller, but with one modification.
> Unlike for platform devices, we cannot use generic IOMMU bindings
> (iommus property), as we need to support more flexible configuration.
> The problem is that PCI devices under the single PCI Host controller
> may have the backends running in different Xen domains and thus have
> different endpoints ID (backend domains ID).

Hi Oleksandr,

>From another email I understood that you successfully managed to
describe in device tree all the individual virtio pci devices so that
you can have iommu-map/iommu-map-mask properties under each virtio
device node. Is that right?

If that is the case, then I would rather jump straight to that approach
because I think it is far better than this one.

Cheers,

Stefano



> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
> properties) which allows us to describe relationship between PCI
> devices and backend domains ID properly.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> than for platform devices.
> 
> Changes V1 -> V2:
>    - update commit description
>    - rebase
>    - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
> 
> Based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
> ---
>  drivers/xen/grant-dma-ops.c | 87 ++++++++++++++++++++++++++++++++-----
>  1 file changed, 76 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index daa525df7bdc..b79d9d6ce154 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>  #include <linux/module.h>
>  #include <linux/dma-map-ops.h>
>  #include <linux/of.h>
> +#include <linux/pci.h>
>  #include <linux/pfn.h>
>  #include <linux/xarray.h>
>  #include <linux/virtio_anchor.h>
> @@ -292,12 +293,55 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> +static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
> +{
> +	struct pci_dev *pdev = to_pci_dev(dev);
> +	struct pci_bus *bus = pdev->bus;
> +
> +	/* Walk up to the root bus to look for PCI Host controller */
> +	while (!pci_is_root_bus(bus))
> +		bus = bus->parent;
> +
> +	return of_node_get(bus->bridge->parent->of_node);
> +}
> +
> +static struct device_node *xen_dt_get_node(struct device *dev)
> +{
> +	if (dev_is_pci(dev))
> +		return xen_dt_get_pci_host_node(dev);
> +
> +	return of_node_get(dev->of_node);
> +}
> +
> +static int xen_dt_map_id(struct device *dev, struct device_node **iommu_np,
> +			 u32 *sid)
> +{
> +	struct pci_dev *pdev = to_pci_dev(dev);
> +	u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +	struct device_node *host_np;
> +	int ret;
> +
> +	host_np = xen_dt_get_pci_host_node(dev);
> +	if (!host_np)
> +		return -ENODEV;
> +
> +	ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask", iommu_np, sid);
> +	of_node_put(host_np);
> +
> +	return ret;
> +}
> +
>  static bool xen_is_dt_grant_dma_device(struct device *dev)
>  {
> -	struct device_node *iommu_np;
> +	struct device_node *iommu_np = NULL;
>  	bool has_iommu;
>  
> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +	if (dev_is_pci(dev)) {
> +		if (xen_dt_map_id(dev, &iommu_np, NULL))
> +			return false;
> +	} else
> +		iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +
>  	has_iommu = iommu_np &&
>  		    of_device_is_compatible(iommu_np, "xen,grant-dma");
>  	of_node_put(iommu_np);
> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
>  
>  bool xen_is_grant_dma_device(struct device *dev)
>  {
> +	struct device_node *np;
> +
>  	/* XXX Handle only DT devices for now */
> -	if (dev->of_node)
> -		return xen_is_dt_grant_dma_device(dev);
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		bool ret;
> +
> +		ret = xen_is_dt_grant_dma_device(dev);
> +		of_node_put(np);
> +		return ret;
> +	}
>  
>  	return false;
>  }
> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
>  static int xen_dt_grant_init_backend_domid(struct device *dev,
>  					   struct xen_grant_dma_data *data)
>  {
> -	struct of_phandle_args iommu_spec;
> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
>  
> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> -			0, &iommu_spec)) {
> -		dev_err(dev, "Cannot parse iommus property\n");
> -		return -ESRCH;
> +	if (dev_is_pci(dev)) {
> +		if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
> +			dev_err(dev, "Cannot translate ID\n");
> +			return -ESRCH;
> +		}
> +	} else {
> +		if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> +				0, &iommu_spec)) {
> +			dev_err(dev, "Cannot parse iommus property\n");
> +			return -ESRCH;
> +		}
>  	}
>  
>  	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> @@ -354,6 +413,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>  void xen_grant_setup_dma_ops(struct device *dev)
>  {
>  	struct xen_grant_dma_data *data;
> +	struct device_node *np;
>  
>  	data = find_xen_grant_dma_data(dev);
>  	if (data) {
> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  	if (!data)
>  		goto err;
>  
> -	if (dev->of_node) {
> -		if (xen_dt_grant_init_backend_domid(dev, data))
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		int ret;
> +
> +		ret = xen_dt_grant_init_backend_domid(dev, data);
> +		of_node_put(np);
> +		if (ret)
>  			goto err;
>  	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>  		dev_info(dev, "Using dom0 as backend\n");
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 01:26:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 01:26:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424678.672281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okbNc-0004pb-6F; Tue, 18 Oct 2022 01:26:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424678.672281; Tue, 18 Oct 2022 01:26:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okbNc-0004pU-2o; Tue, 18 Oct 2022 01:26:52 +0000
Received: by outflank-mailman (input) for mailman id 424678;
 Tue, 18 Oct 2022 01:26:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okbNb-0004pN-2H
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 01:26:51 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id efb23eae-4e83-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 03:26:49 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 5E180612F4;
 Tue, 18 Oct 2022 01:26:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF227C433D6;
 Tue, 18 Oct 2022 01:26:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: efb23eae-4e83-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666056407;
	bh=T68CN2SGOaBpQNuMZfn7mBL9Zq41PiKYwHxZzpuuZRQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=fWMyBqNDPxEMfzKCer3hc8hnYg8Lk9xRepw33WRjRSobJS3ZkNy4j2M+ytM3AHPgO
	 8nZX2q7JSxnhFwjUi29UzhNw/w0Ezeu5OHNVTajm2KF26i3cvC6kbUBPQWX/FPvITg
	 cPLO+kkx5cQmScEmOd1SbvFJT+YJjYs1eri2HUQaKpnhdjniSUGPOAtGT0EBIlo9E1
	 nMXiMDKfwdXP2NJQNgVLbVPOzba119X1a+s0A1Mwl1T94WMaHJ3Sm06Ca7+2Dv5L7k
	 SN3dVcGoAT8e4MbCyFnz93pRYPWwA2ycmdgh5DuUwQyGmJ4z6w1iybe3J4woIuGQus
	 1RjqNpjcKcrzw==
Date: Mon, 17 Oct 2022 18:26:43 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org, 
    stefano.stabellini@amd.com, Peter Maydell <peter.maydell@linaro.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, 
    "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>, 
    "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
In-Reply-To: <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
Message-ID: <alpine.DEB.2.22.394.2210171345450.2351079@ubuntu-linux-20-04-desktop>
References: <20221015050750.4185-1-vikram.garhwal@amd.com> <20221015050750.4185-11-vikram.garhwal@amd.com> <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sun, 16 Oct 2022, Julien Grall wrote:
> Hi,
> 
> There seem to be some missing patches on xen-devel (including the cover
> letter). Is that expected?
> 
> On 15/10/2022 06:07, Vikram Garhwal wrote:
> > Add a new machine xenpv which creates a IOREQ server to register/connect
> > with
> > Xen Hypervisor.
> 
> I don't like the name 'xenpv' because it doesn't convey the fact that some of
> the HW may be emulated rather than para-virtualized. In fact one may only want
> to use for emulating devices.
> 
> Potential name would be 'xen-arm' or re-using 'virt' but with 'accel=xen' to
> select a Xen layout.

The benefit of 'xenpv' is that it doesn't require any changes to libxl.
It is even backward compatible so it could be used with an older version
of Xen/libxl. Backward compatibility aside, if we come up with a
different name then we'll need changes to libxl and to manage those
changes. For instance, if we use 'xen-arm' that would mean we would need
to handle per-arch QEMU machine names.


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 01:26:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 01:26:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424679.672292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okbNj-00056i-Dl; Tue, 18 Oct 2022 01:26:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424679.672292; Tue, 18 Oct 2022 01:26:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okbNj-00056W-Ax; Tue, 18 Oct 2022 01:26:59 +0000
Received: by outflank-mailman (input) for mailman id 424679;
 Tue, 18 Oct 2022 01:26:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okbNh-00055g-Vs
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 01:26:57 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3dd3eef-4e83-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 03:26:56 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 61C476131D;
 Tue, 18 Oct 2022 01:26:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 713D3C433D6;
 Tue, 18 Oct 2022 01:26:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3dd3eef-4e83-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666056414;
	bh=e/FVKmjHz7MymBQZF1e2NJrF7LA/JdyKHUkXs0U4oCo=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ei8aoBlMpDFZxdLLdKBgvbEbXtoR9h2XV2+LhO4SOQePty/BsLpbE7/wu8nPgR5hc
	 azPcVsJ2i54XB/FJIpu2iWKFwHtBRPQqc82D1YDAkWcCIIdhQoqUKVv9iVzP4cV6UP
	 CQ4YOEAD7j1r4Oxe0BVQcmGACYOYUN8lBTwLoAs/0N4vzPw6y9rnZXbp9mAnt+W+6R
	 Vt5lZjo4oe9zCZKNbBo/qU/xsSBb6y5fhHBEFojgbaIa/mNet9nRyxVO2jtsbBbGYV
	 HXK1WkBqAt7E1ZqPfizCbuvuYRlMK7Wv1TQzPoOjZokz2hGIMPKHzgE9aSzhKQvgbO
	 ydcyKHVX7e1WA==
Date: Mon, 17 Oct 2022 18:26:51 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Ayan Kumar Halder <ayankuma@amd.com>, 
    "Stabellini, Stefano" <stefano.stabellini@amd.com>, 
    "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, 
    Henry Wang <Henry.Wang@arm.com>, Penny Zheng <Penny.Zheng@arm.com>, 
    Jaxson Han <Jaxson.Han@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Need guidance to support reading GICR_TYPER (64 bit register)
 on Aarch32_v8r
In-Reply-To: <6D2FD203-04D9-4CDD-B57D-E90F5BC5CC3A@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210171549480.4587@ubuntu-linux-20-04-desktop>
References: <e2d041b2-3b38-f19b-2d8e-3a255b0ac07e@amd.com> <alpine.DEB.2.22.394.2210141109400.3690179@ubuntu-linux-20-04-desktop> <e5e337cc-9478-e4d5-e7ce-71138817f56e@xen.org> <2FED929A-C718-468B-B385-5C80CEED0664@arm.com>
 <6D2FD203-04D9-4CDD-B57D-E90F5BC5CC3A@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 17 Oct 2022, Bertrand Marquis wrote:
> > On 17 Oct 2022, at 10:17, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
> >> On 15 Oct 2022, at 10:28, Julien Grall <julien@xen.org> wrote:
> >> On 14/10/2022 19:09, Stefano Stabellini wrote:
> >>> On Thu, 13 Oct 2022, Ayan Kumar Halder wrote:
> >>>> Hi Arm mantainers/Folks,
> >>>> 
> >>>> Please refer to the discussion
> >>>> https://github.com/zephyrproject-rtos/zephyr/pull/51163 .
> >>>> 
> >>>> We intend to run Zephyr as a domU guest on Xen on Aarch32_v8R fixed virtual
> >>>> platform.
> >>>> 
> >>>> Zephyr is trying to read GICR_TYPER which is a 64 bit register using ldrd
> >>>> instruction.
> >>>> 
> >>>> As GICR is emulated by Xen, so this instruction gets trapped with HSR =
> >>>> 0x9200000c.
> >>>> 
> >>>> As ISV is 0, so Xen cannot emulate this instruction.
> >>>> 
> >>>> The proposed solution is to use two sys_read32() on GICR_TYPER to return the
> >>>> lower and upper 32 bits.
> >>>> 
> >>>> With this, HSR = 0x9383 000c, ISV=1 so ISS is valid.
> >>> Hi all,
> >>> I wanted to take a step back on this issue before we jump into the
> >>> details.
> >>> Differently from other instructions we discussed in the past, strd and ldrd
> >>> are not deprecated and are not "unusual corner cases". There is no
> >>> statements such as "please don't use this" on the ARM ARM. If I were to
> >>> write an register read/write function in assembly for an RTOS, it would
> >>> be reasonable to use them.
> >> 
> >> Just to be clear it is fine to use the ldrd/strd for accessing non MMIO area. The problem comes with MMIO access because they can be emulated by the hypervisor and we don't have the syndrome. At the moment, this is only a problem when accessing some of the GICv3 (including ITS) registers.
> >> 
> >>> So, I struggle to see how we'll be able to deal with all the possible
> >>> RTOSes out there that might have them in the code. We can fix Zephyr,
> >>> but what about FreeRTOS, ThreadX and the proprietary ones (VxWorks,
> >>> etc.)?
> >> 
> >> This is not an Xen issue but architecture issue. The RTOSes will face the exact same issue on any hypervisors unless they decided to decode the instruction.
> >> 
> >> As we discussed before decoding an instruction correctly is quite difficult to do (what we have in Xen for pos-increment store/load is just a band-aid). So I would expect the other hypervisors to have made the decision to not implement it. AFAIK KVM doesn't suppor them,
> >> Note that looking at ID_ISAR2, it seems that ldrd/strd is technically optional. Therefore, the RTOS would have to assume it is targeting a processor that supports them.
> >> 
> >>> Unless we can get ARM to issue a clear guidance that strd and ldrd are
> >>> deprecated, 
> >> 
> >> Arm Arm cannot say that because ldrd/strd are necessary to modify the LPAE page-tables atomically. What we need to know is which instructions can be allowed on MMIO accesses.
> > 
> > Definitely this is something that arm arm cannot fully answer as it is also down to the full platform. MMIO accesses are going out of the CPU and hence wether or not 64bit MMIO accesses can be properly done might also depend on the bus or the IP on the other side (some peripherals might just refuse 64bit accesses or some bus might only be 32bit so the operations would need to be divided).
> > 
> >> 
> >> I think I already raised that when Ayan added decoding for post-increment instructions. There are plenty of instructions (or combinations) that doesn't provide a syndrome and yet the processor doesn't prevent anyone to use them on MMIO.
> >> 
> >> I was worry we are going to have to continue to decode instructions in a non-compliant way in Xen just to please a few RTOs that may not even run anywhere else.
> >> 
> >> This would also reduce our leverage to request a change in the RTOes or the Arm Arm (maybe there is already a statement I haven't spotted) because Xen will already (badly) support the instruction.
> > 
> > Going back on the ID_ISAR2, if Xen is properly setting the value seen by the guests, there is not reason for us to actually emulate those instructions.
> > The emulation code inside Xen cost a lot in matter of lines of code and would need a lot of testing (which is missing at the moment).
> > So as we have a standard way to inform the guest that this is not supported, we should stick to that.
> > 
> >> 
> >>> I think it would be better to attempt to decode them rather
> >>> than just fail. I don't like to have this kind of code in Xen, but I
> >>> don't see a way to support R52s without it.
> >> That's not specific to R52. This is anyone using GICv3 on Arm32 core.
> > 
> > Agree.
> > 
> >> 
> >>> That said, of course if Zephyr was to use two 32-bit reads instead of
> >>> one 64-bit read, it would be better for Xen. And we have more important
> >>> things to deal with right now in terms of R52 support (it is not even
> >>> upstream yet). So it is totally fine to change Zephyr and move forward
> >>> for now.
> >>> But medium term it doesn't seem to me that we can get away without a
> >>> solution in Xen for this (or a change in the ARM ARM).
> >> 
> >> See above. This is an architecture problem and we should discuss with Arm first before continuing to add more decoding in Xen.
> > 
> > I will discuss it internally to have an answer but I think that the answer cannot only come from Arm as there are for sure hardware implementations that cannot support this, as explain before.
> 
> I had some discussions internally and here is the official view:
> 
> >From the architecture point of view this should always work but this is not virtualisable (as there is no syndrome register) and not recommended as deferencing a pointer accessing MMIO registers is not safe, so it should not be done for MMIO.
> 
> Linux is not doing those kind of accesses and KVM does not support guest doing them.
> 
> So I think we should not try to emulate this.

I wouldn't take Linux and KVM as role models for the embedded space.
Zephyr would be better (unfortunately Zephyr is not behaving as we
prefer today).


At least at AMD/Xilinx, our users try something on native first, then
they try it on Xen, and if it doesn't work they blame Xen. They don't
typically try KVM and compare behavior. We try to explain that Xen is
not necessarily to blame but this is the natural way of thinking for
engineers apparently as it happened many times in the last few years for
a range of issues with users in very different
geographys/companies/projects.

I am writing the above just for context and to create a common
understanding of Xen users' behavior and way of thinking. I don't think
we can succeed in changing our users' way of thinking.

So generally my preference is to try to prevent a situation where a user
might reach out to us in regard to something that used to work on native
and doesn't anymore on Xen. It is always very difficult to explain in a
way that is convincing to the user.


But honestly, we had zero reports of ldrd/strd causing a guest crash
from users so far. So I think it is OK not to introduce code in the
hypervisor to fix a "theoretical" bug. So one approach is to wait for
the first real user report of the problem and then re-discuss the issue
at that point in time (if it ever happens).

Documentation would help if we had it -- we don't have an official
document anywhere stating that Xen as a project doesn't intend to
support ltrd/strd on MMIO regions. That would help.

If we had such a document, it would be easier to explain the issue to
users and they would more easily fix their RTOS if they can. There is
also the possibility that they can't, because it is provided by
third-parties. Like above, if it happens we can re-discuss it at that
point in time.


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 01:27:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 01:27:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424680.672303 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okbNy-0005dE-LQ; Tue, 18 Oct 2022 01:27:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424680.672303; Tue, 18 Oct 2022 01:27:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okbNy-0005d7-IR; Tue, 18 Oct 2022 01:27:14 +0000
Received: by outflank-mailman (input) for mailman id 424680;
 Tue, 18 Oct 2022 01:27:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okbNx-0004pN-9Z
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 01:27:13 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd96251b-4e83-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 03:27:12 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 57B93B81BE1;
 Tue, 18 Oct 2022 01:27:11 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 592C8C433D6;
 Tue, 18 Oct 2022 01:27:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd96251b-4e83-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666056430;
	bh=d/uyL4nUXrAWbDTy+W/35i9Dy1kXM9XMBqMFwfsxsik=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=rIBmP2ZhAsbyxTd/tTY9SjVpt5tYxVDpsnS5VVIc/Qx+T/P4iIvH42DKU7qNNewjq
	 ZJB1F5y20Hm/yM/q9klK3+d9CuY1yhuBm6rvvQHrbJ9+cBYpOFrIFeFBkStnjrCjuR
	 JYjCYIdkyYcfqUF6NnAZbDa+48NmPUnYDiAjCC/fZYLNu/S6v3tSZ3d1yMZCCWetWY
	 EG6q3DERC5ZpSYQCIB2L0zk5Lp0ZsOFC83lffbmkZ2DalpE7Wqy7nW4CTivCjD3m77
	 xBsuVCOkfwMKpkR9q1pTMgOXvxrrzuuoXaTA07NvDEyJijxuBYpVRKXMwCMBHq5O/q
	 1Fy/JtHu86LOg==
Date: Mon, 17 Oct 2022 18:27:07 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
In-Reply-To: <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
References: <cover.1665561024.git.bertrand.marquis@arm.com> <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop> <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 17 Oct 2022, Bertrand Marquis wrote:
> Hi Stefano,
> 
> > On 14 Oct 2022, at 21:27, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Wed, 12 Oct 2022, Bertrand Marquis wrote:
> >> This patch series is a first attempt to check if we could use Yocto in
> >> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
> >> 
> >> The first patch is creating a container with all elements required to
> >> build Yocto, a checkout of the yocto layers required and an helper
> >> script to build and run xen on qemu with yocto.
> >> 
> >> The second patch is creating containers with a first build of yocto done
> >> so that susbsequent build with those containers would only rebuild what
> >> was changed and take the rest from the cache.
> >> 
> >> The third patch is adding a way to easily clean locally created
> >> containers.
> >> 
> >> This is is mainly for discussion and sharing as there are still some
> >> issues/problem to solve:
> >> - building the qemu* containers can take several hours depending on the
> >>  network bandwith and computing power of the machine where those are
> >>  created
> >> - produced containers containing the cache have a size between 8 and
> >>  12GB depending on the architecture. We might need to store the build
> >>  cache somewhere else to reduce the size. If we choose to have one
> >>  single image, the needed size is around 20GB and we need up to 40GB
> >>  during the build, which is why I splitted them.
> >> - during the build and run, we use a bit more then 20GB of disk which is
> >>  over the allowed size in gitlab
> >> 
> >> Once all problems passed, this can be used to build and run dom0 on qemu
> >> with a modified Xen on the 3 archs in less than 10 minutes.
> > 
> > The build still doesn't work for me. I found the reason:
> > 
> >  create archive failed: cpio: write failed - Cannot allocate memory
> > 
> > It is a "silly" out of memory error. I tried to solve the problem by
> > adding:
> > 
> >  export RPM_BUILD_NCPUS=8
> > 
> > at the beginning of build-yocto.sh but it didn't work. I realize that
> > this error might be considered a workstation configuration error at my
> > end but I cannot find a way past it. Any suggestions?
> 
> 
> Can you give me more details on when this is happening ? Ie the full logs.
> 
> Can you try to apply the following:
> --- a/automation/build/yocto/build-yocto.sh
> +++ b/automation/build/yocto/build-yocto.sh
> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
>  # Save some disk space
>  INHERIT += "rm_work"
> 
> +# Reduce number of jobs
> +BB_NUMBER_THREADS=2
> +
>  EOF
> 
>      if [ "${do_localsrc}" = "y" ]; then
> 
> This should reduce the number of parallel jobs during Yocto build.

It should be

BB_NUMBER_THREADS="2"

but that worked! Let me a couple of more tests.


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 02:10:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 02:10:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424699.672320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okc3v-0003GJ-2i; Tue, 18 Oct 2022 02:10:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424699.672320; Tue, 18 Oct 2022 02:10:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okc3u-0003GC-V1; Tue, 18 Oct 2022 02:10:34 +0000
Received: by outflank-mailman (input) for mailman id 424699;
 Tue, 18 Oct 2022 02:10:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okc3t-0003G2-Lk; Tue, 18 Oct 2022 02:10:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okc3t-0004ox-I7; Tue, 18 Oct 2022 02:10:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okc3t-0000zO-4P; Tue, 18 Oct 2022 02:10:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okc3t-0000da-3p; Tue, 18 Oct 2022 02:10:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gBN+yg6ekWuV380q55PLyw+aRa55A4P2d5Lj/pCbvP4=; b=XZSDBJ5TFPozdiKsPMgQhYiJmx
	DmthXofpEgiG1OAUpRJNgI9xp/1autlL50vOqVjLbMyYAo93aZwKjU8nZ0tc7RE9/kU83KlvvXscZ
	H/KKQlpZAtHP6ME58SMoopwI4rMjvMOUkyQS/X3Leg/SDHTEI//hpSVo414kHqZhzng8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173967-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 173967: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=5c2439a92ce4a1c5a53070bd803d6f7647e702ca
X-Osstest-Versions-That:
    qemuu=f1d33f55c47dfdaf8daacd618588ad3ae4c452d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 02:10:33 +0000

flight 173967 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173967/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173447
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173447
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173447
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173447
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173447
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173447
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173447
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173447
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                5c2439a92ce4a1c5a53070bd803d6f7647e702ca
baseline version:
 qemuu                f1d33f55c47dfdaf8daacd618588ad3ae4c452d1

Last test of basis   173447  2022-10-06 14:38:42 Z   11 days
Failing since        173497  2022-10-11 15:38:33 Z    6 days    7 attempts
Testing same since   173967  2022-10-17 00:10:12 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akihiko Odaki <akihiko.odaki@daynix.com>
  Alberto Faria <afaria@redhat.com>
  Alex Bennée <alex.bennee@linaro.org>
  Alexander Graf <agraf@csgraf.de>
  Alistair Francis <alistair.francis@wdc.com>
  Ani Sinha <ani@anisinha.ca>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Bryce Mills <brycemills@proton.me>
  Chenyi Qiang <chenyi.qiang@intel.com>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniil Tatianin <d-tatianin@yandex-team.ru>
  David Hildenbrand <david@redhat.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dongwon Kim <dongwon.kim@intel.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Emmanuel Blot <emmanuel.blot@sifive.com>
  Eric Auger <eric.auger@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Greg Kurz <groug@kaod.org>
  Hal Martin <hal.martin@gmail.com>
  Helge Konetzka <hk@zapateado.de>
  Igor Mammedov <imammedo@redhat.com>
  Janosch Frank <frankja@linux.ibm.com>
  Jason Wang <jasowang@redhat.com>
  Jerome Forissier <jerome.forissier@linaro.org>
  Jim Shu <jim.shu@sifive.com>
  Joel Stanley <joel@jms.id.au>
  John Millikin <john@john-millikin.com>
  Jonah Palmer <jonah.palmer@oracle.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Juan Quintela <quintela@redhat.com>
  Kevin Wolf <kwolf@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  lu zhipeng <luzhipeng@cestc.cn>
  Marc Zyngier <maz@kernel.org>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Michael Labiuk <michael.labiuk@virtuozzo.com>
  Michael S. Tsirkin <mst@redhat.com>
  Miguel Luis <miguel.luis@oracle.com>
  Pankaj Gupta <pankaj.gupta@amd.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Peter Xu <peterx@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>
  Sebastian Mitterle <smitterl@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Sunil V L <sunilvl@ventanamicro.com>
  Thomas Huth <thuth@redhat.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Volker Rümelin <vr_qemu@t-online.de>
  Wilfred Mallawa <wilfred.mallawa@wdc.com>
  Yang Liu <liuyang22@iscas.ac.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   f1d33f55c4..5c2439a92c  5c2439a92ce4a1c5a53070bd803d6f7647e702ca -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 03:16:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 03:16:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424707.672330 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okd5O-0001PF-RL; Tue, 18 Oct 2022 03:16:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424707.672330; Tue, 18 Oct 2022 03:16:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okd5O-0001P8-Ob; Tue, 18 Oct 2022 03:16:10 +0000
Received: by outflank-mailman (input) for mailman id 424707;
 Tue, 18 Oct 2022 03:16:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okd5O-0001Oy-7p; Tue, 18 Oct 2022 03:16:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okd5O-00061n-5X; Tue, 18 Oct 2022 03:16:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okd5N-0003FY-SY; Tue, 18 Oct 2022 03:16:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okd5N-0005fA-S6; Tue, 18 Oct 2022 03:16:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UHkxreUhdpqhpD+OIyPe0HtdgUZqsAkelMHxJGfpNm0=; b=z6uFz3eJs9mQFh+nI42QuSxlH/
	jWl+dsGJHqdf0vWW5H18WN0PiAwd81tilH2f16ybDz6YY5wpY/+KHZFRk58VhkQQwVs+WGRh8J/IZ
	LMzCK5IBWbil7vi0iIH0aD7VW6OPDQJ6+wGv/JSmbF2LCAhZXIDlSYK9Y5HfMznLHc78=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174028-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174028: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 03:16:09 +0000

flight 174028 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174028/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174001

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174001 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174001 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   42 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 03:52:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 03:52:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424717.672348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okdeV-0005l7-Ki; Tue, 18 Oct 2022 03:52:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424717.672348; Tue, 18 Oct 2022 03:52:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okdeV-0005l0-IA; Tue, 18 Oct 2022 03:52:27 +0000
Received: by outflank-mailman (input) for mailman id 424717;
 Tue, 18 Oct 2022 03:52:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=llzQ=2T=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1okdeT-0005ku-TX
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 03:52:26 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45187003-4e98-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 05:52:23 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 8802F5C021E;
 Mon, 17 Oct 2022 23:52:21 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 17 Oct 2022 23:52:21 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 17 Oct 2022 23:52:19 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45187003-4e98-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:message-id:mime-version:reply-to:sender:subject
	:subject:to:to; s=fm3; t=1666065141; x=1666151541; bh=W4YdM85rRr
	G8oSndD/hIo0CDcv3F1jsFFOfc7EWctI4=; b=QHQht0C4dVlXl/FbBF9w7NG9o4
	4UgJ8jOEvdug/MzJJ9yawQ2Q77WksxxyG4F6cmNvBRNWaZee4kxO8M8uVHjxTbmr
	r4VNCeI2ideFuwp5rJugzV1+T7PLZ9faCVHQSv7esIKDbY/2FENPFRcsiFm9gozT
	qcZM8xYq5hy8b0+8fFEgUuCtQ5FFS01tWWWGxJ4yqkYu6ER1+hFvX1YH03VoaoFI
	ie5svNFkqEUybqyUJu+cs6Kt/T6v1vyeII04OOEN7+vr06JBHH+NSjIFqmi7k6Pf
	Ldmeor+EMZ6EJoO4Vf0ZJx7YFC9KyOOdMVsHoCmED+x4Hqy/PLbi5/j0yAgA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:message-id:mime-version
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666065141; x=
	1666151541; bh=W4YdM85rRrG8oSndD/hIo0CDcv3F1jsFFOfc7EWctI4=; b=I
	r2PL6lYzUUvpbh6Rkts4EO0ht4E+sf7lcSHJvbPy8vJCFhdS3itiRXhTAPuCbDkr
	0FaBeLbEMqzg3ZYCzr80DkLJqXgsLwi8v6MICwzFkumS0abPydv/SiCZ+E8XlCzZ
	taiWPK2yZPpAjpRJLMdflzzLlhQL2rUdlDZhAxluRu1Aq0ypYa73sHJxeIU6U6Zp
	grwAH3BQF1bu1qmLv4EODp8YCn73YnXySP3p3XAYna2l+0IvwqlqI+sS0p6Pb4Zg
	fvS02sp3lTLOW8ZQIvTxVk93h8YQgRmdWmdXZe4INI2y/xPAGcCAN6o7Ctvy43sh
	x8kd6Aum1x3IUPnrNZOUg==
X-ME-Sender: <xms:9CJOY-Hs1A2mbvw8Np9dZ86H7aWMvHikYIjhdixNFZEuttrDAByybg>
    <xme:9CJOY_Ud3fUTNSujKSylqRCCEHASmm7N9--uMjO3Ve3tuvIUIRaht-ZrbVuESWIKp
    JH0YlsVyzgPKA>
X-ME-Received: <xmr:9CJOY4I3TGP0QG9t5gony9WuosjuBLsbUn-Qn-2VSsuPyzSqlCwP8-uCA1RFBYkOa9FQJs38Xzv3xMf06uXyDUuOME-YNQZAKocl>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeltddgjeejucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkgggtugesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu
    ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhephefguedv
    jeekieekleduleetveefgeffgeetfeffteehteffuddujeeuudfgvdetnecuffhomhgrih
    hnpehquhgsvghsqdhoshdrohhrghdpghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfu
    ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvih
    hsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:9CJOY4HaDe7b7N0A0jNI3TuJE090tUi-F4_RDwJsUDnZUUEC4ZMqFw>
    <xmx:9CJOY0WzZVfoqLtd1tMLezcf2RCqfXiZjjcNxWEJ1wTcJz7BbqW4Gg>
    <xmx:9CJOY7Pu3y9Pv_iUc4RX-xmxM0gwJPxzLoy_uqj5I_1eFd6zKGyA6w>
    <xmx:9SJOY2JMS45VDdmqfauwWh86z8TszdDU3rezAUI8tP5zQJNKUFe5vg>
Feedback-ID: i1568416f:Fastmail
Date: Tue, 18 Oct 2022 05:52:16 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Christoph Hellwig <hch@lst.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev
Subject: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Message-ID: <Y04i8V7xamTkuqNA@mail-itl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="cFcJRBMRCFbBRw5w"
Content-Disposition: inline


--cFcJRBMRCFbBRw5w
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 18 Oct 2022 05:52:16 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Christoph Hellwig <hch@lst.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev
Subject: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"

Hi,

Since 5.19, I observe severe glitches (mostly horizontal black stripes, but
not only) when using IGD in Xen PV dom0. After not very long time Xorg
crashes, and dmesg contain messages like this:

    i915 0000:00:02.0: [drm] GPU HANG: ecode 7:1:01fffbfe, in Xorg [5337]
    i915 0000:00:02.0: [drm] Resetting rcs0 for stopped heartbeat on rcs0
    i915 0000:00:02.0: [drm] Xorg[5337] context reset due to GPU hang

The issue can be observed on several different hardware (at least Ivy
Bridge, Tiger Lake and Kaby Lake). It doesn't always happen immediately,
sometimes I need to start several VMs first.
Example how it looks like:
https://openqa.qubes-os.org/tests/48187#step/qui_widgets_notifications/8

More screenshots and logs are linked at https://github.com/QubesOS/qubes-is=
sues/issues/7813

I managed to git bisect the issue and ended up with this as the first
bad commit:

    commit a2daa27c0c6137481226aee5b3136e453c642929
    Author: Christoph Hellwig <hch@lst.de>
    Date:   Mon Feb 14 11:44:42 2022 +0100

        swiotlb: simplify swiotlb_max_segment
       =20
        Remove the bogus Xen override that was usually larger than the actu=
al
        size and just calculate the value on demand.  Note that
        swiotlb_max_segment still doesn't make sense as an interface and sh=
ould
        eventually be removed.
       =20
        Signed-off-by: Christoph Hellwig <hch@lst.de>
        Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
        Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
        Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

I tried reverting just this commit on top of 6.0.x, but the context
changed significantly in subsequent commits, so after trying reverting
it together with 3 or 4 more commits I gave up.

What may be an important detail, the system heavily uses cross-VM shared
memory (gntdev) to map window contents from VMs. This is Qubes OS, and
it uses Xen 4.14.


--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--cFcJRBMRCFbBRw5w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNOIvEACgkQ24/THMrX
1yycxQf+MDrI5t+yoFuj1FC3BntpCUVQRQlOwZpAQuuDMEZp7i0SQgELI+rr7AxM
7hENZvEWiRVfcul01QkAIqJHtuNtRCjdIZre5ISRBsqgw8KHyD7SWxGcs9hsXOcU
Z5r1dIX8FqROun1vYIhRVBOtIHIA1jXnHEttenNu2KnMEXstGU03X+Xri99PJPH/
JaYf+re4ziOqYqWE6SkQlmo2iDVOIbbg9huOJTFjRBf4VCVQM3jMIh87i52V+U9W
vhxvGK8cYRRo4DWQOdgNRMCqKG9w0xn2uB06E2KXqwenNv++EhWEQNCeR13otXY5
Hh6jT1pbY3q76EOTjIYfvL5Pi0MXvA==
=3u4/
-----END PGP SIGNATURE-----

--cFcJRBMRCFbBRw5w--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 04:12:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 04:12:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424727.672365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okdyH-0008Oj-E9; Tue, 18 Oct 2022 04:12:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424727.672365; Tue, 18 Oct 2022 04:12:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okdyH-0008Oc-BD; Tue, 18 Oct 2022 04:12:53 +0000
Received: by outflank-mailman (input) for mailman id 424727;
 Tue, 18 Oct 2022 04:12:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okdyG-0008OS-7V; Tue, 18 Oct 2022 04:12:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okdyG-00075k-4d; Tue, 18 Oct 2022 04:12:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okdyF-0006QD-I3; Tue, 18 Oct 2022 04:12:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okdyF-0007Qi-HY; Tue, 18 Oct 2022 04:12:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fx836/f3Ulu/3e2UumsvEdCwFXZO0+EQ/OQOpKSwNVU=; b=cC13VqYxanMJczLqKpdP46KEb3
	hmtP2G67VsUAAbtolEyKD/BW9t9j5mZxac3W8m8SM0zuxOHu4rKrJEvWasG+Q/dG2jDTv4T+5vbZV
	QDVBhg0sOsLEb9RY8m5CFqyJO+U2+RbPH6A2SN7nNDu2VZhw794VxqvNw9Px5bcixd7E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173975-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 173975: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:build-arm64-xsm:xen-build:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9abf2313adc1ca1b6180c508c25f22f9395cc780
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 04:12:51 +0000

flight 173975 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173975/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 build-arm64-xsm               6 xen-build                fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                9abf2313adc1ca1b6180c508c25f22f9395cc780
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   10 days
Failing since        173470  2022-10-08 06:21:34 Z    9 days   18 attempts
Testing same since   173975  2022-10-17 02:56:23 Z    1 days    1 attempts

------------------------------------------------------------
1276 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 120271 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 06:39:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 06:39:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424739.672388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okgG0-0006dh-Tt; Tue, 18 Oct 2022 06:39:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424739.672388; Tue, 18 Oct 2022 06:39:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okgG0-0006da-R6; Tue, 18 Oct 2022 06:39:20 +0000
Received: by outflank-mailman (input) for mailman id 424739;
 Tue, 18 Oct 2022 06:35:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ejmv=2T=gmail.com=xxc3ncoredxx@srs-se1.protection.inumbo.net>)
 id 1okgCZ-0006Zs-0b
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 06:35:47 +0000
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
 [2a00:1450:4864:20::435])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17083692-4eaf-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 08:35:44 +0200 (CEST)
Received: by mail-wr1-x435.google.com with SMTP id a3so21937262wrt.0
 for <xen-devel@lists.xenproject.org>; Mon, 17 Oct 2022 23:35:43 -0700 (PDT)
Received: from dj3ntoo (171.sub-72-110-15.myvzw.com. [72.110.15.171])
 by smtp.gmail.com with ESMTPSA id
 g8-20020a7bc4c8000000b003c0d504a92csm16848483wmk.22.2022.10.17.23.35.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 17 Oct 2022 23:35:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17083692-4eaf-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
         :subject:date:message-id:reply-to;
        bh=2A9S3CXOTCwdn+lDuQPpMAFg52KVpluL8upUmekQkfE=;
        b=JyMsQR3qIyUWFoQba2C/2+utgcVKN46fWVFxbFVVzSfxcKa2TGDomP3fI0JCcSVpJs
         9+SsVv/xbvTqnO5FCZJGGovhFsWNgeoe22zf108esG0Q5LyLPB1OOWVelV5WKpIMFPcT
         wg01TCcX+GOzUNQYgxtihyLZ+b8JFsAqyE8sGk/JPFipBv3UOt/gpfEV0i6WrgHmoA2b
         WnqwZsTpogUPTN7pj9pnfuK42rOsj8+zJTyEJp8OyN8u1s/Mjp68H44koyiNH9MgA/J/
         WSBUclB9VYsvIWqlTdU1YJNkpWzvsPG/fFu8nzjPCm2g0X+0eC5COXAkMcGcSU9mIlDX
         wWxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=2A9S3CXOTCwdn+lDuQPpMAFg52KVpluL8upUmekQkfE=;
        b=LEq57bJhw7XVKLSztPtN9jhBJdP+7sVFECX8z+6zwIWK2++G8D9TABpCeLZb6R1sXx
         DzcRxjBJ/9L2PallFQfOhVTaJfc8qO52qS0QTP8zAYJpq7kPHY3Jp4/nfu9jDQv1MApn
         iBzn7mdmfinJ7Ynf2yuakjklippD36MTMi57EnEegMRmI++JNwHFH8pDaoVDRG/Mysax
         oAgbiaULKaN6LFYz3fWKa/XpDAUW52c2suiiqAcY0xhctHOipiwnQrpH/65DnB6cRiKE
         IWAaS2HPm3Gf+0za29gtlg51TKFjgO5X8EttcdqrknMY+ew6FzPcRNPoVFK43BjC6JSK
         hU3Q==
X-Gm-Message-State: ACrzQf2e5jXvlB0hsq42IpI8xJJlqvVxbywibRTNxUAqmXnT7SIbIjPu
	FNeZ66uds9A+dj/OFwvA0/8=
X-Google-Smtp-Source: AMsMyM4ODs2Al3Bsn4YO641bipvzPdIt/3s/ruCqKG9waOoeXw09qbFzKhhVAQCLRUch6UatcLiWsQ==
X-Received: by 2002:a05:6000:1541:b0:231:115e:9bb8 with SMTP id 1-20020a056000154100b00231115e9bb8mr852082wry.51.1666074942570;
        Mon, 17 Oct 2022 23:35:42 -0700 (PDT)
Date: Tue, 18 Oct 2022 01:35:35 -0500
From: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>, mathieu.desnoyers@efficios.com,
	rharwood@redhat.com, samuel.thibault@ens-lyon.org,
	debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org,
	Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <Y05JN1zyh/++s5RA@dj3ntoo>
Mail-Followup-To: grub-devel@gnu.org,
	Daniel Kiper <daniel.kiper@oracle.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org, Denton Liu <liu.denton@gmail.com>
References: <20221017103532.845293-1-liu.denton@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="hXVz/a4Innggs2yF"
Content-Disposition: inline
In-Reply-To: <20221017103532.845293-1-liu.denton@gmail.com>


--hXVz/a4Innggs2yF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 17, 2022 at 03:35:32 -0700, Denton Liu wrote:
> A user may wish to use an image that is not sorted as the "latest"
> version as the top-level entry. For example, in Arch Linux, if a user
> has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts`
> gets sorted as the "latest" compared to `/boot/vmlinuz-linux`. However,
> a user may wish to use the regular kernel as the default with the LTS
> only existing as a backup.
>=20
> Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
> GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
> top-level entry.
>=20
> Create grub_move_to_front() as a helper function which moves entries to
> the front of a list. This function does the heavy lifting of moving
> the menu entry to the front in each script.
>=20
> In 10_netbsd, since there isn't an explicit list variable, extract the
> items that are being iterated through into a list so that we can
> optionally apply grub_move_to_front() to the list before the loop.
>=20
> Signed-off-by: Denton Liu <liu.denton@gmail.com>

Reviewed-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>

I've tested it on Linux, but the other platforms and os-prober are still
untested.

- Oskari

--hXVz/a4Innggs2yF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCY05JMQAKCRCp8he9GGIf
EQ0WAP0ZQxLfKP72sWT44WYI+U+sA+CLj0HtNgBM7y1Re5wnBwD8DVQv8NcQ8mkW
qUNttUu8qfwYls2ccVNpvEHPvu9jGQE=
=gtWi
-----END PGP SIGNATURE-----

--hXVz/a4Innggs2yF--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 06:42:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 06:42:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424746.672399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okgIu-00080q-CN; Tue, 18 Oct 2022 06:42:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424746.672399; Tue, 18 Oct 2022 06:42:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okgIu-00080j-8t; Tue, 18 Oct 2022 06:42:20 +0000
Received: by outflank-mailman (input) for mailman id 424746;
 Tue, 18 Oct 2022 06:42:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okgIt-00080V-16; Tue, 18 Oct 2022 06:42:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okgIs-00024f-UC; Tue, 18 Oct 2022 06:42:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okgIs-0006HD-MC; Tue, 18 Oct 2022 06:42:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okgIs-0008Ld-Ll; Tue, 18 Oct 2022 06:42:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o3ZI4Qr7nY1H/Nyc6p32UlMcAweMqNz99g0jzGChsUk=; b=ow3ouXsDCLaNjYwEGwxjBXpEwV
	vX+VKRQwgNF1PQk4r3bdNPv/dLOndljxpCZrfAGyh3PWOmeT46xs9LG+EQtzqccfG6DUSgi/DS6eF
	Kdyfb5s/wTsb1flVk+yBWi0URt6uhF6pXNl5QtzQcQVPSaXkvNjOoTtwFavx8ti9byrY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174033-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174033: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 06:42:18 +0000

flight 174033 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174033/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174001

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174001 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174001 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   43 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 07:08:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 07:08:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424756.672416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okgiK-0002Px-GW; Tue, 18 Oct 2022 07:08:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424756.672416; Tue, 18 Oct 2022 07:08:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okgiK-0002Pq-D4; Tue, 18 Oct 2022 07:08:36 +0000
Received: by outflank-mailman (input) for mailman id 424756;
 Tue, 18 Oct 2022 07:08:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okgiJ-0002Pk-PB
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 07:08:35 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2089.outbound.protection.outlook.com [40.107.21.89])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ad903020-4eb3-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 09:08:34 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB7591.eurprd04.prod.outlook.com (2603:10a6:20b:297::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct
 2022 07:08:32 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 07:08:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad903020-4eb3-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eJDyt0PH+VsV8bFrmx0JrNdrFKX+vOIUxeEZsNlQ8d6U9s8PM0sux2QFuYgvcmTuS5FJ4NST0SOoSCmbV9eLLDZiLeRS1XNTjIaIOQut4vXnXUrD8S8pmS/sy+DuYwbtNKjw+Gguq1Qa43EOIq6Z2/pBopSAK/6nHvKO80iDd088WkGTEJW89wJquV/mBG65mg6A+fLAMLOMJB6MRH4JyBOhCiJefQINZCuXItbTtyLOhICe49epRSGJnkzEvLcLXBEX9n8NuP5d5Zki6qUZ41a9k1e1wpthVW4Vak/2e8QQm48jZsgWtDnS7er3G6DbPR/+bwrnUf7d5a87Ud29lQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=avymgcjJ6uBY8Le7K1Sv9JaeDNUpZldvNkHynNp/vEo=;
 b=TS+baY4iWVWkMwwMHHs+/tsTX0KMmlpUB0s6aE5B8qFUYrrAyhwxsAXPkPpcl+FpVBok6buLmXzBhRE0v+vGIUNFMmJNAnDOVzwOPZxe1Hy/OdFlpkTzJQqQa68C6m1Sf/OL0bHDTXmzoY6NdadUNKRqDYxmf7tA13bWIGW7Uf7If4qfBYWlrLkee0UQqSHoXcjIdo6hoel+uomFbGwV/00y92b7PB92sTaf1yp0SOX/yPjbAlGoyzUCQom+jIU72cwzZV+r+kqOf2JXsN/H/mZwI9K2RWA1Aq8kF2ShYfjX8iKmQm1CmEG92bfSJ3H9jbK3YFKutTjH4Btg/HeyoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=avymgcjJ6uBY8Le7K1Sv9JaeDNUpZldvNkHynNp/vEo=;
 b=uCfSNNTJyS8XyxGnPteL17foCeB+dtIupawbAi9asIdTzOoUXF5C7zfqWL4LAnAcWg1gmsJADlUcQYEpGpP3aqfBGkZ0vMxR0yyTAjBWkn3Xdb2pcVBQ0T9eu3itihbVLgFSGxUgzr+SE1OH0PDR2CnyRep8EGVNNz/OB0NewLE9v1dz6uamLShv/E0tJLKzR5ewVyvr12WaBGHElhspBq3vK+oInq2RHkl6BhsfiFxeVYr9u23rqz5ursWGYvl0HKAL++2WiCdPE4LIUKnrzLWPJ/VIZR22RhHiMZ66dN3HuIxgpF0frs7aGRumGMwlKXtLWEGgDI9/3yZ0pTCLmA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81c0a4a9-c10a-2020-d26a-0a82d8a3131c@suse.com>
Date: Tue, 18 Oct 2022 09:08:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221017191237.11079-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0048.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7591:EE_
X-MS-Office365-Filtering-Correlation-Id: 40d0ccb0-886c-4ba2-9ddf-08dab0d79110
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0H1ZwhdwhmtdfIKtcHeLSVReQNRFYR+6RI0hLZNV+TkRgrm8uck312Km4OEdwhNnI7uQ6Ik2LYH4PLCxKUSjCmwgsLmwZBd4X3tyqGoCG2+9gib6Fl3u82AEXOT/OWaLn2ZA68vZsXz4CDeUuHNJNNvraOlAe0kmyFPlUq99eqRWzM7kU0mpAcs9X44MMXGGuLulPIWq0T3HH6kSjF1RnTZMFuvulUpcIModLJWbjEpHW7hl96CnPeJ0XnDAsm3nj8S7JK/sggw7CG1mvajkIER0H8wOMLEq3ixRGm3bAH22Px/e10oO4xKeEpzTI/BoaVDb+/4uCk/Xkc1+gnGEv1FW4rusXNAB7hmVYnY55gZg3pnoOzFZpDJ02Y85z2woFGb+gY2ZoKZMGL1np4iqJ3H8v5Gjks0dHlThT5lePZCm2uDVGqMOvcIOSUlIUXsksOFaM4B8cvf2J2Vd2xcQhYDkRViqLuw1dxYGuCLL1Eu+vXzoyo+zXsg5/AtepaetNBxKOONBhHbrGBdq9h1qS1wxI/9NhQdhhBUb/67FeUSc52r9McL5udRS1zjNBY5CLJVBYgVFnPnUGhmZeibmf09hXhCfprlFK3xA91SYEWt8fL3Mtde+GSL0pwiDgk42KQmDGvYMeP4cUt/iRQ7Fmr5hHwUay46IVNT6gS7Z/auqbhZahUKYH9GSHOjn+egwQmBpuWYpjofcJo4UlR7De/K+5cKBpbXifCVwdgty4LHoEy/SNnBWzuahdNBr87/6kupL5UOCvXWYSnmEFMSZqaEi7y8Pazb3iHTtCGUxD5I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(396003)(376002)(136003)(39860400002)(451199015)(6486002)(6916009)(2616005)(186003)(83380400001)(41300700001)(86362001)(31696002)(38100700002)(5660300002)(2906002)(4326008)(8676002)(6512007)(478600001)(53546011)(26005)(6506007)(316002)(66556008)(66476007)(66946007)(8936002)(31686004)(36756003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b2pjWjFhcm80QWovSmZRbE5zWXFOK0lQUm1odHZOcVlWWmlRTHF3dUwxK0xK?=
 =?utf-8?B?TDY0NzRVc1UxR3pUVHNqRnphR08zY1R4bjNCQVI1WnJNU1ZLTmkvZEJsdXFU?=
 =?utf-8?B?TEo3UWZoK0hWWk5jcHVNVm1TU0pxYWVHWGZFUHJ1SzlVcFhTUU53RlVCVWsr?=
 =?utf-8?B?aHRjMmVoU29UdjFjdlVrckFNM0lsUDBadWhTdFJCVDNzT2RCelNPYWtRaW1y?=
 =?utf-8?B?aDJOOWVFSHJUYkVtQTBvNTluZ3pESU9KcHUybEZkZG9KcGVTUklUMlBaelpC?=
 =?utf-8?B?aWsrWk4xUlpHM3lnTEM5VDVLdFNrRDkvM0hhUnUweEw1MVFCSWdvMi8xZkxY?=
 =?utf-8?B?MzQ1NVlVNnR3TmVTNUJFSDRISlpIZnJOdC80L1VNR2JleDdTV1ROL2pXTit3?=
 =?utf-8?B?TmU0Tk95cS9La0dvVkpFWUxCT3VNazdjTm9nNExtN2xvMnJGY2QxamZHZGd5?=
 =?utf-8?B?ZU5JaW5CNjdZZWVWSEFxbkhlakE2RWdXeC84cWtXN0V0TURTb0JxVllEdW9j?=
 =?utf-8?B?L2VmMk1kVXRWSTNyT3psbUovMFRUMkhYM0J6Zm5PMVRnRm05SHVqbDh1QWFB?=
 =?utf-8?B?eGtUMDBFQ2E2ZlJ2bVFNWmNtaFBlNDBFS2dWb3JYbGRqMzhWZW00RU40STRP?=
 =?utf-8?B?eC9wTHpySURsMXZZYmdhUHJIVWVOZUpCL0UwM2M5UlZEbVFXNkVwbUlQRUcr?=
 =?utf-8?B?WVpwL3VyL1IxdGJLTm1Sdkg2bks5R05jTzVjRXpVY1MvOHF4b3FWb0RxOWlv?=
 =?utf-8?B?dThaYXcyOTg0d1Mvbk1tYUFHSi8ySEN2MEtnS1JGQkNQTU1xQzFsaFQ1dVQ4?=
 =?utf-8?B?b0grS3ZLcjRLY0xrUGNyMnN3Z0htV3hLemVYRUpPdlZJMHc0MXEzSy9xNS92?=
 =?utf-8?B?MWpIVkdYV3crQitndnVuNkl6Qkh4Si9HdHZLS1psZy9TK0VDeEJzY1kzVHFi?=
 =?utf-8?B?Z3NUVWd1bTN2dENCdXFaVkxsejdOR0RXL0Z2YllXbDU0TTh4V3RQaUcrUHB3?=
 =?utf-8?B?RnMvUjJYLys0cWpBNldlTTYwd1dtTG5sd2cvU3cvRG9jYkxXeTRrdVRmWTQ4?=
 =?utf-8?B?TWxqZVVzeGZzVGJCalFIMllmc0pBZmFXakt1R3I0ZW1Uc1dFUGtaNnAzLy9h?=
 =?utf-8?B?ajZjVy9ZYXFBZHZ6REJhSWRBWjNYRmFPN09kME1tSDNQbGZ1amh5L1hBSmdj?=
 =?utf-8?B?RHJoSnBpVExqaE5MMnNkd1BmN0dLRVZBcjhPQ3daVnhuUzlKRFBpVk1YdktB?=
 =?utf-8?B?Y0pwZXU3NHM1cGRCaUZqdVBXVWpSWkVNM2JvalM0WEhIcFdNMlR4cEdlMXBa?=
 =?utf-8?B?UVlueW42Ykx6K2luNGd6Tm0rSXJCRE9LOTBxOGFJQzJTNElKaVFPSnNNMlZ5?=
 =?utf-8?B?Q212cnlROGVOeUpucEtHZm9TcG9qTEhoeGtEaUltR3ZsWUw3UW52d0s2ZGlu?=
 =?utf-8?B?YmpiMGNSM3J2N1ZEZkppaHZyMklGUTV5MkdMeWh3S3dKbGJURGFOYVduOWNv?=
 =?utf-8?B?TGRralBrQnlKeTBLTXF4V0tLZWZEcnVmZll6d05hYWh5RVp3bmtWV2p2WHhI?=
 =?utf-8?B?ZzA5M0NQVDl2TC9pMDB0REozREFDR0habFgrZW5MdHExanBSb1E4RjdFTGF6?=
 =?utf-8?B?UW1UVFdCRGl1ckVBeWJjaGRIM3ZKeHBabWE0dDVIdUhFSVAzamtpRGZSNVNn?=
 =?utf-8?B?SGgzSm44bWN4blZ5VUVGN21MblRuVkZmTUtwOHBDWVRhKyt0WmQ4YzRaZ3dQ?=
 =?utf-8?B?TnRITzJtWWRQVnVvbFBETkoyb2dLZnF4UTFZWG0ra2VMbldPVmFhOGV0OWx1?=
 =?utf-8?B?RitRMkJLOUQzNDVveFBYVFZEYng4UzRkNDU0MDZtak5rVFNkTitRUDJPazdO?=
 =?utf-8?B?YTRDRDVnOUpJM2RiNnNtaEhlU2lVa00zeTlSaklLOUtURlpoczI5VHZNSEpD?=
 =?utf-8?B?TzcrWVdjb0RHR0FjK3pLSEFvQ0ZGQTJ3KzdaSi9ETE96TSsreUFGeFZiOUpG?=
 =?utf-8?B?U255aWJRWUpyaXBxVXltWkpBR3FldTFyY3BWaGJ0amt1eVN1L3FqcE9kbzJD?=
 =?utf-8?B?ZE56NC9lWGhmS3RoZUxuOVBaU01qeDQyOXVRTFJLNEw2c0RLUWxnNVMzZXp3?=
 =?utf-8?Q?4nIK9XFwTaSYHXFFM7v5TY3us?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40d0ccb0-886c-4ba2-9ddf-08dab0d79110
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 07:08:32.6307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: py/pook70MfN81lxApZVFX6UOY9HmO06PNbisCQPhE6kDpjLENYomR95ew/mps8hjIpR9Rk/3FoDEFw9JNdV7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7591

On 17.10.2022 21:12, Andrew Cooper wrote:
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1736,8 +1736,36 @@ void p2m_final_teardown(struct domain *d)
>      if ( !p2m->domain )
>          return;
>  
> -    ASSERT(page_list_empty(&p2m->pages));
> -    ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
> +    /*
> +     * On the domain_create() error path only, we can end up here with a
> +     * non-zero P2M pool.
> +     *
> +     * At present, this is a maximum of 16 pages, spread between p2m->pages
> +     * and the free list.  The domain has never been scheduled (it has no
> +     * vcpus), so there is TLB maintenance to perform; just free everything.
> +     */
> +    if ( !page_list_empty(&p2m->pages) ||
> +         !page_list_empty(&d->arch.paging.p2m_freelist) )
> +    {
> +        struct page_info *pg;
> +
> +        /*
> +         * There's no sensible "in the domain_create() error path" predicate,
> +         * so simply sanity check that we don't have unexpected work to do.
> +         */
> +        ASSERT(d->arch.paging.p2m_total_pages <= 16);

I guess this isn't sufficient as a sanity check, as the count (contrary
to the name of the field) is only representing all pages on p2m_freelist.

Jan

> +        spin_lock(&d->arch.paging.lock);
> +
> +        while ( (pg = page_list_remove_head(&p2m->pages)) )
> +            free_domheap_page(pg);
> +        while ( (pg = page_list_remove_head(&d->arch.paging.p2m_freelist)) )
> +            free_domheap_page(pg);
> +
> +        d->arch.paging.p2m_total_pages = 0;
> +
> +        spin_unlock(&d->arch.paging.lock);
> +    }
>  
>      if ( p2m->root )
>          free_domheap_pages(p2m->root, P2M_ROOT_ORDER);



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 08:14:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 08:14:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424771.672445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhjo-0001xH-UM; Tue, 18 Oct 2022 08:14:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424771.672445; Tue, 18 Oct 2022 08:14:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhjo-0001xA-Rd; Tue, 18 Oct 2022 08:14:12 +0000
Received: by outflank-mailman (input) for mailman id 424771;
 Tue, 18 Oct 2022 08:14:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RnJu=2T=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okhjn-0001x4-B5
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 08:14:11 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140042.outbound.protection.outlook.com [40.107.14.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d71406be-4ebc-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 10:14:09 +0200 (CEST)
Received: from DB6PR0402CA0013.eurprd04.prod.outlook.com (2603:10a6:4:91::23)
 by DU0PR08MB9204.eurprd08.prod.outlook.com (2603:10a6:10:418::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct
 2022 08:14:07 +0000
Received: from DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:91:cafe::91) by DB6PR0402CA0013.outlook.office365.com
 (2603:10a6:4:91::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Tue, 18 Oct 2022 08:14:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT003.mail.protection.outlook.com (100.127.142.89) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Tue, 18 Oct 2022 08:14:06 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Tue, 18 Oct 2022 08:14:06 +0000
Received: from 7dbef5e3c54f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0DDC3585-96B1-4EEA-8E50-B4213E02837A.1; 
 Tue, 18 Oct 2022 08:13:59 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7dbef5e3c54f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 08:13:59 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by GV2PR08MB8270.eurprd08.prod.outlook.com (2603:10a6:150:c1::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 08:13:57 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 08:13:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d71406be-4ebc-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Qrt77yaKtojvjMmOB1oT9TQw/l3vG8UTWEJvlpLPb5RsDLacimCne/+H8leg8xKo0xSjccHPX3ZiZUXl+ZK29fU0nBAld6Q2VxFt8G8KEl/OI+6ONE20EW3f690+26qycTMkfup2bwX3xdT1bcGoi5XltwcBvfCFBK+fm6ha5qeUITDDtk3cxWO3ExgjFCFzlzqcn0d6L+X+9esANIOxa9GNr5TYL4BzZt7DnGSprAqmDsBFJDfN31ZS0CZTYDJN2Lq4wgWNXNZWEz/WksPZQ5HEhtzMRq0kUtD8updjIS+2DvPvdQUzdWzMWK558q05hAnb7vXu/1j+MYecJPt9tQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=foh0/NlodilCKf9ZTJs38GGwrVWCeYoIbT1SNFQNe2w=;
 b=VUG1SMpxXe5Fjg4OnYLWeG7pfxLx76ZowdwmN7U4tru5EUAZk/bMu4q/0v3AhOpm8tk8xksgvYQF3p/rbBolQDjgTjvcIC9mCXP8qI0pzbHQ5Be9ZhmXxM89yznGUI92uOG+5mvTf6+v7Gmls1ZRQ8KTWelnPApArnzr6RduDENnVR4aWU13jp5Ht8B3Mef2sLS+sn+kR2G+qW+pO82ihVapJoA1ZuaXDlvG5BpOcna9xoIw98bazTuTCTMuJAPPkDwXl48qsSc4F7RuSKcxTi4JCCb0OY1yGVCh8qQ6NYOiIjZJEZ0rnKdP+1PPA9c5722zBVG+hFdqbf1mMuyoYg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=foh0/NlodilCKf9ZTJs38GGwrVWCeYoIbT1SNFQNe2w=;
 b=7hWSKsiPkjZxjP/vF1YbOWA2TKc+UWAjHCfj2LSsip4JcDE67ogiusPISv4sMD0SalotrPLigB9T+0hFYm90/9hLyotcBdEFWnS+p2hTZ5uw+I/QERKUbMTbJQc4EnX5HDqymsTOCxOGLUQhpJ3tImIA30pRF8JOiGdcTgLnLOc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5a8e7c8a0e75cfbd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nNw4LVSI6hNFpV8Rt7grgMKJowQdff2VugKAO+aqlqma32wMpEYseL6hH9h8WQQIKtSHBF3AUr9dg/gNWWFYNwANyDgLSak2acpFENYw4rHEEByIeITdOoK+F2eAWB+i0C0Uc01m1CBrCZKn/W9A+Ca8VACNDIvUE/6wRkRCuYpwfvOkBTLTUzFdVxmo6C7n6EvphJYxRiDx5xSeG+rIz7i5o3HpTl2UYo59P8AngbyWnSN2E7sQJi5kjhkmEXI8Y9k0Sy9iOo5PjvIK2magRll0OC4jtLu2eYmB9vjS9R3pMqt4fVmFvvXh6IKPdhli0XeDOdhrSMs3Qn2kLhgWUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=foh0/NlodilCKf9ZTJs38GGwrVWCeYoIbT1SNFQNe2w=;
 b=G+yJrmofyuIiR421v+vrCZoMXl/D6lh3/zJ5g/itN/8JVMN5EKBkJEoTkTLE7Giu19hz3zuCPmfmnTigNRLII7BYJDbWSn24nfSYGiYr0ic9C2a9LnNJnK5+iIyWjfzc4tNpfQPyTGuwXpvJtEE7oJGEyEXCrGoulCjQsmuxtEk+SXpP0cFVnNEZglwI6pv52PfzXlk86q5ihDHpDtHH7rDN7W3IY0DKeYgf3HiHyL4H5rceuAsoJbK9XXXeDQKVBtNs/A4uHvfwU6JxVz9ej/wsAQqbwj/i/6yVHRgaAmTpMqL21cg+bhvjnjO1S+qHNTCZmXWD6snqa++DxsYvog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=foh0/NlodilCKf9ZTJs38GGwrVWCeYoIbT1SNFQNe2w=;
 b=7hWSKsiPkjZxjP/vF1YbOWA2TKc+UWAjHCfj2LSsip4JcDE67ogiusPISv4sMD0SalotrPLigB9T+0hFYm90/9hLyotcBdEFWnS+p2hTZ5uw+I/QERKUbMTbJQc4EnX5HDqymsTOCxOGLUQhpJ3tImIA30pRF8JOiGdcTgLnLOc=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Peter Hoyes <Peter.Hoyes@arm.com>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Diego Sueiro
	<Diego.Sueiro@arm.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Thread-Topic: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Thread-Index: AQHY1zZSy8ha9+hxm0C1gDMvI07yO64T5LUA
Date: Tue, 18 Oct 2022 08:13:57 +0000
Message-ID: <E63CD72F-9C98-4EB2-840C-56C46BFD7BA1@arm.com>
References: <20221003144216.2297632-1-peter.hoyes@arm.com>
In-Reply-To: <20221003144216.2297632-1-peter.hoyes@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|GV2PR08MB8270:EE_|DBAEUR03FT003:EE_|DU0PR08MB9204:EE_
X-MS-Office365-Filtering-Correlation-Id: 8f10aa83-20ad-4a3c-b150-08dab0e0ba0c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8hTJHIykIIWKSSpetfaXdPJ5IwRNQpgmZqQmfJDC0TMwl73K86sNONTBIMOxg88/6I6neRFSNI0j2WN/pvjmiIpbXaMUsHQM837OC6DtgVKAEfxPkJQ/iUUWYjZ+4azLSNf+LWkhw2QfXCQQStHtCAZQEumdffVc84S1JId8oq/vqqvWsrV2F9bfQZ2ubsewIQxeEBAWi5sqUN2jrDpo+9wfhlBMxyC0/sn+qYYTcPEIEYFXYgHbcIwL0DW6tHN1YFD+vXlJUbol6O+rAwJTB7ZfYFvLbiY6+6+gH7aD7hTpjiIVbkU0MGHzFM0s5RbUDHpbj3c2h714oocsEM+mZuRtl4Ii6C1IMnVcCZFbY7AMeeswypkJoUEFAu2wVWqhAUyK5ZhmQN2loyo3OSIr3Ze6SwRrfnLdumwrzamwzOEc5xjmfgxAqst+B+fMkr0lLqdwZbiNVqW9SoliMwM3mhagVuR5GU1QauQuQZMzWpuYgZSkkrm13sN2tSvKp/YSWTRWYqAKITTTcbZnnAfPmQgU6pTZTF/WKqm9BnGPmRnYbq9tXH5UUOYXQiNBFqCnpcu6WBz4tgMzeyQcYznkcreED70aKvMA5ajcRnLguaSPC01wChb88GvsEOqropq3hYdEqAt3i/HB/4sTsPtzbJhTpkduUOp6WJAAWnIyvqshpLR1tAEv2yfhd8r33qTxgQRrAZ8+R3JR152h5Y8WUQWX9qJ3dafIyVqK9sOYMskJPnezYiMgYt4TQY4wMUAUuqyXdwBc/bi+W1QKp89FThWWnr9cO9pYQIkjHo2trUE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(366004)(39860400002)(346002)(451199015)(186003)(2616005)(6512007)(6506007)(83380400001)(26005)(2906002)(53546011)(5660300002)(6862004)(54906003)(37006003)(8936002)(6636002)(66476007)(478600001)(6486002)(64756008)(41300700001)(66446008)(71200400001)(8676002)(4326008)(91956017)(66556008)(66946007)(76116006)(316002)(36756003)(86362001)(33656002)(38100700002)(122000001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DB9197A14062184EB950CA7A5D7794FA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8270
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4d34dc48-8634-4be7-5844-08dab0e0b45e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gB2kRfk09XooO5Jxir7jMvpyWtd5QBFuIdUE0bXmDxmm6y/D048Mq0JhmKdb8zcDaHYjKOYXs0+rvpkuFFvHWti5YGVYOg//ONspfVVcSjRuysYrOvhxEvLv4a+Rx+ssuwSW0y4elymdSKIJozkMr0o/qNMGJ6GSmAZPpVklWoWNRfr0WGDeMYmgTslwNg7SyIrHsHaaIYUboQx5tOXHMkDsxPkOtyN3KyUoTTnCGVMkEwCSLrtFoNq01HAG+fNTsHW7gRA4q5s5k/Pa3YBHwatQTxtv/Q/D4ollrExZfjeZN3zCwaKiGbzXzVTkkk6ctr/Ctxf8cqyju1SpMIATN/Wl2pfUZ9omeV/Ij7TWUlzkR2Cyf+erC1edcBcBs/+HzkP+aW4wwIna6yr/5OTX3/P25JZptRStE25F5j+8sh+47dF7+BhDQ4nuL5WBp5m6ud8D+ubMgucfTPOZstOFQMCAgG7vFk5SksEMnZhKxjEjXJpBH6l0npXixZ3Cpb/mL3aWD8TU4o9JuUXQrUI3cT2lRujefJCJjIyusP6F1IaW4cCbc+G0FAF6PbWAoC4HIW9YFnLozl5B+dbXgAnf/mi7YS8Tkbvcq3JZqisD6JgzavTZS6nTK1inVQGU9tkaqsaO3AeWmuibnpg6a6TK1tgZnOjMShiRFhMQ3tOUd+jv3GXYez1Qventar6PihNseYlpIUaz0xsZyIh6vlSeTMm55J6uhWt11DYGRRdx3OI037QQnf7i0l7qCM43u/uN3xSAffbdE68shaC6U4v4lA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(6862004)(5660300002)(8936002)(83380400001)(41300700001)(4326008)(70586007)(8676002)(2906002)(70206006)(86362001)(82740400003)(36756003)(356005)(81166007)(33656002)(40460700003)(2616005)(186003)(47076005)(6506007)(478600001)(26005)(6512007)(6486002)(316002)(36860700001)(54906003)(6636002)(82310400005)(53546011)(336012)(40480700001)(37006003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 08:14:06.6903
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f10aa83-20ad-4a3c-b150-08dab0e0ba0c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9204

Hi,

Gentil ping on this one as it might be a suitable one for 4.17

Cheers
Bertrand

> On 3 Oct 2022, at 15:42, Peter Hoyes <Peter.Hoyes@arm.com> wrote:
>=20
> From: Peter Hoyes <Peter.Hoyes@arm.com>
>=20
> The xendomains script uses the output of `xl list -l` to collect the
> id and name of each domain, which is used in the shutdown logic, amongst
> other purposes.
>=20
> The linked commit added a "domid" field to libxl_domain_create_info.
> This causes the output of `xl list -l` to contain two "domid"s per
> domain, which may not be equal. This in turn causes `xendomains stop` to
> issue two shutdown commands per domain, one of which is to a duplicate
> and/or invalid domid.
>=20
> To work around this, make the LIST_GREP pattern more restrictive for
> domid, so it only detects the domid at the top level and not the domid
> inside c_info.
>=20
> Fixes: 4a3a25678d92 ("libxl: allow creation of domains with a specified
> or random domid")
> Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
> ---
> tools/hotplug/Linux/xendomains.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/hotplug/Linux/xendomains.in b/tools/hotplug/Linux/xend=
omains.in
> index 334d244882..70f4129ef4 100644
> --- a/tools/hotplug/Linux/xendomains.in
> +++ b/tools/hotplug/Linux/xendomains.in
> @@ -211,7 +211,7 @@ get_xsdomid()
>     fi
> }
>=20
> -LIST_GREP=3D'(domain\|(domid\|(name\|^    {$\|"name":\|"domid":'
> +LIST_GREP=3D'(domain\|(domid\|(name\|^    {$\|"name":\|^        "domid":=
'
> parseln()
> {
>     if [[ "$1" =3D~ '(domain' ]] || [[ "$1" =3D "{" ]]; then
> --=20
> 2.25.1
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 08:17:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 08:17:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424776.672456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhmq-0002bb-FD; Tue, 18 Oct 2022 08:17:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424776.672456; Tue, 18 Oct 2022 08:17:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhmq-0002bU-B0; Tue, 18 Oct 2022 08:17:20 +0000
Received: by outflank-mailman (input) for mailman id 424776;
 Tue, 18 Oct 2022 08:17:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3X7+=2T=gmail.com=vsuneja63@srs-se1.protection.inumbo.net>)
 id 1okhmp-0002bO-8z
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 08:17:19 +0000
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com
 [2a00:1450:4864:20::52b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46c39cba-4ebd-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 10:17:16 +0200 (CEST)
Received: by mail-ed1-x52b.google.com with SMTP id m15so19308677edb.13
 for <xen-devel@lists.xenproject.org>; Tue, 18 Oct 2022 01:17:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46c39cba-4ebd-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=90ZjSDua2qyjWgYFEzx8rCopKaliM8vxbKPF7kybeyE=;
        b=KGkjnD/K9NHiN3yUUkHgYLWxVwp4zNAjMnLAsgATjM1sdEE2uwxDa1GZk32qITvTta
         fdDRhxgi5/bPwl54+/PMPPt8dYA+384fCtpZKFyin+en4F8OHIpP+JzWqmswq9+l1Ih/
         DjfFH+cRG4bXkBaUwqhY0vq4lCxitQq4T09lJFoICRFu5i81Cdtvjnja+57fzZnTkkjO
         FR+pLPG6EZW5bwaCO5oNaXYON2O1Eyyt8qRKAAK8n0RY0twwU+agkhKwKEHycApFquQ+
         NlI1PYP86HCfAX+OAeffA3G/u3+plAV1DRW7jG47OgPOF2gv0rbDAG8qe+VdK/g6tW4A
         nSmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=90ZjSDua2qyjWgYFEzx8rCopKaliM8vxbKPF7kybeyE=;
        b=hWSkVXHDsK6Hx6Nu3XlqhdArHAld9jqmw5Se5DutCWg+jgQpnTVXanAqmlVhTtWMZJ
         Crqm810juswMcftLdUv/wX7zuLb882qXOrFACGy4uwV93XsSemzR1rLUCNAWCdG8/zSD
         MbwouODgnh9Xc5M7PzudidYy+0aPY5LmSxRsgnDb3Dv2hqlyvrsgD7YhyDMeeW9m4RyM
         ecVhgpbgWVv3NDlAPxnPUn4evU3xFccbkwsr8pnVfRxqnu9vHDBX6/gMcCOKwWJeQdLR
         IFyOmxN5ZuSsbdsEbbYQVlVTNR03nh8TB9Kbc7OvP6kHjNj6MHOhYOEPylJH7erH3OSm
         IY7w==
X-Gm-Message-State: ACrzQf0Mz9hYmZ5fI/1IgX2gxTBC/rAUTaDEQoOhlUKqTY6pJu8KwPAT
	PD7pawNiHtVQUfHuphKVmQ1TDCEIO9vVcqN7GyY=
X-Google-Smtp-Source: AMsMyM4Q2IlJX83NI4qcSb8utiEe2wutDuWukjsMEJgBg38ZtuApqetM/Q3NPjjMQtm/Swmc3ZFjVX4D4up8ggdAsTA=
X-Received: by 2002:a05:6402:ca:b0:45c:dbdd:8143 with SMTP id
 i10-20020a05640200ca00b0045cdbdd8143mr1528014edu.213.1666081037558; Tue, 18
 Oct 2022 01:17:17 -0700 (PDT)
MIME-Version: 1.0
References: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop>
From: Vipul Suneja <vsuneja63@gmail.com>
Date: Tue, 18 Oct 2022 13:47:05 +0530
Message-ID: <CALAP8f81ojfVD9n5EMtD7DxY-8uomgENVEQH9Afz7Hk9rfaAsw@mail.gmail.com>
Subject: Re: Porting Xen in raspberry pi4B
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, 
	oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com
Content-Type: multipart/alternative; boundary="00000000000069287305eb4ab819"

--00000000000069287305eb4ab819
Content-Type: text/plain; charset="UTF-8"

Hi Stefano,

Thanks for the response!

I could install tigerVNC, x11vnc & libvncserver in Dom0 xen-image-minimal
but only manage to install libvncserver(couldn't install tigervnc & x11vnc
because of x11
support missing, it's wayland) in DOMU custom graphical image. I tried
running vncviewer with IP address & port in dom0 to access the domu
graphical image display as per below commands.

* vncviewer 192.168.1.42:5901 <http://192.168.1.42:5901>*

 But it showing can't open display, below are the logs:








*root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901
<http://192.168.1.42:5901>TigerVNC Viewer 64-bit v1.11.0Built on:
2020-09-08 12:16Copyright (C) 1999-2020 TigerVNC Team and many others (see
README.rst)See https://www.tigervnc.org <https://www.tigervnc.org> for
information on TigerVNC.Can't open display: root@raspberrypi4-64:~/guest1#*

I am not exactly sure what the issue is but I thought only libvncserver in
DOMU could work to get access but it did not work.
If TigerVNC is the issue here then is there any other VNC source which
could be installed for both x11 & wayland supported images?

Regards,
Vipul Kumar

On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini <sstabellini@kernel.org>
wrote:

> VNC is typically easier to setup, because SDL needs extra libraries at
> build time and runtime. If QEMU is built without SDL support it won't
> start when you ask for SDL.
>
> VNC should work with both x11 and wayland in your domU. It doesn't work
> at the x11 level, it exposes a special fbdev device in your domU that
> should work with:
> - a graphical console in Linux domU
> - x11
> - wayland (but I haven't tested this so I am not 100% sure about it)
>
> When you say "it doesn't work", what do you mean? Do you get a black
> window?
>
> You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
> (drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text
> console up and running in your domU before attempting x11/wayland.
>
> Cheers,
>
> Stefano
>
> On Mon, 17 Oct 2022, Vipul Suneja wrote:
> > Hi,
> > Thanks!
> >
> > I have ported xen minimal image as DOM0 & custom wayland GUI based image
> as DOMU in raspberry pi4B. I am trying to make GUI display up
> > for guest machine. I tried using sdl, included below line in guest.conf
> file
> > vfb= [ 'sdl=1' ]
> >
> > But it is throwing below error:
> >
> > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
> > Parsing config from guest1.cfg
> > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP
> socket: Connection reset by peer
> > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error
> happened with the QMP connection to QEMU
> > libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain
> 3:Post DM startup configs failed, rc=-26
> > libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain
> 3:device model did not start: -26
> > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model
> already exited
> > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain
> 3:Non-existant domain
> > libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain
> 3:Unable to destroy guest
> > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain
> 3:Destruction of domain failed
> >
> > Another way is VNC, i could install tigervnc in DOM0 but same i couldn't
> in guest machine because it doesn't support x11(supports wayland
> > only). I am completely blocked here, Need your support to enable the
> display up.
> > Any alternative of VNC which could work in both x11 & wayland supported
> images?
> >
> > Any input on VNC, SDL or any other way to proceed on this? Looking
> forward to hearing from you.
> >
> > Regards,
> > Vipul Kumar

--00000000000069287305eb4ab819
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Stefano,<br><br>Thanks for the response!<br><br>I could=
 install tigerVNC, x11vnc &amp; libvncserver in Dom0 xen-image-minimal but =
only manage to install libvncserver(couldn&#39;t install tigervnc &amp; x11=
vnc because of x11<br>support missing, it&#39;s wayland) in DOMU custom gra=
phical image. I tried running vncviewer with IP address &amp; port in dom0 =
to access the domu graphical image display as per below commands.<br>=C2=A0=
<br><b><i>=C2=A0vncviewer <a href=3D"http://192.168.1.42:5901">192.168.1.42=
:5901</a></i></b><br>=C2=A0<br>=C2=A0But it showing can&#39;t open display,=
 below are the logs:<br>=C2=A0<br><b><i>root@raspberrypi4-64:~/guest1# vncv=
iewer <a href=3D"http://192.168.1.42:5901">192.168.1.42:5901</a><br><br>Tig=
erVNC Viewer 64-bit v1.11.0<br>Built on: 2020-09-08 12:16<br>Copyright (C) =
1999-2020 TigerVNC Team and many others (see README.rst)<br>See <a href=3D"=
https://www.tigervnc.org">https://www.tigervnc.org</a> for information on T=
igerVNC.<br>Can&#39;t open display: <br>root@raspberrypi4-64:~/guest1#</i><=
/b><br><div><b><i><br></i></b></div><div>I am not exactly=C2=A0sure what th=
e issue is but I thought only libvncserver in DOMU could work to get access=
 but it did not work.=C2=A0</div><div>If TigerVNC is the issue here then is=
 there any other VNC source which could be installed for both x11 &amp; way=
land supported images?</div><div><br></div><div>Regards,</div><div>Vipul Ku=
mar</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gma=
il_attr">On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini &lt;<a href=3D"=
mailto:sstabellini@kernel.org">sstabellini@kernel.org</a>&gt; wrote:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">VNC is typically easie=
r to setup, because SDL needs extra libraries at<br>
build time and runtime. If QEMU is built without SDL support it won&#39;t<b=
r>
start when you ask for SDL.<br>
<br>
VNC should work with both x11 and wayland in your domU. It doesn&#39;t work=
<br>
at the x11 level, it exposes a special fbdev device in your domU that<br>
should work with:<br>
- a graphical console in Linux domU<br>
- x11<br>
- wayland (but I haven&#39;t tested this so I am not 100% sure about it)<br=
>
<br>
When you say &quot;it doesn&#39;t work&quot;, what do you mean? Do you get =
a black<br>
window?<br>
<br>
You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU<br>
(drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text<br=
>
console up and running in your domU before attempting x11/wayland.<br>
<br>
Cheers,<br>
<br>
Stefano<br>
<br>
On Mon, 17 Oct 2022, Vipul Suneja wrote:<br>
&gt; Hi,<br>
&gt; Thanks!<br>
&gt; <br>
&gt; I have ported xen minimal image as DOM0 &amp; custom wayland GUI based=
 image as DOMU in raspberry pi4B. I am trying to make GUI display up<br>
&gt; for=C2=A0guest machine. I tried using=C2=A0sdl, included below line in=
 guest.conf file<br>
&gt; vfb=3D [ &#39;sdl=3D1&#39; ]<br>
&gt; <br>
&gt; But it is throwing below error:<br>
&gt; <br>
&gt; root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg<br>
&gt; Parsing config from guest1.cfg<br>
&gt; libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on Q=
MP socket: Connection reset by peer<br>
&gt; libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happ=
ened with the QMP connection to QEMU<br>
&gt; libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:P=
ost DM startup configs failed, rc=3D-26<br>
&gt; libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3=
:device model did not start: -26<br>
&gt; libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model al=
ready exited<br>
&gt; libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-e=
xistant domain<br>
&gt; libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Un=
able to destroy guest<br>
&gt; libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruct=
ion of domain failed<br>
&gt; <br>
&gt; Another way is VNC, i could install tigervnc in DOM0 but same i couldn=
&#39;t in guest machine because it doesn&#39;t support x11(supports wayland=
<br>
&gt; only). I am completely blocked here, Need your support to enable the d=
isplay up.<br>
&gt; Any alternative of VNC which could work in both x11 &amp; wayland supp=
orted images?<br>
&gt; <br>
&gt; Any input on VNC, SDL or any other way to proceed on this? Looking for=
ward to hearing from you.<br>
&gt; <br>
&gt; Regards,<br>
&gt; Vipul Kumar</blockquote></div>

--00000000000069287305eb4ab819--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 08:24:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 08:24:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424783.672473 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhtc-00044J-5f; Tue, 18 Oct 2022 08:24:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424783.672473; Tue, 18 Oct 2022 08:24:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhtc-00044C-2n; Tue, 18 Oct 2022 08:24:20 +0000
Received: by outflank-mailman (input) for mailman id 424783;
 Tue, 18 Oct 2022 08:24:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ieme=2T=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1okhta-000446-Md
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 08:24:18 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4083e01e-4ebe-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 10:24:15 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 5CDBB68C4E; Tue, 18 Oct 2022 10:24:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4083e01e-4ebe-11ed-8fd0-01056ac49cbb
Date: Tue, 18 Oct 2022 10:24:13 +0200
From: Christoph Hellwig <hch@lst.de>
To: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Message-ID: <20221018082413.GA25785@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y04i8V7xamTkuqNA@mail-itl>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Tue, Oct 18, 2022 at 05:52:16AM +0200, Marek Marczykowski-G�recki wrote:
> not only) when using IGD in Xen PV dom0. After not very long time Xorg
> crashes, and dmesg contain messages like this:
> 
>     i915 0000:00:02.0: [drm] GPU HANG: ecode 7:1:01fffbfe, in Xorg [5337]
>     i915 0000:00:02.0: [drm] Resetting rcs0 for stopped heartbeat on rcs0
>     i915 0000:00:02.0: [drm] Xorg[5337] context reset due to GPU hang

<snip>

> I tried reverting just this commit on top of 6.0.x, but the context
> changed significantly in subsequent commits, so after trying reverting
> it together with 3 or 4 more commits I gave up.
> 
> What may be an important detail, the system heavily uses cross-VM shared
> memory (gntdev) to map window contents from VMs. This is Qubes OS, and
> it uses Xen 4.14.

Can you try the patch below?

---
>From 26fe4749750f1bf843666ca777e297279994e33a Mon Sep 17 00:00:00 2001
From: Robert Beckett <bob.beckett@collabora.com>
Date: Tue, 26 Jul 2022 16:39:35 +0100
Subject: drm/i915: stop abusing swiotlb_max_segment

Calling swiotlb functions directly is nowadays considered harmful. See
https://lore.kernel.org/intel-gfx/20220711082614.GA29487@lst.de/

Replace swiotlb_max_segment() calls with dma_max_mapping_size().
In i915_gem_object_get_pages_internal() no longer consider max_segment
only if CONFIG_SWIOTLB is enabled. There can be other (iommu related)
causes of specific max segment sizes.

Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
[hch: added the Xen hack]
---
 drivers/gpu/drm/i915/gem/i915_gem_internal.c | 19 +++----------
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c    |  2 +-
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c      |  4 +--
 drivers/gpu/drm/i915/gem/i915_gem_userptr.c  |  2 +-
 drivers/gpu/drm/i915/i915_scatterlist.h      | 30 +++++++++++---------
 5 files changed, 25 insertions(+), 32 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_internal.c b/drivers/gpu/drm/i915/gem/i915_gem_internal.c
index c698f95af15fe..629acb403a2c9 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_internal.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_internal.c
@@ -6,7 +6,6 @@
 
 #include <linux/scatterlist.h>
 #include <linux/slab.h>
-#include <linux/swiotlb.h>
 
 #include "i915_drv.h"
 #include "i915_gem.h"
@@ -38,22 +37,12 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 	struct scatterlist *sg;
 	unsigned int sg_page_sizes;
 	unsigned int npages;
-	int max_order;
+	int max_order = MAX_ORDER;
+	unsigned int max_segment;
 	gfp_t gfp;
 
-	max_order = MAX_ORDER;
-#ifdef CONFIG_SWIOTLB
-	if (is_swiotlb_active(obj->base.dev->dev)) {
-		unsigned int max_segment;
-
-		max_segment = swiotlb_max_segment();
-		if (max_segment) {
-			max_segment = max_t(unsigned int, max_segment,
-					    PAGE_SIZE) >> PAGE_SHIFT;
-			max_order = min(max_order, ilog2(max_segment));
-		}
-	}
-#endif
+	max_segment = i915_sg_segment_size(i915->drm.dev) >> PAGE_SHIFT;
+	max_order = min(max_order, get_order(max_segment));
 
 	gfp = GFP_KERNEL | __GFP_HIGHMEM | __GFP_RECLAIMABLE;
 	if (IS_I965GM(i915) || IS_I965G(i915)) {
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index f42ca1179f373..11125c32dd35d 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -194,7 +194,7 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)
 	struct intel_memory_region *mem = obj->mm.region;
 	struct address_space *mapping = obj->base.filp->f_mapping;
 	const unsigned long page_count = obj->base.size / PAGE_SIZE;
-	unsigned int max_segment = i915_sg_segment_size();
+	unsigned int max_segment = i915_sg_segment_size(i915->drm.dev);
 	struct sg_table *st;
 	struct sgt_iter sgt_iter;
 	struct page *page;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index e3fc38dd5db04..de5d0a7241027 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -189,7 +189,7 @@ static int i915_ttm_tt_shmem_populate(struct ttm_device *bdev,
 	struct drm_i915_private *i915 = container_of(bdev, typeof(*i915), bdev);
 	struct intel_memory_region *mr = i915->mm.regions[INTEL_MEMORY_SYSTEM];
 	struct i915_ttm_tt *i915_tt = container_of(ttm, typeof(*i915_tt), ttm);
-	const unsigned int max_segment = i915_sg_segment_size();
+	const unsigned int max_segment = i915_sg_segment_size(i915->drm.dev);
 	const size_t size = (size_t)ttm->num_pages << PAGE_SHIFT;
 	struct file *filp = i915_tt->filp;
 	struct sgt_iter sgt_iter;
@@ -538,7 +538,7 @@ static struct i915_refct_sgt *i915_ttm_tt_get_st(struct ttm_tt *ttm)
 	ret = sg_alloc_table_from_pages_segment(st,
 			ttm->pages, ttm->num_pages,
 			0, (unsigned long)ttm->num_pages << PAGE_SHIFT,
-			i915_sg_segment_size(), GFP_KERNEL);
+			i915_sg_segment_size(i915_tt->dev), GFP_KERNEL);
 	if (ret) {
 		st->sgl = NULL;
 		return ERR_PTR(ret);
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index 8423df021b713..e4515d6acd43c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -129,7 +129,7 @@ static void i915_gem_object_userptr_drop_ref(struct drm_i915_gem_object *obj)
 static int i915_gem_userptr_get_pages(struct drm_i915_gem_object *obj)
 {
 	const unsigned long num_pages = obj->base.size >> PAGE_SHIFT;
-	unsigned int max_segment = i915_sg_segment_size();
+	unsigned int max_segment = i915_sg_segment_size(obj->base.dev->dev);
 	struct sg_table *st;
 	unsigned int sg_page_sizes;
 	struct page **pvec;
diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h b/drivers/gpu/drm/i915/i915_scatterlist.h
index 9ddb3e743a3e5..c278888f71528 100644
--- a/drivers/gpu/drm/i915/i915_scatterlist.h
+++ b/drivers/gpu/drm/i915/i915_scatterlist.h
@@ -9,7 +9,8 @@
 
 #include <linux/pfn.h>
 #include <linux/scatterlist.h>
-#include <linux/swiotlb.h>
+#include <linux/dma-mapping.h>
+#include <xen/xen.h>
 
 #include "i915_gem.h"
 
@@ -127,19 +128,22 @@ static inline unsigned int i915_sg_dma_sizes(struct scatterlist *sg)
 	return page_sizes;
 }
 
-static inline unsigned int i915_sg_segment_size(void)
+static inline unsigned int i915_sg_segment_size(struct device *dev)
 {
-	unsigned int size = swiotlb_max_segment();
-
-	if (size == 0)
-		size = UINT_MAX;
-
-	size = rounddown(size, PAGE_SIZE);
-	/* swiotlb_max_segment_size can return 1 byte when it means one page. */
-	if (size < PAGE_SIZE)
-		size = PAGE_SIZE;
-
-	return size;
+	size_t max = min_t(size_t, UINT_MAX, dma_max_mapping_size(dev));
+
+	/*
+	 * Xen on x86 can reshuffle pages under us.  The DMA API takes
+	 * care of that both in dma_alloc_* (by calling into the hypervisor
+	 * to make the pages contigous) and in dma_map_* (by bounce buffering).
+	 * But i915 abuses ignores the coherency aspects of the DMA API and
+	 * thus can't cope with bounce buffering actually happening, so add
+	 * a hack here to force small allocations and mapping when running on
+	 * Xen.  (good luck with TDX, btw --hch)
+	 */
+	if (IS_ENABLED(CONFIG_X86) && xen_domain())
+		max = PAGE_SIZE;
+	return round_down(max, PAGE_SIZE);
 }
 
 bool i915_sg_trim(struct sg_table *orig_st);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 08:24:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 08:24:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424788.672484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhuC-0004dA-Iu; Tue, 18 Oct 2022 08:24:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424788.672484; Tue, 18 Oct 2022 08:24:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okhuC-0004d3-GB; Tue, 18 Oct 2022 08:24:56 +0000
Received: by outflank-mailman (input) for mailman id 424788;
 Tue, 18 Oct 2022 08:24:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okhuA-0004cj-Qn
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 08:24:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okhu7-0004Wl-Aa; Tue, 18 Oct 2022 08:24:51 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okhu6-0006Sw-SW; Tue, 18 Oct 2022 08:24:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=RZV2EaUyuf7LDviRdlZ1zghsWBgRjq3ZsAcy/wHuSkU=; b=3Km7LjD/BOVMIq0yts/6nebgii
	slQfESAWAaNb0YGu5FfAHfeY++Wbav9WaOtjsB/8e8aog/HiWUbLZIbBkDYAAazGc8h9TI032O3fK
	2SKxbgaEPUgOlmKfCdeWfTU5NplIGHeRUiWa8oXIOliI2OBXvvW/LW48mUWuBQQkTwR0=;
Message-ID: <460a480e-4e91-8d78-60da-59b9cc98beee@xen.org>
Date: Tue, 18 Oct 2022 09:24:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org,
 stefano.stabellini@amd.com, Peter Maydell <peter.maydell@linaro.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com>
 <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
 <alpine.DEB.2.22.394.2210171345450.2351079@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
In-Reply-To: <alpine.DEB.2.22.394.2210171345450.2351079@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 18/10/2022 02:26, Stefano Stabellini wrote:
> On Sun, 16 Oct 2022, Julien Grall wrote:
>> Hi,
>>
>> There seem to be some missing patches on xen-devel (including the cover
>> letter). Is that expected?
>>
>> On 15/10/2022 06:07, Vikram Garhwal wrote:
>>> Add a new machine xenpv which creates a IOREQ server to register/connect
>>> with
>>> Xen Hypervisor.
>>
>> I don't like the name 'xenpv' because it doesn't convey the fact that some of
>> the HW may be emulated rather than para-virtualized. In fact one may only want
>> to use for emulating devices.
>>
>> Potential name would be 'xen-arm' or re-using 'virt' but with 'accel=xen' to
>> select a Xen layout.
> 
> The benefit of 'xenpv' is that it doesn't require any changes to libxl.

I am quite surprised. Looking at the code, it seems to work more by 
chance than it is intentional as the code is gated by 
libxl__need_xenpv_qemu(). So it would not start if there were no 
emulated devices.

> It is even backward compatible so it could be used with an older version
> of Xen/libxl.
We don't really gain much here. IOREQ is a tech preview and anyone that 
wants to try it should really use the latest Xen.

> Backward compatibility aside, if we come up with a
> different name then we'll need changes to libxl and to manage those
> changes. For instance, if we use 'xen-arm' that would mean we would need
> to handle per-arch QEMU machine names.

Right, so the main argument here is for simplicity in libxl
Looking at how 'xenpv' is built, this is really expected to deal with PV 
backend rather than emulated device. I do expect some changes as we go 
along to be able to add emulated device.

Furthermore, libxl is not the only toolstack out. So I am not convinced 
this is a good argument to keep the name the same.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 08:57:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 08:57:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424801.672501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okiPx-0008KW-6G; Tue, 18 Oct 2022 08:57:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424801.672501; Tue, 18 Oct 2022 08:57:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okiPx-0008KP-3Z; Tue, 18 Oct 2022 08:57:45 +0000
Received: by outflank-mailman (input) for mailman id 424801;
 Tue, 18 Oct 2022 08:57:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okiPw-0008KJ-Cb
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 08:57:44 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed30841b-4ec2-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 10:57:43 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8256.eurprd04.prod.outlook.com (2603:10a6:102:1c6::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct
 2022 08:57:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 08:57:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed30841b-4ec2-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lfMLewIA6CxCD3w4c1eKdqTLBZc7ZvIHLkpDuP2UgI2pxhiVydU3guJzts9HAVTiSfY3PzsFAvrSsqssdsaUGwoK9CY4g0G5kki1l6Gy0SxMrjHt5VsjLuXZPP407/fp8JYdtYHnaeZIfoLOhALQoi0158IdKk2zQU8hp1l7QXcqIf6UptJtno75ipUbWZRA46In8pEBT8y5V4F4N2nzZqFQ8idn48h+EHw8nVy2R6WfQDnJxw+1B4g1pg0aZD6fWzXuqPVh4YzIvWU7FHPkbwl82zg+NeLfB0ZTYuWNokQpjpzzQmpFHW0kJaj+t0B+IFGSt2p8ZOGf/mjXBOvRYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SqwJCSGjT2esYjKBkbxmpZdGWTZBZZK5hYeibCpufYU=;
 b=fgUwqBAnrhhZyMUo0rr+hp4iQyHyJJibsa71cgrtD5KkRwyr1UKXt91LCW1ZjYwxiOqojYkxzKTpCD462HJobuFLJa3o4jeR8xCj7ETQ91UexmTfV/8MZ/ANWsDeIwVxPOHqEaNG8nGHQs5JnRIfjHfJes8RrCuROo/pX7QXwcRV6SnVKSlmTG8rrwdqdLm8peYDtKKeU59uioGO7mDSEUXi1vvE85vr+UZxIsmMmTaw25YuAomYRZbT3LI6F9rDIKuZgEmdemaTnSdnHLdNCdg6rmHnze/k5rAoovwmro3drMJJNWtg9LbOTJX0J4Q1YWpfUNJvwlDaZspAtfquUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SqwJCSGjT2esYjKBkbxmpZdGWTZBZZK5hYeibCpufYU=;
 b=iPl71mOJ6kLNX6cjs6iTQYWR5j9R0wRjhqEvHZWrImi4Rbb+MC9q9Cl1cFwsSLz3iIhYfjKuMbxq2cq3qqhXSyabRVjoSBkHQJqJcY5Bu7PsDTJLapcesCY+S/rm5GxfkRnNLDNCgCS56mAM535MDQ7HOP/KYOrriuE8hbtlEQXeqMtYrujgEiRpY480I4McZVk04FHihaVZeuR87ENi+0Ygu+Gs9z3YrgnfudUJvX5GXdDbAzLDF7Eer+F/Uc8dTE+IJuqijDPbxIhRTIVRt+1l4V85Hz0v5Z49z63/vPeGm5hTT2zIj7FRdIySq39z6WZ0xBl1kcO8rfMKU9IGag==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com>
Date: Tue, 18 Oct 2022 10:57:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Anshuman Khandual <anshuman.khandual@arm.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
 iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
 Jani Nikula <jani.nikula@linux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@intel.com>,
 Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
 Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20221018082413.GA25785@lst.de>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221018082413.GA25785@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8256:EE_
X-MS-Office365-Filtering-Correlation-Id: b7b1ec7f-63ea-4131-cacc-08dab0e6cf7c
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Aqa1Kbk5ugW/26/HgcVQ/c7A/GlRCPUNaCpa2kOSqG4qzfj+FhxKQvicGYmvs+rP+LnsXFIY4Umct4rwhjTJR8s+803vRLQunYX6Eg1VnXI29Ltr1Y7LrTOwQQtKGM0Y6+BKVi4vfPumMZlIx5dWuKwHG8M5DtXwpPm1buYjTMGNkiUbqynLdkDbe3kvQy+rIv5XjkffTaTKngvsBTdAtfSLBVdJHZzE9c6RPou3UFkzAzTA+qNaMm2H9RBD02OM4Z4B4bs2YD+UOG35O+ARyHYlsCwlR0e5OGwl6DiNL5gqt+PZtygV0v7uw3Kf0V/XJ0bQNyi8lm5nndva4SUSERPtpU+BiY90Bw/rvnXiYDeG+6on2db3lpLZaSitfY4AEaXJxXgjKWXHcR/+oFDZd/rpSfqzTnVWK3ryEafLLC1D4jU9uD4l0/pL5WFj6dYbDuLwOEQybgIVD0EkQ/Rrd86wXDG9m8bac/5DaCaGE1SwYdyP/WOIAbGiXVBov8VfXheEGOcDiM5PffVAcACVTxG55lBrodG6FQqjxIqg996DbRz46NFSGK2qMNBiZbltxlcTxNyAabYHulQbaLgxIrYuO53KmDkAEBodx79nd0vEYyG3i3aaLLRGvw9Qzq2i2hnaPaBFPmu5NY+IC+rI/c7WjYmtzhxAx1gmqLdHOkilisBuT/YkjNXbK3cDFE61DiSsfYGg7GAZUxaeahw1Wc+8yTlSaYbMHVRjzUuhfoNyPyMiAcdLzqL/CBgTDlyVCfhMGC5Nai6l7I9iASorbtRaWGChRdwUYBRj/NoRMP0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199015)(26005)(186003)(41300700001)(6512007)(478600001)(2616005)(2906002)(36756003)(6506007)(7416002)(4326008)(5660300002)(8936002)(31696002)(86362001)(53546011)(38100700002)(54906003)(6916009)(316002)(6486002)(8676002)(66946007)(66556008)(66476007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mkc4cVRDMTByUVVFU29lZjNQdkliUWxJUWw3WUtHcTg5dnNIbklDUVJiSk8y?=
 =?utf-8?B?aktLRmMrL29UUzNqNkEvMUpFQVBXenYrOVpnMkJnekFGS2xGMFppYTllS0gy?=
 =?utf-8?B?MG0xQXkzMXA1RWpxbGZwM29Rd1BmN2c3K2ZycG5WUzh3eU1vay85cUFibHRi?=
 =?utf-8?B?b09kcWdaaVJySERkL25odHdaNzVyeWZuVVNyL2NINmRFZGxWbXpQb1hybU4z?=
 =?utf-8?B?Z09VRkU2VzJrcjUzei9BL2xINllaYXNNRlJQRzR1TGEwNVpSOC8yNXZaY0Va?=
 =?utf-8?B?bEVKSWdNOXZZRzNGZUp6Z2NYTExkNEdUSjlzYW93TUsrNi9SU1NmaUdBTVVV?=
 =?utf-8?B?SGFQZ09BbjJqZ1FGL3JNc2xDZVlLZmFOd2pjOGwxNkVHcXVSaHdiU2Fzc1NJ?=
 =?utf-8?B?SUZKQitYWkoxSHZLRDdZeWZ1bE9DZnBxSGI1ZzNmY09qUHd5S3hSaHlUTlhL?=
 =?utf-8?B?c3oyQ2cvLzQ1eW9zRDBNaXVsSDl5ekNzN1FzdGNRSE9VbDJjU083L0UyT3JJ?=
 =?utf-8?B?L0RZcm9ZZ1VZRTdtWnVCZHZUZ0wyd0JSU0ZpVVRxL0hyS3RWZGNoQnpjRC84?=
 =?utf-8?B?cWg4N0tuTmZVMTZuVEdzR2NXcUNPb3o1UkQralhCR3dZL0xGUTYvODVmaU9F?=
 =?utf-8?B?R09pNjhPQ1pIa2x2Y2k1VmZuUkFzUHMwcGxLTmtPaXNTN25xT0ZLUUdGMWN0?=
 =?utf-8?B?T0dZWlBYRWNQWHZlQ2JBT3lvVUJHNW5Ec0JXc21ScXZlMjc4dDE5MXd5aW9Q?=
 =?utf-8?B?WkNNUGVuSVJxU05TeTd6RWs5V3YxMUxzR0U3WXpJREg3bVJkSDBvVHd6K2hQ?=
 =?utf-8?B?UTZHTndPd0Y2R0ZPdTBTMkJJU2U2UVhPUFBENDRlOUo4bXpzYUZUbmdjVXN6?=
 =?utf-8?B?ckxlZTlabG1Tdk9pMDV6OERqS3pQMDFFMlNqdDk3NGIvODBBbHYxeXdCNnhT?=
 =?utf-8?B?QUd2QkkwY3A0N2x3MWRGTE9vZmVyZjVZajBWaGl6Z3lJY29IM1p0ZGdGNjNp?=
 =?utf-8?B?SmpVVUJSUVhBWFN0aWcwdnFHRFN5YzVrblBtL00wSCtVM2JRWGtPcWNvU2Uy?=
 =?utf-8?B?akg2aDB2L3VFWVljUFJYRVhjQ0MrWEVwaWNMNVJiK09qcWdaSFhUWnJzdlFN?=
 =?utf-8?B?c3hUaC9YTHFPdDR5VXVKdzFJa1BvSlE3UUZMSVhjQUpaUkg3MEx3b3djMytP?=
 =?utf-8?B?Z1F1ZC9IelhCNHZkTDdvVnhRRnVCSHA1WUhDMXNaaVFNUURLYmxlTVdlSmpP?=
 =?utf-8?B?YlRyVmsvdFljS1N4UndudkRMK0JGM1pINXE0NFNpVXFlcUdrUTBydWdpbmlL?=
 =?utf-8?B?cFYvcXR0THpIeTFETHA4MEhUNnpOS3VlK2JIdmJWVE1sNklnejVIOU8rWkdh?=
 =?utf-8?B?S3RKMGg0Y29rMzVud2hRMURiU3FuenBsbjZPQ0xKT0d0S2RINUZ4Q2REUTRl?=
 =?utf-8?B?Lytib0NlL2srdkt4bDVCdjZYNTdKcVI5cVh5RERKTzMvRC9XdEZXTzhWVjdu?=
 =?utf-8?B?UmF2b0l3cnBSK2JRMjJWc0NUbDZYRDlzeTB5SlRpeVpnYTdzWUl0c0JZOFdR?=
 =?utf-8?B?M05kOVBaTVJON3pNMVNVZVpySXMxZEFyV1MzbG5DdEhTVkZUYjkwdkVLeVRY?=
 =?utf-8?B?S2ZKNHZFVUhqM0FieWV6a2VOZ0MrNENYbzMyclFGcXp4NHd0eldTNVVDc0sr?=
 =?utf-8?B?Tys5aHZUb3R2NnRwd2hDVUJ4aEJRWkxIOWNhK25yUWpzMTZIdDhQTEt0MU1z?=
 =?utf-8?B?T2ZuSnl3b0FDaFVvOW05OVZ1UDB6UTdHVjM4MUQzRHVneFJ6UWp4RDY1UmpE?=
 =?utf-8?B?ekpzS3VWZ2x4cTNaclNlL1RXcGkybDl0eVNNU2J6dmdzVHVkQVJYcUNhZkZ6?=
 =?utf-8?B?bkxMUnBVa2lBeXdQVDhlNXdxNFQrQlRhY2I4V3VSa2FZL000MHVuOGwxWjNz?=
 =?utf-8?B?eGljanNwWHVHSlZBSnZkWmxOdTdPQjRycnBQd3RoRlBVM1NmODYvWFdRdjA5?=
 =?utf-8?B?aXlYVGhOTHJ4bGRPRXRubkV2UmZvSm12Nm1rc1AyZElJZEtnNXFZZ2laZXVM?=
 =?utf-8?B?T1gySXV2RFFSOFpIdzA3b0x1ejhHUWs3Y3FGcHp0NmViQ1pOdW1rbVUyRmZm?=
 =?utf-8?Q?249D1jMTBNMjrGI4Y4eCL45cz?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7b1ec7f-63ea-4131-cacc-08dab0e6cf7c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 08:57:39.7937
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0lJmNEjoGe8XX8uNUvvtD4nyKEwsDiul5PdoGnAE8mujmiumgWgzDZv12rD6l4zD1mBAkAIz1PG9pD56pGuhcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8256

On 18.10.2022 10:24, Christoph Hellwig wrote:
> @@ -127,19 +128,22 @@ static inline unsigned int i915_sg_dma_sizes(struct scatterlist *sg)
>  	return page_sizes;
>  }
>  
> -static inline unsigned int i915_sg_segment_size(void)
> +static inline unsigned int i915_sg_segment_size(struct device *dev)
>  {
> -	unsigned int size = swiotlb_max_segment();
> -
> -	if (size == 0)
> -		size = UINT_MAX;
> -
> -	size = rounddown(size, PAGE_SIZE);
> -	/* swiotlb_max_segment_size can return 1 byte when it means one page. */
> -	if (size < PAGE_SIZE)
> -		size = PAGE_SIZE;
> -
> -	return size;
> +	size_t max = min_t(size_t, UINT_MAX, dma_max_mapping_size(dev));
> +
> +	/*
> +	 * Xen on x86 can reshuffle pages under us.  The DMA API takes
> +	 * care of that both in dma_alloc_* (by calling into the hypervisor
> +	 * to make the pages contigous) and in dma_map_* (by bounce buffering).
> +	 * But i915 abuses ignores the coherency aspects of the DMA API and
> +	 * thus can't cope with bounce buffering actually happening, so add
> +	 * a hack here to force small allocations and mapping when running on
> +	 * Xen.  (good luck with TDX, btw --hch)
> +	 */
> +	if (IS_ENABLED(CONFIG_X86) && xen_domain())
> +		max = PAGE_SIZE;
> +	return round_down(max, PAGE_SIZE);
>  }

Shouldn't this then be xen_pv_domain() that you use here, and - if you
really want IS_ENABLED() in addition - CONFIG_XEN_PV?

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 09:02:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 09:02:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424807.672512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okiUW-0001L4-Oy; Tue, 18 Oct 2022 09:02:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424807.672512; Tue, 18 Oct 2022 09:02:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okiUW-0001Kx-M8; Tue, 18 Oct 2022 09:02:28 +0000
Received: by outflank-mailman (input) for mailman id 424807;
 Tue, 18 Oct 2022 09:02:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=im79=2T=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1okiUV-0001Kr-GS
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 09:02:27 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on2062.outbound.protection.outlook.com [40.107.212.62])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9511a59c-4ec3-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 11:02:25 +0200 (CEST)
Received: from BN9P223CA0007.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::12)
 by PH7PR12MB5710.namprd12.prod.outlook.com (2603:10b6:510:1e1::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct
 2022 09:02:22 +0000
Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:10b:cafe::6e) by BN9P223CA0007.outlook.office365.com
 (2603:10b6:408:10b::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Tue, 18 Oct 2022 09:02:22 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Tue, 18 Oct 2022 09:02:22 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct
 2022 04:02:21 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct
 2022 02:02:21 -0700
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 18 Oct 2022 04:02:20 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9511a59c-4ec3-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SeS5ntB3Yqx4Gi3mTpCBFnn3Qu35kZcuY/3WHVfyl4VUTkl9wNsnY3KvLxY1KvZg7/t1lzKMwQdAy77Q5LcwD5/6RTtdMRMJOf8Rw/6l2teviLvr+adS86DBHDk0a7MtkZrFhkH27oWinaanQHnom63fBHNOaS0rQmK955uq790k7MLlTlNAVh1FJkUSHTju8BWoGqQPvDEFjbPFJ6WKRDeT1ceRp9s9aZprEjXd6Ia18/tJrCdplhrCXxoHCv2O3Nj5j2ZJ4n++VxvgUEy0mimcmVY/drDSqRY2zbdk0M1ABqjFY1OI9enBK1XTRjXqVKqSyHfQVzSvEtnKYIU+Rw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LAhAc+OIAwUW2yecFHQOqlRgNQVA19hhoZ1LlxWHUxI=;
 b=Gaz0RsW6gbCsRIaIyuuHGAuXHCf4YXgxH+K8pqlAC/PfIqmtlbZODWWhIzZufR9+KZV57tAjuQ+aEG6EH3SrR/1ejyJ1TdllGhGGL0uCzz8TiwsHk5dielFwpIsrVFuiMTSWvSxau8/MlyxufH6Tf1teqN39NGmg37ojFsAut0g1bcxbZ1fxeQ9pagMY2uGbHt9IRigWPBDKOVXx8ogFIH637Tz9VTMCL+44RnbFdTwzKmEp0CbMHIe/t2yRNG84e8YAzniYiqw6ZMsICZ5ft2+2RKA9+zcon1e/3/twCs+Ej9SYVwNk2LgspoSj1cONr66AOuASTP6dMeU7K8wyfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LAhAc+OIAwUW2yecFHQOqlRgNQVA19hhoZ1LlxWHUxI=;
 b=arH+neiBZuWVxwr3vRsDxBRcec57+kGddZC9eOO5OSzASlLYwpKALdCZqSIA5CtXH34jFE/YZo+GB5jvqMEVrX6eXM5HmYEywvuMYR7Iik7tiOa2HooTL9pLwodyjbnWBtSMN7MQgEtxJhNieg1aAvgSiQ2IyKdaYTzdWHimuis=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <ddef5ab7-c217-546d-0e5d-294465a49586@amd.com>
Date: Tue, 18 Oct 2022 11:02:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>
References: <20221017173209.236781-1-burzalodowa@gmail.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221017173209.236781-1-burzalodowa@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|PH7PR12MB5710:EE_
X-MS-Office365-Filtering-Correlation-Id: 392cec2c-5011-4a6f-0041-08dab0e777e2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Iw9YTYY58Zr2duAgCybCfKfJqcBGFsimEXejGxF/4eToWMdAQjDb6pHzWhe4sEBs1szOfup86E4ALP6ogJbLNJqL5Gxr8QyRvsEiDcT0vPMa22FFyBLgC3dVws0AXFAnQG2vdNTI3zVn0fRlbYtmOAt9l4TDhOkEr4KQJYPgLp9xU/898KtmOEs9rqSWCO56i+cm9UFuInMPwUIIdDgpoaTUfUjx3fyuX2iyt6ov3Ndk5PLmFRdzR1UWLPLSlA2+8uJTuNm9EEI8iGixzFPemle9b31dfn2nK6qD/nRwij0FsMhwe22L0ykVPix0qRVhxldfIL/z8Rhvsv2LvuObfzJar0jo0R4SYPkq2a5QqkEaCDNZiyjlVKXLlgIv+DnAC7SBACcfSzsbfiwu7cu4Y6YJWO80qi84oE/A6RgDutU+q50WwlRJbiSBN+rDQLgAS17nvc+xUWJM+CDnLIoM43ogkosJFFmAOuoFNmvaAQMui/FMeiYRCrPiCmr+y530z546MK6MwzhJJdCf7sieFJ6rljZcy3hSjZGP5eA/jckyrx26F0xQ4RBP0c+XoVTgH8zNxh0PgWikHFoMTQnVNOfLSY1zQ+TCsFu4yMCC6cjZ3DovhMMTPuPvwRHz23HxmVrnkgOp/TgQWAb/JueXaRkl4qzNOF9YRfUGCxckseafyGdzqXEcpRT32+paxXlEWjGEQMatTucx2OFSx6YxbruoEcJujfD+20+XA49eQ0dy/XOCgidXTb7eU9SDSMbYk792Jbyas6GjFMSVIfrlhcOZHiyD6x/ZWiECs9d+/ImiplilQnr1r7bKGuO0oMXQINtT1NSyAs8m0pDlFXnA2w==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(31686004)(36860700001)(26005)(53546011)(82310400005)(8936002)(110136005)(40460700003)(2906002)(41300700001)(83380400001)(4326008)(478600001)(5660300002)(316002)(54906003)(16576012)(40480700001)(8676002)(36756003)(82740400003)(356005)(2616005)(426003)(336012)(47076005)(44832011)(70206006)(31696002)(70586007)(81166007)(4744005)(86362001)(186003)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 09:02:22.1111
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 392cec2c-5011-4a6f-0041-08dab0e777e2
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT012.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5710

Hi Xenia,

On 17/10/2022 19:32, Xenia Ragiadakou wrote:
> 
> 
> Currently the pa_range_info for the 52-bit pa range advertizes that the
> p2m root table consists of 8 concatenated tables at level 3, which does
> not make much sense.
I think the current code advertises 8 concatenated tables at level -1 (sl0=3 -> root_level=-1)
which is obviously incorrect, but the commit msg should be updated.
Funnily enough p2m_root_level is unsigned so it would lead to overflow
(p2m_root_level would end up with (1 << 32) - 1 instead of -1).

> In order to support the 52-bit pa size with 4KB granule, the p2m root
> table needs to be configured either as a single table at level -1 or
> as 16 concatenated tables at level 0.
> Since, currently there is not support for level -1, set the
> root_order and sl0 fields of the corresponding pa_range_info according
> to the second approach.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>

Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 09:25:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 09:25:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424813.672523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okiqK-0003uB-IR; Tue, 18 Oct 2022 09:25:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424813.672523; Tue, 18 Oct 2022 09:25:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okiqK-0003u4-Fg; Tue, 18 Oct 2022 09:25:00 +0000
Received: by outflank-mailman (input) for mailman id 424813;
 Tue, 18 Oct 2022 09:24:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SMRC=2T=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1okiqI-0003ty-Pf
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 09:24:58 +0000
Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com
 [2607:f8b0:4864:20::434])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id baefeda8-4ec6-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 11:24:57 +0200 (CEST)
Received: by mail-pf1-x434.google.com with SMTP id y1so13546467pfr.3
 for <xen-devel@lists.xenproject.org>; Tue, 18 Oct 2022 02:24:57 -0700 (PDT)
Received: from leoy-yangtze.lan (211-75-219-199.hinet-ip.hinet.net.
 [211.75.219.199]) by smtp.gmail.com with ESMTPSA id
 x184-20020a6286c1000000b005622f99579esm8751955pfd.160.2022.10.18.02.24.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 18 Oct 2022 02:24:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: baefeda8-4ec6-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=6vlRg12olj5JkM7jdQADHZUuCu+dv7eXSTEyPP63tuM=;
        b=P1gfuj+vS2QDJxu1ooGWer4pVsrKmzCDHz9FHhxnOig9U7bz4XYkqeDAU+JIt/fsmD
         sgJ9qKUBK4inEUw2EHMPjofAguOQ9njovgIHn2GzIecXKKN9dF43FwTTf+qIfIxVekO+
         7hogsV51vdrqI1ndYpALp9CDNR+zes6Ny+3Vt+nn71KHyZsUFOD9bZFR476rXnqd9NG9
         vvPfH+s+6vbAmpoYECVXV10XvPHn8nvM9odQP8fIaSa1N4ui5IHGsCXrQ6oG25K5hX5G
         CSzTeR68486wubvX6JU4P/OE73TWH6asfcw+LJ4lYNMz0YTSSfQGb79o6vqHO1xJe6Om
         /4TA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=6vlRg12olj5JkM7jdQADHZUuCu+dv7eXSTEyPP63tuM=;
        b=z1am1uB7YBZ7z5euplaNpe5d4gaS2epPyxY915AW57L+524rGcykprLTitMnyeMVZx
         T3BdJYWwBPLPlRC1c/bfQm6lIWd8FFzF0i7HfGHVse0C65697NK1CcIcfuNr9kmigVNQ
         q0ZyQzXlo8b4oBamBq0oCNp8tStL0Qyfjew3qaNBpMDbOOIg17fdPkth7l+RTavGR0/F
         pqV0MFk2msIQbZVMKCFPStWlHrn2qBe0/vQ18am8vffjep+jwXIyLyVVvyC6xmpyU14N
         d9MfsdhJr9ux/Rq2Os0SwBqINNmOOUmoPnnUuyKiIk00+5g3lVNqAfLb1UKrv10KMSwq
         yVrA==
X-Gm-Message-State: ACrzQf2P+C8Wf5Supse6DB3h4RQjVxkGVAJnGilC0fWUj9Hm7bcTVwoz
	iGk+owG2pDcv9VvPp5fFwQjQrw==
X-Google-Smtp-Source: AMsMyM7+CwR43A4a9QUq23F8tIyu/URPeg4W1jVH9kqRk8M4nTYphS0xt93RZGLX0aKj56rShlBDfg==
X-Received: by 2002:a05:6a00:1947:b0:565:c337:c53b with SMTP id s7-20020a056a00194700b00565c337c53bmr2299521pfk.10.1666085095708;
        Tue, 18 Oct 2022 02:24:55 -0700 (PDT)
Date: Tue, 18 Oct 2022 17:24:47 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y05w36OAVyDJwCCr@leoy-yangtze.lan>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>

On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote:

[...]

> > Which means it takes 543us to let Dom0 to receive the notification.
> > You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
> > not have contention for CPU resources.  Seems to me, it's likely Xen
> > hypervisor takes long time to deliver the interrupt, note, it's not
> > take so long time for every skb transferring, sometimes the time for
> > response a notification is short (about ~10us).
> 
> Good find. I think this is worth investigating further. Do you have
> vwfi=native in your Xen command line as well?

Yes, I have added "sched=null" and "vwfi=native" into Xen options:

options=noreboot dom0_mem=4096M bootscrub=0 iommu=on loglvl=error guest_loglvl=error sched=null vwfi=native

> After that, I would add printk also in Xen with the timestamp. The event
> channel notification code path is the following:
> 
> # domU side
> xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
> xen/arch/arm/vgic.c:vgic_to_sgi
> xen/arch/arm/vgic.c:vgic_inject_irq
> xen/arch/arm/vgic.c:vcpu_kick
> xen/arch/arm/gic-v2.c:gicv2_send_SGI
> 
> # dom0 side
> xen/arch/arm/gic.c:do_sgi
> xen/arch/arm/traps.c:leave_hypervisor_to_guest
> 
> It would be good to understand why sometimes it takes ~10us and some
> other times it takes ~540us

Thanks a lot for detailed info.

Just note, in my platform DomU enables GICv3 driver rather than GICv2.
This would be a bit different in the Xen code.  But it should be easy
for me to map to vgic-v3 files.

I have a question for how to trace Xen system.  Outputting chars to UART
is time costy (usually it's millisecond level), it is not friendly to
use console for debugging performance issue.  I searched a bit, either
"xl dmesg" or xentrace can be used for capturing trace logs, one thing
I am not certain is if we can save Xen logs only into log buffer and
doesn't output to UART, so that afterwards we can use "xl dmesg" to
capture the logs.  Could anyone confirm for this is correct usage with
"xl dmesg" or I should use xentrace for this case?

Thanks!

Leo


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 10:01:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 10:01:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424820.672534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjPK-0008Uq-F1; Tue, 18 Oct 2022 10:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424820.672534; Tue, 18 Oct 2022 10:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjPK-0008Uj-BT; Tue, 18 Oct 2022 10:01:10 +0000
Received: by outflank-mailman (input) for mailman id 424820;
 Tue, 18 Oct 2022 10:01:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okjPJ-0008UZ-ET; Tue, 18 Oct 2022 10:01:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okjPJ-0006Jk-AE; Tue, 18 Oct 2022 10:01:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okjPI-0005HH-Ub; Tue, 18 Oct 2022 10:01:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okjPI-0008K1-U9; Tue, 18 Oct 2022 10:01:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qfeVKJyKFU2/bfvT1QnHxcyD+/rs1LIAnD5PY0Q1AtI=; b=5VK1nsQvvqY/bVa53QquF49/AB
	mACIzYmBlltSCQCCf87/29tigDAZFrE3NKG7N7blcll/S37Ev5WpOKo3Rs0TR8Cn1ypawOfCpV9Fh
	Dvb50402vK1kZpONhr8ogxicmBoyIfPTJWrkjotMl9OQn3WwIpk188VdkHrCoANIpm0c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174039-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174039: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 10:01:08 +0000

flight 174039 xen-unstable-smoke real [real]
flight 174046 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174039/
http://logs.test-lab.xenproject.org/osstest/logs/174046/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   10 days
Failing since        173492  2022-10-11 13:01:50 Z    6 days   44 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 10:28:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 10:28:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424828.672544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjpC-0002jY-JY; Tue, 18 Oct 2022 10:27:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424828.672544; Tue, 18 Oct 2022 10:27:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjpC-0002jR-H0; Tue, 18 Oct 2022 10:27:54 +0000
Received: by outflank-mailman (input) for mailman id 424828;
 Tue, 18 Oct 2022 10:27:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j5CF=2T=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1okjpB-0002jL-Q8
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 10:27:53 +0000
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com
 [2a00:1450:4864:20::52a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8427ee09-4ecf-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 12:27:52 +0200 (CEST)
Received: by mail-ed1-x52a.google.com with SMTP id b12so19775074edd.6
 for <xen-devel@lists.xenproject.org>; Tue, 18 Oct 2022 03:27:50 -0700 (PDT)
Received: from [192.168.1.93] (adsl-46.176.58.194.tellas.gr. [176.58.194.46])
 by smtp.gmail.com with ESMTPSA id
 3-20020a170906318300b0078c213ad441sm7330127ejy.101.2022.10.18.03.27.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 18 Oct 2022 03:27:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8427ee09-4ecf-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=zX11Xw/h+8sd4YDjRtPuRoWYPSIUhHXGmBSMfYZQbFA=;
        b=fS6k+MjNP1ipepGVqqH7rPzuAluGBrqbOUrz0rIxFagdBwCKp1Hr/2ugkP80BAjRyz
         2eRmO73AJi8WKIpiGz/O8Xuwc0FnOgaDbeDrnLsSGsczba5fB10v5W42aPtIcWTrDsAn
         FZRPPTgnmj/PaHbimABGK43pMh4zWAwVnTWdc9uoiqLEC6e0U/DIWfqjn+JxKL88Rc7H
         /0vUtSQD/YggSomGHsSEviNyXf3BdNvK+ChP5/gW13CE2TclbW1FD8mWgY62CknhPd+T
         iFjpOPwqlGVFHTkdgYYJX67div/0L5+B3tlJzoaOJ7ywr3zxnfhSdVAsyh5TkXmAGL7o
         YUGw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=zX11Xw/h+8sd4YDjRtPuRoWYPSIUhHXGmBSMfYZQbFA=;
        b=aDVOFPcVj9ajEYo7LQLncJI3OWcZb7ItraZkg/6xD9PPxWm9EQ7SRh5gbCHL6DXVmo
         b4FHhcVzl+Pl1BZ+JZEgqpDniCRPViCujQYtv9WZfm6PuiZQa6X/k2Fgh0ZHRN5usSRi
         c43PCrd7TP0CbhM+W9avG0suE9pWDo5NZDUtAAZutrNPBSPVzSbWoa4GL/gFgTDMOOyL
         rpDbFCg0xarmHeG9qsF20gjM6Sfocw/RQdmUe3PlEC0mdI7bpuU458FDfr+BSmcCElZx
         HZ0PelVQpJQ7uCgnxabI9PK8CQLo6mGTFoherlDrRUCC38gcS+HzACR31IMMKHjNM3aP
         la9g==
X-Gm-Message-State: ACrzQf0M4gHDml4vwXbo8v34Y267KhBYZzh7Ul4F2EVb5xtmhh69yj/q
	kkBjg5+l0rf60dr6QUci8oen/7Uk0ZY=
X-Google-Smtp-Source: AMsMyM7HmJLyte/OXb/kzVr/8xo8o9M/HQWXaAOSPOu9x+Id4tJi/ISeMDEz3fRuxELi9GM7EhyFow==
X-Received: by 2002:a05:6402:51c9:b0:45d:5efe:d1a3 with SMTP id r9-20020a05640251c900b0045d5efed1a3mr1944881edd.58.1666088870032;
        Tue, 18 Oct 2022 03:27:50 -0700 (PDT)
Message-ID: <65b46c0e-3499-ce6c-dcd6-76c506115c6e@gmail.com>
Date: Tue, 18 Oct 2022 13:27:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017173209.236781-1-burzalodowa@gmail.com>
 <ddef5ab7-c217-546d-0e5d-294465a49586@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <ddef5ab7-c217-546d-0e5d-294465a49586@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/18/22 12:02, Michal Orzel wrote:

Hi Michal,

> Hi Xenia,
> 
> On 17/10/2022 19:32, Xenia Ragiadakou wrote:
>>
>>
>> Currently the pa_range_info for the 52-bit pa range advertizes that the
>> p2m root table consists of 8 concatenated tables at level 3, which does
>> not make much sense.
> I think the current code advertises 8 concatenated tables at level -1 (sl0=3 -> root_level=-1)
> which is obviously incorrect, but the commit msg should be updated.

I did the same mistake in my email but I did not want to hijack the 
thread that 's why I did not come back to correct my error.
According to the manual, to support 52-bit pa range with 4KB granule 
with the root table at level -1, you need to set SL2=1 and SL0=0.
SL0=3 configures the root table at level 3.

> Funnily enough p2m_root_level is unsigned so it would lead to overflow
> (p2m_root_level would end up with (1 << 32) - 1 instead of -1).

Actually, currently, there is no support at all in XEN neither for LPA 
(LPA support for 4KB is not checked, VCTR DS and SL2 are not set etc) 
nor level -1 (the root table level is determined only based on sl0, the 
number of possible levels is hardcoded to 4 in many places etc). I don't 
think that there is even support for accessing other than the first 
table of concatenated root tables but I need to verify that (I assume 
this based on the way LPAE_TABLE_INDEX_GS is implemented).

This entry is populated in the pa_range_info table just to prevent XEN 
from falling into this
if ( pa_range >= ARRAY_SIZE(pa_range_info) || 
!pa_range_info[pa_range].pabits )
         panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", 
pa_range);

> 
>> In order to support the 52-bit pa size with 4KB granule, the p2m root
>> table needs to be configured either as a single table at level -1 or
>> as 16 concatenated tables at level 0.
>> Since, currently there is not support for level -1, set the
>> root_order and sl0 fields of the corresponding pa_range_info according
>> to the second approach.
>>
>> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
> 
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
> 
> ~Michal
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 10:31:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 10:31:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424834.672556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjsy-00048W-2u; Tue, 18 Oct 2022 10:31:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424834.672556; Tue, 18 Oct 2022 10:31:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjsy-00048P-0C; Tue, 18 Oct 2022 10:31:48 +0000
Received: by outflank-mailman (input) for mailman id 424834;
 Tue, 18 Oct 2022 10:31:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okjsx-00048J-1w
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 10:31:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okjsw-0006ui-Ns; Tue, 18 Oct 2022 10:31:46 +0000
Received: from [15.248.2.52] (helo=[10.24.67.27])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okjsw-0003lH-FX; Tue, 18 Oct 2022 10:31:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cAjyBr40IBDLi78Yf9k9FTGxZ1/hLIyOZYAS0CCYdpE=; b=Q53ecbAv2TR2vpRqaFBYSoD1Kk
	fKxW46KamT689f7LgK32qhLI6hXn6lp11VTAGDURc98294dKHDL1xyoBwG94mPbe1/RQvwCr1gYJj
	KBSQ+oisoBfzu4GSytCKJVLvlMWaszdBqJD0mCRlbSu170hE+QcOIquCCCsR0pMZgTCM=;
Message-ID: <42ad10fb-0d77-2f5f-ff34-dbdcb42523fd@xen.org>
Date: Tue, 18 Oct 2022 11:31:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017173209.236781-1-burzalodowa@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221017173209.236781-1-burzalodowa@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Xenia,

On 17/10/2022 18:32, Xenia Ragiadakou wrote:
> Currently the pa_range_info for the 52-bit pa range advertizes that the
> p2m root table consists of 8 concatenated tables at level 3, which does
> not make much sense.
> In order to support the 52-bit pa size with 4KB granule, the p2m root
> table needs to be configured either as a single table at level -1 or
> as 16 concatenated tables at level 0.
> Since, currently there is not support for level -1, set the
> root_order and sl0 fields of the corresponding pa_range_info according
> to the second approach.
> 

Please add a Fixes tag. Also, it would be good to provide a reference to 
the Arm Arm (paragraph + version) so it is easier to find where your 
values come from.

Cheers,

> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
> ---
>   xen/arch/arm/p2m.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index f17500ddf3..c824d62806 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -2251,7 +2251,7 @@ void __init setup_virt_paging(void)
>           [3] = { 42,      22/*22*/,  3,          1 },
>           [4] = { 44,      20/*20*/,  0,          2 },
>           [5] = { 48,      16/*16*/,  0,          2 },
> -        [6] = { 52,      12/*12*/,  3,          3 },
> +        [6] = { 52,      12/*12*/,  4,          2 },
>           [7] = { 0 }  /* Invalid */
>       };
>   

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 10:38:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 10:38:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424840.672566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjzG-0004tF-Q9; Tue, 18 Oct 2022 10:38:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424840.672566; Tue, 18 Oct 2022 10:38:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okjzG-0004t8-NU; Tue, 18 Oct 2022 10:38:18 +0000
Received: by outflank-mailman (input) for mailman id 424840;
 Tue, 18 Oct 2022 10:38:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V1Uc=2T=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1okjzF-0004t2-2z
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 10:38:17 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2072.outbound.protection.outlook.com [40.107.93.72])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f811e64e-4ed0-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 12:38:15 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM4PR12MB5771.namprd12.prod.outlook.com (2603:10b6:8:62::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct
 2022 10:38:10 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836%6]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 10:38:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f811e64e-4ed0-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k2qQrG9E5W1FrmCOLWv9dyUigCmjYVuqhh592gATa91GvXfkchXbBFymb8CR2r4KB76ByGCjQFh6qXpuE4Kr5zUYCWDYJtrTeXzNv3GUJJNix8wUcUEprmdaSilN5L2yCZgVRQ2ZKR0cNxHOl/VDfXrGX3j9OiKk86mqV7IcMWpyHjq3rw0CZD/pLOZcAR2Vm050IzP32r9Jxd+q2PO78mU5gqLQ6tF/cpohBIRzViCiczKxDfhTykWVqbIRpoORhfeR1IJ5/gTF8msQDyvc/ZpPBTzderjk9RvdWbi5HV4C0CrFj+AxEYr3mIFm3CUvvll7yP1usZVxueCJkwowsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BvkagyM3KobcBA2b4SMRPB5en7GYIVE5ghqxHNPc/kA=;
 b=L8kvfnXchaPGeiiHmbxcE+WjG8S6nDUpWmxqkOh5JMLniOIFZ6bXVmG3lm+zj5Kap+KUMvAqHuAeoCZfr1XbnMul+mjMpsCatz90FWvM9lZC+dCQ89rrdzv91f4p/9DlFaWaY4QIcaU6bx3BFQ4oxmtfqx77AHi/G/2Sxxv43o5aYnRkhkwP1gR9O6stohmu9SZ5hZ5Z6T0bbIKSjqtDL9vi5QQ+TpklXVsl933OrPTgvB8L9Zoj5AR9V0OR1tqgZv+G4ZUrtNwY1EfCQP1n58e6gZF+0xwFMV/kURSP1IQZULYc1ffx0OdalX4NcwHmt3lihUMs5V36HpwjBzBOcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BvkagyM3KobcBA2b4SMRPB5en7GYIVE5ghqxHNPc/kA=;
 b=ZmsGGUDtVKMEUwLqn0pxn5UWIODEO5OwSrgRXniC6L0P7YRcxDSc3uq4B2i4BHPLAR9pxI4/db3KK98ApUzPEN6RQAPBJtcOyhILmU79zGSaxQkTV8EmvHDGgXbjP8RtU0/KllbOjlMU6O1QC+DvAzqdq2knPUy+4xE96st/ESM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <b4d413eb-2956-b167-323f-31d82da737dd@amd.com>
Date: Tue, 18 Oct 2022 11:38:00 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Andre Przywara <andre.przywara@arm.com>, marc.zyngier@arm.com,
 eric.auger@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com,
 suzuki.poulose@arm.com
From: Ayan Kumar Halder <ayankuma@amd.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
 linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.ed,
 Julien Grall <julien@xen.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Need guidance regarding emulation of GICR_PENDBASER and
 GICR_PROPBASER registers on Aarch32
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0133.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2c4::8) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM4PR12MB5771:EE_
X-MS-Office365-Filtering-Correlation-Id: 74ffc1d0-bae6-4d56-d69f-08dab0f4d8ce
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aDGX6oJIyuCsKfy5YXNmqARnKRPnCIVXx7yQTMHTVF5y8ZVRaiABiDduId+OUk+hgtoHZkAI7d+O5L1GQg+nfp7wcfBV3RLt53POL16DOuC5wLI0OCfMJmCy0clYgmw1Yt7lCokqRFouukM7XGS7Usmb58nKJM7EfE+2zkScpClFP2p34NzUv8KxcCOgMLMLV2l81/4/aKMuKPfLQZrnVPJB3hIfb9zU2pCuUdil+1BN+ZlvwdCKZt4clUB6GQg2pQ9PsFjobomc41pMpSWnN6T/wqPZqCJR+pBdGwXmi/BMQHKCWm5osq9btVF5O9Q/fyPWGRLrFbRij0A5ToE6qzeBYDb0U9ATd+93WJ3c8SVV66m0scHyU30x7mGT3f9nuXALZIGPRrFR51zBjwoRLLyZE2o0KUR2LJ0qwOqd/2JDfe6Zb0PjrOeRJj+VvftteYZrWSB0YzGBgugzNDP0Uwqzx75dEabNoU7MKD6xMS65Fsk+lih+q1/8qukt3uzhJT8RXkYmxFeJVHMslzF1wsYC4HJ8JQljIPd6yHDDZKy648CXcCJBPEAEZXrly56zkOuRe7An3rIyeN74ztzNo1DZwoyPEetN66oCrt/OstWxv1UsIRj62K7wvstvOa/3Y7/DTA0tY96bRBZ5GiTMFgzceCrlHvUIe4geBgaTVdRGfLX0GgTDMJpg/aeExdV7jrNymBN+/35Ga4xGvUP3Ac9pSDMO/5h47rvGm5P1H1l/TlqCYlim6V+mjW7QcGliWLRVw81IneXKjGXjI0V8NHS2xVoHZTkw2SVQZ5PsQmc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199015)(31686004)(6666004)(6506007)(478600001)(6486002)(26005)(6512007)(36756003)(2616005)(186003)(2906002)(83380400001)(54906003)(31696002)(316002)(7416002)(5660300002)(38100700002)(8936002)(66946007)(8676002)(4326008)(66556008)(66476007)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WU9jWmVrK0RNbHFzS0gzVDhKL3pONjdicWorNGhiV0krUnl6aGh4RHVwSnF2?=
 =?utf-8?B?Z0tmd3dpemR2aDh2TVlWZEp4Zi9la1RiMm0wQkRKNFZab01GcWpwSS9YcDQ4?=
 =?utf-8?B?YitSeUs5OFZQWDlEVHkxdDI0cFhSdEdpb0pYSVpBUWhYdHZkZGVQTzUzM0VR?=
 =?utf-8?B?NHg0c3lwLzJ4REpSS3E5QmxxRGJVMU5sWkpCU29oSUFnOUFaSTBqbnlFL1lD?=
 =?utf-8?B?N2paM2liQmJIOUtaelFONjRzSy9FNnhJMjdzMHN3bVBQOHhkaEZsQzltbTBV?=
 =?utf-8?B?NHJyTVFSTkdsbE9Bc1hmazJSTGtQZnorWHd6b1NJdFZveXBEYWVWODdwYWVJ?=
 =?utf-8?B?aVJyNnIwUks0ZFpYcWE4dGswQlIrWUE1clIyOHI1aVRLUTV0cDQwbFZ5RDRk?=
 =?utf-8?B?UWlRWFJtTTJ3ZGt5TWNkT3Z4NWZYR2grVXlsZUhTcmFpM0JuZXpScElXRGEy?=
 =?utf-8?B?Tk1xVUQ2UlhuK3d0U0RhVlVYSXFWTWwwZ016ZVBkNmZjYk1JLzBkY1BraE50?=
 =?utf-8?B?ajJIc2U2SDVsUTViZWZTOFY3OC8rNVpHRzRVZmhtblFFcXNxcWF3clNhMGJ0?=
 =?utf-8?B?K1Q1OFFOc2s5aGNvZ0ZnZnp2ZWtNMW83cnZIb2RhNFMvbitKV2ZOblFtaCsz?=
 =?utf-8?B?YmdVeThvS3NIV09EV2hoZnRmZWk1aEhId3dncTQ5VGxEaFpjOEs1aWQ1aVpv?=
 =?utf-8?B?ZGVtaXNYbi9oK2RmN3NSNmZEWEc2elB5SmY1OWpuWnJQbUtuY3Q3QXZXQldG?=
 =?utf-8?B?Y3QvZEhPM2xlZHMwQ2ZVWFBwWTRwd2NhVlNyZzEyVHVCQ1JxSkJqa3FVdTlD?=
 =?utf-8?B?aUlncjhrQ1NISXhRbHMyV0M3VE1vOUFXQ3lweFJQR1lzM0hSOG90d2xQR1ll?=
 =?utf-8?B?d2YxMXZtbW1zY081S2JjZnpMZmk2VElibXdrTFl3aUFpL28vM1lwSWJRYURQ?=
 =?utf-8?B?SG0zWVlEdzFCNzFUcUxFUGl0aEhuM3U4ZWdBaUR6NFU0SnlINUtCZWlIL09Q?=
 =?utf-8?B?aHF3T0x0TEx2bE5IWVNkZkMyUnphTFdab2o5TlZzK3F5WmQrbzJ6Qys0NW02?=
 =?utf-8?B?Y0I0UzdMa0FYSllWS0xBTjBBYmpmWFY4VjVVUnptWHFXQ0pDTXl6MkcvdzYx?=
 =?utf-8?B?SUhabXZsT2RmWUphSDVVeEFRdUExSkJaUkV4QWhRRjB0ZmxZaVFWeTVJYnNT?=
 =?utf-8?B?dXJmZ29QSnNqVjBTMHVhemtCVW84bk5sWmNHazdDUGpiM2pKU2pGS0hyUWRB?=
 =?utf-8?B?b0R0aVJMcWRmY1FQdVZWUVY0OUVGeWx5OUVYelcvWjRjWWZyTTFieTRtOGNH?=
 =?utf-8?B?dkFKNFFiSWQxdjl0SXcyQkhZbHFnR1hRVmdXb0x5endqUWtIdW5hYVJYNUYz?=
 =?utf-8?B?VWU4M0JpcjE2bGR3dFdTQnA5UzFta2Z0bEVjdTNqMC9HbEVBRmNPeEVLWHBV?=
 =?utf-8?B?aURLNFV5U2lYWWNDY3RySGt5OU9OeDcvcm1za3cyUy9TQ1ByWXBQcVVRMytq?=
 =?utf-8?B?TzM1UlZoNXU3UjNhTkp2cmpFaGFYNkRVQWdBdlNsSFRmQ0JraDdOVklHZjNZ?=
 =?utf-8?B?K3N0RnhmWXFwSjRXRUdGVGRHbDNGQk52U2FRcndZSGNXZERodmZiMXp1NEow?=
 =?utf-8?B?V1liREl0WS9FKy9HZzN5MStRWFg5dWsvdTFDaGdlRDY5RFBiVWpqaWxNemNX?=
 =?utf-8?B?Vi9WUUlQQXI4NmpsbEU3VmZ1cTN1Qk94OUFKWXZsTVRyOSs1OWc2Y3RtYlBu?=
 =?utf-8?B?c3U2VjcvTnFVVkdidFY1ZVhNTXcwQ1NOdE1zRFk5WkxIUmNYR0l1TytNbjZp?=
 =?utf-8?B?b3J1VUJwaEN4dWIvREF0VTdKQ3BlMGY1Tnl1a1FVNEl6WUdac3ozV0NybGMx?=
 =?utf-8?B?aFA4ak4yZWh5RjVVVFFJUHVnZ1AxRVVEYUFJZGZGUFFJRURqZUQ4dnVlaENy?=
 =?utf-8?B?NnFCR2N5T0tVUEZrY2dUWDRRM252T2pwUWxFNDd5aFlqTDZNclZmQzhjYlhw?=
 =?utf-8?B?U2FpUDQ3dEdoNE1YRkpPcjYyZk9KclJ2M1Q5TkRjZHBoUnd3dWtLd2xjRWlV?=
 =?utf-8?B?V2NVS3VjV1c0M25TS3N3UHNLbkVxNVNKOEhydjBGMld5d1c2V3hna1VlRDBC?=
 =?utf-8?Q?3ascA63wcsXPEo8MmRpYiJDeR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74ffc1d0-bae6-4d56-d69f-08dab0f4d8ce
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 10:38:08.4164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HLmsNArnU5N91h7xpHvTdYSCw0MHXF0beBHU30RC91SIPYHnTGSJcBDukiKTQq8Q38s0tz6yrdnnl2VHwX8oWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5771

Hi Andre/All,

Greetings. I am trying to port Xen on Cortex-R52.

I am trying to understand whether GICR_PENDBASER and GICR_PROPBASER 
exist on Aarch32 platform.

Looking at the definition of the registers in "Arm IHI ID020922", (from 
my understanding) it seems the registers can be accessed in 64bit mode only.

Please confirm if my understanding is correct or not.

This seems unlike GICR_TYPER which might be accessed as two 32 bit 
registers. The reason being the upper 32bits represent affinity and the 
lower 32 bits represent everything else.


If GICR_PENDBASER and GICR_PROPBASER are accessible in 64 bit mode only, 
then we Xen can't emulate them on Aarch32 as ISS is invalid (for ldrd, 
strd instructions).

However, looking at the following commit in kernel, I am a bit confused.

commit 0aa1de57319c4e023187aca0d59dd593a96459a8
Author: Andre Przywara <andre.przywara@arm.com>
Date:   Fri Jul 15 12:43:29 2016 +0100

     KVM: arm64: vgic: Handle ITS related GICv3 redistributor registers

     In the GICv3 redistributor there are the PENDBASER and PROPBASER
     registers which we did not emulate so far, as they only make sense
     when having an ITS. In preparation for that emulate those MMIO
     accesses by storing the 64-bit data written into it into a variable
     which we later read in the ITS emulation.
     We also sanitise the registers, making sure RES0 regions are respected
     and checking for valid memory attributes.

<<<<< code >>>
REGISTER_DESC_WITH_LENGTH(GICR_PROPBASER,
-               vgic_mmio_read_raz, vgic_mmio_write_wi, 8,
+               vgic_mmio_read_propbase, vgic_mmio_write_propbase, 8,
                 VGIC_ACCESS_64bit | VGIC_ACCESS_32bit),
         REGISTER_DESC_WITH_LENGTH(GICR_PENDBASER,
-               vgic_mmio_read_raz, vgic_mmio_write_wi, 8,
+               vgic_mmio_read_pendbase, vgic_mmio_write_pendbase, 8,
                 VGIC_ACCESS_64bit | VGIC_ACCESS_32bit),
<<<< code >>>>

The register regions are defined in arch/arm64/kvm/vgic/vgic-mmio-v3.c 
and the registers seem accessible in both 64 bit and 32 bit modes.
Please let me know if GICR_PENDBASER and GICR_PROPBASER are accessible 
in 32 bit mode.

Kind regards,
Ayan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 10:56:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 10:56:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424846.672577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkGz-0007PL-6Q; Tue, 18 Oct 2022 10:56:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424846.672577; Tue, 18 Oct 2022 10:56:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkGz-0007PE-3n; Tue, 18 Oct 2022 10:56:37 +0000
Received: by outflank-mailman (input) for mailman id 424846;
 Tue, 18 Oct 2022 10:56:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1okkGx-0007P8-Mp
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 10:56:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okkGw-0007Km-Nx; Tue, 18 Oct 2022 10:56:34 +0000
Received: from [15.248.2.52] (helo=[10.24.67.27])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1okkGw-0004zM-HD; Tue, 18 Oct 2022 10:56:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=EAoh4xPEOs9HbyFwRm1j5W/DubrhLm9PeOLwpJwIbVQ=; b=rFhBQlJIj8kWMC1VZtUXurWfzt
	GXfk51LnYwDhr5ryJw0hLC3Ws+BRqjUmmeO0PuUh6FPmo+o26H3qNAoFhc29tBdIahOei8xqIWoGu
	pvBEcHeC8VOFChTHSRXw/n/f1hEbitBVDNVdfQA3VlVQwlDX0LVYOqgoTB3xe64U05ws=;
Message-ID: <fbc42d87-e96f-3343-cc63-a14564549c02@xen.org>
Date: Tue, 18 Oct 2022 11:56:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
 Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017173209.236781-1-burzalodowa@gmail.com>
 <ddef5ab7-c217-546d-0e5d-294465a49586@amd.com>
 <65b46c0e-3499-ce6c-dcd6-76c506115c6e@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <65b46c0e-3499-ce6c-dcd6-76c506115c6e@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Xenia,

On 18/10/2022 11:27, Xenia Ragiadakou wrote:
> On 10/18/22 12:02, Michal Orzel wrote:
> 
> Hi Michal,
> 
>> Hi Xenia,
>>
>> On 17/10/2022 19:32, Xenia Ragiadakou wrote:
>>>
>>>
>>> Currently the pa_range_info for the 52-bit pa range advertizes that the
>>> p2m root table consists of 8 concatenated tables at level 3, which does
>>> not make much sense.
>> I think the current code advertises 8 concatenated tables at level -1 
>> (sl0=3 -> root_level=-1)
>> which is obviously incorrect, but the commit msg should be updated.
> 
> I did the same mistake in my email but I did not want to hijack the 
> thread that 's why I did not come back to correct my error.
> According to the manual, to support 52-bit pa range with 4KB granule 
> with the root table at level -1, you need to set SL2=1 and SL0=0.
> SL0=3 configures the root table at level 3.

Which section are you reading? Looking at the definition of VTCR_EL2.SL0 
(D17-6375, ARM DDI 0487I.a), the field has different meaning depending 
on whether the feature TTST (Small translation table) is present.

SL0 would be reserved when TTST is not present. That said, it looks like 
LPA requires TTST.

> 
>> Funnily enough p2m_root_level is unsigned so it would lead to overflow

Did you mean underflow rather than overflow?

>> (p2m_root_level would end up with (1 << 32) - 1 instead of -1).
> 
> Actually, currently, there is no support at all in XEN neither for LPA 
> (LPA support for 4KB is not checked, VCTR DS and SL2 are not set etc) 
> nor level -1 (the root table level is determined only based on sl0, the 
> number of possible levels is hardcoded to 4 in many places etc). I don't 
> think that there is even support for accessing other than the first 
> table of concatenated root tables but I need to verify that (I assume 
> this based on the way LPAE_TABLE_INDEX_GS is implemented).

I am not sure I understand this. Are you saying that concatenation can 
be used for non-root table?

> 
> This entry is populated in the pa_range_info table just to prevent XEN 
> from falling into this
> if ( pa_range >= ARRAY_SIZE(pa_range_info) || 
> !pa_range_info[pa_range].pabits )
>          panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", 
> pa_range);

I think it would be worth to point out in the commit message that the 
value is not used so far. So this is only update for correctness.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 11:02:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 11:02:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424853.672588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkN0-0000VK-Up; Tue, 18 Oct 2022 11:02:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424853.672588; Tue, 18 Oct 2022 11:02:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkN0-0000VD-SG; Tue, 18 Oct 2022 11:02:50 +0000
Received: by outflank-mailman (input) for mailman id 424853;
 Tue, 18 Oct 2022 11:02:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ieme=2T=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1okkMz-0000V7-5d
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 11:02:49 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66219363-4ed4-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 13:02:48 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 1BE7E68C4E; Tue, 18 Oct 2022 13:02:44 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66219363-4ed4-11ed-8fd0-01056ac49cbb
Date: Tue, 18 Oct 2022 13:02:43 +0200
From: Christoph Hellwig <hch@lst.de>
To: Jan Beulich <jbeulich@suse.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Message-ID: <20221018110243.GA4655@lst.de>
References: <20221018082413.GA25785@lst.de> <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Tue, Oct 18, 2022 at 10:57:37AM +0200, Jan Beulich wrote:
> Shouldn't this then be xen_pv_domain() that you use here, and - if you
> really want IS_ENABLED() in addition - CONFIG_XEN_PV?

I'll need help from people that understand Xen better than me what
the exact conditions (and maybe also comments are).


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 11:12:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 11:12:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424860.672600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkWc-00024d-ST; Tue, 18 Oct 2022 11:12:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424860.672600; Tue, 18 Oct 2022 11:12:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkWc-00024W-Oq; Tue, 18 Oct 2022 11:12:46 +0000
Received: by outflank-mailman (input) for mailman id 424860;
 Tue, 18 Oct 2022 11:12:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XTa7=2T=aepfle.de=olaf@srs-se1.protection.inumbo.net>)
 id 1okkWc-00024Q-4F
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 11:12:46 +0000
Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de
 [85.215.255.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca058cda-4ed5-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 13:12:44 +0200 (CEST)
Received: from sender by smtp.strato.de (RZmta 48.2.0 AUTH)
 with ESMTPSA id z9e8dfy9IBCgpG5
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
 (Client did not present a certificate);
 Tue, 18 Oct 2022 13:12:42 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca058cda-4ed5-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1666091562;
    s=strato-dkim-0002; d=aepfle.de;
    h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date:
    From:Subject:Sender;
    bh=LtcbZ9Iww575aSLIrkBg79ikIdVbb2hej8vnSDJr77Q=;
    b=tKE5Cc6UXOo5coTpnKDUbm3BwCfN7cKEPctjvIR10G6e0MBvSyOYtJTaU9QznPhJlm
    k7DW/yzD4Z30scpzGT+bNLMOPnkKWxlmeLJHOQT8fcZqiBUfY+xp8DbXkV+mtq9Qc2aP
    sVKSTK1jMtIre5IqM09ZdSm5CSX7XOtjlaywy2gUlt0bqNXg9Ldcn6/ZgFYYZ3yIDSIG
    5ela96sFSVsuTIPy9PXgqC70a6WsxITox1JVLF9TGnyG4AiBDdU0E1jWhbexbBoAMjSK
    Tmpg3TLY3B2muIWFVCHqIy9taktTWloTW7cIAMRb9jUf1oPSPN65e7eIB/4r1zZoCAf+
    xieQ==
Authentication-Results: strato.com;
    dkim=none
X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX2j/OiDv7LX1ITFkr8sRtLhQJY8wcRJ+GvY"
X-RZG-CLASS-ID: mo00
Date: Tue, 18 Oct 2022 13:12:35 +0200
From: Olaf Hering <olaf@aepfle.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>, Oskari
 Pirhonen <xxc3ncoredxx@gmail.com>, mathieu.desnoyers@efficios.com,
 rharwood@redhat.com, samuel.thibault@ens-lyon.org,
 debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <20221018131235.5e70f0bc.olaf@aepfle.de>
In-Reply-To: <20221017103532.845293-1-liu.denton@gmail.com>
References: <20221017103532.845293-1-liu.denton@gmail.com>
X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen.
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/E6wAUjBaT41rYmMIlhKgAKC";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/E6wAUjBaT41rYmMIlhKgAKC
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Mon, 17 Oct 2022 03:35:32 -0700 Denton Liu <liu.denton@gmail.com>:

> A user may wish to use an image that is not sorted as the "latest"
> version as the top-level entry.=20

Correct.

What is really required is some form of file pattern matching and to use --=
id=3D in "menuentry title" commands.

That way one can have the "latest" of /boot/${short_pattern} as default ent=
ry, in case there are multiple variants of files matching ${short_pattern}.=
 The pattern gets enabled with "grub-set-default pattern".

Based on this, I have to NACK your patch.


Olaf

--Sig_/E6wAUjBaT41rYmMIlhKgAKC
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmNOiiMACgkQ86SN7mm1
DoA4mRAAnXfdszjjzJS++3/9jLYMrjGScSHdTCxMkwofUdmS7PxjvHEI1Xofs0t5
IdjAT2g7brdzynpd2y1PDYAcs9OXI5lowh+qWsPll9OVvBFppQoyg6dzAAmue6N3
XWB8vyUgemZaLjphOsUkGRcFpafTF/8ChX8En+CkqLggDS6+wzGJAFnEL1lh5UuY
ZBvnNHThRZ1FXQa/EOnDsdIXlAgu4tIeo5F6BY8acpM4rDb6q9LsMvzanKOkJoqv
ckfurfIqvTjm76c+lmKJ5tcWsT/ouHuJ7BuRsWsyjAJ1dyw34Pj1LyTQ38DSP6s3
DBidiRbApGz0Dn2Fzn07QSx2hRXqYqR3C7O7/ATHwbVQNdxyc0PG9ggCPZT6RyfG
ia//22r1dNSE60Efc75Fbx2ru8MLokq1Uzf2GBfNPETF8IHTtJtCmAZs+9HVELbP
t7Ugwyt4ga1I/EpKYEZpiXQBMVFhIROynFSXS9guNFWf2QrlXTTMBWTr7/TJBlqt
s41KwF0SBNMD8rOs3rESwfyZjUTewaM1avm5ccjQcAVK87/CyBVXFbPXFIxRfWjg
ysR/zYQt/DiiUBinNSB+BRpjOeHteyJMFBKlsUX8WDyDRIF4jFsoYo4vHlywd97C
0BNjmZ4mypYVJXURcDHP5xs13aABYj2Q/9saYp1PONk+xtvvUY0=
=Myb3
-----END PGP SIGNATURE-----

--Sig_/E6wAUjBaT41rYmMIlhKgAKC--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 11:17:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 11:17:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424866.672610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkb7-0002np-D0; Tue, 18 Oct 2022 11:17:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424866.672610; Tue, 18 Oct 2022 11:17:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okkb7-0002ni-AU; Tue, 18 Oct 2022 11:17:25 +0000
Received: by outflank-mailman (input) for mailman id 424866;
 Tue, 18 Oct 2022 11:17:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xNhK=2T=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1okkb6-0002nb-58
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 11:17:24 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 6f4a4ab0-4ed6-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 13:17:22 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54DFA113E;
 Tue, 18 Oct 2022 04:17:27 -0700 (PDT)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5D5633F7D8;
 Tue, 18 Oct 2022 04:17:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f4a4ab0-4ed6-11ed-8fd0-01056ac49cbb
Date: Tue, 18 Oct 2022 12:17:06 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: marc.zyngier@arm.com, eric.auger@redhat.com, james.morse@arm.com,
 alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com,
 will@kernel.org, linux-arm-kernel@lists.infradead.org,
 kvmarm@lists.cs.columbia.ed, Julien Grall <julien@xen.org>,
 "stefanos@xilinx.com" <stefanos@xilinx.com>, Bertrand Marquis
 <Bertrand.Marquis@arm.com>, "xen-devel@lists.xenproject.org"
 <xen-devel@lists.xenproject.org>
Subject: Re: Need guidance regarding emulation of GICR_PENDBASER and
 GICR_PROPBASER registers on Aarch32
Message-ID: <20221018121706.6bd88dd1@donnerap.cambridge.arm.com>
In-Reply-To: <b4d413eb-2956-b167-323f-31d82da737dd@amd.com>
References: <b4d413eb-2956-b167-323f-31d82da737dd@amd.com>
Organization: ARM
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 18 Oct 2022 11:38:00 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi Ayan,

> Greetings. I am trying to port Xen on Cortex-R52.

Oh dear, my condolences.

> I am trying to understand whether GICR_PENDBASER and GICR_PROPBASER=20
> exist on Aarch32 platform.

Those are GIC MMIO registers, so they exist regardless of which instruction
set the CPU is using. There is really nothing architecture wise that would
restrict access.

> Looking at the definition of the registers in "Arm IHI ID020922", (from=20
> my understanding) it seems the registers can be accessed in 64bit mode on=
ly.

Not really, the GIC spec says that those registers are 64-bit registers.
What that means is explained in section "12.1.3 GIC memory-mapped
register access", of particular interest is the paragraph starting with:
"In addition, in system where one or more PE supports AArch32: ...."

> Please confirm if my understanding is correct or not.
>=20
> This seems unlike GICR_TYPER which might be accessed as two 32 bit=20
> registers. The reason being the upper 32bits represent affinity and the=20
> lower 32 bits represent everything else.

There is really not much difference access-wise between TYPER and BASER.
You can always access them as two words, and this is the recommended way
to do so on AArch32, or actually in both ISAs. Check out Jean-Philippe's
comment here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arc=
h/arm/include/asm/arch_gicv3.h#n135

In particular the BASE registers don't require atomic accesses, since they
only become effective later on, as it's not allowed to write to them when
LPIs are enabled. So there is no problem in updating the upper and lower
half in separate steps.

> If GICR_PENDBASER and GICR_PROPBASER are accessible in 64 bit mode only,=
=20
> then we Xen can't emulate them on Aarch32 as ISS is invalid (for ldrd,=20
> strd instructions).

If the guest is accessing them using ldrd/strd (which is architecturally
valid, but not easily virtualisable), then you cannot do anything about
it, and would need to change the guest to not do so. See above what Linux
does: always access them in two chunks, so it works everywhere.

Cheers,
Andre

> However, looking at the following commit in kernel, I am a bit confused.
>=20
> commit 0aa1de57319c4e023187aca0d59dd593a96459a8
> Author: Andre Przywara <andre.przywara@arm.com>
> Date:=C2=A0=C2=A0 Fri Jul 15 12:43:29 2016 +0100
>=20
>  =C2=A0=C2=A0=C2=A0 KVM: arm64: vgic: Handle ITS related GICv3 redistribu=
tor registers
>=20
>  =C2=A0=C2=A0=C2=A0 In the GICv3 redistributor there are the PENDBASER an=
d PROPBASER
>  =C2=A0=C2=A0=C2=A0 registers which we did not emulate so far, as they on=
ly make sense
>  =C2=A0=C2=A0=C2=A0 when having an ITS. In preparation for that emulate t=
hose MMIO
>  =C2=A0=C2=A0=C2=A0 accesses by storing the 64-bit data written into it i=
nto a variable
>  =C2=A0=C2=A0=C2=A0 which we later read in the ITS emulation.
>  =C2=A0=C2=A0=C2=A0 We also sanitise the registers, making sure RES0 regi=
ons are respected
>  =C2=A0=C2=A0=C2=A0 and checking for valid memory attributes.
>=20
> <<<<< code >>>
> REGISTER_DESC_WITH_LENGTH(GICR_PROPBASER,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 vgic_mmio_read_raz, vgic_mmio_write_wi, 8,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 vgic_mmio_read_propbase, vgic_mmio_write_propbase, 8,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 VGIC_ACCESS_64bit | VGIC_ACCESS_32bit),
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 REGISTER_DESC_WITH_LENGTH(GIC=
R_PENDBASER,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 vgic_mmio_read_raz, vgic_mmio_write_wi, 8,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 vgic_mmio_read_pendbase, vgic_mmio_write_pendbase, 8,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 VGIC_ACCESS_64bit | VGIC_ACCESS_32bit),
> <<<< code >>>>
>=20
> The register regions are defined in arch/arm64/kvm/vgic/vgic-mmio-v3.c=20
> and the registers seem accessible in both 64 bit and 32 bit modes.
> Please let me know if GICR_PENDBASER and GICR_PROPBASER are accessible=20
> in 32 bit mode.
>=20
> Kind regards,
> Ayan



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 11:51:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 11:51:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424943.672657 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okl7g-0000l2-MB; Tue, 18 Oct 2022 11:51:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424943.672657; Tue, 18 Oct 2022 11:51:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okl7g-0000kv-JU; Tue, 18 Oct 2022 11:51:04 +0000
Received: by outflank-mailman (input) for mailman id 424943;
 Tue, 18 Oct 2022 11:51:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j5CF=2T=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1okl7f-0000jl-Dw
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 11:51:03 +0000
Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com
 [2a00:1450:4864:20::636])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 23e051bc-4edb-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 13:51:02 +0200 (CEST)
Received: by mail-ej1-x636.google.com with SMTP id w18so31510319ejq.11
 for <xen-devel@lists.xenproject.org>; Tue, 18 Oct 2022 04:51:02 -0700 (PDT)
Received: from [192.168.1.93] (adsl-214.109.242.138.tellas.gr.
 [109.242.138.214]) by smtp.gmail.com with ESMTPSA id
 e2-20020a170906314200b00730df07629fsm7590326eje.174.2022.10.18.04.51.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 18 Oct 2022 04:51:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23e051bc-4edb-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=mZqYEXNeeyCRWnmLXFa73tj9RFkXn2K6wtJKVYhXjuw=;
        b=XDObaZs8RqivC0M2f4zsL2Y/MJKwgDZM0wmACDD5d4CHcSzul7QEJCbfMlnPAFRUJb
         OwEIqfLEWhk+Q36taCWdilweCqKU/kNW6t8YT6EbpWRCVfSrCWcE4ipBV0GBOekV0HrO
         C4n3LNe58T9OEi/UUUwpASVKjMuJzUkZMF2QmR3Z7EfQ+o3pQLurHIfxgryHGAL+nmhA
         MEORY6Besa/i3o5RwXIkENyAuUay4+M4NW8uti18m3FF4e8vq7usJKOpbnb/UPjC9vY0
         r5vyVU25EiATNJPscUxiDrbeL8t8xglblupoc/LwLoSN1UaRq1E5zis27TI+cc0NFo9U
         esrg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=mZqYEXNeeyCRWnmLXFa73tj9RFkXn2K6wtJKVYhXjuw=;
        b=n9AD6eubwdIo71/CdAMCVY7KrBdjjTENB5/g6c+c6OgHmNrni0LLu6lZkyNL/9Yocn
         UwpomDwUsTeOLZtVwSpN7OXaYixXR5kJUZq37e1ihxbY5UKI/76ToSF3+1VvLFqqqhrw
         OH9clWn1U+5lSC0IJ4fSF4rGaQVwbrFU6TEzmhkk3tl3g+KwZbqgAtnssnAO4gMLwS6t
         BGtO8ruUwbjHK7v4LBVdMDrytPTTrxf1ApMiABlp1VF2F756/4EE23/EhxUqY77JjgCO
         SZvFdbn5Me1eSs0HHgJZVew8Guq/djco23yuo1lmjvQvKwB52g4nF5MNKk4b20VaFWjN
         cVPw==
X-Gm-Message-State: ACrzQf38l4cDcfAuWzO20rqzUN550und1dFu50sIXn3kUIKZNit8q/ob
	VuQcsaixEFblNBDM7RgiJ2w=
X-Google-Smtp-Source: AMsMyM4A41SEvGlHEQv3ljC0LoiDOH/miep9IJe79rbMqB4a1n9C/c+cG1Z8SoUpVB7oTdlmUa54AA==
X-Received: by 2002:a17:906:9bc3:b0:78d:816f:3743 with SMTP id de3-20020a1709069bc300b0078d816f3743mr2106835ejc.380.1666093862269;
        Tue, 18 Oct 2022 04:51:02 -0700 (PDT)
Message-ID: <95183fbb-f578-4c87-a875-a1cf0437e7c0@gmail.com>
Date: Tue, 18 Oct 2022 14:51:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Michal Orzel <michal.orzel@amd.com>,
 xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017173209.236781-1-burzalodowa@gmail.com>
 <ddef5ab7-c217-546d-0e5d-294465a49586@amd.com>
 <65b46c0e-3499-ce6c-dcd6-76c506115c6e@gmail.com>
 <fbc42d87-e96f-3343-cc63-a14564549c02@xen.org>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <fbc42d87-e96f-3343-cc63-a14564549c02@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10/18/22 13:56, Julien Grall wrote:

Hi Julien,

> Hi Xenia,
> 
> On 18/10/2022 11:27, Xenia Ragiadakou wrote:
>> On 10/18/22 12:02, Michal Orzel wrote:
>>
>> Hi Michal,
>>
>>> Hi Xenia,
>>>
>>> On 17/10/2022 19:32, Xenia Ragiadakou wrote:
>>>>
>>>>
>>>> Currently the pa_range_info for the 52-bit pa range advertizes that the
>>>> p2m root table consists of 8 concatenated tables at level 3, which does
>>>> not make much sense.
>>> I think the current code advertises 8 concatenated tables at level -1 
>>> (sl0=3 -> root_level=-1)
>>> which is obviously incorrect, but the commit msg should be updated.
>>
>> I did the same mistake in my email but I did not want to hijack the 
>> thread that 's why I did not come back to correct my error.
>> According to the manual, to support 52-bit pa range with 4KB granule 
>> with the root table at level -1, you need to set SL2=1 and SL0=0.
>> SL0=3 configures the root table at level 3.
> 
> Which section are you reading? Looking at the definition of VTCR_EL2.SL0 
> (D17-6375, ARM DDI 0487I.a), the field has different meaning depending 
> on whether the feature TTST (Small translation table) is present.
> 
> SL0 would be reserved when TTST is not present. That said, it looks like 
> LPA requires TTST.

I 'm referring to the table Table D8-12 "4KB granule, determining stage 
2 initial lookup level" (D8-5103, ARM DDI 0487I.a).
With 4KB granule, for having the root table at level 3, TTST is 
required, yes.

> 
>>
>>> Funnily enough p2m_root_level is unsigned so it would lead to overflow
> 
> Did you mean underflow rather than overflow?
> 
>>> (p2m_root_level would end up with (1 << 32) - 1 instead of -1).
>>
>> Actually, currently, there is no support at all in XEN neither for LPA 
>> (LPA support for 4KB is not checked, VCTR DS and SL2 are not set etc) 
>> nor level -1 (the root table level is determined only based on sl0, 
>> the number of possible levels is hardcoded to 4 in many places etc). I 
>> don't think that there is even support for accessing other than the 
>> first table of concatenated root tables but I need to verify that (I 
>> assume this based on the way LPAE_TABLE_INDEX_GS is implemented).
> 
> I am not sure I understand this. Are you saying that concatenation can 
> be used for non-root table?

No, the contrary. I cannot see how it can work out of the box given the 
current implementation. Because the mask applied to get the table index 
is limited to the size of a single table.

> 
>>
>> This entry is populated in the pa_range_info table just to prevent XEN 
>> from falling into this
>> if ( pa_range >= ARRAY_SIZE(pa_range_info) || 
>> !pa_range_info[pa_range].pabits )
>>          panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", 
>> pa_range);
> 
> I think it would be worth to point out in the commit message that the 
> value is not used so far. So this is only update for correctness.

Sure.
Do I need a Fixes tag even though the previous code, effectively, was 
not breaking anything?

> 
> Cheers,
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 11:52:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 11:52:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424953.672669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okl8s-0001Mh-1M; Tue, 18 Oct 2022 11:52:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424953.672669; Tue, 18 Oct 2022 11:52:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okl8r-0001Ma-Tx; Tue, 18 Oct 2022 11:52:17 +0000
Received: by outflank-mailman (input) for mailman id 424953;
 Tue, 18 Oct 2022 11:52:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RnJu=2T=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okl8q-0001MJ-Fu
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 11:52:16 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2054.outbound.protection.outlook.com [40.107.105.54])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f24fc54-4edb-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 13:52:15 +0200 (CEST)
Received: from AM7PR02CA0012.eurprd02.prod.outlook.com (2603:10a6:20b:100::22)
 by AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct
 2022 11:52:13 +0000
Received: from AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:100:cafe::60) by AM7PR02CA0012.outlook.office365.com
 (2603:10a6:20b:100::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17 via Frontend
 Transport; Tue, 18 Oct 2022 11:52:13 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT011.mail.protection.outlook.com (100.127.140.81) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 18 Oct 2022 11:52:13 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Tue, 18 Oct 2022 11:52:13 +0000
Received: from 1f90a26ddfc1.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4633CA88-8BCD-4FF6-989D-77A0C6EC6522.1; 
 Tue, 18 Oct 2022 11:52:06 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1f90a26ddfc1.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 11:52:06 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAWPR08MB9966.eurprd08.prod.outlook.com (2603:10a6:102:35e::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct
 2022 11:52:03 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 11:52:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f24fc54-4edb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=LiiMFszQjL0A/X4bVjNLIZx2fPIpPjySLre0OIWsYFqcnoKl+zJdXT2cbPDGUQMR4pS+c3QPY7UOE2dZXoED798WyhYt6TFFVu7WQWkSxpAUCwQCpJ8/1OkSHstJXBBY8y/uR3PlgGprLMafqJgp+08EbN9FFYYIoI+Re7swxS/UNfgQpgzTRfuKAYQpj7FUXSk4Jg1iS41Ti3740DkiaGIx0D8uHjRidIiEwYf9ha0M7QuwdXGzCgzq38EmySSIkijHNjFqrjX/watOxupPioXYaJ7JYIQ5J70KSw2AIJWg6+bUaW/cM/v7GXb+0nKIILnR1obV+g7YO3YtBnhtMQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EsfXy0BKQDopchh9sqTepaGzECim6z7Urd9YPkG1nM4=;
 b=JBi6cjdMgYcbZ86pUQMhzwraU2TtO9aGzFDGBUqcjI/fbSB4JYbYe446SkCBimLLsJc0ungxW2OVQdcSXVwxwTT0/obwrlA8lC62dk2qWBvr84eGhQvnokccMyE0A+IvvW3QDuKU1w0jBQi+W/uoexZFjNIevCqC57xwSOfkt0V3EDfCtkx/aDtcqUvN4XSXzXyialxeEW02PmLNgbqqz+eWzMMwdWiKujEULw7r0h4S/y2LhZ81jmgU4gUBn+iqZW3xhEYA1c/nQrSC8lDHncUjOJpJAEM1qQTN5wi6GwffjsAH7CMiMVX6s4AsqwKCeA6b/NMqlgihj7qmxcNdyA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EsfXy0BKQDopchh9sqTepaGzECim6z7Urd9YPkG1nM4=;
 b=2Dp1n6+ptEdbzoJH+2ugOhMqRaKPq1L/3J2Z3cJBT9bb36r1slbHIhQg8WuQMjRpCK1N/tX6hh1ePT1/p2MOg/HY83mTff701iHqcfYH/V1mqZohqaRHCb1pJgnOgEQ8ypa/cgsPTiaK6hP0Z5fw3rHviQ103sKaod+w4M6tnS4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: c7d54cf6462deb50
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PDlJHqKcM1x0/RGowbmw/I3bKzQ4jBGpRGfFYxSEYrby1yYvPiMMOgcRWkFdCADtfEA8Mw0vPqfkw0uOn2RVGma3RLVBl/nuKFUfyuJnvmmCkRLcuWTWE2+WTxiwmDjkuuseqh/cSXYouguoSM5PrvTq6LZgTve1pY7plBgrDZCK1lEcyR3Nd2A8avUbU/4Hkun05YazOGHOQ8reWA/OFTVhQ4mtLyWL9WTrvjBQgANDOjWXEO4i7DdzB6AmmAHAy7GgOe0P2TPNWN5vp1BXA6hjKKaJul0JzVG9WKKqsBsDwpCo/HFSPADWQD34CF15yZDhhWrHux/Wj6sr3T363A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EsfXy0BKQDopchh9sqTepaGzECim6z7Urd9YPkG1nM4=;
 b=IXH3ZNkz3DUKnvMo7UGeB0I/3slMsBMWLplJh3w3H9Yy7qbx9SEqGcNtFmRTmLUtz4uJKZwVm2dyGZ90Xbhv/WDA3ktiXs1Vvt8kbGirZe5oRHZKFDvt7WIMnW1rM3oRJ9aN3sVIx8OfSYoF76DvgOVvQ6e2n1iDOXc880NmV/U2493PbO2RMAIdVH60OptW9hlZnulyIHsmWuEeZGOzwkeaOuNY97pOUXDhZv0t+uEU8xrFvOpIze5TtBJhxRM7ckrudWISoGYPDnhtxDy1oEUkxhX1IbMw/FK3twD0kzAYMd98VYXK88xh1eHvLWIQiD24wPdSYd2gW30Gcb9VNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EsfXy0BKQDopchh9sqTepaGzECim6z7Urd9YPkG1nM4=;
 b=2Dp1n6+ptEdbzoJH+2ugOhMqRaKPq1L/3J2Z3cJBT9bb36r1slbHIhQg8WuQMjRpCK1N/tX6hh1ePT1/p2MOg/HY83mTff701iHqcfYH/V1mqZohqaRHCb1pJgnOgEQ8ypa/cgsPTiaK6hP0Z5fw3rHviQ103sKaod+w4M6tnS4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH 1/2] arm/p2m: Rework p2m_init()
Thread-Topic: [PATCH 1/2] arm/p2m: Rework p2m_init()
Thread-Index: AQHY4lx8NcMOBRjDdEuRGdu/FdZOvq4UC1kA
Date: Tue, 18 Oct 2022 11:52:03 +0000
Message-ID: <C324FE00-226A-458B-82BD-485313414F0B@arm.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-2-andrew.cooper3@citrix.com>
In-Reply-To: <20221017191237.11079-2-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAWPR08MB9966:EE_|AM7EUR03FT011:EE_|AS8PR08MB8659:EE_
X-MS-Office365-Filtering-Correlation-Id: 553d66bf-2c71-4ed4-1aa8-08dab0ff324e
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 kk6/UkN2RRGE7I7v1DdpfE+7CxyEJ2fp+lOrk5p1C403urum3/Re+bryggZQJM5urcUUXt39iO+YgrX/H3HqYK3HDsuPj67gHr9JLFPjFfyOMHUpl0xGIgBIf9DkyZGxeXWkLAKGiHtnz+Oet+X2GVjSq1GBvHpgfZHbSYhlTIuSY2P4bSwRnWnjFl9LaKGAeKjTjAusqsy5YoXftO6AUD6UhQIwpQh2bQOzPPmfCAL5VO9Vy4R6vVjzZV+J5glm/krG8p8+H3LRzrCK61VaQifjc3dUAKwrqnMxzv9zau6BtyZgLj34f0+9HkmYrXpDI0DO+sTyw/9fKZSbfHiPSBQpSUpmRVyrLDMZYVIAsJ6mvQeeCAknuF7C0OSZnGQvKN+JlFGRNvkE9EtZgtKvouZ4Iag71oFg4fJuu3wBAIw/bztZxVtsLF96UX214JHSJBN6koF47ybZqzoGW7bhTnY22T/I13DTRBOFbSgdbcDLLjJh/rxsyqhl+m0ZPyC1EZGZcvNxq4SkLGXhmgcPKwXTDez6eV9P6tRXxRc7wyhf8484hpp363c+O6bY+Mjm73vm/t19xLVae3Gwm2qgGjiB5/t1gT7+auXTNIV+81tfe57btlKND+kPhfPggX2bsUHk+X8g/6qyFpUjsveR4J2As6i36a8+k5acTb+ZTaxTYbNgTGOPFRXJgcTEVT6Qum7//OQbHyHbfNQSI+5tmPlZl5gHiHnvUlH5H47a1JOnWdI/qMEPRdC59gzsJZY4igtNbIgIJqYagmN8ZQsYqFCo4KSbqua6FlJtH1EEa2E=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(346002)(376002)(136003)(451199015)(76116006)(186003)(2616005)(38070700005)(83380400001)(86362001)(5660300002)(38100700002)(122000001)(2906002)(54906003)(64756008)(4326008)(41300700001)(8676002)(478600001)(6512007)(26005)(6506007)(316002)(53546011)(66446008)(6916009)(66476007)(66556008)(91956017)(66946007)(8936002)(6486002)(36756003)(71200400001)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <C2E8B52F9ED8194495832549F2F5C6C4@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9966
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7c36276e-e939-4a5d-cc0c-08dab0ff2c6f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xwQUpn698UdL/2mtnfDB3j2IpU+tlYqO2KuQD4dWzYHaJTeK/fQXGGH1c1TieqBH75Tnwb6IY8nPfXgMKdypxIxe8xJWxk7EmWjAYCu2ZnZSODm78JJSJua8AAyjD9KKjPBUK7MECC1VPdXoc+DHZjC3/LyE2zw2JiqtKvd3QZXOPsWCHoOItF8Nm7z4zwCvk8EziPji88ymHsHGbYOkK7Do3SP8dvsMsvNHqSX2lVsnwh3WbsfjZw3AD+Yaecx8HtAOREkDDU0GFN6qBxBUgzZG11bIVdgtvzBbszLjeMeYYdCqXxKkE+yrIe/H+L0QqoBIver14/8KWfMVcqlF84PhpX30WD8h5tEtbk2tu6gAvWTYVk2ndnBu4yv9MIBpJg70Npl8Py0I4Hi8f/gZgtgZXBGijYDzUA+X/JZlUHJJozEPFqCXy5eaBsfDvApapoXMev2wTFVavJgBQ94go6ho8JF6pfpXjbQ8QJgGYrUlB/w0NhDU1Nzziaph4Cy/vXE7puytEfarXHpwXjTLbDFm8O34wTp5WVGcBySDavoNlghFzbWiYvb4J+tB5BeaHoWOc29xj9PnAkZwApu+q6kFH8zr1CqRHjxQshj10GoAywj+M+T9G3W+uVnmXfopnVs9v2u7XMI91o/JAfSCjgh/arZUyCPgggcLIXSb70QU9kChk9w/8vxJ0/azc13+3OVtCDjcUNx9BSsSIRL7BxuExEZFeY4P3N5cAOhfUB0B7rmDNjsmCUOgdSHIzs/LxWLMWzp/6ns5sv5pV9Zseg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(36756003)(33656002)(82310400005)(36860700001)(86362001)(82740400003)(5660300002)(54906003)(2906002)(2616005)(186003)(336012)(83380400001)(47076005)(356005)(81166007)(6506007)(53546011)(316002)(6512007)(6486002)(70586007)(70206006)(478600001)(40480700001)(6862004)(4326008)(8936002)(41300700001)(26005)(40460700003)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 11:52:13.3006
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 553d66bf-2c71-4ed4-1aa8-08dab0ff324e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8659

SGkgQW5kcmV3LA0KDQo+IE9uIDE3IE9jdCAyMDIyLCBhdCAyMDoxMiwgQW5kcmV3IENvb3BlciA8
QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBwMm1faW5pdCgpIGlzIG1v
c3RseSB0cml2aWFsIGluaXRpYWxpc2F0aW9uLCBidXQgaGFzIHR3byBmYWlsYWJsZSBvcGVyYXRp
b25zDQoNCk1heWJlIHNheSDigJx0d28gb3BlcmF0aW9ucyB0aGF0IGNhbiBmYWls4oCdIGFzIHRo
ZSBmYWlsYWJsZSBkb2VzIHNlZW0gZnVsbHkgcmlnaHQgOi0pDQpCdXQgSSBhbSBub3QgYSBuYXRp
dmUgc3BlYWtlciBzbyBJIHdpbGwgbGV0IHRoYXQgdG8geW91Lg0KDQo+IHdoaWNoIGFyZSBvbiBl
aXRoZXIgc2lkZSBvZiB0aGUgYmFja3BvaW50ZXIgdHJpZ2dlciBmb3IgdGVhcmRvd24gdG8gdGFr
ZQ0KPiBhY3Rpb25zLg0KPiANCj4gcDJtX2ZyZWVfdm1pZCgpIGlzIGlkZW1wb3RlbnQgd2l0aCBh
IGZhaWxlZCBwMm1fYWxsb2Nfdm1pZCgpLCBzbyByZWFycmFuZ2UNCj4gcDJtX2luaXQoKSB0byBw
ZXJmb3JtIGFsbCB0cml2aWFsIHNldHVwLCB0aGVuIHNldCB0aGUgYmFja3BvaW50ZXIsIHRoZW4N
Cj4gcGVyZm9ybSBhbGwgZmFpbGFibGUgc2V0dXAuDQo+IA0KPiBUaGlzIHdpbGwgc2ltcGxpZnkg
YSBmdXR1cmUgYnVnZml4IHdoaWNoIG5lZWRzIHRvIGFkZCBhIHRoaXJkIGZhaWxhYmlsZQ0KPiBv
cGVyYXRpb24uDQo+IA0KPiBObyBwcmFjdGljYWwgY2hhbmdlLg0KPiANCj4gU2lnbmVkLW9mZi1i
eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NClJldmlld2VkLWJ5
OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQoNCkNoZWVycw0K
QmVydHJhbmQNCg0KPiAtLS0NCj4gQ0M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlA
a2VybmVsLm9yZz4NCj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IENDOiBW
b2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IENDOiBCZXJ0
cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+DQo+IENDOiBIZW5yeSBXYW5n
IDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IC0tLQ0KPiB4ZW4vYXJjaC9hcm0vcDJtLmMgfCAyNCAr
KysrKysrKysrKystLS0tLS0tLS0tLS0NCj4gMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo
KyksIDEyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0u
YyBiL3hlbi9hcmNoL2FybS9wMm0uYw0KPiBpbmRleCBmMTc1MDBkZGYzYTMuLjY4MjZmNjMxNTA4
MCAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jDQo+ICsrKyBiL3hlbi9hcmNoL2Fy
bS9wMm0uYw0KPiBAQCAtMTc1NCw3ICsxNzU0LDcgQEAgdm9pZCBwMm1fZmluYWxfdGVhcmRvd24o
c3RydWN0IGRvbWFpbiAqZCkNCj4gaW50IHAybV9pbml0KHN0cnVjdCBkb21haW4gKmQpDQo+IHsN
Cj4gICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0gPSBwMm1fZ2V0X2hvc3RwMm0oZCk7DQo+IC0g
ICAgaW50IHJjID0gMDsNCj4gKyAgICBpbnQgcmM7DQo+ICAgICB1bnNpZ25lZCBpbnQgY3B1Ow0K
PiANCj4gICAgIHJ3bG9ja19pbml0KCZwMm0tPmxvY2spOw0KPiBAQCAtMTc2MywxMSArMTc2Myw2
IEBAIGludCBwMm1faW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPiAgICAgSU5JVF9QQUdFX0xJU1Rf
SEVBRCgmZC0+YXJjaC5wYWdpbmcucDJtX2ZyZWVsaXN0KTsNCj4gDQo+ICAgICBwMm0tPnZtaWQg
PSBJTlZBTElEX1ZNSUQ7DQo+IC0NCj4gLSAgICByYyA9IHAybV9hbGxvY192bWlkKGQpOw0KPiAt
ICAgIGlmICggcmMgIT0gMCApDQo+IC0gICAgICAgIHJldHVybiByYzsNCj4gLQ0KPiAgICAgcDJt
LT5tYXhfbWFwcGVkX2dmbiA9IF9nZm4oMCk7DQo+ICAgICBwMm0tPmxvd2VzdF9tYXBwZWRfZ2Zu
ID0gX2dmbihVTE9OR19NQVgpOw0KPiANCj4gQEAgLTE3ODMsOCArMTc3OCw2IEBAIGludCBwMm1f
aW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPiAgICAgcDJtLT5jbGVhbl9wdGUgPSBpc19pb21tdV9l
bmFibGVkKGQpICYmDQo+ICAgICAgICAgIWlvbW11X2hhc19mZWF0dXJlKGQsIElPTU1VX0ZFQVRf
Q09IRVJFTlRfV0FMSyk7DQo+IA0KPiAtICAgIHJjID0gcDJtX2FsbG9jX3RhYmxlKGQpOw0KPiAt
DQo+ICAgICAvKg0KPiAgICAgICogTWFrZSBzdXJlIHRoYXQgdGhlIHR5cGUgY2hvc2VuIHRvIGlz
IGFibGUgdG8gc3RvcmUgdGhlIGFuIHZDUFUgSUQNCj4gICAgICAqIGJldHdlZW4gMCBhbmQgdGhl
IG1heGltdW0gb2YgdmlydHVhbCBDUFVTIHN1cHBvcnRlZCBhcyBsb25nIGFzDQo+IEBAIC0xNzk3
LDEzICsxNzkwLDIwIEBAIGludCBwMm1faW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPiAgICAgICAg
cDJtLT5sYXN0X3ZjcHVfcmFuW2NwdV0gPSBJTlZBTElEX1ZDUFVfSUQ7DQo+IA0KPiAgICAgLyoN
Cj4gLSAgICAgKiBCZXNpZGVzIGdldHRpbmcgYSBkb21haW4gd2hlbiB3ZSBvbmx5IGhhdmUgdGhl
IHAybSBpbiBoYW5kLA0KPiAtICAgICAqIHRoZSBiYWNrIHBvaW50ZXIgdG8gZG9tYWluIGlzIGFs
c28gdXNlZCBpbiBwMm1fdGVhcmRvd24oKQ0KPiAtICAgICAqIGFzIGFuIGVuZC1vZi1pbml0aWFs
aXphdGlvbiBpbmRpY2F0b3IuDQo+ICsgICAgICogIlRyaXZpYWwiIGluaXRpYWxpc2F0aW9uIGlz
IG5vdyBjb21wbGV0ZS4gIFNldCB0aGUgYmFja3BvaW50ZXIgc28NCj4gKyAgICAgKiBwMm1fdGVh
cmRvd24oKSBhbmQgZnJpZW5kcyBrbm93IHRvIGRvIHNvbWV0aGluZy4NCj4gICAgICAqLw0KPiAg
ICAgcDJtLT5kb21haW4gPSBkOw0KPiANCj4gLSAgICByZXR1cm4gcmM7DQo+ICsgICAgcmMgPSBw
Mm1fYWxsb2Nfdm1pZChkKTsNCj4gKyAgICBpZiAoIHJjICkNCj4gKyAgICAgICAgcmV0dXJuIHJj
Ow0KPiArDQo+ICsgICAgcmMgPSBwMm1fYWxsb2NfdGFibGUoZCk7DQo+ICsgICAgaWYgKCByYyAp
DQo+ICsgICAgICAgIHJldHVybiByYzsNCj4gKw0KPiArICAgIHJldHVybiAwOw0KPiB9DQo+IA0K
PiAvKg0KPiAtLSANCj4gMi4xMS4wDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 12:02:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 12:02:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424972.672680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oklIR-0003DL-C8; Tue, 18 Oct 2022 12:02:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424972.672680; Tue, 18 Oct 2022 12:02:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oklIR-0003DE-9A; Tue, 18 Oct 2022 12:02:11 +0000
Received: by outflank-mailman (input) for mailman id 424972;
 Tue, 18 Oct 2022 12:02:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=llzQ=2T=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1oklIP-0003BP-5s
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 12:02:09 +0000
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id af5172aa-4edc-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 14:02:07 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 85AC25C00C0;
 Tue, 18 Oct 2022 08:02:05 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 18 Oct 2022 08:02:05 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 18 Oct 2022 08:02:01 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af5172aa-4edc-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1666094525; x=
	1666180925; bh=O2/dMz8NgpCHX1Sqp3OOccZ2LMUa8ynU7I6zNQmgh+0=; b=l
	70icwUpCYe/Aui9OGIpsAdTKFMrKO8qR1ZA95p2xUAPSBHbPaMwalL10N/XoI6DI
	6ZYD77TVYc7dvLvHSH9+Tr/quqSR4pVkgTMPy6WR2nxZYP8Ut0Xs2poaa5xessjT
	f0uFfDB2lp/qV5dIt1ZKRPcKvLNGIttJ1uOfymbM7q1E9tAMAED2VMWUfz6gcSyo
	Wcp2tBrYDTJF65c5gzf+BZ4ngpAAkq+049NxQB81884loVMp1TgjNwX7uArKJEl2
	C/HyOxcqSPNVw/zW1CAw+i1jfgB2OavopVZZbsW7XAPX+zrRKPdZYK8ma4BcaHMQ
	SW4Rm1QIAxLvBFC3lharw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1666094525; x=1666180925; bh=O2/dMz8NgpCHX1Sqp3OOccZ2LMUa
	8ynU7I6zNQmgh+0=; b=lTeAcC/icUBb+IlQWBzbTLHVrTH5ajyoSWtpcUiVRIhz
	vpZWIAP57iGUXKR6d58fDi2y3UqU8itb1kn3YjiiFZOvPy+j7aYBERpYoK9iqBMh
	1UIMYouGb6GVcaCyVQX6Em8XqnJBn8pc9MMZi6ywh29NsYiCcex7oCd0U4cA4fdc
	gylkVnvf+4YTZ76l0YOgdwz141C5gCEpOlLAxXJ5dAgdKN9JDhwJASxIy2B0G2A1
	wC8aGjGA72X596R6bBAIa3FbrSZf9r5AdvQ+1QZBGCV1i/qHoK6zfObK7og/p6pk
	D6BG0fCj8MS3pwqPUBVc4Vv1uqAz5/2WqnGnINd9JQ==
X-ME-Sender: <xms:u5VOY82j9ZJWwLuBuO62e6RXoISFTb8cxq7dqTz-s--dzOK8BUwnnw>
    <xme:u5VOY3EIs1KXrYXtuQ5BdB3VBwQXNeh9aE_uc-OFAT0zFkZH19lwuE3xP_pf0zFCK
    FpyTsYcCZi0cA>
X-ME-Received: <xmr:u5VOY052XM0GJlQstg7vCbpdciJsx8nAwC6pumYrNNN2YzoguXHE7OGHCe_vupzRSf6TVmW6AMZYC1TuSy1AuEk31VG9IbD5nOKu>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelvddgudekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:u5VOY13fc3uSr8JORwaxyD9b04YDru3oXdU9H8TxTJO-awSdPee5lA>
    <xmx:u5VOY_FsA3dQ_fLjy8D0865wmQ8NIDpv03MspxTHb5UhN5uSwOVAOA>
    <xmx:u5VOY--EaK2gNw3aY4jYloONLw6zwutGCRWDL3v6e6wst1ar8abn-A>
    <xmx:vZVOY8e5fR4nP3eZQFZ9S5n_lu5ZLNMZn3VC4iVGv_lu0b1PN0C6fw>
Feedback-ID: i1568416f:Fastmail
Date: Tue, 18 Oct 2022 14:01:40 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Message-ID: <Y06VthUrV6PjOcJH@mail-itl>
References: <Y04i8V7xamTkuqNA@mail-itl>
 <20221018082413.GA25785@lst.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qtGIkQp0BUuCxgCT"
Content-Disposition: inline
In-Reply-To: <20221018082413.GA25785@lst.de>


--qtGIkQp0BUuCxgCT
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 18 Oct 2022 14:01:40 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"

On Tue, Oct 18, 2022 at 10:24:13AM +0200, Christoph Hellwig wrote:
> On Tue, Oct 18, 2022 at 05:52:16AM +0200, Marek Marczykowski-G=C3=B3recki=
 wrote:
> > not only) when using IGD in Xen PV dom0. After not very long time Xorg
> > crashes, and dmesg contain messages like this:
> >=20
> >     i915 0000:00:02.0: [drm] GPU HANG: ecode 7:1:01fffbfe, in Xorg [533=
7]
> >     i915 0000:00:02.0: [drm] Resetting rcs0 for stopped heartbeat on rc=
s0
> >     i915 0000:00:02.0: [drm] Xorg[5337] context reset due to GPU hang
>=20
> <snip>
>=20
> > I tried reverting just this commit on top of 6.0.x, but the context
> > changed significantly in subsequent commits, so after trying reverting
> > it together with 3 or 4 more commits I gave up.
> >=20
> > What may be an important detail, the system heavily uses cross-VM shared
> > memory (gntdev) to map window contents from VMs. This is Qubes OS, and
> > it uses Xen 4.14.
>=20
> Can you try the patch below?

Yes, this seems to help.

And since this is a PV domain, with Jan proposed change it should work
too. Intuitively this indeed should be PV-only thing (as was forcing
swiotlb before).

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--qtGIkQp0BUuCxgCT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNOlbUACgkQ24/THMrX
1ywetwf8DTYa8ZbhMb5HDzxNAzyTnFvsCY1DX+0u7OmcBugMCEX5sJViL7uuwVZJ
ZlJiCsAuFZ/FrBKchCzCND/GQ7rrAwRi/0QOjiOi6rf2dk8KMvGtY6GbcEf3cpqC
Oh9OZGCirz84We8EBSRTo+MwwnM5EVbtjnhdXahTBk01ZGSQVbBct59sqpbJNamu
oj/qXqFUuwVzn/5PuTUxifnWdj8nJbMFWwm5gyPEwJoqpG2e/31UmkJwGNifSvOy
ohr3oSYiv0UuPKctnCsjr9WjLCPZVynL674H6TiUBdH0ySEupEKrKdossTByT4+7
u7PQT2fMcvycjOi+XITjfwZ5p5d0Qg==
=ebS7
-----END PGP SIGNATURE-----

--qtGIkQp0BUuCxgCT--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 12:02:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 12:02:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424975.672691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oklIl-0003b0-Ks; Tue, 18 Oct 2022 12:02:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424975.672691; Tue, 18 Oct 2022 12:02:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oklIl-0003at-Ha; Tue, 18 Oct 2022 12:02:31 +0000
Received: by outflank-mailman (input) for mailman id 424975;
 Tue, 18 Oct 2022 12:02:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cSYL=2T=epam.com=prvs=2290940752=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1oklIk-00036n-6M
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 12:02:30 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bbff70cc-4edc-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 14:02:28 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29I9S6Si019466;
 Tue, 18 Oct 2022 12:02:17 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k9d882bev-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 18 Oct 2022 12:02:17 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS2PR03MB9396.eurprd03.prod.outlook.com (2603:10a6:20b:59c::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct
 2022 12:02:14 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 12:02:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbff70cc-4edc-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RimkMW3AyD090Wj3RhpNoNqj7sm1TWO3MC4eU16BnXv/dPU/4XOuVB0v2oNhW088blBgWD8WM1YxQZvqD3llR8wvlenWdvtmsqxK0KkDDoGDo1idnz06z4Q+1T6zzeGqXNJaYvrG5U0C02ppzVNj7sehsz1nmOPQdX65L34/peQykhK7/RhbAEbxX0JrJwuBj6Sl8qsb0TrRRvOK0Sm0FoSG/aUzq5LAL3Vub0rx6MjMBDIqd92XChpHyuN/VPtOCKzF2BQq7zA5ePZ9sPDL1X7e9mfKN4ACoBQEpCZ8OgVuEkmkU8loVHxxefCZNv6zk0lzcXe6hLEvv7KCl9idww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bkXjOIo2Q2vRt5lRHIQlgi5K/KNwI+/mN62E96uVs2w=;
 b=Cv4knJANW/UgmSTlpzCdmnhKDrqLNK7RK5qCreyADQefUGCoO+qp+3QWtt4pg75p1wG26fFIFyrR9CP7Po3g0p4der4/HEjFZV6AHi1tkNYSHe26rZVAVjMT4mGMyqpiImSpQkRm4zAsNb9ZC9GtnghwpvcidACsx1zcaA1OmcOpvnwzu0nAieq38+SCLVW82BpOmtWuChPBTU92icpohnJ9pNoomNp7juiOGvZPL9yE1hGKGOxGXWElLaxmqSEhK/cqurB01fRcVwtkRMc2s5+NjdmH86hnkAbDfM80TgD5GI3ANwECc4zMNXJ8kX+gFA5KrzIBXtSV2+479F/fNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bkXjOIo2Q2vRt5lRHIQlgi5K/KNwI+/mN62E96uVs2w=;
 b=oDAM6hVQHWzH0OX9ekv61kRaqlvh5FL3f/MfDYghwN0BH/gy7BkddTnDMK2ybPfmBrj+2LZLWLWa5t7Ehf7zOadetgnl06utf9nCq/6ouCd02l2alKF0b39iVvBNmy5lvTBW+mjT/dwJ+pSBgMDJgh/SzXYV4c8t3hLpQUDvthCerpLdnRMwWUy2FNpzfMtSXBEvWHIZ6+NPUUdc3/eWothenPVRpYzIHw1qkmiiNBViFzrAGhv66ylY6HemfyLiKwRpyn9c8VT8yy45ihd45Vxkw2eCXoNzMVrjbuxHJCNKc/IzYbLK2DZcUYt5bCtCZQs51HUi6gCLQh0a1+ClDQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64TUTqAgADAWAA=
Date: Tue, 18 Oct 2022 12:02:13 +0000
Message-ID: <531d3fe0-de24-4aac-f58a-091edbe25a98@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210171731110.4587@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210171731110.4587@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS2PR03MB9396:EE_
x-ms-office365-filtering-correlation-id: 0441a798-7215-4e2f-f0ac-08dab10097e0
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 psPpKUBA/CPyc15ijhJfXNF3dtJoZL8smPaSuujRs51xXNyOsFxH1QNGuC8aGrCD9cY2hHhwjZfyr6IpKbSTl/qOzNw6jQf/53CmE/gxtUw+g36i8qFa977XkHyVgzXk7aiUEzajoo5VfZl6Lp+n1EQDSAbhYoajeCQIDjW84DniFFiFO62S6VB6a0wnMZUTkWr4dYnj4uqX/IgjnlEa8LLnHFRx0/mniUV6wh071PK3wvQx+9ROnjqEZ9kG1S4+WA/aHbcbdx4oXETPp3PJnhJn80obEwQyVD1pH+noUcdcDJn3J6WqHbYF2opZNrXkJshfWv6weOrGIHjQy/kQW2hWFZL0qt8VuSD935aO2Q6zNEbFnEyAfx6InrlnEGnijVS1Ykq9JjI/OG5M/JFvHWBimvJ8APg7YuypklEqK2R+70GFVJ7bY3y6t9ahi3dWo3wBAdYzT55FH3+g68k8xECIohiS5wEfoF2Ef/DESpqYcpHnS7Gr6movsCO2r8thGLutwXD9Ca1+Gw/9vZAU/aUHR3a2nv29iXmE2f0u/xWWyBL8hlxkCcqk34RqjdEhGzS/BP8TxCr5EePwdXHyAeRtM/kg+4NqeRdUQkTxrz/YVIgdtt4Xsioqf3Pdx6vNt9rhw1LwDk4xSp8uZ3RTc7wc5lTP50IeYIaDZ5M/aXxjnPF4uit4l7bjkrErpZaSqwlSJ5CmUFOTLbI/ZvaZw01tlkYd2cDHM7g6QKCmHXDYi3SBnUh7Cj1IxAe+RFJ4iW+cAEuJpdY5OIOcMtJMRQegEwTxUeFhNtycliaAtxXFkhc2stjXmNzBFRfFC6AshV1XAGvAc0enXiCtHaLbspGiouINKo9SpY+vLj7BrYDGFejJoM4JiWeRDk3xN3Mz
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199015)(31686004)(2616005)(6486002)(38070700005)(186003)(2906002)(966005)(6916009)(6506007)(54906003)(36756003)(316002)(38100700002)(478600001)(66946007)(41300700001)(86362001)(122000001)(5660300002)(76116006)(71200400001)(83380400001)(26005)(53546011)(64756008)(91956017)(31696002)(6512007)(66446008)(4326008)(66556008)(8676002)(66476007)(55236004)(8936002)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ZW5PYVdMTzJsT0F2VEZOUGk3YkpTTkFCL1dGV0kzMkcydngvMktzcnFKQjRG?=
 =?utf-8?B?ZVFtYzJCY0hqZnByWjdlYjlaOUZoWXB4czMwRUQzRlVtN3pPZ2k0R2ZsZHlK?=
 =?utf-8?B?L3ZSeU95b0F0NDVoK2RsaEEwRzV4UkxINk11YWJyZTJrOGYyT0tVc0ZqcHZy?=
 =?utf-8?B?VnQyTThOWjR0cEF3RUdNSzVmUHBsaEd2cmRMeGdZbnluS0tpeitENStsbitt?=
 =?utf-8?B?c0czSXJURDROQlJwcDdxOVVNNmlOY0VNWGQ5cENYV3ROMmx5VEdhdWlrOWpr?=
 =?utf-8?B?U1N4MTd3M0Y3ZzBmRW1LT3lNdGdLRGRxMDV6SXM5bkVORmU1VmVsSXFQWDRw?=
 =?utf-8?B?ZkFPVXZ1eGJESnd1NmtxMHVJQUt3OWRDRjRVSHhsSDN1ZHFpVHVIN2xnVEt4?=
 =?utf-8?B?MHI0QXJ1cVFwdTdjZlh6MGVyT1ZtUDhYMWdXbzZaL05pTW4zTkNLQXBzTjVN?=
 =?utf-8?B?UTI3eU9DcXpOM1VCUjZyaFYydVFTMFFEOHdnTnJSWklzd3ZBVGJnaHpWdkU3?=
 =?utf-8?B?Rjl4NlEwb1BCNnBqdHNZNzVwb3FkWTFOb05BK3EyaWE4RTArVjFac2c5VEk4?=
 =?utf-8?B?OUZtY1JqM3llQ0dmdTFPWXBUcklPRXRoYzVvaTZYcDJjUVdxVUdxWEZreW9X?=
 =?utf-8?B?dzVDazRXVS9EdWkrSlNremNDVG0xMlhKdy93RVRjZWhNL0w1Q1UwWVg2Risz?=
 =?utf-8?B?eVFjWFd4VlAxMUJjT2VSWFNwK3krUVVPRjR0U3o4MDB6MzRhUXRjdGJJdmhX?=
 =?utf-8?B?K2p1TElvaGgwUEFQOCtLT2hLSUJzb25iUUNHdm1GODR0Rml1OEtCSkdnRXRG?=
 =?utf-8?B?cWppYzFCU3pYb0lBR3JuM1hycm9PSnJ5VkVCSEF0a1o1Q1NNZE9YSDc4ZFlp?=
 =?utf-8?B?WDFKMWsweHF3UjlJdDdmZzQxSTh0blV5N05xZDZzV3hpeWtGelg5UU5FL0Fi?=
 =?utf-8?B?V0g0dDlUM3B6d1BxZXBxNHg4VERneFdsRnZ5NzlTT2RzdGtTRzU4WWZzY2V2?=
 =?utf-8?B?YU9HbHd0VXU5ZHFxUVo2SmUwK0VyTjdMK1FxK2ZNc0NLditKbXQ4OVRGSjBX?=
 =?utf-8?B?OWFROGZNVHhSejNleVk1cWFwV1R1WXppVXQrNUNDL2RWK3lRbkZVOG1Sc0ph?=
 =?utf-8?B?a0VTN2dobUNLaCtWNXBlcDdwTFlscjdlYlFEdTdrdlNVaVRyTWZzdXYrSjNo?=
 =?utf-8?B?QUJ3NC9VTVlWRCtZblZCWTNtSjYzU3AvdU5qNS9GSkxKaENBbDdDK3VpVFNL?=
 =?utf-8?B?S3ZEMHRpVlpaQXFKRWdNWGNEUXg5R0JNbEx1N254L3Q4eWFuSHA1Zk5jdkFt?=
 =?utf-8?B?bi9kbHpKTTJnNnFtbHA1ejJJZnl3RHR3L1BSZHZ5MmZ5L1FVNHovTCtwNDRV?=
 =?utf-8?B?dHF1T25tMytpWS9LUG91Vy94Y0JKNVRrTUxCdXZJN3o2QmVzWGJNeUxBN0Vl?=
 =?utf-8?B?MU9XeWhlT2R4MWxkK0N1YTlVN0F1cGczcHNhWDBIMTY2T1ZHc3gwMUg4bHRY?=
 =?utf-8?B?cktOTjFJTzJWeERKY1ZSOG9kTkhyVkJtdjZUeS85ZitaU0Q4bUxVRFNUdXgw?=
 =?utf-8?B?SnRPaC9lNXFQeUtVNjdWWkQrWXpSVWp3MWEvZzhoZVRSZC9rdzdLenZJWDJQ?=
 =?utf-8?B?SDB0bGpIbFVCWXF1NC9zNXJFNDd5b3U5ZEhrU2RvWnJyYSt6YlBpYmVMZXBo?=
 =?utf-8?B?RW5kTkY2em55akk3UytoOVByVUJIcGl3Y0Rha1ppaEtHM2FvcDBmMlNuRVpT?=
 =?utf-8?B?MndvZ2huTENEWFZJcTVoNkY2SW92dmkvT21PdFNxeWpLUVNXVUVaUmg2SEpF?=
 =?utf-8?B?QTVBZmd3S2VJKzVoY0ZHWFQzMlBqVzNqSDBlUEwwN0lEd05MNW1ieEZDRnQz?=
 =?utf-8?B?dlBJVGk4SUpWN2tQdGNYQ2FmM1JIaGhsQlI0ZWhUUXM2K2RIUmN4aFpITnVs?=
 =?utf-8?B?b3o0WHdHTktxZmk5eUNtdGJkSm45Q3BCZXpSUDFTZkpwMzB1d3RkUUkvYlF1?=
 =?utf-8?B?b0VtazFHOXdidDZEWmlsV1BxQnNtQ1c4bVM3NWFJMmVNcTZRYjVKSW1JdmU1?=
 =?utf-8?B?ekpGVksrWkIxZmptN3gvckJ6U0pHNHR0NlRDeit6RUErbEtqV25PeWZxK080?=
 =?utf-8?B?SFJNV2VKdllCYVdXQlM5akpodkhEcFNSYW5WOGRLUmdxNWUyckVIby9QNjFV?=
 =?utf-8?Q?LEcsKMHfhk7mDM70/wmEZNw=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <15D80D1E95C7B0488B9B2EC824704196@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0441a798-7215-4e2f-f0ac-08dab10097e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 12:02:13.2095
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vf8zDnbz+tbNLu0iIcRHhT+B+msmMfLmpeVt1+rQZDtgfs7GgEq10ZFwKZESyvnl0ud6QH+S+IoV++0Be43nwyXukG+nr8ZQEHaK0S89+zE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR03MB9396
X-Proofpoint-ORIG-GUID: P4WLpaaprH-qyakZxRxIigcdbPGiOooj
X-Proofpoint-GUID: P4WLpaaprH-qyakZxRxIigcdbPGiOooj
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-18_03,2022-10-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0
 lowpriorityscore=0 malwarescore=0 adultscore=0 mlxscore=0 impostorscore=0
 suspectscore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1011
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210180069

DQpPbiAxOC4xMC4yMiAwMzozMywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gT24gU2F0LCAxNSBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3Jv
dGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29A
ZXBhbS5jb20+DQo+Pg0KPj4gVXNlIHRoZSBzYW1lICJ4ZW4tZ3JhbnQtZG1hIiBkZXZpY2UgY29u
Y2VwdCBmb3IgdGhlIFBDSSBkZXZpY2VzDQo+PiBiZWhpbmQgZGV2aWNlLXRyZWUgYmFzZWQgUENJ
IEhvc3QgY29udHJvbGxlciwgYnV0IHdpdGggb25lIG1vZGlmaWNhdGlvbi4NCj4+IFVubGlrZSBm
b3IgcGxhdGZvcm0gZGV2aWNlcywgd2UgY2Fubm90IHVzZSBnZW5lcmljIElPTU1VIGJpbmRpbmdz
DQo+PiAoaW9tbXVzIHByb3BlcnR5KSwgYXMgd2UgbmVlZCB0byBzdXBwb3J0IG1vcmUgZmxleGli
bGUgY29uZmlndXJhdGlvbi4NCj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgUENJIGRldmljZXMgdW5k
ZXIgdGhlIHNpbmdsZSBQQ0kgSG9zdCBjb250cm9sbGVyDQo+PiBtYXkgaGF2ZSB0aGUgYmFja2Vu
ZHMgcnVubmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFpbnMgYW5kIHRodXMgaGF2ZQ0KPj4gZGlm
ZmVyZW50IGVuZHBvaW50cyBJRCAoYmFja2VuZCBkb21haW5zIElEKS4NCj4gSGkgT2xla3NhbmRy
LA0KPg0KPiAgRnJvbSBhbm90aGVyIGVtYWlsIEkgdW5kZXJzdG9vZCB0aGF0IHlvdSBzdWNjZXNz
ZnVsbHkgbWFuYWdlZCB0bw0KPiBkZXNjcmliZSBpbiBkZXZpY2UgdHJlZSBhbGwgdGhlIGluZGl2
aWR1YWwgdmlydGlvIHBjaSBkZXZpY2VzIHNvIHRoYXQNCj4geW91IGNhbiBoYXZlIGlvbW11LW1h
cC9pb21tdS1tYXAtbWFzayBwcm9wZXJ0aWVzIHVuZGVyIGVhY2ggdmlydGlvDQo+IGRldmljZSBu
b2RlLiBJcyB0aGF0IHJpZ2h0Pw0KDQpOby4gSGVyZSBbMV0gSSBtZW50aW9uZWQgdGhhdCBJIGhh
ZCBleHBlcmltZW50ZWQgd2l0aCBQQ0ktSU9NTVUgYmluZGluZ3MgDQooaW9tbXUtbWFwL2lvbW11
LW1hcC1tYXNrIHByb3BlcnRpZXMpIGFzIElPTU1VIGJpbmRpbmdzIChpb21tdSBwcm9wZXJ0eSkg
DQppcyBpbnN1ZmZpY2llbnQgZm9yIHVzIGFuZCBnb3QgaXQgd29ya2VkLg0KQWxzbyBJIHByb3Zp
ZGVkIGEgbGluayB0byB0aGUgY3VycmVudCBwYXRjaC4gU29ycnksIGlmIEkgd2FzIHVuY2xlYXIu
DQoNCkp1c3QgdG8gYmUgY2xlYXI6DQoNCldlIGRvIG5vdCBkZXNjcmliZSBpbiBkZXZpY2UtdHJl
ZSBhbGwgdGhlIGluZGl2aWR1YWwgdmlydGlvLXBjaSBkZXZpY2VzIA0KKGFuZCB3ZSBkbyBub3Qg
aGF2ZSB0byksIHdlIG9ubHkgZGVzY3JpYmUgZ2VuZXJpYyBQQ0kgaG9zdCBicmlkZ2Ugbm9kZS4N
ClNvIHdlIGhhdmUgb25seSBhICpzaW5nbGUqIGlvbW11LW1hcCBwcm9wZXJ0eSB1bmRlciB0aGF0
IFBDSSBob3N0IGJyaWRnZSANCm5vZGUuDQpUaGUgaW9tbXUtbWFwIHByb3BlcnR5IGluIHR1cm4g
ZGVzY3JpYmVzIHRoZSBJT01NVSBjb25uZWN0aW9ucyBmb3IgdGhlIA0KZW5kcG9pbnRzIHdpdGhp
biB0aGF0IFBDSSBIb3N0IGJyaWRnZSBhY2NvcmRpbmcgdG86DQpodHRwczovL3d3dy5rZXJuZWwu
b3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL3BjaS1pb21tdS50
eHQNCg0KRm9yIHRoZSBpbnN0YW5jZSwgdGhlIGZvbGxvd2luZyBpb21tdS1tYXAgcHJvcGVydHkg
dW5kZXIgdGhhdCBQQ0kgaG9zdCANCmJyaWRnZSBub2RlIGRlc2NyaWJlcyB0aGUgcmVsYXRpb25z
aGlwIGJldHdlZW4gSU9NTVUgYW5kIHR3byBQQ0kgZGV2aWNlcyANCigwMDAwOjAwOjAxLjAgYW5k
IDAwMDA6MDA6MDIuMCk6DQppb21tdS1tYXAgPSA8MHgwOCAweGZkZTkgMHgwMSAweDA4IDB4MTAg
MHhmZGU5IDB4MDIgMHgwOD47DQpGb3IgMDAwMDowMDowMS4wIHdlIHBhc3MgdGhlIGVuZHBvaW50
IElEIDEgKGJhY2tlbmQgZG9taWQgMSkNCkZvciAwMDAwOjAwOjAyLjAgd2UgcGFzcyB0aGUgZW5k
cG9pbnQgSUQgMiAoYmFja2VuZCBkb21pZCAyKQ0KT3RoZXIgUENJIGRldmljZXMgKGkuZSAwMDAw
OjAwOjAzLjApIGFyZSB1bnRyYW5zbGF0ZWQgKGFyZSBub3QgcmVxdWlyZWQgDQp0byB1c2UgZ3Jh
bnRzIGZvciB0aGUgdmlydGlvKS4NCg0KDQo+DQo+IElmIHRoYXQgaXMgdGhlIGNhc2UsIHRoZW4g
SSB3b3VsZCByYXRoZXIganVtcCBzdHJhaWdodCB0byB0aGF0IGFwcHJvYWNoDQo+IGJlY2F1c2Ug
SSB0aGluayBpdCBpcyBmYXIgYmV0dGVyIHRoYW4gdGhpcyBvbmUuDQoNClBsZWFzZSBzZWUgYWJv
dmUsIEkgZG9uJ3QgaGF2ZSBhbnkgb3RoZXIgYXBwcm9hY2ggZXhjZXB0IHRoZSBvbmUgDQppbXBs
ZW1lbnRlZCBpbiBjdXJyZW50IHBhdGNoLg0KDQpbMV0gDQpodHRwczovL2xvcmUua2VybmVsLm9y
Zy94ZW4tZGV2ZWwvMTY0ODViYzktMGUyYS03ODhhLTkzYjgtNDUzY2M5ZWYwZDNjQGVwYW0uY29t
Lw0KDQoNCj4NCj4gQ2hlZXJzLA0KPg0KPiBTdGVmYW5vDQo+DQo+DQo+DQo+PiBTbyB1c2UgZ2Vu
ZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5zdGVhZCAoaW9tbXUtbWFwL2lvbW11LW1hcC1tYXNr
DQo+PiBwcm9wZXJ0aWVzKSB3aGljaCBhbGxvd3MgdXMgdG8gZGVzY3JpYmUgcmVsYXRpb25zaGlw
IGJldHdlZW4gUENJDQo+PiBkZXZpY2VzIGFuZCBiYWNrZW5kIGRvbWFpbnMgSUQgcHJvcGVybHku
DQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90
eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gLS0tDQo+PiBTbGlnaHRseSBSRkMuIFRoaXMgaXMgbmVl
ZGVkIHRvIHN1cHBvcnQgWGVuIGdyYW50IG1hcHBpbmdzIGZvciB2aXJ0aW8tcGNpIGRldmljZXMN
Cj4+IG9uIEFybSBhdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUuIFRoZSBYZW4gdG9vbHN0YWNr
IHNpZGUgaXMgbm90IGNvbXBsZXRlbHkgcmVhZHkgeWV0Lg0KPj4gSGVyZSwgZm9yIFBDSSBkZXZp
Y2VzIHdlIHVzZSBtb3JlIGZsZXhpYmxlIHdheSB0byBwYXNzIGJhY2tlbmQgZG9taWQgdG8gdGhl
IGd1ZXN0DQo+PiB0aGFuIGZvciBwbGF0Zm9ybSBkZXZpY2VzLg0KPj4NCj4+IENoYW5nZXMgVjEg
LT4gVjI6DQo+PiAgICAgLSB1cGRhdGUgY29tbWl0IGRlc2NyaXB0aW9uDQo+PiAgICAgLSByZWJh
c2UNCj4+ICAgICAtIHJld29yayB0byB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5z
dGVhZCBvZiBnZW5lcmljIElPTU1VIGJpbmRpbmdzDQo+Pg0KPj4gUHJldmlvdXMgZGlzY3Vzc2lv
biBpcyBhdDoNCj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2xvcmUua2Vy
bmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDYxNzQ4MDQuMjAwMzAyOS0xLW9sZWtzdHlzaEBnbWFp
bC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSExbVNFVHhnOENSb2hsTDVPcFlvMFZhTEJYdGJXUkxa
bGFtOVFBQk1QX1lVenNZY3JuOG5vMUZ4QlB2aFFuTlJDU3pwM3BrQzFkWElnbWhkYVptSjNveVY2
eVdVeTN3JCAgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pg0KPj4gQmFzZWQgb246DQo+PiBodHRw
czovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xp
bnV4L2tlcm5lbC9naXQveGVuL3RpcC5naXQvbG9nLz9oPWZvci1saW51cy02LjFfXzshIUdGXzI5
ZGJjUUlVQlBBITFtU0VUeGc4Q1JvaGxMNU9wWW8wVmFMQlh0YldSTFpsYW05UUFCTVBfWVV6c1lj
cm44bm8xRnhCUHZoUW5OUkNTenAzcGtDMWRYSWdtaGRhWm1KM295V2EtNnl5dWckICBbZ2l0Wy5d
a2VybmVsWy5db3JnXQ0KPj4gLS0tDQo+PiAgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyB8
IDg3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0NCj4+ICAgMSBmaWxlIGNo
YW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEt
b3BzLmMNCj4+IGluZGV4IGRhYTUyNWRmN2JkYy4uYjc5ZDlkNmNlMTU0IDEwMDY0NA0KPj4gLS0t
IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFu
dC1kbWEtb3BzLmMNCj4+IEBAIC0xMCw2ICsxMCw3IEBADQo+PiAgICNpbmNsdWRlIDxsaW51eC9t
b2R1bGUuaD4NCj4+ICAgI2luY2x1ZGUgPGxpbnV4L2RtYS1tYXAtb3BzLmg+DQo+PiAgICNpbmNs
dWRlIDxsaW51eC9vZi5oPg0KPj4gKyNpbmNsdWRlIDxsaW51eC9wY2kuaD4NCj4+ICAgI2luY2x1
ZGUgPGxpbnV4L3Bmbi5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgveGFycmF5Lmg+DQo+PiAgICNp
bmNsdWRlIDxsaW51eC92aXJ0aW9fYW5jaG9yLmg+DQo+PiBAQCAtMjkyLDEyICsyOTMsNTUgQEAg
c3RhdGljIGNvbnN0IHN0cnVjdCBkbWFfbWFwX29wcyB4ZW5fZ3JhbnRfZG1hX29wcyA9IHsNCj4+
ICAgCS5kbWFfc3VwcG9ydGVkID0geGVuX2dyYW50X2RtYV9zdXBwb3J0ZWQsDQo+PiAgIH07DQo+
PiAgIA0KPj4gK3N0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnhlbl9kdF9nZXRfcGNpX2hvc3Rf
bm9kZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiArew0KPj4gKwlzdHJ1Y3QgcGNpX2RldiAqcGRl
diA9IHRvX3BjaV9kZXYoZGV2KTsNCj4+ICsJc3RydWN0IHBjaV9idXMgKmJ1cyA9IHBkZXYtPmJ1
czsNCj4+ICsNCj4+ICsJLyogV2FsayB1cCB0byB0aGUgcm9vdCBidXMgdG8gbG9vayBmb3IgUENJ
IEhvc3QgY29udHJvbGxlciAqLw0KPj4gKwl3aGlsZSAoIXBjaV9pc19yb290X2J1cyhidXMpKQ0K
Pj4gKwkJYnVzID0gYnVzLT5wYXJlbnQ7DQo+PiArDQo+PiArCXJldHVybiBvZl9ub2RlX2dldChi
dXMtPmJyaWRnZS0+cGFyZW50LT5vZl9ub2RlKTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGljIHN0
cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+
ICt7DQo+PiArCWlmIChkZXZfaXNfcGNpKGRldikpDQo+PiArCQlyZXR1cm4geGVuX2R0X2dldF9w
Y2lfaG9zdF9ub2RlKGRldik7DQo+PiArDQo+PiArCXJldHVybiBvZl9ub2RlX2dldChkZXYtPm9m
X25vZGUpOw0KPj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IHhlbl9kdF9tYXBfaWQoc3RydWN0
IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKippb21tdV9ucCwNCj4+ICsJCQkgdTMy
ICpzaWQpDQo+PiArew0KPj4gKwlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2
KTsNCj4+ICsJdTMyIHJpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51bWJlciwgcGRldi0+ZGV2
Zm4pOw0KPj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKmhvc3RfbnA7DQo+PiArCWludCByZXQ7DQo+
PiArDQo+PiArCWhvc3RfbnAgPSB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoZGV2KTsNCj4+ICsJ
aWYgKCFob3N0X25wKQ0KPj4gKwkJcmV0dXJuIC1FTk9ERVY7DQo+PiArDQo+PiArCXJldCA9IG9m
X21hcF9pZChob3N0X25wLCByaWQsICJpb21tdS1tYXAiLCAiaW9tbXUtbWFwLW1hc2siLCBpb21t
dV9ucCwgc2lkKTsNCj4+ICsJb2Zfbm9kZV9wdXQoaG9zdF9ucCk7DQo+PiArDQo+PiArCXJldHVy
biByZXQ7DQo+PiArfQ0KPj4gKw0KPj4gICBzdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1h
X2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiAgIHsNCj4+IC0Jc3RydWN0IGRldmljZV9u
b2RlICppb21tdV9ucDsNCj4+ICsJc3RydWN0IGRldmljZV9ub2RlICppb21tdV9ucCA9IE5VTEw7
DQo+PiAgIAlib29sIGhhc19pb21tdTsNCj4+ICAgDQo+PiAtCWlvbW11X25wID0gb2ZfcGFyc2Vf
cGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21tdXMiLCAwKTsNCj4+ICsJaWYgKGRldl9pc19wY2ko
ZGV2KSkgew0KPj4gKwkJaWYgKHhlbl9kdF9tYXBfaWQoZGV2LCAmaW9tbXVfbnAsIE5VTEwpKQ0K
Pj4gKwkJCXJldHVybiBmYWxzZTsNCj4+ICsJfSBlbHNlDQo+PiArCQlpb21tdV9ucCA9IG9mX3Bh
cnNlX3BoYW5kbGUoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgMCk7DQo+PiArDQo+PiAgIAloYXNf
aW9tbXUgPSBpb21tdV9ucCAmJg0KPj4gICAJCSAgICBvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShp
b21tdV9ucCwgInhlbixncmFudC1kbWEiKTsNCj4+ICAgCW9mX25vZGVfcHV0KGlvbW11X25wKTsN
Cj4+IEBAIC0zMDcsOSArMzUxLDE3IEBAIHN0YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFf
ZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgDQo+PiAgIGJvb2wgeGVuX2lzX2dyYW50
X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+PiArCXN0cnVjdCBkZXZp
Y2Vfbm9kZSAqbnA7DQo+PiArDQo+PiAgIAkvKiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNlcyBm
b3Igbm93ICovDQo+PiAtCWlmIChkZXYtPm9mX25vZGUpDQo+PiAtCQlyZXR1cm4geGVuX2lzX2R0
X2dyYW50X2RtYV9kZXZpY2UoZGV2KTsNCj4+ICsJbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsN
Cj4+ICsJaWYgKG5wKSB7DQo+PiArCQlib29sIHJldDsNCj4+ICsNCj4+ICsJCXJldCA9IHhlbl9p
c19kdF9ncmFudF9kbWFfZGV2aWNlKGRldik7DQo+PiArCQlvZl9ub2RlX3B1dChucCk7DQo+PiAr
CQlyZXR1cm4gcmV0Ow0KPj4gKwl9DQo+PiAgIA0KPj4gICAJcmV0dXJuIGZhbHNlOw0KPj4gICB9
DQo+PiBAQCAtMzI1LDEyICszNzcsMTkgQEAgYm9vbCB4ZW5fdmlydGlvX21lbV9hY2Moc3RydWN0
IHZpcnRpb19kZXZpY2UgKmRldikNCj4+ICAgc3RhdGljIGludCB4ZW5fZHRfZ3JhbnRfaW5pdF9i
YWNrZW5kX2RvbWlkKHN0cnVjdCBkZXZpY2UgKmRldiwNCj4+ICAgCQkJCQkgICBzdHJ1Y3QgeGVu
X2dyYW50X2RtYV9kYXRhICpkYXRhKQ0KPj4gICB7DQo+PiAtCXN0cnVjdCBvZl9waGFuZGxlX2Fy
Z3MgaW9tbXVfc3BlYzsNCj4+ICsJc3RydWN0IG9mX3BoYW5kbGVfYXJncyBpb21tdV9zcGVjID0g
eyAuYXJnc19jb3VudCA9IDEgfTsNCj4+ICAgDQo+PiAtCWlmIChvZl9wYXJzZV9waGFuZGxlX3dp
dGhfYXJncyhkZXYtPm9mX25vZGUsICJpb21tdXMiLCAiI2lvbW11LWNlbGxzIiwNCj4+IC0JCQkw
LCAmaW9tbXVfc3BlYykpIHsNCj4+IC0JCWRldl9lcnIoZGV2LCAiQ2Fubm90IHBhcnNlIGlvbW11
cyBwcm9wZXJ0eVxuIik7DQo+PiAtCQlyZXR1cm4gLUVTUkNIOw0KPj4gKwlpZiAoZGV2X2lzX3Bj
aShkZXYpKSB7DQo+PiArCQlpZiAoeGVuX2R0X21hcF9pZChkZXYsICZpb21tdV9zcGVjLm5wLCBp
b21tdV9zcGVjLmFyZ3MpKSB7DQo+PiArCQkJZGV2X2VycihkZXYsICJDYW5ub3QgdHJhbnNsYXRl
IElEXG4iKTsNCj4+ICsJCQlyZXR1cm4gLUVTUkNIOw0KPj4gKwkJfQ0KPj4gKwl9IGVsc2Ugew0K
Pj4gKwkJaWYgKG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKGRldi0+b2Zfbm9kZSwgImlvbW11
cyIsICIjaW9tbXUtY2VsbHMiLA0KPj4gKwkJCQkwLCAmaW9tbXVfc3BlYykpIHsNCj4+ICsJCQlk
ZXZfZXJyKGRldiwgIkNhbm5vdCBwYXJzZSBpb21tdXMgcHJvcGVydHlcbiIpOw0KPj4gKwkJCXJl
dHVybiAtRVNSQ0g7DQo+PiArCQl9DQo+PiAgIAl9DQo+PiAgIA0KPj4gICAJaWYgKCFvZl9kZXZp
Y2VfaXNfY29tcGF0aWJsZShpb21tdV9zcGVjLm5wLCAieGVuLGdyYW50LWRtYSIpIHx8DQo+PiBA
QCAtMzU0LDYgKzQxMyw3IEBAIHN0YXRpYyBpbnQgeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9k
b21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiAgIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9v
cHMoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+PiAgIAlzdHJ1Y3QgeGVuX2dyYW50X2Rt
YV9kYXRhICpkYXRhOw0KPj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4gICANCj4+ICAg
CWRhdGEgPSBmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShkZXYpOw0KPj4gICAJaWYgKGRhdGEpIHsN
Cj4+IEBAIC0zNjUsOCArNDI1LDEzIEBAIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3Ry
dWN0IGRldmljZSAqZGV2KQ0KPj4gICAJaWYgKCFkYXRhKQ0KPj4gICAJCWdvdG8gZXJyOw0KPj4g
ICANCj4+IC0JaWYgKGRldi0+b2Zfbm9kZSkgew0KPj4gLQkJaWYgKHhlbl9kdF9ncmFudF9pbml0
X2JhY2tlbmRfZG9taWQoZGV2LCBkYXRhKSkNCj4+ICsJbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2
KTsNCj4+ICsJaWYgKG5wKSB7DQo+PiArCQlpbnQgcmV0Ow0KPj4gKw0KPj4gKwkJcmV0ID0geGVu
X2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYsIGRhdGEpOw0KPj4gKwkJb2Zfbm9kZV9w
dXQobnApOw0KPj4gKwkJaWYgKHJldCkNCj4+ICAgCQkJZ290byBlcnI7DQo+PiAgIAl9IGVsc2Ug
aWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQpKSB7DQo+PiAgIAkJ
ZGV2X2luZm8oZGV2LCAiVXNpbmcgZG9tMCBhcyBiYWNrZW5kXG4iKTsNCj4+IC0tIA0KPj4gMi4y
NS4xDQo+Pg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 12:44:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 12:44:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424989.672702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oklwo-0008VE-UX; Tue, 18 Oct 2022 12:43:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424989.672702; Tue, 18 Oct 2022 12:43:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oklwo-0008V7-QX; Tue, 18 Oct 2022 12:43:54 +0000
Received: by outflank-mailman (input) for mailman id 424989;
 Tue, 18 Oct 2022 12:43:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oklwn-0008V1-OJ
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 12:43:53 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oklwn-0000sy-E6; Tue, 18 Oct 2022 12:43:53 +0000
Received: from [15.248.2.52] (helo=[10.24.69.11])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oklwn-00026v-5u; Tue, 18 Oct 2022 12:43:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Nid0cBE9bk9DN2UFY29/rFqOgdZoiNjfGtNkaR9NiRQ=; b=lrO8bRFnSFf/SbmnCYqLR/lljS
	6wCDnybdh5cFn9IYjl7B10KUWvKMpJUFsfxuxaOY4SN53U1srFrtAglR+G+4fBOtaQA9SBAcQbqZH
	nYHMFaafe3Tg3Od9j6pFYAY4j2tIDo/hJXurIpHky8JvyaKbVXy7OmX4XeWtkVIvN1O8=;
Message-ID: <9da32b0b-7e3c-ad38-01c6-9ae78bf92702@xen.org>
Date: Tue, 18 Oct 2022 13:43:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221017165133.17066-1-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221017165133.17066-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 17/10/2022 17:51, Henry Wang wrote:
> @@ -1736,7 +1739,20 @@ void p2m_final_teardown(struct domain *d)
>       if ( !p2m->domain )
>           return;
>   
> +    /*
> +     * No need to call relinquish_p2m_mapping() here because
> +     * p2m_final_teardown() is called either after domain_relinquish_resources()
> +     * where relinquish_p2m_mapping() has been called, or from failure path of
> +     * domain_create()/arch_domain_create() where mappings that require
> +     * p2m_put_l3_page() should never be created. For the latter case, also see
> +     * comment on top of the p2m_set_entry() for more info.
> +     */
> +
> +    BUG_ON(p2m_teardown(d, false));
>       ASSERT(page_list_empty(&p2m->pages));
> +
> +    while ( p2m_teardown_allocation(d) == -ERESTART )
> +        continue; /* No preemption support here */
>       ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
>   
>       if ( p2m->root )
> @@ -1784,6 +1800,8 @@ int p2m_init(struct domain *d)

As Andrew pointed out the change in p2m_init() will end up leaking 
either the VMID or the root table.

Andrew's patch #1 [1] should help to solve the problem. So I would 
suggest to rebase on top of it.

Other than that, the logic looks good to me. This is even knowning that 
Andrew said the code is buggy. I spent some time starring at the code 
and can't figure out where the issue lies because p2m_teardown() will do 
nothing when the list is empty. If it is not empty, then it is 
guaranteed that the VMID and root table is allocated. So the code looks 
functional but just not efficient.

We already discussed the latter point earlier in the review and agreed 
to look at improve it post 4.17.

For the former, I am happy to be proven wrong. But this is going to 
require more substantial explanations.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 12:54:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 12:54:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.424995.672713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okm7I-0001fq-Uz; Tue, 18 Oct 2022 12:54:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 424995.672713; Tue, 18 Oct 2022 12:54:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okm7I-0001fj-Qw; Tue, 18 Oct 2022 12:54:44 +0000
Received: by outflank-mailman (input) for mailman id 424995;
 Tue, 18 Oct 2022 12:54:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=L+Ts=2T=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okm7G-0001fd-PH
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 12:54:43 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07cb2092-4ee4-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 14:54:41 +0200 (CEST)
Received: from AS9P250CA0003.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::9)
 by AS2PR08MB9497.eurprd08.prod.outlook.com (2603:10a6:20b:60f::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 12:54:33 +0000
Received: from AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:532:cafe::f9) by AS9P250CA0003.outlook.office365.com
 (2603:10a6:20b:532::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Tue, 18 Oct 2022 12:54:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT024.mail.protection.outlook.com (100.127.140.238) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Tue, 18 Oct 2022 12:54:33 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Tue, 18 Oct 2022 12:54:32 +0000
Received: from c1c0513f0fe9.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A7CC28BC-7E93-469D-9889-11CF627D939E.1; 
 Tue, 18 Oct 2022 12:54:21 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1c0513f0fe9.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 12:54:21 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB7838.eurprd08.prod.outlook.com (2603:10a6:20b:529::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 12:54:18 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 12:54:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07cb2092-4ee4-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=GfACyHzofszpH7E990Q+doPO9sAXPAKDqMhl0YqIrQTjmPmaiGrghl0wF4U8iHYJqVWoQ/DuEREAaX/h43GEF2s7jWCUnA0MP/MG+tOP622xPvJIiA50EePjZMer8l0IGexRpqxjyQkLW2902PaMLERi3YTDgM/Qw3v7uPPPf5pnDfBrneBc1S6zh1hAJw6ePXue7OfwnZ9fQJqYJS9jjXRXCwNU/i1nB5jCJnlhyPoyk90B8eXZoc30POjRkiEd2zrpxLFVtEo9Rkto0a68LB/tIcQLGJCjQxbJ8khoyw9DvHEPi5LlQdt1KTtrS/SxZceiXGK5dGRuB7ZGz2biqw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3ZVPCmAawhP/ivgOYB1lMAEBPcBuPLOnQXrB6xC0yQ8=;
 b=jgfjR0WSFZyumVYwZ/Sy0tYR3eIP33aNcxPSRy6fLWCkTQiiZXlcf7Gb80N3dFnWE0LP+GbrgzGxNaODUjm6sNaAJ1r/+aZlbNCz01zXvZ5Bn9shiwYj5PMoEGAipClXTgw/OGctVGMRpF8lE1dIFY/2ZaAM0U9h1ecfKCihiflJEwjDQeFi+/YIvGVz4n3Fm/YtHPg3P4XjoOp5OQsnfgyGuwucIBKAFZXy4Sec2Ps4u6l+JbLL6MLChBYHf4SzGF49ieRElWgR+7nx6gy6YGGllO2HonNHuM7XbPUNcxgWYL8DSgsxa36ijWhajG5zubxoZR5+sxot8SUkw0O1/g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3ZVPCmAawhP/ivgOYB1lMAEBPcBuPLOnQXrB6xC0yQ8=;
 b=zXHLab2OD1G7gWVKhhwxQvRZzvc19n/JUApRS1eDxHruuSlp5QOGgwhKUAOHPc+1359AcuxmRHGW7Qgi0ymTHri+DJyqOEeiPFV6lT84j8OQw4T8ZLzU9chM1xUe5ptHzmI11bBYpId91vkHV5CkEhr7Q+ctdvVuZbeAIPa4xs4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oDZjNQcS29hiyts6Tqe/Bamwkaj0F5tUTg+knrMSjsyIavzNiecQk5ts41kjQL8YfMsyeCb9FLw1qoGQYu5qV8jajXa42uq3ESgsxlcvQtL+NRapMwDV2Qdj/5QPWedh9xJAZUKZxgNHKvfHWTNisScW1KbI5sxRLohmIEXvxB34idYFDhWEK+V4pRjjyHz3FSWx1O7TXTV/js/gvpXSXEcRIwojNAPXJzBIJfmq6JX0pNAyOB4wPWMgbVfQkZ1URiiV+FCgBYJTEHEuR0ta5ogYPyKuKLIPephdrg0f/0AAQiiPIlyVhc7hYkWuZMgCmyz8/jIPFR/Ls9i5V6+hgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3ZVPCmAawhP/ivgOYB1lMAEBPcBuPLOnQXrB6xC0yQ8=;
 b=QrEnVWiAxPA3+n9OJvzlCSoC4ioQIFQ90aoMJAdHRYYZY6jQD+Q2yqXB/9EmQkCt8bLzdYU3PZmgWXjz5ThhkrPtA2iLffAbU67Uvk3qHbfn8Rw2rVwjOFRF//PRAwnjYGueHn6EXpcGleHbWdDo5rcVZ2IhKbPPRiEBySv8AgvxZXwg6qZvP7Fhrcn/8dpx/BbUJFZWpzNfOq1VDrh314yeH/8PMwAGhJyPYb6XESPv5JCRjqwwuRKBb9X8630dAtDcDiByhO9lFPAdlNABwpGKDb18GEFBGrFFfY8XqIVKmtjP1FnBUpXz4s/GFjd/ja8oe98yM6jIzg1iriqDKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3ZVPCmAawhP/ivgOYB1lMAEBPcBuPLOnQXrB6xC0yQ8=;
 b=zXHLab2OD1G7gWVKhhwxQvRZzvc19n/JUApRS1eDxHruuSlp5QOGgwhKUAOHPc+1359AcuxmRHGW7Qgi0ymTHri+DJyqOEeiPFV6lT84j8OQw4T8ZLzU9chM1xUe5ptHzmI11bBYpId91vkHV5CkEhr7Q+ctdvVuZbeAIPa4xs4=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4kjE8chHQ2hgBESCJmpSFAnjhK4UGfkAgAAAnDA=
Date: Tue, 18 Oct 2022 12:54:18 +0000
Message-ID:
 <AS8PR08MB7991C654A0DE223131D6635D92289@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221017165133.17066-1-Henry.Wang@arm.com>
 <9da32b0b-7e3c-ad38-01c6-9ae78bf92702@xen.org>
In-Reply-To: <9da32b0b-7e3c-ad38-01c6-9ae78bf92702@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 607CD119499FA74BA3053861FD7048D2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB7838:EE_|AM7EUR03FT024:EE_|AS2PR08MB9497:EE_
X-MS-Office365-Filtering-Correlation-Id: 2f68226c-460a-43e5-4f03-08dab107e76b
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2rtgllXRreyDz3acFMiz3orwvc7MQgnL8HnOdRWWtc57uHQqLRCyUULPyPnqwf5EvqOOftFbl5L4QD8EWYzF2rHM4tAUEPYlp2mo278lb2P+1Sj9ZnF/7JFGmv7UHtys0bd1p3Mp7JVQP9I1hcMcae5/fLcLmSA1+kzpOSSYX6XLYl2WSKUzXjgv2b3qTigmQnE07tNeG2XtD4ViPc9LFO/Pr+6TTEz6smW4YjEYkDYksUodGX4nb6PaiqjRBAgb2ofsmP1AZibfD8CGTBSmutHIDIZ4rTw+HyF7A847goPrlLSJE4CMTC2MBIIgkUz8uOlKvcr7FZ1jOnbpos+72GIkdGTWK+xPbdjTJ96FCy+mAubuiGjN0anmBQSGhQz5INIbCymou61k/vXFJ5upqNkXZX3PzmPLC714TQpKbA1S9JfhuGcB06c89HMF+QWvL6QRg0SPh/pu6p4xiIQ6S6IGobJNt9l/hd3fyxPRfBINBB25+QAgQgrTUskomRDxCX8h+/YSRA+6PCOqCENEkqadWLTUSWggsyxhY3bdranv6E/z8lXs1UfdhimOZWpeeUEk0ofWvx508TTgyb+8Rrr95FvFRvpCwIyapG9ngvfb7HuUdkCp8o07ro9AykzNBD2egFpwJSWsdmQG+YPNzebwCOg0aZlWl4ddiEzF4n7i/nJDwduVVdb80AS5esMTKmc5UvxNOGlmN7ofzuYoZ9MyktsO+BCEosL++IcW6TU94nO/4y4EtZlEASxV9C4HIaLwurWrRz7vCq1k2NDASQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(376002)(136003)(396003)(346002)(451199015)(71200400001)(54906003)(186003)(38070700005)(83380400001)(38100700002)(86362001)(5660300002)(122000001)(2906002)(7696005)(55016003)(8676002)(64756008)(52536014)(41300700001)(4326008)(9686003)(478600001)(8936002)(6506007)(316002)(66556008)(66446008)(76116006)(110136005)(66476007)(66946007)(26005)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7838
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bd6334b7-c0fd-45a0-29bf-08dab107deb4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	coplwlqysIKOMhjFXVe3lwKDsAuVOfzQ86RnO1vgxql7bZgsNy8Hi16FNeRijfcFMm2Ar15avgixDlDTNRWK0o3mKRx06Z059c6eypLdOmllw/+e9Y/WJgeemqS4OD6oNCDqmtB3B3zP4fcnTweqV86nceUcQDAazsqqLZ1W/64c4nSHQ7njaVxpn4rE3ShuL/mbmdwsDKsdLHMqNS7J5Qh55qP7bHwjtf+0TVGBxNOnNdxJQ/yD+Oz2aEYW0bIStI5GbHVLKJtQLZdm9kPXGGKg3T3UlRw/x2zj87DCDXTrlBwxl2Sg8Jq6Yq5LAdaDm6qVJptfvO0ylmSDe67bP+0Vi97MRwSg0W/b35O9Tm2zEoy+8MfJ59GPtDndCyn2RdUm6Q3ScLWO1bRzz1/sI/jVUGjx6o4wW+PP79Hte3QDSdy2bs8oXp0n/F0K7owATOReSBpENXDrn5hqWwWmFkiGm0lGmdjzvM9J2PS7epcl8SzhqqPMwZ4KtreaI917NNwz+t9eX2QHg2IzVVqTByS+LfoaI/0XpdvNtl5Hv7kmvp5LlD01z9tq7MnMwUe3RUmHgHGcxgy4rGyRrB/M255beoq56hYJP/0ps734ad+9YTJCEBZIVpIjDbiy/ZJB6jWpMatdvisMthXgrQaSjr4jwahTTs40QB32PlDW6HF7vn8zTKwjeAPRVfhUseqeS9sxDmrfewrrMEQImpwIFl4ck0ceFRPbM+6ZSeBsdh99ZxW+MmO84irZEvfaLJ9VkD0fQIUTs1dkz/og+uYfFA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(33656002)(86362001)(356005)(81166007)(82740400003)(186003)(6506007)(55016003)(40460700003)(2906002)(5660300002)(40480700001)(36860700001)(107886003)(7696005)(9686003)(478600001)(83380400001)(26005)(336012)(47076005)(4326008)(316002)(110136005)(54906003)(8936002)(82310400005)(70586007)(41300700001)(8676002)(52536014)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 12:54:33.1334
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f68226c-460a-43e5-4f03-08dab107e76b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9497

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjRdIHhlbi9h
cm06IHAybTogUG9wdWxhdGUgcGFnZXMgZm9yIEdJQ3YyIG1hcHBpbmcgaW4NCj4gYXJjaF9kb21h
aW5fY3JlYXRlKCkNCj4gPiAgICAgICBpZiAoIHAybS0+cm9vdCApDQo+ID4gQEAgLTE3ODQsNiAr
MTgwMCw4IEBAIGludCBwMm1faW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPiANCj4gQXMgQW5kcmV3
IHBvaW50ZWQgb3V0IHRoZSBjaGFuZ2UgaW4gcDJtX2luaXQoKSB3aWxsIGVuZCB1cCBsZWFraW5n
DQo+IGVpdGhlciB0aGUgVk1JRCBvciB0aGUgcm9vdCB0YWJsZS4NCj4gDQo+IEFuZHJldydzIHBh
dGNoICMxIFsxXSBzaG91bGQgaGVscCB0byBzb2x2ZSB0aGUgcHJvYmxlbS4gU28gSSB3b3VsZA0K
PiBzdWdnZXN0IHRvIHJlYmFzZSBvbiB0b3Agb2YgaXQuDQoNCk9mIGNvdXJzZS4gSSBhcHByZWNp
YXRlIEFuZHJldyB2ZXJ5IG11Y2ggZm9yIGZpbmRpbmcgdGhlIGlzc3VlLiBUbw0KcHJvcGVybHkg
c29sdmUgdGhlIHByb2JsZW0gYW5kIHJlZHVjZSB0aGUgYW1vdW50IG9mIHdvcmsgZnJvbQ0KbWFp
bnRhaW5lcnMsIEkgd2lsbCB0cnkgdG8gcmVzcGluIHRoZSBwYXRjaCBzZXJpZXMgKHdpdGggIzEg
ZnJvbSBBbmRyZXcNCmFuZCAjMiBmcm9tIG15IHJlYmFzZWQgcGF0Y2ggd2l0aCBjb21taXQgbWVz
c2FnZSBwcm9wZXJseSBhZGFwdGVkKS4NClNvIHRoYXQgZWl0aGVyIHdlIGRlY2lkZWQgdG8gcGlj
ayBBbmRyZXcncyB3aG9sZSBzZXJpZXMgb3IgQW5kcmV3J3MgIzENCnBsdXMgbXkgIzIsIHdlIGNh
biBmZXRjaCB0aGUgc2VyaWVzIGRpcmVjdGx5IGZyb20gTUwuDQoNClsuLi5dDQoNCj4gDQo+IE90
aGVyIHRoYW4gdGhhdCwgdGhlIGxvZ2ljIGxvb2tzIGdvb2QgdG8gbWUuIFRoaXMgaXMgZXZlbiBr
bm93bmluZyB0aGF0DQo+IEFuZHJldyBzYWlkIHRoZSBjb2RlIGlzIGJ1Z2d5LiBJIHNwZW50IHNv
bWUgdGltZSBzdGFycmluZyBhdCB0aGUgY29kZQ0KDQpUaGFua3MgZm9yIHlvdXIgdGltZSA6KQ0K
DQo+IGFuZCBjYW4ndCBmaWd1cmUgb3V0IHdoZXJlIHRoZSBpc3N1ZSBsaWVzIGJlY2F1c2UgcDJt
X3RlYXJkb3duKCkgd2lsbCBkbw0KPiBub3RoaW5nIHdoZW4gdGhlIGxpc3QgaXMgZW1wdHkuIElm
IGl0IGlzIG5vdCBlbXB0eSwgdGhlbiBpdCBpcw0KPiBndWFyYW50ZWVkIHRoYXQgdGhlIFZNSUQg
YW5kIHJvb3QgdGFibGUgaXMgYWxsb2NhdGVkLiBTbyB0aGUgY29kZSBsb29rcw0KPiBmdW5jdGlv
bmFsIGJ1dCBqdXN0IG5vdCBlZmZpY2llbnQuDQo+IA0KPiBXZSBhbHJlYWR5IGRpc2N1c3NlZCB0
aGUgbGF0dGVyIHBvaW50IGVhcmxpZXIgaW4gdGhlIHJldmlldyBhbmQgYWdyZWVkDQo+IHRvIGxv
b2sgYXQgaW1wcm92ZSBpdCBwb3N0IDQuMTcuDQo+IA0KPiBGb3IgdGhlIGZvcm1lciwgSSBhbSBo
YXBweSB0byBiZSBwcm92ZW4gd3JvbmcuIEJ1dCB0aGlzIGlzIGdvaW5nIHRvDQo+IHJlcXVpcmUg
bW9yZSBzdWJzdGFudGlhbCBleHBsYW5hdGlvbnMuDQoNCi4uLmhhdmluZyBzYWlkIHRoYXQsIGRl
ZmluaXRlbHkgbm8gcHJvYmxlbSBmb3IgbWUgdG8gd2FpdCBmb3IgYSBiaXQgZm9yDQp0aGUgZGlz
Y3Vzc2lvbiBjb250aW51ZXMuIFdlIGNhbiBwaWNrIHRoZSBtb3N0IHN1aXRhYmxlIHNlcmllcyB3
aGVuIHdlDQpyZWFjaCB0byB0aGUgY29uY2x1c2lvbi4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkN
Cg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 13:26:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 13:26:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425002.672726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okmc7-0005K8-DH; Tue, 18 Oct 2022 13:26:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425002.672726; Tue, 18 Oct 2022 13:26:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okmc7-0005K1-AX; Tue, 18 Oct 2022 13:26:35 +0000
Received: by outflank-mailman (input) for mailman id 425002;
 Tue, 18 Oct 2022 13:26:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okmc5-0005Jv-JH
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 13:26:33 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150043.outbound.protection.outlook.com [40.107.15.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7acdf0cd-4ee8-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 15:26:32 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct
 2022 13:26:28 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 13:26:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7acdf0cd-4ee8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a+Sm6LI14o3ca8LQb9e+CC9JdTr2lpeW1Tlbr5y3iLlKhfYZegALWr+mblsIb5hwQL56v0+SPyI1ah6ZRKA5ue1SZrJ86BE4bErTC6l51C674YOgjKGbhEcNemHhI6p7jchX31vVh2Up+Bva5SX0uQOctq/6v/X3u2u6X25SRLfNt9Lwj5lmqKmr+RcW221rLTltjmz1AyE8jxZMh62p9RsKRk9KtEbdYZZRZpCStB/VC6AitX5PP/wqGFIEnfPKxXAwfpjOkn6og9Nv+Bt/b+/Yp+K0FpLDxAYgdyhQhCSlk3PgGp4/eVH1CHPBT/BXpdvNsT8jdV54FdvrWp1P0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gclX7OTZ/dgr1mtcKCPuoV+U3KTDJR5J0WaTMbJGv7U=;
 b=LYJ8XxkuOmhaIUNUjro+ubJ/S18h5N97iRz/05zakfp2rIXrOltx7ASyKYA7CkmRnVXMarg0kFX3uzIjpd2TXulAUyFBFE4hkA9SOPfK2DZ4yv02Ndg7qHwTcclJdR7SCxz6UoKz1KCebenis6QxeF6at1E7bXRBzxQR653KoLvIZJrs6UemexHCiazhHbRW84yVU9vIdXCFELWYcKPVo/Z4x5QCP7Qq6ZoNEi4K7yfPtrLXqmTNyady7RgK+ek/k+lFYDDXAvMn7Fg46ij3Edqhhph8TV+yhTqez3klIOIgpg1SldsQGrpav6eJaHrj/zbdJcdGKOBpnQTNGO/jIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gclX7OTZ/dgr1mtcKCPuoV+U3KTDJR5J0WaTMbJGv7U=;
 b=15oOJ77h7DN/kAvdA7IxfJhH4pWDZf7P1nIuP0K1G1Ub9YJng5TcIaB33SthY/nwuu16nKA8SiAzBT1I1nlpnPi83jRsZ8dLo1C8jJCncty7GFemHu3QiPp+noVsmall5MY8aUqUNLRxnSiNgZQR0yDO65zajQBwX4+KyveEc5JlVbzJ8/r0Mt2eop2vrXsnUDlZveHWHGdLBHCzPO3guB/3LCgHDCtNah2Ny4a9znkiadb1dyYRNL5cExttosFIOivRe3ig9J1jLXCWOzmkvKrRvhDGfO2xqcbAM4IEbysXN7Dq9G7eR0fSNWrsw0SzmAg+jDTPLic5Sogh1eztcA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <06571c6b-533e-c580-fe4a-dc7d2213a801@suse.com>
Date: Tue, 18 Oct 2022 15:26:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v6 1/6] xen/x86: Provide helpers for common code to access
 acpi_numa
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-2-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011111708.1272985-2-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0105.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::6) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8790:EE_
X-MS-Office365-Filtering-Correlation-Id: c73f95e4-e0a0-419b-12bf-08dab10c5d01
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hf+HRShYsbhMFq+AxUiKuQ2LLLQMnM+CtO7xJbdAWYNfSEWTUu17VJ2X80kN5gTmNcZ86c0SG6AWRUVDFa7wRDbaLftJgy6Z9+GKc01/pNBZhk0Rl/kVgrLtalq5wpoH7jzr6pw2CGpFY546u8yKPD7xQKvVngtlToD2sjEM4sOwbgeA7wNn1BTzj8TkL39b9DVScyH4SfSK5KFZBJMRStTr2w9xzn64GIUZZAipH8Z4wbstduR+qSjSqX4J/BTTW2+YS/6dYmDstxO8uLTqE6Bj3Vc9FwjECGFtHEBqIkbWsRcYTVwsnbUz9X09eRsKeRniSZPAh6bxxL9MdAfcolVucFl3rTFvYSrqFQFy9aqaJs9VP0f6e82SVOkGWkrn+TJiSma+t3AEnyPCXUV1n3R+QYMW+Im5q4/6HSZgF6i89UMPDiv+Zq8hNDWuvkivHVeKWk23VsM80SvKWyRzRZsbT08fGzWVKmEUSKIad0Hn6EXl5fFysyRxh/OPDdfGMv8ZDrez0eYbysh+e/q5LB1BT+vam938IlfPx4Q/R1Zidh5XcqyGd6TRXgzGkR16LIOPVfZVTkU/SE306UAo4bUwP/qLHjfgHP6sWY68sIPm5iytzKvmPV2nJ658MUMi1KKqpY9VUvZLsH5Q6wGEdq+dA700GZRKvMBh6fJrkJhYx9IaEV6LiPENuWW4NaLyYYjD+T11ClfxlAGd2D5vaQNYEniiKfZw+irjn8Y7zgGaqpxQdvhEvAdRgcfn445IaL5T8qnHr0ifS11pepv+kp2cGTL1oi/UUXz7we6TpqE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199015)(26005)(41300700001)(186003)(6512007)(478600001)(2616005)(36756003)(2906002)(6506007)(86362001)(5660300002)(4326008)(53546011)(8936002)(31696002)(38100700002)(54906003)(6916009)(316002)(6486002)(8676002)(83380400001)(66946007)(66556008)(66476007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eDBLS2NoY29CVStoVnpKVk1IamNrYXFVaElNNXdaZE51RmZMa3dkT2JqelJT?=
 =?utf-8?B?b2FuOVh6TUxUU05kMkJlRTZLTzdpTjFsUnlRREE3dWw0MUtyVHUvNHpPMmg3?=
 =?utf-8?B?dmpoSDVOMFIvWDZuRFp6Y3lIOVBYdGpZNGZNcFQreVljQjRzNjZKQzBUdEdK?=
 =?utf-8?B?VC9YTmpaNDNTZ0VpSEVxZmpYamtZL2xJZXhOMzgwNWMwQjJ1YlBsQndNNzY4?=
 =?utf-8?B?OGdoN3YrRjF3cjk4RnZKNE5FNlp2THFSdUZLU05tMUFWdStGR0FCcFNZNllx?=
 =?utf-8?B?eFUxcGZYck1MZm5aOVZkcHYxUnU5c1NpSDQzbEdTM0o3Y1hrSXBzSmNuWDlK?=
 =?utf-8?B?VEZWNjU2eTN4MmlrMmhCWVdqaTNGYVhmeDBtbHp3TmtvOVY1SWhsNWl3WjV6?=
 =?utf-8?B?T1JPVTFScC9ad1d1WkxDSVovY2NiWFBPUzFYUkFDOStjcmVUQUhmUmV3QXhr?=
 =?utf-8?B?SFUwbWdIaGxjY0NVcmNCYXMvc285MDhRYVgwRlkxTUgxR2RDc0J3a05NcWR3?=
 =?utf-8?B?UTZ2UmkvYW9QZTBOUk5mVkN0N0plOStjbTVSb2ViZms4QzhuT2pEVC9kREJC?=
 =?utf-8?B?VUJ3OGdFdmowL0FTM1lXckNjVVI4MHRmcG56anNqdCtoOFNMVHIwOE9TVjZw?=
 =?utf-8?B?N1FWVWpCVFVwNTRsd3hxZUJSK1lRNkUxRy9LZk5HWUdFK3V2NkxZVmlBRmhM?=
 =?utf-8?B?VjRTOTVjeGdwSDI1YzlsTHRNc2U0NStnQWZnNFcrQXpGWUxSZlgwNjRkbWlQ?=
 =?utf-8?B?dUhXcVRFcjA5eFY3eTNCUGtta1U1S2VuanMycXNaQUZXK2IrSjdnTVFtQTA5?=
 =?utf-8?B?L3gxMG9EWHVJWDBGalZuaS9MLzZ0cTNmK3lUNlZPTmtHUUpkc01XaHMxRTVP?=
 =?utf-8?B?VU1UOFl5K25nc0ZrTlhYWDhaOG9JenlpdG5qVFRsWjgwU1MrQWNNQ3NZSmhS?=
 =?utf-8?B?dFlsYnJLdTZKWnJ4V055NlRnUG1FRDNpQkhPU1BPLzI4c05TMEMxaTdSV2tW?=
 =?utf-8?B?YVZFU3J2U2R3YU5IaE1ES0xYaHF2RG5EVENNNElGaVBBSmlROVZQVTNBYVpk?=
 =?utf-8?B?SnVsSjVqZkVxZ1gwTUV6T1BPL0lDRVE3dW8vK3RxejViSkorVGk3SjJ0WkFp?=
 =?utf-8?B?MjZHQU5KcDNRMjFwdU1JZExWT013WklMYVlFc1EwWnFSeVVZdStoRVpvRVQx?=
 =?utf-8?B?MDVucE5HQ2tzUkZQK3pGUTlzN2pHUG1VSUJUR2pKTExkcEVSLzlQMmg4VGxB?=
 =?utf-8?B?eHlIK0xCT0M4OGEyOUlNYzFqeVNOOFNKcTJzSnIxbldVckVnTTdzeFQ1Y2cz?=
 =?utf-8?B?Q0JHNGdlMXh5ZUl4ZjJuL1B2Ri9uOHh5eGNYUVJ0YmlCMDU3aWM1SU9pQ0Qw?=
 =?utf-8?B?ZEdTbUxxcDhiYU1DbURldjBIY2FtNXUxb21tL1kvUHMrRE01NjBxU1YrakpP?=
 =?utf-8?B?c09tWHFseC9idHFGWkdMclNNWXJRdGhNV0xKTkY0UDhFY2M5ZkVEVkRBL01N?=
 =?utf-8?B?QzBERkNCNnpMbGNlL1h4L09NMDU5dnJTNWVqd0RQZEM4S1g1ZWNxL0t1bHBW?=
 =?utf-8?B?ZXJUWkZXZG5kd0oyVEo2YXh1S3hCcHpFc3h5U05rS0NmMzZ3ZU1BQmRDMXV1?=
 =?utf-8?B?TGc4Zzd6OWs0Z0lMTzdOOUQ1VjFHY1JCTDdJSGpHa3ErR1hHcVFabUpkZGFX?=
 =?utf-8?B?OGNLakFEalo2dHRPenYrVWdnMWNvS2RIcXNISnFnOUFXR3c2NEV5Y241Qlg2?=
 =?utf-8?B?bjhqY01VZjBJajBQL20wQXBKYkQ4TVFBdlVLYTVKV3JFbFdqMlpvNy91SEln?=
 =?utf-8?B?dDhqUHY3VnRoc2RiUFFMdEN4clBhdndLczgwVmlFSnYrOUZEN3o4Tnp0a081?=
 =?utf-8?B?T1JiUkhvSHQ4U0VVTWdmYjZCNldUZUNrcVRVR3E0YTdEdzkzb25jNjRwSzV1?=
 =?utf-8?B?Vk5iRjRCamdWMUYwS2o4T2pFVmk3VWhWclJZanZvL1NUV3FxSWNjWnJkZ2FN?=
 =?utf-8?B?SThNckVnbVc0bHlzc3E1Smp6dFI3WDNvLzBkcnlzWWg0bzEzQUNISWNWZnlw?=
 =?utf-8?B?ZXozaEM5ckxsRW44bGNxdnZ0N01hYmJiN01hSWVoaHFxWCtVMVJvUzdQdTNj?=
 =?utf-8?Q?w/gywqoY5IyGB0MuSKP7+gv4Z?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c73f95e4-e0a0-419b-12bf-08dab10c5d01
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 13:26:28.6140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sKJxcMllkpxslhWWnqVgoQdqHtIhbakS+gipfVQhBzZX8SH6cde8Y9CM6b7VS1MG6ydanei1U6yUs+OdpAEjqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8790

On 11.10.2022 13:17, Wei Chen wrote:
> acpi_numa is a specific NUMA switch for ACPI NUMA implementation.
> Other NUMA implementation may not need this switch. But this switch is
> not only used by ACPI code, it is also used directly in some general
> NUMA logic code. So far this hasn't caused any problem because Xen only
> has x86 implementing ACPI NUMA, but now Arm is implementing device tree
> based NUMA. Accesssing acpi_numa directly in some functions will be a
> block of reusing NUMA common code. It is also difficult for us to replace
> it with a new generic switch, because it is hard to prove that the new
> switch states can guarantee the original code will work correctly.
> 
> So in this patch, we provide two helpers for common code to update and
> get states of acpi_numa. And other new NUMA implementations just need
> to provide the same helpers for common code. In this case, the generic
> NUMA logic code can be reused by all NUMA implementations.
> 
> Signed-off-by: Wei Chen <wei.chen@arm.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Tue Oct 18 13:46:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 13:46:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425010.672741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okmuv-0007z2-5S; Tue, 18 Oct 2022 13:46:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425010.672741; Tue, 18 Oct 2022 13:46:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okmuv-0007yv-28; Tue, 18 Oct 2022 13:46:01 +0000
Received: by outflank-mailman (input) for mailman id 425010;
 Tue, 18 Oct 2022 13:46:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okmuu-0007yp-0t
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 13:46:00 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 323a8099-4eeb-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 15:45:59 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7772.eurprd04.prod.outlook.com (2603:10a6:10:1e3::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct
 2022 13:45:56 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 13:45:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 323a8099-4eeb-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FZCBCTlAF6Q1yf6vxWI3jxEZCRuaYM1Bkw6h23ewd28WPnkcuZhTFq807WDwnbSaWaigO3Hqb688M/W27k24xVlJPYJcjvUZ0s4cZ/YkxsTDzFbBtbxUKiykCocyH5K3FuogkN+OZnanErFPCtsgPIbIod2wpBvsrBFMq3YYt2PViGLMTIQHpvv57NuJ3aFG0oaBJAiz6Pd9u+Q8AiUzokcKg+mAPREokSlngM6QNkWNtgdI2CvJA3Fhwd84q0Va4Q8qmyN+5akS7Ukr6tNf5ojqnIK3FAkVeiFgu4oIN578jFh9aqdCDvliaOvpfgD1igHwjgcO0x9kV49/mzgbqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hXRxwaWaXAkHACvM+MNdQovDSnV3EImA1Wlpni37DgM=;
 b=YO6+l1dFZnoycpKbkmdH1hj6bz1R2aetMG4n+vTZYNVR9oVFuERd7MFMhi2rcoa0EzvtGWa5rwVUJEoS90QBJ/AtP3k1rLCAE8Ns5CUsv1hV/4l7bFhUGDpGQmL3P80pBNzJvVOgHe3j3+ve/R++vDDtKe5gGZGojJ7ItyZusivlnmEefpm98LJCTsmaBQpn+A9Qi0pXQJCLPxp42X5BfovtDD2bVSavWdk3ftizp8mioRKNGfvt3rltWBiTnxGwR/HH+MluTQykkofLKcHxfVe/MI5ApV67JuU+SrVYWTzsRbGBjBWwifSajjk0Lu8g2X6fyWafsg8JaVl9+YFXgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hXRxwaWaXAkHACvM+MNdQovDSnV3EImA1Wlpni37DgM=;
 b=o2VOpqlE6YDJKf0xqOyV8wiIJTYECwpw9rO4m/gNDoIea2bHO3c7ZiLZ5hszk/ToTaTLLb2lkYqvUR4v5QEGP1RQQgl/st1/rQy2u3JtuO6zgAlBU3bHsbFtiJ8S7JBghncI7BO7evLXcHIdaVE/aqC3mvwYaH3la+Bdb4JF5Yyw3zHTNiVxEJAnTB6x/ODN5JbgJi/dQ/Pf4KXbH3DcK5CzUJLeYNikPLYUsPYkGJERkHIS/iVu0GwEL/AWey/6jtKIS/UOAAscqEpWPDMYUzOtdAFqkQQpfhj2zNo1CEC0G6SUAZKkI7iVsBoDY4s+G1SBPpuedwgtv1p0J9BpmA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
Date: Tue, 18 Oct 2022 15:45:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011111708.1272985-3-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0023.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::7) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7772:EE_
X-MS-Office365-Filtering-Correlation-Id: a1611252-ba19-4734-7358-08dab10f14bb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lMNLDGvmTjzX1VfQda9ZAxG/+ao1ftFlJL1QMeQexfehYJjjI6wM7kb1ISF5Zl/Iu7JXn1TPbYXN/hf3CiMYzH3KoSB9SQLOr7J0wHApNopjn9qRuJ2ompjmA33wobx7gKKiNSro96DdTMMY9zpCX3PIMyDYFZSuu2VPeluWmP8dPJpQLKnu+xxIDna7jh5CCeE5ylVPLAiZ7g95BmtpjGEHeKSjCCVD4V/9KlRf6HEY1VO+gaNf0vRzv23jaSwBPjFOmyzBL11L8NyHrMtO262Q62YU1+DmsVO7Oq03ahXwIXe0CnPYzgOqaOM/zqtzMQ9RoDQw/XewhDljUVzFIu2p10KAsg2MBQfU8Ty2xZLDoW/h5CONxuoTC2VGsiulCOX5UwzJLAYrfgZBfh0mzT7VsMPzP2Pn6Q5zS3sSioTKUrbMfsek+egwOiB3kvB38Ib+AlhNS+PxBxI4lXkDUkdRpehYkliNW7FfhYjffx5kL0i6sPfRNJP7Jv9hz0rwK70vWeldqu9BbNBy46rcy0WE7y0EYdRSd8SYhpLHjhFHQKbU8dhyQ9Xs34xw/lBIqUqgnXHBCi5R0koMZM65FbQ3VMwLvsMz1DC4oOOKCw7WnehvjoPET6flbF6vA6/LlSaoZrsepnh0xgGe8eFpOsYTxa3ccagHuefrBw5nN3QiUPiFt0pZRBEVD+xiOkw/mbx5v3RE1cydPHagWZuVKyrlqotnXOh5UGlcGfB12S8g09ZWi429KW39GNqvS8sBAxz72Xo3hPxFmfqgi7FeQhWEBXZx0A+tfZMac7Uf5/M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(396003)(136003)(376002)(366004)(451199015)(31686004)(6506007)(2906002)(36756003)(8936002)(31696002)(86362001)(53546011)(4326008)(5660300002)(6512007)(26005)(41300700001)(186003)(2616005)(478600001)(8676002)(6486002)(66946007)(83380400001)(66476007)(66556008)(38100700002)(6916009)(54906003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mk9LdDhkb01oZUFSMDY4eDZqbHhLWEVmRk9PQ3h3TWNzaDVTb0JOUWErUk5W?=
 =?utf-8?B?K2I1cVBCdTNXc1RPTTEwZnIybWJpZ1lwWkVjT1E2eWdmdlM2S0l0Wk5qQ0k5?=
 =?utf-8?B?YUs4TUlXamtjZnBiRy9XblVDbkYxMXBUVkRoTnlCYlNzU1h0Z3hTL3ZLOUUz?=
 =?utf-8?B?MjNtWElyN2VTeWdObmgyWkpwbllSN2s4UFBUcnFDVjRVcE8xUVgxNHJIUmti?=
 =?utf-8?B?anVHb2xlbVdrak04enZXRE54dHBGRE54WGFzSkgxd2VQTmVDUUdlZ1R1M0Rn?=
 =?utf-8?B?a29YaXRwMktucXJybWZTaFFTNndxd1VPeWtsU1hiQ21xenBPMjhEc01oWktE?=
 =?utf-8?B?NGpBWWxxMTR6SzZHREtlNmpWNlNMZGduNitkSldkRVVFZ0d1QXZlQ3pVaTVa?=
 =?utf-8?B?STRKSk1jTUF6bHJXTTlxaUc1NEh1ZjlJZEhLNDFNelJyb1pUaW5WMTRIYUVt?=
 =?utf-8?B?d1JGS1MzUGZSL2NKSFRNNk1BVGVDTWI5YWJsYUYxZ3V4QzYxcy81YUM2b1p4?=
 =?utf-8?B?clVwTDBCbWpEQm9UZXV1SGxWSk8ycU5aaFFoTFYvZXZhRmZFamhWMXcvYjFI?=
 =?utf-8?B?M2dkT0dCZjBaYStYVExyL3hxN3AxTEd1WFNwTDFLL0NXWVAxYzU3TnJXSTJC?=
 =?utf-8?B?akgyZzY0b2E3b3RDTkpBWlY3Q29TRUhYcVJBRC83TTNLeks5bHJsVU5rVzl4?=
 =?utf-8?B?elZCVHB4cVQ3ZlZCdXlibW1jTVFUZVNpNnBidC9IOXlsNWxoeXJPaGR4Vzg0?=
 =?utf-8?B?bXpjOHVBR0lZeldmRVlnQVNCSjJvMndWY205Q3FnamNqTUdQWUEvQUwydnRH?=
 =?utf-8?B?RFBVNDA3cmFuMFMxR1lkNUpFeEthcVgwbysxbEpFYW1rWk0rZWVwOEpSWjhl?=
 =?utf-8?B?OEFFdmV3a0duM0tQaHBOV2s0cm5TVGFxRXI0TnI5Yk9wenpRM3o3Mm9LWWZr?=
 =?utf-8?B?ZkZtTXBJK3NxYXZJM1BYeGJic0lUWGxJZUtoT1dKUERleWdGL1ltaGxoQVgr?=
 =?utf-8?B?SUp1VUlYTWVKRE9sMTlFTWpSSHF0M24wZXJxZzRtRE9WK0k4dXo0Y2Q1YWpk?=
 =?utf-8?B?dDBGNDlrUTJDMzZxeE9pRjdISGdicDlLcTZ1U1k0dDRSVmlYVnhPQTZuNkZM?=
 =?utf-8?B?NFhialdUOE5NRE5RREJzSk51ZzZqTFdnTFZ6NUZJVzN3Y1ZMSlM5YXkxdlBo?=
 =?utf-8?B?SkRycGg4Mm5hUXRxanRrdDdtT0tCWm9keTlSbmp6Yy9EM0VCU0hzZld6bFF2?=
 =?utf-8?B?VUpPeGVRSkN4MUZaTStCVHdQWVFJaGxITnk1a1g0NFBBYjV6ZWFNWkUvYTVQ?=
 =?utf-8?B?Sk9uMnlZUS92SFdvWTZzOXMrS0xKSWtXQUNodFg5R1pHSjkvV2FSblhMcGt5?=
 =?utf-8?B?ZkNia0wrREUrbXV4Rmd2ZG1DZzNhWjNvRDQrQnVaSHFsOWZMeXlzOHNnVzA4?=
 =?utf-8?B?RTZadmhWZllhZldCSjh4RENyaGpQMmNTVVlJSVl6WU9ka1FsMVFsbndJeWl5?=
 =?utf-8?B?WUp3bFh4TUZZd1FCM1lrcW8rUjhnRHhFem1McGtTK1pjaVdFRGc4S2ZJNS9h?=
 =?utf-8?B?YnRRYVZ4VUtab2d4clR4Wjl1Qmo1b3FPd3ZxbnByckxQZzYybkJGYVVJaDMw?=
 =?utf-8?B?dW56alZKb0xpY1JpWkd0eWluVGhYelZ1ZkVYK1pxWTZ5T2MrTGlpQmowdUlq?=
 =?utf-8?B?WXlETHE4czdNSVhuZlIwN292QTlTNzNwOXlrbDZST1hDTFFkd0tsWHVpTDBy?=
 =?utf-8?B?ejRiSkNKelJnSThTeTNtQXh3eGliaUNNaytRYVZOTVRGN2U1UGptRk1Sd3FB?=
 =?utf-8?B?Q1NzNGlqNk1uQVpiS0ZxTUd0Ky9yV1dBUzhuVFlEUVo3STJwT3IxcURWR0pV?=
 =?utf-8?B?Um9kNitlZCtWYnJXRVhSa2kzdDFZN2w5eHM2ZDc1ZzdlTm9QMDJPbENEYmlM?=
 =?utf-8?B?MmpTblhnZjZDS0oxQkxHbVoxa0NYUHYzdjhXNTJhVDlTdG1BVk9DSHJ2Z3Fn?=
 =?utf-8?B?K1dqczlGRENqTTZnNk0vb0ErOEVLdGo0cVhISjJSMVNMNlRiNzRqNTNHcUxP?=
 =?utf-8?B?cTJBbUlLaEYzNDd2MzZnSlRWL2NsRTBOcjcwYzRNWmgvSVRSVlVDUmoxSnJV?=
 =?utf-8?Q?zk05FiPiWiwf4VMxUGUif+0Rv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1611252-ba19-4734-7358-08dab10f14bb
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 13:45:55.7895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ct+bY3hfPcMcXTGGwLWwWNwC2piecAIJ69deW6dyaHOC9fj6q9Ed3Hc6sjP8l1EzXCrFqvV77U3ENP5C4X8ouQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7772

On 11.10.2022 13:17, Wei Chen wrote:
> v5 -> v6:
>  1. Replace numa_scan_node to numa_process_nodes in commit log.
>  2. Limit the scope of page_num_node, vnuma and page of numa_setup
>     function.
>  3. Use memset to init page_num_node instead of for_each_online_node.
>  4. Use %u instead of %d for nodeid_t and j in numa_setup print
>     messages.

The only instances of nodeid_t typed variable uses that I was able to
find are in dump_numa(). I guess you can leave them that way, but
strictly speaking %u isn't correct to use for nodeid_t (as it promotes
to int, not to unsigned int).

>  5. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift
>     when only one node is in the system.

This change needs mentioning / justifying in the description.

> +static void cf_check dump_numa(unsigned char key)
> +{
> +    s_time_t now = NOW();
> +    unsigned int i, j, n;
> +    struct domain *d;
> +
> +    printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key,
> +           now);
> +
> +    for_each_online_node ( i )
> +    {
> +        paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1);
> +
> +        printk("NODE%u start->%lu size->%lu free->%lu\n",
> +               i, node_start_pfn(i), node_spanned_pages(i),
> +               avail_node_heap_pages(i));
> +        /* Sanity check phys_to_nid() */
> +        if ( phys_to_nid(pa) != i )
> +            printk("phys_to_nid(%"PRIpaddr") -> %u should be %u\n",
> +                   pa, phys_to_nid(pa), i);
> +    }
> +
> +    j = cpumask_first(&cpu_online_map);
> +    n = 0;
> +    for_each_online_cpu ( i )
> +    {
> +        if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] )
> +        {
> +            if ( n > 1 )
> +                printk("CPU%u...%u -> NODE%u\n", j, j + n - 1, cpu_to_node[j]);
> +            else
> +                printk("CPU%u -> NODE%u\n", j, cpu_to_node[j]);
> +            j = i;
> +            n = 1;
> +        }
> +        else
> +            ++n;
> +    }
> +    if ( n > 1 )
> +        printk("CPU%u...%u -> NODE%u\n", j, j + n - 1, cpu_to_node[j]);
> +    else
> +        printk("CPU%u -> NODE%u\n", j, cpu_to_node[j]);
> +
> +    rcu_read_lock(&domlist_read_lock);
> +
> +    printk("Memory location of each domain:\n");
> +    for_each_domain ( d )
> +    {
> +        const struct page_info *page;
> +        unsigned int page_num_node[MAX_NUMNODES];
> +        const struct vnuma_info *vnuma;
> +
> +        process_pending_softirqs();
> +
> +        printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d));

Perhaps switch to using %pd here?

> +        memset(page_num_node, 0, sizeof(unsigned int) * MAX_NUMNODES);

Simply (and less fragile) sizeof(page_num_node)?

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 13:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 13:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425016.672751 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okn6G-0001BN-7b; Tue, 18 Oct 2022 13:57:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425016.672751; Tue, 18 Oct 2022 13:57:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okn6G-0001BG-4r; Tue, 18 Oct 2022 13:57:44 +0000
Received: by outflank-mailman (input) for mailman id 425016;
 Tue, 18 Oct 2022 13:57:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xG/W=2T=gmail.com=liu.denton@srs-se1.protection.inumbo.net>)
 id 1okn6E-0001BA-FX
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 13:57:42 +0000
Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com
 [2607:f8b0:4864:20::1032])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d489b4df-4eec-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 15:57:41 +0200 (CEST)
Received: by mail-pj1-x1032.google.com with SMTP id
 t10-20020a17090a4e4a00b0020af4bcae10so14053980pjl.3
 for <xen-devel@lists.xenproject.org>; Tue, 18 Oct 2022 06:57:41 -0700 (PDT)
Received: from generichostname (136-25-1-99.cab.webpass.net. [136.25.1.99])
 by smtp.gmail.com with ESMTPSA id
 p184-20020a625bc1000000b005618189b0ffsm9283724pfb.104.2022.10.18.06.57.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 18 Oct 2022 06:57:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d489b4df-4eec-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=UB/TlnNYsdNPB64JcYN58oKOc/BijMwEPi/j10gC6mU=;
        b=DOfpZpkvwLL0QoaOZOMbcptHsCgdeop4zAPIoCfdcWrTtU4CCk0S01yi07lZCilLFw
         IH9N5p0ELman9A1Is4rG4iD97WR5e1pSvs+X0Zueky4feV4WLe53BQNs5bioVo5xFFOT
         Pmo9kB9gz/AXfeG4pmRqsgUN+73OJZV67mQNLyY3KvViTHxaqcEkTFqY+jzVMfolT32+
         av//szEDB24IgsvDviYyn58IWukUU6BvC6yFO9wfI75Dv6GLVjSfxE03CT0OiiVmsQ23
         FiEvlXy9IhPKfrw3lFgUnAFBbM8jS8i52AMwD3cVicH8WhsMnfpUlQ0krrWFQK2a7XH1
         seVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=UB/TlnNYsdNPB64JcYN58oKOc/BijMwEPi/j10gC6mU=;
        b=Ucu/evu75WdYu1062EEjD1zPBZgon9belP4huq9Ztte4pj3AUN3uAjEhY7huao7fK7
         Nk7LqJhscNpujY+wtjEOnQql3xZUhe118dGEwS4yiSVQ7qHul/gusuvNUEOpVY1vWcDR
         jonsge/TOND6lWkhntHkCHy2ZApUbKBB7s48chSOonx1Bq1fW0E3Bk8l1BhM1UP9285l
         WVqMdE2K9XL8EQxsJMH4No6PwUuTF82ruZjBcMjq6FooKycxD95MdF1InLpdoaydfKOu
         SPcJFya74jYL54PoqBiyLTxwAxhxXn28ThPjseVoMdYyCCE2l/oSLnNHpqG9iUZVi8xW
         DHWA==
X-Gm-Message-State: ACrzQf1tWgsTlwatRHg+tCPZVGwOpTqxcNRQv347BuVIAXEcn3gd14PL
	j/J/n8VzmnBARm9qtBhivZo=
X-Google-Smtp-Source: AMsMyM5KE8Pew8snuRuW41KbHugJ5K70JaRVKTiStYdtAFtcpyET6zZR9tkLt42iwt82AQr2C9a17Q==
X-Received: by 2002:a17:902:7296:b0:180:1330:b3c0 with SMTP id d22-20020a170902729600b001801330b3c0mr3142346pll.170.1666101459718;
        Tue, 18 Oct 2022 06:57:39 -0700 (PDT)
Date: Tue, 18 Oct 2022 06:57:36 -0700
From: Denton Liu <liu.denton@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <Y06w0Oda0sHTHPNW@generichostname>
References: <20221017103532.845293-1-liu.denton@gmail.com>
 <20221018131235.5e70f0bc.olaf@aepfle.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221018131235.5e70f0bc.olaf@aepfle.de>

Hi Olaf,

On Tue, Oct 18, 2022 at 01:12:35PM +0200, Olaf Hering wrote:
> Mon, 17 Oct 2022 03:35:32 -0700 Denton Liu <liu.denton@gmail.com>:
> 
> > A user may wish to use an image that is not sorted as the "latest"
> > version as the top-level entry. 
> 
> Correct.
> 
> What is really required is some form of file pattern matching and to use --id= in "menuentry title" commands.
> 
> That way one can have the "latest" of /boot/${short_pattern} as default entry, in case there are multiple variants of files matching ${short_pattern}. The pattern gets enabled with "grub-set-default pattern".

If I'm understanding correctly, what you're proposing is a mechanism for
setting the default entry. If I'm not mistaken, this seems like an
orthogonal discussion to me. My patch proposes a method of setting the
top-level menu entry while this method only sets the default entry,
which may be hidden behind a submenu.

In my case, I keep a LTS kernel as backup but primarily use the latest
kernel as my daily driver. I only ever boot into the LTS kernel in case
there are any breakages, which is quite rare. As such, while it is
possible for me to configure my default to point within a submenu to the
non-LTS kernel, it seems like a bad user experience for Grub to impose a
top-level entry on the user, even if that entry is almost never used.

Allowing users to configure the top-level entry to fit their needs would
certainly make for happier users.

Thanks,
Denton


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:08:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:08:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425022.672763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknGR-0002qE-7E; Tue, 18 Oct 2022 14:08:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425022.672763; Tue, 18 Oct 2022 14:08:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknGR-0002q7-3m; Tue, 18 Oct 2022 14:08:15 +0000
Received: by outflank-mailman (input) for mailman id 425022;
 Tue, 18 Oct 2022 14:08:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oknGQ-0002q1-1i
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:08:14 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2055.outbound.protection.outlook.com [40.107.104.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d39bf05-4eee-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 16:08:12 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8389.eurprd04.prod.outlook.com (2603:10a6:102:1bf::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 14:08:10 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 14:08:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d39bf05-4eee-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n9ghjj9iT8AaKNZURuxV7OZuyLaSfk3pY4ptq/6LW0BlRYqgKna8EDwe4TnwCObMf4FY5PsOG/cFV14+ejHxH2JbVktse2qtDzwgJaEXM3Diah4oRcrqy5GtIAvIec4+YBCz436sKAcgK2eF8e6grXkonwMiGyMVmEcDomzj6KiVfwvQafPWDLKX+w3ee6cToBBB9o40ughewtbAeo6sAYc/Vo2dw7aHk0RtUTS6fhJiYel5JLXhiiSh3NptbU8NP8G+PSsBdnkrqh0RFaTnBEEO85rYTE2VKqA1wBokXbD2gifh/6GGUQ1EbUQSMpIkMRxnL0b2eQdEK5qMny4w3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k3pNf35GFmxwtZfw7iXig4qJ/cZlVHnspzfN5CpLGbY=;
 b=i1G2aiyXl7oZW+axRgsPBVP2EbqcZ9JKRRPuXA3pY2pA+Q89l4slgfQXorxERZg+Y5j2+OfFjtJ9TV6ZEqPaZpefrpAqiLk52DGafB0N3oXbdJfOWBc9GDf3NdCSXdh9woEojZ7j8ONSQnBXiFucgD/d/DOSy85MNusM16EAd34BgD3Nkkh8aPVuvREDcsdqN8pTu00aQmi66WM2+S3hNSbN53uNqiSk/BCHHZCJQKn5TA3Lt/kcLYI5ddyUa0B4UiEfF0aVOB04kVO2Y5wMdhKOhadr+X38YEZRlPOoqy25wjTBDB1hQkLcp3DUIav4e+B6oUPHdjy/xwHbSkP6TQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k3pNf35GFmxwtZfw7iXig4qJ/cZlVHnspzfN5CpLGbY=;
 b=GtdHSUKPh7BtDbOfA+gHrypX3YMNnRTGeDVcJwzZKt+r08qwugv7sjBpn8WnJK2tH9UpSJ0D45D9LVvBoJNaGzbCu12LQs9TUIgdBlx1kwwkvs/fzXv7fLkHrS3xfeyT9qMdVsTKiXJPt8y/C7OJ3Z/BgIQwN7rsthCS5y0q++e5s8V6UV1dKbucHhD9PabuEymIe+/tDMs2kEhjP4mIxZl/2ltabe8lrii9F4ZYU9ZcDT08voReNVDp08yAOeXiYXg0cgQOkSv1lUzhNNVn+4z/Dmxlxep3i/Ivc0gyZpOWWhMuLWi8pGDE92eLK9V5ngNZGGrvKHChoh+zUA/bmw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <298666d7-f007-fb3e-99ab-18b01ad48b00@suse.com>
Date: Tue, 18 Oct 2022 16:08:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v6 5/6] xen/x86: move NUMA process nodes nodes code from
 x86 to common
Content-Language: en-US
To: Wei Chen <wei.chen@arm.com>
Cc: nd@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-6-wei.chen@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221011111708.1272985-6-wei.chen@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0106.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8389:EE_
X-MS-Office365-Filtering-Correlation-Id: ee3dfc43-b7a6-4071-1390-08dab112304d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TmS6OoDXZKOdstcanh12VltMGA3JbqdqAfHIbbsX66wVn/qA6yL2gbbxTGX5Q5hnapPczuC5mwi6Q6ncWfnUFuXGj3/2pr12P0+dISHkg689J6h3gB7slZdyM0kH915Xxm8WiKyp9HJMmIfwS0IIuZoNgvBYePG1OJUq7IEvu3mn/jNYbJA+E0FfEaVHmaa96Fio+Tl78Upj2dYfa98GaAjW9CY4lVOLG3xucZo+UYzL8KKPhEuZASmmAvqzXsiT6owGUCrr+/5aNugErKzj/DVo+DE576dntQBAQ25HqkKdG5zkTdBYj04VUebo98p8+kqSWVFerXdK63tfOnFyFN7jGN1spmlFBeqFaamserY+w9rz9rW51jALF/73iSV9PPqtsvzGYEQq7Wzg2W+5DonN/L1yp+aDGDvC3/iU3coMblEXNvBv03HoSD/p9HshwPfc0+kkD8fiM1eB+qYRQYOR5Evb6jig4ptN5KGIpzyerPQk/CMjmREwQCvkOU8gLW8/5tpp63JeMDFSUgRS3Ge5xQUFfCJJEegHoq6NkXkXP+u4eB4yG2609Y0WW0mkuz54XpgWr6yIeavShUe53yQxpO9mzVzTk4ZP24F5eTL0y0rPsCBT7vquabGyzYn4dBCxPmhs+cjtE55jOfXe0SkcSTs9xlFnUFSSAWpmJumCQ9Av/07JC/ESfwVcJUcQsRhpKAWyD5nklpVt9LtzU+nvQoczQWVADyzM1FB8roUF/+rNup64otovWqEDB+rl4U2WAqCQgdtSeH0wU5Ri17g6NIOrKev9keKQ7wzNYFw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(31696002)(38100700002)(66476007)(66556008)(316002)(31686004)(5660300002)(54906003)(6916009)(8936002)(6486002)(186003)(2906002)(4326008)(2616005)(66946007)(6506007)(478600001)(6512007)(26005)(53546011)(8676002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NkxzTVA1TW5mYjNqaURpdHVKMnpkNnFmREloVFhYWURHdk1XMVZOcW1IMUMv?=
 =?utf-8?B?WEt0Nk1LcUtUUENtalBGTXo5b0tYenRLcXZLMG9teTFWUi82blBOaW80WHVk?=
 =?utf-8?B?NDdGWHRqMWV1Ym9YdlJGaTY2V2R0Yk9oVnF5dmsrVklMUkxmN2RFQ0tpWFJ3?=
 =?utf-8?B?LzhlQVg1WUx4K05xR3VMTkM0MDdYRHRRc1IxdnpzenAwOExzKy9pYUJoYVZi?=
 =?utf-8?B?a1crVDRIc2hXUGtmTTVZbnJiQmhuWFJBOVhaVThiNGZBT0F2aHpDZUVEeVVj?=
 =?utf-8?B?cDlMbTg3UWR0MzYxYWo1SnByRWRYYlNhbmNYcXV3aWpxaGxiMkhndzN6TFFy?=
 =?utf-8?B?NmY4T2NNSm1OWnRXaDZLNE01UFFPaWk5d3pYbTFSektWL2dqY1gwUTl4WXRa?=
 =?utf-8?B?YU9VZ1FrWFJ6OEp4a2t0TTM1SVJ1SW85d05UdHRWVW5ZdWtQd1pWRi9vK2sv?=
 =?utf-8?B?dTBrM1I1ZXRzS1lGUG4rMlpvTVpXeHEybVFNQ3JtTkxSYitycGJ2bU9HRFpH?=
 =?utf-8?B?K0psR1pOQS9heitvZllBeEd0c1dRYzNMTjNLR09aT09Tb0s5bW5RTXBLM25V?=
 =?utf-8?B?Skc3VG0rUlF2bk1najhJRm51bk1lWWVxMkhnYnRwcjlsSEhiVlo2d29KKzVH?=
 =?utf-8?B?dDFJeEEzNlJPMXZlS0lWWWJmMzQ3c21XbmhOb0NxdmJoekdoeUxmUU5jNzJH?=
 =?utf-8?B?S2xKTllST3EwR1NVQkt0UytIVEduZXllakVYaEdWdU5EeGtGSmhiVVhaYWp4?=
 =?utf-8?B?SWlJNGl1SURKd3ZMVVVlT2lOT2svRmZaZjA3MlJOVFZqNG1LVUZqcUtzYjdT?=
 =?utf-8?B?YWo5d2FoRXV1REVpN3hjWkpPcmNVVG41VURHU0tUSmJRQUZkMFNPS1hVZmJE?=
 =?utf-8?B?bm9UMlJWWkdLOWV1N1pXR3AyQVZsWUpUdi9ScFZkcnRHbkxOK2FkWmF2SnhM?=
 =?utf-8?B?QXNlSFBVSzhJTWxyTjVLUUEvQ0dWdlBPR1FVZXdnQkF1MEQ1NzZnMm9xd2tL?=
 =?utf-8?B?UGhBOWxnYXFEQXl5M1hDNW4xa3RubmJ1MHJKakhxUnowUTVEY1JpT3pxanha?=
 =?utf-8?B?cGFuaDhLQ0YxYmRIWVIweWQwckFNNCt3emlIT3ZDMHNPTDNMdkFTVzdhSWJz?=
 =?utf-8?B?MWFjd0hIRDZFVWFLUGJWTkJNVDZaWlAzUHNGQzF5UFB5R0JadGRzbkIxblJ2?=
 =?utf-8?B?REtvMEVXWGExN3M4NXpIWENES29uc2ZXSUF4NmdzbDdFWkxjUndQZndPRTY1?=
 =?utf-8?B?cUV6endJVisrU2VBVXhYU1k4Q0hEVXBTTTNlRHVTbGpta3ZBVHB1VkpyOHBl?=
 =?utf-8?B?OXYyNWN3TE9EVW1SVmVDRnArSWgyRURWYmMyNEMxZUxTVmxBTlVDZzYwTG9L?=
 =?utf-8?B?THhhRGV3REkxTitTWDV3VUJGUEVkK09tTDdVZWdkNzZLUnlnYjBmYWp2R25H?=
 =?utf-8?B?VGxMZkVUeFpYekYveXl4Y1gvL3ZYbkNJaTV4V2MvbDRoalJ3enB5MjU0bDUy?=
 =?utf-8?B?M25reVFSQ2VCZ0xYc2RlYld5eTYzdmtEakJlQU1DOUlHUnZ5N3hQakE0aThv?=
 =?utf-8?B?dGJjRTMxMm9BaEFad3VsVWJqUWVlQWZVWTJFclNqN0c5aWFvaC9PM20wWmwv?=
 =?utf-8?B?VG1jN0g1RlhKZUZmSDRQbVF5U0xIa0FYY3ZjUHBTUE5Nd05pc1VnZU53N0Jj?=
 =?utf-8?B?RGhzcTkzdm0wanE4bjh2b1o4bDh0bGFJbEZoQmh1VTR4UkltU3BFQlNOcEVr?=
 =?utf-8?B?SjYzYzFPVUZGNDlPelEzN1dHK2R3Y3FnYzMxRzN2OXdabTZaNm9NeTdIeTVv?=
 =?utf-8?B?aGdKMHRpMldSdjFIb2g0cE1mZmFlRTB6MW1QcGdLR2RRWUF2bGN1SmhqL2FZ?=
 =?utf-8?B?SENrdlgxYnNRSlVucVhjcEZiN0FON0N3VVVGNTFxVE5YbEMxdUZvTTZ5NW45?=
 =?utf-8?B?NHpHeEJ5bFR2K2poNkp6S004dGM0WXdkM2hBQW00T080UUh4VExYYVFLYnBx?=
 =?utf-8?B?c2RDK2tYWjlleS9IWVdCZG8wNTk3a1BMK0hFTko4MXJiQjcxM3d0Mk9sQkVJ?=
 =?utf-8?B?Tmk5dDlrcU1xUWZicytvZlAwUmN5eWZKa3lHZXE3MzRUbTZmOHFKd1FFdHN0?=
 =?utf-8?Q?qExrWnO3I1kJb/XhbFker9NKZ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee3dfc43-b7a6-4071-1390-08dab112304d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 14:08:10.5481
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o21bgkKKlbU0L/QnqUmlETvjQgt8qW1L5qbhzRIMJkJqTDcPa8RrH9D7cH1JQWf1p0LD8iZfX5gaKvjI36TmPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8389

On 11.10.2022 13:17, Wei Chen wrote:
> --- a/xen/arch/x86/numa.c
> +++ b/xen/arch/x86/numa.c
> @@ -46,6 +46,11 @@ bool arch_numa_disabled(void)
>      return acpi_numa < 0;
>  }
>  
> +bool arch_numa_unavailable(void)

__init ?

> @@ -31,11 +46,334 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
>  
>  bool __ro_after_init numa_off;
>  
> +const char *__ro_after_init numa_fw_nid_name = "NONAME";

Didn't you mean to leave this at NULL for the DT case? (But yes, this
way you avoid a conditional at every printk() using it.)

I'm also uncertain of "NOMAME" - personally I think e.g. "???" would
be better, just in case a message actually is logged with this still
un-overridden.

> +bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid,
> +                                     paddr_t start, paddr_t size, bool hotplug)
> +{
> +    unsigned int i;
> +    bool next = false;
> +    paddr_t end = start + size;
> +    paddr_t nd_start = start;
> +    paddr_t nd_end = end;
> +    struct node *nd = &nodes[node];
> +
> +    /*
> +     * For the node that already has some memory blocks, we will
> +     * expand the node memory range temporarily to check memory
> +     * interleaves with other nodes. We will not use this node
> +     * temp memory range to check overlaps, because it will mask
> +     * the overlaps in same node.
> +     *
> +     * Node with 0 bytes memory doesn't need this expansion.
> +     */
> +    if ( nd->start != nd->end )
> +    {
> +        if ( nd_start > nd->start )
> +            nd_start = nd->start;
> +
> +        if ( nd_end < nd->end )
> +            nd_end = nd->end;
> +    }
> +
> +    /* It is fine to add this area to the nodes data it will be used later */
> +    switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) )
> +    {
> +    case OVERLAP:
> +        if ( memblk_nodeid[i] == node )
> +        {
> +            bool mismatch = !hotplug != !test_bit(i, memblk_hotplug);
> +
> +            printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n",
> +                   mismatch ? KERN_ERR : KERN_WARNING, numa_fw_nid_name,
> +                   arch_nid, start, end - 1,
> +                   node_memblk_range[i].start, node_memblk_range[i].end - 1);
> +            if ( mismatch )
> +                return false;
> +            break;
> +        }
> +
> +        printk(KERN_ERR
> +               "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n",
> +               numa_fw_nid_name, arch_nid, start, end - 1, numa_fw_nid_name,
> +               numa_node_to_arch_nid(memblk_nodeid[i]),
> +               node_memblk_range[i].start, node_memblk_range[i].end - 1);
> +        return false;
> +
> +    case INTERLEAVE:
> +        printk(KERN_ERR
> +               "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n",
> +               numa_fw_nid_name, arch_nid, nd_start, nd_end - 1,
> +               numa_fw_nid_name, numa_node_to_arch_nid(memblk_nodeid[i]),
> +               node_memblk_range[i].start, node_memblk_range[i].end - 1);
> +        return false;
> +
> +    case NO_CONFLICT:
> +        break;
> +    }
> +
> +    if ( !hotplug )
> +    {
> +        node_set(node, memory_nodes_parsed);
> +        nd->start = nd_start;
> +        nd->end = nd_end;
> +    }
> +
> +    printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
> +           node, numa_fw_nid_name, arch_nid, start, end - 1,
> +           hotplug ? " (hotplug)" : "");
> +
> +    /* Keep node_memblk_range[] sorted by address. */
> +    for ( i = 0; i < num_node_memblks; ++i )
> +        if ( node_memblk_range[i].start > start ||
> +             (node_memblk_range[i].start == start &&
> +             node_memblk_range[i].end > end) )
> +            break;
> +
> +    memmove(&node_memblk_range[i + 1], &node_memblk_range[i],
> +            (num_node_memblks - i) * sizeof(*node_memblk_range));
> +    node_memblk_range[i].start = start;
> +    node_memblk_range[i].end = end;
> +
> +    memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i],
> +            (num_node_memblks - i) * sizeof(*memblk_nodeid));
> +    memblk_nodeid[i] = node;
> +
> +    if ( hotplug ) {

Nit: Placement of brace.

> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -159,6 +159,8 @@
>  #define PGT_TYPE_INFO_INITIALIZER 0
>  #endif
>  
> +paddr_t __read_mostly mem_hotplug;

Not __ro_after_init?

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:18:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:18:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425030.672773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknQX-0004VH-97; Tue, 18 Oct 2022 14:18:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425030.672773; Tue, 18 Oct 2022 14:18:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknQX-0004VA-6W; Tue, 18 Oct 2022 14:18:41 +0000
Received: by outflank-mailman (input) for mailman id 425030;
 Tue, 18 Oct 2022 14:18:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XTa7=2T=aepfle.de=olaf@srs-se1.protection.inumbo.net>)
 id 1oknQV-0004V4-AI
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:18:39 +0000
Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de
 [85.215.255.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c203f717-4eef-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:18:38 +0200 (CEST)
Received: from sender by smtp.strato.de (RZmta 48.2.0 AUTH)
 with ESMTPSA id z9e8dfy9IEIZqTs
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
 (Client did not present a certificate);
 Tue, 18 Oct 2022 16:18:35 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c203f717-4eef-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1666102716;
    s=strato-dkim-0002; d=aepfle.de;
    h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date:
    From:Subject:Sender;
    bh=vhiNBxZSYP3vilOtpXXi2VpwfooaHch2tx9V29uJbYc=;
    b=SCH6OGh1SevE4+QjYkiWEMFjXucx7SGL+u40cm+JiP/myWGtx7D9yfEQJw5ms4Q2BX
    ogNWGrZMPqzZT+ezU8px85Jfu8R5UCo9XBpfRCNDYTAwGYkftOv/s6Fy14aDVaadt2Fe
    UnfokEn1KxndP9YGB5ZgJoQE76RgaYFcM3D8nSecFllKycbiVJHkPRjvSg7r7MM9sL0R
    AG16wLKZNNkpSXXl5WhFoqy6MtlKip82gYFCgF+kfkKPSyVfMrONNCKP/sMEfMNFdd/p
    TbmHbgj1eWvIcq5Ssb5Xz5d+LJTuTnAfs+dEroBYalQI7Al9ufHt9ggVqheoelAikcNf
    UsiQ==
Authentication-Results: strato.com;
    dkim=none
X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX2j/OiDv7LX1ITFkr8sRtLhQJY8wcRJ+GvY"
X-RZG-CLASS-ID: mo00
Date: Tue, 18 Oct 2022 16:18:21 +0200
From: Olaf Hering <olaf@aepfle.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>, Oskari
 Pirhonen <xxc3ncoredxx@gmail.com>, mathieu.desnoyers@efficios.com,
 rharwood@redhat.com, samuel.thibault@ens-lyon.org,
 debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <20221018161821.149ee6fd.olaf@aepfle.de>
In-Reply-To: <Y06w0Oda0sHTHPNW@generichostname>
References: <20221017103532.845293-1-liu.denton@gmail.com>
	<20221018131235.5e70f0bc.olaf@aepfle.de>
	<Y06w0Oda0sHTHPNW@generichostname>
X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen.
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/=pk9Y9LpQ6oa5YoIJDRURMY";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/=pk9Y9LpQ6oa5YoIJDRURMY
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Tue, 18 Oct 2022 06:57:36 -0700 Denton Liu <liu.denton@gmail.com>:

> If I'm understanding correctly, what you're proposing is a mechanism for
> setting the default entry. If I'm not mistaken, this seems like an
> orthogonal discussion to me. My patch proposes a method of setting the
> top-level menu entry while this method only sets the default entry,
> which may be hidden behind a submenu.

I think this can be done already today. At least YaST offers a way to selec=
t a specific item in a submenu and pass it to grub-set-default. This leads =
to an entry like this in grubenv:

saved_entry=3DAdvanced options for SLE15SP4 (with Xen hypervisor)>Xen hyper=
visor, version 4.17.20220823T122205.399bcbf2-xen_unstable.150400.370>SLE15S=
P4, with Xen 4.17.20220823T122205.399bcbf2-xen_unstable.150400.370 and Linu=
x 5.14.21-150400.24.21-default

This entry will be booted as long as both this specific Xen version and thi=
s specific kernel version is found. There is a slim chance a SUSE specific =
patch exists to enable this functionality.

Maybe the patch description lacks a specific example how the proposed chang=
e is supposed to be used in your environment.

Olaf

--Sig_/=pk9Y9LpQ6oa5YoIJDRURMY
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmNOta0ACgkQ86SN7mm1
DoALCg//dbAthIrUpj/CgWD2MVsYXsTcxEnduej/jcSyWMLfj8qeRCuNuMx03neD
3OMOhs/3nz6cnbp9fKv8421fP8qaUrgwn+meU6Er/r0bn08pGvlBBrNnetwrV/Sv
FfFdXuemnaGTyDLmw3VNvTWGcHMZwGpASjdIPJd7OImLs4XBqO2zLlptCiP/nRCv
bBAR3V8J3EbKjNtqqiZVrf1fFdAVNcbyB/0jQIewJ5Fv/lo+grg8Hx6YtchPvJlJ
lcE42oQ7G637/HH8y9nZig1Tzm0jat7/WbmbM8wkSTBL0DM+rWeHI9H/85U9l9Sc
fC7hq5LafaaTBmHyT6W3kK0anGArLrXB1ii4Cg7ZDz1ClpoXB042BeXujtpOzJMC
pAi3uE/7qkVsZkL+TJa45Be47TbLT7MIIzyFpJNTOGmVwCeNkyqLiHAdYwTzojgG
im++PkFocBq4w2+SLmSNlzLtbMIv3KufrjM0hTrJga6M30QrRF+Uhu7D+iE/7vpR
oFYjtczM7WfETQ6E9In/pqhPp/8l+X/BwpEV4RrEVofxXSsPH4ajMZ7x+LKiOMNC
DDlsD2xkRwQMTdqgyboSBWP9GBmDw+jH7WUUEzOBNXsIYMnckLaKi0T1Rb2mSppN
+RsP/PReLrCnsB6DwtDespr5lO4Wf1U7laVpqMmC54fwmpxeEVA=
=feKy
-----END PGP SIGNATURE-----

--Sig_/=pk9Y9LpQ6oa5YoIJDRURMY--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:21:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:21:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425036.672785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknTZ-0005rz-NP; Tue, 18 Oct 2022 14:21:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425036.672785; Tue, 18 Oct 2022 14:21:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknTZ-0005rs-Kd; Tue, 18 Oct 2022 14:21:49 +0000
Received: by outflank-mailman (input) for mailman id 425036;
 Tue, 18 Oct 2022 14:21:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oknTZ-0005rm-8O
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:21:49 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3365244b-4ef0-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:21:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8766.eurprd04.prod.outlook.com (2603:10a6:102:20d::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct
 2022 14:21:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 14:21:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3365244b-4ef0-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cZLCghwoaweAK6AiSWMlV1PYyKvXEvTfF/A9GBOG7NgM74RmQHspej6JaSusrPoGU99LX11K/e8JYCr6A0GRBMJu6sRAj36d1ZEx46NozLM2DD9AM1YhI7RHiN6T1lTMVea7O7dyejAShEsWeUOI2cot84kRg7VsH5XQq8tkt/mhQG9uKyIZ4Z2MME4kxBuIVkDji3it9q2nV2tAHz6UnfBEb+9LJZlEIWB4PeagICTwempdxZb1BEx/KcXxOrw8HoKbE8VJbDikFdd3KL/h9Xl+EMSHyZagQpqAAzBctvsHgNlKQgW0USA7mE9iZPTgYRE8OB1BoQtM6ZUUz2GtLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2K642ghudLTIsyxgMMLATLhX4zB9IF3MWcLYfmF8A8E=;
 b=Vo5Pyj5rNTm6RE99y92aUc1HNCk7nSbjsBURg0bYp5jWV0EkCv+cuppAghr6VVXBRpw7Vi16pjOyVsfp2iC2Z5RMRPP5Fm1MQvWpDf7Enz/XPq9LwkhJHX5pTwOyx3GbyFtc5/KJcyUew2hqRk+WdNDBUTkFCj74hw38EkoHh+AGOAKxzlfx8HoDwUJgft1gZdD+yecwk+n3bplhehsqr8xphtQ4SPT1559wd2aUILGy6qpV4IzaG0+qtlc6J3kG9E5ne9JYA0vxfYfIytmYyWTkrQLbHyYTDCTdwVvhA2e1DgTjL0lVzgbV0tUfYHpQI0CIxn22n3s/X3Zjar+lCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2K642ghudLTIsyxgMMLATLhX4zB9IF3MWcLYfmF8A8E=;
 b=UOEt5knMgkO2jWfNwUuXG81gW4S5BNB/EoGJDndKIzSf+v+1el3wCcLydBggBwrs6v1hk4kU066uGZFwInhtEY3bG8tMQ9nH8dDS3FqE2jysqpGwicvp0UeJxQboJnRyKRoYbl0GOYMUlWJz+aCKo0YRAUoNF9EY9+OaPhD4LfwsnaaA/PYJKPoDVPLe1DUPbVlf+TJLMBgwyo7PybuVb2HR0TY3XUpJ/m6cHfqgDXct8bbTO0dTDa5XxFOW11KEab84XcmLOHwD0TEDbQhonhpbvv1jQBL559Zs+3/MDrqCRJX3MYd5Zkk7uM4WAl3fGDahWYlwOLgroTAnpzZg9g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d67ceabb-b31a-59e6-fc77-8d6c48b277f2@suse.com>
Date: Tue, 18 Oct 2022 16:21:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Anshuman Khandual <anshuman.khandual@arm.com>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
 iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
 Jani Nikula <jani.nikula@linux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@intel.com>,
 Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
 Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20221018082413.GA25785@lst.de>
 <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com>
 <20221018110243.GA4655@lst.de>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221018110243.GA4655@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0267.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::33) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8766:EE_
X-MS-Office365-Filtering-Correlation-Id: 7d1f1b3e-e816-454f-bd6e-08dab1141640
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	unmDrL5qpfGQ7k1nYSMAelNn3VH1U1IrlamfrNq066vYzyEJTYLVHgmFfmj5vNozi2T+7PgQ6TMP9czFIm5xe6VjZIdKWyE4xLHiTOcexOcx9KUwihpOwPxJAzbxMagytdqJ/A9l1zDeJfsKw0W70mUGb2VYzESxrr638pRIu9dfATl+XOy698gfa1OyCjS9d65PKdKGhkCbbA68UohnTIssvh9fLdU07ug1MoILJ1/ksZyeY7dogEWJYeBZWYsThFutGrDc4E8cnksJTOZTAJCZ8ORJM1FCrHFpN1n2YB3FaGlao/aTTb7Mv0Gq4DRnsbUfjYDQwjcS38yF7YWPS98d/7B+P/wJPGk7zid4bAE2YyfyU6odexY9DWmUVCPJrfpyIheQuGZn8bZKQL7twwe76UCHiwwqu3vV2gkDWY3ka7YLjOak+fjZFVlb/02B/48q5aacPt6MP8cgXgXHcK2BJA+oj1TQx1M1+lx3kDdHGfLt//dzLg9gQH1/Paz7CjGPd8vvIBGZGDABvU5l57lLPibJ5Izp9G4iWrwEt0Ck3T2GhLX+ohDBN2h4/C1rYLss4x1F05bimvAqapGvjzNRORvtHVfX2SHUF/dDSjOFRRDNVPAxCWQv3Vagcz0YsadAUMB9IwSxHG2NQXX3mDvhlbng92HJS3/12DN4hoClpwS/PpgZ4EVbQ8Cr8LtetqveH2o/JSLkr/10c4LEOct1eyc57xhrSM7wqooKnNPFvGKWAbhnluks84rIil3BBifDYDV/iLWSVTMjGkzuLVITFqEaF/YiMQTgpjJxb54=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199015)(38100700002)(31686004)(478600001)(6486002)(186003)(2616005)(36756003)(6506007)(4326008)(54906003)(6916009)(316002)(66946007)(66556008)(5660300002)(8676002)(66476007)(6512007)(53546011)(2906002)(26005)(8936002)(86362001)(31696002)(41300700001)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c05BYmM0emt2a3ZsM09rZllhdWFQT3JEVURNaFhjU3g1Zmt6azQ2bzkzNTJi?=
 =?utf-8?B?dE9iN1RaWU9Kdm02QWtLZEdYdUdIckpIUkxjaWFKdmE0d0xJNk44Mkd5anBM?=
 =?utf-8?B?UE10Z2NNZjE4a2k4VlcwdG11bU9qcHZtSzYvRElvVnlQWVhPcWY2aDlYMHFn?=
 =?utf-8?B?WmxqajBsSlNLSWlNL1V0MTlFZjgrWGhpSkpLL0pXUkUweitlU21mTmhNV0Rh?=
 =?utf-8?B?SW41RzdxRThWY0ovWDd5U1Z0TVNoakgzeWlTdEpIdUJudXI4bVJScUlkUy85?=
 =?utf-8?B?UENNL1hjM3VQTFBMeGhsNXhpU2tYbWZaUU5LOEMxaGl5OVNxQnJ5SW1NRmpM?=
 =?utf-8?B?WEdBaDdRd3MzSkZUNFdHV3hEUmo4K3NhYWNURGNKblBSTnR6cXk1WDM4THBj?=
 =?utf-8?B?N0NJL3lValF2aXpIc1Q5MWhoc0h5TE9MT2xocmtIVk9WeTA4YUUwOThVYVZQ?=
 =?utf-8?B?aFZCYTZOL1JFVmhhVzF3UDV5QWd0QnJTOHZYRjkyUEZwbnlBQXgzUG83aXdF?=
 =?utf-8?B?dWJucGFybVBRUXhFNmxEeWxXWEgvY2xxV3NldGgrUUk5Z1VWeDNuV3ZWSUpI?=
 =?utf-8?B?cHhIL3FOYThZbm5BaGh4ampGcHY2MytGU2JwNjdIUUFkVjNoRUZIL1A5QUdm?=
 =?utf-8?B?NjA3bzI3d2ZoelFCRDVmSzMwT2JQRm1xWUlGcm9Ka3M4dDM0RWljZitwZHRq?=
 =?utf-8?B?N3N2UDJrcTI0WXc1NHEvNlQzTnBXNHh2UUxDL1ZXaFVDcHNhQzBVRVowU0I5?=
 =?utf-8?B?SXpabU41S0x5MGVHeEJJb2dsYnExYzVMKzVXSUNTL1BFMU16QUkwMFFaZUtR?=
 =?utf-8?B?enh4SlZEUUVGV25OREM5ZlA0R1R4TkJLSFhLdjRiVllMNyt1UDRoTDBXUzQx?=
 =?utf-8?B?empCWnJ4TEFsdHMyNVRQT2tzM3JUUldHRHRxN1RkWUFCNndrMVpOY3hLTHdJ?=
 =?utf-8?B?Z1RPMFdGOG02WmxlMUlNSXpYS0tFL3VqeklWcGJaaXhVbUhwcEtYK1ZQMWda?=
 =?utf-8?B?ekc1VWpMZGhRV09uNzVsKzRqRG0vMjBnUjdLdXFoSFNMNDhPM0k3Z2hsTHJs?=
 =?utf-8?B?dWs1SXozNGpGOXBoZXJYWjBCT2dPZVFnaEV0ektMNzJWVXIvTlg1cXdTeWVV?=
 =?utf-8?B?Qzl1a2J5a2lITVdVTDFLUmhDYmtFS2FCclQ3akZMWFZlelZObWpSSytzZ0wr?=
 =?utf-8?B?VHhMWTh5VEdBblVVb2t4bUFuUFZJNnVuRngxV2VYd0pCQ1V4YlFKTVoxcXcz?=
 =?utf-8?B?bXBUNDlOT2E1YTFPYURxZkdZK3pUalJFTXBvZVRBdzdFUXFWZnZRM1Axbjhz?=
 =?utf-8?B?Vk81VW9zU2FDWWZrMHp5OHdIL1VIT3ptSjFLaEZYMlVQUFp2U3g5UCswVmNC?=
 =?utf-8?B?KzV5eWZZYmwxYnVjdlZxbXVoY1hDS3kyZGgvanhoTUUyeldTREV4QkRGa2Z4?=
 =?utf-8?B?UG9zOXhhRVFEOVZnQ3o3Y0hCdDZsQytJbXVna1AvbmJZNWI3WmZ4Qk5kTWNz?=
 =?utf-8?B?OFFRSFpxN3ZLd0l2RzVrRU5JNk1Nbnd5Q0owZzl6U1A5Tzg0a2VSRTliaGhX?=
 =?utf-8?B?LzVuaWVZZVY2VXBDYjhyMXhDM2ppV0UwUGVPbjBRYlQ3Sm5wMnhSek1ITTN4?=
 =?utf-8?B?S3dmR2htMWdoWWpJMnlPdSs4T0pTU1lKK1JFZGxDTWFCZlFKclYyWFN2dWtO?=
 =?utf-8?B?ZVFpRS9vVEEyMm56ZVZhWnBTNkd5T3VzT2JmOXNlWjRNNkJ6dEhiNHdXVUVU?=
 =?utf-8?B?WndHRlUvM3VrMUpueldIOTc5djZLQUhkZVZNaC9IU05yM1ByWWNkTSs1Vzd3?=
 =?utf-8?B?NnZkcmdhSFRuZ0QvQnNwUElUdlVqL3E5TnZxSld2bkpHTHczYjFBRTZyVkNP?=
 =?utf-8?B?ME9IUjA5YjAxc201NXlsL28wMGZrNjVHV0VLU0pEazFyeDc4MGNnWUIxUEZ6?=
 =?utf-8?B?UGdnbUYvcU5HbGNKMVM5dGlKV1NvZjA0R1ZtSXdOeHNKaUZSYWJoTnFqZEc0?=
 =?utf-8?B?VDRsdGxUODIvRXVCQ2x2N096VHZseVJpVnBJRHowTE9zVHNobGtQT3luenAw?=
 =?utf-8?B?M0grTGtCVjhFU1JHUUdNaWxFVGhOME5Mb1ptVHNqb2ExUGVYdFFsZXNvekRY?=
 =?utf-8?Q?38sq0lqwKw0nx1z1/+AxME4KX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d1f1b3e-e816-454f-bd6e-08dab1141640
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 14:21:45.8712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dQDXCbjgngb8SmPtVWGMTkn3COXtlu5GoVnxU4JsFR6YaRz/rbOaaN2KcRuHncuFSzrH9CzDbk9X6/FG020e1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8766

On 18.10.2022 13:02, Christoph Hellwig wrote:
> On Tue, Oct 18, 2022 at 10:57:37AM +0200, Jan Beulich wrote:
>> Shouldn't this then be xen_pv_domain() that you use here, and - if you
>> really want IS_ENABLED() in addition - CONFIG_XEN_PV?
> 
> I'll need help from people that understand Xen better than me what
> the exact conditions (and maybe also comments are).

Leaving the "i915 abuses" part aside (because I can't tell what exactly the
abuse is), but assuming that "can't cope with bounce buffering" means they
don't actually use the allocated buffers, I'd suggest this:

	/*
	 * For Xen PV guests pages aren't contiguous in DMA (machine) address
	 * space.  The DMA API takes care of that both in dma_alloc_* (by
	 * calling into the hypervisor to make the pages contiguous) and in
	 * dma_map_* (by bounce buffering).  But i915 abuses ignores the
	 * coherency aspects of the DMA API and thus can't cope with bounce
	 * buffering actually happening, so add a hack here to force small
	 * allocations and mappings when running in PV mode on Xen.
	 */
	if (IS_ENABLED(CONFIG_XEN_PV) && xen_pv_domain())
		max = PAGE_SIZE;

I've dropped the TDX related remark because I don't think it's meaningful
for PV guests. Otoh I've left the "abuses ignores" word sequence as is, no
matter that it reads odd to me. Plus, as hinted at before, I'm not
convinced the IS_ENABLED() use is actually necessary or warranted here.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:24:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:24:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425043.672796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknVg-0006Sl-3q; Tue, 18 Oct 2022 14:24:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425043.672796; Tue, 18 Oct 2022 14:24:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknVg-0006Se-16; Tue, 18 Oct 2022 14:24:00 +0000
Received: by outflank-mailman (input) for mailman id 425043;
 Tue, 18 Oct 2022 14:23:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=L+Ts=2T=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oknVf-0006SY-10
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:23:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 804caa8f-4ef0-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 16:23:57 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C29E2113E;
 Tue, 18 Oct 2022 07:24:02 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 789603F792;
 Tue, 18 Oct 2022 07:23:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 804caa8f-4ef0-11ed-91b4-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 0/2] arm/p2m: XSA-409 fix
Date: Tue, 18 Oct 2022 14:23:44 +0000
Message-Id: <20221018142346.52272-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

This series contains:

1. The first patch from Andrew that reworks p2m_init() so that
fallible operations in p2m_init() will not lead to leakage of VMID
or the root table.
2. The patch in [1] rebased on top of the p2m_init() rework that
populate default 16 pages to the p2m pool for the mapping of GICv2
at the domain creation stage.

[1] https://lore.kernel.org/xen-devel/20221017165133.17066-1-Henry.Wang@arm.com/

Andrew Cooper (1):
  arm/p2m: Rework p2m_init()

Henry Wang (1):
  xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

 xen/arch/arm/domain.c          |  2 +-
 xen/arch/arm/include/asm/p2m.h | 14 +++++---
 xen/arch/arm/p2m.c             | 58 ++++++++++++++++++++++++++--------
 3 files changed, 55 insertions(+), 19 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:24:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:24:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425044.672806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknVm-0006kL-BX; Tue, 18 Oct 2022 14:24:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425044.672806; Tue, 18 Oct 2022 14:24:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknVm-0006kE-8e; Tue, 18 Oct 2022 14:24:06 +0000
Received: by outflank-mailman (input) for mailman id 425044;
 Tue, 18 Oct 2022 14:24:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=L+Ts=2T=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oknVl-0006SO-4J
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:24:05 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 844bcd63-4ef0-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:24:03 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D14D1113E;
 Tue, 18 Oct 2022 07:24:09 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 90AF63F792;
 Tue, 18 Oct 2022 07:24:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 844bcd63-4ef0-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 1/2] arm/p2m: Rework p2m_init()
Date: Tue, 18 Oct 2022 14:23:45 +0000
Message-Id: <20221018142346.52272-2-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221018142346.52272-1-Henry.Wang@arm.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>

From: Andrew Cooper <andrew.cooper3@citrix.com>

p2m_init() is mostly trivial initialisation, but has two fallible operations
which are on either side of the backpointer trigger for teardown to take
actions.

p2m_free_vmid() is idempotent with a failed p2m_alloc_vmid(), so rearrange
p2m_init() to perform all trivial setup, then set the backpointer, then
perform all fallible setup.

This will simplify a future bugfix which needs to add a third fallible
operation.

No practical change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
v5 changes:
- Correct typo in commit message, add reviewed-by from Arm maintainers.
---
 xen/arch/arm/p2m.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3..6826f63150 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1754,7 +1754,7 @@ void p2m_final_teardown(struct domain *d)
 int p2m_init(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
-    int rc = 0;
+    int rc;
     unsigned int cpu;
 
     rwlock_init(&p2m->lock);
@@ -1763,11 +1763,6 @@ int p2m_init(struct domain *d)
     INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist);
 
     p2m->vmid = INVALID_VMID;
-
-    rc = p2m_alloc_vmid(d);
-    if ( rc != 0 )
-        return rc;
-
     p2m->max_mapped_gfn = _gfn(0);
     p2m->lowest_mapped_gfn = _gfn(ULONG_MAX);
 
@@ -1783,8 +1778,6 @@ int p2m_init(struct domain *d)
     p2m->clean_pte = is_iommu_enabled(d) &&
         !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK);
 
-    rc = p2m_alloc_table(d);
-
     /*
      * Make sure that the type chosen to is able to store the an vCPU ID
      * between 0 and the maximum of virtual CPUS supported as long as
@@ -1797,13 +1790,20 @@ int p2m_init(struct domain *d)
        p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID;
 
     /*
-     * Besides getting a domain when we only have the p2m in hand,
-     * the back pointer to domain is also used in p2m_teardown()
-     * as an end-of-initialization indicator.
+     * "Trivial" initialisation is now complete.  Set the backpointer so
+     * p2m_teardown() and friends know to do something.
      */
     p2m->domain = d;
 
-    return rc;
+    rc = p2m_alloc_vmid(d);
+    if ( rc )
+        return rc;
+
+    rc = p2m_alloc_table(d);
+    if ( rc )
+        return rc;
+
+    return 0;
 }
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:24:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:24:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425045.672818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknVr-00074E-KZ; Tue, 18 Oct 2022 14:24:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425045.672818; Tue, 18 Oct 2022 14:24:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknVr-000743-HU; Tue, 18 Oct 2022 14:24:11 +0000
Received: by outflank-mailman (input) for mailman id 425045;
 Tue, 18 Oct 2022 14:24:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=L+Ts=2T=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oknVq-0006SO-BO
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:24:10 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 8726547d-4ef0-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:24:08 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A05BA113E;
 Tue, 18 Oct 2022 07:24:14 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5FC2E3F792;
 Tue, 18 Oct 2022 07:24:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8726547d-4ef0-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()
Date: Tue, 18 Oct 2022 14:23:46 +0000
Message-Id: <20221018142346.52272-3-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221018142346.52272-1-Henry.Wang@arm.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
which requires 6 P2M pages as the two pages will be consecutive but not
necessarily in the same L3 page table and keep a buffer, populate 16
pages as the default value to the P2M pages pool in p2m_init() at the
domain creation stage to satisfy the GICv2 requirement. For GICv3, the
above-mentioned P2M mapping is not necessary, but since the allocated
16 pages here would not be lost, hence populate these pages
unconditionally.

With the default 16 P2M pages populated, there would be a case that
failures would happen in the domain creation with P2M pages already in
use. To properly free the P2M for this case, firstly support the
optionally preemption of p2m_teardown(), then call p2m_teardown() and
p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
As non-preemptive p2m_teardown() should only return 0, use a
BUG_ON to confirm that.

Since p2m_final_teardown() is called either after
domain_relinquish_resources() where relinquish_p2m_mapping() has been
called, or from failure path of domain_create()/arch_domain_create()
where mappings that require p2m_put_l3_page() should never be created,
relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
in-code comments to refer this.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
This should also be backported to 4.13, 4.14, 4.15 and 4.16.
v5 changes:
- Rebase on top of Andrew's patch, update commit message accordingly.
v4 changes:
- Move the initial population of 16 default pages to the end of
  p2m_init(), add if(rc) return rc; after p2m_alloc_table()
v3 changes:
- Move the population of default pages to p2m_init().
- Use a loop over p2m_teardown_allocation() to implement the
  non-preemptive p2m_teardown_allocation() and avoid open-coding.
- Reorder assertions in p2m_final_teardown().
- Add p2m_teardown() will always return 0 if called non-preemptively in
  doc, move the page_list_empty(&p2m->pages) check to p2m_teardown()
  and use a BUG_ON to confirm p2m_teardown() will return 0 in
  p2m_final_teardown().
- Add a comment in p2m_final_teardown() to mention relinquish_p2m_mapping()
  does not need to be called, also update commit message.
v2 changes:
- Move the p2m_set_allocation(d, 0, NULL); to p2m_final_teardown().
- Support optionally preemption of p2m_teardown(), and make the calling of
  p2m_teardown() preemptively when relinquish the resources, non-preemptively
  in p2m_final_teardown().
- Refactor the error handling to make the code use less spin_unlock.
- Explain the worst case of page tables and the unconditional population
  of pages in commit message.
- Mention the unconditional population of pages in in-code comment.
---
 xen/arch/arm/domain.c          |  2 +-
 xen/arch/arm/include/asm/p2m.h | 14 ++++++++++----
 xen/arch/arm/p2m.c             | 34 ++++++++++++++++++++++++++++++++--
 3 files changed, 43 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2c84e6dbbb..38e22f12af 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1064,7 +1064,7 @@ int domain_relinquish_resources(struct domain *d)
             return ret;
 
     PROGRESS(p2m):
-        ret = p2m_teardown(d);
+        ret = p2m_teardown(d, true);
         if ( ret )
             return ret;
 
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index 42bfd548c4..c8f14d13c2 100644
--- a/xen/arch/arm/include/asm/p2m.h
+++ b/xen/arch/arm/include/asm/p2m.h
@@ -194,14 +194,18 @@ int p2m_init(struct domain *d);
 
 /*
  * The P2M resources are freed in two parts:
- *  - p2m_teardown() will be called when relinquish the resources. It
- *    will free large resources (e.g. intermediate page-tables) that
- *    requires preemption.
+ *  - p2m_teardown() will be called preemptively when relinquish the
+ *    resources, in which case it will free large resources (e.g. intermediate
+ *    page-tables) that requires preemption.
  *  - p2m_final_teardown() will be called when domain struct is been
  *    freed. This *cannot* be preempted and therefore one small
  *    resources should be freed here.
+ *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
+ *  free the P2M when failures happen in the domain creation with P2M pages
+ *  already in use. In this case p2m_teardown() is called non-preemptively and
+ *  p2m_teardown() will always return 0.
  */
-int p2m_teardown(struct domain *d);
+int p2m_teardown(struct domain *d, bool allow_preemption);
 void p2m_final_teardown(struct domain *d);
 
 /*
@@ -266,6 +270,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
 /*
  * Direct set a p2m entry: only for use by the P2M code.
  * The P2M write lock should be taken.
+ * TODO: Add a check in __p2m_set_entry() to avoid creating a mapping in
+ * arch_domain_create() that requires p2m_put_l3_page() to be called.
  */
 int p2m_set_entry(struct p2m_domain *p2m,
                   gfn_t sgfn,
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 6826f63150..00d05bb708 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1685,7 +1685,7 @@ static void p2m_free_vmid(struct domain *d)
     spin_unlock(&vmid_alloc_lock);
 }
 
-int p2m_teardown(struct domain *d)
+int p2m_teardown(struct domain *d, bool allow_preemption)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long count = 0;
@@ -1693,6 +1693,9 @@ int p2m_teardown(struct domain *d)
     unsigned int i;
     int rc = 0;
 
+    if ( page_list_empty(&p2m->pages) )
+        return 0;
+
     p2m_write_lock(p2m);
 
     /*
@@ -1716,7 +1719,7 @@ int p2m_teardown(struct domain *d)
         p2m_free_page(p2m->domain, pg);
         count++;
         /* Arbitrarily preempt every 512 iterations */
-        if ( !(count % 512) && hypercall_preempt_check() )
+        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
         {
             rc = -ERESTART;
             break;
@@ -1736,7 +1739,20 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
+    /*
+     * No need to call relinquish_p2m_mapping() here because
+     * p2m_final_teardown() is called either after domain_relinquish_resources()
+     * where relinquish_p2m_mapping() has been called, or from failure path of
+     * domain_create()/arch_domain_create() where mappings that require
+     * p2m_put_l3_page() should never be created. For the latter case, also see
+     * comment on top of the p2m_set_entry() for more info.
+     */
+
+    BUG_ON(p2m_teardown(d, false));
     ASSERT(page_list_empty(&p2m->pages));
+
+    while ( p2m_teardown_allocation(d) == -ERESTART )
+        continue; /* No preemption support here */
     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
 
     if ( p2m->root )
@@ -1803,6 +1819,20 @@ int p2m_init(struct domain *d)
     if ( rc )
         return rc;
 
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
+     * the allocated 16 pages here would not be lost, hence populate these
+     * pages unconditionally.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+    if ( rc )
+        return rc;
+
     return 0;
 }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:33:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:33:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425065.672830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okneq-0000oB-QN; Tue, 18 Oct 2022 14:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425065.672830; Tue, 18 Oct 2022 14:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okneq-0000o4-LA; Tue, 18 Oct 2022 14:33:28 +0000
Received: by outflank-mailman (input) for mailman id 425065;
 Tue, 18 Oct 2022 14:33:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ieme=2T=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1oknep-0000ny-BS
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:33:27 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d2e60b73-4ef1-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:33:25 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id A17A968C7B; Tue, 18 Oct 2022 16:33:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2e60b73-4ef1-11ed-8fd0-01056ac49cbb
Date: Tue, 18 Oct 2022 16:33:20 +0200
From: Christoph Hellwig <hch@lst.de>
To: Jan Beulich <jbeulich@suse.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Message-ID: <20221018143320.GA19106@lst.de>
References: <20221018082413.GA25785@lst.de> <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com> <20221018110243.GA4655@lst.de> <d67ceabb-b31a-59e6-fc77-8d6c48b277f2@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d67ceabb-b31a-59e6-fc77-8d6c48b277f2@suse.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Tue, Oct 18, 2022 at 04:21:43PM +0200, Jan Beulich wrote:
> Leaving the "i915 abuses" part aside (because I can't tell what exactly the
> abuse is), but assuming that "can't cope with bounce buffering" means they
> don't actually use the allocated buffers, I'd suggest this:

Except for one odd place i915 never uses dma_alloc_* but always allocates
memory itself and then maps it, but then treats it as if it was a
dma_alloc_coherent allocations, that is never does ownership changes.

> I've dropped the TDX related remark because I don't think it's meaningful
> for PV guests.

This remark is for TDX in general, not Xen related.  With TDX and other
confidentatial computing schemes, all DMA must be bounce buffered, and
all drivers skipping dma_sync* calls are broken.

> Otoh I've left the "abuses ignores" word sequence as is, no
> matter that it reads odd to me. Plus, as hinted at before, I'm not
> convinced the IS_ENABLED() use is actually necessary or warranted here.

If we don't need the IS_ENABLED is not needed I'm all for dropping it.
But unless I misread the code, on arm/arm64 even PV guests are 1:1
mapped so that all Linux physically contigous memory also is Xen
contigous, so we don't need the hack.


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:48:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:48:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425072.672840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknti-0002aD-1B; Tue, 18 Oct 2022 14:48:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425072.672840; Tue, 18 Oct 2022 14:48:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknth-0002a6-UX; Tue, 18 Oct 2022 14:48:49 +0000
Received: by outflank-mailman (input) for mailman id 425072;
 Tue, 18 Oct 2022 14:48:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=L+Ts=2T=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1okntg-0002a0-T0
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:48:49 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2047.outbound.protection.outlook.com [40.107.104.47])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f8181a1b-4ef3-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:48:47 +0200 (CEST)
Received: from AM6P192CA0026.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::39)
 by PAVPR08MB9505.eurprd08.prod.outlook.com (2603:10a6:102:315::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct
 2022 14:48:39 +0000
Received: from VI1EUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:83:cafe::4c) by AM6P192CA0026.outlook.office365.com
 (2603:10a6:209:83::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Tue, 18 Oct 2022 14:48:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT032.mail.protection.outlook.com (100.127.145.24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 18 Oct 2022 14:48:39 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Tue, 18 Oct 2022 14:48:38 +0000
Received: from f29a7f7a9e30.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 53FC1B54-5118-414C-B8B6-BFAB226C40B8.1; 
 Tue, 18 Oct 2022 14:48:29 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f29a7f7a9e30.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 14:48:29 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB6373.eurprd08.prod.outlook.com (2603:10a6:20b:33a::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct
 2022 14:48:26 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 14:48:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8181a1b-4ef3-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=XMSzDbz50vWvUnViWt3WBqouhATQ3nXn+S4UiWQuSNd+EnPGgWjVnX3MrLWXoLERkwLLPzxt9tSiStWYWM3TcwFS6LfbodPmwuOG7cYzFLANSV7xkoKRF4ACRTtu7jdOY4J1qgHMUc8TejWQtYjN95KweT+KOWg4DniNrnPo9ejL/YAa4IunaVsarwZx2q2W25uolcN9xsvkm8YsrBjrfuoVVGYTK/2dbd1+pzGT7OM1venesMNmp3UGHqE1xOh6PjLcLfty0MXHGiyVTqJsr8ulHrOBSpsHeMgEwkJ9PrEg9gZ1HIotmIvcb1fW8DPReYPWy+ZrJazRuL7qGGHV8Q==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yonvIVVAI+uAHvGelOtgqlT/jbY6Fp77ncSqyDsN0/M=;
 b=F05p4Ua5xKiQVhxPMEatOH/F4yjcUIm4Cn9nX7kTdzsrfVLuSY4nL790HVGvvCErSaWJlmqVww3FO8D/NQj93mrriZ2fMVH7g6lw6TjSuTsF0E+jGpWjO+AvyXG5r3+fnwVYi+3OdY6Cn8Nk18vOKPk36KoxdvQwcoRyFWefTNR2z4H7Yu0N1xZahmvoe+oA9IhG9t9GjlHWYkNRWEM+ZZVBpZGXLtJV1JoqRweaEntWa5Lcapg2GND5DiU4iSFjykXUbDACBuvaOMqfhPZ8x0S/6+U62LC3ftcy//WYV1Lj9edciFNEBPSktag7aa48M+dh8mQ1Ut0avpxLcuXWzg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yonvIVVAI+uAHvGelOtgqlT/jbY6Fp77ncSqyDsN0/M=;
 b=BxQshHXGhNQ44eu4aVKaJ40FHGi0AnBlE51YioWlZmjCOhF3HYW5C+OueNTGN3sx2r9PPhyphXdaSTu1Bbh2gXHgVKJYcuw8A1ccErGiItksNLkdXZJ9btlH0JVfiYc+PhCN3KkvB18c1Cyp2ZKQuXIoj655FnGFH6m0GfOkMtg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KTu6qNB6aLoM+CIwDbXY1iK/PZuWbhCObjOW9/5dD5hpRbueARtmq+k1kQszJs6Itz2jg7SqBFMOQVPwo8gux35liLGTcgKxZNLSPwzdDcSSof4XCaGzcPw5lBXFoWjqT6UPcsFtJGaRN6U/ZyMLKBgsoZfF0s27/xls/4/I5AUYuJPO7FYHt3Jrku/t55U22JhcR9I1HsumgVj2p6cEFfLe881Os0o6TqlSrb2T5QNQ3bu8xkIRHoUqiDs/RRi3TLucR7g+OyMzgCmdUHpA8fkmDUvwgHzpQA7LzxxpV6F2MEOXicms8mAuWlEm7biEhBfyBlMSk1GtqurxLBM7dQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yonvIVVAI+uAHvGelOtgqlT/jbY6Fp77ncSqyDsN0/M=;
 b=JRaKLMKwq/roIwKrv+WOuYcL9M4tmjPC3h9n2GAIJ/DzOvlooNcAmevT5aUpSr7Een3A7apxZbAu4rdwTY2C6jCqI93XTUvZOE+rm9CpWHEO9YN/a91F8r9UXWocWpnyaly8YPkiEleBzFCQMGPDTQhcH5viRSw9z82t6DM2TfnXwSYHI/bElakzcCchGYEidoK4wdBwNg/IZWXjKGdxMDwfwqlJPtYBQzBo4DZJ9tMaVnqi4f8DRCAwIGaKGRnzQK5SIzuTjagkRhphMD/blA4yl+qTJa076L+0upEu0aLzMlWGcDvh1M9jgrXrwX/2Q8tL9Hup1rwpALt1wb4wng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yonvIVVAI+uAHvGelOtgqlT/jbY6Fp77ncSqyDsN0/M=;
 b=BxQshHXGhNQ44eu4aVKaJ40FHGi0AnBlE51YioWlZmjCOhF3HYW5C+OueNTGN3sx2r9PPhyphXdaSTu1Bbh2gXHgVKJYcuw8A1ccErGiItksNLkdXZJ9btlH0JVfiYc+PhCN3KkvB18c1Cyp2ZKQuXIoj655FnGFH6m0GfOkMtg=
From: Henry Wang <Henry.Wang@arm.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v5 1/2] arm/p2m: Rework p2m_init()
Thread-Topic: [PATCH v5 1/2] arm/p2m: Rework p2m_init()
Thread-Index: AQHY4v1ZlXAD3ap4t02LRXIwxIJsRK4UOW7Q
Date: Tue, 18 Oct 2022 14:48:26 +0000
Message-ID:
 <AS8PR08MB799176C6282EC985F9D53DD592289@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>
 <20221018142346.52272-2-Henry.Wang@arm.com>
In-Reply-To: <20221018142346.52272-2-Henry.Wang@arm.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 4277DE1931EAA84BBF014CAD9B3E1AE2.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB6373:EE_|VI1EUR03FT032:EE_|PAVPR08MB9505:EE_
X-MS-Office365-Filtering-Correlation-Id: 8405cceb-4288-4d02-86a8-08dab117d80c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 zCdKpx8TKeWkY+nR51lWAHnG5lndjEDLyPLJrCZv7Icy8FTU5oj9IdaHoHPwgHJ9oC2YjNtH80f/1/PhIqymkV95iUvDiz8fjWE8472EX/PudtfDIxMKs++JOq/pmRiMDqVXp/nbIX5qJeTMbeVfAhkvMHnmosizctrO/r0pjGkdfYb+11J+SEkLX5kY2vjHMrTkq9R7qBDbb55Bkkj3uQ3cQctCcKIzcbslmvGJZHQefunJU7IS46S0EMcMmvDabUDmH7Ftf/31+RxgjZ090VjsReUNnX/xwttk/uEn58imQlh4T1+zKk22MAk/VcK9Bjywh68OcKJRtUGvD8MjHP0j6Ag6akM4BuqrXueezQXBIX07P+7oItC4FVlbp4NDHYQY23mOCEd8bxbl0b1Zueg8eix44+3/XobSP6OW7MoKw49lGTK4m1lddkT0bBIhGkov7UjPd0QnCQMSta7pg7vcakksmjfdvUeWcjtvL3Wtv8Me0JZNQ7VIkBlFNo0jXkblE6wm4P/uTkoDQUkChH6CORFox7Yh+tjjAOVnCufAvPLBKJ6/YrCSeY1AhQk9psDRirnuw8UNToSyg4eMsZ3X059Jl0hd0jasXuKRgx+kKzYBYBzRPMeIQ3pnCvDoEkpVddk9glDKrGVVdCJXmLhzly0qxLlhwVEQV8k+Rp2oY+cR6ureM5SHgYL6QkpCRXDCmN3IbMC+8mfk7oO2bHd6c2B5Djsp6jGQGip2gMPZ7/uioPAQN6nseVE6j646tln/iFfzuXvnM1iam3AGDg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(451199015)(38070700005)(71200400001)(38100700002)(478600001)(122000001)(9686003)(54906003)(33656002)(6506007)(7696005)(4326008)(6916009)(316002)(186003)(76116006)(66946007)(66556008)(64756008)(66476007)(66446008)(8676002)(4744005)(5660300002)(2906002)(26005)(55016003)(8936002)(86362001)(52536014)(83380400001)(41300700001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6373
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	887dfa86-2cb0-4474-a73b-08dab117d064
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ccNcRAIAIO+HvlfD0rMkZJHBLamM9ACw+PEBU+DamNFdCvd0NWhQrdxt77Aym+YreC1x+mlpllQWukzDynqgS4un2krfWk2c1aLcoTXo6PwPDNnbb16zXSDsU2cNvE/OG7yUSxoOLvacJuJyDSyY0vXFyq3nD8bTFEJYESpgqYCv2mp5FZrWYc0icG1NRZSIwVCRiqW1DWDjDzGqXsaUSnj243eYtpw0Ied6Z48bern3uM7yLTqEFz7nvKQgxq+yL81Y0oAqs3Sc21qrFEEhPKBzmqyYik2O1K0TOlRMj/9nreWcTtNXFED9Ir3xvndm8QyvQ//8P2QI/PNgckWhFG/7QlH3wK6RcvX/xVLgtiF/WCumMp5x2T/j/+PwIKiu8+bkhR/hdLS3RKRi/HpBdzmkM9LgAFnU7Q8Tt/cqnXBDuu43F0TmNJY4wowWONmaJg+VFUaw61PDgo8ZILrGG68069+oyBMjA2wMiuw6GrWuBKrRv8zona1jGwXbDEwJTtpgk5Nsh3qTFZxB7vTYXLM67L+nXTMu8AVCnWkn8GuDS10tnlsj3mnNuYd593MgFLwEbXiG/qAP6qxi53nDBigDfnKoBa9WmqVKH96INxl9SCLT7TXQXQD7/HNyqT8VGgQV4NQ06oShKYS/8f/Ni9Kh8ueU8RK/S1mi2mbXAgQ9ELgztfa1dJgod06BNYTzIJ/kM3ugTRamYQdHASGD2PWxG8mbSgH4XDq04zRWs2UYfAKwRvmLmfW5gZjlfO/q9oCP/CV/3AEKSpgkTU+HGw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(86362001)(40480700001)(82740400003)(36860700001)(33656002)(55016003)(40460700003)(81166007)(356005)(82310400005)(83380400001)(316002)(107886003)(478600001)(54906003)(6916009)(41300700001)(7696005)(26005)(8936002)(6506007)(5660300002)(52536014)(4744005)(70206006)(70586007)(9686003)(8676002)(4326008)(336012)(186003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 14:48:39.2316
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8405cceb-4288-4d02-86a8-08dab117d80c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9505

> -----Original Message-----
> Subject: [PATCH v5 1/2] arm/p2m: Rework p2m_init()
>=20
> From: Andrew Cooper <andrew.cooper3@citrix.com>
>=20
> p2m_init() is mostly trivial initialisation, but has two fallible operati=
ons
> which are on either side of the backpointer trigger for teardown to take
> actions.
>=20
> p2m_free_vmid() is idempotent with a failed p2m_alloc_vmid(), so rearrang=
e
> p2m_init() to perform all trivial setup, then set the backpointer, then
> perform all fallible setup.
>=20
> This will simplify a future bugfix which needs to add a third fallible
> operation.
>=20
> No practical change.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Julien Grall <jgrall@amazon.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:53:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:53:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425078.672851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknyc-0003za-Ks; Tue, 18 Oct 2022 14:53:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425078.672851; Tue, 18 Oct 2022 14:53:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknyc-0003zT-IF; Tue, 18 Oct 2022 14:53:54 +0000
Received: by outflank-mailman (input) for mailman id 425078;
 Tue, 18 Oct 2022 14:53:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4KBa=2T=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oknyb-0003zM-Ac
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:53:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id adccab35-4ef4-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:53:51 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6762521883;
 Tue, 18 Oct 2022 14:53:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E093713480;
 Tue, 18 Oct 2022 14:53:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mDKRNf69TmMFUAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 18 Oct 2022 14:53:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adccab35-4ef4-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666104831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bF3DrP31+GvB7zHSheslhxfSA2LjZWK4h34WoFWlWag=;
	b=uhEmpL+LqowFZpMis7rdL+XyM6ZyRWbZkXDYzYHWmF2taWuaLa2ZLBJo3GVuQiN6nQgV+b
	gd2k8uQWaCXYnJnPs19QlmYM7s+Qd53ecAQ5kSiVCAhSmoYvEh1yx8wuzMGdyGn2ZHwnQp
	3farCF8MEbGro7jEb0RxubTSemck+zo=
Message-ID: <e0448dac-a35e-cfd0-c087-411558512b5e@suse.com>
Date: Tue, 18 Oct 2022 16:53:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
To: Christoph Hellwig <hch@lst.de>, Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Anshuman Khandual <anshuman.khandual@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
 iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
 Jani Nikula <jani.nikula@linux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@intel.com>,
 Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
 Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20221018082413.GA25785@lst.de>
 <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com>
 <20221018110243.GA4655@lst.de>
 <d67ceabb-b31a-59e6-fc77-8d6c48b277f2@suse.com>
 <20221018143320.GA19106@lst.de>
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221018143320.GA19106@lst.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------dc3TknTbH6vDjCxs96kqh3VL"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------dc3TknTbH6vDjCxs96kqh3VL
Content-Type: multipart/mixed; boundary="------------Kgg0bGLcOQl0evOUdHqCwYPG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Christoph Hellwig <hch@lst.de>, Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Anshuman Khandual <anshuman.khandual@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
 iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
 Jani Nikula <jani.nikula@linux.intel.com>,
 Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@intel.com>,
 Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
 Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
Message-ID: <e0448dac-a35e-cfd0-c087-411558512b5e@suse.com>
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
References: <20221018082413.GA25785@lst.de>
 <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com>
 <20221018110243.GA4655@lst.de>
 <d67ceabb-b31a-59e6-fc77-8d6c48b277f2@suse.com>
 <20221018143320.GA19106@lst.de>
In-Reply-To: <20221018143320.GA19106@lst.de>

--------------Kgg0bGLcOQl0evOUdHqCwYPG
Content-Type: multipart/mixed; boundary="------------HP4PX2rd4ybSjA8vplorqVEm"

--------------HP4PX2rd4ybSjA8vplorqVEm
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTguMTAuMjIgMTY6MzMsIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOg0KPiBPbiBUdWUs
IE9jdCAxOCwgMjAyMiBhdCAwNDoyMTo0M1BNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToN
Cj4+IExlYXZpbmcgdGhlICJpOTE1IGFidXNlcyIgcGFydCBhc2lkZSAoYmVjYXVzZSBJIGNh
bid0IHRlbGwgd2hhdCBleGFjdGx5IHRoZQ0KPj4gYWJ1c2UgaXMpLCBidXQgYXNzdW1pbmcg
dGhhdCAiY2FuJ3QgY29wZSB3aXRoIGJvdW5jZSBidWZmZXJpbmciIG1lYW5zIHRoZXkNCj4+
IGRvbid0IGFjdHVhbGx5IHVzZSB0aGUgYWxsb2NhdGVkIGJ1ZmZlcnMsIEknZCBzdWdnZXN0
IHRoaXM6DQo+IA0KPiBFeGNlcHQgZm9yIG9uZSBvZGQgcGxhY2UgaTkxNSBuZXZlciB1c2Vz
IGRtYV9hbGxvY18qIGJ1dCBhbHdheXMgYWxsb2NhdGVzDQo+IG1lbW9yeSBpdHNlbGYgYW5k
IHRoZW4gbWFwcyBpdCwgYnV0IHRoZW4gdHJlYXRzIGl0IGFzIGlmIGl0IHdhcyBhDQo+IGRt
YV9hbGxvY19jb2hlcmVudCBhbGxvY2F0aW9ucywgdGhhdCBpcyBuZXZlciBkb2VzIG93bmVy
c2hpcCBjaGFuZ2VzLg0KPiANCj4+IEkndmUgZHJvcHBlZCB0aGUgVERYIHJlbGF0ZWQgcmVt
YXJrIGJlY2F1c2UgSSBkb24ndCB0aGluayBpdCdzIG1lYW5pbmdmdWwNCj4+IGZvciBQViBn
dWVzdHMuDQo+IA0KPiBUaGlzIHJlbWFyayBpcyBmb3IgVERYIGluIGdlbmVyYWwsIG5vdCBY
ZW4gcmVsYXRlZC4gIFdpdGggVERYIGFuZCBvdGhlcg0KPiBjb25maWRlbnRhdGlhbCBjb21w
dXRpbmcgc2NoZW1lcywgYWxsIERNQSBtdXN0IGJlIGJvdW5jZSBidWZmZXJlZCwgYW5kDQo+
IGFsbCBkcml2ZXJzIHNraXBwaW5nIGRtYV9zeW5jKiBjYWxscyBhcmUgYnJva2VuLg0KPiAN
Cj4+IE90b2ggSSd2ZSBsZWZ0IHRoZSAiYWJ1c2VzIGlnbm9yZXMiIHdvcmQgc2VxdWVuY2Ug
YXMgaXMsIG5vDQo+PiBtYXR0ZXIgdGhhdCBpdCByZWFkcyBvZGQgdG8gbWUuIFBsdXMsIGFz
IGhpbnRlZCBhdCBiZWZvcmUsIEknbSBub3QNCj4+IGNvbnZpbmNlZCB0aGUgSVNfRU5BQkxF
RCgpIHVzZSBpcyBhY3R1YWxseSBuZWNlc3Nhcnkgb3Igd2FycmFudGVkIGhlcmUuDQo+IA0K
PiBJZiB3ZSBkb24ndCBuZWVkIHRoZSBJU19FTkFCTEVEIGlzIG5vdCBuZWVkZWQgSSdtIGFs
bCBmb3IgZHJvcHBpbmcgaXQuDQo+IEJ1dCB1bmxlc3MgSSBtaXNyZWFkIHRoZSBjb2RlLCBv
biBhcm0vYXJtNjQgZXZlbiBQViBndWVzdHMgYXJlIDE6MQ0KPiBtYXBwZWQgc28gdGhhdCBh
bGwgTGludXggcGh5c2ljYWxseSBjb250aWdvdXMgbWVtb3J5IGFsc28gaXMgWGVuDQo+IGNv
bnRpZ291cywgc28gd2UgZG9uJ3QgbmVlZCB0aGUgaGFjay4NCg0KVGhlcmUgYXJlIG5vIFBW
IGd1ZXN0cyBvbiBhcm0vYXJtNjQuDQoNCg0KSnVlcmdlbg0K
--------------HP4PX2rd4ybSjA8vplorqVEm
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------HP4PX2rd4ybSjA8vplorqVEm--

--------------Kgg0bGLcOQl0evOUdHqCwYPG--

--------------dc3TknTbH6vDjCxs96kqh3VL
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNOvf4FAwAAAAAACgkQsN6d1ii/Ey+9
8Qf+JxxMZEdEGyEjsJpPt47ZJcyUfuvyHf4WDR8qZjfA5REOBj3vzoCPls41mnZKRxb+Q3Hm+aZp
UG0JJKo8XA9PiqrI87WOza8ogApFg0Cfizhyuw7V5a/HJGuGmGbsgRhphQLhpVXi7HODv1qc2iPL
NIxi93tZAYo3lI2mCp2H8FV/okYkz8gtiaOtaP9KciQJV7ccttWIVVVD5PCkBgqRyu0Ko/L6F24C
AD/db7b/Dv8oc/pbAf/0vfUa/zaoFLzOt442UfIcKgYB3TtX3yGTRdJbWGL4OSo91oTlKzCBR+oM
bMJYClYr1+UbHfeGeGkLHwb9KBuOs65u79bb1Uudkg==
=qg+p
-----END PGP SIGNATURE-----

--------------dc3TknTbH6vDjCxs96kqh3VL--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:54:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:54:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425083.672862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknzZ-0004Y8-V3; Tue, 18 Oct 2022 14:54:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425083.672862; Tue, 18 Oct 2022 14:54:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oknzZ-0004Xz-S4; Tue, 18 Oct 2022 14:54:53 +0000
Received: by outflank-mailman (input) for mailman id 425083;
 Tue, 18 Oct 2022 14:54:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oknzY-0004Xj-IB; Tue, 18 Oct 2022 14:54:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oknzY-0003Wq-Fa; Tue, 18 Oct 2022 14:54:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oknzX-0006LJ-VM; Tue, 18 Oct 2022 14:54:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oknzX-000544-Ui; Tue, 18 Oct 2022 14:54:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9KEBzG/hmhfOWVpSR0z1NP1vctIv5i67cYcogdHktxY=; b=4JRaBrAMzyaMXQWdiDlz4G5ow1
	1TX7Uzod0nV6/ozIrpIiQdP1VX2rI+KfrCsAaAqBlebFipsvFel6TuQglKHD9LXsF5YEjnIolyqWx
	bUh0jepQb47iEr8LTUYHhEcyZyp6B2VkKGa7y8rKM0+kd5yDaHykEHcRNCDx0HifoAog=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174034-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174034: regressions - trouble: blocked/fail/pass/starved
X-Osstest-Failures:
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking
    linux-linus:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    linux=bb1a1146467ad812bb65440696df0782e2bc63c8
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 14:54:51 +0000

flight 174034 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174034/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-examine      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 linux                bb1a1146467ad812bb65440696df0782e2bc63c8
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   10 days
Failing since        173470  2022-10-08 06:21:34 Z   10 days   19 attempts
Testing same since   174034  2022-10-18 04:15:50 Z    0 days    1 attempts

------------------------------------------------------------
1277 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          starved 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     starved 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      starved 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 120462 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:55:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:55:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425092.672873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oko0Z-0005Ic-Dg; Tue, 18 Oct 2022 14:55:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425092.672873; Tue, 18 Oct 2022 14:55:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oko0Z-0005IV-Ar; Tue, 18 Oct 2022 14:55:55 +0000
Received: by outflank-mailman (input) for mailman id 425092;
 Tue, 18 Oct 2022 14:55:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ieme=2T=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1oko0Y-0005Gh-Pb
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 14:55:54 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6aeb438-4ef4-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 16:55:53 +0200 (CEST)
Received: by verein.lst.de (Postfix, from userid 2407)
 id BD2FD68C4E; Tue, 18 Oct 2022 16:55:50 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6aeb438-4ef4-11ed-8fd0-01056ac49cbb
Date: Tue, 18 Oct 2022 16:55:50 +0200
From: Christoph Hellwig <hch@lst.de>
To: Juergen Gross <jgross@suse.com>
Cc: Christoph Hellwig <hch@lst.de>, Jan Beulich <jbeulich@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	regressions@lists.linux.dev, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, Robert Beckett <bob.beckett@collabora.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>
Subject: Re: i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify
 swiotlb_max_segment"
Message-ID: <20221018145550.GA21066@lst.de>
References: <20221018082413.GA25785@lst.de> <a5966644-72d7-4b25-83d1-9765d0593e44@suse.com> <20221018110243.GA4655@lst.de> <d67ceabb-b31a-59e6-fc77-8d6c48b277f2@suse.com> <20221018143320.GA19106@lst.de> <e0448dac-a35e-cfd0-c087-411558512b5e@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e0448dac-a35e-cfd0-c087-411558512b5e@suse.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Tue, Oct 18, 2022 at 04:53:50PM +0200, Juergen Gross wrote:
>> If we don't need the IS_ENABLED is not needed I'm all for dropping it.
>> But unless I misread the code, on arm/arm64 even PV guests are 1:1
>> mapped so that all Linux physically contigous memory also is Xen
>> contigous, so we don't need the hack.
>
> There are no PV guests on arm/arm64.

Ok, that's the part I was missing.  In that case we should be fine
without the IS_ENABLED indeed.


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:57:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:57:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425100.672883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oko2S-0005wO-PL; Tue, 18 Oct 2022 14:57:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425100.672883; Tue, 18 Oct 2022 14:57:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oko2S-0005wH-ML; Tue, 18 Oct 2022 14:57:52 +0000
Received: by outflank-mailman (input) for mailman id 425100;
 Tue, 18 Oct 2022 14:57:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oko2R-0005w2-DR; Tue, 18 Oct 2022 14:57:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oko2R-0003bB-Bh; Tue, 18 Oct 2022 14:57:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oko2Q-0006Sf-Sz; Tue, 18 Oct 2022 14:57:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oko2Q-0007qT-SV; Tue, 18 Oct 2022 14:57:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IS2spNuhG47Iwu8VnYIWMNIXuoly1DVLgDmg5gM/gYg=; b=WhNRhf+fKwoOg88vv2hkpqFeJb
	O905Au7dzgwFLjfOZnOZlQonM8ZQ/Hb9LBp1rqlYqsuCRcCtUkgcrFMWBzJpJQLNTcYpttYMhOnBW
	zzyeeGdxYMyaVKQzJ/Khg0XUdhtocj25qRubnTaV8xkmxWY0GDXRO2ic3FgzYpYBzTGA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174030-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174030: tolerable trouble: fail/pass/starved - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking
    qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    qemuu=8823ef1336d6c4af1a6ccdcaa8f5c0b756f3a875
X-Osstest-Versions-That:
    qemuu=5c2439a92ce4a1c5a53070bd803d6f7647e702ca
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 14:57:50 +0000

flight 174030 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174030/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173967
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173967
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173967
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173967
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173967
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-arm64-arm64-libvirt-raw  3 hosts-allocate               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a
 test-arm64-arm64-libvirt-xsm  3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-credit1   3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-credit2   3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-xsm       3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl           3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-seattle   3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-thunderx  3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-vhd       3 hosts-allocate               starved  n/a

version targeted for testing:
 qemuu                8823ef1336d6c4af1a6ccdcaa8f5c0b756f3a875
baseline version:
 qemuu                5c2439a92ce4a1c5a53070bd803d6f7647e702ca

Last test of basis   173967  2022-10-17 00:10:12 Z    1 days
Testing same since   174030  2022-10-18 02:12:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andreas K. Huettel <dilfridge@gentoo.org>
  Philippe Mathieu-Daudé <philmd@linaro.org>
  Song Gao <gaosong@loongson.cn>
  Stefan Hajnoczi <stefanha@redhat.com>
  WANG Xuerui <xen0n@gentoo.org>
  Xiaojuan Yang <yangxiaojuan@loongson.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          starved 
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 starved 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      starved 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  starved 
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  starved 
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 starved 
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  starved 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 starved 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      starved 
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   5c2439a92c..8823ef1336  8823ef1336d6c4af1a6ccdcaa8f5c0b756f3a875 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 14:58:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 14:58:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425107.672895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oko3F-0006UM-2x; Tue, 18 Oct 2022 14:58:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425107.672895; Tue, 18 Oct 2022 14:58:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oko3F-0006UF-0G; Tue, 18 Oct 2022 14:58:41 +0000
Received: by outflank-mailman (input) for mailman id 425107;
 Tue, 18 Oct 2022 14:58:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oko3D-0006U1-TV; Tue, 18 Oct 2022 14:58:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oko3D-0003bv-Sg; Tue, 18 Oct 2022 14:58:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oko3D-0006UQ-Lt; Tue, 18 Oct 2022 14:58:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oko3D-0008CB-LQ; Tue, 18 Oct 2022 14:58:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RWCkuW+Af2N1OQqrPbiU3KgZNCGrwC0iqLKi+Ky3mHs=; b=6q7wJ6Pu8P4gRs++1tfhb49QIg
	lSmPVar56pXG6I4JWq/TYR5bLfCTtkBNzmOpikMFRk56/WkOI3qJs3ihV979oSNiYn0AQcQHZX5ab
	jT2wtj0kGB4j3Z1iEV1FC7qYSz9cuiBJnx94k6kMstlHBmIJknZ8jAj8hmpiPnLcHCJQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174048-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174048: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 14:58:39 +0000

flight 174048 xen-unstable-smoke real [real]
flight 174050 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174048/
http://logs.test-lab.xenproject.org/osstest/logs/174050/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   45 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 15:08:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 15:08:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425154.672924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoCJ-0000nG-Bq; Tue, 18 Oct 2022 15:08:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425154.672924; Tue, 18 Oct 2022 15:08:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoCJ-0000n9-80; Tue, 18 Oct 2022 15:08:03 +0000
Received: by outflank-mailman (input) for mailman id 425154;
 Tue, 18 Oct 2022 15:08:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RnJu=2T=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okoCH-0000n3-UW
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 15:08:02 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a8038f90-4ef6-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 17:08:00 +0200 (CEST)
Received: from AM5PR0402CA0008.eurprd04.prod.outlook.com
 (2603:10a6:203:90::18) by DB9PR08MB6490.eurprd08.prod.outlook.com
 (2603:10a6:10:25a::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 15:07:57 +0000
Received: from VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:90:cafe::df) by AM5PR0402CA0008.outlook.office365.com
 (2603:10a6:203:90::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Tue, 18 Oct 2022 15:07:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT052.mail.protection.outlook.com (100.127.144.233) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Tue, 18 Oct 2022 15:07:56 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Tue, 18 Oct 2022 15:07:55 +0000
Received: from 68d07a9aec62.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 651D6B36-EB7E-44A0-8F34-3FB68BF76D74.1; 
 Tue, 18 Oct 2022 15:07:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 68d07a9aec62.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 15:07:45 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB9PR08MB6347.eurprd08.prod.outlook.com (2603:10a6:10:253::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 15:07:42 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 15:07:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8038f90-4ef6-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=m05hvVSrnetaqlSbheSuJesKOn84OawYLkEFdQrWyDC8NQwDQPnmlfdWWUcKuNrxeg/NbLUc5ZoyOZuCbM31r1Dh0v1nWfrubj0wKCvpfMWjhIBsFQyrNeBMl0v/+xNT8vtu4QW5dQutUCg+cMZ8Hlya8ZQhfN6KFMUpF3U/0IkthtlxO5wzQXp7PrDkLszJE/jgpJCGxthtdyvI6Zu+AiV8gpI07O25ovJrjUmW2ehyBo6R6tyJOKK6pBQNUZ/d2J6cwqIHkeaWpUMPX3+BdfcG86CxMstNRLnmhwr6AYHMZpVoQ1dhSjFkB5lBmYW5/Werz0JwcJ7TS5JJD8ksoQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h8h5zhdoolhHEZDPCk4VVAhcd7l812chy8Q6UHj2YS4=;
 b=cDFMhaDJf1okfq+2kyMa4QRbnZkafbONDGFGg0pBIj/e4M/307HHQzv7mlpDV1wqIp9KAoarCt/kBeNl4hBYl2A3Y/uzCTvc4Kzp0F1eYyy8lUiNyvLzvMgpY5F7/4p0kieho5C77X0Y/6UVEeNT40JwjOgSWncOE//Z2Hb+heQeOemK/ToKvqo7wNh/DquREnz2tZcuOOnuH5vv/GB5yYvfqrbLOa3umizUXmFP4OHQxY8lxuoHJIYiZkkPHVTUP6od59qSVfX47bsyGV5zDYS08YWITEEqVopFvOrOz0279QYI4K/BkENqWxTdcn9FcQZcRbfpGyGo2eJneTMGUw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h8h5zhdoolhHEZDPCk4VVAhcd7l812chy8Q6UHj2YS4=;
 b=QzvBryjkFNaj4/lQgMHewVKzVTeOQJMaZ8+Z58fBVpbuIYkvrDuiDyVtO6GTEAJXRd4DvS68PzGEeH+8bqYuPQ1iD5/2chJR79LSZwfnZUisld4zPpbK51XtGkqQ1KGnxs0+1TjGRMkxmmM0YCJX/+fZfJwOcb5x/JlyyQfdiA0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1ca733ce53479071
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jWm4hwSTweo9UMAKcHt/tIKGsHFx2KESIAPFCW9M4rfBjk6UM2EdJC3fZVE7ObBjDHoqWIfFUbxtBsQNkUcUAriNcxlppiBuXU277OFdrd08sJMeyuwE/zGQbZZb5bA6HmlQRSL47sGY5kzsYQNz3xJfP8lNYjgwh4GeExzfImMNnXuXd6VddbxtfiBhGK3waA02SVkcCmslTlCZXsy/B1ihRl855eKuSa72ZBkticJxkkezw4JJIH+6h78L7Vrf1xA5E057o1IYd3c2+bAnC0UGb9ADF+MrEvBINd1Lb81e+Hj3Ec1vk/VWaf0YxD2UAkkyYDLx21Eeq0PeI6WmPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=h8h5zhdoolhHEZDPCk4VVAhcd7l812chy8Q6UHj2YS4=;
 b=NeGCKaAl5pYhnST3g2Xv2hoTma/2vh6HWV7ZlaBgBL43Ly3Wo/iuhXLXOKJx1tSxzOnChfFDzhIg6gbXeQa+rFI083xFSlWkK/f6NmqXyOK/nZh9UM5L2Ipy4N3VsmWMMAV0HArVwtVe6yT18wyTEI+OeyanF+CMV+Q+XvGbklRcyNKu2CkY+7wfOV+MZp0sNBCEJWPS9JpD4/Ga+PIVIF1vchq+niKn4Fg4wrT6+W3INlR41f4CYUM10EnahxrGoQR+k+BNNmqLaJF1EIMpZwCKSneN4SWt0Rxui17E1EpBbf4eIM/LQabiwNx1F1U8lUroyPEF11qkZWbhZlnRaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=h8h5zhdoolhHEZDPCk4VVAhcd7l812chy8Q6UHj2YS4=;
 b=QzvBryjkFNaj4/lQgMHewVKzVTeOQJMaZ8+Z58fBVpbuIYkvrDuiDyVtO6GTEAJXRd4DvS68PzGEeH+8bqYuPQ1iD5/2chJR79LSZwfnZUisld4zPpbK51XtGkqQ1KGnxs0+1TjGRMkxmmM0YCJX/+fZfJwOcb5x/JlyyQfdiA0=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Henry Wang <Henry.Wang@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Wei Chen
	<Wei.Chen@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH v4] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4kjE5QulsJtPN02L0AHtsxk0ra4S8tkAgAFPUgA=
Date: Tue, 18 Oct 2022 15:07:42 +0000
Message-ID: <3EAD681D-7B3D-4165-B9DA-04587D233386@arm.com>
References: <20221017165133.17066-1-Henry.Wang@arm.com>
 <fcb69acd-2985-1c84-07b4-94cff742a18c@citrix.com>
In-Reply-To: <fcb69acd-2985-1c84-07b4-94cff742a18c@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|DB9PR08MB6347:EE_|VI1EUR03FT052:EE_|DB9PR08MB6490:EE_
X-MS-Office365-Filtering-Correlation-Id: cf2d93c8-a80b-4e98-e01d-08dab11a89e9
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6tExFk0G3eLsl+Onz3NLXSQoMiVtW9wtgCemXS/QX0npp1N5gnStqs6l5L5ygmFEPR9oHUiBW7XrGGYstjehdj2MeAVdSHbAhhrLToAuWypDF7aekKgejc/xzebFRuAlOTtUupMBuMgW2Jb9jkdqlf8pmK3LyEsDOFxxCYQVDDHLeNLSe0M0uHFi1FgM8qG+Dye6C8+00fCBsxGUsifTcsAlcDFxMn4cF14R+H2/gQPc/XxmIMczNsjvyin5hOMnTQ7Z2f/JRHxhlAlDJ4tAeoucs5yhy+pqQqEM3B0yQbdVsUFyW5M4O6UYjqAlVn2B1JsLbGXOmwTjS03JQ+VMC/icyIBHY9f3yiCGT+Y1ctCgL10bdGF6jnykP//bjSLf6PgHx3V5b8MQk9cCu9zRwxhkNgn0PxeXDVyAwid3d+OPsd6wTKTKCIw8XDfvTkMwtcERlE1ynEBkotPzM8FJnEXxQZwYBg58HFetNqMFMUH+5Tk+gSu5/hon1e1WUhXuts6KzRso5kczpwRZI9UDVW2HRlbsmFrp9uGVXZt4tcjd0f2pZUagzy/d6PmuwaNnfULf0sZIqRgl+qk2jqIFuFKwPrYN/jNooGNxK6r13bh3ENXFWRD4Qrt25zB1/6Ttz+Spp52Ov8RdLDZjzlehp1XM4A+LtSz3qFv/gbb2J8TkLUlxhjSMXUoDNFjDY/HFwVTr8aYjSEJ8wAo71kLdG2Widh/rSWLbcKzicY3DpSa6k6afoAsMScMgri+qTne7mCVX9AcwgBQRqzMey33SupCmGsneUcieq/q7r4e90Lw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(451199015)(36756003)(33656002)(86362001)(4744005)(5660300002)(38100700002)(2906002)(186003)(2616005)(71200400001)(6916009)(38070700005)(26005)(6506007)(316002)(53546011)(478600001)(6486002)(54906003)(6512007)(41300700001)(66476007)(76116006)(66556008)(91956017)(66446008)(66946007)(122000001)(4326008)(8936002)(64756008)(8676002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1285DAC713B58B47950B51C46C825DD3@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6347
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bc2e55b6-492f-44ce-fdcc-08dab11a8168
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dy3GbMr1APGo7NqKG7znVXJGS1BklvzpOVZyn6pAgIWfkR0fADsL4CxgmwNQj4tywjHpYYp619mR0kjpcLDv6aDF2jbRQ4Fz6uzEHCezDXSALO+OIzGgpq+DdmFDdtCCXYiVM7ETiZBAsGwo1cUlptKc/tDEj8PJR/fe3Gq3NfNF0vm8msgwqFqfGel9mfgtkkmIMa+gwRIB4AhizMtgIUzY2r0vkRt6FD0poBJPWWE/VXiANVv9hQMG31mBTs17cKo099hfBFqHgs9FfB5Z+L/iwO0oFnVQruaN6f2CSqh3yxMOZx+d6/uV2EcwGRo99dZktpBpQnJnEcOl6klsT+iafZFRG0Mbv0ML4qcCE98GIlnzzzjo+aTli7lnkY5fxYGw9Z4Jrbj6VOtYP1S6t9irft/ZR0lOKV3t5sv6Zkrtv/3wbu5HxK2AdKNqn8LCfqLBJZDpMOLllqHR413I1J+9ueuNJbV9w3oqosyRB1uRUYqZj0Qb6bh1qmywsYyUqA9epp1lz2YHILiQYeQl5gH24dLSPkh8VxXq2wajBvX4ErS2GSUNRZJoj9Jm+vevqi2TjQORUsNdHSBpb628olcXzj3WhydHicKb0jUxpN5JPmQgu7SOvhYYVWi4Qb6k5dmSiX98K+DBFqzal1L+Vjf8H49bSkOamcETPyoUPigZr9M/GB+w+JDKW20z/tb1M4QQiPKLmxY0O9aZj44xIhV1aPoRkDzjD0OLpzpQWaK0vr7CFUGmRRJuG2Q8OtMf1dYcbUNdNPRb/jFBjfGHUw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(54906003)(4744005)(8676002)(316002)(478600001)(4326008)(53546011)(6512007)(6506007)(41300700001)(26005)(186003)(2906002)(6862004)(5660300002)(6486002)(8936002)(336012)(2616005)(81166007)(36756003)(82740400003)(356005)(82310400005)(47076005)(36860700001)(70206006)(70586007)(33656002)(107886003)(40460700003)(86362001)(40480700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:07:56.6324
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cf2d93c8-a80b-4e98-e01d-08dab11a89e9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6490

Hi Andrew,

> On 17 Oct 2022, at 20:07, Andrew Cooper <Andrew.Cooper3@citrix.com> wrote=
:
>=20
> On 17/10/2022 17:51, Henry Wang wrote:
>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>> index f17500ddf3..0b4e24218e 100644
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -1784,6 +1800,8 @@ int p2m_init(struct domain *d)
>>         !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK);
>>=20
>>     rc =3D p2m_alloc_table(d);
>> +    if ( rc !=3D 0 )
>> +        return rc;
>=20
> This error path now leaks the VMID.
>=20
> And to preempt the obvious change, if you simply move this lower, you'll
> introduce a path where p2m_teardown() falls over a NULL pointer.

Could you explain me the in which case we would end up with a NULL pointer =
?
If the list is empty we bail out so I do not see how this could happen.

Cheers
Bertrand

>=20
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 15:17:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 15:17:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425197.672952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoLj-0003TX-Ny; Tue, 18 Oct 2022 15:17:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425197.672952; Tue, 18 Oct 2022 15:17:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoLj-0003TQ-LD; Tue, 18 Oct 2022 15:17:47 +0000
Received: by outflank-mailman (input) for mailman id 425197;
 Tue, 18 Oct 2022 15:17:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=opEU=2T=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1okoLi-0003TK-I4
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 15:17:46 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130040.outbound.protection.outlook.com [40.107.13.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 03d7e813-4ef8-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 17:17:44 +0200 (CEST)
Received: from DB8PR09CA0020.eurprd09.prod.outlook.com (2603:10a6:10:a0::33)
 by DB9PR08MB8265.eurprd08.prod.outlook.com (2603:10a6:10:3c7::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct
 2022 15:17:40 +0000
Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:a0:cafe::57) by DB8PR09CA0020.outlook.office365.com
 (2603:10a6:10:a0::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend
 Transport; Tue, 18 Oct 2022 15:17:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 18 Oct 2022 15:17:40 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Tue, 18 Oct 2022 15:17:39 +0000
Received: from a7e7e8fd1376.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 79A1230C-79F0-4EF9-9600-B84614FE2355.1; 
 Tue, 18 Oct 2022 15:17:29 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7e7e8fd1376.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 15:17:29 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by AM8PR08MB6514.eurprd08.prod.outlook.com (2603:10a6:20b:36b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct
 2022 15:17:26 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 15:17:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03d7e813-4ef8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=aI6xRDzD1Wahfjl1EAK9xFk4uSZMwxClJho6bhrQNiRBSKqChuMOUwxOCCrpf0I+BRPOn9kHTLPJ90646plOm7anQCceVjmJCJOl2KpGXbTQ7+1I3Z8K51haNbrRch79yR21zNGnvG9wW89FYKDCGKh3Mm0X5T66JojC+KLZVDA1tpnM8VVU2yKo3ZMgdfINNvtKicykPov+keemWzbLDw6xO1zikUVJ6P4mHq/uFM4Jfy9gb5ijbfE84cqodyYHm9xMILZpO3TCV1oYEr8cYc4vMIZGXk9lowuUU0EsoDligkwRCSZLHpi1RU8Q5o5Y8wWt3MU1EY0Duv2HLWfaUg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Ghlzpktg46hCF/5KCmkbb768aLnMPNkKW7sL6+jCLY=;
 b=l6CIhLmc3es3PHJ9zkCRSB1/5XdLvYNcxkVP48y/zoKnPV56O2iiGg2tfMRj78LsUId+fnxPNmAnf9JCS0iRebqmIe/8/Ir0Zo47KWBn+vmc9ggsn4yVK3MOa9Hiix3r3Ewax0BhXdVg3LVA7HUM5vFboUXkljpnytBzYlt5LGTm60i4oJeO+eNL8FAusOFKcxrCa//9kY5set5H8GsozqlhP8L2jeA9Yc3j2tbEtPCRKCLvFSdl5k1aA/+4KjPXmFZpFEVRPm9lo56k70PiyoCA53JQmGLz1Ay9eNuCXtCsmg8Ht0C34E5wKK1e+BsLlx3E3Q1A/AuwPb3xi6Gesw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9Ghlzpktg46hCF/5KCmkbb768aLnMPNkKW7sL6+jCLY=;
 b=qbO0xTcRhVCBu5/dKH0mtTjHYSw6L5iNep2+EC5JC2BrmIZhdURAgOKwRUu37FRqev+Rj+qA9j/63Ah2SzERF6ksAgbWv39oeaMdYo4fQrHQzNn73jvCn8YPKggDiWlOA5TueEGse9zvWwEitFDAKzRadAtsBBRRFLLCsNdsajo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6cee83c84770fa8c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XViCx/ecZJ1XseowFrBUzUKris7o4AWx5XG3sbSvRb/oObzC/Rn8+Xi5uJCpaW6hzmd4X0LTQLuCSHHN8/iYrY/mlC0VcRZTLobAQGj436EVuu6X5xDrhck2CMBQyEbWYCIltx7uceSu1wHjJeLzIVRsFyGG57+2cmURn/newvcvNYAzFTxXmkM6wzTwKAZD/rXGnSQRhvO/OK8ZOsR5PXrJimFeMvPg6eydfHU6rpYoxosRtBpOwuawO33eACGypdJhi8ljRm+hZZAcfsDoU0yBgf19x4lLDU0RbbxKGDD5ucc92jtYnrOO//Ev1auL5VIy4PFj5RadcKeiiWhgkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9Ghlzpktg46hCF/5KCmkbb768aLnMPNkKW7sL6+jCLY=;
 b=fV9V9e8OnfhmoOA29AE4z62yck/YXQ6aooQ8zy1LPwjj1r5DbEupe5fGJ7eFMt7MlpLvHfk8++W+WjtV7c9AHvp9S4qxPPcvF/vTALab63hbnU6gQ1oope5Vity95LutlEDhPcNU3YCnPddFRK981SlO0CF/fuhfbZ9Us20DAvseXQeV1AkLKlc7QvwqD5wiChaaR49Tf3cIqrI+i1Y7OXm3mwzoR8F8r2S5GbkwW8wpYsNz+l4U/05A+P+Icu+zRpfB2o8o/f2nwyf1EpqHtQy+jqrin2eQsKgaonxNGG0Ce3+f6lEho8YLfhfzQrzzo2TPdny7nuZPE82zlF4q2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9Ghlzpktg46hCF/5KCmkbb768aLnMPNkKW7sL6+jCLY=;
 b=qbO0xTcRhVCBu5/dKH0mtTjHYSw6L5iNep2+EC5JC2BrmIZhdURAgOKwRUu37FRqev+Rj+qA9j/63Ah2SzERF6ksAgbWv39oeaMdYo4fQrHQzNn73jvCn8YPKggDiWlOA5TueEGse9zvWwEitFDAKzRadAtsBBRRFLLCsNdsajo=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index: AQHY3lPHTZwvWtdyCU+0K6Hw9nMyM64L9DeAgAAneoCAABdHAIAIGdUA
Date: Tue, 18 Oct 2022 15:17:26 +0000
Message-ID: <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
In-Reply-To: <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|AM8PR08MB6514:EE_|DBAEUR03FT011:EE_|DB9PR08MB8265:EE_
X-MS-Office365-Filtering-Correlation-Id: dbf6bdaa-046e-4bc2-6ea9-08dab11be59c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ZSd/Sdj/tIQmhqv4CqzbK6dMbBDsZZ0n7dUFZchQZdPW8m0SyO+FWHncyDSTVK540NxyAWSdmgT4qDhh8ACovmqZzL73+/lry0Uy4J4eVp/Q4YkBVHe7LdehK6KS7PqJzmh9r/JbO6npD1U1aQIHbojyDPoDxxjCTWAAIrhNDl/Cmh9n2CK5IQ67ZkwbfH2JwRpA3GphO77p3UZ8FPvcYQCZcLNhf9cj4QRJ7vq00Blfl+WSsrvdV6Jq618EssWCNrwj3eOihrOIk0mJ47sb8HwuSrmQlK+1nJe0NIGq4ZlKqy/fVjFqvCKWFB6pE3sdVCZI06ujB1/o7KApQLDPWMNTVGK2rwn1LIESZdfyowp+LclH592bQ735JY8VazyJCy1PwBQpw7D3ZORXVcbMZAEAv4Ig+HXW12p2rcpoF2BzuwVSq8uzCNmgfWYKFLJo4NDGukiPcdqul0CYc1iHhIjHVKSoObdZsaerD2pRQN9keW7OFV6FLKurTOEZIshxNCyahnmqdpRB9iSI4KCMbCKxb7XQizhWFysYBk/zcaPLBopJCGQUtfAjzGkr9VI603hdyoNQY8l8J9Pgiocf5aLwgA5ZHtYvXCMlikIXBsbOihEZgZ7t/BiMSeD5dv+8K6xPv5z3O8VpJrwUiNpT/0tBcOsuf7qTzNE9pQYRbdqSQfsRImyXt0KXg0vTStlmZ5bbD1BItbK7YGGfMT025cLzngezRrgPb3Uoy+rFikztpTMRKwhPrfAnChEo0cxfgZV1Z0vFemkUGRfUqlo6aXxm2WkB1ihHE6kfGOUf9AWQ2aUOskn+FJE/u/plywSUeaAMzk8SISOjFBUFA7Ag2A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(366004)(346002)(451199015)(186003)(2616005)(2906002)(6506007)(26005)(54906003)(5660300002)(53546011)(316002)(6916009)(6512007)(86362001)(38100700002)(41300700001)(66446008)(64756008)(8676002)(66476007)(33656002)(91956017)(76116006)(66556008)(66946007)(30864003)(83380400001)(122000001)(4326008)(966005)(8936002)(38070700005)(478600001)(36756003)(6486002)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <F40FEFAC34BA16479618CB8FB5D2B7DC@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6514
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	647e5766-0b61-4079-7cd7-08dab11bddb5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6m+SbglRLebYnL1C4PfwWwz4eQklx7FidCu+ANCq0gy+dTlGpQ8+lyP/KeDfg5tLK2JCuZbPZp5P3A36DtAAdszyzjzacfDSYFBty/szobs58Wg2V/dfUdUcAY9a6QHr5Hih0hEd1tw4ojwIr9k3l5L6rtXEy2m961I5i4u6QxySi9U390GDF/oUJU+n0RaPAKrfZhw5CSQQpMfuC9/xePkVwGiPbcC0Z4wk+4ysRxKzqM9hthLJ8lDwoHZ6TGr6zXqYPYusSzON0UmpJ6BCT4tX/my7Vs9+Lyg/LKj9eaRRHWnsKtnqCQOi267ONZdCBF+ECdpmd6JrqdNYTMttHRqsPPSbg4MSjBIQ6N984pyYrgp8eo8WI47PfkLQ30xnvjjIPvoLNpX8fTGVv47gG4hB2o6m8V1Yv31UZdWJN8KIr7glX7Ab1RpOO1sbHvxfVRNH4Swbl3BSgFBeGUJ9gm6pzPbDN1N3KGsOZw1iTO39iHkXbfFb9IfEME/Z+hBwIe8zC2O3rTmuw/otQXBoS0bh5CCV2JswFbsRdyeh9A9R2qHHAQbllwK+yge4M/+cdU8rnUzr8imLUYF9rF5uC9oQrtP8vmz2MBVTyI7VdA0Oe3cGeiWmJupSgR/djj5hwcCQ84V9CDxLVWIxnEV+amxXj/QSPZoRGMfjKjoiiRXOHmeO9tcA9XV/YxM8IGm9ZS72C5gohnUz/OmpMJr0btUY2bNv1mqoxuOu0uF1CFSSZeNIqPNt7R+oXa9T7+r8k0/57olXitIjf0FrBUAeedLPjjezqCfcUPQZZ6o2ggs=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(41300700001)(8936002)(2906002)(6862004)(5660300002)(30864003)(82310400005)(478600001)(316002)(70586007)(70206006)(6486002)(40480700001)(82740400003)(4326008)(8676002)(36756003)(26005)(54906003)(6512007)(6506007)(53546011)(966005)(33656002)(356005)(81166007)(2616005)(86362001)(40460700003)(47076005)(186003)(36860700001)(336012)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:17:40.0658
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dbf6bdaa-046e-4bc2-6ea9-08dab11be59c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8265

DQoNCj4gT24gMTMgT2N0IDIwMjIsIGF0IDEyOjM0LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTMuMTAuMjAyMiAxMjoxMSwgTHVjYSBGYW5jZWxsdSB3
cm90ZToNCj4+PiBPbiAxMyBPY3QgMjAyMiwgYXQgMDg6NTAsIEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gT24gMTIuMTAuMjAyMiAxODowMCwgTHVjYSBGYW5jZWxs
dSB3cm90ZToNCj4+Pj4gSW4gdGhlIFhlbiBjb2RlYmFzZSwgdGhlc2UgdGFncyB3aWxsIGJlIHVz
ZWQgdG8gZG9jdW1lbnQgYW5kIHN1cHByZXNzIGZpbmRpbmdzOg0KPj4+PiANCj4+Pj4gLSBTQUYt
WC1zYWZlOiBUaGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxpbmUgb2YgY29kZSBjb250YWlu
cyBhIGZpbmRpbmcsIGJ1dA0KPj4+PiB0aGUgbm9uIGNvbXBsaWFuY2UgdG8gdGhlIGNoZWNrZXIg
aXMgYW5hbHlzZWQgYW5kIGRlbW9uc3RyYXRlZCB0byBiZSBzYWZlLg0KPj4+PiAtIFNBRi1YLWZh
bHNlLXBvc2l0aXZlOiBUaGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxpbmUgb2YgY29kZSBj
b250YWlucyBhDQo+Pj4+IGZpbmRpbmcsIGJ1dCB0aGUgZmluZGluZyBpcyBhIGJ1ZyBvZiB0aGUg
dG9vbC4NCj4+PiANCj4+PiBXZSBkaWQgZGlzY3VzcyB0aGlzOiBGYWxzZSBwb3NpdGl2ZXMgYXJl
IG9mdGVuIHNwZWNpZmljIHRvIGp1c3Qgb25lIG9mIHRoZQ0KPj4+IHRvb2xzIHVzZWQuIEkgdGhp
bmsgdGhpcyB3YW50cyBtZW50aW9uaW5nIGhlcmUsIGluY2x1ZGluZyB0aGUgaW1wbGljYXRpb25z
DQo+Pj4gKGlpcmMgdGhlIHBsYW4gd2FzIHRvIGtlZXAgdGhlIHRhZyBnZW5lcmljIGJ1dCBtYWtl
IHRoZSB0YWJsZSBlbnRyeSBleHByZXNzDQo+Pj4gd2hpY2ggdG9vbCBpdCBpcyB0aGF0IGlzIGFm
ZmVjdGVkKS4NCj4+IA0KPj4gWWVzLCBpbiB0aGUgZGF0YWJhc2UgZm9ybWF0IGJlbG93LCBhIGZh
bHNlIHBvc2l0aXZlIGVudHJ5IHdpbGwgaGF2ZSBpdHMga2V5LXZhbHVlIGl0ZW0NCj4+IGluIHRo
ZSDigJxhbmFseXNlcuKAnSBkaWN0aW9uYXJ5LiBNb3Jlb3ZlciwgYSBmYWxzZSBwb3NpdGl2ZSBl
bnRyeSBjb3VsZCBiZSB3cml0dGVuIGZvcg0KPj4gZXhhbXBsZSBhcyB0aGUgbGluZSBiZWxvdywg
dG8gc3VwcHJlc3MgYSBjcHBjaGVjayBmYWxzZSBwb3NpdGl2ZSBmb3IgTUlTUkEgcnVsZSAyMC43
Og0KPj4gDQo+PiAvKiBTQUYtMC1mYWxzZS1wb3NpdGl2ZSBjcHBjaGVjayBmYWxzZS1wb3NpdGl2
ZSBmb3IgcnVsZSAyMC43ICovDQo+PiANCj4+IENsZWFybHkgdGhpcyBjb21tZW50IHdhbnRzIHRo
ZSBwcm9wZXIgZW50cnkgaW4gZmFsc2UtcG9zaXRpdmUuanNvbiB3aXRoIHRoZSBjb3JyZWN0IGlu
dGVybmFsIElEDQo+PiBmb3IgdGhlIHJ1bGUgMjAuNyBnaXZlbiBieSBjcHBjaGVjaywgdGhhdCBp
cyDigJxtaXNyYS1jMjAxMi0yMC434oCdLCBhbmQgYSBwcm9wZXIganVzdGlmaWNhdGlvbiB0aGF0
DQo+PiBleHBsYWlucyB3aHkgaXTigJlzIGEgYnVnIG9mIHRoZSB0b29sIGFuZCBub3QgYSBub24t
Y29tcGxpYW5jZSBvZiB0aGUgY29kZS4NCj4gDQo+IEFsbCBvZiB5b3VyIHJlc3BvbnNlIGRvZXNu
J3QgcmVhbGx5IHNlZW0gdG8gZml0IG15IHJlcXVlc3Qgb2YgbWFraW5nIG1vcmUNCj4gZXhwbGlj
aXQgdGhhdCBpbiB0aGUgY29tbW9uIGNhc2UgZmFsc2UgcG9zaXRpdmVzIGFyZSBleHBlY3RlZCB0
byBiZSBsaW1pdGVkDQo+IHRvIGp1c3Qgb25lIHRvb2wuIChJbiBmYWN0IEkgd2FzIHdvbmRlcmlu
ZyB3aGV0aGVyLCBvdGhlciB0aGFuIGZvciB0aGUNCj4gInNhZmUiIHRhYmxlLCB0aGVyZSB3b3Vs
ZG4ndCBiZXR0ZXIgYmUgcGVyLXRvb2wgZmFsc2UtcG9zaXRpdmVzIHRhYmxlcy4gTm90DQo+IHRo
ZSBsZWFzdCBiZWNhdXNlIGZhbHNlIHBvc2l0aXZlcyBhcmUgYWxzbyBsaWFibGUgdG8gYmUgdmVy
c2lvbiBkZXBlbmRlbnQsDQo+IHdoaWNoIGN1cnJlbnRseSB5b3UgaGF2ZSBubyB3YXkgdG8gZXhw
cmVzcy4pDQoNClRoZSBmYWxzZS1wb3NpdGl2ZSBmb3JtYXQgbWlnaHQgYmUgZGlmZmVyZW50IGZy
b20gdGhlIHNhZmUgdGFibGUsIGZvciBleGFtcGxlIGFkZGluZyBhIOKAnHZlcnNpb27igJ0gZmll
bGQgdG8NCnRoZSBlbnRyeSAod2hpY2ggaXMgZWFzeSB1c2luZyB0aGUgSlNPTiBmb3JtYXQpLg0K
DQpJdCBzaG91bGRu4oCZdCBiZSBhIHByb2JsZW0gdG8gaGF2ZSBkaWZmZXJlbnQgZmlsZXMgZm9y
IGVhY2ggYW5hbHlzaXMgdG9vbCwgYnV0IHdlIG5lZWQgdG8gcHJvdmlkZSBkaWZmZXJlbnQNCnRh
Z3MgbGlrZSAvKiBTQUYtWC1mYWxzZS1wb3NpdGl2ZS08dG9vbD4gKi8NCg0KQnV0IEkgZG9u4oCZ
dCBleHBlY3QgdG8gaGF2ZSBhIGxvdCBvZiBmYWxzZSBwb3NpdGl2ZSBhcGFydCBmcm9tIGNwcGNo
ZWNrLCBzbyBmb3IgdGhhdCByZWFzb24gSSB3YXMgc3VnZ2VzdGluZw0KanVzdCBvbmUgZmlsZS4N
Cg0KPiANCj4+Pj4gRW50cmllcyBpbiB0aGUgZGF0YWJhc2Ugc2hvdWxkIG5ldmVyIGJlIHJlbW92
ZWQsIGV2ZW4gaWYgdGhleSBhcmUgbm90IHVzZWQNCj4+Pj4gYW55bW9yZSBpbiB0aGUgY29kZSAo
aWYgYSBwYXRjaCBpcyByZW1vdmluZyBvciBtb2RpZnlpbmcgdGhlIGZhdWx0eSBsaW5lKS4NCj4+
Pj4gVGhpcyBpcyB0byBtYWtlIHN1cmUgdGhhdCBudW1iZXJzIGFyZSBub3QgcmV1c2VkIHdoaWNo
IGNvdWxkIGxlYWQgdG8gY29uZmxpY3RzDQo+Pj4+IHdpdGggb2xkIGJyYW5jaGVzIG9yIG1pc2xl
YWRpbmcganVzdGlmaWNhdGlvbnMuDQo+Pj4gDQo+Pj4gQ2FuIHdlIGFkZCBwcm92aXNpb25zIGZv
ciBzaHJpbmtpbmcgc3VjaCBlbnRyaWVzIHRvIGUuZy4ganVzdCB0aGVpciAiaWQiDQo+Pj4gbGlu
ZT8gT3IgaXMgdGhlIGludGVudGlvbiB0byBiZSBhYmxlIHRvIHJlLXVzZSBzdWNoIGFuIGVudHJ5
IGlmIGEgbWF0Y2hpbmcNCj4+PiBpbnN0YW5jZSBhcHBlYXJzIGFnYWluIGxhdGVyPw0KPj4gDQo+
PiBJIHByZWZlciB0byBkb27igJl0IHNocmluayBpdCwgdGhlIG5hbWUgaXRzZWxmIGlzIG5vdCB2
ZXJ5IGxvbmcsIGV2ZW4gdXNpbmcgbWFueSBkaWdpdHMgb2YgdGhlIGluY3JlbWVudGFsDQo+PiBu
dW1iZXIsIGl0IHJlbW92ZXMgYWxzbyB0aGUgZGVwZW5kZW5jeSBvbiB0aGUgZmlsZSBuYW1lLg0K
PiANCj4gTmFtZSBsZW5ndGggaXNuJ3QgcmVsZXZhbnQgaGVyZSwgYW5kIEkgaGF2ZSBubyBpZGVh
IHdoYXQgZGVwZW5kZW5jeSBvbiBhDQo+IGZpbGUgbmFtZSB5b3UncmUgdGhpbmtpbmcgb2YuIE15
IHF1ZXN0aW9uIGlzIGEgc2NhbGFiaWxpdHkgb25lOiBPdmVyIHRpbWUNCj4gdGhlIHRhYmxlIHdp
bGwgZ3JvdyBsYXJnZS4gSWYgYWxsIGVudHJpZXMgcmVtYWluIHRoZXJlIGluIGZ1bGwgZm9yZXZl
ciwNCj4gdGFibGUgc2l6ZSBtYXkgYmVjb21lIHVud2llbGR5Lg0KDQpPayBJIG1pc3VuZGVyc3Rv
b2QgeW91ciBxdWVzdGlvbiwgbm93IEkgdW5kZXJzdGFuZCB3aGF0IHlvdSBhcmUgYXNraW5nLCB3
ZSBjb3VsZCByZW1vdmUgdGhlIGNvbnRlbnQNCm9mIHRoZSDigJxhbmFseXNlcuKAnSBkaWN0aW9u
YXJ5IGZvciBzdXJlLCBiZWNhdXNlIGlmIHRoZXJlIGlzIG5vdCBhbnltb3JlIGEgbGluayB3aXRo
IHRoZSBjdXJyZW50IGNvZGUuDQoNClJlZ2FyZGluZyByZW1vdmluZyB0aGUg4oCcbmFtZeKAnSBh
bmQg4oCcdGV4dOKAnSwgY291bGQgaXQgYmUgdGhhdCBhdCBzb21lIHBvaW50IHdlIGNhbiBpbnRy
b2R1Y2UgaW4gdGhlIGNvZGUNCmEgdmlvbGF0aW9uIHRoYXQgcmVxdWlyZXMgdGhlIHNhbWUganVz
dGlmaWNhdGlvbiBwcm92aWRlZCBieSB0aGUg4oCcb3JwaGFu4oCdIGVudHJ5Pw0KSW4gdGhhdCBj
YXNlIHdlIGNvdWxkIHJldXNlIHRoYXQgZW50cnkgd2l0aG91dCBjcmVhdGluZyBhIG5ldyBvbmUg
dGhhdCB3aWxsIG9ubHkgd2FzdGUgc3BhY2UuDQpXaGF0IGlzIHRoZSBvcGluaW9uIG9uIHRoaXM/
DQoNCj4gDQo+Pj4gVGFraW5nIHRoaXMgZXhhbXBsZSBJIGFsc28gZGFyZSB0byBhc2s6IFNob3Vs
ZG4ndCB0b29scyBiZSBhd2FyZSB0aGF0DQo+Pj4gdG9rZW4gY29uY2F0ZW5hdGlvbiBuZWNlc3Nh
cmlseSBtZWFucyBubyB1c2Ugb2YgcGFyZW50aGVzZXM/IFNlZSBhbHNvDQo+Pj4gYmVsb3cuDQo+
PiANCj4+IFllcyB0aGUgdG9vbCBzaG91bGQgYmUgYXdhcmUsIGluIHRoZSBleGFtcGxlIGJlbG93
LCB0aGUgdG9vbCBpcyBjb21wbGFpbmluZyBqdXN0DQo+PiBmb3IgdGhlIGxpbmVzIDc1IGFuZCA4
MCwgaW4gdGhhdCBwYXJ0aWN1bGFyIGV4YW1wbGUgSSB3b3VsZCBoYXZlIGZpeGVkIHRoZSBmaW5k
aW5nDQo+PiBpbnN0ZWFkIG9mIHVzaW5nIGEganVzdGlmaWNhdGlvbiwgYnV0IEnigJl2ZSByZXBv
cnRlZCB0aGF0IGV4YW1wbGUganVzdCB0byBzaG93IGhvdw0KPj4gdGhlIGZpbmRpbmcgY2FuIGJl
IHN1cHByZXNzZWQuDQo+PiANCj4+IEhlcmUgdGhlIGxpbmsgdG8gZWNsYWlyOiBodHRwczovL2Vj
bGFpcml0LmNvbTozNzg3L2ZzL3Zhci9saWIvamVua2lucy9qb2JzL1hFTi9jb25maWd1cmF0aW9u
cy9heGlzLVRhcmdldC9BUk02NC9heGlzLWFnZW50L3B1YmxpYy9idWlsZHMvNTQxL2FyY2hpdmUv
RUNMQUlSL291dC9QUk9KRUNULmVjZDsvc291cmNlcy94ZW4vaW5jbHVkZS94ZW4vcGFyYW0uaC5o
dG1sI0w3NV92aW9sYXRpb24NCj4+IA0KPj4gVGhlIGNvZGluZyBzdGFuZGFyZCB3YW50cyBqdXN0
IHRvIGhhdmUgdGhpczoNCj4+IA0KPj4gI2RlZmluZSBzdHJpbmdfcGFyYW0oX25hbWUsIF92YXIp
IFwNCj4+IF9fc2V0dXBfc3RyIF9fc2V0dXBfc3RyXyMjX3ZhcltdID0gKF9uYW1lKTsgXA0KPj4g
X19rcGFyYW0gX19zZXR1cF8jI192YXIgPSBcDQo+PiAgICAgeyAubmFtZSA9IF9fc2V0dXBfc3Ry
XyMjX3ZhciwgXA0KPj4gICAgICAgLnR5cGUgPSBPUFRfU1RSLCBcDQo+PiAgICAgICAubGVuID0g
c2l6ZW9mKF92YXIpLCBcDQo+PiAgICAgICAucGFyLnZhciA9ICYoX3ZhcikgfQ0KPiANCj4gTWF5
IEkgc3VnZ2VzdCB0aGF0IHlvdSBwaWNrIGEgcmVhbCBleGFtcGxlIHRoZW4gcmF0aGVyIHRoYW4g
b25lIHdoZXJlIHdlDQo+IGFjdHVhbGx5IHdhbnQgdG8gZml4IHRoZSBjb2RlPyBQZW9wbGUgbWF5
IGRlcml2ZSBtb3JlIHRoYW4ganVzdCB0aGUNCj4gaW50ZW5kZWQgaW5mb3JtYXRpb24gZnJvbSBh
bnkgZXhhbXBsZXMgZ2l2ZW4gaGVyZS4NCg0KWWVzLCBsZXTigJlzIHRha2UgYSB2aW9sYXRpb24g
b2YgdGhlIFJ1bGUgOC42Og0KDQpFY2xhaXIgcmVwb3J0cyBpdCBoZXJlOg0KaHR0cHM6Ly9lY2xh
aXJpdC5jb206Mzc4Ny9mcy92YXIvbGliL2plbmtpbnMvam9icy9YRU4vY29uZmlndXJhdGlvbnMv
YXhpcy1UYXJnZXQvQVJNNjQvYXhpcy1hZ2VudC9wdWJsaWMvYnVpbGRzLzU0OS9hcmNoaXZlL0VD
TEFJUi9vdXQvUFJPSkVDVC5lY2Q7L3NvdXJjZXMveGVuL2luY2x1ZGUveGVuL2tlcm5lbC5oLmh0
bWwjUjUwNzQzXzENCg0KQWxzbyBjb3Zlcml0eSByZXBvcnRzIGl0LCBoZXJlIGFuIGV4dHJhY3Qg
b2YgdGhlIGZpbmRpbmc6DQoNCnhlbi9pbmNsdWRlL3hlbi9rZXJuZWwuaDo2ODoNCiAgMS4gbWlz
cmFfY18yMDEyX3J1bGVfOF82X3Zpb2xhdGlvbjogRnVuY3Rpb24gIl9zdGFydCIgaXMgZGVjbGFy
ZWQgYnV0IG5ldmVyIGRlZmluZWQuDQoNClRoZSBhbmFseXNlcnMgYXJlIGNvbXBsYWluaW5nIGJl
Y2F1c2Ugd2UgaGF2ZSB0aGlzIGluIHhlbi9pbmNsdWRlL3hlbi9rZXJuZWwuaCBhdCBsaW5lIDY4
Og0KDQpleHRlcm4gY2hhciBfc3RhcnRbXSwgX2VuZFtdLCBzdGFydFtdOw0KDQpUaG9zZSBhcmUg
c3ltYm9scyBleHBvcnRlZCBieSB0aGUgbGlua2VyLCBoZW5jZSB3ZSB3aWxsIG5lZWQgdG8gaGF2
ZSBhIHByb3BlciBkZXZpYXRpb24gZm9yIHRoaXMgZmluZGluZy4NCg0KV2Ugd2lsbCBwcmVwYXJl
IG91ciBlbnRyeSBpbiB0aGUgZGF0YWJhc2U6DQoNCnx7DQp8ICAgICJ2ZXJzaW9uIjogIjEuMCIs
DQp8ICAgICJjb250ZW50IjogWw0KfCAgICAgICAgew0KfCAgICAgICAgW+KApl0NCnwgICAgICAg
IH0sDQp8ICAgICAgICB7DQp8ICAgICAgICAgICAgImlkIjrigJ1TQUYtMS1zYWZlIiwNCnwgICAg
ICAgICAgICAiYW5hbHlzZXIiOiB7DQp8ICAgICAgICAgICAgICAgIOKAnGVjbGFpciI6ICJNQzNS
MS5SOC42IiwNCnwgICAgICAgICAgICAgICAgImNvdmVyaXR5IjogIm1pc3JhX2NfMjAxMl9ydWxl
XzhfNl92aW9sYXRpb24iDQp8ICAgICAgICAgICAgfSwNCnwgICAgICAgICAgICAibmFtZSI6IOKA
nFJ1bGUgOC42OiBsaW5rZXIgZGVmaW5lZCBzeW1ib2xzIiwNCnwgICAgICAgICAgICAidGV4dCI6
IOKAnEl0IGlzIHNhZmUgdG8gZGVjbGFyZSB0aGlzIHN5bWJvbCBiZWNhdXNlIGl0IGlzIGRlZmlu
ZWQgaW4gdGhlIGxpbmtlciBzY3JpcHQuIg0KfCAgICAgICAgfSwNCnwgICAgICAgIHsNCnwgICAg
ICAgICAgICAiaWQiOuKAnVNBRi0yLXNhZmUiLA0KfCAgICAgICAgICAgICJhbmFseXNlciI6IHt9
LA0KfCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCnwgICAgICAgICAgICAidGV4dCI6
ICIiDQp8ICAgICAgICB9DQp8ICAgIF0NCnx9DQoNCkFuZCB3ZSB3aWxsIHVzZSB0aGUgcHJvcGVy
IHRhZyBhYm92ZSB0aGUgdmlvbGF0aW9uIGxpbmU6DQoNCi8qIFNBRi0xLXNhZmUgW29wdGlvbmFs
IHRleHRdICovDQpleHRlcm4gY2hhciBfc3RhcnRbXSwgX2VuZFtdLCBzdGFydFtdOw0KDQpUaGlz
IGVudHJ5IHdpbGwgZml4IGFsc28gdGhlIHZpb2xhdGlvbiBvbiBfZW5kIGFuZCBzdGFydCwgYmVj
YXVzZSB0aGV5IGFyZSBvbiB0aGUgc2FtZSBsaW5lIGFuZCB0aGUNCnNhbWUg4oCcdmlvbGF0aW9u
IElE4oCdLg0KDQpBbHNvLCB0aGUgc2FtZSB0YWcgY2FuIGJlIHVzZWQgb24gb3RoZXIgc3ltYm9s
cyBmcm9tIHRoZSBsaW5rZXIgdGhhdCBhcmUgZGVjbGFyZWQgaW4gdGhlIGNvZGViYXNlLA0KYmVj
YXVzZSB0aGUganVzdGlmaWNhdGlvbiBob2xkcyBmb3IgdGhlbSB0b28uDQoNCj4gDQo+Pj4+IEhl
cmUgYSBicmllZiBleHBsYW5hdGlvbiBvZiB0aGUgZmllbGQgaW5zaWRlIGFuIG9iamVjdCBvZiB0
aGUgImNvbnRlbnQiIGFycmF5Og0KPj4+PiAtIGlkOiBpdCBpcyBhIHVuaXF1ZSBzdHJpbmcgdGhh
dCBpcyB1c2VkIHRvIHJlZmVyIHRvIHRoZSBmaW5kaW5nLCBtYW55IGZpbmRpbmcNCj4+Pj4gY2Fu
IGJlIHRhZ2dlZCB3aXRoIHRoZSBzYW1lIGlkLCBpZiB0aGUganVzdGlmaWNhdGlvbiBob2xkcyBm
b3IgYW55IGFwcGxpZWQNCj4+Pj4gY2FzZS4NCj4+Pj4gSXQgdGVsbHMgdGhlIHRvb2wgdG8gc3Vi
c3RpdHV0ZSBhIFhlbiBpbi1jb2RlIGNvbW1lbnQgaGF2aW5nIHRoaXMgc3RydWN0dXJlOg0KPj4+
PiAvKiBTQUYtMC1zYWZlIFsuLi5dIFwqLw0KPj4+PiAtIGFuYWx5c2VyOiBpdCBpcyBhbiBvYmpl
Y3QgY29udGFpbmluZyBwYWlyIG9mIGtleS12YWx1ZSBzdHJpbmdzLCB0aGUga2V5IGlzDQo+Pj4+
IHRoZSBhbmFseXNlciwgc28gaXQgY2FuIGJlIGNwcGNoZWNrLCBjb3Zlcml0eSBvciBlY2xhaXIu
IFRoZSB2YWx1ZSBpcyB0aGUNCj4+Pj4gcHJvcHJpZXRhcnkgaWQgY29ycmVzcG9uZGluZyBvbiB0
aGUgZmluZGluZywgZm9yIGV4YW1wbGUgd2hlbiBjb3Zlcml0eSBpcw0KPj4+PiB1c2VkIGFzIGFu
YWx5c2VyLCB0aGUgdG9vbCB3aWxsIHRyYW5zbGF0ZSB0aGUgWGVuIGluLWNvZGUgY29tZW50IGlu
IHRoaXMgd2F5Og0KPj4+PiAvKiBTQUYtMC1zYWZlIFsuLi5dIFwqLyAtPiAvKiBjb3Zlcml0eVtj
b3Zlcml0eS1pZF0gXCovDQo+Pj4gDQo+Pj4gSW4gaGVyZSwgd2hlcmUgd291bGQgY292ZXJpdHkt
aWQgY29tZSBmcm9tPyBBbmQgaG93IGRvZXMgdGhlIHRyYW5zZm9ybWF0aW9uDQo+Pj4gaGVyZSBt
YXRjaCB1cCB3aXRoIHRoZSB2YWx1ZSBvZiB0aGUgImNvdmVyaXR5IjogZmllbGQgaW4gdGhlIHRh
YmxlPw0KPj4gDQo+PiBJIGNhbiBwdXQgYW4gZXhhbXBsZSBvZiB0aGF0LCBhcyB5b3UgcG9pbnRl
ZCBvdXQgaXQgY291bGQgYmUgZGlmZmljdWx0IHRvIGdldCB3aGVyZQ0KPj4gdGhpcyBwcm9wcmll
dGFyeSB0b29sIElEIGNvbWVzIGZyb20uDQo+PiANCj4+IFRoZSBwcm9wcmlldGFyeSBJRCAoQ292
ZXJpdHkgaW4gdGhpcyBjYXNlKSBjb21lcyBmcm9tIHRoZSByZXBvcnQgaXQgcHJvZHVjZXM6DQo+
PiANCj4+IFvigKZdDQo+PiA8ZmlsZSBwYXRoPjo8bGluZSBudW1iZXI+Og0KPj4gIDEuIHByb3By
aWV0YXJ5X0lEOiBb4oCmXQ0KPj4gW+KApl0NCj4+IA0KPj4gYWZ0ZXIgd2Ugc2VlIHRoZSBmaW5k
aW5nLCB3ZSB0YWtlIHRoYXQgSUQsIHdlIHB1dCBpdCBpbiB0aGUg4oCcYW5hbHlzZXLigJ0gZGlj
dGlvbmFyeSBhczoNCj4+IA0KPj4gW+KApl0NCj4+ICJpZCI64oCdU0FGLTItc2FmZSIsDQo+PiDi
gJxhbmFseXNlcuKAnTogew0KPj4gCeKAnGNvdmVyaXR54oCdOiDigJxwcm9wcmlldGFyeV9JRCIN
Cj4+IH0sDQo+PiBb4oCmXQ0KPj4gDQo+PiBTbyBpbiB0aGUgc291cmNlIGNvZGUgd2Ugd2lsbCBo
YXZlOg0KPj4gDQo+PiAvKiBTQUYtMi1zYWZlIFtvcHRpb25hbCB0ZXh0XSAqLw0KPj4gQyBjb2Rl
IGFmZmVjdGVkIGxpbmU7DQo+PiANCj4+IEFuZCB3aGVuIHRoZSBhbmFseXNpcyB3aWxsIGJlIHBl
cmZvcm1lZCwgdGhlIHRvb2wgKGNvdmVyaXR5IGZvciBleGFtcGxlKSB3aWxsIHJ1biBvbiB0aGlz
IHNvdXJjZSBjb2RlOg0KPj4gDQo+PiAvKiBjb3Zlcml0eVtwcm9wcmlldGFyeV9JRF0gKi8NCj4+
IEMgY29kZSBhZmZlY3RlZCBsaW5lOw0KPj4gDQo+PiBUaGUgdG9vbCB3aWxsIHdyaXRlIGEgcmVw
b3J0IGFuZCB3aWxsIHN1cHByZXNzIHRoZSBmaW5kaW5nIHdpdGgg4oCccHJvcHJpZXRhcnlfSUTi
gJ0gdGhhdCBjb21lcyBpbiB0aGUgQyBjb2RlDQo+PiBsaW5lIGFmdGVyIHRoZSBjb21tZW50Lg0K
PiANCj4gTGV0IG1lIGFkZCBzb21lIGJhY2tncm91bmQgdG8gbXkgZWFybGllciBjb21tZW50Og0K
PiANCj4gSWYgd2Ugd2FudGVkIHRvIGFkZCBzdWNoIElEcyB0byB0aGUgdGFibGUsIHRoZW4gSSBn
dWVzcyB0aGlzIHdvdWxkIHJlc3VsdCBpbg0KPiBhIHByb2xpZmVyYXRpb24gb2YgZW50cmllcy4g
SWYgbXkgb2JzZXJ2YXRpb25zIGhhdmVuJ3QgbWlzZ3VpZGVkIG1lLA0KPiBDb3Zlcml0eSBtaWdo
dCByZS11c2UgdGhlIHNhbWUgSUQgZm9yIG11bHRpcGxlIHNpbWlsYXIgbmV3IGlzc3VlcyBmb3Vu
ZCBpbiBhDQo+IHNpbmdsZSBydW4sIGJ1dCBpdCB3b3VsZCBub3QgcmUtdXNlIHRoZW0gYWNyb3Nz
IHJ1bnMuIEhlbmNlIGlycmVzcGVjdGl2ZSBvZg0KPiB0aGVpciBzaW1pbGFyaXR5LCBtdWx0aXBs
ZSB0YWJsZSBlbnRyaWVzIHdvdWxkIGJlIG5lZWRlZCBqdXN0IGJlY2F1c2Ugb2YgdGhlDQo+IGRp
ZmZlcmVudCBDb3Zlcml0eSBJRHMuDQoNCkNvdmVyaXR5IHdpbGwgdXNlIGV2ZXJ5IHJ1biB0aGUg
c2FtZSBpZCBmb3IgdGhlIHNhbWUgY2xhc3Mgb2YgdmlvbGF0aW9uLCBmb3IgZXhhbXBsZQ0KbWlz
cmFfY18yMDEyX3J1bGVfOF82X3Zpb2xhdGlvbiBmb3IgdmlvbGF0aW9uIG9mIHJ1bGUgOC42Lg0K
DQo+IA0KPj4gQWZ0ZXIgdGhlIGFuYWx5c2lzLCB0aGUgc291cmNlIGNvZGUgd2lsbCByZXR1cm4g
YXMgdGhlIG9yaWdpbmFsICh3aXRoIHRoZSBTQUYtKiB0YWcpLg0KPiANCj4gV2hpbGUgeW91IG1l
bnRpb24gc29tZXRoaW5nIHNpbWlsYXIgYWxzbyBhcyBzdGVwIDMgaW4gdGhlIG9yaWdpbmFsIGRv
Y3VtZW50DQo+IG5lYXIgdGhlIHRvcCwgSSdtIGFmcmFpZCBJIGRvbid0IHVuZGVyc3RhbmQgd2hh
dCB0aGlzICJyZXR1cm4gYXMgdGhlIG9yaWdpbmFsIg0KPiBtZWFucy4gSWYgeW91IHdhbnQgdG8g
cnVuIHRoZSB0b29sIG9uIGFuIGFsdGVyZWQgKGNvbW1lbnRzIG1vZGlmaWVkKSBzb3VyY2UNCj4g
dHJlZSwgd2hhdCBJJ2QgZXhwZWN0IHlvdSB0byBkbyBpcyBjbG9uZSB0aGUgc291cmNlcyBpbnRv
IGEgdGhyb3ctYXdheSB0cmVlLA0KPiBtYXNzYWdlIHRoZSBjb21tZW50cywgcnVuIHRoZSB0b29s
LCBhbmQgZGVsZXRlIHRoZSBtYXNzYWdlZCB0cmVlLg0KPj4+PiBpZiB0aGUgb2JqZWN0IGRvZXNu
J3QgaGF2ZSBhIGtleS12YWx1ZSwgdGhlbiB0aGUgY29ycmVzcG9uZGluZyBpbi1jb2RlDQo+Pj4+
IGNvbW1lbnQgd29uJ3QgYmUgdHJhbnNsYXRlZC4NCj4+PiANCj4+PiBJaXJjIGF0IGxlYXN0IENv
dmVyaXR5IGlnbm9yZXMgY2VydGFpbiBpbnN0YW5jZXMgb2Ygd2hhdCBpdCBtaWdodCBjb25zaWRl
cg0KPj4+IHZpb2xhdGlvbnMgKGZhbGwtdGhyb3VnaCBpbiBzd2l0Y2goKSBzdGF0ZW1lbnRzIGlu
IHBhcnRpY3VsYXIpIGluIGNhc2UNCj4+PiBfYW55XyBjb21tZW50IGlzIHByZXNlbnQuIFRoZXJl
Zm9yZSBtYXkgSSBzdWdnZXN0IHRoYXQgc3VjaCBjb21tZW50cyBiZQ0KPj4+IGRlbGV0ZWQgKHJl
YWxseTogcmVwbGFjZWQgYnkgYSBibGFuayBsaW5lLCB0byBtYWludGFpbiBjb3JyZWN0IGxpbmUN
Cj4+PiBudW1iZXJpbmcpIGlmIHRoZXJlJ3Mgbm8gbWF0Y2hpbmcga2V5LXZhbHVlIHBhaXI/DQo+
PiANCj4+IFllcyB0aGUgbGluZSB3b27igJl0IGJlIGFsdGVyZWQgaWYgdGhlcmUgaXMgbm8gbWF0
Y2guIFRoaXMgdG8gZW5zdXJlIHRoZSBjb3JyZWN0IGxpbmUNCj4+IG51bWJlcmluZyBpcyBub3Qg
YWZmZWN0ZWQuDQo+IA0KPiAid29uJ3QgYmUgYWx0ZXJlZCIgaXMgdGhlIG9wcG9zaXRlIG9mIHdo
YXQgSSd2ZSBiZWVuIGFza2luZyB0byBjb25zaWRlcjoNCj4gT2JzZXJ2aW5nIHRoYXQgY29tbWVu
dHMgX3JlZ2FyZGxlc3NfIG9mIHRoZWlyIGNvbnRlbnRzIG1heSBzaWxlbmNlIGZpbmRpbmdzLA0K
PiB0aGUgc3VnZ2VzdGlvbiBpcyB0byByZW1vdmUgY29tbWVudHMgKGxlYXZpbmcgYSBibGFuayBs
aW5lKSB3aGVuIHRoZXJlJ3Mgbm8NCj4gZW50cnkgZm9yIHRoZSB0YXJnZXRlZCB0b29sIGluIHRo
ZSB0YWJsZSBlbnRyeS4NCg0KV2h5PyBUaGUgdGFnIGNvbW1lbnQgd29u4oCZdCBkbyBhbnl0aGlu
ZywgaXQgd291bGQgYWN0IGFzIGEgYmxhbmsgbGluZSBmcm9tIHRoZSBhbmFseXNlcg0KcGVyc3Bl
Y3RpdmUuDQoNCj4gDQo+Pj4+IC0gbmFtZTogYSBzaW1wbGUgbmFtZSBmb3IgdGhlIGZpbmRpbmcN
Cj4+Pj4gLSB0ZXh0OiBhIHByb3BlciBqdXN0aWZpY2F0aW9uIHRvIHR1cm4gb2ZmIHRoZSBmaW5k
aW5nLg0KPj4+IA0KPj4+IFRoZSBkaXN0aW5jdGlvbiBiZXR3ZWVuIHRoZSBsYXN0IHR3byBkb2Vz
bid0IHJlYWxseSBiZWNvbWUgY2xlYXIuIFRha2luZw0KPj4+IHlvdXIg4oCcVmFyaWFibGUgc2V0
IGJ1dCBub3QgdXNlZCIgZXhhbXBsZSBhYm92ZTogU3VjaCBhICJuYW1lIiB3aWxsIGZpdA0KPj4+
IG1hbnkgY2FzZXMsIHlldCB0aGUganVzdGlmaWNhdGlvbiBmb3IgZWFjaCBtaWdodCBiZSBkaWZm
ZXJlbnQuIEhlbmNlDQo+Pj4gdGhlIHF1ZXN0aW9uIGlzIGhvdyB1bmlxdWUgIm5hbWUiIHNob3Vs
ZCBiZSBhbmQgLSBpZiBpdCBkb2Vzbid0IG5lZWQgdG8NCj4+PiBiZSB1bmlxdWUgLSB3aGF0IGlu
Zm9ybWF0aW9uIGl0IGlzIGludGVuZGVkIHRvIGNvbnZleS4NCj4+IA0KPj4gTmFtZSBpcyBub3Qg
ZW5mb3JjZWQgdG8gYmUgdW5pcXVlLCBpdOKAmXMgY29udmVuaWVudCB0byBnZXQgYSBzdWJqZWN0
IGZvciB0aGUgcGFydGljdWxhciBqdXN0aWZpY2F0aW9uLg0KPj4gSWYgdGhlIG5hbWUgb2YgdHdv
IGp1c3RpZmljYXRpb24gaXMgdGhlIHNhbWUsIGJ1dCB0aGUganVzdGlmaWNhdGlvbiBpcyBkaWZm
ZXJlbnQsIHRoZW4gaXQgd29u4oCZdCByZXF1aXJlDQo+PiBtdWNoIGVmZm9ydCB0byB3cml0ZSBh
IGRpZmZlcmVudCBuYW1lIHRvIHF1aWNrbHkgcmVjYWxsIGFuZCBkaWZmZXJlbnRpYXRlIHRoZSBv
bmUgZnJvbSB0aGUgb3RoZXIuDQo+PiANCj4+IEhvd2V2ZXIgaWYgbm8gb25lIGZpbmRzIHRoZSDi
gJxuYW1l4oCdIGZpZWxkIG5lY2Vzc2FyeSwgd2UgY2FuIHJlbW92ZSBpdC4gSXQgd2FzIGludHJv
ZHVjZWQgaGF2aW5nDQo+PiBJbiBtaW5kIHRoYXQgYXQgc29tZSBwb2ludCBhIGRvY3VtZW50IHdp
bGwgYmUgY3JlYXRlZCB3aXRoIGFsbCB0aGUganVzdGlmaWNhdGlvbnMgdG9nZXRoZXIuDQo+PiAN
Cj4+IElmIG90aGVycyBhcmUgYWdhaW5zdCBpdCBqdXN0IHJlcGx5IHRvIHRoYXQuDQo+IA0KPiBJ
IGNhbid0IHNheSB3aGV0aGVyIEknbSBwcm8gb3IgY29uIGFzIGxvbmcgYXMgaXQncyBub3QgcmVh
bGx5IGNsZWFyIHdoYXQNCj4gaW5mb3JtYXRpb24gaXMgdG8gYmUgY29udmV5ZWQgYnkgYm90aC4g
SWYgIm5hbWUiIGlzIHNvbWV3aGF0IGxpa2UgdGhlDQo+IHN1YmplY3Qgb2YgYW4gZW1haWwgYW5k
IGlkZW50aWNhbCBuYW1lcyBhcmUgZGVlbWVkIGZpbmUsIHRoZW4gc28gYmUgaXQuDQo+IFF1ZXN0
aW9uIHRob3VnaCBpcyB3aGV0aGVyIGhhdmluZyBwZXJoYXBzIGRvemVucyAob3IgaHVuZHJlZHMp
IG9mDQo+IGlkZW50aWNhbGx5IG5hbWVkIGVudHJpZXMgaXMgdmVyeSB1c2VmdWwuDQoNCk9rLCBs
ZXTigJlzIHdhaXQgZm9yIG1vcmUgZmVlZGJhY2tzIG9uIHRoaXMuDQoNCj4gDQo+Pj4+IEhlcmUg
YW4gZXhhbXBsZSBvZiB0aGUgdXNhZ2Ugb2YgdGhlIGluLWNvZGUgY29tbWVudCB0YWdzOg0KPj4+
PiANCj4+Pj4gLyogU0FGLTAtc2FmZSBbZXZlbnR1YWwgZGV2ZWxvcGVyIG1lc3NhZ2UgdGhhdCBz
aGFsbCBub3QgZXhjZWVkcyBsaW5lIGNoYXIgbWF4IGNvdW50LCBkb27igJl0IGJyZWFrIHRoZSBs
aW5lIV0gKi8NCj4+Pj4gI2RlZmluZSBzdHJpbmdfcGFyYW0oX25hbWUsIF92YXIpIFwNCj4+Pj4g
ICBfX3NldHVwX3N0ciBfX3NldHVwX3N0cl8jI192YXJbXSA9IF9uYW1lOyBcDQo+Pj4+ICAgX19r
cGFyYW0gX19zZXR1cF8jI192YXIgPSBcDQo+Pj4+ICAgICAgIHsgLm5hbWUgPSBfX3NldHVwX3N0
cl8jI192YXIsIFwNCj4+Pj4gICAgICAgICAudHlwZSA9IE9QVF9TVFIsIFwNCj4+Pj4gICAgICAg
ICAubGVuID0gc2l6ZW9mKF92YXIpLCBcDQo+Pj4+ICAgICAgICAgLnBhci52YXIgPSAmX3ZhciB9
DQo+Pj4+IA0KPj4+PiBJbiB0aGUgZXhhbXBsZSBhYm92ZSwgdGhlIHRvb2wgZmluZGluZyBmb3Ig
dGhpcyBtYWNybyBpcyBzdXBwcmVzc2VkLiBXaGVuIHRoZXJlIGFyZSBtdWx0aXBsZSBmaW5kaW5n
cyBmb3INCj4+Pj4gdGhlIHNhbWUgbGluZSwgbXVsdGlwbGUgaW4tY29kZSBjb21tZW50cyBuZWVk
cyB0byBiZSBpbnNlcnRlZCwgZXZlcnkgb25lIG9uIGEgZGlmZmVyZW50IGxpbmUuDQo+Pj4gDQo+
Pj4gU2luY2UgdGhpcyBpcyBhYm91dCBwYXJlbnRoZXNpemF0aW9uLCB3b3VsZA0KPj4+IA0KPj4+
ICNkZWZpbmUgc3RyaW5nX3BhcmFtKF9uYW1lLCBfdmFyKSBcDQo+Pj4gICBfX3NldHVwX3N0ciAo
X19zZXR1cF9zdHJfIyNfdmFyKVtdID0gX25hbWU7IFwNCj4+PiAgIF9fa3BhcmFtIChfX3NldHVw
XyMjX3ZhcikgPSBcDQo+Pj4gICAgICAgeyAubmFtZSA9IChfX3NldHVwX3N0cl8jI192YXIpLCBc
DQo+Pj4gICAgICAgICAudHlwZSA9IE9QVF9TVFIsIFwNCj4+PiAgICAgICAgIC5sZW4gPSBzaXpl
b2YoX3ZhciksIFwNCj4+PiAgICAgICAgIC5wYXIudmFyID0gJihfdmFyKSB9DQo+Pj4gDQo+Pj4g
c2F0aXNmeSB0aGUgdG9vbHM/IEFuZCB3b3VsZG4ndCB3ZSBiZXR0ZXIgbm90IG1hc2sgZGV0ZWN0
aW9uIG9uIHRoaXMNCj4+PiBjb25zdHJ1Y3QgYW55d2F5LCBzaW5jZSB0aGUgbGFzdCBvZiB0aGUg
dXNlcyBvZiAiX3ZhciIgaW5kZWVkIGRvZXMNCj4+PiB2aW9sYXRlIHRoZSBydWxlICh3aXRob3V0
IHBhcmVudGhlc2VzIGFkZGVkKT8NCj4+IA0KPj4gWWVzIHRoaXMgd2FzIGp1c3QgYW4gZXhhbXBs
ZSBvZiBob3cgdG8gc3VwcHJlc3MgYSBmaW5kaW5nLCBpbiB0aGlzIHBhcnRpY3VsYXINCj4+IGNh
c2UsIEkgd291bGQgaGF2ZSBmaXhlZCB0aGUgZXJyb3IgaW5zdGVhZCBvZiBzdXBwcmVzc2luZyBp
dC4NCj4+IFRoZSBjaGFuZ2VzIHRvIGZpeCB0aGUgZmluZGluZyBpcyBhYm92ZS4NCj4+IA0KPj4+
IA0KPj4+IEFzIHRvIHRoZSBwbGFjZW1lbnQgb2YgdGhlIGxhYmVsOiBJdCB3YXMgcmVwZWF0ZWRs
eSBzYWlkIHRoYXQgYW5hbHlzaXMNCj4+PiBvY2N1cnMgb24gcHJlLXByb2Nlc3NlZCBzb3VyY2Vz
LiBJcyBwbGFjaW5nIGEgbGFiZWwgYWhlYWQgb2YgYSBtYWNybw0KPj4+IGRlZmluaXRpb24gdGhl
cmVmb3JlIGdvaW5nIHRvIGhhdmUgYW55IGVmZmVjdCBhdCBhbGw/IFdvdWxkbid0IHRoZSB0aGlu
Zw0KPj4+IHJhdGhlciBuZWVkIHRvIGxvb2sgbGlrZSB0aGlzIChhc3N1bWluZyBhIHByZS1wcm9j
ZXNzaW5nIG1vZGUgaXMgdXNlZA0KPj4+IHdoaWNoIHJldGFpbnMgY29tbWVudHMgYW5kIHJlc3Bl
Y3RzIGxpbmUgc3BsaXRzIGRlc3BpdGUgdGhlIHVzZSBvZiBsaW5lDQo+Pj4gY29udGludWF0aW9u
cyBpbiB0aGUgbWFjcm8gZGVmaW5pdGlvbik6DQo+Pj4gDQo+Pj4gI2RlZmluZSBzdHJpbmdfcGFy
YW0oX25hbWUsIF92YXIpIFwNCj4+PiAgIC8qIFNBRi0wLXNhZmUgLi4uICovIFwNCj4+PiAgIF9f
c2V0dXBfc3RyIF9fc2V0dXBfc3RyXyMjX3ZhcltdID0gX25hbWU7IFwNCj4+PiAgIC8qIFNBRi0w
LXNhZmUgLi4uICovIFwNCj4+PiAgIF9fa3BhcmFtIF9fc2V0dXBfIyNfdmFyID0gXA0KPj4+ICAg
ICAgIC8qIFNBRi0wLXNhZmUgLi4uICovIFwNCj4+PiAgICAgICB7IC5uYW1lID0gX19zZXR1cF9z
dHJfIyNfdmFyLCBcDQo+Pj4gICAgICAgICAudHlwZSA9IE9QVF9TVFIsIFwNCj4+PiAgICAgICAg
IC5sZW4gPSBzaXplb2YoX3ZhciksIFwNCj4+PiAgICAgICAgIC5wYXIudmFyID0gJihfdmFyKSB9
DQo+PiANCj4+IEZyb20gdGhlIGV4cGVyaWVuY2Ugb24gY3BwY2hlY2sgYW5kIGNvdmVyaXR5LCBp
dCBpcyBlbm91Z2ggdG8gcGxhY2UgdGhlDQo+PiBJbi1jb2RlIGNvbW1lbnQgYWJvdmUgdGhlIGZp
cnN0IGxpbmUgb2YgdGhlIG1hY3JvIHRvIHN1cHByZXNzIHRoZSBmaW5kaW5nLg0KPiANCj4gSW50
ZXJlc3RpbmcuIEhvdyBpcyB0aGUgY29tbWVudCB0aGVuIHByb3BhZ2F0ZWQgdG8gYWxsIGV4cGFu
c2lvbnMgb2YgdGhlDQo+IG1hY3JvIChpbiB0aGUgY291cnNlIG9mIHByZS1wcm9jZXNzaW5nKT8N
Cg0KSeKAmW0gYWZyYWlkIHRoYXQgSSBkb27igJl0IGhhdmUgdGhlIGV4YWN0IGFuc3dlciBhcyBp
dCBpcyBpbnRlcm5hbCB0byBldmVyeSB0b29sIEkgZ3Vlc3MuDQpBbGwgSSBrbm93IGlzIGZyb20g
YSB1c2VyIHBlcnNwZWN0aXZlLg0KDQpDaGVlcnMsDQpMdWNhDQoNCj4gDQo+IEphbg0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 15:29:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 15:29:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425281.673000 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoXR-0007J3-OJ; Tue, 18 Oct 2022 15:29:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425281.673000; Tue, 18 Oct 2022 15:29:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoXR-0007Iw-Lg; Tue, 18 Oct 2022 15:29:53 +0000
Received: by outflank-mailman (input) for mailman id 425281;
 Tue, 18 Oct 2022 15:29:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okoXQ-0007Iq-3R
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 15:29:52 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4b9b0ad-4ef9-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 17:29:50 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9632.eurprd04.prod.outlook.com (2603:10a6:20b:477::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct
 2022 15:29:49 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 15:29:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4b9b0ad-4ef9-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M9qQkJe2UIwQ/KegLOe2+GahhLNfvqrLNboAieSRjdtsAMjZJRPg+jwvJndpkP+zJ97QSfniriCs/FcqkGc8qgqEb6uI4aXDV1dFVuJo+OQlzU5/GABWlTkSTsl+Gk6AL5rsTAf/gAC+aGx8UTFfGnleJh6c3KxXFaUkM+3Y1n3PQ8zqNwWYwl03HawglxDHtqJ6MtGKPhGl0C1/5+JK5XobyOZgNpbW/+RkYy7bbmoY82I74gi2MHuXzZpuYtZzpUbXxQg25hMyk7c47DTfRYbuQ6ItqKxs5W4eJOGZxFyM9FAlSydDRIvGlCfgsvLPryGA5G5bUU746MROgTHplQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fE68tToyp7Mszp30JJOgnvGyztmkwmTz2hlbTeYo8iY=;
 b=LZQ2YmPnNsXFo0qi4yKNcXjencw2al1miJ8XU6wewrIwZv3PFpvbv8mvcOc8GHqQAcewHNHCOiX7ngTMkCVlGCM6RvQXtoGTKKAZ0Rcl0sJ3XLDwJ5W05ADdzEy9jVTTCA85KEv8Nl4guLEUpFXqT1H9jLSYJTRB6AxcApo1HWSSAcZAfPgLzXx0Ggzxq4W5lIRUEIXW5U0OHE/2whSJu2rfO6PvQDeubulgtqRaieEAwwruKYNOSv7zqckEVlz5/9ZFi4ldr13nMwNkRgRkOJ7s81yPdQEtKynHkrlVw7YUn25gCpc7jhANJQucNA4BGbyYZqY53zszC1aJVuQ48A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fE68tToyp7Mszp30JJOgnvGyztmkwmTz2hlbTeYo8iY=;
 b=XT7W0PNyBt5g2RwwNsgL7COoI5FjBr7Hx72TcKeI0VlzK680n/DUkhGLF12QVL+kRC8GbAq2Y6P0VVbvtRES1oe7OAOkz1VVY9VdzE+HLYVlmewyiXTx3tOIwrAT2XXEQkB52UE5zqORrHKnTVPRE693AVSZOx2nzf8u0ukh5QSyI0qNjpq/CQ5WExCnLQJalTEdJS9GH7RGCUGO40A7PSfGJe3y6iowqU+OYJuUdQm/81UH/uVrbiaw/bq9V7jtBZDLz8MjiSTl3IUY33K1SK0aVMyX+gKn7TRFOaAs8/F/ZU03QomEJNHhf9zEMQZzvS10f0FNQdEkOmrL1TgJBA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
Date: Tue, 18 Oct 2022 17:29:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Proposal for deviations in static analyser findings
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::9) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9632:EE_
X-MS-Office365-Filtering-Correlation-Id: c194b288-857f-4191-2cee-08dab11d97f1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6dauYnTJiTyQyaispNQZkN+ukdpis94yhieAsRFl1bXGhK94LJ238OqspYcBeg6a5VHjs2vXOSPdw3mA373BBhzk0g6QzXgNwlLqscZHEIM7ZrRUz1qtOL07DlK+PaaDbBA3aouShULMKHsmBy5e0GWOqul/Wa7kO0pm0cb/UHDQvOwQSzDR19yw2porrrZuC8uWhGWqq16suq6sGbe8Qf7HVuXMxFshHaPu0nqRit8yK0X4rIITaAhz5qXNudq4F1aX7DnXKHEAcc8dy07s5TpAecGPnvt1FSAj60f7EmOpInwWD8PlRHq8Q5w2kTYJMjNlO6eo0dhsAriJ+RDYULjWLAijwRSPVU1cMe6io6RctaBGJgMD2uAtUM1dP/daosD8L71r7p0RWy3zcZwc7wBTcFJ8PO85ePdGcaf97uyrmo90x0AbxkgtR/RgYxf3YqEq/3NeT9iiyNWNolTR+Mc/Qgf7jiEF3VeJ/QlYVNkHiRWRDNuadD3msYliJy5L2dqW/JLaCoejDYu0CpjNNtacQbfTzAQi2b/m1O4GFe7dkgzMSh3t9gok/qO029/2sjfQuKL6DFH48TQt94Ok3YtcuEHXHqaLD3r/KE67lv3SHiruWYtNNMxBbrO3ehL+cCK0PlUeNB4VV9pqWXumCeJlr511qfiu+f43tY2yDVATBohGnzSxJXIZcDyNF3NzT/nhVobhwm3CH+W9Zq64rAArG3DRMjTSGK1QU3ELxFxxYZgbJFoKvi2nRpKYlUz1swsjrD/ALkRDe8kLjDACwiK5QtDrsGi3qcnSWz1p11A=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199015)(5660300002)(8936002)(2906002)(66476007)(8676002)(4326008)(38100700002)(66556008)(41300700001)(36756003)(31696002)(86362001)(6512007)(26005)(6506007)(53546011)(2616005)(6916009)(186003)(54906003)(6486002)(478600001)(66946007)(316002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3BOUGxyMmx4WGJzb1pWUE12T1RpNHNRbk5XQVcyaERvelVJV21INTBGSGVq?=
 =?utf-8?B?MDNDSnR1UGozclZBRGMrNlJHUlJVY0grQVdiZitOVGsvTFNmOFB3V0dGa0dm?=
 =?utf-8?B?REpsU2ExSmxMdmEwZE56c2tyY09sRmJCbUQ3L2xGT1pWQUdKc01sZTBCcFpm?=
 =?utf-8?B?a1BvZDZBNzQvRDNOc1Vpc0lkUHU0Ky90WHBiOE9NNyttWjRjeWhxeFppNWR0?=
 =?utf-8?B?czNTMHFWSjc3WHYzd09SRkljOTY4aU9NMVplcmcwTnNPUTlibkZKNzFHVWdI?=
 =?utf-8?B?bFlVT1F1Nng4TnFGZTdPMWIwV1BWbkd4dzJqS3p1MUtxbGJaSkUyRVU0U09E?=
 =?utf-8?B?bklGV2NQMjRzbXB3aGcrZWZDMStUazZpT3hNeCtIUUttR1I4RnRTYlA3SGFT?=
 =?utf-8?B?Mzczb251US9nNDdSUG5MaHY4OXlPQXpHQmVTQlhJOVdyR0c3UHp0cGpQNHJo?=
 =?utf-8?B?a1pwL3RWbnBoL2ZHNWhYY3B3eUMvOHBSK2NkZGE3TDBMOC8vN2xWZlRtU0lp?=
 =?utf-8?B?QkNMcGkrSmphYXdTS3lUdjFydXZTTEk1c2Q1ZnVSdlY2NW4ya2wwaXl6Wmtu?=
 =?utf-8?B?V1VZQzk3RGx1cWFKSnFIL1MxZ3VpRWJMM2lxdnZnMUQzdHIxZEVWdnc2RWJz?=
 =?utf-8?B?SU1GeTk0eW1vaWFaZUVSL1Zmai96NVZiNEpWTUhKbjhjcmJCb2t3Q0RnZUd2?=
 =?utf-8?B?UlFId0JzMGZ5elVCWDRZRURVZzluQ2M3R1BaZWtQc2MwQ1N3cTBUUTRVNEZn?=
 =?utf-8?B?RGhFNWFWN3hqa0NEbDEyNnI5eTczbGY1UmFCQWdsc1luVURyOVdFMUFlRnIz?=
 =?utf-8?B?TGViRlhmOGZqL0E5OEVLY2YrTitQcHBOZDEzdGhtd1BpRzZUSWUxajZVNEJ2?=
 =?utf-8?B?SGVqcEE3NUxRZkhKQUM5eTZGVXJGc3ZBSVhMeVZiUWZvQ1hqd3dicDVKcjk3?=
 =?utf-8?B?NjRrRzBuS2hSbm53MUJCRnhIL0k2MGNKdU1hNi9odmkvT01ueGdFWGQ3ZHVp?=
 =?utf-8?B?Slk3SVoxYVRXRWNjb0FpWERJbFZNVkVVaUlWaDdCdWI0NzVHczBWcXlSdmVB?=
 =?utf-8?B?N0YyUmNxOGRxZ0hkWVVVSXF0dWtDYmsrM2lkZTBlYW9OQzdqUUphc3RuRkVJ?=
 =?utf-8?B?YjVhTm16YUllRi81T0xhWGxBeWZWZG9vcjhKMFljaFBYeXdhSlZhS202YWZx?=
 =?utf-8?B?SlV6dXl2R0s3bU15WlBEQ3d2bHQ0TG9sOEdGc213Mm9PVHBwMXovYXFKODNU?=
 =?utf-8?B?Y1orUWZkT1BqYmdaakFjbU56TnNmbjJxT3JSeFUxK3hNZXFTT29GcnZNMXBD?=
 =?utf-8?B?azlRTjRZNEdwUEhyTDR5aFJ6R09ub1ZNQURxZEdESHRCTnNSNzV6T1YydGdw?=
 =?utf-8?B?VnNLUWVQbkswRmVnbXpTMXJvRDBSUGV6R21WY2NGS0U5SzF5Y3ZDQTFmM3do?=
 =?utf-8?B?cFpaWVFZQzB6dXFFTERkaVVjbmhhSXlGMjg5ekRqK0ZEOXZYVEg1R20wVmhY?=
 =?utf-8?B?WGZsbmN2UURrVncxRFZTWkRCQUphN2RXdGcwa1Bnak1HTG9EdmZndDRaQTZi?=
 =?utf-8?B?OTVuajB4UkJUdDcwOVhRR0ZzKzVMVWpmSkpqakFpSHJhdzhLTmwxTDNSTHpX?=
 =?utf-8?B?RXJ1LzBpcGU3ek1kMmhEU0QvM09rVHVpWEx0RWN3eVFaN2oyaGZXQWN6dGlF?=
 =?utf-8?B?bC9MdU1BRU9CbWl0Qk4xa0xyZ2tRc01QMDNkUXk1WFYvRm8zWDRYaHpmdU5r?=
 =?utf-8?B?dDVkQUhZUU10akh4L2FtUHRrcEJOTmFEaVZRVktaaGt4czkxUVBaeDFOVHRK?=
 =?utf-8?B?eVdOTGlnM1VOWHhCRktmUUdGSFcybnVxTFNaSmh0d0pUTUFEdDB3Z3ZEdWU1?=
 =?utf-8?B?MlREdTF3ZmlKRm54TzVZRnc2RElDVTFJaDgyL3VFa3ZTS2RYRHhQRXdVR3Jk?=
 =?utf-8?B?Q3dtWmU0QmJ2Zmp5SktIdy9VN2hKWFBFUEVENmpnVnFvTFgxQzMySVFKeng2?=
 =?utf-8?B?WlZvK0F0NDB0a3dmbzI4RS9ZL3VRTm1nZWFWNXRjaWZ0T3pvbTJ0ZUxRZkZ0?=
 =?utf-8?B?Y0duWEpuNzYxUjRxV2h0Q3VpbDFKdlV0R29reEh1RXNUdzFralJId0dLQU50?=
 =?utf-8?Q?04Zb6riDix4xLLr7O4dDkkYlk?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c194b288-857f-4191-2cee-08dab11d97f1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:29:48.9085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gExaNIzYQdZ4FF643mMfIjEvLKuslRbmne60VF9+Bt0F59yBgqFR9zYoCYxuszaH96eeSHJ00cioNrFY6OvPNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9632

On 18.10.2022 17:17, Luca Fancellu wrote:
>> On 13 Oct 2022, at 12:34, Jan Beulich <jbeulich@suse.com> wrote:
>> On 13.10.2022 12:11, Luca Fancellu wrote:
>>>> On 13 Oct 2022, at 08:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 12.10.2022 18:00, Luca Fancellu wrote:
>>>>> Entries in the database should never be removed, even if they are not used
>>>>> anymore in the code (if a patch is removing or modifying the faulty line).
>>>>> This is to make sure that numbers are not reused which could lead to conflicts
>>>>> with old branches or misleading justifications.
>>>>
>>>> Can we add provisions for shrinking such entries to e.g. just their "id"
>>>> line? Or is the intention to be able to re-use such an entry if a matching
>>>> instance appears again later?
>>>
>>> I prefer to don’t shrink it, the name itself is not very long, even using many digits of the incremental
>>> number, it removes also the dependency on the file name.
>>
>> Name length isn't relevant here, and I have no idea what dependency on a
>> file name you're thinking of. My question is a scalability one: Over time
>> the table will grow large. If all entries remain there in full forever,
>> table size may become unwieldy.
> 
> Ok I misunderstood your question, now I understand what you are asking, we could remove the content
> of the “analyser” dictionary for sure, because if there is not anymore a link with the current code.
> 
> Regarding removing the “name” and “text”, could it be that at some point we can introduce in the code
> a violation that requires the same justification provided by the “orphan” entry?
> In that case we could reuse that entry without creating a new one that will only waste space.
> What is the opinion on this?

Well, yes, this is the one case that I, too, was wondering about. It's not
clear to me whether it wouldn't be better to allocate a fresh ID in such a
case.

>>>>> Here a brief explanation of the field inside an object of the "content" array:
>>>>> - id: it is a unique string that is used to refer to the finding, many finding
>>>>> can be tagged with the same id, if the justification holds for any applied
>>>>> case.
>>>>> It tells the tool to substitute a Xen in-code comment having this structure:
>>>>> /* SAF-0-safe [...] \*/
>>>>> - analyser: it is an object containing pair of key-value strings, the key is
>>>>> the analyser, so it can be cppcheck, coverity or eclair. The value is the
>>>>> proprietary id corresponding on the finding, for example when coverity is
>>>>> used as analyser, the tool will translate the Xen in-code coment in this way:
>>>>> /* SAF-0-safe [...] \*/ -> /* coverity[coverity-id] \*/
>>>>
>>>> In here, where would coverity-id come from? And how does the transformation
>>>> here match up with the value of the "coverity": field in the table?
>>>
>>> I can put an example of that, as you pointed out it could be difficult to get where
>>> this proprietary tool ID comes from.
>>>
>>> The proprietary ID (Coverity in this case) comes from the report it produces:
>>>
>>> […]
>>> <file path>:<line number>:
>>>  1. proprietary_ID: […]
>>> […]
>>>
>>> after we see the finding, we take that ID, we put it in the “analyser” dictionary as:
>>>
>>> […]
>>> "id":”SAF-2-safe",
>>> “analyser”: {
>>> 	“coverity”: “proprietary_ID"
>>> },
>>> […]
>>>
>>> So in the source code we will have:
>>>
>>> /* SAF-2-safe [optional text] */
>>> C code affected line;
>>>
>>> And when the analysis will be performed, the tool (coverity for example) will run on this source code:
>>>
>>> /* coverity[proprietary_ID] */
>>> C code affected line;
>>>
>>> The tool will write a report and will suppress the finding with “proprietary_ID” that comes in the C code
>>> line after the comment.
>>
>> Let me add some background to my earlier comment:
>>
>> If we wanted to add such IDs to the table, then I guess this would result in
>> a proliferation of entries. If my observations haven't misguided me,
>> Coverity might re-use the same ID for multiple similar new issues found in a
>> single run, but it would not re-use them across runs. Hence irrespective of
>> their similarity, multiple table entries would be needed just because of the
>> different Coverity IDs.
> 
> Coverity will use every run the same id for the same class of violation, for example
> misra_c_2012_rule_8_6_violation for violation of rule 8.6.

Hmm, I've never seen such. I always saw it use numeric IDs, and we've
actually been putting these in commits when addressing their findings.

>>> After the analysis, the source code will return as the original (with the SAF-* tag).
>>
>> While you mention something similar also as step 3 in the original document
>> near the top, I'm afraid I don't understand what this "return as the original"
>> means. If you want to run the tool on an altered (comments modified) source
>> tree, what I'd expect you to do is clone the sources into a throw-away tree,
>> massage the comments, run the tool, and delete the massaged tree.
>>>>> if the object doesn't have a key-value, then the corresponding in-code
>>>>> comment won't be translated.
>>>>
>>>> Iirc at least Coverity ignores certain instances of what it might consider
>>>> violations (fall-through in switch() statements in particular) in case
>>>> _any_ comment is present. Therefore may I suggest that such comments be
>>>> deleted (really: replaced by a blank line, to maintain correct line
>>>> numbering) if there's no matching key-value pair?
>>>
>>> Yes the line won’t be altered if there is no match. This to ensure the correct line
>>> numbering is not affected.
>>
>> "won't be altered" is the opposite of what I've been asking to consider:
>> Observing that comments _regardless_ of their contents may silence findings,
>> the suggestion is to remove comments (leaving a blank line) when there's no
>> entry for the targeted tool in the table entry.
> 
> Why? The tag comment won’t do anything, it would act as a blank line from the analyser
> perspective.

The _tag_ won't do anything, but as said any _comment_ may have an effect.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 15:50:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 15:50:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425292.673011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okor6-0002IW-Dn; Tue, 18 Oct 2022 15:50:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425292.673011; Tue, 18 Oct 2022 15:50:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okor6-0002IP-Ap; Tue, 18 Oct 2022 15:50:12 +0000
Received: by outflank-mailman (input) for mailman id 425292;
 Tue, 18 Oct 2022 15:50:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=opEU=2T=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1okor4-0002IJ-Lp
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 15:50:10 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2064.outbound.protection.outlook.com [40.107.21.64])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8a1c375a-4efc-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 17:50:07 +0200 (CEST)
Received: from AS9PR04CA0045.eurprd04.prod.outlook.com (2603:10a6:20b:46a::15)
 by AS2PR08MB10252.eurprd08.prod.outlook.com (2603:10a6:20b:648::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 15:50:06 +0000
Received: from AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46a:cafe::7) by AS9PR04CA0045.outlook.office365.com
 (2603:10a6:20b:46a::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Tue, 18 Oct 2022 15:50:06 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT035.mail.protection.outlook.com (100.127.141.24) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 18 Oct 2022 15:50:05 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Tue, 18 Oct 2022 15:50:05 +0000
Received: from 8b9259c5e38a.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0161C0DD-4DB6-49E1-96A0-C755D4F87060.1; 
 Tue, 18 Oct 2022 15:49:54 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b9259c5e38a.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 15:49:54 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by GV1PR08MB8306.eurprd08.prod.outlook.com (2603:10a6:150:a3::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct
 2022 15:49:51 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 15:49:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a1c375a-4efc-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Tp5WWOqgyIt0ou1FRI/J5O9+azC1Zey2K7voGUOVaFdGBiC6NoMJNFN55Yuy+QCQNplhoP/LiUr5lyimX7TjBCRMssgt07EA/aYbysv3M2NwJM631QoTuDHRX0faiqKpXQu8XDRIwcMmBuoqRq/MvGvsJswQ4uAJI2owfCwHJJweJGRmD5L7AYPuCMr1JdEv+x9VifeXycI00XD1hHzLUtocq26w06gy8KgCKQrVApLlRBheUejlX8Txw3Fp6QdgBOam6MUqmDCyrkvYxCEBxkl1wQDcmkUof8Y9WB22VLbH8GrHOiYmU5lb0JVzO63gFQh5Bkn+3XTE7kMczroKVA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/JK6iBwdWgdNikg4jzo96cher+aqzD3zrjGnzg1PmSk=;
 b=ThrkU0HNmcnGeFgTabUbEkvWXsgQZgmArOyQCJqcf+vIU4O9FPR9zxH0zG+XQ9xpD2K47qA71UJFPx+RZHcJ3nuiHCIXv0Sbs7/+uU/gSO7CjTH8bH9eiUC8wE4jmvLusqYjt+w5kSymWrDJp3O+FEFj3eZ/noEYbRNxt7aRdqPf/reV5IroxsIPCIp/EmImkvUvwQ2tDR3bub9RAdPrzCZKtLXbwgPKEMdJ8uRF5H2Uf6TrVgNrcFYIUteV04RrBbIEe4gICGMOOLOKxK3nb3R58ksw6QWVrhj6xewIyOFckxF/VCDlsWUbq/UeEwe9Z7StvwhGtZJU6CTl8lsjug==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/JK6iBwdWgdNikg4jzo96cher+aqzD3zrjGnzg1PmSk=;
 b=YIZVaMgCNt1Qyyt5PgzKsWqJ0K0eU8vbrbOQSQ7mKqLesD4wA+RatHJNnVDtwHu7RmdDQ/NHk2h0R9OxRHci39C/9W1PIRxyX42uB1w3WZSUOKTnuZPq4c2S3YiKJ1koe+pypfV9BCW2/QSvXYRPNrhvM6S80X59a802JCs7pcQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 118b8a194568899c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QocmTyuVeCVYFhfJCB7pK9JhcK/CyFBcc8A3orqxUvc0G5+DHKc7atARVYMXv1+lgknKeoece1Ro2JtZwIsFcMpeaDrijUz5plJoL1QLDuB/VyRzFyfTMuuqS892O+PvUFp9K7xX+33UHyhh3CHCQvrqT4e6mqff1sjFCcZJg2kJgyhiA68eji3XYtHq9TRhwLunjh1xeYDLSpKJhP9Bc4gBv1EyrRDXrRkTzSiEWmSCNfPS+a1UicVi5hQ4dM+00hwQNka2T3t0T42T8Hzv4uOpiXEmLg7CndYvZoORXHN9yo0xaIWXJIjnuWoBeZPFKmMRunPDHzl0oc45waftSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/JK6iBwdWgdNikg4jzo96cher+aqzD3zrjGnzg1PmSk=;
 b=NFM8uX6nPNKNbhVc2w3Nji9kr64RX9bhgpjm2GRo18IZQyxUtHf0Bd0YZGUPlY4bbORkT/+MHUfhSB6Q/w0J0XNssibxgnUwOgfvsa8T7wB7nzw8EkCIVAwyeZ0QP2Z+Np2Jo6AQ0T8tGO8bQw0OvxlQ+M0YC3AhYUJxkAwesMK3BQ7kBkFbibkGIeNBhDBaqgusyeInjWZmpM053GD38HK4BySCtlJGcJvIL615lLOwaXgK9sxIxPjZMcXvJ+EjoF0amBPcC354/rRK/d8zB72Rcdj5RYlB0W7k+/Fpw061GxV3K+fsq6lKbdbOfxHxYMO8YKJqrYxnaRVOIZQCiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/JK6iBwdWgdNikg4jzo96cher+aqzD3zrjGnzg1PmSk=;
 b=YIZVaMgCNt1Qyyt5PgzKsWqJ0K0eU8vbrbOQSQ7mKqLesD4wA+RatHJNnVDtwHu7RmdDQ/NHk2h0R9OxRHci39C/9W1PIRxyX42uB1w3WZSUOKTnuZPq4c2S3YiKJ1koe+pypfV9BCW2/QSvXYRPNrhvM6S80X59a802JCs7pcQ=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index:
 AQHY3lPHTZwvWtdyCU+0K6Hw9nMyM64L9DeAgAAneoCAABdHAIAIGdUAgAADdICAAAWaAA==
Date: Tue, 18 Oct 2022 15:49:50 +0000
Message-ID: <F95C1103-8CDB-4CC3-BCB5-45254DBB286E@arm.com>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
In-Reply-To: <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|GV1PR08MB8306:EE_|AM7EUR03FT035:EE_|AS2PR08MB10252:EE_
X-MS-Office365-Filtering-Correlation-Id: bfbc3178-3b64-4a21-a624-08dab1206d63
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ymjDBCkFlpNS1lTkMhZAIkM+QaBy88OrEjFEnY0MDT6pt4o4MX7xyjy8d9eXIR+AAhZaBXyUbevButBTJe2VD+NOJO7TnoaMsyx57XsblAbBXXauS/1daiCxp/9GJR/KukEFa2eb6JGbD5wsPx3eTI6rpUmsb88fWduMJ9IFTaudzPJI2PNMEalO8b+bJ/oX87ZVEKAFGIKWm7jGLyaiCx40q4z73y6kPyjt3fG8aav2TRKM6cNK13BM6sNm9Xu/7U6RLPsNIoFekOc3Xx51Mn4T+T6ODqbaHFPrrjZa74lq/JSbH3drqo1Wvul2eM/f5GBKzyBVFEIvxE26kfAGyBXSOsdojbNn8Qn1ILIgW2fMYsCAbYEhgr7ldor5pSGAm+Ci4lI/e/7B/39E4qFGGiaXi1y51w0BqZun2EbrheIqvQMFOLKA3yT00mgDRJq/rfVWW+HH5KhQMQxZ4sEhks8LJDeUwcsLXmjIBbHgrUA2pVZN97XIoW/GWIA2NHPwinWtNLBJpBQoXmjuMw7xgw2Kbpl3BuGl9BkEceLlyD4fTSb2la81j8yu+06j5Y4zEi7Hdr51o5GUu+NVMR/qhy0WbGta66eAw4no+gzi8WQeA2f9l3yEdlcgcfaWjixqRKg56qDtYQ3wYyPZf7SrrAvUp7JJM6quTdS/FesxYWymYHHx5SoVJCdKrGC7u9p9mlaJa/2FVx2gWX+DJLNgz2dH4rA7GbO1D0JDduEoV8QfSsrMlsATt1kWmC8kWPUIfcTWw3fhU9IIR26m2mi9HsuEEygqCSLX26lDePOD/K4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(451199015)(38070700005)(122000001)(6486002)(478600001)(71200400001)(38100700002)(33656002)(316002)(2616005)(186003)(66556008)(66476007)(64756008)(8676002)(54906003)(66946007)(6916009)(66446008)(76116006)(91956017)(4326008)(6506007)(36756003)(53546011)(26005)(41300700001)(6512007)(8936002)(86362001)(5660300002)(2906002)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <ECE18CDC7987D64EA9FD6C51DB9F4102@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8306
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	941af9f1-1f8a-470e-01b4-08dab1206456
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uXFgOyGwYpaWzf+BLrgwBz70SUX03eWAMNn9PtDMuX2I8B/i1IORRKnpf67gCWu1G9o3XD3ZnubcdLl9Cn8w55NDjqoqBQNOjauoljqxSb4YAMWIkEj41j/WEs1gJqcQxncmaSALnrzayYXxGad0SRLxzj83LkQBLhaG2DIhDjkB4Br//3wMF8UdBGAeDCf0xzfwHNPny3qA0lpnTqqN+9GxALLmoE6kYLUT3xuAReHh3Z+m9OjDBjYP5k7FSBBhC6ABAN9weJz7dWYY/Xh42lOr2mlHJE9rq3O4opsdmmGI5eXTqPlE1/yxBr0lvY6OUjVqNEuKSXPlFseAHrf/j8zi3ajeGn6Af3gnXCWnANKHMYtRVT4Gjp/JLJybM6wqWPne6aZJjAa157zX3J/wdO0mmm5awU1NyAGTsSC3ZlZ3/od4xzQXkd9dWKm7r/SOEU3YuexJhxLLMZcqKd4ydc3BGVcoucO3DxzCh+PaIXKuUc7jIV0NYxCMbKgJ5qwyRFCOP1ydRId8m6fwaCD7KUqqtAFH7XWCCTwtQMld5nte4t2uqTPq7e/Ny2cB0hrlrGbhrJXGKyzT8PuByWFaC6kt/7Pkr1xu1pHQqR8plYQFhEPyPD1Xsmny1hfGItY7vz7OKvinywxkqMcrK6X1H/TIawBE5+tWWZgtQSMn13ggiAx+RjjMSAoiRE3nAYss5W987bSgf0wPM4iyyNCaPbV2aTnIBzB6t/Rp/O9rb3k/I1AnCa3aiXWxjZ/EptStyHWxJgNfL51xAuDEbp+t7w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(36756003)(47076005)(36860700001)(6862004)(5660300002)(82740400003)(81166007)(336012)(83380400001)(33656002)(86362001)(356005)(8936002)(26005)(6512007)(54906003)(186003)(2616005)(478600001)(40460700003)(6486002)(40480700001)(316002)(82310400005)(70586007)(4326008)(41300700001)(53546011)(70206006)(8676002)(6506007)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:50:05.7882
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bfbc3178-3b64-4a21-a624-08dab1206d63
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10252

DQoNCj4gT24gMTggT2N0IDIwMjIsIGF0IDE2OjI5LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTguMTAuMjAyMiAxNzoxNywgTHVjYSBGYW5jZWxsdSB3
cm90ZToNCj4+PiBPbiAxMyBPY3QgMjAyMiwgYXQgMTI6MzQsIEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gT24gMTMuMTAuMjAyMiAxMjoxMSwgTHVjYSBGYW5jZWxs
dSB3cm90ZToNCj4+Pj4+IE9uIDEzIE9jdCAyMDIyLCBhdCAwODo1MCwgSmFuIEJldWxpY2ggPGpi
ZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+IE9uIDEyLjEwLjIwMjIgMTg6MDAsIEx1Y2Eg
RmFuY2VsbHUgd3JvdGU6DQo+Pj4+Pj4gRW50cmllcyBpbiB0aGUgZGF0YWJhc2Ugc2hvdWxkIG5l
dmVyIGJlIHJlbW92ZWQsIGV2ZW4gaWYgdGhleSBhcmUgbm90IHVzZWQNCj4+Pj4+PiBhbnltb3Jl
IGluIHRoZSBjb2RlIChpZiBhIHBhdGNoIGlzIHJlbW92aW5nIG9yIG1vZGlmeWluZyB0aGUgZmF1
bHR5IGxpbmUpLg0KPj4+Pj4+IFRoaXMgaXMgdG8gbWFrZSBzdXJlIHRoYXQgbnVtYmVycyBhcmUg
bm90IHJldXNlZCB3aGljaCBjb3VsZCBsZWFkIHRvIGNvbmZsaWN0cw0KPj4+Pj4+IHdpdGggb2xk
IGJyYW5jaGVzIG9yIG1pc2xlYWRpbmcganVzdGlmaWNhdGlvbnMuDQo+Pj4+PiANCj4+Pj4+IENh
biB3ZSBhZGQgcHJvdmlzaW9ucyBmb3Igc2hyaW5raW5nIHN1Y2ggZW50cmllcyB0byBlLmcuIGp1
c3QgdGhlaXIgImlkIg0KPj4+Pj4gbGluZT8gT3IgaXMgdGhlIGludGVudGlvbiB0byBiZSBhYmxl
IHRvIHJlLXVzZSBzdWNoIGFuIGVudHJ5IGlmIGEgbWF0Y2hpbmcNCj4+Pj4+IGluc3RhbmNlIGFw
cGVhcnMgYWdhaW4gbGF0ZXI/DQo+Pj4+IA0KPj4+PiBJIHByZWZlciB0byBkb27igJl0IHNocmlu
ayBpdCwgdGhlIG5hbWUgaXRzZWxmIGlzIG5vdCB2ZXJ5IGxvbmcsIGV2ZW4gdXNpbmcgbWFueSBk
aWdpdHMgb2YgdGhlIGluY3JlbWVudGFsDQo+Pj4+IG51bWJlciwgaXQgcmVtb3ZlcyBhbHNvIHRo
ZSBkZXBlbmRlbmN5IG9uIHRoZSBmaWxlIG5hbWUuDQo+Pj4gDQo+Pj4gTmFtZSBsZW5ndGggaXNu
J3QgcmVsZXZhbnQgaGVyZSwgYW5kIEkgaGF2ZSBubyBpZGVhIHdoYXQgZGVwZW5kZW5jeSBvbiBh
DQo+Pj4gZmlsZSBuYW1lIHlvdSdyZSB0aGlua2luZyBvZi4gTXkgcXVlc3Rpb24gaXMgYSBzY2Fs
YWJpbGl0eSBvbmU6IE92ZXIgdGltZQ0KPj4+IHRoZSB0YWJsZSB3aWxsIGdyb3cgbGFyZ2UuIElm
IGFsbCBlbnRyaWVzIHJlbWFpbiB0aGVyZSBpbiBmdWxsIGZvcmV2ZXIsDQo+Pj4gdGFibGUgc2l6
ZSBtYXkgYmVjb21lIHVud2llbGR5Lg0KPj4gDQo+PiBPayBJIG1pc3VuZGVyc3Rvb2QgeW91ciBx
dWVzdGlvbiwgbm93IEkgdW5kZXJzdGFuZCB3aGF0IHlvdSBhcmUgYXNraW5nLCB3ZSBjb3VsZCBy
ZW1vdmUgdGhlIGNvbnRlbnQNCj4+IG9mIHRoZSDigJxhbmFseXNlcuKAnSBkaWN0aW9uYXJ5IGZv
ciBzdXJlLCBiZWNhdXNlIGlmIHRoZXJlIGlzIG5vdCBhbnltb3JlIGEgbGluayB3aXRoIHRoZSBj
dXJyZW50IGNvZGUuDQo+PiANCj4+IFJlZ2FyZGluZyByZW1vdmluZyB0aGUg4oCcbmFtZeKAnSBh
bmQg4oCcdGV4dOKAnSwgY291bGQgaXQgYmUgdGhhdCBhdCBzb21lIHBvaW50IHdlIGNhbiBpbnRy
b2R1Y2UgaW4gdGhlIGNvZGUNCj4+IGEgdmlvbGF0aW9uIHRoYXQgcmVxdWlyZXMgdGhlIHNhbWUg
anVzdGlmaWNhdGlvbiBwcm92aWRlZCBieSB0aGUg4oCcb3JwaGFu4oCdIGVudHJ5Pw0KPj4gSW4g
dGhhdCBjYXNlIHdlIGNvdWxkIHJldXNlIHRoYXQgZW50cnkgd2l0aG91dCBjcmVhdGluZyBhIG5l
dyBvbmUgdGhhdCB3aWxsIG9ubHkgd2FzdGUgc3BhY2UuDQo+PiBXaGF0IGlzIHRoZSBvcGluaW9u
IG9uIHRoaXM/DQo+IA0KPiBXZWxsLCB5ZXMsIHRoaXMgaXMgdGhlIG9uZSBjYXNlIHRoYXQgSSwg
dG9vLCB3YXMgd29uZGVyaW5nIGFib3V0LiBJdCdzIG5vdA0KPiBjbGVhciB0byBtZSB3aGV0aGVy
IGl0IHdvdWxkbid0IGJlIGJldHRlciB0byBhbGxvY2F0ZSBhIGZyZXNoIElEIGluIHN1Y2ggYQ0K
PiBjYXNlLg0KDQpJdOKAmXMgbm90IGNsZWFyIHRvIG1lIHRoZSBvcHBvc2l0ZSwgdGhhdCBpcyB3
aHkgd2Ugd291bGQgYWxsb2NhdGUgYSBmcmVzaCBJRCBpbiB0aGlzIGNhc2UuDQoNCj4gDQo+Pj4+
Pj4gSGVyZSBhIGJyaWVmIGV4cGxhbmF0aW9uIG9mIHRoZSBmaWVsZCBpbnNpZGUgYW4gb2JqZWN0
IG9mIHRoZSAiY29udGVudCIgYXJyYXk6DQo+Pj4+Pj4gLSBpZDogaXQgaXMgYSB1bmlxdWUgc3Ry
aW5nIHRoYXQgaXMgdXNlZCB0byByZWZlciB0byB0aGUgZmluZGluZywgbWFueSBmaW5kaW5nDQo+
Pj4+Pj4gY2FuIGJlIHRhZ2dlZCB3aXRoIHRoZSBzYW1lIGlkLCBpZiB0aGUganVzdGlmaWNhdGlv
biBob2xkcyBmb3IgYW55IGFwcGxpZWQNCj4+Pj4+PiBjYXNlLg0KPj4+Pj4+IEl0IHRlbGxzIHRo
ZSB0b29sIHRvIHN1YnN0aXR1dGUgYSBYZW4gaW4tY29kZSBjb21tZW50IGhhdmluZyB0aGlzIHN0
cnVjdHVyZToNCj4+Pj4+PiAvKiBTQUYtMC1zYWZlIFsuLi5dIFwqLw0KPj4+Pj4+IC0gYW5hbHlz
ZXI6IGl0IGlzIGFuIG9iamVjdCBjb250YWluaW5nIHBhaXIgb2Yga2V5LXZhbHVlIHN0cmluZ3Ms
IHRoZSBrZXkgaXMNCj4+Pj4+PiB0aGUgYW5hbHlzZXIsIHNvIGl0IGNhbiBiZSBjcHBjaGVjaywg
Y292ZXJpdHkgb3IgZWNsYWlyLiBUaGUgdmFsdWUgaXMgdGhlDQo+Pj4+Pj4gcHJvcHJpZXRhcnkg
aWQgY29ycmVzcG9uZGluZyBvbiB0aGUgZmluZGluZywgZm9yIGV4YW1wbGUgd2hlbiBjb3Zlcml0
eSBpcw0KPj4+Pj4+IHVzZWQgYXMgYW5hbHlzZXIsIHRoZSB0b29sIHdpbGwgdHJhbnNsYXRlIHRo
ZSBYZW4gaW4tY29kZSBjb21lbnQgaW4gdGhpcyB3YXk6DQo+Pj4+Pj4gLyogU0FGLTAtc2FmZSBb
Li4uXSBcKi8gLT4gLyogY292ZXJpdHlbY292ZXJpdHktaWRdIFwqLw0KPj4+Pj4gDQo+Pj4+PiBJ
biBoZXJlLCB3aGVyZSB3b3VsZCBjb3Zlcml0eS1pZCBjb21lIGZyb20/IEFuZCBob3cgZG9lcyB0
aGUgdHJhbnNmb3JtYXRpb24NCj4+Pj4+IGhlcmUgbWF0Y2ggdXAgd2l0aCB0aGUgdmFsdWUgb2Yg
dGhlICJjb3Zlcml0eSI6IGZpZWxkIGluIHRoZSB0YWJsZT8NCj4+Pj4gDQo+Pj4+IEkgY2FuIHB1
dCBhbiBleGFtcGxlIG9mIHRoYXQsIGFzIHlvdSBwb2ludGVkIG91dCBpdCBjb3VsZCBiZSBkaWZm
aWN1bHQgdG8gZ2V0IHdoZXJlDQo+Pj4+IHRoaXMgcHJvcHJpZXRhcnkgdG9vbCBJRCBjb21lcyBm
cm9tLg0KPj4+PiANCj4+Pj4gVGhlIHByb3ByaWV0YXJ5IElEIChDb3Zlcml0eSBpbiB0aGlzIGNh
c2UpIGNvbWVzIGZyb20gdGhlIHJlcG9ydCBpdCBwcm9kdWNlczoNCj4+Pj4gDQo+Pj4+IFvigKZd
DQo+Pj4+IDxmaWxlIHBhdGg+OjxsaW5lIG51bWJlcj46DQo+Pj4+IDEuIHByb3ByaWV0YXJ5X0lE
OiBb4oCmXQ0KPj4+PiBb4oCmXQ0KPj4+PiANCj4+Pj4gYWZ0ZXIgd2Ugc2VlIHRoZSBmaW5kaW5n
LCB3ZSB0YWtlIHRoYXQgSUQsIHdlIHB1dCBpdCBpbiB0aGUg4oCcYW5hbHlzZXLigJ0gZGljdGlv
bmFyeSBhczoNCj4+Pj4gDQo+Pj4+IFvigKZdDQo+Pj4+ICJpZCI64oCdU0FGLTItc2FmZSIsDQo+
Pj4+IOKAnGFuYWx5c2Vy4oCdOiB7DQo+Pj4+IAnigJxjb3Zlcml0eeKAnTog4oCccHJvcHJpZXRh
cnlfSUQiDQo+Pj4+IH0sDQo+Pj4+IFvigKZdDQo+Pj4+IA0KPj4+PiBTbyBpbiB0aGUgc291cmNl
IGNvZGUgd2Ugd2lsbCBoYXZlOg0KPj4+PiANCj4+Pj4gLyogU0FGLTItc2FmZSBbb3B0aW9uYWwg
dGV4dF0gKi8NCj4+Pj4gQyBjb2RlIGFmZmVjdGVkIGxpbmU7DQo+Pj4+IA0KPj4+PiBBbmQgd2hl
biB0aGUgYW5hbHlzaXMgd2lsbCBiZSBwZXJmb3JtZWQsIHRoZSB0b29sIChjb3Zlcml0eSBmb3Ig
ZXhhbXBsZSkgd2lsbCBydW4gb24gdGhpcyBzb3VyY2UgY29kZToNCj4+Pj4gDQo+Pj4+IC8qIGNv
dmVyaXR5W3Byb3ByaWV0YXJ5X0lEXSAqLw0KPj4+PiBDIGNvZGUgYWZmZWN0ZWQgbGluZTsNCj4+
Pj4gDQo+Pj4+IFRoZSB0b29sIHdpbGwgd3JpdGUgYSByZXBvcnQgYW5kIHdpbGwgc3VwcHJlc3Mg
dGhlIGZpbmRpbmcgd2l0aCDigJxwcm9wcmlldGFyeV9JROKAnSB0aGF0IGNvbWVzIGluIHRoZSBD
IGNvZGUNCj4+Pj4gbGluZSBhZnRlciB0aGUgY29tbWVudC4NCj4+PiANCj4+PiBMZXQgbWUgYWRk
IHNvbWUgYmFja2dyb3VuZCB0byBteSBlYXJsaWVyIGNvbW1lbnQ6DQo+Pj4gDQo+Pj4gSWYgd2Ug
d2FudGVkIHRvIGFkZCBzdWNoIElEcyB0byB0aGUgdGFibGUsIHRoZW4gSSBndWVzcyB0aGlzIHdv
dWxkIHJlc3VsdCBpbg0KPj4+IGEgcHJvbGlmZXJhdGlvbiBvZiBlbnRyaWVzLiBJZiBteSBvYnNl
cnZhdGlvbnMgaGF2ZW4ndCBtaXNndWlkZWQgbWUsDQo+Pj4gQ292ZXJpdHkgbWlnaHQgcmUtdXNl
IHRoZSBzYW1lIElEIGZvciBtdWx0aXBsZSBzaW1pbGFyIG5ldyBpc3N1ZXMgZm91bmQgaW4gYQ0K
Pj4+IHNpbmdsZSBydW4sIGJ1dCBpdCB3b3VsZCBub3QgcmUtdXNlIHRoZW0gYWNyb3NzIHJ1bnMu
IEhlbmNlIGlycmVzcGVjdGl2ZSBvZg0KPj4+IHRoZWlyIHNpbWlsYXJpdHksIG11bHRpcGxlIHRh
YmxlIGVudHJpZXMgd291bGQgYmUgbmVlZGVkIGp1c3QgYmVjYXVzZSBvZiB0aGUNCj4+PiBkaWZm
ZXJlbnQgQ292ZXJpdHkgSURzLg0KPj4gDQo+PiBDb3Zlcml0eSB3aWxsIHVzZSBldmVyeSBydW4g
dGhlIHNhbWUgaWQgZm9yIHRoZSBzYW1lIGNsYXNzIG9mIHZpb2xhdGlvbiwgZm9yIGV4YW1wbGUN
Cj4+IG1pc3JhX2NfMjAxMl9ydWxlXzhfNl92aW9sYXRpb24gZm9yIHZpb2xhdGlvbiBvZiBydWxl
IDguNi4NCj4gDQo+IEhtbSwgSSd2ZSBuZXZlciBzZWVuIHN1Y2guIEkgYWx3YXlzIHNhdyBpdCB1
c2UgbnVtZXJpYyBJRHMsIGFuZCB3ZSd2ZQ0KPiBhY3R1YWxseSBiZWVuIHB1dHRpbmcgdGhlc2Ug
aW4gY29tbWl0cyB3aGVuIGFkZHJlc3NpbmcgdGhlaXIgZmluZGluZ3MuDQoNCkkgZG9u4oCZdCBr
bm93IGhvdyBkb2VzIGl0IHdvcmsgZm9yIENvdmVyaXR5IFNjYW4sIGJ1dCBpdCBzaG91bGQganVz
dCBydW4gc3RhdGljIGFuYWx5c2lzIG9uIHRoZQ0KY29kZSBhbmQgbm90IE1JU1JBIGNvbXBsaWFu
Y2UuDQpUaGUg4oCcQ292ZXJpdHnigJ0gc3VpdGUgaW5zdGVhZCB1c2UgZml4ZWQgSURzIGZvciBl
dmVyeSBjbGFzcyBvZiB2aW9sYXRpb25zLCBhbHNvIGluIGNhc2Ugb2Ygc3RhdGljDQphbmFseXNp
cywgYW4gZXhhbXBsZSBoZXJlOg0KDQp4ZW4vYXJjaC9hcm0vYXJtNjQvbGliL2JpdG9wcy5jOjEy
NDoNCiAgMS4gc2V0X2J1dF9ub3RfdXNlZDogdmFyaWFibGUgInRtcCIgd2FzIHNldCBidXQgbmV2
ZXIgdXNlZA0KDQo+IA0KPj4+PiBBZnRlciB0aGUgYW5hbHlzaXMsIHRoZSBzb3VyY2UgY29kZSB3
aWxsIHJldHVybiBhcyB0aGUgb3JpZ2luYWwgKHdpdGggdGhlIFNBRi0qIHRhZykuDQo+Pj4gDQo+
Pj4gV2hpbGUgeW91IG1lbnRpb24gc29tZXRoaW5nIHNpbWlsYXIgYWxzbyBhcyBzdGVwIDMgaW4g
dGhlIG9yaWdpbmFsIGRvY3VtZW50DQo+Pj4gbmVhciB0aGUgdG9wLCBJJ20gYWZyYWlkIEkgZG9u
J3QgdW5kZXJzdGFuZCB3aGF0IHRoaXMgInJldHVybiBhcyB0aGUgb3JpZ2luYWwiDQo+Pj4gbWVh
bnMuIElmIHlvdSB3YW50IHRvIHJ1biB0aGUgdG9vbCBvbiBhbiBhbHRlcmVkIChjb21tZW50cyBt
b2RpZmllZCkgc291cmNlDQo+Pj4gdHJlZSwgd2hhdCBJJ2QgZXhwZWN0IHlvdSB0byBkbyBpcyBj
bG9uZSB0aGUgc291cmNlcyBpbnRvIGEgdGhyb3ctYXdheSB0cmVlLA0KPj4+IG1hc3NhZ2UgdGhl
IGNvbW1lbnRzLCBydW4gdGhlIHRvb2wsIGFuZCBkZWxldGUgdGhlIG1hc3NhZ2VkIHRyZWUuDQo+
Pj4+Pj4gaWYgdGhlIG9iamVjdCBkb2Vzbid0IGhhdmUgYSBrZXktdmFsdWUsIHRoZW4gdGhlIGNv
cnJlc3BvbmRpbmcgaW4tY29kZQ0KPj4+Pj4+IGNvbW1lbnQgd29uJ3QgYmUgdHJhbnNsYXRlZC4N
Cj4+Pj4+IA0KPj4+Pj4gSWlyYyBhdCBsZWFzdCBDb3Zlcml0eSBpZ25vcmVzIGNlcnRhaW4gaW5z
dGFuY2VzIG9mIHdoYXQgaXQgbWlnaHQgY29uc2lkZXINCj4+Pj4+IHZpb2xhdGlvbnMgKGZhbGwt
dGhyb3VnaCBpbiBzd2l0Y2goKSBzdGF0ZW1lbnRzIGluIHBhcnRpY3VsYXIpIGluIGNhc2UNCj4+
Pj4+IF9hbnlfIGNvbW1lbnQgaXMgcHJlc2VudC4gVGhlcmVmb3JlIG1heSBJIHN1Z2dlc3QgdGhh
dCBzdWNoIGNvbW1lbnRzIGJlDQo+Pj4+PiBkZWxldGVkIChyZWFsbHk6IHJlcGxhY2VkIGJ5IGEg
YmxhbmsgbGluZSwgdG8gbWFpbnRhaW4gY29ycmVjdCBsaW5lDQo+Pj4+PiBudW1iZXJpbmcpIGlm
IHRoZXJlJ3Mgbm8gbWF0Y2hpbmcga2V5LXZhbHVlIHBhaXI/DQo+Pj4+IA0KPj4+PiBZZXMgdGhl
IGxpbmUgd29u4oCZdCBiZSBhbHRlcmVkIGlmIHRoZXJlIGlzIG5vIG1hdGNoLiBUaGlzIHRvIGVu
c3VyZSB0aGUgY29ycmVjdCBsaW5lDQo+Pj4+IG51bWJlcmluZyBpcyBub3QgYWZmZWN0ZWQuDQo+
Pj4gDQo+Pj4gIndvbid0IGJlIGFsdGVyZWQiIGlzIHRoZSBvcHBvc2l0ZSBvZiB3aGF0IEkndmUg
YmVlbiBhc2tpbmcgdG8gY29uc2lkZXI6DQo+Pj4gT2JzZXJ2aW5nIHRoYXQgY29tbWVudHMgX3Jl
Z2FyZGxlc3NfIG9mIHRoZWlyIGNvbnRlbnRzIG1heSBzaWxlbmNlIGZpbmRpbmdzLA0KPj4+IHRo
ZSBzdWdnZXN0aW9uIGlzIHRvIHJlbW92ZSBjb21tZW50cyAobGVhdmluZyBhIGJsYW5rIGxpbmUp
IHdoZW4gdGhlcmUncyBubw0KPj4+IGVudHJ5IGZvciB0aGUgdGFyZ2V0ZWQgdG9vbCBpbiB0aGUg
dGFibGUgZW50cnkuDQo+PiANCj4+IFdoeT8gVGhlIHRhZyBjb21tZW50IHdvbuKAmXQgZG8gYW55
dGhpbmcsIGl0IHdvdWxkIGFjdCBhcyBhIGJsYW5rIGxpbmUgZnJvbSB0aGUgYW5hbHlzZXINCj4+
IHBlcnNwZWN0aXZlLg0KPiANCj4gVGhlIF90YWdfIHdvbid0IGRvIGFueXRoaW5nLCBidXQgYXMg
c2FpZCBhbnkgX2NvbW1lbnRfIG1heSBoYXZlIGFuIGVmZmVjdC4NCg0KWWVzLCBhbnkgY29tbWVu
dCB0aGF0IGlzIHVzaW5nIGEgcHJvcHJpZXRhcnkgc3ludGF4IGZvciB0aGUgdG9vbHMgd2UgdXNl
Og0KDQovKiBjcHBjaGVjay1zdXBwcmVzc1twcm9wcmlldGFyeV9JRF0gKi8NCi8qIGNvdmVyaXR5
W3Byb3ByaWV0YXJ5X0lEXSAqLw0KLyogLUU+IGhpZGUgcHJvcHJpZXRhcnlfSUQgMSDigJwiICov
DQoNCk1heSBoYXZlIGFuIGVmZmVjdC4NCg0KSWYgYW4gZW50cnkgaW4gdGhlIGRhdGFiYXNlIGhh
cyBubyBtYXRjaCB3aXRoIHRoZSB1c2VkIHRvb2wsIHRoZW4gaXQgd291bGQgc3RheSBhcyAoZm9y
IGV4YW1wbGUpOg0KDQovKiBTQUYtWC1zYWZlIFtibGFibGFibGFdICovDQoNCldoaWNoIGhhcyBu
byBlZmZlY3Qgb24gYW55IHRvb2wsIGhlbmNlIEkgZG9u4oCZdCBzZWUgdGhlIG5lZWRzIHRvIHJl
cGxhY2UgaXQgd2l0aCBhIGJsYW5rIGxpbmUuDQoNCkNoZWVycywNCkx1Y2ENCg0KPiANCj4gSmFu
DQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 15:57:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 15:57:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425299.673021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoy1-000393-9L; Tue, 18 Oct 2022 15:57:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425299.673021; Tue, 18 Oct 2022 15:57:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okoy1-00038w-6i; Tue, 18 Oct 2022 15:57:21 +0000
Received: by outflank-mailman (input) for mailman id 425299;
 Tue, 18 Oct 2022 15:57:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+2Ad=2T=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1okoy0-00038q-Td
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 15:57:20 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8baa5ad2-4efd-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 17:57:20 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB8235.eurprd04.prod.outlook.com (2603:10a6:10:243::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct
 2022 15:57:17 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 15:57:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8baa5ad2-4efd-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SYd4GC5CrXyBB8HosyBzneKFaMoIMaYqwg2fkL7hYsS5AAByDXSL0DmeCK2weHP9S9Ta8U5AkdkaFZU07XNwXWdcR/feZcKJgJgXutdD3y1+sixyB2DsWrTmqCi8fdDb9AZRdUfBNH7M6Mdm8mivsGMIzpvDtfqZEFW1S0aej09zk0GqTDRm5VSMe7cVkgYCe1FuqZKZKdmXHm2Oz/at2i3wH/IguQj6dfS0VfPJTgMqdWygcMMAjtMAwNbgKMEYnP65xDHFGCPrThl8/P2+Wyj+ngG5rRq32nTrUlqryBaNvWu5c65D0FTH3XxOrppb2G29EWHii1reWpmKZjwIsA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hG2br83tQxUeM0V05Wnkau+jniQ3+X83HQp6p918x84=;
 b=dCvPrsdK8kDtTGx3Q8EwNPc5Xo1GcpE3zjyfHoyWhXROpfEnl8chL4Y5+FuXXelJGhesB6YbMtxNCXRKBDTyCdYhW3ePiZjwY2c8o2xTJNjVu2omU+YIk2z1kZN4Y2rwj6HBCYbyFOvxJ3cDpyijxmeD31ajETlkJ2fyuq9pvpT8lMb9QXKvFkyk4uZ+4pHkOjWQeMnUKY+9zzR1yvhUP8Vv//556e6V1VR/OOJtVzkj5kaMoEA7EUB5HClvu1Jk3DPraXOhh1g63f6GG/eZtm94N9EU1qDgluGVfAUv6c9xG3Dnfb4rchNvY0J7qBKLJasyJzuEbLXZ6HgziazKYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hG2br83tQxUeM0V05Wnkau+jniQ3+X83HQp6p918x84=;
 b=LpfaYXmzG5AX3zT9efhkQOIEryJuyt+GFJwQquSsLEQ6z42WtWtTbr+IDOXkbUnzJGSPvQCEaKAlMtKidA3t+lpW2SGiAbEiWVN7pfcDdJbgzevbFD4Bx0P84ZDwlr8v+XIF5uj0QV5HtK9yfdBuS9uXR5XKdn7tO/Px8yLCFd11tda2Rrsxcd/gfaNzTfyQV63sAusad4+xDy6VjKxcK6/koluJMcprjKVbXcv8IQ+mOrLhk6o0ioiiW367ii9xL4B8yWwZxtKk86j48RZiIBZoEyRkKIE4d5k5c8De1FM5uXSmylRlVUkRI4wYDAwSgfYWjOv4Og8VfIFFtNRPwQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d1345f8e-b51a-9104-4063-8dfbd5edffe9@suse.com>
Date: Tue, 18 Oct 2022 17:57:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Proposal for deviations in static analyser findings
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
 <F95C1103-8CDB-4CC3-BCB5-45254DBB286E@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <F95C1103-8CDB-4CC3-BCB5-45254DBB286E@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8235:EE_
X-MS-Office365-Filtering-Correlation-Id: 0cff2c43-88a0-4c97-ce61-08dab1216e2e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xGKsFpDs3LLcZL89OZZI8b9qDnuz/FR3gB+zDqHXhxbVo+Akyi3EFrFb69XslbninVvE11yxafcIVtAiGyvnjzF9SFD3fdZcTf/b1ya3meF665leZbFzBt32+2V9Le5+JXq1WXLJpkL9vTwydGPLOnyYIiHdu+dy0kk57f6z54rNnv4nJibSccPrGGd1l+N04ANbR+kp7xrEvLIVUGC/33Eo3sEgYxbgb2iqMtMaJr68/PYkDXwxyp+Zd+rmNrfMFKUijcFvpm5zxu2VLWDQrtH1SSjnaOsVGYEGKQrYdEaFnmzYY7RZQp6HsAFwMJWgP/DLycZ/cd8n8KtP7t4nIjCBNPwW1gAUAYRkLlxs6QwAw4vSivsgKfqJza1dFS5d3gsG+lZINk+G1ODUJJs4rZfCNDjYoGRo57Iywm2UqSyDuPYvLF3lVwYeRAzd280v7MPST2rVD5fwoCs/DY6XUmXYV1A1DCnvPC3ysPn4oWM7pDAqvsFlzkDgtZ83w75eBytdD1th3/Y/7OuQrfHBAZ0/U9R9j6VJDrOMNxfMCv8VNtU1l8dc8LeiFerE1ZgA1/4owsWhEfyLGA1mZYR2XzOg0IzVU7WTn/PY9OjMOq5eprROtT22+lT0xjqlM/2Dp4BiySzm1eAFdscPXzr42+E+ltRV7dfolRgy9DhJvWHbG2lgeBVnssdXEzaC/I6zPZ5oZFVbrGm8v0/AsLkJ184etOEw0XwVDjoyh6yB4YdRjqGeTafrgDWLt/zHme6B1Of2PMfmrSnGG83FnUOuq/j4tqx2r0gcu/8ABefFAUA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199015)(2906002)(31686004)(5660300002)(66556008)(4326008)(6916009)(54906003)(8676002)(316002)(36756003)(478600001)(66946007)(6506007)(8936002)(41300700001)(6486002)(6512007)(53546011)(83380400001)(26005)(66476007)(2616005)(38100700002)(31696002)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L0w4T1lYdGFyOVUrMDFLaTZHNjAvdEU2TVNYamxuZU5MMHpWZi81NWRYNnpZ?=
 =?utf-8?B?OWQ0OW4xZDloQUlXcjZaVW9QVnV6My9YTHRBanhjblpTODRaVDFtNlhBVnBv?=
 =?utf-8?B?ZEEyeXhTL2xZWnZlSXFPcVhQdDJ1emdSaWxjb2xnQUtMY2RraVQzZ3lIUnNk?=
 =?utf-8?B?NGU2UWRYZlBwNTA2SXNyUzlsVU93YmsyQ0VLdVhrdStHUDdzcjg1Ry8zNExp?=
 =?utf-8?B?aU51M2JiN3ZGaVRGWFN3ZXllVXVsS0JkcUU4c3NXcFZONGlUZDViUVlmMEtz?=
 =?utf-8?B?SFV1Vnd1M3RubW1PbW15bHB0Tm9XbVNFTElGWVB4YXN3RllhZCtBNVEvN3Fo?=
 =?utf-8?B?WkdicW9kOTk0dXY0RVl3dE5CQUZTZVpDS2hsZFRvZEhFTEtZOTN5L2ROdWJZ?=
 =?utf-8?B?TktLcHBQOXZMVTZaL1RGQmRTb2IwWnFzQmlhT0NpbU01ZEtNSnFTdGRwTTRI?=
 =?utf-8?B?WVZHT1J1a1VXQmREaDFFa2NlenZMOUdlSGNTRHduQnJiRmh5cEhpSnJpVnps?=
 =?utf-8?B?RnJDbTRLVE5haW5QNGFzd2RlWFE0bWFZeWVxbWhSc2xScFl5OXQ0bGxJNHVs?=
 =?utf-8?B?bGljcUd6ZndKTWhwNG4rWHovRnNrWUVOaExUYjV3bG1rZDhFNlhqNFlCNmxw?=
 =?utf-8?B?MnB2QnB4QlhIcC9PbWlON24yaTVJbE5NY01YT3VLQ25hYXIxSm9OM2FGWGNp?=
 =?utf-8?B?Mkh2YlRHWmZFNklFcWRjNkl4TFJhZkJlNzBVUnZmVTJSMFU5QUhsS2V1dXBx?=
 =?utf-8?B?M0l6RWRUZDFVczFML2ZXYjlKb0Zja2U3cUd0Z25aWUd4ZW9KWGJXalVzemM1?=
 =?utf-8?B?KzNBSUc3TE1YQnl3SEFHYUVyME1FbVY4aW9QREVYbzdkcktuNytqbmdlcTgw?=
 =?utf-8?B?V3lsRzRjNG1vemJabTgraFAzdmlXc1BVZExvTmU4cVRLdEtyUHFJVEdzMkht?=
 =?utf-8?B?QUtwQXBwaHFrZTBCY1ZiSGluT2pwVkJJZmN0VG9ZWFFnLzJYZjhNdDlJQVQx?=
 =?utf-8?B?NzNxWXVtVHdlcmUyQ05sRnZMNit0VWxqdjcybStqdmx0elJCYjl2YW5sRHU2?=
 =?utf-8?B?NDJPNzFUd0hobXh6eXdjcklIMk9NZVh2UDVBZFFFNmdQZkp0em9GWTVwTEpJ?=
 =?utf-8?B?NENWdmY0QTArQVY1azBVUS9hQzVOYnZKLzhRWDkyeUFySUNkUVB3cmJ1TFdp?=
 =?utf-8?B?NHk5ZnpJQlg3eStLSVNyTndENENuVzBDN0VzcUEvTC9NbmV1Z3ZRL0s3dXI0?=
 =?utf-8?B?WkY2aEZlNkZtVzVvcDErYVdxMER1R1ZkUG45YWNNLzRpQnZqNHN5U21SV1Qz?=
 =?utf-8?B?a1o0V240YnI5RzJlMkdRYVlnMTNqMkx2Zlk4YTBqdTczQmdYb2t5dHJuMDFw?=
 =?utf-8?B?NHZTLzlFSlIwVFVXbkZLNnhwcm5pZXp4RjAwZVdLVE9sS0pEVE1sWHlWOUlG?=
 =?utf-8?B?bEZoM2ZjdmdjQ2wvMjF4Y1ZIRk1zM3g2Szl4TjJCSUxRY1lZaU1UMllEcnVx?=
 =?utf-8?B?eW53WHhic3A4T09QamV0N0w3emNnQk5IbUk0dlZscDgxWmQ3K0Q1cjBRWWxC?=
 =?utf-8?B?cWdLcTZmOE1RajNsWnVmdUpUS29FTXFFTzg0aVJ0c1pzY2pQU25MRnRTZEEx?=
 =?utf-8?B?Wnp5WW1CS1duaHBEbmNvaWhkRU9INFVtdGExNzJ6S2NWTEprNityVThQaFRv?=
 =?utf-8?B?ZGhPRXRUUk9oY04yU2FkM2Q2bmhBNUtQdW9relJhdXJvZEhLR0wzenRKL3l1?=
 =?utf-8?B?OXllTkkrek54QjZucU9NbWZPbU9FQ3hBWDZJSTlNV2JzZnQrV1BqcTJ3L2Ur?=
 =?utf-8?B?SDBoZUk1bDlzWlJlVDhmLzlCcUY4bXlOVkJBaWdneTF2WWZmMWRzSkR0RnFR?=
 =?utf-8?B?RWd3M2tVbFNrL1hudkFJRFdZY0ZBclRiY1pNNnlUL1BtRjdOcVFuM0pHODdJ?=
 =?utf-8?B?d0Nzd0pVZElWS1Z6RklFL2x6Y1hsTnBucmVpbCtwbnZMQXhxLzRNZ0hhbkRN?=
 =?utf-8?B?Sml6MnRaQjFJRWpOeW92VlduRUozOTdoaFhJL1UvRXV5ZWJQeGhSeEc0bTBz?=
 =?utf-8?B?Y0lOa2RTQzIvMjk0SXZIMDEwTWhibHM2T1ZtNXVnYWFyUk1NNFhqcW53VFZn?=
 =?utf-8?Q?cHZWwqcMysaUG0q9eehU87GlS?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cff2c43-88a0-4c97-ce61-08dab1216e2e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:57:16.8038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nh75vZ1TMM/NUbkE79ndTiD1XqvWJ7c7stazS3Ul8ZJRyp4MdGOYQ2smYtgT3AkQ8xmu1aUr5ZPE+1OE1OE9hA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8235

On 18.10.2022 17:49, Luca Fancellu wrote:
>> On 18 Oct 2022, at 16:29, Jan Beulich <jbeulich@suse.com> wrote:
>> On 18.10.2022 17:17, Luca Fancellu wrote:
>>>> On 13 Oct 2022, at 12:34, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 13.10.2022 12:11, Luca Fancellu wrote:
>>>>>> On 13 Oct 2022, at 08:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> Iirc at least Coverity ignores certain instances of what it might consider
>>>>>> violations (fall-through in switch() statements in particular) in case
>>>>>> _any_ comment is present. Therefore may I suggest that such comments be
>>>>>> deleted (really: replaced by a blank line, to maintain correct line
>>>>>> numbering) if there's no matching key-value pair?
>>>>>
>>>>> Yes the line won’t be altered if there is no match. This to ensure the correct line
>>>>> numbering is not affected.
>>>>
>>>> "won't be altered" is the opposite of what I've been asking to consider:
>>>> Observing that comments _regardless_ of their contents may silence findings,
>>>> the suggestion is to remove comments (leaving a blank line) when there's no
>>>> entry for the targeted tool in the table entry.
>>>
>>> Why? The tag comment won’t do anything, it would act as a blank line from the analyser
>>> perspective.
>>
>> The _tag_ won't do anything, but as said any _comment_ may have an effect.
> 
> Yes, any comment that is using a proprietary syntax for the tools we use:
> 
> /* cppcheck-suppress[proprietary_ID] */
> /* coverity[proprietary_ID] */
> /* -E> hide proprietary_ID 1 “" */
> 
> May have an effect.
> 
> If an entry in the database has no match with the used tool, then it would stay as (for example):
> 
> /* SAF-X-safe [blablabla] */
> 
> Which has no effect on any tool, hence I don’t see the needs to replace it with a blank line.

One more try: May I ask that you re-read the very beginning of the context
I've left in place? I did call out a case where, from all I know, a tool
would be silenced by the mere presence of a comment, regardless of comment
text. Hence by not purging SAF-X-... comments you may suppress findings.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 16:12:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 16:12:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425305.673033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okpCF-00067d-KD; Tue, 18 Oct 2022 16:12:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425305.673033; Tue, 18 Oct 2022 16:12:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okpCF-00067W-GN; Tue, 18 Oct 2022 16:12:03 +0000
Received: by outflank-mailman (input) for mailman id 425305;
 Tue, 18 Oct 2022 16:12:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RnJu=2T=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1okpCE-00065t-4Y
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 16:12:02 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98402f57-4eff-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 18:11:59 +0200 (CEST)
Received: from DU2P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::25)
 by DB3PR08MB8913.eurprd08.prod.outlook.com (2603:10a6:10:43a::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct
 2022 16:11:57 +0000
Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:230:cafe::e5) by DU2P251CA0010.outlook.office365.com
 (2603:10a6:10:230::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Tue, 18 Oct 2022 16:11:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 18 Oct 2022 16:11:57 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Tue, 18 Oct 2022 16:11:57 +0000
Received: from ae42d45d7561.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 37C49311-F5F9-48E3-A3F3-88C8C2FF497B.1; 
 Tue, 18 Oct 2022 16:11:47 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ae42d45d7561.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 18 Oct 2022 16:11:46 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DB9PR08MB6427.eurprd08.prod.outlook.com (2603:10a6:10:25a::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct
 2022 16:11:44 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022
 16:11:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98402f57-4eff-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=eumjy+BzVu7eRBaFndoRLmBo+Re90O6CzPOEzmoCLszG+jWFTeeSkPjovTnGfANpSABZCLd7B9KTZ5kH4J8v8MoEvnniMmkaulUZCkBRZmNoNToSbEZf8zErPGYsTQ3F4Px7DjgHuDf2z3UUXtw1SPN2bNoWROvHmIvMe/5lCMY+E7x7bDaqbVo1ADWWDua6jevuszxQkR82u637P5htOdegOAaeo6EHGWGlND/fq0+5xqTXIqnQwO34NH3f3C1MRsjIPuKVVWw49klJrkd4Yrvp87BoFxJr6EySQ/Uwz23pRqYl/H7id77pEW5R/6P3vP1Q/CV4j+3jroF5jRdCKg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZFQ3hU6pgKRN9KLaAKrTOdnpabWGjgVOhZI8BI+ZFYE=;
 b=XPSq14Yw4Kk2xzZk2ihkWdMSOb4Wio2Q5WPhG8plVO/5y13FtzhbYKz/8R01yx9vbyloIE6JMFZ+lgwS9jGozDADD9MtXPSh/bnHKQ4DYZqrzrqbN37R/dK66xhYowf+3dGvKqFkX+kSj5qoSVPCoVrmttHWn8NsfhTUhT63YZpuslvBXWzWwcYN82soTx4I/cqVNZacNAPuHi+HmsbMzysBuQtV7idlXlG51PMVgeYBDpXWvJbjNZshW/xzYpVDvkPKF2R0PLC3hRtChqqXP25vLIt7AFl8HSkBaZMatfFhlpvQ155HXMHuufL1WLl94Ies+ZFqauyqc3tmRHHmbg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZFQ3hU6pgKRN9KLaAKrTOdnpabWGjgVOhZI8BI+ZFYE=;
 b=Em/vni01cmYEQclE5rNY+PZHmk1Sx5LHSC5JxTT3sPaEgqXdn12TXg6OWH9C8zUvE6NFKQYv6uQSJcf89NTZ8v2WIacA59FpOBSmq25J8ZVztkRxkzY/aRfSkaJUZ4araCBnyCJnaL/DIS45lqLj5aSMZcXWVOq3XIguhp/0VEk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 553b3c67a07c87a0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Koje0jNsrMBjrc6b4Keh8d8UGbCaOm7MHmWiEMcOAjXyfatT8TG0i6DYol+T2gIO70ECUD5QyN68pWFldge1yPuVrzptxbzhJ3pk4+3Kq/VV4Rkc8fSG0TXXxVEL+wta28fQLz9PX0gY5vi3aIlh2EvY7x8GeIgwMcp/FevIondozJkcM+vpPtLhAQTpsGBaHLzhBCdgQyhXB2jP4n2bJTuykg/sesKvMnD0sTlQ2xVVxdrQtRT+FlbU0eZAxuaHBEFMChElGPa6L8H7pyLFgAEl10o8Z+gmZmhj3fWTH4u01Us5Mbcixh+jGABu2Rom4aZLtqkNFZWGy8+Px2sqsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZFQ3hU6pgKRN9KLaAKrTOdnpabWGjgVOhZI8BI+ZFYE=;
 b=a2gmSSLm8HJzbvbH5g7CL11xcyGn2bmVXmmj5mveWiZBij/1jEZYBNSZKvF+9vCZ3to4k4KnPu8x6lRhYdUkHKazKkwdjD3zPfn2qf3G32hyYRYg/iyPhhC3/j/5iGMWx2bG0GIQ8/J65uF7fva7qDiTQL/wZV6AoDgSPjuNCW2D0zTQUZt+ajWnXKr6QyyYt0NhCRTpq1bZqPXjSmjOac66Z8uKaZe9LV+dhA++P0i+xu5goypXSmT6vELtjqVPCriztpE3+CC4QJ2Ai/JAe98BSNCBf1XC9npgjqqHy03tNVPBcjfDg7jthRoZUAa15QU8QPOJdlDI359bnL1GmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZFQ3hU6pgKRN9KLaAKrTOdnpabWGjgVOhZI8BI+ZFYE=;
 b=Em/vni01cmYEQclE5rNY+PZHmk1Sx5LHSC5JxTT3sPaEgqXdn12TXg6OWH9C8zUvE6NFKQYv6uQSJcf89NTZ8v2WIacA59FpOBSmq25J8ZVztkRxkzY/aRfSkaJUZ4araCBnyCJnaL/DIS45lqLj5aSMZcXWVOq3XIguhp/0VEk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Luca Fancellu <Luca.Fancellu@arm.com>, Wei Chen <Wei.Chen@arm.com>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index:
 AQHY3lPHM2Tyba3hCkeKMW07GDOb2a4L9DeAgAAnewCAABdGAIAIGdUAgAADdICAAAu3gA==
Date: Tue, 18 Oct 2022 16:11:43 +0000
Message-ID: <A906FDB6-7DA5-4900-A6DE-1140231E69AE@arm.com>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
In-Reply-To: <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|DB9PR08MB6427:EE_|DBAEUR03FT049:EE_|DB3PR08MB8913:EE_
X-MS-Office365-Filtering-Correlation-Id: 6c42f0ba-2878-4117-3164-08dab1237b17
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Kg+eW9mWB0xNtjwE0H6rFpH6pmE3cCnwJEYq9Vd8o1/e4NM0pV/a80jI8Oo1vNm8pMqwdZetIqYzAL0FtSEKxo6y3RcMKGe1Eh61Q8qHE+AXLsdGz4Vvrx9Q8v+r8YVbwwrly+TWEbRJ598UEtmoJU8ET/KumFgWtVWmodc32Pak4j1vI5ffZZ9BS5gsUa++QS9ahxyHjCWS8YsQrFxUOFpc0Y4HOxLiq19IPbe2P+Csed3/nFNrfZzEtv4zda4yk1wYmHdM5zIrd34yCN+OeY8zNbsCSnzpC5hbBTSR0gKlPOa4Sx2OuWS1D5PibexytpEqP7/RFNgccVEk/3w7xShJT4ywaLGEiLp3F+sfixcF/GGRwcShMiUuImehAlGZU2NKr6vYJz/I4bVKquyQpBdnCcZPnvG/aWuFVcTBWFMBe8HkhyM7gHYcfm3ogfOZ5QjdHfom73/3lkXah95QqYXwN+gKP9pFES8H3TR2ZqrqYt1iYk+O6Pd+VW+KI2sxoiHRf00fkB74NnhSiLLYc04nCvEk5u3OZU4Cr9i2RwTGCl9kChkaNfkPtu3SOKrC5xWGBcfVN4pD/WkV2lSUpIMg6Pv9MTY0HdE2sS3/40J3sAt3G3phLa+C21LZLb1V28sKaw47HZSxJwYSAnBtO/aAb8RSAN39cs8hJh1xgW2Mxesckwfa6nXANB+72ls+Z3kdUz9cBJfAXpI/hz1ciIC/4E+wSti0wuUcaYfrDTZOBMBsovacJjb2uJh4ObUqGvd7GsnodyG2b0HqeHRTREL49zNRJQGxvg7RZFVwVts=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(451199015)(83380400001)(2906002)(186003)(2616005)(86362001)(33656002)(4326008)(8676002)(26005)(6506007)(66446008)(64756008)(6512007)(41300700001)(53546011)(38070700005)(36756003)(316002)(54906003)(66476007)(122000001)(38100700002)(66556008)(8936002)(71200400001)(5660300002)(6916009)(66946007)(76116006)(91956017)(6486002)(478600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <A6AF9A4124F1FC46BA85048787D26808@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6427
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ae883c9f-0ca7-4d20-c6be-08dab123730a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	S9nSJQo545FPEJE8GawoNOiLyj3tIMwHcQTRTev8JO7oqr22dRGqCte2TUoiykKyJVTp0xB9U4u5bUPvLxf4266DCYkTG6AbeLInLUS7/JC1P3gUK+mmWEnpHOynuQcNdpFvJFBnoJPijP4dfvFi2crmWzKdrvko11LWe7QVXKxlPmWlgpzwO/PrIt2pV9GFhzGri+bQtsuEd7AoShcNcVGgKAsHRm8vQPlDiWEJ2/Rm5iTtR/bmhmXn1B5V1O7QlL0IE16dcIhu++233UGxszAAgvMJ1n55e9sUHz8B180RdYsu18oW0EFSKVY7nbAjF0+LJpUTPRFU5y6c3txxtyb7WAnsh4QEY6LJu5KFg++Pb5yQy+Sq/C8KcnmI0qCDVV4k1o5cMXUb+SzTrPb+rTbCD1qB0+CHC7Km8ho7Il+RyvUbRJTRq5Ozbzufm8Dhgl12F9Vt5aBGJ2LIBUzMvU0FgRs3WutN0Qu/X/Ymh6NegLPhhpdxJKJd03W44lkbmrwlX6c0RYfKY0zw/L7zldviw2HmY9G+zB0Yiirstfa7DXj99Su42nUrOL+LIiCsT3kd0Kx83liNcI+k09Djlg9/5DuqhKfAPnXYpv878rOvU3XJVTzOA9RG8PvEHC9FaHmddnAoaSSKVvLzj7G8ku9kPYUVWlfUU95/YbyPhtFto+/M48QcqNLNkK2kUS1cR3J2KWgca2OyVxMJphUsFEl7rY8DoZesjsGfcR+UmZAjVOvNpcRNjASS93vQ/+fCLWlCHVr1ajZq07I/SQhVVQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(86362001)(40480700001)(82740400003)(36756003)(36860700001)(33656002)(40460700003)(81166007)(356005)(82310400005)(83380400001)(316002)(478600001)(54906003)(6486002)(53546011)(41300700001)(26005)(8936002)(2616005)(6506007)(6512007)(5660300002)(6862004)(70206006)(70586007)(8676002)(4326008)(336012)(186003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 16:11:57.3279
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c42f0ba-2878-4117-3164-08dab1237b17
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8913

SGksDQoNCj4gT24gMTggT2N0IDIwMjIsIGF0IDE2OjI5LCBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTguMTAuMjAyMiAxNzoxNywgTHVjYSBGYW5jZWxs
dSB3cm90ZToNCj4+PiBPbiAxMyBPY3QgMjAyMiwgYXQgMTI6MzQsIEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gT24gMTMuMTAuMjAyMiAxMjoxMSwgTHVjYSBGYW5j
ZWxsdSB3cm90ZToNCj4+Pj4+IE9uIDEzIE9jdCAyMDIyLCBhdCAwODo1MCwgSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+IE9uIDEyLjEwLjIwMjIgMTg6MDAsIEx1
Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+Pj4gRW50cmllcyBpbiB0aGUgZGF0YWJhc2Ugc2hvdWxk
IG5ldmVyIGJlIHJlbW92ZWQsIGV2ZW4gaWYgdGhleSBhcmUgbm90IHVzZWQNCj4+Pj4+PiBhbnlt
b3JlIGluIHRoZSBjb2RlIChpZiBhIHBhdGNoIGlzIHJlbW92aW5nIG9yIG1vZGlmeWluZyB0aGUg
ZmF1bHR5IGxpbmUpLg0KPj4+Pj4+IFRoaXMgaXMgdG8gbWFrZSBzdXJlIHRoYXQgbnVtYmVycyBh
cmUgbm90IHJldXNlZCB3aGljaCBjb3VsZCBsZWFkIHRvIGNvbmZsaWN0cw0KPj4+Pj4+IHdpdGgg
b2xkIGJyYW5jaGVzIG9yIG1pc2xlYWRpbmcganVzdGlmaWNhdGlvbnMuDQo+Pj4+PiANCj4+Pj4+
IENhbiB3ZSBhZGQgcHJvdmlzaW9ucyBmb3Igc2hyaW5raW5nIHN1Y2ggZW50cmllcyB0byBlLmcu
IGp1c3QgdGhlaXIgImlkIg0KPj4+Pj4gbGluZT8gT3IgaXMgdGhlIGludGVudGlvbiB0byBiZSBh
YmxlIHRvIHJlLXVzZSBzdWNoIGFuIGVudHJ5IGlmIGEgbWF0Y2hpbmcNCj4+Pj4+IGluc3RhbmNl
IGFwcGVhcnMgYWdhaW4gbGF0ZXI/DQo+Pj4+IA0KPj4+PiBJIHByZWZlciB0byBkb27igJl0IHNo
cmluayBpdCwgdGhlIG5hbWUgaXRzZWxmIGlzIG5vdCB2ZXJ5IGxvbmcsIGV2ZW4gdXNpbmcgbWFu
eSBkaWdpdHMgb2YgdGhlIGluY3JlbWVudGFsDQo+Pj4+IG51bWJlciwgaXQgcmVtb3ZlcyBhbHNv
IHRoZSBkZXBlbmRlbmN5IG9uIHRoZSBmaWxlIG5hbWUuDQo+Pj4gDQo+Pj4gTmFtZSBsZW5ndGgg
aXNuJ3QgcmVsZXZhbnQgaGVyZSwgYW5kIEkgaGF2ZSBubyBpZGVhIHdoYXQgZGVwZW5kZW5jeSBv
biBhDQo+Pj4gZmlsZSBuYW1lIHlvdSdyZSB0aGlua2luZyBvZi4gTXkgcXVlc3Rpb24gaXMgYSBz
Y2FsYWJpbGl0eSBvbmU6IE92ZXIgdGltZQ0KPj4+IHRoZSB0YWJsZSB3aWxsIGdyb3cgbGFyZ2Uu
IElmIGFsbCBlbnRyaWVzIHJlbWFpbiB0aGVyZSBpbiBmdWxsIGZvcmV2ZXIsDQo+Pj4gdGFibGUg
c2l6ZSBtYXkgYmVjb21lIHVud2llbGR5Lg0KPj4gDQo+PiBPayBJIG1pc3VuZGVyc3Rvb2QgeW91
ciBxdWVzdGlvbiwgbm93IEkgdW5kZXJzdGFuZCB3aGF0IHlvdSBhcmUgYXNraW5nLCB3ZSBjb3Vs
ZCByZW1vdmUgdGhlIGNvbnRlbnQNCj4+IG9mIHRoZSDigJxhbmFseXNlcuKAnSBkaWN0aW9uYXJ5
IGZvciBzdXJlLCBiZWNhdXNlIGlmIHRoZXJlIGlzIG5vdCBhbnltb3JlIGEgbGluayB3aXRoIHRo
ZSBjdXJyZW50IGNvZGUuDQo+PiANCj4+IFJlZ2FyZGluZyByZW1vdmluZyB0aGUg4oCcbmFtZeKA
nSBhbmQg4oCcdGV4dOKAnSwgY291bGQgaXQgYmUgdGhhdCBhdCBzb21lIHBvaW50IHdlIGNhbiBp
bnRyb2R1Y2UgaW4gdGhlIGNvZGUNCj4+IGEgdmlvbGF0aW9uIHRoYXQgcmVxdWlyZXMgdGhlIHNh
bWUganVzdGlmaWNhdGlvbiBwcm92aWRlZCBieSB0aGUg4oCcb3JwaGFu4oCdIGVudHJ5Pw0KPj4g
SW4gdGhhdCBjYXNlIHdlIGNvdWxkIHJldXNlIHRoYXQgZW50cnkgd2l0aG91dCBjcmVhdGluZyBh
IG5ldyBvbmUgdGhhdCB3aWxsIG9ubHkgd2FzdGUgc3BhY2UuDQo+PiBXaGF0IGlzIHRoZSBvcGlu
aW9uIG9uIHRoaXM/DQo+IA0KPiBXZWxsLCB5ZXMsIHRoaXMgaXMgdGhlIG9uZSBjYXNlIHRoYXQg
SSwgdG9vLCB3YXMgd29uZGVyaW5nIGFib3V0LiBJdCdzIG5vdA0KPiBjbGVhciB0byBtZSB3aGV0
aGVyIGl0IHdvdWxkbid0IGJlIGJldHRlciB0byBhbGxvY2F0ZSBhIGZyZXNoIElEIGluIHN1Y2gg
YQ0KPiBjYXNlLg0KDQpGb3IgdHJhY2VhYmlsaXR5IGFuZCByZWxlYXNlIGhhbmRsaW5nIEkgdGhp
bmsgaXQgaXMgaW1wb3J0YW50IHRoYXQ6DQotIHdlIG5ldmVyIHJldXNlIHRoZSBzYW1lIElEIGlu
IGFueSBjYXNlDQotIHdlIGtlZXAgSURzIGluIHRoZSBkYXRhYmFzZSBldmVuIGlmIHRoZXJlIGlz
IG5vIG9jY3VycmVuY2UgaW4geGVuIGNvZGUgYXMgdGhpcyB3aWxsIHByZXZlbnQgYWRkaW5nIGEg
bmV3IElEIGlmIGFuIGV4aXN0aW5nIG9uZSBjYW4gYmUgcmV1c2VkDQoNCkluIGEgY2VydGlmaWNh
dGlvbiBjb250ZXh0LCB3aGVuIGEganVzdGlmaWNhdGlvbiBoYXMgYmVlbiB2YWxpZGF0ZWQgYW5k
IGFncmVlZCBpdCB3aWxsIG1ha2UgbGlmZSBhIGxvdCBlYXNpZXIgdG8gbm90IG1vZGlmeSBpdCBh
bmQgcmV1c2UgaXQgaW4gdGhlIGZ1dHVyZSBpZiBpdCBpcyBuZWVkZWQuDQpGcm9tIG91ciBwb2lu
dCBvZiB2aWV3LCBoYXZpbmcgYSBjbGVhciBhbmQgc2ltcGxlIHdheSBvZiBoYW5kbGluZyB0aG9z
ZSB3aWxsIG1ha2UgYmFja3BvcnRzIGEgbG90IGVhc2llci4NCg0KDQo+Pj4+Pj4gSGVyZSBhIGJy
aWVmIGV4cGxhbmF0aW9uIG9mIHRoZSBmaWVsZCBpbnNpZGUgYW4gb2JqZWN0IG9mIHRoZSAiY29u
dGVudCIgYXJyYXk6DQo+Pj4+Pj4gLSBpZDogaXQgaXMgYSB1bmlxdWUgc3RyaW5nIHRoYXQgaXMg
dXNlZCB0byByZWZlciB0byB0aGUgZmluZGluZywgbWFueSBmaW5kaW5nDQo+Pj4+Pj4gY2FuIGJl
IHRhZ2dlZCB3aXRoIHRoZSBzYW1lIGlkLCBpZiB0aGUganVzdGlmaWNhdGlvbiBob2xkcyBmb3Ig
YW55IGFwcGxpZWQNCj4+Pj4+PiBjYXNlLg0KPj4+Pj4+IEl0IHRlbGxzIHRoZSB0b29sIHRvIHN1
YnN0aXR1dGUgYSBYZW4gaW4tY29kZSBjb21tZW50IGhhdmluZyB0aGlzIHN0cnVjdHVyZToNCj4+
Pj4+PiAvKiBTQUYtMC1zYWZlIFsuLi5dIFwqLw0KPj4+Pj4+IC0gYW5hbHlzZXI6IGl0IGlzIGFu
IG9iamVjdCBjb250YWluaW5nIHBhaXIgb2Yga2V5LXZhbHVlIHN0cmluZ3MsIHRoZSBrZXkgaXMN
Cj4+Pj4+PiB0aGUgYW5hbHlzZXIsIHNvIGl0IGNhbiBiZSBjcHBjaGVjaywgY292ZXJpdHkgb3Ig
ZWNsYWlyLiBUaGUgdmFsdWUgaXMgdGhlDQo+Pj4+Pj4gcHJvcHJpZXRhcnkgaWQgY29ycmVzcG9u
ZGluZyBvbiB0aGUgZmluZGluZywgZm9yIGV4YW1wbGUgd2hlbiBjb3Zlcml0eSBpcw0KPj4+Pj4+
IHVzZWQgYXMgYW5hbHlzZXIsIHRoZSB0b29sIHdpbGwgdHJhbnNsYXRlIHRoZSBYZW4gaW4tY29k
ZSBjb21lbnQgaW4gdGhpcyB3YXk6DQo+Pj4+Pj4gLyogU0FGLTAtc2FmZSBbLi4uXSBcKi8gLT4g
LyogY292ZXJpdHlbY292ZXJpdHktaWRdIFwqLw0KPj4+Pj4gDQo+Pj4+PiBJbiBoZXJlLCB3aGVy
ZSB3b3VsZCBjb3Zlcml0eS1pZCBjb21lIGZyb20/IEFuZCBob3cgZG9lcyB0aGUgdHJhbnNmb3Jt
YXRpb24NCj4+Pj4+IGhlcmUgbWF0Y2ggdXAgd2l0aCB0aGUgdmFsdWUgb2YgdGhlICJjb3Zlcml0
eSI6IGZpZWxkIGluIHRoZSB0YWJsZT8NCj4+Pj4gDQo+Pj4+IEkgY2FuIHB1dCBhbiBleGFtcGxl
IG9mIHRoYXQsIGFzIHlvdSBwb2ludGVkIG91dCBpdCBjb3VsZCBiZSBkaWZmaWN1bHQgdG8gZ2V0
IHdoZXJlDQo+Pj4+IHRoaXMgcHJvcHJpZXRhcnkgdG9vbCBJRCBjb21lcyBmcm9tLg0KPj4+PiAN
Cj4+Pj4gVGhlIHByb3ByaWV0YXJ5IElEIChDb3Zlcml0eSBpbiB0aGlzIGNhc2UpIGNvbWVzIGZy
b20gdGhlIHJlcG9ydCBpdCBwcm9kdWNlczoNCj4+Pj4gDQo+Pj4+IFvigKZdDQo+Pj4+IDxmaWxl
IHBhdGg+OjxsaW5lIG51bWJlcj46DQo+Pj4+IDEuIHByb3ByaWV0YXJ5X0lEOiBb4oCmXQ0KPj4+
PiBb4oCmXQ0KPj4+PiANCj4+Pj4gYWZ0ZXIgd2Ugc2VlIHRoZSBmaW5kaW5nLCB3ZSB0YWtlIHRo
YXQgSUQsIHdlIHB1dCBpdCBpbiB0aGUg4oCcYW5hbHlzZXLigJ0gZGljdGlvbmFyeSBhczoNCj4+
Pj4gDQo+Pj4+IFvigKZdDQo+Pj4+ICJpZCI64oCdU0FGLTItc2FmZSIsDQo+Pj4+IOKAnGFuYWx5
c2Vy4oCdOiB7DQo+Pj4+IAnigJxjb3Zlcml0eeKAnTog4oCccHJvcHJpZXRhcnlfSUQiDQo+Pj4+
IH0sDQo+Pj4+IFvigKZdDQo+Pj4+IA0KPj4+PiBTbyBpbiB0aGUgc291cmNlIGNvZGUgd2Ugd2ls
bCBoYXZlOg0KPj4+PiANCj4+Pj4gLyogU0FGLTItc2FmZSBbb3B0aW9uYWwgdGV4dF0gKi8NCj4+
Pj4gQyBjb2RlIGFmZmVjdGVkIGxpbmU7DQo+Pj4+IA0KPj4+PiBBbmQgd2hlbiB0aGUgYW5hbHlz
aXMgd2lsbCBiZSBwZXJmb3JtZWQsIHRoZSB0b29sIChjb3Zlcml0eSBmb3IgZXhhbXBsZSkgd2ls
bCBydW4gb24gdGhpcyBzb3VyY2UgY29kZToNCj4+Pj4gDQo+Pj4+IC8qIGNvdmVyaXR5W3Byb3By
aWV0YXJ5X0lEXSAqLw0KPj4+PiBDIGNvZGUgYWZmZWN0ZWQgbGluZTsNCj4+Pj4gDQo+Pj4+IFRo
ZSB0b29sIHdpbGwgd3JpdGUgYSByZXBvcnQgYW5kIHdpbGwgc3VwcHJlc3MgdGhlIGZpbmRpbmcg
d2l0aCDigJxwcm9wcmlldGFyeV9JROKAnSB0aGF0IGNvbWVzIGluIHRoZSBDIGNvZGUNCj4+Pj4g
bGluZSBhZnRlciB0aGUgY29tbWVudC4NCj4+PiANCj4+PiBMZXQgbWUgYWRkIHNvbWUgYmFja2dy
b3VuZCB0byBteSBlYXJsaWVyIGNvbW1lbnQ6DQo+Pj4gDQo+Pj4gSWYgd2Ugd2FudGVkIHRvIGFk
ZCBzdWNoIElEcyB0byB0aGUgdGFibGUsIHRoZW4gSSBndWVzcyB0aGlzIHdvdWxkIHJlc3VsdCBp
bg0KPj4+IGEgcHJvbGlmZXJhdGlvbiBvZiBlbnRyaWVzLiBJZiBteSBvYnNlcnZhdGlvbnMgaGF2
ZW4ndCBtaXNndWlkZWQgbWUsDQo+Pj4gQ292ZXJpdHkgbWlnaHQgcmUtdXNlIHRoZSBzYW1lIElE
IGZvciBtdWx0aXBsZSBzaW1pbGFyIG5ldyBpc3N1ZXMgZm91bmQgaW4gYQ0KPj4+IHNpbmdsZSBy
dW4sIGJ1dCBpdCB3b3VsZCBub3QgcmUtdXNlIHRoZW0gYWNyb3NzIHJ1bnMuIEhlbmNlIGlycmVz
cGVjdGl2ZSBvZg0KPj4+IHRoZWlyIHNpbWlsYXJpdHksIG11bHRpcGxlIHRhYmxlIGVudHJpZXMg
d291bGQgYmUgbmVlZGVkIGp1c3QgYmVjYXVzZSBvZiB0aGUNCj4+PiBkaWZmZXJlbnQgQ292ZXJp
dHkgSURzLg0KPj4gDQo+PiBDb3Zlcml0eSB3aWxsIHVzZSBldmVyeSBydW4gdGhlIHNhbWUgaWQg
Zm9yIHRoZSBzYW1lIGNsYXNzIG9mIHZpb2xhdGlvbiwgZm9yIGV4YW1wbGUNCj4+IG1pc3JhX2Nf
MjAxMl9ydWxlXzhfNl92aW9sYXRpb24gZm9yIHZpb2xhdGlvbiBvZiBydWxlIDguNi4NCj4gDQo+
IEhtbSwgSSd2ZSBuZXZlciBzZWVuIHN1Y2guIEkgYWx3YXlzIHNhdyBpdCB1c2UgbnVtZXJpYyBJ
RHMsIGFuZCB3ZSd2ZQ0KPiBhY3R1YWxseSBiZWVuIHB1dHRpbmcgdGhlc2UgaW4gY29tbWl0cyB3
aGVuIGFkZHJlc3NpbmcgdGhlaXIgZmluZGluZ3MuDQoNCkhlcmUgSSB0aGluayB5b3UgYXJlIG1p
eGluZyBhIGZpbmRpbmcgaW5zaWRlIHRoZSBjb2RlIHdpdGggdGhlIHR5cGUgYXNzb2NpYXRlZC4N
CldlIG1pZ2h0IGhhdmUgc2V2ZXJhbCBmaW5kaW5ncyBvZiB0aGUgc2FtZSB0eXBlIGJ1dCB3aXRo
IGRpZmZlcmVudCBqdXN0aWZpY2F0aW9ucy4NCg0KPiANCj4+Pj4gQWZ0ZXIgdGhlIGFuYWx5c2lz
LCB0aGUgc291cmNlIGNvZGUgd2lsbCByZXR1cm4gYXMgdGhlIG9yaWdpbmFsICh3aXRoIHRoZSBT
QUYtKiB0YWcpLg0KPj4+IA0KPj4+IFdoaWxlIHlvdSBtZW50aW9uIHNvbWV0aGluZyBzaW1pbGFy
IGFsc28gYXMgc3RlcCAzIGluIHRoZSBvcmlnaW5hbCBkb2N1bWVudA0KPj4+IG5lYXIgdGhlIHRv
cCwgSSdtIGFmcmFpZCBJIGRvbid0IHVuZGVyc3RhbmQgd2hhdCB0aGlzICJyZXR1cm4gYXMgdGhl
IG9yaWdpbmFsIg0KPj4+IG1lYW5zLiBJZiB5b3Ugd2FudCB0byBydW4gdGhlIHRvb2wgb24gYW4g
YWx0ZXJlZCAoY29tbWVudHMgbW9kaWZpZWQpIHNvdXJjZQ0KPj4+IHRyZWUsIHdoYXQgSSdkIGV4
cGVjdCB5b3UgdG8gZG8gaXMgY2xvbmUgdGhlIHNvdXJjZXMgaW50byBhIHRocm93LWF3YXkgdHJl
ZSwNCj4+PiBtYXNzYWdlIHRoZSBjb21tZW50cywgcnVuIHRoZSB0b29sLCBhbmQgZGVsZXRlIHRo
ZSBtYXNzYWdlZCB0cmVlLg0KPj4+Pj4+IGlmIHRoZSBvYmplY3QgZG9lc24ndCBoYXZlIGEga2V5
LXZhbHVlLCB0aGVuIHRoZSBjb3JyZXNwb25kaW5nIGluLWNvZGUNCj4+Pj4+PiBjb21tZW50IHdv
bid0IGJlIHRyYW5zbGF0ZWQuDQo+Pj4+PiANCj4+Pj4+IElpcmMgYXQgbGVhc3QgQ292ZXJpdHkg
aWdub3JlcyBjZXJ0YWluIGluc3RhbmNlcyBvZiB3aGF0IGl0IG1pZ2h0IGNvbnNpZGVyDQo+Pj4+
PiB2aW9sYXRpb25zIChmYWxsLXRocm91Z2ggaW4gc3dpdGNoKCkgc3RhdGVtZW50cyBpbiBwYXJ0
aWN1bGFyKSBpbiBjYXNlDQo+Pj4+PiBfYW55XyBjb21tZW50IGlzIHByZXNlbnQuIFRoZXJlZm9y
ZSBtYXkgSSBzdWdnZXN0IHRoYXQgc3VjaCBjb21tZW50cyBiZQ0KPj4+Pj4gZGVsZXRlZCAocmVh
bGx5OiByZXBsYWNlZCBieSBhIGJsYW5rIGxpbmUsIHRvIG1haW50YWluIGNvcnJlY3QgbGluZQ0K
Pj4+Pj4gbnVtYmVyaW5nKSBpZiB0aGVyZSdzIG5vIG1hdGNoaW5nIGtleS12YWx1ZSBwYWlyPw0K
Pj4+PiANCj4+Pj4gWWVzIHRoZSBsaW5lIHdvbuKAmXQgYmUgYWx0ZXJlZCBpZiB0aGVyZSBpcyBu
byBtYXRjaC4gVGhpcyB0byBlbnN1cmUgdGhlIGNvcnJlY3QgbGluZQ0KPj4+PiBudW1iZXJpbmcg
aXMgbm90IGFmZmVjdGVkLg0KPj4+IA0KPj4+ICJ3b24ndCBiZSBhbHRlcmVkIiBpcyB0aGUgb3Bw
b3NpdGUgb2Ygd2hhdCBJJ3ZlIGJlZW4gYXNraW5nIHRvIGNvbnNpZGVyOg0KPj4+IE9ic2Vydmlu
ZyB0aGF0IGNvbW1lbnRzIF9yZWdhcmRsZXNzXyBvZiB0aGVpciBjb250ZW50cyBtYXkgc2lsZW5j
ZSBmaW5kaW5ncywNCj4+PiB0aGUgc3VnZ2VzdGlvbiBpcyB0byByZW1vdmUgY29tbWVudHMgKGxl
YXZpbmcgYSBibGFuayBsaW5lKSB3aGVuIHRoZXJlJ3Mgbm8NCj4+PiBlbnRyeSBmb3IgdGhlIHRh
cmdldGVkIHRvb2wgaW4gdGhlIHRhYmxlIGVudHJ5Lg0KPj4gDQo+PiBXaHk/IFRoZSB0YWcgY29t
bWVudCB3b27igJl0IGRvIGFueXRoaW5nLCBpdCB3b3VsZCBhY3QgYXMgYSBibGFuayBsaW5lIGZy
b20gdGhlIGFuYWx5c2VyDQo+PiBwZXJzcGVjdGl2ZS4NCj4gDQo+IFRoZSBfdGFnXyB3b24ndCBk
byBhbnl0aGluZywgYnV0IGFzIHNhaWQgYW55IF9jb21tZW50XyBtYXkgaGF2ZSBhbiBlZmZlY3Qu
DQoNCkkgYW0gbm90IHN1cmUgSSBmb2xsb3cgdGhpcyBvbmUgYnV0IGluIGFueSBjYXNlIHdlIGNh
biBjaG9vc2UgdG8gYW55d2F5IHN1YnN0aXR1dGUgdGhlIHRhZyB3aXRoIHNvbWV0aGluZyBsaWtl
IC8qIE5vdCBhcHBsaWNhYmxlICovLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+IEphbg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 18:41:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 18:41:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425328.673056 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okrWh-0005QG-IB; Tue, 18 Oct 2022 18:41:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425328.673056; Tue, 18 Oct 2022 18:41:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okrWh-0005Q9-Ei; Tue, 18 Oct 2022 18:41:19 +0000
Received: by outflank-mailman (input) for mailman id 425328;
 Tue, 18 Oct 2022 18:41:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okrWg-0005Pz-Cr; Tue, 18 Oct 2022 18:41:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okrWg-0008CI-8W; Tue, 18 Oct 2022 18:41:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okrWf-000131-Iz; Tue, 18 Oct 2022 18:41:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okrWf-0007Y5-IY; Tue, 18 Oct 2022 18:41:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pHqEKT1TQAyCInWPEKuUtMmZd7bVkDa5DGwSkmqddkc=; b=F+3DNwzdJ6IORqgGVWJduW6FOH
	K0YUa1RiNLRzX0viEeeSbaIhxnAk4fTfJOyMbNMVcgm8UOPhFOFEZDHcl7ye9PLCZedZZCWmg3cqn
	Hp/YmzB/Lpm1iCYioXeES5xzs5lbVB44L4Js3Eh0rqPnkwqyXC8qNd29zwPnykRxaals=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173980-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 173980: trouble: broken/fail/pass
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-libvirt-vhd:<job status>:broken:regression
    xen-unstable:test-amd64-amd64-libvirt-vhd:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 18:41:17 +0000

flight 173980 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173980/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt-vhd    <job status>                 broken

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-vhd  5 host-install(5)          broken pass in 173920
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 173920
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 173920

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail in 173920 never pass
 test-amd64-i386-qemuu-rhel6hvm-amd  7 xen-install             fail like 173466
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173488
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173920
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173920
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173920
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173920
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173920
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173920
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173920
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173920
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173920
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173920
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173920
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173920
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle   3 hosts-allocate           starved in 173920 n/a

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173980  2022-10-17 06:23:56 Z    1 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 broken  
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-libvirt-vhd broken
broken-step test-amd64-amd64-libvirt-vhd host-install(5)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Oct 18 19:14:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 19:14:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425337.673070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oks2D-0000gF-4F; Tue, 18 Oct 2022 19:13:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425337.673070; Tue, 18 Oct 2022 19:13:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oks2D-0000g8-1S; Tue, 18 Oct 2022 19:13:53 +0000
Received: by outflank-mailman (input) for mailman id 425337;
 Tue, 18 Oct 2022 19:13:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oks2C-0000g2-CK
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 19:13:52 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff06a587-4f18-11ed-8fd0-01056ac49cbb;
 Tue, 18 Oct 2022 21:13:50 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id E952061668;
 Tue, 18 Oct 2022 19:13:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52143C433D6;
 Tue, 18 Oct 2022 19:13:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff06a587-4f18-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666120428;
	bh=ybscR/xhESRTSorP7KlMKado9vU24cN/tdu0rNSXnes=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pF+ljYG99bsb/dU5T6x3U70RRZ0VkAFsLOgXwvq/Vhl3HR3Bq0HHBHNa7IV7bCSAv
	 fOJDdXKwotbjHCOyZeUt11/lWFgdw7nniY9aAfDB5DeS8+ZLG7clMu9ikb1g/+YKKM
	 CF/K6CP+n3L18xkqw5C8jve1U1L9cXC+1VKCZ/NAw4oNMFmgdqAnp9D46G7WHfIOw/
	 gWYqCOSxKG1+Nffnjx0nCmiDXhG+e1al8bshkJsH6zpvRZZ9SYcU/Tq817FYYBY1gk
	 Yxoe2+O8q42P0rpgaHyh0y+Q3FvDwHwloL+S6yoUPInNejDrsnqaZoVT2K/CuA7mkn
	 5sliWLoMXrEEg==
Date: Tue, 18 Oct 2022 12:13:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Vipul Suneja <vsuneja63@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, 
    oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, 
    Bertrand.Marquis@arm.com
Subject: Re: Porting Xen in raspberry pi4B
In-Reply-To: <CALAP8f81ojfVD9n5EMtD7DxY-8uomgENVEQH9Afz7Hk9rfaAsw@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210181213370.4587@ubuntu-linux-20-04-desktop>
References: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com> <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop> <CALAP8f81ojfVD9n5EMtD7DxY-8uomgENVEQH9Afz7Hk9rfaAsw@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1769250347-1666120333=:4587"
Content-ID: <alpine.DEB.2.22.394.2210181212200.4587@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1769250347-1666120333=:4587
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210181212201.4587@ubuntu-linux-20-04-desktop>

It usually works the way it is described in the guide:

https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest

You don't need to install any VNC-related server software because it is
already provided by Xen (to be precise it is provided by QEMU working
together with Xen.)

You only need the vnc client in dom0 so that you can connect, but you
could also run the vnc client outside from another host. So basically
the following should work when executed in Dom0 after creating DomU:

  vncviewer localhost:0

Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use
netstat -taunp to check if there is anything running at port 5900 or
5901?

Cheers,

Stefano


On Tue, 18 Oct 2022, Vipul Suneja wrote:
> Hi Stefano,
> 
> Thanks for the response!
> 
> I could install tigerVNC, x11vnc & libvncserver in Dom0 xen-image-minimal but only manage to install libvncserver(couldn't install tigervnc
> & x11vnc because of x11
> support missing, it's wayland) in DOMU custom graphical image. I tried running vncviewer with IP address & port in dom0 to access the domu
> graphical image display as per below commands.
>  
>  vncviewer 192.168.1.42:5901
>  
>  But it showing can't open display, below are the logs:
>  
> root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901
> 
> TigerVNC Viewer 64-bit v1.11.0
> Built on: 2020-09-08 12:16
> Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)
> See https://www.tigervnc.org for information on TigerVNC.
> Can't open display:
> root@raspberrypi4-64:~/guest1#
> 
> I am not exactly sure what the issue is but I thought only libvncserver in DOMU could work to get access but it did not work. 
> If TigerVNC is the issue here then is there any other VNC source which could be installed for both x11 & wayland supported images?
> 
> Regards,
> Vipul Kumar
> 
> On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       VNC is typically easier to setup, because SDL needs extra libraries at
>       build time and runtime. If QEMU is built without SDL support it won't
>       start when you ask for SDL.
> 
>       VNC should work with both x11 and wayland in your domU. It doesn't work
>       at the x11 level, it exposes a special fbdev device in your domU that
>       should work with:
>       - a graphical console in Linux domU
>       - x11
>       - wayland (but I haven't tested this so I am not 100% sure about it)
> 
>       When you say "it doesn't work", what do you mean? Do you get a black
>       window?
> 
>       You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
>       (drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text
>       console up and running in your domU before attempting x11/wayland.
> 
>       Cheers,
> 
>       Stefano
> 
>       On Mon, 17 Oct 2022, Vipul Suneja wrote:
>       > Hi,
>       > Thanks!
>       >
>       > I have ported xen minimal image as DOM0 & custom wayland GUI based image as DOMU in raspberry pi4B. I am trying to make GUI
>       display up
>       > for guest machine. I tried using sdl, included below line in guest.conf file
>       > vfb= [ 'sdl=1' ]
>       >
>       > But it is throwing below error:
>       >
>       > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
>       > Parsing config from guest1.cfg
>       > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection reset by peer
>       > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connection to QEMU
>       > libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed, rc=-26
>       > libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not start: -26
>       > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited
>       > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain
>       > libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy guest
>       > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed
>       >
>       > Another way is VNC, i could install tigervnc in DOM0 but same i couldn't in guest machine because it doesn't support
>       x11(supports wayland
>       > only). I am completely blocked here, Need your support to enable the display up.
>       > Any alternative of VNC which could work in both x11 & wayland supported images?
>       >
>       > Any input on VNC, SDL or any other way to proceed on this? Looking forward to hearing from you.
>       >
>       > Regards,
>       > Vipul Kumar
> 
> 
> 
--8323329-1769250347-1666120333=:4587--


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 19:30:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 19:30:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425345.673083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oksIb-0003I1-MP; Tue, 18 Oct 2022 19:30:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425345.673083; Tue, 18 Oct 2022 19:30:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oksIb-0003Hu-Jf; Tue, 18 Oct 2022 19:30:49 +0000
Received: by outflank-mailman (input) for mailman id 425345;
 Tue, 18 Oct 2022 19:30:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oksIa-0003Hk-4i; Tue, 18 Oct 2022 19:30:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oksIa-0000fM-30; Tue, 18 Oct 2022 19:30:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oksIZ-0003fC-Rd; Tue, 18 Oct 2022 19:30:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oksIZ-0001dx-RB; Tue, 18 Oct 2022 19:30:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KqltBcbZjD70knY5jd4nO6LKvJ6r0ZB6vaANFGRcVL0=; b=cjAMMtm2z5GSFvjVDH7DKUr5U8
	EG5U5+EqUcC5cpzNCTOfRP0fyiZIXjYBsNY/i4p9hMu0VeD5hlmOGHa0lzbDDbhAXzHLk5RxPomgN
	h9v3KuMcRQAUeOWqFNJMEhPCJfro/5gL5/J4jkjWkh8gLLdjc24JxPnNXlvEqjd3jSWM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174051-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174051: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 19:30:47 +0000

flight 174051 xen-unstable-smoke real [real]
flight 174056 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174051/
http://logs.test-lab.xenproject.org/osstest/logs/174056/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   46 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 19:55:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 19:55:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425353.673094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oksg2-000622-Jg; Tue, 18 Oct 2022 19:55:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425353.673094; Tue, 18 Oct 2022 19:55:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oksg2-00061v-Gt; Tue, 18 Oct 2022 19:55:02 +0000
Received: by outflank-mailman (input) for mailman id 425353;
 Tue, 18 Oct 2022 19:55:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9K0G=2T=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oksg1-00061p-Cb
 for xen-devel@lists.xenproject.org; Tue, 18 Oct 2022 19:55:01 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf67470f-4f1e-11ed-91b4-6bf2151ebd3b;
 Tue, 18 Oct 2022 21:54:59 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 30ED8B81F11;
 Tue, 18 Oct 2022 19:54:59 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E907C433D6;
 Tue, 18 Oct 2022 19:54:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf67470f-4f1e-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666122898;
	bh=VJcLJ6R5zsloyg6Ttp2tp38Jl0ZqQbH3A07lWjEZngk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ROb7MFdIyv0cqyc2xrJjAiOFh+vqk21cGr2MR97GOhIA2WfcJ1k3v84/rCsweH66u
	 YPv238pN8Yyyid0lS7TH7rTZkuV3hePFHT6SHryCF+udbUGi0S4gavyJS3wKAj6DtZ
	 ThgJi7TUVx+YSka8em9q0P1Hi0DqEuHjOmbP/Micn9NOmURVjigMhtf5BLfB0lCaeG
	 Y5+3XkErWA0BRloIe5fuq7IWG1jJ4awNIX4aTxicC90JikjdgpyQGfMJRemwmYJggS
	 t+Q94MCS8+m092tdgXfPEmX80dwLbdoxKA6iaxWF/olxHKr5ITdLRt3GvL7cQnzjBQ
	 XNRrC5se2w9qw==
Date: Tue, 18 Oct 2022 12:54:55 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Leo Yan <leo.yan@linaro.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Xen Develop <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Mathieu Poirier <mathieu.poirier@linaro.org>, 
    Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>, 
    jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, 
    wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <Y05w36OAVyDJwCCr@leoy-yangtze.lan>
Message-ID: <alpine.DEB.2.22.394.2210181253260.4587@ubuntu-linux-20-04-desktop>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop> <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop> <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop> <Y05w36OAVyDJwCCr@leoy-yangtze.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 18 Oct 2022, Leo Yan wrote:
> On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote:
> 
> [...]
> 
> > > Which means it takes 543us to let Dom0 to receive the notification.
> > > You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
> > > not have contention for CPU resources.  Seems to me, it's likely Xen
> > > hypervisor takes long time to deliver the interrupt, note, it's not
> > > take so long time for every skb transferring, sometimes the time for
> > > response a notification is short (about ~10us).
> > 
> > Good find. I think this is worth investigating further. Do you have
> > vwfi=native in your Xen command line as well?
> 
> Yes, I have added "sched=null" and "vwfi=native" into Xen options:
> 
> options=noreboot dom0_mem=4096M bootscrub=0 iommu=on loglvl=error guest_loglvl=error sched=null vwfi=native
> 
> > After that, I would add printk also in Xen with the timestamp. The event
> > channel notification code path is the following:
> > 
> > # domU side
> > xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
> > xen/arch/arm/vgic.c:vgic_to_sgi
> > xen/arch/arm/vgic.c:vgic_inject_irq
> > xen/arch/arm/vgic.c:vcpu_kick
> > xen/arch/arm/gic-v2.c:gicv2_send_SGI
> > 
> > # dom0 side
> > xen/arch/arm/gic.c:do_sgi
> > xen/arch/arm/traps.c:leave_hypervisor_to_guest
> > 
> > It would be good to understand why sometimes it takes ~10us and some
> > other times it takes ~540us
> 
> Thanks a lot for detailed info.
> 
> Just note, in my platform DomU enables GICv3 driver rather than GICv2.
> This would be a bit different in the Xen code.  But it should be easy
> for me to map to vgic-v3 files.
> 
> I have a question for how to trace Xen system.  Outputting chars to UART
> is time costy (usually it's millisecond level), it is not friendly to
> use console for debugging performance issue.  I searched a bit, either
> "xl dmesg" or xentrace can be used for capturing trace logs, one thing
> I am not certain is if we can save Xen logs only into log buffer and
> doesn't output to UART, so that afterwards we can use "xl dmesg" to
> capture the logs.  Could anyone confirm for this is correct usage with
> "xl dmesg" or I should use xentrace for this case?

I am not super familiar about this. But if you take away the console
entirely from Xen and give it to dom0 only (no dtuart command line
option to Xen), you should get the behavior you described:
- no console output because Xen has no console
- xl dmesg should still work


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 22:13:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 22:13:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425363.673117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okupS-0003cG-KF; Tue, 18 Oct 2022 22:12:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425363.673117; Tue, 18 Oct 2022 22:12:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okupS-0003c9-Hd; Tue, 18 Oct 2022 22:12:54 +0000
Received: by outflank-mailman (input) for mailman id 425363;
 Tue, 18 Oct 2022 22:12:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okupR-0003bz-8i; Tue, 18 Oct 2022 22:12:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okupR-0003i4-6L; Tue, 18 Oct 2022 22:12:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okupQ-0005lB-PG; Tue, 18 Oct 2022 22:12:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okupQ-00079B-Om; Tue, 18 Oct 2022 22:12:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=k8A+HI6o7n9TAxVZoaPEtSNCJOLhF0MAP4VYWnBxAqs=; b=yfFodq49AHMJjRr9rCHuxkZz6u
	pirOCwdQOBhC1w92G3qGcXTXM2oKKtEJikkrTCYSdWwJH1IapVwByj889q8AuLup20SU/7135L3hM
	oKmjoKRyD0X70uQsM45BQ+jYG/wucDvfQVeJ314AvbiljrrFhkxle1O2wfSaTExxkOMI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174059-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174059: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 22:12:52 +0000

flight 174059 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174059/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174051

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174051 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174051 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   47 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 18 22:17:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 18 Oct 2022 22:17:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425371.673129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okuuC-0004Hs-7Q; Tue, 18 Oct 2022 22:17:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425371.673129; Tue, 18 Oct 2022 22:17:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okuuC-0004Hl-3X; Tue, 18 Oct 2022 22:17:48 +0000
Received: by outflank-mailman (input) for mailman id 425371;
 Tue, 18 Oct 2022 22:17:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okuuB-0004Hb-3i; Tue, 18 Oct 2022 22:17:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okuuB-0003pD-1v; Tue, 18 Oct 2022 22:17:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okuuA-0006B9-Q4; Tue, 18 Oct 2022 22:17:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okuuA-0001Bs-Pd; Tue, 18 Oct 2022 22:17:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LyFqC9gpTDwVzsLrRNNX3Dr4Fiz2HAhsgHXlhEpjJOM=; b=Y0PG46AdXhREvPCKRJ4ZlUMlUG
	sduBif2lcCk+o+L7NMAXL8P/2UKVqwlwzYfWiwiRAFIv+8i4ao1jcaO3Gh5+X4cJ0GT4NDQwCvgXU
	RA+g3pcj7jiVnLEAhEsZOCZLT2oxvxuXQI6G14dMpWUKCcld35goKQM4CTGPTQNGIWWA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173987-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 173987: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 18 Oct 2022 22:17:46 +0000

flight 173987 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173987/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-raw   7 xen-install      fail in 173904 pass in 173987
 test-amd64-i386-freebsd10-i386  7 xen-install              fail pass in 173904

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   64 days
Failing since        173494  2022-10-11 13:38:08 Z    7 days    9 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    6 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 00:03:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 00:03:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425380.673140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okwY4-0007NN-W3; Wed, 19 Oct 2022 00:03:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425380.673140; Wed, 19 Oct 2022 00:03:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okwY4-0007NG-Sh; Wed, 19 Oct 2022 00:03:04 +0000
Received: by outflank-mailman (input) for mailman id 425380;
 Wed, 19 Oct 2022 00:03:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okwY2-0007NA-PF
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 00:03:02 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 63e7f143-4f41-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 02:02:59 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3028861725;
 Wed, 19 Oct 2022 00:02:58 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9B92C433C1;
 Wed, 19 Oct 2022 00:02:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63e7f143-4f41-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666137777;
	bh=nHU86mjljBt+3asOzaka8GubQM/7jtRpMrtyeaxbU7Y=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=SVH0L2+IR+TL+qk6n4W9mG6MIIgz9BtX6mxxkiaOPSySr/cDAmLpBXg3tdvV45aol
	 DQSjNK8dE3clC0TGLA0fFJWHi7+TosF7aPZARrqAJ/yFajs/YI0626eviTIhRTvqT+
	 7wGlXDT3I+O+pnZkcNYd/emqOYA5acSzcvf3k55XRbY2X2l3MSJtnEaldhxLEE99wy
	 xwSJeuYckybqjJAbf7byg9VeEMYc7LLQzwCc7w+7kZpoE0WKpzuTs2YfagpOTtLKCD
	 hQHwOszUhX+E0qzcSnyrIh+/AKFLrBEVZFRVn5VsMqVulm/LFPb4h4q3FHdaAG3aHm
	 hOpcsBFG4DPsg==
Date: Tue, 18 Oct 2022 17:02:55 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>, michal.orzel@amd.com
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
In-Reply-To: <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
References: <cover.1665561024.git.bertrand.marquis@arm.com> <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop> <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com> <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 17 Oct 2022, Stefano Stabellini wrote:
> It should be
> 
> BB_NUMBER_THREADS="2"
> 
> but that worked! Let me a couple of more tests.

I could run successfully a Yocto build test with qemuarm64 as target in
gitlab-ci, hurray! No size issues, no build time issues, everything was
fine. See:
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/3193051236
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/3193083119

I made the appended changes in top of this series.

- I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
  registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64
- for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
  xen.git, not from a copy stored inside a container
- when building the kirkstone-qemuarm64 container the first time
  (outside of gitlab-ci) I used COPY and took the script from the local
  xen.git tree
- after a number of tests, I settled on: BB_NUMBER_THREADS="8" more than
  this and it breaks on some workstations, please add it
- I am running the yocto build on arm64 so that we can use the arm64
  hardware to do it in gitlab-ci

Please feel free to incorporate these changes in your series, and add
corresponding changes for the qemuarm32 and qemux86 targets.

I am looking forward to it! Almost there!

Cheers,

Stefano


diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
index 0d31dad607..16f1dcc0a5 100755
--- a/automation/build/yocto/build-yocto.sh
+++ b/automation/build/yocto/build-yocto.sh
@@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
 # Save some disk space
 INHERIT += "rm_work"
 
+# Reduce number of jobs
+BB_NUMBER_THREADS="8"
+
 EOF
 
     if [ "${do_localsrc}" = "y" ]; then
diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
index f279a7af92..aea3fc1f3e 100644
--- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
+++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
@@ -16,7 +16,8 @@ ARG target=qemuarm64
 
 # This step can take one to several hours depending on your download bandwith
 # and the speed of your computer
-RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
+COPY ./build-yocto.sh /
+RUN /build-yocto.sh --dump-log $target
 
 FROM $from_image
 
diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
index 367a7863b6..ffbd91aa90 100644
--- a/automation/build/yocto/kirkstone.dockerfile
+++ b/automation/build/yocto/kirkstone.dockerfile
@@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
              /home/$USER_NAME/xen && \
     chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
 
-# Copy the build script
-COPY build-yocto.sh /home/$USER_NAME/bin/
-
 # clone yocto repositories we need
 ARG yocto_version="kirkstone"
 RUN for rep in \
diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index ddc2234faf..4b8bcde252 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
     EXTRA_XEN_CONFIG: |
       CONFIG_BOOT_TIME_CPUPOOLS=y
 
+yocto-kirkstone-qemuarm64:
+  stage: build
+  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
+  script:
+    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
+  variables:
+    CONTAINER: yocto:kirkstone-qemuarm64
+  artifacts:
+    paths:
+      - '*.log'
+      - '*/*.log'
+      - 'logs/*'
+    when: always
+  tags:
+    - arm64
+
 ## Test artifacts common
 
 .test-jobs-artifact-common:


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 00:15:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 00:15:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425386.673150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okwk6-0000VT-3F; Wed, 19 Oct 2022 00:15:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425386.673150; Wed, 19 Oct 2022 00:15:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okwk6-0000VM-0i; Wed, 19 Oct 2022 00:15:30 +0000
Received: by outflank-mailman (input) for mailman id 425386;
 Wed, 19 Oct 2022 00:15:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okwk4-0000VG-Pd
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 00:15:28 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 221b3e97-4f43-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 02:15:27 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 84277B821A9;
 Wed, 19 Oct 2022 00:15:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE917C433B5;
 Wed, 19 Oct 2022 00:15:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 221b3e97-4f43-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666138524;
	bh=6i7KAYuzLBv0qf0M4B6AwUOT+eo1+bQqCOc9SAEYLRs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Io+QfxDfonOBKqwTUft1nb9xK9O8l5Hdqk61KgxQgIg41zaRWM0IPAiMV2gwUg994
	 HqKLJET0l6EZ5K6PsLUw+Atms/XdlnnUX/WC9ipkvfSn25jsGJ7yXdBJwUYWxSozIA
	 4v30wsJgiOuYdpPrmKXwDsmwEIRozJxXd6s5Fol8IP4i1HQLuZy5aQ6tZnd3++1BiW
	 9NLgdq5lagA7sJ3Za2jx8usP+KnuuiBYxMmLlOR33LOxHW+RmSu3FSOQ4q4Vl4SVDe
	 ndTZlJj6fx1tg4CjrLCgJq0+03RQ+T0lQENf+qNMWGOaw0vcA+o0LUj21bW+ShLuVN
	 IkRnjXPNk/5og==
Date: Tue, 18 Oct 2022 17:15:21 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org, 
    stefano.stabellini@amd.com, Peter Maydell <peter.maydell@linaro.org>, 
    Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, 
    "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>, 
    "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
In-Reply-To: <460a480e-4e91-8d78-60da-59b9cc98beee@xen.org>
Message-ID: <alpine.DEB.2.22.394.2210181241320.4587@ubuntu-linux-20-04-desktop>
References: <20221015050750.4185-1-vikram.garhwal@amd.com> <20221015050750.4185-11-vikram.garhwal@amd.com> <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org> <alpine.DEB.2.22.394.2210171345450.2351079@ubuntu-linux-20-04-desktop>
 <460a480e-4e91-8d78-60da-59b9cc98beee@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 18 Oct 2022, Julien Grall wrote:
> On 18/10/2022 02:26, Stefano Stabellini wrote:
> > On Sun, 16 Oct 2022, Julien Grall wrote:
> > > Hi,
> > > 
> > > There seem to be some missing patches on xen-devel (including the cover
> > > letter). Is that expected?
> > > 
> > > On 15/10/2022 06:07, Vikram Garhwal wrote:
> > > > Add a new machine xenpv which creates a IOREQ server to register/connect
> > > > with
> > > > Xen Hypervisor.
> > > 
> > > I don't like the name 'xenpv' because it doesn't convey the fact that some
> > > of
> > > the HW may be emulated rather than para-virtualized. In fact one may only
> > > want
> > > to use for emulating devices.
> > > 
> > > Potential name would be 'xen-arm' or re-using 'virt' but with 'accel=xen'
> > > to
> > > select a Xen layout.
> > 
> > The benefit of 'xenpv' is that it doesn't require any changes to libxl.
> 
> I am quite surprised. Looking at the code, it seems to work more by chance
> than it is intentional as the code is gated by libxl__need_xenpv_qemu(). So it
> would not start if there were no emulated devices.
> 
> > It is even backward compatible so it could be used with an older version
> > of Xen/libxl.
> We don't really gain much here. IOREQ is a tech preview and anyone that wants
> to try it should really use the latest Xen.

I think that's fair.


> > Backward compatibility aside, if we come up with a
> > different name then we'll need changes to libxl and to manage those
> > changes. For instance, if we use 'xen-arm' that would mean we would need
> > to handle per-arch QEMU machine names.
> 
> Right, so the main argument here is for simplicity in libxl

Yeah


> Looking at how 'xenpv' is built, this is really expected to deal with PV
> backend rather than emulated device. I do expect some changes as we go along
> to be able to add emulated device.
> 
> Furthermore, libxl is not the only toolstack out. So I am not convinced this
> is a good argument to keep the name the same.

Let's think some more about the naming strategy. From a QEMU point of
view we could choose any name we like (Vikram please confirm), the issue
is really on the libxl side.

Today libxl understands two QEMU "machines": xenpv and xenfv
(pc,accel=xen is the same as xenfv, I'll use xenfv in this email for
simplicity).

xenpv is for PV guests and only provides PV backends, no emulation. It
is used on both ARM and x86.

xenfv is only used on x86, and it is for HVM guests, with a full set of
emulated hardware (PIIX3, etc.).

The purpose of this series is to introduce a QEMU machine that:
- works on ARM (but could maybe work on other archs as a stretch goal)
- provides PV backends
- no emulated devices by default
- also can emulate selected devices on request

Certainly it is not xenfv or pc,accel=xen because they would with more
emulation by default. This is more like "xenpvh": an extension to PV
with also the capability of emulating one device as requested. It is not
intended to emulate a full PC and doesn't do that by default like xenfv.

If/When x86 PVH gains the ability to use QEMU as IOREQ server, I would
imagine it would run a QEMU machine similar to this one.

This is also how I would imagine it would get integrated in libxl: as a
xenpv + individual emulated devices. Not as HVM for ARM. The other QEMU
command line arguments are inline with the xenpv command line arguments
rather than xenfv command line arguments. This is why the libxl changes
are small to zero to make it work today.

So, I think the following options work:

a) call it "xenpv" because it is an extension of the old xenpv machine
b) call it "xenpvh" because it is PV + few individual emulated devices

If we call it xenpv there are fewer changes in libxl. If we call it
xenpvh there are more changes in libxl but we can distinguish xenpv from
xenpvh (I don't see why we need it right now, but I could imagine it
could turn out useful in the future.)

I would stay away from arch-specific machine names because it will make
it harder on the libxl side without immediate benefits.


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 00:34:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 00:34:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425392.673162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okx2b-0002v3-Mr; Wed, 19 Oct 2022 00:34:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425392.673162; Wed, 19 Oct 2022 00:34:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okx2b-0002uw-Jw; Wed, 19 Oct 2022 00:34:37 +0000
Received: by outflank-mailman (input) for mailman id 425392;
 Wed, 19 Oct 2022 00:34:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okx2Z-0002uq-Vq
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 00:34:35 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cd0e325c-4f45-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 02:34:34 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8DE1E61700;
 Wed, 19 Oct 2022 00:34:32 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F13BC433D7;
 Wed, 19 Oct 2022 00:34:31 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd0e325c-4f45-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666139672;
	bh=wb4kkINtcV5qtL4S9StL2IH6A9wLl3t5eYlT5FECAAk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Nhi2sRc1LiOIKzFUazGNnHfqXWePQFUH4/3cwnRA4bgDYyidr/SqRG6RKA4Hoo7hK
	 XmkKVpNmgsMdlxw9AESSwZBAzN1u8pRkRH/rq8m0G2EszkAlyXEQT6dmCLBtAQOdyG
	 scHe0UF5/HmtJowriInsBTtOpKeOUZGoGcVlcyDLOn52x7JDQEyjr6oR/mHRSg739j
	 NrMejya8vue3wfOFcaLx5wG8FmGs7rkKuejUmrMVWvjUkGJKeqMfwVMReDkXLYCnEi
	 yiIrcb0uDvhg8uGunsSLzOIrcCU70Md2OEp8oPmicxwFrj4YK+2McUgR3APjFad32n
	 Trq/eA+8Vefvg==
Date: Tue, 18 Oct 2022 17:34:29 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Juergen Gross <jgross@suse.com>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
In-Reply-To: <531d3fe0-de24-4aac-f58a-091edbe25a98@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210181732350.4587@ubuntu-linux-20-04-desktop>
References: <20221015153409.918775-1-olekstysh@gmail.com> <alpine.DEB.2.22.394.2210171731110.4587@ubuntu-linux-20-04-desktop> <531d3fe0-de24-4aac-f58a-091edbe25a98@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 18 Oct 2022, Oleksandr Tyshchenko wrote:
> On 18.10.22 03:33, Stefano Stabellini wrote:
> > On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
> >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>
> >> Use the same "xen-grant-dma" device concept for the PCI devices
> >> behind device-tree based PCI Host controller, but with one modification.
> >> Unlike for platform devices, we cannot use generic IOMMU bindings
> >> (iommus property), as we need to support more flexible configuration.
> >> The problem is that PCI devices under the single PCI Host controller
> >> may have the backends running in different Xen domains and thus have
> >> different endpoints ID (backend domains ID).
> > Hi Oleksandr,
> >
> >  From another email I understood that you successfully managed to
> > describe in device tree all the individual virtio pci devices so that
> > you can have iommu-map/iommu-map-mask properties under each virtio
> > device node. Is that right?
> 
> No. Here [1] I mentioned that I had experimented with PCI-IOMMU bindings 
> (iommu-map/iommu-map-mask properties) as IOMMU bindings (iommu property) 
> is insufficient for us and got it worked.
> Also I provided a link to the current patch. Sorry, if I was unclear.
> 
> Just to be clear:
> 
> We do not describe in device-tree all the individual virtio-pci devices 
> (and we do not have to), we only describe generic PCI host bridge node.
> So we have only a *single* iommu-map property under that PCI host bridge 
> node.
> The iommu-map property in turn describes the IOMMU connections for the 
> endpoints within that PCI Host bridge according to:
> https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/pci-iommu.txt
> 
> For the instance, the following iommu-map property under that PCI host 
> bridge node describes the relationship between IOMMU and two PCI devices 
> (0000:00:01.0 and 0000:00:02.0):
> iommu-map = <0x08 0xfde9 0x01 0x08 0x10 0xfde9 0x02 0x08>;
> For 0000:00:01.0 we pass the endpoint ID 1 (backend domid 1)
> For 0000:00:02.0 we pass the endpoint ID 2 (backend domid 2)
> Other PCI devices (i.e 0000:00:03.0) are untranslated (are not required 
> to use grants for the virtio).

That's great! I misunderstood. Actually I wonder if iommu-map might be
suitable also for hotplug devices (as long as the backend domid is known
beforehand). I think that should work? It should be possible to specify
PCI device IDs even if those device IDs are not present yet?

If this work, it could be the best solution actually.
 

> > If that is the case, then I would rather jump straight to that approach
> > because I think it is far better than this one.
> 
> Please see above, I don't have any other approach except the one 
> implemented in current patch.
> 
> [1] 
> https://lore.kernel.org/xen-devel/16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com/
> 
> 
> >
> > Cheers,
> >
> > Stefano
> >
> >
> >
> >> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
> >> properties) which allows us to describe relationship between PCI
> >> devices and backend domains ID properly.
> >>
> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >> ---
> >> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> >> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> >> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> >> than for platform devices.
> >>
> >> Changes V1 -> V2:
> >>     - update commit description
> >>     - rebase
> >>     - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> >>
> >> Previous discussion is at:
> >> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!1mSETxg8CRohlL5OpYo0VaLBXtbWRLZlam9QABMP_YUzsYcrn8no1FxBPvhQnNRCSzp3pkC1dXIgmhdaZmJ3oyV6yWUy3w$  [lore[.]kernel[.]org]
> >>
> >> Based on:
> >> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1__;!!GF_29dbcQIUBPA!1mSETxg8CRohlL5OpYo0VaLBXtbWRLZlam9QABMP_YUzsYcrn8no1FxBPvhQnNRCSzp3pkC1dXIgmhdaZmJ3oyWa-6yyug$  [git[.]kernel[.]org]
> >> ---
> >>   drivers/xen/grant-dma-ops.c | 87 ++++++++++++++++++++++++++++++++-----
> >>   1 file changed, 76 insertions(+), 11 deletions(-)
> >>
> >> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> >> index daa525df7bdc..b79d9d6ce154 100644
> >> --- a/drivers/xen/grant-dma-ops.c
> >> +++ b/drivers/xen/grant-dma-ops.c
> >> @@ -10,6 +10,7 @@
> >>   #include <linux/module.h>
> >>   #include <linux/dma-map-ops.h>
> >>   #include <linux/of.h>
> >> +#include <linux/pci.h>
> >>   #include <linux/pfn.h>
> >>   #include <linux/xarray.h>
> >>   #include <linux/virtio_anchor.h>
> >> @@ -292,12 +293,55 @@ static const struct dma_map_ops xen_grant_dma_ops = {
> >>   	.dma_supported = xen_grant_dma_supported,
> >>   };
> >>   
> >> +static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
> >> +{
> >> +	struct pci_dev *pdev = to_pci_dev(dev);
> >> +	struct pci_bus *bus = pdev->bus;
> >> +
> >> +	/* Walk up to the root bus to look for PCI Host controller */
> >> +	while (!pci_is_root_bus(bus))
> >> +		bus = bus->parent;
> >> +
> >> +	return of_node_get(bus->bridge->parent->of_node);
> >> +}
> >> +
> >> +static struct device_node *xen_dt_get_node(struct device *dev)
> >> +{
> >> +	if (dev_is_pci(dev))
> >> +		return xen_dt_get_pci_host_node(dev);
> >> +
> >> +	return of_node_get(dev->of_node);
> >> +}
> >> +
> >> +static int xen_dt_map_id(struct device *dev, struct device_node **iommu_np,
> >> +			 u32 *sid)
> >> +{
> >> +	struct pci_dev *pdev = to_pci_dev(dev);
> >> +	u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> >> +	struct device_node *host_np;
> >> +	int ret;
> >> +
> >> +	host_np = xen_dt_get_pci_host_node(dev);
> >> +	if (!host_np)
> >> +		return -ENODEV;
> >> +
> >> +	ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask", iommu_np, sid);
> >> +	of_node_put(host_np);
> >> +
> >> +	return ret;
> >> +}
> >> +
> >>   static bool xen_is_dt_grant_dma_device(struct device *dev)
> >>   {
> >> -	struct device_node *iommu_np;
> >> +	struct device_node *iommu_np = NULL;
> >>   	bool has_iommu;
> >>   
> >> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> >> +	if (dev_is_pci(dev)) {
> >> +		if (xen_dt_map_id(dev, &iommu_np, NULL))
> >> +			return false;
> >> +	} else
> >> +		iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> >> +
> >>   	has_iommu = iommu_np &&
> >>   		    of_device_is_compatible(iommu_np, "xen,grant-dma");
> >>   	of_node_put(iommu_np);
> >> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
> >>   
> >>   bool xen_is_grant_dma_device(struct device *dev)
> >>   {
> >> +	struct device_node *np;
> >> +
> >>   	/* XXX Handle only DT devices for now */
> >> -	if (dev->of_node)
> >> -		return xen_is_dt_grant_dma_device(dev);
> >> +	np = xen_dt_get_node(dev);
> >> +	if (np) {
> >> +		bool ret;
> >> +
> >> +		ret = xen_is_dt_grant_dma_device(dev);
> >> +		of_node_put(np);
> >> +		return ret;
> >> +	}
> >>   
> >>   	return false;
> >>   }
> >> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
> >>   static int xen_dt_grant_init_backend_domid(struct device *dev,
> >>   					   struct xen_grant_dma_data *data)
> >>   {
> >> -	struct of_phandle_args iommu_spec;
> >> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
> >>   
> >> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> >> -			0, &iommu_spec)) {
> >> -		dev_err(dev, "Cannot parse iommus property\n");
> >> -		return -ESRCH;
> >> +	if (dev_is_pci(dev)) {
> >> +		if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
> >> +			dev_err(dev, "Cannot translate ID\n");
> >> +			return -ESRCH;
> >> +		}
> >> +	} else {
> >> +		if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> >> +				0, &iommu_spec)) {
> >> +			dev_err(dev, "Cannot parse iommus property\n");
> >> +			return -ESRCH;
> >> +		}
> >>   	}
> >>   
> >>   	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> >> @@ -354,6 +413,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
> >>   void xen_grant_setup_dma_ops(struct device *dev)
> >>   {
> >>   	struct xen_grant_dma_data *data;
> >> +	struct device_node *np;
> >>   
> >>   	data = find_xen_grant_dma_data(dev);
> >>   	if (data) {
> >> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
> >>   	if (!data)
> >>   		goto err;
> >>   
> >> -	if (dev->of_node) {
> >> -		if (xen_dt_grant_init_backend_domid(dev, data))
> >> +	np = xen_dt_get_node(dev);
> >> +	if (np) {
> >> +		int ret;
> >> +
> >> +		ret = xen_dt_grant_init_backend_domid(dev, data);
> >> +		of_node_put(np);
> >> +		if (ret)
> >>   			goto err;
> >>   	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
> >>   		dev_info(dev, "Using dom0 as backend\n");
> >> -- 
> >> 2.25.1
> >>
> -- 
> Regards,
> 
> Oleksandr Tyshchenko
> 


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 00:58:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 00:58:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425398.673173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okxPN-0005Rx-Jg; Wed, 19 Oct 2022 00:58:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425398.673173; Wed, 19 Oct 2022 00:58:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okxPN-0005Rq-GZ; Wed, 19 Oct 2022 00:58:09 +0000
Received: by outflank-mailman (input) for mailman id 425398;
 Wed, 19 Oct 2022 00:58:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1okxPM-0005Rj-6A
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 00:58:08 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16b8c9de-4f49-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 02:58:06 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 885816172E;
 Wed, 19 Oct 2022 00:58:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 308A6C433D6;
 Wed, 19 Oct 2022 00:58:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16b8c9de-4f49-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666141084;
	bh=pnxCyzPm3hjqwJLkvTjMO+xVkN+jfmiHlHruC5BM2xU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=l8P6dB7L/PRrKCfkvtxwg0woenifQcNqkdaxEJJT12zZg+mgPS102pKwLkZWhtf4O
	 J191jNBUX1ZOYGCmKRSQPOo8HfUlEX0gzeo99VYeDnSnTzxxaExkxia0oEhF7DG6ca
	 Y8Q65n3IINzP58lQknYtLnBABCQi4qoaaLpTNT6nJHGDxSl/RtsSJSDZeAbWTwIMCR
	 O4sRFI2PegWbckVWyqub8rAgqKuSaDoKgmeUtjagtKdyYFaso/aCkBbAsiiuJIo9sw
	 20c9yLt26Uq8ctE3ko6HMZL/YAoEKa0wR50NKO8VLpMmVWSorKjPMYCyKy2dk+HS9I
	 rxgF34+Hnfrzw==
Date: Tue, 18 Oct 2022 17:58:01 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
In-Reply-To: <20221015153409.918775-1-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
References: <20221015153409.918775-1-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the same "xen-grant-dma" device concept for the PCI devices
> behind device-tree based PCI Host controller, but with one modification.
> Unlike for platform devices, we cannot use generic IOMMU bindings
> (iommus property), as we need to support more flexible configuration.
> The problem is that PCI devices under the single PCI Host controller
> may have the backends running in different Xen domains and thus have
> different endpoints ID (backend domains ID).
> 
> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
> properties) which allows us to describe relationship between PCI
> devices and backend domains ID properly.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Now that I understood the approach and the reasons for it, I can review
the patch :-)

Please add an example of the bindings in the commit message.


> ---
> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> than for platform devices.
> 
> Changes V1 -> V2:
>    - update commit description
>    - rebase
>    - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
> 
> Based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
> ---
>  drivers/xen/grant-dma-ops.c | 87 ++++++++++++++++++++++++++++++++-----
>  1 file changed, 76 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index daa525df7bdc..b79d9d6ce154 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>  #include <linux/module.h>
>  #include <linux/dma-map-ops.h>
>  #include <linux/of.h>
> +#include <linux/pci.h>
>  #include <linux/pfn.h>
>  #include <linux/xarray.h>
>  #include <linux/virtio_anchor.h>
> @@ -292,12 +293,55 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> +static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
> +{
> +	struct pci_dev *pdev = to_pci_dev(dev);
> +	struct pci_bus *bus = pdev->bus;
> +
> +	/* Walk up to the root bus to look for PCI Host controller */
> +	while (!pci_is_root_bus(bus))
> +		bus = bus->parent;
> +
> +	return of_node_get(bus->bridge->parent->of_node);
> +}

It seems silly that we need to walk the hierachy that way, but I
couldn't find another way to do it


> +static struct device_node *xen_dt_get_node(struct device *dev)
> +{
> +	if (dev_is_pci(dev))
> +		return xen_dt_get_pci_host_node(dev);
> +
> +	return of_node_get(dev->of_node);
> +}
> +
> +static int xen_dt_map_id(struct device *dev, struct device_node **iommu_np,
> +			 u32 *sid)
> +{
> +	struct pci_dev *pdev = to_pci_dev(dev);
> +	u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +	struct device_node *host_np;
> +	int ret;
> +
> +	host_np = xen_dt_get_pci_host_node(dev);
> +	if (!host_np)
> +		return -ENODEV;
> +
> +	ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask", iommu_np, sid);
> +	of_node_put(host_np);
> +	return ret;
> +}
> +
>  static bool xen_is_dt_grant_dma_device(struct device *dev)
>  {
> -	struct device_node *iommu_np;
> +	struct device_node *iommu_np = NULL;
>  	bool has_iommu;
>  
> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +	if (dev_is_pci(dev)) {
> +		if (xen_dt_map_id(dev, &iommu_np, NULL))
> +			return false;
> +	} else
> +		iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +
>  	has_iommu = iommu_np &&
>  		    of_device_is_compatible(iommu_np, "xen,grant-dma");
>  	of_node_put(iommu_np);
> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
>  
>  bool xen_is_grant_dma_device(struct device *dev)
>  {
> +	struct device_node *np;
> +
>  	/* XXX Handle only DT devices for now */
> -	if (dev->of_node)
> -		return xen_is_dt_grant_dma_device(dev);
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		bool ret;
> +
> +		ret = xen_is_dt_grant_dma_device(dev);
> +		of_node_put(np);
> +		return ret;
> +	}

We don't need to walk the PCI hierachy twice. Maybe we can add the
of_node check directly to xen_is_dt_grant_dma_device?


>  	return false;
>  }
> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
>  static int xen_dt_grant_init_backend_domid(struct device *dev,
>  					   struct xen_grant_dma_data *data)
>  {
> -	struct of_phandle_args iommu_spec;
> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
>  
> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> -			0, &iommu_spec)) {
> -		dev_err(dev, "Cannot parse iommus property\n");
> -		return -ESRCH;
> +	if (dev_is_pci(dev)) {
> +		if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
> +			dev_err(dev, "Cannot translate ID\n");
> +			return -ESRCH;
> +		}
> +	} else {
> +		if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> +				0, &iommu_spec)) {
> +			dev_err(dev, "Cannot parse iommus property\n");
> +			return -ESRCH;
> +		}
>  	}
>  
>  	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> @@ -354,6 +413,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>  void xen_grant_setup_dma_ops(struct device *dev)
>  {
>  	struct xen_grant_dma_data *data;
> +	struct device_node *np;
>  
>  	data = find_xen_grant_dma_data(dev);
>  	if (data) {
> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  	if (!data)
>  		goto err;
>  
> -	if (dev->of_node) {
> -		if (xen_dt_grant_init_backend_domid(dev, data))
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		int ret;
> +
> +		ret = xen_dt_grant_init_backend_domid(dev, data);
> +		of_node_put(np);
> +		if (ret)
>  			goto err;
>  	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>  		dev_info(dev, "Using dom0 as backend\n");
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 01:29:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 01:29:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425407.673189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okxt1-0007E1-7L; Wed, 19 Oct 2022 01:28:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425407.673189; Wed, 19 Oct 2022 01:28:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okxt1-0007Du-4F; Wed, 19 Oct 2022 01:28:47 +0000
Received: by outflank-mailman (input) for mailman id 425407;
 Wed, 19 Oct 2022 01:28:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okxt0-0007Dk-FK; Wed, 19 Oct 2022 01:28:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okxt0-0006BG-D9; Wed, 19 Oct 2022 01:28:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okxt0-0000fs-1U; Wed, 19 Oct 2022 01:28:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okxt0-0004Tf-1A; Wed, 19 Oct 2022 01:28:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=84qlbFq5M/fkE6Dl6NoMgS20enGqIDpnqX3x7eNEOmU=; b=BvecEcJ0ohDmUa+edwdHK72sQF
	tTZAtCS1Kubodx6pbdsstnX8FRk7mxTcv0++QEwRgt3Qj1HycvKLAuu9cKup4b9umdZEnvz0GeSgD
	yioergUUkWt3+GvCdG5g1KU70AiwTU7hhJjCBqbo5jrzJilxu50lx5qN7zqYT0e04i8I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174064-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174064: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 01:28:46 +0000

flight 174064 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174064/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174051

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174051 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174051 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   48 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 01:58:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 01:58:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425416.673201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okyM2-0002CV-HM; Wed, 19 Oct 2022 01:58:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425416.673201; Wed, 19 Oct 2022 01:58:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okyM2-0002CO-DV; Wed, 19 Oct 2022 01:58:46 +0000
Received: by outflank-mailman (input) for mailman id 425416;
 Wed, 19 Oct 2022 01:58:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JMjo=2U=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1okyM0-0002CH-I0
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 01:58:44 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2054.outbound.protection.outlook.com [40.107.103.54])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e7c561b-4f51-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 03:58:42 +0200 (CEST)
Received: from AS9PR0301CA0056.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::34) by VI1PR08MB5488.eurprd08.prod.outlook.com
 (2603:10a6:803:137::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 01:58:39 +0000
Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:469:cafe::eb) by AS9PR0301CA0056.outlook.office365.com
 (2603:10a6:20b:469::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Wed, 19 Oct 2022 01:58:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 19 Oct 2022 01:58:39 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Wed, 19 Oct 2022 01:58:38 +0000
Received: from b90bcecbffbf.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 06FDA684-6BA4-492F-BCA5-5F4F1C93FCB2.1; 
 Wed, 19 Oct 2022 01:58:32 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b90bcecbffbf.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 01:58:32 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by PA4PR08MB6111.eurprd08.prod.outlook.com (2603:10a6:102:e3::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 01:58:31 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684%4]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022
 01:58:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e7c561b-4f51-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=jXasIwam82MYKrekQvkIeHb13B2de5cwEud1W8FPZQUHwl/7FpjojB/kla2MZFiWtBbnS+MJc3d3RzGiDuMJwUmgGHiOCmsQhucrsoza1EGXgU05a3bgbtaPm7gh9xpLJnETBKlo2YMPfoPEFYuzW9ZqaRu9oyjhDYHCF79+A92S074ri0p6hnwEZbQ7ASWAtsceDd1cWynqud8QZV1Y4ZkBmPbymOlWMCnNWXlbtGSP6AJut1RpCur7yv8kTj4riZ06ZexE2pgGvrhJ/iphdFcTbWqrM0BP/sefiuaB2P810dVCI/m8Q6C0NmY57xE8Y7jDirZJ4ITJnM260eShrQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i1w6JL9suuS75LD7hgwtYV7oE2h10TSLhKXd1ToEJSU=;
 b=mrYfEmDPJPVEDdRfBacv6zZm5kBLVJJ8y3AuPc+9zVxV8DwaF8X3v7UQly8BIDGh99213kfkLg0a/XxxjuEWd9FppeWZfEdmF4j9MlEEc85smfT/YxIOWR3tefgmocf/btPxAtaZtSaGLhk7WSvPl73kTRyK/LCXp5qBYeTcLDxduyEATVsB9e4COt1IStAyAi5h7OoAGCzRyu3BiNhIaZzHNvma6RpZLd5A1A7QO38WgFb7dtOd+IiTBc8uVslJ7nZuL8gTf2v53TI08gaYyqoVQk02kdPaYqfFxBVIGLs9KBiTH+8PW/hrtrzq8hCKzV1e79Uza5A03ZcIvTYdPg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i1w6JL9suuS75LD7hgwtYV7oE2h10TSLhKXd1ToEJSU=;
 b=7YYQTFLSySlna6tddyqk5XNxM0YzNZ9ZxBsZ+64yc8ftcfXaRwP/zctJCzN026mlwppvtiz97rdHnLAU5Ewz6ABIDVEc/CVjy2hmkFRd2Ag4GZjafou1ZiBDhy0DT0owIQxL3Bal2/blfbg399dePvd1TMD2tN9QBm6jZ51Koj4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i5p6j9N5HKRJJO5Br83OSDI4Qi4/htLYWuvZqhHLcdo2PBzePdbDDZEAtsFihMcWZt6BUD3rkm9/2rWn9YZVI8ROaQhj2J3EafWLrAILwwYfmai3D139Ob1feNsfRczdwRZaN5Egpf7RADwIPOf1opy6PGwBzAM9ft7CHogNCAbIqoWwgEbFGBTPy7KZEJ0IDRqZtfUGAev2H8jERAuOPPyLKQjx5nopvhrgg6fCZpITdlazmaZNYwIT0agygO9dXhmSJlnZrkexyZVBjbRZ/zeIGrmXt31NCrOH2pQofxYZttKn6F5yhtW67gwYZJrvAO+OD08TklTcZrR0+K/2xA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i1w6JL9suuS75LD7hgwtYV7oE2h10TSLhKXd1ToEJSU=;
 b=cXbILwK/oHxMr3jfz2u0zDDvoiSBhTDRULjd5Juj9bpjBJmQNUDG0EVUYcVXI6k0/QastCqTFMV5kMWA0o/vT0n4jB6RfjsJhkUnO2zRDTFHFJol1kqZYzcjZhPIy9rWl5hezZz2w06v5Bt2E0FEuLaySD6bhEHYgPnWJ1VRoP3I1wG2BV9gy1lsIV/N/GzDAWcrX86nTgYDAVPpz4TNfjYHh65c4HoK/29Uov6d9cCMkq+Sa8k/pWwS17yaC41p2oFlVq8t+2+E0EvGH+OsM1cJrLvpNrZc5W7LrJqJpufhi+e4cOJwXLi9sG4gqpqvsj7xgML+78vkX4fHQZJGbw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i1w6JL9suuS75LD7hgwtYV7oE2h10TSLhKXd1ToEJSU=;
 b=7YYQTFLSySlna6tddyqk5XNxM0YzNZ9ZxBsZ+64yc8ftcfXaRwP/zctJCzN026mlwppvtiz97rdHnLAU5Ewz6ABIDVEc/CVjy2hmkFRd2Ag4GZjafou1ZiBDhy0DT0owIQxL3Bal2/blfbg399dePvd1TMD2tN9QBm6jZ51Koj4=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Index: AQHY3WMXl9OYk9SO1UmCbrdWlsAFLa4UNRwAgADISRA=
Date: Wed, 19 Oct 2022 01:58:31 +0000
Message-ID:
 <PAXPR08MB7420E9ABED55E0554D3C33689E2B9@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
 <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
In-Reply-To: <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 2DF0A0D97B820C428AF7BA898D287AB7.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	PAXPR08MB7420:EE_|PA4PR08MB6111:EE_|AM7EUR03FT020:EE_|VI1PR08MB5488:EE_
X-MS-Office365-Filtering-Correlation-Id: c18c830f-c655-4336-dc69-08dab17570fb
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4473X6TPDuTRN/nhjpUyqLIAu+lqfhFHATpWp0yACD8jSn9uo6F8GcerwpcZa7+m1XW4WLdQjdwkbFUz57DVkjG8KEkuiGXsE77NpDJdDKM615l8olGCrk+9K4C/JkO4GvQP2wIUrydFK93uw4zs4atyPCV7ItemjM5o5FgHFNx7eSFF2hgIxunhhESFSAYhwPD+3LdI3dg7895k544FZM4oU1gzvVispyHLQjRjT5ygmJesmpYOhesVWuYyWZTE3Ksop+tvr1cm1Evi5khSbpAvshmQyHOdBiF+lsWeyr+mOiLouoB7/mpSZFt3nUoOcAYaoPQv/F0FGOFb4GexOvDBfdHQy0x4QEw/f8AQF1mPK/YgyqAUtVeI+19He+nNhtyobS+rlhnQ8pSni+TeyOlUG/jdp0UGIig17HFnBbklCBEknmiLP6OTcIQOjm9MO10YghQxXMH1dEI/XnJQRtSl8H51CUseYk30iahFtjy4IrgOZDNBeBgz1ljaKcHQSKaR97k/HTBCmTeeza8qMnW+WUl7vnykDk+pgjxqFlGQ9ortND7O42yXZ5IsosCcEFScpQIqv4kJFv4ttTe3899ojN41ul6IB1Xhyqv2iW8kpO/eUngw5S/dJLlHyt4jfNtVA7GlMgbp/TWpEmYOm5jsg+b0Y4RgFuyVIyX+si8R//Zs3BbZQzcKoLVqZjvX9cItvK4pyrUBWD1SK51z39/lRQDWQ9WPxQkhVVKSPCZDjoIVyjp5QR9T6UbUJqERu8Agv3kFRaBdMqsoCOkBAg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(451199015)(52536014)(316002)(33656002)(41300700001)(38100700002)(83380400001)(38070700005)(8676002)(64756008)(66946007)(2906002)(8936002)(4326008)(5660300002)(76116006)(55016003)(6916009)(66556008)(71200400001)(66476007)(66446008)(54906003)(186003)(9686003)(26005)(122000001)(86362001)(7696005)(53546011)(6506007)(478600001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6111
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	78de2a19-d5cd-4530-c928-08dab1756c33
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dqc13WS6+NbD0dLcUxLsgCoyZNE8uvUEygihYjgDOx9Plf1Tec5/j8/mjZzpIjuZeEGMX5ziXabwcMew+hPR0yuKRCeXdihT1g1s82OFB/fTDXcrCl/hm3jjnOhKwP07/byiztOiiD/cfbSd7uyoRrH7fLHPtQgWKVUdeuPl2r7u20TTKPVeEPT3BqtKC22n9o09IfA3dQj6RpBSFN779LsLdRj6yjGFvumpYUQSHBWwg033ajW6JKsBO8PE+tH900YK9HJrTCBwTuYLDjnfZ4xNtzFsRR/MV5bUGU8AUB6d/MEkWhk93Zjc+1WKtYRBXVnHM+CGW5w5z30psYTPzyEUAPnqO95DI9snZh+xIykeOmZ/lzoU4/RIozA71ZhBR+hQVbQSDVXqzwGcFEJo6VOdIgYqnbXYKv2riNYYifLForeqMkWQH2em7fEF1Fu1MDV+B4VtjePWMciCGylsvDxeob6gVFeQpRbWH0v/95GP5U06VgqrrYolO2/r/cIn0FOVHcogtiWKrffrpcK7/Zm8IVkut2+pqgTA8m5X4L+aJJCpIgB/pkHG6XtfFdWBmqnkFqvwa1KzLv79xkWFxPQA1e0CsfIzYXtvcDSMRYL2TzF4jhmN9L+IiagviDwzRRvtY2jIdtkHx0kG7iHpKW/x1i36JXs/3qcEMAyGWA6za8LTjLWs7ImoOhs8go9HPAZb52NJi6pJi+m6sTiYwDnt7okvBhJ9wWBfWKe6B+Q1UjlVy3dXSG4uCNFE/a7y7zi4bHV17+DRr/gfVIXkww==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(356005)(81166007)(47076005)(52536014)(86362001)(9686003)(5660300002)(8936002)(33656002)(6862004)(41300700001)(7696005)(6506007)(70586007)(53546011)(70206006)(26005)(40460700003)(40480700001)(4326008)(55016003)(8676002)(336012)(82310400005)(186003)(54906003)(2906002)(316002)(36860700001)(478600001)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 01:58:39.0565
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c18c830f-c655-4336-dc69-08dab17570fb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5488

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEw5pyIMTjml6UgMjE6NDYN
Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+
OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vv
cmdlIER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs
Lm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BB
VENIIHY2IDIvNl0geGVuL3g4NjogbW92ZSBnZW5lcmljYWxseSB1c2FibGUgTlVNQSBjb2RlDQo+
IGZyb20geDg2IHRvIGNvbW1vbg0KPiANCj4gT24gMTEuMTAuMjAyMiAxMzoxNywgV2VpIENoZW4g
d3JvdGU6DQo+ID4gdjUgLT4gdjY6DQo+ID4gIDEuIFJlcGxhY2UgbnVtYV9zY2FuX25vZGUgdG8g
bnVtYV9wcm9jZXNzX25vZGVzIGluIGNvbW1pdCBsb2cuDQo+ID4gIDIuIExpbWl0IHRoZSBzY29w
ZSBvZiBwYWdlX251bV9ub2RlLCB2bnVtYSBhbmQgcGFnZSBvZiBudW1hX3NldHVwDQo+ID4gICAg
IGZ1bmN0aW9uLg0KPiA+ICAzLiBVc2UgbWVtc2V0IHRvIGluaXQgcGFnZV9udW1fbm9kZSBpbnN0
ZWFkIG9mIGZvcl9lYWNoX29ubGluZV9ub2RlLg0KPiA+ICA0LiBVc2UgJXUgaW5zdGVhZCBvZiAl
ZCBmb3Igbm9kZWlkX3QgYW5kIGogaW4gbnVtYV9zZXR1cCBwcmludA0KPiA+ICAgICBtZXNzYWdl
cy4NCj4gDQo+IFRoZSBvbmx5IGluc3RhbmNlcyBvZiBub2RlaWRfdCB0eXBlZCB2YXJpYWJsZSB1
c2VzIHRoYXQgSSB3YXMgYWJsZSB0bw0KPiBmaW5kIGFyZSBpbiBkdW1wX251bWEoKS4gSSBndWVz
cyB5b3UgY2FuIGxlYXZlIHRoZW0gdGhhdCB3YXksIGJ1dA0KPiBzdHJpY3RseSBzcGVha2luZyAl
dSBpc24ndCBjb3JyZWN0IHRvIHVzZSBmb3Igbm9kZWlkX3QgKGFzIGl0IHByb21vdGVzDQo+IHRv
IGludCwgbm90IHRvIHVuc2lnbmVkIGludCkuDQoNCkluIHRoaXMgY2FzZSwgSSB3aWxsIHJlc3Rv
cmUgdGhlbSB0byAlZC4NCg0KPiANCj4gPiAgNS4gVXNlIG1pbihQQUREUl9CSVRTLCBCSVRTX1BF
Ul9MT05HIC0gMSkgdG8gY2FsY3VsYXRlIHRoZSBzaGlmdA0KPiA+ICAgICB3aGVuIG9ubHkgb25l
IG5vZGUgaXMgaW4gdGhlIHN5c3RlbS4NCj4gDQo+IFRoaXMgY2hhbmdlIG5lZWRzIG1lbnRpb25p
bmcgLyBqdXN0aWZ5aW5nIGluIHRoZSBkZXNjcmlwdGlvbi4NCj4gDQoNCg0KSSB3aWxsIGRvIGl0
Lg0KDQo+ID4gK3N0YXRpYyB2b2lkIGNmX2NoZWNrIGR1bXBfbnVtYSh1bnNpZ25lZCBjaGFyIGtl
eSkNCj4gPiArew0KPiA+ICsgICAgc190aW1lX3Qgbm93ID0gTk9XKCk7DQo+ID4gKyAgICB1bnNp
Z25lZCBpbnQgaSwgaiwgbjsNCj4gPiArDQo+ID4gKyAgICBwcmludGsoIk1lbW9yeSBsb2NhdGlv
biBvZiBlYWNoIGRvbWFpbjpcbiIpOw0KPiA+ICsgICAgZm9yX2VhY2hfZG9tYWluICggZCApDQo+
ID4gKyAgICB7DQo+ID4gKyAgICAgICAgY29uc3Qgc3RydWN0IHBhZ2VfaW5mbyAqcGFnZTsNCj4g
PiArICAgICAgICB1bnNpZ25lZCBpbnQgcGFnZV9udW1fbm9kZVtNQVhfTlVNTk9ERVNdOw0KPiA+
ICsgICAgICAgIGNvbnN0IHN0cnVjdCB2bnVtYV9pbmZvICp2bnVtYTsNCj4gPiArDQo+ID4gKyAg
ICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7DQo+ID4gKw0KPiA+ICsgICAgICAgIHBy
aW50aygiRG9tYWluICV1ICh0b3RhbDogJXUpOlxuIiwgZC0+ZG9tYWluX2lkLA0KPiBkb21haW5f
dG90X3BhZ2VzKGQpKTsNCj4gDQo+IFBlcmhhcHMgc3dpdGNoIHRvIHVzaW5nICVwZCBoZXJlPw0K
PiANCg0KRGlkIHlvdSBtZWFuICVkIGZvciBkLT5kb21haW5faWQgaGVyZT8NCg0KPiA+ICsgICAg
ICAgIG1lbXNldChwYWdlX251bV9ub2RlLCAwLCBzaXplb2YodW5zaWduZWQgaW50KSAqIE1BWF9O
VU1OT0RFUyk7DQo+IA0KPiBTaW1wbHkgKGFuZCBsZXNzIGZyYWdpbGUpIHNpemVvZihwYWdlX251
bV9ub2RlKT8NCg0KT2suDQoNClRoYW5rcywNCldlaSBDaGVuDQoNCj4gDQo+IEphbg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 02:18:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 02:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425422.673212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okyeg-00050s-3E; Wed, 19 Oct 2022 02:18:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425422.673212; Wed, 19 Oct 2022 02:18:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okyef-00050l-Vj; Wed, 19 Oct 2022 02:18:01 +0000
Received: by outflank-mailman (input) for mailman id 425422;
 Wed, 19 Oct 2022 02:18:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JMjo=2U=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1okyed-00050f-Rr
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 02:18:00 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140080.outbound.protection.outlook.com [40.107.14.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f2f4a1a-4f54-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 04:17:57 +0200 (CEST)
Received: from AM6P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::37)
 by GV2PR08MB8076.eurprd08.prod.outlook.com (2603:10a6:150:7a::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Wed, 19 Oct
 2022 02:17:55 +0000
Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::6e) by AM6P194CA0024.outlook.office365.com
 (2603:10a6:209:90::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend
 Transport; Wed, 19 Oct 2022 02:17:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 19 Oct 2022 02:17:54 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Wed, 19 Oct 2022 02:17:53 +0000
Received: from ec8b72b553d5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AEA02377-BD64-47BC-9BA3-8AB218A67891.1; 
 Wed, 19 Oct 2022 02:17:47 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec8b72b553d5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 02:17:47 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by GV2PR08MB8194.eurprd08.prod.outlook.com (2603:10a6:150:74::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 02:17:37 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684%4]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022
 02:17:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f2f4a1a-4f54-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ZlBH6yT+3xky3s5qP4cvVTjGXjMLDgNCtvnR2bCRtoStHJFvpGqoOjMUuzB4hXOcMqj4Cdvmhxob2FcisOH11Rid1H6mIpuUZiksGUiTumzjGr0pB0t1L12pbYWkjilB2ITwtGJAcLM9da2FPv2LxnQ1ZFKzBDEsjW4nOgcqYS5YKfT9UfLTXcBiJBQMwr5PpFmLNJYKH1czdHCM8dOwTT6ZSfcJq3C7XjV1mFjLRAQgmSXvjLu0ch/8iWC4nDKPWIXKnIW4ODkKtKcW6F2z53afcDlTbVldBuuB6sjr5A+YN3SqmfinnKYQNeZ2PJnnHgzErFhJkvSevRA7tzMJTQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XURcNgy3MkV74ZAjLI3+lIYyiOJT9nfVQUYsk9XBMWo=;
 b=SvKHzB9FiEFL2QjcTbAY7o4FOCHoSXwuoT3atABReYaZa4Q2iL4cea5uX8iQ7wQTsRSuybyl9B1uGeYeXSpP/1uo7UYMFtT/Nmd7bFKRSTdgSgbM1dSjYToa3WPkSXuY/pqT7poIpmayvTF12w0P994MVIBPlHi4ibyHTUvjbBikhI2zAaFDZpPa2VepnYIYCAZT7QWBz4t7CbdzA4akBHW6Ki/NTg3Lf+p6iSBy+bKJqP4e21km3ls+eSC+h0cIHA9ENuCYbGQXgyN+fFbp6su8VaTrbbTC8iTiqLWbm0G513AryYmbfZE2nr+RXyrv5KAMXVo0kLpS4R5dL27iNw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XURcNgy3MkV74ZAjLI3+lIYyiOJT9nfVQUYsk9XBMWo=;
 b=Ao53vf7hWg9/wHvpSp6ND8scMXrsahuz4tqzvldW52U3hk239vBBBgaPO4+YKPTIQNuTnZxaiWt6UKs7CTc/nE/EMJxfHdbWNOYM/zanuK6g/gDJljBeFnzQD1phZIZrEFKOm+dHggu2Qeozhe7PRfprsrT1QIyCDPD8x2Vi2w8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nP/vv35EVLdXXevQnoleV7uOX0+W48QHK175iSRFFOXoNLwNVLLO/oQHxXL9LSSMCkMOYqcm7OoKnDGTcLUUMjrze2JJ9hk87M2WD7NeES8rBKZyKFltLAHDEVZRRx18oc8a4Js9SqwWCst02ijRT0gd7fzTvb1e2mNctKIe4o0x2bnc6yLkYqRvjO2Mf5eCU8BPga4OqOVN1AmyGUAhSFEC0PHFlmvfsT+9X1u2f1SNwU6O/YnrIX99Owa/i4deSxsMNw06SfPNbCFzK8g/6DgO9h5niZLxLuBMw/68GmCQX4HM+++f4HFQ5MRBgziMGstjCfTrojhwLTPi6IAUUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XURcNgy3MkV74ZAjLI3+lIYyiOJT9nfVQUYsk9XBMWo=;
 b=hgnqxuH8U0lK9FtAni8+zUpFbyGlxI6FLgPw2yLbPzMXZgs/4PoG3TOGgovUwwzmye6zzzj2qcAt3SKx4lml2ayGe5FP+DSZgoQNKo3Eo2A5AugRXGFmRmAzCZz5mml3lwVq+w1Y2wOjkp6jZVJ2LAGntGyjdto0AVUsAnQG5MaXC7L/Zt7nqYEXV5NoAhSVm4TSvpEiFwJF3mJwCmKfYjpB+x24kNcFxo/PpWJ6EJI3N8cPsVMUb57eNJnbg1sANtKqx8XckeSQsId/XSt3tRJkUG2q1+xuHXKEVyGR924uM1C+2FWTjg7nxmLSiYleQNq2+QoQWaeWN7WcMfgIPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XURcNgy3MkV74ZAjLI3+lIYyiOJT9nfVQUYsk9XBMWo=;
 b=Ao53vf7hWg9/wHvpSp6ND8scMXrsahuz4tqzvldW52U3hk239vBBBgaPO4+YKPTIQNuTnZxaiWt6UKs7CTc/nE/EMJxfHdbWNOYM/zanuK6g/gDJljBeFnzQD1phZIZrEFKOm+dHggu2Qeozhe7PRfprsrT1QIyCDPD8x2Vi2w8=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v6 5/6] xen/x86: move NUMA process nodes nodes code from
 x86 to common
Thread-Topic: [PATCH v6 5/6] xen/x86: move NUMA process nodes nodes code from
 x86 to common
Thread-Index: AQHY3WMd/F6kSYZvakmE40WWtzpE9K4UO1IAgADGeHA=
Date: Wed, 19 Oct 2022 02:17:37 +0000
Message-ID:
 <PAXPR08MB7420DD4B01123A16896BDA7D9E2B9@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-6-wei.chen@arm.com>
 <298666d7-f007-fb3e-99ab-18b01ad48b00@suse.com>
In-Reply-To: <298666d7-f007-fb3e-99ab-18b01ad48b00@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 9343258818AE7D4F88472CD565157A6C.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	PAXPR08MB7420:EE_|GV2PR08MB8194:EE_|VI1EUR03FT017:EE_|GV2PR08MB8076:EE_
X-MS-Office365-Filtering-Correlation-Id: 5d1b06f2-942a-4b03-af9e-08dab1782169
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6gn70GKFLAsg+50P1nq3I+6HxjsB00mq9J/79n1nf1UPS1dTzSOnTgVOQTe6/Kua67w31BSWA0uEfcZXv3li0vdDHxpCq0EvXq3lbi7XywpDqCTde59Y8kISdb/FYQ1iisg3NLxssZa2oR5VsdtlZGCt20KbcJVSY46BU8cDhClAT7v8iOogjY2rP5gFg2H6tDQ4V+3v0H79MGDsYlV7WrXxU7WPbWAscs1tuxpJfTWuwib1+B5jJHKNK98o7rFvkZTu04WYUWgJoC8SAy9BbAeNRcVsyV7BPkNrdCETysCorvPvZ50cHPpSvdBkGuni0kgGTiQnDbIW1Bgr/+OvGzahNz0BV/NjpKFTzKagUszYKslMUzPGPFiPJTTw1VRy/ZGwM17MKVfML8/JAVsQluXK9LpSRtF6rnLZtnLAlkNJlhcnTdZ8wS2koiVHgD8Z2frJf1SorS40OmAv6nDGvbFk5DVSmmXjfua994i0EJavjNWVT6FVOnako++Jgj27gfJ7P8Jyvu1qqf0XaZczeONhGAhW9VBGLUvpatQhG54JD2FRL1dPtYe2EjJVh63QpIsddPnChpzLgS3mgS96U5OUKHLYywTOtPsFL8ebmdsuHfnV/BvVsuopH35xvdcN4N3nqTPPysdrEnT5I590lEfTxWDTJO3k0g6XTLZAGtezYg2Q/DntShNbN1NOZesgZGsVZ4aJKu0pKqdFvmSL0QJG3aTpLVlvOug63vrs0QL8tDwvU2zgXgbCx0rGAp1sXjBZVqTnHW2TYdGOR097Mw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199015)(33656002)(86362001)(9686003)(38070700005)(7696005)(6506007)(26005)(8676002)(122000001)(66446008)(64756008)(2906002)(66476007)(66556008)(4326008)(8936002)(38100700002)(41300700001)(52536014)(5660300002)(76116006)(66946007)(55016003)(83380400001)(316002)(54906003)(186003)(6916009)(53546011)(478600001)(71200400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8194
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fd63c3ac-b847-47e0-bb17-08dab178179d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	k+S5ITa3BHTqLke9NWVLZiqVcIpOXgQtXPyEfk/0pmM5jMsWqp9WIGUXRyDQZ3GtwnO0Lvom3iTLmd5hsgGPKyLG2wYYBzq9QKx0tm5dhBNrkvjpvEzw6wACyiLXSwsW0ZC4Ci2+cW58+bsxKgDxh1ma2yoQKQ0tnDqubu1zYnwmwW89R5CSI2IHwJ9z1DIrARgL/+uRwbSpJ7rLKBdNeJ+WA6TYTALhPGJmXYjO84Io0N6n4q9NYkjFE/xEIsr8NJe6TYW6dbDspL58NyN26So3Dir/DbDbq143rOXA1dv8XR6T/TGuUMA0bd/aXo50Yb10cbvXzYlPNiwESF4fwDoo9HPcxv+9NieuK6Cab9X/Wh0fxFydB8lh2oWTPPNcF9JmCQpBtKbxnuTiGCHjRL5e+31F+t+0mDHThl4gnUNCY//l3bCVvx/VVvovrRYzL/YB+WVRtoQlGh5rIKWUeR8N7wJDvJ5kjgdw9vJndOyNcvIAhErNwMuX5PCQgBMWgxVrt4Uv6R5xon6JVve81aj7WsloHI4qtV1h6MHDFbXuM2Bzg82MybKcSy4+lBiYCnJS6SnghCE3Qrhgy42+NXNfiLXd0lJy37B6ihL8p8uL60odTgtpz4OchDKK955b538u2Yr/OKlGBFkwoUPPmsCtZLJgAJh6S48TGomAAcSJhgusT7Qhqnqbk/EnFfAV07enNO4Bqooh9uooBzPKM+QnAXyfrsghA1c0xli3z4WeokiLApVoW7eloIOXY3b6T5Yl8OD/paWfPwC1Q0s8aQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(478600001)(4326008)(8676002)(33656002)(70586007)(70206006)(8936002)(86362001)(6862004)(5660300002)(316002)(2906002)(336012)(186003)(40460700003)(52536014)(7696005)(9686003)(41300700001)(83380400001)(6506007)(26005)(356005)(82310400005)(81166007)(47076005)(36860700001)(53546011)(54906003)(40480700001)(82740400003)(55016003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 02:17:54.0019
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d1b06f2-942a-4b03-af9e-08dab1782169
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8076

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEw5pyIMTjml6UgMjI6MDgN
Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+
OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vv
cmdlIER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs
Lm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BB
VENIIHY2IDUvNl0geGVuL3g4NjogbW92ZSBOVU1BIHByb2Nlc3Mgbm9kZXMgbm9kZXMgY29kZQ0K
PiBmcm9tIHg4NiB0byBjb21tb24NCj4gDQo+IE9uIDExLjEwLjIwMjIgMTM6MTcsIFdlaSBDaGVu
IHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9hcmNoL3g4Ni9udW1hLmMNCj4gPiArKysgYi94ZW4vYXJj
aC94ODYvbnVtYS5jDQo+ID4gQEAgLTQ2LDYgKzQ2LDExIEBAIGJvb2wgYXJjaF9udW1hX2Rpc2Fi
bGVkKHZvaWQpDQo+ID4gICAgICByZXR1cm4gYWNwaV9udW1hIDwgMDsNCj4gPiAgfQ0KPiA+DQo+
ID4gK2Jvb2wgYXJjaF9udW1hX3VuYXZhaWxhYmxlKHZvaWQpDQo+IA0KPiBfX2luaXQgPw0KDQpZ
ZXMsIHRoaXMgZnVuY3Rpb24gd2lsbCBvbmx5IGJlIGNhbGxlZCBpbiBhbiBpbml0IGZ1bmN0aW9u
Lg0KSSB3aWxsIGFkZCBpdC4NCg0KPiANCj4gPiBAQCAtMzEsMTEgKzQ2LDMzNCBAQCBub2RlbWFz
a190IF9fcmVhZF9tb3N0bHkgbm9kZV9vbmxpbmVfbWFwID0geyB7IFswXQ0KPiA9IDFVTCB9IH07
DQo+ID4NCj4gPiAgYm9vbCBfX3JvX2FmdGVyX2luaXQgbnVtYV9vZmY7DQo+ID4NCj4gPiArY29u
c3QgY2hhciAqX19yb19hZnRlcl9pbml0IG51bWFfZndfbmlkX25hbWUgPSAiTk9OQU1FIjsNCj4g
DQo+IERpZG4ndCB5b3UgbWVhbiB0byBsZWF2ZSB0aGlzIGF0IE5VTEwgZm9yIHRoZSBEVCBjYXNl
PyAoQnV0IHllcywgdGhpcw0KPiB3YXkgeW91IGF2b2lkIGEgY29uZGl0aW9uYWwgYXQgZXZlcnkg
cHJpbnRrKCkgdXNpbmcgaXQuKQ0KPiANCg0KWWVzLg0KDQo+IEknbSBhbHNvIHVuY2VydGFpbiBv
ZiAiTk9NQU1FIiAtIHBlcnNvbmFsbHkgSSB0aGluayBlLmcuICI/Pz8iIHdvdWxkDQo+IGJlIGJl
dHRlciwganVzdCBpbiBjYXNlIGEgbWVzc2FnZSBhY3R1YWxseSBpcyBsb2dnZWQgd2l0aCB0aGlz
IHN0aWxsDQo+IHVuLW92ZXJyaWRkZW4uDQo+IA0KDQpPaywgSSB3aWxsIHVzZSAiPz8/IiBmb3Ig
dGhpcyBkZWZhdWx0IHZhbHVlLg0KDQo+ID4gK2Jvb2wgX19pbml0IG51bWFfdXBkYXRlX25vZGVf
bWVtYmxrcyhub2RlaWRfdCBub2RlLCB1bnNpZ25lZCBpbnQNCj4gYXJjaF9uaWQsDQo+ID4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHN0YXJ0LCBwYWRkcl90
IHNpemUsIGJvb2wNCj4gaG90cGx1ZykNCj4gPiArICAgIG5vZGVfbWVtYmxrX3JhbmdlW2ldLnN0
YXJ0ID0gc3RhcnQ7DQo+ID4gKyAgICBub2RlX21lbWJsa19yYW5nZVtpXS5lbmQgPSBlbmQ7DQo+
ID4gKw0KPiA+ICsgICAgbWVtbW92ZSgmbWVtYmxrX25vZGVpZFtpICsgMV0sICZtZW1ibGtfbm9k
ZWlkW2ldLA0KPiA+ICsgICAgICAgICAgICAobnVtX25vZGVfbWVtYmxrcyAtIGkpICogc2l6ZW9m
KCptZW1ibGtfbm9kZWlkKSk7DQo+ID4gKyAgICBtZW1ibGtfbm9kZWlkW2ldID0gbm9kZTsNCj4g
PiArDQo+ID4gKyAgICBpZiAoIGhvdHBsdWcgKSB7DQo+IA0KPiBOaXQ6IFBsYWNlbWVudCBvZiBi
cmFjZS4NCj4gDQoNCk9rLg0KDQo+ID4gLS0tIGEveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4g
PiArKysgYi94ZW4vY29tbW9uL3BhZ2VfYWxsb2MuYw0KPiA+IEBAIC0xNTksNiArMTU5LDggQEAN
Cj4gPiAgI2RlZmluZSBQR1RfVFlQRV9JTkZPX0lOSVRJQUxJWkVSIDANCj4gPiAgI2VuZGlmDQo+
ID4NCj4gPiArcGFkZHJfdCBfX3JlYWRfbW9zdGx5IG1lbV9ob3RwbHVnOw0KPiANCj4gTm90IF9f
cm9fYWZ0ZXJfaW5pdD8NCg0KSSB3aWxsIGFkZCBpdC4NCg0KVGhhbmtzLA0KV2VpIENoZW4NCg0K
PiANCj4gSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 03:13:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 03:13:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425433.673235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okzW4-0002r4-91; Wed, 19 Oct 2022 03:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425433.673235; Wed, 19 Oct 2022 03:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1okzW4-0002qx-6H; Wed, 19 Oct 2022 03:13:12 +0000
Received: by outflank-mailman (input) for mailman id 425433;
 Wed, 19 Oct 2022 03:13:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okzW3-0002qn-Bf; Wed, 19 Oct 2022 03:13:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okzW3-000067-6p; Wed, 19 Oct 2022 03:13:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1okzW2-0007dU-LQ; Wed, 19 Oct 2022 03:13:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1okzW2-0000Lz-Ku; Wed, 19 Oct 2022 03:13:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+cDvdmOM1YZpCEfh3j039VibEu+v6GJaEkHTKkdClo0=; b=18GdGbIH+N7BeyRlfrQ1Zd/glr
	rL7sPGqnx58lqxU+QEHGl+dQZOErzbZQu/3JAHrqsdKd70V28wQCOwR/RFA6Vil2SVQxuFBLul571
	kXpgzP2NpgJeYISEuDnjhKg7ZPzLZDXr9sadYMICjkh9jisscB/kPwSmeiwZIO8R8xuw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-173986-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 173986: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 03:13:10 +0000

flight 173986 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173986/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-amd64-i386-qemuu-rhel6hvm-amd  7 xen-install          fail pass in 173882

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   61 days
Testing same since   173493  2022-10-11 13:07:01 Z    7 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 04:07:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 04:07:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425449.673270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol0Mi-0008Q0-LX; Wed, 19 Oct 2022 04:07:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425449.673270; Wed, 19 Oct 2022 04:07:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol0Mi-0008Pt-Ig; Wed, 19 Oct 2022 04:07:36 +0000
Received: by outflank-mailman (input) for mailman id 425449;
 Wed, 19 Oct 2022 04:07:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol0Mh-0008Pj-7W; Wed, 19 Oct 2022 04:07:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol0Mh-0001AN-5i; Wed, 19 Oct 2022 04:07:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol0Mg-0002Mz-TT; Wed, 19 Oct 2022 04:07:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol0Mg-0001cn-Sy; Wed, 19 Oct 2022 04:07:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CMuLSnEzZTNdW7haPbmEPjBnxxUwk9INd5SOYXXWIOI=; b=GuueOPbi2g9M8zXRNbiibRZFkp
	ivAALw/TyYUvlfkig3E74eRkOPPVB/oWyouVShiDrOFwGLKzE7YveauTkEE0ogyiAeJq42acwwi/i
	eQ0KtPIHLdYyyS9DVePAhEcIWLhj7Rq8QLJdPrG9GDS4NOtE1zZyQt43YCp7VEalnhm0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174066-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174066: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 04:07:34 +0000

flight 174066 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174066/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174051

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174051 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174051 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   49 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 04:53:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 04:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425461.673287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol15J-0005NA-Cl; Wed, 19 Oct 2022 04:53:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425461.673287; Wed, 19 Oct 2022 04:53:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol15J-0005N3-8N; Wed, 19 Oct 2022 04:53:41 +0000
Received: by outflank-mailman (input) for mailman id 425461;
 Wed, 19 Oct 2022 04:53:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7E7d=2U=gmail.com=liu.denton@srs-se1.protection.inumbo.net>)
 id 1ol15I-0005Mx-0b
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 04:53:40 +0000
Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com
 [2607:f8b0:4864:20::1033])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fdfd7d9e-4f69-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 06:53:38 +0200 (CEST)
Received: by mail-pj1-x1033.google.com with SMTP id cl1so15929896pjb.1
 for <xen-devel@lists.xenproject.org>; Tue, 18 Oct 2022 21:53:37 -0700 (PDT)
Received: from generichostname (136-25-1-99.cab.webpass.net. [136.25.1.99])
 by smtp.gmail.com with ESMTPSA id
 d7-20020a170902654700b0017c3776634dsm9639571pln.32.2022.10.18.21.53.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 18 Oct 2022 21:53:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdfd7d9e-4f69-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=ZbUQNylXhVXKh1s0EJHctv8BE/4Z6ehnPchOqGRN3vo=;
        b=laO575w29tLUZcgzXGqTPpyRHGqXcNcV1nDeKkDbx0zZT+FOua+erEdbJggPJcMUBE
         VfwaE54TEHl/FwseLPL/Wg21zaq8ILuTskT1ZXOrUydwdKh8muuVqAyIfH5KzqdQUvSi
         9zO3AVQ5MPaCk43ccL6XlM6fe87moJ3+RzCTAayEocd2PdBOWscwdxRUpMSuLswFrh/5
         YPfOw4xCZ4wl2I/AtFvz1HR+dKV32SfSaE3O+ogGT86rQxiPWnYHyOuG9tCBqDlRREBD
         9F7FRBtl7l3xtZru5/p13YOCPXOAPS1ZkKwhiLFWFOgqx5gBKrjCYsQsQwtmmUVauIH4
         IQbw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=ZbUQNylXhVXKh1s0EJHctv8BE/4Z6ehnPchOqGRN3vo=;
        b=Mq6kLdm2BqdDKjgvXrhCvwuR4mJHgj2gUuzdMg0RhLKZlzOKSyje/99qs33Wfi955J
         CZ9xZ74F5PDYpsrHtmr33FV5gLI3hkh/OUbaQslg95Tq0y5zQFy+YW2oFCztGzJdFPGK
         HDey2eVD9kJvHC2192Dompp7LbkUwGakGVqPjiDuLbbEQT40HahOIf3X+dOPBzeo4PC3
         9wDffJyj4rDwNyxekCnNx2ucQ6TC7nRw9JWTDDd/npXxyMl1JJEKX8y9K3xjN+yGXbca
         89LDavPUvsH9F3sec6rLYzZRcvlQoJWPC3S70lRdTa/cCNt7VGx5DCOuBKq4o6dG6kdH
         yuHw==
X-Gm-Message-State: ACrzQf1J1+uQuKWsL4+uV5W73xwab2C9TXr6XI5Fg+bLfPeRKixRPION
	IYyCpW3lm1Hv3sNzustPSqA=
X-Google-Smtp-Source: AMsMyM5xG/9NQohjSp3JAsEV138F01V+6/sixxAwGiiyN6nAo2Sw/zQIyzJlQyQ9KBa33R7J9ImThQ==
X-Received: by 2002:a17:902:d2cc:b0:182:d901:5d28 with SMTP id n12-20020a170902d2cc00b00182d9015d28mr6814310plc.142.1666155216361;
        Tue, 18 Oct 2022 21:53:36 -0700 (PDT)
Date: Tue, 18 Oct 2022 21:53:32 -0700
From: Denton Liu <liu.denton@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <Y0+CzFbQXxYiqgPC@generichostname>
References: <20221017103532.845293-1-liu.denton@gmail.com>
 <20221018131235.5e70f0bc.olaf@aepfle.de>
 <Y06w0Oda0sHTHPNW@generichostname>
 <20221018161821.149ee6fd.olaf@aepfle.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221018161821.149ee6fd.olaf@aepfle.de>

Hi Olaf,

On Tue, Oct 18, 2022 at 04:18:21PM +0200, Olaf Hering wrote:
> I think this can be done already today. At least YaST offers a way to select a specific item in a submenu and pass it to grub-set-default. This leads to an entry like this in grubenv:

Right, we currently offer the ability to navigate to a default _submenu_
but I think that it's bad UI to relegate the most oft-used entry to a
submenu entry instead of the top-level entry. I would like to be able to
specify the top-level entry, that is the first entry in the first menu.

> Maybe the patch description lacks a specific example how the proposed change is supposed to be used in your environment.

My patch description says:

	Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
	GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
	top-level entry.

and I'm not quite sure how to make it more clear other than, perhaps,
explaining what the top-level entry means.

-Denton


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:09:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:09:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425472.673304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2Gm-0004lq-VW; Wed, 19 Oct 2022 06:09:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425472.673304; Wed, 19 Oct 2022 06:09:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2Gm-0004lj-SQ; Wed, 19 Oct 2022 06:09:36 +0000
Received: by outflank-mailman (input) for mailman id 425472;
 Wed, 19 Oct 2022 06:09:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol2Gl-0004lZ-VQ; Wed, 19 Oct 2022 06:09:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol2Gl-0003pC-Ol; Wed, 19 Oct 2022 06:09:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol2Gl-0007vX-9k; Wed, 19 Oct 2022 06:09:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol2Gl-0006db-9J; Wed, 19 Oct 2022 06:09:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9jRK/n7D6f+dQ8eRUiSrpYUiIypKmSR4U4kPmxHN63c=; b=gQzcPbl0eAYcEzd2cXiWSoAFVN
	227AYPaUleqhYBC5SzwreJSikUkRNU/yJVi53GUlAp8ww98EyM4m0WzZaznAQ9avoKmotj3a+PLeM
	wPH0oMxAKshiOfJxYB6eKcSq8RzYgdc936P+ddnLa//aMkGSSmNhlicjHZ+jJlhUlloM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174003-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174003: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 06:09:35 +0000

flight 174003 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174003/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174003
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174003
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174003
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174003
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174003
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   64 days
Failing since        173496  2022-10-11 14:08:01 Z    7 days    8 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    6 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:23:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:23:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425482.673321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2UD-0007AV-A0; Wed, 19 Oct 2022 06:23:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425482.673321; Wed, 19 Oct 2022 06:23:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2UD-0007AO-6B; Wed, 19 Oct 2022 06:23:29 +0000
Received: by outflank-mailman (input) for mailman id 425482;
 Wed, 19 Oct 2022 06:23:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=dXjq=2U=suse.com=MChang@srs-se1.protection.inumbo.net>)
 id 1ol2UC-0007AI-6k
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 06:23:28 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89ca74b7-4f76-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 08:23:25 +0200 (CEST)
Received: from DU2PR04MB9081.eurprd04.prod.outlook.com (2603:10a6:10:2f0::13)
 by PAXPR04MB9302.eurprd04.prod.outlook.com (2603:10a6:102:2b8::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 06:23:23 +0000
Received: from DU2PR04MB9081.eurprd04.prod.outlook.com
 ([fe80::a241:d3e4:c22b:a236]) by DU2PR04MB9081.eurprd04.prod.outlook.com
 ([fe80::a241:d3e4:c22b:a236%7]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022
 06:23:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89ca74b7-4f76-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TOFn00KMklvQR3lNNosekwei4qbguD9ZJJBpMIKD2qAjSKVoMyzRovqIqZzJst9EzVQHG2nsFgRofPb+HckOPYBRUTVrMRZnsUCNcuawQNZNz8PAXh/a9EOn0qZMRdgboSPTe+qa7hZS6Vlrl31Oa2Z3lhOULzpgmdPvoYOF9gTDYX+pyQZIHlFAbJCFjM1bPzKtrlhT69bSoKbyuPlkyBW0h/HyddqFNeUYQ/5mNCfse/9AdbHfp9JfI9bJF2ANlX7PMDShUBLUirEIO4ZSDpdsXhk+HjxxRHB8FhtU1KZ2ZOODUOW+oJ2xX1zRW95B5Ae1MYvaEq0VdGFMQwLfdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5G+eFuzJxj7+/WKBbpljkfn32fF7Ge5Hm0UmQOXWsUE=;
 b=j0186qq+7dIvqshOuniSHpvJ1QgURdiKJ50DOoJQUeAVhlKXkm7LJMsBPx1Nk809EUT/2TtYa0FyLUBTjU7BY8FOrQJ/mAdn+EFWHr1bIuOD61N6XDkUZpsw+vY0JKlN7EtYDT1yZ60x18+55JSLlaYzp07ksw5qMrO3RGKLYeBlyFFoyG9Zt6MSKkg/gQQJojhbeh7c1qiDo750lBjAONVxIWQaPxinxmIBURqnXPdvz5G9NznEFLAFpbCN2n/yrrr81LPk1ZibSHKSJjwl9fvbQpo0NOlwOuKqpIX5uEI9TRjJ6XZMYd9+/AqCbgwZonJLYlwmn1ztM/1T1vbL9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5G+eFuzJxj7+/WKBbpljkfn32fF7Ge5Hm0UmQOXWsUE=;
 b=d2yUssnTkoDvuk27hUbZzDPbObctr72uy1+E0AH3Sa2Y2KVig7snzHhKzElYdgtKfXAXDmz2KhjpNUkMC39rhIfSYNp98KAYVzMMaVKawCZuPBX1Xeyr7woIzT4LR+Lv/ihnub4hu5/oMjGUOQVx5xtblL8uoWAvRxCrBP/XNjvNwlBxxuQVWwvfU30Y7BYRnLtulQWLnPMe26T4gVUYS+BGtFpp89JY1sY0tQH2awL9I75CsgbUAPqlxJ1gubNQ+wpmrBDsyAEEKGq2Bl16dXQATrCLliPNW+hTpGg2sAN9Tf85JQb+gXJnGZBoyZiQibIUHsjBmxKWRqdVJbmGiA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Date: Wed, 19 Oct 2022 14:23:13 +0800
From: Michael Chang <mchang@suse.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Denton Liu <liu.denton@gmail.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <20221019062313.GA19401@mazu>
References: <20221017103532.845293-1-liu.denton@gmail.com>
 <20221018131235.5e70f0bc.olaf@aepfle.de>
 <Y06w0Oda0sHTHPNW@generichostname>
 <20221018161821.149ee6fd.olaf@aepfle.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221018161821.149ee6fd.olaf@aepfle.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-ClientProxiedBy: TYCPR01CA0136.jpnprd01.prod.outlook.com
 (2603:1096:400:2b7::6) To DU2PR04MB9081.eurprd04.prod.outlook.com
 (2603:10a6:10:2f0::13)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU2PR04MB9081:EE_|PAXPR04MB9302:EE_
X-MS-Office365-Filtering-Correlation-Id: c1a4011f-403b-4bc2-3f0c-08dab19a6c5e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ia/ToCS5WzRTJLperUIUwIIMC1+uXkL12cgzNZFW9ZA+y+Y6zLE4F8/v3quFNJNOhs6rJlkQHCjJR2Vi7SZRBPFSHiffDZJTfWhr9xT/EAwkMSEltsl3q4sBTOV/QEarue2RTsyN2jm0Tk6GohqY9tG9YPU/xdlwcJYXRmfMmuUckhYwFFPp6xcs6jj7YaYKJQmga7ptCXohpRYCSqECrOzMH7WR6ZSJLrl+mRIZv2SJ7m2practn8IQ0MhRIv1PD4LETYSqx4akPe+I7+F+Me81fNEIKhqpdmXJLq/2EiduS7dnBhBDg4THg4yWRBHyGwvK4O7EFW0IPvBFSqXDVcWvak7xFtXUEGZgyDMzlbnNXJbE9PM/LA63+FdBKzB6ppkZ0x40WNx925LlJVeWscQfO8lrOl890IyywLZo5OM5hG43jrpe3fEwlBhHlSf7pNUnlyFdqKko0g01jWsajzaZfaOTNaZCothIv1MFqfHgrn0LSI6FZL4fK6XKmkoGfayVSInTCP8959/h67JSWQdoEBYgqDwbJlrCz/TRTxDxSyldyoeH0N+WPMOL/6zCPqsj6N2sSjrBqEZDJkp/1sTEULr/ol4nIH6ilMWnMTHM3OJU27E+D3zMCSeOCuZw5Gc6kyVgsmsJbQ1sbubV9LhjMLtXzoTsAcoOzj9I5QX+i4sWmZ7gViLufLTUiyemR5BbRaVeUHSIpcoXMe8IiuO+TiEo5zxXtFUdvOwymfc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9081.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(376002)(346002)(39860400002)(136003)(366004)(396003)(451199015)(54906003)(86362001)(6916009)(41300700001)(8676002)(6666004)(66476007)(6506007)(316002)(5660300002)(4326008)(9686003)(66556008)(6512007)(8936002)(66899015)(2906002)(33716001)(1076003)(186003)(33656002)(66946007)(38100700002)(478600001)(966005)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3xvu8GS7YV+KABooMMSqeMpJ072dL60ora0PvQ2IPQImOVbmulmQ9T0XbhqZ?=
 =?us-ascii?Q?igpc3hYrcfdd0rguzTwm17yXv+rgFNi6pbKBDJlZADYQ9RGQxO7QXom6ktHZ?=
 =?us-ascii?Q?EWy/OCJnhXc5j7ib8FVvoPMRAkn/aPPWnP4TigBpBZ3rvEomLTOpmnD8Ks+G?=
 =?us-ascii?Q?WzzhNUyMhrNXTQr+7PuWSy8q8XXwa4TPgMssa9gtAxIPfe15ZwnFzW10BhPK?=
 =?us-ascii?Q?Ck4JpWnVwsQDl2cLn0pC8HsLa2hR4sC+2Z+doaJlaV/ER/I6jYa4FGsq8ANj?=
 =?us-ascii?Q?0sQBHzEXoFaWAnV7hE3vzgNpRooYrQSnW1Us/JHwu1MLf+ZCeODRxGdWCTbN?=
 =?us-ascii?Q?JFOykvzCdcGNwFIzbcsW6FS6Qhs6jeQXzPyJmpy3eirPOBkejUlzeLDrxGLC?=
 =?us-ascii?Q?f4cjG80bXKDTnYXfNP8ca6mff1bYjzTjhFyu0WtA4gVG8yIn19LHmdTqVEYa?=
 =?us-ascii?Q?nR1W7dvrBJKDIc5K5VH9KFlYcnNy3O986EivHTrXY1XibDoEzVn0gLLxNo7F?=
 =?us-ascii?Q?ZUJboLDuqxkw6QowRkvSjUxCL4QfPLHPOlUEvec0JRGDebqRsPvgrMs+XspU?=
 =?us-ascii?Q?BF/2B0qVQ52Kn2cLnd7mYorXoBH5mFmZ9XSwfYr7imVzJ2raKRj1rFtqrkrh?=
 =?us-ascii?Q?0xmhiKNQFNSkJgudxyxtHz/abanlXZe/YmJeD/0JfFNyszCvXbVRU0wjh0de?=
 =?us-ascii?Q?TS7XE71xMS82Lz5mPBRyx9HH+oRWKGn+Vgya49Vs7v3W1nNlEPx29yqJ4HF0?=
 =?us-ascii?Q?CXVrYSYdVTe63HeKYAZMg7oxpYV9ESXCm5qF9WTOqcLGhk7NDjtYjWyv6hdv?=
 =?us-ascii?Q?t6tLWf1L9yYGNoYLna26zM9A9jPKBGsOOdqo1uZEmkt6JwMKf2b+JrPL7v/h?=
 =?us-ascii?Q?5hpAOrmQTaldoitdn1FhYRMXnjYbDBY1/PlpqVJCwkaBFY6gZKfdYS2LwvB3?=
 =?us-ascii?Q?JQJ7l/pWrZbAKeCKhky+/zZbtiYTdJMUPhTQyuzSZoty8XtDj8FYnKZHc0Cc?=
 =?us-ascii?Q?osGUHllAAO1EEDRCDZl7UdyMXak0DfTnMgpiLLLrTc8BDnrIcA4IPyHDAVpp?=
 =?us-ascii?Q?3wstNUvYKERpP57VM/6JwgohiBJ/16pXH8aJgyxalyjho0jnKjLiKUFwCyOC?=
 =?us-ascii?Q?hTtLUFpEOslXGFrXNo2nUM2Z/0wg6INju4/wjGNnLJRD9tafGrWVTHocNjNf?=
 =?us-ascii?Q?lSzTbDpSE0866kIwNqg2jXy2HfYyVJyJrWvdQYCiQeGtHTuydQixVIuILBuA?=
 =?us-ascii?Q?DHTCoALR9F/s175axlbtRTod6avsiyrKHyFxm8mlQYF22Q8A8lDSH4YINWdX?=
 =?us-ascii?Q?iq3vLgU2ySGyvU8EgKEmAfcTdsd1jVHk+GPD0uheYL3/AExL/P2iD0lN6Yda?=
 =?us-ascii?Q?e+l8NYwGUNOdxrFfPum9jJkuykb4AR+wYkzC/jMIRep0Evvkx7MKIgaaXg1e?=
 =?us-ascii?Q?+cOyGGBfP0PHcpEEhqdAZ5n9ktMgd2KmZyEqX18K7QXXgG47XyBOjyhjJCfx?=
 =?us-ascii?Q?jlD6NFXTQ0BnvEttS2j3Lr7hK8BUQtXEJLV+n96I0HBXjJQhwuaWKk1rlnmn?=
 =?us-ascii?Q?e+Zen5GdhxoK5AJLGK5JgDCZJo+jdL9AjpKR4BeNPq8ZkYj8Hl6OKYoCUq2k?=
 =?us-ascii?Q?X2zjj6tdyOA8RVu+CWVV9+5jwrd0Lbt7T3xgbNDkbDhw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1a4011f-403b-4bc2-3f0c-08dab19a6c5e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9081.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 06:23:23.5368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iD7PjRKfbzFTJNpVyI78AR9X2oKvcOQd9MBYiaDQwac0R1Hu52lIqQ59kciQmYLd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9302

On Tue, Oct 18, 2022 at 04:18:21PM +0200, Olaf Hering wrote:
> Tue, 18 Oct 2022 06:57:36 -0700 Denton Liu <liu.denton@gmail.com>:
> 
> > If I'm understanding correctly, what you're proposing is a mechanism for
> > setting the default entry. If I'm not mistaken, this seems like an
> > orthogonal discussion to me. My patch proposes a method of setting the
> > top-level menu entry while this method only sets the default entry,
> > which may be hidden behind a submenu.
> 
> I think this can be done already today. At least YaST offers a way to select a specific item in a submenu and pass it to grub-set-default. This leads to an entry like this in grubenv:
> 
> saved_entry=Advanced options for SLE15SP4 (with Xen hypervisor)>Xen hypervisor, version 4.17.20220823T122205.399bcbf2-xen_unstable.150400.370>SLE15SP4, with Xen 4.17.20220823T122205.399bcbf2-xen_unstable.150400.370 and Linux 5.14.21-150400.24.21-default
> 
> This entry will be booted as long as both this specific Xen version and this specific kernel version is found. There is a slim chance a SUSE specific patch exists to enable this functionality.

Just to clarify. There is no specific patch, this is common function in grub.

Thanks,
Michael

> 
> Maybe the patch description lacks a specific example how the proposed change is supposed to be used in your environment.
> 
> Olaf



> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:38:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:38:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425491.673338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2ie-0000R7-Pa; Wed, 19 Oct 2022 06:38:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425491.673338; Wed, 19 Oct 2022 06:38:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2ie-0000R0-MC; Wed, 19 Oct 2022 06:38:24 +0000
Received: by outflank-mailman (input) for mailman id 425491;
 Wed, 19 Oct 2022 06:38:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol2ic-0000Qu-Mt
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 06:38:22 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80080.outbound.protection.outlook.com [40.107.8.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9f9c483b-4f78-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 08:38:21 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB8124.eurprd04.prod.outlook.com (2603:10a6:10:246::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.28; Wed, 19 Oct
 2022 06:38:19 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 06:38:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f9c483b-4f78-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FocO9eVA675ctE4tdSaMkSRkICtpiec0Ye9WrOGv3+V0VSnzXhLLZ54UTVUkem4sM9KRxv74fc3pJ09e42lrBjFJr5B8wFgdOYr1lfucc+NVtgbFc9+xkV7MXMBM2mKnUDBAI4Tygdk9evJVx1deeoywxvIBDKoqgfo2DRfHRDq3C0+upV5PAi1WaztfLhg+/LkIpItqSlLR+gwnWT17RSDNr38ko8Tg2kQXV1v0ARWZv9Z3FskwJjeiJyln/ucwcMyIHfYcmAK9EzvWgNZmumFZPuIVADPt8IGPn0botAtNCDApWuu22B0Xs0NfSpojaHuBvGwdBFyPV3OXPsDuIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aYuLN5bgvnF5RnwrWpONTqY08xWFtrkzfXj+k9tmKkQ=;
 b=hxmOhuQRwp9VukyfVrY1tgyFd92zoP55Y3QpCK8HMKqKutwW2hPsHtFoDF2UjLBhH4ot6oA7oPU/rbmCySTq2wl70YAp+yRc/FOvxOdOCO4O1Q4FhqSSfLl5Sl3q+fsMBFmUGxjxQMGOnc12mdCrRp1Vj12ClH7G1GJVZnEejen+pmjMk8Ro1YpnH/H/FtmpbfCOw5DIuRN/vo1qOv37OsI+CY32RvLxppqQe0H0bKhmRhz48OhGsowOyH4LobKjdzzPUZDcL/xzuBG8RDyvzPiOiy3Ec4vm80OZ3YfYGgvzZE9aHLtidZF02Ens+u3mgzEZ+AC1n1JlqBPjzWQZmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aYuLN5bgvnF5RnwrWpONTqY08xWFtrkzfXj+k9tmKkQ=;
 b=0QSk2h8Y1XBNyrZlQKTgdKf/fHULd6Doe+Ha5onbi2I6xlTamGUDJ75/XohLeLG4y5xn/ZT6Vd9L2dg8sr53tc9mudOZAc42NQOUgEsgQYWm+Ey0B6c4AyWn5FxvMNC3uqoyVJ7Qli0IZ0DiWcQJj5KSqgzKy+1nGmT9iW5AdMDqNTZ2PaGYoKtDaTj4TLNhOahzFpF2CMmnflT3r1NcfWx1FrYs0FDAf3IY3v0keX0yKNLr+azH2eV86GQ/W5uyBGwaBj3yDDQQtCSRrLL0emvv7qUKpKCat1VHNIGDdagvXFDtWHCBai6Q8gdZSpmB2l9e7cWK/2sjUEpkZncb8w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9b113db9-4dce-d300-9393-a8572ee4fdcd@suse.com>
Date: Wed, 19 Oct 2022 08:38:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Proposal for deviations in static analyser findings
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Luca Fancellu <Luca.Fancellu@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
 <A906FDB6-7DA5-4900-A6DE-1140231E69AE@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <A906FDB6-7DA5-4900-A6DE-1140231E69AE@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0143.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8124:EE_
X-MS-Office365-Filtering-Correlation-Id: dd1ed2be-5bf3-4023-29bc-08dab19c82a0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YQDBzVWRDzk1PiTTAr/B/XI9LNks6tQ2bETjIMIIpQyTA4umpjbN5pb4DnXQOnnBVDAmNwnHCpZCaVjsuB1W5BDBWbqe0ExEwoobR17osBmWQJxHSYjhB46o9OLqpl3bmMyq9wT9lxwdhELVi9TCNH/kt5ojzU38HJez62FQT4CDOFI3iRO2duG1tFebtWftSNlxtj8g/6A5qVRiBA0qPixB023clbb0RNGnVY8zHdOZ3OydAOn32pPQTSVxNVExkqJuQtSSebxZkj2UDygYYrju3wdUK+odv8UexL9PCBDyWVnG3b50buUCKXY+DhLnlCqTm1J19SnA3hENFuEZrdqRC8Jdddac+Kh8Rw6QfJsVHn3B3S2qh0YQGvnvy+kqT2c/ZlayJ+Weav4g3KVnOg6tO+Sw+fMt3K89mE9fyEb3Dw0DEE2366OTS9/POvLKnf6Aq9fcvJxBK2e8j28ldadsfxQ8k7dXxr54u9+nAAVIzJ4g/7N2tkKwL46Wm0VaQ/xitw1EYKlvavnhCaYSgn0amq/GpfjBNuF7iqR1AWKlVytimqDwNPhER4XPc3QmQS16XdLByZXdRFPmZ0Zfi4gXD1wB3e/rjQRfdV7/on530Q7tUDsZHqAvzcbGWZyGVo/56D1G6wWQeh1HBHISGZtC2mYxlQLLNxgEXIRez9pTMLoZrgH0X58peeAHXTf9mJFUufH68jLxX8OV/WFI0l9vkWpmLjPH+Bsk1Juv74TcC9YiQKpXrlAgEWp0NRN7XmIPb60/xjGGRuHtL8V/GYxVCLNJpu1RKCQH0BiCQUU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199015)(54906003)(8676002)(6916009)(66946007)(66476007)(4326008)(2616005)(316002)(66556008)(6506007)(186003)(5660300002)(2906002)(86362001)(31696002)(83380400001)(26005)(41300700001)(53546011)(36756003)(6512007)(8936002)(31686004)(6486002)(478600001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TlhxdHl4ODZOaDB1UXh6NWRsVVBnYU9CTUFyQndqUXVuakw0M0FscXoxZVBX?=
 =?utf-8?B?dFZIVGlSNDdlUUNGV1R1cittTUVwZ1FxcXQ3WHlmYXJMZmxRclRjazJJWFgx?=
 =?utf-8?B?eUpJd0piaXhhNVdWK041amFWQjVmT2ptYUQvOWRmclEyN2ptb0I3UFNUeTBE?=
 =?utf-8?B?MTBVMElEc0k4WkdIckduaFM0ZFBaeVRQWXhZU2NvRVdtTE9JV1c2S1dUZ3pw?=
 =?utf-8?B?RUdZcHR4N1JvMFlJNm9YY3oxMVJLL0RWL00yUFN4TGptWVhLb2VJYkhheDda?=
 =?utf-8?B?c281azZXVDRucG44QjZjODZrQlVwdXVVSE1lNnowLy9naVJMMGFMQStJcUFp?=
 =?utf-8?B?SHgwdXcxT1pXMmcrNGduR040azJMeEJtTWNmbU1aaVhVVWlkS1BsTVorSTli?=
 =?utf-8?B?V3Q5eXZzT3dhUENYUkVmNjArVXNHMVRnU3Vsdnp5dlltTEV6ZVZGZFZkcXhi?=
 =?utf-8?B?S0lWeDltQVI3bzJYb0NNWnp6aE5CbGRLTFphaVRwNDN0MHBUUUxzeW14T0g5?=
 =?utf-8?B?TmNubGhqRGk2QVA3TFBHTUpUWi9OUFFzM3lzTnpmQnRwa0E5YjNpbXJLYUxN?=
 =?utf-8?B?OWlBUFNCTzIzV3grbnVQRlpmMzZTcy9jcmpFZnZ3SzErcnBsekJ5c2Q1ZEky?=
 =?utf-8?B?amJsYmpTN3dsK295M2p3dVhtZUR1cGVjSXk5dHRuT1A5MzlUWjlwaCtCRVdV?=
 =?utf-8?B?dUloSU1hc1B4NnBrSkk5dDlwUkVBNFNYUXlMbjFSeUNUa20vbGRXWWhHWjUw?=
 =?utf-8?B?SGRDTXBLTEw2QkMwK0JyZHBwSmttNDhtekZueXp5dlExVTVta0RvTU4wVGdK?=
 =?utf-8?B?ZjRyVlFldElZSzArK3crOW5pd2ROSC9UV0dwTVRXR3ZjTzlWY0tXbjVYZ2pr?=
 =?utf-8?B?d0RmZWk0aWxpbjJlQ0xIOXFpMFIvb0hzMjl2Vko1dEdsaVhZaWZDWms2L2xj?=
 =?utf-8?B?T1JSc2hBNWJRRk9TMlpscFlzajF3SHVVNWFRWndsZlFLZ0lVUElMWE1xNEJC?=
 =?utf-8?B?dzl1U2Y3RHhoMCtIZTRWY3lZQ1RUam1VK1FBR2poaFZyMzdYRk9jWTczZ0hD?=
 =?utf-8?B?VFhFYU1mYW5JR29qUVB1OGVtYnExLzc1UGEyZ2ttVW8zbnVEUUlFemlTdUtr?=
 =?utf-8?B?TENCZGZlN05oeC9uRzhaSFoyQnpQeWl6MDdlNGRVMUtuL2p6VkIyODVQcVo3?=
 =?utf-8?B?TlU2cldvVytrb1k5Qkh0emlaY00xa3JwTEJQbFJVU09ZUElldjJGaUwrQmxN?=
 =?utf-8?B?cFNENUxhd05FZTcwWjFhbkVPYUNMaC9QSkozYmZmWEhHUE53UC96dlN0U3NO?=
 =?utf-8?B?U1RoVU13QStqbExYQktGdUN4T0s1WDlwMVRJS1dJNHo2a1RzcXlDd251ZHVs?=
 =?utf-8?B?YlROMkk5c2pIYzlIVnM1UFc0ZDN3OHIvSURnbGdVb0lPYVFQS3pGcHVPU2dX?=
 =?utf-8?B?VGU4MGtJSDVBRkx2aTRLUzFaM3NPeDM3VmtqS1ZaclVEa3p4Znp2V0kzOUU2?=
 =?utf-8?B?REJ1MFZyck40K0ZGMGNGNGI4OFMxVGJ3ano3NHQyTGxJN0tVTElSWU9kaElY?=
 =?utf-8?B?UlVxdHF2TWlsTng2dlExWVFONkt2VGd0Slp3Um95OUJjaHEvb1JrNlZ0THZV?=
 =?utf-8?B?VXpuVGRqK3V3NkJhWEFxNnQwMHNiTWh5cTNUUDM0Yk84eDFTVTBxMmhBdWJ1?=
 =?utf-8?B?STFPVUpaUU91OTRrL1F3cGtvRFM4Rlk3QUhmSTBxdHVYYUI3YUFGR0ZuVWNF?=
 =?utf-8?B?d1k2TTRSaWZIRFZKZzJNQlJQNE1wUU9sUFEvTkthTkhBNHA1L2VGOVhkRTEx?=
 =?utf-8?B?ZFpDWDEvck1HMVdCeUlJWXh5OFdaOUVDRXhPTi9OWVh3amJLQ2xhUnlmaTMw?=
 =?utf-8?B?dURtMkhIZGtVYlJraUdTUVJUbHBiY1Y1MGU0QU5Cb3NWc2l0U1J2QzhQelN0?=
 =?utf-8?B?SmFPMkU2RGt3TEJ6M3dSdWNOSzAwMHFYcTBpa3ZvM1NWdmlOWENkdS9uVTdN?=
 =?utf-8?B?Mk9KUEs3bzZKeUQreFVWemhkQVNnbVNLVTFHV2Z0RTZ3ckJjQzRKQkJzUWpI?=
 =?utf-8?B?Q2ZaZGw5di8vODRvdFd0RHp5Y3MxWDVQNlAwajIwam1vRVVUWis5UXgzMnUr?=
 =?utf-8?Q?A4zkQQEKBn+IFsJXHFqYQNG2R?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd1ed2be-5bf3-4023-29bc-08dab19c82a0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 06:38:19.2457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CTR8lfi7YDCUTtCI0vUyVxMnoOU1c89JhTO+wUT0rWpL2cJYjwxzjq4Y16/Wo0/HtFjSTcuZPAJLMcdhVhoNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8124

On 18.10.2022 18:11, Bertrand Marquis wrote:
>> On 18 Oct 2022, at 16:29, Jan Beulich <jbeulich@suse.com> wrote:
>> On 18.10.2022 17:17, Luca Fancellu wrote:
>>>> On 13 Oct 2022, at 12:34, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 13.10.2022 12:11, Luca Fancellu wrote:
>>>>>> On 13 Oct 2022, at 08:50, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 12.10.2022 18:00, Luca Fancellu wrote:
>>>>>>> Entries in the database should never be removed, even if they are not used
>>>>>>> anymore in the code (if a patch is removing or modifying the faulty line).
>>>>>>> This is to make sure that numbers are not reused which could lead to conflicts
>>>>>>> with old branches or misleading justifications.
>>>>>>
>>>>>> Can we add provisions for shrinking such entries to e.g. just their "id"
>>>>>> line? Or is the intention to be able to re-use such an entry if a matching
>>>>>> instance appears again later?
>>>>>
>>>>> I prefer to don’t shrink it, the name itself is not very long, even using many digits of the incremental
>>>>> number, it removes also the dependency on the file name.
>>>>
>>>> Name length isn't relevant here, and I have no idea what dependency on a
>>>> file name you're thinking of. My question is a scalability one: Over time
>>>> the table will grow large. If all entries remain there in full forever,
>>>> table size may become unwieldy.
>>>
>>> Ok I misunderstood your question, now I understand what you are asking, we could remove the content
>>> of the “analyser” dictionary for sure, because if there is not anymore a link with the current code.
>>>
>>> Regarding removing the “name” and “text”, could it be that at some point we can introduce in the code
>>> a violation that requires the same justification provided by the “orphan” entry?
>>> In that case we could reuse that entry without creating a new one that will only waste space.
>>> What is the opinion on this?
>>
>> Well, yes, this is the one case that I, too, was wondering about. It's not
>> clear to me whether it wouldn't be better to allocate a fresh ID in such a
>> case.
> 
> For traceability and release handling I think it is important that:
> - we never reuse the same ID in any case
> - we keep IDs in the database even if there is no occurrence in xen code as this will prevent adding a new ID if an existing one can be reused
> 
> In a certification context, when a justification has been validated and agreed it will make life a lot easier to not modify it and reuse it in the future if it is needed.
> From our point of view, having a clear and simple way of handling those will make backports a lot easier.

Isn't validation of a justification connected to the affected code? If so,
every new instance will need validation, while an orphan entry is entirely
meaningless.

>>>>> After the analysis, the source code will return as the original (with the SAF-* tag).
>>>>
>>>> While you mention something similar also as step 3 in the original document
>>>> near the top, I'm afraid I don't understand what this "return as the original"
>>>> means. If you want to run the tool on an altered (comments modified) source
>>>> tree, what I'd expect you to do is clone the sources into a throw-away tree,
>>>> massage the comments, run the tool, and delete the massaged tree.
>>>>>>> if the object doesn't have a key-value, then the corresponding in-code
>>>>>>> comment won't be translated.
>>>>>>
>>>>>> Iirc at least Coverity ignores certain instances of what it might consider
>>>>>> violations (fall-through in switch() statements in particular) in case
>>>>>> _any_ comment is present. Therefore may I suggest that such comments be
>>>>>> deleted (really: replaced by a blank line, to maintain correct line
>>>>>> numbering) if there's no matching key-value pair?
>>>>>
>>>>> Yes the line won’t be altered if there is no match. This to ensure the correct line
>>>>> numbering is not affected.
>>>>
>>>> "won't be altered" is the opposite of what I've been asking to consider:
>>>> Observing that comments _regardless_ of their contents may silence findings,
>>>> the suggestion is to remove comments (leaving a blank line) when there's no
>>>> entry for the targeted tool in the table entry.
>>>
>>> Why? The tag comment won’t do anything, it would act as a blank line from the analyser
>>> perspective.
>>
>> The _tag_ won't do anything, but as said any _comment_ may have an effect.
> 
> I am not sure I follow this one but in any case we can choose to anyway substitute the tag with something like /* Not applicable */.

That's still a comment, which hence may still silence a tool:

    switch ( x )
    {
    case a:
        ...
        /* SAF-<N>-safe */
    case b:
        ...
        break;
    }

is no different from

    switch ( x )
    {
    case a:
        ...
        /* fall-through */
    case b:
        ...
        break;
    }

nor

    switch ( x )
    {
    case a:
        ...
        /* Not applicable */
    case b:
        ...
        break;
    }

Only

    switch ( x )
    {
    case a:
        ...

    case b:
        ...
        break;
    }

will make e.g. Coverity actually point out the potentially unintended
fall through (based on past observations). Whether that behavior is
fall-through-specific I don't know. If it indeed is, then maybe my
concern is void - in the long run I think we want to use the pseudo-
keyword there in all cases anyway.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:46:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:46:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425497.673349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2qH-0001u3-IG; Wed, 19 Oct 2022 06:46:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425497.673349; Wed, 19 Oct 2022 06:46:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2qH-0001tw-FU; Wed, 19 Oct 2022 06:46:17 +0000
Received: by outflank-mailman (input) for mailman id 425497;
 Wed, 19 Oct 2022 06:46:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol2qG-0001tq-TD
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 06:46:16 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2043.outbound.protection.outlook.com [40.107.104.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ba47d503-4f79-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 08:46:15 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8490.eurprd04.prod.outlook.com (2603:10a6:102:1de::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 06:46:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 06:46:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba47d503-4f79-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZC6C/MUuHKJRncUWlqiNXXNhg2VVkKxSmPW86NSSTYoVkYV9sd+Z4I0vGebAO59+zDNsRnz2l7LyGyTZ0q8s5AIBNSYeo5cf0LnTOLm8w3Wif+94GcvqCQW5QqxxbvBBqvz10yyu0EbE1jDszPVAwZqys27UHUyt5vhULIX20xUuZxRpJDv+MOS6T029pBr8UiOWMdIWf1zKunoFEPMEMAuf823B0I2KfQkYf0YHHroPeOxFg5PItVPxmRje0pc+o0BOMNRq5aWFVSd5HV6EAsLjkn20anWTK14xQUcPcv46kxsWdcudhP7V5H0pb/qRqAhQl7xALJFM3LXUXdeGhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2Lgyb00FqAeO12JB6cDVClauHNkexfkXc7WQaudLwA8=;
 b=nT6nWq1ErxU8TXMpA/oIZaWmyNOQJjiWfnV0N5t7uUKKAW9jURCuEhyZ3iXu1XIKecHnoNYiF5RVl2TTsOvtTzbrVJLcpfE4Dx4kRs5TVebKldpV+3L2HkfRzms2nDdDAMj1mKRHgVJhSnHUZYkWapKL5tT6YkcoMYmSafohBykjH4y84rbYp8K2ImN+P1NRZlJ8JMQAXq1Y7zfhvpa5p3F0sUyzK0tDeUc64wwQnG0a8OhRKKZn6yIzahV3a2rvTo4imMFd5WH16TXF+JDUw+4yMl/cbSzKml5hzCUTbjUDhmvSzdMVbUMl1U6ens0zTXellhFsTscnpwBk7tWPgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2Lgyb00FqAeO12JB6cDVClauHNkexfkXc7WQaudLwA8=;
 b=5A+5GxACub0bUqwxVh0dCY0EJU499YJZK3tbwAV/6SVo9HhJCfr31x+m5KzKbvjqRk9IjYCD4o4NRsZzCalHcxyegRpZWzW5F92g2CSY9lrqjOnA9Xw6sAaMKpuibmr6F3dCWLEdKxVZdgZjf4l1A/gzgJ4cYMerjEylXgvb7IU8FTXwnERou0Oq36ht47IisK1eVh4pkD6BeHkyRz5x71f/MdiXaU6NDa3bIcLZOG5y/php7yON8ckO25AU3oDjbrI2JFGeo4OqI63S2DE9TUELTC7A4LQVnxfedneVH45Fb+X2e29igZ1cq2l4RMjx1OhC5kjlxuJjq3xf3Wp0QQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9e850527-70f5-c6fd-e3da-1cddaf5c6bd2@suse.com>
Date: Wed, 19 Oct 2022 08:46:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Content-Language: en-US
To: Wei Chen <Wei.Chen@arm.com>
Cc: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
 <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
 <PAXPR08MB7420E9ABED55E0554D3C33689E2B9@PAXPR08MB7420.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <PAXPR08MB7420E9ABED55E0554D3C33689E2B9@PAXPR08MB7420.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8490:EE_
X-MS-Office365-Filtering-Correlation-Id: f8020892-04e4-4195-f512-08dab19d9d64
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PklSBXrCrVpfx0Hc7Ig4QOLSCIhUHw6NZzYv9kEI3myDDnYFhaknv7pME7hqWUp4hbvEZsSyKv5g2mj9a1kgIeWxdOPftbABXNKoISO6GHiOk9JvQX0csjPwqbyJU0OF3915toGWSmWGiJ9JnfDL/weTQEgoSnbxtpudYG6xnCcyRBzVTKkJpLOo0gORYhv9wdQZc5TOyNQwRKMKQ3iD1e52hc9jbj3dO70ePDYBZz8nv/UTjIrocHM1E+95vtYujo7p/SmkYSI3k4zQ4z7rE23aE77VCZsQTnyF9AS1l/uh54g0C0ab3FfbF226wHlrNA91MSjSvleYmzyHJlh+R9OM4WktBAwx99sxnz9cmOofCy/pRjPatT0JXtHrHw4r5pQH3kpnwjv6obL6HlLspv32CcAr/eTTF/J7FwygKPugi8FhIwT2ulffF15ARX/OuP3qBSe9i0a6MrNX1ZWXecLQoV2KjLDRye9kQcAWLzP19T7Hh+GC+6AXajP3oX4G38R267XWv9f8rnuNzvy+nh567THvKIMrH+zg7wvqRg/pYMSIx+FAPhoeLWA6JB1KW9cNgDbepT6fX1b+V4KwdhDvsfsip/JiiC7R+e0CzqT/Aum5+cC4xkQCIXAs3tsmdFxRiLQsAfkt7bqvJtKy4vOVUnGq64eEunGSSJVuEJQiBDitP1WCuOSDFNOJYy9WSwY+qKMJQpe8ZcfWGnYcaOWEKqJZ83a8hHVDGwf8csSUUZVnNIr8xjD29Mp8lKUT92vFldri8X73RCvYFplnY+tTUgHWNjD712RM9a5B9Y8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(346002)(366004)(136003)(39860400002)(451199015)(26005)(4744005)(41300700001)(6512007)(66946007)(478600001)(2616005)(186003)(36756003)(2906002)(6506007)(4326008)(8936002)(5660300002)(31696002)(86362001)(53546011)(38100700002)(6916009)(316002)(54906003)(6486002)(8676002)(66476007)(83380400001)(66556008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WWdWZjFUOVkwZjVOS2xxdDlTTjRvSjdJSThPaVFqS2FsV25sT2ZSYUlWRzgy?=
 =?utf-8?B?SW1HV044WmhHS08zcjRsZGYweTRrNVQydmZTSjBmbW5yc244UE0rb29lTjZC?=
 =?utf-8?B?Ky92WlAzSS9OdkdmOGwzTCtGMWlMNUszQUNpZ3FLdGJvYTlWNTVyMVpxTjAy?=
 =?utf-8?B?NWM4ZDJiaGhRYTJsa3plK3JOblVTTGFZTDBESXJaY2FMRkNHK05hWUMxei9N?=
 =?utf-8?B?MGtneHVsdkIybU1LV1Q2Ulh3RDRSTlZ5WGY1YWZxOVhEUlFWdmhTNzB2L0pZ?=
 =?utf-8?B?UjNUakwvVjJTTVIzdlpXdzdsVXJPVFhmV0tjNE5WQk1qSjBhdDV1MVhIQldP?=
 =?utf-8?B?UWFOWlRtZHlRVVVnOExQTTdkU3I1OG1CTVN0Q1J4RWQ3amh2UExKZ0hqMDQ5?=
 =?utf-8?B?SXloc1dYbXBiajBpTmIycGMrNzhHcXVxb092NHNOeVpYcDRUam9zSmhGSUx5?=
 =?utf-8?B?ekRIR3FsQ280RnFwaXVHUGhGWHVES3dONmIydFdBcmR3VWJHQklnci9pWG5u?=
 =?utf-8?B?V0Q2WXlDM295NlRIWjBsTFBDQmxxeVIrT0h3WFdzTXZPYW9Dc29ReEMrQWlO?=
 =?utf-8?B?bnhoWStXRmMwZTZmMUpwQmlLbUxEVjNKY2dlOUlMK1MxL2pqVzdhWVBQQjhI?=
 =?utf-8?B?WTZ2SVRCTW1veXJoeGllOWp1dURIdUw4bnlPTXJORDd5eUU5b3Z3R2xoYUVV?=
 =?utf-8?B?SVNyc3FvMTAreW5SampzRVVmZlFFZWtwWENmUTVRakg4MGp2cC9EcXB5djUw?=
 =?utf-8?B?QlhMbnhTcW1RbHZ0Kzl6K0w5U1FGMWs0ZFJvTm1WUmZVODRxcnFCQ2JMQTdP?=
 =?utf-8?B?Wk1EZnFhb1dyeDJNa2llRFZJenVJa0tpaWM2SzgyT0o4aUpscUlTV01BbEk1?=
 =?utf-8?B?bkY2V0JTSU5sODN5NkhaK0RhM2YwZGJXckJmekVlM3VCNzBLWDZoZzR2OW1y?=
 =?utf-8?B?cEFXeENVRU42MWxUUU1PT1laSFNUMllDcllQajlhZ2ZyRDdsek82V2YyZ09k?=
 =?utf-8?B?RFQ1Zk1mMFhINFkrekhYblE1dGRTcDVwZkVWMTM1T3hlRWZUMFRQSkx2dmo0?=
 =?utf-8?B?eFRueEVoKytiNVlMSEVSMDRqSVNGOFFQNlBQNnhpQlRlcDBGKzFSbG5VKytD?=
 =?utf-8?B?ODZQU0l0MEVoQUlNelRXRVpZTTBLTTNTVS91QlpDMlp2NmxBT29iQzd6SXBv?=
 =?utf-8?B?ZHg4ZDh2bVdDMXRRcHFhczU1OFcrZ3hhamlMeWdMODE0ZXVmdkVIRnFqYWMr?=
 =?utf-8?B?b0ZDQ3RkeHBPbk9nUGw0NnRvWU9KWDcyV0lNQlpZQXhCMUYvdWlFalFrSkZ6?=
 =?utf-8?B?SlltcmhiRk1TSDFISGg3bjN2Z2crZWtTeWV4Znp1TURKb1JkL3pydFlLYk1H?=
 =?utf-8?B?ZmR1b1FYdXdvZkMyZ0w1djVlOFZhL0JGbW9uVHVGL2tJZHRoN091cEp0YW1Z?=
 =?utf-8?B?UDd2QkcvS2hDOUM0Ylc3VFYzQUtzVXdkSzh4UTNsb05Fa0FtK1FFSDNMV2ty?=
 =?utf-8?B?aDFPQmV4aTZTZ2lTRDRBeVppbHd0bi9EZTVqblVxWktBVk9mUFJkZUp2OGg4?=
 =?utf-8?B?dGtYYWI2Ylo5aWZBcVRBeGFXOExEZndYTXJqeEZHZHYwTzJMcjQxcDM5Qld2?=
 =?utf-8?B?NnlyeFZBNGxmQVNmTWRqMytpakx4NHZjRWhTR25ZMVhJMXJmM1AvOHowREx2?=
 =?utf-8?B?cHV4d0NUVUZ5NWI3OEthZm5NVTdrVU5ySkNwS0o1Um53VjFubmVtdm44bUlL?=
 =?utf-8?B?YjNCVHVKYk5idHFsUC82RzJIcC85WXNiOTl2S1ZNWHJZU1ZOMXZPczNzT2F4?=
 =?utf-8?B?REhoNDRQWFVyczlVb2J3VklOTDZFUTJJc1IzTldXUHcrNmFxQy9YcUEzbFU3?=
 =?utf-8?B?bnhac3ExamZ0TW9xTU9Cc3I5NjhKcVFFU2dPRVgxd3BlMng0STZ1ZTlWaFJs?=
 =?utf-8?B?UTkyVXU1UU5oVzVubTM3cDBOZG1nNlh0VzVPcEZORExlZjF5VlRLc1Z6dlR5?=
 =?utf-8?B?TVZ1eUFoN295bW1JOWJndHhiYUZ6emxZUnRFWWlJT0dBN0dRN202MU9NNlNk?=
 =?utf-8?B?TWJlaGJGTzhTZzlCajBCbUZhTHJUVEhNL0tCL3V2OFhlOGVha3dzcktTeG5K?=
 =?utf-8?Q?qBSiYflrZJMPGfVhgd8UOd4pu?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8020892-04e4-4195-f512-08dab19d9d64
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 06:46:13.6061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7ME5zCsGXRr4Jzcspaj0YbzTlL2R9gESa969HJchammtSYxoHlYn9iqRWRiFJeCuHDnoXFsfAAtsKR3QV5NhhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8490

On 19.10.2022 03:58, Wei Chen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: 2022年10月18日 21:46
>>
>> On 11.10.2022 13:17, Wei Chen wrote:
>>> +static void cf_check dump_numa(unsigned char key)
>>> +{
>>> +    s_time_t now = NOW();
>>> +    unsigned int i, j, n;
>>> +
>>> +    printk("Memory location of each domain:\n");
>>> +    for_each_domain ( d )
>>> +    {
>>> +        const struct page_info *page;
>>> +        unsigned int page_num_node[MAX_NUMNODES];
>>> +        const struct vnuma_info *vnuma;
>>> +
>>> +        process_pending_softirqs();
>>> +
>>> +        printk("Domain %u (total: %u):\n", d->domain_id,
>> domain_tot_pages(d));
>>
>> Perhaps switch to using %pd here?
>>
> 
> Did you mean %d for d->domain_id here?

No, I did mean %pd:

        printk("%pd (total: %u):\n", d, ...);

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:50:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:50:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425503.673360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2uR-0003J5-3l; Wed, 19 Oct 2022 06:50:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425503.673360; Wed, 19 Oct 2022 06:50:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2uR-0003Iy-0p; Wed, 19 Oct 2022 06:50:35 +0000
Received: by outflank-mailman (input) for mailman id 425503;
 Wed, 19 Oct 2022 06:50:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2xL=2U=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ol2uP-0003Is-FG
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 06:50:33 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2049.outbound.protection.outlook.com [40.107.21.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 527767d6-4f7a-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 08:50:31 +0200 (CEST)
Received: from AM6PR10CA0015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::28)
 by GV1PR08MB8665.eurprd08.prod.outlook.com (2603:10a6:150:82::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 06:50:24 +0000
Received: from AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:89:cafe::c2) by AM6PR10CA0015.outlook.office365.com
 (2603:10a6:209:89::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 06:50:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT022.mail.protection.outlook.com (100.127.140.217) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 19 Oct 2022 06:50:23 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Wed, 19 Oct 2022 06:50:23 +0000
Received: from 8f385ddfac47.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1A826DB7-3955-41BC-9012-573A9422BBDE.1; 
 Wed, 19 Oct 2022 06:50:12 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8f385ddfac47.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 06:50:12 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by VI1PR08MB5486.eurprd08.prod.outlook.com (2603:10a6:803:13b::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 06:50:10 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 06:50:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 527767d6-4f7a-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=RNMVXRL9vHrSm//K9mOvLIqdvWBI7VeXU4oVGazG05uc5I+Hg5CHUj5fkyk6QGsEZ7xTZD7xGx6tM7ZLUp3nLDf2j+rePwZsUlEAQ+8tLEyrTY9Nd6RAMxHKHMryOgRgztQvk48ptQCJELPvL3pT7xHhxGz1V4gMYqrY80Eh8wq1gvZebHoP9W7EzKb0Lu2NhATJ5llNXHIBXk00uXUgJC34f3NLBePeQVJ7eUFbqc5wcjWH8V4qugZzshTg8aF8pRvA6+ipAapUncByRldIaeP1cPwey/qkxot8uapw15phgv9jQW5qD4xe+H6Pp8PpOpMKxFgIDlaKniSzqVR9Dg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LaaLxsF1qs+9uUuDbYX1U0wpk4yRP1W7MFE3egtqdU8=;
 b=HTRS2hJIhe0HReacJtdBBUQBUyFn2jn+MXh2WKzhqsWOs3TmQzzZthf8X912P3rOkTHcmKOslTlIKWJZlxayc5vHCwoLrFt0RnRzZ5a4S2FsDahocHLPTnWenPKe58Rl6OaQH6ufKRcNzz8ro506l7T8f/8mOZMJL/JFdzv26jpep/pTcYhqX7/QDbXBlfYVhyfuR5D36TPy0ECJ0YVlO3tsui/jk86k94+56DEq/EExowhvmMNL+re3pdg0fBt8AskANNF9HD6yx6tRJZRCCVYCyDrodZx2PRhEGV4klZu/BFdqjVvdujpYtvXVpCloDguiy9/vMIfsBWIfUdpLyw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LaaLxsF1qs+9uUuDbYX1U0wpk4yRP1W7MFE3egtqdU8=;
 b=nRPqlN9T+ie0fiXUqk2zryCPJLTkdbFThlVbSBMgsvWHXCwtUqJkHk2LNL1Q+1Qu8SA45L0wDSn4KDTsRZLT6/2Xn9ugMP9WWbVxeg6tMvU+32ZT1nExQmk/0uzISj0TKxFikuYjOGXkBjMIWEYvZjjnlJsr8vll5yyA8JKdoW0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B1FKIWIQj28l4r/OxXd9CbVdqZTv1CZEHb6kl5OWMX3yPxU1gY7pgwc9rZyvLp+i1z3sG05PzNVn+VPsl6sPw5CVUJV+XYQ2ZZw2dO7rZZRyJloyRJDy3HhAgCkCfBztQ68hCnwVOxe3BpSmQqV4lUIxke4x0xC9DyWC/kalVdJlAMEFqwSS5jG/JgGmxkYg9+roxDyxOBB9gK3U/Qs/4mr1T1GBHK0Y5J+Xkx0qI+LyTaZw3BVnWNSYDIXg4NbyUUUm679JYx+mOsZBL4IuU+T1+w5t0FPUiWFwPoBfuos0tZjIw2Y9ZS6zTn9B+L8pp0ztjUfK+ecnT6tw+aHB/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LaaLxsF1qs+9uUuDbYX1U0wpk4yRP1W7MFE3egtqdU8=;
 b=YPl9xLF+8Lm94d+lCJhHqbeP+0RN5ULGHG8kHkFvfiX5blI7ZbXnUXjHRs1Oh8AFQAarVrjiTkZqoMasLVVSimwg9XZdzmjdCme6LH2fJVtUpayDFO303IB4ugbN6nVrcBKbriJ1Zr2mCdWkstgFiqQnXz0f52MN7xlUy28iiMBe5NR++b53Ew0wd4FRwP0XwlEVu1F+2r16N0+dOFLs8XwkdHXbaAeCgmkuLdCOEmo9lnnUoim0/ULVT8KwUPJXQeTd1/ST9rnKHwl62tg43lvZB41Oy8ZiTCo2HdHczcHF8EzuH60Sjb9NNCSpsH+BdtlM9Ygv42j6KwoGxDXPqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LaaLxsF1qs+9uUuDbYX1U0wpk4yRP1W7MFE3egtqdU8=;
 b=nRPqlN9T+ie0fiXUqk2zryCPJLTkdbFThlVbSBMgsvWHXCwtUqJkHk2LNL1Q+1Qu8SA45L0wDSn4KDTsRZLT6/2Xn9ugMP9WWbVxeg6tMvU+32ZT1nExQmk/0uzISj0TKxFikuYjOGXkBjMIWEYvZjjnlJsr8vll5yyA8JKdoW0=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Wei Chen <Wei.Chen@arm.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Index: AQHY3WMp8fkwGFUvPUGj/zptqNRTAq4UNRwAgAEdejA=
Date: Wed, 19 Oct 2022 06:50:10 +0000
Message-ID:
 <AS8PR08MB79911F3700C0619BA1DA34DE922B9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
 <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
In-Reply-To: <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 6053327C5EEA664ABA80973D1CDA52DF.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|VI1PR08MB5486:EE_|AM7EUR03FT022:EE_|GV1PR08MB8665:EE_
X-MS-Office365-Filtering-Correlation-Id: 5db3890c-f382-46a2-cf68-08dab19e32b8
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jsesN+1ZECD441XflQei3NIZKT+t3MXCKAG39+S043lE52BMZssklu3Wm24szt5rgeNMQUvdGKrRKX6uPNPX80eua5sNQR4H/h/Cqb0iTdbjhp6jan3mog4HYLNgjUGdLMLyZJQigOnckJo2sFTwJsaCg80fAW+xhji1WHfjMRwAV3lKyfkxFmK2D54i1xoltdYorTA+EYbNxBqLlbuXxR+k1SnU8FQysS4X0Ukrpy84+sWlZ0ndKJ/XHdYuSel3MuTtZMJI1W/9DQm1OUaadl6Q3Hni/h55Ql+qYvs7eJUHvGOmiV3p8X/l5Gu1At4qau+WXHS1PtonAzOvLZ1ZyrYbFcF1IVOMKgvynsgRKOSugNzY0iBqSQawVFVSXhfKkC0eqD7i2IyITfAwxBeLi3oMTrtYe2XvEuINn4vv+HB9Y2mDQpAex6hBtHU/0ejZQ7yWLk/voJTmGgNZkJuDC8ZMd2cK+dIGqgCKJdi0gyfi336/K6xoTLd1pF28KlOGQwOiYLS5AT8y5SL5ReLncGYpy/WOINtQKkZvKcyErr55G9nxdLUNt0ZbvHmBy/TTsSr6SzluksNzvCxbPP5+gGe5+WArWDl5RH0pGVNNUQcPlvJ8WGHufGFOV767VA/XPnOVvxiPRpeaA4g7PU0sJKBaiZAxbIekMoOuUvAvdwN9w+L6IPArgvmHixfaq3dFSsfa0rzGB76tbMjy4FpncjJQt1pnBp3vWHKHBphenMNtWH0Qg1QWroaC5UWnVtsS98FfjUEDuFW5kj6qXyg/AQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(9686003)(186003)(26005)(7696005)(6506007)(53546011)(83380400001)(2906002)(5660300002)(55016003)(316002)(110136005)(4326008)(54906003)(41300700001)(71200400001)(6636002)(478600001)(52536014)(8936002)(8676002)(66556008)(76116006)(64756008)(66446008)(66476007)(66946007)(33656002)(86362001)(38100700002)(122000001)(38070700005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5486
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e67383a6-0c3f-46b9-8d25-08dab19e2add
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	21FR3fA0CcjX4OLmjKEPnx6zI+jtTGUGIKENeDLr2cws5mrAEuV1V8GLBLuUU5la2SxzhVKSs77ZGl8teHAfvE8iq5aDl5iWQNDKxcRDsrfdIxUVJjnWECVXW/JnJGBktM6zSr5gFcEXA5JyT2S6DA3n2hJfxZj71zBzQvyR6L5yYrHjsxR0rRVZsQVUBI/jnxkNeQlU0/gI1yf9ZwSmjXW+6df06+SP0o0bxOfI+A5SbTAY748SFd6+RTVYLpsI2i3klLx1FHvN2ZMn8nWCTX57P9GEZvf0nsLHT9k0ig09HNeJ7041Ov9yHbcoyTH4GV99IFumagtSbEy8X04+F47LSLicondv6Jjh0B0KaaaJa5zRH2HznzS5VDPsnatgKxIJrwLzkuD1CdUnojn6lzweD53HmKPJtsoTqKQ+nJLUd7AL30MWIhGlYDC5i2k7U9UfzYivSIpDqMxNJnlcFmr94x7u66K6p2L2c3ODa8XHr2XkdLGEje0mHlN3XWljinwnedBiga2GiMSahL1yDAFln7G2OkdHQejhdBzYum0en168xYNNxNZ7U7vOSPmPGyQaq7xVbyu5B1wuP1XjNzB9OrMNP97RxcI8I+BRS38CUpKxqGYaSNtOwu7js2Sg+UMfbIqSNvpEM8XviH3s+OkNbVK0EK34+eg679h/QW19X5HcGY9zYeHAZA0A8cS1S74oaKaCBYIwSVkKmqizuxWz2n6j3jDWgOUmVzn+RDZX6wjeKOn7ZQgscXCjyn3ADbr1BmsUltE2wMEW8adZbA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(86362001)(33656002)(82740400003)(356005)(81166007)(186003)(336012)(2906002)(40460700003)(5660300002)(40480700001)(55016003)(26005)(47076005)(9686003)(7696005)(6506007)(36860700001)(53546011)(83380400001)(316002)(478600001)(70206006)(110136005)(54906003)(41300700001)(82310400005)(4326008)(8676002)(6636002)(70586007)(8936002)(52536014);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 06:50:23.9643
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5db3890c-f382-46a2-cf68-08dab19e32b8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8665

SGkgSmFuIGFuZCBXZWksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gU3ViamVj
dDogUmU6IFtQQVRDSCB2NiAyLzZdIHhlbi94ODY6IG1vdmUgZ2VuZXJpY2FsbHkgdXNhYmxlIE5V
TUEgY29kZQ0KPiBmcm9tIHg4NiB0byBjb21tb24NCj4gDQo+IE9uIDExLjEwLjIwMjIgMTM6MTcs
IFdlaSBDaGVuIHdyb3RlOg0KPiA+IHY1IC0+IHY2Og0KPiA+ICAxLiBSZXBsYWNlIG51bWFfc2Nh
bl9ub2RlIHRvIG51bWFfcHJvY2Vzc19ub2RlcyBpbiBjb21taXQgbG9nLg0KPiA+ICAyLiBMaW1p
dCB0aGUgc2NvcGUgb2YgcGFnZV9udW1fbm9kZSwgdm51bWEgYW5kIHBhZ2Ugb2YgbnVtYV9zZXR1
cA0KPiA+ICAgICBmdW5jdGlvbi4NCj4gPiAgMy4gVXNlIG1lbXNldCB0byBpbml0IHBhZ2VfbnVt
X25vZGUgaW5zdGVhZCBvZiBmb3JfZWFjaF9vbmxpbmVfbm9kZS4NCj4gPiAgNC4gVXNlICV1IGlu
c3RlYWQgb2YgJWQgZm9yIG5vZGVpZF90IGFuZCBqIGluIG51bWFfc2V0dXAgcHJpbnQNCj4gPiAg
ICAgbWVzc2FnZXMuDQo+IA0KPiBUaGUgb25seSBpbnN0YW5jZXMgb2Ygbm9kZWlkX3QgdHlwZWQg
dmFyaWFibGUgdXNlcyB0aGF0IEkgd2FzIGFibGUgdG8NCj4gZmluZCBhcmUgaW4gZHVtcF9udW1h
KCkuIEkgZ3Vlc3MgeW91IGNhbiBsZWF2ZSB0aGVtIHRoYXQgd2F5LCBidXQNCj4gc3RyaWN0bHkg
c3BlYWtpbmcgJXUgaXNuJ3QgY29ycmVjdCB0byB1c2UgZm9yIG5vZGVpZF90IChhcyBpdCBwcm9t
b3Rlcw0KPiB0byBpbnQsIG5vdCB0byB1bnNpZ25lZCBpbnQpLg0KDQpTb3JyeSBmb3Igc3VkZGVu
bHkganVtcGluZyBpbnRvIHRoZSBkaXNjdXNzaW9uLiBGaXJzdGx5IHRoYW5rcyBKYW4gZm9yDQp0
aGUgcmV2aWV3IDopKQ0KDQpJIGFtIGEgbGl0dGxlIGJpdCBjb25mdXNlZCBoZXJlLCBub2RlaWRf
dCBpcyBkZWZpbmVkIGFzOg0KdHlwZWRlZiB1OCBub2RlaWRfdDsNCg0Kc28gSSB0aGluayBoZXJl
ICV1IHNob3VsZCBiZSBwcm9iYWJseSBmaW5lIChJIG1heSBoYXZlIG1pc3NlZA0Kc29tZXRoaW5n
IHRob3VnaCk/DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:53:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:53:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425510.673371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2ww-0003y3-Jq; Wed, 19 Oct 2022 06:53:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425510.673371; Wed, 19 Oct 2022 06:53:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2ww-0003xw-Gh; Wed, 19 Oct 2022 06:53:10 +0000
Received: by outflank-mailman (input) for mailman id 425510;
 Wed, 19 Oct 2022 06:53:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JMjo=2U=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1ol2wv-0003xq-CI
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 06:53:09 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2084.outbound.protection.outlook.com [40.107.20.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0538b19-4f7a-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 08:53:08 +0200 (CEST)
Received: from DB9PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:10:1da::18)
 by DU0PR08MB7541.eurprd08.prod.outlook.com (2603:10a6:10:312::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 06:53:04 +0000
Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1da:cafe::bd) by DB9PR05CA0013.outlook.office365.com
 (2603:10a6:10:1da::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Wed, 19 Oct 2022 06:53:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 19 Oct 2022 06:53:03 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Wed, 19 Oct 2022 06:53:03 +0000
Received: from 8e94318d63ca.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E23433BA-B2B1-4B13-9C9F-52B40223299B.1; 
 Wed, 19 Oct 2022 06:52:57 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e94318d63ca.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 06:52:57 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by PR3PR08MB5644.eurprd08.prod.outlook.com (2603:10a6:102:86::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 06:52:54 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::b62d:6e04:1c26:6684%4]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022
 06:52:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0538b19-4f7a-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OERFSsBRViJuB22lybDSA1j6eeJ2D7HtXNvht7xDHv8IjUI/jPAedJapE96poCZsn06Knee9OQs3G6C6FjFGrUfbMJh3IENcuPvkaS75rHklt81cqczrI+AnzQB19GRG18i8Boy3W2MaYkmqzhvArp0Iaf63gJzsU8Vs93qVbr1L8CSPOF9jEtn/p7iLed8J435UD/KkJOZrUoufAqB7cNNZUPSDiGkldjg9DnlTpMwhv3jbzB8WyYyoOF4MdtKUD/7pcgBGPeZCVhJcdJeWq7VACo2z8otoeWuHzBBcx3X3BP7inQBHysOsn5R0o74Z65H35jmqbTbs7/U/f0r+eg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lf65EyQCx7kVm7rtbql0ezNCriiV67/9Y7CJ4fTOwnU=;
 b=XXAbXXw9QRlFCoxjjDbF5PH+UJwlFouKWTJ01n0LIYzjYhZfIGuf+5jVqldfSRK1NakwNGFl+KetLe+c98iKJBatszYYut1TxdAhwqSuJvsZbNcmXfvFwiPDndRBgraaD5lPpEyBlFZ8sHJQ4HtDgpnhbVfL0HeS0KIK6exvc6sx996j8f8qeRX+vU+h+YXiq/ugh5m9OMhkQYOxrHGkZ4xMrskx3y53Qb1EUZKqxY2ht7NSjpktnq/SCWJxRAelAYN9s7NHIdyn83HamlZ1wiU5P/wIR/v6LBQ5JfNrGsAQ5J7OC0CUdm3quCqkyUQuLz8BSUykzW7so/nLMjjZMA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lf65EyQCx7kVm7rtbql0ezNCriiV67/9Y7CJ4fTOwnU=;
 b=qJr8Zqavl8b0semef4WsjX2J90XAQFm5rkQHlsac4yqYpnb31rfZqs5u7fcE42j8ccPJ2hlsySatKYsMGEdR5fkHKLTt9jUmu1xJtu08yosxaaBGNNCI9jXhEZZCU6bY9RRaj111QMCuR4Zxv5ixKqexGnLK2TdMNT0m1KWbxwY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N2i5ko04O9VjVDa5MVtTtJZY4RSykTMBecxcRBfMMSIR65+ADHEPJIa3oUxDoEN8xI+8Z5X8uhTHJMehzKwNV7ZrflMcBjikSxrkiSbFBvwApgxVwGrmULDiTV4vEBvWqQ36/39T3AFYVmAvnQJJqzCcvC76EZgupcJ1bIbXSG5IWPQ383fWwAYEukBYKKLaTViRLGwol19QGh4eqWBPtz34Gym/95oYMbc8ghuyfcSzs/ANjVrjLBa7IH5KlqRHY8KjOUvtD8KufmMKqmLBs4kOEJm50kXpNCc0lpMgYP6LdzpQUQ9UUaH7BDikMW4LVnScIvDCYXMz+VLWruJeVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Lf65EyQCx7kVm7rtbql0ezNCriiV67/9Y7CJ4fTOwnU=;
 b=chW7nPwEs7noyV3G7lndHEZGLCyeV3AJsPIwKLE0nSyRXMxa6/uOYRzaKEz0ip9bD3nJrwJmAYvZ0JIz0qHcW9g1PWonhrfzIMhuTKMJhP7/hxHl/uLZOiQbRnnoNiWO5/R55YGnD9Tvmva9/TZvqswvewAyoUrH1Ik1CCSEjIxVId1F0H3zWDZAVNAH2eWn6zx+azW36BSzC2WvuKgyITg9YV52uTc2fRQ+Jq6gSBGvSpl7H791728QQJchR5IE92eNVNYxuIfjPmi4exE66nuptKIB3vgHcL8hcAxjU790B3G7h8QaQl48f+83hzlcLDmxc71erBIIxY2L/Ua6oQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Lf65EyQCx7kVm7rtbql0ezNCriiV67/9Y7CJ4fTOwnU=;
 b=qJr8Zqavl8b0semef4WsjX2J90XAQFm5rkQHlsac4yqYpnb31rfZqs5u7fcE42j8ccPJ2hlsySatKYsMGEdR5fkHKLTt9jUmu1xJtu08yosxaaBGNNCI9jXhEZZCU6bY9RRaj111QMCuR4Zxv5ixKqexGnLK2TdMNT0m1KWbxwY=
From: Wei Chen <Wei.Chen@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Index: AQHY3WMXl9OYk9SO1UmCbrdWlsAFLa4UNRwAgADISRCAAFTIAIAAAK4w
Date: Wed, 19 Oct 2022 06:52:54 +0000
Message-ID:
 <PAXPR08MB7420A36A53658B496DC09F719E2B9@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
 <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
 <PAXPR08MB7420E9ABED55E0554D3C33689E2B9@PAXPR08MB7420.eurprd08.prod.outlook.com>
 <9e850527-70f5-c6fd-e3da-1cddaf5c6bd2@suse.com>
In-Reply-To: <9e850527-70f5-c6fd-e3da-1cddaf5c6bd2@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 717C51F1FA64344B9F726EEFDA2C55D4.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	PAXPR08MB7420:EE_|PR3PR08MB5644:EE_|DBAEUR03FT006:EE_|DU0PR08MB7541:EE_
X-MS-Office365-Filtering-Correlation-Id: 6b3d2093-36a3-43a5-7207-08dab19e9213
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Nh/bAQo4XXdH7zzZ44So8x3Wn/+90D7oyBAgC0uhlGeS9SAY+azHdv17gEu8BzYMYJYYXw3nMMilpV5pNx5BNRn/Bi+7R6BERBXuhgSzQn2HPfquoCsseXsXVLleKN1vtNJ3i8IgJlH0htdSMMXFkc+3R9JxPW4MvAdjWxBsFZSi/gqCbVjyfYF7YG5Ebv65cCpAP0+jjX0IuuNWGg/B43AdIQURa5wLGlpbLbwxAPoAqNt84HbDowyi+hoAaCisu5H5v8zZ1Hkih60tWt07Znc2DLpRdoLYMif+x1/jvd9sZItnwQK9pyj9Jnjs90l1VqQnFQtAF8kF09Jt9JPhgY8I9mJ7CKhtI86CgYoIo2NeQcpE5tNG7N/O7HuA7a46eoNFTybQIpyIN5MsOwoCDPgs7TZqmXvqqAm5/FRjuQyMfcQ1pIwZm+jHAadFSl8jNWuWrnumrJYSMFxgpzL6pxj9udP3EM9rJw58l+ZUE90XS67XPD2PohrhgoiLvKK3hQN4EBUxjf9uR8N5Wahtrn5o9qmdKljnVFmCfTUytx5c5mXKSAvTX5ZZ4ikVx3LZFzYXZ5LLiHzzDwjWdh4je5bZ5tAl5JGqzxAMxUkvgl8izAO2shGHqzmt5xoX6sFK8nmqPBRqHJB3i10eGcVIlXEbdN+TDWbTY+WHGWbT2asXS9kSmqHn6rEw0sy72Gto6ipooejTUVbY0uu8xW1WbFXyUNIJ/+dgay43Ir+2t0ef3ySI+LJLMpPADEm/UDQVsvWHJybEh6ToTncqZf8XwA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(451199015)(71200400001)(478600001)(83380400001)(122000001)(52536014)(9686003)(86362001)(38100700002)(38070700005)(6916009)(2906002)(186003)(316002)(54906003)(33656002)(8936002)(41300700001)(5660300002)(8676002)(55016003)(4326008)(7696005)(6506007)(76116006)(26005)(53546011)(66946007)(66556008)(66446008)(64756008)(66476007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5644
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d1833dcf-1327-4568-2d9a-08dab19e8c64
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zGdHCGuOdFis0aRmk1SljQwrV+ihJdjqfBAF9ET6WXHT8IannyaHfzJXFJvmQ02W+bIva57R/rMDXYDl3IW5ezt7Vdy2PEBXj0SqTAiXgH2OZivvgBdiZ+v/Xsw/QkXgabvxui1prLzdFh+sL2U0Sc1rqNVKo/Juu+BbnraBxsnlUghHWZAk1vht3rz50SfnVBcto9BpCdHJTL3MjcdHs0fUi6FLKqS8XvrCtiX3l1h7Hi33mpZ0mlo49HTd46zh75+6j/h5xEkK1q2s7Q/sTjtKdSMfMIVe+QuEhqxPV5U+aPP/bkQBd03BNNcKVB9NXd6kPq5qZ15esXLK+iJoNFhgSue1cfwlL7M5qTLOzo7bJ7fhfKoj04766H1M3UlJB/P4gkzojhhgaZt0JTpOmfd8j8isbp61l98ZWkDl4U8ycdp7QUqadzY1SzXYdbeRFas22IqgnrRgDMZMu1gRgjc55JY0Mr4AxBTLN4mzCbzvadfuJn1L65ChlGRj/NuPv+tpDkrwLjIWavid8YU0uzfAUTlgo84aLrcHjPDwjgH5c85/852RMJzwLTO1XlUdPLdusI+9or96VSwhUzdw7ixswSr/wub1Lw9s28MTAJGCYvonDD2ww7p3hcKFaf35VFXtVOLkuBOBHxOzLV1X0cSXU6Xi1ajJnorDCnaEHPX1WBPF/QlZKd4NhLX3yaOa+aZoqDPR2fLBoUyRBHX4sQjVXEzRv60hMwlT58mUxPapA9BtR9OaaLOJB0ZLhRmJMvS0XLcwM4d9nrlv4iBTdA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(8676002)(54906003)(316002)(9686003)(26005)(6506007)(7696005)(4326008)(53546011)(478600001)(41300700001)(186003)(2906002)(336012)(6862004)(5660300002)(8936002)(52536014)(81166007)(356005)(82310400005)(47076005)(82740400003)(83380400001)(36860700001)(70206006)(70586007)(33656002)(40480700001)(55016003)(40460700003)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 06:53:03.9887
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b3d2093-36a3-43a5-7207-08dab19e9213
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7541

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDEw5pyIMTnml6UgMTQ6NDYN
Cj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzogbmQgPG5kQGFybS5jb20+
OyBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgUm9nZXIgUGF1DQo+
IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgR2Vv
cmdlIER1bmxhcA0KPiA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8NCj4gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVs
Lm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BB
VENIIHY2IDIvNl0geGVuL3g4NjogbW92ZSBnZW5lcmljYWxseSB1c2FibGUgTlVNQSBjb2RlDQo+
IGZyb20geDg2IHRvIGNvbW1vbg0KPiANCj4gT24gMTkuMTAuMjAyMiAwMzo1OCwgV2VpIENoZW4g
d3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gU2VudDogMjAyMuW5tDEw5pyIMTjml6Ug
MjE6NDYNCj4gPj4NCj4gPj4gT24gMTEuMTAuMjAyMiAxMzoxNywgV2VpIENoZW4gd3JvdGU6DQo+
ID4+PiArc3RhdGljIHZvaWQgY2ZfY2hlY2sgZHVtcF9udW1hKHVuc2lnbmVkIGNoYXIga2V5KQ0K
PiA+Pj4gK3sNCj4gPj4+ICsgICAgc190aW1lX3Qgbm93ID0gTk9XKCk7DQo+ID4+PiArICAgIHVu
c2lnbmVkIGludCBpLCBqLCBuOw0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBwcmludGsoIk1lbW9yeSBs
b2NhdGlvbiBvZiBlYWNoIGRvbWFpbjpcbiIpOw0KPiA+Pj4gKyAgICBmb3JfZWFjaF9kb21haW4g
KCBkICkNCj4gPj4+ICsgICAgew0KPiA+Pj4gKyAgICAgICAgY29uc3Qgc3RydWN0IHBhZ2VfaW5m
byAqcGFnZTsNCj4gPj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBwYWdlX251bV9ub2RlW01BWF9O
VU1OT0RFU107DQo+ID4+PiArICAgICAgICBjb25zdCBzdHJ1Y3Qgdm51bWFfaW5mbyAqdm51bWE7
DQo+ID4+PiArDQo+ID4+PiArICAgICAgICBwcm9jZXNzX3BlbmRpbmdfc29mdGlycXMoKTsNCj4g
Pj4+ICsNCj4gPj4+ICsgICAgICAgIHByaW50aygiRG9tYWluICV1ICh0b3RhbDogJXUpOlxuIiwg
ZC0+ZG9tYWluX2lkLA0KPiA+PiBkb21haW5fdG90X3BhZ2VzKGQpKTsNCj4gPj4NCj4gPj4gUGVy
aGFwcyBzd2l0Y2ggdG8gdXNpbmcgJXBkIGhlcmU/DQo+ID4+DQo+ID4NCj4gPiBEaWQgeW91IG1l
YW4gJWQgZm9yIGQtPmRvbWFpbl9pZCBoZXJlPw0KPiANCj4gTm8sIEkgZGlkIG1lYW4gJXBkOg0K
PiANCj4gICAgICAgICBwcmludGsoIiVwZCAodG90YWw6ICV1KTpcbiIsIGQsIC4uLik7DQo+IA0K
DQpPaCwgSSBmb3Jnb3QgdG8gY2hhbmdlICJkLT5kb21haW5faWQiIHRvICJkIiwgYW5kIGdvdCBh
bmQgZm9ybWF0IGVycm9yLg0KDQpJdCB3b3JrcyBub3cuDQoNClRoYW5rcywNCldlaSBDaGVuLg0K
DQo+IEphbg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 06:55:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 06:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425516.673382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2zF-0004aW-0X; Wed, 19 Oct 2022 06:55:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425516.673382; Wed, 19 Oct 2022 06:55:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol2zE-0004aP-Tz; Wed, 19 Oct 2022 06:55:32 +0000
Received: by outflank-mailman (input) for mailman id 425516;
 Wed, 19 Oct 2022 06:55:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol2zD-0004aH-2n
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 06:55:31 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2065.outbound.protection.outlook.com [40.107.105.65])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04d256df-4f7b-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 08:55:30 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB9094.eurprd04.prod.outlook.com (2603:10a6:20b:445::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 06:55:28 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 06:55:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04d256df-4f7b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IlxLUa/naAtdjqpzFY10N+MYEX/hTkqOhUYSDaiC1tYnxJ5l8qvkmwRWXknXpYKGKSyRSWG8xmD444EhXFtyGE43ywypyfR92h3cFRHHDJW9FMBdfzx7iHiP+8dFNvnh305lol4k3Vv4TCEXwtjqAWJR46i+iyqCMshxed6UCwXcYyWTq0VgAlOGmlR9KFWKYb+CSaIdtnka4A8Y+sLEs2KSaM4mxdPIZGax+9yrLPGE23ONRheYisv7hp41X5hf4zSMGGycQzqwyAlEYFnBJYeZ6lt3oHHF2NNRUi2bYyM+1un3wpzfDFsVCp4uivbAvWHMQC2T1XCKDjzlod4Zgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pJgE8w/judukBxWXoRVGDNHZ5U7gAKDQRqwYYFOvqag=;
 b=WmnW4ogb49uPf6Lu3ZwUICrkKaOGNKT00dvyTmTWu6DQWmort3okonFaNWPiBym97mQw97GdHssWszuOxIJF8fh1PPdCQf+unZVZQl7PtKnH0AZBD/Q5FetjjLyEyCPnqml0ae4e6osfST1vM+zKqPsB54MmAgII2GKNnoy1PqefcR5Vqyv5m60iqcPJgAViOIZ06FhnLgHCzGpuslp3KATqDuDU5WUorQsEG5J/woqu5pMU44jWEjTq4lTOeCQZL0whxh+Pfrd+q3S54SQ9+n4eJSXMrkEjs+dWnF+wh/dfGP1etUJj5R9T3YHwJy6DF6NRzEDCLhz5N9d2Q/n4Tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pJgE8w/judukBxWXoRVGDNHZ5U7gAKDQRqwYYFOvqag=;
 b=Div9StNNwr43nmgENR9A+nvLe4v88yqgHKWF0zAsW7oWwMKNrE2B0uXG32GoIQPtNwIZZqp5C1ZHcV2R1/clElDd4hUfIAEXBTrNDFpcwuJBmn84tCSDeNs963TzMDpzk2lbmZ1hBKI0bEWliy3Dyn4sUxxffYDMNxk5nd2Tu2OedwwB4d9IhRX2Ri4clC05pahVb5jAuQJQUY2YgSXJj2UtkGSX5Lqn07hqC7KojQ6c+4NAWJIsKGl2fQAaqh796wS3EJSM6/VUbRofxudMXOQfCx7g1Wo+6CTc+KYCGD5I3NcRga2LaQK/borqICwDnrhl78L1iVjw9vIwBXokww==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <aa6ada50-8eb5-49b1-3e16-a3347ef55f2f@suse.com>
Date: Wed, 19 Oct 2022 08:55:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Chen <Wei.Chen@arm.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
 <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
 <AS8PR08MB79911F3700C0619BA1DA34DE922B9@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB79911F3700C0619BA1DA34DE922B9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0011.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::24) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9094:EE_
X-MS-Office365-Filtering-Correlation-Id: 2cd22e7f-6fef-456f-e0bc-08dab19ee7d0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uLHE+LUwIr/3Q3/RNQu5/9WYEuE4PRBPQLgQUWQutpDipdkt78MjqMLtK1g4Ii/Eu3dOgb8fch12C7yyU5sBcZWxTxW3SyU8A1JX3ebbhPiF2FBgHmZujy2JVq3X+uWy1G8dnD2XwVVSW7dOrStOB3wHZQJjgGZ1WftyiAd7flW80YZZwU1o/u8qwMLXJnjc22GzjLqhwNGyxwJorGFgWJhRZ2VkVNb+HTdq6a/nZZWX2xkZ/RQQPGHKI2bepPAPachfRMWV7HMxPfp+pSRgiUSvrhkp0EOxEebWGLhGWgD/NyGMakaGMkT+a6p7+sKmRwww/o/Ik1We1DdOfkE5Z4eP0dNhhX3PBEJZ/aLj5K8tBQnuByQhVRDF0vnB/MynenO6Ar/ujDhOHS4GlcpkVgTPVgU0ujVGG/f0/m5ilerMh/R3J0PmSOxYzkib6AXF9HHTMSjF8T9yKTKaLEMWl3kq2oYKvhIPVPqUyZaB8bMuc04BuH1E/0+uFYj7PONmSZjYfDZfKLVatI1z2AP8FqyzMCEXBXQh13ah3WtxlzT5O1IFrzHff7WZOhvKVGc1EKoSahNlXrGRA2znIRoi4deVpKJa5JtoT6ImGqz1cVzI43LHwEptoLaRXFWL2kB7tzC6USshZH7q7KdzH+yj17W49XYbRMdBWSvQSbZsbsix/gNJJSvyQ0JjYUgqSC/W+YhnnLGiv/jnGtzZJAJIreGgsaUc3ZihlEJTnRtlBpQZHvp/Omgyynl7aePk0kRd5FWGaP6MJPP8dYN+ezf+lsnMVONzoHVA2chzdT/XwV4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199015)(66476007)(8676002)(4326008)(31696002)(66556008)(66946007)(38100700002)(316002)(2906002)(5660300002)(41300700001)(6512007)(8936002)(26005)(2616005)(6916009)(6506007)(478600001)(54906003)(6486002)(86362001)(186003)(83380400001)(6666004)(53546011)(7416002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L2FqWWtNTlYzQVJmU3Z3cDNOelgwYXAxSkgvaitZQUJOMmRYUWwwNzNYd0JF?=
 =?utf-8?B?Z2xEMW9MNHJpSS9EZHNoaC9PL0s3N1MrNVpOUUdUVWJhK0Y1TWVLaldOeWNS?=
 =?utf-8?B?YnhIVkgrbGpIOGdjbGUyQnRIcGRIYlVXaVI5R09qb3FMcmNnSmp2M0w4d1NH?=
 =?utf-8?B?UzFHRXpMZW9NeHdvRlRlNjlDeU5rbHd0MnhPRVlWMVl6SVZiSVNWTmFRSGt1?=
 =?utf-8?B?NDE3dndxSTJYTmhkT0YvclRwanhUSklnaGFFbVVWMWxtU3R0SGQrU1hHSURW?=
 =?utf-8?B?QnJoYjY5K3RyN09KaEw3TzJkUGpHMlJJSnkzTlgyazNjVVBTZDRuVmlPbUgw?=
 =?utf-8?B?RkxSMzJQVldnWUtadmZIb1VsV25QUkE4TCs0cVI1Vkx3OGN6cUdHSldoWEJn?=
 =?utf-8?B?RmNmK3QwWkYybU9zcnhOR3dhSjRxTTVzdjhsR1RpR3BlU05WWmhXM1dPaXor?=
 =?utf-8?B?bklRZStnTHBxM0tZMnRjdTcwTEU4M0RYNE0wNHFjUzFjOVVSQ1VUVk95UW9V?=
 =?utf-8?B?eGl6b3pKbk9uNFYwRkdNL1J0dHMrSlZOcW5pQUx2RndmZnNGU2V4N2szYXNW?=
 =?utf-8?B?a3VMWmd3SjV2WlVSVlU5S3M5K1B3cTE2ek1hTXJ6RVVlZy9jTzRaMEh4NW1z?=
 =?utf-8?B?T0ZuMU1tenpNcnR3d3dpalR5dTFEclp0VUFJRE1jbFJwSDNyRWQycEc1cWUr?=
 =?utf-8?B?V1k4WDRNNTRIaGdzaHIweHZwMmcyTmk3MHUzdXdtVUliK0JnWUVWd01CUmN3?=
 =?utf-8?B?alJsekpPSjdNd2FBaXg0OXBZK1pHaXNRcGE0bEwzWGlPWWN4RXJidkRSZlhH?=
 =?utf-8?B?UU5TaGExejlkYU0wdEFxVEdMbk9PUytyRWZsN21IKzVQbVpmTEMrcE1BeG1j?=
 =?utf-8?B?UkNuWEZNU3p0Ym1ndFZnQWJScFBDQms3VnprZ2Nkbmp3U0I3SkFvMzZNWlN3?=
 =?utf-8?B?dEpZK29ZL1pLNW9NNHhTMkJYdHc4aHFvNENRMjZGenFaMENleS8xYS9xUUZZ?=
 =?utf-8?B?Z1F1WjRvaDlmTFVqV1czc2x0SERma292M0hDL1JBVDgxS0VRdjRtaFNXWnBG?=
 =?utf-8?B?a25qMllzc0tBQ2tDTEE2Sko1Si9JWGptUUJsajlaamltTVU3OWFRQU40N0x3?=
 =?utf-8?B?TzdFRUljNElYRktqRHc1RXFZaWpZeHpMQmtmc2xKWWVNeExidzNaWkRaU25a?=
 =?utf-8?B?UHp3ZTZwVXBVUGZsUnZPRVRMeXUwY1Fkc1RraFJCWEw1UTlpdlc2ZDkvV25l?=
 =?utf-8?B?emVZUlAxbnNaWkNXWmxQM2lJUmNCMDNTUmZjWlJVczFENm9RT05JY3ZKdmNq?=
 =?utf-8?B?dGpKalJncHJpa0VOTVBjVVdpYUhSWkVkS0t2aXdoMkRXZXhXSExzQnFsUU42?=
 =?utf-8?B?bDlFR2NQTVY2SU8wcGk1ZEFMSkxUKzhHZ0Y3cTZhMThlY1lVSUEyUWVCUmRI?=
 =?utf-8?B?UEIyaVZiUXRidTh5ZjVQTitPRHRROHJBTERlTUtVZWpzQ0h4bEFMUFVDbG5G?=
 =?utf-8?B?aUZlck9jTWkydVI0bEt6MHF1VTkrY2cxbUpCNjF5T2lmdnNobVh6cVdqeUNO?=
 =?utf-8?B?VEdhaEJMQnlGU1JUcmxGREY1WkM0UC9jbFUybUI4SVpvYU0zNWRWdW9vRmtN?=
 =?utf-8?B?YmhoUEo5UmRhLzJYTlA2NkdXVkJjYTR0THFPVjFXNnJHbkEzQ0N3VWZZR1BN?=
 =?utf-8?B?d2V2a3FBNlFjTHJ1OHR3MGUycUhxSWJ6VDA2K0I0MXJRSFk5cGxOZlZvRlZw?=
 =?utf-8?B?SHRHdy9RbXY2eDNobVYwSWJ5R3NQSUh5T3ZlMDdJUHFDUWZndnNzbmd4NXJ6?=
 =?utf-8?B?RzhNbzZrMXZUMlpFaC9lTlhjYk55N2dWZmo3Z3Ezc1dRNlQ2VFBPa2dseVh2?=
 =?utf-8?B?amswT0dqekxyNUJDWnh0K0E2VnU2S1MzSTlCaElJa2lYQmU2VkROY0F5T3p2?=
 =?utf-8?B?VTNaY00xdzB1T1JHK2VQMDBNSzhVRmFtYXBhenV2eFNBNjBBZUNObDNkM2My?=
 =?utf-8?B?cXIwWVhmYjZyUnBQaFRGclBpdytZNDJJanhIZnRYV1BramZOVFM0QkJISVpu?=
 =?utf-8?B?MTBjbzcyZUNqV09wUmV2YXYyMlB6dnFKQmVUVk9BQW5xdjQ4OVdXc3NRZHg5?=
 =?utf-8?Q?UBeErvKI2ZSpe54crw+V0/9W4?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd22e7f-6fef-456f-e0bc-08dab19ee7d0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 06:55:27.9771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iya28X7RjTF+xGf9rEP+6xRubfZYTZ7kc98z58N+/WlqtIhDNRiWG/U8DuM5lGMlYNguog9XxBCpdbC3f2dzhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9094

On 19.10.2022 08:50, Henry Wang wrote:
>> -----Original Message-----
>> Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code
>> from x86 to common
>>
>> On 11.10.2022 13:17, Wei Chen wrote:
>>> v5 -> v6:
>>>  1. Replace numa_scan_node to numa_process_nodes in commit log.
>>>  2. Limit the scope of page_num_node, vnuma and page of numa_setup
>>>     function.
>>>  3. Use memset to init page_num_node instead of for_each_online_node.
>>>  4. Use %u instead of %d for nodeid_t and j in numa_setup print
>>>     messages.
>>
>> The only instances of nodeid_t typed variable uses that I was able to
>> find are in dump_numa(). I guess you can leave them that way, but
>> strictly speaking %u isn't correct to use for nodeid_t (as it promotes
>> to int, not to unsigned int).
> 
> Sorry for suddenly jumping into the discussion. Firstly thanks Jan for
> the review :))
> 
> I am a little bit confused here, nodeid_t is defined as:
> typedef u8 nodeid_t;
> 
> so I think here %u should be probably fine (I may have missed
> something though)?

%u is indeed "probably fine" (hence me saying that they can be left that
way), but from a strict language perspective it isn't: unsigned types
more narrow than "int" promote to "int", not "unsigned int" (and type
promotion kicks in when passing arguments to functions where only
ellipsis is specified, i.e. parameter type information isn't available).

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:01:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:01:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425522.673393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol34b-000657-M7; Wed, 19 Oct 2022 07:01:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425522.673393; Wed, 19 Oct 2022 07:01:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol34b-000650-IW; Wed, 19 Oct 2022 07:01:05 +0000
Received: by outflank-mailman (input) for mailman id 425522;
 Wed, 19 Oct 2022 07:01:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=G2xL=2U=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ol34Z-00064u-DF
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:01:03 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20080.outbound.protection.outlook.com [40.107.2.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id caaa59a7-4f7b-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:01:02 +0200 (CEST)
Received: from FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::15)
 by AS8PR08MB9576.eurprd08.prod.outlook.com (2603:10a6:20b:618::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:01:00 +0000
Received: from VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4a:cafe::31) by FR3P281CA0043.outlook.office365.com
 (2603:10a6:d10:4a::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.17 via Frontend
 Transport; Wed, 19 Oct 2022 07:01:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT046.mail.protection.outlook.com (100.127.144.113) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 19 Oct 2022 07:00:59 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Wed, 19 Oct 2022 07:00:58 +0000
Received: from faf9a8707409.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8FCFBF96-695E-47A3-9F81-9E85DBD4C1E4.1; 
 Wed, 19 Oct 2022 07:00:49 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id faf9a8707409.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 07:00:49 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by VI1PR08MB10029.eurprd08.prod.outlook.com (2603:10a6:800:1c6::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct
 2022 07:00:45 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:00:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: caaa59a7-4f7b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=j0Iy+Ev5noo7dZwOxpOMJoOXuU1cg7MdtX+38o35I5RiOmtSI5ysTf1MUKVETGwG0ab6ARuvbeik3U4TqM9Bog8b1T2suJS5nw9/QVneuV/GxERPkOOeyAnN56VIb7rgW/BGGLjgZ6JL4X9wmu0juDVji+LnronPnZ+y9rQfX7emr9MWr2SWeHSdLPLMIQclKTsBpDui/c+04tvHEBVbvTjwE6toqljIviKa4WA0Dks09C9vqUVhKkJlI3oyT1k1Y5L1L44gRZoQFZn2sMmkt7MAN75vl8iuByAcZBcTTOqFm62D/5WRr1vo6hdF4zmZ829o9k6yuu997tgXChicNw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZWBACWjmM3frdlb9BxYg6vvmstDvji8EwYqqLzcqGW8=;
 b=WzpNcWgR8EVDzlaWeLsiZcnXF5X24jGl1fdkMopl9EzyIK1YZZWC/WsoSM007YWfb1mYCpWc6EMI0yGNdHWKvFp4WhbTpNCcuG2enx1o+9mjlgQigAd1uT3vQ1Dr7JMxcZ7fF+lsAnXR4k0EY2xABGVdAAjn0lhErUv9B/p7Yo2nbdv5qnIV5w8sOMwbh5mNi62w3jMZIlGEE4vNSXM8tL3Qiq3oL7oFbU+3trgA3DJpgk8UOzZJA/hn0NSLOhuyd3+Nh1Bk91mymI46vPq4h13i581A/dl7Bl5z+Ltz7fVJOBX6IhgikrI/w/YC9o68QAk8Fje0LXfMVgztukioiw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZWBACWjmM3frdlb9BxYg6vvmstDvji8EwYqqLzcqGW8=;
 b=MuoRrW8zt6sYLUEknANKhvfEx7g77kARn41ylZ5C7ObPHVOLeDCOnzb3eKEraz1HCK652k4x+rDrzUa3aaady1G8KwTCX+WXxu1G9IjPwBw8VBAb0e//AhWjxsVdjtiWtRX7OMdOsxudObB0Tf/XRgN587+met2czkDnwLBfJXI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VlcLCrHW4wWyXv+OcLCRbruRkyjCQ3Jr6Sb8ByHvarPnJ0styA1x+6YSsZ8LBd0EqmisuYNm8S2d/vKGASKZ8CyIlrXE5thrNhyzhjsWQ5QLLDNvm5KU2X6XRQiMFk+1SvNqYXLl9uhO09MRDla/0r6wZacG7M6gWhMEZt/ZGEsSVDCcLcv5yrIuMJaC/jIzPP2B6R4CwM9oQO1SqaBr+e8Z0MRfuGw8WcZnMb0DCpGTSRlf4PzJb2vxrOIlXgZ/JFJG0dlAhFQOHtG7enHeALhaGtLoesDJQNhuOZPP+EFhZxLuV3v5AC2D1K7vWlebSdJjShaCD6NlD4eBsHT/gQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZWBACWjmM3frdlb9BxYg6vvmstDvji8EwYqqLzcqGW8=;
 b=NWEpfASdRKN9hvjpES5bFPyk/7q3el0cNM4eCrBmSBMz41ADEO4CniKdP5xM9TnV3Qbm3KonM1iKgrdY283orXCmSE2YJt4pEz7yp1EYlV6P+lE2sKXjtgmbGISTBQokFiW79V2icZE5AxIRcWW3Y858/VwuW/g8LjADIxa7q2JJ/EELBM8DP89lvrRtQkbNt9yNQYXlh/0i6afSx0AsM4T9HJua7baKrnXMJHE/LAAi4+baPydf4rYldzYnM60eTkI+Y/Vd4sQDqk/f5KL7K5ykWjdyymMAHPKYD6rv6CdLDp2W4vCSUNuWt7JYXwfRaDWYUtsS6IzBmPPaozYKiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZWBACWjmM3frdlb9BxYg6vvmstDvji8EwYqqLzcqGW8=;
 b=MuoRrW8zt6sYLUEknANKhvfEx7g77kARn41ylZ5C7ObPHVOLeDCOnzb3eKEraz1HCK652k4x+rDrzUa3aaady1G8KwTCX+WXxu1G9IjPwBw8VBAb0e//AhWjxsVdjtiWtRX7OMdOsxudObB0Tf/XRgN587+met2czkDnwLBfJXI=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: nd <nd@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Chen
	<Wei.Chen@arm.com>
Subject: RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from
 x86 to common
Thread-Index: AQHY3WMp8fkwGFUvPUGj/zptqNRTAq4UNRwAgAEdejCAAAIqgIAAAIHw
Date: Wed, 19 Oct 2022 07:00:44 +0000
Message-ID:
 <AS8PR08MB79919D975E305428D47B9500922B9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221011111708.1272985-1-wei.chen@arm.com>
 <20221011111708.1272985-3-wei.chen@arm.com>
 <039ba141-766b-a7ea-2124-be396e8433f2@suse.com>
 <AS8PR08MB79911F3700C0619BA1DA34DE922B9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <aa6ada50-8eb5-49b1-3e16-a3347ef55f2f@suse.com>
In-Reply-To: <aa6ada50-8eb5-49b1-3e16-a3347ef55f2f@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F4127F475E87334DBC5CAC8B1F99DC38.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|VI1PR08MB10029:EE_|VI1EUR03FT046:EE_|AS8PR08MB9576:EE_
X-MS-Office365-Filtering-Correlation-Id: 462c2a12-0f04-44b8-fdf4-08dab19fad75
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Qrie4ol9Q2gRJNec5Jpex/1qgQiQwxq2tmHZfMe8RUMzKxqeUzH5FrX5EjlsbW0fgnYbfx6epZuuZ7zDZzFLLz/gyLMns0BlzC0OZ3YabrdpMmXh/17ARqdJCDkI26EjZ7nM8TrS2krmnVVTggP4VsC9Lx1E+PigfQiRAnEJzVVbIAfUY8FulpJZcmRNudOeywaB1fB7CQLgDndTQ2LTfFJvkvKR4ycWh6nfGl1RsbOvV9Nwj+nHA0TFSrTg8lLTLlWa4L8+F7Te5sN3eSQUYO1OPIoizFWwkDAdloLdK2NcPxwO7EHJ6OT/WmCRBcY6jQpZz9whmXIu1oPYqc/Dt5pfOiWcI0LQzIgTxzHYRsTG6iOuKlZk8FWu7vwf+COZ7DJeZV1hk7LVCT0VhlaaHNf/9vLkoBPl+CJF1AVyWTIasGnx5CzRwaqP+m6LNqZl/QM8CYHH11ZwSbs+D7uCrxiT2N632gHZfcCZGI/feHmlOQ0bqEi+yRFnvIL7PCyGfqRTSWmcI2ONG15mycJccWGEa166wCgT3xMwr88BK5SZLrdXGdmdWXL7FEkzWpI70tfxvbe41K6FbqZKH2g6kRIT7A7lq00I1a4oR2KhazTQmknwxN2EzHQtiwmJpipkox1NmqUcBuCIp6ITatXXI672KxNzDgKYyGkGImhrbHuOtyOOL+1BVrDkhaPsGz0z3rNPvY9yIsBybjLibSoWfwx0Y3HYldJBV+eYKF8Tl4BLaeplm3+swG1/WPghqVJCABxWuoL4NhkT6/CNk5HaEw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(86362001)(33656002)(122000001)(38100700002)(38070700005)(83380400001)(7696005)(5660300002)(26005)(9686003)(55016003)(6506007)(186003)(2906002)(64756008)(478600001)(316002)(71200400001)(54906003)(6916009)(8936002)(66476007)(66946007)(8676002)(76116006)(66446008)(66556008)(52536014)(41300700001)(4326008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10029
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c6950acb-432f-43e2-b69a-08dab19fa4cc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rdHWqX1/cDZSXJsrykSouZm9mupxg3ICzv9NgtpyH71KUpRXChPUBMMWBTRBLkm3ZYm6j5J1GZNLxQOMxdMopOwmzMTO9rTILmoGRxkwNGkDOHc7VEdDQTr7GnAfEcKFePR0V9tlEeWqVSmE0dV0mD1xw8tdMR5cLTMSlFzXGSoQARcdnCWQS2Cz3648f4WSO7pVrQTqfyDUnsEVnFTijvuUAjF0MqkJmkgmIOmcxPP9mnku/25thGGBQByMEBZjLH5+bTTsQEayfQ1W+xofS4C6HSqNGfyT6fyaHQhJoIC9LQGcTnJm6ddby4l7chY4ViPlTHhsZu8J0JdWtYNugWCMZaHwdSYnSNBmUkLu4d9cO0kLT2BmeTVlUo0HGOsIQ13YyJinW8RJKM4S0c1nZVmzUuqgXipOlYhMx7m6Bx5MtYLC8uKEGCjyjw1GfKlSBKlHki8xpGSvn98H3ww2d+W4d2SUGriCsjIhVZNYSIfEdkA3XfpMAaiFaOQjjMeSqsGfstE6/THnNHJpD9188TIn7hKwkwTaqJgpwO3GxzsXcnn3SHIxlYOqaM5TT4rFPXT5fvDtGDdkCxTA4MEflaH1Fky4l+2Oiicq5M5Ns0Z6iFmzXbrLyVDT9PQr+tNPTBcnfjQWhFjK/odr4wq2VgMlbyceFr44c4u4PBvnd5UDi8iZAKN7vbPCm7tjfnL6sFdgporvqT6cyP0/3B934ls5GCTxTqqyH9U78PnQZhkEK6RnCtkub/NBGqsajZdkgEUOYT8jzLm+whBHiJkTcQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(33656002)(9686003)(54906003)(4326008)(8676002)(5660300002)(70586007)(36860700001)(40460700003)(70206006)(316002)(2906002)(478600001)(41300700001)(86362001)(82310400005)(6862004)(8936002)(52536014)(83380400001)(7696005)(6506007)(186003)(336012)(47076005)(40480700001)(356005)(82740400003)(81166007)(26005)(55016003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:00:59.3360
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 462c2a12-0f04-44b8-fdf4-08dab19fad75
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9576

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4+ICA0LiBVc2UgJXUgaW5zdGVhZCBvZiAlZCBm
b3Igbm9kZWlkX3QgYW5kIGogaW4gbnVtYV9zZXR1cCBwcmludA0KPiA+Pj4gICAgIG1lc3NhZ2Vz
Lg0KPiA+Pg0KPiA+PiBUaGUgb25seSBpbnN0YW5jZXMgb2Ygbm9kZWlkX3QgdHlwZWQgdmFyaWFi
bGUgdXNlcyB0aGF0IEkgd2FzIGFibGUgdG8NCj4gPj4gZmluZCBhcmUgaW4gZHVtcF9udW1hKCku
IEkgZ3Vlc3MgeW91IGNhbiBsZWF2ZSB0aGVtIHRoYXQgd2F5LCBidXQNCj4gPj4gc3RyaWN0bHkg
c3BlYWtpbmcgJXUgaXNuJ3QgY29ycmVjdCB0byB1c2UgZm9yIG5vZGVpZF90IChhcyBpdCBwcm9t
b3Rlcw0KPiA+PiB0byBpbnQsIG5vdCB0byB1bnNpZ25lZCBpbnQpLg0KPiA+DQo+ID4gU29ycnkg
Zm9yIHN1ZGRlbmx5IGp1bXBpbmcgaW50byB0aGUgZGlzY3Vzc2lvbi4gRmlyc3RseSB0aGFua3Mg
SmFuIGZvcg0KPiA+IHRoZSByZXZpZXcgOikpDQo+ID4NCj4gPiBJIGFtIGEgbGl0dGxlIGJpdCBj
b25mdXNlZCBoZXJlLCBub2RlaWRfdCBpcyBkZWZpbmVkIGFzOg0KPiA+IHR5cGVkZWYgdTggbm9k
ZWlkX3Q7DQo+ID4NCj4gPiBzbyBJIHRoaW5rIGhlcmUgJXUgc2hvdWxkIGJlIHByb2JhYmx5IGZp
bmUgKEkgbWF5IGhhdmUgbWlzc2VkDQo+ID4gc29tZXRoaW5nIHRob3VnaCk/DQo+IA0KPiAldSBp
cyBpbmRlZWQgInByb2JhYmx5IGZpbmUiIChoZW5jZSBtZSBzYXlpbmcgdGhhdCB0aGV5IGNhbiBi
ZSBsZWZ0IHRoYXQNCj4gd2F5KSwgYnV0IGZyb20gYSBzdHJpY3QgbGFuZ3VhZ2UgcGVyc3BlY3Rp
dmUgaXQgaXNuJ3Q6IHVuc2lnbmVkIHR5cGVzDQo+IG1vcmUgbmFycm93IHRoYW4gImludCIgcHJv
bW90ZSB0byAiaW50Iiwgbm90ICJ1bnNpZ25lZCBpbnQiIChhbmQgdHlwZQ0KPiBwcm9tb3Rpb24g
a2lja3MgaW4gd2hlbiBwYXNzaW5nIGFyZ3VtZW50cyB0byBmdW5jdGlvbnMgd2hlcmUgb25seQ0K
PiBlbGxpcHNpcyBpcyBzcGVjaWZpZWQsIGkuZS4gcGFyYW1ldGVyIHR5cGUgaW5mb3JtYXRpb24g
aXNuJ3QgYXZhaWxhYmxlKS4NCg0KQWggeWVzLCBzb3JyeSBJIHNob3VsZCBoYXZlIHRob3VnaHQg
ZGVlcGVyLiBUaGFua3MgZm9yIHlvdXIgZGV0YWlsZWQNCmV4cGxhbmF0aW9uLg0KDQpLaW5kIHJl
Z2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:36:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:36:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425529.673403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3cN-0001Gz-F4; Wed, 19 Oct 2022 07:35:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425529.673403; Wed, 19 Oct 2022 07:35:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3cN-0001Gs-C5; Wed, 19 Oct 2022 07:35:59 +0000
Received: by outflank-mailman (input) for mailman id 425529;
 Wed, 19 Oct 2022 07:35:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3cM-0001Gm-5d
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:35:58 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab3b7703-4f80-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:35:56 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8765.eurprd04.prod.outlook.com (2603:10a6:102:20c::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:35:55 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:35:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab3b7703-4f80-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GRpUL1hdUxnvsflbQC0TxQ9A3MQk4hqqiV6SqWVbc8g26ahifVzCi7kBN+ghNaZ4XfAf3gGw8PfvpJUwpT4QAjADU/bp4MWOvnpSSUXY6w3AvFjrh5702K1i11jaRcAZ/6l26J/f+uYbZwVbN7dNua40mbrYU7cXMhzxbLr8T+bcQJybo9zjYqfWLaXyMhsJRPd/W87lNYmzb2FYNw3NlhQIxkWRi8iv2BNOM9V+vrUG8DdbYYTR3w2zHG6rqkCqRMfMq04ETii7XvYu3JLdUv9OmC1sEjZ4hz1I8XpmdPRM1YG4f1sU8cPvMXNFdeKY2jhGX4Vo/KHHVYFRXuxFrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pJiD6Q6jenheJKbc0kl+G/6YfOjBRubcoZo+kdEjwhE=;
 b=nUZopUszHUP7dpOtKtkiAozYApF/1RBVQiXtid/e++Lm9r49QfsPLHnWXgeH4lhbgsicC9rBDgLscuFj8G6zThR93J+pJHAOxEP2LMbbyMJSUBMlhSptWNh/rNYWNfesrlMKaAItVj24So/aMwxxChjIJAaXr+HJg5AMFrrcLDZ7qVz03p7pXN16nYfOqjZ9VPSGkIzpaD4WjUYzb6hfqVES5stdI5So337VkNhZ08m6yOQwOUpnCjYhbpiTqjUjurVrEKeze7IaFlmBJwrLeWb7V+i9ulSydzLGYqlZvd0ACLsEfenJaPCfjHNtWbyldYVQ12Nb0fmCj2KUhz3xAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pJiD6Q6jenheJKbc0kl+G/6YfOjBRubcoZo+kdEjwhE=;
 b=YsM2pbpxZjEDtrtDrfBNKGEJR17BWDoFqyFCrlqxYJq9ZgS5OpOxzMThBm6bpRrKemZUVugAqbiK8UVoo/H+nXf8Jo8mv7liOvYdFCwB7uEVOuzTP5MDIfSoPa5ifIJXB42gwLPkuEEzOpVVfBBBL2bG0bn5IV2pS1zDdM0t7dGqCKZhuJ0Xogd6pUXmvPclVF8oHhIhNnFlKTuOrrB8CUOHDMRaexjrwOyVGDSzP9U26coksLXww5VTuLtkCZix+p5DHNfVYDnW8x5+krxNNzZYxY5UpdQMwGJBpDPGy+hH90JdFhSQx4QlSmsZi8ARDSfIZooI4zfFdZno2bcL6A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Date: Wed, 19 Oct 2022 09:35:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH RFC 00/10] runstate/time area registration by (guest) physical
 address
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8765:EE_
X-MS-Office365-Filtering-Correlation-Id: 352459a7-0101-460b-71ba-08dab1a48e4f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wSdxzTX9Y1uwigUXPImfB1xMyRvttgAeSzvLeuuOICV2EOX3AtxJdPCQsusDzNGGIOOEI8VBcV5rFep2Go84BfzooangBRvQET4NMcF4oXIzb57WhDTlYcymMOuuP8l75V5Pgan6rWHxgcyZQaN06dj+9jWw0d2fXAfFJqwGAFCHyi4bYnIdSE2PNN71PwQ7A5JU4F+NbfYnhD7YXD3p/BIxs0tRgovs3DQ24oMnJsb8/KgjcMAuPv5lxdnyBtKvZp/2V0Rj59sLYlQJa1tp6fhHhACxIKQZ9qw9yBFKuXq88Pz2dXyBGgZvzfxigJmDW7m5djIlGM+Yn5V8+D3LDUCPEB/MjvsuuHgC7ukZWIE3gPxe24vRIi6/B4bqhDBa1clZSUmDKFkLGh0pQ0A8zr1m7v2SFfoY8qbifz/EGah/p7OwbfCcrE9io0bJn/bWLgm9z48jPQdTdrf1OibjQ2w7E+Pm8RgcSyYEX4YzpARwVMYBrwfyRk91BO1QrkAW2TTotF4EGRJ37aoIHcW0+SXGOxgYt50ArCf9Fk/fGF555pAzFTxdtq9+/ATiVMXJX5IBv1vAAF6blLWLtArB8olUp/CnVSlSNH6yabGItgt4GVVg930RIpznzBoquwTSu+fAQs6Bl853qqtBuZ4y8+s527Bb4XkqnAf/6llxSP6sKkXmI1wGs2hUYbpq2g1PMY6j3lKfJB0pg3qBvLq1H+AOhCpCqy5Q603Qj9uQQRcZm033kppTjfrSAYBg5dPDLVlV7mUxrA14ZFy/apC3YwwDoS70EBvRu7Y2ovYaDtc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199015)(54906003)(186003)(6486002)(83380400001)(86362001)(31696002)(2616005)(38100700002)(5660300002)(2906002)(4326008)(41300700001)(8936002)(66476007)(6512007)(6506007)(478600001)(66946007)(316002)(66556008)(6916009)(8676002)(31686004)(26005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eGNtK0ZEOVFxaGY0K3QxQ2Fnd0dDckVlK3VFaU1hN2dxS0x3UzZqdEwyMjg4?=
 =?utf-8?B?R0cvWVVPSEZteGQ3SVh6SGh1RUJ3TjFkdDMyd2dQc0xMa2VhUWxjNWdtZjBN?=
 =?utf-8?B?b0xsYlFVM0t3SUZ2QWo4RXRFVUUxcXptc0QvSTVYZmNsOFRsL1RWUmZHMjly?=
 =?utf-8?B?OU9aTGhtcE5FMjZmMHZCTnNRZk5NYXFBaFhFRlFrMWxOVGpOYWtXcVA5TGNz?=
 =?utf-8?B?Umh4YVRJYnR1NXppaWNkaE9RbHJrV2hZb3RnYmVKb1NTRFo3TzZqaTd3Y0kz?=
 =?utf-8?B?NmswWTNUUkNLOGpmckN2KzlkT1Yyb24wQ3NZbjFYY0JuYUJ5TTd6a0d0ak9u?=
 =?utf-8?B?aFZidndIZmRmc1U2dlh1MzlCMEc0S25QU0hONzRNbEZpa2hpTXpWNFR6MlV0?=
 =?utf-8?B?VXRZb1ZiWDMyYVpncUVZOEJzc0loaURva1o4dndrMmVWVGRjMndMVjFkcGVk?=
 =?utf-8?B?L0I0MGlEczZXQTJaK2Fjb2szdytCcHRCOXhHY1BMSFN6ZzFSNTZCTU5hbldC?=
 =?utf-8?B?Ylk3d1lZSWNJY1c2TERkSlZPQjJjaUlEWE1zODdhZDcxdVpYc2pzdUVaTVB1?=
 =?utf-8?B?eVdrY0JHNUQ4WmF2UllzMC95WGZ0MU4wTy9hWHBkanF1QXJTQ21UQnNzc3o5?=
 =?utf-8?B?ejFlKzkwcGNjMEsyR0plTE5pNGtmTTczWGROSnZKenhJbnYwcURZNDVKV0RW?=
 =?utf-8?B?bWhEV2s0N2t4Y1phdU82NCtMaG5udTZ6NGFZenVpYkxTOW1lZlQ0c2lDM3NW?=
 =?utf-8?B?K1p0NUxpcFFQV0ZoOTV6SENMNWNtZkl1OUNwUjV2OW1kbkk4SXpaaTRHMjIz?=
 =?utf-8?B?dUZOOC9TcHk2U0lqMmh1eGtscjM2NVhudms2SnB3RkxMWU8wQ3hwV21Lajdl?=
 =?utf-8?B?bkxIS0xqdWJXSC9SQStvV1AwR1p4WDZ5UmZZWkJXVWZZU09GOGVlYTYwcklS?=
 =?utf-8?B?bzM3b3FreEYzRmZtU1dNSXgrVE9naVpIVUc5MHpVMlNJZmZ3OUFWaWxtL1E3?=
 =?utf-8?B?d1Y5YnA0V3UvYlY2Q2wrUmNxWlE2Wmpwa29Oc05XWUhlaUp3bUQraXRMNVlF?=
 =?utf-8?B?a1ZSU2gvaUxITmNNSEhJVnpjWkZZM1owTDIwdHdsUmVpa2NURks5S0w1Zjdt?=
 =?utf-8?B?Z3VEU3kzTktDRkVZUWNRNFRVS3RLN3JqeHVBRHgwVGZJMU9XcTJWazRxelZs?=
 =?utf-8?B?VDFwVmhKKzFBUmpyeHdha0VWYUJiSy8wbGQrUm5Nd1BhQk9NV0RGVGgvUVA0?=
 =?utf-8?B?a0p2aFR0Q3o1Mm8yTDJHQStRbDEzUTF4akhBVlBCRVVSN3J3Y3AzZmt3Qzk1?=
 =?utf-8?B?M2hEZUpFdFBlbXU5MnEyWGk5SkFrUkdtcTVKLzRTcFlxMmkvS2ovempRaVNv?=
 =?utf-8?B?NnRvcFhKYUxXNE8vMnVDbmlXYllSa1FsbFQ3cXZhTHFmaXQ4T0s3Nk8vL0Yy?=
 =?utf-8?B?ZE9GR0tmQ3RPNFdDTXhjcjJ6cUxBSFBQMjJqS3hldm9iZnV1T2YwRjh1eVll?=
 =?utf-8?B?OWNkSXJMV2t0eklVV25vWWZJc0RYNDJUY2R3MzFsalZOejRzaDBTUFd1ella?=
 =?utf-8?B?Mzkra1RWL2Q2YWNvaUI1cWxidzFadlFCMko4MFA1ZXFyS3VjVnZxWXdQYWYx?=
 =?utf-8?B?N2JENm9wUDZXUUt2Y3FDNEhCdXFVRWVkN0JGUDJ4TjlCSjZuc00vMjBnd2Ux?=
 =?utf-8?B?SWdDa2hZb3Nhc1psYlZ2bmxySWFDZk1Xc09ZS3NYeDhFTWcrUVc2SFF1cGEw?=
 =?utf-8?B?d3ZpTFZNdGxjbTNBOTAyamFsSXJSZGlFM0F1YjdpMDJVSmdkWDBmZGhBanN3?=
 =?utf-8?B?eFFCdjh0WGFDVzFHRlNGczRBT01mM1ZGczgydU81eVZTcFNJZGk4RG5nKzZU?=
 =?utf-8?B?b1U2Ly9kOGJsTEFOY2lYeDduVHEyS0F0ZmtLMGJlMXkxSHNyM1pHTzc1ZS9y?=
 =?utf-8?B?RXorT0gxaEE0TTJKbnVqQmJTaGVTN094aCtHYTdxSlVhMEFodFV6ajRRd3Vs?=
 =?utf-8?B?c3grYWhHNzVta0Zkbm1xZlVBM3djdys3WHhoNklpYnRteStTS0ViNkpmalBy?=
 =?utf-8?B?TW1BTFAzZDNNNzl5aEF5em0xbytJMFFHakErM2FWY0VRYnJaNlFIOW1oWU5m?=
 =?utf-8?Q?ibpx/4oPpWmcGdqib9q9pLI5V?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 352459a7-0101-460b-71ba-08dab1a48e4f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:35:54.8232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vl2OIor66yYD2HaPUluiqSbcReYSuh/hvYQtP2JymtWIGqcZ+ZHrRf7gvMQRLQojnWi3y4rfHpR5ijAyDXgAQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8765

Since it was indicated that introducing specific new vCPU ops may be
beneficial independent of the introduction of a fully physical-
address-based ABI flavor, here we go. There are a number of open
questions throughout the series, resolving of which is the main goal
of this early posting.

01: unify update_runstate_area()
02: x86: split populating of struct vcpu_time_info into a separate function
03: domain: GADDR based shared guest area registration alternative - cleanup
04: domain: update GADDR based runstate guest area
05: x86: update GADDR based secondary time area
06: x86/mem-sharing: copy GADDR based shared guest areas
07: domain: map/unmap GADDR based shared guest areas
08: domain: introduce GADDR based runstate area registration alternative
09: x86: introduce GADDR based secondary time area registration alternative
10: common: convert vCPU info area registration

These go on top of the previously posted small bug fixes "common:
map_vcpu_info() wants to unshare the underlying page" and "x86: also
zap secondary time area handles during soft reset".

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:38:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:38:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425535.673415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3eq-0001rl-SY; Wed, 19 Oct 2022 07:38:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425535.673415; Wed, 19 Oct 2022 07:38:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3eq-0001re-Pb; Wed, 19 Oct 2022 07:38:32 +0000
Received: by outflank-mailman (input) for mailman id 425535;
 Wed, 19 Oct 2022 07:38:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3ep-0001rW-8o
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:38:31 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06667bb1-4f81-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:38:29 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB7053.eurprd04.prod.outlook.com (2603:10a6:800:12f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:38:27 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:38:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06667bb1-4f81-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FZXSvtQuIDjkdFus1q3OLD+4gR7p7iKbr9kjMGS6aneK8qr17tB9PDmpAr9Y364yp+8WxqOTalInYBtnmD8/dATU94ilMXVV0BD7n69Th8ELz0+ud5TA/hq22PrRDLQDHJESM/26NFPJxOYhJlO5A4cClOk6fMMfx588ZFf2Ia0XM86y9PUzbxW3fFej1VyEmt7Wl6B7JyvVjvBpnlsxYClXRuGgE6GapFg3etDSJr8b53t2h0aIbJd6hOQ8h6T1Lh5j57YLQtGpWaVMt/+/aLfN6HrpOPfOMe2t6YVawOILeenniplpJlyJ1Y8GqKqHNGMGOwlks1WSsP5m7XHNZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=COQfJ9cXtlA7UIJk7VaHsvDyCd7LmdLVrgloG0YU3Gg=;
 b=jjryaKi0TlalE8tNftmC+dFFcMr2DauN0YpAfAqcGzrqzveQsjRpk6rnpYnyWUJlxWY8wpl6HqvNmYy6Z9lWL/UJUukHsxlxRAHz6TF4deGRlF1UBnfBdwITtTLBCbsIX9K5wi88zz943KPBgi6CcQ7/8hGafzaqAirQEjz+QsnSjXmtmrsEsgLx455RsP+OOylsoc60UuDREVJgpODvK+0H1BR1Gw77pXoyEuEhsyWyQ0dXlOlAgKDMNH66auBszoyVAqkYehNFgWG7Z7u9Cak2wBQfLDzN9Ekn9cIs5/+uJERG29WhRgOSrHSp+mvgQ5OIo3BELmoGx7SMnHCDwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=COQfJ9cXtlA7UIJk7VaHsvDyCd7LmdLVrgloG0YU3Gg=;
 b=ek5QYgbLywyD/y1tHbgWsUxhvWgiZFXZhawagYs5mzZaWV6MIA5Y60KxU58BpBHDV2iuHbdl2Sl6a/s0Ox4Zl8vE0+rg8yxWFVCE/5fCXt79UeD3o/EjaT6eLhqAX9GleZQBr76eRImo5UgE5Rchlkbqib17mDyfQsVK06u+AE0LvZU1Q27Jzmt9uFYTmWN5Jkt9Cqiw5Dby0iAx8lxq7r6A1JrH8m5AkG3K2wpk++KIhBmbTCJAzmNBeN+DXSGnxouQjojQs+n/0amGPxByOiV5dc4Txa94/UwUaiJiiEZOLK9ja3brxt/GlzHX9UAPmuGvbcHwP6vYo4mwUEbS2Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de5c29dd-7827-10e7-9d12-bd8a9a048fed@suse.com>
Date: Wed, 19 Oct 2022 09:38:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH 01/10] unify update_runstate_area()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7053:EE_
X-MS-Office365-Filtering-Correlation-Id: 80ce886e-6474-436c-6400-08dab1a4e938
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c0qls4/pCAqsGa70KzhcNzFS0Elt6aS8WYI+sa5Hnbciwktgr0FGurxEGyylMewtIy+z+eS+LX/z9s3hJWGd2nN71JnZEO4wGzF/NCrqmVJWObGwZFcvDRKI9cjuhfvJSzALaMFTZj5DHkMJsB+spvCyrURsuUItD8qkMVmTWLHNmUv+2lNQIPUoUasSoa6yXc68wU2oW0xC5ikWnqT+5bZGQAFqhgN+EJN5N5UuCR5Ix7bRB7nLAWG0SjsBToPMTukZE2b0rk4cuPDNnd35tiRhFsnBv6jQCwWEy4iugZwUU5ZDKY1D6KMehfbsfIzGX3gfRmoqwbg22Tb2McL7m2kgybmh8DUpUcKWkwRx7Uj6kSeK7W7vS5d2nhCgpLp9aKUB8U+5lHgx5ynSpSNzyi59nqQZ8gQ+Fd0TofkuIIOsRsMZEZgmT4EhV7eNw/JnHjagIgGPFUR8dvIQkc4PwhaY1dsJ+om4yaxQ3oxkfA2yyPHetFLkqH+MWQeprHGVXAF50Z1Ro48AgGpVLpU8bYykOLn6tclaUq7VIWSFBvvSHz/yF0KpRlaPJANhdE8WFXw5uus8yIRTgUclSX3Ti8cci7dg0J8z0OcdHSCcSptWkwayHlKaWbMgq4stxEzg6whhSgGR10ChpUvoNy9+7PRx0j8isuGJ1Psxy7ajIACr1XaUBJCO9sIt3RcUNUVKb37MU84YD9M/sABZKVS46l0uv5s39IHz6Q4IskE9EZUr6AkH2O6pXCLzn13KeW9AIJCfuaFzIFz0q/fXdto9CrDftQNTuG9UC8uOZNvspfA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(15650500001)(41300700001)(2906002)(5660300002)(31686004)(8936002)(316002)(6916009)(54906003)(6506007)(478600001)(66476007)(66946007)(6486002)(4326008)(8676002)(36756003)(66556008)(38100700002)(31696002)(86362001)(26005)(83380400001)(6512007)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Zi9ELzRvVWpWRWE3cEJBMW8wODZVeWNnZmNBaTh3Q2VaUmxNNnU3SEt2K0E0?=
 =?utf-8?B?ekdWd1JWNHNYTjRyRC8yOHNGdEpKdmlVemVXUUUvcmNBY2FpL3p6SHFlaERZ?=
 =?utf-8?B?bnFteFV2cGJsS0JaRWM4dXdPT2kxSUV2QlpieHNWWGxVaXZDV0drTlR1YXdO?=
 =?utf-8?B?YjdTVnh1SUVBOEFINEladXlSK3hSSjVnb3JVekdtaGc3dHNvVElITHFZQmY5?=
 =?utf-8?B?U2V3b0NvY2FHWWtDQlNvUDBNRGlaV0YvNVNYYjVvd2tvK2tMNlRzSzBBbktj?=
 =?utf-8?B?clFLQjhjdWxDK0dMd0tmQUFiMGJwSXRWODMwTWNrWDQwRGMwNy8vM2RkY3g1?=
 =?utf-8?B?ZVk1SHZZSUl3YkNLZUVmNjVLMUl3ZCttSUR2N3ZWcGJCaElNeFlpVjBBTnRx?=
 =?utf-8?B?UjdLZnM1ZjV2Yi81b3JkaVYweXRvQi9LOWttMXRlL1ZWQ2FCbjFRMC81UmhR?=
 =?utf-8?B?VEdaazF6WElxTytRR1ROYWhsU2VIN0VQWndINUg3RS81NTZMaWptSkpjVkVR?=
 =?utf-8?B?azFxajBDaFpJY2xhalM1cjhHTVRGY0FqK2FjZytzSVBLaDVlQmJyaHlYV00z?=
 =?utf-8?B?cTRFUVVDTXRkNHNYRWVFQWEva3BxTDJtSkZyM1BYak02a0dGUWdzNUVKSGtU?=
 =?utf-8?B?MGVoZTNDVFJpd1BQRXZoT2s3TDJZcTVoK2NPQ0NaWnNqMG16R0hqci91dWc5?=
 =?utf-8?B?WTJyRkJSZ2oxYzBtSFdxQTlKenhlMFpiTVE2dXRhSERWWFd1OG42ZVJ1Q3Y1?=
 =?utf-8?B?Qk1ydnFLZXkvRTQxQU5BZ0h1VUR2OWFPdFAwUFlJR0prRy9CVytEMGhuTzU2?=
 =?utf-8?B?cUNIcU5yYkxnRmJtQllzeUJOanhaVGt0YUJUOU10Y2EwWWVzMC9ZQjI0TVhM?=
 =?utf-8?B?Qmg2a3YyY05yOHdpWUowcVgvTVJtRjZPc0RnS2VLV2MvVE0vQ1R0cXJtaysz?=
 =?utf-8?B?MGFBMjBsQVJibWRnQVJhb3Q5aVF2UHdUd3VwamxNdUNmWWszS2VKa2VWbTh2?=
 =?utf-8?B?YVQvNkdvaFFjL2RuemV0TzV3U0ExM0tMcEJLMWFVLzExQ0FTaVg1WDhUaWRn?=
 =?utf-8?B?eVR1dlV2cjFHbzRaYmxmVEJqRk13aTdkMDBmZTdiUGtJN3hGcDZhY2Q2aml4?=
 =?utf-8?B?ZVgxNDFpVDJ4SFpyQUU5K3FSUGFESWtOOVVhSTVpODNMSXdmVDZBYXdSeU1p?=
 =?utf-8?B?UG1ZNW9XM2R3TWlMWEo1RzhCTThPUEZFYXhySko3aUp4cVpHajAvaWJvbmpR?=
 =?utf-8?B?K25Fb1BCUGlxWFBaT1cydkh6QUl6SFFDSWwrTHB3aml2aHRvOW80bzM1V1Mw?=
 =?utf-8?B?VnI1QjFYajkreEJWalVwdkxRdzJ4NjZuSEtOWE5tYUY4dnVRWmhjY3doWWpF?=
 =?utf-8?B?RXdsa1ZDc2hSeFliU2VJRGd4Y0JLQTl6dlRXTUJDcGhKek8weVQxYzR4UDFL?=
 =?utf-8?B?WmQyUjlSY1NqeGwvOXVuQmtnQnNUTVVnekw0ZzVyc3ZZQWg0ckRiVnB0VlRH?=
 =?utf-8?B?Wkx5ZFBHVVdGaTc4c3lWUGlKV2Nwd2lMWmhHcWkwVjlXR2hLY3k0TVJCbkth?=
 =?utf-8?B?UDNySnp3enRJYmFvTkVlTHR3V0E1b3pycDQxM1JySnVWcFlHN0tFSUZ4eVIr?=
 =?utf-8?B?Y1ZydmUxWER3SlUzVjVYcURlY0graXJ6b0J4RDB3RzdVeE1DMkozUlhIVzNH?=
 =?utf-8?B?VDFIZHMrbnczZTNBNjV6ZTUrR3huakhxZEdwWE9QYTVQbnVWWkt4ZFM1TTlS?=
 =?utf-8?B?RU44a1ZWU1Uwak9uTVlWQnBENUUwR1dXaE5VazFTdEwwZDlKR0YwOVZNQnZo?=
 =?utf-8?B?eHhPcXZIRVkxcDVkSkNtbDZHT2JJU0FGOU5PZS8xYmIwL3M1NnZLc04vTCs4?=
 =?utf-8?B?bTByWGFsdUhuUW9LdjJTRE1yNTFsb1ZuRFhDL1hOcENmRnM2VFY1cXhsWGtU?=
 =?utf-8?B?bGxWbUc5dHk0MVNLUHVOVVRSSFpZeTE1ZjJ3YTJ0WXdtUHdlOWJoM3pPWm1B?=
 =?utf-8?B?WVdUTHNSdUptdy9CcGlxTUcyY2YzU3VCRmVGYitZVUZpYWNPRW9pTXJ6NXJY?=
 =?utf-8?B?N0xnOXU0aWdJTjFPdjE5ckptMkFHd1JTT2ErRXZQTVI3RGcyblRCcWpmc3c1?=
 =?utf-8?Q?QNGksONWwvH0Mnus/2JKhGtdx?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80ce886e-6474-436c-6400-08dab1a4e938
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:38:27.3292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HfC+OdPr8EqfKYjHerugrt1a4SIHu5lpasVLwrw9KWNC2VeWVWsAPbFF75gUjp3MNJqnd3ptDxcyzvZ/D607oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7053

x86'es variant is a superset of Arm's, with CONFIG_COMPAT parts already
properly marked. The only other missing piece is
update_guest_memory_policy(): For the time being Arm simply gains an
empty struct and inline function.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -281,38 +281,6 @@ static void ctxt_switch_to(struct vcpu *
     WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2);
 }
 
-/* Update per-VCPU guest runstate shared memory area (if registered). */
-static void update_runstate_area(struct vcpu *v)
-{
-    void __user *guest_handle = NULL;
-    struct vcpu_runstate_info runstate;
-
-    if ( guest_handle_is_null(runstate_guest(v)) )
-        return;
-
-    memcpy(&runstate, &v->runstate, sizeof(runstate));
-
-    if ( VM_ASSIST(v->domain, runstate_update_flag) )
-    {
-        guest_handle = &v->runstate_guest.p->state_entry_time + 1;
-        guest_handle--;
-        runstate.state_entry_time |= XEN_RUNSTATE_UPDATE;
-        __raw_copy_to_guest(guest_handle,
-                            (void *)(&runstate.state_entry_time + 1) - 1, 1);
-        smp_wmb();
-    }
-
-    __copy_to_guest(runstate_guest(v), &runstate, 1);
-
-    if ( guest_handle )
-    {
-        runstate.state_entry_time &= ~XEN_RUNSTATE_UPDATE;
-        smp_wmb();
-        __raw_copy_to_guest(guest_handle,
-                            (void *)(&runstate.state_entry_time + 1) - 1, 1);
-    }
-}
-
 static void schedule_tail(struct vcpu *prev)
 {
     ASSERT(prev != current);
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -295,6 +295,11 @@ struct arch_vcpu_io {
     struct instr_details dabt_instr; /* when the instruction is decoded */
 };
 
+struct guest_memory_policy {};
+static inline void update_guest_memory_policy(struct vcpu *v,
+                                              struct guest_memory_policy *gmp)
+{}
+
 #endif /* __ASM_DOMAIN_H__ */
 
 /*
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1852,64 +1852,6 @@ void cf_check paravirt_ctxt_switch_to(st
         wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
 }
 
-/* Update per-VCPU guest runstate shared memory area (if registered). */
-bool update_runstate_area(struct vcpu *v)
-{
-    bool rc;
-    struct guest_memory_policy policy = { .nested_guest_mode = false };
-    void __user *guest_handle = NULL;
-    struct vcpu_runstate_info runstate;
-
-    if ( guest_handle_is_null(runstate_guest(v)) )
-        return true;
-
-    update_guest_memory_policy(v, &policy);
-
-    memcpy(&runstate, &v->runstate, sizeof(runstate));
-
-    if ( VM_ASSIST(v->domain, runstate_update_flag) )
-    {
-#ifdef CONFIG_COMPAT
-        guest_handle = has_32bit_shinfo(v->domain)
-            ? &v->runstate_guest.compat.p->state_entry_time + 1
-            : &v->runstate_guest.native.p->state_entry_time + 1;
-#else
-        guest_handle = &v->runstate_guest.p->state_entry_time + 1;
-#endif
-        guest_handle--;
-        runstate.state_entry_time |= XEN_RUNSTATE_UPDATE;
-        __raw_copy_to_guest(guest_handle,
-                            (void *)(&runstate.state_entry_time + 1) - 1, 1);
-        smp_wmb();
-    }
-
-#ifdef CONFIG_COMPAT
-    if ( has_32bit_shinfo(v->domain) )
-    {
-        struct compat_vcpu_runstate_info info;
-
-        XLAT_vcpu_runstate_info(&info, &runstate);
-        __copy_to_guest(v->runstate_guest.compat, &info, 1);
-        rc = true;
-    }
-    else
-#endif
-        rc = __copy_to_guest(runstate_guest(v), &runstate, 1) !=
-             sizeof(runstate);
-
-    if ( guest_handle )
-    {
-        runstate.state_entry_time &= ~XEN_RUNSTATE_UPDATE;
-        smp_wmb();
-        __raw_copy_to_guest(guest_handle,
-                            (void *)(&runstate.state_entry_time + 1) - 1, 1);
-    }
-
-    update_guest_memory_policy(v, &policy);
-
-    return rc;
-}
-
 static void _update_runstate_area(struct vcpu *v)
 {
     if ( !update_runstate_area(v) && is_pv_vcpu(v) &&
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -681,7 +681,6 @@ void update_guest_memory_policy(struct v
 
 void domain_cpu_policy_changed(struct domain *d);
 
-bool update_runstate_area(struct vcpu *);
 bool update_secondary_system_time(struct vcpu *,
                                   struct vcpu_time_info *);
 
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1579,6 +1579,64 @@ int default_initialise_vcpu(struct vcpu
     return rc;
 }
 
+/* Update per-VCPU guest runstate shared memory area (if registered). */
+bool update_runstate_area(struct vcpu *v)
+{
+    bool rc;
+    struct guest_memory_policy policy = { };
+    void __user *guest_handle = NULL;
+    struct vcpu_runstate_info runstate;
+
+    if ( guest_handle_is_null(runstate_guest(v)) )
+        return true;
+
+    update_guest_memory_policy(v, &policy);
+
+    memcpy(&runstate, &v->runstate, sizeof(runstate));
+
+    if ( VM_ASSIST(v->domain, runstate_update_flag) )
+    {
+#ifdef CONFIG_COMPAT
+        guest_handle = has_32bit_shinfo(v->domain)
+            ? &v->runstate_guest.compat.p->state_entry_time + 1
+            : &v->runstate_guest.native.p->state_entry_time + 1;
+#else
+        guest_handle = &v->runstate_guest.p->state_entry_time + 1;
+#endif
+        guest_handle--;
+        runstate.state_entry_time |= XEN_RUNSTATE_UPDATE;
+        __raw_copy_to_guest(guest_handle,
+                            (void *)(&runstate.state_entry_time + 1) - 1, 1);
+        smp_wmb();
+    }
+
+#ifdef CONFIG_COMPAT
+    if ( has_32bit_shinfo(v->domain) )
+    {
+        struct compat_vcpu_runstate_info info;
+
+        XLAT_vcpu_runstate_info(&info, &runstate);
+        __copy_to_guest(v->runstate_guest.compat, &info, 1);
+        rc = true;
+    }
+    else
+#endif
+        rc = __copy_to_guest(runstate_guest(v), &runstate, 1) !=
+             sizeof(runstate);
+
+    if ( guest_handle )
+    {
+        runstate.state_entry_time &= ~XEN_RUNSTATE_UPDATE;
+        smp_wmb();
+        __raw_copy_to_guest(guest_handle,
+                            (void *)(&runstate.state_entry_time + 1) - 1, 1);
+    }
+
+    update_guest_memory_policy(v, &policy);
+
+    return rc;
+}
+
 long common_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc = 0;
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -98,6 +98,8 @@ void arch_get_info_guest(struct vcpu *,
 int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
+bool update_runstate_area(struct vcpu *);
+
 int domain_relinquish_resources(struct domain *d);
 
 void dump_pageframe_info(struct domain *d);



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:39:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:39:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425540.673426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3g6-0002QP-7K; Wed, 19 Oct 2022 07:39:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425540.673426; Wed, 19 Oct 2022 07:39:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3g6-0002QI-4V; Wed, 19 Oct 2022 07:39:50 +0000
Received: by outflank-mailman (input) for mailman id 425540;
 Wed, 19 Oct 2022 07:39:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3g4-0002QA-7X
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:39:48 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3452a975-4f81-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:39:46 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB7053.eurprd04.prod.outlook.com (2603:10a6:800:12f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:39:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:39:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3452a975-4f81-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k6w6YLJXixG32gp7MkVWn1pFNyYczIDI8Iv8Y0ZCFl4M65GaATiaQUIGNN4Iung/wCv8sCYKmNVu644auOAiYcYuSNsTD3d5nMacOO1dsiUsiNkyCiS/VMfPf3Ma325x1I+OKwDgXblwv0aXvxSfsdI/OT8HsMKhEWIchtiNrz9Qm2TqMOTML4fds1mX7iZwl01+nszeBRnuZkw4ZGWjc9pvB0PnjKE4JJWd4aX2y9ifgmnZY2OGbpC+B8LqljiOy/0iiUDXdBLgIcwokMyT2KxsALHrtfTK6y1T0eYCLRrwmtQktmhM4aLTLUvh80JVJMD6ncYaUtRMaAxy7wL4NQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NS+Ir87A7hMdS05pA5lIP70EV6ArkjcWoo9W2xzsvTE=;
 b=So1NOtATYJVmtiRge2gk5MynRXMX4dLUSk9JmBzBOS9sZLA5D1NnPCmauB2Mh+kXIfl/UxhbcpazrvP0B2KoabxaQ8+qcVZtfhmkJmD0g4USJ2DKNyuXlyKOTDrldlqai4b2nESU71gDi+GfGqEZxMEYprwHKs+ZxYj4/hINW7mxIgO8jWlB/WCUvAW/XgIYA5vqIBmmKMYqKx/TlPdBnk3NPYYe38hWC1pbRUuIz2cqBA8+wTcZAyGAZIb+ytUCUCSDymLU7zFSRNJzoymjCTYh0RNFBrCUFerOGM6H92gL9GebLlseEhVGZN006pYlyyb5k1GVfhp7LzbGNDQWAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NS+Ir87A7hMdS05pA5lIP70EV6ArkjcWoo9W2xzsvTE=;
 b=wBQgNm+QtaOUJF79pfjWM9mpl0Tho6x2fpCWe/JlLu6xGVjNw+wL13LbtEFenLbrmJEsXTqsS8DL2gJiSXkpTQBtu1WhJhUgJzL6gI9iqih+tg4bVj1o/H9q65sI2VLtOCc+SDBH77/C33aMKUyaEdon8KlyZsKLkVJQZsu8ieMySkPYj1OQbEht3bqoQxVk7qvwTd06tD6GW1do6vAXkfHWU6RKfEO3AACz4eALd6aKdsVfVBa3JXL46hjVLuA9uMrPDnDuLiJImRWK1EMqA1Eal6Aavk4ieng3D+ebU+W6sK9VNMTXbzzXc5nW5XG/lnt9WghC5weCWCmDEATxtw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3ff84ed1-8143-15c2-2b4a-3ae8ef23677c@suse.com>
Date: Wed, 19 Oct 2022 09:39:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH 02/10] x86: split populating of struct vcpu_time_info into a
 separate function
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0083.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7053:EE_
X-MS-Office365-Filtering-Correlation-Id: ad5e30ed-1ee7-4ea8-56cd-08dab1a517ae
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FXsLKYJshS7GEnqLwf3tWxbapiQJw5SH9CV7KNtJNmrfum7Z8yjghnpOdfay2n4Kn1KZL/rEx5fxrzZytbufIg0KvKzgLp+6+6l1lCKetYc7GCHLwCZ/1a57UXsdZf7fUgjYlbCzDos9DqEQW2F+wAmq1nxYRyINjIOxCC/tdbMprynjqkQW61VGbNdbtSFkP07lsnBlm6JwFoinoocDJDQQ97uxn95kuWMXCxezb/qm4yBEPmdjYUYIC5VUOWyuFkuneFEAaUM+R79WOpjeu4Hu+Z9pDi91bcxh7Z37m0oZOTvKrX6IWSBqaaaDJtDlC2+t21/kq8wl+IgL7jNe/Xi2MO+Pk1ma19WP7aOmavHWWdk9ZQRx4dkHHHZyZDeVYy+UxEgazP+YAi1t7JBOfe8is3ysHJeiMZVnbjWgBphYHGUV6vrBacz5dWxRmb45q5jelJrL4G5AA+A7tjpEaQTttRLu+YK8iS6aqMM5Ey+8oNeB1MLN1lo3AIb7R+KZWVgMlx8WzER5mjfF8LsD1b7kAiegcjzqoadkQ5OgcUv+gPrh/7h7IW5og9VsoyU3c+HZjb/ELEhn41QkugJ3OxL+Ua97SoKXc8L9KmvruUmnQ9oB6t61AgEB6kqcen/BqemKczhktF3T9CPQNM8iRPznTUcRnM30IfamLR+GReEKN809lVgJlIABVRIwXUqVF96pBgsFJadiE61MuOA66ES8L0WmBpF0kN0wsb6+iUkBViIa/FDffmuZ208VkKfblsOahy9BqTITBKwBDL0z9prAuAnJLNAfkcP8y7MKJt0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(41300700001)(2906002)(5660300002)(31686004)(8936002)(316002)(6916009)(54906003)(6506007)(478600001)(6666004)(66476007)(66946007)(6486002)(4326008)(8676002)(36756003)(66556008)(38100700002)(31696002)(86362001)(26005)(83380400001)(6512007)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a21lMWZkWDZLRTBlYW1ZdEQzTkppQTJBZkcwUmV6aFcwOEZYVTZZY3dnRzZn?=
 =?utf-8?B?NGFWV0dFRHcrVVc0SjJjTlJMUGtxYmNXUy9OTkkrQ2d4N3p1Ykt2Ujd3aGp3?=
 =?utf-8?B?ZEttNDNwZUg1U2FpeGlPMTczYW95a2JsNkNtQlZaZXVUY0ppV0dySlZwVG8v?=
 =?utf-8?B?amlTOWxiT3VFZ09ramt4c0E0TkxGeWxzUnRJeGwrU0M1bEpxNmtIejRQcVpG?=
 =?utf-8?B?NWpXeUJXOGN6RFczeWtvYnlEVnJxY05yNHVYdUROSnNOdVFUUzNRaTFhQzNa?=
 =?utf-8?B?VmVYLzNhbGRnekxtTThMUWt1d1FzT04vRlRwbkFCUVlEMmhMWXdZeWdxRWRz?=
 =?utf-8?B?QmFrZlhRRGRua2dHUnl6V3JGUDNnZm91YzJ2Vi9LSXQvUHg3Q25oN25RdXRq?=
 =?utf-8?B?QjBYdUlreFhheUt2YjJyV3JTRFJIbjZZMkNGY1ByV2FiTFpUL1hQV09zS3Ar?=
 =?utf-8?B?NWJFeTRZS1RTd0VWRE8ycm54M2RZbXI1bWs3TmtscXUzQ3JSYWFkay9uWHNQ?=
 =?utf-8?B?ZGc2SkpVVmRVZmYwUklrenUwTmlYNk1kN1hIZDVIVElFNFVMRW53MlFzM3pY?=
 =?utf-8?B?dWV0VmtLTXRlMVdxUGN6RU1BRkFIS0VidlVpemhTNFFJQmMzOFNYV0lQdk1u?=
 =?utf-8?B?ckV4cktKcVlNWG53Z2o0cVhzMEVkSlkvZUVtRTBoQU9ZWklqWDQvcUx0VVNG?=
 =?utf-8?B?c2w4L1BZYnd1c1ZKMXQ2V1ZxNVJFakR0Rm5ncWRvMUxZaTEvYmQzL09PTTJN?=
 =?utf-8?B?cVRaMWw2Vy9yemNqS0REOU1XYW5YeGxkN1ViRmpYKzljNHhBdFJldnBISEQy?=
 =?utf-8?B?Nlc4dnY2eWs5eE5MVEtkREl0K3Fvd1NiVUgzNmpOY3RidDhBU01pcU9mZ21R?=
 =?utf-8?B?Z205ajRsc0FlT1VOdk9rbENnWkg5eDJxZ1NZeThsUnI0TjVpb2ZndFZRQ0tv?=
 =?utf-8?B?ZW1FdUYrbk9GT1dWTGxjR0Fybnd2TjJFVjVyeTEzQVh0aTFZT0dUZW0yT1Js?=
 =?utf-8?B?MUVWSnhwMC9COHN5WSt4RHJuTFBxeHZBc2cxWWorSlB2UjBoWmNoZkE0QjVY?=
 =?utf-8?B?ZjNNR3YvajdQQXpHWC9STlBEQ0MvRmdtMXJJUitTYWhJUXlka1YwZ2l4Uk9P?=
 =?utf-8?B?UEZVbnVqVTBvUWVia2poV3MyeGhDVDZTai9sSER6ODkvNjNtZ2wyUjFBdGNC?=
 =?utf-8?B?VzYrU2pQc1BWbS8yc3l4a1Q3N3VEOXVhVGNGNEUrelFnK3dnaE1DcGd5K1ZP?=
 =?utf-8?B?Z1hTVEc3bll6TFAweStBbHZuQkN6Nm5KQ01nUEMrV0lVK2p0Y2lEdUxjMml4?=
 =?utf-8?B?TGNBekhIT0U5NTl5YmFkbGJBNk9GQUQwTUtyTHkwSlFpSlQwejk3aUNiNkNp?=
 =?utf-8?B?UEdxR2FSdThxdEFsbUlLMkE1Y1BqbTd5Q3NLb3FXa1EyTUlCZkhKeEl4aDFT?=
 =?utf-8?B?Mk9jYUlSL0k1c05NMXE3eXFIdUlEbkxJMlF3M0d6UFBhbi9uNjhTa3k4eU1w?=
 =?utf-8?B?eUJ0R09nWGl4bzh6ODBjVFFzY2pKZXEwK2Z6SUhBUFZFNGRHQys1QWRqWnVv?=
 =?utf-8?B?QW8xTEhtTEF2MHV1NVQvRlNtNTB1bjNDZ090emc4L01iR0h3dW1wTlBaZVgw?=
 =?utf-8?B?eVkzNENpZFFOcTg1MkU4eFU0aDJ0dHhyd0RWMW5lYUlPMEV5eWlVcEpFNUpp?=
 =?utf-8?B?enRNMHNwYWF1cHBsaUlsWXhLWUI2c0ZNc2VCZFJGRlpqMEljL3lqdks0dFNx?=
 =?utf-8?B?MUQwYzNRRzVkOGFnS1VLVHl5SGxYTDdNei9keVl4WVYvcnJ1aEl1N0FBVjZT?=
 =?utf-8?B?Sm5LV0pIcXVuOTJtRnVPYnVyRlRhbitDL1Z4N0MyajdwUnI5MTVTYm5DNVQv?=
 =?utf-8?B?c29lUnpVS0NBVnFIVXRybWZjQ2laRnB4YkdUOVcxUW8rYVQyOVErcmUrVFdG?=
 =?utf-8?B?WllBeklwM0xqWVR5N1pQaGphME8yTDlMSjZ3NkYrRFl1WkdYRmlWV0tPZ29Q?=
 =?utf-8?B?TFZzWlVMa0NHWlc0dkhwMk5ISDhjQWRvMGJTYmpDMkQxTVNjNU9kd1pReW1U?=
 =?utf-8?B?KzNuVVJ0R0M2cVZsTURLZjloSGErLzRWOVB1VE5LbjlxM0huc3d3VnhJU0NZ?=
 =?utf-8?Q?RgQMynEFrJTjlXeWU+WTnxQUB?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad5e30ed-1ee7-4ea8-56cd-08dab1a517ae
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:39:45.2774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uvMxJBohBNqiJdxwoY+KRk27By85ROdgGfuIu/7Wsv3Vh9uxdyRYNRNtTVb4LVdrBbkAtgh772uk29OSQnH51Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7053

This is to facilitate subsequent re-use of this code.

While doing so add const in a number of places, extending to
gtime_to_gtsc() and then for symmetry also its inverse function.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I was on the edge of also folding the various is_hvm_domain() into a
function scope boolean, but then wasn't really certain that this
wouldn't open up undue speculation opportunities.

--- a/xen/arch/x86/include/asm/time.h
+++ b/xen/arch/x86/include/asm/time.h
@@ -52,8 +52,8 @@ uint64_t cf_check acpi_pm_tick_to_ns(uin
 uint64_t tsc_ticks2ns(uint64_t ticks);
 
 uint64_t pv_soft_rdtsc(const struct vcpu *v, const struct cpu_user_regs *regs);
-u64 gtime_to_gtsc(struct domain *d, u64 time);
-u64 gtsc_to_gtime(struct domain *d, u64 tsc);
+uint64_t gtime_to_gtsc(const struct domain *d, uint64_t time);
+uint64_t gtsc_to_gtime(const struct domain *d, uint64_t tsc);
 
 int tsc_set_info(struct domain *d, uint32_t tsc_mode, uint64_t elapsed_nsec,
                  uint32_t gtsc_khz, uint32_t incarnation);
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1373,18 +1373,14 @@ uint64_t tsc_ticks2ns(uint64_t ticks)
     return scale_delta(ticks, &t->tsc_scale);
 }
 
-static void __update_vcpu_system_time(struct vcpu *v, int force)
+static void collect_time_info(const struct vcpu *v,
+                              struct vcpu_time_info *u)
 {
-    const struct cpu_time *t;
-    struct vcpu_time_info *u, _u = {};
-    struct domain *d = v->domain;
+    const struct cpu_time *t = &this_cpu(cpu_time);
+    const struct domain *d = v->domain;
     s_time_t tsc_stamp;
 
-    if ( v->vcpu_info == NULL )
-        return;
-
-    t = &this_cpu(cpu_time);
-    u = &vcpu_info(v, time);
+    memset(u, 0, sizeof(*u));
 
     if ( d->arch.vtsc )
     {
@@ -1392,7 +1388,7 @@ static void __update_vcpu_system_time(st
 
         if ( is_hvm_domain(d) )
         {
-            struct pl_time *pl = v->domain->arch.hvm.pl_time;
+            const struct pl_time *pl = d->arch.hvm.pl_time;
 
             stime += pl->stime_offset + v->arch.hvm.stime_offset;
             if ( stime >= 0 )
@@ -1403,27 +1399,27 @@ static void __update_vcpu_system_time(st
         else
             tsc_stamp = gtime_to_gtsc(d, stime);
 
-        _u.tsc_to_system_mul = d->arch.vtsc_to_ns.mul_frac;
-        _u.tsc_shift         = d->arch.vtsc_to_ns.shift;
+        u->tsc_to_system_mul = d->arch.vtsc_to_ns.mul_frac;
+        u->tsc_shift         = d->arch.vtsc_to_ns.shift;
     }
     else
     {
         if ( is_hvm_domain(d) && hvm_tsc_scaling_supported )
         {
             tsc_stamp            = hvm_scale_tsc(d, t->stamp.local_tsc);
-            _u.tsc_to_system_mul = d->arch.vtsc_to_ns.mul_frac;
-            _u.tsc_shift         = d->arch.vtsc_to_ns.shift;
+            u->tsc_to_system_mul = d->arch.vtsc_to_ns.mul_frac;
+            u->tsc_shift         = d->arch.vtsc_to_ns.shift;
         }
         else
         {
             tsc_stamp            = t->stamp.local_tsc;
-            _u.tsc_to_system_mul = t->tsc_scale.mul_frac;
-            _u.tsc_shift         = t->tsc_scale.shift;
+            u->tsc_to_system_mul = t->tsc_scale.mul_frac;
+            u->tsc_shift         = t->tsc_scale.shift;
         }
     }
 
-    _u.tsc_timestamp = tsc_stamp;
-    _u.system_time   = t->stamp.local_stime;
+    u->tsc_timestamp = tsc_stamp;
+    u->system_time   = t->stamp.local_stime;
 
     /*
      * It's expected that domains cope with this bit changing on every
@@ -1431,10 +1427,21 @@ static void __update_vcpu_system_time(st
      * or if it further requires monotonicity checks with other vcpus.
      */
     if ( clocksource_is_tsc() )
-        _u.flags |= XEN_PVCLOCK_TSC_STABLE_BIT;
+        u->flags |= XEN_PVCLOCK_TSC_STABLE_BIT;
 
     if ( is_hvm_domain(d) )
-        _u.tsc_timestamp += v->arch.hvm.cache_tsc_offset;
+        u->tsc_timestamp += v->arch.hvm.cache_tsc_offset;
+}
+
+static void __update_vcpu_system_time(struct vcpu *v, int force)
+{
+    struct vcpu_time_info *u = &vcpu_info(v, time), _u;
+    const struct domain *d = v->domain;
+
+    if ( v->vcpu_info == NULL )
+        return;
+
+    collect_time_info(v, &_u);
 
     /* Don't bother unless timestamp record has changed or we are forced. */
     _u.version = u->version; /* make versions match for memcmp test */
@@ -2476,7 +2483,7 @@ static int __init cf_check tsc_parse(con
 }
 custom_param("tsc", tsc_parse);
 
-u64 gtime_to_gtsc(struct domain *d, u64 time)
+uint64_t gtime_to_gtsc(const struct domain *d, uint64_t time)
 {
     if ( !is_hvm_domain(d) )
     {
@@ -2488,7 +2495,7 @@ u64 gtime_to_gtsc(struct domain *d, u64
     return scale_delta(time, &d->arch.ns_to_vtsc);
 }
 
-u64 gtsc_to_gtime(struct domain *d, u64 tsc)
+uint64_t gtsc_to_gtime(const struct domain *d, uint64_t tsc)
 {
     u64 time = scale_delta(tsc, &d->arch.vtsc_to_ns);
 



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:40:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:40:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425547.673437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3go-0003oZ-N8; Wed, 19 Oct 2022 07:40:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425547.673437; Wed, 19 Oct 2022 07:40:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3go-0003oS-Jm; Wed, 19 Oct 2022 07:40:34 +0000
Received: by outflank-mailman (input) for mailman id 425547;
 Wed, 19 Oct 2022 07:40:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3gn-0002QA-Kt
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:40:33 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4fa9ec51-4f81-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:40:32 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB7053.eurprd04.prod.outlook.com (2603:10a6:800:12f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:40:31 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:40:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fa9ec51-4f81-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U37Wvqu9UKgMQNEYUCUxBzLdO8eR7E1D/VNw5j00Suz1aTGsNuU+lBSqy9waEQg4IdgC12LrbrG6YrBnH9BRcmzVUhgNJuwAm7ByW45I8FQZXQ5Oqo1PhDZF2HWTgkza3aEiiF3BuFPeqR7bhPojtdtQZKJ9+KyPBkhpBtTBZ4kQhCQKMzuzO8F5YQ7C6ChxkvP0QX9/1NzkOLyDocuahxDkYXRuCRwPMWyS8GEaYBIjR034lzRf4XNyUiqLWtHM98ezYjsnOU4yQYemB+F3x2AMCkkEjJjenZiWoZebT3jtWP3glha47aKJYWuigLl7pUjhpw6ZGxB4fiSPijsPVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ys5qUv51nmA4Djlb7ZReN8bSfFratiuu2AVuBlXA8hI=;
 b=hkvfCA3TvpnPlwwr9qPB+OkRdBGY8FGvw0pJ+Q4dhyfaYu5TOaSn+m3Laq6hqjB9MbPiQwWVl8jrfbF8+iv6DDgkwbXmDWgCzefgZ5FwJQgRpojK0Uwxc4jZtTj+e6FnIX6rkI2gWc40aWwrfXGbPCi0Rhs2Dnig9XhaAfGjg3UI8CbMfn/C9BCxYNeO0CxTI6l/41z+u6kTxxRgtxkWcrxbwiEvcI9P5qHWZ1vUk7wHAyQzIMzKOGmUz9LXdcXhv4J+/cL503BpftujvNk3A8s+6Tt3sJ0ApVT3Sh6l1OoUvWldPzNCMIXfFeQPVCPrO2jlekO7d92ne4Hzz5auEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ys5qUv51nmA4Djlb7ZReN8bSfFratiuu2AVuBlXA8hI=;
 b=jW7HmTmecVUTa5ENqHULQr5tLw0/JXIzalGC0BumQ9EEgTe0IXiu+nmuCbsSROdQRIygOD0C9Iu6lJLYshqIYrOIeZDlJEWYgqFO7d7BA+3y2E4hUjGb/meggTjzQLsWfs1sDvfd3RHKXfkGkwZ5/UhP+j3e25cz/J9sB3KkD3YEB3NalgZMdKkHDEKII0rInf2HsfEe/CPHYCWgjUuNNP0Op7gCx/Mst8qGnfP4DqKv4jFZjTcD+n2m2BLcaxfZ/Bk7Mm4jT9IPxyCMdxVLptO42xgbj5AjklHJFo/o3KgHG9eO9TBAdJ5iD3j2kzuARnxAC7cww9CWjtJ5AzDJFw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <214c9ec9-b948-1ca6-24d6-4e7f8852ac45@suse.com>
Date: Wed, 19 Oct 2022 09:40:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH RFC 03/10] domain: GADDR based shared guest area registration
 alternative - teardown
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7053:EE_
X-MS-Office365-Filtering-Correlation-Id: 3e0fbdcf-ebc0-4a6e-b642-08dab1a532fe
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	91ndG52ZwxfKmvtSDkw7DrjWZkHE3s8S+r8G7XFuaMXvBOm8p6IZaApwhQC/k6yEF/zflQZZgx7ii0Zxd1hxgSZeRw3Xt27rqKxcAoS9fiZnV5ZtzkETGI8Ps+7SrhCbY4bc4yj/8AlOoJejbjwm9/EDX9HMuiAwP5P3D+0BDzTCXn7JV3zOV1nIk6aDx/0/JXlGSNE64QKQEwdS7UvNjIIx6LEwL/5TMrZB8ABY7vzYOXNrbPYXvye3dnPY3KBsUicssHhIgTf07J9dl3dx687th47HGyY6Jac57zMt3RffhS7Jh/i3PPhCxCmwffSvMXZgY4IKUzDYyzIOH8oZqmoTE/nChyODsgQhUOhilnkyLCjUWgY2qjkpOcRr+79A0/uCxFfqWqmaU1hNe89R66A7j7pnhSbGFbOHg6RXluZi2t7t7n3O97QfaXn5zmCKumk9BzKTJ54nvXhy4OO/+QVJBRrxXl8sVzCOUSmXduzIWOObbOBxWM+6WbwSjFtaBf1IE6sXrwwv0wb0VD9cb9ZJYkX93mgSdeCnWpHekRhMxghxn1aIgTU+EXSTRfWFGLlmeJ92wvcTIM5gpaOGeNWrIHk5YBSr9DNaaPTQvef0pYFjNaDhWwEbfU3X8BXuH68hAwZsCKoycOHtEdSrNvVSnGSYQdVUfZ2LCNzB4l99t9mZ9zx/I64t1Z68/AFc1nxRVhYnQNbXj7L1s77qgbDyfauWGHMmYGptkIqN1futl1JtS6w5p3CIqGowHB/zaS38U33cno129auYvg/xf0Hbhl3J4mggOXjNnkGLVWQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(41300700001)(2906002)(5660300002)(31686004)(8936002)(316002)(6916009)(54906003)(6506007)(478600001)(66476007)(66946007)(6486002)(4326008)(8676002)(36756003)(66556008)(38100700002)(31696002)(86362001)(26005)(6512007)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S05HbDNsQ2piQ0R0WlNMZ0ZqclVoQnBHNjZLZWhDMVdZNjlaQlRBZUR4UCtX?=
 =?utf-8?B?WDRlZ2RoOTRQTVBDRlZlMHRJZ1FHUFdhSFZYekxpamJSWjRYTU9GQjVXYk5s?=
 =?utf-8?B?NVhSN2FwM1k2d1NKbU4wMVlOR2NXMVZqMU5yTlBKWlBGVDRMMGU2Q0RyWDVn?=
 =?utf-8?B?WVl1SUk4QWhzUjBlOEswMjNoMmpUeFB3MXpaQXh4cTI5N3N0WjdueFBCQ0VV?=
 =?utf-8?B?K1BPUzkwUDhJZEQ0M2YrUFpRMzR4VUFSZktoeG9hSnNGdUFnZ0ZtQUg0RmZ4?=
 =?utf-8?B?K2NhMFNVVG9ZcmhTV1hxZ0dpRFlQLzR1MVp2SzkwWU51SUR3OVV1N2VSL2ll?=
 =?utf-8?B?cnZLWFowVjdDZ0N2NWoxd1hlQ3JXMWczenpIbmREQ0thSlNrZUd1ekRhd0JM?=
 =?utf-8?B?Q2dTMGpkZ083Mjd2UEJ0RytjVkVNUGEwY09CL003S0tCdi8ydnh6SFhEVHhZ?=
 =?utf-8?B?QXUzU0NZMWdSK3lVOXpyS3dwdDQyTU1VSTRWK0l2YjBOUWhQS2VCY0txUGNt?=
 =?utf-8?B?Vms5VHc5UUpzU281OGo3WHU3djZaVzBjQkd0YUpZNWQ1Vy95bkYvRU8wNzg0?=
 =?utf-8?B?M2VXYkRMRDc0OHNnTkh5cGNKbHVmTnltcXc5VnhZZEN0VTdzWHJzeTVxNTNF?=
 =?utf-8?B?cklIaGh5L0pVRWpYQWlRS1dsTW9PTk04NkJHUE1MeThKeHdkWDJrbk5PV1kr?=
 =?utf-8?B?cGFKZ1Z2YXZvQy9BQWtRUitXMlBIcGxJUFVRT2NxWVNuVjFJNUMwM2N5TG9O?=
 =?utf-8?B?OHlXcTFzdVdvOFRKMEtBNGdyMFlGZklSdFBQcXZ0K2lDOWZzQkdjMnlXQVhT?=
 =?utf-8?B?NnhBM1ZmaFFuNEtrL2N6b3J2SlN1NDFacEg4TDd4YkhSend5N2UzYXh2YjRz?=
 =?utf-8?B?Ui9FTldZRjY3NUlQNmUyYnBpb0tZVmhhVXBWVklaVVc3NU1oOWZjekovK0Zh?=
 =?utf-8?B?aUZ3WVJnVC95OGFnZy9QT3NNbkRzWDBtODNROVV4ZTVvSVhxODAxSm95RjUy?=
 =?utf-8?B?ZmozejNzeHN3Y09YWGYxb0U2MkhrYjF5dGtTNG9EYWdhUXJISUd4c3BWWm8r?=
 =?utf-8?B?b3ZaQmdUY0pDd1c5SXFveVI5aVNjdy9zdXN0MzR2c09uSENUR3g4TzBNWk5x?=
 =?utf-8?B?N1o3VXRuV1pOYkhkRldKT2dSZ01LOVlIVXRoZ0JCTFMxazZiK0FWS0xkL1VE?=
 =?utf-8?B?RmtEQlBXSWZNbm1QMFhkSWxHZ3BmUzhBOHk1S0JRRTRSM0hjZ3BzREdrWkZy?=
 =?utf-8?B?ZTdoWFVQSU15WHJwUkh5WnNKK3U3YkE2aEgwTlhOTVE4MjFIVVNCOWNMM0VO?=
 =?utf-8?B?dGNCWkhHVTYyZHdqcTFxc2FFZlV0M2lGT2FvYVRqUU1UVUk0MENub1NpSFE3?=
 =?utf-8?B?L0FsTlhwSHBkUTJVRml0VlpxTm9NTktNMmFyQ0d1UUdFcGw2aXpGczlwZ0Vo?=
 =?utf-8?B?UWo3MjJJYVhGSVJLUmVDSldQNFNBWXV1RTgzWHQxeWpUWXBtR2NmekFBU3M3?=
 =?utf-8?B?RkpHZTkvZUZvWEtHdERPQ1ZuN1NUdEQ5b2lpRTZlOHNwdFEvcmJLa2lWemc2?=
 =?utf-8?B?SkQ0SlZmcXhlbVQ3aEE2d0hQN0h1bUtCaDF2NmpmR0V1S3FvVVBwZHJZeTBr?=
 =?utf-8?B?clE4ckpKZXpaZE5zQmRpZUdybEtJa3RMK2NtZGhCUlVvQlZxejRxN3lTbUtY?=
 =?utf-8?B?d1d4dG5Ka1pVODRFYXd2V2cvSVdLUGN3dVIvTzA4L2p4YkJHRmZabXcyUU00?=
 =?utf-8?B?ZGZ6ckVvZnlrbjlqbG1Bek1rVVMrMU9WK3dielhzYVdRNG9Vcm1sQ0pZdFhL?=
 =?utf-8?B?UmMxdmN4TE14SGRnazZXVjcvRVQwMHdJb0tzZDRUWTRhSXZ6SzhBaXNoV0xv?=
 =?utf-8?B?a2FwRFY2SEZaMlhqVkRGR3MrVGwzWEtub200cHZMdkZrY0Zhb2w3THZZQW9l?=
 =?utf-8?B?dlB1dUdIS0hxLzhzc1ZaVEg1cks2cHJ3TkljZFNFUGdSZ3lPQURNWDN1emJT?=
 =?utf-8?B?aS9uZHJuWll6MENNdEdzNG13UVY1YkQvMzFjNVJvS0ZXZlJZZzlKajA0dnZa?=
 =?utf-8?B?Q2h1ZDdnL1pBRXN2ZVBSMm9RZ3g0OU9nNkdMTjgzQlk4KzFHRWhTaGFjTUhS?=
 =?utf-8?Q?h1lx5ewCMpWw7qGLXLYDDPUl3?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0fbdcf-ebc0-4a6e-b642-08dab1a532fe
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:40:31.1026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FBTIDukUI3PcDhSfJBYbmRNLzJ2DY5oOfvZU4dfWBdLjk4WYBSiHZpRkYdnyWgsKlrMdul2swqc5K6QBuuQRvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7053

In preparation of the introduction of new vCPU operations allowing to
register the respective areas (one of the two is x86-specific) by
guest-physical address, add the necessary domain cleanup hooks.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: Zapping the areas in pv_shim_shutdown() may not be strictly
     necessary: Aiui unmap_vcpu_info() is called only because the vCPU
     info area cannot be re-registered. Beyond that I guess the
     assumption is that the areas would only be re-registered as they
     were before. If that's not the case I wonder whether the guest
     handles for both areas shouldn't also be zapped.

--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1035,7 +1035,10 @@ int arch_domain_soft_reset(struct domain
     }
 
     for_each_vcpu ( d, v )
+    {
         set_xen_guest_handle(v->arch.time_info_guest, NULL);
+        unmap_guest_area(v, &v->arch.time_guest_area);
+    }
 
  exit_put_gfn:
     put_gfn(d, gfn_x(gfn));
@@ -2350,6 +2353,8 @@ int domain_relinquish_resources(struct d
             if ( ret )
                 return ret;
 
+            unmap_guest_area(v, &v->arch.time_guest_area);
+
             vpmu_destroy(v);
         }
 
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -661,6 +661,7 @@ struct arch_vcpu
 
     /* A secondary copy of the vcpu time info. */
     XEN_GUEST_HANDLE(vcpu_time_info_t) time_info_guest;
+    struct guest_area time_guest_area;
 
     struct arch_vm_event *vm_event;
 
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -394,8 +394,10 @@ int pv_shim_shutdown(uint8_t reason)
 
     for_each_vcpu ( d, v )
     {
-        /* Unmap guest vcpu_info pages. */
+        /* Unmap guest vcpu_info page and runstate/time areas. */
         unmap_vcpu_info(v);
+        unmap_guest_area(v, &v->runstate_guest_area);
+        unmap_guest_area(v, &v->arch.time_guest_area);
 
         /* Reset the periodic timer to the default value. */
         vcpu_set_periodic_timer(v, MILLISECS(10));
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -950,7 +950,10 @@ int domain_kill(struct domain *d)
         if ( cpupool_move_domain(d, cpupool0) )
             return -ERESTART;
         for_each_vcpu ( d, v )
+        {
             unmap_vcpu_info(v);
+            unmap_guest_area(v, &v->runstate_guest_area);
+        }
         d->is_dying = DOMDYING_dead;
         /* Mem event cleanup has to go here because the rings 
          * have to be put before we call put_domain. */
@@ -1404,6 +1407,7 @@ int domain_soft_reset(struct domain *d,
     {
         set_xen_guest_handle(runstate_guest(v), NULL);
         unmap_vcpu_info(v);
+        unmap_guest_area(v, &v->runstate_guest_area);
     }
 
     rc = arch_domain_soft_reset(d);
@@ -1555,6 +1559,15 @@ void unmap_vcpu_info(struct vcpu *v)
     put_page_and_type(mfn_to_page(mfn));
 }
 
+/*
+ * This is only intended to be used for domain cleanup (or more generally only
+ * with at least the respective vCPU, if it's not the current one, reliably
+ * paused).
+ */
+void unmap_guest_area(struct vcpu *v, struct guest_area *area)
+{
+}
+
 int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct vcpu_guest_context *ctxt;
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -5,6 +5,12 @@
 #include <xen/types.h>
 
 #include <public/xen.h>
+
+struct guest_area {
+    struct page_info *pg;
+    void *map;
+};
+
 #include <asm/domain.h>
 #include <asm/numa.h>
 
@@ -76,6 +82,11 @@ void arch_vcpu_destroy(struct vcpu *v);
 int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned int offset);
 void unmap_vcpu_info(struct vcpu *v);
 
+int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size,
+                   struct guest_area *area,
+                   void (*populate)(void *dst, struct vcpu *v));
+void unmap_guest_area(struct vcpu *v, struct guest_area *area);
+
 int arch_domain_create(struct domain *d,
                        struct xen_domctl_createdomain *config,
                        unsigned int flags);
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -202,6 +202,7 @@ struct vcpu
         XEN_GUEST_HANDLE(vcpu_runstate_info_compat_t) compat;
     } runstate_guest; /* guest address */
 #endif
+    struct guest_area runstate_guest_area;
     unsigned int     new_state;
 
     /* Has the FPU been initialised? */



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:41:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:41:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425552.673448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3hR-0004NB-W4; Wed, 19 Oct 2022 07:41:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425552.673448; Wed, 19 Oct 2022 07:41:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3hR-0004N2-Sa; Wed, 19 Oct 2022 07:41:13 +0000
Received: by outflank-mailman (input) for mailman id 425552;
 Wed, 19 Oct 2022 07:41:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3hQ-0003Zj-K9
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:41:12 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6722243f-4f81-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:41:11 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB7053.eurprd04.prod.outlook.com (2603:10a6:800:12f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:41:10 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:41:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6722243f-4f81-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SIhE9zIa89SFf+cHOPBHECxdOiSLaHPWte+PjRZnwk0OnvNSjNAM/wcZx/zjeeDAxy2KwIli+Lvhlc7M411qV03BuI8oJEwr8a/bKX/AK27UAfXviO/mfTEinDq5lKg9FrWti5Qd7sVwoooqcxzifGX/38Ekl/5J72BZG87xVcfc3UvPLToYfuyORdPI4CtIxA9DDm5E16lwytETBOZGEbZtKpBO5NUJYyyEjAGph+uMdJ/erxuJSGmWnimfREAk+y0Mjpf3wKTpVuehRcwJVDJCJyHIlc777plKqkMSAjMp5dtCNp+mYpGTOoH5lVWs/OtepFwauMGyoz99UMX4Xw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HZp+A6KIECj3TCy69kUkEPmXjjjlHR2l+u9nS0q8m9M=;
 b=D6e323yIvK2fQFHtHf0x9IEnEkO3KsKQMDnw0OR8NVsyLXHfHVQVGbSIe7f/YCEyQ8AZbTXp3ik73QEG2bv5GLGIjtEZY3AJBXZJ0po3HYC/kjxyo/D2BH5w7r1tN6OJN83hUpIXegF56ZLtljL0EbxfLCDsSxi6kcnQD1MFpI+DAWezchTeCZTHP9iC4uj7ilWUOQzuZtcX2fubr6pC4aSsce/5PZiXcbHPdIsJapidUS/neMMQYbox5LsyIp2qcK0+QEkLCi/VenDKJfUJKjPc/neFcG8/6bweU4QF/fLlJG60j4CeGKDzJ/nYUpAo68bSzHPBK5q4xuRNHyOYyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HZp+A6KIECj3TCy69kUkEPmXjjjlHR2l+u9nS0q8m9M=;
 b=mrUuh7e4haF3QCUhjMHMxDkuvI7nuiPgfindF1O1/ASDAXtg3Kwb8AVV7Dh+3FCa4urRm8o8TpQXf1koepNVbwpRmLMxcEglgntnR+Fg2hdY+YsmFs6r9j/kX4HwyVlou2hqGLrlX3+fEJFGdFBafDLL9nbnGM8pOdgpaUA862EHTsuNYPyXhwcYEqaNb9vq6tvuyzuDKJcfgfq31ZCKsSx+LrQZuvXAuIl3g/hhSmvZMPsxmm0zqeZvnQePiXCs5dpHmhrwn4x8HByzXo8DUc4L6u3KdV0ctvRNWosSshdK8KfU9WPI+XUdI7T/1susOnvRU7h5qPDu2FYZrM12Iw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <22422a1c-1cfa-95d0-c1fa-99150a8f2a32@suse.com>
Date: Wed, 19 Oct 2022 09:41:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH RFC 04/10] domain: update GADDR based runstate guest area
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0098.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::39) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7053:EE_
X-MS-Office365-Filtering-Correlation-Id: 519bc538-f9d8-498d-a15c-08dab1a54a7d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6kJZBBSRNjt6kprI8vd27PyXX0MSuyL1D00cmStSZtOSJUhioZTLvKU7suAPiehczis8uJ6dd41fL8ctbQhCMghoXQKnPUnhdEg0zyhWE7k6qM7ZpvXkuEMmrpM/8qZ9ILyD5HVfRBZnMVCPj7+RTHdLO8aO3hQjAhkJWRXfUiJzCs57OCBUEun9V80H4G8PCD14SY8/3v06pC1LMPNYQ10rTNuSJQQidrDyC25FYedUMhBS58b5nAtYgAagUggSFrS1rrk/Jf2TtvXGKk4GQOa9lNTFKseSmJ7e/NO4e+BZXtg1uV5+/kCRsUwImDz3wGRrSAnzdsv837DlOyx20EJYtVVGxX7is1memkH60YjI9J6vNXaOkq32GTnjQY5n8pBiM16/L52Tr10R/L+IE3ml37t16mGifyeeqf8NcdDewGo8oJaOZdWRp7iEuTN86wDBizMeDOiIG9toEQRhuhNsaM6d7DRBFbkoOgqX+95WQbTzBXTKoUJvclQQsMmstwFUrcV/y/pZizNu3F1ML1Xmt2pbbeaW/LTuZNOft+dCyJa/xDQJlkFVlb8NC4/pBcrpHrR3w0romaT9a2BPvPu6tymTKChcP87caZtsz8sa1DNd26DAh+Zs1XcoxRsMsPOj2QgZ4EE9XtcZwhGiEbujuysgb4jPT3D2gU/NgXOKT1BM2iDJZlXbNXuf+nj5qpvyvJitmFWwot7oRpCH4XD9cvfYCTusaPpWWRZYdNvEVIKpTcn+f+df01Qh32zUEGRNF/fjslNUqM5sU4frlAUMLWmN8EpHyBnkcKmOcy4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(15650500001)(41300700001)(2906002)(5660300002)(31686004)(8936002)(316002)(6916009)(54906003)(6506007)(478600001)(66476007)(66946007)(6486002)(4326008)(8676002)(36756003)(66556008)(38100700002)(31696002)(86362001)(26005)(83380400001)(6512007)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L3dFY0Myc3JGRURlbWkxRmxNSW9mMmE2cFZGdTZKT0J4aEhVUGVGajhvYSt6?=
 =?utf-8?B?c1JNbm5iZnpsNWM2ZnAyYVRYS3R6cmVWWFgycWN0dHpJc2FvSmllR0xTS0hO?=
 =?utf-8?B?a3p1WXVKS1NwTjMwc2xRSEk2ZllkVFpFUitQQTVWNjhXSEN5QTBCdEZkWFZN?=
 =?utf-8?B?a1ZqanBXci95cXpHRElUbHo4VWl2NnZZcVlUN3RzK0NzSmtiM1ZHTmtXU0kx?=
 =?utf-8?B?WlZMZEt0K3BYRmF2TCt2Y2xDa3JuaTU2SXBwRnlzczJhdnplM0s2ZXVydS9h?=
 =?utf-8?B?UGZVMFZFWUJ1Si9BejNXeC95Q05QbHNUMVdxWmZxRmdsc0gwRndXSmIyWm40?=
 =?utf-8?B?TVdxZGRRWmZrY2ozcHlsMkJwUlh0NEZHb2E1aGhZYjVsU3VaK0VHS09zbjJV?=
 =?utf-8?B?ZnVldE1OaXNYaVRjREZFYVR0alVkNUhuTFA0RGlJR2dSYUExczhGQ3VhQlFI?=
 =?utf-8?B?d0NwZW1uYVJOamF0YnI4SDh0dmR2Vm5XbFZQSkxQQnFXZ29kTmlXZ2tYQ0li?=
 =?utf-8?B?Uk0wdGRKN0hNYkI1cW1aMldYTlhBZGZVc0xsQitwSEdKLytKRVhNWDhKR2Vo?=
 =?utf-8?B?U0htbTU0alh5MmpkUkVta1lDRGJJK2VzOURFTVBtVVViaVhQN1VzWm4xNjZV?=
 =?utf-8?B?YUJnWjVOMXRLTFBFR1E4UUpSNi9QQU5YZUFEU3U0b2tadVFhTWxYUjN3T0Yy?=
 =?utf-8?B?QkFaMWdZZUFqNzJYT3RtMzRzMDVXQ3duZTVsNUt0elIxRnduc0RtVStCQjRB?=
 =?utf-8?B?bUNjamdoVnB5dEgzMTlNL1VIcXFleXZUTFF1VnpqTWYrazJpMW5NTWNwTVhr?=
 =?utf-8?B?anlKMUhBZVpXMDRjSUI5YkIzUHJkUm0wcDI2Tm5ucjNxYUQ1WW5YaWhsNlJ6?=
 =?utf-8?B?cEF3R0F6Zk1LbXltd2t0L1VMbDEzNFZ1Z29vUEcya2ZhRlB2cG1reElVLzlP?=
 =?utf-8?B?WUNLblJiMjdYLy9zUW5qRTZjU2kvTWF4cWk1eFFBMWkyQWYwQUNpOFhhTDND?=
 =?utf-8?B?K21FQ2gzbWVFay92QUNpRDRmSDZnUXhUdUlkM0NBQURIejlYSTZUdXJNK1pi?=
 =?utf-8?B?d3RQU1RTSy9GREdNdm5BcGFlbGE5dFgyU2hlR2FPT3ExMUJZQk9TVlluWmpp?=
 =?utf-8?B?YUJKRHZCQWFyRzZ5ZitkZFhGK1F6RXB0TEl1SnV3MFk2dE1UR0hOcHZkYjRQ?=
 =?utf-8?B?YmFUY0R6T3FTU21TMDJaMWdENzdTcjY0NS9uREgreUFuaDRXbk8yNjg1MzJT?=
 =?utf-8?B?d3Avdy9LNjJ5Q0wxZTZqOU4rSFhtYmpNYzlib0xRK2xZSW1HaVM0bmxSNWhJ?=
 =?utf-8?B?Qjh2ZEkwQ2hBZVM5N1BjQUV6Rm5HNDRIZ1FiOVNxZXNCWVRvWisvMWYvdnYv?=
 =?utf-8?B?VGxVMEZzeDE2SDVvd2NGajc1WHl5enU3R3FsNUR5N0x2WEpLaWw4L0hsbjJN?=
 =?utf-8?B?eFdtc0krTlpKRVpueFdsU1lkak0zblhXYlI0SE9ZUFpnbCtBL1JQWjcwaHJU?=
 =?utf-8?B?eXloSk5ra1N3MU9PcitSdnJIYlVOV0tpeGRFQnd2K0FvSFJKeDBWZGNSOFlF?=
 =?utf-8?B?SlBGYkdiMTZmdktzL3FWTTZnZUZnNW41ekxRdGtoSGs4N1lBRldJdlg1N3Fq?=
 =?utf-8?B?V0J4VDg5YU9ZVGRxQTRjKyt2TVpUalRyczVPTFU0TWQ0S1ZZT2hpUTVZeWl4?=
 =?utf-8?B?Y2tDOTVmdUl2V2hVQnlIWnpuV0p5cnJoUUI1U09QTlk3NURtZ3kzbERaNE9s?=
 =?utf-8?B?NFlGa2pTbjVhSzUzM1pSc2xNRDZlekN5SHVZWkYraThFNVoyVzRWY1hvbXZT?=
 =?utf-8?B?ZTVQcUNBbSs5STRQYXpUdENMWVF6WUJHNFJ5UXVDc1Z1RkNLS24wdHZLMllw?=
 =?utf-8?B?R044VldxNzM1YVBkT3NlaW1wU2twWi9NQjZYdnA4Y2lDTEw5Z1hqZWpWcXNO?=
 =?utf-8?B?aGIxcnBWSWhQWGV1bTRaSGdVeUxpd2QxemxPMkhDRVVKMXdydkJONU5xcnIv?=
 =?utf-8?B?eEc2bXpZUFExTytFaDdOOVgzSjh6Q1dUNjZuMlZqa1NtaHFiMStBbUhtUThM?=
 =?utf-8?B?Q3cwbTQ5VUxodlZWUzlrL2szSEVpUFA0TVY4NDFoNjJpaUwzTjdYaDJqV3VZ?=
 =?utf-8?Q?QnvGE1NJxNTHJQ6F7XmyY2WdT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 519bc538-f9d8-498d-a15c-08dab1a54a7d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:41:10.5063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TrDuOGT569USg1YIsWPmbErc/tzLJy1A0eNgBCd+joJDfNF5nbDlWxn9h7eNufDbkpIXnPDEWNI4D4xR09/R8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7053

Before adding a new vCPU operation to register the runstate area by
guest-physical address, add code to actually keep such areas up-to-date.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: Pages aren't marked dirty when written to (matching the handling of
     space mapped by map_vcpu_info() afaict), on the basis that the
     registrations are lost anyway across migration. Plus the contents
     of the areas in question have to be deemed volatile in the first
     place (so saving a "most recent" value is pretty meaningless even
     for e.g. snapshotting).

RFC: Can we perhaps avoid the VM-assist conditionals, assuming the more
     modern behavior to apply uniformly for gaddr-based registrations?

RFC: HVM guests (on x86) can change bitness and hence layout (and size!
     and alignment) of the runstate area. I don't think it is an option
     to require 32-bit code to pass a range such that even the 64-bit
     layout wouldn't cross a page boundary (and be suitably aligned). I
     also don't see any other good solution, so for now a crude approach
     with an extra boolean is used (using has_32bit_shinfo() isn't race
     free and could hence lead to overrunning the mapped space).

--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1599,14 +1599,55 @@ bool update_runstate_area(struct vcpu *v
     struct guest_memory_policy policy = { };
     void __user *guest_handle = NULL;
     struct vcpu_runstate_info runstate;
+    struct vcpu_runstate_info *map = v->runstate_guest_area.map;
+
+    memcpy(&runstate, &v->runstate, sizeof(runstate));
+
+    if ( map )
+    {
+        uint64_t *pset = NULL;
+#ifdef CONFIG_COMPAT
+        struct compat_vcpu_runstate_info *cmap = NULL;
+
+        if ( v->runstate_guest_area_compat )
+            cmap = (void *)map;
+#endif
+
+        if ( VM_ASSIST(v->domain, runstate_update_flag) )
+        {
+#ifdef CONFIG_COMPAT
+            if ( cmap )
+                pset = &cmap->state_entry_time;
+            else
+#endif
+                pset = &map->state_entry_time;
+            runstate.state_entry_time |= XEN_RUNSTATE_UPDATE;
+            write_atomic(pset, runstate.state_entry_time);
+            smp_wmb();
+        }
+
+#ifdef CONFIG_COMPAT
+        if ( cmap )
+            XLAT_vcpu_runstate_info(cmap, &runstate);
+        else
+#endif
+            *map = runstate;
+
+        if ( pset )
+        {
+            smp_wmb();
+            runstate.state_entry_time &= ~XEN_RUNSTATE_UPDATE;
+            write_atomic(pset, runstate.state_entry_time);
+        }
+
+        return true;
+    }
 
     if ( guest_handle_is_null(runstate_guest(v)) )
         return true;
 
     update_guest_memory_policy(v, &policy);
 
-    memcpy(&runstate, &v->runstate, sizeof(runstate));
-
     if ( VM_ASSIST(v->domain, runstate_update_flag) )
     {
 #ifdef CONFIG_COMPAT
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -231,6 +231,8 @@ struct vcpu
 #ifdef CONFIG_COMPAT
     /* A hypercall is using the compat ABI? */
     bool             hcall_compat;
+    /* Physical runstate area registered via compat ABI? */
+    bool             runstate_guest_area_compat;
 #endif
 
 #ifdef CONFIG_IOREQ_SERVER



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:41:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:41:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425556.673459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3hv-0004vZ-8C; Wed, 19 Oct 2022 07:41:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425556.673459; Wed, 19 Oct 2022 07:41:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3hv-0004vS-52; Wed, 19 Oct 2022 07:41:43 +0000
Received: by outflank-mailman (input) for mailman id 425556;
 Wed, 19 Oct 2022 07:41:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3hu-0003Zj-8V
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:41:42 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 78b0655a-4f81-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:41:41 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB8064.eurprd04.prod.outlook.com (2603:10a6:102:cf::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 07:41:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:41:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78b0655a-4f81-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M3o+6L9+WDc1yJ+tJBF/w+Yu8Ob5PCY/kqxIHbXRAuv/1R+mdKhYoZ6M/12+9tMgHPWwmpCoYWa0jfZ6X54hofU4ekEfngGv0CiXYcN9LltNpkRPAv4ApY/cZD+AKJaI9q5zduK3550dPd7igUVXcf9ZTNAgUeC9VFpgg4NGord9soP6P280Wf97bRBWS9IKqzxuW+fTUnwIhAYSXZJx8gzRY6sKROvVMHxsuDj1snxmaamayFHtWcMYSw8jcd/oNKsCUAuAKWhI2XbB0vtkg4NnCalIDXVRJaHadv8JFpN8IgPxhDSw+0N0Ny7zwDiUJUwmRM608rFgV/8FrotUcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4zbAeKGcLxlIY49axvUp6udDpWdFPLm3sDwSLxopW8A=;
 b=A7ir7CVPeBLLXLvaABUrjhDN5NppLgRmy2MP+ymQTgGQ4KJeR2IguxDd3tsquTgxJT0ibpygEsLKWSsTAkU81hUNy5npQS8VZ+3VeAra4dR68X8G7KXkAaOOvhebCUPQi6eaPKW6Xk93zUU3faOeXOIKMgFgaM8cXME5WMuoXZq4AICDmevfpGTFOX4BAHvlGEAcl+VjiMlIymo9vLvec3Jh0Nt9DqpU/OZCBrlbCl8ukLn+eZRAqK37T+gh9UuepF/YPUcxVi4EiP6CBVHg1xfwBhX/RDrgdMdENmyQ8v9TmiTeWvkBhCpGTwKk+hwwDBYXGjK5vWo8W2IkYPasUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4zbAeKGcLxlIY49axvUp6udDpWdFPLm3sDwSLxopW8A=;
 b=KHDxoiMniU20imloNY0qf7SyHA4BAsOKKcsuLWpPXIxh1eLVCohEol7ij6he03oE4VDYWvMSYG5JwwbeQQ9tqEf77mJlmVXdHWdDK5ObTaNC0P1S3sF5JwrKfizkQeb/KC/8SomJKqfTOH3GkKXFTRg+17GJY8vAFd9bFxSr+UK2M9kNnCXAsZ64AZUxBWTMcRj/U9POkhaEgv+xBPHBma4YK9sg4dVsvx4UPnWY9CLo7fPT46G7ZvZgtZe1HlaHNZFA/QbZC3GvNs0vymeaK1lrqeiEUsYjOwFWAr/LEUUnUohGl8YYviXbcLwN5eIDD9KRgoGvAEooxgZvEajWcQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d814375-c190-ae0b-793b-a8563a23d318@suse.com>
Date: Wed, 19 Oct 2022 09:41:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH RFC 05/10] x86: update GADDR based secondary time area
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0514.eurprd06.prod.outlook.com
 (2603:10a6:20b:49d::9) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8064:EE_
X-MS-Office365-Filtering-Correlation-Id: b712a35d-e580-4324-eb54-08dab1a55c0d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	E9mQNDtbpKxXCt6fmbwstqxJCNsnzSnuo/ocAr8SvxFE9cerJsPpcepRYr6KPC/YutfwHsWF5PnBcXa0gT7maDF0q988M0L3+LF/9cEV5+EJKWRNNl60GWBxsriDsCwLBJU0y8JQCxm6GUZOAaztjG8G4G7k0A6sJl71hhyoHOIx9cry1YI3RGBnaFkTM+CEQRjucYLLd7jpRx4vRZFwP8iTZkA0P9EUA/cH+lrAXlf7M5ztoA9bH17n/BqgTeX2UigBAVh+y4pi6wyr1F4vGxOTixiWbdMZCBFAeSyCo3I78Fpjfy9R2JhZk43GsGkGwdTY6h2JuI1gFpIKhqHbi+mTVzXQBjdrvInl95lewgDWbp1xV2ONs8Am3Mn7YnxpDf2TU/ilMM+n4aoCY5bIUSXNSCfgTAB55lQ3UhWISOqmdNHhu9CZ/ZJkahJVrL2E3ZR/G+RDrv4AXmkz6YIK1om2Wr7+IYf6Stb61XRkGLi/BMq5BWzUDTnsQxrtoM41pg0gwNyC2LFilhvo5fbjuJ+r8Py8A4nltXB2QyDo1rqckxgzXrzMSv2kHLlmOzYxO/TqgKwVaALkJ+leflPmFHKGFhJ8yJ+3OCnJ4CVgE5vLBJt0DT2ja2etp55c5Z2mm4AMlcVDqPBQbJXZ0CD2GVC/IQl3MHRe0lWVhi7bid5eb1mFXSMupo84M7n3+Da1mzWhHg0xHoTW/HvVf3OAZyz23URJUl9WRm+vlu8NYVIkKQuDdpn3Ob0ghEhxJeSgl1KT/iHQ1o7kMj9rLm9vp/SAn9m7FIyasIl3Zra9UMU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(36756003)(31686004)(86362001)(31696002)(38100700002)(2906002)(5660300002)(186003)(2616005)(6916009)(83380400001)(26005)(6486002)(316002)(6506007)(41300700001)(478600001)(6512007)(54906003)(66556008)(66946007)(66476007)(15650500001)(8936002)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q20xcmNibEpqck1pVXNBNjgwQ2tvMTJnalpHZXlQRE80b0ViMWt4SUVwWmRn?=
 =?utf-8?B?UStqRmxqT1RDTGhvWDYyWFcyaWUxR2NnRC9iL29hT3pPS01md3Jyd1pQWGJv?=
 =?utf-8?B?dE94OHpiRjNpVXVYemp4UWxzdFE4UVBxelFCSGFOanBRVWJ1Z3dxY2dmU3JM?=
 =?utf-8?B?OTJvTWRvd3JqQTNJREY5VXVTV3JMbUxWNEw3Y2ZUTE9NTm4zeDFDaFhjdG9k?=
 =?utf-8?B?Q3hqYTVmKzR2bVJYWnZPKzkrWUQ5bmlzOVRyL1NrcWFhb3B5ZWN4VWo2WkpF?=
 =?utf-8?B?OW8rTTQydGtZZWt5WllrWEZVME5PSUljcVJpL1hUS0hUOVB4ZitBUmFicGMx?=
 =?utf-8?B?TTdmOTF1eTRHUGQ2R1FVUUQ4RXRJUzRtTTZ4MFA4THNRbTJ3L01QTVVnUGhD?=
 =?utf-8?B?eWpldnRBeHdrcWNjNGxrVlBHTmdWOHk4bVFRYlh4cFhzZ2NCajlzdllNYWky?=
 =?utf-8?B?cFpWQXRLVjY0MGh2UHhzTk81N3RzRjJRZW9pRDQvNlBxeXMrVFdvUVZnSlM2?=
 =?utf-8?B?MEhrZW0zdlEybUhCSHRXMjgvTnVNWVEzRTIrYVBBd0VZUWFHUmZ1YXliQUdM?=
 =?utf-8?B?MDdBLzZ0WUFPMHcwNkE0cnZ6dHBxWmxEeFVJTFlEeGtkVU1JQ0JYVlZ2R3ZL?=
 =?utf-8?B?NDBkV3BTQnk3UzNOVVdtKzd0bS9DaTh3TDRTTzlHS2E4dFErclZoUS9LeWhP?=
 =?utf-8?B?dmFpYVkrWlA0dSthcC9GUmVmMUZCeFZVcldBdzNiM1FQR3VCLzQyUlowWjdJ?=
 =?utf-8?B?YS9NS3B5MmFKUDJDaXJkbnhUSkZLZzFORlU0NytlcllWUXMrTWN6MHEzNTMr?=
 =?utf-8?B?QmN3a3JzbGhkeHU5RDdZcEVPRTJUMG5PdFg2WS8zcmhmUXdhVmRJMEt6bHMw?=
 =?utf-8?B?VUpLV1hvVTdZS3dZakJ0bnJmZFVOVm11YklsbUsra3BuNDFEMjA3ODI4RXhy?=
 =?utf-8?B?MjNTUjVHdjBNa3psWHFzak9vcGptVUNiSDF5LzlWZ2dYNVF5dUpOR2hweWto?=
 =?utf-8?B?dVU1WjYvVzNGWXBOK1FKd0Fkcis3TmlZbkRkNTJTNGRKR3FzaVpqNUJTeE53?=
 =?utf-8?B?TVQ3KzhkUzZYTEdiRVAwc0l0SjJBei9rZlVUVFFRMm9PZWhuai81RjhHTFdX?=
 =?utf-8?B?U2NoK1VXV25jN2ZKTytqSFBPTHpwcXUxZDFMWkZkWnNkUysveHMwZFhVdHhT?=
 =?utf-8?B?akMyMEROemsrMDQ2bHpyTmM2NGpIL1hUaC9mbEdyQ2VCcEpUR2VhTG5zVUdp?=
 =?utf-8?B?bm1INUMvallTOE1EaG40VVNnVk96dHZHVDZqR0o1QnpQTmttYWZ2NVhNTUxu?=
 =?utf-8?B?ZTQvYXphR3d6ditKbndmMTBDRHhYeXAxcGpFd3h2TUJ2eFhmbnNrWSs2WE1Q?=
 =?utf-8?B?dHpYWktORTRJZVIvTFVvWW9oNERtVUtvU29pdDBRZUw0ZmtCa0RuQkFLdGhG?=
 =?utf-8?B?by9TU1dyWVovaFltNWVPb3REc0VVQjRySDN3WmMzamppejBFT3VxbEZvT2JZ?=
 =?utf-8?B?QUhVMnFRZDhmZGJhS25XQWV0bnNITGhnR1J4WWcwa0JES2piU3orNGFtUGZq?=
 =?utf-8?B?cXc3RHJnQnA5S2FWRnFRS0VabFl6WmE4UVlYajdUVWlGdEZSc0NxbnoraEd3?=
 =?utf-8?B?OERESHZqNnFzSURTaUtsdFpzZ1dCVWQyRnVlbUljSUNNZEVpYk0xZ1IvVTJI?=
 =?utf-8?B?WDNZZDNCZFpMazRSWHNWSm95Ni9ZOWJlSUk2OXY5TzFIbmt4Y0R3RFlKQ1hn?=
 =?utf-8?B?aE4zeHRpSE9jQ2lHMXl0bUl2dDlzT1BSR3FPRFJvWmxIYzlwcndkeTd5c0Vs?=
 =?utf-8?B?dWNnTVRXNnpDbDFSejF4MUlrUHlGb1FvRTFtNXZMV0Z3bGhrZWRHRDBkWGNC?=
 =?utf-8?B?aGJvT2xrWHR3NW54b3ZWMTM3by8rdUxSeFRtQW9vV3p5eW1CQXlNeEc5VXY2?=
 =?utf-8?B?RFpBWGljMEFrcXp0L1M1c2JLQkZzeThnc2RPVEgxTzlNQlhBT3dNTVFyRmkx?=
 =?utf-8?B?TkxqYUY0dW41Smd4dGd0elh4TjFQcjFwSjBvNm9OZ2RmVW11ckVBZXZudUZ4?=
 =?utf-8?B?VzlnbjUwVVhvMVVRd2lQZTcraW1GdXBnMCtWTWxCc0RiV1V3UThJNEs0MjZT?=
 =?utf-8?Q?xgghug+CdryA6ejGGebRTglJw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b712a35d-e580-4324-eb54-08dab1a55c0d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:41:39.9576
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TXIy27kUkJlbrIgGLLnbwO5vnSmrMgJm3nV+Ix4EqDdP/etN5sxD7CTHCNdyKb6cxBeHOrO8ssxdOtP856h0sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8064

Before adding a new vCPU operation to register the secondary time area
by guest-physical address, add code to actually keep such areas up-to-
date.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: Pages aren't marked dirty when written to (matching the handling of
     space mapped by map_vcpu_info() afaict), on the basis that the
     registrations are lost anyway across migration. Plus the contents
     of the areas in question have to be deemed volatile in the first
     place (so saving a "most recent" value is pretty meaningless even
     for e.g. snapshotting).

--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1462,12 +1462,34 @@ static void __update_vcpu_system_time(st
         v->arch.pv.pending_system_time = _u;
 }
 
+static void write_time_guest_area(struct vcpu_time_info *map,
+                                  const struct vcpu_time_info *src)
+{
+    /* 1. Update userspace version. */
+    write_atomic(&map->version, src->version);
+    smp_wmb();
+
+    /* 2. Update all other userspace fields. */
+    *map = *src;
+
+    /* 3. Update userspace version again. */
+    smp_wmb();
+    write_atomic(&map->version, version_update_end(src->version));
+}
+
 bool update_secondary_system_time(struct vcpu *v,
                                   struct vcpu_time_info *u)
 {
     XEN_GUEST_HANDLE(vcpu_time_info_t) user_u = v->arch.time_info_guest;
+    struct vcpu_time_info *map = v->arch.time_guest_area.map;
     struct guest_memory_policy policy = { .nested_guest_mode = false };
 
+    if ( map )
+    {
+        write_time_guest_area(map, u);
+        return true;
+    }
+
     if ( guest_handle_is_null(user_u) )
         return true;
 



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:42:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:42:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425564.673470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3ie-0005bp-Mr; Wed, 19 Oct 2022 07:42:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425564.673470; Wed, 19 Oct 2022 07:42:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3ie-0005bi-IM; Wed, 19 Oct 2022 07:42:28 +0000
Received: by outflank-mailman (input) for mailman id 425564;
 Wed, 19 Oct 2022 07:42:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3id-0005MY-5o
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:42:27 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 935eeb23-4f81-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:42:26 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB8064.eurprd04.prod.outlook.com (2603:10a6:102:cf::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 07:42:25 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:42:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 935eeb23-4f81-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m4yvjRXlAT++a4p1luomrB4x147nghCWDomEr2n7DVcb3AWHSjhyhebOaJ7nIJyTNShCuWEXtT8BxyuYZkdJ7D0721FYvOSU2QJAAQ/kE9WUNcbvrGR4fLg7dooTBAiq2KnrhzUrkFmm7MxMnji6XGKA2MRQaKPQQmVhSAr1k3UGpvKriJ8p2tM+Gtl6O9Zi0svGb4WjomuXcxYSl+628iT8u4895IfcOSCzT3dG8cSi7F4gXl3q4Zv0jN2FS3NDEDU0cBiNMfDh2R34XLE5q5CgMTSjLDPdfAsrOmCARc2p4jJhASGYIuuEnPu73Fk+OxxHpwtyY/v6fcoYfigLyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vVtvQDy47SYv74CafBwlr5zPDrPScUVwTLeJSlDM1jo=;
 b=UNUC8NnMwE8gLZGE1PcvPoqx6BSnrQyQlFbaq4RRlE3Ppscup7lfUvZmaZ5Wa2Fs4GP1v0I32nhtpf42DXRUnU16IHRiHBgbBC82xZKGTKnK2ujj1SeLKrwm0zXybbcWO+kTUprWzXMs+QBMRhaQHaBrg9q0MhJ402gP5/3WShDrwAV1umm+np4OUflCFGJkJmyatvZKGgCqUfEhNcmqIZLVFtpev0EyZg1XzHJRh25IiXfQ1WECxA6TC75buIun8KkBXivBU+1tDHgbIN8gwp66mKC+AmD8T01yJcngOfzPETPPR8HJgFM6EOiZkjE3iZ18kroij86gTch1I15H6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vVtvQDy47SYv74CafBwlr5zPDrPScUVwTLeJSlDM1jo=;
 b=htwLii9fKmyNouln8Q+nQ5QTcuu8R9f5JS5z36E/WLTpZEcCV21lH+Y/oNuGHzKezLmy3z9k9tWLtF6Bb+8P1hCLQeJLi6ck7WI2p9hvk79gJBQmqc4HEeuBo1fc00/t55ynhYkujmbykavlHRAsje7iefMhhXTfhureA2ljV7tgB2WSDJORefPdi/+u2VmetHcrmkFTfMZsBmoPQWIhofXOH8HKIRvU4WtpLdFQxV4hHP+1EgwwPF/8D9Nudx4K6aVk8DUFYCemgAo8wq0Mz+0ksUb17fciX0JJYT7hSutUCichXArf6gvGEybT5mYgT5lxIV5NWKn896FTrBAsGQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bb3be891-1dad-43db-da69-f20a471ccdb7@suse.com>
Date: Wed, 19 Oct 2022 09:42:23 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH 06/10] x86/mem-sharing: copy GADDR based shared guest areas
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0115.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8064:EE_
X-MS-Office365-Filtering-Correlation-Id: e617502b-760b-4131-68c1-08dab1a576b7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	K3AP1NupAyj7rYhopa43ytpqqHS9B34FnfPkd1zCKA/FJUP6YUaDPbb4besXONadrX8+lp4qYabOcw7jI+PP5AdpBUdU9N342Xx9Zg9S77wrD9ZUZRXPLFa6WDHziSE1BXgwCPIg6HoOpinBgY2tTa3i71umP/S8QKqRFYjBg0XXR5xPx/edbg6P1fOV+zO3adY9guxDUL9SCTWGmrQi3XUx9KlyK3AaWRZxuhRWhA5r1CDc6JHdMUxdKyLw8JVczPKv+aIy6OpKH6xSyKwjG4iG3ogF6zL7Qf+EvNX/CdokT7YkiaBbQHA72jTArkjIbBTu5SqyfZApLDZ3qnStU91GikxoZ5fe9NbxODoBv/Ui3K3kVkbRnMeE1iODTRkIxlgl+vXrGBJjrzIGRB/2xpvDPTE/4e5NIMsollfbk5IRFtMfBCIFPdvwiiDoioyElP8e4w7PKhVNVjMOAQ0Ly1Ob58bieBmu76Lv7F7fLOfUk7I/4PJKmKhDOLEGL8nJ/KDecZ0b/X6MiY8OR7g5sOae1WuqcSdVGLYDv5HPXyOJrVcrA5jdSW51odkKQcoMlg7xG+RGqKluarSiV3GuX8VZ+bOz4LKE0kRWfiX5F4Her9hO9bgCdO7il9GDMK+M1+vVMNuE0K0/jnaZLpuxK7UMRhkAuvwriV817VlIZ51xYs02MUvKqz7ys8d126gsXxaY8RdCLggilSgW/H/3xAVH5DICJErMCF8fPClz4S66ObBBqtHg7bsrkiJZ/exHpcjJJzoeIm5KZxItyoRlFum6BXmFcIxSgRWAmG4RFic=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(36756003)(31686004)(86362001)(31696002)(38100700002)(2906002)(5660300002)(186003)(2616005)(6916009)(83380400001)(26005)(6486002)(316002)(6506007)(41300700001)(478600001)(6512007)(54906003)(66556008)(66946007)(66476007)(8936002)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ejdkc1hnM2F6ZEt2aXovOFl3SVJXV0wra3dDb29XK2RITVhtZUkvNmk5cVcv?=
 =?utf-8?B?YWRPMVJ4RVkyVER4SkRUbUEwdjJ0dXFrNVVlWE4xdVBHcmFIVlZEalV3Nmg3?=
 =?utf-8?B?STh3amFOS21KMVhvS3owSW9vZTQrb00yUzdyZGgyUG0yZUV1Z2ZxSWRXSFlu?=
 =?utf-8?B?U0NFUE5KanJGcjNOZ2YrRlAyNDFkWndEVmtHSlJnNTRqeU9ycG9BUTRzcDc1?=
 =?utf-8?B?SHVMNDE0MWlUZHBURzVwaTJyUTUvUWZFbGl3UU83Y0xPNS9nK3B1UFhsbGZM?=
 =?utf-8?B?SU82TnNjYTNEenAwUkJHU2E0YUpIbEtyelpJVnpaQ0NLekZ0NTZaT0VjcHhF?=
 =?utf-8?B?ZkZla0R6VFpRWWZ6YTduM290ZWtwRWQ4cTg1YWVBRk9ybXl1TEZ5cTY3SFdR?=
 =?utf-8?B?S0RaVnJuN0ZKWU1KU3ZweEIycFJwNTVMK0RPM2NoRlo1M2tZeG9BK25XUEY2?=
 =?utf-8?B?TVlONm1lK2lSM1JCVTZLZGpYcnlRYk1ZY0RSRjN6Q3dYSks3RytISTNGVE9o?=
 =?utf-8?B?OFpWQ3lCNVZ4S1p4Z0hzUUNQQ216V1Rtak12dnlONUtlTXdqNEZPNzk3WTBh?=
 =?utf-8?B?bXBJUXVJb2QreGZZMnB5cmZPV2dvaFFCSWNUdUJtRHIxL1JtSTlGOC9mSkNH?=
 =?utf-8?B?M09uT0lPT1RVazFCTUg1a1lydzV2c0NNOGMxQmM4OTRvRnNrZlAwVVhidEw1?=
 =?utf-8?B?Q2wxaldtMC9jZ0tWcVhldkc0ajBqQmN4S1JHUk5nOWNtTlBySUFHN000ZURW?=
 =?utf-8?B?NXo4V0hYS2ZQbEpXcUtPOFd2MGhVandSd1BrNXRzNm5KT3RoZmNVZVlDbldE?=
 =?utf-8?B?a3hzZDV4SGdEU3RXaE91OTdodmVRbDlhUmNOVVdsc2tQNTVSMkR0RkVjbm95?=
 =?utf-8?B?NFgvd1RSbzE3bUJwdkpGd1RTaFRNV2o4Ulk1M0xoMTZiWUl0MlZIcE5ZelRG?=
 =?utf-8?B?YWI3OVJEeHRCdU4zVmdFVnZNUmlsMUVQOXNhTkZrYzJwRDhwUzhGaHVnSkRF?=
 =?utf-8?B?aEFOVnBjSFVUclVTMkJlWUwzT0pDWEFiditFWi9kQTFwMlowbnpJL0wvZGph?=
 =?utf-8?B?U0pHRkcyQTEybG4rd0NwWm5PcjNCeG1sYVJrSlY1VTJpU2h3L2VmVDE5QlVk?=
 =?utf-8?B?cU9hSXJoWW1YdHY2K01Yb0grWG0wTmhUYUJXeWxDbzFQam40Y05TUzhSWWRr?=
 =?utf-8?B?dGlmaHp4ekZuU3VDK0w2UlV0bmdpWGtWV2NYRWo2RHkwS0xJc1g3emJ5VEtJ?=
 =?utf-8?B?VEhqcDRLYkJ6YWZPVkYvamhSNmxxYUxoVG14RW9lOFVJVENzaUJWc09GNmxF?=
 =?utf-8?B?enM2RHZnSmVQbjJyODUxV0pTVzR1OUpUV1dSSCtLWk5FTStVRTlOZDhIci9s?=
 =?utf-8?B?TVJtN0pabGorT0NVVmVMOVRaaVZ5cmZBK3h5SUJaNStZTDZnTlhnMXppbmMz?=
 =?utf-8?B?WWZ3VUgvbityWndrazVRbWZlMGRtbDg4UGRpRkdCdGo5alZacU82aEoyQmJG?=
 =?utf-8?B?aTd6MnkxUmwyWDRlL0JsSUdMNG5nTUkvZ0Q5TzNqajhWTXJJa2FzK0RmMXZ4?=
 =?utf-8?B?VzBHc3B1bHVoZXVNYnV1d3Y1em9hZjFVUW9EaXRrdWV3VllQam5hSjNndXVJ?=
 =?utf-8?B?dUJZNmhUU09SOXdZU2l3QnYxaWo4REp4NzBJQXBGckNMN2h5QytsTUxXVEFy?=
 =?utf-8?B?VGFBM0l3N1pCYjBCMkRuRmJBYVJaNjNMcUtKSSsraG8zYU9XcEF1ZjB0VUxo?=
 =?utf-8?B?NUhHc1ZtUmFqSk5VQW92KzB5WExyai9PN1B1ekI1VTRZMzJOR0lndC9iZDYv?=
 =?utf-8?B?VGlqRkhoSUxNcUpKOW8xN1NUTU5UK1dKUXNOUFBHb2poUmluRDNpRUVjZEpv?=
 =?utf-8?B?cHFYTnZHdjMvWDRuTU1HT3pvQW82L1ZGS2FBYVJybnVSZ2o1THYwQjdDOEEw?=
 =?utf-8?B?dDkwaGVrL2NGL3lyTUsvQWRWclBoYmFmMmtwYTQ3L28veUVwc0o0RWlpOHo3?=
 =?utf-8?B?WU41U2g1ZEVObFdVeW5MejJrcGxKaVh6dzQyaUFSdkZLajlvZUJlUHhoaVVD?=
 =?utf-8?B?UGZtdXNBOE9VbW5jVWs5SWcwcUwvc3lJZVRTM091MU5PbU1RVUlONk5CMy83?=
 =?utf-8?Q?rx4mqiGbuHxYxDZrxucdt85bN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e617502b-760b-4131-68c1-08dab1a576b7
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:42:25.2047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XvL1Y3Uv16KC+CwCwPZN27LxL0jMZp3cTYlOUXiWW4jXzSOdVsQ2OP4wBnvWjOU+R+2lZK6lXxI6GVauvnip/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8064

In preparation of the introduction of new vCPU operations allowing to
register the respective areas (one of the two is x86-specific) by
guest-physical address, add the necessary fork handling (with the
backing function yet to be filled in).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1653,6 +1653,65 @@ static void copy_vcpu_nonreg_state(struc
     hvm_set_nonreg_state(cd_vcpu, &nrs);
 }
 
+static int copy_guest_area(struct guest_area *cd_area,
+                           const struct guest_area *d_area,
+                           struct vcpu *cd_vcpu,
+                           const struct domain *d)
+{
+    mfn_t d_mfn, cd_mfn;
+
+    if ( !d_area->pg )
+        return 0;
+
+    d_mfn = page_to_mfn(d_area->pg);
+
+    /* Allocate & map a page for the area if it hasn't been already. */
+    if ( !cd_area->pg )
+    {
+        gfn_t gfn = mfn_to_gfn(d, d_mfn);
+        struct p2m_domain *p2m = p2m_get_hostp2m(cd_vcpu->domain);
+        p2m_type_t p2mt;
+        p2m_access_t p2ma;
+        unsigned int offset;
+        int ret;
+
+        cd_mfn = p2m->get_entry(p2m, gfn, &p2mt, &p2ma, 0, NULL, NULL);
+        if ( mfn_eq(cd_mfn, INVALID_MFN) )
+        {
+            struct page_info *pg = alloc_domheap_page(cd_vcpu->domain, 0);
+
+            if ( !pg )
+                return -ENOMEM;
+
+            cd_mfn = page_to_mfn(pg);
+            set_gpfn_from_mfn(mfn_x(cd_mfn), gfn_x(gfn));
+
+            ret = p2m->set_entry(p2m, gfn, cd_mfn, PAGE_ORDER_4K, p2m_ram_rw,
+                                 p2m->default_access, -1);
+            if ( ret )
+                return ret;
+        }
+        else if ( p2mt != p2m_ram_rw )
+            return -EBUSY;
+
+        /*
+         * Simply specify the entire range up to the end of the page. All the
+         * function uses it for is a check for not crossing page boundaries.
+         */
+        offset = PAGE_OFFSET(d_area->map);
+        ret = map_guest_area(cd_vcpu, gfn_to_gaddr(gfn) + offset,
+                             PAGE_SIZE - offset, cd_area, NULL);
+        if ( ret )
+            return ret;
+    }
+    else
+        cd_mfn = page_to_mfn(cd_area->pg);
+
+    copy_domain_page(cd_mfn, d_mfn);
+
+    return 0;
+}
+
 static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu)
 {
     struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu);
@@ -1745,6 +1804,16 @@ static int copy_vcpu_settings(struct dom
             copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn);
         }
 
+        /* Same for the (physically registered) runstate and time info areas. */
+        ret = copy_guest_area(&cd_vcpu->runstate_guest_area,
+                              &d_vcpu->runstate_guest_area, cd_vcpu, d);
+        if ( ret )
+            return ret;
+        ret = copy_guest_area(&cd_vcpu->arch.time_guest_area,
+                              &d_vcpu->arch.time_guest_area, cd_vcpu, d);
+        if ( ret )
+            return ret;
+
         ret = copy_vpmu(d_vcpu, cd_vcpu);
         if ( ret )
             return ret;
@@ -1987,7 +2056,10 @@ int mem_sharing_fork_reset(struct domain
 
  state:
     if ( reset_state )
+    {
         rc = copy_settings(d, pd);
+        /* TBD: What to do here with -ERESTART? */
+    }
 
     domain_unpause(d);
 
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1559,6 +1559,13 @@ void unmap_vcpu_info(struct vcpu *v)
     put_page_and_type(mfn_to_page(mfn));
 }
 
+int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size,
+                   struct guest_area *area,
+                   void (*populate)(void *dst, struct vcpu *v))
+{
+    return -EOPNOTSUPP;
+}
+
 /*
  * This is only intended to be used for domain cleanup (or more generally only
  * with at least the respective vCPU, if it's not the current one, reliably



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:43:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:43:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425571.673480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3jV-0006Cx-0K; Wed, 19 Oct 2022 07:43:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425571.673480; Wed, 19 Oct 2022 07:43:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3jU-0006Cq-Sx; Wed, 19 Oct 2022 07:43:20 +0000
Received: by outflank-mailman (input) for mailman id 425571;
 Wed, 19 Oct 2022 07:43:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3jT-0006C9-Po
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:43:19 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b2b1d866-4f81-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:43:18 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB8064.eurprd04.prod.outlook.com (2603:10a6:102:cf::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 07:43:17 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:43:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2b1d866-4f81-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f29W4RaYXkfx34LmHMhA1zNJbtO35OBlU5FTC9oYT9NQDiBOfEkOTg3x9Y55ijgtC5gOoDbrM0Idh9n/scK9lKJdjGiBWnuesOM74DIhkZb/1qVMIlc5Af6siftMoXJ3wG8BxwwbkpjJlYf0KdePelJkRCuJpl+3sQuOV/EXW8qCq8feIDmuwJZy+dUQwikggMZUgGYS8EJRAF2a02n0bLqgSv5BituQwmHCY4pexSmEh/BJ1cGeX0DVh/lOrKi2oW+wFIOBUDDcp56C/xs8jmyD/ylUWcx7ei3EZO2bRrspmrvi6x/OcsTdCKGevvIFIH03tsnkGtN8Pmq6wPDD0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=n7rxHqGJe7QhMdpLK67MoUseFPrCyco8DcpKedNqvNI=;
 b=jzLY1lA3KEZFogH4TNrGCdZc5r5gwZWki27fIHpEkWNnoFUaY4b5DY0JhlAyROilGn8eO56pY5AeKGIUX2MzjIL5D2OQf4GQZBds/F6c7eGLEARwFAU4gz4pXk3ehRbsLFgL4s2bW1TnzST9BhXnDXdSZ8SK4zMqnD5pli0/6/UJqYFiK1RAF3up7jrurDl+abvAA0p49JyfLmtlJxZiu7gJXYdmjuR/jRvwVdG9rumE9Pv/P+edVBIKbc/7I463GCK/CbQ+sKrLqnUjdPt/d5cl0B0+3zk4LF74k5Pg+jd2VW8Gu6I1XygWaB1nl+epfIwcTytB0qHp2DSjcr+5PA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=n7rxHqGJe7QhMdpLK67MoUseFPrCyco8DcpKedNqvNI=;
 b=kXrDL5X9ERyfMnIAFRlomb92HBzFSnc+lclYz4s2NK+RiwpygPM1mMEqHuk5sEl3mhXWS3yBmMP1UQEjigbj9Rkkr0yptITF89V6/wDjQyNSHxnktWOHqKTAfalpvX96bD7qqCbNMKJVIyicxxoQyLVHIjRv9GPJjOQJSuzJUub/Ss+HFilXZRgSEgPo+UYI/COUUJzKV6vrwNqzuclPvOINH5lNNhfVRBJRUDQsB2H1ooK+PZzD4Ex2SrgKSVVKsOtgiSWth4CLSSn0NqsSHRluhCn7UANHjCj3TDjqrPPSq50Lwb3rLAM3HfzGOD2zHwMgUGMQdVO6EgSJ0LKXQw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5a571fd9-b0c2-216e-a444-102397a22ca0@suse.com>
Date: Wed, 19 Oct 2022 09:43:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH RFC 07/10] domain: map/unmap GADDR based shared guest areas
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0144.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:95::15) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8064:EE_
X-MS-Office365-Filtering-Correlation-Id: 27c89384-1611-4788-491b-08dab1a59649
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GlqJBSv2tm/uopySD0w5U4yJg+YjgCamrIQizm6f/G06FJTvg8K0biOB24L09QgvSgiyx9pGY3TYb6MsaUaAvuMNs0CaWYgDbES1LF/JKj2ZcC5af/Se5e7ohyh/GhACpGl044LuCTNlZ8cRK7myVoUqek6t+eKxHaS2giXfIJ2QrN6h2VDmMOT6CzMu4D+YAeM+yBJngLXbHOzLpKA5xnDM+nna0rjrkP618052ucZ7yv1K3LCreG5/yDYm8VzYeAJutZVD3M4Ez9+4PK3gyQRsBUABi8Uq3oPUsF0CYlUZX3ins+nDG5r57pra2ylCpYM2S0HcCs8ZOF5I+EvOHMwfuPekZrkBCGSQZUsKg2lAsxj48F/KcJvNBK60CFmJopKLuod5+BK90MyZLQn8rUzdw4y2JWjh6kke2i6BcJ18cJNhfdLV6inkJbgyTqt8NL5LLBz5Kvui3n7ogqbeFl0qH9cT+jL/DE/QYjozHgtNisqkXRH7chdoNsmcP/oyIjutoMjvA+URGbulHKetSPUlAvQz7lCasvPPztuNCA8WPb1sf3O5Wv8eRw0oIHN509wmBHOWY0ix2EVwkSKSpcXGRpRgVRefsKC9d28txZ0VquxNr4grrhwqNEyc7UaBVX035uoBic2CfOoNpreZIZeYuauURiuogVltA1ez8m2h9xSUFfliUme7kd0cVkKOwBTRYcunh0+lTvpxJJ+54ltDRfjC6Q6dvKPUtgsRapyF2MSscRP9xUWrMfdqp28AJ7CQ8+ASoRFV2jyHujNcKSBAxSyOEEv7Ld6teU+wHmY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(36756003)(31686004)(86362001)(31696002)(38100700002)(2906002)(5660300002)(186003)(2616005)(6916009)(83380400001)(26005)(6486002)(316002)(6506007)(41300700001)(478600001)(6512007)(54906003)(66556008)(66946007)(66476007)(8936002)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dkgyZWFsWDJyVnNRei9FSlpmSHhNZEM3bmdRVm41bzIvOWlMZmQ0UzNXSTFv?=
 =?utf-8?B?c1ZRVzUyRUJVS0JxSDFqaEtPdTROaFZHYnNOTWVWaG5DdHgyaVU0Q1BUY2cw?=
 =?utf-8?B?MUFndkFXK1JyZWtoTzllcEJpYVRTK0lGa1ZXdnpoeFBQeHc3SlJlZXM0d1E3?=
 =?utf-8?B?aUV0TG1PaGxUQmhYZldGVUVHN214L1NVT1FyZS9jcEZ5T0tKRE9BYnZWNm9j?=
 =?utf-8?B?cERORmlDREluQnZkeUNxOG5BRS9IMnIrUVdBaFl0T0hQNlNzTHdQU3BRM0JG?=
 =?utf-8?B?SWl5SjYvdG1NWGhwZGZ1VlVNTUFNell4c0htOEJVL0dSWSsxRmxuRkpIaHA5?=
 =?utf-8?B?NXkyRnVaYkVhZlhGT1pKR0F0dy9rNVpoVWJURzkrcXowL0R4UzJnSTk4TDdN?=
 =?utf-8?B?TXM2SFVCeGZ4SENua1YxTHJlelpjeEo5WVR1YzFYelZjWEdtdWU4cyticHlS?=
 =?utf-8?B?VThTNENkNkloTjY3cStUdWtRYk5WenBEZmljOStLRGxpMlBPQ2lBSGxjc29F?=
 =?utf-8?B?S0tMSS8wT2k4SXpDeWZjdndVa3Z5MVV6NkVmbmRqTXNZdnVnZmtGblJKbFhJ?=
 =?utf-8?B?WDcrSStSd1MwWWh6MlQ5blEwdklQUUsycVVOVVI5ZFVIamRQbG5pNWs0SEFl?=
 =?utf-8?B?RGV3cks1Z3RLMTFrbHVBUW9hcGNJK2dHc3phMnZlNzI2UVFqMnluUzkzWHd3?=
 =?utf-8?B?NnlHeExUOFBJbEpFb3Q2VHY2RzNDTWVob29icnNtWk1jZCttdERNcFQ5Vnda?=
 =?utf-8?B?UGtkT3R1NTVxZnd6Z0ZHZDQ4azZHaTVHRnJKdmwxTlAwbG5ydU5pTkcwd1M4?=
 =?utf-8?B?VkhlSXZjVVMxQ1Mwd0xMQkVsNmhOSzRIRWVSc0NHUWh0MGMrNGVhYjIraStH?=
 =?utf-8?B?MWF2eHNTcHkrNGJzbkpvNW44eDB6eEhRTWdBa2JDNVJZYStzZng0VnVKcDhM?=
 =?utf-8?B?Vkg0QWgzQnJqSlhHMEpSUjNXZS9tN0N2QU9ZdFAvd3g4QmJUWmRvNmFmVTdl?=
 =?utf-8?B?SVh5cGc3Q1lBUTVxekd5UE9jaXVDY1NhRnlQOS9mb1M5a3M5WGVqbHZ6K2Fi?=
 =?utf-8?B?ZDJnU1JhbE5TdWZrN0JtdStkWC9tQUdUYXNRVEc0ei9wb0hOb1RNUUlQb2Js?=
 =?utf-8?B?bDdmbUFud00rNEZDZm5RNkVmNkpYVzN6OS9EZ0xHWEVrSHQ1VnlrRUl2L1gw?=
 =?utf-8?B?YVRoUDM0ZURDVmt1VEZjTk9KbzZTMk8xSXdkWEpHak1GbGpvdHU2aTcyZ3Fr?=
 =?utf-8?B?Tm42Vk1Pa3RtLzNHbmE0QnoyMkVNOHFJNnBmK1U0NkpjZzdRSUQraVhzcmJH?=
 =?utf-8?B?RUpuc1RPbEdxakExaGE1ZjZpQlBpcWt5dWZjWW50TDA0TGlZbk5LTXkvR0s1?=
 =?utf-8?B?VnpPZncxcGF2Y0pJcVBXZ3hvaTVJYXVPU0dYL2kvOXk1cjRUdU5vK3BVZmNL?=
 =?utf-8?B?QkNRL1hyZm9hSWt0Tndld3RpVHoxcms5RHFVNU5zcHcwdWtMOWo0UmxxWEFq?=
 =?utf-8?B?OWVEaG5CSHFYamo3Y0FIMzUyVHJTVS96TElJZDE3dlVQRHdyZmt2T3haMFFE?=
 =?utf-8?B?YUUrK20xM05UaXAyNXZpN2NBUmV1c1RLcTFvczY5VEhvNXk0SmhQTXlUL1Vp?=
 =?utf-8?B?YmNjOU5IeHBlN2pQeENGQmFkb2hNdUw4ZkdoWE52NkFDMEpxS29BMzFiUk5X?=
 =?utf-8?B?ZnIySFNHemFhT0NRb2Vwb1EzbXRPWm83ays5MGNRWVhhM2l2cXZDRE9rQ3c1?=
 =?utf-8?B?Y2k3QzM2TS9uNDhYSkRIRGRyTzJOZHY3VFUzd2tGMnIrY2czWDdQV3FKUDlE?=
 =?utf-8?B?aDVWaWNZSWJjaUVDV2w5Z1hnN0xEVFZ3cEpyYnZ5WVR5ODdKMC9NQnlwNmlX?=
 =?utf-8?B?RVR0MFI0eUJsb2ViK2EvZExNdkNYNnRrMXlIUHRXeHJvVEZid1JnNU82V05C?=
 =?utf-8?B?SE5CNEVXS1ZvRHRVZFh3Mi93Rm9iMGlvSmtEbnYwWXpEVHpyMDY2aHRzcTda?=
 =?utf-8?B?L0RoSVlxcU9Hbk1ZWGlKdkNOb2VWeFp6UUVEaHJJR2NzK2o2VFNwODkrWVRX?=
 =?utf-8?B?WmFCb0NoclRmQnk5dXNabDU4SDdmS0pTTnN3ODg1YTcxZjZxa1h3U1lQZktH?=
 =?utf-8?Q?OKMQ3BQg9f/e/W/PwAvFav83I?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27c89384-1611-4788-491b-08dab1a59649
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:43:17.6545
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z+Qlkht51QngTOTPPh4wW/f6M3Oq/ul+2zGgUeBNm/iMxiIAKUSWcNgTb2eK4SIxuF9TMHrkb5wWdHKzZ7GstQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8064

The registration by virtual/linear address has downsides: At least on
x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit
PV domains the areas are inaccessible (and hence cannot be updated by
Xen) when in guest-user mode.

In preparation of the introduction of new vCPU operations allowing to
register the respective areas (one of the two is x86-specific) by
guest-physical address, flesh out the map/unmap functions.

Noteworthy differences from map_vcpu_info():
- areas can be registered more than once (and de-registered),
- remote vCPU-s are paused rather than checked for being down (which in
  principle can change right after the check),
- the domain lock is taken for a much smaller region.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: By using global domain page mappings the demand on the underlying
     VA range may increase significantly. I did consider to use per-
     domain mappings instead, but they exist for x86 only. Of course we
     could have arch_{,un}map_guest_area() aliasing global domain page
     mapping functions on Arm and using per-domain mappings on x86. Yet
     then again map_vcpu_info() doesn't do so either (albeit that's
     likely to be converted subsequently to use map_vcpu_area() anyway).

RFC: In map_guest_area() I'm not checking the P2M type, instead - just
     like map_vcpu_info() - solely relying on the type ref acquisition.
     Checking for p2m_ram_rw alone would be wrong, as at least
     p2m_ram_logdirty ought to also be okay to use here (and in similar
     cases, e.g. in Argo's find_ring_mfn()). p2m_is_pageable() could be
     used here (like altp2m_vcpu_enable_ve() does) as well as in
     map_vcpu_info(), yet then again the P2M type is stale by the time
     it is being looked at anyway without the P2M lock held.

--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1563,7 +1563,82 @@ int map_guest_area(struct vcpu *v, paddr
                    struct guest_area *area,
                    void (*populate)(void *dst, struct vcpu *v))
 {
-    return -EOPNOTSUPP;
+    struct domain *currd = v->domain;
+    void *map = NULL;
+    struct page_info *pg = NULL;
+    int rc = 0;
+
+    if ( gaddr )
+    {
+        unsigned long gfn = PFN_DOWN(gaddr);
+        unsigned int align;
+        p2m_type_t p2mt;
+
+        if ( gfn != PFN_DOWN(gaddr + size - 1) )
+            return -ENXIO;
+
+#ifdef CONFIG_COMPAT
+        if ( has_32bit_shinfo(currd) )
+            align = alignof(compat_ulong_t);
+        else
+#endif
+            align = alignof(xen_ulong_t);
+        if ( gaddr & (align - 1) )
+            return -ENXIO;
+
+        rc = check_get_page_from_gfn(currd, _gfn(gfn), false, &p2mt, &pg);
+        if ( rc )
+            return rc;
+
+        if ( !get_page_type(pg, PGT_writable_page) )
+        {
+            put_page(pg);
+            return -EACCES;
+        }
+
+        map = __map_domain_page_global(pg);
+        if ( !map )
+        {
+            put_page_and_type(pg);
+            return -ENOMEM;
+        }
+        map += PAGE_OFFSET(gaddr);
+    }
+
+    if ( v != current )
+    {
+        if ( !spin_trylock(&currd->hypercall_deadlock_mutex) )
+        {
+            rc = -ERESTART;
+            goto unmap;
+        }
+
+        vcpu_pause(v);
+
+        spin_unlock(&currd->hypercall_deadlock_mutex);
+    }
+
+    domain_lock(currd);
+
+    if ( map )
+        populate(map, v);
+
+    SWAP(area->pg, pg);
+    SWAP(area->map, map);
+
+    domain_unlock(currd);
+
+    if ( v != current )
+        vcpu_unpause(v);
+
+ unmap:
+    if ( pg )
+    {
+        unmap_domain_page_global(map);
+        put_page_and_type(pg);
+    }
+
+    return rc;
 }
 
 /*
@@ -1573,6 +1648,22 @@ int map_guest_area(struct vcpu *v, paddr
  */
 void unmap_guest_area(struct vcpu *v, struct guest_area *area)
 {
+    struct domain *d = v->domain;
+    void *map;
+    struct page_info *pg;
+
+    domain_lock(d);
+    map = area->map;
+    area->map = NULL;
+    pg = area->pg;
+    area->pg = NULL;
+    domain_unlock(d);
+
+    if ( pg )
+    {
+        unmap_domain_page_global(map);
+        put_page_and_type(pg);
+    }
 }
 
 int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:44:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:44:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425577.673491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3kE-0006nh-8F; Wed, 19 Oct 2022 07:44:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425577.673491; Wed, 19 Oct 2022 07:44:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3kE-0006na-5U; Wed, 19 Oct 2022 07:44:06 +0000
Received: by outflank-mailman (input) for mailman id 425577;
 Wed, 19 Oct 2022 07:44:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3kC-0006C9-JI
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:44:04 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cd81bc68-4f81-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:44:03 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB8064.eurprd04.prod.outlook.com (2603:10a6:102:cf::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 07:44:02 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:44:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd81bc68-4f81-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UH+93NzZPaEl9BwAyleGGJPfojXWlG5Cqh1x8Nns1vD2J5OfjNA0lFqoEYnLCUwYdzqdAd1MllGrfbBKW8sHveBYRtnSLr69sG/YVlK+ecSC9jrdz+KeOCWrlexcQ2Njj22gLpUEW1z5oXG/XV02mi+rZk+0WoAvpI+kDV0K0gMttutNRbeuLh+bIVtJl8jwhP9/dKZUvP6LrW4AhkPmWsUZ3uHE9U97+ltBhKgDvxKucFSSnzmPW/ojCo0bqkRPneXKfSLLnowg6K2fc5OCXkHBtaSy+yxq2CHNUP/c2MYR2j4ufWiVY1pUHa3YefSKgBGUMoy4rfe1VAiMKXdu5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uIAHlBsa3yb3lyHlE99+Grwv42zC6285qiNcBzkrcuI=;
 b=VbYTVlSL4+2k2jwzh/9QF8Ol0Bbxx599CVi2upaP0C+8sjN9P9JksUU9kvg7++HXB5pP9PdIvTKSCggK7Ci7/fJUEgkeWk5Yh3zKWy1qByw3af40iLlknKUkanRyvWv8TPYDgfEiqRzU0ThihsufIX1XFnaZn/i8TwNsEGKHi92KOtBsO5d/0J/mWuF7SsyR6PXAKgEtwXVBrV5Nn1zkK9b/iCgniF6neRhis+TU7b4xoUUhR1TfSBrLWFt7HSSo71OC+ZWZ083GiFXVqGtHZYO/BvLGuWdY6ZSnoIDNlaxkGeTh9OoOv9ui5B5tLxeTwbtWL7w8UScbqo0ACb44LQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uIAHlBsa3yb3lyHlE99+Grwv42zC6285qiNcBzkrcuI=;
 b=rTASEkTnnFECeR4zCziETpLVSHfq6wRAWh/OEOi9b2+MNDJ9FVRGt6TVWibfDk0kfWMPfeJNl64T9lsWiS3lywgNqvKMNYeOKaDGnczJUKVaNlyHc6zOZD2HBOpBv/0L/DQoXUriI98zD4uxOhWZF3xAUpjUnSC3nUKiKMmQ12vUk8udEaM9XkBUN2f1Qd8ShFQblXCjkk+FF6YnsEEkxhhka9cgSChuKmTE/RA/FkMjGdHzFKCUoG1wKv/KGgEMbmAt0mw4Rb/XZBPNUkLBrwyG3VN7GoY1mih6gCPOsP7Iqf1edXgBh1gUpYp/wcr7mb1olGLCGXPjQLdBrFsu+A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <64915cea-918c-fc3a-6e4d-cd56b40cd225@suse.com>
Date: Wed, 19 Oct 2022 09:44:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH 08/10] domain: introduce GADDR based runstate area
 registration alternative
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0122.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:94::6) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8064:EE_
X-MS-Office365-Filtering-Correlation-Id: 40c7400c-f9cb-48c3-26f9-08dab1a5b114
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IOgZRECG5gH1I6OM4Y80/3SiCbMCzeXOvt25L2g1amD8Dmop75BIYhkOSjKwjiFDYGDCM1jl/oFxdjSwpR4jc8UXabfuawKmlChvaUoShqp3w86cpZNu9tSc90HenYP94TJ4CBCYu2scoy3iJBdrW49Ol4YA0wnGmibONUqhCz6jxqumX+bTtJU9mzhsZdjeUkePwLJ4o6G17XavJUuKxbQ++bpCHczNonrlUuPrQk3Zp3rCZYzzH3DV+TZxDKLdGdYNALn6haWYibSXYZa//4W3lxgNXMN7gmm8QMR7b2cpvT0qsrsAeoiUZ6qfM949yqw9wyDoi3SoN0O1hd8zbvrcL+UhN1ibgaBXIZLa5CMoDDYvtR/REhlAsPjg47vaJGwIrFY23gyV7NGqjKp8T18DxMVkl6o/mWbJJ3S0BVH74UDchYK7kUGx+PC91es/zRg9S3A2wSCbeGV3Tyarc3fb29Iw90WXZQ6CF5YDTNIsUPpv3HXxMokR0k+tN9VcioTEjNr8E9qTc2zi1bRGNS2ohRfWXNHz39XM6IoEc66GLRrWT+wffLlYdVRPlzj6r+ldksbd6eo1vF5RmoCcr1xMPUs/hzbin0jQK/lMfBL9m0aCmTpXz3dTyDiE5C8TozXDsp9XeOtAmevOwajY1yUu0JbgqcDDSyoS8lAg3jb3QP1I6aj9keJfKHZeO528zCu2E2WM0aYv1yNtcl7XbmatQOkH1XmKXwmbSsVdPIRuOrmYFm8gxExPcUZ0GLj0CmDI+cVP8gGBzVQQv38uz1TkFyKMff9/d+vVPPq9USU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(36756003)(31686004)(86362001)(31696002)(38100700002)(2906002)(5660300002)(186003)(2616005)(6916009)(83380400001)(26005)(6486002)(316002)(6506007)(41300700001)(478600001)(6512007)(54906003)(66556008)(66946007)(66476007)(8936002)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NXU2UWJPS2dYWW9zZEd6bmd0dlQ2YXpSamlSVmhkWmQ1QWMvbGdCYjNjMkU5?=
 =?utf-8?B?S1JzM1BRNmlLc21zaVQ0OW10MW55bTE1NDBRNytQdzBIS0RaQ1E0V0FwQkoy?=
 =?utf-8?B?YzgxNS9sZkFBRWJsOHZPR201VjhrcWNQZ2FTKzcxTGVEVWk2dmFXamFkTUVU?=
 =?utf-8?B?cjQ0RCtKdVlvYmFSZlpDKzJqeDd4ZjlwSzEySzdEb2RydnYxcW1yTG4wc0VR?=
 =?utf-8?B?dmVkb3lsajRFS3VEZWl1emNFbnFtOG1BaTAwTkZYZThUeWtvOFo2eGNnTnM0?=
 =?utf-8?B?ZjFlcWJkMHZYcXNPeE9iUkVYMVVDbkhneGRCU3VOQy9rZFFNM3lUcCtIcFpm?=
 =?utf-8?B?TU9GV0prY2dmSm5VLzBBZ091dVdoem5xYU1BSkhhRGRmOGhHUzF6U3VCK29G?=
 =?utf-8?B?ZXdEUWNkY1hEc0FLdzVjZ1MxVWRXa2w1YmRhUTk2SHBteWF4RzE0S0tKazRM?=
 =?utf-8?B?RmFnMkllL0tOSkhuUDBvaE96SHZYSThsZC9TbnBRSGxhU3p4TEI3cUJRdlcr?=
 =?utf-8?B?L2JRZkFIczU0c252SXE2SHVxV1llbXRXb0U2VUhwa3NJQnBLQVNGaFU1L2g0?=
 =?utf-8?B?UTdxT0dja0t6Sk9rdUIyTVhvMGp1UGdnVFhISEhQVWRaT1ltY3lrdTlGeG04?=
 =?utf-8?B?QWxPcHk1empTL013dkRSc01lRUlXMGZ3K3gxMlc0VjlqYUdLTGVjT2E4amhw?=
 =?utf-8?B?UHZLODhFNlBzNDdFa1JITTdVV1JRSExZcnhsc3kydGs3RnlOVndoZDJmalVH?=
 =?utf-8?B?MWZtVDdPT1hqMFI1NDJLa3k5RnBPcE0rbFhIV1dnUU9IVnhtTEFKcENrTXNH?=
 =?utf-8?B?RmVFWUlPVWpjK2hTOEpIaStNRWxvQ0hiY1V6QVB3M3dnSXJ5c3JrbHArTWxE?=
 =?utf-8?B?NUZsbU5zWTlCYTJuVE01MTcxT05PWDVYVWhGWVF6UXV6ekdieEFGZS9qSWZT?=
 =?utf-8?B?SVRzZndsRmYxaUt5UzFqR3BXd3VKTFJhRGY0TzdYbXFwTC83MDdnTWF6ZmxL?=
 =?utf-8?B?TGhaaWZMV3JrU05Va1ZLM1J6UTI1dWd5SEkwa0VzRWd5aFV6cWJpM3hISTVH?=
 =?utf-8?B?ZmsrTm1WUGw5Tis0aW90WDFFUnZ2YnozMk1PZjJBczkvMVczUGtDQVd1M292?=
 =?utf-8?B?MXNEd2pxV1F4K2U2SS92Ky96RzZGM1prd1laQUs2Y0d6VlZHMjhiM3IySGlJ?=
 =?utf-8?B?WEwyV2JxbWpBcGdVRGJVZE1CdVRiWE9JRTNjbVpQanRQaEJZNDhxNmJoaE1Z?=
 =?utf-8?B?RVB1ZUg4RVhNenFjRWZVOTBIWEd2TnZxejFwTm13b1pVbGVqYkM0YWM4bHg0?=
 =?utf-8?B?UXZzMlN5NE1Ja0hrMWhVdFkyalhxYUo0NElJOWJZdVVtKzBaVi9YaUZ3ODVT?=
 =?utf-8?B?WGJFd1hpcXNnNDUvWXZWQ2UyWG56dFE0QXNrNzVxd2FIV0IrcFB0UkE5cHJ3?=
 =?utf-8?B?WTJlL2h4OWNrUTJxdlI3R2JtUmNDWFJScC9NOFVYRi9XZGYxNDV4b29TR0Ry?=
 =?utf-8?B?NWpmUkVhMkwvbGEyVXhBQ1EzWmhOMCtyUzNoU0RNSURvUHp6QjFMUHdiSzRD?=
 =?utf-8?B?VndjdWYvZGp5aGZsSkNvOW9oTEhkRFhWT0ZMSWE0VDRRbXNDcTB2K0xTTjE4?=
 =?utf-8?B?dnRaWnZZai9EMUdLQ0ZkVW5pWnUwL0MwY2dBWThqUDlEdm1tK25kR0piRmlD?=
 =?utf-8?B?WkErRWFiWkx4UDFMeDh4b1g5em5mSWhSaWVxSS9HeHp6ZUJXT3k1OFZPenBZ?=
 =?utf-8?B?dElQb0JDRTc1VWZZQXpRTUM3L0VJc05tNG1BRlYxTlJIa2NuSTRFWHZHWU9w?=
 =?utf-8?B?MVBpQ25GTmpFZVh2K1d1OU04RllqVGpIYnV6ZVRiSE0rSUtwVEZCWFdLSXYv?=
 =?utf-8?B?MlFBem5tL2NRcm1PMjdEUWY4TGZFUDQ1VUJIc3EzNFR2OW1LdXM3YzB3dlhm?=
 =?utf-8?B?a09rby9JMENadnNQeFBUVVRaL3IvNm5pNXp1bzVIVDVvZDVCOWlyc1hLR09W?=
 =?utf-8?B?LzNmL3ZxQkQvekhrOHV0NU9sUVkrcG1EYVJIU0I0M1JwS3BiSk1CYnlENWlL?=
 =?utf-8?B?a1B1QkJXeWMwNzFJeHJJcTIwbDJzQ2ZiaUJpaTQ4aW1kUUlwZzh5Y2dIY3Ey?=
 =?utf-8?Q?HygieqmEWl+R0Ric+pows71av?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40c7400c-f9cb-48c3-26f9-08dab1a5b114
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:44:02.6048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0FH0OPZQNC2aytKi8GbB8EBedXXPjhTSRlpqI1OcdNirYjhPDHWkdxKeN7hjlCu71X/RPPyCM9nDT6eFrhSn5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8064

The registration by virtual/linear address has downsides: At least on
x86 the access is expensive for HVM/PVH domains. Furthermore for 64-bit
PV domains the area is inaccessible (and hence cannot be updated by Xen)
when in guest-user mode.

Introduce a new vCPU operation allowing to register the runstate area by
guest-physical address.

An at least theoretical downside to using physically registered areas is
that PV then won't see dirty (and perhaps also accessed) bits set in its
respective page table entries.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/x86_64/domain.c
+++ b/xen/arch/x86/x86_64/domain.c
@@ -12,6 +12,22 @@
 CHECK_vcpu_get_physid;
 #undef xen_vcpu_get_physid
 
+static void cf_check
+runstate_area_populate(void *map, struct vcpu *v)
+{
+    if ( is_pv_vcpu(v) )
+        v->arch.pv.need_update_runstate_area = false;
+
+    v->runstate_guest_area_compat = true;
+
+    if ( v == current )
+    {
+        struct compat_vcpu_runstate_info *info = map;
+
+        XLAT_vcpu_runstate_info(info, &v->runstate);
+    }
+}
+
 int
 compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
@@ -57,6 +73,25 @@ compat_vcpu_op(int cmd, unsigned int vcp
 
         break;
     }
+
+    case VCPUOP_register_runstate_phys_area:
+    {
+        struct compat_vcpu_register_runstate_memory_area area;
+
+        rc = -EFAULT;
+        if ( copy_from_guest(&area.addr.p, arg, 1) )
+            break;
+
+        rc = map_guest_area(v, area.addr.p,
+                            sizeof(struct compat_vcpu_runstate_info),
+                            &v->runstate_guest_area,
+                            runstate_area_populate);
+        if ( rc == -ERESTART )
+            rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih",
+                                               cmd, vcpuid, arg);
+
+        break;
+    }
 
     case VCPUOP_register_vcpu_time_memory_area:
     {
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1789,6 +1789,26 @@ bool update_runstate_area(struct vcpu *v
     return rc;
 }
 
+static void cf_check
+runstate_area_populate(void *map, struct vcpu *v)
+{
+#ifdef CONFIG_PV
+    if ( is_pv_vcpu(v) )
+        v->arch.pv.need_update_runstate_area = false;
+#endif
+
+#ifdef CONFIG_COMPAT
+    v->runstate_guest_area_compat = false;
+#endif
+
+    if ( v == current )
+    {
+        struct vcpu_runstate_info *info = map;
+
+        *info = v->runstate;
+    }
+}
+
 long common_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc = 0;
@@ -1963,6 +1983,25 @@ long common_vcpu_op(int cmd, struct vcpu
 
         break;
     }
+
+    case VCPUOP_register_runstate_phys_area:
+    {
+        struct vcpu_register_runstate_memory_area area;
+
+        rc = -EFAULT;
+        if ( copy_from_guest(&area.addr.p, arg, 1) )
+            break;
+
+        rc = map_guest_area(v, area.addr.p,
+                            sizeof(struct vcpu_runstate_info),
+                            &v->runstate_guest_area,
+                            runstate_area_populate);
+        if ( rc == -ERESTART )
+            rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih",
+                                               cmd, vcpuid, arg);
+
+        break;
+    }
 
     default:
         rc = -ENOSYS;
--- a/xen/include/public/vcpu.h
+++ b/xen/include/public/vcpu.h
@@ -235,6 +235,15 @@ struct vcpu_register_time_memory_area {
 typedef struct vcpu_register_time_memory_area vcpu_register_time_memory_area_t;
 DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t);
 
+/*
+ * Like the respective VCPUOP_register_*_memory_area, just using the "addr.p"
+ * field of the supplied struct as a guest physical address (i.e. in GFN space).
+ * The respective area may not cross a page boundary.  Pass 0 to unregister an
+ * area.  Note that as long as an area is registered by physical address, the
+ * linear address based area will not be serviced (updated) by the hypervisor.
+ */
+#define VCPUOP_register_runstate_phys_area      14
+
 #endif /* __XEN_PUBLIC_VCPU_H__ */
 
 /*



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:45:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:45:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425584.673503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3lD-0007TE-Lt; Wed, 19 Oct 2022 07:45:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425584.673503; Wed, 19 Oct 2022 07:45:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3lD-0007T7-II; Wed, 19 Oct 2022 07:45:07 +0000
Received: by outflank-mailman (input) for mailman id 425584;
 Wed, 19 Oct 2022 07:45:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3lC-0007Sw-2K
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:45:06 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60054.outbound.protection.outlook.com [40.107.6.54])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f1f3af92-4f81-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:45:05 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB8018.eurprd04.prod.outlook.com (2603:10a6:20b:236::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 07:45:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:45:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1f3af92-4f81-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=moBix3iTL+mkz6rmwQ8Lxjq+wqCwplriD7m1Wc2FBoP0Fd49C234W1baD8AbP2DQFUOx9JLE4ZYZSf5Ytd2T1gM/G4xAVDbBJcxdKJLZj2bLDNOLcKaYJw85eKT5o64bOuCofRCo4x1uSXOe/p6aUWr5zLlkMRjQgR5MwWSt5FbX5rB7GyngDvmeVuGb0KR58L6P47s+mZGGbBRQR/bB7B+JEp6ygL7R0+RRYwLmqjX0fIKw48nFKBy+QzPbw9uTva5Usp5KRLPfsL6mhZa58twkOpOtc7GFYa8pzCG3RHUQPkCYZlmdOfK+cm+4ew3ESVRIuk7w7loggLTRUAGCkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9eflRRB2jmPiyNvfvJoh4skvHiPaEH7JTca4Ol831Ug=;
 b=NmvinShEUZOBxVMoRUiskbK280RIZcc0sGk2t4Pk4Wd96tN17vMDnTBwh79kaZ1HJyMFIA4GVdNbOkArZ6PWWr+BsfZ60V7y2Ji0l3LiiQ1m5jz7BaDhMtEo825EiEg5KmLIuVYTsSq6Tsin67fojLuIUpg9Vcr571BvL4PoY92tcFsme3/c29JYNNvIM8MlwxoFR8wePhaCQzxpY7VSKHbnWZOZ2jwAW+QT5anz+1SpW2m2zpzUg9f48w8qJYcMmNoqfvecxRbjS9TKe1Ys3VfXf5cnfJ4TNmtvBncc1JwvS/piUWNyAzus1I8yfA5YvyXUPzcHM1czXy4FLUOxwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9eflRRB2jmPiyNvfvJoh4skvHiPaEH7JTca4Ol831Ug=;
 b=dRwIuD6ggBCTjjcntzvnkiLV3hUFz6WVLqP3W2dFBfgtmh+M+ESCAfB+eMbE/xNCqQPFADQ+EeaiZiRYvOANNA2zqwFnuBcNmR6y4uysWRcqa91JmiS+H/FfQ8Tv9ZcmftaMpFHvG97frLHZ/J0/jX8gm8LVJssaOszoN3KohkokPIqAYD7bp9OwYAWfdTpfFu3VsBENmjjNnMCHzxT4Z2kj5A9HkIsjgWdgSGK1m6/pF+9+8acePWR1mWhCp+qnwnliyXx5Kz4KdNn+4US6nGR7jzPsU9oNAXZscaLpJZUMPjpn0WNrgOS4iEN97FO+CMBvEaeXTY5Uq0Vl/Mychg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f0d6cb31-4d87-78ed-cf21-8e508211fd00@suse.com>
Date: Wed, 19 Oct 2022 09:45:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH 09/10] x86: introduce GADDR based secondary time area
 registration alternative
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0048.eurprd06.prod.outlook.com
 (2603:10a6:203:68::34) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB8018:EE_
X-MS-Office365-Filtering-Correlation-Id: 1350ba36-13f1-43cc-5d77-08dab1a5d51e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9MplujuXHuxO5nfVn/J5+8mmUx7bS9K7YH/dp8ZUjz6nb+nUGoOaJMCwjBdRJwcZNTOoMlAXr6EwFtFjTqvBtbDDuOMYfCMrVA/qPKhgFxuZ0rYWSICdP+WESIB6dqAy5x8PCJjeJvNaydun+lqxS6tast1jhvzNsSTVvuJcy2T9Bm/MCOzex2mKGnQNKWXzMhw4NRYhzJllh3yUAo6u8zoCujt9/2IuTUBRwXf2Mm69wXOWPqmnqzEXLh1X9PgXCiHMozAF70DNyHuDQOG76yBavUu1U6DVsryTMxsvu7eMAh8LUnVQ0JqhfH+w+/Q3P7O4BTZQidxtj/7jTHpBqZXrdoEN+qfA5Kiag8ipvCz+Gtn//AeMSW+0uZd5XziMCBTib0I8HfcmS1g8qptfqEGqW1MLvEASu2qCKbSQ5T1CmRO29kyiC7m1TvAe2fvz2CWwRH2dvGguUCh6yJa4fHp9GgYepQrQD/YB2/fq7d56N2qUJ+mLn+R+zuwfTYZdj++cf2cdUtO10cZ3YqMEd7ALS6y14B0Zms3swu9Pl8Z7gbBJYFmvi0MkkANbUR97Nq1wdP7wW179P5/zE/O+vWHC9ZhkADlgK+2GtbZWWOxAWCm4ZDICpBiQCwGgygYgvEACVJJ0lD4GMXjwXJJtKTBnnfXV+z0exMcEHYjU4POiq9Zjx5B1T2g8GB8MKXifxtS6vBGR3T/gAaMmFzS7RAAqYtkEkupsUKZ0OuT2qlbqf4ilRZoi4z9fDkprXEeKVY1UXZUu0JSTrm1xz+EJmx2dwY8X4pPiDQzJtx3Bu+M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(316002)(186003)(2906002)(83380400001)(31696002)(36756003)(86362001)(38100700002)(31686004)(6486002)(478600001)(6916009)(54906003)(2616005)(41300700001)(6506007)(5660300002)(8936002)(26005)(6512007)(4326008)(66476007)(66946007)(8676002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUNoWFFqcjUyR2NMOUlod2pWbXlZTjIwNzU2Q1V4T0pNaGorTkk5bG5tZWJR?=
 =?utf-8?B?Z3BJd1B5Y0tZOUUyRjNTY2xvSnpOK0JHT3l3WVZzUUVFbWdzVVF2K2plMTF6?=
 =?utf-8?B?cDNLekhnWEJoSFZ4enlBeWs1bnpBV1BCNkVEY3JDMlhFSVZZZks4eWZxTzlr?=
 =?utf-8?B?QTc0ejA3cU5nelZuRUw0eUE3SlRYUWhDdVRUSkEydXE3eWRUZWVTdmU3bVR2?=
 =?utf-8?B?NmVSYmxBam1BQVRyY2NaUThwa1F2dWo0dkdZYi9VU1lUYUtKaStrdDVMKzdI?=
 =?utf-8?B?a2l6TmxqekhyL2c1U2pYZUJzRDFLbk1XUERuNFFhS2h2Tjk1VWlXMy9tWGxu?=
 =?utf-8?B?a1o5aUs0TkhMdzFkMEdPcWVMVHYwT2lEUmpSUXFvbmNZcFUwenlXeG9WVG5v?=
 =?utf-8?B?RTgwTUFIeWFkY0w4R3VMR25ZOGdPT0lIaTRIRlFSbDliTjFad0RvK1NUVndU?=
 =?utf-8?B?Y2dsZ21FYXFhTjhDd0RnY0Rld0g4VWFwcis0ZVVzSDFNRlhFMWRabGR1N3hr?=
 =?utf-8?B?b0ZNVEphQnptQk5OSkZJV0ZEaEdJTm9ZTS8waGpHNlNMZ3ViT2U3dU9CcjZC?=
 =?utf-8?B?eDVuVmJ4S01EMGZHVXlqODhtN3FyWmtKemdBeFpPelVPQnFmdGYxdFh5cFl1?=
 =?utf-8?B?L3ltaTRKVU4yc1RDNVRvVndoMHJZYUc4akIrbElPdVFqRU00VlJHa2xsM0pl?=
 =?utf-8?B?RVY5V3p5WDBQcTkrUnF2WTNaM04wUjNFVDlnZ3A1cDhpaGpwRWtLU3hQVUxs?=
 =?utf-8?B?OFU3UVd1NXhEQ2VCS1BwUkVtQjBzdU1lT0Y3M3h6cFRGM1ltR29hTXV4cHlC?=
 =?utf-8?B?YzlkMThaZnVhK3Y3VEFvakNJaWsxQTlRQmhqUzNoRStHV2orVDRoRUQ2cTJY?=
 =?utf-8?B?cXZ0ZU0reEFPSXBPdTZSWThzRFVxTnErZ2hQQm9mNVlqUitNWUxLbUh0ZVBT?=
 =?utf-8?B?ZXJ3VTBzZ1VWMlA2bHAxRkRQQ0JleFFtenQ0WStnbXhybzFlVnFyZXd3eWs1?=
 =?utf-8?B?SGQ5RVRjelJmTzcxRytuYnBJNHlqZGN2L3JlTWFuQWFneStHVWR2L244clN6?=
 =?utf-8?B?KzIybTJDK2kwRnovbTM5UC91dk1GZjRLaThGUVdFdU9xa3RPY2dacU45MEF3?=
 =?utf-8?B?TFVtQXlCbUoxWW9zbHN4QmZabVdIclFYRVNHL3NEa2pOVTEvdnlTcnNNL29s?=
 =?utf-8?B?c1ZxSE1mTUlySzk2MUxXVXV6MUhKK1RlYUhBMHFteUZ2TVRLU1RNRFRLUGVB?=
 =?utf-8?B?d0RZNENRc3d5blRqSDN6bGZXdWFMZVFRc0ovSEI5L1Z4R0FDS1hybERxNS81?=
 =?utf-8?B?clFia3VBTkNBNExiZzk5YnMwOU9SSUtUY3RxSUhKcGYwNjV6Sko0dFhKOER3?=
 =?utf-8?B?Zmh4anRIRlhmN1NjNFFtL0Z5eWxhdHRnR2lqSERKL3MxakF1VlZueEUxd251?=
 =?utf-8?B?Y1hyMHpjengwSURPREFVYzVZeGhncXVya09PWGdka0tZMThGaUphRmhRVFFQ?=
 =?utf-8?B?MFNqelZ4WFRSNHBlUy80andhM2V1SVQ2RFhsVnZVaWRjT1R5MDlKQlp5VjV0?=
 =?utf-8?B?Y1B2SkNySUJpNGNFQmxFdW5ud0dvNlpqWXZrcGdmVGE0ek95MUQ1L0l3Y0Jw?=
 =?utf-8?B?dG15OFJjYjhlUUh0RUsyQzc0ZTZzYWJlTUZBN3haWEdaWU1SUE5hTHA5YklP?=
 =?utf-8?B?dEJoazZVNU1QWEtEMXJReWFBeU5aNUlLcGI1VFNBdWpHSzdhVnlRUFFmTURR?=
 =?utf-8?B?bGpjeU1JbmFLZFEyN2IzZC84aEpTYmdXWXB2UmpPTHkrRjErMytVTVBHOHBR?=
 =?utf-8?B?dXlYVGxKeGEwZ1FuQ2cwTmlCQXZoWVM5eUNPMHdjS05CeDAyZXIvL3FMNURK?=
 =?utf-8?B?bU5OVDlKUVlpa1pCUFY2OGhNcTNzYVVSMUFQNFJXZld2bHBnSm1SZFBiRkNw?=
 =?utf-8?B?NDBoOFk2RkhUZUNHczdNdmlscG1SYjlibHFjL0gzdnUxbktVUmZrVzdhWXNU?=
 =?utf-8?B?SHB1cUhwTXhvakZyVkZ0UVZFenBjY1lvaGY0dFZuSHFlVGZCdzNXY2RiZkRa?=
 =?utf-8?B?MjNwMklmbDBGQzNKQURZdi9XUXRIdXpIZEs2cmxkWFEzd2kreWNUWi9oQ2FB?=
 =?utf-8?Q?vU8WELX2EOMNkpVRO1r4rqziY?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1350ba36-13f1-43cc-5d77-08dab1a5d51e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:45:03.1166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1F4PrKNus+XtsfTrp2xvWHMg25bdippVu7hh+UXefZ2C87cA/wVJWINKDBIdjL2CUvooMaqqJeUOLy/s1NsUhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8018

The registration by virtual/linear address has downsides: The access is
expensive for HVM/PVH domains. Furthermore for 64-bit PV domains the area
is inaccessible (and hence cannot be updated by Xen) when in guest-user
mode.

Introduce a new vCPU operation allowing to register the secondary time
area by guest-physical address.

An at least theoretical downside to using physically registered areas is
that PV then won't see dirty (and perhaps also accessed) bits set in its
respective page table entries.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1520,6 +1520,15 @@ int arch_vcpu_reset(struct vcpu *v)
     return 0;
 }
 
+static void cf_check
+time_area_populate(void *map, struct vcpu *v)
+{
+    if ( is_pv_vcpu(v) )
+        v->arch.pv.pending_system_time.version = 0;
+
+    force_update_secondary_system_time(v, map);
+}
+
 long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc = 0;
@@ -1557,6 +1566,25 @@ long do_vcpu_op(int cmd, unsigned int vc
 
         break;
     }
+
+    case VCPUOP_register_vcpu_time_phys_area:
+    {
+        struct vcpu_register_time_memory_area area;
+
+        rc = -EFAULT;
+        if ( copy_from_guest(&area.addr.p, arg, 1) )
+            break;
+
+        rc = map_guest_area(v, area.addr.p,
+                            sizeof(vcpu_time_info_t),
+                            &v->arch.time_guest_area,
+                            time_area_populate);
+        if ( rc == -ERESTART )
+            rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih",
+                                               cmd, vcpuid, arg);
+
+        break;
+    }
 
     case VCPUOP_get_physid:
     {
--- a/xen/arch/x86/x86_64/domain.c
+++ b/xen/arch/x86/x86_64/domain.c
@@ -115,6 +115,7 @@ compat_vcpu_op(int cmd, unsigned int vcp
 
     case VCPUOP_send_nmi:
     case VCPUOP_get_physid:
+    case VCPUOP_register_vcpu_time_phys_area:
         rc = do_vcpu_op(cmd, vcpuid, arg);
         break;
 
--- a/xen/arch/x86/include/asm/domain.h
+++ b/xen/arch/x86/include/asm/domain.h
@@ -684,6 +684,8 @@ void domain_cpu_policy_changed(struct do
 
 bool update_secondary_system_time(struct vcpu *,
                                   struct vcpu_time_info *);
+void force_update_secondary_system_time(struct vcpu *,
+                                        struct vcpu_time_info *);
 
 void vcpu_show_execution_state(struct vcpu *);
 void vcpu_show_registers(const struct vcpu *);
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1524,6 +1524,15 @@ void force_update_vcpu_system_time(struc
     __update_vcpu_system_time(v, 1);
 }
 
+void force_update_secondary_system_time(struct vcpu *v,
+                                        struct vcpu_time_info *map)
+{
+    struct vcpu_time_info u;
+
+    collect_time_info(v, &u);
+    write_time_guest_area(map, &u);
+}
+
 static void update_domain_rtc(void)
 {
     struct domain *d;
--- a/xen/include/public/vcpu.h
+++ b/xen/include/public/vcpu.h
@@ -243,6 +243,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_register_ti
  * linear address based area will not be serviced (updated) by the hypervisor.
  */
 #define VCPUOP_register_runstate_phys_area      14
+#define VCPUOP_register_vcpu_time_phys_area     15
 
 #endif /* __XEN_PUBLIC_VCPU_H__ */
 



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:46:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:46:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425591.673513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3m3-00085V-UK; Wed, 19 Oct 2022 07:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425591.673513; Wed, 19 Oct 2022 07:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3m3-00085O-RS; Wed, 19 Oct 2022 07:45:59 +0000
Received: by outflank-mailman (input) for mailman id 425591;
 Wed, 19 Oct 2022 07:45:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3m1-0007wU-Ml
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:45:58 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1089ad06-4f82-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 09:45:56 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB8018.eurprd04.prod.outlook.com (2603:10a6:20b:236::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 07:45:54 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:45:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1089ad06-4f82-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HmShmaqQykFqvmtCcfCQ1GOW4Os2WvVSex46DrA1W/IA2XONfWPJZk5ErWkmBSOyIQcFanUMApAoyfk0ZDxh8FzhVIO7CA6rfV2hDgbW+t1/zAhL8XLnTdcvwJRX0QgKHiQzkYP/8jNhm8wJEPoHxHZxJtkRwKhRkQeJkKAvdwL93aLXZ+zVYLRrFAeBjjXDLh5i0TD4nJI6gX3Flbs6aBKlg+mFcQmIDgFhXtFxqKvZE7wZJiC6JQZyY63TPGbLH9TW06OCdQ2q+38G75SjDet/Px5X+ONIiwoh9mGmaUXwD3yjz2HWvpy7uucLO/pTsvbHSUWGGgYXVNAUe/MaLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DgBhR75TKXzhjJAKk8igA43OaQRf/s9CHiXdfaBkBfE=;
 b=iz25YbwMEI8ZEwfiXIX1isd7+QjHbDI+Qenlwqd9kfuEWxhyFlnFnfkNjwJk+zJC7NwCMvfM2rE2b3n3/g5pC+T6E6H3s46UAWZF6dHOKxRy0gLJy/Z2DTSBKebYZf20WNYpq4kNVFtTMO+5Uf+7tnu5g0q0eyIYCt32M2CVo2RMYKGFu3vaXrdd4uEmUdDRR0WGMGuNR5JWpRcJbZo65/gc1VQDWdSXc/GYk4UAlLwKRP0LNzBjSoWFohyn2ycG0G0MEyg1+a021jYjFSsBLE45BCftmEilv+yUh2qVszJ0je4jXgWmaCgL3MBmaCIaOO7SLlq66cbWLzs/JtAH/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DgBhR75TKXzhjJAKk8igA43OaQRf/s9CHiXdfaBkBfE=;
 b=WiPwRwz/yM48cBypGN2NvO1SJMJmqMJFJ9laL+qptGd36jswR3IjjY0vPTweTf0D8slKscE/lIwMRgm2L94IXyePTnpc8FMVE51PiaehwApJKMdUG/HhnOMUP59DFLDWQSWrX0/0yhQz0/IniIPwHIm9/FFzowW/M6yoRFxYQOACuoM9YCbDU21cDx1nTuG5lhinDDA1NxnfB21IQvNEjMV8xssOfS1jFMWqqLmwDwkSvKnOswRtjUoY9kRDzYqY4cZY1bV/gkeaqMydEXUh8lDa8jimiFS4caDW56m984f+GcrJFevW5DDT+BwgrKhEW4XQBd/aCwABX2CWaJZYLA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f1745e62-8a46-e9af-6a79-592a5402a5f4@suse.com>
Date: Wed, 19 Oct 2022 09:45:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: [PATCH RFC 10/10] common: convert vCPU info area registration
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
In-Reply-To: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0047.eurprd06.prod.outlook.com
 (2603:10a6:203:68::33) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB8018:EE_
X-MS-Office365-Filtering-Correlation-Id: 2dcfca35-a02f-4ce7-ae75-08dab1a5f3d9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2T65b7R6Aal8xTNpLsZA6Y7pIPoufXUXsCieyNMeOAV2reGiv0yma6tRbOwmzYhH5DrYW/HT/scx6UVlkfFkdoXKbnYcDwMrbzPKAI2JDDle5u4y5nI1g1bUW+EiQFZjxzzqicyP2HJtzF+QLnSBwOlWoFUxTitmz+ETchAcRMXaAnN6v1FR17uZhF22XIIyMLOysb0i4gfQCfHu+wAoS3SAU8snYxb/t4Gd57Kck0CYwHGxbOkL2FKV3b+69uHvy+miEhZh5oXLrfH7gmcj2Z+8Oy6ujAVXdpK7er3nIJeETIEASlIykqPZ+IurHICF8yD1koUPC3rFwPAIj8YrpN1QPFU0LDPSZaWj9CJP4PT5XxJo4ndhjzntTD6qIuYS+aRRhTDtNaHkudWcUUuE+NlWDGPYl5h8pIUBaJB/li0vKRBlF/M7Q1fXHDrloj/nAatLvzDcOiS+5JcNjCa7Sc6SYFQnLB7PJf6GUzCtayhZKfPO7jQcXjpLv+toKQl8rWXA8z6Y6PDriduKc9HJRP4bqYavER+OU0SlFlJeUKJKTbupX8VDfIPCb7WyCzJLpHj62zR2CcSfS3/hPQQIlemylO3CJ9TL6aXlcolVvWeFyas5ew97Hh81EMlZq1ZECXGLzBsGP/IRDP5uk/JLOi7NYKgwfAwkpwsJMgYpd79LM4ioWPBqdnx9XEekz8WM2WgNFUZYdus5JyBSI7/Rz1XY+aNS4HkMvHRMWfMV831KLqLM5rqqJeQa0Wa2uQT45uBmj/pUGwhUqSKJDrOq4iUOygoN9veXGr28YNcZ7Zy64W48VTuYQ0bcX9RHk9Vp
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(316002)(186003)(2906002)(83380400001)(31696002)(36756003)(86362001)(38100700002)(31686004)(6486002)(478600001)(6916009)(54906003)(2616005)(41300700001)(6506007)(5660300002)(8936002)(30864003)(26005)(6512007)(4326008)(66476007)(66946007)(8676002)(66556008)(45980500001)(43740500002)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UmY3SGhPOGp3UmtoZjhGSFBETWQ5clNSWG5IQkMzSUJQdG5Da2lObzRhd0Jh?=
 =?utf-8?B?QTJoaGVkMUpnUjhwTlRWdTJaR3hHdy8xZEhwWndKTWVsdTJMT2Y3cnhMUVM3?=
 =?utf-8?B?QVZ6SE5ISHMzbkJBbGJ3UXZNZEN2elVDeFVmWWptVjEyN1AwT0VPVmdpUklJ?=
 =?utf-8?B?cXVxVlpyTWZQQWt2MlNJZHB2dS9wdHdpK3ozNUhTTFNrT2ExNy85dDJhdWRT?=
 =?utf-8?B?NVhiU0ZydlMyY3N3WW9VaU0vRkpUemFyTDJQMVV0MDFxQUNJZ3JYWTd3RmZN?=
 =?utf-8?B?QktvbnRDQjR5K1BpUmJxQm5wUjNrdHJCTitKRllZa3loRXJGdEg2VUsrckZ3?=
 =?utf-8?B?dFEzb2NoSWdZNVJMYitEc0xnMTZpczd1eDRSRzljMEtwaDY5bUFqdERROE1H?=
 =?utf-8?B?NllKZHF0VmxBek5EK1ZzT052ZWc3dW01UmNVOU5BUnluQUpZYWdtRElrUHRm?=
 =?utf-8?B?aWt2R0JzOVZuU1grM2FHMHdmUTIvR3UyMkg2Yk5GY05SSjZBQTlvVDVhT3Nr?=
 =?utf-8?B?ZE01OFNEY0R2ZDFMbStrakVUR08wMnFGZlcwWlVRR1d2UlVvcU1pUTdpaHgr?=
 =?utf-8?B?Tk5zY1JDNWZoeEcwMWtsSDlRQ0JhSmZXbWVUbkt0a2FDRGdyNE1veUlyNTFZ?=
 =?utf-8?B?WDNxQ1duQVRwME11VXRHNjViUUFXSFZLTmNFY0ZNbjl0T2t4VlVjNWN6K2RT?=
 =?utf-8?B?aGY4ZUNxRWh0M00vS21VenZUZ0hsTzRLVW1xanNHNWRBbU5oaHdQdkZjT2hu?=
 =?utf-8?B?TDl0TWR5ak9RNkJFb3FCQzY4UjhUNW95b0gvN1lPREpNa01yUnl0M2pkdEJQ?=
 =?utf-8?B?THVxby9FRnhYUktzSU91WXl3V05Fclc1NldZQ1Z2Q2E2MFBabmZ3d2J4cisr?=
 =?utf-8?B?UEpjL09DU0N4enk4RFBXUVlJWmpVUXNwL1N4NWZ6RHFHL1BGd09TZlU5VTV2?=
 =?utf-8?B?SXZRQ082QnZ5aCtxNUJyY0YzRjVVRCt1a0JMZ2tHSDJ1VW5yS1crcC9EZnNt?=
 =?utf-8?B?ODhSVWNGYzJMVHhtQThFWjdEdTFiTEZTZ2tET0xrT2pYZlJ6TkQzNzhqT0JE?=
 =?utf-8?B?VzVyY29Gb05zODBWbWFVOXBReURnTml3dWZ3MHREOXhVWWtsVmJtZ2R1UlR0?=
 =?utf-8?B?U0txam5sUWpmMHF2cWNDZUNSM0pxTmRxcTJmQjJNRzFjTndQVmR1bXNDU2hL?=
 =?utf-8?B?ZE9VcFo1dkJZYXZ2SkgvZElYRE9OY3k5ZFEvVGlJN1JrWUdKbnlsbXEySnpn?=
 =?utf-8?B?T0wrb3JxMng4UkRJM29OcTFvRC90UnJCbjBPSm5iSHNEQnBaWnJuRHNyMDNn?=
 =?utf-8?B?YlFDUkU1U2VJWHd1TnB4cFhKTmxqTFNlRTY0VEdWUGJJcFpKQ1RSd09FWHIz?=
 =?utf-8?B?TGVZVC9DV0hoYWVJUHpNeGNoWUhuVHlFOTFUVmJkZFIwTGd2TTk1YWloZHBL?=
 =?utf-8?B?dFRvOHRYRVd0cnBvMVFEeVRGMlF6VThucGp1eVNsVGQvdEVUNVhkMTV4L2Ry?=
 =?utf-8?B?djVqRTJGZGRrck9mY3JVWGJOTE41bVBONWsrRnRNcmsvYVlQNytRdFlHaEcz?=
 =?utf-8?B?VnVHZ3RmTGlwQ0cwWE9HaFVDRU5RYkVCVllJWHVuRXdGczhaNVBLaHF1UVYr?=
 =?utf-8?B?S2Y5RGYzWGRmb1pHUDIraG0yR1VXV1ExenRiUjBwUVozUk81cWtUUjNib2VS?=
 =?utf-8?B?WXBicWlQajBJTVRPSzl2bkFFNSsrWWlzWHpMcUp2MUNRcDhZekJCcEJXdHhZ?=
 =?utf-8?B?SUphbjZyN1N4WGxyb0o4KzRNRng5eStWMEo5ckpGaVhKRkhEV2l5T0dNRUVy?=
 =?utf-8?B?RlFIcWRXeDhZQk5ELytOSFdtcS9rRjBMbXdWajZWOFdEY01JdlVCSlZQWENI?=
 =?utf-8?B?MXUxdGZNS3J4NThoYkFvOXVyZUo5OVBDR216Z2EyMVpDbk96U2swNXAzVmdJ?=
 =?utf-8?B?RDBMcjVjQWFOd1RLVWxCaCtOYXVITWpvd2lQb1FMdU4wZTFrQlFuNkgwbEtF?=
 =?utf-8?B?QTBpQzc5WitXVzF0bkRoNlkvdTNJRURtZDk5VitHYlF6bDFzblBjcEpZY0VG?=
 =?utf-8?B?NGYzSStET0trWXFVaW5OTkcyMWlWYWZ0eHFEMHpVY2w0Z0xTN3YrSFBMcGtL?=
 =?utf-8?Q?qmJnh+8sP2n6iG0pnW7oOlmCR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dcfca35-a02f-4ce7-ae75-08dab1a5f3d9
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:45:54.6446
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HIxhdHhpl8su2QnFekvrpJ10UDoYmLUcgdVaDKrmkZLPIde2EjEbvwB92JvDLaUxr1Pr7dBkAd30niVc4nRVxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8018

Switch to using map_guest_area(). Noteworthy differences from
map_vcpu_info():
- remote vCPU-s are paused rather than checked for being down (which in
  principle can change right after the check),
- the domain lock is taken for a much smaller region,
- areas could now be registered more than once, if we want this,
- as a corner case registering the area at GFN 0 offset 0 is no longer
  possible (this is considered an invalid de-registration request).

Note that this eliminates a bug in copy_vcpu_settings(): The function
did allocate a new page regardless of the GFN already having a mapping,
thus in particular breaking the case of two vCPU-s having their info
areas on the same page.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
RFC: While the "no re-registration" check is retained, it is now racy.
     If we really think it needs retaining _and_ properly enforcing,
     then locking will be needed, but I don't think we can hold the
     domain lock around a call to map_guest_area(), first and foremost
     because of its use of vcpu_pause().

RFC: Is the GFN 0 offset 0 behavioral change deemed acceptable?

RFC: To have just a single instance of casts to vcpu_info_t *,
     introducing a macro (or inline function if header dependencies
     permit) might be nice. However, the only sensible identifier for it
     would imo be vcpu_info(). Yet we already have a macro of that name.
     With some trickery it might be possible to overload the macro
     (making the "field" argument optional), but this may not be
     desirable for other reasons (it could e.g. be deemed confusing).

--- a/xen/arch/x86/include/asm/shared.h
+++ b/xen/arch/x86/include/asm/shared.h
@@ -27,16 +27,16 @@ static inline void arch_set_##field(stru
 static inline type arch_get_##field(const struct vcpu *v)       \
 {                                                               \
     return !has_32bit_shinfo(v->domain) ?                       \
-           v->vcpu_info->native.arch.field :                    \
-           v->vcpu_info->compat.arch.field;                     \
+           ((const vcpu_info_t *)v->vcpu_info_area.map)->native.arch.field : \
+           ((const vcpu_info_t *)v->vcpu_info_area.map)->compat.arch.field;  \
 }                                                               \
 static inline void arch_set_##field(struct vcpu *v,             \
                                     type val)                   \
 {                                                               \
     if ( !has_32bit_shinfo(v->domain) )                         \
-        v->vcpu_info->native.arch.field = val;                  \
+        ((vcpu_info_t *)v->vcpu_info_area.map)->native.arch.field = val; \
     else                                                        \
-        v->vcpu_info->compat.arch.field = val;                  \
+        ((vcpu_info_t *)v->vcpu_info_area.map)->compat.arch.field = val; \
 }
 
 #else
@@ -57,12 +57,12 @@ static inline void arch_set_##field(stru
 #define GET_SET_VCPU(type, field)                           \
 static inline type arch_get_##field(const struct vcpu *v)   \
 {                                                           \
-    return v->vcpu_info->arch.field;                        \
+    return ((const vcpu_info_t *)v->vcpu_info_area.map)->arch.field; \
 }                                                           \
 static inline void arch_set_##field(struct vcpu *v,         \
                                     type val)               \
 {                                                           \
-    v->vcpu_info->arch.field = val;                         \
+    ((vcpu_info_t *)v->vcpu_info_area.map)->arch.field = val; \
 }
 
 #endif
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1758,53 +1758,24 @@ static int copy_vpmu(struct vcpu *d_vcpu
 static int copy_vcpu_settings(struct domain *cd, const struct domain *d)
 {
     unsigned int i;
-    struct p2m_domain *p2m = p2m_get_hostp2m(cd);
     int ret = -EINVAL;
 
     for ( i = 0; i < cd->max_vcpus; i++ )
     {
         struct vcpu *d_vcpu = d->vcpu[i];
         struct vcpu *cd_vcpu = cd->vcpu[i];
-        mfn_t vcpu_info_mfn;
 
         if ( !d_vcpu || !cd_vcpu )
             continue;
 
-        /* Copy & map in the vcpu_info page if the guest uses one */
-        vcpu_info_mfn = d_vcpu->vcpu_info_mfn;
-        if ( !mfn_eq(vcpu_info_mfn, INVALID_MFN) )
-        {
-            mfn_t new_vcpu_info_mfn = cd_vcpu->vcpu_info_mfn;
-
-            /* Allocate & map the page for it if it hasn't been already */
-            if ( mfn_eq(new_vcpu_info_mfn, INVALID_MFN) )
-            {
-                gfn_t gfn = mfn_to_gfn(d, vcpu_info_mfn);
-                unsigned long gfn_l = gfn_x(gfn);
-                struct page_info *page;
-
-                if ( !(page = alloc_domheap_page(cd, 0)) )
-                    return -ENOMEM;
-
-                new_vcpu_info_mfn = page_to_mfn(page);
-                set_gpfn_from_mfn(mfn_x(new_vcpu_info_mfn), gfn_l);
-
-                ret = p2m->set_entry(p2m, gfn, new_vcpu_info_mfn,
-                                     PAGE_ORDER_4K, p2m_ram_rw,
-                                     p2m->default_access, -1);
-                if ( ret )
-                    return ret;
-
-                ret = map_vcpu_info(cd_vcpu, gfn_l,
-                                    PAGE_OFFSET(d_vcpu->vcpu_info));
-                if ( ret )
-                    return ret;
-            }
-
-            copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn);
-        }
-
-        /* Same for the (physically registered) runstate and time info areas. */
+        /*
+         * Copy and map the vcpu_info page and the (physically registered)
+         * runstate and time info areas.
+         */
+        ret = copy_guest_area(&cd_vcpu->vcpu_info_area,
+                              &d_vcpu->vcpu_info_area, cd_vcpu, d);
+        if ( ret )
+            return ret;
         ret = copy_guest_area(&cd_vcpu->runstate_guest_area,
                               &d_vcpu->runstate_guest_area, cd_vcpu, d);
         if ( ret )
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -395,7 +395,7 @@ int pv_shim_shutdown(uint8_t reason)
     for_each_vcpu ( d, v )
     {
         /* Unmap guest vcpu_info page and runstate/time areas. */
-        unmap_vcpu_info(v);
+        unmap_guest_area(v, &v->vcpu_info_area);
         unmap_guest_area(v, &v->runstate_guest_area);
         unmap_guest_area(v, &v->arch.time_guest_area);
 
--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1438,7 +1438,7 @@ static void __update_vcpu_system_time(st
     struct vcpu_time_info *u = &vcpu_info(v, time), _u;
     const struct domain *d = v->domain;
 
-    if ( v->vcpu_info == NULL )
+    if ( !v->vcpu_info_area.map )
         return;
 
     collect_time_info(v, &_u);
--- a/xen/arch/x86/x86_64/asm-offsets.c
+++ b/xen/arch/x86/x86_64/asm-offsets.c
@@ -53,7 +53,7 @@ void __dummy__(void)
 
     OFFSET(VCPU_processor, struct vcpu, processor);
     OFFSET(VCPU_domain, struct vcpu, domain);
-    OFFSET(VCPU_vcpu_info, struct vcpu, vcpu_info);
+    OFFSET(VCPU_vcpu_info, struct vcpu, vcpu_info_area.map);
     OFFSET(VCPU_trap_bounce, struct vcpu, arch.pv.trap_bounce);
     OFFSET(VCPU_thread_flags, struct vcpu, arch.flags);
     OFFSET(VCPU_event_addr, struct vcpu, arch.pv.event_callback_eip);
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -97,7 +97,7 @@ static void _show_registers(
     if ( context == CTXT_hypervisor )
         printk(" %pS", _p(regs->rip));
     printk("\nRFLAGS: %016lx   ", regs->rflags);
-    if ( (context == CTXT_pv_guest) && v && v->vcpu_info )
+    if ( (context == CTXT_pv_guest) && v && v->vcpu_info_area.map )
         printk("EM: %d   ", !!vcpu_info(v, evtchn_upcall_mask));
     printk("CONTEXT: %s", context_names[context]);
     if ( v && !is_idle_vcpu(v) )
--- a/xen/common/compat/domain.c
+++ b/xen/common/compat/domain.c
@@ -49,7 +49,7 @@ int compat_common_vcpu_op(int cmd, struc
     {
     case VCPUOP_initialise:
     {
-        if ( v->vcpu_info == &dummy_vcpu_info )
+        if ( v->vcpu_info_area.map == &dummy_vcpu_info )
             return -EINVAL;
 
 #ifdef CONFIG_HVM
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -127,10 +127,10 @@ static void vcpu_info_reset(struct vcpu
 {
     struct domain *d = v->domain;
 
-    v->vcpu_info = ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS)
-                    ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id])
-                    : &dummy_vcpu_info);
-    v->vcpu_info_mfn = INVALID_MFN;
+    v->vcpu_info_area.map =
+        ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS)
+         ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id])
+         : &dummy_vcpu_info);
 }
 
 static void vmtrace_free_buffer(struct vcpu *v)
@@ -951,7 +951,7 @@ int domain_kill(struct domain *d)
             return -ERESTART;
         for_each_vcpu ( d, v )
         {
-            unmap_vcpu_info(v);
+            unmap_guest_area(v, &v->vcpu_info_area);
             unmap_guest_area(v, &v->runstate_guest_area);
         }
         d->is_dying = DOMDYING_dead;
@@ -1406,7 +1406,7 @@ int domain_soft_reset(struct domain *d,
     for_each_vcpu ( d, v )
     {
         set_xen_guest_handle(runstate_guest(v), NULL);
-        unmap_vcpu_info(v);
+        unmap_guest_area(v, &v->vcpu_info_area);
         unmap_guest_area(v, &v->runstate_guest_area);
     }
 
@@ -1454,111 +1454,6 @@ int vcpu_reset(struct vcpu *v)
     return rc;
 }
 
-/*
- * Map a guest page in and point the vcpu_info pointer at it.  This
- * makes sure that the vcpu_info is always pointing at a valid piece
- * of memory, and it sets a pending event to make sure that a pending
- * event doesn't get missed.
- */
-int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned int offset)
-{
-    struct domain *d = v->domain;
-    void *mapping;
-    vcpu_info_t *new_info;
-    struct page_info *page;
-    unsigned int align;
-
-    if ( offset > (PAGE_SIZE - sizeof(*new_info)) )
-        return -ENXIO;
-
-#ifdef CONFIG_COMPAT
-    BUILD_BUG_ON(sizeof(*new_info) != sizeof(new_info->compat));
-    if ( has_32bit_shinfo(d) )
-        align = alignof(new_info->compat);
-    else
-#endif
-        align = alignof(*new_info);
-    if ( offset & (align - 1) )
-        return -ENXIO;
-
-    if ( !mfn_eq(v->vcpu_info_mfn, INVALID_MFN) )
-        return -EINVAL;
-
-    /* Run this command on yourself or on other offline VCPUS. */
-    if ( (v != current) && !(v->pause_flags & VPF_down) )
-        return -EINVAL;
-
-    page = get_page_from_gfn(d, gfn, NULL, P2M_UNSHARE);
-    if ( !page )
-        return -EINVAL;
-
-    if ( !get_page_type(page, PGT_writable_page) )
-    {
-        put_page(page);
-        return -EINVAL;
-    }
-
-    mapping = __map_domain_page_global(page);
-    if ( mapping == NULL )
-    {
-        put_page_and_type(page);
-        return -ENOMEM;
-    }
-
-    new_info = (vcpu_info_t *)(mapping + offset);
-
-    if ( v->vcpu_info == &dummy_vcpu_info )
-    {
-        memset(new_info, 0, sizeof(*new_info));
-#ifdef XEN_HAVE_PV_UPCALL_MASK
-        __vcpu_info(v, new_info, evtchn_upcall_mask) = 1;
-#endif
-    }
-    else
-    {
-        memcpy(new_info, v->vcpu_info, sizeof(*new_info));
-    }
-
-    v->vcpu_info = new_info;
-    v->vcpu_info_mfn = page_to_mfn(page);
-
-    /* Set new vcpu_info pointer /before/ setting pending flags. */
-    smp_wmb();
-
-    /*
-     * Mark everything as being pending just to make sure nothing gets
-     * lost.  The domain will get a spurious event, but it can cope.
-     */
-#ifdef CONFIG_COMPAT
-    if ( !has_32bit_shinfo(d) )
-        write_atomic(&new_info->native.evtchn_pending_sel, ~0);
-    else
-#endif
-        write_atomic(&vcpu_info(v, evtchn_pending_sel), ~0);
-    vcpu_mark_events_pending(v);
-
-    return 0;
-}
-
-/*
- * Unmap the vcpu info page if the guest decided to place it somewhere
- * else. This is used from domain_kill() and domain_soft_reset().
- */
-void unmap_vcpu_info(struct vcpu *v)
-{
-    mfn_t mfn = v->vcpu_info_mfn;
-
-    if ( mfn_eq(mfn, INVALID_MFN) )
-        return;
-
-    unmap_domain_page_global((void *)
-                             ((unsigned long)v->vcpu_info & PAGE_MASK));
-
-    vcpu_info_reset(v); /* NB: Clobbers v->vcpu_info_mfn */
-
-    put_page_and_type(mfn_to_page(mfn));
-}
-
 int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size,
                    struct guest_area *area,
                    void (*populate)(void *dst, struct vcpu *v))
@@ -1628,6 +1523,30 @@ int map_guest_area(struct vcpu *v, paddr
 
     domain_unlock(currd);
 
+    /* Set pending flags /after/ new vcpu_info pointer was set. */
+    if ( area == &v->vcpu_info_area )
+    {
+        /*
+         * Mark everything as being pending just to make sure nothing gets
+         * lost.  The domain will get a spurious event, but it can cope.
+         */
+#ifdef CONFIG_COMPAT
+        if ( !has_32bit_shinfo(currd) )
+        {
+            vcpu_info_t *info = area->map;
+
+            /* For VCPUOP_register_vcpu_info handling in common_vcpu_op(). */
+            BUILD_BUG_ON(sizeof(*info) != sizeof(info->compat));
+            write_atomic(&info->native.evtchn_pending_sel, ~0);
+        }
+        else
+#endif
+            write_atomic(&vcpu_info(v, evtchn_pending_sel), ~0);
+        vcpu_mark_events_pending(v);
+
+        force_update_vcpu_system_time(v);
+    }
+
     if ( v != current )
         vcpu_unpause(v);
 
@@ -1654,7 +1573,10 @@ void unmap_guest_area(struct vcpu *v, st
 
     domain_lock(d);
     map = area->map;
-    area->map = NULL;
+    if ( area == &v->vcpu_info_area )
+        vcpu_info_reset(v);
+    else
+        area->map = NULL;
     pg = area->pg;
     area->pg = NULL;
     domain_unlock(d);
@@ -1789,6 +1711,27 @@ bool update_runstate_area(struct vcpu *v
     return rc;
 }
 
+/*
+ * This makes sure that the vcpu_info is always pointing at a valid piece of
+ * memory, and it sets a pending event to make sure that a pending event
+ * doesn't get missed.
+ */
+static void cf_check
+vcpu_info_populate(void *map, struct vcpu *v)
+{
+    vcpu_info_t *info = map;
+
+    if ( v->vcpu_info_area.map == &dummy_vcpu_info )
+    {
+        memset(info, 0, sizeof(*info));
+#ifdef XEN_HAVE_PV_UPCALL_MASK
+        __vcpu_info(v, info, evtchn_upcall_mask) = 1;
+#endif
+    }
+    else
+        memcpy(info, v->vcpu_info_area.map, sizeof(*info));
+}
+
 static void cf_check
 runstate_area_populate(void *map, struct vcpu *v)
 {
@@ -1818,7 +1761,7 @@ long common_vcpu_op(int cmd, struct vcpu
     switch ( cmd )
     {
     case VCPUOP_initialise:
-        if ( v->vcpu_info == &dummy_vcpu_info )
+        if ( v->vcpu_info_area.map == &dummy_vcpu_info )
             return -EINVAL;
 
         rc = arch_initialise_vcpu(v, arg);
@@ -1942,16 +1885,30 @@ long common_vcpu_op(int cmd, struct vcpu
     case VCPUOP_register_vcpu_info:
     {
         struct vcpu_register_vcpu_info info;
+        paddr_t gaddr;
 
         rc = -EFAULT;
         if ( copy_from_guest(&info, arg, 1) )
             break;
 
-        domain_lock(d);
-        rc = map_vcpu_info(v, info.mfn, info.offset);
-        domain_unlock(d);
+        rc = -EINVAL;
+        gaddr = gfn_to_gaddr(_gfn(info.mfn)) + info.offset;
+        if ( !gaddr ||
+             gfn_x(gaddr_to_gfn(gaddr)) != info.mfn ||
+             /*
+              * Technically re-registration is okay, but it wasn't allowed
+              * originally.  By trying to win a race, a guest might be able
+              * to bypass this restriction.
+              */
+             v->vcpu_info_area.pg )
+            break;
 
-        force_update_vcpu_system_time(v);
+        /* See the BUILD_BUG_ON() in vcpu_info_populate(). */
+        rc = map_guest_area(v, gaddr, sizeof(vcpu_info_t),
+                            &v->vcpu_info_area, vcpu_info_populate);
+        if ( rc == -ERESTART )
+            rc = hypercall_create_continuation(__HYPERVISOR_vcpu_op, "iih",
+                                               cmd, vcpuid, arg);
 
         break;
     }
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -79,9 +79,6 @@ void cf_check free_pirq_struct(void *);
 int  arch_vcpu_create(struct vcpu *v);
 void arch_vcpu_destroy(struct vcpu *v);
 
-int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned int offset);
-void unmap_vcpu_info(struct vcpu *v);
-
 int map_guest_area(struct vcpu *v, paddr_t gaddr, unsigned int size,
                    struct guest_area *area,
                    void (*populate)(void *dst, struct vcpu *v));
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -175,7 +175,7 @@ struct vcpu
 
     int              processor;
 
-    vcpu_info_t     *vcpu_info;
+    struct guest_area vcpu_info_area;
 
     struct domain   *domain;
 
@@ -288,9 +288,6 @@ struct vcpu
 
     struct waitqueue_vcpu *waitqueue_vcpu;
 
-    /* Guest-specified relocation of vcpu_info. */
-    mfn_t            vcpu_info_mfn;
-
     struct evtchn_fifo_vcpu *evtchn_fifo;
 
     /* vPCI per-vCPU area, used to store data for long running operations. */
--- a/xen/include/xen/shared.h
+++ b/xen/include/xen/shared.h
@@ -44,6 +44,7 @@ typedef struct vcpu_info vcpu_info_t;
 extern vcpu_info_t dummy_vcpu_info;
 
 #define shared_info(d, field)      __shared_info(d, (d)->shared_info, field)
-#define vcpu_info(v, field)        __vcpu_info(v, (v)->vcpu_info, field)
+#define vcpu_info(v, field)        \
+        __vcpu_info(v, (vcpu_info_t *)(v)->vcpu_info_area.map, field)
 
 #endif /* __XEN_SHARED_H__ */



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:53:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:53:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425599.673525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3tC-0001IY-Po; Wed, 19 Oct 2022 07:53:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425599.673525; Wed, 19 Oct 2022 07:53:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3tC-0001IR-N6; Wed, 19 Oct 2022 07:53:22 +0000
Received: by outflank-mailman (input) for mailman id 425599;
 Wed, 19 Oct 2022 07:53:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GAs9=2U=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ol3tB-0001IL-Nl
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:53:22 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140089.outbound.protection.outlook.com [40.107.14.89])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18f19c70-4f83-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:53:20 +0200 (CEST)
Received: from DB7PR05CA0072.eurprd05.prod.outlook.com (2603:10a6:10:2e::49)
 by AM8PR08MB6514.eurprd08.prod.outlook.com (2603:10a6:20b:36b::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct
 2022 07:53:13 +0000
Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::3a) by DB7PR05CA0072.outlook.office365.com
 (2603:10a6:10:2e::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Wed, 19 Oct 2022 07:53:13 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 19 Oct 2022 07:53:13 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Wed, 19 Oct 2022 07:53:13 +0000
Received: from 965e70817973.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A429C01F-9FB7-4683-AA5C-201E611D03C0.1; 
 Wed, 19 Oct 2022 07:53:02 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 965e70817973.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 07:53:02 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PR3PR08MB5673.eurprd08.prod.outlook.com (2603:10a6:102:86::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 07:52:59 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:52:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18f19c70-4f83-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Ui2/BiiROAJ1XfpEj7orFj2Q9ygfUfLihGpb1izAfc1X9NArK65GJq7KIKXgd26AVn3qMdSlSrKwEA1B8m0gosnnkAbGLam9+2cdwNWEJo5TNgQI+iD0MI+G88cy3uW9VZf7pqtIo+a92Gh8Ilq76oAHNSVonUsi1BMIiHi0UnUlzANkbWngNkJMoZuXONK+uoCJHQAUdNSAWP9eprQjg/hT2F/lMrsCQlIvATOEXGlHGbHxtJeDIGpU2HPbPZ6WF4wXApcck7d9L5mPiBA/4ajCDNxqa912PJgX2tW2ZogOalu33MNC/PKfA0eVSuzm/Xa8Z9y7/U+2oUTkB1PEMQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7Zg7ZG6Wf7lkUiNk7DKWDDPlFday/yqNF7zo/Bwp0p8=;
 b=aZJt0qG1JMQVNXSKGXALOCLJlVys6P9ihEaKoD+i6rTAlJdHxcIgYNEZ17UA6m7RMlnPBLuAYs9h9pFRoBIeOMDd2kMWkHsUVg7V+zuH7GJuTmfLDEdXgNk+JVYKNZyylQE1JCywwM4fkAj+eaf66+e4EVWTFwcBde4UxalSB6W+VePPNHaZ7ZhKGXt8LTuThu/551BAJaZrWB5YsAgfUEzlkCzCZdaCth8Vzbs/CQ1hk/S6myNoeUg+oeIayoGAK5ZtzVMwKxxFW2SaUAARnI7kEfXqZbURTrlhfxBa6Vd0ncQ/chhC8reAXJlrKhtZcW0f4o1c6ubJoeBbkxcq9w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7Zg7ZG6Wf7lkUiNk7DKWDDPlFday/yqNF7zo/Bwp0p8=;
 b=QOCUiXQvSmUO8/5iopsT0BXUBE5JK8Ne03AQ1blXawWS+m2/nnPHdBDGO8T5gPQHmw+DPIXWGjqsnwTZDJReQrjLjUfw60SUym5muFWJWA/1zgq01rdETTTuhOwY7X4KE1AlxuI1TGLyi/HLOPSrwVIeSwH+EbE8vrXkEKORM4A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 543e1c6cec28e726
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LC5ZhMjjz+ZMsCPUqV32siZH3deBmO0dIDp4NiZYcNccLdGempFVTGiJ39gT2oNTZKLWSgY/w6evWBjI33LP8sCnWvGwdKxOBLVdH7Fx88LVtw8KwqfTK+n/xy8pwwXiTbhBzdb4C3f6Y7x9YxXi9o134WrfchwEh7Bk1OEgW0upxueSyApmDZIZFKoXaLaPxrTDP9JD3XhLcMNIJZQ/3IrCcGlDXVSPPXPr1RAlIdlkZkJqDlDGuCNH7Rrjjdx/a/2el4i5UEzU1+nOfugNctMeJNMKBCMo2Rp1xbBHKJFgOk/7Rpd3UsD3oXHyneEYqicFkvK+0JNy74Mzzq2xRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7Zg7ZG6Wf7lkUiNk7DKWDDPlFday/yqNF7zo/Bwp0p8=;
 b=DmTrloEK1etz6Y5elOchM6Kg/i2RUrC3l9qk7u8AC4CnIZw2at97yFi2ps4RuY3zH0SNRmZyVhZm4nbj7AmcUDUNpZyYpgkO+QwMiZEJwAFJ0Eo4TYj5D/mzNnaqYFZOBk2FAiLmAv0Iu19IskHhgm/NFFRcoN+0y1rqnn8Qxa9LRDr+WIikypVzRVhN1GU7jzrlmwMbeT69wXhO2zCZqT6oNFbE+TywXCkczV/lMeFNAg4fUJQyOYkuyyVR7FtOF2T0oYN4AM3QRQJmkIZrebVCUlPGSJYH8ruaZ9XFKDCT0FW5LNU8f5pzDQko6FX4DQJsP7hDvGeqlWCrA4Tjsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7Zg7ZG6Wf7lkUiNk7DKWDDPlFday/yqNF7zo/Bwp0p8=;
 b=QOCUiXQvSmUO8/5iopsT0BXUBE5JK8Ne03AQ1blXawWS+m2/nnPHdBDGO8T5gPQHmw+DPIXWGjqsnwTZDJReQrjLjUfw60SUym5muFWJWA/1zgq01rdETTTuhOwY7X4KE1AlxuI1TGLyi/HLOPSrwVIeSwH+EbE8vrXkEKORM4A=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Luca Fancellu <Luca.Fancellu@arm.com>, Wei Chen <Wei.Chen@arm.com>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index:
 AQHY3lPHM2Tyba3hCkeKMW07GDOb2a4L9DeAgAAnewCAABdGAIAIGdUAgAADdICAAAu3gIAA8h6AgAAU34A=
Date: Wed, 19 Oct 2022 07:52:59 +0000
Message-ID: <A3CC086E-7B11-4D6A-BF01-565BB8C3A846@arm.com>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
 <A906FDB6-7DA5-4900-A6DE-1140231E69AE@arm.com>
 <9b113db9-4dce-d300-9393-a8572ee4fdcd@suse.com>
In-Reply-To: <9b113db9-4dce-d300-9393-a8572ee4fdcd@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PR3PR08MB5673:EE_|DBAEUR03FT013:EE_|AM8PR08MB6514:EE_
X-MS-Office365-Filtering-Correlation-Id: 7c5c6106-1fb0-4f33-3a6e-08dab1a6f986
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sVlzXgZ3SdhQlFoo2mTUIEzT1RPVpkiUv4NoFNpPMy6Cca2LDE8REsBUIJFvgXMCkxD2j2UFI+lS6j+OyxHxxdSCFJLpXOa2GMPxTBo0EZyqvdtP8y4KDJ5BtLS4EJ1/RLV9yuCcG33+exAAXkRa2+nYjP9BRkIGStdg0b1XE4HV+rih/qQvovGT9yzyzxGBZZukuf2Y4Gt7x4iVuXL0EGFVklwEmAPAytBCo+KnKhBmVZg7U2t7m0ptGP6sXoEfQH7jqw21OvFNHL7JWwd6J8qyv2CgNIvasnBOTv7sx6vT3keZylCKpHcFzH5Gug44FnbJ2LKN42KB9x/cNaQP1883GRuLRn6gvSRvdS9IGuD/w1MUYza+EGdYT3OHvuLnXSnqANSoefvLF4xGWiCnQvsy0Dnjok0cbPOyoFj2h31KlwFU6KvNeJOMCtgTedAFATdGwb+C9FVX7//R1pkvYUF7VVZjIS06NxgRKRAEwWUNnPHW7e7iUKPFAo9J+H7vNHP32C1RjCM54Uzvj3O+YViqgi6msvZSDzm4LPWTSebBxpBrm623xrnBqgaUMMS6K7GOTPum7QeTYxl1RYDxnySKQJAViNsBhb8kiAjC3XHAzrTmpbwqHLycflrCfVqzOrW43XkvI7727waKYBuKbVz7PP70rPSH8IKEboE0Bui0LSirFmqa0eMR+31RlgJT3mie9ZilkHmb97kellP7j15AO6U0GTsnub54I9aGZ6x95to6LO9UWpdqeXdFfqfPnfHdTN8ZHk97Isdfr4wQgn9zc963LtFNc/JHfuxNXf0=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199015)(6916009)(54906003)(4326008)(66556008)(8676002)(64756008)(66946007)(66476007)(66446008)(86362001)(83380400001)(41300700001)(53546011)(36756003)(6512007)(6506007)(26005)(5660300002)(316002)(91956017)(8936002)(76116006)(38100700002)(6486002)(2616005)(33656002)(71200400001)(2906002)(186003)(122000001)(478600001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <68288A746D6FA34E916239D26D5389FF@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5673
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9967d6ef-0906-438f-8a76-08dab1a6f10b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v1Al8e8zNMZ25NqcaplSrJ/cAvJdq7LR/Xwx7iaP8iAuaTLPriP/1pL90s+1mkyWA12Ye3vShREdTWvwjI1FivseTKDDLDUUHJh/zEgs3voTMu4DXd3j4AHGCSk2KDas57Ag6WnCgPiT+IGyRYvZ61Dp2iNjnAu/ueHLt2+K4biDo6yj4usVnFigP/KBby+g04Q6KTVQp3hCcgSiXVEsCZ/EQk87H1OsFdvpueHO1QBUOilovNW3PkcZA9vwY8MM4aY9lpkBH3wMJ6HqVSEHNdaVwNxVak84cETBsCKXvaOThHMs3hXRMryAK5ttLlBXe4t9p/huptdcHfIUL09Kg2D1/td0fR1tZOTbWs/Xx8o0AM8Ww0Eg7AmdyLpHPBtJCesXeukK6ADvBu+ssfVm7Vdsh+M6zZ/hwR4MulyZ1TQ3Tbcgq90heP0jE/yWV2LvkFnUC9eZ9n+BRc1V6D5+Tn9buC0KvrwNAc9uIDDTuXlFYvhiI7Nx1+SP7mNHAZOqKzmpxRHI12t5ANYkfhcMpi+8W1PY8lmF2PcJgc8ZEs3Yc6ZgpDy2Y5nP6F00rsQZft7YaR+cI3YsDittnVBnjoO4Bcu9VQ8//cw1JkPCLHT9e78TwS8A0Xbyt7feH8l9cR/+MxtRyDf3WbYQcQP9uNOjXAduCd/viIOrPU9dugT1hfKEw39tcfNrBnotTC+n3VGXSpbciit++RDBoG7uU+68uo2VY0XNhCYFwnK64nKCj1v8A0X+YZrAdp3LfQV74ruJjGLdpcybXgp7pWaekQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(186003)(47076005)(336012)(36860700001)(2906002)(2616005)(6506007)(82310400005)(54906003)(26005)(5660300002)(53546011)(316002)(6512007)(86362001)(41300700001)(82740400003)(8676002)(70586007)(33656002)(70206006)(83380400001)(81166007)(8936002)(4326008)(356005)(6862004)(40460700003)(40480700001)(478600001)(36756003)(6486002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:53:13.5357
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c5c6106-1fb0-4f33-3a6e-08dab1a6f986
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6514

SGkgSmFuLA0KDQo+IE9uIDE5IE9jdCAyMDIyLCBhdCAwNzozOCwgSmFuIEJldWxpY2ggPGpiZXVs
aWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDE4LjEwLjIwMjIgMTg6MTEsIEJlcnRyYW5k
IE1hcnF1aXMgd3JvdGU6DQo+Pj4gT24gMTggT2N0IDIwMjIsIGF0IDE2OjI5LCBKYW4gQmV1bGlj
aCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDE4LjEwLjIwMjIgMTc6MTcsIEx1
Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+PiBPbiAxMyBPY3QgMjAyMiwgYXQgMTI6MzQsIEphbiBC
ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4+PiBPbiAxMy4xMC4yMDIyIDEy
OjExLCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+Pj4+PiBPbiAxMyBPY3QgMjAyMiwgYXQgMDg6
NTAsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4+Pj4+IE9uIDEy
LjEwLjIwMjIgMTg6MDAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+Pj4+PiBFbnRyaWVzIGlu
IHRoZSBkYXRhYmFzZSBzaG91bGQgbmV2ZXIgYmUgcmVtb3ZlZCwgZXZlbiBpZiB0aGV5IGFyZSBu
b3QgdXNlZA0KPj4+Pj4+Pj4gYW55bW9yZSBpbiB0aGUgY29kZSAoaWYgYSBwYXRjaCBpcyByZW1v
dmluZyBvciBtb2RpZnlpbmcgdGhlIGZhdWx0eSBsaW5lKS4NCj4+Pj4+Pj4+IFRoaXMgaXMgdG8g
bWFrZSBzdXJlIHRoYXQgbnVtYmVycyBhcmUgbm90IHJldXNlZCB3aGljaCBjb3VsZCBsZWFkIHRv
IGNvbmZsaWN0cw0KPj4+Pj4+Pj4gd2l0aCBvbGQgYnJhbmNoZXMgb3IgbWlzbGVhZGluZyBqdXN0
aWZpY2F0aW9ucy4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IENhbiB3ZSBhZGQgcHJvdmlzaW9ucyBmb3Ig
c2hyaW5raW5nIHN1Y2ggZW50cmllcyB0byBlLmcuIGp1c3QgdGhlaXIgImlkIg0KPj4+Pj4+PiBs
aW5lPyBPciBpcyB0aGUgaW50ZW50aW9uIHRvIGJlIGFibGUgdG8gcmUtdXNlIHN1Y2ggYW4gZW50
cnkgaWYgYSBtYXRjaGluZw0KPj4+Pj4+PiBpbnN0YW5jZSBhcHBlYXJzIGFnYWluIGxhdGVyPw0K
Pj4+Pj4+IA0KPj4+Pj4+IEkgcHJlZmVyIHRvIGRvbuKAmXQgc2hyaW5rIGl0LCB0aGUgbmFtZSBp
dHNlbGYgaXMgbm90IHZlcnkgbG9uZywgZXZlbiB1c2luZyBtYW55IGRpZ2l0cyBvZiB0aGUgaW5j
cmVtZW50YWwNCj4+Pj4+PiBudW1iZXIsIGl0IHJlbW92ZXMgYWxzbyB0aGUgZGVwZW5kZW5jeSBv
biB0aGUgZmlsZSBuYW1lLg0KPj4+Pj4gDQo+Pj4+PiBOYW1lIGxlbmd0aCBpc24ndCByZWxldmFu
dCBoZXJlLCBhbmQgSSBoYXZlIG5vIGlkZWEgd2hhdCBkZXBlbmRlbmN5IG9uIGENCj4+Pj4+IGZp
bGUgbmFtZSB5b3UncmUgdGhpbmtpbmcgb2YuIE15IHF1ZXN0aW9uIGlzIGEgc2NhbGFiaWxpdHkg
b25lOiBPdmVyIHRpbWUNCj4+Pj4+IHRoZSB0YWJsZSB3aWxsIGdyb3cgbGFyZ2UuIElmIGFsbCBl
bnRyaWVzIHJlbWFpbiB0aGVyZSBpbiBmdWxsIGZvcmV2ZXIsDQo+Pj4+PiB0YWJsZSBzaXplIG1h
eSBiZWNvbWUgdW53aWVsZHkuDQo+Pj4+IA0KPj4+PiBPayBJIG1pc3VuZGVyc3Rvb2QgeW91ciBx
dWVzdGlvbiwgbm93IEkgdW5kZXJzdGFuZCB3aGF0IHlvdSBhcmUgYXNraW5nLCB3ZSBjb3VsZCBy
ZW1vdmUgdGhlIGNvbnRlbnQNCj4+Pj4gb2YgdGhlIOKAnGFuYWx5c2Vy4oCdIGRpY3Rpb25hcnkg
Zm9yIHN1cmUsIGJlY2F1c2UgaWYgdGhlcmUgaXMgbm90IGFueW1vcmUgYSBsaW5rIHdpdGggdGhl
IGN1cnJlbnQgY29kZS4NCj4+Pj4gDQo+Pj4+IFJlZ2FyZGluZyByZW1vdmluZyB0aGUg4oCcbmFt
ZeKAnSBhbmQg4oCcdGV4dOKAnSwgY291bGQgaXQgYmUgdGhhdCBhdCBzb21lIHBvaW50IHdlIGNh
biBpbnRyb2R1Y2UgaW4gdGhlIGNvZGUNCj4+Pj4gYSB2aW9sYXRpb24gdGhhdCByZXF1aXJlcyB0
aGUgc2FtZSBqdXN0aWZpY2F0aW9uIHByb3ZpZGVkIGJ5IHRoZSDigJxvcnBoYW7igJ0gZW50cnk/
DQo+Pj4+IEluIHRoYXQgY2FzZSB3ZSBjb3VsZCByZXVzZSB0aGF0IGVudHJ5IHdpdGhvdXQgY3Jl
YXRpbmcgYSBuZXcgb25lIHRoYXQgd2lsbCBvbmx5IHdhc3RlIHNwYWNlLg0KPj4+PiBXaGF0IGlz
IHRoZSBvcGluaW9uIG9uIHRoaXM/DQo+Pj4gDQo+Pj4gV2VsbCwgeWVzLCB0aGlzIGlzIHRoZSBv
bmUgY2FzZSB0aGF0IEksIHRvbywgd2FzIHdvbmRlcmluZyBhYm91dC4gSXQncyBub3QNCj4+PiBj
bGVhciB0byBtZSB3aGV0aGVyIGl0IHdvdWxkbid0IGJlIGJldHRlciB0byBhbGxvY2F0ZSBhIGZy
ZXNoIElEIGluIHN1Y2ggYQ0KPj4+IGNhc2UuDQo+PiANCj4+IEZvciB0cmFjZWFiaWxpdHkgYW5k
IHJlbGVhc2UgaGFuZGxpbmcgSSB0aGluayBpdCBpcyBpbXBvcnRhbnQgdGhhdDoNCj4+IC0gd2Ug
bmV2ZXIgcmV1c2UgdGhlIHNhbWUgSUQgaW4gYW55IGNhc2UNCj4+IC0gd2Uga2VlcCBJRHMgaW4g
dGhlIGRhdGFiYXNlIGV2ZW4gaWYgdGhlcmUgaXMgbm8gb2NjdXJyZW5jZSBpbiB4ZW4gY29kZSBh
cyB0aGlzIHdpbGwgcHJldmVudCBhZGRpbmcgYSBuZXcgSUQgaWYgYW4gZXhpc3Rpbmcgb25lIGNh
biBiZSByZXVzZWQNCj4+IA0KPj4gSW4gYSBjZXJ0aWZpY2F0aW9uIGNvbnRleHQsIHdoZW4gYSBq
dXN0aWZpY2F0aW9uIGhhcyBiZWVuIHZhbGlkYXRlZCBhbmQgYWdyZWVkIGl0IHdpbGwgbWFrZSBs
aWZlIGEgbG90IGVhc2llciB0byBub3QgbW9kaWZ5IGl0IGFuZCByZXVzZSBpdCBpbiB0aGUgZnV0
dXJlIGlmIGl0IGlzIG5lZWRlZC4NCj4+IEZyb20gb3VyIHBvaW50IG9mIHZpZXcsIGhhdmluZyBh
IGNsZWFyIGFuZCBzaW1wbGUgd2F5IG9mIGhhbmRsaW5nIHRob3NlIHdpbGwgbWFrZSBiYWNrcG9y
dHMgYSBsb3QgZWFzaWVyLg0KPiANCj4gSXNuJ3QgdmFsaWRhdGlvbiBvZiBhIGp1c3RpZmljYXRp
b24gY29ubmVjdGVkIHRvIHRoZSBhZmZlY3RlZCBjb2RlPyBJZiBzbywNCj4gZXZlcnkgbmV3IGlu
c3RhbmNlIHdpbGwgbmVlZCB2YWxpZGF0aW9uLCB3aGlsZSBhbiBvcnBoYW4gZW50cnkgaXMgZW50
aXJlbHkNCj4gbWVhbmluZ2xlc3MuDQoNCkhvcGVmdWxseSBtb3N0IG91ciBqdXN0aWZpY2F0aW9u
cyBzaG91bGQgYmUgZm9yIHNvbWUg4oCcY29tbW9u4oCdIGRldmlhdGlvbnMNCndlIGFsbG93IGFu
ZCBhcyBhIGNvbnNlcXVlbmNlIGJlIHJldXNlZCBzZXZlcmFsIHRpbWVzLg0KQW4gb3JwaGFuIG1p
Z2h0IGJlIG1lYW5pbmdsZXNzIGJ1dCBjb3VsZCBzdGlsbCBoYXZlIGEgbWVhbmluZyBpbiBhIHN0
YWJsZQ0KYnJhbmNoLCB0YWtpbmcgdGhvc2Ugb3V0IG1pZ2h0IG1ha2UgdGhlIHdvcmsgb2YgcGVv
cGxlIGRvaW5nIGNlcnRpZmljYXRpb24NCm1vcmUgY29tcGxleC4NCkFueXdheSBJIHRoaW5rIHRo
aXMgaXMgYSBjb3JuZXIgY2FzZSB0aGF0IHdlIGNvdWxkIHJlY29uc2lkZXIgZGVwZW5kaW5nIG9u
DQpob3cgb2Z0ZW4gaXQgaXMgaGFwcGVuaW5nIGJ1dCBmb3IgYSBzdGFydCBpdCB3b3VsZCBtYWtl
IGxpZmUgZWFzaWVyIHRvIG5vdCByZW1vdmUNCnNvIHRoYXQgbnVtYmVycyBhcmUgbm90IHJldXNl
ZC4NCg0KPiANCj4+Pj4+PiBBZnRlciB0aGUgYW5hbHlzaXMsIHRoZSBzb3VyY2UgY29kZSB3aWxs
IHJldHVybiBhcyB0aGUgb3JpZ2luYWwgKHdpdGggdGhlIFNBRi0qIHRhZykuDQo+Pj4+PiANCj4+
Pj4+IFdoaWxlIHlvdSBtZW50aW9uIHNvbWV0aGluZyBzaW1pbGFyIGFsc28gYXMgc3RlcCAzIGlu
IHRoZSBvcmlnaW5hbCBkb2N1bWVudA0KPj4+Pj4gbmVhciB0aGUgdG9wLCBJJ20gYWZyYWlkIEkg
ZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IHRoaXMgInJldHVybiBhcyB0aGUgb3JpZ2luYWwiDQo+Pj4+
PiBtZWFucy4gSWYgeW91IHdhbnQgdG8gcnVuIHRoZSB0b29sIG9uIGFuIGFsdGVyZWQgKGNvbW1l
bnRzIG1vZGlmaWVkKSBzb3VyY2UNCj4+Pj4+IHRyZWUsIHdoYXQgSSdkIGV4cGVjdCB5b3UgdG8g
ZG8gaXMgY2xvbmUgdGhlIHNvdXJjZXMgaW50byBhIHRocm93LWF3YXkgdHJlZSwNCj4+Pj4+IG1h
c3NhZ2UgdGhlIGNvbW1lbnRzLCBydW4gdGhlIHRvb2wsIGFuZCBkZWxldGUgdGhlIG1hc3NhZ2Vk
IHRyZWUuDQo+Pj4+Pj4+PiBpZiB0aGUgb2JqZWN0IGRvZXNuJ3QgaGF2ZSBhIGtleS12YWx1ZSwg
dGhlbiB0aGUgY29ycmVzcG9uZGluZyBpbi1jb2RlDQo+Pj4+Pj4+PiBjb21tZW50IHdvbid0IGJl
IHRyYW5zbGF0ZWQuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBJaXJjIGF0IGxlYXN0IENvdmVyaXR5IGln
bm9yZXMgY2VydGFpbiBpbnN0YW5jZXMgb2Ygd2hhdCBpdCBtaWdodCBjb25zaWRlcg0KPj4+Pj4+
PiB2aW9sYXRpb25zIChmYWxsLXRocm91Z2ggaW4gc3dpdGNoKCkgc3RhdGVtZW50cyBpbiBwYXJ0
aWN1bGFyKSBpbiBjYXNlDQo+Pj4+Pj4+IF9hbnlfIGNvbW1lbnQgaXMgcHJlc2VudC4gVGhlcmVm
b3JlIG1heSBJIHN1Z2dlc3QgdGhhdCBzdWNoIGNvbW1lbnRzIGJlDQo+Pj4+Pj4+IGRlbGV0ZWQg
KHJlYWxseTogcmVwbGFjZWQgYnkgYSBibGFuayBsaW5lLCB0byBtYWludGFpbiBjb3JyZWN0IGxp
bmUNCj4+Pj4+Pj4gbnVtYmVyaW5nKSBpZiB0aGVyZSdzIG5vIG1hdGNoaW5nIGtleS12YWx1ZSBw
YWlyPw0KPj4+Pj4+IA0KPj4+Pj4+IFllcyB0aGUgbGluZSB3b27igJl0IGJlIGFsdGVyZWQgaWYg
dGhlcmUgaXMgbm8gbWF0Y2guIFRoaXMgdG8gZW5zdXJlIHRoZSBjb3JyZWN0IGxpbmUNCj4+Pj4+
PiBudW1iZXJpbmcgaXMgbm90IGFmZmVjdGVkLg0KPj4+Pj4gDQo+Pj4+PiAid29uJ3QgYmUgYWx0
ZXJlZCIgaXMgdGhlIG9wcG9zaXRlIG9mIHdoYXQgSSd2ZSBiZWVuIGFza2luZyB0byBjb25zaWRl
cjoNCj4+Pj4+IE9ic2VydmluZyB0aGF0IGNvbW1lbnRzIF9yZWdhcmRsZXNzXyBvZiB0aGVpciBj
b250ZW50cyBtYXkgc2lsZW5jZSBmaW5kaW5ncywNCj4+Pj4+IHRoZSBzdWdnZXN0aW9uIGlzIHRv
IHJlbW92ZSBjb21tZW50cyAobGVhdmluZyBhIGJsYW5rIGxpbmUpIHdoZW4gdGhlcmUncyBubw0K
Pj4+Pj4gZW50cnkgZm9yIHRoZSB0YXJnZXRlZCB0b29sIGluIHRoZSB0YWJsZSBlbnRyeS4NCj4+
Pj4gDQo+Pj4+IFdoeT8gVGhlIHRhZyBjb21tZW50IHdvbuKAmXQgZG8gYW55dGhpbmcsIGl0IHdv
dWxkIGFjdCBhcyBhIGJsYW5rIGxpbmUgZnJvbSB0aGUgYW5hbHlzZXINCj4+Pj4gcGVyc3BlY3Rp
dmUuDQo+Pj4gDQo+Pj4gVGhlIF90YWdfIHdvbid0IGRvIGFueXRoaW5nLCBidXQgYXMgc2FpZCBh
bnkgX2NvbW1lbnRfIG1heSBoYXZlIGFuIGVmZmVjdC4NCj4+IA0KPj4gSSBhbSBub3Qgc3VyZSBJ
IGZvbGxvdyB0aGlzIG9uZSBidXQgaW4gYW55IGNhc2Ugd2UgY2FuIGNob29zZSB0byBhbnl3YXkg
c3Vic3RpdHV0ZSB0aGUgdGFnIHdpdGggc29tZXRoaW5nIGxpa2UgLyogTm90IGFwcGxpY2FibGUg
Ki8uDQo+IA0KPiBUaGF0J3Mgc3RpbGwgYSBjb21tZW50LCB3aGljaCBoZW5jZSBtYXkgc3RpbGwg
c2lsZW5jZSBhIHRvb2w6DQo+IA0KPiAgICBzd2l0Y2ggKCB4ICkNCj4gICAgew0KPiAgICBjYXNl
IGE6DQo+ICAgICAgICAuLi4NCj4gICAgICAgIC8qIFNBRi08Tj4tc2FmZSAqLw0KPiAgICBjYXNl
IGI6DQo+ICAgICAgICAuLi4NCj4gICAgICAgIGJyZWFrOw0KPiAgICB9DQo+IA0KPiBpcyBubyBk
aWZmZXJlbnQgZnJvbQ0KPiANCj4gICAgc3dpdGNoICggeCApDQo+ICAgIHsNCj4gICAgY2FzZSBh
Og0KPiAgICAgICAgLi4uDQo+ICAgICAgICAvKiBmYWxsLXRocm91Z2ggKi8NCj4gICAgY2FzZSBi
Og0KPiAgICAgICAgLi4uDQo+ICAgICAgICBicmVhazsNCj4gICAgfQ0KPiANCj4gbm9yDQo+IA0K
PiAgICBzd2l0Y2ggKCB4ICkNCj4gICAgew0KPiAgICBjYXNlIGE6DQo+ICAgICAgICAuLi4NCj4g
ICAgICAgIC8qIE5vdCBhcHBsaWNhYmxlICovDQo+ICAgIGNhc2UgYjoNCj4gICAgICAgIC4uLg0K
PiAgICAgICAgYnJlYWs7DQo+ICAgIH0NCj4gDQo+IE9ubHkNCj4gDQo+ICAgIHN3aXRjaCAoIHgg
KQ0KPiAgICB7DQo+ICAgIGNhc2UgYToNCj4gICAgICAgIC4uLg0KPiANCj4gICAgY2FzZSBiOg0K
PiAgICAgICAgLi4uDQo+ICAgICAgICBicmVhazsNCj4gICAgfQ0KPiANCj4gd2lsbCBtYWtlIGUu
Zy4gQ292ZXJpdHkgYWN0dWFsbHkgcG9pbnQgb3V0IHRoZSBwb3RlbnRpYWxseSB1bmludGVuZGVk
DQo+IGZhbGwgdGhyb3VnaCAoYmFzZWQgb24gcGFzdCBvYnNlcnZhdGlvbnMpLiBXaGV0aGVyIHRo
YXQgYmVoYXZpb3IgaXMNCj4gZmFsbC10aHJvdWdoLXNwZWNpZmljIEkgZG9uJ3Qga25vdy4gSWYg
aXQgaW5kZWVkIGlzLCB0aGVuIG1heWJlIG15DQo+IGNvbmNlcm4gaXMgdm9pZCAtIGluIHRoZSBs
b25nIHJ1biBJIHRoaW5rIHdlIHdhbnQgdG8gdXNlIHRoZSBwc2V1ZG8tDQo+IGtleXdvcmQgdGhl
cmUgaW4gYWxsIGNhc2VzIGFueXdheS4NCg0KV2UgY2FuIGNob29zZSB0aGUgcmVwbGFjZW1lbnQg
Y29tbWVudCB0byBiZSBzb21ldGhpbmcgbm90DQpjb25zaWRlcmVkIGJ5IHRoZSB0b29scyAob3Ig
ZXZlbiBwdXQgYW4gZW1wdHkgLyogKi8pLg0KV2hhdCB3ZSBjYW5ub3QgZG8gaXMgcmVtb3ZlIHRo
ZSBsaW5lIGFzIGl0IHdvdWxkIGNoYW5nZSBsaW5lIG51bWJlcnMuDQpCdXQgYXBhcnQgZnJvbSBm
YWxsdGhyb3VnaCBJIGRvIG5vdCB0aGluayBhbnkgY29tbWVudCBpcyBjb25zaWRlcmVkIGJ5DQph
bnkgdG9vbHMgc28gdGhpcyBzaG91bGQgbm90IGJlIGFuIGlzc3VlLg0KDQpCZXJ0cmFuZA0KDQo+
IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 07:53:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 07:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425603.673535 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3tl-0001mP-28; Wed, 19 Oct 2022 07:53:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425603.673535; Wed, 19 Oct 2022 07:53:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3tk-0001mI-VV; Wed, 19 Oct 2022 07:53:56 +0000
Received: by outflank-mailman (input) for mailman id 425603;
 Wed, 19 Oct 2022 07:53:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Lsc4=2U=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ol3tk-0001IL-4d
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 07:53:56 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2073.outbound.protection.outlook.com [40.107.103.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2dcfb18e-4f83-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 09:53:55 +0200 (CEST)
Received: from ZR0P278CA0099.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::14)
 by DU0PR08MB7566.eurprd08.prod.outlook.com (2603:10a6:10:31e::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 07:53:48 +0000
Received: from VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:910:23:cafe::57) by ZR0P278CA0099.outlook.office365.com
 (2603:10a6:910:23::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 07:53:48 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT016.mail.protection.outlook.com (100.127.144.158) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 19 Oct 2022 07:53:47 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Wed, 19 Oct 2022 07:53:46 +0000
Received: from cd2c502f2146.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C21989AF-1E69-45E6-91B9-A931EFF106D6.1; 
 Wed, 19 Oct 2022 07:53:35 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd2c502f2146.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 07:53:35 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by AS8PR08MB5927.eurprd08.prod.outlook.com (2603:10a6:20b:292::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Wed, 19 Oct
 2022 07:53:26 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 07:53:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dcfb18e-4f83-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=jMtVabdl+3ZEx3LCGQtTcgIKGH8PcwWRP/+SoyyrhTshjCIJNJY0c2X9SuVqvGnJ/YPJAEQoqLya5w6GPPOrGLjeedJbqMtX4IZbfa+jpifaN/SRV01Kq3z3aFVzyipKskoj222xBNMaDFIzaulzpIZMJ2y4JHbi0k5Guvwl+26jCJELfYSanQpIZ9/E3fzg+QhWT//mDvAlKnDkTZXec1E7C8cf4lpegM8sTpYOIYddAtpzKhFzKIQF+6HpPxnxT8oGa9BoWm8wlTsh1VSzbnXNNgbfcA8sD9ec0A0VbctW5J9TR6pyR6VnSDUwLk84LN/q0Gbhu76PhqaUkadFoA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uoue+sftUPG41DLR3UGsHkPb59JJLDks6XMlrJljExk=;
 b=IhIUPsStIhFfXMK7WkHDKZ1ZAM2Gw+3EVvPEI0XstJtGYimeBwyD4iDiUfgRrzMeYC3UxiteNKucDtjpn7iZK9pS8MyNVsrpwfpNCstllRc1OHxOMXSFaQ79uyE/j7Ba0DtR9n0Qf8DIb5C9moXNp1CNv9TCRL4AAUilQiTLlFhTSyxPQBJ7mr6TwcqVwgO0Dow0Wu+MZkF4gs/PmgLKrWa75gSA01PgjzQ39M5eu7NiXdfljK4uf6pGWH2X+y0EBK0h2xzwwivd0tCzkRLtFFxqbXRNeENy52DTP3SeWnOQ+ceS5oEs2XTKqqoMYStJagsnvb2sRVrrSRq/+hS3YQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uoue+sftUPG41DLR3UGsHkPb59JJLDks6XMlrJljExk=;
 b=XbL48FxHBNVbDRmN+GRO79KWh+QBVIp+lNQcHNdjzt1rsUOx1RtD97WeL7wczxlBanqmQKn2/jyOhSaelKWhQXJxtn5Q1U+ZOFGTsHGvI4Y9l2a277LavZQukV9shnbd4xLVvjL7oTw7GhFn+Mp8gtx6o3SMrJIt727kT91eoaU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 97f69dac5f32b2f3
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WgNNek7baVS1CZdpN1oYupLxPtGdXjGDN1m/Xx7BhN7gmna7SB+rhnOJF2wfZyVdv4aZBB+aNgnWQuYXoFIWwdqRg5xg3lquBo5uxGI36OcOtZHvr2TFMi0RcZBMHLgkqth301cS+RCbTVIv/Q9+qYC4yd8KH61embNrWKwKF9hLVMuPKcqr7Y1uuFxRoBpIBk5xgiWSd4nnu0y1eFohWwQOzT8TT639IsGVmTc7aPnMJd18q8doooDxTUNS1mREUBaBUFY0cd9iZUbCacN8JNxDo7OzNjoAwiXy/YGwxahbCYnCYZCufbUFiq+mI9At6zxX6ega/XDjJsCwjgCsYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uoue+sftUPG41DLR3UGsHkPb59JJLDks6XMlrJljExk=;
 b=i3k73I3yZXRPXnaEF07jXuxQxE0iGrhtQ5vhWxrTNERL8ZdNpYK2L15ITrNeIhaumB4SCM8lmX5PF92ieKYtzgs0i1e2Bz4oMnco6q9zzMLdXyhIpVHM7AqZE5Uj+i+QpwvAd3vTm4D0QDFatNWzkRLEnEgB2eSq99foUTsWLodhjbRhiV85SyWW83Z344iDw+d8KcFViXfQoEM9nLEwOe8GDrNYnVBfhDsVtVMBcb/yXjCeZIqAraXkR4kkYs6n4b2CF7w+a2vf7auOtX3RAKHi5nnyQNF7At0vZg3QCVNYDyXFjb2fMaFlUkiJzxBAbeIW2PrCNTL4LDRfXmHMbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uoue+sftUPG41DLR3UGsHkPb59JJLDks6XMlrJljExk=;
 b=XbL48FxHBNVbDRmN+GRO79KWh+QBVIp+lNQcHNdjzt1rsUOx1RtD97WeL7wczxlBanqmQKn2/jyOhSaelKWhQXJxtn5Q1U+ZOFGTsHGvI4Y9l2a277LavZQukV9shnbd4xLVvjL7oTw7GhFn+Mp8gtx6o3SMrJIt727kT91eoaU=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Proposal for deviations in static analyser findings
Thread-Topic: Proposal for deviations in static analyser findings
Thread-Index:
 AQHY3lPHTZwvWtdyCU+0K6Hw9nMyM64L9DeAgAAneoCAABdHAIAIGdUAgAADdICAAAu3gIAA8h6AgAAU+4A=
Date: Wed, 19 Oct 2022 07:53:25 +0000
Message-ID: <5A5A9588-A6A3-4F46-8498-A5382C6144F0@arm.com>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
 <A906FDB6-7DA5-4900-A6DE-1140231E69AE@arm.com>
 <9b113db9-4dce-d300-9393-a8572ee4fdcd@suse.com>
In-Reply-To: <9b113db9-4dce-d300-9393-a8572ee4fdcd@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|AS8PR08MB5927:EE_|VI1EUR03FT016:EE_|DU0PR08MB7566:EE_
X-MS-Office365-Filtering-Correlation-Id: 25ee0009-3666-4ffa-0006-08dab1a70df2
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XFF4MBwN7cfc0SS72VRdlLYnqSimRW/wM4UojCPJvfCp+J6gCatVz03IP11lBgtedWiOvuCnB3Mu3Z7nviRAoeOCx6zqFWPJcRys9ZUFtmSDPWONLBSNzVFygyoB7Yag9+qqshEOZJF3IOZEJGW/HNKRQZYC7IOrCSXZaH3Re0xPWHr6qV0Z8ptG+qchSydJDPVotvj0nYgUwmFuwnnXJmOTgb4rQUuBOUCiM1WrfU2uk+8sNfKSbMF3uynAF8sK1Ffmj4NxId69xamhOB35f/mXCiZwyY0RHhznuFcv0XzylIdTWrtgZd4r92Oj8alZO0fwccW3vwCgQZ6ZCR+4K0On1sqBVpRq+4bm8dBbSFgZ83vCV4pSc5NShGBnVTR8Wf+zr6Z4MGi+mRGb9+PLvj1fkC7Z+MfCX0E37h5IeROSK/ZOZMChnl8v37gohqlqRJQpXnI5/4MagWbBq1WD2g1LzkC/1kS7/ku5A5lVpNgbJX9Hm+cpcR0eGHGZCdKKwlCzr9fomlQ5v1MEAJ4HLurnaP86g3XGcO/LjX3r6F++dp5BUpBv4EawOVVgs9mazyChiA14Ie1/1+O9lgP+DuH5idJtR1+DetpDAxvH293SvpOENSWgMREo/VRcepHXuFbP15tsoBAHPEc9Dc3NGYkuSHCjdbCijld9LKcIGVfwhp/US/YwxK7U3mZwpHTEVE+BKVyq6xmz3a9mzXaY00HTuy++0OlNUHRKnBiXMZ+6vxp3kCv8zcTdSUSC/IdS3SY4xLOklpRYppI6kxVWMbSRkbbT4eIZ0+muDQ5UMlA0lvNXUdeKZ+yxbNwaSc6/2TxvFPMJqfzTnAiNvod0XA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199015)(33656002)(36756003)(91956017)(122000001)(38070700005)(4326008)(316002)(54906003)(66476007)(6916009)(86362001)(64756008)(66556008)(66946007)(66446008)(8676002)(5660300002)(38100700002)(6486002)(478600001)(966005)(41300700001)(53546011)(6512007)(6506007)(26005)(2906002)(8936002)(76116006)(186003)(71200400001)(2616005)(83380400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <121AD643FDD1FF48AF5108C63981758D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5927
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	776a0664-f966-49f7-f9cc-08dab1a700dd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	szJTkzFro2kKlY+TX6kMbwm8A7VP1StjiIckOwWMkwS4KWhVboD5Cnx10D6sqcfYwHc9rucuvOyoZ54qQvV1uceBeQd6zO84UmWchj8ZtH0vxj17xsVI/MWaDovPWYgQQQHiopxGNw2/TSWgnPLbf8GZVPd03mINnxQ8LyK3m3mljz34T7xN9hhO+tWqjpG4ExxqZI7Xnoz7PYvao2xPiSxYqJ/3Cwyyt4Qe+QxwLkWHWjoX0ji/a+Iwn9rwzqN+J47DxzxP/YK5ysu83bWOIeKQFtYlmPxvQH9e1GoveW33h1pDvyYoAoEP5RDfkwiwYI6HvFAz7Y1RnLUGR57RKJKB8891jpnnlKG960Je3XcUPeLCyEh+j26N/sO/6O55AFdPAIu25cAJwZgmsjdqJnPWvwNtRyw00/7xu01RxmdoTCTiqwT/I1Fl8XA957A056HBMIeaq5cpQNNO1wkO/nTsB58L5R0YE9QkvhNctfK2wlHi7r+qd7S/dDLz5spXPdFIprWMiJKZ9RJdlUlwXPGmXUZg0/sGN/qMkdTHAcifRUfGQSOrcBodrGy5Kr/u7LLJnXX8U1/n70aPDsQvhp55Vw6hH26I/ZFxVTIPvfFx46/Ol1+OhH6CufrxYsb54cTNB/DCGMziWmlHVHwjbtNiO6Xk/BmRovFrB2pzfPLZDdhQytgCt0l6a5sjxF63PKKo0JzUb8BQCIdWF5gDuDso3qm074/jXISwnyK5AJRNbsHEp+sKye13T3eoqu81HbChmssejjsOU+prAaNn3Rjc4ZHwu8uGlrYw/6SSIfo=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(81166007)(47076005)(186003)(6486002)(83380400001)(356005)(336012)(86362001)(41300700001)(36860700001)(2616005)(5660300002)(82740400003)(2906002)(966005)(82310400005)(40480700001)(4326008)(8676002)(70586007)(6862004)(6506007)(478600001)(6512007)(316002)(8936002)(70206006)(40460700003)(53546011)(36756003)(54906003)(26005)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 07:53:47.6714
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ee0009-3666-4ffa-0006-08dab1a70df2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT016.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7566

DQoNCj4gT24gMTkgT2N0IDIwMjIsIGF0IDA3OjM4LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTguMTAuMjAyMiAxODoxMSwgQmVydHJhbmQgTWFycXVp
cyB3cm90ZToNCj4+PiBPbiAxOCBPY3QgMjAyMiwgYXQgMTY6MjksIEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+Pj4gT24gMTguMTAuMjAyMiAxNzoxNywgTHVjYSBGYW5j
ZWxsdSB3cm90ZToNCj4+Pj4+IE9uIDEzIE9jdCAyMDIyLCBhdCAxMjozNCwgSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+IE9uIDEzLjEwLjIwMjIgMTI6MTEsIEx1
Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+Pj4+IE9uIDEzIE9jdCAyMDIyLCBhdCAwODo1MCwgSmFu
IEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4+Pj4+Pj4gT24gMTIuMTAuMjAy
MiAxODowMCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+Pj4+IEVudHJpZXMgaW4gdGhlIGRh
dGFiYXNlIHNob3VsZCBuZXZlciBiZSByZW1vdmVkLCBldmVuIGlmIHRoZXkgYXJlIG5vdCB1c2Vk
DQo+Pj4+Pj4+PiBhbnltb3JlIGluIHRoZSBjb2RlIChpZiBhIHBhdGNoIGlzIHJlbW92aW5nIG9y
IG1vZGlmeWluZyB0aGUgZmF1bHR5IGxpbmUpLg0KPj4+Pj4+Pj4gVGhpcyBpcyB0byBtYWtlIHN1
cmUgdGhhdCBudW1iZXJzIGFyZSBub3QgcmV1c2VkIHdoaWNoIGNvdWxkIGxlYWQgdG8gY29uZmxp
Y3RzDQo+Pj4+Pj4+PiB3aXRoIG9sZCBicmFuY2hlcyBvciBtaXNsZWFkaW5nIGp1c3RpZmljYXRp
b25zLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gQ2FuIHdlIGFkZCBwcm92aXNpb25zIGZvciBzaHJpbmtp
bmcgc3VjaCBlbnRyaWVzIHRvIGUuZy4ganVzdCB0aGVpciAiaWQiDQo+Pj4+Pj4+IGxpbmU/IE9y
IGlzIHRoZSBpbnRlbnRpb24gdG8gYmUgYWJsZSB0byByZS11c2Ugc3VjaCBhbiBlbnRyeSBpZiBh
IG1hdGNoaW5nDQo+Pj4+Pj4+IGluc3RhbmNlIGFwcGVhcnMgYWdhaW4gbGF0ZXI/DQo+Pj4+Pj4g
DQo+Pj4+Pj4gSSBwcmVmZXIgdG8gZG9u4oCZdCBzaHJpbmsgaXQsIHRoZSBuYW1lIGl0c2VsZiBp
cyBub3QgdmVyeSBsb25nLCBldmVuIHVzaW5nIG1hbnkgZGlnaXRzIG9mIHRoZSBpbmNyZW1lbnRh
bA0KPj4+Pj4+IG51bWJlciwgaXQgcmVtb3ZlcyBhbHNvIHRoZSBkZXBlbmRlbmN5IG9uIHRoZSBm
aWxlIG5hbWUuDQo+Pj4+PiANCj4+Pj4+IE5hbWUgbGVuZ3RoIGlzbid0IHJlbGV2YW50IGhlcmUs
IGFuZCBJIGhhdmUgbm8gaWRlYSB3aGF0IGRlcGVuZGVuY3kgb24gYQ0KPj4+Pj4gZmlsZSBuYW1l
IHlvdSdyZSB0aGlua2luZyBvZi4gTXkgcXVlc3Rpb24gaXMgYSBzY2FsYWJpbGl0eSBvbmU6IE92
ZXIgdGltZQ0KPj4+Pj4gdGhlIHRhYmxlIHdpbGwgZ3JvdyBsYXJnZS4gSWYgYWxsIGVudHJpZXMg
cmVtYWluIHRoZXJlIGluIGZ1bGwgZm9yZXZlciwNCj4+Pj4+IHRhYmxlIHNpemUgbWF5IGJlY29t
ZSB1bndpZWxkeS4NCj4+Pj4gDQo+Pj4+IE9rIEkgbWlzdW5kZXJzdG9vZCB5b3VyIHF1ZXN0aW9u
LCBub3cgSSB1bmRlcnN0YW5kIHdoYXQgeW91IGFyZSBhc2tpbmcsIHdlIGNvdWxkIHJlbW92ZSB0
aGUgY29udGVudA0KPj4+PiBvZiB0aGUg4oCcYW5hbHlzZXLigJ0gZGljdGlvbmFyeSBmb3Igc3Vy
ZSwgYmVjYXVzZSBpZiB0aGVyZSBpcyBub3QgYW55bW9yZSBhIGxpbmsgd2l0aCB0aGUgY3VycmVu
dCBjb2RlLg0KPj4+PiANCj4+Pj4gUmVnYXJkaW5nIHJlbW92aW5nIHRoZSDigJxuYW1l4oCdIGFu
ZCDigJx0ZXh04oCdLCBjb3VsZCBpdCBiZSB0aGF0IGF0IHNvbWUgcG9pbnQgd2UgY2FuIGludHJv
ZHVjZSBpbiB0aGUgY29kZQ0KPj4+PiBhIHZpb2xhdGlvbiB0aGF0IHJlcXVpcmVzIHRoZSBzYW1l
IGp1c3RpZmljYXRpb24gcHJvdmlkZWQgYnkgdGhlIOKAnG9ycGhhbuKAnSBlbnRyeT8NCj4+Pj4g
SW4gdGhhdCBjYXNlIHdlIGNvdWxkIHJldXNlIHRoYXQgZW50cnkgd2l0aG91dCBjcmVhdGluZyBh
IG5ldyBvbmUgdGhhdCB3aWxsIG9ubHkgd2FzdGUgc3BhY2UuDQo+Pj4+IFdoYXQgaXMgdGhlIG9w
aW5pb24gb24gdGhpcz8NCj4+PiANCj4+PiBXZWxsLCB5ZXMsIHRoaXMgaXMgdGhlIG9uZSBjYXNl
IHRoYXQgSSwgdG9vLCB3YXMgd29uZGVyaW5nIGFib3V0LiBJdCdzIG5vdA0KPj4+IGNsZWFyIHRv
IG1lIHdoZXRoZXIgaXQgd291bGRuJ3QgYmUgYmV0dGVyIHRvIGFsbG9jYXRlIGEgZnJlc2ggSUQg
aW4gc3VjaCBhDQo+Pj4gY2FzZS4NCj4+IA0KPj4gRm9yIHRyYWNlYWJpbGl0eSBhbmQgcmVsZWFz
ZSBoYW5kbGluZyBJIHRoaW5rIGl0IGlzIGltcG9ydGFudCB0aGF0Og0KPj4gLSB3ZSBuZXZlciBy
ZXVzZSB0aGUgc2FtZSBJRCBpbiBhbnkgY2FzZQ0KPj4gLSB3ZSBrZWVwIElEcyBpbiB0aGUgZGF0
YWJhc2UgZXZlbiBpZiB0aGVyZSBpcyBubyBvY2N1cnJlbmNlIGluIHhlbiBjb2RlIGFzIHRoaXMg
d2lsbCBwcmV2ZW50IGFkZGluZyBhIG5ldyBJRCBpZiBhbiBleGlzdGluZyBvbmUgY2FuIGJlIHJl
dXNlZA0KPj4gDQo+PiBJbiBhIGNlcnRpZmljYXRpb24gY29udGV4dCwgd2hlbiBhIGp1c3RpZmlj
YXRpb24gaGFzIGJlZW4gdmFsaWRhdGVkIGFuZCBhZ3JlZWQgaXQgd2lsbCBtYWtlIGxpZmUgYSBs
b3QgZWFzaWVyIHRvIG5vdCBtb2RpZnkgaXQgYW5kIHJldXNlIGl0IGluIHRoZSBmdXR1cmUgaWYg
aXQgaXMgbmVlZGVkLg0KPj4gRnJvbSBvdXIgcG9pbnQgb2YgdmlldywgaGF2aW5nIGEgY2xlYXIg
YW5kIHNpbXBsZSB3YXkgb2YgaGFuZGxpbmcgdGhvc2Ugd2lsbCBtYWtlIGJhY2twb3J0cyBhIGxv
dCBlYXNpZXIuDQo+IA0KPiBJc24ndCB2YWxpZGF0aW9uIG9mIGEganVzdGlmaWNhdGlvbiBjb25u
ZWN0ZWQgdG8gdGhlIGFmZmVjdGVkIGNvZGU/IElmIHNvLA0KPiBldmVyeSBuZXcgaW5zdGFuY2Ug
d2lsbCBuZWVkIHZhbGlkYXRpb24sIHdoaWxlIGFuIG9ycGhhbiBlbnRyeSBpcyBlbnRpcmVseQ0K
PiBtZWFuaW5nbGVzcy4NCj4gDQo+Pj4+Pj4gQWZ0ZXIgdGhlIGFuYWx5c2lzLCB0aGUgc291cmNl
IGNvZGUgd2lsbCByZXR1cm4gYXMgdGhlIG9yaWdpbmFsICh3aXRoIHRoZSBTQUYtKiB0YWcpLg0K
Pj4+Pj4gDQo+Pj4+PiBXaGlsZSB5b3UgbWVudGlvbiBzb21ldGhpbmcgc2ltaWxhciBhbHNvIGFz
IHN0ZXAgMyBpbiB0aGUgb3JpZ2luYWwgZG9jdW1lbnQNCj4+Pj4+IG5lYXIgdGhlIHRvcCwgSSdt
IGFmcmFpZCBJIGRvbid0IHVuZGVyc3RhbmQgd2hhdCB0aGlzICJyZXR1cm4gYXMgdGhlIG9yaWdp
bmFsIg0KPj4+Pj4gbWVhbnMuIElmIHlvdSB3YW50IHRvIHJ1biB0aGUgdG9vbCBvbiBhbiBhbHRl
cmVkIChjb21tZW50cyBtb2RpZmllZCkgc291cmNlDQo+Pj4+PiB0cmVlLCB3aGF0IEknZCBleHBl
Y3QgeW91IHRvIGRvIGlzIGNsb25lIHRoZSBzb3VyY2VzIGludG8gYSB0aHJvdy1hd2F5IHRyZWUs
DQo+Pj4+PiBtYXNzYWdlIHRoZSBjb21tZW50cywgcnVuIHRoZSB0b29sLCBhbmQgZGVsZXRlIHRo
ZSBtYXNzYWdlZCB0cmVlLg0KPj4+Pj4+Pj4gaWYgdGhlIG9iamVjdCBkb2Vzbid0IGhhdmUgYSBr
ZXktdmFsdWUsIHRoZW4gdGhlIGNvcnJlc3BvbmRpbmcgaW4tY29kZQ0KPj4+Pj4+Pj4gY29tbWVu
dCB3b24ndCBiZSB0cmFuc2xhdGVkLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gSWlyYyBhdCBsZWFzdCBD
b3Zlcml0eSBpZ25vcmVzIGNlcnRhaW4gaW5zdGFuY2VzIG9mIHdoYXQgaXQgbWlnaHQgY29uc2lk
ZXINCj4+Pj4+Pj4gdmlvbGF0aW9ucyAoZmFsbC10aHJvdWdoIGluIHN3aXRjaCgpIHN0YXRlbWVu
dHMgaW4gcGFydGljdWxhcikgaW4gY2FzZQ0KPj4+Pj4+PiBfYW55XyBjb21tZW50IGlzIHByZXNl
bnQuIFRoZXJlZm9yZSBtYXkgSSBzdWdnZXN0IHRoYXQgc3VjaCBjb21tZW50cyBiZQ0KPj4+Pj4+
PiBkZWxldGVkIChyZWFsbHk6IHJlcGxhY2VkIGJ5IGEgYmxhbmsgbGluZSwgdG8gbWFpbnRhaW4g
Y29ycmVjdCBsaW5lDQo+Pj4+Pj4+IG51bWJlcmluZykgaWYgdGhlcmUncyBubyBtYXRjaGluZyBr
ZXktdmFsdWUgcGFpcj8NCj4+Pj4+PiANCj4+Pj4+PiBZZXMgdGhlIGxpbmUgd29u4oCZdCBiZSBh
bHRlcmVkIGlmIHRoZXJlIGlzIG5vIG1hdGNoLiBUaGlzIHRvIGVuc3VyZSB0aGUgY29ycmVjdCBs
aW5lDQo+Pj4+Pj4gbnVtYmVyaW5nIGlzIG5vdCBhZmZlY3RlZC4NCj4+Pj4+IA0KPj4+Pj4gIndv
bid0IGJlIGFsdGVyZWQiIGlzIHRoZSBvcHBvc2l0ZSBvZiB3aGF0IEkndmUgYmVlbiBhc2tpbmcg
dG8gY29uc2lkZXI6DQo+Pj4+PiBPYnNlcnZpbmcgdGhhdCBjb21tZW50cyBfcmVnYXJkbGVzc18g
b2YgdGhlaXIgY29udGVudHMgbWF5IHNpbGVuY2UgZmluZGluZ3MsDQo+Pj4+PiB0aGUgc3VnZ2Vz
dGlvbiBpcyB0byByZW1vdmUgY29tbWVudHMgKGxlYXZpbmcgYSBibGFuayBsaW5lKSB3aGVuIHRo
ZXJlJ3Mgbm8NCj4+Pj4+IGVudHJ5IGZvciB0aGUgdGFyZ2V0ZWQgdG9vbCBpbiB0aGUgdGFibGUg
ZW50cnkuDQo+Pj4+IA0KPj4+PiBXaHk/IFRoZSB0YWcgY29tbWVudCB3b27igJl0IGRvIGFueXRo
aW5nLCBpdCB3b3VsZCBhY3QgYXMgYSBibGFuayBsaW5lIGZyb20gdGhlIGFuYWx5c2VyDQo+Pj4+
IHBlcnNwZWN0aXZlLg0KPj4+IA0KPj4+IFRoZSBfdGFnXyB3b24ndCBkbyBhbnl0aGluZywgYnV0
IGFzIHNhaWQgYW55IF9jb21tZW50XyBtYXkgaGF2ZSBhbiBlZmZlY3QuDQo+PiANCj4+IEkgYW0g
bm90IHN1cmUgSSBmb2xsb3cgdGhpcyBvbmUgYnV0IGluIGFueSBjYXNlIHdlIGNhbiBjaG9vc2Ug
dG8gYW55d2F5IHN1YnN0aXR1dGUgdGhlIHRhZyB3aXRoIHNvbWV0aGluZyBsaWtlIC8qIE5vdCBh
cHBsaWNhYmxlICovLg0KPiANCj4gVGhhdCdzIHN0aWxsIGEgY29tbWVudCwgd2hpY2ggaGVuY2Ug
bWF5IHN0aWxsIHNpbGVuY2UgYSB0b29sOg0KPiANCj4gICAgc3dpdGNoICggeCApDQo+ICAgIHsN
Cj4gICAgY2FzZSBhOg0KPiAgICAgICAgLi4uDQo+ICAgICAgICAvKiBTQUYtPE4+LXNhZmUgKi8N
Cj4gICAgY2FzZSBiOg0KPiAgICAgICAgLi4uDQo+ICAgICAgICBicmVhazsNCj4gICAgfQ0KPiAN
Cj4gaXMgbm8gZGlmZmVyZW50IGZyb20NCj4gDQo+ICAgIHN3aXRjaCAoIHggKQ0KPiAgICB7DQo+
ICAgIGNhc2UgYToNCj4gICAgICAgIC4uLg0KPiAgICAgICAgLyogZmFsbC10aHJvdWdoICovDQo+
ICAgIGNhc2UgYjoNCj4gICAgICAgIC4uLg0KPiAgICAgICAgYnJlYWs7DQo+ICAgIH0NCj4gDQo+
IG5vcg0KPiANCj4gICAgc3dpdGNoICggeCApDQo+ICAgIHsNCj4gICAgY2FzZSBhOg0KPiAgICAg
ICAgLi4uDQo+ICAgICAgICAvKiBOb3QgYXBwbGljYWJsZSAqLw0KPiAgICBjYXNlIGI6DQo+ICAg
ICAgICAuLi4NCj4gICAgICAgIGJyZWFrOw0KPiAgICB9DQo+IA0KPiBPbmx5DQo+IA0KPiAgICBz
d2l0Y2ggKCB4ICkNCj4gICAgew0KPiAgICBjYXNlIGE6DQo+ICAgICAgICAuLi4NCj4gDQo+ICAg
IGNhc2UgYjoNCj4gICAgICAgIC4uLg0KPiAgICAgICAgYnJlYWs7DQo+ICAgIH0NCj4gDQo+IHdp
bGwgbWFrZSBlLmcuIENvdmVyaXR5IGFjdHVhbGx5IHBvaW50IG91dCB0aGUgcG90ZW50aWFsbHkg
dW5pbnRlbmRlZA0KPiBmYWxsIHRocm91Z2ggKGJhc2VkIG9uIHBhc3Qgb2JzZXJ2YXRpb25zKS4g
V2hldGhlciB0aGF0IGJlaGF2aW9yIGlzDQo+IGZhbGwtdGhyb3VnaC1zcGVjaWZpYyBJIGRvbid0
IGtub3cuIElmIGl0IGluZGVlZCBpcywgdGhlbiBtYXliZSBteQ0KPiBjb25jZXJuIGlzIHZvaWQg
LSBpbiB0aGUgbG9uZyBydW4gSSB0aGluayB3ZSB3YW50IHRvIHVzZSB0aGUgcHNldWRvLQ0KPiBr
ZXl3b3JkIHRoZXJlIGluIGFsbCBjYXNlcyBhbnl3YXkuDQoNCmh0dHBzOi8vd3d3LnN5bm9wc3lz
LmNvbS9ibG9ncy9zb2Z0d2FyZS1zZWN1cml0eS9naW1tZS1hLWJyZWFrLw0KDQpOb3cgSSB1bmRl
cnN0YW5kIHdoYXQgeW91IG1lYW4sIHRoZSBmYWxsIHRocm91Z2ggaXMgdmVyeSBkaWZmaWN1bHQg
dG8gdW5kZXJzdGFuZCBmcm9tIHRoZSB0b29sIGJlY2F1c2UNCkl0IGNvdWxkIGJlIGEgc291cmNl
IG9mIGEgbG90IG9mIGZhbHNlIHBvc2l0aXZlLg0KDQpIZW5jZSBDb3Zlcml0eSBjYW1lIHVwIHdp
dGggdGhpcywgaG93ZXZlciBJIHJlYWxseSBkb3VidCBDb3Zlcml0eSBpcyBzaWxlbmNpbmcgdGhl
IGZpbmRpbmcgb24gX2FueV8gY29tbWVudCwNCnRoaW5rIGFib3V0IHRoaXMgZXhhbXBsZToNCg0K
c3dpdGNoICh4KQ0Kew0KY2FzZSBhOg0KICAgICA8c3RhdGVtZW50Pg0KICAgICAvKiBicmVhazsg
Ki8NCmNhc2UgMjoNCiAgICAgPHN0YXRlbWVudD4NCiAgICAgYnJlYWs7DQp9DQoNClRoaXMgaXMg
Y2xlYXJseSBhIGRldmVsb3BlciBtaXN0YWtlIGFuZCBzaG91bGQgbm90IHNpbGVuY2UgdGhlIGZp
bmRpbmc6IGZhbHNlLW5lZ2F0aXZlIGFyZSB3YXkgbW9yZSBoYXJtZnVsIHRoYW4NCmZhbHNlLXBv
c2l0aXZlIHRoYXQgYXJlIG1vc3RseSBhbm5veWluZy4NCg0KSW4gZmFjdCBJIHRoaW5rIENvdmVy
aXR5IGlzIGNoZWNraW5nIHRoZSBjb250ZW50IG9mIHRoZSBjb21tZW50IGxvb2tpbmcgZm9yIGZh
bGwtdGhyb3VnaC9mYWxsIHRocm91Z2gvZmFsbCB0aHJ1IFvigKZdDQoNCg0KDQo+IA0KPiBKYW4N
Cg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 08:00:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 08:00:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425614.673547 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3zy-0003x7-4g; Wed, 19 Oct 2022 08:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425614.673547; Wed, 19 Oct 2022 08:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol3zy-0003x0-0v; Wed, 19 Oct 2022 08:00:22 +0000
Received: by outflank-mailman (input) for mailman id 425614;
 Wed, 19 Oct 2022 08:00:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol3zw-0003rj-3a
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 08:00:20 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140049.outbound.protection.outlook.com [40.107.14.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12890e63-4f84-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 10:00:18 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8695.eurprd04.prod.outlook.com (2603:10a6:10:2de::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 08:00:16 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 08:00:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12890e63-4f84-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xzgs0hcvm3N/IvxKRHtpnS8qOEbM+J9Z51t+HXUcjm3oGdmfmRoOxPANco7K2Wz3z3y07bBrfvTlw6KVtGZ+5GYZ9NiVk1D7vk9n08XNKQtHRaTiLeyo52pH8IqxkBz5W42EE0UHC1BzgWR8Q1o593oxf/G74csedId+eaRXp09MVRrdYcUWnczi6LrVqpiO8bvIUsnGPKoqFN/KDDY5ijdW4lA4ZdK0P8Ame31/YLDsaXvMk7g304uyRYMi6A6i92tFd/S6RNqCq73imAiVgctJ7O6RuAIvZ4QccUTWyafWqXGPedKkUKLkh3CsgEkT5cI2PlwRjMwrMgsotB1bEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zG5oUj1mt+uZIvQd9jtbBI3e4TyhhC7SRnv9n6nV0ds=;
 b=lUkfapLauY2awnMg9eb9GSuWPPXFf7b1oybsq4gOGTNfZCPuL9WbcwlycuZ4zMHjhbhpbMdg+ddZNSJ1EOfDj2t9gyTyVfq/eeClUjem0P3mkxu3asF30Rm5An1eydiIDTJejVVdSXQnra/3df0uo1vdByGAiQzxWGNV+JGuBWfGbctTHL/mh2AvxpMGmV9uvsVR9s6EyhR14NCdm7ij6ZMJrGSH9q1X0tERHPF+fGzkVJny8dtnn+SdIgUuNtJwrNPurgc4JfbTmB7B5UWXD9JbieLRNY2pS/e1eR6A9fwWG3nNiqIt6ssFbxseAHDF97SE3hAZZekm2sdcwpM/TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zG5oUj1mt+uZIvQd9jtbBI3e4TyhhC7SRnv9n6nV0ds=;
 b=A9l+IRoBtMZd/bjazH5ZCSYTMz2ueC+41zueMap+GThWQO2I5yK9MealmrqO6X7lz8G+M3plz0y8LoxRQT4mAhHTPQuIIKzD0AkHw1Wnr4uPadeH2zYgPM1/7wequFDjxPvKH2MHcVg7EtEo8gg5jhfY9l/suNSVtVd9ck4l1zZcmBK4vDzcn4l/0qM77/bsOKOBrrjba58l0VWYmXkH3VJF4hySM9iRZcBlIuvdCqNBmY20lHtXdt83Y/BeNqmr7FyaFh6BNc5JvbgpcpV6w5Krvec1R7n8LW5h1ynICJM7AynzhBDiAtx76OeR9s3w+KAztfWXAasNJqmTvclrtA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de0d84bc-d2e3-759e-7459-d81e768b7749@suse.com>
Date: Wed, 19 Oct 2022 10:00:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Proposal for deviations in static analyser findings
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Luca Fancellu <Luca.Fancellu@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <EBCDE6CE-A84A-48C7-B3C2-7856E5D2392B@arm.com>
 <ddc5039d-e312-326a-b71c-8d08d04100e0@suse.com>
 <186C83D7-6C7A-4319-86E4-69F7FDA7FDA5@arm.com>
 <559a3d4c-08ea-ef8c-9a56-2b53db3d51e4@suse.com>
 <E00E3AE4-7863-4231-9DB7-A7B66C8F6791@arm.com>
 <233a9356-b64f-37f7-d7ee-3d6223224497@suse.com>
 <A906FDB6-7DA5-4900-A6DE-1140231E69AE@arm.com>
 <9b113db9-4dce-d300-9393-a8572ee4fdcd@suse.com>
 <A3CC086E-7B11-4D6A-BF01-565BB8C3A846@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <A3CC086E-7B11-4D6A-BF01-565BB8C3A846@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a8::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8695:EE_
X-MS-Office365-Filtering-Correlation-Id: 1908bd9c-954f-4d04-ec83-08dab1a7f543
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fhfDeoLgU1ExfMb2FsYMScMa8n87e+6wj/on3vIfV21tGBkK2LyMOnuUW6QvpeCqmXQNgrzZnRj4oVBNcOJqJIjS5sNaF+px9rCyI1rDL42rfS1VSyB3+TiWrzcPx3IXtAz8fOObF1pCuLRAbtSOZtFQ5erWTe8fikOSe7AdbO1tqavKLgLqAhSxSNQ5Vc2n0Y1rLZWKqsVQx1eu7yDNQKKwOtKLeNWvSO6gEv7KM1AqFOnddFjyeCUepeTn2hcNp9cg24f+Hk4cEn6OSLSQRxMp5MHcyNGtn4Vh31JzVD2/fFZfSiJuZ8CfHcXMYxnIE0cdMAIqdDJSycR4FXyMGyEbADG52Gm7k7icx2aYZQhpdX2LWaeP606bcPTPyho5Qd5viOqAE9Eym+UCn5lpeNL7qRoTT6DD83iMZCWWhY/10WJVdprHA+TbDZFdaNZMvABORcMZXFC9qvv2i8124SPp4+YkFCnHvaMFmpFizpsXmr1LWJ3WBDihk8aRCUnxowkfwgShJURB3yG7PHAsnPZHPfrV7RblaFDuLgxzRBnZAp/oBE6HDWDv33opGYgrHkz7PdjkUaxe2IoszkC6DenLYusMN3tjcQPAoGqaDeqeAhJ9Il6BqspojWFyEuwCj0DZamHkWH6SarKz02hx008bGLR1hp8EDAX8r5T7Gzy+IX0gQQqblvikbH9VvyYRctxCEDjPIqLo6leUJNetpq4GchbxPbG+iRIqaUV6wivWc41dTIh1fiWAeqxU4K1EYQcSnkrRwbTi62khjCEYaW0A3mAeaFfHsd63PgJMqeQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(396003)(346002)(376002)(451199015)(41300700001)(5660300002)(31686004)(2906002)(66556008)(66946007)(54906003)(8676002)(6916009)(4326008)(316002)(36756003)(6486002)(6506007)(8936002)(478600001)(6512007)(83380400001)(53546011)(26005)(38100700002)(66476007)(186003)(31696002)(86362001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWx5SzduSlRWTWQvTmNBUTU1Mzd4TUphaXY4eW5BNTZjWjZCV2lCT3Q2QUhq?=
 =?utf-8?B?N1NKdTZ5eFBhRmRveDRLL09IVHUrVXFDZVZ2YUpRZHdiSEhvNGhOdFFyT2cr?=
 =?utf-8?B?cHhCZ3ZEbkh6d1lqbEx4SEE0R3p0MlN0MEo3YjNpWjExRWtvZjZxVGtVbldu?=
 =?utf-8?B?aUdJc0JzQ3Q4UUN3ZUt2UjNPaVh4RDQ5WE4yeFMvZ20vQzhQMHJHcGV4SGw2?=
 =?utf-8?B?SzNlQmtqV0ZFcW9xWE94WWtXRzhtV3M5V3BOeSsxVjlFYTRsOTExOG1icEtP?=
 =?utf-8?B?YVlPRFdRQWdtbUdweGdRNzhVQVJzcjU0SmcwQjZFTW5yMURqMVhaRWRrWkp1?=
 =?utf-8?B?K09xNmNMMngvc1l3Y2d6Y3RHU0VLazBXU3pLRy9ybHF1NTRITjA0cDVGSVhz?=
 =?utf-8?B?SXFITjZDTWRrV3VpdmVNU05EUXRDZHVpdVhNR3R5cTFud1h4QW9PTmhPRWpm?=
 =?utf-8?B?c0owMXJLK0lhb2tJYXFxNFc4WmxUY3ZSdDZHRHJ6MytIZWdoTEZZbjFmdjdZ?=
 =?utf-8?B?dmpkaXBXOFpoUVZWMXNtYkg0KzJleVdmNjZmbmNTZEloOUc4djJQMFJmeS9p?=
 =?utf-8?B?cTV0dnp0RmkzZXI3WC9nNlhzc2VBdFVyUUJzajliZ3lHWWVZcDJYczA1OEFa?=
 =?utf-8?B?YUh6M2ZjQUtsSm5ObkJ3cG4rdmV5clQ4Q2NMMkVCMzNvR0N2MG12ZnZTNkRE?=
 =?utf-8?B?dHJLQjdhSTc3YlJrYzZTOHNSaHowQ0ZtUHl4c2wxaXlmQWtqUDZsRHV2OXNW?=
 =?utf-8?B?cTdPTGtDSmJLZ2ZzWHBqdGVUSHNqZytEMlV3OWE2eHRzQkxCK0lFS2ZvdUhw?=
 =?utf-8?B?Yy9LdldsYXRJMWxDbnV3OUF5QUdRbWYxL1FrcFUxVmF4UUdMRGY4bW8ya2lp?=
 =?utf-8?B?Y2lHZCs4SVIwUmFHWEMyVDlWK1FZdlBkQmpySWRVdnNkRHAvSEFMYnUvYW5V?=
 =?utf-8?B?ZHE3K0htZnZtQjBlRGxWcU1jRDV3L0diR3ZoaW1GSHk2RG84bzJOc1R1ZVdV?=
 =?utf-8?B?VDlEL003MER4K1V4eTAyT2dYMGJTNUNjSHZJVTBPNXpIWXFqUTVFU2c5c25j?=
 =?utf-8?B?Tk5QZjY2QzlYN3pTYlMwaVZwWHEzYVZvY3E3SndjVUphdHNpbUlsalV2QlZQ?=
 =?utf-8?B?L1lwL0o2NnJPU1VIaWh1d0M4dTdTZWFJcDFVdURzT2puTmx6N1gzNU40TVl6?=
 =?utf-8?B?YXhjWFJqWFQyREh6YXAwY2FKU0J5QlV1M0FpOTREdExONTJLM25ZWFk4WTAz?=
 =?utf-8?B?NUhId0g3cG9YQmppZG9qbE5JUExSRlZoVk5zSVE5dUhQNWNHOFhGWjJrUTJY?=
 =?utf-8?B?U0kwU0Q0bjBNYkdaMzI5Vm9zL2w1ZVYyT0NCRzh1SVhQcDNPcFdQSG5rWW1k?=
 =?utf-8?B?VzcvMHZ2UXZHOERhTnRyWTJTTU1LTkNIUXpQV0VqVlFyVU5PWStxZkFmOS9s?=
 =?utf-8?B?RVJ5WGMwN0RQSnFGOWtPazJER2hqb3djN1NvK3o4akN3L2FuSGxBNmVsSGFY?=
 =?utf-8?B?RnFHSGw1NWFVR2xtTy9PbmpwR3gzN0UyQnJNYTZkUzAvOUgxeVdycW1QMSsy?=
 =?utf-8?B?YlppdTN6VlBCc2syN2VmQzZMK1BCRm5Pa2RNeHJDbnZVVGluUVN2Y1RBaTVk?=
 =?utf-8?B?clB1KzVjbkNXUlJKUTg5T2pWK1lQUlRpRVZuZnhhZkN6SWhqVjhDV05aSVhw?=
 =?utf-8?B?dmpMYzdTM0traGMvQU1IRG5LRFNGWnVWamxZWjJGamhqbk1aWjl3aURnekVQ?=
 =?utf-8?B?WllJWEpUZkpqSGZwZm5KMnQxL3RwTGlLK1dKT3drRUR0ZGE2Qm5DMG5JQWZy?=
 =?utf-8?B?U3M0TGJzcExSUlhHRFduUHkzWGdzSmU4M0VkbHdaYzMxOXFBc3hSa2xYK3dk?=
 =?utf-8?B?b2ZLNkJOQTY0NEMrWmhWRDhiWWVmVnRTcS9aZ3N5aFVoY0RKUjVqdkFtVGNz?=
 =?utf-8?B?ck9aUEx2TmIxQ2xvdVVMcHU0OUdQdDB6TCszQjgwYnJYNTBPU090U3lhRnhL?=
 =?utf-8?B?NXV4UkNTcm43a0diMzByeVd2N2k2cjBrVFJ3SGluZnN4YUIxQmlzN2FCS2FB?=
 =?utf-8?B?VFZHRTdVTmVIMktQR21QRlBLMWNPYThhT2dWNUowRm9aSlorUnVaT2Y0dHhZ?=
 =?utf-8?Q?LLFWBebd9+FAj7Q2cniWjXika?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1908bd9c-954f-4d04-ec83-08dab1a7f543
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 08:00:16.0276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EuRNtDDLpG4EliePG4VHv8CQQYNxUNF9+M4+A2Srxw2tcvH94SRDimUS0e8FPgjM8rF1Gp3x9mXWRAIqIHhTRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8695

On 19.10.2022 09:52, Bertrand Marquis wrote:
>> On 19 Oct 2022, at 07:38, Jan Beulich <jbeulich@suse.com> wrote:
>> On 18.10.2022 18:11, Bertrand Marquis wrote:
>>>> On 18 Oct 2022, at 16:29, Jan Beulich <jbeulich@suse.com> wrote:
>>>> On 18.10.2022 17:17, Luca Fancellu wrote:
>>>>>> On 13 Oct 2022, at 12:34, Jan Beulich <jbeulich@suse.com> wrote:
>>>>>> On 13.10.2022 12:11, Luca Fancellu wrote:
>>>>>>> After the analysis, the source code will return as the original (with the SAF-* tag).
>>>>>>
>>>>>> While you mention something similar also as step 3 in the original document
>>>>>> near the top, I'm afraid I don't understand what this "return as the original"
>>>>>> means. If you want to run the tool on an altered (comments modified) source
>>>>>> tree, what I'd expect you to do is clone the sources into a throw-away tree,
>>>>>> massage the comments, run the tool, and delete the massaged tree.
>>>>>>>>> if the object doesn't have a key-value, then the corresponding in-code
>>>>>>>>> comment won't be translated.
>>>>>>>>
>>>>>>>> Iirc at least Coverity ignores certain instances of what it might consider
>>>>>>>> violations (fall-through in switch() statements in particular) in case
>>>>>>>> _any_ comment is present. Therefore may I suggest that such comments be
>>>>>>>> deleted (really: replaced by a blank line, to maintain correct line
>>>>>>>> numbering) if there's no matching key-value pair?
>>>>>>>
>>>>>>> Yes the line won’t be altered if there is no match. This to ensure the correct line
>>>>>>> numbering is not affected.
>>>>>>
>>>>>> "won't be altered" is the opposite of what I've been asking to consider:
>>>>>> Observing that comments _regardless_ of their contents may silence findings,
>>>>>> the suggestion is to remove comments (leaving a blank line) when there's no
>>>>>> entry for the targeted tool in the table entry.
>>>>>
>>>>> Why? The tag comment won’t do anything, it would act as a blank line from the analyser
>>>>> perspective.
>>>>
>>>> The _tag_ won't do anything, but as said any _comment_ may have an effect.
>>>
>>> I am not sure I follow this one but in any case we can choose to anyway substitute the tag with something like /* Not applicable */.
>>
>> That's still a comment, which hence may still silence a tool:
>>
>>    switch ( x )
>>    {
>>    case a:
>>        ...
>>        /* SAF-<N>-safe */
>>    case b:
>>        ...
>>        break;
>>    }
>>
>> is no different from
>>
>>    switch ( x )
>>    {
>>    case a:
>>        ...
>>        /* fall-through */
>>    case b:
>>        ...
>>        break;
>>    }
>>
>> nor
>>
>>    switch ( x )
>>    {
>>    case a:
>>        ...
>>        /* Not applicable */
>>    case b:
>>        ...
>>        break;
>>    }
>>
>> Only
>>
>>    switch ( x )
>>    {
>>    case a:
>>        ...
>>
>>    case b:
>>        ...
>>        break;
>>    }
>>
>> will make e.g. Coverity actually point out the potentially unintended
>> fall through (based on past observations). Whether that behavior is
>> fall-through-specific I don't know. If it indeed is, then maybe my
>> concern is void - in the long run I think we want to use the pseudo-
>> keyword there in all cases anyway.
> 
> We can choose the replacement comment to be something not
> considered by the tools (or even put an empty /* */).
> What we cannot do is remove the line as it would change line numbers.

Right, and hence I did say we want to zap the comment, leaving an empty
line.

> But apart from fallthrough I do not think any comment is considered by
> any tools so this should not be an issue.

Well, we can hope for that of course.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 08:05:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 08:05:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425620.673558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol44o-0004db-ME; Wed, 19 Oct 2022 08:05:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425620.673558; Wed, 19 Oct 2022 08:05:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol44o-0004dU-Iw; Wed, 19 Oct 2022 08:05:22 +0000
Received: by outflank-mailman (input) for mailman id 425620;
 Wed, 19 Oct 2022 08:05:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol44m-0004dK-JR; Wed, 19 Oct 2022 08:05:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol44m-0006ds-H7; Wed, 19 Oct 2022 08:05:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol44m-0007LS-8u; Wed, 19 Oct 2022 08:05:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol44m-00087E-8Q; Wed, 19 Oct 2022 08:05:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F8CRWsJ2npbrRrVtrRtopYc/kDOSdy8Fco1b8x7Nb2Y=; b=nXWFmm6YcHMWKl4tXS5Eom4Spe
	TpdjRKGbNHqX+g4GkGq1e19IOXJGKR0AHIBEFNRBDjiydqTsMCKJEm7s10vBBXNECv0XPx0JMWTda
	NbsrVJJgfHczbVhC4MCqRnrvNLwVJjt3xFXXoi4vCH4epaolioykoRg/IZ2JwKqv3bcI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174075-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174075: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c4663e7277d12835a886994919822e218a01b62e
X-Osstest-Versions-That:
    ovmf=9d6915ca91519271a79bc6190a31f0af89e339b2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 08:05:20 +0000

flight 174075 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174075/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c4663e7277d12835a886994919822e218a01b62e
baseline version:
 ovmf                 9d6915ca91519271a79bc6190a31f0af89e339b2

Last test of basis   173982  2022-10-17 08:12:08 Z    1 days
Testing same since   174075  2022-10-19 04:40:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bob Feng <bob.c.feng@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   9d6915ca91..c4663e7277  c4663e7277d12835a886994919822e218a01b62e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 08:07:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 08:07:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425628.673569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol471-0005Ei-30; Wed, 19 Oct 2022 08:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425628.673569; Wed, 19 Oct 2022 08:07:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol470-0005Eb-Vz; Wed, 19 Oct 2022 08:07:38 +0000
Received: by outflank-mailman (input) for mailman id 425628;
 Wed, 19 Oct 2022 08:07:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol46z-0005ER-CG; Wed, 19 Oct 2022 08:07:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol46z-0006h7-BM; Wed, 19 Oct 2022 08:07:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol46z-0007Ub-3i; Wed, 19 Oct 2022 08:07:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol46z-0004Fa-3I; Wed, 19 Oct 2022 08:07:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Vh4Eq/AeERamA+lHwzRMS2Ooj2sKDlmtXcEkj1INsQo=; b=lmopn4jg8+oiF9weeXrPFU1doY
	iQ1+9kmpFFk160hJKTqnkNiXGUb2871wTLm4ncdvYj3+Q/8iDmqV/Au7XGI5nRrYZftptFO3aV6+n
	KyyjHISKt/0oJAvEZqR+TI3Ygsxr3fj7zWGVwR66Xh8AWW8Mr457hws1Knj4QbWrzX3s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174076-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174076: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 08:07:37 +0000

flight 174076 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174076/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174051

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174051 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174051 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   50 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 08:11:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 08:11:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425636.673580 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol4AM-0006dP-Gt; Wed, 19 Oct 2022 08:11:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425636.673580; Wed, 19 Oct 2022 08:11:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol4AM-0006dI-DV; Wed, 19 Oct 2022 08:11:06 +0000
Received: by outflank-mailman (input) for mailman id 425636;
 Wed, 19 Oct 2022 08:11:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GAs9=2U=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ol4AK-0006dC-I5
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 08:11:04 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2073.outbound.protection.outlook.com [40.107.105.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92eddb1f-4f85-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 10:11:03 +0200 (CEST)
Received: from AS9PR06CA0416.eurprd06.prod.outlook.com (2603:10a6:20b:461::10)
 by AS4PR08MB7685.eurprd08.prod.outlook.com (2603:10a6:20b:504::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 08:11:00 +0000
Received: from VI1EUR03FT053.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::5a) by AS9PR06CA0416.outlook.office365.com
 (2603:10a6:20b:461::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 08:11:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT053.mail.protection.outlook.com (100.127.144.132) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 19 Oct 2022 08:11:00 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Wed, 19 Oct 2022 08:11:00 +0000
Received: from 13fdde4679ae.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B988705C-4338-43AB-906B-E46A57A842A5.1; 
 Wed, 19 Oct 2022 08:10:52 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 13fdde4679ae.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 08:10:52 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS4PR08MB7632.eurprd08.prod.outlook.com (2603:10a6:20b:4cf::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Wed, 19 Oct
 2022 08:10:50 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 08:10:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92eddb1f-4f85-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=D2zsURfvCc8qVkvOMJlY2OXPdgYykH34bB0fcpVlLiF5jLA1ML5+27puayrXSZr1nxZnMtdZchsV57e3InZX9P2azHGSgygNn1BnthSdvQrWUX/QolIxSjuMs+r5GWftxKRBe1xf4nqFivcHgQLgM/uO1zsd8b93zg+8t6MrhCvo9MnSEpkj1ij5LvNWOG8QEIKYMPDNBUfZfMDCoCOIdgz/gUZSuJg4o3o0FbarCaUFVRnYO4T0WW9fjqaAAGESur3gFhMvKWEVIkBKVYFlW06VJU1x0n6y6OFIQ6lC28cKndjscLGI0DFKWbLnjv1bUy5tB/Hos5hOGwj7bztUmg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vtGb7538Cx8y2U4c/1zdE7k1Q7Ac0s9VsCZsLE3gk6g=;
 b=aR1ZkkvOhBlx5F+p3bF1rSap4FMWZAmdpFSxFJ7lix4iWmGFBJC3PXLTaFAIv6cMHdWqnraLTrKEEQycddHsdvxo9cNppEP7DugVKvtTfA8w7tZQi7mr2Q/IVBCf2RYl/EuQpHYW5uEkQMiBsZhUMy8uEeVeqnrF+1UjMFeTti1dI2VUEVdF46zH7qgbPqd7IlRzKE7047Qbc1IvQahgAXz0XMdIw+VYBsU/dG1U9SZvSpVz/bAJCl5GhRDTmOZ0ZZmoohNQpB41pr9XIT4HdB7dxHjeXhy4JbAIZIXJ3nGl4p56FOFXAgB8Zvar3oIA8+0f+v1gK/KSB1xvpCxrEg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vtGb7538Cx8y2U4c/1zdE7k1Q7Ac0s9VsCZsLE3gk6g=;
 b=IF4CDd1emiTKeXgGl8eFsha/gha2JWObCOhgU+UobAUp0GN+g9OOFsfZSYHgqbo0vZRz1XpVfNoEJcgtDiSmfWNxwonwMGdVtvFGfSzGSUbEe5pEJLPHkh2I6CUOO0IDlM13FJW5naPZBeOTnENyIOaTIjVHhWGfRplfALl2Ce4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 447a7592deed8a0d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mewOLLt33gpDH0uL6FCACeHvKeLa/rEjS78IKBr5vOjovDjCVcnB3m7WEDTCA5roFWZzRZQwFt69FXAKGZOIjVCQgRe2/bPO9B04qYN2IfacvpmPN+w/M5tJMGpnGw8/QTVueVBN6blk0BhCPynnONDxs+nUwn1tEef/2p5M0Cr2wRcawke2FxCwP580tZeHMmQ4zlq3nIoo43GpB7aDuw73erkl1iUTkBRuUaYgbJXzGsdoDc9f6xHGTREjEZt0kAO/nfoJZi2D6onEqtuNewaHKZFkpr/id9JlgOT2f63Pfi5GLfl3JFRti9zDzp3jOBF6/WD8TwPGodFNDWSZcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vtGb7538Cx8y2U4c/1zdE7k1Q7Ac0s9VsCZsLE3gk6g=;
 b=O3OYBb0sCrw/Eg4Jzw+eA/0Op+922cDwHIgJ7U/elFgErGJI9lw8vbCOJrWbNeYjZj+gvTD97DEvwlfIJya2EE0eiMLr9iwEqaSjERYvSNJGZOpuOdVlZUZJkd0etlzAuNzIDqOBS46X38MNjXdfLtAEf0tJsRXEJlq2MTMqvuRJrfnDiy3C5Qsiig1g7HIEEXltoBY58RKIwD6I9JcedQhuhIdLmmCr3seXSH0/CNMRixoUdeYan+90zazlU+7wboz37TTZePSD0ZpEo2BLUyfAo1/HnxxdWRy4CMxdIv1bV2ijDqZxPbLOsYd7KOmsu0f4YWVzVJDox1daWJrbCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vtGb7538Cx8y2U4c/1zdE7k1Q7Ac0s9VsCZsLE3gk6g=;
 b=IF4CDd1emiTKeXgGl8eFsha/gha2JWObCOhgU+UobAUp0GN+g9OOFsfZSYHgqbo0vZRz1XpVfNoEJcgtDiSmfWNxwonwMGdVtvFGfSzGSUbEe5pEJLPHkh2I6CUOO0IDlM13FJW5naPZBeOTnENyIOaTIjVHhWGfRplfALl2Ce4=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>, "michal.orzel@amd.com" <michal.orzel@amd.com>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
Thread-Topic: [PATCH v2 0/3] Yocto Gitlab CI
Thread-Index: AQHY3hEMDLhOM5SRDUy6m8XkPQoc/64OWrqAgAP8xgCAAQ3WgIABes6AgACIUwA=
Date: Wed, 19 Oct 2022 08:10:50 +0000
Message-ID: <49FA68FE-43E0-4FB0-843D-1C4F744E778A@arm.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
 <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
 <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS4PR08MB7632:EE_|VI1EUR03FT053:EE_|AS4PR08MB7685:EE_
X-MS-Office365-Filtering-Correlation-Id: 0762fee4-1799-44f7-c783-08dab1a9755a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 er6ZZHc9tnDikf4XHaicwZLanvqCAzzMa9wwe+VUguDVAerPo1mjCWVxXOgOX0s8MlFLXBu3byQkLp3MGfoph3KhhkHFilK92Gwj9D+19MzQGx5jCr0S1njNBQ45cynapUCBamntMGpyGKQzQ4GrfrQFUvr03oSNPwFeZh2+vgKFJEC1Bp42WF9/sU2jk0342mv4qZlrZSNdqTjo2i0b0upxadbaWdPvVzTXbwBHUULGmDjjXEhMMCTkAZw3O+y61TntegCFkEaqJvWUdGvTM0n2PFpIha7OO2kdyiq9GnDJ/b/uy5+HG/LY+A2Uq0ez3lDNdRjGXFD7CvoLt4JYcRNYUkVkc0/kcTAZQO2CuUySnxwE780E1x59A+wXqlOSfYq2jVjOgbzHV+NySsyouapIW1kEOx/aP05ZmlUf7Gbe4xgWgZ5JHPS+PXhJ+DypKBFpdrikU55HjJsh8A33F75CkTEV/2yMP8yXJS1m0HGHHp4r6LDSUruYFRon+SnlXzqY4lLrP001D7WzYxPhiuhKJh1cHfiR2TuxKk03x6o0C34yTmJpSdMl48LsR3cz+Ggl4COqqwuFVrjr7JLSL0pXN+hShAPVszfJNxGuvFTjm9PNoACnjBSV0nR4UwS03CMSdd970Kt/cvd3YkpR45zGOF0O/0z7hJji3a2N956dkXHRK++t9TrMldqkjWsVmMpSGkR5X0+qhSsdKilL4sgdDUnH42A3gPWqfvkTSJJljNpk/ZaAOLRu2OSlrjHYnqseNih9fw/EWOAZaB2WkmuNyT7M5KKeApHpcHAVnUqdRSr4F/317PH85rHXDaOmYa5sR0LIggvAkfkPInv16wJoRzvgPptin1NZPYE+A8Y=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199015)(478600001)(38070700005)(36756003)(6506007)(5660300002)(83380400001)(966005)(6486002)(76116006)(66556008)(64756008)(66446008)(91956017)(66476007)(66946007)(4326008)(8676002)(8936002)(41300700001)(86362001)(53546011)(6512007)(26005)(54906003)(6916009)(2616005)(71200400001)(84970400001)(33656002)(122000001)(38100700002)(316002)(186003)(2906002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FEE7B4F9BD9CD44AB2243A45B0B202A7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7632
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c9a601ff-9e14-4b01-e5af-08dab1a96f87
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YbLAZGHS03xZyFANpGI47sLxRh+Os4F6nERv3djsJeJnRx6uhLMLxicol89roiXK5cVxN2OnCq7EiwWdDFGPeqj5eu8KBRwHSmhBX7WUCjGQlJEhG6++Eqruifc7AI05VGzkg0lZGHjigVFHL5vXeFvZEL3eMSjU0j1seb+nd865yvQnn/oQbl4NwfTiQKRNhKTuMQbImwpw4zgQIOtgR3NatKorZi8h7Qp+ofQuKLKF399OYltRcEt7NnZ1tUzrtPKoFfrefLF7z/yxUBz9fgxDwtWlshMJdMzmp85wdruA9K8dVdo2m+091prP6pMD2Wg8CXzmFLjkqF9indx2TQpiQmIFgl4L64CVrZwTJ6Z90CDGq6igLhngJ8BepGJLva+sY1xa+UIf4nUKX0K/uDPmd1RZ2xy8wBiZtfnq3vj0isq9IoSxleXo/kA2E6AOu9qNDykMQ1lIm833aJX4FTh08VHw0zO+oVEi7LJrVF7ez+Wr5gKagv5gaMq3lQGM3Tb0T028E6ZGY4w7Ihh8LJLwvo2ct5Tl7V22GFSPzqUIt4KUN6Q4DujmD04o7tXEHYSKq/qDnQq/ba/AfJRZo5jzQOnC3OzKyuEdYCMlCKgeLVRZeARzQ+mfmtT3aaHdOjb+mRTnIk/kyAre9PSW/qNLU6VHkcydIwV2kRczuIvXGIEqBQFQYqveBtCURW56doEYw4c6cC8FvnPgEwuDc5LF4NEWka3nLYXnQaOyA/EoejEzsMPoif/egrhsKVGDgNIYP/F/NIoxK1xbAIZOlJuU7YRt0W5/WbrNmp7usit1OhuEBJLDpJI9DnAXqc1+hRT4HuePY25Ex7Pz6Jd1HA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(2616005)(26005)(6512007)(6506007)(53546011)(186003)(36860700001)(47076005)(2906002)(336012)(5660300002)(40480700001)(40460700003)(8676002)(6862004)(54906003)(41300700001)(316002)(478600001)(70206006)(8936002)(966005)(6486002)(82310400005)(70586007)(4326008)(83380400001)(86362001)(36756003)(33656002)(81166007)(82740400003)(356005)(84970400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 08:11:00.1725
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0762fee4-1799-44f7-c783-08dab1a9755a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7685

Hi Stefano,

> On 19 Oct 2022, at 01:02, Stefano Stabellini <sstabellini@kernel.org> wro=
te:
>=20
> On Mon, 17 Oct 2022, Stefano Stabellini wrote:
>> It should be
>>=20
>> BB_NUMBER_THREADS=3D"2"
>>=20
>> but that worked! Let me a couple of more tests.
>=20
> I could run successfully a Yocto build test with qemuarm64 as target in
> gitlab-ci, hurray! No size issues, no build time issues, everything was
> fine. See:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/3193051236
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/3193083119

Awesome, this is quite fast :-)

>=20
> I made the appended changes in top of this series.
>=20
> - I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
>  registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64

This should already be handle by the Makefile using PUSH or did
you have to modify something ?

> - for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
>  xen.git, not from a copy stored inside a container

Ok

> - when building the kirkstone-qemuarm64 container the first time
>  (outside of gitlab-ci) I used COPY and took the script from the local
>  xen.git tree

Ok

> - after a number of tests, I settled on: BB_NUMBER_THREADS=3D"8" more tha=
n
>  this and it breaks on some workstations, please add it

I will put this by default and leave a command line argument to have a solu=
tion to change this.

> - I am running the yocto build on arm64 so that we can use the arm64
>  hardware to do it in gitlab-ci

I tested this when I made the patches and this works for arm64, arm32 and x=
86 targets on an arm64 machine so go for it.

>=20
> Please feel free to incorporate these changes in your series, and add
> corresponding changes for the qemuarm32 and qemux86 targets.

Will do and I will also add a patch to create the build.yaml entries.

>=20
> I am looking forward to it! Almost there!

Me to :-)

Thanks a lot for the testing and the review.

Cheers
Bertrand

>=20
> Cheers,
>=20
> Stefano
>=20
>=20
> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yoc=
to/build-yocto.sh
> index 0d31dad607..16f1dcc0a5 100755
> --- a/automation/build/yocto/build-yocto.sh
> +++ b/automation/build/yocto/build-yocto.sh
> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal =3D " ssh-p=
regen-hostkeys"
> # Save some disk space
> INHERIT +=3D "rm_work"
>=20
> +# Reduce number of jobs
> +BB_NUMBER_THREADS=3D"8"
> +
> EOF
>=20
>     if [ "${do_localsrc}" =3D "y" ]; then
> diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/auto=
mation/build/yocto/kirkstone-qemuarm64.dockerfile
> index f279a7af92..aea3fc1f3e 100644
> --- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> @@ -16,7 +16,8 @@ ARG target=3Dqemuarm64
>=20
> # This step can take one to several hours depending on your download band=
with
> # and the speed of your computer
> -RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
> +COPY ./build-yocto.sh /
> +RUN /build-yocto.sh --dump-log $target
>=20
> FROM $from_image
>=20
> diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/bui=
ld/yocto/kirkstone.dockerfile
> index 367a7863b6..ffbd91aa90 100644
> --- a/automation/build/yocto/kirkstone.dockerfile
> +++ b/automation/build/yocto/kirkstone.dockerfile
> @@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
>              /home/$USER_NAME/xen && \
>     chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
>=20
> -# Copy the build script
> -COPY build-yocto.sh /home/$USER_NAME/bin/
> -
> # clone yocto repositories we need
> ARG yocto_version=3D"kirkstone"
> RUN for rep in \
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build=
.yaml
> index ddc2234faf..4b8bcde252 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
>     EXTRA_XEN_CONFIG: |
>       CONFIG_BOOT_TIME_CPUPOOLS=3Dy
>=20
> +yocto-kirkstone-qemuarm64:
> +  stage: build
> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> +  script:
> +    - ./automation/build/yocto/build-yocto.sh -v --log-dir=3D./logs --xe=
n-dir=3D`pwd` qemuarm64
> +  variables:
> +    CONTAINER: yocto:kirkstone-qemuarm64
> +  artifacts:
> +    paths:
> +      - '*.log'
> +      - '*/*.log'
> +      - 'logs/*'
> +    when: always
> +  tags:
> +    - arm64
> +
> ## Test artifacts common
>=20
> .test-jobs-artifact-common:



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 08:48:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 08:48:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425661.673618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol4k1-0002Oi-4m; Wed, 19 Oct 2022 08:47:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425661.673618; Wed, 19 Oct 2022 08:47:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol4k1-0002Ob-27; Wed, 19 Oct 2022 08:47:57 +0000
Received: by outflank-mailman (input) for mailman id 425661;
 Wed, 19 Oct 2022 08:47:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=prF/=2U=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ol4jz-0002OV-NW
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 08:47:55 +0000
Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com
 [2a00:1450:4864:20::629])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b88473cf-4f8a-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 10:47:54 +0200 (CEST)
Received: by mail-ej1-x629.google.com with SMTP id r17so38246671eja.7
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 01:47:53 -0700 (PDT)
Received: from [192.168.1.93] (adsl-166.109.242.226.tellas.gr.
 [109.242.226.166]) by smtp.gmail.com with ESMTPSA id
 w22-20020a1709064a1600b0074136cac2e7sm8612834eju.81.2022.10.19.01.47.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 01:47:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b88473cf-4f8a-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=Fn0vkXWE/OgO7OZyVob5cWSHyej/WCT0UHxy2GYCHp4=;
        b=Emsnh+FxiJ3lB1Xe6RkfRkxIT5iuxz0dU0KsvvWhhFoJmkRj+86tj6eyLfc0o5x2zR
         Xpuxbxf7HoP9+bGmvQxYWvpEGxVNbVLCnXE1HP+p33s8+rA3qo24vH/22w3/GSu7b5pD
         STVQvQWhHnlsIiFFDc9xhSeRbAEoLL2OzSL3rS8+VScQSxYkDqODm7vHSqxM0HQmyKlq
         bjm0VKQgagI3tfSg2gtsPaqNaz+exH3W54JnlW7ImE+hKDU+g3Uumx/3UoG9Dk3+/Zlv
         FcjGrh4j1kuI+DT/Pgv/czMCRFSisMOA2+vZUSX0F5/02CcNsUB3de6hYyivhM3gRmqU
         jxWg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Fn0vkXWE/OgO7OZyVob5cWSHyej/WCT0UHxy2GYCHp4=;
        b=5rGRWzjGv8v/IAaKNoH3TTH29D7bx31zJ/xwTTQeIeYY1IERCK+2cj/bZ+KMhNN7rd
         I+aRqHGMJV04ZNCKlytWk3xLsiaJ4o3LNYf7C7x9vLEeA6LaTpCFTNsQ4A3csE3Wvw9I
         3px55mKrr7Hhhwx8vHV7CmVfABsmyZJSmoXgd3rxGLXKAN5Xt4+vsID+hutDh7whBTjj
         wlgidV5vQ9TL9Ssj6R04ammQXLDh1IeGpoXDuZ6gE5v9W/1ZIX8yNMqkXCUkNiFfIkcj
         8xX3dYororX3Lc3uMqqfUe8V09DWs/T4+9Rj9/QHSHDDO4qfVMtyoNlxRkVlsFfBeqze
         LPNQ==
X-Gm-Message-State: ACrzQf1dreqhgOJm1feszRmzAZptQAbOfSEc610PiHC0Xcfv37yuWy3u
	daNzMpGdlGTHHLdqgDJBxXY=
X-Google-Smtp-Source: AMsMyM6S7Wg58ZQT0dZSgmjbSrfnEfkfxXF6anbfyb3hyGKS4y6IJYMBCj+vH7GR82tp8p+9wYrxsw==
X-Received: by 2002:a17:907:3e0f:b0:791:9529:3674 with SMTP id hp15-20020a1709073e0f00b0079195293674mr5663556ejc.503.1666169273367;
        Wed, 19 Oct 2022 01:47:53 -0700 (PDT)
Message-ID: <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
Date: Wed, 19 Oct 2022 11:47:51 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Juergen Gross <jgross@suse.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/19/22 03:58, Stefano Stabellini wrote:
> On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Use the same "xen-grant-dma" device concept for the PCI devices
>> behind device-tree based PCI Host controller, but with one modification.
>> Unlike for platform devices, we cannot use generic IOMMU bindings
>> (iommus property), as we need to support more flexible configuration.
>> The problem is that PCI devices under the single PCI Host controller
>> may have the backends running in different Xen domains and thus have
>> different endpoints ID (backend domains ID).
>>
>> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
>> properties) which allows us to describe relationship between PCI
>> devices and backend domains ID properly.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Now that I understood the approach and the reasons for it, I can review
> the patch :-)
> 
> Please add an example of the bindings in the commit message.
> 
> 
>> ---
>> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
>> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
>> Here, for PCI devices we use more flexible way to pass backend domid to the guest
>> than for platform devices.
>>
>> Changes V1 -> V2:
>>     - update commit description
>>     - rebase
>>     - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
>>
>> Previous discussion is at:
>> https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
>>
>> Based on:
>> https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
>> ---
>>   drivers/xen/grant-dma-ops.c | 87 ++++++++++++++++++++++++++++++++-----
>>   1 file changed, 76 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>> index daa525df7bdc..b79d9d6ce154 100644
>> --- a/drivers/xen/grant-dma-ops.c
>> +++ b/drivers/xen/grant-dma-ops.c
>> @@ -10,6 +10,7 @@
>>   #include <linux/module.h>
>>   #include <linux/dma-map-ops.h>
>>   #include <linux/of.h>
>> +#include <linux/pci.h>
>>   #include <linux/pfn.h>
>>   #include <linux/xarray.h>
>>   #include <linux/virtio_anchor.h>
>> @@ -292,12 +293,55 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>>   	.dma_supported = xen_grant_dma_supported,
>>   };
>>   
>> +static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
>> +{
>> +	struct pci_dev *pdev = to_pci_dev(dev);
>> +	struct pci_bus *bus = pdev->bus;
>> +
>> +	/* Walk up to the root bus to look for PCI Host controller */
>> +	while (!pci_is_root_bus(bus))
>> +		bus = bus->parent;
>> +
>> +	return of_node_get(bus->bridge->parent->of_node);
>> +}
> 
> It seems silly that we need to walk the hierachy that way, but I
> couldn't find another way to do it
> 
> 
>> +static struct device_node *xen_dt_get_node(struct device *dev)
>> +{
>> +	if (dev_is_pci(dev))
>> +		return xen_dt_get_pci_host_node(dev);
>> +
>> +	return of_node_get(dev->of_node);
>> +}
>> +
>> +static int xen_dt_map_id(struct device *dev, struct device_node **iommu_np,
>> +			 u32 *sid)
>> +{
>> +	struct pci_dev *pdev = to_pci_dev(dev);
>> +	u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
>> +	struct device_node *host_np;
>> +	int ret;
>> +
>> +	host_np = xen_dt_get_pci_host_node(dev);
>> +	if (!host_np)
>> +		return -ENODEV;
>> +
>> +	ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask", iommu_np, sid);
>> +	of_node_put(host_np);
>> +	return ret;
>> +}
>> +
>>   static bool xen_is_dt_grant_dma_device(struct device *dev)
>>   {
>> -	struct device_node *iommu_np;
>> +	struct device_node *iommu_np = NULL;
>>   	bool has_iommu;
>>   
>> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>> +	if (dev_is_pci(dev)) {
>> +		if (xen_dt_map_id(dev, &iommu_np, NULL))
>> +			return false;
>> +	} else
>> +		iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>> +
>>   	has_iommu = iommu_np &&
>>   		    of_device_is_compatible(iommu_np, "xen,grant-dma");
>>   	of_node_put(iommu_np);
>> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
>>   
>>   bool xen_is_grant_dma_device(struct device *dev)
>>   {
>> +	struct device_node *np;
>> +
>>   	/* XXX Handle only DT devices for now */
>> -	if (dev->of_node)
>> -		return xen_is_dt_grant_dma_device(dev);
>> +	np = xen_dt_get_node(dev);
>> +	if (np) {
>> +		bool ret;
>> +
>> +		ret = xen_is_dt_grant_dma_device(dev);
>> +		of_node_put(np);
>> +		return ret;
>> +	}
> 
> We don't need to walk the PCI hierachy twice. Maybe we can add the
> of_node check directly to xen_is_dt_grant_dma_device?
> 

I think in general we could pass directly the host bridge device if 
dev_is_pci(dev) (which can be retrieved with 
pci_get_host_bridge_device(to_pci_dev(dev), and after done with it 
pci_put_host_bridge_device(phb)).
So that, xen_is_dt_grant_dma_device() and 
xen_dt_grant_init_backend_domid() won't need to discover it themselves.
This will simplify the code.

> 
>>   	return false;
>>   }
>> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
>>   static int xen_dt_grant_init_backend_domid(struct device *dev,
>>   					   struct xen_grant_dma_data *data)
>>   {
>> -	struct of_phandle_args iommu_spec;
>> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
>>   
>> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
>> -			0, &iommu_spec)) {
>> -		dev_err(dev, "Cannot parse iommus property\n");
>> -		return -ESRCH;
>> +	if (dev_is_pci(dev)) {
>> +		if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
>> +			dev_err(dev, "Cannot translate ID\n");
>> +			return -ESRCH;
>> +		}
>> +	} else {
>> +		if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
>> +				0, &iommu_spec)) {
>> +			dev_err(dev, "Cannot parse iommus property\n");
>> +			return -ESRCH;
>> +		}
>>   	}
>>   
>>   	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
>> @@ -354,6 +413,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>>   void xen_grant_setup_dma_ops(struct device *dev)
>>   {
>>   	struct xen_grant_dma_data *data;
>> +	struct device_node *np;
>>   
>>   	data = find_xen_grant_dma_data(dev);
>>   	if (data) {
>> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>>   	if (!data)
>>   		goto err;
>>   
>> -	if (dev->of_node) {
>> -		if (xen_dt_grant_init_backend_domid(dev, data))
>> +	np = xen_dt_get_node(dev);
>> +	if (np) {
>> +		int ret;
>> +
>> +		ret = xen_dt_grant_init_backend_domid(dev, data);
>> +		of_node_put(np);
>> +		if (ret)
>>   			goto err;
>>   	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>>   		dev_info(dev, "Using dom0 as backend\n");
>> -- 
>> 2.25.1
>>
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 09:07:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 09:07:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425675.673643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol52a-00053u-TO; Wed, 19 Oct 2022 09:07:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425675.673643; Wed, 19 Oct 2022 09:07:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol52a-00053n-Qc; Wed, 19 Oct 2022 09:07:08 +0000
Received: by outflank-mailman (input) for mailman id 425675;
 Wed, 19 Oct 2022 09:07:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rFyQ=2U=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ol52Y-00053h-Uc
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 09:07:07 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2087.outbound.protection.outlook.com [40.107.237.87])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 664904e6-4f8d-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 11:07:05 +0200 (CEST)
Received: from MW4PR04CA0227.namprd04.prod.outlook.com (2603:10b6:303:87::22)
 by MN2PR12MB4127.namprd12.prod.outlook.com (2603:10b6:208:1d1::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 09:07:02 +0000
Received: from CO1NAM11FT042.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:87:cafe::59) by MW4PR04CA0227.outlook.office365.com
 (2603:10b6:303:87::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 09:07:01 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT042.mail.protection.outlook.com (10.13.174.250) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 19 Oct 2022 09:07:01 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 04:07:00 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 04:06:38 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 19 Oct 2022 04:06:37 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 664904e6-4f8d-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nyyn6//JrE9e/On1w/ZQ5kryvvmc+Qh7a1AqsYGHrLcs12NJHkQQKF3bFrtj9E8/2NZlpUP1VxMbF5RpqfEL8R2VFsSL3nB8D5xkX/eRqiqboDJyovhdn86re7U3J9JWGTaZJJ7Zn3/eN+Qh+W29cf5+qwU+iRk7W6Z1lO13rgWZPapNZH1hpyN1dTrb2UQ9Qu99oKrP9WxCvrjDKitzMqsmgdVWlLXTNbiRW1jdbmm1uwsx46QM17kz8SPoGh/OBUJi/vP9Vrpwx/4weeUuM9w97sYqeD+dk5OvxkXnZsHRxYLErrjoUsBuZFlVC82HT+f/S6ECE6/aMTOi9N5ooA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s2pVKOxocZIZCBd4njKlEy+jDzbfa8B8TJzQnz4hs1E=;
 b=iQip9Uc+a6/bqerxVcp4XmVn6Dxxfd+8tkskEpMp6+k6w0nOsVnpKOq0CEXC5kX7H97URsEGvlqbPqiL+nz0y2eP8nPxX2YJcfLOQ4P7fNyFUkOEaLclRKigGroVQVvbWz32flCc9Fw5v2jQzeu/k5kNrCJnqF/LRogf4clkIw17ZCLo4YoKqXFRDnJxyMku/LWWCy/mzdL443QPdLSDjidSvSBI3Yo01/XgD7lInhEwdGgbVjK1zTYrKp8SloKpy0a9pyLjxczj+EBnH7nNcQ7VnGYqO/W3H5CSO7g+eA/lS4NtLRtoDGl8083lT5u2qnJQd1lqR8SeBrjBT/UClw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s2pVKOxocZIZCBd4njKlEy+jDzbfa8B8TJzQnz4hs1E=;
 b=uVwLCOKucjC1ODU4HPa7XVp//aja5VF6i1h+e2rdunMmSFLHDDLdPIczMWHUWwoAkTTmgqG7wkHPf+2SsmiFpfkGY8DA225193BPUFTcrZP8zeNOJSUd1wUy+z0qLDEaQLfbSyQh2pI3bFJjGaJPa+eNgzIv1EPOSzx2a4nHRzY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <56155bff-6229-05a4-7221-cd6aa5a1de8b@amd.com>
Date: Wed, 19 Oct 2022 11:06:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Doug
 Goldstein" <cardoe@cardoe.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
 <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
 <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT042:EE_|MN2PR12MB4127:EE_
X-MS-Office365-Filtering-Correlation-Id: 53bba205-df68-4a82-776e-08dab1b148c9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D+iJXzDyd1lkU9emUuGgdLcriBrOVwMlmOC76RWc4I79ddVMvyb86Prd3huWyIjeXBNJxv1ylSPPtAHjPxkQfFNi8Eyu7TsOdtfdYvCkUfowZkThfd0+5y52eBkseP4JMQ/2LtNxPmb/k7w0/5t1xg8fMI+Ac/2x+KYPGm09piR+2UgwQF9cFEcnHnBJTCTUZ4LTWhHVfgj2v4deX5sfU4w0SJ0svTYN4oTOHjFhMMqxAwjJWi4WjMrr67oUE95QPSxlNHgkk6AmP2J9NcWaR5B6EaiMKe0W+BsUliMoQiDu4Ta+2wOEM91pYR56ROgJJ/DiHOy3MBTDtYLKdfpUbaK8BPpo2ZlSLWdyaR4Bt89WBsXCe6jf8/xiCsRosVYgjLjBchP5bcMjqeZKP9Vb0KiecpFRvSCL5U6zY6kzLsYRYlbsliZVY/tCi6wTcUIH4V2TeJVL2u/ix/jOtqcig9AtW0PWul0ySrqz3LSCVV1YUM5bPU3pX9yhVVtX+Ccnw8YvJ7K/VwiSHZF8p0IjiOzwYxZ/5VzC+QBLjQJSTf+mlFzU2DqKzURjB5ipT4XJIleQfqHkpnHkydpTTDPyy9ClvPO6kR1EQz+Ppc+Pi2kyslHKYZswM1bczhsbHvQC4/cB7c8S5881atb9YIfzmrY6ju1Ab8on7JWKsDvZlMgNoabV/x3HnF5AKD2PV0JhX+WiRhh5DLrTi3LHQ+lGFp2IBME+fjlnzBbCUa7/EI09dIlwiTOucO6Y0NsvGXAYPtl8duBwWFwoUmzRp+/T95t0e253swgr11ViXoYeixN4GC08TGYATC+vPrgr3P66w1cm3Lpm14zdXAAXZnvemxCrQSGzdCzU9zCBGRsz2pu17xiNinbIcaJvzh3fYmYjAvb1nNkyzpbWP0tergccFg==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(40470700004)(46966006)(36840700001)(31686004)(478600001)(45080400002)(83380400001)(86362001)(31696002)(84970400001)(966005)(70586007)(36756003)(70206006)(53546011)(8676002)(316002)(41300700001)(26005)(16576012)(8936002)(44832011)(6916009)(4326008)(54906003)(5660300002)(40480700001)(47076005)(426003)(82310400005)(2616005)(2906002)(40460700003)(186003)(336012)(82740400003)(356005)(36860700001)(81166007)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 09:07:01.3274
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 53bba205-df68-4a82-776e-08dab1b148c9
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT042.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4127

Hi Stefano,

On 19/10/2022 02:02, Stefano Stabellini wrote:
> 
> 
> On Mon, 17 Oct 2022, Stefano Stabellini wrote:
>> It should be
>>
>> BB_NUMBER_THREADS="2"
>>
>> but that worked! Let me a couple of more tests.
> 
> I could run successfully a Yocto build test with qemuarm64 as target in
> gitlab-ci, hurray! No size issues, no build time issues, everything was
> fine. See:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193051236&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C75ea919bbde249e1bac408dab1654960%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017345841386870%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=oWrGVbloqkJoOxvvxTr55RbKVzd3YmS4iiLPyxDZCYY%3D&amp;reserved=0
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193083119&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C75ea919bbde249e1bac408dab1654960%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017345841386870%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=%2BXf3ZB1bsVi8K%2BzEEe1Dhpg0GSohpseogff12GaK3Gw%3D&amp;reserved=0
> 
> I made the appended changes in top of this series.
> 
> - I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
>   registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64
> - for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
>   xen.git, not from a copy stored inside a container
> - when building the kirkstone-qemuarm64 container the first time
>   (outside of gitlab-ci) I used COPY and took the script from the local
>   xen.git tree
> - after a number of tests, I settled on: BB_NUMBER_THREADS="8" more than
>   this and it breaks on some workstations, please add it
> - I am running the yocto build on arm64 so that we can use the arm64
>   hardware to do it in gitlab-ci
> 
> Please feel free to incorporate these changes in your series, and add
> corresponding changes for the qemuarm32 and qemux86 targets.
> 
> I am looking forward to it! Almost there!
> 
> Cheers,
> 
> Stefano
> 
> 
> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
> index 0d31dad607..16f1dcc0a5 100755
> --- a/automation/build/yocto/build-yocto.sh
> +++ b/automation/build/yocto/build-yocto.sh
> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
>  # Save some disk space
>  INHERIT += "rm_work"
> 
> +# Reduce number of jobs
> +BB_NUMBER_THREADS="8"
> +
>  EOF
> 
>      if [ "${do_localsrc}" = "y" ]; then
> diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> index f279a7af92..aea3fc1f3e 100644
> --- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> @@ -16,7 +16,8 @@ ARG target=qemuarm64
> 
>  # This step can take one to several hours depending on your download bandwith
>  # and the speed of your computer
> -RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
> +COPY ./build-yocto.sh /
> +RUN /build-yocto.sh --dump-log $target
> 
>  FROM $from_image
> 
> diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
> index 367a7863b6..ffbd91aa90 100644
> --- a/automation/build/yocto/kirkstone.dockerfile
> +++ b/automation/build/yocto/kirkstone.dockerfile
> @@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
>               /home/$USER_NAME/xen && \
>      chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
> 
> -# Copy the build script
> -COPY build-yocto.sh /home/$USER_NAME/bin/
> -
>  # clone yocto repositories we need
>  ARG yocto_version="kirkstone"
>  RUN for rep in \
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index ddc2234faf..4b8bcde252 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
>      EXTRA_XEN_CONFIG: |
>        CONFIG_BOOT_TIME_CPUPOOLS=y
> 
> +yocto-kirkstone-qemuarm64:
> +  stage: build
> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> +  script:
> +    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
> +  variables:
> +    CONTAINER: yocto:kirkstone-qemuarm64
> +  artifacts:
> +    paths:
> +      - '*.log'
> +      - '*/*.log'
The above lines are not needed as the logs/* below will handle them all (logs are only stored in logs/).

> +      - 'logs/*'
> +    when: always
> +  tags:
> +    - arm64
> +
build-yocto.sh performs both build and run actions. I think it'd be better to move this into test.yaml in that case.
The best would be to create one build job (specifying --no-run) in build.yaml and one test job (specifying --no-build) in test.yaml.
This however would probably require marking path build/tmp/deploy/***/qemuarm64 as an build artifact. The question then is
whether having this path would be enough for runqemu (Bertrand's opinion needed).

Apart from that there is an aspect of Yocto releases and the containers/tests names.
Yocto needs to be up-to-date in order to properly build Xen+tools.
This basically means that we will need to update the containers once
per Yocto release. The old containers would still need to be stored in our CI container registry
so that we can use CI for older versions of Xen. However, updating the containers would also require
modifying the existing tests (for now we have e.g. yocto-kirkstone-qemuarm64 but in a month we will have
to change them to yocto-langdale-qemuarm64). In a few years time this will result in several CI jobs
that are the same but differ only in name/container. I would thus suggest to name the CI jobs like this:
yocto-qemuarm64 (without yocto release name) and define the top-level YOCTO_CONTAINER variable to store
the current yocto release container. This will solve the issue I described above.


~Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 09:09:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 09:09:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425681.673654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol557-0005dF-A4; Wed, 19 Oct 2022 09:09:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425681.673654; Wed, 19 Oct 2022 09:09:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol557-0005d8-7A; Wed, 19 Oct 2022 09:09:45 +0000
Received: by outflank-mailman (input) for mailman id 425681;
 Wed, 19 Oct 2022 09:09:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lfqm=2U=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1ol555-0005d2-4D
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 09:09:43 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c37dbbd1-4f8d-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 11:09:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 62F9C6187F;
 Wed, 19 Oct 2022 09:09:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49A47C433D7;
 Wed, 19 Oct 2022 09:09:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c37dbbd1-4f8d-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666170579;
	bh=WOtLqPtfTzhG6xYKuXLzf9SXFlrNx350kTurMW1iEWw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=FKrkq4mxl7UzWAyUXth0fYW43x5dhgids6rAsLpKKl9ExuG+YJ4gAIe3baLB+TKdo
	 MGfLJ1/67Ht6N1AARsFqPu0sLeL3Vbzpd4C1gmpx5Fp/LPj0oJIBqdBPVugqUUP/LH
	 gPNcImneQBiLWeW697ON9gShNI+BBoJCeoxOyoa4=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 6.0 676/862] x86/entry: Work around Clang __bdos() bug
Date: Wed, 19 Oct 2022 10:32:43 +0200
Message-Id: <20221019083319.836953318@linuxfoundation.org>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221019083249.951566199@linuxfoundation.org>
References: <20221019083249.951566199@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 0ed2e487a693..9b1a58dda935 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -765,6 +765,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -774,7 +775,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Wed Oct 19 09:10:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 09:10:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425687.673666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol55s-000728-NF; Wed, 19 Oct 2022 09:10:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425687.673666; Wed, 19 Oct 2022 09:10:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol55s-000721-Ii; Wed, 19 Oct 2022 09:10:32 +0000
Received: by outflank-mailman (input) for mailman id 425687;
 Wed, 19 Oct 2022 09:10:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=illN=2U=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ol55r-0005xH-9z
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 09:10:31 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2084.outbound.protection.outlook.com [40.107.104.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e0d293b7-4f8d-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 11:10:30 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8441.eurprd04.prod.outlook.com (2603:10a6:102:1d8::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 09:10:28 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 09:10:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0d293b7-4f8d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cDTVYknjCo30d6W/D4gRIUGgggo+ukK5DN0rn2eRVO9JPE8/IYbBQTnfpAXVuMjH82HpP7x/Xx0i4TzbQskY73XtBBBhyYkaoAQeWDnQQ//pqQgJ6wJ8uxmGUi7WuraKuvDyXOn+eEpfPtjAaqXoqZTeYrSz+04dXBA1I3gHaNhk9ErIYzwjED3kQrwSMdy9+/BY6aibNnVXlat0sSd/2pW3JEfSey3mKGERtuzFJIaGzhRlLEkziDo/gXdKA20kzYawWdPKsUVroucuIM8/ar8dY4YxFOLbcgSrJH8hzIW8FmkH/guoN3lrB/qLmKE1vYW0Ef1+L5evzfMKMwnxsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/MloKwlUFSPntwzhcL0PjnY/XkLE3GPSbgNrfJeplII=;
 b=OFrtm/+bttC1fctpc+PSDEQ3sjfvwckoNmGhob69fHRYw32lTm/2J9F9Xr3GKUvnUl1nqr5UtLcFBfUWN6lc4BMS/QRxdcysD9r359Chfp6TK47vRHyhf7ul7xaNNv8RJeXUDgB6YqVfYtyj10+Wi94zRak2OzeAM7U2j0lLD3jFqqTnZFbW4TToPBUR1QnEPPUhfH8yWzJh68kbPy9AAUM3pXtjbXiteWq/Zn7HxWly3DpJOBf58dji+w6Fh7KGPKvgOaEzBOROnz6Mtwy2gHa/LQHFYxMInc+5yOkk/m30aEpulcq2OT4P+AvPhtMGohcpvrSMnmU1X5WBT5tdoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/MloKwlUFSPntwzhcL0PjnY/XkLE3GPSbgNrfJeplII=;
 b=N43WCyklMzqPAR983Zesz2Pjcw/hKUxI9OvzxAkVtoVOK/ZTPMSSMcFF5WArb5VdX20WfYjkuVM6KVXCwHQTMO1EwX0Tm5K9KzwPa4MDgxA+lLQcSMHOyftWgh5ojwmCoGbLIEh/PuDUvwrUhmmGcEZ7LGEvtl/8Rg5JVbK/OWUzPU+UXYJG7xXmT4/++DnXyUlYLiWG8KPdedZRPGOVMNI9yo672i494HRgAoNaynccCB6lGSBlKMJCvDy+bG4qd8qEQI953lzkqFeqgJ5kzYoyG5EV6ETMWTOG+O/aCHyIQMC6HHXPJ5WBockoVkShhKNRcgcLvS1Ti/Efuyoy/Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1bc4414f-1009-2073-ea56-9b772a7189b1@suse.com>
Date: Wed, 19 Oct 2022 11:10:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 1/2][4.17] x86emul: further correct 64-bit mode zero count
 repeated string insn handling
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4ca86bb6-ca6e-0c6f-448a-55fb73a3c02a@suse.com>
 <1dac86de-cb8c-d2b2-d0ab-bf76707d22d0@suse.com>
 <9c407e09-4af8-b021-293d-b1db8a0ca4f9@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9c407e09-4af8-b021-293d-b1db8a0ca4f9@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8441:EE_
X-MS-Office365-Filtering-Correlation-Id: 9527f916-8c94-4ba4-1b77-08dab1b1c399
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iEyPpE/kBa5quD2SEX0ydABNr3bzbIVi1dxBNbpSor3RS3F+mF8Hg+xjegZVoqiWKXYhO/QV492Tbxkn4SsTADvUAq5Rf9QCggJ2GD7atPbo+KbJxz8Jx7zut6CNfoUFto6jVa2z0xCUIZjUpMYUR5fk64508RM/e5PEb9+Oy34EVl4fG9zlzmTaxTlo8gVXWtJuvlzmBHyS/xj21nMlrMy7UcCbCCx7cFfwTd9HqtiIUMnHsz8JgqQO355uSMc1bokpsiP9q9bbbg66NGjeeiW9ZhGL9/Tx2epbVpZUaHRrpf35aK2lypVCeq3qHENAiD+Fl6ttkzgGiXKHwfd7v94T62ItFDju9gZ3yyAXxXyOguu6fND/HjjygecFWUNw1hihq1tkM5HAOA3msmSEgBspT2My4xeVJcHI7zJk7RDibvGdVs+iZs98OC8RdON7OekO8WmWdVaKaTBYwd+SfwUv8Pts1QJ+DkE1VdbRc00vw93KLbOnmGoHoV8bfmnYl/c2x8c9O3u5Q1AOsljDrS9k0EEq0GbABeic86ouTpHHuRV62KtK17X6oOBzhXaozIFvvuTbGncDuFSjNT+D8KC5r+Jlm2X8ledcjOXflnGxwHz6OT7bm5iOqYTXRfDSBOWQ0JZjUm+R+pea1qsUU844VAHY65x1v9zHntOB0AVPIAXmgNpgRfoyo3yKjFRrh49y0sV1qmwxFSXVsQeqCEnKPKIPr/CsdOMmfhSBFxHs3ERD0WkIRsaz8FFwiXyD0ugQK5DsOKRWnfjyzjoGpU2YtXHSrK+LIEHzSd+BUH0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(136003)(346002)(39860400002)(376002)(451199015)(83380400001)(36756003)(31696002)(86362001)(38100700002)(66556008)(316002)(6916009)(54906003)(31686004)(5660300002)(8936002)(186003)(66476007)(2906002)(6506007)(2616005)(53546011)(66946007)(478600001)(6512007)(6486002)(26005)(41300700001)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWRVa0VFRXVqVGk1UGw5T1RrUmlxTDFWR3pqYTJDQi96dXZkb29pMWptREhp?=
 =?utf-8?B?SnRoOUNWRW1INWFnT21rRm84TTFlWkprWThPWHpiUU5NRlErNGpjOXZYUCt1?=
 =?utf-8?B?eTNRUElEejJ4R1RKaGFKMEU1VmdOWWZPY0pHV1hWNHhpYVVDaUlJa3RGSUtG?=
 =?utf-8?B?RHdFcnUzUXRoUE5ndVJHQWRWeFZXWENRNGl3MDZmNXFEczdwVzJGRXBzQncz?=
 =?utf-8?B?VHJBN2xXQ1VPK1orNlhEYi94b1paNCtPVXZyL0ZJWGJvMkFpNWxFb29RR1c2?=
 =?utf-8?B?WnF3eTlJb1NNUEJPQnVJTjluODcrSjB5WjM4YzFPSWFYNy8yUlBtZlg3NzJQ?=
 =?utf-8?B?WkZzR1BUM3FnWmkwUlVRMWJxVERvVytReG5GUGJvekZyRzN5Rk10NUxzZTBL?=
 =?utf-8?B?eTVVV1A5NG81YVNhSW9mV2R5ZWVBalFXaHMvYWZJaVdpSjJHMDVFMUk2Z2V1?=
 =?utf-8?B?a1VVNG1xUkxoZDh6SjVlTjczc0Q5cThMYXNycXRtUktJcGFSWFJZNkR1bW1V?=
 =?utf-8?B?NG5TZHFjN0RUaVhiMDZBc3NOd01kZGNUNGZIWWdBSkJwck1jY0s5ajFvek50?=
 =?utf-8?B?MUNwbmlSNlNsK3BRTVd5ZDdKbXp6TWw1WDVmc0ZFeEZDNUJwVHVDSHpYTmNB?=
 =?utf-8?B?Z3JkRktMd3FPdGJ1Zk1mUjVPTjJxeWZtcnNFTnI4cWl1TlVaN3k2K1oyUG9l?=
 =?utf-8?B?RTgrMlV6S2J6MFNGaklvcGg0K0hpK3F6WHVnaDU5MGM5WEdtY0JYdTB5Qkpi?=
 =?utf-8?B?SHVVY1QxeGpobHJISGpBckYwNW5CcnA2MGo0ZEtjdFU3WGQzeXNYOWtiVnhk?=
 =?utf-8?B?NjdkelhCUmF6THp5Q25TYjRvdGFYVW5STTBjY1BSWUpsYk9RL2NKRkZYZUxz?=
 =?utf-8?B?VmhvdHN0dzdBMTV4bUxhWmhPU1JDem1xREpHbmJxa1BSRWpPYm84bDNMaUlI?=
 =?utf-8?B?NENjeThZdDB3TVl3eUwwWE4xRVozS2x5RURuWFJ3T24xRlpqZ24veEgzTDd3?=
 =?utf-8?B?SElKZHc0YndFTG81RE1vLzQ1b2xUUDdKWC9FL3V1LzdJK0pRZkFDNDFxdzlQ?=
 =?utf-8?B?bXRXRWxDM0R1MUd1SEw3bHErbFR4dHZ6MFJyUFl1cUtxY0pWWjRnS3FXY0Fx?=
 =?utf-8?B?dnJRSnhLY1VXSmRGQnJKSDRXNENOYlBtQmZDRkw3NC9KbVpnbFFoSEM0VjVY?=
 =?utf-8?B?L0NhOXJaS0NjdHVEREZ5R3dWWFBFTkFPQUNIZ1Ixa2VwMDZrZXBraEtSd1B4?=
 =?utf-8?B?SnZpbFB1MlRUVGV3ZjFRdUZLdVJIaHdrbzNkSzBSNHNGOVlXTUdBSERsMVpi?=
 =?utf-8?B?T1htV1ExS0JDV3l6R29hTDRKbm96aFdjaTIzZytJR2ZWZzJSdjA5MENRYWRQ?=
 =?utf-8?B?czBhU1ljZjJQOTNkOGsxZHJTRlBrNE42U3JQZ0VmdUlqbjBDck96M1RRS3py?=
 =?utf-8?B?SzdHcjNmRGhucTZlUTNGWG9mamlvdXFSR21IOU1LcTdwdDMxUzM1ZGFOMTF5?=
 =?utf-8?B?R2Z6QVp6MlpoN1JrWG55RGV3Y0pzbk1kUVY1RzZDSzlEM01tKzRYdEZDYVB3?=
 =?utf-8?B?NFF4YU9hL1JhdmpLMHpaMjAyR0p1T1l2UTlJLzRYejc2TGtNeGlEL2Qra1ZF?=
 =?utf-8?B?aG1tRlVRN2EzNi9nL1BsZTIyNVcxakVNVUVTQ0hPUXF0NUxxck9qdXRybjFH?=
 =?utf-8?B?MXZicHlGK2FwYmt6MlRWK3U5bllSSE4xdGNpbnFmMnB3U3REbmtwYXdteUZm?=
 =?utf-8?B?QWcrSTEwVFlWQ1FUTUlKYTdwL3Bjdy8zaUZ4Nk9tWlUzUElkNGNGM0ZKNVlz?=
 =?utf-8?B?Z3hEVkxOSktvQnl2U2pWbzFEdEkxVTVNTTFzdGd3NnZBaXErN0VOSVdpaXpO?=
 =?utf-8?B?R3hQMlFmYmxySkQ1SEcvaU1wMmdabGZCaUlmSzN6NDFCVld4YW9UdWFKZzF5?=
 =?utf-8?B?K1Bmc3A5M3ptL3BUOFZXMW9yVUNVNU9hRzRJUGlGejZadHgyN05ZeXJ6VXp4?=
 =?utf-8?B?YVpiSWk2aG80OEsxYTVhMXhYaXZGSERpZjUycW9vdis0SE9aS1ZHUkc2U0JO?=
 =?utf-8?B?M2MzQXRVOEl2T2o2aVBMQk5GRTE3Sk1mVEZrRzFFenpnNHhXRjhCQys3UXlu?=
 =?utf-8?Q?CplIVyCxllcIPwNsRvA9B49oV?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9527f916-8c94-4ba4-1b77-08dab1b1c399
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 09:10:27.7296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vzJdbABzPPnH9cg6Qv76JD+PWXov6aOCLtGVtA32iqByFXueHZIvjt5tKXsOC0hwN3gHiEQ1z31t1q6h5YmG5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8441

On 10.10.2022 20:56, Andrew Cooper wrote:
> On 06/10/2022 14:11, Jan Beulich wrote:
>> In an entirely different context I came across Linux commit 428e3d08574b
>> ("KVM: x86: Fix zero iterations REP-string"), which points out that
>> we're still doing things wrong: For one, there's no zero-extension at
>> all on AMD. And then while RCX is zero-extended from 32 bits uniformly
>> for all string instructions on newer hardware, RSI/RDI are only for MOVS
>> and STOS on the systems I have access to. (On an old family 0xf system
>> I've further found that for REP LODS even RCX is not zero-extended.)
>>
>> Fixes: 79e996a89f69 ("x86emul: correct 64-bit mode repeated string insn handling with zero count")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Partly RFC for none of this being documented anywhere (and it partly
>> being model specific); inquiry pending.
> 
> None of this surprises me.  The rep instructions have always been
> microcoded, and 0 reps is a special case which has been largely ignored
> until recently.
> 
> I wouldn't be surprised if the behaviour changes with
> MISC_ENABLE.FAST_STRINGS (given the KVM commit message)

I've tried this on a Skylake, and things don't change there when forcing
the MSR bit off.

Jan

> and I also
> wouldn't be surprised if it's different between Core and Atom too (given
> the Fam 0xf observation).
> 
> It's almost worth executing a zero-length rep stub, except that may
> potentially go very wrong in certain ecx/rcx cases.
> 
> I'm not sure how important these cases are to cover.  Given that they do
> differ between vendors and generation, and that their use in compiled
> code is not going to consider the registers live after use, is the
> complexity really worth it?
> 
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 09:49:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 09:49:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425696.673683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol5hT-0002DI-Kn; Wed, 19 Oct 2022 09:49:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425696.673683; Wed, 19 Oct 2022 09:49:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol5hT-0002DB-I9; Wed, 19 Oct 2022 09:49:23 +0000
Received: by outflank-mailman (input) for mailman id 425696;
 Wed, 19 Oct 2022 09:49:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ol5hS-0002D5-7d
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 09:49:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ol5hM-0000EO-SK; Wed, 19 Oct 2022 09:49:16 +0000
Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.0.59])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ol5hM-0007JZ-KS; Wed, 19 Oct 2022 09:49:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=bfLfUI5VV/aiOPg3GhIqLRIMALZTgk/QoebBxXK1huM=; b=R/sNYXaKXsGrijxYxCqDDX2I7t
	0Xkr0UBz4xOrhDWGa/Lo1xcTpqkpq9+Eihd3AfGQYNA5YxOBe1cWU75pgSkK5SQTR4JxPRlv4tTUw
	CDF0QM/ueCJ7slJzr2HuYsN3q5cadmWkcaD2IaT75vCOtXXQE0k0r0TWv9sQmhG87iGA=;
Message-ID: <2abb8f7d-fcf8-7ed6-b180-a715b5d6a5ba@xen.org>
Date: Wed, 19 Oct 2022 10:49:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org,
 stefano.stabellini@amd.com, Peter Maydell <peter.maydell@linaro.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com>
 <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
 <alpine.DEB.2.22.394.2210171345450.2351079@ubuntu-linux-20-04-desktop>
 <460a480e-4e91-8d78-60da-59b9cc98beee@xen.org>
 <alpine.DEB.2.22.394.2210181241320.4587@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2210181241320.4587@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 19/10/2022 01:15, Stefano Stabellini wrote:
> On Tue, 18 Oct 2022, Julien Grall wrote:
>> On 18/10/2022 02:26, Stefano Stabellini wrote:
>>> On Sun, 16 Oct 2022, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> There seem to be some missing patches on xen-devel (including the cover
>>>> letter). Is that expected?
>>>>
>>>> On 15/10/2022 06:07, Vikram Garhwal wrote:
>>>>> Add a new machine xenpv which creates a IOREQ server to register/connect
>>>>> with
>>>>> Xen Hypervisor.
>>>>
>>>> I don't like the name 'xenpv' because it doesn't convey the fact that some
>>>> of
>>>> the HW may be emulated rather than para-virtualized. In fact one may only
>>>> want
>>>> to use for emulating devices.
>>>>
>>>> Potential name would be 'xen-arm' or re-using 'virt' but with 'accel=xen'
>>>> to
>>>> select a Xen layout.
>>>
>>> The benefit of 'xenpv' is that it doesn't require any changes to libxl.
>>
>> I am quite surprised. Looking at the code, it seems to work more by chance
>> than it is intentional as the code is gated by libxl__need_xenpv_qemu(). So it
>> would not start if there were no emulated devices.
>>
>>> It is even backward compatible so it could be used with an older version
>>> of Xen/libxl.
>> We don't really gain much here. IOREQ is a tech preview and anyone that wants
>> to try it should really use the latest Xen.
> 
> I think that's fair.
> 
> 
>>> Backward compatibility aside, if we come up with a
>>> different name then we'll need changes to libxl and to manage those
>>> changes. For instance, if we use 'xen-arm' that would mean we would need
>>> to handle per-arch QEMU machine names.
>>
>> Right, so the main argument here is for simplicity in libxl
> 
> Yeah
> 
> 
>> Looking at how 'xenpv' is built, this is really expected to deal with PV
>> backend rather than emulated device. I do expect some changes as we go along
>> to be able to add emulated device.
>>
>> Furthermore, libxl is not the only toolstack out. So I am not convinced this
>> is a good argument to keep the name the same.
> 
> Let's think some more about the naming strategy. From a QEMU point of
> view we could choose any name we like (Vikram please confirm), the issue
> is really on the libxl side.
> 
> Today libxl understands two QEMU "machines": xenpv and xenfv
> (pc,accel=xen is the same as xenfv, I'll use xenfv in this email for
> simplicity).
> 
> xenpv is for PV guests and only provides PV backends, no emulation. It
> is used on both ARM and x86.
> 
> xenfv is only used on x86, and it is for HVM guests, with a full set of
> emulated hardware (PIIX3, etc.).
> 
> The purpose of this series is to introduce a QEMU machine that:
> - works on ARM (but could maybe work on other archs as a stretch goal)
> - provides PV backends
> - no emulated devices by default
> - also can emulate selected devices on request
> 
> Certainly it is not xenfv or pc,accel=xen because they would with more
> emulation by default. This is more like "xenpvh": an extension to PV
> with also the capability of emulating one device as requested. It is not
> intended to emulate a full PC and doesn't do that by default like xenfv.

The definition of "full PC" is not very clear for me. Unlike x86, Arm 
doesn't have legacy devices that needs to be emulated. So technically, 
if we emulated one network card and one block device, then we would be 
able potentially be able to boot an unaware OS on Xen on Arm. This would 
be the same as if you passthrough-ed the two devices.

In the past, I have seen interest to boot OS like Windows OS/iOS on Arm. 
I do expect that the addition of a Xen platform in QEMU will lead to 
another increase of the interest because we could expose anything to the 
VM. Although, it might need some tweak in Xen to allow more dynamic 
layout just in case an OS doesn't discover dynamically devices.

> 
> If/When x86 PVH gains the ability to use QEMU as IOREQ server, I would
> imagine it would run a QEMU machine similar to this one.
To me it would sounds odd to add emulated devices in the 'xenpv' because 
they would only work for PVH domain. AFAIK, QEMU doesn't know whether a 
domain is PV or PVH. So we would solely rely on IOREQ to return an error.

> 
> This is also how I would imagine it would get integrated in libxl: as a
> xenpv + individual emulated devices. Not as HVM for ARM. The other QEMU
> command line arguments are inline with the xenpv command line arguments
> rather than xenfv command line arguments. This is why the libxl changes
> are small to zero to make it work today.
> 
> So, I think the following options work:
> 
> a) call it "xenpv" because it is an extension of the old xenpv machine
> b) call it "xenpvh" because it is PV + few individual emulated devices
> 
> If we call it xenpv there are fewer changes in libxl. If we call it
> xenpvh there are more changes in libxl but we can distinguish xenpv from
> xenpvh (I don't see why we need it right now, but I could imagine it
> could turn out useful in the future.)

IMHO, we need to plan for the future.

> 
> I would stay away from arch-specific machine names because it will make
> it harder on the libxl side without immediate benefits.

If the name is the only change, then I would expect this could be done 
with a per-arch define. So that would be a few lines change maximum.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 09:58:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 09:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425702.673694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol5pm-0003hl-E9; Wed, 19 Oct 2022 09:57:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425702.673694; Wed, 19 Oct 2022 09:57:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol5pm-0003he-BL; Wed, 19 Oct 2022 09:57:58 +0000
Received: by outflank-mailman (input) for mailman id 425702;
 Wed, 19 Oct 2022 09:57:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Se4D=2U=virtuozzo.com=alexander.atanasov@srs-se1.protection.inumbo.net>)
 id 1ol5pl-0003hY-1w
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 09:57:57 +0000
Received: from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80ca944c-4f94-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 11:57:55 +0200 (CEST)
Received: from dev011.ch-qa.sw.ru ([172.29.1.16])
 by relay.virtuozzo.com with esmtp (Exim 4.95)
 (envelope-from <alexander.atanasov@virtuozzo.com>)
 id 1ol5lV-00B8K8-SR; Wed, 19 Oct 2022 11:56:24 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80ca944c-4f94-11ed-8fd0-01056ac49cbb
From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
To: 
Cc: kernel@openvz.org,
	Alexander Atanasov <alexander.atanasov@virtuozzo.com>,
	kernel test robot <lkp@intel.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Wei Liu <wei.liu@kernel.org>,
	Nadav Amit <namit@vmware.com>,
	pv-drivers@vmware.com,
	Jason Wang <jasowang@redhat.com>,
	virtualization@lists.linux-foundation.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Dexuan Cui <decui@microsoft.com>,
	linux-hyperv@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	xen-devel@lists.xenproject.org
Subject: [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to the rest of the kernel
Date: Wed, 19 Oct 2022 12:56:12 +0300
Message-Id: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
inflate and deflate the guest memory size but there is no
way to know how much the memory size is changed by them.

Make it possible for the drivers to report the values to mm core.

Display reported InflatedTotal and InflatedFree in /proc/meminfo
and print these values on OOM and sysrq from show_mem().

The two values are the result of the two modes the drivers work
with using adjust_managed_page_count or without.

In earlier versions, there was a notifier for these changes
but after discussion - it is better to implement it in separate
patch series. Since it came out as larger work than initially expected.

Amount of inflated memory can be used:
 - totalram_pages() users working with drivers not using
    adjust_managed_page_count
 - si_meminfo(..) users can improve calculations
 - by userspace software that monitors memory pressure

Alexander Atanasov (8):
  mm: Make a place for a common balloon code
  mm: Enable balloon drivers to report inflated memory
  mm: Display inflated memory to users
  mm: Display inflated memory in logs
  drivers: virtio: balloon - report inflated memory
  drivers: vmware: balloon - report inflated memory
  drivers: hyperv: balloon - report inflated memory
  documentation: create a document about how balloon drivers operate

 Documentation/filesystems/proc.rst            |   6 +
 Documentation/mm/balloon.rst                  | 138 ++++++++++++++++++
 MAINTAINERS                                   |   4 +-
 arch/powerpc/platforms/pseries/cmm.c          |   2 +-
 drivers/hv/hv_balloon.c                       |  12 ++
 drivers/misc/vmw_balloon.c                    |   3 +-
 drivers/virtio/virtio_balloon.c               |   7 +-
 fs/proc/meminfo.c                             |  10 ++
 .../linux/{balloon_compaction.h => balloon.h} |  18 ++-
 lib/show_mem.c                                |   8 +
 mm/Makefile                                   |   2 +-
 mm/{balloon_compaction.c => balloon.c}        |  19 ++-
 mm/migrate.c                                  |   1 -
 mm/vmscan.c                                   |   1 -
 14 files changed, 213 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/mm/balloon.rst
 rename include/linux/{balloon_compaction.h => balloon.h} (91%)
 rename mm/{balloon_compaction.c => balloon.c} (94%)

v4->v5:
 - removed notifier
 - added documentation
 - vmware update after op is done , outside of the mutex
v3->v4:
 - add support in hyperV and vmware balloon drivers
 - display balloon memory in show_mem so it is logged on OOM and on sysrq
v2->v3:
 - added missed EXPORT_SYMBOLS
Reported-by: kernel test robot <lkp@intel.com>
 - instead of balloon_common.h just use balloon.h (yes, naming is hard)
 - cleaned up balloon.h - remove from files that do not use it and
   remove externs from function declarations
v1->v2:
 - reworked from simple /proc/meminfo addition

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Nadav Amit <namit@vmware.com>
Cc: pv-drivers@vmware.com
Cc: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: linux-hyperv@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: xen-devel@lists.xenproject.org

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
-- 
2.31.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 10:40:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 10:40:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425716.673723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6V7-0000Y6-Ql; Wed, 19 Oct 2022 10:40:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425716.673723; Wed, 19 Oct 2022 10:40:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6V7-0000Xz-NT; Wed, 19 Oct 2022 10:40:41 +0000
Received: by outflank-mailman (input) for mailman id 425716;
 Wed, 19 Oct 2022 10:40:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GAs9=2U=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ol6V6-0000Xt-QK
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 10:40:40 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2069.outbound.protection.outlook.com [40.107.103.69])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77c05971-4f9a-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 12:40:39 +0200 (CEST)
Received: from FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::17)
 by AS8PR08MB6040.eurprd08.prod.outlook.com (2603:10a6:20b:296::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct
 2022 10:40:34 +0000
Received: from VI1EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:4a:cafe::6b) by FR3P281CA0041.outlook.office365.com
 (2603:10a6:d10:4a::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.17 via Frontend
 Transport; Wed, 19 Oct 2022 10:40:34 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT024.mail.protection.outlook.com (100.127.145.23) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 19 Oct 2022 10:40:33 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Wed, 19 Oct 2022 10:40:32 +0000
Received: from 2573cc200cc8.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 439F4132-BFFC-4540-8E28-F76EB1041014.1; 
 Wed, 19 Oct 2022 10:40:26 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2573cc200cc8.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 19 Oct 2022 10:40:26 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAVPR08MB9403.eurprd08.prod.outlook.com (2603:10a6:102:300::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 10:40:18 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 10:40:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77c05971-4f9a-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=lHQDD8vXX+DUE+8EuiODXrYO+pfmZra+3ZVuiGKNi7cs8MkWr5liPpMQVM7n2IDPRHFloHcAZUQ+766qWG/IK8goUs1+v+drnZnThaouxuCNnzsXegl7pOZ+tT+I5D26Nsbv1Sov+Q+9FvkqEF+CbsmWW+dQR7KOzW/jUY4FON5xNweWlQbqJ8LEeNqlVFhd14by660qKaFEKQHMFrsfOo36BnbhKstB5nd0pwbnFAVnG6J496I1KuGEoAEYjduBptWRCAi4FFwq6GafsTyR/rWUts9+TJqOFxa/60V/p1L5+MWFBS+6s1CR/IKXR4zGXKQ6CHO94/MtN6XRNIc5fg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K4/QlHMtpyTlUwuZoPfJwKsx2lbSopfoz02KHRDs3U0=;
 b=PLRkk+JEQxWwOYaR+d+ZF8DN3VttNv5gtgbY1k6LeF7RFj5583BNnMWoiAGxKD49DCVkULAeZw73eQjiUM7r+RhXKCR1Qm0r7H6vFOMXjI2ANH7ebgDs+RiFh4RWFz/DkZ1QmNaGyDgtnOcobXrG1FpqPRyHtptaAtBjfmW5x5TtDngTMeOfGGskig0lFQIM5ACuD4h37DleGdjSyYgK8M4U0VlPFe3AWwsw9joUV72UxoCnHq9v9UmBJMSl9ZREvdxSRSBM3Ugct9iSowGO+LrDws9zrXtyyQtFlJNBUO5BR/v3jNcHfQ93H3gfxfyRXgOBAltIQ1ik+jys1n7H4w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K4/QlHMtpyTlUwuZoPfJwKsx2lbSopfoz02KHRDs3U0=;
 b=FrivusEtPhv+A6IjriMaaofapzq1wWOTojabMsGrSBK1JTagzSS7k8FP3Z3VtqDpKmiVuG1b+NXoroYFtaymKKvvjFq4ONksjmLIRCAQX9Fm/lINqS7InyPM1mn2Iwrs4yp1dO/jQ1xtlqlwRt7hyZux0k94KlQoKqH5/9bT8Gw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5a545c12548f8a2d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TQvp+MBymuylf766lucY1M/kBBKkpc+Tfy35nf46p2v4sTQ37XSSXgxOAe6x3qT6hK9PIsTjWRH3gFwp4O4CdRqyoJK8RPzBnlHks+MAxDy3lm7eFhDO6t9UbZJDEtNjCjNB2OLSzQEwstaYjn563BhlzR5ieAnwYUyzHyKnJIJhcoZlW691kndZcgjHM0P9gpSUbz5rWCBlACXyx0Lp8GUojR4/sxy+wH1Qylm1pSsdE/PnCO8mEaGUQI2W0UaL0D/h9ip1/XZj1g3Kv3Ty6C7iCRp/KZ+g7QmuwFBOjOKXsY85hRO+bY+7s2NO/RNN3KoADh4JtM4+kKCUcAyafA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K4/QlHMtpyTlUwuZoPfJwKsx2lbSopfoz02KHRDs3U0=;
 b=lE9OqjYtP6ewePGD+x5rNh3HUN4Izb9ask8FCot4ZoQQSl9hlsr2XshCsPRxWjXlljNhJF0/N62wFu/3ma7MShZVLr9hOzDbrG5aMhLZ+sEm6khvGkpwqHn/N8cbm/CrCVXyDb7Mli4TexJijVoL5pGlBxs3s+sJs82SmtQs8+Ykj+kz+4V19RIRYjfioIj6s+NlgF/P5j2Z37qhDMxNG1pHlHfLZc2vV0dkcnxDE0DLWklt2oDZ9VNceBKLnyXYtufRyxlRyUriEwkCiGvR74pS8mIfb0tYeSObR6dAGMirm4gGfgWv2LygChndXv2aCNwNBjKlbuZ7eibStSAJaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K4/QlHMtpyTlUwuZoPfJwKsx2lbSopfoz02KHRDs3U0=;
 b=FrivusEtPhv+A6IjriMaaofapzq1wWOTojabMsGrSBK1JTagzSS7k8FP3Z3VtqDpKmiVuG1b+NXoroYFtaymKKvvjFq4ONksjmLIRCAQX9Fm/lINqS7InyPM1mn2Iwrs4yp1dO/jQ1xtlqlwRt7hyZux0k94KlQoKqH5/9bT8Gw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
Thread-Topic: [PATCH v2 0/3] Yocto Gitlab CI
Thread-Index:
 AQHY3hEMDLhOM5SRDUy6m8XkPQoc/64OWrqAgAP8xgCAAQ3WgIABes6AgACX5oCAABowAA==
Date: Wed, 19 Oct 2022 10:40:18 +0000
Message-ID: <0070D1D1-F579-4E11-8A27-62D3D92DE896@arm.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
 <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
 <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
 <56155bff-6229-05a4-7221-cd6aa5a1de8b@amd.com>
In-Reply-To: <56155bff-6229-05a4-7221-cd6aa5a1de8b@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAVPR08MB9403:EE_|VI1EUR03FT024:EE_|AS8PR08MB6040:EE_
X-MS-Office365-Filtering-Correlation-Id: 66c2366b-8039-4e60-cf73-08dab1be5a0c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0LI5hPtf0dY2dcXIJgRBACfPwtiWDlnLe8qBlZVlQGq4olCfgr0v1CgvN/cwC/sBUWKjXa7iSYMTEXgZqntyE6GIcyfTzFXD2+qwSKjnXT1VORqjioy0UT48Q3R83bjuPlz6L0iOVpzuliFIbJyaFeW1RuktHkRzMh8nrPOWs0sx58zM8sg7jD+y0DWdn2X9364+0vFGm/8xEyOikYG8pEY02S7ucuFcC9fybU+Daja8KEP9b53/NmDLVn0jqv0nsh1kkB+DD7w+fB0QI6Bym7/0ANkPaU2RWLOu1i57eNZET/R6eizQ3j+2sQLPsrgGllEa+3jA8H3zASp6oBRVqEy66EGKxA+4pCRSWHc9PXaq5STVHbH+L6AAEoLRZaCk4+NloHVoDQGXUyM4KSK2USLS8ThDS4lAtoQXy3ngnaRIRF/jXpPuHJ2olyWxEpsgYJVQp3AE8TJYXhIj4tRh4WLMrimhyWosq0kRTWD8YCtdbpZ4orb+pcx7zvYt7j2NqQT8F03Rf8VXQLvH2Pv2o9sDUWCwxgGGdsJfnHo5mcwuSLfJmsichuVCLVmwjvL82rWsKD+ZmW5w3SIOw5d51bDuQ5H/NhR3Xf4jf3ut3bnQtUxTIZioX86Oh7hgRbOmWiYuNa3wdTpnrAUmKEeBeacZCh54nNlGCFueIT8qPXluUxQ6MOEWs53UijYWmG4zYcEBOxFTvuZAQfUK87WQa/ecHtDnUFNZaWgksBPkymarfdmeBOg2bFyI0gg43VzUO8rGYZYtIpvqAKHR7xoOBDNx3oIdYYZ/mY4SUYr7u1JNcqcqfKciz4CoElyB3xvwm63iwL2wh0kTtH4ZqPRVNVrWvcxIc7kd7S2p3KzpDXA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39860400002)(376002)(366004)(451199015)(71200400001)(478600001)(45080400002)(83380400001)(86362001)(6486002)(84970400001)(966005)(76116006)(66556008)(66946007)(36756003)(91956017)(66476007)(53546011)(6506007)(66446008)(8676002)(4326008)(316002)(41300700001)(26005)(6512007)(8936002)(6916009)(54906003)(5660300002)(2616005)(2906002)(33656002)(186003)(64756008)(122000001)(38070700005)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E058AA5FFC29B44F95A2F7E8B08CEE26@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9403
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	95c02450-a4f9-4119-b1cd-08dab1be50f1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OCqc2JP1lyDqu6514z6DcspDcYdplBS/KywPIlqDfFbnmHV8PNcz1mfw3wRQ1VA/c0JT02g08D0MNR1pInkY9xJXimNoaKiprbVf2TGEkukGkCJ56E7d8Cj25KBnusNlaTImyYTgQdMkYaQ1uagf48J8g7fMQuDKWvDHE/aZdOi3ssZXpoCji/XxnTVXk7zQMnjnmDGhDpoPeh/ZcJ+RBsa3UyxBkkN3w27sYJVogUKMiSs8ZQvnUdBTw0n7yFpCB99oomlLBBtMUy15i7cj5uTznyAEDS2eob3c72SKbdSrWcvX6UV6NhrJSvDTleb9PA8AoTkRL55Kz3Y6Vh58/ZyP1pBntta/Td430e07hckfCV3MCpoLGbQtI/NA7UNDbISqzkKuynQDIAXRcO7mZcCbkwUpaMqAVysLbpexciXbocl9vf3TTtvKj0WSQWQBlFfLM5O/AhupsuWwppuqn+szWGNqb1eGgkS3tezlJy798jK4gO3ujgC7nHFPaSU2wl8titbyGPSieA78v1TtQXUfkzGBWqeVo43uIsXnITFtArinl6+OdE5vcF6bVzV+GGU5xvbbXXwbaS6Y9MRIVZwrpLTC1Jm36t9AePJ3amnrie0t8oWsxn5PTELJeJ3Z/9QgjcL/iHdJxmdgD4D6oigc3j4zF7V25IfFAC/wJvJdpOm2W4aIhJwL+3Zl1su5JUrkWWO6xjDtlinE3XAAVatK0dBWApgDn032pxxWDjMsoi3pIlUcZ+lVr/qoSZ9lM2wa5S6Z0AqsQIkjBlUtNDPrK7cfi/gmJ9VvGMmL0BFtL7J0nOxc5UEBYPyBJGIP4PPzCr/OIdFIpH1XxcjhWQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(47076005)(186003)(2616005)(83380400001)(356005)(81166007)(26005)(86362001)(36860700001)(336012)(82740400003)(5660300002)(2906002)(8936002)(966005)(4326008)(40480700001)(82310400005)(6862004)(107886003)(8676002)(40460700003)(478600001)(45080400002)(6486002)(6506007)(53546011)(316002)(41300700001)(70206006)(54906003)(6512007)(70586007)(36756003)(33656002)(84970400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 10:40:33.7631
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 66c2366b-8039-4e60-cf73-08dab1be5a0c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6040

Hi Michal,

> On 19 Oct 2022, at 10:06, Michal Orzel <michal.orzel@amd.com> wrote:
>=20
> Hi Stefano,
>=20
> On 19/10/2022 02:02, Stefano Stabellini wrote:
>>=20
>>=20
>> On Mon, 17 Oct 2022, Stefano Stabellini wrote:
>>> It should be
>>>=20
>>> BB_NUMBER_THREADS=3D"2"
>>>=20
>>> but that worked! Let me a couple of more tests.
>>=20
>> I could run successfully a Yocto build test with qemuarm64 as target in
>> gitlab-ci, hurray! No size issues, no build time issues, everything was
>> fine. See:
>> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgitl=
ab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193051236&a=
mp;data=3D05%7C01%7Cmichal.orzel%40amd.com%7C75ea919bbde249e1bac408dab16549=
60%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017345841386870%7CUnknow=
n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI=
6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DoWrGVbloqkJoOxvvxTr55RbKVzd3YmS4iiLPyxD=
ZCYY%3D&amp;reserved=3D0
>> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgitl=
ab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193083119&a=
mp;data=3D05%7C01%7Cmichal.orzel%40amd.com%7C75ea919bbde249e1bac408dab16549=
60%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017345841386870%7CUnknow=
n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI=
6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3D%2BXf3ZB1bsVi8K%2BzEEe1Dhpg0GSohpseogff=
12GaK3Gw%3D&amp;reserved=3D0
>>=20
>> I made the appended changes in top of this series.
>>=20
>> - I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
>>  registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64
>> - for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
>>  xen.git, not from a copy stored inside a container
>> - when building the kirkstone-qemuarm64 container the first time
>>  (outside of gitlab-ci) I used COPY and took the script from the local
>>  xen.git tree
>> - after a number of tests, I settled on: BB_NUMBER_THREADS=3D"8" more th=
an
>>  this and it breaks on some workstations, please add it
>> - I am running the yocto build on arm64 so that we can use the arm64
>>  hardware to do it in gitlab-ci
>>=20
>> Please feel free to incorporate these changes in your series, and add
>> corresponding changes for the qemuarm32 and qemux86 targets.
>>=20
>> I am looking forward to it! Almost there!
>>=20
>> Cheers,
>>=20
>> Stefano
>>=20
>>=20
>> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yo=
cto/build-yocto.sh
>> index 0d31dad607..16f1dcc0a5 100755
>> --- a/automation/build/yocto/build-yocto.sh
>> +++ b/automation/build/yocto/build-yocto.sh
>> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal =3D " ssh-=
pregen-hostkeys"
>> # Save some disk space
>> INHERIT +=3D "rm_work"
>>=20
>> +# Reduce number of jobs
>> +BB_NUMBER_THREADS=3D"8"
>> +
>> EOF
>>=20
>>     if [ "${do_localsrc}" =3D "y" ]; then
>> diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/aut=
omation/build/yocto/kirkstone-qemuarm64.dockerfile
>> index f279a7af92..aea3fc1f3e 100644
>> --- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
>> +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
>> @@ -16,7 +16,8 @@ ARG target=3Dqemuarm64
>>=20
>> # This step can take one to several hours depending on your download ban=
dwith
>> # and the speed of your computer
>> -RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
>> +COPY ./build-yocto.sh /
>> +RUN /build-yocto.sh --dump-log $target
>>=20
>> FROM $from_image
>>=20
>> diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/bu=
ild/yocto/kirkstone.dockerfile
>> index 367a7863b6..ffbd91aa90 100644
>> --- a/automation/build/yocto/kirkstone.dockerfile
>> +++ b/automation/build/yocto/kirkstone.dockerfile
>> @@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
>>              /home/$USER_NAME/xen && \
>>     chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
>>=20
>> -# Copy the build script
>> -COPY build-yocto.sh /home/$USER_NAME/bin/
>> -
>> # clone yocto repositories we need
>> ARG yocto_version=3D"kirkstone"
>> RUN for rep in \
>> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/buil=
d.yaml
>> index ddc2234faf..4b8bcde252 100644
>> --- a/automation/gitlab-ci/build.yaml
>> +++ b/automation/gitlab-ci/build.yaml
>> @@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
>>     EXTRA_XEN_CONFIG: |
>>       CONFIG_BOOT_TIME_CPUPOOLS=3Dy
>>=20
>> +yocto-kirkstone-qemuarm64:
>> +  stage: build
>> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
>> +  script:
>> +    - ./automation/build/yocto/build-yocto.sh -v --log-dir=3D./logs --x=
en-dir=3D`pwd` qemuarm64
>> +  variables:
>> +    CONTAINER: yocto:kirkstone-qemuarm64
>> +  artifacts:
>> +    paths:
>> +      - '*.log'
>> +      - '*/*.log'
> The above lines are not needed as the logs/* below will handle them all (=
logs are only stored in logs/).

Ack

>=20
>> +      - 'logs/*'
>> +    when: always
>> +  tags:
>> +    - arm64
>> +
> build-yocto.sh performs both build and run actions. I think it'd be bette=
r to move this into test.yaml in that case.
> The best would be to create one build job (specifying --no-run) in build.=
yaml and one test job (specifying --no-build) in test.yaml.
> This however would probably require marking path build/tmp/deploy/***/qem=
uarm64 as an build artifact. The question then is
> whether having this path would be enough for runqemu (Bertrand's opinion =
needed).

This will not be enough to run qemu as the qemu binary and its dependencies=
 are in the build artifacts and not in deploy.
Splitting the build and run is not a good idea because the size of the arti=
fact between the 2 will be huge.

>=20
> Apart from that there is an aspect of Yocto releases and the containers/t=
ests names.
> Yocto needs to be up-to-date in order to properly build Xen+tools.
> This basically means that we will need to update the containers once
> per Yocto release. The old containers would still need to be stored in ou=
r CI container registry
> so that we can use CI for older versions of Xen. However, updating the co=
ntainers would also require
> modifying the existing tests (for now we have e.g. yocto-kirkstone-qemuar=
m64 but in a month we will have
> to change them to yocto-langdale-qemuarm64). In a few years time this wil=
l result in several CI jobs
> that are the same but differ only in name/container. I would thus suggest=
 to name the CI jobs like this:
> yocto-qemuarm64 (without yocto release name) and define the top-level YOC=
TO_CONTAINER variable to store
> the current yocto release container. This will solve the issue I describe=
d above.

I think we have no other way around this and we will need to have one Yocto=
 release supported by Xen officially so
we will have to keep old docker images for old releases of Xen and move to =
newer versions of Yocto in staging when
it is needed.

We have to find a way for gitlab-ci to use the build.yaml contained inside =
the tree that is to be tested somehow so that gitlab would automatically ta=
ke the right one.
Which means that build.yaml will be different between branches and contain =
the right version for the current branch.

Regards
Bertrand

>=20
>=20
> ~Michal



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 10:44:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 10:44:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425723.673733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6YJ-0001DP-Do; Wed, 19 Oct 2022 10:43:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425723.673733; Wed, 19 Oct 2022 10:43:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6YJ-0001DI-At; Wed, 19 Oct 2022 10:43:59 +0000
Received: by outflank-mailman (input) for mailman id 425723;
 Wed, 19 Oct 2022 10:43:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/vg5=2U=epam.com=prvs=22912afb2d=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1ol6YH-0001D8-Dc
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 10:43:57 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed0e86d8-4f9a-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 12:43:55 +0200 (CEST)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JAJuTo012523;
 Wed, 19 Oct 2022 10:43:33 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k9x3pkkgs-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 19 Oct 2022 10:43:32 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7392.eurprd03.prod.outlook.com (2603:10a6:102:106::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 10:43:30 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::551e:e1bc:b684:b7bb]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::551e:e1bc:b684:b7bb%9]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 10:43:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed0e86d8-4f9a-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QHvVz3lupSgLrfTfRvcD6hmOiM/TVoX4vAI+Rwy9poBadEjRPI0VIgR2isPLgkW0uzjjCKqbmHrNMhK0SChTgYMJ8NE7sO5v27qCK+If1sp3JnbOk3xkscuonn0FsT3oX/A8cKYag/hHvmgFIRz2kXoxPzcVXxllWeP7pjxZ3V7uH0KF79hUjUp5qndPQnEDx5YjY231rmVKqA1usKlb2yIU7+FP8d7HYdrd26Cb+57dgj8DAp8yz791PVMOl3eJVxJD9jEP4PJlbHBxOSgQZsDcFwwfgtlm643LycvWc/HvjaY9skRM2GsFNofvKT82/7mIBbFpoXchY0bDp0aX6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+TH18d6jJiu/VsRvpIH+0CdOUoQ76uMhOxlznj9gV4I=;
 b=MQI3HD2dJxJJOuY8bxuLWIAfvIDqs48egBy/K0k6iEgU6hvDWlfxhuoGiR/jNL1oA/KSZe3DLGSalgQ61CsvaJPtO0OZ8XKCUXbQMe7FikOme2rUOiTNYtZdACR7g8Ad5w+XUGkRAfYVzXm1UJq1h/46dttCmsMzuTvC9EMt44etkgbLJxdIGe416ZNdLv7SelVPeK6+6t/vK71WgubeRHIFxktnPrKX4i2yn31/8PfJA+Y95dWdS2KIDbKpOTObwSjJjCOzhB5yw6tUhGtHOzwWctOd5A6c5U50Bu/nlyabZBsDXo9u9RdZPB7aJ6Aq/4UY++x9aEVEd/uZNlFS8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+TH18d6jJiu/VsRvpIH+0CdOUoQ76uMhOxlznj9gV4I=;
 b=gMIwodgSRJBa5Vt4wCo7ARSqjFfFRAwaUQAq/CdrlTZ8DEvTUpbqPxeHSvfpIqTUwi7tcLdtzILWb1g/BE5w7xfSxyGZWoIoG+nJCVAKCPFk9uUj1ejQLHAZ1M3ft8HZY/Wtx7Ir9YjwJfL7HTTuUPajGwiIU4YoTXtKuKIV8gpDjVAC5lfmLfSwiHtsUKRVYUk2ga0ZTzQ6GKM9U3DXjI9031ZaSDrpLRK6+a2t9rtcGyB56hkywDB7whDtLjD/IADyo9xJWWPhd6Edh0b1/odSxO3MUi98Vtmr0TjybX78zii9oUcGI3XUHgaPbBsW4RcgsUePMHZF+Giif8cG2A==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "jennifer.herbert@citrix.com" <jennifer.herbert@citrix.com>
CC: "jgross@suse.com" <jgross@suse.com>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        "maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
        "mripard@kernel.org"
	<mripard@kernel.org>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Issue on unmap_grant_pages before releasing dmabuf
Thread-Topic: Issue on unmap_grant_pages before releasing dmabuf
Thread-Index: AQHY46egGI7L6jjRBkOb9R/tnZLb7A==
Date: Wed, 19 Oct 2022 10:43:30 +0000
Message-ID: <Y0/U0RNDSRdV7bex@EPUAKYIW015D>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|PA4PR03MB7392:EE_
x-ms-office365-filtering-correlation-id: 248371b3-0c09-414a-9adf-08dab1bec33d
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 1ajmBmC2qHpjNru4mpKe2XQXhvN0PoX0vK94YZPHK+dtMn4b2XZxuquNSWpJuyRzh6xn916ikNz0XrHVxu3pFRgNJ8gFYxkfNeDCvIcUdIa7eWxhQxLBtOXTvAJgHS72SX/Oz6prHyOfrinjW58QFyb1RFu8Zpzd8uVUF9FUM3LkJ/7xD3MslIiqNI1kDLRLWKpRzSkb5ISbK2paO5dtm3UChSiEQsmGaJFJLvNxxHK/F8DnQsLIxp3VCPZ9q2Bie/KpMh9C5qKuY+ntf4EDhvBmRhliwO3GR6gcfKxoUjTvnEmh02GGlikwTrFNmmT3X9PHS7OKDGxYPyfzdEzGdiZH0lN65fz5t03RfjOB8/gB9pchff3N1Fy+ovlG8lcr0X2yfBwJHLQE/p11vgcMX4SYL5+DMYbQf/5p8JYDpeXir7iivysmMHhjmbCidJp2tGlSu6rJK6XipLXUrZm76xvDEEr8Fs292BeQiDhnb2ebF0XyZvntuoITNR/C7dZ6DKJLe9N3wpAfG1NfTGHwLjSnvx4i9oxtTftC3ZD9kjjNOYSSX86hKlxKsddr5li24NgMRghf36X/Afw7513SU4QBKMX6jbeb5hGbkqDUL+HfEfivjNk66sxZj46autZTiOeoktxb/BFvlg7sH+u9ctuiwxFy220I4EGN+m/hjYSiUmh+jAT+fwgHY3NyAcCn9MEOyy/fXQS05OYCooav4r96ZHJVYcTt/xsmdjxK/xgaUUDn3zlCpR7OfPEzVL7fMhWW6kH4f2VrFhXYYFStkkqDsECBCPwZjCyUMu3gYf9vxxB3nR/kHXWn4p5ITgq63wsOpnJPoLRessX80OyZ0g==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(366004)(396003)(136003)(346002)(39860400002)(84040400005)(451199015)(6916009)(4326008)(5660300002)(54906003)(66446008)(66556008)(76116006)(66946007)(8676002)(91956017)(8936002)(6506007)(316002)(6512007)(9686003)(26005)(41300700001)(64756008)(66476007)(38100700002)(33716001)(38070700005)(122000001)(186003)(2906002)(86362001)(83380400001)(71200400001)(478600001)(45080400002)(966005)(6486002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ZWJpOr8VAGPLJ0VxmIFDkoy317kfd4FigvoqSqVahNhPD4J4wg16bPD/fjnc?=
 =?us-ascii?Q?AAxe3qDLsSM9Rqf3FS2bN2Aa9CQ7eXgnXB9oFfsmkKkSFwlGWZGAT787CqBY?=
 =?us-ascii?Q?TrDuWHTwt/F8l8a0CoCFmsl6nvfTc1qEOZ7eZXRaTG/xSRnmxUOlpGRx0Jjq?=
 =?us-ascii?Q?rptDg8DUiWvhWr6rZyIzYX3R8Yfr2vK53sbqIIhmCZaA/YaTpinlJ+fjWNsU?=
 =?us-ascii?Q?rdM9wPNVJ2h1W0cV76uG5r/4MzuPEcRaj/8euqfJ0MuCQzFbczMlOtpZQ1CX?=
 =?us-ascii?Q?CGguEyRHAzUJZ4BSdmHGl02L6kxlS28hUZazpc18nvivVVw7OhMdnYZPECay?=
 =?us-ascii?Q?99SIuNcAjfg9NBs59dzqMO8nsRySf6aR+qPYdmOSrWLhHRxxMTEOX+Ckbjik?=
 =?us-ascii?Q?IyNqJJIjMJ+UCHRBvMDOtAHTul6qDeqJC+OM3mKidKEZVDZPhZun0UZlEQ0I?=
 =?us-ascii?Q?peEYsMZ49tOMquIql8wuOJUw2gQeqdbEklC+p0TILh6JkLAxwMYUygyTiCVM?=
 =?us-ascii?Q?HXCJrX03iQOKQU6RQDKIun4334aPuafYe6jB1SRJHN1WSENddegkLAXh+ZOa?=
 =?us-ascii?Q?7exVpRr/O3lyST5Rtb6Nt/h3og6dur1WH+TQY3kBSril+JJATiPjUzcmZea3?=
 =?us-ascii?Q?Q0L4f0HXncEsptP/KZ9uHIGmdg0ofhyBh4HVUJOipdEeNvYGh6/cc5+kMG0J?=
 =?us-ascii?Q?hCBXQAt/Ibmn2JWYKtTVK7V7K/DnlF1jwJm7g0kJABIVcIz98s5XzmLFbveq?=
 =?us-ascii?Q?xGAXNSDAM7sNEnsB7/sYJcnAlSpto23xU2XNCKZJz79Lu9FyoRR7gMSpQfDu?=
 =?us-ascii?Q?1l999pkfazv63NHwFgfUkri6kEOTuImzSxinHGkYeLtqqdZiA9lIu9FbWIcn?=
 =?us-ascii?Q?dFotNDr5TYBT7q+S778BPKWae3ttjRS2H2vjg5mGHfnO/v0NOdgURFNsCkIi?=
 =?us-ascii?Q?0M2I09wMBflCixt405Jtl0DPXujPejFoB0vD7rWL/lqVFMZAqWx5r4+S2tlQ?=
 =?us-ascii?Q?hpSRLATBzrMlhA4pZHVVTXJ7uhk8avYkk+NKHnue5t0wBEkQfzduwUumN+gV?=
 =?us-ascii?Q?Vw6Py6LprvR07+tc2OFZ3lCIyNSqRzuf05hahVehV9w/8isju8RgEwzavgos?=
 =?us-ascii?Q?sRTGOqQ3wxMq5Qu8OlXL5KDp6buHuB0SzFYNym93JX/c6tv5SfjbhM1eGlF9?=
 =?us-ascii?Q?r6l54KwL3BM75QcHu3r4jmUVRse3HpmxASqIh2/wokWAgVP0R48tTvE1q35/?=
 =?us-ascii?Q?gg+8+Qa2lrBk87xby2sfW4ejmIsH8ZjuWi7EHgH/NKECSBm7uYj9fowhjhZs?=
 =?us-ascii?Q?IEcxfVItWa7Bhl1XvqQ4Zj2CItvVO8watvc23XofvfMgPMuSFzBrhTJZ2UVF?=
 =?us-ascii?Q?nU5nS5MHP9duskfHWVEv+ARnzPeq+M0PGRlorwtO8ZDMmpV7MVblOm9qxhPN?=
 =?us-ascii?Q?3OaMte7WZKHsWLr9CqT5M6pWtASeZ3RLjaHVS+JMN7zW5WRIs73AzrIMjMYH?=
 =?us-ascii?Q?Xo3rXQAxdtYEeGi3Nf05/pnAY1uA0pK7869T7Unb/B+d0Zymf8HR/KnZzjyV?=
 =?us-ascii?Q?c8rX5/R8EsQkwlicF9PzGoQ6ZV4IEBW4N9CB5IPjwkf9yrccUQmyvpvhvuer?=
 =?us-ascii?Q?9A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BF063B05B28AF1498C3E5698FDCC3D90@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 248371b3-0c09-414a-9adf-08dab1bec33d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 10:43:30.3374
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NARB9CSUXii2WbH8W/x7zroh+CYY27tU2CbbfySBGmnPP+EY/tFK4v/dSeqdsKZaoAihmJe5njRYtPxGWuz1TYPqSQNGhMeZCGGXEQzQDDA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7392
X-Proofpoint-ORIG-GUID: GMkuTjpDy9qh95K13P9QT05TQFhki3cI
X-Proofpoint-GUID: GMkuTjpDy9qh95K13P9QT05TQFhki3cI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_06,2022-10-19_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0
 phishscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999
 priorityscore=1501 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210190059

Greetings.

I need your advise about the problem I'm facing right now:
I'm working on the new type of dmabuf export implementation. This=20
is going to be new ioctl to the gntdev and it's purpose is to use
external buffer, provided by file descriptor as the backing storage
during export to grant refs.
Few words about the functionality I'm working on right now:
My setup is based on IMX8QM (please see PS below if you need
configuration details)

When using dma-buf exporter to create dma-buf with backing storage and
map it to the grant refs, provided from the domain, we've met a problem,
that several HW (i.MX8 gpu in our case) do not support external buffer
and requires backing storage to be created using it's native tools
(eglCreateImageKHR returns EGL_NO_IMAGE_KHR for buffers, which were not
created using gbm_bo_create).
That's why new ioctls were added to be able to pass existing dma-buffer
fd as input parameter and use it as backing storage to export to refs.
Kernel version on IMX8QM board is 5.10.72 and itworks fine on this kernel
version.

New ioctls source code can be found here:
 https://github.com/oleksiimoisieiev/linux/tree/gntdev_map_buf_upstr_for-li=
nus-6.1_2
   =20
Now regarding the problem I've met when rebased those code on master:
On my test stand I use DRM_IOCTL_MODE_CREATE_DUMB/DRM_IOCTL_MODE_DESTROY_DU=
MB ioctls
to allocate buffer and I'm observing the following backtrace on DRM_IOCTL_M=
ODE_DESTROY_DUMB:

Unable to handle kernel paging request at virtual address 0000000387000098
Mem abort info:
  ESR =3D 0x0000000096000005
  EC =3D 0x25: DABT (current EL), IL =3D 32 bits
  SET =3D 0, FnV =3D 0
  EA =3D 0, S1PTW =3D 0
  FSC =3D 0x05: level 1 translation fault
Data abort info:
  ISV =3D 0, ISS =3D 0x00000005
  CM =3D 0, WnR =3D 0
user pgtable: 4k pages, 48-bit VAs, pgdp=3D000000006df98000
[0000000387000098] pgd=3D0800000064f4f003, p4d=3D0800000064f4f003, pud=3D00=
00000000000000
Internal error: Oops: 96000005 [#1] PREEMPT SMP
Modules linked in: xen_pciback overlay crct10dif_ce ip_tables x_tables ipv6
PU: 0 PID: 34 Comm: kworker/0:1 Not tainted 6.0.0 #85
Hardware name: linux,dummy-virt (DT)
Workqueue: events virtio_gpu_dequeue_ctrl_func
pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=3D--)
pc : check_move_unevictable_folios+0xb8/0x4d0
lr : check_move_unevictable_folios+0xb4/0x4d0
sp : ffff8000081a3ad0
x29: ffff8000081a3ad0 x28: ffff03856ac98800 x27: 0000000000000000
x26: ffffde7b168ee9d8 x25: ffff03856ae26008 x24: 0000000000000000
x23: ffffde7b1758d6c0 x22: 0000000000000001 x21: ffff8000081a3b68
x20: 0000000000000001 x19: fffffc0e15935040 x18: ffffffffffffffff
x17: ffff250a68e3d000 x16: 0000000000000012 x15: ffff8000881a38d7
x14: 0000000000000000 x13: ffffde7b175a3150 x12: 0000000000002c55
x11: 0000000000000ec7 x10: ffffde7b176113f8 x9 : ffffde7b175a3150
x8 : 0000000100004ec7 x7 : ffffde7b175fb150 x6 : ffff8000081a3b70
x5 : 0000000000000001 x4 : 0000000000000000 x3 : ffff03856ac98850
x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000387000000
Call trace:
 check_move_unevictable_folios+0xb8/0x4d0
 check_move_unevictable_pages+0x8c/0x110
 drm_gem_put_pages+0x118/0x198
 drm_gem_shmem_put_pages_locked+0x4c/0x70
 drm_gem_shmem_unpin+0x30/0x50
 virtio_gpu_cleanup_object+0x84/0x130
 virtio_gpu_cmd_unref_cb+0x18/0x2c
 virtio_gpu_dequeue_ctrl_func+0x124/0x290
 process_one_work+0x1d0/0x320
 worker_thread+0x14c/0x444
 kthread+0x10c/0x110
 ret_from_fork+0x10/0x20
Code: 97fc3fe1 aa1303e0 94003ac7 b4000080 (f9404c00)=20
---[ end trace 0000000000000000 ]---

After some investigation I think I've found the cause of the problem:
This is the functionality, added in commit 3f9f1c67572f5e5e6dc84216d48d1480=
f3c4fcf6 which
introduces safe mechanism to unmap grant pages which is waiting until page_=
count(page) =3D 1
before doing unmap.
The problem is that DRM_IOCTL_MODE_CREATE_DUMB creates buffer where page_co=
unt(page) =3D 2.

On my QEMU test stand I'm using Xen 4.16 (aarch64) with debian based Dom0 +=
 DomU on the latest
kernels.
I've created some apps for testing:
The first one is to allocate grant refs on DomU:
https://github.com/oleksiimoisieiev/linux/tree/gntdev_map_buf_upstr_for-lin=
us-6.1_2
The name is test.ko and it can be built using command:
cd ./test; make
NOTE: makefile expects kernel build to be present on ../../test-build direc=
tory.

It should be run on DomU using command:
insmod test.ko; echo "create" > /sys/kernel/etx_sysfs/etx_value

Result will be the following:
[  126.104903] test: loading out-of-tree module taints kernel.
[  126.150586] Sysfs - Write!!!
[  126.150773] create
[  126.150773] =20
[  126.150888] Hello, World!
[  126.151203] Hello, World!
[  126.151324] gref 301
[  126.151376] addr ffff00000883d000
[  126.151431] gref 302
[  126.151454] addr ffff00000883e000
[  126.151478] gref 303
[  126.151497] addr ffff00000883f000
[  126.151525] gref 304
[  126.151546] addr ffff000008840000
[  126.151573] gref 305
[  126.151593] addr ffff000008841000

The second is for dom0 and can be found here:
https://github.com/oleksiimoisieiev/xen/tree/gntdev_fd

How to build:
make -C tools/console all

Result: ./tools/console/gnt_test should be uploaded to Dom0

Start: sudo ./gnt_test_map 1 301 302 303 304 305
Where 1 is DomU ID and 301 302 303 304 305 - grefs from test.ko output

This will create buffer using ioctls DRM_IOCTL_MODE_CREATE_DUMB them passes=
 it as backing=20
storage to gntdev and then destroys it using DRM_IOCTL_MODE_DESTROY_DUMB.
The problem is that when dumb buffer is created we observe page_count(page)=
 =3D 2. So
when before buffer release I'm trying to unmap grant refs using unmap_grant=
_pages it is calling
__gnttab_unmap_refs_async, which postpones actual unmapping to 5 ms because=
=20
page_count(page) > 1.
Which causes drm_gem_get_pages to try to free pages, which are still mapped=
.
Also if I change in the following line:
https://github.com/torvalds/linux/blob/bb1a1146467ad812bb65440696df0782e2bc=
63c8/drivers/xen/grant-table.c#L1313
change from page_count(item->pages[pc]) > 1 to page_count(item->pages[pc]) =
> 2 - everything works fine.
The obvious way for fix this issue I see is to make the expected page_count
for __gnttab_unmap_refs_async configurable for each buffer, but I'm now sur=
e
if this is the
best solution.

I would be happy to hear your thoughts and advises about how to fix this si=
tuation.

PS: IMX8QM configuration details:
IMX8QM board has XEN 4.16 with 2 domains:
DomU, which has 1 gpu core passed through and graphics should start;
Dom0, which has the second gpu core and weston.
Weston is starting on DomU via xen drm frontend/backend and using=20
zwp_linux_dmabuf_v1_interface to implement zerocopy support.
Details of zerocopy initialization:=20
 https://github.com/xen-troops/displ_be/blob/782471533dc1e7b38099a5583256bf=
e0c2be488c/src/displayBackend/wayland/WaylandZCopy.cpp#L410

Best regards,
Oleksii.
 =


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 10:53:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 10:53:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425729.673744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6hk-0002jB-B3; Wed, 19 Oct 2022 10:53:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425729.673744; Wed, 19 Oct 2022 10:53:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6hk-0002j4-8D; Wed, 19 Oct 2022 10:53:44 +0000
Received: by outflank-mailman (input) for mailman id 425729;
 Wed, 19 Oct 2022 10:53:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rFyQ=2U=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ol6hi-0002iy-5v
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 10:53:42 +0000
Received: from NAM04-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam04on2059.outbound.protection.outlook.com [40.107.101.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 491dd5d2-4f9c-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 12:53:39 +0200 (CEST)
Received: from DM6PR06CA0012.namprd06.prod.outlook.com (2603:10b6:5:120::25)
 by MN2PR12MB4190.namprd12.prod.outlook.com (2603:10b6:208:1dd::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 10:53:35 +0000
Received: from DM6NAM11FT091.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:120:cafe::12) by DM6PR06CA0012.outlook.office365.com
 (2603:10b6:5:120::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 10:53:35 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT091.mail.protection.outlook.com (10.13.173.108) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 19 Oct 2022 10:53:35 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 05:53:34 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 19 Oct 2022 05:53:33 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 491dd5d2-4f9c-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rnl3ClUJ/lpbAC3B6upya6zEz0LsslFVDEy3FANrwI6m9oAUggNUSXA0WjUNDG//MHmYSZW5tIzh1maxcE2eYZLYuJw2qXykv5EQzoV45TMnH62+LPYUHpEi18MvdV1FnJ7kyHcQuTuAVP7SNSGZw0h5mHxSBwdDtKpdGZpuSU2TJk9anOGA4PMuXpq0tmnnwfy6yZ8nsd6UsBSexA4lvarVpc+et82bZayw0hoA4qSd+fAfk38koHm8rOgZwOoq1qmbj9ihrh/qgWhFEqg1DxQiVU2h+f8050RFbWWLZ0PotmfJ80rOsqYrDE700Q9VMomEXmPDg5cbKxx+RUKHmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HJEKRS8WmOl0dAIwJpZNbxPA3SHbecZxZanXz44Smps=;
 b=M6B8arCpdYhD78SGHCzYYhRJ1CdfhbdYFrftmrxnbrus6o3jy2t3KchIhSeNksSvauHK140/AQz/i3thtTI2zDGWseJmnY6yqYgS+Idw0eDl2R07HtXThFQAkk5MTdLwOjYRyyoncVeMQXxavrBo8g2adRsk85zCt9qgH+gMEGBnu30FqUYDyDAKHoBo0mjl7F5eu+L0OCOLzJGhQ07dbWdoBnc/EEP1QqdXelI/15JXeYoAgs2A+BkJvpLndopgyYddYo7jmlooz78qPF4o7iha+bXAvcGjuJ8fob3ISu0akn9bNcfvkoV/m3KsbiuepTrdi8QhKaFTaau+mRjEQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HJEKRS8WmOl0dAIwJpZNbxPA3SHbecZxZanXz44Smps=;
 b=g8ODJo5/Fapx30MSXIzPlNUOEq/+8Weuv+UtrT8+g4AUNXsND83+hNjI6nGj2WiiwuGkb3P9zwHluP29uu9+j8jvbgP7UVYyi08PkXEhJJRHB15iDiwWiWqfQitzHBUK7BgUa+eFBM6Y/IuP2pBiTtRORqdFNA2OHUiA28N86rk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <a1d2ab41-0d30-5d34-5a42-fb74b68d30f4@amd.com>
Date: Wed, 19 Oct 2022 12:53:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Stefano Stabellini <sstabellini@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>
References: <cover.1665561024.git.bertrand.marquis@arm.com>
 <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop>
 <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com>
 <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop>
 <56155bff-6229-05a4-7221-cd6aa5a1de8b@amd.com>
 <0070D1D1-F579-4E11-8A27-62D3D92DE896@arm.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <0070D1D1-F579-4E11-8A27-62D3D92DE896@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT091:EE_|MN2PR12MB4190:EE_
X-MS-Office365-Filtering-Correlation-Id: 68d819a8-6d94-433c-3eb6-08dab1c02bc8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	imhg8S4KfChdi0TudOLpCW+JUURRYslmhc5rOQgQCZAx+c30GPM9DBtedfMCMabjU52iiVEajQtZXS0lSSKnM8awgVngHTwiu+y3jKmoHKvK7n7BmQnATuYNv2AMJicWH0fPo1hLjszPOLkMhELRJSPfng3fJNZdXepz7/ATkk6P7dPHrWJzLyRFZLgn9SkE33tumirGArJSG2Plh6vPV8moJENb1A8fPu4H+XRqMByXWV6N9piMkbKm3qOfQUZZxFJ5F5qwxiyfx4Qk7g53jmaS26SzyLV3k+mbQrs5MpNXPFS8DIk3KoRNfvNikvDa4yGpS/OYa6/2vNNHrGjvtt3cWuLoiCUBjzQCVxaEm+bOOPCsyeEtOUHFCachEMl+A9+ZF/OCE1mx+j7ng9a14RHphVA5y2aA73BgQcL/5lUH5fRTn8Az+FP++kVW7p34VuaQ4BVk18erf5JX/6vI7hBB0kpO8FKGYfMzCY+JuMgDJgTe34U59GQ5KIW1+1if2j7xeCdtSgZJFPnz0Y/bqi70AtHHJrprZQi5m4IkvwfW/EYwxbTIctSnFvGJYpNSUK7ZhYyN72YpDkI1QwVxFeHLPyqc8be6N54PysaeRSiZoL32VySDsPZwZxgSuxdtKzfqCO8yxF5Bn7SrWSu25ZUVRHxS5ebixh+TrbCECi2zPt74YrAFvbriGG+UKj4diEjBu1rAHcHiTOOMl5nk36K2LP7HQOX51opMlFjIsCGJrx7VLNuBg5Oe9r71k+iqORjgYvl3NWm3o0eYYixmy0DG6etzK7r4ri/SkDB2az1NKZ+VBGNx/QwE9XFRzN51Pvw2Pne3kDzka5s+KCe1ZBlEk6Z3cL9QIay+kJOizVKza7M4kJFwqFNcLsbXteQaMT0DFSabLsl8/KcOG+1UJQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(44832011)(4326008)(6916009)(5660300002)(54906003)(53546011)(8676002)(70586007)(70206006)(36756003)(16576012)(8936002)(316002)(26005)(41300700001)(36860700001)(81166007)(82740400003)(356005)(82310400005)(2616005)(40480700001)(426003)(47076005)(40460700003)(336012)(186003)(2906002)(31696002)(86362001)(83380400001)(478600001)(31686004)(45080400002)(966005)(84970400001)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 10:53:35.1946
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 68d819a8-6d94-433c-3eb6-08dab1c02bc8
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT091.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4190

Hi Bertrand,

On 19/10/2022 12:40, Bertrand Marquis wrote:
> 
> 
> Hi Michal,
> 
>> On 19 Oct 2022, at 10:06, Michal Orzel <michal.orzel@amd.com> wrote:
>>
>> Hi Stefano,
>>
>> On 19/10/2022 02:02, Stefano Stabellini wrote:
>>>
>>>
>>> On Mon, 17 Oct 2022, Stefano Stabellini wrote:
>>>> It should be
>>>>
>>>> BB_NUMBER_THREADS="2"
>>>>
>>>> but that worked! Let me a couple of more tests.
>>>
>>> I could run successfully a Yocto build test with qemuarm64 as target in
>>> gitlab-ci, hurray! No size issues, no build time issues, everything was
>>> fine. See:
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193051236&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C5f7fc3a161fe44b5954808dab1be5c3a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017728406088513%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=2mb3N26wiz39RJNSA4KoIOt%2BG9X7EMDOWIpfKc2ZZOc%3D&amp;reserved=0
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193083119&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C5f7fc3a161fe44b5954808dab1be5c3a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017728406088513%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=QhTFefS8NU1f7oLemB0Vtn%2BDCD%2BCnq1v1gEmlKCJt84%3D&amp;reserved=0
>>>
>>> I made the appended changes in top of this series.
>>>
>>> - I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
>>>  registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64
>>> - for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
>>>  xen.git, not from a copy stored inside a container
>>> - when building the kirkstone-qemuarm64 container the first time
>>>  (outside of gitlab-ci) I used COPY and took the script from the local
>>>  xen.git tree
>>> - after a number of tests, I settled on: BB_NUMBER_THREADS="8" more than
>>>  this and it breaks on some workstations, please add it
>>> - I am running the yocto build on arm64 so that we can use the arm64
>>>  hardware to do it in gitlab-ci
>>>
>>> Please feel free to incorporate these changes in your series, and add
>>> corresponding changes for the qemuarm32 and qemux86 targets.
>>>
>>> I am looking forward to it! Almost there!
>>>
>>> Cheers,
>>>
>>> Stefano
>>>
>>>
>>> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
>>> index 0d31dad607..16f1dcc0a5 100755
>>> --- a/automation/build/yocto/build-yocto.sh
>>> +++ b/automation/build/yocto/build-yocto.sh
>>> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
>>> # Save some disk space
>>> INHERIT += "rm_work"
>>>
>>> +# Reduce number of jobs
>>> +BB_NUMBER_THREADS="8"
>>> +
>>> EOF
>>>
>>>     if [ "${do_localsrc}" = "y" ]; then
>>> diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
>>> index f279a7af92..aea3fc1f3e 100644
>>> --- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
>>> +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
>>> @@ -16,7 +16,8 @@ ARG target=qemuarm64
>>>
>>> # This step can take one to several hours depending on your download bandwith
>>> # and the speed of your computer
>>> -RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
>>> +COPY ./build-yocto.sh /
>>> +RUN /build-yocto.sh --dump-log $target
>>>
>>> FROM $from_image
>>>
>>> diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
>>> index 367a7863b6..ffbd91aa90 100644
>>> --- a/automation/build/yocto/kirkstone.dockerfile
>>> +++ b/automation/build/yocto/kirkstone.dockerfile
>>> @@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
>>>              /home/$USER_NAME/xen && \
>>>     chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
>>>
>>> -# Copy the build script
>>> -COPY build-yocto.sh /home/$USER_NAME/bin/
>>> -
>>> # clone yocto repositories we need
>>> ARG yocto_version="kirkstone"
>>> RUN for rep in \
>>> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
>>> index ddc2234faf..4b8bcde252 100644
>>> --- a/automation/gitlab-ci/build.yaml
>>> +++ b/automation/gitlab-ci/build.yaml
>>> @@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
>>>     EXTRA_XEN_CONFIG: |
>>>       CONFIG_BOOT_TIME_CPUPOOLS=y
>>>
>>> +yocto-kirkstone-qemuarm64:
>>> +  stage: build
>>> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
>>> +  script:
>>> +    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
>>> +  variables:
>>> +    CONTAINER: yocto:kirkstone-qemuarm64
>>> +  artifacts:
>>> +    paths:
>>> +      - '*.log'
>>> +      - '*/*.log'
>> The above lines are not needed as the logs/* below will handle them all (logs are only stored in logs/).
> 
> Ack
> 
>>
>>> +      - 'logs/*'
>>> +    when: always
>>> +  tags:
>>> +    - arm64
>>> +
>> build-yocto.sh performs both build and run actions. I think it'd be better to move this into test.yaml in that case.
>> The best would be to create one build job (specifying --no-run) in build.yaml and one test job (specifying --no-build) in test.yaml.
>> This however would probably require marking path build/tmp/deploy/***/qemuarm64 as an build artifact. The question then is
>> whether having this path would be enough for runqemu (Bertrand's opinion needed).
> 
> This will not be enough to run qemu as the qemu binary and its dependencies are in the build artifacts and not in deploy.
> Splitting the build and run is not a good idea because the size of the artifact between the 2 will be huge.
> 
>>
>> Apart from that there is an aspect of Yocto releases and the containers/tests names.
>> Yocto needs to be up-to-date in order to properly build Xen+tools.
>> This basically means that we will need to update the containers once
>> per Yocto release. The old containers would still need to be stored in our CI container registry
>> so that we can use CI for older versions of Xen. However, updating the containers would also require
>> modifying the existing tests (for now we have e.g. yocto-kirkstone-qemuarm64 but in a month we will have
>> to change them to yocto-langdale-qemuarm64). In a few years time this will result in several CI jobs
>> that are the same but differ only in name/container. I would thus suggest to name the CI jobs like this:
>> yocto-qemuarm64 (without yocto release name) and define the top-level YOCTO_CONTAINER variable to store
>> the current yocto release container. This will solve the issue I described above.
> 
> I think we have no other way around this and we will need to have one Yocto release supported by Xen officially so
> we will have to keep old docker images for old releases of Xen and move to newer versions of Yocto in staging when
> it is needed.
> 
> We have to find a way for gitlab-ci to use the build.yaml contained inside the tree that is to be tested somehow so that gitlab would automatically take the right one.
> Which means that build.yaml will be different between branches and contain the right version for the current branch.
> 

What I suggest is that with each new yocto release, we add new docker container files and push them to registry.
So we will end up in a registry having e.g. (arm64 as an example):
- kirkstone-qemuarm64
- langdale-qemuarm64
We maintain only the one group of CI jobs whose names are generic (yocto-qemuarm64).
After adding new containers for a new Yocto release, we modify the YOCTO_RELEASE variable
to point to the latest yocto release containers.

test.yaml:
...
# Yocto test jobs
variables:
  YOCTO_RELEASE: "kirkstone"

yocto-qemuarm64:
  extends: .test-jobs-common
  script:
    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
  variables:
    CONTAINER: yocto:${YOCTO_RELEASE}-qemuarm64
  artifacts:
    paths:
      - 'logs/*'
    when: always
  tags:
    - arm64

This means that:
- on the current staging branch the YOCTO_RELEASE points to the latest containers (for the latest yocto release)
- on the old stable branches the YOCTO_RELEASE points to the old containers (for the old yocto release).

~Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 10:53:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 10:53:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425730.673756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6ht-00031b-OR; Wed, 19 Oct 2022 10:53:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425730.673756; Wed, 19 Oct 2022 10:53:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol6ht-00031Q-LP; Wed, 19 Oct 2022 10:53:53 +0000
Received: by outflank-mailman (input) for mailman id 425730;
 Wed, 19 Oct 2022 10:53:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CpyO=2U=gmail.com=koct9i@srs-se1.protection.inumbo.net>)
 id 1ol6hs-00030S-7k
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 10:53:52 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50863696-4f9c-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 12:53:50 +0200 (CEST)
Received: by mail-lj1-x229.google.com with SMTP id i21so18706852ljh.12
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 03:53:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50863696-4f9c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=SLJhYMtLXgKI7Y17ZUIiMFD3J1dSMKzi0bGsbw5e7go=;
        b=BIopzC1/zEhmwdduNBVA6swDAiJ/PaY8ch4dJ2rG5XuPIEphc4HpFIwENy/oXgcF77
         g26f5vpGaEszcK++cCcUTKXnXewQJhMolM/QKzyYXNbX9xSmjD/h8CuNjZnIiz7Pow8u
         9oViyTjYtEDviMMGlKH85v/Ws+BdAJzTCaIXgEvN2cQC8OYtO73LOuvgzZLgMf+F+rIG
         mtckB/MCVPgD2rV3KUTEV82YQSZME3UNkpjhzr5nvBMLdEHKNnoKLk44gbindiuqP3++
         9IOegW4jhF+LV2Vq5vqvc4+NLv43nVgJjixrVLu9Nl+mWgLbiiG+y5EemQvr99KzMTYQ
         tpgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=SLJhYMtLXgKI7Y17ZUIiMFD3J1dSMKzi0bGsbw5e7go=;
        b=xV0S/2yb8Zn01SCLrXGGRr3ljRXG3XGf7zg3ZQN51G8XWbQOw205PS73GMh875T+mB
         2UqIFaSDQHIWzl3nyw/MXA5mZtTuveyR7rLY9oopfmYQDOlyXXy3HGR5c5+DTYag5Yp2
         da8YKF2ujTIgUimkcra6lOB0CW9ARom1cqJ1zAsqfHIf43FiKsfLlR9v0/Ctrgw/wxx8
         Tg/+6yjovJU4LXW3X7BGa3zu609DZ1/fLRwosxOQhDkmdTGvQ3PDN0MMKb4ubwQcG1cn
         jJ/MSwpWfUq34iCibM9nkbOX4G4jaEEZqjL2LtWQcpUGQFg1G5PmkpR79cDB/0qzm5Na
         rcRw==
X-Gm-Message-State: ACrzQf3qSUITs8nguRUCUGoMXLxZ8lMKuPfQztrlzMqwv4XsXw6WL3Q4
	J8lPSLMRqFkmqVMW8fbKgOk+tzcZLRHt5VfLmvk=
X-Google-Smtp-Source: AMsMyM56LTTzTKGc4F++LzICGIh8ple7Tae6Xn81CIYsoHyoaHlCwHgx+9D2SKe1qtnypzSnzS56crQyLn1GyeQTpJg=
X-Received: by 2002:a05:651c:194c:b0:26f:ec78:6172 with SMTP id
 bs12-20020a05651c194c00b0026fec786172mr2697844ljb.479.1666176829774; Wed, 19
 Oct 2022 03:53:49 -0700 (PDT)
MIME-Version: 1.0
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
In-Reply-To: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
From: Konstantin Khlebnikov <koct9i@gmail.com>
Date: Wed, 19 Oct 2022 13:53:38 +0300
Message-ID: <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com>
Subject: Re: [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to
 the rest of the kernel
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: kernel@openvz.org, kernel test robot <lkp@intel.com>, 
	"Michael S . Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, Wei Liu <wei.liu@kernel.org>, 
	Nadav Amit <namit@vmware.com>, pv-drivers@vmware.com, Jason Wang <jasowang@redhat.com>, 
	virtualization@lists.linux-foundation.org, 
	"K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, 
	Stephen Hemminger <sthemmin@microsoft.com>, Dexuan Cui <decui@microsoft.com>, 
	linux-hyperv@vger.kernel.org, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="00000000000012626105eb6106d0"

--00000000000012626105eb6106d0
Content-Type: text/plain; charset="UTF-8"

On Wed, 19 Oct 2022 at 12:57, Alexander Atanasov <
alexander.atanasov@virtuozzo.com> wrote:

> Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
> inflate and deflate the guest memory size but there is no
> way to know how much the memory size is changed by them.
>
> Make it possible for the drivers to report the values to mm core.
>
> Display reported InflatedTotal and InflatedFree in /proc/meminfo
> and print these values on OOM and sysrq from show_mem().
>
> The two values are the result of the two modes the drivers work
> with using adjust_managed_page_count or without.
>
> In earlier versions, there was a notifier for these changes
> but after discussion - it is better to implement it in separate
> patch series. Since it came out as larger work than initially expected.
>
> Amount of inflated memory can be used:
>  - totalram_pages() users working with drivers not using
>     adjust_managed_page_count
>  - si_meminfo(..) users can improve calculations
>  - by userspace software that monitors memory pressure
>

Sorry, I see no reason for that series.
Balloon inflation adjusts totalram_pages. That's enough.

There is no reason to know the amount of non-existent ballooned memory
inside.
Management software which works outside should care about that.

For debugging you could get current balloon size from /proc/vmstat
(balloon_inflate - balloon_deflate).
Also (I guess) /proc/kpageflags has a bit for that.

Anyway it's easy to monitor balloon inflation by seeing changes of total
memory size.


>
> Alexander Atanasov (8):
>   mm: Make a place for a common balloon code
>   mm: Enable balloon drivers to report inflated memory
>   mm: Display inflated memory to users
>   mm: Display inflated memory in logs
>   drivers: virtio: balloon - report inflated memory
>   drivers: vmware: balloon - report inflated memory
>   drivers: hyperv: balloon - report inflated memory
>   documentation: create a document about how balloon drivers operate
>
>  Documentation/filesystems/proc.rst            |   6 +
>  Documentation/mm/balloon.rst                  | 138 ++++++++++++++++++
>  MAINTAINERS                                   |   4 +-
>  arch/powerpc/platforms/pseries/cmm.c          |   2 +-
>  drivers/hv/hv_balloon.c                       |  12 ++
>  drivers/misc/vmw_balloon.c                    |   3 +-
>  drivers/virtio/virtio_balloon.c               |   7 +-
>  fs/proc/meminfo.c                             |  10 ++
>  .../linux/{balloon_compaction.h => balloon.h} |  18 ++-
>  lib/show_mem.c                                |   8 +
>  mm/Makefile                                   |   2 +-
>  mm/{balloon_compaction.c => balloon.c}        |  19 ++-
>  mm/migrate.c                                  |   1 -
>  mm/vmscan.c                                   |   1 -
>  14 files changed, 213 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/mm/balloon.rst
>  rename include/linux/{balloon_compaction.h => balloon.h} (91%)
>  rename mm/{balloon_compaction.c => balloon.c} (94%)
>
> v4->v5:
>  - removed notifier
>  - added documentation
>  - vmware update after op is done , outside of the mutex
> v3->v4:
>  - add support in hyperV and vmware balloon drivers
>  - display balloon memory in show_mem so it is logged on OOM and on sysrq
> v2->v3:
>  - added missed EXPORT_SYMBOLS
> Reported-by: kernel test robot <lkp@intel.com>
>  - instead of balloon_common.h just use balloon.h (yes, naming is hard)
>  - cleaned up balloon.h - remove from files that do not use it and
>    remove externs from function declarations
> v1->v2:
>  - reworked from simple /proc/meminfo addition
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Wei Liu <wei.liu@kernel.org>
> Cc: Nadav Amit <namit@vmware.com>
> Cc: pv-drivers@vmware.com
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: virtualization@lists.linux-foundation.org
> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Dexuan Cui <decui@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Cc: xen-devel@lists.xenproject.org
>
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> --
> 2.31.1
>
>

--00000000000012626105eb6106d0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, 19 Oct 2022 at 12:57, Alexander A=
tanasov &lt;<a href=3D"mailto:alexander.atanasov@virtuozzo.com">alexander.a=
tanasov@virtuozzo.com</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex">Currently balloon drivers (=
Virtio,XEN, HyperV, VMWare, ...)<br>
inflate and deflate the guest memory size but there is no<br>
way to know how much the memory size is changed by them.<br>
<br>
Make it possible for the drivers to report the values to mm core.<br>
<br>
Display reported InflatedTotal and InflatedFree in /proc/meminfo<br>
and print these values on OOM and sysrq from show_mem().<br>
<br>
The two values are the result of the two modes the drivers work<br>
with using adjust_managed_page_count or without.<br>
<br>
In earlier versions, there was a notifier for these changes<br>
but after discussion - it is better to implement it in separate<br>
patch series. Since it came out as larger work than initially expected.<br>
<br>
Amount of inflated memory can be used:<br>
=C2=A0- totalram_pages() users working with drivers not using<br>
=C2=A0 =C2=A0 adjust_managed_page_count<br>
=C2=A0- si_meminfo(..) users can improve calculations<br>
=C2=A0- by userspace software that monitors memory pressure<br></blockquote=
><div><br></div><div>Sorry, I see no reason for that series.</div><div>Ball=
oon inflation adjusts totalram_pages. That&#39;s enough.</div><div><br></di=
v><div>There is no reason to know the amount of non-existent ballooned memo=
ry inside.<br></div><div>Management software which works outside should car=
e about that.</div><div><br></div><div>For debugging you could get current=
=C2=A0balloon=C2=A0size from /proc/vmstat (balloon_inflate -=C2=A0balloon_d=
eflate).</div><div>Also (I guess) /proc/kpageflags has a bit for that.</div=
><div><br></div><div>Anyway it&#39;s easy to monitor balloon=C2=A0inflation=
 by seeing changes of total memory size.</div><div>=C2=A0</div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">
<br>
Alexander Atanasov (8):<br>
=C2=A0 mm: Make a place for a common balloon code<br>
=C2=A0 mm: Enable balloon drivers to report inflated memory<br>
=C2=A0 mm: Display inflated memory to users<br>
=C2=A0 mm: Display inflated memory in logs<br>
=C2=A0 drivers: virtio: balloon - report inflated memory<br>
=C2=A0 drivers: vmware: balloon - report inflated memory<br>
=C2=A0 drivers: hyperv: balloon - report inflated memory<br>
=C2=A0 documentation: create a document about how balloon drivers operate<b=
r>
<br>
=C2=A0Documentation/filesystems/proc.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 |=C2=A0 =C2=A06 +<br>
=C2=A0Documentation/mm/balloon.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 | 138 ++++++++++++++++++<br>
=C2=A0MAINTAINERS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=
=A0 =C2=A04 +-<br>
=C2=A0arch/powerpc/platforms/pseries/cmm.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 |=C2=A0 =C2=A02 +-<br>
=C2=A0drivers/hv/hv_balloon.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 12 ++<br>
=C2=A0drivers/misc/vmw_balloon.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A03 +-<br>
=C2=A0drivers/virtio/virtio_balloon.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A07 +-<br>
=C2=A0fs/proc/meminfo.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 10 ++<br>
=C2=A0.../linux/{balloon_compaction.h =3D&gt; balloon.h} |=C2=A0 18 ++-<br>
=C2=A0lib/show_mem.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A08 +<=
br>
=C2=A0mm/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=
=A0 =C2=A02 +-<br>
=C2=A0mm/{balloon_compaction.c =3D&gt; balloon.c}=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 |=C2=A0 19 ++-<br>
=C2=A0mm/migrate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=
=A01 -<br>
=C2=A0mm/vmscan.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=
=A0 =C2=A01 -<br>
=C2=A014 files changed, 213 insertions(+), 18 deletions(-)<br>
=C2=A0create mode 100644 Documentation/mm/balloon.rst<br>
=C2=A0rename include/linux/{balloon_compaction.h =3D&gt; balloon.h} (91%)<b=
r>
=C2=A0rename mm/{balloon_compaction.c =3D&gt; balloon.c} (94%)<br>
<br>
v4-&gt;v5:<br>
=C2=A0- removed notifier<br>
=C2=A0- added documentation<br>
=C2=A0- vmware update after op is done , outside of the mutex<br>
v3-&gt;v4:<br>
=C2=A0- add support in hyperV and vmware balloon drivers<br>
=C2=A0- display balloon memory in show_mem so it is logged on OOM and on sy=
srq<br>
v2-&gt;v3:<br>
=C2=A0- added missed EXPORT_SYMBOLS<br>
Reported-by: kernel test robot &lt;<a href=3D"mailto:lkp@intel.com" target=
=3D"_blank">lkp@intel.com</a>&gt;<br>
=C2=A0- instead of balloon_common.h just use balloon.h (yes, naming is hard=
)<br>
=C2=A0- cleaned up balloon.h - remove from files that do not use it and<br>
=C2=A0 =C2=A0remove externs from function declarations<br>
v1-&gt;v2:<br>
=C2=A0- reworked from simple /proc/meminfo addition<br>
<br>
Cc: Michael S. Tsirkin &lt;<a href=3D"mailto:mst@redhat.com" target=3D"_bla=
nk">mst@redhat.com</a>&gt;<br>
Cc: David Hildenbrand &lt;<a href=3D"mailto:david@redhat.com" target=3D"_bl=
ank">david@redhat.com</a>&gt;<br>
Cc: Wei Liu &lt;<a href=3D"mailto:wei.liu@kernel.org" target=3D"_blank">wei=
.liu@kernel.org</a>&gt;<br>
Cc: Nadav Amit &lt;<a href=3D"mailto:namit@vmware.com" target=3D"_blank">na=
mit@vmware.com</a>&gt;<br>
Cc: <a href=3D"mailto:pv-drivers@vmware.com" target=3D"_blank">pv-drivers@v=
mware.com</a><br>
Cc: Jason Wang &lt;<a href=3D"mailto:jasowang@redhat.com" target=3D"_blank"=
>jasowang@redhat.com</a>&gt;<br>
Cc: <a href=3D"mailto:virtualization@lists.linux-foundation.org" target=3D"=
_blank">virtualization@lists.linux-foundation.org</a><br>
Cc: &quot;K. Y. Srinivasan&quot; &lt;<a href=3D"mailto:kys@microsoft.com" t=
arget=3D"_blank">kys@microsoft.com</a>&gt;<br>
Cc: Haiyang Zhang &lt;<a href=3D"mailto:haiyangz@microsoft.com" target=3D"_=
blank">haiyangz@microsoft.com</a>&gt;<br>
Cc: Stephen Hemminger &lt;<a href=3D"mailto:sthemmin@microsoft.com" target=
=3D"_blank">sthemmin@microsoft.com</a>&gt;<br>
Cc: Dexuan Cui &lt;<a href=3D"mailto:decui@microsoft.com" target=3D"_blank"=
>decui@microsoft.com</a>&gt;<br>
Cc: <a href=3D"mailto:linux-hyperv@vger.kernel.org" target=3D"_blank">linux=
-hyperv@vger.kernel.org</a><br>
Cc: Juergen Gross &lt;<a href=3D"mailto:jgross@suse.com" target=3D"_blank">=
jgross@suse.com</a>&gt;<br>
Cc: Stefano Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org" target=
=3D"_blank">sstabellini@kernel.org</a>&gt;<br>
Cc: Oleksandr Tyshchenko &lt;<a href=3D"mailto:oleksandr_tyshchenko@epam.co=
m" target=3D"_blank">oleksandr_tyshchenko@epam.com</a>&gt;<br>
Cc: <a href=3D"mailto:xen-devel@lists.xenproject.org" target=3D"_blank">xen=
-devel@lists.xenproject.org</a><br>
<br>
base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780<br>
-- <br>
2.31.1<br>
<br>
</blockquote></div></div>

--00000000000012626105eb6106d0--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 11:22:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 11:22:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425746.673773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol79Q-0006nj-5B; Wed, 19 Oct 2022 11:22:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425746.673773; Wed, 19 Oct 2022 11:22:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol79Q-0006nc-1D; Wed, 19 Oct 2022 11:22:20 +0000
Received: by outflank-mailman (input) for mailman id 425746;
 Wed, 19 Oct 2022 11:22:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tQ2t=2U=citrix.com=prvs=28491fd06=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ol79P-0006nW-1r
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 11:22:19 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47dd838e-4fa0-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 13:22:17 +0200 (CEST)
Received: from mail-mw2nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Oct 2022 07:21:45 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by CO1PR03MB5859.namprd03.prod.outlook.com (2603:10b6:303:98::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Wed, 19 Oct
 2022 11:21:40 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::7131:3804:744b:d7cc%6]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 11:21:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47dd838e-4fa0-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666178536;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=6WBXppwj+sXpeKK0SJMJ07eAjAzaRK+57WPAOXAjyXo=;
  b=gJpzaxBGJFsTHoXwl5V6VRui+zl2nTNYLioMl/7h9qHeH/8BaOdws58m
   zI4SRoymS/Fz/6kNv2jhnqpWR2/RrTz/5xd7MJ5YteYczCvuj2SMbmxkn
   d+WPN3EZjryHJrWpV+89R3oU4iHxdWMPXK/Nj4jVo3MfNSU6drsp8Aytd
   E=;
X-IronPort-RemoteIP: 104.47.55.104
X-IronPort-MID: 85587839
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:JofiV6N7TBg7dY3vrR3ol8FynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem
 TxOHSzEb+HbITHFz+oGOo2190sEv8fQz941SAo+ri88EykSp5fMVIvFIBetMynMfsHIFxJt5
 p9CY4nKc8xuFyDXrx73YuC58iV3i63ZHtIQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKl5
 Yiv+JeBZwSsi24vPGlLsa/e+B03sPit4GMR5AIzPfsa4FOGm3crV59OfqvZw1kU4GV3NrXjG
 7ucluHREkfxpUpF5gaNy+6jGqEyaueOe1LI0hK6YoD66jBavCs+z60nA/QVbEZTml2hkst4j
 d5ArvRccy9wVkH3sLlbAkQw/x1WZ/UcouafeCnn66R/8mWdG5fS66Q2ZK0JFdVwFtZfWQlm6
 fEeITYRWRGP78reLGWTE7QEamwLdaEHDatH0p1S5Wix4cUOGPgvd57i995AtArcs+gVdRroi
 2j1XhI0BPjIS0Un1l76k/vSls/w7pX0W2UwRF54OcPbSoUcpeB8+OGFDTbbRjCFbZ58rB+3q
 174xUHkBlYjG/6R0DuK8m3504cjnQujMG4TPJuR06cyxXisnCkUAhBQUkanq/6kjEL4Q8hYN
 0Ef5ispq+416VCvSd7+GRa/pRZovDZFA4YWT7J8tVzLk/KIi+qaLjFsojppR9EhrsA7AxA30
 FuAh/viBCB1sa3TQnWYnluRhWPvZHhKfTRTDcMCZRZcyeegjcYLtRXSEu5SC7WapYLeKy6ll
 lhmqwB73d3/l/Uj1a+24FTGiDKEvYXSQ0g+4QC/dkKo6BloIrGsYYOA4ELeq/1HKe6xUV2pr
 HUC3c+E44gmBpaIkTGLQfkcWrSg4f+KPSf0kVNpB4Mm9Tmm5zikZ484yCFzIgJlP9gJfRftY
 VTPokVB6ZlLJnyoYKRrJYWrBKwXIbPIEN3kUrXRcYBIa50oLAufpng2OQiXwnznl1UqnecnI
 5CHfM2wDHEcT6N60D6xQORb2rgurswj+V7uqVnA50zP+dKjiLS9EN/p7HPmgjgF0Z65
IronPort-HdrOrdr: A9a23:eGF6tK9arWyZAcHkFNpuk+Fudb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8bpYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ
 uIEJIOReEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK
 DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561
 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu
 O85yvIcf4DrE85NVvF3CcFkzOQrArGrUWShWNwyEGT3/DRVXY0DdFMipledQac4008vMtk2K
 YOxG6BsYFLZCmw1RgUd7DzJm5Xf2eP0A0feNQo/gpieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO
 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u
 yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou
 W1bLp1jx9AR6u1M7z+4HRiyGG8fEytGTLw18pZ+591/rXhWbuDC1zwdGwT
X-IronPort-AV: E=Sophos;i="5.95,196,1661832000"; 
   d="asc'?scan'208,217";a="85587839"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ilXuer1s2hilPR2EvCTGTre73twTC2Tt3N4JvQcQrS5EK6nrJucE9y3Ruz8ikk5WasaiL4Wdd4FwloNpoRnL2OTv9DIJKUrvgDKQ9mJH0zAFUn0uH1MnxtsaA0DTAWHO9lXm7XDUOm0XJSOPGG/bHo06hnsREqyWDgATQ2SZqQ/4yFDSGx9xcmLaMMU7Eh9LftLrbsiV9WXxduuzjDYSvOFYn+is/6b/BsSeKJuRh8z/LniESKHR8+SKgWtV3x6QcHfenF+A9ep5FjVlpMqLHjM+z1tRe402ICNRtJzyPeOF4MSvl7nwlJtwVxrp4j4mnt+9g9PBT7KMcco/QM52OA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iSkTZjb1eo2iV4Ni3JTl84m6pfrasfAIVln131ZTn38=;
 b=KJnKZhGPQf8F2wqUnCvgsR4YwBn6xU9csdMAQU+WZ8v7YzjBMtR5W0WfFuKmqBPHjWPc/vDg6opGEjdUZ/F7zl4tVX3lb63xTLiaSjBxZ3vzshKkpE+tsSTyTBUfgsX/Yh/wzPAaYZjwLQcq6d6V528DhNfwos46DnzOXhfoUh5EBg85z399lq6OjOJ+0GlRgo5wBCkjMYsCiM7tm35rFwGfGjvunmjISbUFyE89Kx4sh0O27X2/Ub7FKBJvWonMuR2lug9GxF+8GjF6oVVA9LHSsO6bz+FqBlu1JTKuMBlBVyLyn3AmvOmKz6ohyWcBbLsWl+IiQdphsWlM8wMjgg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iSkTZjb1eo2iV4Ni3JTl84m6pfrasfAIVln131ZTn38=;
 b=QhC7iTVJ9JcRs0C0hArVYpP24y8Orp/IgCtE1lugmgkDt6QV7AwI8x3TtiENC+D2DwSz419pSfSwd4X4THsmGNSYmRDQxagNr8I/SpaKgy/oHjVvJQrAVrGK0u/hiyXPPEqzoqdzqB0AGGrq4q1Df4OdhJ/wuGLPg0DzjHzAKfo=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Wei Liu <wl@xen.org>, Community Manager
	<community.manager@xenproject.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM
 guests
Thread-Topic: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM
 guests
Thread-Index:
 AQHYagNDrZ0UxO/94kuHn0c4ykfZPq2wJomAgAADuACAABCxAIAAoG4AgADJ4gCAZOCcgA==
Date: Wed, 19 Oct 2022 11:21:39 +0000
Message-ID: <A28D01E5-F7D1-4AC5-8A41-C03C77BF882E@citrix.com>
References: <20220517153127.40276-1-roger.pau@citrix.com>
 <53cc6a9f-5a4e-0716-fe08-ad86fc155cbf@suse.com>
 <1dbab710-6d3c-a6cb-faa7-31558c04aab2@citrix.com>
 <3a975638-9675-9a95-fead-91120edefee1@suse.com>
 <07176f1c-2759-ddb0-1d59-38b4504d0ed4@citrix.com>
 <bd319ac0-0f17-5461-5508-d383dfe07308@suse.com>
In-Reply-To: <bd319ac0-0f17-5461-5508-d383dfe07308@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|CO1PR03MB5859:EE_
x-ms-office365-filtering-correlation-id: bfb303be-7498-4014-4f7a-08dab1c417f6
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 OJ6RmIsWZ9kTtUu89iOwatD+fEmAmMysYgIyfsONZS52GdQPuGrCrCg4bOyXMq3ZNjthZQWFfsfiAMoEePVlX0qmbzuSGMvWMDqJbRP0p7DM3GOW7rv6DS6w45nuzHrGq7jLGUqcAf7D8NqdQgePtzfUpv8man06DJT5AE0WE7vlQSVKBKXD/y0SNEh2rBTV9XWc0fZ1rDP7rEhyEZ5H1+wRFu/K6On5nrd6G0FLmtT2p2F7x/QFcBRYKMvKPK/caBj3U7Lcn597crKtqhLd00NYp4DEqMc8mDPnP47EnGREhQzU9/PD+qEzeoe+7N+9bi/tpUZElBiV44eNjg4cNHm6Sbdl/fA+TnAWWsef96Q/Di6WC14IBbbcWHX57QOBFOWbxky/PXQURtzikxVN7od8SL9LgsvR3LJwJq80/FuvDqG786CEeE3XGhMHTHpaNcOYQ0cwreB/ueYlRu01idOCQjnxeDJZWC1YixNUAxZ6OKz60bR7iV4X8hiLw//Fp12ZdA44meTI0xOOS3L9kVLmdsRlM/AXUHmHdLN5FuHvK95FbER6QJGcvlfUBfzbuCL7oRkDFLAKqVkQx7V/cLPSxrl9quizC0vw7T3wwIeAvFJYom4IX+z8552RhK+JmnckHDFpXyP3/0nenCvE1wIiDXorzDKJ/k5oH7V87s/z8qtalYwmVTR8Fc2r4zX/f+LwXO8Tsa9YTK0qkZBOyoNdkpO3542VJPEo6CFXr4z4nsq0owyZa84xFKRe+C6KNCyMLmUhmhNwtHoBtCKcV8AgG14rcZCQXWvO2vKGV5j19b+klJy3eUwok4mHX+Ai
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(366004)(451199015)(6916009)(54906003)(82960400001)(2616005)(316002)(38100700002)(2906002)(186003)(71200400001)(33656002)(122000001)(99936003)(6486002)(478600001)(38070700005)(36756003)(5660300002)(6506007)(6512007)(8936002)(41300700001)(86362001)(26005)(76116006)(66556008)(107886003)(8676002)(4326008)(66476007)(91956017)(66446008)(64756008)(66946007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VjZYTW5EQXhGZmgxZjFGNjh3aXcrR3BaWTRqUEtDQTZJYXVrejNKWVNnUWlD?=
 =?utf-8?B?Mmt3WklGMTlpV0ZtZTE1MkRPVkdRcEJWMXpQd2VPQlVNcDFHSURSMXhNUnhC?=
 =?utf-8?B?VjVubmpHeFAzVit6TW5PYjM5ZHdtbENER0lCVTFCZ1V1ampRRkE0MHYrTS9M?=
 =?utf-8?B?cXVvNGtWWUJXdGpidENZeDlOQVZ3Z3BaM2hNZkVIR1lHaUdMbmU1blRwMjV5?=
 =?utf-8?B?dnJDOHhpeUI5UE8yUGZTUjBXNkpqZDgzczNJVG8xVjZLeWh1ME0vRGxLcFBP?=
 =?utf-8?B?UHlubzZlRTFiNGh1cGNLNnlwRVlxSzhGVVltMmIwSlhQQS9VR3V4TUQ3OVYy?=
 =?utf-8?B?S0plc1RzckJjdUhOYTJGOWl6cHRLTW14RXozY0I5K0pZakpDdmRaUmMvbDNF?=
 =?utf-8?B?ZlAxb2QxUjlDd2NKUnlETVVuSUNuMjllcm41N0lYVXAvSktLamp0TWpDcUNP?=
 =?utf-8?B?Q2xnRG52L2NIZjNZbzdQc0w5MktlZ3Q1RDFtN2lOWjhySStiTnJGRlZianQy?=
 =?utf-8?B?V1Rhb1N0dG14cTBLSVI4L1BGTVgzMG4xTURXT0FDOWRVZERMalM2UDNVTERH?=
 =?utf-8?B?eWVoYmVhSHM2WjA3M3IvcmFVRDZwZW91akR3cnh3SkdPTU1URkM3NzRUelpu?=
 =?utf-8?B?S1lHaEh3L0pxcEhjUHI4T2I2bjFTUVZiYU9BQ1ZwNytIQlh5bmQ4RVdRSTVB?=
 =?utf-8?B?TFVFcG5UeE1mWUx2UFpXWTlNc2liTkRBbUpRVW85bHZBaDJzRFZnN2VibGNL?=
 =?utf-8?B?aXdPWmtKWjRlUitqWm94NU1JejFlbkxBQW5ha05UcXN1dWRLWmJ3L0VLQkpq?=
 =?utf-8?B?U0QyR2d0WFJvNEROQ2NCWWU1RDN2VHJGMmpkVzhFdXRsNDloNzZnNnA0RWJE?=
 =?utf-8?B?L25DeDNHdHpFZkNoSFIzYmR3aUdoOWxqTXliWlladllvOE5HYWMyVllXYm43?=
 =?utf-8?B?RXlianNNTFRpUWx3c2ZBK2lZK2Q2QlZEZER0TzBnSEd4a2ttSnowNm5yejhp?=
 =?utf-8?B?c3pSSVVRS0xlMmMrWFVLWDRQNEU4L0RaeHNacjZIVGhYR3RYRGM0eUFJU3NN?=
 =?utf-8?B?dVFXSEl3d3ZuaWdtVzNTK3V2OEgwd0lwdW40ZHA0OFYxVVUvKzZKdWtnMFFy?=
 =?utf-8?B?NUF4aWg2WnZtV0MvS1JhQUZiSndKNWF6NHhSdEladVlvTWp4QjErWEZtTy8r?=
 =?utf-8?B?cHltWTNFQXdVMnZZNVZpWFRHcDBGdThPOEFDSzd2QVlac05ZdkY0TzBFQjNn?=
 =?utf-8?B?aHE0bTA1UW1wdEhuYm5XS0tBanMrem0zNVdLd1B0RFIyMU95d01NUTArOWZx?=
 =?utf-8?B?NzR6aFh3ZkdlRWxOYXFUeXlDRHZOUHpnbHV1dTFoRFE5M3JnWGN5Wk10RjdI?=
 =?utf-8?B?Z0ZxTFNIcTB5dmpOcytocW0vWVdRYXlTVEcvUlVGeVZSUXQvOVBYQ1IwWlRh?=
 =?utf-8?B?OTBKaFc0YXlPQnpOUFdPOXNhMUhBVVU5NzBoNWRIZ0N4MTVDK1hMd1ZxaFV2?=
 =?utf-8?B?RFgxMmZmTU5WNERjcTB3eVVXSU4reG5kTXlRcGdXN0gycXF6VmRuZFFLZkVa?=
 =?utf-8?B?YjJuMVoveHNNN0kyM1pJdkhLTEx6UVk1cnlnNXR5Ykk2QWdJT2VwWVpISG9G?=
 =?utf-8?B?elNheS9zcnJaOVFTZlQ5MUQ2eEYxL00wRU5iT1BTQ29veWZUZE10WDdHS1pY?=
 =?utf-8?B?NG54M0Q0YnMvQjY2RTR4T0c0bTFETHlMdERyak1HNTZobkdjZFh5QlNwZXJP?=
 =?utf-8?B?SHA3NC9hejNpZjVvYktmSVk2RkNaM3ZicWpzVFA0MTZ1b0l6M0ovQXpFU2Mz?=
 =?utf-8?B?UFdtbVVYY0lQWklIMnVaeUlnTDlrL1lXK0tHSm5QK2VKVUozNHNpcFBXRmJm?=
 =?utf-8?B?N3I1dWtyMVI2WW41R2tvUWEySW83UzgwNTJ2RkxySWpOT1V2NUxVZzRwMEJw?=
 =?utf-8?B?ZTFybVZaUmJvRTV4SGU1K1FDbHpBQVg2YUR3YzNwNHhUZ3BFQWYzbnpiTzdR?=
 =?utf-8?B?ZlFtcFVmOUZaY2FIdXdRVHNBOUNDaUk1Z29PK2VNUHVEUkxhVlpJQ0RHd1BE?=
 =?utf-8?B?cE9SaVNxcXcrclZOUnc5NTkxZ25xaUQ3UlBYb2FZYmhoUEtaL2ozaWVRV3NK?=
 =?utf-8?B?bzVlS2RPMUxWTlZQZkpoWVJYY21Xdjlkdm1jODRENE5sblJtNjl6RkFHb240?=
 =?utf-8?B?dVE9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_A97D27F9-52DA-4212-8F2D-A650CCD30534";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfb303be-7498-4014-4f7a-08dab1c417f6
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 11:21:39.9446
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MMAneFqisW+bOg2Qk+Q10Yf/I6of1O9Rm2a+vPFNSLpsdcdMIqs5/m+wY3h7JfLTxCT0rVLUVhm5LAuWJNesn1N75Gn1VHKXL+zA03gzWQY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5859

--Apple-Mail=_A97D27F9-52DA-4212-8F2D-A650CCD30534
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_AE78D5F4-4F3C-482D-B31E-5B1E51AF6CD7"


--Apple-Mail=_AE78D5F4-4F3C-482D-B31E-5B1E51AF6CD7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Hello all,

This thread was brought to the attention of the Code of Conduct team =
because it contains some fairly serious accusations. Having looked into =
the matter, and given the people involved a chance to respond, we=E2=80=99=
d like to set the record straight (to the best of our current =
knowledge).

First of all, we=E2=80=99d like to acknowledge that the issue addressed =
in this series has been a long-term source of frustration: Andrew first =
mentioned the need for this functionality in 2018, and from then until =
January 2022 repeatedly mentioned it as something critical to get in but =
which he simply didn=E2=80=99t have time to personally address.

That said, while his frustration is understandable, there were a number =
of accusations made which, as far as we can tell, were unfounded; so we =
want to set the record straight. In particular, having looked into the =
history of this series and had discussions with all the parties, we have =
concluded the following:

* Roger attempted to address all of the feedback Andrew gave; and not =
only was the minimum check-in process followed, but Jan and Roger made =
every effort to get Andrew's feedback before checking in the patch.

* The "Suggested-by" tags were reasonable for Roger to have put in, and =
reasonable for Jan to have retained.

This is not the kind of community we strive to be. In particular, we=E2=80=
=99d like to exhort people to avoid charged language and attempt to lay =
out the facts =E2=80=94 with references =E2=80=94 such that they speak =
for themselves.

We are also attempting to improve communication and shared =
understanding, to hopefully keep frustration levels low in the future.

Thanks,

 -The Xen Project Conduct Team

--Apple-Mail=_AE78D5F4-4F3C-482D-B31E-5B1E51AF6CD7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; =
-webkit-line-break: after-white-space;" class=3D""><p =
style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" class=3D"">Hello=
 all,<br class=3D""><br class=3D"">This thread was brought to the =
attention of the Code of Conduct team because it contains some fairly =
serious accusations. Having looked into the matter, and given the people =
involved a chance to respond, we=E2=80=99d like to set the record =
straight (to the best of our current knowledge).<br class=3D""><br =
class=3D"">First of all, we=E2=80=99d like to acknowledge that the issue =
addressed in this series has been a long-term source of frustration: =
Andrew first mentioned the need for this functionality in 2018, and from =
then until January 2022 repeatedly mentioned it as something critical to =
get in but which he simply didn=E2=80=99t have time to personally =
address.<br class=3D""><br class=3D"">That said, while his frustration =
is understandable, there were a number of accusations made which, as far =
as we can tell, were unfounded; so we want to set the record straight. =
In particular, having looked into the history of this series and had =
discussions with all the parties, we have concluded the following:<br =
class=3D""></p><p style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, =
0);" class=3D"">* Roger attempted to address all of the feedback Andrew =
gave; and not only was the minimum check-in process followed, but Jan =
and Roger made every effort to get Andrew's feedback before checking in =
the patch.<br class=3D""></p><p style=3D"caret-color: rgb(0, 0, 0); =
color: rgb(0, 0, 0);" class=3D"">* The "Suggested-by" tags were =
reasonable for Roger to have put in, and reasonable for Jan to have =
retained.<br class=3D""></p><p style=3D"caret-color: rgb(0, 0, 0); =
color: rgb(0, 0, 0);" class=3D"">This is not the kind of community we =
strive to be. In particular, we=E2=80=99d like to exhort people to avoid =
charged language and attempt to lay out the facts =E2=80=94 with =
references =E2=80=94 such that they speak for themselves.<br =
class=3D""></p><p style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, =
0);" class=3D"">We are also attempting to improve communication and =
shared understanding, to hopefully keep frustration levels low in the =
future.</p><p style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" =
class=3D"">Thanks,</p><p style=3D"caret-color: rgb(0, 0, 0); color: =
rgb(0, 0, 0);" class=3D"">&nbsp;-The Xen Project Conduct =
Team</p></body></html>=

--Apple-Mail=_AE78D5F4-4F3C-482D-B31E-5B1E51AF6CD7--

--Apple-Mail=_A97D27F9-52DA-4212-8F2D-A650CCD30534
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNP3b8ACgkQshXHp8eE
G+1D7Af+JqVw89ekgZQHN3IB40lAwUH8+U5Nkz0DCpimXY7ju96dftZEvUCPT2c1
eXN3Cbo95K5ADpFJDIt9Up5kxitquPT97En916EfkCLbFMjOkmQ8aRUv47KnyLur
kifNn7EnqnGOAx/XhWBWOeBY+exSS0S1HpGwfO1DZ6V/HwRR1iZrF+cV/+RdmTyl
BwlbyLlz294cdzX9ecML3GzWJ1J6hqH8oAKNkLv3v9TlGIaHvU/gCzDSEG/1Q64/
uxn1xr8SRQjok0GPVEXUku70Y3cjYKbPNpR+w4zlGa6DokELxW+iH/3Rz+TVzl1O
y9H6wXzRPrD6dFckr8RDPucP8UD2dw==
=8jZb
-----END PGP SIGNATURE-----

--Apple-Mail=_A97D27F9-52DA-4212-8F2D-A650CCD30534--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 11:33:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 11:33:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425742.673784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7Je-0008Ml-6p; Wed, 19 Oct 2022 11:32:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425742.673784; Wed, 19 Oct 2022 11:32:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7Je-0008Me-40; Wed, 19 Oct 2022 11:32:54 +0000
Received: by outflank-mailman (input) for mailman id 425742;
 Wed, 19 Oct 2022 11:06:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Bifj=2U=virtuozzo.com=den@srs-se1.protection.inumbo.net>)
 id 1ol6to-0004w3-Tf
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 11:06:13 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140095.outbound.protection.outlook.com [40.107.14.95])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07a58c88-4f9e-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 13:06:07 +0200 (CEST)
Received: from PAXPR08MB6956.eurprd08.prod.outlook.com (2603:10a6:102:1db::9)
 by AS2PR08MB9473.eurprd08.prod.outlook.com (2603:10a6:20b:5ea::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 11:06:05 +0000
Received: from PAXPR08MB6956.eurprd08.prod.outlook.com
 ([fe80::c82b:333d:9400:dbc9]) by PAXPR08MB6956.eurprd08.prod.outlook.com
 ([fe80::c82b:333d:9400:dbc9%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 11:06:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07a58c88-4f9e-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oJhmopj2H7hFOJsYd2E+z4cIaukNLQ4DxPfDcQAR2UXZoEOUG73446xgNGFOxKIlJzQ3PZ+m/FvVtIWDrAJteGmXcp6eH2Q5lbKRcl+AWp839w5mY78LvLUwZFn68mI9l6AfA7uFnb1yx5oXqEHaIh1tJbEL4lMRy6NfHnEVmrDb2pdVyDI+JZuera0YyCjr3XceysDz7dl5fQ6FI7/1yA6EPoIzbSJgk8bEicd8adBb4ZNgLlZ6buyG/zzPMemor49JXko7+UlFYZK5PbA+sY+ZLewSLTWQJRNygobqord+2m8VJfTGpVpAIQgqW7IwgjzPVbDiQdI3rH15nJPcuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xhltnm+rSwr6w0Xbd8xf08MBurU4Rs3LaoB4CsMhb5M=;
 b=nRmS2xIpIIWWRBpQIvHAC/VNTeREoEdX5EOHR5G/zB76KMiBuXDlJSSsUF2HHgFA6j+gnl9JX1ks+cElwwyePFwW9hU6nYWJLUaGv6P/DpJxTsr1OI4UBeYQ7UyKsgMjbFLcgzHjen38JjwSCjhgYlc7fzuDpIRcDg62kO/PuJ7xYnIxD/3KwViFaTFsPGswv/NWDtuS7tqf+PFKGEc4hqBG36lej44XBmsZXYktZiER6XPR4bZhG9k7ccshOS1xI02BOQEsB+wcvMP7YljXteyq42ZXBzOyV73/SdhENNjPEwJGqNr19DHuhFoFn+hD4IBJZzlgZSJPE1iNQ0HElw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=virtuozzo.com; dmarc=pass action=none
 header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Xhltnm+rSwr6w0Xbd8xf08MBurU4Rs3LaoB4CsMhb5M=;
 b=qw1mMQurUqW4KCJL803lSNYsN6kH9ln8D439d/qZTWUjX9MzE0EjSXzpw46m/ZeiQMCqYrg9s+ieJJAB/62m/7nRqnxw2uLdiAsa+hx5P+LZWOfLlU0KXEDG2kSGPnC05b7SqjI1/5rDLOdzIzmpoOxEhYsoUam1jkk3KZZvQSDsZ/rQdaFxhwlF2dHKpU51CEIoHQo7f+wQRMyPIse1ehcyxIXXlpZ43y1kh1qtxn6t500ocP6+vtuLM7Qx4Z8qUKRJlMHCrh7Y0o8++rf5G5Z8tYcSq9S9nx5CeUC9zYamIfA0MSu3VQC8xKwBI3u00fzvVxsbDhvve7ZN0SAtZg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=virtuozzo.com;
Message-ID: <1c69ff97-831d-ece3-7a52-bb7659fc8dd4@virtuozzo.com>
Date: Wed, 19 Oct 2022 13:06:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to
 the rest of the kernel
Content-Language: en-US
To: Konstantin Khlebnikov <koct9i@gmail.com>,
 Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: kernel@openvz.org, kernel test robot <lkp@intel.com>,
 "Michael S . Tsirkin" <mst@redhat.com>, David Hildenbrand
 <david@redhat.com>, Wei Liu <wei.liu@kernel.org>,
 Nadav Amit <namit@vmware.com>, pv-drivers@vmware.com,
 Jason Wang <jasowang@redhat.com>, virtualization@lists.linux-foundation.org,
 "K. Y. Srinivasan" <kys@microsoft.com>,
 Haiyang Zhang <haiyangz@microsoft.com>,
 Stephen Hemminger <sthemmin@microsoft.com>, Dexuan Cui
 <decui@microsoft.com>, linux-hyperv@vger.kernel.org,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
 <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com>
From: "Denis V. Lunev" <den@virtuozzo.com>
In-Reply-To: <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: VI1PR09CA0112.eurprd09.prod.outlook.com
 (2603:10a6:803:78::35) To PAXPR08MB6956.eurprd08.prod.outlook.com
 (2603:10a6:102:1db::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: PAXPR08MB6956:EE_|AS2PR08MB9473:EE_
X-MS-Office365-Filtering-Correlation-Id: eb3f68f1-5ba8-475c-7d93-08dab1c1ea21
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QGf7Hq+IzikwzXW1di0MGYMno4UujJoHWEWKAy8hqrAGi+dLfqOTkwwSGSYwRbKNi2daon24CGDvg8qUwXVcwxCksIYGnu3G4dckVm75hpkbBuCU+BXSXzw8ZJSqL0VCjdiP7y6EsszNlLfghLB1aXsQlr3Rirj1/ju5y/tOUdn5Hao8ogBNUhEZOC92CUJU4Ljnlvi/PeBJRTeuG7R1AsTu9cAj4MLov4MvfuYIX0tGDkfCJL955TghoLXhyXnncC8upO9XmOqyWvo7x20F1nPFoxnks+5ZmcVxW6zBW2rVeAZDl9fwI2/wz4zT3s7+4U26YIIil0sPf9QEpzU8i3U1w24ddabKAS6L7BAD/MwpFtps1/lClYKN4sy2+VsrmuZ4sozExGfE2Pi0OdKBQI4arEOdeydknHSSDbj5uoNrDfS8V46jR1Qv1neTWd6ILriiNy/KFp5+jEze2R2F1LYGautSTW/mESqqbUZAQ2A0R6QKeStaXMP2JfInEaR/DvNaK0q0s4QN93bNqnj6GDfpl+ZW/rN9VtYXDq1EbDSX9qA9ONLS5L9iDj8fJQMJNJgTTYZhIfykhkM2H9+/n0pMy2qFx6g3q0ek0p12hNEXnkhk28/+qwAlhH+e3PJqqChbBdA0iH7XXAMZA0zBKh43GlVWwwWOsvbmQnGIIbBEKd3az0sMtoGdGTk8MSBtBrd73ji8s1sDnBUcBFWE731BwauCmeDVCYWpUZ3IqWrMTrq2itVB7DJoyg09jQ2XOUJNFr6Z0VbyiZUoLn6cqVUD6EKJbCnRoNT9UeLYbdY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6956.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(346002)(136003)(376002)(366004)(396003)(451199015)(2906002)(186003)(38100700002)(2616005)(6486002)(478600001)(45080400002)(54906003)(6636002)(86362001)(66476007)(66946007)(8676002)(66556008)(4326008)(110136005)(8936002)(31686004)(6512007)(6506007)(26005)(36756003)(53546011)(31696002)(83380400001)(41300700001)(7416002)(316002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bDJxd243Ymd2czA3Qy9pYnVhUlNRbWthL1hNaG5rb2oyZFRvNTNlK2xCUkZM?=
 =?utf-8?B?OU1UYTZ3a2w1cU5yM2tOOC9jdmw0SkpVa04remRZK1dWc3lGdWorcGloaWVv?=
 =?utf-8?B?SUdLeVZzQVNib2NYSmVkdkJYbExlY3RQcGdHR0V4S1pSVmZVcEZnVHNaRDR5?=
 =?utf-8?B?dGs1Mktpb3VlR1VGdllrQlVlZmoxZkNjL2oydU13UFRUU1VQZGhpTlF1Q2pC?=
 =?utf-8?B?d1ZhdVpaS2ppdFFRbnRjQTJLZFNTWkhtSU9zNkxzOUt1UXhOc25WWXU4eS9I?=
 =?utf-8?B?TnJrd1BaMWg0SjR2UlIvTVRVYTZ1djFUaU5TTlVIbTlTMXFOSXFyUmpMOFk0?=
 =?utf-8?B?YUFnZGUzd0szRnBVRTVjMmNVZUl0Z3NPRUdGaUNwOWx5RnF0aUg3OG9TVjVi?=
 =?utf-8?B?ZEwxRG4reWV4YThLb2o4SzNlN2VyaHJqQW5GTVRDd1VpS2FJZWlzUlBXWnNL?=
 =?utf-8?B?bUZYdHluZWpmV3dqZFVqZ0Vid2ExYkxNcnhXcE84Nk13UXRKVWJVL1E4eUc4?=
 =?utf-8?B?V3dKQWZERzZzY1RNTjd6L2VKeVk5NGsrRzIrSFRHS2hhSm9BVVJUTEpIMW43?=
 =?utf-8?B?QWxPcE1jVjREVkNnYXJ5Qkh0eFVod2J3TDJqaGQ4TUNOeHdPYVJoR0t1Y2JG?=
 =?utf-8?B?QVlqMDczRXNyekRyUmhsQUlYbkxIOXkxTnQ3YkJBYUoyTk5xWC9BZlNJU1Iw?=
 =?utf-8?B?eENUM2RKbzZzK3RBU2xCYWV5N0E3K3hVd1RFSzdoNE4xNDJWKzducGlNbUFa?=
 =?utf-8?B?TFU5bktnS3owQ2dBUXAwMHRmVGVaRVptL3g5SVBwVGI3U1BORHpYT0lNZS9D?=
 =?utf-8?B?c3hrK1N3YlpwcHk5ZzJYUVNaZkZBcHJxVXRuNFJIaWFWR05lNS9PQ0FjMENP?=
 =?utf-8?B?VjZkNjR2TW1zZzFGRytZMjRLT2RLZW05UTZrS08yUWszZXNVWE1USHFlUXo1?=
 =?utf-8?B?a0hQb2dFbmhPTkZaZFdqUG1XczVsdFZsSHZ0RllJVS9MK1FjSENaa0JOSkJl?=
 =?utf-8?B?QVJWNkE1WmZkUlhqWmxxby9iYmFRelB0R29SUXlySDNhc2ZkUnRFOXhnMysr?=
 =?utf-8?B?STVwT2NyUWMweXNJdFpGS2xJRFUrcnhmaU9HbURMaG1wOWZUWkp4T2piWE1Z?=
 =?utf-8?B?K1ZPZFp6YTVnTEY4V3dscmlQenFnZGpra0hUdkFDTnVXb3pYeldnOU5xWjN5?=
 =?utf-8?B?MkVBVXZtdWx3ZzJNeGFFcmtmNkdpMVUwZXFVaGpzbFBDZUhuZnN3N3VoSndT?=
 =?utf-8?B?dS90VW4vUXUrTzBWZUtiOTcwZ3hoNWtRYXJwazdNR1hGV2ZzaEs4SWNFa3RS?=
 =?utf-8?B?cGFyVjlwQXZxbndFaE1IU2t1ZHBES1UzYklHTFl6bm40U3FIQmlNRU91V1hM?=
 =?utf-8?B?ZEsyTFRNR00zQzVNSFdmRTRCU2RsQW5yUkNLU0U2NXI4T29IWWg0S2VSdFdS?=
 =?utf-8?B?a1c2Q3pUeFhTT1BsWEZNVmpMM1I3Q3llV0xKVUo3WFVuRE9XT2VOMkFyZTNh?=
 =?utf-8?B?UEMvL0xnUXArSWpteUpPYi9DVnZpL1RhRG40Y0tRdHE2Mi9sbmNBNEx2YmVY?=
 =?utf-8?B?Y0Jhbml3TW80dWdnMnF4VjlsNUVrVVVJUEF6ZmpaTzJITUFuWUpxSFFMSTN6?=
 =?utf-8?B?dzgxTmxHWHhYVTVWM1V0S3VhdEdINENqUVVRTm9reDlSaEZkbWJsTTJaQVFk?=
 =?utf-8?B?Nnc3MHpOckVacWJCUXRXeVFpYTV3OS91djVDMU1iZHZMb1FadHlwdFBvNFkv?=
 =?utf-8?B?WklwMFFaM25tanVVZUdtb1l5dmw1aFRoTEpFVkVhMmRSWEdGcGsxWHNVSkMw?=
 =?utf-8?B?bko1ams0ZUhoL0NBendJMzdvd0d3Z2lwWGlRQ0VsdHZGTnNWeGVxUmtxVEtL?=
 =?utf-8?B?RFZ2SllnM3F3UnJrVWVRTjlyc2xOMUZVM2M5TFdpVDZna2xBczFMcjlZUE1Q?=
 =?utf-8?B?RlFIcUdhYzcxMkYrd2FkZGNVT2dxbDMva1lJbXNQeWtJT0xSVHZzelQ0Qk8z?=
 =?utf-8?B?TWtZcUVzaSt5SVR4eHMzSVJWeW5wNFY5dkZLTnhNU0syWmZxL2V3YlRSVElE?=
 =?utf-8?B?T3B5MjFCYXVMYVl4SWNBNlJORGNOTDlMKzRhZ3BzZWozVjJ5NHY0QXgzL1lD?=
 =?utf-8?Q?+VLJ13tbOqXPNqLUgFkIqL9q0?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb3f68f1-5ba8-475c-7d93-08dab1c1ea21
X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6956.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 11:06:04.2621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NNpPyzKz/pYmBgwzYw4U3PGQIpQE6wKhel0T6Wy+mzKGqdVOLvkFM0rFkradIuyPKNd782iMdkj1xYn11KZEvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9473

On 10/19/22 12:53, Konstantin Khlebnikov wrote:
> On Wed, 19 Oct 2022 at 12:57, Alexander Atanasov 
> <alexander.atanasov@virtuozzo.com> wrote:
>
>     Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
>     inflate and deflate the guest memory size but there is no
>     way to know how much the memory size is changed by them.
>
>     Make it possible for the drivers to report the values to mm core.
>
>     Display reported InflatedTotal and InflatedFree in /proc/meminfo
>     and print these values on OOM and sysrq from show_mem().
>
>     The two values are the result of the two modes the drivers work
>     with using adjust_managed_page_count or without.
>
>     In earlier versions, there was a notifier for these changes
>     but after discussion - it is better to implement it in separate
>     patch series. Since it came out as larger work than initially
>     expected.
>
>     Amount of inflated memory can be used:
>      - totalram_pages() users working with drivers not using
>         adjust_managed_page_count
>      - si_meminfo(..) users can improve calculations
>      - by userspace software that monitors memory pressure
>
>
> Sorry, I see no reason for that series.
> Balloon inflation adjusts totalram_pages. That's enough.
>
no, they are not at least under some circumstances, f.e.
virtio balloon does not do that with VIRTIO_BALLOON_F_DEFLATE_ON_OOM
set

> There is no reason to know the amount of non-existent ballooned memory 
> inside.
> Management software which works outside should care about that.
>
The problem comes at the moment when we are running
our Linux server inside virtual machine and the customer
comes with crazy questions "where our memory?".

> For debugging you could get current balloon size from /proc/vmstat 
> (balloon_inflate - balloon_deflate).
> Also (I guess) /proc/kpageflags has a bit for that.
>
> Anyway it's easy to monitor balloon inflation by seeing changes of 
> total memory size.
for monitoring - may be. But in order to report total amount
there is no interface so far.

>
>     Alexander Atanasov (8):
>       mm: Make a place for a common balloon code
>       mm: Enable balloon drivers to report inflated memory
>       mm: Display inflated memory to users
>       mm: Display inflated memory in logs
>       drivers: virtio: balloon - report inflated memory
>       drivers: vmware: balloon - report inflated memory
>       drivers: hyperv: balloon - report inflated memory
>       documentation: create a document about how balloon drivers operate
>
>      Documentation/filesystems/proc.rst            |   6 +
>      Documentation/mm/balloon.rst                  | 138
>     ++++++++++++++++++
>      MAINTAINERS                                   |   4 +-
>      arch/powerpc/platforms/pseries/cmm.c          |   2 +-
>      drivers/hv/hv_balloon.c                       |  12 ++
>      drivers/misc/vmw_balloon.c                    |   3 +-
>      drivers/virtio/virtio_balloon.c               |   7 +-
>      fs/proc/meminfo.c                             |  10 ++
>      .../linux/{balloon_compaction.h => balloon.h} |  18 ++-
>      lib/show_mem.c                                |   8 +
>      mm/Makefile                                   |   2 +-
>      mm/{balloon_compaction.c => balloon.c}        |  19 ++-
>      mm/migrate.c                                  |   1 -
>      mm/vmscan.c                                   |   1 -
>      14 files changed, 213 insertions(+), 18 deletions(-)
>      create mode 100644 Documentation/mm/balloon.rst
>      rename include/linux/{balloon_compaction.h => balloon.h} (91%)
>      rename mm/{balloon_compaction.c => balloon.c} (94%)
>
>     v4->v5:
>      - removed notifier
>      - added documentation
>      - vmware update after op is done , outside of the mutex
>     v3->v4:
>      - add support in hyperV and vmware balloon drivers
>      - display balloon memory in show_mem so it is logged on OOM and
>     on sysrq
>     v2->v3:
>      - added missed EXPORT_SYMBOLS
>     Reported-by: kernel test robot <lkp@intel.com>
>      - instead of balloon_common.h just use balloon.h (yes, naming is
>     hard)
>      - cleaned up balloon.h - remove from files that do not use it and
>        remove externs from function declarations
>     v1->v2:
>      - reworked from simple /proc/meminfo addition
>
>     Cc: Michael S. Tsirkin <mst@redhat.com>
>     Cc: David Hildenbrand <david@redhat.com>
>     Cc: Wei Liu <wei.liu@kernel.org>
>     Cc: Nadav Amit <namit@vmware.com>
>     Cc: pv-drivers@vmware.com
>     Cc: Jason Wang <jasowang@redhat.com>
>     Cc: virtualization@lists.linux-foundation.org
>     Cc: "K. Y. Srinivasan" <kys@microsoft.com>
>     Cc: Haiyang Zhang <haiyangz@microsoft.com>
>     Cc: Stephen Hemminger <sthemmin@microsoft.com>
>     Cc: Dexuan Cui <decui@microsoft.com>
>     Cc: linux-hyperv@vger.kernel.org
>     Cc: Juergen Gross <jgross@suse.com>
>     Cc: Stefano Stabellini <sstabellini@kernel.org>
>     Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>     Cc: xen-devel@lists.xenproject.org
>
>     base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
>     -- 
>     2.31.1
>



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 11:35:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 11:35:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425758.673795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7MG-0000YO-Ln; Wed, 19 Oct 2022 11:35:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425758.673795; Wed, 19 Oct 2022 11:35:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7MG-0000YH-Hy; Wed, 19 Oct 2022 11:35:36 +0000
Received: by outflank-mailman (input) for mailman id 425758;
 Wed, 19 Oct 2022 11:35:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7ME-0000Y2-P1; Wed, 19 Oct 2022 11:35:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7ME-0002Dl-ME; Wed, 19 Oct 2022 11:35:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7ME-0001t6-D8; Wed, 19 Oct 2022 11:35:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7ME-00067l-Ce; Wed, 19 Oct 2022 11:35:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lmLQPkhiAuS/NEEOEcQt1CLk5rswZfn90jt6slnbtXM=; b=uB8POrhjjZbPluUF3L2uB/dwhY
	tg1g7kPQQXMQoV4IJHGKS/VlhxZX5ZgX3rnQY4SJNp05eunL57PM41qtfx7Hh/D8VxcSxYaHmh0S0
	AyZjTfwbXSsDpLNT2aPPgDE20YwoXDjLZaR6Eglj1Dvd04ghbYL3q1f7jmPWZ+KlRtNk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174084-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174084: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 11:35:34 +0000

flight 174084 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174084/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 174051

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174051 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174051 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   11 days
Failing since        173492  2022-10-11 13:01:50 Z    7 days   51 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 11:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 11:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425767.673808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7VF-00022v-GS; Wed, 19 Oct 2022 11:44:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425767.673808; Wed, 19 Oct 2022 11:44:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7VF-00022o-Dv; Wed, 19 Oct 2022 11:44:53 +0000
Received: by outflank-mailman (input) for mailman id 425767;
 Wed, 19 Oct 2022 11:44:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Se4D=2U=virtuozzo.com=alexander.atanasov@srs-se1.protection.inumbo.net>)
 id 1ol7VE-00022i-1m
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 11:44:52 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140129.outbound.protection.outlook.com [40.107.14.129])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f8e7b63-4fa3-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 13:44:49 +0200 (CEST)
Received: from VE1PR08MB4765.eurprd08.prod.outlook.com (2603:10a6:802:a5::16)
 by AS8PR08MB5943.eurprd08.prod.outlook.com (2603:10a6:20b:23e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 11:44:48 +0000
Received: from VE1PR08MB4765.eurprd08.prod.outlook.com
 ([fe80::6809:fef7:a205:b08a]) by VE1PR08MB4765.eurprd08.prod.outlook.com
 ([fe80::6809:fef7:a205:b08a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 11:44:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f8e7b63-4fa3-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gwG5SIKcNgX7/zR8X5Wj5zq7ZPJFZut2NcgkYCAeJINDTMa3+gd1nsM5FFtutWVaFN60Xurcc+3JrIz77/xb0SQQ6q/3KhSsVaWJT89kuRT8fyp4T2RSI9YCOcoey30MlVdV2QgISI9LdX6kz+QhaPL+mYkLR3Czws+hzTDTimGr3MynYNP256rqbTWr8gmKVjjIXYabfc17K1bi0TdMzK1LEuHQgVF5VFq3H8m6eOn18BH5f99LAwYYI6tnKsFVZAHYeA4vDuoBloXCxqOmwbWnFcKlHA7P60H3BU2Nr1KeeAT54PD93dpQqRGTv5wuAm1msOCzZrHNNTTPPs6rrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sPflqNVTjcIJi0I6gleyxBPiVTz6DIBxSfsAWHMsG/E=;
 b=D5+DW4LP5A2aZfCk+0XBPatUqq2BHMY9Nnl9rWp+r15cmv6U/vaeu2XHuk0MER0pOqf8fns6MO/oatiUj3mlhpzFgkJWPfdA8K66096NrWre9C2o6NLautovYm2CvWApCIYWTb7QwVdOripnrjWArmPc+uSrRsJncXo3l31DnOVpr5x74VfcfCDJo4rQ2C+5QJZyhALDZ78tNWixov/xgQsSpeG+yHYg53rgM4f+3HJRA7I5bANn2KBkc9IICC3tCngEvYXSr28utVCvG9mGr6QaJI61b+OsREMf1SWwikAjG3BnQ0KzvU9JoTegbrXU2YSpml2AQnEj1r5DTnCfYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=virtuozzo.com; dmarc=pass action=none
 header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sPflqNVTjcIJi0I6gleyxBPiVTz6DIBxSfsAWHMsG/E=;
 b=NNWz33lBNmMHsqtf7OGHCbe6h2h+bLbCWKDEYHxXzeEvnkOtp9bAkynlHvSgz4wz97E5qCvO+KSgij63Uyft/37SU1BlLngR8Bq1O8CfmjisXMCzuiyP8er6NFT3O+5Wr1peaNduY+uL2qDBSndE6KWqvBNNCKvbUrn/nhBbkFnzjqrPXwkzgNRWTVYr1WqSvWMxvCrFQ5tZOjSxdehYijz6Ituv+tInRNEZeEZLoR8Yu1ZFl7fuTvAMgrrbtonuis2kwuafPxe8gboEio6tIqq6WOeKPuKEWiVvr8WGmA7XhMWtUOZqEL9WwqNRLflRvW14N+DcAQkUav7qbv27CQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=virtuozzo.com;
Message-ID: <2c87f6a7-47ae-4d9d-292a-0ed5702e82d1@virtuozzo.com>
Date: Wed, 19 Oct 2022 14:44:45 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to
 the rest of the kernel
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: kernel@openvz.org, kernel test robot <lkp@intel.com>,
 "Michael S . Tsirkin" <mst@redhat.com>, David Hildenbrand
 <david@redhat.com>, Wei Liu <wei.liu@kernel.org>,
 Nadav Amit <namit@vmware.com>, pv-drivers@vmware.com,
 Jason Wang <jasowang@redhat.com>, virtualization@lists.linux-foundation.org,
 "K. Y. Srinivasan" <kys@microsoft.com>,
 Haiyang Zhang <haiyangz@microsoft.com>,
 Stephen Hemminger <sthemmin@microsoft.com>, Dexuan Cui
 <decui@microsoft.com>, linux-hyperv@vger.kernel.org,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
 <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com>
From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: VI1PR0601CA0032.eurprd06.prod.outlook.com
 (2603:10a6:800:1e::42) To VE1PR08MB4765.eurprd08.prod.outlook.com
 (2603:10a6:802:a5::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR08MB4765:EE_|AS8PR08MB5943:EE_
X-MS-Office365-Filtering-Correlation-Id: 2f5251ca-a004-4e19-b493-08dab1c75320
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	agZ2/hSAMs9VNhd8mAKDSs0krEg+PGD72pAbdnKhiIQWIgUrtSIipuP+4K7NT0IVpBgy2OEuKt1Dkjj60wwKCFKGEqY1tbk7mebZyEOT/8ytKHinTk486Ihsm4JKJp4zswyBLP+mIXRUmxczFXc0wx4FaEhnh0q9BYLrOScEOWUGp2x/gXKb+VQCOheFBRA5zQCxNHOJsOI+/snIqhGrbeeyYyntO1/kHoNs0xCvs3b2sJOPkV3QWfybyJ9elwW/bup67GpNfjA2Bq2fLG8bZSS2zEVlaWiPH5UDJpy8oO3PheYqYAk4u4CSqZsqtw+VnxneS34eY8JbKe+oxRszI4zX6/HyaPsm47abZh6zC6fOnqgs1F8B2abd3yKjxttur5ehNBrYV/RPJZhmhbHKC7QGi0F9E4qD6BSRsIVLC3BJxCjY3PDE45KDmwH66WHtn+xoYqJrNDC8ii2HpHKoY2KCkhx4y3PxYPRh+Jg31IOw3MGBOrik0YhWvu56XXwDPL03PzLIOtj0P07Cbmtp1wyf0WWo8AUnEh6ONzezx/wiJGOwNJaCb00KO0L0U3sJjqFBGMjD6jcr9zDv1EhXwTPw9iFbM8BD95M8FDqNVgbaMqT6lFhlw4YE8xLjdIlW0n947In7NaHLKaMeKml4Bi89S1Fc4RooMRXrUBS8IEOVpWzkfY6VFR2lPRWLKY6NyAxt+3eYD/TEWaNiHumD5fqr8UIEDdZ837GZGBESL/IRDGGwSTVkZVyaqEEFVAhP5JRFEOPraH8viMHO1IZ5AYJublovESQ4h9Bwfr3oVWw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB4765.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39850400004)(366004)(451199015)(45080400002)(38100700002)(86362001)(31696002)(6512007)(5660300002)(8936002)(41300700001)(53546011)(6506007)(66476007)(66946007)(66556008)(26005)(4326008)(8676002)(44832011)(7416002)(2906002)(186003)(54906003)(6916009)(2616005)(316002)(36756003)(31686004)(6486002)(478600001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V1puRmRPQlFKa0x5VStpeGpBZVlIenNpTWFISUhxM2hoUHNMS09LSnh2Q0Yw?=
 =?utf-8?B?YzlPeXNmYnBvUnd5d1NxNVZWNEF1M3c2TktWOS84RlkvZUlPR0RWLzYwbFc5?=
 =?utf-8?B?czhuYXlzL0hiN2lUcHhSdXU1TitxUGF0V1VmSER5VUU4Yk1pWEU1aHNvUWlz?=
 =?utf-8?B?d3IzTFNPbElaenkvMUc0Y0FlWEdzSGdBbzgwTWMwZVVEU2E4TTQyWEh0TlFN?=
 =?utf-8?B?ci96SEFhS2hzMWlVTzRBMHZhTVE2NW1lZlQybkxvdkM5ZVRwbUZDNDl0U2J3?=
 =?utf-8?B?MlB2ZWttY0RCa0pSbW9saHBlY2ZCT1AvVnhjZDVUYkdkUzZQRGZjaEpFd2tC?=
 =?utf-8?B?RW13ckovMnIwSW5PbWtiZ0hTUjJJbVlFeDFHa0RNOVZYenI4Ri9QL1NqK3Vh?=
 =?utf-8?B?WVVjUCtkRC9Xc21IdjhkQitycW44Z1Q0TTRDRHlndC8vNFVsdHFhdHhzU3hC?=
 =?utf-8?B?N0dKTlROWmxyajViV3BsRVMweXdDUGo4NVBydE45NjFIaVhTWkRlb3hTcWcy?=
 =?utf-8?B?cTduTE0yeWoxZ3dBMSt3dkluRlEwSVNucEZackpuM0JjL2NKMmRXRlkzYW8r?=
 =?utf-8?B?SkJnYWdFY3VvbFB4VkQvcVpWMUZFYUxVUWZVMDhqeE96SktUVGZGejRqNHpu?=
 =?utf-8?B?aEVEWXJvMHFtdFpCaXNFTzBHWWd3cm1ab3ZleFBXT2p4RlR4TitoVENpZ0hL?=
 =?utf-8?B?b016NDBNUG9OdlpzcjVid1dPSTlJMGFucFlLNUlmYkRiR01UMzN2ak03ZHVv?=
 =?utf-8?B?RHlsbmVzcnF6TWd1aEpuWWZ2a0VDM1Z2VHdIZjZLTEd0WkRoNXpRZWF2Nzc2?=
 =?utf-8?B?QnQ1TUo3UEJvVXFveEFXUWV3amw2RkZ5WVVIK2lxYUwzVEZMTi8vYTc3Y21w?=
 =?utf-8?B?NHdadmxVd2lBd29KNEE0cklxNlB1TjBMUTlUdk85ZHk5WGRkbnJnL1J2Mmxk?=
 =?utf-8?B?cG9hbGFBUXRZYXhPNG9pMWdISHB1Mkpod0tZUmE3YnVQWXYrL2d2MzBwRW5X?=
 =?utf-8?B?MVBJMlI2NHZ1S0xoZmtCSkkzWklvYmM3Y0xHbnJGZkM1Rmw4dS9vYldXSkhr?=
 =?utf-8?B?TzlXY0poQUVCcFI1bC91aDhzY3VEYzJEalZ6TzQwa0doOC9LTlFkdUdnS2xa?=
 =?utf-8?B?NnJiNERGSjJMRUJRSnZJQWVURnV5ZGRQblE4TlZSUzFNOUJFbUNlSHhoczRa?=
 =?utf-8?B?dmI1Yk0rQUcyM0JEZllMZ294VjRDMjcrR29qMXVwVlNBR1RFbmc3aVh0eFVM?=
 =?utf-8?B?aWJ4WmFSdlVhWGRMUTVUSzlkQzIvREtnOENxQmQ3NDNrU3V5TGhWWkh5Mnh6?=
 =?utf-8?B?SGVON2ROYzlkbGJMMnk4WjloazlnK0lwNXVSWVdhcVhVWE9QYzMwVkZGckxP?=
 =?utf-8?B?ZVpueGNZT0QxeHlzOHZkSjRjNDAycWJrL0Y2Mml2eldvWjJxY0Zzbk50VTB5?=
 =?utf-8?B?OWFjWDlwNGE0MjJKcGVTNFRrUzE3ZXlENWhnS3lPYmNMRjByWERnUGNJRDFW?=
 =?utf-8?B?VFBXZ2NLbGNoSTQ0V3o5N2tBYnNYc0dzM2VDWUV4c2N4VWx1czNqblJqU092?=
 =?utf-8?B?YmdKUWVLUkpHajJBQ0lUU1N1ZGhEWVdSWG1uaENrTytLWStsZEMwWDllZnl2?=
 =?utf-8?B?N2RBc3dKUXQ2NDVZa2o1RCs5bm5rSG1EcmViTzdrMEpqTlVXNWNBTzVSd2s4?=
 =?utf-8?B?Tnk1Y01sVlhvV3FhQ1R6eFJPdUpHdWNITU5KOEdzWW41d0N4MW8xbDVQTFo0?=
 =?utf-8?B?ajBLSEdvbVQwbyt4ZHVITmQzVzhZSFVHbmwwTkRrVDFpVE9XaUtkSmhqajVr?=
 =?utf-8?B?U2duNSsxV3pKdnJWU3lyZkN5ZFN3c0M1eXVlcVk3N3VGa05ZSEIzOWVwY2N4?=
 =?utf-8?B?aGNYOEhDaE5ScmIrOWZwZTJIU3RLa2Z3SEU3TWR6dlZDRFlxVm5LeUtaaE82?=
 =?utf-8?B?S2F1bVZrcTV1TG9TVDY0cDBacHBFZ0M2N09DL1ZTWTM5RHRRS1JwbTg0V3d6?=
 =?utf-8?B?Y1FzMURSeHFicyt5NGlhMFZKZU56NFFvQkVEdE1SR1lGTHlZbUVuMkpSOFAx?=
 =?utf-8?B?aUtDY2Q1TnNuOG9OUktIdU81NUNyaGh2TDFYbkMxREhuNk5zdDdVZ0RMQmpL?=
 =?utf-8?B?bUwyWTZybS9rbmphOGlTNDVLN2J1TFMvTlhZSTZNdm9pNzg0alF1bXoxR1RP?=
 =?utf-8?B?bmc9PQ==?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f5251ca-a004-4e19-b493-08dab1c75320
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4765.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 11:44:47.8700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o0cdBuHWekT9SSi3UPT9gNw/93FkKojGb/rDdUqW6eFcLMeq/W5W9CbfNs72Xezpuowyj2JOrTMTwBSJvQSzETgsuj7mbxlCl6F+i28MIIl2RDIrtduUsc9HmlnJkdlE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5943

On 19.10.22 13:53, Konstantin Khlebnikov wrote:
> On Wed, 19 Oct 2022 at 12:57, Alexander Atanasov 
> <alexander.atanasov@virtuozzo.com 
> <mailto:alexander.atanasov@virtuozzo.com>> wrote:
> 
>     Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
>     inflate and deflate the guest memory size but there is no
>     way to know how much the memory size is changed by them.
> 
>     Make it possible for the drivers to report the values to mm core.
> 
>     Display reported InflatedTotal and InflatedFree in /proc/meminfo
>     and print these values on OOM and sysrq from show_mem().
> 
>     The two values are the result of the two modes the drivers work
>     with using adjust_managed_page_count or without.
> 
>     In earlier versions, there was a notifier for these changes
>     but after discussion - it is better to implement it in separate
>     patch series. Since it came out as larger work than initially expected.
> 
>     Amount of inflated memory can be used:
>       - totalram_pages() users working with drivers not using
>          adjust_managed_page_count
>       - si_meminfo(..) users can improve calculations
>       - by userspace software that monitors memory pressure
> 
> 
> Sorry, I see no reason for that series.
> Balloon inflation adjusts totalram_pages. That's enough.

That is not true in all cases - some do some do not.

> 
> There is no reason to know the amount of non-existent ballooned memory 
> inside.

Why? Memory managment is becoming more and more dynamic - to make it 
easy and accurate you need to know that amount. The kernel itself
on boot pre-allocates caches and sets limits based on total ram at boot 
time when balloon steals half of the memory these initial calculations 
become very wrong. To redo them correctly these amounts need to be 
known. The idea of doing this is thru a notifier chain in a separte series.

> Management software which works outside should care about that.
> 
> For debugging you could get current balloon size from /proc/vmstat 
> (balloon_inflate - balloon_deflate).

Currently you can do that only if using VMWare balloon.

> Also (I guess) /proc/kpageflags has a bit for that.
> 
> Anyway it's easy to monitor balloon inflation by seeing changes of total 
> memory size.

Not all drivers do that - VMWare and virtio (in one case) for example do 
not. I proposed to unify them but since it can break existing users it 
was NAKed.

> 
>     Alexander Atanasov (8):
>        mm: Make a place for a common balloon code
>        mm: Enable balloon drivers to report inflated memory
>        mm: Display inflated memory to users
>        mm: Display inflated memory in logs
>        drivers: virtio: balloon - report inflated memory
>        drivers: vmware: balloon - report inflated memory
>        drivers: hyperv: balloon - report inflated memory
>        documentation: create a document about how balloon drivers operate
> 
>       Documentation/filesystems/proc.rst            |   6 +
>       Documentation/mm/balloon.rst                  | 138 ++++++++++++++++++
>       MAINTAINERS                                   |   4 +-
>       arch/powerpc/platforms/pseries/cmm.c          |   2 +-
>       drivers/hv/hv_balloon.c                       |  12 ++
>       drivers/misc/vmw_balloon.c                    |   3 +-
>       drivers/virtio/virtio_balloon.c               |   7 +-
>       fs/proc/meminfo.c                             |  10 ++
>       .../linux/{balloon_compaction.h => balloon.h} |  18 ++-
>       lib/show_mem.c                                |   8 +
>       mm/Makefile                                   |   2 +-
>       mm/{balloon_compaction.c => balloon.c}        |  19 ++-
>       mm/migrate.c                                  |   1 -
>       mm/vmscan.c                                   |   1 -
>       14 files changed, 213 insertions(+), 18 deletions(-)
>       create mode 100644 Documentation/mm/balloon.rst
>       rename include/linux/{balloon_compaction.h => balloon.h} (91%)
>       rename mm/{balloon_compaction.c => balloon.c} (94%)
> 
>     v4->v5:
>       - removed notifier
>       - added documentation
>       - vmware update after op is done , outside of the mutex
>     v3->v4:
>       - add support in hyperV and vmware balloon drivers
>       - display balloon memory in show_mem so it is logged on OOM and on
>     sysrq
>     v2->v3:
>       - added missed EXPORT_SYMBOLS
>     Reported-by: kernel test robot <lkp@intel.com <mailto:lkp@intel.com>>
>       - instead of balloon_common.h just use balloon.h (yes, naming is hard)
>       - cleaned up balloon.h - remove from files that do not use it and
>         remove externs from function declarations
>     v1->v2:
>       - reworked from simple /proc/meminfo addition
> 
>     Cc: Michael S. Tsirkin <mst@redhat.com <mailto:mst@redhat.com>>
>     Cc: David Hildenbrand <david@redhat.com <mailto:david@redhat.com>>
>     Cc: Wei Liu <wei.liu@kernel.org <mailto:wei.liu@kernel.org>>
>     Cc: Nadav Amit <namit@vmware.com <mailto:namit@vmware.com>>
>     Cc: pv-drivers@vmware.com <mailto:pv-drivers@vmware.com>
>     Cc: Jason Wang <jasowang@redhat.com <mailto:jasowang@redhat.com>>
>     Cc: virtualization@lists.linux-foundation.org
>     <mailto:virtualization@lists.linux-foundation.org>
>     Cc: "K. Y. Srinivasan" <kys@microsoft.com <mailto:kys@microsoft.com>>
>     Cc: Haiyang Zhang <haiyangz@microsoft.com
>     <mailto:haiyangz@microsoft.com>>
>     Cc: Stephen Hemminger <sthemmin@microsoft.com
>     <mailto:sthemmin@microsoft.com>>
>     Cc: Dexuan Cui <decui@microsoft.com <mailto:decui@microsoft.com>>
>     Cc: linux-hyperv@vger.kernel.org <mailto:linux-hyperv@vger.kernel.org>
>     Cc: Juergen Gross <jgross@suse.com <mailto:jgross@suse.com>>
>     Cc: Stefano Stabellini <sstabellini@kernel.org
>     <mailto:sstabellini@kernel.org>>
>     Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com
>     <mailto:oleksandr_tyshchenko@epam.com>>
>     Cc: xen-devel@lists.xenproject.org
>     <mailto:xen-devel@lists.xenproject.org>
> 
>     base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
>     -- 
>     2.31.1
> 

-- 
Regards,
Alexander Atanasov



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 11:55:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 11:55:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425775.673822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7fN-0003fJ-L8; Wed, 19 Oct 2022 11:55:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425775.673822; Wed, 19 Oct 2022 11:55:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol7fN-0003fC-IN; Wed, 19 Oct 2022 11:55:21 +0000
Received: by outflank-mailman (input) for mailman id 425775;
 Wed, 19 Oct 2022 11:55:20 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7fM-0003f2-TS; Wed, 19 Oct 2022 11:55:20 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7fM-0002b2-Qf; Wed, 19 Oct 2022 11:55:20 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7fM-0002UZ-Gi; Wed, 19 Oct 2022 11:55:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol7fM-00020W-GF; Wed, 19 Oct 2022 11:55:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QqRapo815BkPu7Ambx+98i2sdlinKB0p9MWohgX97d4=; b=ZowwF+qqTVZQnP0dlS3Qw2nWHB
	iZXmrOcXWdl3UfgkmJb7CqgKHqS0Jcy3H/H/2VFGSeWQ5UUbYIK9nW6mpzktJMLqtiOmSrtYkif1m
	lgY4tn0AT9L+WP/Xr8MqxC4wCY+aZc35lmYwilxVwmnJUeVpufLPw+sfV0cCwYvIuvTM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174081-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174081: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=0f6eccdbf75885631221388d362417eb7b873ce0
X-Osstest-Versions-That:
    ovmf=c4663e7277d12835a886994919822e218a01b62e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 11:55:20 +0000

flight 174081 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174081/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 0f6eccdbf75885631221388d362417eb7b873ce0
baseline version:
 ovmf                 c4663e7277d12835a886994919822e218a01b62e

Last test of basis   174075  2022-10-19 04:40:29 Z    0 days
Testing same since   174081  2022-10-19 08:11:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chen, Christine <Yuwei.Chen@intel.com>
  Konstantin Aladyshev <aladyshev22@gmail.com>
  Pierre Gondois <pierre.gondois@arm.com>
  Yuwei Chen <yuwei.chen@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c4663e7277..0f6eccdbf7  0f6eccdbf75885631221388d362417eb7b873ce0 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 12:30:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 12:30:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425791.673834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol8DC-00089l-Lf; Wed, 19 Oct 2022 12:30:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425791.673834; Wed, 19 Oct 2022 12:30:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol8DC-00089e-Ii; Wed, 19 Oct 2022 12:30:18 +0000
Received: by outflank-mailman (input) for mailman id 425791;
 Wed, 19 Oct 2022 12:30:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=HYsd=2U=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ol8DA-00089Y-Id
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 12:30:16 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7f908b5-4fa9-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 14:30:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E4D27204F3;
 Wed, 19 Oct 2022 12:30:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A083C13A36;
 Wed, 19 Oct 2022 12:30:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Jd+JJdXtT2NvawAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 19 Oct 2022 12:30:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7f908b5-4fa9-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666182613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Xaj4mH7txC7d288vTgUtDorUrbJZzcrLdpatQpIRUvg=;
	b=p+1AYwyG8Rcpo3fVrkSdW50kgppmvZKdIRZMI2xkyt5XN7E84rOZS0r4fuXYP+9vISSvtA
	aymDAH2JqjcKzJl8cu0BYh1yvb7g02uq70S6xp65mjgfGuWlrcaYlpu/j2i8BfMmLBvDv3
	MGeBgjBczF5cxFF7f9S1IzgirrWUmcQ=
Message-ID: <9a13e1aa-91a8-7b06-2807-769552639b0c@suse.com>
Date: Wed, 19 Oct 2022 14:30:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "jennifer.herbert@citrix.com" <jennifer.herbert@citrix.com>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "maarten.lankhorst@linux.intel.com" <maarten.lankhorst@linux.intel.com>,
 "mripard@kernel.org" <mripard@kernel.org>,
 "tzimmermann@suse.de" <tzimmermann@suse.de>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
References: <Y0/U0RNDSRdV7bex@EPUAKYIW015D>
From: Juergen Gross <jgross@suse.com>
Subject: Re: Issue on unmap_grant_pages before releasing dmabuf
In-Reply-To: <Y0/U0RNDSRdV7bex@EPUAKYIW015D>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------zsrO4Hs8YW0rK26Zjkfdj30z"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------zsrO4Hs8YW0rK26Zjkfdj30z
Content-Type: multipart/mixed; boundary="------------e4uMnI8o0ZlqDuWh7LC5S2Sb";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "jennifer.herbert@citrix.com" <jennifer.herbert@citrix.com>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "maarten.lankhorst@linux.intel.com" <maarten.lankhorst@linux.intel.com>,
 "mripard@kernel.org" <mripard@kernel.org>,
 "tzimmermann@suse.de" <tzimmermann@suse.de>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Message-ID: <9a13e1aa-91a8-7b06-2807-769552639b0c@suse.com>
Subject: Re: Issue on unmap_grant_pages before releasing dmabuf
References: <Y0/U0RNDSRdV7bex@EPUAKYIW015D>
In-Reply-To: <Y0/U0RNDSRdV7bex@EPUAKYIW015D>

--------------e4uMnI8o0ZlqDuWh7LC5S2Sb
Content-Type: multipart/mixed; boundary="------------501KvknMR9wxJKQC5EqDg8Pq"

--------------501KvknMR9wxJKQC5EqDg8Pq
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMTkuMTAuMjIgMTI6NDMsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0KPiBHcmVldGlu
Z3MuDQo+IA0KPiBJIG5lZWQgeW91ciBhZHZpc2UgYWJvdXQgdGhlIHByb2JsZW0gSSdtIGZh
Y2luZyByaWdodCBub3c6DQo+IEknbSB3b3JraW5nIG9uIHRoZSBuZXcgdHlwZSBvZiBkbWFi
dWYgZXhwb3J0IGltcGxlbWVudGF0aW9uLiBUaGlzDQo+IGlzIGdvaW5nIHRvIGJlIG5ldyBp
b2N0bCB0byB0aGUgZ250ZGV2IGFuZCBpdCdzIHB1cnBvc2UgaXMgdG8gdXNlDQo+IGV4dGVy
bmFsIGJ1ZmZlciwgcHJvdmlkZWQgYnkgZmlsZSBkZXNjcmlwdG9yIGFzIHRoZSBiYWNraW5n
IHN0b3JhZ2UNCj4gZHVyaW5nIGV4cG9ydCB0byBncmFudCByZWZzLg0KPiBGZXcgd29yZHMg
YWJvdXQgdGhlIGZ1bmN0aW9uYWxpdHkgSSdtIHdvcmtpbmcgb24gcmlnaHQgbm93Og0KPiBN
eSBzZXR1cCBpcyBiYXNlZCBvbiBJTVg4UU0gKHBsZWFzZSBzZWUgUFMgYmVsb3cgaWYgeW91
IG5lZWQNCj4gY29uZmlndXJhdGlvbiBkZXRhaWxzKQ0KPiANCj4gV2hlbiB1c2luZyBkbWEt
YnVmIGV4cG9ydGVyIHRvIGNyZWF0ZSBkbWEtYnVmIHdpdGggYmFja2luZyBzdG9yYWdlIGFu
ZA0KPiBtYXAgaXQgdG8gdGhlIGdyYW50IHJlZnMsIHByb3ZpZGVkIGZyb20gdGhlIGRvbWFp
biwgd2UndmUgbWV0IGEgcHJvYmxlbSwNCj4gdGhhdCBzZXZlcmFsIEhXIChpLk1YOCBncHUg
aW4gb3VyIGNhc2UpIGRvIG5vdCBzdXBwb3J0IGV4dGVybmFsIGJ1ZmZlcg0KPiBhbmQgcmVx
dWlyZXMgYmFja2luZyBzdG9yYWdlIHRvIGJlIGNyZWF0ZWQgdXNpbmcgaXQncyBuYXRpdmUg
dG9vbHMNCj4gKGVnbENyZWF0ZUltYWdlS0hSIHJldHVybnMgRUdMX05PX0lNQUdFX0tIUiBm
b3IgYnVmZmVycywgd2hpY2ggd2VyZSBub3QNCj4gY3JlYXRlZCB1c2luZyBnYm1fYm9fY3Jl
YXRlKS4NCj4gVGhhdCdzIHdoeSBuZXcgaW9jdGxzIHdlcmUgYWRkZWQgdG8gYmUgYWJsZSB0
byBwYXNzIGV4aXN0aW5nIGRtYS1idWZmZXINCj4gZmQgYXMgaW5wdXQgcGFyYW1ldGVyIGFu
ZCB1c2UgaXQgYXMgYmFja2luZyBzdG9yYWdlIHRvIGV4cG9ydCB0byByZWZzLg0KPiBLZXJu
ZWwgdmVyc2lvbiBvbiBJTVg4UU0gYm9hcmQgaXMgNS4xMC43MiBhbmQgaXR3b3JrcyBmaW5l
IG9uIHRoaXMga2VybmVsDQo+IHZlcnNpb24uDQo+IA0KPiBOZXcgaW9jdGxzIHNvdXJjZSBj
b2RlIGNhbiBiZSBmb3VuZCBoZXJlOg0KPiAgIGh0dHBzOi8vZ2l0aHViLmNvbS9vbGVrc2lp
bW9pc2llaWV2L2xpbnV4L3RyZWUvZ250ZGV2X21hcF9idWZfdXBzdHJfZm9yLWxpbnVzLTYu
MV8yDQo+ICAgICAgDQo+IE5vdyByZWdhcmRpbmcgdGhlIHByb2JsZW0gSSd2ZSBtZXQgd2hl
biByZWJhc2VkIHRob3NlIGNvZGUgb24gbWFzdGVyOg0KPiBPbiBteSB0ZXN0IHN0YW5kIEkg
dXNlIERSTV9JT0NUTF9NT0RFX0NSRUFURV9EVU1CL0RSTV9JT0NUTF9NT0RFX0RFU1RST1lf
RFVNQiBpb2N0bHMNCj4gdG8gYWxsb2NhdGUgYnVmZmVyIGFuZCBJJ20gb2JzZXJ2aW5nIHRo
ZSBmb2xsb3dpbmcgYmFja3RyYWNlIG9uIERSTV9JT0NUTF9NT0RFX0RFU1RST1lfRFVNQjoN
Cj4gDQo+IFVuYWJsZSB0byBoYW5kbGUga2VybmVsIHBhZ2luZyByZXF1ZXN0IGF0IHZpcnR1
YWwgYWRkcmVzcyAwMDAwMDAwMzg3MDAwMDk4DQo+IE1lbSBhYm9ydCBpbmZvOg0KPiAgICBF
U1IgPSAweDAwMDAwMDAwOTYwMDAwMDUNCj4gICAgRUMgPSAweDI1OiBEQUJUIChjdXJyZW50
IEVMKSwgSUwgPSAzMiBiaXRzDQo+ICAgIFNFVCA9IDAsIEZuViA9IDANCj4gICAgRUEgPSAw
LCBTMVBUVyA9IDANCj4gICAgRlNDID0gMHgwNTogbGV2ZWwgMSB0cmFuc2xhdGlvbiBmYXVs
dA0KPiBEYXRhIGFib3J0IGluZm86DQo+ICAgIElTViA9IDAsIElTUyA9IDB4MDAwMDAwMDUN
Cj4gICAgQ00gPSAwLCBXblIgPSAwDQo+IHVzZXIgcGd0YWJsZTogNGsgcGFnZXMsIDQ4LWJp
dCBWQXMsIHBnZHA9MDAwMDAwMDA2ZGY5ODAwMA0KPiBbMDAwMDAwMDM4NzAwMDA5OF0gcGdk
PTA4MDAwMDAwNjRmNGYwMDMsIHA0ZD0wODAwMDAwMDY0ZjRmMDAzLCBwdWQ9MDAwMDAwMDAw
MDAwMDAwMA0KPiBJbnRlcm5hbCBlcnJvcjogT29wczogOTYwMDAwMDUgWyMxXSBQUkVFTVBU
IFNNUA0KPiBNb2R1bGVzIGxpbmtlZCBpbjogeGVuX3BjaWJhY2sgb3ZlcmxheSBjcmN0MTBk
aWZfY2UgaXBfdGFibGVzIHhfdGFibGVzIGlwdjYNCj4gUFU6IDAgUElEOiAzNCBDb21tOiBr
d29ya2VyLzA6MSBOb3QgdGFpbnRlZCA2LjAuMCAjODUNCj4gSGFyZHdhcmUgbmFtZTogbGlu
dXgsZHVtbXktdmlydCAoRFQpDQo+IFdvcmtxdWV1ZTogZXZlbnRzIHZpcnRpb19ncHVfZGVx
dWV1ZV9jdHJsX2Z1bmMNCj4gcHN0YXRlOiAwMDAwMDBjNSAobnpjdiBkYUlGIC1QQU4gLVVB
TyAtVENPIC1ESVQgLVNTQlMgQlRZUEU9LS0pDQo+IHBjIDogY2hlY2tfbW92ZV91bmV2aWN0
YWJsZV9mb2xpb3MrMHhiOC8weDRkMA0KPiBsciA6IGNoZWNrX21vdmVfdW5ldmljdGFibGVf
Zm9saW9zKzB4YjQvMHg0ZDANCj4gc3AgOiBmZmZmODAwMDA4MWEzYWQwDQo+IHgyOTogZmZm
ZjgwMDAwODFhM2FkMCB4Mjg6IGZmZmYwMzg1NmFjOTg4MDAgeDI3OiAwMDAwMDAwMDAwMDAw
MDAwDQo+IHgyNjogZmZmZmRlN2IxNjhlZTlkOCB4MjU6IGZmZmYwMzg1NmFlMjYwMDggeDI0
OiAwMDAwMDAwMDAwMDAwMDAwDQo+IHgyMzogZmZmZmRlN2IxNzU4ZDZjMCB4MjI6IDAwMDAw
MDAwMDAwMDAwMDEgeDIxOiBmZmZmODAwMDA4MWEzYjY4DQo+IHgyMDogMDAwMDAwMDAwMDAw
MDAwMSB4MTk6IGZmZmZmYzBlMTU5MzUwNDAgeDE4OiBmZmZmZmZmZmZmZmZmZmZmDQo+IHgx
NzogZmZmZjI1MGE2OGUzZDAwMCB4MTY6IDAwMDAwMDAwMDAwMDAwMTIgeDE1OiBmZmZmODAw
MDg4MWEzOGQ3DQo+IHgxNDogMDAwMDAwMDAwMDAwMDAwMCB4MTM6IGZmZmZkZTdiMTc1YTMx
NTAgeDEyOiAwMDAwMDAwMDAwMDAyYzU1DQo+IHgxMTogMDAwMDAwMDAwMDAwMGVjNyB4MTA6
IGZmZmZkZTdiMTc2MTEzZjggeDkgOiBmZmZmZGU3YjE3NWEzMTUwDQo+IHg4IDogMDAwMDAw
MDEwMDAwNGVjNyB4NyA6IGZmZmZkZTdiMTc1ZmIxNTAgeDYgOiBmZmZmODAwMDA4MWEzYjcw
DQo+IHg1IDogMDAwMDAwMDAwMDAwMDAwMSB4NCA6IDAwMDAwMDAwMDAwMDAwMDAgeDMgOiBm
ZmZmMDM4NTZhYzk4ODUwDQo+IHgyIDogMDAwMDAwMDAwMDAwMDAwMCB4MSA6IDAwMDAwMDAw
MDAwMDAwMDAgeDAgOiAwMDAwMDAwMzg3MDAwMDAwDQo+IENhbGwgdHJhY2U6DQo+ICAgY2hl
Y2tfbW92ZV91bmV2aWN0YWJsZV9mb2xpb3MrMHhiOC8weDRkMA0KPiAgIGNoZWNrX21vdmVf
dW5ldmljdGFibGVfcGFnZXMrMHg4Yy8weDExMA0KPiAgIGRybV9nZW1fcHV0X3BhZ2VzKzB4
MTE4LzB4MTk4DQo+ICAgZHJtX2dlbV9zaG1lbV9wdXRfcGFnZXNfbG9ja2VkKzB4NGMvMHg3
MA0KPiAgIGRybV9nZW1fc2htZW1fdW5waW4rMHgzMC8weDUwDQo+ICAgdmlydGlvX2dwdV9j
bGVhbnVwX29iamVjdCsweDg0LzB4MTMwDQo+ICAgdmlydGlvX2dwdV9jbWRfdW5yZWZfY2Ir
MHgxOC8weDJjDQo+ICAgdmlydGlvX2dwdV9kZXF1ZXVlX2N0cmxfZnVuYysweDEyNC8weDI5
MA0KPiAgIHByb2Nlc3Nfb25lX3dvcmsrMHgxZDAvMHgzMjANCj4gICB3b3JrZXJfdGhyZWFk
KzB4MTRjLzB4NDQ0DQo+ICAga3RocmVhZCsweDEwYy8weDExMA0KPiAgIHJldF9mcm9tX2Zv
cmsrMHgxMC8weDIwDQo+IENvZGU6IDk3ZmMzZmUxIGFhMTMwM2UwIDk0MDAzYWM3IGI0MDAw
MDgwIChmOTQwNGMwMCkNCj4gLS0tWyBlbmQgdHJhY2UgMDAwMDAwMDAwMDAwMDAwMCBdLS0t
DQo+IA0KPiBBZnRlciBzb21lIGludmVzdGlnYXRpb24gSSB0aGluayBJJ3ZlIGZvdW5kIHRo
ZSBjYXVzZSBvZiB0aGUgcHJvYmxlbToNCj4gVGhpcyBpcyB0aGUgZnVuY3Rpb25hbGl0eSwg
YWRkZWQgaW4gY29tbWl0IDNmOWYxYzY3NTcyZjVlNWU2ZGM4NDIxNmQ0OGQxNDgwZjNjNGZj
ZjYgd2hpY2gNCj4gaW50cm9kdWNlcyBzYWZlIG1lY2hhbmlzbSB0byB1bm1hcCBncmFudCBw
YWdlcyB3aGljaCBpcyB3YWl0aW5nIHVudGlsIHBhZ2VfY291bnQocGFnZSkgPSAxDQo+IGJl
Zm9yZSBkb2luZyB1bm1hcC4NCj4gVGhlIHByb2JsZW0gaXMgdGhhdCBEUk1fSU9DVExfTU9E
RV9DUkVBVEVfRFVNQiBjcmVhdGVzIGJ1ZmZlciB3aGVyZSBwYWdlX2NvdW50KHBhZ2UpID0g
Mi4NCj4gDQo+IE9uIG15IFFFTVUgdGVzdCBzdGFuZCBJJ20gdXNpbmcgWGVuIDQuMTYgKGFh
cmNoNjQpIHdpdGggZGViaWFuIGJhc2VkIERvbTAgKyBEb21VIG9uIHRoZSBsYXRlc3QNCj4g
a2VybmVscy4NCj4gSSd2ZSBjcmVhdGVkIHNvbWUgYXBwcyBmb3IgdGVzdGluZzoNCj4gVGhl
IGZpcnN0IG9uZSBpcyB0byBhbGxvY2F0ZSBncmFudCByZWZzIG9uIERvbVU6DQo+IGh0dHBz
Oi8vZ2l0aHViLmNvbS9vbGVrc2lpbW9pc2llaWV2L2xpbnV4L3RyZWUvZ250ZGV2X21hcF9i
dWZfdXBzdHJfZm9yLWxpbnVzLTYuMV8yDQo+IFRoZSBuYW1lIGlzIHRlc3Qua28gYW5kIGl0
IGNhbiBiZSBidWlsdCB1c2luZyBjb21tYW5kOg0KPiBjZCAuL3Rlc3Q7IG1ha2UNCj4gTk9U
RTogbWFrZWZpbGUgZXhwZWN0cyBrZXJuZWwgYnVpbGQgdG8gYmUgcHJlc2VudCBvbiAuLi8u
Li90ZXN0LWJ1aWxkIGRpcmVjdG9yeS4NCj4gDQo+IEl0IHNob3VsZCBiZSBydW4gb24gRG9t
VSB1c2luZyBjb21tYW5kOg0KPiBpbnNtb2QgdGVzdC5rbzsgZWNobyAiY3JlYXRlIiA+IC9z
eXMva2VybmVsL2V0eF9zeXNmcy9ldHhfdmFsdWUNCj4gDQo+IFJlc3VsdCB3aWxsIGJlIHRo
ZSBmb2xsb3dpbmc6DQo+IFsgIDEyNi4xMDQ5MDNdIHRlc3Q6IGxvYWRpbmcgb3V0LW9mLXRy
ZWUgbW9kdWxlIHRhaW50cyBrZXJuZWwuDQo+IFsgIDEyNi4xNTA1ODZdIFN5c2ZzIC0gV3Jp
dGUhISENCj4gWyAgMTI2LjE1MDc3M10gY3JlYXRlDQo+IFsgIDEyNi4xNTA3NzNdDQo+IFsg
IDEyNi4xNTA4ODhdIEhlbGxvLCBXb3JsZCENCj4gWyAgMTI2LjE1MTIwM10gSGVsbG8sIFdv
cmxkIQ0KPiBbICAxMjYuMTUxMzI0XSBncmVmIDMwMQ0KPiBbICAxMjYuMTUxMzc2XSBhZGRy
IGZmZmYwMDAwMDg4M2QwMDANCj4gWyAgMTI2LjE1MTQzMV0gZ3JlZiAzMDINCj4gWyAgMTI2
LjE1MTQ1NF0gYWRkciBmZmZmMDAwMDA4ODNlMDAwDQo+IFsgIDEyNi4xNTE0NzhdIGdyZWYg
MzAzDQo+IFsgIDEyNi4xNTE0OTddIGFkZHIgZmZmZjAwMDAwODgzZjAwMA0KPiBbICAxMjYu
MTUxNTI1XSBncmVmIDMwNA0KPiBbICAxMjYuMTUxNTQ2XSBhZGRyIGZmZmYwMDAwMDg4NDAw
MDANCj4gWyAgMTI2LjE1MTU3M10gZ3JlZiAzMDUNCj4gWyAgMTI2LjE1MTU5M10gYWRkciBm
ZmZmMDAwMDA4ODQxMDAwDQo+IA0KPiBUaGUgc2Vjb25kIGlzIGZvciBkb20wIGFuZCBjYW4g
YmUgZm91bmQgaGVyZToNCj4gaHR0cHM6Ly9naXRodWIuY29tL29sZWtzaWltb2lzaWVpZXYv
eGVuL3RyZWUvZ250ZGV2X2ZkDQo+IA0KPiBIb3cgdG8gYnVpbGQ6DQo+IG1ha2UgLUMgdG9v
bHMvY29uc29sZSBhbGwNCj4gDQo+IFJlc3VsdDogLi90b29scy9jb25zb2xlL2dudF90ZXN0
IHNob3VsZCBiZSB1cGxvYWRlZCB0byBEb20wDQo+IA0KPiBTdGFydDogc3VkbyAuL2dudF90
ZXN0X21hcCAxIDMwMSAzMDIgMzAzIDMwNCAzMDUNCj4gV2hlcmUgMSBpcyBEb21VIElEIGFu
ZCAzMDEgMzAyIDMwMyAzMDQgMzA1IC0gZ3JlZnMgZnJvbSB0ZXN0LmtvIG91dHB1dA0KPiAN
Cj4gVGhpcyB3aWxsIGNyZWF0ZSBidWZmZXIgdXNpbmcgaW9jdGxzIERSTV9JT0NUTF9NT0RF
X0NSRUFURV9EVU1CIHRoZW0gcGFzc2VzIGl0IGFzIGJhY2tpbmcNCj4gc3RvcmFnZSB0byBn
bnRkZXYgYW5kIHRoZW4gZGVzdHJveXMgaXQgdXNpbmcgRFJNX0lPQ1RMX01PREVfREVTVFJP
WV9EVU1CLg0KPiBUaGUgcHJvYmxlbSBpcyB0aGF0IHdoZW4gZHVtYiBidWZmZXIgaXMgY3Jl
YXRlZCB3ZSBvYnNlcnZlIHBhZ2VfY291bnQocGFnZSkgPSAyLiBTbw0KPiB3aGVuIGJlZm9y
ZSBidWZmZXIgcmVsZWFzZSBJJ20gdHJ5aW5nIHRvIHVubWFwIGdyYW50IHJlZnMgdXNpbmcg
dW5tYXBfZ3JhbnRfcGFnZXMgaXQgaXMgY2FsbGluZw0KPiBfX2dudHRhYl91bm1hcF9yZWZz
X2FzeW5jLCB3aGljaCBwb3N0cG9uZXMgYWN0dWFsIHVubWFwcGluZyB0byA1IG1zIGJlY2F1
c2UNCj4gcGFnZV9jb3VudChwYWdlKSA+IDEuDQo+IFdoaWNoIGNhdXNlcyBkcm1fZ2VtX2dl
dF9wYWdlcyB0byB0cnkgdG8gZnJlZSBwYWdlcywgd2hpY2ggYXJlIHN0aWxsIG1hcHBlZC4N
Cj4gQWxzbyBpZiBJIGNoYW5nZSBpbiB0aGUgZm9sbG93aW5nIGxpbmU6DQo+IGh0dHBzOi8v
Z2l0aHViLmNvbS90b3J2YWxkcy9saW51eC9ibG9iL2JiMWExMTQ2NDY3YWQ4MTJiYjY1NDQw
Njk2ZGYwNzgyZTJiYzYzYzgvZHJpdmVycy94ZW4vZ3JhbnQtdGFibGUuYyNMMTMxMw0KPiBj
aGFuZ2UgZnJvbSBwYWdlX2NvdW50KGl0ZW0tPnBhZ2VzW3BjXSkgPiAxIHRvIHBhZ2VfY291
bnQoaXRlbS0+cGFnZXNbcGNdKSA+IDIgLSBldmVyeXRoaW5nIHdvcmtzIGZpbmUuDQo+IFRo
ZSBvYnZpb3VzIHdheSBmb3IgZml4IHRoaXMgaXNzdWUgSSBzZWUgaXMgdG8gbWFrZSB0aGUg
ZXhwZWN0ZWQgcGFnZV9jb3VudA0KPiBmb3IgX19nbnR0YWJfdW5tYXBfcmVmc19hc3luYyBj
b25maWd1cmFibGUgZm9yIGVhY2ggYnVmZmVyLCBidXQgSSdtIG5vdyBzdXJlDQo+IGlmIHRo
aXMgaXMgdGhlDQo+IGJlc3Qgc29sdXRpb24uDQo+IA0KPiBJIHdvdWxkIGJlIGhhcHB5IHRv
IGhlYXIgeW91ciB0aG91Z2h0cyBhbmQgYWR2aXNlcyBhYm91dCBob3cgdG8gZml4IHRoaXMg
c2l0dWF0aW9uLg0KDQpNeSBmaXJzdCB0aG91Z2h0IHdvdWxkIGJlIHRvIHNhdmUgdGhlIHBh
Z2VfY291bnQoKSBvZiBlYWNoIHBhZ2Ugd2hlbiBkb2luZw0KdGhlIG1hcCBvcGVyYXRpb24s
IGFuZCB0aGVuIGNvbXBhcmUgdG8gdGhhdCB2YWx1ZS4NCg0KVGhlIG5hdHVyYWwgcGxhY2Ug
dG8gc3RvcmUgdGhpcyBjb3VudCB3b3VsZCBiZSBzdHJ1Y3QgeGVuX3BhZ2VfZm9yZWlnbiwN
CmJ1dCB0aGVyZSBhcmUgb25seSAxNiBiaXRzIGZyZWUgZm9yIHRoZSA2NC1iaXQgc3lzdGVt
IGNhc2UgKGl0IGlzIHVzaW5nDQp0aGUgc3RydWN0IHBhZ2UtPnByaXZhdGUgZmllbGQgZm9y
IHRoYXQgcHVycG9zZSksIHNvIHlvdSdkIG5lZWQgdG8gYmFpbA0Kb3V0IGluIGNhc2UgcGFn
ZV9jb3VudCgpIGlzID4gNjU1MzUuDQoNCg0KSnVlcmdlbg0K
--------------501KvknMR9wxJKQC5EqDg8Pq
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------501KvknMR9wxJKQC5EqDg8Pq--

--------------e4uMnI8o0ZlqDuWh7LC5S2Sb--

--------------zsrO4Hs8YW0rK26Zjkfdj30z
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNP7dUFAwAAAAAACgkQsN6d1ii/Ey8Y
Vgf+Pbo41cM7sqEZXwGJe7frmk432niuOhpsmsDCQeELFFgQeCp9SD1vE7z2bxHGSLTVTS00kZcH
GCEnM/bgo1hT4cKPfy57ULLdPS0EWdnmBJLGnRhAU9QWPzBNwXrkT2esuh97b6iuRRlpCd4J4wmK
obhBjsTdgPy72OQVCEN0WDZt4Xf5a4YEBk+H04OTUHDoV+sv2LvaoLp27jo9hpsEt6ftPl0vjsjv
FN4T9KEwGRofwhuv4v5JGcEjWV7XrfTqxkNbNuM8GDT5aoZoCR3VSLqU16oUO+5MDWBajwoy0U15
ORo+qIYxMdNcLL+01Ov1FTIMnTgO9c3qLRZVQ7oxog==
=0feV
-----END PGP SIGNATURE-----

--------------zsrO4Hs8YW0rK26Zjkfdj30z--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 12:46:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 12:46:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425802.673844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol8So-0001Lg-Vw; Wed, 19 Oct 2022 12:46:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425802.673844; Wed, 19 Oct 2022 12:46:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol8So-0001LZ-TF; Wed, 19 Oct 2022 12:46:26 +0000
Received: by outflank-mailman (input) for mailman id 425802;
 Wed, 19 Oct 2022 12:46:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/vg5=2U=epam.com=prvs=22912afb2d=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1ol8Sn-0001LN-Dt
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 12:46:25 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 09264555-4fac-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 14:46:23 +0200 (CEST)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JCJ04W021098;
 Wed, 19 Oct 2022 12:46:14 GMT
Received: from eur03-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur03lp2111.outbound.protection.outlook.com [104.47.30.111])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3k9ru8njrp-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 19 Oct 2022 12:46:13 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by DB9PR03MB9830.eurprd03.prod.outlook.com (2603:10a6:10:454::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 12:46:07 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::551e:e1bc:b684:b7bb]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::551e:e1bc:b684:b7bb%9]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 12:46:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09264555-4fac-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h6h3TxBzyzm0CAHxPXQ6tRB8vMEafiMMSak1RHc/8gPDtm1WKvujvR/QEQwwXpUURIgi0VTC4iOYqsT40Yu5HysJsgaI2bAc2v+mmhHWCltBzt+J+4bQeJAxel9pl9s2ydVgUOpekKR+Yw0zqx6xQPoIMejw9h3Ql7W1Fc5dPy+/fo8nx3617Im6PFSYaKojKSoiekt0lmgW+3g+BerB/ict0/xCExO4oto2OkGbeD9oXVyBrnvUqPo/nxuCF9Xh9Pc0LOaFCP5n4tdO3c3uYGhyywDmfanYKm3/pja7EUyVxxjv+Fd2Zhlu45jvzZjMioE0Fw1FzAMb5+SUxNaQuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=S9WgTCEAkpuz8hI3Gi58gMbr+/FmkVsfuGpafWrHMcw=;
 b=Da5mTb+pH7a9VDxmomQu9fDgLXSObXMYLWjkBNVC8p0RSLLsBqoNqe7JMiVYHl8IPYwsxoPrWxg7OTArgoPaxCAnFzL55rjb6dt28hVky9UFxxnVIc6rgUZd8CHlxZMwEzewpMPerrm0pT2eUCIxccI3XzLNPG8v/9FFOiPykAz3X8pX78JzA0Yfkb6lNHxjzeJWiG+RYnD64jfIkUVUw74inOHb3xG5gbAfHyWB6WqcqY1QDvgf2q+HCRBgpH2TtQNFIF6encLClq1WXZ/v1CDubhNc47ZJi7PGVFXwJww2MP5bjhHMRFLccKXAtqpI4sX/LY8lkH0WxIAqA/zsuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=S9WgTCEAkpuz8hI3Gi58gMbr+/FmkVsfuGpafWrHMcw=;
 b=ANyk0KQZ6lXtSw2sqyNaF0mz5LjodH9RhcOqo0zhZ69ytOmWTfOSlg28fQC7HZeN6h9SBCm7e9RhMLQiP8CBdXNhYhJaPfJjQHQWE1UIkCQIs5UuOvM6w3iIkRMfvfolVyJp9ZAUfOjucMeSOth4FmKpG2vymWP+A7fcexU1+w25HlYcUbkI9zTVHGEuFRxBFFfw+YVtz45teWO3ZmRFUJI1TB1rFlqNvymNKYzIj9P5eZi5/2o1GlG/PVlRbunEH8W3BJw7TIVPfj9IVmPH8lipzXOB6NvSfFTbrrzrJoCxHKMhGVYt/CbqWvRW2m96An/SF9NrB+kHE5rMcaI9iQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Juergen Gross <jgross@suse.com>
CC: "jennifer.herbert@citrix.com" <jennifer.herbert@citrix.com>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        "maarten.lankhorst@linux.intel.com" <maarten.lankhorst@linux.intel.com>,
        "mripard@kernel.org" <mripard@kernel.org>,
        "tzimmermann@suse.de"
	<tzimmermann@suse.de>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: Issue on unmap_grant_pages before releasing dmabuf
Thread-Topic: Issue on unmap_grant_pages before releasing dmabuf
Thread-Index: AQHY46egGI7L6jjRBkOb9R/tnZLb7K4VpcKAgAAEcoA=
Date: Wed, 19 Oct 2022 12:46:07 +0000
Message-ID: <Y0/xj+TA4YLdxJ2M@EPUAKYIW015D>
References: <Y0/U0RNDSRdV7bex@EPUAKYIW015D>
 <9a13e1aa-91a8-7b06-2807-769552639b0c@suse.com>
In-Reply-To: <9a13e1aa-91a8-7b06-2807-769552639b0c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PA4PR03MB7136:EE_|DB9PR03MB9830:EE_
x-ms-office365-filtering-correlation-id: b6d7a8fb-bb11-4859-57fb-08dab1cfe477
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 F4n0dz/buoVW7NLBWjjhjJAibcNj1qBpRY7kEVOxxoHkjbg/FGOIeHHvR/lVnC19zVI7Z0+f05/Z8m/CaE7QtBeuk/7OAwAO6fYvQkKv3Y09AuYNaW6VNOPkyzcwmtlwXHesL5xi+XzPTbhQo9HaxWefK2iOrxqHbP9oIyCYbd2C4NZ3pmZNokmxGH5GM89i/HvT+Mp4oQvKrfMzB8/SOtdnd1J0icWkpkpF199eL4mxhrxKvyzPyUizxisv3VDf0ctRETRiPMWXuNZNA99RSrDNh+SmezmPAf+FsRYOfZ4J7JWoYexXBtH3zFSmvlgCqmBGb/i1NUItZG04SlYfbjqbGGKM0FrOrdFEYgNSIsAqQcn8KZLgrOSQ6vP8SOOxiI7wb4IGjyU1hyEWfp6Mav/Q9e5CNHhY7y8IGH+GZePBzRb6ezXxtL948BM1RN38un7/fQNAN4t0/1CUYVMsa7xYr5ibQftZMrA4t3L5jYm9vYC41UufK1RGmOkBGbydiyRWR8V8uJoFpzZwyyULItIC9bvFCETrYzCM8wVvjg0CS9wYuqISgXGOeoY1iRU/hp2H1zBcuczDWy/FoeZTFMXL+G8JRsNdfjV+p8o2ry2WSk08i2trgzKNcYn6JuBlE7gH9ARIyZXaP4xS+wsPOaw2wUExfhCEFMk+ewCYv3ZqnkzHL1oTfRlXiWzLuzqYnSdiu+hti/riOZH9ALaC01u9+ojf/rDeA+TTYyZi0HTKDx2+NLKwnXkC4TNCeIUYGAu+zlhK1Lp+AyFw6tXc3PfbdqgOO240jW0mwIFtcszP9sciJhM+3GrDG/VnQSaNKz/qVZvP5/yArPLMrCw84A==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(84040400005)(451199015)(316002)(6916009)(64756008)(4326008)(186003)(6506007)(54906003)(26005)(6512007)(8936002)(2906002)(86362001)(9686003)(41300700001)(53546011)(83380400001)(66446008)(66946007)(76116006)(91956017)(66556008)(66476007)(8676002)(5660300002)(33716001)(71200400001)(122000001)(38070700005)(6486002)(45080400002)(38100700002)(478600001)(966005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?vXbCIu7qXUHMs34y2WnD1Wq7yGRIyUbSDN5huq/V04m8Xzf608WsKs+xnelU?=
 =?us-ascii?Q?T1/8mI5Gj07sSZgyQ7szuHx0soLIyF5IcdrStrLFuIu+JGvVB7pEzZADHMQ5?=
 =?us-ascii?Q?VI+DRDeKOJHnUcFAo+rDjwFDcJMTvF0ByB0gq2WTvZnkNqz1mgUXOh1JomAN?=
 =?us-ascii?Q?i1qiBtkk1FI+Y5xzAsNdCvwD0L0A+/LSzN9HjUV7V94Rr7sCA/pFeymEyaxx?=
 =?us-ascii?Q?TIt0GfKlgvACPyFXwNd0hHmoUiXLI71PqROnt9PoOZYTRkZ38IXnhTwUPuIR?=
 =?us-ascii?Q?DXKnT+4q7VhoBpSOw0Uy3Y6aKrbIQxVJ59YxW451V3Z4yQbm+i27aZtyVbHJ?=
 =?us-ascii?Q?SeE0lQiF2mJb+tw6sce1eRsfVU9ctZyhyRnU75254GF8iI/M3y279+2PFLaG?=
 =?us-ascii?Q?jWrMf60etpSyP85FXk74jfURoVZ+mqYVS3U0ZFsfhLECh0TaAqOyv1cVSQft?=
 =?us-ascii?Q?/7y3L/jynGidWF0JU3qVOhhU33ta446A2hVKkvR9VOt01CeA8V4TwLqsBtXT?=
 =?us-ascii?Q?g6k0yRnmAItstLjfmSxO4i4/Vr4aYtPNCzucDZ3ifCXUnKGBDvN4d5hZYxwL?=
 =?us-ascii?Q?zEWNrTwZh8itYzESTKrzXO1YQcnPGjReINkTXd5lVpRIEwmOBCnoI2ebemdM?=
 =?us-ascii?Q?Jg0a/kr1O6tQSWFLEWgZNcYQPcz74nCQDPWZz31mHWG7nfETynobji1l3BlH?=
 =?us-ascii?Q?y59b4ZlhQL+tIo2ANQIgZND/bvPzuWWp0TWQMkoq+JkeFZfBKGuBXQqqxqFn?=
 =?us-ascii?Q?PJp0WlXKrpXWmSfiE2qrV1m0DqNTLbhAeUJzv+J8ZnsLfC2zn6IqlChepuuW?=
 =?us-ascii?Q?b3MXzplwdWdvShja2Jh7n/dStS6y1Jzsn6vIy+R/BU9T7gAdOygCfQduIe7y?=
 =?us-ascii?Q?WegymwJTRK0ROXOWzaXPAvmIq3Lhtk6WuL+/0CoOmvb2w387UqrpL63w33Sb?=
 =?us-ascii?Q?1Sk4htnHl2vPHkbMeJx64T3WmEXLohyjkvRj4HC0R5vzYiRk8Ka4rpWHO54n?=
 =?us-ascii?Q?TfYh+tf/PbF34YWqUuGXHdMXgon7o5Cf4om+9zT+kcSaAyRDnCmpGxsFv1NG?=
 =?us-ascii?Q?NSqsGJ3jzRVbBvTJB/Dnq6c1j5F2Z9uB131yhorho2oGZpRKzc5NMzhVsofu?=
 =?us-ascii?Q?YkKcUTf65FWR/iBYPIYXMQaw+Gb45PLDqFgOsQuyIyx0ii8sjz+EXL0V1wZX?=
 =?us-ascii?Q?I5ACpaf5tNchBXR9gmNFRSZw27lRvZ+QGG4mT8yp3se1Q5gZBTm062TY1DSE?=
 =?us-ascii?Q?8m4w28Dfv/TDMS+dqE2jx0wp/aYItOHbGtnAQufUuxA0zkRuzURTh3zUw9po?=
 =?us-ascii?Q?UBvoFI61oTTFzJGbyTZgh34GbiU3/f6c4wyLquYSW96/il8QcuOHVqvT21aE?=
 =?us-ascii?Q?rI1jFN0AfEuijYWEJcVR/hVS4TSua3iiTW3mqSSl08paW6mCHCy3pXzr/QHW?=
 =?us-ascii?Q?XKI94gjaYkxGtjTADHLNPE1i3HlbRyXoKKGSNsRuMZI6ZcxpbN+1M5J+lFpW?=
 =?us-ascii?Q?4SwwaIK4Zz/c+wsuMTevIxfHlnyS1DBEpHj93dOJg+St4pZIluecQE8ExlN3?=
 =?us-ascii?Q?iXQDDhxU+LLHqdqSRC6r91gI50SPj3KVw7eUttu2ZNv6Yg5e6GWNkXPkpULb?=
 =?us-ascii?Q?+Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C041C1E4FC319C43B0C76BE07351FE99@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6d7a8fb-bb11-4859-57fb-08dab1cfe477
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 12:46:07.5407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uUtL81rzEnAmi7emDdh0JlC5X77tyrBhVtHX7rVxQQidRLnBUQbbgFAcu9OzXst6iYP9CLhaOs1gRnJPpolM2q2Gw52NVa/ROO5U3xOH7ao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB9830
X-Proofpoint-ORIG-GUID: BRe2ekHQ9FEKnw-sF6ZtJ-FRmZFkq8iR
X-Proofpoint-GUID: BRe2ekHQ9FEKnw-sF6ZtJ-FRmZFkq8iR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_07,2022-10-19_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0
 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 mlxlogscore=999
 lowpriorityscore=0 suspectscore=0 mlxscore=0 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210190071

On Wed, Oct 19, 2022 at 02:30:13PM +0200, Juergen Gross wrote:
> On 19.10.22 12:43, Oleksii Moisieiev wrote:
> > Greetings.
> >=20
> > I need your advise about the problem I'm facing right now:
> > I'm working on the new type of dmabuf export implementation. This
> > is going to be new ioctl to the gntdev and it's purpose is to use
> > external buffer, provided by file descriptor as the backing storage
> > during export to grant refs.
> > Few words about the functionality I'm working on right now:
> > My setup is based on IMX8QM (please see PS below if you need
> > configuration details)
> >=20
> > When using dma-buf exporter to create dma-buf with backing storage and
> > map it to the grant refs, provided from the domain, we've met a problem=
,
> > that several HW (i.MX8 gpu in our case) do not support external buffer
> > and requires backing storage to be created using it's native tools
> > (eglCreateImageKHR returns EGL_NO_IMAGE_KHR for buffers, which were not
> > created using gbm_bo_create).
> > That's why new ioctls were added to be able to pass existing dma-buffer
> > fd as input parameter and use it as backing storage to export to refs.
> > Kernel version on IMX8QM board is 5.10.72 and itworks fine on this kern=
el
> > version.
> >=20
> > New ioctls source code can be found here:
> >   https://github.com/oleksiimoisieiev/linux/tree/gntdev_map_buf_upstr_f=
or-linus-6.1_2
> > Now regarding the problem I've met when rebased those code on master:
> > On my test stand I use DRM_IOCTL_MODE_CREATE_DUMB/DRM_IOCTL_MODE_DESTRO=
Y_DUMB ioctls
> > to allocate buffer and I'm observing the following backtrace on DRM_IOC=
TL_MODE_DESTROY_DUMB:
> >=20
> > Unable to handle kernel paging request at virtual address 0000000387000=
098
> > Mem abort info:
> >    ESR =3D 0x0000000096000005
> >    EC =3D 0x25: DABT (current EL), IL =3D 32 bits
> >    SET =3D 0, FnV =3D 0
> >    EA =3D 0, S1PTW =3D 0
> >    FSC =3D 0x05: level 1 translation fault
> > Data abort info:
> >    ISV =3D 0, ISS =3D 0x00000005
> >    CM =3D 0, WnR =3D 0
> > user pgtable: 4k pages, 48-bit VAs, pgdp=3D000000006df98000
> > [0000000387000098] pgd=3D0800000064f4f003, p4d=3D0800000064f4f003, pud=
=3D0000000000000000
> > Internal error: Oops: 96000005 [#1] PREEMPT SMP
> > Modules linked in: xen_pciback overlay crct10dif_ce ip_tables x_tables =
ipv6
> > PU: 0 PID: 34 Comm: kworker/0:1 Not tainted 6.0.0 #85
> > Hardware name: linux,dummy-virt (DT)
> > Workqueue: events virtio_gpu_dequeue_ctrl_func
> > pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=3D--)
> > pc : check_move_unevictable_folios+0xb8/0x4d0
> > lr : check_move_unevictable_folios+0xb4/0x4d0
> > sp : ffff8000081a3ad0
> > x29: ffff8000081a3ad0 x28: ffff03856ac98800 x27: 0000000000000000
> > x26: ffffde7b168ee9d8 x25: ffff03856ae26008 x24: 0000000000000000
> > x23: ffffde7b1758d6c0 x22: 0000000000000001 x21: ffff8000081a3b68
> > x20: 0000000000000001 x19: fffffc0e15935040 x18: ffffffffffffffff
> > x17: ffff250a68e3d000 x16: 0000000000000012 x15: ffff8000881a38d7
> > x14: 0000000000000000 x13: ffffde7b175a3150 x12: 0000000000002c55
> > x11: 0000000000000ec7 x10: ffffde7b176113f8 x9 : ffffde7b175a3150
> > x8 : 0000000100004ec7 x7 : ffffde7b175fb150 x6 : ffff8000081a3b70
> > x5 : 0000000000000001 x4 : 0000000000000000 x3 : ffff03856ac98850
> > x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000387000000
> > Call trace:
> >   check_move_unevictable_folios+0xb8/0x4d0
> >   check_move_unevictable_pages+0x8c/0x110
> >   drm_gem_put_pages+0x118/0x198
> >   drm_gem_shmem_put_pages_locked+0x4c/0x70
> >   drm_gem_shmem_unpin+0x30/0x50
> >   virtio_gpu_cleanup_object+0x84/0x130
> >   virtio_gpu_cmd_unref_cb+0x18/0x2c
> >   virtio_gpu_dequeue_ctrl_func+0x124/0x290
> >   process_one_work+0x1d0/0x320
> >   worker_thread+0x14c/0x444
> >   kthread+0x10c/0x110
> >   ret_from_fork+0x10/0x20
> > Code: 97fc3fe1 aa1303e0 94003ac7 b4000080 (f9404c00)
> > ---[ end trace 0000000000000000 ]---
> >=20
> > After some investigation I think I've found the cause of the problem:
> > This is the functionality, added in commit 3f9f1c67572f5e5e6dc84216d48d=
1480f3c4fcf6 which
> > introduces safe mechanism to unmap grant pages which is waiting until p=
age_count(page) =3D 1
> > before doing unmap.
> > The problem is that DRM_IOCTL_MODE_CREATE_DUMB creates buffer where pag=
e_count(page) =3D 2.
> >=20
> > On my QEMU test stand I'm using Xen 4.16 (aarch64) with debian based Do=
m0 + DomU on the latest
> > kernels.
> > I've created some apps for testing:
> > The first one is to allocate grant refs on DomU:
> > https://github.com/oleksiimoisieiev/linux/tree/gntdev_map_buf_upstr_for=
-linus-6.1_2
> > The name is test.ko and it can be built using command:
> > cd ./test; make
> > NOTE: makefile expects kernel build to be present on ../../test-build d=
irectory.
> >=20
> > It should be run on DomU using command:
> > insmod test.ko; echo "create" > /sys/kernel/etx_sysfs/etx_value
> >=20
> > Result will be the following:
> > [  126.104903] test: loading out-of-tree module taints kernel.
> > [  126.150586] Sysfs - Write!!!
> > [  126.150773] create
> > [  126.150773]
> > [  126.150888] Hello, World!
> > [  126.151203] Hello, World!
> > [  126.151324] gref 301
> > [  126.151376] addr ffff00000883d000
> > [  126.151431] gref 302
> > [  126.151454] addr ffff00000883e000
> > [  126.151478] gref 303
> > [  126.151497] addr ffff00000883f000
> > [  126.151525] gref 304
> > [  126.151546] addr ffff000008840000
> > [  126.151573] gref 305
> > [  126.151593] addr ffff000008841000
> >=20
> > The second is for dom0 and can be found here:
> > https://github.com/oleksiimoisieiev/xen/tree/gntdev_fd
> >=20
> > How to build:
> > make -C tools/console all
> >=20
> > Result: ./tools/console/gnt_test should be uploaded to Dom0
> >=20
> > Start: sudo ./gnt_test_map 1 301 302 303 304 305
> > Where 1 is DomU ID and 301 302 303 304 305 - grefs from test.ko output
> >=20
> > This will create buffer using ioctls DRM_IOCTL_MODE_CREATE_DUMB them pa=
sses it as backing
> > storage to gntdev and then destroys it using DRM_IOCTL_MODE_DESTROY_DUM=
B.
> > The problem is that when dumb buffer is created we observe page_count(p=
age) =3D 2. So
> > when before buffer release I'm trying to unmap grant refs using unmap_g=
rant_pages it is calling
> > __gnttab_unmap_refs_async, which postpones actual unmapping to 5 ms bec=
ause
> > page_count(page) > 1.
> > Which causes drm_gem_get_pages to try to free pages, which are still ma=
pped.
> > Also if I change in the following line:
> > https://github.com/torvalds/linux/blob/bb1a1146467ad812bb65440696df0782=
e2bc63c8/drivers/xen/grant-table.c#L1313
> > change from page_count(item->pages[pc]) > 1 to page_count(item->pages[p=
c]) > 2 - everything works fine.
> > The obvious way for fix this issue I see is to make the expected page_c=
ount
> > for __gnttab_unmap_refs_async configurable for each buffer, but I'm now=
 sure
> > if this is the
> > best solution.
> >=20
> > I would be happy to hear your thoughts and advises about how to fix thi=
s situation.
>=20
> My first thought would be to save the page_count() of each page when doin=
g
> the map operation, and then compare to that value.
>=20
> The natural place to store this count would be struct xen_page_foreign,
> but there are only 16 bits free for the 64-bit system case (it is using
> the struct page->private field for that purpose), so you'd need to bail
> out in case page_count() is > 65535.
>=20
>=20
> Juergen

Hello Juergen,

Thank you for the advise.
I think I'll use this approach if everybody fine with it.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 13:35:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 13:35:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425809.673856 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol9E1-0006h7-MO; Wed, 19 Oct 2022 13:35:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425809.673856; Wed, 19 Oct 2022 13:35:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol9E1-0006gm-J3; Wed, 19 Oct 2022 13:35:13 +0000
Received: by outflank-mailman (input) for mailman id 425809;
 Wed, 19 Oct 2022 13:35:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tv8N=2U=epam.com=prvs=22918d0935=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ol9E0-0006gS-Gu
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 13:35:12 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d807d4b0-4fb2-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 15:35:08 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JCKWjn024537;
 Wed, 19 Oct 2022 13:34:55 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k9vmcmepc-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 19 Oct 2022 13:34:54 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DU2PR03MB8008.eurprd03.prod.outlook.com (2603:10a6:10:2df::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 13:34:50 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 13:34:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d807d4b0-4fb2-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BiJZNE/QeHswfPlTtdBx4veQw1IJ2g3CnOjzzCNFFC3zQCtDmc06Sv9OEIavBGY+UnU/hrrRezSEEwDpc43gT/7rrM+kBr+DhPyxxAA3y+BDWfxXBQ5uK28BQQJ7uZW9nZuvzmCwhSwINp8Vp+8yTAN2tCW17JhxklbGy43WHq6ExzOt2UAwz6U1oSYnvs1DbyDm304mnxlu3MJkPwL2h53mM04bnJ5FVd3L6jVPC/S35LnUOBaCdZ9MZGOwAAQB9aNnrwWBEgj/1fBWWQ7d6lsbE/mXDkzArvNQx8q8150q1h2C+XoP50cgr9ULwZjwHgN90UrWyz3D32BsUolvjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iJ0/Aso2A9HDFRygp9MAOKxPZ/LgnYoBYE6ey3KN8V4=;
 b=OnKS5a2YWzvsSnQ3m89PyJOTrqYtg/y51YfXh3A2rYZEnLwfEFOmPJoC6Gb7N7e8C0+RdEyBg1DxTbBzfWK1xQzeqMehQErWDQKk0b4UKDFlnzmqwKVCBzh2Tpmqi/UaNN8qOBtfFTDGGhfyCHVm6I4c+Bwbh0CoWhQqhOuUtw0DX90JyNKcmzYuuYdDqagTD285auT0d0CYf2wWcMkUVt2QY5pOHMY2ghjeAJV+ikRJnax/axyKopEqEvW5VudNGbZkdNu7NhrLyyLaoyjPl4Sd2HcPOwGFX45s96mxcSudxZbj1UzizLKun/LzrbHrJfKqWJatFkhgdFEusm0NcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iJ0/Aso2A9HDFRygp9MAOKxPZ/LgnYoBYE6ey3KN8V4=;
 b=KE+6gqVdtJKQ2qnWWeuu1B0gnXy9oPMKLkPgU9ShJjMkJyatcabJhHeC21944eX6Kx2qALNqNrNMkyXjPDJ66Udp5WAuHmoMX1IJj6T6TwArqAyeRsdXMx+R/aFivVmbpXjnk4qeITjepDkDpv+BhfQAhL6y1Spi4V21zN64ph7SiGKX0+tIdXaYUSR1rOYEnBtxUxlFucWs2JCSqM7Fhxl0cSgZLu1LV9PnJFduZpU72DNj0SV76R37fjlaQfoioiLY6FLMXlzLl5kl1YOZKdTGn9RWxnDJtc31f0S1lIhSdcJ9f/R8Td/XFTVfdVwpyoRe1TBd2o3AdIr+EC3JYA==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Topic: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Index: 
 AQHY2avbTqg8YKTBpUCScd7xSfM5Yq4CIOiAgAkdnYCAAET3gIAEI/OAgAN2W4CAAq38gA==
Date: Wed, 19 Oct 2022 13:34:50 +0000
Message-ID: <af073c71-df43-4a5c-c67a-a9858678f588@epam.com>
References: <20221006174804.2003029-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop>
 <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com>
 <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
 <16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com>
 <alpine.DEB.2.22.394.2210171323450.2351079@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210171323450.2351079@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DU2PR03MB8008:EE_
x-ms-office365-filtering-correlation-id: 9246b1df-c6c1-4162-8b9f-08dab1d6b2ae
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 j52yvgerpeyySr2TkPaYiLXb34KLh053xYB4A9NivsckEjwsmhSveTQDcxuaJoj4gcS1ajUxGkXfIXnI6OIXjaiET0aG5TuhTWyKFfb3AOlC54ss3Fbqu7WCfVsBaWttkpp6xqAulGE28lXKjxlI+tMYudjKOhgvWytn9aec/yIWQxNG/Wz8y6eTObtsPGgKTPDVt89NbERfPcKvadQXYBVvB+kFj48ulFN+HGxdLW6rhp0I7ZpAD5mEOLRU2iXtct4Q25Gq9oAJc83w9sAM0aFQEt2hiX89wPrh1x55rS2XgOarW8izspjd9/AZ/C8G7ZiGKTdcjc/3rRYTSOujbetJj6lpMkmHPfBadyO9qs4q359q+kUdou5xW50xT1MgaDMfnkyr1KusnH1WDO2r1T8UWrJ2/u3/odA+9o4G9Ti5nHxRq5DosuUrtnlBJ71Gc7uLFGMXGUueiUzyKyRPK2hciu8pVZEWqqPpdn242YV6MmCn5mlQU7GSkj+caxbGf7n7Ec41QAP05JVSEuc+BuVE6Klhh2jAsxV/O1N8v/SagBC3JYL92+k+7Xv2Z4JxIYVsyv1s0/KIsoWOz917zOIYi42BjKilPtXilxfddlZI/7JkUOsIgfSa28/it5eLHpfudswJPeBQ7Jk+r+221q+YKbj/JkI8uycQgvJuwVVOnyc0Rs/P4OLa01CWaekFJhVzyabnFZK1/OyFVwEylaU5N+n8wM65yU/xypYLikVO+ogJvMErjsctfpAUGyMVbRe5U46IOvJCtMzfxk7GxPEDgLGM9eYKwJmuA1+LC3xkmIN7QJrlc1u9zKwUVcEgGk6dDJQXwHhOhS+hIt+AKeTdCjmp77aDOzqJwxcTSf0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(396003)(346002)(376002)(451199015)(2616005)(186003)(6506007)(26005)(53546011)(55236004)(6512007)(83380400001)(2906002)(5660300002)(30864003)(66476007)(54906003)(6916009)(316002)(966005)(6486002)(478600001)(71200400001)(41300700001)(8936002)(91956017)(64756008)(4326008)(8676002)(66556008)(66946007)(76116006)(66446008)(66899015)(86362001)(31696002)(36756003)(38100700002)(122000001)(38070700005)(31686004)(45980500001)(579004)(559001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OURjVkRCd29qMDl2OEloV0RqSFFRUEUzejFnZ2thS3pIUnIwUXNySU1aUGd5?=
 =?utf-8?B?dldkRkRwWW1GMkZiVDBoZmhDTE0xei9BbHBBREF3dFBwNjZmb091ZUQwSzYv?=
 =?utf-8?B?VTlaTjZGeEdiQUZiMk1IN3ZFRTVrcE1jZ2pFSDhXcU45OVJRcktPVjRaWGRE?=
 =?utf-8?B?YXFnbXlLM3VvaWJ3ZXhudStQT1ZTcDZaVC93NGs2TGJnaE5VNUVUaU8vZDRU?=
 =?utf-8?B?eTJMb1d2WEFFY0tCOXoxMlRTZkQ3dVNrd1VUVy9hTnlPNzUzQ1hWbUNoWVpm?=
 =?utf-8?B?RkFOSFFoRDB5Y1VpdnI2Y3kwaWsySlU3bVArVXVtQkpJZWI4TDRQREdxWjQ3?=
 =?utf-8?B?V3JLK0FOUEpFNkE4dlQ4RWN3VjlPUjhEUkhDUURaaVVoM2F1SHUzWW1TYVFY?=
 =?utf-8?B?S1pMU0tkcjNCL0pMWTF6RHBCRUpyZXhmSUlZQkxRVHFMUHFKemY1cGQ2NmpX?=
 =?utf-8?B?NEhRYi84NWdiTXMvejRobkM1bUlVb1hNYlo5cTY5Z1B5NWR6c2FUck5ObTc1?=
 =?utf-8?B?blB4NVcvMy8vVUJUdXIxM2NqSmpMZGhMSS9GV1NaRjBmQTdCOGp6bGpuK2hE?=
 =?utf-8?B?UkI0UXhMUERkckN3NEw4TGdIK2VBU3M0ODZtcjJOdmpmQWYxd0hsdFpNQkNO?=
 =?utf-8?B?NFppZUtkckMxV0wzaVFKbUR2c0o0aGpKWkw2MndndDhabmRwblQwRTFHbDZX?=
 =?utf-8?B?OHBZVEUyb2J2MGNWM1VpVUhhNDJJQzVxSlNBVXJQU2UwenVzRFZkampJVG1V?=
 =?utf-8?B?WDRTdUNjQmowM1F6UDc0UndzWFJKdTV6alY4M2ljUDkxTmNwdE8xM25QaWxr?=
 =?utf-8?B?cktmSWZ1Njl4QmN3R2FINk1lK3k0OVlXQkNmR05zTzlDQjhiOXp6eUdYMGRF?=
 =?utf-8?B?Z3RraVdSMnhaUncyWHJubzJTZG9HNXMrdEN2RURpcTZzaFNPbDlzd1ZxUzUr?=
 =?utf-8?B?dk5kT0dMTHAzYnNCdzNxL2NVZlJwME5ySnRad2txU3BSRFUvVTBsU0JWZzg5?=
 =?utf-8?B?U0x0ZXdzRWJoU1VzR0JNdnJwc29zN0ZFclF3cmkxb0g3N2RoV091UzdBcnZX?=
 =?utf-8?B?eDh2SExFbDRWVHhSOFZHSlppUjdTa2JiL050bXdwRE03Y2xXNmtQNDBQNDZ2?=
 =?utf-8?B?eGV2THZydHlWdDZEbnZaYi84Q0I4K1hSVTQzenF1TFFQNTZwdmVUd1hZbE1o?=
 =?utf-8?B?ZkpFNVpQSkhONFMyS1dMdDJublhmY1J3OWl0RVh6djY3UmhUOHo3dDBjczJP?=
 =?utf-8?B?RkRYUXpGT1lhV3RpTlpMQ0tEYzZFZDB1dHRlVDBqcnhrSjVQL3ZsWllxQVJV?=
 =?utf-8?B?dDlDejVBcFE1YTI3LzFVRTJoTUZiL0dwNXh4QjkrOTExblFCclZaWHFMWWds?=
 =?utf-8?B?bG4vb3BCUTBXTGd4UThuaEttbkJjdE9NZHdQVE4rdGFUQTZLMm9LWDhDQ1Uz?=
 =?utf-8?B?WUdieFVDQk5ibjdQZjNCVVcrdExlM09sYmpUQzNtZjVOQkNabkJEVzROa0Ir?=
 =?utf-8?B?MTdUVGt4MDlVUStOVUp1SzBhRzFiR25JRWFsZEJTak1idzNUT2pKZzJqb1dT?=
 =?utf-8?B?Y2xoUDIwbE5aQnUvSGc3N1I0Q1JsVG1uYnNnV0g3OEVBRDJ0NHZQUHRXcTlF?=
 =?utf-8?B?NFlIaEJhZVNsSGdpY3ZQZmVhK0dFL2Z5V2kxWmlDMGlKQlRqbEtEZmR2cGpX?=
 =?utf-8?B?eE5pc1ZvY2lTNTRnWm4xeUUvUW1aN0NWT2lRR0t4VTVrUlgzcVZUcjNMQnAr?=
 =?utf-8?B?SHZvazNpNU1RUk1CNDAvQVk4MGJDbEwwR01TNmhyUjJPbTR6KzdITXRPMTUr?=
 =?utf-8?B?M3JueTBHOUlrd2tBTWtNcGxrcjBaOUVtSEdUbGxXTXMyZlhzQWF1K2JkNmdv?=
 =?utf-8?B?TTI1T3g1OHFBSzdUWGpwV2dWaC96ZFlQVEN6NmcyTmdsSlpGWW15VmhFWjJs?=
 =?utf-8?B?VmdVZjQ1bUFLMGZEa1FXNUo0cFg2LzgwQUw3aGxKaG41YnRnUXJyU014TTVO?=
 =?utf-8?B?Q1U2V1NNVUIwN0t0UlpaQ0hlUzhKSWw2T1FBQS9pL05nSkViWStZZUpRTnRo?=
 =?utf-8?B?WGNtdXptR09rWVFFcEJMTUVFRklXTjZQU1FxMnA3WkQzOUg1VC9tdTdidER2?=
 =?utf-8?B?dlJ1ekdzZmZpQXJuTmI4dlQ5Y09LMG9WYWQ1ZHZzd2V4R0FFemY0OWZpa3VX?=
 =?utf-8?Q?yL99cy8WUaIe4ZzsAmFpx1I=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <34DAA42DD29ACD499107D16FCAB86967@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9246b1df-c6c1-4162-8b9f-08dab1d6b2ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 13:34:50.5091
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bXgPpA4PkvWIqtwnzmnE7f1dTwtUqFY5YZBL29j5mWa1TsK794jAuS0QsyZLTLa0nldzYLs5pfVr2nxRLsLbwWWl3ZydNAhw6dhhAlodhC8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR03MB8008
X-Proofpoint-ORIG-GUID: P6tsOpR5KK-lhLCam2hBAF_C4VsXp8CM
X-Proofpoint-GUID: P6tsOpR5KK-lhLCam2hBAF_C4VsXp8CM
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_08,2022-10-19_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 adultscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210190076

DQpPbiAxNy4xMC4yMiAyMzozOSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gT24gU2F0LCAxNSBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3Jv
dGU6DQo+PiBPbiAxMy4xMC4yMiAwMzozMywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4N
Cj4+IEhlbGxvIFN0ZWZhbm8NCj4+DQo+Pj4gT24gV2VkLCAxMiBPY3QgMjAyMiwgT2xla3NhbmRy
IFR5c2hjaGVua28gd3JvdGU6DQo+Pj4+PiBPbiBUaHUsIDYgT2N0IDIwMjIsIE9sZWtzYW5kciBU
eXNoY2hlbmtvIHdyb3RlOg0KPj4+Pj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVr
c2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+Pg0KPj4+Pj4+IFVzZSB0aGUgc2FtZSAi
eGVuLWdyYW50LWRtYSIgZGV2aWNlIGNvbmNlcHQgKGJhc2VkIG9uIGdlbmVyaWMgSU9NTVUNCj4+
Pj4+PiBkZXZpY2UtdHJlZSBiaW5kaW5ncykgZm9yIHRoZSBQQ0kgZGV2aWNlcyBiZWhpbmQgZGV2
aWNlLXRyZWUgYmFzZWQNCj4+Pj4+PiBQQ0kgSG9zdCBjb250cm9sbGVyLg0KPj4+Pj4+DQo+Pj4+
Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hl
bmtvQGVwYW0uY29tPg0KPj4+Pj4+IC0tLQ0KPj4+Pj4+IFNsaWdodGx5IFJGQy4gVGhpcyBpcyBu
ZWVkZWQgdG8gc3VwcG9ydCBYZW4gZ3JhbnQgbWFwcGluZ3MgZm9yIHZpcnRpby1wY2kgZGV2aWNl
cw0KPj4+Pj4+IG9uIEFybSBhdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUuIFRoZSBYZW4gdG9v
bHN0YWNrIHNpZGUgaXMgbm90IHB1Ymxpc2hlZCB5ZXQuDQo+Pj4+Pj4gSGVyZSwgZm9yIFBDSSBk
ZXZpY2VzIHdlIHVzZSB0aGUgc2FtZSB3YXkgdG8gcGFzcyBiYWNrZW5kIGRvbWlkIHRvIHRoZSBn
dWVzdCBhcyBmb3INCj4+Pj4+PiBwbGF0Zm9ybSBkZXZpY2VzLg0KPj4+Pj4+DQo+Pj4+Pj4gRGVw
ZW5kcyBvbiBKdWVyZ2VuJ3Mgc2VyaWVzOg0KPj4+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20v
djMvX19odHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDYwNzE1MDAuMTU2
ODktMS1qZ3Jvc3NAc3VzZS5jb20vX187ISFHRl8yOWRiY1FJVUJQQSF3YU9rMkdvYzdxbGhObzUt
Y3NST2JyeWlsX0d6TUZfZTYxRUpSNTAxb0owOGNIMmRuSnVsc1pYV2xlbEJEVEJxYTYzVFZvVWNX
UVRCNU5lY0oxcDR4Rk5naDJfRXVBJCAgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pj4+Pj4gLS0t
DQo+Pj4+Pj4gICAgIGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyB8IDUxICsrKysrKysrKysr
KysrKysrKysrKysrKysrKysrLS0tLS0tLS0NCj4+Pj4+PiAgICAgMSBmaWxlIGNoYW5nZWQsIDQx
IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQ0KPj4+Pj4+DQo+Pj4+Pj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1v
cHMuYw0KPj4+Pj4+IGluZGV4IGZmOWJlM2FmZjg3ZS4uNzlkMTMxMjJlYzA4IDEwMDY0NA0KPj4+
Pj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4+ICsrKyBiL2RyaXZl
cnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4+IEBAIC0xMCw2ICsxMCw3IEBADQo+Pj4+Pj4g
ICAgICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4NCj4+Pj4+PiAgICAgI2luY2x1ZGUgPGxpbnV4
L2RtYS1tYXAtb3BzLmg+DQo+Pj4+Pj4gICAgICNpbmNsdWRlIDxsaW51eC9vZi5oPg0KPj4+Pj4+
ICsjaW5jbHVkZSA8bGludXgvcGNpLmg+DQo+Pj4+Pj4gICAgICNpbmNsdWRlIDxsaW51eC9wZm4u
aD4NCj4+Pj4+PiAgICAgI2luY2x1ZGUgPGxpbnV4L3hhcnJheS5oPg0KPj4+Pj4+ICAgICAjaW5j
bHVkZSA8bGludXgvdmlydGlvX2FuY2hvci5oPg0KPj4+Pj4+IEBAIC0yNzMsMTIgKzI3NCwyOCBA
QCBzdGF0aWMgY29uc3Qgc3RydWN0IGRtYV9tYXBfb3BzIHhlbl9ncmFudF9kbWFfb3BzID0gew0K
Pj4+Pj4+ICAgICAJLmRtYV9zdXBwb3J0ZWQgPSB4ZW5fZ3JhbnRfZG1hX3N1cHBvcnRlZCwNCj4+
Pj4+PiAgICAgfTsNCj4+Pj4+PiAgICAgDQo+Pj4+Pj4gLXN0YXRpYyBib29sIHhlbl9pc19kdF9n
cmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4+PiArc3RhdGljIHN0cnVj
dCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4+
PiArew0KPj4+Pj4+ICsJaWYgKGRldl9pc19wY2koZGV2KSkgew0KPj4+Pj4+ICsJCXN0cnVjdCBw
Y2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPj4+Pj4+ICsJCXN0cnVjdCBwY2lfYnVz
ICpidXMgPSBwZGV2LT5idXM7DQo+Pj4+Pj4gKw0KPj4+Pj4+ICsJCS8qIFdhbGsgdXAgdG8gdGhl
IHJvb3QgYnVzIHRvIGxvb2sgZm9yIFBDSSBIb3N0IGNvbnRyb2xsZXIgKi8NCj4+Pj4+PiArCQl3
aGlsZSAoIXBjaV9pc19yb290X2J1cyhidXMpKQ0KPj4+Pj4+ICsJCQlidXMgPSBidXMtPnBhcmVu
dDsNCj4+Pj4+PiArDQo+Pj4+Pj4gKwkJcmV0dXJuIG9mX25vZGVfZ2V0KGJ1cy0+YnJpZGdlLT5w
YXJlbnQtPm9mX25vZGUpOw0KPj4+Pj4+ICsJfQ0KPj4+Pj4gSXMgaXQgcG9zc2libGUgdG8gaGF2
ZSBtdWx0aXBsZSB2aXJ0aW8gZGV2aWNlcyB1bmRlciBhIHNpbmdsZSB2aXJ0aW8tcGNpDQo+Pj4+
PiByb290IGNvbXBsZXg/DQo+Pj4+IHllcw0KPj4+Pg0KPj4+Pg0KPj4+Pj4gV2hhdCBpZiB2aXJ0
aW8tbmV0IGhhcyB0aGUgYmFja2VuZCBpbiBkb20wIGFuZA0KPj4+Pj4gdmlydGlvLWJsb2NrIGhh
cyB0aGUgYmFja2VuZCBpbiBkb20xPw0KPj4+Pj4NCj4+Pj4+IE9yIGVhY2ggdmlydGlvIFBDSSBk
ZXZpY2Ugc2hvd3MgdXAgdW5kZXIgYSBkaWZmZXJlbnQgUENJIHJvb3QgY29tcGxleD8NCj4+Pj4g
R29vZCBxdWVzdGlvbnMuIFRvIGJlIGhvbmVzdCwgaXQgaXMgbm90IDEwMCUgY2xlYXIgdG8gbWUg
eWV0IGhvdyBpdCBpcw0KPj4+PiBzdXBwb3NlZCB0byBiZS4gQnV0IGxldCdzIGd1ZXNzLi4uDQo+
Pj4+DQo+Pj4+IEkgdGhpbmsgdGhhdCBoYXZpbmcgYSBQQ0kgSG9zdCBicmlkZ2UgcGVyIHZpcnRp
by1wY2kgZGV2aWNlIGlzIG92ZXJraWxsLg0KPj4+Pg0KPj4+PiBTbywgSSBzZWUgdHdvIG9wdGlv
bnMgaGVyZToNCj4+Pj4gMS4gV2UgcHJvdmlkZSBQQ0kgSG9zdCBicmlkZ2UgcGVyIGJhY2tlbmRz
IGRvbWFpbiB0byB0aGUgZ3Vlc3QsIHNvIGVhY2gNCj4+Pj4gUENJIEhvc3QgYnJpZGdlIGNvdmVy
cyBvbmx5IHZpcnRpby1wY2kgZGV2aWNlcyB3aG9zZSBiYWNrZW5kcyBhcmUNCj4+Pj4gcnVubmlu
ZyB3aXRoaW4gKnRoZSBzYW1lKiBkb21haW4uDQo+Pj4+IFdpdGggdGhhdCB3ZSB3b3VsZCBiZSBh
YmxlIHRvIHVzZSBwcm9wZXJ0eSBhdCBQQ0kgSG9zdCBicmlkZ2UgbGV2ZWwuDQo+Pj4+DQo+Pj4+
IDIuIFdlIHByb3ZpZGUgb25seSBhIHNpbmdsZSBQQ0kgSG9zdCBicmlkZ2UgdG8gdGhlIGd1ZXN0
LCBzbyB0aGF0IHNpbmdsZQ0KPj4+PiBQQ0kgSG9zdCBicmlkZ2UgY292ZXJzIGFsbCB2aXJ0aW8t
cGNpIGRldmljZXMgYXNzaWduZWQgdG8gdGhpcyBndWVzdC4NCj4+Pj4gTm8gbWF0dGVyIHdoZXJl
IHRoZSBjb3JyZXNwb25kaW5nIGJhY2tlbmRzIGFyZSBydW5uaW5nICh0aGUNCj4+Pj4gdmlydGlv
LWRldmljZXMgdW5kZXIgdGhhdCBQQ0kgSG9zdCBicmlkZ2UgY2FuIGhhdmUgdGhlIGJhY2tlbmRz
IGluDQo+Pj4+IGRpZmZlcmVudCBkb21haW5zKS4NCj4+Pj4gV2l0aCB0aGF0IHdlIHdvdWxkbuKA
mXQgYmUgYWJsZSB0byB1c2UgcHJvcGVydHkgYXQgUENJIEhvc3QgYnJpZGdlIGxldmVsLg0KPj4+
PiBBbmQgd2UgbmVlZCBhIG1vcmUgZmxleGlibGUgb3B0aW9uKHMpIHRvIGJlIGFibGUgZGlzdGlu
Z3Vpc2ggYmV0d2Vlbg0KPj4+PiB2aXJ0aW8tcGNpIGRldmljZXMuDQo+Pj4+DQo+Pj4+IFRha2lu
ZyBpbnRvIGFjY291bnQgdGhhdCBmb3IgdmlydGlvLXBjaSBvbiBBcm0gd2UgbmVlZCB0byBlbXVs
YXRlIGENCj4+Pj4gc3BlY2lmaWMgUENJIEhvc3QgYnJpZGdlIGluIFhlbiB0byBpbnRlcmNlcHQg
dGhlIGd1ZXN0IFBDSSBjb25maWcgc3BhY2UNCj4+Pj4gYWNjZXNzZXMNCj4+Pj4gKGRldGVjdCB3
aGF0IFBDSSBkZXZpY2UgaXMgdGFyZ2V0ZWQpIGFuZCBmb3J3YXJkIHRoZW0gdG8gdGhlIGFwcHJv
cHJpYXRlDQo+Pj4+IGJhY2tlbmQgKElPUkVRIFNlcnZlciksDQo+Pj4+IGl0IGZlZWxzIHRvIG1l
IHRoYXQgd2UgbGlrZWx5IG5lZWQgdG8gZ28gd2l0aCB0aGUgc2Vjb25kIG9wdGlvbiBoZXJlDQo+
Pj4+IChvbmUgUENJIGhvc3QgYnJpZGdlIHBlciBndWVzdCksIEkgbWF5IG1pc3Rha2UsDQo+Pj4+
IGJ1dCBJIGRvbuKAmXQgdGhpbmsgdGhhdCB3ZSB3YW50IHRvIGVtdWxhdGUgc2V2ZXJhbCBQQ0kg
SG9zdCBicmlkZ2VzIGZvciBhDQo+Pj4+IHNpbmdsZSBndWVzdCAobW9yZSBjb2RlLCBtb3JlIHJl
c291cmNlcywgZXRjKS4NCj4+Pj4NCj4+Pj4NCj4+Pj4NCj4+Pj4+IElmIHdlIGNhbiBoYXZlIG11
bHRpcGxlIHZpcnRpbyBQQ0kgZGV2aWNlcyB1bmRlciBhIHNpbmdsZSBQQ0kgcm9vdA0KPj4+Pj4g
Y29tcGxleCwgdGhlbiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBjaGVjayBmb3IgYSBw
ZXItZGV2aWNlDQo+Pj4+PiBwcm9wZXJ0eSwgcmF0aGVyIHRoYW4gYSBzaW5nbGUgcHJvcGVydHkg
YXQgdGhlIFBDSSByb290IGNvbXBsZXggbGV2ZWwuDQo+Pj4+IENvbXBsZXRlbHkgYWdyZWUuDQo+
Pj4+DQo+Pj4+DQo+Pj4+PiBUaGUgZmlyc3QgdGhpbmcgdGhhdCBjb21lcyB0byBtaW5kIGlzIHRv
IGRlc2NyaWJlIGVhY2ggUENJIGRldmljZSB1bmRlcg0KPj4+Pj4gdGhlIHJvb3QgY29tcGxleCBp
biBkZXZpY2UgdHJlZS4gQWx0aG91Z2ggaXQgaXMgdW5jb21tb24gKHVzdWFsbHkgb25seQ0KPj4+
Pj4gdGhlIFBDSSByb290IGNvbXBsZXggaXMgZGVzY3JpYmVkIGluIGRldmljZSB0cmVlKSwgaXQg
aXMgcG9zc2libGUgdG8NCj4+Pj4+IGFsc28gZGVzY3JpYmUgaW4gZGV2aWNlIHRyZWUgYWxsIHRo
ZSBpbmRpdmlkdWFsIFBDSSBkZXZpY2VzIHVuZGVyIHRoZQ0KPj4+Pj4gcm9vdCBjb21wbGV4Lg0K
Pj4+Pj4NCj4+Pj4+IEdpdmVuIHRoYXQgdGhlIGRvbVUgZGV2aWNlIHRyZWUgaXMgZ2VuZXJhdGVk
IGJ5IFhlbiBhbmQvb3IgdGhlIFhlbg0KPj4+Pj4gdG9vbHN0YWNrLCBpdCB3b3VsZCBiZSBlYXN5
IHRvIGFycmFuZ2UgZm9yIGl0IHRvIGhhcHBlbi4NCj4+Pj4gVGVjaG5pY2FsbHkgeWVzLiBJZiB3
ZSBkZWNpZGUgdG8gcHJvdmlkZSBvbmx5IGEgc2luZ2xlIFBDSSBIb3N0IGJyaWRnZQ0KPj4+PiB0
byB0aGUgZ3Vlc3QsIHdlIHdpbGwgaGF2ZSBoYXZlIHRvIGRlYWwgd2l0aCB0aGUgdmlydGlvLXBj
aSBkZXZpY2VzIHdpdGgNCj4+Pj4gdmFyaW91cyBiYWNrZW5kX2RvbWlkLA0KPj4+PiBzbyB3ZSBj
YW4gY29uc2lkZXIgdXNpbmcgbW9yZSBmbGV4aWJsZSBwcm9wZXJ0eQ0KPj4+PiDigJxpb21tdS1t
YXDigJ0v4oCdaW9tbXUtbWFwLW1hc2vigJ0gc3BlY2lhbGx5IGludHJvZHVjZWQgZm9yIHN1Y2gg
cHVycG9zZXM6DQo+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL3d3dy5r
ZXJuZWwub3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL3BjaS1p
b21tdS50eHRfXzshIUdGXzI5ZGJjUUlVQlBBITE3RGtfczhjXzVRQ1FEbUxNMUZZcDY5NUx1VU1T
VHJVVjZIUGZSQTlCZ21WejlUUlJEWkJPdXpzZFp3X2M2RzBvZ2t5MVAxMWdxbDlDSEFPc2h1a1dt
djd6V1MwZFEkICBba2VybmVsWy5db3JnXQ0KPj4+PiBJIHRoaW5rLCB3aXRoIHRoYXQgd2Ugd291
bGQgYmUgYWJsZSB0byBkZXNjcmliZSwgaS5lIHRoYXQgdmlydGlvLXBjaQ0KPj4+PiBkZXZpY2Ug
QSBjb25uZWN0cyB0byBzdHJlYW1faWQgKGJhY2tlbmRfZG9taWQpIFggYW5kIHZpcnRpby1wY2kg
ZGV2aWNlIEINCj4+Pj4gdG8gc3RyZWFtX2lkIFksDQo+Pj4+IGFuZCB2aXJ0aW8tcGNpIGRldmlj
ZSBDIHRvIG5vdGhpbmcgKHNvIGlzIG5vdCByZXF1aXJlZCB0byB1c2UgZ3JhbnRzKSwNCj4+Pj4g
dW5sZXNzIEkgbWlzc2VkIHNvbWV0aGluZy4NCj4+Pj4NCj4+Pj4gSSBoYXZlIGxvb2tlZCBhdCBp
dCBhbmQgSSBkb27igJl0IHNlZSBhdCB0aGUgbW9tZW50IHdoeSB0aGUgaWRlYSB3b3VsZG7igJl0
DQo+Pj4+IHdvcmssIGJ1dCBJIGhhdmVu4oCZdCBleHBlcmltZW50ZWQgd2l0aCB0aGF0IHlldCBp
biBzdWNoIGNvbnRleHQuDQo+Pj4gSSB0aGluayBpdCB3b3VsZCB3b3JrIHRvbw0KPj4NCj4+IEkg
aGF2ZSBleHBlcmltZW50ZWQgd2l0aCB0aGF0LCBpdCB3b3Jrcy4gQW5kIEkgaGF2ZSBhbHJlYWR5
IGNyZWF0ZWQgYSBwYXRjaC4NCj4+DQo+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0
cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIxMDE1MTUzNDA5LjkxODc3NS0xLW9s
ZWtzdHlzaEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSF4QkpsRTZmbWJWX1hqVndtMFFC
SUw0WVRDSk9vSHUzMzdtUEVZV085NlFCeW1wOHVOb1FwYXhXWWdxM29SemZWVkEwSU85S3o3N2hl
YklrRHNQWXFHSHVydE1yVk1BJCAgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pg0KPj4NCj4+IFdo
YXQgSSB3YXMgdGhpbmtpbmcgaXMgYWx0aG91Z2ggZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MN
Cj4+ICgieGVuLWdyYW50LWRtYSIpIHdvdWxkbid0IGxpa2VseSBiZSBzdWl0YWJsZSBmb3IgKmZ1
dHVyZSogaG90cGx1ZyBzdXBwb3J0LA0KPj4gaXQgd291bGQgYWxsb3cgdXMgdG8gaGF2ZSB0aGUg
d29ya2luZyBzb2x1dGlvbiBvbiBBcm0gKHdpdGggYSBtaW5pbWFsDQo+PiBjaGFuZ2VzLCBvbmx5
IGRyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBpcyB0b3VjaGVkKQ0KPj4gYXQgbGVhc3QgZm9y
IFBDSSBkZXZpY2VzIHdoaWNoIGFyZSBrbm93biBhdCB0aGUgZG9tYWluIGNyZWF0aW9uIHRpbWUu
IE9mDQo+PiBjb3Vyc2UsIHRoaXMgbmVlZHMgdGhlIHByb3BlciBzdXBwb3J0IGluIHRoZSB0b29s
c3RhY2suDQo+IFllYWgsIGl0IGlzIGhhcmQgdG8gYXJndWUgYWdhaW5zdCB0aGlzLCBhcyB3ZSBk
b24ndCBoYXZlIGEgZ29vZA0KPiBhbHRlcm5hdGl2ZSA6LSkNCj4NCj4NCj4+Pj4+IFRoYXQgd291
bGQgc29sdmUgdGhlIGlzc3VlIGFzIGZhciBhcyBJIGNhbiB0ZWxsLCBidXQgSSB3b3JyeSBpdCBt
aWdodA0KPj4+Pj4gbm90IGJlIGEgZ29vZCBpZGVhIGJlY2F1c2UgaWYgd2UgcmVseSBvbiB0aGUg
cGVyLWRldmljZSBkZXZpY2UgdHJlZSBub2RlDQo+Pj4+PiB0byBiZSBwcmVzZW50IHRoZW4gaXQg
YmVjb21lcyBoYXJkZXIgdG8gaW1wbGVtZW50IHZpcnRpbyBob3RwbHVnDQo+Pj4+PiAoVmlydGlv
IGhvdHBsdWcgaXMgaW1wb3J0YW50IHRvIGFkZCBkb20wbGVzcyBzdXBwb3J0LikNCj4+Pj4+DQo+
Pj4+PiBMZXQncyBzYXkgdGhhdCB3ZSBjcmVhdGUgYSBkb20wbGVzcyBkb21VIHdpdGggYW4gZW11
bGF0ZWQgUENJIHJvb3QNCj4+Pj4+IGNvbXBsZXggd2l0aG91dCBhbnkgZGV2aWNlcyB1bmRlciBp
dCwgdGhlbiBhZnRlciBEb20wIGlzIGZ1bGx5IGJvb3RlZCwNCj4+Pj4+IHdlIGFkZCBhIHZpcnRp
by1uZXQgZW11bGF0ZWQgZGV2aWNlLiBIb3cgZG8gd2UgdGVsbCB0aGUgZ3Vlc3Qgd2hhdCBpcw0K
Pj4+Pj4gdGhlIGJhY2tlbmQgZG9tYWluIGlkPw0KPj4+Pj4NCj4+Pj4+IERldmljZSB0cmVlIGFu
ZCBvdGhlciBmaXJtd2FyZSB0YWJsZXMgYXJlIG5vdCByZWxldmFudCBhbnltb3JlLg0KPj4+Pj4N
Cj4+Pj4+IFdlIGNvdWxkIHJldXNlIGEgUENJIGNvbmZpZyBzcGFjZSByZWdpc3RlciB0byBleHBv
c2UgdGhlIGJhY2tlbmQgaWQuDQo+Pj4+PiBIb3dldmVyIHRoaXMgc29sdXRpb24gcmVxdWlyZXMg
YSBiYWNrZW5kIGNoYW5nZSAoUUVNVSkgdG8gZXhwb3NlIHRoZQ0KPj4+Pj4gYmFja2VuZCBpZCB2
aWEgYW4gZW11bGF0ZWQgcmVnaXN0ZXIgZm9yIGVhY2ggZW11bGF0ZWQgZGV2aWNlLg0KPj4+Pj4N
Cj4+Pj4+IFRvIGF2b2lkIGhhdmluZyB0byBpbnRyb2R1Y2UgYSBzcGVjaWFsIGNvbmZpZyBzcGFj
ZSByZWdpc3RlciBpbiBhbGwNCj4+Pj4+IGVtdWxhdGVkIFBDSSBkZXZpY2VzICh2aXJ0aW8tbmV0
LCB2aXJ0aW8tYmxvY2ssIGV0YykgSSB3b25kZXIgaWYgd2UNCj4+Pj4+IGNvdWxkIGFkZCBhIHNw
ZWNpYWwgUENJIGNvbmZpZyBzcGFjZSByZWdpc3RlciBhdCB0aGUgZW11bGF0ZWQgUENJIFJvb3QN
Cj4+Pj4+IENvbXBsZXggbGV2ZWwuDQo+Pj4+Pg0KPj4+Pj4gQmFzaWNhbGx5IHRoZSB3b3JrZmxv
dyB3b3VsZCBiZSBhcyBmb2xsb3c6DQo+Pj4+Pg0KPj4+Pj4gLSBMaW51eCByZWNvZ25pemVzIHRo
ZSBQQ0kgUm9vdCBDb21wbGV4IGFzIGEgWGVuIFBDSSBSb290IENvbXBsZXgNCj4+Pj4+IC0gTGlu
dXggd3JpdGVzIHRvIHNwZWNpYWwgUENJIGNvbmZpZyBzcGFjZSByZWdpc3RlciBvZiB0aGUgWGVu
IFBDSSBSb290DQo+Pj4+PiAgICAgIENvbXBsZXggdGhlIFBDSSBkZXZpY2UgaWQgKGJhc2ljYWxs
eSB0aGUgQkRGKQ0KPj4+Pj4gLSBUaGUgWGVuIFBDSSBSb290IENvbXBsZXggZW11bGF0ZWQgYnkg
WGVuIGFuc3dlcnMgYnkgd3JpdGluZyBiYWNrIHRvDQo+Pj4+PiAgICAgIHRoZSBzYW1lIGxvY2F0
aW9uIHRoZSBiYWNrZW5kIGlkIChkb21pZCBvZiB0aGUgYmFja2VuZCkNCj4+Pj4+IC0gTGludXgg
cmVhZHMgYmFjayB0aGUgc2FtZSBQQ0kgY29uZmlnIHNwYWNlIHJlZ2lzdGVyIG9mIHRoZSBYZW4g
UENJDQo+Pj4+PiAgICAgIFJvb3QgQ29tcGxleCBhbmQgbGVhcm4gdGhlIHJlbGV2YW50IGRvbWlk
DQo+Pj4+Pg0KPj4+Pj4gV2hhdCBkbyB5b3UgdGhpbms/DQo+Pj4+IEkgdGhpbmsgdGhlIGlkZWEg
c291bmRzIGluZGVlZCBpbnRlcmVzdGluZyBhbmQgd291bGQgcHJvYmFibHkgd29yaywgYnV0DQo+
Pj4+IHdvdWxkIHJlcXVpcmUgZ3Vlc3QgbW9kaWZpY2F0aW9ucyBvdGhlciB0aGFuIGp1c3QgaW4g
ZHJpdmVycy94ZW4gKGFuZA0KPj4+PiBsaWtlbHkgdGhlIHNwZWNpZmljYXRpb24gY2hhbmdlcyBh
cyB3ZWxsKS4NCj4+Pj4gV2hpY2ggaWRlYWxseSBvZiBjb3Vyc2Ugc2hvdWxkIGJlIGF2b2lkZWQu
DQo+Pj4+IEFsc28gSSB3YXMgdGhpbmtpbmcgaXQgd291bGQgYmUgbmljZSBub3QgdG8gZGl2ZXJn
ZSBtdWNoIGJldHdlZW4NCj4+Pj4gY29tbXVuaWNhdGluZyB0aGUgYmFja2VuZF9kb21pZCBmb3Ig
cGxhdGZvcm0gYW5kIFBDSSBkZXZpY2VzIG9uIEFybSB3aXRoDQo+Pj4+IGRldmljZSB0cmVlLg0K
Pj4+Pg0KPj4+PiBJZiB3ZSBtYW5hZ2VkIHRvIHJlLXVzZSBnZW5lcmljIElPTU1VIGRldmljZS10
cmVlIGJpbmRpbmdzIGZvcg0KPj4+PiB2aXJ0aW8tbW1pbywgd2Ugd291bGQgbGlrZWx5IGJlIGFi
bGUgdG8gcmUtdXNlIFBDSS1JT01NVSBkZXZpY2UtdHJlZQ0KPj4+PiBiaW5kaW5ncyBmb3Igdmly
dGlvLXBjaSwNCj4+Pj4gYXQgbGVhc3QgZm9yIGJvb3QgUENJIGRldmljZXMgKHdoaWNoIGFyZSBr
bm93biBhdCB0aGUgZG9tYWluIGNyZWF0aW9uIHRpbWUpLg0KPj4+PiBUaGUgbW9yZSwgdGhlIGJp
bmRpbmdzIGlzIGFscmVhZHkgcHJlc2VudDoNCj4+Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92
My9fX2h0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZh
bGRzL2xpbnV4LmdpdC90cmVlL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9pb21t
dS94ZW4sZ3JhbnQtZG1hLnlhbWxfXzshIUdGXzI5ZGJjUUlVQlBBITE3RGtfczhjXzVRQ1FEbUxN
MUZZcDY5NUx1VU1TVHJVVjZIUGZSQTlCZ21WejlUUlJEWkJPdXpzZFp3X2M2RzBvZ2t5MVAxMWdx
bDlDSEFPc2h1a1dtdnBmRjhHbUEkICBbZ2l0Wy5da2VybmVsWy5db3JnXQ0KPj4+IEkgdGhpbmsg
dXNpbmcgYSBzcGVjaWFsIGNvbmZpZyBzcGFjZSByZWdpc3RlciBpbiB0aGUgcm9vdCBjb21wbGV4
IHdvdWxkDQo+Pj4gbm90IGJlIHRlcnJpYmxlIGluIHRlcm1zIG9mIGd1ZXN0IGNoYW5nZXMgYmVj
YXVzZSBpdCBpcyBlYXN5IHRvDQo+Pj4gaW50cm9kdWNlIGEgbmV3IHJvb3QgY29tcGxleCBkcml2
ZXIgaW4gTGludXggYW5kIG90aGVyIE9TZXMuIFRoZSByb290DQo+Pj4gY29tcGxleCB3b3VsZCBz
dGlsbCBiZSBFQ0FNIGNvbXBhdGlibGUgc28gdGhlIHJlZ3VsYXIgRUNBTSBkcml2ZXIgd291bGQN
Cj4+PiBzdGlsbCB3b3JrLiBBIG5ldyBkcml2ZXIgd291bGQgb25seSBiZSBuZWNlc3NhcnkgaWYg
eW91IHdhbnQgdG8gYmUgYWJsZQ0KPj4+IHRvIGFjY2VzcyB0aGUgc3BlY2lhbCBjb25maWcgc3Bh
Y2UgcmVnaXN0ZXIuDQo+Pg0KPj4gVGhpcyBuZWVkcyBhbiBhZGRpdGlvbmFsIGludmVzdGlnYXRp
b24uDQo+Pg0KPj4NCj4+PiBUaGF0IHNhaWQsIGZvciBzdXJlIHRoZSBmZXdlciBjaGFuZ2VzIHRv
IHRoZSBndWVzdCB0aGUgYmV0dGVyIGFuZCBJIGxpa2UNCj4+PiB0aGUgZXhpc3RpbmcgeGVuLGdy
YW50LWRtYSBiaW5kaW5nLg0KPj4+DQo+Pj4NCj4+Pj4gUmVnYXJkaW5nIHRoZSBob3RwbHVnIGRl
dmljZXMsIHllcyBpdCBpcyBhIHZhbGlkIHVzZS1jYXNlIHdoaWNoIHNob3VsZA0KPj4+PiBiZSBh
bHNvIHN1cHBvcnRlZCB3aXRoIHZpcnRpby1wY2ksIEkgYXNzdW1lIHRoZSBYZW5zdG9yZSBjb3Vs
ZCBiZQ0KPj4+PiByZS11c2VkIGZvciB0aGF0IHB1cnBvc2UgaWYgaXQgd291bGQgYmUgYXZhaWxh
YmxlLg0KPj4+PiBUaGUgWGVuc3RvcmUgaXMgYXZhaWxhYmxlIHdpdGggdGhlIHVzdWFsIERvbTAg
YW5kIHRvb2xzdGFjaywgaXMgaXQNCj4+Pj4gYXZhaWxhYmxlIHdpdGggZG9tMGxlc3M/DQo+Pj4g
WGVuc3RvcmUgaXMgYXZhaWxhYmxlIGZvciBkb20wbGVzcyBpZiB3ZSBoYXZlIGEgZG9tMCBydW5u
aW5nIHdpdGgNCj4+PiB4ZW5zdG9yZWQgYXMgb25lIG9mIHRoZSBkb20wbGVzcyBkb21haW5zLiBX
ZSBjdXJyZW50bHkgcmVseSBvbiBpdCBmb3INCj4+PiBYZW4gUFYgZHJpdmVycyB3aXRoIGRvbTBs
ZXNzLiAgQWZ0ZXIgZG9tMCBpcyBmdWxseSBib290ZWQsIHdlIHVzZSAieGwNCj4+PiBuZXR3b3Jr
LWF0dGFjaCIgdG8gY3JlYXRlIGEgdmlmIGludGVyZmFjZSBkeW5hbWljYWxseSBpbiB0aGUgZG9t
VS4NCj4+Pg0KPj4+IFRoYXQgaXMgd2h5IEkgd2FzIHRoaW5raW5nIG9mIHVzaW5nIHZpcnRpbyBo
b3RwbHVnIHRvIHNvbHZlIHRoZSBzYW1lDQo+Pj4gcHJvYmxlbSB3aXRoIHZpcnRpbywgSSB3YXMg
aW1hZ2luaW5nIHRoYXQgYWZ0ZXIgZG9tMCBpcyBmdWxseSBib290ZWQgd2UNCj4+PiB3b3VsZCBk
byAieGwgdmlydGlvLWF0dGFjaCIgYW5kIGNyZWF0ZSBhIG5ldyB2aXJ0aW8gaW50ZXJmYWNlIGlu
IHRoZQ0KPj4+IGRvbVUuIEJ1dCBJIGNhbm5vdCBzZWUgYW4gZWFzeSB3YXkgdG8gbWFrZSB2aXJ0
aW8gaG90cGx1ZyB3b3JrIHRvZ2V0aGVyDQo+Pj4gd2l0aCB0aGUgeGVuLGdyYW50LWRtYSBiaW5k
aW5ncy4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgaWYgd2UgZmluZCBhDQo+Pj4gd2F5IHRv
IG1ha2UgaXQgd29yayB3aXRob3V0IHhlbnN0b3JlIChiZWNhdXNlIHhlbnN0b3JlIHdvdWxkIGJl
IGENCj4+PiBzYWZldHktY2VydGlmaWNhdGlvbiBkZXBlbmRlbmN5KS4NCj4+IEkgZ290IHlvdXIg
Y29uY2VybiByZWdhcmRpbmcgdGhlIHVzYWdlIG9mIHhlbnN0b3JlIGluIGdlbmVyYWwuDQo+PiBB
bHNvIEkgZ290IHRoYXQgaG90cGx1ZyBpcyB0aGUgb25seSB3YXkgdG8gZ2V0IHZpcnR1YWwgZGV2
aWNlcyAoZWl0aGVyDQo+PiBQViBvciB2aXJ0aW8pIHdvcmtpbmcgZm9yIHRoZSBkb20wbGVzcyBz
eXN0ZW0sIGlzIG15IHVuZGVyc3RhbmRpbmcgY29ycmVjdD8NCj4gSW4gYSBkb20wbGVzcyBzeXN0
ZW0gZG9tYWlucyBib290IGluIHBhcmFsbGVsLiBUaGUgYmFja2VuZCBpcyB0eXBpY2FsbHkNCj4g
aW4gYSBsYXJnZXIgYW5kIHNsb3dlciBkb21haW4gdG8gYm9vdCAoTGludXgpLiBTbyB0byBzb2x2
ZSB0aGUgcHJvYmxlbQ0KPiB3aXRoIFhlbiBQViBkcml2ZXJzLCB3ZSBob3RwbHVnIFhlbiBQViBk
ZXZpY2VzIGFmdGVyIGRvbTAgaXMgYm9vdGVkICgieGwNCj4gbmV0d29yay1hdHRhY2giIGZvciBp
bnN0YW5jZSkuDQo+DQo+IFdpdGggdmlydGlvLCB3ZSBjb3VsZCBlaXRoZXIgZG8gdGhlIHNhbWUg
KHVzZSB2aXJ0aW8gaG90cGx1Zykgb3IgZmluZCBhDQo+IHdheSB0byB0ZWxsIHRoZSBmcm9udGVu
ZCB0byBkZWxheSBpbml0aWFsaXphdGlvbi4gVGhlIHBvaW50IGlzIHRoYXQgd2UNCj4gZG9uJ3Qg
d2FudCB0byBmcm9udGVuZCB0byB0cnkgdG8gYWNjZXNzIGJhY2tlbmQgcmVzb3VyY2VzIGJlZm9y
ZSB0aGUNCj4gYmFja2VuZCBpcyB1cCBhbmQgcnVubmluZy4NCg0KDQpOb3cgSSBnb3QgdGhlIHBy
b2JsZW0uIFRoYW5rIHlvdSBmb3IgdGhlIGV4cGxhbmF0aW9uLg0KDQoNCj4NCj4NCj4+IFRoZSB2
aXJ0aW8gaG90cGx1ZyBjb3VsZCAqcHJvYmFibHkqIHdvcmsgdG9nZXRoZXIgd2l0aCB0aGUNCj4+
ICJ4ZW4sZ3JhbnQtZG1hIiBiaW5kaW5ncyB3aXRoIHNvbWUgcHJlcmVxdWlzaXRlcyAoYmFja2Vu
ZCBkb21pZCBzaG91bGQNCj4+IGJlIGtub3duIGluIGFkdmFuY2UpLA0KPj4gYnV0IEkgYW0gbm90
IHF1aXRlIGFzIEkgYW0gbm90IHRvbyBmYW1pbGlhciB3aXRoIGRvbTBsZXNzIGRldGFpbHMuIEJ1
dA0KPj4gYW55d2F5LCBJIHdpbGwgdHJ5IHRvIGRlc2NyaWJlIGl0Li4uDQo+Pg0KPj4gQXMgZmFy
IGFzIEkga25vdyB0aGUgZG9tMGxlc3MgRG9tVXMgYXJlIGNvbmZpZ3VyZWQgZnJvbSB0aGUgZGV2
aWNlLXRyZWUuDQo+PiBTbyB0aGUgY29uZmlndXJhdGlvbiBpcyBrbm93biBhbmQgcHJlcGFyZWQg
YmVmb3JlaGFuZC4NCj4+IEkgbWF5IGd1ZXNzIHRoYXQgd2Uga25vdyBpbiB3aGF0IERvbVUxIHdl
IGFyZSBnb2luZyB0byBydW4gdGhlIHZpcnRpbw0KPj4gYmFja2VuZHMgYW5kIHdoYXQgUENJIGRl
dmljZXMgd2UgYXJlIGdvaW5nIHRvIGFzc2lnbiB0byBEb21VMi4gU28gd2hlbg0KPj4gWGVuIGdl
bmVyYXRpbmcgZGV2aWNlLXRyZWUNCj4+IGZvciBEb21VMiBpdCBjb3VsZCBjcmVhdGUgcHJvcGVy
IGlvbW11LW1hcCBmb3IgdGhlIFBDSSBIb3N0IGJyaWRnZSBub2RlLg0KPj4gQWx0aG91Z2ggZm9y
IHRoaXMgdG8gd29yayB3ZSB3b3VsZCBuZWVkIGFuIGFiaWxpdHkgdG8gY29uZmlndXJlIGRvbWFp
bg0KPj4gSUQgKGQtPmRvbWFpbl9pZCkgdmlhIGRldmljZS10cmVlDQo+PiBhbmQgbGlrZWx5IHJl
c2VydmUgc29tZSByYW5nZSBvZiBkb21haW4gSURzICh0byBub3QgY3Jvc3Mgd2l0aA0KPj4gbWF4
X2luaXRfZG9taWQpLiBCdXQsIGl0IHdvdWxkbid0IGJlIDEwMCUgaG90cGx1ZyB0aGVuLg0KPiBU
aGF0J3MgZmluZSBpdCBkb2Vzbid0IGhhdmUgdG8gYmUgMTAwJSBob3RwbHVnLiBJbiByZWFsaXR5
LCB0aGlzIGlzIGENCj4gc3RhdGljIGNvbmZpZ3VyYXRpb24gc28gd2Uga25vdyBhbGwgdGhlIGlu
Zm9ybWF0aW9uIGJlZm9yZWhhbmQgKHdoaWNoIFZNDQo+IGlzIHRoZSBiYWNrZW5kLCB3aGljaCBp
cyB0aGUgZnJvbnRlbmQsIHdoaWNoIGRldmljZXMgYXJlDQo+IHNoYXJlZC9lbXVsYXRlZCkuIFRo
ZSBvbmx5IGlzc3VlIGlzIHRoYXQgd2UgbmVlZCBhIHdheSB0byB0ZWxsIFZNMiB0bw0KPiB3YWl0
IGZvciB0aGUgYmFja2VuZCBpbiBWTTEgdG8gY29tZSBvbmxpbmUuIEJ1dCB0aGUgZGV2aWNlIHRy
ZWUgY291bGQNCj4gY29udGFpbiBhbGwgaW5mb3JtYXRpb24gZnJvbSB0aGUgc3RhcnQuDQoNCg0K
Z3JlYXQsIGl0IGlzIGdvb2QgdGhhdCBkZXZpY2UgdHJlZSBjb3VsZCBjb250YWluIGFsbCBpbmZv
cm1hdGlvbiBmcm9tIA0KdGhlIHN0YXJ0LA0KSSB0aGluayB0aGlzIHdpbGwgc2ltcGxpZnkgdGhp
bmdzLg0KDQoNCj4gICANCj4NCj4+PiBNYXliZSB3ZSBuZWVkIHRvIHRoaW5rIG91dHNpZGUgdGhl
IGJveCBhbmQgZmluZCBhbm90aGVyIHNvbHV0aW9uIHRoYXQNCj4+PiBkb2Vzbid0IHJlbHkgb24g
aG90cGx1Zy4NCj4+Pg0KPj4+IEZvciBpbnN0YW5jZSwgbGV0J3Mgc2F5IHRoYXQgd2UgZXhwb3Nl
IHRoZSB2aXJ0aW8gZGV2aWNlcyBpbiBkZXZpY2UgdHJlZQ0KPj4+IGluIGEgZG9tMGxlc3MgY29u
ZmlndXJhdGlvbiB0b28gYnV0IHdpdGggc3RhdHVzID0gImRpc2FibGVkIi4gV2hlbiBkb20wDQo+
Pj4gKG9yIGJhY2tlbmQgZG9tYWluKSBpcyB1cCBhbmQgcnVubmluZyBpdCBjYW4gc2lnbmFsIHRo
YXQgaXQgaXMgcmVhZHkuDQo+Pj4gTWF5YmUgaWYgd2UgaGFkIGEgc3BlY2lhbCBYZW4tc3BlY2lm
aWMgUENJIFJvb3QgQ29tcGxleCBkcml2ZXIgaW4gdGhlDQo+Pj4gZ3Vlc3QsIGl0IGNvdWxkIHdh
aXQgZm9yIHRoZSBYZW4gc2lnbmFsIGFuZCB0aGVuIGNvbnRpbnVlIFBDSSBwcm9iaW5nIGF0DQo+
Pj4gdGhhdCBwb2ludCBob25vcmluZyB4ZW4sZ3JhbnQtZG1hIGJpbmRpbmdzIGlmIHByZXNlbnQg
aW4gZGV2aWNlIHRyZWUNCj4+PiBldmVuIGlmIHRoZSBkZXZpY2VzIGhhZCBzdGF0dXMgPSAiZGlz
YWJsZWQiIGluaXRpYWxseS4NCj4+Pg0KPj4+IEl0IGxvb2tzIGxpa2UgdGhhdCB3b3VsZCByZXF1
aXJlIG1hbnkgZ3Vlc3QgY2hhbmdlcyB1bmZvcnR1bmF0ZWx5Lg0KPj4NCj4+IEl0IGxvb2tzIGxp
a2UgeWVzLCBhbHNvIHlvdSBtZW50aW9uZWQgIml0IGNhbiBzaWduYWwgdGhhdCBpdCBpcyByZWFk
eSIsDQo+PiB0aGUgcXVlc3Rpb24gaXMgYnkgd2hhdCBtZWFucyAoeGVuc3RvcmUgd291bGQgYmUg
YSBnb2QgZml0IGhlcmUuLi4pPw0KPiBNYXliZSB4ZW5zdG9yZSwgeWVzLiBUaGUgcHJvYmxlbSBp
cyB0aGF0IHdlIHdhbnQgc29tZXRoaW5nIHRoYXQgd29ya3MNCj4gd2l0aCBtaW5pbWFsIGRyaXZl
cnMgY2hhbmdlcywgYW5kIHRoZSBwcm9ibGVtIGlzIHRoYXQgaWYgd2UgcHJlc2VudCB0aGUNCj4g
dmlydGlvIGRldmljZXMgaW4gZGV2aWNlIHRyZWUgZnJvbSBib290LCB0aGUgZHJpdmVycyB3aWxs
IHRyeSB0byBwcm9iZQ0KPiB0aGVtIGltbWVkaWF0ZWx5LiBXZSBuZWVkIGEgd2F5IHRvIGRlbGF5
IHRoYXQuDQoNCg0KYWdyZWUNCg0KDQo+DQo+DQo+PiBBbmQgSSBoYXZlbid0IHNlZW4gdGhhdCB2
aXJ0aW8tcGNpIGRldmljZXMgYXJlIGRlc2NyaWJlZCBpbiBkZXZpY2UtdHJlZQ0KPj4gc29tZXdo
ZXJlLCBvbmx5IGdlbmVyaWMgUENJIGhvc3QgYnJpZGdlIG5vZGUNCj4+IGlzIGRlc2NyaWJlZC4g
VGhlIHZpcnRpby1wY2kgZGV2aWNlcyB3aWxsIGJlIGRldGVjdGVkIHRoZSBzYW1lIHdheSBhcw0K
Pj4gdXN1YWwgUENJIGRldmljZXMgZHVyaW5nIGJvb3QuIFVubGVzcyBJIG1pc3NlZCBzb21ldGhp
bmcuDQo+IFllcyBleGFjdGx5LCBhbmQgdGhhdCBpcyB0aGUgcHJvYmxlbS4gSG93IGRvIHdlIG1h
a2UgdGhvc2UgZHJpdmVyICJ3YWl0Ig0KPiBiZWZvcmUgcHJvYmluZy4NCg0KDQpvaywgc28gLi4u
DQoNCg0KPg0KPg0KPj4gUmVnYXJkaW5nIHRoZSB2aXJ0aW8tbW1pbyAocGxhdGZvcm0pIGRldmlj
ZXMsIHllcywgd2UgY291bGQgZXhwb3NlIHRoZW0NCj4+IHdpdGggc3RhdHVzICJkaXNhYmxlZCIs
IGFuZCB0aGV5IHdvbid0IGdldCBwcm9iZWQgYnkgZGVmYXVsdC4NCj4+IFRvIGJlIGhvbmVzdCwg
SSBoYXZlIGV4cGVyaW1lbnRlZCB3aXRoIHRoYXQsIHdoZW4gSSB3YXMgdGhpbmtpbmcgb2YNCj4+
IHBvc3NpYmxlIGhvdHBsdWcgZm9yIHZpcnRpby1tbWlvIGRldmljZXMgKEkga25vdywgdGhpcyBz
b3VuZHMgdW5jb21tb24NCj4+IGFuZCBzdHJhbmdlKS4NCj4+IEkgdXNlZCBMaW51eCBmZWF0dXJl
IChDT05GSUdfT0ZfRFlOQU1JQywgb3ZlcmxheXMpIHRvIHVwZGF0ZSB0aGUNCj4+IGRldmljZS10
cmVlIG9uIHJ1bm5pbmcgZ3Vlc3QsIHNvIHRoZSB0b29sc3RhY2sgaW5pdGlhbGx5IGluc2VydHMN
Cj4+IHZpcnRpby1tbWlvIGRldmljZSBub2RlcyBmb3Igbm9uLWJvb3QgZGV2aWNlcw0KPj4gd2l0
aCBzdGF0dXMgImRpc2FibGVkIiwgYW5kIGF0IHRoZSBydW50aW1lLCBvbmNlIHdlIHJlY2VpdmUg
YW4gZXZlbnQgZm9yDQo+PiBleGFtcGxlLCB3ZSBjaGFuZ2UgdGhlIHN0YXR1cyB0byAib2siIGFu
ZCB0aGUgY29ycmVzcG9uZGluZyB2aXJ0aW8tbW1pbw0KPj4gZGV2aWNlIGdldHMgcHJvYmVkLg0K
Pj4gQnV0IGFnYWluLCBpdCBpcyBub3QgYSAxMDAlIGhvdHBsdWcsIGFzIHdlIG5lZWQgdG8gcHJl
LWFsbG9jYXRlIG1lbW9yeQ0KPj4gcmFuZ2UgYW5kIGludGVycnVwdCBpbiBhZHZhbmNlICh3aGVu
IGdlbmVyYXRpbmcgZ3Vlc3QgZGV2aWNlIHRyZWUpLg0KPiBBY3R1YWxseSB0aGlzIGlzIHJlYWxs
eSBjb29sISBEb2VzIGl0IHdvcms/IEl0IGRvZXNuJ3QgbWF0dGVyIHRvIG1lIGlmDQo+IHRoZSB2
aXJ0aW8gZGV2aWNlcyBhcmUgcGNpIG9yIG1taW8gYXMgbG9uZyBhcyB3ZSBjYW4gc29sdmUgdGhl
ICJ3YWl0Ig0KPiBwcm9ibGVtLiBTbyB0aGlzIGNvdWxkIGJlIGEgZ29vZCBzb2x1dGlvbi4NCg0K
DQouLi4geWVzLCBpdCBkb2VzLiBJbml0aWFsbHkgSSBleHBlcmltZW50ZWQgd2l0aCB2aXJ0aW8t
bW1pbyBkZXZpY2VzLCBidXQgDQp0b2RheSBJIHRyaWVkIHdpdGggUENJIGhvc3QgYnJpZGdlIGFz
IHdlbGwuDQpJIHdvbid0IGRlc2NyaWJlIHRoZSBjb21tYW5kcyB3aGljaCBJIHVzZWQgdG8gYXBw
bHkvcmVtb3ZlIGRldmljZS10cmVlIA0Kb3ZlcmxheXMgZnJvbSB0aGUgdXNlcnNwYWNlIGFzIHdl
bGwgYXMgdGhlIGNvbnRleHQgb2YNCmR0c28gZmlsZXMgSSBjcmVhdGVkLCBJIHdpbGwgZGVzY3Jp
YmUgaG93IHRoYXQgY291bGQgYmUgZG9uZSBmcm9tIHRoZSANCmtlcm5lbCBieSB1c2luZyBleGlz
dGluZyBmdW5jdGlvbmFsaXR5IChDT05GSUdfT0ZfRFlOQU1JQykuDQoNCkFzIEkgc2FpZCBpZiB3
ZSBleHBvc2VkIHRoZSBkZXZpY2VzIHdpdGggc3RhdHVzICJkaXNhYmxlZCIsIHRoZXkgDQp3b3Vs
ZG4ndCBnZXQgcHJvYmVkIGJ5IGRlZmF1bHQuIE9uY2Ugd2UgcmVjZWl2ZSBhbiBzaWduYWwNCnRo
YXQgb3RoZXJlbmQgaXMgcmVhZHksIHdlIGNoYW5nZSB0aGUgc3RhdHVzIHRvICJvayIgYW5kIHRo
ZSANCmNvcnJlc3BvbmRpbmcgZGV2aWNlIGdldHMgcHJvYmVkLg0KDQpTbyBiZWxvdyB0aGUgdGVz
dCBwYXRjaCwgd2hpY2gganVzdCBjaGFuZ2UgdGhlIHN0YXR1cyBvZiB0aGUgcmVxdWlyZWQgDQpk
ZXZpY2UtdHJlZSBub2RlIChhcyB5b3UgY2FuIHNlZSB0aGUgY29kZSB0byB1cGRhdGUgdGhlIHBy
b3BlcnR5IGlzIA0Kc2ltcGxlIGVub3VnaCksDQpJIGhhY2tlZCAieGwgc3lzcnEiIGZvciB0aGUg
Y29udmVuaWVuY2Ugb2YgdGVzdGluZy4NCg0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ3Jh
bnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQppbmRleCAwNDVjMTgw
NWIyZDUuLjk2ODNjZTA3NWJjOSAxMDA2NDQNCi0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1v
cHMuYw0KKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQpAQCAtMTAsNiArMTAsNyBA
QA0KIMKgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KIMKgI2luY2x1ZGUgPGxpbnV4L2RtYS1t
YXAtb3BzLmg+DQogwqAjaW5jbHVkZSA8bGludXgvb2YuaD4NCisjaW5jbHVkZSA8bGludXgvb2Zf
cGxhdGZvcm0uaD4NCiDCoCNpbmNsdWRlIDxsaW51eC9wY2kuaD4NCiDCoCNpbmNsdWRlIDxsaW51
eC9wZm4uaD4NCiDCoCNpbmNsdWRlIDxsaW51eC94YXJyYXkuaD4NCkBAIC0zNzksNiArMzgwLDEw
OCBAQCBib29sIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCiDC
oMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQogwqB9DQoNCisvKiBUT0RPOiBDb25zaWRlciB1
c2luZyBzdGF0aWNhbGx5IGFsbG9jYXRlZCAoc3RydWN0IHByb3BlcnR5IHN0YXR1cykgKi8NCitz
dGF0aWMgaW50IHhlbl9ncmFudF9kbWFfZW5hYmxlX2RldmljZShzdHJ1Y3QgZGV2aWNlX25vZGUg
Km5wKQ0KK3sNCivCoMKgwqDCoMKgwqAgc3RydWN0IHByb3BlcnR5ICpzdGF0dXM7DQorDQorwqDC
oMKgwqDCoMKgIHN0YXR1cyA9IGt6YWxsb2Moc2l6ZW9mKCpzdGF0dXMpLCBHRlBfS0VSTkVMKTsN
CivCoMKgwqDCoMKgwqAgaWYgKCFzdGF0dXMpDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCByZXR1cm4gLUVOT01FTTsNCisNCivCoMKgwqDCoMKgwqAgc3RhdHVzLT5uYW1lID0ga3N0cmR1
cCgic3RhdHVzIiwgR0ZQX0tFUk5FTCk7DQorwqDCoMKgwqDCoMKgIGlmICghc3RhdHVzLT5uYW1l
KQ0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07DQorDQorwqDC
oMKgwqDCoMKgIHN0YXR1cy0+dmFsdWUgPSBrc3RyZHVwKCJva2F5IiwgR0ZQX0tFUk5FTCk7DQor
wqDCoMKgwqDCoMKgIGlmICghc3RhdHVzLT52YWx1ZSkNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIHJldHVybiAtRU5PTUVNOw0KKw0KK8KgwqDCoMKgwqDCoCBzdGF0dXMtPmxlbmd0aCA9
IHNpemVvZigib2theSIpOw0KKw0KK8KgwqDCoMKgwqDCoCByZXR1cm4gb2ZfdXBkYXRlX3Byb3Bl
cnR5KG5wLCBzdGF0dXMpOw0KK30NCisNCitzdGF0aWMgaW50IHhlbl9ncmFudF9kbWFfZGlzYWJs
ZV9kZXZpY2Uoc3RydWN0IGRldmljZV9ub2RlICpucCkNCit7DQorwqDCoMKgwqDCoMKgIHN0cnVj
dCBwcm9wZXJ0eSAqc3RhdHVzOw0KKw0KK8KgwqDCoMKgwqDCoCBzdGF0dXMgPSBremFsbG9jKHNp
emVvZigqc3RhdHVzKSwgR0ZQX0tFUk5FTCk7DQorwqDCoMKgwqDCoMKgIGlmICghc3RhdHVzKQ0K
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07DQorDQorwqDCoMKg
wqDCoMKgIHN0YXR1cy0+bmFtZSA9IGtzdHJkdXAoInN0YXR1cyIsIEdGUF9LRVJORUwpOw0KK8Kg
wqDCoMKgwqDCoCBpZiAoIXN0YXR1cy0+bmFtZSkNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIHJldHVybiAtRU5PTUVNOw0KKw0KK8KgwqDCoMKgwqDCoCBzdGF0dXMtPnZhbHVlID0ga3N0
cmR1cCgiZGlzYWJsZWQiLCBHRlBfS0VSTkVMKTsNCivCoMKgwqDCoMKgwqAgaWYgKCFzdGF0dXMt
PnZhbHVlKQ0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07DQor
DQorwqDCoMKgwqDCoMKgIHN0YXR1cy0+bGVuZ3RoID0gc2l6ZW9mKCJkaXNhYmxlZCIpOw0KKw0K
K8KgwqDCoMKgwqDCoCByZXR1cm4gb2ZfdXBkYXRlX3Byb3BlcnR5KG5wLCBzdGF0dXMpOw0KK30N
CisNCit2b2lkIHhlbl9ncmFudF9kbWFfaGFuZGxlX3N5c3JxKGludCBrZXkpDQorew0KK8KgwqDC
oMKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KK8KgwqDCoMKgwqDCoCBjb25zdCBjaGFy
ICpwYXRoOw0KK8KgwqDCoMKgwqDCoCBib29sIGVuYWJsZTsNCisNCivCoMKgwqDCoMKgwqAgcHJp
bnRrKCIlczogZ290IGtleSAlZFxuIiwgX19mdW5jX18sIGtleSk7DQorDQorwqDCoMKgwqDCoMKg
IHN3aXRjaCAoa2V5KSB7DQorwqDCoMKgwqDCoMKgIGNhc2UgJzAnOg0KK8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgcGF0aCA9ICIvdmlydGlvQDIwMDAwMDAiOw0KK8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgZW5hYmxlID0gdHJ1ZTsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIGJyZWFrOw0KKw0KK8KgwqDCoMKgwqDCoCBjYXNlICcxJzoNCivCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHBhdGggPSAiL3ZpcnRpb0AyMDAwMjAwIjsNCivCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIGVuYWJsZSA9IHRydWU7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBicmVhazsNCisNCivCoMKgwqDCoMKgwqAgY2FzZSAnMic6DQorwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBwYXRoID0gIi92aXJ0aW9AMjAwMDAwMCI7DQorwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBlbmFibGUgPSBmYWxzZTsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IGJyZWFrOw0KKw0KK8KgwqDCoMKgwqDCoCBjYXNlICczJzoNCivCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHBhdGggPSAiL3ZpcnRpb0AyMDAwMjAwIjsNCivCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIGVuYWJsZSA9IGZhbHNlOw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
YnJlYWs7DQorDQorwqDCoMKgwqDCoMKgIGNhc2UgJzQnOg0KK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgcGF0aCA9ICIvcGNpZUAxMDAwMDAwMCI7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBlbmFibGUgPSB0cnVlOw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYnJl
YWs7DQorDQorwqDCoMKgwqDCoMKgIGNhc2UgJzUnOg0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgcGF0aCA9ICIvcGNpZUAxMDAwMDAwMCI7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCBlbmFibGUgPSBmYWxzZTsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFr
Ow0KKw0KK8KgwqDCoMKgwqDCoCBkZWZhdWx0Og0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgcHJpbnRrKCIlczogd3Jvbmcga2V5ICVkXG4iLCBfX2Z1bmNfXywga2V5KTsNCivCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybjsNCivCoMKgwqDCoMKgwqAgfQ0KKw0KK8KgwqDC
oMKgwqDCoCBucCA9IG9mX2ZpbmRfbm9kZV9ieV9wYXRoKHBhdGgpOw0KK8KgwqDCoMKgwqDCoCBp
ZiAoIW5wKSB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludGsoIiVzOiBmYWls
ZWQgdG8gZmluZCBub2RlIGJ5IHBhdGggJXNcbiIsIF9fZnVuY19fLCANCnBhdGgpOw0KK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuOw0KK8KgwqDCoMKgwqDCoCB9DQorDQorwqDC
oMKgwqDCoMKgIGlmIChlbmFibGUpIHsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHhl
bl9ncmFudF9kbWFfZW5hYmxlX2RldmljZShucCk7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCBwcmludGsoIiVzOiBlbmFibGUgJXNcbiIsIF9fZnVuY19fLCBwYXRoKTsNCivCoMKgwqDC
oMKgwqAgfSBlbHNlIHsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHhlbl9ncmFudF9k
bWFfZGlzYWJsZV9kZXZpY2UobnApOw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJp
bnRrKCIlczogZGlzYWJsZSAlc1xuIiwgX19mdW5jX18sIHBhdGgpOw0KK8KgwqDCoMKgwqDCoCB9
DQorfQ0KKw0KIMKgYm9vbCB4ZW5fdmlydGlvX21lbV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2Ug
KmRldikNCiDCoHsNCiDCoMKgwqDCoMKgwqDCoCBpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJ
UlRJT19GT1JDRV9HUkFOVCkgfHwgeGVuX3B2X2RvbWFpbigpKQ0KZGlmZiAtLWdpdCBhL2RyaXZl
cnMveGVuL21hbmFnZS5jIGIvZHJpdmVycy94ZW4vbWFuYWdlLmMNCmluZGV4IGMxNmRmNjI5OTA3
ZS4uNmRmOTZiZTFlYTQwIDEwMDY0NA0KLS0tIGEvZHJpdmVycy94ZW4vbWFuYWdlLmMNCisrKyBi
L2RyaXZlcnMveGVuL21hbmFnZS5jDQpAQCAtMzA4LDcgKzMwOCw4IEBAIHN0YXRpYyB2b2lkIHN5
c3JxX2hhbmRsZXIoc3RydWN0IHhlbmJ1c193YXRjaCANCip3YXRjaCwgY29uc3QgY2hhciAqcGF0
aCwNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBhZ2FpbjsNCg0KIMKgwqDC
oMKgwqDCoMKgIGlmIChzeXNycV9rZXkgIT0gJ1wwJykNCi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGhhbmRsZV9zeXNycShzeXNycV9rZXkpOw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgLypoYW5kbGVfc3lzcnEoc3lzcnFfa2V5KTsqLw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgeGVuX2dyYW50X2RtYV9oYW5kbGVfc3lzcnEoc3lzcnFfa2V5KTsNCiDCoH0NCg0K
IMKgc3RhdGljIHN0cnVjdCB4ZW5idXNfd2F0Y2ggc3lzcnFfd2F0Y2ggPSB7DQpkaWZmIC0tZ2l0
IGEvaW5jbHVkZS94ZW4veGVuLW9wcy5oIGIvaW5jbHVkZS94ZW4veGVuLW9wcy5oDQppbmRleCBh
MzRmNDI3MWEyZTkuLmMyZGExYmMyNDA5MSAxMDA2NDQNCi0tLSBhL2luY2x1ZGUveGVuL3hlbi1v
cHMuaA0KKysrIGIvaW5jbHVkZS94ZW4veGVuLW9wcy5oDQpAQCAtMjE1LDYgKzIxNSw4IEBAIHN0
YXRpYyBpbmxpbmUgdm9pZCB4ZW5fcHJlZW1wdGlibGVfaGNhbGxfZW5kKHZvaWQpIHsgfQ0KDQog
wqAjZW5kaWYgLyogQ09ORklHX1hFTl9QViAmJiAhQ09ORklHX1BSRUVNUFRJT04gKi8NCg0KK3Zv
aWQgeGVuX2dyYW50X2RtYV9oYW5kbGVfc3lzcnEoaW50IGtleSk7DQorDQogwqAjaWZkZWYgQ09O
RklHX1hFTl9HUkFOVF9ETUFfT1BTDQogwqB2b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKHN0
cnVjdCBkZXZpY2UgKmRldik7DQogwqBib29sIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVj
dCBkZXZpY2UgKmRldik7DQooRU5EKQ0KDQpTbyBob3cgaXQgbG9va3MgbGlrZToNCg0KMS4gRG9t
VSBib290cyB3aXRob3V0IFBDSSBIb3N0IGJyaWRnZSBwcm9iZWQuIFNvIG5vdGhpbmcgUENJIHJl
bGF0ZWQgaXMgDQpvYnNlcnZlZCBpbiBEb21VLg0KDQpjYXQgL3Byb2MvZGV2aWNlLXRyZWUvcGNp
ZUAxMDAwMDAwMC9zdGF0dXMNCmRpc2FibGVkDQoNCjIuIEkgcnVuIGJhY2tlbmRzIGluIERvbUQg
YW5kIGFmdGVyIHRoYXQgaXNzdWUgYSBzaWduYWwgdG8gImVuYWJsZSINCg0Kcm9vdEBnZW5lcmlj
LWFybXY4LXh0LWRvbTA6fiMgeGwgc3lzcnEgRG9tVSA0DQoNCjMuIFRoZSBQQ0kgSG9zdCBicmlk
Z2UgaXMgcHJvYmVkLCBhbmQgYWxsIHJlcXVpcmVkIFBDSSBkZXZpY2VzIGFyZSANCmRpc2NvdmVy
ZWQNCg0Kcm9vdEBnZW5lcmljLWFybXY4LXh0LWRvbTA6fiMgeGwgY29uc29sZSBEb21VDQpbwqAg
MjM3LjQwNzYyMF0geGVuX2dyYW50X2RtYV9oYW5kbGVfc3lzcnE6IGdvdCBrZXkgNTINClvCoCAy
MzcuNDA4MTMzXSBwY2ktaG9zdC1nZW5lcmljIDEwMDAwMDAwLnBjaWU6IGhvc3QgYnJpZGdlIA0K
L3BjaWVAMTAwMDAwMDAgcmFuZ2VzOg0KW8KgIDIzNy40MDgxODZdIHBjaS1ob3N0LWdlbmVyaWMg
MTAwMDAwMDAucGNpZTrCoMKgwqDCoMKgIE1FTSANCjB4MDAyMzAwMDAwMC4uMHgwMDMyZmZmZmZm
IC0+IDB4MDAyMzAwMDAwMA0KW8KgIDIzNy40MDgyMzFdIHBjaS1ob3N0LWdlbmVyaWMgMTAwMDAw
MDAucGNpZTrCoMKgwqDCoMKgIE1FTSANCjB4MDEwMDAwMDAwMC4uMHgwMWZmZmZmZmZmIC0+IDB4
MDEwMDAwMDAwMA0KW8KgIDIzNy40MDgzMTNdIHBjaS1ob3N0LWdlbmVyaWMgMTAwMDAwMDAucGNp
ZTogRUNBTSBhdCBbbWVtIA0KMHgxMDAwMDAwMC0weDFmZmZmZmZmXSBmb3IgW2J1cyAwMC1mZl0N
ClvCoCAyMzcuNDA4NDUxXSBwY2ktaG9zdC1nZW5lcmljIDEwMDAwMDAwLnBjaWU6IFBDSSBob3N0
IGJyaWRnZSB0byBidXMgDQowMDAwOjAwDQpbwqAgMjM3LjQwODQ5MF0gcGNpX2J1cyAwMDAwOjAw
OiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQ0KW8KgIDIzNy40MDg1MTddIHBjaV9idXMg
MDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSANCjB4MjMwMDAwMDAtMHgzMmZmZmZmZl0N
ClvCoCAyMzcuNDA4NTQ1XSBwY2lfYnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0g
DQoweDEwMDAwMDAwMC0weDFmZmZmZmZmZiBwcmVmXQ0KW8KgIDIzNy40MDkwNDNdIHBjaSAwMDAw
OjAwOjAwLjA6IFsxYjM2OjAwMDhdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDANClvCoCAyMzcuNDU4
MDQ1XSBwY2kgMDAwMDowMDowMS4wOiBbMWFmNDoxMDQxXSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAw
DQpbwqAgMjM3LjUwMjU4OF0gcGNpIDAwMDA6MDA6MDEuMDogcmVnIDB4MjA6IFttZW0gMHgwMDAw
MDAwMC0weDAwMDAzZmZmIA0KNjRiaXQgcHJlZl0NClvCoCAyMzcuNTA3NDc1XSBwY2kgMDAwMDow
MDowMi4wOiBbMWFmNDoxMDQyXSB0eXBlIDAwIGNsYXNzIDB4MDEwMDAwDQpbwqAgMjM3LjU1Mjcw
Nl0gcGNpIDAwMDA6MDA6MDIuMDogcmVnIDB4MjA6IFttZW0gMHgwMDAwMDAwMC0weDAwMDAzZmZm
IA0KNjRiaXQgcHJlZl0NClvCoCAyMzcuNTU5ODQ3XSBwY2kgMDAwMDowMDowMS4wOiBCQVIgNDog
YXNzaWduZWQgW21lbSANCjB4MTAwMDAwMDAwLTB4MTAwMDAzZmZmIDY0Yml0IHByZWZdDQpbwqAg
MjM3LjU2MDQxMV0gcGNpIDAwMDA6MDA6MDIuMDogQkFSIDQ6IGFzc2lnbmVkIFttZW0gDQoweDEw
MDAwNDAwMC0weDEwMDAwN2ZmZiA2NGJpdCBwcmVmXQ0KW8KgIDIzNy41NjMzMjRdIHZpcnRpby1w
Y2kgMDAwMDowMDowMS4wOiBTZXQgdXAgWGVuIGdyYW50IERNQSBvcHMgKHJpZCANCjB4OCBzaWQg
MHgxKQ0KW8KgIDIzNy41NjQ4MzNdIHZpcnRpby1wY2kgMDAwMDowMDowMS4wOiBlbmFibGluZyBk
ZXZpY2UgKDAwMDAgLT4gMDAwMikNClvCoCAyMzcuNTgyNzM0XSB2aXJ0aW8tcGNpIDAwMDA6MDA6
MDIuMDogU2V0IHVwIFhlbiBncmFudCBETUEgb3BzIChyaWQgDQoweDEwIHNpZCAweDEpDQpbwqAg
MjM3LjU4MzQxM10gdmlydGlvLXBjaSAwMDAwOjAwOjAyLjA6IGVuYWJsaW5nIGRldmljZSAoMDAw
MCAtPiAwMDAyKQ0KW8KgIDIzNy41OTU3MTJdIHZpcnRpb19ibGsgdmlydGlvMTogNC8wLzAgZGVm
YXVsdC9yZWFkL3BvbGwgcXVldWVzDQpbwqAgMjM3LjU5NjIyN10gdmlydGlvX25ldCB2aXJ0aW8w
IGVucDBzMTogcmVuYW1lZCBmcm9tIGV0aDENClvCoCAyMzcuNjAyNDk5XSB2aXJ0aW9fYmxrIHZp
cnRpbzE6IFt2ZGFdIDQwOTYwMDAgNTEyLWJ5dGUgbG9naWNhbCBibG9ja3MgDQooMi4xMCBHQi8x
Ljk1IEdpQikNClvCoCAyMzcuNjA2MzE3XSB4ZW5fZ3JhbnRfZG1hX2hhbmRsZV9zeXNycTogZW5h
YmxlIC9wY2llQDEwMDAwMDAwDQoNCjQuIFRoZSBzYW1lIHdheSB0aGUgcHNldWRvLWhvdHJlbW92
ZSB3b3VsZCB3b3JrIChpZiB3ZSBjaGFuZ2UgdGhlIHN0YXR1cyANCnRvICJkaXNhYmxlZCIgdGhl
IGNvcnJlc3BvbmRpbmcgZGV2aWNlIGdldHMgcmVtb3ZlZCkNCg0KDQpJZiB0aGlzIHBzZXVkby1o
b3RwbHVnIHNvdW5kcyBhcHByb3ByaWF0ZSBmb3IgdGhlIGRvbTBsZXNzLCB0aGUgb25lIG9mIA0K
dGhlIG5leHQgcXVlc3Rpb25zIHdvdWxkIGJlIHdoYXQNCm1lY2hhbmlzbSB0byB1c2UgZm9yIHNp
Z25hbGxpbmcgKGV2ZW50LCB4ZW5zdG9yZSwgd2hhdGV2ZXIpLiBOb3RlIHRoYXQgDQpzaWduYWwg
c2hvdWxkIG9ubHkgYmUgc2VudA0KaWYgYWxsIGJhY2tlbmRzIHdoaWNoIHNlcnZlIHZpcnRpby1w
Y2kgZGV2aWNlcyB3aXRoaW4gdGhhdCBQQ0kgSG9zdCANCmJyaWRnZSBhcmUgcmVhZHkuDQoNCg0K
Pg0KPg0KPj4+IEFzIGFuIGFsdGVybmF0aXZlIEkgd29uZGVyLCBnaXZlbiB0aGF0IFhlbiBlbXVs
YXRlcyB0aGUgUENJIHJvb3QNCj4+PiBjb21wbGV4LCBpZiB3ZSBjYW4gcmV1c2Ugb25lIG9mIHRo
ZSBQQ0kgbGluayB1cC9kb3duIGRlbGF5cyBmb3IgdGhpcw0KPj4+IGluc3RlYWQsIGxpa2UgInBj
aWVfd2FpdF9mb3JfbGluayIuIEl0IGxvb2tzIGxpa2UgdGhlIHdhaXQgdGltZSBpcyBpbg0KPj4+
IG1pbGxpc2VjIHdoaWxlIHdlIHdvdWxkIG5lZWQgcG90ZW50aWFsbHkgc2V2ZXJhbCBzZWNvbmRz
IGhlcmUgYnV0IGl0DQo+Pj4gbWlnaHQgYmUgcG9zc2libGU/DQo+PiBJIGFtIG5vdCBzdXJlIHRo
YXQgSSB1bmRlcnN0YW5kIHRoaXMgYWx0ZXJuYXRpdmUgaWRlYS4NCj4gVGhlIFBDSSBzdWJzeXN0
ZW0gaGFzIGFscmVhZHkgYSBjb25jZXB0IG9mIHdhaXQgdGltZXMuIEp1c3QgaGF2ZSBhIGxvb2sN
Cj4gYXQgcGNpZV93YWl0X2Zvcl9saW5rIHVuZGVyIGRyaXZlcnMvcGNpLiBUaGUgcXVlc3Rpb24g
d2FzIHdoZXRoZXIgd2UgY2FuDQo+IGZpbmQgYSB3YXkgdG8gcmV1c2Ugb25lIG9mIHRoZSBleGlz
dGluZyB3YWl0IHRpbWVzIHRvIGRlYWwgd2l0aCBvdXINCj4gIndhaXQiIHByb2JsZW0uDQoNCg0K
VGhhbmsgeW91IGZvciB0aGUgZXhwbGFuYXRpb24uIEV2ZW4gaWYgd29ya3MgaXQgd291bGQgYmUg
b25seSBzdWl0YWJsZSANCmZvciB2aXJ0aW8tcGNpDQooZm9yIHRoZSB2aXJ0aW8tbW1pbyB3ZSB3
b3VsZCBuZWVkIHRvIGZpbmQgYW5vdGhlciBzb2x1dGlvbikuDQoNCg0KPg0KPiAgIA0KPj4+IE90
aGVyIGlkZWFzPw0KPj4gQW5vdGhlciAoY3Jhenk/KSBpZGVhIGlzIHRvIHJldXNlIENPTkZJR19Y
RU5fVklSVElPX0ZPUkNFX0dSQU5UIGZvcg0KPj4gZG9tMGxlc3Mgc3lzdGVtIChJIG1lYW4gd2l0
aG91dCAieGVuLGdyYW50LWRtYSIgYmluZGluZ3MgYXQgYWxsKS4NCj4+IElmIHZpcnRpbyBiYWNr
ZW5kcyBhcmUgYWx3YXlzIGdvaW5nIHRvIHJ1biBpbiBEb20wIHdoZW4gd2UgaGF2ZSBpdCB1cA0K
Pj4gYW5kIHJ1bm5pbmcsIHRoZW4gaXQgc2hvdWxkIHdvcmsgYXMgZG9taWQgPT0gMCBpcyByZXNl
cnZlZCBmb3IgRG9tMC4NCj4+IElmIHRoZXJlIGlzIGEgbmVlZCB0byBydW4gdmlydGlvIGJhY2tl
bmRzIGluIG90aGVyICpiYWNrZW5kKiBkb21haW4gKGZvcg0KPj4gdGhlIGRvbWFpbiBJRCB0byBi
ZSBhbHdheXMga25vd24gd2UgY291bGQgcmVzZXJ2ZSBhbiBJRCBmb3IgaXQsIHNvIGl0DQo+PiB3
b3VsZCBiZSBhIGNvbnN0IHZhbHVlKSwNCj4+IHdlIGNvdWxkIHByb2JhYmx5IGludHJvZHVjZSBz
b21ldGhpbmcgY29uZmlndXJhYmxlIGxpa2UNCj4+IENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dS
QU5UX0JFX0RPTUlEIHdpdGggMCBieSBkZWZhdWx0IChvciBjbWQgbGluZQ0KPj4gb3B0aW9uKS4N
Cj4gVGhlIHByb2JsZW0gaW4gYSBkb20wbGVzcyBzeXN0ZW0gaXMgbm90IG11Y2ggaG93IHRvIHRl
bGwgd2hpY2ggaXMgdGhlDQo+IGJhY2tlbmQgZG9taWQsIGJlY2F1c2UgdGhhdCBpcyBrbm93biBp
biBhZHZhbmNlIGFuZCBjb3VsZCBiZSBhZGRlZCB0bw0KPiBkZXZpY2UgdHJlZSBhdCBib290IHNv
bWVob3cuIFRoZSBpc3N1ZSBpcyBob3cgdG8gYXNrIHRoZSBmcm9udGVuZCB0bw0KPiAid2FpdCIg
YW5kIHRoZW4gaG93IHRvIHRlbGwgdGhlIGZyb250ZW5kIHRvICJwcm9jZWVkIiBhZnRlciB0aGUg
YmFja2VuZA0KPiBjb21lcyBvbmxpbmUuDQoNCnBsZWFzZSBzZWUgYWJvdmUuDQoNCg0KVG8gc3Vt
bWFyaXplOg0KDQoxLiBGb3Igbm9ybWFsIGNhc2UgdGhlcmUgaXMgbm8gcHJvYmxlbSB3aXRoIGNv
bW11bmljYXRpbmcgdGhlIGJhY2tlbmQgDQpkb21pZCBvbiBBcm0gd2l0aCBkZXZpY2UtdHJlZSAo
bmVpdGhlciBmb3IgdmlydGlvLW1taW8gbm9yIGZvciB2aXJ0aW8tcGNpKSwNCmZvciB0aGUgdmly
dGlvLXBjaSB0aGUgVjIgKFBDSS1JT01NVSBiaW5kaW5ncykgc2hvdWxkIGJlIHVzZWQuIEZvciB0
aGUgDQpkb20wbGVzcyB0aGVyZSB3b24ndCBiZSBwcm9ibGVtIGFsc28gYXMgSSB1bmRlcnN0b29k
IGZyb20gdGhlIGRpc2N1c3Npb24gDQooYXMgdGhlIGNvbmZpZ3VyYXRpb24gaXMga25vd24gaW4g
YWR2YW5jZSkuDQpTbyBJIHByb3Bvc2UgdG8gY29uY2VudHJhdGUgb24gVjIuDQoNCjIuIFRoZSBw
cm9ibGVtIGlzIGluIHN1cHBvcnRpbmcgdmlydGlvIGZvciB0aGUgZG9tMGxlc3MgaW4gZ2VuZXJh
bCANCmRlc3BpdGUgd2hldGhlciBpdCBpcyBhIGZvcmVpZ24gb3IgZ3JhbnQgbWFwcGluZ3MuDQpI
ZXJlIHdlIHdvdWxkIG5lZWQgYSAocHNldWRvLSlob3RwbHVnIG9yIHNvbWUgb3RoZXIgbWV0aG9k
IHRvIHN0YXJ0IA0Kb3BlcmF0aW5nIG9ubHkgd2hlbiBiYWNrZW5kIGlzIGF2YWlsYWJsZS4NCg0K
DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:12:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:12:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425817.673867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol9oL-0002g4-KO; Wed, 19 Oct 2022 14:12:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425817.673867; Wed, 19 Oct 2022 14:12:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ol9oL-0002fx-HN; Wed, 19 Oct 2022 14:12:45 +0000
Received: by outflank-mailman (input) for mailman id 425817;
 Wed, 19 Oct 2022 14:12:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol9oJ-0002fn-N2; Wed, 19 Oct 2022 14:12:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol9oJ-0005ES-KZ; Wed, 19 Oct 2022 14:12:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ol9oJ-0005s3-CM; Wed, 19 Oct 2022 14:12:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ol9oJ-0005U4-Bp; Wed, 19 Oct 2022 14:12:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=X7+qJC0jhFrQ6GQm3QAsXgcU7ERX8/IR0SPzNzRh3gs=; b=eyXuz328rkZjI4Jtbs6XnPcAue
	0W1x+22/owuEDZHCcMZVWLCJZYCqvyshb0Yw2YbrXGt9Y+bk98pickQWOBks1Z4Cqdi1HukgJk3ys
	8LOCQBId/zKbf8xrj2O4DthXQq5+iwjlmS4QSrIhC51xlafzvjuAvwZ3bj+WHhrS9g18=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174092-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174092: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=31b16384688df9ce0e8f59021fd667e47d7d3972
X-Osstest-Versions-That:
    ovmf=0f6eccdbf75885631221388d362417eb7b873ce0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 14:12:43 +0000

flight 174092 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174092/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 31b16384688df9ce0e8f59021fd667e47d7d3972
baseline version:
 ovmf                 0f6eccdbf75885631221388d362417eb7b873ce0

Last test of basis   174081  2022-10-19 08:11:59 Z    0 days
Testing same since   174092  2022-10-19 12:10:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Leif Lindholm <quic_llindhol@quicinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   0f6eccdbf7..31b1638468  31b16384688df9ce0e8f59021fd667e47d7d3972 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:37:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:37:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425827.673883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olABk-0005DP-L4; Wed, 19 Oct 2022 14:36:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425827.673883; Wed, 19 Oct 2022 14:36:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olABk-0005DI-IV; Wed, 19 Oct 2022 14:36:56 +0000
Received: by outflank-mailman (input) for mailman id 425827;
 Wed, 19 Oct 2022 14:36:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=77I7=2U=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olABj-0005DC-FH
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 14:36:55 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 78742d88-4fbb-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 16:36:53 +0200 (CEST)
Received: from MW4PR04CA0269.namprd04.prod.outlook.com (2603:10b6:303:88::34)
 by DS7PR12MB6311.namprd12.prod.outlook.com (2603:10b6:8:94::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 14:36:49 +0000
Received: from CO1NAM11FT023.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:88:cafe::b9) by MW4PR04CA0269.outlook.office365.com
 (2603:10b6:303:88::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend
 Transport; Wed, 19 Oct 2022 14:36:49 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT023.mail.protection.outlook.com (10.13.175.35) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 19 Oct 2022 14:36:48 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 09:36:46 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 07:36:34 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Wed, 19 Oct 2022 09:36:33 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78742d88-4fbb-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BHeIn4N/MSSJIX0M0y/BnhXkHnDZSUmuehI5vuIESaa81n1dWPJb5CyX4UhqEaesTDSHwo305ZFCwOvszm7b2i4Ey7PVEpVDoQ7FWtyxO/CL7nMQf0znu8Sg1DUUNEPfAMvA3nWk7ZxXgqBrHPq//ek71dpfuKbzsi8lh06NutAhpv7Ic4bwEY5O+mUjmAkiz28rKBxyH/y0s+g/034RQXeZOthxhd+u/XjBwSBSkWO+/N+LGse4XMXfxZzJ1BnKlfKhqfJB/PxYxMUuvPjIfWN9uj0okqN1vKwVJ0DFBZjoAl+KgsJcw+LHmDC13ieXfcioOG05pRaZg8leABHk2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9MOdIhXTWf3IsGbVG4GdVVi8MySn/L+Duw9Q6uZ3MKU=;
 b=I4O83/O1kAAZzhD11XYLqYPf3U5subrTlyCyNVXFUwWW0zsTbieBQdSmLSV/fctjDr528pq/N2ShjdRi41UVHS64T5CSv4lIQvfeTUXBvdBXJ11+qKVfqveD3s5pvXUZRjKvmb9IJshlCqilDnvdVZ3/V+kY63nT6P/WwtTjYkuzNa2IhbeAJSPSJCw4XYGGaX0mN3oPVhHngTwkElqBj5Q7czPbNlgUVwtMsoMbMrHet29l2URwkm8mVY+JKRgSe2jpy+RlbYQlU9dWRRt8YVR92RU+Ah6YIsOMF0UPXbl773g5puOsR8goHi8aRxjnY7kcjkDFxw/Qe7SVKw8ggQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9MOdIhXTWf3IsGbVG4GdVVi8MySn/L+Duw9Q6uZ3MKU=;
 b=PJQ+UOl83eFNTYERO3Tl52yKP8AcNllsQgFfQgkgAooIZ1SqyoNqt7leLgk5QWSYbqzrkw95Xz3oec7HBG3e1Hi1tbDNIvH/mwlXhPvIh5raNSJS1AGZAq3XdewO3iYlPZcK6uWHRPGT36mxouJxGI8m+ufTuO+jq66q+hr50co=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [XEN v1] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Date: Wed, 19 Oct 2022 15:36:20 +0100
Message-ID: <20221019143620.45814-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT023:EE_|DS7PR12MB6311:EE_
X-MS-Office365-Filtering-Correlation-Id: 1f5ccad1-2ada-4cd2-937d-08dab1df5acd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	inE1BqBLxZWzR/hsfB+wb/L1k2rClrcy+YobPDdrS3Tcw58xppmn878BhqH3PxvP2pzAD29BA1em1nPhmBrlrAGJmhKBBuqxVMxl9NGlNPBo3zPt7DiEWwt9/4qkkrD6Kmjm0JEt8sTkMM6fta0S46ktMDkvYuidEjS3fgwIbFh++o+zbpF+GBGWCecQMOYAND9ziIxEmKKPcYun+DmdIAP3LDaq4GGVrTbqHOBwseH95M33adCyler7rV/lC2Z0knqqV+Lyx54a4Y9vuvkfAhz3C+3gB4QYBW7zrdrMBJ3KwxfD2zS/Bt1XQw1iUia7mZFVcjTR7YvUbvGIFU6tFGYA4Z5af2djndHJp7P4YFoISaJu45/JGsaMA6M0FEfF1yYEKqsYPaMZDeY05XP63Pask71HWvfYdcDL0GZQBPmd6z7bHBwSu0pjA27a3E50bd/TKl/PiXvp6Biz4XE1aAa+JyGWvyRak11hhczlS/iCBFAI+jR8gNzaYQzOEDGaqENMnxxyFgjJtTaIF9VyJbCjm2vbESsRxp+K6RkrpgiJxBho9vL1Kkhzbf0X9bpQwwyqxB70kGA+FMt6zCM2TMMPqmabcWnN6WsISC4q6Q3nOrgyx/gLwQvoYe513WYhC+0D+Otc1ttOfHYu7zKgfe1U0Ko56Fd59rjMrbu/EPKhLtc6cF0sT2c7CirOx9w72OtTAxybexWlZy303KgJPtL8jE+wbrSlqAnYRkIydovDScbuAHakEdoMUjRbJQ4GGBL89OgHYyMxXAzxoMD5964H4KkQRPBR80WUXs/bav0=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(40470700004)(46966006)(36840700001)(47076005)(336012)(83380400001)(41300700001)(2906002)(1076003)(6916009)(2616005)(426003)(36860700001)(8936002)(478600001)(5660300002)(82740400003)(186003)(81166007)(36756003)(356005)(8676002)(82310400005)(70586007)(4326008)(70206006)(40460700003)(6666004)(54906003)(40480700001)(26005)(316002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 14:36:48.3873
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f5ccad1-2ada-4cd2-937d-08dab1df5acd
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT023.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6311

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
IGROUPR) is relevant only when the guests run in secure/non-secure mode.
As Xen does not implement security extensions for guests, so the registers
are emulated as read as zero/write ignore.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

 xen/arch/arm/include/asm/gic.h | 2 ++
 xen/arch/arm/vgic-v3.c         | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
index 76e3fa5dc4..998dd62651 100644
--- a/xen/arch/arm/include/asm/gic.h
+++ b/xen/arch/arm/include/asm/gic.h
@@ -48,6 +48,8 @@
 #define GICD_ICFGR1     (0xC04)
 #define GICD_ICFGR2     (0xC08)
 #define GICD_ICFGRN     (0xCFC)
+#define GICD_IGRPMODR   (0xD00)
+#define GICD_IGRPMODRN  (0xD7C)
 #define GICD_NSACR      (0xE00)
 #define GICD_NSACRN     (0xEFC)
 #define GICD_SGIR       (0xF00)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 7fb99a9ff2..0c23f6df9d 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, read zero */
         if ( dabt.size != DABT_WORD ) goto bad_width;
         goto read_as_zero;
@@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, write ignore */
         goto write_ignore_32;
 
@@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /*
          * Above all register are common with GICR and GICD
          * Manage in common
@@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* Above registers are common with GICR and GICD
          * Manage in common */
         return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:47:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:47:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425835.673901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olALR-0006l6-Lx; Wed, 19 Oct 2022 14:46:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425835.673901; Wed, 19 Oct 2022 14:46:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olALR-0006kz-IM; Wed, 19 Oct 2022 14:46:57 +0000
Received: by outflank-mailman (input) for mailman id 425835;
 Wed, 19 Oct 2022 14:46:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olALQ-0006kr-9l
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 14:46:56 +0000
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com
 [2a00:1450:4864:20::32e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e0283b60-4fbc-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 16:46:55 +0200 (CEST)
Received: by mail-wm1-x32e.google.com with SMTP id
 m29-20020a05600c3b1d00b003c6bf423c71so198678wms.0
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 07:46:55 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-224.amazon.com. [54.240.197.224])
 by smtp.gmail.com with ESMTPSA id
 a15-20020adfeecf000000b00228692033dcsm13430511wrp.91.2022.10.19.07.46.53
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 07:46:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0283b60-4fbc-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=e3CNJR4QS88HvnwtBSl41wTR/zmG/zG9xm1dKy2hdG0=;
        b=RLaFX/Dp3vnHi7EJHhSX5b0GIwsMg1yBfJYKUnwXS1cwlDmgjvqMKlg74E60lsiytg
         asoB9dkZbge9csMKtXHnImgeTbKEblrhN6dCjW09KPDjEiWEjZyxsul2DnJiaQxcrEsD
         r381NrzshWlQHwKsJyCQL+X6C+jXyBUrUrcbX4LPeA+tobEE0L6b3mMcNePasU/qGhW8
         xC8DrRSYHSQM43Shmy4Uvz6NL/jr6kw+svjQJWt68FwiAlZyY94cU1JENTq+muMASOzY
         azh2EL/KQ3Nrn5j7jkLmpR0LN5OBD6Le1aDNNr5MQMKl4qVk2L05rS2WedHAdxBx1zBE
         FRJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=e3CNJR4QS88HvnwtBSl41wTR/zmG/zG9xm1dKy2hdG0=;
        b=6r6BFOvmWl2/SveAkEnv7+qG6sckvqf2dx/fu7tSfSXqzkuLz+GKUUOzF2Tw9NnDgq
         tEyNtRckvPLEHi6tzqOfcw0/MK1+vvXaBIzQKtOfuLwVKoVTlXYS01llCYcSXFVOKsUL
         6g5sYcuShWWHyRX5VDbmDTKT84rFT+9xYjkcHXXCqZJgpR+zssc0In8gAqzsHVZ1B40/
         +WKY9EPdJeccZw2lxQbdw2U9CB9Py1dR17eQrzXIdqb8+bkpbFLtgFX0bE63mJtP5v3T
         7tdPe6AEPTjjk0rhqpJiXS41kvpHNk/edlEE/jpJoMwBW6dS9iT5562ebBaJcFA2FZhM
         r5PQ==
X-Gm-Message-State: ACrzQf3bSQYoqwU+jpe/S+Nf4tF1eUQi6Dt6cT7r1JLFh88gL+o1q1pg
	z7wp0mSLAJWp+Iy0ki4HUQ0=
X-Google-Smtp-Source: AMsMyM60hDMlihxQXeLTz6qUTDrTpSHzW00hsuj5yzeuBTXayoatL+q6lxxLGEJhzi1YDWR2UimQIw==
X-Received: by 2002:a05:600c:230d:b0:3c4:2975:321a with SMTP id 13-20020a05600c230d00b003c42975321amr26929174wmo.155.1666190814830;
        Wed, 19 Oct 2022 07:46:54 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <66161258-9b2b-400b-4ed5-e980394f905e@xen.org>
Date: Wed, 19 Oct 2022 15:46:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-2-vikram.garhwal@amd.com>
Content-Language: en-US
Organization: Xen Project
In-Reply-To: <20221015050750.4185-2-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> Build fails when have_xen_pci_passthrough is disabled. This is because of
> incorrect build configuration for xen_pt_stub.c.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Reviewed-by: Paul Durrant <paul@xen.org>



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:49:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:49:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425841.673911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAO6-0007MM-22; Wed, 19 Oct 2022 14:49:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425841.673911; Wed, 19 Oct 2022 14:49:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAO5-0007MF-Vm; Wed, 19 Oct 2022 14:49:41 +0000
Received: by outflank-mailman (input) for mailman id 425841;
 Wed, 19 Oct 2022 14:49:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=prF/=2U=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1olAO4-0007M7-P0
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 14:49:40 +0000
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com
 [2a00:1450:4864:20::32e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4236aa01-4fbd-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 16:49:39 +0200 (CEST)
Received: by mail-wm1-x32e.google.com with SMTP id
 bh7-20020a05600c3d0700b003c6fb3b2052so178817wmb.2
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 07:49:39 -0700 (PDT)
Received: from uni.router.wind (adsl-166.109.242.226.tellas.gr.
 [109.242.226.166]) by smtp.googlemail.com with ESMTPSA id
 u11-20020a05600c210b00b003c6d0f8c377sm161260wml.7.2022.10.19.07.49.37
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 19 Oct 2022 07:49:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4236aa01-4fbd-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=iLhcGxMHCoOK9aYxPCTx907ASeijniOgclzPKssdW5E=;
        b=BdfSJTVWwlsKlhzxuESrSKcnelMbZdUiwTmeLYYSrInaKjK4bGdcr9ZNkwQnvO0aPT
         XbPlfxSSQRJZdWIYMVMYNqdToXfw7XtWntUmGmKbwrErb6h1Wapskejr+8ClpmPyqG3N
         cFFyi07wlYZFBgUeexPo7x3gZQqY7GQMuEZE7mf08uL7d05WLJgGNY3hYj/b0pdS2ldm
         oykPnTjahU/PR9TCfPrWXp8eb6Oi/f6Cs+uDF2SxgFjXN4IJKKuu3IoQJMVlVePRQDGF
         dskZFAJmsxta31sMSEIuMHBfoOOIh7dC8egE8NJrlz1pjIiW3OfLR+xBvowV2nR8Rsdu
         6yEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=iLhcGxMHCoOK9aYxPCTx907ASeijniOgclzPKssdW5E=;
        b=wl2WxSDndxJjdKXhxCB+wTJkn3bEu4d9bNst86+AWRejq8oZqOqnRdtrtFtnvfkW8o
         uN26rx8f0zGluQUEhKkOKvN3la6YhyTi2MrlpiGfzfPEoLYyVMTMfLe2YpyXIn22gVaA
         RdVpfsYCeyhs5Gzpjxl2L3b30Kq5IyqP5Vl06rG5NdTCGM+RkqCaL7YO7S1a13YwwKrJ
         b7+CNItLykR4q25PbQzO7JWbSksbhfOptKjYauNfpYESra+w5IE4ORAOiTQ/FRGpUiFh
         +qOqQdn2zHvY8rqcMc2NxeqwSrBzjJy8I/fgSKbNjxdtwcmq41WmtKMEuJbIN1cgSJwd
         idbw==
X-Gm-Message-State: ACrzQf3lpNsnpuyaFrjFlV33P9QsZ0DpKDfHvKfdT5IlXDzW+dNYAKhU
	LUaPsaDiVKGmXlTv0KLlPmBAh2lDjEA=
X-Google-Smtp-Source: AMsMyM6QERr7j5qDETkwwChgOvJNcEkwecREg4eGj2PGAR1CKin+Kt3OGADWk83T9gq1ij2V5ovJZg==
X-Received: by 2002:a05:600c:3d15:b0:3b4:8bd9:3905 with SMTP id bh21-20020a05600c3d1500b003b48bd93905mr26482553wmb.173.1666190979046;
        Wed, 19 Oct 2022 07:49:39 -0700 (PDT)
From: Xenia Ragiadakou <burzalodowa@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Date: Wed, 19 Oct 2022 17:49:13 +0300
Message-Id: <20221019144913.291677-1-burzalodowa@gmail.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently, the fields 'root_order' and 'sl0' of the pa_range_info for
the 52-bit pa range have the values 3 and 3, respectively.
This configuration does not match any of the valid root table configurations
for 4KB granule and t0sz 12, described in ARM DDI 0487I.a D8.2.7.

More specifically, according to ARM DDI 0487I.a D8.2.7, in order to support
the 52-bit pa size with 4KB granule, the p2m root table needs to be configured
either as a single table at level -1 or as 16 concatenated tables at level 0.
Since, currently there is not support for level -1, set the 'root_order' and
'sl0' fields of the 52-bit pa_range_info according to the second approach.

Note that the values of those fields are not used so far. This patch updates
their values only for the sake of correctness.

Fixes: 407b13a71e32 ("xen/arm: p2m don't fall over on FEAT_LPA enabled hw")
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---

Changes in v2:
- add Fixes tag
- provide a reference to the Arm Arm (paragraph + version)
- change wording in the commit log to not make assumptions on value
  interpretations that may lead to confusion
- state clearly that these values are not used so far

 xen/arch/arm/p2m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index f17500ddf3..c824d62806 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -2251,7 +2251,7 @@ void __init setup_virt_paging(void)
         [3] = { 42,      22/*22*/,  3,          1 },
         [4] = { 44,      20/*20*/,  0,          2 },
         [5] = { 48,      16/*16*/,  0,          2 },
-        [6] = { 52,      12/*12*/,  3,          3 },
+        [6] = { 52,      12/*12*/,  4,          2 },
         [7] = { 0 }  /* Invalid */
     };
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:54:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:54:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425847.673923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olASK-0000L4-Jp; Wed, 19 Oct 2022 14:54:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425847.673923; Wed, 19 Oct 2022 14:54:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olASK-0000Kx-H7; Wed, 19 Oct 2022 14:54:04 +0000
Received: by outflank-mailman (input) for mailman id 425847;
 Wed, 19 Oct 2022 14:54:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olASJ-0000Kr-0g
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 14:54:03 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de3cd9f7-4fbd-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 16:54:01 +0200 (CEST)
Received: by mail-wr1-x431.google.com with SMTP id bp11so29551537wrb.9
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 07:54:01 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 x19-20020a1c7c13000000b003b4868eb6bbsm174007wmc.23.2022.10.19.07.53.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 07:54:00 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de3cd9f7-4fbd-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=0yRTTVBNbj3XA+3EDNVvotZrJvbU0BGaEmHb8InPfG0=;
        b=E2vxbpUHwX77sZFJL6PBKUbeVbBH7WAAubW+1wsp/BXJgK5iWz2YRxogovWe2aDr0S
         IJFe1A5MdZ1vn1D3jQHVTfyVXPiY1Mx+pxFrno/Q6e27CWXL/O1oCxAnzcnpxfB0hEKX
         GlTQrM4S6Y0MT03oQ8ap3MU/oCZD6jsempzvHA69yS81Y2xaF1+nMdjeOACtnmIQyUR2
         I0ZrXwKrukpYCXzV93rFZkILor8/hDHDBv17SAMW66LXf+tGx0broRsoSqEISdsMuFTU
         Kpg9P+3yFGGQx0o8JxIyoGA/TFIUeoEkp38e/BA5VhKz0zN+txCDQJj4CjBJwsbsqN1e
         G8Vw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=0yRTTVBNbj3XA+3EDNVvotZrJvbU0BGaEmHb8InPfG0=;
        b=3YbjAw2wuVEps6PX7YX/6qDRJINlvI2Alrz1RgcvO+g9+52hL9NoFIbOj18deck/mz
         FzBX/nET+Ui/DF0+wRiXAjIjfTFlxGjCxhBG7l7rhqqK2Hr/U6yythMegqyNSqq5ayu7
         62/f01BIrMGBI72RLOvcObDv4leT4P4+WfmK5RKuB+Pla8ugO2axnlkU1G67JDxnWZka
         fTOsaDWBOwjrLy0ZQeFEj90bQFY3EOEeU10cLaW0BHbBX22sJnvgsLlGm2jxNcdf8DT2
         s5m2sbiRp5Xy1NK54DQq7i650FBNNhuwXCzLWzYy6HQUMl4RkT5UIbf8sAyPArHgz0SW
         u+vQ==
X-Gm-Message-State: ACrzQf1h9MOdlRPgDel84DEt6qIfkmDNl8RPcAXyChH0lVBqEZ2suOxG
	FK3BouAkm+eCYB9aSj+hOTE=
X-Google-Smtp-Source: AMsMyM6cYbnQ89uH4UoJ1T55BKD6zyEHstSbXhd0DL+SznmT6uERxps5bwjTk3dmvYSuT212RMynQw==
X-Received: by 2002:a5d:5850:0:b0:234:27c9:8fd8 with SMTP id i16-20020a5d5850000000b0023427c98fd8mr2107984wrf.548.1666191240976;
        Wed, 19 Oct 2022 07:54:00 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <f12d712c-dc47-7778-8cf5-cfd621fdb9ad@xen.org>
Date: Wed, 19 Oct 2022 15:53:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 02/12] hw/i386/xen/: move xen-mapcache.c to hw/xen/
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-3-vikram.garhwal@amd.com>
Organization: Xen Project
In-Reply-To: <20221015050750.4185-3-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> xen-mapcache.c contains common functions which can be used for enabling Xen on
> aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it
> accessible for both aarch64 and x86.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
>   hw/i386/meson.build              | 1 +
>   hw/i386/xen/meson.build          | 1 -
>   hw/i386/xen/trace-events         | 5 -----
>   hw/xen/meson.build               | 4 ++++
>   hw/xen/trace-events              | 5 +++++
>   hw/{i386 => }/xen/xen-mapcache.c | 0
>   6 files changed, 10 insertions(+), 6 deletions(-)
>   rename hw/{i386 => }/xen/xen-mapcache.c (100%)
> 
> diff --git a/hw/i386/meson.build b/hw/i386/meson.build
> index 213e2e82b3..cfdbfdcbcb 100644
> --- a/hw/i386/meson.build
> +++ b/hw/i386/meson.build
> @@ -33,5 +33,6 @@ subdir('kvm')
>   subdir('xen')
>   
>   i386_ss.add_all(xenpv_ss)
> +i386_ss.add_all(xen_ss)
>   
>   hw_arch += {'i386': i386_ss}
> diff --git a/hw/i386/xen/meson.build b/hw/i386/xen/meson.build
> index be84130300..2fcc46e6ca 100644
> --- a/hw/i386/xen/meson.build
> +++ b/hw/i386/xen/meson.build
> @@ -1,6 +1,5 @@
>   i386_ss.add(when: 'CONFIG_XEN', if_true: files(
>     'xen-hvm.c',
> -  'xen-mapcache.c',
>     'xen_apic.c',
>     'xen_platform.c',
>     'xen_pvdevice.c',
> diff --git a/hw/i386/xen/trace-events b/hw/i386/xen/trace-events
> index 5d6be61090..a0c89d91c4 100644
> --- a/hw/i386/xen/trace-events
> +++ b/hw/i386/xen/trace-events
> @@ -21,8 +21,3 @@ xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p"
>   cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
>   cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x"
>   
> -# xen-mapcache.c
> -xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64
> -xen_remap_bucket(uint64_t index) "index 0x%"PRIx64
> -xen_map_cache_return(void* ptr) "%p"
> -
> diff --git a/hw/xen/meson.build b/hw/xen/meson.build
> index ae0ace3046..19d0637c46 100644
> --- a/hw/xen/meson.build
> +++ b/hw/xen/meson.build
> @@ -22,3 +22,7 @@ else
>   endif
>   
>   specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
> +
> +xen_ss = ss.source_set()
> +
> +xen_ss.add(when: 'CONFIG_XEN', if_true: files('xen-mapcache.c'))

Curious as to why you couldn't just add this to the softmmu_ss list above?

   Paul

> diff --git a/hw/xen/trace-events b/hw/xen/trace-events
> index 3da3fd8348..2c8f238f42 100644
> --- a/hw/xen/trace-events
> +++ b/hw/xen/trace-events
> @@ -41,3 +41,8 @@ xs_node_vprintf(char *path, char *value) "%s %s"
>   xs_node_vscanf(char *path, char *value) "%s %s"
>   xs_node_watch(char *path) "%s"
>   xs_node_unwatch(char *path) "%s"
> +
> +# xen-mapcache.c
> +xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64
> +xen_remap_bucket(uint64_t index) "index 0x%"PRIx64
> +xen_map_cache_return(void* ptr) "%p"
> diff --git a/hw/i386/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c
> similarity index 100%
> rename from hw/i386/xen/xen-mapcache.c
> rename to hw/xen/xen-mapcache.c



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:57:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:57:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425854.673934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAVj-00013y-6E; Wed, 19 Oct 2022 14:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425854.673934; Wed, 19 Oct 2022 14:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAVj-00013r-3Y; Wed, 19 Oct 2022 14:57:35 +0000
Received: by outflank-mailman (input) for mailman id 425854;
 Wed, 19 Oct 2022 14:57:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olAVh-00013h-H2; Wed, 19 Oct 2022 14:57:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olAVh-0006Aa-Dn; Wed, 19 Oct 2022 14:57:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olAVh-0006rH-4o; Wed, 19 Oct 2022 14:57:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olAVh-0002j9-4L; Wed, 19 Oct 2022 14:57:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zb5W6sETOJp6xYPcwvg4F8E91n7qFWy9HjFNvo+ZUKA=; b=FRqD/8kOkb+L02bn9TKo/eX1hm
	R6jHWMs5fgwohE65/E1QPhff+Od7RSgKdZX36FHey/WC6R6zmTekn4UmNzhAqG40ZcQSRIFEx2ie/
	48E8hwxhuWI3Daxwo9wlmdhde7dXUNiaw1IFePYD+9izOg+x51PDTfyVaKUwUvaYSr/Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174091-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174091: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 14:57:33 +0000

flight 174091 xen-unstable-smoke real [real]
flight 174093 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174091/
http://logs.test-lab.xenproject.org/osstest/logs/174093/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   12 days
Failing since        173492  2022-10-11 13:01:50 Z    8 days   52 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    1 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 14:59:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 14:59:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425862.673945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAXo-0001di-JU; Wed, 19 Oct 2022 14:59:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425862.673945; Wed, 19 Oct 2022 14:59:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAXo-0001db-GP; Wed, 19 Oct 2022 14:59:44 +0000
Received: by outflank-mailman (input) for mailman id 425862;
 Wed, 19 Oct 2022 14:59:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olAXm-0001dR-Vq
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 14:59:43 +0000
Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com
 [2a00:1450:4864:20::334])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a9309e3e-4fbe-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 16:59:42 +0200 (CEST)
Received: by mail-wm1-x334.google.com with SMTP id
 r8-20020a1c4408000000b003c47d5fd475so188112wma.3
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 07:59:42 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 r11-20020a1c440b000000b003c6f8d30e40sm129706wma.31.2022.10.19.07.59.40
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 07:59:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9309e3e-4fbe-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=XoEeh4KZ31p8n/r4n57cbRW8eoKncmT5vVUmUJK3abU=;
        b=L2sw2TPWXnqend4GkIKrF70tZItmzrLiaR/2OxEAg0eEOWbsDkU+J71PF1nwWAXkKy
         TMYU66e/b8bVfDOFP/mQffjSfG647G2OvnnQp8MZFK1wHmTaknqYRn627H0qmxQINxQz
         /eeeh+pR+6u7+lgO5SVaGrGvg5tJ71Yt2SoNn2wgl6DNnzIxxW6hUzHXBVd589K6lvOT
         QgkoSDDcIsHBvaUo2FaSKsVYBjyk9p3Dav+pmplR12Luct8YHut+kXxR3TEa/pa5E1dA
         XAKxgoGxUwwEaFzyxoeQLyu4HVrLSelYPf603CRwYtM3V+HTtfGDorFabAjdWd0jP3Cb
         lFdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=XoEeh4KZ31p8n/r4n57cbRW8eoKncmT5vVUmUJK3abU=;
        b=7fPhfXhoENA5XgRexwkkdFZs6vaPNLfOB3iF9iQ+uOWd+LrVt/EpcIe28Nr1FasXKN
         3y9GN4N1cV+wtCVE1bNtVPz0q5rPTSxMrmusxYS1P29KXP3sj/PY+ybIddVqJfrExFCC
         orJjWc73xazW1SPvealxZQqWc1mxFUuUn9Hh8MJh0gy4z3ovNycvs60B/SVL7cRTEX0z
         rmdUXnCn5o7fkBazzL0HXNHynLg+5//KgSfXHO72tHpDM+9IxFTx1Aic46/9/6AcsTfz
         x69/SyaNtaip9vjnMSDLEck38rWPXImj3UnC8C4zg+Vs037Sc4Hx7/tJJ9eZEGBksLhJ
         jz8Q==
X-Gm-Message-State: ACrzQf1Fd6Ud8o/9/3+tYGvNSQbGQ8JYP/0RSphcj8AqX6Yn3OcRvkx6
	GkIo4mjxRdmpdAT0Kohc0oE=
X-Google-Smtp-Source: AMsMyM5akBAxdTLdyO602pWu43D5XtULy0iuDq8UgMPWYLOzH8BUZI8IchS6XWDc7Z4GwjkwpFHKeg==
X-Received: by 2002:a05:600c:3d08:b0:3c6:fb56:ac9f with SMTP id bh8-20020a05600c3d0800b003c6fb56ac9fmr8946745wmb.193.1666191581617;
        Wed, 19 Oct 2022 07:59:41 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <50fc4560-1658-f6c7-6617-9ae37b0cffab@xen.org>
Date: Wed, 19 Oct 2022 15:59:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 03/12] hw/i386/xen: rearrange xen_hvm_init_pc
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin"
 <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-4-vikram.garhwal@amd.com>
Organization: Xen Project
In-Reply-To: <20221015050750.4185-4-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> In preparation to moving most of xen-hvm code to an arch-neutral location,
> move non IOREQ references to:
> - xen_get_vmport_regs_pfn
> - xen_suspend_notifier
> - xen_wakeup_notifier
> - xen_ram_init
> 
> towards the end of the xen_hvm_init_pc() function.
> 
> This is done to keep the common ioreq functions in one place which will be
> moved to new function in next patch in order to make it common to both x86 and
> aarch64 machines.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

Reviewed-by: Paul Durrant <paul@xen.org>



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 15:01:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 15:01:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425868.673956 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAZY-00031t-U4; Wed, 19 Oct 2022 15:01:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425868.673956; Wed, 19 Oct 2022 15:01:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAZY-00031m-RH; Wed, 19 Oct 2022 15:01:32 +0000
Received: by outflank-mailman (input) for mailman id 425868;
 Wed, 19 Oct 2022 15:01:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rFyQ=2U=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olAZX-00031e-Mh
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 15:01:31 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2042.outbound.protection.outlook.com [40.107.94.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e920334a-4fbe-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 17:01:30 +0200 (CEST)
Received: from MW4P222CA0019.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::24)
 by BN9PR12MB5307.namprd12.prod.outlook.com (2603:10b6:408:104::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 15:01:26 +0000
Received: from CO1NAM11FT012.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:114:cafe::6d) by MW4P222CA0019.outlook.office365.com
 (2603:10b6:303:114::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 15:01:26 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT012.mail.protection.outlook.com (10.13.175.192) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 19 Oct 2022 15:01:25 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 10:01:24 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 19 Oct 2022 10:01:23 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e920334a-4fbe-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ka/0xb7fu6oX6Xj5cvYg8kD1+EmTA2cB50YCEdexM8CNKf8oV5jnHH5OZrFhbMxp7i2DO5LPSpZBemGW9/yAGR2ybERP4cCQLOUDfwX0E1cZMbEXyijktEu9NLVks1iD02rm+HcBcqdCQRvij+kcgVtDDE0pIuXV8UvtukYf0JLE3YaYAeARiAx8cn7PIWHeqhIeaeIHcYau0i7ABHKTAacukZztbQyqNhxkmpQLC6Gv2bSW90UdGT/VhmYNC1YDcdECzpkKazFzymAJ+i6aacFBY+WA854HvwW2TrrP/9MWHxDKx6Z40hFlrLrWZ3Nbo27KQP5zhmkIvsIrhweUxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QLXR1ru8/yNLeV/Q5w+0zVenBH3nC9OpKEyhUqLgW2o=;
 b=ezs839riop1lPlVRpTi3o3YthLKLKs3lc45obxdybmDYv2igSqB2HqGC5NY3sivRA3mYsLgbd58lCOgjHXBb/gtKqfN0fNLFIGADgRml6KeUtSUVO6n37Gz9Kl4LuvluUp9J8hZly75E36t6JjliBCSWZr8MDyfvftv4lMS1sEt12abi6gfzm2btEpK39JIBCXw8Ou+Tlopc3jsxYwtt3wFaUNL+lGly8R+zhC6jNLtU8udVXgMFKcv251TYHI4QOdkk20VwSEpaf7exGkZ1Zis3i9Zy4R+M5fs2/v/cMm+EkOmcMbYH6KAzzOi15LmOnq8iH4upgTs2ZwZvkJwAPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QLXR1ru8/yNLeV/Q5w+0zVenBH3nC9OpKEyhUqLgW2o=;
 b=AriBnTy5MYo0bTki8GVsfYYWMW8mQFnhQnAy8TeP7nYDeFvk1dsZGPAfIE6+DK8kFi88eQwT5KECPFIvr0Vz/wscnlTyv7h3Tt1JpY7lVKkKyh0+vq+gdU2WgXhEOiglDZFSNseCiZRgte3jCO3Om2K6/1DdiInQanOyP/JXqYI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <4b63c1b9-8d0c-81ae-f401-5cf615ff77bc@amd.com>
Date: Wed, 19 Oct 2022 17:01:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit pa range
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221019144913.291677-1-burzalodowa@gmail.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221019144913.291677-1-burzalodowa@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT012:EE_|BN9PR12MB5307:EE_
X-MS-Office365-Filtering-Correlation-Id: 8a058307-9f73-4fde-8b99-08dab1e2cb6c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v174aBvkVngtr44PhUaJ2A/DL4QeZ4r0J5mI3ZSIY9LJR4BXZ57tx5x6jHKR6CHo8Eipmf+gJV5vjHxGGW8Xz5eHi/G08UYsby0L6q6vvfMgKfic0Vpry8nuXKuobNWJ2K6ri6b5rKVoVBnH03YQzNgFhrUeiO3aNYRzrI5JNqiReCbJ9JUvmLBk5kC2XE7wn6QGfVzQZ6i43V3vJfcLO6AYNXhNwLHKSQj5xeTZQdVoHh1vMUR5vWDvXEYXYrDDXPD7ryhaiGA+eahSB0ses4bLD8E6BDTnAA4NIXWaFlSnDIKnOUY2pQcOoUcnJUFlToUEzzTs/R+lrQqZXXaDit1pWhtoj1Onv16fZFSg5YQkap0xb2CPhTOORNP/GG9g3w/a33nocmd5tIAbyMHbRxHYGxT5cQPdSg+T0NCjHCgcTs4JVSSwFiH+AtItEv2LZkBQOzmKita6keZf0UrbYE7gpfndMeJcMmnT8vP5J/CIzPzzBaQgOdMBAZvhh7XnKAPgM3oM+FiYYhP3OECcJYlQKguOvRL2WV2j+sJgEivIgUuBsR0KojcCBMJjaWJeeDx7QzfuNOTIwt9lIm08VQ7JFxXbK+bkV7sHDLMfukd4rfmXv0i30XIZ0SH15GlgBI8m2OWYkL7pKNiU5BbcLYLgjMqE/PvO3h+w4ydkxsN8o/rv+igj7qMIvqV8t6xB3ZehZ8XA1ZWvkcQtn0f+BI84NIzR6QyVsPLcE/QvAnTWarFRRlrrbItV8CW+jHIq3LOvTvJoxjQ1zNiH8bDbQy4oJHQRZ6GhcfTIpdoM89KAsH2TgrFo/psCFz2QJR6pye9ryZFvTktvWmvPndPXkQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(426003)(47076005)(83380400001)(86362001)(31696002)(82310400005)(81166007)(356005)(82740400003)(41300700001)(8676002)(4326008)(44832011)(8936002)(5660300002)(70206006)(316002)(16576012)(54906003)(70586007)(110136005)(40480700001)(26005)(53546011)(336012)(186003)(40460700003)(2616005)(2906002)(478600001)(31686004)(36756003)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 15:01:25.8241
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a058307-9f73-4fde-8b99-08dab1e2cb6c
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT012.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5307

Hi Xenia,

On 19/10/2022 16:49, Xenia Ragiadakou wrote:
> 
> 
> Currently, the fields 'root_order' and 'sl0' of the pa_range_info for
> the 52-bit pa range have the values 3 and 3, respectively.
> This configuration does not match any of the valid root table configurations
> for 4KB granule and t0sz 12, described in ARM DDI 0487I.a D8.2.7.
> 
> More specifically, according to ARM DDI 0487I.a D8.2.7, in order to support
> the 52-bit pa size with 4KB granule, the p2m root table needs to be configured
> either as a single table at level -1 or as 16 concatenated tables at level 0.
> Since, currently there is not support for level -1, set the 'root_order' and
> 'sl0' fields of the 52-bit pa_range_info according to the second approach.
> 
> Note that the values of those fields are not used so far. This patch updates
> their values only for the sake of correctness.
> 
> Fixes: 407b13a71e32 ("xen/arm: p2m don't fall over on FEAT_LPA enabled hw")
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>

Reviewed-by: Michal Orzel <michal.orzel@amd.com>

~Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 15:12:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 15:12:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425874.673967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAkF-0004Zd-VP; Wed, 19 Oct 2022 15:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425874.673967; Wed, 19 Oct 2022 15:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAkF-0004ZV-Qh; Wed, 19 Oct 2022 15:12:35 +0000
Received: by outflank-mailman (input) for mailman id 425874;
 Wed, 19 Oct 2022 15:12:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tv8N=2U=epam.com=prvs=22918d0935=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1olAkF-0004ZP-3C
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 15:12:35 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73ea9b98-4fc0-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 17:12:32 +0200 (CEST)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JCL5Xk018779;
 Wed, 19 Oct 2022 15:12:24 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3k9ymybtbn-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 19 Oct 2022 15:12:23 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS2PR03MB9696.eurprd03.prod.outlook.com (2603:10a6:20b:60c::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 15:12:20 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 15:12:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73ea9b98-4fc0-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aYcHgZfV92o4O7Crzc+yx/wma+PZMmWNEA4hMEpWeWcx3GjWz6DYNSeLZPUoMBGobQgXn91CgtBGTjmzP/Lw1kpfCv4+1unAoyIa+V6iNC3ppNgJqw6/5CPsugiQBY3rNwi0rJZYFZUkbFv9RSUFuXW4nodzvf5KcD+X5kpM0uKWo6tRBngJ/Vosv4FpFmqVJnHXcXLbDwflecGHO5/7S04YYWwQs9kUGymp/ZpnmfBwSVBI/5y9yQ5iEZULr648E/K7IZUNaqkzaPGgcs69eOmwotjaVRL3nUhPmP/fvKFeMxk2q4NL5zCxmxj08CYHx5zR93d2zH4lWTJfbmrpvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vBmCDwh3KZepR4aGaTdrW0m02Ti4GDoKL5jVbWFHiI0=;
 b=CATgjLQFFL5KHwUY2TWfQO0KJHbBKcp9rmVB+BsfYCPfC86LFl8oc5n7qtOwLxBBTjiuMo+nlhNfJgngNgBrKAE3EnjmYag/lnwLGsU8avzbd0px5v1VpQ9rqSomYCrSO9ymn5w8fU/SuZr0Wgnvd6rS2jssNBOrAty4o9MOsTFguIrbL1D5sLDf8ghsf9/3nSemDa5pRFZ+W3Qx8DviS1WyFPt8SQW7fYX5BzLqOWBxdt1LGH7EcZ3pqY/9R9qKOQkILU052K11oYG+C6gVadNtY9URMerZ2NNJ+iET+4MbiOt/AybkQY9Tfjp2chajW6cleGyVqQEiDIdJddedNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vBmCDwh3KZepR4aGaTdrW0m02Ti4GDoKL5jVbWFHiI0=;
 b=pdJB/QgHUoK2bd7oS+O3ijELqZAgC1ia71YapZbUKNHsGkfjSW64DakWZE6mxYSlxKpDRxz8CAR7wQePM1nCknDZzZkgNlzimHjmUqJow8yyG8orh4pdDIIicZLE8bGX348A67aD2BGCmNR60ObjkG+K1jZWY55ZcPasPJJ7rFrZuCEkRCitkTz+GSVzZyzqV1WEhDyhZyzDffNMMP0euUQUu6cd6mbmDltB3Vja/FYP+UWvmrSilAgIzmtYhdpY+w4nmkD8WZKWZP5+jON+RjJcr9zeZX/q3h+wFCA4s6JUoGtXNzCa8LwewgFDFgNDz6R+PmfmhHJWP3wcZxasEw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64TUTqAgADAWACAANIvgIAA9USA
Date: Wed, 19 Oct 2022 15:12:20 +0000
Message-ID: <5beb5456-25ca-99bc-1ac6-b7d96776b837@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210171731110.4587@ubuntu-linux-20-04-desktop>
 <531d3fe0-de24-4aac-f58a-091edbe25a98@epam.com>
 <alpine.DEB.2.22.394.2210181732350.4587@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210181732350.4587@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS2PR03MB9696:EE_
x-ms-office365-filtering-correlation-id: e1091a1e-e5d4-4d2e-dcd5-08dab1e45197
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MMMj/eKyv0xqMwzpAof224+vGiZ1pnofduAHdwM4mb1KaJU5fU1mAwc/M//vMCQoiZ3lMRWieWZQoq1tW4mvvz+/yUmrA7vCOHSn0AlQbzvH+ojCpTC+uPcdcdolc9Lu2biwYDbeag3AorFJzRzJVx+gZ3u/wKcOJFQBvkQsZVi9+KQ6grqBlkDvqmjxin2fxq7Qg+U9H75+jJ8ScwBzQiuWP4s5k2JJvLAFC9KHXzgBSbwvJ8vG6PrCk619uNPv6/zKu1JTosCVwyWzHR9lYDhsoxN3tbtZcFDGr9NOB+RkvkSYVds86PP4zIsK9H9pdG8OwL91YYGMd5TknysY5cAYrFHoZuT2zBoKWWnHRA1mqvniFnIqEfjnOVJza8S22O79mF4Hy/qSLUGP4bsWlfw4affJGQ3Z1E0KJiJzOXNtY6zjlNJoiA3yJzSUIY5BBKUAMIFh33fTGlMEYnq+ZT+IjImuzX7LCYueBK41AKmQF9lwe+KGKeU0u6ztswqm72aPjmG16V1hwiOCZwAtF7dX0fhd7LBY2ws2/kc3if8dOCSwB5+wQDEwOGYehN/7geWcvRQTg5AHNBVZn15N3z9A3oi8Fo8ISSf4KRk9RoU5Qbb0vaLWz4qXLwdCkb0nmuoTBya61eQ6HQm8/wHY8bI5oynzYDayAMwsXFH4aaY/Z2o6eRtM6XrdQfDvr6s3b6N39/AWdmBVRE8EWcLNHv3yyTDD/Mm+vMyZbXRiZ0KvSY3ZpDGAPGllUOW8RigFVDU7hZ7rBZs02GOXdtH6FTLBgQvx1OKbCSrTfbbq1cGvLUk4+cyf0mekRxGxJV+QZBkJiZ+efPUYQj5bts09dTr6ThpIr3KMqSOj0EEYi6RUsuXNf/M+sVahw2XMvhhZy+lNT/vMau5vK/m5VX4q2A==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(451199015)(36756003)(31686004)(86362001)(31696002)(122000001)(5660300002)(2906002)(38100700002)(41300700001)(30864003)(66446008)(2616005)(66556008)(54906003)(76116006)(316002)(83380400001)(38070700005)(26005)(66476007)(966005)(478600001)(53546011)(55236004)(6916009)(6486002)(186003)(66946007)(91956017)(6512007)(6506007)(4326008)(71200400001)(8936002)(64756008)(8676002)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VFlxSGNGWUoyZEx3eXZkRjQ4dWpIZ0xnTVdaUVFOZE9MT1BzU2NkcXVxbHVB?=
 =?utf-8?B?WU1wUDVwLzd6amVUTWs3clIvM0Erbi9HazdDOVpCaThQc2w2QWErck5FbzdS?=
 =?utf-8?B?dzJoU1JhSVpkemVBMlBWU3hjY0hZMTFOdy9aZklmV1ZENDF5Sk8yWEhEK05K?=
 =?utf-8?B?YTM4WVVoQk85dVZnL1EvWVNSSHdqZkpVcURvdVc0N1R2N3VObHFibGlxcHQz?=
 =?utf-8?B?M2lBb1NRL0ZuWUJSUjVRcC8vSmZOQ3M0SEtNTFMxOUR1Y2pzWkV3UURSZmU3?=
 =?utf-8?B?VTZYenpraEVIS1UxYnVMOUJNTWZVMDdPR21mWFVzTE5WVVh2bTBZSnN3Y0Jm?=
 =?utf-8?B?SUhOZXI4NDVVOHBvMHcxb2s4MzNCaEdRcFBHVXV6OVEyTjlwdWxaRVNFZmUr?=
 =?utf-8?B?cUlkUDZKUy8yTXFOSVVpR1pidS8vTHpFd3RWOTJYeFhlelA0TjMyeVlDMm1L?=
 =?utf-8?B?WTNjay9YdjQrR0F5NnZSWGFQQ24xK3hwK1VYeXVRQk5PN1ZhaXU2c0pJNU1w?=
 =?utf-8?B?TDVtUVE2S1NQTzN2Nndna2lPK1lwQU8yVEIvWUUxaXZkcC9DLzdGK0lWYzhQ?=
 =?utf-8?B?d3c4dzNJenhSMFRDTmpWVWh1OTRFQlNuMERjY0JUbEl4a0l5QWJWUmF4NTNk?=
 =?utf-8?B?S3RyQzd0alZWTUhuKyt4QlFTUWEzdTJJR3lFK0RKd3cwNDBML0Eyb0VXNmpC?=
 =?utf-8?B?YTdqbkdBMHhjRitjd2d6RUJaNWpFTVFRUGtoNWpJSGpiT3JWZ3UySmNXT1hQ?=
 =?utf-8?B?amxoVTUzaVE3RXN5eEI3R2Zwa0VLZnBTWFJ5S09ZVkkzeUtPS0QvQzdMc3Iw?=
 =?utf-8?B?KzQvdkg5M1E2di9QMXR0ODBJQ0pKSDRYejRsN0dzczJ4N3pBK3JzYTZURmpV?=
 =?utf-8?B?UmJKajIvUEhYbE9Sa2hxclQ5VHlmeGQvbER0c0tqQ280cEtKZUlWenZoSnF6?=
 =?utf-8?B?cXNFNkxUKzduQmJ1TlBoeWZBdzEzankwQytLV2FWbGd6OFR0SjlhcjF4Q0Z3?=
 =?utf-8?B?c1dlWDJXUGcxRXVoVlN2elpoSnNXWXcyZDFaWTEzU1lTTWJ5aFE0d28xWUpa?=
 =?utf-8?B?dHo0QWlWU3hTV3F0SU9DYWY3SUowRTdzNnFObUNqMmtKcGRpNnhleDNxZGhu?=
 =?utf-8?B?UnptdU5pM2xQVnlkRXE5dVBGQmpIbldHaFhkdWlGKzIyWlk1R0RCUzFKeFQ0?=
 =?utf-8?B?SEc1ZVI0alV1WjU5NVBIbkt4UDc5aUl6dmRsMmtzY3pFWUQwVlRzUSs0UWxV?=
 =?utf-8?B?NWdmMWFVaUlwL3ZqV3h3eVVBZ2lqQWx5ekdrWW9UVDJyeEFQM1EvbTZoc1Bx?=
 =?utf-8?B?UThHYXM2Mzd2cVRtRVFCMWJSdXZURWl0VE03OWliTUVrUjltV3NUa0FJN3dN?=
 =?utf-8?B?MVJNeGlDMjdTeVRwREFQMkc2RktJQVFjdmU0MzYxUVVjOER4M0czYjJmd3dU?=
 =?utf-8?B?eEozMHBqdFh1WWo0TmZEN3FEekMrdVF5QUtncXZ2N2c4aFlScmpBdDJqU3lj?=
 =?utf-8?B?M0JpQ2s1OUY5eW1FeGQvS2I1eDV0blE5ZEVIbHZkajlGMlVrNWU0RnhWc211?=
 =?utf-8?B?dVlqS0hIMkNvalhYN2wyQzNRWTdvVFl4SC91NngzVWN5RHA4V1E5Ry93UjVt?=
 =?utf-8?B?TXo5VDFZb0huL016c21pOGdEVHhzc2xJNmcxUTNuRTR6MGQ5OE90MFk0NXhu?=
 =?utf-8?B?cGlGdk93WXZpQ1FhNTJma2l3WXVIL0RONVBBbTF2VGVKQnJkY0FHWmdweCth?=
 =?utf-8?B?YzBsN3NaOGpXQ0RMRUVIT3ZodWkrTE1iMUp2Q2tHeGQ0UWUyamZwUEp0UWhu?=
 =?utf-8?B?SlBZU0pvQkE0ZElDb3ZvNGJJNDlpeUtrKzVqU1dXQkpwY2U3WU5pOTQ0V3d0?=
 =?utf-8?B?TDFac0Q1ZGEzUXB1TVRsOC9BV3owMjJ3c3dCWFU3WU5XakRnNFZ3ODFvUC94?=
 =?utf-8?B?ck91QW1nVWhDSFJyL2xDSHMvdERjYUdoVDBmKzB2dFZFYzNmOFExZXJVVU5O?=
 =?utf-8?B?akJtZ3ZmUmlwcStLL2FRcEM4VDByWDlXYUdBc255L0VFbFhkSzhHMGZLQ0Z1?=
 =?utf-8?B?ZmxmSmJNSHdjRXdJd1lGUGxJN2lsTURJMEVEUlVrb3lYUXNQNGZubFducXRz?=
 =?utf-8?B?L3dqY0FYMW1QMjlSRWtieUlodFBSM3hweDVjYys4RzlaNXE2S3FpV3R2K0Fy?=
 =?utf-8?Q?XeFeW1yaayxvDW3HUFjRwh4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <A8ED58559D528E4F831D742A0D02FEDA@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1091a1e-e5d4-4d2e-dcd5-08dab1e45197
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 15:12:20.5757
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7gKh42Elyg8RSIUVdmvoGDtJPFprllOTqDH9d2vreWP2BBGC0Y86GtNCXL2MEUFufLdbf29gfXj2ygBzwNWdFbpb8lxqXwBtYKm7AlU3bo8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR03MB9696
X-Proofpoint-ORIG-GUID: zS3rjZZ-cuwG1CVKQZPG0oiWOiglE5JK
X-Proofpoint-GUID: zS3rjZZ-cuwG1CVKQZPG0oiWOiglE5JK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_09,2022-10-19_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0
 priorityscore=1501 clxscore=1015 suspectscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210190085

DQpPbiAxOS4xMC4yMiAwMzozNCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gT24gVHVlLCAxOCBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3Jv
dGU6DQo+PiBPbiAxOC4xMC4yMiAwMzozMywgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+
IE9uIFNhdCwgMTUgT2N0IDIwMjIsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBG
cm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+
DQo+Pj4+DQo+Pj4+IFVzZSB0aGUgc2FtZSAieGVuLWdyYW50LWRtYSIgZGV2aWNlIGNvbmNlcHQg
Zm9yIHRoZSBQQ0kgZGV2aWNlcw0KPj4+PiBiZWhpbmQgZGV2aWNlLXRyZWUgYmFzZWQgUENJIEhv
c3QgY29udHJvbGxlciwgYnV0IHdpdGggb25lIG1vZGlmaWNhdGlvbi4NCj4+Pj4gVW5saWtlIGZv
ciBwbGF0Zm9ybSBkZXZpY2VzLCB3ZSBjYW5ub3QgdXNlIGdlbmVyaWMgSU9NTVUgYmluZGluZ3MN
Cj4+Pj4gKGlvbW11cyBwcm9wZXJ0eSksIGFzIHdlIG5lZWQgdG8gc3VwcG9ydCBtb3JlIGZsZXhp
YmxlIGNvbmZpZ3VyYXRpb24uDQo+Pj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgUENJIGRldmljZXMg
dW5kZXIgdGhlIHNpbmdsZSBQQ0kgSG9zdCBjb250cm9sbGVyDQo+Pj4+IG1heSBoYXZlIHRoZSBi
YWNrZW5kcyBydW5uaW5nIGluIGRpZmZlcmVudCBYZW4gZG9tYWlucyBhbmQgdGh1cyBoYXZlDQo+
Pj4+IGRpZmZlcmVudCBlbmRwb2ludHMgSUQgKGJhY2tlbmQgZG9tYWlucyBJRCkuDQo+Pj4gSGkg
T2xla3NhbmRyLA0KPj4+DQo+Pj4gICBGcm9tIGFub3RoZXIgZW1haWwgSSB1bmRlcnN0b29kIHRo
YXQgeW91IHN1Y2Nlc3NmdWxseSBtYW5hZ2VkIHRvDQo+Pj4gZGVzY3JpYmUgaW4gZGV2aWNlIHRy
ZWUgYWxsIHRoZSBpbmRpdmlkdWFsIHZpcnRpbyBwY2kgZGV2aWNlcyBzbyB0aGF0DQo+Pj4geW91
IGNhbiBoYXZlIGlvbW11LW1hcC9pb21tdS1tYXAtbWFzayBwcm9wZXJ0aWVzIHVuZGVyIGVhY2gg
dmlydGlvDQo+Pj4gZGV2aWNlIG5vZGUuIElzIHRoYXQgcmlnaHQ/DQo+PiBOby4gSGVyZSBbMV0g
SSBtZW50aW9uZWQgdGhhdCBJIGhhZCBleHBlcmltZW50ZWQgd2l0aCBQQ0ktSU9NTVUgYmluZGlu
Z3MNCj4+IChpb21tdS1tYXAvaW9tbXUtbWFwLW1hc2sgcHJvcGVydGllcykgYXMgSU9NTVUgYmlu
ZGluZ3MgKGlvbW11IHByb3BlcnR5KQ0KPj4gaXMgaW5zdWZmaWNpZW50IGZvciB1cyBhbmQgZ290
IGl0IHdvcmtlZC4NCj4+IEFsc28gSSBwcm92aWRlZCBhIGxpbmsgdG8gdGhlIGN1cnJlbnQgcGF0
Y2guIFNvcnJ5LCBpZiBJIHdhcyB1bmNsZWFyLg0KPj4NCj4+IEp1c3QgdG8gYmUgY2xlYXI6DQo+
Pg0KPj4gV2UgZG8gbm90IGRlc2NyaWJlIGluIGRldmljZS10cmVlIGFsbCB0aGUgaW5kaXZpZHVh
bCB2aXJ0aW8tcGNpIGRldmljZXMNCj4+IChhbmQgd2UgZG8gbm90IGhhdmUgdG8pLCB3ZSBvbmx5
IGRlc2NyaWJlIGdlbmVyaWMgUENJIGhvc3QgYnJpZGdlIG5vZGUuDQo+PiBTbyB3ZSBoYXZlIG9u
bHkgYSAqc2luZ2xlKiBpb21tdS1tYXAgcHJvcGVydHkgdW5kZXIgdGhhdCBQQ0kgaG9zdCBicmlk
Z2UNCj4+IG5vZGUuDQo+PiBUaGUgaW9tbXUtbWFwIHByb3BlcnR5IGluIHR1cm4gZGVzY3JpYmVz
IHRoZSBJT01NVSBjb25uZWN0aW9ucyBmb3IgdGhlDQo+PiBlbmRwb2ludHMgd2l0aGluIHRoYXQg
UENJIEhvc3QgYnJpZGdlIGFjY29yZGluZyB0bzoNCj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20v
djMvX19odHRwczovL3d3dy5rZXJuZWwub3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv
YmluZGluZ3MvcGNpL3BjaS1pb21tdS50eHRfXzshIUdGXzI5ZGJjUUlVQlBBITA3OEtUXzZNNWY3
UDVfbTZPMkVvdHZXRUQteXVTWktIenpxeWtEb1c1RFB0UU9XSlFlb1pCNFFXc0pDcUNrUC13RnRM
cnk1VGlMQXozdWhObkIyY2NOWTlDc041N1EkICBba2VybmVsWy5db3JnXQ0KPj4NCj4+IEZvciB0
aGUgaW5zdGFuY2UsIHRoZSBmb2xsb3dpbmcgaW9tbXUtbWFwIHByb3BlcnR5IHVuZGVyIHRoYXQg
UENJIGhvc3QNCj4+IGJyaWRnZSBub2RlIGRlc2NyaWJlcyB0aGUgcmVsYXRpb25zaGlwIGJldHdl
ZW4gSU9NTVUgYW5kIHR3byBQQ0kgZGV2aWNlcw0KPj4gKDAwMDA6MDA6MDEuMCBhbmQgMDAwMDow
MDowMi4wKToNCj4+IGlvbW11LW1hcCA9IDwweDA4IDB4ZmRlOSAweDAxIDB4MDggMHgxMCAweGZk
ZTkgMHgwMiAweDA4PjsNCj4+IEZvciAwMDAwOjAwOjAxLjAgd2UgcGFzcyB0aGUgZW5kcG9pbnQg
SUQgMSAoYmFja2VuZCBkb21pZCAxKQ0KPj4gRm9yIDAwMDA6MDA6MDIuMCB3ZSBwYXNzIHRoZSBl
bmRwb2ludCBJRCAyIChiYWNrZW5kIGRvbWlkIDIpDQo+PiBPdGhlciBQQ0kgZGV2aWNlcyAoaS5l
IDAwMDA6MDA6MDMuMCkgYXJlIHVudHJhbnNsYXRlZCAoYXJlIG5vdCByZXF1aXJlZA0KPj4gdG8g
dXNlIGdyYW50cyBmb3IgdGhlIHZpcnRpbykuDQo+IFRoYXQncyBncmVhdCEgSSBtaXN1bmRlcnN0
b29kLiBBY3R1YWxseSBJIHdvbmRlciBpZiBpb21tdS1tYXAgbWlnaHQgYmUNCj4gc3VpdGFibGUg
YWxzbyBmb3IgaG90cGx1ZyBkZXZpY2VzIChhcyBsb25nIGFzIHRoZSBiYWNrZW5kIGRvbWlkIGlz
IGtub3duDQo+IGJlZm9yZWhhbmQpLiBJIHRoaW5rIHRoYXQgc2hvdWxkIHdvcms/DQoNCkkgZG9u
J3Qgc2VlIGF0IHRoZSBtb21lbnQgYW55IHJlYXNvbnMgd2h5IGFjdHVhbGx5IG5vdC4gSSBhc3N1
bWUsIGl0IA0Kd291bGQgYWxzbyB3b3JrLg0KRm9yIGhvdHBsdWcgZGV2aWNlcyB0aGUgYXJjaF9z
ZXR1cF9kbWFfb3BzKCkgLT4gLi4uIC0+IA0KeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoKQ0Kd2ls
bCBhbHNvIGJlIGNhbGxlZCBhcyBpdCBpcyBjYWxsZWQgZm9yICpib290KiBkZXZpY2VzLCBpc24n
dCBpdD8NCg0KDQo+IEl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byBzcGVjaWZ5DQo+IFBDSSBkZXZp
Y2UgSURzIGV2ZW4gaWYgdGhvc2UgZGV2aWNlIElEcyBhcmUgbm90IHByZXNlbnQgeWV0Pw0KDQoN
CkkgbWF5IG1pc3Rha2UsIGJ1dCBJIHRoaW5rLCB5ZXMuIEkgdGhpbmssIG5vdGhpbmcgcHJldmVu
dHMgdXMgZnJvbSBkb2luZyANCnNvIHdoZW4gY3JlYXRpbmcgUENJIEhvc3QgYnJpZGdlIG5vZGUg
aW4gdGhlIHRvb2xzdGFjayAob3IgWGVuIGlmIGl0IGlzIA0KYSBkb20wbGVzcykuDQpJIHRoaW5r
LCB3ZSBkbyBub3QgdmlvbGF0ZSBhbnl0aGluZy4gV2UganVzdCBkZXNjcmliZSB0aGUgSU9NTVUg
bWFwcGluZyANCnNjaGVtZSBmb3IgUENJIGRldmljZXMuIElmIFBDSSBkZXZpY2Ugd2l0aCBzcGVj
aWZpZWQgUklEIGFwcGVhcnMgYXQgc29tZSANCnBvaW50IGluIGZ1dHVyZSwNCnRoZSBjb3JyZXNw
b25kaW5nIFNJRCAoYmFja2VuZCBkb21pZCkgd2lsbCBiZSBhc3NpZ25lZCB0byBpdCwgaWYgbm90
IA0KYXBwZWFycyAtIG5vdGhpbmcgYmFkIHdpbGwgaGFwcGVuLg0KDQpJIHRoaW5rLCB0aGlzIGlz
IHNpbWlsYXIgdG8gaW50ZXJydXB0LW1hcCBwcm9wZXJ0eSB3aGVyZSB3ZSBkZXNjcmliZSB0aGUg
DQppbnRlcnJ1cHQgbWFwcGluZyBzY2hlbWUgZm9yIFBDSSBkZXZpY2VzLg0KDQoNCj4NCj4gSWYg
dGhpcyB3b3JrLCBpdCBjb3VsZCBiZSB0aGUgYmVzdCBzb2x1dGlvbiBhY3R1YWxseS4NCg0KDQp0
aGFua3MsIEkgY2Fubm90IHNheSBmb3Igc3VyZSB3aGV0aGVyIGl0IHdpbGwgMTAwJSB3b3JrIGFz
IHdlIGRvbid0IGhhdmUgDQphIHdvcmtpbmcgaG90cGx1ZyBhdCB0aGUgbW9tZW50LCBzbyBpdCBp
cyBub3QgcG9zc2libGUgdG8gcmUtY2hlY2ssIGJ1dCANCkkgZG9uJ3Qgc2VlIHdoeSB0aGF0IHNv
bHV0aW9uIHdvbid0IHdvcmsgZm9yIHVzLg0KDQoNCj4gICANCj4NCj4+PiBJZiB0aGF0IGlzIHRo
ZSBjYXNlLCB0aGVuIEkgd291bGQgcmF0aGVyIGp1bXAgc3RyYWlnaHQgdG8gdGhhdCBhcHByb2Fj
aA0KPj4+IGJlY2F1c2UgSSB0aGluayBpdCBpcyBmYXIgYmV0dGVyIHRoYW4gdGhpcyBvbmUuDQo+
PiBQbGVhc2Ugc2VlIGFib3ZlLCBJIGRvbid0IGhhdmUgYW55IG90aGVyIGFwcHJvYWNoIGV4Y2Vw
dCB0aGUgb25lDQo+PiBpbXBsZW1lbnRlZCBpbiBjdXJyZW50IHBhdGNoLg0KPj4NCj4+IFsxXQ0K
Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hl
bi1kZXZlbC8xNjQ4NWJjOS0wZTJhLTc4OGEtOTNiOC00NTNjYzllZjBkM2NAZXBhbS5jb20vX187
ISFHRl8yOWRiY1FJVUJQQSEwNzhLVF82TTVmN1A1X202TzJFb3R2V0VELXl1U1pLSHp6cXlrRG9X
NURQdFFPV0pRZW9aQjRRV3NKQ3FDa1Atd0Z0THJ5NVRpTEF6M3VoTm5CMmNjTmFvTjBBVU93JCAg
W2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pg0KPj4NCj4+PiBDaGVlcnMsDQo+Pj4NCj4+PiBTdGVm
YW5vDQo+Pj4NCj4+Pg0KPj4+DQo+Pj4+IFNvIHVzZSBnZW5lcmljIFBDSS1JT01NVSBiaW5kaW5n
cyBpbnN0ZWFkIChpb21tdS1tYXAvaW9tbXUtbWFwLW1hc2sNCj4+Pj4gcHJvcGVydGllcykgd2hp
Y2ggYWxsb3dzIHVzIHRvIGRlc2NyaWJlIHJlbGF0aW9uc2hpcCBiZXR3ZWVuIFBDSQ0KPj4+PiBk
ZXZpY2VzIGFuZCBiYWNrZW5kIGRvbWFpbnMgSUQgcHJvcGVybHkuDQo+Pj4+DQo+Pj4+IFNpZ25l
ZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFt
LmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IFNsaWdodGx5IFJGQy4gVGhpcyBpcyBuZWVkZWQgdG8gc3Vw
cG9ydCBYZW4gZ3JhbnQgbWFwcGluZ3MgZm9yIHZpcnRpby1wY2kgZGV2aWNlcw0KPj4+PiBvbiBB
cm0gYXQgc29tZSBwb2ludCBpbiB0aGUgZnV0dXJlLiBUaGUgWGVuIHRvb2xzdGFjayBzaWRlIGlz
IG5vdCBjb21wbGV0ZWx5IHJlYWR5IHlldC4NCj4+Pj4gSGVyZSwgZm9yIFBDSSBkZXZpY2VzIHdl
IHVzZSBtb3JlIGZsZXhpYmxlIHdheSB0byBwYXNzIGJhY2tlbmQgZG9taWQgdG8gdGhlIGd1ZXN0
DQo+Pj4+IHRoYW4gZm9yIHBsYXRmb3JtIGRldmljZXMuDQo+Pj4+DQo+Pj4+IENoYW5nZXMgVjEg
LT4gVjI6DQo+Pj4+ICAgICAgLSB1cGRhdGUgY29tbWl0IGRlc2NyaXB0aW9uDQo+Pj4+ICAgICAg
LSByZWJhc2UNCj4+Pj4gICAgICAtIHJld29yayB0byB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmlu
ZGluZ3MgaW5zdGVhZCBvZiBnZW5lcmljIElPTU1VIGJpbmRpbmdzDQo+Pj4+DQo+Pj4+IFByZXZp
b3VzIGRpc2N1c3Npb24gaXMgYXQ6DQo+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19o
dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDYxNzQ4MDQuMjAwMzAyOS0x
LW9sZWtzdHlzaEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSExbVNFVHhnOENSb2hsTDVP
cFlvMFZhTEJYdGJXUkxabGFtOVFBQk1QX1lVenNZY3JuOG5vMUZ4QlB2aFFuTlJDU3pwM3BrQzFk
WElnbWhkYVptSjNveVY2eVdVeTN3JCAgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+Pj4+DQo+Pj4+
IEJhc2VkIG9uOg0KPj4+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9naXQu
a2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQveGVuL3RpcC5naXQvbG9nLz9oPWZv
ci1saW51cy02LjFfXzshIUdGXzI5ZGJjUUlVQlBBITFtU0VUeGc4Q1JvaGxMNU9wWW8wVmFMQlh0
YldSTFpsYW05UUFCTVBfWVV6c1ljcm44bm8xRnhCUHZoUW5OUkNTenAzcGtDMWRYSWdtaGRhWm1K
M295V2EtNnl5dWckICBbZ2l0Wy5da2VybmVsWy5db3JnXQ0KPj4+PiAtLS0NCj4+Pj4gICAgZHJp
dmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgODcgKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKystLS0tLQ0KPj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgNzYgaW5zZXJ0aW9ucygrKSwgMTEg
ZGVsZXRpb25zKC0pDQo+Pj4+DQo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1k
bWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4gaW5kZXggZGFhNTI1
ZGY3YmRjLi5iNzlkOWQ2Y2UxNTQgMTAwNjQ0DQo+Pj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50
LWRtYS1vcHMuYw0KPj4+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+Pj4g
QEAgLTEwLDYgKzEwLDcgQEANCj4+Pj4gICAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KPj4+
PiAgICAjaW5jbHVkZSA8bGludXgvZG1hLW1hcC1vcHMuaD4NCj4+Pj4gICAgI2luY2x1ZGUgPGxp
bnV4L29mLmg+DQo+Pj4+ICsjaW5jbHVkZSA8bGludXgvcGNpLmg+DQo+Pj4+ICAgICNpbmNsdWRl
IDxsaW51eC9wZm4uaD4NCj4+Pj4gICAgI2luY2x1ZGUgPGxpbnV4L3hhcnJheS5oPg0KPj4+PiAg
ICAjaW5jbHVkZSA8bGludXgvdmlydGlvX2FuY2hvci5oPg0KPj4+PiBAQCAtMjkyLDEyICsyOTMs
NTUgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkbWFfbWFwX29wcyB4ZW5fZ3JhbnRfZG1hX29wcyA9
IHsNCj4+Pj4gICAgCS5kbWFfc3VwcG9ydGVkID0geGVuX2dyYW50X2RtYV9zdXBwb3J0ZWQsDQo+
Pj4+ICAgIH07DQo+Pj4+ICAgIA0KPj4+PiArc3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVu
X2R0X2dldF9wY2lfaG9zdF9ub2RlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4gK3sNCj4+Pj4g
KwlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2KTsNCj4+Pj4gKwlzdHJ1Y3Qg
cGNpX2J1cyAqYnVzID0gcGRldi0+YnVzOw0KPj4+PiArDQo+Pj4+ICsJLyogV2FsayB1cCB0byB0
aGUgcm9vdCBidXMgdG8gbG9vayBmb3IgUENJIEhvc3QgY29udHJvbGxlciAqLw0KPj4+PiArCXdo
aWxlICghcGNpX2lzX3Jvb3RfYnVzKGJ1cykpDQo+Pj4+ICsJCWJ1cyA9IGJ1cy0+cGFyZW50Ow0K
Pj4+PiArDQo+Pj4+ICsJcmV0dXJuIG9mX25vZGVfZ2V0KGJ1cy0+YnJpZGdlLT5wYXJlbnQtPm9m
X25vZGUpOw0KPj4+PiArfQ0KPj4+PiArDQo+Pj4+ICtzdGF0aWMgc3RydWN0IGRldmljZV9ub2Rl
ICp4ZW5fZHRfZ2V0X25vZGUoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4+PiArew0KPj4+PiArCWlm
IChkZXZfaXNfcGNpKGRldikpDQo+Pj4+ICsJCXJldHVybiB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25v
ZGUoZGV2KTsNCj4+Pj4gKw0KPj4+PiArCXJldHVybiBvZl9ub2RlX2dldChkZXYtPm9mX25vZGUp
Ow0KPj4+PiArfQ0KPj4+PiArDQo+Pj4+ICtzdGF0aWMgaW50IHhlbl9kdF9tYXBfaWQoc3RydWN0
IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKippb21tdV9ucCwNCj4+Pj4gKwkJCSB1
MzIgKnNpZCkNCj4+Pj4gK3sNCj4+Pj4gKwlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9k
ZXYoZGV2KTsNCj4+Pj4gKwl1MzIgcmlkID0gUENJX0RFVklEKHBkZXYtPmJ1cy0+bnVtYmVyLCBw
ZGV2LT5kZXZmbik7DQo+Pj4+ICsJc3RydWN0IGRldmljZV9ub2RlICpob3N0X25wOw0KPj4+PiAr
CWludCByZXQ7DQo+Pj4+ICsNCj4+Pj4gKwlob3N0X25wID0geGVuX2R0X2dldF9wY2lfaG9zdF9u
b2RlKGRldik7DQo+Pj4+ICsJaWYgKCFob3N0X25wKQ0KPj4+PiArCQlyZXR1cm4gLUVOT0RFVjsN
Cj4+Pj4gKw0KPj4+PiArCXJldCA9IG9mX21hcF9pZChob3N0X25wLCByaWQsICJpb21tdS1tYXAi
LCAiaW9tbXUtbWFwLW1hc2siLCBpb21tdV9ucCwgc2lkKTsNCj4+Pj4gKwlvZl9ub2RlX3B1dCho
b3N0X25wKTsNCj4+Pj4gKw0KPj4+PiArCXJldHVybiByZXQ7DQo+Pj4+ICt9DQo+Pj4+ICsNCj4+
Pj4gICAgc3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmlj
ZSAqZGV2KQ0KPj4+PiAgICB7DQo+Pj4+IC0Jc3RydWN0IGRldmljZV9ub2RlICppb21tdV9ucDsN
Cj4+Pj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKmlvbW11X25wID0gTlVMTDsNCj4+Pj4gICAgCWJv
b2wgaGFzX2lvbW11Ow0KPj4+PiAgICANCj4+Pj4gLQlpb21tdV9ucCA9IG9mX3BhcnNlX3BoYW5k
bGUoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgMCk7DQo+Pj4+ICsJaWYgKGRldl9pc19wY2koZGV2
KSkgew0KPj4+PiArCQlpZiAoeGVuX2R0X21hcF9pZChkZXYsICZpb21tdV9ucCwgTlVMTCkpDQo+
Pj4+ICsJCQlyZXR1cm4gZmFsc2U7DQo+Pj4+ICsJfSBlbHNlDQo+Pj4+ICsJCWlvbW11X25wID0g
b2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21tdXMiLCAwKTsNCj4+Pj4gKw0KPj4+
PiAgICAJaGFzX2lvbW11ID0gaW9tbXVfbnAgJiYNCj4+Pj4gICAgCQkgICAgb2ZfZGV2aWNlX2lz
X2NvbXBhdGlibGUoaW9tbXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQo+Pj4+ICAgIAlvZl9ub2Rl
X3B1dChpb21tdV9ucCk7DQo+Pj4+IEBAIC0zMDcsOSArMzUxLDE3IEBAIHN0YXRpYyBib29sIHhl
bl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4gICAgDQo+
Pj4+ICAgIGJvb2wgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0K
Pj4+PiAgICB7DQo+Pj4+ICsJc3RydWN0IGRldmljZV9ub2RlICpucDsNCj4+Pj4gKw0KPj4+PiAg
ICAJLyogWFhYIEhhbmRsZSBvbmx5IERUIGRldmljZXMgZm9yIG5vdyAqLw0KPj4+PiAtCWlmIChk
ZXYtPm9mX25vZGUpDQo+Pj4+IC0JCXJldHVybiB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShk
ZXYpOw0KPj4+PiArCW5wID0geGVuX2R0X2dldF9ub2RlKGRldik7DQo+Pj4+ICsJaWYgKG5wKSB7
DQo+Pj4+ICsJCWJvb2wgcmV0Ow0KPj4+PiArDQo+Pj4+ICsJCXJldCA9IHhlbl9pc19kdF9ncmFu
dF9kbWFfZGV2aWNlKGRldik7DQo+Pj4+ICsJCW9mX25vZGVfcHV0KG5wKTsNCj4+Pj4gKwkJcmV0
dXJuIHJldDsNCj4+Pj4gKwl9DQo+Pj4+ICAgIA0KPj4+PiAgICAJcmV0dXJuIGZhbHNlOw0KPj4+
PiAgICB9DQo+Pj4+IEBAIC0zMjUsMTIgKzM3NywxOSBAQCBib29sIHhlbl92aXJ0aW9fbWVtX2Fj
YyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KQ0KPj4+PiAgICBzdGF0aWMgaW50IHhlbl9kdF9n
cmFudF9pbml0X2JhY2tlbmRfZG9taWQoc3RydWN0IGRldmljZSAqZGV2LA0KPj4+PiAgICAJCQkJ
CSAgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGEpDQo+Pj4+ICAgIHsNCj4+Pj4gLQlz
dHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzIGlvbW11X3NwZWM7DQo+Pj4+ICsJc3RydWN0IG9mX3BoYW5k
bGVfYXJncyBpb21tdV9zcGVjID0geyAuYXJnc19jb3VudCA9IDEgfTsNCj4+Pj4gICAgDQo+Pj4+
IC0JaWYgKG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKGRldi0+b2Zfbm9kZSwgImlvbW11cyIs
ICIjaW9tbXUtY2VsbHMiLA0KPj4+PiAtCQkJMCwgJmlvbW11X3NwZWMpKSB7DQo+Pj4+IC0JCWRl
dl9lcnIoZGV2LCAiQ2Fubm90IHBhcnNlIGlvbW11cyBwcm9wZXJ0eVxuIik7DQo+Pj4+IC0JCXJl
dHVybiAtRVNSQ0g7DQo+Pj4+ICsJaWYgKGRldl9pc19wY2koZGV2KSkgew0KPj4+PiArCQlpZiAo
eGVuX2R0X21hcF9pZChkZXYsICZpb21tdV9zcGVjLm5wLCBpb21tdV9zcGVjLmFyZ3MpKSB7DQo+
Pj4+ICsJCQlkZXZfZXJyKGRldiwgIkNhbm5vdCB0cmFuc2xhdGUgSURcbiIpOw0KPj4+PiArCQkJ
cmV0dXJuIC1FU1JDSDsNCj4+Pj4gKwkJfQ0KPj4+PiArCX0gZWxzZSB7DQo+Pj4+ICsJCWlmIChv
Zl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25vZGUsICJpb21tdXMiLCAiI2lvbW11
LWNlbGxzIiwNCj4+Pj4gKwkJCQkwLCAmaW9tbXVfc3BlYykpIHsNCj4+Pj4gKwkJCWRldl9lcnIo
ZGV2LCAiQ2Fubm90IHBhcnNlIGlvbW11cyBwcm9wZXJ0eVxuIik7DQo+Pj4+ICsJCQlyZXR1cm4g
LUVTUkNIOw0KPj4+PiArCQl9DQo+Pj4+ICAgIAl9DQo+Pj4+ICAgIA0KPj4+PiAgICAJaWYgKCFv
Zl9kZXZpY2VfaXNfY29tcGF0aWJsZShpb21tdV9zcGVjLm5wLCAieGVuLGdyYW50LWRtYSIpIHx8
DQo+Pj4+IEBAIC0zNTQsNiArNDEzLDcgQEAgc3RhdGljIGludCB4ZW5fZHRfZ3JhbnRfaW5pdF9i
YWNrZW5kX2RvbWlkKHN0cnVjdCBkZXZpY2UgKmRldiwNCj4+Pj4gICAgdm9pZCB4ZW5fZ3JhbnRf
c2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+ICAgIHsNCj4+Pj4gICAgCXN0
cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+Pj4+ICsJc3RydWN0IGRldmljZV9ub2Rl
ICpucDsNCj4+Pj4gICAgDQo+Pj4+ICAgIAlkYXRhID0gZmluZF94ZW5fZ3JhbnRfZG1hX2RhdGEo
ZGV2KTsNCj4+Pj4gICAgCWlmIChkYXRhKSB7DQo+Pj4+IEBAIC0zNjUsOCArNDI1LDEzIEBAIHZv
aWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4+PiAgICAJ
aWYgKCFkYXRhKQ0KPj4+PiAgICAJCWdvdG8gZXJyOw0KPj4+PiAgICANCj4+Pj4gLQlpZiAoZGV2
LT5vZl9ub2RlKSB7DQo+Pj4+IC0JCWlmICh4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlk
KGRldiwgZGF0YSkpDQo+Pj4+ICsJbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsNCj4+Pj4gKwlp
ZiAobnApIHsNCj4+Pj4gKwkJaW50IHJldDsNCj4+Pj4gKw0KPj4+PiArCQlyZXQgPSB4ZW5fZHRf
Z3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSk7DQo+Pj4+ICsJCW9mX25vZGVfcHV0
KG5wKTsNCj4+Pj4gKwkJaWYgKHJldCkNCj4+Pj4gICAgCQkJZ290byBlcnI7DQo+Pj4+ICAgIAl9
IGVsc2UgaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQpKSB7DQo+
Pj4+ICAgIAkJZGV2X2luZm8oZGV2LCAiVXNpbmcgZG9tMCBhcyBiYWNrZW5kXG4iKTsNCj4+Pj4g
LS0gDQo+Pj4+IDIuMjUuMQ0KPj4+Pg0KPj4gLS0gDQo+PiBSZWdhcmRzLA0KPj4NCj4+IE9sZWtz
YW5kciBUeXNoY2hlbmtvDQo+Pg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5r
bw0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 15:28:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 15:28:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425881.673978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAzR-0006Z7-FF; Wed, 19 Oct 2022 15:28:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425881.673978; Wed, 19 Oct 2022 15:28:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olAzR-0006Z0-An; Wed, 19 Oct 2022 15:28:17 +0000
Received: by outflank-mailman (input) for mailman id 425881;
 Wed, 19 Oct 2022 15:28:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ql0W=2U=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1olAzQ-0006Ys-Cr
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 15:28:16 +0000
Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com
 [2607:f8b0:4864:20::a33])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a583081b-4fc2-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 17:28:14 +0200 (CEST)
Received: by mail-vk1-xa33.google.com with SMTP id s185so8492141vkb.0
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 08:28:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a583081b-4fc2-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=I6tvXcyWMOlmBE2vfqP0Hlyf7Pqf5lS5gm7azA9VEYQ=;
        b=FO0ZcKD8zLAuKgUKhmDljyBrYc48p7n0VTpHLEyI4iCp7c5IdN/dxXI/64ly0GHu/o
         MYhyvnuruD60+/7N8QZ8bWo9B3VfBCkG3AwCNYzfIcKMYKp4nPm0qbxHAseW/6dSfyjB
         F+6Ws60CtHl8QYtAxBjOuukOQbj34DfGHRPNr68b0cJhNF0dqC+khK5Y66DuKY+U8JVq
         vpL6hyEVslhMo5a+KToqUYiN+hmY9TVnRc+1Q+aICIBsn/ccrRNb7Pr7LomF0SsPGPPU
         15OyAALHs6EceimTi7kT5c1PH8EEIIQAPcUvEtaoz9X9v9jRfGlhg+0dXweUA4fRG4ER
         cmZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=I6tvXcyWMOlmBE2vfqP0Hlyf7Pqf5lS5gm7azA9VEYQ=;
        b=GC+46HH5kyuXJdU+B160tsLRkjpGBvmY9xRKFogpHDTw9Dd1ayzubwPfXDJr1JsiOt
         Chiee9VYPtwbSKT28+zSgFjYELV9NdmzoBIjsKHQNO71r8eQDcYoR35rMj1H76j1+GUQ
         IU+A1JfT6pdrDReNHkoRIj9IeI+eD2A6MljehGQdAH2aD1GY9/GQCSe6htbQA+M5hTPz
         fVbXUEuFaffuVE70r1miQblexII+UtMAUUzNPX+PiafviDJqRTd4tsSf2+PttyYtAC/v
         a/pZuFC6aXXvNhhCwqPj53+GSTanKwKYUOzN/52oU40ZyYYvvES8o0p7HmHDSPPddfOC
         yDgA==
X-Gm-Message-State: ACrzQf20sp9n1zyCM3oRJ2YFMwShKTR6bkh8MJvzwstN3/Q8jP+fD1is
	RFgAKUZOWEF76KhhEhvGr2aKrylr85jP9E3vJaaKB/ZI
X-Google-Smtp-Source: AMsMyM4vmVOTItpM3pno1d8IhXom4nGEhV5qPs96DsFonilKz2DMFAePyLfQDiKmT63m+vF0tQQvJ8Ew6BexVzH63m4=
X-Received: by 2002:a1f:32c8:0:b0:3a2:914f:b490 with SMTP id
 y191-20020a1f32c8000000b003a2914fb490mr4084700vky.2.1666193293291; Wed, 19
 Oct 2022 08:28:13 -0700 (PDT)
MIME-Version: 1.0
References: <20221018142346.52272-1-Henry.Wang@arm.com> <20221018142346.52272-3-Henry.Wang@arm.com>
In-Reply-To: <20221018142346.52272-3-Henry.Wang@arm.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Wed, 19 Oct 2022 16:28:01 +0100
Message-ID: <CAFLBxZZ59zkuNJM1vQSv_Syv8i0Q_dAFk0p-JXY4oFs0cCUSnQ@mail.gmail.com>
Subject: Policy: A release acks for the release manager's patches (was Re:
 [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init())
To: Henry Wang <Henry.Wang@arm.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="0000000000005fb54005eb64dbae"

--0000000000005fb54005eb64dbae
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 18, 2022 at 3:24 PM Henry Wang <Henry.Wang@arm.com> wrote:

> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> when the domain is created. Considering the worst case of page tables
> which requires 6 P2M pages as the two pages will be consecutive but not
> necessarily in the same L3 page table and keep a buffer, populate 16
> pages as the default value to the P2M pages pool in p2m_init() at the
> domain creation stage to satisfy the GICv2 requirement. For GICv3, the
> above-mentioned P2M mapping is not necessary, but since the allocated
> 16 pages here would not be lost, hence populate these pages
> unconditionally.
>
> With the default 16 P2M pages populated, there would be a case that
> failures would happen in the domain creation with P2M pages already in
> use. To properly free the P2M for this case, firstly support the
> optionally preemption of p2m_teardown(), then call p2m_teardown() and
> p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
> As non-preemptive p2m_teardown() should only return 0, use a
> BUG_ON to confirm that.
>
> Since p2m_final_teardown() is called either after
> domain_relinquish_resources() where relinquish_p2m_mapping() has been
> called, or from failure path of domain_create()/arch_domain_create()
> where mappings that require p2m_put_l3_page() should never be created,
> relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
> in-code comments to refer this.
>
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M
> pool")
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>


Henry brought this patch to my attention because it needs a release ack,
but it doesn't seem proper for Henry to be the one to release-ack his own
patches. :-)

I propose that a suitable rule would be:

"If the release manager themselves have submitted a patch which needs a
release ack, then the patch needs a release ack from one of the Committers
who is not involved in the patch."

Given the time-critical nature of this patch, I propose that we adopt the
rule as an expediency now, and we can discuss afterwards whether to make it
permanent.

With that in mind, it looks like this patch is critical for fixing a
release issue; it's in core code, but has also has a lot of scrutiny.  So
with that in mind:

Release-acked-by: George Dunlap <george.dunlap@citrix.com>

--0000000000005fb54005eb64dbae
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Oct 18, 2022 at 3:24 PM Henry=
 Wang &lt;<a href=3D"mailto:Henry.Wang@arm.com" target=3D"_blank">Henry.Wan=
g@arm.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 =
area<br>
when the domain is created. Considering the worst case of page tables<br>
which requires 6 P2M pages as the two pages will be consecutive but not<br>
necessarily in the same L3 page table and keep a buffer, populate 16<br>
pages as the default value to the P2M pages pool in p2m_init() at the<br>
domain creation stage to satisfy the GICv2 requirement. For GICv3, the<br>
above-mentioned P2M mapping is not necessary, but since the allocated<br>
16 pages here would not be lost, hence populate these pages<br>
unconditionally.<br>
<br>
With the default 16 P2M pages populated, there would be a case that<br>
failures would happen in the domain creation with P2M pages already in<br>
use. To properly free the P2M for this case, firstly support the<br>
optionally preemption of p2m_teardown(), then call p2m_teardown() and<br>
p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().<br=
>
As non-preemptive p2m_teardown() should only return 0, use a<br>
BUG_ON to confirm that.<br>
<br>
Since p2m_final_teardown() is called either after<br>
domain_relinquish_resources() where relinquish_p2m_mapping() has been<br>
called, or from failure path of domain_create()/arch_domain_create()<br>
where mappings that require p2m_put_l3_page() should never be created,<br>
relinquish_p2m_mapping() is not added in p2m_final_teardown(), add<br>
in-code comments to refer this.<br>
<br>
Fixes: cbea5a1149ca (&quot;xen/arm: Allocate and free P2M pages from the P2=
M pool&quot;)<br>
Suggested-by: Julien Grall &lt;<a href=3D"mailto:jgrall@amazon.com" target=
=3D"_blank">jgrall@amazon.com</a>&gt;<br>
Signed-off-by: Henry Wang &lt;<a href=3D"mailto:Henry.Wang@arm.com" target=
=3D"_blank">Henry.Wang@arm.com</a>&gt;<br></blockquote><div><br></div><div>=
<br></div><div>Henry brought this patch to my attention because it needs a =
release ack, but it doesn&#39;t seem proper for Henry to be the one to rele=
ase-ack his own patches. :-)</div><div><br></div><div>I propose that a suit=
able rule would be:</div><div><br></div><div>&quot;If the release manager t=
hemselves have submitted a patch which needs a release ack, then the patch =
needs a release ack from one of the Committers who is not involved in the p=
atch.&quot;</div><div><br></div><div>Given the time-critical nature of this=
 patch, I propose that we adopt the rule as an expediency now, and we can d=
iscuss afterwards whether to make it permanent.</div><div><br></div><div>Wi=
th that in mind, it looks like this patch is critical for fixing a release =
issue; it&#39;s in core code, but has also has a lot of scrutiny.=C2=A0 So =
with that in mind:</div><div><br></div><div>Release-acked-by: George Dunlap=
 &lt;<a href=3D"mailto:george.dunlap@citrix.com">george.dunlap@citrix.com</=
a>&gt;</div><div><br></div><div><br></div></div></div>

--0000000000005fb54005eb64dbae--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 15:40:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 15:40:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425887.673989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBAZ-00085r-Fj; Wed, 19 Oct 2022 15:39:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425887.673989; Wed, 19 Oct 2022 15:39:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBAZ-00085k-Bl; Wed, 19 Oct 2022 15:39:47 +0000
Received: by outflank-mailman (input) for mailman id 425887;
 Wed, 19 Oct 2022 15:39:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CpyO=2U=gmail.com=koct9i@srs-se1.protection.inumbo.net>)
 id 1olBAY-00085b-1X
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 15:39:46 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4043f155-4fc4-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 17:39:43 +0200 (CEST)
Received: by mail-lf1-x12b.google.com with SMTP id bu25so28843161lfb.3
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 08:39:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4043f155-4fc4-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=RK4xoOZYyfRDB1X5WsmKkjIdK20um88SdCRg+FscnVc=;
        b=bwXkNkcQOjN0WxRn+TzKaVD2WFrlkFnUl5MFCBpmyQ8g/h4IA/oJp3WpSpIXvkypbV
         Bh21BUf04UYYoe+ca2ZDJ5zATVRCo3yyhph/FOw9+p22jMUp6JNRpkuZNajpZ9SbICU3
         rVs1dmz7a3UlIGSq0j3pEHGzXS8HveSXsKGciz0ORD4LA7isR+5hAX2AEtGESPDguXKY
         TcGtrwKZzH1OYzOL4ZTwug6MmWqsPlAtrQxhwVjGKSK7uUX77D0yIrOMmkXU3HsUa6+a
         IkCbpvyOEsoeqSNcO3Eo5mWDoKPSBLZ7XtJDlBIdkB9y4eSaxSLnqVnryOWGQx69az2D
         aqPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=RK4xoOZYyfRDB1X5WsmKkjIdK20um88SdCRg+FscnVc=;
        b=NP9fxizAlfJqKLvxIl0QBOzOXarkSmotxFkgjGor7C1iErwGXxi9anhKGpvut8Bmtt
         NeG++SKFVCRqUktwtUtbVcZD7XhFX90/MEa6C9ZBEkzR2SmB9dV79jGYCErnQ3Di+/Rt
         rsBqf9Pfor2WZfXl3UyZ483JvryfoJwk1u1He1pThnTnqhpvOfMuOls2aTn1e4pi234J
         n81EfFusUtCnxt5uVAq0OV3z8Ys4OTiENUBvc8Rkx96HmNTGUJTwqPPzgSnTcqVYYaLV
         /DfY5kdQvg4BiqbCAwiqMMQEfEewHW5NeNKsfKRjxwewVRjEByrNzoQotJ0mk2VCHnRb
         Fl/w==
X-Gm-Message-State: ACrzQf3aRu4mk5Qlcuq3p1G7I7dONE9z8/4FFgz3ygU8rCBvSkfUzJb2
	rpuARBcCtXrhGTwETi6BdprZRcA9H3nYXwr/OPA=
X-Google-Smtp-Source: AMsMyM5xKMUiaYBkD/HxblJqLfy0suavMVVslmZLPZ8He+oTFu65I1yxfrDbu5z2Ftve+UdHzwlPNLyZWKVu0U/E85Y=
X-Received: by 2002:a19:ee10:0:b0:4a3:fa6f:e66d with SMTP id
 g16-20020a19ee10000000b004a3fa6fe66dmr3150133lfb.596.1666193982344; Wed, 19
 Oct 2022 08:39:42 -0700 (PDT)
MIME-Version: 1.0
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
 <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com> <1c69ff97-831d-ece3-7a52-bb7659fc8dd4@virtuozzo.com>
In-Reply-To: <1c69ff97-831d-ece3-7a52-bb7659fc8dd4@virtuozzo.com>
From: Konstantin Khlebnikov <koct9i@gmail.com>
Date: Wed, 19 Oct 2022 18:39:30 +0300
Message-ID: <CALYGNiMMo7aqgQrcHBWaoU7O9Lpk1qCD2CmRJ5mw+-pFJwFajQ@mail.gmail.com>
Subject: Re: [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to
 the rest of the kernel
To: "Denis V. Lunev" <den@virtuozzo.com>
Cc: Alexander Atanasov <alexander.atanasov@virtuozzo.com>, kernel@openvz.org, 
	kernel test robot <lkp@intel.com>, "Michael S . Tsirkin" <mst@redhat.com>, David Hildenbrand <david@redhat.com>, 
	Wei Liu <wei.liu@kernel.org>, Nadav Amit <namit@vmware.com>, pv-drivers@vmware.com, 
	Jason Wang <jasowang@redhat.com>, virtualization@lists.linux-foundation.org, 
	"K. Y. Srinivasan" <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, 
	Stephen Hemminger <sthemmin@microsoft.com>, Dexuan Cui <decui@microsoft.com>, 
	linux-hyperv@vger.kernel.org, Juergen Gross <jgross@suse.com>, 
	Stefano Stabellini <sstabellini@kernel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="00000000000071d4a105eb6504a3"

--00000000000071d4a105eb6504a3
Content-Type: text/plain; charset="UTF-8"

On Wed, 19 Oct 2022 at 14:06, Denis V. Lunev <den@virtuozzo.com> wrote:

> On 10/19/22 12:53, Konstantin Khlebnikov wrote:
> > On Wed, 19 Oct 2022 at 12:57, Alexander Atanasov
> > <alexander.atanasov@virtuozzo.com> wrote:
> >
> >     Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
> >     inflate and deflate the guest memory size but there is no
> >     way to know how much the memory size is changed by them.
> >
> >     Make it possible for the drivers to report the values to mm core.
> >
> >     Display reported InflatedTotal and InflatedFree in /proc/meminfo
> >     and print these values on OOM and sysrq from show_mem().
> >
> >     The two values are the result of the two modes the drivers work
> >     with using adjust_managed_page_count or without.
> >
> >     In earlier versions, there was a notifier for these changes
> >     but after discussion - it is better to implement it in separate
> >     patch series. Since it came out as larger work than initially
> >     expected.
> >
> >     Amount of inflated memory can be used:
> >      - totalram_pages() users working with drivers not using
> >         adjust_managed_page_count
> >      - si_meminfo(..) users can improve calculations
> >      - by userspace software that monitors memory pressure
> >
> >
> > Sorry, I see no reason for that series.
> > Balloon inflation adjusts totalram_pages. That's enough.
> >
> no, they are not at least under some circumstances, f.e.
> virtio balloon does not do that with VIRTIO_BALLOON_F_DEFLATE_ON_OOM
> set
>

> > There is no reason to know the amount of non-existent ballooned memory
> > inside.
> > Management software which works outside should care about that.
> >
> The problem comes at the moment when we are running
> our Linux server inside virtual machine and the customer
> comes with crazy questions "where our memory?".
>

Ok. In this case balloon management is partially inside VM.
I.e. we could report portion of balloon as potentially available memory.

I guess memory pressure could deflate balloon till some threshold set by
external hypervisor.
So, without knowledge about this threshold there is no correct answer about
size of available memory.
Showing just size of balloon doesn't gives much.


>
> > For debugging you could get current balloon size from /proc/vmstat
> > (balloon_inflate - balloon_deflate).
> > Also (I guess) /proc/kpageflags has a bit for that.
> >
> > Anyway it's easy to monitor balloon inflation by seeing changes of
> > total memory size.
> for monitoring - may be. But in order to report total amount
> there is no interface so far.
>
> >
> >     Alexander Atanasov (8):
> >       mm: Make a place for a common balloon code
> >       mm: Enable balloon drivers to report inflated memory
> >       mm: Display inflated memory to users
> >       mm: Display inflated memory in logs
> >       drivers: virtio: balloon - report inflated memory
> >       drivers: vmware: balloon - report inflated memory
> >       drivers: hyperv: balloon - report inflated memory
> >       documentation: create a document about how balloon drivers operate
> >
> >      Documentation/filesystems/proc.rst            |   6 +
> >      Documentation/mm/balloon.rst                  | 138
> >     ++++++++++++++++++
> >      MAINTAINERS                                   |   4 +-
> >      arch/powerpc/platforms/pseries/cmm.c          |   2 +-
> >      drivers/hv/hv_balloon.c                       |  12 ++
> >      drivers/misc/vmw_balloon.c                    |   3 +-
> >      drivers/virtio/virtio_balloon.c               |   7 +-
> >      fs/proc/meminfo.c                             |  10 ++
> >      .../linux/{balloon_compaction.h => balloon.h} |  18 ++-
> >      lib/show_mem.c                                |   8 +
> >      mm/Makefile                                   |   2 +-
> >      mm/{balloon_compaction.c => balloon.c}        |  19 ++-
> >      mm/migrate.c                                  |   1 -
> >      mm/vmscan.c                                   |   1 -
> >      14 files changed, 213 insertions(+), 18 deletions(-)
> >      create mode 100644 Documentation/mm/balloon.rst
> >      rename include/linux/{balloon_compaction.h => balloon.h} (91%)
> >      rename mm/{balloon_compaction.c => balloon.c} (94%)
> >
> >     v4->v5:
> >      - removed notifier
> >      - added documentation
> >      - vmware update after op is done , outside of the mutex
> >     v3->v4:
> >      - add support in hyperV and vmware balloon drivers
> >      - display balloon memory in show_mem so it is logged on OOM and
> >     on sysrq
> >     v2->v3:
> >      - added missed EXPORT_SYMBOLS
> >     Reported-by: kernel test robot <lkp@intel.com>
> >      - instead of balloon_common.h just use balloon.h (yes, naming is
> >     hard)
> >      - cleaned up balloon.h - remove from files that do not use it and
> >        remove externs from function declarations
> >     v1->v2:
> >      - reworked from simple /proc/meminfo addition
> >
> >     Cc: Michael S. Tsirkin <mst@redhat.com>
> >     Cc: David Hildenbrand <david@redhat.com>
> >     Cc: Wei Liu <wei.liu@kernel.org>
> >     Cc: Nadav Amit <namit@vmware.com>
> >     Cc: pv-drivers@vmware.com
> >     Cc: Jason Wang <jasowang@redhat.com>
> >     Cc: virtualization@lists.linux-foundation.org
> >     Cc: "K. Y. Srinivasan" <kys@microsoft.com>
> >     Cc: Haiyang Zhang <haiyangz@microsoft.com>
> >     Cc: Stephen Hemminger <sthemmin@microsoft.com>
> >     Cc: Dexuan Cui <decui@microsoft.com>
> >     Cc: linux-hyperv@vger.kernel.org
> >     Cc: Juergen Gross <jgross@suse.com>
> >     Cc: Stefano Stabellini <sstabellini@kernel.org>
> >     Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >     Cc: xen-devel@lists.xenproject.org
> >
> >     base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> >     --
> >     2.31.1
> >
>
>

--00000000000071d4a105eb6504a3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, 19 Oct 2022 at 14:06, Denis V=
. Lunev &lt;<a href=3D"mailto:den@virtuozzo.com">den@virtuozzo.com</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/19/=
22 12:53, Konstantin Khlebnikov wrote:<br>
&gt; On Wed, 19 Oct 2022 at 12:57, Alexander Atanasov <br>
&gt; &lt;<a href=3D"mailto:alexander.atanasov@virtuozzo.com" target=3D"_bla=
nk">alexander.atanasov@virtuozzo.com</a>&gt; wrote:<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Currently balloon drivers (Virtio,XEN, HyperV, VMWa=
re, ...)<br>
&gt;=C2=A0 =C2=A0 =C2=A0inflate and deflate the guest memory size but there=
 is no<br>
&gt;=C2=A0 =C2=A0 =C2=A0way to know how much the memory size is changed by =
them.<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Make it possible for the drivers to report the valu=
es to mm core.<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Display reported InflatedTotal and InflatedFree in =
/proc/meminfo<br>
&gt;=C2=A0 =C2=A0 =C2=A0and print these values on OOM and sysrq from show_m=
em().<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0The two values are the result of the two modes the =
drivers work<br>
&gt;=C2=A0 =C2=A0 =C2=A0with using adjust_managed_page_count or without.<br=
>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0In earlier versions, there was a notifier for these=
 changes<br>
&gt;=C2=A0 =C2=A0 =C2=A0but after discussion - it is better to implement it=
 in separate<br>
&gt;=C2=A0 =C2=A0 =C2=A0patch series. Since it came out as larger work than=
 initially<br>
&gt;=C2=A0 =C2=A0 =C2=A0expected.<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Amount of inflated memory can be used:<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- totalram_pages() users working with drivers=
 not using<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 adjust_managed_page_count<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- si_meminfo(..) users can improve calculatio=
ns<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- by userspace software that monitors memory =
pressure<br>
&gt;<br>
&gt;<br>
&gt; Sorry, I see no reason for that series.<br>
&gt; Balloon inflation adjusts totalram_pages. That&#39;s enough.<br>
&gt;<br>
no, they are not at least under some circumstances, f.e.<br>
virtio balloon does not do that with VIRTIO_BALLOON_F_DEFLATE_ON_OOM<br>
set<br></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
&gt; There is no reason to know the amount of non-existent ballooned memory=
 <br>
&gt; inside.<br>
&gt; Management software which works outside should care about that.<br>
&gt;<br>
The problem comes at the moment when we are running<br>
our Linux server inside virtual machine and the customer<br>
comes with crazy questions &quot;where our memory?&quot;.<br></blockquote><=
div><br></div><div>Ok. In this case balloon management is partially inside =
VM.</div><div>I.e. we could report portion of balloon as potentially availa=
ble memory.</div><div><br></div><div>I guess memory pressure could deflate =
balloon till some threshold set by external hypervisor.</div><div>So, witho=
ut knowledge about this threshold there is no correct answer about size of =
available memory.<br></div><div>Showing just size of balloon doesn&#39;t gi=
ves much.</div><div>=C2=A0<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">
<br>
&gt; For debugging you could get current=C2=A0balloon=C2=A0size from /proc/=
vmstat <br>
&gt; (balloon_inflate -=C2=A0balloon_deflate).<br>
&gt; Also (I guess) /proc/kpageflags has a bit for that.<br>
&gt;<br>
&gt; Anyway it&#39;s easy to monitor balloon=C2=A0inflation by seeing chang=
es of <br>
&gt; total memory size.<br>
for monitoring - may be. But in order to report total amount<br>
there is no interface so far.<br>
<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Alexander Atanasov (8):<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 mm: Make a place for a common balloon code<b=
r>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 mm: Enable balloon drivers to report inflate=
d memory<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 mm: Display inflated memory to users<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 mm: Display inflated memory in logs<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 drivers: virtio: balloon - report inflated m=
emory<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 drivers: vmware: balloon - report inflated m=
emory<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 drivers: hyperv: balloon - report inflated m=
emory<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 documentation: create a document about how b=
alloon drivers operate<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0Documentation/filesystems/proc.rst=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 +<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0Documentation/mm/balloon.rst=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 138<br>
&gt;=C2=A0 =C2=A0 =C2=A0++++++++++++++++++<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0MAINTAINERS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A04 +-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0arch/powerpc/platforms/pseries/cmm.c=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0drivers/hv/hv_balloon.c=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 12 ++=
<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0drivers/misc/vmw_balloon.c=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A03 +-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0drivers/virtio/virtio_balloon.c=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A07 +-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0fs/proc/meminfo.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0|=C2=A0 10 ++<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0.../linux/{balloon_compaction.h =3D&gt; ballo=
on.h} |=C2=A0 18 ++-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0lib/show_mem.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 |=C2=A0 =C2=A08 +<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0mm/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0mm/{balloon_compaction.c =3D&gt; balloon.c}=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 19 ++-<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0mm/migrate.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 |=C2=A0 =C2=A01 -<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0mm/vmscan.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A01 -<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A014 files changed, 213 insertions(+), 18 delet=
ions(-)<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0create mode 100644 Documentation/mm/balloon.r=
st<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0rename include/linux/{balloon_compaction.h =
=3D&gt; balloon.h} (91%)<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0rename mm/{balloon_compaction.c =3D&gt; ballo=
on.c} (94%)<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0v4-&gt;v5:<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- removed notifier<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- added documentation<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- vmware update after op is done , outside of=
 the mutex<br>
&gt;=C2=A0 =C2=A0 =C2=A0v3-&gt;v4:<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- add support in hyperV and vmware balloon dr=
ivers<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- display balloon memory in show_mem so it is=
 logged on OOM and<br>
&gt;=C2=A0 =C2=A0 =C2=A0on sysrq<br>
&gt;=C2=A0 =C2=A0 =C2=A0v2-&gt;v3:<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- added missed EXPORT_SYMBOLS<br>
&gt;=C2=A0 =C2=A0 =C2=A0Reported-by: kernel test robot &lt;<a href=3D"mailt=
o:lkp@intel.com" target=3D"_blank">lkp@intel.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- instead of balloon_common.h just use balloo=
n.h (yes, naming is<br>
&gt;=C2=A0 =C2=A0 =C2=A0hard)<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- cleaned up balloon.h - remove from files th=
at do not use it and<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0remove externs from function declarati=
ons<br>
&gt;=C2=A0 =C2=A0 =C2=A0v1-&gt;v2:<br>
&gt;=C2=A0 =C2=A0 =C2=A0=C2=A0- reworked from simple /proc/meminfo addition=
<br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Michael S. Tsirkin &lt;<a href=3D"mailto:mst@re=
dhat.com" target=3D"_blank">mst@redhat.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: David Hildenbrand &lt;<a href=3D"mailto:david@r=
edhat.com" target=3D"_blank">david@redhat.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Wei Liu &lt;<a href=3D"mailto:wei.liu@kernel.or=
g" target=3D"_blank">wei.liu@kernel.org</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Nadav Amit &lt;<a href=3D"mailto:namit@vmware.c=
om" target=3D"_blank">namit@vmware.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: <a href=3D"mailto:pv-drivers@vmware.com" target=
=3D"_blank">pv-drivers@vmware.com</a><br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Jason Wang &lt;<a href=3D"mailto:jasowang@redha=
t.com" target=3D"_blank">jasowang@redhat.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: <a href=3D"mailto:virtualization@lists.linux-fo=
undation.org" target=3D"_blank">virtualization@lists.linux-foundation.org</=
a><br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: &quot;K. Y. Srinivasan&quot; &lt;<a href=3D"mai=
lto:kys@microsoft.com" target=3D"_blank">kys@microsoft.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Haiyang Zhang &lt;<a href=3D"mailto:haiyangz@mi=
crosoft.com" target=3D"_blank">haiyangz@microsoft.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Stephen Hemminger &lt;<a href=3D"mailto:sthemmi=
n@microsoft.com" target=3D"_blank">sthemmin@microsoft.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Dexuan Cui &lt;<a href=3D"mailto:decui@microsof=
t.com" target=3D"_blank">decui@microsoft.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: <a href=3D"mailto:linux-hyperv@vger.kernel.org"=
 target=3D"_blank">linux-hyperv@vger.kernel.org</a><br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Juergen Gross &lt;<a href=3D"mailto:jgross@suse=
.com" target=3D"_blank">jgross@suse.com</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Stefano Stabellini &lt;<a href=3D"mailto:sstabe=
llini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: Oleksandr Tyshchenko &lt;<a href=3D"mailto:olek=
sandr_tyshchenko@epam.com" target=3D"_blank">oleksandr_tyshchenko@epam.com<=
/a>&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0Cc: <a href=3D"mailto:xen-devel@lists.xenproject.or=
g" target=3D"_blank">xen-devel@lists.xenproject.org</a><br>
&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc7=
80<br>
&gt;=C2=A0 =C2=A0 =C2=A0-- <br>
&gt;=C2=A0 =C2=A0 =C2=A02.31.1<br>
&gt;<br>
<br>
</blockquote></div></div>

--00000000000071d4a105eb6504a3--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 15:49:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 15:49:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425894.674000 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBKE-0001EB-Fd; Wed, 19 Oct 2022 15:49:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425894.674000; Wed, 19 Oct 2022 15:49:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBKE-0001E4-Cd; Wed, 19 Oct 2022 15:49:46 +0000
Received: by outflank-mailman (input) for mailman id 425894;
 Wed, 19 Oct 2022 15:49:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rFyQ=2U=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olBKC-0001Dy-4C
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 15:49:44 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4ebf165-4fc5-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 17:49:42 +0200 (CEST)
Received: from MW4PR03CA0170.namprd03.prod.outlook.com (2603:10b6:303:8d::25)
 by DS7PR12MB6070.namprd12.prod.outlook.com (2603:10b6:8:9e::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct
 2022 15:49:39 +0000
Received: from CO1NAM11FT038.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:8d:cafe::2e) by MW4PR03CA0170.outlook.office365.com
 (2603:10b6:303:8d::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend
 Transport; Wed, 19 Oct 2022 15:49:38 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT038.mail.protection.outlook.com (10.13.174.231) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 19 Oct 2022 15:49:38 +0000
Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 10:49:33 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com
 (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 10:49:30 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 19 Oct 2022 10:49:29 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4ebf165-4fc5-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P++uulnqIbBhnm/TQqfw6Tlg+HOGrB2PrP0QYJJrhpEGew+ugj45KnDrMTkwfzT8puH9ZPHaKtnFCeKm7JiY9cn/vBmvzgDDZV3vMcG5Nos23atgCwciu6xADgK1Cv90Hfa8wvxM6EQGFABmBicWIOg98zDvGX2sqKU5TLAtvwSdp8cQr2mNuvTijOfcXL870YR4RHH2xjpoy7g3oZgwI1ucONL9FoM/8y7XaFGJvb5E8Cxn/9U98oqxAwxsuOjct6KS3068aVqtUmYdScSj2gKnrg8VDMY9EHzxfQ4yqdoxtOCNpjGX5fzPaEr/agQsMMW9NXUu2uAxeltCOSllJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BeGba4M/2lBAEih9NOwNpf78NbOThvzF8ia69VsVhwA=;
 b=oX5oqsoegXhRUTIkCqiqFSskDTj/ReY+BOuehHoILd+PDdMRf60sZZbNAV25kg99VWMqbf3xBKmZ1VTdABTssxTV+b2h+o2Uh7bXI/PL8WtMqfGc7jvKfMiWCeYJHkfMgtZkNaI81ZHFFuNIluX9tmo7sHrAE+RJ1un2EKsuibTqNS4SgaxBinKZl99eg/Eu3NdQbOczVyp4Wc7BBUSlsVYq4B9MoxfL9Ws8e5RwZBsSrR81lCvUtdZgMtFxkeSZrmxqO7SxaUyWCkaprCnbv5UdzXE4ONz938qDfMciCbhBBkEtWI/tJeqdk/ti7TY4kBetRXP64Gc8CzHMK1JfBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BeGba4M/2lBAEih9NOwNpf78NbOThvzF8ia69VsVhwA=;
 b=WR0LQDb3kFCY2eE+77UKOmLXnOrvkrYC31cp/q03QhGoPjB9OIxtSA3UfyihxZz6geCHJEKxgnNmWGHvSDx9trIppUW76lFkTDaALgv3MQIJ275e4I8srPxDwQmEAPUKqWF8oPrkQPELmWO+7HYBMApSWXxM3tz85wNujR/c6nU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <745ed2f6-4193-b7a3-c3a0-455ef8c24b66@amd.com>
Date: Wed, 19 Oct 2022 17:49:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [XEN v1] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>
References: <20221019143620.45814-1-ayankuma@amd.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221019143620.45814-1-ayankuma@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT038:EE_|DS7PR12MB6070:EE_
X-MS-Office365-Filtering-Correlation-Id: d4bd8321-3f94-4283-691b-08dab1e9876e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Df2uoELUOG2tPtlDVg5xtz6XZKwh1HCW8ebIw14XLtSuyXTdJVsSdBUACgkbC/r9CST/ETsAH1x9bBdSIc9hcjvuT2Drv4BPpWqcghLiWJ/69ZrRDCoENMOoB7irnUAXl0k543rOcAU/hx3l0Ko8nj2rrdd18VMV4Tmx7+ZeMcg2bQiSQiZq5UCUk4qRw1ElqSwQU0jgxrgirG3foI+BkKAny0OfruVkzUzERH5vPSJrpiegQBad22eM0BjpYbPGfRMOmKrbDHJtkGxohNEHKtcpTqhdgBovZ4OwI+FcB5LKaylQbqUkc6FwBLH2352D71HIeGSUhO2lM89Mm7yNIuh1mCWzbk4ajqQO6kAXrmblHpYgovr0vEULjjfJ2oZFtFnaoPFUtsmaaJEo22Ih8sBNv6Hq98644p3plHsnN+8D3QtYF2zYReEkxcfKGepXuP0ZmlKqzhJUS2lpkBQVjkaGJYIT8umtAq0jL4a2EXwkVSnvwVaDkcSGYUh1uI0l0LYvIZ6GGrD1TxK3/OmgiezEB8nLN/pIrsh5sSk1tyGwa8g14AKCDvdVre+NeuhlRu0wbnMxoI+MkdIuwvfNZNzY1LyTlpD9Z4ZfgsLVXQrZ0a1KgYfInbtiywZbRg94EVfqSzsqT7MfOO3KjI2ZH8wUaNgSL+PSs/7hbs5r3zV5FMb82IxLpofh10ngnonBNGsfgvHgZGcMCX1ViZx6G8RPTy8cigyuqmL9q2Q0XWGGCsmAvp54y1d5sgd77HQxQ3JcfMfM5PjK0yxBEUkwfjb0x0f3KDJQ2cGPwR+nfsYyCpDkYbfCcUNLWsL0J1DdkqhXpSQCRcBfYrPQ5Nj/BA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(36756003)(31696002)(336012)(36860700001)(86362001)(47076005)(82740400003)(44832011)(2906002)(5660300002)(8936002)(54906003)(426003)(186003)(2616005)(81166007)(356005)(83380400001)(16576012)(70206006)(478600001)(53546011)(4326008)(70586007)(26005)(31686004)(110136005)(316002)(82310400005)(40480700001)(8676002)(40460700003)(41300700001)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 15:49:38.2284
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d4bd8321-3f94-4283-691b-08dab1e9876e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT038.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6070

Hi Ayan,

On 19/10/2022 16:36, Ayan Kumar Halder wrote:
> 
> 
> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
> IGROUPR) is relevant only when the guests run in secure/non-secure mode.
> As Xen does not implement security extensions for guests, so the registers
> are emulated as read as zero/write ignore.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
> 
> Observed the issue while running Zephyr on R52.
> Also, found that KVM has similar behaviour.
> 
>  xen/arch/arm/include/asm/gic.h | 2 ++
>  xen/arch/arm/vgic-v3.c         | 4 ++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
> index 76e3fa5dc4..998dd62651 100644
> --- a/xen/arch/arm/include/asm/gic.h
> +++ b/xen/arch/arm/include/asm/gic.h
> @@ -48,6 +48,8 @@
>  #define GICD_ICFGR1     (0xC04)
>  #define GICD_ICFGR2     (0xC08)
>  #define GICD_ICFGRN     (0xCFC)
> +#define GICD_IGRPMODR   (0xD00)
> +#define GICD_IGRPMODRN  (0xD7C)

These registers are GICv3 specific and as such should be defined
in arch/arm/include/asm/gic_v3_defs.h.

~Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 15:57:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 15:57:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425902.674016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBRC-0002hs-8m; Wed, 19 Oct 2022 15:56:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425902.674016; Wed, 19 Oct 2022 15:56:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBRC-0002hl-5w; Wed, 19 Oct 2022 15:56:58 +0000
Received: by outflank-mailman (input) for mailman id 425902;
 Wed, 19 Oct 2022 15:56:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olBRB-0002hd-46
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 15:56:57 +0000
Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com
 [2a00:1450:4864:20::334])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a74e0162-4fc6-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 17:56:55 +0200 (CEST)
Received: by mail-wm1-x334.google.com with SMTP id iv17so13223019wmb.4
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 08:56:55 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 r12-20020adff10c000000b00225239d9265sm14250557wro.74.2022.10.19.08.56.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 08:56:53 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a74e0162-4fc6-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=hVupMUX+AbKGeudOf3VM2f3d4o9emAy/RsXvFXsgs1k=;
        b=Hoz1h64VhbNtpfHkg2GnQ43QHYEysX6x8fWmjZbb3LYmUCk3yEE2xhj57LzJqjNNEm
         l8X3Q2z2FN8ZK7xzhI4P/lZN8isM5sv++uF0MDnOx9+3GYx8mOd0X7Ruiug7ey05Zu9A
         0IQBNwMILplU/EC+FQw6L9mb7kh38zH/oj9dj4gVqP2l7i7u/N9o4I4wcJ8p1sHMw/aA
         jm670VNGNkZEo9Ay3FFC5XIb5wv+jPAnWxc82or4Yct/C7xiHxGLurgcuSmOCnqeY2LK
         sLfSQ/iYLW5Bpp6jjiDPyx/u6AyEm7w/3J4+x5Z4Kh8qRiQQxeC0sxYUTB4LAL/0yoxA
         mGgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=hVupMUX+AbKGeudOf3VM2f3d4o9emAy/RsXvFXsgs1k=;
        b=DiY6JdpcRIP8FC+dKUfyJS1RICbQigQaZNjfvGkUpmnyzfSXfY9W26LoYCb7bDSsWt
         7swUclvoT6nXFAEWEab/0nVP2arkuNCLt4/N0TdAnwd3vTT3Ul4FtjHiXY6CxDe47ru3
         GiJ60UoDtdpZOJAAjFihE+xfoi0dzYnn1ir/X5K2ntW88D3b+xwUXzRS7C2DmWrDcfmk
         ESKewXLqQf21mmk9nLVRev++8sl21UYCalfm41Y2n3ZbnD4rJV23eiA2iqDnspxpSEqD
         xrawPXVBPD4oaHLAEmKgSuyVDy4dqnvOJthJzRIpzrKcoldYxMvSMPnFBOrRw6mrlfRz
         6Zeg==
X-Gm-Message-State: ACrzQf2e3DRuM+6pyfzm1bdJCE6pInAL2V6MJgTbWTl+K06ugoOcsPlv
	t2sJfj7f3EOm+eZSNEScPS8=
X-Google-Smtp-Source: AMsMyM7RcuUsQvVHd7FHqJ0owLc1kucQ4TcSIdeJKxzL9l0FF0hwuPxWV4qgGZiNjL+DS4GtbOU2DA==
X-Received: by 2002:a05:600c:3d8a:b0:3c6:f241:cb36 with SMTP id bi10-20020a05600c3d8a00b003c6f241cb36mr6231312wmb.115.1666195014489;
        Wed, 19 Oct 2022 08:56:54 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <1fe17e03-dd7b-b705-4730-7b8556af014b@xen.org>
Date: Wed, 19 Oct 2022 16:56:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields
 out of XenIOState
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-5-vikram.garhwal@amd.com>
Organization: Xen Project
In-Reply-To: <20221015050750.4185-5-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> In preparation to moving most of xen-hvm code to an arch-neutral location, move:
> - shared_vmport_page
> - log_for_dirtybit
> - dirty_bitmap
> - suspend
> - wakeup
> 
> out of XenIOState struct as these are only used on x86, especially the ones
> related to dirty logging.
> Updated XenIOState can be used for both aarch64 and x86.
> 
> Also, remove free_phys_offset as it was unused.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Reviewed-by: Paul Durrant <paul@xen.org>




From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:00:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:00:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425908.674027 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBUU-0004eQ-Nd; Wed, 19 Oct 2022 16:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425908.674027; Wed, 19 Oct 2022 16:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBUU-0004eJ-KH; Wed, 19 Oct 2022 16:00:22 +0000
Received: by outflank-mailman (input) for mailman id 425908;
 Wed, 19 Oct 2022 16:00:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olBUT-0004eD-VY
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:00:21 +0000
Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com
 [2a00:1450:4864:20::333])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 221effb9-4fc7-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 18:00:21 +0200 (CEST)
Received: by mail-wm1-x333.google.com with SMTP id y10so13241976wma.0
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 09:00:21 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 t21-20020a7bc3d5000000b003b4a699ce8esm359817wmj.6.2022.10.19.09.00.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 09:00:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 221effb9-4fc7-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=hVupMUX+AbKGeudOf3VM2f3d4o9emAy/RsXvFXsgs1k=;
        b=JPTArh3Fo4mWtWDttlA0ClC01c7R8sZVod1y+p1Vsv9eXhEmp7db4MDO3syoY38G8y
         6THKAaVIYgz0zUEhaoeCW5TIff2CcMwjO5dz4MuXHAOGz+xjc9ECk+MIuGrooHCDJ7k9
         icRRACR79bQCsajRphZgSqapgH7ZFXEQ++sgb6shptuPXECUSxuJnXTs1G2ZMVKQzT8c
         2dxBLtpkSRdMO7irWPyXajs8V+kmrUQKU9hh8lFqeRBWabbaFRECGxaorFxl95RgrNag
         74fEYSmWbmQwEnhmnA+Jwk/P3uNf36vaJIEj7d/qffkS2H0X7KgtxGWL91D1j6EvvipS
         J9dA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=hVupMUX+AbKGeudOf3VM2f3d4o9emAy/RsXvFXsgs1k=;
        b=F273JFbHaLKhJLvbOY3HPBZfTUDlkDF/D6YI9VuJ7B+ui6KvVDdq6jEDts0CiuMAUQ
         /SkpcDCXBmvD88+Vy4A+PjuteJzguHmiYw8JF+/dWZiuxj5vVKUSgpBAw52Oj5diiraF
         UZE/oRWNUd2TfTfAIJkDvT2lAeR9gQod97pR2H/CJGZYZVQyLEoPLSAZ4Sormkxkrv/T
         QjZO644Di+bciGah2x/wcdRIAxQiYTTLrb+8ruP8I5mU1yGqgQ+LX5uqeQfNpd3nN1kk
         e4duFCnb45+UOWrf+SYKoh8W9/ePp8cgWnNl81eOe4v9yX8c26qKLMyuVe2XdOeJRkDO
         6V8g==
X-Gm-Message-State: ACrzQf0wySDu/E7oWhWZe1jgbgSuRV9E/v7yklFfU6bySaQvT9HJMQgz
	8rj2VnL5MjYSpE3EVN92fT4=
X-Google-Smtp-Source: AMsMyM56wfRKb1W4RRWfr9a44/7FKXWWZbg3jEH/nJzz4jN0Z367Bev8MYCgZc5kmwy9tTq2PTMK2Q==
X-Received: by 2002:a05:600c:3148:b0:3c6:eefa:fa5 with SMTP id h8-20020a05600c314800b003c6eefa0fa5mr6640215wmo.88.1666195219222;
        Wed, 19 Oct 2022 09:00:19 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <6ccbd834-b7c5-3209-008e-a2ede8427986@xen.org>
Date: Wed, 19 Oct 2022 17:00:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields
 out of XenIOState
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-5-vikram.garhwal@amd.com>
Content-Language: en-US
Organization: Xen Project
In-Reply-To: <20221015050750.4185-5-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> In preparation to moving most of xen-hvm code to an arch-neutral location, move:
> - shared_vmport_page
> - log_for_dirtybit
> - dirty_bitmap
> - suspend
> - wakeup
> 
> out of XenIOState struct as these are only used on x86, especially the ones
> related to dirty logging.
> Updated XenIOState can be used for both aarch64 and x86.
> 
> Also, remove free_phys_offset as it was unused.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Reviewed-by: Paul Durrant <paul@xen.org>



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:09:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425914.674039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBdF-0005Mq-J5; Wed, 19 Oct 2022 16:09:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425914.674039; Wed, 19 Oct 2022 16:09:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBdF-0005Mj-GC; Wed, 19 Oct 2022 16:09:25 +0000
Received: by outflank-mailman (input) for mailman id 425914;
 Wed, 19 Oct 2022 16:09:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olBdE-0005Md-CO
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:09:24 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 657e3d95-4fc8-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 18:09:23 +0200 (CEST)
Received: by mail-wr1-x431.google.com with SMTP id bv10so29842937wrb.4
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 09:09:23 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-224.amazon.com. [54.240.197.224])
 by smtp.gmail.com with ESMTPSA id
 d12-20020a05600c34cc00b003b435c41103sm536772wmq.0.2022.10.19.09.09.21
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 09:09:22 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 657e3d95-4fc8-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=/gaivNtOvRrmGFG6RPtNgIZb7CGAKiq1jjE5q+NEHYU=;
        b=cwrXMjtw99DxuvfQpNVOsjORQFtxpP4N7aw5W673k40lx5roGxVPn5LnRPAqpw3HpA
         2K6LE+lZH2DbtOtMGwWXYLrMkOqprxQXXS9f6IWj7sbOY2AVuKDNjJL+QGzXSji1rnrC
         k0k8mLrMRqKzFQ3Y6hhqpqlk62WabsCRp4WAW4ZMTItbMtvKYX23oAH/ETrp5nXYB/WH
         iUVY/87IgTYjiVzascblXfdp65nlqXn+LGUlB0hNiQp9bhapWbBZW+kBl4SvEeC8W+86
         qTcMz19B8zxy4v5XKjywPyZe2LLJrSMpkg8CaPpZDbG8uwEDzRN7gJTzlywi4zK6TPI1
         Es+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=/gaivNtOvRrmGFG6RPtNgIZb7CGAKiq1jjE5q+NEHYU=;
        b=grBG69kIROtyGHS2cieMcdd/FqODNgt6np17iCCsVb66K7rZk5PULHn1SdRfm3vqr2
         0WCQ6rGd/TxlwFw2kUvK2NP5qGR1HLa+5Uw/85OXLJJNZ+/ZrbWPxxqHn8CxkMDW/Eb3
         PxOk7tHMxkgPzD+2uuLDK3WYEO+PM3BgEaLi+qExkKJIiFtMycWTwmfnlaLpfyCdPKKZ
         85kkForisU/wcFvduj9g6nk2d8O0V0xPtU75P1572ZNZWSaA0rJdF3MpJ03tOcDYIpzm
         D7nJby+yXUwbyxnPsM7MZKB0Cv1oxw71WwNiIT4F5yt4PCpqf/np2BV3WGvRHFGR569+
         wvvg==
X-Gm-Message-State: ACrzQf2Qs/MzC8jJiNVeyIqp0ax01qft+kT9+1uolY8X9Vj7nMA0d7Gq
	pjT83ICCqkRZeTNTvGhU1FI=
X-Google-Smtp-Source: AMsMyM7AqcpGVOsCXg9XMM+zrskrCjvD7TOGamHI2Z1R4J3KaR7LgpJ+lBr1vVn8AO35vwlVfZ754Q==
X-Received: by 2002:a5d:58d3:0:b0:22c:e8e4:1461 with SMTP id o19-20020a5d58d3000000b0022ce8e41461mr5783598wrf.227.1666195762924;
        Wed, 19 Oct 2022 09:09:22 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <0cd7b6e5-b20f-6bab-ea7b-65723c16a065@xen.org>
Date: Wed, 19 Oct 2022 17:09:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq
 and arch_xen_set_memory
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-6-vikram.garhwal@amd.com>
Organization: Xen Project
In-Reply-To: <20221015050750.4185-6-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> In preparation to moving most of xen-hvm code to an arch-neutral location,
> move the x86-specific portion of xen_set_memory to arch_xen_set_memory.
> 
> Also move handle_vmport_ioreq to arch_handle_ioreq.
> 
> NOTE: This patch breaks the build. Next patch fixes the build issue.
> Reason behind creating this patch is because there is lot of new code addition
> and pure code movement done for enabling Xen on ARM. Keeping the this patch
> separate is done to make it easier to review.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Reviewed-by: Paul Durrant <paul@xen.org>



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:16:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:16:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425920.674050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBkN-0006qu-9H; Wed, 19 Oct 2022 16:16:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425920.674050; Wed, 19 Oct 2022 16:16:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBkN-0006qn-64; Wed, 19 Oct 2022 16:16:47 +0000
Received: by outflank-mailman (input) for mailman id 425920;
 Wed, 19 Oct 2022 16:16:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olBkM-0006qh-48
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:16:46 +0000
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [2a00:1450:4864:20::42c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ca64eac-4fc9-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 18:16:45 +0200 (CEST)
Received: by mail-wr1-x42c.google.com with SMTP id a10so29885149wrm.12
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 09:16:45 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 h17-20020a05600c315100b003b4a68645e9sm323180wmo.34.2022.10.19.09.16.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 09:16:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ca64eac-4fc9-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=WIgq7KUkYAZufLZT/vJOKCqP4ihn+JSpnSvPKstMd2Y=;
        b=AOOTzFFJZ+yUIMjgdeHf1D7JPZg8t95Tpk6QQ128iQoHJYFSXGZ4qacujs2ESTOisC
         A5QXDcD+360J+dV93ampTlklhgXeKHieLNMAz1Dg0irNgJENEsyPoVaSKP9J3xICpF94
         1uWhLHMUt9oHnaJpDkFVEZefu7sGXaKLNDAyUZFO1rAx9u+jP34xnsalh59QQ9nxyltk
         R69AbDDKwfaqwbKuEzlgY2QLdERmGfwQg4DtZZr1oeAR06ierQY1VXpit3aIvY1Mbj+R
         B6b8Es/lh5tRjquy6f1+5vLnfQGlYD2dU2UNCcb1343tS+O8RXj6ZvVpumfnrbL7eeXE
         tM2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=WIgq7KUkYAZufLZT/vJOKCqP4ihn+JSpnSvPKstMd2Y=;
        b=t/9sg1VJbsC7QEkqXQc0UPrk1Y6NbTrSd3fFalCrcsXIMcasCCtvT8N+j0ugJioLWb
         IhNIeZEtd7JlNFZa72NIzUIK9C9LjRyNdQ3o7DwtlYPeFkyncAdOKo4qHbvRKVhXry4l
         x59fA3BrAtlGw+g+rbXPBBnvxsCErfWCdRJQrqb96AEDxSqfV3Lg2Vinr46wwxs6Dc0h
         nT42ap7nvQ5mftqdICgz06qXokTmfJ3YxHh0rf69zvSCdS+JALOjky48IHxI7kLKKbWm
         ArFErzK89QtHjdQx90gTkxvpajolZOX/UrhZNJmtknoV3zeAEkaebWhtsW2m1B9BG3FA
         aETA==
X-Gm-Message-State: ACrzQf3U0ymMi1nadkNdIURGOPmuEVgg4m7hTbaaFHP2CIKMUYudxiUb
	GKdDEbP54H9eVplX+mSY1bM=
X-Google-Smtp-Source: AMsMyM70BAGn+ITDttNygqHII8IscaYNZml+iS8aG88q+Uj1/vKaPUkqZHfITZl9ve2GqS+zJReXkg==
X-Received: by 2002:a05:6000:78a:b0:22e:4c41:9e36 with SMTP id bu10-20020a056000078a00b0022e4c419e36mr5641977wrb.160.1666196204511;
        Wed, 19 Oct 2022 09:16:44 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org>
Date: Wed, 19 Oct 2022 17:16:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to
 hw/xen/xen-hvm-common.c
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-7-vikram.garhwal@amd.com>
Organization: Xen Project
In-Reply-To: <20221015050750.4185-7-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
[snip]
> +    qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
> +
> +    state->memory_listener = xen_memory_listener;
> +    memory_listener_register(&state->memory_listener, &address_space_memory);
> +
> +    state->io_listener = xen_io_listener;
> +    memory_listener_register(&state->io_listener, &address_space_io);
> +
> +    state->device_listener = xen_device_listener;
> +    QLIST_INIT(&state->dev_list);
> +    device_listener_register(&state->device_listener);
> +

As Julien said, these do not belong here. These are the (current and 
legacy) PV backend setup functions; they most certainly have nothing to 
do with device emulation.

   Paul



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:20:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:20:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425929.674061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBo1-0008Jm-0L; Wed, 19 Oct 2022 16:20:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425929.674061; Wed, 19 Oct 2022 16:20:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olBo0-0008Jf-TC; Wed, 19 Oct 2022 16:20:32 +0000
Received: by outflank-mailman (input) for mailman id 425929;
 Wed, 19 Oct 2022 16:20:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V6HZ=2U=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1olBnz-0008JZ-Mj
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:20:31 +0000
Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com
 [2a00:1450:4864:20::330])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f31ad909-4fc9-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 18:20:30 +0200 (CEST)
Received: by mail-wm1-x330.google.com with SMTP id v11so3254095wmd.1
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 09:20:30 -0700 (PDT)
Received: from [192.168.16.131] (54-240-197-232.amazon.com. [54.240.197.232])
 by smtp.gmail.com with ESMTPSA id
 d9-20020adfe889000000b00223b8168b15sm14188174wrm.66.2022.10.19.09.20.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 19 Oct 2022 09:20:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f31ad909-4fc9-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=Iwmw9PMnCNDtKtpfuQSnL7/aFDgNl4A9sE5A7TitH6M=;
        b=cfwe++AiGE7jqAH8ujUv1LRlfnr91OEW85b2hJqJxKubegALAtGBYQHoXwYNqkvG5U
         dr9osH3qXP/K19r41hRnNwYkMI5UOHBaQlZ6VClAq5+rG0EMPSz5tHaw/4ixEBDpsbvR
         sg7W9/cMx462lV746LZUum7LAMZXp/6cbF0h3bRILiwzF5+nub9BVR9GwftOVG1V/9MW
         0xroRkr1gc7+V/BCHyIxFJUm7If8jmkjI4DhaT5DexWIG1HpMQpfimG40ejemxXJtbIP
         Dnz2btsel0Ip3P//ZJCMfyJZZ6QtCgyZnmLf/Lpmby5ePOBF+Vb9GJ/bMgFe45HSCQt9
         Z8kw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:organization:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Iwmw9PMnCNDtKtpfuQSnL7/aFDgNl4A9sE5A7TitH6M=;
        b=jZlhtZnkVO7U5CJ5koj8TNhB+fsJwCDNpheEKaUH6/PAhxFAGjYBOMGE7g5PD5LGlM
         SQcu7Sp1kF5uhnreBH0Eb+nEFmIGTYpC2Cu+84FwZtLimUa3EMLStxR5QcoxZKkIj2/c
         zTg7564n+1F9XpqvG6pND24oq7KVkAUcFLu97ZHCgNw/eqsgBXrZSs9O0egf4+G5VTU2
         q0v8nbbajKvYBzpXaLlK78RzGMjgieoLEI32YjniLYb9qt7arVjvZdm2qPXT3LUgPUl0
         wDkhc78xX+ROhzhl+yPyXIXCX2Chh4sTknfS3opl2IC8yN/oAQqHjQjETc4+lJxRkIos
         oLIg==
X-Gm-Message-State: ACrzQf143nVK9dSLZ9qyd9yONLLHItcQlyqgpiFumAc+9RylK588afn/
	23c1NVXXNtsqmw2VbyA8twrP5HeQPQMkSw==
X-Google-Smtp-Source: AMsMyM56y348l/ISeOIYUF1NaaK8V1VIBgfBhdJf3+3om/ZwuaQWqDea3kef/AjLmL6gQvD8BjrdDw==
X-Received: by 2002:a05:600c:3c84:b0:3b4:eff4:ab69 with SMTP id bg4-20020a05600c3c8400b003b4eff4ab69mr27107411wmb.104.1666196430326;
        Wed, 19 Oct 2022 09:20:30 -0700 (PDT)
From: Paul Durrant <xadimgnik@gmail.com>
X-Google-Original-From: Paul Durrant <paul@xen.org>
Message-ID: <03aa5254-18f3-d8f0-edc9-7e8cfadaf434@xen.org>
Date: Wed, 19 Oct 2022 17:20:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export
 xenstore_record_dm_state
Content-Language: en-US
To: Vikram Garhwal <vikram.garhwal@amd.com>, qemu-devel@nongnu.org
Cc: stefano.stabellini@amd.com, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-10-vikram.garhwal@amd.com>
Organization: Xen Project
In-Reply-To: <20221015050750.4185-10-vikram.garhwal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15/10/2022 06:07, Vikram Garhwal wrote:
> xenstore_record_dm_state() will also be used in aarch64 xenpv machine.
> 
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

Reviewed-by: Paul Durrant <paul@xen.org>



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:36:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425926.674072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olC2y-0001UH-BU; Wed, 19 Oct 2022 16:36:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425926.674072; Wed, 19 Oct 2022 16:36:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olC2y-0001UA-7r; Wed, 19 Oct 2022 16:36:00 +0000
Received: by outflank-mailman (input) for mailman id 425926;
 Wed, 19 Oct 2022 16:18:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UZ99=2U=free.fr=denis.chancogne@srs-se1.protection.inumbo.net>)
 id 1olBli-0007UA-Er
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:18:10 +0000
Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e9452e0-4fc9-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 18:18:09 +0200 (CEST)
Received: from zimbra59-e10.priv.proxad.net (unknown [172.20.243.209])
 by smtp4-g21.free.fr (Postfix) with ESMTP id 0C8D819F5AF;
 Wed, 19 Oct 2022 18:18:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e9452e0-4fc9-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr;
	s=smtp-20201208; t=1666196288;
	bh=Pm/EqWEbJ0hJheqvBqZmNf9qn6cGXW/G7iT0GFcr5EY=;
	h=Date:From:To:Cc:In-Reply-To:Subject:From;
	b=G+SoyyooIx4gby1nJ7Fk7dFR/4C2USpgk9NFbtGHDXWEzc9oNrjBotZU43OtHCuh0
	 dfan4nUiccPx3gvmxzP4KXk0Pjhamo5LoL82PvyNKt6+xcqLuu2nNMx9nXHlJLmqcu
	 cHATROltxHcRaLTBRmVTO9oX7bVWTMlSkG+AfCXevWcHBENNkGsRmYUMgDkjWXYi6g
	 p+DanzlxvvgzF171TxwxHs91Hy4OuzPHyMIPRP+n1peqjJQoYMZUOKINUX7QzFOrCn
	 raQFH7s+Kzwz5XI5hmOyeUAC0/+whjpAc8EUbRXn9kAbgtVLbqIn8GE0HD3H8eSoHq
	 McSgEXpsNcd+Q==
Date: Wed, 19 Oct 2022 18:18:07 +0200 (CEST)
From: denis.chancogne@free.fr
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Juergen Gross <jgross@suse.com>, 
	Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	regressions@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>, 
	xen-devel@lists.xenproject.org, 
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Message-ID: <478267192.700718309.1666196287955.JavaMail.root@zimbra59-e10.priv.proxad.net>
In-Reply-To: <402ab0ef-8bea-6210-1585-2e0e217a2e08@leemhuis.info>
Subject: Re: Bug 216581 - Kernel panic on /init as busybox symbolic link
 with xen efi
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Originating-IP: [90.83.51.20]
X-Mailer: Zimbra 7.2.0-GA2598 (ZimbraWebClient - GC80 (Win)/7.2.0-GA2598)
X-Authenticated-User: denis.chancogne@free.fr

>On 17.10.22 02:23, Marek Marczykowski-G=C3=B3recki wrote:
>> On Sun, Oct 16, 2022 at 01:08:53PM +0200, Thorsten Leemhuis wrote:
>
>>>>  Denis Chancogne 2022-10-13 22:00:19 UTC
>>>>
>>>> when I start Xen 4.15.3 in efi with kernel 5.18.19, all works well;
>>>> but since kernel 5.19, I have a kernel panic on my /init process as
>>>> busybox symbolic link inside initramfs.
>>>>
>>>> This is the kernel log :
>> [...]
>>=20
>> Thanks for forwarding.
>>=20
>> This is already fixed on the Xen side: https://xenbits.xen.org/gitweb/?p=
=3Dxen.git;a=3Dcommit;h=3Dc3bd0b83ea5b7c0da6542687436042eeea1e7909
>> The commit is also in 4.15 branch already:
>> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D7923ea47e578b=
ca30a6e45951a9da09e827ff028,
>> to be included in 4.15.4 rather soon.
>
>Hmmm. Well, strictly speaking this is still a kernel regression that
>should be fixed (or worked around) on the kernel level. But 5.19 is out
>for a while already and this afaics was the first report of this problem
>in kernel land. Maybe it's not worth it, so let's leave everything as it
>is for now, if that's okay for Denis. We IMHO will need to reconsider if
>more users run into this.
>
>Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
>#regzbot introduced: 8ad7e8f69695
>#regzbot invalid: it is a kernel regression, but one that can be worked
>around by updating Xen hypervisor

Hi all,
thanks a lot for your responses, it's very well for me.
I will wait for xen-4.15.4 to use latest kernel release.
Regards
Denis


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:43:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:43:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425945.674087 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olC9r-0002zc-50; Wed, 19 Oct 2022 16:43:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425945.674087; Wed, 19 Oct 2022 16:43:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olC9r-0002zV-1b; Wed, 19 Oct 2022 16:43:07 +0000
Received: by outflank-mailman (input) for mailman id 425945;
 Wed, 19 Oct 2022 16:43:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rFyQ=2U=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olC9p-0002zM-9w
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:43:05 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2060.outbound.protection.outlook.com [40.107.244.60])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1879540e-4fcd-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 18:43:03 +0200 (CEST)
Received: from DM6PR06CA0041.namprd06.prod.outlook.com (2603:10b6:5:54::18) by
 DM6PR12MB4202.namprd12.prod.outlook.com (2603:10b6:5:219::22) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.34; Wed, 19 Oct 2022 16:42:59 +0000
Received: from DM6NAM11FT053.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:54:cafe::4b) by DM6PR06CA0041.outlook.office365.com
 (2603:10b6:5:54::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Wed, 19 Oct 2022 16:42:58 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT053.mail.protection.outlook.com (10.13.173.74) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 19 Oct 2022 16:42:58 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 11:42:57 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 19 Oct
 2022 09:42:57 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Wed, 19 Oct 2022 11:42:56 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1879540e-4fcd-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FQgePsNUWrxyqL7R+agbjnWgiu129YCEeYoBmAwplOcCABTzNjie3FdQKHIV5Io5ynd2c2kXMCdh4SRcXiXGMZIWLG25NZ3mHsnh8ubpkeC26hCXA8PhdvfBj2vWJBLfJ6a4iv7k7dn/gmS1Q8yMPee2xqzCS0U0uU4HGFnzi8CQn0UQlig28XuB/XZt13jq2oR/mb/CTU8gjYbc7jNjiUdFU2++FqKDnjwFkH0aI3QKkOE0YZByllTYfEpMlG/ubueySZmMItQUmFDWNlJr5IUfk9ygDQTeDpIKozz88+MSAYHa2CUcb9sz5/3mW7+gYhTLqtXt3NQydH2pPWZrVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kMd2aBnsUoAVumnQYJYbP57oXs20Y21qvcFrIMFAu3E=;
 b=dtYJjlEqI53JgbJkfzn2McuK871c+cmWjuQC50/R1nP+ceBNVngnkSuoPkO92CVsBXJ7+9UpXIUEzZ0BrKl+5yI2IFaLlWX2GHRLmjQh8WGkDho/7GLmv5FtcU/wom/euBzKkw93N2DfU+jIFfqZKw/BTFD/6iaSydYq+qqaQeXkCv+5pgeT0DTPKpSei4D7AfHPA9WwfJJWKOcrnjOyOt43RPrrJ8VtML3VEuG3FMw2ElWF7+MGerBUmiFdiOJvqR1JhMGD6ateooqXaxKtXVGwXmO8U2UCnMenj4JuiscvwWEhZIbMW6SzLthepBSDMZtlOYnFRqMkVGNgCr4X5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kMd2aBnsUoAVumnQYJYbP57oXs20Y21qvcFrIMFAu3E=;
 b=0DJaICuJA8IpYqvkRpkklJ5cUDMRhJsJ9XrXL+w7eJwKBwNW6JxMNgoYWklFiz30RePAhTbbwhKNM4266/put10R6j1lP37hGWtnxFtI5CJutBGN6ZzH+HI1McaOq2DwrUUN9xHfkrrO6zbkF0Kl/BGAQqtFFoBARb6gM2m3aqI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] automation: test.yaml: Introduce templates to reduce the overhead
Date: Wed, 19 Oct 2022 18:42:46 +0200
Message-ID: <20221019164246.5487-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT053:EE_|DM6PR12MB4202:EE_
X-MS-Office365-Filtering-Correlation-Id: 53d21537-2d65-4d5d-49da-08dab1f0fad8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q/ysvF6BwO1AX211XpKgRmfPnTQnwvT7QoqqSdXTLypFhwNE6AEnquZn5Cf/xb/zhLwIezZ5BjJseQZ80Q59IypOSuQ0sbloXDP+RKojvtTCAl23RdSlkCg8oQqB8hQRTaSYjngDxCEWN1SkJcZ8uo92MlrBYZtp84VUNO2h3VOPRlfnGeWMWXcfRWozrmcHst/PMww28nKIEW0GWX8xSGlPps/zs/LMneDp4tLy7RpfLWPx0J3k08zF0zTlWy1l4K1zJktIRzG21oQwdVjERhji6gnL5JWkYXmzM/EO4EKAMsDlsObjx0XWC5HuuFaQi1dNIagqNmzcxYPk+FF/W0+FS+94z/QKBDBD+fZ9Xnj/3uOp8c7SQhHVHLXQYliFqjwhtjZ4oePXVzEKsfNdxqXqjrDyahp+V8gTEFdtZ6SPbOoQjqppi0WRbhS0XB4VUD4nB+v0Z3Fz0lVKq+IHY+9GMOXoSkdh67sOsiB77Z7BSsF4PCDs4AaheXiRTE3f1trff6OXSIAAZVSoLf2fljPGD938Ix4fqwiRCrG7LiChMwjkuqVCpddX7zs5k3/tzBCcphxLJu/bUwuELx6cfQAKslx9JRUir56O3WToGXoOByYWYein6R1hMPWWEWm+PyfHoD+ufth7ujujuQYAGXfV+5vnFnHUzoWOxGdJRsX2SNghZZXMmVQwgT94mL0deTzxlAfjeysrOXMiORPLmSykwUjjVMuit5yBoXhP+kTxngP1hBfZUhJcvrpQB2EpnUm0z2tCKQAT6r5B1GlI1CbxCgYNjzuEZRL1mBGgk0TP6/3FuxKNesDL696Qcnf1pb0YV9XvTXmA2K3x4j5zCVj3aom1Su00k4F76VhKctWhl4pW13jRkjjw+6Z0xm47
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(46966006)(40470700004)(36840700001)(86362001)(36756003)(81166007)(82740400003)(356005)(2906002)(83380400001)(40460700003)(30864003)(5660300002)(40480700001)(44832011)(26005)(6666004)(2616005)(186003)(1076003)(336012)(47076005)(426003)(36860700001)(966005)(316002)(478600001)(82310400005)(54906003)(6916009)(70586007)(70206006)(8676002)(4326008)(41300700001)(8936002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:42:58.4155
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 53d21537-2d65-4d5d-49da-08dab1f0fad8
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT053.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4202

At the moment, we define lots of test jobs in test.yaml, that make use
of the same configuration sections like variables, tags, artifacts.
Introduce templates (hidden jobs whose names start with a dot) to
reduce the overhead and simplify the file (more than 100 lines saved).
This way, the actual jobs can only specify sections that are unique
to them.

Most of the test jobs specify the same set of prerequisite jobs under needs
property with just one additional being unique to the job itself. Introduce
YAML anchors for that purpose, because when using extends, the needs property
is not being merged (the parent property overwrites the child one).

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
This patch is based on the CI next branch where we already have several
patches (already acked) to be merged into staging after the release:
https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next

Tested pipeline:
https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/671114820
---
 automation/gitlab-ci/test.yaml | 266 ++++++++++-----------------------
 1 file changed, 80 insertions(+), 186 deletions(-)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 92e0a1f7c510..fc0884b12082 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -7,32 +7,12 @@
     - /^coverity-tested\/.*/
     - /^stable-.*/
 
-# Test jobs
-build-each-commit-gcc:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
-    XEN_TARGET_ARCH: x86_64
-    CC: gcc
-  script:
-    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
-    - mv ../build-each-commit-gcc.log .
-  artifacts:
-    paths:
-      - '*.log'
-    when: always
-  needs: []
-  tags:
-    - x86_64
-
-qemu-smoke-dom0-arm64-gcc:
+.qemu-arm64:
   extends: .test-jobs-common
   variables:
     CONTAINER: debian:unstable-arm64v8
-  script:
-    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  needs:
-    - alpine-3.12-gcc-arm64
+    LOGFILE: qemu-smoke-arm64.log
+  needs: &qemu-arm64-needs
     - alpine-3.12-arm64-rootfs-export
     - kernel-5.19-arm64-export
     - qemu-system-aarch64-6.0.0-arm64-export
@@ -44,17 +24,13 @@ qemu-smoke-dom0-arm64-gcc:
   tags:
     - arm64
 
-qemu-smoke-dom0-arm64-gcc-debug:
+.qemu-arm32:
   extends: .test-jobs-common
   variables:
     CONTAINER: debian:unstable-arm64v8
-  script:
-    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  needs:
-    - alpine-3.12-gcc-debug-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
+    LOGFILE: qemu-smoke-arm32.log
+  needs: &qemu-arm32-needs
+    - qemu-system-aarch64-6.0.0-arm32-export
   artifacts:
     paths:
       - smoke.serial
@@ -63,16 +39,11 @@ qemu-smoke-dom0-arm64-gcc-debug:
   tags:
     - arm64
 
-qemu-alpine-x86_64-gcc:
+.qemu-x86-64:
   extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
-  script:
-    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-x86_64.log
-  needs:
-    - alpine-3.12-gcc
-    - alpine-3.12-rootfs-export
-    - kernel-5.10.74-export
+    LOGFILE: qemu-smoke-x86-64.log
   artifacts:
     paths:
       - smoke.serial
@@ -81,214 +52,137 @@ qemu-alpine-x86_64-gcc:
   tags:
     - x86_64
 
-qemu-smoke-dom0less-arm64-gcc:
+# Test jobs
+build-each-commit-gcc:
   extends: .test-jobs-common
   variables:
-    CONTAINER: debian:unstable-arm64v8
+    CONTAINER: debian:stretch
+    XEN_TARGET_ARCH: x86_64
+    CC: gcc
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  needs:
-    - alpine-3.12-gcc-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
+    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
+    - mv ../build-each-commit-gcc.log .
   artifacts:
     paths:
-      - smoke.serial
       - '*.log'
     when: always
+  needs: []
   tags:
-    - arm64
+    - x86_64
+
+qemu-smoke-dom0-arm64-gcc:
+  extends: .qemu-arm64
+  script:
+    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - *qemu-arm64-needs
+    - alpine-3.12-gcc-arm64
+
+qemu-smoke-dom0-arm64-gcc-debug:
+  extends: .qemu-arm64
+  script:
+    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - *qemu-arm64-needs
+    - alpine-3.12-gcc-debug-arm64
+
+qemu-smoke-dom0less-arm64-gcc:
+  extends: .qemu-arm64
+  script:
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - *qemu-arm64-needs
+    - alpine-3.12-gcc-arm64
 
 qemu-smoke-dom0less-arm64-gcc-debug:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm64-needs
     - alpine-3.12-gcc-debug-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-staticmem:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm64-needs
     - alpine-3.12-gcc-arm64-staticmem
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-debug-staticmem:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm64-needs
     - alpine-3.12-gcc-debug-arm64-staticmem
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-boot-cpupools:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm64-needs
     - alpine-3.12-gcc-arm64-boot-cpupools
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm64-needs
     - alpine-3.12-gcc-debug-arm64-boot-cpupools
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0-arm32-gcc:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm32
   script:
-    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
+    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm32-needs
     - debian-unstable-gcc-arm32
-    - qemu-system-aarch64-6.0.0-arm32-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0-arm32-gcc-debug:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm32
   script:
-    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
+    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *qemu-arm32-needs
     - debian-unstable-gcc-arm32-debug
-    - qemu-system-aarch64-6.0.0-arm32-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
+
+qemu-alpine-x86_64-gcc:
+  extends: .qemu-x86-64
+  script:
+    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - alpine-3.12-gcc
+    - alpine-3.12-rootfs-export
+    - kernel-5.10.74-export
 
 qemu-smoke-x86-64-gcc:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
   needs:
     - debian-stretch-gcc-debug
-  tags:
-    - x86_64
 
 qemu-smoke-x86-64-clang:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
   needs:
     - debian-unstable-clang-debug
-  tags:
-    - x86_64
 
 qemu-smoke-x86-64-gcc-pvh:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
   needs:
     - debian-stretch-gcc-debug
-  tags:
-    - x86_64
 
 qemu-smoke-x86-64-clang-pvh:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
   needs:
     - debian-unstable-clang-debug
-  tags:
-    - x86_64
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 16:47:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 16:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425954.674098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olCDj-0003f7-LD; Wed, 19 Oct 2022 16:47:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425954.674098; Wed, 19 Oct 2022 16:47:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olCDj-0003f0-IQ; Wed, 19 Oct 2022 16:47:07 +0000
Received: by outflank-mailman (input) for mailman id 425954;
 Wed, 19 Oct 2022 16:47:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tv8N=2U=epam.com=prvs=22918d0935=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1olCDh-0003et-IJ
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 16:47:05 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a80ce3a3-4fcd-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 18:47:03 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JFcxkC001134;
 Wed, 19 Oct 2022 16:46:58 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3kam2m07mj-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 19 Oct 2022 16:46:58 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB9PR03MB7770.eurprd03.prod.outlook.com (2603:10a6:10:2cd::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 19 Oct
 2022 16:46:54 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 16:46:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a80ce3a3-4fcd-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E128A5AN986xLICYEo1xEzTRH0lLlPXCTe6+3CmHAUvtO1veqFqUYnVxrGhGI2WibXv79mR/diwMDrcBvm8ILHMSBEOUTTB6IdXvHjLO/Vo/zGtm37ABZBuIXeH7iO6AYYVKQxtqvk+u3khHTLrzeDRAxASaEeqq/MNS/aESKkPo/dtIs4Z0Jkqkx3sbqz4EgC8ThmY9Gp0jZT330inK5PF3KQgICuLtKbtsJdnay72wO4LgRG7ijtkioMo6TXaWibtA0jTcSM1+5FatCLqI7c6ns5oLUQcXswWvDJ6hFEavNHvSUXO/CqJ+c/pSbG8/0BW1dezFaCOcUh1pAkiiJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V+td5XQxBbaztZZ8fugpXW3pC0y/TTG6psbvVSRrAXo=;
 b=dgl454gxVFq07mqnVpimROqh+5BPBOMrLVf01iwVm8XHCiVoiSG42GFhAf8OtcpEfiLkiHchz0zVCTD5yzgt1w+KQvA+/KYZefZaBNZsmFcTwPIOM9bZtBcwzZxverFJRCCEHMD9hOVx6XAveYRRLF+j5nlgAkcxA/QCUBkIShRuR0Tg2oS0uCcm1zn5W8JgVZxxGvYSWfsOp3p9YnhsZr1kZZ75QXtHyf8ewF/kU5IOIIEF+R59WJm/o5WHvjt6PE8zV/TzSiOB1rcveFAsuMqoOVCvlZfD3+36po1eAhv7fMcI5VtYKjuW9IxKbJL6rzqAUvIfPeOo9wI3BIiHXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V+td5XQxBbaztZZ8fugpXW3pC0y/TTG6psbvVSRrAXo=;
 b=GfD8Hxn/Ke8u3ZEuBEkdKn80NkK+ePK+iwi4GoVFe3XuQVrY2fVk0JJbBkl3j9kAu0mJxZ0XqS30egvsp52C2vhnApBb8Eg8lSXt9mr7Eu1b+7LZZOXpvxDe6j7zj9RusO7496xR76K0hQqm08fv8BzymCDdQPoudcKjzt4fajzg6VhsgEkodO4xcMqLi8/ZY7ojmydnfavGtx2+FdDHyibb/2EK5N3eFy6gCnL/nV25zcE1f0CLF8YRB8YLm6PWU5lotLicYtaVZu/7L0d6pd/aBmdNNZA2YxTxLMPpTASPk7+dMM2ztrtfZ+kQ+WCpoPXYA7qedwi9Cl6QT+0lGQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64U6lSAgAEJHIA=
Date: Wed, 19 Oct 2022 16:46:54 +0000
Message-ID: <af1a47f4-be0a-141d-8e53-0be303486a1a@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DB9PR03MB7770:EE_
x-ms-office365-filtering-correlation-id: af5380c1-7808-401f-4112-08dab1f1876b
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 otQb/OPKA+o36LUmTwveX/uYJ06nBvx/n+QOZLIIPuvcC1MIAXei7EWoQjmk4GiB6iH3tExuhMT4VSf9Y/7u3M0IFcYncIpfkJCOPvo9lqMwB/Y76ldRteHskcmHV01DGBzECSt66ZvdG6aB9/4/35YaEgqIOq0DcXymsVaWOPHjWH0/qCF69sBPEdiPSEolCcXwbwZdICRSJr1ruguLII2/3MirEMyZ3R5J3SDjpfz0zuRWY1/Y0R3cW5z3NT0Lk4uRkYMq9LIbtOFEVzPfN+Lx1jLBKftQwubl4KBCEU86pzp9LquSxxbJnrl2TrT5SUA5A2UeeyB6ryGW+4k6V+E1Wk7YHfDrJ5fZ6QDoCsj8RiKx3aCLHAPpt/5YOGFTH3zyy+24bMCw8AEQqMorYqIlhazIZZGYzz8nVdBimIwmWkzvFWktB8v9Q6Co3ztf2jumLlMOyImKgJ536G7Nwuv6i8uO0vyAWcJCYr+m9Bqb6LSxU/vejnN2xk97uArY/v4xsZqHTqa+V4VbbH04jGgB8EBew2cRPuJ38CJIUXMOWwEqMIYFsfaxcdQcoQHOo/BstH8z9+05S5GIYvV/apDBZB1RRTykvy8zrMvyscn0YNlQL3Uzxv1hqJYX1RpTsMRo3nnBz805QtK+asNR2rAbCi9Q8PI6N+z2L5x8wiO9V5UMHBauWG6cYGCb1UlwB+cuKvvHMtwU+nnpk347IADVzNy/NZ4+3CPtmNhZHcEmUByaTkg5dheyq9lJ3PQLlztCt2mkT642PPTfJVNXmUD3vuekQIp9lw1H0LxCBaaBUHTTAEDfCIzjemOmu64GeqT1vC2pdbJTKBEazUU0A2AbYw3VIyFHyo4f/xorauk=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(396003)(346002)(136003)(451199015)(41300700001)(2906002)(8936002)(5660300002)(66556008)(36756003)(6916009)(76116006)(66476007)(71200400001)(122000001)(966005)(66946007)(6506007)(316002)(478600001)(6486002)(64756008)(4326008)(66446008)(91956017)(8676002)(55236004)(31696002)(83380400001)(86362001)(31686004)(53546011)(38070700005)(54906003)(38100700002)(186003)(26005)(6512007)(2616005)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?c0RZRC80UCtMaHIyS3FKMmp4eEp4M2xPNkxGYXV2QVc0cGJpNjlZM3ltVVFL?=
 =?utf-8?B?dGRUVmpKZVdSV01wYVB4cmU1bktsVS94UjFRUjhQWFlYN2gxeTZFTFkyMEpH?=
 =?utf-8?B?ZmpIWHRDSjdBVnhpbXZJbUVNUkZmbWJJM2UrbjhpYzhBak1IaUJPMHMzZVBr?=
 =?utf-8?B?eTF2NlkrSncvb2ovcEFNbnVNZXpzdFI0RW8xVldPSk9rQ2Zvb3Z5MTFkUjRx?=
 =?utf-8?B?NlB1NkZ6OHBUV3lhWTRTUUlzSDZNYU5YbndGRGRhQWpScGMyQ0hxdWlGampQ?=
 =?utf-8?B?Q1ZkRXVZcHFCNGhZazJoZWJ2VGxtWUR5MnpWS2ZBaGZBSXlXdzc2TjdnWUdK?=
 =?utf-8?B?TmZVQlczN2FYaDRrODR3MjlKNlVYT3hPZlMwbVJUd1NBQWRnNXI0NGJqMDh3?=
 =?utf-8?B?c3h0eEJHNjBYaGFjQUM2NFdTc3JBRmRzdGljd29Ra3lZSUU3QjZ2NUVlTkdW?=
 =?utf-8?B?OE9hSGU2WmtQeGVGL3duN0w1UkplUGZDS29kVzZkcDIzR3R5MTJuRG82UnRm?=
 =?utf-8?B?YUQzTm1lQ0V3UVJrMVNUbUhjYXQzbTlTNTIyR0p2NkNydFBFVW1sZmthV2ND?=
 =?utf-8?B?dDZ0ZEd1TktCN0k3bXg5NUVzNU1HL3R1L3VCTGlHWWp4aTB2WkJIVGRMdHF3?=
 =?utf-8?B?MU9uS1ZXblh5bWtiOHJTdUlHbnJzYXE5RGFoR1paRkdEWUNoSHFDNlhWVkJt?=
 =?utf-8?B?K21WTUhoR1JxaEd1V0svZ0JtTUhzODZsK2Q4WWRxWnBpd2UyWlltSDFLbUZR?=
 =?utf-8?B?anMrZTVJWHRJSEZTeW41S0ZoS0tocFlubkNDeER5UFJQSWdtMjFwdU1SMTM0?=
 =?utf-8?B?UDhqVWlaV1VsRUdPb1RzUXMvemZrdUFyYnhUN1FXMkNEcDFNcTY5RWovMkVz?=
 =?utf-8?B?UjhFL1R4ZHVVRTI0bWJ3UUQvNUorTjBJQmhYM0t5VnlyaGU5aXkzcUlVc053?=
 =?utf-8?B?SlozbTdrUWRWODk3dzJHWHZCbEQ5Q3ppQnpmMWdGZ0tQYkZhMHJESytMakJx?=
 =?utf-8?B?NVpOQ3NRT0FxQkpocnBZdjJQUXhscHAxelhSRHJ0UWtsQkViR0gwRktZVGNY?=
 =?utf-8?B?T3ZNcFhEdUNXU2FXR0h2akt3MFJBNGV0QW1Pb29pdlBvUGp3cjhTMFNGRk5N?=
 =?utf-8?B?cXh3MXlLSkRGYURqNEE5VGd6c2ZGZk5vVkl2TVphU1hVclI2YURJT3lUc3Zk?=
 =?utf-8?B?c290UDh3TWlUODNJWnIyL0lYUENpdWs0MXp5WDZZeDUvd1Z0OStDQ3VLK3Jx?=
 =?utf-8?B?bXBGaE95LzlMc08wdnRVWXUySjBLYkwrVVpHNHNDaXArV0dFLzBrTW9FN3F3?=
 =?utf-8?B?WVQ4NFhPYUMzaWFrR2IvNW44dmNDNmpZcXBCZ2x5dSsyNmhqVjRRazVhWUlX?=
 =?utf-8?B?TW44c21ZRTFGellnKzdhWXIrV1BnRjZZai9uOVA1NUw2WFh3NjdHRGZSSmo0?=
 =?utf-8?B?TFUxMzAvbFVtRGlsRGpNRjZENUJPRTFHZlE3R2RtWk80NW5oVmw4Rkczd1g1?=
 =?utf-8?B?aUUxTW42dHVBYTVVOUFGQktpWDh2RklSSkt1cFdNRS9qRnVjbEU0UWp3a1dp?=
 =?utf-8?B?MEJqL1ZkYnFXUGYrL2lqNTREaHhzVVR4cGVpVEViVnVaeU9FdVhFSXdjWFl2?=
 =?utf-8?B?dkpQU2JPbDZQWmNPanN5V2xPeUdXVTQyellwVWNMVXZmeWRkbnNGRy9uY0pK?=
 =?utf-8?B?b3k3aHBHTlFncGd4ZHZiKzE3bGw0cWFGYk9NbXJPL2Y5cEREWWUzMGZxLzB3?=
 =?utf-8?B?L29iVTlyT0dZSUsxSU5iTTZrNEt2NDdDQ1FDNWl0a0VSMHErR0JaZmw4NkdM?=
 =?utf-8?B?cXpydW91ZXRyYWcxYmViMXRVbXV2R3lPb2gzaFAxVFJLa3NSNXJBNFA3Ym1L?=
 =?utf-8?B?c0dva291TGdySlVYVTJRT3EzN09UbkpldzBpU0VzcUxQb1NLVXQ3cFBkVG1p?=
 =?utf-8?B?SVN0NzN2S3VwMjlUQ2F4STV4SHBQSWxrUW55TVlObDJyYmp0TXkyZmdrcGRn?=
 =?utf-8?B?VVkvVVdqdWE1TWZ6c3l2VjlMTGM0WDBCVDd3WVA3b0dGT1VNTGVSeGhqNUM0?=
 =?utf-8?B?OERQRzhraS9jeVNPMDR5b1hvSXQvZFNPTGM1b2ZPTWl6U1ZuS2FIRUo2cWd2?=
 =?utf-8?B?R3JlMVlrNzNTRmRpYmhLTlNjYlJLT3Z3V0kwSDE3dG5SYjRNQSthdXJXb2dl?=
 =?utf-8?Q?E8BvxnsKHLfpxKp4kOORzb0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <65EFB23887A962498211572D4195F7EE@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af5380c1-7808-401f-4112-08dab1f1876b
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 16:46:54.3378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Og0/JtV+DgsRimjyzQWcp+ng2NvGDpvZIj7RqLzI+GTYBj0mEnCslCh6LOgg67mfxdvmd6SlTTmJ+dkVBtOHvYWXQC1DKwCd2JfxFalD6Jo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7770
X-Proofpoint-GUID: H5bEOx6cRd02o26fZk4tx6Trv1K1ys3w
X-Proofpoint-ORIG-GUID: H5bEOx6cRd02o26fZk4tx6Trv1K1ys3w
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_09,2022-10-19_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 clxscore=1015 lowpriorityscore=0
 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210190094

DQpPbiAxOS4xMC4yMiAwMzo1OCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gT24gU2F0LCAxNSBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3Jv
dGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29A
ZXBhbS5jb20+DQo+Pg0KPj4gVXNlIHRoZSBzYW1lICJ4ZW4tZ3JhbnQtZG1hIiBkZXZpY2UgY29u
Y2VwdCBmb3IgdGhlIFBDSSBkZXZpY2VzDQo+PiBiZWhpbmQgZGV2aWNlLXRyZWUgYmFzZWQgUENJ
IEhvc3QgY29udHJvbGxlciwgYnV0IHdpdGggb25lIG1vZGlmaWNhdGlvbi4NCj4+IFVubGlrZSBm
b3IgcGxhdGZvcm0gZGV2aWNlcywgd2UgY2Fubm90IHVzZSBnZW5lcmljIElPTU1VIGJpbmRpbmdz
DQo+PiAoaW9tbXVzIHByb3BlcnR5KSwgYXMgd2UgbmVlZCB0byBzdXBwb3J0IG1vcmUgZmxleGli
bGUgY29uZmlndXJhdGlvbi4NCj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgUENJIGRldmljZXMgdW5k
ZXIgdGhlIHNpbmdsZSBQQ0kgSG9zdCBjb250cm9sbGVyDQo+PiBtYXkgaGF2ZSB0aGUgYmFja2Vu
ZHMgcnVubmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFpbnMgYW5kIHRodXMgaGF2ZQ0KPj4gZGlm
ZmVyZW50IGVuZHBvaW50cyBJRCAoYmFja2VuZCBkb21haW5zIElEKS4NCj4+DQo+PiBTbyB1c2Ug
Z2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5zdGVhZCAoaW9tbXUtbWFwL2lvbW11LW1hcC1t
YXNrDQo+PiBwcm9wZXJ0aWVzKSB3aGljaCBhbGxvd3MgdXMgdG8gZGVzY3JpYmUgcmVsYXRpb25z
aGlwIGJldHdlZW4gUENJDQo+PiBkZXZpY2VzIGFuZCBiYWNrZW5kIGRvbWFpbnMgSUQgcHJvcGVy
bHkuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5k
cl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPiBOb3cgdGhhdCBJIHVuZGVyc3Rvb2QgdGhlIGFwcHJv
YWNoIGFuZCB0aGUgcmVhc29ucyBmb3IgaXQsIEkgY2FuIHJldmlldw0KPiB0aGUgcGF0Y2ggOi0p
DQoNCnBlcmZlY3QsIHRoYW5rcy4NCg0KDQo+DQo+IFBsZWFzZSBhZGQgYW4gZXhhbXBsZSBvZiB0
aGUgYmluZGluZ3MgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLg0KDQpvaywgd2lsbCBkbw0KDQoNCj4N
Cj4NCj4+IC0tLQ0KPj4gU2xpZ2h0bHkgUkZDLiBUaGlzIGlzIG5lZWRlZCB0byBzdXBwb3J0IFhl
biBncmFudCBtYXBwaW5ncyBmb3IgdmlydGlvLXBjaSBkZXZpY2VzDQo+PiBvbiBBcm0gYXQgc29t
ZSBwb2ludCBpbiB0aGUgZnV0dXJlLiBUaGUgWGVuIHRvb2xzdGFjayBzaWRlIGlzIG5vdCBjb21w
bGV0ZWx5IHJlYWR5IHlldC4NCj4+IEhlcmUsIGZvciBQQ0kgZGV2aWNlcyB3ZSB1c2UgbW9yZSBm
bGV4aWJsZSB3YXkgdG8gcGFzcyBiYWNrZW5kIGRvbWlkIHRvIHRoZSBndWVzdA0KPj4gdGhhbiBm
b3IgcGxhdGZvcm0gZGV2aWNlcy4NCj4+DQo+PiBDaGFuZ2VzIFYxIC0+IFYyOg0KPj4gICAgIC0g
dXBkYXRlIGNvbW1pdCBkZXNjcmlwdGlvbg0KPj4gICAgIC0gcmViYXNlDQo+PiAgICAgLSByZXdv
cmsgdG8gdXNlIGdlbmVyaWMgUENJLUlPTU1VIGJpbmRpbmdzIGluc3RlYWQgb2YgZ2VuZXJpYyBJ
T01NVSBiaW5kaW5ncw0KPj4NCj4+IFByZXZpb3VzIGRpc2N1c3Npb24gaXMgYXQ6DQo+PiBodHRw
czovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVs
LzIwMjIxMDA2MTc0ODA0LjIwMDMwMjktMS1vbGVrc3R5c2hAZ21haWwuY29tL19fOyEhR0ZfMjlk
YmNRSVVCUEEheEpQZFpPMy0zV21nb183OUh1RHNENTNSa0hfZUFOOTZObXd1d0ZFN2RBcnRfeE5Z
R2RENkxlTHNxNEJfUVBycnZYLXgyM3RKbDZqUWxOcWd5TmpnelQyTkUzUHFqZyQgIFtsb3JlWy5d
a2VybmVsWy5db3JnXQ0KPj4NCj4+IEJhc2VkIG9uOg0KPj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNv
bS92My9fX2h0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3hl
bi90aXAuZ2l0L2xvZy8/aD1mb3ItbGludXMtNi4xX187ISFHRl8yOWRiY1FJVUJQQSF4SlBkWk8z
LTNXbWdvXzc5SHVEc0Q1M1JrSF9lQU45Nk5td3V3RkU3ZEFydF94TllHZEQ2TGVMc3E0Ql9RUHJy
dlgteDIzdEpsNmpRbE5xZ3lOamd6VDJKNDBMT3hnJCAgW2dpdFsuXWtlcm5lbFsuXW9yZ10NCj4+
IC0tLQ0KPj4gICBkcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgfCA4NyArKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKy0tLS0tDQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA3NiBpbnNlcnRp
b25zKCspLCAxMSBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4v
Z3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBpbmRleCBk
YWE1MjVkZjdiZGMuLmI3OWQ5ZDZjZTE1NCAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMveGVuL2dy
YW50LWRtYS1vcHMuYw0KPj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBA
QCAtMTAsNiArMTAsNyBAQA0KPj4gICAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+DQo+PiAgICNp
bmNsdWRlIDxsaW51eC9kbWEtbWFwLW9wcy5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgvb2YuaD4N
Cj4+ICsjaW5jbHVkZSA8bGludXgvcGNpLmg+DQo+PiAgICNpbmNsdWRlIDxsaW51eC9wZm4uaD4N
Cj4+ICAgI2luY2x1ZGUgPGxpbnV4L3hhcnJheS5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgvdmly
dGlvX2FuY2hvci5oPg0KPj4gQEAgLTI5MiwxMiArMjkzLDU1IEBAIHN0YXRpYyBjb25zdCBzdHJ1
Y3QgZG1hX21hcF9vcHMgeGVuX2dyYW50X2RtYV9vcHMgPSB7DQo+PiAgIAkuZG1hX3N1cHBvcnRl
ZCA9IHhlbl9ncmFudF9kbWFfc3VwcG9ydGVkLA0KPj4gICB9Ow0KPj4gICANCj4+ICtzdGF0aWMg
c3RydWN0IGRldmljZV9ub2RlICp4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoc3RydWN0IGRldmlj
ZSAqZGV2KQ0KPj4gK3sNCj4+ICsJc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRl
dik7DQo+PiArCXN0cnVjdCBwY2lfYnVzICpidXMgPSBwZGV2LT5idXM7DQo+PiArDQo+PiArCS8q
IFdhbGsgdXAgdG8gdGhlIHJvb3QgYnVzIHRvIGxvb2sgZm9yIFBDSSBIb3N0IGNvbnRyb2xsZXIg
Ki8NCj4+ICsJd2hpbGUgKCFwY2lfaXNfcm9vdF9idXMoYnVzKSkNCj4+ICsJCWJ1cyA9IGJ1cy0+
cGFyZW50Ow0KPj4gKw0KPj4gKwlyZXR1cm4gb2Zfbm9kZV9nZXQoYnVzLT5icmlkZ2UtPnBhcmVu
dC0+b2Zfbm9kZSk7DQo+PiArfQ0KPiBJdCBzZWVtcyBzaWxseSB0aGF0IHdlIG5lZWQgdG8gd2Fs
ayB0aGUgaGllcmFjaHkgdGhhdCB3YXksIGJ1dCBJDQo+IGNvdWxkbid0IGZpbmQgYW5vdGhlciB3
YXkgdG8gZG8gaXQNCg0KSSBhbHNvIGNvdWxkbid0LCBidXQgaXMgaXQgYSByZWFsbHkgcHJvYmxl
bT8gVGhpcyBjb2RlIGlzIG9ubHkgZ2V0cyANCmNhbGxlZCBkdXJpbmcgaW5pdGlhbGl6YXRpb24u
DQoNCg0KPg0KPg0KPj4gK3N0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnhlbl9kdF9nZXRfbm9k
ZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiArew0KPj4gKwlpZiAoZGV2X2lzX3BjaShkZXYpKQ0K
Pj4gKwkJcmV0dXJuIHhlbl9kdF9nZXRfcGNpX2hvc3Rfbm9kZShkZXYpOw0KPj4gKw0KPj4gKwly
ZXR1cm4gb2Zfbm9kZV9nZXQoZGV2LT5vZl9ub2RlKTsNCj4+ICt9DQo+PiArDQo+PiArc3RhdGlj
IGludCB4ZW5fZHRfbWFwX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2Rl
ICoqaW9tbXVfbnAsDQo+PiArCQkJIHUzMiAqc2lkKQ0KPj4gK3sNCj4+ICsJc3RydWN0IHBjaV9k
ZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQo+PiArCXUzMiByaWQgPSBQQ0lfREVWSUQocGRl
di0+YnVzLT5udW1iZXIsIHBkZXYtPmRldmZuKTsNCj4+ICsJc3RydWN0IGRldmljZV9ub2RlICpo
b3N0X25wOw0KPj4gKwlpbnQgcmV0Ow0KPj4gKw0KPj4gKwlob3N0X25wID0geGVuX2R0X2dldF9w
Y2lfaG9zdF9ub2RlKGRldik7DQo+PiArCWlmICghaG9zdF9ucCkNCj4+ICsJCXJldHVybiAtRU5P
REVWOw0KPj4gKw0KPj4gKwlyZXQgPSBvZl9tYXBfaWQoaG9zdF9ucCwgcmlkLCAiaW9tbXUtbWFw
IiwgImlvbW11LW1hcC1tYXNrIiwgaW9tbXVfbnAsIHNpZCk7DQo+PiArCW9mX25vZGVfcHV0KGhv
c3RfbnApOw0KPj4gKwlyZXR1cm4gcmV0Ow0KPj4gK30NCj4+ICsNCj4+ICAgc3RhdGljIGJvb2wg
eGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+
PiAtCXN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnA7DQo+PiArCXN0cnVjdCBkZXZpY2Vfbm9k
ZSAqaW9tbXVfbnAgPSBOVUxMOw0KPj4gICAJYm9vbCBoYXNfaW9tbXU7DQo+PiAgIA0KPj4gLQlp
b21tdV9ucCA9IG9mX3BhcnNlX3BoYW5kbGUoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgMCk7DQo+
PiArCWlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+ICsJCWlmICh4ZW5fZHRfbWFwX2lkKGRldiwg
JmlvbW11X25wLCBOVUxMKSkNCj4+ICsJCQlyZXR1cm4gZmFsc2U7DQo+PiArCX0gZWxzZQ0KPj4g
KwkJaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDAp
Ow0KPj4gKw0KPj4gICAJaGFzX2lvbW11ID0gaW9tbXVfbnAgJiYNCj4+ICAgCQkgICAgb2ZfZGV2
aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQo+PiAgIAlvZl9u
b2RlX3B1dChpb21tdV9ucCk7DQo+PiBAQCAtMzA3LDkgKzM1MSwxNyBAQCBzdGF0aWMgYm9vbCB4
ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiAgIA0KPj4g
ICBib29sIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAg
ew0KPj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4gKw0KPj4gICAJLyogWFhYIEhhbmRs
ZSBvbmx5IERUIGRldmljZXMgZm9yIG5vdyAqLw0KPj4gLQlpZiAoZGV2LT5vZl9ub2RlKQ0KPj4g
LQkJcmV0dXJuIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldik7DQo+PiArCW5wID0geGVu
X2R0X2dldF9ub2RlKGRldik7DQo+PiArCWlmIChucCkgew0KPj4gKwkJYm9vbCByZXQ7DQo+PiAr
DQo+PiArCQlyZXQgPSB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShkZXYpOw0KPj4gKwkJb2Zf
bm9kZV9wdXQobnApOw0KPj4gKwkJcmV0dXJuIHJldDsNCj4+ICsJfQ0KPiBXZSBkb24ndCBuZWVk
IHRvIHdhbGsgdGhlIFBDSSBoaWVyYWNoeSB0d2ljZS4gTWF5YmUgd2UgY2FuIGFkZCB0aGUNCj4g
b2Zfbm9kZSBjaGVjayBkaXJlY3RseSB0byB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZT8NCg0K
DQpHb29kIHBvaW50LiBJIHdhcyB0aGlua2luZyB0aGF0IHdlIHdvdWxkIGxpa2VseSBuZWVkIHRo
ZSBmb2xsb3dpbmcgDQpjb25zdHJ1Y3QgaXMgdGhlIGZ1dHVyZToNCg0KDQppZiAobnApIC8qIERU
IGRldmljZSAqLw0KIMKgwqAgcmV0dXJuIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldik7
DQplbHNlIC8qIEFDUEkgZGV2aWNlICovDQogwqDCoCByZXR1cm4geGVuX2lzX2FjcGlfZ3JhbnRf
ZG1hX2RldmljZShkZXYpOw0KDQoNClNvLCBpZiB3ZSB1c2UgdGhlIGNoZWNrIGRpcmVjdGx5IGlu
IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKCkgYW5kIGl0IA0KcmV0dXJucyBmYWxzZSB3ZSB3
b24ndCBiZSBhYmxlIHRvIHJlY29nbml6ZSBhIHJlYXNvbiB0aGVuDQood2hldGhlciBkZXYgaXMg
bm90IHJlbGF0ZWQgdG8gRFQsIG9yIGl0IGlzIHJlbGF0ZWQgdG8gRFQgYnV0IGl0IGlzIG5vdCAN
CmEgInhlbixncmFudC1kbWEiIGRldmljZSkuDQpCdXQsIEkgYW0gb2sgdG8gZWxpbWluYXRlIG9u
ZSB3YWxrIHJpZ2h0IG5vdywgdGhlbiB3ZSB3aWxsIHNlZS4NCg0KeGVuX2lzX2dyYW50X2RtYV9k
ZXZpY2UoKSB3aWxsIGJlY2FtZSB0aGUgZm9sbG93aW5nOg0KDQpib29sIHhlbl9pc19ncmFudF9k
bWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCnsNCiDCoMKgIMKgcmV0dXJuIHhlbl9pc19k
dF9ncmFudF9kbWFfZGV2aWNlKGRldik7DQp9DQoNCnhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNl
KCkgd2lsbCBuZWVkIHRvIGdhaW4gYSBjaGVjayB0aGF0IGRldi0+b2Zfbm9kZSANCmlzIG5vdCBh
IE5VTEwuDQoNCg0KU2hhbGwgST8NCg0KDQoNCj4NCj4NCj4+ICAgCXJldHVybiBmYWxzZTsNCj4+
ICAgfQ0KPj4gQEAgLTMyNSwxMiArMzc3LDE5IEBAIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0
cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYpDQo+PiAgIHN0YXRpYyBpbnQgeGVuX2R0X2dyYW50X2lu
aXRfYmFja2VuZF9kb21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiAgIAkJCQkJICAgc3RydWN0
IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YSkNCj4+ICAgew0KPj4gLQlzdHJ1Y3Qgb2ZfcGhhbmRs
ZV9hcmdzIGlvbW11X3NwZWM7DQo+PiArCXN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3Bl
YyA9IHsgLmFyZ3NfY291bnQgPSAxIH07DQo+PiAgIA0KPj4gLQlpZiAob2ZfcGFyc2VfcGhhbmRs
ZV93aXRoX2FyZ3MoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgIiNpb21tdS1jZWxscyIsDQo+PiAt
CQkJMCwgJmlvbW11X3NwZWMpKSB7DQo+PiAtCQlkZXZfZXJyKGRldiwgIkNhbm5vdCBwYXJzZSBp
b21tdXMgcHJvcGVydHlcbiIpOw0KPj4gLQkJcmV0dXJuIC1FU1JDSDsNCj4+ICsJaWYgKGRldl9p
c19wY2koZGV2KSkgew0KPj4gKwkJaWYgKHhlbl9kdF9tYXBfaWQoZGV2LCAmaW9tbXVfc3BlYy5u
cCwgaW9tbXVfc3BlYy5hcmdzKSkgew0KPj4gKwkJCWRldl9lcnIoZGV2LCAiQ2Fubm90IHRyYW5z
bGF0ZSBJRFxuIik7DQo+PiArCQkJcmV0dXJuIC1FU1JDSDsNCj4+ICsJCX0NCj4+ICsJfSBlbHNl
IHsNCj4+ICsJCWlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25vZGUsICJp
b21tdXMiLCAiI2lvbW11LWNlbGxzIiwNCj4+ICsJCQkJMCwgJmlvbW11X3NwZWMpKSB7DQo+PiAr
CQkJZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+ICsJ
CQlyZXR1cm4gLUVTUkNIOw0KPj4gKwkJfQ0KPj4gICAJfQ0KPj4gICANCj4+ICAgCWlmICghb2Zf
ZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfc3BlYy5ucCwgInhlbixncmFudC1kbWEiKSB8fA0K
Pj4gQEAgLTM1NCw2ICs0MTMsNyBAQCBzdGF0aWMgaW50IHhlbl9kdF9ncmFudF9pbml0X2JhY2tl
bmRfZG9taWQoc3RydWN0IGRldmljZSAqZGV2LA0KPj4gICB2b2lkIHhlbl9ncmFudF9zZXR1cF9k
bWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgew0KPj4gICAJc3RydWN0IHhlbl9ncmFu
dF9kbWFfZGF0YSAqZGF0YTsNCj4+ICsJc3RydWN0IGRldmljZV9ub2RlICpucDsNCj4+ICAgDQo+
PiAgIAlkYXRhID0gZmluZF94ZW5fZ3JhbnRfZG1hX2RhdGEoZGV2KTsNCj4+ICAgCWlmIChkYXRh
KSB7DQo+PiBAQCAtMzY1LDggKzQyNSwxMyBAQCB2b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3Bz
KHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgCWlmICghZGF0YSkNCj4+ICAgCQlnb3RvIGVycjsN
Cj4+ICAgDQo+PiAtCWlmIChkZXYtPm9mX25vZGUpIHsNCj4+IC0JCWlmICh4ZW5fZHRfZ3JhbnRf
aW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSkpDQo+PiArCW5wID0geGVuX2R0X2dldF9ub2Rl
KGRldik7DQo+PiArCWlmIChucCkgew0KPj4gKwkJaW50IHJldDsNCj4+ICsNCj4+ICsJCXJldCA9
IHhlbl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoZGV2LCBkYXRhKTsNCj4+ICsJCW9mX25v
ZGVfcHV0KG5wKTsNCj4+ICsJCWlmIChyZXQpDQo+PiAgIAkJCWdvdG8gZXJyOw0KPj4gICAJfSBl
bHNlIGlmIChJU19FTkFCTEVEKENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5UKSkgew0KPj4g
ICAJCWRldl9pbmZvKGRldiwgIlVzaW5nIGRvbTAgYXMgYmFja2VuZFxuIik7DQo+PiAtLSANCj4+
IDIuMjUuMQ0KPj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 17:20:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 17:20:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425969.674112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olCjj-00081n-8f; Wed, 19 Oct 2022 17:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425969.674112; Wed, 19 Oct 2022 17:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olCjj-00081g-5m; Wed, 19 Oct 2022 17:20:11 +0000
Received: by outflank-mailman (input) for mailman id 425969;
 Wed, 19 Oct 2022 17:20:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=e9yj=2U=gmail.com=vsuneja63@srs-se1.protection.inumbo.net>)
 id 1olCji-00081a-26
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 17:20:10 +0000
Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com
 [2a00:1450:4864:20::532])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47871c0a-4fd2-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 19:20:08 +0200 (CEST)
Received: by mail-ed1-x532.google.com with SMTP id b12so26281245edd.6
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 10:20:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47871c0a-4fd2-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=lMyZl1HIk5QbkfXnvfl3s8oUJiKRV8LFjyWmV1q/nj8=;
        b=QwRN7cwYOuoYua00YLen2/+kdC+R68qSIpBLR87GglmMV9M2HK6nfZznxYh97wlSJr
         xaDsov3wSX96O3VAZcVZ/Re0Jxzcxg+Nn2xGuk9xR7goKCRCwUmQ8S0VqHvrzW6oY3n7
         mbG7joZf6/a0Qiktg3173MloNOxFReYZuG/CDGkCdlOCsCz7L4QI+ufInXMfVN+L+PUQ
         7wUPDxEj7e9Rw0gDTjcVyKamcFCD7jJFp/wbH9ekirM4EtnUmWjNoA+fGrn0rnB5DmWW
         tDv53oLy2P+eD+kNQ+QhqiHvFbL1wU9e/6eM/2N2XoSDRaMPyKZ059vRM6tJ8YTvXvxK
         j11w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=lMyZl1HIk5QbkfXnvfl3s8oUJiKRV8LFjyWmV1q/nj8=;
        b=yrI4NOa0IrYKeFhBlvpILds71PRLAukW5+z4aH7E6jDBBnugE7UWUXHsOOa5DX5a5C
         qQEHaUdFs0w89XIwwAQF8u8a4T4HQrcLT3zccfy5AgvZMAKWgjuy4mAPlc9eB0xD0IAO
         I44zgnb2oSODhdl6V5tDzX3Gx5F38SW11eqD1SajVzr+pXl/BUNr3gh/AexyL2UG2pgg
         OsakCXnNvI8YOKodSWSgzPwgaI6Zh/redI3x3HdMytlTt87/qjfG0y4Tmz8e0APldDbz
         9jWpwHnlXixzIUMHWu3LcokwYbkq8Ic4cO9+jZPAvcGtuqzxIIZqNDWgJoNM5h0LQ5ns
         ly9w==
X-Gm-Message-State: ACrzQf1+DbMnoP+I8hNMwv980TBAcKqS8OZkBdzl0b349f3HdbAaYv71
	NlAdfuMLMraPJMVgel0Ie595YPDKdyx+jyCQ+2o=
X-Google-Smtp-Source: AMsMyM7Pdj1LGRdJaiR74nkHHSZSxW9JuEVhx/SDAmdD6B+VMNZadI6OMNCiMMo4h6CR6wCJqX+Ota46yUD2N+fGZBc=
X-Received: by 2002:a05:6402:ca:b0:45c:dbdd:8143 with SMTP id
 i10-20020a05640200ca00b0045cdbdd8143mr8465933edu.213.1666200007592; Wed, 19
 Oct 2022 10:20:07 -0700 (PDT)
MIME-Version: 1.0
References: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop>
 <CALAP8f81ojfVD9n5EMtD7DxY-8uomgENVEQH9Afz7Hk9rfaAsw@mail.gmail.com> <alpine.DEB.2.22.394.2210181213370.4587@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2210181213370.4587@ubuntu-linux-20-04-desktop>
From: Vipul Suneja <vsuneja63@gmail.com>
Date: Wed, 19 Oct 2022 22:49:55 +0530
Message-ID: <CALAP8f9Zgue6WfAk2uRGkg=1Up2Z+eQWqvQ1_Z2=r66Z5fvKoA@mail.gmail.com>
Subject: Re: Porting Xen in raspberry pi4B
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, 
	oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, 
	Bertrand.Marquis@arm.com
Content-Type: multipart/mixed; boundary="000000000000942cc805eb666b30"

--000000000000942cc805eb666b30
Content-Type: multipart/alternative; boundary="000000000000942cc405eb666b2e"

--000000000000942cc405eb666b2e
Content-Type: text/plain; charset="UTF-8"

Hi Stefano,

Thanks for the response!

I am following the same link you shared from the beginning. Tried the
command "vncviewer localhost:0" in DOM0 but same issue "Can't open
display", below are the logs:







*root@raspberrypi4-64:~# vncviewer localhost:0TigerVNC Viewer 64-bit
v1.11.0Built on: 2020-09-08 12:16Copyright (C) 1999-2020 TigerVNC Team and
many others (see README.rst)See https://www.tigervnc.org
<https://www.tigervnc.org> for information on TigerVNC.Can't open display:*

Below are the netstat logs, i couldn't see anything running at port 5900 or
5901:


























*root@raspberrypi4-64:~# netstat -tuwx Active Internet connections (w/o
servers)Proto Recv-Q Send-Q Local Address           Foreign Address
State       tcp        0    164 192.168.1.39:ssh        192.168.1.38:37472
<http://192.168.1.38:37472>      ESTABLISHED Active UNIX domain sockets
(w/o servers)Proto RefCnt Flags       Type       State         I-Node
Pathunix  8      [ ]         DGRAM      CONNECTED      10565 /dev/logunix
 3      [ ]         STREAM     CONNECTED      10891
/var/run/xenstored/socketunix  3      [ ]         STREAM     CONNECTED
 13791 unix  3      [ ]         STREAM     CONNECTED      10843
/var/run/xenstored/socketunix  3      [ ]         STREAM     CONNECTED
 10573 /var/run/xenstored/socketunix  2      [ ]         DGRAM
 CONNECTED      14510 unix  3      [ ]         STREAM     CONNECTED
 13249 unix  2      [ ]         DGRAM      CONNECTED      13887 unix  2
 [ ]         DGRAM      CONNECTED      10599 unix  3      [ ]
STREAM     CONNECTED      14005 unix  3      [ ]         STREAM
CONNECTED      13258 unix  3      [ ]         STREAM     CONNECTED
 13248 unix  3      [ ]         STREAM     CONNECTED      14003 unix  3
 [ ]         STREAM     CONNECTED      10572 /var/run/xenstored/socketunix
 3      [ ]         STREAM     CONNECTED      10786
/var/run/xenstored/socketunix  3      [ ]         DGRAM      CONNECTED
 13186 unix  3      [ ]         STREAM     CONNECTED      10864
/var/run/xenstored/socketunix  3      [ ]         STREAM     CONNECTED
 10812 /var/run/xenstored/socketunix  2      [ ]         DGRAM
 CONNECTED      14083 unix  3      [ ]         STREAM     CONNECTED
 10813 /var/run/xenstored/socket*









*unix  3      [ ]         STREAM     CONNECTED      14068 unix  3      [ ]
        STREAM     CONNECTED      13256 unix  3      [ ]         STREAM
CONNECTED      10571 /var/run/xenstored/socketunix  3      [ ]
STREAM     CONNECTED      10842 unix  3      [ ]         STREAM
CONNECTED      13985 unix  3      [ ]         DGRAM      CONNECTED
 13185 unix  2      [ ]         STREAM     CONNECTED      13884 unix  2
 [ ]         DGRAM      CONNECTED      14528 unix  2      [ ]         DGRAM
     CONNECTED      13785 unix  3      [ ]         STREAM     CONNECTED
 14034 *

Attaching xen log files of /var/log/xen.
I didn't get the role of QEMU here because as mentioned earlier, I am
porting in raspberrypi 4B.

Regards,
Vipul Kumar

On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini <sstabellini@kernel.org>
wrote:

> It usually works the way it is described in the guide:
>
>
> https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest
>
> You don't need to install any VNC-related server software because it is
> already provided by Xen (to be precise it is provided by QEMU working
> together with Xen.)
>
> You only need the vnc client in dom0 so that you can connect, but you
> could also run the vnc client outside from another host. So basically
> the following should work when executed in Dom0 after creating DomU:
>
>   vncviewer localhost:0
>
> Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use
> netstat -taunp to check if there is anything running at port 5900 or
> 5901?
>
> Cheers,
>
> Stefano
>
>
> On Tue, 18 Oct 2022, Vipul Suneja wrote:
> > Hi Stefano,
> >
> > Thanks for the response!
> >
> > I could install tigerVNC, x11vnc & libvncserver in Dom0
> xen-image-minimal but only manage to install libvncserver(couldn't install
> tigervnc
> > & x11vnc because of x11
> > support missing, it's wayland) in DOMU custom graphical image. I tried
> running vncviewer with IP address & port in dom0 to access the domu
> > graphical image display as per below commands.
> >
> >  vncviewer 192.168.1.42:5901
> >
> >  But it showing can't open display, below are the logs:
> >
> > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901
> >
> > TigerVNC Viewer 64-bit v1.11.0
> > Built on: 2020-09-08 12:16
> > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)
> > See https://www.tigervnc.org for information on TigerVNC.
> > Can't open display:
> > root@raspberrypi4-64:~/guest1#
> >
> > I am not exactly sure what the issue is but I thought only libvncserver
> in DOMU could work to get access but it did not work.
> > If TigerVNC is the issue here then is there any other VNC source which
> could be installed for both x11 & wayland supported images?
> >
> > Regards,
> > Vipul Kumar
> >
> > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
> >       VNC is typically easier to setup, because SDL needs extra
> libraries at
> >       build time and runtime. If QEMU is built without SDL support it
> won't
> >       start when you ask for SDL.
> >
> >       VNC should work with both x11 and wayland in your domU. It doesn't
> work
> >       at the x11 level, it exposes a special fbdev device in your domU
> that
> >       should work with:
> >       - a graphical console in Linux domU
> >       - x11
> >       - wayland (but I haven't tested this so I am not 100% sure about
> it)
> >
> >       When you say "it doesn't work", what do you mean? Do you get a
> black
> >       window?
> >
> >       You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
> >       (drivers/video/fbdev/xen-fbfront.c). I would try to get a
> graphical text
> >       console up and running in your domU before attempting x11/wayland.
> >
> >       Cheers,
> >
> >       Stefano
> >
> >       On Mon, 17 Oct 2022, Vipul Suneja wrote:
> >       > Hi,
> >       > Thanks!
> >       >
> >       > I have ported xen minimal image as DOM0 & custom wayland GUI
> based image as DOMU in raspberry pi4B. I am trying to make GUI
> >       display up
> >       > for guest machine. I tried using sdl, included below line in
> guest.conf file
> >       > vfb= [ 'sdl=1' ]
> >       >
> >       > But it is throwing below error:
> >       >
> >       > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
> >       > Parsing config from guest1.cfg
> >       > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain
> 3:error on QMP socket: Connection reset by peer
> >       > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain
> 3:Error happened with the QMP connection to QEMU
> >       > libxl: error: libxl_dm.c:3351:device_model_postconfig_done:
> Domain 3:Post DM startup configs failed, rc=-26
> >       > libxl: error: libxl_create.c:1867:domcreate_devmodel_started:
> Domain 3:device model did not start: -26
> >       > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device
> Model already exited
> >       > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain
> 3:Non-existant domain
> >       > libxl: error: libxl_domain.c:1137:domain_destroy_callback:
> Domain 3:Unable to destroy guest
> >       > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain
> 3:Destruction of domain failed
> >       >
> >       > Another way is VNC, i could install tigervnc in DOM0 but same i
> couldn't in guest machine because it doesn't support
> >       x11(supports wayland
> >       > only). I am completely blocked here, Need your support to enable
> the display up.
> >       > Any alternative of VNC which could work in both x11 & wayland
> supported images?
> >       >
> >       > Any input on VNC, SDL or any other way to proceed on this?
> Looking forward to hearing from you.
> >       >
> >       > Regards,
> >       > Vipul Kumar
> >
> >
> >

--000000000000942cc405eb666b2e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Stefano,<br><br>Thanks for the response!<br><br>I am fo=
llowing the same link you shared from the beginning. Tried the command &quo=
t;vncviewer localhost:0&quot; in DOM0 but same issue &quot;Can&#39;t open d=
isplay&quot;, below are the logs:<br><br><b>root@raspberrypi4-64:~# vncview=
er localhost:0<br><br>TigerVNC Viewer 64-bit v1.11.0<br>Built on: 2020-09-0=
8 12:16<br>Copyright (C) 1999-2020 TigerVNC Team and many others (see READM=
E.rst)<br>See <a href=3D"https://www.tigervnc.org">https://www.tigervnc.org=
</a> for information on TigerVNC.<br>Can&#39;t open display:</b><br><br>Bel=
ow are the netstat logs, i couldn&#39;t see anything running at port 5900 o=
r 5901:<br><br><b>root@raspberrypi4-64:~# netstat -tuwx <br>Active Internet=
 connections (w/o servers)<br>Proto Recv-Q Send-Q Local Address =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 Foreign Address =C2=A0 =C2=A0 =C2=A0 =C2=A0 State =
=C2=A0 =C2=A0 =C2=A0 <br>tcp =C2=A0 =C2=A0 =C2=A0 =C2=A00 =C2=A0 =C2=A0164 =
192.168.1.39:ssh =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"http://192.168.1.38:=
37472">192.168.1.38:37472</a> =C2=A0 =C2=A0 =C2=A0ESTABLISHED <br>Active UN=
IX domain sockets (w/o servers)<br>Proto RefCnt Flags =C2=A0 =C2=A0 =C2=A0 =
Type =C2=A0 =C2=A0 =C2=A0 State =C2=A0 =C2=A0 =C2=A0 =C2=A0 I-Node Path<br>=
unix =C2=A08 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=
=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010565 /dev/log<br>unix =C2=
=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=
=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010891 /var/run/xenstored/socket<br>unix =
=C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =
=C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013791 <br>unix =C2=A03 =C2=A0 =C2=A0 =
=C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0=
 =C2=A0 =C2=A010843 /var/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0=
 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=
=A0 =C2=A0 =C2=A010573 /var/run/xenstored/socket<br>unix =C2=A02 =C2=A0 =C2=
=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECT=
ED =C2=A0 =C2=A0 =C2=A014510 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=
=A013249 <br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013887 <br>unix =
=C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =
=C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010599 <br>unix =C2=A03 =C2=A0 =
=C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED=
 =C2=A0 =C2=A0 =C2=A014005 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A0132=
58 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STR=
EAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013248 <br>unix =C2=A03 =C2=
=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNE=
CTED =C2=A0 =C2=A0 =C2=A014003 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=
=A010572 /var/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =
=C2=A010786 /var/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[=
 ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =
=C2=A0 =C2=A013186 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010864 /var=
/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010812 /va=
r/run/xenstored/socket<br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A01=
4083 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 S=
TREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010813 /var/run/xenstored/=
socket</b><br><b>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014068 <br>unix =
=C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =
=C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013256 <br>unix =C2=A03 =C2=A0 =C2=A0 =
=C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0=
 =C2=A0 =C2=A010571 /var/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0=
 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=
=A0 =C2=A0 =C2=A010842 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013985 =
<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =
=C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013185 <br>unix =C2=A02 =
=C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CO=
NNECTED =C2=A0 =C2=A0 =C2=A013884 <br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=
=A0 =C2=A014528 <br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013785 <b=
r>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =
=C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014034 </b><br><br>Attaching xen=
 log files of /var/log/xen.<br>I didn&#39;t get the role of QEMU here becau=
se as mentioned earlier, I am porting in raspberrypi 4B.<br><div><br></div>=
<div>Regards,</div><div>Vipul Kumar</div></div><br><div class=3D"gmail_quot=
e"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 19, 2022 at 12:43 AM S=
tefano Stabellini &lt;<a href=3D"mailto:sstabellini@kernel.org">sstabellini=
@kernel.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">It usually works the way it is described in the guide:<br>
<br>
<a href=3D"https://www.virtuatopia.com/index.php?title=3DConfiguring_a_VNC_=
based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest" rel=3D"nor=
eferrer" target=3D"_blank">https://www.virtuatopia.com/index.php?title=3DCo=
nfiguring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_G=
uest</a><br>
<br>
You don&#39;t need to install any VNC-related server software because it is=
<br>
already provided by Xen (to be precise it is provided by QEMU working<br>
together with Xen.)<br>
<br>
You only need the vnc client in dom0 so that you can connect, but you<br>
could also run the vnc client outside from another host. So basically<br>
the following should work when executed in Dom0 after creating DomU:<br>
<br>
=C2=A0 vncviewer localhost:0<br>
<br>
Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use<br>
netstat -taunp to check if there is anything running at port 5900 or<br>
5901?<br>
<br>
Cheers,<br>
<br>
Stefano<br>
<br>
<br>
On Tue, 18 Oct 2022, Vipul Suneja wrote:<br>
&gt; Hi Stefano,<br>
&gt; <br>
&gt; Thanks for the response!<br>
&gt; <br>
&gt; I could install tigerVNC, x11vnc &amp; libvncserver in Dom0 xen-image-=
minimal but only manage to install libvncserver(couldn&#39;t install tigerv=
nc<br>
&gt; &amp; x11vnc because of x11<br>
&gt; support missing, it&#39;s wayland) in DOMU custom graphical image. I t=
ried running vncviewer with IP address &amp; port in dom0 to access the dom=
u<br>
&gt; graphical image display as per below commands.<br>
&gt; =C2=A0<br>
&gt; =C2=A0vncviewer <a href=3D"http://192.168.1.42:5901" rel=3D"noreferrer=
" target=3D"_blank">192.168.1.42:5901</a><br>
&gt; =C2=A0<br>
&gt; =C2=A0But it showing can&#39;t open display, below are the logs:<br>
&gt; =C2=A0<br>
&gt; root@raspberrypi4-64:~/guest1# vncviewer <a href=3D"http://192.168.1.4=
2:5901" rel=3D"noreferrer" target=3D"_blank">192.168.1.42:5901</a><br>
&gt; <br>
&gt; TigerVNC Viewer 64-bit v1.11.0<br>
&gt; Built on: 2020-09-08 12:16<br>
&gt; Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)=
<br>
&gt; See <a href=3D"https://www.tigervnc.org" rel=3D"noreferrer" target=3D"=
_blank">https://www.tigervnc.org</a> for information on TigerVNC.<br>
&gt; Can&#39;t open display:<br>
&gt; root@raspberrypi4-64:~/guest1#<br>
&gt; <br>
&gt; I am not exactly=C2=A0sure what the issue is but I thought only libvnc=
server in DOMU could work to get access but it did not work.=C2=A0<br>
&gt; If TigerVNC is the issue here then is there any other VNC source which=
 could be installed for both x11 &amp; wayland supported images?<br>
&gt; <br>
&gt; Regards,<br>
&gt; Vipul Kumar<br>
&gt; <br>
&gt; On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini &lt;<a href=3D"mail=
to:sstabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt;=
 wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC is typically easier to setup, because SD=
L needs extra libraries at<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0build time and runtime. If QEMU is built wit=
hout SDL support it won&#39;t<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0start when you ask for SDL.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC should work with both x11 and wayland in=
 your domU. It doesn&#39;t work<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0at the x11 level, it exposes a special fbdev=
 device in your domU that<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0should work with:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0- a graphical console in Linux domU<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0- x11<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0- wayland (but I haven&#39;t tested this so =
I am not 100% sure about it)<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0When you say &quot;it doesn&#39;t work&quot;=
, what do you mean? Do you get a black<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0window?<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0You need CONFIG_XEN_FBDEV_FRONTEND in Linux =
domU<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0(drivers/video/fbdev/xen-fbfront.c). I would=
 try to get a graphical text<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0console up and running in your domU before a=
ttempting x11/wayland.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Mon, 17 Oct 2022, Vipul Suneja wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Hi,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Thanks!<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I have ported xen minimal image as DOM0=
 &amp; custom wayland GUI based image as DOMU in raspberry pi4B. I am tryin=
g to make GUI<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0display up<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; for=C2=A0guest machine. I tried using=
=C2=A0sdl, included below line in guest.conf file<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; vfb=3D [ &#39;sdl=3D1&#39; ]<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; But it is throwing below error:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; root@raspberrypi4-64:~/guest1# xl creat=
e -c guest1.cfg<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Parsing config from guest1.cfg<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_qmp.c:1400:qmp_ev_f=
d_callback: Domain 3:error on QMP socket: Connection reset by peer<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_qmp.c:1439:qmp_ev_f=
d_callback: Domain 3:Error happened with the QMP connection to QEMU<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_dm.c:3351:device_mo=
del_postconfig_done: Domain 3:Post DM startup configs failed, rc=3D-26<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_create.c:1867:domcr=
eate_devmodel_started: Domain 3:device model did not start: -26<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_aoutils.c:646:libxl=
__kill_xs_path: Device Model already exited<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_domain.c:1183:libxl=
__destroy_domid: Domain 3:Non-existant domain<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_domain.c:1137:domai=
n_destroy_callback: Domain 3:Unable to destroy guest<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_domain.c:1064:domai=
n_destroy_cb: Domain 3:Destruction of domain failed<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Another way is VNC, i could install tig=
ervnc in DOM0 but same i couldn&#39;t in guest machine because it doesn&#39=
;t support<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0x11(supports wayland<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; only). I am completely blocked here, Ne=
ed your support to enable the display up.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Any alternative of VNC which could work=
 in both x11 &amp; wayland supported images?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Any input on VNC, SDL or any other way =
to proceed on this? Looking forward to hearing from you.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Regards,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Vipul Kumar<br>
&gt; <br>
&gt; <br>
&gt; </blockquote></div>

--000000000000942cc405eb666b2e--
--000000000000942cc805eb666b30
Content-Type: application/octet-stream; name="qemu-dm-guest1.log"
Content-Disposition: attachment; filename="qemu-dm-guest1.log"
Content-Transfer-Encoding: base64
Content-ID: <f_l9fvyqy40>
X-Attachment-Id: f_l9fvyqy40

Vk5DIHNlcnZlciBydW5uaW5nIG9uIDEyNy4wLjAuMTo1OTAwCnFlbXUtc3lzdGVtLWkzODY6IHRl
cm1pbmF0aW5nIG9uIHNpZ25hbCAxIGZyb20gcGlkIDY5OCAoeGwpCg==
--000000000000942cc805eb666b30
Content-Type: application/octet-stream; name="xl-guest1.log"
Content-Disposition: attachment; filename="xl-guest1.log"
Content-Transfer-Encoding: base64
Content-ID: <f_l9fvyqyk1>
X-Attachment-Id: f_l9fvyqyk1

V2FpdGluZyBmb3IgZG9tYWluIGd1ZXN0MSAoZG9taWQgMSkgdG8gZGllIFtwaWQgNjY1XQpEb21h
aW4gMSBoYXMgYmVlbiBkZXN0cm95ZWQuCg==
--000000000000942cc805eb666b30--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 17:42:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 17:42:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425975.674124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olD51-000254-2m; Wed, 19 Oct 2022 17:42:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425975.674124; Wed, 19 Oct 2022 17:42:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olD50-00024x-Vu; Wed, 19 Oct 2022 17:42:10 +0000
Received: by outflank-mailman (input) for mailman id 425975;
 Wed, 19 Oct 2022 17:42:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olD4z-00024n-J6; Wed, 19 Oct 2022 17:42:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olD4z-0001Kc-98; Wed, 19 Oct 2022 17:42:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olD4y-0002JU-Sa; Wed, 19 Oct 2022 17:42:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olD4y-0001HE-S2; Wed, 19 Oct 2022 17:42:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OJFVg/hsAc23lLblXhWbjV+3ex5uRbySTl0DyDg6oEE=; b=OM23zY9P0RHWOIYXvLjhd/L5Jb
	7vp9ugpl52v9I6gNS0fTkhsMTe6v+aXVfoNiAocBmIZA9rWC1SzNASoySS10D3M3wbPqxCRlAZW7a
	ZE82YKkIeUyJmimqbKwZaUExsr1Bd7pGbwgGJIdKQ2efsnGryVflNxIWUYrUl3BZG+GQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174012-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174012: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fd92cfed8bc6668d314acd1e6da708a80826f768
X-Osstest-Versions-That:
    linux=1d0da8674c23e8d65398c33a4d5018eaf02e1c64
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 17:42:08 +0000

flight 174012 linux-5.4 real [real]
flight 174098 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174012/
http://logs.test-lab.xenproject.org/osstest/logs/174098/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm   7 xen-install         fail pass in 174098-retest
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 174098-retest
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 174098-retest
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174098-retest

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 174098 never pass
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat    fail like 173806
 test-armhf-armhf-xl-credit2  14 guest-start                  fail  like 173923
 test-armhf-armhf-xl-credit1  18 guest-start/debian.repeat    fail  like 173923
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173923
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173923
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173923
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173923
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173923
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173923
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173923
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173923
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173923
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173923
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 173923
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173923
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173923
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                fd92cfed8bc6668d314acd1e6da708a80826f768
baseline version:
 linux                1d0da8674c23e8d65398c33a4d5018eaf02e1c64

Last test of basis   173923  2022-10-16 11:19:21 Z    3 days
Testing same since   174012  2022-10-17 16:21:11 Z    2 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Ilan Peer <ilan.peer@intel.com>
  Johannes Berg <johannes.berg@intel.com>
  Jon Hunter <jonathanh@nvidia.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Sasha Levin <sashal@kernel.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1d0da8674c23..fd92cfed8bc6  fd92cfed8bc6668d314acd1e6da708a80826f768 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 18:04:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 18:04:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425984.674135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olDQB-0004gk-VQ; Wed, 19 Oct 2022 18:04:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425984.674135; Wed, 19 Oct 2022 18:04:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olDQB-0004gd-Rp; Wed, 19 Oct 2022 18:04:03 +0000
Received: by outflank-mailman (input) for mailman id 425984;
 Wed, 19 Oct 2022 18:04:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Se4D=2U=virtuozzo.com=alexander.atanasov@srs-se1.protection.inumbo.net>)
 id 1olDQ9-0004gX-TX
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 18:04:02 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60134.outbound.protection.outlook.com [40.107.6.134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 678b2a13-4fd8-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 20:03:59 +0200 (CEST)
Received: from VE1PR08MB4765.eurprd08.prod.outlook.com (2603:10a6:802:a5::16)
 by GVXPR08MB8235.eurprd08.prod.outlook.com (2603:10a6:150:16::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct
 2022 18:03:53 +0000
Received: from VE1PR08MB4765.eurprd08.prod.outlook.com
 ([fe80::6809:fef7:a205:b08a]) by VE1PR08MB4765.eurprd08.prod.outlook.com
 ([fe80::6809:fef7:a205:b08a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 18:03:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 678b2a13-4fd8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AqwuEVImSTpQhPDLQMmxbw0yeXTUuqVJ0E2WAwjMtaVqZa0aUl+UFapy5XTbbspT8OYNMPhRvn6jOwVuE+QSuorlqv1bMV79ofAZzGt2rZO0sVD9aarlyZgOcLF05Rkct/d4ms6pneA75ipoJRFxfh/wOPxHSy1tViOxgUuMkJGBL/WcBgKskteL6hBDOtB0OigckNuqLSDBhLdCkmUGnptLrLGPrnsztUkXAitIaTbrOpYjjFcG4uiRsAg2Zs+4/Pb/zaS5dVMl95pdUGky4EIwKX4KzUwNwpV1D4IDHoH19Opsv3oYlit8RVOP0xhMNXTOwshCypVz8raee4XvmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vs+FhT6DfVlbo1rRgiKciFrQ4G+cKMyMKx+ZTDrqppg=;
 b=EXgBZ8QSBM4tIhZUYw8dCY1055q4vilkFG9EXugt4ErK4P+b+9Wzbk+2apb4L6dmagk/ak/4eUPzny+IvxbkEwYNPtCK/OTuP/il9GPE0L0+X5c2/VCoxnwbdX0gZce+KAn7LPYtjz3pceL9LTJ/2ZMtAP/SCfd091/AZL9AbjAxTb6ICK8dCcT8GrlnneP/SsmxqJt7DnUw5t1jZ5xFExzy87Xd/DL2AiogZ1PhxHW64cWVzbRuoTW4+y878CNDOEV5VkrN1d6NCrMc5kR0JUNsNBq0LIHBrmLx1KJLp0u8MKY0kkpLU7l1tQAuoAMpfwIPH8Dsc90MXQAdAaNRqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=virtuozzo.com; dmarc=pass action=none
 header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vs+FhT6DfVlbo1rRgiKciFrQ4G+cKMyMKx+ZTDrqppg=;
 b=BuSEmh9nGARu45P88rDRbFsSp1/B1Qpd9h3vdG9AqBsE+JfFsvSG8KsAilXzjJwtCnmE7naIXPYIlkESJFTy59Er2MCDvu07u9h8bERFrf/YtTGRsGV8z7sbrxZFCjvLLHg1dvEEr+UlD6v1xxOv9b7rBhJt0WW4o7X3Lry8ssH1i4csZMa+ZbrpuFG8hIfJ+E4AZibd+8dr77hv8jeLYz6uJQ0kvi3AjQUdTjEcff9hBy/qjuW7SqnbvPky7BZfpVPppTBCaOm+0cJmuw6btju6nf1Z6SDf4zLHTdOhA1zUPoyJ4qM+LP0RTSxX6HQuagXmaXF6HJSdQhcudPBsBw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=virtuozzo.com;
Message-ID: <022ee579-9347-cf82-d31c-c40d2f5efe12@virtuozzo.com>
Date: Wed, 19 Oct 2022 21:03:50 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to
 the rest of the kernel
To: Konstantin Khlebnikov <koct9i@gmail.com>,
 "Denis V. Lunev" <den@virtuozzo.com>
Cc: kernel@openvz.org, kernel test robot <lkp@intel.com>,
 "Michael S . Tsirkin" <mst@redhat.com>, David Hildenbrand
 <david@redhat.com>, Wei Liu <wei.liu@kernel.org>,
 Nadav Amit <namit@vmware.com>, pv-drivers@vmware.com,
 Jason Wang <jasowang@redhat.com>, virtualization@lists.linux-foundation.org,
 "K. Y. Srinivasan" <kys@microsoft.com>,
 Haiyang Zhang <haiyangz@microsoft.com>,
 Stephen Hemminger <sthemmin@microsoft.com>, Dexuan Cui
 <decui@microsoft.com>, linux-hyperv@vger.kernel.org,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 xen-devel@lists.xenproject.org
References: <20221019095620.124909-1-alexander.atanasov@virtuozzo.com>
 <CALYGNiONv3au6hbAva60jWurwkU5ancWo-o2v7tpSzwguqzD9g@mail.gmail.com>
 <1c69ff97-831d-ece3-7a52-bb7659fc8dd4@virtuozzo.com>
 <CALYGNiMMo7aqgQrcHBWaoU7O9Lpk1qCD2CmRJ5mw+-pFJwFajQ@mail.gmail.com>
From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <CALYGNiMMo7aqgQrcHBWaoU7O9Lpk1qCD2CmRJ5mw+-pFJwFajQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: VE1PR08CA0003.eurprd08.prod.outlook.com
 (2603:10a6:803:104::16) To VE1PR08MB4765.eurprd08.prod.outlook.com
 (2603:10a6:802:a5::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR08MB4765:EE_|GVXPR08MB8235:EE_
X-MS-Office365-Filtering-Correlation-Id: 9f097a35-2691-40bd-505b-08dab1fc4819
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0+88ox2ErcbzznNIKVqOa2QnVyKVOk3NafSDrj7NY8217n8Ki7u9WaZ8mzUxotnLUkN0yAvnLkehA0LIr9G6WQ5pHMB500J0EBi5yJaBfPe6j6DO0WbF5eDBwvLb8oKXEHrQ0aKiReJmnvoUPNIbHfNpGYED6l52vwUvWqB9pWv//3uAEFB0o+sL9WWYLjVEqyJDz2me0XMvruXEyCCG34BMFJeXky0OdwKpTwv9mqAAdwXa5r/ZMmq6w2/PjonvXGeBl43ckHUK2jU213B+3uL9yrZ4x9nXrztr7QJuwwn98sUE/k/zdtZImBkG59BblQ3Dr0Uw/N5JE/QZooxYApD8+M6vHP3fBWgfPTvIq6XgCEPH38yCIDw7LrnUNiyTcqbUSoarMeiHt+ZZbYQ+pWPWX8gbBdN1+wGprcGXWY+zWMqyqSnsxGSJpmC1v7LZdxJbpoYEky8wuPy9A7lTfRAp1scPv8XVf6B3S32CCT0GmaCVYszkZdpMWXp6o67rTh7/qkyKcmakTpptKBNfJzbcJzD1VIoJMuSNflNCotVC878rtehhAtUlLmseCPCtF4/2LD7hobiBHGxtN+WzHyl//jbKXDSD7qnzHpTf67q8Kas5NY/fX5ioKI70Vx0vgmP2IHpzub1rYtHYfQuXxX/fvLzZXKiNsUzKUdH1Z2VawZx8bnPpp2PIWKDEwnX84Y2xHFGOCdTJsXPqahuJKz696IsjCfhV+UMPBgDi4g3e8Watq73NYkW8fYuENXJ7pLxjlGA0m1lBZt3dBCSrdsKXpkYSQyY8KbjAu2kGRXs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB4765.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(366004)(39850400004)(376002)(451199015)(41300700001)(6506007)(54906003)(6636002)(110136005)(316002)(5660300002)(8936002)(86362001)(36756003)(186003)(7416002)(2616005)(44832011)(31696002)(8676002)(4326008)(66556008)(6512007)(66946007)(26005)(66476007)(2906002)(53546011)(31686004)(38100700002)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cGNINHZrZU10ajZPVHF2Vm5XVkJuNXozdmRvNjVrUXdidHZqTmxrS3A4WWdh?=
 =?utf-8?B?OTdQM3RLajBJNTRObGh2bkJoNnNRS0d0N2ppVWJKRmZrZU9RUjk2NndnYi8w?=
 =?utf-8?B?SGRydDdEYVU5OG1xVk5WbGZNendYejlMdFJjcmxoR0dZVXZRbUdVdDhKWEg3?=
 =?utf-8?B?UHhNZ2FIYmRTWC81enJ6N3JBbkpxTERVaUhJRUcrblhiOVIyNkxKdUl0Zlpi?=
 =?utf-8?B?T3U1K0R0WmZYZHhNbFVtcjN6K0lweUMvemROQnd4UWdEU2xIY3pNNXgvaHYx?=
 =?utf-8?B?cWlXT2s5ZHlCeVVOelpNRXdMT2FaQXFGM1NZRUF3VHJZOXZvZjUrbG0yRmdO?=
 =?utf-8?B?RmszMlNlTnYxQ1NicSs5WUFvMmJBNnZ1cXR5aDQ2TWNkaGNhWnZaeVhrS29P?=
 =?utf-8?B?ZWYxb3lBd3lsVWpoVG1rTHlkTGxpMkdyWk05akI0dmtFLzVCcGxBTnJUYXg0?=
 =?utf-8?B?NGZ5Y1BqZG1tYU5lVlU1ajdnVnlYUEMxZ3Z3Qi9vVWZ0Ujd2Q2ROLzczZE9U?=
 =?utf-8?B?RlFKam9rUldwbTBhakxyRHZPUlJhUzZYSVpBT1RzOWVpWHBwWVBqWFZuV2w3?=
 =?utf-8?B?WnpFemVUY05kdlZoOFpVcXVxT0daTUtYTE11bHpyYWMvRENwUEhwNXFPWmdS?=
 =?utf-8?B?Yi9CSzJLb1FoQlNMeTR2MFA5UVloVlEvWWxmNWx0ZVdlbTZNUFdqRDl4aUpW?=
 =?utf-8?B?SXVQZElESEx4MC9VRVUvbXhQMXZUeFRMbEJyTkVFQUgvYXFuK0JDa2dZL1FV?=
 =?utf-8?B?czV4OURGUDVzU1lyL2dNQXJTR2pZNXVuT0pZckwyMVFrdTBaSEdkL2RGV0hO?=
 =?utf-8?B?eWlUeWp2SnRJbElQWHBOOURzOUxnNk82U2NzR1ZlU2FOcjJoaVQ2TmZ3NGpP?=
 =?utf-8?B?SWdibjFjMStvUGdObnREUzJMcEZSSVVoaERGSGNkQjY5NWNESzhVNjc4VXAy?=
 =?utf-8?B?SmIvV1gzaDh1VkZvUW92dVkzWE5Fb1BIMW1Ya0w2a3YweDNqR2t3Y1NHV1Vr?=
 =?utf-8?B?b1l6T0huSTFVRVh1eDhqb2Jqdm5pZm9uVWwvUG5ZZVJIZFhzU0hyMEVWZjFN?=
 =?utf-8?B?WHJDSFJtL2VDK0JqUG5oSFFKRHdsakx2d0JjUzF5eG9FcDZSNjhySHVNTVps?=
 =?utf-8?B?dzVwZFUyRHFtaXlma0lReWk1ZnA4UkRVWlpUcVZ0aVZ6VFhUbkszQnRrdUh2?=
 =?utf-8?B?S01tR2I0ZXdQNXcwakZQd2kvZ1lLd1RiL2lrZ0NHVGcrcUMxU05jVFF4cWZq?=
 =?utf-8?B?WUhRUlhTenpEeUluZjVqR2xsL0V5UXAwczBHZE56SS9VSkk4L2xPcnlPak9z?=
 =?utf-8?B?dlFtakhFNDRFSVVLTG43TU5HcXJJMHVBK1R2VTNlVDdCdldPbDRycEVqSHRn?=
 =?utf-8?B?cVBxTFdIWGV2akhVMXdNNUxGRFBzbWZRU2h1Q21XQmVpYVZPVjZVVzlFUk1w?=
 =?utf-8?B?cUN0K3p6MVhZUzVrLzYySVlrZkJsQ29oVElIK1RmZjVDUCtIbHVBUXhQSVB0?=
 =?utf-8?B?ZnEyOWhsSS9oWC9EMnlWeWdYRG8ydUJTZEFzd044Q0d6ZTJENk9VNmFFU21Y?=
 =?utf-8?B?SDl1dDhWbDRZN2JXWkpqc2IwRWdaU3NiR1pTSGNLVVZoWFc3N2RMVVR2ZEJM?=
 =?utf-8?B?WThYUUVtYWRGdUFEQ1NCMm8wTFFEYTE0aGtkK2NnZVg3WGxnSDgrdGg2ZnpF?=
 =?utf-8?B?SXdaZ0hqSG1vSEw5aUV5K1NPV1hOZkxIMGhlOGY2VmFOWFg4NWZwd3I5blIy?=
 =?utf-8?B?eVJETWd0K0FsVEpKTUJQenA4Rmd4a2MwcytYNlpPSGloVUxUUnF3M0RyVUhF?=
 =?utf-8?B?VWNSaHZGQXd4SjkrZDR2L3lmSmhINmZiejBCNlBTZ0xuT2UyTStXV3hkWVB3?=
 =?utf-8?B?azcrdGdpbmZGUkJJVDArc3BvQ0tFN1A0ZGN6L0dmZFdpbEY2UUtLSnB5ZkVE?=
 =?utf-8?B?QVg4cVlNSGxnVUYwcUVtcVRSeDV0SkZRbUNhSExrZXhiR2NVd09vQ1JxbExJ?=
 =?utf-8?B?aXo1VTMrTmd1S2lOSFFIelI3elJtaTA0YVJmMmJYZFVtT3gyRlF2UC80YVlx?=
 =?utf-8?B?Zm8zYmtNOXNRQ2lpc0xqSFVWb0loNDYwSmlycEtwWk0wSFFQK3Y5RVVra0hD?=
 =?utf-8?B?cXR6YUxhWDZ0MTB0NDRRMWdIY2tjbjZTaVRDNmMvSVBzb3BZbzFxUVN1V0Qz?=
 =?utf-8?B?Tmc9PQ==?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f097a35-2691-40bd-505b-08dab1fc4819
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4765.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 18:03:52.7246
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BXLACakV7ixiNk09rriJ2OUBOckTu8+icagmOL+fDmZraY1odd+7KKtLrgwaK76yqU3xHj+4C607pinQeAYCfvh2cTtBZXh1+u0fiZYPBSHnoxfLSWmMQLzPgRGE5FmI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB8235

On 19.10.22 18:39, Konstantin Khlebnikov wrote:
> 
> 
> On Wed, 19 Oct 2022 at 14:06, Denis V. Lunev <den@virtuozzo.com 
> <mailto:den@virtuozzo.com>> wrote:
> 
>     On 10/19/22 12:53, Konstantin Khlebnikov wrote:
>      > On Wed, 19 Oct 2022 at 12:57, Alexander Atanasov
>      > <alexander.atanasov@virtuozzo.com
>     <mailto:alexander.atanasov@virtuozzo.com>> wrote:
>      >
>      >     Currently balloon drivers (Virtio,XEN, HyperV, VMWare, ...)
>      >     inflate and deflate the guest memory size but there is no
>      >     way to know how much the memory size is changed by them.
>      >
>      >     Make it possible for the drivers to report the values to mm core.
>      >
>      >     Display reported InflatedTotal and InflatedFree in /proc/meminfo
>      >     and print these values on OOM and sysrq from show_mem().
>      >
>      >     The two values are the result of the two modes the drivers work
>      >     with using adjust_managed_page_count or without.
>      >
>      >     In earlier versions, there was a notifier for these changes
>      >     but after discussion - it is better to implement it in separate
>      >     patch series. Since it came out as larger work than initially
>      >     expected.
>      >
>      >     Amount of inflated memory can be used:
>      >      - totalram_pages() users working with drivers not using
>      >         adjust_managed_page_count
>      >      - si_meminfo(..) users can improve calculations
>      >      - by userspace software that monitors memory pressure
>      >
>      >
>      > Sorry, I see no reason for that series.
>      > Balloon inflation adjusts totalram_pages. That's enough.
>      >
>     no, they are not at least under some circumstances, f.e.
>     virtio balloon does not do that with VIRTIO_BALLOON_F_DEFLATE_ON_OOM
>     set
> 
> 
>      > There is no reason to know the amount of non-existent ballooned
>     memory
>      > inside.
>      > Management software which works outside should care about that.
>      >
>     The problem comes at the moment when we are running
>     our Linux server inside virtual machine and the customer
>     comes with crazy questions "where our memory?".
> 
> 
> Ok. In this case balloon management is partially inside VM.
> I.e. we could report portion of balloon as potentially available memory.
> 
> I guess memory pressure could deflate balloon till some threshold set by 
> external hypervisor.
> So, without knowledge about this threshold there is no correct answer 
> about size of available memory.
> Showing just size of balloon doesn't gives much.

You need the current and the adjustment to get the absolute top.
If you check only totalram_pages() it is the current. To get the 
absolute maximum you need to know how much the balloon adjusted it.

The drivers that do not adjust totalram_pages() and leave the inflated 
memory as used assume that this memory can be reclaimed at anytime.
But that assumption is not completely true and provides the system with 
false totalram value. Why - VMWare does not have oom_notifier at all (it 
is possible to have sone other mechanism, i do not know), Virtio balloon 
reclaims 1MB on OOM _if_ it can.

-- 
Regards,
Alexander Atanasov



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 19:02:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 19:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425990.674147 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olEKf-0002Te-AG; Wed, 19 Oct 2022 19:02:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425990.674147; Wed, 19 Oct 2022 19:02:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olEKf-0002TX-5r; Wed, 19 Oct 2022 19:02:25 +0000
Received: by outflank-mailman (input) for mailman id 425990;
 Wed, 19 Oct 2022 19:02:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olEKd-0002TN-Dv; Wed, 19 Oct 2022 19:02:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olEKd-0002rD-BD; Wed, 19 Oct 2022 19:02:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olEKc-000432-TI; Wed, 19 Oct 2022 19:02:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olEKc-0006BB-Ss; Wed, 19 Oct 2022 19:02:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CgRyzFyKTqd5Bd0/qQWx1P4aQGwNOk32fD7Jt/iLwa4=; b=EEhAEHVMJ/bUqwwk3ql5aX1fnv
	eJ9P4hicj9eWQPlDXpI4dq6hZTKx02QsIepQFrMqU7p+wTirq9O9I0JN8+/cL4kzYSsG/QIpttifU
	ZNx5JaU4p+X8/ONRG/X6gkwYayOdD6UnhO/rQAe8+ayr1+bZSLQootjl92QSQdbu5CFI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174096-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174096: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 19:02:22 +0000

flight 174096 xen-unstable-smoke real [real]
flight 174100 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174096/
http://logs.test-lab.xenproject.org/osstest/logs/174100/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   12 days
Failing since        173492  2022-10-11 13:01:50 Z    8 days   53 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    2 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 19:41:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 19:41:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.425998.674157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olEwT-0006r7-7a; Wed, 19 Oct 2022 19:41:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 425998.674157; Wed, 19 Oct 2022 19:41:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olEwT-0006r0-4m; Wed, 19 Oct 2022 19:41:29 +0000
Received: by outflank-mailman (input) for mailman id 425998;
 Wed, 19 Oct 2022 19:41:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tv8N=2U=epam.com=prvs=22918d0935=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1olEwR-0006qX-Ly
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 19:41:27 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03ad7c5f-4fe6-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 21:41:25 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29JFd2oE001167;
 Wed, 19 Oct 2022 19:41:20 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2052.outbound.protection.outlook.com [104.47.2.52])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3kam2m0pg9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 19 Oct 2022 19:41:19 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by PAXPR03MB8141.eurprd03.prod.outlook.com (2603:10a6:102:2bd::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct
 2022 19:41:16 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 19:41:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03ad7c5f-4fe6-11ed-91b4-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FT0oFeY//55DzBYs+XZ9JtyY59t/sJJYUnYjhUAINIEH1m4wS8wWRV3FhlPhpdHBa9eofrtzFWcMBKHBPc2phPNiAqsUrKFGwsuspWRJ8HujV686PYdfKq+eNqdjtoFpPEHKLJSKYuhYUyf8Mbo6BVKryxUaN0Kbl4UUR0str/viM5HaICZ1j8PHC0Xk8Y6ifyJJD/ZT88g3skOpFEG+Mg9vhAnaa6dptdfjVyE0YKHOghRID0KWAE5KylmQ2eD9713oCLByT9V/XwD9H9/jo0PWuCZxr7wLjzHcT8Ny/fKJs1KrMAitkGrK0tpPsQMrhU8zCbw7LRrRrQqlVjwUew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fvXVPPkqvnIe4BKrnrJ//c5ja2iVsia1EdJ7iOPrQRc=;
 b=DGKMCc6A31lsQTjhSigltCnCF9eDDH8iiAm8drIO93yvbPQmWeXPxua1aDeq3Ir12IfZdKqRry7PLnjKrHyIEPJTggeYqRDhjMcKsUPiN+asl2zI3N4gc7EYqps9cCmIEzQMoPUs8gymL9443KwMVdGFoY4BL3xcczuwWfEEZlI/QUgWis2yhrbtg9DRQ0PUyvmLVzkp2A42wjM9sFkXVxcotUGTq+FOwQKIshPXcyXgu4rX/pcFJaODKDE3a7x3nIzqpAvO9uqgHuyeUskNu26MgsKeHcmdZo+NdR19GkgwvdsdqhzE8U/vVKsIFVrfIBqsLiZUIDj/74C2+KKwWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fvXVPPkqvnIe4BKrnrJ//c5ja2iVsia1EdJ7iOPrQRc=;
 b=iv2zSLE6urGQWNoNBuYz/c72wm1Pgn8R/1MxozbZXZPcdcuYfyPIe3RZva4lAxLS1K96t6UJtoJfORub70d3KkS9fmWrxwhgRLvFD9IMPSe2NbAOPj0J/5V82yUu6U3aWnqd8hrI33cROeLCyI5vxX/gYuTOlYtv8VKB7CY1KOHHoAKEtLXwZfjHztXpA4Yc0VsTPGwlLLApubCraeZYu5Qwd23DqHT80K4McrHyhq9mMJvxjYIjQjCMyegIbH8an0IUtIHUChKWiW3MKaecn++xVycVRMKdZClsyB4cxQoI7CQNBGuLCJyAg7+C077nrSViNIf3H9Fs/xQhOAfnvg==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr
 Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64U6lSAgACDRYCAALaPgA==
Date: Wed, 19 Oct 2022 19:41:16 +0000
Message-ID: <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
In-Reply-To: <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|PAXPR03MB8141:EE_
x-ms-office365-filtering-correlation-id: 9f4c8e8f-9956-423a-786e-08dab209e334
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 8sv2myu0NScst7Sf+SZ/2/MXEYxO/IS+yYMECNLZoP1ffFH+g/yx4m8l/VQbzJ3VZk1VN2h7ho9jmzsTr1aQmpTEV6C4hJI+laxP9PcwKziDMTOnVS4UVZ5vsAm6l+apYpi5QoXWu2rAZgsN5v3Rt6q1fgisabDLFuz3OvSYnNtX7nmX3V9arozojNQG4gG7om3zKLiEHEwT0EjFehF7Gva8aLT2mUEGj1fhSu/YC58YbtntMkIjVp4czXPQ+j5cXyQUDtdakNxq4MFt4qgMr3uFtViVoMPgtnOfkh7P7SUbdaeM0mkA547i3FkasRjx2hgt69CK9GPr3ji48+GyE+UYJvOk3Btn8/8nwlcWqMANNK/KpRahmcvO7Ep8ILaA6Kq8RR7NZIfdz2O/FreTSQJEkSC/Mggvl7+we16WoINGIp+QbNuL7Kz6R+vXcHeFEY/6nxwL+vcIwnGtU4ggeotzGZns4Zf2OchW+ecPxLSHv8CkJeur3osqc3mJZkPitGisGJzARHXQrooTHzAiIHFlyLLs1SRROcMoQLQPUrdEOjFIkipcafPnYHG7PKfhPbGz9UnUU5yQHAfDj7Y3FUjDN7g/gZleH3uaZmaDo241gFToal/RBD0mwKF2o0ISBFitS1X8xiOq7vxUb1/E/6MF73Rn3Kqv7VDgY0zzjUa8zhu/uC75k1VkbAaTrhM8SKOqb2HLOuYghPKBWLQ75/DwBPWiXiZT7O9HWBNpKi6mAB1SByAxSkOwWyLgFKznGXDB1ve/GbuGNdeoa2GTfMO/UcHwiQlP4o13KUlDVAx5X8U57Qh8poet1/BeTd50S50JqG1FMTaBXLTV4gutYyU4+SJaTb4sXFT1hkrZGGw=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199015)(6916009)(4326008)(5660300002)(54906003)(53546011)(55236004)(6506007)(8676002)(66446008)(66946007)(76116006)(66556008)(66476007)(91956017)(36756003)(8936002)(316002)(6512007)(26005)(41300700001)(64756008)(38100700002)(38070700005)(122000001)(2616005)(186003)(2906002)(86362001)(31696002)(83380400001)(71200400001)(31686004)(478600001)(6486002)(966005)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TmlKTlFpVVlGYjJBZ3NOamlhRERhWTVFcGV5TWRPdTJmbnM4MmppeW5MOW5F?=
 =?utf-8?B?SGFpSy9tWkVOYWJUbEswYlVpRlBPdUU0SjVSWExqY3pybmoxQ3JZWjFJYUJS?=
 =?utf-8?B?MndMMVRVemFzYzlNb0xWM0dmd1Q2NHRJOFoxVDV1b293K1VGKzJDRFdkMkM5?=
 =?utf-8?B?TlpRUENRWThnV3RPdUdUUjNwTmtTUzFTNTRVTjE2bUtVY0o3VU5KVFA2SlhF?=
 =?utf-8?B?ZGlKTWhPTFRLMlFMbm5FbWZlODNwY1RaZHBLQjBvYzRsRmhRRDdNaU11QkxQ?=
 =?utf-8?B?M2Y4ZEZSNnM0eXpiejl4WUxhSmR6eXdoaUhUSlQrTEpwK0w1bllVL1ArN1ZW?=
 =?utf-8?B?MXJqeWI2ZXhCajNtWXJuaERwZmFOY2I3eldFN01HL0JGVVI5VU5sT0lOcjBT?=
 =?utf-8?B?eSs3UC9KeUlTMk51UjdGeVFOUVRLWW9lKzZZSEN5UExEUGF0c2lnZk1rVnlo?=
 =?utf-8?B?NnhWdkJBNm9hTmt0RkhXNEpaTkMxbnQ4cHBPajNqWDZpb2JjNUo1U0pqV1Q0?=
 =?utf-8?B?ajhkMXR2QVRHK3RGQnl5aDNsWVhUWVg1cWRhRUIwRTgzRVZHd2x2bndoMDR2?=
 =?utf-8?B?NDhGUGcrdjU3Uk5NcFNVWkhsd1NMMUVWQk9IRGN2eHlDQTl4NU9PSXhxb0Rr?=
 =?utf-8?B?bkNyL0xzQUJiYTBJL05MenlWZlRhQ2dZbWFLUVVBNXVPcnY1UFlSd05VODMy?=
 =?utf-8?B?MGNlUGJmZlNjMGRvNUt1NnY2RHVFUHNvaHBob3M1aTJVZ1kwaDZxc1hmTUdu?=
 =?utf-8?B?MXgyQWVKdjFBbnFzcDJoeG5Ibk52OTQwL0VhZ3lmQUxwQlpmMFNZMWVXU0g2?=
 =?utf-8?B?ajFGcmZsbTJMWFRrRXIwMk9oMSttUlh4dWI1eHF5clVDRWNPNDViS2puT2hM?=
 =?utf-8?B?UHJqSlBHSzhZZHhaaGczR283M21aT3pJS256TTltdGl4dHhQSlZHMjJhbGdy?=
 =?utf-8?B?YmlzK2hhMFN5RXYzanVkSjN6YmNwdVdhRU4ra3dEWHZjcGxnMURucGFMMEFE?=
 =?utf-8?B?V01XZHEydWZHdkFmR29pWHJZUmh0bnNHclJHdXdwT2ZDb1FXRnUvbTRoejVI?=
 =?utf-8?B?MGh3cklCOW05ZEhKQVVIL2lHaXMzQ2lMWDFyanJrYjdLd1B6eXk4NzZxZUln?=
 =?utf-8?B?cC9HM1g1VkU3djN4TGp4RUhTZ0NveXRqaGlmbVZyN3pINkxCN1p4d1NIMko0?=
 =?utf-8?B?NFpHdThFa25pMzgySFkvalR3eldDb3BrcmRTSGNmYUVYTzB0Zi9CcEp6d2Rq?=
 =?utf-8?B?U1gyV09VTUtZUHBCLzRmNDhvd21vbGNWNjkxMzFBR3FxaEVNRENNSElrRXhI?=
 =?utf-8?B?QU1KQWI2U2hkWVRhbGIzUEdGRTlpZnlydEZwTkphWjJscEhvMjZvZEZMamoy?=
 =?utf-8?B?RnlqK1ZRZmhzdUZKM3UwL1l6YzdiN1RXeDJKQWY2RkRZTEFwK1dFdk44TW1S?=
 =?utf-8?B?MEV3RTNqZlNuTzRmcjVCdURjNDRsbzR0S1MrNFFPUm1yZEhjeHJvaGZWbTZE?=
 =?utf-8?B?ZDJhaVJoL1BvSExDUWhzckVEUnFiY1V0Q2daY040WXcxdjlhVytRbmtkbkJz?=
 =?utf-8?B?ZXdRYWh1dFowMkV5eWwvN3hxejdFSkw3STR4M3k0WGtmRmRxeU40V2pwSEZr?=
 =?utf-8?B?V2hvQmIwSjg5ZUhFdnFydmU3MitjV2VLbDgxSm1LSkdWcXlMVWRPU1VQRVpQ?=
 =?utf-8?B?ekl0b25aZk9wVXc3N3B3bnNQd2JEalNTWmV4SWpSTU04eGk4eHdSMEVHTlF6?=
 =?utf-8?B?V0JXTEkvTXBQNkd4WGVzMktoV1FpYXMxMDFCSzFqdXpta0FJdGVZNkE0YkVh?=
 =?utf-8?B?d0ljK0tLMGo3WXgyaWpIa1FWSWsyTlBrdS9pOU1CYTZrQUJVaksyak0vZFBM?=
 =?utf-8?B?aEJQYnBhOExTMU40UW91bXNHR20vd1o2OFYydkFneFJkdytjYndhSlVwb1lX?=
 =?utf-8?B?THl4cGVucE5iVThyNVpEYmIveGkzcVU1UzMvVXgvL1RXTG5RVHlLTWJUbi9u?=
 =?utf-8?B?ZWt4eldOeDE0RzVqZGh1L2FacTF4WjY0Y2IyM09qdFFtRi9ZeXA5NVNRbzNs?=
 =?utf-8?B?SllQdEdleWVqeVFPUHlXUVNhWkpPSkY0RmxjMjY5Z09CbDd0UHVtdFhzcVNt?=
 =?utf-8?B?WUlubC9ISE9RdjBnd2wwWUVzTFBVQlNDbjNvRmtONFhveGVGdG1KVTJNalN5?=
 =?utf-8?Q?A0umBO2bdYhNoYeNvE6NW9c=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2CAE717240B33242B698F9CB2557A906@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4c8e8f-9956-423a-786e-08dab209e334
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 19:41:16.2350
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SbGLZ+KtV9Mc8lfse3dfbT9fpuoD6PZOtI2V37tufKDhP3vwN1uzb1j1tVftoEgmsEpQC2TPR/NYKNw9N4oqm8ShLgvWSNX4+sVGZPQ8sdY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8141
X-Proofpoint-GUID: IgTgnjEVAA4_gHrOWDekb_Q0tHD2oeIh
X-Proofpoint-ORIG-GUID: IgTgnjEVAA4_gHrOWDekb_Q0tHD2oeIh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-19_11,2022-10-19_04,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 clxscore=1015 lowpriorityscore=0
 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210190110

DQpPbiAxOS4xMC4yMiAxMTo0NywgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KSGVsbG8gWGVu
aWENCg0KPiBPbiAxMC8xOS8yMiAwMzo1OCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4g
T24gU2F0LCAxNSBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4gRnJv
bTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0K
Pj4+DQo+Pj4gVXNlIHRoZSBzYW1lICJ4ZW4tZ3JhbnQtZG1hIiBkZXZpY2UgY29uY2VwdCBmb3Ig
dGhlIFBDSSBkZXZpY2VzDQo+Pj4gYmVoaW5kIGRldmljZS10cmVlIGJhc2VkIFBDSSBIb3N0IGNv
bnRyb2xsZXIsIGJ1dCB3aXRoIG9uZSANCj4+PiBtb2RpZmljYXRpb24uDQo+Pj4gVW5saWtlIGZv
ciBwbGF0Zm9ybSBkZXZpY2VzLCB3ZSBjYW5ub3QgdXNlIGdlbmVyaWMgSU9NTVUgYmluZGluZ3MN
Cj4+PiAoaW9tbXVzIHByb3BlcnR5KSwgYXMgd2UgbmVlZCB0byBzdXBwb3J0IG1vcmUgZmxleGli
bGUgY29uZmlndXJhdGlvbi4NCj4+PiBUaGUgcHJvYmxlbSBpcyB0aGF0IFBDSSBkZXZpY2VzIHVu
ZGVyIHRoZSBzaW5nbGUgUENJIEhvc3QgY29udHJvbGxlcg0KPj4+IG1heSBoYXZlIHRoZSBiYWNr
ZW5kcyBydW5uaW5nIGluIGRpZmZlcmVudCBYZW4gZG9tYWlucyBhbmQgdGh1cyBoYXZlDQo+Pj4g
ZGlmZmVyZW50IGVuZHBvaW50cyBJRCAoYmFja2VuZCBkb21haW5zIElEKS4NCj4+Pg0KPj4+IFNv
IHVzZSBnZW5lcmljIFBDSS1JT01NVSBiaW5kaW5ncyBpbnN0ZWFkIChpb21tdS1tYXAvaW9tbXUt
bWFwLW1hc2sNCj4+PiBwcm9wZXJ0aWVzKSB3aGljaCBhbGxvd3MgdXMgdG8gZGVzY3JpYmUgcmVs
YXRpb25zaGlwIGJldHdlZW4gUENJDQo+Pj4gZGV2aWNlcyBhbmQgYmFja2VuZCBkb21haW5zIElE
IHByb3Blcmx5Lg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28g
PG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+IE5vdyB0aGF0IEkgdW5kZXJz
dG9vZCB0aGUgYXBwcm9hY2ggYW5kIHRoZSByZWFzb25zIGZvciBpdCwgSSBjYW4gcmV2aWV3DQo+
PiB0aGUgcGF0Y2ggOi0pDQo+Pg0KPj4gUGxlYXNlIGFkZCBhbiBleGFtcGxlIG9mIHRoZSBiaW5k
aW5ncyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuDQo+Pg0KPj4NCj4+PiAtLS0NCj4+PiBTbGlnaHRs
eSBSRkMuIFRoaXMgaXMgbmVlZGVkIHRvIHN1cHBvcnQgWGVuIGdyYW50IG1hcHBpbmdzIGZvciAN
Cj4+PiB2aXJ0aW8tcGNpIGRldmljZXMNCj4+PiBvbiBBcm0gYXQgc29tZSBwb2ludCBpbiB0aGUg
ZnV0dXJlLiBUaGUgWGVuIHRvb2xzdGFjayBzaWRlIGlzIG5vdCANCj4+PiBjb21wbGV0ZWx5IHJl
YWR5IHlldC4NCj4+PiBIZXJlLCBmb3IgUENJIGRldmljZXMgd2UgdXNlIG1vcmUgZmxleGlibGUg
d2F5IHRvIHBhc3MgYmFja2VuZCBkb21pZCANCj4+PiB0byB0aGUgZ3Vlc3QNCj4+PiB0aGFuIGZv
ciBwbGF0Zm9ybSBkZXZpY2VzLg0KPj4+DQo+Pj4gQ2hhbmdlcyBWMSAtPiBWMjoNCj4+PiDCoMKg
wqAgLSB1cGRhdGUgY29tbWl0IGRlc2NyaXB0aW9uDQo+Pj4gwqDCoMKgIC0gcmViYXNlDQo+Pj4g
wqDCoMKgIC0gcmV3b3JrIHRvIHVzZSBnZW5lcmljIFBDSS1JT01NVSBiaW5kaW5ncyBpbnN0ZWFk
IG9mIGdlbmVyaWMgDQo+Pj4gSU9NTVUgYmluZGluZ3MNCj4+Pg0KPj4+IFByZXZpb3VzIGRpc2N1
c3Npb24gaXMgYXQ6DQo+Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbG9y
ZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIyMTAwNjE3NDgwNC4yMDAzMDI5LTEtb2xla3N0eXNo
QGdtYWlsLmNvbS9fXzshIUdGXzI5ZGJjUUlVQlBBITMtdnE3RWRtM1hmS3RENWNuTmpuT3pEUXZ1
b19YcmhKNzN5SC1uUGZxT2tHR1UwSWpMRzdSN01SX25BSkNBUGVPdXRIUkxUNDR3S1l3UXd6M1Nh
dUFDaWVfWkF5JCANCj4+PiBbbG9yZVsuXWtlcm5lbFsuXW9yZ10NCj4+Pg0KPj4+IEJhc2VkIG9u
Og0KPj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2dpdC5rZXJuZWwub3Jn
L3B1Yi9zY20vbGludXgva2VybmVsL2dpdC94ZW4vdGlwLmdpdC9sb2cvP2g9Zm9yLWxpbnVzLTYu
MV9fOyEhR0ZfMjlkYmNRSVVCUEEhMy12cTdFZG0zWGZLdEQ1Y25Oam5PekRRdnVvX1hyaEo3M3lI
LW5QZnFPa0dHVTBJakxHN1I3TVJfbkFKQ0FQZU91dEhSTFQ0NHdLWXdRd3ozU2F1QUVuTURIQXEk
IA0KPj4+IFtnaXRbLl1rZXJuZWxbLl1vcmddDQo+Pj4gLS0tDQo+Pj4gwqAgZHJpdmVycy94ZW4v
Z3JhbnQtZG1hLW9wcy5jIHwgODcgDQo+Pj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KystLS0tLQ0KPj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA3NiBpbnNlcnRpb25zKCspLCAxMSBkZWxl
dGlvbnMoLSkNCj4+Pg0KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+PiBpbmRleCBkYWE1MjVkZjdiZGMu
LmI3OWQ5ZDZjZTE1NCAxMDA2NDQNCj4+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMNCj4+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+PiBAQCAtMTAsNiAr
MTAsNyBAQA0KPj4+IMKgICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4NCj4+PiDCoCAjaW5jbHVk
ZSA8bGludXgvZG1hLW1hcC1vcHMuaD4NCj4+PiDCoCAjaW5jbHVkZSA8bGludXgvb2YuaD4NCj4+
PiArI2luY2x1ZGUgPGxpbnV4L3BjaS5oPg0KPj4+IMKgICNpbmNsdWRlIDxsaW51eC9wZm4uaD4N
Cj4+PiDCoCAjaW5jbHVkZSA8bGludXgveGFycmF5Lmg+DQo+Pj4gwqAgI2luY2x1ZGUgPGxpbnV4
L3ZpcnRpb19hbmNob3IuaD4NCj4+PiBAQCAtMjkyLDEyICsyOTMsNTUgQEAgc3RhdGljIGNvbnN0
IHN0cnVjdCBkbWFfbWFwX29wcyANCj4+PiB4ZW5fZ3JhbnRfZG1hX29wcyA9IHsNCj4+PiDCoMKg
wqDCoMKgIC5kbWFfc3VwcG9ydGVkID0geGVuX2dyYW50X2RtYV9zdXBwb3J0ZWQsDQo+Pj4gwqAg
fTsNCj4+PiDCoCArc3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9wY2lfaG9z
dF9ub2RlKHN0cnVjdCBkZXZpY2UgDQo+Pj4gKmRldikNCj4+PiArew0KPj4+ICvCoMKgwqAgc3Ry
dWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQo+Pj4gK8KgwqDCoCBzdHJ1Y3Qg
cGNpX2J1cyAqYnVzID0gcGRldi0+YnVzOw0KPj4+ICsNCj4+PiArwqDCoMKgIC8qIFdhbGsgdXAg
dG8gdGhlIHJvb3QgYnVzIHRvIGxvb2sgZm9yIFBDSSBIb3N0IGNvbnRyb2xsZXIgKi8NCj4+PiAr
wqDCoMKgIHdoaWxlICghcGNpX2lzX3Jvb3RfYnVzKGJ1cykpDQo+Pj4gK8KgwqDCoMKgwqDCoMKg
IGJ1cyA9IGJ1cy0+cGFyZW50Ow0KPj4+ICsNCj4+PiArwqDCoMKgIHJldHVybiBvZl9ub2RlX2dl
dChidXMtPmJyaWRnZS0+cGFyZW50LT5vZl9ub2RlKTsNCj4+PiArfQ0KPj4NCj4+IEl0IHNlZW1z
IHNpbGx5IHRoYXQgd2UgbmVlZCB0byB3YWxrIHRoZSBoaWVyYWNoeSB0aGF0IHdheSwgYnV0IEkN
Cj4+IGNvdWxkbid0IGZpbmQgYW5vdGhlciB3YXkgdG8gZG8gaXQNCj4+DQo+Pg0KPj4+ICtzdGF0
aWMgc3RydWN0IGRldmljZV9ub2RlICp4ZW5fZHRfZ2V0X25vZGUoc3RydWN0IGRldmljZSAqZGV2
KQ0KPj4+ICt7DQo+Pj4gK8KgwqDCoCBpZiAoZGV2X2lzX3BjaShkZXYpKQ0KPj4+ICvCoMKgwqDC
oMKgwqDCoCByZXR1cm4geGVuX2R0X2dldF9wY2lfaG9zdF9ub2RlKGRldik7DQo+Pj4gKw0KPj4+
ICvCoMKgwqAgcmV0dXJuIG9mX25vZGVfZ2V0KGRldi0+b2Zfbm9kZSk7DQo+Pj4gK30NCj4+PiAr
DQo+Pj4gK3N0YXRpYyBpbnQgeGVuX2R0X21hcF9pZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVj
dCBkZXZpY2Vfbm9kZSANCj4+PiAqKmlvbW11X25wLA0KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgdTMyICpzaWQpDQo+Pj4gK3sNCj4+PiArwqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2
ID0gdG9fcGNpX2RldihkZXYpOw0KPj4+ICvCoMKgwqAgdTMyIHJpZCA9IFBDSV9ERVZJRChwZGV2
LT5idXMtPm51bWJlciwgcGRldi0+ZGV2Zm4pOw0KPj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9u
b2RlICpob3N0X25wOw0KPj4+ICvCoMKgwqAgaW50IHJldDsNCj4+PiArDQo+Pj4gK8KgwqDCoCBo
b3N0X25wID0geGVuX2R0X2dldF9wY2lfaG9zdF9ub2RlKGRldik7DQo+Pj4gK8KgwqDCoCBpZiAo
IWhvc3RfbnApDQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5PREVWOw0KPj4+ICsNCj4+
PiArwqDCoMKgIHJldCA9IG9mX21hcF9pZChob3N0X25wLCByaWQsICJpb21tdS1tYXAiLCAiaW9t
bXUtbWFwLW1hc2siLCANCj4+PiBpb21tdV9ucCwgc2lkKTsNCj4+PiArwqDCoMKgIG9mX25vZGVf
cHV0KGhvc3RfbnApOw0KPj4+ICvCoMKgwqAgcmV0dXJuIHJldDsNCj4+PiArfQ0KPj4+ICsNCj4+
PiDCoCBzdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNl
ICpkZXYpDQo+Pj4gwqAgew0KPj4+IC3CoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICppb21tdV9u
cDsNCj4+PiArwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBOVUxMOw0KPj4+
IMKgwqDCoMKgwqAgYm9vbCBoYXNfaW9tbXU7DQo+Pj4gwqAgLcKgwqDCoCBpb21tdV9ucCA9IG9m
X3BhcnNlX3BoYW5kbGUoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgMCk7DQo+Pj4gK8KgwqDCoCBp
ZiAoZGV2X2lzX3BjaShkZXYpKSB7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICh4ZW5fZHRfbWFw
X2lkKGRldiwgJmlvbW11X25wLCBOVUxMKSkNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBy
ZXR1cm4gZmFsc2U7DQo+Pj4gK8KgwqDCoCB9IGVsc2UNCj4+PiArwqDCoMKgwqDCoMKgwqAgaW9t
bXVfbnAgPSBvZl9wYXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPj4+
ICsNCj4+PiDCoMKgwqDCoMKgIGhhc19pb21tdSA9IGlvbW11X25wICYmDQo+Pj4gwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfbnAsICJ4ZW4s
Z3JhbnQtZG1hIik7DQo+Pj4gwqDCoMKgwqDCoCBvZl9ub2RlX3B1dChpb21tdV9ucCk7DQo+Pj4g
QEAgLTMwNyw5ICszNTEsMTcgQEAgc3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50X2RtYV9kZXZp
Y2Uoc3RydWN0IA0KPj4+IGRldmljZSAqZGV2KQ0KPj4+IMKgIMKgIGJvb2wgeGVuX2lzX2dyYW50
X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4+IMKgIHsNCj4+PiArwqDCoMKgIHN0
cnVjdCBkZXZpY2Vfbm9kZSAqbnA7DQo+Pj4gKw0KPj4+IMKgwqDCoMKgwqAgLyogWFhYIEhhbmRs
ZSBvbmx5IERUIGRldmljZXMgZm9yIG5vdyAqLw0KPj4+IC3CoMKgwqAgaWYgKGRldi0+b2Zfbm9k
ZSkNCj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNl
KGRldik7DQo+Pj4gK8KgwqDCoCBucCA9IHhlbl9kdF9nZXRfbm9kZShkZXYpOw0KPj4+ICvCoMKg
wqAgaWYgKG5wKSB7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGJvb2wgcmV0Ow0KPj4+ICsNCj4+PiAr
wqDCoMKgwqDCoMKgwqAgcmV0ID0geGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2UoZGV2KTsNCj4+
PiArwqDCoMKgwqDCoMKgwqAgb2Zfbm9kZV9wdXQobnApOw0KPj4+ICvCoMKgwqDCoMKgwqDCoCBy
ZXR1cm4gcmV0Ow0KPj4+ICvCoMKgwqAgfQ0KPj4NCj4+IFdlIGRvbid0IG5lZWQgdG8gd2FsayB0
aGUgUENJIGhpZXJhY2h5IHR3aWNlLiBNYXliZSB3ZSBjYW4gYWRkIHRoZQ0KPj4gb2Zfbm9kZSBj
aGVjayBkaXJlY3RseSB0byB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZT8NCj4+DQo+DQo+IEkg
dGhpbmsgaW4gZ2VuZXJhbCB3ZSBjb3VsZCBwYXNzIGRpcmVjdGx5IHRoZSBob3N0IGJyaWRnZSBk
ZXZpY2UgaWYgDQo+IGRldl9pc19wY2koZGV2KSAod2hpY2ggY2FuIGJlIHJldHJpZXZlZCB3aXRo
IA0KPiBwY2lfZ2V0X2hvc3RfYnJpZGdlX2RldmljZSh0b19wY2lfZGV2KGRldiksIGFuZCBhZnRl
ciBkb25lIHdpdGggaXQgDQo+IHBjaV9wdXRfaG9zdF9icmlkZ2VfZGV2aWNlKHBoYikpLg0KPiBT
byB0aGF0LCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZSgpIGFuZCANCj4geGVuX2R0X2dyYW50
X2luaXRfYmFja2VuZF9kb21pZCgpIHdvbid0IG5lZWQgdG8gZGlzY292ZXIgaXQgdGhlbXNlbHZl
cy4NCj4gVGhpcyB3aWxsIHNpbXBsaWZ5IHRoZSBjb2RlLg0KDQoNCkdvb2QgcG9pbnQuIEkgaGF2
ZSBzb21lIHJlbWFyay4gQ2FuIHdlIHVzZSBwY2lfZmluZF9ob3N0X2JyaWRnZSgpIA0KaW5zdGVh
ZD8gVGhpcyB3YXkgd2UgZG9uJ3QgaGF2ZSB0byBhZGQgI2luY2x1ZGUgIi4uL3BjaS9wY2kuaCIs
IGFuZCBoYXZlIA0KdG8gZHJvcCByZWZlcmVuY2UgYWZ0ZXJ3YXJkcy4NCg0KV2l0aCB0aGF0IHhl
bl9kdF9nZXRfcGNpX2hvc3Rfbm9kZSgpIHdpbGwgYmVjYW1lIHRoZSBmb2xsb3dpbmc6DQoNCg0K
c3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9wY2lfaG9zdF9ub2RlKHN0cnVj
dCBkZXZpY2UgKmRldikNCnsNCiDCoMKgIMKgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdl
ID0gDQpwY2lfZmluZF9ob3N0X2JyaWRnZSh0b19wY2lfZGV2KGRldiktPmJ1cyk7DQoNCiDCoMKg
IMKgcmV0dXJuIG9mX25vZGVfZ2V0KGJyaWRnZS0+ZGV2LnBhcmVudC0+b2Zfbm9kZSk7DQp9DQoN
Cg0KV2l0aCBTdGVmYW5vJ3Mgc3VnZ2VzdGlvbiwgd2Ugd29uJ3Qgd2FsayB0aGUgUENJIGhpZXJh
cmNoeSB0d2ljZSB3aGVuIA0KZXhlY3V0aW5nIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKCkgZm9y
IFBDSSBkZXZpY2U6DQoNCnhlbl9pc19ncmFudF9kbWFfZGV2aWNlKCkgLT4geGVuX2lzX2R0X2dy
YW50X2RtYV9kZXZpY2UoKSAtPiANCnhlbl9kdF9tYXBfaWQoKSAtPiB4ZW5fZHRfZ2V0X3BjaV9o
b3N0X25vZGUoKQ0KDQoNCldoYXQgZG8geW91IHRoaW5rPw0KDQoNCj4NCj4+DQo+Pj4gwqDCoMKg
wqDCoCByZXR1cm4gZmFsc2U7DQo+Pj4gwqAgfQ0KPj4+IEBAIC0zMjUsMTIgKzM3NywxOSBAQCBi
b29sIHhlbl92aXJ0aW9fbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2RldmljZSANCj4+PiAqZGV2KQ0K
Pj4+IMKgIHN0YXRpYyBpbnQgeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1Y3Qg
ZGV2aWNlICpkZXYsDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGEpDQo+Pj4gwqAgew0KPj4+
IC3CoMKgwqAgc3RydWN0IG9mX3BoYW5kbGVfYXJncyBpb21tdV9zcGVjOw0KPj4+ICvCoMKgwqAg
c3RydWN0IG9mX3BoYW5kbGVfYXJncyBpb21tdV9zcGVjID0geyAuYXJnc19jb3VudCA9IDEgfTsN
Cj4+PiDCoCAtwqDCoMKgIGlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25v
ZGUsICJpb21tdXMiLCANCj4+PiAiI2lvbW11LWNlbGxzIiwNCj4+PiAtwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCAwLCAmaW9tbXVfc3BlYykpIHsNCj4+PiAtwqDCoMKgwqDCoMKgwqAgZGV2X2Vycihk
ZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+PiAtwqDCoMKgwqDCoMKg
wqAgcmV0dXJuIC1FU1JDSDsNCj4+PiArwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+
PiArwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9kdF9tYXBfaWQoZGV2LCAmaW9tbXVfc3BlYy5ucCwg
aW9tbXVfc3BlYy5hcmdzKSkgew0KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRldl9lcnIo
ZGV2LCAiQ2Fubm90IHRyYW5zbGF0ZSBJRFxuIik7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgcmV0dXJuIC1FU1JDSDsNCj4+PiArwqDCoMKgwqDCoMKgwqAgfQ0KPj4+ICvCoMKgwqAgfSBl
bHNlIHsNCj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdz
KGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIA0KPj4+ICIjaW9tbXUtY2VsbHMiLA0KPj4+ICvCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+Pj4gK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3Bl
cnR5XG4iKTsNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVTUkNIOw0KPj4+
ICvCoMKgwqDCoMKgwqDCoCB9DQo+Pj4gwqDCoMKgwqDCoCB9DQo+Pj4gwqAgwqDCoMKgwqDCoCBp
ZiAoIW9mX2RldmljZV9pc19jb21wYXRpYmxlKGlvbW11X3NwZWMubnAsICJ4ZW4sZ3JhbnQtZG1h
IikgfHwNCj4+PiBAQCAtMzU0LDYgKzQxMyw3IEBAIHN0YXRpYyBpbnQgDQo+Pj4geGVuX2R0X2dy
YW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+Pj4gwqAgdm9pZCB4
ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4gwqAgew0KPj4+
IMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YTsNCj4+PiArwqDCoMKg
IHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnA7DQo+Pj4gwqAgwqDCoMKgwqDCoCBkYXRhID0gZmluZF94
ZW5fZ3JhbnRfZG1hX2RhdGEoZGV2KTsNCj4+PiDCoMKgwqDCoMKgIGlmIChkYXRhKSB7DQo+Pj4g
QEAgLTM2NSw4ICs0MjUsMTMgQEAgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3Qg
ZGV2aWNlICpkZXYpDQo+Pj4gwqDCoMKgwqDCoCBpZiAoIWRhdGEpDQo+Pj4gwqDCoMKgwqDCoMKg
wqDCoMKgIGdvdG8gZXJyOw0KPj4+IMKgIC3CoMKgwqAgaWYgKGRldi0+b2Zfbm9kZSkgew0KPj4+
IC3CoMKgwqDCoMKgwqDCoCBpZiAoeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYs
IGRhdGEpKQ0KPj4+ICvCoMKgwqAgbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsNCj4+PiArwqDC
oMKgIGlmIChucCkgew0KPj4+ICvCoMKgwqDCoMKgwqDCoCBpbnQgcmV0Ow0KPj4+ICsNCj4+PiAr
wqDCoMKgwqDCoMKgwqAgcmV0ID0geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYs
IGRhdGEpOw0KPj4+ICvCoMKgwqDCoMKgwqDCoCBvZl9ub2RlX3B1dChucCk7DQo+Pj4gK8KgwqDC
oMKgwqDCoMKgIGlmIChyZXQpDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBl
cnI7DQo+Pj4gwqDCoMKgwqDCoCB9IGVsc2UgaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJU
SU9fRk9SQ0VfR1JBTlQpKSB7DQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGRldl9pbmZvKGRldiwg
IlVzaW5nIGRvbTAgYXMgYmFja2VuZFxuIik7DQo+Pj4gLS0gDQo+Pj4gMi4yNS4xDQo+Pj4NCj4+
DQo+DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 20:10:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 20:10:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426007.674174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFOE-0001xL-KY; Wed, 19 Oct 2022 20:10:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426007.674174; Wed, 19 Oct 2022 20:10:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFOE-0001xE-HD; Wed, 19 Oct 2022 20:10:10 +0000
Received: by outflank-mailman (input) for mailman id 426007;
 Wed, 19 Oct 2022 20:10:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Rl4W=2U=citrix.com=prvs=284ee54c8=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olFOD-0001x8-I4
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 20:10:09 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0523028a-4fea-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 22:10:07 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Oct 2022 16:09:46 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB5919.namprd03.prod.outlook.com (2603:10b6:a03:2d8::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct
 2022 20:09:43 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 20:09:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0523028a-4fea-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666210207;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=f/IRuNciZO2iCUAHCt/9LQ3hJ9mpBNMdmcJrw49+R8c=;
  b=XA5fK3gPVWh9yxL7Dn6loluMyLTusyCstwih5kZ9YM6lhX3hrhQJ2cOq
   J+qSaNUJ1W1ee87a3CZqp95irMu7Jnfej7o5+UHgu0LhL7UDOQ1UznM5t
   R+ijHNpntpzKWyLumH/U0eJR+gKZE1vwSlPNSvr5mwtGu1DX/k2Z2OelQ
   g=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 82733994
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:JYshzas6HDKeN2CgfdmC9oQ7mOfnVNlfMUV32f8akzHdYApBsoF/q
 tZmKT/QP66OZzDze9F1Ydvgp00DupOBxtA1SQA6qXhmRixD+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPaka5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklXz
 MYcLQ0GRyu8iv6J5+ydFNFdmsgaeZyD0IM34hmMzBn/JNN/GNXpZfWP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUvgNABM/KMEjCObexTklyVu
 STt+GPhDwtBHNee1SCE4jSngeqncSbTCNhNT+bpp6ICbFu7w0MrUzkOcV2C8aOGphWCW99yJ
 kU79X97xUQ13AnxJjXnZDW0vXiAtwYTc8dVEuY6rgyB18L8wwufHHlCcTdHZ/QvrspwTjsvv
 neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32
 T/ihCojg7Qei+Yb2qP9+krI6xqmq4LVVAcz6kPSV3i88wJiTIe/Ysqj7l2zxchHKIGVX1yQp
 k8uksKV7P0NJZyVnSnLS+IIdIxF/N6AOTzYxFRpT58o8m30/2b5JN4ApjZjOE1uL8AIPyfzZ
 1Pesh9Q45kVO2a2aahwYMS6DMFCIbXcKOkJn8v8NrJmCqWdvifep0mCuWb4M7jRrXUR
IronPort-HdrOrdr: A9a23:qUhKIq81r0V20V0Mck5uk+Fudb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8bpYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ
 uIEJIOReEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK
 DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561
 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu
 O85yvIcf4DrE85NVvF3CcFkzOQrArGrUWShWNwyEGT3/AQDlgBerV8rJMcfR3D50U6utZglK
 pNwmKCrpJSSQjNhSLn+rHzJlhXf2eP0A0feNQo/gpieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO
 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u
 yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou
 W1bLp1jx9AR6u1M7z+4HRiyGG8fEytGTLw18pZ+591/rXhWbuDC1zwdGwT
X-IronPort-AV: E=Sophos;i="5.95,196,1661832000"; 
   d="scan'208,217";a="82733994"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cvXuaKfPFqXGeY1fYYsIteseqMsiECZt609cc5BGLW19lxhBrpkGsCbqr0bagHgt3IERZSLt8SfCTyFD/tz8CaAt6ZT/+ch9Pv74YUI1VLG9IqBYlWrAS8eHM1PrFE833ImI2AXf/0/4vfqnRzWjp7OmV2eoNNd7w88gyTnfxi5k7u3Ykf/mXDffBcf4WicyBcSXQGm7JZrdyCZEyy6zOL8J7ivV4NtvGwMo1nFsswbgyk0JmkVm54Kobzzp7Xi8ZjMlsrk9DFzojFihFqZrbLI5HXF+/BO4zlOCTfRiHj3pVb8P2uLJI0YTusb3tktf01SNLTM026Oz0BOBb36gkQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f/IRuNciZO2iCUAHCt/9LQ3hJ9mpBNMdmcJrw49+R8c=;
 b=Mx3Tq8ZLv/eq2KZ8G6s9m2AKzYxhWLzkvWhQFidQ0vngeuE+FE2cGCPkzSskoWYgoDpWgSBmPnI6r+AVjAKslQc78MR60auS6CTGESSHxven3R+eVB+zWXZ1ZKMJa7UFs3zQEPYVIEtiRkRz0GeVBrSoZ+oSPXloKEC+hVege3ddM9GfWRZDwsPOyT6ls4/VDtgqt2Kielb9ZtZQ+HqfNoz39Fp85nTOcs9l9+9imAdnOzf2ZUOU1FmHlEyOOZIgS+VpZ467YnUJK4oK84MqGx3YOglEh8ac2xxi7sDpxtyg0fyAtqc7Wa4VByHcnhS7003gAtkkuIfVYJCVfXdlpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=f/IRuNciZO2iCUAHCt/9LQ3hJ9mpBNMdmcJrw49+R8c=;
 b=IMNMUt1Ld9alR6PuuM296/0grAsVUMgzRasOXEw/j1HNwlQFa41h+YlfyJSuFSu4lj81tPQsEiFOwFNRsZUvKusVEWqpbtDJwwH1xYzqidydaFROmNdhHt/N5CABMEOgq9dNPmcSePSJbcHEY3c1bEZRsnaL3WlRT2/7r9VjreQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: George Dunlap <dunlapg@umich.edu>, Henry Wang <Henry.Wang@arm.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	George Dunlap <George.Dunlap@citrix.com>
Subject: Re: Policy: A release acks for the release manager's patches (was Re:
 [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init())
Thread-Topic: Policy: A release acks for the release manager's patches (was
 Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 p2m_init())
Thread-Index: AQHY4893wY6db56RwEawpyEuXhxcpq4WJdMA
Date: Wed, 19 Oct 2022 20:09:43 +0000
Message-ID: <7c6b1894-4dbe-8d8b-9f08-c07214b65844@citrix.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>
 <20221018142346.52272-3-Henry.Wang@arm.com>
 <CAFLBxZZ59zkuNJM1vQSv_Syv8i0Q_dAFk0p-JXY4oFs0cCUSnQ@mail.gmail.com>
In-Reply-To:
 <CAFLBxZZ59zkuNJM1vQSv_Syv8i0Q_dAFk0p-JXY4oFs0cCUSnQ@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5919:EE_
x-ms-office365-filtering-correlation-id: 28bd6bd7-f982-4a87-c1af-08dab20ddcad
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 vF3iVgP6r/nGzYoUwitGxJtcZQt5O4fe4qnA6FeprfN69uB4FSXUf5o5n1xYjJH4jsRl++wh6oytOpk/k++et1RJ5G86CP95uZgcu67y5x9ymlIVrKxadWVze8/b5B214OxfeRScl88OlS/xAb07LzeaXZJY1byd93e7l8FAe1EZUugjeHfgPF0q6sfMp0YxMj7eoQ9yfgzTTXW/gt23EH1+Hg4fGFdlogx1B8tBuDRwWHJKCWz9dkneoxzGm3FoJdZowRQcsHRaNqYxn0X088M6P/meyKSUCWwfKHfyrcE9OY8RTg/9CU033CBQJ3kY3k6oH6W2XvdzYvKEZPLDdMRlL/8YS3Wozo04bzH1biq+sDwkwu6qrVcbgErcxSuS3/YiPSLgxWsniAxLZGpNwzfXt8NZTRBl+i036K/Hbga0FVTMgfna2t63lIVB5kGHcyBQ2djYpQ24bhCLKNAoggGofubgj2A0FseOeUcXhmwpoJVI5l+IWqL1quwqtK7W7eHqSMPVl4qUoECEnydbupo9aqw9u+I1EnCYyyQV3Kij0LzEYoIluFo00FMIAELD1Lb5PnZoxY2crjGMX+dgjxmOgN0Rftn8UoIq6OoxdYFo9ujkd61auLMl6pR22Q8r9bHSqER4Dqn2JQYBxoDc+AFQxqbRRbL9zzw1eZUY4gIOT7NsR5oBN36hL+V+yDo7Fiy/hzkXLptFmxa6TfN5aN/T3M2TJLZ5/fFD9AFQ7ixXgIIlKgrkvtvCkv5OpVcxJq6If1Pb50qo49cHjfcNKOTJBE9K1vYEHqEkbYHbXAhBWt3LGNrhV6DNvpjH/H0WZ47XndStRzFgr1xB0shaZA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(31686004)(36756003)(8676002)(66556008)(86362001)(6512007)(122000001)(6506007)(26005)(38070700005)(82960400001)(66476007)(66446008)(64756008)(2906002)(31696002)(8936002)(4326008)(38100700002)(41300700001)(5660300002)(91956017)(76116006)(66946007)(83380400001)(316002)(54906003)(6486002)(186003)(110136005)(53546011)(2616005)(478600001)(71200400001)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?L1lLRXMwQVdvTWdkVjJDMzdkaitsTkRub2dPSVdsQ1BnLzdWaS9XWHdScUNq?=
 =?utf-8?B?MTdSZWFLMUZRV2h0YWNWSlV1ejhYY1MzcVpSOStRN0VQL1B1SG1DVFRGSWZL?=
 =?utf-8?B?OXBSNjhtYjBDcXZWaVVuTm5INFpqUDZVdlEwZVFlVFlKdERleVF2VzNWL2VU?=
 =?utf-8?B?SHZ0eURsTitieFVBQjdhamU1NUxIQm1HM2NnbkwyWUJZSlFjSUcyYm02NDVY?=
 =?utf-8?B?MVM4Q2JVRnplOTUzdVFOZnZUTFNXL3BUOWdhMGl0b09JSjdDSkY0c1ZKL2xj?=
 =?utf-8?B?T2I4cTJmb2RmU0h5V0lDcTQ3a21yWE82ZzFjU3JQelNJeUYxYzBpZ2twQXRN?=
 =?utf-8?B?eVc2NUh4elM4VlNvVlJkbXZmZVJFdThLSEJ4bWZwdVk5Q1RMQzd2UUZBTUdE?=
 =?utf-8?B?a01keGFicHRKWUVRM0hKTVhocGluUDFUamJlWU8vK08wOW1GUDhzbXdjRWYx?=
 =?utf-8?B?OStRaGNLR0ZuSHJ1MjRPTUlaNXcrclUra2ZVWVNKak40RzdCaDJHUnNFSzZs?=
 =?utf-8?B?MGlsbVlQYk1RVllMSDRlZTVENXFWVUdQTktMMmcyNHhkSnNjaW16YXlOdDJS?=
 =?utf-8?B?Y09SdkVQZGdIYXhGZVRMSDZ5cWd1NlAxZ0Z6THF1V0lkUlJiN0twZ1VzbWlk?=
 =?utf-8?B?Zks0KytuNkpEYTQ3YTBGckg2WG53RmZrSExkMEYra1U3SXdseEFtUm9wZTcx?=
 =?utf-8?B?RUxTMlRjemlvKzRQKzNUWnhOeHY4OEZQRGdyMk9rejkveWdFcm51K2NrbThx?=
 =?utf-8?B?SUdBSEpPMzMvMmhlOWl5OEtQNW5lVTVpVUFLRzlVbmhVVU5uNXExcWpzbmky?=
 =?utf-8?B?MGYrVm1KREZSSlhZMzBERGduWC9TZnZ0SHpyQUJnU3hSTVMzYk1zUlVuWWZW?=
 =?utf-8?B?YlNGeUVMaVhnemwrSzBrK2dsa2ZGMEk4L0FjSHdiODlldmpSblp1V1paTGFO?=
 =?utf-8?B?WlFnRy9pYmNmYjBLSEtvbGdGSzZkTHZWcVgzbVNDQkttNjdjRFh5eDBYbUZ6?=
 =?utf-8?B?WEFienVJRlRWY3laNzVsQjRVSk1yeEM1MEZUcEt6VXViL0poYkx5b0lTT2dk?=
 =?utf-8?B?OXAxMWM0V3c4M0tqc1IwREh0cVhYN3BIQ2FPMStBOWZrREZ3Y2ZLY0xiN2RX?=
 =?utf-8?B?dnJZRlhVUGpEWExtMkt2eE9zTGNISnowalAyakNhMkx5NDVPZ3ZVaW5NTjVl?=
 =?utf-8?B?bjk4WitTTzhwY1U3c0I2UC9LZXNzNjlROWlGRlZ5UlhhLzYyK3VEQ2dnSyts?=
 =?utf-8?B?ejR0dXJ4bWZQOUJvekdWT2g0TEZCN2pxaWxuRTVGOFFFK0hWWU54ZHhkanlo?=
 =?utf-8?B?UDJCeVNMWFR3b0V3TFBNWVZWWHczVk1PbUZBSWhncldiYXJQZHd5QUtJWTNN?=
 =?utf-8?B?MWJNSE5WV2RydkptcFdFMlMrcEZyS2dZQVByL2w0Ty9rc2htS25YTWEydGxJ?=
 =?utf-8?B?SnRZQi94MUVWcTduSW5tK25SbFo4TEo4MnBvdGV2c1RJTEd0QzF6ajg4cGhv?=
 =?utf-8?B?UjU1WWx1U09qZy9uWmRFUkFxTThkQVNpdktpOHpEU0k5aXJjT1pLRzhQN3c2?=
 =?utf-8?B?cWlyNzlZcUlKcHVtWTAyaDI5MUxoVEtlb1NRd1dxRExUbzlNZWlwUEJhSzJx?=
 =?utf-8?B?YWpNamtpNXRta0x3RWR5RFZjOUNENDVHblFtMXh2ZGtvUTdRM2s4RDU5czFF?=
 =?utf-8?B?bVhralVMODcxUzNBa2pmdVAxWjBrNWNQcGZzTXV2U3NLWXkrazl4bVZ6b3V6?=
 =?utf-8?B?VGhCVDdTQStxUEpRMVl5bnFHZDFsd0ZjaUQreCtENWRhWDlkQVQydDRsV2hw?=
 =?utf-8?B?RThtb1pmemd1UjdHSWFqRm5iQ2RLdjI3ZFVRZm1nNGhSMEhmUHVJTUJBNzdI?=
 =?utf-8?B?NWptSS84NkFlUzRVbm53aTlzQ3ZJVitnTUN6eThUNW8rR2hFYngwSDlvMVBm?=
 =?utf-8?B?N01KbGZKbHpGbEhLMk55Sjk1dTNReHJQOHZsa0hjZFVpczZjSFdFNU5qN1ZI?=
 =?utf-8?B?N1JuN3pNemU2Y1NuMnNSUnd5VStsSVllM3BqUmNjSU5KL05TRnJLckwxL2lS?=
 =?utf-8?B?NW9SRTZpVjNqUWdHODdFb0g5K2tFZzdyaGYvZ1dBdlB0T0tYTXVqdEs2YTMw?=
 =?utf-8?Q?PCpAj1L4Dvm91RwRn+4536NTs?=
Content-Type: multipart/alternative;
	boundary="_000_7c6b18944dbe8d8b9f08c07214b65844citrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28bd6bd7-f982-4a87-c1af-08dab20ddcad
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 20:09:43.2727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rpxS5r7HAIdwWrE4mEFuN5WykQG3neMETnHTODiWX4KbslJ0bGhzFU9t8vWEfICQ3KtfCPlW3Qpt6aq+HW4f3NPV9yMwmRxtPLhSX2zrA58=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5919

--_000_7c6b18944dbe8d8b9f08c07214b65844citrixcom_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

T24gMTkvMTAvMjAyMiAxNjoyOCwgR2VvcmdlIER1bmxhcCB3cm90ZToNCg0KDQpPbiBUdWUsIE9j
dCAxOCwgMjAyMiBhdCAzOjI0IFBNIEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbTxtYWls
dG86SGVucnkuV2FuZ0Bhcm0uY29tPj4gd3JvdGU6DQpIYXJkd2FyZSB1c2luZyBHSUN2MiBuZWVk
cyB0byBjcmVhdGUgYSBQMk0gbWFwcGluZyBvZiA4S0IgR0lDdjIgYXJlYQ0Kd2hlbiB0aGUgZG9t
YWluIGlzIGNyZWF0ZWQuIENvbnNpZGVyaW5nIHRoZSB3b3JzdCBjYXNlIG9mIHBhZ2UgdGFibGVz
DQp3aGljaCByZXF1aXJlcyA2IFAyTSBwYWdlcyBhcyB0aGUgdHdvIHBhZ2VzIHdpbGwgYmUgY29u
c2VjdXRpdmUgYnV0IG5vdA0KbmVjZXNzYXJpbHkgaW4gdGhlIHNhbWUgTDMgcGFnZSB0YWJsZSBh
bmQga2VlcCBhIGJ1ZmZlciwgcG9wdWxhdGUgMTYNCnBhZ2VzIGFzIHRoZSBkZWZhdWx0IHZhbHVl
IHRvIHRoZSBQMk0gcGFnZXMgcG9vbCBpbiBwMm1faW5pdCgpIGF0IHRoZQ0KZG9tYWluIGNyZWF0
aW9uIHN0YWdlIHRvIHNhdGlzZnkgdGhlIEdJQ3YyIHJlcXVpcmVtZW50LiBGb3IgR0lDdjMsIHRo
ZQ0KYWJvdmUtbWVudGlvbmVkIFAyTSBtYXBwaW5nIGlzIG5vdCBuZWNlc3NhcnksIGJ1dCBzaW5j
ZSB0aGUgYWxsb2NhdGVkDQoxNiBwYWdlcyBoZXJlIHdvdWxkIG5vdCBiZSBsb3N0LCBoZW5jZSBw
b3B1bGF0ZSB0aGVzZSBwYWdlcw0KdW5jb25kaXRpb25hbGx5Lg0KDQpXaXRoIHRoZSBkZWZhdWx0
IDE2IFAyTSBwYWdlcyBwb3B1bGF0ZWQsIHRoZXJlIHdvdWxkIGJlIGEgY2FzZSB0aGF0DQpmYWls
dXJlcyB3b3VsZCBoYXBwZW4gaW4gdGhlIGRvbWFpbiBjcmVhdGlvbiB3aXRoIFAyTSBwYWdlcyBh
bHJlYWR5IGluDQp1c2UuIFRvIHByb3Blcmx5IGZyZWUgdGhlIFAyTSBmb3IgdGhpcyBjYXNlLCBm
aXJzdGx5IHN1cHBvcnQgdGhlDQpvcHRpb25hbGx5IHByZWVtcHRpb24gb2YgcDJtX3RlYXJkb3du
KCksIHRoZW4gY2FsbCBwMm1fdGVhcmRvd24oKSBhbmQNCnAybV9zZXRfYWxsb2NhdGlvbihkLCAw
LCBOVUxMKSBub24tcHJlZW1wdGl2ZWx5IGluIHAybV9maW5hbF90ZWFyZG93bigpLg0KQXMgbm9u
LXByZWVtcHRpdmUgcDJtX3RlYXJkb3duKCkgc2hvdWxkIG9ubHkgcmV0dXJuIDAsIHVzZSBhDQpC
VUdfT04gdG8gY29uZmlybSB0aGF0Lg0KDQpTaW5jZSBwMm1fZmluYWxfdGVhcmRvd24oKSBpcyBj
YWxsZWQgZWl0aGVyIGFmdGVyDQpkb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoKSB3aGVyZSBy
ZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgaGFzIGJlZW4NCmNhbGxlZCwgb3IgZnJvbSBmYWlsdXJl
IHBhdGggb2YgZG9tYWluX2NyZWF0ZSgpL2FyY2hfZG9tYWluX2NyZWF0ZSgpDQp3aGVyZSBtYXBw
aW5ncyB0aGF0IHJlcXVpcmUgcDJtX3B1dF9sM19wYWdlKCkgc2hvdWxkIG5ldmVyIGJlIGNyZWF0
ZWQsDQpyZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgaXMgbm90IGFkZGVkIGluIHAybV9maW5hbF90
ZWFyZG93bigpLCBhZGQNCmluLWNvZGUgY29tbWVudHMgdG8gcmVmZXIgdGhpcy4NCg0KRml4ZXM6
IGNiZWE1YTExNDljYSAoInhlbi9hcm06IEFsbG9jYXRlIGFuZCBmcmVlIFAyTSBwYWdlcyBmcm9t
IHRoZSBQMk0gcG9vbCIpDQpTdWdnZXN0ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpv
bi5jb208bWFpbHRvOmpncmFsbEBhbWF6b24uY29tPj4NClNpZ25lZC1vZmYtYnk6IEhlbnJ5IFdh
bmcgPEhlbnJ5LldhbmdAYXJtLmNvbTxtYWlsdG86SGVucnkuV2FuZ0Bhcm0uY29tPj4NCg0KDQpI
ZW5yeSBicm91Z2h0IHRoaXMgcGF0Y2ggdG8gbXkgYXR0ZW50aW9uIGJlY2F1c2UgaXQgbmVlZHMg
YSByZWxlYXNlIGFjaw0KDQpBY3R1YWxseSB0aGlzIG9uZSBkb2Vzbid0LiAgSXQncyBhIHNlY3Vy
aXR5IHBhdGNoLCBhbmQgdGhlIG9ubHkgcmVhc29uIGl0cyBvbiB4ZW4tZGV2ZWwgaXMgYmVjYXVz
ZSBPU1NUZXN0IGRpc2NvdmVyZWQgdGhhdCBYU0EtNDA5IGlzIERvQSBhZnRlciB0aGUgZmFjdC4g
IEFuZCBvbiBhbGwgc2VjdXJpdHkgc3VwcG9ydGVkIGJyYW5jaGVzIHRvby4NCg0KV2hlbiB0aGUg
YnVncyBoYXZlIGJlZW4gZml4ZWQsIGl0IHdpbGwgY2F1c2UgZm9yY2UgYSByZS1pc3N1ZSBvZiBY
U0EtNDA5Lg0KDQosIGJ1dCBpdCBkb2Vzbid0IHNlZW0gcHJvcGVyIGZvciBIZW5yeSB0byBiZSB0
aGUgb25lIHRvIHJlbGVhc2UtYWNrIGhpcyBvd24gcGF0Y2hlcy4gOi0pDQoNCkkgZG9uJ3Qgc2Vl
IGFuIGlzc3VlIHdpdGggYW4gUk0gUi1hY2staW5nIHRoZWlyIG93biBwYXRjaC4gIFRoZXJlJ3Mg
cGFzdCBmb3JtIGZvciBzZWxmLVItYWNrLCBhbmQgdGhlIHBhdGNoIHN0aWxsIG5lZWRzIG9uZSBv
dGhlciBwZXJzb24gYW5kL29yIGEgbWFpbnRhaW5lci9jb21taXR0ZXIgYW5kIHRoZSB1c3VhbCBy
ZXNvbHV0aW9uIG9mIG91dHN0YW5kaW5nIGNvbmNlcm5zLg0KDQpUaGVyZSdzIGFkbWluaXN0cml2
aWEgd2hpY2ggdGhlIFJNIHR5cGljYWxseSBkb2VzIGNsb3NlciB0byB0aGUgcmVsZWFzZSwgYW5k
IHdlJ3ZlIG5ldmVyIGhhZCBjcm9zcy1SLWFjayBmb3IgdGhlIGRvY3MvcHJvY2VzcyBzaWRlIG9m
IHRoaW5ncy4NCg0KDQpJIHByb3Bvc2UgdGhhdCBhIHN1aXRhYmxlIHJ1bGUgd291bGQgYmU6DQoN
CiJJZiB0aGUgcmVsZWFzZSBtYW5hZ2VyIHRoZW1zZWx2ZXMgaGF2ZSBzdWJtaXR0ZWQgYSBwYXRj
aCB3aGljaCBuZWVkcyBhIHJlbGVhc2UgYWNrLCB0aGVuIHRoZSBwYXRjaCBuZWVkcyBhIHJlbGVh
c2UgYWNrIGZyb20gb25lIG9mIHRoZSBDb21taXR0ZXJzIHdobyBpcyBub3QgaW52b2x2ZWQgaW4g
dGhlIHBhdGNoLiINCg0KR2l2ZW4gdGhlIHRpbWUtY3JpdGljYWwgbmF0dXJlIG9mIHRoaXMgcGF0
Y2gsIEkgcHJvcG9zZSB0aGF0IHdlIGFkb3B0IHRoZSBydWxlIGFzIGFuIGV4cGVkaWVuY3kgbm93
LCBhbmQgd2UgY2FuIGRpc2N1c3MgYWZ0ZXJ3YXJkcyB3aGV0aGVyIHRvIG1ha2UgaXQgcGVybWFu
ZW50Lg0KDQpXaXRoIHRoYXQgaW4gbWluZCwgaXQgbG9va3MgbGlrZSB0aGlzIHBhdGNoIGlzIGNy
aXRpY2FsIGZvciBmaXhpbmcgYSByZWxlYXNlIGlzc3VlOyBpdCdzIGluIGNvcmUgY29kZSwgYnV0
IGhhcyBhbHNvIGhhcyBhIGxvdCBvZiBzY3J1dGlueS4gIFNvIHdpdGggdGhhdCBpbiBtaW5kOg0K
DQpSZWxlYXNlLWFja2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5j
b208bWFpbHRvOmdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4+DQoNCkF0IHRoZSBlbmQgb2YgdGhl
IGRheSwgUi1hY2sgbWVhbnMgIkkgaGF2ZSBkZWVtZWQgdGhpcyBpbXBvcnRhbnQgZm9yIHRoZSBy
ZWxlYXNlIiwgYW5kIHRoZSBjb21taXR0ZXJzIGFyZSB0aGUgZmFsbGJhY2sgZm9yIGFsbCBjb3Ju
ZXIgY2FzZXMuICBJJ2Qgc2F5IHRoYXQncyBhbHJlYWR5IGNvdmVyZWQgaW4gdGhlIGV4aXN0aW5n
IHJ1bGVzIGFuZCBjb252ZW50aW9ucywgZ2l2ZW4gdGhlIGV4cGVjdGF0aW9uIHRoYXQgY29tbWl0
dGVycyB3b3VsZG4ndCB0cmVhZCBvbiB0aGUgdG9lcyBvZiB0aGUgUk0gaW4gdGhlIGZpcnN0IHBs
YWNlLg0KDQp+QW5kcmV3DQo=

--_000_7c6b18944dbe8d8b9f08c07214b65844citrixcom_
Content-Type: text/html; charset="utf-8"
Content-ID: <C7E45BFAD12E324DB24EA296BF572877@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64

PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i
dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i
bW96LWNpdGUtcHJlZml4Ij5PbiAxOS8xMC8yMDIyIDE2OjI4LCBHZW9yZ2UgRHVubGFwIHdyb3Rl
Ojxicj4NCjwvZGl2Pg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0ZT0ibWlkOkNBRkxCeFpa
NTl6a3VOSk0xdlFTdl9TeXY4aTBRX2RBRmswcC1KWFk0b0ZzMGNDVVNuUUBtYWlsLmdtYWlsLmNv
bSI+DQo8ZGl2IGRpcj0ibHRyIj4NCjxkaXYgZGlyPSJsdHIiPjxicj4NCjwvZGl2Pg0KPGJyPg0K
PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPg0KPGRpdiBkaXI9Imx0ciIgY2xhc3M9ImdtYWlsX2F0
dHIiPk9uIFR1ZSwgT2N0IDE4LCAyMDIyIGF0IDM6MjQgUE0gSGVucnkgV2FuZyAmbHQ7PGEgaHJl
Zj0ibWFpbHRvOkhlbnJ5LldhbmdAYXJtLmNvbSIgdGFyZ2V0PSJfYmxhbmsiIG1vei1kby1ub3Qt
c2VuZD0idHJ1ZSIgY2xhc3M9Im1vei10eHQtbGluay1mcmVldGV4dCI+SGVucnkuV2FuZ0Bhcm0u
Y29tPC9hPiZndDsgd3JvdGU6PGJyPg0KPC9kaXY+DQo8YmxvY2txdW90ZSBjbGFzcz0iZ21haWxf
cXVvdGUiIHN0eWxlPSJtYXJnaW46MHB4IDBweCAwcHgNCiAgICAgICAgICAgIDAuOGV4O2JvcmRl
ci1sZWZ0OjFweCBzb2xpZA0KICAgICAgICAgICAgcmdiKDIwNCwyMDQsMjA0KTtwYWRkaW5nLWxl
ZnQ6MWV4Ij4NCkhhcmR3YXJlIHVzaW5nIEdJQ3YyIG5lZWRzIHRvIGNyZWF0ZSBhIFAyTSBtYXBw
aW5nIG9mIDhLQiBHSUN2MiBhcmVhPGJyPg0Kd2hlbiB0aGUgZG9tYWluIGlzIGNyZWF0ZWQuIENv
bnNpZGVyaW5nIHRoZSB3b3JzdCBjYXNlIG9mIHBhZ2UgdGFibGVzPGJyPg0Kd2hpY2ggcmVxdWly
ZXMgNiBQMk0gcGFnZXMgYXMgdGhlIHR3byBwYWdlcyB3aWxsIGJlIGNvbnNlY3V0aXZlIGJ1dCBu
b3Q8YnI+DQpuZWNlc3NhcmlseSBpbiB0aGUgc2FtZSBMMyBwYWdlIHRhYmxlIGFuZCBrZWVwIGEg
YnVmZmVyLCBwb3B1bGF0ZSAxNjxicj4NCnBhZ2VzIGFzIHRoZSBkZWZhdWx0IHZhbHVlIHRvIHRo
ZSBQMk0gcGFnZXMgcG9vbCBpbiBwMm1faW5pdCgpIGF0IHRoZTxicj4NCmRvbWFpbiBjcmVhdGlv
biBzdGFnZSB0byBzYXRpc2Z5IHRoZSBHSUN2MiByZXF1aXJlbWVudC4gRm9yIEdJQ3YzLCB0aGU8
YnI+DQphYm92ZS1tZW50aW9uZWQgUDJNIG1hcHBpbmcgaXMgbm90IG5lY2Vzc2FyeSwgYnV0IHNp
bmNlIHRoZSBhbGxvY2F0ZWQ8YnI+DQoxNiBwYWdlcyBoZXJlIHdvdWxkIG5vdCBiZSBsb3N0LCBo
ZW5jZSBwb3B1bGF0ZSB0aGVzZSBwYWdlczxicj4NCnVuY29uZGl0aW9uYWxseS48YnI+DQo8YnI+
DQpXaXRoIHRoZSBkZWZhdWx0IDE2IFAyTSBwYWdlcyBwb3B1bGF0ZWQsIHRoZXJlIHdvdWxkIGJl
IGEgY2FzZSB0aGF0PGJyPg0KZmFpbHVyZXMgd291bGQgaGFwcGVuIGluIHRoZSBkb21haW4gY3Jl
YXRpb24gd2l0aCBQMk0gcGFnZXMgYWxyZWFkeSBpbjxicj4NCnVzZS4gVG8gcHJvcGVybHkgZnJl
ZSB0aGUgUDJNIGZvciB0aGlzIGNhc2UsIGZpcnN0bHkgc3VwcG9ydCB0aGU8YnI+DQpvcHRpb25h
bGx5IHByZWVtcHRpb24gb2YgcDJtX3RlYXJkb3duKCksIHRoZW4gY2FsbCBwMm1fdGVhcmRvd24o
KSBhbmQ8YnI+DQpwMm1fc2V0X2FsbG9jYXRpb24oZCwgMCwgTlVMTCkgbm9uLXByZWVtcHRpdmVs
eSBpbiBwMm1fZmluYWxfdGVhcmRvd24oKS48YnI+DQpBcyBub24tcHJlZW1wdGl2ZSBwMm1fdGVh
cmRvd24oKSBzaG91bGQgb25seSByZXR1cm4gMCwgdXNlIGE8YnI+DQpCVUdfT04gdG8gY29uZmly
bSB0aGF0Ljxicj4NCjxicj4NClNpbmNlIHAybV9maW5hbF90ZWFyZG93bigpIGlzIGNhbGxlZCBl
aXRoZXIgYWZ0ZXI8YnI+DQpkb21haW5fcmVsaW5xdWlzaF9yZXNvdXJjZXMoKSB3aGVyZSByZWxp
bnF1aXNoX3AybV9tYXBwaW5nKCkgaGFzIGJlZW48YnI+DQpjYWxsZWQsIG9yIGZyb20gZmFpbHVy
ZSBwYXRoIG9mIGRvbWFpbl9jcmVhdGUoKS9hcmNoX2RvbWFpbl9jcmVhdGUoKTxicj4NCndoZXJl
IG1hcHBpbmdzIHRoYXQgcmVxdWlyZSBwMm1fcHV0X2wzX3BhZ2UoKSBzaG91bGQgbmV2ZXIgYmUg
Y3JlYXRlZCw8YnI+DQpyZWxpbnF1aXNoX3AybV9tYXBwaW5nKCkgaXMgbm90IGFkZGVkIGluIHAy
bV9maW5hbF90ZWFyZG93bigpLCBhZGQ8YnI+DQppbi1jb2RlIGNvbW1lbnRzIHRvIHJlZmVyIHRo
aXMuPGJyPg0KPGJyPg0KRml4ZXM6IGNiZWE1YTExNDljYSAoJnF1b3Q7eGVuL2FybTogQWxsb2Nh
dGUgYW5kIGZyZWUgUDJNIHBhZ2VzIGZyb20gdGhlIFAyTSBwb29sJnF1b3Q7KTxicj4NClN1Z2dl
c3RlZC1ieTogSnVsaWVuIEdyYWxsICZsdDs8YSBocmVmPSJtYWlsdG86amdyYWxsQGFtYXpvbi5j
b20iIHRhcmdldD0iX2JsYW5rIiBtb3otZG8tbm90LXNlbmQ9InRydWUiIGNsYXNzPSJtb3otdHh0
LWxpbmstZnJlZXRleHQiPmpncmFsbEBhbWF6b24uY29tPC9hPiZndDs8YnI+DQpTaWduZWQtb2Zm
LWJ5OiBIZW5yeSBXYW5nICZsdDs8YSBocmVmPSJtYWlsdG86SGVucnkuV2FuZ0Bhcm0uY29tIiB0
YXJnZXQ9Il9ibGFuayIgbW96LWRvLW5vdC1zZW5kPSJ0cnVlIiBjbGFzcz0ibW96LXR4dC1saW5r
LWZyZWV0ZXh0Ij5IZW5yeS5XYW5nQGFybS5jb208L2E+Jmd0Ozxicj4NCjwvYmxvY2txdW90ZT4N
CjxkaXY+PGJyPg0KPC9kaXY+DQo8ZGl2Pjxicj4NCjwvZGl2Pg0KPGRpdj5IZW5yeSBicm91Z2h0
IHRoaXMgcGF0Y2ggdG8gbXkgYXR0ZW50aW9uIGJlY2F1c2UgaXQgbmVlZHMgYSByZWxlYXNlIGFj
azwvZGl2Pg0KPC9kaXY+DQo8L2Rpdj4NCjwvYmxvY2txdW90ZT4NCjxicj4NCkFjdHVhbGx5IHRo
aXMgb25lIGRvZXNuJ3QuJm5ic3A7IEl0J3MgYSBzZWN1cml0eSBwYXRjaCwgYW5kIHRoZSBvbmx5
IHJlYXNvbiBpdHMgb24geGVuLWRldmVsIGlzIGJlY2F1c2UgT1NTVGVzdCBkaXNjb3ZlcmVkIHRo
YXQgWFNBLTQwOSBpcyBEb0EgYWZ0ZXIgdGhlIGZhY3QuJm5ic3A7IEFuZCBvbiBhbGwgc2VjdXJp
dHkgc3VwcG9ydGVkIGJyYW5jaGVzIHRvby48YnI+DQo8YnI+DQpXaGVuIHRoZSBidWdzIGhhdmUg
YmVlbiBmaXhlZCwgaXQgd2lsbCBjYXVzZSBmb3JjZSBhIHJlLWlzc3VlIG9mIFhTQS00MDkuPGJy
Pg0KPGJyPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0ZT0ibWlkOkNBRkxCeFpaNTl6a3VO
Sk0xdlFTdl9TeXY4aTBRX2RBRmswcC1KWFk0b0ZzMGNDVVNuUUBtYWlsLmdtYWlsLmNvbSI+DQo8
ZGl2IGRpcj0ibHRyIj4NCjxkaXYgY2xhc3M9ImdtYWlsX3F1b3RlIj4NCjxkaXY+LCBidXQgaXQg
ZG9lc24ndCBzZWVtIHByb3BlciBmb3IgSGVucnkgdG8gYmUgdGhlIG9uZSB0byByZWxlYXNlLWFj
ayBoaXMgb3duIHBhdGNoZXMuIDotKTwvZGl2Pg0KPC9kaXY+DQo8L2Rpdj4NCjwvYmxvY2txdW90
ZT4NCjxicj4NCkkgZG9uJ3Qgc2VlIGFuIGlzc3VlIHdpdGggYW4gUk0gUi1hY2staW5nIHRoZWly
IG93biBwYXRjaC4mbmJzcDsgVGhlcmUncyBwYXN0IGZvcm0gZm9yIHNlbGYtUi1hY2ssIGFuZCB0
aGUgcGF0Y2ggc3RpbGwgbmVlZHMgb25lIG90aGVyIHBlcnNvbiBhbmQvb3IgYSBtYWludGFpbmVy
L2NvbW1pdHRlciBhbmQgdGhlIHVzdWFsIHJlc29sdXRpb24gb2Ygb3V0c3RhbmRpbmcgY29uY2Vy
bnMuPGJyPg0KPGJyPg0KVGhlcmUncyBhZG1pbmlzdHJpdmlhIHdoaWNoIHRoZSBSTSB0eXBpY2Fs
bHkgZG9lcyBjbG9zZXIgdG8gdGhlIHJlbGVhc2UsIGFuZCB3ZSd2ZSBuZXZlciBoYWQgY3Jvc3Mt
Ui1hY2sgZm9yIHRoZSBkb2NzL3Byb2Nlc3Mgc2lkZSBvZiB0aGluZ3MuPGJyPg0KPGJyPg0KPGJs
b2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0ZT0ibWlkOkNBRkxCeFpaNTl6a3VOSk0xdlFTdl9TeXY4
aTBRX2RBRmswcC1KWFk0b0ZzMGNDVVNuUUBtYWlsLmdtYWlsLmNvbSI+DQo8ZGl2IGRpcj0ibHRy
Ij4NCjxkaXYgY2xhc3M9ImdtYWlsX3F1b3RlIj4NCjxkaXY+PGJyPg0KPC9kaXY+DQo8ZGl2Pkkg
cHJvcG9zZSB0aGF0IGEgc3VpdGFibGUgcnVsZSB3b3VsZCBiZTo8L2Rpdj4NCjxkaXY+PGJyPg0K
PC9kaXY+DQo8ZGl2PiZxdW90O0lmIHRoZSByZWxlYXNlIG1hbmFnZXIgdGhlbXNlbHZlcyBoYXZl
IHN1Ym1pdHRlZCBhIHBhdGNoIHdoaWNoIG5lZWRzIGEgcmVsZWFzZSBhY2ssIHRoZW4gdGhlIHBh
dGNoIG5lZWRzIGEgcmVsZWFzZSBhY2sgZnJvbSBvbmUgb2YgdGhlIENvbW1pdHRlcnMgd2hvIGlz
IG5vdCBpbnZvbHZlZCBpbiB0aGUgcGF0Y2guJnF1b3Q7PC9kaXY+DQo8ZGl2Pjxicj4NCjwvZGl2
Pg0KPGRpdj5HaXZlbiB0aGUgdGltZS1jcml0aWNhbCBuYXR1cmUgb2YgdGhpcyBwYXRjaCwgSSBw
cm9wb3NlIHRoYXQgd2UgYWRvcHQgdGhlIHJ1bGUgYXMgYW4gZXhwZWRpZW5jeSBub3csIGFuZCB3
ZSBjYW4gZGlzY3VzcyBhZnRlcndhcmRzIHdoZXRoZXIgdG8gbWFrZSBpdCBwZXJtYW5lbnQuPC9k
aXY+DQo8ZGl2Pjxicj4NCjwvZGl2Pg0KPGRpdj5XaXRoIHRoYXQgaW4gbWluZCwgaXQgbG9va3Mg
bGlrZSB0aGlzIHBhdGNoIGlzIGNyaXRpY2FsIGZvciBmaXhpbmcgYSByZWxlYXNlIGlzc3VlOyBp
dCdzIGluIGNvcmUgY29kZSwgYnV0IGhhcyBhbHNvIGhhcyBhIGxvdCBvZiBzY3J1dGlueS4mbmJz
cDsgU28gd2l0aCB0aGF0IGluIG1pbmQ6PC9kaXY+DQo8ZGl2Pjxicj4NCjwvZGl2Pg0KPGRpdj5S
ZWxlYXNlLWFja2VkLWJ5OiBHZW9yZ2UgRHVubGFwICZsdDs8YSBocmVmPSJtYWlsdG86Z2Vvcmdl
LmR1bmxhcEBjaXRyaXguY29tIiBtb3otZG8tbm90LXNlbmQ9InRydWUiIGNsYXNzPSJtb3otdHh0
LWxpbmstZnJlZXRleHQiPmdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbTwvYT4mZ3Q7PC9kaXY+DQo8
L2Rpdj4NCjwvZGl2Pg0KPC9ibG9ja3F1b3RlPg0KPGJyPg0KQXQgdGhlIGVuZCBvZiB0aGUgZGF5
LCBSLWFjayBtZWFucyAmcXVvdDtJIGhhdmUgZGVlbWVkIHRoaXMgaW1wb3J0YW50IGZvciB0aGUg
cmVsZWFzZSZxdW90OywgYW5kIHRoZSBjb21taXR0ZXJzIGFyZSB0aGUgZmFsbGJhY2sgZm9yIGFs
bCBjb3JuZXIgY2FzZXMuJm5ic3A7IEknZCBzYXkgdGhhdCdzIGFscmVhZHkgY292ZXJlZCBpbiB0
aGUgZXhpc3RpbmcgcnVsZXMgYW5kIGNvbnZlbnRpb25zLCBnaXZlbiB0aGUgZXhwZWN0YXRpb24g
dGhhdCBjb21taXR0ZXJzIHdvdWxkbid0DQogdHJlYWQgb24gdGhlIHRvZXMgb2YgdGhlIFJNIGlu
IHRoZSBmaXJzdCBwbGFjZS48YnI+DQo8YnI+DQp+QW5kcmV3PGJyPg0KPC9ib2R5Pg0KPC9odG1s
Pg0K

--_000_7c6b18944dbe8d8b9f08c07214b65844citrixcom_--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 20:14:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 20:14:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426013.674185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFSD-0002Zk-5p; Wed, 19 Oct 2022 20:14:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426013.674185; Wed, 19 Oct 2022 20:14:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFSD-0002Zd-2t; Wed, 19 Oct 2022 20:14:17 +0000
Received: by outflank-mailman (input) for mailman id 426013;
 Wed, 19 Oct 2022 20:14:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olFSB-0002ZX-Nh
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 20:14:15 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99e1e86c-4fea-11ed-91b4-6bf2151ebd3b;
 Wed, 19 Oct 2022 22:14:14 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id E79D8B82565;
 Wed, 19 Oct 2022 20:14:13 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4D1CC433C1;
 Wed, 19 Oct 2022 20:14:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99e1e86c-4fea-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666210452;
	bh=FF9KbNdQHNh5m0gRXO+KOo0OL+lC7nTVEehSa0aIgP8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=SRl92ku75ud54oQvG8QH8BzfmVKYxQYsk+dzgPMOj0s+FUkIoFBmtl2p6aI/i1Vnw
	 VJLWRDlYIGUMfie9r2qSSh3u99HN5fM+tLMo3S6ZdwlnUXR+6Or3hIr+y7KTZRUVWy
	 LpWhuVgdg0iV/YrS7ySBJcgTUbnQrEgnPR6oJBorUCtwTqOMHgEmRBKJTMal59osZv
	 21K41MB9XgMD1uzxwAzO5ShGfrHfQTlY0Iq6vlyhsMX+zKSZVT5Qn/pnjPCUh2SRJO
	 clK5e1+MHMSwiPeBHcv3QjXeecWSLUamp+7RY3N9nsiiVomlolBnTivGON9yjPlovl
	 tUmsYBorV9soQ==
Date: Wed, 19 Oct 2022 13:14:10 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Juergen Gross <jgross@suse.com>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
In-Reply-To: <af1a47f4-be0a-141d-8e53-0be303486a1a@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210191313070.3873@ubuntu-linux-20-04-desktop>
References: <20221015153409.918775-1-olekstysh@gmail.com> <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop> <af1a47f4-be0a-141d-8e53-0be303486a1a@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1494198937-1666210452=:3873"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1494198937-1666210452=:3873
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 19 Oct 2022, Oleksandr Tyshchenko wrote:
> On 19.10.22 03:58, Stefano Stabellini wrote:
> > On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
> >> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> >>
> >> Use the same "xen-grant-dma" device concept for the PCI devices
> >> behind device-tree based PCI Host controller, but with one modification.
> >> Unlike for platform devices, we cannot use generic IOMMU bindings
> >> (iommus property), as we need to support more flexible configuration.
> >> The problem is that PCI devices under the single PCI Host controller
> >> may have the backends running in different Xen domains and thus have
> >> different endpoints ID (backend domains ID).
> >>
> >> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
> >> properties) which allows us to describe relationship between PCI
> >> devices and backend domains ID properly.
> >>
> >> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > Now that I understood the approach and the reasons for it, I can review
> > the patch :-)
> 
> perfect, thanks.
> 
> 
> >
> > Please add an example of the bindings in the commit message.
> 
> ok, will do
> 
> 
> >
> >
> >> ---
> >> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> >> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> >> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> >> than for platform devices.
> >>
> >> Changes V1 -> V2:
> >>     - update commit description
> >>     - rebase
> >>     - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> >>
> >> Previous discussion is at:
> >> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!xJPdZO3-3Wmgo_79HuDsD53RkH_eAN96NmwuwFE7dArt_xNYGdD6LeLsq4B_QPrrvX-x23tJl6jQlNqgyNjgzT2NE3Pqjg$  [lore[.]kernel[.]org]
> >>
> >> Based on:
> >> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1__;!!GF_29dbcQIUBPA!xJPdZO3-3Wmgo_79HuDsD53RkH_eAN96NmwuwFE7dArt_xNYGdD6LeLsq4B_QPrrvX-x23tJl6jQlNqgyNjgzT2J40LOxg$  [git[.]kernel[.]org]
> >> ---
> >>   drivers/xen/grant-dma-ops.c | 87 ++++++++++++++++++++++++++++++++-----
> >>   1 file changed, 76 insertions(+), 11 deletions(-)
> >>
> >> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> >> index daa525df7bdc..b79d9d6ce154 100644
> >> --- a/drivers/xen/grant-dma-ops.c
> >> +++ b/drivers/xen/grant-dma-ops.c
> >> @@ -10,6 +10,7 @@
> >>   #include <linux/module.h>
> >>   #include <linux/dma-map-ops.h>
> >>   #include <linux/of.h>
> >> +#include <linux/pci.h>
> >>   #include <linux/pfn.h>
> >>   #include <linux/xarray.h>
> >>   #include <linux/virtio_anchor.h>
> >> @@ -292,12 +293,55 @@ static const struct dma_map_ops xen_grant_dma_ops = {
> >>   	.dma_supported = xen_grant_dma_supported,
> >>   };
> >>   
> >> +static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
> >> +{
> >> +	struct pci_dev *pdev = to_pci_dev(dev);
> >> +	struct pci_bus *bus = pdev->bus;
> >> +
> >> +	/* Walk up to the root bus to look for PCI Host controller */
> >> +	while (!pci_is_root_bus(bus))
> >> +		bus = bus->parent;
> >> +
> >> +	return of_node_get(bus->bridge->parent->of_node);
> >> +}
> > It seems silly that we need to walk the hierachy that way, but I
> > couldn't find another way to do it
> 
> I also couldn't, but is it a really problem? This code is only gets 
> called during initialization.
> 
> 
> >
> >
> >> +static struct device_node *xen_dt_get_node(struct device *dev)
> >> +{
> >> +	if (dev_is_pci(dev))
> >> +		return xen_dt_get_pci_host_node(dev);
> >> +
> >> +	return of_node_get(dev->of_node);
> >> +}
> >> +
> >> +static int xen_dt_map_id(struct device *dev, struct device_node **iommu_np,
> >> +			 u32 *sid)
> >> +{
> >> +	struct pci_dev *pdev = to_pci_dev(dev);
> >> +	u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> >> +	struct device_node *host_np;
> >> +	int ret;
> >> +
> >> +	host_np = xen_dt_get_pci_host_node(dev);
> >> +	if (!host_np)
> >> +		return -ENODEV;
> >> +
> >> +	ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask", iommu_np, sid);
> >> +	of_node_put(host_np);
> >> +	return ret;
> >> +}
> >> +
> >>   static bool xen_is_dt_grant_dma_device(struct device *dev)
> >>   {
> >> -	struct device_node *iommu_np;
> >> +	struct device_node *iommu_np = NULL;
> >>   	bool has_iommu;
> >>   
> >> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> >> +	if (dev_is_pci(dev)) {
> >> +		if (xen_dt_map_id(dev, &iommu_np, NULL))
> >> +			return false;
> >> +	} else
> >> +		iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> >> +
> >>   	has_iommu = iommu_np &&
> >>   		    of_device_is_compatible(iommu_np, "xen,grant-dma");
> >>   	of_node_put(iommu_np);
> >> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
> >>   
> >>   bool xen_is_grant_dma_device(struct device *dev)
> >>   {
> >> +	struct device_node *np;
> >> +
> >>   	/* XXX Handle only DT devices for now */
> >> -	if (dev->of_node)
> >> -		return xen_is_dt_grant_dma_device(dev);
> >> +	np = xen_dt_get_node(dev);
> >> +	if (np) {
> >> +		bool ret;
> >> +
> >> +		ret = xen_is_dt_grant_dma_device(dev);
> >> +		of_node_put(np);
> >> +		return ret;
> >> +	}
> > We don't need to walk the PCI hierachy twice. Maybe we can add the
> > of_node check directly to xen_is_dt_grant_dma_device?
> 
> 
> Good point. I was thinking that we would likely need the following 
> construct is the future:
> 
> 
> if (np) /* DT device */
>     return xen_is_dt_grant_dma_device(dev);
> else /* ACPI device */
>     return xen_is_acpi_grant_dma_device(dev);
> 
> 
> So, if we use the check directly in xen_is_dt_grant_dma_device() and it 
> returns false we won't be able to recognize a reason then
> (whether dev is not related to DT, or it is related to DT but it is not 
> a "xen,grant-dma" device).

That problem can easily be solved by having xen_is_dt_grant_dma_device
return more than 2 possible values. It could return an int for example,
with 3 valid values.


> But, I am ok to eliminate one walk right now, then we will see.
> 
> xen_is_grant_dma_device() will became the following:
> 
> bool xen_is_grant_dma_device(struct device *dev)
> {
>      return xen_is_dt_grant_dma_device(dev);
> }
> 
> xen_is_dt_grant_dma_device() will need to gain a check that dev->of_node 
> is not a NULL.
> 
> 
> Shall I?

--8323329-1494198937-1666210452=:3873--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 20:15:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 20:15:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426019.674196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFT3-0003BA-JO; Wed, 19 Oct 2022 20:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426019.674196; Wed, 19 Oct 2022 20:15:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFT3-0003B3-Gc; Wed, 19 Oct 2022 20:15:09 +0000
Received: by outflank-mailman (input) for mailman id 426019;
 Wed, 19 Oct 2022 20:15:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=y3fJ=2U=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1olFT1-0003Ak-I1
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 20:15:07 +0000
Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com
 [2607:f8b0:4864:20::72e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b8b65fa2-4fea-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 22:15:06 +0200 (CEST)
Received: by mail-qk1-x72e.google.com with SMTP id b25so11496045qkk.7
 for <xen-devel@lists.xenproject.org>; Wed, 19 Oct 2022 13:15:06 -0700 (PDT)
Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:ba27:ebff:fee8:ce27])
 by smtp.gmail.com with ESMTPSA id
 bj3-20020a05620a190300b006eeca296c00sm5813448qkb.104.2022.10.19.13.15.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 19 Oct 2022 13:15:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8b65fa2-4fea-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=P6ehJmZtaKjHfWDooxLByyg7Qm8nO8821wCtlJKz2+4=;
        b=TybltSlWY2qkowVbGkbhGUhl8GW5569umxbF7Wp6iG+ZXAuhuOylG8yjLXPo43vTZA
         dAabbW135Irpmk/ZJVBz1w3a4szDvKd7Dqfim+MtPKw7HA6Q6rElVHH1UEeH+Bwq16qk
         qtW6K4LiAVNCwVj+YAVZK2AVdn05XYfHM+5Zisi1UnbBb4mgqL/djqPx60S1WgFMFGxf
         DT8E7ijLIq5TjewGJ6yZvF33qampqKD28bJPN/sHzTIgAu7pKWqfOL0WwZGdiC77iomF
         uV6PwFQBRaOKse1ujXcu1EBwRjxIiPRbXDvBDCURMMUnwQne/kqKCqQ443yFSL/XonOU
         vKcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=P6ehJmZtaKjHfWDooxLByyg7Qm8nO8821wCtlJKz2+4=;
        b=3Gu1zmAcg+TC/DnDT1xaDcPtJuxcKvrCERVbmDtS2TuNFdxi4WTtScRIEeMemJrDQy
         8qdSAEPXuJf7J4ZMmTzX4snKw/Z10sSLeq0psS4VYxJsZ5DCGt6BCqST1JCVbb0/e0Ef
         uJprA01WYZPqgkwQ6UwmHZCRU353njhDCYrxVE2oN1g8TKG3cxuOqC2Yl4eXF1Fe6wYG
         +nFu5sSL22LHFe5oOSVLf1L7tMgyY8oyVJ4Om1L2AzZtu0hNnoc5Po4mvoQOGyMbCAOH
         VEm41L/yHFO7cI7etvvV3KFheoAfWjLtoUGT3n7t1MiYSEjnXyCNj6zslpgpIhlgRW5O
         Z4SQ==
X-Gm-Message-State: ACrzQf2DQH2vbGiMEM6zwfAFAqO5j1wDkDJ/pe1xC1l7f7qY/MI6+irU
	rIr5D96lNdATskKHIok430TrToSYfCc=
X-Google-Smtp-Source: AMsMyM4ZHmOVoj5agvIt9yLlHK+ps82y567FzoPncwvnc5+QX6N88fZlpsF0dCXNDa/n+eOBD4dBCg==
X-Received: by 2002:a05:620a:3708:b0:6ee:d16f:b780 with SMTP id de8-20020a05620a370800b006eed16fb780mr6861107qkb.144.1666210505337;
        Wed, 19 Oct 2022 13:15:05 -0700 (PDT)
From: Jason Andryuk <jandryuk@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Jason Andryuk <jandryuk@gmail.com>,
	Phillip Susi <phill@thesusis.net>,
	stable@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org
Subject: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias
Date: Wed, 19 Oct 2022 16:14:57 -0400
Message-Id: <20221019201458.21803-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.37.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

xen kbdfront registers itself as being able to deliver *any* key since
it doesn't know what keys the backend may produce.

Unfortunately, the generated modalias gets too large and uevent creation
fails with -ENOMEM.

This can lead to gdm not using the keyboard since there is no seat
associated [1] and the debian installer crashing [2].

Trim the ranges of key capabilities by removing some BTN_* ranges.
While doing this, some neighboring undefined ranges are removed to trim
it further.

This removes:
BTN_DPAD_UP(0x220)..BTN_DPAD_RIGHT(0x223)
Empty space 0x224..0x229

Emtpy space 0x2bd..0x2bf
BTN_TRIGGER_HAPPY(0x2c0)..BTN_TRIGGER_HAPPY40(0x2e7)
Empty space 0x2e8..0x2ff

The modalias shrinks from 2082 to 1754 bytes.

[1] https://github.com/systemd/systemd/issues/22944
[2] https://lore.kernel.org/xen-devel/87o8dw52jc.fsf@vps.thesusis.net/T/

Cc: Phillip Susi <phill@thesusis.net>
Cc: stable@vger.kernel.org
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
 drivers/input/misc/xen-kbdfront.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 8d8ebdc2039b..23f37211be78 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -256,7 +256,14 @@ static int xenkbd_probe(struct xenbus_device *dev,
 		__set_bit(EV_KEY, kbd->evbit);
 		for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
 			__set_bit(i, kbd->keybit);
-		for (i = KEY_OK; i < KEY_MAX; i++)
+		/* In theory we want to go KEY_OK..KEY_MAX, but that grows the
+		 * modalias line too long.  KEY_KBD_LCD_MENU5 is the last
+		 * defined non-button key. There is a gap of buttons from
+		 * BTN_DPAD_UP..BTN_DPAD_RIGHT and KEY_ALS_TOGGLE is the next
+		 * defined. */
+		for (i = KEY_OK; i < BTN_DPAD_UP; i++)
+			__set_bit(i, kbd->keybit);
+		for (i = KEY_ALS_TOGGLE; i <= KEY_KBD_LCD_MENU5; i++)
 			__set_bit(i, kbd->keybit);
 
 		ret = input_register_device(kbd);
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Wed Oct 19 20:38:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 20:38:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426027.674207 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFpo-0005l0-FI; Wed, 19 Oct 2022 20:38:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426027.674207; Wed, 19 Oct 2022 20:38:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olFpo-0005kt-CF; Wed, 19 Oct 2022 20:38:40 +0000
Received: by outflank-mailman (input) for mailman id 426027;
 Wed, 19 Oct 2022 20:38:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olFpn-0005kn-U4
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 20:38:40 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02851d08-4fee-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 22:38:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5F291B825C4;
 Wed, 19 Oct 2022 20:38:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 472F0C433C1;
 Wed, 19 Oct 2022 20:38:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02851d08-4fee-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666211916;
	bh=A/VeIiymKAD/CA/qi6EVdDQ9Ix/I6WbTZMy4WD/Zvdc=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=SOl4GvBO0+9bc1cDDPss8etiIjqoxxxV2PTlQa/GUdtICkfpc+g/dKGA+WxssDsnj
	 pEDjm3FNW15KrBof4o7ltUgybSljk3q/+uvEVXvOJRHCaYTCdvkLelMsT+ongQZwN4
	 prwvyANRKaMawTPsqvNgeGQTm1+F+s/vAAPoHbN7CJLGU5woD/XqJmPJnLkK3OBIAl
	 sfwV9eqHlzMQErykxsA5q1J8SJEftKymEYBPxdFA+xNpxqZNp09t2d7pQ4LQZGxOT3
	 HTK7qdpwCMIdjrZdewcG3fxJgBWylcw4Z6ZJMstA0fq5kr100v/MoSrq+FSHUjERg3
	 q5zqCOQrWMlOg==
Date: Wed, 19 Oct 2022 13:38:33 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Oleksandr Tyshchenko <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
    Juergen Gross <jgross@suse.com>, vikram.garhwal@amd.com
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
In-Reply-To: <af073c71-df43-4a5c-c67a-a9858678f588@epam.com>
Message-ID: <alpine.DEB.2.22.394.2210191314410.3873@ubuntu-linux-20-04-desktop>
References: <20221006174804.2003029-1-olekstysh@gmail.com> <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop> <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com> <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
 <16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com> <alpine.DEB.2.22.394.2210171323450.2351079@ubuntu-linux-20-04-desktop> <af073c71-df43-4a5c-c67a-a9858678f588@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-682290085-1666210582=:3873"
Content-ID: <alpine.DEB.2.22.394.2210191316280.3873@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-682290085-1666210582=:3873
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210191316281.3873@ubuntu-linux-20-04-desktop>

+ Vikram

On Wed, 19 Oct 2022, Oleksandr Tyshchenko wrote:
> >> Regarding the virtio-mmio (platform) devices, yes, we could expose them
> >> with status "disabled", and they won't get probed by default.
> >> To be honest, I have experimented with that, when I was thinking of
> >> possible hotplug for virtio-mmio devices (I know, this sounds uncommon
> >> and strange).
> >> I used Linux feature (CONFIG_OF_DYNAMIC, overlays) to update the
> >> device-tree on running guest, so the toolstack initially inserts
> >> virtio-mmio device nodes for non-boot devices
> >> with status "disabled", and at the runtime, once we receive an event for
> >> example, we change the status to "ok" and the corresponding virtio-mmio
> >> device gets probed.
> >> But again, it is not a 100% hotplug, as we need to pre-allocate memory
> >> range and interrupt in advance (when generating guest device tree).
> > Actually this is really cool! Does it work? It doesn't matter to me if
> > the virtio devices are pci or mmio as long as we can solve the "wait"
> > problem. So this could be a good solution.
> 
> 
> ... yes, it does. Initially I experimented with virtio-mmio devices, but 
> today I tried with PCI host bridge as well.
> I won't describe the commands which I used to apply/remove device-tree 
> overlays from the userspace as well as the context of
> dtso files I created, I will describe how that could be done from the 
> kernel by using existing functionality (CONFIG_OF_DYNAMIC).
> 
> As I said if we exposed the devices with status "disabled", they 
> wouldn't get probed by default. Once we receive an signal
> that otherend is ready, we change the status to "ok" and the 
> corresponding device gets probed.
> 
> So below the test patch, which just change the status of the required 
> device-tree node (as you can see the code to update the property is 
> simple enough),
> I hacked "xl sysrq" for the convenience of testing.
> 
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 045c1805b2d5..9683ce075bc9 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>   #include <linux/module.h>
>   #include <linux/dma-map-ops.h>
>   #include <linux/of.h>
> +#include <linux/of_platform.h>
>   #include <linux/pci.h>
>   #include <linux/pfn.h>
>   #include <linux/xarray.h>
> @@ -379,6 +380,108 @@ bool xen_is_grant_dma_device(struct device *dev)
>          return false;
>   }
> 
> +/* TODO: Consider using statically allocated (struct property status) */
> +static int xen_grant_dma_enable_device(struct device_node *np)
> +{
> +       struct property *status;
> +
> +       status = kzalloc(sizeof(*status), GFP_KERNEL);
> +       if (!status)
> +               return -ENOMEM;
> +
> +       status->name = kstrdup("status", GFP_KERNEL);
> +       if (!status->name)
> +               return -ENOMEM;
> +
> +       status->value = kstrdup("okay", GFP_KERNEL);
> +       if (!status->value)
> +               return -ENOMEM;
> +
> +       status->length = sizeof("okay");
> +
> +       return of_update_property(np, status);
> +}
> +
> +static int xen_grant_dma_disable_device(struct device_node *np)
> +{
> +       struct property *status;
> +
> +       status = kzalloc(sizeof(*status), GFP_KERNEL);
> +       if (!status)
> +               return -ENOMEM;
> +
> +       status->name = kstrdup("status", GFP_KERNEL);
> +       if (!status->name)
> +               return -ENOMEM;
> +
> +       status->value = kstrdup("disabled", GFP_KERNEL);
> +       if (!status->value)
> +               return -ENOMEM;
> +
> +       status->length = sizeof("disabled");
> +
> +       return of_update_property(np, status);
> +}
> +
> +void xen_grant_dma_handle_sysrq(int key)
> +{
> +       struct device_node *np;
> +       const char *path;
> +       bool enable;
> +
> +       printk("%s: got key %d\n", __func__, key);
> +
> +       switch (key) {
> +       case '0':
> +               path = "/virtio@2000000";
> +               enable = true;
> +               break;
> +
> +       case '1':
> +               path = "/virtio@2000200";
> +               enable = true;
> +               break;
> +
> +       case '2':
> +               path = "/virtio@2000000";
> +               enable = false;
> +               break;
> +
> +       case '3':
> +               path = "/virtio@2000200";
> +               enable = false;
> +               break;
> +
> +       case '4':
> +               path = "/pcie@10000000";
> +               enable = true;
> +               break;
> +
> +       case '5':
> +               path = "/pcie@10000000";
> +               enable = false;
> +               break;
> +
> +       default:
> +               printk("%s: wrong key %d\n", __func__, key);
> +               return;
> +       }
> +
> +       np = of_find_node_by_path(path);
> +       if (!np) {
> +               printk("%s: failed to find node by path %s\n", __func__, 
> path);
> +               return;
> +       }
> +
> +       if (enable) {
> +               xen_grant_dma_enable_device(np);
> +               printk("%s: enable %s\n", __func__, path);
> +       } else {
> +               xen_grant_dma_disable_device(np);
> +               printk("%s: disable %s\n", __func__, path);
> +       }
> +}
> +
>   bool xen_virtio_mem_acc(struct virtio_device *dev)
>   {
>          if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain())
> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index c16df629907e..6df96be1ea40 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -308,7 +308,8 @@ static void sysrq_handler(struct xenbus_watch 
> *watch, const char *path,
>                  goto again;
> 
>          if (sysrq_key != '\0')
> -               handle_sysrq(sysrq_key);
> +               /*handle_sysrq(sysrq_key);*/
> +               xen_grant_dma_handle_sysrq(sysrq_key);
>   }
> 
>   static struct xenbus_watch sysrq_watch = {
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a34f4271a2e9..c2da1bc24091 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -215,6 +215,8 @@ static inline void xen_preemptible_hcall_end(void) { }
> 
>   #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
> 
> +void xen_grant_dma_handle_sysrq(int key);
> +
>   #ifdef CONFIG_XEN_GRANT_DMA_OPS
>   void xen_grant_setup_dma_ops(struct device *dev);
>   bool xen_is_grant_dma_device(struct device *dev);
> (END)
> 
> So how it looks like:
> 
> 1. DomU boots without PCI Host bridge probed. So nothing PCI related is 
> observed in DomU.
> 
> cat /proc/device-tree/pcie@10000000/status
> disabled
> 
> 2. I run backends in DomD and after that issue a signal to "enable"
> 
> root@generic-armv8-xt-dom0:~# xl sysrq DomU 4
> 
> 3. The PCI Host bridge is probed, and all required PCI devices are 
> discovered
> 
> root@generic-armv8-xt-dom0:~# xl console DomU
> [  237.407620] xen_grant_dma_handle_sysrq: got key 52
> [  237.408133] pci-host-generic 10000000.pcie: host bridge 
> /pcie@10000000 ranges:
> [  237.408186] pci-host-generic 10000000.pcie:      MEM 
> 0x0023000000..0x0032ffffff -> 0x0023000000
> [  237.408231] pci-host-generic 10000000.pcie:      MEM 
> 0x0100000000..0x01ffffffff -> 0x0100000000
> [  237.408313] pci-host-generic 10000000.pcie: ECAM at [mem 
> 0x10000000-0x1fffffff] for [bus 00-ff]
> [  237.408451] pci-host-generic 10000000.pcie: PCI host bridge to bus 
> 0000:00
> [  237.408490] pci_bus 0000:00: root bus resource [bus 00-ff]
> [  237.408517] pci_bus 0000:00: root bus resource [mem 
> 0x23000000-0x32ffffff]
> [  237.408545] pci_bus 0000:00: root bus resource [mem 
> 0x100000000-0x1ffffffff pref]
> [  237.409043] pci 0000:00:00.0: [1b36:0008] type 00 class 0x060000
> [  237.458045] pci 0000:00:01.0: [1af4:1041] type 00 class 0x020000
> [  237.502588] pci 0000:00:01.0: reg 0x20: [mem 0x00000000-0x00003fff 
> 64bit pref]
> [  237.507475] pci 0000:00:02.0: [1af4:1042] type 00 class 0x010000
> [  237.552706] pci 0000:00:02.0: reg 0x20: [mem 0x00000000-0x00003fff 
> 64bit pref]
> [  237.559847] pci 0000:00:01.0: BAR 4: assigned [mem 
> 0x100000000-0x100003fff 64bit pref]
> [  237.560411] pci 0000:00:02.0: BAR 4: assigned [mem 
> 0x100004000-0x100007fff 64bit pref]
> [  237.563324] virtio-pci 0000:00:01.0: Set up Xen grant DMA ops (rid 
> 0x8 sid 0x1)
> [  237.564833] virtio-pci 0000:00:01.0: enabling device (0000 -> 0002)
> [  237.582734] virtio-pci 0000:00:02.0: Set up Xen grant DMA ops (rid 
> 0x10 sid 0x1)
> [  237.583413] virtio-pci 0000:00:02.0: enabling device (0000 -> 0002)
> [  237.595712] virtio_blk virtio1: 4/0/0 default/read/poll queues
> [  237.596227] virtio_net virtio0 enp0s1: renamed from eth1
> [  237.602499] virtio_blk virtio1: [vda] 4096000 512-byte logical blocks 
> (2.10 GB/1.95 GiB)
> [  237.606317] xen_grant_dma_handle_sysrq: enable /pcie@10000000
> 
> 4. The same way the pseudo-hotremove would work (if we change the status 
> to "disabled" the corresponding device gets removed)
> 
> 
> If this pseudo-hotplug sounds appropriate for the dom0less,

This is great! Yes I think it is totally acceptable.


> the one of the next questions would be what mechanism to use for
> signalling (event, xenstore, whatever).

For your information, we had to solve a similar issue a few months ago
to let a domU discover a newly added and directly assigned programmable
logic block. That was also done by applying DT overlays, first to Xen,
then to the domU.

Have a look at Vikram's Xen Summit presentation:
https://static.sched.com/hosted_files/xen2022/e8/Introduce%20Dynamic%20Device%20Node%20Programming%20for%20Xen.pdf

We wrote a small xenstore-based protocol to notify the domU and also to
tranfer the overlay to it:

https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/docs/misc/arm/overlay.txt
https://github.com/Xilinx/xen/blob/xlnx_rebase_4.16/tools/helpers/get_overlay.c

There is a good description starting at slide 16 in the PDF.


I am only sharing this as FYI. This Virtio problem is simpler because we
already know the devices that are going to become available. We don't
need an actual DT overlay to be passed to the domU. So we could get away
with just a single interrupt or a single xenstore property.


> Note that signal should only be sent if all backends which serve
> virtio-pci devices within that PCI Host bridge are ready.

Yes. That should be fine as long as all the backends are in the same
domain. I can imagine there could be difficulties if the backends are
in different domains: backend-domain-1 would have to tell dom0 that it
is ready, then backend-domain-2 would have to do the same, then dom0
finally notifies the domU, or something like that.

Anyway, I think this is good enough to start as a solution. Excellent!


> >>> Other ideas?
> >> Another (crazy?) idea is to reuse CONFIG_XEN_VIRTIO_FORCE_GRANT for
> >> dom0less system (I mean without "xen,grant-dma" bindings at all).
> >> If virtio backends are always going to run in Dom0 when we have it up
> >> and running, then it should work as domid == 0 is reserved for Dom0.
> >> If there is a need to run virtio backends in other *backend* domain (for
> >> the domain ID to be always known we could reserve an ID for it, so it
> >> would be a const value),
> >> we could probably introduce something configurable like
> >> CONFIG_XEN_VIRTIO_FORCE_GRANT_BE_DOMID with 0 by default (or cmd line
> >> option).
> > The problem in a dom0less system is not much how to tell which is the
> > backend domid, because that is known in advance and could be added to
> > device tree at boot somehow. The issue is how to ask the frontend to
> > "wait" and then how to tell the frontend to "proceed" after the backend
> > comes online.
> 
> please see above.
> 
> 
> To summarize:
> 
> 1. For normal case there is no problem with communicating the backend 
> domid on Arm with device-tree (neither for virtio-mmio nor for virtio-pci),
> for the virtio-pci the V2 (PCI-IOMMU bindings) should be used. For the 
> dom0less there won't be problem also as I understood from the discussion 
> (as the configuration is known in advance).
> So I propose to concentrate on V2.

Yes I agree


> 2. The problem is in supporting virtio for the dom0less in general 
> despite whether it is a foreign or grant mappings.
> Here we would need a (pseudo-)hotplug or some other method to start 
> operating only when backend is available.

Yes I think you are right
--8323329-682290085-1666210582=:3873--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 21:31:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 21:31:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426033.674218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olGen-0003RL-Bl; Wed, 19 Oct 2022 21:31:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426033.674218; Wed, 19 Oct 2022 21:31:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olGen-0003RE-8m; Wed, 19 Oct 2022 21:31:21 +0000
Received: by outflank-mailman (input) for mailman id 426033;
 Wed, 19 Oct 2022 21:31:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Rl4W=2U=citrix.com=prvs=284ee54c8=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olGel-0003R7-JN
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 21:31:19 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c964278-4ff5-11ed-8fd0-01056ac49cbb;
 Wed, 19 Oct 2022 23:31:17 +0200 (CEST)
Received: from mail-sn1anam02lp2042.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 19 Oct 2022 17:30:57 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MW4PR03MB6588.namprd03.prod.outlook.com (2603:10b6:303:12b::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct
 2022 21:30:52 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 21:30:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c964278-4ff5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666215077;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=Yv/QVJRsUp/yPss4XDO2uyARKytCTQ2rbplWR1kFyvM=;
  b=E/WoKZHDqC8Fl8pwH+sxZd0sePkT+yRseupUT7YC4IkYMV688slgi5q/
   B69LwVWs1ll5gGycAP4DXM2b1er2O1VEJ8wv0g+b1e70+La9mlw0wD8KV
   kl697oJzw6LJjepaAQN5nPyChlzRUxcy/qkuBd7x1W6eoTGSF8PTZVQKt
   4=;
X-IronPort-RemoteIP: 104.47.57.42
X-IronPort-MID: 82738378
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:HfJLD6MSN8QuKcbvrR1WlsFynXyQoLVcMsEvi/4bfWQNrUoj1WEEm
 2dKCD3UPv2NYDP2Ktp+atu+oEwEv5SAxtFkHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayr6WtD1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eN4EK6vhSKEt30
 flIJjwXXBvT17yP3+fuIgVsrpxLwMjDGqo64isl9heASPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTJ/8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toijz3b+UwnOTtIQ6L761xKNaoGSpyEMIFEEvUgGhkNiDsxvrMz5YA
 wlOksY0loAw6UiqQ9/VTxC+5nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv
 nepktXzFHpQubuaYXuH8/GfqjbaETMOMWYIaCsATA0Ey9ruuoc+ilTIVNkLOJCyitr5CDTh2
 QegpSI1h6gQpcMT3qD99lfC6xqmq4LVVAcz6kPSV3i88wJiTIe/Ysqj7l2z0BpbBIOQT13Ep
 35dks6X6bhUCYnXzHDXBuIQALuu+vCJdiXGhkJiFIUg8DLr/GO/eYdX43d1I0IB3ts4RAIFq
 XT74Wt5jKK/9lPzBUOrS+pd0/gX8JU=
IronPort-HdrOrdr: A9a23:W9/dJKkwzdx9jNSywvWKQbc2aNrpDfOPimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee
 r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+
 uzUagmccPeEQ==
X-IronPort-AV: E=Sophos;i="5.95,196,1661832000"; 
   d="scan'208";a="82738378"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k0atHUHmgsqhzOJd3nDnPiNuhRCixflxSAlx7b5WACmIeMyUJEJn+8WjG7vE29BOrtQW44idq2Ng+QIQvhHnvBztRtD33rJqIyc5Dq4CHvRn54jyUN/xAcEGF3uSYEThi7JcGu9SkhFCm3ey3PCt1YTyzZ/XZHM7A7byfhAPoe9NXAVWnSoVKL3IH3lPjT1ZuexFVRqYfifut7PBHsbnQdiY/DKUc2UZg9Z6WAd/vKIZSGrxZVgI/Vu8Vvo3CczYzrZc6j1UsFa118JV8oW+cAwCtMpn8GQmD24pYVn1Hq3mhYCakCjR1ogXIGH6WGDb6cX3GtB6sYKbCNbOgB1h9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yv/QVJRsUp/yPss4XDO2uyARKytCTQ2rbplWR1kFyvM=;
 b=gRhj6KrINKmF6Qmke7lIsRSAsjSVJkrlKT2C3jWqprSvLVXLd5XtoKX4+L0NI8VSzd2lXRAaIEnbr+AKZlGlaT5qd6iZhbo0ecmGpapd5+bhRg+VlB/u4cLWpfueLzxKj7ywmKlTFBSntr2PLkgt6BTFC0iLol6WOngkOcxJafnm5t18XwgcPDR74KrZrwj7G1KLKZxLqVYycNnLtrxfuMFZpMZGDXf3us/u5zJXRejkcpMWlhFbM8EituPbFailPutF1pATrwiWrn4x+uSgQo3b4iwtWU8baPx+zumBMw3vLq+9xpzweLN6QAVGelRhhtiVz6dGr7yNq6k6YDo2yQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yv/QVJRsUp/yPss4XDO2uyARKytCTQ2rbplWR1kFyvM=;
 b=V3CkOAKJyYZIiSXT6ElKXM2IlKMh0OKtwADkQp+FoiX2P66AcB6edMG9h1LMZCIfqkwX37wqSzqutyxoOsOYq9ljhd3Se9F9MsMWWfLe2JfKI4N3/d6d0yAMc+0fX/NECVl2K0JM4avdUOJdB45MozoY5xsusQsfew2JEOSby1Y=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
CC: Henry Wang <Henry.Wang@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index: AQHY4lyBiWnfx+vnUkmAUdSmWjh5Xq4TC2qAgAAU4ACAABPHgIADC1WA
Date: Wed, 19 Oct 2022 21:30:51 +0000
Message-ID: <dffdc951-91fd-2659-ec7f-5c213138d785@citrix.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
 <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
 <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
 <5587f5bd-1694-a843-9e80-ad477527a576@xen.org>
In-Reply-To: <5587f5bd-1694-a843-9e80-ad477527a576@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MW4PR03MB6588:EE_
x-ms-office365-filtering-correlation-id: 57ee49a3-10bc-47ba-94ba-08dab2193271
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 3wsBPKkn/aOMwDRtMjmWnbaAvIAlvb5iOwtKs2GjONb9u6IiroyactEH18F4MPZWO+XJPYBI/l/hJR2MDiOINPiJjFPwE74TjfqGonHkDFySQ2tsc4yxrOyIr7M+nEjkmnemd9yUoAlZC3/tZxLEGKuopqG8GEFZk9EVLQLxfRd/KJ5eVcWXwNSpm2NxIxvLWK5Ab20P7BFarq9n7r8rqmYAoUMcmE0uR1Teq7GXnVrCRXZ+yJORbUjeVZlT0Z7c0egzKXS8NaWyBbJbwwo2kK/oB1MMgK/2vBdsSlAQs7q8ZzVQnm6CWpQZO9txlzQQcvHIgvDRug/qbFDzy9gH1sBcLkkHXnsBL5Pa9LIDGstvp91ZLg6PPqCZKT0xg8SBjTTec4cYqOXqGdAT/dHS/lOHmZjFD+Qm0NlZPF3OHq/Y3n3EAMTsOrbLpH+hIUWjfrm9zufe84JiBnD5ovKSI5XsIK8n5bF5Zj4cMBiswX7J4vhhedGmy9SsqLuTnCo/T2FHY2lN8YHSEJCmQidti3txS5rbfQHVS4zzurCKYY+MxFO+5bh0VqFqfwrW0TcLsM56wsGoBSnM421QZY6OV4Tw6vQ8GV71vtXPjxX7SSNykgG+IPfbs3mDUeLCM7GTVVViOJq3pm5QCZDV4Sip3ayXkelMCLin5MS1ol9WQmgCyKM6Bt03lWYiBO+366iHvIcdQ9M88xRrbHAWOTKRCWkrm4YmxXVyZSSnzfhbPD9t09Yi7nD6hmNNKGqOjjrfI0krxNalYD0DtSaG9KcKmAf7aFnxXgxJPDSZkvcOlxCvHhKqKwiW4vUPpKQY2gPdNWgNNgrBbccSFFTWzL2B6Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(36756003)(122000001)(66476007)(82960400001)(8676002)(66556008)(86362001)(31696002)(66446008)(38100700002)(64756008)(66946007)(38070700005)(91956017)(76116006)(2906002)(54906003)(110136005)(478600001)(2616005)(4326008)(316002)(41300700001)(8936002)(5660300002)(186003)(26005)(83380400001)(6486002)(71200400001)(53546011)(6506007)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?SDVhL0JEajFKL3pHa1dyYkE4Y05rd2VwWWg0bUM1NVllSlhwTTl0QXdlTVd1?=
 =?utf-8?B?b3JlaWlFelZxMndta1lucXVHdjcxWVdyZ3RyY05GWnp5VkZ0c1NJQW90SUl6?=
 =?utf-8?B?MU1rbmtoZUNJcXgvbU56eXNoYUJMMEsrRU5OdG1BRDJxL0orK2RjckE5QkVW?=
 =?utf-8?B?ZVFSK09jamVnRXAyVGdoK1ZJcDBjL1VLZjhFSG1OcFFNd2tJcHo3NFpjVVV4?=
 =?utf-8?B?QWZkdEpQcy9EblpoQmdkTlN0QWMzbjBDWk94KzM0enM2Y05KSVMrTFg4QzFI?=
 =?utf-8?B?bmNGRVZENHV3RDlCTWswb3BZZGFFYkZ4L3dEalFMZEk4ejc1T2RrQzJGZnVz?=
 =?utf-8?B?RXRLelpSQk1zOEVkWUVRRUdzTmtSWWtJdjFDK3BQNHpBVWFYWkhrS2k1SldW?=
 =?utf-8?B?bFRBdTlBT3VvbnY1U2p6Z2RFOWtBVnhROHdTRTJiTnZhQXlJZWE0eWRmSmNC?=
 =?utf-8?B?U2JBaDB6MXY3S25yNUxXd1VMWm9kazJCQ0JHclZ2MzhJaVJENXQraWJJNG11?=
 =?utf-8?B?NHdpSU5kMVFMcUQvd1hrcUM5eTdhUVRvTTNGT0tDUTVHVVhWUTFlcjk0a1p3?=
 =?utf-8?B?d2ZyMUhUZThEcEFQQWZIQjRXYjc2WXRsTGtsWkdMeEMvdWJCYVdpanNLVi9i?=
 =?utf-8?B?b2Q0VzRwRmJ5V0x6akY1NDNUd3JOeWw4RGNTYlVBOGJhTlJtOGt0b2pYY0lR?=
 =?utf-8?B?dDJxZ0ZXeVJ6RTZXK0tqckJ2YjI2VExhMXc4ZFJTb2hMVzJwZ1E5Q1RUN3FL?=
 =?utf-8?B?aFlWTTBFTDRKVXJzYldSQ0U4Y3o0Yit4L1dOb2puM0lGL0hsU2l2TjFhRjZ6?=
 =?utf-8?B?S08ybXduUHJXSTJQZXZVc1FrZGVkMWpwZ0VtaEE1OVAvbVJFbFllaC82aEZ3?=
 =?utf-8?B?N3plVDQxN3cwOXI4STNLcXhEcVpxL2VHbVl0NEFGOVpEREJCb0d3Nm9XRHJu?=
 =?utf-8?B?SURRNW56YWNUeVVzak41WTg1bnVkTlFHNU51WW1heGxsUVVib0RQc1l0N083?=
 =?utf-8?B?bjFKVFl2R0hPWGlFY016RUc0ODBnVE9keWY0N0o5LzVvMHRyNkpNZHFWclJi?=
 =?utf-8?B?UVVqbnp1ajFvM0RGNFIrZDRScW1FaGsyeVNZc2owNElLUmZFcG0xKzF1QnBh?=
 =?utf-8?B?bXlmNFlCdmRxa0hYaGtXR3RmMGI0eld1UmJyQkc4KzVGZDU5QzFBV0VoU2Qx?=
 =?utf-8?B?NG5XKzUveU5mRjVXWUlmMitzNE1GYzZqZ2lkYVo4ZnBjTUg0bFR2VjFTN29s?=
 =?utf-8?B?aE5jdU5qSHNBOHh2VFhTbko2ZVlVR1RBa0VxL24vcTgycENGQUEybXRPemdV?=
 =?utf-8?B?TzBBbXEwZU9sVk43MUJVOURaOElMaGYzRXRHVTFHRXJscnpkbE1LM1ZxYmo0?=
 =?utf-8?B?ZVdja2w3WTc2cFhiUDMwUnRBV1JFTXlIN3d5VkVsTU5TK1h6eVAxTEs2WjNv?=
 =?utf-8?B?ckVDNUxxclZPTVVKbDk3OVdRdjduNXI2Y2NEMGYwdWRxUzhxMUFLVldKT1Z0?=
 =?utf-8?B?MFJLK25TMitVaFpWRFJKNlMwc3I3cXRJcXJMekZVVHRBL2pQc0V2clVpZ2pO?=
 =?utf-8?B?WVR6bS9mYkxsL0NaVGM2ZUJwRTNIOWU3VlFQYm02RW9jdi9Bdm81cWw3VjRS?=
 =?utf-8?B?QTc5ODFyLzlESExtWitYZnc4cTdSbE9hclJTQVpLbXFYZHpBdFg5TVNjUmtz?=
 =?utf-8?B?dm5scGpIemV0Nmk1RHV5eXlwZ2oyb21VVlZsZkdpTGRzbUk3OXp5VEdyVkZW?=
 =?utf-8?B?QzJ6c0l6OUtlSmJDMmxNRy9IbnBEdTl1cUEzVUU1dUR2bzBJNlF6MDZBajND?=
 =?utf-8?B?UFltb3ZNUjhmRmt4MnFQbFZUUFdZTmJOcy9ENTVUOVpYYmt4eDRXYnRMVlpi?=
 =?utf-8?B?SjgyYWRueGpOUG1wT1NPZFJ5d0RqVWJTSUN4ZTVlcnorQVhnQkErYklVT2dn?=
 =?utf-8?B?TmEyQWJoYzBXZlpqakZ6NGVSclBnKzNKVUswNVQwTVFsdDJnWGdJQ3NrdVRZ?=
 =?utf-8?B?OHVTdUp2U3JDeG1YM254bjNBbGRxd0NGSnc1NTIxSmFXbGRZV3UweTcvN1l4?=
 =?utf-8?B?L3lJM2p3UktsZHNNRFZEOGFjNm9LZG1uc1FBWmxreGIwR1VXVU1nYmdCTENv?=
 =?utf-8?Q?tixrkhslhVKCDVrvv2wl/ATVw?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E468536F0EFDB94D94AF488B7C1B0446@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57ee49a3-10bc-47ba-94ba-08dab2193271
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 21:30:51.5952
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 36KfVs0JLuN0UucPwAPbnirbPonm4YHcaa6mxHKULHtzVgpk2lxw/rdcuyYmB7FghdqNLqUahkBvRwq4bNXyUHttbycyS6uelSRpW1QmGjg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6588

T24gMTgvMTAvMjAyMiAwMDowMSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+PiBTaWduZWQtb2Zm
LWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+Pj4+IFNpZ25lZC1vZmYtYnk6
IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+Pj4+IC0tLQ0KPj4+
PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPj4+PiBD
QzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4+Pj4gQ0M6IFZvbG9keW15ciBCYWJj
aHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4+Pj4gQ0M6IEJlcnRyYW5kIE1hcnF1
aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4+Pj4gQ0M6IEhlbnJ5IFdhbmcgPEhlbnJ5
LldhbmdAYXJtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IMKgwqAgeGVuL2FyY2gvYXJtL3AybS5jIHwg
NDMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQ0KPj4+PiDCoMKg
IDEgZmlsZSBjaGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4+Pg0K
Pj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5j
DQo+Pj4+IGluZGV4IDY4MjZmNjMxNTA4MC4uNzZhMGUzMWM2YzhjIDEwMDY0NA0KPj4+PiAtLS0g
YS94ZW4vYXJjaC9hcm0vcDJtLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3AybS5jDQo+Pj4+
IEBAIC0xNzM2LDggKzE3MzYsMzYgQEAgdm9pZCBwMm1fZmluYWxfdGVhcmRvd24oc3RydWN0IGRv
bWFpbiAqZCkNCj4+Pj4gwqDCoMKgwqDCoMKgIGlmICggIXAybS0+ZG9tYWluICkNCj4+Pj4gwqDC
oMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuOw0KPj4+PiDCoMKgIC3CoMKgwqAgQVNTRVJUKHBhZ2Vf
bGlzdF9lbXB0eSgmcDJtLT5wYWdlcykpOw0KPj4+PiAtwqDCoMKgIEFTU0VSVChwYWdlX2xpc3Rf
ZW1wdHkoJmQtPmFyY2gucGFnaW5nLnAybV9mcmVlbGlzdCkpOw0KPj4+PiArwqDCoMKgIC8qDQo+
Pj4+ICvCoMKgwqDCoCAqIE9uIHRoZSBkb21haW5fY3JlYXRlKCkgZXJyb3IgcGF0aCBvbmx5LCB3
ZSBjYW4gZW5kIHVwIGhlcmUNCj4+Pj4gd2l0aCBhDQo+Pj4+ICvCoMKgwqDCoCAqIG5vbi16ZXJv
IFAyTSBwb29sLg0KPj4+PiArwqDCoMKgwqAgKg0KPj4+PiArwqDCoMKgwqAgKiBBdCBwcmVzZW50
LCB0aGlzIGlzIGEgbWF4aW11bSBvZiAxNiBwYWdlcywgc3ByZWFkIGJldHdlZW4NCj4+Pj4gcDJt
LT5wYWdlcw0KPj4+PiArwqDCoMKgwqAgKiBhbmQgdGhlIGZyZWUgbGlzdC7CoCBUaGUgZG9tYWlu
IGhhcyBuZXZlciBiZWVuIHNjaGVkdWxlZCAoaXQNCj4+Pj4gaGFzIG5vDQo+Pj4+ICvCoMKgwqDC
oCAqIHZjcHVzKSwgc28gdGhlcmUgaXMgVExCIG1haW50ZW5hbmNlIHRvIHBlcmZvcm07IGp1c3Qg
ZnJlZQ0KPj4+PiBldmVyeXRoaW5nLg0KPj4+PiArwqDCoMKgwqAgKi8NCj4+Pj4gK8KgwqDCoCBp
ZiAoICFwYWdlX2xpc3RfZW1wdHkoJnAybS0+cGFnZXMpIHx8DQo+Pj4+ICvCoMKgwqDCoMKgwqDC
oMKgICFwYWdlX2xpc3RfZW1wdHkoJmQtPmFyY2gucGFnaW5nLnAybV9mcmVlbGlzdCkgKQ0KPj4+
PiArwqDCoMKgIHsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHN0cnVjdCBwYWdlX2luZm8gKnBnOw0K
Pj4+PiArDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCAvKg0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoCAq
IFRoZXJlJ3Mgbm8gc2Vuc2libGUgImluIHRoZSBkb21haW5fY3JlYXRlKCkgZXJyb3IgcGF0aCIN
Cj4+Pj4gcHJlZGljYXRlLA0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIHNvIHNpbXBseSBzYW5p
dHkgY2hlY2sgdGhhdCB3ZSBkb24ndCBoYXZlIHVuZXhwZWN0ZWQgd29yaw0KPj4+PiB0byBkby4N
Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqAgKi8NCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIEFTU0VSVChk
LT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPD0gMTYpOw0KPj4+PiArDQo+Pj4+ICvCoMKg
wqDCoMKgwqDCoCBzcGluX2xvY2soJmQtPmFyY2gucGFnaW5nLmxvY2spOw0KPj4+PiArDQo+Pj4+
ICvCoMKgwqDCoMKgwqDCoCB3aGlsZSAoIChwZyA9IHBhZ2VfbGlzdF9yZW1vdmVfaGVhZCgmcDJt
LT5wYWdlcykpICkNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZnJlZV9kb21oZWFwX3Bh
Z2UocGcpOw0KPj4+PiArwqDCoMKgwqDCoMKgwqAgd2hpbGUgKCAocGcgPQ0KPj4+PiBwYWdlX2xp
c3RfcmVtb3ZlX2hlYWQoJmQtPmFyY2gucGFnaW5nLnAybV9mcmVlbGlzdCkpICkNCj4+Pj4gK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgZnJlZV9kb21oZWFwX3BhZ2UocGcpOw0KPj4+PiArDQo+Pj4+
ICvCoMKgwqDCoMKgwqDCoCBkLT5hcmNoLnBhZ2luZy5wMm1fdG90YWxfcGFnZXMgPSAwOw0KPj4+
PiArDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBzcGluX3VubG9jaygmZC0+YXJjaC5wYWdpbmcubG9j
ayk7DQo+Pj4+ICvCoMKgwqAgfQ0KPj4+DQo+Pj4gLi4uIHlvdSBhcmUgaGFyZGNvZGluZyBib3Ro
IHAybV90ZWFyZG93bigpIGFuZCBwMm1fc2V0X2FsbG9jYXRpb24oKS4NCj4+PiBJTU8gdGhpcyBp
cyBub3QgYW4gaW1wcm92ZW1lbnQgYXQgYWxsLiBJdCBpcyBqdXN0IG1ha2luZyB0aGUgY29kZSBt
b3JlDQo+Pj4gY29tcGxleCB0aGFuIG5lY2Vzc2FyeSBhbmQgbGFjayBhbGwgdGhlIGV4cGxhbmF0
aW9uIG9uIHRoZSBhc3N1bXB0aW9ucy4NCj4+Pg0KPj4+IFNvIHdoaWxlIEkgYW0gZmluZSB3aXRo
IHlvdXIgcGF0Y2ggIzEgKGFscmVhZHkgcmV2aWV3ZWQgaXQpLCB0aGVyZSBpcw0KPj4+IGEgYmV0
dGVyIHBhdGNoIGZyb20gSGVucnkgb24gdGhlIE1MLiBTbyB3ZSBzaG91bGQgdGFrZSBoaXMgKHJl
YmFzZWQpDQo+Pj4gaW5zdGVhZCBvZiB5b3Vycy4NCj4+DQo+PiBJZiBieSBiZXR0ZXIsIHlvdSBt
ZWFuIHNvbWV0aGluZyB0aGF0IHN0aWxsIGhhcyBlcnJvcnMsIHRoZW4gc3VyZS4NCj4+DQo+PiBU
aGVyZSdzIGEgcmVhbGx5IGdvb2QgcmVhc29uIHdoeSB5b3UgY2Fubm90IHNhZmVseSByZXB1cnBv
c2UNCj4+IHAybV90ZWFyZG93bigpLsKgIEl0J3Mgd3JpdHRlbiBleHBlY3RpbmcgYSBmdWxseSBj
b25zdHJ1Y3RlZCBkb21haW4gLQ0KPj4gd2hpY2ggaXMgZmluZSBiZWNhdXNlIHRoYXQncyBob3cg
aXQgaXMgdXNlZC7CoCBJdCBkb2Vzbid0IGNvcGUgc2FmZWx5DQo+PiB3aXRoIGFuIHBhcnRpYWxs
eSBjb25zdHJ1Y3RlZCBkb21haW4uDQo+DQo+IEl0IGlzIG5vdCAxMDAlIGNsZWFyIHdoYXQgaXMg
dGhlIGlzc3VlIHlvdSBhcmUgcmVmZXJyaW5nIHRvIGFzIHRoZQ0KPiBWTUlEIGlzIHZhbGlkIGF0
IHRoaXMgcG9pbnQuIFNvIHdoYXQgcGFydCB3b3VsZCBiZSB3cm9uZz8NCg0KRmFsbGluZyBvdmVy
IGEgYmFkIHJvb3QgcG9pbnRlciBmcm9tIGFuIGVhcmx5IGNvbnN0cnVjdGlvbiBleGl0Lg0KDQo+
IEJ1dCBpZiB0aGVyZSBhcmUgcGFydCBvZiBwMm1fdGVhcmRvd24oKSB0aGF0IGFyZSBub3Qgc2Fm
ZSBmb3INCj4gcGFydGlhbGx5IGNvbnN0cnVjdGVkIGRvbWFpbiwgdGhlbiB3ZSBzaG91bGQgc3Bs
aXQgdGhlIGNvZGUuIFRoaXMNCj4gd291bGQgYmUgbXVjaCBiZXR0ZXIgdGhhdCB0aGUgZHVwbGlj
YXRpb24geW91IGFyZSBwcm9wb3NpbmcuDQoNCllvdSBoYXZlIHR3byB0b3RhbGx5IGRpZmZlcmVu
dCBjb250ZXh0cyB3aXRoIGRpZmZlcmVudCBzYWZldHkNCnJlcXVpcmVtZW50cy7CoCBjL3MgNTU5
MTRmN2ZjOSBpcyBhIHJlYXNvbmFibHkgZ29vZCBhbmQgY2xlYW4gc2VwYXJhdGlvbg0KYmV0d2Vl
biBwcmVlbXB0aWJsZSBhbmQgbm9uLXByZWVtcHRpYmxlIGNsZWFudXBbMV0uDQoNCllvdSd2ZSBh
Z3JlZWQgdGhhdCB0aGUgaW50cm9kdWN0aW9uIG9mIHRoZSBub24tcHJlZW1wdGlibGUgcGF0aCB0
byB0aGUNCnByZWVtcHRpYmxlIHBhdGggaXMgYSBoYWNrIGFuZCBsYXllcmluZyB2aW9sYXRpb24s
IGFuZCB3aWxsIG5lZWQgdW5kb2luZw0KbGF0ZXIuwqAgT3RoZXJzIGhhdmUgcmFpc2VkIHRoaXMg
Y29uY2VybiB0b28uDQoNCk5vdyBjb25zaWRlciB0aGF0IHdlJ3JlIHRha2luZyB0aGUgZXJyb3Ig
cGF0aCB3aXRob3V0IGFuY2lsbGFyeQ0KY29sbGF0ZXJhbCBkYW1hZ2UuwqAgSXQ6DQoxKSBaZXJv
cyBhbGwgdGhlIHJvb3QgZnJhbWVzDQoyKSBTd2l0Y2hlcyB0byBhIHJlbW90ZSBWTUlEIGluIG9y
ZGVyIHRvIGZsdXNoIHRoZSBUTEJzLCBub3QgdGhhdCB0aGV5DQpuZWVkIGZsdXNoaW5nIGluIHRo
ZSBmaXJzdCBwbGFjZQ0KMykgRm9yIGFsbG9jYXRlZCBQMk0gcGFnZXMsIG1vdmVzIHRoZW0gb25l
IGF0IGEgdGltZSBvbnRvIHRoZSBmcmVlIGxpc3QsDQp0YWtpbmcgdGhlIHBhZ2luZyBsb2NrIGZv
ciBlYWNoIGZyYW1lDQo0KSAod3JhcHBpbmcgdGhlIHByZWVtcHRpYmxlIGhlbHBlciB3aXRoIGFu
IGlnbm9yZSBsb29wKSBmaW5hbGx5IGZyZWUNCnRoZSBjb21wbGV0ZSBwb29sLg0KDQouLi4gaW4g
YSBjYXNlIHdoZXJlIDE2IGlzIHRoZSBjaG9zZW4gdmFsdWUgYmVjYXVzZSB5b3UncmUgYWxyZWFk
eQ0KY29uY2VybmVkIGFib3V0IHRoZSBoeXBlcmNhbGwgdGFraW5nIHRvbyBsb25nLg0KDQpJcyB0
aGF0IHNhZmU/IFBvc3NpYmx5LsKgIElzIGl0IHdpc2U/wqAgbm8uDQoNCllvdSBjYW4ndCB0ZXN0
IHRoZSBlcnJvciBwYXRoIGluIHF1ZXN0aW9uIGhlcmUgKGJlY2F1c2UgbXkgZmF1bHRfdHRsDQpw
YXRjaGVzIGFyZSBzdGlsbCBwZW5kaW5nKS7CoCAiQ29ycmVjdG5lc3MiIGlzIGFsbW9zdCBleGNs
dXNpdmVseSBieSBjb2RlDQppbnNwZWN0aW9uLg0KDQpBbHNvIHJlYWxpc2UgdGhhdCB5b3UndmUg
bm93IHNwbGl0IHRoZSBoZWxwZXIgYmV0d2VlbiByZWd1bGFyIGh5cGVyY2FsbA0KY29udGV4dCwg
YW5kIFJDVSBjb250ZXh0LCBhbmQgcmVjYWxsIHdoYXQgaGFwcGVuZWQgd2hlbiB3ZSBmaW5hbGx5
DQpzdGFydGVkIGFzc2VydGluZyB0aGF0IG1lbW9yeSBjb3VsZG4ndCBiZSBhbGxvY2F0ZWQgaW4g
c3RvcC1tYWNoaW5lIGNvbnRleHQuDQoNCkhvdyBjZXJ0YWluIGFyZSB5b3UgdGhhdCB0aGUgc2Fm
ZXR5IGlzIHRoZSBzYW1lIG9uIGVhcmxpZXIgdmVyc2lvbnMgb2YNClhlbj/CoCBXaGF0IGlzIHRo
ZSBsaWtlbGlob29kIHRoYXQgYWxsIG9mIHRoZXNlIGFjdGlvbnMgd2lsbCByZW1haW4gc2FmZQ0K
Z2l2ZW4gZnV0dXJlIGRldmVsb3BtZW50Pw0KDQoNCkRlc3BpdGUgd2hhdCBpcyBiZWluZyBjbGFp
bWVkLCB0aGUgYXR0ZW1wdCB0byBzaGFyZSBjbGVhbnVwIGxvZ2ljIGlzDQppbnRyb2R1Y2luZyBm
cmFnaWxpdHkgYW5kIHJpc2ssIG5vdCByZW1vdmluZyBpdC7CoCBUaGlzIGlzIGEgYnVnZml4IGZv
cg0KdG8gYSBzZWN1cml0eSBmaXggaXNzdWUgd2hpY2ggaXMgdG90YWxseSBkZWFkIG9uIGFycml2
YWw7IG5ldCBzYWZldHksDQplc3BlY2lhbGx5IGluIG9sZGVyIHZlcnNpb25zIG9mIHRoZSBYZW4s
IGlzICp0aGUgaGlnaGVzdCBwcmlvcml0eSouDQoNClRoZXNlIHR3byBkaWZmZXJlbnQgY29udGV4
dHMgZG9uJ3Qgc2hhcmUgYW55IGNvbW1vbiBwcm9wZXJ0aWVzIG9mIGhvdyB0bw0KY2xlYW4gdXAg
dGhlIHBvb2wsIHNhdmUgZnJlZWluZyB0aGUgZnJhbWVzIGJhY2sgdG8gdGhlIG1lbW9yeQ0KYWxs
b2NhdG9yLsKgIEluIGEgcHJvcGVyIGRlc2lnbiwgdGhpcyBpcyB0aGUgaGludCB0aGF0IHRoZXkg
c2hvdWxkbid0DQpzaGFyZSBsb2dpYyBlaXRoZXIuDQoNCg0KR2l2ZW4gdGhhdCB5b3UgZG8gZXhw
ZWN0IHNvbWVvbmUgdG8gc3BlbmQgeWV0LW1vcmUgdGltZSZlZmZvcnQgdG8gdW5kbw0KdGhlIHNo
b3J0IHRlcm0gaGFjayBjdXJyZW50bHkgYmVpbmcgcHJvcG9zZWQsIGhvdyBkbyB5b3UgZW52aXNh
Z2UgdGhlDQplbmQgcmVzdWx0IGxvb2tpbmc/DQoNCn5BbmRyZXcNCg0KWzFdIEFsdGhvdWdoIHRo
ZSBvcmRlciBvZiBhY3Rpb25zIGluIHAybV90ZWFyZG93bigpIGZvciB0aGUgY29tbW9uIGNhc2UN
CmlzIHBvb3IuwqAgVGhlIHJvb3QgcGFnZXRhYmxlcyBzaG91bGQgYmUgY2xlYW5lZCBhbmQgZnJl
ZWQgZmlyc3Qgc28gc3RlcHMNCjEgYW5kIDIgb2YgdGhlIGxpc3QgYWJvdmUgYXJlIG5vdCByZXBl
YXRlZCBmb3IgZXZlcnkgY29udGludWF0aW9uLg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 22:11:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 22:11:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426044.674241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olHHY-0008BO-MZ; Wed, 19 Oct 2022 22:11:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426044.674241; Wed, 19 Oct 2022 22:11:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olHHY-0008BH-Jt; Wed, 19 Oct 2022 22:11:24 +0000
Received: by outflank-mailman (input) for mailman id 426044;
 Wed, 19 Oct 2022 22:11:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olHHX-0008BB-GA
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 22:11:23 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6c406ca-4ffa-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 00:11:22 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4BF46B8221F;
 Wed, 19 Oct 2022 22:11:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25F9AC433D6;
 Wed, 19 Oct 2022 22:11:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6c406ca-4ffa-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666217480;
	bh=m9ZDOWxnSvLqhYxK6ftul5+hyjpWwYrIqdhvnPZ0VOU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=MkFcY59wWYp197xpVKIppfTfiyH8b5+nJReNTxozhJv6dmeMDEJdaNwfJw2poseBU
	 dMx5wmTRkSn48pj3PViBr2IkOaKLIL15EA9A7pysIiWLGRbWv5NYBG9Z8A5TTjsKMe
	 z2uWwcwsd/0QMFvzo2Hg/Tl9sOmR9M+YgKIu80uNThL4fXGe9ycASNPz1H3ILuBnUo
	 cAsWOuBRPOMbOiD65YBIKz7TLRh9d8ttJB6F3AMtEqYbcwIqmOrScJOmGj4R739PTi
	 NKRPkBVw7InCX8adKJDEFsRTIdJkb7nIMfWM2nqC5Stz565cgJI5MK3DTkJ5Q9eNRN
	 TxXegYncyxGeg==
Date: Wed, 19 Oct 2022 15:11:17 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Michal Orzel <michal.orzel@amd.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
In-Reply-To: <0070D1D1-F579-4E11-8A27-62D3D92DE896@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210191510380.3873@ubuntu-linux-20-04-desktop>
References: <cover.1665561024.git.bertrand.marquis@arm.com> <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop> <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com> <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop> <56155bff-6229-05a4-7221-cd6aa5a1de8b@amd.com> <0070D1D1-F579-4E11-8A27-62D3D92DE896@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 19 Oct 2022, Bertrand Marquis wrote:
> Hi Michal,
> 
> > On 19 Oct 2022, at 10:06, Michal Orzel <michal.orzel@amd.com> wrote:
> > 
> > Hi Stefano,
> > 
> > On 19/10/2022 02:02, Stefano Stabellini wrote:
> >> 
> >> 
> >> On Mon, 17 Oct 2022, Stefano Stabellini wrote:
> >>> It should be
> >>> 
> >>> BB_NUMBER_THREADS="2"
> >>> 
> >>> but that worked! Let me a couple of more tests.
> >> 
> >> I could run successfully a Yocto build test with qemuarm64 as target in
> >> gitlab-ci, hurray! No size issues, no build time issues, everything was
> >> fine. See:
> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193051236&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C75ea919bbde249e1bac408dab1654960%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017345841386870%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=oWrGVbloqkJoOxvvxTr55RbKVzd3YmS4iiLPyxDZCYY%3D&amp;reserved=0
> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193083119&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C75ea919bbde249e1bac408dab1654960%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017345841386870%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=%2BXf3ZB1bsVi8K%2BzEEe1Dhpg0GSohpseogff12GaK3Gw%3D&amp;reserved=0
> >> 
> >> I made the appended changes in top of this series.
> >> 
> >> - I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
> >>  registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64
> >> - for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
> >>  xen.git, not from a copy stored inside a container
> >> - when building the kirkstone-qemuarm64 container the first time
> >>  (outside of gitlab-ci) I used COPY and took the script from the local
> >>  xen.git tree
> >> - after a number of tests, I settled on: BB_NUMBER_THREADS="8" more than
> >>  this and it breaks on some workstations, please add it
> >> - I am running the yocto build on arm64 so that we can use the arm64
> >>  hardware to do it in gitlab-ci
> >> 
> >> Please feel free to incorporate these changes in your series, and add
> >> corresponding changes for the qemuarm32 and qemux86 targets.
> >> 
> >> I am looking forward to it! Almost there!
> >> 
> >> Cheers,
> >> 
> >> Stefano
> >> 
> >> 
> >> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
> >> index 0d31dad607..16f1dcc0a5 100755
> >> --- a/automation/build/yocto/build-yocto.sh
> >> +++ b/automation/build/yocto/build-yocto.sh
> >> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
> >> # Save some disk space
> >> INHERIT += "rm_work"
> >> 
> >> +# Reduce number of jobs
> >> +BB_NUMBER_THREADS="8"
> >> +
> >> EOF
> >> 
> >>     if [ "${do_localsrc}" = "y" ]; then
> >> diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> >> index f279a7af92..aea3fc1f3e 100644
> >> --- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> >> +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> >> @@ -16,7 +16,8 @@ ARG target=qemuarm64
> >> 
> >> # This step can take one to several hours depending on your download bandwith
> >> # and the speed of your computer
> >> -RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
> >> +COPY ./build-yocto.sh /
> >> +RUN /build-yocto.sh --dump-log $target
> >> 
> >> FROM $from_image
> >> 
> >> diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
> >> index 367a7863b6..ffbd91aa90 100644
> >> --- a/automation/build/yocto/kirkstone.dockerfile
> >> +++ b/automation/build/yocto/kirkstone.dockerfile
> >> @@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
> >>              /home/$USER_NAME/xen && \
> >>     chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
> >> 
> >> -# Copy the build script
> >> -COPY build-yocto.sh /home/$USER_NAME/bin/
> >> -
> >> # clone yocto repositories we need
> >> ARG yocto_version="kirkstone"
> >> RUN for rep in \
> >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> >> index ddc2234faf..4b8bcde252 100644
> >> --- a/automation/gitlab-ci/build.yaml
> >> +++ b/automation/gitlab-ci/build.yaml
> >> @@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
> >>     EXTRA_XEN_CONFIG: |
> >>       CONFIG_BOOT_TIME_CPUPOOLS=y
> >> 
> >> +yocto-kirkstone-qemuarm64:
> >> +  stage: build
> >> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> >> +  script:
> >> +    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
> >> +  variables:
> >> +    CONTAINER: yocto:kirkstone-qemuarm64
> >> +  artifacts:
> >> +    paths:
> >> +      - '*.log'
> >> +      - '*/*.log'
> > The above lines are not needed as the logs/* below will handle them all (logs are only stored in logs/).
> 
> Ack
> 
> > 
> >> +      - 'logs/*'
> >> +    when: always
> >> +  tags:
> >> +    - arm64
> >> +
> > build-yocto.sh performs both build and run actions. I think it'd be better to move this into test.yaml in that case.
> > The best would be to create one build job (specifying --no-run) in build.yaml and one test job (specifying --no-build) in test.yaml.
> > This however would probably require marking path build/tmp/deploy/***/qemuarm64 as an build artifact. The question then is
> > whether having this path would be enough for runqemu (Bertrand's opinion needed).
> 
> This will not be enough to run qemu as the qemu binary and its dependencies are in the build artifacts and not in deploy.
> Splitting the build and run is not a good idea because the size of the artifact between the 2 will be huge.

Although not ideal, I think it is fine to have a single job that does
both the build and the run.


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 22:12:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 22:12:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426049.674251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olHIM-0000HA-Ul; Wed, 19 Oct 2022 22:12:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426049.674251; Wed, 19 Oct 2022 22:12:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olHIM-0000H3-Rq; Wed, 19 Oct 2022 22:12:14 +0000
Received: by outflank-mailman (input) for mailman id 426049;
 Wed, 19 Oct 2022 22:12:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PkOC=2U=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olHIK-0000EC-Sr
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 22:12:13 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1443f764-4ffb-11ed-91b4-6bf2151ebd3b;
 Thu, 20 Oct 2022 00:12:11 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D4817B825C4;
 Wed, 19 Oct 2022 22:12:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7180C433C1;
 Wed, 19 Oct 2022 22:12:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1443f764-4ffb-11ed-91b4-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666217529;
	bh=GiCDD+yazSW/EflQT8JGbHTRXOwFuJcsOdaLcFeOPmM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=VmlNlQoTNDZLygd+1D0FU55cQoJoIt8t0u8l+ytM/VK3n/m7n6Mcmb5H/wSMWuJ+F
	 l8nIItmRcnCahf1dcJPNhAA1RZG3X5B8QyHG9Ezlg3+QRFAQaUndKhZaoXUxv201Ez
	 qBQ7CzZxFMUYZMK9wVcQu20W4DgjFB9ogcnYaoLcu1GM8tRCWy9AG10NdA2qUcSHdB
	 OiUCvDgcgOL1OPBhIsZsGaIGMO1LES/jDhos6+NwhiH4LvgswikakqV71fwwQi+mIN
	 Jr2lQKyW1pvMQlwzP6EAAJqOjWNU18KR4ucwhZN4fBY/1QfhZjecNbBjhF3VmVucVc
	 YUCXN6q9ff+kQ==
Date: Wed, 19 Oct 2022 15:12:07 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v2 0/3] Yocto Gitlab CI
In-Reply-To: <a1d2ab41-0d30-5d34-5a42-fb74b68d30f4@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210191511260.3873@ubuntu-linux-20-04-desktop>
References: <cover.1665561024.git.bertrand.marquis@arm.com> <alpine.DEB.2.22.394.2210141325240.3690179@ubuntu-linux-20-04-desktop> <7DE7B34C-F6BD-42D9-83A3-AAA3A6A35B62@arm.com> <alpine.DEB.2.22.394.2210171651250.4587@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2210181654170.4587@ubuntu-linux-20-04-desktop> <56155bff-6229-05a4-7221-cd6aa5a1de8b@amd.com> <0070D1D1-F579-4E11-8A27-62D3D92DE896@arm.com> <a1d2ab41-0d30-5d34-5a42-fb74b68d30f4@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 19 Oct 2022, Michal Orzel wrote:
> Hi Bertrand,
> 
> On 19/10/2022 12:40, Bertrand Marquis wrote:
> > 
> > 
> > Hi Michal,
> > 
> >> On 19 Oct 2022, at 10:06, Michal Orzel <michal.orzel@amd.com> wrote:
> >>
> >> Hi Stefano,
> >>
> >> On 19/10/2022 02:02, Stefano Stabellini wrote:
> >>>
> >>>
> >>> On Mon, 17 Oct 2022, Stefano Stabellini wrote:
> >>>> It should be
> >>>>
> >>>> BB_NUMBER_THREADS="2"
> >>>>
> >>>> but that worked! Let me a couple of more tests.
> >>>
> >>> I could run successfully a Yocto build test with qemuarm64 as target in
> >>> gitlab-ci, hurray! No size issues, no build time issues, everything was
> >>> fine. See:
> >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193051236&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C5f7fc3a161fe44b5954808dab1be5c3a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017728406088513%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=2mb3N26wiz39RJNSA4KoIOt%2BG9X7EMDOWIpfKc2ZZOc%3D&amp;reserved=0
> >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Fjobs%2F3193083119&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C5f7fc3a161fe44b5954808dab1be5c3a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638017728406088513%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=QhTFefS8NU1f7oLemB0Vtn%2BDCD%2BCnq1v1gEmlKCJt84%3D&amp;reserved=0
> >>>
> >>> I made the appended changes in top of this series.
> >>>
> >>> - I pushed registry.gitlab.com/xen-project/xen/yocto:kirkstone and
> >>>  registry.gitlab.com/xen-project/xen/yocto:kirkstone-qemuarm64
> >>> - for the gitlab-ci runs, we need to run build-yocto.sh from the copy in
> >>>  xen.git, not from a copy stored inside a container
> >>> - when building the kirkstone-qemuarm64 container the first time
> >>>  (outside of gitlab-ci) I used COPY and took the script from the local
> >>>  xen.git tree
> >>> - after a number of tests, I settled on: BB_NUMBER_THREADS="8" more than
> >>>  this and it breaks on some workstations, please add it
> >>> - I am running the yocto build on arm64 so that we can use the arm64
> >>>  hardware to do it in gitlab-ci
> >>>
> >>> Please feel free to incorporate these changes in your series, and add
> >>> corresponding changes for the qemuarm32 and qemux86 targets.
> >>>
> >>> I am looking forward to it! Almost there!
> >>>
> >>> Cheers,
> >>>
> >>> Stefano
> >>>
> >>>
> >>> diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
> >>> index 0d31dad607..16f1dcc0a5 100755
> >>> --- a/automation/build/yocto/build-yocto.sh
> >>> +++ b/automation/build/yocto/build-yocto.sh
> >>> @@ -107,6 +107,9 @@ IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
> >>> # Save some disk space
> >>> INHERIT += "rm_work"
> >>>
> >>> +# Reduce number of jobs
> >>> +BB_NUMBER_THREADS="8"
> >>> +
> >>> EOF
> >>>
> >>>     if [ "${do_localsrc}" = "y" ]; then
> >>> diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> >>> index f279a7af92..aea3fc1f3e 100644
> >>> --- a/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> >>> +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
> >>> @@ -16,7 +16,8 @@ ARG target=qemuarm64
> >>>
> >>> # This step can take one to several hours depending on your download bandwith
> >>> # and the speed of your computer
> >>> -RUN /home/$USER_NAME/bin/build-yocto.sh --dump-log $target
> >>> +COPY ./build-yocto.sh /
> >>> +RUN /build-yocto.sh --dump-log $target
> >>>
> >>> FROM $from_image
> >>>
> >>> diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
> >>> index 367a7863b6..ffbd91aa90 100644
> >>> --- a/automation/build/yocto/kirkstone.dockerfile
> >>> +++ b/automation/build/yocto/kirkstone.dockerfile
> >>> @@ -84,9 +84,6 @@ RUN mkdir -p /home/$USER_NAME/yocto-layers \
> >>>              /home/$USER_NAME/xen && \
> >>>     chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
> >>>
> >>> -# Copy the build script
> >>> -COPY build-yocto.sh /home/$USER_NAME/bin/
> >>> -
> >>> # clone yocto repositories we need
> >>> ARG yocto_version="kirkstone"
> >>> RUN for rep in \
> >>> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> >>> index ddc2234faf..4b8bcde252 100644
> >>> --- a/automation/gitlab-ci/build.yaml
> >>> +++ b/automation/gitlab-ci/build.yaml
> >>> @@ -584,6 +584,22 @@ alpine-3.12-gcc-arm64-boot-cpupools:
> >>>     EXTRA_XEN_CONFIG: |
> >>>       CONFIG_BOOT_TIME_CPUPOOLS=y
> >>>
> >>> +yocto-kirkstone-qemuarm64:
> >>> +  stage: build
> >>> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> >>> +  script:
> >>> +    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
> >>> +  variables:
> >>> +    CONTAINER: yocto:kirkstone-qemuarm64
> >>> +  artifacts:
> >>> +    paths:
> >>> +      - '*.log'
> >>> +      - '*/*.log'
> >> The above lines are not needed as the logs/* below will handle them all (logs are only stored in logs/).
> > 
> > Ack
> > 
> >>
> >>> +      - 'logs/*'
> >>> +    when: always
> >>> +  tags:
> >>> +    - arm64
> >>> +
> >> build-yocto.sh performs both build and run actions. I think it'd be better to move this into test.yaml in that case.
> >> The best would be to create one build job (specifying --no-run) in build.yaml and one test job (specifying --no-build) in test.yaml.
> >> This however would probably require marking path build/tmp/deploy/***/qemuarm64 as an build artifact. The question then is
> >> whether having this path would be enough for runqemu (Bertrand's opinion needed).
> > 
> > This will not be enough to run qemu as the qemu binary and its dependencies are in the build artifacts and not in deploy.
> > Splitting the build and run is not a good idea because the size of the artifact between the 2 will be huge.
> > 
> >>
> >> Apart from that there is an aspect of Yocto releases and the containers/tests names.
> >> Yocto needs to be up-to-date in order to properly build Xen+tools.
> >> This basically means that we will need to update the containers once
> >> per Yocto release. The old containers would still need to be stored in our CI container registry
> >> so that we can use CI for older versions of Xen. However, updating the containers would also require
> >> modifying the existing tests (for now we have e.g. yocto-kirkstone-qemuarm64 but in a month we will have
> >> to change them to yocto-langdale-qemuarm64). In a few years time this will result in several CI jobs
> >> that are the same but differ only in name/container. I would thus suggest to name the CI jobs like this:
> >> yocto-qemuarm64 (without yocto release name) and define the top-level YOCTO_CONTAINER variable to store
> >> the current yocto release container. This will solve the issue I described above.
> > 
> > I think we have no other way around this and we will need to have one Yocto release supported by Xen officially so
> > we will have to keep old docker images for old releases of Xen and move to newer versions of Yocto in staging when
> > it is needed.
> > 
> > We have to find a way for gitlab-ci to use the build.yaml contained inside the tree that is to be tested somehow so that gitlab would automatically take the right one.
> > Which means that build.yaml will be different between branches and contain the right version for the current branch.
> > 
> 
> What I suggest is that with each new yocto release, we add new docker container files and push them to registry.
> So we will end up in a registry having e.g. (arm64 as an example):
> - kirkstone-qemuarm64
> - langdale-qemuarm64
> We maintain only the one group of CI jobs whose names are generic (yocto-qemuarm64).
> After adding new containers for a new Yocto release, we modify the YOCTO_RELEASE variable
> to point to the latest yocto release containers.
> 
> test.yaml:
> ...
> # Yocto test jobs
> variables:
>   YOCTO_RELEASE: "kirkstone"
> 
> yocto-qemuarm64:
>   extends: .test-jobs-common
>   script:
>     - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` qemuarm64
>   variables:
>     CONTAINER: yocto:${YOCTO_RELEASE}-qemuarm64
>   artifacts:
>     paths:
>       - 'logs/*'
>     when: always
>   tags:
>     - arm64
> 
> This means that:
> - on the current staging branch the YOCTO_RELEASE points to the latest containers (for the latest yocto release)
> - on the old stable branches the YOCTO_RELEASE points to the old containers (for the old yocto release).
 
I think that's a good idea


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 22:33:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 22:33:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426056.674263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olHcY-0002nd-Ld; Wed, 19 Oct 2022 22:33:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426056.674263; Wed, 19 Oct 2022 22:33:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olHcY-0002nW-Ih; Wed, 19 Oct 2022 22:33:06 +0000
Received: by outflank-mailman (input) for mailman id 426056;
 Wed, 19 Oct 2022 22:33:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olHcY-0002nN-1o
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 22:33:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olHcX-0006gL-H4; Wed, 19 Oct 2022 22:33:05 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.85.39.71])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olHcX-0005GN-76; Wed, 19 Oct 2022 22:33:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+qkh3NNEHHOFAhi9bBrRrQ3He8Cc/WI9wSQ4QXa58yw=; b=hjByN9Qn47BWDkoVQmrV7v29Z5
	pdMHmYihEHeQYTwTYmMarErnEKXPlKKEQLJB5p6vjRCeLHNVDBjnZHf5P4xrBYPfJMQbUX5iT4a8J
	ur/pi3kGQxnpZcM3h8u+Q35lN+4+RmLgPnGMW332mJnjoRYT6hnXLRekiyvddjK5M1FU=;
Message-ID: <f200534c-c001-3ec0-7e05-cdbb76f456e3@xen.org>
Date: Wed, 19 Oct 2022 23:33:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
 <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
 <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
 <5587f5bd-1694-a843-9e80-ad477527a576@xen.org>
 <dffdc951-91fd-2659-ec7f-5c213138d785@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <dffdc951-91fd-2659-ec7f-5c213138d785@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 19/10/2022 22:30, Andrew Cooper wrote:
> On 18/10/2022 00:01, Julien Grall wrote:
>>>> ... you are hardcoding both p2m_teardown() and p2m_set_allocation().
>>>> IMO this is not an improvement at all. It is just making the code more
>>>> complex than necessary and lack all the explanation on the assumptions.
>>>>
>>>> So while I am fine with your patch #1 (already reviewed it), there is
>>>> a better patch from Henry on the ML. So we should take his (rebased)
>>>> instead of yours.
>>>
>>> If by better, you mean something that still has errors, then sure.
>>>
>>> There's a really good reason why you cannot safely repurpose
>>> p2m_teardown().  It's written expecting a fully constructed domain -
>>> which is fine because that's how it is used.  It doesn't cope safely
>>> with an partially constructed domain.
>>
>> It is not 100% clear what is the issue you are referring to as the
>> VMID is valid at this point. So what part would be wrong?
> 
> Falling over a bad root pointer from an early construction exit.

You have been mentioning that several time now but I can't see how this
can happen. If you look at Henry's second patch, p2m_teardown() starts
with the following check:
if ( page_list_empty(&p2m->pages) )
    return;

Per the logic in p2m_init(), the root pages have to be allocated (note 
they are *not* allocated from the P2M pool) and the VMID as well before 
any pages could be added in the list.

> 
>> But if there are part of p2m_teardown() that are not safe for
>> partially constructed domain, then we should split the code. This
>> would be much better that the duplication you are proposing.
> 
> You have two totally different contexts with different safety
> requirements.  c/s 55914f7fc9 is a reasonably good and clean separation
> between preemptible and non-preemptible cleanup[1].

The part you mention in [1] was decided to be delayed post 4.17 for 
development cycle reasons.

> 
> You've agreed that the introduction of the non-preemptible path to the
> preemptible path is a hack and layering violation, and will need undoing
> later.  Others have raised this concern too.

[...]

> 
> Also realise that you've now split the helper between regular hypercall
> context, and RCU context, and recall what happened when we finally
> started asserting that memory couldn't be allocated in stop-machine context.
> 
> How certain are you that the safety is the same on earlier versions of
> Xen?
I am pretty confident because the P2M code has not changed a lot.

> What is the likelihood that all of these actions will remain safe
> given future development?
Code always evolve and neither you (nor I) can claim that any work will 
stay safe forever. In your patch proposal, then the risk is a bug could 
be duplicated.

> 
> 
> Despite what is being claimed, the attempt to share cleanup logic is
> introducing fragility and risk, not removing it.

I find interesting you are saying that... If we were going to move 
p2m_teardown() in domain_teardown() then we would end up to share the code.

To me, this is not very different here because in one context it would 
be preemptible while the other it won't. At which point...

>  This is a bugfix for
> to a security fix issue which is totally dead on arrival; net safety,
> especially in older versions of the Xen, is *the highest priority*.
> 
> These two different contexts don't share any common properties of how to
> clean up the pool, save freeing the frames back to the memory
> allocator.  In a proper design, this is the hint that they shouldn't
> share logic either
... why is your design better than what Henry's proposed?

> 
> Given that you do expect someone to spend yet-more time&effort to undo
> the short term hack currently being proposed, how do you envisage the
> end result looking?

The end result will be p2m_teardown() & co to be called from 
domain_teardown().

Anyway, this discussion doesn't make us closer to come to an agreement 
on the correct approach. We have both very diverging opinion and so far 
I haven't seen any strong reasons that is showing yours is better.

So unless Bertrand or Stefano agree with you, then I will go ahead and 
merge Henry's patch tomorrow after a final review.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 23:12:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 23:12:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426062.674273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olIEn-0007dt-NA; Wed, 19 Oct 2022 23:12:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426062.674273; Wed, 19 Oct 2022 23:12:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olIEn-0007dm-K1; Wed, 19 Oct 2022 23:12:37 +0000
Received: by outflank-mailman (input) for mailman id 426062;
 Wed, 19 Oct 2022 23:12:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hoZG=2U=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1olIEm-0007dg-MI
 for xen-devel@lists.xenproject.org; Wed, 19 Oct 2022 23:12:36 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 82fe4db0-5003-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 01:12:34 +0200 (CEST)
Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23)
 by BY5PR12MB4226.namprd12.prod.outlook.com (2603:10b6:a03:203::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct
 2022 23:12:30 +0000
Received: from MW3PR12MB4409.namprd12.prod.outlook.com
 ([fe80::45b:5f00:6991:c7e]) by MW3PR12MB4409.namprd12.prod.outlook.com
 ([fe80::45b:5f00:6991:c7e%3]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022
 23:12:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82fe4db0-5003-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LBxDirxmDG4gKiq0WWvE3/4tM7PDw7emonIHCjGHPwXy7uIvq4nTd2bmMhKHxAndiBwO6QXGLrRcmEPDYyFj13AWT/A5kLOoMglmx+iyF0pwwljbN4B4nJ2YpqgJrn9pKh6F85+G9XECZgDkxB+K+fA36t7RGsi1MKzDS4Hspw10krQUNNTE1pY0PC5P0k+talFI+TzuD68KTEPtC3xIWVMaleduM2QChEVHAE4o45xMES76tR21EEHhyXa7ouzaitxEPQq4wV+MCzLVesbccUSX4BSHpn02OCdko9a1uJZDZL3j1KulIPjwmlZjJWLNS1WlbfDMeQAGX5ErVm/Tng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cge5Yb2CzSD5Bu0WVHIFKjdDadxJS6eZRxLuDht1xKU=;
 b=iJqACC5pZUEgL3+sngHYNKvoUL5B0OZqbQdMiggKbWyq045yKZJ7kYYO1GUvjVFFhbY+58z1HzyzMD5q/M2wBkhVJZaMEud8m0SXXxf5dKBbAgVc/ZnMS4uv4AQvBQPBpF72zwrxgjnmy4D4j25AfyJyvIFF/54NsiI+WbVi7HocJe7pKDpv35pLZs1/ApLitpuVQ3q3u0XFTIHrATziyAmRkGTq29ktHMbSumXA29uIy+xARiAVOXnMrRNwQuPsWQbuVY6P3ETzxlYHsrUoGjKDIKDScg59dJhb0xAdb3Q5VDEdoz+0xZyg6A1OK6fQeR30cBLrkFjKXNLohGetmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cge5Yb2CzSD5Bu0WVHIFKjdDadxJS6eZRxLuDht1xKU=;
 b=DvDJfnkSMpqFxIzM9EZnjkQxW7H615G5tIIvoBY/cekTC53YWSYtHsEX9hawxadJSu4+GRuQ1HSGhsfJeJG8Pyv3zeMCRShd5k0mP9ooK39XmUMads/1x5IiVwWGboMmHEO9lsVGGunf2DcJTniA61rbwhcOZDHSIKBcki7OF9E=
From: "Garhwal, Vikram" <vikram.garhwal@amd.com>
To: Paul Durrant <xadimgnik@gmail.com>, "qemu-devel@nongnu.org"
	<qemu-devel@nongnu.org>
CC: "Stabellini, Stefano" <stefano.stabellini@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum
	<marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard
 Henderson <richard.henderson@linaro.org>, Eduardo Habkost
	<eduardo@habkost.net>, "open list:X86 Xen CPUs"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to
 hw/xen/xen-hvm-common.c
Thread-Topic: [PATCH v1 06/12] xen-hvm: move common functions to
 hw/xen/xen-hvm-common.c
Thread-Index: AQHY4FQ0tVypMawM1ke4uV2W+2m2Q64V66+AgAB0FBU=
Date: Wed, 19 Oct 2022 23:12:30 +0000
Message-ID:
 <MW3PR12MB4409CDD81742B163D0DD11769F2B9@MW3PR12MB4409.namprd12.prod.outlook.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-7-vikram.garhwal@amd.com>
 <7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org>
In-Reply-To: <7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MW3PR12MB4409:EE_|BY5PR12MB4226:EE_
x-ms-office365-filtering-correlation-id: 23df9e2d-1ba9-4906-e536-08dab2276581
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 pN5e24PcLSQ1cCvv38jyTr9A+zOgTE06H8eTvo7xUPz6Eb2U6TPH7glts8dQihw6dh411TJdErO9WwN62n38liv6zcLgHVBNVownh9opqEstGywg939mNYIxYMSQEK5YQN6dpTJySZJzYvWfyunS2R9M5rzPX6sz6lUzB9dPqJWjJ5BXVSO7uSxH0gF2shfLFFAV1S20OY4OdAo7ivlD4vUxYJYZp2SQHfy1sOfKgX/a/06GsaBQWeEmvKkXzat9liZiR+vNx/8EVoJeC86Ba63XPuaW4kTEU9RyqXyeg7cnppg02MdT+7w6OWbD2qdTZSC5Ddr2OKWznYf3WXAHEWopNN60FTykkEzToKAuPTfaI2iuE9zEWKlXSfjcjadGivck7tmC3GejRCS0pAIdI1ohWKIfA7wMMV14+WCLy5DocBPTuk9o9ZIm/euRmQj+3yp2ofaK81CELyjuPcDFtk/j0UvdXbXckQTlHcjMlAT9xGlvErJH8i27l0pAxkyrJ7krKdTbKcL5pPWuhPN34sGlXXjXrz2/T+Vqa/Sx/sDasJel4DvTqy7ySeEHzNSLgbO3pE3QtXjlYtoDxMzHnQM4ekh4W+K63Kj3WBa0hbhTIC37kCth9Nj5RRyBTmigQCj2xSOFEQy9pRqIoplAtALWP9x5wsI0w/pQEpUOPFPH8AMISRUNuY1HnNIzjWLb3rT6dnKT/MiITEel7VdFcrbbYAgRYTDkZFVBZXT/01XB84EXiO6J9x2++g+lUkTHCb0JTU4hrNV+1vKpGbGfwA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199015)(41300700001)(186003)(26005)(478600001)(64756008)(38070700005)(86362001)(2906002)(6506007)(53546011)(8936002)(33656002)(52536014)(9686003)(5660300002)(4326008)(7416002)(54906003)(38100700002)(7696005)(91956017)(110136005)(122000001)(316002)(76116006)(55016003)(71200400001)(8676002)(66446008)(66556008)(66476007)(83380400001)(66946007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?7+NCEbcC+tFqf3LmBoXY8ba0iAf7md7PnaQ5vbJxfvT/UWwCICC+mEEGnC29?=
 =?us-ascii?Q?yV7HyH0oB5VOuXxApqOyC30wAuEMz2xnNWrPk8aAYjBJ/9wH7pohDwtyZ9Eq?=
 =?us-ascii?Q?n1c5IqQYPCBGQOFqxgAtJldGQR2MfYd+cgIbD5J2VYBxYVC+jYDwDJMiowhB?=
 =?us-ascii?Q?gaxMz7RLvawNbNikc1Q6F3h5aFR73g4xavl4cnLCnoATeQjQHTOvFg0O/Ug/?=
 =?us-ascii?Q?Wr+/3Y6s7RIj9Rcvd3oAK8vIEu9YTIxDxtZfpnoAT/jbySYO7OZtUVasZo4N?=
 =?us-ascii?Q?GNbM83UAeY0u2wyfl0UDpHY7pBTxXxxa3RxbkEX/lsKzQYMicVqoIK5ikccB?=
 =?us-ascii?Q?w8Lpe0/zeEoiHiE/3X478njUBP1b6q/DZeaqr6PztQ00rTDUQCRLTn+WSOkW?=
 =?us-ascii?Q?32wxTchWCDCI09KfdUEIvC+1Psm8qgm34l/I2OGKqqgHIKjH9aGJ+/l90QUA?=
 =?us-ascii?Q?1JNJpZZLqbi17fyZ3u9kTt4xAPajXTiMSsxFhQTkrk8spvtztTO5WEPp9oqU?=
 =?us-ascii?Q?dfY0X/vobj8QuKHqnU8JUg32wh9Qgy+WPXWJYBwlh+DmyeTvUHwmjn73EDUA?=
 =?us-ascii?Q?g6vlvK2tI/fFzUAuufC/dC/5gLnREThm1YMXSQu8H8PkQP9Q2ndhEiQfw5ZC?=
 =?us-ascii?Q?uRiODjlFPHwUWTFFNm/oNTH752qin2y8Agb1mUCPB8SWHwiCDWEfB3Qsr/Sg?=
 =?us-ascii?Q?gzne0gO90kmjKzGVzOX4SbCg/yDu+cYdNHxAX7RdcI/CwWRqWhIEBNzIU6J7?=
 =?us-ascii?Q?fVLrBW6EDPznfkR0JFbrN5h0yHBrafRB1z8ORAClvmGFicMlQJ6EyPaxkXDh?=
 =?us-ascii?Q?UUmtoTWbCdyYNEUBIGjQxUvAx8L9jPzuCgCAlGfHq71UdOrNWM0S2HtTOoyt?=
 =?us-ascii?Q?U9F3kS/yAVTXECHI5pwOiL0spq2+/Pfsql77z7lIGVVAJNiEgwGq8WXGr+bC?=
 =?us-ascii?Q?U7zocUBqRO2bpuy1j4y7GoDMMlQ517Px0C7DAu1RkCMPlIwE+8JFn7Tm/JKV?=
 =?us-ascii?Q?5m4NzDcHy8EaadsevzXJle4kUUZuBAIO38tyvYYLEMaOco6HYuqijA7m0N4E?=
 =?us-ascii?Q?qgCGQpkVKbFThjxq8EfJxFouIWbAfStjgN/lJiY66g1sc0nj6H9SwPpw9GGA?=
 =?us-ascii?Q?QLij892ronN+R5pQ0Jne+BlPJUAp/bOZywqNw3wLk0QXmlLIKQH/ZEe8AZu2?=
 =?us-ascii?Q?HqlrhH4IQUv9npY8FZZAnr/wXxEwY4ZQESwCsZL2D9Z0vcN64+Lxy7No3DnR?=
 =?us-ascii?Q?upXIP9g+6Sso7hkPvBdrNP27cwePAWicQxzRCnoxTG838tQiNuZPVXTDUDoi?=
 =?us-ascii?Q?UPDLKtaZICAMZa9BQ8xJXg9LndeYI+nrHQQcOZiJEd+9CoeCIGGRYebEdPah?=
 =?us-ascii?Q?q9jgvX4X3NVWe2UDHStilfSUjG4WUtHhZLXVGYCUMU6ihHvqT5NUhVqWDsav?=
 =?us-ascii?Q?SCb4fxHpLt7ovoEYE2EdKk8A9Hc3MMhP8Elsx6WOszMCbwDzRvpdTLAkWJiq?=
 =?us-ascii?Q?ov3mYNXTurlGl3mpf6foibGS4nxbJfKbYVFLIgnwSDoSv1liTH7az27vFFTc?=
 =?us-ascii?Q?PNCne5Z0UKT7ZS5Zkp4K051BqTAd2J7hVr/xWtoZustkqBIwR2I6ADUoa7hp?=
 =?us-ascii?Q?Ng=3D=3D?=
Content-Type: multipart/alternative;
	boundary="_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_"
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23df9e2d-1ba9-4906-e536-08dab2276581
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 23:12:30.2354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8wLlyxRIG/7emrOSKcnd6OOAgQ79Ob1EdVKjAQVkEie357t2PX0klx7q76kfoWpfXvihaukOvP6E4vcSWVm1Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4226

--_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Thanks Paul & Julien for reviewing. I will update this in v2.

Regards,
Vikram

From: Paul Durrant <xadimgnik@gmail.com>
Date: Wednesday, October 19, 2022 at 9:16 AM
To: Garhwal, Vikram <vikram.garhwal@amd.com>, qemu-devel@nongnu.org <qemu-d=
evel@nongnu.org>
Cc: Stabellini, Stefano <stefano.stabellini@amd.com>, Stefano Stabellini <s=
stabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Michael=
 S. Tsirkin <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>=
, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson=
@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, open list:X86 Xen CPUs=
 <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-=
hvm-common.c
On 15/10/2022 06:07, Vikram Garhwal wrote:
[snip]
> +    qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state=
);
> +
> +    state->memory_listener =3D xen_memory_listener;
> +    memory_listener_register(&state->memory_listener, &address_space_mem=
ory);
> +
> +    state->io_listener =3D xen_io_listener;
> +    memory_listener_register(&state->io_listener, &address_space_io);
> +
> +    state->device_listener =3D xen_device_listener;
> +    QLIST_INIT(&state->dev_list);
> +    device_listener_register(&state->device_listener);
> +

As Julien said, these do not belong here. These are the (current and
legacy) PV backend setup functions; they most certainly have nothing to
do with device emulation.

   Paul

--_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc=
hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of=
fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	font-size:10.0pt;
	font-family:"Calibri",sans-serif;}
span.EmailStyle19
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style>
</head>
<body lang=3D"EN-US" link=3D"#0563C1" vlink=3D"#954F72" style=3D"word-wrap:=
break-word">
<div class=3D"WordSection1">
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt">Thanks Paul &amp; J=
ulien for reviewing. I will update this in v2.<o:p></o:p></span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt"><o:p>&nbsp;</o:p></=
span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt">Regards,<o:p></o:p>=
</span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt">Vikram<o:p></o:p></=
span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt"><o:p>&nbsp;</o:p></=
span></p>
<div style=3D"border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in =
0in 0in">
<p class=3D"MsoNormal" style=3D"mso-margin-top-alt:0in;margin-right:0in;mar=
gin-bottom:12.0pt;margin-left:.5in">
<b><span style=3D"font-size:12.0pt;color:black">From: </span></b><span styl=
e=3D"font-size:12.0pt;color:black">Paul Durrant &lt;xadimgnik@gmail.com&gt;=
<br>
<b>Date: </b>Wednesday, October 19, 2022 at 9:16 AM<br>
<b>To: </b>Garhwal, Vikram &lt;vikram.garhwal@amd.com&gt;, qemu-devel@nongn=
u.org &lt;qemu-devel@nongnu.org&gt;<br>
<b>Cc: </b>Stabellini, Stefano &lt;stefano.stabellini@amd.com&gt;, Stefano =
Stabellini &lt;sstabellini@kernel.org&gt;, Anthony Perard &lt;anthony.perar=
d@citrix.com&gt;, Michael S. Tsirkin &lt;mst@redhat.com&gt;, Marcel Apfelba=
um &lt;marcel.apfelbaum@gmail.com&gt;, Paolo Bonzini &lt;pbonzini@redhat.co=
m&gt;,
 Richard Henderson &lt;richard.henderson@linaro.org&gt;, Eduardo Habkost &l=
t;eduardo@habkost.net&gt;, open list:X86 Xen CPUs &lt;xen-devel@lists.xenpr=
oject.org&gt;<br>
<b>Subject: </b>Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/x=
en/xen-hvm-common.c<o:p></o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal" style=3D"mso-margin-top-alt:0in;margin-right:0in;mar=
gin-bottom:12.0pt;margin-left:.5in">
<span style=3D"font-size:11.0pt">On 15/10/2022 06:07, Vikram Garhwal wrote:=
<br>
[snip]<br>
&gt; +&nbsp;&nbsp;&nbsp; qemu_add_vm_change_state_handler(xen_hvm_change_st=
ate_handler, state);<br>
&gt; +<br>
&gt; +&nbsp;&nbsp;&nbsp; state-&gt;memory_listener =3D xen_memory_listener;=
<br>
&gt; +&nbsp;&nbsp;&nbsp; memory_listener_register(&amp;state-&gt;memory_lis=
tener, &amp;address_space_memory);<br>
&gt; +<br>
&gt; +&nbsp;&nbsp;&nbsp; state-&gt;io_listener =3D xen_io_listener;<br>
&gt; +&nbsp;&nbsp;&nbsp; memory_listener_register(&amp;state-&gt;io_listene=
r, &amp;address_space_io);<br>
&gt; +<br>
&gt; +&nbsp;&nbsp;&nbsp; state-&gt;device_listener =3D xen_device_listener;=
<br>
&gt; +&nbsp;&nbsp;&nbsp; QLIST_INIT(&amp;state-&gt;dev_list);<br>
&gt; +&nbsp;&nbsp;&nbsp; device_listener_register(&amp;state-&gt;device_lis=
tener);<br>
&gt; +<br>
<br>
As Julien said, these do not belong here. These are the (current and <br>
legacy) PV backend setup functions; they most certainly have nothing to <br=
>
do with device emulation.<br>
<br>
&nbsp;&nbsp; Paul<o:p></o:p></span></p>
</div>
</div>
</body>
</html>

--_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_--


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 23:27:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 23:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426069.674284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olISf-0000qW-30; Wed, 19 Oct 2022 23:26:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426069.674284; Wed, 19 Oct 2022 23:26:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olISf-0000qO-0M; Wed, 19 Oct 2022 23:26:57 +0000
Received: by outflank-mailman (input) for mailman id 426069;
 Wed, 19 Oct 2022 23:26:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olISd-0000qD-Ie; Wed, 19 Oct 2022 23:26:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olISd-0007ek-Fo; Wed, 19 Oct 2022 23:26:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olISc-0001lf-SI; Wed, 19 Oct 2022 23:26:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olISc-0006pW-Rp; Wed, 19 Oct 2022 23:26:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iizNIGmaazPMj82Rja/i05G/FqewOeS5JVO2LWr/jH4=; b=pfFUAqmi5c8Pc4Ee75r/ROHPHJ
	sHwhjsXBGTnZTYlKJLggb/utHsvOos5Mx0Wo99RgJF1k3a7JQRtAY4usdHQFYFMifEdGU9B84xiQR
	/L5dj1KeRkfi7kRsvHDgmf7L5TqdfmuXvzuqtrfVtOg1UeQRInCDYMZD53xotHT30kco=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174021-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174021: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 23:26:54 +0000

flight 174021 xen-4.13-testing real [real]
flight 174099 xen-4.13-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174021/
http://logs.test-lab.xenproject.org/osstest/logs/174099/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw  3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-credit1   3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-thunderx  3 hosts-allocate               starved  n/a
 test-arm64-arm64-libvirt-xsm  3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-vhd       3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-xsm       3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl           3 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-credit2   3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   65 days
Failing since        173495  2022-10-11 14:08:01 Z    8 days    8 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    6 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          starved 
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 starved 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      starved 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  starved 
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  starved 
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 starved 
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 starved 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      starved 
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 19 23:30:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 19 Oct 2022 23:30:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426077.674296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olIVi-00029w-LK; Wed, 19 Oct 2022 23:30:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426077.674296; Wed, 19 Oct 2022 23:30:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olIVi-00029p-Fk; Wed, 19 Oct 2022 23:30:06 +0000
Received: by outflank-mailman (input) for mailman id 426077;
 Wed, 19 Oct 2022 23:30:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olIVg-0001v1-El; Wed, 19 Oct 2022 23:30:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olIVg-0007hN-Du; Wed, 19 Oct 2022 23:30:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olIVg-0001qI-7J; Wed, 19 Oct 2022 23:30:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olIVg-0000Rh-6q; Wed, 19 Oct 2022 23:30:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=J7mbG/+ue0SH0+NOTDPTJw461O/2NzxJigqaBvvMr3k=; b=kfdVBHz5Sj2WOPegjoMXeM5WkK
	P1W+o5hxoL16gb3A+KKodCXGZyIoQULjfnsqsGnT7pUUkLIrJagKKKky2FfTImyzuVXAJ3/DGPkaO
	bc7L44vi4BbPURyFADHSwnpP7MEoHUzyyv0RIl9tqqUsabB7y+pWK3IlTYPBKpUHHlIg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174102-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174102: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 19 Oct 2022 23:30:04 +0000

flight 174102 xen-unstable-smoke real [real]
flight 174105 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174102/
http://logs.test-lab.xenproject.org/osstest/logs/174105/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   12 days
Failing since        173492  2022-10-11 13:01:50 Z    8 days   54 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    2 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 01:22:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 01:22:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426091.674325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olKGc-0003gS-0Z; Thu, 20 Oct 2022 01:22:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426091.674325; Thu, 20 Oct 2022 01:22:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olKGb-0003gK-S5; Thu, 20 Oct 2022 01:22:37 +0000
Received: by outflank-mailman (input) for mailman id 426091;
 Thu, 20 Oct 2022 01:22:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olKGa-0003gA-Dr; Thu, 20 Oct 2022 01:22:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olKGa-0000Hg-9l; Thu, 20 Oct 2022 01:22:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olKGZ-0006an-Oc; Thu, 20 Oct 2022 01:22:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olKGZ-0004Eh-Nx; Thu, 20 Oct 2022 01:22:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=msWg5WQzIydFpe0LC7Fvaove+KxoJ09efkZnxVLHThA=; b=TkWhrjrDOvtD5xXXM9bpcG+Ugz
	Up9rJ5y2pOQxZuilzpOQHELrOVonAxK7fuKSOlTsHvAtdqAdSH/E1wAZwnIpsj9B8nphuPcxU4Nb9
	Tpubh9t/uGW16zdUuGebLmZDfsKUJOmeEsmxxng3q8hfXHWHsiEk9q5nyqagIAGryOag=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174052-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174052: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=bb1a1146467ad812bb65440696df0782e2bc63c8
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 01:22:35 +0000

flight 174052 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174052/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                bb1a1146467ad812bb65440696df0782e2bc63c8
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   12 days
Failing since        173470  2022-10-08 06:21:34 Z   11 days   20 attempts
Testing same since   174034  2022-10-18 04:15:50 Z    1 days    2 attempts

------------------------------------------------------------
1277 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 120462 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 02:07:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 02:07:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426100.674337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olKxn-0000IM-Hw; Thu, 20 Oct 2022 02:07:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426100.674337; Thu, 20 Oct 2022 02:07:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olKxn-0000IE-Bx; Thu, 20 Oct 2022 02:07:15 +0000
Received: by outflank-mailman (input) for mailman id 426100;
 Thu, 20 Oct 2022 02:07:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olKxm-0000I1-31; Thu, 20 Oct 2022 02:07:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olKxm-0001lb-0E; Thu, 20 Oct 2022 02:07:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olKxl-0001oj-Ax; Thu, 20 Oct 2022 02:07:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olKxl-0007HV-9f; Thu, 20 Oct 2022 02:07:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0zyJQQEBS9gxULt9D0b2H8NxU2vCrM+YavBhu1HB+UU=; b=rGkN7ADQA7QtAEaLStc+1jcvk2
	xPqs1EB8/mcxhfXe8l21Mkta0aI4BUy2+n+7B8DvZbB2pH8Jc+j51PE5qnaa1bm7g5QgF9UyFqiUG
	3O9gYO++zF+uiqeRnYKZ+SsJ23jE7TkZkVQE3Cw7BoMvssHrkTqReiWGVFPMu0jFQlPI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174035-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174035: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=71d9836ca174997aafc4b14fb4f14d59ecc270b4
X-Osstest-Versions-That:
    libvirt=e7d6f2d958705bf3298cbe7c1e7d9ded772a643c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 02:07:13 +0000

flight 174035 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174035/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173796
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173796
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173796
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              71d9836ca174997aafc4b14fb4f14d59ecc270b4
baseline version:
 libvirt              e7d6f2d958705bf3298cbe7c1e7d9ded772a643c

Last test of basis   173796  2022-10-15 04:18:48 Z    4 days
Testing same since   174035  2022-10-18 04:18:52 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jiang Jiacheng <jiangjiacheng@huawei.com>
  Jim Fehlig <jfehlig@suse.com>
  Ján Tomko <jtomko@redhat.com>
  Maxim Kostin <ttxinee@outlook.com>
  Michal Privoznik <mprivozn@redhat.com>
  Peter Krempa <pkrempa@redhat.com>
  ttxine <ttxinee@outlook.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   e7d6f2d958..71d9836ca1  71d9836ca174997aafc4b14fb4f14d59ecc270b4 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 02:58:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 02:58:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426108.674346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olLks-0005Yu-6c; Thu, 20 Oct 2022 02:57:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426108.674346; Thu, 20 Oct 2022 02:57:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olLks-0005Yn-40; Thu, 20 Oct 2022 02:57:58 +0000
Received: by outflank-mailman (input) for mailman id 426108;
 Thu, 20 Oct 2022 02:57:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olLkq-0005Yd-OS; Thu, 20 Oct 2022 02:57:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olLkq-00030p-Lt; Thu, 20 Oct 2022 02:57:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olLkq-0004T2-AW; Thu, 20 Oct 2022 02:57:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olLkq-0003jT-A1; Thu, 20 Oct 2022 02:57:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RuRQVh3129Ir+Ga/FxyAxKeeCUF2PZ6A4NzJrHKGDtw=; b=F+z7E2WoNiI3JU+3OlOyFjC/Nt
	UYkwow5SJ2cinLKWsG5n5T4JEpHMewemQZ0pCRT7xM+/29OfxExMYE1ZhER0pGSm2qOjmF71NbWt5
	/0N1TAGI3B1eUsSs0+82PIrO3u1SJ0g8PsZ1H6CDNnOADKEh3dSyyYmPv4jNtSuDA/YU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174107-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174107: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 02:57:56 +0000

flight 174107 xen-unstable-smoke real [real]
flight 174113 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174107/
http://logs.test-lab.xenproject.org/osstest/logs/174113/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   12 days
Failing since        173492  2022-10-11 13:01:50 Z    8 days   55 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    2 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 03:01:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 03:01:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426116.674358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olLny-0006x6-Ls; Thu, 20 Oct 2022 03:01:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426116.674358; Thu, 20 Oct 2022 03:01:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olLny-0006wz-J3; Thu, 20 Oct 2022 03:01:10 +0000
Received: by outflank-mailman (input) for mailman id 426116;
 Thu, 20 Oct 2022 03:01:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oIjd=2V=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1olLnx-0006wn-2X
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 03:01:09 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2085.outbound.protection.outlook.com [40.107.103.85])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ec79007-5023-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 05:01:03 +0200 (CEST)
Received: from AS9PR06CA0537.eurprd06.prod.outlook.com (2603:10a6:20b:49d::34)
 by AS8PR08MB7838.eurprd08.prod.outlook.com (2603:10a6:20b:529::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 03:00:57 +0000
Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:49d:cafe::10) by AS9PR06CA0537.outlook.office365.com
 (2603:10a6:20b:49d::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 03:00:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 03:00:57 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Thu, 20 Oct 2022 03:00:56 +0000
Received: from ec5e4c7a76c0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7EA5881E-7517-4CFD-B899-584A351EE779.1; 
 Thu, 20 Oct 2022 03:00:50 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec5e4c7a76c0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 03:00:50 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11)
 by DB9PR08MB6331.eurprd08.prod.outlook.com (2603:10a6:10:251::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 03:00:48 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c]) by AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 03:00:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ec79007-5023-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=nv5P8zMH++IQfLfzjU/IftW6Qb6Qo6TWGoTxuUbi30b6I9vw1E+EZ1pJZkM8KkhQP/jz4NWM+cUllIELEHqdizKptITPLh8gIdweothHZmgXG50QzqZxOb/dBAXNabkepIsYu8hxu6a9OAauqdCJ31m20cUQrgEsrqn5dB3nk5XOxpPr3yDpQv0ZijZDIrqxTJTGPNAhdIgLlpNSnWszLSjelfwrSh9DVfgtVRL8zrTj5wE93vnm/6dL9h7U27FE1xMAG6JqeQZPhbHqu8UUgsj/V/lJiytBLZVVdGyhjA7qfcfBM7BaNJ56wqJa61A05EL03BgTaVYh6HLYLYKkZg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9FBfuY0wOlOUqM+aQYbculcX2JSONvjRHhg/X9r/nrM=;
 b=X261p19VHqApLDXfnrvBF1026jZJ+daJ3FQj1at/YO7B5hvnwJPGA/YVcrEUSg02t3HRt+XptXMGPg7ec5SY+mIxjzlQkPdLdmx7fibfyrizkg5Tn2jl29q4ZaxoqhfXYDrifVq2hF1h9v8DpE3F+14tqGhEoK5KDbyp7SbgO3PGZGHcnuOPYoQHALx608AUnt4awg0J3yZeKfGPiEW001nYCtAjEh7PfdraPqD01dnSyEQWsFc+gxVDnLL9pBlA858zUlSiYQEX9E/M0HjmfpzFv6icvCBsjcJTFrpFOtzlfbLuJgIxdj7lwmjnCYjJkT1bcA0ptFDtR83UgOtbbA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9FBfuY0wOlOUqM+aQYbculcX2JSONvjRHhg/X9r/nrM=;
 b=MxvADIBUBO62+HqnZiRQkwZ7SIRkh86FJjIIfYJQyE65eOhkwUb1SSF4SV5Xgh3f6hJ0snWc6rRJGYIZTJTZQntnhFYKiIDXnq2f48zCDWtd9DQ7DiTDBgXBD8+w4PY/suw0bRZysUqYshiAy9/7a22X5wpzW/0GmHJXEOtVI08=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RUXwB0ThJzJxCH5WHd1+f6lj8u6MtLT8Gz9NUuQwzYbyXSkju3k+mvBE/hB7J/xBtQwrruWRRRo/NLCbALZKCQHXifr4JHEPV35xcfqKyxOmzzoT5ZV6JMUt5U2CV2SavwswroGyDdLJqrOx9IYAX0Qso64eip0yH3TnJCjy9qpo4Yrorg4nPfUEFLY7EJmD6VbFK1X+w9JB1ZL0I4tTtnbJzYU9wrUBxNnd8j2APqTUZ9yYh+xHPNYC1Fx5QoMVQiCwKPwK2oWGJIv9TqjMK57CksU1SAplgZGw6P/bCvbDEJ7G6JB+oUyLV8F+THEYtJfFg3+Uz+1uZwgxJ8Xk5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9FBfuY0wOlOUqM+aQYbculcX2JSONvjRHhg/X9r/nrM=;
 b=agABo7CfVJjBbjTiaBQNjXFBNZzuDiibZlemYrJxHzK0IQs1oFSzAhUoUmFt0iq2gpUwBCuDLunP8p3g4KIK6gp7iiUViyj31TC0p8KfvcGaq2V03tCBk+ajGoN0SuvN8LQME32V5EnpbODBK/UXFOtN2ZZqpk8Tf/FYHhJZ4knSeIPveJYdQLr4FUwkJTxyS26ocuA+q5zZaHY8ANJQQvXWfqAd41C0F2KR/7dbxBr9MmPnGF1GAtbLsSUVIlcB9Ptj6DDHXiqqyZDeCJUG0dniXm8mQP7k1BRPY5Q5k/yrtvFVRY96YdeNKHs29muFLQ3LNNSoXyvTXZ6ZS7Vgww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9FBfuY0wOlOUqM+aQYbculcX2JSONvjRHhg/X9r/nrM=;
 b=MxvADIBUBO62+HqnZiRQkwZ7SIRkh86FJjIIfYJQyE65eOhkwUb1SSF4SV5Xgh3f6hJ0snWc6rRJGYIZTJTZQntnhFYKiIDXnq2f48zCDWtd9DQ7DiTDBgXBD8+w4PY/suw0bRZysUqYshiAy9/7a22X5wpzW/0GmHJXEOtVI08=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: RE: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Thread-Topic: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Thread-Index: AQHY0lZFu/mKHMVlEk6rDAaZCITsX64Ws3HQ
Date: Thu, 20 Oct 2022 03:00:48 +0000
Message-ID:
 <AS8PR08MB7696D8C9D2239CC9ED2FE08F922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
References: <20220927094727.12762-1-michal.orzel@amd.com>
 <20220927094727.12762-6-michal.orzel@amd.com>
In-Reply-To: <20220927094727.12762-6-michal.orzel@amd.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F1C4FB2A9BFFD743A93E1C409AEF2474.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7696:EE_|DB9PR08MB6331:EE_|AM7EUR03FT006:EE_|AS8PR08MB7838:EE_
X-MS-Office365-Filtering-Correlation-Id: 7745b51f-24d1-401e-67fe-08dab2474f71
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0IoMcRV4UbA0pBTmZl8UqfQYu/GGXrFwIGyydcuqGREq3B98DLzSm2osoPkZtAxwc/iVnNf7mWPvqjF4/7SbCMLBMHYS40UkGvcNUTv63sBwZ7++hu61nyhoQlDedL790Z6fG+epVx6tbNMra6njvWxkaT8chlG81RJD/YsonAGsCG2Ar7tpeJfgo9z7QJ7XJzICRQ7Ne9Mi3JGASd1HyKUyI8N82aEdp+I0LoYMtEsZmzT2LCxXG2yvwUPsYvBty6u94efBReTtEhjmHkuaZmLaFmNJ2/VJ4D0XzvaleGPRFqSuCZu6Vl92h3an1tnMdTKv3cONw2fT/bfwU9phEp4ag+CgFiAgD29Yri+CEa0KfVOGaqz16V2twuwznsWWtcnMERyq0AVS/Y0y2l8ECYEk1VZW/Od/Ubs2PgD9HoNbnoWfv5lp1PQiQD8uawdeDGAdlmdpr1Nf6eiHvr0MIBEl6E+yw+4jMFrdljokAcFy2ABkCB/PDrytJ8b9vMpGIWYlBoJ+ku9J/UlB6AfRdSZcWxqjqSbwkMrZ5EauAX7HbFSCF0XR0r2W1YNs5C9ml3NqwVTQGJ+Lex1Q1GCFKUzb+Kg7c+3mfkHjrfvLl5jf7sy+XxDmqLhiHY3J1KjiQnk5AIqXpmSrhtKOIDR9xkmxkCCJRruM6raoXdSaRLhvyssIclwZe/7/WLU6MUw8cbUvOZ+59gF8wQSjA32QUfezLO/7GH+tdgcF+R5NCvyGA6d9+5GcjZY2Avas0/yx
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(136003)(39860400002)(451199015)(26005)(8676002)(33656002)(66476007)(76116006)(64756008)(66446008)(66946007)(66556008)(316002)(478600001)(54906003)(52536014)(110136005)(4326008)(55016003)(186003)(38100700002)(122000001)(83380400001)(2906002)(41300700001)(53546011)(9686003)(86362001)(7696005)(6506007)(8936002)(5660300002)(38070700005)(71200400001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6331
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6084dc88-7d10-4868-873d-08dab2474a35
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A+0LEVt4JdtcuBbZB2x+XSyITBLe+JCzBTi5NGw8mDtUoYmfXLs6nXYkJktpUDXL/LMbiof5U80ANwT/mDIJYv4u1xjlbr9nsoCevmLK3TJ7mJ3ogvPmkaVfBciRh4Z/KeAYySuUYCUY+XozeezNbyEt/GI2MIfD6NvGSDGblqNX1f/1GN6ws5KyqfxOP4DF4/MGq6CLpPr0RNCvv9hHtAl0ma4huKpFZ7QFSpG1nKs9CMkKb2dgm3GkdlQw64EFbpwuJLrlOx8UaHAPi+6x6TnlMeEFYDLTYgVtlq5PZoiS+0stLj7SQS9jTwz6YMW0llgRhECF8mmuNXjdnr7uudBGP+d0Vva0EU3HrdLqXx5RHvy8Mgp0EOfNJ7dI5ohCUMjLm1QxEzFypgATM6ZQDBYyyCsg0iBzjDhwAM9hc+brkL1j4MG3NXgmiN615u/6sPEX3EwhDtheb5kbHJaojOeJCkifJOwi4zVUsMSstSg9HljSJZpyfMnGS8uIgnx5jN3fQ7KeAFADvpLkaQ9xiwqCXADII7zoDZ4a3Ovf6ow54aZmSCq87oPj3oIJHBBoeUJHn/NZh7shMd4tkG9xByc1f/ES9O2KvZKf2mZzhu2Llp7+yxU6lUA2BOyGgmOq1Rudv6ABelluo/0iD2+sR7wwGCQrYlAHA5pES9tIFEosw/vEK/ewouM4XC1tA02UWlcbI3nX5ud9jFPzPovBG+rNCruzxENdgcradj1h9uXnskG6P1lU8ZPXH+skRUgcpysPPJE7QQGuEQlccjJOiw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(33656002)(336012)(36860700001)(86362001)(82740400003)(2906002)(5660300002)(8936002)(54906003)(47076005)(186003)(81166007)(356005)(83380400001)(6506007)(478600001)(70206006)(70586007)(53546011)(4326008)(7696005)(316002)(9686003)(26005)(110136005)(82310400005)(55016003)(40480700001)(52536014)(107886003)(40460700003)(8676002)(41300700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 03:00:57.1132
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7745b51f-24d1-401e-67fe-08dab2474f71
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7838

Hi Michal,

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Michal Orzel
> Sent: Tuesday, September 27, 2022 5:47 PM
> To: xen-devel@lists.xenproject.org
> Cc: Michal Orzel <michal.orzel@amd.com>; Doug Goldstein
> <cardoe@cardoe.com>; Stefano Stabellini <sstabellini@kernel.org>
> Subject: [PATCH v3 05/10] automation: Add Arm containers to containerize
> script
>=20
> Script automation/scripts/containerize makes it easy to build Xen within
> predefined containers from gitlab container registry. This script is
> currently missing the helpers to select Arm containers, so populate the
> necessary entries.
>=20
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> Changes in v3:
> - none
> Changes in v2:
> - modify commit msg to reflect that we are missing helpers but in reality
>   it could be possible to use Arm containers by specifying the full path
>   to gitlab container registry. However, such usage is annoying.
> ---
>  automation/scripts/containerize | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/automation/scripts/containerize
> b/automation/scripts/containerize
> index 9d4beca4fa4b..0f4645c4cccb 100755
> --- a/automation/scripts/containerize
> +++ b/automation/scripts/containerize
> @@ -25,6 +25,7 @@ die() {
>  BASE=3D"registry.gitlab.com/xen-project/xen"
>  case "_${CONTAINER}" in
>      _alpine) CONTAINER=3D"${BASE}/alpine:3.12" ;;
> +    _alpine-arm64v8) CONTAINER=3D"${BASE}/alpine:3.12-arm64v8" ;;
>      _archlinux|_arch) CONTAINER=3D"${BASE}/archlinux:current" ;;
>      _riscv64) CONTAINER=3D"${BASE}/archlinux:riscv64" ;;
>      _centos7) CONTAINER=3D"${BASE}/centos:7" ;;
> @@ -35,6 +36,8 @@ case "_${CONTAINER}" in
>      _stretch|_) CONTAINER=3D"${BASE}/debian:stretch" ;;
>      _buster-gcc-ibt) CONTAINER=3D"${BASE}/debian:buster-gcc-ibt" ;;
>      _unstable|_) CONTAINER=3D"${BASE}/debian:unstable" ;;
> +    _unstable-arm32-gcc) CONTAINER=3D"${BASE}/debian:unstable-arm32-
> gcc" ;;
> +    _unstable-arm64v8) CONTAINER=3D"${BASE}/debian:unstable-arm64v8" ;;
>      _trusty) CONTAINER=3D"${BASE}/ubuntu:trusty" ;;
>      _xenial) CONTAINER=3D"${BASE}/ubuntu:xenial" ;;
>      _opensuse-leap|_leap) CONTAINER=3D"${BASE}/suse:opensuse-leap" ;;
> --
> 2.25.1

[Jiamei Xie]=20
I wonder if an default container for arm can be added. For example,  if=20
 "CONTAINER=3Darm64 automation/scripts/containerize bash",=20
 set the default CONTAINER as "registry.gitlab.com/xen-project/xen/alpine:3=
.12-arm64v8"

Best wishes
Jiamei Xie




From xen-devel-bounces@lists.xenproject.org Thu Oct 20 04:54:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 04:54:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426129.674387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olNYv-0001Os-34; Thu, 20 Oct 2022 04:53:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426129.674387; Thu, 20 Oct 2022 04:53:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olNYv-0001Ol-0B; Thu, 20 Oct 2022 04:53:45 +0000
Received: by outflank-mailman (input) for mailman id 426129;
 Thu, 20 Oct 2022 04:53:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olNYt-0001Ob-EZ; Thu, 20 Oct 2022 04:53:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olNYt-0006Dv-AC; Thu, 20 Oct 2022 04:53:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olNYs-0002qL-O4; Thu, 20 Oct 2022 04:53:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olNYs-0000Kr-NZ; Thu, 20 Oct 2022 04:53:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=19Ytn/v8otDmD71HmUPIXByvbZgbQsgp2NxEDsw01G4=; b=YsKubAD2g63X6rbKXkE1zxC7if
	pGyDe3tQExQQwFZ3+CiLqELEF2n4FRNCtQSBuQrodFQDYutCnbytAw+tQ0dv7mRpbCYRgRyBydUIp
	9LwMXGsEleK8EgcPDE5ygcarZ8Mz54yCy02qnoP+cpdmLmq30NggG6QOx9AUgF8hkzS8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174063-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174063: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 04:53:42 +0000

flight 174063 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174063/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173987 REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-vhd   12 debian-di-install fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start   fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start  fail in 173987 REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174063
 test-amd64-i386-qemut-rhel6hvm-amd  7 xen-install          fail pass in 173987
 test-amd64-i386-xl-xsm        7 xen-install                fail pass in 173987
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173987
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 173987

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start    fail in 173987 REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   65 days
Failing since        173494  2022-10-11 13:38:08 Z    8 days   10 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    7 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:07:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426142.674404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOhe-0000ca-GH; Thu, 20 Oct 2022 06:06:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426142.674404; Thu, 20 Oct 2022 06:06:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOhe-0000cT-Cm; Thu, 20 Oct 2022 06:06:50 +0000
Received: by outflank-mailman (input) for mailman id 426142;
 Thu, 20 Oct 2022 06:06:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oIjd=2V=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1olOhc-0000cN-Rb
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:06:49 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60046.outbound.protection.outlook.com [40.107.6.46])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5fe4e1b8-503d-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:06:45 +0200 (CEST)
Received: from DB6P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::19) by
 DU0PR08MB8019.eurprd08.prod.outlook.com (2603:10a6:10:3e6::17) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.26; Thu, 20 Oct 2022 06:06:42 +0000
Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:29:cafe::fa) by DB6P193CA0009.outlook.office365.com
 (2603:10a6:6:29::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Thu, 20 Oct 2022 06:06:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 06:06:41 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Thu, 20 Oct 2022 06:06:41 +0000
Received: from b514b77a992f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F2DCA093-2E99-438F-B87B-6E9741050198.1; 
 Thu, 20 Oct 2022 06:06:35 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b514b77a992f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:06:35 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11)
 by AM9PR08MB6708.eurprd08.prod.outlook.com (2603:10a6:20b:30e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 06:06:31 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c]) by AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 06:06:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fe4e1b8-503d-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ZV2V37J1P7U9AVbz7RfOImXEucQqM3/zuWL4DRg8wYa/u6MORBmHcuUDiovEqO7j30oz+2lFLuGA3+4FrkPjx+MH2eE4Eguw6OL66tIudE8OqYdP8RrCa2oNfsFcRzYdeN6Cp4OSlXj3j+HV44eT9OYtOALHhFc+QQVhufuAZJEze3+PbNzaxzBsBmQfTi+s/yxm+LFmrzMNXqQWsOoJvVzWqqsgb807h6zE0wPr9nwZm76whWaB31fUfRBArARc4C6hoVS7zNxhVreTu0nyMyBNBKKScrXwrf5eoXuooq3Tljt3VUzXenh6p8oeVaAVd8JYI9vqDc1GYjxA1pqJpw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XR8xoKIO59aqd5nvBPcfi+Vb+egPn9X+bVoWkdzuG8w=;
 b=lia6FEKWQ99GcTH5IStQKlN/cRYfBH5Y8Fgl9w3Bq8VLvo9e+xwLEwUiGpoDCCSAIWld/2VtNzn7phR5zUptRlrFgkxaHa4PWnljKzAy6tCIb2qkwR/fOnpuzpJSMauKw5ZyLq8PFb8315A3ASvtO+imRIQklJu1e1A/RMJqfarBwR6lRRLx5L/wxI+f3dLg77I5GCs1zMS9mduXmM7YKZOxz8JgTGVH1bXNsLGNY/7EqI11TlKrP3auljqHg3GEHDmLtlxWpvS4llE5Hxf0pZwT0jdQ5hRbS36CNI6IoF4Niq30ScdX9zxd0Yt6ExkgCsRUQUYkvBz42q6ivW8+YQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XR8xoKIO59aqd5nvBPcfi+Vb+egPn9X+bVoWkdzuG8w=;
 b=OxUQ6A3KP1lVHqJVEjGq8Ek0c9Shz6B1R6NLr7Ya/ykWwQUpcNa5iloYYiEnL+Dp4qdRPHiVak9LHkEb+pTwJBLImIR0WX6dw5KgITo1l2uQGc18zVqWQH4YiW1IAzoYHZFJzzS6ECdDkr05uB4jjPwFZqAUWqRw1pEeYWeMUnE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NP0nsDDQYbl4QXQ7FnzbGY7Lv3xgpy6w3JbZBCql7W+Yq3j3cywGn16S2zraFHEeqe0O/fc368o4pGAQLTv8u66jHnxszvwk7cSmlYfzNphZYVehRr1aGWhGbTJs+mrIxapE8azVuVY/SrwQFonz5rXV0p6bwv3y1oTTCSAFfM73U8IWbbu63obi6uxRH2rlfSG+ViAsoX0lBGlWTfLa3rZGAZCCMjESeX7NUahgEXXPlkKC9WFOP/rxly0uIf0nuiEfd2fjR3fv3S1FsSqeJ3VmGHVNmiikwSyUBNY+Z/0GjqT7DjLmkVS61jynfRv9gnXZC5G0tfCC2bHaB8d14Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XR8xoKIO59aqd5nvBPcfi+Vb+egPn9X+bVoWkdzuG8w=;
 b=W/pF6L42BA9V9aArUa5tF8pE+QuX1GbKcuoAsXVD6oWasi2nYyJY/ivLDnzjclKt1jTP5ME0k9hJE034+NwiHvRYihHju/mxn95skGrDn9qVatOlN6yiL8l3b8aEfzee84RAqNRT/h29PxYIkmqrnY4AYc8q5Qy6W9jw/OfFCxbJqx0yNfj054xINWHek+YA2xhlwdChjdgBeDPCqap74jh5sItNJPANmoTiuWE3A9C0RbbX+PkNAvFAabOFdhaP4kXm+nYKHUOQg01eu+nWifT/kZJ6RK6DXRVwjyCZE1iZdIknYlWjA/OuxmxWNocENzT3lG1KdoNZS47c2Svxdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XR8xoKIO59aqd5nvBPcfi+Vb+egPn9X+bVoWkdzuG8w=;
 b=OxUQ6A3KP1lVHqJVEjGq8Ek0c9Shz6B1R6NLr7Ya/ykWwQUpcNa5iloYYiEnL+Dp4qdRPHiVak9LHkEb+pTwJBLImIR0WX6dw5KgITo1l2uQGc18zVqWQH4YiW1IAzoYHZFJzzS6ECdDkr05uB4jjPwFZqAUWqRw1pEeYWeMUnE=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: RE: [PATCH] automation: test.yaml: Introduce templates to reduce the
 overhead
Thread-Topic: [PATCH] automation: test.yaml: Introduce templates to reduce the
 overhead
Thread-Index: AQHY49ns8H4XagK8TEuA8KOvVnaQ864WxmAg
Date: Thu, 20 Oct 2022 06:06:31 +0000
Message-ID:
 <AS8PR08MB7696EB037262B58E33209E18922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
References: <20221019164246.5487-1-michal.orzel@amd.com>
In-Reply-To: <20221019164246.5487-1-michal.orzel@amd.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 6175EA4EE2E65946A8A069A0D8B371C5.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7696:EE_|AM9PR08MB6708:EE_|DBAEUR03FT006:EE_|DU0PR08MB8019:EE_
X-MS-Office365-Filtering-Correlation-Id: 26431547-292c-4a8b-f32e-08dab261420c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 byUQc1YdDOnyr/x8AREuDtelzEzqQUmXMHZlghEcM1huIAm72kEmuoWgwsDsvBbkQzPZSukEQJ2yWq9cb8wFA+GUqnEtvT3jo2l0gyjGYB3o3QfDvB5ZiGkq0TcsNjum2M06ymFEixSvNaHKwLkIFiFLqqyh32Tf7+43rLMh5aSzWRw7zv3uFV1STwqvWniG3hedU/GWPin8MNTHWVfsakDTz3qZM16K3TL7V9/bK+GhlDZmlRX+R4FGumLzU3Lv5YKIlX4CyPdkw69yfiijo/qDXDQU5Y7nnmBDcyqa31hRWLgoGNgMryMz5bmL3cmRSFzcVG42ath9IMFzy6d5W0YamNXs8z5jBN4oYXvbAAhTiE13Th2i6RMs+wkbCkotr70d8rscDQa5svPz8bDzWDEM1Y9EdRTzZRXVsMGvA3s5+Zlwmjh5eVMJqQ5QLeCwY6LAta7YGoo00IIaGXSaQaHmUp/3F8u8l77ABGvj46G48n97ih1Qthe6rLxRP/12VlWAtS8TvPguuIuZaHaE/0qiJauN7uKwKee+gG9fjYjSiLCd6TPkYd3I8qtW3Nx4o0wjlv3O5LlrFoLSCXIqf+LOcXa9GV2Z1UCOxfb/ZN/pLWZhIrbmVheFaQlBmBT+J0d4IbjMefC4K35ky1rhJOw4wf5Qqc7lD1cmUrYv0d0MAzWA427DMyr07JJ82ajUNj/2iTDaXafidqb7yyO50Quxfn0VQrSuk8cKzZcMnLdUep4gZbZLklQkQvOvglACChh6kQSYg2cRqj8cbecFHYkJMLCOXVrXn9zw2VAQTBOWP5kapyuVwboewTTw3ISWnHQd1idjcTnyKNoArKtoTg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199015)(41300700001)(122000001)(53546011)(7696005)(6506007)(38100700002)(8936002)(52536014)(8676002)(55016003)(71200400001)(66446008)(4326008)(66946007)(66556008)(64756008)(66476007)(76116006)(5660300002)(316002)(33656002)(2906002)(110136005)(54906003)(38070700005)(83380400001)(86362001)(478600001)(26005)(9686003)(186003)(966005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6708
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2b156a8a-91a2-43d2-1c82-08dab2613c10
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MI3wDc6O2jaPkI/vd6/LvhJF4SUmUDigTeyhv5RtvkX2kAlst3Dw+5kigI3PofS+6zlT6hb8nJrOkioSIdI5Qk6NyXzPYhJyhDdsi/pApZuI/Zg050/2o5zvFLxlvemkmFTewI3wHNBJOUu+1pqvMi9quXVA19yIc1L9zUkvxbC5YJIsGYcOiApH6CMuHaueYMMYzag+m+3ih7mPJkiGd9D37jxREW7frWuKoZo/MMFaGzpJ/QuARhNrr3RNynsZQF4BPDtisK75WZjI0DkdC07Jgcjybnq5DnA5wcH81EDaCVzyij0/MU+A8cdZcADgyrO6JYjRTAhJ7zbarO+JGBh7Mm03S0i8n8IxGpvHrP8DU3sUNSdUE48HBwoGmE8ZTyBLGgfdkQjqlPfPtgNNWEbHU6VIObCHtmG2lx/+POM801/YHKP4mbl/WEWsCalg4ZuNrsMTV+KAVyNe2KG7VJMw3tkt1sKQfNUlDqHLp38CCr2UwjTgS0Wz7bLKJzm1Y6MIRYjPBdoN0ehH/9XU2xarEWNkkNCxsLCgxN/OuDCBwYDVW9gfDq1pG6cRgfdDNEzapfiZrpAmUm5E1jnC4VD2SxclqkUTwVlreC3UW9AIY0HknATaMRVLHGQjBanVU39hp1iy+CCIREfvL6Ai8yfh6PsSgq/BvHozhO4L/YY6OqrGmgrV/S7nLIa2n4vJQ6sxYejxZReTMMsmW7IxliVPZDN9CJ5LxglngXAlhMGxWyMqzSfBEVDGivGDt5oFmzYeDClPWQ9pqmUMPJbSI8Yj3Vd2cLCfwkxTrvUgFsWR9B1zwbKIU2tKivDoD1BgunApmt26cMfBAu+EcCK7Nw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(82740400003)(81166007)(82310400005)(83380400001)(356005)(40460700003)(33656002)(86362001)(40480700001)(55016003)(36860700001)(107886003)(70206006)(70586007)(54906003)(316002)(110136005)(5660300002)(53546011)(186003)(966005)(2906002)(6506007)(7696005)(4326008)(8936002)(26005)(52536014)(478600001)(9686003)(336012)(8676002)(41300700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:06:41.6063
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 26431547-292c-4a8b-f32e-08dab261420c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8019

H Michal,

> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Michal Orzel
> Sent: Thursday, October 20, 2022 12:43 AM
> To: xen-devel@lists.xenproject.org
> Cc: Michal Orzel <michal.orzel@amd.com>; Doug Goldstein
> <cardoe@cardoe.com>; Stefano Stabellini <sstabellini@kernel.org>
> Subject: [PATCH] automation: test.yaml: Introduce templates to reduce the
> overhead
>=20
> At the moment, we define lots of test jobs in test.yaml, that make use
> of the same configuration sections like variables, tags, artifacts.
> Introduce templates (hidden jobs whose names start with a dot) to
> reduce the overhead and simplify the file (more than 100 lines saved).
> This way, the actual jobs can only specify sections that are unique
> to them.
>=20
> Most of the test jobs specify the same set of prerequisite jobs under nee=
ds
> property with just one additional being unique to the job itself. Introdu=
ce
> YAML anchors for that purpose, because when using extends, the needs
> property
> is not being merged (the parent property overwrites the child one).
>=20
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> ---
> This patch is based on the CI next branch where we already have several
> patches (already acked) to be merged into staging after the release:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next
>=20
> Tested pipeline:
> https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-
> /pipelines/671114820

Looks good to me.

Reviewed-by: Jiamei.xie@arm.com



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426151.674437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpr-0002hM-4Q; Thu, 20 Oct 2022 06:15:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426151.674437; Thu, 20 Oct 2022 06:15:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpr-0002hF-0b; Thu, 20 Oct 2022 06:15:19 +0000
Received: by outflank-mailman (input) for mailman id 426151;
 Thu, 20 Oct 2022 06:15:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOpp-0002Ja-6e
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:17 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 90379fd6-503e-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 08:15:16 +0200 (CEST)
Received: from AS9PR06CA0600.eurprd06.prod.outlook.com (2603:10a6:20b:486::35)
 by AS2PR08MB9523.eurprd08.prod.outlook.com (2603:10a6:20b:60d::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 06:15:07 +0000
Received: from AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:486:cafe::f) by AS9PR06CA0600.outlook.office365.com
 (2603:10a6:20b:486::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT020.mail.protection.outlook.com (100.127.140.196) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 06:15:05 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Thu, 20 Oct 2022 06:15:05 +0000
Received: from c7705e2c8b9e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6E1C670D-88B7-4137-AAC2-83C9E54A50C5.1; 
 Thu, 20 Oct 2022 06:14:58 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7705e2c8b9e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:14:58 +0000
Received: from DB8PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:10:110::14)
 by PR3PR08MB5642.eurprd08.prod.outlook.com (2603:10a6:102:8b::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 06:14:56 +0000
Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:110:cafe::13) by DB8PR04CA0004.outlook.office365.com
 (2603:10a6:10:110::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Thu, 20 Oct 2022 06:14:56 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:14:56 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:14:55 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:14:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90379fd6-503e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=F9UCUmUwD3kv9LcrU1oZr+TsjCm5DEI5lu45oqlaSC/8JZZXF+psqyRtYmKePLJG0LDzTOPRCsPKIZnWN0MGQHGjqG64J88pia3uZI3Kk0kMAb6uoRNQRxfaMSAlt7yi9ZdQ8S6zRU9xEjbjRNeD0y6DAeOvlGVHYHC6oaAcrIVZOYN4MFzMzFcnOph5pvAv5wAHIz4VD8nvPdpjUlOn7hqMvYFE4/RYj03y76eCjxnglIyW10kLF5547SVdOZ/eR/9bnTOH/P+Rj0fjyErLaf4kgiEgVNJ9xZAEX0Wo27l21flTXRR3Jel/1Jr9PE/WDekMnQxqAmQC6U8vgLATmQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PCpgI2W9EASjdF75FsifWclntiKlW1ihr8b+D4Reccc=;
 b=fKDuq2TerZiaKILJq7lECO+5RA2uwe96ie4+L2CarvCA1nPkd+bF/r8GdJThtzAS0fVyGAjoBbYUlFRz2JpezBBhTuJsqAI7Q3XLk2IXo0Z5eNv/aw7lqaBl7lwBD7if3CzdR0IDDvoyWLZwxHKrIKqUxDxc5tnI+EuO1Q+5Kzu6Wh2WKNDzD/sW4GumfNmewjoTsR2gOe8rJlbjF4FExxTYD7et6dFETnaoPiGzPeeP2wjfPs4UFU1nM3W76GHwqy9AYlw6OWzhJOPf3mjYGF32dHpM95UlNRGdaoFal9F8XUiIXgzCu1u7R7YmBUrvQRMtcGiIYSvBWPCqnAPFog==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PCpgI2W9EASjdF75FsifWclntiKlW1ihr8b+D4Reccc=;
 b=7bAdbaTtf0ki3Z2qGXNYOlv7LGqMrDhAQ4C2aIwXzt7HkElbothVOdIJ4GpAl5viPp1ZI+S8uYEBgxTx8oXHMxW83v1mBbRgDNBrpV/KlOyCd1E0lfWwRxg7YcXjifS3oMaEPuEOe+WzSC6u7GCJWqUD8YOUSaWbgfMDoq7jPl4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5c0d0de74e907bae
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O0Z7qYDZxGjtyv9RlveFmv+nLNcG9N+Ke1QQsz3+1SygO4n7trk66ZudCsTG+QF6TE51qdeV858R2UzX/XqJiyMEV2zWQqy5e8S1qpkupzoMZzqRFzUGEdK3QF69AwT8hITiNiFxkUk7xZjuwqAXDm884iWcLiNXhdmPtLFVGN11q0NMWvw0FspCw3j3BApaST1QqLsxeIIu8Vn1IrBHGETRlKY5QKAj05oK5LC6k0CZHbJK1zWxPJDmw8NAm38nxZiKFm+hoadMfQIQTSZ1KOjym7/t2pFhyEHsdVHKKAOCWdToa42rE1Sx+3Gs1SmkY/ksoDO42uGeqWhM15ue8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PCpgI2W9EASjdF75FsifWclntiKlW1ihr8b+D4Reccc=;
 b=Y+8CjqoiUqMWuwxExIOZ2Oogv4UHOL5OBfMwJx4lyyJTfyz9halL7x0EhQHYYWniz5s6BR8oWBQvGFDr4dcHCZiqDENUXx4CB7k/brJpjQ64lfmDKryDgTY6MegxYv8RQR8NiInJXXhTZABypKkqHDa7QBO9bZBZpWphPiwpgLICDXsobvWoCNRtg20GDnlOiN5/y1agSegLe6RVKDAt2j1/M3kw8gfclgfPTJ0gI3xcl/7gfyBV03jwmwBuEIPZAuEPqTR3FZT3tdMx64tiYD4OxBjqKaNLIFBdTCohDfohVzeOuVZlMUxkFUgm8SdGlfZ9bzadbnnCMCb5f8sZsg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PCpgI2W9EASjdF75FsifWclntiKlW1ihr8b+D4Reccc=;
 b=7bAdbaTtf0ki3Z2qGXNYOlv7LGqMrDhAQ4C2aIwXzt7HkElbothVOdIJ4GpAl5viPp1ZI+S8uYEBgxTx8oXHMxW83v1mBbRgDNBrpV/KlOyCd1E0lfWwRxg7YcXjifS3oMaEPuEOe+WzSC6u7GCJWqUD8YOUSaWbgfMDoq7jPl4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>
Subject: [PATCH v7 1/6] xen/x86: Provide helpers for common code to access acpi_numa
Date: Thu, 20 Oct 2022 14:14:40 +0800
Message-ID: <20221020061445.288839-2-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221020061445.288839-1-wei.chen@arm.com>
References: <20221020061445.288839-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	DBAEUR03FT025:EE_|PR3PR08MB5642:EE_|AM7EUR03FT020:EE_|AS2PR08MB9523:EE_
X-MS-Office365-Filtering-Correlation-Id: fddc3ec7-ecd5-4c15-fb4f-08dab2626ea3
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 mrqJPOZx7rRf6s2jlvisqvhrBuzzn5cMsL8cp49f2P52a2LyLPLHSUpdzPiFtWfTcFdfeUiq2TXS3bcWI11aQylzjmXzePXJDA7RAzK+s0kSDs9UAFyo5Vj8bMyRu9RESYY0jNU+BC927AgY3tTwd7gf2nMnGWOrmhLnJ4HPehosChiBy1RhWPZYWaYP6qk5QFhrx7w9VdO9WgWsjJWZP02Imb88I62gUGmE65GlNtvI621ih4xgwV4KdPxkfCGzNCMSTrBbJ+hB6bjRA3x5zZuBHiYLIsDgqzTnRGYFI7AVJl5YmXXlKOaADt7jT0RsbLFkjzqkfK8fGTEjtKxqMsUWYXxXlGmM9wwBiaVNV6fa+1ovXIHcoZAUSQH4FnBz78heeV70r4p3njLjUH9GUhKShchqwtiGIOVa+7Z5ndDKJ7hxU/V8eDlIKivndPpyaxXFjbuSr2mwhf7Z0Uu5a8wH/Twthxm7MReiJjE3DBTm4Rkpyg31FPFsE2ZxLq5aoG7MIW7TGiffjk3xuJrzYEBXPSdyMXBO8bZ21Kh/kC9TsjSAnr/QC7YBHSF18S5aW4H8YSNw+9+RcDuYUpgvOumfvOSRGiYg9Q6rkr40kx73iUsynx8FzHYCKa2wFnU1O/5fNOdKYDsjwZAuiER8i6lGbz4sp/AY0yQKonc0Gtv81L+8HotklXKU0hhg4a4f29HOB2AHYxL1B87mj2l5oG2PHBPKt6sorRjcrF5um+RmdrvGicC5JEBmHgC4sBLOzZcgCgO8eziOjsBwH3CGOjNV3D8yC6P/tLTGylKjWX3xKYh4P01wap3XPvZGuinl
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(36840700001)(40470700004)(46966006)(2616005)(336012)(6666004)(186003)(1076003)(26005)(7696005)(36860700001)(426003)(83380400001)(2906002)(47076005)(5660300002)(40480700001)(44832011)(40460700003)(316002)(82310400005)(54906003)(6916009)(478600001)(8936002)(41300700001)(70206006)(4326008)(8676002)(70586007)(36756003)(86362001)(82740400003)(81166007)(356005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5642
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	201be532-b962-4700-1e54-08dab26268f4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+7hvon9wLcW8xm4p3d76k/preWyibXB/PDCqTRGUHATY9fLnyqcimXY9vC/2dWzv83lK9U57ptR80vBmRGe2dYuzw2RkgFi/9WPRk4dg96/of3QerzCE9cDY2JQUNAfk1U9dOsHCq+n3KOzPcbQNjARwzjS4cQBLFZGfyfT+ve1QB3CTJDI7r3MRtVYgvTqTvbhHE8mCdYcuhzEKe5uEDFPe6vLsVbMr5rm4gpuxroWeSmMjdWq1otEmgN4TJh3xIndWmMeqi1caHClNfisgLrvSaul6jEV7qLGNT5QGxxpCBCXYg9yrkepQP6APY8ti957spX2bDGkyU2oaCN6nARZF7BhQsD6iNOqSekZKDgWT6DYap+wyfIXXUUxKXm0QGQJPETXXBYYD15VphGPVfYPQu1ZUP2DOwOquKYI/lkkzdfRJUcgBSGm2HIr+kKXe90qmq5JT4iTpMxrmV3+c1ZUSXSO2jZ4bAngBJoNrya/Us0Bf/v0QO6vKHL/aXA3nXqOVwXv4CFsgooaXLq5mWXVMLQItka/fEJ+xEawqz8XVTGFXjm368xIv6fKadxp5DSXHXD/Sca1nCKXzpBelqwJUQMssJd8bMAiHN/JAeN1dkeZO6PVCX34hpSpTlhs93NszxYeY9o8jFr5zIuZof5DIHC96sfPOdd/I1RGfZF79KyX3IMfbW/iFOg96khexnwHKQi7dIUUK4DhcR4zXMXhOyL6yU7daU3dL7sRnGLqrF8/xClGffyBGfT4QmPpgvfnIm6tVCF6HydI5JYCRBQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(26005)(2616005)(6666004)(36860700001)(7696005)(83380400001)(186003)(1076003)(336012)(426003)(47076005)(2906002)(5660300002)(40480700001)(44832011)(40460700003)(8676002)(82310400005)(316002)(6916009)(478600001)(54906003)(41300700001)(70206006)(4326008)(70586007)(8936002)(86362001)(36756003)(82740400003)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:05.8501
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fddc3ec7-ecd5-4c15-fb4f-08dab2626ea3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9523

acpi_numa is a specific NUMA switch for ACPI NUMA implementation.
Other NUMA implementation may not need this switch. But this switch is
not only used by ACPI code, it is also used directly in some general
NUMA logic code. So far this hasn't caused any problem because Xen only
has x86 implementing ACPI NUMA, but now Arm is implementing device tree
based NUMA. Accesssing acpi_numa directly in some functions will be a
block of reusing NUMA common code. It is also difficult for us to replace
it with a new generic switch, because it is hard to prove that the new
switch states can guarantee the original code will work correctly.

So in this patch, we provide two helpers for common code to update and
get states of acpi_numa. And other new NUMA implementations just need
to provide the same helpers for common code. In this case, the generic
NUMA logic code can be reused by all NUMA implementations.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
v6 -> v7:
1. Add Rb.
v5 -> v6:
1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa
   can be set to -1 by users. So acpi_numa < 0 does not mean
   a broken firmware.
v4 -> v5:
1. Use arch_numa_broken instead of arch_numa_disabled for
   acpi_numa < 0 check. Because arch_numa_disabled might
   include acpi_numa < 0 (init failed) and acpi_numa == 0
   (no data or data no init) cases.
v3 -> v4:
1. Drop parameter from arch_numa_disabled, the parameter will be
   introduced in later patch where use it.
2. Drop unnecessary "else" from arch_numa_setup, and fix its
   indentation.
v2 -> v3:
1. Drop enumeration of numa status.
2. Use helpers to get/update acpi_numa.
3. Insert spaces among parameters of strncmp in numa_setup.
v1 -> v2:
1. Remove fw_numa.
2. Use enumeration to replace numa_off and acpi_numa.
3. Correct return value of srat_disabled.
4. Introduce numa_enabled_with_firmware.
---
 xen/arch/x86/include/asm/numa.h |  5 +++--
 xen/arch/x86/numa.c             | 38 ++++++++++++++++++++++-----------
 2 files changed, 28 insertions(+), 15 deletions(-)

diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index c32ccffde3..237f2c6dbf 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -32,8 +32,9 @@ extern void numa_add_cpu(int cpu);
 extern void numa_init_array(void);
 extern bool numa_off;
 
-
-extern int srat_disabled(void);
+extern int arch_numa_setup(const char *opt);
+extern bool arch_numa_disabled(void);
+extern bool srat_disabled(void);
 extern void numa_set_node(int cpu, nodeid_t node);
 extern nodeid_t setup_node(unsigned int pxm);
 extern void srat_detect_node(int cpu);
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 322157fab7..1c3198445d 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -50,9 +50,28 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
 bool numa_off;
 s8 acpi_numa = 0;
 
-int srat_disabled(void)
+int __init arch_numa_setup(const char *opt)
 {
-    return numa_off || acpi_numa < 0;
+#ifdef CONFIG_ACPI_NUMA
+    if ( !strncmp(opt, "noacpi", 6) )
+    {
+        numa_off = false;
+        acpi_numa = -1;
+        return 0;
+    }
+#endif
+
+    return -EINVAL;
+}
+
+bool arch_numa_disabled(void)
+{
+    return acpi_numa < 0;
+}
+
+bool srat_disabled(void)
+{
+    return numa_off || arch_numa_disabled();
 }
 
 /*
@@ -294,28 +313,21 @@ void numa_set_node(int cpu, nodeid_t node)
 /* [numa=off] */
 static int __init cf_check numa_setup(const char *opt)
 {
-    if ( !strncmp(opt,"off",3) )
+    if ( !strncmp(opt, "off", 3) )
         numa_off = true;
-    else if ( !strncmp(opt,"on",2) )
+    else if ( !strncmp(opt, "on", 2) )
         numa_off = false;
 #ifdef CONFIG_NUMA_EMU
     else if ( !strncmp(opt, "fake=", 5) )
     {
         numa_off = false;
-        numa_fake = simple_strtoul(opt+5,NULL,0);
+        numa_fake = simple_strtoul(opt + 5, NULL, 0);
         if ( numa_fake >= MAX_NUMNODES )
             numa_fake = MAX_NUMNODES;
     }
-#endif
-#ifdef CONFIG_ACPI_NUMA
-    else if ( !strncmp(opt,"noacpi",6) )
-    {
-        numa_off = false;
-        acpi_numa = -1;
-    }
 #endif
     else
-        return -EINVAL;
+        return arch_numa_setup(opt);
 
     return 0;
 } 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426150.674426 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpp-0002Qv-MF; Thu, 20 Oct 2022 06:15:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426150.674426; Thu, 20 Oct 2022 06:15:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpp-0002Qm-Il; Thu, 20 Oct 2022 06:15:17 +0000
Received: by outflank-mailman (input) for mailman id 426150;
 Thu, 20 Oct 2022 06:15:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOpo-0002BJ-MZ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:16 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140054.outbound.protection.outlook.com [40.107.14.54])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8ff4c3f8-503e-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:15:15 +0200 (CEST)
Received: from AM6PR10CA0057.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::34)
 by AS4PR08MB7805.eurprd08.prod.outlook.com (2603:10a6:20b:518::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 06:15:12 +0000
Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:80:cafe::50) by AM6PR10CA0057.outlook.office365.com
 (2603:10a6:209:80::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 06:15:12 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Thu, 20 Oct 2022 06:15:12 +0000
Received: from a3a542a781b0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2F040717-9E47-428C-962C-CFE91661B20A.1; 
 Thu, 20 Oct 2022 06:15:05 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3a542a781b0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:15:05 +0000
Received: from DU2PR04CA0260.eurprd04.prod.outlook.com (2603:10a6:10:28e::25)
 by DU0PR08MB8065.eurprd08.prod.outlook.com (2603:10a6:10:3e8::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 06:15:04 +0000
Received: from DBAEUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28e:cafe::d) by DU2PR04CA0260.outlook.office365.com
 (2603:10a6:10:28e::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:03 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DBAEUR03FT034.mail.protection.outlook.com (100.127.142.97) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:15:03 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:15:02 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:14:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ff4c3f8-503e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=LdR72guAIt3Su1zentttDKsz0W4J1uBfw0L2wWhcXzZlyxDZaUuWJJpxu6CNSM9z4cRU/GanDd+aDrMxuYFcK5Q7eEKerWQUd+7ex3UySysU/CWUb5TzOEK5r8TCkI9Md6TFUAEZ+OEXAJGqt/Ouq08gNiP6oS4OE+AOa+aMwKvukQz0qoAiD81g1a2RPY5ICa2mo4aWxJN9TJxpcxCHsdKRTp4XnWlD80/FWa5jnI2pdwa3VwtywMTuWutTZGFAaPR1Wrf60rOiE0qMSP06tH5/iVmbDOcSQP0SYhuNQyOzxSA6wFunHH1XPhrWeLAAhoATYV3XXYDVnJbOhGycJQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DvH9wa2333jE45Y3VR8tOi+XK23VkwLg26N4R4RSZFM=;
 b=B0DEjhYDmOa1BDE77LcwrED8IEhvbW+wl79xaIO6rME9oFMZ2wUzQnYlQH6t9v69hSjSi4rAYmf+iEdzT4imaRW+dWqBLk3xCLDeh1FgjJpjbdc4DjReSapY8ETgWbyYtpJfuOuY5lYrCP6V9uCdDCk/Iv2YRvhnLeHlc2zzVabwTRgJu9Tes77f9gaFPbLW8nky47He8ND9cc9r4ltHUngAwLEqTw9DJbZUr4Fix9oeiiWK6Gsy23amn7OsQquajeLJGBXU8vxaGGj0zkekMcrLYaud4Di3h89pe3JOqB+B5T9vABzdOSGLNKcCrbZLx0TJvuJfzx+pHRWRUHJjEg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DvH9wa2333jE45Y3VR8tOi+XK23VkwLg26N4R4RSZFM=;
 b=4dgmNuRZ7yjY9XI4VtTp9Ji56lgA0XHcdFMrcCKT8X8Ef7jDNK3PgA0pERqjEtEB+fQww0P3kLui8r+1UyS2OuHpiRJ6f4o15vhMXWSYfLgFoVEHI89fmDijUx1s2A1uV2TZ/vIKDnF30u5TIuBt5dKj4Bb0E5qr5PEr+yOryw0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2169fa7b3ed6e4c4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TrM88a7CkSS8QiASm+icfwUqapS8DILZsKQJ0/3UKWwasCJcBq7kZLTrGAS0pgEyjKkbiA5eS6cPOWJJ0/2FPilFxbz2huyNc1gk4n4QEZOl6alkOguTnccD3RPpxMqfP2koXDb6wzIr4LWhe/80fvf2exoY21pYItlsYK80rr0gI4XQ11dexj9GX56uyEH4VBGz5Kdi8xfmq5knAGlrOWTlfb+r9kXPKfgldkCBJxkJzZl7YeJdJL/PdvOIgXQqvZrmnPn6BbpzSx/IWH8+z1Ngn3NaKZ6kxclfwbDMHjmIIqxMj/n/33G3MHxCls49qaPx78JIhYOqG3L4VQiV1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DvH9wa2333jE45Y3VR8tOi+XK23VkwLg26N4R4RSZFM=;
 b=iKy0Y2j87oeyqh7dBC7/e+OZfbiN6IGLO3T8cu3yWy4qQ/SWJcUnDPORa+q/GlLwUJGzMVmXSjZYVDNUtU6M3XiPX9TyZ0mWXNXWpOunUQJnmVQ96Cu4r0tBhpekRVq0jI4KN0dEEBo70ZpnPcaSoimOFhz+Jl3oAehlyW0mNy8O4AwgqM6+ZVzMPW/r/1GBsMWchHmzVP0w0gvYrBLbYSDjUA9F2HhwIjQ/rlEY6/GIXBJE15g/C3UT4sCz4MrZJ9vyhQFTHsi0cmh8XTAIJBhfHKEKHMQrEI9nODwtbbvw16AY6muCJWAlU6dsH3J/kZAiKHV9l+YzZuTNx6GlKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DvH9wa2333jE45Y3VR8tOi+XK23VkwLg26N4R4RSZFM=;
 b=4dgmNuRZ7yjY9XI4VtTp9Ji56lgA0XHcdFMrcCKT8X8Ef7jDNK3PgA0pERqjEtEB+fQww0P3kLui8r+1UyS2OuHpiRJ6f4o15vhMXWSYfLgFoVEHI89fmDijUx1s2A1uV2TZ/vIKDnF30u5TIuBt5dKj4Bb0E5qr5PEr+yOryw0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Jiamei Xie
	<jiamei.xie@arm.com>
Subject: [PATCH v7 3/6] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid
Date: Thu, 20 Oct 2022 14:14:42 +0800
Message-ID: <20221020061445.288839-4-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221020061445.288839-1-wei.chen@arm.com>
References: <20221020061445.288839-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	DBAEUR03FT034:EE_|DU0PR08MB8065:EE_|AM7EUR03FT012:EE_|AS4PR08MB7805:EE_
X-MS-Office365-Filtering-Correlation-Id: 214bfbd9-7c83-43ce-380c-08dab262728a
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Mlo2Ei7OdBYJyXomd+fdEXzfb8c5tQRyB9IgAmQn8TDaDat8WZHcxsdwYrUKXDCeFxtAPk4S0gmldzaZYimttdxjjN3x6i382F1OCTWJvE0nT54+e0NeIbHV5Bccvhkuoz842Lk9F/uAxBaw5pSeqg1OYJ+STPFnSWhlRkW/q3ZEJvR062fup7fVsLt1AFuj05WVPdkNk5uTb7FWTsjwtAIVqNzbctsTBgX2KIA/YOM9Thxbg8yRyYlAXMhxw6O4FWKwuYaxCqqq+HhO2fQ0StX+zFI+tl1WkgDpq3PxmdT3tvFx/vDiu/zEA2cuhOxFTy9Z+BUD4UQ9MFcXWpC/c40yUMeNrgoKAEejTHnuPg84dIRz2e3+DrlSK0BGeUTULjhfWM+PAhf3jpFQeGGycRq+unjpu4cNANoyJQq5rGmICEcFo4/keE5Qj8TbS20YUPE006gjgEqEmvnmWmv7DjTT1kr1XtJ63ugRhPkyVNDb2c4CqXWdg0MRKNXESclftCJMCdZSDfU2soSa9/Kq99j5WjN+MogBxani+w9iWZr0U1BVPF29lfSHH1G63O/CwzknnlFzL/po6A/5r9l3pGSpvv1qIMejTrZWlBsEt11NRD6GPu+EyU4MnucOeEy7wr3o6KEwzdbnk03Sy3dmofxx0Mz4jcwfCLDnnG04UwwjBvxJb9Gpn+CHvAu+noLYHe4TzmfXIzvwPPHnV5zzDniH/4adKxRaRWclEh/OJjucPTd0+mpsa1g1OoIsBYk0VIQVEraRWOQP/I97rkMn4DeLy13XEqM1MtmUD1OWTqCQ7S/o3K4B9swhZ6Hz/WqA
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(83380400001)(336012)(36860700001)(40460700003)(8936002)(81166007)(356005)(5660300002)(44832011)(86362001)(82740400003)(41300700001)(4326008)(7696005)(82310400005)(2906002)(70586007)(186003)(6916009)(70206006)(6666004)(8676002)(316002)(54906003)(26005)(1076003)(40480700001)(2616005)(478600001)(426003)(36756003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8065
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5e7b836a-bb2c-49f9-fed4-08dab2626d46
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/FYKtd7BJem3fzSA/LpzYal88571gb1XmDzG3FH8owYXUzXL7b3XqPCezZ1ngo1rlR+g+vJfk+HDrLiinhNd8fzzceilW+inGVEoR56GGxLmsuaDq2eWCzeHsm2YmFZFomHzL62eSfiZmpDZV1jF3x1YkkBxSssnGq0Q0zqI7XI9pO2ltpGir8LYswji1wibarUQX/kK8j6pbdmTieiXl9JX3j8GnPmG6p3H0H9A3+X5N8+i14Wms1sYMc+KEKRqohLBKeuBPzd5W9L9jr7aCOi0yfI5d/dUGI5j9CW0UmByuDLpB9aAhBxcq693SZgVrId9CnDUsz9T1Utmkwv/0VdTktJVudvGcHKxGXgD2nfj43odt4/fVcHFxnvC/0RT3JXEqr+qkzHo13LptskndYVXCEfDMEqXX5iBd4PDICTBH5vD15MOzPxAFSL6JAntGAe5eGtPF5C4mqNL+9wzxMDIA4P1CJczEMNgSDceso6ZkV4EqIEpmZhsK2IqxgXFubzEoP01x37v0EzmFBafNLLIv+TySvxX3lpSDEogZ1tEWFZDd3MGsE40jfTzVwNR5t/Oi0VgMXiHdIxcMViopS50CZ9v0rOwmgITinS4e65ktZwYsyFL81C79QvmipwmuXi4os/1yadIgNsPHBPUPaqOaSAxDHGbGNGNvDPAS6vRqvcDD5YM5rvWXhZwREF9MdYhOsrd88IcziPKfs5QIW43eytOKX1nUFe3+DLz9z9DJUSm3Jv4e8Nlo+KaFHjgEWIIyjym8SUjy8EimMOSVA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(81166007)(40480700001)(40460700003)(36756003)(82310400005)(86362001)(41300700001)(26005)(8676002)(4326008)(6916009)(8936002)(7696005)(70206006)(44832011)(5660300002)(478600001)(6666004)(70586007)(316002)(2616005)(36860700001)(54906003)(82740400003)(47076005)(426003)(1076003)(186003)(336012)(2906002)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:12.3921
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 214bfbd9-7c83-43ce-380c-08dab262728a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7805

VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This
results in two lines of error-checking code in phys_to_nid
that is not actually working and causing two compilation
errors:
1. error: "MAX_NUMNODES" undeclared (first use in this function).
   This is because in the common header file, "MAX_NUMNODES" is
   defined after the common header file includes the ARCH header
   file, where phys_to_nid has attempted to use "MAX_NUMNODES".
   This error was resolved after we moved the phys_to_nid from
   x86 ARCH header file to common header file.
2. error: wrong type argument to unary exclamation mark.
   This is because, the error-checking code contains !node_data[nid].
   But node_data is a data structure variable, it's not a pointer.

So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to
enable the two lines of error-checking code. And fix the left
compilation errors by replacing !node_data[nid] to
!node_data[nid].node_spanned_pages. Although NUMA allows one node
can only have CPUs but without any memory. And node with 0 bytes
of memory might have an entry in memnodemap[] theoretically. But
that doesn't mean phys_to_nid can find any valid address from a
node with 0 bytes memory.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Tested-by: Jiamei Xie <jiamei.xie@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v6 -> v7:
1. No change.
v5 -> v6:
1. No change.
v4 -> v5:
1. No change.
v3 -> v4:
1. No change.
v2 -> v3:
1. Remove unnecessary change items in history.
2. Add Acked-by.
v1 -> v2:
1. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
2. Adjust the conditional express for ASSERT.
3. Refine the justification of using !node_data[nid].node_spanned_pages.
---
 xen/include/xen/numa.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 5b3877344b..04556f3a6f 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -35,8 +35,6 @@ struct node {
 extern int compute_hash_shift(const struct node *nodes,
                               unsigned int numnodes, const nodeid_t *nodeids);
 
-#define VIRTUAL_BUG_ON(x)
-
 extern bool numa_off;
 
 extern void numa_add_cpu(unsigned int cpu);
@@ -69,9 +67,9 @@ extern struct node_data node_data[];
 static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
 {
     nodeid_t nid;
-    VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
+    ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize);
     nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift];
-    VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]);
+    ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages);
     return nid;
 }
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426149.674415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpo-0002BW-E2; Thu, 20 Oct 2022 06:15:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426149.674415; Thu, 20 Oct 2022 06:15:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpo-0002BP-BF; Thu, 20 Oct 2022 06:15:16 +0000
Received: by outflank-mailman (input) for mailman id 426149;
 Thu, 20 Oct 2022 06:15:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOpn-0002BJ-NS
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:15 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8efec115-503e-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:15:14 +0200 (CEST)
Received: from AM6P192CA0063.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::40)
 by PAVPR08MB9137.eurprd08.prod.outlook.com (2603:10a6:102:30e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 06:15:11 +0000
Received: from VI1EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::f7) by AM6P192CA0063.outlook.office365.com
 (2603:10a6:209:82::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT034.mail.protection.outlook.com (100.127.144.165) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 06:15:10 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Thu, 20 Oct 2022 06:15:10 +0000
Received: from cf1711abba75.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F9B7CC05-392E-4380-81A8-125A50B85496.1; 
 Thu, 20 Oct 2022 06:15:04 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf1711abba75.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:15:04 +0000
Received: from DU2PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:10:3b::29)
 by AM7PR08MB5398.eurprd08.prod.outlook.com (2603:10a6:20b:103::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Thu, 20 Oct
 2022 06:14:53 +0000
Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:3b:cafe::f7) by DU2PR04CA0024.outlook.office365.com
 (2603:10a6:10:3b::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.25 via Frontend
 Transport; Thu, 20 Oct 2022 06:14:53 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:14:53 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:14:52 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:14:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8efec115-503e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=h5PzYrAUuUUYPhhhIGzUBxy27LQ1fog/2Q/jTnKpwPGjw0+0ePbtUa2eR8MjvNvD45QQD4+AkTIaFL10NqqoFKlGORj/bRf1k8cOqoB/GlkyuDIiQpsd4+cAGt4znryADsB+L9WAzhLa/HfiGA+ivQ5y06ZNZApjU8zv84w+IlSc//9AXax4RnlfqBRQjmopn4pLNwZKMvd6lStIplSTvb5jIA4oWj6A+X43TG4g+WXYaDKeAO8cOnXP3uhH5tB+eWHbFPshPQmhXv69ch/hC4Se/tyc3FmrcQvaB4dtQEjXOdRPW8MA2LRTTDIHASdKkzYOGP16xro55GFooOHx0w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZoKMoz/76/MRfADVFAivdFQhXqVUJOOH6Y4EzA36OxA=;
 b=hoJzgsl6nJuFscgyTDFBijTOLcdS7hJs0YjizMUiLG4GTyLiZqAWoyclSoT790eaMd2s8rKiVzM/hE1sKWAcqO+NjJMPomq4zpprFBWrXOT4rysPrIjdNe1HD8a4Gtp06w+F8pDgKkqrtB3TOwtZyTXzNWEzTKfEfYbNb521J6tvcBR4oksd5Hbgs+ptYmA5+4LUm5W25wPSmnOq4IOMBiVbreJUpzIFWMwNh+7z7sCzkXHFHreq/6co8Xhk4+UXaCzmHaxX7gnFWIJR4Z2QmQ6uZQf0JLHELmFxgdnd69qdA0qgLIfl1kIcawfRn62QXLcUUxgWgjqxbRAYRqByIA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZoKMoz/76/MRfADVFAivdFQhXqVUJOOH6Y4EzA36OxA=;
 b=tlUfp7a+uwdWIv4R9iceM6xlpsIDOR90y1GoU+ywEoaGdHqg2fjf8R2b/iBhsqCr/BCkPL4apU+hWqHgAvXayemWYq/xQ60RTgqOKqXfaFF9gkU0U14iYa4DnL+5gAR6MePFngtKW8k6EBXYUpW+znHX+pRkIPtlSM3sbPxQnN0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8c104a2a53f5f9d6
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E/vo/rQ9uX/kYYwYZjUPpC7oWm57kYzYYhrug2u13MNIsPJlAQW0t+jmFPk60Ku4DUOvOHauRK5FAmIrAHsDkPAUture8YN/Xn5ZWTwwvFCwwg7qvP3aAumB8whnIgRf5hN3aWLzWvI6zii0cXmMelpt8z8pSIhTm8YOtW+lMounns5g71bmLhYL4XtyBRypLThMazQKvuXMsYFl7EpzdZLTCePaDxL6AogAZL93RUxzNN0sgF7RELImz3dVTd+RozlwjnvdhImUHMWalheKiuRlNxzKPmv2MVwYMaHTaM7bXrfrPCG/AhCILI+e12JwGOgOD5zFuKtRUDdYY2F60A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZoKMoz/76/MRfADVFAivdFQhXqVUJOOH6Y4EzA36OxA=;
 b=Vo0hambz0kJT8a0KFP3JFhjh8z4KzgKFNXQkjb/0VX9sAgdVhgF/jMpZqHZ+W0qjK/8jf3SW/EosrnTh81xgdV9tCroiqaSN2om/X3GS8N0ARfHO0V4a2OZ3qo3kkPR7wZcuMIb3pdhs6forgfKDUVUB4pOIAhzQOhMMWQYOk56onDX0zE8WdkutUb/xf4eujjlVnjtiqygZCzeV67UEtH4i5NqvRCGzW1eMkn6CnSszhx5qYbJ95i6ztAr+yHmGGjIS8iOrxgwKKPNA56wbEx3RWV1hRm4WDPXkWLA35gM9MfeBYRl6lb5HrVN5XEBrq+P9uIMdXo+JC2COPvRErw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZoKMoz/76/MRfADVFAivdFQhXqVUJOOH6Y4EzA36OxA=;
 b=tlUfp7a+uwdWIv4R9iceM6xlpsIDOR90y1GoU+ywEoaGdHqg2fjf8R2b/iBhsqCr/BCkPL4apU+hWqHgAvXayemWYq/xQ60RTgqOKqXfaFF9gkU0U14iYa4DnL+5gAR6MePFngtKW8k6EBXYUpW+znHX+pRkIPtlSM3sbPxQnN0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v7 0/6] Device tree based NUMA support for Arm - Part#2
Date: Thu, 20 Oct 2022 14:14:39 +0800
Message-ID: <20221020061445.288839-1-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	DBAEUR03FT010:EE_|AM7PR08MB5398:EE_|VI1EUR03FT034:EE_|PAVPR08MB9137:EE_
X-MS-Office365-Filtering-Correlation-Id: 5c6936eb-af4d-4a59-671c-08dab26271a0
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /ZH2Za04rsW29OO3CkXfqX4MDPrpHFQ35sRdyyJkhLr1ZtvFkp9NVKS7e+IFuRDfB+18fTbVYeYZLgPP2eVmJ1vSNLgq+0Lc4hW6m/Y5/X6PpBJeLfemAK6RgfLKAqgMei0savVNV4sp74aQTNR5Be7J6drDClEKMKnBceTO64kdq7a3+4n6XOOSQlKKWf9RElJEkENxiUMuomkSh+aLCn7eomlAPJAjraAtjiqw6Le7L/6TkhiOqDtApRlAyUIe3xx4VZ0XztuSdnxthOx/krOgYw6Jn3rS/1O9PMA1KphVDp3OqNoTCc5uXYTGfKBvVORsvGQPHD514+IutqKWVpAAFB1csIbhsVqbAiAqQvll8J2PvL2qIhH9ArmMf+s+ndyDnHK1t663BoJ3Br+wB04ZQHwItyKrEH8I8nhA2VwQVRu1MmTkJQyF+/zaUB7AaAlAnrkWlyzgiiPXKtScX1Uzn7J7Yd17OKwmDzHhuKZQShVDoq8eakS4vGhtexSbB/gBoqywYK2xkD4Xur6WoEthPdE/Vv6GU5iymbUkhD7H8v4pH6lXsdgpNFrOQ4Kt8ps79RbpPI+Ho6bEesoPUZ9TxSX8vRAd/W3LMogn/n415N6zb/87KZjXrQKWcu8JabviQtBfcJBmO/TcnOu+USv0oBkCKtM5cqHiFFcAoDlQQ+Z5zzaKFUgu2FL1MOOO5ftCe7IrkkimVDdohUyVrjroheEk7tGqXW1dI77DZW1onzzl5h+Mu3gzcdsOIHDQUdBEFnm/Pb6guUTftvMCj+jJlevPDRV4lENzhqSvdnToRLCQIpail8uj7Cdpjx/SDi2fcfziCFso/R+PvPdt5Sreo7vWZXVZk5+4Lh6BHB++WTMkgn6VqESW+YuPsAQi
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199015)(36840700001)(46966006)(40470700004)(82740400003)(41300700001)(44832011)(4326008)(5660300002)(8936002)(336012)(6916009)(478600001)(1076003)(186003)(26005)(426003)(36756003)(70586007)(2616005)(86362001)(47076005)(7696005)(6666004)(83380400001)(82310400005)(8676002)(2906002)(36860700001)(70206006)(54906003)(966005)(316002)(81166007)(356005)(40460700003)(40480700001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5398
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4296eeea-31b9-4267-d681-08dab262673c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zGUu2+Le3lp+QG7cpCGsRszGMRtD90S9Sc2AuWMm5l0a7UGXlCWQNoPnsu8brioyp+v5aivHVX75Yxo/Bj+6OGLqmOFjcHjxStsG+vwltVwnx8zdYTJ1fAIsEdtHi+1Et8jx/tFmGlxgSqbFk+U735N9gosvgB92bcW4gbMoyLOVRotEWAw1jiBWf8RX+Rp3zsrYkgw/2eQXIMAzspbOYHnwAAezCvT+FoyJeLg5gIk5ZbU5AlESpMgBm7wGhaiw+qd05OOGFIMyaTDRcBorQwgfXhHbK+SUsbKgO0atW1GrFHzIIIJl+Vi9n9kffq2CuoQqyMfBuzymSBW2FfV6Acvo7punDVrvas4Cki2hE47FhBkgMuJPtK5V2LKQ8ZEohfZ3PqpMYz7IUhPJLd1qqy/u4in5kY7FoL986fIVezrrioq3TVClTEXolAJlPPmqak2Sv2myFNmAOI9tXDnOh4SD5gOqWOG0GGDujz54qGFMlCx8aNenBOfG1UxH1eGwnfJGoMfrYRnaQ1KjlCHeFc8HgTgCQ1aserFgPPicH8KrHw1qfBz0Mqd4LkIhg4EkkvSHZawDGkTd2RLXdbzQA4/RzF2fmC5qOGVyHTZfRB+tW1KKmIahtABrAVz6Ke2owZNvxdSDlH/+XprM7Hm9kDm0jxI3XAtijG9jZ41Y/GFbrBxrJylyKeEqEDYWH+m5QGMj382SVZy7zpE3fzU+zZrlomXI9Blrr6CgrQHr0+ckHPYEKoAOdLOhl7GDWkTDyfJYSVIL7CjSIaqfQtNgqtC/pqrxvXCN5WKQyhn96E+adr47S7DXx6J7MRsXyuSwXrdSeu6pgKArETakxU3eRw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199015)(36840700001)(40470700004)(46966006)(2616005)(1076003)(186003)(6666004)(107886003)(7696005)(36860700001)(47076005)(426003)(26005)(83380400001)(44832011)(336012)(40460700003)(2906002)(40480700001)(5660300002)(54906003)(316002)(478600001)(82310400005)(8676002)(8936002)(41300700001)(70586007)(4326008)(70206006)(966005)(6916009)(86362001)(36756003)(81166007)(82740400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:10.7973
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6936eb-af4d-4a59-671c-08dab26271a0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9137

(The Arm device tree based NUMA support patch set contains 35
patches. In order to make stuff easier for reviewers, I split
them into 3 parts:
1. Preparation. I have re-sorted the patch series. And moved
   independent patches to the head of the series - merged in [1]
2. Move generically usable code from x86 to common - this series.
3. Add new code to support Arm.

This series only contains the second part patches. As the whole NUMA
series has been reviewed for 1 round in [2], so this series would
be v7)

Xen memory allocation and scheduler modules are NUMA aware.
But actually, on x86 has implemented the architecture APIs
to support NUMA. Arm was providing a set of fake architecture
APIs to make it compatible with NUMA awared memory allocation
and scheduler.

Arm system was working well as a single node NUMA system with
these fake APIs, because we didn't have multiple nodes NUMA
system on Arm. But in recent years, more and more Arm devices
support multiple nodes NUMA system.

So now we have a new problem. When Xen is running on these Arm
devices, Xen still treat them as single node SMP systems. The
NUMA affinity capability of Xen memory allocation and scheduler
becomes meaningless. Because they rely on input data that does
not reflect real NUMA layout.

Xen still think the access time for all of the memory is the
same for all CPUs. However, Xen may allocate memory to a VM
from different NUMA nodes with different access speeds. This
difference can be amplified in workloads inside VM, causing
performance instability and timeouts.

So in this patch series, we implement a set of NUMA API to use
device tree to describe the NUMA layout. We reuse most of the
code of x86 NUMA to create and maintain the mapping between
memory and CPU, create the matrix between any two NUMA nodes.
Except ACPI and some x86 specified code, we have moved other
code to common. In next stage, when we implement ACPI based
NUMA for Arm64, we may move the ACPI NUMA code to common too,
but in current stage, we keep it as x86 only.

This patch serires has been tested and booted well on one
Arm64 NUMA machine and one HPE x86 NUMA machine.

[1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html

---
v6 -> v7:
 1. Restore %d for nodeid_t in dump_numa.
 2. Use sizeof(page_num_node) for page_num_node size in memset.
 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1)
    to calculate the shift when only one node is in the system.
 4. Use %pd for domain print in dump_numa.
 5. Add __init for arch_numa_unavailable.
 6. Use __ro_after_init for mem_hotplug.
 7. Use "???" instead of "NONAME" for unset numa_fw_nid_name.
 8. Fix code-style.
v5 -> v6:
 1. Revert arch_numa_broken to arch_numa_disabled, as acpi_numa
    can be set to -1 by users. So acpi_numa < 0 does not mean
    a broken firmware.
 2. Replace numa_scan_node to numa_process_nodes in commit log.
 3. Limit the scope of page_num_node, vnuma and page of numa_setup
    function.
 4. Use memset to init page_num_node instead of for_each_online_node.
 5. Use %u instead of %d for nodeid_t and j in numa_setup print
    messages.
 6. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift
    when only one node is in the system.
 7. Drop the marco: node_to_first_cpu(node)
 8. Use arch_numa_unavailable to replace arch_numa_disabled for
    acpi_numa <= 0.
 9. Remove Kconfig for HAS_NUMA_NODE_FWID.
10. Use numa_fw_nid_name for NUMA implementation to set their fw
    NUMA node name for print messages.

v4 -> v5:
 1. Use arch_numa_broken instead of arch_numa_disabled for
    acpi_numa < 0 check. Because arch_numa_disabled might
    include acpi_numa < 0 (init failed) and acpi_numa == 0
    (no data or data no init) cases.
 2. Use nodeid_t instead of uint8_t for memnodemap.
 3. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the
    further adjustments for _memnodemap's type.
 4. Use __ro_after_init for numa_off.
 5. Use pointer-to-const for proper function parameters.
 6. Use unsigned int for variables that are not realy used for node ID.
 7. Fix code comments code-style and adjust the length.
 8. Fix code-styles.
 9. Rename numa_scan_nodes to numa_process_nodes.
10. Defer introduce arch_numa_disabled for acpi_numa <= 0. And remove
    the paramter init_as_disable of arch_numa_disabled.
11. Fix typo "expandsion".
12. Fix Indentation for l1tf_safe_maddr.
13. Remove double blank lines.
14. Add a space between for_each_node_mask and '('.
    Add a space page_list_for_each and '('.
15. Use bool for nodes_cover_memory return value.
16. Use a plain "int ret" to record compute_hash_shift return value.
17. Add a blank line before the function's main "return".
18. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig.

v3 -> v4:
 1. Add init_as_disable as arch_numa_disabled parameter in the patche
    where use it.
 2. Drop unnecessary "else" from arch_numa_setup, and fix its
   indentation.
 3. Restore compute_hash_shift's return value to int.
 4. Remove unnecessary parentheses for macros.
 5. Use unsigned int for proper variables.
 6. Fix some code-style.
 7. Move arch_get_ram_range function comment to header file.
 8. Use bool for found, and add a new "err" for the return
    value of arch_get_ram_range.
 9. Use -ENODATA instead of -EINVAL for non-RAM type ranges.
10. Use bool as return value for functions that only return
    0/1 or 0/-EINVAL.
11. Move mem_hotplug to a proper place in mm.h
12. Remove useless "size" in numa_scan_nodes.
13. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping
    between node id and architectural node id (fw node id).

v2 -> v3:
 1. Drop enumeration of numa status.
 2. Use helpers to get/update acpi_numa.
 3. Insert spaces among parameters of strncmp in numa_setup.
 4. Drop helpers to access mem_hotplug. Export mem_hotplug for all arch.
 5. Remove acpi.h from common/numa.c.
 6. Rename acpi_scan_nodes to numa_scan_nodes.
 7. Replace u8 by uint8_t for memnodemap.
 8. Use unsigned int for memnode_shift and adjust related functions
    (compute_hash_shift, populate_memnodemap) to use correct types for
    return values or parameters.
 9. Use nodeid_t for nodeid and node numbers.
10. Use __read_mostly and __ro_after_init for appropriate variables.
11. Adjust the __read_mostly and __initdata location for some variables.
12. Convert from plain int to unsigned for cpuid and other proper 
13. Remove unnecessary change items in history.
14. Rename arch_get_memory_map to arch_get_ram_range.
15. Use -ENOENT instead of -ENODEV to indicate end of memory map.
16. Add description to code comment that arch_get_ram_range returns
    RAM range in [start, end) format.
17. Rename bad_srat to numa_fw_bad.
18. Rename node_to_pxm to numa_node_to_arch_nid.
19. Merge patch#7 and #8 into patch#6.
20. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h
22. Use 2-64 for node range.

v1 -> v2:
 1. Refine the commit messages of several patches.
 2. Merge v1 patch#9,10 into one patch. Introduce the new functions
    in the same patch that this patch will be used first time.
 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary,
    in this case, we can drop mem_hotplug_boundary.
 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa.
 5. Correct return value of srat_disabled.
 6. Introduce numa_enabled_with_firmware.
 7. Refine the justification of using !node_data[nid].node_spanned_pages.
 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid.
 9. Adjust the conditional express for ASSERT.
10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86.
11. Use conditional macro to gate MAX_NUMNODES for other architectures.
12. Use arch_get_memory_map to replace arch_get_memory_bank_range
    and arch_get_memory_bank_number.
13. Remove the !start || !end check, because caller guarantee
    these two pointers will not be NULL.
14. Add code comment for numa_update_node_memblks to explain:
    Assumes all memory regions belonging to a single node
    are in one chunk. Holes between them will be included
    in the node.
15. Merge this single patch instead of serval patches to move
    x86 SRAT code to common.
16. Export node_to_pxm to keep pxm information in NUMA scan
    nodes error messages.
17. Change the code style to target file's Xen code-style.
18. Adjust some __init and __initdata for some functions and
    variables.
19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts.
20. Turn numa_scan_nodes to static.
21. Change NR_NUMA_NODES upper bound from 4095 to 255.

Wei Chen (6):
  xen/x86: Provide helpers for common code to access acpi_numa
  xen/x86: move generically usable NUMA code from x86 to common
  xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid
  xen/x86: use arch_get_ram_range to get information from E820 map
  xen/x86: move NUMA process nodes nodes code from x86 to common
  xen: introduce a Kconfig option to configure NUMA nodes number

 xen/arch/Kconfig                 |  11 +
 xen/arch/x86/include/asm/acpi.h  |   2 -
 xen/arch/x86/include/asm/mm.h    |   2 -
 xen/arch/x86/include/asm/numa.h  |  61 +--
 xen/arch/x86/include/asm/setup.h |   1 -
 xen/arch/x86/mm.c                |   2 -
 xen/arch/x86/numa.c              | 441 +----------------
 xen/arch/x86/smpboot.c           |   2 +-
 xen/arch/x86/srat.c              | 335 +------------
 xen/common/Makefile              |   1 +
 xen/common/numa.c                | 803 +++++++++++++++++++++++++++++++
 xen/common/page_alloc.c          |   2 +
 xen/include/xen/mm.h             |   2 +
 xen/include/xen/numa.h           |  96 +++-
 14 files changed, 960 insertions(+), 801 deletions(-)
 create mode 100644 xen/common/numa.c

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426152.674448 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpu-00030X-DI; Thu, 20 Oct 2022 06:15:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426152.674448; Thu, 20 Oct 2022 06:15:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpu-00030N-97; Thu, 20 Oct 2022 06:15:22 +0000
Received: by outflank-mailman (input) for mailman id 426152;
 Thu, 20 Oct 2022 06:15:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOpr-0002BJ-UO
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:20 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2061.outbound.protection.outlook.com [40.107.103.61])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90e172a2-503e-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:15:17 +0200 (CEST)
Received: from AS9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:20b:462::7)
 by AM7PR08MB5528.eurprd08.prod.outlook.com (2603:10a6:20b:dd::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 06:15:14 +0000
Received: from VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:462:cafe::4b) by AS9PR06CA0002.outlook.office365.com
 (2603:10a6:20b:462::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:14 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT052.mail.protection.outlook.com (100.127.144.233) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 06:15:13 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Thu, 20 Oct 2022 06:15:13 +0000
Received: from 53115f174e26.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D310179B-5AED-4BE8-AB49-0AAC34B5BD27.1; 
 Thu, 20 Oct 2022 06:15:05 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 53115f174e26.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:15:05 +0000
Received: from AS9PR07CA0013.eurprd07.prod.outlook.com (2603:10a6:20b:46c::10)
 by DB9PR08MB9657.eurprd08.prod.outlook.com (2603:10a6:10:454::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 06:15:02 +0000
Received: from VI1EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46c:cafe::1e) by AS9PR07CA0013.outlook.office365.com
 (2603:10a6:20b:46c::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.18 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:01 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VI1EUR03FT035.mail.protection.outlook.com (100.127.145.20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Thu, 20 Oct 2022 06:15:00 +0000
Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:14:59 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com
 (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:14:58 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:14:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90e172a2-503e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=PWuaFkV9GEbEq4lN+Su9P4emPk+ODwF/HcAva9yKGXS4CMBbV2WrOhIa6o1RdrfI/1X4OXouPG9YYAooW0AbcmFljaTWC2MxZDSSZQ90irV0j5rOR7U8BZIOPtM5xjcgVyR9J7CewYxTWP+Iby28K92bihve3sP/bCQ6TFKg4KWyMnDL7PixuvzY6jSFnY72o3k6o/GtDl0CXb5FjzOxTl7PMbi4qBVHnapW7bAzEBWOovmrUq9gHmHZTKioIkQWM/Q0xYIf0XrEtze7NZsE+Y172CY0Y2kXDqyMXDYJufLJa3dkScDaHaMIo5KtrGzJtoBEmlP/x3PK9lazhsyJ+w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pWdcTC1qwCEU5Ak+1ld1rY8GQ+EKX/rWeM0UwGh2Ggk=;
 b=AltzOs+NmaC7RwUA/oUNuOzLZAnrg5A7S2RLXzUK4GyEfS64kcbdqR+y4lko6YlSKnhBqfwmgIB+eOtZplvO/UEjFF8KAsl+qgNclFMCNivfSmUVBJOCuraEMR6IUANxv+XGflIZ+GkIsOP9FJZ8NssupksGPC/SnUn5/hTph8gxhT1RXulWZnbwy/KgEYkMY71a5ppZ5hMrdyCu22s0RPdBsFNVlVMjghBJ2vxjTszV54huigHatJW44AJOmAhLaaY/Wovoq4btRGUS1NCHz/oXLdSvGrVmY34GevD3E2jUlCuw98jW3EvTD1eMVgyZCY73/DNWegJ4HGvWwKZu6g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pWdcTC1qwCEU5Ak+1ld1rY8GQ+EKX/rWeM0UwGh2Ggk=;
 b=aK/TndgMIZmpEs8WPVR3nIBNXCj84TtRguFeG88i+83vhbUDb9TnomMa+ru++RXNFANisTKDcf/uGZwtsTuudak3diODxktbwIZvKJD8vhy2cm48dKOfZpVEj+TWxq0MP43srFfwL+Fo1cXEyswT33kwmvwnAuQ8f/RMlUUQjaA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: b364045090ccceda
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j0COGSBXDe7DXq9044OLJZzSdrkIOPw4XKe4TV+RNsr3lmLi3t4Af8ULLHdLLRqeS/1ADm1vAR+AtGYUwbUpZ/+VpJ/sgNCRVw2IrRId8Cic8d81QygSD4qi+YVNClZ4K8VoIzPpIrVyJSPj1QKZEF5ni8bPPasKhO1Ia2cbxVoHbtNli0sm6DJLr9j4Vj93k397adnjxm4qZVe5aNjovnCJtmJ24uETSS6kwPfYRE5pchiBmghSGY3GkSssKKpdXVfHkDUUY2Y9FHOqgBzAgyPdHfnv/S6i5cng99kp6Tw5CDLw2Bw++uu/luSyUXAvI0KwdZrSAZflNk2zHlVVwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pWdcTC1qwCEU5Ak+1ld1rY8GQ+EKX/rWeM0UwGh2Ggk=;
 b=K1ovgHbuBLuX3435AnXrx/TlEwSPEqjSB0b0sRwAVpe71S97WC2TgR3ONxTyuRu7z3a0MhPMAR9vqLe9UCSitMHUToxvB0Kt7OHgp92pP9SL86Q9skIwYVvvmEB6O1K9Qc2cf6mO+N8aQPOg7LnehfgDNsmhQTzybPEjetki+n0rtWUzOHTbodr04APz6IzxV/JUtKudPQp4GW6HVtiIxn5ad2JGQIA7lUHJMKjOLgRRH7KwWBt9iQFYOZ15aLfQBevipE1ls/VbFkh2ig5hL7niG5Wj01aybBhDnvPPVUoyN1sVzFKqmq3l7dKYZHrVsFkAji0nEG3kivKn2epr5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pWdcTC1qwCEU5Ak+1ld1rY8GQ+EKX/rWeM0UwGh2Ggk=;
 b=aK/TndgMIZmpEs8WPVR3nIBNXCj84TtRguFeG88i+83vhbUDb9TnomMa+ru++RXNFANisTKDcf/uGZwtsTuudak3diODxktbwIZvKJD8vhy2cm48dKOfZpVEj+TWxq0MP43srFfwL+Fo1cXEyswT33kwmvwnAuQ8f/RMlUUQjaA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common
Date: Thu, 20 Oct 2022 14:14:41 +0800
Message-ID: <20221020061445.288839-3-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221020061445.288839-1-wei.chen@arm.com>
References: <20221020061445.288839-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	VI1EUR03FT035:EE_|DB9PR08MB9657:EE_|VI1EUR03FT052:EE_|AM7PR08MB5528:EE_
X-MS-Office365-Filtering-Correlation-Id: 9359f7d6-5cc5-46cd-8f93-08dab2627337
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 8NM7VPT7YUe6Ol11gTX5x6PQNHQxGb9t1Gad2Mt2mSQUiBCFJAxzvq3f4qa6VvPKsh3i9+ztcbJSTgS0gngFVxmqdEyGBwzZ/zHPXo8T6oXzI1hOF08V1a99FfFTVC09+nO+Rj9Z+sEKTW76ZYuPvv312mesvH6/PiiuQAhL1SU6L+087/XFkd0lXNsd28dMrvkMvAMqk6hOQK4edM4DYlZA+JGOdNU/ePsuoLEujHyN/7qY3/MWEeqcHkcA5anKRHBEL1FOlLF7Bs8+sPktpsOQ8ywWu0g8OSnUqSnUAYgkV9aITy3afwDBK18Sj0Nke/5y9MPZ1dV8xazB6vcvHHspnabbXX3xqT8B7NOMQ9lr6KW2I/DNwFxD4grZrpPGhdfx9XWHlg8j44alGrMxokaRfb6S8EdvI6uAajo/9ayNuvH6eMgNodUJ4x4LIkKcL06XCN66g6NjzyH86qSRQFnVUB7NdDs1MklPCawShRI0PM5KO2yPfnbfjT4LVEq7UOkVHDk2Cr9KzD3ox6ALFsBkiG3ENqz6xDmoJdLnSKfqFb2uMViNi3wbiVCNCJeK69P/aQWGIL2q3b3kCYDSe6POlIdgPg1SNPDQb0Iss79ycB+XeOQBcOWq8PogrXNJ58xIPJYDVVtCAFhWvTflXR1K+K44HrHbZnKoVzLLCGb+OQw7Xl8WyB6R+L+aMTN7mYvLH1qZn2/tFn23P8JkxuOIt9lqRa3lnBROGOrgmIJEPfW8apGosoADj4vUYUJNF2yEtGRz/Wf/i7zEnuQ8fNuZzoDedk0/dGg7ViO7G2dZidYDOfmOitiZNR9fMCi/CqmnJHmVRncMLUJkU7htJg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(40470700004)(46966006)(36840700001)(82740400003)(336012)(40460700003)(6666004)(36756003)(36860700001)(5660300002)(26005)(426003)(8936002)(2616005)(40480700001)(44832011)(30864003)(7696005)(8676002)(4326008)(70586007)(70206006)(1076003)(47076005)(186003)(86362001)(41300700001)(2906002)(82310400005)(478600001)(83380400001)(54906003)(6916009)(316002)(356005)(81166007)(21314003)(36900700001)(579004);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9657
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	8eea5e76-d835-4774-180b-08dab2626bbc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5VElSS42JLslK6EpwS8FqSGW+J7ZZgMW8rmr0HPkWhGo75IWlu/nxEs2zkD9/eMBPfLp1WDTNs3ayQUhdMl/NtFlJ17yLlMylVFCjRcOmSDrxplrPimYC69gaJ1BxAeA/5ku2IOjMZxPKugMTU/bN55/LSlAywjQ1t62xtHNiI5GuSluZ/Af4YmrllsnpJqTr1vq4YuTkeEYZIYShr3yTTCTneQKQpd8I49kAkNa5gEfCzuDiP6P5dHnuVrEM3JC/2Ldf1kpMN4zL9roSlAneUylyw19JhzjDBap+tawifmnLJ5D8yHzOZEgAIfLGXDaC7OOZ3IPUJRUIXw5hNRHGCroQqc0i/2sP6uCi5kZWPcqT1d2wG+Juw1VWVgZMtIdR/AAqA7TrJjzEKKf+y/+H1T0PMEWb8Zo+J2hvjzC5gvQ9O4NlnfR9SnIZpnfqfbs4QO2Chx49uXzK6tL3VfbycO4XlwIFyOd8Oi09AoS/kTeANV4ojobTiBKPcTnBF7L8DNliKmFPNJeii0G8x6GgDcDPLy27rT9oSVKNLHvAtruJmntjajrgQ079eDAdJj7rCg0bR+yn0inwnoVuX2WuY4PVNeoMilTcvTRvZXYjDQa73hDkRuOPTn53mCsQYosPAJ4Sn/Pmsf1UhdePiNL9iZSKBfkI35NH4uKkHOr2XlZ2QaMID88JQC9m62kvspTJLhFJ2lG9H9ZLollsEzPgCJu555ay7E8wS/8S7x6MfEAtjD+31/Q0UF2ZJP2GmDwfVjfhncJk86l3qbUO/OmpmXlfzDosDw12TxAx+mPk/c=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(2906002)(36860700001)(86362001)(5660300002)(30864003)(82740400003)(47076005)(54906003)(1076003)(44832011)(186003)(83380400001)(2616005)(81166007)(26005)(336012)(426003)(70206006)(82310400005)(316002)(70586007)(478600001)(7696005)(8676002)(6916009)(41300700001)(40480700001)(4326008)(36756003)(40460700003)(6666004)(8936002)(107886003)(21314003)(579004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:13.4500
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9359f7d6-5cc5-46cd-8f93-08dab2627337
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5528

There are some codes in x86/numa.c can be shared by common
architectures to implememnt NUMA support. Just like some
variables and functions to check and store NUMA memory map.
And some variables and functions to do NUMA initialization.

In this patch, we move them to common/numa.c and xen/numa.h
and use the CONFIG_NUMA to gate them for non-NUMA supported
architectures. As the target header file is Xen-style, so
we trim some spaces and replace tabs for the codes that has
been moved to xen/numa.h at the same time.

As acpi_scan_nodes has been used in a common function, it
doesn't make sense to use acpi_xxx in common code, so we
rename it to numa_process_nodes in this patch too. After that
if we still use CONFIG_ACPI_NUMA in to gate numa_process_nodes
in numa_initmem_init, that doesn't make sense. As CONFIG_NUMA
will be selected by CONFIG_ACPI_NUMA for x86. So, we replace
CONFIG_ACPI_NUMA by CONFIG_NUMA to gate numa_process_nodes.

As arch_numa_disabled has been implememnted for ACPI NUMA,
we can rename srat_disabled to numa_disabled and move it
to common code as well.

The macro node_to_first_cpu(node) hasn't been used anywhere,
so we drop it in this patch too.

Because some architectures allow to use all 64 physical address
bits, but some architectures are not (like Arm64 allows 52, 48
bits). In this case, we use min(PADDR_BITS, BITS_PER_LONG - 1)
to calculate the shift when only one node is in the system in
this patch too.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v6 -> v7:
 1. Restore %d for nodeid_t in dump_numa.
 2. Use sizeof(page_num_node) for page_num_node size in memset.
 3. Add description for using min(PADDR_BITS, BITS_PER_LONG - 1)
    to calculate the shift when only one node is in the system.
 4. Use %pd for domain print.
v5 -> v6:
 1. Replace numa_scan_node to numa_process_nodes in commit log.
 2. Limit the scope of page_num_node, vnuma and page of numa_setup
    function.
 3. Use memset to init page_num_node instead of for_each_online_node.
 4. Use %u instead of %d for nodeid_t and j in numa_setup print
    messages.
 5. Use min(PADDR_BITS, BITS_PER_LONG - 1) to calculate the shift
    when only one node is in the system.
 6. Drop the marco: node_to_first_cpu(node)
v4 -> v5:
 1. Use nodeid_t instead of uint8_t for memnodemap.
 2. Restore to use typeof(*memnodemap) for _memnodemap, this will avoid the
    further adjustments for _memnodemap's type.
 3. Use __ro_after_init for numa_off.
 4. Use pointer-to-const for proper function parameters.
 5. Use unsigned int for variables that are not realy used for node ID.
 6. Fix code comments code-style and adjust the length.
 7. Fix code-styles.
 8. Rename numa_scan_nodes to numa_process_nodes.
 9. Use a plain "int ret" to record compute_hash_shift return value.
v3 -> v4:
 1. Restore compute_hash_shift's return value to int.
 2. Remove unnecessary parentheses for macros.
 3. Use unsigned int for proper variables.
 4. Fix some code-style.
v2 -> v3:
 1. Remove acpi.h from common/numa.c.
 2. Rename acpi_scan_nodes to numa_scan_nodes.
 3. Replace u8 by uint8_t for memnodemap.
 4. Use unsigned int for memnode_shift and adjust related functions
    (compute_hash_shift, populate_memnodemap) to use correct types for
    return values or parameters.
 5. Use nodeid_t for nodeid and node numbers.
 6. Use __read_mostly and __ro_after_init for appropriate variables.
 7. Adjust the __read_mostly and __initdata location for some variables.
 8. convert from plain int to unsigned for cpuid and other proper variables.
 9. Use __attribute_pure__ instead of __attribute__((pure)).
10. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA in numa_initmem_init.
11. Add const for some functions' parameters.
12. Move srat_disabled to common code with new name numa_disabled.
13. Fix some spaces code-style for numa_emulation.
14. Change from int to unsigned int for numa_fake.
v1 -> v2:
1. New patch in v2.
---
 xen/arch/x86/include/asm/acpi.h  |   1 -
 xen/arch/x86/include/asm/numa.h  |  57 +---
 xen/arch/x86/include/asm/setup.h |   1 -
 xen/arch/x86/numa.c              | 433 +---------------------------
 xen/arch/x86/smpboot.c           |   2 +-
 xen/arch/x86/srat.c              |  10 +-
 xen/common/Makefile              |   1 +
 xen/common/numa.c                | 464 +++++++++++++++++++++++++++++++
 xen/include/xen/numa.h           |  66 +++++
 9 files changed, 539 insertions(+), 496 deletions(-)
 create mode 100644 xen/common/numa.c

diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h
index 9a9cc4c240..5c2dd5da2d 100644
--- a/xen/arch/x86/include/asm/acpi.h
+++ b/xen/arch/x86/include/asm/acpi.h
@@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address;
 #define ARCH_HAS_POWER_INIT	1
 
 extern s8 acpi_numa;
-extern int acpi_scan_nodes(u64 start, u64 end);
 #define NR_NODE_MEMBLKS (MAX_NUMNODES*2)
 
 extern struct acpi_sleep_info acpi_sinfo;
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 237f2c6dbf..6c87942d43 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -9,72 +9,17 @@ typedef u8 nodeid_t;
 
 extern int srat_rev;
 
-extern nodeid_t      cpu_to_node[NR_CPUS];
-extern cpumask_t     node_to_cpumask[];
-
-#define cpu_to_node(cpu)		(cpu_to_node[cpu])
-#define parent_node(node)		(node)
-#define node_to_first_cpu(node)  (__ffs(node_to_cpumask[node]))
-#define node_to_cpumask(node)    (node_to_cpumask[node])
-
-struct node { 
-	paddr_t start, end;
-};
-
-extern int compute_hash_shift(struct node *nodes, int numnodes,
-			      nodeid_t *nodeids);
 extern nodeid_t pxm_to_node(unsigned int pxm);
 
 #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
-#define VIRTUAL_BUG_ON(x) 
 
-extern void numa_add_cpu(int cpu);
-extern void numa_init_array(void);
-extern bool numa_off;
-
-extern int arch_numa_setup(const char *opt);
-extern bool arch_numa_disabled(void);
-extern bool srat_disabled(void);
-extern void numa_set_node(int cpu, nodeid_t node);
+extern bool numa_disabled(void);
 extern nodeid_t setup_node(unsigned int pxm);
 extern void srat_detect_node(int cpu);
 
-extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
 extern nodeid_t apicid_to_node[];
 extern void init_cpu_to_node(void);
 
-static inline void clear_node_cpumask(int cpu)
-{
-	cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
-}
-
-/* Simple perfect hash to map pdx to node numbers */
-extern int memnode_shift; 
-extern unsigned long memnodemapsize;
-extern u8 *memnodemap;
-
-struct node_data {
-    unsigned long node_start_pfn;
-    unsigned long node_spanned_pages;
-};
-
-extern struct node_data node_data[];
-
-static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr)
-{ 
-	nodeid_t nid;
-	VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
-	nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; 
-	VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); 
-	return nid; 
-} 
-
-#define NODE_DATA(nid)		(&(node_data[nid]))
-
-#define node_start_pfn(nid)	(NODE_DATA(nid)->node_start_pfn)
-#define node_spanned_pages(nid)	(NODE_DATA(nid)->node_spanned_pages)
-#define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
-				 NODE_DATA(nid)->node_spanned_pages)
 #define arch_want_default_dmazone() (num_online_nodes() > 1)
 
 extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h
index 21037b7f31..ae470ea12f 100644
--- a/xen/arch/x86/include/asm/setup.h
+++ b/xen/arch/x86/include/asm/setup.h
@@ -20,7 +20,6 @@ void early_time_init(void);
 
 void set_nr_cpu_ids(unsigned int max_cpus);
 
-void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
 void arch_init_memory(void);
 void subarch_init_memory(void);
 
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 1c3198445d..90b2a22591 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -4,20 +4,11 @@
  * Adapted for Xen: Ryan Harper <ryanh@us.ibm.com>
  */ 
 
-#include <xen/mm.h>
-#include <xen/string.h>
 #include <xen/init.h>
-#include <xen/ctype.h>
+#include <xen/mm.h>
 #include <xen/nodemask.h>
 #include <xen/numa.h>
-#include <xen/keyhandler.h>
-#include <xen/param.h>
-#include <xen/time.h>
-#include <xen/smp.h>
-#include <xen/pfn.h>
 #include <asm/acpi.h>
-#include <xen/sched.h>
-#include <xen/softirq.h>
 
 #ifndef Dprintk
 #define Dprintk(x...)
@@ -26,28 +17,13 @@
 /* from proto.h */
 #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1)))
 
-struct node_data node_data[MAX_NUMNODES];
-
-/* Mapping from pdx to node id */
-int memnode_shift;
-static typeof(*memnodemap) _memnodemap[64];
-unsigned long memnodemapsize;
-u8 *memnodemap;
-
-nodeid_t cpu_to_node[NR_CPUS] __read_mostly = {
-    [0 ... NR_CPUS-1] = NUMA_NO_NODE
-};
 /*
  * Keep BIOS's CPU2node information, should not be used for memory allocaion
  */
 nodeid_t apicid_to_node[MAX_LOCAL_APIC] = {
     [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE
 };
-cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly;
 
-nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
-
-bool numa_off;
 s8 acpi_numa = 0;
 
 int __init arch_numa_setup(const char *opt)
@@ -69,270 +45,6 @@ bool arch_numa_disabled(void)
     return acpi_numa < 0;
 }
 
-bool srat_disabled(void)
-{
-    return numa_off || arch_numa_disabled();
-}
-
-/*
- * Given a shift value, try to populate memnodemap[]
- * Returns :
- * 1 if OK
- * 0 if memnodmap[] too small (of shift too small)
- * -1 if node overlap or lost ram (shift too big)
- */
-static int __init populate_memnodemap(const struct node *nodes,
-                                      int numnodes, int shift, nodeid_t *nodeids)
-{
-    int i, res = -1;
-
-    memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap));
-    for ( i = 0; i < numnodes; i++ )
-    {
-        unsigned long spdx = paddr_to_pdx(nodes[i].start);
-        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1);
-
-        if ( spdx > epdx )
-            continue;
-        if ( (epdx >> shift) >= memnodemapsize )
-            return 0;
-        do {
-            if ( memnodemap[spdx >> shift] != NUMA_NO_NODE &&
-                 (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) )
-                return -1;
-
-            if ( !nodeids )
-                memnodemap[spdx >> shift] = i;
-            else
-                memnodemap[spdx >> shift] = nodeids[i];
-
-            spdx += (1UL << shift);
-        } while ( spdx <= epdx );
-        res = 1;
-    }
-
-    return res;
-}
-
-static int __init allocate_cachealigned_memnodemap(void)
-{
-    unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap));
-    unsigned long mfn = mfn_x(alloc_boot_pages(size, 1));
-
-    memnodemap = mfn_to_virt(mfn);
-    mfn <<= PAGE_SHIFT;
-    size <<= PAGE_SHIFT;
-    printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n",
-           mfn, mfn + size);
-    memnodemapsize = size / sizeof(*memnodemap);
-
-    return 0;
-}
-
-/*
- * The LSB of all start addresses in the node map is the value of the
- * maximum possible shift.
- */
-static int __init extract_lsb_from_nodes(const struct node *nodes,
-                                         int numnodes, const nodeid_t *nodeids)
-{
-    int i, nodes_used = 0;
-    unsigned long spdx, epdx;
-    unsigned long bitfield = 0, memtop = 0;
-
-    for ( i = 0; i < numnodes; i++ )
-    {
-        spdx = paddr_to_pdx(nodes[i].start);
-        epdx = paddr_to_pdx(nodes[i].end - 1) + 1;
-        if ( spdx >= epdx )
-            continue;
-        if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) )
-            bitfield |= spdx;
-        if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] )
-            nodes_used++;
-        if ( epdx > memtop )
-            memtop = epdx;
-    }
-    if ( nodes_used <= 1 )
-        i = BITS_PER_LONG - 1;
-    else
-        i = find_first_bit(&bitfield, sizeof(unsigned long)*8);
-    memnodemapsize = ((memtop - 1) >> i) + 1;
-    return i;
-}
-
-int __init compute_hash_shift(struct node *nodes, int numnodes,
-                              nodeid_t *nodeids)
-{
-    int shift;
-
-    shift = extract_lsb_from_nodes(nodes, numnodes, nodeids);
-    if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) )
-        memnodemap = _memnodemap;
-    else if ( allocate_cachealigned_memnodemap() )
-        return -1;
-    printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift);
-
-    if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 )
-    {
-        printk(KERN_INFO "Your memory is not aligned you need to "
-               "rebuild your hypervisor with a bigger NODEMAPSIZE "
-               "shift=%d\n", shift);
-        return -1;
-    }
-
-    return shift;
-}
-/* initialize NODE_DATA given nodeid and start/end */
-void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
-{
-    unsigned long start_pfn = paddr_to_pfn(start);
-    unsigned long end_pfn = paddr_to_pfn(end);
-
-    NODE_DATA(nodeid)->node_start_pfn = start_pfn;
-    NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn;
-
-    node_set_online(nodeid);
-} 
-
-void __init numa_init_array(void)
-{
-    int rr, i;
-
-    /* There are unfortunately some poorly designed mainboards around
-       that only connect memory to a single CPU. This breaks the 1:1 cpu->node
-       mapping. To avoid this fill in the mapping for all possible
-       CPUs, as the number of CPUs is not known yet.
-       We round robin the existing nodes. */
-    rr = first_node(node_online_map);
-    for ( i = 0; i < nr_cpu_ids; i++ )
-    {
-        if ( cpu_to_node[i] != NUMA_NO_NODE )
-            continue;
-        numa_set_node(i, rr);
-        rr = cycle_node(rr, node_online_map);
-    }
-}
-
-#ifdef CONFIG_NUMA_EMU
-static int numa_fake __initdata = 0;
-
-/* Numa emulation */
-static int __init numa_emulation(unsigned long start_pfn,
-                                 unsigned long end_pfn)
-{
-    int i;
-    struct node nodes[MAX_NUMNODES];
-    uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake;
-
-    /* Kludge needed for the hash function */
-    if ( hweight64(sz) > 1 )
-    {
-        u64 x = 1;
-        while ( (x << 1) < sz )
-            x <<= 1;
-        if ( x < sz/2 )
-            printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n");
-        sz = x;
-    }
-
-    memset(&nodes,0,sizeof(nodes));
-    for ( i = 0; i < numa_fake; i++ )
-    {
-        nodes[i].start = pfn_to_paddr(start_pfn) + i * sz;
-        if ( i == numa_fake - 1 )
-            sz = pfn_to_paddr(end_pfn) - nodes[i].start;
-        nodes[i].end = nodes[i].start + sz;
-        printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n",
-               i,
-               nodes[i].start, nodes[i].end,
-               (nodes[i].end - nodes[i].start) >> 20);
-        node_set_online(i);
-    }
-    memnode_shift = compute_hash_shift(nodes, numa_fake, NULL);
-    if ( memnode_shift < 0 )
-    {
-        memnode_shift = 0;
-        printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n");
-        return -1;
-    }
-    for_each_online_node ( i )
-        setup_node_bootmem(i, nodes[i].start, nodes[i].end);
-    numa_init_array();
-
-    return 0;
-}
-#endif
-
-void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
-{ 
-    int i;
-    paddr_t start = pfn_to_paddr(start_pfn);
-    paddr_t end = pfn_to_paddr(end_pfn);
-
-#ifdef CONFIG_NUMA_EMU
-    if ( numa_fake && !numa_emulation(start_pfn, end_pfn) )
-        return;
-#endif
-
-#ifdef CONFIG_ACPI_NUMA
-    if ( !numa_off && !acpi_scan_nodes(start, end) )
-        return;
-#endif
-
-    printk(KERN_INFO "%s\n",
-           numa_off ? "NUMA turned off" : "No NUMA configuration found");
-
-    printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n",
-           start, end);
-    /* setup dummy node covering all memory */
-    memnode_shift = BITS_PER_LONG - 1;
-    memnodemap = _memnodemap;
-    /* Dummy node only uses 1 slot in reality */
-    memnodemap[0] = 0;
-    memnodemapsize = 1;
-
-    nodes_clear(node_online_map);
-    node_set_online(0);
-    for ( i = 0; i < nr_cpu_ids; i++ )
-        numa_set_node(i, 0);
-    cpumask_copy(&node_to_cpumask[0], cpumask_of(0));
-    setup_node_bootmem(0, start, end);
-}
-
-void numa_add_cpu(int cpu)
-{
-    cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
-} 
-
-void numa_set_node(int cpu, nodeid_t node)
-{
-    cpu_to_node[cpu] = node;
-}
-
-/* [numa=off] */
-static int __init cf_check numa_setup(const char *opt)
-{
-    if ( !strncmp(opt, "off", 3) )
-        numa_off = true;
-    else if ( !strncmp(opt, "on", 2) )
-        numa_off = false;
-#ifdef CONFIG_NUMA_EMU
-    else if ( !strncmp(opt, "fake=", 5) )
-    {
-        numa_off = false;
-        numa_fake = simple_strtoul(opt + 5, NULL, 0);
-        if ( numa_fake >= MAX_NUMNODES )
-            numa_fake = MAX_NUMNODES;
-    }
-#endif
-    else
-        return arch_numa_setup(opt);
-
-    return 0;
-} 
-custom_param("numa", numa_setup);
-
 /*
  * Setup early cpu_to_node.
  *
@@ -381,146 +93,3 @@ unsigned int __init arch_get_dma_bitsize(void)
                  flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1)
                  + PAGE_SHIFT, 32);
 }
-
-static void cf_check dump_numa(unsigned char key)
-{
-    s_time_t now = NOW();
-    unsigned int i, j, n;
-    struct domain *d;
-    struct page_info *page;
-    unsigned int page_num_node[MAX_NUMNODES];
-    const struct vnuma_info *vnuma;
-
-    printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key,
-           now);
-
-    for_each_online_node ( i )
-    {
-        paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1);
-
-        printk("NODE%u start->%lu size->%lu free->%lu\n",
-               i, node_start_pfn(i), node_spanned_pages(i),
-               avail_node_heap_pages(i));
-        /* sanity check phys_to_nid() */
-        if ( phys_to_nid(pa) != i )
-            printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n",
-                   pa, phys_to_nid(pa), i);
-    }
-
-    j = cpumask_first(&cpu_online_map);
-    n = 0;
-    for_each_online_cpu ( i )
-    {
-        if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] )
-        {
-            if ( n > 1 )
-                printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]);
-            else
-                printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]);
-            j = i;
-            n = 1;
-        }
-        else
-            ++n;
-    }
-    if ( n > 1 )
-        printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]);
-    else
-        printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]);
-
-    rcu_read_lock(&domlist_read_lock);
-
-    printk("Memory location of each domain:\n");
-    for_each_domain ( d )
-    {
-        process_pending_softirqs();
-
-        printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d));
-
-        for_each_online_node ( i )
-            page_num_node[i] = 0;
-
-        spin_lock(&d->page_alloc_lock);
-        page_list_for_each(page, &d->page_list)
-        {
-            i = phys_to_nid(page_to_maddr(page));
-            page_num_node[i]++;
-        }
-        spin_unlock(&d->page_alloc_lock);
-
-        for_each_online_node ( i )
-            printk("    Node %u: %u\n", i, page_num_node[i]);
-
-        if ( !read_trylock(&d->vnuma_rwlock) )
-            continue;
-
-        if ( !d->vnuma )
-        {
-            read_unlock(&d->vnuma_rwlock);
-            continue;
-        }
-
-        vnuma = d->vnuma;
-        printk("     %u vnodes, %u vcpus, guest physical layout:\n",
-               vnuma->nr_vnodes, d->max_vcpus);
-        for ( i = 0; i < vnuma->nr_vnodes; i++ )
-        {
-            unsigned int start_cpu = ~0U;
-
-            if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE )
-                printk("       %3u: pnode ???,", i);
-            else
-                printk("       %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]);
-
-            printk(" vcpus ");
-
-            for ( j = 0; j < d->max_vcpus; j++ )
-            {
-                if ( !(j & 0x3f) )
-                    process_pending_softirqs();
-
-                if ( vnuma->vcpu_to_vnode[j] == i )
-                {
-                    if ( start_cpu == ~0U )
-                    {
-                        printk("%d", j);
-                        start_cpu = j;
-                    }
-                }
-                else if ( start_cpu != ~0U )
-                {
-                    if ( j - 1 != start_cpu )
-                        printk("-%d ", j - 1);
-                    else
-                        printk(" ");
-                    start_cpu = ~0U;
-                }
-            }
-
-            if ( start_cpu != ~0U  && start_cpu != j - 1 )
-                printk("-%d", j - 1);
-
-            printk("\n");
-
-            for ( j = 0; j < vnuma->nr_vmemranges; j++ )
-            {
-                if ( vnuma->vmemrange[j].nid == i )
-                    printk("           %016"PRIx64" - %016"PRIx64"\n",
-                           vnuma->vmemrange[j].start,
-                           vnuma->vmemrange[j].end);
-            }
-        }
-
-        read_unlock(&d->vnuma_rwlock);
-    }
-
-    rcu_read_unlock(&domlist_read_lock);
-}
-
-static int __init cf_check register_numa_trigger(void)
-{
-    register_keyhandler('u', dump_numa, "dump NUMA info", 1);
-    return 0;
-}
-__initcall(register_numa_trigger);
-
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index b46fd9ab18..9df08e9366 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -1350,7 +1350,7 @@ int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm)
 
     x86_acpiid_to_apicid[acpi_id] = apic_id;
 
-    if ( !srat_disabled() )
+    if ( !numa_disabled() )
     {
         nodeid_t node = setup_node(pxm);
 
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index fbcd8749c4..ce507dac9e 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -238,7 +238,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa)
 	unsigned pxm;
 	nodeid_t node;
 
-	if (srat_disabled())
+	if (numa_disabled())
 		return;
 	if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) {
 		bad_srat();
@@ -274,7 +274,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 	unsigned pxm;
 	nodeid_t node;
 
-	if (srat_disabled())
+	if (numa_disabled())
 		return;
 	if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) {
 		bad_srat();
@@ -314,7 +314,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 	unsigned int i;
 	bool next = false;
 
-	if (srat_disabled())
+	if (numa_disabled())
 		return;
 	if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) {
 		bad_srat();
@@ -543,8 +543,8 @@ void __init srat_parse_regions(paddr_t addr)
 	pfn_pdx_hole_setup(mask >> PAGE_SHIFT);
 }
 
-/* Use the information discovered above to actually set up the nodes. */
-int __init acpi_scan_nodes(paddr_t start, paddr_t end)
+/* Use discovered information to actually set up the nodes. */
+int __init numa_process_nodes(paddr_t start, paddr_t end)
 {
 	int i;
 	nodemask_t all_nodes_parsed;
diff --git a/xen/common/Makefile b/xen/common/Makefile
index 3baf83d527..9a3a12b12d 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o
 obj-y += memory.o
 obj-y += multicall.o
 obj-y += notifier.o
+obj-$(CONFIG_NUMA) += numa.o
 obj-y += page_alloc.o
 obj-$(CONFIG_HAS_PDX) += pdx.o
 obj-$(CONFIG_PERF_COUNTERS) += perfc.o
diff --git a/xen/common/numa.c b/xen/common/numa.c
new file mode 100644
index 0000000000..a435a07db9
--- /dev/null
+++ b/xen/common/numa.c
@@ -0,0 +1,464 @@
+/*
+ * Generic VM initialization for NUMA setups.
+ * Copyright 2002,2003 Andi Kleen, SuSE Labs.
+ * Adapted for Xen: Ryan Harper <ryanh@us.ibm.com>
+ */
+
+#include <xen/init.h>
+#include <xen/keyhandler.h>
+#include <xen/mm.h>
+#include <xen/nodemask.h>
+#include <xen/numa.h>
+#include <xen/param.h>
+#include <xen/sched.h>
+#include <xen/softirq.h>
+
+struct node_data __ro_after_init node_data[MAX_NUMNODES];
+
+/* Mapping from pdx to node id */
+unsigned int __ro_after_init memnode_shift;
+unsigned long __ro_after_init memnodemapsize;
+nodeid_t *__ro_after_init memnodemap;
+static typeof(*memnodemap) __ro_after_init _memnodemap[64];
+
+nodeid_t __read_mostly cpu_to_node[NR_CPUS] = {
+    [0 ... NR_CPUS-1] = NUMA_NO_NODE
+};
+
+cpumask_t __read_mostly node_to_cpumask[MAX_NUMNODES];
+
+nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
+
+bool __ro_after_init numa_off;
+
+bool numa_disabled(void)
+{
+    return numa_off || arch_numa_disabled();
+}
+
+/*
+ * Given a shift value, try to populate memnodemap[]
+ * Returns :
+ * 1 if OK
+ * 0 if memnodmap[] too small (of shift too small)
+ * -1 if node overlap or lost ram (shift too big)
+ */
+static int __init populate_memnodemap(const struct node *nodes,
+                                      unsigned int numnodes, unsigned int shift,
+                                      const nodeid_t *nodeids)
+{
+    unsigned int i;
+    int res = -1;
+
+    memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap));
+
+    for ( i = 0; i < numnodes; i++ )
+    {
+        unsigned long spdx = paddr_to_pdx(nodes[i].start);
+        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1);
+
+        if ( spdx > epdx )
+            continue;
+
+        if ( (epdx >> shift) >= memnodemapsize )
+            return 0;
+
+        do {
+            if ( memnodemap[spdx >> shift] != NUMA_NO_NODE &&
+                 (!nodeids || memnodemap[spdx >> shift] != nodeids[i]) )
+                return -1;
+
+            if ( !nodeids )
+                memnodemap[spdx >> shift] = i;
+            else
+                memnodemap[spdx >> shift] = nodeids[i];
+
+            spdx += (1UL << shift);
+        } while ( spdx <= epdx );
+
+        res = 1;
+    }
+
+    return res;
+}
+
+static int __init allocate_cachealigned_memnodemap(void)
+{
+    unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap));
+    unsigned long mfn = mfn_x(alloc_boot_pages(size, 1));
+
+    memnodemap = mfn_to_virt(mfn);
+    mfn <<= PAGE_SHIFT;
+    size <<= PAGE_SHIFT;
+    printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n",
+           mfn, mfn + size);
+    memnodemapsize = size / sizeof(*memnodemap);
+
+    return 0;
+}
+
+/*
+ * The LSB of all start addresses in the node map is the value of the
+ * maximum possible shift.
+ */
+static unsigned int __init extract_lsb_from_nodes(const struct node *nodes,
+                                                  nodeid_t numnodes,
+                                                  const nodeid_t *nodeids)
+{
+    unsigned int i, nodes_used = 0;
+    unsigned long bitfield = 0, memtop = 0;
+
+    for ( i = 0; i < numnodes; i++ )
+    {
+        unsigned long spdx = paddr_to_pdx(nodes[i].start);
+        unsigned long epdx = paddr_to_pdx(nodes[i].end - 1) + 1;
+
+        if ( spdx >= epdx )
+            continue;
+
+        if ( i && (!nodeids || nodeids[i - 1] != nodeids[i]) )
+            bitfield |= spdx;
+
+        if ( !i || !nodeids || nodeids[i - 1] != nodeids[i] )
+            nodes_used++;
+
+        if ( epdx > memtop )
+            memtop = epdx;
+    }
+
+    if ( nodes_used <= 1 )
+        i = min(PADDR_BITS, BITS_PER_LONG - 1);
+    else
+        i = find_first_bit(&bitfield, sizeof(unsigned long) * 8);
+
+    memnodemapsize = ((memtop - 1) >> i) + 1;
+
+    return i;
+}
+
+int __init compute_hash_shift(const struct node *nodes,
+                              unsigned int numnodes, const nodeid_t *nodeids)
+{
+    unsigned int shift = extract_lsb_from_nodes(nodes, numnodes, nodeids);
+
+    if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) )
+        memnodemap = _memnodemap;
+    else if ( allocate_cachealigned_memnodemap() )
+        return -1;
+
+    printk(KERN_DEBUG "NUMA: Using %u for the hash shift\n", shift);
+
+    if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 )
+    {
+        printk(KERN_INFO "Your memory is not aligned you need to "
+               "rebuild your hypervisor with a bigger NODEMAPSIZE "
+               "shift=%u\n", shift);
+        return -1;
+    }
+
+    return shift;
+}
+
+/* Initialize NODE_DATA given nodeid and start/end */
+void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end)
+{
+    unsigned long start_pfn = paddr_to_pfn(start);
+    unsigned long end_pfn = paddr_to_pfn(end);
+
+    NODE_DATA(nodeid)->node_start_pfn = start_pfn;
+    NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn;
+
+    node_set_online(nodeid);
+}
+
+void __init numa_init_array(void)
+{
+    unsigned int i;
+    nodeid_t rr;
+
+    /*
+     * There are unfortunately some poorly designed mainboards
+     * around that only connect memory to a single CPU. This
+     * breaks the 1:1 cpu->node mapping. To avoid this fill in
+     * the mapping for all possible CPUs, as the number of CPUs
+     * is not known yet. We round robin the existing nodes.
+     */
+    rr = first_node(node_online_map);
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_to_node[i] != NUMA_NO_NODE )
+            continue;
+        numa_set_node(i, rr);
+        rr = cycle_node(rr, node_online_map);
+    }
+}
+
+#ifdef CONFIG_NUMA_EMU
+static unsigned int __initdata numa_fake;
+
+/* Numa emulation */
+static int __init numa_emulation(unsigned long start_pfn,
+                                 unsigned long end_pfn)
+{
+    int ret;
+    unsigned int i;
+    struct node nodes[MAX_NUMNODES];
+    uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake;
+
+    /* Kludge needed for the hash function */
+    if ( hweight64(sz) > 1 )
+    {
+        uint64_t x = 1;
+
+        while ( (x << 1) < sz )
+            x <<= 1;
+        if ( x < sz / 2 )
+            printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n");
+        sz = x;
+    }
+
+    memset(&nodes, 0, sizeof(nodes));
+    for ( i = 0; i < numa_fake; i++ )
+    {
+        nodes[i].start = pfn_to_paddr(start_pfn) + i * sz;
+
+        if ( i == numa_fake - 1 )
+            sz = pfn_to_paddr(end_pfn) - nodes[i].start;
+
+        nodes[i].end = nodes[i].start + sz;
+        printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n",
+               i, nodes[i].start, nodes[i].end,
+               (nodes[i].end - nodes[i].start) >> 20);
+        node_set_online(i);
+    }
+
+    ret = compute_hash_shift(nodes, numa_fake, NULL);
+    if ( ret < 0 )
+    {
+        printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n");
+        return -1;
+    }
+    memnode_shift = ret;
+
+    for_each_online_node ( i )
+        setup_node_bootmem(i, nodes[i].start, nodes[i].end);
+
+    numa_init_array();
+
+    return 0;
+}
+#endif
+
+void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
+{
+    unsigned int i;
+    paddr_t start = pfn_to_paddr(start_pfn);
+    paddr_t end = pfn_to_paddr(end_pfn);
+
+#ifdef CONFIG_NUMA_EMU
+    if ( numa_fake && !numa_emulation(start_pfn, end_pfn) )
+        return;
+#endif
+
+#ifdef CONFIG_NUMA
+    if ( !numa_off && !numa_process_nodes(start, end) )
+        return;
+#endif
+
+    printk(KERN_INFO "%s\n",
+           numa_off ? "NUMA turned off" : "No NUMA configuration found");
+
+    printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n",
+           start, end);
+
+    /* Setup dummy node covering all memory */
+    memnode_shift = BITS_PER_LONG - 1;
+    memnodemap = _memnodemap;
+
+    /* Dummy node only uses 1 slot in reality */
+    memnodemap[0] = 0;
+    memnodemapsize = 1;
+
+    nodes_clear(node_online_map);
+    node_set_online(0);
+    for ( i = 0; i < nr_cpu_ids; i++ )
+        numa_set_node(i, 0);
+
+    cpumask_copy(&node_to_cpumask[0], cpumask_of(0));
+    setup_node_bootmem(0, start, end);
+}
+
+void numa_add_cpu(unsigned int cpu)
+{
+    cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
+}
+
+void numa_set_node(unsigned int cpu, nodeid_t node)
+{
+    cpu_to_node[cpu] = node;
+}
+
+/* [numa=off] */
+static int __init cf_check numa_setup(const char *opt)
+{
+    if ( !strncmp(opt, "off", 3) )
+        numa_off = true;
+    else if ( !strncmp(opt, "on", 2) )
+        numa_off = false;
+#ifdef CONFIG_NUMA_EMU
+    else if ( !strncmp(opt, "fake=", 5) )
+    {
+        numa_off = false;
+        numa_fake = simple_strtoul(opt + 5, NULL, 0);
+        if ( numa_fake >= MAX_NUMNODES )
+            numa_fake = MAX_NUMNODES;
+    }
+#endif
+    else
+        return arch_numa_setup(opt);
+
+    return 0;
+}
+custom_param("numa", numa_setup);
+
+static void cf_check dump_numa(unsigned char key)
+{
+    s_time_t now = NOW();
+    unsigned int i, j, n;
+    struct domain *d;
+
+    printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key,
+           now);
+
+    for_each_online_node ( i )
+    {
+        paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1);
+
+        printk("NODE%u start->%lu size->%lu free->%lu\n",
+               i, node_start_pfn(i), node_spanned_pages(i),
+               avail_node_heap_pages(i));
+        /* Sanity check phys_to_nid() */
+        if ( phys_to_nid(pa) != i )
+            printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n",
+                   pa, phys_to_nid(pa), i);
+    }
+
+    j = cpumask_first(&cpu_online_map);
+    n = 0;
+    for_each_online_cpu ( i )
+    {
+        if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] )
+        {
+            if ( n > 1 )
+                printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]);
+            else
+                printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]);
+            j = i;
+            n = 1;
+        }
+        else
+            ++n;
+    }
+    if ( n > 1 )
+        printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]);
+    else
+        printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]);
+
+    rcu_read_lock(&domlist_read_lock);
+
+    printk("Memory location of each domain:\n");
+    for_each_domain ( d )
+    {
+        const struct page_info *page;
+        unsigned int page_num_node[MAX_NUMNODES];
+        const struct vnuma_info *vnuma;
+
+        process_pending_softirqs();
+
+        printk("%pd (total: %u):\n", d, domain_tot_pages(d));
+
+        memset(page_num_node, 0, sizeof(page_num_node));
+
+        spin_lock(&d->page_alloc_lock);
+        page_list_for_each ( page, &d->page_list )
+        {
+            i = phys_to_nid(page_to_maddr(page));
+            page_num_node[i]++;
+        }
+        spin_unlock(&d->page_alloc_lock);
+
+        for_each_online_node ( i )
+            printk("    Node %u: %u\n", i, page_num_node[i]);
+
+        if ( !read_trylock(&d->vnuma_rwlock) )
+            continue;
+
+        if ( !d->vnuma )
+        {
+            read_unlock(&d->vnuma_rwlock);
+            continue;
+        }
+
+        vnuma = d->vnuma;
+        printk("     %u vnodes, %u vcpus, guest physical layout:\n",
+               vnuma->nr_vnodes, d->max_vcpus);
+        for ( i = 0; i < vnuma->nr_vnodes; i++ )
+        {
+            unsigned int start_cpu = ~0U;
+
+            if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE )
+                printk("       %3u: pnode ???,", i);
+            else
+                printk("       %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]);
+
+            printk(" vcpus ");
+
+            for ( j = 0; j < d->max_vcpus; j++ )
+            {
+                if ( !(j & 0x3f) )
+                    process_pending_softirqs();
+
+                if ( vnuma->vcpu_to_vnode[j] == i )
+                {
+                    if ( start_cpu == ~0U )
+                    {
+                        printk("%u", j);
+                        start_cpu = j;
+                    }
+                }
+                else if ( start_cpu != ~0U )
+                {
+                    if ( j - 1 != start_cpu )
+                        printk("-%u ", j - 1);
+                    else
+                        printk(" ");
+                    start_cpu = ~0U;
+                }
+            }
+
+            if ( start_cpu != ~0U  && start_cpu != j - 1 )
+                printk("-%u", j - 1);
+
+            printk("\n");
+
+            for ( j = 0; j < vnuma->nr_vmemranges; j++ )
+            {
+                if ( vnuma->vmemrange[j].nid == i )
+                    printk("           %016"PRIx64" - %016"PRIx64"\n",
+                           vnuma->vmemrange[j].start,
+                           vnuma->vmemrange[j].end);
+            }
+        }
+
+        read_unlock(&d->vnuma_rwlock);
+    }
+
+    rcu_read_unlock(&domlist_read_lock);
+}
+
+static int __init cf_check register_numa_trigger(void)
+{
+    register_keyhandler('u', dump_numa, "dump NUMA info", 1);
+    return 0;
+}
+__initcall(register_numa_trigger);
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 7aef1a88dc..5b3877344b 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -18,4 +18,70 @@
   (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \
    ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE)
 
+/* The following content can be used when NUMA feature is enabled */
+#ifdef CONFIG_NUMA
+
+extern nodeid_t      cpu_to_node[NR_CPUS];
+extern cpumask_t     node_to_cpumask[];
+
+#define cpu_to_node(cpu)        cpu_to_node[cpu]
+#define parent_node(node)       (node)
+#define node_to_cpumask(node)   node_to_cpumask[node]
+
+struct node {
+    paddr_t start, end;
+};
+
+extern int compute_hash_shift(const struct node *nodes,
+                              unsigned int numnodes, const nodeid_t *nodeids);
+
+#define VIRTUAL_BUG_ON(x)
+
+extern bool numa_off;
+
+extern void numa_add_cpu(unsigned int cpu);
+extern void numa_init_array(void);
+extern void numa_set_node(unsigned int cpu, nodeid_t node);
+extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
+extern int numa_process_nodes(paddr_t start, paddr_t end);
+
+extern int arch_numa_setup(const char *opt);
+extern bool arch_numa_disabled(void);
+extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
+
+static inline void clear_node_cpumask(unsigned int cpu)
+{
+    cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
+}
+
+/* Simple perfect hash to map pdx to node numbers */
+extern unsigned int memnode_shift;
+extern unsigned long memnodemapsize;
+extern uint8_t *memnodemap;
+
+struct node_data {
+    unsigned long node_start_pfn;
+    unsigned long node_spanned_pages;
+};
+
+extern struct node_data node_data[];
+
+static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
+{
+    nodeid_t nid;
+    VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize);
+    nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift];
+    VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]);
+    return nid;
+}
+
+#define NODE_DATA(nid)          (&node_data[nid])
+
+#define node_start_pfn(nid)     (NODE_DATA(nid)->node_start_pfn)
+#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages)
+#define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
+                                 NODE_DATA(nid)->node_spanned_pages)
+
+#endif
+
 #endif /* _XEN_NUMA_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426153.674453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpu-00034q-RL; Thu, 20 Oct 2022 06:15:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426153.674453; Thu, 20 Oct 2022 06:15:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOpu-000342-Jj; Thu, 20 Oct 2022 06:15:22 +0000
Received: by outflank-mailman (input) for mailman id 426153;
 Thu, 20 Oct 2022 06:15:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOps-0002BJ-US
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:20 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2058.outbound.protection.outlook.com [40.107.247.58])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 91d8ca22-503e-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:15:18 +0200 (CEST)
Received: from DU2PR04CA0204.eurprd04.prod.outlook.com (2603:10a6:10:28d::29)
 by DU0PR08MB7812.eurprd08.prod.outlook.com (2603:10a6:10:3b4::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 06:15:16 +0000
Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28d:cafe::24) by DU2PR04CA0204.outlook.office365.com
 (2603:10a6:10:28d::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.16 via Frontend Transport; Thu, 20 Oct 2022 06:15:16 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Thu, 20 Oct 2022 06:15:16 +0000
Received: from a8e266bfd540.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6C428D65-0EF9-486D-9B67-1C8579B16092.1; 
 Thu, 20 Oct 2022 06:15:10 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8e266bfd540.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:15:10 +0000
Received: from DB8PR04CA0025.eurprd04.prod.outlook.com (2603:10a6:10:110::35)
 by AS8PR08MB6407.eurprd08.prod.outlook.com (2603:10a6:20b:33e::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 06:15:07 +0000
Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:110:cafe::d8) by DB8PR04CA0025.outlook.office365.com
 (2603:10a6:10:110::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:07 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:15:07 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:15:06 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91d8ca22-503e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=efy58adiWwYTGTczPal7Cvifrq1HYP5JdkiHjID1EerqCEb2xMwQO95hADd7R5F324QSJFGjvd1gN342ao2pepRRN8HNk5cD7vIaXAHMT274SN82VWrX2X9Z4Byoc+OgkIB8tn3GISl3Jx7fNRl1DB0TxaJyOqmUCK+uw4WVlxFvYxWo3p+lh8gzpdejtrkFTULWoxZ0jOSUi5PX3lECMmXo0ZZpOknuUsxacZ6pFFmsGEZk/GHf4b+PHz8vcyTvW/Qp90ZEj9J+V0sU8cyAwEkqUh8N3/X0/HvSBcpIOXbzigseFqw0aHrh8g4DCdF0QIt+Rz+8l5rhbwhe6pp2Ww==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=me1rkhKCFKXNKIcsR7o38t7l8niAuonnluIDnY1Civo=;
 b=efue8/Ou9uxfQ6HHLIcfafO8troP/OU0sddfdTtxI5l6odcGO9kH/a6ikuZr0Pjfmf6daKWCgdmgnrv1x+SdL6pimyChJybDrD30CNU1qIqcll5B/Bt3lkjzkV36/bcByd+uvn7GL/KLCb0xFLfmWoX3UnBXINZZdtRU/6kQQ/Jc+dPqY5VEwOF7yNgp/VYk9G1cRA6cKmlCLFjzHq27+JGSWKn4voJq+dzRr4/UGnO62MTS6rP+nLhd/z6WLfYONr3EvaL3jUnf0ksMBulnpD80iH+rVkuXZsV1gahHVMO8EWDvsUFv0trYXVjPoN8GM1EBBaFAncFbrs6/MWoz1Q==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=me1rkhKCFKXNKIcsR7o38t7l8niAuonnluIDnY1Civo=;
 b=tzkyRq5k4e05UQIDGwgLNl05EhKXCtPfBQggGLCseoCln7evwA5UNZCiQ8r4YGmrPPJuTlf3qT7hljjX2Cb9Lboi8JnQ0zt28QyW+5MCDwRIPcXnmhp21vRtIb6uL90lRRITzK/7PUp/+BAQGvqchmXcE4MwidWgoxHgHuVvaiA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: e869cceb156bf5f0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SgvyGxIemSj9Nrt7W5fm1iLNFTXfmGpBp9cZkNZk3CmCyChRoTIECOsm4fAyZyaOQ2fWAS8KQq5XvfeNLDrVziOyOmKd2D9T/vcSpyXgDKHUPefjiTiy1EL7OiNuT3h2SsenLjHaYe81iiMr4y60h6YGM+Kt/vdbkiMs93gND/UxJE7pRGhKLLOUWPbc7JTrpIXHrGvB4N3HMUYq2bx53Ok6v2iSwLbz6r66yXJUdmRls+y2lpWGEJekw7abKw8EApliDylv2Ydhjx9FmRxxdgCWnuBssIhex2Vxb20wApglRklHHtWcoIOQpxVbw1NuCT5OIBVROICeesrAHtIKbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=me1rkhKCFKXNKIcsR7o38t7l8niAuonnluIDnY1Civo=;
 b=TT4wxpuHHQDRZhDFiiK2Zrtw7jpAfbpjuGJUqXi+uyibIPLHI0T5UqQ13mCORUXwLNwWD4RoNON6BiDe4H6MdXU4s69w3KmvxujbW/EzxfvEd94800CI0eQJVteC+kDzkPWGfQUm8o8/u1cxMO8LKG65yugLMRJ6FI8mNSoLLIbr2IVAaHWZD2p38uJQO9O4VNHTVbrdwjl/ywfh7U3aydrFVViRq32YEIryoWlSb1ZUlDzDQltTNbcGHtkMjBAztffrQdd9K+SU6vHrsAuQfrH6o83R7UC0OaeiOfOPUbixGc4QnH+IwZmAqoKNOGuSyzy79TLPPJird3W57SK4Ng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=me1rkhKCFKXNKIcsR7o38t7l8niAuonnluIDnY1Civo=;
 b=tzkyRq5k4e05UQIDGwgLNl05EhKXCtPfBQggGLCseoCln7evwA5UNZCiQ8r4YGmrPPJuTlf3qT7hljjX2Cb9Lboi8JnQ0zt28QyW+5MCDwRIPcXnmhp21vRtIb6uL90lRRITzK/7PUp/+BAQGvqchmXcE4MwidWgoxHgHuVvaiA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v7 4/6] xen/x86: use arch_get_ram_range to get information from E820 map
Date: Thu, 20 Oct 2022 14:14:43 +0800
Message-ID: <20221020061445.288839-5-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221020061445.288839-1-wei.chen@arm.com>
References: <20221020061445.288839-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	DBAEUR03FT025:EE_|AS8PR08MB6407:EE_|DBAEUR03FT054:EE_|DU0PR08MB7812:EE_
X-MS-Office365-Filtering-Correlation-Id: 28f67739-1db8-4cd3-6241-08dab26274e9
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Lz7x1CWnLpzFV8qQUpXXqgeUkcH4Hi9HhOfj9HfKeAa3pOYVGlVJJe5b16SWv4thl5iw9jzHfgUcVOa4/YdutS9NUkOZZWO+be3len1cSIBT9RYCILB57euyfBnCBhKH5Tp4+8Itkp2RURdkr75RGPYZtYuT/SLvHHXWdgww57Ic/EnDOWOuG2WSxIWNFfDCq+Idk5wUnzgrOssRUSY8FgaqYvZNDuMQRIjt/dpHAeWt2q7ePxw6iidxatvykoGfc2V8EFO5sYX3LXHTmEpsqPHoJZtNSGOA8qeEYRHZ2Ycvus4l+w9CMWbIleBw15/XBv9j8pYgXIAe6jfuU1r4ZfOiVNrs41B0ApeDIqdlPTlYatejsi+LvviqKvsphxmN6oKxH2/QKNM7SrcaP3qL5hodnz9tDmDEKcFu10i4w90u2gJjqNS54oNhZW3L4zXnvMpg8LpSeL182bKWtCznDK/EU+dXeh7lzD6+SfTn7DN7nvnqvWy2phEw0KJlCyA4mMegusU1mZRlwXOEBftRvEKA0qBfzsq1Kg08ZQCQA2up3cWUZ2KkyCxrD0zpOC/bt3WJ8QqadBt4Y6w62I4bjoJCsqR2Gkdu/GlIXUi9jVJTDqn7oxeOdzCdDbtmdLcZvhV+SGwbGFJ2IPEUzUAPU12c7VAaJB87iEKgY4iSdaiQ7C3jFLbohu1t83RTh8KDSq1NYZ3/bsKOnwZ8DugfI9U1ojBgrApFOBTQ/tDHNGaABHbsgJwoBE1fukTAvMuU4BNxXC7IIgpFtj849lqAARVFgyIfgj3aVvTXu2CP+U0uYgbQL7KSGwTCMLduzC51
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(86362001)(82740400003)(356005)(81166007)(2906002)(83380400001)(426003)(44832011)(40460700003)(5660300002)(47076005)(40480700001)(1076003)(186003)(26005)(2616005)(6666004)(336012)(36860700001)(7696005)(6916009)(478600001)(54906003)(316002)(82310400005)(8936002)(8676002)(70586007)(4326008)(41300700001)(70206006)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6407
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b0ef59ff-758a-41a8-750c-08dab2626fa1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XiaYPmKNfvupWOz6uVGq6m+DzzSDfeCacc9h0YQ9778PXR6Nl39MGT5pbwO8M8CQ9jopteotrt732R9OJLyfbPpzogRfUOK675HK/Fi2/DmEHA1X7VHR/UdqrRdUgQf0sRGvRzq7mCWeJElK4jYo8d1Jx+IQKgqZ7xaxlonJkE4veiXsrdHU73Kkhca7nreiGVE6D55vtTXdlrtyjsjXE0W5Fm1Fkl+RSI+79aKx2FPMSR4JAbz+99ZWjf2XryL/4C84QXEIx3WzosM+BMDuwc2DO4UlcXw28Nspef0FgjTASg8nvar/tuKQPMltDx9ZHID3V+ZYY6tFwuGqWa4V6FyeUAeMroYqzlnzn9SPWtn/X226NtDffJ6e+DUB4sOeD9kxJv6s2okYzsnyQxMGmpG7WgofEbkgKefxDfUcHE47w5FDlMEybzsiTkncniCsdBI3hTYP7ytwJrK0m/OU8nm2zGpiWzf3xDAWZUa+5WrT1Nn6c37KcvTZkgCkP9RFzTAKJY4Unng1Md3AMQYMadMsIARU4thSdlgSyKX+pBd8T5A6oKNPapn88auqA0MBQy32A2+UpnrWDmoUgbNeVtzpsIOoxoJEauzHNBnH9wwIWKxgU+xv98401+gtdwLJVxQ7vQpMLI9frH8XqCFxF6XKE823vFu+xWaB21PcjQjJZiGH8JN1IKfsCPsliyDKuUysaz8A7Ti+aLOabItC5YjWdYH/rCuQt7K+nry8UT6gr2Pm7v5xTun9vef38Cm1I3mUsATq5V/omvCiwY9ntQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(70206006)(86362001)(40480700001)(1076003)(6916009)(54906003)(316002)(70586007)(6666004)(81166007)(2906002)(5660300002)(186003)(40460700003)(8676002)(4326008)(7696005)(336012)(2616005)(107886003)(47076005)(426003)(36756003)(44832011)(82740400003)(83380400001)(41300700001)(478600001)(82310400005)(26005)(8936002)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:16.4337
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 28f67739-1db8-4cd3-6241-08dab26274e9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7812

The sanity check of nodes_cover_memory is also a requirement of
other architectures that support NUMA. But now, the code of
nodes_cover_memory is tied to the x86 E820. In this case, we
introduce arch_get_ram_range to decouple architecture specific
memory map from this function. This means, other architectures
like Arm can also use it to check its node and memory coverage
from bootmem info.

Depends arch_get_ram_range, we make nodes_cover_memory become
architecture independent. We also use neutral words to replace
SRAT and E820 in the print message of this function. This will
to make the massage seems more common.

As arch_get_ram_range use unsigned int for index, we also adjust
the index in nodes_cover_memory from int to unsigned int.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
v6 -> v7:
1. No change.
v5 -> v6:
1. No change.
v4 -> v5:
1. Add Rb.
2. Adjust the code comments.
v3 -> v4:
1. Move function comment to header file.
2. Use bool for found, and add a new "err" for the return
   value of arch_get_ram_range.
3. Use -ENODATA instead of -EINVAL for non-RAM type ranges.
v2 -> v3:
1. Rename arch_get_memory_map to arch_get_ram_range.
2. Use -ENOENT instead of -ENODEV to indicate end of memory map.
3. Add description to code comment that arch_get_ram_range returns
   RAM range in [start, end) format.
v1 -> v2:
1. Use arch_get_memory_map to replace arch_get_memory_bank_range
   and arch_get_memory_bank_number.
2. Remove the !start || !end check, because caller guarantee
   these two pointers will not be NULL.
---
 xen/arch/x86/numa.c    | 15 +++++++++++++++
 xen/arch/x86/srat.c    | 30 ++++++++++++++++++------------
 xen/include/xen/numa.h | 13 +++++++++++++
 3 files changed, 46 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index 90b2a22591..fa8caaa084 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -9,6 +9,7 @@
 #include <xen/nodemask.h>
 #include <xen/numa.h>
 #include <asm/acpi.h>
+#include <asm/e820.h>
 
 #ifndef Dprintk
 #define Dprintk(x...)
@@ -93,3 +94,17 @@ unsigned int __init arch_get_dma_bitsize(void)
                  flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1)
                  + PAGE_SHIFT, 32);
 }
+
+int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end)
+{
+    if ( idx >= e820.nr_map )
+        return -ENOENT;
+
+    if ( e820.map[idx].type != E820_RAM )
+        return -ENODATA;
+
+    *start = e820.map[idx].addr;
+    *end = *start + e820.map[idx].size;
+
+    return 0;
+}
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index ce507dac9e..1a108a34c6 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -452,37 +452,43 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
    Make sure the PXMs cover all memory. */
 static int __init nodes_cover_memory(void)
 {
-	int i;
+	unsigned int i;
 
-	for (i = 0; i < e820.nr_map; i++) {
-		int j, found;
+	for (i = 0; ; i++) {
+		int err;
+		unsigned int j;
+		bool found;
 		paddr_t start, end;
 
-		if (e820.map[i].type != E820_RAM) {
-			continue;
-		}
+		/* Try to loop memory map from index 0 to end to get RAM ranges. */
+		err = arch_get_ram_range(i, &start, &end);
 
-		start = e820.map[i].addr;
-		end = e820.map[i].addr + e820.map[i].size;
+		/* Reached the end of the memory map? */
+		if (err == -ENOENT)
+			break;
+
+		/* Skip non-RAM entries. */
+		if (err)
+			continue;
 
 		do {
-			found = 0;
+			found = false;
 			for_each_node_mask(j, memory_nodes_parsed)
 				if (start < nodes[j].end
 				    && end > nodes[j].start) {
 					if (start >= nodes[j].start) {
 						start = nodes[j].end;
-						found = 1;
+						found = true;
 					}
 					if (end <= nodes[j].end) {
 						end = nodes[j].start;
-						found = 1;
+						found = true;
 					}
 				}
 		} while (found && start < end);
 
 		if (start < end) {
-			printk(KERN_ERR "SRAT: No PXM for e820 range: "
+			printk(KERN_ERR "NUMA: No NODE for RAM range: "
 				"[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1);
 			return 0;
 		}
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 04556f3a6f..9da0e7d555 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -80,6 +80,19 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
 #define node_end_pfn(nid)       (NODE_DATA(nid)->node_start_pfn + \
                                  NODE_DATA(nid)->node_spanned_pages)
 
+/*
+ * This function provides the ability for caller to get one RAM entry
+ * from architectural memory map by index.
+ *
+ * This function will return zero if it can return a proper RAM entry.
+ * Otherwise it will return -ENOENT for out of scope index, or other
+ * error codes, e.g. return -ENODATA for non-RAM type memory entry.
+ *
+ * Note: the range is exclusive at the end, e.g. [*start, *end).
+ */
+extern int arch_get_ram_range(unsigned int idx,
+                              paddr_t *start, paddr_t *end);
+
 #endif
 
 #endif /* _XEN_NUMA_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426157.674469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOq3-0003oP-Bx; Thu, 20 Oct 2022 06:15:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426157.674469; Thu, 20 Oct 2022 06:15:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOq3-0003o8-79; Thu, 20 Oct 2022 06:15:31 +0000
Received: by outflank-mailman (input) for mailman id 426157;
 Thu, 20 Oct 2022 06:15:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOq2-0002Ja-6E
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:30 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2058.outbound.protection.outlook.com [40.107.22.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 979c04dd-503e-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 08:15:28 +0200 (CEST)
Received: from DB6PR1001CA0015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::25)
 by AS8PR08MB5957.eurprd08.prod.outlook.com (2603:10a6:20b:290::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 06:15:23 +0000
Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:b7:cafe::38) by DB6PR1001CA0015.outlook.office365.com
 (2603:10a6:4:b7::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:15:23 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Thu, 20 Oct 2022 06:15:23 +0000
Received: from cc0d96545c1a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AE75C71D-9A86-435A-B193-593203ED5757.1; 
 Thu, 20 Oct 2022 06:15:16 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc0d96545c1a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:15:16 +0000
Received: from DU2PR04CA0017.eurprd04.prod.outlook.com (2603:10a6:10:3b::22)
 by AS1PR08MB7500.eurprd08.prod.outlook.com (2603:10a6:20b:4db::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 06:15:11 +0000
Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:3b:cafe::69) by DU2PR04CA0017.outlook.office365.com
 (2603:10a6:10:3b::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:11 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:15:11 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:15:09 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 979c04dd-503e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=d2Ru+z42qx6S/IFyZGd1IQYgP+mhp8+LAK3Us3yaT7EiDsJ/QgvCGhXx9JWErqFVU2JmALTr2VnlRfsqX8Z3yVngdW9+4d0n3y1mGAgaWwqWepYH2f4Siko27htE0Clqr8iM4LL1KzJZMT1FHvo6bFFdxyNekbMvFegdsc+AVOJj3hs1YmQALdPsCDPeYmteeayC0lSi5sN9E9rZ1mQghkFP2mZhObm2Ty+0u6yYpO6Ytx4hAGH1Pr76weIUh4nzQwf8RO3k7KkUVHQQyIW2AGkdHcRUnS6tQFg1t+hFWu750ueYfnzKCZ8b+5JMp21J2TThKkF5Sn5DOkRBfqdODw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P6GLMvssaIA80vaP85Ipgimr6sv0AlvObMKFc5jWK44=;
 b=VMNyFkX82tI2klnmHV1Zos1k6euvrG9bC3R6lMnIgCmhR2UiA76kF/uuXuLspWT5CH2KJG51fQOEgxE5iyDazeDMNRmrRxl35V/1Q/ewFf57TMQtJ+HHXHQSxBWz29YZjHYdL8iwoU38uXys8c8UYVJnSdpZLTVwCfI3bG2QD5A5gS1//pgIvGEI+mPJPkSs4lhoSOqGrm/nUKk4LcgVBZ+3ouJXSe9mrbDMQ/gpvZ+c9B3maGN9o9vS0FLz+Tx11+H4LScRXpb1XfMWu2q5s2PwySFTAcf6V4agzzlyFqo7WN8qUQOCImT0qdb5r85VCqkdCGRtyjHRZswh3O4MsA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P6GLMvssaIA80vaP85Ipgimr6sv0AlvObMKFc5jWK44=;
 b=uBUhejbwoVY5BTPNOiDaHDuSjfAFdcCJwsxuvET4tQt06CjRaBeu/w8vP+6MaPn4QJOdr37IntaY6FxQE/xVq0p5Lf3GAVZwtKd5nj4D283IQN2+yXMiB4NuE7ceyTunKW77Ex5xW2gNObfrWVG6AFWzg5LHl9TIFNA8xCkY0Ss=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 40a973d52cbec7d9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NJ/vuGUeoccn2RYlKEAyyPZJ0scJCiaAh3BmP1AbEU8H9fsvCgW3xixj/xje8myNh71ye6t9BomkAfk8eg9QOEoFe4fvOrXB7Li1T+e2hEbdt0AWEszqEdIruoFAmKwsangu3XgldgaGdoafeaQHYkaa2wfnFleIhsg41S3H3bwHl87lnzbbXI7wnIWxOUzQjZ+9nnS3iSxC7/KtbMbbDCGlKdf1GDvB6UPn2RF+3FYRjCOxKlFnTlPu5aTCLwtH4qSMzeSVLviihSy2QHFWb9t9Nf1Xzpm/Rq8l9rE6B9bjpIGzfHh7w2aftZuKqqvQl9/n7CglHkXLPfy2tl4OnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P6GLMvssaIA80vaP85Ipgimr6sv0AlvObMKFc5jWK44=;
 b=eOnp/BWLy/Y89he/rUXsKTMhAvrzRTAAkIFRI9mtFYwxJbogW29F3aBaDAOtOjUcaylNQoN6chW9FLtq/vj7xQYtPeeBtEEj/2Zf4nvRhk7do9WHeNxe3GPV23RJApx2q7GE9YCvNUx5fftVuOKmjJgIFWT7j9Q/sMuJNqDvhZmD4+k7if8YmIsu0SXCQMXoenP3EXJ8f0qtG1n6HMMln8mJ1S/yr0RRmpyQHlwiFegjr1344zcZhyh/geLQqmagBXIJUR0IHI67pmHfMzQBFcbMb2eTN7tKAAH52WSEK3PEYO0tUpKFACOX+Uiwypit/CQ0N2UomdHfcxovVhDlvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P6GLMvssaIA80vaP85Ipgimr6sv0AlvObMKFc5jWK44=;
 b=uBUhejbwoVY5BTPNOiDaHDuSjfAFdcCJwsxuvET4tQt06CjRaBeu/w8vP+6MaPn4QJOdr37IntaY6FxQE/xVq0p5Lf3GAVZwtKd5nj4D283IQN2+yXMiB4NuE7ceyTunKW77Ex5xW2gNObfrWVG6AFWzg5LHl9TIFNA8xCkY0Ss=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v7 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common
Date: Thu, 20 Oct 2022 14:14:44 +0800
Message-ID: <20221020061445.288839-6-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221020061445.288839-1-wei.chen@arm.com>
References: <20221020061445.288839-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	DBAEUR03FT010:EE_|AS1PR08MB7500:EE_|DBAEUR03FT023:EE_|AS8PR08MB5957:EE_
X-MS-Office365-Filtering-Correlation-Id: 08b9774d-15f0-4c7c-3e4c-08dab2627924
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GSGRcy31ool4rPwdRwBE6ZXFSBhK+UnL2RmSXCi/yn9GdCiKcjFoC/8VjbLwQhKfnVrkyNT/k4YzmOz8oncu74Z5FLadiKqwtBRefDARDow1FHixhUKoCkDZR8fi/KuABIc+dyGW2DeDyDHkYMhhgX+udlXIcAdVNJ7mRB2L4jLakKgHuqqJuinJL8VR3Ro5IJbQqLXxrlRTPWAfc72r0Fc+H2bJBU/em1Ej8ySmOtOqOg3vhtXi8O51XcNMYay8HCB4TVvx5EIMMukMFiUDOkE2YveULhkjgMXmleLCyp98DEJIN81vqh533EAcE9Ft6ZfA4osW+ELCr7q9WXIuKJV37cebmDYiPxSykYUekmpEE60qKmqEdo7z/NTyEb2/5pPgYOXOTra8rufq/Avxugj6KSQWcin5lifS9IFMrCZX0LDPJXCxp0F6QC+AqpkX3lbkPfP8lGfNs2HDKZmRXuJtnAivJo7P1KarCxvMVUQ7osTeZCYqRoYqy1qHgWIcSwYKCobZHUdg410fWzQr/VKOOtIUX1dgro2uMrS6KFRtGWpsdli0CB36iVztbSULjmd97d1s4Y1RjHKZMISeXIPoj9hMNrI6pagVxuoxY2OsjygXSIqKkkPnutwJHVp/r91hM6Np4AtYjnZ28pD4JnP2DrVi24zCMkbm8Ke0oYWM4B+agFWJtIK8H+60xvDJG3HXBntziNM4GO6bFCDs3M3+WN/0JpnRf4WMDikfuoDwdNp+YP6tr/AkrrhnO4hsIBRcC8mhbLEFHV7JUobyezRAXIRpnH5GwedTzTYxf/98fvldSQ5okpH+ZP7TCXfh
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36840700001)(40470700004)(46966006)(6666004)(36756003)(81166007)(86362001)(82740400003)(356005)(2906002)(82310400005)(36860700001)(83380400001)(336012)(1076003)(186003)(47076005)(70206006)(6916009)(426003)(40460700003)(7696005)(26005)(478600001)(54906003)(70586007)(4326008)(30864003)(40480700001)(44832011)(316002)(8936002)(41300700001)(2616005)(5660300002)(8676002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7500
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	df10bfcc-11d9-4b4f-3548-08dab26271d8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fmXoxqqnDLjmmh9W6sn/eOLNVihdJTRrEqN3v415zqMhs8xeXVFaL4RCQj+yykmiR3Za0r9XYPhBPrAOpvyRBrw8oNMc+qrlLPSdbXSAtvLwyfALksBFSBRePbUrt/5yHvxWE+8T0fxT7LO2QxH2bO1eetiDQzxO9XaVB6AawcFhJKke0g4OKznJtwV0PUCVM5i+SGyi6aPke2QeH6Ilby/tYfumB+xvT6/KuZYiyb8hXxgTEEsaSUq9CRbofeWCcwPDJzUSor7sA+xmJCbjNMVgdFWc/qxEhQlQ5/B6VECUOQy6nlfiEOEsh8CdeHTQuGCThS1PefqbIb3WnNMQ5AO49rInvZBm9Uk3LAorKti7dbPEJ475sqgUcDjlmP+3OZI2yvbBreSv2gYvixc0Is5sAum8QBueBN3R32cNTwLVkoYoA3P6w889MOf1QRRVMjv3Jo9h8zyNtl77lqe+r1LO4fHcyefm1YEPvywLEhcLSl5ezT1EeNpothoKc3bQvAxl8hOX+OiTkOCYZGBhEkl4uCuVJ8QVXRLZ/vDsD7Rg1MgYpYjVLbjimJMwVvrc4zh+TLwWtN7zZA9ShyRKL0qkJ2SkLN3OCP5qQNIHqD7dmR4tEcYyIcKYEJsXH4/P02psdnQR8F6REnvz1Dy4vNrj/qgNQkO+TG3BPgc502/KvsL/xMVRf1ifbjruu+uLauGZ5DNZgb25HBG1NLaoLJrc/A50Mb39D8ao8fk4DeanbwrqtvtDNUtrAD6VQgoBE6InHAVRyQltQZ7jmE6JeQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(1076003)(186003)(2906002)(82740400003)(81166007)(478600001)(2616005)(82310400005)(40460700003)(70586007)(70206006)(86362001)(30864003)(6916009)(26005)(8676002)(4326008)(44832011)(336012)(54906003)(36860700001)(40480700001)(47076005)(6666004)(426003)(107886003)(8936002)(316002)(7696005)(36756003)(83380400001)(41300700001)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:23.5304
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 08b9774d-15f0-4c7c-3e4c-08dab2627924
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5957

x86 has implemented a set of codes to process NUMA nodes. These
codes will parse NUMA memory and processor information from
ACPI SRAT table. But except some ACPI specific codes, most
of the process code like memory blocks validation, node memory
range updates and some sanity check can be reused by other
NUMA implementation.

So in this patch, we move some variables and related functions
for NUMA memory and processor to common as library. At the
same time, numa_set_processor_nodes_parsed has been introduced
for ACPI specific code to update processor parsing results.
With this helper, we can reuse most of NUMA memory affinity init
code from ACPI. As bad_srat and node_to_pxm functions have been
used in common code to do architectural fallback and node to
architectural node info translation. But it doesn't make sense
to reuse the functions names in common code, we have rename them
to neutral names as well.

PXM is an ACPI specific item, we can't use it in common code
directly. As an alternative, we extend the parameters of
numa_update_node_memblks. The caller can pass the PXM as print
messages' prefix or as architectural node id. And we introduced
an numa_fw_nid_name for each NUMA implementation to set their
specific firmware NUMA node name. In this case, we do not need
to retain a lot of per-arch code but still can print architectural
log messages for different NUMA implementations. A default value
"???" will be set to indicate an unset numa_fw_nid_name.

mem_hotplug is accessed by common code if memory hotplug is
activated. Even if this is only supported by x86, export the
variable so that other architectures could support it in the future.

As asm/acpi.h has been removed from common/numa.c, we have to
move NR_NODE_MEMBLKS from asm/acpi.h to xen/numa.h in this patch
as well.

Signed-off-by: Wei Chen <wei.chen@arm.com>
---
v6 -> v7:
 1. Add __init for arch_numa_unavailable.
 2. Use __ro_after_init for mem_hotplug.
 3. Use "???" instead of "NONAME" for unset numa_fw_nid_name.
 4. Fix code-style.
v5 -> v6:
 1. Fix code-style.
 2. Use arch_numa_unavailable to replace arch_numa_disabled for
    acpi_numa <= 0.
 3. Remove Kconfig for HAS_NUMA_NODE_FWID.
 4. Use numa_fw_nid_name for NUMA implementation to set their fw
    NUMA node name for print messages.
v4 -> v5:
 1. Introduce arch_numa_disabled for acpi_numa <= 0 in this patch.
 2. Remove the paramter init_as_disable of arch_numa_disabled.
 3. Fix typo "expandsion".
 4. Add const to proper varibales.
 5. Fix Indentation for l1tf_safe_maddr.
 6. Remove double blank lines.
 7. Add a space between for_each_node_mask and '('.
    Add a space page_list_for_each and '('.
 8. Use bool for nodes_cover_memory return value.
 9. Use a plain "int ret" to record compute_hash_shift return value.
10. Add a blank line before the function's main "return".
11. Add new Kconfig option HAS_NUMA_NODE_FWID to common/Kconfig.
v3 -> v4:
1. Use bool as return value for functions that only return
   0/1 or 0/-EINVAL.
2. Move mem_hotplug to a proper place in mm.h
3. Remove useless "size" in numa_scan_nodes.
4. Use unsigned int or const for proper variables.
5. Fix code-style.
6. Add init_as_disable as arch_numa_disabled parameter.
7. Add CONFIG_HAS_NUMA_NODE_FWID to gate print the mapping
   between node id and architectural node id (fw node id).
v2 -> v3:
1. Add __ro_after_init to proper variables.
2. Rename bad_srat to numa_fw_bad.
3. Rename node_to_pxm to numa_node_to_arch_nid.
4. Merge patch#7 and #8 into this patch.
5. Correct int to unsigned int in proper places.
6. Move NR_NODE_MEMBLKS from x86/acpi.h to common/numa.h
7. Drop helpers to access mem_hotplug, we export mem_hotplug
   from x86/mm.c to common/page_alloc.c
v1 -> v2:
1. Add code comment for numa_update_node_memblks to explain:
   Assumes all memory regions belonging to a single node
   are in one chunk. Holes between them will be included
   in the node.
2. Merge this single patch instead of serval patches to move
   x86 SRAT code to common.
3. Export node_to_pxm to keep pxm information in NUMA scan
   nodes error messages.
4. Change the code style to target file's Xen code-style.
5. Adjust some __init and __initdata for some functions and
   variables.
6. Merge two patches into this patch:
   1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA.
   2. replace "SRAT" texts.
7. Turn numa_scan_nodes to static.
---
 xen/arch/x86/include/asm/acpi.h |   1 -
 xen/arch/x86/include/asm/mm.h   |   2 -
 xen/arch/x86/include/asm/numa.h |   3 +-
 xen/arch/x86/mm.c               |   2 -
 xen/arch/x86/numa.c             |   5 +
 xen/arch/x86/srat.c             | 335 +++----------------------------
 xen/common/numa.c               | 341 +++++++++++++++++++++++++++++++-
 xen/common/page_alloc.c         |   2 +
 xen/include/xen/mm.h            |   2 +
 xen/include/xen/numa.h          |  10 +-
 10 files changed, 382 insertions(+), 321 deletions(-)

diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h
index 5c2dd5da2d..c453450a74 100644
--- a/xen/arch/x86/include/asm/acpi.h
+++ b/xen/arch/x86/include/asm/acpi.h
@@ -102,7 +102,6 @@ extern unsigned long acpi_wakeup_address;
 #define ARCH_HAS_POWER_INIT	1
 
 extern s8 acpi_numa;
-#define NR_NODE_MEMBLKS (MAX_NUMNODES*2)
 
 extern struct acpi_sleep_info acpi_sinfo;
 #define acpi_video_flags bootsym(video_flags)
diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h
index 0fc826de46..95ff71a83a 100644
--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -474,8 +474,6 @@ static inline int get_page_and_type(struct page_info *page,
     ASSERT(((_p)->count_info & PGC_count_mask) != 0);          \
     ASSERT(page_get_owner(_p) == (_d))
 
-extern paddr_t mem_hotplug;
-
 /******************************************************************************
  * With shadow pagetables, the different kinds of address start
  * to get get confusing.
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 6c87942d43..2ca3475271 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -10,6 +10,7 @@ typedef u8 nodeid_t;
 extern int srat_rev;
 
 extern nodeid_t pxm_to_node(unsigned int pxm);
+extern unsigned int numa_node_to_arch_nid(nodeid_t n);
 
 #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT))
 
@@ -22,8 +23,6 @@ extern void init_cpu_to_node(void);
 
 #define arch_want_default_dmazone() (num_online_nodes() > 1)
 
-extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
-
 void srat_parse_regions(paddr_t addr);
 extern u8 __node_distance(nodeid_t a, nodeid_t b);
 unsigned int arch_get_dma_bitsize(void);
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index db1817b691..68f9989e1f 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -157,8 +157,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE)
 l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE)
     l1_fixmap_x[L1_PAGETABLE_ENTRIES];
 
-paddr_t __read_mostly mem_hotplug;
-
 /* Frame table size in pages. */
 unsigned long max_page;
 unsigned long total_pages;
diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
index fa8caaa084..4b0b297c7e 100644
--- a/xen/arch/x86/numa.c
+++ b/xen/arch/x86/numa.c
@@ -46,6 +46,11 @@ bool arch_numa_disabled(void)
     return acpi_numa < 0;
 }
 
+bool __init arch_numa_unavailable(void)
+{
+    return acpi_numa <= 0;
+}
+
 /*
  * Setup early cpu_to_node.
  *
diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index 1a108a34c6..3bab47591e 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -24,10 +24,6 @@
 
 static struct acpi_table_slit *__read_mostly acpi_slit;
 
-static nodemask_t memory_nodes_parsed __initdata;
-static nodemask_t processor_nodes_parsed __initdata;
-static struct node nodes[MAX_NUMNODES] __initdata;
-
 struct pxm2node {
 	unsigned pxm;
 	nodeid_t node;
@@ -35,19 +31,6 @@ struct pxm2node {
 static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] =
 	{ [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} };
 
-static unsigned node_to_pxm(nodeid_t n);
-
-static int num_node_memblks;
-static struct node node_memblk_range[NR_NODE_MEMBLKS];
-static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS];
-static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS);
-
-enum conflicts {
-	NO_CONFLICT,
-	OVERLAP,
-	INTERLEAVE,
-};
-
 static inline bool node_found(unsigned idx, unsigned pxm)
 {
 	return ((pxm2node[idx].pxm == pxm) &&
@@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm)
 	return node;
 }
 
-int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node)
-{
-	int i;
-
-	for (i = 0; i < num_node_memblks; i++) {
-		struct node *nd = &node_memblk_range[i];
-
-		if (nd->start <= start && nd->end >= end &&
-			memblk_nodeid[i] == node)
-			return 1;
-	}
-
-	return 0;
-}
-
-static
-enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start,
-					  paddr_t end, paddr_t nd_start,
-					  paddr_t nd_end, unsigned int *mblkid)
-{
-	unsigned int i;
-
-	/*
-	 * Scan all recorded nodes' memory blocks to check conflicts:
-	 * Overlap or interleave.
-	 */
-	for (i = 0; i < num_node_memblks; i++) {
-		struct node *nd = &node_memblk_range[i];
-
-		*mblkid = i;
-
-		/* Skip 0 bytes node memory block. */
-		if (nd->start == nd->end)
-			continue;
-		/*
-		 * Use memblk range to check memblk overlaps, include the
-		 * self-overlap case. As nd's range is non-empty, the special
-		 * case "nd->end == end && nd->start == start" also can be covered.
-		 */
-		if (nd->end > start && nd->start < end)
-			return OVERLAP;
-
-		/*
-		 * Use node memory range to check whether new range contains
-		 * memory from other nodes - interleave check. We just need
-		 * to check full contains situation. Because overlaps have
-		 * been checked above.
-		 */
-	        if (nid != memblk_nodeid[i] &&
-		    nd->start >= nd_start && nd->end <= nd_end)
-			return INTERLEAVE;
-	}
-
-	return NO_CONFLICT;
-}
-
-static __init void cutoff_node(int i, paddr_t start, paddr_t end)
-{
-	struct node *nd = &nodes[i];
-	if (nd->start < start) {
-		nd->start = start;
-		if (nd->end < nd->start)
-			nd->start = nd->end;
-	}
-	if (nd->end > end) {
-		nd->end = end;
-		if (nd->start > nd->end)
-			nd->start = nd->end;
-	}
-}
-
-static __init void bad_srat(void)
+void __init numa_fw_bad(void)
 {
 	int i;
 	printk(KERN_ERR "SRAT: SRAT not used.\n");
@@ -241,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa)
 	if (numa_disabled())
 		return;
 	if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	if (!(pa->flags & ACPI_SRAT_CPU_ENABLED))
@@ -254,12 +166,12 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa)
 	pxm = pa->proximity_domain;
 	node = setup_node(pxm);
 	if (node == NUMA_NO_NODE) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 
 	apicid_to_node[pa->apic_id] = node;
-	node_set(node, processor_nodes_parsed);
+	numa_set_processor_nodes_parsed(node);
 	acpi_numa = 1;
 
 	if (opt_acpi_verbose)
@@ -277,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 	if (numa_disabled())
 		return;
 	if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	if (!(pa->flags & ACPI_SRAT_CPU_ENABLED))
@@ -290,11 +202,11 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 	}
 	node = setup_node(pxm);
 	if (node == NUMA_NO_NODE) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	apicid_to_node[pa->apic_id] = node;
-	node_set(node, processor_nodes_parsed);
+	numa_set_processor_nodes_parsed(node);
 	acpi_numa = 1;
 
 	if (opt_acpi_verbose)
@@ -306,33 +218,27 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa)
 void __init
 acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 {
-	struct node *nd;
-	paddr_t nd_start, nd_end;
-	paddr_t start, end;
 	unsigned pxm;
 	nodeid_t node;
-	unsigned int i;
-	bool next = false;
 
 	if (numa_disabled())
 		return;
 	if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 	if (!(ma->flags & ACPI_SRAT_MEM_ENABLED))
 		return;
 
-	start = ma->base_address;
-	end = start + ma->length;
 	/* Supplement the heuristics in l1tf_calculations(). */
-	l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE));
+	l1tf_safe_maddr = max(l1tf_safe_maddr,
+			      ROUNDUP(ma->base_address + ma->length,
+				      PAGE_SIZE));
 
-	if (num_node_memblks >= NR_NODE_MEMBLKS)
-	{
+	if (!numa_memblks_available()) {
 		dprintk(XENLOG_WARNING,
-                "Too many numa entry, try bigger NR_NODE_MEMBLKS \n");
-		bad_srat();
+			"Too many numa entries, try bigger NR_NODE_MEMBLKS!\n");
+		numa_fw_bad();
 		return;
 	}
 
@@ -341,159 +247,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma)
 		pxm &= 0xff;
 	node = setup_node(pxm);
 	if (node == NUMA_NO_NODE) {
-		bad_srat();
+		numa_fw_bad();
 		return;
 	}
 
-	/*
-	 * For the node that already has some memory blocks, we will
-	 * expand the node memory range temporarily to check memory
-	 * interleaves with other nodes. We will not use this node
-	 * temp memory range to check overlaps, because it will mask
-	 * the overlaps in same node.
-	 *
-	 * Node with 0 bytes memory doesn't need this expandsion.
-	 */
-	nd_start = start;
-	nd_end = end;
-	nd = &nodes[node];
-	if (nd->start != nd->end) {
-		if (nd_start > nd->start)
-			nd_start = nd->start;
-
-		if (nd_end < nd->end)
-			nd_end = nd->end;
-	}
-
-	/* It is fine to add this area to the nodes data it will be used later*/
-	switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) {
-	case OVERLAP:
-		if (memblk_nodeid[i] == node) {
-			bool mismatch = !(ma->flags &
-					  ACPI_SRAT_MEM_HOT_PLUGGABLE) !=
-			                !test_bit(i, memblk_hotplug);
-
-			printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n",
-			       mismatch ? KERN_ERR : KERN_WARNING, pxm, start,
-			       end - 1, node_memblk_range[i].start,
-			       node_memblk_range[i].end - 1);
-			if (mismatch) {
-				bad_srat();
-				return;
-			}
-			break;
-		}
-
-		printk(KERN_ERR
-		       "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n",
-		       pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]),
-		       node_memblk_range[i].start,
-		       node_memblk_range[i].end - 1);
-		bad_srat();
-		return;
-
-	case INTERLEAVE:
-		printk(KERN_ERR
-		       "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n",
-		       pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]),
-		       node_memblk_range[i].start, node_memblk_range[i].end - 1);
-		bad_srat();
-		return;
-
-	case NO_CONFLICT:
-		break;
-	}
-
-	if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) {
-		node_set(node, memory_nodes_parsed);
-		nd->start = nd_start;
-		nd->end = nd_end;
-	}
-
-	printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
-	       node, pxm, start, end - 1,
-	       ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : "");
-
-	/* Keep node_memblk_range[] sorted by address. */
-	for (i = 0; i < num_node_memblks; ++i)
-		if (node_memblk_range[i].start > start ||
-		    (node_memblk_range[i].start == start &&
-		     node_memblk_range[i].end > end))
-			break;
-
-	memmove(&node_memblk_range[i + 1], &node_memblk_range[i],
-	        (num_node_memblks - i) * sizeof(*node_memblk_range));
-	node_memblk_range[i].start = start;
-	node_memblk_range[i].end = end;
-
-	memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i],
-	        (num_node_memblks - i) * sizeof(*memblk_nodeid));
-	memblk_nodeid[i] = node;
-
-	if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
-		next = true;
-		if (end > mem_hotplug)
-			mem_hotplug = end;
-	}
-	for (; i <= num_node_memblks; ++i) {
-		bool prev = next;
-
-		next = test_bit(i, memblk_hotplug);
-		if (prev)
-			__set_bit(i, memblk_hotplug);
-		else
-			__clear_bit(i, memblk_hotplug);
-	}
-
-	num_node_memblks++;
-}
-
-/* Sanity check to catch more bad SRATs (they are amazingly common).
-   Make sure the PXMs cover all memory. */
-static int __init nodes_cover_memory(void)
-{
-	unsigned int i;
-
-	for (i = 0; ; i++) {
-		int err;
-		unsigned int j;
-		bool found;
-		paddr_t start, end;
-
-		/* Try to loop memory map from index 0 to end to get RAM ranges. */
-		err = arch_get_ram_range(i, &start, &end);
-
-		/* Reached the end of the memory map? */
-		if (err == -ENOENT)
-			break;
-
-		/* Skip non-RAM entries. */
-		if (err)
-			continue;
-
-		do {
-			found = false;
-			for_each_node_mask(j, memory_nodes_parsed)
-				if (start < nodes[j].end
-				    && end > nodes[j].start) {
-					if (start >= nodes[j].start) {
-						start = nodes[j].end;
-						found = true;
-					}
-					if (end <= nodes[j].end) {
-						end = nodes[j].start;
-						found = true;
-					}
-				}
-		} while (found && start < end);
-
-		if (start < end) {
-			printk(KERN_ERR "NUMA: No NODE for RAM range: "
-				"[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1);
-			return 0;
-		}
-	}
-	return 1;
+	numa_fw_nid_name = "PXM";
+	if (!numa_update_node_memblks(node, pxm, ma->base_address, ma->length,
+				      ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE))
+		numa_fw_bad();
 }
 
 void __init acpi_numa_arch_fixup(void) {}
@@ -549,59 +310,9 @@ void __init srat_parse_regions(paddr_t addr)
 	pfn_pdx_hole_setup(mask >> PAGE_SHIFT);
 }
 
-/* Use discovered information to actually set up the nodes. */
-int __init numa_process_nodes(paddr_t start, paddr_t end)
+unsigned int numa_node_to_arch_nid(nodeid_t n)
 {
-	int i;
-	nodemask_t all_nodes_parsed;
-
-	/* First clean up the node list */
-	for (i = 0; i < MAX_NUMNODES; i++)
-		cutoff_node(i, start, end);
-
-	if (acpi_numa <= 0)
-		return -1;
-
-	if (!nodes_cover_memory()) {
-		bad_srat();
-		return -1;
-	}
-
-	memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks,
-				memblk_nodeid);
-
-	if (memnode_shift < 0) {
-		printk(KERN_ERR
-		     "SRAT: No NUMA node hash function found. Contact maintainer\n");
-		bad_srat();
-		return -1;
-	}
-
-	nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed);
-
-	/* Finally register nodes */
-	for_each_node_mask(i, all_nodes_parsed)
-	{
-		uint64_t size = nodes[i].end - nodes[i].start;
-
-		if ( size == 0 )
-			printk(KERN_INFO "SRAT: node %u has no memory\n", i);
-
-		setup_node_bootmem(i, nodes[i].start, nodes[i].end);
-	}
-	for (i = 0; i < nr_cpu_ids; i++) {
-		if (cpu_to_node[i] == NUMA_NO_NODE)
-			continue;
-		if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed))
-			numa_set_node(i, NUMA_NO_NODE);
-	}
-	numa_init_array();
-	return 0;
-}
-
-static unsigned node_to_pxm(nodeid_t n)
-{
-	unsigned i;
+	unsigned int i;
 
 	if ((n < ARRAY_SIZE(pxm2node)) && (pxm2node[n].node == n))
 		return pxm2node[n].pxm;
@@ -618,8 +329,8 @@ u8 __node_distance(nodeid_t a, nodeid_t b)
 
 	if (!acpi_slit)
 		return a == b ? 10 : 20;
-	index = acpi_slit->locality_count * node_to_pxm(a);
-	slit_val = acpi_slit->entry[index + node_to_pxm(b)];
+	index = acpi_slit->locality_count * numa_node_to_arch_nid(a);
+	slit_val = acpi_slit->entry[index + numa_node_to_arch_nid(b)];
 
 	/* ACPI defines 0xff as an unreachable node and 0-9 are undefined */
 	if ((slit_val == 0xff) || (slit_val <= 9))
diff --git a/xen/common/numa.c b/xen/common/numa.c
index a435a07db9..f58679e7b9 100644
--- a/xen/common/numa.c
+++ b/xen/common/numa.c
@@ -13,6 +13,21 @@
 #include <xen/sched.h>
 #include <xen/softirq.h>
 
+static nodemask_t __initdata processor_nodes_parsed;
+static nodemask_t __initdata memory_nodes_parsed;
+static struct node __initdata nodes[MAX_NUMNODES];
+
+static unsigned int __ro_after_init num_node_memblks;
+static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS];
+static nodeid_t __ro_after_init memblk_nodeid[NR_NODE_MEMBLKS];
+static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS);
+
+enum conflicts {
+    NO_CONFLICT,
+    OVERLAP,
+    INTERLEAVE,
+};
+
 struct node_data __ro_after_init node_data[MAX_NUMNODES];
 
 /* Mapping from pdx to node id */
@@ -31,11 +46,335 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
 
 bool __ro_after_init numa_off;
 
+const char *__ro_after_init numa_fw_nid_name = "???";
+
 bool numa_disabled(void)
 {
     return numa_off || arch_numa_disabled();
 }
 
+void __init numa_set_processor_nodes_parsed(nodeid_t node)
+{
+    node_set(node, processor_nodes_parsed);
+}
+
+bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node)
+{
+    unsigned int i;
+
+    for ( i = 0; i < num_node_memblks; i++ )
+    {
+        const struct node *nd = &node_memblk_range[i];
+
+        if ( nd->start <= start && nd->end >= end &&
+             memblk_nodeid[i] == node )
+            return true;
+    }
+
+    return false;
+}
+
+static enum conflicts __init conflicting_memblks(
+    nodeid_t nid, paddr_t start, paddr_t end, paddr_t nd_start,
+    paddr_t nd_end, unsigned int *mblkid)
+{
+    unsigned int i;
+
+    /*
+     * Scan all recorded nodes' memory blocks to check conflicts:
+     * Overlap or interleave.
+     */
+    for ( i = 0; i < num_node_memblks; i++ )
+    {
+        const struct node *nd = &node_memblk_range[i];
+
+        *mblkid = i;
+
+        /* Skip 0 bytes node memory block. */
+        if ( nd->start == nd->end )
+            continue;
+        /*
+         * Use memblk range to check memblk overlaps, include the
+         * self-overlap case. As nd's range is non-empty, the special
+         * case "nd->end == end && nd->start == start" also can be covered.
+         */
+        if ( nd->end > start && nd->start < end )
+            return OVERLAP;
+
+        /*
+         * Use node memory range to check whether new range contains
+         * memory from other nodes - interleave check. We just need
+         * to check full contains situation. Because overlaps have
+         * been checked above.
+         */
+        if ( nid != memblk_nodeid[i] &&
+             nd->start >= nd_start && nd->end <= nd_end )
+            return INTERLEAVE;
+    }
+
+    return NO_CONFLICT;
+}
+
+static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end)
+{
+    struct node *nd = &nodes[i];
+
+    if ( nd->start < start )
+    {
+        nd->start = start;
+        if ( nd->end < nd->start )
+            nd->start = nd->end;
+    }
+
+    if ( nd->end > end )
+    {
+        nd->end = end;
+        if ( nd->start > nd->end )
+            nd->start = nd->end;
+    }
+}
+
+bool __init numa_memblks_available(void)
+{
+    return num_node_memblks < NR_NODE_MEMBLKS;
+}
+
+/*
+ * This function will be called by NUMA memory affinity initialization to
+ * update NUMA node's memory range. In this function, we assume all memory
+ * regions belonging to a single node are in one chunk. Holes (or MMIO
+ * ranges) between them will be included in the node.
+ *
+ * So in numa_update_node_memblks, if there are multiple banks for each
+ * node, start and end are stretched to cover the holes between them, and
+ * it works as long as memory banks of different NUMA nodes don't interleave.
+ */
+bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid,
+                                     paddr_t start, paddr_t size, bool hotplug)
+{
+    unsigned int i;
+    bool next = false;
+    paddr_t end = start + size;
+    paddr_t nd_start = start;
+    paddr_t nd_end = end;
+    struct node *nd = &nodes[node];
+
+    /*
+     * For the node that already has some memory blocks, we will
+     * expand the node memory range temporarily to check memory
+     * interleaves with other nodes. We will not use this node
+     * temp memory range to check overlaps, because it will mask
+     * the overlaps in same node.
+     *
+     * Node with 0 bytes memory doesn't need this expansion.
+     */
+    if ( nd->start != nd->end )
+    {
+        if ( nd_start > nd->start )
+            nd_start = nd->start;
+
+        if ( nd_end < nd->end )
+            nd_end = nd->end;
+    }
+
+    /* It is fine to add this area to the nodes data it will be used later */
+    switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) )
+    {
+    case OVERLAP:
+        if ( memblk_nodeid[i] == node )
+        {
+            bool mismatch = !hotplug != !test_bit(i, memblk_hotplug);
+
+            printk("%sNUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n",
+                   mismatch ? KERN_ERR : KERN_WARNING, numa_fw_nid_name,
+                   arch_nid, start, end - 1,
+                   node_memblk_range[i].start, node_memblk_range[i].end - 1);
+            if ( mismatch )
+                return false;
+            break;
+        }
+
+        printk(KERN_ERR
+               "NUMA: %s %u [%"PRIpaddr", %"PRIpaddr"] overlaps with %s %u [%"PRIpaddr", %"PRIpaddr"]\n",
+               numa_fw_nid_name, arch_nid, start, end - 1, numa_fw_nid_name,
+               numa_node_to_arch_nid(memblk_nodeid[i]),
+               node_memblk_range[i].start, node_memblk_range[i].end - 1);
+        return false;
+
+    case INTERLEAVE:
+        printk(KERN_ERR
+               "NUMA： %s %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with %s %u memblk [%"PRIpaddr", %"PRIpaddr"]\n",
+               numa_fw_nid_name, arch_nid, nd_start, nd_end - 1,
+               numa_fw_nid_name, numa_node_to_arch_nid(memblk_nodeid[i]),
+               node_memblk_range[i].start, node_memblk_range[i].end - 1);
+        return false;
+
+    case NO_CONFLICT:
+        break;
+    }
+
+    if ( !hotplug )
+    {
+        node_set(node, memory_nodes_parsed);
+        nd->start = nd_start;
+        nd->end = nd_end;
+    }
+
+    printk(KERN_INFO "NUMA: Node %u %s %u [%"PRIpaddr", %"PRIpaddr"]%s\n",
+           node, numa_fw_nid_name, arch_nid, start, end - 1,
+           hotplug ? " (hotplug)" : "");
+
+    /* Keep node_memblk_range[] sorted by address. */
+    for ( i = 0; i < num_node_memblks; ++i )
+        if ( node_memblk_range[i].start > start ||
+             (node_memblk_range[i].start == start &&
+             node_memblk_range[i].end > end) )
+            break;
+
+    memmove(&node_memblk_range[i + 1], &node_memblk_range[i],
+            (num_node_memblks - i) * sizeof(*node_memblk_range));
+    node_memblk_range[i].start = start;
+    node_memblk_range[i].end = end;
+
+    memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i],
+            (num_node_memblks - i) * sizeof(*memblk_nodeid));
+    memblk_nodeid[i] = node;
+
+    if ( hotplug )
+    {
+        next = true;
+        if ( end > mem_hotplug )
+            mem_hotplug = end;
+    }
+
+    for ( ; i <= num_node_memblks; ++i )
+    {
+        bool prev = next;
+
+        next = test_bit(i, memblk_hotplug);
+        if ( prev )
+            __set_bit(i, memblk_hotplug);
+        else
+            __clear_bit(i, memblk_hotplug);
+    }
+
+    num_node_memblks++;
+
+    return true;
+}
+
+/*
+ * Sanity check to catch more bad SRATs (they are amazingly common).
+ * Make sure the PXMs cover all memory.
+ */
+static bool __init nodes_cover_memory(void)
+{
+    unsigned int i;
+
+    for ( i = 0; ; i++ )
+    {
+        int err;
+        unsigned int j;
+        bool found;
+        paddr_t start, end;
+
+        /* Try to loop memory map from index 0 to end to get RAM ranges. */
+        err = arch_get_ram_range(i, &start, &end);
+
+        /* Reached the end of the memory map? */
+        if ( err == -ENOENT )
+            break;
+
+        /* Skip non-RAM entries. */
+        if ( err )
+            continue;
+
+        do {
+            found = false;
+            for_each_node_mask ( j, memory_nodes_parsed )
+                if ( start < nodes[j].end && end > nodes[j].start )
+                {
+                    if ( start >= nodes[j].start )
+                    {
+                        start = nodes[j].end;
+                        found = true;
+                    }
+
+                    if ( end <= nodes[j].end )
+                    {
+                        end = nodes[j].start;
+                        found = true;
+                    }
+                }
+        } while ( found && start < end );
+
+        if ( start < end )
+        {
+            printk(KERN_ERR "NUMA: No node for RAM range: "
+                   "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1);
+            return false;
+        }
+    }
+
+    return true;
+}
+
+/* Use discovered information to actually set up the nodes. */
+static bool __init numa_process_nodes(paddr_t start, paddr_t end)
+{
+    int ret;
+    unsigned int i;
+    nodemask_t all_nodes_parsed;
+
+    /* First clean up the node list */
+    for ( i = 0; i < MAX_NUMNODES; i++ )
+        cutoff_node(i, start, end);
+
+    /* When numa is on and has data, we can start to process numa nodes. */
+    if ( arch_numa_unavailable() )
+        return false;
+
+    if ( !nodes_cover_memory() )
+    {
+        numa_fw_bad();
+        return false;
+    }
+
+    ret = compute_hash_shift(node_memblk_range, num_node_memblks,
+                             memblk_nodeid);
+    if ( ret < 0 )
+    {
+        printk(KERN_ERR
+               "NUMA: No NUMA node hash function found. Contact maintainer\n");
+        numa_fw_bad();
+        return false;
+    }
+    memnode_shift = ret;
+
+    nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed);
+
+    /* Finally register nodes */
+    for_each_node_mask ( i, all_nodes_parsed )
+    {
+        if ( nodes[i].end == nodes[i].start )
+            printk(KERN_INFO "NUMA: node %u has no memory\n", i);
+
+        setup_node_bootmem(i, nodes[i].start, nodes[i].end);
+    }
+
+    for ( i = 0; i < nr_cpu_ids; i++ )
+    {
+        if ( cpu_to_node[i] == NUMA_NO_NODE )
+            continue;
+        if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) )
+            numa_set_node(i, NUMA_NO_NODE);
+    }
+
+    numa_init_array();
+
+    return true;
+}
+
 /*
  * Given a shift value, try to populate memnodemap[]
  * Returns :
@@ -261,7 +600,7 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn)
 #endif
 
 #ifdef CONFIG_NUMA
-    if ( !numa_off && !numa_process_nodes(start, end) )
+    if ( !numa_off && numa_process_nodes(start, end) )
         return;
 #endif
 
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 62afb07bc6..07df36d475 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -159,6 +159,8 @@
 #define PGT_TYPE_INFO_INITIALIZER 0
 #endif
 
+paddr_t __ro_after_init mem_hotplug;
+
 /*
  * Comma-separated list of hexadecimal page numbers containing bad bytes.
  * e.g. 'badpage=0x3f45,0x8a321'.
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index a925028ab3..9d14aed74b 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -147,6 +147,8 @@ int assign_page(
 /* Dump info to serial console */
 void arch_dump_shared_mem_info(void);
 
+extern paddr_t mem_hotplug;
+
 /*
  * Extra fault info types which are used to further describe
  * the source of an access violation.
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 9da0e7d555..04ecaf7769 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -11,6 +11,7 @@
 #define NUMA_NO_DISTANCE 0xFF
 
 #define MAX_NUMNODES    (1 << NODES_SHIFT)
+#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
 
 #define vcpu_to_node(v) (cpu_to_node((v)->processor))
 
@@ -36,14 +37,16 @@ extern int compute_hash_shift(const struct node *nodes,
                               unsigned int numnodes, const nodeid_t *nodeids);
 
 extern bool numa_off;
+extern const char *numa_fw_nid_name;
 
 extern void numa_add_cpu(unsigned int cpu);
 extern void numa_init_array(void);
 extern void numa_set_node(unsigned int cpu, nodeid_t node);
 extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn);
-extern int numa_process_nodes(paddr_t start, paddr_t end);
+extern void numa_fw_bad(void);
 
 extern int arch_numa_setup(const char *opt);
+extern bool arch_numa_unavailable(void);
 extern bool arch_numa_disabled(void);
 extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end);
 
@@ -92,6 +95,11 @@ static inline nodeid_t __attribute_pure__ phys_to_nid(paddr_t addr)
  */
 extern int arch_get_ram_range(unsigned int idx,
                               paddr_t *start, paddr_t *end);
+extern bool valid_numa_range(paddr_t start, paddr_t end, nodeid_t node);
+extern bool numa_memblks_available(void);
+extern bool numa_update_node_memblks(nodeid_t node, unsigned int arch_nid,
+                                     paddr_t start, paddr_t size, bool hotplug);
+extern void numa_set_processor_nodes_parsed(nodeid_t node);
 
 #endif
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426159.674481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOq5-00049z-2d; Thu, 20 Oct 2022 06:15:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426159.674481; Thu, 20 Oct 2022 06:15:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOq4-00049m-SU; Thu, 20 Oct 2022 06:15:32 +0000
Received: by outflank-mailman (input) for mailman id 426159;
 Thu, 20 Oct 2022 06:15:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olOq3-0003rE-KV; Thu, 20 Oct 2022 06:15:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olOq3-00083u-GE; Thu, 20 Oct 2022 06:15:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olOq3-0006UC-7y; Thu, 20 Oct 2022 06:15:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olOq3-0007f9-7V; Thu, 20 Oct 2022 06:15:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9RLsRijtgLxGopU4LtONmiBijAqdtGhBUJoom6AmaOs=; b=GlODol01iv1fLYsJB6ZOuxCtri
	99ArQCtksNk4FLheDYt4MBznrnoi7rVYPlZ5dDuZv/Dk/WFwq5M/AFPjhm47KfK6Oin9XlNyYcxj8
	DCm6smNPpzrdu0LipvoCebx3pFEiIn/gdlxuHcJD387wNhaAjZVkpOrr3dllocidxyR4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174114-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174114: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 06:15:31 +0000

flight 174114 xen-unstable-smoke real [real]
flight 174120 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174114/
http://logs.test-lab.xenproject.org/osstest/logs/174120/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   12 days
Failing since        173492  2022-10-11 13:01:50 Z    8 days   56 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    2 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:15:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:15:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426168.674492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOqA-0004qO-Ai; Thu, 20 Oct 2022 06:15:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426168.674492; Thu, 20 Oct 2022 06:15:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOqA-0004q8-6w; Thu, 20 Oct 2022 06:15:38 +0000
Received: by outflank-mailman (input) for mailman id 426168;
 Thu, 20 Oct 2022 06:15:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=umfN=2V=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1olOq8-0002BJ-JW
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:15:36 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2078.outbound.protection.outlook.com [40.107.20.78])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9be27929-503e-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:15:35 +0200 (CEST)
Received: from DB6PR0301CA0017.eurprd03.prod.outlook.com (2603:10a6:4:3e::27)
 by GV2PR08MB8294.eurprd08.prod.outlook.com (2603:10a6:150:be::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 06:15:31 +0000
Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:3e:cafe::c) by DB6PR0301CA0017.outlook.office365.com
 (2603:10a6:4:3e::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 06:15:30 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Thu, 20 Oct 2022 06:15:30 +0000
Received: from e59f6ae725df.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5079A3B4-1269-479B-8134-37C4D0C37CFE.1; 
 Thu, 20 Oct 2022 06:15:24 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e59f6ae725df.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 06:15:24 +0000
Received: from DB8PR06CA0053.eurprd06.prod.outlook.com (2603:10a6:10:120::27)
 by PR3PR08MB5836.eurprd08.prod.outlook.com (2603:10a6:102:8f::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 06:15:15 +0000
Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:120:cafe::62) by DB8PR06CA0053.outlook.office365.com
 (2603:10a6:10:120::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:14 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 06:15:14 +0000
Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 20 Oct
 2022 06:15:13 +0000
Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com
 (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend
 Transport; Thu, 20 Oct 2022 06:15:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9be27929-503e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=F86P+aXwKA5pAx/4g5fxD2k3+JQ+y8vSr2rZJFhHy+q909rD0UWfFGxs+WqDQHp6naD/CrDBPna+DfU3hwHILIvFd8NXiy8j/aXt7Rip6wn3lzcotKVsNO9ZkB3WWNkVyttF6h9lC/ZWnThsirHT4xkBTiUT86XRneHrC5uAnPIetE/44JaqlgnJ7eqg+56FFWo8nTR2Crg1B//JmTFe6YjrwtduMZ2dU26WIkPajHMWMDAHY6vz+Z01dgkWUaFxTe5EJYVkfI4y5Hajr35mpliW7eKmIr1VSrHBPlPpGFhY98Yp0g0PLTjaO/e+gonZa+juCNFQkCDUGLXB21Wh7g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tKlQzekOAy2bagSwndJhdrniq14Z6mxEvy636QOfYxI=;
 b=EouQ5+3tZFCePXMB37F50eisLfeuQzrZkeLGFai7NPi6vIkgzv2i8nhp1ahVIREdZ4vhcsv3F1248WMPE9gXBqQcWKSz8r9diHplB4Ps4cfhrYl5Voki5ETM7ynkzFxMG2wu87Oxus8xS9viy/RBmQ4VlTsZmxq6qG6UMIjjY6EqsQr4wpYmgAE6rHWKTjfp2Hg8sc/d+qe+Qpr08HH8ziMhc1M/xsAwaUjqoiOE9trxriUVPKUNMbM4i5/3ABEa4au4hUTD75Di9mPXNQKjBQc7lPMVsRAYdU5yF9hQA22lOpui9Hes4aWHhVC1ZIJdPJpjrCxJULhXP4bZ8nDMdQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tKlQzekOAy2bagSwndJhdrniq14Z6mxEvy636QOfYxI=;
 b=B/aFMwQsvnR755a94r013Aoh7SsQtIW5U9BU43v5iElvaCi5bZhnRQkrP2EsJQGxfzBycWXZgNFs/vULlFCGwZztbDYzw0xbCZmrgMLv7SsUBKDjnPjxC+zsxozmOl+7+MG8avb7lJ8gYATyfugv8MANCRRZZFp/WZl+4mJHCnY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: daa77c44be242fcf
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ac6WMgSdYn3ArjqJQ+38eeMLWDcp8dwfvXTukB1xulfHo9Z2fskzp5bs97zke0/ge/tCI+FfUD1pM+ssllZEekAOmURMi9FU+R+6kh9l9sldZJxLeLkGjoF74AQgqpghBDNtTyC5788jgWPoYUXtDa4oUrX532orA+KUPTlgybYLsN/oGnAXH1WVLP/tDosspB1A9QRKfT/b69lFtrSsG6bI/Ttmf3CQC+bIwTM1MFJoCYrFWoiLZ/aFARn9SWFV533EsErJLoAqIgmmaeDv/qq/sQg8UYB9uyiYa+tTyLocdfuvmUv2nR1HRR8GBm77v8QwC63lvHNPhgpMSqWCbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tKlQzekOAy2bagSwndJhdrniq14Z6mxEvy636QOfYxI=;
 b=A4DIjfBUYPT76SBWDtZ1gOf9W0MRSmIyUqRj/9RDyU5hcwfZoW9aUwMVeXgstM/fx7hN82IYZS4RIA44Gp75p4qZKc2GK52HIiOxwLUkiU7jBuPC5cc2o8VkfadF9oVTui4t01/cLTbmi349c9EsXpRlWi2bJ1Dm4qPJhlQ64+pg5wciJ3wCsdzFvaJgzt7ojuEgj8zyhawvU/e0scgGn9jJqmhP0Eze7xk3FNH9MrPb0LYiaUuNIj2N8gCsDcaqaflngJi7NpQ/A/zSYtxxiqoZh3FDUGFIflyvybq3+mh0rtDuFDb43dsE2/Zh3sYvQ5pwb5HRnqBlqsWqKGcpaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tKlQzekOAy2bagSwndJhdrniq14Z6mxEvy636QOfYxI=;
 b=B/aFMwQsvnR755a94r013Aoh7SsQtIW5U9BU43v5iElvaCi5bZhnRQkrP2EsJQGxfzBycWXZgNFs/vULlFCGwZztbDYzw0xbCZmrgMLv7SsUBKDjnPjxC+zsxozmOl+7+MG8avb7lJ8gYATyfugv8MANCRRZZFp/WZl+4mJHCnY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com; pr=C
From: Wei Chen <wei.chen@arm.com>
To: <xen-devel@lists.xenproject.org>
CC: <nd@arm.com>, Wei Chen <wei.chen@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Jan
 Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v7 6/6] xen: introduce a Kconfig option to configure NUMA nodes number
Date: Thu, 20 Oct 2022 14:14:45 +0800
Message-ID: <20221020061445.288839-7-wei.chen@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221020061445.288839-1-wei.chen@arm.com>
References: <20221020061445.288839-1-wei.chen@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-TrafficTypeDiagnostic:
	DBAEUR03FT043:EE_|PR3PR08MB5836:EE_|DBAEUR03FT055:EE_|GV2PR08MB8294:EE_
X-MS-Office365-Filtering-Correlation-Id: e2fa41ce-95d3-41b1-7639-08dab2627d97
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 YWSwhB/g8a33ch7F4+tPT0ZFvK48E+Wi2RAj69ezdajYNP/1Mc5Y16xPvN5Bd5anvVj4DGeN5lWZepiv44OVel6FOLQigaGqZinQJTbs/tJ91LLTb4jShrvqUrhXjjLYwBi9hoz0TZBrrXaDol8Fq6a8RsEhRf5nMLsX0wGJwwdxuOFfRHsn+x2EGeTtLinGb1DsEOF0Jc3ZLQ6VMjlDBjzuua4d0kkUvIaaAlHkEwFqAD/Snv1hZ9/7fKsZfUQcMpcoRlD0RQ/xduQdOgQ1TQnOJ0MaC5jfsiLl5Y78jaGMAolt6Fvt+CbvnHBZ3JTrVCcHF5cX7borl47+QUJ23PGlANtJ8CWnhDurbbjDCI7xDS5NHIDb4yza9gAAJ9Ogz65qlCoAGVuANxPqqnDaQBpvBGOSjn8/8wId+3To/y6z3QU75Hvx2zodgQh2VNivsJkf/Tww8SOXURAj3DPHZFlDslArlkSx8oHMZ5qxmTZcWDSuVFyRMxbABluItk0OMMgkg9x3/pFSh+GPiV99HcmnrIBEo7OGflLm5fX+v1Ed5qSurP1q9joxLWt6g34XbErrezvR8OptqpQMY8GPyDrF3+4n1qs511SmK1hTo5AQrgXGo4bPVKorKL1XUQi9uyPrZ6sPkE8YklyJxjoxdhmvHLTKwCx0whmC7bD3q7haAO22GcEfNXMGmhgJqDJ029atZmJGNhhAD4gEK0mXVA/lEMcyhZrDJHQ1n3hApMbI755tBMNiv/sQzFYTFWXdisv27pdDJ5qJ0bbub0CPxJf9PqrQGq0tVFQv8761y6A=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(186003)(2616005)(6666004)(1076003)(336012)(36860700001)(47076005)(426003)(7696005)(83380400001)(40460700003)(2906002)(40480700001)(5660300002)(26005)(44832011)(54906003)(316002)(478600001)(82310400005)(41300700001)(8936002)(8676002)(6916009)(70586007)(4326008)(70206006)(36756003)(86362001)(356005)(81166007)(82740400003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5836
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f20fbc68-9b4c-44b9-d0cc-08dab26273d3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P4hH7y5oW8VsVrvJdtoCDddDsWTZaW+eSJM7tlFB1+KMplvEzrPTzJuAriBYKDIgQgn4CyV8+UZbZMv0WQkM6ew98QXGbhggR+EiDjicFVsv8jlIjWyrqpJ7IhEj1RUdNFlPpvzSnYBLy36CUeiCYi0oyVyfzaVrcgN1YpbruF9s2nyUa29yHKn0A0BKR8K+ex+F8oaFexj0lDUM1l8F+Ud4suK+FcMGSzyZZguwh/kvTOQVVCzq+/CfmlBNa5/0fYCwRQpGMScqv+9IlLWkwocrDfXyYT8FduMf85y1rBzpU3fFpZxOoWg7E16fQRJEfmNYQrX0RZUuPtXInOd2r269zE9oFxVgHpkV7Qq9EfKWHGNsTLw+++gm/YFgG1VhYG+1TMGlX4sZv4lh7DNWEPK/FqHf6jkMrTIUWbKfBX8rFU8LXM5zptOboKxlwa+zsDgtnPpl/ENZBq5GCMj2v40Jliu8VYZphL0TLTL3FlFgjKONB7HupEeWtn/MMVXCqF04UGsTixusocw8ZGcWaKAAuc9nT96bhtnBYEbwG8G2TzgzPWp0ibRUBTuNL1bC5kTPBBaDBehTlULx+/PnNOV1h72mljZoRkvU0x3iIhQvEyX0pQpqf7friyDE2rs2zIRWT7q+BKovFkPI56qZ/BZVGHAjLiRhz13ycc7dX4fAGrxF0bTX7wmXQNOikke6B1umEdJ61HOIh8e3dgrvD/sU3KSKhV+XEsEf8RfWIeKNDLlv7itCKzQ/APSAangp5rXm0yR2tFOJtIni51YLVO6O0gZ/dfGLzaaFd68HJBO/27DuW+/9Wa33Xf23KuMd
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(8936002)(44832011)(41300700001)(2906002)(5660300002)(54906003)(4326008)(8676002)(36756003)(82740400003)(70206006)(86362001)(6666004)(36860700001)(6916009)(26005)(70586007)(7696005)(107886003)(316002)(2616005)(186003)(478600001)(83380400001)(40480700001)(82310400005)(426003)(1076003)(81166007)(336012)(47076005)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:15:30.9807
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e2fa41ce-95d3-41b1-7639-08dab2627d97
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8294

Currently the maximum number of NUMA nodes is a hardcoded value.
This provides little flexibility unless changing the code.

Introduce a new Kconfig option to change the maximum number of
NUMA nodes conveniently. Also considering that not all
architectures support NUMA, this Kconfig option is only visible
on NUMA enabled architectures. Architectures not supporting NUMA
still use 1 for MAX_NUMNODES.

As NODES_SHIFT is currently unused, we're taking this
opportunity to remove it.

Signed-off-by: Wei Chen <wei.chen@arm.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
v6 -> v7:
1. No change.
v5 -> v6:
1. No change.
v4 -> v5:
1. No change.
v3 -> v4:
1. Update the commit log to follow Jan's suggestion.
2. Add Ack-by.
v2 -> v3:
1. Fix indent.
2. Use 2-64 for node range.
v1 -> v2:
1. Add NODES_SHIFT remove message in commit log
2. Change NR_NUMA_NODES upper bound from 4095 to 255.
---
 xen/arch/Kconfig                | 11 +++++++++++
 xen/arch/x86/include/asm/numa.h |  2 --
 xen/include/xen/numa.h          | 11 ++++++-----
 3 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig
index f16eb0df43..7028f7b74f 100644
--- a/xen/arch/Kconfig
+++ b/xen/arch/Kconfig
@@ -17,3 +17,14 @@ config NR_CPUS
 	  For CPU cores which support Simultaneous Multi-Threading or similar
 	  technologies, this the number of logical threads which Xen will
 	  support.
+
+config NR_NUMA_NODES
+	int "Maximum number of NUMA nodes supported"
+	range 2 64
+	default "64"
+	depends on NUMA
+	help
+	  Controls the build-time size of various arrays and bitmaps
+	  associated with multiple-nodes management. It is the upper bound of
+	  the number of NUMA nodes that the scheduler, memory allocation and
+	  other NUMA-aware components can handle.
diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h
index 2ca3475271..7866afa408 100644
--- a/xen/arch/x86/include/asm/numa.h
+++ b/xen/arch/x86/include/asm/numa.h
@@ -3,8 +3,6 @@
 
 #include <xen/cpumask.h>
 
-#define NODES_SHIFT 6
-
 typedef u8 nodeid_t;
 
 extern int srat_rev;
diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h
index 04ecaf7769..71a5f837b3 100644
--- a/xen/include/xen/numa.h
+++ b/xen/include/xen/numa.h
@@ -3,14 +3,15 @@
 
 #include <asm/numa.h>
 
-#ifndef NODES_SHIFT
-#define NODES_SHIFT     0
-#endif
-
 #define NUMA_NO_NODE     0xFF
 #define NUMA_NO_DISTANCE 0xFF
 
-#define MAX_NUMNODES    (1 << NODES_SHIFT)
+#ifdef CONFIG_NR_NUMA_NODES
+#define MAX_NUMNODES CONFIG_NR_NUMA_NODES
+#else
+#define MAX_NUMNODES 1
+#endif
+
 #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
 
 #define vcpu_to_node(v) (cpu_to_node((v)->processor))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:17:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:17:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426188.674502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOrd-0006oL-MB; Thu, 20 Oct 2022 06:17:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426188.674502; Thu, 20 Oct 2022 06:17:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olOrd-0006oE-JW; Thu, 20 Oct 2022 06:17:09 +0000
Received: by outflank-mailman (input) for mailman id 426188;
 Thu, 20 Oct 2022 06:17:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olOrc-0006o0-RM; Thu, 20 Oct 2022 06:17:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olOrc-0008AE-Qf; Thu, 20 Oct 2022 06:17:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olOrc-0006YV-Ge; Thu, 20 Oct 2022 06:17:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olOrc-0000H7-G9; Thu, 20 Oct 2022 06:17:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/yVeFn5EHYIZcTym9MUTRny2fVOFegrs9uPBcR0w6XQ=; b=vsITL4hE8ATck0rJuwpBuS3uYO
	IeoCgL4HplLdo0J3nopI2IoscB58JB3ydye0s+yf3OhxnhFwPFy9qQGlKqSf7ZwZF7/6ki1014YXd
	y+okEAsJOePjWl2BwTz2l3CqFcl99jasxSQ0+aBmdHsv6mmW1iNqemRqE04F1/ZPQbnE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174116-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174116: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c6720db5ddffec747bb0b2830e528511b1a4bfb2
X-Osstest-Versions-That:
    ovmf=31b16384688df9ce0e8f59021fd667e47d7d3972
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 06:17:08 +0000

flight 174116 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174116/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c6720db5ddffec747bb0b2830e528511b1a4bfb2
baseline version:
 ovmf                 31b16384688df9ce0e8f59021fd667e47d7d3972

Last test of basis   174092  2022-10-19 12:10:19 Z    0 days
Testing same since   174116  2022-10-20 03:43:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  jdzhang <jdzhang@kunluntech.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   31b1638468..c6720db5dd  c6720db5ddffec747bb0b2830e528511b1a4bfb2 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 06:59:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 06:59:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426227.674526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olPWf-0002yN-2T; Thu, 20 Oct 2022 06:59:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426227.674526; Thu, 20 Oct 2022 06:59:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olPWe-0002yG-VM; Thu, 20 Oct 2022 06:59:32 +0000
Received: by outflank-mailman (input) for mailman id 426227;
 Thu, 20 Oct 2022 06:59:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t2Es=2V=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olPWd-0002yA-Hd
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 06:59:31 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam04on2069.outbound.protection.outlook.com [40.107.100.69])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bd793e1f-5044-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 08:59:29 +0200 (CEST)
Received: from MW4PR04CA0168.namprd04.prod.outlook.com (2603:10b6:303:85::23)
 by PH8PR12MB7109.namprd12.prod.outlook.com (2603:10b6:510:22f::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 06:59:26 +0000
Received: from CO1NAM11FT110.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:85:cafe::85) by MW4PR04CA0168.outlook.office365.com
 (2603:10b6:303:85::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Thu, 20 Oct 2022 06:59:26 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT110.mail.protection.outlook.com (10.13.175.125) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Thu, 20 Oct 2022 06:59:25 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct
 2022 01:59:24 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Thu, 20 Oct 2022 01:59:23 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd793e1f-5044-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RCyRsxSJ3rCWiTCUw0OEPFsUv7crPY10JKAbveOxg8qMGR/OwdXM4qbplGguGI774CQxZTy9bXgE9OZzUUHr2Y64yP1pseTpRyNl2bC40JgpZaSmqUILdl7qXGAD2tCDvfYBBQIs5zUr6SttF8qHOJxNMKsI0oN0ciPfq8L3i78q/hOEEUN4NH7Ip3b8au1pc5VdR0KVaXJp45HUMAmsBIm+Tp4Qkmm5HsYNdQfUxpDtUi1uT+gDdfxtPYcvJ3Ou3xD35/IQrQdjsNfkFOn220IkJp7ERSoQkf4TVwQ5AnElT4FYZnl43VYUCQ2xv1MlIwek7mI3WVUL6+WBstsvIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HoO7VQb2AeH+OR2oYqPOm2g8zTDm2n0Sc40MAmzf2ug=;
 b=az+J0O3fwkXg3wzwtYCsn5G9h/f95+lBk9VJVDZRmVU3/UtTQABGcvOLhgZz1YnoVV2GMDUUtYDB4CuKNhLhfRmCi24fvsuJjVn3/L/3idS9hE08Eaj100nk8mFSBcM9FRw2Ee+TH8pCdRycS5ZsKMEfhwXnVwMA+K1RhqZR4toqZAay+TmpcrL/a6Ib6dBQUJRkeGh2kdESS1oEh0XsTF3EQfgYhICmgl9Kuch9jYA7sJtRGmJrN88FxxO3EeYWOd5MqhxaO5fVFIUvMXpkDwcyvHo3v/i2QACsjUOYIxprcw9Efb67zlAodIUNtmy+eqj2rFLSH0g6iz2yosRg/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HoO7VQb2AeH+OR2oYqPOm2g8zTDm2n0Sc40MAmzf2ug=;
 b=Gv7088x9FzbEDKboMgAo8VaBnIzg4gmB5tpL3aeR2ApNKrldo4WioT8vFcrk2UTV/ts5KasVegcuFXuStRp1TrNq58mrBe0Z2baMhiU/v43vRIqebTBwvbC8e4uOJtuBYN9cNngBVJ07x39SumcBc8i494G9lIhObjtiGeRNFS8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <bc41f3a0-27ec-8bbe-a087-125acc20df2f@amd.com>
Date: Thu, 20 Oct 2022 08:59:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
To: Jiamei Xie <Jiamei.Xie@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
References: <20220927094727.12762-1-michal.orzel@amd.com>
 <20220927094727.12762-6-michal.orzel@amd.com>
 <AS8PR08MB7696D8C9D2239CC9ED2FE08F922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <AS8PR08MB7696D8C9D2239CC9ED2FE08F922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT110:EE_|PH8PR12MB7109:EE_
X-MS-Office365-Filtering-Correlation-Id: 791c16fe-498b-4dfb-1dc7-08dab268a00f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0XiFAUHaKuwxo1EMdnDdtbEtfGXuLTTBZnNIDasNi17yc0FQwZwfAj7JXOJl8R94hsGEuNescRV3uVA005/eRfwNG4PezM5DJ2cvFqefaiv5Z2fBTeV7520YNIDNYl+dtMxKZKUzhCQ22Aq6ZQuWIy96br96rURdYTH1gmM51nf0fGcXA+qLj8r2vEq+SpYrIHYg/0ehFL6EHCW9rpI52nDguX63EPBjlQQBmAfkX3ypkNGc8VNzoL0dAvLPGJ5Ny0q6zVEBDGOCVuHeXj9uc2MlNGqd1xryXKek4ZA15H16312scVy8P6yCOtaOdMcFEMfrW42lNlzRN9qGvbyS7+M8l+9O9wbJycEy6sJ2CNvHdN/HsgphRIWWZZgvX4PZkt1mQUeZDP3xgrllkNlMWkAGhiIKMcuH3b4X+lc1LieJdR5ZP/JP4Sg4kqGEpHhu8U2MiQ4GNC89HoQZo5zFGA8OWVb4Vr4nOLP+bE8zfbjjIZEzciJPFVZQka8NsU6XNNqTLtJE7aN4KcRyUEJ/3mWF/1fcXQIgPkDK6LS83Gm+nthJA6pL79h8CnnLlSSKjCXzYexjJRVuQRG68piCCCUAKDyIjovP3aZja8TB6Iosek+vkzg5hJfGcW127cyfXm5REEujehr9luw/ak8yw7cqvdFaOBtHXqw4lv23dddZGbaLuEK8WpeGfaDh8PDwhjGMC8iZ2OmUvjElQsH454mI3qK1p/wZ/IpGeVhEixYthiZnmmCah7GOOnl1mg6pzSeXAdKHLJP/36cPs4u7ltkla6/T9S9S5PFjbZ+CnIekf5zwHvAqjoczVS1pte5C4CX1LsxdvkVeubuglXOK8g==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(31686004)(356005)(478600001)(82740400003)(82310400005)(36860700001)(110136005)(186003)(2906002)(44832011)(36756003)(40460700003)(2616005)(41300700001)(47076005)(316002)(54906003)(16576012)(86362001)(70586007)(336012)(426003)(70206006)(8676002)(40480700001)(4326008)(81166007)(53546011)(5660300002)(26005)(31696002)(8936002)(83380400001)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 06:59:25.6315
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 791c16fe-498b-4dfb-1dc7-08dab268a00f
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT110.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7109

Hi Jiamei,

On 20/10/2022 05:00, Jiamei Xie wrote:
> 
> 
> Hi Michal,
> 
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
>> Michal Orzel
>> Sent: Tuesday, September 27, 2022 5:47 PM
>> To: xen-devel@lists.xenproject.org
>> Cc: Michal Orzel <michal.orzel@amd.com>; Doug Goldstein
>> <cardoe@cardoe.com>; Stefano Stabellini <sstabellini@kernel.org>
>> Subject: [PATCH v3 05/10] automation: Add Arm containers to containerize
>> script
>>
>> Script automation/scripts/containerize makes it easy to build Xen within
>> predefined containers from gitlab container registry. This script is
>> currently missing the helpers to select Arm containers, so populate the
>> necessary entries.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>> ---

> 
> [Jiamei Xie]
> I wonder if an default container for arm can be added. For example,  if
>  "CONTAINER=arm64 automation/scripts/containerize bash",
>  set the default CONTAINER as "registry.gitlab.com/xen-project/xen/alpine:3.12-arm64v8"
> 

It can be added doing the following:

diff --git a/automation/scripts/containerize b/automation/scripts/containerize
index 0f4645c4cccb..b395bd359ecf 100755
--- a/automation/scripts/containerize
+++ b/automation/scripts/containerize
@@ -25,7 +25,7 @@ die() {
 BASE="registry.gitlab.com/xen-project/xen"
 case "_${CONTAINER}" in
     _alpine) CONTAINER="${BASE}/alpine:3.12" ;;
-    _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;;
+    _alpine-arm64v8|_arm64) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;;
     _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;;
     _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;;
     _centos7) CONTAINER="${BASE}/centos:7" ;;

The question is whether it would be beneficial. After all you would still need to
type CONTAINER=arm64, whereas at the moment, you need to type CONTAINER=alpine-arm64v8.
TBH I'm not sure it is improving anything (?).

~Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 07:13:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 07:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426235.674537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olPk8-0005SR-AO; Thu, 20 Oct 2022 07:13:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426235.674537; Thu, 20 Oct 2022 07:13:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olPk8-0005SK-6v; Thu, 20 Oct 2022 07:13:28 +0000
Received: by outflank-mailman (input) for mailman id 426235;
 Thu, 20 Oct 2022 07:13:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oIjd=2V=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1olPk6-0005SD-4p
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 07:13:26 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2088.outbound.protection.outlook.com [40.107.21.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae934fd8-5046-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 09:13:22 +0200 (CEST)
Received: from FR3P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::10)
 by AS8PR08MB7912.eurprd08.prod.outlook.com (2603:10a6:20b:52b::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 07:13:11 +0000
Received: from VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:a2:cafe::da) by FR3P281CA0165.outlook.office365.com
 (2603:10a6:d10:a2::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.18 via Frontend
 Transport; Thu, 20 Oct 2022 07:13:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT021.mail.protection.outlook.com (100.127.144.91) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 07:13:11 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Thu, 20 Oct 2022 07:13:10 +0000
Received: from 6cf0697e2da6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B4E00039-58F1-4459-9878-3F8C5F6673B2.1; 
 Thu, 20 Oct 2022 07:13:05 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6cf0697e2da6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 07:13:05 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11)
 by DB9PR08MB7794.eurprd08.prod.outlook.com (2603:10a6:10:399::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 07:13:02 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c]) by AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 07:13:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae934fd8-5046-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=KQ8XhryxlTP/ucCbHUvPRh3rxe/38UY/a5WF887xJtGYCFvqL/ZCHLaaPaOGrxnkM4pvMDqzUi4U7dt+3OI3ZaQScFW7iiOuasCEZh4Tt4phjYQH/8WIJlEh0L3eWrLasguPmhfsdUxqm+2iKSt29uEDNA/RfjACmzURf7/ZmfK2NQpnj2RFyMc/FNQo+XHKNdtjdsfZtVAkqdypKv+mzNEVZTyoVbr6KG2Hg5nPHhRHP+/xZ6FJALA8tSGXBkXABwnkB7Aq2d4T2ZdRCT7RR4Zow6YMgTJKujSUo+2UHbOYn8/nPdd7V2KaWrmhL43uOOv4ZaLEEmHUByQ5j0MsEA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EyKUoMVuybSfdp647m3UxF7ky7nzDGlllppVmGA5Hsk=;
 b=bvwKa6Tlqzqystg5Q97COCVKi+C0rOCVLYbFbLlkavZxECn6NgPGndxPiJZ47kifbOFn2uOPKHYV6+1HS7vTL8uBWR3G+Wl+UE/ShLXYF8WGi0hEmrJHURqOVHZtolvdqdG9uSBJryUvyECj4yXsacKBJSSPUv5LCvoVi+jCb+cb9xqWd0cC6n01EWPpa+l5mMvRQLtFpxOkZT4NlZSRc/3nQK8XuMt/IKjxE3HcNBZCy0k9VDo1TD6o0sPVGFJDLyiOKozspdA+ee5KLrFOsFmxhcZRvADhXNLoz8O6Mdi2N4p+ZDtzqZaM0pmTDDgW7aOF7f2zyRzm39XKjjQzSg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EyKUoMVuybSfdp647m3UxF7ky7nzDGlllppVmGA5Hsk=;
 b=YzkF2tyOyjt+3HMu3DUWsN04Wp9MEGAlDh9VL0HMsBXyvBRZO61hMuye/3rW7cYfcP3IWTSUegTs9K/0RvTD3FeoBn/gk9VUqYT6fEpUXnK7M8oU0ZgjP8T8SnikGHNu3PVcutmS62uwgZBaaN5v+d49vKfh3R1SMn+FN3k4PCU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AkljyGTTI7CCCgt0Kld2zNEeCSqrwKd1IPO8VQNPVDyhG8fXVu0KXwv4/uIj58hREHWFObcSH13cSnAhNfcNVHtn4E5IXVN8RhdwEs0BQYPMLgIKemqrU2nzdulE9bwVoZvKJLXKRzo+kDi47VlSmyebKQQE2+fE1Lu8RpA7CWxW7Ych+c7R/8g4Rc3FHB5BtsrJYU6lzrj9zM6d+eSdbHScSC8kdnBOsPCZCtGauBMiX5d4MWl10Rn6nLZgNMhi4+QZAHUZ4qy63+uGK8ftzdaJKNJ4YdPhN/ASCN4GuEaNr2Rxv7MXUR03W//lQInHlaCktbB4SiglGrFPsj4i0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EyKUoMVuybSfdp647m3UxF7ky7nzDGlllppVmGA5Hsk=;
 b=gBPclVpJw6hzHfevuTLBPHIQ6Z3sjh/6jLYpqFvbowqXSvbUSVxcp/FG9559naskmFfjdxxveQLzrQsHz5RY6dkdzlloij6VwAToMZK/IvwieDAEZ2wXwnBhCkQmjewUB+srbF5dfW9Bd1VgLD1Sa/57FjT1Tss6HM0mdkLGrd0F0AaTm2PneEmpULGJ1oXLYDAYIfFI40OhoytaCbnPzHngxpC0YTofGT6O/9OFXAI3a734qmaS9kT7N9QlKENG1Epz55dJxHt1iyLBu5RaqEyVLWnuMV4wyinH8/jYEY1gTaIt5HQML5rCK0tsvAsoojUAg188oY0OrPTEYI8Ccw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EyKUoMVuybSfdp647m3UxF7ky7nzDGlllppVmGA5Hsk=;
 b=YzkF2tyOyjt+3HMu3DUWsN04Wp9MEGAlDh9VL0HMsBXyvBRZO61hMuye/3rW7cYfcP3IWTSUegTs9K/0RvTD3FeoBn/gk9VUqYT6fEpUXnK7M8oU0ZgjP8T8SnikGHNu3PVcutmS62uwgZBaaN5v+d49vKfh3R1SMn+FN3k4PCU=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: RE: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Thread-Topic: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Thread-Index: AQHY0lZFu/mKHMVlEk6rDAaZCITsX64Ws3HQgABK2QCAAAFz0A==
Date: Thu, 20 Oct 2022 07:13:02 +0000
Message-ID:
 <AS8PR08MB769676050B41BCEDCA3F2891922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
References: <20220927094727.12762-1-michal.orzel@amd.com>
 <20220927094727.12762-6-michal.orzel@amd.com>
 <AS8PR08MB7696D8C9D2239CC9ED2FE08F922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
 <bc41f3a0-27ec-8bbe-a087-125acc20df2f@amd.com>
In-Reply-To: <bc41f3a0-27ec-8bbe-a087-125acc20df2f@amd.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: CFA5B327AFA34147A0B8048A9BF68C90.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7696:EE_|DB9PR08MB7794:EE_|VI1EUR03FT021:EE_|AS8PR08MB7912:EE_
X-MS-Office365-Filtering-Correlation-Id: 72f624a2-b16d-4dc7-6d78-08dab26a8c24
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 fAiu6ikI9VcUr88CIz0Ho2l6E+ggQsqQDFTXdoL8KkxYPfpwKXykjI4zD2NMkuxw0zs8+u9L3vlQq3FdtOAOs9TE4XVarwcaQepv+wkjKX2ra8KVpZ7mo9eLc9ieNHjYGXoCIKNNThl8hcvHCVF6JwkUnQr2inCVB/YnY23vfldYScKjtHlk7fNx3yZGGpRGoeMbSS5faUO5hzxH4tzLYlZGONw9pAAAzMrMAoSD4zkBD+kF2eYAvVRLrMD/65iiG9PUR4Xm601UB+DQydOFdsVfwwZtDgZH5J9gm+3h3e1oGswZy6MTYfSFyjwrRQew8V794FRiUZKdSA4vl1MmG7sPUyFxEvCuQeAhkFWanoZk5cozoepbj9KFw+5MV5Na/lt87mvZ0x8CgxNaFKFYVOIUX3os9yGsWepz0QXiuCh+n/eFB1mkc+LQyGdRYEf8EbqCgCME5LbqKqFFsCD/Sm/26cscNBD4CwteJfqhhWefBMDubT+LFGkzLjC9cvb5gBB6m1OYF0pS6WxB5cbIV06oqNth2D5gg8WxiAwelb7ckQzB1+Rof+fDmHDYrHSTSq0l0D1pFC/eyxL9RgmrGfL6qVeN6mbez4knyu2cwAr3WiOjmtX+W/efQReWZtmtJ2bKux+zSulw9W8JvUezVr80XNwG/A1rY6Zdn/IzRA1Lomd93FsPPPT75C4FqNK1tAR2QJAhd8IWDRSBUMN8pfIDhQL5ZLBtzw7kgVHwdWUe5lrtUuBYI5hhT9JclsuZBS5oz8FNvOB3MTq1Ekg6UNk3lclfwJUypke5b9F5ml0=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199015)(66446008)(84970400001)(316002)(110136005)(66476007)(76116006)(64756008)(55016003)(4326008)(41300700001)(66556008)(38100700002)(8676002)(54906003)(71200400001)(7696005)(33656002)(66946007)(122000001)(38070700005)(186003)(53546011)(26005)(478600001)(86362001)(6506007)(9686003)(83380400001)(2906002)(52536014)(5660300002)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7794
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f124069a-f591-425d-74d4-08dab26a86d1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s6zSVsVyvx1rjg8KFJA4OJFUZzdRpin5LZ8sSghuS3iN2UY6bC5uLU2tkzUCJuEadY8PWE8hw1NH0hjenl/eWQjZOv2vx/Y5WuJeuMDfQ3rG5wSxZDvGL1HjSoiipHGWKAfpDu35tUzn+tchEWBKvgGRhG1TGe/cRGmmEc/Zyy5EvdlpvzL+TYdQkTtjps2F7tLWGPWjslslOQcgttqdxokpgQxHoOWf4ymogeaQGTxPTmW6jPCOL6cTHftKxJ4boKt4X77TyGuRWw+S7pKDcS2W4crmAOnM9spnBDKKns+y797h0qi5v/LtPb16e1S4BB+o6t0mB2zetH1gJD4eZzvoJX4NeNekhDt1dO0mbVLGpmI3d5jEQ96Ai6cw9SIM9Hi5Cvijbyy/YjHl9GcoOyOYhGqLDFRMqgC02ih5UpJRjMYuEKqz3QyfLmEsE6quTwP0809DvLzn3P/zD4f2SqP4C0UmVJtpuJ8LyXCuHNFSp2QnEdRB1DceoC0HuGUk58UF9GHYY+3LHih97WFeWMqePL7BjM3WVTJUQMwabhfJYsvhnDyKUZtwdzk1J3oFWDRfBxyfb885BahCAFhaYcAiwXOxLnWvh5/1b/NWzmpl+FbiHe0oe/3DBzSla1EgpXDmYyrz5a9ZS4EoDPhL3NMYvtxx6/xisy3eYU0oboOeet8mUJoieaGiCi9EWVNnFmxqS7smnZ166Sq5SMEleZbXvYosl4xX7UrdiHPPuP2mt1yjPwnLPS+0YX1ogX8D6No+65eKvAVg5T/A0RLzGm7tn6ZKy1030JdhH/1yOKU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(82740400003)(81166007)(356005)(47076005)(9686003)(52536014)(86362001)(5660300002)(6506007)(8676002)(8936002)(41300700001)(26005)(70206006)(70586007)(53546011)(7696005)(40480700001)(4326008)(55016003)(40460700003)(2906002)(336012)(110136005)(82310400005)(54906003)(33656002)(186003)(316002)(36860700001)(107886003)(84970400001)(478600001)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 07:13:11.2727
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 72f624a2-b16d-4dc7-6d78-08dab26a8c24
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7912

SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh
bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+IFNlbnQ6IFRodXJzZGF5LCBPY3RvYmVy
IDIwLCAyMDIyIDI6NTkgUE0NCj4gVG86IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT47
IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogRG91ZyBHb2xkc3RlaW4gPGNh
cmRvZUBjYXJkb2UuY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJu
ZWwub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDA1LzEwXSBhdXRvbWF0aW9uOiBBZGQg
QXJtIGNvbnRhaW5lcnMgdG8NCj4gY29udGFpbmVyaXplIHNjcmlwdA0KPiANCj4gSGkgSmlhbWVp
LA0KPiANCj4gT24gMjAvMTAvMjAyMiAwNTowMCwgSmlhbWVpIFhpZSB3cm90ZToNCj4gPg0KPiA+
DQo+ID4gSGkgTWljaGFsLA0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+
ID4+IEZyb206IFhlbi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5v
cmc+IE9uIEJlaGFsZiBPZg0KPiA+PiBNaWNoYWwgT3J6ZWwNCj4gPj4gU2VudDogVHVlc2RheSwg
U2VwdGVtYmVyIDI3LCAyMDIyIDU6NDcgUE0NCj4gPj4gVG86IHhlbi1kZXZlbEBsaXN0cy54ZW5w
cm9qZWN0Lm9yZw0KPiA+PiBDYzogTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT47
IERvdWcgR29sZHN0ZWluDQo+ID4+IDxjYXJkb2VAY2FyZG9lLmNvbT47IFN0ZWZhbm8gU3RhYmVs
bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gPj4gU3ViamVjdDogW1BBVENIIHYzIDA1
LzEwXSBhdXRvbWF0aW9uOiBBZGQgQXJtIGNvbnRhaW5lcnMgdG8NCj4gY29udGFpbmVyaXplDQo+
ID4+IHNjcmlwdA0KPiA+Pg0KPiA+PiBTY3JpcHQgYXV0b21hdGlvbi9zY3JpcHRzL2NvbnRhaW5l
cml6ZSBtYWtlcyBpdCBlYXN5IHRvIGJ1aWxkIFhlbiB3aXRoaW4NCj4gPj4gcHJlZGVmaW5lZCBj
b250YWluZXJzIGZyb20gZ2l0bGFiIGNvbnRhaW5lciByZWdpc3RyeS4gVGhpcyBzY3JpcHQgaXMN
Cj4gPj4gY3VycmVudGx5IG1pc3NpbmcgdGhlIGhlbHBlcnMgdG8gc2VsZWN0IEFybSBjb250YWlu
ZXJzLCBzbyBwb3B1bGF0ZSB0aGUNCj4gPj4gbmVjZXNzYXJ5IGVudHJpZXMuDQo+ID4+DQo+ID4+
IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4+
IEFja2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+
ID4+IC0tLQ0KPiANCj4gPg0KPiA+IFtKaWFtZWkgWGllXQ0KPiA+IEkgd29uZGVyIGlmIGFuIGRl
ZmF1bHQgY29udGFpbmVyIGZvciBhcm0gY2FuIGJlIGFkZGVkLiBGb3IgZXhhbXBsZSwgIGlmDQo+
ID4gICJDT05UQUlORVI9YXJtNjQgYXV0b21hdGlvbi9zY3JpcHRzL2NvbnRhaW5lcml6ZSBiYXNo
IiwNCj4gPiAgc2V0IHRoZSBkZWZhdWx0IENPTlRBSU5FUiBhcyAicmVnaXN0cnkuZ2l0bGFiLmNv
bS94ZW4tDQo+IHByb2plY3QveGVuL2FscGluZTozLjEyLWFybTY0djgiDQo+ID4NCj4gDQo+IEl0
IGNhbiBiZSBhZGRlZCBkb2luZyB0aGUgZm9sbG93aW5nOg0KPiANCj4gZGlmZiAtLWdpdCBhL2F1
dG9tYXRpb24vc2NyaXB0cy9jb250YWluZXJpemUNCj4gYi9hdXRvbWF0aW9uL3NjcmlwdHMvY29u
dGFpbmVyaXplDQo+IGluZGV4IDBmNDY0NWM0Y2NjYi4uYjM5NWJkMzU5ZWNmIDEwMDc1NQ0KPiAt
LS0gYS9hdXRvbWF0aW9uL3NjcmlwdHMvY29udGFpbmVyaXplDQo+ICsrKyBiL2F1dG9tYXRpb24v
c2NyaXB0cy9jb250YWluZXJpemUNCj4gQEAgLTI1LDcgKzI1LDcgQEAgZGllKCkgew0KPiAgQkFT
RT0icmVnaXN0cnkuZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC94ZW4iDQo+ICBjYXNlICJfJHtDT05U
QUlORVJ9IiBpbg0KPiAgICAgIF9hbHBpbmUpIENPTlRBSU5FUj0iJHtCQVNFfS9hbHBpbmU6My4x
MiIgOzsNCj4gLSAgICBfYWxwaW5lLWFybTY0djgpIENPTlRBSU5FUj0iJHtCQVNFfS9hbHBpbmU6
My4xMi1hcm02NHY4IiA7Ow0KPiArICAgIF9hbHBpbmUtYXJtNjR2OHxfYXJtNjQpIENPTlRBSU5F
Uj0iJHtCQVNFfS9hbHBpbmU6My4xMi1hcm02NHY4IiA7Ow0KPiAgICAgIF9hcmNobGludXh8X2Fy
Y2gpIENPTlRBSU5FUj0iJHtCQVNFfS9hcmNobGludXg6Y3VycmVudCIgOzsNCj4gICAgICBfcmlz
Y3Y2NCkgQ09OVEFJTkVSPSIke0JBU0V9L2FyY2hsaW51eDpyaXNjdjY0IiA7Ow0KPiAgICAgIF9j
ZW50b3M3KSBDT05UQUlORVI9IiR7QkFTRX0vY2VudG9zOjciIDs7DQo+IA0KPiBUaGUgcXVlc3Rp
b24gaXMgd2hldGhlciBpdCB3b3VsZCBiZSBiZW5lZmljaWFsLiBBZnRlciBhbGwgeW91IHdvdWxk
IHN0aWxsIG5lZWQNCj4gdG8NCj4gdHlwZSBDT05UQUlORVI9YXJtNjQsIHdoZXJlYXMgYXQgdGhl
IG1vbWVudCwgeW91IG5lZWQgdG8gdHlwZQ0KPiBDT05UQUlORVI9YWxwaW5lLWFybTY0djguDQo+
IFRCSCBJJ20gbm90IHN1cmUgaXQgaXMgaW1wcm92aW5nIGFueXRoaW5nICg/KS4NCj4gDQo+IH5N
aWNoYWwNCltKaWFtZWkgWGllXSANCkkgYW0gbm90IHN1cmUgYWJvdXQgdGhpcyBlaXRoZXIuICBJ
IGFkZGVkIHNvbWV0aGluZyBsaWtlIGJlbG93IGYgdG8gcnVuIGl0IG9uIGFybTY0IG1hY2hpbmUu
ICAgQnV0IGl0ICBkaWRuJ3QgdGFrZSAicnVubmluZyBjb250YWluZXIgZm9yIGEgZGlmZmVyZW50
IGFyY2hpdGVjdHVyZSIgaW50byBjb25zaWRlcmF0aW9uLg0KDQotLS0gYS9hdXRvbWF0aW9uL3Nj
cmlwdHMvY29udGFpbmVyaXplDQorKysgYi9hdXRvbWF0aW9uL3NjcmlwdHMvY29udGFpbmVyaXpl
DQpAQCAtMTgsNiArMTgsMTIgQEAgZGllKCkgew0KICAgICBleGl0IDENCiB9DQoNCisjIFRoZXJl
IGFyZSB0d28gY29udGFpbmVycyB0aGF0IGNhbiBydW4gb24gYWFyY2g2NCwgdW5zdGFibGUgYW5k
IGFscGluZS4NCisjIFNldCB0aGUgZGVmYXVsdCBjb250YWluZXIgdG8gYWxwaW5lIGZvciBhYXJj
aDY0DQoraWYgW1sgJCh1bmFtZSAtbSkgPSAiYWFyY2g2NCIgJiYgLXogJHtDT05UQUlORVJ9IF1d
OyB0aGVuDQorICAgIENPTlRBSU5FUj0iYWxwaW5lIg0KK2ZpDQorDQogIw0KICMgVGhlIGNhbGxl
ciBpcyBleHBlY3RlZCB0byBvdmVycmlkZSB0aGUgQ09OVEFJTkVSIGVudmlyb25tZW50DQogIyB2
YXJpYWJsZSB3aXRoIHRoZSBjb250YWluZXIgdGhleSB3aXNoIHRvIGxhdW5jaC4NCkBAIC00MSw2
ICs0NywxMSBAQCBjYXNlICJfJHtDT05UQUlORVJ9IiBpbg0KICAgICBfb3BlbnN1c2UtdHVtYmxl
d2VlZHxfdHVtYmxld2VlZCkgQ09OVEFJTkVSPSIke0JBU0V9L3N1c2U6b3BlbnN1c2UtdHVtYmxl
d2VlZCIgOzsNCiBlc2FjDQoNCisjIENvbnRhaW5lcnMgZm9yIGFhcmNoNjQgaGF2ZSBhIHN1Zml4
ICItYXJtNjR2OCINCitpZiBbWyAkKHVuYW1lIC1tKSA9ICJhYXJjaDY0IiBdXTsgdGhlbg0KKyAg
ICBDT05UQUlORVI9IiR7Q09OVEFJTkVSfS1hcm02NHY4Ig0KK2ZpDQorDQogIyBVc2UgdGhpcyB2
YXJpYWJsZSB0byBjb250cm9sIHdoZXRoZXIgcm9vdCBzaG91bGQgYmUgdXNlZA0KIGNhc2UgIl8k
e0NPTlRBSU5FUl9VSUQwfSIgaW4NCiAgICAgXzEpICAgdXNlcmFyZz0gOzsNCg0KDQpCZXN0IHdp
c2hlcw0KSmlhbWVpIFhpZQ0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 07:45:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 07:45:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426243.674554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQFA-0000TA-MC; Thu, 20 Oct 2022 07:45:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426243.674554; Thu, 20 Oct 2022 07:45:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQFA-0000T3-IN; Thu, 20 Oct 2022 07:45:32 +0000
Received: by outflank-mailman (input) for mailman id 426243;
 Thu, 20 Oct 2022 07:45:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tvbq=2V=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1olQF9-0000Sx-K5
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 07:45:31 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2086.outbound.protection.outlook.com [40.107.104.86])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2bb0d336-504b-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 09:45:30 +0200 (CEST)
Received: from AS8PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:313::16)
 by AM0PR08MB5425.eurprd08.prod.outlook.com (2603:10a6:208:17d::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 07:45:25 +0000
Received: from VI1EUR03FT053.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:313:cafe::a4) by AS8PR04CA0071.outlook.office365.com
 (2603:10a6:20b:313::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Thu, 20 Oct 2022 07:45:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT053.mail.protection.outlook.com (100.127.144.132) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 07:45:24 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Thu, 20 Oct 2022 07:45:24 +0000
Received: from 02c7f9d7cb5a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C5C87A2F-37C4-49AB-8467-DB02F08208D4.1; 
 Thu, 20 Oct 2022 07:45:18 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 02c7f9d7cb5a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 07:45:18 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM8PR08MB5665.eurprd08.prod.outlook.com (2603:10a6:20b:1da::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 07:45:17 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 07:45:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bb0d336-504b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=XNsW2v1v9PTkpX7rMysTQymiQZTXy78X4Y2rTlxinvGbJ3FkDaZKuN5eTIMKX02uGN+CC8wVtT2MVFQwEkORmR9OlgFuziO1etWn2SlmnEQMIBMnTKgjHWmwRegKFik6rm5W8ART+WbsexT01U3vJb9BjO0MBUMU8gzS9TJNheKUVTmiOiPtfGOeOLXxIumF4AKv1mHB2Qz32shKr9O1Na8m3d89K6SybGtz8GfXCZ1UUlR3YM50RBun5S79cfWSP1w4n2cJ23Yuyp5IXZXS75EeF4dSfehy+0ZcH5JXLAZaf6XR5OZkdwsWUDlcZO6U8b8Nvq3B8ucfAt27/KUTeg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pakc4jwgdwAmapOlRtJkMWGKWBnO41Nij/FL96uvn18=;
 b=NwwpffyN5TEgSpsDsHTBGfTN0djJtf9Rhk3TulOKCsE3/aeeudT7/hp8MMVf0G/gLrZcSJZn6tejY2dIRE7tRhnJ5EISwsWiDXIwAwAtr93xjb4rIMwvfUsBhkZaLDBG6OmJDV60HgqX6Sc2EcQFlwfRRWvaZMyKL3i/7mNMzrorju9mTSunpSY9agbf4y+9FDFp3T7a4FbbCwKGrVOR1IMpqw/X2p1XGmKLQToQF1AGGa2hY/VO1NFCiLMAC04kl4ZYYoOo073FJHRMW64HbDAlTcNJ+ycfdltoIeItZHSLtnUY5wbWeNiTIXauNmsZQiSEqb130L2SEP7vaGz3Cg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pakc4jwgdwAmapOlRtJkMWGKWBnO41Nij/FL96uvn18=;
 b=z8kBFDITuKjrXvcbQ1JxWC68PmAzTem7fQBzotc3ANwmANJE4q9ZU0kWqGeF6W/3ira32hvLqm/VolgVVwNFqn256wTYDzq1WUsgAuidNnxBw9GHUMZl6uwdSOgHMz4AKDSOthu7dfYweHruNQQyWDEpSs5b/f/aZMtoW107DNI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: e765eca24e2a4053
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RNwx7000mYo9GhqIyXLOcAWnaUmmvXTpVTtoos3TDkXAkr/QAHzJGNRrZkZO1kGjen1lGqDE5sxJw+WZ0sDhwBF+l+YyskK6PlRSsinoHPLhiVNvpwUV3OwUQdPdriX6xW1DK71fQZ7BzuX69ksDyetlknmx31mpc5NsCEp7yKiqJvAMDNPRaV1iwwYlNklq9fm0V7Uj1vrvXBsjpxzlctC7LS4yRa19BTGjypKoy56tKSLAq2k06uBaU767w+v2Ggdvfsqo5Aehp6dFeQVstYcWsXE4MyXeoWRldZULZn10pTQu/S42MHVm0QFayTykAfFFcu7Bc/Sggq2/YdvGFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pakc4jwgdwAmapOlRtJkMWGKWBnO41Nij/FL96uvn18=;
 b=ms3m+/nA2l89hz4YODGUIvJbz41XAsU8Q9bwAmPqFG6Fa4kRhqNl08qiDgcgPbjS2kE32GrNiywkWRL+a9mRcBY3s67Kv8wWlTlCwHTTAlT5n8NWeNQ4+IPqYe1tO+Mvnsi85gKgtD9WoUiJS4vMlqwbpljuOwP3ium18JmV/ZKBSHEUppTn9PtrASolNAhwRYAkLsGZp5G+vtuSUrFTLiAylv+Q9V79fpSst3Y3DcfE7B0SznpcE24GMwpXRK4VN2+qXW+XMxQD7D8nVcZhkqgRvkVjfiyptbmO9RbXWfqk2YYiZkNjZJS8RC0Cf/wxpHYd9oaR1/7p3agcf6iQUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pakc4jwgdwAmapOlRtJkMWGKWBnO41Nij/FL96uvn18=;
 b=z8kBFDITuKjrXvcbQ1JxWC68PmAzTem7fQBzotc3ANwmANJE4q9ZU0kWqGeF6W/3ira32hvLqm/VolgVVwNFqn256wTYDzq1WUsgAuidNnxBw9GHUMZl6uwdSOgHMz4AKDSOthu7dfYweHruNQQyWDEpSs5b/f/aZMtoW107DNI=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Henry Wang <Henry.Wang@arm.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Topic: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Thread-Index:
 AQHY4lyDZWCrsBxeFk+1cow2xbojCa4TC2qAgAAU4ACAABPHgIADC1WAgAARXoCAAJpKAA==
Date: Thu, 20 Oct 2022 07:45:15 +0000
Message-ID: <B9C56976-BBC7-4A0B-9D9E-E26492FDA446@arm.com>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
 <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
 <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
 <5587f5bd-1694-a843-9e80-ad477527a576@xen.org>
 <dffdc951-91fd-2659-ec7f-5c213138d785@citrix.com>
 <f200534c-c001-3ec0-7e05-cdbb76f456e3@xen.org>
In-Reply-To: <f200534c-c001-3ec0-7e05-cdbb76f456e3@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AM8PR08MB5665:EE_|VI1EUR03FT053:EE_|AM0PR08MB5425:EE_
X-MS-Office365-Filtering-Correlation-Id: a3f1eb0e-56dc-4343-d74b-08dab26f0cbc
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jrEn6HO1y3Wx286us77T2kB0TzNJKotp5E3DWUMhtaFl1DifjZnufG4qnHTuKT/j32Ze71kZRmCUa3300FUtNTg+o8Z0c9zaNU6C26ToCBA3jfnzhaM1bC079cVWUMMzYY6rjR6qcNz8tt55iPYAogwHP5CYKt4sfctFwW06BWP6y/O7L+h1k/qEKkwKB4kAS+yPAxEpY9oBcbw9LCQFJlpThCXagZzb0RGcCjQz4Wzhb72qrfy76lazIiERwZ07+WsCGdoc+fNRB8mgZBgk9AiCDuKwx0Va9EQrYqka0di2nXta3UPTlRhzV8mAsnZf3kPToxdM7cAbTKgtH6zAt8frBiGPkouUnXBWvsA1uWoQ6372Q6dTxj3FZapbk/xGzM2l+CCWVStCTDf2swjFHmMeDvv+XV0D767jBRxErTpUoHLFArs8KwuMyNF1EDpiM+ZzCYfqj2/1iks3tE2zuk0+4UbiPkQi3AxKVXp3D3gI/w8YMmiSa3PeG7Y3tUlvcimEAOKJl7lirMu+pqdHHlu8eqw8+heSd8JPHj2twcjbWYnsjBiTBcrp92oY421LoVlrvFdahfT7QGvFQuqwIoOoSMNdslgzrXk+Yuz48UpRFga3LvWCWMqBOIewPB78R/5pnIh1lZ1mLcmcmjPQZYyDj46gPpt+TsZY0LKQpTunW98jwi3/vJgtthD0fY6B2e4cQmxmP/V1/wSOEAnBAbQ4dkHAg3xX3nW6cV5MtqW/f2CizdCoHWKtBJTvK18Z4/B5HrbURcYumgD7J2eRBY9vPM3YhOWt9nBGzhOPstI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199015)(36756003)(86362001)(33656002)(122000001)(66476007)(41300700001)(66556008)(38100700002)(66446008)(66946007)(2616005)(38070700005)(83380400001)(64756008)(6506007)(186003)(478600001)(5660300002)(53546011)(2906002)(6916009)(316002)(76116006)(91956017)(8676002)(4326008)(8936002)(6486002)(26005)(71200400001)(54906003)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <E3E28CCFC75AC34181A0F479690F603B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5665
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	924ffcd8-b143-41f7-23e2-08dab26f06eb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cX6evrQ2aWU28U05S2tYMGOHT40V6y5/IXYWPXuH50jPzJuEP9TOA5yU4IP78HE48fHpzqmlVnLa3FUp+tjt3C8FfBEkGhWNJrPegQzNSG/ilHI6g/deyXi50esF/w4bKi0XWyNvDvAHi2NoQpI5yjQHf3roAiV3+yX3cZiT/GbB5JILCryAyvuc9mLDJTdrarF8ME0TmNBGlWspCXv1Zpn3w6hzWAO9yjYgY7XjzeEn7m46ol+gmqszmxh1agdLX9mtPlUsIs1Tven022L+c7koP+ITAPWTrPXRN6H7gGQch5F+NYj4eudkGaEtekUBg8fL9TvNdZQr0Cp1lQ4AUKIZIA7ppsMwNM/VDWnePv9Usq/gzbrwgpUAOmNP006LajcR+buba3JU2B5GJBMPJcs5spMEcw40SmdYRYUlasonJ00V4DHlpmtg2qm4Am6gJ/pAOw7dZjgtHSxcrtO0ZV1avF1HDGzS7D+yurlt2CszfGo0XZrdSA5/vseidiDjUgUWeDD0Y6voxmrLdViML4XNnGnmJJzKiwWZTx3+uBbXBjisuFitmhY8MYJsU0HIX15nv6mPK831/U4UyWlJ+sjLeZ+JV7nN7X9qUJFutF6Eeap67kRBp457Jb6ZM2BBulyr0zZUAtRcccgZg5lNxCCXeq+wElDncDphlagu+hbqgfVVNk2/tRxCzAbxvRhT8azdQTnRr9OXycUD8N2TcjSW3XJXxnSo9e3t2X/al+Eve7tZ5oTiqU/k8niTLXfPeU/13JJZLnp+isSPKCrHbw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(83380400001)(2616005)(356005)(186003)(70206006)(26005)(81166007)(336012)(86362001)(36860700001)(54906003)(47076005)(5660300002)(82740400003)(4326008)(40480700001)(8936002)(107886003)(6862004)(36756003)(53546011)(40460700003)(6506007)(6512007)(82310400005)(478600001)(70586007)(6486002)(316002)(41300700001)(8676002)(2906002)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 07:45:24.9756
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a3f1eb0e-56dc-4343-d74b-08dab26f0cbc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5425

SGkgSnVsaWVuLA0KDQo+IE9uIDE5IE9jdCAyMDIyLCBhdCAyMzozMywgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBBbmRyZXcsDQo+IA0KPiBPbiAxOS8xMC8y
MDIyIDIyOjMwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gT24gMTgvMTAvMjAyMiAwMDowMSwg
SnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+Pj4gLi4uIHlvdSBhcmUgaGFyZGNvZGluZyBib3RoIHAy
bV90ZWFyZG93bigpIGFuZCBwMm1fc2V0X2FsbG9jYXRpb24oKS4NCj4+Pj4+IElNTyB0aGlzIGlz
IG5vdCBhbiBpbXByb3ZlbWVudCBhdCBhbGwuIEl0IGlzIGp1c3QgbWFraW5nIHRoZSBjb2RlIG1v
cmUNCj4+Pj4+IGNvbXBsZXggdGhhbiBuZWNlc3NhcnkgYW5kIGxhY2sgYWxsIHRoZSBleHBsYW5h
dGlvbiBvbiB0aGUgYXNzdW1wdGlvbnMuDQo+Pj4+PiANCj4+Pj4+IFNvIHdoaWxlIEkgYW0gZmlu
ZSB3aXRoIHlvdXIgcGF0Y2ggIzEgKGFscmVhZHkgcmV2aWV3ZWQgaXQpLCB0aGVyZSBpcw0KPj4+
Pj4gYSBiZXR0ZXIgcGF0Y2ggZnJvbSBIZW5yeSBvbiB0aGUgTUwuIFNvIHdlIHNob3VsZCB0YWtl
IGhpcyAocmViYXNlZCkNCj4+Pj4+IGluc3RlYWQgb2YgeW91cnMuDQo+Pj4+IA0KPj4+PiBJZiBi
eSBiZXR0ZXIsIHlvdSBtZWFuIHNvbWV0aGluZyB0aGF0IHN0aWxsIGhhcyBlcnJvcnMsIHRoZW4g
c3VyZS4NCj4+Pj4gDQo+Pj4+IFRoZXJlJ3MgYSByZWFsbHkgZ29vZCByZWFzb24gd2h5IHlvdSBj
YW5ub3Qgc2FmZWx5IHJlcHVycG9zZQ0KPj4+PiBwMm1fdGVhcmRvd24oKS4gIEl0J3Mgd3JpdHRl
biBleHBlY3RpbmcgYSBmdWxseSBjb25zdHJ1Y3RlZCBkb21haW4gLQ0KPj4+PiB3aGljaCBpcyBm
aW5lIGJlY2F1c2UgdGhhdCdzIGhvdyBpdCBpcyB1c2VkLiAgSXQgZG9lc24ndCBjb3BlIHNhZmVs
eQ0KPj4+PiB3aXRoIGFuIHBhcnRpYWxseSBjb25zdHJ1Y3RlZCBkb21haW4uDQo+Pj4gDQo+Pj4g
SXQgaXMgbm90IDEwMCUgY2xlYXIgd2hhdCBpcyB0aGUgaXNzdWUgeW91IGFyZSByZWZlcnJpbmcg
dG8gYXMgdGhlDQo+Pj4gVk1JRCBpcyB2YWxpZCBhdCB0aGlzIHBvaW50LiBTbyB3aGF0IHBhcnQg
d291bGQgYmUgd3Jvbmc/DQo+PiBGYWxsaW5nIG92ZXIgYSBiYWQgcm9vdCBwb2ludGVyIGZyb20g
YW4gZWFybHkgY29uc3RydWN0aW9uIGV4aXQuDQo+IA0KPiBZb3UgaGF2ZSBiZWVuIG1lbnRpb25p
bmcgdGhhdCBzZXZlcmFsIHRpbWUgbm93IGJ1dCBJIGNhbid0IHNlZSBob3cgdGhpcw0KPiBjYW4g
aGFwcGVuLiBJZiB5b3UgbG9vayBhdCBIZW5yeSdzIHNlY29uZCBwYXRjaCwgcDJtX3RlYXJkb3du
KCkgc3RhcnRzDQo+IHdpdGggdGhlIGZvbGxvd2luZyBjaGVjazoNCj4gaWYgKCBwYWdlX2xpc3Rf
ZW1wdHkoJnAybS0+cGFnZXMpICkNCj4gICByZXR1cm47DQo+IA0KPiBQZXIgdGhlIGxvZ2ljIGlu
IHAybV9pbml0KCksIHRoZSByb290IHBhZ2VzIGhhdmUgdG8gYmUgYWxsb2NhdGVkIChub3RlIHRo
ZXkgYXJlICpub3QqIGFsbG9jYXRlZCBmcm9tIHRoZSBQMk0gcG9vbCkgYW5kIHRoZSBWTUlEIGFz
IHdlbGwgYmVmb3JlIGFueSBwYWdlcyBjb3VsZCBiZSBhZGRlZCBpbiB0aGUgbGlzdC4NCj4gDQo+
Pj4gQnV0IGlmIHRoZXJlIGFyZSBwYXJ0IG9mIHAybV90ZWFyZG93bigpIHRoYXQgYXJlIG5vdCBz
YWZlIGZvcg0KPj4+IHBhcnRpYWxseSBjb25zdHJ1Y3RlZCBkb21haW4sIHRoZW4gd2Ugc2hvdWxk
IHNwbGl0IHRoZSBjb2RlLiBUaGlzDQo+Pj4gd291bGQgYmUgbXVjaCBiZXR0ZXIgdGhhdCB0aGUg
ZHVwbGljYXRpb24geW91IGFyZSBwcm9wb3NpbmcuDQo+PiBZb3UgaGF2ZSB0d28gdG90YWxseSBk
aWZmZXJlbnQgY29udGV4dHMgd2l0aCBkaWZmZXJlbnQgc2FmZXR5DQo+PiByZXF1aXJlbWVudHMu
ICBjL3MgNTU5MTRmN2ZjOSBpcyBhIHJlYXNvbmFibHkgZ29vZCBhbmQgY2xlYW4gc2VwYXJhdGlv
bg0KPj4gYmV0d2VlbiBwcmVlbXB0aWJsZSBhbmQgbm9uLXByZWVtcHRpYmxlIGNsZWFudXBbMV0u
DQo+IA0KPiBUaGUgcGFydCB5b3UgbWVudGlvbiBpbiBbMV0gd2FzIGRlY2lkZWQgdG8gYmUgZGVs
YXllZCBwb3N0IDQuMTcgZm9yIGRldmVsb3BtZW50IGN5Y2xlIHJlYXNvbnMuDQo+IA0KPj4gWW91
J3ZlIGFncmVlZCB0aGF0IHRoZSBpbnRyb2R1Y3Rpb24gb2YgdGhlIG5vbi1wcmVlbXB0aWJsZSBw
YXRoIHRvIHRoZQ0KPj4gcHJlZW1wdGlibGUgcGF0aCBpcyBhIGhhY2sgYW5kIGxheWVyaW5nIHZp
b2xhdGlvbiwgYW5kIHdpbGwgbmVlZCB1bmRvaW5nDQo+PiBsYXRlci4gIE90aGVycyBoYXZlIHJh
aXNlZCB0aGlzIGNvbmNlcm4gdG9vLg0KPiANCj4gWy4uLl0NCj4gDQo+PiBBbHNvIHJlYWxpc2Ug
dGhhdCB5b3UndmUgbm93IHNwbGl0IHRoZSBoZWxwZXIgYmV0d2VlbiByZWd1bGFyIGh5cGVyY2Fs
bA0KPj4gY29udGV4dCwgYW5kIFJDVSBjb250ZXh0LCBhbmQgcmVjYWxsIHdoYXQgaGFwcGVuZWQg
d2hlbiB3ZSBmaW5hbGx5DQo+PiBzdGFydGVkIGFzc2VydGluZyB0aGF0IG1lbW9yeSBjb3VsZG4n
dCBiZSBhbGxvY2F0ZWQgaW4gc3RvcC1tYWNoaW5lIGNvbnRleHQuDQo+PiBIb3cgY2VydGFpbiBh
cmUgeW91IHRoYXQgdGhlIHNhZmV0eSBpcyB0aGUgc2FtZSBvbiBlYXJsaWVyIHZlcnNpb25zIG9m
DQo+PiBYZW4/DQo+IEkgYW0gcHJldHR5IGNvbmZpZGVudCBiZWNhdXNlIHRoZSBQMk0gY29kZSBo
YXMgbm90IGNoYW5nZWQgYSBsb3QuDQo+IA0KPj4gV2hhdCBpcyB0aGUgbGlrZWxpaG9vZCB0aGF0
IGFsbCBvZiB0aGVzZSBhY3Rpb25zIHdpbGwgcmVtYWluIHNhZmUNCj4+IGdpdmVuIGZ1dHVyZSBk
ZXZlbG9wbWVudD8NCj4gQ29kZSBhbHdheXMgZXZvbHZlIGFuZCBuZWl0aGVyIHlvdSAobm9yIEkp
IGNhbiBjbGFpbSB0aGF0IGFueSB3b3JrIHdpbGwgc3RheSBzYWZlIGZvcmV2ZXIuIEluIHlvdXIg
cGF0Y2ggcHJvcG9zYWwsIHRoZW4gdGhlIHJpc2sgaXMgYSBidWcgY291bGQgYmUgZHVwbGljYXRl
ZC4NCj4gDQo+PiBEZXNwaXRlIHdoYXQgaXMgYmVpbmcgY2xhaW1lZCwgdGhlIGF0dGVtcHQgdG8g
c2hhcmUgY2xlYW51cCBsb2dpYyBpcw0KPj4gaW50cm9kdWNpbmcgZnJhZ2lsaXR5IGFuZCByaXNr
LCBub3QgcmVtb3ZpbmcgaXQuDQo+IA0KPiBJIGZpbmQgaW50ZXJlc3RpbmcgeW91IGFyZSBzYXlp
bmcgdGhhdC4uLiBJZiB3ZSB3ZXJlIGdvaW5nIHRvIG1vdmUgcDJtX3RlYXJkb3duKCkgaW4gZG9t
YWluX3RlYXJkb3duKCkgdGhlbiB3ZSB3b3VsZCBlbmQgdXAgdG8gc2hhcmUgdGhlIGNvZGUuDQo+
IA0KPiBUbyBtZSwgdGhpcyBpcyBub3QgdmVyeSBkaWZmZXJlbnQgaGVyZSBiZWNhdXNlIGluIG9u
ZSBjb250ZXh0IGl0IHdvdWxkIGJlIHByZWVtcHRpYmxlIHdoaWxlIHRoZSBvdGhlciBpdCB3b24n
dC4gQXQgd2hpY2ggcG9pbnQuLi4NCj4gDQo+PiAgIFRoaXMgaXMgYSBidWdmaXggZm9yDQo+PiB0
byBhIHNlY3VyaXR5IGZpeCBpc3N1ZSB3aGljaCBpcyB0b3RhbGx5IGRlYWQgb24gYXJyaXZhbDsg
bmV0IHNhZmV0eSwNCj4+IGVzcGVjaWFsbHkgaW4gb2xkZXIgdmVyc2lvbnMgb2YgdGhlIFhlbiwg
aXMgKnRoZSBoaWdoZXN0IHByaW9yaXR5Ki4NCj4+IFRoZXNlIHR3byBkaWZmZXJlbnQgY29udGV4
dHMgZG9uJ3Qgc2hhcmUgYW55IGNvbW1vbiBwcm9wZXJ0aWVzIG9mIGhvdyB0bw0KPj4gY2xlYW4g
dXAgdGhlIHBvb2wsIHNhdmUgZnJlZWluZyB0aGUgZnJhbWVzIGJhY2sgdG8gdGhlIG1lbW9yeQ0K
Pj4gYWxsb2NhdG9yLiAgSW4gYSBwcm9wZXIgZGVzaWduLCB0aGlzIGlzIHRoZSBoaW50IHRoYXQg
dGhleSBzaG91bGRuJ3QNCj4+IHNoYXJlIGxvZ2ljIGVpdGhlcg0KPiAuLi4gd2h5IGlzIHlvdXIg
ZGVzaWduIGJldHRlciB0aGFuIHdoYXQgSGVucnkncyBwcm9wb3NlZD8NCj4gDQo+PiBHaXZlbiB0
aGF0IHlvdSBkbyBleHBlY3Qgc29tZW9uZSB0byBzcGVuZCB5ZXQtbW9yZSB0aW1lJmVmZm9ydCB0
byB1bmRvDQo+PiB0aGUgc2hvcnQgdGVybSBoYWNrIGN1cnJlbnRseSBiZWluZyBwcm9wb3NlZCwg
aG93IGRvIHlvdSBlbnZpc2FnZSB0aGUNCj4+IGVuZCByZXN1bHQgbG9va2luZz8NCj4gDQo+IFRo
ZSBlbmQgcmVzdWx0IHdpbGwgYmUgcDJtX3RlYXJkb3duKCkgJiBjbyB0byBiZSBjYWxsZWQgZnJv
bSBkb21haW5fdGVhcmRvd24oKS4NCj4gDQo+IEFueXdheSwgdGhpcyBkaXNjdXNzaW9uIGRvZXNu
J3QgbWFrZSB1cyBjbG9zZXIgdG8gY29tZSB0byBhbiBhZ3JlZW1lbnQgb24gdGhlIGNvcnJlY3Qg
YXBwcm9hY2guIFdlIGhhdmUgYm90aCB2ZXJ5IGRpdmVyZ2luZyBvcGluaW9uIGFuZCBzbyBmYXIg
SSBoYXZlbid0IHNlZW4gYW55IHN0cm9uZyByZWFzb25zIHRoYXQgaXMgc2hvd2luZyB5b3VycyBp
cyBiZXR0ZXIuDQo+IA0KPiBTbyB1bmxlc3MgQmVydHJhbmQgb3IgU3RlZmFubyBhZ3JlZSB3aXRo
IHlvdSwgdGhlbiBJIHdpbGwgZ28gYWhlYWQgYW5kIG1lcmdlIEhlbnJ5J3MgcGF0Y2ggdG9tb3Jy
b3cgYWZ0ZXIgYSBmaW5hbCByZXZpZXcuDQoNCkF0IHRoaXMgc3RhZ2UsIEkgc3RpbGwgZG8gbm90
IGdldCB0aGUgTlVMTCBwb2ludGVyIGNhc2UgYXMgZnJvbSBteSBwb2ludCBvZiB2aWV3IHRoZSBs
aXN0X2VtcHR5IGRvbmUgYXQgdGhlIGJlZ2lubmluZyBpcyBtYWtpbmcgdGhhdCBjYXNlIGltcG9z
c2libGUuDQpXZSBoYXZlIGEgY3VycmVudGx5IGJsb2NrZWQgc3RhdHVzIHdoZXJlIGFueSBHSUN2
MiBiYXNlZCBib2FyZCBpcyBub3QgYm9vdGluZyBhbmQgd2UgYWxsIGtub3cgdGhhdCBIZW5yeeKA
mXMgc29sdXRpb24gd2lsbCBuZWVkIHRvIGJlIHJld29ya2VkIHBvc3QgNC4xNy4NCg0KU28gSSB3
aWxsIGdpdmUgbXkgcmV2aWV3ZWQtYnkgb24gSGVucnnigJlzIHBhdGNoIHNvIHRoYXQgd2UgaGF2
ZSBhIHNob3J0IHRlcm0gc29sdXRpb24gZ2l2aW5nIHVzIG1vcmUgdGltZSB0byBkaXNjdXNzIGFu
ZCBmaW5kIGEgcHJvcGVyIHNvbHV0aW9uLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCg0KPiANCj4g
Q2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 07:47:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 07:47:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426251.674565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQHA-00017z-7r; Thu, 20 Oct 2022 07:47:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426251.674565; Thu, 20 Oct 2022 07:47:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQHA-00017s-3k; Thu, 20 Oct 2022 07:47:36 +0000
Received: by outflank-mailman (input) for mailman id 426251;
 Thu, 20 Oct 2022 07:47:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tvbq=2V=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1olQH8-00017T-WB
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 07:47:35 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2042.outbound.protection.outlook.com [40.107.247.42])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7544f823-504b-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 09:47:34 +0200 (CEST)
Received: from DB6PR07CA0163.eurprd07.prod.outlook.com (2603:10a6:6:43::17) by
 PA4PR08MB5934.eurprd08.prod.outlook.com (2603:10a6:102:e8::21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.35; Thu, 20 Oct 2022 07:47:29 +0000
Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:43:cafe::5) by DB6PR07CA0163.outlook.office365.com
 (2603:10a6:6:43::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.17 via Frontend
 Transport; Thu, 20 Oct 2022 07:47:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 07:47:29 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Thu, 20 Oct 2022 07:47:29 +0000
Received: from 96a632a00542.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D3D51E56-07EC-425A-B14E-D63DFA3B8583.1; 
 Thu, 20 Oct 2022 07:47:22 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96a632a00542.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 07:47:22 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM8PR08MB5665.eurprd08.prod.outlook.com (2603:10a6:20b:1da::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 07:47:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::a8c6:cf12:7155:de53%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 07:47:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7544f823-504b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=G2tPXq+ez6njSrreOuvIuhspYO7G8cTmHHRKzG5uRrdu4Zb4TuWqOfBmPkyloCAANtVhqZBPcExCrdBmMqOMqox0SHA+CY3IHhAZzg3WqoxrRxTFxzYwmcwzD1Mih4BzV61wS+pP3i0iySzUxJNAIIPcXfTCprnhntWsJxIdcLss/K1dlzyq1yqvsDjmFtSubudwJBkKsnio0YSIpFPG/TKZtElr7knO2RIwai2fzWGNv7c/plOUM5OePZF185Q1vMIlz1H0aLkRAxjGew18cLqx6O114OPmR1Rqsp4lAlz6W9mLK3NXarRsCY2KnltkWgTkpeJh3HeCZwLqj2O2RQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=d/9fjoKKQESXKbjfAlAqcf2n3pNx0eJda1SPUTQJUFk=;
 b=PrKNS9TMKkjOstRPkVjxzkGMoVsrtWbFNK63VSrXuzyf3mFyh3fgHgRAukbTaIeP/tJlfzvlG7hPkfW2OZCV+Q1P7MRdZjV59ps88lsiRvDVzAA3XyXwqwAyXI0jEmX+gOhy6JScmbekcMM7JxjUMMOlI1s6ym1C9teutDtlnkoCR5II8baEysLioCIFUc1RgpsUwaVO4HvjA5C5vnuDpGQ26jtAIMIeMRKCCfjFyvK5ObbI696pYX7URw0dAu8SeZWu9ehx6Qn0D3QMWaITJiYInDKDplyHZkXk/zCfWu++3k7LM+xdm0IRLBLgLrJUb0bk2yJLV8v0+iFf0JF2Ag==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=d/9fjoKKQESXKbjfAlAqcf2n3pNx0eJda1SPUTQJUFk=;
 b=o6iJNDHft2wEbLP+dXOtRNcRwq2GENsHCnGEoEXhU2dXWsgsP8K+m9HM6HPN0xpr6NeL/WGjBiSR2M002ss9O2qo6uPvr/v7YLtYh5UQKGcdQhrSN9+KxtGrB2IZnCRAXrsuwdjMJJed+TUlj40uQs/nsmOPHFtIBxEdRWgJjZk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 51d1f9afc0eecefc
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l+vNj4jqGgpefreX3r/dP6rYSoPUlFMpM6p4DTgZ4RVy7Vh43Q14/pcZjHF16LgKZiorp+SpGvTtAGXckEmDo7oEm5z9P2vj6AROsN2Z/HwFUP8KG7syAw4io5uUBLngJsBp32iOyQAAp2s/T35q1HYsk/eHRFzbQNsemxs2zkH34rJqgABzSORkMQGj8lOdZvl/wGh5kRUyfCj1SBrYhKb5QG7s+DZAcYoTZdz2mtyN9s1c1GusGc+p4hyPwvF+z5OjsOvUKjQdvLECCAj+IM0xnIqzuEDZA4ht3w4Gczl3SnyU2NpMVh6GFoCfLfVxYr9h6uH7NE+MAnBlek17ig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=d/9fjoKKQESXKbjfAlAqcf2n3pNx0eJda1SPUTQJUFk=;
 b=mBVoe+zV+UYQdCuj8qC8WL76FzwffxBW9ZlE2OOftF/XMcYRwOzINYizQXVH8+SCEYwOZ7zaLj8QOwzx7R7F9obzdsIugB5x0QKK/mPGJzI2jctybj/bJmqM81iO7ybnPyaw2ET5WW5c/AO6PKiq9UMRXSoXUqpbCyMWZYEpeQ8sXnOV/KJxb1xe8Oodmyk6CsfLGVNfQ3D3RD3vBy0HH77wxnVhW3Pu7zerbATyGs+qsjSdhHwz/+H8y7lFUjV3DQEWilg2uCsLCzHibIAGWclKyNFwg+jXUnxc1JCB673t2W0bPOl9MrJsW/whyhP3KKj24H/0IN3/evOQA4SJHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=d/9fjoKKQESXKbjfAlAqcf2n3pNx0eJda1SPUTQJUFk=;
 b=o6iJNDHft2wEbLP+dXOtRNcRwq2GENsHCnGEoEXhU2dXWsgsP8K+m9HM6HPN0xpr6NeL/WGjBiSR2M002ss9O2qo6uPvr/v7YLtYh5UQKGcdQhrSN9+KxtGrB2IZnCRAXrsuwdjMJJed+TUlj40uQs/nsmOPHFtIBxEdRWgJjZk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 p2m_init()
Thread-Topic: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 p2m_init()
Thread-Index: AQHY4v1UNTDexmHkFU+TbVAEitUu+q4W6mIA
Date: Thu, 20 Oct 2022 07:47:20 +0000
Message-ID: <DD601A86-C7C6-42AF-965F-A9759245E241@arm.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>
 <20221018142346.52272-3-Henry.Wang@arm.com>
In-Reply-To: <20221018142346.52272-3-Henry.Wang@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AM8PR08MB5665:EE_|DBAEUR03FT010:EE_|PA4PR08MB5934:EE_
X-MS-Office365-Filtering-Correlation-Id: 071f54ec-7999-4b25-0d3d-08dab26f56b0
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FUSgC85CRKgZuLzyztp7J/LPPeT0XZgbS6KwtTeq2cXj5lD723/8ebuV93d9gyBXKLxHdE6iYlrsbv6KHsdu/OSzf8qDFNf1Oxu9A46sb5lWoVkp/VvkWeAXMVh0IuuWeaof3bz2d9ZGTA9n/FUBaIXcTK1zQqFcB7L7g/6QyNszQ0lg68x7UwV7l5p6OR2qpHLmUCA/XpkQCIyR0RPS19e9CD+SyxhiXJBWL+lBLRJubdD8suxAqwkvy+PCnmKBTVs5dRfL8v4K8o5IVaN9SIyaQqCAHo+DjZAnrjUFs8v5Ia/GNILtze3e0POCCenqBbCGx6F84yBUbgHV5+wHX9+BvPrMTztMlEGr3zqgGG/GDFcmn37CutoPWAl+mNRqi4ff5jYevS6NrwO/qnbcTzYKQeqa53hQCzINBBhvd85sF1i3XtI2Xb5LddLb78ZWOBLx1/fjIzJfZyf+oMdKc5ZGqZD0hw5nH6ISTLzIEel8xnE6Oy6AJtBOvVGOdsTzCKx5+iF4Ev4AOWabDKKlt2jQdxjEeFyTxazus3BpWV6mTMjITlbZivbsbYYClC4dzA3bwPTJYxLGPmDOePgcv0vmg1R3McYFBW5E0yl+Lqkedk9nia1NV1UeLTYTZYAdIY3DqmR0DbpGW2/qBr3VViPSOOfaomQ6R4YMbqOQLg/JTkmglziUsPJ5qBLfVmymz8yXsDNxVyUjWcxjH7Xn0fLRPPw2FL0QZSnFsghmTHxwT+YhnVds3k3l+Q+GQqqtpotFqydhSxvqVLjOgVOdgUMmvQKi948oMecSQbeLvkw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199015)(36756003)(86362001)(33656002)(122000001)(66476007)(37006003)(41300700001)(66556008)(38100700002)(66446008)(66946007)(2616005)(38070700005)(83380400001)(64756008)(6506007)(186003)(478600001)(5660300002)(53546011)(2906002)(316002)(76116006)(6636002)(6862004)(91956017)(8676002)(4326008)(8936002)(6486002)(26005)(71200400001)(54906003)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <35185F8B985F714BBB43DDAC8740045F@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5665
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	0246be49-fe8e-4d20-26aa-08dab26f51cb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KaTaWP8CN0XbafEofCVXcqXFKqKlV9MS7zvM7iQvLIr0rf4nJNuro9dlO7tKY8fFaOb2j4xOl+ZkbhPGYZ4Stsr1DklxDgd1XTihymEOYYtAiG/MUypNehLEYr/4Qe0y3ZaRDL3Ef0tp2sLp9+oP/jYIDr8a2karUSYp30/hMHkoC4NT/uRWmdEvcKax0noA4vcZb8UIWLzv6BI8olZQRtkr8IdV8iYNNmK4V/dNyOt4bu9ZPcUig+F/WlijskRYHFmOGRPjljKeUFRa888OsqQDawrMwzekr39yMd0G8Apu09+Z6nG229/CiMZTpyH9+xzpigZoBm671Wai+qU59hWG51ztpC6E1dUsncYIx1V2bCEMEhrkp6ELrwoGY+nbX1TawR0UWcoMujRtczMErbHJgTO9AY8UNFeU1IbiIUfM4G4d9H7qNENCHVztaW6ulapA0v/jq8MyMt7TXz7syt4iF0vZ+r3Mcy135oEUCikd/hiJJsd62MNea/Up2cf937323m49sw2/sBbFZJde1PQkMZ6grvLKNeBcTALP9qlQXwqt71+EW3YQJrXW/tciTyj221/wzdEX6Z7DNquZc3G3c0ki7otK1FyB1rjO90uTFdk/xCKhu2vnrB+gVc1dR5r5xRVbKA49kGdSM2NfXS3A92RB+Xc3L4uClK/dPEWdfpuMUzqsFD6fNdFJZZg14zpFSn6XZH06AP4hM2Fm2xsBexpvRdGulj2CyRTCGxxJspfiOAGThKdqHBGQxTJH9FCZaX0937EGQl4DBciUcA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(2616005)(336012)(107886003)(186003)(6512007)(53546011)(26005)(6506007)(36860700001)(83380400001)(2906002)(40460700003)(40480700001)(5660300002)(47076005)(6862004)(82310400005)(316002)(478600001)(6486002)(70206006)(8936002)(41300700001)(37006003)(70586007)(4326008)(8676002)(6636002)(54906003)(33656002)(36756003)(86362001)(82740400003)(81166007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 07:47:29.1838
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 071f54ec-7999-4b25-0d3d-08dab26f56b0
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5934

Hi Henry,

> On 18 Oct 2022, at 15:23, Henry Wang <Henry.Wang@arm.com> wrote:
>=20
> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> when the domain is created. Considering the worst case of page tables
> which requires 6 P2M pages as the two pages will be consecutive but not
> necessarily in the same L3 page table and keep a buffer, populate 16
> pages as the default value to the P2M pages pool in p2m_init() at the
> domain creation stage to satisfy the GICv2 requirement. For GICv3, the
> above-mentioned P2M mapping is not necessary, but since the allocated
> 16 pages here would not be lost, hence populate these pages
> unconditionally.
>=20
> With the default 16 P2M pages populated, there would be a case that
> failures would happen in the domain creation with P2M pages already in
> use. To properly free the P2M for this case, firstly support the
> optionally preemption of p2m_teardown(), then call p2m_teardown() and
> p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
> As non-preemptive p2m_teardown() should only return 0, use a
> BUG_ON to confirm that.
>=20
> Since p2m_final_teardown() is called either after
> domain_relinquish_resources() where relinquish_p2m_mapping() has been
> called, or from failure path of domain_create()/arch_domain_create()
> where mappings that require p2m_put_l3_page() should never be created,
> relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
> in-code comments to refer this.
>=20
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M p=
ool")
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> This should also be backported to 4.13, 4.14, 4.15 and 4.16.
> v5 changes:
> - Rebase on top of Andrew's patch, update commit message accordingly.
> v4 changes:
> - Move the initial population of 16 default pages to the end of
>  p2m_init(), add if(rc) return rc; after p2m_alloc_table()
> v3 changes:
> - Move the population of default pages to p2m_init().
> - Use a loop over p2m_teardown_allocation() to implement the
>  non-preemptive p2m_teardown_allocation() and avoid open-coding.
> - Reorder assertions in p2m_final_teardown().
> - Add p2m_teardown() will always return 0 if called non-preemptively in
>  doc, move the page_list_empty(&p2m->pages) check to p2m_teardown()
>  and use a BUG_ON to confirm p2m_teardown() will return 0 in
>  p2m_final_teardown().
> - Add a comment in p2m_final_teardown() to mention relinquish_p2m_mapping=
()
>  does not need to be called, also update commit message.
> v2 changes:
> - Move the p2m_set_allocation(d, 0, NULL); to p2m_final_teardown().
> - Support optionally preemption of p2m_teardown(), and make the calling o=
f
>  p2m_teardown() preemptively when relinquish the resources, non-preemptiv=
ely
>  in p2m_final_teardown().
> - Refactor the error handling to make the code use less spin_unlock.
> - Explain the worst case of page tables and the unconditional population
>  of pages in commit message.
> - Mention the unconditional population of pages in in-code comment.
> ---
> xen/arch/arm/domain.c          |  2 +-
> xen/arch/arm/include/asm/p2m.h | 14 ++++++++++----
> xen/arch/arm/p2m.c             | 34 ++++++++++++++++++++++++++++++++--
> 3 files changed, 43 insertions(+), 7 deletions(-)
>=20
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2c84e6dbbb..38e22f12af 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -1064,7 +1064,7 @@ int domain_relinquish_resources(struct domain *d)
>             return ret;
>=20
>     PROGRESS(p2m):
> -        ret =3D p2m_teardown(d);
> +        ret =3D p2m_teardown(d, true);
>         if ( ret )
>             return ret;
>=20
> diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2=
m.h
> index 42bfd548c4..c8f14d13c2 100644
> --- a/xen/arch/arm/include/asm/p2m.h
> +++ b/xen/arch/arm/include/asm/p2m.h
> @@ -194,14 +194,18 @@ int p2m_init(struct domain *d);
>=20
> /*
>  * The P2M resources are freed in two parts:
> - *  - p2m_teardown() will be called when relinquish the resources. It
> - *    will free large resources (e.g. intermediate page-tables) that
> - *    requires preemption.
> + *  - p2m_teardown() will be called preemptively when relinquish the
> + *    resources, in which case it will free large resources (e.g. interm=
ediate
> + *    page-tables) that requires preemption.
>  *  - p2m_final_teardown() will be called when domain struct is been
>  *    freed. This *cannot* be preempted and therefore one small
>  *    resources should be freed here.
> + *  Note that p2m_final_teardown() will also call p2m_teardown(), to pro=
perly
> + *  free the P2M when failures happen in the domain creation with P2M pa=
ges
> + *  already in use. In this case p2m_teardown() is called non-preemptive=
ly and
> + *  p2m_teardown() will always return 0.
>  */
> -int p2m_teardown(struct domain *d);
> +int p2m_teardown(struct domain *d, bool allow_preemption);
> void p2m_final_teardown(struct domain *d);
>=20
> /*
> @@ -266,6 +270,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn=
,
> /*
>  * Direct set a p2m entry: only for use by the P2M code.
>  * The P2M write lock should be taken.
> + * TODO: Add a check in __p2m_set_entry() to avoid creating a mapping in
> + * arch_domain_create() that requires p2m_put_l3_page() to be called.
>  */
> int p2m_set_entry(struct p2m_domain *p2m,
>                   gfn_t sgfn,
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 6826f63150..00d05bb708 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1685,7 +1685,7 @@ static void p2m_free_vmid(struct domain *d)
>     spin_unlock(&vmid_alloc_lock);
> }
>=20
> -int p2m_teardown(struct domain *d)
> +int p2m_teardown(struct domain *d, bool allow_preemption)
> {
>     struct p2m_domain *p2m =3D p2m_get_hostp2m(d);
>     unsigned long count =3D 0;
> @@ -1693,6 +1693,9 @@ int p2m_teardown(struct domain *d)
>     unsigned int i;
>     int rc =3D 0;
>=20
> +    if ( page_list_empty(&p2m->pages) )
> +        return 0;
> +
>     p2m_write_lock(p2m);
>=20
>     /*
> @@ -1716,7 +1719,7 @@ int p2m_teardown(struct domain *d)
>         p2m_free_page(p2m->domain, pg);
>         count++;
>         /* Arbitrarily preempt every 512 iterations */
> -        if ( !(count % 512) && hypercall_preempt_check() )
> +        if ( allow_preemption && !(count % 512) && hypercall_preempt_che=
ck() )
>         {
>             rc =3D -ERESTART;
>             break;
> @@ -1736,7 +1739,20 @@ void p2m_final_teardown(struct domain *d)
>     if ( !p2m->domain )
>         return;
>=20
> +    /*
> +     * No need to call relinquish_p2m_mapping() here because
> +     * p2m_final_teardown() is called either after domain_relinquish_res=
ources()
> +     * where relinquish_p2m_mapping() has been called, or from failure p=
ath of
> +     * domain_create()/arch_domain_create() where mappings that require
> +     * p2m_put_l3_page() should never be created. For the latter case, a=
lso see
> +     * comment on top of the p2m_set_entry() for more info.
> +     */
> +
> +    BUG_ON(p2m_teardown(d, false));
>     ASSERT(page_list_empty(&p2m->pages));
> +
> +    while ( p2m_teardown_allocation(d) =3D=3D -ERESTART )
> +        continue; /* No preemption support here */
>     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
>=20
>     if ( p2m->root )
> @@ -1803,6 +1819,20 @@ int p2m_init(struct domain *d)
>     if ( rc )
>         return rc;
>=20
> +    /*
> +     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 a=
rea
> +     * when the domain is created. Considering the worst case for page
> +     * tables and keep a buffer, populate 16 pages to the P2M pages pool=
 here.
> +     * For GICv3, the above-mentioned P2M mapping is not necessary, but =
since
> +     * the allocated 16 pages here would not be lost, hence populate the=
se
> +     * pages unconditionally.
> +     */
> +    spin_lock(&d->arch.paging.lock);
> +    rc =3D p2m_set_allocation(d, 16, NULL);
> +    spin_unlock(&d->arch.paging.lock);
> +    if ( rc )
> +        return rc;
> +
>     return 0;
> }
>=20
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 07:52:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 07:52:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426257.674576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQLN-0002Wc-RE; Thu, 20 Oct 2022 07:51:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426257.674576; Thu, 20 Oct 2022 07:51:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQLN-0002WV-Mt; Thu, 20 Oct 2022 07:51:57 +0000
Received: by outflank-mailman (input) for mailman id 426257;
 Thu, 20 Oct 2022 07:51:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t2Es=2V=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olQLM-0002WN-50
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 07:51:56 +0000
Received: from NAM04-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam04on2081.outbound.protection.outlook.com [40.107.101.81])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f6e34fe-504c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 09:51:54 +0200 (CEST)
Received: from MW4PR04CA0041.namprd04.prod.outlook.com (2603:10b6:303:6a::16)
 by IA1PR12MB6137.namprd12.prod.outlook.com (2603:10b6:208:3eb::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 07:51:50 +0000
Received: from CO1NAM11FT021.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:6a:cafe::be) by MW4PR04CA0041.outlook.office365.com
 (2603:10b6:303:6a::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Thu, 20 Oct 2022 07:51:49 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT021.mail.protection.outlook.com (10.13.175.51) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Thu, 20 Oct 2022 07:51:49 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct
 2022 02:51:48 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Thu, 20 Oct 2022 02:51:48 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f6e34fe-504c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RdNyf8bBvYQgst2ng7WtrJuC+aZkgMSF5S+ahbGfEZG7uXCQaPmFaQ3dzLMvPJFVBM6zz2aFa9xB+tzUoClAbZ0BiWeRZwrh4vidieOcztlHf9BGsbDFk7kj9fuGWN+3ZfNaATRR6zNlErNnIBByyT1Fpu+cbwxDhjeZf95Y4Udl4qaz8xRUKMar8OFPfM+lU43XxPfGSnALuxjgrNh6hK4PqrUikGiTOfBZueDeMPYPQENOQCEChSjFxYhku2XcZB/ZExcXCFtJkn7RmnQILrNkp+DoEovH+h8fsgPUGPWTQ1aTm4od6luk3bkfbRY0EaKonn2dRJLFYqZLnzy19g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fM8zzqzuMoh1+GP100enU+ugyyRDaAt84n9V5tfnmv4=;
 b=fhTN5oySvtn5Ehxb113aTusF/mU2Qydw8z9C7uoG+e5EFyVWpd9LCKaSp+mupc2Ur2xsNzMhQaDlHNqsHVhlSD/9IwbHIUpLa7Omrr2m5/3I3ZMGWXOXS44MgaKoMk8YCoWRd4M3iupM1v77f38HIjK9/qU7Ec33PwQg5BRbCmM34iuADvHmxwJWYHLX9WYwt6iw3IhvkYPFmJnGTEAZm0Ws6K5ABho/Wfp3WhWanrcHn+QKe7achUnh+TlDYBw2rakzUHMHQJl/IEVLVHRxV7utvEdAMy4oLOy1iJMax0qN294bdlJroqlbUJ6bD43KfAjM2/EXCkwMwKUItUk7kA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fM8zzqzuMoh1+GP100enU+ugyyRDaAt84n9V5tfnmv4=;
 b=TdBnW66aFH3SBebKo79RzSLONpP3HEqvguyUdN73amhJN+S5nATzGeseR84Fkd9bqgREFTOA5S6kkeimwBXMZm/7rqbexYlE1GOvsJ2rlZF6vqTiEQEZglcrAEoa+ZYqp+jnUqEuVM67WvtUSWH6pUGA21prn/NTIq442t5lJBc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <e0e0d4af-54e0-6dee-2f01-99bb5d31d346@amd.com>
Date: Thu, 20 Oct 2022 09:51:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Content-Language: en-US
To: Jiamei Xie <Jiamei.Xie@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
References: <20220927094727.12762-1-michal.orzel@amd.com>
 <20220927094727.12762-6-michal.orzel@amd.com>
 <AS8PR08MB7696D8C9D2239CC9ED2FE08F922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
 <bc41f3a0-27ec-8bbe-a087-125acc20df2f@amd.com>
 <AS8PR08MB769676050B41BCEDCA3F2891922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <AS8PR08MB769676050B41BCEDCA3F2891922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT021:EE_|IA1PR12MB6137:EE_
X-MS-Office365-Filtering-Correlation-Id: f3cede87-7aed-4521-9a3a-08dab26ff218
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zod3hDDzlgEAp50k0iyvCoWa0uEovbDm7TXvnCe2zmlL4r7BUnpm8jnZH9yzsJLH2tkYBT3cfxJxXz9kQxOnOfxcHLgEU2KDMRtDj4Sqk2zKzyHYHeLitYqHK/Gdi0c5f1IFqxL0qAMKCk8uhiQZR/mMXuyVv9aodhWL+Ab1uG9FFCfkxtiNMk2xgh3nXnKl77h6VixE4VHVVJBOycKOw9c/KbXQI5ozCr37Og3iI/5T5kKg/Oy4pi1PAfwwUhnRlwmhHV0T44qjD3zSiHtvpi0PsqeMPcmJNLjappwM5wuhXycOok3KbMaQ6SdaxGhi06tAkJ3RNrhIHwdE4XU8ZwFu7BvxT7Z7k76A0B9FKmg71UMUa5MNjfbRzGeE7kBbY3mUTXVCkGYyXD3N3Cex7qLqbUrLMech6shZQnqAtdHdbzW769ypmXvpjECVTLNjXdSkfmCpuhSvJAEtuHesA7fEGFtcBxwLIfRmH0LBiwtQq8tXOmEA3OBJtpO9WVUBZtDXGph/NdBVFzSKzRDlGZRz9wYoic2U4BkVv48paxQkeBHF05ZDhdO9Bbtq5ih+fAEkI8LMBW/2EvfCb1Q50tikBkP9AnYRbVHlhGutG5dvxrHeqlFhsOCfCZFR0NndasnxyfAOVA3IMjFzwET4/la6/c1whbTDqy0cLYWK67jB6IJBwNmUrW2xwtoN4EueALUzBkzI4zEAfCDpdSXbIjdw3IQK/RjNKp35a7+izzlIF9WMCnrCAeAyGpUwgfYdHWXQHF4QxadFYm+G4pQFlDWTiB5qfe/AFNLySYbk1swRThUe/KxRcNX02OYauKohYQ+F2+piHPOQsw0cZooiatSw7Y06leie6tJTT6Y+dbA=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(478600001)(53546011)(336012)(36756003)(83380400001)(426003)(26005)(47076005)(2906002)(5660300002)(186003)(8936002)(41300700001)(356005)(2616005)(81166007)(82310400005)(40460700003)(86362001)(40480700001)(82740400003)(31696002)(36860700001)(31686004)(316002)(110136005)(16576012)(84970400001)(44832011)(54906003)(70586007)(8676002)(4326008)(70206006)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 07:51:49.7596
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f3cede87-7aed-4521-9a3a-08dab26ff218
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT021.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6137

Hi Jiamei,

On 20/10/2022 09:13, Jiamei Xie wrote:
> 
> 
> Hi Michal,
> 
>> -----Original Message-----
>> From: Michal Orzel <michal.orzel@amd.com>
>> Sent: Thursday, October 20, 2022 2:59 PM
>> To: Jiamei Xie <Jiamei.Xie@arm.com>; xen-devel@lists.xenproject.org
>> Cc: Doug Goldstein <cardoe@cardoe.com>; Stefano Stabellini
>> <sstabellini@kernel.org>
>> Subject: Re: [PATCH v3 05/10] automation: Add Arm containers to
>> containerize script
>>
>> Hi Jiamei,
>>
>> On 20/10/2022 05:00, Jiamei Xie wrote:
>>>
>>>
>>> Hi Michal,
>>>
>>>> -----Original Message-----
>>>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
>>>> Michal Orzel
>>>> Sent: Tuesday, September 27, 2022 5:47 PM
>>>> To: xen-devel@lists.xenproject.org
>>>> Cc: Michal Orzel <michal.orzel@amd.com>; Doug Goldstein
>>>> <cardoe@cardoe.com>; Stefano Stabellini <sstabellini@kernel.org>
>>>> Subject: [PATCH v3 05/10] automation: Add Arm containers to
>> containerize
>>>> script
>>>>
>>>> Script automation/scripts/containerize makes it easy to build Xen within
>>>> predefined containers from gitlab container registry. This script is
>>>> currently missing the helpers to select Arm containers, so populate the
>>>> necessary entries.
>>>>
>>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>>> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>>>> ---
>>
>>>
>>> [Jiamei Xie]
>>> I wonder if an default container for arm can be added. For example,  if
>>>  "CONTAINER=arm64 automation/scripts/containerize bash",
>>>  set the default CONTAINER as "registry.gitlab.com/xen-
>> project/xen/alpine:3.12-arm64v8"
>>>
>>
>> It can be added doing the following:
>>
>> diff --git a/automation/scripts/containerize
>> b/automation/scripts/containerize
>> index 0f4645c4cccb..b395bd359ecf 100755
>> --- a/automation/scripts/containerize
>> +++ b/automation/scripts/containerize
>> @@ -25,7 +25,7 @@ die() {
>>  BASE="registry.gitlab.com/xen-project/xen"
>>  case "_${CONTAINER}" in
>>      _alpine) CONTAINER="${BASE}/alpine:3.12" ;;
>> -    _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;;
>> +    _alpine-arm64v8|_arm64) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;;
>>      _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;;
>>      _riscv64) CONTAINER="${BASE}/archlinux:riscv64" ;;
>>      _centos7) CONTAINER="${BASE}/centos:7" ;;
>>
>> The question is whether it would be beneficial. After all you would still need
>> to
>> type CONTAINER=arm64, whereas at the moment, you need to type
>> CONTAINER=alpine-arm64v8.
>> TBH I'm not sure it is improving anything (?).
>>
>> ~Michal
> [Jiamei Xie]
> I am not sure about this either.  I added something like below f to run it on arm64 machine.   But it  didn't take "running container for a different architecture" into consideration.
> 
So your question is not about adding default container when selecting CONTAINER=arm64, but adding
a default one when running on arm64 platform. Right now, the default one is debian:stretch
(if you don't type CONTAINER= at all). Do I understand it right that you would like the same
behavior when running on arm64 platform (currently, it would also select debian:stretch)?
So that when executing:
./automation/scripts/containerize ...
it would automatically select alpine-arm64v8?


> --- a/automation/scripts/containerize
> +++ b/automation/scripts/containerize
> @@ -18,6 +18,12 @@ die() {
>      exit 1
>  }
> 
> +# There are two containers that can run on aarch64, unstable and alpine.
> +# Set the default container to alpine for aarch64
> +if [[ $(uname -m) = "aarch64" && -z ${CONTAINER} ]]; then
The output from `uname -m` for arm64 can be aarch64 and arm64.

> +    CONTAINER="alpine"
> +fi
> +
>  #
>  # The caller is expected to override the CONTAINER environment
>  # variable with the container they wish to launch.
> @@ -41,6 +47,11 @@ case "_${CONTAINER}" in
>      _opensuse-tumbleweed|_tumbleweed) CONTAINER="${BASE}/suse:opensuse-tumbleweed" ;;
>  esac
> 
> +# Containers for aarch64 have a sufix "-arm64v8"
> +if [[ $(uname -m) = "aarch64" ]]; then
> +    CONTAINER="${CONTAINER}-arm64v8"
> +fi
This is not needed. CONTAINER can be selected on the first check and let case/esac block
to determine the full path to container.

> +
>  # Use this variable to control whether root should be used
>  case "_${CONTAINER_UID0}" in
>      _1)   userarg= ;;
> 
> 
> Best wishes
> Jiamei Xie
> 
> 

What you are asking for can be done in a simpler way. The following is enough:

diff --git a/automation/scripts/containerize b/automation/scripts/containerize
index 0f4645c4cccb..4e7e8bb48e3a 100755
--- a/automation/scripts/containerize
+++ b/automation/scripts/containerize
@@ -18,6 +18,11 @@ die() {
     exit 1
 }
 
+# Select default container when running on arm64 machine.
+if [ -z "${CONTAINER}" ] && uname -m | grep -qE 'aarch64|arm64'; then
+    CONTAINER="alpine-arm64v8"
+fi
+
 #
 # The caller is expected to override the CONTAINER environment
 # variable with the container they wish to launch.

~Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 07:55:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 07:55:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426264.674586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQOd-0003Eg-DQ; Thu, 20 Oct 2022 07:55:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426264.674586; Thu, 20 Oct 2022 07:55:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQOd-0003EZ-Al; Thu, 20 Oct 2022 07:55:19 +0000
Received: by outflank-mailman (input) for mailman id 426264;
 Thu, 20 Oct 2022 07:55:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VPXW=2V=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1olQOc-0003ER-DZ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 07:55:18 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2080.outbound.protection.outlook.com [40.107.249.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89076c6f-504c-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 09:55:17 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7833.eurprd04.prod.outlook.com (2603:10a6:10:1ef::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 07:55:14 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 07:55:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89076c6f-504c-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZKitq2LM5fsDo3RDeRA3XI0o6pmH5OPS1V73/w3X2wWGsv3y6UBF+o/DYP/a6hIX89qJivvTvkgmPL0VEFeoRS1j390+O/Ngbq09elSjvoIsieF8w4iBf9IgtT6iq5rGPeLbLZnpUMOmV5OPCpEfJgBUSuy0a1xffO4cjTxS0fjlYyQ8ksbYjng+Q6x6x8hcs0+hlMZtg/Iacy6NP2LCy7/QN+WjnkIWm2GRetptFuOCQQeGXCjrrqu6Rp88Xyl9/CVDIp2kIMeQRtaWFbfxPkEAdmHs/C3/tbruKY5g7b2u8NNSSp3CIh/KghA7pqpbq3B4r9ZV3oe3TEEHcMKJmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k55QTnKmhTrHh2FHmVSyabaaWdqa5ydNMrO1x7S53zs=;
 b=bBt7woAl9pgqshgfPim2+S15Fnlu4KXh9OoStF8QvdFkig+Nd2Xc88JUBox7k3Ko6nHcxvRSkEkRMXJ4b4QXxhhfcf2nkOUuMQBqmIKPKpShOmQMODgqRnbe+oDJfCSJyuYr4aRRLpGHLSoFZ+8+6YdoYsQesBcIlG98anhJQcmQD9Nx+RR1c/8njnuONieXg76kJ5xcJBeztBbAgp9QfxxRrs1tYnKzhvpUyywQmsUw5UOEEELGS/gya9x2yRNJI+SPusrZcNdKRNowEAHWvUEqtSn/R4GeD6phYwB+RE7hyWIDxy1o7a9iWjmMOAVFQB+FgO+YHHRDvh57v+OipQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k55QTnKmhTrHh2FHmVSyabaaWdqa5ydNMrO1x7S53zs=;
 b=kOSh/l/DjGBWeg36ZeOPtO+Nm89upPm+3YjzW1g0Tn+5GP0jGRbJ+zukAgZ8cPCVQWAeAEcVOmj7CcRp1pcdaeh/oQL0quXH46cfrk2Hp5qef7kUF2QaFNCcJobRpXybcOOnFylgi358hZTSSA/qka8oBE9Ri1ER2NpYEl1DNVYJRtYLEBpsBGMSYTAVDIH/c6ZCINlxAnHCIFkIurK6V5mR/6lSzKLBJ6gz3dR7lzFJM6TdjXlnaiaJpUY6P15PZnVUwq/VYrB6hbM1CC7tHqY2IkYiEp7RRZit/Mm5Qps3YMznIH6sKq6UUsXkRzldUPoTSGm1dfSZQLzTRFNEYQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1dd7fe56-e545-12f7-5d49-5947734f3f65@suse.com>
Date: Thu, 20 Oct 2022 09:55:12 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 arch_domain_create()
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Henry Wang <Henry.Wang@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221017191237.11079-1-andrew.cooper3@citrix.com>
 <20221017191237.11079-3-andrew.cooper3@citrix.com>
 <0456d318-731f-8df7-297c-19ecde06ed96@xen.org>
 <cadcee69-e51b-99af-78c3-ab4a0e2e42d9@citrix.com>
 <5587f5bd-1694-a843-9e80-ad477527a576@xen.org>
 <dffdc951-91fd-2659-ec7f-5c213138d785@citrix.com>
 <f200534c-c001-3ec0-7e05-cdbb76f456e3@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f200534c-c001-3ec0-7e05-cdbb76f456e3@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7833:EE_
X-MS-Office365-Filtering-Correlation-Id: 7e111360-443a-4b71-52d5-08dab2706bda
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A/D5hs/7hoywrgSw1e15pztSfHgCLfD5TOhVZVuw0oQz3bn/6Af9mHBEruLP8eUcGfMRB1Qcdhfx6b/oGtCe/mRJUlyv8EJJd83MbPLThKx5vGthxi5/DIFEDdA/rjsopd0S/lae6vqAmDHKMhjHcDcUCrl4ne7f9KDqIVHVllpXkptMgHfRG2xclQBMPtQpNO4BzaaIg6dm2qu8bGwG9kycDzQXyV14cJV8Xw5y2ticbFlwjFzEdhjQQaQGXqGH80+KLOWbN9X49FaX2zW1B+W8A6i65TSv443IBEntYd7sx33Iijq0aY/duj5l9M6+67DpsJIIYPJqsANUPSGTGMUVwdwzgH94T0q5fHNs+bmQEzsM5FzOYwJwqwJXZVciu/ND0ArVxvBIOw8oIJ+d1NtPOz1ZNwAnNONauz0h44uHka94qgOJZKw40m/F6GzxqgNp4/bMm+4ItwjOCg7me7Yj+urb8CsZM3rKqH6wjSWCD7MSvY334fEcJomIreNdeImWU70A6MuaYaN73fI2pCsOOXFtqxD7XxsOuS/cmO8hZT1KYd1d8oyd1D17TLA7UnTB6o2Iyg17MhskH4YnG/7K+llMNNZKdq+ro+M9FnURyHrhuL2tQk5Wv3WuE4hysZiRI//P4I7ZWoiiyR4W9e5WA1uMOrr+1fc9WyrW9oYHsvUtPSNkdjG/HNv5c23Ajqskp9t3P/GfDqGq8GYFkQiy8ptOEFOxxhXS2iIGFgJ4gmXmFsCM6LRDnG6tJVSW5pavqtqZcWAJQ/xH6NSYCgU4mIHkLvnel2Qcwpw/6ys=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(346002)(136003)(376002)(396003)(451199015)(110136005)(54906003)(4326008)(66556008)(8676002)(36756003)(86362001)(66946007)(66476007)(41300700001)(31696002)(26005)(6506007)(316002)(5660300002)(83380400001)(8936002)(53546011)(6512007)(31686004)(38100700002)(6486002)(2616005)(2906002)(186003)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QThvUVFJMkgyYktzaGtLdHBYc0R6cXJnU05VRDhQb1NHOHF3Zys2OXU4Rm80?=
 =?utf-8?B?MnI4SzlLZ01YQ2RjS1VESEFMVnNUbm55NklUZlQ0TTdKeEE4MGxsL3d1QWJv?=
 =?utf-8?B?RERIa05QYnhyR0VsUGg4dWRoeVIrdHdYWHd6ZTMrMW5nNTR6SzBEMlJDdEx1?=
 =?utf-8?B?ME9OY2tuTmwyL0FQM1VVRWlETjRpbmJ3SHhYQlB3YU9qTWVObkVVSmgxaUll?=
 =?utf-8?B?cHQzK09ycUttemlZaVVKRnhQKzFqWVowcTc0WDBWOEhlTmREUVprRFIxWUdG?=
 =?utf-8?B?NXU2MUIySDBVUFlHTzFrRXlDSkxoTFBjVkRPUm9id0IzdVVaMDlvOWpOaWl2?=
 =?utf-8?B?b0k2R1N5TW1LWHJ3dCtqbXAzWGdMbzZFYXMwN1cvZVV1NERxTFNETFJJMkI5?=
 =?utf-8?B?NmVyMkJZcFV1cFRKOElKdnV3aUhvNFdNRHZoNDBxd2w5RkhMcXNpL05MblBS?=
 =?utf-8?B?VkZwTk1ZMFZBUkdVMnlGQ0pxRm9vRTh1djYvdHZyMERkZkU1WnBIbzBJd3Np?=
 =?utf-8?B?WDBwMDY4ZmlsenZGZzhIME9hVVVta3pyenZ5UWQzM2x1SWFUQ1RGaURiSlJO?=
 =?utf-8?B?ajVzZmw3cTBtWFhkTGVBZWIxRUhqNXJGNEw1eW5PcmpYVkhlWjI1YkVrV2RF?=
 =?utf-8?B?RUlkWnVTYm1rT25KcS8rMFpvNkttQ3gvODk5YnlVV2JrVzJVdGZtS0l3TkY5?=
 =?utf-8?B?RENLcmMvS0FVajh6YmE1SnFZbGZkZSthMUVFTGRZQ0tJc29HUzFneDA0THp2?=
 =?utf-8?B?SGVLUzRMMHIreDg0RWorYmZBK0E2OGN3T2pocHkzVE1BWFNMa2pGZ1RZS3pD?=
 =?utf-8?B?TWRIMTU4T2lzd2p5TVY3QnRORGEzVWZuaVFwaFZsajBYNlg0c2RnVDFZYTBP?=
 =?utf-8?B?OTJ2WmttbDV4R3cvemMyeis3VjA3L05iZ0pLOEE2bzNydHF0dWVJMS9zOE8r?=
 =?utf-8?B?aEU5eXlTYmk0UkxzcXF5MzJiSVVSSFNQRWJablowZGRMeEFiVyt4QnNHS2Vn?=
 =?utf-8?B?TmF6c3JidFZ0dHVxV3NZell2bEtUNm1iL1FIS3pHSlBYbXIrek91ejZGcVVo?=
 =?utf-8?B?OHBnOWUwTmFxdWN4ODI3cUNPb0FVaFNYQ2VhVmc0VGdaUjRNNW5SL2NQMVhE?=
 =?utf-8?B?SXhwZ1JCZFZzVnlMSUdsMy9DMG1RQk9ZM29BaFJEdXNJblhOdTBTSTFMSmdH?=
 =?utf-8?B?SU1vK2NNUlV5dHZQRE5mbFRsbm8xdy93T3B4K0ViSm1IR0gxM3dvQTgyd0ky?=
 =?utf-8?B?WU9BUTA5OXZWcENYZlRSVjdWSHVSeW9PcitWSklOM29qQ0lCUDBTK2ZmZlZh?=
 =?utf-8?B?WTRZV3JaZjdkRGxSMW9OVC9LZ3FJZUFRUmZ2Y2hYTHhYaUlJc1k1ZGRia0NQ?=
 =?utf-8?B?aDFDS2RmWDFaUjhrakNLWmpiREdYTmFOMXpLa1Q1d2tRMjd3T0hrcHRpbExt?=
 =?utf-8?B?Y0VJRGs4MVFPOURLVDVnUXV6R0VpeUQxaldjK3g0SElPWUxQYjhNL0pnYVdt?=
 =?utf-8?B?b3pWa3Jqa09qMkdpNHZmV0x1NndHUjZaZDRTT3NlNkkwT1dYbmVaQTY5cGxQ?=
 =?utf-8?B?RVYzWmcwcW9yekxQRDVhMXN5czZCK0VvVVJkcVJES1NENlhKMU1ndVFKVGhm?=
 =?utf-8?B?c3ZOak9LS0lTZEtJVGRsZG02SjB0MTFmclBqdTVOVmRpODJoUCtmeE1iVTZI?=
 =?utf-8?B?ajJRRGxyZkVlSDE4elpIclZRZVhNbThUYVhuNUFQUEpmdzVHbVJYazBxM0w4?=
 =?utf-8?B?NU51VTRNVWhWWUxIRU4ya0R2K3FvMWpmeXFFT3NXQkd3ZTY4SWFTQzVNYTRa?=
 =?utf-8?B?SmFhc2FoZm96WWd0TzlnWUFMK3BQRjFDd1Mwd2V1dkJERmVrdFhXcGtIU2R2?=
 =?utf-8?B?amVtbkU1NG5UWU9ZaDNmM2xDd2FEZ3J1VXdDb2xZWEFhMWtJYWJBUUFPVDlC?=
 =?utf-8?B?T2U1UTVnV2hONVVFbTNxV2pqNlc4dkxiVlBONlZsZDhJR2lUQnFPYnA2RThi?=
 =?utf-8?B?SnJpNTJxb0JWeUxQLy9BM3JueE5CeXR2Q1ZQWDlhOVJGL0p2RVBIbWpvZ1JV?=
 =?utf-8?B?bjU1VnJpL252UUhBSmtiUnh0S0ZmcnRuTFU0UDZOWGlSMEp1UXZJVjIvZTBl?=
 =?utf-8?Q?IQuR1EWZejiVUSU86lirIRjC2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e111360-443a-4b71-52d5-08dab2706bda
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 07:55:14.3304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WayoxPY/6xzteTnxTc4IpQz8IwSvInLAiM+08JNvkri7ZbX+wrcivb2FxU3wMIX3nK6czv7ftdoL9h0yVTwMDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7833

On 20.10.2022 00:33, Julien Grall wrote:
> On 19/10/2022 22:30, Andrew Cooper wrote:
>> On 18/10/2022 00:01, Julien Grall wrote:
>>>>> ... you are hardcoding both p2m_teardown() and p2m_set_allocation().
>>>>> IMO this is not an improvement at all. It is just making the code more
>>>>> complex than necessary and lack all the explanation on the assumptions.
>>>>>
>>>>> So while I am fine with your patch #1 (already reviewed it), there is
>>>>> a better patch from Henry on the ML. So we should take his (rebased)
>>>>> instead of yours.
>>>>
>>>> If by better, you mean something that still has errors, then sure.
>>>>
>>>> There's a really good reason why you cannot safely repurpose
>>>> p2m_teardown().  It's written expecting a fully constructed domain -
>>>> which is fine because that's how it is used.  It doesn't cope safely
>>>> with an partially constructed domain.
>>>
>>> It is not 100% clear what is the issue you are referring to as the
>>> VMID is valid at this point. So what part would be wrong?
>>
>> Falling over a bad root pointer from an early construction exit.
> 
> You have been mentioning that several time now but I can't see how this
> can happen. If you look at Henry's second patch, p2m_teardown() starts
> with the following check:
> if ( page_list_empty(&p2m->pages) )
>     return;
> 
> Per the logic in p2m_init(), the root pages have to be allocated (note 
> they are *not* allocated from the P2M pool) and the VMID as well before 
> any pages could be added in the list.
> 
>>
>>> But if there are part of p2m_teardown() that are not safe for
>>> partially constructed domain, then we should split the code. This
>>> would be much better that the duplication you are proposing.
>>
>> You have two totally different contexts with different safety
>> requirements.  c/s 55914f7fc9 is a reasonably good and clean separation
>> between preemptible and non-preemptible cleanup[1].
> 
> The part you mention in [1] was decided to be delayed post 4.17 for 
> development cycle reasons.
> 
>>
>> You've agreed that the introduction of the non-preemptible path to the
>> preemptible path is a hack and layering violation, and will need undoing
>> later.  Others have raised this concern too.
> 
> [...]
> 
>>
>> Also realise that you've now split the helper between regular hypercall
>> context, and RCU context, and recall what happened when we finally
>> started asserting that memory couldn't be allocated in stop-machine context.
>>
>> How certain are you that the safety is the same on earlier versions of
>> Xen?
> I am pretty confident because the P2M code has not changed a lot.
> 
>> What is the likelihood that all of these actions will remain safe
>> given future development?
> Code always evolve and neither you (nor I) can claim that any work will 
> stay safe forever. In your patch proposal, then the risk is a bug could 
> be duplicated.
> 
>>
>>
>> Despite what is being claimed, the attempt to share cleanup logic is
>> introducing fragility and risk, not removing it.
> 
> I find interesting you are saying that... If we were going to move 
> p2m_teardown() in domain_teardown() then we would end up to share the code.
> 
> To me, this is not very different here because in one context it would 
> be preemptible while the other it won't. At which point...
> 
>>   This is a bugfix for
>> to a security fix issue which is totally dead on arrival; net safety,
>> especially in older versions of the Xen, is *the highest priority*.
>>
>> These two different contexts don't share any common properties of how to
>> clean up the pool, save freeing the frames back to the memory
>> allocator.  In a proper design, this is the hint that they shouldn't
>> share logic either
> ... why is your design better than what Henry's proposed?
> 
>>
>> Given that you do expect someone to spend yet-more time&effort to undo
>> the short term hack currently being proposed, how do you envisage the
>> end result looking?
> 
> The end result will be p2m_teardown() & co to be called from 
> domain_teardown().
> 
> Anyway, this discussion doesn't make us closer to come to an agreement 
> on the correct approach. We have both very diverging opinion and so far 
> I haven't seen any strong reasons that is showing yours is better.
> 
> So unless Bertrand or Stefano agree with you, then I will go ahead and 
> merge Henry's patch tomorrow after a final review.

While Andrew makes several points worth considering, I agree here that
staging needs unbreaking rather sooner than later. I'm inclined to say
the patches want committing now, unless an actual bug was still known to
be present there (which I can't deduce from Andrew's reply). In the
absence of actual bugs it really should be the maintainers to have the
final say when there are multiple ways of carrying out certain
functionality.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 08:03:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 08:03:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426274.674598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQWn-0005Fb-Lf; Thu, 20 Oct 2022 08:03:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426274.674598; Thu, 20 Oct 2022 08:03:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQWn-0005FU-Hy; Thu, 20 Oct 2022 08:03:45 +0000
Received: by outflank-mailman (input) for mailman id 426274;
 Thu, 20 Oct 2022 08:03:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oIjd=2V=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1olQWm-0005FM-4q
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 08:03:44 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b64ecf75-504d-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 10:03:42 +0200 (CEST)
Received: from AS8PR04CA0019.eurprd04.prod.outlook.com (2603:10a6:20b:310::24)
 by AM9PR08MB6100.eurprd08.prod.outlook.com (2603:10a6:20b:287::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 08:03:40 +0000
Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:310:cafe::b4) by AS8PR04CA0019.outlook.office365.com
 (2603:10a6:20b:310::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Thu, 20 Oct 2022 08:03:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 08:03:40 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Thu, 20 Oct 2022 08:03:40 +0000
Received: from e8341c58fe65.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AC0F9BCA-DC26-46C2-9ABD-15A1540442F2.1; 
 Thu, 20 Oct 2022 08:03:33 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e8341c58fe65.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 08:03:33 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11)
 by PAXPR08MB6720.eurprd08.prod.outlook.com (2603:10a6:102:130::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 08:03:31 +0000
Received: from AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c]) by AS8PR08MB7696.eurprd08.prod.outlook.com
 ([fe80::d793:e6d8:6250:d00c%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 08:03:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b64ecf75-504d-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=gfPIVoupecmNMA61ZyMDScmO5aqCRuoXKaAjUneccnnR5klN//hmKc7Ie0y9X/zlAwBz6T768Yc+sTZNYQ7+PwhliYjrCqPYL9STunwDAGoDWFXJZfhBHJ+c6AkVH1bcLyGZFGeLUfU3uWdo8V1WalSSCdv58pE+X6fSdHvsGzoVz6kBBo/XTjW1hHZHiu1pHXeQ4ZR8n4iP7u/ymH3iPWJeJtFC5OmhTt5mPSpkw2ZjZm8o4fH8YfsombtK2pRR0sZx4+/fZ7bH9vhFIB+/MoYawhY3ajRo4n6TZ2DJzZfQqum0M4L+SwJzBEshc9Jwj+FyLuy+yvATx+KUN+rYQQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pSxYXp92YlagzFFnQkaaPPPaDO8PHE5v8f/k8Fq6jTc=;
 b=HV+wVMpNQqVueWClX8cxTA1YjNb44xCHlsPUPEm16UjzTNfHtjkcZwAvJHXGoaP1yQnahw3vMrUtke/OUvKv0sC1XWO/Kb+JEq/keuTaAPwJBq6s1W6MbCUBXydX3sQIAc4t6J9JqLpJar6hUyPszDetoofK7UErGUOC8I2v9WNICyFfpewxVFy1EG5Bhm5/UfMzTXGeoW9Y1T/G9O0BPPWknS7va7aut4wlc+dkVLXnOTHDvL3ACF7a8/bfpgUiKz2TZWc0foCsZpmtzxYLtpTVs4SzhwrUO9/rDMiHvoOp5Zu/yRVyQYDoNig6QMjYaE82agoS3NlDQMsiEj7pZA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pSxYXp92YlagzFFnQkaaPPPaDO8PHE5v8f/k8Fq6jTc=;
 b=wkKm57uE3QtdzdUZ1YQvGrVXud4YJ3jDrQi8BG5LdPU+WdG4pUiYrFIQG8AYBegAbUry0UPEv4jN+W/8Auiup8/kIPPaJy3XTkm1PkTqPvvzJUGonRkkhwfM/VMKkfWwYaLphFCpVnV+EtX8EMSASQURUExcyuVcRAXR5Ql5ag8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nl3BzI28FOiN88PrDWAPGzhLP5qQ0NrfDgvQO1kbeE1OyHhIGWROkxnddOJfQGZGIYFcjy50IsCrILPZyWEu+JreH24FbHlb0eJ8WLWsx9KvHuP/Bmqy/LdSJH7Clu09LLEbhDJFnE26Fj6j4OaPcmfNUSGCPygawcXQ4cNsgk0WfSWO9aX+d2AcFDWvqgdSkiyRTyWuZvJQ4UEnr/YoGrvMeHzMXm42uZ/KyqYpN7PlJKEXmzM07T6n8V1xG36uEeGSzcSzE24AkzV3d0RD7rn5dX1lgY7yEH508BzGrtaJoHDv8IYtDGvAYw/+/tLmSSGy4q0wpbr/v0+kEJ5vVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pSxYXp92YlagzFFnQkaaPPPaDO8PHE5v8f/k8Fq6jTc=;
 b=B0cfMMgmZybpYh3K5kHvD+5zdNhDmJMwksA9yeQQo46AjBiXb2DtZbvUWeoynjf5jd28WFL3+D26d/+Z/uOkmTC0p6ycqS2+clizbnvjZBNfdm7DuenlN87N3RTE5vTejuChsj5YHJoS38b73efTpWugIFVFjqVsfZwINx0AmVGXLZjwO2EEzhucbjk5DKLS1bPamF7tmuXN2TKRA0Y+b9yLBl2ACmxHxyZXuPOyjBv73bmqLlimyqi3xsnrctNm1VkE6dXhrqEMTkmd/B4+CuJzA9u//3U57NbeJhCgdGXAJLALylxZdvNmIKqouXVubunQhl52X9HFPcm+nwtPHg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pSxYXp92YlagzFFnQkaaPPPaDO8PHE5v8f/k8Fq6jTc=;
 b=wkKm57uE3QtdzdUZ1YQvGrVXud4YJ3jDrQi8BG5LdPU+WdG4pUiYrFIQG8AYBegAbUry0UPEv4jN+W/8Auiup8/kIPPaJy3XTkm1PkTqPvvzJUGonRkkhwfM/VMKkfWwYaLphFCpVnV+EtX8EMSASQURUExcyuVcRAXR5Ql5ag8=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: RE: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Thread-Topic: [PATCH v3 05/10] automation: Add Arm containers to containerize
 script
Thread-Index: AQHY0lZFu/mKHMVlEk6rDAaZCITsX64Ws3HQgABK2QCAAAFz0IAADTKAgAABtvA=
Date: Thu, 20 Oct 2022 08:03:31 +0000
Message-ID:
 <AS8PR08MB76965761992D481299A7F0E9922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
References: <20220927094727.12762-1-michal.orzel@amd.com>
 <20220927094727.12762-6-michal.orzel@amd.com>
 <AS8PR08MB7696D8C9D2239CC9ED2FE08F922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
 <bc41f3a0-27ec-8bbe-a087-125acc20df2f@amd.com>
 <AS8PR08MB769676050B41BCEDCA3F2891922A9@AS8PR08MB7696.eurprd08.prod.outlook.com>
 <e0e0d4af-54e0-6dee-2f01-99bb5d31d346@amd.com>
In-Reply-To: <e0e0d4af-54e0-6dee-2f01-99bb5d31d346@amd.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 086B72B8A37B2C4493F8AAC284F2D792.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7696:EE_|PAXPR08MB6720:EE_|AM7EUR03FT041:EE_|AM9PR08MB6100:EE_
X-MS-Office365-Filtering-Correlation-Id: 0bd534e6-7ec1-4b1e-0ff3-08dab271999a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 qbpIq+PULakANcrV/v4M72F3xThbVvcNhB1elVNILz4yZ2Rhu3PLP59VTAW9x5tcZRTojex4quSX2eBZZrnP14As/bSC9OBez8Be8sS1eiDdZH5DJxYn6RFOe3IV+MLPmGMVCuPC09AI/gI+z/l9cL9CmaKeLSKYtAiZ7bsWhyfa1+F8qA8tmOttkKEJFPCZ9VfO4ygTZXi9YV9hajCadXiA2jNVjzq4ZE9CVH/MVUu9uGEo8oP4OXBOp39S5NpEgVLLVLS4sIGDfdqBoUxPOHC1WkESps9mi+dBJhZ16uQ/n12JocIRL027tXVjDnvqUItwuXzJJs3jJbyLF2K/7H+CghzExZvxETTweM3gpyxjSnBYs4qyxEa4Y+8bkX8q0Wmz+cftt7/0pPIoxVxBm/NTToT0+pHkwLHRaZVMsAukJgzC2eIe0xzrb+gqsVYwumwJ9bK9L2wb3pt0WdQmhA3zgLC0iC2q7SrAtxKoJ/sRDtvCD9SL5TRET3/DnutjmbgKw5E9DSOjdB+2Qqq/9kZhUwKoDXaFYknpLEuq8Wz196GVgQL7D8/SH5HSoP0m705BxS9sUOIw8bYnr29998eAAUcTkClfzQVPc5dg3iNlkviptTzKs3aMnRb4i3Ah7epszqRA8CcwVo587NTl10fPdcdvbwSo2VuqAm9cUVC8mCe0XwoZ/fovFPpR0EwO2mp+G/X2VSkliiNB/GddpKShh4aMSEwL9cb3CN+Hda29zYWxUZA+OAPDlVM4i5F5D+LmSKPpMvZJIer5hFsX5N1iNjjI8m3F9nE6KKzyAn8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(451199015)(9686003)(7696005)(83380400001)(52536014)(5660300002)(71200400001)(26005)(84970400001)(53546011)(6506007)(478600001)(316002)(66556008)(110136005)(54906003)(66446008)(66946007)(4326008)(41300700001)(86362001)(76116006)(186003)(64756008)(8936002)(55016003)(33656002)(66476007)(2906002)(38070700005)(8676002)(38100700002)(122000001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6720
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f3b9496e-1587-432f-7a43-08dab271941f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DRqEcuEaCoRs2sKrp9YAzv1+TcavKsP7b03Km9EOhJGiFDkRjr/HvK82MuaNYLKxV9pXv7tzc4v8FCT7/shaOQlxVXn3x3URwZ5DSGkDMSvDYTeXBvAOtevTp7eNDzPThk1P9aSopH3C3Ol+36x7t+RjyhF5Gjq+05lglQ9GsHcPXDoPGrG9Eksh8IpHKC8TJ1q3o3RyCLlW7feWqdUp4x/S8ROtBu0/qWmX2gtbM1gn4OaoN115aT/wPqJxUiZdGXxxwM5BZdO/raFoA17hItq6kcrXNsRYy7poZSzHKhV1QPp8mTnBoFJcPrBvPIX4HZQc4+t/lZIZSTj6ahT3ZmA6CMa93QmT97PwVDRWBPfZWku34mWgNh0XS1CP9meAxkkX7u69serYJyAlIZrFldeQVZBrSBuiSij+nbxwHlfOERDsIgqOb1ye3rDe55A6ldONLImU4uk/GhkQha+9iWHh2jhfH2UWKZdUYcRak2zRboBdDJfBDk9dndGjGXq/LV1kc8GjiDquaRbsXVa7Hj1zlEGGlGUOtAszMxS6qm/qzXc0FGgizvWH1Hp6F2uKttuR2jAEUEhaHsJBwdVCLmkrYd0zz2WdclGuKuU2M1cNXEL/Kb3UB4PBystux6+Upq6rDFHY+VcTSQFwUevpJHrLqxDAlGKGEBCzi8j7tSixihhkD/H1uaW6tWpraMD5EnL6OYcAR3jAbHae5mPZEOzZQaY0kU/N12mlOynP59H0AyFzm5Wtl6fJN4DkwVigeaFYtpR+1iSQUWExSuj5bcr+TKylYiqybXaY4RyDcGs=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(47076005)(336012)(186003)(84970400001)(55016003)(40480700001)(33656002)(107886003)(2906002)(356005)(81166007)(86362001)(40460700003)(82740400003)(82310400005)(83380400001)(70586007)(6506007)(7696005)(53546011)(36860700001)(26005)(9686003)(316002)(41300700001)(70206006)(8676002)(4326008)(478600001)(110136005)(54906003)(5660300002)(8936002)(52536014);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 08:03:40.3624
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd534e6-7ec1-4b1e-0ff3-08dab271999a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6100

SGkgTWljaGFsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE1pY2hh
bCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+IFNlbnQ6IFRodXJzZGF5LCBPY3RvYmVy
IDIwLCAyMDIyIDM6NTIgUE0NCj4gVG86IEppYW1laSBYaWUgPEppYW1laS5YaWVAYXJtLmNvbT47
IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogRG91ZyBHb2xkc3RlaW4gPGNh
cmRvZUBjYXJkb2UuY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJu
ZWwub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDA1LzEwXSBhdXRvbWF0aW9uOiBBZGQg
QXJtIGNvbnRhaW5lcnMgdG8NCj4gY29udGFpbmVyaXplIHNjcmlwdA0KPiANCj4gSGkgSmlhbWVp
LA0KPiANCj4gT24gMjAvMTAvMjAyMiAwOToxMywgSmlhbWVpIFhpZSB3cm90ZToNCj4gPg0KPiA+
DQo+ID4gSGkgTWljaGFsLA0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+
ID4+IEZyb206IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+DQo+ID4+IFNlbnQ6
IFRodXJzZGF5LCBPY3RvYmVyIDIwLCAyMDIyIDI6NTkgUE0NCj4gPj4gVG86IEppYW1laSBYaWUg
PEppYW1laS5YaWVAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiA+
PiBDYzogRG91ZyBHb2xkc3RlaW4gPGNhcmRvZUBjYXJkb2UuY29tPjsgU3RlZmFubyBTdGFiZWxs
aW5pDQo+ID4+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+PiBTdWJqZWN0OiBSZTogW1BB
VENIIHYzIDA1LzEwXSBhdXRvbWF0aW9uOiBBZGQgQXJtIGNvbnRhaW5lcnMgdG8NCj4gPj4gY29u
dGFpbmVyaXplIHNjcmlwdA0KPiA+Pg0KPiA+PiBIaSBKaWFtZWksDQo+ID4+DQo+ID4+IE9uIDIw
LzEwLzIwMjIgMDU6MDAsIEppYW1laSBYaWUgd3JvdGU6DQo+ID4+Pg0KPiA+Pj4NCj4gPj4+IEhp
IE1pY2hhbCwNCj4gPj4+DQo+ID4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4+
PiBGcm9tOiBYZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3Jn
PiBPbiBCZWhhbGYNCj4gT2YNCj4gPj4+PiBNaWNoYWwgT3J6ZWwNCj4gPj4+PiBTZW50OiBUdWVz
ZGF5LCBTZXB0ZW1iZXIgMjcsIDIwMjIgNTo0NyBQTQ0KPiA+Pj4+IFRvOiB4ZW4tZGV2ZWxAbGlz
dHMueGVucHJvamVjdC5vcmcNCj4gPj4+PiBDYzogTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxA
YW1kLmNvbT47IERvdWcgR29sZHN0ZWluDQo+ID4+Pj4gPGNhcmRvZUBjYXJkb2UuY29tPjsgU3Rl
ZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+Pj4+IFN1YmplY3Q6
IFtQQVRDSCB2MyAwNS8xMF0gYXV0b21hdGlvbjogQWRkIEFybSBjb250YWluZXJzIHRvDQo+ID4+
IGNvbnRhaW5lcml6ZQ0KPiA+Pj4+IHNjcmlwdA0KPiA+Pj4+DQo+ID4+Pj4gU2NyaXB0IGF1dG9t
YXRpb24vc2NyaXB0cy9jb250YWluZXJpemUgbWFrZXMgaXQgZWFzeSB0byBidWlsZCBYZW4NCj4g
d2l0aGluDQo+ID4+Pj4gcHJlZGVmaW5lZCBjb250YWluZXJzIGZyb20gZ2l0bGFiIGNvbnRhaW5l
ciByZWdpc3RyeS4gVGhpcyBzY3JpcHQgaXMNCj4gPj4+PiBjdXJyZW50bHkgbWlzc2luZyB0aGUg
aGVscGVycyB0byBzZWxlY3QgQXJtIGNvbnRhaW5lcnMsIHNvIHBvcHVsYXRlIHRoZQ0KPiA+Pj4+
IG5lY2Vzc2FyeSBlbnRyaWVzLg0KPiA+Pj4+DQo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogTWljaGFs
IE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4NCj4gPj4+PiBBY2tlZC1ieTogU3RlZmFubyBT
dGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+Pj4+IC0tLQ0KPiA+Pg0KPiA+
Pj4NCj4gPj4+IFtKaWFtZWkgWGllXQ0KPiA+Pj4gSSB3b25kZXIgaWYgYW4gZGVmYXVsdCBjb250
YWluZXIgZm9yIGFybSBjYW4gYmUgYWRkZWQuIEZvciBleGFtcGxlLCAgaWYNCj4gPj4+ICAiQ09O
VEFJTkVSPWFybTY0IGF1dG9tYXRpb24vc2NyaXB0cy9jb250YWluZXJpemUgYmFzaCIsDQo+ID4+
PiAgc2V0IHRoZSBkZWZhdWx0IENPTlRBSU5FUiBhcyAicmVnaXN0cnkuZ2l0bGFiLmNvbS94ZW4t
DQo+ID4+IHByb2plY3QveGVuL2FscGluZTozLjEyLWFybTY0djgiDQo+ID4+Pg0KPiA+Pg0KPiA+
PiBJdCBjYW4gYmUgYWRkZWQgZG9pbmcgdGhlIGZvbGxvd2luZzoNCj4gPj4NCj4gPj4gZGlmZiAt
LWdpdCBhL2F1dG9tYXRpb24vc2NyaXB0cy9jb250YWluZXJpemUNCj4gPj4gYi9hdXRvbWF0aW9u
L3NjcmlwdHMvY29udGFpbmVyaXplDQo+ID4+IGluZGV4IDBmNDY0NWM0Y2NjYi4uYjM5NWJkMzU5
ZWNmIDEwMDc1NQ0KPiA+PiAtLS0gYS9hdXRvbWF0aW9uL3NjcmlwdHMvY29udGFpbmVyaXplDQo+
ID4+ICsrKyBiL2F1dG9tYXRpb24vc2NyaXB0cy9jb250YWluZXJpemUNCj4gPj4gQEAgLTI1LDcg
KzI1LDcgQEAgZGllKCkgew0KPiA+PiAgQkFTRT0icmVnaXN0cnkuZ2l0bGFiLmNvbS94ZW4tcHJv
amVjdC94ZW4iDQo+ID4+ICBjYXNlICJfJHtDT05UQUlORVJ9IiBpbg0KPiA+PiAgICAgIF9hbHBp
bmUpIENPTlRBSU5FUj0iJHtCQVNFfS9hbHBpbmU6My4xMiIgOzsNCj4gPj4gLSAgICBfYWxwaW5l
LWFybTY0djgpIENPTlRBSU5FUj0iJHtCQVNFfS9hbHBpbmU6My4xMi1hcm02NHY4IiA7Ow0KPiA+
PiArICAgIF9hbHBpbmUtYXJtNjR2OHxfYXJtNjQpIENPTlRBSU5FUj0iJHtCQVNFfS9hbHBpbmU6
My4xMi0NCj4gYXJtNjR2OCIgOzsNCj4gPj4gICAgICBfYXJjaGxpbnV4fF9hcmNoKSBDT05UQUlO
RVI9IiR7QkFTRX0vYXJjaGxpbnV4OmN1cnJlbnQiIDs7DQo+ID4+ICAgICAgX3Jpc2N2NjQpIENP
TlRBSU5FUj0iJHtCQVNFfS9hcmNobGludXg6cmlzY3Y2NCIgOzsNCj4gPj4gICAgICBfY2VudG9z
NykgQ09OVEFJTkVSPSIke0JBU0V9L2NlbnRvczo3IiA7Ow0KPiA+Pg0KPiA+PiBUaGUgcXVlc3Rp
b24gaXMgd2hldGhlciBpdCB3b3VsZCBiZSBiZW5lZmljaWFsLiBBZnRlciBhbGwgeW91IHdvdWxk
IHN0aWxsDQo+IG5lZWQNCj4gPj4gdG8NCj4gPj4gdHlwZSBDT05UQUlORVI9YXJtNjQsIHdoZXJl
YXMgYXQgdGhlIG1vbWVudCwgeW91IG5lZWQgdG8gdHlwZQ0KPiA+PiBDT05UQUlORVI9YWxwaW5l
LWFybTY0djguDQo+ID4+IFRCSCBJJ20gbm90IHN1cmUgaXQgaXMgaW1wcm92aW5nIGFueXRoaW5n
ICg/KS4NCj4gPj4NCj4gPj4gfk1pY2hhbA0KPiA+IFtKaWFtZWkgWGllXQ0KPiA+IEkgYW0gbm90
IHN1cmUgYWJvdXQgdGhpcyBlaXRoZXIuICBJIGFkZGVkIHNvbWV0aGluZyBsaWtlIGJlbG93IGYg
dG8gcnVuIGl0IG9uDQo+IGFybTY0IG1hY2hpbmUuICAgQnV0IGl0ICBkaWRuJ3QgdGFrZSAicnVu
bmluZyBjb250YWluZXIgZm9yIGEgZGlmZmVyZW50DQo+IGFyY2hpdGVjdHVyZSIgaW50byBjb25z
aWRlcmF0aW9uLg0KPiA+DQo+IFNvIHlvdXIgcXVlc3Rpb24gaXMgbm90IGFib3V0IGFkZGluZyBk
ZWZhdWx0IGNvbnRhaW5lciB3aGVuIHNlbGVjdGluZw0KPiBDT05UQUlORVI9YXJtNjQsIGJ1dCBh
ZGRpbmcNCj4gYSBkZWZhdWx0IG9uZSB3aGVuIHJ1bm5pbmcgb24gYXJtNjQgcGxhdGZvcm0uIFJp
Z2h0IG5vdywgdGhlIGRlZmF1bHQgb25lDQo+IGlzIGRlYmlhbjpzdHJldGNoDQo+IChpZiB5b3Ug
ZG9uJ3QgdHlwZSBDT05UQUlORVI9IGF0IGFsbCkuIERvIEkgdW5kZXJzdGFuZCBpdCByaWdodCB0
aGF0IHlvdQ0KPiB3b3VsZCBsaWtlIHRoZSBzYW1lDQo+IGJlaGF2aW9yIHdoZW4gcnVubmluZyBv
biBhcm02NCBwbGF0Zm9ybSAoY3VycmVudGx5LCBpdCB3b3VsZCBhbHNvIHNlbGVjdA0KPiBkZWJp
YW46c3RyZXRjaCk/DQo+IFNvIHRoYXQgd2hlbiBleGVjdXRpbmc6DQo+IC4vYXV0b21hdGlvbi9z
Y3JpcHRzL2NvbnRhaW5lcml6ZSAuLi4NCj4gaXQgd291bGQgYXV0b21hdGljYWxseSBzZWxlY3Qg
YWxwaW5lLWFybTY0djg/DQo+IA0KWWVzLCB0aGlzIGlzIHdoYXQgSSBtZWFuLg0KPiANCj4gPiAt
LS0gYS9hdXRvbWF0aW9uL3NjcmlwdHMvY29udGFpbmVyaXplDQo+ID4gKysrIGIvYXV0b21hdGlv
bi9zY3JpcHRzL2NvbnRhaW5lcml6ZQ0KPiA+IEBAIC0xOCw2ICsxOCwxMiBAQCBkaWUoKSB7DQo+
ID4gICAgICBleGl0IDENCj4gPiAgfQ0KPiA+DQo+ID4gKyMgVGhlcmUgYXJlIHR3byBjb250YWlu
ZXJzIHRoYXQgY2FuIHJ1biBvbiBhYXJjaDY0LCB1bnN0YWJsZSBhbmQgYWxwaW5lLg0KPiA+ICsj
IFNldCB0aGUgZGVmYXVsdCBjb250YWluZXIgdG8gYWxwaW5lIGZvciBhYXJjaDY0DQo+ID4gK2lm
IFtbICQodW5hbWUgLW0pID0gImFhcmNoNjQiICYmIC16ICR7Q09OVEFJTkVSfSBdXTsgdGhlbg0K
PiBUaGUgb3V0cHV0IGZyb20gYHVuYW1lIC1tYCBmb3IgYXJtNjQgY2FuIGJlIGFhcmNoNjQgYW5k
IGFybTY0Lg0KPiANCj4gPiArICAgIENPTlRBSU5FUj0iYWxwaW5lIg0KPiA+ICtmaQ0KPiA+ICsN
Cj4gPiAgIw0KPiA+ICAjIFRoZSBjYWxsZXIgaXMgZXhwZWN0ZWQgdG8gb3ZlcnJpZGUgdGhlIENP
TlRBSU5FUiBlbnZpcm9ubWVudA0KPiA+ICAjIHZhcmlhYmxlIHdpdGggdGhlIGNvbnRhaW5lciB0
aGV5IHdpc2ggdG8gbGF1bmNoLg0KPiA+IEBAIC00MSw2ICs0NywxMSBAQCBjYXNlICJfJHtDT05U
QUlORVJ9IiBpbg0KPiA+ICAgICAgX29wZW5zdXNlLXR1bWJsZXdlZWR8X3R1bWJsZXdlZWQpDQo+
IENPTlRBSU5FUj0iJHtCQVNFfS9zdXNlOm9wZW5zdXNlLXR1bWJsZXdlZWQiIDs7DQo+ID4gIGVz
YWMNCj4gPg0KPiA+ICsjIENvbnRhaW5lcnMgZm9yIGFhcmNoNjQgaGF2ZSBhIHN1Zml4ICItYXJt
NjR2OCINCj4gPiAraWYgW1sgJCh1bmFtZSAtbSkgPSAiYWFyY2g2NCIgXV07IHRoZW4NCj4gPiAr
ICAgIENPTlRBSU5FUj0iJHtDT05UQUlORVJ9LWFybTY0djgiDQo+ID4gK2ZpDQo+IFRoaXMgaXMg
bm90IG5lZWRlZC4gQ09OVEFJTkVSIGNhbiBiZSBzZWxlY3RlZCBvbiB0aGUgZmlyc3QgY2hlY2sg
YW5kIGxldA0KPiBjYXNlL2VzYWMgYmxvY2sNCj4gdG8gZGV0ZXJtaW5lIHRoZSBmdWxsIHBhdGgg
dG8gY29udGFpbmVyLg0KPiANCj4gPiArDQo+ID4gICMgVXNlIHRoaXMgdmFyaWFibGUgdG8gY29u
dHJvbCB3aGV0aGVyIHJvb3Qgc2hvdWxkIGJlIHVzZWQNCj4gPiAgY2FzZSAiXyR7Q09OVEFJTkVS
X1VJRDB9IiBpbg0KPiA+ICAgICAgXzEpICAgdXNlcmFyZz0gOzsNCj4gPg0KPiA+DQo+ID4gQmVz
dCB3aXNoZXMNCj4gPiBKaWFtZWkgWGllDQo+ID4NCj4gPg0KPiANCj4gV2hhdCB5b3UgYXJlIGFz
a2luZyBmb3IgY2FuIGJlIGRvbmUgaW4gYSBzaW1wbGVyIHdheS4gVGhlIGZvbGxvd2luZyBpcw0K
PiBlbm91Z2g6DQo+IA0KPiBkaWZmIC0tZ2l0IGEvYXV0b21hdGlvbi9zY3JpcHRzL2NvbnRhaW5l
cml6ZQ0KPiBiL2F1dG9tYXRpb24vc2NyaXB0cy9jb250YWluZXJpemUNCj4gaW5kZXggMGY0NjQ1
YzRjY2NiLi40ZTdlOGJiNDhlM2EgMTAwNzU1DQo+IC0tLSBhL2F1dG9tYXRpb24vc2NyaXB0cy9j
b250YWluZXJpemUNCj4gKysrIGIvYXV0b21hdGlvbi9zY3JpcHRzL2NvbnRhaW5lcml6ZQ0KPiBA
QCAtMTgsNiArMTgsMTEgQEAgZGllKCkgew0KPiAgICAgIGV4aXQgMQ0KPiAgfQ0KPiANCj4gKyMg
U2VsZWN0IGRlZmF1bHQgY29udGFpbmVyIHdoZW4gcnVubmluZyBvbiBhcm02NCBtYWNoaW5lLg0K
PiAraWYgWyAteiAiJHtDT05UQUlORVJ9IiBdICYmIHVuYW1lIC1tIHwgZ3JlcCAtcUUgJ2FhcmNo
NjR8YXJtNjQnOyB0aGVuDQo+ICsgICAgQ09OVEFJTkVSPSJhbHBpbmUtYXJtNjR2OCINCj4gK2Zp
DQo+ICsNCj4gICMNCj4gICMgVGhlIGNhbGxlciBpcyBleHBlY3RlZCB0byBvdmVycmlkZSB0aGUg
Q09OVEFJTkVSIGVudmlyb25tZW50DQo+ICAjIHZhcmlhYmxlIHdpdGggdGhlIGNvbnRhaW5lciB0
aGV5IHdpc2ggdG8gbGF1bmNoLg0KPiANCj4gfk1pY2hhbA0KWWVhaCwgSSBhZ3JlZSB3aXRoIHRo
aXMgIGltcGxlbWVudGF0aW9uLiANCg0KQmVzdCB3aXNoZXMNCkppYW1laSBYaWUNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 08:24:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 08:24:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426282.674609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQqa-0007lp-G6; Thu, 20 Oct 2022 08:24:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426282.674609; Thu, 20 Oct 2022 08:24:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQqa-0007li-Cy; Thu, 20 Oct 2022 08:24:12 +0000
Received: by outflank-mailman (input) for mailman id 426282;
 Thu, 20 Oct 2022 08:24:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rNmt=2V=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1olQqZ-0007lc-BF
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 08:24:11 +0000
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com
 [2a00:1450:4864:20::32a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 91f3f12c-5050-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 10:24:09 +0200 (CEST)
Received: by mail-wm1-x32a.google.com with SMTP id
 186-20020a1c02c3000000b003c6c154d528so1727325wmc.4
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 01:24:09 -0700 (PDT)
Received: from [192.168.1.93] (adsl-46.176.58.194.tellas.gr. [176.58.194.46])
 by smtp.gmail.com with ESMTPSA id
 d15-20020adffd8f000000b0022e309d35f8sm15774481wrr.12.2022.10.20.01.24.07
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 01:24:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91f3f12c-5050-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=0uvn2r8+SbuGnCUYBaYa7eNv/J6QlUQPzRsgRxuCTqM=;
        b=KwatoKpqZLGxx/nD9zodPBdIoTcxTf7tsD1Eu01UyiGqylmxbkR4xJem8pmw5my34L
         If3IaJvU+FkrI5wyXKJCg1eDOJNIWGkr7dHMGXOi47PrdzTlTV9z8BxhuShdXuKllKOz
         hOpuZhp7bL5dr7/MTkWIEEBCvO6cTe24YN9XuQtLk6YWeEZbILuxeJunsJkbB/6yEmhE
         jYkIZr0niNJmfHzhT/GfGNBoN6CSmU6f3wXTchdyxDDeZgTrI1XMOI0mWIbvEuM5vgUr
         eN/MSIkJlC7pdOduPXLZVGwb0rFaKPSMJyNr0WNZgiahLQkLPPNVq//iH/BIPJQ2KLue
         /ujQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=0uvn2r8+SbuGnCUYBaYa7eNv/J6QlUQPzRsgRxuCTqM=;
        b=HnVR0jg7ORsS8HgY68gYdoRqWxyrIY6UkQb6ERbaijdp4uBYIzn5Ugb0mXuKMYYE+s
         0fo3HzTS4mpBpZFoAmCkTku5IQuEc8NnLQzAOTf6M2KXczwWe5zIGr9TGniMvvMqfo2c
         F+Roes3w74jc8q5uOyGJxLG+u2oJk6BXXLOP9h4HaJDDdV73j0O067R7j9J3Og+ovTJe
         merdQQ9m3A5/0bkaYNhNRb6QATX8engEqM4axTFDjgMKepP1896MA5dvde98BcAoIORh
         jvPjkWlKDrQN8t4t/kP7waGoVaBjj9yOjQRYUfEEpQwXGqq2So+0WsUVFA5lh05WD+KU
         MQEA==
X-Gm-Message-State: ACrzQf1OID42ylve9nySpCTf5xHhTimaFWIZ5Qp18Ba+ju0quT2C1UAA
	bTkigF0wltrJQnMRyp3T5UKt4CfrdOw=
X-Google-Smtp-Source: AMsMyM7RwXNA2b5CBNQ8QvInzSbgWsYrZoRbB/ISxOP/vOrQQXFtpC/vHoKAHLnVy/XPntnvtofd9g==
X-Received: by 2002:a05:600c:1906:b0:3c6:f154:d4b5 with SMTP id j6-20020a05600c190600b003c6f154d4b5mr8355717wmq.94.1666254248923;
        Thu, 20 Oct 2022 01:24:08 -0700 (PDT)
Message-ID: <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
Date: Thu, 20 Oct 2022 11:24:06 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
 <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/19/22 22:41, Oleksandr Tyshchenko wrote:

Hi Oleksandr

> 
> On 19.10.22 11:47, Xenia Ragiadakou wrote:
> 
> Hello Xenia
> 
>> On 10/19/22 03:58, Stefano Stabellini wrote:
>>> On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> Use the same "xen-grant-dma" device concept for the PCI devices
>>>> behind device-tree based PCI Host controller, but with one
>>>> modification.
>>>> Unlike for platform devices, we cannot use generic IOMMU bindings
>>>> (iommus property), as we need to support more flexible configuration.
>>>> The problem is that PCI devices under the single PCI Host controller
>>>> may have the backends running in different Xen domains and thus have
>>>> different endpoints ID (backend domains ID).
>>>>
>>>> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
>>>> properties) which allows us to describe relationship between PCI
>>>> devices and backend domains ID properly.
>>>>
>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> Now that I understood the approach and the reasons for it, I can review
>>> the patch :-)
>>>
>>> Please add an example of the bindings in the commit message.
>>>
>>>
>>>> ---
>>>> Slightly RFC. This is needed to support Xen grant mappings for
>>>> virtio-pci devices
>>>> on Arm at some point in the future. The Xen toolstack side is not
>>>> completely ready yet.
>>>> Here, for PCI devices we use more flexible way to pass backend domid
>>>> to the guest
>>>> than for platform devices.
>>>>
>>>> Changes V1 -> V2:
>>>>      - update commit description
>>>>      - rebase
>>>>      - rework to use generic PCI-IOMMU bindings instead of generic
>>>> IOMMU bindings
>>>>
>>>> Previous discussion is at:
>>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!3-vq7Edm3XfKtD5cnNjnOzDQvuo_XrhJ73yH-nPfqOkGGU0IjLG7R7MR_nAJCAPeOutHRLT44wKYwQwz3SauACie_ZAy$
>>>> [lore[.]kernel[.]org]
>>>>
>>>> Based on:
>>>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1__;!!GF_29dbcQIUBPA!3-vq7Edm3XfKtD5cnNjnOzDQvuo_XrhJ73yH-nPfqOkGGU0IjLG7R7MR_nAJCAPeOutHRLT44wKYwQwz3SauAEnMDHAq$
>>>> [git[.]kernel[.]org]
>>>> ---
>>>>    drivers/xen/grant-dma-ops.c | 87
>>>> ++++++++++++++++++++++++++++++++-----
>>>>    1 file changed, 76 insertions(+), 11 deletions(-)
>>>>
>>>> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
>>>> index daa525df7bdc..b79d9d6ce154 100644
>>>> --- a/drivers/xen/grant-dma-ops.c
>>>> +++ b/drivers/xen/grant-dma-ops.c
>>>> @@ -10,6 +10,7 @@
>>>>    #include <linux/module.h>
>>>>    #include <linux/dma-map-ops.h>
>>>>    #include <linux/of.h>
>>>> +#include <linux/pci.h>
>>>>    #include <linux/pfn.h>
>>>>    #include <linux/xarray.h>
>>>>    #include <linux/virtio_anchor.h>
>>>> @@ -292,12 +293,55 @@ static const struct dma_map_ops
>>>> xen_grant_dma_ops = {
>>>>        .dma_supported = xen_grant_dma_supported,
>>>>    };
>>>>    +static struct device_node *xen_dt_get_pci_host_node(struct device
>>>> *dev)
>>>> +{
>>>> +    struct pci_dev *pdev = to_pci_dev(dev);
>>>> +    struct pci_bus *bus = pdev->bus;
>>>> +
>>>> +    /* Walk up to the root bus to look for PCI Host controller */
>>>> +    while (!pci_is_root_bus(bus))
>>>> +        bus = bus->parent;
>>>> +
>>>> +    return of_node_get(bus->bridge->parent->of_node);
>>>> +}
>>>
>>> It seems silly that we need to walk the hierachy that way, but I
>>> couldn't find another way to do it
>>>
>>>
>>>> +static struct device_node *xen_dt_get_node(struct device *dev)
>>>> +{
>>>> +    if (dev_is_pci(dev))
>>>> +        return xen_dt_get_pci_host_node(dev);
>>>> +
>>>> +    return of_node_get(dev->of_node);
>>>> +}
>>>> +
>>>> +static int xen_dt_map_id(struct device *dev, struct device_node
>>>> **iommu_np,
>>>> +             u32 *sid)
>>>> +{
>>>> +    struct pci_dev *pdev = to_pci_dev(dev);
>>>> +    u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
>>>> +    struct device_node *host_np;
>>>> +    int ret;
>>>> +
>>>> +    host_np = xen_dt_get_pci_host_node(dev);
>>>> +    if (!host_np)
>>>> +        return -ENODEV;
>>>> +
>>>> +    ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask",
>>>> iommu_np, sid);
>>>> +    of_node_put(host_np);
>>>> +    return ret;
>>>> +}
>>>> +
>>>>    static bool xen_is_dt_grant_dma_device(struct device *dev)
>>>>    {
>>>> -    struct device_node *iommu_np;
>>>> +    struct device_node *iommu_np = NULL;
>>>>        bool has_iommu;
>>>>    -    iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>> +    if (dev_is_pci(dev)) {
>>>> +        if (xen_dt_map_id(dev, &iommu_np, NULL))
>>>> +            return false;
>>>> +    } else
>>>> +        iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>> +
>>>>        has_iommu = iommu_np &&
>>>>                of_device_is_compatible(iommu_np, "xen,grant-dma");
>>>>        of_node_put(iommu_np);
>>>> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct
>>>> device *dev)
>>>>      bool xen_is_grant_dma_device(struct device *dev)
>>>>    {
>>>> +    struct device_node *np;
>>>> +
>>>>        /* XXX Handle only DT devices for now */
>>>> -    if (dev->of_node)
>>>> -        return xen_is_dt_grant_dma_device(dev);
>>>> +    np = xen_dt_get_node(dev);
>>>> +    if (np) {
>>>> +        bool ret;
>>>> +
>>>> +        ret = xen_is_dt_grant_dma_device(dev);
>>>> +        of_node_put(np);
>>>> +        return ret;
>>>> +    }
>>>
>>> We don't need to walk the PCI hierachy twice. Maybe we can add the
>>> of_node check directly to xen_is_dt_grant_dma_device?
>>>
>>
>> I think in general we could pass directly the host bridge device if
>> dev_is_pci(dev) (which can be retrieved with
>> pci_get_host_bridge_device(to_pci_dev(dev), and after done with it
>> pci_put_host_bridge_device(phb)).
>> So that, xen_is_dt_grant_dma_device() and
>> xen_dt_grant_init_backend_domid() won't need to discover it themselves.
>> This will simplify the code.
> 
> 
> Good point. I have some remark. Can we use pci_find_host_bridge()
> instead? This way we don't have to add #include "../pci/pci.h", and have
> to drop reference afterwards.
> 
> With that xen_dt_get_pci_host_node() will became the following:
> 
> 
> static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
> {
>       struct pci_host_bridge *bridge =
> pci_find_host_bridge(to_pci_dev(dev)->bus);
> 
>       return of_node_get(bridge->dev.parent->of_node);
> }
> 

You are right. I prefer your version instead of the above.

> 
> With Stefano's suggestion, we won't walk the PCI hierarchy twice when
> executing xen_is_grant_dma_device() for PCI device:
> 
> xen_is_grant_dma_device() -> xen_is_dt_grant_dma_device() ->
> xen_dt_map_id() -> xen_dt_get_pci_host_node()
> 
> 
> What do you think?
> 

I was thinking passing the device_node along with the device in the 
function arguments. More specifically, of doing this (not tested, just 
an idea):

bool xen_is_grant_dma_device(struct device *dev)
{
     struct device_node *np;
     bool has_iommu = false;

     /* XXX Handle only DT devices for now */
     np = xen_dt_get_node(dev);
     if (np)
         has_iommu = xen_is_dt_grant_dma_device(dev, np);
     of_node_put(np);
     return has_iommu;
}

static bool xen_is_dt_grant_dma_device(struct device *dev,
                                        struct device_node *np)
{
     struct device_node *iommu_np = NULL;
     bool has_iommu;

     if (dev_is_pci(dev)) {
         struct pci_dev *pdev = to_pci_dev(dev);
	u32 id = PCI_DEVID(pdev->bus->number, pdev->devfn);
         of_map_id(np, id, "iommu-map", "iommu-map-mask", &iommu_np, NULL);
     } else {
         iommu_np = of_parse_phandle(np, "iommus", 0);
     }
	
     has_iommu = iommu_np && of_device_is_compatible(iommu_np, 
"xen,grant-dma");
     of_node_put(iommu_np);

     return has_iommu;
}

I 'm wondering ... is it possible for the host bridge device node to 
have the iommus property set? meaning that all of its pci devs will have 
the same backend?

>>
>>>
>>>>        return false;
>>>>    }
>>>> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device
>>>> *dev)
>>>>    static int xen_dt_grant_init_backend_domid(struct device *dev,
>>>>                           struct xen_grant_dma_data *data)
>>>>    {
>>>> -    struct of_phandle_args iommu_spec;
>>>> +    struct of_phandle_args iommu_spec = { .args_count = 1 };
>>>>    -    if (of_parse_phandle_with_args(dev->of_node, "iommus",
>>>> "#iommu-cells",
>>>> -            0, &iommu_spec)) {
>>>> -        dev_err(dev, "Cannot parse iommus property\n");
>>>> -        return -ESRCH;
>>>> +    if (dev_is_pci(dev)) {
>>>> +        if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
>>>> +            dev_err(dev, "Cannot translate ID\n");
>>>> +            return -ESRCH;
>>>> +        }
>>>> +    } else {
>>>> +        if (of_parse_phandle_with_args(dev->of_node, "iommus",
>>>> "#iommu-cells",
>>>> +                0, &iommu_spec)) {
>>>> +            dev_err(dev, "Cannot parse iommus property\n");
>>>> +            return -ESRCH;
>>>> +        }
>>>>        }
>>>>          if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
>>>> @@ -354,6 +413,7 @@ static int
>>>> xen_dt_grant_init_backend_domid(struct device *dev,
>>>>    void xen_grant_setup_dma_ops(struct device *dev)
>>>>    {
>>>>        struct xen_grant_dma_data *data;
>>>> +    struct device_node *np;
>>>>          data = find_xen_grant_dma_data(dev);
>>>>        if (data) {
>>>> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>>>>        if (!data)
>>>>            goto err;
>>>>    -    if (dev->of_node) {
>>>> -        if (xen_dt_grant_init_backend_domid(dev, data))
>>>> +    np = xen_dt_get_node(dev);
>>>> +    if (np) {
>>>> +        int ret;
>>>> +
>>>> +        ret = xen_dt_grant_init_backend_domid(dev, data);
>>>> +        of_node_put(np);
>>>> +        if (ret)
>>>>                goto err;
>>>>        } else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>>>>            dev_info(dev, "Using dom0 as backend\n");
>>>> -- 
>>>> 2.25.1
>>>>
>>>
>>

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 08:31:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 08:31:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426288.674620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQxJ-0000o7-6C; Thu, 20 Oct 2022 08:31:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426288.674620; Thu, 20 Oct 2022 08:31:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olQxJ-0000o0-3I; Thu, 20 Oct 2022 08:31:09 +0000
Received: by outflank-mailman (input) for mailman id 426288;
 Thu, 20 Oct 2022 08:31:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olQxH-0000nu-BX
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 08:31:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olQxH-0002gQ-3l; Thu, 20 Oct 2022 08:31:07 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.85.39.71])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olQxG-0007YW-TE; Thu, 20 Oct 2022 08:31:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jvqPFdVSuH7U+4G6vXCwKN0osyDEPAsFd6qojsAy05Y=; b=fbURFBPjJeFWIGQTCq1Y46j89t
	yljmdPpcgV5/riPWQe8gj48Dmnl8Ui+21X0T8sDMDV0uK0gAuLjBQ2bVZSLTmxyvuqERjq5YDPbfg
	KDrj5i+2JAb/mmzq+k8hUsuQIPgen404NOOOc79C7R8kLo/NpfVwtXjc+7aC0UjS7/kQ=;
Message-ID: <910e5b7a-da5b-d7c9-1236-faa000ed4f5c@xen.org>
Date: Thu, 20 Oct 2022 09:31:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in
 p2m_init()
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>
 <20221018142346.52272-3-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221018142346.52272-3-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 18/10/2022 15:23, Henry Wang wrote:
> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
> when the domain is created. Considering the worst case of page tables
> which requires 6 P2M pages as the two pages will be consecutive but not
> necessarily in the same L3 page table and keep a buffer, populate 16
> pages as the default value to the P2M pages pool in p2m_init() at the
> domain creation stage to satisfy the GICv2 requirement. For GICv3, the
> above-mentioned P2M mapping is not necessary, but since the allocated
> 16 pages here would not be lost, hence populate these pages
> unconditionally.
> 
> With the default 16 P2M pages populated, there would be a case that
> failures would happen in the domain creation with P2M pages already in
> use. To properly free the P2M for this case, firstly support the
> optionally preemption of p2m_teardown(), then call p2m_teardown() and
> p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
> As non-preemptive p2m_teardown() should only return 0, use a
> BUG_ON to confirm that.
> 
> Since p2m_final_teardown() is called either after
> domain_relinquish_resources() where relinquish_p2m_mapping() has been
> called, or from failure path of domain_create()/arch_domain_create()
> where mappings that require p2m_put_l3_page() should never be created,
> relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
> in-code comments to refer this.
> 
> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

I will commit it shortly. Regarding the backports, I will wait for a 
push in to staging/master before doing them.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 08:44:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 08:44:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426299.674638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olRAJ-0002SU-FK; Thu, 20 Oct 2022 08:44:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426299.674638; Thu, 20 Oct 2022 08:44:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olRAJ-0002SN-CX; Thu, 20 Oct 2022 08:44:35 +0000
Received: by outflank-mailman (input) for mailman id 426299;
 Thu, 20 Oct 2022 08:44:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olRAI-0002SB-A9; Thu, 20 Oct 2022 08:44:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olRAI-0002uc-7b; Thu, 20 Oct 2022 08:44:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olRAH-0007Ix-Tv; Thu, 20 Oct 2022 08:44:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olRAH-0007ig-TU; Thu, 20 Oct 2022 08:44:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Xi0ukxKr4HPFL7cobwlq3sWVX4pPAhlPuebUJaxAi8Q=; b=qJKClpy4ccEkr8Ws88p+n+Zg1E
	TIne2mPV82o9+5Tk7/7DLYQlkiifXG4ZlXJq7+5Qfjt3DqPjG3GISrL7N0jwx2LKWHEcvRxLkKEa7
	i1DCrZCDPCzauBnfQD7aN94vb0hp4XbADMS7FcHVI9kwXLOLi4pX0YLj76Nr6nx1F9Y4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174106-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174106: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 08:44:33 +0000

flight 174106 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174106/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd   12 debian-di-install fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start   fail in 173935 REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start  fail in 173935 REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174106
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start    fail in 173935 REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   65 days
Failing since        173495  2022-10-11 14:08:01 Z    8 days    9 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    7 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:16:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:16:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426291.674660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olReo-00067W-8N; Thu, 20 Oct 2022 09:16:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426291.674660; Thu, 20 Oct 2022 09:16:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olReo-00067P-4f; Thu, 20 Oct 2022 09:16:06 +0000
Received: by outflank-mailman (input) for mailman id 426291;
 Thu, 20 Oct 2022 08:31:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=374O=2V=baylibre.com=mkorpershoek@srs-se1.protection.inumbo.net>)
 id 1olQxl-0001Av-N1
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 08:31:37 +0000
Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com
 [2a00:1450:4864:20::32b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9c60af8a-5051-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 10:31:36 +0200 (CEST)
Received: by mail-wm1-x32b.google.com with SMTP id
 c7-20020a05600c0ac700b003c6cad86f38so1760988wmr.2
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 01:31:36 -0700 (PDT)
Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id
 j28-20020a5d6e5c000000b0022cd27bc8c1sm19246814wrz.9.2022.10.20.01.31.35
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 20 Oct 2022 01:31:35 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c60af8a-5051-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=baylibre-com.20210112.gappssmtp.com; s=20210112;
        h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=/hCpDbVRoc+q/9gSPADK7PRRzF3tzQ7+LRZVH7HnjY8=;
        b=ZOwrGT8YlcyuCniv3v2gcTGYsyOsF1bRQP+5/n5cJtEfVLBTSwrkPRnwTHYdXH5AS4
         GpbQhf/EJDFhESbVNKeMcOA4AP/2TpsnqAwRkh1zuw8DPcNFNt3I1DKvWc8OhxL47HyO
         94eUlug5J2DmCBN69I9GYPdf+CiQJEmygXdjpETIGeowjOre0R79sv7c1Q9RQ0aeSgjA
         mt/1gthUycDV4pJjcXRfNC8PgwaWu2zZ3S9r53z1oORZ2tRITN3YHmhzLqhKj86MHQ3y
         7h/s9aWZfmFMX5F4eVOhSoMD5mrH13LUCX+GXuMWABU1wXjzGcvvXu+zda+XvTRoiu9v
         naog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=/hCpDbVRoc+q/9gSPADK7PRRzF3tzQ7+LRZVH7HnjY8=;
        b=n6hiaJbyr8/DJPy9msjR/IIHOkLszMbgLUgBQ3/eOVHDF8YVbPhDSRfM0X/iTqolth
         72ZoutRz332u51Ae7x4tnyNptsf7GGuSfhBdJS9JZC+FLCCTiaV9A5zJnUGTDd7juLXI
         lBv30vX1AQiU+53icqrAovEXVA8F/jDHRNsBPDD9ptwELx4IR08UL/FsGzcAmOur5sgk
         JtAYpxdtAn8Z6d0mKcB4zH90jB6pGDAENAcWq0I7l6oKRs/NT0fKnvUZWQ8LlzXsWlJx
         JvaZYT646k8YUEkUmqo3fsXhhE6ZV4aopYPZ9WkAA8S7Uf023li1AVWaC2VYEy5RCe5/
         7/TQ==
X-Gm-Message-State: ACrzQf3k0F+dK7QqevNq2BLXT3sEwpdDPcindXjZW2RJvk15CzgVUB8m
	C0MWT4P2sbRqq/9V+AyhRSTSrQ==
X-Google-Smtp-Source: AMsMyM6iQl1yh/y0HEH9uS1CZVI3KrJmHjy5uCOsdpFu/YF84jxhh6xVVSE8CZ2CG6O57/gkvjT9Lg==
X-Received: by 2002:a05:600c:a08:b0:3bc:eb4c:b90 with SMTP id z8-20020a05600c0a0800b003bceb4c0b90mr8488441wmp.184.1666254696083;
        Thu, 20 Oct 2022 01:31:36 -0700 (PDT)
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Jason Andryuk <jandryuk@gmail.com>, linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Jason Andryuk <jandryuk@gmail.com>,
 Phillip Susi <phill@thesusis.net>, stable@vger.kernel.org, Dmitry Torokhov
 <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias
In-Reply-To: <20221019201458.21803-1-jandryuk@gmail.com>
References: <20221019201458.21803-1-jandryuk@gmail.com>
Date: Thu, 20 Oct 2022 10:31:34 +0200
Message-ID: <87zgdq99qx.fsf@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Oct 19, 2022 at 16:14, Jason Andryuk <jandryuk@gmail.com> wrote:

> xen kbdfront registers itself as being able to deliver *any* key since
> it doesn't know what keys the backend may produce.
>
> Unfortunately, the generated modalias gets too large and uevent creation
> fails with -ENOMEM.
>
> This can lead to gdm not using the keyboard since there is no seat
> associated [1] and the debian installer crashing [2].
>
> Trim the ranges of key capabilities by removing some BTN_* ranges.
> While doing this, some neighboring undefined ranges are removed to trim
> it further.
>
> This removes:
> BTN_DPAD_UP(0x220)..BTN_DPAD_RIGHT(0x223)
> Empty space 0x224..0x229
>
> Emtpy space 0x2bd..0x2bf
> BTN_TRIGGER_HAPPY(0x2c0)..BTN_TRIGGER_HAPPY40(0x2e7)
> Empty space 0x2e8..0x2ff
>
> The modalias shrinks from 2082 to 1754 bytes.
>
> [1] https://github.com/systemd/systemd/issues/22944
> [2] https://lore.kernel.org/xen-devel/87o8dw52jc.fsf@vps.thesusis.net/T/
>
> Cc: Phillip Susi <phill@thesusis.net>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  drivers/input/misc/xen-kbdfront.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 8d8ebdc2039b..23f37211be78 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -256,7 +256,14 @@ static int xenkbd_probe(struct xenbus_device *dev,
>  		__set_bit(EV_KEY, kbd->evbit);
>  		for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
>  			__set_bit(i, kbd->keybit);
> -		for (i = KEY_OK; i < KEY_MAX; i++)
> +		/* In theory we want to go KEY_OK..KEY_MAX, but that grows the
> +		 * modalias line too long.  KEY_KBD_LCD_MENU5 is the last
> +		 * defined non-button key. There is a gap of buttons from
> +		 * BTN_DPAD_UP..BTN_DPAD_RIGHT and KEY_ALS_TOGGLE is the next
> +		 * defined. */
> +		for (i = KEY_OK; i < BTN_DPAD_UP; i++)
> +			__set_bit(i, kbd->keybit);
> +		for (i = KEY_ALS_TOGGLE; i <= KEY_KBD_LCD_MENU5; i++)
>  			__set_bit(i, kbd->keybit);
>  
>  		ret = input_register_device(kbd);
> -- 
> 2.37.3


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426329.674694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS96-0001P7-0b; Thu, 20 Oct 2022 09:47:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426329.674694; Thu, 20 Oct 2022 09:47:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS95-0001P0-Tr; Thu, 20 Oct 2022 09:47:23 +0000
Received: by outflank-mailman (input) for mailman id 426329;
 Thu, 20 Oct 2022 09:47:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS94-0001OM-7T
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:22 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2fb0b786-505c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:47:20 +0200 (CEST)
Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:14 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Thu, 20 Oct
 2022 09:47:12 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fb0b786-505c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259240;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=k+2bCajRjmdDUI5qrAEiOOQGkBMftTHfCURovph7k1o=;
  b=LnxzfAGxx1riSzwyFeeHy3USPtqi7xDTZw8jr/BBRqrlXkqmQsG0p+Jg
   TPTygZCZtH9BtyfkpqxnY8Ln+/yHX4atutAo9VHYVz4OKMdI30nP7F4X/
   APgjYJvEaSxNwwEzMavaBGCluIl/UTnri1tAlRe6AI44Ga0me4u7Dq1Rd
   o=;
X-IronPort-RemoteIP: 104.47.56.168
X-IronPort-MID: 82251983
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:GB87FKt5VlT2QyFHe7keYX5qM+fnVFhfMUV32f8akzHdYApBsoF/q
 tZmKTqPPKrZamChL90gaYXk800FvZbSyIM1SARpqSxkRHxD+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPaoT5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklE5
 8M/NwofSCuMuPqw/oDkasRQt+A8eZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUvgNABM/KMEjCObd9SkUuC4
 HrP4kzyAw0ANczZwj2Amp6prr+Vx36iCdJJfFG+3vBFgn3Q13wJMTw5UlKAs/WhyUGHUc0Kf
 iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZebPQ2uclwQiYlv
 mJlhPvsDD1r9baSEHSU8+7NqSvoYHZFa2gfeSUDUA0JpcH5p50+hQ7OSdAlF7OpitryGnf7x
 DXiQDUCuoj/RPUjj82TlW0rSRr1znQVZmbZPjnqY18=
IronPort-HdrOrdr: A9a23:O0cap6GA4b6rjBAGpLqFc5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79
 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+tOKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+zLzGomjMlFx9fy7Yr9m
 bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfgWK1RH5m5+BwlquCm71gn1P
 HKvhcbJsx2r0jce2mkyCGdrjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MG40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIZLH45JlO11GkbKp
 guMCmFj8wmMW9yLkqp9FWH+ebcEUjaRXy9Mws/Us/86UkloJk29Tpb+CUlpAZxyHsMceg72w
 36CNUYqFg3dL5xUUtcPpZ0fSLlMB27fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="82251983"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AkLc7JC6jujAjdgfgOurSt+BWDRq/Y/fb8lCwrKfBHPNEpLkZADGD/5vfcFlS4KEpTLYuxFLY+DzKv8EFQxw/+akNhIktN4Yo9VMh+WnrIPS7W6CBZb5o5w24Lw6WwpdnYxPtAq2ywRBgkjZtA85Fm+kIwcyW4+akqepCm9YMH3p6cQ2eeJSN8M9lENT/wBnp4TWVcHG1DqWwAubzAzq73bzqmwZFXM/GgXxRx/5T/cTrRbuc35vWiiZsDy7EQUY9qD46ROUe7Kr8uJDJAWt6fN3OUtsM7XFQ1MtLwHzua9UFbhUsmfUsPgtRX6JU+JTjFDR0WQl6DFntWEoYk3D0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p+XSJ9rQmd5UfBXKliHWuNtxPvSFy2AGFgwTxJdAwX0=;
 b=JnSgcLVh1Q2d4kzwxlN6yMfOxkkEpP6bvdkPJSMWEby3y4fhlCLcfDP0Eo5ZKP2CrfXLRK9aQVrh/+X0RpMAN27BzKN2uAEbNxjcUC7+UAyE72+m1eLTJUyjWHE3o36mJt9qbFNv6xxzLtPIHc+GsEpkyJcx4vACZ2vs0lbqv0afy6KW8tI2CuK0eTyRb7t4tZPEXGcXNwFqGh4QaaB7lpRHsT9AvONJZshSsxhV/6c8C73UgIbhJt5S5aWmX7abEv4BSjt5NbMJt7GOmhJQY4I02/8XQ/YWEo3KZ4sFqantzAcd+b+5Wm5Fb9OBFSnfso+w6vdpPxzFDI2K5wgxBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p+XSJ9rQmd5UfBXKliHWuNtxPvSFy2AGFgwTxJdAwX0=;
 b=VuJ9L4nEyskamt3uqgjoeN/6kAVKzENa+5G8PcixXa5LT0PPULI+wn8L6tVuo3iZYruznxFg3iOkQQz56bYMvnC1Rs9qDdIgMZ3d54vw6b/A3JFLUZhXTCVZ6Qn1rFrdYeHX0dG7qtZ51urOoe5a6U8FRlbII0t9vRQYhXta0Mw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define
Date: Thu, 20 Oct 2022 11:46:44 +0200
Message-Id: <20221020094649.28667-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0048.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::36)
 To SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: 5094f796-e799-4b1f-b0c4-08dab2801041
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fWyr9+hYLYclK/mh5Crgy7OsQP9xMVHe3gV2guGn8GaAXgheKq8rB2tChqqn2IkC3RZI86PLG5WOOV9Cl7Ge9KR1pCA5CGo48RjkpVv6BjbpHRZlBKENeGroaI4vzkdR4afinJn/gWJko7fAcwS1zpBjNIM/7VvbngkThNxGomJYCy62L3vCQrRHds36NxI1i2vA+yFAZrFW3DV4PdIdg8DXRoUn+mGrSLbV46AVh/x8SHKhpou5djLm/eQPcgNA07puUJ0ZNcV3KEyh1hT7U7bupserpT8dK91jRPkPbQednhITIVhyT3rx7mGh3Y57BDBIlQuy/Q8HLGW7ZgjAVP1ArrgTYDsEpNtVkw/HfbX3iOIQlrrEm3+c7CEf/3rRArIVQ4aERKSTf/nJy6aXtFPNVnrnA907kDS3NF5hI//Zw7yN0iXpBTrFqGCsILHyGHNKqNUnzqOJX6spO5JcMNOs5NKhGx52epGKuGSocjrg+EWFOD2BZBScnCHNSRzTGUb93ZYO4P1q9Ha5uYbshMolSdW5q9Pb39iJAKU7MzWEmRB+1TinXoR2AVBzROHr0gc6hmiT34l3/6+Z2QMfM1mW2Xj3JgMBwdFbM+Ua3LwQEBTwF47bZNs1gHZ28PCZT2pFb31ZAUmmYuNjNvcDc18hWOzxGqXxiwHE+d/mPEbciUhqs3ImV0zbNnmcDOuoKInSusv56DhFWAgXchOJ8A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(316002)(54906003)(6916009)(6506007)(186003)(36756003)(2906002)(41300700001)(1076003)(2616005)(4744005)(6512007)(5660300002)(83380400001)(8936002)(26005)(6666004)(8676002)(86362001)(66946007)(66556008)(66476007)(4326008)(107886003)(38100700002)(82960400001)(478600001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3I4anpsMVZDVlh2YTJFU0FJZlhtbzNPanZ2NUdRNHdwZjVVOEJtZkh5VTlM?=
 =?utf-8?B?VUdJMmN2NmtRck1mUmdyNDNLSjFKdWQ4dTBJZExRZTRMS1MwYlo3MlhrQ1ZT?=
 =?utf-8?B?NUlWczdncXYzcXhiZmJhU1AwQlFzOEVVaWFJbnBmdTZWSnNVbkhLTlc4amNV?=
 =?utf-8?B?WEpZK1FiVytUY3FIS3QvRk1lempsd1hqOHVRbW9nNlZCU3k3Ykc0eThZR2Y0?=
 =?utf-8?B?ekZYblkxMW9vU3F4bXJwNGo0VnAzc0pRYjdTdmkxbWJuMzViNUdDZGZxU1U0?=
 =?utf-8?B?Qng2YnRKd2pwd2NVTjVYNWhLdkdBeWYxZnNEdHN3M1lKUlpUQTROUzJnTUpD?=
 =?utf-8?B?THVVM2xnOWhZS0JFQnJNbWgvem1WVVJUeWtWTVZ2dk1Qa3hNU1hmOU9HTHBS?=
 =?utf-8?B?d1RZdFpNVG4xWEtMcW9iMHYwaktDUVdxV2xFdDQvTDZEOXRmRk02ZnJIZ0Q2?=
 =?utf-8?B?R3lQZlZZb2cwMlVGR1pvMVRBeFBLVmUvbkRhaWdKOFhybXNjNG91V0xlQkhy?=
 =?utf-8?B?N0ppNzRleitPdkNPYXQxUGp0OFpWaDBQa1M0QXNjL1FHdWxBR0hHRDI4NXZF?=
 =?utf-8?B?eUpQM2U4WUI3THlJSUU3NEk4elk0NEViL0dhWFVybHFiZ1pndGpUK0J2U21D?=
 =?utf-8?B?SVhackxOU2YxdXo3MjhRNXo3SENFTzRxNjV6S2J5amFFMmQ5SGw2Q0ROV205?=
 =?utf-8?B?SmMrYXh3RlhveWJ3a29OSjNrckR4clQ4cDM0STZLQ2c0RUVoZ3NoOE5neFhk?=
 =?utf-8?B?NE8wTHZaRWMzcVk0ZEIrSmRmUURqclJCZlhJY3d3dHNFQzdWMEVrR09yYnlj?=
 =?utf-8?B?YjVkRW9DWHZJWXhNWW5EN2NkOG5Rd0M5M25oNEJRb0pSdDJadEdRZkRlZzh1?=
 =?utf-8?B?Z1JQeUQ3a2Q3VkhXSVVkVDc3a25hdEpOZXVGK1N3TUZWSWR6ZE9UY3JUY05G?=
 =?utf-8?B?YXRaMEd1UHRXWlhWYTNHaWpIc3V1clEzekRDOXNXRG8ySWRKNW95c3JQQnkz?=
 =?utf-8?B?TC9qa3AxNkY5UVA5TDhNUVZobU9Uek5uUkJ5Z013SU1ONFRPZkZlSXlySFdp?=
 =?utf-8?B?L3dzRkFmTFRzbjJVNEJ6WGtId2YxVEt3NFFxbWhBMHR6bW42djgxUWlXTDBG?=
 =?utf-8?B?YzNQYmx4MnpEeDJsaFZUOWVjeUptNS9jWWFPTURDak4yRmdvSkZIbk02K2VC?=
 =?utf-8?B?cy9CamlBdlYvMVY0RStpaFMyU1AreG9vNWIwRHY1Q09wUnRlM2F2bXp1aUI0?=
 =?utf-8?B?eEhzZzFsNWlZZWNodzFUenJiaytZOGNwbmV0MVRzYXp5Z0lNMWxDaTJ1L2R5?=
 =?utf-8?B?N1RhaGhST2dUQndKdnpkTGxML0NpT2NJRmpma3R1dTErUUVreVNTZGxuMlFI?=
 =?utf-8?B?MUh3Skl4ZlU3eUYrWlIwVDduMWg3THdNSk1ucWZXK2QvNGZsK2ZXbS9RNzcr?=
 =?utf-8?B?UWhVRUJVTndzcVNmTllwalo1Ulk0YWZYZW5TOURoYjlTTVB5VXpqNEtaR1hM?=
 =?utf-8?B?MWtkbk9HaG5ERkw2UzR6Yi9Pa0pnVi9oNWZCWkE2VDhEVG9NUVZIczNUZ0pi?=
 =?utf-8?B?eEU4Rk8wdWxZc3hQL0w2N2kzVDlxbWlJRjRvNnFMWjYvMERKbzBpS0Y4bGRG?=
 =?utf-8?B?RThDSEwzTlhoVVVnRVFmazMzOU14bVBlejJiSmN5Nkg5NFdVT3dXMFU1c0lX?=
 =?utf-8?B?L1l4N2Z0RXA5TWtyRlBCY3liOFNYQmZ6NWVUdFpHUUV6VjdVUGNRa0NGT09o?=
 =?utf-8?B?QkFRVDRWZWRzRjFwT2RWcmNDOWVJamxyUWNra3dXNVRPc1k5Q0tTRHR5ck5n?=
 =?utf-8?B?ajhtdVJPSXBHRzRUY24zbXZVY1oxKzFVdkYxTHBsTHVlZU1aVEQzNzdPL1kz?=
 =?utf-8?B?YWJVQnhGNkdZSkZJdGxuQnNjL256VnlTVC9UL0t3MUo0OVFSUUxiSWVxdlph?=
 =?utf-8?B?UndIbkdUL1FhQ0x0L1E2blROT1lmY3dUM1lHUkU4ZnloeEgraGFqMEttYjYz?=
 =?utf-8?B?ZFBZRitpck9yOHhQY201QnN1d0Z3VUFRSHAvblZPVzVaN1NKY2VCSmdVZHRW?=
 =?utf-8?B?ck1YeWNBUnBjaWpCL0VHaWN5Sm0zb05Valg0SXB3QU5zbXBRVjF3T2Roa0hw?=
 =?utf-8?Q?E/XUJNah1rAeUAjq49/hip0AH?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5094f796-e799-4b1f-b0c4-08dab2801041
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:12.5598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zNrWa3syDppKynSHPDi47cp01up5rWLVhFwbjZtfjn7QmYftG07CeO4dzE4GYvYLjC5k+qyU4TVHt7NvtB5hIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

Some vpci functions got the cfcheck attribute added, but that's not
defined in the user-space test harness, so add a dummy define in order
for the harness to build.

Fixes: 4ed7d5525f ('xen/vpci: CFI hardening')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/tests/vpci/emul.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h
index 2e1d3057c9..386b15eb86 100644
--- a/tools/tests/vpci/emul.h
+++ b/tools/tests/vpci/emul.h
@@ -37,6 +37,7 @@
 #define prefetch(x) __builtin_prefetch(x)
 #define ASSERT(x) assert(x)
 #define __must_check __attribute__((__warn_unused_result__))
+#define cf_check
 
 #include "list.h"
 
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426331.674716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9A-0001xz-Mx; Thu, 20 Oct 2022 09:47:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426331.674716; Thu, 20 Oct 2022 09:47:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9A-0001xq-Js; Thu, 20 Oct 2022 09:47:28 +0000
Received: by outflank-mailman (input) for mailman id 426331;
 Thu, 20 Oct 2022 09:47:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS99-0001OM-A5
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:27 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 33ca61dd-505c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:47:25 +0200 (CEST)
Received: from mail-sn1anam02lp2049.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:25 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Thu, 20 Oct
 2022 09:47:23 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33ca61dd-505c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259245;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=QaWL9ZH+AlYfB57gC9TTJMbJfyVyxNkJBtusLwT0/kY=;
  b=G7O6tOvScYEECQCUwIalDplOWJOISIN3OEjBLLIdmXqgcCYQQDCbYAF4
   bfzzqkG2ORI6vLIDV1fQbWrWI87tD9HhwdJXC07WdyBBPWlmIQlgWH1/L
   PSH1vYeKXETYKP+a4sZyH+4CvKdvmZMiJUA4N2RbY+/WNZgBgYAc+v+6+
   M=;
X-IronPort-RemoteIP: 104.47.57.49
X-IronPort-MID: 83565866
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:lkx/z6JoCmKKfgjdFE+Rq5QlxSXFcZb7ZxGr2PjKsXjdYENS3mQGy
 2JJXGuDMquNZmH9eopwbY208R4AucTdnNZnSwRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FaYZ/vkpHzx3z
 qE/BDZXYDKel8e3zL3uH4GAhux7RCXqFKU2nyk6iAr/VLMhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T+ftfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPkmfbryLy2IcjmwukaNpPGr7/7sVamUGcxUkcKBYyCAG09KzRZkmWHog3x
 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xA2EFSntaboUvssYzHWYuz
 gXRw4KvAiFzurqIT37b7q2TsT65JSkSKykFeDMASgwGpdLkpenfky7yczqqK4bt5vWdJN066
 2niQPQW71nLsfM26g==
IronPort-HdrOrdr: A9a23:POP50KlD7TikpDLkIrQHCH8EMgXpDfO3imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhR4tKPTOWw1dASbsP0WKM+UyFJ8STzI5gPO
 JbAtFD4b7LfCdHZLjBkW6F+r8bqbHokZxAx92ut0uFJTsaF52IhD0JbzpzfHcGJzWvUvECZe
 ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d
 FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp
 T525RT5c9zp/AtHNNA7Z86MK2K40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd
 L6IRhliVI=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83565866"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XFLiqwF97r76+iujKXTPn0bxpXq49FfqTelivfw7CL2t22ZS3MPPuxK7YAA+lHSUFjb+jM9ZZWqvpBvaHhnj3wTZFTp2BjkGTfugqYVXzj0tm8pXGUtnng9My4a1/rQN/uql2boYFVz71WSufGGW9cHtE6r9jFkEfW0xvsDpAx25KrcOMERNTGfs9lzhgOR6j6U2Y+nbtrufeaEhV96HSkcyiUoohf/nOnN7cO8OOYM+u8Qda/O8aOSfuRo+A2BypKN21UMIwK20vJM2HhdZ4shznSaHCX7H8sUId0oapvhh8f0pK+PPZAPt+qtijC9UlTyRzwTg0u/STPp2KNZsiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SYCSSJNqrhzg2jhEg2bewEOFbQS4tBVFIatzBZKv8Rw=;
 b=XPioA4wE6GNz6TDoJIP4UU1vZay1gIhwQi20bph8EaUHIggHloBrf4mbUZ0TsMHYObcRYj8KSsn5HMSXvPviNnuQqgSK592KO1YCPQnIK613PCFjRdCgOz/DUKDWWs3C1vcNmW/30vxJxYO4jJmiIL7Llfp63QAxglCv0BrX4ZdyYdfkhRJ8VAJBTsY2ObWwEjtx+Xh8lBxoBmki0KQr5V8BBmTsgDM4YROdY0L5DVPxolVtV+E55vyFHTsiMUI844F28fYv4xFTci2ZIyDZgTAgGNvwfmLnuVXrhIwnOIt2ilMdJGAoUFTXVSZWTgzLlX/C0gSsKUGqSWovirpHtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SYCSSJNqrhzg2jhEg2bewEOFbQS4tBVFIatzBZKv8Rw=;
 b=l+DgvREwbBU6/NpEIlRSDA2L9Wt9P6JbtL3BMjba9Dxa2YLmycWyDYW6Ep3EWup113p5imaRyjWjBQTh05yJYJMV1Buz+lsBcWys+zDRnWLvU6EKTO824klAGEOzWbedj9YJe/tRXt5WeGkBfEtGqqm7ayMG9swxuJW54P7DPpQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH for-4.17 3/6] vpci: don't assume that vpci per-device data exists unconditionally
Date: Thu, 20 Oct 2022 11:46:46 +0200
Message-Id: <20221020094649.28667-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0670.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:351::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: 11ec937f-f5d4-4542-000a-08dab2801680
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tv/SyzQeRxu/R2Ber9AaOVw41H8SEKQk4zMR3auy+FDhy3HTxycFwa5cRP9kGzPsFUs2hQcyMUqnn41ZUvo48un1Lh5BpdQwvmPm8lapLgA6HGP5syVr0lzm9u2Ibf6nN9Bj6gYQihhwfz435uPvhnEcWPlDxu+4q1z4BFff/C22znLVqOWi41Chbnss9FGiNlB+g58Y5spuLmaVIlfX68Zz0NItD/c53sZ3D1uQtkEY2GOxhrU9ZQlHkHs8db2N2pK2sFcxkacyZDU6d8+fkiIGriMU82Kv+CPBTa3FFtJ5vJzvCFJx2Bz3tSxXOuKNb4R1ht8n2Un2PP/1DkF9Ta2Fg58m1q6KuHr/rdFGHozcs/uJLnzmISZGsONFGqUyOwNRq7586Iv2/iRIBmkyy42Bya3qst7JWKqTSPUUdoLZGndDbO23HghplTNaG7zdtjkT/S9cgXxjTX48qGzuvzLBMj9fgv1GCVit6RrBGrbZugS9RlhzwNIDfLXlqAsiIkva5BCW3WzoLrkNKzwdQNDp4csnZ2RV9oPH/RQcLR779ij6jVHDdrN1wLoGHTe7jhQqWRzlbOlbQM7pX+xGc2YkuoR0Tp5a9/XFQvm85gj2iqnM+NU46lV7mOQ2sY+Fb5hadYyKo73Q2Yjnzk6zPd7UN5NiFBjOe5GCSkrUWmlbCloHSi8HF1uEMglmiha53l8MstDoJ+pe7a26/mMcYw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(316002)(6916009)(6506007)(186003)(36756003)(2906002)(41300700001)(1076003)(2616005)(6512007)(5660300002)(83380400001)(8936002)(26005)(6666004)(8676002)(86362001)(66946007)(66556008)(66476007)(4326008)(107886003)(38100700002)(82960400001)(478600001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UE8yYWkvbGdoM0NtcERYVmdjN3JScWQ0citlQ0NJNHIzVGNJckxQQXJIYVNV?=
 =?utf-8?B?RjhmVHFpNnl0M3h0VE42TG1XSHZ5a2NHclpEbEJvanZucVU4bnVzWGJZaGd6?=
 =?utf-8?B?SHZOZnY3SE5oZWZKT3MrT043R0IzZlI3OGZqR1BQOXZDWjdSSUVLZmltRFdM?=
 =?utf-8?B?Nm1MTm9FNUxQSUx6a1VLTW52QUpOd3IvKzRHNWNWc0dlZDlKeGZ1MURGRXYx?=
 =?utf-8?B?bVVUb1ZqSldzUGhZNjR4VGFVMm9SWTVEeno0anI5MXphcmhlZzFaTjdzMVp6?=
 =?utf-8?B?a0xlc05HN3gxdktGb1J1WjV4UGNoL2ZkZEJpRnFUaEo4VjhMRWdnRm83QXZT?=
 =?utf-8?B?a1E5bU1Hd0crUXY2WFFDT3F1Y0Y3N1ZWWWlqVis2amtWWmNtbi9qaXphMnBE?=
 =?utf-8?B?MWlnS1Q4bnlmbzNHU1JSTGcrY2IwYVFuaFBZSVYzbkRrSmJpMmY0Y1A3Q0NB?=
 =?utf-8?B?K0NHekI1RmkyYjdHa3g2dWltWTR0RnFsdm00N0huUm1QL3ZZdnR1Tk0rNkUv?=
 =?utf-8?B?Z2ZhOFVsVm9SSnZZTEh5RWF2ZzM1cTAyVVZpeGJ0aDdoK29Cb29uMzBEcHZm?=
 =?utf-8?B?K1EwQkc4QkhKZTdhN3hKdkNvMTlxQUtkODZPb05vRFlkRWVGVjZvWlNwcXUr?=
 =?utf-8?B?NW56TG5XWWR0V05TbkJ6M2JlMTQwVnVXWm5NRFp1M0xOcHhZL0JKenFGaUVV?=
 =?utf-8?B?TXBEYXdna1pQanNLMXJLTDNpRmNMTWhKQWIrankrZGJwcE1iTDl5YXVMOUtS?=
 =?utf-8?B?eWtPQnM2V0d2NVM0dWV2YSs3QmpRWE90REdVa3BubzNPZTBEYjJobVVqRWdo?=
 =?utf-8?B?VTZjWGo4TnpPaGs1bXVTZmRUVW1IK0VibUFWUmMyeTZTR0svUmkxVFJCaEJE?=
 =?utf-8?B?TXhMM0N6S1NoSFJpR3Y2c2ZIRCtaRlBxQkQ1THQwSDFNelNtQjQvSUZkUklK?=
 =?utf-8?B?OGNSZzNDL2tHNThyVjRSUG5kNDhIeU03RXRYY2dnTzRXZFU0dXg1UGlwcmpY?=
 =?utf-8?B?RnpLVmRlQkVJWC9oZHBmdWNyNUE5Ujl6S1lqSDVVNnFyWlFTem00L3pDVWNq?=
 =?utf-8?B?NGpFc3JvR1ZJODNyb0pFMWFNQXVKZ2s1Y1lTNUxUTWhpZGFZNzlGRGNSdEV6?=
 =?utf-8?B?SVprOWdXdk5lSmVEWi9rNFBOSzJSOFN0cTNHR1BuTHpUdXJYYW9qQTlHa3BL?=
 =?utf-8?B?eFkyZit0T0dRRkpTU283M3phRUNpTHd4WC9mYWJrM3lYRk5GUmJTZFQvaXgw?=
 =?utf-8?B?U2NvL1dBV1czLzFsNms3UVJHVVUwSUVHVUJTMDRRZ1hBWFY5cm13Rk0rdjFG?=
 =?utf-8?B?d29na3B0S1NvUUh1ZmlLbURDdDJqMkZwakNFOExETGpvZVRVUnBVUFFGZ3hw?=
 =?utf-8?B?WXpYYXlqOUd3SDkzMUpVNnNXQ29uNmNZZ3lQTXFIeSt5czU3MGdCTTRGU0tl?=
 =?utf-8?B?WDEvWUdzSUtzK28zMVNYK3VKZjFYT00xK0s4NFp3WUNBMnFDOWsyeUgxK2My?=
 =?utf-8?B?bkZiTDlUZGVIYjgxVmhGYUF6aTJDZ1FCZU1GVDFkSytKZ3VLYXprc3k1ZGZp?=
 =?utf-8?B?YkVzWThXU0cxc1h6ZUZHbVB2VThFSUZRQzAraGJiRSsxZUFybHlIRHF3NURS?=
 =?utf-8?B?UUkrR09CMm1ZdjJJM290WlhZYlJ3cmZ4dDBDdmtoYU9jd2ZienZ0V0JVSGd6?=
 =?utf-8?B?OUUvZGVYaGtGUDFxaDdjQ21zUVFqNzgxSUwxc09oNEcyWTBNQkFYVExMWnhZ?=
 =?utf-8?B?UDNzUXpKbGVocXBvbUJtTno3L2hqaUJBaWJCSWtxN1F2alJMYWRLNHpXMFJh?=
 =?utf-8?B?eFpFNWVYeHpUQm4rZnROSk9rYzhSNXU1QnlPY2VTZWFCTXJYbEJnTmpaeXJG?=
 =?utf-8?B?L3VVOEMwczBQTHJXSjg3ZkxaWG9pZll0YXJKQVVvUDlSVWJPY29HdXc2eldR?=
 =?utf-8?B?UzAweVBEZzNOcmNmR2ppTVdjLy9BeDlGNlVVQi9qSlI0RDBVcVpmQnRxTk1G?=
 =?utf-8?B?M2V5aS91VE42TXNrR25HSDVwQ05uN1JybG10OFluRXYwT2tFdU1sMmMyRzhU?=
 =?utf-8?B?V0FMenFUdDN1dzhIUXM4dzFtLytudng1Y2Vtb2Z6K0Q3WWJDckVlL2hpVHhu?=
 =?utf-8?Q?8Wa/oP3nvBYzpcUSrcKEzSbvc?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11ec937f-f5d4-4542-000a-08dab2801680
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:23.2047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nT9vngJV517BOFpx84wI3HHxwz44bQckXOk80yg56jFgVUC41PGWlkpe2hVpjg1lE0pogWX1PuZCWTz3nXB5yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

It's possible for a device to be assigned to a domain but have no
vpci structure if vpci_process_pending() failed and called
vpci_remove_device() as a result.  The unconditional accesses done by
vpci_{read,write}() and vpci_remove_device() to pdev->vpci would
then trigger a NULL pointer dereference.

Add checks for pdev->vpci presence in the affected functions.

Fixes: 9c244fdef7 ('vpci: add header handlers')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/vpci/vpci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 3467c0de86..647f7af679 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -37,7 +37,7 @@ extern vpci_register_init_t *const __end_vpci_array[];
 
 void vpci_remove_device(struct pci_dev *pdev)
 {
-    if ( !has_vpci(pdev->domain) )
+    if ( !has_vpci(pdev->domain) || !pdev->vpci )
         return;
 
     spin_lock(&pdev->vpci->lock);
@@ -326,7 +326,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 
     /* Find the PCI dev matching the address. */
     pdev = pci_get_pdev(d, sbdf);
-    if ( !pdev )
+    if ( !pdev || !pdev->vpci )
         return vpci_read_hw(sbdf, reg, size);
 
     spin_lock(&pdev->vpci->lock);
@@ -436,7 +436,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
      * Passthrough everything that's not trapped.
      */
     pdev = pci_get_pdev(d, sbdf);
-    if ( !pdev )
+    if ( !pdev || !pdev->vpci )
     {
         vpci_write_hw(sbdf, reg, size, data);
         return;
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426328.674683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS90-00019E-Ov; Thu, 20 Oct 2022 09:47:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426328.674683; Thu, 20 Oct 2022 09:47:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS90-000197-Lr; Thu, 20 Oct 2022 09:47:18 +0000
Received: by outflank-mailman (input) for mailman id 426328;
 Thu, 20 Oct 2022 09:47:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS8z-000191-Ph
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:17 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d053341-505c-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 11:47:15 +0200 (CEST)
Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:12 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Thu, 20 Oct
 2022 09:47:08 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d053341-505c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259235;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=sLE1jYGtVDN2iM2r1wkx0OY+wHqUvwNkuW/lzH9f3tA=;
  b=Ig3EFqPxTbJG2WJbHD6E1iK/s2UJyrgEyytLjzn86p3m2lxdJB9cki0W
   XYyfBWf1N0JfvqV1Nm38NeF2CBiiyZZRW23ALXnS9Mly9rnrR9MLz1hyO
   dlbekaSaY3gTq5QcUJrmoceWJzwLO9LUhtU+VJYEwN7GpRzH7utpF7oNm
   4=;
X-IronPort-RemoteIP: 104.47.56.171
X-IronPort-MID: 83161003
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AkV091aphk5asO6WNG+ftUaqpC7BeBgzWbkUOw?=
 =?us-ascii?q?fr8NTMMsldhBb0lAxOYCXWvSSMQ+8hVknGiFiWPDGKUnjHI174Syg+iHdmqm?=
 =?us-ascii?q?L1vGXYAEGT2FEbRijYA2jPw7qWV3YewoB1DdvFke2EZG6yNDDUiHLt9GQW2m?=
 =?us-ascii?q?Q/wci91Nupa1K2w/JwewC3X/LokLxurhaapOHarRRzE2PowLvkwe4JFwWwW7?=
 =?us-ascii?q?BBB+d2qGFYu5XwdbiOYVVgWs9CV0Woy+ZSsIWIWQG+mI4fAPH3+jTPk+LAOT?=
 =?us-ascii?q?j0c4gx8DcNtg+4P0A4X1jGEplxrMM4IeDdwgz1/gGdsoz3iS9TatrIeu1uG0?=
 =?us-ascii?q?enE9BeygA5CGAzO5Y0TKcSfLa+dERtLM3z7WuctlEaiiBGjfL/8RBHLCf0aY?=
 =?us-ascii?q?gXmuT/cf9y8wVfoBFNNzzGDQxV2Vt7I8jRfjRh7WEfhcTxaP/h12CanECTqD?=
 =?us-ascii?q?kdfkcjBkIe0hd9Ubjn2WK6PSIPwEtLklZSM3Cks+SZ8B4TBLsG1gFq3aBTDJ?=
 =?us-ascii?q?DgEenTOmc5L3NEF3uEtkoWlmNSFyZQ+6t/ioxbkwMy3vy/voq2djkKjzTkQc?=
 =?us-ascii?q?n6u05wxQtbWATZh8KoY50f5y7NQOn1GHo3Ojnxw5qsp/RDc2CrwH2lbtqOyp?=
 =?us-ascii?q?jmKBGrMFCoqYM5yGU8b16PP80pghgmWpn0MiPhYhrRDWD7Y7rzByyNhQQzhc?=
 =?us-ascii?q?UzQaNcdTxZlYwYZrOtRX7C6Fq7Pjwl8e1WzOV2Du3DmakEWPNDKOgq8DNXO4?=
 =?us-ascii?q?AMow3/rDQJ23gZZEGrI8eX689k/gT1+PrXBgOL5eHqekM+RENykRyvqmM1dq?=
 =?us-ascii?q?cTrXmscljn5gp0iRf1spFbMhrqQR+EIxa5Q574F9SNRFYGUeFwAsn9uglCWC?=
 =?us-ascii?q?QbZnAWpxA/SqwGmTT9HCtGbRMzZ6pcqZFYd/KHTQMwGvZT1NwgFUsAHiP0j7?=
 =?us-ascii?q?+H6t1qpcqncSOe5o4GxrGSL5KUsNhNJ5FwqTUu++GBkKcqTNOEOYIA1umoZi?=
 =?us-ascii?q?9qhnYVj8pUiV/INwU07oZchUMhMxhXwVazzn/0OUXmCDjGamuqwOt+KwwTS9?=
 =?us-ascii?q?xfq9tzYzB++EepFwaMLP6MGRNjBngLtBrbtOiMZEFHe+fe1QMyAGqQDNrHWC?=
 =?us-ascii?q?4c40u9CTW73g1crgwok2A9IEmFmVgAkOmJUpc5Aq80OJo//zOK1KUG/i4M4e?=
 =?us-ascii?q?kHz63Y0Js3pNXiABP6mGnel1jRQn8nmZLRHIH2IvrwNXL6XoSfQ7RlvmcngA?=
 =?us-ascii?q?TCUtzNMTWzR7zFkIljQytIH0qhl730Gu0OA8nUd7aw6GCF32nds09mG74Rli?=
 =?us-ascii?q?KhMpNTFqqm+52oIyaefFR5XXtg+AgH+EoIQLYHdu5CYLA+F5EbZXz3Z2FHMQ?=
 =?us-ascii?q?abzmVlQTS5dJNUeauQ5p2wHyQFNMvnRwCJfkuQhc3/CFQuts7MRhOO1yQJEW?=
 =?us-ascii?q?bMqmqaP9naeocQQbWpAaP7kUD6UYdU8mAJ1ySj/C3nn9P+WP1MmQHryAaDwQ?=
 =?us-ascii?q?RB+p3omeE1dVJlsoNwAHIFX0qPtrgdIYaG+W7nTTvOb12oJk9QFwSD5hNzBh?=
 =?us-ascii?q?wbuXDzQ0pR9+dA6yhuyhEyN5ux0SdQIT5+PQuSopWji5KgYeLCtFJnxaLAWW?=
 =?us-ascii?q?d+3ioCZyCA4Qh+RucEZ/dJ6Gfc3dzmAA8AiJOFFoxgBZbvjFXK9QcLi5cL5P?=
 =?us-ascii?q?29nu6tKziHM7JPjqu/FPGvBDLhRIL7g84gVBB6iE5CswXC0Q9DM5n/L9jrSs?=
 =?us-ascii?q?MYYWaKcg0bddGcw1cMNjSg9GytznNfSeGpZeODt3Kl1O2RSLIF3ZgeXL+VJ5?=
 =?us-ascii?q?gGwjzO/dKGV/A2nzUZN2W6vitKEDLF7/JVGwPdVYFfAG2iuSpbJOUo0UmA9f?=
 =?us-ascii?q?iKeS+xTbnVsHbrvrgsTaHXhuWPtvSzApFOlSBPVwAkeGYwHKzvkZN/Wl5V9v?=
 =?us-ascii?q?ZZMFuZS9o/1rwdP2pT5yIrYudntAW3fk0dNwBeFZJLWGn8SnnmCJlGiY1EhD?=
 =?us-ascii?q?kxsRTqckW+BXNh4JIbEaEHnl/750D6d9nMNDJoKpNdR2okfb/KyXKrXlntu2?=
 =?us-ascii?q?kJJ322ApN7uu/nvS3Gk8jregq/KOlbl2l6mdURkoKI+R6xwimTMg1MkP3O1P?=
 =?us-ascii?q?fc4At01Nd9BmWtOl+tX+RBoW1rDCdVg8oZ6yWhsA3Yd57PWWciG0o39posGT?=
 =?us-ascii?q?BCp3XSly6vgDOydo79xpbPsTU/UwV0fcU4BA7b4ZNUknJRPNEZ6FtfH+piUk?=
 =?us-ascii?q?DYDACDp4nR8Qnu4cu1E3sgj0CzLWHiFncLjM5fwY1jtyctkC6QL/MALtUG/Q?=
 =?us-ascii?q?fsawWHGXui3iHbv+HRXZg6JQQawz9y6s11elXG6UXVHoKFwrGnRbd+tpH233?=
 =?us-ascii?q?I8DLOvwp3lZ+3ApcwZhGz/PCVCJxTWS18LTxUBncMvpYTKu6aEaZ95BTR0qv?=
 =?us-ascii?q?oDN9PuBew10yjYMHSp1?=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83161003"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CeZO53io7Jnlay2MtWHmqzty8qQKBceh00qM5cAycGLPjTFwQf+e7xQx02kAWYc+lFpNz1UMUCLn1+AG9Lw+poJAvVTXeXdzDizW1x+8MhBxQmRVF8TNuJ1wVoPHUOgwUttM94+wdfSB3g8O2YpPe9G0Tabi+xsC4lP9KnYWyt0/AaeyL9ThBRvP7UPiCodit43xgkOF+BeB5m1lR4PkRxMbCsuGDVu92y0YLtXYM07IE2+15iIT8zARyqDaHIj4BTaDs3LCo/kgC70d6yUCmd7QANZJVHOX8lFn+xmGspotVbCD2DTxa0NLm5F89BC6q3qLSdILbOuBHiYGDL3fCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vutzteqHd/d6SfnamA+IPie5GbMRgN6EDUq+i7stlk8=;
 b=RjakwPuZW4E5plKZvpdeSUDVZPXogZBhdI1oWgNS8vINbnodrBcDxxWUyl0Qa/i5y2QWCFnD8mAA79zB43yfrmhETlFT2wisf2dWHtyJ3m1z+fj+tkyesFs+UzxM/NKPWIVnGIP0uV9sQ26K7rXhcABZdPPiX0HsZzrj031QGxb6hjX4mKGTwQzQOBcKb+/1ZXUnl08ZhVd1pJ2OZt3QgtHqFa/4j6oijnSxC0aAJGY94dmFRcXwcLqh6TXvXdG2vy6O7mCc2UBCPPHNR/BQ1QxxrLxAS9jLSIZQ37zqG/+DebqK0sEEwcUKoNP7dflXulKXs72ARgQj2BWV9L5w7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vutzteqHd/d6SfnamA+IPie5GbMRgN6EDUq+i7stlk8=;
 b=s4gYQlEMj4X6EfV/Gs9Ec7wlYZVHbl1lUQ4gO/wEBPLGayMxPFAefPI6qum9p1TMroYBlpYe/cxE57FBX1rPmvYDmyY22/K7Fu1MjXAebitbtfdDGxogqQZWIg3dsKLEIEExV6TqmBSFJXkZLWM4FbqADvnHUFlWfdDn0gF3dD4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding handling
Date: Thu, 20 Oct 2022 11:46:43 +0200
Message-Id: <20221020094649.28667-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0385.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:f::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: 7472bcc9-e1a5-4401-a228-08dab2800d54
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KgJz2OfqgqJI5GQWhL9G012j4hQR+jlEVYuy72Z0RMssxVOm8wfIwSj8gLx+lDP6agn3jqNR5W9yuZ6VVFPUGYNakdN95MZH67mGZOXCAqk5DnfVOTBPdsXHMxic63BVaEdvCSsx8mOVJEPN5+xT3mSlxxVjjpPzCmReZe+8oHchrZ27uom3IfrPPRQq1xQ/sDxrysJRPUMlp4/tsN8KWsDPjTMk9yPdLATXAxL/PAMK9ty7WvcdsvL4lLlGkK6ZRxWQiv7fX+C5IvEtQxeVXWdT8w7Oe7Y2SJb7tK0p6ZVkxJozJ989+34ZK1wCkpkF+kqJLq0iKfdboijqqgjEEh6vkfcSW8DX45czFooxC7uTYoQV9px8PZWPbzLOh2Mv44G7cjG7gc9le6+4mpi5/HK8J64SWerX5h+a2tr2Hc7Owo/oS3V2x/FtS6A8kQpSQV0jCXl6glLwPYV8l2+jIazMmoE66U0byulah+58rW9nWmZnLKdXHNX+FdcEGrJ0vOy7HQ7xZ6QMJnSlD8TsLqsxMPuiXZX+H2edY51DuWQgcyy7aKbxtv2P9zFuvTY5TZpt31abOPequNyxpi9scdcBXWKgmZQpqDhxdFxe+Ol+xvHjzTKFfnV5FxxVTw4gP/HumMrw875/c9UhpyO3btFAMDxES4cBYUGixRpfinnCnB/W2sVmG52eJTPDZJDKIZ7GwqQXpcKmGDWh+9/PsA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(316002)(54906003)(6916009)(6506007)(186003)(36756003)(2906002)(41300700001)(1076003)(2616005)(6512007)(5660300002)(83380400001)(8936002)(26005)(6666004)(8676002)(86362001)(66946007)(66556008)(66476007)(4326008)(38100700002)(82960400001)(478600001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d0NSUVZZYlhEVG9TQlkrU20xK0YxSW9icko2aC9wcVhZam14VFpFQXlYaGg0?=
 =?utf-8?B?dFJ5dFpjOXZXVjBGNmloZ0ZKd0ZGQThXQmI3R2xGNS9xMHFPR3FpVmF0Q3ls?=
 =?utf-8?B?UmV5MmhlRkxGd0tvM3RYNDNUWFI4TkdkVVpBenZ2MmNLSUd6bWtMRkxuYnNC?=
 =?utf-8?B?dlhQSkRCVmxhVXVOUmxwbzVlTGdmOER6YmQ1YXE2QW1EVlFRSHV3UUJQaDhG?=
 =?utf-8?B?MHdVTVRsWlJBelJjVGRIRm1PUnBvR09vbUJZZ0VLTHd1UXlHZmpTMkhVcE41?=
 =?utf-8?B?NlpEc1UvWWlEODlGWHVuVCtEL1htTEVDWU9iMTNrSTdLaWxCV3NHeWFPSCtp?=
 =?utf-8?B?eGFQekwzY2JiaVFuWERiWXJCQzBsR1Vnc2dmbHdzMGhVWjdhSHFSQWxiL1hG?=
 =?utf-8?B?K0x3WEJPQjdFbXZWemx5NWlmSGlORitOa2VyUkdnVWtyTXVtcFAwcGtBd1Z4?=
 =?utf-8?B?ajZ6M0Fyc3dKM1k0NkNWMHVYNW4yUTRjWmRGYzZIVUxlSFlJQkJpVEh5NHZi?=
 =?utf-8?B?b1RLYlErdGp0SHBHYTRoUFhibTBZSVVLLzc4bVFPOG5SUm1tTFdkaWxWbmRy?=
 =?utf-8?B?OHlmNFA2M05lVW5qM25WT1djbktHbWZTZWN4TytnRng3dnNNc0lUWUtETFha?=
 =?utf-8?B?UERtdk9KcDJLbnFTY3UxR1hiMXVrczZ5SHk0VkI1RTgydlBmTUJxTzQra3px?=
 =?utf-8?B?ajVFNFp6RUFyb3FJdjZYMjNKbFMyNjhKTmNPZ3prTHJCSytqY0NwdDBYZjlK?=
 =?utf-8?B?djQxTnBraFg1Qk0wMHQyakRUSTRKcjlrMERZSG1sR0NEK0RVRUpydTdGaXZz?=
 =?utf-8?B?QVdPaDkzQTlva0l5d2NzQlF2bG5rT0hWaE1kRndVR3hHWURsR2EyQkt4WWla?=
 =?utf-8?B?K0ZwMHhtcnVUTjdhVTVFZlhZdHlYcGpLcHNYRFNmWEZJdDNGQ3h5MTRMMVY0?=
 =?utf-8?B?SFV2MTZicEZHSHhDOVdnWmxtR0kzUktzY1JTSEVtenVWMEkyb2JHdTJWcS85?=
 =?utf-8?B?TkdMSWE1cVQ2VGpyYkVTcEtQVUVIZG1ZS1hJOXpkMjF0OVhMT3QzWlRESFhE?=
 =?utf-8?B?SjM4UC8rUWJuSit6WFd3WW5zNHZrT1p6SldpNFpiR0tWR1M0SnVWWHRYNFdI?=
 =?utf-8?B?UmtJNWdFRHpCQkMzTFg2MzlMRlMwT3hBb2hGOERpNm9jV0MxeitUbm55MUZu?=
 =?utf-8?B?b1UxTUxJSTc5UmhsTGtrWUs3VmhndThwYmVza2pUSkM2Qm5wTGpvT3lLWVZm?=
 =?utf-8?B?akNNQ083dDg5RHk0STd1SGRwZUw0WFVXMEVUbTFIbHAwVUU3YVBTVGV5MWhh?=
 =?utf-8?B?cnhkQnhOb3hOVG02U0ZZWWpRa2F6azdrcWZkcUMxVUtxUFMxZURYZ0dMaXpj?=
 =?utf-8?B?WHVIblBMMkN4ZmF3cWtSOXFvRkhwc3FTZnJORlFZaWcxRjEwRlV5ODdRS0Vl?=
 =?utf-8?B?SmVGbEhIamtkR01HTGdDcGVpNzMxL2ZWQVRlMW1RWncyb0xyRDB3dXJJNUVi?=
 =?utf-8?B?QTF5bFJ6Vmp2N2JMcmJzSVJVZ0pMZ1pGR2lGWTM2NmhLVUVuQWgvNDdUMFVa?=
 =?utf-8?B?a3B6Z0xHYXo0VmdsL0Era0VsWU9UcWdiNWhqckU0ayt3eVhua2psY2thSzlZ?=
 =?utf-8?B?MlBBNWNmUGt2anBScDNwaUgwVmJMeFcvN0V6aG4xMEx0RlZGbnBhRkVZME1i?=
 =?utf-8?B?S2RzYWplUmhDWEkreWVoKzJCeDV1Tkh1SlVwNmk2K3RGcHJ4aTNmNEczbFNa?=
 =?utf-8?B?bGlKUDd4UnBtekRub2MrelVqNjAxTGpVdUJoZEVoMXFzQjROWW9oaEIxMnph?=
 =?utf-8?B?dlI5OW9kYmwyRldMb05vNFJiK2c2UVpJQVF6QmlaUGNnbGhaNGJCcng3Qk1x?=
 =?utf-8?B?SytUM29JYjgraERlRnNSUGloUk9nT2lNaldnNVdlZ2N5bUhRUUU3ajJrcTl1?=
 =?utf-8?B?bllhQms4Ym9ESTV0ZGcvVjl0dERKNHZJWjlrNmlVL2lHM1I1aUFxTEhtaFRI?=
 =?utf-8?B?ZUJORkg4WFRqcW9QdmVISzh3WGcyK2ZWN1BMYWM0MEd5aS85U1owUk1ZVjgx?=
 =?utf-8?B?MUcrZDZjSzEwUWVQSE8zd2JSRURaL1lMUkFFdE41ek9Rd21CdHY1b1czZ0F3?=
 =?utf-8?Q?YUaHNa5xHurFkf7d4mCG/yjc/?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7472bcc9-e1a5-4401-a228-08dab2800d54
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:07.8054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TAvgeyOwJDC7x7TB7iqJHvvU0pOK9XnNC1DXeTfEz3fQtuYuewaLUXyjWqrCE18yIT/fE1Aozbx1DYckpqELsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

Hello,

First two patches fix some build isses that showed up on the vpci test
harness, following patches attempt to fix the regressions caused by
75cc460a1b ('xen/pci: detect when BARs are not suitably positioned') and
the last patch relaxes the check done when attempting to write to BARs
with memory decoding enabled.

I consider all of them bug fixes, albeit the last patch is not fixing a
regression (since vPCI code has always behaved this way).

Thanks, Roger.

Roger Pau Monne (6):
  test/vpci: add dummy cfcheck define
  test/vpci: fix vPCI test harness to provide pci_get_pdev()
  vpci: don't assume that vpci per-device data exists unconditionally
  vpci: introduce a local vpci_bar variable to modify_decoding()
  pci: do not disable memory decoding for devices
  vpci: refuse BAR writes only if the BAR is mapped

 tools/tests/vpci/emul.h       |  3 +-
 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 38 ++++++++++++++-----
 xen/drivers/vpci/vpci.c       |  6 +--
 4 files changed, 34 insertions(+), 82 deletions(-)

-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426330.674705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS97-0001fa-ES; Thu, 20 Oct 2022 09:47:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426330.674705; Thu, 20 Oct 2022 09:47:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS97-0001fT-BS; Thu, 20 Oct 2022 09:47:25 +0000
Received: by outflank-mailman (input) for mailman id 426330;
 Thu, 20 Oct 2022 09:47:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS95-0001OM-Sc
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:23 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 310f8e5b-505c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:47:22 +0200 (CEST)
Received: from mail-sn1anam02lp2049.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:20 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Thu, 20 Oct
 2022 09:47:17 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 310f8e5b-505c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259242;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=QkS8LmF8sq5TWLGpZ9BwE7SA8QxQS8KMGl/B93RqDpo=;
  b=FVXwRsZccfOBim01fYO9lK7FI9LFmLIlJErQMnlHWkz+3fSx/7ojCkCT
   CEawNYPIWe8odwMBh5Isos+F08kgcAHWfxAc4geBQvs1XG67GdMfZBYYc
   RTszJO/FakzvOEJ4fy4VdtjHz3D+zs/QKeYRgEtykYWIj1VFiVV6Jl9x+
   g=;
X-IronPort-RemoteIP: 104.47.57.49
X-IronPort-MID: 83565863
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:+6RAi6y20m/RSUo74j56t+c5xyrEfRIJ4+MujC+fZmUNrF6WrkVRy
 mpMXmuEMv+LMzbyc9B/ao+/o09QsZLXmN9kHlFtryAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC5gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw9vkoJEZ39
 uMhLzEQPjCqrbq/mfG0Rbw57igjBJGD0II3nFhFlWucNtB/BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxrsgA/zyQouFTpGMDSddGQA91cg26Tp
 37c/nS/CRYfXDCa4Wreryzx1rGU9c/9cMENOPrj8r1RvG3N9FNKKloRcgS9//bs3yZSXPoac
 ST44BEGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6GAkAUQzgHb8Yp3PLaXhQv3
 16N2sjvXDVpubjNE3aFrO/I/HW1JDQfKnIEaWkcVwwZ7tL/oYY1yBXSUtJkF63zhdrwcd3t/
 w23QOEFr+17paY2O2+TpDgrXxrESkD1czMI
IronPort-HdrOrdr: A9a23:Q8pEvKP9U+Lgh8BcT1r155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jztSWatN/eYgBDpTnmAtj7fZq8z+8P3WB1B9uftWbdyQ+Vxe1ZjbcKhgeQYhEWldQtqp
 uIDZIOb+EYZGIS5aia3OD7KadZ/DDuytHVuQ609QYJcegFUdAC0+8vYTzrb3GeCTM2c6YRJd
 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoILSIly95FMzQjlPybAt/S
 zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+cwzqAVcBEYfmvrTo1qOag5BIDl8
 TNmQ4pO4BJ53bYbgiO0G7Q8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnJ
 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvsX+9KK1wUh4S1bpXUd
 WHVKrnlbZrmBKhHjrkV1BUsZORti9ZJGbEfqAA0vbloQS+0koJjXfw//Zv7kvoxKhNNaWs2N
 60Q5iA7Is+KPP+TZgNcNvpEvHHfVDlcFbrDF+4B2jBOeUuB0/twqSHk4ndotvaM6A18A==
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83565863"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FN0k2f0SLt+yLEzYvl0FcivMxOLn9YFP+fUBcFXm4BZ7+UjGHR5zOhDuzINvW56WbYhV7tjUMzt9nAOkuNjCr/uPtktUT76iHFZez7AVnilmS2FfaCQzR6OcMtMK3KWy5Fl2nFACYgvDnbWDMPkcEdgQg1lC52KYJ3PS5iFpeC5NVdCBua0Re2+UniEf6HRzAWRqfgPPEF7uI0JIH3RZULWgGhJ42nQK3m2Zllxnf5NeaiUgF2FS6Gu1Ssrx6I/V314N3vNK8fAQTOnKSlHZcv98wmlt4wNRedehFxGX5oQSdirpiteaBzGqLDjBWb/YZ4LYzPWpiU2g0zdwXW6btQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c55b8Y3FjLXBmFEK2e5vgOav21j93/W+nW7shNB4ico=;
 b=BZWSDVUQtLN/IGapOPy0aPwsHHx98HU6Oz1RA5CjdFfBe0btMVQY3m1ZCr5vchD//1eydWM8sAt9qP483ILCn1nbgUrjlM4gxFoVmQdiy4gPxPYJrFif9sWTAiNdkZx8bYEyxeJf/8jXAoAlLiTOC4HNxlj6DjvsoX+/ykvl9RoPV3FJJSzNcGMHy5pzkGtlwOm00v43x15fEhtprMZv0pED4U8R1wTq0IKP5bxVBwy5bT9shtSjW+wPBGcSKxscpIhKungsf2TZuaKHKDM+0Ampm0SxM7tALbHscypguXf+7MiJpdOx2bHfcQMP2nNHPUCDjxeVe4HfXdoj+t0T+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=c55b8Y3FjLXBmFEK2e5vgOav21j93/W+nW7shNB4ico=;
 b=TMkSEZ7HbEsEYS4WWlKyZvwqRIRTjidz0QwrWSU+hfF2uWT9xzdfcueDr9pPGdMcsyeyB7Fm1Y/u23zgdJzNR6hh8u+oDBfxNACXViXE5Ipxp4MJZ6ecTW5cSIATELIO5FP0gGUdygvUC+O4tLIfF9wUPI6QAowGlmlLsywM4Iw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH for-4.17 2/6] test/vpci: fix vPCI test harness to provide pci_get_pdev()
Date: Thu, 20 Oct 2022 11:46:45 +0200
Message-Id: <20221020094649.28667-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0129.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9f::21) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: b946d289-54f6-499c-2921-08dab2801363
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LPrOBerhvRfX8ELjtef5u+RS3zO56K5+LchbSJ1ERN88/SPq6BhqvscIGigf7TwHVWzaqSl3GqP3Et/8T3KyCnKFrw+jQty5Z+XklESexvIZacM9FVa4jJQ/MB3vrs2KUioRC9aOijK0LeYoVFQDW/9E70I/UrPY71BIDTWIH3O515sSUxlq5v/sapIFH8imm298ne+HOB/Hrtiwoxhxhb6pVbqW439Jy2LM0Lxvkx9JSspqJmeKwg+/uSwgh50qCg1qy5+rA0/aLtxuEbnR/hSpLl6KoHO/y3++Q0r3/6KNxBQd2a7cZ36Gls+FoZIRaEdvIHvgZYh9x5GLATOCVPzITZx0UaZQCMrgNilMHxLuQexzaKHbocV3GTNzzXvgoBxGgnj+sW8FhNpHD6ARSc8dxX5G0T8s3irwZ9c+pbzc16dXkKMOFa5wiQyFzqrixUrTiIurOs1YHjdvKE0LnwnJFwzmcABEICVEJDxR/C4HVu7L+XI/99N5XPpuyTowerugJmZNSKsVy0pDGRuAmPZHjumQjFcJTDMKv/4TuBEbfN3UeZWsplkzF4nWTqMJGSo89lOAN88mRizF4wBzUCJiZAZ/TnNBDybKCED6tis8XsW1vJT4Fi6oha8I7cAHSk+tT5SwCP8qioS61rDLMpIoYwxfHp6c9BgXVFgmJ81FKcvvfNrpwKQlpfDoVkl7oTwpvTH43GgGb6prWi1J6g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(316002)(54906003)(6916009)(6506007)(186003)(36756003)(2906002)(41300700001)(1076003)(2616005)(4744005)(6512007)(5660300002)(83380400001)(8936002)(26005)(6666004)(8676002)(86362001)(66946007)(66556008)(66476007)(4326008)(107886003)(38100700002)(82960400001)(478600001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U012bkNUNzdadEc0UnZqSmFDdU9sMUZvNHB3MmtheTlzMjVDVVJ2eWFuWmhM?=
 =?utf-8?B?emR2dnJqZHgwdzY4UFg3NW5MOUxRRXNoMEZGd1lLRmFWV3pWZHFHRmFGV1Nk?=
 =?utf-8?B?UE5JYmRFTDIrdy9UbWZKTGhyMlNqeEt3THAxSmhLUGlSOXlsUjVlSzJqaEhF?=
 =?utf-8?B?Q3I5Yzh6K2xEVjQ5NmluT3VaWGVNSkNFZGR4c2dvdVhrZ2FFZHpoSC9kS0hO?=
 =?utf-8?B?VVlnMlpndG1oemJ1MkZCWHVHTVRsdGNiNG9rMFhGdlZGNUVLRlk0WUZtbXdt?=
 =?utf-8?B?UHpSbjRVS2g1T3lYdHU5VCsxczJVL25JTGV5NzNuY1dJQVM4TkQyRnQ4Mi9Z?=
 =?utf-8?B?cUh6ZDc5VEVWQ1JVUXkxSlFjdjRuSyszQTJvU0plQXhBUHFOT2VWbk9DV0FY?=
 =?utf-8?B?MnBtYVc2U25pa0grQ2hyT2gvVXpOWWh5WU1TbkVoaHRnd1FFSU94Tzh5TnJB?=
 =?utf-8?B?VUtIMmdKemVPQ2l5Z0pFaU4yRzhQeG1vUytlR1lRZnZReFdBVGxmZ2dWcXpO?=
 =?utf-8?B?akxZajk3OVJJVHZJQ3VKQ25HcHlkVitUV2dhb2VHc1VTUWtKSkI1SnNWdURu?=
 =?utf-8?B?ZkJQQzNaVzRwWFlEUExva2phWHRKcTBya2gvTCtRVUxQY05yU2ZNQTlkditj?=
 =?utf-8?B?cE51VHViRXUrUGlXRW9sS3ZNU1p6ZVJiNTAxdTJWNk1JaHM4TnV4ay9hNld0?=
 =?utf-8?B?R2V1Tkx4V3ZrV2JZbmRZSGJmWE5jaUs4dnN3aVZLRktQZlRwczMza1UxVElj?=
 =?utf-8?B?a1lRZG5XOTkvcW1VWEFIcVFTUTN1UEdITUFqbFcyTThnNFNKVzJsY3U1S0dW?=
 =?utf-8?B?ODlsZ0tpMXV1R0VkSHBLbGROSXUwcmtSRUpONmZPS2JpcTBGTFpNU3BYcWR4?=
 =?utf-8?B?Tld5SFExZGMwWHVDVWlDck1KTjNFb2pzM2NoNE5xSjJCUEFyNjdXZURCcElM?=
 =?utf-8?B?SjRLT0JsMDlkcDJINkVoekxJSlNNOXJ3TWt1cnhDNHBrOVl3Z3Z4allaTTRr?=
 =?utf-8?B?cFZxbDJRTmRjRkxVQzNHcDlVQ29zeGFSQ0xxL1pnc3Q3NThkMTRNQ3pmWVBu?=
 =?utf-8?B?TFVQQWlrVHQ0amtTNEg2SHNGOEpNN2U1ZjlTZFF1TGNBSWtsVlZYWUo1dThT?=
 =?utf-8?B?YXNIUkQybFhhbWdiN0NVU0pucVY4RjNkSlowbU5kMjd6bi9hQzBCU1lPZjJK?=
 =?utf-8?B?QTB5ZkZrMGVNdmM5cnQrL3ZqdXFtcVdtMW54TlowZGg5NndIYUpvRi8yVkJQ?=
 =?utf-8?B?RFpNT096U2pwcWZ0MndkN1BaOWozalF3bGtlYlRpV0l6TWFpUlhyL0duMDVx?=
 =?utf-8?B?YnoxdGJUd0tBT2ZLSDhWQVkzdkxTeXI1dlhldndUKzFYcFRrbGEyTkVlMHln?=
 =?utf-8?B?eS9CQWZwa1pQUktySXJvamdMb0RTYjk4WDc5cGYvT2JOV2ZFdCtrdEZ6eFRh?=
 =?utf-8?B?ZWd3K05ubmZNbXR5aktCU200a2xPQ0hhSEJ1M2VNSGlhOFo4amY1OHh0YWxq?=
 =?utf-8?B?R0Y0bDJKTXp4MHh0UUhQMUw0alhNcDFVdkQ5dWN2NzRlMDMzRzdhOTY0VFgz?=
 =?utf-8?B?akJxc0Nid1NpQ052THlRekRLenNmeW05ejdtM29UMHQ0TjZSbEd1NEh1SlVx?=
 =?utf-8?B?SE9hT3V0cTlwd0drNGFLMHVuNjlyNDNTZFRZSnNna05ORGVRRC84YlREMzFh?=
 =?utf-8?B?SWp1aXJZKzV2amFIRFdZeUVYRU4wUTZQMXovMGVrNmF3d1NnOFpJK1owQ0hr?=
 =?utf-8?B?TUVhQkd4c3NTYU12ZEY0R0xmcjQ5SDl0cGllNWhoSWlXRU1GNVNjQjZrZEF6?=
 =?utf-8?B?THZuWnpjYkZ3THB4SFE4RlZFWE5RNCtPUEhKK24zTTFsUE5OTFRTRC85VUFU?=
 =?utf-8?B?NUoyT01zMTRZVGVWbjVNNlZDYTVBbFA5amFSNExUOFRwdzUwa0U0aFloNWVx?=
 =?utf-8?B?MmdHZTBoc2VCSjVZZGI5WlhoYkNxU2M0TG1KNXQ3MklNTVlrTTV6WFR5UGl0?=
 =?utf-8?B?eHV6Sk1IRVF5MS9FUUNSb3lsM0d6RkJXdnlpeTJDYTlhaHpkRWVhaXlXUlV6?=
 =?utf-8?B?eTY2RGtVNjZoMllzcWp4V1o4OTRmeFlFeWVkR1ZlVjZjU25BbXJ0dTdNZzNG?=
 =?utf-8?Q?nE2H+uuayPnQyayOfNuUV04zl?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b946d289-54f6-499c-2921-08dab2801363
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:17.8419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8WcJTDQp2pBbNm5ANZnAyQ0wsBzAkhlGSfiohPMfyrVVRrtR6AUiVjN6zu2Hr8nyuCWlBo1uWUwXde1ukR2jPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

Instead of pci_get_pdev_by_domain(), which is no longer present in the
hypervisor.

While there add parentheses around the define value.

Fixes: a37f9ea7a6 ('PCI: fold pci_get_pdev{,_by_domain}()')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/tests/vpci/emul.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h
index 386b15eb86..f03e3a56d1 100644
--- a/tools/tests/vpci/emul.h
+++ b/tools/tests/vpci/emul.h
@@ -92,7 +92,7 @@ typedef union {
 #define xmalloc(type) ((type *)malloc(sizeof(type)))
 #define xfree(p) free(p)
 
-#define pci_get_pdev_by_domain(...) &test_pdev
+#define pci_get_pdev(...) (&test_pdev)
 #define pci_get_ro_map(...) NULL
 
 #define test_bit(...) false
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426332.674727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9F-0002KG-W3; Thu, 20 Oct 2022 09:47:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426332.674727; Thu, 20 Oct 2022 09:47:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9F-0002K9-Si; Thu, 20 Oct 2022 09:47:33 +0000
Received: by outflank-mailman (input) for mailman id 426332;
 Thu, 20 Oct 2022 09:47:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS9E-0001OM-9g
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 36ca03f2-505c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:47:30 +0200 (CEST)
Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:30 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Thu, 20 Oct
 2022 09:47:28 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36ca03f2-505c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259250;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=zhU/cvtVTG1/4sJCeeB/wJONeiOC1F2tMr7LlQSVZm8=;
  b=HvjoCCAEghT5bIRMmUTqbW7LISMZ5DR9HTO9HG1w71nboM7PQRWhPZbP
   kELS92xSkgfKrAu/Tj89axsAWBBUjhV6l9lw5RsJ/k0FqZ5QDZbUY6tcr
   1XD2Fuwz8rTITr+QOH6hP1H9h9ZMlAPcKfX64yZBop2zabtvj/PUtSVSR
   o=;
X-IronPort-RemoteIP: 104.47.56.168
X-IronPort-MID: 83565871
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:EQJS/K4b1k08hWOIvF9hhgxRtELGchMFZxGqfqrLsTDasY5as4F+v
 modWj+CMvaKYmH2f99+ad+//EsHu8PdytNgTwZtqHsyHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZmPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5oKztAq
 8ZfEAk1ZzW7ls7twpmCc9hF05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGNnGSd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL327GSzXyiMG4UPKL/3MRXg2fN/Vc4Cjw/V1mcruKkpGfrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWblXoVRZEYd0i8cQxHDoj0
 wbQm8uzXGI/9rqIVXia67GY6yuoPjQYJnMDYilCShYZ597ko8c4iRenostfLZNZR+bdQVnYq
 w1mZgBn71nPpabnD5mGwG0=
IronPort-HdrOrdr: A9a23:uud85ap6qzRjBQVQjMXfHrQaV5uwL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssREb9uxo9pPwI080kqQFm7X5XI3SJzUO3VHFEGgM1/qH/9SNIU3DH6tmpN
 5dmstFeaLN5CZB/KHHCWCDer5PoeVvsprY/ds2p00dMT2CAJsQijuRZDzrcXGfE2J9dOcE/d
 enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr18jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvS/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kda11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa
 dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvjklLYIk7zU9HakGOul5Dt
 T/Q9pVfY51P74rhNpGdYE8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d
 /8bG8=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83565871"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RGCC6ZWd2XotCbco2NAAFVjsEK6yOR8geiHqFqm9PLLj9dQ/qH2dBrGgNejOPStM55yUx0p08A2Zx35zK2LKJ17MzxIWdLrqnaSD+3pWbNIvoR6hF+M8zzgFTydVtoznltdvvLJ/f+WkPgSPeBMLKcjn75a3GdTBRnG1vpXTcamjSrodJOKstoWlBI2oXTZ7dfUu23OIOytPOer9TYzl+WtlLLkoy/S8JqwM5lBDoEE+8XleMky7pwi8WkkUgpXr1+0r79McbtgGoXoDzf2ZlyGBPg5buPmaWvp4imG9x11PqWXaO9t58w+7bJzZc/dn6WPPq6kh5IHGs4E7lOcAwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tcNqGycumZluqS1dv81OQzz4p9zUec8vGdrHjobcML0=;
 b=fu0+v4n25iLXRhQYOYLizZ2ZIk7x9zCHtXyYR4Bpd34cu7hiTncXYtBpt/BVwBe/5lAEUVdJz16TC8ltP8u2xalc6romO8LZewN3A6LpTwG4F6Xp6jTcvUWX56grkaob+oG06t+cls68bq01z3F7z5W+0Jrx94K87rX9hmLAI+XgcDU1AoRGCXtDSF6H/dvTfFVrGHxXXUE5pm8thZPi+2SveavIB+kCRxuIpZoMMqjFZDik6YZ+D7c5O+fQFOadSWBipZiWIuwA2i8vmEdSN/Bmg2ec2Urhpv9JI8KncxmPdE/DHByIA0TWQ0ersD0jNHGsR8hOCcXnfbfcGCMNXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tcNqGycumZluqS1dv81OQzz4p9zUec8vGdrHjobcML0=;
 b=wiyew6rYX/0calNxVHMkPtpAJZfqga+i0fYoSdFdJvEsGZMOLUD31DHG0m5IXuhO3R5Ppem+W44T5IY9kCBqz0IpEtxi+vVhmXjlcsOEuBqZGSSxGylY6OMEj8OlE40KKMaB69bfBGJzYevOAqOIATFrHJY+9dW4d+aIQfioZMU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH for-4.17 4/6] vpci: introduce a local vpci_bar variable to modify_decoding()
Date: Thu, 20 Oct 2022 11:46:47 +0200
Message-Id: <20221020094649.28667-5-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0657.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:316::6) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: b079895e-1c0c-4144-01ca-08dab2801955
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Husm1w+74Z8vtSAkUXxYbjiwCKvF58/5YtxE1kmZ3zXt/opOkLB1DwwO8APeMDK8hG+7M/CpMtQcsXoxJ9jPMSmStL4Es1MxhsoMSvOnaZ356tRHpJEuzv4dxvpwGekI9ZizoKRaxWTEYUsIHHOJ8pc8h3adiLJzBjYGoG//avFP21SrK0gTlmKoDjfU5xyTSYcNWKOLNDbgaS0KjSKmz79CMvL3ytDLc4sFvd5v8kAT3fYNq2q4y+NyjraxkLa2fcTv5dM0YAr9lXALiE4riZPZqWfhxjQx2MKAymgleAory+FGz0LRSou7Y98CufEjZzM1SeKt1DZ+kY+Nhew3G5iy7OEygKteHtsNi8V83q2ifHlGJGz8aM+Jj8sQV8sbJLnB1Ff7GCWqv1MeYE99MC8k+gIQnimiW5S7Y4DeId0UyOSBkcKOiyRU+suVRkInV9sN4Z3zujk4iMzU1S0NZG3ekWLQwwDWXqUifRf4vAlKXpJa7dKGwG/7IkXbEHEAJT0GFBVeNUODoDzxpNcgSCUBMQg8RbgAOYVXYRwHQjuRvaip/U2MbH8e0VnIm3MIyVaZhfdHNtp3Kw1bpakPCahPn3SigGEFndFvM/PAcD3NZigbWPDbmwOdRw4WtIZ3WZfS2asA+s95t4OTCFKznROWInqLkFx8mWvOmxf78v2P1FJoqfQxHPEoLtv8VNo0RYH1mu4Ax0xO6iZ2llg4Wg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(316002)(6916009)(6506007)(186003)(36756003)(2906002)(41300700001)(1076003)(2616005)(6512007)(5660300002)(83380400001)(8936002)(26005)(6666004)(8676002)(86362001)(66946007)(66556008)(66476007)(4326008)(107886003)(38100700002)(82960400001)(478600001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eG1UZktMbEFOTm9PSUY0c2ZFT2FyTUJuWGViaDdqNDNtUXRJelZ4Z2Y4bUhq?=
 =?utf-8?B?Y1pUMmJyNXJkdTg0bHRBeWRVMklzeWJzK0pSYnlNU1lSeVRtYUh6dSs4eVVZ?=
 =?utf-8?B?K2NZRCtGR2psQUc2NWdyelU2K0gwM3RSK0xVenNJT2NlbFdnczk0Z2RRNTNR?=
 =?utf-8?B?K2I5Q1MxbG1jVGRNKzFnNkV2SW5HZGUxcDNNeXhaeFFKclE3U1hmU0k0dTJ1?=
 =?utf-8?B?bSthSGp6S2dzZ0J6V2FTVFM2dDg3WDYrR3IwRHEzU09iRmFMNWgzNjczUzBZ?=
 =?utf-8?B?UThqVW9ReDhPd0F0cWNrcStpd1hIYTNxVzBXQ3E3R1BlM0JmRjF6Y295K3g3?=
 =?utf-8?B?OWQwc1paWE5JR2ZwWTVxKzFDc2ZlVG5kdW9WdkRYaWpQblI4am9lMnJXZFRs?=
 =?utf-8?B?QTQ3SzFabDJPcFFzeUtiOXNSRUtnNXMwdU85SzhQSldhWWJzODBvUGJOelpz?=
 =?utf-8?B?MEQ4TkwrTjNKVElSQlBjV3hFdVNEN2pmRHlrUmZkbGZxYTQva0gxTlUxNjlQ?=
 =?utf-8?B?WmR3VitCYjJjZjQ1SmFSbzFEaTExamFkbkZheUljOEF6eTU1d3Q1T01jZldy?=
 =?utf-8?B?bnhsRVUwNUI2bGZsRUlVNVRaRXFablJTZWJwUXF1N29vNTM5cExZSEg4cXRH?=
 =?utf-8?B?YmpEamloMkp2c2NxbmJkcXZVQm41NHhzTlNlTHZWdkx2dkQ5bVp5Y2tpa3hD?=
 =?utf-8?B?S0NCaWRTT1cyQ0o2d3ptMVhkVHp6MWQzYURKb0ptSjlaTklNVERabTRDaTVm?=
 =?utf-8?B?MUdJbERNR1ZacDlhTVpDazlveU9adDVDdFE5aDVsdGcrdnRjNVc5MnNudTFu?=
 =?utf-8?B?cjdmUUVSalU0WExPYURFSmZ5N3BueHlxZDJMVHRWa2t0YnpaTmN1RVhLQU8w?=
 =?utf-8?B?Yi93Q1RDcFhOM0xPcnVqSXN0cEJkNzB1M2xTSEl5bzhHT2lsWEhDQk1DMUZJ?=
 =?utf-8?B?L2liR2pOVExvaWhGQTFaRm1LOENxV1RuOFh4Y0pxdnR6Smw2N3hsbEJGcEFm?=
 =?utf-8?B?UjFlRWZibDRaM2o4ajRNcTZOVkZiQmVVNGxUME1vMFpxU3RDZU5hSmdyQTFG?=
 =?utf-8?B?a2p6SVAyUzVkK0FtMTBuM1UvbFA2V1JpKzRpSG41ZDEvVkFmZURyZVZZdWFP?=
 =?utf-8?B?dThkK1pEcUhTWlp2VUh5N3ZkUTB5amRaTUFzWjRiVFpOMGJSd0lCa1pVclpI?=
 =?utf-8?B?TWZKSTRKUjhBK0Qweis1bTNaWmY2MWhwZ1NVY2xsbEFCem1CSEQ4Y2Fyd3N4?=
 =?utf-8?B?c0YrYis0NCtRcGVaWmJKcXBINUUxVzU3c2QrTGVzdGlOeCtESHpUanFpa3J6?=
 =?utf-8?B?UjY0V2xPb1ZMbVlMVW0xS0Z3aWlLenBGL0x5Mzc4RkZCaE9aR2pRY01NYWdP?=
 =?utf-8?B?K3d0US8zVHZjaTdZLzIxUXJ1bWJFbEpDdlhYUEZEc0hvMllRQURCYW9kK0xG?=
 =?utf-8?B?NXh6d3NsZmRSdHd0K0Fvc3QrMCtxa3VxV1ZsUlp6Wi9pMzNaTTBMN0NYV3F1?=
 =?utf-8?B?Wml5SDZ5aThkc28wbEw2UklXYWViWGFxUWVsRUcxTEdPb0hzeDczS3NyUXNl?=
 =?utf-8?B?Z2dudDFwV0lnU2VqODgwQzFKbndiK1RkNmxGU3FFSDdYdDJHWlBWQ21XeUgy?=
 =?utf-8?B?NVlWR2NmSEJ5Wk15MHRhMWNLM0FvbGxSaFlHd2UzaUFKRWx6YVVBMDdEdDJV?=
 =?utf-8?B?cEljNW81c01HWW1tZEFlclVVMjE1REU1Ymp6cGxTVmRqQm9sMUZXRjRlTXRa?=
 =?utf-8?B?WHdHZFUyYXU2R1B3NjZ0WDhlalowZGVUZlVpdzNiWXBCTkZ6WFArRXU3UGQ5?=
 =?utf-8?B?QStBRjNiNFZWRmtFSko0Mk1wV0VHK0MyZWM4Tk5JekNRcnV1ZEFySU5GRHlh?=
 =?utf-8?B?VUNwQk1mVk03bnRUMUpUdTBiMW5UWDBEZ3AwMW5SZGRjOWg3dnhFQ3JhZGdL?=
 =?utf-8?B?RlR6SEJFUUlINElTM3pqZlc4OVRlZ1VoTzBHSmdIMVRRWkpXQVBTbjBzYUd5?=
 =?utf-8?B?cE5kaURBNGlFeTVzQW9WU2JBbDdKUGZCVmc5amJEVzdOa2s1VFpNTVhrTkFR?=
 =?utf-8?B?OXZ0NzhJbm9NNVZNa0tvd3AvdC9ua0lFdTFRc0NtcDBwck9tQUhVV1AyOTdX?=
 =?utf-8?Q?KNU3Apwi1AB6HYr0pZiLSJxmR?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b079895e-1c0c-4144-01ca-08dab2801955
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:27.9405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LzHyw9acq0WVBKaqn3/Rt4UxQ6AyxoymcKHmlAq85Oe5rxHO175byHxv0g61nIEhBaGS2VABoEULLRViFED7lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

This is done to shorten line length in the function in preparation for
adding further usages of the vpci_bar data structure.

No functional change.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/vpci/header.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index a1c928a0d2..eb9219a49a 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -103,24 +103,26 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
 
     for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
     {
-        if ( !MAPPABLE_BAR(&header->bars[i]) )
+        struct vpci_bar *bar = &header->bars[i];
+
+        if ( !MAPPABLE_BAR(bar) )
             continue;
 
-        if ( rom_only && header->bars[i].type == VPCI_BAR_ROM )
+        if ( rom_only && bar->type == VPCI_BAR_ROM )
         {
             unsigned int rom_pos = (i == PCI_HEADER_NORMAL_NR_BARS)
                                    ? PCI_ROM_ADDRESS : PCI_ROM_ADDRESS1;
-            uint32_t val = header->bars[i].addr |
+            uint32_t val = bar->addr |
                            (map ? PCI_ROM_ADDRESS_ENABLE : 0);
 
-            header->bars[i].enabled = header->rom_enabled = map;
+            bar->enabled = header->rom_enabled = map;
             pci_conf_write32(pdev->sbdf, rom_pos, val);
             return;
         }
 
         if ( !rom_only &&
-             (header->bars[i].type != VPCI_BAR_ROM || header->rom_enabled) )
-            header->bars[i].enabled = map;
+             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
+            bar->enabled = map;
     }
 
     if ( !rom_only )
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426338.674738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9Q-00034o-CT; Thu, 20 Oct 2022 09:47:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426338.674738; Thu, 20 Oct 2022 09:47:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9Q-00034F-8U; Thu, 20 Oct 2022 09:47:44 +0000
Received: by outflank-mailman (input) for mailman id 426338;
 Thu, 20 Oct 2022 09:47:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS9O-0001OM-LX
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:42 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3bd0cd0f-505c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:47:40 +0200 (CEST)
Received: from mail-sn1anam02lp2046.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:35 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM6PR03MB5003.namprd03.prod.outlook.com (2603:10b6:5:1e7::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Thu, 20 Oct
 2022 09:47:33 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bd0cd0f-505c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259260;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=kAAdyrIBV5b3v2jo4pvSozj+LaxTfiauFnyu5tTM1Vc=;
  b=WveUFgk3MacFGc9jXE4J8aoR7hOMzlEmZ6xlRJNjPaQVGKA8CLzESx35
   +Pds3++lWKX6Mkhd+RAhz8U/UVtLp3HzEF1M5UmbpVQUAK8lkbksQXXMU
   t8Oiukuq/5SHHRM5gY5o5D9VVW68Yuvdca0G8NuGxMt/Bj26S8k+RdApT
   c=;
X-IronPort-RemoteIP: 104.47.57.46
X-IronPort-MID: 85669458
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:6Qrc/q+z+0uZkUohKUhuDrUDpX+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 TAWWW7VbqzfN2P2Kdtwa4rnoEpTup/QyINrHFFt+yA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5ARmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sxbOzpPr
 N86EyEuNEuMn+iR5+34WOY506zPLOGzVG8ekldJ6GmDSM0AGNXESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxvza7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVryzy17OSzUsXXqoWGYPmz+M33Ge0nEtUSz85bwO5jb6Q3xvWt9V3b
 hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xBGIJUzpAY9wOr9ItSHoh0
 Vrht8vgGDhHoLCTD3WH+d+pQSiaPCEUKSoZY3YNSwIAu4PnuNtr0kyJSct/GqmoiNGzASv33
 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNXNi1CAgbQD0ct9EQ==
IronPort-HdrOrdr: A9a23:NsT4SqDTjDKO3KTlHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN
 hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dOwEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 529lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ5o+a87bWzHAb0cYa
 hT5Jm23ocXTbraVQGSgoBX+q3iYpxpdS32AXTruaSuokprdT5CvgklLfck7wc9HaIGOud5Dt
 v/Q9VVfcl1P6krhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="85669458"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ewCm6bVX+99uBKN8XM7piXtfqoikl5qLfZIyF2++Uo6deKJWtzGTOmigtD0Poz5Q4tmp8R1jXfXazv+YVTI6Bvvtv688SIZQAiBxns2tMJ8ONFi37rKw7eN+tUwzxHDzTUzf+CiB8NVCrehLs1tBjhZQyUt1rVVE/CeF4b4NTIYTTeZa11VyVsfPFv4AjaHunXQmlTuWLFR4/HReaNNaaVdGPGHQEIQPG9P55bRgPfgMywR9a5IeRstha2S29oy48/OTBqmo0iI6ldo1FPfx20DJTys6u+7OO0qwC4ZLN4kN3qxmZw6h+FRzPzbaVZd8DxdJxQp0uoxY+P8Njxdq2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9VZPXsMkn9fam+VCRpitzkT4VDEDmOwmP7P5aKFDPN0=;
 b=hWOziJ2QIKMOBTjxZ2TIF3ewzHIDw2VxS5P3+wNL9G597BHst7lPh6bNsvjHtWBsfxgpl3AiPXzsR4hrJJTmvbOCr34ea0hco5Aywxqro3vdfsaEMhuW54sIqTlQzK/G7PXnsX/qk/2THLqn14QqCM2nns2KlemaujWf/4Nsyej766wTSkFmU6txBesclrZV9ZvjpVapA/PjuLWVU6H2oEYXb8tUk/E0/MZ8t2blBbkfFIast8Bd9JScrD1rU2+KPQT+bmokOFm80yco+IdnOUI7DGz/2RwycpXHgeh5X4SnRNJ4ozVpBemqrIR+MzSlPzBw2QICJVUl350cDv9dDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9VZPXsMkn9fam+VCRpitzkT4VDEDmOwmP7P5aKFDPN0=;
 b=hWSnJSh/DUmE0/xyx1yvjg+s4Q5UaiMU6hT+VQoxQb1zJ0I5U8VinqRP8Xv0mFc3m6pvIOKtRMFHcedQi/6WBBVxlwVcKQ2E1G0rM3aUjnDHnaAL27t8vOGmSOHnC3ilKKQUUXwq1Mr6D0i78BkEVlPOI0C0Igly0a+Rn2vJ76U=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH for-4.17 5/6] pci: do not disable memory decoding for devices
Date: Thu, 20 Oct 2022 11:46:48 +0200
Message-Id: <20221020094649.28667-6-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO6P123CA0011.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:338::15) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5003:EE_
X-MS-Office365-Filtering-Correlation-Id: 52381660-6420-42e6-bec5-08dab2801c6b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uyJStD2AI4yE3GZ70vKKl16j59nhd0djgGI06h4MT9GsSnOGny1yIXk8nPHEi04lAoBci8uc08Z1GScLIxWhdVqFJxEvBljgyi6d10qSIt3W3jH4BIVdaVDPDxomu5u1YBaRx63783E1Hs4No90HuADssmY6xBYBRsDuT9b/HPiB3vKWzg4MRBKTKKyuHzPjHVqgrdpPXrI8YKp4yFiPS9r1vN64e3zVfQJC0iKdzD9/FXoouyAFJTyd7uSxzH+aHwyJ5D0GaH10DgFhi4VcLa35SwnsioKrnrzs+rlXLcP0GEov8QldH0Z7MoQDjAbo85nQhrqvhbx7EqKIWJ+CSfKMKBeO8/tDSbiYJ/Hn/O/TMNRFxzfq8r0Rac/om5GA8bBkz5jTyX+eCj8sZx54DjutA/ytggm1MJ3CwinIwTuUZgViJu4BK0PloH8gJ9OYj4WmorkpUEDYnnsw/o4FTJ2zcTM1srWQruWT0fAdAL6wuv/5uqvcjsJ0kprdxfzkrilTZ4fMu4uV5Vj+WsB3vxEkHZlf0UaiAKz7J6FqDAdaGnTrXf2UbzSuna5iQm1/uwf+tuZTaVBCS+bdqfnWqaJkUtohHeHIloK94gcYfru74ez4uJHN9ZCqbyzeO6lVhas4aDjKk6PJKnET6zsra37cBBudgTf6HheaamlPLEbA7J9Uf2FeFWFcg6BbAx/TEu4poK/CjQP9gQpppJqQUA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199015)(6666004)(41300700001)(6512007)(8936002)(6506007)(6486002)(478600001)(54906003)(4326008)(6916009)(8676002)(36756003)(186003)(86362001)(1076003)(66476007)(38100700002)(82960400001)(2616005)(26005)(83380400001)(316002)(66946007)(2906002)(5660300002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZE14VlIvMmF1ZTlSOHdGdWNzQk5rL2FPSUkrUlpNWGFFUGkzd2NGYWIza0o5?=
 =?utf-8?B?UW4yaWRiWmpxVDVtZjk5TVovZjdKRlhlQlJLNjVZcDcxZjBqeE5qcnRkRjR2?=
 =?utf-8?B?WE0xMjBPLzdwZmJyeWRRTXZrTlNQVE1SUWk0STY2ZmFWRE4reGI2ZmhiMnhC?=
 =?utf-8?B?WXNOR0Ryb1lQZjR0eTFoSTlXNElwUzZjaXM1QzdibFduajBTYzU4Ti8zLzJ4?=
 =?utf-8?B?VS8weWUyZEZMaTlFZDFvUTV1NTMxN2FMUjdvZW1iWG95RmJtNDBsNExVQVBE?=
 =?utf-8?B?MWsvNTZBWWFWeEhyYlpTUG9FaVprQ2tiRjhpMWxad2E0bXBkUXIzZE14UnRm?=
 =?utf-8?B?blFESkkzUHU1OGt0cFhpYUtBK0xqMVI5T0ordWJTRTZOOTJnc2hOempsVFVB?=
 =?utf-8?B?MEl2MkZ1anYxM0xzdkpyQ09nVHpjenVWSnBjdytJWm02VFV1cFE2TGdndmxU?=
 =?utf-8?B?YWI0dTd4VG9HU016NDBKZTRmamdmQjc3TnJlMDIrSkdnZTdEZ2IyZXUvaU14?=
 =?utf-8?B?OTYxVVNlRkU5QVhEeTNKL0IyM1pBNVJvMURUTFVmS1I4QnkwSkNEMWQ3cnVS?=
 =?utf-8?B?cUdXZTVPd3VnaitCVFBCdXF5WHkwcVdYTWdIWnlCTWRhSmFkcnZVb2pMaFMx?=
 =?utf-8?B?d2FiS09ycHdmTlhObXMzaUpGZjdIZFc1dUcxMGNQcUl0K3ZWK1YybGlWcnRC?=
 =?utf-8?B?c1RPYWJZQVBPWTlPMlVCdFkwSzJJaHpjVHZyZzFIVVRpa3p5SlZzcFpialVB?=
 =?utf-8?B?RFFDUEl0bHBERDhhWkdCaTlUUVhIejRKSGx4L25PRlVlSTNmQnIwRmdrbGNG?=
 =?utf-8?B?R1h1Y0V6NWNWQlBLR1c3bW9IMnh0VlY0aVo3VHlpbWQyYzRvQVBDYXl5S1Nz?=
 =?utf-8?B?YWQxY3ZiTzJ5K1JockpMdFlMWktCZjJXRnl3d3BTVWorVGNRa21wQU9Qc1dX?=
 =?utf-8?B?WlI0c0ZaemRTK3oweWJlV1ZEa2tQZUxYbjF4YWM3Qm9vem54UzJxK1BpelRI?=
 =?utf-8?B?d3p4NVNkNUV2Z0tKQ1FES1R6dmhPS1pJa212bllvZGNRc1ZYa0dvSGpQN2Uw?=
 =?utf-8?B?eVVRSXhIN0s1T1hNTXNHQVVqT29yU21LeG5NZlQvZ2lMWmRzQlFIRGN4NkJT?=
 =?utf-8?B?aTh6d2VyNVJwVzlaSmZNVU45S0FKLzl3ckdENm9oVWlMQVZWeUlrZ2RhTzN2?=
 =?utf-8?B?bTFjWE43V3pUVEt3WE5xeDNnY3R6Z0xCTzR4aEl0VVhiU3hscEgvNFRBWHQ4?=
 =?utf-8?B?MHg3dEhnM1ptUi80ZHdINGw2MFlSQlBpOFVzNUZ6OGQwOTFoZ3FEN0VOZGdM?=
 =?utf-8?B?RlNFWmhaTVo3d2o3TU1hbmo4T0VwMEF0VzVkU3JlMUhMOUVLZWQ4UmlBekVz?=
 =?utf-8?B?dFBNOHV3eXR2alRFRlIzd2FwL3VBcE16QmlPNUwwb0Y1a0ptTHByV0x0N1FF?=
 =?utf-8?B?S293ZzV4VHdBUDNJQW94eFYrdklibWhaWXdPY3NwQ2tDYXAxZ29TS0VuWWJ3?=
 =?utf-8?B?aUdWUnhuN0M2M3NqU29kVWt6NjhZRWRWblR0YW1tNnZ3dzR4RVkvS3hoLzJl?=
 =?utf-8?B?VHY4OWk4dWU1Qm1rR0lCYlFsNysveE1IZUNJZkV6WmxDdEg3U0FpNHUvazNZ?=
 =?utf-8?B?RFZJK3ZURlhqVGxTRXVuTHFtMXZ4QmYxbzRFY0hyRk95WFNKbW5WMDNFZnlw?=
 =?utf-8?B?OFV0RCtyWWNUbzBjZUVrQmM2SUlRYUMvN3hjSmlrQ1hBMFdiMGptUm8yQTBW?=
 =?utf-8?B?U0lmS3RFWnMybnhpNDI1WC9rOE5tZS90eFFibTNNbXlpYmpLMU9EUW9Sa25S?=
 =?utf-8?B?aTZqSjBuZjFrQkFsTXBvVFpQYkNjNnpRTnpzYjBNc1hpaFgvbEN4RGdMK0w5?=
 =?utf-8?B?cFFNR2tYV0tpdUVramdsbTIvTHBmeC9SRWtUc2dvc1RNbjFMSUZjZ1krZkwz?=
 =?utf-8?B?OGlYVi9RZ0greHFMaWZWWExleFhIZldEU0FZMCtJM0VnS1dIdTZPb3F5b1VK?=
 =?utf-8?B?dEt5bWN4eG9EVUV2NU9Fd0JMOTMrMnVRS2pNdEsvUHZGV2FSY2xNbE1iQTZB?=
 =?utf-8?B?dXBGTHFYdDJHL1BzclJvdUhkZ281UmtjWXk1KzJ6YjhSdlFMSTIwUDhLdllT?=
 =?utf-8?Q?uIV7jcG98J+pqU2y3qSYDQLAa?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52381660-6420-42e6-bec5-08dab2801c6b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:33.1539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /4gznc2WFS4AHSZ/JBKcm58c/OcN5PINwncwcO9OmCVXFQi0RZqzYBINZ6TI/g+unO/cl1rdp8oY7PCNM5dcNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5003

Commit 75cc460a1b added checks to ensure the position of the BARs from
PCI devices don't overlap with regions defined on the memory map.
When there's a collision memory decoding is left disabled for the
device, assuming that dom0 will reposition the BAR if necessary and
enable memory decoding.

While this would be the case for devices being used by dom0, devices
being used by the firmware itself that have no driver would usually be
left with memory decoding disabled by dom0 if that's the state dom0
found them in, and thus firmware trying to make use of them will not
function correctly.

The initial intent of 75cc460a1b was to prevent vPCI from creating
MMIO mappings on the dom0 p2m over regions that would otherwise
already have mappings established.  It's my view now that we likely
went too far with 75cc460a1b, and Xen disabling memory decoding of
devices (as buggy as they might be) is harmful, and reduces the set of
hardware on which Xen works.

This commits reverts most of 75cc460a1b, and instead adds checks to
vPCI in order to prevent misplaced BARs from being added to the
hardware domain p2m.  Signaling on whether BARs are mapped is tracked
in the vpci structure, so that misplaced BARs are not mapped, and thus
Xen won't attempt to unmap them when memory decoding is disabled.

This restores the behavior of Xen for PV dom0 to the state it was
previous to 75cc460a1b, while also introducing a more contained fix
for the vPCI BAR mapping issues.

Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
AT Citrix we have a system with a device with the following BARs:

BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
BAR [0, 0x1fff] -> not positioned, outside host bridge window

And memory decoding enabled by the firmware.  With the current code
(or any of the previous fix proposals), Xen would still disable memory
decoding for the device, and the system will freeze when attempting to
set EFI vars.

I'm afraid the best solution to avoid regressions caused by 75cc460a1b
is the proposal here.
---
 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 22 ++++++++++-
 2 files changed, 20 insertions(+), 71 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 149f68bb6e..b42acb8d7c 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -233,9 +233,6 @@ static void check_pdev(const struct pci_dev *pdev)
      PCI_STATUS_REC_TARGET_ABORT | PCI_STATUS_REC_MASTER_ABORT | \
      PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)
     u16 val;
-    unsigned int nbars = 0, rom_pos = 0, i;
-    static const char warn[] = XENLOG_WARNING
-        "%pp disabled: %sBAR [%#lx, %#lx] overlaps with memory map\n";
 
     if ( command_mask )
     {
@@ -254,8 +251,6 @@ static void check_pdev(const struct pci_dev *pdev)
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_BRIDGE:
-        nbars = PCI_HEADER_BRIDGE_NR_BARS;
-        rom_pos = PCI_ROM_ADDRESS1;
         if ( !bridge_ctl_mask )
             break;
         val = pci_conf_read16(pdev->sbdf, PCI_BRIDGE_CONTROL);
@@ -272,75 +267,11 @@ static void check_pdev(const struct pci_dev *pdev)
         }
         break;
 
-    case PCI_HEADER_TYPE_NORMAL:
-        nbars = PCI_HEADER_NORMAL_NR_BARS;
-        rom_pos = PCI_ROM_ADDRESS;
-        break;
-
     case PCI_HEADER_TYPE_CARDBUS:
         /* TODO */
         break;
     }
 #undef PCI_STATUS_CHECK
-
-    /* Check if BARs overlap with other memory regions. */
-    val = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
-    if ( !(val & PCI_COMMAND_MEMORY) || pdev->ignore_bars )
-        return;
-
-    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val & ~PCI_COMMAND_MEMORY);
-    for ( i = 0; i < nbars; )
-    {
-        uint64_t addr, size;
-        unsigned int reg = PCI_BASE_ADDRESS_0 + i * 4;
-        int rc = 1;
-
-        if ( (pci_conf_read32(pdev->sbdf, reg) & PCI_BASE_ADDRESS_SPACE) !=
-             PCI_BASE_ADDRESS_SPACE_MEMORY )
-            goto next;
-
-        rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size,
-                              (i == nbars - 1) ? PCI_BAR_LAST : 0);
-        if ( rc < 0 )
-            /* Unable to size, better leave memory decoding disabled. */
-            return;
-        if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr),
-                                    maddr_to_mfn(addr + size - 1)) )
-        {
-            /*
-             * Return without enabling memory decoding if BAR position is not
-             * in IO suitable memory. Let the hardware domain re-position the
-             * BAR.
-             */
-            printk(warn,
-                   &pdev->sbdf, "", PFN_DOWN(addr), PFN_DOWN(addr + size - 1));
-            return;
-        }
-
- next:
-        ASSERT(rc > 0);
-        i += rc;
-    }
-
-    if ( rom_pos &&
-         (pci_conf_read32(pdev->sbdf, rom_pos) & PCI_ROM_ADDRESS_ENABLE) )
-    {
-        uint64_t addr, size;
-        int rc = pci_size_mem_bar(pdev->sbdf, rom_pos, &addr, &size,
-                                  PCI_BAR_ROM);
-
-        if ( rc < 0 )
-            return;
-        if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr),
-                                    maddr_to_mfn(addr + size - 1)) )
-        {
-            printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr),
-                   PFN_DOWN(addr + size - 1));
-            return;
-        }
-    }
-
-    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val);
 }
 
 static void apply_quirks(struct pci_dev *pdev)
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index eb9219a49a..4d7f8f4a30 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -121,7 +121,9 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
         }
 
         if ( !rom_only &&
-             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
+             (bar->type != VPCI_BAR_ROM || header->rom_enabled) &&
+             pci_check_bar(pdev, _mfn(PFN_DOWN(bar->addr)),
+                           _mfn(PFN_DOWN(bar->addr + bar->size - 1))) )
             bar->enabled = map;
     }
 
@@ -234,9 +236,25 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 
         if ( !MAPPABLE_BAR(bar) ||
              (rom_only ? bar->type != VPCI_BAR_ROM
-                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
+                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ||
+             /* Skip BARs already in the requested state. */
+             bar->enabled == !!(cmd & PCI_COMMAND_MEMORY) )
             continue;
 
+        /*
+         * Only do BAR position checks for the hardware domain, for guests it's
+         * assumed that the hardware domain has changed the position of any
+         * problematic BARs.
+         */
+        if ( is_hardware_domain(pdev->domain) &&
+             !pci_check_bar(pdev, _mfn(start), _mfn(end)) )
+        {
+            printk(XENLOG_G_WARNING
+                   "%pp: not mapping BAR [%lx, %lx] invalid position\n",
+                   &pdev->sbdf, start, end);
+            continue;
+        }
+
         rc = rangeset_add_range(mem, start, end);
         if ( rc )
         {
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:47:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:47:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426340.674749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9R-0003Rv-Rs; Thu, 20 Oct 2022 09:47:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426340.674749; Thu, 20 Oct 2022 09:47:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olS9R-0003Qm-Kx; Thu, 20 Oct 2022 09:47:45 +0000
Received: by outflank-mailman (input) for mailman id 426340;
 Thu, 20 Oct 2022 09:47:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olS9P-0001OM-H0
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:47:43 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3db54171-505c-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:47:42 +0200 (CEST)
Received: from mail-sn1anam02lp2043.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:47:39 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM6PR03MB5003.namprd03.prod.outlook.com (2603:10b6:5:1e7::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Thu, 20 Oct
 2022 09:47:38 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:47:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3db54171-505c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259262;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=CW2Sjpzu+EEGZpXFIVYipeQNHkgG59ttaeRSs3lrE/g=;
  b=c2Xbyv/S7A1T+mKZu+VnK2Gu/JE+oeZP3u03hKehieRCpwnbYC7NsjwL
   iAKunzI3zfM/CHn9ZZt2fDjkYPg+flP35cqZcPzxYSHQ09fmW1zuzjjqT
   RB9n7K1l/wXugjbPXV0xTIFaUID/O1QBtD4xfee0ZwDpLBZ7RyokKaBDf
   8=;
X-IronPort-RemoteIP: 104.47.57.43
X-IronPort-MID: 85669466
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:f1ROfapG/MSzAn/xKsJYQKlFlU1eBmJiZBIvgKrLsJaIsI4StFCzt
 garIBmEM6uJNGP9e9BwOt+wp0gD6JfVz4BgTARq/ikxQXsV9JuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR5AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mr
 NNIBB8/aFe6t8Hu7569EbZVqe4AM5y+VG8fkikIITDxK98DGcqGeIOToNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ok0oti9ABM/KMEjCObd9SkUuC4
 HrP4kzyAw0ANczZwj2Amp6prr+Sw32qBNxMfFG+3uNBsFqQgVEQMhQ9dFy2/NeQsBaXRM0Kf
 iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/Qjvc4yACcsj
 1aPltaxXzh36uXJEjSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6
 2jihEADa38716bnC43TEYj7vg+R
IronPort-HdrOrdr: A9a23:rE/ohal2o5r048uXgmWY41TMPJDpDfO3imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhR4tKPTOWw1dASbsP0WKM+UyFJ8STzI5gPO
 JbAtFD4b7LfCdHZLjBkW6F+r8bqbHokZxAx92ut0uFJTsaF52IhD0JbzpzfHcGJzWvUvECZe
 ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d
 FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp
 T525RT5c9zp/AtHNNA7Z86MK2K40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd
 L6IRhliVI=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="85669466"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PbKTDR6ps1JcwFL/ihu0dhIjFZL/m/MUetodNn7mEeGkzx4MITqqBlipbLZi33s8ds6YNbhrINqqgIA43C11FdEnkM22LSH87ig283d4VyLZ71tW4CZgfhapx78IOE6QgFstXcEx9r7hIR7HkZFWx5p22Hfl8EUwmP3Ztq/Ij6IERFlgVVYwFIiYw9+PPBS55qBJZJijfgLyAnjzULoAUqmr0zU4hj2jXgVd8+I3Fjyldy/Ze1It4QZxawDSxnT8YCI6m8muantJVLrYxYsH/oUrjBSiIJoBSON3W2hv5CSmv83lbyfIHUH9Pb/nmBdWxYLn/pvncKS+rM0K2CdaGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=978VHNm8HL9oE714Wo1de7N2hjymmg8SC4PEXMhjlqM=;
 b=WytDwgb09+7FH+9KS6eKm2RmTZEDXSaVqXwaXA6vl5B3Q58EW0h2jYQFss8/koCS9MhGp7QMgsxVJY77TLWGpuX/EGcX/SIyy+QhzbeDDtwnJKs6j/6YmvPqTrSYbNghRm5aCho+jke6goQmDwqcaqSy1y4k3hcAVIW/Yg/2fjVGMdTpxV/dB1P62s40Ax12Fw3DplSv9JpyOpEs0wrPJElrti2PcIiXDXp4eBpXm/tQ1ZiIQt7BcUYdYBuJuk1ZiUqVSxrrGBHR9kO+05VAARsYeQZAvrgtZOdRTyIaKqm41NVlOs71bFWvA3QSj15roSCaxleDj0DWqTICGjay2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=978VHNm8HL9oE714Wo1de7N2hjymmg8SC4PEXMhjlqM=;
 b=p6jYpCGjkYoZ8WKlZhMYiJM3u4h/x0VlVA0I8ASPoRnDibZDTPr+NNEYaSqqqjstwifdTsaJETkwrtGE8wdASHm2+JfNrD9zNGM9HNMUp2o+VpYTSSpd5TvWU1NhXKEHUdFXu2yKUSQbK47TVH7jFk9WZ+dpcGNyA/YtWblMjKc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH for-4.17 6/6] vpci: refuse BAR writes only if the BAR is mapped
Date: Thu, 20 Oct 2022 11:46:49 +0200
Message-Id: <20221020094649.28667-7-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0115.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB5003:EE_
X-MS-Office365-Filtering-Correlation-Id: 778ec23d-40d9-47cf-f873-08dab2801f6d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5y+vkFWCOT/9Gxr51dmne/8q3Ly+4u92aF6lTTBk36oKt8L0UKwHrmB/cRWLtCVYOuKp7YSRWfEogkeXtKGEdcbJle/Iz+lp3TzZeoctCB6ycitItSBLyOZ+B4RBfGwYwwGAaxabPbOIcRBVgCT/YABNsBX0JSkTcOLcbqCr+bZluv5qrD03leCghcVLHgsBD4Fp5TDBSPNMV37U7RSdeWBv6H9orDqzZZF2R+hTuUdJs/8Q9eneLbek3a1aVLPD0SZnQEoMgjgM2qL/Dr/E1KrygcytOLt0MFJV2a8vJeX7Dbt9ROJGQFNWA2/4knehKfKhjiOoabYaOHDgUC2MEqxWC43HjgNFJYhKlx/EifXqRYNxPm3+jp3gjU9ZCQEkpcTt/EugEykXR1LsmmczQ7uqkStJG+7I7WYo9xjyHF7BtIj8KlcOObB4b4bqlBCaIlntKZAtx0AMp6YvsUDh6SnLe5Fga1qmKdBU0qZif6J5LoCIJWRRV9v8b8lc39S0SPcfjOx5SFN+4JBq0H4/pe+PPQyPPZhtt/aB0J2ftZfntLjSIc+UGeRJ6Bs/70ZKOEfxgXRhseL0ExjE5IyxR9y1FWwaxynXi2wbvZBt9pbQrzi4W3MCffAjPEQ0ep0iRxAEl9aUIwHTAT54j8EAh/qteGw8nFs13rhEmc9DUqoTe0Pi+B82MVzZgKRF2wb+62iywc3e/grMaGjiVjaCdg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199015)(6666004)(41300700001)(6512007)(107886003)(8936002)(6506007)(6486002)(478600001)(4326008)(6916009)(8676002)(36756003)(186003)(86362001)(1076003)(66476007)(38100700002)(82960400001)(2616005)(26005)(83380400001)(316002)(66946007)(2906002)(5660300002)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?alZkZWRnbWs5R0NRNS90b2w1Z0JqRE9DdFhZczU4MUg1SjNSNnFwSGp1ejNq?=
 =?utf-8?B?clUyb1d3cndvRFZ5bDk5WmlsK29iWUlGTDQxQkQ4WGdjTllNSnNGbjFjcVhu?=
 =?utf-8?B?ekphUHVvSUtQNmZJUTJHSHJqZmE0bHRGNWU5WjAyRGVuYWJwai9DTlh1SENO?=
 =?utf-8?B?a1AxOTFSdElzbko1bXM1ZUpXbWwwTittOS9PWW9lYWVBdEloZk9kSlN0eVlo?=
 =?utf-8?B?Zld3dFZ5UE01bFpuK1dneFd5WC91eFFsYUdpNG1yZGoweXVMdEhqT2xoMlBO?=
 =?utf-8?B?VXpiSVEva3pHZWlzUW1QQWxhVmZMVlRLQmhSbVhxVVdCWTdXLzhOeGRGNUxR?=
 =?utf-8?B?a1g2WEJMVkY1UlpkbmRnQ2FTY0twTzBOR052RS9Ka1NDMEtzam1UQTRqNDBl?=
 =?utf-8?B?UEZXTEZkL0h6b0RkeGxRbkpRVDM0OVVsY2tUL3hMcVF5a21lS1FQVEwrc3Ny?=
 =?utf-8?B?Z25HN2x3MXBhVGhycXlLeWJNeXNFRGZ3dTNocEd5dlpud0VyTVVEQm8rYXNV?=
 =?utf-8?B?QlB4MExrTHF6dTV5T1JkZS9rOU5FVS9TK053NjZJR1dVZHNNbEd0c3JWeENT?=
 =?utf-8?B?OUZTZ2JSZDFNd1VaV21QUzRQdEFIcDhGUVVzNHR0bTd0cHlBZlY4MTNyQnlV?=
 =?utf-8?B?MkZFazZyaElBWVFZL1l6MlNlODZWU3VrbFBlYzZtcGtjcVZFOTVvM2tycDR3?=
 =?utf-8?B?a1FEWmJlYkhha2ordG54V1I1WjF1WWhJRktaeXBpU0hiSk90SUtacDNnQ2Qx?=
 =?utf-8?B?eEN4OWYreTNsUU1KaTUxTlBKdm5XZkFYVHNvbUkxSlhVZUZ4djIxQUVWVGRF?=
 =?utf-8?B?RkZMbXhKZzRTQm82NmZhRkQyUWhUeFJhcU9rWlcrZVdzN3ZBZGRIRDNURWRU?=
 =?utf-8?B?TCtsQnlwUG9KbndhemVDTE1TRlpjWklYT1h4VFBkSDJzSUxLU256SUxHNVJm?=
 =?utf-8?B?dFV3V0dNTkxhaW1zY0EzOEV6WlFQQndNT1p2MDZkeDJ3bHB2L1k5bnZJNXpU?=
 =?utf-8?B?R2JXZXMrSVRzOWx5ZFRnWlhRYjVnai9UZWtPdTIra1VPbkFjMlRkZmhxMkZl?=
 =?utf-8?B?bUx3QnY0bk90SmRqbi9kcnZ4YUxVRHBWWlNXZVdCbjMzUGRJeDBZSWpNZEVV?=
 =?utf-8?B?Nm8yUlJPWFhhZGk1S25WaUxBSXBPN21RL1BHVEdIbmViQ2pqQU5OK2N6MWht?=
 =?utf-8?B?SnJVamhWWFZBSm44NjR5R1JtZE9DRVRHdmRyRHc4NDd2aE82VjRXVklkQ0Vq?=
 =?utf-8?B?SDluZ0F2bHFmOXlQVGcvUFRoSkl4SmdsU1FhQTJUOTk1L1NsMDJQaE9xZWxL?=
 =?utf-8?B?eWNRNktaN0tteEJoQk9xZ1hOWjBucDdPYk8vK3NzaStDYlAyVlQvdmoxZDZD?=
 =?utf-8?B?Mm9IQkw2RFFxU3hheFAvNDBmQkt3ZU1SVFhKbDlaT0J3VmdkaDlKSHJDMDFS?=
 =?utf-8?B?RzBKOXJHdVFMZncrVEpVdW4ybDYvOWM0TUdaT0tBWVplNVNxcGx0TWpQbjFs?=
 =?utf-8?B?WnBaNVp2UkpIMkFxWnB2dlhFZ1R0bVhETnMyV2xBSXZ3K1lMSEtxK1MxNkVB?=
 =?utf-8?B?ZXpZWEpHNHpGcFgzOEJzMk5ZMlRRVUNLUHF5dWZHT0pJYjBiSlNtbVhmOXhy?=
 =?utf-8?B?VU5LaG1FWC82VEx0Z0pucnNnak9vWjNMZE5zNEZjQWhkaEloSVBDeDBaMmMw?=
 =?utf-8?B?aWRXV2pmUm8xSFFNcjVtMjV6SDlOWUY1dnZRc2tDS0VLNU9TQ3VzaXNsbFhU?=
 =?utf-8?B?ZFIzT1AvNWZibVZXTWZZSHBZZUFaVGZNOEU2b3FOM2IzUXYzZjV5RHoyMnl5?=
 =?utf-8?B?YVFhcmdEaUphK2pKNUlaTGI1N0J6dm1wemFHT1c3TFZvWk1vb3BXZWxraVd5?=
 =?utf-8?B?cEtBWHdXTnpHZm96MjU2YlQ2ZExIaXhPQmtHeXhBdGpjU1ZIQS84ajl3NkpX?=
 =?utf-8?B?K2dQV1EzRG94ZmJBWXBwcXZGQjZjY0ZROUs4Q1VxNGZLSHc3Qi9CcVIrNWhI?=
 =?utf-8?B?ZldRNWpKWFZKSzV6RFd6NTNhK2NKUWdqN2J3N1hNM0I2OU51V1hMV3Z6d0Y2?=
 =?utf-8?B?QmQ4c1JQRzYxMmY4VzkzZmQvalhsYUtMYTVidGk1SGo2Mk03b1ltN0tvZUoz?=
 =?utf-8?Q?3q6/x0tbzT372+KGkqXMRaz2U?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 778ec23d-40d9-47cf-f873-08dab2801f6d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 09:47:38.1548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g780mqa9nZWzkJC/j/dTr0mxyGd9O5vTTS1ETmOuskuS+SLJxUIDgwlSC3cfQC9NCZ14Crb2OXNW7rHjqUD9RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5003

Writes to the BARs are ignored if memory decoding is enabled for the
device, and the same happen with ROM BARs if the write is an attempt
to change the position of the BAR without disabling it first.

The reason of ignoring such writes is a limitation in Xen, as it would
need to unmap the BAR, change the address, and remap the BAR at the
new position, which the current logic doesn't support.

Some devices however seem to have the memory decoding bit hardcoded to
enabled, and attempts to disable it don't get reflected on the
command register.

This causes issues for well behaved guests that disable memory
decoding and then try to size the BARs, as vPCI will think memory
decoding is still enabled and ignore the write.

Since vPCI doesn't explicitly care about whether the memory decoding
bit is disabled as long as the BAR is not mapped in the guest p2m use
the information in the vpci_bar to check whether the BAR is mapped,
and refuse writes only based on that information.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/vpci/header.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 4d7f8f4a30..4b39737b76 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -388,7 +388,7 @@ static void cf_check bar_write(
     else
         val &= PCI_BASE_ADDRESS_MEM_MASK;
 
-    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
+    if ( bar->enabled )
     {
         /* If the value written is the current one avoid printing a warning. */
         if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
@@ -425,7 +425,7 @@ static void cf_check rom_write(
     uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
     bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
 
-    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
+    if ( rom->enabled && new_enabled )
     {
         gprintk(XENLOG_WARNING,
                 "%pp: ignored ROM BAR write with memory decoding enabled\n",
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 09:57:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 09:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426373.674759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSIx-0006Hp-VF; Thu, 20 Oct 2022 09:57:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426373.674759; Thu, 20 Oct 2022 09:57:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSIx-0006Hi-Sc; Thu, 20 Oct 2022 09:57:35 +0000
Received: by outflank-mailman (input) for mailman id 426373;
 Thu, 20 Oct 2022 09:57:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3+B4=2V=citrix.com=prvs=285f10a64=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olSIw-0006Hc-F3
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 09:57:34 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d0685e8-505d-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 11:57:32 +0200 (CEST)
Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 05:57:30 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DS7PR03MB5477.namprd03.prod.outlook.com (2603:10b6:5:2c4::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 09:57:26 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 09:57:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d0685e8-505d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666259852;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=XsioKsCG4Kwr3mwXn/CwG2Bxa6fJuAR026roc6JWHw0=;
  b=hGrVTRBWQJb+xyh/yd7ffTNNPJe7/XdayAgzQwYKT89s1LZLQq+PPKZF
   U8yks1JMM1pCol/9/p6mvFa/3/iIzXgNrXnuydLBHuLJktosC12UUVp3r
   qhKTKX2/jBQ4tJtKOaX3tltUe+AJgVQanBg7wqO+8LFewG9nMiiPZyOOi
   I=;
X-IronPort-RemoteIP: 104.47.55.173
X-IronPort-MID: 85669954
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:HfKLj6nIZjlTgv5bEHFp+mTo5gyUJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJMDGmBbq7cYjDyfNlxOoXg/UlQ7JTdyoQyHARppH9hECMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkPagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfXG8J0
 7tAeTY3RzOmvLy1/KqiTugvv5F2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1cZPLvFabI5fvSjQ8lPk1nej
 WXB52njWTkRNcCFyCrD+XWp7gPKtXOmBtxDReDknhJsqAaT/z0+VyAab3yAs/KTrlSUQNYCO
 kNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ5sOcmSDps0
 UWG9+4FHhRqubyRDHibprGdqGroPTBPdDBZIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w
 HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCTJuLpzm07hl6Y0z4=
IronPort-HdrOrdr: A9a23:wzZPHaFQCAD9IETrpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp
 uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf
 +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2
 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq
 iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe
 ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO
 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46
 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ
 HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8
 o=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="85669954"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gyM7hwX7DjMaw7GkVl1v24rOcvf+gL3SNXiK6xrtLGM5nVmPAwTM6ZD+W7eddI4CkatzSWHp3Jx4E5kkbJTder3BMiNXPOw/Mk445AyuDcSMS7GLCsSOaoPlgzTE7dd+L8stov3RtQIezU8OqNhRPJ+qZ9Xup9eVfAYpW+/VZsus1IR8pVzHv2eL+CXAcNZm04H4zbAXvTEHE766LfLjS5Fz/WGrbrgYAMEvzw6aLsuq2fV/Ygm0fOVHn3kPBy99dofCbP4nPq+Y3eBDEQMjVwzOf/n7zCpvzmXZ0VJcDmdri4pwlgDn6wrZeSGJjBt/lacAAEIwcAp6fWf+y1LuVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XsioKsCG4Kwr3mwXn/CwG2Bxa6fJuAR026roc6JWHw0=;
 b=Hm0Kq9il9NTFCjxNeUkWbD97f3tPaSgJ5O5Cjx51NG57lPcvFYKWBRR291OB+S47bgobYU3tYBDKKxwqq79jKg3CzugJJkg5ch68JxO91oMg30Up/OvcR3g5gx+23BAHy3jVUQ3lqpLb3MnSt4DQhcUV8IFyikplX4U+PzmBDf0jZVjYSE5NkgeN5FQ/PZbvPmOA7yqVwD3pKhvgxHzhHf72nRIhvs0lcbPTglEMmJQepg20kwpCdV65mRjkHOeHHVfn868kxajyGh1o8ylUuxCRq4m8Fp8/Fih1gdC3+n/uNbqIGTuP7Fs+2QOoctHNPeGLP+zVpqZsp/glD1Uf5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XsioKsCG4Kwr3mwXn/CwG2Bxa6fJuAR026roc6JWHw0=;
 b=S1s/kZpkKMfMKt5UOmp0edRQr/dxe2rXi0dZlE27zR2EYBafkwF9Ct8iz15MK7a7ijmMHHExZfpPI+890yu7ZKZ97EZs2pWLm9ZFEXXlP5acxi1ius4f82JuJ0P8BDIl6T6YV+5Cj4mul0b1+eD9gdJp+J2mKwGkDooH8YllO5k=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define
Thread-Topic: [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define
Thread-Index: AQHY5Gj3NrHn8HwTAE6Wstyf2zkCg64XC+OA
Date: Thu, 20 Oct 2022 09:57:26 +0000
Message-ID: <93b6bfd9-729d-74b4-d4a6-21286074fe8f@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-2-roger.pau@citrix.com>
In-Reply-To: <20221020094649.28667-2-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5477:EE_
x-ms-office365-filtering-correlation-id: 425e0aa8-17b3-48cc-915c-08dab2817e21
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 OVXU7tIXliBeFKOgZ5krawkxpaG93DsXUT3ZtwFEqqJzPd3qqpfOJCG9cA4lWdjc4Gp9TCF+FXk3C8EvhZUBMN7eniZkxAUwie12SZ4ge+0nZcYFkeimblZzvFMOcA0GgVRdNFSZ0a6nrWm3c6MR+xEXfJVhjFNBYzrD+AME04gD/kRbdFIgrckjvnT+XO28kXp33EnstLUX40huKEQSpM+Je6V9Bm1VEM9zRjSay1qP3QXerIktcU3KGF4YBUlbuDQHRPSeQHaO2FDWVDteom3wRUTPp3GMv0917WGpPxV2nl1jP5VhPcW6x79HwM1//jxEhs6hhZ3t35qhq6znnmb01sKpjWiKz4dNjdoyw+n15uMvb/q5X7ogiP4oQJOHiPjqJwKyifVQHblNZ6BQeM8p0cDDTp+LdrLKTIM+ewG+WHfPtsEvFUTozLHIjYgjqDSK8WuzpTZTVtzBLgWRjyforNYMdI+EV5fXHHY/khPbfNl4QJqo9ohoQId6WxGBi1t5gdxnZmKq3lWRKbCrX3z2TwHWm+8op5kHNRzmciyzU+oa9Wdac+w1ZmOjqq7XwUvCb+d03WV39YFs6lUXyUecW60ea4rluGMtNBaId5v38es3BYJMfx+KD6C0r5V9VITMEMwVSd/tmF/I81HLlhGgP+gPhVhvovka/bpJubxnBUZuGF/JEE1GT1l1MyPW4vZzOIuoBdMREkJupr7HuI4o41deHOTDH8L8uuND8jurS8sCtaU/Mo5NR7nlUotaaz+HWxUXntFciS5QZjIv7BpRD67RD5GJhU6qU+bgXSRCiY/m+ED/xxs7YpISw9286DeqHoosXNKSzSB0kQox6A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(396003)(366004)(136003)(451199015)(186003)(2616005)(31686004)(107886003)(71200400001)(2906002)(4744005)(122000001)(38070700005)(36756003)(86362001)(31696002)(82960400001)(38100700002)(6512007)(83380400001)(6506007)(53546011)(26005)(66946007)(316002)(41300700001)(478600001)(66556008)(66476007)(66446008)(64756008)(8676002)(4326008)(76116006)(6486002)(110136005)(54906003)(91956017)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VWc0SXNSTTFZT2hTVkJHNnBKc3ZsM0c3bFJHakovSTZuUXo1Tk9yUXQweWJ3?=
 =?utf-8?B?dDhZdkE4YzR1OEVmSTd3YTNpMGtBdU13MWxtaFpDMlZIazhsRGF6WEhOelhN?=
 =?utf-8?B?Slk3RktlREYyNlI0QXphR0RDaVRFRWk4dzVDVzBmcWFZYWtwTXI3ZkljSjBQ?=
 =?utf-8?B?RER3emQ4Tks0WHROZFhMWWx2cW9hVjc4UU9QZkd2cmVFVzBnbUs2Z05lTGla?=
 =?utf-8?B?bGJSV2xOa1hCSENGekJNc3RtWG8xVHF5MWMxWHZDbnlUNWd5WURuZlJldWNV?=
 =?utf-8?B?b0RJdXVBUGFLV1N5NDFKbEUrL1RqUjI1MU5TLzM0clpHdFpvd0wxVC9JcEhz?=
 =?utf-8?B?d1JBSDNTeE4yaW4ybnlwakR0dVBRTVJBYXo3NWRUVm9zUDByRkZScEF5Yk1V?=
 =?utf-8?B?ZEQ3NXZHNFpZWDVpQ3RIVy9hdFFnMUkvbDNVM1ZqZEltYkI1QnV3TVgzMHFs?=
 =?utf-8?B?RGFpT0R1elBUaGh4Z1ppREloL25DcG04aExtLzNHdVJLVHFQTGFyZ1RCNklE?=
 =?utf-8?B?MEQ2VGVyTmk0c1RuSFdrNW9XUnk0VUF0bWFQREMybmpia3k1RnFiTm9NMytG?=
 =?utf-8?B?TDhmUXh6djU3V2dsU3hhemJPa1pqSEMxaFd6VkJFWFhZMnd2Y0NVbndrZkVQ?=
 =?utf-8?B?dkRXZjA4VXZieU9VUFltNnMwTFZWbFBwU3FKNWFmaFpZMnkvRHFGeTg1QmpZ?=
 =?utf-8?B?b1FUMXloSGoyODJ3NzJ1dmpSM2xnQmpITktQQ0VkL2FyQ080K3QvcUVHY1Zu?=
 =?utf-8?B?SGg2WHJhNFNvM2daU3V0YW9iRVJIMjVHUy80NzFDamwzU0wycHFHRWJDVncz?=
 =?utf-8?B?M3BML01QaVE5SGVxalJJYjRVWTRwTEhHQnlTNG1KNkl6eWs5bmNJY2x6T3hy?=
 =?utf-8?B?THZBNHdGNTZtRkYwYm9yVm9KclRNNHNUTUh0NUlKV2ZNVUR3eE5TbnBuRGVL?=
 =?utf-8?B?NldIejlzeFJjaHNPSUhGMXFDcjFjUG53eGFWUFlXYWthN3FOLzh1V1ZRTWZh?=
 =?utf-8?B?Tzk5TnZ0UmhscExCYmJ6Zmh4S1IrYmc2U3MxZElhM0E4ZHVraVZnRXc5UjAr?=
 =?utf-8?B?SmhIRzhVTTZ6Y1J4VGFKMk5oTVZ2SUNHSXpubTFSdXpYME1LMThGNHowaEVE?=
 =?utf-8?B?SDBhRkIzSXhVbXB0LzRVVHVXd1J0bkg5enNGb3VkcmxiQWVLN1p0R1pLakhE?=
 =?utf-8?B?YW5waUFURCtMTjl0dGdoQ0h3NUxhbVZsUHRFZVVCZHNkbWI3cmQ3TE4xNjhq?=
 =?utf-8?B?Rkk2Z1BXbHdjUncrRi9lMWJLa2Ric0p6d2dsL3lRMEszT0xOU3FrN3c3a1pr?=
 =?utf-8?B?cExmaVM2dWVwQlZyYXdTWHhqZHBZRHdwTWJKNzNPaG95VHhURHR0Ti9UWlls?=
 =?utf-8?B?MWlnMm9rcUh1d3c2cittVUxvWFJjMDV2YXQyY0w0dXJWaTZHazJ1UXRmTzRn?=
 =?utf-8?B?UkpIMjZMYll3UzhyaHdodlZIQk9QTnVqZHN4d2kxREZYRzBBbjZ2THFiZTQv?=
 =?utf-8?B?WENDRDE4Q2poUjlwTlk2Z1dMTjhiWld2dzczbTlzc1RYN3ZUWmJoSlBsVDU2?=
 =?utf-8?B?Z0RBeFVGbGVXejExblVpby9HWjVLWkp3K2tjZ1I2T3RoeVc2Qnh5YVRCMjJF?=
 =?utf-8?B?ekFEU1RBZkNPT3hHbFVaeHNZaHRmV2JJdzJMK3d2VkU3MWVENmUzRkZTejUw?=
 =?utf-8?B?U01ua3BlYVp2WXczUzdmU0x4NDk2K20wWWZlN0ZreGIwamo5U0xmOG5pRnlM?=
 =?utf-8?B?dG9uakxhbkRodmc2bWREbkpFcjlQOXFzcm1zcXJUMGMyVFZEdU8xUWxxb1Rl?=
 =?utf-8?B?SHBleWxDRWI1djIzWDJMZSttWnRnd013SXBjVXFzYlpwQVNIbW4raGtOTnlD?=
 =?utf-8?B?OTdIWjZGMStrNFZpMHRVSTE4TDl6MUNzYUV1elR4U0tNNVhjek9GNzFYTnl4?=
 =?utf-8?B?bTRFYXVtQWExdWluTGRXWlJnS2hoR0lhU2xUWWZDcTR2bGV3M1FmamdGT2Z4?=
 =?utf-8?B?MkZHREJxdzkvRjhGaUx1MTNvaTRYa0NQNFhub01SY3Mxb3FrcXh3aHYzU3hZ?=
 =?utf-8?B?cUtaNGdBK0hqSTJGL3cwbzZIU3dOM1NwcCtvMndtd1VVVEJvU29PbEx0TTJY?=
 =?utf-8?Q?zIvWu0GFU7TYDDXVKDm2fAi9+?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <679068DD1E1CF245854B86A20267BB70@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 425e0aa8-17b3-48cc-915c-08dab2817e21
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 09:57:26.2844
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CdLG8XvsoO1K1McQkjrHCtuCDxOiIhAQAlC5RVKucDBADV/wOm/XsUuEjNULE1ogrgt892tyqQHvf/cP7Pj6LdUPn8awj+tqKhUrifUEJhM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5477

T24gMjAvMTAvMjAyMiAxMDo0NiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBTb21lIHZwY2kg
ZnVuY3Rpb25zIGdvdCB0aGUgY2ZjaGVjayBhdHRyaWJ1dGUgYWRkZWQsIGJ1dCB0aGF0J3Mgbm90
DQo+IGRlZmluZWQgaW4gdGhlIHVzZXItc3BhY2UgdGVzdCBoYXJuZXNzLCBzbyBhZGQgYSBkdW1t
eSBkZWZpbmUgaW4gb3JkZXINCj4gZm9yIHRoZSBoYXJuZXNzIHRvIGJ1aWxkLg0KPg0KPiBGaXhl
czogNGVkN2Q1NTI1ZiAoJ3hlbi92cGNpOiBDRkkgaGFyZGVuaW5nJykNCj4gU2lnbmVkLW9mZi1i
eTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQoNCkFja2VkLWJ5OiBB
bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KDQpIb3dldmVyLCBJIHRo
aW5rIHRoZXJlIHdhbnRzIHRvIGJlIGFub3RoZXIgcGF0Y2ggaW4gdGhpcyBzZXJpZXMgd2lyaW5n
DQp1cCB0aGUgdW5pdCB0ZXN0IGJ5IGRlZmF1bHQsIHNvIHdlIGRvbid0IGtlZXAgYnJlYWtpbmcg
dGhpcy4uLg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:13:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:13:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426387.674785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSXu-0000dH-Jz; Thu, 20 Oct 2022 10:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426387.674785; Thu, 20 Oct 2022 10:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSXu-0000dA-Fs; Thu, 20 Oct 2022 10:13:02 +0000
Received: by outflank-mailman (input) for mailman id 426387;
 Thu, 20 Oct 2022 10:13:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olSXs-0000cb-Sy; Thu, 20 Oct 2022 10:13:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olSXs-0004dM-RN; Thu, 20 Oct 2022 10:13:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olSXs-000350-Ev; Thu, 20 Oct 2022 10:13:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olSXs-0004fl-Dk; Thu, 20 Oct 2022 10:13:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ReOZowhbcFKBpoKbOESTDwXhlhCE54nqTIE/TS9f4UE=; b=J+Mf88YlKgMTKU4audu57UzTqT
	AjufMDSwDHLjRYO2xYpghxfwZCb1FlqIaXj9DPuNpxaIBk+qtNr4QvUkulGpeX9Wai10/ZVyQ0Dyp
	jZZ4w55BIjiCH2IKiX19KppQmWu2IZXZHlDhIBbuCfFznA70mtgVxEBhE2qzqEVBen7o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174124-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174124: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cc4747be8ba157a3b310921e9ee07fb8545aa206
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 10:13:00 +0000

flight 174124 xen-unstable-smoke real [real]
flight 174129 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174124/
http://logs.test-lab.xenproject.org/osstest/logs/174129/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 173457

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cc4747be8ba157a3b310921e9ee07fb8545aa206
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   12 days
Failing since        173492  2022-10-11 13:01:50 Z    8 days   57 attempts
Testing same since   174001  2022-10-17 15:00:30 Z    2 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 961 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:13:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:13:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426386.674775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSXr-0000NJ-B8; Thu, 20 Oct 2022 10:12:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426386.674775; Thu, 20 Oct 2022 10:12:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSXr-0000NC-8D; Thu, 20 Oct 2022 10:12:59 +0000
Received: by outflank-mailman (input) for mailman id 426386;
 Thu, 20 Oct 2022 10:12:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZuZ=2V=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olSXp-0000N6-Gt
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:12:57 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80055.outbound.protection.outlook.com [40.107.8.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c33e54ad-505f-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:12:55 +0200 (CEST)
Received: from DB8PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:10:110::25)
 by PAXPR08MB6334.eurprd08.prod.outlook.com (2603:10a6:102:dc::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 20 Oct
 2022 10:12:52 +0000
Received: from DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:110:cafe::44) by DB8PR04CA0015.outlook.office365.com
 (2603:10a6:10:110::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30 via Frontend
 Transport; Thu, 20 Oct 2022 10:12:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT012.mail.protection.outlook.com (100.127.142.126) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Thu, 20 Oct 2022 10:12:52 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Thu, 20 Oct 2022 10:12:52 +0000
Received: from 8f6c0fbdb673.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 886E33D4-7360-4062-B224-BDD0569F4209.1; 
 Thu, 20 Oct 2022 10:12:46 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8f6c0fbdb673.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 10:12:46 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 10:12:45 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 10:12:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c33e54ad-505f-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=D04oXZ1hQsA+p3GaIwUyYzSw5BY3H30zvwEkkcimHrGub/zy2tk8RugTl5oXcw7I94EY89d+3nCISqeeWH0wdxCLoB7wKFXq0SvEBycGUwov94I0Gvdqt1IUPvgTTf4X55SMFaiZ7tQ6zd3XEttccEaHj9yzRy6RAMDqbTzIRgnhRsWZwm86V5rsmWnvtgtZ41Icn4G6tcv4mReT+Iau0uehluLGTQjBsG18K8tvASkxPaoWc0eojf2kG9GgZjdQ/C6t35sdw71Gon5K2iYvP0kJYfYJ5fzTluc4qhXAs8iKoSKCySDpdJnb6RCqEN8UKrQIfuO3hENgkkRXEWqXWg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Cj4P5s/YQPJglgykj+oSMcvjBIAHOgnUdborGgmu0+0=;
 b=NyaLNtL6lOKfl8bbxB4gV1DVjHLmkvNn0FK5Zg1tj7Q4+3/L0kij+8p5V2onvo/yNn42ku8NXjpj6/JE+LHP1755bY7OPbJo+he7ZV0BCkBrRC9Cc8SF6S9MX4YqDNSBRAbhAoXu2dsTR1qU39fDQiNtIIPk2jAar2hBSUYkJY1UKDkSThmaqGG69pCY50vbQjigJVn6uClqSlt0xSXMXU8EsTTk1ahg0G9J68OhAAAofS+sP+4IVnO3rKlA4KXCM0UYdOhybn8KbLdT4wxitZf47MtU/7rbQ8QJRjLeY9PqUFW+GxbBZBNdT6fkgUNKq2Xu3qpn/67c4ApBTGxZeQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Cj4P5s/YQPJglgykj+oSMcvjBIAHOgnUdborGgmu0+0=;
 b=4xy7GUP/+KU3BPZD4LR11euzT2ERykIdJwVA9eV9fzWrZShQTe+Lo3yEDuuCtOE08PqzDdQk8K1bA5FTmdws20QxFy4OUGd3gwYd7J90WiIf870J8dblgiAJ1Pzo/Fa360rMOdKMW9vDH6ocN9Zsy5nP+sE08W9W/R+jquSxd/s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VktSi8ntBh1PDnxKC3zLqAUrqVBtALO4Wv8ycPgtRVy8MchG9AWeCFof/Awmkabb4NGeFh+SqDFgOKpL+7WrhGUh12ZWJxMlVJa8DMzYAzGoBDkS0vjMECUErw7bsR1/8g8I47Rqmk+2Oo+GVg2A9f7WW17zjESpx36XQ9K9U9b1liGXn0odzT5X8OeGp90iRJdzjL76cHcg1XsI4LCCLzQWfcqoxZJB3Ig7bh2I2zRIDvjAAxOtOaV6JPYZTJWypQMFhpPHnBVwcvfYXf0toLdZB3LThOb7pKtiCx7+oKDxPMqZAjDIyropWE6oA3YsTH4ejjfra6MmhrxvCC9IbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Cj4P5s/YQPJglgykj+oSMcvjBIAHOgnUdborGgmu0+0=;
 b=i+/juhvqih6ZaPGVmH7mXyKQPPX5cXc3I5qFOrlIGSebJwXDp728w+TiouXaMAQuv8VPibldA+Eqm92xQziecnwqnRHOl1fd7aJY+4E+HQGCQG5j3Qi2xioPOj9+TblaiowJ+OlcK8lWnHV0UETcKaMbVJjidtARIcgOZopPqJZsTXXOKU+vka41z77gljOCKTpmmZPHo1EzdktW85H54EtcpgNpNnOJgpDySSUz8Wr1tBg7nQ8ylVrgdTBMr9L1AZirUm4SQg7Q0vDj93/4wo48SIZzwMoEG6Xy69Ua67owMo49Wvd2sPE6ls3ajB1GKELXIwLTmj1NZfxgrGOXKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Cj4P5s/YQPJglgykj+oSMcvjBIAHOgnUdborGgmu0+0=;
 b=4xy7GUP/+KU3BPZD4LR11euzT2ERykIdJwVA9eV9fzWrZShQTe+Lo3yEDuuCtOE08PqzDdQk8K1bA5FTmdws20QxFy4OUGd3gwYd7J90WiIf870J8dblgiAJ1Pzo/Fa360rMOdKMW9vDH6ocN9Zsy5nP+sE08W9W/R+jquSxd/s=
From: Henry Wang <Henry.Wang@arm.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Jan
 Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>
Subject: RE: [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding
 handling
Thread-Topic: [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding
 handling
Thread-Index: AQHY5GkOCveZHX5ZBUGwhdfrTrFAqa4XD2Ag
Date: Thu, 20 Oct 2022 10:12:44 +0000
Message-ID:
 <AS8PR08MB7991CDF482A0B232C36628D0922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
In-Reply-To: <20221020094649.28667-1-roger.pau@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: FDCF0ED0873DFD44896DA35FDB1FDF21.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DBBPR08MB6091:EE_|DBAEUR03FT012:EE_|PAXPR08MB6334:EE_
X-MS-Office365-Filtering-Correlation-Id: ad9cc7fa-2d33-43c0-8dc7-08dab283a5f8
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 udrSH5KWoe3Rw3vOt3zlE9Kq408phiPBNcE62Sc9Rjlub/Gqa4lEa+fLUpv/8GRSWz/lBZ20Ga/avhzywvZ1yxvTdAK0nx8Ezh5O0SGq2tS3uYd4VXt8wfpT2nXIqUnWVmleliFdnKrEroZfQpXe/amTWkLkDNARY9h6Alhf3XTvYZEku2xDAadMRU/JwE992VSzHXDWfIkvYAESD0U4Hy6xeVsQA9/U5kk80q/TO0e+D1lbHJbdLaLaWWuFjW5jubYTvNbQ0kfpFbVbUGCyDzzO7pOxhdF468G6WW9+5xpQLadvMC7NhIFjHNim2zyu1TcVCIDxL/3cq5rdqlSIDFBIpmI+8CDfd1+cGpfdY+3cqbEnBqZ8DtIRURCyexmcQXsliKOMc3GOrDwnKB6IkTSar6wpkNu0PGovi7RwaIpSO/NY8yiTtxwmgyY2UQOsoFWXdonibQnHWLrjnIsU5SdqiT35EAJSNqwrZZilJ3m6t4jlppt5ZLWT8xHhCka659Gq2XnW+QMZDU3gKTrCjUd2w3J5xNEVGRcibiUSaoTLIrah+v273q532N9tMewz+DRDzCqAbyKHU0ERyGJwMVBeMxDM0VLVQDSYxbt6LKw/oi42jZWk9whnsTiQ4j6u2mW51ESIFNy1F0SHY3dofsmbCcLEWCv9HfYDS3tP9Mn8ECzMGZYed+4q1996gBy0L/NjzDJo52tmCE5QO63VbitUGh9jLA8UjBMOmsmEQmkZYLkij6aeuipWEYhB+BRuu5CpHK/5Tl2FwAW9a8XOTg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199015)(186003)(71200400001)(38100700002)(478600001)(38070700005)(122000001)(33656002)(54906003)(110136005)(6506007)(7696005)(41300700001)(55016003)(83380400001)(316002)(76116006)(66946007)(5660300002)(2906002)(66446008)(66476007)(66556008)(64756008)(52536014)(4326008)(8676002)(86362001)(26005)(9686003)(8936002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6091
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6bd5fdf2-edc8-4aa8-fed5-08dab283a19b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	295/FChDSEHHyVSNYlx9ARCAS328hk98rMTEncCD2AEshPiBnvhC+atwzFf+QxaLGwT+SYxSosiAn9TVCgD7KOcmEXD6BlxaADRoTQCoQ3ERen6ImrhzTRKE99AbIrbXJFeX8T5bVgxBJ63ioWzNcDArZDoBLaUFlKqYXWE4p7cF7fif6uev5QODrvk92k0SuYbarmhmORHX5yQ8tHw4XEtlB+TJ6Ez0MiKCYu5+OO8sCDKM+Y7Vc8yOQ6aSaDKP19OoqpZt/59KEF6HZcyzcHcoCtj2Y5kBhFjbcHWTy7g0FS1wUygIQ5jJjKDBPFvgdweanaYZcDDSg19rP+x4HhkZUjOFSORg65Y7wSCMiRG2zMtbRVg2l4NyeqzWFMxU5uzyU2SpwQ6+chGs8H2QVM+d6za2RZ+6PJEX5J7V3nkHXOZrjszYgCb1xqWegTjbKc1fVHWlENif4HGQIVtzQsXDuYO+6MRrV1XtO9UHbjGgCI85kJSEQGgpXP3Ul1DFhsYIiLjOxiG6RaNIlRwGVeT6uC6HAPMuJix6EdeAiJe0Rkqys02HkVhBV0Dg8BGHlmIKvX2oDZwAFMLDzC5VEeqFKUrYfnkjXubOUdCyNs8ki5Fp+IaODYBUXCupLxq/hgSdg/K/wonPDQs8mMHLp+kjmpyf9mhXYq0rLbTXWclzwyfaByI8b5T5PCkP/h5LmV0UbYbT1fV7drIMEo4iMHJHm8RVUbze5sdqdvQJ2HvvcsHRXlKDEJeuhyw93hGlfrSLzbR3tBqmo/qU9Dm4WQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(36840700001)(46966006)(40470700004)(9686003)(54906003)(8676002)(81166007)(70586007)(82740400003)(83380400001)(82310400005)(4326008)(70206006)(2906002)(356005)(36860700001)(40460700003)(33656002)(52536014)(186003)(336012)(6506007)(110136005)(26005)(86362001)(5660300002)(41300700001)(55016003)(7696005)(8936002)(47076005)(478600001)(40480700001)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 10:12:52.1336
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ad9cc7fa-2d33-43c0-8dc7-08dab283a5f8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6334

SGkgUm9nZXIsIA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFtQ
QVRDSCBmb3ItNC4xNyAwLzZdICh2KXBjaTogZml4ZXMgcmVsYXRlZCB0byBtZW1vcnkgZGVjb2Rp
bmcNCj4gaGFuZGxpbmcNCj4gDQo+IEhlbGxvLA0KPiANCj4gRmlyc3QgdHdvIHBhdGNoZXMgZml4
IHNvbWUgYnVpbGQgaXNzZXMgdGhhdCBzaG93ZWQgdXAgb24gdGhlIHZwY2kgdGVzdA0KPiBoYXJu
ZXNzLCBmb2xsb3dpbmcgcGF0Y2hlcyBhdHRlbXB0IHRvIGZpeCB0aGUgcmVncmVzc2lvbnMgY2F1
c2VkIGJ5DQo+IDc1Y2M0NjBhMWIgKCd4ZW4vcGNpOiBkZXRlY3Qgd2hlbiBCQVJzIGFyZSBub3Qg
c3VpdGFibHkgcG9zaXRpb25lZCcpIGFuZA0KPiB0aGUgbGFzdCBwYXRjaCByZWxheGVzIHRoZSBj
aGVjayBkb25lIHdoZW4gYXR0ZW1wdGluZyB0byB3cml0ZSB0byBCQVJzDQo+IHdpdGggbWVtb3J5
IGRlY29kaW5nIGVuYWJsZWQuDQo+IA0KPiBJIGNvbnNpZGVyIGFsbCBvZiB0aGVtIGJ1ZyBmaXhl
cywgYWxiZWl0IHRoZSBsYXN0IHBhdGNoIGlzIG5vdCBmaXhpbmcgYQ0KPiByZWdyZXNzaW9uIChz
aW5jZSB2UENJIGNvZGUgaGFzIGFsd2F5cyBiZWhhdmVkIHRoaXMgd2F5KS4NCg0KQXMgSSBkb24n
dCByZWFsbHkgd2FudCB0byBzcGFtIHRoZSBsaXN0LCBJIHdpbGwgcHJvdmlkZSBteSByZWxlYXNl
LWFjayBpbg0KdGhlIGNvdmVyIGxldHRlci4NCg0KVGhpcyBzZXJpZXMgaXMgYSBidWdmaXggc2Vy
aWVzLCBzbzoNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0u
Y29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQoNCj4gDQo+IFRoYW5rcywgUm9nZXIuDQo+
IA0KPiBSb2dlciBQYXUgTW9ubmUgKDYpOg0KPiAgIHRlc3QvdnBjaTogYWRkIGR1bW15IGNmY2hl
Y2sgZGVmaW5lDQo+ICAgdGVzdC92cGNpOiBmaXggdlBDSSB0ZXN0IGhhcm5lc3MgdG8gcHJvdmlk
ZSBwY2lfZ2V0X3BkZXYoKQ0KPiAgIHZwY2k6IGRvbid0IGFzc3VtZSB0aGF0IHZwY2kgcGVyLWRl
dmljZSBkYXRhIGV4aXN0cyB1bmNvbmRpdGlvbmFsbHkNCj4gICB2cGNpOiBpbnRyb2R1Y2UgYSBs
b2NhbCB2cGNpX2JhciB2YXJpYWJsZSB0byBtb2RpZnlfZGVjb2RpbmcoKQ0KPiAgIHBjaTogZG8g
bm90IGRpc2FibGUgbWVtb3J5IGRlY29kaW5nIGZvciBkZXZpY2VzDQo+ICAgdnBjaTogcmVmdXNl
IEJBUiB3cml0ZXMgb25seSBpZiB0aGUgQkFSIGlzIG1hcHBlZA0KPiANCj4gIHRvb2xzL3Rlc3Rz
L3ZwY2kvZW11bC5oICAgICAgIHwgIDMgKy0NCj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj
aS5jIHwgNjkgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gIHhlbi9kcml2
ZXJzL3ZwY2kvaGVhZGVyLmMgICAgIHwgMzggKysrKysrKysrKysrKystLS0tLQ0KPiAgeGVuL2Ry
aXZlcnMvdnBjaS92cGNpLmMgICAgICAgfCAgNiArLS0NCj4gIDQgZmlsZXMgY2hhbmdlZCwgMzQg
aW5zZXJ0aW9ucygrKSwgODIgZGVsZXRpb25zKC0pDQo+IA0KPiAtLQ0KPiAyLjM3LjMNCj4gDQoN
Cg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:23:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:23:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426402.674797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olShg-0002WR-Lc; Thu, 20 Oct 2022 10:23:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426402.674797; Thu, 20 Oct 2022 10:23:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olShg-0002WK-Io; Thu, 20 Oct 2022 10:23:08 +0000
Received: by outflank-mailman (input) for mailman id 426402;
 Thu, 20 Oct 2022 10:23:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aKW4=2V=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1olShf-0002WB-1m
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:23:07 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ee6c7ea-5061-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:23:05 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-618-qPPDbW3POkONa7b3GzeZfw-1; Thu, 20 Oct 2022 06:23:01 -0400
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
 [10.11.54.9])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F013800B23;
 Thu, 20 Oct 2022 10:23:00 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id E66B049BB60;
 Thu, 20 Oct 2022 10:22:59 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 0C20321E6936; Thu, 20 Oct 2022 12:22:57 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ee6c7ea-5061-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666261384;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TfOkpGu3n1Tioz9GJHRmwzGEyNM3g7ymXrDN/7gskxw=;
	b=c2Bk2bUgk9vBlLY2ZeCrPB2ANO9kvPKpiBgDS3HuXz1GE1AZKe8BIGR5Psne+8qHI32GAc
	E8r4PNW3928TIFM4kHwxQsJXAfIpGbzg7iTsosAt0bFVd8WMqg8Yw65U5NrgFEEQ61c6CQ
	xEOSincdREmdzJ3ZpRualQUcwNjbdyE=
X-MC-Unique: qPPDbW3POkONa7b3GzeZfw-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Stefano Stabellini <sstabellini@kernel.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David
 Alan Gilbert"
 <dgilbert@redhat.com>,  Jason Wang <jasowang@redhat.com>,  "Michael S.
 Tsirkin" <mst@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Anthony
 Perard <anthony.perard@citrix.com>,  Greg Kurz <groug@kaod.org>,  Eric
 Blake <eblake@redhat.com>,  Stefan Weil <sw@weilnetz.de>,  Thomas Huth
 <thuth@redhat.com>,  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Paul
 Durrant <paul@xen.org>,  David Gibson <david@gibson.dropbear.id.au>,
  xen-devel@lists.xenproject.org
Subject: Re: [PATCH v11 17/17] net: stream: add QAPI events to report
 connection state
References: <20221011200539.1486809-1-lvivier@redhat.com>
	<20221011200539.1486809-18-lvivier@redhat.com>
	<87mt9u4m9d.fsf@pond.sub.org>
	<7eaa3255-7580-7e06-8b28-ae60ed5e1be6@redhat.com>
Date: Thu, 20 Oct 2022 12:22:57 +0200
In-Reply-To: <7eaa3255-7580-7e06-8b28-ae60ed5e1be6@redhat.com> (Laurent
	Vivier's message of "Mon, 17 Oct 2022 16:03:36 +0200")
Message-ID: <87pmemdcam.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9

Sorry for the slow replay, too many distractions...

Laurent Vivier <lvivier@redhat.com> writes:

> On 10/17/22 15:23, Markus Armbruster wrote:
>> Laurent Vivier <lvivier@redhat.com> writes:
>> 
>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>> is connected, and NETDEV_STREAM_EOC when it is disconnected.
>>>
>>> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
>>> address.
>>>
>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>

[...]

>>> diff --git a/qapi/net.json b/qapi/net.json
>>> index 6a1a49749294..69f83bceff3f 100644
>>> --- a/qapi/net.json
>>> +++ b/qapi/net.json
>>> @@ -895,3 +895,49 @@
>>>   ##
>>>   { 'event': 'FAILOVER_NEGOTIATED',
>>>     'data': {'device-id': 'str'} }
>>> +
>>> +##
>>> +# @NETDEV_STREAM_CONNECTED:
>>> +#
>>> +# Emitted when the netdev stream backend is connected
>>> +#
>>> +# @netdev-id: QEMU netdev id that is connected
>>> +# @uri: The Uniform Resource Identifier identifying the destination address
>>
>> Is an URI the appropriate representation here?  It's not how we specify
>> such addresses elsewhere in QAPI/QMP...
>
> I put in the event the same information we have in info_str and displayed by the HMP command 'info network'. What would be a more appropriate reprensation?

SocketAddress?

>>> +#
>>> +# Since: 7.2
>>> +#
>>> +# Example:
>>> +#
>>> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
>>> +#      'data': {'uri': 'tcp:::1:1234', 'netdev-id': 'netdev0'},
>>> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
>>> +#
>>> +# or
>>> +#
>>> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
>>> +#      'data': {'uri': ''unix:/tmp/qemu0', 'netdev-id': 'netdev0'},
>>> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
>>> +#
>>> +##
>>> +{ 'event': 'NETDEV_STREAM_CONNECTED',
>>> +  'data': { 'netdev-id': 'str',
>>> +            'uri': 'str' } }
>>> +
>>> +##
>>> +# @NETDEV_STREAM_EOC:
>>
>> What does "EOC" mean?
>
> End-Of-Connection, this is the nomenclature used in the code when the socket is disconnected.
>
>> Could this be named NETDEV_STREAM_DISCONNECTED, for symmetry with
>> NETDEV_STREAM_CONNECTED?
>
> Yes, it can. EOC is shorter, it's why I used it, but if you prefer "disconnected"...

For better or worse, we've always preferred longhand to abbreviations in
QAPI schema names.  Exceptions have crept in, of course.

[...]



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:27:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:27:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426408.674808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSlk-0003BF-64; Thu, 20 Oct 2022 10:27:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426408.674808; Thu, 20 Oct 2022 10:27:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSlk-0003B8-35; Thu, 20 Oct 2022 10:27:20 +0000
Received: by outflank-mailman (input) for mailman id 426408;
 Thu, 20 Oct 2022 10:27:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olSli-0003B2-Vh
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:27:19 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c484fff5-5061-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:27:17 +0200 (CEST)
Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 06:27:15 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BY5PR03MB5078.namprd03.prod.outlook.com (2603:10b6:a03:1e5::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 10:27:12 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 10:27:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c484fff5-5061-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666261638;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=ngX+WlzQoqklnKAvqzDrlMCRtPo9t49icdQ+7W3G+5E=;
  b=QSbZ1EqMJ4zyC+DTcbkHYbp2F3MaZv+934QqcnEV8oGYR18Zt9zGQBn0
   PRs/uvmtHD14Z7uWL8zF5RyKWwiKv9051RNIyly1P9UUtzoil7t/ozAIc
   a5RNu8ir7bei5/sX492f4hXErPOkHL2iuz2DcbziAsa+Js+Fw7RpE1klY
   c=;
X-IronPort-RemoteIP: 104.47.58.104
X-IronPort-MID: 83568273
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Hc8B76KTaDtpfxEJFE+Ry5QlxSXFcZb7ZxGr2PjKsXjdYENShTdRm
 DNOXGzQaaqINmv8fdh3bIq0/B5TupHSzdc2SQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FZxC3/YqM2ZQz
 MABNQpUblPdgbuX/ovuH4GAhux7RCXqFKU2nyg4iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QLT/PJri4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWHYrCL22bSncSXTW4cVTbOg69JRpHrK7VwPLTMyRWWCrqzs4qK5c5cFQ
 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yyaUAHIVCAFIbtMOvdUzAzct0
 zehgNfBFTFp9rqPRhqgGqy8qDqzPW0ZKDEEbCpdFQ8duYC7/Mc0kw7FSctlHOitlNrpFDrsw
 jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNt2uVuKbNi1SU1GXm
IronPort-HdrOrdr: A9a23:JQSvDq5EWkzSTb1tZQPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5
 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ
 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S
 zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN
 zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a
 hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd
 gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A==
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83568273"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cb9dUykbq1zEga09pOcWbIlvfU5K3rb+61WlYOvT3SYMtw8DGqPAErkOKgtJdS/9MZlgch7MDhJu3okF548vxBrAJS7ZshQXL0SFVwRmqy3ssvOVZwa3+gkDJBLy2dWvY0LCQECdxDejpOv//2btkBdk9/lU09FJzY+4g+Hx6rqF3g5p710EqelX3T8p6Ocpbw9QvIcrrNTKSUTHOQhryJYNmmo3rR7OJlpHGJAaf8ME1TP3+NGoD08I9X9BEu03vOddYmkCryVc9La3Hs1bNJomta+uatMTPGS7WSyE+uFES1dDefwlhJJfGk8MJx3FwAjcSF0a831DZijb7RqiTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/I+FaKURwIjbND5Ow6oLQIFmGi3KR2FA236qcyuO0qQ=;
 b=KAE/fPOKhbxySDdNgK3wLS5EMlnC329MVlW7SQufd68w2CgG84eUQbM9QFEVJfj6A8lL2MIYO5sOBaa3g5EH2CMeHFmkkRoNHeFl02MDtREkov+79CUtyo1UAjDfZaNRAg0KbCS8NuJZnkN+4IruwBe7HTczmHbQAhLKoN/lflQ5eLEKgTC8zl/nrOy7Aqb5KvGdEZg/qH2yEBCsyGDcM15TL9Fqm4yrjYaDb9CFma+i4TAFc0s5X+ZtFhy6WolnMle1KmDQMb6Ug10vdfiuDy8peemU7/ndYHVQzRc38FQbrsSgUcz7AsIhbp4G1hHg70WVCZhvtKLrIKsXKlSEFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/I+FaKURwIjbND5Ow6oLQIFmGi3KR2FA236qcyuO0qQ=;
 b=hw4jq+0KK++eCsN6ARg6H6gKLk3oNZc0CuptgoZZJXQV2xEMFE+tYsJ/keLEaNkYqtOiGgKzr9mz35ETZ+gtaGqbGiDLx9fJJHxa4dNJMooat+Vgtcx85YTdeJ5ecfhE4bKBadvHktTVzvv/NjupVOAUz2L/0YfQUdJE30SQinE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: [PATCH for-4.17?] test/vpci: enable by default
Date: Thu, 20 Oct 2022 12:27:06 +0200
Message-Id: <20221020102706.29267-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO6P123CA0036.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:2fe::10) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5078:EE_
X-MS-Office365-Filtering-Correlation-Id: d138c819-0698-4e77-bbec-08dab285a6b3
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fnViuGgJDxCb0CY3BzT3gH2nVY09B+sNodePrLBPDkDVF2suOU1N/zWSnCOeOev8CMOH8iMPCsB772Ye6TiGkVH/I5iHh1HoCYmehfErpLUUPSf30txpqImAsc1a8DrLz581mk5f20yhm1tOlc/LxE8K/KBVvO5bxKL2Vxs3XIU4bKq1O1Eo3GwNXzniCKHhfkTgGha4TGBIqGnZS0dnH+Fs3AEC8ief06AWQ7hAr7/Zoom64+Bvsgi/Dj/t/zIxpRcUaaTi03Cb0GU6q/lqpa47rT6O8czGqTDAse1JDYBRZvA2G9hrniBgHCtZg8ECJ9zYFi9/i5BOzMs8I48PEsA+y1/norA++dgksZ/WuUX2NPrSJN1CixevsfzaoaUcuNXV1wzFBv7I2s735p8Z5KY0sIJMCyu6Pp+rv/15SZj9cP8ylmKlHE9Sx4LpqbE0BHUhi4LW0H/5KOLv4i7Vk/ICI8SRbGK3CODMQU8OdG4WxODbrV3q7CQcqOxzdXNBbY7hmGvvdHvH6JJH1vW8P515GlDT7Pe/RgKv8tHSYdBdBHCshcFAHbwpL9BSY6aVwUfyz45iorXJYwqzKksYW4nB9Pr7B4FMbFGzgN1hHe2H0r6O39wc1ExpTMAbmkRFD8JQi29uCJR2iYiUH+3WKubEmsIYKwtQahbXHt6KGdiNQKfbzoIzNT3mqu8UIQ6ShpUGU9f600DErt8kVZCr3A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199015)(66556008)(2906002)(4744005)(5660300002)(66476007)(8676002)(66946007)(54906003)(4326008)(41300700001)(6486002)(36756003)(6666004)(107886003)(478600001)(38100700002)(6506007)(8936002)(1076003)(26005)(6512007)(83380400001)(6916009)(2616005)(316002)(82960400001)(86362001)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L3NBZkg2ZTNNelhESFQyY21rUU1SdUNPMXlFeFllU2M5NkFuVTJ2Nlh5L3U5?=
 =?utf-8?B?REFpWWJvVThSdUgxVXJqN0oxL1FvNFJJbE1YdFpOKzBxMFl1VkNFOTN0ZkpG?=
 =?utf-8?B?VmtFZjR4SUlFb0VoWVVWSUZWTDdaUDRRU05kNFBIVzRWWWRsUFZVSVhNNlVE?=
 =?utf-8?B?MmQzVG1qdE8vY3h5N2M5ZklJMXJFek5NNEZGTFpWelRWRitHZndhNkw3YTkz?=
 =?utf-8?B?UGpoaHB3dVYvYk5MUGovUEtyeDRjektGNVdmcy83NjVyR0hUN29pbzg2bUdh?=
 =?utf-8?B?OUFPOEZwbHNlaDhOK0JmQ0FKUVVRS2VidnlZZ21XS1hORDJxbllUR3M3bWQ1?=
 =?utf-8?B?ODZRR2VGb2gweURLOVEwUTZRaVpPaGhtZjhRekdCdGNaaDV4U3l6a08zbE41?=
 =?utf-8?B?eENqQUxIcGM4SGxqLzdITm9mQVNIbzUvVVpvNHY5dmZjdE9iTVlDUHMyWlZo?=
 =?utf-8?B?LzV5Q3gwOHlvb3ZzTlRQeE52UnRxMEprU2VYR0tpRkgvYlMreHdXRW9hTm5C?=
 =?utf-8?B?WnVsMTlReWIwZVdqeHRTZkdYTXBneTlNamhQRnQ2aGdEQUtHQndGNFN4ZUZL?=
 =?utf-8?B?T1ppK1JtT2NNV0dnam9zeGMyRWVudFdDdXFrTDVTRHJRRGhmMU4zczFiczFE?=
 =?utf-8?B?K2FxQjRMOEUxWWgxUzBQazFEMWFyYUNsdWc3Ti9hNjdOSkRGZ2ZLaWtNdklV?=
 =?utf-8?B?ckR4MXpOLzA1ZlRzVXFuY2VvRm5Mc3JFRmZBSDl6TjRGM3BDbEpIb2srRVlr?=
 =?utf-8?B?MTY5dHVXSDdwRnhxem5iU05JdmhQV1ZMY3YzTFJieE9Ua1ZGdFIyQWM5SklE?=
 =?utf-8?B?azNPeUs1alY0Y3J0cXd6VmczNG1GOUZodHdIVzVKcVFTTU1ldFFTZFVzRnRJ?=
 =?utf-8?B?Smo3UWFRN2wxNlVDdkREelhHUHczeUFSZGRKd2xKOFBWcEprajlWS3RYMFBs?=
 =?utf-8?B?MmNlK05qbU93SVh5L0xLK1VCYTQ3ODkwczExejJlQmwzRjF1YllxMVBFa0ZV?=
 =?utf-8?B?MDQ0R0hQWEhtK3YwcCs4TnFtZW1kNkVzMXNkRURiZWJLcE1nejhIZWpjTVRV?=
 =?utf-8?B?dThEMmxkNnJwbXBuRGhjeTc5K09ZMGNkRVVNWjU0SGZjUEVVaGozR3l6dG1E?=
 =?utf-8?B?RTMyK2xCd29VRWdWeGRXelVWdW13WWJnajNPamZka2JwZ0RXMXNQanVObXNm?=
 =?utf-8?B?TEU1M1F0WE1Sa280Vll2RkVyMjdQMmhPZkdOMDd0THU4Y1VMSTMvYWlKalA5?=
 =?utf-8?B?VzFxTG5JWUsxODZuNm1wSDZ4bDllbUR5VmQ0dWo0TUJYYytIMmMxMVdyNms2?=
 =?utf-8?B?eFpxU01YSWVKRHY0WUJFang2VCthK0VZVlVad2ZBSnYySEtDcXJBdG5uK2Fo?=
 =?utf-8?B?OFFhdHJQUXFUYVdvOVVhT0p0T0R3blh6UEdKc3JjQkxYUWFqeTI5T2xVcVdB?=
 =?utf-8?B?TTV5MUFMeEg1VUM1NDhrbkpySXQrR0FEWnU2RjVyWmtPS3lXbEI3b1gxNW5w?=
 =?utf-8?B?TVQzTzc3eUtSK29URE1ZYkRyelBBWFJjUlMvSmhsYmphUGVwQ2drdW1OTmFv?=
 =?utf-8?B?d0lGRkV6ZjBGcHNldVg2cnVRQjUxWmYwN2dhVGRVanFzTXBPSXc4MFNqdW5D?=
 =?utf-8?B?YWxFei9uYVBqdTdBUzJGSFJBOE9QRVBOZ3NVbFg1dkV6UVJjWFdvUWprcmla?=
 =?utf-8?B?L3hJNEJDOGNkcXA5UG1zZUs3ak1DOVZJaGdtQ3h0NVAxZFVOREJvZDd3Zkla?=
 =?utf-8?B?RzNnbFh5N0ZoRmcxSEd6b1dzVGpJeDJrYzBtVzY2ejhUbUFOTWFQU3Q5Yzhk?=
 =?utf-8?B?aE5ZZTBBTzVUdTdpWU5BQy9LMFp4QW9aWEJqS0gwU3p1V0U3ZHlrS0FqOEZz?=
 =?utf-8?B?N1NwYTcwU1FBeVR2MVFJL2Jsc0U2WnlxdXR1b29XTVNlMzVGQWlPZnRSamJQ?=
 =?utf-8?B?NjNTWnRkWDFNVCtCWEV3L0twSXE1VU5LUS8yZU5rRWhndWxwMlpGYkwrMnVt?=
 =?utf-8?B?dk9XdmY1dlE2QjRVcmpVZEluZ1dOMmZLNjhuVW51NTgwMVF0STY1VldFRlJD?=
 =?utf-8?B?dGJ1bUdZaE5IbGpyVWFwVnlNOHlDSzVkc3pWUmRFajBZNUZiNUNOOVZGaHZl?=
 =?utf-8?Q?BMBb3bTnnA/tKElJV1z8ymyzB?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d138c819-0698-4e77-bbec-08dab285a6b3
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 10:27:12.4787
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EWK8kMtuUmmJVockn9LpQ3s1oo7u3LrYtxWof2J+Q6+EPxNs0syAY4tlPGG9SsnlQTtsilZtlJP4L5ekRCOf1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5078

CONFIG_HAS_PCI is not defined for the tools build, and as a result the
vpci harness would never get build.  Fix this by building it
unconditionally, there's nothing arch specific in it.

Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
While not strictly a bugfix, I think it's worth adding this change to the
release in order to always build the vpci test hardness and prevent it
from bitrotting.
---
 tools/tests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tests/Makefile b/tools/tests/Makefile
index 33e32730c4..d99146d56a 100644
--- a/tools/tests/Makefile
+++ b/tools/tests/Makefile
@@ -10,7 +10,7 @@ SUBDIRS-$(CONFIG_X86) += x86_emulator
 endif
 SUBDIRS-y += xenstore
 SUBDIRS-y += depriv
-SUBDIRS-$(CONFIG_HAS_PCI) += vpci
+SUBDIRS-y += vpci
 
 .PHONY: all clean install distclean uninstall
 all clean distclean install uninstall: %: subdirs-%
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:30:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:30:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426414.674819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSoz-0004YB-KP; Thu, 20 Oct 2022 10:30:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426414.674819; Thu, 20 Oct 2022 10:30:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSoz-0004Y4-Hg; Thu, 20 Oct 2022 10:30:41 +0000
Received: by outflank-mailman (input) for mailman id 426414;
 Thu, 20 Oct 2022 10:30:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZuZ=2V=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olSoy-0004Xx-IH
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:30:40 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3d3189e4-5062-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:30:38 +0200 (CEST)
Received: from FR3P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::14)
 by VE1PR08MB5791.eurprd08.prod.outlook.com (2603:10a6:800:1b1::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 10:30:35 +0000
Received: from VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:a1:cafe::37) by FR3P281CA0098.outlook.office365.com
 (2603:10a6:d10:a1::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.18 via Frontend
 Transport; Thu, 20 Oct 2022 10:30:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT049.mail.protection.outlook.com (100.127.144.168) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 10:30:35 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Thu, 20 Oct 2022 10:30:35 +0000
Received: from 714cb6995abe.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AA9A0759-BA3A-4355-BA1E-A982F4D8BAAD.1; 
 Thu, 20 Oct 2022 10:30:28 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 714cb6995abe.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 10:30:28 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS2PR08MB8503.eurprd08.prod.outlook.com (2603:10a6:20b:55e::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 10:30:26 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 10:30:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d3189e4-5062-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=AcJncRH65v/IGTlX++36QlX6UqaAyveRO7Gu+z24rZOVJossCrl+ZSHbv9+dYvWSei9qCGQ9h9eg90/+nS26Ypb7GpV9tyxJ6ThbGi0ECmngj6d/UNbPyHJRTVgPAZWxQ4xcNixW8y333zhF1R0oSbOtHBBCWGrd1UTBlPnHfn7Di8eqI7vtKH4aEKk61zOGEJx6OF3kWY7ZmkC3S/yZ/l6hxd22c/xzkRHNZPHlPZPTb6G3ZiLNHoN9HdUlWc1ub4bB20ht355J4/2+AqrF9x3cczRGX1PL7H/uVEPJJEMajrV8Y9gz3Lg9uOC1GFjEVfswVX3siHKtZ5aCr8mYlA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KAQUSMRrd56ccAEu1NXYxB5fkpyk6gidnrJ7pjL4vWE=;
 b=farYdwI1x6FTsAW48Kk0KDhGoAOiS5RYt1BS29sRbpxJVm0YbppZ9f+9FBJfsWLAlleO/mxD8bXbgQipY2pwMLRp+psAV6g4w1WmEv+e5013gZoSX6XDRqD55e1H2YI5FqqLt9ouikPg7NaMXkfUMrE+cPq5zCfjqw96IoY39vMZv1uKXlm9iKh/0jVV+dR5qCyZ4NHb35IOjPM4YLqQ9Qvi2K+QSgk075vGwj6JYAkG2tNiebnz8DAm+t3it5QZmzzt1cQQLhAW5cI/UF6+VBDpLKT2D308EAnzeZztVqkxHl8mdnb1hZdrU6CnXnomcsgl5bbwG0PB9VvK2ASmEQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KAQUSMRrd56ccAEu1NXYxB5fkpyk6gidnrJ7pjL4vWE=;
 b=4PbwA/k3+WxsLLIK7Jq4XfKraysydBslxwwdE6nR9jjlHwgFZ4YsTlUDca47TPsStrILpx4XsKgRCQKq8VRyG5OyuGd3ANz3YPtwMReCaC6nMRcEmYghnYwEbvNOSXHL8t16pdH2Hmon6UZ5SRKGJeN+3DAcESg03/BVjvnkG0k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GRMb3p4+jXlOUr8kMpDV+9Mj91nWHkj1TDiU/aHlIeyj6kjbwVdbPyY+DtLKw3uXwSzgMlu3MMjcqYInwJzBgeRu7XGqd/3s0BMS+1VHRnbIcS6Da/kK/38SCNIIs9gMZLQdgQrUismFmtxCxuegsCc8QaStAn2mlCAFxR1RmjFchGTnbZfadzml+gUbZbBTgBCfIiL8DbUfAPdzM24K0ODVtEC/b0b8/bzeZWJaRWwXrWkiAmxiNoiWecpOiVtzuIJuEqzRHwbn9lN4ruGSfAFwnubY76cx/Mfv54z9zZCnEZM2NQiqPFKXnkQy11hZysa7V6ZYPduAXbN/PLz4IQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KAQUSMRrd56ccAEu1NXYxB5fkpyk6gidnrJ7pjL4vWE=;
 b=QkNVrXDvbfDnTutZ8lJQU6If9z0t1gpFZW/8TysTtf5POkYEY+IbUTsgxYTe27PT7rrvJ/YR7dArmdsWiybu/NXQtJWKFX/3kLs4qQUSp51V9hRpSmGd0KfQVkP+DH34Dmh2qsbjxWz3FKUcUY8atDnxNEHotC32uWNMtGdgniQNceKgXjXqGMQHwBT5NxEMJSkWZpQSCYXNgMYI2X26BcQ1GSqiEMKqsvkXfsA3PqzYcdAzESpBhvDb71QMTSuCfkHLELIYuucwx0IHu12fbpIJQg979qV/MFyPdcnYI61NeRIKV0l+w1K9p4VgUwT8k+Gfv+xcvCHWwsxkuNczKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KAQUSMRrd56ccAEu1NXYxB5fkpyk6gidnrJ7pjL4vWE=;
 b=4PbwA/k3+WxsLLIK7Jq4XfKraysydBslxwwdE6nR9jjlHwgFZ4YsTlUDca47TPsStrILpx4XsKgRCQKq8VRyG5OyuGd3ANz3YPtwMReCaC6nMRcEmYghnYwEbvNOSXHL8t16pdH2Hmon6UZ5SRKGJeN+3DAcESg03/BVjvnkG0k=
From: Henry Wang <Henry.Wang@arm.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>
Subject: RE: [PATCH for-4.17?] test/vpci: enable by default
Thread-Topic: [PATCH for-4.17?] test/vpci: enable by default
Thread-Index: AQHY5G6LBoyhiXjFqUqNYD0Wl8lAwK4XFLTw
Date: Thu, 20 Oct 2022 10:30:26 +0000
Message-ID:
 <AS8PR08MB79919E26BAD0DD1B74C564EF922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221020102706.29267-1-roger.pau@citrix.com>
In-Reply-To: <20221020102706.29267-1-roger.pau@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F11A06ADD107AC48BE85EBBED7D5B118.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS2PR08MB8503:EE_|VI1EUR03FT049:EE_|VE1PR08MB5791:EE_
X-MS-Office365-Filtering-Correlation-Id: 5e4c9764-53d1-4c4c-6884-08dab2861fd5
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XzwEhmfIFBqa455yxAtxz7OjtJx+YTDFWWVq/Xx0C3bCisWfERTxAeoTAVJ68QJ9UiqyInvcKVwu1hCgRZGPlAmc+y56jkkPmJVhbyisnxoFazZKK39aKUSfcVeKMDAWXUvtpD5iLHuXupnWHvIJ059d0zP/6ilFTBluUkpi7n1WRnQNib27xAbBZNceLKYN1pNQyHoXuYAzYV6xuJ0AFD+hypi/Ku68R8L5aW3N9KnSiqwrpWTO011nAFT9Asge1Pc7QWeifMHFr3oyqeg+xwcdhoVfCWs2IDsbcXWcmyLHl3tXoFTW38Nl/u6bWszaQYMRdKL0DVw5YzURw0Kr1eUm91+GJiXja+kTxzIS+MRCi8YaCm9VlroCAyX3wkC0m9A9yvW2vQb0EFEXr1o1/7YVc3z6rjASJTko7csoNPWYL+C/e0hb7KKJF/8H2P++55I9wKt0o1mBn94Qig/i7dQm4LmrI6QSYiwYsiXvvOc+tkKjDdGULvj2SWvG74n5e+mdvopDRFTGUvhBWVb2oD9gjyVG359ss5qtvansVMeCmMSoZ6ONKBIPn42OWHWY4GlYWIycPGFSyO0rptsHAD//KW/rV1hzG1Fc89jC4gT4SSgbHhqXGsx6AX0Ky7dPE7bMpYjVxpgZKSFR4Qj+4UA3zhecq6KLZwCtH7VKuc6nueoo+lzcng4+hf3qXAXWwdqvm+uEevfu7S0MEi1Iq/kw0erkmLT/7fKKCFFJBtqaoolvhqAvTWVDM6r9GVugpjz4BGSFORHQTdTfSmZQnw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(451199015)(38070700005)(38100700002)(122000001)(86362001)(33656002)(2906002)(71200400001)(478600001)(55016003)(41300700001)(316002)(66556008)(4326008)(8676002)(64756008)(66446008)(66476007)(8936002)(5660300002)(76116006)(52536014)(54906003)(110136005)(66946007)(83380400001)(9686003)(26005)(7696005)(6506007)(186003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8503
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ad3aa9c8-d928-43df-98f5-08dab2861aa4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m3/jOysTribsTIzt9yKSTpGfJ292wOlRit9cw4rlhh+MeZyptYsYhn/Xni6g7mDR2ImA8rTuXqbWhja7psFO/O5/wc2okKSs8Zwr1y29sz2eGVdN/hLMh3wWZ40H+voeEeNKo3liFrzE2qACTldeL5UVWdyNE3u8AKW0NylUXADQx/kffdWztOsaPLjzOexhae3DTUwJJSsnja9OpGZ5E9pMX9R/SibqJuH7C5Py/R/XICCmEp2/al8pFufQkgpi3cg3R+HOgFuxCW64/iErb/Jv6knLV8fMKazhqrQhYn91poJDU2lPalg9Np5uGf+mkyCk0NMKjuX08NhalXTRXJgp0tY1Q6KM3uJt5P4W7LLG53TG5SeOZcriEen9eFulkhEanUeA7di26HqT6L0v0vnn+B0h+a4iS3/I+h/1Y4aanvyKMqG2P0bunJClIJxj2o3YpC7R8LWcAQyaTrrFsVMVIdV6strealLpoH/u9qfugCf08xpyw0wo/MXl5HIdlDyoGOAjiYDBdjgh+VXZbcr+XdcgEBCA/IBuu/fsf1RLtvyNGHGoo41nJ5nXTJSrbAL2ZTIg4uWYZlEvBJ6vhVuTx2JNs+qdKxDCXj58fhejNoNQL4cHajipO1ke8LFwUMQ7yVzhptPFAaQnj/H7Gz1k/2c9EIIP+K5ht6avHmH0N5rTJYAG8pCv/rH2BgmBeRU+LtYtv/Ls2U/7G3eRDes2U52NC0U/ujW5Z6FRkbcTI1auqSmnXiKv9JbT05G7LHe0QuwZB9Ubr3ln1G0UnQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(2906002)(186003)(47076005)(336012)(83380400001)(86362001)(33656002)(40460700003)(26005)(9686003)(4326008)(8676002)(41300700001)(8936002)(81166007)(356005)(40480700001)(55016003)(316002)(110136005)(36860700001)(54906003)(82740400003)(82310400005)(70206006)(7696005)(52536014)(5660300002)(70586007)(6506007)(107886003)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 10:30:35.4694
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4c9764-53d1-4c4c-6884-08dab2861fd5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5791

SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9nZXIg
UGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00
LjE3P10gdGVzdC92cGNpOiBlbmFibGUgYnkgZGVmYXVsdA0KPiANCj4gQ09ORklHX0hBU19QQ0kg
aXMgbm90IGRlZmluZWQgZm9yIHRoZSB0b29scyBidWlsZCwgYW5kIGFzIGEgcmVzdWx0IHRoZQ0K
PiB2cGNpIGhhcm5lc3Mgd291bGQgbmV2ZXIgZ2V0IGJ1aWxkLiAgRml4IHRoaXMgYnkgYnVpbGRp
bmcgaXQNCj4gdW5jb25kaXRpb25hbGx5LCB0aGVyZSdzIG5vdGhpbmcgYXJjaCBzcGVjaWZpYyBp
biBpdC4NCj4gDQo+IFJlcG9ydGVkLWJ5OiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0Bj
aXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVA
Y2l0cml4LmNvbT4NCj4gLS0tDQo+IFdoaWxlIG5vdCBzdHJpY3RseSBhIGJ1Z2ZpeCwgSSB0aGlu
ayBpdCdzIHdvcnRoIGFkZGluZyB0aGlzIGNoYW5nZSB0byB0aGUNCj4gcmVsZWFzZSBpbiBvcmRl
ciB0byBhbHdheXMgYnVpbGQgdGhlIHZwY2kgdGVzdCBoYXJkbmVzcyBhbmQgcHJldmVudCBpdA0K
PiBmcm9tIGJpdHJvdHRpbmcuDQoNCkdvb2QgcG9pbnQuDQoNCk5vIHByb2JsZW0gZnJvbSBteSBz
aWRlLCBidXQgSSB0aGluayB5b3UgbmVlZCBhbHNvIEFudGhvbnkncyBvcGluaW9uDQphcyBoZSBp
cyB0aGUgdG9vbHN0YWNrIG1haW50YWluZXIuIElmIGhlIGFsc28gbGlrZXMgdGhpcyBpZGVhLCBm
ZWVsIGZyZWUgdG8NCmFkZCBteToNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVu
cnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IC0tLQ0KPiAgdG9v
bHMvdGVzdHMvTWFrZWZpbGUgfCAyICstDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o
KyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy90ZXN0cy9NYWtlZmls
ZSBiL3Rvb2xzL3Rlc3RzL01ha2VmaWxlDQo+IGluZGV4IDMzZTMyNzMwYzQuLmQ5OTE0NmQ1NmEg
MTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL3Rlc3RzL01ha2VmaWxlDQo+ICsrKyBiL3Rvb2xzL3Rlc3Rz
L01ha2VmaWxlDQo+IEBAIC0xMCw3ICsxMCw3IEBAIFNVQkRJUlMtJChDT05GSUdfWDg2KSArPSB4
ODZfZW11bGF0b3INCj4gIGVuZGlmDQo+ICBTVUJESVJTLXkgKz0geGVuc3RvcmUNCj4gIFNVQkRJ
UlMteSArPSBkZXByaXYNCj4gLVNVQkRJUlMtJChDT05GSUdfSEFTX1BDSSkgKz0gdnBjaQ0KPiAr
U1VCRElSUy15ICs9IHZwY2kNCj4gDQo+ICAuUEhPTlk6IGFsbCBjbGVhbiBpbnN0YWxsIGRpc3Rj
bGVhbiB1bmluc3RhbGwNCj4gIGFsbCBjbGVhbiBkaXN0Y2xlYW4gaW5zdGFsbCB1bmluc3RhbGw6
ICU6IHN1YmRpcnMtJQ0KPiAtLQ0KPiAyLjM3LjMNCg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426426.674868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw8-000617-A3; Thu, 20 Oct 2022 10:38:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426426.674868; Thu, 20 Oct 2022 10:38:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw7-0005yC-Q2; Thu, 20 Oct 2022 10:38:03 +0000
Received: by outflank-mailman (input) for mailman id 426426;
 Thu, 20 Oct 2022 10:38:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw5-0005Jc-AE
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 448cad20-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id CD1A922B44;
 Thu, 20 Oct 2022 10:37:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5229C13B72;
 Thu, 20 Oct 2022 10:37:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qB1AEwclUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 448cad20-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262279; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ILAWk4N2BpG7ACFBIyEkxMn7YCTi50stXRwJvqUhhvc=;
	b=iZEPHizs/QiBzQVZ3JsJ/F9X6G1nd/86Qcw9nEQAD2A7eJsS4awW+QW32Kp6WLSQrdz6+a
	jrmY5l3MwAsdn/8SdukALuzE1HC9bvN3wKFVbwU6omIcEGHJqnctsxjUwESTJwtn8hSBSf
	rdFcl5qx1zhVnvX5Q9i+z/HFvdg6sNo=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262279;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ILAWk4N2BpG7ACFBIyEkxMn7YCTi50stXRwJvqUhhvc=;
	b=vG1blXNVXRI3H2h0JgrscuPkuZqeSCKOqgN82zOl3p7t08NLpRe6KvKSwq6QyP0GvCxvIV
	O5+iXb9KnG28K+Dw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 05/21] drm/logicvc: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:39 +0200
Message-Id: <20221020103755.24058-6-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as logicvc uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/logicvc/logicvc_mode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/logicvc/logicvc_mode.c b/drivers/gpu/drm/logicvc/logicvc_mode.c
index d8207ffda1af9..9971950ebd4ee 100644
--- a/drivers/gpu/drm/logicvc/logicvc_mode.c
+++ b/drivers/gpu/drm/logicvc/logicvc_mode.c
@@ -10,7 +10,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mode_config.h>
@@ -26,7 +25,6 @@
 
 static const struct drm_mode_config_funcs logicvc_mode_config_funcs = {
 	.fb_create		= drm_gem_fb_create,
-	.output_poll_changed	= drm_fb_helper_output_poll_changed,
 	.atomic_check		= drm_atomic_helper_check,
 	.atomic_commit		= drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426422.674836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw5-0005Oo-Rw; Thu, 20 Oct 2022 10:38:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426422.674836; Thu, 20 Oct 2022 10:38:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw5-0005NY-LV; Thu, 20 Oct 2022 10:38:01 +0000
Received: by outflank-mailman (input) for mailman id 426422;
 Thu, 20 Oct 2022 10:37:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw3-0005Jc-Gy
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:37:59 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 43884e75-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:37:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3B59D22B3D;
 Thu, 20 Oct 2022 10:37:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BBDBF13AF5;
 Thu, 20 Oct 2022 10:37:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EG0KLQUlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43884e75-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FmVfBkgQXeOJOs+lPsJuCl8bEsl7tdAgDeD2faGswnM=;
	b=xXdmWqIQfh0f0yJA3s0BPIeYEr3NNBygmE7VRKPJkQsM/g6E2+cV3BtvIsSHfPV/Zm2qX7
	r2clL0Fv/uWooja8TMsFYgvZciJRT0hTccsFr8g1QaD0IUJqiBlD+GdmvD0oilhw5kenke
	6XqrCQkfvOQ9SsLQR9c+XaGqOPwxmz4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262278;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FmVfBkgQXeOJOs+lPsJuCl8bEsl7tdAgDeD2faGswnM=;
	b=4eKuWLJB4biZqfRWi8B+SJis28AqEs4YJSoTa7xFnBHPlmt1qY0h5xZ7aBvq6htSbFrV3z
	FgVjttMfW3hPpXAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 02/21] drm/imx: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:36 +0200
Message-Id: <20221020103755.24058-3-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as imx uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index b4f82ebca5325..1defd6a40f11d 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -21,7 +21,6 @@ DEFINE_DRM_GEM_DMA_FOPS(dcss_cma_fops);
 
 static const struct drm_mode_config_funcs dcss_drm_mode_config_funcs = {
 	.fb_create = drm_gem_fb_create,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 	.atomic_check = drm_atomic_helper_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426425.674861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw7-0005rV-MC; Thu, 20 Oct 2022 10:38:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426425.674861; Thu, 20 Oct 2022 10:38:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw7-0005oP-4j; Thu, 20 Oct 2022 10:38:03 +0000
Received: by outflank-mailman (input) for mailman id 426425;
 Thu, 20 Oct 2022 10:38:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw5-0005Jb-3B
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 442d2e8e-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:37:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4D3251FA2F;
 Thu, 20 Oct 2022 10:37:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CD72313AF5;
 Thu, 20 Oct 2022 10:37:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KDenMAYlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 442d2e8e-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262279; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sHEv3PMrKNnInemYrMBOWuesS2nTAxE1RBtBG3/fya4=;
	b=A0Go8wc0pthGW821MuoZikUiXXtHq7ymZv2SSV9lTrmeXN1Yu4C7G6tnivAyJ9Sz9m6+AD
	Zm6tr3TtXaNArHNJj+Sv9XmKhd3H7TiF+Os9Ff0MveRULnotL60eHIpU5X9rRPUBbPL1uL
	Ft9F58IF15dCLP2XfZO4I3FgQoJUclY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262279;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sHEv3PMrKNnInemYrMBOWuesS2nTAxE1RBtBG3/fya4=;
	b=p2UIJ75nTMOoxRtiGSi2fv0IHNabxHTRxzd/SuQjnaHbwL4gc3z2PuPKKPd6TeO/w7i8Fc
	IFCKarlQzfPAwNCg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 04/21] drm/komeda: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:38 +0200
Message-Id: <20221020103755.24058-5-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as komeda uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 451746ebbe713..62dc64550793e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -10,7 +10,6 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
@@ -59,7 +58,6 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data)
 
 static const struct drm_driver komeda_kms_driver = {
 	.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
-	.lastclose			= drm_fb_helper_lastclose,
 	DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(komeda_gem_dma_dumb_create),
 	.fops = &komeda_cma_fops,
 	.name = "komeda",
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426423.674843 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw6-0005Vm-82; Thu, 20 Oct 2022 10:38:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426423.674843; Thu, 20 Oct 2022 10:38:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw6-0005V8-0U; Thu, 20 Oct 2022 10:38:02 +0000
Received: by outflank-mailman (input) for mailman id 426423;
 Thu, 20 Oct 2022 10:38:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw4-0005Jb-57
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:00 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43e2528e-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:37:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B282722B42;
 Thu, 20 Oct 2022 10:37:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F55713B72;
 Thu, 20 Oct 2022 10:37:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qG2kDgYlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43e2528e-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dfNCfewKdF4qrRIFBcdy7kMwlQEEw/he+rN8lqzuO0c=;
	b=sT2vIrk7gnJPmpN3+w8QkaaTa6QUjGrubtLOteaO8q4FcNJyLa4bQ5A3cJng6/bv4x1ZRW
	Lz3p/ro9/w3xl+AVVT9FPWpjAMPcA8qn3cc/ebFvAESW96dJmzCi9Vt9UP6A/tQvx+rg4o
	YGUKbfUA6e96QHnR/bkR596lb9w56ZA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262278;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dfNCfewKdF4qrRIFBcdy7kMwlQEEw/he+rN8lqzuO0c=;
	b=R9wURktsZ4GUuQFrOAQNChz7Mxyve21ulKCwP98mDiqGdgQ9gW2RRTX44wOhGGfIABxhoh
	cnNyRpZaMJHX9BCA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:37 +0200
Message-Id: <20221020103755.24058-4-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_mode_config.output_poll_changed. It's used to
inform the fbdev console about conncetor changes. But as ingenic
uses generic fbdev emulation, the console is being informed by the
DRM client helpers already. See the calls to drm_client_dev_hotplug()
in drm_probe_helper.c.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index ab0515d2c420a..99f86f1ba8bee 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -1018,7 +1018,6 @@ static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = {
 
 static const struct drm_mode_config_funcs ingenic_drm_mode_config_funcs = {
 	.fb_create		= ingenic_drm_gem_fb_create,
-	.output_poll_changed	= drm_fb_helper_output_poll_changed,
 	.atomic_check		= drm_atomic_helper_check,
 	.atomic_commit		= drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426424.674852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw6-0005fD-Rr; Thu, 20 Oct 2022 10:38:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426424.674852; Thu, 20 Oct 2022 10:38:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw6-0005dn-GC; Thu, 20 Oct 2022 10:38:02 +0000
Received: by outflank-mailman (input) for mailman id 426424;
 Thu, 20 Oct 2022 10:38:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw4-0005Jc-AE
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 43574464-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:37:58 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B7C181FA26;
 Thu, 20 Oct 2022 10:37:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4709113B72;
 Thu, 20 Oct 2022 10:37:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IHRqEAUlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43574464-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ro4+Kd0RltbjMdu4OrI2uib0ho5AqwGxOtBXY8dS7Qg=;
	b=hTN4RHJE1PxuqFN5kOORkafwVSL1AHktl4otDV1rbos5DSJ5D0LXWxzf9Ke/RXxSVAMXJC
	bbEyIjc/qFuqiBk6LPkyF317wUWc8k/1yIswUZHcgLxfE9QsfT+4CEKHPhrtDjJtG6VhFy
	KPo1RuIGxz3LnsPOov3fRzdR4m8wnm8=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262277;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ro4+Kd0RltbjMdu4OrI2uib0ho5AqwGxOtBXY8dS7Qg=;
	b=WQRBhVwummZkW7YtUvgBUG6C4KPwGlTIFpcexjZJs8nWsclzJ/R0QWj5vc7b/l6wWQm5S1
	usWIWm27yZzJJcBQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:35 +0200
Message-Id: <20221020103755.24058-2-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as amdgpu uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c       | 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 23998f727c7f9..fb7186c5ade2a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1224,7 +1224,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev,
 
 const struct drm_mode_config_funcs amdgpu_mode_funcs = {
 	.fb_create = amdgpu_display_user_framebuffer_create,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 };
 
 static const struct drm_prop_enum_list amdgpu_underscan_enum_list[] =
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index f6a9e8fdd87d6..e9a28a5363b9a 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -82,7 +82,6 @@
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_blend.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_vblank.h>
@@ -2810,7 +2809,6 @@ const struct amdgpu_ip_block_version dm_ip_block =
 static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = {
 	.fb_create = amdgpu_display_user_framebuffer_create,
 	.get_format_info = amd_get_format_info,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 	.atomic_check = amdgpu_dm_atomic_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426421.674830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw5-0005KD-II; Thu, 20 Oct 2022 10:38:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426421.674830; Thu, 20 Oct 2022 10:38:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw5-0005K2-Dk; Thu, 20 Oct 2022 10:38:01 +0000
Received: by outflank-mailman (input) for mailman id 426421;
 Thu, 20 Oct 2022 10:37:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw3-0005Jb-Bn
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:37:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 430c44da-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:37:57 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 428851F93A;
 Thu, 20 Oct 2022 10:37:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE6B013AF5;
 Thu, 20 Oct 2022 10:37:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8BWlLQQlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 430c44da-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Y7BdOtp6TFqwXPX3o6UHDb+9HmQzCsygQB8jvOJl5oY=;
	b=pexEAXjK3+YaGpJd+JADtO15n0ydGTiAR9QdozIjQlWTGCJGvjDk3GLtnTjahBibfxqKn8
	e0ZCiKKRAhP4pa+DGq9AHeQHkye84awc19SWK5FgvFa4p4jHOOLv6Ie/+7K77qgyduKGGP
	7xA6whgamY9hl61unJ7iRpO/wohJ91Q=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262277;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Y7BdOtp6TFqwXPX3o6UHDb+9HmQzCsygQB8jvOJl5oY=;
	b=CVcd7TwC6JyEu5wf89r3Wdsik/2sML9uk++MZ6TfBQTpvFyIWJxR+TOmqJlzmQsVkjVxBs
	WhUhW1hA4SnyrHBQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 00/21] drm/fb-helper: Untangle fbdev emulation and helpers
Date: Thu, 20 Oct 2022 12:37:34 +0200
Message-Id: <20221020103755.24058-1-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Separate generic fbdev emulation from the helper code that is shared
among the various fbdev implementations within DRM. Affects many drivers.

The goal of this patchset is to improve readability and streamline the
fbdev helper code within DRM. In the long term, we want to get to a point
where drivers or memory managers can pick and combine the various helpers
for optimal fbdev support.

Patches 1 to 8 start by preparing drivers. Setting lastclose is not
required by generic fbdev emulation.

Two drivers depend on fb helpers implicitly including other Linux header
files. Fixing this in patches 9 and 10 allows to remove unnecesary include
statements from the fb-helper header in patch 11.

Do some renaming in patches 12 to 14.

There are currently various implementation of the fbdev I/O helpers
with varying feature sets. The fb helpers for fbdev I/O should all call
fb_sync, which is what fbdev's internal implementation does. For DRM,
damage handling needs to be performed after updating a framebuffer. The
damage worker is part of the fb helpers, but the actual update logic only
works with generic fbdev emulation. Separate the two, which also gives
other drivers an option so set their own damage handling if neccessary.
The full-featured I/O helpers can be moved under a shared implementation
and called by all drivers. Patches 15 to 18 resolve these issues.

Patch 19 changes fbdev disablement to work at the level of display
detection. If disabled, generic fbdev emulation will be initialized,
but no display will be detected. It can later be enabled by changing
the parameter in sysfs and plugging in a connector.

Patches 20 and 21 move the generic fbdev emulation into their own source
and header files and clean up the include statements throughout DRM.
Many drivers only call drm_fbdev_generic_setup() and can avoid including
other Linux header files.

Built on x86-64, aarch64, arm, ppc64le. Tested with various combinations
of bochs, radeon, simpledrm.

Thomas Zimmermann (21):
  drm/amdgpu: Don't set struct drm_driver.lastclose
  drm/imx: Don't set struct drm_driver.lastclose
  drm/ingenic: Don't set struct drm_driver.lastclose
  drm/komeda: Don't set struct drm_driver.lastclose
  drm/logicvc: Don't set struct drm_driver.lastclose
  drm/mcde: Don't set struct drm_driver.lastclose
  drm/rockchip: Don't set struct drm_driver.lastclose
  drm/vboxvideo: Don't set struct drm_driver.lastclose
  drm/panel-ili9341: Include <linux/backlight.h>
  drm/tve200: Include <linux/of.h>
  drm/fb-helper: Cleanup include statements in header file
  drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper
  drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix
  drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info
    postfix
  drm/fb-helper: Disconnect damage worker from update logic
  drm/fb-helper: Call fb_sync in I/O functions
  drm/fb-helper: Perform all fbdev I/O with the same implementation
  drm/fb_helper: Minimize damage-helper overhead
  drm/fb-helper: Always initialize generic fbdev emulation
  drm/fb-helper: Move generic fbdev emulation into separate source file
  drm/fb-helper: Remove unnecessary include statements

 drivers/gpu/drm/Makefile                      |    2 +-
 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    |    1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   |    2 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |    1 -
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    2 -
 .../gpu/drm/arm/display/komeda/komeda_drv.c   |    2 +-
 .../gpu/drm/arm/display/komeda/komeda_kms.c   |    2 -
 drivers/gpu/drm/arm/hdlcd_crtc.c              |    1 -
 drivers/gpu/drm/arm/hdlcd_drv.c               |    2 +-
 drivers/gpu/drm/arm/malidp_drv.c              |    2 +-
 drivers/gpu/drm/armada/armada_fbdev.c         |    6 +-
 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c       |    2 +-
 drivers/gpu/drm/ast/ast_drv.c                 |    1 +
 drivers/gpu/drm/ast/ast_drv.h                 |    1 -
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |    2 +-
 drivers/gpu/drm/bridge/tc358762.c             |    2 +-
 drivers/gpu/drm/drm_crtc_helper.c             |    1 -
 drivers/gpu/drm/drm_fb_helper.c               | 1081 ++++++-----------
 drivers/gpu/drm/drm_fbdev.c                   |  512 ++++++++
 drivers/gpu/drm/drm_gem_framebuffer_helper.c  |    1 -
 drivers/gpu/drm/drm_probe_helper.c            |    1 -
 drivers/gpu/drm/etnaviv/etnaviv_drv.h         |    3 +-
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c     |    6 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c     |    2 +-
 drivers/gpu/drm/gma500/framebuffer.c          |    6 +-
 drivers/gpu/drm/gud/gud_drv.c                 |    2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |    1 +
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |    1 -
 .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |    2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c       |    2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c   |    1 -
 drivers/gpu/drm/i915/display/intel_fbdev.c    |    8 +-
 drivers/gpu/drm/imx/dcss/dcss-kms.c           |    3 +-
 drivers/gpu/drm/imx/imx-drm-core.c            |    2 +-
 drivers/gpu/drm/imx/imx-ldb.c                 |    2 +-
 drivers/gpu/drm/imx/imx-tve.c                 |    1 -
 drivers/gpu/drm/imx/parallel-display.c        |    2 +-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |    3 +-
 drivers/gpu/drm/kmb/kmb_drv.c                 |    2 +-
 drivers/gpu/drm/kmb/kmb_plane.c               |    1 -
 drivers/gpu/drm/logicvc/logicvc_drm.c         |    2 +-
 drivers/gpu/drm/logicvc/logicvc_mode.c        |    2 -
 drivers/gpu/drm/mcde/mcde_drv.c               |    3 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |    2 +-
 drivers/gpu/drm/meson/meson_drv.c             |    2 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |    1 +
 drivers/gpu/drm/mgag200/mgag200_drv.h         |    1 -
 drivers/gpu/drm/msm/msm_fbdev.c               |    4 +-
 drivers/gpu/drm/mxsfb/lcdif_drv.c             |    2 +-
 drivers/gpu/drm/mxsfb/mxsfb_drv.c             |    2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c       |   27 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c          |    6 +-
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c  |    3 +-
 drivers/gpu/drm/pl111/pl111_drv.c             |    2 +-
 drivers/gpu/drm/qxl/qxl_drv.c                 |    1 +
 drivers/gpu/drm/qxl/qxl_drv.h                 |    1 -
 drivers/gpu/drm/radeon/radeon_fb.c            |    6 +-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c         |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h   |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c    |    2 -
 drivers/gpu/drm/solomon/ssd130x.c             |    2 +-
 drivers/gpu/drm/sti/sti_drv.c                 |    2 +-
 drivers/gpu/drm/stm/drv.c                     |    2 +-
 drivers/gpu/drm/sun4i/sun4i_drv.c             |    2 +-
 drivers/gpu/drm/tegra/fb.c                    |    8 +-
 drivers/gpu/drm/tidss/tidss_drv.c             |    2 +-
 drivers/gpu/drm/tidss/tidss_kms.c             |    1 -
 drivers/gpu/drm/tilcdc/tilcdc_drv.c           |    2 +-
 drivers/gpu/drm/tiny/arcpgu.c                 |    2 +-
 drivers/gpu/drm/tiny/bochs.c                  |    2 +-
 drivers/gpu/drm/tiny/cirrus.c                 |    2 +-
 drivers/gpu/drm/tiny/gm12u320.c               |    2 +-
 drivers/gpu/drm/tiny/hx8357d.c                |    2 +-
 drivers/gpu/drm/tiny/ili9163.c                |    2 +-
 drivers/gpu/drm/tiny/ili9225.c                |    2 +-
 drivers/gpu/drm/tiny/ili9341.c                |    2 +-
 drivers/gpu/drm/tiny/ili9486.c                |    2 +-
 drivers/gpu/drm/tiny/mi0283qt.c               |    2 +-
 drivers/gpu/drm/tiny/ofdrm.c                  |    2 +-
 drivers/gpu/drm/tiny/panel-mipi-dbi.c         |    2 +-
 drivers/gpu/drm/tiny/repaper.c                |    2 +-
 drivers/gpu/drm/tiny/simpledrm.c              |    2 +-
 drivers/gpu/drm/tiny/st7586.c                 |    2 +-
 drivers/gpu/drm/tiny/st7735r.c                |    2 +-
 drivers/gpu/drm/tve200/tve200_drv.c           |    3 +-
 drivers/gpu/drm/udl/udl_drv.c                 |    2 +-
 drivers/gpu/drm/v3d/v3d_drv.c                 |    1 -
 drivers/gpu/drm/vboxvideo/vbox_drv.c          |    4 +-
 drivers/gpu/drm/vboxvideo/vbox_main.c         |    1 -
 drivers/gpu/drm/vc4/vc4_drv.c                 |    2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c          |    1 +
 drivers/gpu/drm/virtio/virtgpu_drv.h          |    1 -
 drivers/gpu/drm/vkms/vkms_drv.c               |    2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c            |    3 +
 drivers/gpu/drm/xen/xen_drm_front_gem.c       |    1 -
 drivers/gpu/drm/xlnx/zynqmp_dpsub.c           |    2 +-
 include/drm/drm_fb_helper.h                   |   59 +-
 include/drm/drm_fbdev.h                       |   15 +
 99 files changed, 1019 insertions(+), 883 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_fbdev.c
 create mode 100644 include/drm/drm_fbdev.h


base-commit: 8c797a984264f04708d2099e83c85978a0fede89
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426428.674877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw8-0006Dt-V9; Thu, 20 Oct 2022 10:38:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426428.674877; Thu, 20 Oct 2022 10:38:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw8-0006Ar-Fq; Thu, 20 Oct 2022 10:38:04 +0000
Received: by outflank-mailman (input) for mailman id 426428;
 Thu, 20 Oct 2022 10:38:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw6-0005Jc-AF
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 44cb1658-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 540BF1FA34;
 Thu, 20 Oct 2022 10:38:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D1B0513AF5;
 Thu, 20 Oct 2022 10:37:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gLtLMgclUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:37:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44cb1658-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wfe4V8EQXU+OQKS3l1kyBjPu6yaqxe3odm+OUovraU8=;
	b=ihgfTJ5J709+rPMXFDj4uNgC6FmkN6D0x3zOugKW/edKZUb7MZ9GjAP0pVwAsaWVkiwCaJ
	Bxhc5uaCrz9BrbIyl0jI0k2B2uIgrYnSj9bXR4K3r3PrICoZQrI9F0Yx37pQHgRoCNQeL4
	t4rlXuRbKW0dLT3g1YF0QLQ6mdSYwl8=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262280;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wfe4V8EQXU+OQKS3l1kyBjPu6yaqxe3odm+OUovraU8=;
	b=oJAiMk8bqr+Bj4NMP4a4mKteU8kvjeIa4Kp+CbGTZb9h8jbLqvLj6PfNFBLKNMBTQQo7V0
	1D3gf1DxTWtmxpDg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 06/21] drm/mcde: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:40 +0200
Message-Id: <20221020103755.24058-7-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as mcde uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/mcde/mcde_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 1c4482ad507d9..38c3907bb151a 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -203,7 +203,6 @@ DEFINE_DRM_GEM_DMA_FOPS(drm_fops);
 static const struct drm_driver mcde_drm_driver = {
 	.driver_features =
 		DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
-	.lastclose = drm_fb_helper_lastclose,
 	.ioctls = NULL,
 	.fops = &drm_fops,
 	.name = "mcde",
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426427.674887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw9-0006W7-Sz; Thu, 20 Oct 2022 10:38:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426427.674887; Thu, 20 Oct 2022 10:38:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSw9-0006UF-EQ; Thu, 20 Oct 2022 10:38:05 +0000
Received: by outflank-mailman (input) for mailman id 426427;
 Thu, 20 Oct 2022 10:38:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw6-0005Jb-BD
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45607161-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:38:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5A5941FA44;
 Thu, 20 Oct 2022 10:38:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D649613B72;
 Thu, 20 Oct 2022 10:38:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id eOpuMwglUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45607161-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4LfKpOswsnembvGTw5A10DEjilDnUQNy6bx3ya4350M=;
	b=tXd3IWYpE+AANm0xpi3Q23Tyutj9Sdq9yA9FR/7DcSNXy96WtXWQGzMt9IwfCYTCBAQamd
	THr8pj7rjAn9jU+HaO5SQiMq017TXsYjJcjNLQX83/LJmys2bmCNMCVnK78mXNtDMQ+1z2
	WEXzB3SfIEWpTepTzbB9H+x+1MnkEYc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262281;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4LfKpOswsnembvGTw5A10DEjilDnUQNy6bx3ya4350M=;
	b=hfPPG9Hoyh//3cunThx+JTGWBet+d79xGzcyxY6nrUqT7snss1g85BmKsTMqO7P/1BTPnG
	RJfDSRgygYZyKVBw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 08/21] drm/vboxvideo: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:42 +0200
Message-Id: <20221020103755.24058-9-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as vboxvideo uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index f4f2bd79a7cb6..1cd716eb17a1c 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_drv.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c
@@ -178,8 +178,6 @@ static const struct drm_driver driver = {
 	.driver_features =
 	    DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
 
-	.lastclose = drm_fb_helper_lastclose,
-
 	.fops = &vbox_fops,
 	.name = DRIVER_NAME,
 	.desc = DRIVER_DESC,
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426430.674898 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwA-0006hX-Vw; Thu, 20 Oct 2022 10:38:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426430.674898; Thu, 20 Oct 2022 10:38:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwA-0006ec-Ad; Thu, 20 Oct 2022 10:38:06 +0000
Received: by outflank-mailman (input) for mailman id 426430;
 Thu, 20 Oct 2022 10:38:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw7-0005Jc-AQ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:03 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 45168606-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D2CAA22B47;
 Thu, 20 Oct 2022 10:38:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 598D613AF5;
 Thu, 20 Oct 2022 10:38:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UMn+FAglUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45168606-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jWFK76GZFYsgYwc+6vxSArga9uMmZ2Tc8oMprbqiqw0=;
	b=Ejd78jRSYmwnBxX2aipwC3Ox8skiLUbjtMay59sDp649DdHDOhbUxuiSAsJXDe59jzY039
	7m8t3LalhptMXwLVTrzVkCxp54leuuDcxIxewQ+X5Z1wJw/nYtKJ6C9nQ6NwMv8FXkTkGO
	3RqSYtiMQc/Rly3XWIlnJ+uGnR6kSNM=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262280;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jWFK76GZFYsgYwc+6vxSArga9uMmZ2Tc8oMprbqiqw0=;
	b=9Bhly1S29cGBzEZtlHvw8BUo8sDLPZ+WqFVhjceEyB7ynwh+OKfDst1qZxL/12nJNg8l+J
	LjNHGoN0NcLl8OAw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 07/21] drm/rockchip: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:41 +0200
Message-Id: <20221020103755.24058-8-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as rockchip uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 092bf863110b7..7de64b0ad047f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
@@ -9,7 +9,6 @@
 #include <drm/drm.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_damage_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
@@ -101,7 +100,6 @@ rockchip_fb_create(struct drm_device *dev, struct drm_file *file,
 
 static const struct drm_mode_config_funcs rockchip_drm_mode_config_funcs = {
 	.fb_create = rockchip_fb_create,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 	.atomic_check = drm_atomic_helper_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426429.674907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwC-00075a-BS; Thu, 20 Oct 2022 10:38:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426429.674907; Thu, 20 Oct 2022 10:38:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwB-0006ud-Mh; Thu, 20 Oct 2022 10:38:07 +0000
Received: by outflank-mailman (input) for mailman id 426429;
 Thu, 20 Oct 2022 10:38:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw7-0005Jb-A8
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:03 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 46042a42-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:38:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6D4FF1FA35;
 Thu, 20 Oct 2022 10:38:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DEF7113B72;
 Thu, 20 Oct 2022 10:38:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id eJSaNQklUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46042a42-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mu2A6Ru6vvqSAa8anfcgwfFu/Q/j4bw+8GKC1w2HMmA=;
	b=A0zYrW5gqOwD0UmgydO2eWGT2SqjAoP3lZQYxLBbjn1FD9iKZ+jXjtpUH4Wcx9BNQojmOb
	LfAIQZ9VEVbQ8DBB8c1HUrKsvGi9elrzyom5nU1i1S4XEuNggVcldX3aLZek/CnvnSeedU
	gPl5CBmbcXHi4Vbp4H4FbI+8afh2v8o=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262282;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mu2A6Ru6vvqSAa8anfcgwfFu/Q/j4bw+8GKC1w2HMmA=;
	b=2xAW0Xc2OoIRcV0fJ3IAQ47yQzwEXCQEcQPifH7AfQWKa3O1MepBsC39PfWI4G0Chr/PJa
	Q235JYSX8M+kcEDQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 10/21] drm/tve200: Include <linux/of.h>
Date: Thu, 20 Oct 2022 12:37:44 +0200
Message-Id: <20221020103755.24058-11-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Include <linux/of.h> for of_match_ptr().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tve200/tve200_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c
index 04db72e3fa9c2..611785e097576 100644
--- a/drivers/gpu/drm/tve200/tve200_drv.c
+++ b/drivers/gpu/drm/tve200/tve200_drv.c
@@ -32,6 +32,7 @@
 #include <linux/irq.h>
 #include <linux/io.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/shmem_fs.h>
 #include <linux/slab.h>
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426431.674920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwE-0007WE-2w; Thu, 20 Oct 2022 10:38:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426431.674920; Thu, 20 Oct 2022 10:38:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwD-0007Q6-P4; Thu, 20 Oct 2022 10:38:09 +0000
Received: by outflank-mailman (input) for mailman id 426431;
 Thu, 20 Oct 2022 10:38:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw8-0005Jb-4G
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 46552795-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:38:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E11901FA90;
 Thu, 20 Oct 2022 10:38:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 720DE13AF5;
 Thu, 20 Oct 2022 10:38:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id aMgYGwolUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46552795-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YkMHENyFsh6/3SjkSTuYRYMbHc7R5XzWBBCbrwJgYhc=;
	b=1iiK5H3VCq2QZPD9I6TaLe5/dMWlIhalrt5djJ2luVVaxnv1fAuIh/hwuw6a3/WNyh20Zx
	q30hl/TTc5vv9pZ08LkTAQW5UIo5mgzBkMj6j3gzxw0Alyq38w6Ako/4EdwH437ov9gCMb
	69LE0q28P52yd357VRsNAHoJ7rSH73s=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262282;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YkMHENyFsh6/3SjkSTuYRYMbHc7R5XzWBBCbrwJgYhc=;
	b=x46APQL1svgGc11HQOHFEs8osVroEdR2Ae3IDMhH3RiyBUJNS8G/LmoWWl6MsmYBLslbim
	A0NNGlzosuhEQTBQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 11/21] drm/fb-helper: Cleanup include statements in header file
Date: Thu, 20 Oct 2022 12:37:45 +0200
Message-Id: <20221020103755.24058-12-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Only include what we have to.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 include/drm/drm_fb_helper.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index fddd0d1af6891..e923089522896 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -32,11 +32,9 @@
 
 struct drm_fb_helper;
 
-#include <drm/drm_client.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_device.h>
 #include <linux/fb.h>
-#include <linux/kgdb.h>
+
+#include <drm/drm_client.h>
 
 enum mode_set_atomic {
 	LEAVE_ATOMIC_MODE_SET,
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426432.674934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwF-0007kT-Mf; Thu, 20 Oct 2022 10:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426432.674934; Thu, 20 Oct 2022 10:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwE-0007gh-QB; Thu, 20 Oct 2022 10:38:10 +0000
Received: by outflank-mailman (input) for mailman id 426432;
 Thu, 20 Oct 2022 10:38:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw8-0005Jc-AT
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 45b78ea5-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id DE84D1FA48;
 Thu, 20 Oct 2022 10:38:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5DB0613AF5;
 Thu, 20 Oct 2022 10:38:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YBkHFgklUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45b78ea5-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TEgpl55AepC361EexBBEYuHLTFWdn6vIDOCsAIRAdbs=;
	b=AJq1HDi4mThCywNbsDoinhziCOvhwOWDf/KaqbLD9BIxZWF3RJc8Q6yjFbAYUctj7cT5ab
	ILadHlCgqINQgo4eRiMLMe6NNhv5ATaD+RplwNroGQ8btG2hXvSpioeoFAgK/zzzrH6ohw
	0J+C55W94IIN5heAULo+EEO3yzDk4tI=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262281;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TEgpl55AepC361EexBBEYuHLTFWdn6vIDOCsAIRAdbs=;
	b=AQCoFHh+2wQhVT9GDAYJbWIYQLcMCP63/l5NM1FsXeL6KZxteKRzRGp//IUiBz30//HCHF
	VtwNVvPmLxS4YkBw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 09/21] drm/panel-ili9341: Include <linux/backlight.h>
Date: Thu, 20 Oct 2022 12:37:43 +0200
Message-Id: <20221020103755.24058-10-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Include <linux/backlight.h> for devm_of_find_backlight().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 39dc40cf681f0..b59472c29a40d 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -18,6 +18,7 @@
  * Copyright 2018 David Lechner <david@lechnology.com>
  */
 
+#include <linux/backlight.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426433.674940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwG-00081g-Pi; Thu, 20 Oct 2022 10:38:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426433.674940; Thu, 20 Oct 2022 10:38:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwG-0007yD-03; Thu, 20 Oct 2022 10:38:12 +0000
Received: by outflank-mailman (input) for mailman id 426433;
 Thu, 20 Oct 2022 10:38:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSw9-0005Jc-An
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:05 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46ae02aa-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 80EB022B48;
 Thu, 20 Oct 2022 10:38:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E660113B72;
 Thu, 20 Oct 2022 10:38:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UCqFNwolUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46ae02aa-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262283; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qQ5PlpSqpe+WsAWMvXTqCotx3I68o8k8GgPfYoiiu9Q=;
	b=FrKepO4HUQZ7EeTNyrB5cKyOz4cB7P4pRyExF6A7loFNR5MyscLm/a99RFZwqV8kGkX6l6
	t94mk6s+nPRcZb9HC2JZ/dgvNDVxQ7vSq6f/wKazKUf3UcuOi6XBBpNUfcPYm6ohqolbKv
	g4XQRAhUVLIaeTRxstKWqqvwqpx/6OQ=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262283;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qQ5PlpSqpe+WsAWMvXTqCotx3I68o8k8GgPfYoiiu9Q=;
	b=qP+Grg16N64S0dExPBO6MdPzg2FxX3cLM9J15+ZAQQwJG8/S2MykiD1n2DmYDh/yBDqklI
	tlpWfa1Tq5qIs/Bg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper
Date: Thu, 20 Oct 2022 12:37:46 +0200
Message-Id: <20221020103755.24058-13-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Rename struct drm_fb_helper.fbdev to info. The current name is
misleading as it overlaps with generic fbdev naming conventions.
Adapt to the usual naming in fbdev drivers by calling the field
'info'. No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c            | 40 +++++++++++-----------
 drivers/gpu/drm/i915/display/intel_fbdev.c |  2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c    | 23 ++++++-------
 drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 +-
 drivers/gpu/drm/tegra/fb.c                 |  2 +-
 include/drm/drm_fb_helper.h                |  4 +--
 6 files changed, 36 insertions(+), 37 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 71edb80fe0fb9..480bf4f568b7b 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -368,7 +368,7 @@ static void drm_fb_helper_resume_worker(struct work_struct *work)
 						    resume_work);
 
 	console_lock();
-	fb_set_suspend(helper->fbdev, 0);
+	fb_set_suspend(helper->info, 0);
 	console_unlock();
 }
 
@@ -401,7 +401,7 @@ static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper,
 		break;
 	}
 
-	src = fb_helper->fbdev->screen_buffer + offset;
+	src = fb_helper->info->screen_buffer + offset;
 	iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
 
 	for (y = clip->y1; y < clip->y2; y++) {
@@ -598,7 +598,7 @@ struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
 		goto err_free_cmap;
 	}
 
-	fb_helper->fbdev = info;
+	fb_helper->info = info;
 	info->skip_vt_switch = true;
 
 	return info;
@@ -621,8 +621,8 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
  */
 void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
 {
-	if (fb_helper && fb_helper->fbdev)
-		unregister_framebuffer(fb_helper->fbdev);
+	if (fb_helper && fb_helper->info)
+		unregister_framebuffer(fb_helper->info);
 }
 EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
 
@@ -647,13 +647,13 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
 	cancel_work_sync(&fb_helper->resume_work);
 	cancel_work_sync(&fb_helper->damage_work);
 
-	info = fb_helper->fbdev;
+	info = fb_helper->info;
 	if (info) {
 		if (info->cmap.len)
 			fb_dealloc_cmap(&info->cmap);
 		framebuffer_release(info);
 	}
-	fb_helper->fbdev = NULL;
+	fb_helper->info = NULL;
 
 	mutex_lock(&kernel_fb_helper_lock);
 	if (!list_empty(&fb_helper->kernel_fb_list)) {
@@ -914,8 +914,8 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit);
  */
 void drm_fb_helper_set_suspend(struct drm_fb_helper *fb_helper, bool suspend)
 {
-	if (fb_helper && fb_helper->fbdev)
-		fb_set_suspend(fb_helper->fbdev, suspend);
+	if (fb_helper && fb_helper->info)
+		fb_set_suspend(fb_helper->info, suspend);
 }
 EXPORT_SYMBOL(drm_fb_helper_set_suspend);
 
@@ -938,20 +938,20 @@ EXPORT_SYMBOL(drm_fb_helper_set_suspend);
 void drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper,
 					bool suspend)
 {
-	if (!fb_helper || !fb_helper->fbdev)
+	if (!fb_helper || !fb_helper->info)
 		return;
 
 	/* make sure there's no pending/ongoing resume */
 	flush_work(&fb_helper->resume_work);
 
 	if (suspend) {
-		if (fb_helper->fbdev->state != FBINFO_STATE_RUNNING)
+		if (fb_helper->info->state != FBINFO_STATE_RUNNING)
 			return;
 
 		console_lock();
 
 	} else {
-		if (fb_helper->fbdev->state == FBINFO_STATE_RUNNING)
+		if (fb_helper->info->state == FBINFO_STATE_RUNNING)
 			return;
 
 		if (!console_trylock()) {
@@ -960,7 +960,7 @@ void drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper,
 		}
 	}
 
-	fb_set_suspend(fb_helper->fbdev, suspend);
+	fb_set_suspend(fb_helper->info, suspend);
 	console_unlock();
 }
 EXPORT_SYMBOL(drm_fb_helper_set_suspend_unlocked);
@@ -1850,7 +1850,7 @@ EXPORT_SYMBOL(drm_fb_helper_fill_info);
 /*
  * This is a continuation of drm_setup_crtcs() that sets up anything related
  * to the framebuffer. During initialization, drm_setup_crtcs() is called before
- * the framebuffer has been allocated (fb_helper->fb and fb_helper->fbdev).
+ * the framebuffer has been allocated (fb_helper->fb and fb_helper->info).
  * So, any setup that touches those fields needs to be done here instead of in
  * drm_setup_crtcs().
  */
@@ -1858,7 +1858,7 @@ static void drm_setup_crtcs_fb(struct drm_fb_helper *fb_helper)
 {
 	struct drm_client_dev *client = &fb_helper->client;
 	struct drm_connector_list_iter conn_iter;
-	struct fb_info *info = fb_helper->fbdev;
+	struct fb_info *info = fb_helper->info;
 	unsigned int rotation, sw_rotations = 0;
 	struct drm_connector *connector;
 	struct drm_mode_set *modeset;
@@ -1942,7 +1942,7 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper,
 
 	fb_helper->deferred_setup = false;
 
-	info = fb_helper->fbdev;
+	info = fb_helper->info;
 	info->var.pixclock = 0;
 	/* Shamelessly allow physical address leaking to userspace */
 #if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
@@ -2077,7 +2077,7 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper)
 	drm_setup_crtcs_fb(fb_helper);
 	mutex_unlock(&fb_helper->lock);
 
-	drm_fb_helper_set_par(fb_helper->fbdev);
+	drm_fb_helper_set_par(fb_helper->info);
 
 	return 0;
 }
@@ -2135,7 +2135,7 @@ static int drm_fbdev_fb_release(struct fb_info *info, int user)
 
 static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)
 {
-	struct fb_info *fbi = fb_helper->fbdev;
+	struct fb_info *fbi = fb_helper->info;
 	void *shadow = NULL;
 
 	if (!fb_helper->dev)
@@ -2495,7 +2495,7 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
 {
 	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
 
-	if (fb_helper->fbdev)
+	if (fb_helper->info)
 		/* drm_fbdev_fb_destroy() takes care of cleanup */
 		drm_fb_helper_unregister_fbi(fb_helper);
 	else
@@ -2546,7 +2546,7 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
 	drm_fbdev_cleanup(fb_helper);
 err:
 	fb_helper->dev = NULL;
-	fb_helper->fbdev = NULL;
+	fb_helper->info = NULL;
 
 	drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret);
 
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 112aa0447a0dc..b73c6a16f46a0 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -627,7 +627,7 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous
 	if (!ifbdev || !ifbdev->vma)
 		goto set_suspend;
 
-	info = ifbdev->helper.fbdev;
+	info = ifbdev->helper.info;
 
 	if (synchronous) {
 		/* Flush any pending work to turn the console on, and then
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 3c7e0c9d6baf1..ac4bd529ae2e8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -231,9 +231,9 @@ void
 nouveau_fbcon_accel_save_disable(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
-	if (drm->fbcon && drm->fbcon->helper.fbdev) {
-		drm->fbcon->saved_flags = drm->fbcon->helper.fbdev->flags;
-		drm->fbcon->helper.fbdev->flags |= FBINFO_HWACCEL_DISABLED;
+	if (drm->fbcon && drm->fbcon->helper.info) {
+		drm->fbcon->saved_flags = drm->fbcon->helper.info->flags;
+		drm->fbcon->helper.info->flags |= FBINFO_HWACCEL_DISABLED;
 	}
 }
 
@@ -241,9 +241,8 @@ void
 nouveau_fbcon_accel_restore(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
-	if (drm->fbcon && drm->fbcon->helper.fbdev) {
-		drm->fbcon->helper.fbdev->flags = drm->fbcon->saved_flags;
-	}
+	if (drm->fbcon && drm->fbcon->helper.info)
+		drm->fbcon->helper.info->flags = drm->fbcon->saved_flags;
 }
 
 static void
@@ -253,8 +252,8 @@ nouveau_fbcon_accel_fini(struct drm_device *dev)
 	struct nouveau_fbdev *fbcon = drm->fbcon;
 	if (fbcon && drm->channel) {
 		console_lock();
-		if (fbcon->helper.fbdev)
-			fbcon->helper.fbdev->flags |= FBINFO_HWACCEL_DISABLED;
+		if (fbcon->helper.info)
+			fbcon->helper.info->flags |= FBINFO_HWACCEL_DISABLED;
 		console_unlock();
 		nouveau_channel_idle(drm->channel);
 		nvif_object_dtor(&fbcon->twod);
@@ -272,7 +271,7 @@ nouveau_fbcon_accel_init(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
 	struct nouveau_fbdev *fbcon = drm->fbcon;
-	struct fb_info *info = fbcon->helper.fbdev;
+	struct fb_info *info = fbcon->helper.info;
 	int ret;
 
 	if (drm->client.device.info.family < NV_DEVICE_INFO_V0_TESLA)
@@ -290,7 +289,7 @@ nouveau_fbcon_accel_init(struct drm_device *dev)
 static void
 nouveau_fbcon_zfill(struct drm_device *dev, struct nouveau_fbdev *fbcon)
 {
-	struct fb_info *info = fbcon->helper.fbdev;
+	struct fb_info *info = fbcon->helper.info;
 	struct fb_fillrect rect;
 
 	/* Clear the entire fbcon.  The drm will program every connector
@@ -586,8 +585,8 @@ nouveau_fbcon_init(struct drm_device *dev)
 	if (ret)
 		goto fini;
 
-	if (fbcon->helper.fbdev)
-		fbcon->helper.fbdev->pixmap.buf_align = 4;
+	if (fbcon->helper.info)
+		fbcon->helper.info->pixmap.buf_align = 4;
 	return 0;
 
 fini:
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index 40706c5aad7b5..f30aed64f6e20 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -38,7 +38,7 @@ static struct drm_fb_helper *get_fb(struct fb_info *fbi);
 static void pan_worker(struct work_struct *work)
 {
 	struct omap_fbdev *fbdev = container_of(work, struct omap_fbdev, work);
-	struct fb_info *fbi = fbdev->base.fbdev;
+	struct fb_info *fbi = fbdev->base.info;
 	int npages;
 
 	/* DMM roll shifts in 4K pages: */
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 9291209154a7a..e652ea6ec85df 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -261,7 +261,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 
 	fb = fbdev->fb;
 	helper->fb = fb;
-	helper->fbdev = info;
+	helper->info = info;
 
 	info->fbops = &tegra_fb_ops;
 
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index e923089522896..d83e2d8e92eb9 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -96,7 +96,7 @@ struct drm_fb_helper_funcs {
  * @fb: Scanout framebuffer object
  * @dev: DRM device
  * @funcs: driver callbacks for fb helper
- * @fbdev: emulated fbdev device info struct
+ * @info: emulated fbdev device info struct
  * @pseudo_palette: fake palette of 16 colors
  * @damage_clip: clip rectangle used with deferred_io to accumulate damage to
  *                the screen buffer
@@ -127,7 +127,7 @@ struct drm_fb_helper {
 	struct drm_framebuffer *fb;
 	struct drm_device *dev;
 	const struct drm_fb_helper_funcs *funcs;
-	struct fb_info *fbdev;
+	struct fb_info *info;
 	u32 pseudo_palette[17];
 	struct drm_clip_rect damage_clip;
 	spinlock_t damage_lock;
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426434.674951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwI-0008Hp-Ek; Thu, 20 Oct 2022 10:38:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426434.674951; Thu, 20 Oct 2022 10:38:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwH-0008EV-D5; Thu, 20 Oct 2022 10:38:13 +0000
Received: by outflank-mailman (input) for mailman id 426434;
 Thu, 20 Oct 2022 10:38:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwA-0005Jb-4c
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:06 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4784a346-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:38:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EA2601FA95;
 Thu, 20 Oct 2022 10:38:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7793913AF5;
 Thu, 20 Oct 2022 10:38:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8A1eHAwlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4784a346-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WYaJhA1ZHtKKCWMYOS0WRaraoDBAxhkucQ5O+wo9aPw=;
	b=mXgPSBHi5zawVPq5L+SD0KKV8aRm7HzIin4t1yNpngu8W3Mudmc0oZQGIuw/WdwCzRuUIJ
	8ibYdMO6894Ve286kK3at/kFHNNyw8XKCGKkdThOPhpTJJfoX3wiGmAr3VSgJEfZaUn9wd
	z6KAVuLN+cbs1NpinvsEaYlARdq1fxQ=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262284;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WYaJhA1ZHtKKCWMYOS0WRaraoDBAxhkucQ5O+wo9aPw=;
	b=aM3vHdXr1oe5eV20EoETfH0Th/uRu39nBt+QdwOhYVEnehjBh1+l1AyQi+ChSS+ZvbcqRs
	xGJPL47Xn6bXypCQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 15/21] drm/fb-helper: Disconnect damage worker from update logic
Date: Thu, 20 Oct 2022 12:37:49 +0200
Message-Id: <20221020103755.24058-16-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The fbdev helpers implement a damage worker that forwards fbdev
updates to the DRM driver. The worker's update logic depends on
the generic fbdev emulation. Separate the two via function pointer.

The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty,
a new callback that hides the update logic from the damage worker.
It's not possible to use the generic logic with other fbdev emulation,
because it contains additional code for the shadow buffering that
the generic emulation employs.

DRM drivers with internal fbdev emulation can set fb_dirty to their
own implementation if they require damage handling; although no such
drivers currently exist.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 75 ++++++++++++++++++++-------------
 include/drm/drm_fb_helper.h     | 15 +++++++
 2 files changed, 61 insertions(+), 29 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index bfbb2af144060..f6d22cc4cd876 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -448,35 +448,24 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper,
 
 static void drm_fb_helper_damage_work(struct work_struct *work)
 {
-	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper,
-						    damage_work);
-	struct drm_device *dev = helper->dev;
+	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	struct drm_clip_rect clip_copy;
 	unsigned long flags;
 	int ret;
 
+	if (!helper->funcs->fb_dirty)
+		return;
+
 	spin_lock_irqsave(&helper->damage_lock, flags);
 	clip_copy = *clip;
 	clip->x1 = clip->y1 = ~0;
 	clip->x2 = clip->y2 = 0;
 	spin_unlock_irqrestore(&helper->damage_lock, flags);
 
-	/* Call damage handlers only if necessary */
-	if (!(clip_copy.x1 < clip_copy.x2 && clip_copy.y1 < clip_copy.y2))
-		return;
-
-	if (helper->buffer) {
-		ret = drm_fb_helper_damage_blit(helper, &clip_copy);
-		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
-			goto err;
-	}
-
-	if (helper->fb->funcs->dirty) {
-		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1);
-		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
-			goto err;
-	}
+	ret = helper->funcs->fb_dirty(helper, &clip_copy);
+	if (ret)
+		goto err;
 
 	return;
 
@@ -670,16 +659,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
 }
 EXPORT_SYMBOL(drm_fb_helper_fini);
 
-static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
-{
-	struct drm_device *dev = fb_helper->dev;
-	struct drm_framebuffer *fb = fb_helper->fb;
-
-	return dev->mode_config.prefer_shadow_fbdev ||
-	       dev->mode_config.prefer_shadow ||
-	       fb->funcs->dirty;
-}
-
 static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y,
 				 u32 width, u32 height)
 {
@@ -687,7 +666,7 @@ static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y,
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	unsigned long flags;
 
-	if (!drm_fbdev_use_shadow_fb(helper))
+	if (!helper->funcs->fb_dirty)
 		return;
 
 	spin_lock_irqsave(&helper->damage_lock, flags);
@@ -2111,6 +2090,16 @@ void drm_fb_helper_output_poll_changed(struct drm_device *dev)
 }
 EXPORT_SYMBOL(drm_fb_helper_output_poll_changed);
 
+static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
+{
+	struct drm_device *dev = fb_helper->dev;
+	struct drm_framebuffer *fb = fb_helper->fb;
+
+	return dev->mode_config.prefer_shadow_fbdev ||
+	       dev->mode_config.prefer_shadow ||
+	       fb->funcs->dirty;
+}
+
 /* @user: 1=userspace, 0=fbcon */
 static int drm_fbdev_fb_open(struct fb_info *info, int user)
 {
@@ -2487,8 +2476,36 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,
 	return 0;
 }
 
+static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
+{
+	struct drm_device *dev = helper->dev;
+	int ret;
+
+	if (!drm_fbdev_use_shadow_fb(helper))
+		return 0;
+
+	/* Call damage handlers only if necessary */
+	if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
+		return 0;
+
+	if (helper->buffer) {
+		ret = drm_fb_helper_damage_blit(helper, clip);
+		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	if (helper->fb->funcs->dirty) {
+		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
+		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	return 0;
+}
+
 static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = {
 	.fb_probe = drm_fb_helper_generic_probe,
+	.fb_dirty = drm_fbdev_fb_dirty,
 };
 
 static void drm_fbdev_client_unregister(struct drm_client_dev *client)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index edc697a2fde24..3d7a3d68dab8a 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -30,6 +30,7 @@
 #ifndef DRM_FB_HELPER_H
 #define DRM_FB_HELPER_H
 
+struct drm_clip_rect;
 struct drm_fb_helper;
 
 #include <linux/fb.h>
@@ -89,6 +90,20 @@ struct drm_fb_helper_funcs {
 	 */
 	int (*fb_probe)(struct drm_fb_helper *helper,
 			struct drm_fb_helper_surface_size *sizes);
+
+	/**
+	 * @fb_dirty:
+	 *
+	 * Driver callback to update the framebuffer memory. If set, fbdev
+	 * emulation will invoke this callback in regular intervals after
+	 * the framebuffer has been written.
+	 *
+	 * This callback is optional.
+	 *
+	 * Returns:
+	 * 0 on success, or an error code otherwise.
+	 */
+	int (*fb_dirty)(struct drm_fb_helper *helper, struct drm_clip_rect *clip);
 };
 
 /**
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426435.674960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwK-0000GU-OS; Thu, 20 Oct 2022 10:38:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426435.674960; Thu, 20 Oct 2022 10:38:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwJ-000090-2o; Thu, 20 Oct 2022 10:38:15 +0000
Received: by outflank-mailman (input) for mailman id 426435;
 Thu, 20 Oct 2022 10:38:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwA-0005Jc-BC
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:06 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 46f47fb3-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:04 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id F340E22B43;
 Thu, 20 Oct 2022 10:38:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 85D4813AF5;
 Thu, 20 Oct 2022 10:38:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IJPwHwslUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46f47fb3-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XLtdoFG3t9K/FkdzkuKNiHmWsCp4LPOGp2v06LJpDy0=;
	b=sHTEeO1Y9+cHrfBx3UESomI73p/bN7rJhCUC7qstDFGgOJkYmiBC/5iC3zX0hjtkXXwdx7
	ie0hJ1xGvxp/6eBxsSVHzLhsbctqCp7ByzKv23cgX6u+/8KTymAKwkoMHuReGIBlcWtWlb
	0W5E2/LM9daulasM5xn8FKh+61AAKRA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262284;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XLtdoFG3t9K/FkdzkuKNiHmWsCp4LPOGp2v06LJpDy0=;
	b=FZ0V7FeanFp6ft5Hzqg9CG7S9/Lqslb4mBOhrccx6y8atx81z1HdxAaBVdh/yh08UZ8maA
	rfSrCSsJYHNaDEAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix
Date: Thu, 20 Oct 2022 12:37:47 +0200
Message-Id: <20221020103755.24058-14-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as
part of unifying the naming within fbdev helpers. Adapt drivers. No
functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      | 2 +-
 drivers/gpu/drm/drm_fb_helper.c            | 8 ++++----
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  | 2 +-
 drivers/gpu/drm/gma500/framebuffer.c       | 2 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
 drivers/gpu/drm/msm/msm_fbdev.c            | 2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c    | 2 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c       | 2 +-
 drivers/gpu/drm/radeon/radeon_fb.c         | 2 +-
 drivers/gpu/drm/tegra/fb.c                 | 2 +-
 include/drm/drm_fb_helper.h                | 4 ++--
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index 38f5170c0fea6..eaae98d9377ae 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -72,7 +72,7 @@ static int armada_fbdev_create(struct drm_fb_helper *fbh,
 	if (IS_ERR(dfb))
 		return PTR_ERR(dfb);
 
-	info = drm_fb_helper_alloc_fbi(fbh);
+	info = drm_fb_helper_alloc_info(fbh);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto err_fballoc;
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 480bf4f568b7b..881e6a04fa706 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -558,7 +558,7 @@ int drm_fb_helper_init(struct drm_device *dev,
 EXPORT_SYMBOL(drm_fb_helper_init);
 
 /**
- * drm_fb_helper_alloc_fbi - allocate fb_info and some of its members
+ * drm_fb_helper_alloc_info - allocate fb_info and some of its members
  * @fb_helper: driver-allocated fbdev helper
  *
  * A helper to alloc fb_info and the members cmap and apertures. Called
@@ -570,7 +570,7 @@ EXPORT_SYMBOL(drm_fb_helper_init);
  * fb_info pointer if things went okay, pointer containing error code
  * otherwise
  */
-struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
+struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 {
 	struct device *dev = fb_helper->dev->dev;
 	struct fb_info *info;
@@ -609,7 +609,7 @@ struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
 	framebuffer_release(info);
 	return ERR_PTR(ret);
 }
-EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
+EXPORT_SYMBOL(drm_fb_helper_alloc_info);
 
 /**
  * drm_fb_helper_unregister_fbi - unregister fb_info framebuffer device
@@ -2440,7 +2440,7 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,
 	fb_helper->fb = buffer->fb;
 	fb = buffer->fb;
 
-	fbi = drm_fb_helper_alloc_fbi(fb_helper);
+	fbi = drm_fb_helper_alloc_info(fb_helper);
 	if (IS_ERR(fbi))
 		return PTR_ERR(fbi);
 
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 767afd2bfa822..8741eb0b1b604 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -63,7 +63,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
 	unsigned int size = fb->width * fb->height * fb->format->cpp[0];
 	unsigned long offset;
 
-	fbi = drm_fb_helper_alloc_fbi(helper);
+	fbi = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(fbi)) {
 		DRM_DEV_ERROR(to_dma_dev(helper->dev),
 			      "failed to allocate fb info.\n");
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index aa3ecf771fd36..a5fad2483fa3a 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -268,7 +268,7 @@ static int psbfb_create(struct drm_fb_helper *fb_helper,
 
 	memset(dev_priv->vram_addr + backing->offset, 0, size);
 
-	info = drm_fb_helper_alloc_fbi(fb_helper);
+	info = drm_fb_helper_alloc_info(fb_helper);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto err_drm_gem_object_put;
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index b73c6a16f46a0..a1357acb5a1c6 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -254,7 +254,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
 		goto out_unlock;
 	}
 
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		drm_err(&dev_priv->drm, "Failed to allocate fb_info\n");
 		ret = PTR_ERR(info);
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 46168eccfac4a..3de661730a8bb 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -93,7 +93,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
 		goto fail;
 	}
 
-	fbi = drm_fb_helper_alloc_fbi(helper);
+	fbi = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(fbi)) {
 		DRM_DEV_ERROR(dev->dev, "failed to allocate fb info\n");
 		ret = PTR_ERR(fbi);
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index ac4bd529ae2e8..fca40124fc17c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -362,7 +362,7 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
 		}
 	}
 
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto out_unlock;
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index f30aed64f6e20..b21ead9aca2d5 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -161,7 +161,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper,
 		goto fail;
 	}
 
-	fbi = drm_fb_helper_alloc_fbi(helper);
+	fbi = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(fbi)) {
 		dev_err(dev->dev, "failed to allocate fb info\n");
 		ret = PTR_ERR(fbi);
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 6ccea51d40722..2dc96fdd35f9f 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -243,7 +243,7 @@ static int radeonfb_create(struct drm_fb_helper *helper,
 	rbo = gem_to_radeon_bo(gobj);
 
 	/* okay we have an object now allocate the framebuffer */
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto out;
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index e652ea6ec85df..d5a9c800ef829 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -243,7 +243,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 	if (IS_ERR(bo))
 		return PTR_ERR(bo);
 
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		dev_err(drm->dev, "failed to allocate framebuffer info\n");
 		drm_gem_object_put(&bo->gem);
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index d83e2d8e92eb9..5ec9d9c68d144 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -222,7 +222,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
 
 int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper);
 
-struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper);
+struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper);
 void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper);
 void drm_fb_helper_fill_info(struct fb_info *info,
 			     struct drm_fb_helper *fb_helper,
@@ -320,7 +320,7 @@ drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper)
 }
 
 static inline struct fb_info *
-drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
+drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 {
 	return NULL;
 }
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426436.674972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwN-00013d-NS; Thu, 20 Oct 2022 10:38:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426436.674972; Thu, 20 Oct 2022 10:38:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwM-0000t7-MP; Thu, 20 Oct 2022 10:38:18 +0000
Received: by outflank-mailman (input) for mailman id 426436;
 Thu, 20 Oct 2022 10:38:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwB-0005Jc-B4
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:07 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4751c892-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:04 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7ECD822B49;
 Thu, 20 Oct 2022 10:38:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0277D13B72;
 Thu, 20 Oct 2022 10:38:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IJ5bOwslUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4751c892-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=h8c99GytuoJzrJihpm1pKQrZqtXWmjZRCdXW03uirZQ=;
	b=H8L9kq6U0On6TnRNX2EE3bIK/PDmpLC3TnsCtJc8+Y2AZ3amwYPaWiUUzU1/2a5iZ6i5c5
	bPnGd+sk0y0IKOW2FDcfuGPdAoUHzwbAicH2HNa6l4BXsNgwtxImknuWVHtTREi2Rt4UGn
	ZYdCtdzDcfimy2W0FvYEVVXz/yxpJkw=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262284;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=h8c99GytuoJzrJihpm1pKQrZqtXWmjZRCdXW03uirZQ=;
	b=Erx7Mr6/i048deZ8DTUVe6rkVQHHK1LBpPOmgpA94l4P8bJoztUkyaPZKcIDImZIwZ4s3c
	U3OLhI8xqukE3cAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix
Date: Thu, 20 Oct 2022 12:37:48 +0200
Message-Id: <20221020103755.24058-15-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info()
as part of unifying the naming within fbdev helpers. Adapt drivers. No
functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      | 2 +-
 drivers/gpu/drm/drm_fb_helper.c            | 8 ++++----
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  | 2 +-
 drivers/gpu/drm/gma500/framebuffer.c       | 2 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
 drivers/gpu/drm/msm/msm_fbdev.c            | 2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c    | 2 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c       | 2 +-
 drivers/gpu/drm/radeon/radeon_fb.c         | 2 +-
 drivers/gpu/drm/tegra/fb.c                 | 2 +-
 include/drm/drm_fb_helper.h                | 4 ++--
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index eaae98d9377ae..f02f6a5ba8320 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -155,7 +155,7 @@ void armada_fbdev_fini(struct drm_device *dev)
 	struct drm_fb_helper *fbh = priv->fbdev;
 
 	if (fbh) {
-		drm_fb_helper_unregister_fbi(fbh);
+		drm_fb_helper_unregister_info(fbh);
 
 		drm_fb_helper_fini(fbh);
 
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 881e6a04fa706..bfbb2af144060 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -612,19 +612,19 @@ struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 EXPORT_SYMBOL(drm_fb_helper_alloc_info);
 
 /**
- * drm_fb_helper_unregister_fbi - unregister fb_info framebuffer device
+ * drm_fb_helper_unregister_info - unregister fb_info framebuffer device
  * @fb_helper: driver-allocated fbdev helper, can be NULL
  *
  * A wrapper around unregister_framebuffer, to release the fb_info
  * framebuffer device. This must be called before releasing all resources for
  * @fb_helper by calling drm_fb_helper_fini().
  */
-void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
+void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper)
 {
 	if (fb_helper && fb_helper->info)
 		unregister_framebuffer(fb_helper->info);
 }
-EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
+EXPORT_SYMBOL(drm_fb_helper_unregister_info);
 
 /**
  * drm_fb_helper_fini - finialize a &struct drm_fb_helper
@@ -2497,7 +2497,7 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
 
 	if (fb_helper->info)
 		/* drm_fbdev_fb_destroy() takes care of cleanup */
-		drm_fb_helper_unregister_fbi(fb_helper);
+		drm_fb_helper_unregister_info(fb_helper);
 	else
 		drm_fbdev_release(fb_helper);
 }
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 8741eb0b1b604..86c489d945849 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -201,7 +201,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
 			drm_framebuffer_remove(fb);
 	}
 
-	drm_fb_helper_unregister_fbi(fb_helper);
+	drm_fb_helper_unregister_info(fb_helper);
 
 	drm_fb_helper_fini(fb_helper);
 }
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index a5fad2483fa3a..bee4ce24904f6 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -383,7 +383,7 @@ static int psb_fbdev_destroy(struct drm_device *dev,
 {
 	struct drm_framebuffer *fb = fb_helper->fb;
 
-	drm_fb_helper_unregister_fbi(fb_helper);
+	drm_fb_helper_unregister_info(fb_helper);
 
 	drm_fb_helper_fini(fb_helper);
 	drm_framebuffer_unregister_private(fb);
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index a1357acb5a1c6..0ac78b9718684 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -584,7 +584,7 @@ void intel_fbdev_unregister(struct drm_i915_private *dev_priv)
 	if (!current_is_async())
 		intel_fbdev_sync(ifbdev);
 
-	drm_fb_helper_unregister_fbi(&ifbdev->helper);
+	drm_fb_helper_unregister_info(&ifbdev->helper);
 }
 
 void intel_fbdev_fini(struct drm_i915_private *dev_priv)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 3de661730a8bb..0670c98b9c5cc 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -184,7 +184,7 @@ void msm_fbdev_free(struct drm_device *dev)
 
 	DBG();
 
-	drm_fb_helper_unregister_fbi(helper);
+	drm_fb_helper_unregister_info(helper);
 
 	drm_fb_helper_fini(helper);
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index fca40124fc17c..e87de7906f780 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -419,7 +419,7 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon)
 	struct drm_framebuffer *fb = fbcon->helper.fb;
 	struct nouveau_bo *nvbo;
 
-	drm_fb_helper_unregister_fbi(&fbcon->helper);
+	drm_fb_helper_unregister_info(&fbcon->helper);
 	drm_fb_helper_fini(&fbcon->helper);
 
 	if (fb && fb->obj[0]) {
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index b21ead9aca2d5..537c759453ce1 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -274,7 +274,7 @@ void omap_fbdev_fini(struct drm_device *dev)
 	if (!helper)
 		return;
 
-	drm_fb_helper_unregister_fbi(helper);
+	drm_fb_helper_unregister_info(helper);
 
 	drm_fb_helper_fini(helper);
 
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 2dc96fdd35f9f..936df79decc57 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -309,7 +309,7 @@ static int radeon_fbdev_destroy(struct drm_device *dev, struct radeon_fbdev *rfb
 {
 	struct drm_framebuffer *fb = &rfbdev->fb;
 
-	drm_fb_helper_unregister_fbi(&rfbdev->helper);
+	drm_fb_helper_unregister_info(&rfbdev->helper);
 
 	if (fb->obj[0]) {
 		radeonfb_destroy_pinned_object(fb->obj[0]);
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index d5a9c800ef829..30fac20665f4e 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -348,7 +348,7 @@ static int tegra_fbdev_init(struct tegra_fbdev *fbdev,
 
 static void tegra_fbdev_exit(struct tegra_fbdev *fbdev)
 {
-	drm_fb_helper_unregister_fbi(&fbdev->base);
+	drm_fb_helper_unregister_info(&fbdev->base);
 
 	if (fbdev->fb) {
 		struct tegra_bo *bo = tegra_fb_get_plane(fbdev->fb, 0);
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 5ec9d9c68d144..edc697a2fde24 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -223,7 +223,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
 int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper);
 
 struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper);
-void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper);
+void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper);
 void drm_fb_helper_fill_info(struct fb_info *info,
 			     struct drm_fb_helper *fb_helper,
 			     struct drm_fb_helper_surface_size *sizes);
@@ -325,7 +325,7 @@ drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 	return NULL;
 }
 
-static inline void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
+static inline void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper)
 {
 }
 
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426437.674985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwQ-0001bY-2a; Thu, 20 Oct 2022 10:38:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426437.674985; Thu, 20 Oct 2022 10:38:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwO-0001T5-O4; Thu, 20 Oct 2022 10:38:20 +0000
Received: by outflank-mailman (input) for mailman id 426437;
 Thu, 20 Oct 2022 10:38:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwB-0005Jb-Oh
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:08 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 48171e9b-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:38:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id DE9FE22B4B;
 Thu, 20 Oct 2022 10:38:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6EE9A13AF5;
 Thu, 20 Oct 2022 10:38:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8HNZGg0lUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48171e9b-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8Be+tzsOVsbK7gq98qYnoedx5VlVHIs33U4RSar4iO4=;
	b=tHP74gB+KrvtV1wO12GWLOb4TmmEQIramZWfi4MCH9EPqyClDEZDnYx4/CpIJQoIExDFkN
	+26MMxzIs7Y9Z3pi5kUTcIIhh+rA71boAOAvkRBVTI0YzX1SBfDJaH6fqVbmd6N58wCYOW
	hdPia0q1T1DoqR/lwn/O4n7/jwcL5eM=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262285;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8Be+tzsOVsbK7gq98qYnoedx5VlVHIs33U4RSar4iO4=;
	b=MCER/5P8Lpe1m+NgskMCy0y/EoxXdAWnFSk07+eRPDCkJf4Ax3RHExol4mz6b/5FUtahvV
	N47kiq4GVHWS9VAg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation
Date: Thu, 20 Oct 2022 12:37:51 +0200
Message-Id: <20221020103755.24058-18-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Implement the fbdev's read/write helpers with the same functions. Use
the generic fbdev's code as template. Convert all drivers.

DRM's fb helpers must implement regular I/O functionality in struct
fb_ops and possibly perform a damage update. Handle all this in the
same functions and convert drivers. The functionality has been used
as part of the generic fbdev code for some time. The drivers don't
set struct drm_fb_helper.fb_dirty, so they will not be affected by
damage handling.

For I/O memory, fb helpers now provide drm_fb_helper_cfb_read() and
drm_fb_helper_cfb_write(). Several drivers require these. Until now
tegra used I/O read and write, although the memory buffer appears to
be in system memory. So use _sys_ helpers now.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      |   2 +
 drivers/gpu/drm/drm_fb_helper.c            | 383 ++++++++++++---------
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |   2 +
 drivers/gpu/drm/gma500/framebuffer.c       |   2 +
 drivers/gpu/drm/i915/display/intel_fbdev.c |   2 +
 drivers/gpu/drm/radeon/radeon_fb.c         |   2 +
 drivers/gpu/drm/tegra/fb.c                 |   2 +
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c         |   3 +
 include/drm/drm_fb_helper.h                |  17 +
 9 files changed, 257 insertions(+), 158 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index f02f6a5ba8320..584cee123bd8e 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -19,6 +19,8 @@
 static const struct fb_ops armada_fb_ops = {
 	.owner		= THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
+	.fb_read	= drm_fb_helper_cfb_read,
+	.fb_write	= drm_fb_helper_cfb_write,
 	.fb_fillrect	= drm_fb_helper_cfb_fillrect,
 	.fb_copyarea	= drm_fb_helper_cfb_copyarea,
 	.fb_imageblit	= drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 379e0d2f67198..836523aef6a27 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -747,30 +747,132 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli
 }
 EXPORT_SYMBOL(drm_fb_helper_deferred_io);
 
+typedef ssize_t (*drm_fb_helper_read_screen)(struct fb_info *info, char __user *buf,
+					     size_t count, loff_t pos);
+
+static ssize_t __drm_fb_helper_read(struct fb_info *info, char __user *buf, size_t count,
+				    loff_t *ppos, drm_fb_helper_read_screen read_screen)
+{
+	loff_t pos = *ppos;
+	size_t total_size;
+	ssize_t ret;
+
+	if (info->screen_size)
+		total_size = info->screen_size;
+	else
+		total_size = info->fix.smem_len;
+
+	if (pos >= total_size)
+		return 0;
+	if (count >= total_size)
+		count = total_size;
+	if (total_size - count < pos)
+		count = total_size - pos;
+
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
+	ret = read_screen(info, buf, count, pos);
+	if (ret > 0)
+		*ppos += ret;
+
+	return ret;
+}
+
+typedef ssize_t (*drm_fb_helper_write_screen)(struct fb_info *info, const char __user *buf,
+					      size_t count, loff_t pos);
+
+static ssize_t __drm_fb_helper_write(struct fb_info *info, const char __user *buf, size_t count,
+				     loff_t *ppos, drm_fb_helper_write_screen write_screen)
+{
+	loff_t pos = *ppos;
+	size_t total_size;
+	ssize_t ret;
+	int err = 0;
+
+	if (info->screen_size)
+		total_size = info->screen_size;
+	else
+		total_size = info->fix.smem_len;
+
+	if (pos > total_size)
+		return -EFBIG;
+	if (count > total_size) {
+		err = -EFBIG;
+		count = total_size;
+	}
+	if (total_size - count < pos) {
+		if (!err)
+			err = -ENOSPC;
+		count = total_size - pos;
+	}
+
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
+	/*
+	 * Copy to framebuffer even if we already logged an error. Emulates
+	 * the behavior of the original fbdev implementation.
+	 */
+	ret = write_screen(info, buf, count, pos);
+	if (ret < 0)
+		return ret; /* return last error, if any */
+	else if (!ret)
+		return err; /* return previous error, if any */
+
+	*ppos += ret;
+
+	return ret;
+}
+
+static ssize_t drm_fb_helper_read_screen_buffer(struct fb_info *info, char __user *buf,
+						size_t count, loff_t pos)
+{
+	const char *src = info->screen_buffer + pos;
+
+	if (copy_to_user(buf, src, count))
+		return -EFAULT;
+
+	return count;
+}
+
 /**
- * drm_fb_helper_sys_read - wrapper around fb_sys_read
+ * drm_fb_helper_sys_read - Implements struct &fb_ops.fb_read for system memory
  * @info: fb_info struct pointer
  * @buf: userspace buffer to read from framebuffer memory
  * @count: number of bytes to read from framebuffer memory
  * @ppos: read offset within framebuffer memory
  *
- * A wrapper around fb_sys_read implemented by fbdev core
+ * Returns:
+ * The number of read bytes on success, or an error code otherwise.
  */
 ssize_t drm_fb_helper_sys_read(struct fb_info *info, char __user *buf,
 			       size_t count, loff_t *ppos)
 {
-	return fb_sys_read(info, buf, count, ppos);
+	return __drm_fb_helper_read(info, buf, count, ppos, drm_fb_helper_read_screen_buffer);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_read);
 
+static ssize_t drm_fb_helper_write_screen_buffer(struct fb_info *info, const char __user *buf,
+						 size_t count, loff_t pos)
+{
+	char *dst = info->screen_buffer + pos;
+
+	if (copy_from_user(dst, buf, count))
+		return -EFAULT;
+
+	return count;
+}
+
 /**
- * drm_fb_helper_sys_write - wrapper around fb_sys_write
+ * drm_fb_helper_sys_write - Implements struct &fb_ops.fb_write for system memory
  * @info: fb_info struct pointer
  * @buf: userspace buffer to write to framebuffer memory
  * @count: number of bytes to write to framebuffer memory
  * @ppos: write offset within framebuffer memory
  *
- * A wrapper around fb_sys_write implemented by fbdev core
+ * Returns:
+ * The number of written bytes on success, or an error code otherwise.
  */
 ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 				size_t count, loff_t *ppos)
@@ -779,7 +881,7 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 	ssize_t ret;
 	struct drm_rect damage_area;
 
-	ret = fb_sys_write(info, buf, count, ppos);
+	ret = __drm_fb_helper_write(info, buf, count, ppos, drm_fb_helper_write_screen_buffer);
 	if (ret <= 0)
 		return ret;
 
@@ -837,6 +939,119 @@ void drm_fb_helper_sys_imageblit(struct fb_info *info,
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_imageblit);
 
+static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count,
+				   loff_t pos)
+{
+	const char __iomem *src = info->screen_base + pos;
+	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
+	ssize_t ret = 0;
+	int err = 0;
+	char *tmp;
+
+	tmp = kmalloc(alloc_size, GFP_KERNEL);
+	if (!tmp)
+		return -ENOMEM;
+
+	while (count) {
+		size_t c = min_t(size_t, count, alloc_size);
+
+		memcpy_fromio(tmp, src, c);
+		if (copy_to_user(buf, tmp, c)) {
+			err = -EFAULT;
+			break;
+		}
+
+		src += c;
+		buf += c;
+		ret += c;
+		count -= c;
+	}
+
+	kfree(tmp);
+
+	return ret ? ret : err;
+}
+
+/**
+ * drm_fb_helper_cfb_read - Implements struct &fb_ops.fb_read for I/O memory
+ * @info: fb_info struct pointer
+ * @buf: userspace buffer to read from framebuffer memory
+ * @count: number of bytes to read from framebuffer memory
+ * @ppos: read offset within framebuffer memory
+ *
+ * Returns:
+ * The number of read bytes on success, or an error code otherwise.
+ */
+ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf,
+			       size_t count, loff_t *ppos)
+{
+	return __drm_fb_helper_read(info, buf, count, ppos, fb_read_screen_base);
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_read);
+
+static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count,
+				    loff_t pos)
+{
+	char __iomem *dst = info->screen_base + pos;
+	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
+	ssize_t ret = 0;
+	int err = 0;
+	u8 *tmp;
+
+	tmp = kmalloc(alloc_size, GFP_KERNEL);
+	if (!tmp)
+		return -ENOMEM;
+
+	while (count) {
+		size_t c = min_t(size_t, count, alloc_size);
+
+		if (copy_from_user(tmp, buf, c)) {
+			err = -EFAULT;
+			break;
+		}
+		memcpy_toio(dst, tmp, c);
+
+		dst += c;
+		buf += c;
+		ret += c;
+		count -= c;
+	}
+
+	kfree(tmp);
+
+	return ret ? ret : err;
+}
+
+/**
+ * drm_fb_helper_cfb_write - Implements struct &fb_ops.fb_write for I/O memory
+ * @info: fb_info struct pointer
+ * @buf: userspace buffer to write to framebuffer memory
+ * @count: number of bytes to write to framebuffer memory
+ * @ppos: write offset within framebuffer memory
+ *
+ * Returns:
+ * The number of written bytes on success, or an error code otherwise.
+ */
+ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
+				size_t count, loff_t *ppos)
+{
+	loff_t pos = *ppos;
+	ssize_t ret;
+	struct drm_rect damage_area;
+
+	ret = __drm_fb_helper_write(info, buf, count, ppos, fb_write_screen_base);
+	if (ret <= 0)
+		return ret;
+
+	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
+	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
+			     drm_rect_width(&damage_area),
+			     drm_rect_height(&damage_area));
+
+	return ret;
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_write);
+
 /**
  * drm_fb_helper_cfb_fillrect - wrapper around cfb_fillrect
  * @info: fbdev registered by the helper
@@ -2183,176 +2398,28 @@ static bool drm_fbdev_use_iomem(struct fb_info *info)
 	return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem;
 }
 
-static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count,
-				   loff_t pos)
-{
-	const char __iomem *src = info->screen_base + pos;
-	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
-	ssize_t ret = 0;
-	int err = 0;
-	char *tmp;
-
-	tmp = kmalloc(alloc_size, GFP_KERNEL);
-	if (!tmp)
-		return -ENOMEM;
-
-	while (count) {
-		size_t c = min_t(size_t, count, alloc_size);
-
-		memcpy_fromio(tmp, src, c);
-		if (copy_to_user(buf, tmp, c)) {
-			err = -EFAULT;
-			break;
-		}
-
-		src += c;
-		buf += c;
-		ret += c;
-		count -= c;
-	}
-
-	kfree(tmp);
-
-	return ret ? ret : err;
-}
-
-static ssize_t fb_read_screen_buffer(struct fb_info *info, char __user *buf, size_t count,
-				     loff_t pos)
-{
-	const char *src = info->screen_buffer + pos;
-
-	if (copy_to_user(buf, src, count))
-		return -EFAULT;
-
-	return count;
-}
-
 static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
 				 size_t count, loff_t *ppos)
 {
-	loff_t pos = *ppos;
-	size_t total_size;
 	ssize_t ret;
 
-	if (info->screen_size)
-		total_size = info->screen_size;
-	else
-		total_size = info->fix.smem_len;
-
-	if (pos >= total_size)
-		return 0;
-	if (count >= total_size)
-		count = total_size;
-	if (total_size - count < pos)
-		count = total_size - pos;
-
-	if (info->fbops->fb_sync)
-		info->fbops->fb_sync(info);
-
 	if (drm_fbdev_use_iomem(info))
-		ret = fb_read_screen_base(info, buf, count, pos);
+		ret = drm_fb_helper_cfb_read(info, buf, count, ppos);
 	else
-		ret = fb_read_screen_buffer(info, buf, count, pos);
-
-	if (ret > 0)
-		*ppos += ret;
+		ret = drm_fb_helper_sys_read(info, buf, count, ppos);
 
 	return ret;
 }
 
-static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count,
-				    loff_t pos)
-{
-	char __iomem *dst = info->screen_base + pos;
-	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
-	ssize_t ret = 0;
-	int err = 0;
-	u8 *tmp;
-
-	tmp = kmalloc(alloc_size, GFP_KERNEL);
-	if (!tmp)
-		return -ENOMEM;
-
-	while (count) {
-		size_t c = min_t(size_t, count, alloc_size);
-
-		if (copy_from_user(tmp, buf, c)) {
-			err = -EFAULT;
-			break;
-		}
-		memcpy_toio(dst, tmp, c);
-
-		dst += c;
-		buf += c;
-		ret += c;
-		count -= c;
-	}
-
-	kfree(tmp);
-
-	return ret ? ret : err;
-}
-
-static ssize_t fb_write_screen_buffer(struct fb_info *info, const char __user *buf, size_t count,
-				      loff_t pos)
-{
-	char *dst = info->screen_buffer + pos;
-
-	if (copy_from_user(dst, buf, count))
-		return -EFAULT;
-
-	return count;
-}
-
 static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
 				  size_t count, loff_t *ppos)
 {
-	loff_t pos = *ppos;
-	size_t total_size;
 	ssize_t ret;
-	struct drm_rect damage_area;
-	int err = 0;
 
-	if (info->screen_size)
-		total_size = info->screen_size;
-	else
-		total_size = info->fix.smem_len;
-
-	if (pos > total_size)
-		return -EFBIG;
-	if (count > total_size) {
-		err = -EFBIG;
-		count = total_size;
-	}
-	if (total_size - count < pos) {
-		if (!err)
-			err = -ENOSPC;
-		count = total_size - pos;
-	}
-
-	if (info->fbops->fb_sync)
-		info->fbops->fb_sync(info);
-
-	/*
-	 * Copy to framebuffer even if we already logged an error. Emulates
-	 * the behavior of the original fbdev implementation.
-	 */
 	if (drm_fbdev_use_iomem(info))
-		ret = fb_write_screen_base(info, buf, count, pos);
+		ret = drm_fb_helper_cfb_write(info, buf, count, ppos);
 	else
-		ret = fb_write_screen_buffer(info, buf, count, pos);
-
-	if (ret < 0)
-		return ret; /* return last error, if any */
-	else if (!ret)
-		return err; /* return previous error, if any */
-
-	*ppos += ret;
-
-	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+		ret = drm_fb_helper_sys_write(info, buf, count, ppos);
 
 	return ret;
 }
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 86c489d945849..55c92372fca04 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -49,6 +49,8 @@ static const struct fb_ops exynos_drm_fb_ops = {
 	.owner		= THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_mmap        = exynos_drm_fb_mmap,
+	.fb_read	= drm_fb_helper_cfb_read,
+	.fb_write	= drm_fb_helper_cfb_write,
 	.fb_fillrect	= drm_fb_helper_cfb_fillrect,
 	.fb_copyarea	= drm_fb_helper_cfb_copyarea,
 	.fb_imageblit	= drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index bee4ce24904f6..53298674b7ed8 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -147,6 +147,8 @@ static const struct fb_ops psbfb_unaccel_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_setcolreg = psbfb_setcolreg,
+	.fb_read = drm_fb_helper_cfb_read,
+	.fb_write = drm_fb_helper_cfb_write,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 0ac78b9718684..d63b066e8ac70 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -124,6 +124,8 @@ static const struct fb_ops intelfb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_set_par = intel_fbdev_set_par,
+	.fb_read = drm_fb_helper_cfb_read,
+	.fb_write = drm_fb_helper_cfb_write,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 936df79decc57..8717423195f4c 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -80,6 +80,8 @@ static const struct fb_ops radeonfb_ops = {
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_open = radeonfb_open,
 	.fb_release = radeonfb_release,
+	.fb_read = drm_fb_helper_cfb_read,
+	.fb_write = drm_fb_helper_cfb_write,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 30fac20665f4e..071be48390880 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -206,6 +206,8 @@ static int tegra_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 static const struct fb_ops tegra_fb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
+	.fb_read = drm_fb_helper_sys_read,
+	.fb_write = drm_fb_helper_sys_write,
 	.fb_fillrect = drm_fb_helper_sys_fillrect,
 	.fb_copyarea = drm_fb_helper_sys_copyarea,
 	.fb_imageblit = drm_fb_helper_sys_imageblit,
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
index 5b85b477e4c69..0f2e3e6e97864 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
@@ -29,6 +29,7 @@
 #include <linux/fb.h>
 #include <linux/pci.h>
 
+#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/ttm/ttm_placement.h>
 
@@ -611,6 +612,8 @@ static int vmw_fb_set_par(struct fb_info *info)
 
 static const struct fb_ops vmw_fb_ops = {
 	.owner = THIS_MODULE,
+	.fb_read = drm_fb_helper_sys_read,
+	.fb_write = drm_fb_helper_sys_write,
 	.fb_check_var = vmw_fb_check_var,
 	.fb_set_par = vmw_fb_set_par,
 	.fb_setcolreg = vmw_fb_setcolreg,
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 3d7a3d68dab8a..6581183618b89 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -257,6 +257,11 @@ void drm_fb_helper_sys_copyarea(struct fb_info *info,
 void drm_fb_helper_sys_imageblit(struct fb_info *info,
 				 const struct fb_image *image);
 
+ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf,
+			       size_t count, loff_t *ppos);
+ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
+				size_t count, loff_t *ppos);
+
 void drm_fb_helper_cfb_fillrect(struct fb_info *info,
 				const struct fb_fillrect *rect);
 void drm_fb_helper_cfb_copyarea(struct fb_info *info,
@@ -402,6 +407,18 @@ static inline void drm_fb_helper_sys_imageblit(struct fb_info *info,
 {
 }
 
+static inline ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf,
+					     size_t count, loff_t *ppos)
+{
+	return -ENODEV;
+}
+
+static inline ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
+					      size_t count, loff_t *ppos)
+{
+	return -ENODEV;
+}
+
 static inline void drm_fb_helper_cfb_fillrect(struct fb_info *info,
 					      const struct fb_fillrect *rect)
 {
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426438.674991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwR-00020Z-EY; Thu, 20 Oct 2022 10:38:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426438.674991; Thu, 20 Oct 2022 10:38:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwQ-0001s8-Iz; Thu, 20 Oct 2022 10:38:22 +0000
Received: by outflank-mailman (input) for mailman id 426438;
 Thu, 20 Oct 2022 10:38:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwC-0005Jc-B7
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:08 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 47d4ca87-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6BF8322B4A;
 Thu, 20 Oct 2022 10:38:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EDB6013B72;
 Thu, 20 Oct 2022 10:38:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kIkbOQwlUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 47d4ca87-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W2hXo1ZXw+fT7jNTQpjjai6MaQuUlFJ3x4yHM5t/NT8=;
	b=mXMxC8OO+HZ8qhzaLE8AfebgTyxZZ9tZZWp4b7x0BMlwJ5x9pus13/9bOEqPMw/ehUZ5Gm
	NMWe1CLs7URfQKXJhFUMtaH9TNDwSCHSAXQngN6KK8AbjJnlteXfw2iY4Wy+qxQ++vc+C3
	i2Xl+bGq47RvpsltfuDrJ24ofhw8TZw=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262285;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W2hXo1ZXw+fT7jNTQpjjai6MaQuUlFJ3x4yHM5t/NT8=;
	b=qUQDcrgRCPnFyYcZ51L8SJ9jf3CSuZOp6Fc/Q31scIHuqQyNIFoSnsX5swYKn3WKiqCoB1
	s+8FMBlX9/Tru7AQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 16/21] drm/fb-helper: Call fb_sync in I/O functions
Date: Thu, 20 Oct 2022 12:37:50 +0200
Message-Id: <20221020103755.24058-17-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the
behavior of fbdev. Fbdev implementations of fb_read and fb_write in
struct fb_ops invoke fb_sync to synchronize with outstanding operations
before I/O. Doing the same in DRM implementations will allow us to use
them throughout DRM drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index f6d22cc4cd876..379e0d2f67198 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2246,6 +2246,9 @@ static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
 	if (total_size - count < pos)
 		count = total_size - pos;
 
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
 	if (drm_fbdev_use_iomem(info))
 		ret = fb_read_screen_base(info, buf, count, pos);
 	else
@@ -2327,6 +2330,9 @@ static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
 		count = total_size - pos;
 	}
 
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
 	/*
 	 * Copy to framebuffer even if we already logged an error. Emulates
 	 * the behavior of the original fbdev implementation.
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:38:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:38:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426439.675005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwU-0002gb-84; Thu, 20 Oct 2022 10:38:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426439.675005; Thu, 20 Oct 2022 10:38:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSwT-0002ap-75; Thu, 20 Oct 2022 10:38:25 +0000
Received: by outflank-mailman (input) for mailman id 426439;
 Thu, 20 Oct 2022 10:38:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwD-0005Jb-SS
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:10 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 497009bd-5063-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 12:38:08 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 29A0122B52;
 Thu, 20 Oct 2022 10:38:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9F5D013B72;
 Thu, 20 Oct 2022 10:38:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +KnsJQ8lUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 497009bd-5063-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=olaWhHgmBtYXWssH1ionayDympOYx1wSst0NfZQuc1k=;
	b=BkOOMn/wAFBhXieewP6MWxbRploFhPGvJmMVnYKw9dNKljJPsC+/VWYy9ZWll+GJP8DCTj
	B65SB0SMvMvD/AIaWMGbSR50HoGRcce7UxLgxrXaGl+jqUNyF7jrpgpbN9KZ4KwSQ1dvpI
	U41cgNVTd17OiK0Hyy9Fk4o1p2ZNvNQ=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262288;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=olaWhHgmBtYXWssH1ionayDympOYx1wSst0NfZQuc1k=;
	b=/dajMG0d9XFzzCboycY2n+87ZX/2MIHDI9iOd+h0gqeLKbqYC1xCm/l2pGlgRKqor/1zsM
	D28/WyMmFW/FHDAQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 21/21] drm/fb-helper: Remove unnecessary include statements
Date: Thu, 20 Oct 2022 12:37:55 +0200
Message-Id: <20221020103755.24058-22-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove include statements for <drm/drm_fb_helper.h> where it is not
required (i.e., most of them). In a few places include other header
files that are required by the source code.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c  | 1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c     | 1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h        | 1 -
 drivers/gpu/drm/arm/hdlcd_crtc.c                | 1 -
 drivers/gpu/drm/ast/ast_drv.h                   | 1 -
 drivers/gpu/drm/bridge/tc358762.c               | 2 +-
 drivers/gpu/drm/drm_crtc_helper.c               | 1 -
 drivers/gpu/drm/drm_gem_framebuffer_helper.c    | 1 -
 drivers/gpu/drm/drm_probe_helper.c              | 1 -
 drivers/gpu/drm/etnaviv/etnaviv_drv.h           | 3 ++-
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 -
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c     | 1 -
 drivers/gpu/drm/imx/imx-ldb.c                   | 2 +-
 drivers/gpu/drm/imx/imx-tve.c                   | 1 -
 drivers/gpu/drm/imx/parallel-display.c          | 2 +-
 drivers/gpu/drm/kmb/kmb_plane.c                 | 1 -
 drivers/gpu/drm/mgag200/mgag200_drv.h           | 1 -
 drivers/gpu/drm/qxl/qxl_drv.h                   | 1 -
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h     | 2 +-
 drivers/gpu/drm/tidss/tidss_kms.c               | 1 -
 drivers/gpu/drm/v3d/v3d_drv.c                   | 1 -
 drivers/gpu/drm/vboxvideo/vbox_main.c           | 1 -
 drivers/gpu/drm/virtio/virtgpu_drv.h            | 1 -
 drivers/gpu/drm/xen/xen_drm_front_gem.c         | 1 -
 24 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index 491d4846fc02c..e1320edfc5274 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -26,7 +26,6 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/amdgpu_drm.h>
 #include "amdgpu.h"
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index fb7186c5ade2a..5d8f661f31676 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -42,7 +42,6 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_gem_framebuffer_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
index 37322550d7508..8a39300b1a845 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
@@ -36,7 +36,6 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_fixed.h>
 #include <drm/drm_crtc_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_probe_helper.h>
 #include <linux/i2c.h>
diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
index 7030339fa2323..ddbe1dd2d44ef 100644
--- a/drivers/gpu/drm/arm/hdlcd_crtc.c
+++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
@@ -19,7 +19,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h
index 74f41282444f6..d51b81fea9c80 100644
--- a/drivers/gpu/drm/ast/ast_drv.h
+++ b/drivers/gpu/drm/ast/ast_drv.h
@@ -38,7 +38,6 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_mode.h>
 #include <drm/drm_framebuffer.h>
-#include <drm/drm_fb_helper.h>
 
 #define DRIVER_AUTHOR		"Dave Airlie"
 
diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
index 7f4fce1aa9988..0b6a284368859 100644
--- a/drivers/gpu/drm/bridge/tc358762.c
+++ b/drivers/gpu/drm/bridge/tc358762.c
@@ -11,6 +11,7 @@
  */
 
 #include <linux/delay.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/of_graph.h>
 #include <linux/regulator/consumer.h>
@@ -19,7 +20,6 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 1f0a270ac9847..d010b9ad6d24d 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -42,7 +42,6 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
index 880a4975507fc..8b7da4f9d2bc1 100644
--- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
+++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
@@ -9,7 +9,6 @@
 #include <linux/module.h>
 
 #include <drm/drm_damage_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 69b0b2b9cc1c5..ef2b41b2eb7b8 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -36,7 +36,6 @@
 #include <drm/drm_client.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index f32f4771dada7..2bb4c25565dcb 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -6,13 +6,14 @@
 #ifndef __ETNAVIV_DRV_H__
 #define __ETNAVIV_DRV_H__
 
+#include <linux/io.h>
 #include <linux/list.h>
 #include <linux/mm_types.h>
 #include <linux/sizes.h>
 #include <linux/time64.h>
 #include <linux/types.h>
 
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_drv.h>
 #include <drm/drm_gem.h>
 #include <drm/etnaviv_drm.h>
 #include <drm/gpu_scheduler.h>
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
index 7d263f4d70784..feba46e430526 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
@@ -19,7 +19,6 @@
 #include <linux/i2c.h>
 
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_framebuffer.h>
 
 struct hibmc_connector {
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 28e732f94bf2f..6c6b572987973 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -8,7 +8,6 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index 41799011f73b6..c45fc8f4744d0 100644
--- a/drivers/gpu/drm/imx/imx-ldb.c
+++ b/drivers/gpu/drm/imx/imx-ldb.c
@@ -7,6 +7,7 @@
 
 #include <linux/clk.h>
 #include <linux/component.h>
+#include <linux/i2c.h>
 #include <linux/media-bus-format.h>
 #include <linux/mfd/syscon.h>
 #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
@@ -23,7 +24,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index 6b34fac3f73a0..d64ebd2cf15e8 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -19,7 +19,6 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 06723b2e9b847..0fa0b590830b6 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -8,6 +8,7 @@
 #include <linux/component.h>
 #include <linux/media-bus-format.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/videodev2.h>
 
@@ -16,7 +17,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c
index a42f63f6f9573..d172a302f9024 100644
--- a/drivers/gpu/drm/kmb/kmb_plane.c
+++ b/drivers/gpu/drm/kmb/kmb_plane.c
@@ -9,7 +9,6 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h
index f0c2349404b46..9e604dbb8e448 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.h
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.h
@@ -18,7 +18,6 @@
 #include <drm/drm_connector.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_plane.h>
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 432758ad39a35..76f060810f634 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -38,7 +38,6 @@
 
 #include <drm/drm_crtc.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_ttm_helper.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
index 1641440837af5..aeb03a57240fd 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
@@ -9,10 +9,10 @@
 #ifndef _ROCKCHIP_DRM_DRV_H
 #define _ROCKCHIP_DRM_DRV_H
 
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_gem.h>
 
+#include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/component.h>
 
diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
index afb2879980c6c..345bcc3011e4f 100644
--- a/drivers/gpu/drm/tidss/tidss_kms.c
+++ b/drivers/gpu/drm/tidss/tidss_kms.c
@@ -10,7 +10,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index e8c975b815859..478f1f0f60dec 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -22,7 +22,6 @@
 #include <linux/reset.h>
 
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <uapi/drm/v3d_drm.h>
 
diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c
index c9e8b3a63c621..3b83e550f4df5 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_main.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_main.c
@@ -11,7 +11,6 @@
 #include <linux/pci.h>
 #include <linux/vbox_err.h>
 
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_damage_helper.h>
 
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h
index 9b98470593b06..b7a64c7dcc2c9 100644
--- a/drivers/gpu/drm/virtio/virtgpu_drv.h
+++ b/drivers/gpu/drm/virtio/virtgpu_drv.h
@@ -35,7 +35,6 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index e31554d7139f1..4c95ebcdcc2d3 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -12,7 +12,6 @@
 #include <linux/scatterlist.h>
 #include <linux/shmem_fs.h>
 
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_prime.h>
 #include <drm/drm_probe_helper.h>
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:42:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:42:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426479.675039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSzu-0000GH-F5; Thu, 20 Oct 2022 10:41:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426479.675039; Thu, 20 Oct 2022 10:41:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olSzu-0000GA-Bv; Thu, 20 Oct 2022 10:41:58 +0000
Received: by outflank-mailman (input) for mailman id 426479;
 Thu, 20 Oct 2022 10:41:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yb7k=2V=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olSzs-0000G2-UQ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:41:57 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2042.outbound.protection.outlook.com [40.107.94.42])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cfdad687-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:41:55 +0200 (CEST)
Received: from BN8PR04CA0015.namprd04.prod.outlook.com (2603:10b6:408:70::28)
 by IA0PR12MB7774.namprd12.prod.outlook.com (2603:10b6:208:430::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 10:41:51 +0000
Received: from BN8NAM11FT085.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:70:cafe::61) by BN8PR04CA0015.outlook.office365.com
 (2603:10b6:408:70::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 10:41:51 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT085.mail.protection.outlook.com (10.13.176.100) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Thu, 20 Oct 2022 10:41:51 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct
 2022 05:41:50 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Thu, 20 Oct 2022 05:41:49 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfdad687-5063-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UK6iGYbj0hqqjhaZtE0kNjrVH8GZNPfUZKmlE88fSFDrUOQW1pfTvoNjs6WYj0VDL+sdKk3d7LPQXrCWM+fl+Ud8u6UQEv5bcYpuCR8lQMHEjb/s0IGn6eM4BXiLaFvxioVysfWligGKqCC9ZmRFr1qWJz1+tNLztfa8C0edxo1NTe2wLOppEFKoKApULBoB8wAFC8SRVssyrvuu20kmsFZ9wvFEeMchGu9BMgxIuyGesc0f9DQxaCQAxultAL9vJef4b3OdZsKIEQWV73uZqpFK+z3cLwpTDepN+zMPFgimFGd4bIt+nxCi+umE2XUYKinHfspU8ugGrCH3/ozRnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DijQhQr5b/k927xjMyy3lw0o6tSDAsYgZp7BGpv6mAQ=;
 b=iaPVe+iWwgDKJ+ihD+jcSKuTo7NdRck9/8fAeEYvyPumVY8QFNwtoE88B68m1FyBY+hDIawqRuO8GRyiK83s8eTU2aNavwMaTszsgSwUdOeLsJbZosBR2dN9VkfWq7pO8CLOfhN8nAPeQVGG0SPBsB8+Duli7LeVhim0gM++AA8h2nl4P0kIeHwE2wydsntS+zAiyBiZ+7zuuJxNuYwkOHboSjvqGFBDhANu+GNbhLmgacPaGQI8osdE9BmQAsW49kr7rHj1KfKDWfLEUcRWW7BSJG/PmVc+K7j/V++SZEDi+NAP2u0GPRyfXijXJ3jAU3B/a36lVGi32U/NNfJ33A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DijQhQr5b/k927xjMyy3lw0o6tSDAsYgZp7BGpv6mAQ=;
 b=tTwarEuOacQYQ6b2j4VExDZRybwRq8XYjMYTf07NkIbWK9hcjVxVc0UoVnWTxN7LVUNEqkXK3BUFAUCyLeBFWciq0t+43OpsFcVy1Mkei0AxcBgN2utOL7rTRifji+1UoqkNdAlTrCxaqh/UdXdzUSWMD27XDLU3tdF7O09s0pI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Date: Thu, 20 Oct 2022 11:41:46 +0100
Message-ID: <20221020104146.29841-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT085:EE_|IA0PR12MB7774:EE_
X-MS-Office365-Filtering-Correlation-Id: 58743017-b965-4616-6a6e-08dab287b2a7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YUg5WHhGFJCDZqs1LpiEn6w/UzeFoYUOA6XIFQHkYULZ9fH4tPfFlz3zCRZh+DWXwwNjis4HHMNvnZ82UUzOLsxcJc/phY1fdSZfUffGljvups1OMULHvFd6Jnm8iAJDEaFsfQ9klhmMjInHydYAwdssyVVyaGbRgUzdr2HIj276U77+V7XvNgiIidWn2F071dHQO+oogh64DP+ZMY6fbOzFwunfzxavIRVwXH4TPS6PKvzPTefRtH3pvgqzY2nzPAGFfqp6ar3XDZZbo9b5D5Nvg83hTDVCLDjcXos4a9jvaGm8+9ELwoZa4xIoQVx5uSlsCRFsN3ys9r3G+Mb6KlJa2zGMuLqYTX84eLTuuCDQoyOkeMf5r2+GAbWFkskj3p6josVL0sYf95G35AwwgJOafSe9E+dHmovKzLsh47QGRDjKi7zzPzIE7AQkrAoLbKk+g0nqfWOkileZfn4QLVK4fMktasCJBcQWAtfkUh1lUu/YbxKKP8lYHeyMUO/NoR5nmFuKjk7hE4svaCzaBtkxCpqGzPEZJu4PeNPBtIZYm14BwMvlP/JK6qgp+INYY1e/50Nce0/c3+grvbPGEmoQvabt+a27hgYkXx49C3jAa9hblKZ5bwjFSUjvzg4YKUEfhXP8ns4Nrj2TpTP0M2xEKt8hQH0jkEgwEWjmuEmoRZ4fQtO+LcB66nBHbDCdsv58lT9LlPrFRj9yjUJreRTyepyfLnGkfExt6N6dGQygUsA7iVgFAOnWdk+AK2x6pESpDInIQq2JPwm6r4lA2yLUdHd98TrDVS/PEM0R6qQ=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(81166007)(356005)(6666004)(47076005)(70206006)(5660300002)(8676002)(8936002)(41300700001)(70586007)(26005)(40480700001)(40460700003)(6916009)(336012)(426003)(82310400005)(54906003)(4326008)(1076003)(186003)(316002)(2906002)(2616005)(36756003)(36860700001)(478600001)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 10:41:51.3679
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 58743017-b965-4616-6a6e-08dab287b2a7
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT085.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7774

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
IGROUPR) is relevant only when the guests run in secure/non-secure mode.
As Xen does not implement security extensions for guests, so the registers
are emulated as read as zero/write ignore.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

Changes from:-
v1 - Moved the definitions of GICD_IGRPMODR, GICD_IGRPMODRN to gic_v3
specific header.

 xen/arch/arm/include/asm/gic_v3_defs.h | 2 ++
 xen/arch/arm/vgic-v3.c                 | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 34ed5f857d..728e28d5e5 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -30,6 +30,8 @@
 #define GICD_CLRSPI_NSR              (0x048)
 #define GICD_SETSPI_SR               (0x050)
 #define GICD_CLRSPI_SR               (0x058)
+#define GICD_IGRPMODR                (0xD00)
+#define GICD_IGRPMODRN               (0xD7C)
 #define GICD_IROUTER                 (0x6000)
 #define GICD_IROUTER32               (0x6100)
 #define GICD_IROUTER1019             (0x7FD8)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 7fb99a9ff2..0c23f6df9d 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, read zero */
         if ( dabt.size != DABT_WORD ) goto bad_width;
         goto read_as_zero;
@@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, write ignore */
         goto write_ignore_32;
 
@@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /*
          * Above all register are common with GICR and GICD
          * Manage in common
@@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* Above registers are common with GICR and GICD
          * Manage in common */
         return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:43:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:43:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426485.675050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT1L-0000uK-TN; Thu, 20 Oct 2022 10:43:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426485.675050; Thu, 20 Oct 2022 10:43:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT1L-0000uD-QY; Thu, 20 Oct 2022 10:43:27 +0000
Received: by outflank-mailman (input) for mailman id 426485;
 Thu, 20 Oct 2022 10:43:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yb7k=2V=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olT1K-0000u3-63
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:43:26 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2042.outbound.protection.outlook.com [40.107.94.42])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 05a5771f-5064-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:43:25 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CY5PR12MB6324.namprd12.prod.outlook.com (2603:10b6:930:f::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 10:43:20 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::cde6:a05b:5dc7:836%6]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022
 10:43:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05a5771f-5064-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OAeiqK1ZQV1CC8tuLKeTN6J3PGM1qJJ0N8BaEqj/AEyhkuZRrLaYxj/wmpXD1pGJOhTZKvKuPM4ppQ1u2QtCnHbxJAfB6fJt0D0kS3y6Qjp1U6KowKK/MajtomYTWWzqPzUuSiN1TL72IIMHkMDcy4oAMe/5/73ggGrHdo1f79ak47CibQmUdVVpFw1AGdkr/RrsvsTtuzUrGMRO186emUenu/+iZoHBuduzwP2bqp/GkHokv/vcG2LafGWpfwMkCb/L1wmHDcxPeQTu0CI1CzbaWeo2/dtzqKDMqUcCZokS86m1mT/wWdjhfAuGsshZRAgWcBXqDSh8514YM4m7gw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aW1O3Jih8H5+JSUwTtyWGq4DG7pH4FcInZ0wMLtbKnc=;
 b=e4LQuRhMv9L3Tc9RadKqv2VNOH3i1if2cWpVxkXBEPGaXppoNYMqR9I9YG+7rSfUDJIVNqhLfu+q3Z8JVAMz2bcN5ZusVRum8RknYAZ8OwwjpcTOT/i6KDHrXL28n9qyyZ0QLhYGzrF68tvVYd1NbOE4dgmFHDBMqgmxjWGCde4KtU4+RIl/Ur0qPilea5owV7gLl5YT/VPRRF5GTujZ0xtI1WueRNdlRLVyautB89HMu+K/Vk25SsgIMSCnmzX2hzMeeA3eySSNn03TLKzkZRegJ6/o1JmYBcWF4b+KEJXziOtpDPxEzZyvRIE0xe1e49XDNrS36kmm/TGCPSoM6w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aW1O3Jih8H5+JSUwTtyWGq4DG7pH4FcInZ0wMLtbKnc=;
 b=YRdNe3fPVvJ4q30/U+8UcQ+PbljsTB2m/9bZCiWyumg/eLoYPFq0Jl/zR1BlXIku0bbRZ7O6pF+T+TJypBNktxcW5nJJWwX7snUIWnZPzOSTUGy6gBkSqmYYEAJy86mCudMwZ2iRgPcpgtr2HankmFh9RkXtz91PTRq6Aqt7OhA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <c6dd035e-d826-6c81-648e-73cb9292e0fd@amd.com>
Date: Thu, 20 Oct 2022 11:43:12 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [XEN v1] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221019143620.45814-1-ayankuma@amd.com>
 <745ed2f6-4193-b7a3-c3a0-455ef8c24b66@amd.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <745ed2f6-4193-b7a3-c3a0-455ef8c24b66@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0513.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::23) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CY5PR12MB6324:EE_
X-MS-Office365-Filtering-Correlation-Id: 0efb5c44-cb08-415e-52b0-08dab287e76f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/Zi1cHwZ4ETGA6d0p4vYKdGK4S4Peey5o54+eKFzZ1X+BTPbIEgeKzcpTBikwF0/YoyCBg3vYtWd1A1nNHiayWKhP8we6a/typZYVxFwu6KUHHNBUmrheG/c7ZP6uko7L04eD6uSSydnEG//2xG1wwblFJ+4MsmOztxgcuPGYTAlDy+slS2bCWZtay+qzxl8LYFrnuisx+jgxXbdv/n3XY9ZBlo7IOxZ1WKGkLq8VYadjazVahynu+F8xs0pYVM+HoykMNInDz/bYwRJB0tJL/DA5STcoahDdVfElRdy2NTl6Vsgw38J5kdJUu+glcZdtsBQkNGhklNVsEA9BHY8YmhFWiCl/oxncrnoRqBr7OCfZREPeOx6Dkzf6DCaHQAEDuw+s7xKq4nsU+KfG0W2p3bos5xmrNtZVEdWV0ojBqgcIB3k/6oIujeAD+zrTfP1NR+PILc8OwhIwaTw29GtuyXaXw9y4jtld4NofJsucFkhuPF2RNU7cdd6B9cXGZ7uuAWJEeXRlbWmjE2w2VEWIoV+7LyRJmfmYwZHZ/0geM5jWcuG0IavCdKoXmaD+T4l7SKResvlb2zZ1vgX8Xt14KnsVH9qYgvk4VFIsEP46GJ93jYqK2YoSvvr1ndEh143/yet+0tWNpCP3Oj8g2aHnf8wcTTLWNauh/5eTUSSYM5b5YH/uLWDGz50SZRsIgZs+3P/ujvbMDDvPoshD2XKSlaIx/1Xc+Ax1SjPIJrWIdZVNzezsBM81pCAzUXR4ZPyMgdt+FQ/EKa/rSl8NFSk01TUK1yWvwnvZyNvZwnqZbQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(396003)(346002)(136003)(451199015)(6486002)(186003)(83380400001)(5660300002)(8676002)(31696002)(2616005)(2906002)(38100700002)(41300700001)(4326008)(26005)(478600001)(8936002)(6512007)(6666004)(316002)(6506007)(53546011)(66476007)(66946007)(66556008)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?djJscERhTENYR3NFb3FjR0pjOG1QY1dxTTVnOVF5MmFhRUxCUjlKSC93QmQ4?=
 =?utf-8?B?SmxwdlhEbHUwMFdzSDUyTHRUeElaQmxrc043Tkdqd04yYzB0cW84NTc5RDg1?=
 =?utf-8?B?Zklvb1M5bURkSndBT0R1empzSDlTVktlcVBOMTdBamxVNkE4d3BWTE1QaCtB?=
 =?utf-8?B?bWZ0aWd3bk8vdFNTQWVyYldOVHE1em41SDdIeTI3dHUwWnpaUG4xQW9YbWpZ?=
 =?utf-8?B?ZlNodGVWSEljUHZzTHQ3aWVPWkFGVWR0V2M1aGNRekZYcnAxZ0lxK0tKRWx5?=
 =?utf-8?B?QzVwT3E2bS9HOWlpR1pMS1JZbm5mb1JPUFZjU3dmUnkwVXQ3WjU5c2xTQTdk?=
 =?utf-8?B?NzNpa3FDYVN6cTIvQ0U2U3JBNGFWRFZ4Sy81M0VoTHdSTmt4VjA2ZXF5VzQr?=
 =?utf-8?B?RzdGOENCMWJGU1VrV0FzUlB0Z1ZmMzRDL2psVFZEWFR0anFBR0lYTkp5V2RW?=
 =?utf-8?B?V1F3dkFkOWQ4Q2E5Y0VVdkp5TWhaWE9BN1RiLzYzdXdsNGZZcWw5dHphSG1a?=
 =?utf-8?B?ODFUd2FxQThWSEpxQnFROUpNUlA0bW9SUTUwZjQzK2tncHVqbnFIYnR5aFo0?=
 =?utf-8?B?OHBHbGswMzN1ME4wUm9WT2J5MFpIemZIWlRFR3ZPdE1kNFlMdStTMlcwblg4?=
 =?utf-8?B?SVBlOTl0a3BlT1RTKzlTNU1tSHhmb3A4OEVwMVhhVVQ0RjMvamd1TTVXR2NT?=
 =?utf-8?B?UTNTWU9Ha21kdXA2OUxZSVVxMnJLb2lGYmJ2SFRUSFhnVml1Vmdzais1ZVl0?=
 =?utf-8?B?cXFoODVCRU8rRFF6OEJEQ0hGcjlkczJuMUZmdk9UL1o2aE8xeHczaXQyR0NW?=
 =?utf-8?B?M3lmaWFselBFdlZQMXVKd2RvRWRpazJNbFZHeDVIdDZkRmxycjhNa0xkemth?=
 =?utf-8?B?YU1QWGlEMDlNM0tqUWNGL1BGSFhDTlFWYzVNYmlwUEFMUUh6RG5GVlZXRzJv?=
 =?utf-8?B?RFdhZTQ4V0lyUjI4eXBMRk40SlBBOEtWRWZUYTU5bXpuZGxIS3I0QnFMN1N1?=
 =?utf-8?B?UDRTM281alF1UVEvRHFacFZkbGc0REVsU1dCZlZ4ZHliOTFsMVlHSG5JQWZw?=
 =?utf-8?B?YnJzcEFHMnB3OE9ocnV1TG9KRFd2OG1PUWFKcmlxRkF2eDdBVVR0aTUzYlYx?=
 =?utf-8?B?Q0lwSU1GTTkrTGNUNzRTNTNQcENpZTdWNjduT2FabW13Vmo0Y2xld1plSDZu?=
 =?utf-8?B?TnhQTStiOUFnaTN2SHJQeE0yamlYemFHV2FVcGdCRzBjZUVMRHJYYk1RSXJ6?=
 =?utf-8?B?VEFkOWlBNm5UMjRxS2NsMkQyK2VTUkk4bXBjYU0wTkZqTTV4M0NmUDRBOTBk?=
 =?utf-8?B?bWljSysxd2RUaVRjMXR3cWlpdEc2b2tBTW02ekQzK2NDOFl6aTNYcWlyZTEz?=
 =?utf-8?B?NG9CYWFJNnZXYVEwM1AvRTVjQmozUk9JeGs0SzA0bk4vc0ZVaTVja2ptRDB6?=
 =?utf-8?B?a1pMalVMcjhQK0RxYW9YeEZ0MEROcVpBdnZHT2NGSzNTdmF2Rm8rZWxJUjNp?=
 =?utf-8?B?eEJNdUgrWWlZN0N1TG1rWXZZQnRJK2hNV1FvK3ltQ1RDUkNKNVhDRDI3QWV1?=
 =?utf-8?B?OXhNUFZlRktVOEJrY01uWTlGZXFmSzNIRFV1UUI2NmFiaGgwZ285UVllNlFy?=
 =?utf-8?B?TURqSk03aWVNTzFwbGpoNmJiZmV1MUJOdlI4a256ZW1BV0ZhZWYzT0YrOXlB?=
 =?utf-8?B?L256bE1ZelIzTEJncmNra0hFL2gwVG44bGVRcVk0cWgyU0VqRlZKVTNSKzBN?=
 =?utf-8?B?QUZ2T29kYU82MXAway9BTjBJM0JCOHZYSDZZSzR6WitGcklxSG03Y3h6Qkkz?=
 =?utf-8?B?aHdwTXNaUHBlejF1d1loQ2g0M24rVjRaUHR2aTJVNERySFo5aEdEbEgveER4?=
 =?utf-8?B?MDhDRFV0TkJOMDNZVlZjYk9BR3ZBdmlIenVJbW9uRE9FN1JUUUJ6KzN1TWFy?=
 =?utf-8?B?ekxNTC94T2M0S2ZjMlVNclJJSU5RNEFJYVJ4S01aNStYbnBsalZkMFJPam9r?=
 =?utf-8?B?eWtTWGF2d2xVcnlhbTFuc3dDd09wTGU0TWVydlp3d0h1UWRmRnErWUxtbktq?=
 =?utf-8?B?K1J3ZmlIazBJV1RaZVN0MGJadFhxS0pUMldzWXQ2bEdZaXZmdTQ5eWYzT1o0?=
 =?utf-8?Q?93hUGkVXnYfmKonF/5N7u6uMy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0efb5c44-cb08-415e-52b0-08dab287e76f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 10:43:20.4664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4QLLO6IrpTXTHyO192vx3AxZgzkr9BKyqsRTmE/kc4hjrxmrSqH/Y/nMpCj6Scmfny8QdzDzYFExTA6K3VEceA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6324


On 19/10/2022 16:49, Michal Orzel wrote:
> Hi Ayan,
Hi Michal,
>
> On 19/10/2022 16:36, Ayan Kumar Halder wrote:
>>
>> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
>> IGROUPR) is relevant only when the guests run in secure/non-secure mode.
>> As Xen does not implement security extensions for guests, so the registers
>> are emulated as read as zero/write ignore.
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> ---
>>
>> Observed the issue while running Zephyr on R52.
>> Also, found that KVM has similar behaviour.
>>
>>   xen/arch/arm/include/asm/gic.h | 2 ++
>>   xen/arch/arm/vgic-v3.c         | 4 ++++
>>   2 files changed, 6 insertions(+)
>>
>> diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
>> index 76e3fa5dc4..998dd62651 100644
>> --- a/xen/arch/arm/include/asm/gic.h
>> +++ b/xen/arch/arm/include/asm/gic.h
>> @@ -48,6 +48,8 @@
>>   #define GICD_ICFGR1     (0xC04)
>>   #define GICD_ICFGR2     (0xC08)
>>   #define GICD_ICFGRN     (0xCFC)
>> +#define GICD_IGRPMODR   (0xD00)
>> +#define GICD_IGRPMODRN  (0xD7C)
> These registers are GICv3 specific and as such should be defined
> in arch/arm/include/asm/gic_v3_defs.h.

Thanks for pointing out. I have fixed this in v2.

- Ayan

>
> ~Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:45:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:45:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426520.675061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT3X-0001cw-BF; Thu, 20 Oct 2022 10:45:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426520.675061; Thu, 20 Oct 2022 10:45:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT3X-0001cm-7I; Thu, 20 Oct 2022 10:45:43 +0000
Received: by outflank-mailman (input) for mailman id 426520;
 Thu, 20 Oct 2022 10:45:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwF-0005Jc-Bf
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:11 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49274158-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A354E22B51;
 Thu, 20 Oct 2022 10:38:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E5A3A13AF5;
 Thu, 20 Oct 2022 10:38:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sDtBNw4lUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49274158-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iLRwQht7GVds7VAf8IghGhcOaIUvFQknjx/ZhV8AfTY=;
	b=OfKqDXQrx0s5mKpwEu8RYLibl9AJUy7JqASQ6ncrwB//WO/bumTz9ms/0UdT9KB+0xCwFD
	PE+0BNb/qwuhvTxvJ/At81mxe0b4WNdZbt29aYQojXTyY0vWQxKzzc2QlANmAbSMTRgSYo
	5YMM3LOv7zT1RPuTkvI1ymE/QA7G8/E=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262287;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iLRwQht7GVds7VAf8IghGhcOaIUvFQknjx/ZhV8AfTY=;
	b=EhhRukINnbNQwtbxUaKk6QJXEjaachx5Ukf0wJYimFVm40mKuxe/Y07T6jRAXSWDec0eob
	n+7CbcztY22bkFAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file
Date: Thu, 20 Oct 2022 12:37:54 +0200
Message-Id: <20221020103755.24058-21-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Move the generic fbdev implementation into its own source and header
file. Adapt drivers. No functonal changes, but some of the internal
helpers have been renamed to fit into the drm_fbdev_ naming scheme.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/Makefile                      |   2 +-
 .../gpu/drm/arm/display/komeda/komeda_drv.c   |   2 +-
 drivers/gpu/drm/arm/hdlcd_drv.c               |   2 +-
 drivers/gpu/drm/arm/malidp_drv.c              |   2 +-
 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c       |   2 +-
 drivers/gpu/drm/ast/ast_drv.c                 |   1 +
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |   2 +-
 drivers/gpu/drm/drm_fb_helper.c               | 517 +-----------------
 drivers/gpu/drm/drm_fbdev.c                   | 512 +++++++++++++++++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c     |   2 +-
 drivers/gpu/drm/gud/gud_drv.c                 |   2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |   1 +
 .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |   2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c       |   2 +-
 drivers/gpu/drm/imx/dcss/dcss-kms.c           |   2 +-
 drivers/gpu/drm/imx/imx-drm-core.c            |   2 +-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |   2 +-
 drivers/gpu/drm/kmb/kmb_drv.c                 |   2 +-
 drivers/gpu/drm/logicvc/logicvc_drm.c         |   2 +-
 drivers/gpu/drm/mcde/mcde_drv.c               |   2 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |   2 +-
 drivers/gpu/drm/meson/meson_drv.c             |   2 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |   1 +
 drivers/gpu/drm/mxsfb/lcdif_drv.c             |   2 +-
 drivers/gpu/drm/mxsfb/mxsfb_drv.c             |   2 +-
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c  |   2 +-
 drivers/gpu/drm/pl111/pl111_drv.c             |   2 +-
 drivers/gpu/drm/qxl/qxl_drv.c                 |   1 +
 drivers/gpu/drm/rcar-du/rcar_du_drv.c         |   2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |   2 +-
 drivers/gpu/drm/solomon/ssd130x.c             |   2 +-
 drivers/gpu/drm/sti/sti_drv.c                 |   2 +-
 drivers/gpu/drm/stm/drv.c                     |   2 +-
 drivers/gpu/drm/sun4i/sun4i_drv.c             |   2 +-
 drivers/gpu/drm/tidss/tidss_drv.c             |   2 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c           |   2 +-
 drivers/gpu/drm/tiny/arcpgu.c                 |   2 +-
 drivers/gpu/drm/tiny/bochs.c                  |   2 +-
 drivers/gpu/drm/tiny/cirrus.c                 |   2 +-
 drivers/gpu/drm/tiny/gm12u320.c               |   2 +-
 drivers/gpu/drm/tiny/hx8357d.c                |   2 +-
 drivers/gpu/drm/tiny/ili9163.c                |   2 +-
 drivers/gpu/drm/tiny/ili9225.c                |   2 +-
 drivers/gpu/drm/tiny/ili9341.c                |   2 +-
 drivers/gpu/drm/tiny/ili9486.c                |   2 +-
 drivers/gpu/drm/tiny/mi0283qt.c               |   2 +-
 drivers/gpu/drm/tiny/ofdrm.c                  |   2 +-
 drivers/gpu/drm/tiny/panel-mipi-dbi.c         |   2 +-
 drivers/gpu/drm/tiny/repaper.c                |   2 +-
 drivers/gpu/drm/tiny/simpledrm.c              |   2 +-
 drivers/gpu/drm/tiny/st7586.c                 |   2 +-
 drivers/gpu/drm/tiny/st7735r.c                |   2 +-
 drivers/gpu/drm/tve200/tve200_drv.c           |   2 +-
 drivers/gpu/drm/udl/udl_drv.c                 |   2 +-
 drivers/gpu/drm/vboxvideo/vbox_drv.c          |   2 +-
 drivers/gpu/drm/vc4/vc4_drv.c                 |   2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c          |   1 +
 drivers/gpu/drm/vkms/vkms_drv.c               |   2 +-
 drivers/gpu/drm/xlnx/zynqmp_dpsub.c           |   2 +-
 include/drm/drm_fb_helper.h                   |   9 -
 include/drm/drm_fbdev.h                       |  15 +
 61 files changed, 586 insertions(+), 576 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_fbdev.c
 create mode 100644 include/drm/drm_fbdev.h

diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 6ad98d3ceff76..beffde597ff68 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -115,7 +115,7 @@ drm_kms_helper-y := \
 	drm_self_refresh_helper.o \
 	drm_simple_kms_helper.o
 drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o
-drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fb_helper.o
+drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fbdev.o drm_fb_helper.o
 obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o
 
 #
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index 9fce4239d4ad4..9124d9e3f4e71 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -9,7 +9,7 @@
 #include <linux/platform_device.h>
 #include <linux/component.h>
 #include <linux/pm_runtime.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include "komeda_dev.h"
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index a032003c340cc..fddcef0c373e0 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -26,7 +26,7 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modeset_helper.h>
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 1d0b0c54ccc74..7665b651bbc59 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -19,7 +19,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
index a94f1a9e8f409..fa2fec7940b23 100644
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_device.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index bbeb5defc8f5c..44f5da586dad1 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -33,6 +33,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index f7e7f4e919c77..3d3e3dee7d8ec 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
@@ -19,7 +19,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index d1afb420c6e06..f52a90263ac36 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -30,24 +30,17 @@
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/console.h>
-#include <linux/dma-buf.h>
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/slab.h>
 #include <linux/sysrq.h>
-#include <linux/vmalloc.h>
 
 #include <drm/drm_atomic.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
-#include "drm_crtc_helper_internal.h"
 #include "drm_internal.h"
 
 static bool drm_fbdev_emulation = true;
@@ -61,25 +54,6 @@ MODULE_PARM_DESC(drm_fbdev_overalloc,
 		 "Overallocation of the fbdev buffer (%) [default="
 		 __MODULE_STRING(CONFIG_DRM_FBDEV_OVERALLOC) "]");
 
-/*
- * In order to keep user-space compatibility, we want in certain use-cases
- * to keep leaking the fbdev physical address to the user-space program
- * handling the fbdev buffer.
- * This is a bad habit essentially kept into closed source opengl driver
- * that should really be moved into open-source upstream projects instead
- * of using legacy physical addresses in user space to communicate with
- * other out-of-tree kernel modules.
- *
- * This module_param *should* be removed as soon as possible and be
- * considered as a broken and legacy behaviour from a modern fbdev device.
- */
-#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
-static bool drm_leak_fbdev_smem = false;
-module_param_unsafe(drm_leak_fbdev_smem, bool, 0600);
-MODULE_PARM_DESC(drm_leak_fbdev_smem,
-		 "Allow unsafe leaking fbdev physical smem address [default=false]");
-#endif
-
 static LIST_HEAD(kernel_fb_helper_list);
 static DEFINE_MUTEX(kernel_fb_helper_lock);
 
@@ -372,80 +346,6 @@ static void drm_fb_helper_resume_worker(struct work_struct *work)
 	console_unlock();
 }
 
-static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper,
-					   struct drm_clip_rect *clip,
-					   struct iosys_map *dst)
-{
-	struct drm_framebuffer *fb = fb_helper->fb;
-	size_t offset = clip->y1 * fb->pitches[0];
-	size_t len = clip->x2 - clip->x1;
-	unsigned int y;
-	void *src;
-
-	switch (drm_format_info_bpp(fb->format, 0)) {
-	case 1:
-		offset += clip->x1 / 8;
-		len = DIV_ROUND_UP(len + clip->x1 % 8, 8);
-		break;
-	case 2:
-		offset += clip->x1 / 4;
-		len = DIV_ROUND_UP(len + clip->x1 % 4, 4);
-		break;
-	case 4:
-		offset += clip->x1 / 2;
-		len = DIV_ROUND_UP(len + clip->x1 % 2, 2);
-		break;
-	default:
-		offset += clip->x1 * fb->format->cpp[0];
-		len *= fb->format->cpp[0];
-		break;
-	}
-
-	src = fb_helper->info->screen_buffer + offset;
-	iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
-
-	for (y = clip->y1; y < clip->y2; y++) {
-		iosys_map_memcpy_to(dst, 0, src, len);
-		iosys_map_incr(dst, fb->pitches[0]);
-		src += fb->pitches[0];
-	}
-}
-
-static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper,
-				     struct drm_clip_rect *clip)
-{
-	struct drm_client_buffer *buffer = fb_helper->buffer;
-	struct iosys_map map, dst;
-	int ret;
-
-	/*
-	 * We have to pin the client buffer to its current location while
-	 * flushing the shadow buffer. In the general case, concurrent
-	 * modesetting operations could try to move the buffer and would
-	 * fail. The modeset has to be serialized by acquiring the reservation
-	 * object of the underlying BO here.
-	 *
-	 * For fbdev emulation, we only have to protect against fbdev modeset
-	 * operations. Nothing else will involve the client buffer's BO. So it
-	 * is sufficient to acquire struct drm_fb_helper.lock here.
-	 */
-	mutex_lock(&fb_helper->lock);
-
-	ret = drm_client_buffer_vmap(buffer, &map);
-	if (ret)
-		goto out;
-
-	dst = map;
-	drm_fb_helper_damage_blit_real(fb_helper, clip, &dst);
-
-	drm_client_buffer_vunmap(buffer);
-
-out:
-	mutex_unlock(&fb_helper->lock);
-
-	return ret;
-}
-
 static void drm_fb_helper_damage_work(struct work_struct *work)
 {
 	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
@@ -2322,423 +2222,10 @@ EXPORT_SYMBOL(drm_fb_helper_lastclose);
  *
  * This function can be used as the
  * &drm_mode_config_funcs.output_poll_changed callback for drivers that only
- * need to call drm_fb_helper_hotplug_event().
+ * need to call drm_fbdev.hotplug_event().
  */
 void drm_fb_helper_output_poll_changed(struct drm_device *dev)
 {
 	drm_fb_helper_hotplug_event(dev->fb_helper);
 }
 EXPORT_SYMBOL(drm_fb_helper_output_poll_changed);
-
-static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
-{
-	struct drm_device *dev = fb_helper->dev;
-	struct drm_framebuffer *fb = fb_helper->fb;
-
-	return dev->mode_config.prefer_shadow_fbdev ||
-	       dev->mode_config.prefer_shadow ||
-	       fb->funcs->dirty;
-}
-
-/* @user: 1=userspace, 0=fbcon */
-static int drm_fbdev_fb_open(struct fb_info *info, int user)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-
-	/* No need to take a ref for fbcon because it unbinds on unregister */
-	if (user && !try_module_get(fb_helper->dev->driver->fops->owner))
-		return -ENODEV;
-
-	return 0;
-}
-
-static int drm_fbdev_fb_release(struct fb_info *info, int user)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-
-	if (user)
-		module_put(fb_helper->dev->driver->fops->owner);
-
-	return 0;
-}
-
-static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)
-{
-	struct fb_info *fbi = fb_helper->info;
-	void *shadow = NULL;
-
-	if (!fb_helper->dev)
-		return;
-
-	if (fbi) {
-		if (fbi->fbdefio)
-			fb_deferred_io_cleanup(fbi);
-		if (drm_fbdev_use_shadow_fb(fb_helper))
-			shadow = fbi->screen_buffer;
-	}
-
-	drm_fb_helper_fini(fb_helper);
-
-	if (shadow)
-		vfree(shadow);
-	else if (fb_helper->buffer)
-		drm_client_buffer_vunmap(fb_helper->buffer);
-
-	drm_client_framebuffer_delete(fb_helper->buffer);
-}
-
-static void drm_fbdev_release(struct drm_fb_helper *fb_helper)
-{
-	drm_fbdev_cleanup(fb_helper);
-	drm_client_release(&fb_helper->client);
-	kfree(fb_helper);
-}
-
-/*
- * fb_ops.fb_destroy is called by the last put_fb_info() call at the end of
- * unregister_framebuffer() or fb_release().
- */
-static void drm_fbdev_fb_destroy(struct fb_info *info)
-{
-	drm_fbdev_release(info->par);
-}
-
-static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-
-	if (drm_fbdev_use_shadow_fb(fb_helper))
-		return fb_deferred_io_mmap(info, vma);
-	else if (fb_helper->dev->driver->gem_prime_mmap)
-		return fb_helper->dev->driver->gem_prime_mmap(fb_helper->buffer->gem, vma);
-	else
-		return -ENODEV;
-}
-
-static bool drm_fbdev_use_iomem(struct fb_info *info)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-	struct drm_client_buffer *buffer = fb_helper->buffer;
-
-	return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem;
-}
-
-static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
-				 size_t count, loff_t *ppos)
-{
-	ssize_t ret;
-
-	if (drm_fbdev_use_iomem(info))
-		ret = drm_fb_helper_cfb_read(info, buf, count, ppos);
-	else
-		ret = drm_fb_helper_sys_read(info, buf, count, ppos);
-
-	return ret;
-}
-
-static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
-				  size_t count, loff_t *ppos)
-{
-	ssize_t ret;
-
-	if (drm_fbdev_use_iomem(info))
-		ret = drm_fb_helper_cfb_write(info, buf, count, ppos);
-	else
-		ret = drm_fb_helper_sys_write(info, buf, count, ppos);
-
-	return ret;
-}
-
-static void drm_fbdev_fb_fillrect(struct fb_info *info,
-				  const struct fb_fillrect *rect)
-{
-	if (drm_fbdev_use_iomem(info))
-		drm_fb_helper_cfb_fillrect(info, rect);
-	else
-		drm_fb_helper_sys_fillrect(info, rect);
-}
-
-static void drm_fbdev_fb_copyarea(struct fb_info *info,
-				  const struct fb_copyarea *area)
-{
-	if (drm_fbdev_use_iomem(info))
-		drm_fb_helper_cfb_copyarea(info, area);
-	else
-		drm_fb_helper_sys_copyarea(info, area);
-}
-
-static void drm_fbdev_fb_imageblit(struct fb_info *info,
-				   const struct fb_image *image)
-{
-	if (drm_fbdev_use_iomem(info))
-		drm_fb_helper_cfb_imageblit(info, image);
-	else
-		drm_fb_helper_sys_imageblit(info, image);
-}
-
-static const struct fb_ops drm_fbdev_fb_ops = {
-	.owner		= THIS_MODULE,
-	DRM_FB_HELPER_DEFAULT_OPS,
-	.fb_open	= drm_fbdev_fb_open,
-	.fb_release	= drm_fbdev_fb_release,
-	.fb_destroy	= drm_fbdev_fb_destroy,
-	.fb_mmap	= drm_fbdev_fb_mmap,
-	.fb_read	= drm_fbdev_fb_read,
-	.fb_write	= drm_fbdev_fb_write,
-	.fb_fillrect	= drm_fbdev_fb_fillrect,
-	.fb_copyarea	= drm_fbdev_fb_copyarea,
-	.fb_imageblit	= drm_fbdev_fb_imageblit,
-};
-
-static struct fb_deferred_io drm_fbdev_defio = {
-	.delay		= HZ / 20,
-	.deferred_io	= drm_fb_helper_deferred_io,
-};
-
-/*
- * This function uses the client API to create a framebuffer backed by a dumb buffer.
- *
- * The _sys_ versions are used for &fb_ops.fb_read, fb_write, fb_fillrect,
- * fb_copyarea, fb_imageblit.
- */
-static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,
-				       struct drm_fb_helper_surface_size *sizes)
-{
-	struct drm_client_dev *client = &fb_helper->client;
-	struct drm_device *dev = fb_helper->dev;
-	struct drm_client_buffer *buffer;
-	struct drm_framebuffer *fb;
-	struct fb_info *fbi;
-	u32 format;
-	struct iosys_map map;
-	int ret;
-
-	drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n",
-		    sizes->surface_width, sizes->surface_height,
-		    sizes->surface_bpp);
-
-	format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
-	buffer = drm_client_framebuffer_create(client, sizes->surface_width,
-					       sizes->surface_height, format);
-	if (IS_ERR(buffer))
-		return PTR_ERR(buffer);
-
-	fb_helper->buffer = buffer;
-	fb_helper->fb = buffer->fb;
-	fb = buffer->fb;
-
-	fbi = drm_fb_helper_alloc_info(fb_helper);
-	if (IS_ERR(fbi))
-		return PTR_ERR(fbi);
-
-	fbi->fbops = &drm_fbdev_fb_ops;
-	fbi->screen_size = sizes->surface_height * fb->pitches[0];
-	fbi->fix.smem_len = fbi->screen_size;
-	fbi->flags = FBINFO_DEFAULT;
-
-	drm_fb_helper_fill_info(fbi, fb_helper, sizes);
-
-	if (drm_fbdev_use_shadow_fb(fb_helper)) {
-		fbi->screen_buffer = vzalloc(fbi->screen_size);
-		if (!fbi->screen_buffer)
-			return -ENOMEM;
-		fbi->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST;
-
-		fbi->fbdefio = &drm_fbdev_defio;
-		fb_deferred_io_init(fbi);
-	} else {
-		/* buffer is mapped for HW framebuffer */
-		ret = drm_client_buffer_vmap(fb_helper->buffer, &map);
-		if (ret)
-			return ret;
-		if (map.is_iomem) {
-			fbi->screen_base = map.vaddr_iomem;
-		} else {
-			fbi->screen_buffer = map.vaddr;
-			fbi->flags |= FBINFO_VIRTFB;
-		}
-
-		/*
-		 * Shamelessly leak the physical address to user-space. As
-		 * page_to_phys() is undefined for I/O memory, warn in this
-		 * case.
-		 */
-#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
-		if (drm_leak_fbdev_smem && fbi->fix.smem_start == 0 &&
-		    !drm_WARN_ON_ONCE(dev, map.is_iomem))
-			fbi->fix.smem_start =
-				page_to_phys(virt_to_page(fbi->screen_buffer));
-#endif
-	}
-
-	return 0;
-}
-
-static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
-{
-	struct drm_device *dev = helper->dev;
-	int ret;
-
-	if (!drm_fbdev_use_shadow_fb(helper))
-		return 0;
-
-	/* Call damage handlers only if necessary */
-	if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
-		return 0;
-
-	if (helper->buffer) {
-		ret = drm_fb_helper_damage_blit(helper, clip);
-		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
-			return ret;
-	}
-
-	if (helper->fb->funcs->dirty) {
-		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
-		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
-			return ret;
-	}
-
-	return 0;
-}
-
-static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = {
-	.fb_probe = drm_fb_helper_generic_probe,
-	.fb_dirty = drm_fbdev_fb_dirty,
-};
-
-static void drm_fbdev_client_unregister(struct drm_client_dev *client)
-{
-	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
-
-	if (fb_helper->info)
-		/* drm_fbdev_fb_destroy() takes care of cleanup */
-		drm_fb_helper_unregister_info(fb_helper);
-	else
-		drm_fbdev_release(fb_helper);
-}
-
-static int drm_fbdev_client_restore(struct drm_client_dev *client)
-{
-	drm_fb_helper_lastclose(client->dev);
-
-	return 0;
-}
-
-static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
-{
-	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
-	struct drm_device *dev = client->dev;
-	int ret;
-
-	/* Setup is not retried if it has failed */
-	if (!fb_helper->dev && fb_helper->funcs)
-		return 0;
-
-	if (dev->fb_helper)
-		return drm_fb_helper_hotplug_event(dev->fb_helper);
-
-	if (!dev->mode_config.num_connector) {
-		drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n");
-		return 0;
-	}
-
-	drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs);
-
-	ret = drm_fb_helper_init(dev, fb_helper);
-	if (ret)
-		goto err;
-
-	if (!drm_drv_uses_atomic_modeset(dev))
-		drm_helper_disable_unused_functions(dev);
-
-	ret = drm_fb_helper_initial_config(fb_helper, fb_helper->preferred_bpp);
-	if (ret)
-		goto err_cleanup;
-
-	return 0;
-
-err_cleanup:
-	drm_fbdev_cleanup(fb_helper);
-err:
-	fb_helper->dev = NULL;
-	fb_helper->info = NULL;
-
-	drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret);
-
-	return ret;
-}
-
-static const struct drm_client_funcs drm_fbdev_client_funcs = {
-	.owner		= THIS_MODULE,
-	.unregister	= drm_fbdev_client_unregister,
-	.restore	= drm_fbdev_client_restore,
-	.hotplug	= drm_fbdev_client_hotplug,
-};
-
-/**
- * drm_fbdev_generic_setup() - Setup generic fbdev emulation
- * @dev: DRM device
- * @preferred_bpp: Preferred bits per pixel for the device.
- *                 @dev->mode_config.preferred_depth is used if this is zero.
- *
- * This function sets up generic fbdev emulation for drivers that supports
- * dumb buffers with a virtual address and that can be mmap'ed.
- * drm_fbdev_generic_setup() shall be called after the DRM driver registered
- * the new DRM device with drm_dev_register().
- *
- * Restore, hotplug events and teardown are all taken care of. Drivers that do
- * suspend/resume need to call drm_fb_helper_set_suspend_unlocked() themselves.
- * Simple drivers might use drm_mode_config_helper_suspend().
- *
- * Drivers that set the dirty callback on their framebuffer will get a shadow
- * fbdev buffer that is blitted onto the real buffer. This is done in order to
- * make deferred I/O work with all kinds of buffers. A shadow buffer can be
- * requested explicitly by setting struct drm_mode_config.prefer_shadow or
- * struct drm_mode_config.prefer_shadow_fbdev to true beforehand. This is
- * required to use generic fbdev emulation with SHMEM helpers.
- *
- * This function is safe to call even when there are no connectors present.
- * Setup will be retried on the next hotplug event.
- *
- * The fbdev is destroyed by drm_dev_unregister().
- */
-void drm_fbdev_generic_setup(struct drm_device *dev,
-			     unsigned int preferred_bpp)
-{
-	struct drm_fb_helper *fb_helper;
-	int ret;
-
-	drm_WARN(dev, !dev->registered, "Device has not been registered.\n");
-	drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n");
-
-	fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL);
-	if (!fb_helper) {
-		drm_err(dev, "Failed to allocate fb_helper\n");
-		return;
-	}
-
-	ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs);
-	if (ret) {
-		kfree(fb_helper);
-		drm_err(dev, "Failed to register client: %d\n", ret);
-		return;
-	}
-
-	/*
-	 * FIXME: This mixes up depth with bpp, which results in a glorious
-	 * mess, resulting in some drivers picking wrong fbdev defaults and
-	 * others wrong preferred_depth defaults.
-	 */
-	if (!preferred_bpp)
-		preferred_bpp = dev->mode_config.preferred_depth;
-	if (!preferred_bpp)
-		preferred_bpp = 32;
-	fb_helper->preferred_bpp = preferred_bpp;
-
-	ret = drm_fbdev_client_hotplug(&fb_helper->client);
-	if (ret)
-		drm_dbg_kms(dev, "client hotplug ret=%d\n", ret);
-
-	drm_client_register(&fb_helper->client);
-}
-EXPORT_SYMBOL(drm_fbdev_generic_setup);
diff --git a/drivers/gpu/drm/drm_fbdev.c b/drivers/gpu/drm/drm_fbdev.c
new file mode 100644
index 0000000000000..64085bc8b3809
--- /dev/null
+++ b/drivers/gpu/drm/drm_fbdev.c
@@ -0,0 +1,512 @@
+// SPDX-License-Identifier: MIT
+
+#include <linux/moduleparam.h>
+
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_drv.h>
+#include <drm/drm_fb_helper.h>
+#include <drm/drm_framebuffer.h>
+#include <drm/drm_print.h>
+
+#include <drm/drm_fbdev.h>
+
+/*
+ * In order to keep user-space compatibility, we want in certain use-cases
+ * to keep leaking the fbdev physical address to the user-space program
+ * handling the fbdev buffer.
+ * This is a bad habit essentially kept into closed source opengl driver
+ * that should really be moved into open-source upstream projects instead
+ * of using legacy physical addresses in user space to communicate with
+ * other out-of-tree kernel modules.
+ *
+ * This module_param *should* be removed as soon as possible and be
+ * considered as a broken and legacy behaviour from a modern fbdev device.
+ */
+#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
+static bool drm_leak_fbdev_smem;
+module_param_unsafe(drm_leak_fbdev_smem, bool, 0600);
+MODULE_PARM_DESC(drm_leak_fbdev_smem,
+		 "Allow unsafe leaking fbdev physical smem address [default=false]");
+#endif
+
+static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
+{
+	struct drm_device *dev = fb_helper->dev;
+	struct drm_framebuffer *fb = fb_helper->fb;
+
+	return dev->mode_config.prefer_shadow_fbdev ||
+	       dev->mode_config.prefer_shadow ||
+	       fb->funcs->dirty;
+}
+
+/* @user: 1=userspace, 0=fbcon */
+static int drm_fbdev_fb_open(struct fb_info *info, int user)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+
+	/* No need to take a ref for fbcon because it unbinds on unregister */
+	if (user && !try_module_get(fb_helper->dev->driver->fops->owner))
+		return -ENODEV;
+
+	return 0;
+}
+
+static int drm_fbdev_fb_release(struct fb_info *info, int user)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+
+	if (user)
+		module_put(fb_helper->dev->driver->fops->owner);
+
+	return 0;
+}
+
+static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)
+{
+	struct fb_info *fbi = fb_helper->info;
+	void *shadow = NULL;
+
+	if (!fb_helper->dev)
+		return;
+
+	if (fbi) {
+		if (fbi->fbdefio)
+			fb_deferred_io_cleanup(fbi);
+		if (drm_fbdev_use_shadow_fb(fb_helper))
+			shadow = fbi->screen_buffer;
+	}
+
+	drm_fb_helper_fini(fb_helper);
+
+	if (shadow)
+		vfree(shadow);
+	else if (fb_helper->buffer)
+		drm_client_buffer_vunmap(fb_helper->buffer);
+
+	drm_client_framebuffer_delete(fb_helper->buffer);
+}
+
+static void drm_fbdev_release(struct drm_fb_helper *fb_helper)
+{
+	drm_fbdev_cleanup(fb_helper);
+	drm_client_release(&fb_helper->client);
+	kfree(fb_helper);
+}
+
+/*
+ * fb_ops.fb_destroy is called by the last put_fb_info() call at the end of
+ * unregister_framebuffer() or fb_release().
+ */
+static void drm_fbdev_fb_destroy(struct fb_info *info)
+{
+	drm_fbdev_release(info->par);
+}
+
+static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+
+	if (drm_fbdev_use_shadow_fb(fb_helper))
+		return fb_deferred_io_mmap(info, vma);
+	else if (fb_helper->dev->driver->gem_prime_mmap)
+		return fb_helper->dev->driver->gem_prime_mmap(fb_helper->buffer->gem, vma);
+	else
+		return -ENODEV;
+}
+
+static bool drm_fbdev_use_iomem(struct fb_info *info)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+	struct drm_client_buffer *buffer = fb_helper->buffer;
+
+	return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem;
+}
+
+static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
+				 size_t count, loff_t *ppos)
+{
+	ssize_t ret;
+
+	if (drm_fbdev_use_iomem(info))
+		ret = drm_fb_helper_cfb_read(info, buf, count, ppos);
+	else
+		ret = drm_fb_helper_sys_read(info, buf, count, ppos);
+
+	return ret;
+}
+
+static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
+				  size_t count, loff_t *ppos)
+{
+	ssize_t ret;
+
+	if (drm_fbdev_use_iomem(info))
+		ret = drm_fb_helper_cfb_write(info, buf, count, ppos);
+	else
+		ret = drm_fb_helper_sys_write(info, buf, count, ppos);
+
+	return ret;
+}
+
+static void drm_fbdev_fb_fillrect(struct fb_info *info,
+				  const struct fb_fillrect *rect)
+{
+	if (drm_fbdev_use_iomem(info))
+		drm_fb_helper_cfb_fillrect(info, rect);
+	else
+		drm_fb_helper_sys_fillrect(info, rect);
+}
+
+static void drm_fbdev_fb_copyarea(struct fb_info *info,
+				  const struct fb_copyarea *area)
+{
+	if (drm_fbdev_use_iomem(info))
+		drm_fb_helper_cfb_copyarea(info, area);
+	else
+		drm_fb_helper_sys_copyarea(info, area);
+}
+
+static void drm_fbdev_fb_imageblit(struct fb_info *info,
+				   const struct fb_image *image)
+{
+	if (drm_fbdev_use_iomem(info))
+		drm_fb_helper_cfb_imageblit(info, image);
+	else
+		drm_fb_helper_sys_imageblit(info, image);
+}
+
+static const struct fb_ops drm_fbdev_fb_ops = {
+	.owner		= THIS_MODULE,
+	DRM_FB_HELPER_DEFAULT_OPS,
+	.fb_open	= drm_fbdev_fb_open,
+	.fb_release	= drm_fbdev_fb_release,
+	.fb_destroy	= drm_fbdev_fb_destroy,
+	.fb_mmap	= drm_fbdev_fb_mmap,
+	.fb_read	= drm_fbdev_fb_read,
+	.fb_write	= drm_fbdev_fb_write,
+	.fb_fillrect	= drm_fbdev_fb_fillrect,
+	.fb_copyarea	= drm_fbdev_fb_copyarea,
+	.fb_imageblit	= drm_fbdev_fb_imageblit,
+};
+
+static struct fb_deferred_io drm_fbdev_defio = {
+	.delay		= HZ / 20,
+	.deferred_io	= drm_fb_helper_deferred_io,
+};
+
+/*
+ * This function uses the client API to create a framebuffer backed by a dumb buffer.
+ */
+static int drm_fbdev_fb_probe(struct drm_fb_helper *fb_helper,
+			      struct drm_fb_helper_surface_size *sizes)
+{
+	struct drm_client_dev *client = &fb_helper->client;
+	struct drm_device *dev = fb_helper->dev;
+	struct drm_client_buffer *buffer;
+	struct drm_framebuffer *fb;
+	struct fb_info *fbi;
+	u32 format;
+	struct iosys_map map;
+	int ret;
+
+	drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n",
+		    sizes->surface_width, sizes->surface_height,
+		    sizes->surface_bpp);
+
+	format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
+	buffer = drm_client_framebuffer_create(client, sizes->surface_width,
+					       sizes->surface_height, format);
+	if (IS_ERR(buffer))
+		return PTR_ERR(buffer);
+
+	fb_helper->buffer = buffer;
+	fb_helper->fb = buffer->fb;
+	fb = buffer->fb;
+
+	fbi = drm_fb_helper_alloc_info(fb_helper);
+	if (IS_ERR(fbi))
+		return PTR_ERR(fbi);
+
+	fbi->fbops = &drm_fbdev_fb_ops;
+	fbi->screen_size = sizes->surface_height * fb->pitches[0];
+	fbi->fix.smem_len = fbi->screen_size;
+	fbi->flags = FBINFO_DEFAULT;
+
+	drm_fb_helper_fill_info(fbi, fb_helper, sizes);
+
+	if (drm_fbdev_use_shadow_fb(fb_helper)) {
+		fbi->screen_buffer = vzalloc(fbi->screen_size);
+		if (!fbi->screen_buffer)
+			return -ENOMEM;
+		fbi->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST;
+
+		fbi->fbdefio = &drm_fbdev_defio;
+		fb_deferred_io_init(fbi);
+	} else {
+		/* buffer is mapped for HW framebuffer */
+		ret = drm_client_buffer_vmap(fb_helper->buffer, &map);
+		if (ret)
+			return ret;
+		if (map.is_iomem) {
+			fbi->screen_base = map.vaddr_iomem;
+		} else {
+			fbi->screen_buffer = map.vaddr;
+			fbi->flags |= FBINFO_VIRTFB;
+		}
+
+		/*
+		 * Shamelessly leak the physical address to user-space. As
+		 * page_to_phys() is undefined for I/O memory, warn in this
+		 * case.
+		 */
+#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
+		if (drm_leak_fbdev_smem && fbi->fix.smem_start == 0 &&
+		    !drm_WARN_ON_ONCE(dev, map.is_iomem))
+			fbi->fix.smem_start =
+				page_to_phys(virt_to_page(fbi->screen_buffer));
+#endif
+	}
+
+	return 0;
+}
+
+static void drm_fbdev_damage_blit_real(struct drm_fb_helper *fb_helper,
+				       struct drm_clip_rect *clip,
+				       struct iosys_map *dst)
+{
+	struct drm_framebuffer *fb = fb_helper->fb;
+	size_t offset = clip->y1 * fb->pitches[0];
+	size_t len = clip->x2 - clip->x1;
+	unsigned int y;
+	void *src;
+
+	switch (drm_format_info_bpp(fb->format, 0)) {
+	case 1:
+		offset += clip->x1 / 8;
+		len = DIV_ROUND_UP(len + clip->x1 % 8, 8);
+		break;
+	case 2:
+		offset += clip->x1 / 4;
+		len = DIV_ROUND_UP(len + clip->x1 % 4, 4);
+		break;
+	case 4:
+		offset += clip->x1 / 2;
+		len = DIV_ROUND_UP(len + clip->x1 % 2, 2);
+		break;
+	default:
+		offset += clip->x1 * fb->format->cpp[0];
+		len *= fb->format->cpp[0];
+		break;
+	}
+
+	src = fb_helper->info->screen_buffer + offset;
+	iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
+
+	for (y = clip->y1; y < clip->y2; y++) {
+		iosys_map_memcpy_to(dst, 0, src, len);
+		iosys_map_incr(dst, fb->pitches[0]);
+		src += fb->pitches[0];
+	}
+}
+
+static int drm_fbdev_damage_blit(struct drm_fb_helper *fb_helper,
+				 struct drm_clip_rect *clip)
+{
+	struct drm_client_buffer *buffer = fb_helper->buffer;
+	struct iosys_map map, dst;
+	int ret;
+
+	/*
+	 * We have to pin the client buffer to its current location while
+	 * flushing the shadow buffer. In the general case, concurrent
+	 * modesetting operations could try to move the buffer and would
+	 * fail. The modeset has to be serialized by acquiring the reservation
+	 * object of the underlying BO here.
+	 *
+	 * For fbdev emulation, we only have to protect against fbdev modeset
+	 * operations. Nothing else will involve the client buffer's BO. So it
+	 * is sufficient to acquire struct drm_fb_helper.lock here.
+	 */
+	mutex_lock(&fb_helper->lock);
+
+	ret = drm_client_buffer_vmap(buffer, &map);
+	if (ret)
+		goto out;
+
+	dst = map;
+	drm_fbdev_damage_blit_real(fb_helper, clip, &dst);
+
+	drm_client_buffer_vunmap(buffer);
+
+out:
+	mutex_unlock(&fb_helper->lock);
+
+	return ret;
+}
+
+static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
+{
+	struct drm_device *dev = helper->dev;
+	int ret;
+
+	if (!drm_fbdev_use_shadow_fb(helper))
+		return 0;
+
+	/* Call damage handlers only if necessary */
+	if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
+		return 0;
+
+	if (helper->buffer) {
+		ret = drm_fbdev_damage_blit(helper, clip);
+		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	if (helper->fb->funcs->dirty) {
+		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
+		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	return 0;
+}
+
+static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = {
+	.fb_probe = drm_fbdev_fb_probe,
+	.fb_dirty = drm_fbdev_fb_dirty,
+};
+
+static void drm_fbdev_client_unregister(struct drm_client_dev *client)
+{
+	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
+
+	if (fb_helper->info)
+		/* drm_fbdev_fb_destroy() takes care of cleanup */
+		drm_fb_helper_unregister_info(fb_helper);
+	else
+		drm_fbdev_release(fb_helper);
+}
+
+static int drm_fbdev_client_restore(struct drm_client_dev *client)
+{
+	drm_fb_helper_lastclose(client->dev);
+
+	return 0;
+}
+
+static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
+{
+	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
+	struct drm_device *dev = client->dev;
+	int ret;
+
+	/* Setup is not retried if it has failed */
+	if (!fb_helper->dev && fb_helper->funcs)
+		return 0;
+
+	if (dev->fb_helper)
+		return drm_fb_helper_hotplug_event(dev->fb_helper);
+
+	if (!dev->mode_config.num_connector) {
+		drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n");
+		return 0;
+	}
+
+	drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs);
+
+	ret = drm_fb_helper_init(dev, fb_helper);
+	if (ret)
+		goto err;
+
+	if (!drm_drv_uses_atomic_modeset(dev))
+		drm_helper_disable_unused_functions(dev);
+
+	ret = drm_fb_helper_initial_config(fb_helper, fb_helper->preferred_bpp);
+	if (ret)
+		goto err_cleanup;
+
+	return 0;
+
+err_cleanup:
+	drm_fbdev_cleanup(fb_helper);
+err:
+	fb_helper->dev = NULL;
+	fb_helper->info = NULL;
+
+	drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret);
+
+	return ret;
+}
+
+static const struct drm_client_funcs drm_fbdev_client_funcs = {
+	.owner		= THIS_MODULE,
+	.unregister	= drm_fbdev_client_unregister,
+	.restore	= drm_fbdev_client_restore,
+	.hotplug	= drm_fbdev_client_hotplug,
+};
+
+/**
+ * drm_fbdev_generic_setup() - Setup generic fbdev emulation
+ * @dev: DRM device
+ * @preferred_bpp: Preferred bits per pixel for the device.
+ *                 @dev->mode_config.preferred_depth is used if this is zero.
+ *
+ * This function sets up generic fbdev emulation for drivers that supports
+ * dumb buffers with a virtual address and that can be mmap'ed.
+ * drm_fbdev_generic_setup() shall be called after the DRM driver registered
+ * the new DRM device with drm_dev_register().
+ *
+ * Restore, hotplug events and teardown are all taken care of. Drivers that do
+ * suspend/resume need to call drm_fb_helper_set_suspend_unlocked() themselves.
+ * Simple drivers might use drm_mode_config_helper_suspend().
+ *
+ * Drivers that set the dirty callback on their framebuffer will get a shadow
+ * fbdev buffer that is blitted onto the real buffer. This is done in order to
+ * make deferred I/O work with all kinds of buffers. A shadow buffer can be
+ * requested explicitly by setting struct drm_mode_config.prefer_shadow or
+ * struct drm_mode_config.prefer_shadow_fbdev to true beforehand. This is
+ * required to use generic fbdev emulation with SHMEM helpers.
+ *
+ * This function is safe to call even when there are no connectors present.
+ * Setup will be retried on the next hotplug event.
+ *
+ * The fbdev is destroyed by drm_dev_unregister().
+ */
+void drm_fbdev_generic_setup(struct drm_device *dev,
+			     unsigned int preferred_bpp)
+{
+	struct drm_fb_helper *fb_helper;
+	int ret;
+
+	drm_WARN(dev, !dev->registered, "Device has not been registered.\n");
+	drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n");
+
+	fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL);
+	if (!fb_helper)
+		return;
+
+	ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs);
+	if (ret) {
+		kfree(fb_helper);
+		drm_err(dev, "Failed to register client: %d\n", ret);
+		return;
+	}
+
+	/*
+	 * FIXME: This mixes up depth with bpp, which results in a glorious
+	 * mess, resulting in some drivers picking wrong fbdev defaults and
+	 * others wrong preferred_depth defaults.
+	 */
+	if (!preferred_bpp)
+		preferred_bpp = dev->mode_config.preferred_depth;
+	if (!preferred_bpp)
+		preferred_bpp = 32;
+	fb_helper->preferred_bpp = preferred_bpp;
+
+	ret = drm_fbdev_client_hotplug(&fb_helper->client);
+	if (ret)
+		drm_dbg_kms(dev, "client hotplug ret=%d\n", ret);
+
+	drm_client_register(&fb_helper->client);
+}
+EXPORT_SYMBOL(drm_fbdev_generic_setup);
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index b4acc3422ba45..5bf2d019dd5c4 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -20,7 +20,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_modeset_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index 8d1630b8edac1..53e4630369c9c 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
+++ b/drivers/gpu/drm/gud/gud_drv.c
@@ -18,7 +18,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index fe4269c5aa0ab..225f67bc18afe 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -17,6 +17,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_vram_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
index 73ee7f25f7346..47c22b8f37acd 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
@@ -19,7 +19,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index f84d39762a72b..c9fa5e152d059 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -11,7 +11,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index 1defd6a40f11d..4f4267c95c76e 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -7,7 +7,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 8dd8b0f912af6..a82c92f0a0d10 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 99f86f1ba8bee..20d8953525876 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -32,7 +32,7 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 2382ccb3ee99d..0fc46b71e5bf5 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -15,7 +15,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
index cc9a4e965f779..87bbfd55f7803 100644
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -17,7 +17,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_print.h>
 
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 38c3907bb151a..52ec3f70ea087 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -69,7 +69,7 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 91f58db5915f5..450ba47bd8771 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -17,7 +17,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_dma_helper.h>
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index 3b24a924b7b97..c88a5eab9dad3 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -18,7 +18,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modeset_helper_vtables.h>
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index ece6cd102dbb1..75132cfc8d6de 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -11,6 +11,7 @@
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
index 075002ed6fb09..d682b26f84c0b 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mode_config.h>
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index b29b332ed3814..eec7c26d039f0 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -20,7 +20,7 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index b59472c29a40d..d37fc22527e1f 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -31,7 +31,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index eb25eedb5ee00..fdc40470e1a1f 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -48,7 +48,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 3044ca948ce22..34cda5b234100 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.c
+++ b/drivers/gpu/drm/qxl/qxl_drv.c
@@ -37,6 +37,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_gem_ttm_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index a2776f1d6f2c2..6b9e87a49e8e9 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -20,7 +20,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 813f9f8c86982..8bf0a85a59b40 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -17,7 +17,7 @@
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
index f2795f90ea693..5a654201ff32c 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -23,7 +23,7 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 7abf010a32935..0d9607855ef66 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -14,7 +14,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
index d7914f5122dff..9e7159eef7e2c 100644
--- a/drivers/gpu/drm/stm/drv.c
+++ b/drivers/gpu/drm/stm/drv.c
@@ -18,7 +18,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index d06ffd99d86e1..63d27244268ea 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -17,7 +17,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 15cd9b91b7e2a..0c5534194cd0f 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -14,7 +14,7 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index f72755b8ea14c..3fb1e8d0e8f80 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
index bb302a3fd6b5f..4d10c5bf2e601 100644
--- a/drivers/gpu/drm/tiny/arcpgu.c
+++ b/drivers/gpu/drm/tiny/arcpgu.c
@@ -12,7 +12,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index a51262289aefd..e7e46502612b1 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -7,7 +7,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c
index 354d5e854a6f0..f7181b2f8369d 100644
--- a/drivers/gpu/drm/tiny/cirrus.c
+++ b/drivers/gpu/drm/tiny/cirrus.c
@@ -30,7 +30,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
index 7441d992a5d7a..3a37138aeba96 100644
--- a/drivers/gpu/drm/tiny/gm12u320.c
+++ b/drivers/gpu/drm/tiny/gm12u320.c
@@ -12,7 +12,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
diff --git a/drivers/gpu/drm/tiny/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c
index 48c24aa8c28a1..eefffa46bb78d 100644
--- a/drivers/gpu/drm/tiny/hx8357d.c
+++ b/drivers/gpu/drm/tiny/hx8357d.c
@@ -18,7 +18,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/ili9163.c b/drivers/gpu/drm/tiny/ili9163.c
index 9a1a5943bee01..0aa1d84995abc 100644
--- a/drivers/gpu/drm/tiny/ili9163.c
+++ b/drivers/gpu/drm/tiny/ili9163.c
@@ -9,7 +9,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_mipi_dbi.h>
diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
index a79da2b4af647..028e63e68a883 100644
--- a/drivers/gpu/drm/tiny/ili9225.c
+++ b/drivers/gpu/drm/tiny/ili9225.c
@@ -20,7 +20,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/ili9341.c b/drivers/gpu/drm/tiny/ili9341.c
index 69b265e78096b..2a0b516ff1b44 100644
--- a/drivers/gpu/drm/tiny/ili9341.c
+++ b/drivers/gpu/drm/tiny/ili9341.c
@@ -17,7 +17,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index c80028bb1d110..f16cadc813ca7 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -16,7 +16,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c
index bc522fb3d94d1..5307d5d28df59 100644
--- a/drivers/gpu/drm/tiny/mi0283qt.c
+++ b/drivers/gpu/drm/tiny/mi0283qt.c
@@ -15,7 +15,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
index 0e1cc2369afcc..016372da72d12 100644
--- a/drivers/gpu/drm/tiny/ofdrm.c
+++ b/drivers/gpu/drm/tiny/ofdrm.c
@@ -11,7 +11,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
index 955a61d628e7c..7249cf8accec4 100644
--- a/drivers/gpu/drm/tiny/panel-mipi-dbi.c
+++ b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
@@ -16,7 +16,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index e62f4d16b2c6b..347366a3d5767 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -26,7 +26,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index cbb100753154e..b9f541c058c55 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -15,7 +15,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c
index b6f620b902e6d..a9de2c6695d13 100644
--- a/drivers/gpu/drm/tiny/st7586.c
+++ b/drivers/gpu/drm/tiny/st7586.c
@@ -16,7 +16,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c
index c36ba08acda18..4d2d43c27582f 100644
--- a/drivers/gpu/drm/tiny/st7735r.c
+++ b/drivers/gpu/drm/tiny/st7735r.c
@@ -18,7 +18,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c
index 611785e097576..684f319d94c70 100644
--- a/drivers/gpu/drm/tve200/tve200_drv.c
+++ b/drivers/gpu/drm/tve200/tve200_drv.c
@@ -40,7 +40,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
index 91effdcefb6d5..6ccfc23b9134c 100644
--- a/drivers/gpu/drm/udl/udl_drv.c
+++ b/drivers/gpu/drm/udl/udl_drv.c
@@ -7,7 +7,7 @@
 
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index 1cd716eb17a1c..61cc110440a54 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_drv.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c
@@ -14,7 +14,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 2027063fdc309..94d4a6b1cd3ab 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -33,7 +33,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_vblank.h>
 
 #include <soc/bcm2835/raspberrypi-firmware.h>
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
index 0035affc3e590..70c0f49ac895b 100644
--- a/drivers/gpu/drm/virtio/virtgpu_drv.c
+++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
@@ -35,6 +35,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 
 #include "virtgpu_drv.h"
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 0ffe5f0e33f75..e616d2e614dcb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -17,7 +17,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_ioctl.h>
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 1de2d927c32b0..27c8a8218914b 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -19,7 +19,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 6581183618b89..933ca016f1224 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -285,9 +285,6 @@ int drm_fb_helper_debug_leave(struct fb_info *info);
 
 void drm_fb_helper_lastclose(struct drm_device *dev);
 void drm_fb_helper_output_poll_changed(struct drm_device *dev);
-
-void drm_fbdev_generic_setup(struct drm_device *dev,
-			     unsigned int preferred_bpp);
 #else
 static inline void drm_fb_helper_prepare(struct drm_device *dev,
 					struct drm_fb_helper *helper,
@@ -472,12 +469,6 @@ static inline void drm_fb_helper_lastclose(struct drm_device *dev)
 static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev)
 {
 }
-
-static inline void
-drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
-{
-}
-
 #endif
 
 #endif
diff --git a/include/drm/drm_fbdev.h b/include/drm/drm_fbdev.h
new file mode 100644
index 0000000000000..d977087e94b6b
--- /dev/null
+++ b/include/drm/drm_fbdev.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: MIT */
+
+#ifndef DRM_FBDEV_H
+#define DRM_FBDEV_H
+
+struct drm_device;
+
+#ifdef CONFIG_DRM_FBDEV_EMULATION
+void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp);
+#else
+static inline void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
+{ }
+#endif
+
+#endif
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:45:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:45:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426532.675071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT3a-0001va-QT; Thu, 20 Oct 2022 10:45:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426532.675071; Thu, 20 Oct 2022 10:45:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT3a-0001vT-MZ; Thu, 20 Oct 2022 10:45:46 +0000
Received: by outflank-mailman (input) for mailman id 426532;
 Thu, 20 Oct 2022 10:45:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwD-0005Jc-BU
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:09 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4868608c-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6426222B4D;
 Thu, 20 Oct 2022 10:38:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DF56E13B72;
 Thu, 20 Oct 2022 10:38:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gCa6NQ0lUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4868608c-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mIcpJgbeqPNRftPv7Q4iDJZ6HW36+TLeNbJLj/Rhtmc=;
	b=N/8J0ZK8TlQrP5MuDUFT352ZqaEtcH54y/j5pTXt7N3TgI2w7bd+xrImKYdts233ORrkL5
	96bET5hbW0jJYocJOqg4OzXHlCJPGxknEB/FVdDBHax7Y/eSp5Z4DXiaSbNfQsUqhKhOdj
	J2Jx0pUIYCEZPKgNcvZIeR4EGI3eKRI=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262286;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mIcpJgbeqPNRftPv7Q4iDJZ6HW36+TLeNbJLj/Rhtmc=;
	b=R0s5ULDxkJmC55xxZ8WO3j2KQleS938cWUVKLDjw3qyEeAZZSyml7D/dHNB+DzxT2LycZH
	zPCX9qzygK8x75DQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 18/21] drm/fb_helper: Minimize damage-helper overhead
Date: Thu, 20 Oct 2022 12:37:52 +0200
Message-Id: <20221020103755.24058-19-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Pull the test for fb_dirty into the caller to avoid extra work
if no callback has been set. In this case no damage handling is
required and no damage area needs to be computed. Print a warning
if the damage worker runs without getting an fb_dirty callback.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++-----------
 1 file changed, 60 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 836523aef6a27..fbc5c5445fdb0 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper,
 static void drm_fb_helper_damage_work(struct work_struct *work)
 {
 	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
+	struct drm_device *dev = helper->dev;
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	struct drm_clip_rect clip_copy;
 	unsigned long flags;
 	int ret;
 
-	if (!helper->funcs->fb_dirty)
+	if (drm_WARN_ON_ONCE(dev, !helper->funcs->fb_dirty))
 		return;
 
 	spin_lock_irqsave(&helper->damage_lock, flags);
@@ -659,16 +660,12 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
 }
 EXPORT_SYMBOL(drm_fb_helper_fini);
 
-static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y,
+static void drm_fb_helper_damage(struct drm_fb_helper *helper, u32 x, u32 y,
 				 u32 width, u32 height)
 {
-	struct drm_fb_helper *helper = info->par;
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	unsigned long flags;
 
-	if (!helper->funcs->fb_dirty)
-		return;
-
 	spin_lock_irqsave(&helper->damage_lock, flags);
 	clip->x1 = min_t(u32, clip->x1, x);
 	clip->y1 = min_t(u32, clip->y1, y);
@@ -718,6 +715,7 @@ static void drm_fb_helper_memory_range_to_clip(struct fb_info *info, off_t off,
  */
 void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagereflist)
 {
+	struct drm_fb_helper *helper = info->par;
 	unsigned long start, end, min_off, max_off;
 	struct fb_deferred_io_pageref *pageref;
 	struct drm_rect damage_area;
@@ -733,17 +731,19 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli
 	if (min_off >= max_off)
 		return;
 
-	/*
-	 * As we can only track pages, we might reach beyond the end
-	 * of the screen and account for non-existing scanlines. Hence,
-	 * keep the covered memory area within the screen buffer.
-	 */
-	max_off = min(max_off, info->screen_size);
+	if (helper->funcs->fb_dirty) {
+		/*
+		 * As we can only track pages, we might reach beyond the end
+		 * of the screen and account for non-existing scanlines. Hence,
+		 * keep the covered memory area within the screen buffer.
+		 */
+		max_off = min(max_off, info->screen_size);
 
-	drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+		drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
+		drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
+				     drm_rect_width(&damage_area),
+				     drm_rect_height(&damage_area));
+	}
 }
 EXPORT_SYMBOL(drm_fb_helper_deferred_io);
 
@@ -877,6 +877,7 @@ static ssize_t drm_fb_helper_write_screen_buffer(struct fb_info *info, const cha
 ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 				size_t count, loff_t *ppos)
 {
+	struct drm_fb_helper *helper = info->par;
 	loff_t pos = *ppos;
 	ssize_t ret;
 	struct drm_rect damage_area;
@@ -885,10 +886,12 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 	if (ret <= 0)
 		return ret;
 
-	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+	if (helper->funcs->fb_dirty) {
+		drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
+		drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
+				     drm_rect_width(&damage_area),
+				     drm_rect_height(&damage_area));
+	}
 
 	return ret;
 }
@@ -904,8 +907,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_write);
 void drm_fb_helper_sys_fillrect(struct fb_info *info,
 				const struct fb_fillrect *rect)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	sys_fillrect(info, rect);
-	drm_fb_helper_damage(info, rect->dx, rect->dy, rect->width, rect->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, rect->dx, rect->dy, rect->width, rect->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_fillrect);
 
@@ -919,8 +926,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_fillrect);
 void drm_fb_helper_sys_copyarea(struct fb_info *info,
 				const struct fb_copyarea *area)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	sys_copyarea(info, area);
-	drm_fb_helper_damage(info, area->dx, area->dy, area->width, area->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, area->dx, area->dy, area->width, area->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_copyarea);
 
@@ -934,8 +945,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_copyarea);
 void drm_fb_helper_sys_imageblit(struct fb_info *info,
 				 const struct fb_image *image)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	sys_imageblit(info, image);
-	drm_fb_helper_damage(info, image->dx, image->dy, image->width, image->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, image->dx, image->dy, image->width, image->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_imageblit);
 
@@ -1035,6 +1050,7 @@ static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf
 ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
 				size_t count, loff_t *ppos)
 {
+	struct drm_fb_helper *helper = info->par;
 	loff_t pos = *ppos;
 	ssize_t ret;
 	struct drm_rect damage_area;
@@ -1043,10 +1059,12 @@ ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
 	if (ret <= 0)
 		return ret;
 
-	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+	if (helper->funcs->fb_dirty) {
+		drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
+		drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
+				     drm_rect_width(&damage_area),
+				     drm_rect_height(&damage_area));
+	}
 
 	return ret;
 }
@@ -1062,8 +1080,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_write);
 void drm_fb_helper_cfb_fillrect(struct fb_info *info,
 				const struct fb_fillrect *rect)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	cfb_fillrect(info, rect);
-	drm_fb_helper_damage(info, rect->dx, rect->dy, rect->width, rect->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, rect->dx, rect->dy, rect->width, rect->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect);
 
@@ -1077,8 +1099,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect);
 void drm_fb_helper_cfb_copyarea(struct fb_info *info,
 				const struct fb_copyarea *area)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	cfb_copyarea(info, area);
-	drm_fb_helper_damage(info, area->dx, area->dy, area->width, area->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, area->dx, area->dy, area->width, area->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea);
 
@@ -1092,8 +1118,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea);
 void drm_fb_helper_cfb_imageblit(struct fb_info *info,
 				 const struct fb_image *image)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	cfb_imageblit(info, image);
-	drm_fb_helper_damage(info, image->dx, image->dy, image->width, image->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, image->dx, image->dy, image->width, image->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit);
 
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:45:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:45:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426550.675083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT3l-0002Qy-2y; Thu, 20 Oct 2022 10:45:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426550.675083; Thu, 20 Oct 2022 10:45:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olT3k-0002Qn-Vt; Thu, 20 Oct 2022 10:45:56 +0000
Received: by outflank-mailman (input) for mailman id 426550;
 Thu, 20 Oct 2022 10:45:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olSwE-0005Jc-Bf
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:38:10 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 48ae6420-5063-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:38:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D9D1B22B50;
 Thu, 20 Oct 2022 10:38:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 66DD913AF5;
 Thu, 20 Oct 2022 10:38:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AIpTGA4lUWPPYwAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 10:38:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48ae6420-5063-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666262286; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RsAQdHzLmddns92tHuvM6Lu3vuWZMSsqH8X6KbiDvyM=;
	b=TTUneLInqCmMLWxk1GD9d2KmCCv11lcn/0c/gMV2phygkdJQfTPHckj/c9iS+0OigiTMWP
	2So10ChWze1+vATmbv/Q8ZF0YiaPyDyFitO9dwbZLgDLT8RyNzKQH52H8wmoUPDFfjKEAR
	Q/3UV3yK/09TqKMa6dLR2z894iwISek=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666262286;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RsAQdHzLmddns92tHuvM6Lu3vuWZMSsqH8X6KbiDvyM=;
	b=74ibi82PnzrG8q+dqb3jzekLkKdn6jxNvxS3DQFZ7P39O62bfyXQbwEuh/yfaQt3JOh86W
	/q1sls2vXrEy1KDg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 19/21] drm/fb-helper: Always initialize generic fbdev emulation
Date: Thu, 20 Oct 2022 12:37:53 +0200
Message-Id: <20221020103755.24058-20-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
References: <20221020103755.24058-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Initialize the generic fbdev emulation even if it has been disabled
on the kernel command line. The hotplug and mode initialization will
fail accordingly.

The kernel parameter can still be changed at runtime and the emulation
will initialize after hotplugging the connector.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index fbc5c5445fdb0..d1afb420c6e06 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -526,11 +526,6 @@ int drm_fb_helper_init(struct drm_device *dev,
 {
 	int ret;
 
-	if (!drm_fbdev_emulation) {
-		dev->fb_helper = fb_helper;
-		return 0;
-	}
-
 	/*
 	 * If this is not the generic fbdev client, initialize a drm_client
 	 * without callbacks so we can use the modesets.
@@ -2716,9 +2711,6 @@ void drm_fbdev_generic_setup(struct drm_device *dev,
 	drm_WARN(dev, !dev->registered, "Device has not been registered.\n");
 	drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n");
 
-	if (!drm_fbdev_emulation)
-		return;
-
 	fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL);
 	if (!fb_helper) {
 		drm_err(dev, "Failed to allocate fb_helper\n");
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 10:57:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 10:57:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426571.675094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTEN-0004Qr-78; Thu, 20 Oct 2022 10:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426571.675094; Thu, 20 Oct 2022 10:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTEN-0004Qk-2x; Thu, 20 Oct 2022 10:56:55 +0000
Received: by outflank-mailman (input) for mailman id 426571;
 Thu, 20 Oct 2022 10:55:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=o9p+=2V=omp.ru=s.shtylyov@srs-se1.protection.inumbo.net>)
 id 1olTDQ-0004P3-1t
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 10:55:56 +0000
Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c49a985d-5065-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 12:55:54 +0200 (CEST)
Received: from [192.168.1.103] (31.173.87.29) by msexch01.omp.ru (10.188.4.12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Thu, 20 Oct
 2022 13:55:44 +0300
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c49a985d-5065-11ed-8fd0-01056ac49cbb
Subject: Re: [PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose
To: Thomas Zimmermann <tzimmermann@suse.de>, <daniel@ffwll.ch>,
	<airlied@gmail.com>, <sam@ravnborg.org>, <javierm@redhat.com>,
	<mripard@kernel.org>, <maarten.lankhorst@linux.intel.com>
CC: <dri-devel@lists.freedesktop.org>, <amd-gfx@lists.freedesktop.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-arm-kernel@lists.infradead.org>,
	<etnaviv@lists.freedesktop.org>, <linux-samsung-soc@vger.kernel.org>,
	<linux-hyperv@vger.kernel.org>, <intel-gfx@lists.freedesktop.org>,
	<linux-mips@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>, <linux-arm-msm@vger.kernel.org>,
	<freedreno@lists.freedesktop.org>, <nouveau@lists.freedesktop.org>,
	<virtualization@lists.linux-foundation.org>,
	<spice-devel@lists.freedesktop.org>, <linux-renesas-soc@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-stm32@st-md-mailman.stormreply.com>, <linux-sunxi@lists.linux.dev>,
	<linux-tegra@vger.kernel.org>, <xen-devel@lists.xenproject.org>
References: <20221020103755.24058-1-tzimmermann@suse.de>
 <20221020103755.24058-4-tzimmermann@suse.de>
From: Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <013ea55b-3d51-c89c-eff8-b8d355ded352@omp.ru>
Date: Thu, 20 Oct 2022 13:55:44 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20221020103755.24058-4-tzimmermann@suse.de>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [31.173.87.29]
X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru
 (10.188.4.12)
X-KSE-ServerInfo: msexch01.omp.ru, 9
X-KSE-AntiSpam-Interceptor-Info: scan successful
X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 10/20/2022 10:25:24
X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED
X-KSE-AntiSpam-Method: none
X-KSE-AntiSpam-Rate: 59
X-KSE-AntiSpam-Info: Lua profiles 173210 [Oct 20 2022]
X-KSE-AntiSpam-Info: Version: 5.9.20.0
X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru
X-KSE-AntiSpam-Info: LuaCore: 502 502 69dee8ef46717dd3cb3eeb129cb7cc8dab9e30f6
X-KSE-AntiSpam-Info: {rep_avail}
X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to}
X-KSE-AntiSpam-Info: {relay has no DNS name}
X-KSE-AntiSpam-Info: {SMTP from is not routable}
X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.87.29 in (user)
 b.barracudacentral.org}
X-KSE-AntiSpam-Info:
	omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1
X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.87.29
X-KSE-AntiSpam-Info: {DNS response errors}
X-KSE-AntiSpam-Info: Rate: 59
X-KSE-AntiSpam-Info: Status: not_detected
X-KSE-AntiSpam-Info: Method: none
X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror
 smtp.mailfrom=omp.ru;dkim=none
X-KSE-Antiphishing-Info: Clean
X-KSE-Antiphishing-ScanningType: Heuristic
X-KSE-Antiphishing-Method: None
X-KSE-Antiphishing-Bases: 10/20/2022 10:32:00
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 10/20/2022 7:12:00 AM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit

Hello!

On 10/20/22 1:37 PM, Thomas Zimmermann wrote:

> Don't set struct drm_mode_config.output_poll_changed. It's used to
> inform the fbdev console about conncetor changes. But as ingenic

   Connector. :-)

> uses generic fbdev emulation, the console is being informed by the
> DRM client helpers already. See the calls to drm_client_dev_hotplug()
> in drm_probe_helper.c.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
[...]

MBR, Sergey


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:02:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:02:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426578.675105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTJM-0005yL-RQ; Thu, 20 Oct 2022 11:02:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426578.675105; Thu, 20 Oct 2022 11:02:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTJM-0005yE-Nr; Thu, 20 Oct 2022 11:02:04 +0000
Received: by outflank-mailman (input) for mailman id 426578;
 Thu, 20 Oct 2022 11:02:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olTJL-0005y8-7F
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:02:03 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9deb8691-5066-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:02:00 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 07:01:47 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by CO3PR03MB6710.namprd03.prod.outlook.com (2603:10b6:303:179::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Thu, 20 Oct
 2022 11:01:45 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 11:01:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9deb8691-5066-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666263720;
  h=date:from:to:cc:subject:message-id:mime-version;
  bh=KmCyTak+VODO0QMq72yeqEp7X7xp5qmgcjEkBN+xIjM=;
  b=NHwDlXndffwNnkPb9qSjJ0wSLS5vVrFsxo1eThFFuda6EhCqD/E8Qocb
   8vOMgPd+2GeL+wqY17n0ZDvy6pUN+UiMaMflHlSHy4j1J0d0pEHmvu5N7
   sfoqKh3A1vF44UUbw7Ya/sKbQ7BUMljsswDAvlMgFnu54sVuSYj8bGljM
   Q=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 82773652
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:zHIY1q876vLgltsH4J1UDrUDl3+TJUtcMsCJ2f8bNWPcYEJGY0x3n
 GQWUG6EPqreYzHxctF3O4u0o05TvpfUnYJkSQZv+Cw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5ARmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sp1EWNyz
 LtfFAsIcyve2+iKwrmVT+Y506zPLOGzVG8ekldJ6GiASNwAEdXESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujaDpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toijz2bSRwHmTtIQ6NbCS+vM1hVOowH0YBgMNd2aGhtPksxvrMz5YA
 wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmoOQyNFadcmnNQrXjFs3
 ViM9+4FHhRqubyRDHibprGdqGrrPTBPdDFSIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w
 HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCQJuLpzm07hl6Y0z4=
IronPort-HdrOrdr: A9a23:EXVSV66k7bfgYfk6QgPXwSGBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKkyXcV2/h2AV7GZmXbUQSTTL2KgbGSoAEIeBeOjNK1t5
 0QFJSWYeeYZTYasS+T2njCLz9K+qjizEnHv5a98587JjsaE52Ioj0JfzqzIwlTfk1rFJA5HJ
 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cCIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S
 zgnxbi7quunvmnwlv31nPV7b5RhNz9o+EzcPCku4wwEHHBmwyobINuV/mruy00mvim7BIQnN
 zFs34bTrROwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOSfx2g4FhpVRwa
 hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGbf2UIUh4LD3wXklXKvpREnBmc8a+a
 hVfYjhDc9tABmnhyuzhBgg/DSuNk5DbytuDHJy+/B96AIm40yR/3FoufD3oU1wiK7Va6M0lN
 gsYZ4Y5o1mf4sxUZ9XItsnbI+eNlHtKCi8Tl56Z26XYp06Bw==
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="82773652"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h4yk2h6uwvlkhyexMjIH7jk1w3bOSAhj/A2upPdCKU+/8HR5hPpHzxGOQXFUZ+8F64rI+UM2KFwPbY5A/jJ8i/DEzNWd2NhN4BN+tvdyA6J4GckwkW/QZ0g++3PLqgAG5L6f5JESm+6svzAGeMNIc82fMiwWS5OGBrBkdff1+OwvosGx0IIYwljyPJi+YBDEySme3gXSv/Dw+qVJraSwVqvDtp8HHP0NZd3yXq8faGqi5mth3t7QguoMNl+thBYEJogeFFLwsWblymlk/UNitAY7/47ntGgELKsRE4fRNa5Uilv60a5azV/p2ZNfdHEq6fHFVu3UEWVIhu/VAfmnAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=abG0llaJ4lf+ZHf60Txqxj+V4pUUt/WOv1efd66UfDg=;
 b=VnAoF866FJGnOSP/B1nyYWm/+nnPewyVU6q/yEYln7JLqjV32YncXzFWaafbcUFCpnxdr72EqmYfRoehMTtqQdgahst7uEiDMVJcw08TgTRjFfbCtuhZS/CvE5WNnwJbYlGZXO2j0i45GWjCPGR12NWLGMFG1uMbqXIhDB++qPehgY9qAE/0fqybebdFDTIck5I4aZtbZwQZ32AoB2IRzW+xv7NM7tEPCSP7sq6zUh3kNpmu0Fku6F/qisK9KW9cqYlBhxx5s4+KnzdSwC+QdH78UHBGdB9kyCKpbZgXeltT75g1z9nwBYzc3RPSxatC2JPk3Bn2QGudalL+xtw5zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=abG0llaJ4lf+ZHf60Txqxj+V4pUUt/WOv1efd66UfDg=;
 b=PDNai1mLUC5K8RkErxiMjvgOZIROf1tyaVoViT5thiePvL3ByHsPiG/67pVgK+l9XqusRC7LQVW21R8nO10wBi5BoNuqkZj/zTg4u+PP9b6S7Br23c29ILrdGxsKh1CFy8zNJQGMcf5KasibN5RuVKZcW0v/x//ndw/SRnKSJqE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 20 Oct 2022 13:01:39 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Intended behavior/usage of SSBD setting
Message-ID: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-ClientProxiedBy: LO4P123CA0541.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:319::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|CO3PR03MB6710:EE_
X-MS-Office365-Filtering-Correlation-Id: 7b47f8e4-8225-41db-d917-08dab28a79e5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7HdoB+TbskL/ItciKf7Ir80FKYbH/+jRqc/S3hCl2bAy13ADmgSPKfyLwLnOGc+bLBfb2BssgQtW67mWLIKH7k5RYicoF0AE9BVbAmj9+4djHvsk7K7slzsnVgGS5+R3F3IHM3TTGyswM3hCTfeDALfl4W/+wWOMLI1SdrxNDj4Ng8vXVdquFfOEzQYOewQTp4NHCJOeqmoMSGklJ0K/8E5c6j3KnWg8fxK2s8xBZofS8AdXOfgdmquoj3FyPLmf2ll15JFVqiKQuJdEqAXAe7I252HxvxzJwFsYlGVlFqmsvG0E69bJJQeZK8Hx3dd9ia3MgaMK9SFk+5vtgjdCQUaSMw2qSaolU+5Ve9FP8nqv7UaPGgcgiS1ddQ3CMTLaAvNJRMnJhLI9pXRBSt290d5eZIZVk++L06a9q8e0HF4FHpa5ouk0pCkv49w2Mf4lLKEQTfhyqE0urZhxQKwPABheM78eBvgodWoI+yQrZAgql+3kdayR5TfKOCqEHdJo1T2JEJkRadunhpFCe539SeAQ2AHKRCB9+bknLBsF4wMHvpDZnGyPkDd973pFNWL9fDhpP3s9u4u2VuGl9ahP5EHX0VtV/PtpPU/T82TpjIwdIqwpGSy6KSqtDTZSKUfovD1qc52Lp4X/UsxA3ywSgB4EIGdV6DiEG8XOSbQe9Qns36fxGGPvxZJJrEVdGKG5go1OUUxEIa9Lr1zn5xCZlmuq6/rqmkp2nJy2+8STHUlXXsM20gZhXvRTGknMLyzU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199015)(85182001)(66899015)(66476007)(5660300002)(38100700002)(66946007)(86362001)(4326008)(41300700001)(66556008)(9686003)(6486002)(33716001)(6666004)(8676002)(83380400001)(186003)(26005)(82960400001)(54906003)(6512007)(478600001)(966005)(316002)(8936002)(6916009)(6506007)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZDRvUnlGb1lOQ2t0aGtjYXU4RkczTndvZGZzVzdqdTlIMnUraFhwRjlRbENu?=
 =?utf-8?B?YUU1QldvRTFmM0FIem9xTnJLazgwcWNTSXZ5S3RKb0dpcWdLclVzWWVSWm5R?=
 =?utf-8?B?aGZ0TStQUEZCem9qU3UxZnFVaXlybFNSdmlRY0VneGQ2OXU4SGQwaWRNM3Qv?=
 =?utf-8?B?UVBHdko0Mmo1TUs2SXQvVGpCQkYxL3UzVTFyS1Jlb1F1OGJtK3RNekZaU3Nx?=
 =?utf-8?B?aC9uUXFoWVJsSzVraFJCL3BRUlpzZXNaWFFDNDFSZUVxUTloU2lWdlhKeDQz?=
 =?utf-8?B?dFhvN0FTaEREUWFrbnpRMnpZdWdhK0ZJOVZGOVBvWDZFK3FNdEMxZTQ5aXZ5?=
 =?utf-8?B?TU1QS0JDZTFSNW83SXRLREhVZU1KekJJR2tsa29xbFFxZVY4U3ZXUTBLdEsw?=
 =?utf-8?B?V1ZHUXM2bW1zYTZRSUVZdzA0U0M2NjQxekZCR0JvNHMyWkM2TmVhY21TK2FB?=
 =?utf-8?B?N25FT1JFQjBFM3NROStCaERsMUloeXZGT3JOTVBydkZsbCtPb2pJMkFwZ2pN?=
 =?utf-8?B?NUplU3ZBR1ZlUmQrTjJ2SGpSWXhVUEl2dUFzVWJuYUE4VU9YdDUzREptcFJC?=
 =?utf-8?B?bW9YbzBmZzV2SUJmQzdUTTRXZmt5bDdvajJHWUp2QWxKMlV2T3FzZmI2TFp3?=
 =?utf-8?B?Sjk3aFdVaEgyakRmOUdQam0rTFFxM1dEQW5aSjRkbHVweElTZzNwMjVlOStS?=
 =?utf-8?B?Mk9pekIyb2Ntc2dCaGJaV2x3UURUcCtDYzFsS0NPQUxWd2RJSTVNVHpaaWRO?=
 =?utf-8?B?WXF2dGtNcmNyS0JJaEZlNmphUzVNaWVrTXVieEQrOEc0QWpnQnkxdC85aWJO?=
 =?utf-8?B?d0VYNWJlckxCaW9aNUpobjJHd3JJaktzSkhZY2N5WTlTS004cWdBTU1HdkRm?=
 =?utf-8?B?anpEdTNkOWNHKy9wOG1WcEZpdm5WMTdhNkcwM0JzZVhpQ01DbFN5U2xKTUQ1?=
 =?utf-8?B?WGtLS3lTbFFTSVljOUZMYm9VaGpVM2dsYlBrUTF1NVBzeGhSMlhtTFJocjhX?=
 =?utf-8?B?Sk4yT1dlWkVlMms4YzBGQXhrOCt2aUZKNUgwNmtTYnZGWEhBTmFxVnRrdFFK?=
 =?utf-8?B?QTIyazZiMlRVVDJkVnpBdHQzdWtZMDdjaUd1RHpVUG5iRWhTLy9XTCthRTRS?=
 =?utf-8?B?eEx4RWduRTRFSmFqcHl0dGNPRGhrSHZacjk2WUp2Y0ppdWNvQVlGVEZMQzFt?=
 =?utf-8?B?d3JXM0h4ZTk2YjNSNEVpUktLUWZaOGhjWWRwcmJQQlRoUnZTOEhFTGJVVkw0?=
 =?utf-8?B?a1RtbUZFOE15NjQ4WjlwMDh4NWVIeEYxeWhBY1UwcnErMWx0MXkxcDh4a1Rp?=
 =?utf-8?B?ajFodXlTVGxnYm55c1FmbGduSE9KbHFFSXVYc3g0ajNSOUkxdU4xbmJ6YkZB?=
 =?utf-8?B?bjB4SUtxb3ZXanJtYTJ1Q25zSm50L0RVaml2aE1nTGs2ZnhqTXVZMkhCeFZJ?=
 =?utf-8?B?b2sxSUtIR1Z0emtIZ2Uvc2RNMEhFUHA0cHlWUlpQZFAraGxabGNPQzUzRE5a?=
 =?utf-8?B?bXJMekIyMUJRcUZIRGdhYWZxbkJSQlc5WEI3U3YydElrWGxMM1crTjRMUU1F?=
 =?utf-8?B?ZEtUNVg5eHlreitpZUJQNGNvbmgyTEEvSmN4U0hHS3BKZ2R0VDR3ZGVkSnln?=
 =?utf-8?B?S1IxaXl6QWZjTXg4TVZvdHNxVWREcWRrWUYvbC9SRk1kUUJXNWwrZFpqd1JI?=
 =?utf-8?B?ODB2aUNUQlJOOFRhYngvajRrbGFPeTFXVXBEOWVmSnBqUS9FSXdFeFNGZEZk?=
 =?utf-8?B?THNPNHpuR3U1eGRCV2s5enV6WGNTVW5XSENiaXM2cDZ4RmRoaS9Cb1lSQVNv?=
 =?utf-8?B?Y01mN2tMQ1NkaWM4U3k3YnBBSktjVHVsTEJQSVFSWjRFVy95RnNwQmdlM0pn?=
 =?utf-8?B?TDIxb1JxSFY2VDR2NEFTcWZUUGVqVE5qOXY4QitvRVJoNDNHbXZWSkU4TlJ5?=
 =?utf-8?B?ZWtvRTE0U1JTTlYrcmkwcDEzRmR5TnpralJ5eFAwZVRNZnl3TFgzUmMrbmJk?=
 =?utf-8?B?VGkzK1dxV0RuZndQZHRxeXhnSVRybnh5UExKRWpGMDFNMWlnS1Zkc3VrVlMy?=
 =?utf-8?B?QUFZcEUvV2hkLytGQkNhR00yTXdYTzJEVFNLSU5XVUV2RTFLaldhdFNnS1NH?=
 =?utf-8?B?MS9MMWF3bnNsYVg2aUdiMDNVUWVLdlowanBNM2ZWVXZtOXl1VzBpODROTGVp?=
 =?utf-8?B?TEE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b47f8e4-8225-41db-d917-08dab28a79e5
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 11:01:44.8871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PtnNCEvhYXVWrD8A0xkQUegBKPc0Hz+iuK7A/dfKz10LmebjraOrfrUlKGa2n0TQVbyh5n7AapHP6bN6Tkx1hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6710

Hello,

As part of some follow up improvements to my VIRT_SPEC_CTRL series we
have been discussing what the usage of SSBD should be for the
hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
that has an out of date description, as now SSBD is always offered to
guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.

It has been pointed out by Andrew that toggling SSBD on AMD using
VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
have a high impact on performance, and hence switching it on every
guest <-> hypervisor context switch is likely a very high
performance penalty.

It's been suggested that it could be more appropriate to run Xen with
the guest SSBD selection on those systems, however that clashes with
the current intent of the `spec-ctrl=ssbd` option.

I hope I have captured the expressed opinions correctly in the text
above.

I see two ways to solve this:

 * Keep the current logic for switching SSBD on guest <-> hypervisor
   context switch, but only use it if `spec-ctrl=ssbd` is set on the
   command line.

 * Remove the logic for switching SSBD on guest <-> hypervisor context
   switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
   hypervisor code with the guest selection of SSBD.

Which has raised me the question of whether there's an use case
for always running hypervisor code with SSBD enabled, or that's no
longer relevant if we always offer guests a way for them to toggle the
setting when required.

I would like to settle on a way forward, so we can get this fixed
before 4.17.

Thanks, Roger.

[0] https://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#spec-ctrl-x86


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:05:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:05:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426585.675115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTMH-0006bx-Fz; Thu, 20 Oct 2022 11:05:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426585.675115; Thu, 20 Oct 2022 11:05:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTMH-0006bq-Cw; Thu, 20 Oct 2022 11:05:05 +0000
Received: by outflank-mailman (input) for mailman id 426585;
 Thu, 20 Oct 2022 11:04:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olTLh-0006ab-Iy
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:04:29 +0000
Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com
 [2a00:1450:4864:20::42d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5ec8ec7-5066-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 13:04:27 +0200 (CEST)
Received: by mail-wr1-x42d.google.com with SMTP id b4so33740193wrs.1
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 04:04:26 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 b27-20020a05600c4a9b00b003c6b874a0dfsm2878294wmp.14.2022.10.20.04.04.23
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 04:04:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5ec8ec7-5066-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=JKgokySAbSDocqAoeooaDVOHdyffvNbsXeaqlsl0F6Q=;
        b=YuyG979IjH/omPZt2SGnYnru0cV909zoMvrCX3HL8PlAQdcIyioHPGUmIe8W7VRBSv
         d2WnsvRMEK9yG7HTRtQWCf9RmSq9IbNSIhnsLVc2PCjx2Gm680bspMWPyW1lTeBwXRuv
         xuMNES+nRwqUtt4PO6rfyf/9Fw2sP1qA7syP1NgiwDQTJlpmK2BMtT2+57Gcbs7vYsJn
         yYio/2h/fsm9Fc9mw9t+Z4mkyDsXkIDwdnDXlUWjvpl7NtagwnivDivGU9ObtDvXMLYa
         ZprzBgE8PHy04ffFEu2X2AHiYCKwPWAQQq8rs5rQHIAb2gFw+Pg6UZ6B9tqRap+rMoGj
         pGsA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=JKgokySAbSDocqAoeooaDVOHdyffvNbsXeaqlsl0F6Q=;
        b=wd4F7z0bhjOzVx2pmRv5bp3gkz28PJtLYe52IqaMS9JZJzz+NzIsWBoGWbWfFuvjZa
         i2FwOWcIvXPulMhrLK2J7Ld/B+nN0Hb6cSLmUnUVBtf1SGeFp4QaLL3FVU5km1M98i3X
         k4ZUXFXNPCG4mTtQcy0z8nqiXa9Mxo3dhoVAVKqOs6X2ZtPPHVn6IwaLeA3hXNu7x3A3
         yjWDs2Qdf722NaGr17c1UIol8NHnsSbi4qDEgEtMEFVHYOOMF1gFIrg12Cvkr0FOPCbz
         TY1CU5D4aUfdYvjA1eNkXqxNfXvK4TdEup1h7g/zQZHzE6VrHG788Qj7D/94QpxkA53e
         BiwQ==
X-Gm-Message-State: ACrzQf3tFFFXCsnwsMO4bscax9jCPpI/FBswpvU9ruDUW1SLQVtRlhoi
	V0mfDKZd+XMAXGWazkrrmQ25/w==
X-Google-Smtp-Source: AMsMyM6fAcbMc6B7n6thzH2AP9CJAGCgb2F1dro5nYnmNF/EItcvTfq7llVzApvdJ80okI4kHx48fQ==
X-Received: by 2002:a5d:6d0d:0:b0:230:1b65:a378 with SMTP id e13-20020a5d6d0d000000b002301b65a378mr8393523wrq.406.1666263865964;
        Thu, 20 Oct 2022 04:04:25 -0700 (PDT)
Message-ID: <644e55ec-1040-09ad-0d1b-1ac80b70b58c@linaro.org>
Date: Thu, 20 Oct 2022 13:04:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 12/17] net: dgram: add unix socket
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-13-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-13-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/10/22 11:16, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> QAPI schema
> Acked-by: Markus Armbruster <armbru@redhat.com>

Eventually:

   Acked-by: Markus Armbruster <armbru@redhat.com> (QAPI schema)

> ---
>   net/dgram.c     | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
>   qapi/net.json   |  2 +-
>   qemu-options.hx |  1 +
>   3 files changed, 55 insertions(+), 2 deletions(-)
> 
> diff --git a/net/dgram.c b/net/dgram.c
> index e581cc62f39f..02a189e36358 100644
> --- a/net/dgram.c
> +++ b/net/dgram.c
> @@ -426,6 +426,7 @@ int net_init_dgram(const Netdev *netdev, const char *name,
>       SocketAddress *remote, *local;
>       struct sockaddr *dest_addr;
>       struct sockaddr_in laddr_in, raddr_in;
> +    struct sockaddr_un laddr_un, raddr_un;
>       socklen_t dest_len;
>   
>       assert(netdev->type == NET_CLIENT_DRIVER_DGRAM);
> @@ -465,7 +466,7 @@ int net_init_dgram(const Netdev *netdev, const char *name,
>           }
>       } else {
>           if (local->type != SOCKET_ADDRESS_TYPE_FD) {
> -            error_setg(errp, "type=inet requires remote parameter");
> +            error_setg(errp, "type=inet or unix require remote parameter");

Maybe clearer reworded as:

   "type=inet or type=unix requires remote parameter"

>               return -1;
>           }
>       }



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:05:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:05:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426589.675127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTMi-00077L-Rs; Thu, 20 Oct 2022 11:05:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426589.675127; Thu, 20 Oct 2022 11:05:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTMi-00077D-N5; Thu, 20 Oct 2022 11:05:32 +0000
Received: by outflank-mailman (input) for mailman id 426589;
 Thu, 20 Oct 2022 11:05:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olTMh-00074M-Jq
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:05:31 +0000
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com
 [2a00:1450:4864:20::434])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c4b14fd-5067-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:05:30 +0200 (CEST)
Received: by mail-wr1-x434.google.com with SMTP id w18so33791525wro.7
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 04:05:30 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 s9-20020adfdb09000000b0022cc6b8df5esm2545875wri.7.2022.10.20.04.05.27
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 04:05:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c4b14fd-5067-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=k5OMfOF+gS3nVw6PJtVCPK8dnzLUIJZIwge4jOXVGaY=;
        b=Q3uI8GXwyKyIP/hJ8ICeZ90o8G5KP1HxNrbJKqV4bZijJ9NAYQLz5Has63oHv/UY0F
         TPgIPIu9gMaj0LwIjn47ASRYx/5Ijuz/woJVxhwg6Kk0WQSWfdrgWDFj+jE4nIaltvwZ
         F1PVBCaizepN29HktXcKcuUddH/DLLChsqmkQ+eF1PvRA6RAwKuifOo3bQ0ky3UF/j6P
         K/o4h+bgwux1xZNXunciRNvmAm0U5fD787zpFYclAugl4w00MRKQJ8+1z5NMFz6ebaX6
         8MYrphl+jyUh4Crsr53ot53E3wKsktc/hBqoUKtTQwEnN7U9CO64gShtDjrPnvXZrVVa
         Y7Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=k5OMfOF+gS3nVw6PJtVCPK8dnzLUIJZIwge4jOXVGaY=;
        b=vzjBaUesqRhQHt7gSx0GAgxyaq9ywP6h/6zlDteQ6PJwmA//clWi73OS8hYgUCka37
         QdURTSUe2K3SBeg/ixq7RoMz77nTcx328Y/9jJXx8fV33OzQBh010thRcxwUCgUtGD0g
         mpMMgwSBZCSGklSAwZql/xByP8mqqDn/ZM6GV4FoTVnaHtkLJFLu66TlLpN/566QIGNr
         E8B8fq0O/or6rhQ4qb/WsZmlXN6JbpXm1dBd0GHPl86befW6ttVyXIrhOqyvv4t6153E
         zBmt47UrAUVjD9rPbZdI1t//Jk9KrsLJdA5IUA1PHgOX2tZ6BAWdN1trFJU5tUReCA8z
         CShQ==
X-Gm-Message-State: ACrzQf2iXzcrWFIKFQbg4sYQqRa6jmfm7gtiON9MdBuAw1wEaXV0FYMo
	JPVK01JU/vlO0nsXqjKNB2PnNA==
X-Google-Smtp-Source: AMsMyM7gylTucNUFEga3J9dhpDrprY9hwVzIWXDjPCT/TC8wr/MH8Kg0yCzIyLZ5QQ9FJN6bsVX6Vg==
X-Received: by 2002:a05:6000:1565:b0:22f:1407:9bfd with SMTP id 5-20020a056000156500b0022f14079bfdmr8099685wrz.620.1666263930079;
        Thu, 20 Oct 2022 04:05:30 -0700 (PDT)
Message-ID: <86d3bbf2-375c-801c-1576-60eeddad6178@linaro.org>
Date: Thu, 20 Oct 2022 13:05:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional
 parameters
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-16-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-16-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/10/22 11:16, Laurent Vivier wrote:
> Use QIOChannel, QIOChannelSocket and QIONetListener.
> This allows net/stream to use all the available parameters provided by
> SocketAddress.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   meson           |   2 +-
>   net/stream.c    | 493 +++++++++++++++++-------------------------------
>   qemu-options.hx |   4 +-
>   3 files changed, 180 insertions(+), 319 deletions(-)
> 
> diff --git a/meson b/meson
> index 3a9b285a55b9..12f9f04ba0de 160000
> --- a/meson
> +++ b/meson
> @@ -1 +1 @@
> -Subproject commit 3a9b285a55b91b53b2acda987192274352ecb5be
> +Subproject commit 12f9f04ba0decfda425dbbf9a501084c153a2d18

Probably unrelated submodule update?


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:18:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:18:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426598.675138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTYh-0000Nl-U7; Thu, 20 Oct 2022 11:17:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426598.675138; Thu, 20 Oct 2022 11:17:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTYh-0000Ne-RC; Thu, 20 Oct 2022 11:17:55 +0000
Received: by outflank-mailman (input) for mailman id 426598;
 Thu, 20 Oct 2022 11:17:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olTYg-0000NY-Q7
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:17:54 +0000
Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com
 [2a00:1450:4864:20::334])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d2c9c332-5068-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:17:46 +0200 (CEST)
Received: by mail-wm1-x334.google.com with SMTP id
 fn7-20020a05600c688700b003b4fb113b86so1960891wmb.0
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 04:17:53 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 k33-20020a05600c1ca100b003c6cd82596esm2672545wms.43.2022.10.20.04.17.50
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 04:17:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2c9c332-5068-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=aji4vbaAsAZUvQBuxSvdAC7h4FHkKHnOC3DlhOWZEd0=;
        b=moo5qfDu/Ser6hNax3oFsOlv+Dpkmcdt1iwnOv9cljJVLF1IDg0B0DBVqK28e23eVn
         sabAfeMgV5d791gjcbb2ExVERO1ipRXCb2MvhDnDPFv9xy8kGiNy5cTYIWztDmzrj051
         6ImKulsnmgwr4JnCz3vJoI+YbEX7tA0sU3VI56Noq4n/Q679uoiR6SHTqapYGpJtW+3l
         DIx54ZuXspT0Mh6mpEdkdyjEwZZkNTDg7WJs64CgaiSfpnCXLOyQUbG3gW6iQYtsKqiZ
         d1YSwfwZcESrk5FeXn8vi3Bcv5Me7oDCtwNNfpzL6OtuaOtbXJAgvKkcf8L+zFSCGrMh
         WDNg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=aji4vbaAsAZUvQBuxSvdAC7h4FHkKHnOC3DlhOWZEd0=;
        b=ZKQP3IUq49oU21BHqAIGEBK/vRQpBvV3YvgQdEFyC91VZwQsZldfz1VeuHw+VVbXnw
         WfKPheGP8KFQ9E7PbmSzDCbwzHFWryEJSZ7dbGPTlz+zjVUcK5s7X1oLKkuj0HXVTq31
         PNWUA/dXV+7vls7D5/6yf+CUtzcQiOZz5lqecwD3Cr3OIvdH0C8kCSLcIEgFDyQkPWe6
         Uy3VK21l9cWvK/31Qr8ZBGb0JEaOB4BnyuSo/iOi7GaTco549iaXWORx/QGR12QKWjn8
         0LFcmtTd2xAxgM7NSdc7hYGvCp+z3QSvWH9n8fxxuBTJwfJzERlKsDH26jIvchIP493V
         ISog==
X-Gm-Message-State: ACrzQf1t+DqPE52oJ368brXJwE9rYHHJ/VfjnAEZa4hWQlHVntNbCk9/
	IDVF/Z1vTEiwyPni53THxGppwQ==
X-Google-Smtp-Source: AMsMyM5yjZYeFyMUFDsrwK9W8Au6afb9js5tIWn4HVsweRZFCfALDEiJuOLfDDfch4uFJFt/Dl8Q8Q==
X-Received: by 2002:a05:600c:34d4:b0:3c6:f695:b5f8 with SMTP id d20-20020a05600c34d400b003c6f695b5f8mr8951954wmq.203.1666264672833;
        Thu, 20 Oct 2022 04:17:52 -0700 (PDT)
Message-ID: <15217f04-d689-7579-1501-320761b2f6e7@linaro.org>
Date: Thu, 20 Oct 2022 13:17:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 10/17] net: dgram: make dgram_dst generic
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-11-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-11-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 20/10/22 11:16, Laurent Vivier wrote:
> dgram_dst is a sockaddr_in structure. To be able to use it with
> unix socket, use a pointer to a generic sockaddr structure.
> 
> Rename it dest_addr, and store socket length in dest_len.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   net/dgram.c | 82 ++++++++++++++++++++++++++++++++++-------------------
>   1 file changed, 53 insertions(+), 29 deletions(-)

>   static NetClientInfo net_dgram_socket_info = {
> @@ -260,7 +263,7 @@ static NetDgramState *net_dgram_fd_init(NetClientState *peer,
>                                           SocketAddress *mcast,
>                                           Error **errp)
>   {
> -    struct sockaddr_in saddr;
> +    struct sockaddr_in *saddr = NULL;

Preferrably g_autofree.

>       int newfd;
>       NetClientState *nc;
>       NetDgramState *s;
> @@ -275,31 +278,32 @@ static NetDgramState *net_dgram_fd_init(NetClientState *peer,
>       qapi_free_SocketAddress(sa);
>   
>       /*
> -     * fd passed: multicast: "learn" dgram_dst address from bound address and
> +     * fd passed: multicast: "learn" dest_addr address from bound address and
>        * save it. Because this may be "shared" socket from a "master" process,
>        * datagrams would be recv() by ONLY ONE process: we must "clone" this
>        * dgram socket --jjo
>        */
>   
>       if (is_fd && mcast != NULL) {
> -            if (convert_host_port(&saddr, mcast->u.inet.host,
> -                                  mcast->u.inet.port, errp) < 0) {
> +            saddr = g_new(struct sockaddr_in, 1);
> +
> +            if (convert_host_port(saddr, mcast->u.inet.host, mcast->u.inet.port,
> +                                  errp) < 0) {
>                   goto err;
>               }
>               /* must be bound */
> -            if (saddr.sin_addr.s_addr == 0) {
> +            if (saddr->sin_addr.s_addr == 0) {
>                   error_setg(errp, "can't setup multicast destination address");
>                   goto err;
>               }
>               /* clone dgram socket */
> -            newfd = net_dgram_mcast_create(&saddr, NULL, errp);
> +            newfd = net_dgram_mcast_create(saddr, NULL, errp);
>               if (newfd < 0) {
>                   goto err;
>               }
>               /* clone newfd to fd, close newfd */
>               dup2(newfd, fd);
>               close(newfd);
> -
>       }
>   
>       nc = qemu_new_net_client(&net_dgram_socket_info, peer, model, name);
> @@ -311,21 +315,20 @@ static NetDgramState *net_dgram_fd_init(NetClientState *peer,
>       net_dgram_read_poll(s, true);
>   
>       /* mcast: save bound address as dst */
> -    if (is_fd && mcast != NULL) {
> -        s->dgram_dst = saddr;
> +    if (saddr) {
> +        g_assert(s->dest_addr == NULL);
> +        s->dest_addr = (struct sockaddr *)saddr;
> +        s->dest_len = sizeof(*saddr);
>           qemu_set_info_str(nc, "fd=%d (cloned mcast=%s:%d)", fd,
> -                          inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port));
> +                          inet_ntoa(saddr->sin_addr), ntohs(saddr->sin_port));
>       } else {
> -        if (sa_type == SOCKET_ADDRESS_TYPE_UNIX) {
> -            s->dgram_dst.sin_family = AF_UNIX;
> -        }
> -
>           qemu_set_info_str(nc, "fd=%d %s", fd, SocketAddressType_str(sa_type));
>       }
>   
>       return s;
>   
>   err:
> +    g_free(saddr);
>       closesocket(fd);
>       return NULL;
>   }
> @@ -339,21 +342,24 @@ static int net_dgram_mcast_init(NetClientState *peer,
>   {
>       NetDgramState *s;
>       int fd, ret;
> -    struct sockaddr_in saddr;
> +    struct sockaddr_in *saddr;

Preferrably:

   g_autofree struct sockaddr_in *saddr = NULL.

>   
>       if (remote->type != SOCKET_ADDRESS_TYPE_INET) {
>           error_setg(errp, "multicast only support inet type");
>           return -1;
>       }
>   
> -    if (convert_host_port(&saddr, remote->u.inet.host, remote->u.inet.port,
> +    saddr = g_new(struct sockaddr_in, 1);
> +    if (convert_host_port(saddr, remote->u.inet.host, remote->u.inet.port,
>                             errp) < 0) {
> +        g_free(saddr);
>           return -1;
>       }
>   
>       if (!local) {
> -        fd = net_dgram_mcast_create(&saddr, NULL, errp);
> +        fd = net_dgram_mcast_create(saddr, NULL, errp);
>           if (fd < 0) {
> +            g_free(saddr);
>               return -1;
>           }
>       } else {
> @@ -362,13 +368,15 @@ static int net_dgram_mcast_init(NetClientState *peer,
>               struct in_addr localaddr;
>   
>               if (inet_aton(local->u.inet.host, &localaddr) == 0) {
> +                g_free(saddr);
>                   error_setg(errp, "localaddr '%s' is not a valid IPv4 address",
>                              local->u.inet.host);
>                   return -1;
>               }
>   
> -            fd = net_dgram_mcast_create(&saddr, &localaddr, errp);
> +            fd = net_dgram_mcast_create(saddr, &localaddr, errp);
>               if (fd < 0) {
> +                g_free(saddr);
>                   return -1;
>               }
>               break;
> @@ -376,16 +384,19 @@ static int net_dgram_mcast_init(NetClientState *peer,
>           case SOCKET_ADDRESS_TYPE_FD:
>               fd = monitor_fd_param(monitor_cur(), local->u.fd.str, errp);
>               if (fd == -1) {
> +                g_free(saddr);
>                   return -1;
>               }
>               ret = qemu_socket_try_set_nonblock(fd);
>               if (ret < 0) {
> +                g_free(saddr);
>                   error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
>                                    name, fd);
>                   return -1;
>               }
>               break;
>           default:
> +            g_free(saddr);
>               error_setg(errp, "only support inet or fd type for local");
>               return -1;
>           }
> @@ -395,13 +406,17 @@ static int net_dgram_mcast_init(NetClientState *peer,
>                             local->type == SOCKET_ADDRESS_TYPE_FD,
>                             remote, errp);
>       if (!s) {
> +        g_free(saddr);
>           return -1;
>       }
>   
> -    s->dgram_dst = saddr;
> +    g_assert(s->dest_addr == NULL);
> +    s->dest_addr = (struct sockaddr *)saddr;
> +    s->dest_len = sizeof(*saddr);
> +
> +    qemu_set_info_str(&s->nc, "mcast=%s:%d", inet_ntoa(saddr->sin_addr),
> +                      ntohs(saddr->sin_port));
>   
> -    qemu_set_info_str(&s->nc, "mcast=%s:%d", inet_ntoa(saddr.sin_addr),
> -                      ntohs(saddr.sin_port));
>       return 0;
>   
>   }
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:20:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:20:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426604.675149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTbM-0001k8-Bm; Thu, 20 Oct 2022 11:20:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426604.675149; Thu, 20 Oct 2022 11:20:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTbM-0001k1-8h; Thu, 20 Oct 2022 11:20:40 +0000
Received: by outflank-mailman (input) for mailman id 426604;
 Thu, 20 Oct 2022 11:20:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olTbK-0001jt-Lj
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:20:38 +0000
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com
 [2a00:1450:4864:20::32a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 341cb733-5069-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:20:29 +0200 (CEST)
Received: by mail-wm1-x32a.google.com with SMTP id
 l14-20020a05600c1d0e00b003c6ecc94285so2202000wms.1
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 04:20:36 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 t67-20020a1c4646000000b003b505d26776sm2545599wma.5.2022.10.20.04.20.33
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 04:20:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 341cb733-5069-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=9AKfW1OUl6IVvhKHx6nJlHKq3zd67ntMW1dov1zxRho=;
        b=FMotvRwwEiFz1GxmIERePaKPM5upqrmqPcTullTf9hS3/aU7g5iTHQHJIL+w65Y86g
         j21yM8XI2m7gv3PjNalhgUmf9CB6HpkOZa+odEipHSB/5A7LR7yJ2SzmWasAXpQMqM3X
         P5CIVcRmoOTJscvptAjsXltXMnMihamN0mBL/y9NcBKh6GOIyZpFzgIhA5/zvPbjRpfS
         hc24RWM7MPJzROqC1WqVpZE7amibHvx294sFNuhJ2b7lLAnD4pZosvw2LVUsybAdR96u
         jYXiSX7FRizBydH9ocMQQenJCuH5FidZAFMZrZF6tg1EtqCyvmnLkU+eMiHAWUO867cs
         BwMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=9AKfW1OUl6IVvhKHx6nJlHKq3zd67ntMW1dov1zxRho=;
        b=4KPb71QbEo9xhY0oLv4RLKXgddBy8LOsGWKJXN4gPqhetK6UYM1mYmWZNG53ELRBnw
         vDAJ4v6KijHEChDX19j1kZtO7R212Z7FmRvwBik0osSFC0B4gVLteUo6366Ejo9FyXOk
         EMRBbrxgvjNqhaGmr2SQPeBoifwE74gu5xx9k8XmgXWNJGy5ye1izQk3B1H7s1DkLOU9
         IgvV+4kZpptBs2Dfo+nAoKeuShB1lP3HPQU6sPKTZeVhA8R2Je6DqAspjlEcRBGRwzZ1
         zrS5IInwmoRFM2vRTKF4ZiEzQ1rL9DvevBkHnva6SGxblt7rq3sjHb0JY/2x5AqWYdyL
         R7vQ==
X-Gm-Message-State: ACrzQf3LDOiqgagoBy+EDNWPmPxmxN0Ot6o/mOZ5S1ISPoeskjLx1VSo
	uLSTxlorfcbDZ8n0Pb21mW+vSg==
X-Google-Smtp-Source: AMsMyM4QDDxP5/5Q9nlSXHAonkPSNRZL2wP8LdhUoluTBCjES4Xd2hEjKZvm/R4uC3EI9C5UphPzrA==
X-Received: by 2002:a05:600c:1906:b0:3c6:db8a:2178 with SMTP id j6-20020a05600c190600b003c6db8a2178mr27121822wmq.7.1666264836321;
        Thu, 20 Oct 2022 04:20:36 -0700 (PDT)
Message-ID: <50b6debc-97e1-b827-098b-aa34f772e685@linaro.org>
Date: Thu, 20 Oct 2022 13:20:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 17/17] net: stream: add QAPI events to report
 connection state
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-18-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-18-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/10/22 11:16, Laurent Vivier wrote:
> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
> 
> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
> address.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   net/stream.c  | 11 +++++++++--
>   qapi/net.json | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 55 insertions(+), 2 deletions(-)
> 
> diff --git a/net/stream.c b/net/stream.c
> index 95d6b910407d..8ad757cefbdf 100644
> --- a/net/stream.c
> +++ b/net/stream.c
> @@ -38,6 +38,7 @@
>   #include "io/channel.h"
>   #include "io/channel-socket.h"
>   #include "io/net-listener.h"
> +#include "qapi/qapi-events-net.h"
>   
>   typedef struct NetStreamState {
>       NetClientState nc;
> @@ -168,6 +169,8 @@ static gboolean net_stream_send(QIOChannel *ioc,
>           s->nc.link_down = true;
>           qemu_set_info_str(&s->nc, "");
>   
> +        qapi_event_send_netdev_stream_disconnected(s->nc.name);
> +
>           return G_SOURCE_REMOVE;
>       }
>       buf = buf1;
> @@ -243,9 +246,10 @@ static void net_stream_listen(QIONetListener *listener,
>       g_assert(addr != NULL);
>       uri = socket_uri(addr);
>       qemu_set_info_str(&s->nc, uri);
> -    g_free(uri);
>       qapi_free_SocketAddress(addr);
>   
> +    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
> +    g_free(uri);

Maybe worth converting to g_autofree.

>   }
>   
>   static void net_stream_server_listening(QIOTask *task, gpointer opaque)
> @@ -317,12 +321,12 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>       g_assert(addr != NULL);
>       uri = socket_uri(addr);
>       qemu_set_info_str(&s->nc, uri);
> -    g_free(uri);
>   
>       ret = qemu_socket_try_set_nonblock(sioc->fd);
>       if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
>           qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
>                             addr->u.fd.str, -ret);
> +        g_free(uri);
>           qapi_free_SocketAddress(addr);
>           goto error;
>       }
> @@ -338,6 +342,9 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>                                               s, NULL);
>       s->nc.link_down = false;
>   
> +    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
> +    g_free(uri);
> +
>       return;
>   error:
>       object_unref(OBJECT(s->ioc));
> diff --git a/qapi/net.json b/qapi/net.json
> index 39388b1b6c41..569ab7fd37e3 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -895,3 +895,49 @@
>   ##
>   { 'event': 'FAILOVER_NEGOTIATED',
>     'data': {'device-id': 'str'} }
> +
> +##
> +# @NETDEV_STREAM_CONNECTED:
> +#
> +# Emitted when the netdev stream backend is connected
> +#
> +# @netdev-id: QEMU netdev id that is connected
> +# @uri: The Uniform Resource Identifier identifying the destination address
> +#
> +# Since: 7.2
> +#
> +# Example:
> +#
> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
> +#      'data': {'uri': 'tcp:::1:1234', 'netdev-id': 'netdev0'},

Unrelated, but interesting. The URI should be 'tcp:[::1]:1234', we miss
this IPv6 case when parsing SOCKET_ADDRESS_TYPE_INET in socket_uri().

> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
> +#
> +# or
> +#
> +# <- { 'event': 'NETDEV_STREAM_CONNECTED',
> +#      'data': {'uri': ''unix:/tmp/qemu0', 'netdev-id': 'netdev0'},
> +#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
> +#
> +##
> +{ 'event': 'NETDEV_STREAM_CONNECTED',
> +  'data': { 'netdev-id': 'str',
> +            'uri': 'str' } }
> +
> +##
> +# @NETDEV_STREAM_DISCONNECTED:
> +#
> +# Emitted when the netdev stream backend is disconnected
> +#
> +# @netdev-id: QEMU netdev id that is disconnected
> +#
> +# Since: 7.2
> +#
> +# Example:
> +#
> +# <- { 'event': 'NETDEV_STREAM_DISCONNECTED',
> +#      'data': {'netdev-id': 'netdev0'},
> +#      'timestamp': {'seconds': 1663330937, 'microseconds': 526695} }
> +#
> +##
> +{ 'event': 'NETDEV_STREAM_DISCONNECTED',
> +  'data': { 'netdev-id': 'str' } }



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:22:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:22:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426611.675160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTd3-0002Ok-RY; Thu, 20 Oct 2022 11:22:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426611.675160; Thu, 20 Oct 2022 11:22:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTd3-0002Od-OS; Thu, 20 Oct 2022 11:22:25 +0000
Received: by outflank-mailman (input) for mailman id 426611;
 Thu, 20 Oct 2022 11:22:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VPXW=2V=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1olTd3-0002OX-9l
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:22:25 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2046.outbound.protection.outlook.com [40.107.103.46])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 78393b02-5069-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 13:22:24 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB8PR04MB7020.eurprd04.prod.outlook.com (2603:10a6:10:126::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 11:22:22 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 11:22:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78393b02-5069-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O20KOlbyPRwfySBklhLspJls//aZTO0OqOyW8tV08c3hZQpI+hZnOc3C9YrV81Hsr05LLUsPJEc4uAHBx9Xw+nGNVyqxJ0hCEAZibw7a3lgd44O4Fx5ADp4s8TZCCS0N+iwVBM33MqJt62lmTIREirWc68dT6n/Zzdl1/KkbToetTfs1AsDXE4DLwRRmTzj/dfoNfkZGkuFqdskrjph9EttQdBPkQ9VEIIT5KIgAf7baQFGuxfOVSZH4bK0+R3Qn35IyEsy5r3WhTNPj8RWe8ATeEWamyoiSFkQ3supcfGPiPnU9reQHbynyDi6gfDjt1HE6FZ0j8FSXu9LD2oeuXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SzHEfeN0eWADFmzOSEdVxajkOuBplALvwDC3lhdlDe8=;
 b=Ri6tS93IhKJKeKFNDaDvI6gYAaan761rpYbVOwyMnpvp78p+MJf8DS+oyW6FIymbSgTweWf4pC3dyINIoHNRse2ndPbqrzj2+O5iSjRxe3yw7kXCXBL4ZbBZ3rlwdFrcdsh1B9IWrotpWn0NVzR1Yx5JAHJxFcKXTAt5m6yKresJIoO53OC0TkHJYveZvOj6PoMPR73BKXE5ujw48oueJeP3J/Tj9GwtVSIqNVGofa2fWQePcQbEx1nVs/5bwMjlNKUJpDOFPusDmu1yOQMCbidltST8+UiAVl0oY33G2NM4kN3CTTAKKLv+PE4qPWDMGIGSj9ph/qQjyRL1Y9gEWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SzHEfeN0eWADFmzOSEdVxajkOuBplALvwDC3lhdlDe8=;
 b=ZuLbmrA5PC7hm2B/8IqAP71dx4E+VpZtgv/ci1gTRMicLBTqgvFahvFGu8CbL+6/n8R1FoeRBj4VriBTKAhuYsZmOVeKUYKCKVIu4x/lxEAR+VZ90qVBlNVrJ9UQeRxZ/mCNWIjYgwKYHsQtLZ4gKHVuTjo7p5FAyjjcL4ot5vzALPOes/otniDERpFZtXQqdwluUnOYRJe52HvBB4S/KxLOdXFXlhp0uXtifRMZGbwT7wilfXG8uaTYJ7dvJT3kmmNHXGvXwUwbS2TSKQeiFDkVWdyYmgK2AxrV1/Q0KdwQeZdgzqiMV9WIEAQwGyqC5DpN2SPFuGHYlAvu2NJzYw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2f5ec31e-2ac5-2b22-8801-9ebdc4946962@suse.com>
Date: Thu, 20 Oct 2022 13:22:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Intended behavior/usage of SSBD setting
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:95::8) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7020:EE_
X-MS-Office365-Filtering-Correlation-Id: e3da713e-cce5-459f-10c7-08dab28d5b75
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1hLFkxzTqNWUcx7K4BMITx5kVEE1Ap6p2YWphvcWXjIt42qYD7LyFj3S881RxBpDLmZPkb3vS+fZ3Vgb3L7UI2FlGc6L8EN0NwXAXbPfcVFsUvoNk3s+1hw/CvgbBmVdyZjidGwc3JN8czBPxRTRecXNnYrXq4bWvk/1FseYmhUThmWkZQLmjVkQq10QPscK56XGjygJDhi+h/VI7UkcEAi25e/ZQheq8Gv7FDSHRCe+8kg9SAYmuqncH8Bpe44v6ZAYsPrkYwTnBA9v6v/5E9whPfINGa1/baH9yaV2hXgF58GKLXlyXiYDpR8dJ1+FA4A3SPEjEgS4GZGhxA9wtl1mXwcXtpbU2lvCNyZwTnnVec3J8zVC+tJQP/Q/tHAXEyza/lmiIdb095z2n5IhAMbp2pbarBZzX5CQKw17Ay2s+4wj3YVHskvtotiCfLrfdCrwmaGYJdqPh/aY6jU+W6qgXGFYxXhMb0xpJg31ebsf0M9EK/676p7qxOrGrK9xSM7CjtP2+Wzuo3EyZPPBCN+ZEQnqJKtFwZnjgOE2FJpJPjKNENLwNWHZFG8DUOX2KzCG3SFH7IBLQMPPIV4goiif806uIPVYSpZ+MWB8J4Ll1u+FtceD/90Q/Dl/8quHoTe4q6I7dgYTOKU1yjUGgUhBTux4iD+c0NUGTVubJ8L5salf08E/zwJRJerCTksL9HxORFWPSZJ+NdAowzdLcoj/6J/Ah9v7d8qlr7M5T6ici02LE3xl5DV6Du8Qy6IaLSYDs0InGF73xXZ+kju88CGCeospj0HaRyhmpd2nmqo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199015)(36756003)(83380400001)(2616005)(31696002)(86362001)(186003)(38100700002)(8936002)(31686004)(66899015)(6916009)(4326008)(5660300002)(66476007)(66946007)(316002)(41300700001)(478600001)(66556008)(8676002)(6512007)(26005)(6506007)(6486002)(53546011)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SE1TMXZTbnV4YkhkNFY2MTY2UWsrejBMcDBGU3JCTUNWWEdMQ0hIK1hCNnFy?=
 =?utf-8?B?VU42MXUvQXI3VGhOejY1SHRBcGlUUkoyNEYzTVRjT0U1d0lTOEZJZlpvOGpP?=
 =?utf-8?B?ckdnMzdTNUVzTm5ZTVFESXh2ZHZoZzM4SmFRMk5XVTlnVFZkM1FmZ3NWbldV?=
 =?utf-8?B?NkJqY2EvY3YwM0Q1RzNuOWgxdDE4cmV6eHoxWHd2WFNkL205TzB1NVJFODRx?=
 =?utf-8?B?MmVVdVgzV2VJTzFML1orRGI5djcwT0xSMmlubkFXV0FWbGFDVlZGYkhQVlN0?=
 =?utf-8?B?L3Z1bktqdlFKdDUxZnFPTDJobHpveXZhd3MxQlBLTWZqT1dqaWRNY0dIZVl0?=
 =?utf-8?B?TjdMTVNjdUV1V2hTY1lUaFZQOUQrVVBNb3dUMHhmcXl5YUdBSUlzQ3BhMHQ5?=
 =?utf-8?B?dDc4emdENWFQSjBZQWE4aG9Gb3UwNit2ZWlHcnpJNzBBRXFvNFN2My9ySlE5?=
 =?utf-8?B?QWlRenNvMHV2MmFCUEMydnBOdTB5VFVsSFgycE9kU1JhTjFCYWtlakpCbm5j?=
 =?utf-8?B?aFYxUFUySTNiNHY3d1UrVXpkUHFqVlZlQXB4b3c0R0lld09LY3IrKzFYSUha?=
 =?utf-8?B?eUQ5azM1M2J2WklVeVQyR2dGK0czcHI1VC9BbmxKUklqc2YvMzdzSmtZcjZU?=
 =?utf-8?B?R0VWd0FxUGVSdWRYWThtM2lpMnRwbVJHTlVvNCtGd1Q3SlNOc0ZGVzdCWFJ1?=
 =?utf-8?B?eVdlMTU0cmxHTUlYeEY1Ty9oVVR1Slp0aXc2V3pRbmhaOXM2QkhiYUc3eU1a?=
 =?utf-8?B?WFI5R3psWHEvdkRsQi9yRWdyN0t1UytvamtnKzRLQ0MwZlRYcDVUMEJDUHRD?=
 =?utf-8?B?VTM4eHZVU21XeE9SQzNBZHlqN2U1TzY1bG9lUjhLbWtOUnR1Q09tMnh1OVVy?=
 =?utf-8?B?c1ZnYkdkajB1bFNDK0tiWUk3MjhLNk8rblhJRWRXKzJMS1JFVFp6b1Uzenpr?=
 =?utf-8?B?d0U5MDlBelY4d1kwVGExKzEzTVVhK3dGbWVDR01FMERXWmkxNXIxbFhpOUlZ?=
 =?utf-8?B?OEl6OUVtdmZOUk0wbmh6b05PRkVhTGdCTXNhZDVTWWxkanYyMnFPY0lKMmxL?=
 =?utf-8?B?L1FFdkxxdCtEYkRaNm0zanZkSjcvR1BhdnBocDEyYkw3VEFvQzJUeWdJcUY1?=
 =?utf-8?B?SUFhWW5vR08yVlRORlVNZ0NQT2QvSnQ2cGlPbExXd1pBRGtkYTNlbklSbGFR?=
 =?utf-8?B?V3JIRmxFQWZQVTR0TzQ2NkxFS002eUE4UmhuUjBrV0pwRUlGV0xkRW4zM01i?=
 =?utf-8?B?NTkwUVRpWFdid3psblRKTWJrRXRoM1orVHpIY0FwN0tDZjRqUHR6SEFDc29F?=
 =?utf-8?B?UjB6WVpkUHYrMGpYT2VXL3FNeTFhZDNXMjFJUGwvU0FPV0VFak9pQWU5WW9X?=
 =?utf-8?B?RHZnanlwbkY5ZVQwTStkVzBWUmpzdStlZnUvTjF6aW5HNE1ma1ovV1p1OG1V?=
 =?utf-8?B?anVkYktOQnVzVGdNN3F1c0pBWHVBNEpsMnErQzZ2amFPNUxaVGxwcWxyaG9F?=
 =?utf-8?B?RUtld25YdUhxVkFjMHJ2blRRUmttQTN2WHdaTnp3Nk1XV3hFT3gxZ3ArdFRP?=
 =?utf-8?B?VjI5b21aNExUQnRQS2ZCQWwrR05HZVRHM0FFQjVTZW9WTjlqMHpvZTVrOWJk?=
 =?utf-8?B?NldqdjN0NVBwTWFqQ1U5SFd6Tjd2OEtFdWJTL25xTEZmVzAzSXhteDNDZFlR?=
 =?utf-8?B?Mkxjb1BTdDJ0c2lpRlA1SXc1V0RqclI1OERVQTRXQTlqQVNldnU2NUw1SlAw?=
 =?utf-8?B?OExzNHNKOExrSUdwbnEzTXlDM0QxekhRVmlDR256YXZCS256Zk11Mm03MGhs?=
 =?utf-8?B?R1FpWi9Lek9VR0pwakpCSytzSlpJYTJ3azhXZTEveG1NMmVRMXc4Mm9NTTlL?=
 =?utf-8?B?QXBtTlFlN3U4Q1Y1Vm5Ja3hVb1NjUnk4ZVc5RmhlVG5Pc0xDVWJyaFVWeUNq?=
 =?utf-8?B?cEhjUzdhaWZxcVY4bU0wTzdIVTdncVVVdEJPajJYdzR6MmNud0N0azVvRWVk?=
 =?utf-8?B?WVJqblVZMjJCVHJYdU0wd2VoZE84Rmo3SE11ZVFST3lpNlVEY0VxTWNtRUtF?=
 =?utf-8?B?enlmOStUUTJodVYzc0lML3JsdzFEY3g5K0wvYTJ4dXlreXhkMkE1K2kyLytZ?=
 =?utf-8?Q?4JIeL9YjgGRDZjprwl75mNAQF?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3da713e-cce5-459f-10c7-08dab28d5b75
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 11:22:22.2127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EujMuxE7uhWY+AH9J4OmzrGVWuc9BrFt69BmsZ5sfPBQz/0l120oMmgKB7phh2bUHK68XpvZvW8PyJB3sHP6Cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7020

On 20.10.2022 13:01, Roger Pau Monné wrote:
> Hello,
> 
> As part of some follow up improvements to my VIRT_SPEC_CTRL series we
> have been discussing what the usage of SSBD should be for the
> hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
> that has an out of date description, as now SSBD is always offered to
> guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
> 
> It has been pointed out by Andrew that toggling SSBD on AMD using
> VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
> have a high impact on performance, and hence switching it on every
> guest <-> hypervisor context switch is likely a very high
> performance penalty.
> 
> It's been suggested that it could be more appropriate to run Xen with
> the guest SSBD selection on those systems, however that clashes with
> the current intent of the `spec-ctrl=ssbd` option.
> 
> I hope I have captured the expressed opinions correctly in the text
> above.
> 
> I see two ways to solve this:
> 
>  * Keep the current logic for switching SSBD on guest <-> hypervisor
>    context switch, but only use it if `spec-ctrl=ssbd` is set on the
>    command line.
> 
>  * Remove the logic for switching SSBD on guest <-> hypervisor context
>    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
>    hypervisor code with the guest selection of SSBD.

* Give the guest the illusion of controlling the behavior, but run with
  SSBD always enabled when "spec-ctrl=ssbd" is in effect.

* Give the guest the illusion of controlling the behavior when
  "spec-ctrl=ssbd" is in effect, running with the OR of guest and host
  settings (switched, if necessary, as vCPU-s are context-switched).

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:22:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426615.675171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTdV-0002ru-4G; Thu, 20 Oct 2022 11:22:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426615.675171; Thu, 20 Oct 2022 11:22:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTdV-0002rn-1E; Thu, 20 Oct 2022 11:22:53 +0000
Received: by outflank-mailman (input) for mailman id 426615;
 Thu, 20 Oct 2022 11:22:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olTdU-0002na-8v
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:22:52 +0000
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com
 [2a00:1450:4864:20::432])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 84135581-5069-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:22:44 +0200 (CEST)
Received: by mail-wr1-x432.google.com with SMTP id bk15so33830865wrb.13
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 04:22:50 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 f6-20020a05600c490600b003b95ed78275sm2415551wmp.20.2022.10.20.04.22.47
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 04:22:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84135581-5069-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=qeLuBqMrrf60ddrQS5kIMB1G0KMo/uMw/93o5j0BRbA=;
        b=EvhqqP0tsA+OhGXdbX1aSkmkLTgJ021o+8X8kgefgH7W3nnfKs1DEBShJ5+jx6QUbX
         w2FwrZb41vzWKi1pO9meI2F1joVbXKYR4sy+U21In4HCPtCFFqQzpfQQBzR4t+Gmp9/6
         yf2+UHMJXGvCAyNZfhUXNo1SVgtB8nDrZh6C8ipgBtXCSS1hCUu2KakLHjXkgb0oFYol
         VrPOUBo+YxCWuAMDq+IRpM0u6EjYYezdI1SE0ko4YhmRHYfK8Zr9pXuB0Gp6Z9+ISHJ5
         sgFs0vnttL8Hi1uwWjqu0LU0P919ckabIc/ocX96esOzyFtKk0q9Ix8wOSLyZgFC8HEK
         RjBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=qeLuBqMrrf60ddrQS5kIMB1G0KMo/uMw/93o5j0BRbA=;
        b=r5uqAjMDKM3fxA+vNrwmTl9SUToexGuTx8TaOBsT2QU+mVbdROZc2vqhjNx+HvJiI5
         g+SBYj2R2aX5Iu7tcMSBJmw9gPXYxRTqvK6MU3dmzqDyzsi3k+xgmPPXVrlkjrGZ6gea
         552VcLM+Q+GBs0oBDNFdXDf/erFUTbULjxz13F14JS7SMOdcjxQim8ZHyzg9zysoCYTt
         WOzfEJho4xVmk0iNMOQFBIDbDcxMimbrumuMKnSYQKu2yjf0ZnfR/dYOn+/Jx6pndGaI
         KB+HrFAqOhfJFlLL4yJciJHL+3zNRFaMEKWz+ZfXw4Ri2Xhj3yUFmo70GRtJPnNf8Uja
         5e8A==
X-Gm-Message-State: ACrzQf1ADrcii+KAeuoeOt62s3u7erUpFlbv3wfaYEHGnqQAD9mLIJ+z
	q8MzUMtpeDHegdoV4GBxuybWsw==
X-Google-Smtp-Source: AMsMyM40ThoQBavxHAlcW+lg4vJY0hKffuLqNqY4Acfc6gQvEbuZViG8MbqPa2YA3YkDkaON6sn1Qg==
X-Received: by 2002:adf:dd0f:0:b0:236:2f7f:4cce with SMTP id a15-20020adfdd0f000000b002362f7f4ccemr1256849wrm.347.1666264970374;
        Thu, 20 Oct 2022 04:22:50 -0700 (PDT)
Message-ID: <3e6d8138-ad6e-9e23-ebc0-f3e4d5afebe1@linaro.org>
Date: Thu, 20 Oct 2022 13:22:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 05/17] net: introduce qemu_set_info_str() function
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-6-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-6-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 20/10/22 11:16, Laurent Vivier wrote:
> Embed the setting of info_str in a function.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   hw/net/xen_nic.c  |  5 ++---
>   include/net/net.h |  1 +
>   net/l2tpv3.c      |  3 +--
>   net/net.c         | 17 ++++++++++++-----
>   net/slirp.c       |  5 ++---
>   net/socket.c      | 33 ++++++++++++++-------------------
>   net/tap-win32.c   |  3 +--
>   net/tap.c         | 13 +++++--------
>   net/vde.c         |  3 +--
>   net/vhost-user.c  |  3 +--
>   net/vhost-vdpa.c  |  2 +-
>   11 files changed, 41 insertions(+), 47 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:29:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:29:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426623.675182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTk9-0003fg-RZ; Thu, 20 Oct 2022 11:29:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426623.675182; Thu, 20 Oct 2022 11:29:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTk9-0003fZ-Nc; Thu, 20 Oct 2022 11:29:45 +0000
Received: by outflank-mailman (input) for mailman id 426623;
 Thu, 20 Oct 2022 11:29:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olTk8-0003fT-NQ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:29:44 +0000
Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com
 [2a00:1450:4864:20::32b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7e41d256-506a-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 13:29:43 +0200 (CEST)
Received: by mail-wm1-x32b.google.com with SMTP id
 az22-20020a05600c601600b003c6b72797fdso1937525wmb.5
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 04:29:43 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 g7-20020a05600c310700b003b47b80cec3sm2785009wmo.42.2022.10.20.04.29.40
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 04:29:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e41d256-506a-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=Etn0iO4RaXjrrYAkCfqyH7NEpJhpaiQUoe/1LWlrvsk=;
        b=jgfqFJJA76hBb4Id76/FzlxQzhZxxDZHa/QokD907BllT473Y3XtB0P3wjlP8aRAjs
         A/vImCjO27LjnyjGVqISCkap3TTwwuTXs5yhGvHpTgJLBZNMBXpOAtfltu2/+hcw6/1I
         xAjjnkdZ+8HV9XT75WTa9V72ev87ToTseul173SsfyrvFZrlhKjY3cLigHEOaJ2BSaE9
         ptMKZxlSb1TTkfX8RNWPh0vHuNkQHkhmPovhsuivHoUtfJtu0sEEGm8sF7EvV4i+kDCM
         raaTT/wlNVSLk97Ua0KPfLgLDwwNttcaq0kdF61dFW6Zja5hZ0eFkFBilt0dkA6uBQDb
         U+/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Etn0iO4RaXjrrYAkCfqyH7NEpJhpaiQUoe/1LWlrvsk=;
        b=YG49p93xVZAPeaFszyXJEDYoAnXqQeA1U2u8iLGfEr/tbNPAmNnESlqwz/Ib2xfOq9
         Z+NRh+Blr0/m6l7c6bOpiKAxL2lI4AvB732TY4bG4X1LyqhEs/olfCg0Q5pUyFTh2XOg
         BKwtAjRyshTMiuNtD3Whx7tmnVLQ+Nvl65zmn+iQCLLwD28YW4wSSS4hAYqtGC58mztH
         mjfM3nUcUbd8kqgeRlxBNJFEUR4QlEQv2eUqu7paTAlW6k4emppq5gC4YvZkonot6Cy5
         wmQPGZe0hs6aSETk8OJwWmJjuodthMMt+/NHwPXSzksqhswW4CYDtq8ZbkrkTMoZ4TT9
         L5oQ==
X-Gm-Message-State: ACrzQf0CqsfG0d8rO4PhPO+QBZcbBSpAXPhzJhqK46oVlawRbFWsP3WT
	1IvLcqNKJpWIH2UpaWzloLDG2g==
X-Google-Smtp-Source: AMsMyM4ij4BZ7TpeNLVFqunzyg4LLe78a5Dj/HqR1xaY4sjaEQmUcFv30JhQ5Lbs/FiYrzwUlIcU4A==
X-Received: by 2002:a7b:cbce:0:b0:3c6:fb29:6084 with SMTP id n14-20020a7bcbce000000b003c6fb296084mr12340370wmi.131.1666265382916;
        Thu, 20 Oct 2022 04:29:42 -0700 (PDT)
Message-ID: <bec2996a-3ea1-4245-64b6-ff53f9094cbf@linaro.org>
Date: Thu, 20 Oct 2022 13:29:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 09/17] net: stream: add unix socket
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-10-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-10-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 20/10/22 11:16, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> QAPI schema
> Acked-by: Markus Armbruster <armbru@redhat.com>

Eventually:

   Acked-by: Markus Armbruster <armbru@redhat.com> (QAPI schema)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> ---
>   net/stream.c    | 107 +++++++++++++++++++++++++++++++++++++++++++++---
>   qapi/net.json   |   2 +-
>   qemu-options.hx |   1 +
>   3 files changed, 104 insertions(+), 6 deletions(-)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:36:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:36:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426631.675199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTqa-00059U-JD; Thu, 20 Oct 2022 11:36:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426631.675199; Thu, 20 Oct 2022 11:36:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTqa-00059N-GK; Thu, 20 Oct 2022 11:36:24 +0000
Received: by outflank-mailman (input) for mailman id 426631;
 Thu, 20 Oct 2022 11:36:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olTqZ-00059H-3C
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:36:23 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 678c321e-506b-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:36:14 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9DAB72187E;
 Thu, 20 Oct 2022 11:36:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D0EB13494;
 Thu, 20 Oct 2022 11:36:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Jr9bEbUyUWPWBQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 11:36:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 678c321e-506b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666265781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=KHnL53pJczBHTqmZO1LrKItRzowSRHTkckS9BjAXjoE=;
	b=lYmD0CMx11/mhtHCnBMiU+WOl6vGhTpj/AiSjI9Y+eV6rL+Dhg8BSZjQG7421+kDbaFA0U
	CWHhBrzKzEkziGciqXPpbYv4fDQ3jH6dX3UkmdjaRulsa6RdNE4FvubOZnffhyyS/Px4vG
	IzZ7CeB9/zCegnAa22lBFdmlAaSAuZo=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH] x86/xen: simplify sysenter and syscall setup
Date: Thu, 20 Oct 2022 13:36:19 +0200
Message-Id: <20221020113619.17204-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/setup.c | 23 ++++++-----------------
 1 file changed, 6 insertions(+), 17 deletions(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index cfa99e8f054b..0f33ed6d3a7b 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -910,17 +910,9 @@ static int register_callback(unsigned type, const void *func)
 
 void xen_enable_sysenter(void)
 {
-	int ret;
-	unsigned sysenter_feature;
-
-	sysenter_feature = X86_FEATURE_SYSENTER32;
-
-	if (!boot_cpu_has(sysenter_feature))
-		return;
-
-	ret = register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat);
-	if(ret != 0)
-		setup_clear_cpu_cap(sysenter_feature);
+	if (boot_cpu_has(X86_FEATURE_SYSENTER32) &&
+	    register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat))
+		setup_clear_cpu_cap(X86_FEATURE_SYSENTER32);
 }
 
 void xen_enable_syscall(void)
@@ -934,12 +926,9 @@ void xen_enable_syscall(void)
 		   mechanism for syscalls. */
 	}
 
-	if (boot_cpu_has(X86_FEATURE_SYSCALL32)) {
-		ret = register_callback(CALLBACKTYPE_syscall32,
-					xen_entry_SYSCALL_compat);
-		if (ret != 0)
-			setup_clear_cpu_cap(X86_FEATURE_SYSCALL32);
-	}
+	if (boot_cpu_has(X86_FEATURE_SYSCALL32) &&
+	    register_callback(CALLBACKTYPE_syscall32, xen_entry_SYSCALL_compat))
+		setup_clear_cpu_cap(X86_FEATURE_SYSCALL32);
 }
 
 static void __init xen_pvmmu_arch_setup(void)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:38:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:38:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426637.675210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTsC-0005ko-US; Thu, 20 Oct 2022 11:38:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426637.675210; Thu, 20 Oct 2022 11:38:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTsC-0005kh-RN; Thu, 20 Oct 2022 11:38:04 +0000
Received: by outflank-mailman (input) for mailman id 426637;
 Thu, 20 Oct 2022 11:38:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olTsA-0005kU-Lb
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:38:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a302b5b3-506b-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:37:54 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 92DE21FCFA;
 Thu, 20 Oct 2022 11:38:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4090D13494;
 Thu, 20 Oct 2022 11:38:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id REBlDhkzUWPEBgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 11:38:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a302b5b3-506b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666265881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=bOeIQs06Ph1bJ91eHAC9fBVgauw5j59B8/KvO9VWdAY=;
	b=PBpvCe+eKaNf8bwyjdesNestAeyQ6jmQl9dMvpuhLdQXjqPFo9p9VBZgDru/8YYuiEsJmQ
	M0a4vZAgkjF5JxMl8e5xw+lL3Gdm19fY3NtK8sbry4qXU0+EZFADAIQWui+2pHnFqOrQMh
	DHvIn+IF35Oa8nHjrGVNSMG5sLUEBEI=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
Date: Thu, 20 Oct 2022 13:37:59 +0200
Message-Id: <20221020113759.17402-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr
accesses") introduced code resulting in a warning issued by the smatch
static checker, claiming to use an uninitialized variable.

This is a false positive, but work around the warning nevertheless.

Fixes: 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr accesses")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 68aff1382872..898a252ed6f1 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -302,7 +302,7 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read)
 static bool pmu_msr_chk_emulated(unsigned int msr, uint64_t *val, bool is_read,
 				 bool *emul)
 {
-	int type, index;
+	int type = 0, index = 0;
 
 	if (is_amd_pmu_msr(msr))
 		*emul = xen_amd_pmu_emulate(msr, val, is_read);
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:38:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:38:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426643.675221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTsv-0006M8-Af; Thu, 20 Oct 2022 11:38:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426643.675221; Thu, 20 Oct 2022 11:38:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTsv-0006M1-7u; Thu, 20 Oct 2022 11:38:49 +0000
Received: by outflank-mailman (input) for mailman id 426643;
 Thu, 20 Oct 2022 11:38:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3+B4=2V=citrix.com=prvs=285f10a64=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olTst-0006HM-QO
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:38:47 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c0bd5ed3-506b-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 13:38:45 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0bd5ed3-506b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666265925;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=HyEBvSsR+BA/QEyJKmgf3CwK36Yop80LjXHTORlueGA=;
  b=PqMnaLj1awOj2t6rUkPd5IrPqVDKwL65TXgZvUUTOMVEMqTjnpss7Ugg
   LROF99Vq+g8/QzyDf/xeSDHIANcP8sM3O/lqhLTe7XowBgXzzt8u1sqK1
   Aj/jFNYACHf1Zs+y9OFmdqlgmz7auA4G4L7laJmGjSZe4rciLvX/fsjPi
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82258612
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EMLJ9K0OYe4u2e6G7fbD5cVxkn2cJEfYwER7XKvMYLTBsI5bp2MGz
 GAbCz/VO/iIZGH2KY8jPNi28UNXv8CDydNiSwA5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlA5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVG4fhMPThu2
 8dAORYtMhaorbu5n4KCH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8+Dp4kkfjurX74azBC83qepLYt4niVxwt0uFToGIqPIIHaG5wP9qqej
 lLb7UnBCC8YDtfF4CKlol+vo7/hmRquDer+E5Xnr6U30TV/3Fc7KBAQT0r9nvC/hWa3QdcZI
 EsRkgIipLY/3FamRd78W1u/unHslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQXO
 kShxo2zQ2Y16fvMFCzbpuz8QS6O1TY9c3QcXhNdbSU+u8jFgN01pTiWQYlTKfvg5jHqIg3Yz
 zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxawYRLt1WGVtq
 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yT+FWyzyGskTKuMDirjUWawC
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKlHepXEyORDLgjqFfK0QfUYXY
 M3zTCpRJSxCVfQPIMSeHY/xLoPHNghhnDiOFPgXPjys0KaEZW79dIrpxGCmN7hjhIvd+V292
 48Ga6O3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrTac1s3Rj59V6K5LHFIU9UNopm5X9zgp
 hmVMnK0AnKm7ZEbAW1mskxeVY4=
IronPort-HdrOrdr: A9a23:QmfSjKOIFKKOFcBcTtejsMiBIKoaSvp037Eqv3oedfU1SL3+qy
 nAppQmPHPP5Ar5O0tQ/exoWpPwIk80nKQdieJ6UItKNDOW3VdAR7sC0WKN+VLd8lXFh4xg6Z
 s=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="82258612"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Edwin Torok
	<edvin.torok@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>
Subject: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Date: Thu, 20 Oct 2022 12:38:10 +0100
Message-ID: <20221020113810.20844-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

tl;dr This hunk was part of the patch emailed to xen-devel, but was missing
from what ultimately got committed.

https://lore.kernel.org/xen-devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.1610748224.git.edvin.torok@citrix.com/
is the patch in question, but was part of a series that had threading issues.
I have a vague recollection that I sourced the commits from a local branch,
which clearly wasn't as up-to-date as I had thought.

Either way, it's my fault/mistake, and this hunk should have been part of what
got comitted.

Fixes: 00c48f57ab36 ("tools/oxenstored: Start live update process")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Christian Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Edwin Torok <edvin.torok@citrix.com>
CC: Rob Hoes <Rob.Hoes@citrix.com>
CC: Henry Wang <Henry.Wang@arm.com>

Found while reviewing the XenServer patchqueue.  This is low risk for 4.17 and
fixes a feature which we thought had been working since 4.15.
---
 tools/ocaml/xenstored/xenstored.ml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml
index d44ae673c42a..fc90fcdeb5d6 100644
--- a/tools/ocaml/xenstored/xenstored.ml
+++ b/tools/ocaml/xenstored/xenstored.ml
@@ -352,6 +352,11 @@ let _ =
 		rw_sock
 	) in
 
+	(* required for xenstore-control to detect availability of live-update *)
+	Store.mkdir store Perms.Connection.full_rights (Store.Path.of_string "/tool");
+	Store.write store Perms.Connection.full_rights
+		(Store.Path.of_string "/tool/xenstored") Sys.executable_name;
+
 	Sys.set_signal Sys.sighup (Sys.Signal_handle sighup_handler);
 	Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ ->
 		info "Received SIGTERM";
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:39:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:39:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426648.675232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTtQ-0006td-KT; Thu, 20 Oct 2022 11:39:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426648.675232; Thu, 20 Oct 2022 11:39:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTtQ-0006tW-H0; Thu, 20 Oct 2022 11:39:20 +0000
Received: by outflank-mailman (input) for mailman id 426648;
 Thu, 20 Oct 2022 11:39:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RuCN=2V=alien8.de=bp@srs-se1.protection.inumbo.net>)
 id 1olTtM-0006HM-3B
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:39:19 +0000
Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d24ed6b5-506b-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 13:39:14 +0200 (CEST)
Received: from zn.tnic (p200300ea9733e710329c23fffea6a903.dip0.t-ipconnect.de
 [IPv6:2003:ea:9733:e710:329c:23ff:fea6:a903])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 59C931EC0567;
 Thu, 20 Oct 2022 13:39:09 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d24ed6b5-506b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
	t=1666265949;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
	bh=Vt+wMbRFE0rG1uXDujJFiYR0joB4irWLNz9Ee1QgEPY=;
	b=Lo2rYQRz7A01KADbSuyKRxc1XILdeTNVtSfBHQ6PVOriFyIbeFkH76vI40g1wbm5m7rGlR
	TMyHEwGgv0LOWkHvZL3E1HTzoJhM7nJazREkCHOqRC+ROyKYNxA00cJXwKIXbr/IrRJqTn
	z8gXYkwQKD48/lE+L7Ml+vSO/8iqZPk=
Date: Thu, 20 Oct 2022 13:39:09 +0200
From: Borislav Petkov <bp@alien8.de>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] x86/xen: simplify sysenter and syscall setup
Message-ID: <Y1EzXQP3/Pn3bme+@zn.tnic>
References: <20221020113619.17204-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221020113619.17204-1-jgross@suse.com>

On Thu, Oct 20, 2022 at 01:36:19PM +0200, Juergen Gross wrote:
> xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  arch/x86/xen/setup.c | 23 ++++++-----------------
>  1 file changed, 6 insertions(+), 17 deletions(-)
> 
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index cfa99e8f054b..0f33ed6d3a7b 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -910,17 +910,9 @@ static int register_callback(unsigned type, const void *func)
>  
>  void xen_enable_sysenter(void)
>  {
> -	int ret;
> -	unsigned sysenter_feature;
> -
> -	sysenter_feature = X86_FEATURE_SYSENTER32;
> -
> -	if (!boot_cpu_has(sysenter_feature))
> -		return;
> -
> -	ret = register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat);
> -	if(ret != 0)
> -		setup_clear_cpu_cap(sysenter_feature);
> +	if (boot_cpu_has(X86_FEATURE_SYSENTER32) &&

Can you switch that and below to cpu_feature_enabled() while at it, pls?

> +	if (boot_cpu_has(X86_FEATURE_SYSCALL32) &&
	^^^^^^^^^^^^^^^^^^

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:41:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:41:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426656.675243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTvm-0008KN-1e; Thu, 20 Oct 2022 11:41:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426656.675243; Thu, 20 Oct 2022 11:41:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olTvl-0008KG-UJ; Thu, 20 Oct 2022 11:41:45 +0000
Received: by outflank-mailman (input) for mailman id 426656;
 Thu, 20 Oct 2022 11:41:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olTvk-0008K8-FZ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:41:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2730f3e8-506c-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:41:36 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3D5CE1FD3F;
 Thu, 20 Oct 2022 11:41:43 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F116C13494;
 Thu, 20 Oct 2022 11:41:42 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id fyx0OfYzUWMiCQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 11:41:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2730f3e8-506c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666266103; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=V6I+YxKK/S0zNtNkARnSZrYfff5kmB3ES2zI+J4f4Co=;
	b=SyngHn68Jf/MsSgqzkpUHw/+ySnRwv57RteCu8ANICjJpIjMg8f3P+tHZkQoPb+BIFd103
	U/WOPiYkAcKrlWR9y9g1Yb/bVvUdJKmDM4DhOK9OiAAKeVlbS3Kch/JX5FfXw4vZPUR0Na
	mrjK/35p7dE15VQjgAoxETH+L271GWc=
Message-ID: <87deb6d1-b2e3-2560-4b49-d50819d3c4a7@suse.com>
Date: Thu, 20 Oct 2022 13:41:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] x86/xen: simplify sysenter and syscall setup
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 xen-devel@lists.xenproject.org
References: <20221020113619.17204-1-jgross@suse.com>
 <Y1EzXQP3/Pn3bme+@zn.tnic>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <Y1EzXQP3/Pn3bme+@zn.tnic>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------vtDvH23fSoPYeW7IhPhy6DE0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------vtDvH23fSoPYeW7IhPhy6DE0
Content-Type: multipart/mixed; boundary="------------bwGP5d4dr6G0cwG7AfrgUIIv";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 xen-devel@lists.xenproject.org
Message-ID: <87deb6d1-b2e3-2560-4b49-d50819d3c4a7@suse.com>
Subject: Re: [PATCH] x86/xen: simplify sysenter and syscall setup
References: <20221020113619.17204-1-jgross@suse.com>
 <Y1EzXQP3/Pn3bme+@zn.tnic>
In-Reply-To: <Y1EzXQP3/Pn3bme+@zn.tnic>

--------------bwGP5d4dr6G0cwG7AfrgUIIv
Content-Type: multipart/mixed; boundary="------------HmUrsrQGm7kygNSsiWRZ0Rnj"

--------------HmUrsrQGm7kygNSsiWRZ0Rnj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMTAuMjIgMTM6MzksIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVGh1LCBP
Y3QgMjAsIDIwMjIgYXQgMDE6MzY6MTlQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToN
Cj4+IHhlbl9lbmFibGVfc3lzZW50ZXIoKSBhbmQgeGVuX2VuYWJsZV9zeXNjYWxsKCkgY2Fu
IGJlIHNpbXBsaWZpZWQgYSBsb3QuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBH
cm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4gLS0tDQo+PiAgIGFyY2gveDg2L3hlbi9zZXR1
cC5jIHwgMjMgKysrKysrLS0tLS0tLS0tLS0tLS0tLS0NCj4+ICAgMSBmaWxlIGNoYW5nZWQs
IDYgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBh
L2FyY2gveDg2L3hlbi9zZXR1cC5jIGIvYXJjaC94ODYveGVuL3NldHVwLmMNCj4+IGluZGV4
IGNmYTk5ZThmMDU0Yi4uMGYzM2VkNmQzYTdiIDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYv
eGVuL3NldHVwLmMNCj4+ICsrKyBiL2FyY2gveDg2L3hlbi9zZXR1cC5jDQo+PiBAQCAtOTEw
LDE3ICs5MTAsOSBAQCBzdGF0aWMgaW50IHJlZ2lzdGVyX2NhbGxiYWNrKHVuc2lnbmVkIHR5
cGUsIGNvbnN0IHZvaWQgKmZ1bmMpDQo+PiAgIA0KPj4gICB2b2lkIHhlbl9lbmFibGVfc3lz
ZW50ZXIodm9pZCkNCj4+ICAgew0KPj4gLQlpbnQgcmV0Ow0KPj4gLQl1bnNpZ25lZCBzeXNl
bnRlcl9mZWF0dXJlOw0KPj4gLQ0KPj4gLQlzeXNlbnRlcl9mZWF0dXJlID0gWDg2X0ZFQVRV
UkVfU1lTRU5URVIzMjsNCj4+IC0NCj4+IC0JaWYgKCFib290X2NwdV9oYXMoc3lzZW50ZXJf
ZmVhdHVyZSkpDQo+PiAtCQlyZXR1cm47DQo+PiAtDQo+PiAtCXJldCA9IHJlZ2lzdGVyX2Nh
bGxiYWNrKENBTExCQUNLVFlQRV9zeXNlbnRlciwgeGVuX2VudHJ5X1NZU0VOVEVSX2NvbXBh
dCk7DQo+PiAtCWlmKHJldCAhPSAwKQ0KPj4gLQkJc2V0dXBfY2xlYXJfY3B1X2NhcChzeXNl
bnRlcl9mZWF0dXJlKTsNCj4+ICsJaWYgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TWVNF
TlRFUjMyKSAmJg0KPiANCj4gQ2FuIHlvdSBzd2l0Y2ggdGhhdCBhbmQgYmVsb3cgdG8gY3B1
X2ZlYXR1cmVfZW5hYmxlZCgpIHdoaWxlIGF0IGl0LCBwbHM/DQo+IA0KPj4gKwlpZiAoYm9v
dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NZU0NBTEwzMikgJiYNCj4gCV5eXl5eXl5eXl5eXl5e
Xl5eXg0KDQpZZXMsIG9mIGNvdXJzZS4NCg0KDQpKdWVyZ2VuDQo=
--------------HmUrsrQGm7kygNSsiWRZ0Rnj
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------HmUrsrQGm7kygNSsiWRZ0Rnj--

--------------bwGP5d4dr6G0cwG7AfrgUIIv--

--------------vtDvH23fSoPYeW7IhPhy6DE0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNRM/YFAwAAAAAACgkQsN6d1ii/Ey8U
wwf+MqIhga3kLFK72rcr8wgUGEftDN6xfKkEp7YjwYdRQwDcav68bu3qQpyuGT4kFCSiBFnKSO2A
ca/91jZ2ly6Xv+CZuaTZ5aDjDVIkZWyIlvfUi0VPRMmTZj5CFCvjvZ31gArIPiQUe2L7pqZW6/WT
oHS6qYTvjuyCNxNCahgwSKiIsejTsc5D+Xl/NtYfld2y7qQQOG3kTMn3+9fzkLDv3lxakUKtl5WH
LHdoQaM/FOPih/yzHiIFr0MKEknSGCmy7L4RcuAqrzbT4bhzP4DzVMFkad2zoJmFpwciswgMSrxa
Heonb2lOas2Fo9cWIaA3/RneJbrEawV+rWDLADrJIw==
=+9Xr
-----END PGP SIGNATURE-----

--------------vtDvH23fSoPYeW7IhPhy6DE0--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:51:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:51:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426662.675254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olU5N-0001Qz-UB; Thu, 20 Oct 2022 11:51:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426662.675254; Thu, 20 Oct 2022 11:51:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olU5N-0001Qs-RJ; Thu, 20 Oct 2022 11:51:41 +0000
Received: by outflank-mailman (input) for mailman id 426662;
 Thu, 20 Oct 2022 11:51:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mk4f=2V=amd.com=Christian.Koenig@srs-se1.protection.inumbo.net>)
 id 1olU5L-0001Qm-UF
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:51:40 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2057.outbound.protection.outlook.com [40.107.244.57])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 88b7a8ee-506d-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:51:30 +0200 (CEST)
Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13)
 by MW4PR12MB6898.namprd12.prod.outlook.com (2603:10b6:303:207::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 11:51:34 +0000
Received: from BN8PR12MB3587.namprd12.prod.outlook.com
 ([fe80::805b:58b6:1f27:d644]) by BN8PR12MB3587.namprd12.prod.outlook.com
 ([fe80::805b:58b6:1f27:d644%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 11:51:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88b7a8ee-506d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eZGgRa3kdGSuCZRm+Hv4TjScY2SIvPHeWTGnviJGzfM7wLx+OVUHPdlhHOXQ1DuZrIMk9wSurTH+m5Jk5y9by2wfpSLowaS9ADSG0IlqTrGrZqf9gkwBqJ5IeAWknwaNaEVxArsqbiZAwhwipP/e1hdfbXMhR2+Ha3crfw5f1zP7wiWX23tx9AfSfg64vgM7IKtfOgyBgkLfhwu1btCayvtujR/pZ/tR0Mu/0n+F2u3UaBTu999vcMA8iQ2NBvuMm4eiRmRMvnMrHFl1koz3dMel9Jye6zhZquUMubYH//BaA9iEgntTdMvezAu1V3a3AlNx3e5ze15RxGQhQGudAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BkjpM06ND/1tPS8vCFaUA1j7bWQXJk3S6+Ma6y4+cfY=;
 b=l8qbIUvirfxoM99SNeSfKNWvMb3dFtEv1yFv9HfbKP/Kb/MjjJAwfGOgu80xJ0NZF4XOXMrvUv/bi9H+ObYYX/N6ASiTlDCDhsG0DHQsOOGBKZ7FV4TNK12ykqA0gM4G8GLgqh41RN1pddJV/0s/Tq5CtykrPl/iRMJ3BZ+VXO06K5DbCIL2ImHFJiblER6bcwScDIHvSBWvZhFCCLCm7tmefa+1QKmhr5G5/X39vjIBoxZOnEG800ukSD3WDZNg5tX7pOvD6nc9bSGA0Kohtlj34nROReglIFe8eMVJdiIz4A2Wrj6t5uCaa4tdJxWXFmP4CEyiUPHrfKFGvRcZyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BkjpM06ND/1tPS8vCFaUA1j7bWQXJk3S6+Ma6y4+cfY=;
 b=dsyeXoJNcHCjbzP4ZNAVYLXgu0pe8A+opYJYBFnk84JO9MhqSCoYaye+ObyrUo5CQTs87GSP0PNtSul5zL+fMn9m80yN9Mxs51/cR8XcXWLhiAc+tZwEOi1ysx62cUnD0AtYywf/MQYRwvuRQuJ9Nz9gX0iMj99ArryPoQtcey8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <b26e508b-7599-3953-6803-7db00b3cfbcb@amd.com>
Date: Thu, 20 Oct 2022 13:48:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose
Content-Language: en-US
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
 nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org,
 amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev,
 linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org,
 spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
 linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
 freedreno@lists.freedesktop.org
References: <20221020103755.24058-1-tzimmermann@suse.de>
 <20221020103755.24058-2-tzimmermann@suse.de>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221020103755.24058-2-tzimmermann@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0013.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::26) To BN8PR12MB3587.namprd12.prod.outlook.com
 (2603:10b6:408:43::13)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8PR12MB3587:EE_|MW4PR12MB6898:EE_
X-MS-Office365-Filtering-Correlation-Id: 34bb9327-0e2d-47ac-fb3c-08dab2916e16
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	djglQBEcOzQigVniLbe7Uf01Ze6y6L18CCWR2e3mm2E9AzSJ1dwV+R9sPDPXx1A0eWzcwN9YUwpJcH5t5lDYt8a2S3OOz4ouFnAvkOiZmwqnMV9iuwXW25FJ9kjsfDbwGJkT7TgyjGnN44KeQQjy4ZrJeyk/f0GIiIHR9a9IjFOhNx/Z1RfFqa0I/bhvNXRgm2zjwB7e01lEEn80TTf1cKy8g8hCCFE2XpfDIpG+0VwA3xQbDrCnNvu5FvJgW8iY6Vi4W5OSKweYsYGNp4n6gr6A0nKoez9CLbTESEbneiGYKRkE7a4biikyvj8Os0QTiSYK8AS5LUYhj7chpPGfZLuIYwy9CuJQTbs84z/GXy+7/1SzfhsrNnpgo0895gXIwmQt0rDnk7/jcw/6z8MsUC6Wohh4Tw1h7nvtCD+VKTbRR4Q2N3uRzI3fNHsn20o0DadkRUci7fmPE519U9990lvL3F7E/UmaWxTYjJffWnyuqRRK1+ble/q7/zQn37U3/ntUtHzCoJPUFWVQCNni+b+cNvUTis5Ko9VhihiorGXCPuberCeKqVHTN6dALg8D3TMOxJjAXyAxnFC9NmEb+9cpJ+n8JXn0MG+hlQYb5G9KtPOE73WJ/iLT3UkJehD07nkhzgdEx/e/DQegQMNTt52NXTPFUJRXTDl4Nswuq2u0jWPyF9pPEoLfSdAz1J2VKUnnvQTxlrYPx8i0GVW6DfSVsJX1ai9iEyELVV/jTK86xzG+FMW1Pqn5bj5xMFNxd8FRB78bF/t4oQZan14UkaO5EKNcXz1LE+k5omCyxfI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3587.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(451199015)(6512007)(26005)(6666004)(478600001)(83380400001)(186003)(7416002)(6506007)(5660300002)(2616005)(66556008)(316002)(41300700001)(4326008)(66946007)(6486002)(8936002)(66476007)(8676002)(31696002)(86362001)(36756003)(38100700002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NGR3cjIySk43T2JMVlU0NnRNVWdGcUFnNElKV3FWSlVncC8waUlFRlBPamls?=
 =?utf-8?B?ckxnR1V4Y2JUYWhsZGFNemdrSXBYOUhlNldFZTZ1Q3NDOWtCelpQVkRwQkE5?=
 =?utf-8?B?NDRTc2N3T3VydE1ma2pyaEdrcFZmZW1iVTlsY2ZYMXZuQ0FBYkF6aUFhZ3VI?=
 =?utf-8?B?OE9JbFFXeDhVSTdsblY3cWdUUUh4TmorTFpPRm11eVFwYzgwU2J3UGpTUjdz?=
 =?utf-8?B?TFdVSndhVDQxRVdxbVcrczA4YnpHWHZROHVncnJVckkyZHc4Q0tqM2V4VlBo?=
 =?utf-8?B?Yk5WSFcxQVdEUzhXRm1TUHgyUnhZcnArZG5XQ2gyNFZYSzFlN3lBdmRUUEpk?=
 =?utf-8?B?SkdmR29HNnNHWk9iWW0xUjZaWlltL1hmZE9NaVRKU2NSeUNkSkU3dGozbHFV?=
 =?utf-8?B?alR4d3QrZnROOG5QU1p2dHNvbkozdWUvdjB5QThwZitmTi9lZEVnRm1Ra2hC?=
 =?utf-8?B?anZETzJnUDRwQUtjSWMrQ3lFWjhjcTRzOHlPcVhndUF1OTBrYWt3V0JrYTBo?=
 =?utf-8?B?d0ErU0xnWlpmbWJKcm94VEg2YVlmRnB0OFIvMkgxTEpvd05sbVhKRGkzL3JO?=
 =?utf-8?B?Q1BEUWpsSVdXUnBTVkhYYjVmcllDdGhudjFjYkJ1OHFnTnE0MFprUzFGaFJt?=
 =?utf-8?B?YTRWUUVCQ0NQczRjRjFjblRBTDdFZ3RoaXo1Yy9LS09MTGJIR1NLd0FmUTNS?=
 =?utf-8?B?aFdXTXgyU0dTTVcrcGQ4NVhhUHNqZnNmWUUzbWlPdW00Y3ZyWUF1eE5sc1Nq?=
 =?utf-8?B?ek50Q0pveXpxNmRIRWkwS3dhb3lmZFhJcHk0YnJPMU1DTXRMS05WWXlFdHpz?=
 =?utf-8?B?RlZXRDA5c0x0Skt4SkEwZmUxWFZoZ205WUJsc2NVbXkvZFA0bDNQQmNvRFh6?=
 =?utf-8?B?dmhwNzBFVDlXZ0puQ0I5Mi9Wb1V2QStybzVXSkJPUjErZ0hLbG02L2hnZDVx?=
 =?utf-8?B?Tmt1TzVtbW5mM21Pb0hRSTl4Z2hUdEhBMzRTQTYzY1FNeGV3TWxtZXZzYTJN?=
 =?utf-8?B?cnFEQkdUMWE1bGM2QzVPK3JoQWZLejNnc2pGYjhaZm5YQ2lrelhGei94djNo?=
 =?utf-8?B?SkxCRDIzSUw1S21ZdXAzUW8zK25JTWd0OU1IbXZoZEg5QlFPWFhUZHpraDZn?=
 =?utf-8?B?Q1ZNUG0vNm9jeEVSTTVKUTVQYzlvNDFnMklrK3ljZy9PcDA2cXhCSW14Z3Fl?=
 =?utf-8?B?aE80WGxDb1o4NTBmV28wVXhzRGJRV0hoQk1pUnUzQ2U0VlFTZk9ZMlBaajBu?=
 =?utf-8?B?T0wrV3U4VE16cW50VWE5M2YzdVJYRnFTMVllR0htK0RjTE1qNlR2TDhJa2N4?=
 =?utf-8?B?aExYaGx1RDROOFRWdlAwWEFjYzIvM1VDNkRVWElESjZ2WUV6QVNjVW1nL2Uv?=
 =?utf-8?B?SWhuVDExdzJKbnZPUkh0RHdlMnJGdFp3eUt4eitOckxyZXIwUEhEb0I0alBE?=
 =?utf-8?B?TFQ3OUUwb21tWFVSZ2pFUDVMMkUxSlFEY0hoUkhJcXJIRTM4ZXJMRWRlVm5V?=
 =?utf-8?B?d3FjTExlWm1lWHlpQjNpUW1Mc3p0SkRXK1l0QnFDRTZxZ2xpcXNQNjVvb1Q4?=
 =?utf-8?B?SWtvTDhuU3pFcHZoQVVvUGp6d1RXOXZoT3pEbFBIcDZtYXNWaWNMMWMySStt?=
 =?utf-8?B?NkhmRXU4ZFk4Mm5XWkJKZ2UvWmI4ZTMyVmQ3NTZYbFFzRnVjazllbm1wWFRz?=
 =?utf-8?B?TVRSempBYzlXNThpcVBXQWY3QTYvSVVwMEw5dXRoUGIwd2lJSm9YMStnYTQr?=
 =?utf-8?B?UUZYNnM2YzdlQ095d1ozZUk2ZXZqTXlsTERQZVN1aXp4QURrZEhQYnlCYUZl?=
 =?utf-8?B?cjVNZWZ6N3hjbGF2ZXFxUFBOay8vWndOTXFIZFZVWUZUM3prQWNMM1Z5NFFN?=
 =?utf-8?B?M09uczcvS3R6dVZzVEdzbGpMNWxvTWdMbTRVVUUwZFVUL3lGQU90V0kyRU52?=
 =?utf-8?B?L2U5OUVzclpiYk05OHVFL29YSC9COTgvZzV2cDRFTnczOXFkUEQrRVdINmV4?=
 =?utf-8?B?NUw1T3RjODJlVEE5Q2k2VUNaYXJWSEF6THFMK1VHQzMwTEZicy8vaXZFYTNB?=
 =?utf-8?B?RWRJc3pGMjRzM3BiOURCZVQ2c3NwN0o1OTdxYVplS3pmakdpaUk1TXc1bUZs?=
 =?utf-8?Q?81xaw8csJVBvRA3mTABTFHhlz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34bb9327-0e2d-47ac-fb3c-08dab2916e16
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 11:51:31.6004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5OeVYNFFTSt7GCUp4ykoNFJm7pu1DjoecANWmf//HoEVyDQ3WU2UDqJkXgyXYuB7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6898

Am 20.10.22 um 12:37 schrieb Thomas Zimmermann:
> Don't set struct drm_driver.lastclose. It's used to restore the
> fbdev console. But as amdgpu uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See
> the call to drm_client_dev_restore() in drm_lastclose().

???

The commit message doesn't match what the patch is doing. You are 
removing output_poll_changed instead of lastclose here.

Did something got mixed up?

Cheers,
Christian.

>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c       | 1 -
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
>   2 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 23998f727c7f9..fb7186c5ade2a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1224,7 +1224,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev,
>   
>   const struct drm_mode_config_funcs amdgpu_mode_funcs = {
>   	.fb_create = amdgpu_display_user_framebuffer_create,
> -	.output_poll_changed = drm_fb_helper_output_poll_changed,
>   };
>   
>   static const struct drm_prop_enum_list amdgpu_underscan_enum_list[] =
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index f6a9e8fdd87d6..e9a28a5363b9a 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -82,7 +82,6 @@
>   #include <drm/drm_atomic_uapi.h>
>   #include <drm/drm_atomic_helper.h>
>   #include <drm/drm_blend.h>
> -#include <drm/drm_fb_helper.h>
>   #include <drm/drm_fourcc.h>
>   #include <drm/drm_edid.h>
>   #include <drm/drm_vblank.h>
> @@ -2810,7 +2809,6 @@ const struct amdgpu_ip_block_version dm_ip_block =
>   static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = {
>   	.fb_create = amdgpu_display_user_framebuffer_create,
>   	.get_format_info = amd_get_format_info,
> -	.output_poll_changed = drm_fb_helper_output_poll_changed,
>   	.atomic_check = amdgpu_dm_atomic_check,
>   	.atomic_commit = drm_atomic_helper_commit,
>   };



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 11:56:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 11:56:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426669.675265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUAD-0002Am-Kq; Thu, 20 Oct 2022 11:56:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426669.675265; Thu, 20 Oct 2022 11:56:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUAD-0002Af-Hu; Thu, 20 Oct 2022 11:56:41 +0000
Received: by outflank-mailman (input) for mailman id 426669;
 Thu, 20 Oct 2022 11:56:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olUAC-0002AV-R8; Thu, 20 Oct 2022 11:56:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olUAC-0006il-Mu; Thu, 20 Oct 2022 11:56:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olUAC-0000Yg-3A; Thu, 20 Oct 2022 11:56:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olUAC-0001rS-2i; Thu, 20 Oct 2022 11:56:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8vaDZ1UWZ7tR9QSGgyB3Udn/0WKPpzUydFyYIfBsoVM=; b=YO/naqEjgQbomrxbQGPqGZOOOm
	qLC4P39zQ/B6NxGnN5e4aL1yt3UXQmE2Jd7OxmInGKjU+c5lQyzMPQaAKa/2gT3BTWtfX8vdVVdEj
	EA683pXoSD2hWncXiHvG0T/OG+5oEQvojoH48N9LH4IR1DEbNMgQSuWd5TZuRrOJSBAY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174057-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174057: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 11:56:40 +0000

flight 174057 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174057/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173980
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 173980
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 173980
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173980
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173980
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 173980
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 173980
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 173980
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 173980
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173980
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 173980
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173980
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   174057  2022-10-18 18:44:47 Z    1 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:00:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:00:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426677.675276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUDH-0002mc-45; Thu, 20 Oct 2022 11:59:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426677.675276; Thu, 20 Oct 2022 11:59:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUDH-0002mV-1J; Thu, 20 Oct 2022 11:59:51 +0000
Received: by outflank-mailman (input) for mailman id 426677;
 Thu, 20 Oct 2022 11:59:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olUDF-0002mN-MB
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 11:59:49 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id adf798bc-506e-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 13:59:41 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 53C0920A44;
 Thu, 20 Oct 2022 11:59:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1077413494;
 Thu, 20 Oct 2022 11:59:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zs6/AjQ4UWNSFAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 11:59:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adf798bc-506e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666267188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=oySpgM5g+r0WCk6Eq8kGRfyxgEAOWxWakiY/c8kh3qw=;
	b=JGPhQj1ZV+Sm3I4LVtq4L2JrCJZGFxiejo9qvyBgS68IuVh2HOzZyizIwaITr4r3lBXAam
	rB78ZqWe8tgRiWX2mcORmHaemwL1xdxp0yjq8zNmUfeecmJtUvLa7dUoD6pFb8YPEHLFd4
	/SlQGRy9MJC4I/CPIUhDGbvRjCNvmiM=
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2] x86/xen: simplify sysenter and syscall setup
Date: Thu, 20 Oct 2022 13:59:46 +0200
Message-Id: <20221020115946.18772-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

xen_enable_sysenter() and xen_enable_syscall() can be simplified a lot.

While at it, switch to use cpu_feature_enabled() instead of
boot_cpu_has().

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- use cpu_feature_enabled() (Borislav Petkov)
---
 arch/x86/xen/setup.c | 23 ++++++-----------------
 1 file changed, 6 insertions(+), 17 deletions(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index cfa99e8f054b..4f4309500559 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -910,17 +910,9 @@ static int register_callback(unsigned type, const void *func)
 
 void xen_enable_sysenter(void)
 {
-	int ret;
-	unsigned sysenter_feature;
-
-	sysenter_feature = X86_FEATURE_SYSENTER32;
-
-	if (!boot_cpu_has(sysenter_feature))
-		return;
-
-	ret = register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat);
-	if(ret != 0)
-		setup_clear_cpu_cap(sysenter_feature);
+	if (cpu_feature_enabled(X86_FEATURE_SYSENTER32) &&
+	    register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat))
+		setup_clear_cpu_cap(X86_FEATURE_SYSENTER32);
 }
 
 void xen_enable_syscall(void)
@@ -934,12 +926,9 @@ void xen_enable_syscall(void)
 		   mechanism for syscalls. */
 	}
 
-	if (boot_cpu_has(X86_FEATURE_SYSCALL32)) {
-		ret = register_callback(CALLBACKTYPE_syscall32,
-					xen_entry_SYSCALL_compat);
-		if (ret != 0)
-			setup_clear_cpu_cap(X86_FEATURE_SYSCALL32);
-	}
+	if (cpu_feature_enabled(X86_FEATURE_SYSCALL32) &&
+	    register_callback(CALLBACKTYPE_syscall32, xen_entry_SYSCALL_compat))
+		setup_clear_cpu_cap(X86_FEATURE_SYSCALL32);
 }
 
 static void __init xen_pvmmu_arch_setup(void)
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:01:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:01:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426685.675287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUEQ-0004Cz-N1; Thu, 20 Oct 2022 12:01:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426685.675287; Thu, 20 Oct 2022 12:01:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUEQ-0004Cs-Jv; Thu, 20 Oct 2022 12:01:02 +0000
Received: by outflank-mailman (input) for mailman id 426685;
 Thu, 20 Oct 2022 12:01:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vz6S=2V=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1olUEP-00034r-BN
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:01:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dd077d09-506e-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 14:01:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 2CEEE20A43;
 Thu, 20 Oct 2022 12:01:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E08013494;
 Thu, 20 Oct 2022 12:00:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FxuXIXs4UWMgFQAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Thu, 20 Oct 2022 12:00:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd077d09-506e-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666267260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=xkVVGkBtQDyTBLM0kpfBsn85EfLgvqE9XvpjJpebKS0=;
	b=jH0AvdmQ5Sn82qm3xMDUFxEtzQ8Afd86NNzn7lSCGUrsJFLaw9SnOVNSzFWgYotcUsDNAg
	GKaqBJMmMrfij+SPe7P8hnpSwt/PMM4kACWzGqryH9FajEaW0KkQM86idJuP32rsTloZ7/
	EQO0HWAxraWBomxhUiO5JqjhYu4FO/o=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666267260;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=xkVVGkBtQDyTBLM0kpfBsn85EfLgvqE9XvpjJpebKS0=;
	b=vHl/tg1vlnnTCoJtjSfQJbaUEq4mIb+x/G13qkx57QzPLCFuuxyt3aozzSXnhYTqv6SF/Y
	S/MUxJREit23oWCA==
Message-ID: <8f3a7b67-d193-eb47-a5a6-8826e9c82f83@suse.de>
Date: Thu, 20 Oct 2022 14:00:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose
Content-Language: en-US
To: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
 daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com,
 mripard@kernel.org, maarten.lankhorst@linux.intel.com
Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
 nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org,
 amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org,
 spice-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
 linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org,
 linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
 freedreno@lists.freedesktop.org
References: <20221020103755.24058-1-tzimmermann@suse.de>
 <20221020103755.24058-2-tzimmermann@suse.de>
 <b26e508b-7599-3953-6803-7db00b3cfbcb@amd.com>
From: Thomas Zimmermann <tzimmermann@suse.de>
In-Reply-To: <b26e508b-7599-3953-6803-7db00b3cfbcb@amd.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------WYrb0xK08aT03AsuaxFIILPE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------WYrb0xK08aT03AsuaxFIILPE
Content-Type: multipart/mixed; boundary="------------gwXK6OaLfaQ8iAMdjblSoB42";
 protected-headers="v1"
From: Thomas Zimmermann <tzimmermann@suse.de>
To: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
 daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, javierm@redhat.com,
 mripard@kernel.org, maarten.lankhorst@linux.intel.com
Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
 nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org,
 amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org,
 spice-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
 linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org,
 xen-devel@lists.xenproject.org, linux-tegra@vger.kernel.org,
 linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
 freedreno@lists.freedesktop.org
Message-ID: <8f3a7b67-d193-eb47-a5a6-8826e9c82f83@suse.de>
Subject: Re: [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose
References: <20221020103755.24058-1-tzimmermann@suse.de>
 <20221020103755.24058-2-tzimmermann@suse.de>
 <b26e508b-7599-3953-6803-7db00b3cfbcb@amd.com>
In-Reply-To: <b26e508b-7599-3953-6803-7db00b3cfbcb@amd.com>

--------------gwXK6OaLfaQ8iAMdjblSoB42
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

SGkNCg0KQW0gMjAuMTAuMjIgdW0gMTM6NDggc2NocmllYiBDaHJpc3RpYW4gS8O2bmlnOg0K
PiBBbSAyMC4xMC4yMiB1bSAxMjozNyBzY2hyaWViIFRob21hcyBaaW1tZXJtYW5uOg0KPj4g
RG9uJ3Qgc2V0IHN0cnVjdCBkcm1fZHJpdmVyLmxhc3RjbG9zZS4gSXQncyB1c2VkIHRvIHJl
c3RvcmUgdGhlDQo+PiBmYmRldiBjb25zb2xlLiBCdXQgYXMgYW1kZ3B1IHVzZXMgZ2VuZXJp
YyBmYmRldiBlbXVsYXRpb24sIHRoZQ0KPj4gY29uc29sZSBpcyBiZWluZyByZXN0b3JlZCBi
eSB0aGUgRFJNIGNsaWVudCBoZWxwZXJzIGFscmVhZHkuIFNlZQ0KPj4gdGhlIGNhbGwgdG8g
ZHJtX2NsaWVudF9kZXZfcmVzdG9yZSgpIGluIGRybV9sYXN0Y2xvc2UoKS4NCj4gDQo+ID8/
Pw0KPiANCj4gVGhlIGNvbW1pdCBtZXNzYWdlIGRvZXNuJ3QgbWF0Y2ggd2hhdCB0aGUgcGF0
Y2ggaXMgZG9pbmcuIFlvdSBhcmUgDQo+IHJlbW92aW5nIG91dHB1dF9wb2xsX2NoYW5nZWQg
aW5zdGVhZCBvZiBsYXN0Y2xvc2UgaGVyZS4NCj4gDQo+IERpZCBzb21ldGhpbmcgZ290IG1p
eGVkIHVwPw0KDQpBcmdoaC4gVGhlcmUgYXJlIHBhdGNoZXMgZm9yIGxhc3RjbG9zZSBhbmQg
b3V0cHV0X3BvbGxfY2hhbmdlZC4gVGhlIA0KcmVhc29uIGZvciByZW1vdmluZyB0aGVtIGlz
IHRoZSBzYW1lLCBidXQgdGhhbmtzIHRvIGNvcHkgYW5kIHBhc3RlIHRoZSANCm5hbWVzIGFy
ZSB3cm9uZy4gU28gdGhlIHBhdGNoIGlzIGNvcnJlY3QsIGJ1dCB0aGUgZGVzY3JpcHRpb24g
aXNuJ3QuIA0KV2lsbCBiZSBmaXhlZC4NCg0KQmVzdCByZWdhcmRzDQpUaG9tYXMNCg0KPiAN
Cj4gQ2hlZXJzLA0KPiBDaHJpc3RpYW4uDQo+IA0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IFRo
b21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPg0KPj4gLS0tDQo+PiDCoCBk
cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzcGxheS5jwqDCoMKgwqDCoMKg
IHwgMSAtDQo+PiDCoCBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2Ft
ZGdwdV9kbS5jIHwgMiAtLQ0KPj4gwqAgMiBmaWxlcyBjaGFuZ2VkLCAzIGRlbGV0aW9ucygt
KQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn
cHVfZGlzcGxheS5jIA0KPj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf
ZGlzcGxheS5jDQo+PiBpbmRleCAyMzk5OGY3MjdjN2Y5Li5mYjcxODZjNWFkZTJhIDEwMDY0
NA0KPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXku
Yw0KPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXku
Yw0KPj4gQEAgLTEyMjQsNyArMTIyNCw2IEBAIGFtZGdwdV9kaXNwbGF5X3VzZXJfZnJhbWVi
dWZmZXJfY3JlYXRlKHN0cnVjdCANCj4+IGRybV9kZXZpY2UgKmRldiwNCj4+IMKgIGNvbnN0
IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgYW1kZ3B1X21vZGVfZnVuY3MgPSB7DQo+
PiDCoMKgwqDCoMKgIC5mYl9jcmVhdGUgPSBhbWRncHVfZGlzcGxheV91c2VyX2ZyYW1lYnVm
ZmVyX2NyZWF0ZSwNCj4+IC3CoMKgwqAgLm91dHB1dF9wb2xsX2NoYW5nZWQgPSBkcm1fZmJf
aGVscGVyX291dHB1dF9wb2xsX2NoYW5nZWQsDQo+PiDCoCB9Ow0KPj4gwqAgc3RhdGljIGNv
bnN0IHN0cnVjdCBkcm1fcHJvcF9lbnVtX2xpc3QgYW1kZ3B1X3VuZGVyc2Nhbl9lbnVtX2xp
c3RbXSA9DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2Ft
ZGdwdV9kbS9hbWRncHVfZG0uYyANCj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5
L2FtZGdwdV9kbS9hbWRncHVfZG0uYw0KPj4gaW5kZXggZjZhOWU4ZmRkODdkNi4uZTlhMjhh
NTM2M2I5YSAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9h
bWRncHVfZG0vYW1kZ3B1X2RtLmMNCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlz
cGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMNCj4+IEBAIC04Miw3ICs4Miw2IEBADQo+PiDC
oCAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfdWFwaS5oPg0KPj4gwqAgI2luY2x1ZGUgPGRy
bS9kcm1fYXRvbWljX2hlbHBlci5oPg0KPj4gwqAgI2luY2x1ZGUgPGRybS9kcm1fYmxlbmQu
aD4NCj4+IC0jaW5jbHVkZSA8ZHJtL2RybV9mYl9oZWxwZXIuaD4NCj4+IMKgICNpbmNsdWRl
IDxkcm0vZHJtX2ZvdXJjYy5oPg0KPj4gwqAgI2luY2x1ZGUgPGRybS9kcm1fZWRpZC5oPg0K
Pj4gwqAgI2luY2x1ZGUgPGRybS9kcm1fdmJsYW5rLmg+DQo+PiBAQCAtMjgxMCw3ICsyODA5
LDYgQEAgY29uc3Qgc3RydWN0IGFtZGdwdV9pcF9ibG9ja192ZXJzaW9uIGRtX2lwX2Jsb2Nr
ID0NCj4+IMKgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnX2Z1bmNzIGFt
ZGdwdV9kbV9tb2RlX2Z1bmNzID0gew0KPj4gwqDCoMKgwqDCoCAuZmJfY3JlYXRlID0gYW1k
Z3B1X2Rpc3BsYXlfdXNlcl9mcmFtZWJ1ZmZlcl9jcmVhdGUsDQo+PiDCoMKgwqDCoMKgIC5n
ZXRfZm9ybWF0X2luZm8gPSBhbWRfZ2V0X2Zvcm1hdF9pbmZvLA0KPj4gLcKgwqDCoCAub3V0
cHV0X3BvbGxfY2hhbmdlZCA9IGRybV9mYl9oZWxwZXJfb3V0cHV0X3BvbGxfY2hhbmdlZCwN
Cj4+IMKgwqDCoMKgwqAgLmF0b21pY19jaGVjayA9IGFtZGdwdV9kbV9hdG9taWNfY2hlY2ss
DQo+PiDCoMKgwqDCoMKgIC5hdG9taWNfY29tbWl0ID0gZHJtX2F0b21pY19oZWxwZXJfY29t
bWl0LA0KPj4gwqAgfTsNCj4gDQoNCi0tIA0KVGhvbWFzIFppbW1lcm1hbm4NCkdyYXBoaWNz
IERyaXZlciBEZXZlbG9wZXINClNVU0UgU29mdHdhcmUgU29sdXRpb25zIEdlcm1hbnkgR21i
SA0KTWF4ZmVsZHN0ci4gNSwgOTA0MDkgTsO8cm5iZXJnLCBHZXJtYW55DQooSFJCIDM2ODA5
LCBBRyBOw7xybmJlcmcpDQpHZXNjaMOkZnRzZsO8aHJlcjogSXZvIFRvdGV2DQo=

--------------gwXK6OaLfaQ8iAMdjblSoB42--

--------------WYrb0xK08aT03AsuaxFIILPE
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmNROHsFAwAAAAAACgkQlh/E3EQov+Af
qg/8DLfmRUYvAEkOGUdb+UPWlqwaao88s9cPeIA3h2HV6bYLuN3tcbcDWHFeQuAGVFYRgYLVboNR
UtD8lzBIfELkuzD83B+VRxYJBSUdOWNVr5cmES8vFHFcFPQKMLAl/NCnOZOkXBa2xbSyfsJ9t/t4
yXi4FqFTtRT4SWIfAHVY2cduEA/oRkqwmhB1nu+Nv+dWdMxKlWT5W5cc9D/tV7PNyU0D43q/xC3U
UPqtz6yMg2u6UXyQ4smF0HltdBU+CjGDnCKVwKfW1JHy3eo2ONTt3ORu7QnXAGImozT2vrN3G3rF
9FxNTpfh6Hv15QQMOPJqlCicq4nVRIXFHA2Za5jvGWa4m+bLzS4OH7KB+KqeWUEtX+QKl3eqgC56
HBs9QpM0tp9VLVX4ws1GcGoJ48BWHSSNQv2suBrtz7yhdrquiPhXM4+XqWo/MZAxS1jnki7QdBhj
PgYr3LQM68v3qRoLkKoAvqpkMDCUeAP7Sql6H1EmSBYcKupo8RvWEi0xTIoeHWA3WMXS+Lst+3uT
gOVa/gN0OgRYykGJ6NRHykDPW2fBb50tDngSNH9Mh6zxabnKGwbgzG6q6w+SZy4uEceuLu9yfkv7
bc/vqXu6UkH5/6ofgivW2hkPpkiyjQj5u9L55R67jqYOZCZfVsG2nGCNPoWHmDSbMdO1Fgmx46g4
koE=
=eccN
-----END PGP SIGNATURE-----

--------------WYrb0xK08aT03AsuaxFIILPE--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:07:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:07:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426692.675298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUKJ-0004vN-C5; Thu, 20 Oct 2022 12:07:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426692.675298; Thu, 20 Oct 2022 12:07:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUKJ-0004vF-93; Thu, 20 Oct 2022 12:07:07 +0000
Received: by outflank-mailman (input) for mailman id 426692;
 Thu, 20 Oct 2022 12:07:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cvJe=2V=citrix.com=prvs=2859d115b=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1olUKH-0004v9-Um
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:07:06 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0515b8d-506f-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 14:06:56 +0200 (CEST)
Received: from mail-bn1nam07lp2042.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 08:07:00 -0400
Received: from DM6PR03MB4172.namprd03.prod.outlook.com (2603:10b6:5:5c::23) by
 SJ0PR03MB6568.namprd03.prod.outlook.com (2603:10b6:a03:389::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 12:06:57 +0000
Received: from DM6PR03MB4172.namprd03.prod.outlook.com
 ([fe80::bc54:e6d5:2052:ddb4]) by DM6PR03MB4172.namprd03.prod.outlook.com
 ([fe80::bc54:e6d5:2052:ddb4%6]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022
 12:06:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0515b8d-506f-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666267623;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=ZrNAD7hDxWjwb+MMEErtxcdy4MmdgrAl6LptHBDyi0c=;
  b=Oa/VDAy0bTFPZIdI/+5COX270SR0MR/+iOJ+mJ/X/mxTGUh8PXzM4Rcx
   pGspYC5OA+FN2dBKqKvGqNHT8pUDbUrCLyXmkkIe/GEn+IKDGqnjMqmj4
   h2zUCNyN/YRcb+9ohuHTPS1oypUiTZ+h1Xf+D/cz/DircWkvDcyf7P00V
   g=;
X-IronPort-RemoteIP: 104.47.51.42
X-IronPort-MID: 83143555
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:lc7uCKm72LNHaIvgtdH3eU/o5gyuJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOXGiAPPffZWagLdhwPIvn9ksE7MWEm981HQpr/y00QiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkPagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHEV38
 Ps4OWg2VTOeh+6ZmY+CWMVnv5F2RCXrFNt3VnBI6xj8Vaxja7aaBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqui6PlmSd05C0WDbRUteKX8ROgkeRo
 CTC/mL1Ax4yP92D0zuVtHmrg4cjmAurA9tOT+Dlq5aGhnWDylc+UwYWdWe74tvkh0fuZ/tbG
 WIbr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOuMYoSBQw2
 1SOntevAiZg2JW1RHSH5/GrpDW9ESEPKCkJYipscOcey9zqoYV2hBSWSN9mSPGxloetRWu2x
 C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1
 JTcp/Wj0Q==
IronPort-HdrOrdr: A9a23:b7CFRq1bM04xyOvgFLKgpgqjBQRyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHO1OkPMs1NaZLUPbUQ6TQL2KgrGSpAEIdxeeygcZ79
 YZT0EcMqy8MbEZt7ed3ODQKb9Jr7e6GeKT9J7jJhxWPGNXgtRbnmNE43GgYyhLrWd9ZaYRJd
 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njAsRqYrJrBVzSI1BYXVD1ChZ0493
 LergD/7qK/99mm1x7n0XPJ5Zg+oqqu9jIDPr3MtiEmEESutu+aXvUiZ1REhkFxnAib0idrrD
 ALmWZlAy080QKXQoj/m2qR5+Cp6kdT15al8y7VvZKrm72GeBsqT8VGno5XaR3f9g4pu8x9yr
 tC2yaDu4NQFg6oplW12zBZPysa6XZcjEBS5tL7tUYvJ7c2eftUt8gS7UlVGJAPEGbz750mCv
 BnCIXZ6OxNeV2XYnjFti03qebcFUgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u
 zYOuBjla1ITMURcaVhbd1xCfefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzve8PcV
 T6ISZlXEIJCjHT4Je1rex2Gzj2MRWAdCWozN1C7J5kvbC5TKb3MES4OSITr/c=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208,217";a="83143555"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lg+jIcAXHcGZtJQyau0GZWo79r+KuVQutwPer2xVrHQhCYmPNupv3CBqNUOFKTKBb/OeX91XPSimPYOcx74qfGpxbm6NlCeJd2aKxVoFMSwwhK8O65g760U5U1KX1utfgo88zb/SI3b0Cj6peJQlGuhcsAyTZ/liK5uxo10AxI9zEzDPStdm5zNwMra/3nRv8EXYusM2npNYDG5EvihwrfZRwXkdPypl3lBXXHwk0inyromXrR2DPBtYNPwuib3DQby/91bt7XM6v9tl+yXrwLaE0PGGssMEySF70Qy8/TnjZijaMLVarROWUba5QgcYpgSz9OEUm0Fu5GwmhmNjmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZrNAD7hDxWjwb+MMEErtxcdy4MmdgrAl6LptHBDyi0c=;
 b=Jsthe6HW366ETCqVm78Iz6kFkNKj9dqplhwsQfkqW17Dj3J5pgeQsWPGg39Mx/LhPvzIw/OLujM6qWO0dOngBH43c1SlICfEo3KsFzz1iizvKjm5u2q1cE/zfOlOd0+j0JxmMgXk3n2RqnmA/p0octzlr+8XeYpndj0JoD9ljha5kVAsjDgApkIUMzMdqLwoGmG77SJaqqaB5C3fXLNx3ygmHPaAlbvVO6k04LptsvMij1ehAmwBYRuE+/dz4gLKEtprcFeKBp2fzDNPGyixHzBkMhf72azhx1036tuGRmoSAkuTJGa7dN7OdvdW/7jSOjIKMx/xJRqFZxrZHGItNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZrNAD7hDxWjwb+MMEErtxcdy4MmdgrAl6LptHBDyi0c=;
 b=k2Um9xqrw7bVjWtS1bhH94QEBgKIz7Qo6Zmtm8fMoAa82cXz0Ky29eVL9y4mb5LOOr85pzADcYZu0Wr4RNhRg/OMbJIlhN7R3xmseo7nVRFBph4QPC5MhZXLTdYvLwD3M6N8Jxu/t+vTJa2Hs63s+xCSyA6IlTp3mKnbfibt8EA=
From: Christian Lindig <christian.lindig@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>,
	Edwin Torok <edvin.torok@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, Henry
 Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Topic: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Index: AQHY5HiAcD24hk9GgUi1cSkdE1Fmrq4XL/IA
Date: Thu, 20 Oct 2022 12:06:54 +0000
Message-ID: <D2ADDC94-44D1-4854-B17C-A1D065E5D2FB@citrix.com>
References: <20221020113810.20844-1-andrew.cooper3@citrix.com>
In-Reply-To: <20221020113810.20844-1-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR03MB4172:EE_|SJ0PR03MB6568:EE_
x-ms-office365-filtering-correlation-id: 8ad65d39-7abf-4116-011a-08dab293948e
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 N6O6rasRenZNQdyecbL9PY+q5Fupfe+5vaaIiYRyVxPVHz/Y2/WsCJ2gpKoU13fVYRSeW3/u+oKJTgXS7SzjqK0iGf0hUGI07XpcNRhmriwijUh11Obkls69Ilm5k4/bGxctS2U8gPn+FjyiEBOZgGQgqvPWCMZN8jKv3jBR1UkbELXz97HMYXizzD3//HiiCl1Fasi8ul+vCPtvmeiSw2drgqIJ64WEr9MqnxVQurXuTkcB3g4GbenWvK/wgDztIsg3IIJ+euNyLgtuQuvJh4yWPYnTaQcGuxvagrPdsEZA+m1l9NfV96kW/vRVZP8ZFHQqOmpG26/TMCBr6gUHuF3MNQkKrrNT2NXiQHFw0ndzEcpx/WRiwVC6WbpDTXrvzY3JOu3BQBR5ZZ40e7j+0n0a4piz3ZZClWSYPjhvH37R5rWxrdBk71lJwZJMQVU6mQ6wk6xglzjIZB1llob5z+0zeqyji77nbb0VQ8kZg+FTY9EFggHDZcOtYQ1X9BSAfsiUH035tbg1JeCAipd12+9+z+ucgU4JZbg7sIqVIl3Lh7twqPEY7dhXnJU7tk09u6Y/T7rJuZMpbjj/vBzP/xYsaU7DVarl+L8qZD1TR05ioNxJI1FnKTIKHdZqoYQTYTdLbnrEWofmnXR/o/n9Cuvk3TMGKBieQb315xg6Iezl/OV/1hmuz+prkDcbvghVUqWkZjWNqFQlWwLX9VQlDORCi4jPjmkezNcArnQztr+5JShDsN7R3uSXYgg3/X0qerkRCAE+JAJtnA8ke0UhUdDQ3ON+5Y68MUrGeJ6gT2AxPpqDEmL1e3SgT673O0KLwZy+95G2R+HQ0E9IrDTcweCVJTSxgMKklEXROYdMlDOGiVk/dxHjysgAcMrJ2Gej
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB4172.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199015)(33656002)(6506007)(83380400001)(316002)(38070700005)(86362001)(38100700002)(44832011)(8936002)(166002)(478600001)(4744005)(82960400001)(6486002)(5660300002)(122000001)(2906002)(76116006)(66946007)(66556008)(66476007)(66446008)(6862004)(15650500001)(71200400001)(26005)(41300700001)(64756008)(8676002)(4326008)(6636002)(6512007)(2616005)(54906003)(91956017)(186003)(966005)(53546011)(37006003)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?eY72af/0jMYDTv/aUxDclkyWm9wuGN93OC5EDgsxYU7TN7YcPENmCuPbUU3L?=
 =?us-ascii?Q?JnBy/oojeF1NfSwEOdoWK7fj/Y0WYwHZY+XqwKMJFIMSBSWvcqHKrZu+MvML?=
 =?us-ascii?Q?uC3WoCLtiZu3QHbqvPUn4DIW8z/MD5RnvV9Duy5Dtkv81HjjnB2eAEXsJloc?=
 =?us-ascii?Q?K1EPP4uF/nDr+ndwlyIN2A2bUoYzvnOnLx5cZ/I8q78pTgQS8ftKvL3jdIHX?=
 =?us-ascii?Q?dm9NRhsf+ZWVkd9jLsb6QX8sOE+L/YLUcUbq8Yvrm1x8nHHHjPn6R1soyPhd?=
 =?us-ascii?Q?CR873eKu0jCpQEiif9nMDVXp99J4dFDvLxuWPVys+M+Na839N1Nhhx9l+20J?=
 =?us-ascii?Q?ChB0GbAK0JeBwJowo1Kutf2kyuXDBZvR9XN8KR1SacIQYoWTaf7hb7GqTFo7?=
 =?us-ascii?Q?rNHO53WPKHTeAwp2kaz3cFAIaot57ER9T48wegB3aeEPgaN5ttSGMVAIW0xE?=
 =?us-ascii?Q?ctW8pAw1aTOLIavNuAJoYzSdf+AyNWaz/GwmQTEkIuCL6GWfWg4lNt2yXzBq?=
 =?us-ascii?Q?P9KYVKlsCRPhqRmdqTfQR0HOp9BRguB5BHMXJEmXYrIvqfnVFG+8vVR0vRM5?=
 =?us-ascii?Q?D7dl2LriQbouWPwBGM/GU/Pd+VO7msZViNvCJR/6G/NjdcwFns3cPpUBk6Du?=
 =?us-ascii?Q?ZfJPNPrxwzMxJY4B4bPDzDkDu5pimzsgqW5kplEW4GpaAUDIDjs7tZ4jYFMS?=
 =?us-ascii?Q?AMp4d4eJqb7cF1V4tvXIiYFkTecF5iB6g74fzhr91NRkuepoU4XWJzonVrhM?=
 =?us-ascii?Q?rT+ZV3R527zeo11CFx3F25O8zM12pPnhR9BZ+Y2YYgZhIBWdmJ4a/G4XZUpV?=
 =?us-ascii?Q?uerkcv7ZhCFYhutEhTMQ0CfRpnhl8b2qFZulObnCbI+zmqOU9p/hNjOlJwPq?=
 =?us-ascii?Q?SYWuJW7SxMCQcuGxiadm1e+lj7nQzGy0YWPcomUPBLcCv1mFF1R5ql9wFSXR?=
 =?us-ascii?Q?mHtxTfHebDfK5baugWIG53yw6tjoCV4yIX/FAlJ03du9L5MFyiWCIS7xYJ83?=
 =?us-ascii?Q?OUO16gRmlY5JFdpZnObKKqdcKIQZ9dhfuybwWmdG2aZnOVw8xcs0HR9PZOpX?=
 =?us-ascii?Q?Cft/N7RIzVslTCplnUutNyitTg4CI1NMOFin8H5KRAANBDJRVEz5u9fw/fV3?=
 =?us-ascii?Q?yM68n63GKg1q5Zirx7IwuvB50JVXnO+oBh5HGu9yNgibF8eoPy78ubR+ocTH?=
 =?us-ascii?Q?Qf1OhnLVxi2bEDV7OUD/aPfyRevr0DBRgUnal9nQZaBeMylxadQ2HXFQYfP4?=
 =?us-ascii?Q?zYhLlJZ0PfTIX75WyrC+XhypuWiN/njaFf8Fz/5MwVYNCIoiMJVEE/H67eUN?=
 =?us-ascii?Q?J/IhE/2+y9PPrFez4AGgOJ5OqadPrCib4O19Xzu4LR/2glWbbTLp/xKAHiPD?=
 =?us-ascii?Q?Vzzz9+fCdm5yowOzkUMJp0QaV4q8hmzKYAsD7MNiW+qE5zSbDPIBfsOjs+2e?=
 =?us-ascii?Q?Qgnbqm2OIzBHHTrcj4Bvlx9XyJHSBaYLIrpXcz+fyfhLaUWkeopUr5ZhQFAC?=
 =?us-ascii?Q?7yUeL+OBQxBdyB0SXIOF6/ouOSWb0s4yy9rze+FmXAH2q37yke71laUv7Ebk?=
 =?us-ascii?Q?ltmyj+/Bu1l9QRDnGYxZ+4zjlxmKEvpOk7EjG3ByfVwaQphW3iGmRCBVpEwa?=
 =?us-ascii?Q?pfN4WQZDvAYxYfDjg/GwnZk=3D?=
Content-Type: multipart/alternative;
	boundary="_000_D2ADDC9444D14854B17CA1D065E5D2FBcitrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4172.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ad65d39-7abf-4116-011a-08dab293948e
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 12:06:54.8461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kkkyzSUspglUQKZjq++Q5KH942h5iBdLUPtNVmGIBNk3VHpyBeMNfhUD0I2Qxh5iA6wDPbIuwCTnekFKQKVMe1CXxn4gGxWz3/jb27xG2kI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6568

--_000_D2ADDC9444D14854B17CA1D065E5D2FBcitrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 20 Oct 2022, at 12:38, Andrew Cooper <andrew.cooper3@citrix.com<mailto:a=
ndrew.cooper3@citrix.com>> wrote:

tl;dr This hunk was part of the patch emailed to xen-devel, but was missing
from what ultimately got committed.

https://lore.kernel.org/xen-devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.=
1610748224.git.edvin.torok@citrix.com/
is the patch in question, but was part of a series that had threading issue=
s.
I have a vague recollection that I sourced the commits from a local branch,
which clearly wasn't as up-to-date as I had thought.

Either way, it's my fault/mistake, and this hunk should have been part of w=
hat
got comitted.

Fixes: 00c48f57ab36 ("tools/oxenstored: Start live update process")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com<mailto:andrew.coope=
r3@citrix.com>>

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>


--_000_D2ADDC9444D14854B17CA1D065E5D2FBcitrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <596D39167362E34F81E4B8EA0297C892@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 20 Oct 2022, at 12:38, Andrew Cooper &lt;<a href=3D"mail=
to:andrew.cooper3@citrix.com" class=3D"">andrew.cooper3@citrix.com</a>&gt; =
wrote:</div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Menl=
o-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0=
px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-t=
ext-stroke-width: 0px; text-decoration: none; float: none; display: inline =
!important;" class=3D"">tl;dr
 This hunk was part of the patch emailed to xen-devel, but was missing</spa=
n><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">from
 what ultimately got committed.</span><br style=3D"caret-color: rgb(0, 0, 0=
); font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-va=
riant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: s=
tart; text-indent: 0px; text-transform: none; white-space: normal; word-spa=
cing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D=
"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<a href=3D"https://lore.kernel.org/xen-devel/4164cb728313c3b9fc38cf5e9ecb79=
0ac93a9600.1610748224.git.edvin.torok@citrix.com/" style=3D"font-family: Me=
nlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal=
; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: star=
t; text-indent: 0px; text-transform: none; white-space: normal; widows: aut=
o; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-w=
idth: 0px;" class=3D"">https://lore.kernel.org/xen-devel/4164cb728313c3b9fc=
38cf5e9ecb790ac93a9600.1610748224.git.edvin.torok@citrix.com/</a><br style=
=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px;=
 font-style: normal; font-variant-caps: normal; font-weight: 400; letter-sp=
acing: normal; text-align: start; text-indent: 0px; text-transform: none; w=
hite-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text=
-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">is
 the patch in question, but was part of a series that had threading issues.=
</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; =
font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight=
: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-tr=
ansform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-=
width: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">I
 have a vague recollection that I sourced the commits from a local branch,<=
/span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; f=
ont-size: 11px; font-style: normal; font-variant-caps: normal; font-weight:=
 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-tra=
nsform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-w=
idth: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">which
 clearly wasn't as up-to-date as I had thought.</span><br style=3D"caret-co=
lor: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style:=
 normal; font-variant-caps: normal; font-weight: 400; letter-spacing: norma=
l; text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration:=
 none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Either
 way, it's my fault/mistake, and this hunk should have been part of what</s=
pan><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; fon=
t-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 4=
00; letter-spacing: normal; text-align: start; text-indent: 0px; text-trans=
form: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-wid=
th: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">got
 comitted.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo=
-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; f=
ont-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0p=
x; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-te=
xt-stroke-width: 0px; text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Fixes:
 00c48f57ab36 (&quot;tools/oxenstored: Start live update process&quot;)</sp=
an><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font=
-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 40=
0; letter-spacing: normal; text-align: start; text-indent: 0px; text-transf=
orm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-widt=
h: 0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">Signed-off-by:
 Andrew Cooper &lt;</span><a href=3D"mailto:andrew.cooper3@citrix.com" styl=
e=3D"font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-=
variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: au=
to; text-align: start; text-indent: 0px; text-transform: none; white-space:=
 normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -=
webkit-text-stroke-width: 0px;" class=3D"">andrew.cooper3@citrix.com</a><sp=
an style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-siz=
e: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; l=
etter-spacing: normal; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0=
px; text-decoration: none; float: none; display: inline !important;" class=
=3D"">&gt;</span></div>
</blockquote>
</div>
<br class=3D"">
<div class=3D"">
<div style=3D"margin: 0px; font-stretch: normal; font-size: 11px; line-heig=
ht: normal; font-family: Menlo;" class=3D"">
<span style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">Acke=
d-by: Christian Lindig &lt;<a href=3D"mailto:christian.lindig@citrix.com" c=
lass=3D"">christian.lindig@citrix.com</a>&gt;</span></div>
</div>
<div class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures"=
 class=3D""><br class=3D"">
</span></div>
</body>
</html>

--_000_D2ADDC9444D14854B17CA1D065E5D2FBcitrixcom_--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:21:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:21:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426699.675309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUYQ-0007Na-PP; Thu, 20 Oct 2022 12:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426699.675309; Thu, 20 Oct 2022 12:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUYQ-0007NT-Mf; Thu, 20 Oct 2022 12:21:42 +0000
Received: by outflank-mailman (input) for mailman id 426699;
 Thu, 20 Oct 2022 12:21:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bGcH=2V=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1olUYP-0007NN-N6
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:21:41 +0000
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com
 [2a00:1450:4864:20::62d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bbc07782-5071-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 14:21:33 +0200 (CEST)
Received: by mail-ej1-x62d.google.com with SMTP id r17so46914965eja.7
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 05:21:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbc07782-5071-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=IGrBQa4dKAVSu2S4BcOlLBn8S/NnavFLgJaicb8vQu0=;
        b=ZQpm2lcsli3QYI8c+XXlZ/PVz3ooW6w4b5Mmjq4S3wj2ZWs0gomnrAEswUfuVMSEcB
         eH24HXopl+ejc6j6q/xST8VBrxCaZYXtbEYUPmay04U2bKYOwf9a3pXlqchfvHgimGxX
         as0oF66ECDb/95M4SC8EA9Ok4PNFayvL7AQqqeHJE1HNYRygU07DNFiOxi4+xPxF0Td7
         w6NULbuuQSXju9Ujzv80/cNS10Vf8HrMlRdu5OYSFgeyeLtjYXYgKWdNRjL67GY8bz3Q
         +nrJhBhKiywK9iOG50lN3PB+JLhDtnXo99WNa8FWonU0GY2Uq6cgONd6aHAz0rRUptDu
         u4Rw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=IGrBQa4dKAVSu2S4BcOlLBn8S/NnavFLgJaicb8vQu0=;
        b=3AJTL64ahafqKMKVITZ6HM4xx6fg8UvxqTPT9K7RoJegjnYipLIu7PPp40FBEkEpZN
         GpB1kFkVAit/pNbmPNZI4ux7fcijdGAZwd6X5xt5Vp/zspKKfEjfOXvTsFQeeETFEGt4
         8OPEv1n2OHhNnioujxVge/drTqw/5EtQRAwRd4qcJ9S/lJHgue43goBc4aZkURZfvp3p
         Fd0fWShZ+N75yyX4t90PySfKKsMjfB57xw73NqmzERHH0XzuYKhLJEV78/u4mQXF7/KD
         m9ViXbxH8/V2Xv7hyzjijO6IXIxfvxELm78lKo8yq5GxHTGnVgiomiq0B0/T5RTuqgOP
         hExQ==
X-Gm-Message-State: ACrzQf39RvFNleg20ee2GOGajrCc6zeb1zov5oj6hcaUh9D2nUNr7Ui/
	gsbSo41uBzmnLfLfuBIXo8WwD89aGc7JWb85dWE=
X-Google-Smtp-Source: AMsMyM5rrYLJxnUL0QjcOxLrM4KH7p1BP8kgKiFJVnjNMqYfXBoY0qw73eoKLyoIKGqreJdS0nOkOF5NidYfzvwAPyA=
X-Received: by 2002:a17:907:788:b0:741:4d1a:595d with SMTP id
 xd8-20020a170907078800b007414d1a595dmr10552932ejb.737.1666268499744; Thu, 20
 Oct 2022 05:21:39 -0700 (PDT)
MIME-Version: 1.0
References: <20221019201458.21803-1-jandryuk@gmail.com> <87zgdq99qx.fsf@baylibre.com>
In-Reply-To: <87zgdq99qx.fsf@baylibre.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 20 Oct 2022 08:21:27 -0400
Message-ID: <CAKf6xpvHa86frvOp5L3x1nerTCQD=cjz7xqR4VwFBExquKG5bw@mail.gmail.com>
Subject: Re: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, 
	Phillip Susi <phill@thesusis.net>, stable@vger.kernel.org, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 20, 2022 at 4:31 AM Mattijs Korpershoek
<mkorpershoek@baylibre.com> wrote:
>
> On Wed, Oct 19, 2022 at 16:14, Jason Andryuk <jandryuk@gmail.com> wrote:
>
> > xen kbdfront registers itself as being able to deliver *any* key since
> > it doesn't know what keys the backend may produce.
> >
> > Unfortunately, the generated modalias gets too large and uevent creation
> > fails with -ENOMEM.
> >
> > This can lead to gdm not using the keyboard since there is no seat
> > associated [1] and the debian installer crashing [2].
> >
> > Trim the ranges of key capabilities by removing some BTN_* ranges.
> > While doing this, some neighboring undefined ranges are removed to trim
> > it further.
> >
> > This removes:
> > BTN_DPAD_UP(0x220)..BTN_DPAD_RIGHT(0x223)
> > Empty space 0x224..0x229
> >
> > Emtpy space 0x2bd..0x2bf
> > BTN_TRIGGER_HAPPY(0x2c0)..BTN_TRIGGER_HAPPY40(0x2e7)
> > Empty space 0x2e8..0x2ff
> >
> > The modalias shrinks from 2082 to 1754 bytes.
> >
> > [1] https://github.com/systemd/systemd/issues/22944
> > [2] https://lore.kernel.org/xen-devel/87o8dw52jc.fsf@vps.thesusis.net/T/
> >
> > Cc: Phillip Susi <phill@thesusis.net>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

This patch doesn't work and needs to be withdrawn.  My gdm/udev
workaround was still active when I tested, so that is why I had a
working keyboard.  Sorry about that.

Now the question is, which additional keys can be omitted to trim the
modalias to an acceptable size?

Regards,
Jason

> > ---
> >  drivers/input/misc/xen-kbdfront.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> > index 8d8ebdc2039b..23f37211be78 100644
> > --- a/drivers/input/misc/xen-kbdfront.c
> > +++ b/drivers/input/misc/xen-kbdfront.c
> > @@ -256,7 +256,14 @@ static int xenkbd_probe(struct xenbus_device *dev,
> >               __set_bit(EV_KEY, kbd->evbit);
> >               for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> >                       __set_bit(i, kbd->keybit);
> > -             for (i = KEY_OK; i < KEY_MAX; i++)
> > +             /* In theory we want to go KEY_OK..KEY_MAX, but that grows the
> > +              * modalias line too long.  KEY_KBD_LCD_MENU5 is the last
> > +              * defined non-button key. There is a gap of buttons from
> > +              * BTN_DPAD_UP..BTN_DPAD_RIGHT and KEY_ALS_TOGGLE is the next
> > +              * defined. */
> > +             for (i = KEY_OK; i < BTN_DPAD_UP; i++)
> > +                     __set_bit(i, kbd->keybit);
> > +             for (i = KEY_ALS_TOGGLE; i <= KEY_KBD_LCD_MENU5; i++)
> >                       __set_bit(i, kbd->keybit);
> >
> >               ret = input_register_device(kbd);
> > --
> > 2.37.3


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:34:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:34:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426705.675320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUl0-0000W6-UJ; Thu, 20 Oct 2022 12:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426705.675320; Thu, 20 Oct 2022 12:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUl0-0000Vz-R6; Thu, 20 Oct 2022 12:34:42 +0000
Received: by outflank-mailman (input) for mailman id 426705;
 Thu, 20 Oct 2022 12:34:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2BcH=2V=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olUky-0000Vr-NE
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:34:41 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8effd9eb-5073-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 14:34:38 +0200 (CEST)
Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com
 [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-554-rjRp3jgSNia0c5RrhCXmLg-1; Thu, 20 Oct 2022 08:34:35 -0400
Received: by mail-qk1-f197.google.com with SMTP id
 de21-20020a05620a371500b006eed31abb72so5162182qkb.6
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 05:34:35 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a37f903000000b006ee2953fac4sm6990779qkj.136.2022.10.20.05.34.31
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 05:34:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8effd9eb-5073-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666269276;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mt2w1QBu5mUEUGCycb5JqIv7fp2CZ53pt41k7x8rZME=;
	b=AxlcGBlj2WNIzlKfIEhZQrCgjToNi57Ri1TI8YKb8jxtzlyGxdwPgenidmg+UY76RnyWfS
	fUGQah2n2zJC1WMhUgOKD8rA9cwp1kgv0yto624rRkPDlTfUrfQS7NNz4Kg6/+WRGQZdnV
	iTITxG7nvL5Czr80vrFn5GUL4CXj6tQ=
X-MC-Unique: rjRp3jgSNia0c5RrhCXmLg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=mt2w1QBu5mUEUGCycb5JqIv7fp2CZ53pt41k7x8rZME=;
        b=e0ID2gBSuABJeb4L/KTIqLqNq9jC32JW4Luze4jud1gdZqHMICb+pnew2rkOI8zib+
         B/iVC0jxcn9Nhg5edgm417HPP7N9nUMg20P8pX3vEmZQI1sgmdEV/8FtdhQ3cpmVabrt
         BbR+APfalOD9GuJjHnDSYd7wts4VQpMFsOPt8nT4+ZP71axY6qlQMDtCC+gA15e1l8x+
         wagCkfCNyEIt74wUK8xOhCU+vPBjete637cQHtwtZd0cTxooMu33rB9j1jnedH45ytxL
         F0EU2f2+EWNyDxr/Dw61SHIiwFRXc4nuquu6DhK2KEQUyVPe9alD4Wp0/yU5uxoVqrj4
         Xk1g==
X-Gm-Message-State: ACrzQf105oGdhRQpbfdxTdQK1zoNz8g8z/518BZqsmbtVaLW7lcnElLP
	LTqcnhEy6RyfDFHLkoquxXu+QCg449y2eKc1p1W+YDsDDUqHKYF00RpdZoBKsBOw2clKBj5M3y+
	+7Fwj5ZjC1w2nOIVNG7AV6OGKSIY=
X-Received: by 2002:a05:6214:d06:b0:4b4:6bdb:27a with SMTP id 6-20020a0562140d0600b004b46bdb027amr10851275qvh.53.1666269274960;
        Thu, 20 Oct 2022 05:34:34 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7fP3HMuFXt7aawzYaT0jG/mMYGPxNNhF3lZwbpu5H0c20tQBtgdm2nu8Y1S5zCEHjhLEkyAg==
X-Received: by 2002:a05:6214:d06:b0:4b4:6bdb:27a with SMTP id 6-20020a0562140d0600b004b46bdb027amr10851260qvh.53.1666269274742;
        Thu, 20 Oct 2022 05:34:34 -0700 (PDT)
Message-ID: <a835b361-4b3c-6dff-05dd-9c0e7a1a3624@redhat.com>
Date: Thu, 20 Oct 2022 14:34:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v11 17/17] net: stream: add QAPI events to report
 connection state
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>, Greg Kurz <groug@kaod.org>,
 Eric Blake <eblake@redhat.com>, Stefan Weil <sw@weilnetz.de>,
 Thomas Huth <thuth@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Paul Durrant <paul@xen.org>,
 David Gibson <david@gibson.dropbear.id.au>, xen-devel@lists.xenproject.org
References: <20221011200539.1486809-1-lvivier@redhat.com>
 <20221011200539.1486809-18-lvivier@redhat.com> <87mt9u4m9d.fsf@pond.sub.org>
 <7eaa3255-7580-7e06-8b28-ae60ed5e1be6@redhat.com>
 <87pmemdcam.fsf@pond.sub.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <87pmemdcam.fsf@pond.sub.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/20/22 12:22, Markus Armbruster wrote:
> Sorry for the slow replay, too many distractions...
> 
> Laurent Vivier <lvivier@redhat.com> writes:
> 
>> On 10/17/22 15:23, Markus Armbruster wrote:
>>> Laurent Vivier <lvivier@redhat.com> writes:
>>>
>>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>>> is connected, and NETDEV_STREAM_EOC when it is disconnected.
>>>>
>>>> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
>>>> address.
>>>>
>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 
> [...]
> 
>>>> diff --git a/qapi/net.json b/qapi/net.json
>>>> index 6a1a49749294..69f83bceff3f 100644
>>>> --- a/qapi/net.json
>>>> +++ b/qapi/net.json
>>>> @@ -895,3 +895,49 @@
>>>>    ##
>>>>    { 'event': 'FAILOVER_NEGOTIATED',
>>>>      'data': {'device-id': 'str'} }
>>>> +
>>>> +##
>>>> +# @NETDEV_STREAM_CONNECTED:
>>>> +#
>>>> +# Emitted when the netdev stream backend is connected
>>>> +#
>>>> +# @netdev-id: QEMU netdev id that is connected
>>>> +# @uri: The Uniform Resource Identifier identifying the destination address
>>>
>>> Is an URI the appropriate representation here?  It's not how we specify
>>> such addresses elsewhere in QAPI/QMP...
>>
>> I put in the event the same information we have in info_str and displayed by the HMP command 'info network'. What would be a more appropriate reprensation?
> 
> SocketAddress?
> 

I agree SocketAddress looks better.

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:37:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:37:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426711.675331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUoA-0001CF-Bg; Thu, 20 Oct 2022 12:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426711.675331; Thu, 20 Oct 2022 12:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUoA-0001C8-8j; Thu, 20 Oct 2022 12:37:58 +0000
Received: by outflank-mailman (input) for mailman id 426711;
 Thu, 20 Oct 2022 12:37:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olUo8-0001C2-SP
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:37:56 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04292aca-5074-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 14:37:55 +0200 (CEST)
Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 08:37:50 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA0PR03MB5468.namprd03.prod.outlook.com (2603:10b6:806:b1::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 12:37:50 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 12:37:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04292aca-5074-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666269473;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/un6VEClOFwm7x7cbxplUj4ScOZCfgWq3hUabeMfFGs=;
  b=FOUSIeNtY3zVnnslwuauicu4Y583Hm+Qeh1MrEs64y4jUs0we3QErge+
   ZhVToMRnCFQFx1n72B7lXS/+0a/JQUxShDkmPMMfJln07PJhFZex87SwB
   fqXK9SKy242sRaYIs4UcvYV8uczvLW5ZPHOfIDCE8FIx7zvayu82eJ8WA
   Q=;
X-IronPort-RemoteIP: 104.47.55.171
X-IronPort-MID: 83172328
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AK+uGNqIodHx0xq1fFE//H55y2zyVRhNe4xP0q?=
 =?us-ascii?q?kklJ80ptzqEa7yP1Ac8D68u64Nik5vdqf7RNLSqVVbxnmaZA79hCNQ9ovWCc?=
 =?us-ascii?q?3KLehd7hyqqmtozZah+vgnCfLxk1pnDENKXd20SyO5sKQ3qsLa9Nyz67Hv7Y?=
 =?us-ascii?q?eG6ZJViJv8KTomB/ZYxKw2Vu+FyBBZdDTpI8DkyRp4x2GP44gGYJIIFcZgm3?=
 =?us-ascii?q?U9PDhdF6LayaeIYoH3ipfOVwwCxaJ3BbWd92jGvqBw+jkxo6xJwVXbgTtA7Y?=
 =?us-ascii?q?1UYdqJ6lTIu8o5AYbP+boPxBuyb0AjskvM5n9swpyUTQkKv7qDIzLVbJOm1K?=
 =?us-ascii?q?nwOlaZBf7Ks7MQFQunxcscXWqaWtwSb4HgCVPSevQkZ5UbG0TAFgFf2YApUh?=
 =?us-ascii?q?nmZdGdI7NMt9G2fVRqiVZzY391CiqmR6hTTp1/SBBplAXfbJNjIvFWehvh99?=
 =?us-ascii?q?wSne7G3xkU7Urdn1dApkprTNKHnyb6qMzujEtrFL4QLLYQu6cg3lIPUve7zb?=
 =?us-ascii?q?X09jwL5nc7hntJmM7/feLlTQ4Ud1l6BYNz0okU5GMBbOL6F+QcLg5xnAByCZ?=
 =?us-ascii?q?rlYYf14hiNQ1UTBu0WL0rMcnUUUmIxOWDIw+hCIC2CsG3ofdU5S1dsj/7AMd?=
 =?us-ascii?q?SZUSV0Dnh5r/jGW/sU46dFh6QCsVe+TypYuNe0xpdHNesr4oqmZNm1feZvVm?=
 =?us-ascii?q?Qu/7Upq74wi3cE23VIyPjEsKU0vVESFot1K662fwvCKFv7CCU51os+gQV1P6?=
 =?us-ascii?q?JtEHFfEa7e/wjuFu9cemGhlHSGuFq3CPDS5rwgG8/i4Z5mqGCI6uNqs2pDgd?=
 =?us-ascii?q?nsIJIjC68YO6QgpiaNHDMj1g6ecJhiAWAhv0EHI50YGqyLKguysrnZY47SU6?=
 =?us-ascii?q?Tzotn0p0N/Qz0uy/fwgbxcYurv7JhT8lYcguJ6v5fNviiSXE2n96ro0bf0m4?=
 =?us-ascii?q?0GDtQ6nw1CDu82YKtjRAd1O67Hh5gr/Ec1Iy1hcyBRmT9kfRcTs5YTNphJJ+?=
 =?us-ascii?q?YmdpjrqX6GgMjIhUj9A0YetcoBeBC45KaMCxz9e+6POjPzY1OGEQ7bbUeo/g?=
 =?us-ascii?q?qtSbsCaIDeLk17Lg1wpVt5w5pGIZ57epgsNndqkB+F3fRzQ06xDmssX57O3a?=
 =?us-ascii?q?/XvwnUK4NkSaIHMEXaDuAgSvTWkylPDCy46SeXqRoYrxtCyfBtNlsZPp3uNX?=
 =?us-ascii?q?L9QFPnWCfiGOvidN6cMgVezwNdiwgrR23F9q8YgmZCHYzQ6JO7UOmpnnFtb9?=
 =?us-ascii?q?NxuS1QR+lG8Bg7SV9eDizqCqiO5qzfm2Y5dARM7l2UIzQVKfjUfLkEbC18Zm?=
 =?us-ascii?q?8piMZT33OzO3IoNqiD/BtMmR9XZGL8TKLqQm527fJUMFcEWXVywegAGpfwfd?=
 =?us-ascii?q?xz+h8DBn119iXVyjIdWaB+5JSjO9gYNNhA8EpyXehv72+2Vt9fREqeQPbS3n?=
 =?us-ascii?q?/U6im2Gi8A00tno8Yne2JCdTI9oVvtBcWg+YlhRTf9l2v/u3vmCZuTQD2Vq2?=
 =?us-ascii?q?Fbo49ooUlyBkB9NNDwQd9DFK97isiIMpmGdH1NoDHlLiwbJIW7GvwCIuyiMf?=
 =?us-ascii?q?KIb6IdZYXRGAZ5XNcc2O2+FQyBipON2iduYa/MvJkWjy6lGIX4+KaQucDWeb?=
 =?us-ascii?q?CXGxgEBhMT9U+B1kdG7ittbl8aA3qbg5BwaigYSnDldYy/9A1sBQrGXhKuQX?=
 =?us-ascii?q?uB+SITIiySg484dBPrTcAMBRC2mHmgbiM3dT9oB98vgaX9NUIvmoRr5xmnqt?=
 =?us-ascii?q?1IFWuK/sVT8VWE17cQ3EM5D6H1mXc3R8SpK3GNBWYdfapPj7kHYapNvtyKVI?=
 =?us-ascii?q?/ePe7aVV2NglwctixSW4Ey07d1Gcc81ljmuY+VQ55BI0RqSwWCHhox4vN57V?=
 =?us-ascii?q?X/O/m0VslVxXUpAFji9Szos9j5xgbLLNl0eHR/68nPH60R5v2uCZlQ/vziSj?=
 =?us-ascii?q?uxHUx7eqV8K7NEMYFaAGDNW5BPZ6IH43R2znXsywLNXO+UMsgq+/+ryq3s2B?=
 =?us-ascii?q?fS3vbkdvtmd2KlNpYl8I7vfU6s3Kl5ozN4dU3miJRBCH1YAj8lBDejKt64qZ?=
 =?us-ascii?q?Tv3a5bh8qhzbLt1RdnOo6Hj2T7KtcM57NoBZBcHAuiem7bAV0ENu5iASwY5x?=
 =?us-ascii?q?tl0/nc58y7VriO8MaKOfNB4y2p49havxGtdeUtEmX7uNoocJduMSORyL8k8X?=
 =?us-ascii?q?OIoVs76b+TjRyWEoficyKMdN4JmMz1ip/f/h34UhLc9Wx28ilIvsCwX2yz+P?=
 =?us-ascii?q?5OqSe+SEDtsumXPxzzjomPvIp/m+ZzIBAyZxvRW4S4gMcA7edTqOz6AJ+XBK?=
 =?us-ascii?q?UsSSMprRoSFAMuVV5G9kCg/Vm3cV0H7IUdM2GQu4Bp96tfahqx7F8tPDPLu5?=
 =?us-ascii?q?xeGPEueEx/xl9nK6js=3D?=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83172328"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lawLpx0dpbin4ZI2bGqJ0lLCRVakDHjiZdhApLT/EOaUFsoaJeYVC+vBQhS8vkdH1rXVYl3y/eiYCtMVPDNuCmUbcH3Q5ZXVuvjvqtzy2GVX5hjpsH//y0Wz0ImQAE2cozvAlLq1xLEt/jbKkhmB6+d11Wgbo0Pyb6DmvtXsJgMtoZYXhQeVzITTgx+H8R//2XQa0MBwn45mBXrix/51PWmlePvYhgr4n4yfo0MfTnlCL72MfpzW62B4Kdb2r+XDc1Nj3bOQ/0MH3qNITgjdADpNL7WPRBZxhIPJsptgHN+sydrLw7hWV62mMqTKjp2eGk1HLyGuH4wmuWXn3m88fQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UVFDYb/qQDQOUHvmwog2L/8QbdFFGV3QOgAsYVTKyLY=;
 b=BaV0b3Iy/n5JOtOHrskGa7P25KVhxkOvdu1wEjnOqJFK1cDL0vxpngZ+zfyA32mfCt4SFrXsbivwYTbGtDzunPkoaJecbp3XtPtNN9V4teYR2c2zVqEpqwm24GN+0H3zCIOvxHHBuInsKqaKZEhHaDpwea9ZGRJtV6WFsub1ScF+xwQ95s2WPGzKSekCNjxbZkSR4KRzBR86sQrgfpU2tk802/zTLCJTDzTUiH9ndpsx30YY+oimwQW+NogrtTUhPV9gtQXy5CEPR7QL5im4wr85dXVKtAOahMupZwfsvLIMJUX8npH3BAew3F2UY3OFvrwj9sy8JngySgeePR3iDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UVFDYb/qQDQOUHvmwog2L/8QbdFFGV3QOgAsYVTKyLY=;
 b=fDJm9gB4lnRQOyW+w8Xb9+10QZFndX2HM1On/U8IMXoA4Aab4JjK7rlcwzfLDLR/4UYns3qjRFeLmiKzZfbTfKwJ63lckL6K6LK90UmNyvIFimE9slSWIEMZ+ZWByXzjML38BgXuuNuI2I5QCmV7XYfWG8vuj3Ms2uqp7pEybJk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 20 Oct 2022 14:37:45 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: Intended behavior/usage of SSBD setting
Message-ID: <Y1FBGTx5cSrkdVbZ@Air-de-Roger>
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
 <2f5ec31e-2ac5-2b22-8801-9ebdc4946962@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2f5ec31e-2ac5-2b22-8801-9ebdc4946962@suse.com>
X-ClientProxiedBy: BN8PR04CA0029.namprd04.prod.outlook.com
 (2603:10b6:408:70::42) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA0PR03MB5468:EE_
X-MS-Office365-Filtering-Correlation-Id: f6c37271-d574-4ae5-084b-08dab297e5fb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zoUEawQsH2b6fjngw/2Aw56TYKg8qQwsmc79QFGIbSSaeVScFp0NF7GrWl58ixAjg3VXmZZMSeX1UeGWyPk6zm1xvpmWyD3mwIUnuypeGhHPKc25I8iiTxPKh0fkNd36BU0g30vi+IZK+3jkYilEeNRn52pwgI+S3gz2Q9piaMqHUh6PTY+WN6qoBBRB5y7WyIrS/6f6kKgP0sV23M1eVKZaasGBuGAoaGZS+Cj6mGPRsfSkjlAYZ2egDTINPWvXF9n4UhMCMOBMyclVNez0JiJ6VpBIT5Z8zLbyS//LouD+fXOIKp5gjRZhQ09MscIardOgeG+b2gWTa11MhuUn2hNsTlWzogpzMvyxRwW8q5OPwcGYAsNY72UcSha6w1acGta9R2hrANzQE0r6n9X6kNV0Wc7qZPrirSeHyqfWXD1uZdGQBMlMkJQfEgI+gV7NSf+MpxPH5HwNiaVX6ZrEa+vYyOVKnHUYqHA3bsYMPqyI786D7S+dSpErzkgn8KggOXM0F0oFVjjfOetkKnBSPPrOpfLx6BWZe+cpwqK5ymJlhDZNadva0tyMJ4E+V64Fmun06fs+G5bQ6f59znodsP8m+jPoiKgwSrUmpQbLuQYa34xP/xxcuzk6q+EWam6z5Vok8J/SyWp44HiyCr4J9LH9SHw0Qv/y6dOAxRAUj20TFMMGZaPmwPULhpubJ/mEgYYgaL+BgC9EeKgBP+39+A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199015)(26005)(8676002)(66946007)(4326008)(66476007)(66556008)(6506007)(6512007)(83380400001)(41300700001)(85182001)(86362001)(5660300002)(53546011)(316002)(9686003)(8936002)(38100700002)(6916009)(6666004)(6486002)(82960400001)(186003)(33716001)(66899015)(2906002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eWJ1YkFZenlGalZCVFlLd0ZPcVJ6a21WTXNHM1VaOThSK2QwYmRrSXVwTllp?=
 =?utf-8?B?QVByck5vNFpBdzl0YTkwZEQrRnluRmszS1l2K015dzlCTEk4K2lqME9kaWFN?=
 =?utf-8?B?MzJVMllReTYxUk02WkVqdjdrMGZLVU9YM0Q3dDkyblhlVUlPUThwL293WXlH?=
 =?utf-8?B?Q2NBOEF6ZVhOYkpmR0J3Ujd1dWMxNnJtZFN2SHdLaFhOQzhsRjcza1cyazRn?=
 =?utf-8?B?VHFHUExlUGY5Mktib3RscFlRVWJTQnE4SXcxNjBtdnFIVzl3Y1JvSG1PVGtx?=
 =?utf-8?B?K2dQYisvMFhmbFVJWXVORmVzbHp3eFNxZkZJS2lsTVovR3cwN0pvbDFXRUN2?=
 =?utf-8?B?WGg1c3YwRndKT0RaNk1pRStpVFozTnpPNHJkSE5wTlNMbW4ydjNkcGVPTGtw?=
 =?utf-8?B?SDF2VlF6cHhyT1NIVE10S2dndDUxQWp0cVpHbWhMT1BMWkYzZ3prcU43c2ln?=
 =?utf-8?B?WGlrYWNqbDl5YVY5SzFpY2Rid3dpMmcxYzcxVDVQZEVoQ3YrWGZYSXJBOVFi?=
 =?utf-8?B?TUJxL1pJQU9jS3ZXT0wzeXJ1aEVBWFJaUHROaHFTSGNqb0FSS2JrVkcyQ3BW?=
 =?utf-8?B?cE93Ulk1dTFISWIzczJORUs0eHltWHNuUVp6SjZiSmR3YTFERkw4MWdFQ1RI?=
 =?utf-8?B?WkR5bGFlb2tKRWs2V3FGVVhrcXRKYUs4b2hpUGl1bWM5ZmtvMFVrdUJzSk8v?=
 =?utf-8?B?WWdKRWdFd0dkU2tucmd5Qnk1R1hsbDdxN2NJeFRkeVU4dkFaVUM2emx4SExH?=
 =?utf-8?B?T2NRU1o4R2ZlMjU4U2JKZTUwMDQvVGk1Y2d3WDlhQW1wSnRBY3NjTU9ITFZZ?=
 =?utf-8?B?QXh4NXdTcW9Vb21DR2tHdEZabjVmRVdOL3oxWFd5OXE3M1A5QnZsSkRqTWdI?=
 =?utf-8?B?NEh3MStKdnpTMGUxUVZjUllCNzI3UE5EeWJyWjZlWXZ6cTVFVGN6OTJzZnhj?=
 =?utf-8?B?WEEySWRpbkx5d3dEZi9WVTdadHNzZ1VQVGhJS0t2a2NUS3N2cmUxTWdIQUs2?=
 =?utf-8?B?RmQydUZCMTZRK2NOU1BEK3ZYZ2pmUXdqVzY1QmhmMFdKaFlXb3dBZUQzS3Ba?=
 =?utf-8?B?di9qSlkzS3VPZXc3RE5XWTZnNjBMZHZBZFdYdkdRUUhVaTh4eXVyVnZlc1Ny?=
 =?utf-8?B?cG5IUDJvN1FJakFpMmp3R3ovV2pXZSsyemVVRTl2TC9yQjlkbDJFUUp0bHdh?=
 =?utf-8?B?ZnN3Nk5GbGQreHEvbDBqSGFiWVlEOVgzWU9RbG93V0hNZTBqVXhReUFDRW9V?=
 =?utf-8?B?Y2lGbjh1V0twSGJScDk1NmE1NXViWjdQTXVQa0hvaGJFcTdIV1EwcjhUaUhF?=
 =?utf-8?B?b0k1TmxLc20yUnBwM3pNeUZURmNNR1k4eWRTMllxMGtHbjIyQklCSFd5MTdW?=
 =?utf-8?B?Rmg0QW1EOVhWeVF5dHlxMlNUemN5dGdBTmZhVk0yZERlbWQwaHNBUjhMZHZF?=
 =?utf-8?B?ZlI2L3drUnA3WWRXcmh1akFBa1hRUUE3WDJyejd6SFdqRXhaMFpuV3BTSGlH?=
 =?utf-8?B?ZDRCVnZidTZ2b2FPS21Sd3NJTlVmbTNNbzdnd0ZYMDUvbVpzSitVRTZONWRU?=
 =?utf-8?B?aDNyYXh5K3FWS0tINTVES0E0R3dpb2FkNTNvSUhUdEZmQnhzaDNPTnYrdCti?=
 =?utf-8?B?Wm1lMGN6MHdUMm0vWDlCYVlQN1N5Uk1vM25LQ1FCdHI2SmJtNHhwVTZtK3Rv?=
 =?utf-8?B?Um1oUEZXYnNkc0VFVjRDVlZXcmg3OENaWGFCK1lxb2pNQ2FxVm1NVzRhQzU5?=
 =?utf-8?B?OGtrYzIraWRYbjM5Um1GeFBHcU0xWlhUOHlrM0N6ckwxZmdib3l3QVZ2a09O?=
 =?utf-8?B?eXJxL1M3allZRjdQaVRTc0NrcktWWXY5d2w3LzVsYXJMaEswZWRYLzhPMU51?=
 =?utf-8?B?NWRQT1hJcE9jSXRUcXdpamx6bkFRLzVPaHJ2cll4VHRtNGwxOThtV3JPTjVq?=
 =?utf-8?B?NlVXZjZkUEQ2UGlBRHp0NnQvc29zSXpaaHNTcW5OeWlwbnFreTlkY2RydTlZ?=
 =?utf-8?B?NER4VGx2cGFLYlNBWTlUU0NNQ2tiaFptTjkvWVVWVFBVeVBrejZ3Y3RVVDk0?=
 =?utf-8?B?SjZlTUplTExzMHFaOU9pdFZ0ZHZzKzJsNWtSWE8ybnJBYUNMcVlSSUIzUWNp?=
 =?utf-8?Q?knKEw8Ow2ZMePcRmsPvHSioMU?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6c37271-d574-4ae5-084b-08dab297e5fb
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 12:37:49.8492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Yxab0on7kxZAqmaGIApQAsQrgoTjR1IEb1M+ZG4Oj92iSl+LGrz3Syh4n+YIr1Z50B7UaSqf8xWqLz2jzwdqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5468

On Thu, Oct 20, 2022 at 01:22:20PM +0200, Jan Beulich wrote:
> On 20.10.2022 13:01, Roger Pau Monné wrote:
> > Hello,
> > 
> > As part of some follow up improvements to my VIRT_SPEC_CTRL series we
> > have been discussing what the usage of SSBD should be for the
> > hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
> > that has an out of date description, as now SSBD is always offered to
> > guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
> > 
> > It has been pointed out by Andrew that toggling SSBD on AMD using
> > VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
> > have a high impact on performance, and hence switching it on every
> > guest <-> hypervisor context switch is likely a very high
> > performance penalty.
> > 
> > It's been suggested that it could be more appropriate to run Xen with
> > the guest SSBD selection on those systems, however that clashes with
> > the current intent of the `spec-ctrl=ssbd` option.
> > 
> > I hope I have captured the expressed opinions correctly in the text
> > above.
> > 
> > I see two ways to solve this:
> > 
> >  * Keep the current logic for switching SSBD on guest <-> hypervisor
> >    context switch, but only use it if `spec-ctrl=ssbd` is set on the
> >    command line.
> > 
> >  * Remove the logic for switching SSBD on guest <-> hypervisor context
> >    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
> >    hypervisor code with the guest selection of SSBD.
> 
> * Give the guest the illusion of controlling the behavior, but run with
>   SSBD always enabled when "spec-ctrl=ssbd" is in effect.

Right, I've also thought about this option but forgot to add it to the
list. That would limit to only allowing enabling ssbd for the
hypervisor code, but not explicitly disabling it, ie:
`spec-ctrl=no-ssbd` won't be a valid option.

> * Give the guest the illusion of controlling the behavior when
>   "spec-ctrl=ssbd" is in effect, running with the OR of guest and host
>   settings (switched, if necessary, as vCPU-s are context-switched).

Right, this could somehow reduce the number of toggling, but would
still require having code to handle guest <-> hypervisor context
switches.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:45:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:45:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426717.675341 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUvn-0002gz-5K; Thu, 20 Oct 2022 12:45:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426717.675341; Thu, 20 Oct 2022 12:45:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUvn-0002gs-2W; Thu, 20 Oct 2022 12:45:51 +0000
Received: by outflank-mailman (input) for mailman id 426717;
 Thu, 20 Oct 2022 12:45:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZuZ=2V=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olUvm-0002gl-By
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:45:50 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00078.outbound.protection.outlook.com [40.107.0.78])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e9741f6-5075-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 14:45:48 +0200 (CEST)
Received: from FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::17)
 by DU0PR08MB8731.eurprd08.prod.outlook.com (2603:10a6:10:401::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Thu, 20 Oct
 2022 12:45:43 +0000
Received: from VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:48:cafe::db) by FR0P281CA0053.outlook.office365.com
 (2603:10a6:d10:48::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.15 via Frontend
 Transport; Thu, 20 Oct 2022 12:45:43 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT010.mail.protection.outlook.com (100.127.144.228) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 12:45:42 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Thu, 20 Oct 2022 12:45:41 +0000
Received: from c55d6201c179.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8ACFCC80-9DAD-4C22-9E71-CFFC4DB1CDF6.1; 
 Thu, 20 Oct 2022 12:45:35 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c55d6201c179.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 12:45:35 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by VI1PR08MB10274.eurprd08.prod.outlook.com (2603:10a6:800:1be::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 12:45:29 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 12:45:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e9741f6-5075-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=RpKTVGyyWt3Umr7DeAHm0y8oIUrzFuv+zPFLHpKthDZOLoTJx4IyO98zqSoIKfVF181s4EaK8N02OYmpZxZ28TK4GyqUqie7elzY132Qsga1IZnSrYLZgpEVA466z7aXgu14qlFEU7Em0T5AFjs8R4sVFBkLkp2+9YRlCMUIz7tEspK6Lxx4re+aIp9VOaYfDVxGcN19isl/bKg8AvLL4NO/rTTzU0RivGLRX30gO0/78iMmldjMKioBjbMEooZch++6hnh9Mz+YH6zhYY587wHmZr7/jJx++K+168GLVpAnoOpqCVDJ08lK81qWJPXJVxazHkpXgmEm/ClCw4St5A==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VG8yU+u748vLik9EGxDwwv7tyZtNd19IyC3/160ygFw=;
 b=aAA5hc7/Tl/1GtZjNo0IKwzw1/e9vGJ5mf+vJOCh2GqNbeiEumataKLnbwawjA+XJpM32/gIVLkv12NBNbD76s/kKUBJN/uVu25tczZBMViCAvS6lnUZiL5cCCUUCSRdCGO55tPvjsH4++PtDgksaQslGorkbouVNjxNhh52oAbM/AqDGm2dPu2xRPAAnFUvh8HKDiogY/+fshlV/VeSqNEIgzO9laDyuXkQcDpIEcACOAcjlA+fkOGsbQBjWvbIVh+zOBCoIOIIUW2fZTpj0IXjKsTCa3rcZv9dKtV8wKJs+FUL7vZZ1peALyWyK8dtv5zfxOXCDtoqCLt+jWEybQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VG8yU+u748vLik9EGxDwwv7tyZtNd19IyC3/160ygFw=;
 b=xClaMemPw6dKvlOtXhexjo2NvtTppi0lvjJVgZNBzoOAJIOT24+H2oVQDvLhsEh41wVnFc31Tz0l4qgsHIEeGM+ELoXsa8oL8rBqSfYbGnb7DWo9kr2rSGUd3Pho1Xk4vbfB3PDFsRNft+qXbey4p6ntTZyebsK/lrfOKpbaSRM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PsqqcgfFBZ1x7VuUG/0TcQxQtDYh8ld9fGLZP2aOWmGhQQmALKyhA+nW9wyNm+jqh9r2O/HGHlvC3nPtMxfY1sBqN/QbDyMNSKmxN8nzIWy+El7VSSde8p4oVu0QiDT+URUeAQBp4S0MUQdVDbs8MyijOGl6NDM2pVflC/P0sM5aB3E931GK5CsB7GNiyWA6iQ25oBpSPXuNiRYm8e5pTAtjv8lIjeRTrH2LRkRlE5V5HTZiwSzWq1554fnzsxG6w9yR9XblOApOMmBK/zcnypwHBWj3iFPOQjxCQgzjTCNjgTDtTRygfQ4aiRSzvi7nIUYazPp7SHvaTjWgqUCB5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VG8yU+u748vLik9EGxDwwv7tyZtNd19IyC3/160ygFw=;
 b=MhWtGWTfVRCcFuGJxG6/7HXZTq1XJYmgmrroCWYAXpdLxaA1r8fELRAPG7ew+P5Lr0e3eaCzCzT4eBhMf/jtj5M69z9YynA3OnRLmbvrGIG63u6HKd8MQrqj9h6zpqTY2FEUaE5EE9c4CDwUKH/Yfo1b1McY1DXQvU+uto17iPUBpuDkWaiu8mRzwWH941i3Nxsc8UYknrcDBmVNdblaAKJu9EaZrb2xQX/2hLOtcKd2ZgcrH5ieeCOB+IEU/viChWuA86UrdGzUwGFFPcmRjQ+NVr5+7walGohqGxhAR8Dy7lQiUSrqoQkGLuiP7153kZaQgNVDWd0uI1DcvsH1iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VG8yU+u748vLik9EGxDwwv7tyZtNd19IyC3/160ygFw=;
 b=xClaMemPw6dKvlOtXhexjo2NvtTppi0lvjJVgZNBzoOAJIOT24+H2oVQDvLhsEh41wVnFc31Tz0l4qgsHIEeGM+ELoXsa8oL8rBqSfYbGnb7DWo9kr2rSGUd3Pho1Xk4vbfB3PDFsRNft+qXbey4p6ntTZyebsK/lrfOKpbaSRM=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
CC: Christian Lindig <christian.lindig@citrix.com>, David Scott
	<dave@recoil.org>, Edwin Torok <edvin.torok@citrix.com>, Rob Hoes
	<Rob.Hoes@citrix.com>
Subject: RE: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Topic: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Index: AQHY5HiMx9pkqyzOUUCkjGjpajJVHK4XOlXg
Date: Thu, 20 Oct 2022 12:45:28 +0000
Message-ID:
 <AS8PR08MB79914FC06AE997ABF32780E4922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221020113810.20844-1-andrew.cooper3@citrix.com>
In-Reply-To: <20221020113810.20844-1-andrew.cooper3@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B9EC29A6B6854E4CBB8A528FF127A10B.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|VI1PR08MB10274:EE_|VI1EUR03FT010:EE_|DU0PR08MB8731:EE_
X-MS-Office365-Filtering-Correlation-Id: 686b274f-2790-48c4-a431-08dab298ffe5
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 rTkZy1ZUMqJ5ZWZn3W47XMzMUusrgOFXJaRF8qYszliwCY0JzFjA2iPXQcMqm0ZQm2u8gFLrOWm0n4LCr0MZ69of9cEUEL7uUTIPy//nL03HwwXrNumbRMj50xxmXL1xHxSzZTqJDk9GZ4S3JFYrU1gzsvrXv66TUuuJVHv51nA7t4rRuKv+jMeGThY9w0Y7FDqWMFOfRWkdE0g7PCBIK8wazkGamqCgywekawYWi0G0YE+51flzU7orPb4UKpdfYdWgjwEDD75D+/DRtL82g5XOIEmIlHcWrD/xfi8sadE9krXAm8SnpIR3f9dQYey/jNV0guDd78eJ3z0SekQcx1t0yzs5Yz/GwRnRUvnfg2Zv4fAGXoRHkBicVtiInKcBEg2HQH9Cv8nAnlJ1/UzfrVHOB/i0l7pO26uHdsUyPGkWKHuW11bvr3R9zwvbZNzpVhbeDiVtgcI9ZX7Op4o4zYq0CmQgIuOUeJ24E7DOmoZeKO8srWfyWGZp9TNSahYKMBLO2hEM5+0+H9JzzkLmodGJwIrrNNVKafgditx2Wq3CbwYABMZXBX8OgaIxAs0ua3GqVylThOZ0JLn7qd5zvexrz60O9s+JFDBc/RRzOGogagxOzRrz7YUDljNKZvzh9yvURL91eLnAYLA7n83XqDW6E5V2Urr9Lr7bznFv+BO14Tc5nF9u2qMh1ANKP8QXPpEZfizm2cDsMzupL2pOWM9sEBhUdtwVHEkaikCOr5WCU5L3/33AUO39NdL65Qjl4ys/pqdFsJH1g9pZ7YbOPOTz+qeeuuS4BsL2LQB0M8g=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199015)(33656002)(122000001)(15650500001)(86362001)(2906002)(5660300002)(54906003)(186003)(83380400001)(38070700005)(4326008)(966005)(7696005)(316002)(66446008)(76116006)(9686003)(71200400001)(66946007)(110136005)(66476007)(478600001)(52536014)(55016003)(6506007)(41300700001)(38100700002)(26005)(64756008)(8676002)(8936002)(66556008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10274
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	083d2e24-9c2a-4594-8a6c-08dab298f7e0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fraMnMSVfSnOIRRRemHOrdwkVNteXJdl6kpwFnEM3z9qudUgQb4ce7Tlk/D0Xp2dz8VY3M/mS4ETw/ENQMZkIuB8NxVNgYy5I1GbaSzg8zw6DobztFgv1C9SdfuOPLykqByX3/QZdBsHJsIwU77sUfJ99/vh/gNqqGQSD6x4F+VQltcypNuOSzxvwmz/ysUDWMXX3jhifG0BVk2dB0dka+7ANd27HIg6BUIlO/4sUECCk+hHdLuP93auOa7kwELCzzMGLU7jstx19qjO15dDfFnereYXuyUmWQzR85zrEk2adJaooit2CtZTn4ricISHrXI+xN7ScgEpNqV52r+0VvKzYFovGOtwb2aU+Dj6wwjh4915uyLB+RtfGCEpifHO9fm2b4qrhy3aknQS65ofOsVi8/eSiGoIqqJ76mkt1MIIiGP8RR6yA/iPSOE6z7W2+ErQ1MjeuO7yW7ku6eOXHTpsOouXTouqphYC9N3sSDD3UHJzBl3DiSxQ/O23ZIN3K3SlJZGVi4w+uVMo8GXZY++7xPQWMB/tb69S8+x46bHDOH8IRx0+sA61S7G5IcoONP9iZmjrkFPtfgtZ3rLYFr0jakR45szAjdmt+tFBp9YCky/TOm8ZxnlZjpCv4wyHdTZqP/03ylfV9/zUMwNdLQuY2jEYeiheziSxzjg2bll2aDxhiL2sUxDq590EytvSmhJGlXZky/Tbj6wdNmtjm4koMBg98wDu/OnZ9Skdb/AXCu8W4DoDq0cG3rn1sFvBKC59w1r902D+hAhplX1omDnG87JPAMHprjVf5lTpklg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(478600001)(110136005)(54906003)(966005)(107886003)(70586007)(26005)(4326008)(9686003)(70206006)(8676002)(52536014)(6506007)(41300700001)(15650500001)(5660300002)(8936002)(7696005)(83380400001)(82740400003)(82310400005)(316002)(47076005)(186003)(2906002)(336012)(81166007)(86362001)(40480700001)(356005)(33656002)(40460700003)(55016003)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 12:45:42.3109
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 686b274f-2790-48c4-a431-08dab298ffe5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8731

Hi Andrew,

> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@citrix.com>
> Subject: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
>=20
> tl;dr This hunk was part of the patch emailed to xen-devel, but was missi=
ng
> from what ultimately got committed.
>=20
> https://lore.kernel.org/xen-
> devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.1610748224.git.edvin.t
> orok@citrix.com/
> is the patch in question, but was part of a series that had threading iss=
ues.
> I have a vague recollection that I sourced the commits from a local branc=
h,
> which clearly wasn't as up-to-date as I had thought.
>=20
> Either way, it's my fault/mistake, and this hunk should have been part of
> what
> got comitted.
>=20
> Fixes: 00c48f57ab36 ("tools/oxenstored: Start live update process")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Christian Lindig <christian.lindig@citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Edwin Torok <edvin.torok@citrix.com>
> CC: Rob Hoes <Rob.Hoes@citrix.com>
> CC: Henry Wang <Henry.Wang@arm.com>
>=20
> Found while reviewing the XenServer patchqueue.  This is low risk for 4.1=
7
> and
> fixes a feature which we thought had been working since 4.15.

The commit message and above scissors line have described the situation
quite clear, so I don't think there is any reason to ignore this patch.

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


> ---
>  tools/ocaml/xenstored/xenstored.ml | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/tools/ocaml/xenstored/xenstored.ml
> b/tools/ocaml/xenstored/xenstored.ml
> index d44ae673c42a..fc90fcdeb5d6 100644
> --- a/tools/ocaml/xenstored/xenstored.ml
> +++ b/tools/ocaml/xenstored/xenstored.ml
> @@ -352,6 +352,11 @@ let _ =3D
>  		rw_sock
>  	) in
>=20
> +	(* required for xenstore-control to detect availability of live-update =
*)
> +	Store.mkdir store Perms.Connection.full_rights (Store.Path.of_string
> "/tool");
> +	Store.write store Perms.Connection.full_rights
> +		(Store.Path.of_string "/tool/xenstored")
> Sys.executable_name;
> +
>  	Sys.set_signal Sys.sighup (Sys.Signal_handle sighup_handler);
>  	Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ ->
>  		info "Received SIGTERM";
> --
> 2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:47:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:47:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426723.675353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUxQ-0003LU-KN; Thu, 20 Oct 2022 12:47:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426723.675353; Thu, 20 Oct 2022 12:47:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olUxQ-0003LN-HO; Thu, 20 Oct 2022 12:47:32 +0000
Received: by outflank-mailman (input) for mailman id 426723;
 Thu, 20 Oct 2022 12:47:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olUxP-0003LD-VX; Thu, 20 Oct 2022 12:47:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olUxP-0007g0-RL; Thu, 20 Oct 2022 12:47:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olUxP-0003Ea-AC; Thu, 20 Oct 2022 12:47:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olUxP-00014S-9h; Thu, 20 Oct 2022 12:47:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+oGMEqPx9HtrqYs76T6yiJ01TRSQ7xerjNYL4en/f6M=; b=5IUeVwc5g8W61iXsmhNjStfkK/
	OQm3kO1qWUUsCEuwt4t1vY2+G/OSjwne6+eylGOMsfcvdeTcx/NjzMihIb6j2HhpiqalQRTO+KDO9
	O1LLoRMpE2nzzeG3CizTJjL6QSXihvUhNw/PVkyrpxiYaUbOTs1YwWXMmlCfh2Uz4X/U=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174078-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174078: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.14-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 12:47:31 +0000

flight 174078 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174078/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173906 REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173906 REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start    fail in 173906 REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174078
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174078
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174078
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174078
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174078
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   65 days
Failing since        173496  2022-10-11 14:08:01 Z    8 days    9 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    7 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 12:56:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 12:56:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426732.675364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olV6J-0004rT-Gb; Thu, 20 Oct 2022 12:56:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426732.675364; Thu, 20 Oct 2022 12:56:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olV6J-0004rM-DF; Thu, 20 Oct 2022 12:56:43 +0000
Received: by outflank-mailman (input) for mailman id 426732;
 Thu, 20 Oct 2022 12:56:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bGcH=2V=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1olV6H-0004rG-S5
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 12:56:41 +0000
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
 [2a00:1450:4864:20::536])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a40c170a-5076-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 14:56:40 +0200 (CEST)
Received: by mail-ed1-x536.google.com with SMTP id e18so29745694edj.3
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 05:56:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a40c170a-5076-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=211dklALD6kGYLtQWYoou26mE1SCmw0zj++qOMCYAqo=;
        b=bB5izx67N6r3OD509n1Qml1Lhtq/mqwKb4YnJlEiBLkuOTQy7gJbbSSoQsG2j89rW3
         tfz2SZsi4mEYpMMuj1CuhgwdREvJeeUr+UW59UTPIjEopAltK2ihEAbKBNCi44cOIces
         kaq76CsNQuhycRuA6xevwN81B0e6J2ee7qzuk287844nUVu34FM5nhrACUtUHjn2MBrZ
         r+KSmX4jMMyUGVB6zvMJ/sDNPA1fgt96q/04oYFl8uJEuxXd8me1MZcWUgEI7GUBuTv5
         lsxMnj/5W2DEB5vXJvle3f3wRI/0723NSensamUuIjaX3sDc6/Y2E9CB4ulFbu314xbz
         hVKA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=211dklALD6kGYLtQWYoou26mE1SCmw0zj++qOMCYAqo=;
        b=NtDbUUwPV37JvO6y/ehWcSUJggqDzfiF99d1hzeaHDU/zyCiBymWsRSzbv7i5iykcx
         XEiIGdBnK/nmbvJVZSQxgdkn8wvn8GRb5irAecva0NRBaK2AdpfUyQ3fji6J60b6XRos
         29g8bMKim3rDkx8CHYqJ7jetiEbmeUDOxwaqwNzfCRHKxywAnUckAZXKJDC3AQOl/WNM
         DoYtzVBzdMB9GmHakg8pDIvzYwoB19jjRcIGnCOXagf6A0ZnOjqHYuHfv/xTmEQaIQYn
         GcHbYM4qaipnCaYt4m7s/Q4FYo2sWPsiz8Vfo40Bfk02Sat6C/oQvN0tALXMoVaPS/kO
         B7zA==
X-Gm-Message-State: ACrzQf0nV69FaB4Hl9UBQOTk4ee4AkWRDww+Sq2fA43rSjpyb9AOrKjU
	Q8YqZheXt/cvPnQvl19hhoaXg6zHBexDn+t1GlgQseLibLM=
X-Google-Smtp-Source: AMsMyM6ct2gQbef1pZcBeR72NPxKc89pqQgxVpdTN84gbT3+Qc7/qAxzeQBOM4cb7WeVMjaW6um+zrL3dI2YH/lcqB4=
X-Received: by 2002:aa7:ca45:0:b0:458:d9a2:6164 with SMTP id
 j5-20020aa7ca45000000b00458d9a26164mr12275972edt.340.1666270600413; Thu, 20
 Oct 2022 05:56:40 -0700 (PDT)
MIME-Version: 1.0
References: <20221019201458.21803-1-jandryuk@gmail.com> <87zgdq99qx.fsf@baylibre.com>
 <CAKf6xpvHa86frvOp5L3x1nerTCQD=cjz7xqR4VwFBExquKG5bw@mail.gmail.com>
In-Reply-To: <CAKf6xpvHa86frvOp5L3x1nerTCQD=cjz7xqR4VwFBExquKG5bw@mail.gmail.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 20 Oct 2022 08:56:27 -0400
Message-ID: <CAKf6xpvd6rg4AP1XfhCLo0K+BfhVrydBhJy8TReAaTD_1zcY0g@mail.gmail.com>
Subject: Re: [PATCH] Input: xen-kbdfront - drop keys to shrink modalias
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, 
	Phillip Susi <phill@thesusis.net>, stable@vger.kernel.org, 
	Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 20, 2022 at 8:21 AM Jason Andryuk <jandryuk@gmail.com> wrote:
>
> On Thu, Oct 20, 2022 at 4:31 AM Mattijs Korpershoek
> <mkorpershoek@baylibre.com> wrote:
> >
> > On Wed, Oct 19, 2022 at 16:14, Jason Andryuk <jandryuk@gmail.com> wrote:
> >
> > > xen kbdfront registers itself as being able to deliver *any* key since
> > > it doesn't know what keys the backend may produce.
> > >
> > > Unfortunately, the generated modalias gets too large and uevent creation
> > > fails with -ENOMEM.
> > >
> > > This can lead to gdm not using the keyboard since there is no seat
> > > associated [1] and the debian installer crashing [2].
> > >
> > > Trim the ranges of key capabilities by removing some BTN_* ranges.
> > > While doing this, some neighboring undefined ranges are removed to trim
> > > it further.
> > >
> > > This removes:
> > > BTN_DPAD_UP(0x220)..BTN_DPAD_RIGHT(0x223)
> > > Empty space 0x224..0x229
> > >
> > > Emtpy space 0x2bd..0x2bf
> > > BTN_TRIGGER_HAPPY(0x2c0)..BTN_TRIGGER_HAPPY40(0x2e7)
> > > Empty space 0x2e8..0x2ff
> > >
> > > The modalias shrinks from 2082 to 1754 bytes.
> > >
> > > [1] https://github.com/systemd/systemd/issues/22944
> > > [2] https://lore.kernel.org/xen-devel/87o8dw52jc.fsf@vps.thesusis.net/T/
> > >
> > > Cc: Phillip Susi <phill@thesusis.net>
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> >
> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
> This patch doesn't work and needs to be withdrawn.  My gdm/udev
> workaround was still active when I tested, so that is why I had a
> working keyboard.  Sorry about that.
>
> Now the question is, which additional keys can be omitted to trim the
> modalias to an acceptable size?
>
> Regards,
> Jason
>
> > > ---
> > >  drivers/input/misc/xen-kbdfront.c | 9 ++++++++-
> > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> > > index 8d8ebdc2039b..23f37211be78 100644
> > > --- a/drivers/input/misc/xen-kbdfront.c
> > > +++ b/drivers/input/misc/xen-kbdfront.c
> > > @@ -256,7 +256,14 @@ static int xenkbd_probe(struct xenbus_device *dev,
> > >               __set_bit(EV_KEY, kbd->evbit);
> > >               for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> > >                       __set_bit(i, kbd->keybit);
> > > -             for (i = KEY_OK; i < KEY_MAX; i++)
> > > +             /* In theory we want to go KEY_OK..KEY_MAX, but that grows the
> > > +              * modalias line too long.  KEY_KBD_LCD_MENU5 is the last
> > > +              * defined non-button key. There is a gap of buttons from
> > > +              * BTN_DPAD_UP..BTN_DPAD_RIGHT and KEY_ALS_TOGGLE is the next
> > > +              * defined. */
> > > +             for (i = KEY_OK; i < BTN_DPAD_UP; i++)
> > > +                     __set_bit(i, kbd->keybit);
> > > +             for (i = KEY_ALS_TOGGLE; i <= KEY_KBD_LCD_MENU5; i++)

Changing the upper bound to KEY_BRIGHTNESS_MENU works.  That trims out
KEY_MACRO* and KEY_KBD_LCD_MENU*.

Something has to get trimmed out to bring the size down.  These are
probably less common and okay to remove, but I'm just guessing.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:09:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:09:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426740.675381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVIT-0006U2-KG; Thu, 20 Oct 2022 13:09:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426740.675381; Thu, 20 Oct 2022 13:09:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVIT-0006Tv-H9; Thu, 20 Oct 2022 13:09:17 +0000
Received: by outflank-mailman (input) for mailman id 426740;
 Thu, 20 Oct 2022 13:09:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olVIS-0006Tp-PG
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:09:16 +0000
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [2a00:1450:4864:20::42c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 65bcd245-5078-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 15:09:15 +0200 (CEST)
Received: by mail-wr1-x42c.google.com with SMTP id bu30so34359083wrb.8
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 06:09:15 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 t15-20020a5d49cf000000b00230c9d427f9sm16623532wrs.53.2022.10.20.06.09.11
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 06:09:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65bcd245-5078-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=3Bez4xHPLn5WJXFJpVVxEq/3R2QKdu15flkO5zJuSQQ=;
        b=UPV+tG5TN89IiZQTX27CRyuSxeiBlHBQ4M9T0jaBt9sde1MF/DOSyQXwQFM1fjeNa7
         cSgueIHiXCPdBbgD5Eg/ZnphcP3YqTEMpL04F50bmGswWw4kNng6t7pZwuWYOOc55SXe
         pFylqz2nckdvR1inQi8Jla/2pH0zbVGr8kwY7iDl3Ee4PrWzBjtqH2SazjVVULyaXJ5f
         Tj/lzFHa4iPg1zogcxTpQFEX30FypzusBg531rO9i+8A+VDc7OTFhwUowJi7JVwDK7pc
         1X+VRTn/jiTWIO8k7di1o503+E4KCmStOeSUPlqOV6kTlzkdkQv6JFy+7quUwy0d3keN
         ZV6w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=3Bez4xHPLn5WJXFJpVVxEq/3R2QKdu15flkO5zJuSQQ=;
        b=F5QlBrRRyTXJ75+gHoJhaKavLAB6m8iQAwVuD1QP0PdnVHEroDiBwSvUjhpIkl1rjO
         qKVOO7fZRNt1o5qMFTij0p/yA5OJmtPLYQ9gRTLEiKJOu1ClYKk8i+si2yEmxmvPh+yV
         Xjtb6xPmevDw+Q3KPUmDWgwGCRkLK1Ac6Sa+JBPR1lGIs6v3EohcM21MxxXqUoQQ+/Ln
         FCgCpeas9z97zaiTqOF/u3YUNQ7NUAlGhk6V8Fj1OcI0vXl6RPjaCD4X/cm2eegrW5NR
         GiXlmaK40spU7Broz84nAlq6rgzCpqnK+z0Sr75Fb6EpLtgjfzRGSPe1YIvMC+BWZLBn
         pz9g==
X-Gm-Message-State: ACrzQf0xqHnBmifXilpeF9SkRvo0M+LZAqZKRmzJeElxGglMnqATGq9C
	GCtAlB22qaScOSIWZEmv+RGrww==
X-Google-Smtp-Source: AMsMyM6bxol5Wjw2EkMMl4l4bD0Uf/WT/FO43/pKMSEiqPzDXKsP9zdewTz1MhzdWAaTwFhBdeAK+w==
X-Received: by 2002:a5d:6301:0:b0:226:d87b:b55c with SMTP id i1-20020a5d6301000000b00226d87bb55cmr8083437wru.560.1666271354690;
        Thu, 20 Oct 2022 06:09:14 -0700 (PDT)
Message-ID: <6fa6b9e5-fede-0f68-752f-0c0d8fa3494f@linaro.org>
Date: Thu, 20 Oct 2022 15:09:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional
 parameters
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-16-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-16-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/10/22 11:16, Laurent Vivier wrote:
> Use QIOChannel, QIOChannelSocket and QIONetListener.
> This allows net/stream to use all the available parameters provided by
> SocketAddress.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   meson           |   2 +-
>   net/stream.c    | 493 +++++++++++++++++-------------------------------
>   qemu-options.hx |   4 +-
>   3 files changed, 180 insertions(+), 319 deletions(-)

>   static int net_stream_server_init(NetClientState *peer,
> @@ -283,105 +287,61 @@ static int net_stream_server_init(NetClientState *peer,
>   {
>       NetClientState *nc;
>       NetStreamState *s;
> -    int fd, ret;
> -
> -    switch (addr->type) {
> -    case SOCKET_ADDRESS_TYPE_INET: {
> -        struct sockaddr_in saddr_in;
> -
> -        if (convert_host_port(&saddr_in, addr->u.inet.host, addr->u.inet.port,
> -                              errp) < 0) {
> -            return -1;
> -        }
> +    QIOChannelSocket *listen_sioc = qio_channel_socket_new();
>   
> -        fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
> -        if (fd < 0) {
> -            error_setg_errno(errp, errno, "can't create stream socket");
> -            return -1;
> -        }
> -        qemu_socket_set_nonblock(fd);
> +    nc = qemu_new_net_client(&net_stream_info, peer, model, name);
> +    s = DO_UPCAST(NetStreamState, nc, nc);
>   
> -        socket_set_fast_reuse(fd);
> +    s->listen_ioc = QIO_CHANNEL(listen_sioc);
> +    qio_channel_socket_listen_async(listen_sioc, addr, 0,
> +                                    net_stream_server_listening, s,
> +                                    NULL, NULL);
>   
> -        ret = bind(fd, (struct sockaddr *)&saddr_in, sizeof(saddr_in));
> -        if (ret < 0) {
> -            error_setg_errno(errp, errno, "can't bind ip=%s to socket",
> -                             inet_ntoa(saddr_in.sin_addr));
> -            closesocket(fd);
> -            return -1;
> -        }
> -        break;
> -    }
> -    case SOCKET_ADDRESS_TYPE_UNIX: {
> -        struct sockaddr_un saddr_un;
> -
> -        ret = unlink(addr->u.q_unix.path);
> -        if (ret < 0 && errno != ENOENT) {
> -            error_setg_errno(errp, errno, "failed to unlink socket %s",
> -                             addr->u.q_unix.path);
> -            return -1;
> -        }
> +    return 0;
> +}
>   
> -        saddr_un.sun_family = PF_UNIX;
> -        ret = snprintf(saddr_un.sun_path, sizeof(saddr_un.sun_path), "%s",
> -                       addr->u.q_unix.path);
> -        if (ret < 0 || ret >= sizeof(saddr_un.sun_path)) {
> -            error_setg(errp, "UNIX socket path '%s' is too long",
> -                       addr->u.q_unix.path);
> -            error_append_hint(errp, "Path must be less than %zu bytes\n",
> -                              sizeof(saddr_un.sun_path));
> -            return -1;
> -        }
> +static void net_stream_client_connected(QIOTask *task, gpointer opaque)
> +{
> +    NetStreamState *s = opaque;
> +    QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(s->ioc);
> +    SocketAddress *addr;
> +    gchar *uri;
> +    int ret;
>   
> -        fd = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
> -        if (fd < 0) {
> -            error_setg_errno(errp, errno, "can't create stream socket");
> -            return -1;
> -        }
> -        qemu_socket_set_nonblock(fd);
> -
> -        ret = bind(fd, (struct sockaddr *)&saddr_un, sizeof(saddr_un));
> -        if (ret < 0) {
> -            error_setg_errno(errp, errno, "can't create socket with path: %s",
> -                             saddr_un.sun_path);
> -            closesocket(fd);
> -            return -1;
> -        }
> -        break;
> -    }
> -    case SOCKET_ADDRESS_TYPE_FD:
> -        fd = monitor_fd_param(monitor_cur(), addr->u.fd.str, errp);
> -        if (fd == -1) {
> -            return -1;
> -        }
> -        ret = qemu_socket_try_set_nonblock(fd);
> -        if (ret < 0) {
> -            error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
> -                             name, fd);
> -            return -1;
> -        }
> -        break;
> -    default:
> -        error_setg(errp, "only support inet or fd type");
> -        return -1;
> +    if (sioc->fd < 0) {
> +        qemu_set_info_str(&s->nc, "connection error");
> +        goto error;
>       }
>   
> -    ret = listen(fd, 0);
> -    if (ret < 0) {
> -        error_setg_errno(errp, errno, "can't listen on socket");
> -        closesocket(fd);
> -        return -1;
> +    addr = qio_channel_socket_get_remote_address(sioc, NULL);
> +    g_assert(addr != NULL);

Please use:

        addr = qio_channel_socket_get_remote_address(sioc, &error_fatal);

Which is more verbose in case of error, i.e.:

   qemu-system-x86_64: socket family 0 unsupported

Instead of:

   ERROR:../../net/stream.c:321:net_stream_client_connected: assertion 
failed: (addr != NULL)

> +    uri = socket_uri(addr);
> +    qemu_set_info_str(&s->nc, uri);
> +    g_free(uri);
> +
> +    ret = qemu_socket_try_set_nonblock(sioc->fd);
> +    if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
> +        qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
> +                          addr->u.fd.str, -ret);
> +        qapi_free_SocketAddress(addr);
> +        goto error;
>       }
> +    g_assert(ret == 0);
> +    qapi_free_SocketAddress(addr);
>   
> -    nc = qemu_new_net_client(&net_stream_info, peer, model, name);
> -    s = DO_UPCAST(NetStreamState, nc, nc);
> -    s->fd = -1;
> -    s->listen_fd = fd;
> -    s->nc.link_down = true;
>       net_socket_rs_init(&s->rs, net_stream_rs_finalize, false);
>   
> -    qemu_set_fd_handler(s->listen_fd, net_stream_accept, NULL, s);
> -    return 0;
> +    /* Disable Nagle algorithm on TCP sockets to reduce latency */
> +    qio_channel_set_delay(s->ioc, false);
> +
> +    s->ioc_read_tag = qio_channel_add_watch(s->ioc, G_IO_IN, net_stream_send,
> +                                            s, NULL);
> +    s->nc.link_down = false;
> +
> +    return;
> +error:
> +    object_unref(OBJECT(s->ioc));
> +    s->ioc = NULL;
>   }



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:10:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:10:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426744.675391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVJD-0007Gd-37; Thu, 20 Oct 2022 13:10:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426744.675391; Thu, 20 Oct 2022 13:10:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVJC-0007Fv-W8; Thu, 20 Oct 2022 13:10:02 +0000
Received: by outflank-mailman (input) for mailman id 426744;
 Thu, 20 Oct 2022 13:10:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olVJB-000716-BE
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:10:01 +0000
Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com
 [2a00:1450:4864:20::42e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 80c52a4d-5078-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:10:00 +0200 (CEST)
Received: by mail-wr1-x42e.google.com with SMTP id a3so34292301wrt.0
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 06:10:00 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 q47-20020a05600c332f00b003c3a1d8c8e6sm2654065wmp.19.2022.10.20.06.09.57
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 06:09:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80c52a4d-5078-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:references:cc:to:from
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=112G7FXUBLWBLmsXv3bUPwIWqEcI9Lpi3IXFw2eDA10=;
        b=S1CHrYTn1E97XAKKQAM+0ly6EYOZqrrUaXHXp0+Z0tvcHE6JX0p0jddHHlR+V5t8lF
         q5w+V0ZvwhWgyL0qIxi9dAph+CXF/R76CeR1Npr4fie1L7SX4OAtCJMXYEbmGMl2kWI6
         qbUbTrm7kAQJwgRr5ZoI7l/jjyn5j0A6d++FPG0Q2Vrk2f1z9ua5aFPcHOumxCHMtZNc
         /MybkUUJokaPOHGtITyR/EggMwfgeqvw7mlv7IcTkX3e4f6mIPluukA+pSrJsh6wiTsv
         CPKirqJjiDSA8fm3EBP3X5NUS700aqVbsQkruT1ek1zF54eHesTTuSVPYegkFXc2hQsz
         KHwg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:references:cc:to:from
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=112G7FXUBLWBLmsXv3bUPwIWqEcI9Lpi3IXFw2eDA10=;
        b=rud/teqGhHSWPs0fdPswy16WUKJ7cTwKKMV7ZcMvrywfjoQiLyD5MxwfiP0ldGtZD4
         erKQD0PRWzQDVIyEmTp0c+4/f6xOU2pYDIQeOw/UCJnpudsijL+8R4+KGP2IhW3bODwc
         vJbr/A3mSTErnyXCP4IAPJtpufWBQlvPSS6rX/obqfbsd3EKq0s+L3iWIK73m87e/VGv
         O1TQKQG/dYQXG/jAF0fnJ43JxfTOT8LDaDhD4BQEneWXsOxemGwZ/ZTvAuJZ9AhO4tRu
         yMcPc8F66YJ1QSyHxSxRCb92+nnRkmZ+mEaY3z8oz1onfVKmdEKTWFizxtYAtguys7fR
         iwhQ==
X-Gm-Message-State: ACrzQf3QMseVWz2Ifs9PpksijppIpIb71S67Dg6RYqJ8jCiLU0uxoWZ/
	Q1CdCTG+G9dtnDKFcyiK8oyZkA==
X-Google-Smtp-Source: AMsMyM6epb9tN4+sHmwu/vScpA0+w9QEBcSZ3ewUAKeg3HiQCQ/DmHk/XgG0KrzdX/a3bI+2jfIPHw==
X-Received: by 2002:a5d:52d0:0:b0:21e:4923:fa09 with SMTP id r16-20020a5d52d0000000b0021e4923fa09mr8773973wrv.244.1666271400221;
        Thu, 20 Oct 2022 06:10:00 -0700 (PDT)
Message-ID: <3c1d85f0-521b-7ea8-2138-c2b93cd39c15@linaro.org>
Date: Thu, 20 Oct 2022 15:09:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional
 parameters
Content-Language: en-US
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-16-lvivier@redhat.com>
 <86d3bbf2-375c-801c-1576-60eeddad6178@linaro.org>
In-Reply-To: <86d3bbf2-375c-801c-1576-60eeddad6178@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 20/10/22 13:05, Philippe Mathieu-Daudé wrote:
> On 20/10/22 11:16, Laurent Vivier wrote:
>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>> This allows net/stream to use all the available parameters provided by
>> SocketAddress.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   meson           |   2 +-
>>   net/stream.c    | 493 +++++++++++++++++-------------------------------
>>   qemu-options.hx |   4 +-
>>   3 files changed, 180 insertions(+), 319 deletions(-)
>>
>> diff --git a/meson b/meson
>> index 3a9b285a55b9..12f9f04ba0de 160000
>> --- a/meson
>> +++ b/meson
>> @@ -1 +1 @@
>> -Subproject commit 3a9b285a55b91b53b2acda987192274352ecb5be
>> +Subproject commit 12f9f04ba0decfda425dbbf9a501084c153a2d18
> 
> Probably unrelated submodule update?

Likely because I'm getting:

../../meson.build:1:0: ERROR: Meson version is 0.59.3 but project 
requires >=0.61.3




From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:12:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:12:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426753.675403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVLv-0008V4-Gw; Thu, 20 Oct 2022 13:12:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426753.675403; Thu, 20 Oct 2022 13:12:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVLv-0008Ux-Do; Thu, 20 Oct 2022 13:12:51 +0000
Received: by outflank-mailman (input) for mailman id 426753;
 Thu, 20 Oct 2022 13:12:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VPXW=2V=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1olVLu-0008Um-5n
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:12:50 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e5031acb-5078-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 15:12:49 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8490.eurprd04.prod.outlook.com (2603:10a6:102:1de::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Thu, 20 Oct
 2022 13:12:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 13:12:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5031acb-5078-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HB0GF2tEcsirTk7wrbmm9ynoLUfe6wq/fPP6KtLa6JRiDdeBLX/0UgiV2hQVdsFIb8waq59STT5v06nzgd7Rv7WFJYb/XTWXMFM+PFEZ7bvNavdHp4bpEqGJ9Xs+VbR817x7+u3o+2PFqX99pvSydqG+/1GZD3ubRa7kq0X8blxSi9FelTbbx6vDTmMemS7yAUkpkGL6VkdQN9zjVIKnd1zGc2MmTkZqGfRPloPw4Dgkkg3WIcOFTeAbbHuSdcloPoBYIVIbWEHPE4QALhmS+0TIR0JBr0AwQfdgz4grE/TkwAWfVIQ+AsqUI2jK00L6csm36h8XDCH6/zyrKsUaEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2FAcjDvisNRFrMpLqdDa6n58UN2VORG/iWxnUfHrfKM=;
 b=S38o8BlNaCtESBOb2Jni1wHqPpE0iHeB9rkVbSP0QUizRx055ieIvxOibkK36MCsZqQ20yYEStencDWla57zZwuRmpMkXvz5nyuaefZFNorLil87aFVXxUF9b/FB7IL25Its8OzNw6wFiAC0pCBxFHF4eePsnzHg6089mVSbgdRZCwsXJbpi/rgSqWBcH2tqxF+utOL6k5tLQeYxCxlmfpE5TLA6gZ9bxZrsd10gba4+eUA4IU1R06Fu1VjCOb2o786TDWN2P61yongiry4zKigtzYwYTbzya/3tJl0EJaj2WNPqCzhdN9dx3ndqiXrdRVicUUsKgSP6rZvFdfdsQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2FAcjDvisNRFrMpLqdDa6n58UN2VORG/iWxnUfHrfKM=;
 b=kxn10ZH2Bajq5gAKSFljVVnSgtpLzj1xOHuYxpFL/hYcgjKPzGsnZob3N4/Uz0aaWKYmf0xjkANTTqckn7PMy/bOt6q4UWflPcTgW25DvTsn+L+JILDMJOFndF3rVzbU2a6hDluPoUIQom1abXOiFRngPIwfGStL0x3MiYPukA2r2n8CDchvX+BP+4tP5IKGgXse0B3fNIVCQmkb8QoPpdjOPAjn1fSAb9BvrpGEsT+PH0Z8cwZ76YgTzLF/kOcIw3yT6RcTnrmk01rn8II7wpTrVLKqrhdAcqipLSZbXVTpxTc1ABybgZDNfzTK15iJ2R+CsZE3CRuC7QTaB5Idzw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <adc567a7-c338-477d-bf8d-b73300c36f6a@suse.com>
Date: Thu, 20 Oct 2022 15:12:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Policy: A release acks for the release manager's patches (was Re:
 [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init())
Content-Language: en-US
To: George Dunlap <dunlapg@umich.edu>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Henry Wang <Henry.Wang@arm.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>
 <20221018142346.52272-3-Henry.Wang@arm.com>
 <CAFLBxZZ59zkuNJM1vQSv_Syv8i0Q_dAFk0p-JXY4oFs0cCUSnQ@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAFLBxZZ59zkuNJM1vQSv_Syv8i0Q_dAFk0p-JXY4oFs0cCUSnQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0052.eurprd06.prod.outlook.com
 (2603:10a6:20b:463::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8490:EE_
X-MS-Office365-Filtering-Correlation-Id: 7cd63cfd-0460-4e53-c32e-08dab29cc77b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hLgDgEmfkDCWh8/jHRV1KEgmUw6v70eim48weuhnyQVAAGPU5FcY+G+duiPP2g6LiUi29b76zGs0h8jCBofDbYKzG4zrIFTfkbZFLrSmfVRvWVMSf1okFA5VgCK1MFlFex1cQDTf8tcsQpLkmylKX+hNFZc5KLE3O8/2OjHtUMJ6ICe3cWV2QBqsRCaYF/lxKoOWw6tID0rJQeNXhCLqNY4Nij2XMADVf8XCYWq2GuNM5Hky7Gmw1DQKgwz9OZ3wlheb25ILU+rj5Ovmnz2qFtuxJ9t6gUo+NWr9FIthST/PFwjySkuMgNaVG77O0IwLWbXxgQiYAOpIj2iq+3RIPV+qrpx9+n1N+hr3NnQsI6u2M/Q76UCE1X3Xs2pTTk18AmohBkSs1uVLxOqc1pAkd5Yu8yrE7dVtRtlHh8b9+yx5UQYUTzP6ZqRSQcoBQjxpa69LNaOv4PGXAPb2/V/Qp6NRpTCSyUAe8aWTSwBlAUTbCrN4cTyVF3PM3E+ZkmN55tymXi5bi8kSCwRp44A0blDEMPqnwk9IwWyJ6vBswDMFAERkt5v85aa0iAEPl1vVYUrbHr5i3GvkWk4PW0oKAXBrAOPyNfAhxkLqF2+TbMOGrtcGP+RIZYYnH+R3bSQPiR85Gwx2oGAvvk4FpBNu0Jo1BWcd8Yn9wBQqj3/8S5eran+lFE0FC6ngwhQr44Iz9OO6Y3IP4YBX8X2xZvKqOrt5zh0yxva19nI1coiT2LklNXoNukRUm0RzrmIy/8+SrDlZuxvDCzXwJ0/LFUn6cdukpwbrVtqoZPu4JzuNnfc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199015)(31686004)(36756003)(6506007)(2906002)(5660300002)(86362001)(31696002)(8936002)(4326008)(53546011)(41300700001)(26005)(478600001)(6512007)(2616005)(186003)(66946007)(8676002)(83380400001)(66476007)(66556008)(38100700002)(54906003)(316002)(6916009)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3kwdGl6bWJGWFQvNVNjdjFTTVRWWVBuejlXU2IzTnh6aEVSaEVJb2tmakFY?=
 =?utf-8?B?ZkdxUjRpNmhCZGpKTXFYdmlBQnhxT2xkZVp3MEs1ZDF6dWk3WllSNUxKY3JM?=
 =?utf-8?B?eW9xeHAzUGxuTEw1SWFLVHVvVDUwMW9sSG5xNFhaZVFqbEhEZ3RUa292WDN4?=
 =?utf-8?B?SUZ6dzljWUJ6SEY2d2N2T05UaFBhU0wwY3h0ekIrbENNMTl4SG5USHhrSCto?=
 =?utf-8?B?cEJXTnRnSkZxcTg4UERFM1VlRjhjdkRwV211U2MvK3RtREIzQUF0a09WSVA4?=
 =?utf-8?B?cmlQajdGbHpiSDlkRWg0UktVbG1Qa2s5WjRrdHpubXdLeWFuOWIwVDFGSnRW?=
 =?utf-8?B?T1I5SkJBa2JzSjZ4M2ZKb05OdzZCMkg4aVUvT3NrdnlIcXRmMzdGT25TM1ZI?=
 =?utf-8?B?R2VaSlFXeDQxby9yQUo5ci9BN2l0NFpvK29hVmxsWjMxV3Y0cGNRcWJaSTBL?=
 =?utf-8?B?Szg2RHV5eUZNakJ5a0g4SGIyYWFMaFhzaFkwL0FVaTdIWE16NlZsNU9SZXJL?=
 =?utf-8?B?Wmo0eS8weTY2SGxZelVqUDRvdDM0NFRpWFV2YjZGNDk1aFZuRjBFYXdrMWFB?=
 =?utf-8?B?UmhZZVMySVN3cENVVUJyd2hlNXpzWW5SZ1RmV25sV1ZhaHUydEFvcTNIejdZ?=
 =?utf-8?B?eitzcWZTeHBBNm9OWUZSaTNjaC9ucis1eVdtanFCOW5CcEJsbFhUS3ZUZzY0?=
 =?utf-8?B?T2RNNVFreVhsV29jeXZzczJGUndzRkRQVzJJbDhuTWZYSWJnNlozUi9wbWt5?=
 =?utf-8?B?S2pYUkFIUTlXRy9aYjVNYUhIbWpZeG1rbEpyMjQ1eDNxRkVqTmlmam5qOXRq?=
 =?utf-8?B?TUxFZE93emRNekEzZUJsSWQ2eXpoY3h2QUpPckV6a2lFTHZJYTBaSUFKNFdh?=
 =?utf-8?B?Y2hqQzNhdzlBYk1vTnF3NnhYQjR0bXM3WkdkTThrK2l0MkFKMU5OOTdTbkFL?=
 =?utf-8?B?L3R1NUxUbnE3MU8rUEkvbytIKzBXaGtoelFMZHNjdU1EL3RGMFNvRFVPSnpU?=
 =?utf-8?B?ZG50VnAvVzVYNkVkNDVpb3FEOU5WZmRGdXBVRlhjWk1rNEFoLzgvZFIvVUQ0?=
 =?utf-8?B?Vy9mUGhtNlV1b2Z1TGc1YS9Eb2duVndpNVJrWW8yOFFERlhIdlZuYzhpaFRJ?=
 =?utf-8?B?MW9GZXRPK1F1YTNDVzNtUVBwRFcwems3RS9mNUpFU2RTVUozSVZ1M1RGQ0xI?=
 =?utf-8?B?RVRDU3gvcXNFcnBwTzhhTDFKZFpCOHYyM3RDL2thUC9odlB6VkZwRnZNaFdi?=
 =?utf-8?B?ZEg5eGl1YXJqSXVpVUVHQmNrbmZGYlVCSzBuRU9qMHQ2N0pXVFhIM1Q5MXpW?=
 =?utf-8?B?RjJHaHRlQlFtYi96anNHZWNObXVXSGlZQzhHWWZCWDdValBiaC8wRUJiK3oz?=
 =?utf-8?B?TnZ1bVFJMjRZdElxY3VGdmErZ1hsRkNsSW5OV2Q2SythZ09LMTUyS3JQS3o1?=
 =?utf-8?B?L0xLQ2U1ZnJKMTdVSldPMTJadmduMDRHOU5HRHc5Vy9WMy9ONmdCYjljUWNE?=
 =?utf-8?B?MHVhSWtxTStNZklXYVpib042UU13dW41Q3BNTENHeFpueXA5dlN2aHE3Ullu?=
 =?utf-8?B?aFNBQmo0NWkzTXd5VEZSamFhaVN2b00zZk5hVjN2VzM1MTdrbERwNkF1Q1dz?=
 =?utf-8?B?SEhLQjM2dGZ0NDBuSXNzMHhPZGtNQW5mdTRQT0JVVXB1QXVXOFM0UlAwMmNt?=
 =?utf-8?B?MGprcU0yQldDUzE4dDlzVEI2eXB5YnZ5NjlHTEtxV1pzR2Y4bmdlSmVBRXhn?=
 =?utf-8?B?Rzg5VldoaUFhbmRneTBuczF0NDRZRzFVQzdOYWxEWm9lcFl4WUkwYUVEc2Vv?=
 =?utf-8?B?cVlVSUF1WHZ5amJXT3lnekZtVGtVSzZQUndQY012Zk8xNXVqN3pnSW0xMkNR?=
 =?utf-8?B?UXJTOTZiaXFxTFlKVi9MMkRzdkFCYzZmbUFWQVhVRWc3d1pwY1VCOU81Qm5D?=
 =?utf-8?B?aWZkcWNSS0E3b3ROSVduS2hjeUhoNTR0MDR3cTRSUjFja25IM283UmUrZXV6?=
 =?utf-8?B?c2ZNQTBCTllZc3JlcG11d0RKdHhNeWZrQitMSW9hRDFza0NONk8xdmFaV0tF?=
 =?utf-8?B?L1ZaTHd1RU5tdlZhTWcyVHc2K25OeWZuTU9oYUZ6Vm1XZzNObStoVkdOQjJE?=
 =?utf-8?Q?4QAfZOUSMohVh6YZsw25hLkpv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd63cfd-0460-4e53-c32e-08dab29cc77b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 13:12:45.9796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5YpG8zN3HDsjZ0rsl0p0D6QxmrsF6rLClyKBhEHd2ziVOJ9F+MgL4dbBcwXmy0l3AqCBwQwsGPcp8bNHCB5VeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8490

On 19.10.2022 17:28, George Dunlap wrote:
> On Tue, Oct 18, 2022 at 3:24 PM Henry Wang <Henry.Wang@arm.com> wrote:
> 
>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>> when the domain is created. Considering the worst case of page tables
>> which requires 6 P2M pages as the two pages will be consecutive but not
>> necessarily in the same L3 page table and keep a buffer, populate 16
>> pages as the default value to the P2M pages pool in p2m_init() at the
>> domain creation stage to satisfy the GICv2 requirement. For GICv3, the
>> above-mentioned P2M mapping is not necessary, but since the allocated
>> 16 pages here would not be lost, hence populate these pages
>> unconditionally.
>>
>> With the default 16 P2M pages populated, there would be a case that
>> failures would happen in the domain creation with P2M pages already in
>> use. To properly free the P2M for this case, firstly support the
>> optionally preemption of p2m_teardown(), then call p2m_teardown() and
>> p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
>> As non-preemptive p2m_teardown() should only return 0, use a
>> BUG_ON to confirm that.
>>
>> Since p2m_final_teardown() is called either after
>> domain_relinquish_resources() where relinquish_p2m_mapping() has been
>> called, or from failure path of domain_create()/arch_domain_create()
>> where mappings that require p2m_put_l3_page() should never be created,
>> relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
>> in-code comments to refer this.
>>
>> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M
>> pool")
>> Suggested-by: Julien Grall <jgrall@amazon.com>
>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>>
> 
> 
> Henry brought this patch to my attention because it needs a release ack,
> but it doesn't seem proper for Henry to be the one to release-ack his own
> patches. :-)
> 
> I propose that a suitable rule would be:
> 
> "If the release manager themselves have submitted a patch which needs a
> release ack, then the patch needs a release ack from one of the Committers
> who is not involved in the patch."

Like Andrew I think a self-release-ack, as was common practice in the past,
is quite fine. These are entirely different hats that the person would be
wearing.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:15:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:15:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426759.675414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVO6-0000hp-Te; Thu, 20 Oct 2022 13:15:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426759.675414; Thu, 20 Oct 2022 13:15:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVO6-0000hi-Qm; Thu, 20 Oct 2022 13:15:06 +0000
Received: by outflank-mailman (input) for mailman id 426759;
 Thu, 20 Oct 2022 13:15:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UcvY=2V=redhat.com=berrange@srs-se1.protection.inumbo.net>)
 id 1olVO5-0000hc-Gw
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:15:05 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 353fd074-5079-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 15:15:04 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-395-8XB1Lg7xNuqHFFNztoU2DA-1; Thu, 20 Oct 2022 09:14:50 -0400
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
 [10.11.54.9])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A2BF101E154;
 Thu, 20 Oct 2022 13:14:14 +0000 (UTC)
Received: from redhat.com (unknown [10.33.36.226])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C8FA47505F;
 Thu, 20 Oct 2022 13:13:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 353fd074-5079-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666271703;
	h=from:from:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wa6ijFnbOddGZNwKzmOMeXhd0ltWkdQZWS1P83dxN6s=;
	b=iW5hRJ1MxMEZ3Y0EY4b+HgVVDFPXGWdY23GjHlkFAE8GpxGPFsDN7Jfj1XMHyNxcXbIY6/
	RFyRZF2FCQdJqIshaQKMnhoLo+L69r5bSkfAaVkvV4W5GkdXBPmDJUXA96RIvr3o5lyF0o
	sRFNSSHmgdMFYIxIG0WFu6cJ7d+3oso=
X-MC-Unique: 8XB1Lg7xNuqHFFNztoU2DA-1
Date: Thu, 20 Oct 2022 14:13:55 +0100
From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org,
	xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
	Jason Wang <jasowang@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Thomas Huth <thuth@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Paul Durrant <paul@xen.org>, Stefan Weil <sw@weilnetz.de>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional
 parameters
Message-ID: <Y1FJk3/9vbaT5+YG@redhat.com>
Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-16-lvivier@redhat.com>
 <6fa6b9e5-fede-0f68-752f-0c0d8fa3494f@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6fa6b9e5-fede-0f68-752f-0c0d8fa3494f@linaro.org>
User-Agent: Mutt/2.2.7 (2022-08-07)
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9

On Thu, Oct 20, 2022 at 03:09:10PM +0200, Philippe Mathieu-Daudé wrote:
> On 20/10/22 11:16, Laurent Vivier wrote:
> > Use QIOChannel, QIOChannelSocket and QIONetListener.
> > This allows net/stream to use all the available parameters provided by
> > SocketAddress.
> > 
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   meson           |   2 +-
> >   net/stream.c    | 493 +++++++++++++++++-------------------------------
> >   qemu-options.hx |   4 +-
> >   3 files changed, 180 insertions(+), 319 deletions(-)
> 
> >   static int net_stream_server_init(NetClientState *peer,
> > @@ -283,105 +287,61 @@ static int net_stream_server_init(NetClientState *peer,
> >   {
> >       NetClientState *nc;
> >       NetStreamState *s;
> > -    int fd, ret;
> > -
> > -    switch (addr->type) {
> > -    case SOCKET_ADDRESS_TYPE_INET: {
> > -        struct sockaddr_in saddr_in;
> > -
> > -        if (convert_host_port(&saddr_in, addr->u.inet.host, addr->u.inet.port,
> > -                              errp) < 0) {
> > -            return -1;
> > -        }
> > +    QIOChannelSocket *listen_sioc = qio_channel_socket_new();
> > -        fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
> > -        if (fd < 0) {
> > -            error_setg_errno(errp, errno, "can't create stream socket");
> > -            return -1;
> > -        }
> > -        qemu_socket_set_nonblock(fd);
> > +    nc = qemu_new_net_client(&net_stream_info, peer, model, name);
> > +    s = DO_UPCAST(NetStreamState, nc, nc);
> > -        socket_set_fast_reuse(fd);
> > +    s->listen_ioc = QIO_CHANNEL(listen_sioc);
> > +    qio_channel_socket_listen_async(listen_sioc, addr, 0,
> > +                                    net_stream_server_listening, s,
> > +                                    NULL, NULL);
> > -        ret = bind(fd, (struct sockaddr *)&saddr_in, sizeof(saddr_in));
> > -        if (ret < 0) {
> > -            error_setg_errno(errp, errno, "can't bind ip=%s to socket",
> > -                             inet_ntoa(saddr_in.sin_addr));
> > -            closesocket(fd);
> > -            return -1;
> > -        }
> > -        break;
> > -    }
> > -    case SOCKET_ADDRESS_TYPE_UNIX: {
> > -        struct sockaddr_un saddr_un;
> > -
> > -        ret = unlink(addr->u.q_unix.path);
> > -        if (ret < 0 && errno != ENOENT) {
> > -            error_setg_errno(errp, errno, "failed to unlink socket %s",
> > -                             addr->u.q_unix.path);
> > -            return -1;
> > -        }
> > +    return 0;
> > +}
> > -        saddr_un.sun_family = PF_UNIX;
> > -        ret = snprintf(saddr_un.sun_path, sizeof(saddr_un.sun_path), "%s",
> > -                       addr->u.q_unix.path);
> > -        if (ret < 0 || ret >= sizeof(saddr_un.sun_path)) {
> > -            error_setg(errp, "UNIX socket path '%s' is too long",
> > -                       addr->u.q_unix.path);
> > -            error_append_hint(errp, "Path must be less than %zu bytes\n",
> > -                              sizeof(saddr_un.sun_path));
> > -            return -1;
> > -        }
> > +static void net_stream_client_connected(QIOTask *task, gpointer opaque)
> > +{
> > +    NetStreamState *s = opaque;
> > +    QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(s->ioc);
> > +    SocketAddress *addr;
> > +    gchar *uri;
> > +    int ret;
> > -        fd = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
> > -        if (fd < 0) {
> > -            error_setg_errno(errp, errno, "can't create stream socket");
> > -            return -1;
> > -        }
> > -        qemu_socket_set_nonblock(fd);
> > -
> > -        ret = bind(fd, (struct sockaddr *)&saddr_un, sizeof(saddr_un));
> > -        if (ret < 0) {
> > -            error_setg_errno(errp, errno, "can't create socket with path: %s",
> > -                             saddr_un.sun_path);
> > -            closesocket(fd);
> > -            return -1;
> > -        }
> > -        break;
> > -    }
> > -    case SOCKET_ADDRESS_TYPE_FD:
> > -        fd = monitor_fd_param(monitor_cur(), addr->u.fd.str, errp);
> > -        if (fd == -1) {
> > -            return -1;
> > -        }
> > -        ret = qemu_socket_try_set_nonblock(fd);
> > -        if (ret < 0) {
> > -            error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
> > -                             name, fd);
> > -            return -1;
> > -        }
> > -        break;
> > -    default:
> > -        error_setg(errp, "only support inet or fd type");
> > -        return -1;
> > +    if (sioc->fd < 0) {
> > +        qemu_set_info_str(&s->nc, "connection error");
> > +        goto error;
> >       }
> > -    ret = listen(fd, 0);
> > -    if (ret < 0) {
> > -        error_setg_errno(errp, errno, "can't listen on socket");
> > -        closesocket(fd);
> > -        return -1;
> > +    addr = qio_channel_socket_get_remote_address(sioc, NULL);
> > +    g_assert(addr != NULL);
> 
> Please use:
> 
>        addr = qio_channel_socket_get_remote_address(sioc, &error_fatal);

Just 'err' instead of '&error_fatal', and return - to the caller.
This is code where we need to propagate back to the caller, not
abort the running QEMU when hotplugging a NIC backend.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:16:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:16:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426764.675425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVPA-0001Fw-8I; Thu, 20 Oct 2022 13:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426764.675425; Thu, 20 Oct 2022 13:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVPA-0001Fp-59; Thu, 20 Oct 2022 13:16:12 +0000
Received: by outflank-mailman (input) for mailman id 426764;
 Thu, 20 Oct 2022 13:16:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VPXW=2V=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1olVP9-0001Fb-DU
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:16:11 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d2d6091-5079-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:16:10 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7217.eurprd04.prod.outlook.com (2603:10a6:20b:1db::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.28; Thu, 20 Oct
 2022 13:16:04 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 13:16:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d2d6091-5079-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LntkzugKyWwMPmXhjB7xdDMRQQKvn3DSkPivuwcQlXF0IqEMHvlZbY3ukE1d0cRksesQSYa/gJ7P1uwvzEyRn8g5Y8YbPheKP87lynzOoap40508qxYJeAUaHGcK232km8zONZjDBGjD1fkWW5fTf+L8eYpgaWaI8KYp3ZvwS1GtfDDEpQcqBCern1gSkEOCaFVb/d6MmYAT6LJo95cy5feyiE3nUCU680GhCZ8QqHiV43c65O3OvSjdY1n5IJWqP6sndv5Ohqj72A2Iy3S8pNhRrjsAFUx75Kjsq7kEbOMyzKfueBctYew8edicmDuJlRvtgbZkKpUnvUOYvAdeog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ph99jjmvxnSMHZwfBQi6Qqu0r728QlCQCKShM2Fdvog=;
 b=YOPMT+VBV4fCvBHelDjnd8VlpPZQa540BsJZyBjQHeszv99mXIqGhsbA/WuNwbyUlWDnptbGsskdB/HNWhL5Z2HAwzJWI1lF5zXPyYxT81OzGRi6zr2Lya1MS9Af9V6Qh5sdaDzsJ4LeUjFHVSaSq+1e+tXdFVWYRZrI1wM18ooCaXpf1EymJAmSSFw3WTAPpGPzck/SWSZLEtYVizmuQXGzOyRC3hPkIrVcvhM1pFQei5A2klygButiMeZrJNMi6FSf/roc1epOyH1jQi613S/1Atlfa/0AsrmX+mQOP/J91jO8yckRo+m+M18dXVWos77Kx+uh1XLEderAyMMGOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ph99jjmvxnSMHZwfBQi6Qqu0r728QlCQCKShM2Fdvog=;
 b=ry34uHVI9yus1YAmM3l9CIcLmau/KVECGe20SK1oup0c4eKtNvyhqrXNUU85ULzqU4zmvs/glPhXOu1MTctcfexrWox6yu8SfIcXS15Gt9lZjlbXHhZdxga6aLypcizwiiOgncCGw/Q5wE+NjY6EPPeN/cVFwSHKdBM8jlZgeMlMbJ//rxev2IH40jyIvr39HIssC/Z4iku9tTM+5AyE6Q/rByEwY4DwC8p7tAwLQHI+Mn1dqdqQ3HRsPU8ApcR/DWulW01MaSmNZELTXjstidhf+HE+8lrKSm3EUXCXArzXkhOc0dIJw7JwM0ZXbehP2W0qFDF6iUUCU/aX+3kP0A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
Date: Thu, 20 Oct 2022 15:16:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org,
 x86@kernel.org
References: <20221020113759.17402-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221020113759.17402-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0006.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7217:EE_
X-MS-Office365-Filtering-Correlation-Id: 0cc33f2c-131e-4ec1-9e02-08dab29d3dbe
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vu8EDncppGjR4sdKA+DA6P0kP7VwkK/pDuzzJqScWg57f2HxMH/mwqTuE/RojanGUrNoYM6KVfcAnhi7BfgD97zeuOA+tvv1FfOEKGCnNF0MHJo32elgYZoANDTn3RtLa/AEwnHOzZsA8MLfwBeplnH+sC+rrZPA/HcdMXzih6MhUJDA+vUVc55Q5yclCW2f7sosAMufsQy5lSUkf1EA+8zjzsHU3UusKWwJBFc4F1qvb+T3ru/r0UADY/JCaexEI4tI2FIJGLYP0kbisSGtq5RTOTl64FFrX1oiKw9xjSQ1VXlWtIq1m0x5+p7xNJMcEhJMSlKoTqA9IckmVG4Wbi1nR+HSh9ZlmPE3V7INmNAQrT8pzhaQku3gfWMrCelz6V7e0MLi46ljChIY9znhfQohwZsflPXveVdsK3N5lRkVDcNjTwov6QxlxZWNYflFR3UE2bxJFyVgtlLM+cVI7hzW0Yd1yelRf5vk7un3scR8IEqgpzXoEicdSkiPXD/WlHriZD6g2GUAK1ujvO11zQ4+yxyAjsJPUM87HcZkXBuEx4HcHwUkMHOD6K1SJU7kh3r9wRiyp+LcdI4OUJJyY2w8jq5gMHjZ7XO4ZrlguNykFBaCeG3TTroimLju8/vzhPiNDDMQhDLKZBD4wwd22XPRjuhMlal3W7ZTNVjlifRQKHOSTRQ3jWTNTuzYpkaQa4sgGAVjr2bUrNJFpsNdEHpYG/esO66ic0rL0OydQYVjkc8aGgSQU4N1BnLvE03tU9nLw9jJ6aPbDtrjircSy8rxTwpYC1LiMzJp2Il+S6c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(346002)(366004)(451199015)(54906003)(186003)(38100700002)(2906002)(2616005)(6486002)(478600001)(4326008)(37006003)(66476007)(86362001)(66946007)(8676002)(66556008)(4744005)(6636002)(8936002)(31686004)(26005)(6512007)(83380400001)(53546011)(6506007)(41300700001)(31696002)(36756003)(316002)(6862004)(7416002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ek0wTzY1dVIwSlRmOWtGdzN6eEt1RjI1Q0ZlMFZJd0xOSFl4M2YzUEVJUTA1?=
 =?utf-8?B?K2sxS3B1bE41d0kxQVQydFNvSDBudUFiSzgrRm0zbFFTc1ZuNUx1U2Jra2VZ?=
 =?utf-8?B?eFRIVHFOY3VZNzJXOU1EL1RSeVRETjVMQnJqSkZ4MitIMWNBOVhaL2ZaaDUz?=
 =?utf-8?B?clZVZm1jNlJqVmYrTVNZQTJ2OW9QTjRuUW9hUVBoQnBKaUo2T2piYTdmUFMw?=
 =?utf-8?B?SEkwNy9XdlEvYzFLTDBSaEVGaFlZdEZZMG1Qc1dNaThlUjNRZk9ZNHhDM002?=
 =?utf-8?B?RmtVb0VSWXV0cUNVYm1DRUJFajYySjIvTGo2TVE3c0ptTUNhdGQ2R1hVY05h?=
 =?utf-8?B?anY3YkJ3QndXZGZlQ3hJRE10TXd1cVU0bUdLQU1Tc1dRa0ZwTlBnT1hGaWZC?=
 =?utf-8?B?QzNlYitBekR4TTRGY2g5d0U1aDZmNjdsUWhwRlZzcjJTOUZsSzd0KzVlTUlH?=
 =?utf-8?B?WE4wUE1WRjh0UkVKSGlwOHN0bFo2aVBJSkdlaSt3U1lwWG5NWVJReTB6Rjd6?=
 =?utf-8?B?UUhDUXlUNktkeW9FNGlRS3puODVuemlFandsWkh2ckVPQ1A4eGZJTVBkVWlv?=
 =?utf-8?B?WDYxNHRnSFBQbGVhVnlRVmFFZUFGdWF6ODY1WEJXSmVsTGRmcFBRd3ZmNDYz?=
 =?utf-8?B?M3lzWG5RQXJqcGtlYVpxVmkxMGJPbXdtVHc3V3pXTTZuVzZLd0YwR2dmSEVq?=
 =?utf-8?B?a00yaGQwczVFd3ZOaldvZk00eE9sVnhlNVFQS2VEV3FKRzBpM1FaWnZNTk5C?=
 =?utf-8?B?NGdqMjZZaHJXSUNUb083TldvRVhuNkFoVTc2YzFNR2pkVFhVV1ByRVZMVGJX?=
 =?utf-8?B?Z3ZSSkpyUTFlVFpOTE95OVJMY2NTc2JqaU00TSt1WldJdUpGSXVRUWowckQ4?=
 =?utf-8?B?b2EwcldZckJWeGNYb3ZaYXRUZ2JHaGYvckNuRm5YdjRQUHI5QmFxeGFvWjAr?=
 =?utf-8?B?Zm5aU2E5RmQ1eUFoVjhqM1BFeDNJSThBQzN5YlpoaXZoSThYaWVQU1kveXZy?=
 =?utf-8?B?akZ0Smpxc0p6NXo4bXNTNEM2SWdkZ1dsZ0NkMVpEZ0RvSVNSempNMXpmejRo?=
 =?utf-8?B?ZFZGeTRPd2h6VFZDeW5PNm9MazRQVnVweTJiWWtxd0NhYkd5UTMxNktrVThK?=
 =?utf-8?B?NWhrakNGL1RRekJaY3V0M0Y4UERBMjZlVEI5U0k3d0xDdmNTODB3WkRva1p2?=
 =?utf-8?B?bFVjZ2pTSC8xaHJ2WndxQ0hjQ3d4Y1B3MHJSWHZ4UEptNmNiV29hdmFGUUJO?=
 =?utf-8?B?L3N0NUJNSXM0UjhsTFFZR1N4eG1aM1FVSzkxQjVNUFBMU3BUUklaZWl0STZx?=
 =?utf-8?B?d1JwWlh1aDFwV1F0T2tPT1U5aE1DYUFTc2hiWHlMTy84NDgzM2p5OUF1MDVN?=
 =?utf-8?B?NTczZXpxcmZ0V1FqdTY1VUJxd2Q5SUViQXlNYWE3WVc3d3VocGluS0YxNFlH?=
 =?utf-8?B?RmFldlI4bDVwVFdRK0ZrcUw3b0huNkg1Z0FhSmMwWmwzclhBd1VzcEZmRitp?=
 =?utf-8?B?TGd2RE9jRW9BUGgzaEJwVFJHbkxTc2liejhUSy9MeE1nL3ZTTjNRRnROMFFj?=
 =?utf-8?B?clVhZHhUbktQWURHNWplN05lRGVISEJzY0E0eXlOQURsRjZmSFN5TDRzRFl5?=
 =?utf-8?B?dGdmTElmL3VXUU82NVpoQmc3NFJBVmFOZ1lRa2g4S3p6Wjkvd0lZalRYVnd0?=
 =?utf-8?B?K3Y2YVB5SG9Fd0Y3OWF6SHNpRVRUMHl0QlViY3l0Q0ZqWlF4aHNpYUNxL3Rj?=
 =?utf-8?B?M0kyMmtTQUJRWXZiUE53Z09kNU9zcDFVSW16SCsydjMrOWRKb2s1c082TTlZ?=
 =?utf-8?B?K1RXNDdQTUJhT1N5dmx0YlhkNDY3em1naUg3WjQ0QndzVng5ZFNtZkJzSHl1?=
 =?utf-8?B?WjZldWtYUEQ2SUZSbDJSWGduOEc0Y0dtVUdIT3ZTcDJyOXNtKzZuWFIxTUV5?=
 =?utf-8?B?cWMzZlhQaUlzNjBuTDJDZkFzb0x1UUtHRE40UmNKSmt0Q3A3aFpHMTQ5RjlK?=
 =?utf-8?B?VGtCckdidDk0b0ZTNWVMcDhUUEJnNE8rYmwwajRIaGJ5bEdKQUVndWZjdlNL?=
 =?utf-8?B?Skd6TjFvTmVJbjRKbXp1alBES2h1U1A4TXltanhaNW9VdFd6dW9HUVU5bnlW?=
 =?utf-8?Q?t2GQgDgPqz+U2738SUOZd6eO9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cc33f2c-131e-4ec1-9e02-08dab29d3dbe
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 13:16:04.3264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i8kEBRFC3b8HKOsUE9aC/d/OJyqvoAfKljj6cuSRoZvrrVxIqOhHEpx/X4x/5cUz9yF7zDW7uLVCIS9erI8ItQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7217

On 20.10.2022 13:37, Juergen Gross wrote:
> Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr
> accesses") introduced code resulting in a warning issued by the smatch
> static checker, claiming to use an uninitialized variable.
> 
> This is a false positive, but work around the warning nevertheless.

The risk of introducing a problem might be quite low here, but in general
it exists: With the adjustment you remove any chance of the compiler
spotting a missing initialization before use. And I'm not convinced using
0 in such a case would actually be ending up sufficiently benign.

Jan

> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -302,7 +302,7 @@ static bool xen_amd_pmu_emulate(unsigned int msr, u64 *val, bool is_read)
>  static bool pmu_msr_chk_emulated(unsigned int msr, uint64_t *val, bool is_read,
>  				 bool *emul)
>  {
> -	int type, index;
> +	int type = 0, index = 0;
>  
>  	if (is_amd_pmu_msr(msr))
>  		*emul = xen_amd_pmu_emulate(msr, val, is_read);



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:20:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:20:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426772.675436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVTE-0002l2-VQ; Thu, 20 Oct 2022 13:20:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426772.675436; Thu, 20 Oct 2022 13:20:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVTE-0002kv-Sm; Thu, 20 Oct 2022 13:20:24 +0000
Received: by outflank-mailman (input) for mailman id 426772;
 Thu, 20 Oct 2022 13:20:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Iaqk=2V=citrix.com=prvs=285ecbe66=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1olVTD-0002kp-KM
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:20:23 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f2956282-5079-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 15:20:22 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2956282-5079-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666272022;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=CyqtvLuCo9vPcS4ykOKHNf/TdY6KVRL/lttb5kuxJeM=;
  b=aF6ZCztJF3UfqwYXqTHj+ojMkLNjF6J+J0ybd9JF6l9A42PSmO/ApCMg
   NN2nnZvzNVazthHGD5sxElvXfe/dWgaUwzuqEF9yyrCR+o2o5A7z1Xvpi
   GonWnmmkTyOiLj+p4HfssY69eUBk4Gjn20qjjoW28//M1sRERZy2TCeVu
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 85684026
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VYI8G62Si8+ZMlKIm/bD5axxkn2cJEfYwER7XKvMYLTBsI5bpzIPm
 2NOUG+Eb6uLa2Pwf4tyPIqwpEMHupXUnd4yTgtupC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlA5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUV68s0BVBh/
 McGF2gtNAyRoMiXz/G0H7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqIJIzWHZ8L9qqej
 mj0wFumOQ4wDdrF1D28q0yAuO7ovgquDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe9DW8ynUlPCSuVzAQDFZEHgRM7TKqfPaWxQnx
 3LKm+LGDAdxj+W1E26P0Z21onC9bH19wXA5WQcISg4M4t/GqY41jw7SQtsLLJNZnuEZChmrn
 WnU8XFWa6E7yJdSiv7lpQyvbyeE/MChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU
 JTpdqGjAAEy4XOlznHlrAYlRuvBCxO53Nr02AcHInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia
 1LJtAVa6fd7ZSX0M/YuM97tVZ93l8AM8OgJsdiNNLJzjmVZLlfbrEmCm2bKt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLegvp6pdynnpW7TqKHfjTlk37uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyikUwOAbygPXWLrOb+7zkidBAGOHw/kOQPHsbrH+asMDtJ5yP5qV/5R7FYog==
IronPort-HdrOrdr: A9a23:P+peJKrDsh/LIit1r72qW78aV5oTeYIsimQD101hICG8cqSj9v
 xGuM5rsiMc7wxhPk3I+OrwXJVoLkmxyXcY2+Ys1PKZLXDbUQiTXeRfBOnZsl7d8kTFn4Y3v8
 pdmupFeb/N5DBB/L7HCWKDc+rIruPozJyV
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="85684026"
Date: Thu, 20 Oct 2022 14:20:09 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH for-4.17 1/6] test/vpci: add dummy cfcheck define
Message-ID: <Y1FLCaAwscvJ3Lj3@perard.uk.xensource.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-2-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221020094649.28667-2-roger.pau@citrix.com>

On Thu, Oct 20, 2022 at 11:46:44AM +0200, Roger Pau Monne wrote:
> Some vpci functions got the cfcheck attribute added, but that's not
> defined in the user-space test harness, so add a dummy define in order
> for the harness to build.
> 
> Fixes: 4ed7d5525f ('xen/vpci: CFI hardening')
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:21:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:21:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426777.675447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVUP-0003J4-AB; Thu, 20 Oct 2022 13:21:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426777.675447; Thu, 20 Oct 2022 13:21:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVUP-0003Ix-72; Thu, 20 Oct 2022 13:21:37 +0000
Received: by outflank-mailman (input) for mailman id 426777;
 Thu, 20 Oct 2022 13:21:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Iaqk=2V=citrix.com=prvs=285ecbe66=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1olVUO-0003Ip-C8
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:21:36 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d1b9f73-507a-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:21:34 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d1b9f73-507a-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666272094;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=m8Z/x3pSZNAayr0xIBnBZnORN5AFqYVFRDW6DYQ/zYY=;
  b=dN/LW9WQdOfIV3yOTFSQlvWREWogE8cUJgVLZ1IGOiWlAuN52Gzt6M7E
   lzqEiuUn/5tvp1+fykGGYpyaySrerbyiCiUNe+ZPCbVglrMtykI4A1z/O
   ClTmEVLB2ctqOj+hVjAHbOdJt1C4Rx83EKmWUDmRRenjZXapu8pXtTM1j
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82266334
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IQziNqLipZ8SPZODFE+RrpUlxSXFcZb7ZxGr2PjKsXjdYENS12NSy
 zAbW2CCPPuCMTb9e413Oo+z9k0Cv5bdm981HAdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FaoV+sF+J0Ncz
 80dLTEfYiqDv7mYwIvuH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO
 YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYICPJILRHpk9ckCwl
 Fv9oHj2QUsmDNmY+CKptSz827LIgnauMG4VPOLhraM76LGJ/UQMDDUGWF39puO24mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobRsn1
 niAufH7Pw1qtbyHRUidzuy6rQrnbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhr2/vD0ohgJChI7t45Pxidwf8abaoOh8jA3Bt4Qfd/CHjFtU
 JXp8vVyDdzi77nXyURho81XRtlFAspp1xWF2DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYiX0NPYnP97vUJlwpUQFKTgCfqmOBuein7ArLFPXlM2QTRT4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAeLqxMm+eZznEgWnDqLLbiilkjP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPQkkQOAbOhPnWKmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQgnN19e5LWsdRrFY
IronPort-HdrOrdr: A9a23:dkyGYaw5se5hVAIdXhmWKrPwKr1zdoMgy1knxilNoRw8SKKlfu
 SV7ZAmPHjP+VEssRAb6LW90ca7LE80maQY3WBVB8bFYOCEghrLEGgB1+vfKlTbckWUnNK1l5
 0QEJSWYOeAdGSS5vya3ODXKbkd/OU=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="82266334"
Date: Thu, 20 Oct 2022 14:21:22 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
CC: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH for-4.17 2/6] test/vpci: fix vPCI test harness to provide
 pci_get_pdev()
Message-ID: <Y1FLUsSUJv799QsO@perard.uk.xensource.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-3-roger.pau@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221020094649.28667-3-roger.pau@citrix.com>

On Thu, Oct 20, 2022 at 11:46:45AM +0200, Roger Pau Monne wrote:
> Instead of pci_get_pdev_by_domain(), which is no longer present in the
> hypervisor.
> 
> While there add parentheses around the define value.
> 
> Fixes: a37f9ea7a6 ('PCI: fold pci_get_pdev{,_by_domain}()')
> Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:25:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:25:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426784.675458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVYN-00040j-Qs; Thu, 20 Oct 2022 13:25:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426784.675458; Thu, 20 Oct 2022 13:25:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVYN-00040c-Nw; Thu, 20 Oct 2022 13:25:43 +0000
Received: by outflank-mailman (input) for mailman id 426784;
 Thu, 20 Oct 2022 13:25:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VPXW=2V=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1olVYM-00040W-DH
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:25:42 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1440441-507a-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:25:41 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8440.eurprd04.prod.outlook.com (2603:10a6:20b:413::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 20 Oct
 2022 13:25:40 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 13:25:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1440441-507a-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n0yEG32n9cRGUV7w8sAdet4lpkKWEH2SylJWjSUXGrmOeh2na359vTJdPE688QX+9J2Wue2VzBuGgdDkIcrbQNwzSci4CsVNMUMQrvxsg+4q6ZxdyMJ78Elq+GcSG+U/Z+E3Fd5SOgHn2JI1j0wLfndVQMaCQZ7jYU2mP1pxH3zbiGZRn3OyAiXGyMb7vA5zQWRD0BJQ6bi6TF4yGjRjlbub5/nsFQRqlOIrNaOVwc35iCKkakNCFTBNHbePjSp0QbOrYKVDy71bTZG1jzbzdfOPrRNijAbPTwCtkYFekLb3C8BXA0pkzfET0+37aXj5vy/MlF3KxCheu60enuqI+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j4huBr3a8iPd0vXhBJDxD2ZXF+mKTdG4nq3yNO8j/UU=;
 b=fLEqqUlLnQ6KNRiYCXxQN147Fg1zBs9MagdwRv9JhYWABhbJX5xxhFk21EJy8ia4KlYVouYeouY327ohgyjcyDrFXkFxyhTMmy+vYJ+31lTy5SeIdaOY+/oo2lOQmgL/aHG5jHFiSA+SAQjz+EMjsP21l7fT3XauBke6z0OID2pBVKx4npUYBnu/5H4RKOG+r9fy1fxmSVFgNr1SSdPeeK5lncwzgYS/ud4Lg+DT9S9Wlmx2Mo4NYkZzda9rKk3kt5MBkma1tx18DW0k0ET0DFeCGUe1wIJpUxRMSR9zYeok30u/6+1iiq6XmmRztEma7MmybD2Jiny6PzUYX+WFgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j4huBr3a8iPd0vXhBJDxD2ZXF+mKTdG4nq3yNO8j/UU=;
 b=Aw8+3kOb8aT6N7KPEkuT/ZoKDf0oivboQiPkrHi2+f1jWAocovG9f/WXrW9EiWBIsFOX2z4J/9HpRGUu7Ls4QOTHd8O906FyY3ALEgb2gIZCz85xu2up8GfulnBL5szDQxg6XrPHCJYJXf/1DZmDp+uMfJ4RN6RrL5NCwzzVJnmC8K5mQ/R54DE4ZLyjP1IXV4kiOzy8nhnENYSzvAX61zmX79PIi51HwjBIx00voZav5/lXSU4fnxpBsr3kqUDIyv/041BRjXav2kyROm6p8MMTqK/1CtMCmu79W73O/m+YfInuLUeK5iZI/9RCElCmqJhE0q8EP/e+T5Nv4XUiIg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <865a2712-d694-122f-eb10-e206b350c7d6@suse.com>
Date: Thu, 20 Oct 2022 15:25:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Intended behavior/usage of SSBD setting
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xenproject.org
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
 <2f5ec31e-2ac5-2b22-8801-9ebdc4946962@suse.com>
 <Y1FBGTx5cSrkdVbZ@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1FBGTx5cSrkdVbZ@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0019.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::6) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8440:EE_
X-MS-Office365-Filtering-Correlation-Id: ee2690b4-b898-4a7c-c03f-08dab29e94e0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mcC3RimA7zwgFnwkNmJSxr/pwUzV6cSJR4qAPdMfyMgqvArMy516qrFNXiQ2jFSk6G9N9afvIZ7QSNf15JbHRAV+Wj4j1F+zPrqpfXCflnzkPQc89/BHbyq3aF0AW6SRVTwtiUdrJcd8urcoAx874xJbvodkzNHPm0n2nh6OufV5zrh8BGh3yCE0AntvXTkqpQICyg+7JvAKXSPX5YkN05GV7N+b4nEJ+DJXv2JmGqaNNh84OAi4wxmg+XxLMGqr++tfJ/JyYS+RpOW1oYUTRMfahbmtOISm8BtS6XHD+LF3kFOe33j4aFVJHhh7k68B5q093Ej6EDrKjvnpRXq0XCYitqlzOTJlzpccX48MAB9NDWk/JqtTGBxUG5xYAdNhCbybjkkMbf7q+/88cifKYi4b12csRqGKZ3HRPqtyhtUkGmEHz98Q57TorXOL51K+NxkT0vY/pyv+avxOqvd8GA9OzpdKtAcqVB8yQ7kqLMkhCKEBB00YTshkh9ItT7SaObYKOYkp7wsLtJEwWP3wZj1ssHmIXRtN0DLLahG2LqdtRJPsx37brFi1BPWlm/UgXh1fjab6aoQt5yu6QSQFn66VSxaCobFDyF6vDM7xfJIZwd1E5cm5Livg0j4u/7ivJoIsCmVqIoWyn9vhyXasciQg4YAVrfuTXt7+VZKDmEuGam9f3ef44GAE4wP1jn184asKpJ+Uz34AVVFmWyiQx0G9WS6sdxySYyjtuzY/pjV6nz77WZrjCzVmjgPKh9G5UpIDFeTkJC3RfjVj2QEXSd0s3oL77WrDlAI9W3qbkvc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(136003)(396003)(366004)(451199015)(186003)(2616005)(31686004)(66899015)(2906002)(36756003)(31696002)(86362001)(38100700002)(83380400001)(6506007)(53546011)(6512007)(26005)(41300700001)(66556008)(66476007)(8676002)(4326008)(66946007)(478600001)(6486002)(316002)(6916009)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NVgySy95QmhUY2J5L29jSitReWVRTlN3MUp4R2xhUmxOdStBWUNDNVdoSVpI?=
 =?utf-8?B?THUzWGNreTY4dlhCVmN5cy95R1MrbFk0S0lPQ00wbEpIUW9zR0lGVFI5S2Rn?=
 =?utf-8?B?UnB0Yk5yNktlWWNoemFGL2RsMnp6S0tiNUQ3OW1PVzNFRHE0MHhrNFowc0or?=
 =?utf-8?B?QUJEbXBKYTJ4WTJlbGJRL3RISzIzVldZZHdEYy9SQ0Q2TjF0SHF0VFZlS0U3?=
 =?utf-8?B?RFpXcGpGb1N4emxFaVk2U2tlS2IybDVPdnZaVnkyR3g3R3JQZkJSZm5oNjFk?=
 =?utf-8?B?YTBnZGFRZUppeGVFQTRLRGZnTHkxYzlPaDZlREFzV0NoZldTbkRzQ3dlUFFZ?=
 =?utf-8?B?Qm52cUptSlE5emE1M3B3Z1NMaTErcmxVQ281SjRHM1hxenhqVFJGUUNnZVBL?=
 =?utf-8?B?V0JBSGMyS1l3UG85S0l5WkJSZnFvRVJJb3kzTWlYZXZ6MnVUbldkOGFXbFN3?=
 =?utf-8?B?MXRsa3g2VjVSSzZodzRLQ29NMWs3NjhzS0cvOVdaZU9EOHZPbG85MFpCamR1?=
 =?utf-8?B?cmF2NzBiajV2bTRpTEdZdTM2R2xZakgrSDlTdU1nZHphSGd1KzI5UXNUOXp1?=
 =?utf-8?B?WSt1TWVieE9mNmhHalFKSWFibTNRYWNlVm12Rmh0Yy9DU2Y5Ymp0Y3hzcDFQ?=
 =?utf-8?B?VkYwZUQrQm1WeE5CbU9JeC9veVBXMzdrNFZpV2lhclB1Ly9mRERoS0pKK3ZL?=
 =?utf-8?B?WjhKaUMzTGpVV1NaT1ZXcGNQL3IwTGt5NXBlek5va1NTOXhzYUdlNTlLbExL?=
 =?utf-8?B?WnpMKzdZT29sREEyTXFzbEdneVFPWmNDbmwyQ3NxZHR3S0FNK2VmMEJ1MFJk?=
 =?utf-8?B?WTk2bmRzblkyaHhsTTFMbGxxanpsTG9vM2xycXZ4VEtCNkdxc3VnYkcxeEZ0?=
 =?utf-8?B?ZW9saTZpREU1L2QySXpjUGJ3OTl5TkxOWUp1eTNlWUZ4TUdJRU5XQzhXdmZU?=
 =?utf-8?B?WkhYZHRxSTIrN3Q4ZzdaUGowbEdwVEo5c1FnMGhHNGJsZXpxcE1SVmhHK1pT?=
 =?utf-8?B?ZWptdldKWmhpWmlFUnNJT01MSmcrMUcweXhTN0Qxb0xBcEh1NFhKd0pUcnAx?=
 =?utf-8?B?RHk4ZHZaQTJrQ0ZWNGxobFBiY0NKOGlxbENYVEJEb1NYWVROZ094dXd5dU5H?=
 =?utf-8?B?WDZZSjU0b1ZMQi9NOVp6ZTk0bStFcjI2R2ZWUlVwMkU1OW0vSnRCamtBMG5l?=
 =?utf-8?B?L1BHZWJJRDdablJCeTdVOThFZXpSdGFqTGhqK0NjdFFFWTlOSnlkMFFIQ0dv?=
 =?utf-8?B?b0dKYWZrQUlkVkhyanR4ei85UG1ScGxodEg2YXlXY3Q3d0lFMEttUWJyZzhr?=
 =?utf-8?B?LzlEZGR3NXdxbWRIMTN1djUzZXBoWnl2VFVuem8xZjVMZk90TVIydjYzbG9D?=
 =?utf-8?B?cW5WbmVZbFE3c0NudEEzNVoxeTBZLzlTZVJYWGUycFI4ZUZvN3E0cGVkamRJ?=
 =?utf-8?B?SnRXK0ZmT0ZyNW02ek04dDI1UU51cS8vanNDN0NaS0tvdi9IcFYwRk5SWjRq?=
 =?utf-8?B?eGFpdGl6N3Q4M1BUMS9mSkRDaStxVy8zQlFPa285Mk1PTU9ONVh1UFNYaFlT?=
 =?utf-8?B?cGREbHVrR3ViTkEzK2JDVmQ5WFF5SlRTREVJUytzSGFUTWRnc0ZpbDdBMElj?=
 =?utf-8?B?dFNGdnk3TG1XRHNCOGFCaFI2OXhqNHFXTDJmSXRnamtDWnkzaUpwZ3Q1dHBC?=
 =?utf-8?B?U3diWnhSU3o5VjhjWjRncGdYZTJSOVU2SGtmdjlvRGFkL1BOUUsxR0JRT1N1?=
 =?utf-8?B?NzZZTDlGdFA2RTdMV2V1aW1talhtVGxLRnhiQy82dHRtMVNqcnM5MW0wRFJ3?=
 =?utf-8?B?U283UEpvcldrN0RSZlNUUlFFTkFsTjBzcm5PVGRjT0pkcDQyNkZ5eXVJRXhx?=
 =?utf-8?B?bHREUzNwQnBydno5RjRIM1Zkb2krRzRxalJzZExZalFrT0VhYk1DaHJjQ3ZS?=
 =?utf-8?B?MTR4enB2N2FqaHhUQVZXTk5naWc0Vk9Td05iZUdvYjhNOEpNY1NTQzFxbU15?=
 =?utf-8?B?TjRTc0V6VytVQnBYK2oxSkhFK0lzc2dXR2l3QTJkWHd2eWtQNS9lcERvS3Np?=
 =?utf-8?B?N25YZVAwamlEeTNkTUhCZFJ0TWFKY3IvRHNuTmFYUWZRZzlKdWhMV0hrdGNG?=
 =?utf-8?Q?fwqJl4kwkNzjp+yHChxlMgYn6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee2690b4-b898-4a7c-c03f-08dab29e94e0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 13:25:39.9618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DarZIgFr+P+YA74EWdIacaAretrfnuPWyUkBcZBYXlx5J0VRcNlmU+OIpDIz40PjAUPRNitA9LjmQ3Qt3TyOjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8440

On 20.10.2022 14:37, Roger Pau Monné wrote:
> On Thu, Oct 20, 2022 at 01:22:20PM +0200, Jan Beulich wrote:
>> On 20.10.2022 13:01, Roger Pau Monné wrote:
>>> Hello,
>>>
>>> As part of some follow up improvements to my VIRT_SPEC_CTRL series we
>>> have been discussing what the usage of SSBD should be for the
>>> hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
>>> that has an out of date description, as now SSBD is always offered to
>>> guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
>>>
>>> It has been pointed out by Andrew that toggling SSBD on AMD using
>>> VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
>>> have a high impact on performance, and hence switching it on every
>>> guest <-> hypervisor context switch is likely a very high
>>> performance penalty.
>>>
>>> It's been suggested that it could be more appropriate to run Xen with
>>> the guest SSBD selection on those systems, however that clashes with
>>> the current intent of the `spec-ctrl=ssbd` option.
>>>
>>> I hope I have captured the expressed opinions correctly in the text
>>> above.
>>>
>>> I see two ways to solve this:
>>>
>>>  * Keep the current logic for switching SSBD on guest <-> hypervisor
>>>    context switch, but only use it if `spec-ctrl=ssbd` is set on the
>>>    command line.
>>>
>>>  * Remove the logic for switching SSBD on guest <-> hypervisor context
>>>    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
>>>    hypervisor code with the guest selection of SSBD.
>>
>> * Give the guest the illusion of controlling the behavior, but run with
>>   SSBD always enabled when "spec-ctrl=ssbd" is in effect.
> 
> Right, I've also thought about this option but forgot to add it to the
> list. That would limit to only allowing enabling ssbd for the
> hypervisor code, but not explicitly disabling it, ie:
> `spec-ctrl=no-ssbd` won't be a valid option.

Well, it would be valid to use to override an earlier "spec-ctrl=ssbd",
to revert back to whatever the behavior is when no option is specified
at all. It wouldn't strictly mean "no SSBD at all".

>> * Give the guest the illusion of controlling the behavior when
>>   "spec-ctrl=ssbd" is in effect, running with the OR of guest and host
>>   settings (switched, if necessary, as vCPU-s are context-switched).
> 
> Right, this could somehow reduce the number of toggling, but would
> still require having code to handle guest <-> hypervisor context
> switches.

Why? When we're running with the OR of both values, there's no need to
switch when exiting or entering guest context. The only time an
adjustment would be needed is when the guest setting changes (because
of the guest altering the setting, or when switching vCPU-s); obviously
never when the host setting is "on".

Actually I now think that the two points I added actually describe the
same mode, just by somewhat different wording.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:25:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:25:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426785.675468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVYU-0004Hz-2J; Thu, 20 Oct 2022 13:25:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426785.675468; Thu, 20 Oct 2022 13:25:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVYT-0004Hs-Vq; Thu, 20 Oct 2022 13:25:49 +0000
Received: by outflank-mailman (input) for mailman id 426785;
 Thu, 20 Oct 2022 13:25:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olVYS-0004H2-Hn
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:25:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olVYQ-0008NQ-5U; Thu, 20 Oct 2022 13:25:46 +0000
Received: from [54.239.6.185] (helo=[192.168.1.74])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olVYP-00051R-VP; Thu, 20 Oct 2022 13:25:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Z83FGAYtnjKsvqfju3zJYZ++2A5BC6NbzUFcINsFP4g=; b=vrhY8mDUMvebQBnaXs3mWR/H9I
	cO29H+uzR/GYHKmUDyRBjqZ9P9ANA9YMQHiotCAodhbcvBckNndtyWQu68MhgMdgYrTGNSTvQCyCr
	5E3cim4yDl8JgnaI/H6vk2Ei+C7+9Wlx6HG7PxRjhUq0eeCr1GXeWMvwhou0s7mYKEUw=;
Message-ID: <a87302d7-c9b0-d6b9-9d8d-ebbf6b85f389@xen.org>
Date: Thu, 20 Oct 2022 14:25:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: Policy: A release acks for the release manager's patches (was Re:
 [PATCH v5 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init())
To: Jan Beulich <jbeulich@suse.com>, George Dunlap <dunlapg@umich.edu>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>, Henry Wang <Henry.Wang@arm.com>
References: <20221018142346.52272-1-Henry.Wang@arm.com>
 <20221018142346.52272-3-Henry.Wang@arm.com>
 <CAFLBxZZ59zkuNJM1vQSv_Syv8i0Q_dAFk0p-JXY4oFs0cCUSnQ@mail.gmail.com>
 <adc567a7-c338-477d-bf8d-b73300c36f6a@suse.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <adc567a7-c338-477d-bf8d-b73300c36f6a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 20/10/2022 14:12, Jan Beulich wrote:
> On 19.10.2022 17:28, George Dunlap wrote:
>> On Tue, Oct 18, 2022 at 3:24 PM Henry Wang <Henry.Wang@arm.com> wrote:
>>
>>> Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
>>> when the domain is created. Considering the worst case of page tables
>>> which requires 6 P2M pages as the two pages will be consecutive but not
>>> necessarily in the same L3 page table and keep a buffer, populate 16
>>> pages as the default value to the P2M pages pool in p2m_init() at the
>>> domain creation stage to satisfy the GICv2 requirement. For GICv3, the
>>> above-mentioned P2M mapping is not necessary, but since the allocated
>>> 16 pages here would not be lost, hence populate these pages
>>> unconditionally.
>>>
>>> With the default 16 P2M pages populated, there would be a case that
>>> failures would happen in the domain creation with P2M pages already in
>>> use. To properly free the P2M for this case, firstly support the
>>> optionally preemption of p2m_teardown(), then call p2m_teardown() and
>>> p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
>>> As non-preemptive p2m_teardown() should only return 0, use a
>>> BUG_ON to confirm that.
>>>
>>> Since p2m_final_teardown() is called either after
>>> domain_relinquish_resources() where relinquish_p2m_mapping() has been
>>> called, or from failure path of domain_create()/arch_domain_create()
>>> where mappings that require p2m_put_l3_page() should never be created,
>>> relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
>>> in-code comments to refer this.
>>>
>>> Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M
>>> pool")
>>> Suggested-by: Julien Grall <jgrall@amazon.com>
>>> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
>>>
>>
>>
>> Henry brought this patch to my attention because it needs a release ack,
>> but it doesn't seem proper for Henry to be the one to release-ack his own
>> patches. :-)
>>
>> I propose that a suitable rule would be:
>>
>> "If the release manager themselves have submitted a patch which needs a
>> release ack, then the patch needs a release ack from one of the Committers
>> who is not involved in the patch."
> 
> Like Andrew I think a self-release-ack, as was common practice in the past,
> is quite fine. These are entirely different hats that the person would be
> wearing.

I have done it a few times when I was RM and I remember been unease in 
some cases.

I can understand that some release manager may not want to do it to 
avoid any conflict of interest.

IMHO, it would be better to have a policy similar to what George 
suggested. So the way the patches are deal is consistent across all 
release cycles.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:26:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:26:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426790.675480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVYr-0004wN-D7; Thu, 20 Oct 2022 13:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426790.675480; Thu, 20 Oct 2022 13:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVYr-0004wE-89; Thu, 20 Oct 2022 13:26:13 +0000
Received: by outflank-mailman (input) for mailman id 426790;
 Thu, 20 Oct 2022 13:26:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2/78=2V=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olVYp-0004rg-8P
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:26:11 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2ad4250-507a-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 15:26:10 +0200 (CEST)
Received: by mail-wr1-x431.google.com with SMTP id bp11so34440543wrb.9
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 06:26:10 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 p11-20020a05600c358b00b003c21ba7d7d6sm3137473wmq.44.2022.10.20.06.26.07
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 06:26:09 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2ad4250-507a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=Ao80pQoZgJGEAb2bodmw5nlbxR+ZMAoIRtnrKk8Ulvg=;
        b=GG8LBf5MqqJv6YT+kENrU5dCgna6fE5XzYqlSlUpJjCNv3JZ7KVoPU0b7Vu/sKur9B
         ZFC9OdOkxuZxC/VZrWzrYf+0gzjWbvyagtaKYv9TIz64LwEQr8fexboSzjT0ZKGAhxAW
         1cADUL0nguDmWMFRPM1VzovKJSMlnNxc/HCP/69yhNTxb6AS2lzIt3Ntml+rQvwWyQ6X
         WiGiHyikIi52GofnS8eD5b1PIi4DH9KRbbTm6gBJScS36SPBREqKzSH/nwMMXwDJb+CV
         WHfuqdVQ0OdhM+96pbDXiuVjF7Pa2QtbtXkQmZsqe6KavhLhhW04EYltLA9l7Z1mkulf
         iOeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Ao80pQoZgJGEAb2bodmw5nlbxR+ZMAoIRtnrKk8Ulvg=;
        b=UnDk81J5YVDqcTQ1wNZlZxtNgH/q/aUmbR5krMllK74E6pn5DpqtFIUhGrFQyWC1GR
         Yps4mmDQ5vNfTuqboD1cKjdlx1RY4nD/aQI5thMnIu8GGyn6j6W7yabQuhMlg/Z4BQZR
         PDxk69B9J5slVvvwWv1PQ8pc45BOWP0Xeei2H26BX2K9cB7M6Dz5bxCIi4rpbt6Kwn2n
         /8/CkeJ/suBiYQ86tkXEJZXNEU0p1R9aNNaecpwG0F5seucpZ05bVBcV05jGAzHMLOae
         TNbPRzsPdMYCD/yB0UXuuyeoxak7ju21CcPX33YTfJLFNpVVX5llRStXHLlQxE98ZanF
         riCg==
X-Gm-Message-State: ACrzQf1eIcR8ccBIfrQyBCEqmNyOjAUnZtRWFrP21vrt6jEgYX+7MJGC
	LJ3dXKHL0TxbG+V9v/vi979YUA==
X-Google-Smtp-Source: AMsMyM7Om5c8Ma3OvC6cMGxntd1D1a/PZuVouKbHMbYx2ESKorzb5ib/YpCZS+Edolmhg6R8/n71iQ==
X-Received: by 2002:a5d:5b1f:0:b0:22e:51b0:2837 with SMTP id bx31-20020a5d5b1f000000b0022e51b02837mr8764681wrb.132.1666272369772;
        Thu, 20 Oct 2022 06:26:09 -0700 (PDT)
Message-ID: <0f964c69-e3c7-b40a-be5e-85ae0471916d@linaro.org>
Date: Thu, 20 Oct 2022 15:26:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v12 16/17] tests/qtest: netdev: test stream and dgram
 backends
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-17-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221020091624.48368-17-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/10/22 11:16, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   tests/qtest/meson.build     |   1 +
>   tests/qtest/netdev-socket.c | 417 ++++++++++++++++++++++++++++++++++++
>   2 files changed, 418 insertions(+)
>   create mode 100644 tests/qtest/netdev-socket.c

> +int main(int argc, char **argv)
> +{
> +    int ret;
> +
> +    g_test_init(&argc, &argv, NULL);
> +
> +    qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
> +    qtest_add_func("/netdev/stream/inet/ipv6", test_stream_inet_ipv6);
> +    qtest_add_func("/netdev/stream/unix", test_stream_unix);
> +    qtest_add_func("/netdev/stream/unix/abstract", test_stream_unix_abstract);
> +    qtest_add_func("/netdev/stream/fd", test_stream_fd);

The stream tests don't work for me (testing on Darwin).

ERROR:../../tests/qtest/netdev-socket.c:99:test_stream_inet_ipv4:assertion 
failed (resp == "st0: index=0,type=stream,\r\n"): 
("st0:index=0,type=stream,connection error\r\n" == "st0: 
index=0,type=stream,\r\n")

> +    qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
> +    qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
> +    qtest_add_func("/netdev/dgram/unix", test_dgram_unix);
> +    qtest_add_func("/netdev/dgram/fd", test_dgram_fd);

The dgram ones work.

> +    ret = g_test_run();
> +
> +    return ret;
> +}



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:26:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:26:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426796.675491 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVZ7-0005W3-PK; Thu, 20 Oct 2022 13:26:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426796.675491; Thu, 20 Oct 2022 13:26:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVZ7-0005Vw-MS; Thu, 20 Oct 2022 13:26:29 +0000
Received: by outflank-mailman (input) for mailman id 426796;
 Thu, 20 Oct 2022 13:26:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olVZ6-00040W-On
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:26:28 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd034d3d-507a-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:26:27 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3B009224DF;
 Thu, 20 Oct 2022 13:26:27 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1ABD913AF5;
 Thu, 20 Oct 2022 13:26:27 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id vNYyBYNMUWMARAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 13:26:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd034d3d-507a-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666272387; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type;
	bh=YpvYm802qw2Y9fkEp0cRacbmc6NWv8VBCJJBtQImmuQ=;
	b=LENFSgC7uA3dk0GyAU6CXT6Uv4YLkExmP2Xc57RjNbIDpnBfmWkPYpYEKi2EVPxEVHDSfm
	WzeLo3r3NjxrX75JTGjvMB+LiOzR4xlvo/lEn8+Be5DY2hCl8yUY7/0HbZnj/YoN2H1vaV
	F/hLlNVcDkOIQuZ+c2YDcSszuxJlWHU=
Message-ID: <6cccc8b6-4073-69bb-e414-2b38d5081004@suse.com>
Date: Thu, 20 Oct 2022 15:26:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>
From: Juergen Gross <jgross@suse.com>
Subject: Xen RTDS scheduler locking
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------qRkJvCgTU0x8KhjlOfYkBltF"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------qRkJvCgTU0x8KhjlOfYkBltF
Content-Type: multipart/mixed; boundary="------------pZg04xQ3wErRbbHMMIlCcpmG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>
Message-ID: <6cccc8b6-4073-69bb-e414-2b38d5081004@suse.com>
Subject: Xen RTDS scheduler locking

--------------pZg04xQ3wErRbbHMMIlCcpmG
Content-Type: multipart/mixed; boundary="------------1dPTtYcDRihDwhvOtzt0Zjgm"

--------------1dPTtYcDRihDwhvOtzt0Zjgm
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

TG9va2luZyBhdCB0ZXN0IGZhaWx1cmVzIHdpdGggUlREUyBzY2hlZHVsZXIgaW4gWGVuIFsx
XSBJIHRoaW5rIEkndmUgZm91bmQNCmEgbWFqb3IgaXNzdWUgd2l0aCBsb2NraW5nIGluIHRo
ZSBSVERTIHNjaGVkdWxlcjoNCg0Kc3ZjLT5mbGFncyBzZWVtcyB0byBiZSBub3QgcHJvdGVj
dGVkIHByb3Blcmx5LCBhcyBkaWZmZXJlbnQgbG9ja3MgYXJlDQp1c2VkIHdoZW4gZG9pbmcg
bm9uLWF0b21pYyB1cGRhdGVzOiBwcnYtPmxvY2sgKHRoZSBSVERTIGdsb2JhbCBsb2NrKSwN
Cm9yIHRoZSBwZXItc2NoZWR1bGVyLXJlc291cmNlIHNjaGVkdWxpbmcgbG9jay4NCg0KSSdt
IG5vdCBzdXJlIHdoYXQgd291bGQgYmUgdGhlIGJlc3Qgd2F5IHRvIGZpeCB0aGF0LiBPbmUg
cmF0aGVyIGVhc3kgd2F5DQptaWdodCBiZSB0byBsZXQgdGhlIHNjaGVkdWxpbmcgbG9jayBw
b2ludGVyIHBvaW50IGF0IHBydi0+bG9jayAobWVyZ2luZw0Kb2YgdGhlIHR3byBsb2Nrcyks
IHdoaWNoIGlzIGVhc3kgZG9hYmxlIChjcmVkaXQyIGlzIHVzaW5nIGEgc2ltaWxhciBzY2hl
bWUNCnRvIG1ha2UgdGhlIHNjaGVkdWxpbmcgbG9jayBwZXItcnVucXVldWUpLiBJJ20gbm90
IHN1cmUgd2hldGhlciB0aGlzDQp3b3VsZG4ndCByZXN1bHQgaW4gaWxsZWdhbCBsb2NrIG5l
c3RpbmcgKHRyeWluZyB0byBncmFiIHBydi0+bG9jayBpbnNpZGUNCnRoZSBzY2hlZHVsaW5n
IGxvY2spLCB0aG91Z2guDQoNClRob3VnaHRzPw0KDQoNCkp1ZXJnZW4NCg0KWzFdOiANCmh0
dHA6Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9ncy8xNzM0ODgv
dGVzdC1hcm1oZi1hcm1oZi14bC1ydGRzL3NlcmlhbC1jdWJpZXRydWNrLXBpY2Fzc28ubG9n
DQo=
--------------1dPTtYcDRihDwhvOtzt0Zjgm
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------1dPTtYcDRihDwhvOtzt0Zjgm--

--------------pZg04xQ3wErRbbHMMIlCcpmG--

--------------qRkJvCgTU0x8KhjlOfYkBltF
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNRTIIFAwAAAAAACgkQsN6d1ii/Ey+p
/gf+LV25j3R0pEC9AZinvv1BCrBqw4lpvF9x11nkM4q9LMQK/L1Wzr1Q9wNvoEhxAddFiKeO5lm8
ZI/0gn8JU1anxiFdWa6zMz/fLoBGfyTghYsoxyXhQS68034+/qvzb2GZl+0AWNPlm6GfcRWcb4pX
gfGZ7GHNK3M9a9RJxshMgtgco7hX9fjQXGN/uA+zI45QLEa1Dk75s9pVsI2idRGd5R7LXntiRHqD
nciw/IBZmpQuGLuE815H93i+J8+MkPL74ac385wu7yeRYp+0OZqQSVIfr5Oz+jlyCi7kGLcZTuCc
T8Ixwd//VCuLkWOLQLTiUtehXRr5tTQVoeYvMcvSCg==
=V5FF
-----END PGP SIGNATURE-----

--------------qRkJvCgTU0x8KhjlOfYkBltF--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:29:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:29:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426807.675502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVcK-0006PR-81; Thu, 20 Oct 2022 13:29:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426807.675502; Thu, 20 Oct 2022 13:29:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVcK-0006PK-5N; Thu, 20 Oct 2022 13:29:48 +0000
Received: by outflank-mailman (input) for mailman id 426807;
 Thu, 20 Oct 2022 13:29:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Iaqk=2V=citrix.com=prvs=285ecbe66=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1olVcJ-0006PC-A6
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:29:47 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 428d2189-507b-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:29:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 428d2189-507b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666272585;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=aWOjyxBt9oAQgjedR8p8FAX5XibGH38ijrGq3nkJQDw=;
  b=gcoWQBP4JFdpWSlx8TJcTbeYhXUe9bFUmI9kU9tb4XVxw+EltjRBFCDY
   XAcVetSQukLYzhyWEPdIgwfp5sq1+njW0iSMLK/HAfxf5QX7y+/xUBTXj
   j9MYmILinHmlYVzpIV2dMSS2+6G81R5ltd2SreSc+PntXzI/jXozh2M0t
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82266859
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nTWSJqJypPJKabWpFE+R25UlxSXFcZb7ZxGr2PjKsXjdYENShGMDz
 mEYW2yFafuPMWKhL9sjaozko00Ov8XcydNqG1ZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbBJqr8sOX0Vy
 fAVIhYVdjCJrMHx/K3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO
 YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYICPJILaGJQ9ckCwm
 D3q2E32XU8hOvuH4Aqn8layrN7+gnauMG4VPOLhraM76LGJ/UQMDDUGWF39puO24mauVtQaJ
 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O8037hucjJXd5QmxD3IBCDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8kGLiYHMtMTQ+aSIOaxMdw9PIg8YPkUeaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8N8n9hO0yT5FWy13N2ZDB4wWvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMIQXO8gtKFHcoXsGiausM4fFyRJErE3CE
 c3DLZbE4YgyU8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7IdykEW9EO9fWHPXN7hRxPrd/G3oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcqv+p0GKLHfflcO9aNII6a5/I7NsrdNx8x9/tokN
 FnkBie0FHKXaaX7FDi3
IronPort-HdrOrdr: A9a23:CrMQxKw5+qOGSYH2n7uHKrPwKr1zdoMgy1knxilNoRw8SKKlfu
 SV7ZAmPHjP+VEssRAb6LW90ca7LE80maQY3WBVB8bFYOCEghrLEGgB1+vfKlTbckWUnNK1l5
 0QEJSWYOeAdGSS5vya3ODXKbkd/OU=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="82266859"
Date: Thu, 20 Oct 2022 14:29:36 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH for-4.17?] test/vpci: enable by default
Message-ID: <Y1FNQHS496AkjTNX@perard.uk.xensource.com>
References: <20221020102706.29267-1-roger.pau@citrix.com>
 <AS8PR08MB79919E26BAD0DD1B74C564EF922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AS8PR08MB79919E26BAD0DD1B74C564EF922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>

On Thu, Oct 20, 2022 at 10:30:26AM +0000, Henry Wang wrote:
> Hi Roger,
> 
> > -----Original Message-----
> > From: Roger Pau Monne <roger.pau@citrix.com>
> > Subject: [PATCH for-4.17?] test/vpci: enable by default
> > 
> > CONFIG_HAS_PCI is not defined for the tools build, and as a result the
> > vpci harness would never get build.  Fix this by building it
> > unconditionally, there's nothing arch specific in it.
> > 
> > Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > Signed-off-by: Roger Pau Monn� <roger.pau@citrix.com>
> > ---
> > While not strictly a bugfix, I think it's worth adding this change to the
> > release in order to always build the vpci test hardness and prevent it
> > from bitrotting.
> 
> Good point.
> 
> No problem from my side, but I think you need also Anthony's opinion
> as he is the toolstack maintainer.

This sounds fine to me, the risk is that the build could fail. But we
can easily revert the patch and reapply it at the next development
cycle.

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:35:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:35:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426813.675513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVhN-0007od-S1; Thu, 20 Oct 2022 13:35:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426813.675513; Thu, 20 Oct 2022 13:35:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olVhN-0007oW-Ot; Thu, 20 Oct 2022 13:35:01 +0000
Received: by outflank-mailman (input) for mailman id 426813;
 Thu, 20 Oct 2022 13:35:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olVhM-0007oQ-JH
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:35:00 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe1fbd33-507b-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:34:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0522322526;
 Thu, 20 Oct 2022 13:34:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A4AE113494;
 Thu, 20 Oct 2022 13:34:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id RObBJoJOUWOQSAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 13:34:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe1fbd33-507b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666272899; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ARNcepPKyfTU7bO/bwBF1UWT9pTUYO6AT49ukGfCHD8=;
	b=EpNZNQb/hNP9jS9wPXdCxcmjPycruocr80DaPtf13D9IjVgUyiD+MLjPHi6c8Me/k7UguS
	dPx8dte5Rz3wl9NcQ8FTfvTkCkTqTbnAwqaqjDBG4bCbrqY6j3S1MGwn2aGvSm6SOmLxJT
	QDxnTXgC7Dcn431gBOCEyWPH2/fe2qU=
Message-ID: <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
Date: Thu, 20 Oct 2022 15:34:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org,
 x86@kernel.org
References: <20221020113759.17402-1-jgross@suse.com>
 <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
In-Reply-To: <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------57JFMDa70xHhdru0CQKVxZA5"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------57JFMDa70xHhdru0CQKVxZA5
Content-Type: multipart/mixed; boundary="------------6b698FiirMJSMgvVYTVWAQ27";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org,
 x86@kernel.org
Message-ID: <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
References: <20221020113759.17402-1-jgross@suse.com>
 <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
In-Reply-To: <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>

--------------6b698FiirMJSMgvVYTVWAQ27
Content-Type: multipart/mixed; boundary="------------m0MNGMfGi7qcqgN8ZUMqrCaE"

--------------m0MNGMfGi7qcqgN8ZUMqrCaE
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMTAuMjIgMTU6MTYsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMC4xMC4yMDIy
IDEzOjM3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gQ29tbWl0IDg3MTRmN2JjZDNjMiAo
Inhlbi9wdjogYWRkIGZhdWx0IHJlY292ZXJ5IGNvbnRyb2wgdG8gcG11IG1zcg0KPj4gYWNj
ZXNzZXMiKSBpbnRyb2R1Y2VkIGNvZGUgcmVzdWx0aW5nIGluIGEgd2FybmluZyBpc3N1ZWQg
YnkgdGhlIHNtYXRjaA0KPj4gc3RhdGljIGNoZWNrZXIsIGNsYWltaW5nIHRvIHVzZSBhbiB1
bmluaXRpYWxpemVkIHZhcmlhYmxlLg0KPj4NCj4+IFRoaXMgaXMgYSBmYWxzZSBwb3NpdGl2
ZSwgYnV0IHdvcmsgYXJvdW5kIHRoZSB3YXJuaW5nIG5ldmVydGhlbGVzcy4NCj4gDQo+IFRo
ZSByaXNrIG9mIGludHJvZHVjaW5nIGEgcHJvYmxlbSBtaWdodCBiZSBxdWl0ZSBsb3cgaGVy
ZSwgYnV0IGluIGdlbmVyYWwNCj4gaXQgZXhpc3RzOiBXaXRoIHRoZSBhZGp1c3RtZW50IHlv
dSByZW1vdmUgYW55IGNoYW5jZSBvZiB0aGUgY29tcGlsZXINCj4gc3BvdHRpbmcgYSBtaXNz
aW5nIGluaXRpYWxpemF0aW9uIGJlZm9yZSB1c2UuIEFuZCBJJ20gbm90IGNvbnZpbmNlZCB1
c2luZw0KPiAwIGluIHN1Y2ggYSBjYXNlIHdvdWxkIGFjdHVhbGx5IGJlIGVuZGluZyB1cCBz
dWZmaWNpZW50bHkgYmVuaWduLg0KDQpIbW0sIGFuIGFsdGVybmF0aXZlIHdvdWxkIGJlIHRv
IGluaXRpYWxpemUgaXQgdG8gLTEgYW5kIGFkZCBhIHRlc3QgZm9yIHRoZQ0KaW5kZXggdG8g
YmUgPj0gMCBiZWZvcmUgdXNpbmcgaXQuDQoNCk9yIHRvIGxpdmUgd2l0aCB0aGUgc21hc2gg
d2FybmluZyB3aXRoIHRoZSBjaGFuY2UsIHRoYXQgYSBjb21waWxlciBtaWdodCBiZQ0Kd2Fy
bmluZyBmb3IgdGhlIHNhbWUgcmVhc29uIGluIHRoZSBmdXR1cmUuDQoNCg0KSnVlcmdlbg0K

--------------m0MNGMfGi7qcqgN8ZUMqrCaE
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------m0MNGMfGi7qcqgN8ZUMqrCaE--

--------------6b698FiirMJSMgvVYTVWAQ27--

--------------57JFMDa70xHhdru0CQKVxZA5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNRToIFAwAAAAAACgkQsN6d1ii/Ey/y
vAf/ZuR/GKdTUEzYncOawz7kdZHgCaF3QZuVpveV/KJ9fqhX0vIO0vGSgvQ3K45faVm3O4AJAO3j
IZt1fNtxS7nda8pJBqkjj6YM05OjOunP3E9l0go6OOLaeF8bk+e8tNVIZBhtdOLh4gi3JbuRGSTg
8oqhNhduzxQp8MmEZm+evpfdDYxdngJJLktEkpV39kIsA9sFHU6+J6JkRuC0wZxO3nFQUfjC3StF
W6r/4fMCpCHPWSdkesfwl1OYPfFvBUEYB/SkKqRuhllUuz0dQbdHQtRxtu/iH2X7MsEmdn2NcmhB
A40khxvUP8oitAEJzKOOY+XDgaoM5pyjjZafUGlReA==
=bEMw
-----END PGP SIGNATURE-----

--------------57JFMDa70xHhdru0CQKVxZA5--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 13:56:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 13:56:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426821.675524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olW2I-0001uT-Ko; Thu, 20 Oct 2022 13:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426821.675524; Thu, 20 Oct 2022 13:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olW2I-0001uM-Hq; Thu, 20 Oct 2022 13:56:38 +0000
Received: by outflank-mailman (input) for mailman id 426821;
 Thu, 20 Oct 2022 13:56:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2NEB=2V=citrix.com=prvs=285423218=roger.pau@srs-se1.protection.inumbo.net>)
 id 1olW2G-0001uG-W9
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 13:56:37 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0134877a-507f-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 15:56:35 +0200 (CEST)
Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 09:56:31 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN8PR03MB5041.namprd03.prod.outlook.com (2603:10b6:408:d5::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 13:56:28 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 13:56:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0134877a-507f-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666274194;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=jVSpsoxkkQ8LSPnsZ8xZOTzgVorILF3Pmspigzyk1sE=;
  b=NWbgs+UArzG4+VhUM30KY1kMI7JJ1WSjZmT1abaUq+olgc+b1rv6CyME
   eczC6tJzec9BFQciX0825N5jpx42QHXRiIRm2I+q0optuEyrn5RXGC+pP
   qQqDsxRaSvUOMu3ZwzaJoNggKI9OuikaWfwQFwZFT3e4T6XIxaeSjYsmo
   M=;
X-IronPort-RemoteIP: 104.47.57.173
X-IronPort-MID: 83152200
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:MuBnea7mLYw/okl9mhzxCwxRtC/GchMFZxGqfqrLsTDasY5as4F+v
 mUWUGyAP/iJNDemfNwnaouz8BsFvp6AzNM1Gwo6+Cw1Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZmPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5FJTAes
 tkIGglTYyys17Pu6eylZeBV05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMl2Sd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL337KVx3ujMG4UPJrop/lmq3eS/2w0KhAQe2X8oKm/ukHrDrqzL
 GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvU6SdHtbSUTTeR8+mSpDbrYCwNdzZdPmkDUBcP5MTlrMcrlBXTQ91/EamzyNroBTX3x
 DPMpy8771kOsfM2O2yA1Qivq1qRSlLhFGbZOi2/srqZ0z5E
IronPort-HdrOrdr: A9a23:+oGkUqpxYH5msdDxsm10ozoaV5uwL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM
 Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/
 Gnl7d6TnebCAIqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP8f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aiSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7svVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wU9HdwGOtt5Dt
 //Q9RVfYF1P7ErhJ1GdZY8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d
 /8bG8=
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="83152200"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Hg+9zx13zKJxdT2rHHTH8/S1TO139v8iasHDRnq8Opd2hFl/0RIdKakDTW3MEOSx5ObSkJzeCmZWT1Jl76UvFVrYL2Z+fIFs3r5xYKiCmcsYL4kPWMNQQbEP87g091uNBU/UyEocsbrqfKnSewQfazzqW48TeqvMf5v/2Tj411F/6SBr3NUPgAEdrui+H5Yq38Svh8ldpk7fwVLMrmnmicu9f6ImhaYyWUhBsPzYZ2IlinL7s9zzHLI61BKHRY81LutxZxZSQvaW0dVGfvO0hVy7GVWbwfHN5p/iJaV/3QzwQiugm+0smeyaPSygEze+KIELMz0BKJTQ7Ys/7RYzNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8yFRfr8cnUdEBiJSaoiDbirBa68tKKWtxyevbl7woHE=;
 b=ZWrYMrwwFzju9bMAm86spiZiMbWb68hvzUGldboo++HHQG9KcYCgE0EPQBsn+85ImuJTu0MU9IprW02sD54aLTzb5Kr3CiU0l3Vr1sbVclUZGiVdXHqIzVCqUwVQIU97uvNzVHdjQgQd/P2gLDZc+RcBQdze5vsyDx40h+Rqevc2ZFloYcOkqGwljgByV1+m2vvUDCrSRfPes0CTdNC8C7Cpw6vx+n0IBKhZ9vewTVLNdWd+Kry5MG2An8johdR9wMwMpfmTXxaAinr54m4BzmweKbEtKri3UWj1vN7HSiafSc9ZOvnaYLkJxekGBXwCO6hPyWRBo7az4X6S21iEOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8yFRfr8cnUdEBiJSaoiDbirBa68tKKWtxyevbl7woHE=;
 b=uDEr97AizEo3EslQX2WVZDo5yTR8iYJHQk1NGsYrDVNzCbiJvWQ3tdlQvhBI7Mxn4rukzy2lB9Rr6K/e+/1p+Y2XzNWcHr+rkKRa28TD7xJ6umvXfwx1e6XqLCUEAlAxl6DmbC2F8IIPVSXctJejJLlR44/zsKNTAMa1tnyT2IE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 20 Oct 2022 15:56:22 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: Intended behavior/usage of SSBD setting
Message-ID: <Y1FThso5w/WWwoaO@Air-de-Roger>
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
 <2f5ec31e-2ac5-2b22-8801-9ebdc4946962@suse.com>
 <Y1FBGTx5cSrkdVbZ@Air-de-Roger>
 <865a2712-d694-122f-eb10-e206b350c7d6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <865a2712-d694-122f-eb10-e206b350c7d6@suse.com>
X-ClientProxiedBy: LO4P123CA0108.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:191::23) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN8PR03MB5041:EE_
X-MS-Office365-Filtering-Correlation-Id: cd8f85a6-02a2-4531-52f1-08dab2a2e289
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ucPyVZRsVSdU4WJXM8PMrrlqSDTNW4wAvUhnaiv827hu45fKix3RSsgCbYRhbYOzNyE0VjGolNQKoHIcXb0wQxg45iR6IetzDKOZF07ntVFKNwNpA0rJlKyUhr7ZA2P2+GgTguAzEJgaRHsNa2PdpwLer/s7WGSrIbgygHUR79xkgXtZnbNrG6ZBcocIU+ZlRuinhN6nHVVBij0trv1jlEGqjNbVrWIZyB54r3dxQsy0S+xBX/6/lSvsr3gM9GvG56qpzPjzUOuIvYHMjlJzBsysgqKORVT/uVSykmWgBJEq5739gCU4Usfy9uaTwqSEVVEhpXFCFe9cH22Pc0RgAkXSh4e6wCfBUsWwkWbJXUxn2+QeJbhxPYnz+ucaU/WgLM2/KOYnQlNh/12fRJ83O6Cwvr+4ophfZI/z3Xv8B/ogXaj8/3M1r1JVyl+A8BRKqJPwxqFxQVhPuMVp4KW5cuqbub3wlNRNOtNL+QqwDwv6ME103S+HIm91zkJ3WwmlT5pRjq2QFNUaOUuQTc7Yzt4t0UDwAZqIJDXqz7MosMl29S3IGweQ5K84s/cYtpZ67zabW1jlRpYK2hGAWQ2Y1ZhlGBRViz2t06weqASLGPtqwYL4Ngjtt4H6Y3msT0l6t9Op02Spv7s2sK07NBwtwAcHmRHPSPGoFvUcoGHiisiBcsxpZ/CDngw+1AdAFn1TBEKSQJDl/v9nFTV8XYSjkw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(451199015)(41300700001)(5660300002)(2906002)(8936002)(66899015)(85182001)(66946007)(33716001)(6486002)(6666004)(8676002)(478600001)(6916009)(66556008)(6506007)(316002)(4326008)(66476007)(83380400001)(53546011)(86362001)(82960400001)(38100700002)(6512007)(186003)(9686003)(26005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aTNiY3lWS1FDdXBFMUM5T05OTWJhTFdyYlJaeHhhcUw2eWluNGNEMUltbGJt?=
 =?utf-8?B?QWptUzFZME10YW53UmVmWVJxZEFnWllUaC85endoeENnSFVkM1RBNXRGSE56?=
 =?utf-8?B?TU03RXErWkpJQmZwQm91VE1jUHZGNUp0bzlkM1dwaitBY0xjdTB3SzRNYTVB?=
 =?utf-8?B?bXpLS3pxMU1tUWVML1pacFBXLzdVUDd5WmJiWTBkR0MwejVldWZIODV6OEM3?=
 =?utf-8?B?b0NtQUFBNkNCaENoOHVwcE0zOTNuWXBHOXAvNFpIL1RDRXgvbjFxL3ZBbmdk?=
 =?utf-8?B?QW9UakZvL3FjbUFxVGhkenpVQUprVG85SzhqZ1IyV3gzTExMVm5CNVR0ekw3?=
 =?utf-8?B?bWVaSndWenRST0NpZ2VPNmU1QStnby9zRWFFQm8yTDR5c0thRElneXY1Rk5G?=
 =?utf-8?B?UFdkNThpMXFxd2FpVDVxZnpYRVVaOTFXMWxZMmRWMGl2VWpRZ0ZkSWJxaFVI?=
 =?utf-8?B?REsvUjh3NnNEUWx2czUyQmo4NjVLeVNrSGxDTGpPWkkwVnlMd0haV0hibUll?=
 =?utf-8?B?TjhHUlVLTmUwY2lDOW5FNXdrVkk1L00ybHorbEJZK3drUng0UWpBNnRvNFVs?=
 =?utf-8?B?cFJWMUZPdjRJWE1jcVBrazZ4cjVYdDJMeklJRHB3cml6MDAzK0t4c0t4WWhS?=
 =?utf-8?B?akpiSmdhajZ0UDdDWVJ2RUVFdEx0dW5wRUVXN1pKZGhFU2E0NnhmZWU2MkZx?=
 =?utf-8?B?OXZ4VkRmRElxUloxaUxzMzgydGtrdHUyTVNRNTBrMWVaK1RKbVJHYnhJb2ZM?=
 =?utf-8?B?blZaRzI0NitySCs5WWxpRTkzWEl5dTY3MHRPMllOdXhnVGhMbjkxNWRyVUxK?=
 =?utf-8?B?b1ordFFETy9aRlMyRVhBM3dxSVpMNHk5amhjanJnVXAvYzM1T0NUdkJiZ2R6?=
 =?utf-8?B?aFFsLzFrcnBWbW9GaWVadTRzbW05ZDdlTG9QMndHcmYybTRuMFBuSXREN3dl?=
 =?utf-8?B?cFB1cHpyODlKbys1SmdJUjlBQU5aUmZqK1NTa282ZGlKRE5xdWhhM0QyKzBI?=
 =?utf-8?B?NDArQm9uMkEydjVKcHFlaUsxcGIyWjhvblh0N2lCUFIxOEZTUFA0MU90WXMx?=
 =?utf-8?B?UkxPZkhYc1hEYjl0UTZxOTB1VjJiNjBDRzNtQ0NEVGRMREtZNzM5ZGxtWnZv?=
 =?utf-8?B?TkMwbE1UcE9pYmx3RW9aRUhOa2svWDZTR0NnWDltNEdvbFllYzBWdW5lS3FC?=
 =?utf-8?B?Wm9zckNiSE1UdGgzMWJSTTJNYkowYjExa0xYZUxXUjZaeVZINUIxeG13bXF2?=
 =?utf-8?B?VXZEeDZldUxJcUQvMVJlSUN3Z1RybzdoWEVGc2FveVphZkZBNTlyalBOT0Nl?=
 =?utf-8?B?aklpK1JkdDN2UThZVU5zRWt4M20wU0Jvb3dXUVp0c2l3SFgvR25GOG9hY3Q0?=
 =?utf-8?B?eGVIUHM1RnZUakdsNk1IZ3JxeTgwcTJmR0FKblhRRHZiNlZJYkVVbmdRVyt0?=
 =?utf-8?B?NmJBS0dtZ2huRG5Ed0NNU29ZK0J6OGlORDM5SHhaVSsreDNOMHZGTDJKQ1Bl?=
 =?utf-8?B?T295Yk5lL2RtVDczUTJVcGxIbUVEczV6TWNocEo3djF5OVR3c3VIdk16aFY3?=
 =?utf-8?B?cE1sd0F2OFJ5ZGxaUzJwOEFtNHh5Nk1pZjJxaDl2alI3Z3BKRWwrL1dlNjBM?=
 =?utf-8?B?b1RjeVBNYnVJVWNGL0lQcUE1YUhuRnA2ZFlXdW9IL2hiL1JQOHA5YlorZ1Nj?=
 =?utf-8?B?OGI2dEZhYThEVTVYcWh2ZWpDVm8xZWJqQ3V5cHJMckJPYnBIcXBrU1Nnckc1?=
 =?utf-8?B?Vi9ZSnN5WkZHNkRST3ZjSVk2Mkh6SHlDdXdmMlBOYm1TVzAwb2FlS3paandZ?=
 =?utf-8?B?NW83RGNQQm9LbjVNSUZvQWwzSFVpMVRQYkRNQ2V3QzZpTHNGVDhKUzFRMDFp?=
 =?utf-8?B?aEQ4MnZpWjFCck9KQzN0b2o2ZnpLQWFwNGZhWjlyWk1HdUhuZUlWK0plYzll?=
 =?utf-8?B?WmZsVy9VdkZJQWtDc0FGV1p2djh4T2dYckYydGtLS3BFb2xpbkNveGtPdEZJ?=
 =?utf-8?B?a1V1WjlpcGdFQTFHUTVCZWNTQ1V4Rng4cXBNalAxSFpFUEJzQ2kwa3YzUTQy?=
 =?utf-8?B?bm9FdnluNEw5UVkyZXAzb3FCSjUwaFJMK0lJU3FzNFU1TmJiMkdBTmg4Z1JW?=
 =?utf-8?Q?HS4Hwwbc5POLq4JmfdWEwwByS?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd8f85a6-02a2-4531-52f1-08dab2a2e289
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 13:56:28.5036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NZkccvvfcsImU9zGcrIoTfrRxVFq+R3isZHjqmJEOBlA8xkWBZvl8FfguidNNvfEeIe6fpuO1i3Q5P77zlDxLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5041

On Thu, Oct 20, 2022 at 03:25:38PM +0200, Jan Beulich wrote:
> On 20.10.2022 14:37, Roger Pau Monné wrote:
> > On Thu, Oct 20, 2022 at 01:22:20PM +0200, Jan Beulich wrote:
> >> On 20.10.2022 13:01, Roger Pau Monné wrote:
> >>> Hello,
> >>>
> >>> As part of some follow up improvements to my VIRT_SPEC_CTRL series we
> >>> have been discussing what the usage of SSBD should be for the
> >>> hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
> >>> that has an out of date description, as now SSBD is always offered to
> >>> guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
> >>>
> >>> It has been pointed out by Andrew that toggling SSBD on AMD using
> >>> VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
> >>> have a high impact on performance, and hence switching it on every
> >>> guest <-> hypervisor context switch is likely a very high
> >>> performance penalty.
> >>>
> >>> It's been suggested that it could be more appropriate to run Xen with
> >>> the guest SSBD selection on those systems, however that clashes with
> >>> the current intent of the `spec-ctrl=ssbd` option.
> >>>
> >>> I hope I have captured the expressed opinions correctly in the text
> >>> above.
> >>>
> >>> I see two ways to solve this:
> >>>
> >>>  * Keep the current logic for switching SSBD on guest <-> hypervisor
> >>>    context switch, but only use it if `spec-ctrl=ssbd` is set on the
> >>>    command line.
> >>>
> >>>  * Remove the logic for switching SSBD on guest <-> hypervisor context
> >>>    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
> >>>    hypervisor code with the guest selection of SSBD.
> >>
> >> * Give the guest the illusion of controlling the behavior, but run with
> >>   SSBD always enabled when "spec-ctrl=ssbd" is in effect.
> > 
> > Right, I've also thought about this option but forgot to add it to the
> > list. That would limit to only allowing enabling ssbd for the
> > hypervisor code, but not explicitly disabling it, ie:
> > `spec-ctrl=no-ssbd` won't be a valid option.
> 
> Well, it would be valid to use to override an earlier "spec-ctrl=ssbd",
> to revert back to whatever the behavior is when no option is specified
> at all. It wouldn't strictly mean "no SSBD at all".

Hm, so using `spec-ctrl=no-ssbd` would mean 'use default value', but
it won't force SSBD off for hypervisor code execution.  It would have
to be made clear on the documentation.

So we have 3 options.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:12:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:12:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426829.675539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWHh-0004TF-5b; Thu, 20 Oct 2022 14:12:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426829.675539; Thu, 20 Oct 2022 14:12:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWHh-0004T8-2J; Thu, 20 Oct 2022 14:12:33 +0000
Received: by outflank-mailman (input) for mailman id 426829;
 Thu, 20 Oct 2022 14:12:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olWHg-0004Sy-9g; Thu, 20 Oct 2022 14:12:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olWHg-0000vD-7H; Thu, 20 Oct 2022 14:12:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olWHf-00070I-S3; Thu, 20 Oct 2022 14:12:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olWHf-0002T3-RU; Thu, 20 Oct 2022 14:12:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0t19C2BMoRCROSKW2k+xswp8OVpVAttJLcSQrfbmpVk=; b=WXfY+R3YLD39FK5Berhqe8YKw7
	jkPIMT2ipfDMpjlie3wBtej2CCxlF+QfJpK7nNjZ/XIk1Ps7ZqJ3swb6t9vNri4NghDJjfbE0pjDu
	xicR0QYcwUnJEtLFJBw1fr+BsPpbpz0uHkVGdAcael3sdfOoirzqy68+g14LYEpd4TWg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174131-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174131: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c7cff1188802646eaa38e918e5738da0e84949be
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 14:12:31 +0000

flight 174131 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174131/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c7cff1188802646eaa38e918e5738da0e84949be
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   173457  2022-10-07 14:03:14 Z   13 days
Failing since        173492  2022-10-11 13:01:50 Z    9 days   58 attempts
Testing same since   174131  2022-10-20 11:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9029bc265c..c7cff11888  c7cff1188802646eaa38e918e5738da0e84949be -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:12:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:12:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426832.675550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWHz-0004oa-En; Thu, 20 Oct 2022 14:12:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426832.675550; Thu, 20 Oct 2022 14:12:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWHz-0004oT-Ay; Thu, 20 Oct 2022 14:12:51 +0000
Received: by outflank-mailman (input) for mailman id 426832;
 Thu, 20 Oct 2022 14:12:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pcz+=2V=epam.com=prvs=22920ca83a=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1olWHy-0004mw-GW
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 14:12:50 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 457b3caa-5081-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 16:12:47 +0200 (CEST)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29KDSQR4032470;
 Thu, 20 Oct 2022 14:12:35 GMT
Received: from eur03-dba-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2169.outbound.protection.outlook.com [104.47.51.169])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3kahuen4yd-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 20 Oct 2022 14:12:35 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS8PR03MB7939.eurprd03.prod.outlook.com (2603:10a6:20b:426::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.28; Thu, 20 Oct
 2022 14:12:31 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 14:12:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 457b3caa-5081-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H04TIrwetXRfZsJna7Wqgrlj+Zj3qSMF1JmSihd8W1Z+HdQCuIhxK8brp1cc95djFlPAWC+yBYRwGh+dLLgOhSwkzPj0YHNTdrNzY2GJyHZ6ehz98Glu9ibHthq5/jzvHZBP06f8uTZmqYs8xl/tQxqXo4GGy32foSUgMdFCMMfSvN9sPHxi2/YmBPp+ilmvSGEKrQQiUe1bD/+kItr96v9HBWjaMsQGhLCwJew0Qjhc/AiCIU2wBKSP8Uu179uDkp8oDNZ+dbY87Y2mhtNvTxnZJW90/R+sRQ0cIXN+IFKyXns/5mzrOBplJyx/mhESHK8Ox0Zx88eVT7KR+Vjypg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ydXFaMIy1chL1FmcQPcJxnNko47lbx0qOtUoxTLrX78=;
 b=YyvppI+FQMCf3iTgyIO7L9k1g11Z+u7M+YmCDdwWT6D7e0rqfj/RGAWdo8Nxl1KuxoGf+eoCE9HTzymWxvaJHNjDiqdQ7p8d9LOTQswjlvgO96TDuGOMz7JvQl0PWz6i2dgYHY+AQy7MuabJDdErGOqeLwLH5W9chGfQ+NFi4P0MU3nXdGzNW1WoAtbr3XoskUk2RapfjBoee1pQQSer4iNHkag6Dh/W740TqRd9jLqYbA8moajurKR40pnssITzus9HJh9MCEYYrur/LwW1F9nW9+Ro3knnmghED/ZNFpVRh2txovxbRVluhfbXgL8IuyOg0+/drsfnRlk95EfKRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ydXFaMIy1chL1FmcQPcJxnNko47lbx0qOtUoxTLrX78=;
 b=WH1oWmTT0FbxJzuqITmN73ujdE/ygpd8CNYvOESeZFE6ShQor14XUffGA75sZUcpOVAQr6DklBSucZ0dMvOb3+tkVeut12hSuYmTlqvfLbBFHzER7SxOaHra3ghTLbVIjXcuLOpQ8brRUBY0xeO5ZtGwIPnNXp+mKpmvsQW4RylM7lAXvj3SisyHKmEG1GgDVoST+rOCMVECS8FK0X0RNqeYfMIF2uG21BuxwMPAFFhf3zJ/FpNuoFtTdgXyS8s2NBRhxWUPxQoOghZKIvjbHkOKMO9B6d8iluBVcwkkZPFzYPkQv7GmXK29G2EMQPilz+A1AbxP7Yo5MZUMW29W6Q==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr
 Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64U6lSAgACDRYCAALaPgIAA1SMAgABhSgA=
Date: Thu, 20 Oct 2022 14:12:31 +0000
Message-ID: <ded6c520-8f1a-6ee3-bbfa-3de7e1f74779@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
 <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
 <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
In-Reply-To: <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS8PR03MB7939:EE_
x-ms-office365-filtering-correlation-id: b32f40b6-0207-4b10-5bc2-08dab2a520ed
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 tCGTgBwvU6wz0ci5IYZDQ80QMNXk/6kPltQKYdWdVbjLKxHUROWChC9N/fXCESrTEXGoFtIhm9Lzw98TEsN7tKKayio+annHGYCJOKrnCb9/2tL9xYji5etQrOMpNX84HAdef9HYm5bH35ntHhHmco+xFwvLUwKUd3FL1sT0PxjvRcw1Kg/wFhS4X56AMEGsOqm/bZgsL/Y77uTzCiIpGkuy988/jK/XWwlLHoXCzJoTak0hqAcbz92y56uZTTKb/iU/u3JEjV5Xw7Kdx8PL9g7uBCwRYVpv0HWnVwjTv3REq8jX+JaLyfdQQyzQ+m5G2mf9ABEbLL8Ylbk0YNeTfdQBnO8RAe9F32KK9C/MejBieJEUIxjmCImDI9FtPNqYKcpsr+48M4jLOdfeY4rcFUb0k2MbZIUPfi/pkIr8aq7viG8U7hkbkEwPlyJ0pswo5PAfx7RMoXk9Ys/UhSCsm1MjAJuOkN/uM71MIQ4OPR+NBuoRzci2kQkE6DefxNNZ1KB7xvop6EzsevtxgCTWyPB+6I0XB+z/DZ/wcrvNN4AI9RpAtxP9vFp+FnKHc/xhrjjOuEG/PFaQO26kPCnM5CX75SyyP/2jv2XgEVvOf5CEBqm673LSBWxT1C/7xr91dkduPOLHL95nfsP63SDfmvXBwH6eFHt3M6mPQQMj8mZZEh4pozy/ieOrbDeat2MhxhCJvs5QAiqor5xcjrC/xcvv2Eqeo8+t+MEpA8eYhBfPLZEwSK8TLSt6cwRGpaXqknp7W2Lmm9ZJaQLpvs0qAJrFA1vc67mMdpNsXcrSs11rbYZnDNRs87fcgL78q/ADmAkJA+Q1a8KyZOgF/w+qiYA5Mml6O0vOe7IZVVnB2UVMawJ0rIwmshFgL5Ayz2Vf
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(451199015)(6916009)(316002)(31686004)(71200400001)(66476007)(66556008)(91956017)(66946007)(478600001)(54906003)(64756008)(66446008)(76116006)(966005)(8676002)(4326008)(6486002)(6506007)(53546011)(55236004)(41300700001)(8936002)(5660300002)(2616005)(26005)(186003)(2906002)(6512007)(30864003)(122000001)(83380400001)(38070700005)(36756003)(38100700002)(31696002)(86362001)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RkZlZ0ZhL1hjZXNKZ2I3NmpQMTM1bVV2VWw5NmVLYndNZzhGemxxSVF6NUNP?=
 =?utf-8?B?UDdvTkxFaDBXYVdibm12WFpNWXU3SVBjc0FBMEFCbzhjamd4VzRsV1ZGY2xE?=
 =?utf-8?B?SWlMYVU1Tmc3ZEpORUZZMlJYd1NWMEo2amR5TGVIRmxlclJHVDFsN2Y4enpo?=
 =?utf-8?B?bmhOV2d6dXpHRHYrU1pMTGl1Mi90MHZFRzNodExUcWs1V052QkYzZWttalNK?=
 =?utf-8?B?WWYxZXFaSzEyZ3ZUb1RqTVUvRVBRYWcwaWdjQStSVGViWG82RCtqRkNORDJB?=
 =?utf-8?B?WE11czY2bk0rWVNJZXo1bTdNRnd5S0VTbE45Y05YVjJFT1dSbmNOdlRFMDVy?=
 =?utf-8?B?cmtJNEpHeVJCVzNaSnpFeHVJV0I2OVp5QW9DdmVWR3pJcFArbWRqQmxwdGhS?=
 =?utf-8?B?QndQWFNYNW9nT2t6bVQ5WS9xMnVzcjlNaWFDbU5tdTFhM1QyaU9SRlVSaWVt?=
 =?utf-8?B?TWUraWNNSytkU2dqVHUrRDB5RzRJbXJGVS9SN0djdUNaWXZPZjBXdHhIV3Nu?=
 =?utf-8?B?WExFR05iMWJENjZNdFE3L0pITjRhbEtwalFqUU00K0V6Rnc1cmoxUG4rSTJT?=
 =?utf-8?B?K3Y1Zm1sT0FZQzg1OTJYMzdZVzFITzdiRFh5SGpMMXJNMzBvUTZaYzZRZTVq?=
 =?utf-8?B?K0E4Nkc5bjdwYXpYeVBpTW02VEwybVFvQzU4QTFPeHZPbkhLMmZFcTJ3Rng2?=
 =?utf-8?B?YWM3alUySG9xTENRZitLek1KL3F2Q3hrTjFPZlVxK2hZRUdET01ETUZEWWNT?=
 =?utf-8?B?ZzFlWnkzY0o1L0M2Vy9yMUtmUjEwNDRBSThNcHZ4KzhKK0pEbmh3NWkyN3Fs?=
 =?utf-8?B?RmpMMlZIY0xDVkNlMTJ1ODdTcjdIWjQxVHJDZjV4eVhuVmszMTFpODR2d2ds?=
 =?utf-8?B?WXhtTi9ja1ExWlBXOGx2S0h1am9IYVlDRnhpNTgxRGFFdG9oazhQTUxhQXZL?=
 =?utf-8?B?bGxMaWx3R0l0UDRDeVB6aUZoaGVHZXdQYkVPNkZqNkFQclpCSFhmSUF2U1lo?=
 =?utf-8?B?dEV4SnEwdGx4dUNKOGtpaGtnNlNOcWNIL3pGS1p1d0tNdFl2UmlITnc5YlN5?=
 =?utf-8?B?OGVmQm5MM1RLWUFzMExUSStqaG1DN1c2RjRXSyswdVZyUk96Y1BnTE1UYlpS?=
 =?utf-8?B?WVc4NnpQVmVXb3hkNG81eW9TYnZBdk5SMnpGdkQ3R2VjZXozTVExUjV3ek1z?=
 =?utf-8?B?bENwc2pqUDBwN0hDdldFckRkbkpZQVRVcWtleU9QdlIyd1p6MjFtRTNIcmF6?=
 =?utf-8?B?akROQ2NzT1pyZGNOUFhyQXRobXNJK0dFcnpySk5HaXhNWERHYzcvTFE2VVhP?=
 =?utf-8?B?QjVkSVI3Zis5ZXF1cDhGVFpDT1ljVHRJbUZiaXhabmUwdmYzZjhCdm5tWTN6?=
 =?utf-8?B?MDZzTTJWMFg2VEI5RGViaVhpdVRVRXZ4Ti9NSURSelJvR1o0V1dIYlc0R1N6?=
 =?utf-8?B?MlRUa2dvVVBYSmlKWGszQ3V0VE5uR0trOGF3ZGFZOGdHZVVRdUdlQmw3R1lY?=
 =?utf-8?B?eEtnM21mcDM1c25qZHRJR0djQzd3YTFIOTBEcFFrMkxDdGR2Wm13M1k4dGxT?=
 =?utf-8?B?cHpDZ3RFZnlCdGcrUnBaL0NGNllSZjZydXZMeVdYRCt5WkVXY3VIQlRtMjdl?=
 =?utf-8?B?Y2EvNFQyakE0dzFvdkR0UzdrZkFYQkRUTlZVU2xZTk80bERUZ0MvMGxLb2lu?=
 =?utf-8?B?SnhLWk45VUp6VFpEVjBSTHhGTnhpejhJaHVEOEVNb1cramxSZG5yVThpTnBz?=
 =?utf-8?B?YlR0T3BVNkpMNzk5OE9JTmc4QmRyZzViWGNyS0ZKWnZsZHpkTnJWaGxrbkto?=
 =?utf-8?B?SzdVemNoNEc5QXRpMnBSUGY2NmtOcFN4OVZ1QnFVdzVpbG5HU3VaME45Qk5k?=
 =?utf-8?B?Rll1UGJxdXQvY1VwdUU4VGhFZXlIZlc0UmkwdmpwVXFNVnhRVENDVnFDSEZH?=
 =?utf-8?B?M2dCNFNraStHdlIzNzBWYm5oVWpVOXp0enI3ajY0R1BGTVB4eEJlNXY3SW5G?=
 =?utf-8?B?RW56a3ZKb3NPVEQvSENhZWpnUzZKaUZ0Zjhrc21MMExwS2I2K29CaDRBakV2?=
 =?utf-8?B?UStPZDJ1NmlHM2NkZjhZWDhJNG5GaW1YNUl4L1pOTzBRTEF3ZWsxVkdNd2hN?=
 =?utf-8?B?amVNNGY0LzBsRXk4UUNxR01SempwTUV3MVMrbXBjQ2l6VDF4dStBc0dsTnFW?=
 =?utf-8?Q?rKGpv/+FBHd/4meTE1/J0Ac=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <17DA34C02769AD429D3679361248C07E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b32f40b6-0207-4b10-5bc2-08dab2a520ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 14:12:31.7808
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z+O1NC1mfJuXO41mWUXsUopJ8cZxlU0EeNbvNjjD7Asc5iv7pczE9i+1Ap8eBjYTTIniaIXuJ99hhcPmlQiuUX2wsntDDZOPRmuLPGid8Jg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7939
X-Proofpoint-ORIG-GUID: 86xUW2O90f1br-LSDZvQiLEPmwKGInZN
X-Proofpoint-GUID: 86xUW2O90f1br-LSDZvQiLEPmwKGInZN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_05,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0
 spamscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 impostorscore=0 adultscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210200084

DQpPbiAyMC4xMC4yMiAxMToyNCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCj4gT24gMTAvMTkv
MjIgMjI6NDEsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPg0KPiBIaSBPbGVrc2FuZHIN
Cg0KDQpIZWxsbyBYZW5pYQ0KDQoNCj4NCj4+DQo+PiBPbiAxOS4xMC4yMiAxMTo0NywgWGVuaWEg
UmFnaWFkYWtvdSB3cm90ZToNCj4+DQo+PiBIZWxsbyBYZW5pYQ0KPj4NCj4+PiBPbiAxMC8xOS8y
MiAwMzo1OCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+PiBPbiBTYXQsIDE1IE9jdCAy
MDIyLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+Pj4+IEZyb206IE9sZWtzYW5kciBU
eXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+DQo+Pj4+PiBV
c2UgdGhlIHNhbWUgInhlbi1ncmFudC1kbWEiIGRldmljZSBjb25jZXB0IGZvciB0aGUgUENJIGRl
dmljZXMNCj4+Pj4+IGJlaGluZCBkZXZpY2UtdHJlZSBiYXNlZCBQQ0kgSG9zdCBjb250cm9sbGVy
LCBidXQgd2l0aCBvbmUNCj4+Pj4+IG1vZGlmaWNhdGlvbi4NCj4+Pj4+IFVubGlrZSBmb3IgcGxh
dGZvcm0gZGV2aWNlcywgd2UgY2Fubm90IHVzZSBnZW5lcmljIElPTU1VIGJpbmRpbmdzDQo+Pj4+
PiAoaW9tbXVzIHByb3BlcnR5KSwgYXMgd2UgbmVlZCB0byBzdXBwb3J0IG1vcmUgZmxleGlibGUg
Y29uZmlndXJhdGlvbi4NCj4+Pj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgUENJIGRldmljZXMgdW5k
ZXIgdGhlIHNpbmdsZSBQQ0kgSG9zdCBjb250cm9sbGVyDQo+Pj4+PiBtYXkgaGF2ZSB0aGUgYmFj
a2VuZHMgcnVubmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFpbnMgYW5kIHRodXMgaGF2ZQ0KPj4+
Pj4gZGlmZmVyZW50IGVuZHBvaW50cyBJRCAoYmFja2VuZCBkb21haW5zIElEKS4NCj4+Pj4+DQo+
Pj4+PiBTbyB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5zdGVhZCAoaW9tbXUtbWFw
L2lvbW11LW1hcC1tYXNrDQo+Pj4+PiBwcm9wZXJ0aWVzKSB3aGljaCBhbGxvd3MgdXMgdG8gZGVz
Y3JpYmUgcmVsYXRpb25zaGlwIGJldHdlZW4gUENJDQo+Pj4+PiBkZXZpY2VzIGFuZCBiYWNrZW5k
IGRvbWFpbnMgSUQgcHJvcGVybHkuDQo+Pj4+Pg0KPj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3Nh
bmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pg0KPj4+
PiBOb3cgdGhhdCBJIHVuZGVyc3Rvb2QgdGhlIGFwcHJvYWNoIGFuZCB0aGUgcmVhc29ucyBmb3Ig
aXQsIEkgY2FuIA0KPj4+PiByZXZpZXcNCj4+Pj4gdGhlIHBhdGNoIDotKQ0KPj4+Pg0KPj4+PiBQ
bGVhc2UgYWRkIGFuIGV4YW1wbGUgb2YgdGhlIGJpbmRpbmdzIGluIHRoZSBjb21taXQgbWVzc2Fn
ZS4NCj4+Pj4NCj4+Pj4NCj4+Pj4+IC0tLQ0KPj4+Pj4gU2xpZ2h0bHkgUkZDLiBUaGlzIGlzIG5l
ZWRlZCB0byBzdXBwb3J0IFhlbiBncmFudCBtYXBwaW5ncyBmb3INCj4+Pj4+IHZpcnRpby1wY2kg
ZGV2aWNlcw0KPj4+Pj4gb24gQXJtIGF0IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZS4gVGhlIFhl
biB0b29sc3RhY2sgc2lkZSBpcyBub3QNCj4+Pj4+IGNvbXBsZXRlbHkgcmVhZHkgeWV0Lg0KPj4+
Pj4gSGVyZSwgZm9yIFBDSSBkZXZpY2VzIHdlIHVzZSBtb3JlIGZsZXhpYmxlIHdheSB0byBwYXNz
IGJhY2tlbmQgZG9taWQNCj4+Pj4+IHRvIHRoZSBndWVzdA0KPj4+Pj4gdGhhbiBmb3IgcGxhdGZv
cm0gZGV2aWNlcy4NCj4+Pj4+DQo+Pj4+PiBDaGFuZ2VzIFYxIC0+IFYyOg0KPj4+Pj4gwqDCoMKg
wqAgLSB1cGRhdGUgY29tbWl0IGRlc2NyaXB0aW9uDQo+Pj4+PiDCoMKgwqDCoCAtIHJlYmFzZQ0K
Pj4+Pj4gwqDCoMKgwqAgLSByZXdvcmsgdG8gdXNlIGdlbmVyaWMgUENJLUlPTU1VIGJpbmRpbmdz
IGluc3RlYWQgb2YgZ2VuZXJpYw0KPj4+Pj4gSU9NTVUgYmluZGluZ3MNCj4+Pj4+DQo+Pj4+PiBQ
cmV2aW91cyBkaXNjdXNzaW9uIGlzIGF0Og0KPj4+Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92
My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIyMTAwNjE3NDgwNC4yMDAz
MDI5LTEtb2xla3N0eXNoQGdtYWlsLmNvbS9fXzshIUdGXzI5ZGJjUUlVQlBBITMtdnE3RWRtM1hm
S3RENWNuTmpuT3pEUXZ1b19YcmhKNzN5SC1uUGZxT2tHR1UwSWpMRzdSN01SX25BSkNBUGVPdXRI
UkxUNDR3S1l3UXd6M1NhdUFDaWVfWkF5JCANCj4+Pj4+DQo+Pj4+PiBbbG9yZVsuXWtlcm5lbFsu
XW9yZ10NCj4+Pj4+DQo+Pj4+PiBCYXNlZCBvbjoNCj4+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5j
b20vdjMvX19odHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC94
ZW4vdGlwLmdpdC9sb2cvP2g9Zm9yLWxpbnVzLTYuMV9fOyEhR0ZfMjlkYmNRSVVCUEEhMy12cTdF
ZG0zWGZLdEQ1Y25Oam5PekRRdnVvX1hyaEo3M3lILW5QZnFPa0dHVTBJakxHN1I3TVJfbkFKQ0FQ
ZU91dEhSTFQ0NHdLWXdRd3ozU2F1QUVuTURIQXEkIA0KPj4+Pj4NCj4+Pj4+IFtnaXRbLl1rZXJu
ZWxbLl1vcmddDQo+Pj4+PiAtLS0NCj4+Pj4+IMKgwqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9w
cy5jIHwgODcNCj4+Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0NCj4+
Pj4+IMKgwqAgMSBmaWxlIGNoYW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygt
KQ0KPj4+Pj4NCj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMg
DQo+Pj4+PiBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+Pj4gaW5kZXggZGFhNTI1
ZGY3YmRjLi5iNzlkOWQ2Y2UxNTQgMTAwNjQ0DQo+Pj4+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFu
dC1kbWEtb3BzLmMNCj4+Pj4+ICsrKyBiL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+
Pj4gQEAgLTEwLDYgKzEwLDcgQEANCj4+Pj4+IMKgwqAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5o
Pg0KPj4+Pj4gwqDCoCAjaW5jbHVkZSA8bGludXgvZG1hLW1hcC1vcHMuaD4NCj4+Pj4+IMKgwqAg
I2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+Pj4+PiArI2luY2x1ZGUgPGxpbnV4L3BjaS5oPg0KPj4+
Pj4gwqDCoCAjaW5jbHVkZSA8bGludXgvcGZuLmg+DQo+Pj4+PiDCoMKgICNpbmNsdWRlIDxsaW51
eC94YXJyYXkuaD4NCj4+Pj4+IMKgwqAgI2luY2x1ZGUgPGxpbnV4L3ZpcnRpb19hbmNob3IuaD4N
Cj4+Pj4+IEBAIC0yOTIsMTIgKzI5Myw1NSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRtYV9tYXBf
b3BzDQo+Pj4+PiB4ZW5fZ3JhbnRfZG1hX29wcyA9IHsNCj4+Pj4+IMKgwqDCoMKgwqDCoCAuZG1h
X3N1cHBvcnRlZCA9IHhlbl9ncmFudF9kbWFfc3VwcG9ydGVkLA0KPj4+Pj4gwqDCoCB9Ow0KPj4+
Pj4gwqDCoCArc3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9wY2lfaG9zdF9u
b2RlKHN0cnVjdCBkZXZpY2UNCj4+Pj4+ICpkZXYpDQo+Pj4+PiArew0KPj4+Pj4gK8KgwqDCoCBz
dHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2KTsNCj4+Pj4+ICvCoMKgwqAgc3Ry
dWN0IHBjaV9idXMgKmJ1cyA9IHBkZXYtPmJ1czsNCj4+Pj4+ICsNCj4+Pj4+ICvCoMKgwqAgLyog
V2FsayB1cCB0byB0aGUgcm9vdCBidXMgdG8gbG9vayBmb3IgUENJIEhvc3QgY29udHJvbGxlciAq
Lw0KPj4+Pj4gK8KgwqDCoCB3aGlsZSAoIXBjaV9pc19yb290X2J1cyhidXMpKQ0KPj4+Pj4gK8Kg
wqDCoMKgwqDCoMKgIGJ1cyA9IGJ1cy0+cGFyZW50Ow0KPj4+Pj4gKw0KPj4+Pj4gK8KgwqDCoCBy
ZXR1cm4gb2Zfbm9kZV9nZXQoYnVzLT5icmlkZ2UtPnBhcmVudC0+b2Zfbm9kZSk7DQo+Pj4+PiAr
fQ0KPj4+Pg0KPj4+PiBJdCBzZWVtcyBzaWxseSB0aGF0IHdlIG5lZWQgdG8gd2FsayB0aGUgaGll
cmFjaHkgdGhhdCB3YXksIGJ1dCBJDQo+Pj4+IGNvdWxkbid0IGZpbmQgYW5vdGhlciB3YXkgdG8g
ZG8gaXQNCj4+Pj4NCj4+Pj4NCj4+Pj4+ICtzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlICp4ZW5f
ZHRfZ2V0X25vZGUoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4+Pj4gK3sNCj4+Pj4+ICvCoMKgwqAg
aWYgKGRldl9pc19wY2koZGV2KSkNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4geGVuX2R0
X2dldF9wY2lfaG9zdF9ub2RlKGRldik7DQo+Pj4+PiArDQo+Pj4+PiArwqDCoMKgIHJldHVybiBv
Zl9ub2RlX2dldChkZXYtPm9mX25vZGUpOw0KPj4+Pj4gK30NCj4+Pj4+ICsNCj4+Pj4+ICtzdGF0
aWMgaW50IHhlbl9kdF9tYXBfaWQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25v
ZGUNCj4+Pj4+ICoqaW9tbXVfbnAsDQo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHUz
MiAqc2lkKQ0KPj4+Pj4gK3sNCj4+Pj4+ICvCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0
b19wY2lfZGV2KGRldik7DQo+Pj4+PiArwqDCoMKgIHUzMiByaWQgPSBQQ0lfREVWSUQocGRldi0+
YnVzLT5udW1iZXIsIHBkZXYtPmRldmZuKTsNCj4+Pj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9u
b2RlICpob3N0X25wOw0KPj4+Pj4gK8KgwqDCoCBpbnQgcmV0Ow0KPj4+Pj4gKw0KPj4+Pj4gK8Kg
wqDCoCBob3N0X25wID0geGVuX2R0X2dldF9wY2lfaG9zdF9ub2RlKGRldik7DQo+Pj4+PiArwqDC
oMKgIGlmICghaG9zdF9ucCkNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVOT0RFVjsN
Cj4+Pj4+ICsNCj4+Pj4+ICvCoMKgwqAgcmV0ID0gb2ZfbWFwX2lkKGhvc3RfbnAsIHJpZCwgImlv
bW11LW1hcCIsICJpb21tdS1tYXAtbWFzayIsDQo+Pj4+PiBpb21tdV9ucCwgc2lkKTsNCj4+Pj4+
ICvCoMKgwqAgb2Zfbm9kZV9wdXQoaG9zdF9ucCk7DQo+Pj4+PiArwqDCoMKgIHJldHVybiByZXQ7
DQo+Pj4+PiArfQ0KPj4+Pj4gKw0KPj4+Pj4gwqDCoCBzdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3Jh
bnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+PiDCoMKgIHsNCj4+Pj4+IC3C
oMKgwqAgc3RydWN0IGRldmljZV9ub2RlICppb21tdV9ucDsNCj4+Pj4+ICvCoMKgwqAgc3RydWN0
IGRldmljZV9ub2RlICppb21tdV9ucCA9IE5VTEw7DQo+Pj4+PiDCoMKgwqDCoMKgwqAgYm9vbCBo
YXNfaW9tbXU7DQo+Pj4+PiDCoMKgIC3CoMKgwqAgaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFuZGxl
KGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPj4+Pj4gK8KgwqDCoCBpZiAoZGV2X2lzX3Bj
aShkZXYpKSB7DQo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9kdF9tYXBfaWQoZGV2LCAm
aW9tbXVfbnAsIE5VTEwpKQ0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZh
bHNlOw0KPj4+Pj4gK8KgwqDCoCB9IGVsc2UNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBpb21tdV9u
cCA9IG9mX3BhcnNlX3BoYW5kbGUoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgMCk7DQo+Pj4+PiAr
DQo+Pj4+PiDCoMKgwqDCoMKgwqAgaGFzX2lvbW11ID0gaW9tbXVfbnAgJiYNCj4+Pj4+IMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfbnAs
ICJ4ZW4sZ3JhbnQtZG1hIik7DQo+Pj4+PiDCoMKgwqDCoMKgwqAgb2Zfbm9kZV9wdXQoaW9tbXVf
bnApOw0KPj4+Pj4gQEAgLTMwNyw5ICszNTEsMTcgQEAgc3RhdGljIGJvb2wgeGVuX2lzX2R0X2dy
YW50X2RtYV9kZXZpY2Uoc3RydWN0DQo+Pj4+PiBkZXZpY2UgKmRldikNCj4+Pj4+IMKgwqAgwqAg
Ym9vbCB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+PiDC
oMKgIHsNCj4+Pj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICpucDsNCj4+Pj4+ICsNCj4+
Pj4+IMKgwqDCoMKgwqDCoCAvKiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNlcyBmb3Igbm93ICov
DQo+Pj4+PiAtwqDCoMKgIGlmIChkZXYtPm9mX25vZGUpDQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAg
cmV0dXJuIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldik7DQo+Pj4+PiArwqDCoMKgIG5w
ID0geGVuX2R0X2dldF9ub2RlKGRldik7DQo+Pj4+PiArwqDCoMKgIGlmIChucCkgew0KPj4+Pj4g
K8KgwqDCoMKgwqDCoMKgIGJvb2wgcmV0Ow0KPj4+Pj4gKw0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKg
IHJldCA9IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldik7DQo+Pj4+PiArwqDCoMKgwqDC
oMKgwqAgb2Zfbm9kZV9wdXQobnApOw0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7
DQo+Pj4+PiArwqDCoMKgIH0NCj4+Pj4NCj4+Pj4gV2UgZG9uJ3QgbmVlZCB0byB3YWxrIHRoZSBQ
Q0kgaGllcmFjaHkgdHdpY2UuIE1heWJlIHdlIGNhbiBhZGQgdGhlDQo+Pj4+IG9mX25vZGUgY2hl
Y2sgZGlyZWN0bHkgdG8geGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2U/DQo+Pj4+DQo+Pj4NCj4+
PiBJIHRoaW5rIGluIGdlbmVyYWwgd2UgY291bGQgcGFzcyBkaXJlY3RseSB0aGUgaG9zdCBicmlk
Z2UgZGV2aWNlIGlmDQo+Pj4gZGV2X2lzX3BjaShkZXYpICh3aGljaCBjYW4gYmUgcmV0cmlldmVk
IHdpdGgNCj4+PiBwY2lfZ2V0X2hvc3RfYnJpZGdlX2RldmljZSh0b19wY2lfZGV2KGRldiksIGFu
ZCBhZnRlciBkb25lIHdpdGggaXQNCj4+PiBwY2lfcHV0X2hvc3RfYnJpZGdlX2RldmljZShwaGIp
KS4NCj4+PiBTbyB0aGF0LCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZSgpIGFuZA0KPj4+IHhl
bl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoKSB3b24ndCBuZWVkIHRvIGRpc2NvdmVyIGl0
IHRoZW1zZWx2ZXMuDQo+Pj4gVGhpcyB3aWxsIHNpbXBsaWZ5IHRoZSBjb2RlLg0KPj4NCj4+DQo+
PiBHb29kIHBvaW50LiBJIGhhdmUgc29tZSByZW1hcmsuIENhbiB3ZSB1c2UgcGNpX2ZpbmRfaG9z
dF9icmlkZ2UoKQ0KPj4gaW5zdGVhZD8gVGhpcyB3YXkgd2UgZG9uJ3QgaGF2ZSB0byBhZGQgI2lu
Y2x1ZGUgIi4uL3BjaS9wY2kuaCIsIGFuZCBoYXZlDQo+PiB0byBkcm9wIHJlZmVyZW5jZSBhZnRl
cndhcmRzLg0KPj4NCj4+IFdpdGggdGhhdCB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoKSB3aWxs
IGJlY2FtZSB0aGUgZm9sbG93aW5nOg0KPj4NCj4+DQo+PiBzdGF0aWMgc3RydWN0IGRldmljZV9u
b2RlICp4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gew0K
Pj4gwqAgwqDCoCDCoHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSA9DQo+PiBwY2lfZmlu
ZF9ob3N0X2JyaWRnZSh0b19wY2lfZGV2KGRldiktPmJ1cyk7DQo+Pg0KPj4gwqAgwqDCoCDCoHJl
dHVybiBvZl9ub2RlX2dldChicmlkZ2UtPmRldi5wYXJlbnQtPm9mX25vZGUpOw0KPj4gfQ0KPj4N
Cj4NCj4gWW91IGFyZSByaWdodC4gSSBwcmVmZXIgeW91ciB2ZXJzaW9uIGluc3RlYWQgb2YgdGhl
IGFib3ZlLg0KDQoNCm9rLCB0aGFua3MNCg0KDQo+DQo+DQo+Pg0KPj4gV2l0aCBTdGVmYW5vJ3Mg
c3VnZ2VzdGlvbiwgd2Ugd29uJ3Qgd2FsayB0aGUgUENJIGhpZXJhcmNoeSB0d2ljZSB3aGVuDQo+
PiBleGVjdXRpbmcgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2UoKSBmb3IgUENJIGRldmljZToNCj4+
DQo+PiB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZSgpIC0+IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2
aWNlKCkgLT4NCj4+IHhlbl9kdF9tYXBfaWQoKSAtPiB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUo
KQ0KPj4NCj4+DQo+PiBXaGF0IGRvIHlvdSB0aGluaz8NCj4+DQo+DQo+IEkgd2FzIHRoaW5raW5n
IHBhc3NpbmcgdGhlIGRldmljZV9ub2RlIGFsb25nIHdpdGggdGhlIGRldmljZSBpbiB0aGUgDQo+
IGZ1bmN0aW9uIGFyZ3VtZW50cy4gTW9yZSBzcGVjaWZpY2FsbHksIG9mIGRvaW5nIHRoaXMgKG5v
dCB0ZXN0ZWQsIGp1c3QgDQo+IGFuIGlkZWEpOg0KPg0KPiBib29sIHhlbl9pc19ncmFudF9kbWFf
ZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4gew0KPiDCoMKgwqAgc3RydWN0IGRldmljZV9u
b2RlICpucDsNCj4gwqDCoMKgIGJvb2wgaGFzX2lvbW11ID0gZmFsc2U7DQo+DQo+IMKgwqDCoCAv
KiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNlcyBmb3Igbm93ICovDQo+IMKgwqDCoCBucCA9IHhl
bl9kdF9nZXRfbm9kZShkZXYpOw0KPiDCoMKgwqAgaWYgKG5wKQ0KPiDCoMKgwqDCoMKgwqDCoCBo
YXNfaW9tbXUgPSB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShkZXYsIG5wKTsNCj4gwqDCoMKg
IG9mX25vZGVfcHV0KG5wKTsNCj4gwqDCoMKgIHJldHVybiBoYXNfaW9tbXU7DQo+IH0NCj4NCj4g
c3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2
LA0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApDQo+IHsNCj4g
wqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBOVUxMOw0KPiDCoMKgwqAgYm9v
bCBoYXNfaW9tbXU7DQo+DQo+IMKgwqDCoCBpZiAoZGV2X2lzX3BjaShkZXYpKSB7DQo+IMKgwqDC
oMKgwqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPiDCoMKg
wqDCoHUzMiBpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51bWJlciwgcGRldi0+ZGV2Zm4pOw0K
PiDCoMKgwqDCoMKgwqDCoCBvZl9tYXBfaWQobnAsIGlkLCAiaW9tbXUtbWFwIiwgImlvbW11LW1h
cC1tYXNrIiwgJmlvbW11X25wLCANCj4gTlVMTCk7DQo+IMKgwqDCoCB9IGVsc2Ugew0KPiDCoMKg
wqDCoMKgwqDCoCBpb21tdV9ucCA9IG9mX3BhcnNlX3BoYW5kbGUobnAsICJpb21tdXMiLCAwKTsN
Cj4gwqDCoMKgIH0NCj4NCj4gwqDCoMKgIGhhc19pb21tdSA9IGlvbW11X25wICYmIG9mX2Rldmlj
ZV9pc19jb21wYXRpYmxlKGlvbW11X25wLCANCj4gInhlbixncmFudC1kbWEiKTsNCj4gwqDCoMKg
IG9mX25vZGVfcHV0KGlvbW11X25wKTsNCj4NCj4gwqDCoMKgIHJldHVybiBoYXNfaW9tbXU7DQo+
IH0NCg0KDQpJIGdvdCBpdC4NCg0KeGVuX2lzX2dyYW50X2RtYV9kZXZpY2UoKSBmb3IgVjMgd29u
J3QgY2FsbCB4ZW5fZHRfZ2V0X25vZGUoKSwgYnV0IGNhbGwgDQp4ZW5faXNfZHRfZ3JhbnRfZG1h
X2RldmljZSgpIGRpcmVjdGx5Lg0KDQpzdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2Rl
dmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQp7DQogwqDCoCDCoHN0cnVjdCBkZXZpY2Vfbm9kZSAq
aW9tbXVfbnAgPSBOVUxMOw0KIMKgwqAgwqBib29sIGhhc19pb21tdTsNCg0KIMKgwqAgwqBpZiAo
ZGV2X2lzX3BjaShkZXYpKSB7DQogwqDCoCDCoMKgwqDCoCBpZiAoeGVuX2R0X21hcF9pZChkZXYs
ICZpb21tdV9ucCwgTlVMTCkpDQogwqDCoCDCoMKgwqDCoCDCoMKgwqAgcmV0dXJuIGZhbHNlOw0K
IMKgwqAgwqB9IGVsc2UgaWYgKGRldi0+b2Zfbm9kZSkNCiDCoMKgIMKgwqDCoMKgIGlvbW11X25w
ID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21tdXMiLCAwKTsNCiDCoMKgIMKg
ZWxzZQ0KIMKgwqAgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOw0KDQogwqDCoCDCoGhhc19pb21tdSA9
IGlvbW11X25wICYmDQogwqDCoCDCoMKgwqDCoCDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGli
bGUoaW9tbXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQogwqDCoCDCoG9mX25vZGVfcHV0KGlvbW11
X25wKTsNCg0KIMKgwqAgwqByZXR1cm4gaGFzX2lvbW11Ow0KfQ0KDQpib29sIHhlbl9pc19ncmFu
dF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCnsNCiDCoMKgIMKgLyogWFhYIEhhbmRs
ZSBvbmx5IERUIGRldmljZXMgZm9yIG5vdyAqLw0KIMKgwqAgwqByZXR1cm4geGVuX2lzX2R0X2dy
YW50X2RtYV9kZXZpY2UoZGV2KTsNCn0NCg0KDQoNCj4NCj4gSSAnbSB3b25kZXJpbmcgLi4uIGlz
IGl0IHBvc3NpYmxlIGZvciB0aGUgaG9zdCBicmlkZ2UgZGV2aWNlIG5vZGUgdG8gDQo+IGhhdmUg
dGhlIGlvbW11cyBwcm9wZXJ0eSBzZXQ/IG1lYW5pbmcgdGhhdCBhbGwgb2YgaXRzIHBjaSBkZXZz
IHdpbGwgDQo+IGhhdmUgdGhlIHNhbWUgYmFja2VuZD8NCg0KR29vZCBxdWVzdGlvbi4gSSB0aGlu
aywgaXQgaXMgcG9zc2libGUuLi4gVGhpcyBpcyB0ZWNobmljYWxseSB3aGF0IFYxIGlzIA0KZG9p
bmcuDQoNCg0KQXJlIHlvdSBhc2tpbmcgYmVjYXVzZSB0byBzdXBwb3J0ICJpb21tdXMiIGZvciBQ
Q0kgZGV2aWNlcyBhcyB3ZWxsIHRvIA0KZGVzY3JpYmUgdGhhdCB1c2UtY2FzZSB3aXRoIGFsbCBQ
Q0kgZGV2aWNlcyBoYXZpbmcgdGhlIHNhbWUgZW5kcG9pbnQgSUQgDQooYmFja2VuZCBJRCk/DQpJ
ZiB5ZXMsIEkgdGhpbmssIHRoaXMgY291bGQgYmUgc3RpbGwgZGVzY3JpYmVkIGJ5ICJpb21tdS1t
YXAiIHByb3BlcnR5LCANCnNvbWV0aGluZyBsaWtlIHRoYXQgKGlmIHdlIGRvbid0IHdhbnQgdG8g
ZGVzY3JpYmUgbWFwcGluZyBmb3IgZWFjaCBQQ0kgDQpkZXZpY2Ugb25lLWJ5LW9uZSkuDQoNCmlv
bW11LW1hcCA9IDwweDAgJmlvbW11IFggMHgxPjsNCg0KaW9tbXUtbWFwLW1hc2sgPSA8MHgwPjsN
Cg0Kd2hlcmUgdGhlIFggaXMgYmFja2VuZCBJRC4NCg0KDQpJdCBmZWVscyB0byBtZSB0aGF0IGl0
IHNob3VsZCBiZSB3cml0dGVuIGRvd24gc29tZXdoZXJlIHRoYXQgZm9yIA0KcGxhdGZvcm0gZGV2
aWNlcyB3ZSBleHBlY3QgImlvbW11cyIgYW5kIGZvciBQQ0kgZGV2aWNlcyB3ZSBleHBlY3QgDQoi
aW9tbXUtbWFwL2lvbW11LW1hcC1tYXNrIiB0byBiZSBwcmVzZW50Lg0KDQoNCg0KPg0KPg0KPj4+
DQo+Pj4+DQo+Pj4+PiDCoMKgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOw0KPj4+Pj4gwqDCoCB9DQo+
Pj4+PiBAQCAtMzI1LDEyICszNzcsMTkgQEAgYm9vbCB4ZW5fdmlydGlvX21lbV9hY2Moc3RydWN0
IHZpcnRpb19kZXZpY2UNCj4+Pj4+ICpkZXYpDQo+Pj4+PiDCoMKgIHN0YXRpYyBpbnQgeGVuX2R0
X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+Pj4+PiDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVu
X2dyYW50X2RtYV9kYXRhICpkYXRhKQ0KPj4+Pj4gwqDCoCB7DQo+Pj4+PiAtwqDCoMKgIHN0cnVj
dCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYzsNCj4+Pj4+ICvCoMKgwqAgc3RydWN0IG9mX3Bo
YW5kbGVfYXJncyBpb21tdV9zcGVjID0geyAuYXJnc19jb3VudCA9IDEgfTsNCj4+Pj4+IMKgwqAg
LcKgwqDCoCBpZiAob2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3MoZGV2LT5vZl9ub2RlLCAiaW9t
bXVzIiwNCj4+Pj4+ICIjaW9tbXUtY2VsbHMiLA0KPj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYs
ICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+Pj4+IC3CoMKgwqDCoMKgwqDC
oCByZXR1cm4gLUVTUkNIOw0KPj4+Pj4gK8KgwqDCoCBpZiAoZGV2X2lzX3BjaShkZXYpKSB7DQo+
Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9kdF9tYXBfaWQoZGV2LCAmaW9tbXVfc3BlYy5u
cCwgaW9tbXVfc3BlYy5hcmdzKSkgew0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2
X2VycihkZXYsICJDYW5ub3QgdHJhbnNsYXRlIElEXG4iKTsNCj4+Pj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHJldHVybiAtRVNSQ0g7DQo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgfQ0KPj4+Pj4g
K8KgwqDCoCB9IGVsc2Ugew0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChvZl9wYXJzZV9waGFu
ZGxlX3dpdGhfYXJncyhkZXYtPm9mX25vZGUsICJpb21tdXMiLA0KPj4+Pj4gIiNpb21tdS1jZWxs
cyIsDQo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDAsICZpb21tdV9zcGVj
KSkgew0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3Qg
cGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHJldHVybiAtRVNSQ0g7DQo+Pj4+PiArwqDCoMKgwqDCoMKgwqAgfQ0KPj4+Pj4gwqDCoMKgwqDC
oMKgIH0NCj4+Pj4+IMKgwqAgwqDCoMKgwqDCoCBpZiAoIW9mX2RldmljZV9pc19jb21wYXRpYmxl
KGlvbW11X3NwZWMubnAsIA0KPj4+Pj4gInhlbixncmFudC1kbWEiKSB8fA0KPj4+Pj4gQEAgLTM1
NCw2ICs0MTMsNyBAQCBzdGF0aWMgaW50DQo+Pj4+PiB4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5k
X2RvbWlkKHN0cnVjdCBkZXZpY2UgKmRldiwNCj4+Pj4+IMKgwqAgdm9pZCB4ZW5fZ3JhbnRfc2V0
dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+PiDCoMKgIHsNCj4+Pj4+IMKgwqDC
oMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4+Pj4gK8KgwqDCoCBz
dHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4+Pj4gwqDCoCDCoMKgwqDCoMKgIGRhdGEgPSBmaW5k
X3hlbl9ncmFudF9kbWFfZGF0YShkZXYpOw0KPj4+Pj4gwqDCoMKgwqDCoMKgIGlmIChkYXRhKSB7
DQo+Pj4+PiBAQCAtMzY1LDggKzQyNSwxMyBAQCB2b2lkIHhlbl9ncmFudF9zZXR1cF9kbWFfb3Bz
KHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4+IMKgwqDCoMKgwqDCoCBpZiAoIWRhdGEpDQo+Pj4+
PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVycjsNCj4+Pj4+IMKgwqAgLcKgwqDCoCBpZiAo
ZGV2LT5vZl9ub2RlKSB7DQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9kdF9ncmFudF9p
bml0X2JhY2tlbmRfZG9taWQoZGV2LCBkYXRhKSkNCj4+Pj4+ICvCoMKgwqAgbnAgPSB4ZW5fZHRf
Z2V0X25vZGUoZGV2KTsNCj4+Pj4+ICvCoMKgwqAgaWYgKG5wKSB7DQo+Pj4+PiArwqDCoMKgwqDC
oMKgwqAgaW50IHJldDsNCj4+Pj4+ICsNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSB4ZW5f
ZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSk7DQo+Pj4+PiArwqDCoMKgwqDC
oMKgwqAgb2Zfbm9kZV9wdXQobnApOw0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChyZXQpDQo+
Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4+Pj4gwqDCoMKg
wqDCoMKgIH0gZWxzZSBpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFO
VCkpIHsNCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRldl9pbmZvKGRldiwgIlVzaW5nIGRv
bTAgYXMgYmFja2VuZFxuIik7DQo+Pj4+PiAtLSANCj4+Pj4+IDIuMjUuMQ0KPj4+Pj4NCj4+Pj4N
Cj4+Pg0KPg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:23:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:23:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426844.675561 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWRr-0006dD-Hf; Thu, 20 Oct 2022 14:23:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426844.675561; Thu, 20 Oct 2022 14:23:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWRr-0006d6-DE; Thu, 20 Oct 2022 14:23:03 +0000
Received: by outflank-mailman (input) for mailman id 426844;
 Thu, 20 Oct 2022 14:23:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MjXl=2V=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1olWRq-0006d0-6Z
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 14:23:02 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b18e1968-5082-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 16:22:58 +0200 (CEST)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29KDxbi8013099;
 Thu, 20 Oct 2022 14:22:25 GMT
Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta02.appoci.oracle.com [147.154.18.20])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k99nthkt9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 20 Oct 2022 14:22:25 +0000
Received: from pps.filterd
 (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5)
 with ESMTP id 29KCvH5B027423; Thu, 20 Oct 2022 14:22:24 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100])
 by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id
 3k8htjmb6n-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Thu, 20 Oct 2022 14:22:24 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by CH2PR10MB4294.namprd10.prod.outlook.com (2603:10b6:610:a7::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 14:22:22 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::dcd4:3c82:8227:3fd]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::dcd4:3c82:8227:3fd%6]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 14:22:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b18e1968-5082-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2022-7-12;
 bh=oDA76FvYITBlSHbEfX0s8L75NKxf4Oi+JoKzayh4O2Q=;
 b=zne8gIKT0+IExqS7hp6KB5W8PRoqXABzj+duhUuRf91gLOdip2RixFgt227uAA+7LiWh
 WkXIQ/21tXhPqx/M8Nlot0xI9Oi/SopyooUet3/SwQSWX72N45sioUT6LNifNcm7bLIM
 FhymyBx4SPeJ9ClWbE82/CrkRgYOk4w2/ctEeu5ph309IY4cOSYdLoM11Sh/jUGxQQDQ
 EoxgG0R/1Y1PQFTlxMfGvBEhYklPRtIXxbsZlwytj641OGiwZTPIesQHwrLBR+Wszy62
 TmXemAXk9yeq7lgQk1+e81/Lb8qdHzat/0lM6e/BzVOSPhsE38y8Lum9jfsOvx66c3Qh bQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QnKwZgBwfRK0z7t2Tbt6UQMGUd+U9emLavrkp6ByfTDUbQkhX95wfv3iD870qk6T2ChYfgaei/Q5R2lQVySTFjzoPTuPitWj4UBYDpQDS/P0eDlJJRXkyNH7YYuVRaLZpEHl11eC8z7VBxs9s7sR5nVof8TEFapJL8cPOLRRGpJlxbMeAdq/ZFBzMc+zovZ1NJ9YA/nM9GXDgrfKCxYPYvb3XqwoDtBsDVPvCjqMgqKrm7aX6Rsc79rYvDLQ8omiW0donJgGhLHs8Bsld/vCgnC2fYOeGuD4umW0R9hZRf8+qlQrogZAjA9vU6kkpOjLHIThcnmzuSXBd0ua5eKS7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oDA76FvYITBlSHbEfX0s8L75NKxf4Oi+JoKzayh4O2Q=;
 b=CpfT2FeH99LetQkpnCUx31LUUI8YBl4Xe44QsxDJv591WlrmQS1WqBhlvJlyYrqaJi0pHv3jbPXe56e7e3ogwf0lNPHWYExxfD8Mv+A/Ad7q3oxl7KUn+Nnrb/rlwxg6tr9Vdt091+88JsiKFxaxhad2vzh4VyzrjAOYJ6yFLny/WbPJ4MglqycbJ8xgDE0lPbUUPnN4ulFbd9PaixqCq2LoXmqaOb0TMjaCLdqlY9+l/Kvt9f2kLJrIQPkgrVVxM6hfThS9ql4lkdtrkkI7rUeXwzr4gZBLFWwdL4DEf+ozsdwdjs18zgMg6F/Jk8csgQTpM6VyyCDjq4K1bUFEpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oDA76FvYITBlSHbEfX0s8L75NKxf4Oi+JoKzayh4O2Q=;
 b=VEHM8PAqfHAxU1wfFfkIrBxSjSJ46adJrSgrZ+Ro9neHvBu8dV3Ir9oag68WDkLuJ1QW8ii2KOtkitGMvC/HGddoTRCrHz4Plnr7M9kgdwLG3TglEAGxhHQC+4yVl7wab55yVwy8eOr+zBm+Chk5bc3THxbwOH3uDyh3/z0joP0=
Message-ID: <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>
Date: Thu, 20 Oct 2022 10:22:17 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org
References: <20221020113759.17402-1-jgross@suse.com>
 <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
 <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA0PR11CA0163.namprd11.prod.outlook.com
 (2603:10b6:806:1bb::18) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|CH2PR10MB4294:EE_
X-MS-Office365-Filtering-Correlation-Id: 67da7cc3-60e9-4bc0-7459-08dab2a68088
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	qzIpak83jz0mJUCNx+Z2tYjYxePZZpaia02PICBH2ySBeQ4wz/0SGqiGOwZ1CptMTBAY3658HxrCzvQH9f/uPygyxtc0ReTp86F2jEKUgzgTUT5arPFMkohjUdN5cgx6c3EWfzoscnFqNtTiNAJWmfdJSuUgRMbAHsUtmCKgVp1ftRGEDfpdQulTe6RXWNp+g6R5sdgq9+HbskL9Qk9XZ61aZqEU+j+0o+TSOVhYkpiuRRtyiFUCpyzR81wc6DPi5o5k8b2F7UpNV6J0T3gGjYzytgeRFYyiG/7t3+iIUSH9Ur0bspmbiN8oNICve0jpIS5+taRPy+VHwMy4EH/P81VFInHF0x58mf96RIn1ZAIt2AvbZpp7gdfvVS8Mu+FyxP+vF8H8iIMkhUUpB+MjwnAL/RbKCbqbvjbSG/mJI4ky9iHvCmZKmSt1HMS32V4Jxd0R6DELkz4TvOQxi2TAcTKVKV/MWjREkW1aBDloht3B6C2LKdJjuxAlRmrRPljMgE+D2lNbZiOKpzUoQBjKVgYXrJjPBjLHdxj5cZ3JAlzk2hWAvvbosBQDGvKOuWq3SmN3JS2Uh9n9DMGXZB5WhATcBVYMJw13jXXMvsOQNvaTAhYGcgdNYgP3AJYFu7gBOYBvwTVK+zhFK3j549zXJdR/ZuWCMitpxYSSehhQ3UE0ERRNPgrEuTO8Kp7b6g/dkKXggi6Jzn822AVwBCE8itsoCXb4CXuBxranvWz6AeQ7HUND/rxdPd0hXANrun7PdT+D/DVhZgcjVeOX72dkp3yUAOqzLuvZaT/Lbs2FET0=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199015)(186003)(2906002)(6486002)(38100700002)(478600001)(2616005)(53546011)(66476007)(66556008)(66946007)(86362001)(6512007)(6506007)(26005)(8676002)(4326008)(44832011)(54906003)(110136005)(316002)(6666004)(31686004)(8936002)(5660300002)(36756003)(83380400001)(31696002)(41300700001)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WkVaSnhVbUZuYUh5Wno2RTV0cURBc1Jram5KVTNsNHo2U1NQQjBnUzlkK3ZN?=
 =?utf-8?B?bGhWamxTVlpUQ25VU0UzTVIwVU9aS0MzTzFXMVpUV0h6SWlSQUlzMi9Hbzdn?=
 =?utf-8?B?VVFuU2FiS3ViYUxpeHBFb1MrRUpFZzRocDgraUwvRVBrNWM0aFRPM1UwRitB?=
 =?utf-8?B?a09yV09MYzdId250cFRubW40RzNGbHc1enlJTDBBK0RpN3VFQmNyczZzR0Jv?=
 =?utf-8?B?UEY5Z1dmL2dwTEJqTThTOEhBdE5yS3pTeGpqdXUrbnBicXVsTmVTNTRrVWdk?=
 =?utf-8?B?UWFJMjV0NTI4WEZBcytiV1pvVnFRRkZocmRTQXZ5ZjhMNlBDc0p0OHZqUXlG?=
 =?utf-8?B?T1hNdTdadE9udjE3K0taZjQ4Wmd5M2dlZXFtc1g4RFJjYnVHazRRbXpqNm9y?=
 =?utf-8?B?TGV2SW9vWGNhbEl4Tmh4Q0ZyclFHZzZBN0dNU3JVN3k4ZDdENUNkZGpicGF6?=
 =?utf-8?B?bXNxT1hqTGZUUWMxaTNNVW5qcGNGRHNVWURuVjRUanNhMm05N3hzSitVUUNj?=
 =?utf-8?B?SVFib3QwSlpSc1AzS3h4dXNVNGxkZ1BaRlpLZTNsemcwMWk0cWlNaHZuU085?=
 =?utf-8?B?RnBzd2ZRR2VxNnlYU1JhSE1FV3VNNDF2SzQ3Z3Z3NFJnam90UDBqVHBzMkdQ?=
 =?utf-8?B?U1BtYzcvZnA2Z1JnTmE1dWZFeVJjMGdPdkx3QitGRlVqZ1h4a0EvM0Myc1Jr?=
 =?utf-8?B?N1BQZVBGNjFFVGxnbWV2S05oVG9WVmtOeGpMMk9BclZMQ09uR1hFN0lzNkxU?=
 =?utf-8?B?YXFyQkY1UVBTZ2Rid1hndGpZU1JQNjEzSVNyZ0UrOEdydlRpWW1HRFFRVFY4?=
 =?utf-8?B?M3A4MGQyOVlJWERPczZrUVpoQ3N4UjZyL1VBKzdwVGR0c2cxaUNOekVjejB3?=
 =?utf-8?B?RStibVQ1SmpFWmFqU1UrUXBPTXhyR0JIN0VjbDBWYWpidG1PakxRdWVZbmRz?=
 =?utf-8?B?bHNpQUwwWVAxMFJyM3dsa1MwOTRzN1RJZ0xOSTZmUmpRT1FNeTg1ZENqK1BH?=
 =?utf-8?B?dmdPMm9JZy9LOUNHR0d4RWFJTjA5anpHdStzUjNvM0dVdVBoL0Q2ZFpxTXA4?=
 =?utf-8?B?c1VLZ1NBR0wwN0l0S0ZGcnhjSXV2OTBYSWt5dTd0bDFhaFdPUU9odGQ2UnBx?=
 =?utf-8?B?VUZyMHBCVTRLSGNMNmljMUc1ZVJ0L3AwbjB0TnFRYjVIcHp5Q0FFTm04dHNj?=
 =?utf-8?B?TFV3VHB1MFRqN3JnVkhsTFdZWWRleTkxaStEaWlyTkFBcEZjVTVBQjF0NWs5?=
 =?utf-8?B?Tk5NN0hDZTBRYVZuTjJhMjdwNzZPUkpBZjI1OHdFWEU2RzNBdjJHNDNxQWJO?=
 =?utf-8?B?NFVjZ1pOT2Vnb0w4eXpTa3BZQWhjMVE3T0RJVFFLQkRMeERWalhYbmFuU09Y?=
 =?utf-8?B?QjgxU1BGd3FTQnAzemE3bndHTXpBVjdWdmcyMmh4T3daVWFJdy8vOSsxbmNK?=
 =?utf-8?B?TVVoQjBqWUVpOU1hNkpOYnJGL1JPeDZLeDY0TDhiTlE3K3htN1YwMHVzTVdk?=
 =?utf-8?B?enoxNVlrT0MwOE42MUdoSmlsVlp5ZXJqdGxWRVhVa3hYelVCSVkvUW1hU044?=
 =?utf-8?B?amFxRkp6d2Z4aVRtbEZXd2dYKzVJZ01hTkt6QlJCZXg0b1JsM2U1ajh1NFhr?=
 =?utf-8?B?M3pqaXBMeEFZbGlWM0k2R0dqbzgyUUdsT0hVSXM0bmtkZlE1NkNmU2NUZkgr?=
 =?utf-8?B?MElBb3VJVUs1TTQ2N0RjdVMzU0hNSWpIWTREdWtkZFZZS1U2U01FMXpFWXUx?=
 =?utf-8?B?TUdNUVl5Y1N1MGtxbkRtQUFYWXFyV01sblVRU1FOWTZXamg5YVl6UzRzcWJI?=
 =?utf-8?B?cmNkZnV5ZXhTc0hUa01BcmR1ZG5TOWt6SGdpcDlXR2x2cDhNQ0RKbHpVOVoz?=
 =?utf-8?B?aGlPeTVvVU16RUY2d3BDalE0cFRnN2syVE12a1VJcFloeDRtamhmdU41SWdV?=
 =?utf-8?B?N2hXVGIrWWJxOVBoaUZSbmdYb2QrZTF3bHJjY0JoK2xOMGJ0M1ZJd3ZtaWZ1?=
 =?utf-8?B?VDIzZXdqL2RNaXEyRnRTR1R5TWFWb3dGR05NOVpydldaQ2s4NU9JanYzNzRm?=
 =?utf-8?B?R3cyOXdadkFRc2drL3l5SnMwMzQ0bDZSUU5jbXRjTXVXWFFHQWoxRXVBODN2?=
 =?utf-8?B?S3lrbTZPSXJIS0xxMjNNNFR6cFRwSkhaeTh6Zm5wNEY4U2QwTWdZNFd5Z2x2?=
 =?utf-8?B?cVE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67da7cc3-60e9-4bc0-7459-08dab2a68088
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 14:22:22.0837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zCganyRDOODqedaDF2hpSOjjxCZjHOc7O4k9rmqoj5jDrMb8InEaD2NlYJ2SzQutYNHyjWB12/u2tnZQzhE0Zt0YdaMoqTNqlTnWUYbOYow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4294
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_05,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210200085
X-Proofpoint-ORIG-GUID: jyncAmDMA-NPX_ZWfE3p3kVUMZXuqUd-
X-Proofpoint-GUID: jyncAmDMA-NPX_ZWfE3p3kVUMZXuqUd-


On 10/20/22 9:34 AM, Juergen Gross wrote:
> On 20.10.22 15:16, Jan Beulich wrote:
>> On 20.10.2022 13:37, Juergen Gross wrote:
>>> Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr
>>> accesses") introduced code resulting in a warning issued by the smatch
>>> static checker, claiming to use an uninitialized variable.
>>>
>>> This is a false positive, but work around the warning nevertheless.
>>
>> The risk of introducing a problem might be quite low here, but in general
>> it exists: With the adjustment you remove any chance of the compiler
>> spotting a missing initialization before use. And I'm not convinced using
>> 0 in such a case would actually be ending up sufficiently benign.
>
> Hmm, an alternative would be to initialize it to -1 and add a test for the
> index to be >= 0 before using it.
>
> Or to live with the smash warning with the chance, that a compiler might be
> warning for the same reason in the future.


Is smatch complaining about both variables or just index? There are two cases in is_intel_pmu_msr() where it returns true but index is not set so perhaps that's what bothers smatch? It shold not complain if is_intel_pmu_msr() returns false.


-boris



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:33:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:33:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426850.675571 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWbY-00088d-Fh; Thu, 20 Oct 2022 14:33:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426850.675571; Thu, 20 Oct 2022 14:33:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWbY-00088W-Cu; Thu, 20 Oct 2022 14:33:04 +0000
Received: by outflank-mailman (input) for mailman id 426850;
 Thu, 20 Oct 2022 14:33:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olWbX-00088Q-DS
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 14:33:03 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 197e39cd-5084-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 16:33:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B2DC01FB15;
 Thu, 20 Oct 2022 14:33:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60DC813494;
 Thu, 20 Oct 2022 14:33:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id DenjFR1cUWPAZwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 14:33:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 197e39cd-5084-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666276381; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=FVJfmgnGQuxRuEnHw66oXT6YXcIqyTpdZDa7LzHLN5w=;
	b=kgxlmMZcwUcsuGEZrkDxM4t+oB3F1WwaoBTAn13ODCiBzKcnFMxsXNPPIXU4ngCtCLhQ6j
	iJEAow2rSoR/1zSt9RcXlv1BvMTMqMMf5ILBYcWc8Jds5Z+/yk1hp6kelGxTpiCx1WZQMu
	6gwzfhJ8A1E6xp+rngTyS/qDENLzqnQ=
Message-ID: <69f4f7dd-e630-709d-5aa9-334e349109d9@suse.com>
Date: Thu, 20 Oct 2022 16:33:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
Content-Language: en-US
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org,
 x86@kernel.org
References: <20221020113759.17402-1-jgross@suse.com>
 <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
 <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
 <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------zcyfHE0S2ceMK3XoHgwlW6GL"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------zcyfHE0S2ceMK3XoHgwlW6GL
Content-Type: multipart/mixed; boundary="------------vR7EN6oD0YjsOeoyfv6823Cr";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
 Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org,
 x86@kernel.org
Message-ID: <69f4f7dd-e630-709d-5aa9-334e349109d9@suse.com>
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
References: <20221020113759.17402-1-jgross@suse.com>
 <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
 <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
 <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>
In-Reply-To: <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>

--------------vR7EN6oD0YjsOeoyfv6823Cr
Content-Type: multipart/mixed; boundary="------------TNcG0JL7CRY7VAUwTgdr1NZC"

--------------TNcG0JL7CRY7VAUwTgdr1NZC
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMTAuMjIgMTY6MjIsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDEw
LzIwLzIyIDk6MzQgQU0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBPbiAyMC4xMC4yMiAx
NToxNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMjAuMTAuMjAyMiAxMzozNywgSnVl
cmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gQ29tbWl0IDg3MTRmN2JjZDNjMiAoInhlbi9wdjog
YWRkIGZhdWx0IHJlY292ZXJ5IGNvbnRyb2wgdG8gcG11IG1zcg0KPj4+PiBhY2Nlc3NlcyIp
IGludHJvZHVjZWQgY29kZSByZXN1bHRpbmcgaW4gYSB3YXJuaW5nIGlzc3VlZCBieSB0aGUg
c21hdGNoDQo+Pj4+IHN0YXRpYyBjaGVja2VyLCBjbGFpbWluZyB0byB1c2UgYW4gdW5pbml0
aWFsaXplZCB2YXJpYWJsZS4NCj4+Pj4NCj4+Pj4gVGhpcyBpcyBhIGZhbHNlIHBvc2l0aXZl
LCBidXQgd29yayBhcm91bmQgdGhlIHdhcm5pbmcgbmV2ZXJ0aGVsZXNzLg0KPj4+DQo+Pj4g
VGhlIHJpc2sgb2YgaW50cm9kdWNpbmcgYSBwcm9ibGVtIG1pZ2h0IGJlIHF1aXRlIGxvdyBo
ZXJlLCBidXQgaW4gZ2VuZXJhbA0KPj4+IGl0IGV4aXN0czogV2l0aCB0aGUgYWRqdXN0bWVu
dCB5b3UgcmVtb3ZlIGFueSBjaGFuY2Ugb2YgdGhlIGNvbXBpbGVyDQo+Pj4gc3BvdHRpbmcg
YSBtaXNzaW5nIGluaXRpYWxpemF0aW9uIGJlZm9yZSB1c2UuIEFuZCBJJ20gbm90IGNvbnZp
bmNlZCB1c2luZw0KPj4+IDAgaW4gc3VjaCBhIGNhc2Ugd291bGQgYWN0dWFsbHkgYmUgZW5k
aW5nIHVwIHN1ZmZpY2llbnRseSBiZW5pZ24uDQo+Pg0KPj4gSG1tLCBhbiBhbHRlcm5hdGl2
ZSB3b3VsZCBiZSB0byBpbml0aWFsaXplIGl0IHRvIC0xIGFuZCBhZGQgYSB0ZXN0IGZvciB0
aGUNCj4+IGluZGV4IHRvIGJlID49IDAgYmVmb3JlIHVzaW5nIGl0Lg0KPj4NCj4+IE9yIHRv
IGxpdmUgd2l0aCB0aGUgc21hc2ggd2FybmluZyB3aXRoIHRoZSBjaGFuY2UsIHRoYXQgYSBj
b21waWxlciBtaWdodCBiZQ0KPj4gd2FybmluZyBmb3IgdGhlIHNhbWUgcmVhc29uIGluIHRo
ZSBmdXR1cmUuDQo+IA0KPiANCj4gSXMgc21hdGNoIGNvbXBsYWluaW5nIGFib3V0IGJvdGgg
dmFyaWFibGVzIG9yIGp1c3QgaW5kZXg/IFRoZXJlIGFyZSB0d28gY2FzZXMgaW4gDQo+IGlz
X2ludGVsX3BtdV9tc3IoKSB3aGVyZSBpdCByZXR1cm5zIHRydWUgYnV0IGluZGV4IGlzIG5v
dCBzZXQgc28gcGVyaGFwcyB0aGF0J3MgDQo+IHdoYXQgYm90aGVycyBzbWF0Y2g/IEl0IHNo
b2xkIG5vdCBjb21wbGFpbiBpZiBpc19pbnRlbF9wbXVfbXNyKCkgcmV0dXJucyBmYWxzZS4N
Cg0KSSBkaWRuJ3QgdGVzdCBpdCBteXNlbGYsIHNvIEkgY2FuIG9ubHkgc3BlY3VsYXRlLg0K
DQpJIGd1ZXNzIHRoZSBwcm9ibGVtIGlzIHdoZW4gaXNfaW50ZWxfcG11X21zcigpIHJldHVy
bnMgdHJ1ZS4NCg0KSW4gdGhlIGVuZCBJIGRvbid0IHRoaW5rIHdlIGV4cGVjdCBtdWNoIGNv
ZGUgY2h1cm4gaW4gdGhpcyBhcmVhIGluIHRoZSBmdXR1cmUuDQpJdHMgbm90IGFzIGlmIHRo
ZSBwbXUgaGFuZGxpbmcgZm9yIFBWIGd1ZXN0cyBpcyBleHBlY3RlZCB0byBiZSBleHRlbmRl
ZC4NCg0KDQpKdWVyZ2VuDQo=
--------------TNcG0JL7CRY7VAUwTgdr1NZC
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------TNcG0JL7CRY7VAUwTgdr1NZC--

--------------vR7EN6oD0YjsOeoyfv6823Cr--

--------------zcyfHE0S2ceMK3XoHgwlW6GL
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNRXBwFAwAAAAAACgkQsN6d1ii/Ey94
2Af9FTsQmeKB0W9tHVkHTh2hlh8WkHYaXHtUZtzC6+PfP1bbQ6A+0zEMFnb34/49RqtBRbOxysPw
EeHMstV6Iki/418N6leZY6ed0MW649g/IxXZMO2W2zL7qk0D6J5j61c8DW5VqtYwXbBbvJUCZ9oF
4bRtoarCqNnL3hWHoaTZpN6Hat6MG9f9K5Gs53sTc/1kjFEhVZF28K6kiubmq/iOxQGLsOEJFiyj
tKa4Xe/AkVVfIRT6vYtUGWV6NIsXShndmYPzH1RAV+2YHxi5uLaVEpqUd+Ph8fLVztLFYBoybGmR
19fBzhNre321KgmIsApMnHEaF0gYkE1amNmbF0qprw==
=/pVF
-----END PGP SIGNATURE-----

--------------zcyfHE0S2ceMK3XoHgwlW6GL--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:35:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426856.675582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWdU-0000H7-SE; Thu, 20 Oct 2022 14:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426856.675582; Thu, 20 Oct 2022 14:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWdU-0000H0-PE; Thu, 20 Oct 2022 14:35:04 +0000
Received: by outflank-mailman (input) for mailman id 426856;
 Thu, 20 Oct 2022 14:35:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pNAa=2V=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1olWdT-0000GP-5k
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 14:35:03 +0000
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5fbaf5b9-5084-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 16:35:00 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 96C495C010A;
 Thu, 20 Oct 2022 10:34:59 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Thu, 20 Oct 2022 10:34:59 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 20 Oct 2022 10:34:58 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fbaf5b9-5084-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1666276499; x=
	1666362899; bh=M2YOLwha2ja59yQIzvd0K5jAGGswBOvDyJHTaUljHQI=; b=M
	7/B9NNjyZ3Rz1VP0841yh1xB2YXKT+3cyRuAbccRLy5oNSaE0s+ZsKkwZ/j5EEs7
	Ik8z2G0jacShs6k9gVPPGJ5hbHtbBHa56dZOor+UpaKXgBV0fHCS1neEN7H8sers
	qeEAC1/hxhrufxBHb60034ESnVX/gy/R9EnJx2ecEFDsKyOruC0VpuGhLZunJTvq
	MWSjvZ9imsHRhnW09c7bPYuH14gXQLHH1UjidXIGkWahJSOdpmoAWgC75RIcvGu6
	FkLQ0fhFJmQ+ADlw9ec/t+acthCJsFtMEdIWd2WG2G/s7vYQkXN7c4lCICh50ehR
	4SFISb68ZDEj0blS1OoZA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1666276499; x=1666362899; bh=M2YOLwha2ja59yQIzvd0K5jAGGsw
	BOvDyJHTaUljHQI=; b=jglGp3C0yfaC//P6LfC2dVUf1bzqZZ92nUsvG22VFJSj
	NDTqqJqJU5RiXaffRL5AUHcR9sQC9ug1VeYRM7rgMIBopsTP93ZYmfCaeyyGFBge
	rLtfO/pXLO005tTK7hMEaxQQhUIt87boFryghX1dW5WPJ+AunhmpZn0QAClhiYpe
	iFjZcf7GhCbbZc3AvsJ/cJqPIQTDzpGFJzwTDsnfF/xVIWx6w4wiHNHbKjNHXGoy
	uhGohsMJLRXJApDieYm51Yyh9B4X3jjAHUZpVM0/nYc2CZcNps/GsFaM8DBiqTRl
	qk17xdkd/aGd45Th/eFjrzQ0u29WcIlZrSTo0AoBag==
X-ME-Sender: <xms:k1xRY8TLCrKaTshqimzoYkDKpL9u2pwHHCvQ3DIVlS10z-OdR85h6Q>
    <xme:k1xRY5z2UJq3k8yhdlITJ7UuV-zqlI1f72yWTbdDgO986c76T_yfURqPGMc5Ph0aN
    wYpIBPCZ053aQ>
X-ME-Received: <xmr:k1xRY52AOQnH_X0_SqbnnImUrWqESC-hhbfogrD3LxxrKRloTS8mMPjwGrkJZ3UJQ14pLrqklMfEDg9kkjEQWs8wxiNHStvzDUAv>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeliedgjeekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek
    teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh
    grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr
    mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh
    hlrggsrdgtohhm
X-ME-Proxy: <xmx:k1xRYwA9qJJkbm32dYzYia42ZLZT96bp3gnMoSa4qAipdpbUQGGZ-A>
    <xmx:k1xRY1i9sxDSiRfo9RI8MoXiei5r0SLM-oDniehL3L-PNXxD5XLWiw>
    <xmx:k1xRY8pKq_YXkzIhLzhjv0FhTmDZJeXLYWYGup-blOzqTDtqvX2akA>
    <xmx:k1xRY1bo6VHGkTZIyprqqcAumz9m2Xg6z1Xmyd9bzCoQSP1i_IjLgQ>
Feedback-ID: i1568416f:Fastmail
Date: Thu, 20 Oct 2022 16:34:56 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH] Use direct I/O for loop devices
Message-ID: <Y1FckIT6OHJ/x0Ri@mail-itl>
References: <20220817204634.1886-1-demi@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="3GrwXgwMqQJNlss4"
Content-Disposition: inline
In-Reply-To: <20220817204634.1886-1-demi@invisiblethingslab.com>


--3GrwXgwMqQJNlss4
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 20 Oct 2022 16:34:56 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH] Use direct I/O for loop devices

On Wed, Aug 17, 2022 at 04:46:34PM -0400, Demi Marie Obenour wrote:
> This is a huge performance improvement for two reasons:
>=20
> 1. It uses the filesystem=E2=80=99s asynchronous I/O support, rather than=
 using
>    synchronous I/O.
> 2. It bypasses the page cache, removing a redundant layer of caching and
>    associated overhead.

Cross-posting here just in case: this patch breaks block script on
devices with 4k block size, at least with some util-linux versions.
More details at https://github.com/QubesOS/qubes-issues/issues/7828

> ---
>  tools/hotplug/Linux/block | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/hotplug/Linux/block b/tools/hotplug/Linux/block
> index 2691b56951c9b82094471a141b9e0bed04abb929..75785f3a5422c4a5f962a4cd4=
f6acae5080d036d 100644
> --- a/tools/hotplug/Linux/block
> +++ b/tools/hotplug/Linux/block
> @@ -330,7 +330,7 @@ mount it read-write in a guest domain."
>          else
>            roflag=3D''
>          fi
> -        do_or_die losetup $roflag "$loopdev" "$file"
> +        do_or_die losetup --direct-io=3Don $roflag "$loopdev" "$file"
>          xenstore_write "$XENBUS_PATH/node" "$loopdev"
>          write_dev "$loopdev"
>          release_lock "block"
> --=20
> Sincerely,
> Demi Marie Obenour (she/her/hers)
> Invisible Things Lab
>=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--3GrwXgwMqQJNlss4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNRXJAACgkQ24/THMrX
1yzTSwf+NrQBIPlt+6CU7Yr751HmGxyzYb19e1YB5oQUk2UgKMuVYhAJK3m4uZEH
kchcO+83pB4p2/s8cSoxs6Fet8eG+lzYcjQI7oHU0giV9KJODbQJoBQv127CWeQs
rKgm5PudpyKPcaKFexF7dnPa01FubL0kp4qIJkPZUP0uXwrtZLwHGeMOJlf1St7M
2l8EKBAROkp/gydRidhTWfiP3zEtq3dfx5hjRqpbWHsl9/JKq/C71ULTAv7i9mAB
iEWGrflN2dqGTtXE37zaYNQLrsO/xg0V3459V+67vVce1GoL5W/y76jpQ4zIdImA
ccx408YNTwoOsRsO3LlyWieoU3QdPA==
=xFc5
-----END PGP SIGNATURE-----

--3GrwXgwMqQJNlss4--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:37:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:37:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426864.675593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWfx-000114-DF; Thu, 20 Oct 2022 14:37:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426864.675593; Thu, 20 Oct 2022 14:37:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWfx-00010x-AO; Thu, 20 Oct 2022 14:37:37 +0000
Received: by outflank-mailman (input) for mailman id 426864;
 Thu, 20 Oct 2022 14:37:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olWfw-00010l-A7; Thu, 20 Oct 2022 14:37:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olWfw-0001Ok-3r; Thu, 20 Oct 2022 14:37:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olWfv-0001KN-Oy; Thu, 20 Oct 2022 14:37:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olWfv-0006B4-OW; Thu, 20 Oct 2022 14:37:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=rGOgom4+lhhkua9qLBGgc2MkhKI/rZsGvjFo3d3LwOU=; b=OFKlBOUr5NbPK1CsV/I8IUu6DV
	77Fhihfm1u9VNAPLETtu2kkkcaTDptqY4+q4Kx6UNvSaDzyE6VHYFnRMnd/iXRQsmq20+DUC7LyzH
	5cQ7b1Jdu9jByR0WbOdWAYmnRNP1st2LACnELuByLyKwlMoyTB2XmvTKcUmHxUlkrBYI=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-armhf-armhf-libvirt-raw
Message-Id: <E1olWfv-0006B4-OW@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 14:37:35 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-armhf-armhf-libvirt-raw
testid debian-di-install

Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174127/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-armhf-armhf-libvirt-raw.debian-di-install.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-libvirt-raw.debian-di-install --summary-out=tmp/174127.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-armhf-armhf-libvirt-raw debian-di-install
Searching for failure / basis pass:
 173986 fail [host=arndale-westfield] / 172623 [host=cubietruck-picasso] 172548 [host=arndale-metrocentre] 172130 [host=arndale-lakeside] 172110 ok.
Failure / basis pass flights: 173986 / 172110
Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d618fe05bf93a8884619e9362bfc5636da55e347 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 89fe6d0edea841d1d2690cf3f5173e334c687823
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0\
 dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-d618fe05bf93a8884619e9362bfc5636da55e347 git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad8-107951211a8d17658e1aaa0c23a8cf29f8806ad8 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#89fe6d0edea841d1d2690cf3f5173e334c687823-1bce7fb1f702da4f7\
 a749c6f1457ecb20bf74fca
>From git://cache:9419/git://xenbits.xen.org/xen
   9029bc265c..c7cff11888  smoke      -> origin/smoke
Loaded 10001 nodes in revision graph
Searching for test results:
 173759 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173882 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173977 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 89fe6d0edea841d1d2690cf3f5173e334c687823
 173993 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174011 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 11a04bb4a68bc670bd7619c910d55a78221f3d38 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174026 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3c0d567c3719675b9d8ecf07c31706d96467e31b 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173986 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d618fe05bf93a8884619e9362bfc5636da55e347 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174042 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 336133660715a08d2b8b1660ea86ef003d6854c4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174058 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 745e0b300dc3f5000e6d48c273b405d4bcc29ba7
 174068 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 e85e2a3c17b6cd38de041cdaf14d9efdcdabad1a
 174077 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 755a9b52844de3e1e47aa1fc9991a4240ccfbf35
 174097 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174104 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174110 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174117 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174122 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174127 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 172130 [host=arndale-lakeside]
 172110 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 89fe6d0edea841d1d2690cf3f5173e334c687823
 172548 [host=arndale-metrocentre]
 172623 [host=cubietruck-picasso]
 173493 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173511 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173702 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173603 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Searching for interesting versions
 Result found: flight 172110 (pass), for basis pass
 For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x5599369674d8) HASH(0x559936a74438) HASH(0x5599369a6ef0) For basis failure, parent search stopping at 2c846fa6b\
 cc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 755a9b52844de3e1e47aa1fc9991a4240ccfbf35, results HASH(0x559936969de0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9b\
 e763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 745e0b300dc3f5000e6d48c273b405d4bcc29ba7, results HASH(0x559936983fe0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 336133660715a08d2b8b1660ea86ef003d6854c\
 4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x559936990c60) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3c0d567c3719675b9d8ecf07c31706d96467e31b 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb571\
 6698a11312a3f38bc8865cd1e67, results HASH(0x55993698c928) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 11a04bb4a68bc670bd7619c910d55a78221f3d38 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x559936972128) For basis failure, parent search stoppi\
 ng at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 89fe6d0edea841d1d2690cf3f5173e334c687823, results HASH(0x55993697a770) HASH(0x559936967ad8) Result found: flight 173493 (fail), for basis failure (at ancestor ~655)
 Repro found: flight 173977 (pass), for basis pass
 Repro found: flight 173986 (fail), for basis failure
 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 174097 (pass), for last pass
 Result found: flight 174104 (fail), for first failure
 Repro found: flight 174110 (pass), for last pass
 Repro found: flight 174117 (fail), for first failure
 Repro found: flight 174122 (pass), for last pass
 Repro found: flight 174127 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174127/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 164 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-libvirt-raw.debian-di-install.{dot,ps,png,html,svg}.
----------------------------------------
174127: tolerable FAIL

flight 174127 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/174127/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-armhf-armhf-libvirt-raw 12 debian-di-install       fail baseline untested


jobs:
 build-armhf-libvirt                                          pass    
 test-armhf-armhf-libvirt-raw                                 fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 14:49:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 14:49:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426878.675626 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWr8-0002iT-N2; Thu, 20 Oct 2022 14:49:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426878.675626; Thu, 20 Oct 2022 14:49:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olWr8-0002iM-K9; Thu, 20 Oct 2022 14:49:10 +0000
Received: by outflank-mailman (input) for mailman id 426878;
 Thu, 20 Oct 2022 14:49:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2BcH=2V=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olWr7-0002iG-5J
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 14:49:09 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 589d1603-5086-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 16:49:07 +0200 (CEST)
Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com
 [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-250-AOvrBBh8MEC-FnOImWVHZw-1; Thu, 20 Oct 2022 10:49:04 -0400
Received: by mail-qv1-f72.google.com with SMTP id
 h3-20020a0ceec3000000b004b17a25f8bcso13153606qvs.23
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 07:49:04 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 j12-20020a05620a288c00b006b640efe6dasm7399796qkp.132.2022.10.20.07.49.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 07:49:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 589d1603-5086-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666277345;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8Ht4uc+F2VhKi75XpFbjwSsqeX/sAc/dV4pRAF7MDqY=;
	b=SqPvzb4HXYEVLTnDoIkPtQBnVZG7d9DpNMm420xo8vOC7pV0kPs+9hnMgBzZ8LYN4kAjlf
	/w0nylLYopz0ap2kYRMA/yX2ZfeAy4jkSqxsF42N09wEXiq4KAM2uCqiZwKLTbRGfybAHf
	5fvKLZLYueNfc4QapQD24rliTecMC5s=
X-MC-Unique: AOvrBBh8MEC-FnOImWVHZw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=8Ht4uc+F2VhKi75XpFbjwSsqeX/sAc/dV4pRAF7MDqY=;
        b=rHK2dSF5Rk+aju51hr4Umiq5zqzjHVqgOTwPSJK18XhoKsBFeBkCIwYWuiFOfD4olG
         /LgZMp5m3UAaV+C8o9ToRUWgLpxA1J5LpM0csKi6yw/YahuHFaPTrmK1ga969ku44ZZZ
         2WdNs2x8vJrDiwxddMK4HWw2xMRtegDG63dxAUJ4n8W1PilSD05lcW0Z/IHSHY0TGWx6
         xIVbvWouIHPOUQaCg0h55l4JBDOJRI+WOVopDcbK9mflxGypJyXWtL+eQoXE+1TX4HLY
         gbIFrPZRfezOh8huLTIMD6Y/5zeE7q3HZu1O6rmLDHczeiYMNUYb5BLQMDT1qyCFvutE
         dXGw==
X-Gm-Message-State: ACrzQf1d9aJ3f1SEfi2phRw/C5q4ycdPdYCYZz9ndW+80X7xOJNkcVzr
	rGA/f+PhLR19qJLLqc7gN5ZREA90u16Z7h6kFzLWcLUH9/iXSOHC6sMpcUP+WjcKulSb7W9jeR9
	uAHObQqmvkVHs9DgekItWI1WRoLM=
X-Received: by 2002:a05:6214:e6b:b0:4b3:dcaf:c3a7 with SMTP id jz11-20020a0562140e6b00b004b3dcafc3a7mr11516010qvb.34.1666277344055;
        Thu, 20 Oct 2022 07:49:04 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5oWaxjXIjtOg84/mDXFCwbgTI0D8L9sa7jNLjyAhRZGVP7+cxo6c5D4KJthUj3eEDZTCkahg==
X-Received: by 2002:a05:6214:e6b:b0:4b3:dcaf:c3a7 with SMTP id jz11-20020a0562140e6b00b004b3dcafc3a7mr11515993qvb.34.1666277343846;
        Thu, 20 Oct 2022 07:49:03 -0700 (PDT)
Message-ID: <8050912a-58e2-892c-0808-1c4ea6168b68@redhat.com>
Date: Thu, 20 Oct 2022 16:48:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v12 16/17] tests/qtest: netdev: test stream and dgram
 backends
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>,
 qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-17-lvivier@redhat.com>
 <0f964c69-e3c7-b40a-be5e-85ae0471916d@linaro.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <0f964c69-e3c7-b40a-be5e-85ae0471916d@linaro.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/20/22 15:26, Philippe Mathieu-Daudé wrote:
> On 20/10/22 11:16, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   tests/qtest/meson.build     |   1 +
>>   tests/qtest/netdev-socket.c | 417 ++++++++++++++++++++++++++++++++++++
>>   2 files changed, 418 insertions(+)
>>   create mode 100644 tests/qtest/netdev-socket.c
> 
>> +int main(int argc, char **argv)
>> +{
>> +    int ret;
>> +
>> +    g_test_init(&argc, &argv, NULL);
>> +
>> +    qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
>> +    qtest_add_func("/netdev/stream/inet/ipv6", test_stream_inet_ipv6);
>> +    qtest_add_func("/netdev/stream/unix", test_stream_unix);
>> +    qtest_add_func("/netdev/stream/unix/abstract", test_stream_unix_abstract);
>> +    qtest_add_func("/netdev/stream/fd", test_stream_fd);
> 
> The stream tests don't work for me (testing on Darwin).
> 
> ERROR:../../tests/qtest/netdev-socket.c:99:test_stream_inet_ipv4:assertion failed (resp == 
> "st0: index=0,type=stream,\r\n"): ("st0:index=0,type=stream,connection error\r\n" == "st0: 
> index=0,type=stream,\r\n")

My bad: I have changed the default value for "server" but I didn't update the test.

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:06:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:06:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426885.675641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olX7y-0005Bc-62; Thu, 20 Oct 2022 15:06:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426885.675641; Thu, 20 Oct 2022 15:06:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olX7y-0005BV-2y; Thu, 20 Oct 2022 15:06:34 +0000
Received: by outflank-mailman (input) for mailman id 426885;
 Thu, 20 Oct 2022 15:06:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Iaqk=2V=citrix.com=prvs=285ecbe66=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1olX7w-0005BP-JR
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 15:06:32 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c6c640ed-5088-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 17:06:31 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6c640ed-5088-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666278391;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=bVN7ZWAH5fn95rabhI2OjoclmsTOib16zT0YVRWBEjM=;
  b=fABZkyAKPN1JkI2n3hnN86QgR//xIOkf4kz7hR/GeOf/9zUJJyndLkRa
   4Hrr6DslNNyJ2ijig9X/yGoT/fJFOqn8CiP5AwUkXXBmhJ3zQ43TBvn+u
   ZYQarcU8SXDJ+W2GjftBZJ4TsNMQ3RsTUoTLJjLJM9J7FfBT3uhlk5ZHY
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 85696420
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:L5+ZQqz7YJOneQ45mYF6t+fVxirEfRIJ4+MujC+fZmUNrF6WrkVSx
 2caWjvSOPaMYmvyLdEgPNuxpEtSuJXQyYJqSwpkpSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC5gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/dgoKGBK8
 aMjOGoIVDbf29ronqOmY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP
 pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJ4LbG5kPxi50o
 Erc1WShISMdF+fG0Bnb0FaRqKzxjBzSDdd6+LqQqacx3Qz7KnYoIBwJV3OrrP+hkEm8VtlDb
 UsO9UIGsqwa5EGtCN7nUHWQgHOCpA9aZNNWHMUz8gTLwa3Riy61B2ULSXh6ddEnrsgeTCYvk
 FSOmrvBLzF1rKecT37b076OtC6zIgAcN2pEbigBJSM97sXuuscTiQPCVf5qCqvzhdrwcRngz
 jbPoCUgirE7ic8Qy7797V3BmyirpJXCUkgy/Aq/Y46+xlonPsj/PdXusAWFq6YbRGqEcrWfl
 H86xOGf6ORRNoHXkRarHLk1Qu+4+t/QZVUwnmVTN5Um8j2s/VuqcoZR/CxyKS9VDyoURdP6S
 BSN4F0Mvfe/KFPvNPYqONzpV6zG2IC6TbzYuubogs2ii3SbXCuO52lQaEGZxAgBe2B8wPhka
 f93nStBZEv26JiLLhLsGo/xMpdxnEjSIF8/oriilnyaPUK2PiL9dFv8GALmghoFxK2Fuh7J1
 N1UKtGHzR5SOMWnPHeJqNdDcQxUdiVhbXwTlyCwXrfZSjeK5Ul7U6OBqV/fU9YNc1tpehfgo
 SjmBx4wJKvXjnzbMwSaAk1ehEfUdc8n9xoTZHV0VX7xgiRLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwTEGiYqmtAMsSmxGGgHTzy7T+z0+OeSGBXV/Zdq8bhoLcIoiOHGPEyMxeK
IronPort-HdrOrdr: A9a23:12FmS6FihngCJ35tpLqE6seALOsnbusQ8zAXP0AYc31om+ij5q
 eTdZUgpHvJYVkqNE3I9eruBEDEewK7yXcX2/h1AV7BZniEhILAFugLhuGO/9SjIVydygc079
 YYT0EUMr3N5DZB4/rH3A==
X-IronPort-AV: E=Sophos;i="5.95,198,1661832000"; 
   d="scan'208";a="85696420"
Date: Thu, 20 Oct 2022 16:06:16 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Peter Hoyes <Peter.Hoyes@arm.com>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Diego Sueiro <Diego.Sueiro@arm.com>, "Ian
 Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Henry Wang
	<Henry.Wang@arm.com>
Subject: Re: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Message-ID: <Y1Fj6J/iWYJ4fx8J@perard.uk.xensource.com>
References: <20221003144216.2297632-1-peter.hoyes@arm.com>
 <E63CD72F-9C98-4EB2-840C-56C46BFD7BA1@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <E63CD72F-9C98-4EB2-840C-56C46BFD7BA1@arm.com>

On Tue, Oct 18, 2022 at 08:13:57AM +0000, Bertrand Marquis wrote:
> Hi,
> 
> Gentil ping on this one as it might be a suitable one for 4.17

Yeah, that might be a good bug fix to have.

> > On 3 Oct 2022, at 15:42, Peter Hoyes <Peter.Hoyes@arm.com> wrote:
> > From: Peter Hoyes <Peter.Hoyes@arm.com>
> > 
> > The xendomains script uses the output of `xl list -l` to collect the
> > id and name of each domain, which is used in the shutdown logic, amongst
> > other purposes.
> > 
> > The linked commit added a "domid" field to libxl_domain_create_info.
> > This causes the output of `xl list -l` to contain two "domid"s per
> > domain, which may not be equal. This in turn causes `xendomains stop` to
> > issue two shutdown commands per domain, one of which is to a duplicate
> > and/or invalid domid.
> > 
> > To work around this, make the LIST_GREP pattern more restrictive for
> > domid, so it only detects the domid at the top level and not the domid
> > inside c_info.
> > 
> > Fixes: 4a3a25678d92 ("libxl: allow creation of domains with a specified
> > or random domid")
> > Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>

Parsing json with bash, grep and sed, what could go wrong :-). Anyway,
patch looks fine:

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:08:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:08:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426892.675652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXAD-0005rw-Lj; Thu, 20 Oct 2022 15:08:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426892.675652; Thu, 20 Oct 2022 15:08:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXAD-0005rp-J8; Thu, 20 Oct 2022 15:08:53 +0000
Received: by outflank-mailman (input) for mailman id 426892;
 Thu, 20 Oct 2022 15:08:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2BcH=2V=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olXAD-0005rh-Bs
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 15:08:53 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b03c673-5089-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 17:08:52 +0200 (CEST)
Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com
 [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-218-D4QfYWbMN1mdSupDFAUTCg-1; Thu, 20 Oct 2022 11:08:50 -0400
Received: by mail-qv1-f71.google.com with SMTP id
 h3-20020a0ceec3000000b004b17a25f8bcso13202887qvs.23
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 08:08:49 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 q28-20020a05620a2a5c00b006eed14045f4sm7916260qkp.48.2022.10.20.08.08.45
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 08:08:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b03c673-5089-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666278531;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GQ3dyElTQZpuiNzY8qlpiaTnLAs808Grj4avBqSktKw=;
	b=TzDAJM7I8a3R1DWXOnFlIuAuKF2T7fuUYHrEsGJlIb8m3BaAxLxk/EE8lgsXatB26EP1tu
	3zjtI5ggWdFbLEDPmrYJ7mRczqBGF3bGh3wBK3+k45404WIFM11aJqhoY39cFudcb5mGA4
	TEcR8FeM/XHeKknC3HIg9wb9FaHNzIY=
X-MC-Unique: D4QfYWbMN1mdSupDFAUTCg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=GQ3dyElTQZpuiNzY8qlpiaTnLAs808Grj4avBqSktKw=;
        b=kiG8HJhq3uTo3OPKb0UPrjLkCsFxoC0GCh0GwLXLKPc3GQpgfmI3ZD2B/YgIbMfPq2
         dx6yz4WhZJrdbNBRPjGWNalXfI3VAjpz3jhwpHulneHqJ4NNa37oe9Lij7FS/vYW3w4A
         EWn815ZxAvoP6Qyz7syKr4J3fQTdk1VOne+xk5rxZbicxrVL5Yb3IPo8+b18d8Nxis1n
         hsog95RMKKqYS6aXqifiE/xfDAUVmRtwq4BQrhivS+B0E3xe468rCLYZICaDaR834hm9
         Cz80e7GNwkCM0n/1ZGlIP9gNw8h/fLa/bvhpat3row8UNgfdutMM3b+xr045pMkyU+K5
         s2+A==
X-Gm-Message-State: ACrzQf3TYVeORaWOYG1TEHvkHeDR1XIPUT0akBy2Yxe5nbmzGMMbwBN8
	VqV1ItM+joSBqSfM/0O1UTwA7WyB2ukkBmppYJwY9cDZZZSbl3u2mn/0w9tmQtTthIOjVEsdsg7
	k9xm7UXKKJfefjODQqyj8VCClqEM=
X-Received: by 2002:a05:620a:4244:b0:6cf:8a7b:3224 with SMTP id w4-20020a05620a424400b006cf8a7b3224mr9668003qko.32.1666278529481;
        Thu, 20 Oct 2022 08:08:49 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7Mk82y1w4IUblOwX4CtN0grxQ3paXzht3z6wWUQ6Z2aEgvGzoxxatl5GNWIuPDLGRd5a9rHQ==
X-Received: by 2002:a05:620a:4244:b0:6cf:8a7b:3224 with SMTP id w4-20020a05620a424400b006cf8a7b3224mr9667958qko.32.1666278529228;
        Thu, 20 Oct 2022 08:08:49 -0700 (PDT)
Message-ID: <71247f91-a74e-e497-8376-488e399c8c43@redhat.com>
Date: Thu, 20 Oct 2022 17:08:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v12 10/17] net: dgram: make dgram_dst generic
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>,
 qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-11-lvivier@redhat.com>
 <15217f04-d689-7579-1501-320761b2f6e7@linaro.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <15217f04-d689-7579-1501-320761b2f6e7@linaro.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/20/22 13:17, Philippe Mathieu-Daudé wrote:
> On 20/10/22 11:16, Laurent Vivier wrote:
>> dgram_dst is a sockaddr_in structure. To be able to use it with
>> unix socket, use a pointer to a generic sockaddr structure.
>>
>> Rename it dest_addr, and store socket length in dest_len.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   net/dgram.c | 82 ++++++++++++++++++++++++++++++++++-------------------
>>   1 file changed, 53 insertions(+), 29 deletions(-)
> 
>>   static NetClientInfo net_dgram_socket_info = {
>> @@ -260,7 +263,7 @@ static NetDgramState *net_dgram_fd_init(NetClientState *peer,
>>                                           SocketAddress *mcast,
>>                                           Error **errp)
>>   {
>> -    struct sockaddr_in saddr;
>> +    struct sockaddr_in *saddr = NULL;
> 
> Preferrably g_autofree.

No, because saddr pointer is copied to s->dest_addr.

...
>> @@ -339,21 +342,24 @@ static int net_dgram_mcast_init(NetClientState *peer,
>>   {
>>       NetDgramState *s;
>>       int fd, ret;
>> -    struct sockaddr_in saddr;
>> +    struct sockaddr_in *saddr;
> 
> Preferrably:
> 
>    g_autofree struct sockaddr_in *saddr = NULL.

The same here.

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:09:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:09:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426897.675663 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXAn-0006Mr-W9; Thu, 20 Oct 2022 15:09:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426897.675663; Thu, 20 Oct 2022 15:09:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXAn-0006Mk-Sr; Thu, 20 Oct 2022 15:09:29 +0000
Received: by outflank-mailman (input) for mailman id 426897;
 Thu, 20 Oct 2022 15:09:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RZuZ=2V=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olXAn-0006J7-3H
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 15:09:29 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2047.outbound.protection.outlook.com [40.107.104.47])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3034eb04-5089-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 17:09:27 +0200 (CEST)
Received: from AS9PR06CA0604.eurprd06.prod.outlook.com (2603:10a6:20b:46e::6)
 by AS8PR08MB9479.eurprd08.prod.outlook.com (2603:10a6:20b:5ec::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 15:09:25 +0000
Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46e:cafe::8c) by AS9PR06CA0604.outlook.office365.com
 (2603:10a6:20b:46e::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Thu, 20 Oct 2022 15:09:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Thu, 20 Oct 2022 15:09:24 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Thu, 20 Oct 2022 15:09:24 +0000
Received: from f4f12de16f39.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B48A1BCB-B5A4-41ED-9866-D68930C29D11.1; 
 Thu, 20 Oct 2022 15:09:15 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4f12de16f39.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 20 Oct 2022 15:09:15 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS1PR08MB7476.eurprd08.prod.outlook.com (2603:10a6:20b:4dc::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Thu, 20 Oct
 2022 15:09:11 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Thu, 20 Oct 2022
 15:09:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3034eb04-5089-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Kw9htgoVFgnX2rd9KWH0lloCwlvF45bHh5xC9nP1z8YJHoZyhUcShTZc3MlkCPqzY4k9+Jc/+A6G7tIgEqTHyvBBfquBALOZ5f5GFWkku+DCbCS7a6NFkcmDN7CSCu5bNgGXU22wPPL9qYdAxEjsX0f5OGgW3sux1/118Jf63jk8NJq5cquuM3a38RvKeTS3qleGKdHCmjgV5Fq2xOcyWHaP9czCh0pPgfH2zyJKEzLjhFcjFPl95B3KXvjyXsedAGhmNYqSneyBz9t71GwNjBIhvoMTqsnQnSj9XoVAxKEpC/f0Zq8uFeUUnFuv/5yj5FrwJ8yipSkPhDiwq/iO0g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/P0q27pz/FUCbiWfSIqDDlKVjjKuwMR5EdZlip6iRNg=;
 b=ZqWmuSbG6l7MLWlU7Q3yq6CimxiHbXyS3I7yn55mPZQ5FGFcLwP19KTyCPSOlUnQywzgxkSsoNMUYf2jpv5iK56VAV2dlZfqvhNqQWlRl4IdGlyM1Q5usQ8tzN0h6NTe74Si/p/lE3TXgYaAJGjCettdlWfqr6lt0scWPCzeHCrXjF6T5lojCwvypCLNFLGK4DYW34be/rpzzMThUs8UZ3lh3B8NrVnMVgbZGbWM5Ei45pxxd9sjW7vDjzi1u2jvzc7jp+iHwBMnL5Z6X3JGO4aLtFfsrD0JoUNcM9axOZzEy0r4U1spvmzBXQ0gADXW4t3FZ9bocH1FCXKs3oBQ8A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/P0q27pz/FUCbiWfSIqDDlKVjjKuwMR5EdZlip6iRNg=;
 b=FUyARf4fNvOWbP3sAf75N8q3UBSP13moOvFHLCxE3VGnmM5kE8gwVB0I4x5okoHxJkEzcp+yfkIf1QZZ3+pBL+su7JYEJ0Bcdno9LlE3U6SQWKt5pEpYoQdy31yjqA5LYe5tv3LPlW7dyDTw4Tj/hC+znZ4BTOXIC73oSRCs0xg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bfF24NVO24XLJaLsuBjgG/vvXDYdonirzSBNlMnBY3Yu7QzRfpb04kpg7tih/DbwiKlCeToQWhsKiFOQsNveSYHg5xjO361k4K7X2tdas5hrOER+GDTQNrNbq8Ncfw7LVRPI2fCXm3VandcQrQI4VbZL79HZXOPFwhA7nZn/hYR+3EDKMpaJUcqcuSUtKqLpsfjoA7T+3U3BOWOELE0hsTgCsHyCUkZyOBY9wszlH8O8kxiGCVxgvMTTyFAhVZ0HKiSIucfFudsNorJOAyXrs0O1qpiL9V/WVczn6lerowjrw/WMdgvCj58YgJGbmsAwN+TXTAjs4L/U3gWfgN1vTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/P0q27pz/FUCbiWfSIqDDlKVjjKuwMR5EdZlip6iRNg=;
 b=g8v2kjLbjnqBUDTdWf2MO02lsOVb8HlyUPSvEcSo8HYdTXLd7tL6zwdpBvZ27Lyq2C2lSGw9zbmFMcpytPyO9ROr21CSS9lTsho5hzBjgWW4UctNh3q4/4lcW9Tk+gdGDxUWXU24smA9KArcFlI1p1WFYivMM6+MuzeF4Z+h1Jugj8uQ8MCk41q4St/bUA43hy5vkAfdwBXjYRZVg2TiYGFgBoLYThKPRJTblNTfx558wL4PUNXn2GoYLatMPU9xFmjieLLWlUNJjuJFpsAEV9OdM+KQ5h6UGAMbVwQRiPiQLnZVYf3/o+k5N4QaVdXO1bwbAbIvnfOby/61u6lgow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/P0q27pz/FUCbiWfSIqDDlKVjjKuwMR5EdZlip6iRNg=;
 b=FUyARf4fNvOWbP3sAf75N8q3UBSP13moOvFHLCxE3VGnmM5kE8gwVB0I4x5okoHxJkEzcp+yfkIf1QZZ3+pBL+su7JYEJ0Bcdno9LlE3U6SQWKt5pEpYoQdy31yjqA5LYe5tv3LPlW7dyDTw4Tj/hC+znZ4BTOXIC73oSRCs0xg=
From: Henry Wang <Henry.Wang@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
CC: Peter Hoyes <Peter.Hoyes@arm.com>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Diego Sueiro <Diego.Sueiro@arm.com>, Ian
 Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: RE: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Thread-Topic: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GREP
Thread-Index: AQHY1zZYWIYAed9yGUubROrgwcpFPK4T5LaAgAOX3QCAAACvYA==
Date: Thu, 20 Oct 2022 15:09:11 +0000
Message-ID:
 <AS8PR08MB7991D566516CA047BC9F923B922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221003144216.2297632-1-peter.hoyes@arm.com>
 <E63CD72F-9C98-4EB2-840C-56C46BFD7BA1@arm.com>
 <Y1Fj6J/iWYJ4fx8J@perard.uk.xensource.com>
In-Reply-To: <Y1Fj6J/iWYJ4fx8J@perard.uk.xensource.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 9A5B33AA465D90438F844B33F75DCF77.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS1PR08MB7476:EE_|AM7EUR03FT015:EE_|AS8PR08MB9479:EE_
X-MS-Office365-Filtering-Correlation-Id: 8dab360d-1092-420a-4dad-08dab2ad133d
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 J5IS9+20cArpQ1ccTazzmof93SfHDAy9M/FEwj2ZnnktEZXILSi3E0qrUZneLl/ltcOTpHgmRs2a8vwLTBThoYwhE1YaMfkZdBBC24qWQR6xEIBvS3LqFPELuUWYZNp50hvzQ8Vc+EkKt5cfWxOZcgQyZpTyL3oDO8Mq/f457UdVYVaGQnLfWuly1n9PMXuzsftVE+nbjPxagWy0EGaAHSuHpLba11s9D2bMXCcAbE2GpYMG54XGxQAEq0Va9Bcvm3fmbxdIeY1NyyYYk8L6NP38+bt+B3oJv74HUSVmPXxS/OXDDhrmF6f3C4dCwqRFeCCgbdCVHt11Jj7Da4qK8K7rWLm5Z58aFrPElrU2QKyQjJjU8SFSiGFsIrFAfY/d6o3V3ZeGeb54L4v1A+4aLzBsuoJO5tDI3bWRJAVOyRwz036yHLcVBFzyJ6/UItzNc8umZUStc0zQoKDcVS3pPDXDFZdJkn6c9mJjYPmVtGM8fSafyNODYdOLp4K/+WVFOhE6Jw+QHiXEsy4cX6Rn0mWPtbLgjz0CjuYqZjrM2mfG8DksAHVYBi8trEDoGn4LJn4Vg0VitDfoKbLb/0C++FoFUbxv289CGrAGayxJ1r3zHOdx9ex/U+w7VWAumGKInoL24tGP9KEKwWFc9THyo8inTkU/CVyX4tBkRp+2QMgav8yzZNSjuVCVHhQMVMrcKJpVKNf299Eh/yykuIog9Lbdgc77LfjxqtK/wwDsMBtReIV3jTR/e+8xz5DRHJrgACL0DfXNGVbHTSns4M5/7Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199015)(7696005)(6506007)(186003)(53546011)(9686003)(41300700001)(26005)(2906002)(83380400001)(5660300002)(55016003)(110136005)(8676002)(66446008)(66556008)(8936002)(54906003)(64756008)(4326008)(66476007)(66946007)(316002)(6636002)(71200400001)(76116006)(478600001)(52536014)(86362001)(33656002)(38100700002)(38070700005)(122000001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7476
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	09fd2d8d-ba4c-4106-080c-08dab2ad0b22
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m1mlZFzcrU8j5HyUl4NJ714XKyYxNNQkAg5zNYYlmU3Ee3Bp4vGZYTc8k1uubETV2Z6E2AtdlFNvOLTlT28yrWA0hiTdP605V2q+AuDTu3+CZbTMUO9kUT9f7gshBtahsX+V8s7JcuwW6gLeFoHO6RFk4jL0QoXej6M0xmGsYXxqrbklFy3NFLlLcAYQ54x4X3plZLXLUNSQH7Og4xsSqnaGCcW1SCbaY+rLF1SbN0QhCfViM4aA7HZqfO0kPxxUd/eA1qtYriHON+827OTrKyoaJ3s0PTgqJM9YeOdUD+ozErDnVHwvYr8V1rnkeGVzc9mLC9d8A+jeHH25lZBla9cbk8AOLJ8/f220yRJ2NL3ao+z7YY+w1+cxnKfJXa0Vf3uCjKZO5a0IDHuLqbGI5n+xW+OVqEEawrYFPOXCKUT6I7t92k0snu4rgZrC2vTln4SaA28eu77Q6fQtrY81KupbVBq26IoUxvubsxSRGQlc2VO8Dmh5FNW9WU/t4hkpbJowyg+bffZm/nN3KFMBJSLx24KNlu2rvkGDYayHHiMA0zxIICjbD7aDDce7nrhzh0iy4fzmcJw4DJZhsiZPo81zbrTrcEziYKueEwdrjf77+da+6vyn5MplbD9Jf+ZbzYayTODn5daNskgcw6CWII4e+torpyffFR4kaMeJ8Gg20YoFhHhO7b1dKH8ob6kRGccAX6qcK547tEjNxgTHFGl0mwmrKBxP1I1H9mRynSj8HEnjvFX6VaN6a4dEHGOQyrMfF4SXO9eqUl5PlTW1YA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(356005)(47076005)(52536014)(81166007)(86362001)(5660300002)(8676002)(8936002)(41300700001)(7696005)(70586007)(70206006)(53546011)(40460700003)(4326008)(316002)(26005)(55016003)(40480700001)(336012)(110136005)(2906002)(6636002)(82310400005)(54906003)(6506007)(33656002)(186003)(36860700001)(9686003)(478600001)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 15:09:24.7592
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dab360d-1092-420a-4dad-08dab2ad133d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9479

Hi,

> -----Original Message-----
> From: Anthony PERARD <anthony.perard@citrix.com>
> Subject: Re: [PATCH] tools/xendomains: Restrict domid pattern in LIST_GRE=
P
>=20
> On Tue, Oct 18, 2022 at 08:13:57AM +0000, Bertrand Marquis wrote:
> > Hi,
> >
> > Gentil ping on this one as it might be a suitable one for 4.17
>=20
> Yeah, that might be a good bug fix to have.

Agreed.

>=20
> > > On 3 Oct 2022, at 15:42, Peter Hoyes <Peter.Hoyes@arm.com> wrote:
> > > From: Peter Hoyes <Peter.Hoyes@arm.com>
> > >
> > > The xendomains script uses the output of `xl list -l` to collect the
> > > id and name of each domain, which is used in the shutdown logic,
> amongst
> > > other purposes.
> > >
> > > The linked commit added a "domid" field to libxl_domain_create_info.
> > > This causes the output of `xl list -l` to contain two "domid"s per
> > > domain, which may not be equal. This in turn causes `xendomains stop`
> to
> > > issue two shutdown commands per domain, one of which is to a
> duplicate
> > > and/or invalid domid.
> > >
> > > To work around this, make the LIST_GREP pattern more restrictive for
> > > domid, so it only detects the domid at the top level and not the domi=
d
> > > inside c_info.
> > >
> > > Fixes: 4a3a25678d92 ("libxl: allow creation of domains with a specifi=
ed
> > > or random domid")
> > > Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
>=20
> Parsing json with bash, grep and sed, what could go wrong :-). Anyway,
> patch looks fine:
>=20
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

>=20
> Thanks,
>=20
> --
> Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:11:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:11:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426904.675674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXD6-0007ph-Dq; Thu, 20 Oct 2022 15:11:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426904.675674; Thu, 20 Oct 2022 15:11:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXD6-0007pa-Ab; Thu, 20 Oct 2022 15:11:52 +0000
Received: by outflank-mailman (input) for mailman id 426904;
 Thu, 20 Oct 2022 15:11:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olXD5-0007pM-3K; Thu, 20 Oct 2022 15:11:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olXD4-00024P-Ss; Thu, 20 Oct 2022 15:11:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olXD4-0003qJ-J1; Thu, 20 Oct 2022 15:11:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olXD4-0000cD-I0; Thu, 20 Oct 2022 15:11:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=C1pFTg5+otc50BZ0j+DzWWTptSS34TAXfTZZZcs8ETU=; b=oD4P1q7mXamH4eYNjNHk4X3xxd
	0rp5NdZN2BvYtqQexbWnwoSX18IPQ9UwmZ4mFHyX1IgAP9yGgyiiTeLHgOlKSf1q496Ta9cIyIB6i
	juUbKcIXvfn+BwcCOJYWRedj3p6n5rEnhVtQqrcr4hXvDrO3rnVPSQDmnIRBHydvZgG0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174070-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174070: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 15:11:50 +0000

flight 174070 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174070/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173986 pass in 174070
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  7 xen-install fail pass in 173986
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host       fail pass in 173986

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   63 days
Testing same since   173493  2022-10-11 13:07:01 Z    9 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:13:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:13:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426912.675685 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXEU-0008UP-TO; Thu, 20 Oct 2022 15:13:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426912.675685; Thu, 20 Oct 2022 15:13:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXEU-0008UI-Qi; Thu, 20 Oct 2022 15:13:18 +0000
Received: by outflank-mailman (input) for mailman id 426912;
 Thu, 20 Oct 2022 15:13:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=FG6W=2V=aepfle.de=olaf@srs-se1.protection.inumbo.net>)
 id 1olXET-0008UA-Es
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 15:13:17 +0000
Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de
 [85.215.255.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b83cd05d-5089-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 17:13:15 +0200 (CEST)
Received: from sender by smtp.strato.de (RZmta 48.2.0 AUTH)
 with ESMTPSA id z9e8dfy9KFDD1RW
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
 (Client did not present a certificate);
 Thu, 20 Oct 2022 17:13:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b83cd05d-5089-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1666278793;
    s=strato-dkim-0002; d=aepfle.de;
    h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date:
    From:Subject:Sender;
    bh=WRYwxSjI3fCCW9kQyLlQqS00GsQBKloy3nUEzOqqhr0=;
    b=KIQ5yh0Asyfp7rVpFm2um9ejkqkt+4DMB7cUwKt74xPv0OBqISn3Mwp28dKQeCe50N
    8wt10cINDnuCwiXoykyU3RPEfLvrBJXiwE8cgQ21vmem5tvwCVz0nc8u1rmOg5Xz7Lat
    FRurzENpVg9qgKtlyYpZ01Z2Clsf8+wtmb8k93M2ofJhv/ICwARHbGpq664y9YGvgjGw
    62rFvWRTGoSxUy2uSfZEbgeR41QkYSoTHkn3zNGkcaKsS2zWknfrrEYxK6MqrpvRRKOc
    fEj8Xq+t38O3EpUYbVDarRFZWpUXME/c45fPHmR2VoG5V3aChv/b2bjj8f8OzKK1Jy8B
    Qb4g==
Authentication-Results: strato.com;
    dkim=none
X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR4VUeIOBm64+d+5WUw9HQ/QxYfWfC38zdrSEMTow=="
X-RZG-CLASS-ID: mo00
Date: Thu, 20 Oct 2022 17:13:06 +0200
From: Olaf Hering <olaf@aepfle.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>, Oskari
 Pirhonen <xxc3ncoredxx@gmail.com>, mathieu.desnoyers@efficios.com,
 rharwood@redhat.com, samuel.thibault@ens-lyon.org,
 debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <20221020171306.45c275f9.olaf@aepfle.de>
In-Reply-To: <Y0+CzFbQXxYiqgPC@generichostname>
References: <20221017103532.845293-1-liu.denton@gmail.com>
	<20221018131235.5e70f0bc.olaf@aepfle.de>
	<Y06w0Oda0sHTHPNW@generichostname>
	<20221018161821.149ee6fd.olaf@aepfle.de>
	<Y0+CzFbQXxYiqgPC@generichostname>
X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen.
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/WRwpODX/p.BTjC5WHi9/0jq";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/WRwpODX/p.BTjC5WHi9/0jq
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Tue, 18 Oct 2022 21:53:32 -0700 Denton Liu <liu.denton@gmail.com>:

> On Tue, Oct 18, 2022 at 04:18:21PM +0200, Olaf Hering wrote:
> > Maybe the patch description lacks a specific example how the proposed c=
hange is supposed to be used in your environment. =20
> My patch description says:
> 	Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
> 	GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
> 	top-level entry.
> and I'm not quite sure how to make it more clear other than, perhaps,
> explaining what the top-level entry means.

After reading the patch again, the newly added documentation states:
"This option should be a path to a kernel image."

I think it needs to be more specific: is it expecting an absolute path, or =
just the basename of the desired image?


Olaf

--Sig_/WRwpODX/p.BTjC5WHi9/0jq
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmNRZYIACgkQ86SN7mm1
DoBewg/8CgSvlpBoJ4+VNyZOEvHOQF4y5qQkB5WhitIv3GmEztNrEYtLe4lo5MYf
q/TcIK1B5VMo1axI8E0YZRvDD2e0++DaBBVH/8+MokgLKyMTHRuLAVwwxYXLdHId
hnWjaB19Z8pJSXddeoDxg0WSDZI881478+zoKA+oOaQPRX/rkxYQ8AodEgPnNNk8
n747EzPB0rFGhVS6/lPJKWrmLJeApr8LgDmhKao/ECrfoekQGxfGTYoPWrFnA7Fp
qS/cHBd/cGi6NeCRay6zGgmMQn4B6CqRy62tozAEUS9W9lvibFuL2poH2gnUBflt
WCmFl3K+2CHTZwXg0SQ24LOc3JW3OPccOZMGJoMIGnHNWx9PC6M96/lHNn+8l+jy
mYqyggMvfFYJCI6eHAkmCp6/hTamSDFWpRKjm9HmVdcSuoYSNIp69eJulAkVewjO
AJd0vrqe1k+Qfdl1H7x31+iRKvw4nwdsZweSW8sVG7oHOuQS9Zj/w6C6NtDNNvc5
BB1P2XUgrmKkJxm+b66KCUUAB6N14KOBmHAIbKeqJ7j6xRMBi1s+9bkz72zXxX//
HiX0mboyTHE1hUHCSlnZmkMkO7dEsfGXC9F2KHEKulSXXuo64lByjRltcQT5C7sy
p+P616d6yKHk1GlDGX63q6T9za2mmcz/y+g+n6DDlEGnH4+x/2Q=
=eJ4i
-----END PGP SIGNATURE-----

--Sig_/WRwpODX/p.BTjC5WHi9/0jq--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:21:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:21:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426919.675695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXMV-0001YJ-M2; Thu, 20 Oct 2022 15:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426919.675695; Thu, 20 Oct 2022 15:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXMV-0001YC-JM; Thu, 20 Oct 2022 15:21:35 +0000
Received: by outflank-mailman (input) for mailman id 426919;
 Thu, 20 Oct 2022 15:21:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tgfI=2V=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olXMT-0001Y6-TJ
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 15:21:33 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e0cceb99-508a-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 17:21:32 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 31EB72297E;
 Thu, 20 Oct 2022 15:21:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0ED8A13AF5;
 Thu, 20 Oct 2022 15:21:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +AvIAXxnUWPNAgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 20 Oct 2022 15:21:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0cceb99-508a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666279292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QC9m1VpFs9r8xDls23EuZfsJn9t70xMkXds0AA3F3Yw=;
	b=fzeGH+Duk5mBFk0nxtNDggSy6uM8vLqpzY4PRYBUtLcDCAJYMsiceBx7d+BWE1IApyOk3w
	Je8GeBb0DiTnk/J3GVe0MdVPV+Y9AqKYast14xUcPzKtneJerKX5vdzz4aWE6bhddsWuB8
	BpiHuQ2iv0H8jNbonWfrh1BtkegCG4o=
Message-ID: <edd2d799-9f38-966d-868c-26b8cdd7ea16@suse.com>
Date: Thu, 20 Oct 2022 17:21:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: Xen RTDS scheduler locking
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>
References: <6cccc8b6-4073-69bb-e414-2b38d5081004@suse.com>
In-Reply-To: <6cccc8b6-4073-69bb-e414-2b38d5081004@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------dhwI3UwiCWabhA0JsCLLYg04"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------dhwI3UwiCWabhA0JsCLLYg04
Content-Type: multipart/mixed; boundary="------------UGfnP38sPzGBWqMHK2TT9TSx";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>
Message-ID: <edd2d799-9f38-966d-868c-26b8cdd7ea16@suse.com>
Subject: Re: Xen RTDS scheduler locking
References: <6cccc8b6-4073-69bb-e414-2b38d5081004@suse.com>
In-Reply-To: <6cccc8b6-4073-69bb-e414-2b38d5081004@suse.com>

--------------UGfnP38sPzGBWqMHK2TT9TSx
Content-Type: multipart/mixed; boundary="------------k8S9G3UmxXFxscm39w66JxPn"

--------------k8S9G3UmxXFxscm39w66JxPn
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMTAuMjIgMTU6MjYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IExvb2tpbmcgYXQg
dGVzdCBmYWlsdXJlcyB3aXRoIFJURFMgc2NoZWR1bGVyIGluIFhlbiBbMV0gSSB0aGluayBJ
J3ZlIGZvdW5kDQo+IGEgbWFqb3IgaXNzdWUgd2l0aCBsb2NraW5nIGluIHRoZSBSVERTIHNj
aGVkdWxlcjoNCj4gDQo+IHN2Yy0+ZmxhZ3Mgc2VlbXMgdG8gYmUgbm90IHByb3RlY3RlZCBw
cm9wZXJseSwgYXMgZGlmZmVyZW50IGxvY2tzIGFyZQ0KPiB1c2VkIHdoZW4gZG9pbmcgbm9u
LWF0b21pYyB1cGRhdGVzOiBwcnYtPmxvY2sgKHRoZSBSVERTIGdsb2JhbCBsb2NrKSwNCj4g
b3IgdGhlIHBlci1zY2hlZHVsZXItcmVzb3VyY2Ugc2NoZWR1bGluZyBsb2NrLg0KPiANCj4g
SSdtIG5vdCBzdXJlIHdoYXQgd291bGQgYmUgdGhlIGJlc3Qgd2F5IHRvIGZpeCB0aGF0LiBP
bmUgcmF0aGVyIGVhc3kgd2F5DQo+IG1pZ2h0IGJlIHRvIGxldCB0aGUgc2NoZWR1bGluZyBs
b2NrIHBvaW50ZXIgcG9pbnQgYXQgcHJ2LT5sb2NrIChtZXJnaW5nDQo+IG9mIHRoZSB0d28g
bG9ja3MpLCB3aGljaCBpcyBlYXN5IGRvYWJsZSAoY3JlZGl0MiBpcyB1c2luZyBhIHNpbWls
YXIgc2NoZW1lDQo+IHRvIG1ha2UgdGhlIHNjaGVkdWxpbmcgbG9jayBwZXItcnVucXVldWUp
LiBJJ20gbm90IHN1cmUgd2hldGhlciB0aGlzDQo+IHdvdWxkbid0IHJlc3VsdCBpbiBpbGxl
Z2FsIGxvY2sgbmVzdGluZyAodHJ5aW5nIHRvIGdyYWIgcHJ2LT5sb2NrIGluc2lkZQ0KPiB0
aGUgc2NoZWR1bGluZyBsb2NrKSwgdGhvdWdoLg0KDQpNZWgsIHNlZW1zIHRoaXMgd2FzIHdy
b25nIHRoaW5raW5nIG9uIG15IHNpZGUuIFJURFMgaXMgYWxyZWFkeSBzd2l0Y2hpbmcgdGhl
DQpzY2hlZHVsaW5nIGxvY2sgdG8gcHJ2LT5sb2NrLg0KDQpTb3JyeSBmb3IgdGhlIG5vaXNl
Lg0KDQoNCkp1ZXJnZW4NCg0KPiBbMV06IA0KPiBodHRwOi8vbG9ncy50ZXN0LWxhYi54ZW5w
cm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTczNDg4L3Rlc3QtYXJtaGYtYXJtaGYteGwtcnRk
cy9zZXJpYWwtY3ViaWV0cnVjay1waWNhc3NvLmxvZw0KDQo=
--------------k8S9G3UmxXFxscm39w66JxPn
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------k8S9G3UmxXFxscm39w66JxPn--

--------------UGfnP38sPzGBWqMHK2TT9TSx--

--------------dhwI3UwiCWabhA0JsCLLYg04
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNRZ3sFAwAAAAAACgkQsN6d1ii/Ey/f
+Qf+OC4lPDl64l0ouv2l5/zIOHS+JfJXYoWQwF2yA22Zog00rHdMh83fc2bV6pZP6fipTi4pEnDd
+7+EszRFnnN1A1eVcnj0Me4H1v3ELNH8tKGbyXZhb+fq16L5WcRoUUvRMdFoqNOvt1T6x8szZBm7
YgLBomQl7Lmx7g1SabuCX0J2ww9yME7pHiRowWj5j2Xpwihh6m62Afojm7QOB95JVU0Bc8YeP2WE
DzEoHSNNKGNNSle3Q1PgoYfRy5z5ODJznAjW8k2Fnx3IvbF6um/zpgpy2MwH/epPHuuYFbJ1F+8m
MglzxfwwOm3pbXyqYH862lhsPw1/gb5Oa8NvQ2ecgA==
=8E7p
-----END PGP SIGNATURE-----

--------------dhwI3UwiCWabhA0JsCLLYg04--


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 15:23:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 15:23:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426926.675710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXOH-00029e-4D; Thu, 20 Oct 2022 15:23:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426926.675710; Thu, 20 Oct 2022 15:23:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olXOH-00029X-0e; Thu, 20 Oct 2022 15:23:25 +0000
Received: by outflank-mailman (input) for mailman id 426926;
 Thu, 20 Oct 2022 15:23:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2BcH=2V=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olXOG-00029R-Ho
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 15:23:24 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 221f7845-508b-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 17:23:23 +0200 (CEST)
Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com
 [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-187-SyeEJrmBNe27JQLtZrowjg-1; Thu, 20 Oct 2022 11:23:20 -0400
Received: by mail-qt1-f199.google.com with SMTP id
 k9-20020ac85fc9000000b00399e6517f9fso15292014qta.18
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 08:23:20 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 bk18-20020a05620a1a1200b006ec771d8f89sm7645948qkb.112.2022.10.20.08.23.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 08:23:19 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 221f7845-508b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666279402;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zMafXDcBqKdvZpHSUPYR6MPcYJqX4ipPzdBK8RxDOKw=;
	b=IJiYk2/towOBpdYR2Gt+mV0A4zR6Tai4K6ojOWjdqLcsMpPpbOepmKuQihC0jHQEHO692z
	BeWv6M8VvK3ZsvBx8sIbrCbAaTgfJxwWG5FSJc7EY5Spdu/bjq87t10lHp0Gk5XVATOOSA
	/6aDC/5/UtDG9Wq3Utvzy7MHDN4xtmc=
X-MC-Unique: SyeEJrmBNe27JQLtZrowjg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=zMafXDcBqKdvZpHSUPYR6MPcYJqX4ipPzdBK8RxDOKw=;
        b=f901KvgaTk8Xmz9f/3XpparZO546tFZrw9JLZDqOoGbvpOlsDEajecz+YXL9P2JcOZ
         yt/R+H88Vu3Pm1rEEu57VmTzFHZgiotToFw9PEhctpIS1Md3j4CMeFZWyJeOvelZHWIb
         wHlMa/u+CTuyEUb8lcobStryQ1Kh4V+JF+yRObp8Ty868PSMffjvwhnL1d+w/jkuq4dX
         HCl+dDXR/zEOFxWVPGzXmd0tcg1O6C8PfNjulTf06IMm6JxcHu7YhmUOusXZxVDYvegs
         tdIeIJasAhDmx0pDRpLvVy6OSTK13uei5vEDqUIgjX9vuAkqPxsn7anZp0Ww6XhQzVC1
         WOFQ==
X-Gm-Message-State: ACrzQf3VNu0Qi01RQN22csXYhcDBRU5GQ4d6C5DYfQuBsa5uJ6FHEeg6
	UH7dIBRfI3e9g9aaTBQkSaNlRwnTc8lzaevhkvd+so/sgmY+euI1ePmXKZeXN7jomQx3wxCFMWv
	51LDuYJCYS5tNnIxtocOlW+DC138=
X-Received: by 2002:a05:620a:f11:b0:6cf:be4e:e953 with SMTP id v17-20020a05620a0f1100b006cfbe4ee953mr9747467qkl.437.1666279400414;
        Thu, 20 Oct 2022 08:23:20 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5IAM5fKOIcH08J7hWh9Ggvk8a/9IWJQskowqJlbJBxrjSIfRgNk1w/mWkvaP3l64jsbd26/A==
X-Received: by 2002:a05:620a:f11:b0:6cf:be4e:e953 with SMTP id v17-20020a05620a0f1100b006cfbe4ee953mr9747449qkl.437.1666279400159;
        Thu, 20 Oct 2022 08:23:20 -0700 (PDT)
Message-ID: <b1fd6fdf-fd91-b3af-978c-b50c3b1c8763@redhat.com>
Date: Thu, 20 Oct 2022 17:23:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v12 15/17] net: stream: move to QIO to enable additional
 parameters
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>,
 qemu-devel@nongnu.org
Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 xen-devel@lists.xenproject.org, Eric Blake <eblake@redhat.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>,
 Jason Wang <jasowang@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Thomas Huth <thuth@redhat.com>,
 David Gibson <david@gibson.dropbear.id.au>,
 "Michael S. Tsirkin" <mst@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paul Durrant <paul@xen.org>,
 Stefan Weil <sw@weilnetz.de>, Markus Armbruster <armbru@redhat.com>
References: <20221020091624.48368-1-lvivier@redhat.com>
 <20221020091624.48368-16-lvivier@redhat.com>
 <6fa6b9e5-fede-0f68-752f-0c0d8fa3494f@linaro.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <6fa6b9e5-fede-0f68-752f-0c0d8fa3494f@linaro.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/20/22 15:09, Philippe Mathieu-Daudé wrote:
> On 20/10/22 11:16, Laurent Vivier wrote:
>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>> This allows net/stream to use all the available parameters provided by
>> SocketAddress.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   meson           |   2 +-
>>   net/stream.c    | 493 +++++++++++++++++-------------------------------
>>   qemu-options.hx |   4 +-
>>   3 files changed, 180 insertions(+), 319 deletions(-)
> 
>>   static int net_stream_server_init(NetClientState *peer,
>> @@ -283,105 +287,61 @@ static int net_stream_server_init(NetClientState *peer,
>>   {
>>       NetClientState *nc;
>>       NetStreamState *s;
>> -    int fd, ret;
>> -
>> -    switch (addr->type) {
>> -    case SOCKET_ADDRESS_TYPE_INET: {
>> -        struct sockaddr_in saddr_in;
>> -
>> -        if (convert_host_port(&saddr_in, addr->u.inet.host, addr->u.inet.port,
>> -                              errp) < 0) {
>> -            return -1;
>> -        }
>> +    QIOChannelSocket *listen_sioc = qio_channel_socket_new();
>> -        fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
>> -        if (fd < 0) {
>> -            error_setg_errno(errp, errno, "can't create stream socket");
>> -            return -1;
>> -        }
>> -        qemu_socket_set_nonblock(fd);
>> +    nc = qemu_new_net_client(&net_stream_info, peer, model, name);
>> +    s = DO_UPCAST(NetStreamState, nc, nc);
>> -        socket_set_fast_reuse(fd);
>> +    s->listen_ioc = QIO_CHANNEL(listen_sioc);
>> +    qio_channel_socket_listen_async(listen_sioc, addr, 0,
>> +                                    net_stream_server_listening, s,
>> +                                    NULL, NULL);
>> -        ret = bind(fd, (struct sockaddr *)&saddr_in, sizeof(saddr_in));
>> -        if (ret < 0) {
>> -            error_setg_errno(errp, errno, "can't bind ip=%s to socket",
>> -                             inet_ntoa(saddr_in.sin_addr));
>> -            closesocket(fd);
>> -            return -1;
>> -        }
>> -        break;
>> -    }
>> -    case SOCKET_ADDRESS_TYPE_UNIX: {
>> -        struct sockaddr_un saddr_un;
>> -
>> -        ret = unlink(addr->u.q_unix.path);
>> -        if (ret < 0 && errno != ENOENT) {
>> -            error_setg_errno(errp, errno, "failed to unlink socket %s",
>> -                             addr->u.q_unix.path);
>> -            return -1;
>> -        }
>> +    return 0;
>> +}
>> -        saddr_un.sun_family = PF_UNIX;
>> -        ret = snprintf(saddr_un.sun_path, sizeof(saddr_un.sun_path), "%s",
>> -                       addr->u.q_unix.path);
>> -        if (ret < 0 || ret >= sizeof(saddr_un.sun_path)) {
>> -            error_setg(errp, "UNIX socket path '%s' is too long",
>> -                       addr->u.q_unix.path);
>> -            error_append_hint(errp, "Path must be less than %zu bytes\n",
>> -                              sizeof(saddr_un.sun_path));
>> -            return -1;
>> -        }
>> +static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>> +{
>> +    NetStreamState *s = opaque;
>> +    QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(s->ioc);
>> +    SocketAddress *addr;
>> +    gchar *uri;
>> +    int ret;
>> -        fd = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
>> -        if (fd < 0) {
>> -            error_setg_errno(errp, errno, "can't create stream socket");
>> -            return -1;
>> -        }
>> -        qemu_socket_set_nonblock(fd);
>> -
>> -        ret = bind(fd, (struct sockaddr *)&saddr_un, sizeof(saddr_un));
>> -        if (ret < 0) {
>> -            error_setg_errno(errp, errno, "can't create socket with path: %s",
>> -                             saddr_un.sun_path);
>> -            closesocket(fd);
>> -            return -1;
>> -        }
>> -        break;
>> -    }
>> -    case SOCKET_ADDRESS_TYPE_FD:
>> -        fd = monitor_fd_param(monitor_cur(), addr->u.fd.str, errp);
>> -        if (fd == -1) {
>> -            return -1;
>> -        }
>> -        ret = qemu_socket_try_set_nonblock(fd);
>> -        if (ret < 0) {
>> -            error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
>> -                             name, fd);
>> -            return -1;
>> -        }
>> -        break;
>> -    default:
>> -        error_setg(errp, "only support inet or fd type");
>> -        return -1;
>> +    if (sioc->fd < 0) {
>> +        qemu_set_info_str(&s->nc, "connection error");
>> +        goto error;
>>       }
>> -    ret = listen(fd, 0);
>> -    if (ret < 0) {
>> -        error_setg_errno(errp, errno, "can't listen on socket");
>> -        closesocket(fd);
>> -        return -1;
>> +    addr = qio_channel_socket_get_remote_address(sioc, NULL);
>> +    g_assert(addr != NULL);
> 
> Please use:
> 
>         addr = qio_channel_socket_get_remote_address(sioc, &error_fatal);
> 
> Which is more verbose in case of error, i.e.:
> 
>    qemu-system-x86_64: socket family 0 unsupported
> 
> Instead of:
> 
>    ERROR:../../net/stream.c:321:net_stream_client_connected: assertion failed: (addr != NULL)
> 

I put an assert() here because I consider to have NULL here is a programming error, not an 
user error.

"It should not happen".

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 16:55:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 16:55:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426978.675764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olYpP-0004aw-CK; Thu, 20 Oct 2022 16:55:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426978.675764; Thu, 20 Oct 2022 16:55:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olYpP-0004ap-9R; Thu, 20 Oct 2022 16:55:31 +0000
Received: by outflank-mailman (input) for mailman id 426978;
 Thu, 20 Oct 2022 16:55:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LaG4=2V=citrix.com=prvs=285635b8e=edvin.torok@srs-se1.protection.inumbo.net>)
 id 1olYpN-0004ai-FA
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 16:55:29 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fdf194b3-5097-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 18:55:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdf194b3-5097-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666284926;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=OCBu0vUP3JpjZrFBNRbFle7ZV/pcVcLzjOv+Nrmf73g=;
  b=UBgvrU1SPQMXit+hMSzthGqADGQYirWm9IbUsu4ezMMIR40RF8dwnDYY
   r+KjaTbMxm/6pRCJWikZzNGnhkma+VqZL5Gf0vddbkLC+NE8BGEkA5daF
   UEjF3VOu6mLfBoyBvgptUetLl8kic6BkFEZ0l9mGTLuWQsoiFsMLprbNO
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83171108
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AN0fb6Nx6cdymQrvrR28l8FynXyQoLVcMsEvi/4bfWQNrUpzgzFVn
 WQXUWyHa67eYTHyc4t3Odi/9hgA7ZaBm4NjQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo4GtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eNJQeysN4XWZ32
 uVCDTUmUAqtqdCM3+fuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI
 ZpCAdZsRE2ojxlnN1sJCZR4gOCygXrXeDxEslOF46Ew5gA/ySQhi+GyaYONKrRmQ+1+nka3u
 lnqr13aH0slEfK66iO9wmqV07qncSTTB9tJSezQGuRRqEKX7nweDlsRT1TTidm0jFSvHe1WL
 UM88zAr66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZNYcIrnNU7Tjsr0
 hmOhdyBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZQIc5enGr900tz3WFPNmO5CvoPPHIy6ll
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3Hb5
 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8AhkkeS+F0e5eI1cFh
 XM/XisIvfdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxDOhjm9zBRyyvxlU
 Xt+TSpLJS9AYZmLMRLsH7tNuVPV7npWKZzvqWDTkE38jOv2iI+9QrYZKlqeBt0EAFe/iFyNq
 b53bpLSoz0GCbGWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l9UaOOkOx8JNE+90mX/8+Rl
 kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G
IronPort-HdrOrdr: A9a23:3DtL9qhGJZAzkRqffkm7Ewbql3BQXtQji2hC6mlwRA09TySZ//
 rOoB19726TtN9xYgBGpTnuAtjifZqxz/FICOoqTNOftWvdyQmVxehZhOOIqVCNJ8SXzJ8l6U
 4KSchD4bPLY2SS9fyKhTWFLw==
X-IronPort-AV: E=Sophos;i="5.95,199,1661832000"; 
   d="scan'208";a="83171108"
From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= <edvin.torok@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= <edvin.torok@citrix.com>, "Christian
 Lindig" <christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH for-4.17] tools/ocaml/xenstored: fix live update exception
Date: Thu, 20 Oct 2022 17:54:55 +0100
Message-ID: <12d90632bf881e96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

During live update we will load the /tool/xenstored path from the previous binary,
and then try to mkdir /tool again which will fail with EEXIST.
Check for existence of the path before creating it.

The write call to /tool/xenstored should not need any changes
(and we do want to overwrite any previous path, in case it changed).

Prior to 7110192b1df6 live update would work only if the binary path was
specified, and with 7110192b1df6 and this live update also works when
no binary path is specified in `xenstore-control live-update`.

Fixes: 7110192b1df6 ("tools/oxenstored: Fix Oxenstored Live Update")
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
---
 tools/ocaml/xenstored/xenstored.ml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml
index fc90fcdeb5..3299fe73f7 100644
--- a/tools/ocaml/xenstored/xenstored.ml
+++ b/tools/ocaml/xenstored/xenstored.ml
@@ -353,7 +353,9 @@ let _ =
 	) in
 
 	(* required for xenstore-control to detect availability of live-update *)
-	Store.mkdir store Perms.Connection.full_rights (Store.Path.of_string "/tool");
+	let tool_path = Store.Path.of_string "/tool" in
+	if not (Store.path_exists store tool_path) then
+					Store.mkdir store Perms.Connection.full_rights tool_path;
 	Store.write store Perms.Connection.full_rights
 		(Store.Path.of_string "/tool/xenstored") Sys.executable_name;
 

base-commit: 0c06760be3dc3f286015e18c4b1d1694e55da026
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 16:57:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 16:57:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426985.675775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olYrE-0005FF-Rt; Thu, 20 Oct 2022 16:57:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426985.675775; Thu, 20 Oct 2022 16:57:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olYrE-0005F8-Nv; Thu, 20 Oct 2022 16:57:24 +0000
Received: by outflank-mailman (input) for mailman id 426985;
 Thu, 20 Oct 2022 16:57:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LaG4=2V=citrix.com=prvs=285635b8e=edvin.torok@srs-se1.protection.inumbo.net>)
 id 1olYrD-0005F0-M1
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 16:57:23 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4291da93-5098-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 18:57:22 +0200 (CEST)
Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 20 Oct 2022 12:56:59 -0400
Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7)
 by CH0PR03MB6035.namprd03.prod.outlook.com (2603:10b6:610:be::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct
 2022 16:56:56 +0000
Received: from SJ0PR03MB5888.namprd03.prod.outlook.com
 ([fe80::a093:1d6d:9e9:cbfa]) by SJ0PR03MB5888.namprd03.prod.outlook.com
 ([fe80::a093:1d6d:9e9:cbfa%6]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022
 16:56:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4291da93-5098-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666285042;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=cZWiROM90RIokUEreenDFtAZPE2RBHOtcPzGlVzg2DU=;
  b=WOG7KytBJM9mAZLaAiZ8fcVADtG6IauqT+zWkDUAZG0X85YkeOP/+4gJ
   0MFnb/F+wdbExjL3Z2t6oGhatu2qi9Lb4S+J097aj7VJDnH2yNrZxmQr3
   RxWSu0MWIggsgjlJAAG8QvQHG/F0b2DvjH9+8ITEslmeIWSLMAqxXikwX
   I=;
X-IronPort-RemoteIP: 104.47.66.42
X-IronPort-MID: 82806898
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:lzwjVq/MUbu5BOztM1EVDrUDo3+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 2IbD2uGbKqJZDH3fohwYN/jp08F756BndYyHAA4pCk8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5ARmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0r4pAG5e8
 94DEh4IPgmppNjr2rPqR8A506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzK7IA9ZidABNPLYdsKLQ4NJmVyfp
 UrN/njjAwFcP9uaodaA2iL21reRzXKrMG4UPJSj6ttnoGOr/W0OIRYPdlqcn8afj0HrDrqzL
 GRRoELCt5Ma1EGtVMi7YBS+r1aNpBtaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy
 hmOhdyBLTBmrrC9U3+W8baQ6zSoNkAowXQqYCYFSU4A/IPlqYRq1BbXFI4/Suiyk8H/Hiz2z
 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsAGzASpoRGpBcmS8g
 Q==
IronPort-HdrOrdr: A9a23:j4WDIasb0Bi8BOB9Kyg9e9U87skC1YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ
 uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf
 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq
 iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq
 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp
 +ISeBrP8M=
X-IronPort-AV: E=Sophos;i="5.95,199,1661832000"; 
   d="scan'208";a="82806898"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bSl/dYKBc09/KV/nSH0dlEVIGty5MteY+86NC10Z936UopbYOzFB/P1UmqHhpWJpY419yVhh1QZ4nIeU/AEJD7ijJwXZr5i0Gxk0YDggjIK1FAAjxVCAsUNfybrtWX/a44MXtDmUCzzTKt5kcC3H4KfT+ONSobJWR2KzSPXtl/tU7pC6URvcDiwQ4Dwpl/DpwwvGpDU/Y/AoNFkRnOzzht1UEu7iH0099ZCkO02DbN9cCZJdNj6xq158slW/VmaP4UWI2MhP/E4zeSBGkZY4tu5rAxq/mEMCVxMOzp2nCsrCcxwGuOOyVdc7s6hGmElYHwLhXGkTrQGUebzNaAnNUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VFK7ujOBaZ8kb7KrzY1TRCkXR6h3FeT3MJVabsJSrAI=;
 b=OxE9o3zzK4cM4aKsv333ryE8QBgVVl+0PLydYkXcQqt20a8B8s1A5Afuap464ftX647E5cllrPlEGU3+MwK/zNJM+QQQi3Ot8S71pYv/OHipYg0ihdVyjw1ACo/+3+kc5aQWcpGL/X/4iYuHQ2Lnu5KeT1XUv5MXdSuJwSgG1OpxiKg5aLTlMAB5vtL6qApDGqpELKN+syCPlX3pTpyIHuZda2YZJ1sbP9ggvyIetK00NClVKW4h2XkYJuLrN9UmtuMLbsPMfoKngqKl9NFvy2JE59XssLtUkcg9CTDzv0lNw0Vy3T4xYGLj2FQrRUpVqwchokrXRetMI/OqcdKzzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VFK7ujOBaZ8kb7KrzY1TRCkXR6h3FeT3MJVabsJSrAI=;
 b=nkMUKa8uM2vCSTxlTA5LYjxHlGMdfQZ4AGkYMZX+wT8+DZe8exvf++xMtp/sXYGc7Tq6R91R2OUmCm2ZgQZL1QzC+d9CMt7wCyVr+vayJ820uyPPoAPGFpjq4/DdBBqd5FyAovbQiWPk4IWVtrH8ZGNSW+qg+wnVaWbQvaWymoQ=
From: Edwin Torok <edvin.torok@citrix.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>, Rob Hoes
	<Rob.Hoes@citrix.com>
Subject: Re: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Topic: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Index: AQHY5HiAz+6eZQJ7aky5mf6JNm1Bia4XOrgAgABGQAA=
Date: Thu, 20 Oct 2022 16:56:55 +0000
Message-ID: <F65C8E58-EF3D-47D9-A94E-7B70EB93E068@citrix.com>
References: <20221020113810.20844-1-andrew.cooper3@citrix.com>
 <AS8PR08MB79914FC06AE997ABF32780E4922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
In-Reply-To:
 <AS8PR08MB79914FC06AE997ABF32780E4922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|CH0PR03MB6035:EE_
x-ms-office365-filtering-correlation-id: 5241637e-a58c-4e66-1381-08dab2bc1869
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 uthxvL50ElVbY5p26ztfhp9hVoeNs3dPWJFTzqUviHYxeVowApsjGDoQnpiGXYI+uhukMJ5Pi7ZeAZmqDZpPsdaJtFCMyWEe6698toAdGfVSdd/e++A/bDwx7sq/z8ce2osxzS/FsuQfaYv7lwrK5ST4GqhuBJqrCinzIYnjpx6TUdZLulPCezCXpZIh74m9Lf7IG8CYhAo93hnJUaUTkLbhImoqb3v911VCgOtb4MCUbyuhYOMWr6drChfglE497gfjdp0/blgZGHTa/S4ffcgekZOp+5iUypU9iWSrZI/NwTI5Re2KsR9B1qaV7NKa23R/xutinE0lhvHoV9fgPYykDyHnpz/8SX9+vrbBXaEkztsKsYhbZ7adMauFik7Q+H+B49iU3dkB4fMb8KeDSTy48jbJO1xN14se4KrWo68hlrWgjx1kISJkkI+I9LZVH+jiKj1v+JD2NbE7AeP3WOlDUlQEl7A5pCH8lfL4uV/mCMe9GYi3r3ouWHE4LNsKyY1p6mnK0B37VK4K7WJGmccVCp8sySNS0wL5SIjhopGFPdxKHfjZyoDvdTL5HVm0WoZqtT3RcrgmdBTzLwFNVzb2pyUh2sCDsOs30WedUgMAKBWKoQK4B6zR8wgbRi9w7BYBlHqR3zOmYkZWk9UhgicJyqPjl5Lb7eTnevmLigjhUVtGptCMnddUID/12xvg5UNsFo6n9WHYfSzkzZBEFeAAgd9H51nm9NBYaazUArvuGBJmoa435guVUDgjASPTW7r6mKPpo3INBjpcHftOjacD4c7+7y9XhEzuFiaRdiCc4QJnlJzrVRCF0hZgiAEdY9zNvBcha5CBEN3R0tdHP/QHOokjRK+UxrTrQQBs7lI=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(451199015)(86362001)(83380400001)(2616005)(15650500001)(2906002)(6512007)(53546011)(26005)(107886003)(6506007)(186003)(316002)(33656002)(41300700001)(5660300002)(478600001)(4326008)(6916009)(8936002)(36756003)(45080400002)(76116006)(8676002)(54906003)(82960400001)(66946007)(66446008)(64756008)(66476007)(66556008)(966005)(71200400001)(6486002)(38070700005)(38100700002)(122000001)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?I/HufJ0dPA1s4wJHjPzfsm3CemVbbbhYswS/lY3W7ty7Je9o7oiE462YH4hJ?=
 =?us-ascii?Q?yhTYXox9Ib/woPN5959ofuT30DXG9UK44lfasdqR3OZzXH/ChQy/4g+TkBrN?=
 =?us-ascii?Q?KduTtO/4zcxI5G5LQuWtf/xIJhixpFQ9LpGS0NYfF3Gmtxf9cAO9Va8O6biY?=
 =?us-ascii?Q?3SLhQ3mm6/By3Rh50aKWjjX6RHWstZ3kvRf2MkVtaLUCDve77cgPLVQLtM/5?=
 =?us-ascii?Q?hpHmFGc4SsGE2QAukRFcd1l/cSVn7cTRd17BuCsrMNGUMz8A6CtQndIN2GeG?=
 =?us-ascii?Q?1oe51TI+IvUZt65ZmO3vi4wfe3wQkrl2IL1v0/c7RKB24F9T92/0GBuB3Kck?=
 =?us-ascii?Q?jiFM/nfR3xWCqSmJeqdjkmlnsTvwFFZ1FViXoyi+ZDITgyOUxWOqmOb+MfDr?=
 =?us-ascii?Q?CtYCt6qx4DDZgd0VvDyE7cGttOobKCfWJpm8uasoAHAwt8YSYcGdwvFmAIzb?=
 =?us-ascii?Q?88pRC7dviN5SPZJyfdeO5ya4MaRGR3e9x6iOS4TViJovyuzkXjN5Z4dX433v?=
 =?us-ascii?Q?W9V0eUOhC0kJ6yFe+4h1+qLU8mRWVfocka98GDXCJXyICCW/7lPaeEpy+zdG?=
 =?us-ascii?Q?z5UasT8h6yK6W1Goqtry0VBfKgzb7ulG6N9Sg+PtDCv7a/PG4m7pPYL1zfDn?=
 =?us-ascii?Q?soU+zJQ3N4PGqL5pdn5R+XNSOLQRyTgKcRWX4KjujteQc2HSdw9ymBz1lKaX?=
 =?us-ascii?Q?lxtk56nwl+17Av9RJDfMMzfiwrF2Nb6rkjXa7hOuj+CQuv2NkY2USK1w/5Uq?=
 =?us-ascii?Q?jVH40kAAsyaLkck1R6z/I8LJ1jrAE+wvUKNuI8AFK/3qoTcLNmlARzT9hq7O?=
 =?us-ascii?Q?svrHiDb8C0wOMnPZ9dOmQ+hp/fAm2BUbvEsT0q/h88b5B/vPp2BSoIq1Vc29?=
 =?us-ascii?Q?oFYdAJfqrqkxYuKZruT/4otx4MV2aFXkSQWJFHGBmSiVi1ZzS23D/DUkibYW?=
 =?us-ascii?Q?Q0e8CIWEC8vkprILLb09Tax+STknzEYjfZf195YTf04WkLQ4BSSiAEr8DGlQ?=
 =?us-ascii?Q?SnmtDxcRVhePpgZqGxXJ8zlF2VGSLjSmi56qD347Vwr3c83yxPK4Kp5OgBSh?=
 =?us-ascii?Q?gpw8b2xOiS+TN/MtWovN7WV8TtUp2fVcPO1ih0JssrxMbxIMff/V1j0FsmCu?=
 =?us-ascii?Q?7nrTDMFsYcl8Rn9L+/TV0QFKEGIrHAB1MUUhEjOv9cQ2gdt5Ojq/x2U1//uI?=
 =?us-ascii?Q?QvHBMvnpk7MuMtaZZ9ut1xzMbcCTAxJXrEp78X7fVjr7kz2YN++lcai0JjJb?=
 =?us-ascii?Q?2yPwuf5v+fU0p3PeTLrsA8FENS0FlxQCUP1N3qiARv8ZVd0QNkXpOI8/0c8P?=
 =?us-ascii?Q?MvpvYgEaUE18nUTm2dGJyjLDt9j+vGBgP+T1lyX2jGVUIOKXIdkNEC/gqQki?=
 =?us-ascii?Q?lTE2nKk21suFFFKRuXqnmjLPPTVvP7hKaGtAdr5XQJyAWg2a2TPy5gaImyWK?=
 =?us-ascii?Q?XGNSvFDMkUirIogCZ48n5XDeclf5saP+0snElplT+YcndYrENqeYnOhZxDqr?=
 =?us-ascii?Q?/9GTwqPRuce6HFQpSbjX83T3NHLDjbjplPohqCvVCHkK/6Tn5roUghEW0cHv?=
 =?us-ascii?Q?D5N+x9BgzYfTVtI97drXgJmzylA0DXlgjhouZII16p0Xtuc7QjVOo0oC+haA?=
 =?us-ascii?Q?4w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <07EFAB1E0470094199C9659CA0266E62@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5241637e-a58c-4e66-1381-08dab2bc1869
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 16:56:55.9013
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fhj7KILHLUmR3zzlrAVJhmbmzCChbw5HURIPjdWAsIEx8tUqEOITlLIc28XyxivnyklNFNmoHQrSPwXUWvspTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6035



> On 20 Oct 2022, at 13:45, Henry Wang <Henry.Wang@arm.com> wrote:
>=20
> Hi Andrew,
>=20
>> -----Original Message-----
>> From: Andrew Cooper <andrew.cooper3@citrix.com>
>> Subject: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
>>=20
>> tl;dr This hunk was part of the patch emailed to xen-devel, but was miss=
ing
>> from what ultimately got committed.
>>=20
>> https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore=
.kernel.org%2Fxen-&amp;data=3D05%7C01%7Cedvin.torok%40citrix.com%7Cfd3a03c9=
87ce448875f808dab29903ee%7C335836de42ef43a2b145348c2ee9ca5b%7C0%7C0%7C63801=
8667544851864%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL=
CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3D8AnK0Bhh9D%2B0KR7=
5I0zeqwB8GB10JLjUtqkwTtprans%3D&amp;reserved=3D0
>> devel/4164cb728313c3b9fc38cf5e9ecb790ac93a9600.1610748224.git.edvin.t
>> orok@citrix.com/
>> is the patch in question, but was part of a series that had threading is=
sues.
>> I have a vague recollection that I sourced the commits from a local bran=
ch,
>> which clearly wasn't as up-to-date as I had thought.
>>=20
>> Either way, it's my fault/mistake, and this hunk should have been part o=
f
>> what
>> got comitted.
>>=20
>> Fixes: 00c48f57ab36 ("tools/oxenstored: Start live update process")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Christian Lindig <christian.lindig@citrix.com>
>> CC: David Scott <dave@recoil.org>
>> CC: Edwin Torok <edvin.torok@citrix.com>
>> CC: Rob Hoes <Rob.Hoes@citrix.com>
>> CC: Henry Wang <Henry.Wang@arm.com>
>>=20
>> Found while reviewing the XenServer patchqueue.  This is low risk for 4.=
17
>> and
>> fixes a feature which we thought had been working since 4.15.
>=20
> The commit message and above scissors line have described the situation
> quite clear, so I don't think there is any reason to ignore this patch.
>=20
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks.
Further testing has revealed another bug, patch here:
 https://lore.kernel.org/xen-devel/12d90632bf881e96e0b6c256df193f00df187dc1=
.1666284745.git.edvin.torok@citrix.com/T/#u

For convenience the commit is also available from git:
 https://github.com/edwintorok/xen/commit/12d90632bf881e96e0b6c256df193f00d=
f187dc1

With both of these patches a smoketest 'xenstore-control live-update' with =
a stopped toolstack works now.

Best regards,
--Edwin

>=20
> Kind regards,
> Henry
>=20
>=20
>> ---
>> tools/ocaml/xenstored/xenstored.ml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>=20
>> diff --git a/tools/ocaml/xenstored/xenstored.ml
>> b/tools/ocaml/xenstored/xenstored.ml
>> index d44ae673c42a..fc90fcdeb5d6 100644
>> --- a/tools/ocaml/xenstored/xenstored.ml
>> +++ b/tools/ocaml/xenstored/xenstored.ml
>> @@ -352,6 +352,11 @@ let _ =3D
>> 		rw_sock
>> 	) in
>>=20
>> +	(* required for xenstore-control to detect availability of live-update=
 *)
>> +	Store.mkdir store Perms.Connection.full_rights (Store.Path.of_string
>> "/tool");
>> +	Store.write store Perms.Connection.full_rights
>> +		(Store.Path.of_string "/tool/xenstored")
>> Sys.executable_name;
>> +
>> 	Sys.set_signal Sys.sighup (Sys.Signal_handle sighup_handler);
>> 	Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ ->
>> 		info "Received SIGTERM";
>> --
>> 2.11.0
>=20



From xen-devel-bounces@lists.xenproject.org Thu Oct 20 17:48:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 17:48:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.426994.675792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olZep-0002ED-Om; Thu, 20 Oct 2022 17:48:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 426994.675792; Thu, 20 Oct 2022 17:48:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olZep-0002E6-Lx; Thu, 20 Oct 2022 17:48:39 +0000
Received: by outflank-mailman (input) for mailman id 426994;
 Thu, 20 Oct 2022 17:48:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olZeo-0002Dw-8m; Thu, 20 Oct 2022 17:48:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olZeo-0005do-6L; Thu, 20 Oct 2022 17:48:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olZen-0004PM-S6; Thu, 20 Oct 2022 17:48:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olZen-0003F5-Rf; Thu, 20 Oct 2022 17:48:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=o4c1Uz5om2CEl/E8/sXHTlzkRJ69g0wWc47Bf9wNcdI=; b=ofsvLC09lVlSBhn82nTe6zMkJP
	8sBy4bT8yjsrwj81gI/i4PVXPZSo2lxqd/g0ouGHKAdV6FGHDxGpHKZg5S15stSAXDwO/O+I4jjQF
	FWYGquwxvkMlqtjH7NHPRV3vRC5Z4Q+n317+qLViZ+Wgi1ct9axnrwUXJTQzw/I8wlm4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174139-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174139: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=7110192b1df697be84a50f741651d4c3cb129504
X-Osstest-Versions-That:
    xen=c7cff1188802646eaa38e918e5738da0e84949be
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 17:48:37 +0000

flight 174139 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174139/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  7110192b1df697be84a50f741651d4c3cb129504
baseline version:
 xen                  c7cff1188802646eaa38e918e5738da0e84949be

Last test of basis   174131  2022-10-20 11:00:26 Z    0 days
Testing same since   174139  2022-10-20 15:00:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c7cff11888..7110192b1d  7110192b1df697be84a50f741651d4c3cb129504 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:02:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:02:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427002.675803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olZrt-0004f4-Vf; Thu, 20 Oct 2022 18:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427002.675803; Thu, 20 Oct 2022 18:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olZrt-0004ex-Sg; Thu, 20 Oct 2022 18:02:09 +0000
Received: by outflank-mailman (input) for mailman id 427002;
 Thu, 20 Oct 2022 18:02:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pcz+=2V=epam.com=prvs=22920ca83a=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1olZrs-0004er-1y
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:02:08 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4dea0488-50a1-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 20:02:05 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29KGgjw2012480;
 Thu, 20 Oct 2022 18:01:52 GMT
Received: from eur03-dba-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2168.outbound.protection.outlook.com [104.47.51.168])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3kajdtnku0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 20 Oct 2022 18:01:52 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AM9PR03MB7331.eurprd03.prod.outlook.com (2603:10a6:20b:264::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Thu, 20 Oct
 2022 18:01:49 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 18:01:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4dea0488-50a1-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W8EPx+mpItCEeMMOAgHToN9XtSh0mmIFHQV7EZTvRyvfM99XSO8EiBGGRP4Jc6Q9jszhLo60meb+qXcaxDTnL4wcz6msF8Ze8Zec7AA2Lzw80fY2PEA420FiO9ZolLIAx0BWi83dqtEmuk7aEhffxSa+TJQGLigrLEYEFsxhGcO1QyGtSBRIqBbDloX5rsfc79hDTJ+g8l9X3ReBtmJCMPdr2CgSSZ+plrryBmWtBbPX19ypydBR9zZqlGCedAy3Yc2Ehx1YhnBd6XzuDPyJm33LBa6215YtTB8d8YmwsBg+zkf+/0rGwg+szISGxwvqPnJQjnAHsru5IzTOwCNxjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jg+dZokOvxuvqM1+/aceV1T/4Qmbs95uoeaHwHUHZ8A=;
 b=HvOZZU5Bi94z4n4/KqNxmrjOXm94bgLsXwC3kcO6oyXbA7+2DmrtQ9JS87jINE5m847QN7AQE8mL+YrE2NkuXzzhWMnJDWLInvniBzXEZijQVZFEq3UfIXdSLAdswlUe80+sJKnU6VDSm79wNgBp7NWfINznMGzjbQGqvxZGXwV0NsVbzJ+rHIcsmYP6i7bHrqaaeP9qR153fZ04qP+Jl8KL1XigGMTzOB1/Y5UTBO4CP6ofZ/tDOPW3ZHiOXRwesJqng/3h/tItQKiHAu7blUAnGcj/hX82ltNiVwXZ8fxrPGC/iSaGEdxaEN8bIolItyEoSH7ckyLJYJSxpCacWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jg+dZokOvxuvqM1+/aceV1T/4Qmbs95uoeaHwHUHZ8A=;
 b=ZGGjzhpPIrQ2oqaHfgQF90zuhwY3juFB+w0tx+gmuxaHRjt9QjSqe4eOe5EOM0HlanMNZZs0A6gBK8CxotskMfcZ2J2BfUhGsGw8tzhh/fUBkfuzmQ7kpWsy0q4Eks9ZnaLntQ8lNAIwnyLcRm0sbD5NwaY9lePwQ7vvdDX8KzfKP7nvd51u7K6COm67jjewAL/L35Y/ETs84lNNe3rjDXQONvtUdvZ59RhwJllEcIJdos6w3Xw74Q1Bhz8y2YSU6hp0FU3+65KgRA6H4UIz/gWteouNtvDYz6vCGOOaAgUqcdS5Pcn++OQ7BE+BeFTexxKYf0fg4xeoNcpBt1U1zw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        "vikram.garhwal@amd.com" <vikram.garhwal@amd.com>
Subject: Re: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Topic: [PATCH] xen/virtio: Handle PCI devices which Host controller is
 described in DT
Thread-Index: 
 AQHY2avbTqg8YKTBpUCScd7xSfM5Yq4CIOiAgAkdnYCAAET3gIAEI/OAgAN2W4CAAq38gIAAdmSAgAFmi4A=
Date: Thu, 20 Oct 2022 18:01:49 +0000
Message-ID: <03bad045-8b2c-6b79-440d-373a1b341946@epam.com>
References: <20221006174804.2003029-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210061747590.3690179@ubuntu-linux-20-04-desktop>
 <f98f9f44-20e9-af8d-8970-9f6241c8dc44@epam.com>
 <alpine.DEB.2.22.394.2210121733240.3690179@ubuntu-linux-20-04-desktop>
 <16485bc9-0e2a-788a-93b8-453cc9ef0d3c@epam.com>
 <alpine.DEB.2.22.394.2210171323450.2351079@ubuntu-linux-20-04-desktop>
 <af073c71-df43-4a5c-c67a-a9858678f588@epam.com>
 <alpine.DEB.2.22.394.2210191314410.3873@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210191314410.3873@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AM9PR03MB7331:EE_
x-ms-office365-filtering-correlation-id: a49e8299-1c22-4040-5087-08dab2c52934
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 GCTs1VLx4WCqiDYUckmrScGAyh1vinzM7l2oOWTx5KU602jxsI5CJbxuhLcXJaIT81ODiQjdcgWvrbg38eYI9MhhV8F9hcXtyRMkFZ3vHdM7THv+0IM1pCDLllfoPyG43PataskZhgCiDu+wYifTsqzqsljrMW6uhHVwA/WDg8RsmfQ+/F/I5Pzyu7M4aA0Q3kayY2h0Tr+ZfSOqLCe19RQT7ZWnfZYaD+7GwxEv/DU8vRBzJqJcUuhhJfXhWNeorLeHOqAs0taclt+8dTO5fPktVLP48twACq2SJteP5B+WJFYdTgPV2q5jcxpCqeSn+ima4zN19Tn8xLxyFFsaqMbN5aOL8pyQhgajp9QiT4Xn85dx4JV3jGqAfVjdgFwFDTDrbiAoz5H6Vz8pGHC0dmUtJVFHrLTQtj9msDrsJpnkJg789auLmp87ccej3JdPuyNosf7kQEvGb9AN8gZHS0kfBC4vq+uIDdUfOT33RYMqhEn8K00KMMkQkbRdajVb70s0TXNtS5W/EvakadmSn+Re/Sez2Yr6omEnbKpRYbTboaNhVRG5+yTk2ifc8+IDoIbv0NqZ93/KCrqw+DpCTX6dGd/j5KtUTv1TrzAbVseB4lDVcIcy7ddcUP1PxIgTwE6U0BTRzpSz8J8fW4Dvk6P7wjACDIbwBtcs+YqS0FTiMcLWURZxadTgVUa4PZcCYAkvFulhDJDNsnAQ8x2p+zQe8VqHEDvS6lBIrRNVsphhfiyqCG0HXxXkonpUXzsE5lenWvRWEFV9wHApu5dTBWAik+CCIYs+/pyHBJo3cDPE0/ZEwMKKRLPED2h/EkUck4N00mHd8kvxsWx4Fn5DF+TzX7EZW2xAe8FZo2/I0NE=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199015)(83380400001)(38070700005)(186003)(86362001)(31696002)(2616005)(38100700002)(2906002)(122000001)(30864003)(55236004)(41300700001)(5660300002)(8936002)(478600001)(6512007)(54906003)(966005)(6486002)(91956017)(26005)(71200400001)(6506007)(4326008)(8676002)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(6916009)(316002)(31686004)(53546011)(36756003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?c3dYeTJSMUF6b2RIYzdKRlc4bDdzNUl5djhqTVNTSDgxb2d6QWp4WWhTK0Zj?=
 =?utf-8?B?ZXltMWhFdjMzcy9Dc2RlTjczNnlFR2pmWXlHNHI4UGFxTm4vMzJuUlVDVGkw?=
 =?utf-8?B?SmJ0a3FIczhTQTg3UW5rVE9IU0I2M3EzeHNOcnpZLzFkbk4rakw0MmMxRGVm?=
 =?utf-8?B?czF6SVFTY21COVhScVE5UUVhZVFGQzlrRDRudDdkZ3R1R2g3OVBxNnRvc3hP?=
 =?utf-8?B?MklwNHdyZWhGTkhSQ1dLT1Flbk5mZVRBb0lyeDRXbkduRWplSHFNQUZTZjhU?=
 =?utf-8?B?dnJWZ24vSXVKWW5aL1kxYngrL2poVCt2dWdJb080MzBNOWpzNlZWSWh2NWtF?=
 =?utf-8?B?bmhpOWp3L0RMMTdKT2NlUXliVW93d3hmdk52cjVTT0d2enA1eHAzSm0zNk1U?=
 =?utf-8?B?cjBLL0ZPbEI5TEphM0Vacy9aYy9PN3V2Yk05dUtnUzNTU0FzbE5FVDRkZGls?=
 =?utf-8?B?VWJKOWY3Z2wzbTR4TGJtKzN3QXd5WGJaWmVubG1nRVNFYU9DRjdZMzA3TURo?=
 =?utf-8?B?VEoxTFY2SHhxNUk3Ty80UkY4bUFsaFA5RG5iREZWUU9jSWZGNlBscHhISVVF?=
 =?utf-8?B?SjQzMTQxaVI2U3ZTTmk3NEQ5ZXI0eFVaaWhtaFExQTBZQkhQcDlSRmhRV2p5?=
 =?utf-8?B?N3hDVWppNkdLMnhrWmdyUkh0OThzak1XaEZFTGh2cWdzaUEwSmNmYmhYQVJt?=
 =?utf-8?B?QmhkVlNOMVZKUmNWWmhJemFXMVd2d01xdEEybUJzZENEbXprcDdXNEhRQnZa?=
 =?utf-8?B?ajBmWHFsMC9FTXVDNWhaRE9vSkQ5QTA3bzBSa0MzZ1p3ZmFOalF3K3hxaFBK?=
 =?utf-8?B?dnBWdmtMOERhTytoSjEwWVZya3prd1dpSDBkVmdyYVJOWEFXcHFxQTRJL21n?=
 =?utf-8?B?cVBGdHgxVlNGYW5tRVpBOXpQWnRvcUgyM1RIM3NYcUE2aWticlRtSGlyb0NC?=
 =?utf-8?B?MHdySlB0Z0JTVTZscUhabkdqL3NUY1djZnBOZFpIV0VraWlOdlk5SEVwdGo1?=
 =?utf-8?B?aG9VR2dOdUZ1N1RrV3E0YUxDWG1FVkpuM3Q5L3ZWY3BNWUI3eG1xVDJ3NEE2?=
 =?utf-8?B?ek1LQjc1QVUyVUtlTlZIRWVUTVlzNmozSGRJNlZUWXhBTzVhTEp6UXFNY1M1?=
 =?utf-8?B?N0I5bGY5RHp0SmliZW1VYmFuVTdtbFV4TDJkZGJucHFNcDZydkpwM3dvK09z?=
 =?utf-8?B?UGpVbzU1M1BIMEtodHgxOXNBNW9RcEZPS2ZQZHRFU2lDVGwvWmM2bGwrZXI3?=
 =?utf-8?B?cXc1S0dxTWhWNUQvZnBydWZnVmFrVU1lRlM2ZHpoUmRZWUhkV2hYT21maDRU?=
 =?utf-8?B?ZEFudW52VTF2L09XdFpja3pibVpBT0syOUk4eVJ6eDNEUGk1Z1hDTUZCRTZE?=
 =?utf-8?B?aDdrYSt6QWsxcnRyVkpIZ09HVjVjbzRpN1laaldoa3NTMmNVa2ZNalBDMXpE?=
 =?utf-8?B?WXhnSmtRQURyR3FkbGRmaHpPSzRCOGhCOFQyZTMya0tkYzRhbmJHOHJ1YzU0?=
 =?utf-8?B?N3hqOHk0eTlmWXFidWVkR21Lb1h2VmgrNWxNMkxDQ1FGbEs3UWlnSklIRjI3?=
 =?utf-8?B?ZnIvVEhBNkxVSGlYK0xHQVNoaG11ZVFGcDMraGFXNHFRMkkwdmoyQmZ2dkJE?=
 =?utf-8?B?V3h6ZHBQZlp6elllY0g2OVFDU1MvNUJNUGRpcmNFQU03cGVISDRPTW5Va3lE?=
 =?utf-8?B?YmhHTExZZXVXaFM5WlBjeUpxL0dHT3FhalRjbHdzMk1uV1R5WXZtZ2cxbWdx?=
 =?utf-8?B?QnJNTDNLNGVPVUFjRFJsajduKzFqLzY4RmRzd05qS0orWXRiTnlkb1VVNE9H?=
 =?utf-8?B?OHNzZGYxMms1OGc4aGJtMkx5c3RsbW1JRVZCUjVpMUhYUko3QXp1NzUySHBp?=
 =?utf-8?B?THRXelZLQjRCRStlUWhQZjdld3cxV1RCcUprRWprQnlHSTBLa3pFZ1I2TitF?=
 =?utf-8?B?aGtVTlJudTF0bUV4U2Z1QjJvMXZ3WEVZME5EWjdybjQySlJBUWpHOTJRNCtZ?=
 =?utf-8?B?bEpuc3ZUa1VKTnd5TDUrLzZLUXl0aDdwZ3ExUHN0RnprazdrTnZ2a1M2eXBl?=
 =?utf-8?B?OC81ZjBBKzlRRWFUdVF5bDViYWYveTEvalJ6akczNytqZUl4eUpoZkhBS2pz?=
 =?utf-8?B?eGc5K0xxTXd3ZTRnODg3N2h1MW9ScExwTG00cFJLNlJQQ3ZjZEpKK0pOVGdM?=
 =?utf-8?Q?lGj09aRpXAtEAzSMmEktCxg=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <51754E2BDCE6914689CE36E817CC9E86@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a49e8299-1c22-4040-5087-08dab2c52934
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 18:01:49.5629
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2C9X3YztCTdMcwopSWpBujjdk9Z12xcGtUKTu3yuQNYugu1ZVq7b+9orQNdGXLSN7rMBW5a9uehHZG8/l2gpGHTdLqm5c/F1ljYyI5oHbV4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7331
X-Proofpoint-GUID: _RRUg_YUts09lBk49RvTCYSVZWSG11XZ
X-Proofpoint-ORIG-GUID: _RRUg_YUts09lBk49RvTCYSVZWSG11XZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_09,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 priorityscore=1501 mlxlogscore=999 impostorscore=0 mlxscore=0
 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 phishscore=0
 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210200108

DQpPbiAxOS4xMC4yMiAyMzozOCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gKyBWaWtyYW0NCj4NCj4gT24gV2VkLCAxOSBPY3QgMjAyMiwgT2xla3NhbmRy
IFR5c2hjaGVua28gd3JvdGU6DQo+Pj4+IFJlZ2FyZGluZyB0aGUgdmlydGlvLW1taW8gKHBsYXRm
b3JtKSBkZXZpY2VzLCB5ZXMsIHdlIGNvdWxkIGV4cG9zZSB0aGVtDQo+Pj4+IHdpdGggc3RhdHVz
ICJkaXNhYmxlZCIsIGFuZCB0aGV5IHdvbid0IGdldCBwcm9iZWQgYnkgZGVmYXVsdC4NCj4+Pj4g
VG8gYmUgaG9uZXN0LCBJIGhhdmUgZXhwZXJpbWVudGVkIHdpdGggdGhhdCwgd2hlbiBJIHdhcyB0
aGlua2luZyBvZg0KPj4+PiBwb3NzaWJsZSBob3RwbHVnIGZvciB2aXJ0aW8tbW1pbyBkZXZpY2Vz
IChJIGtub3csIHRoaXMgc291bmRzIHVuY29tbW9uDQo+Pj4+IGFuZCBzdHJhbmdlKS4NCj4+Pj4g
SSB1c2VkIExpbnV4IGZlYXR1cmUgKENPTkZJR19PRl9EWU5BTUlDLCBvdmVybGF5cykgdG8gdXBk
YXRlIHRoZQ0KPj4+PiBkZXZpY2UtdHJlZSBvbiBydW5uaW5nIGd1ZXN0LCBzbyB0aGUgdG9vbHN0
YWNrIGluaXRpYWxseSBpbnNlcnRzDQo+Pj4+IHZpcnRpby1tbWlvIGRldmljZSBub2RlcyBmb3Ig
bm9uLWJvb3QgZGV2aWNlcw0KPj4+PiB3aXRoIHN0YXR1cyAiZGlzYWJsZWQiLCBhbmQgYXQgdGhl
IHJ1bnRpbWUsIG9uY2Ugd2UgcmVjZWl2ZSBhbiBldmVudCBmb3INCj4+Pj4gZXhhbXBsZSwgd2Ug
Y2hhbmdlIHRoZSBzdGF0dXMgdG8gIm9rIiBhbmQgdGhlIGNvcnJlc3BvbmRpbmcgdmlydGlvLW1t
aW8NCj4+Pj4gZGV2aWNlIGdldHMgcHJvYmVkLg0KPj4+PiBCdXQgYWdhaW4sIGl0IGlzIG5vdCBh
IDEwMCUgaG90cGx1ZywgYXMgd2UgbmVlZCB0byBwcmUtYWxsb2NhdGUgbWVtb3J5DQo+Pj4+IHJh
bmdlIGFuZCBpbnRlcnJ1cHQgaW4gYWR2YW5jZSAod2hlbiBnZW5lcmF0aW5nIGd1ZXN0IGRldmlj
ZSB0cmVlKS4NCj4+PiBBY3R1YWxseSB0aGlzIGlzIHJlYWxseSBjb29sISBEb2VzIGl0IHdvcms/
IEl0IGRvZXNuJ3QgbWF0dGVyIHRvIG1lIGlmDQo+Pj4gdGhlIHZpcnRpbyBkZXZpY2VzIGFyZSBw
Y2kgb3IgbW1pbyBhcyBsb25nIGFzIHdlIGNhbiBzb2x2ZSB0aGUgIndhaXQiDQo+Pj4gcHJvYmxl
bS4gU28gdGhpcyBjb3VsZCBiZSBhIGdvb2Qgc29sdXRpb24uDQo+Pg0KPj4gLi4uIHllcywgaXQg
ZG9lcy4gSW5pdGlhbGx5IEkgZXhwZXJpbWVudGVkIHdpdGggdmlydGlvLW1taW8gZGV2aWNlcywg
YnV0DQo+PiB0b2RheSBJIHRyaWVkIHdpdGggUENJIGhvc3QgYnJpZGdlIGFzIHdlbGwuDQo+PiBJ
IHdvbid0IGRlc2NyaWJlIHRoZSBjb21tYW5kcyB3aGljaCBJIHVzZWQgdG8gYXBwbHkvcmVtb3Zl
IGRldmljZS10cmVlDQo+PiBvdmVybGF5cyBmcm9tIHRoZSB1c2Vyc3BhY2UgYXMgd2VsbCBhcyB0
aGUgY29udGV4dCBvZg0KPj4gZHRzbyBmaWxlcyBJIGNyZWF0ZWQsIEkgd2lsbCBkZXNjcmliZSBo
b3cgdGhhdCBjb3VsZCBiZSBkb25lIGZyb20gdGhlDQo+PiBrZXJuZWwgYnkgdXNpbmcgZXhpc3Rp
bmcgZnVuY3Rpb25hbGl0eSAoQ09ORklHX09GX0RZTkFNSUMpLg0KPj4NCj4+IEFzIEkgc2FpZCBp
ZiB3ZSBleHBvc2VkIHRoZSBkZXZpY2VzIHdpdGggc3RhdHVzICJkaXNhYmxlZCIsIHRoZXkNCj4+
IHdvdWxkbid0IGdldCBwcm9iZWQgYnkgZGVmYXVsdC4gT25jZSB3ZSByZWNlaXZlIGFuIHNpZ25h
bA0KPj4gdGhhdCBvdGhlcmVuZCBpcyByZWFkeSwgd2UgY2hhbmdlIHRoZSBzdGF0dXMgdG8gIm9r
IiBhbmQgdGhlDQo+PiBjb3JyZXNwb25kaW5nIGRldmljZSBnZXRzIHByb2JlZC4NCj4+DQo+PiBT
byBiZWxvdyB0aGUgdGVzdCBwYXRjaCwgd2hpY2gganVzdCBjaGFuZ2UgdGhlIHN0YXR1cyBvZiB0
aGUgcmVxdWlyZWQNCj4+IGRldmljZS10cmVlIG5vZGUgKGFzIHlvdSBjYW4gc2VlIHRoZSBjb2Rl
IHRvIHVwZGF0ZSB0aGUgcHJvcGVydHkgaXMNCj4+IHNpbXBsZSBlbm91Z2gpLA0KPj4gSSBoYWNr
ZWQgInhsIHN5c3JxIiBmb3IgdGhlIGNvbnZlbmllbmNlIG9mIHRlc3RpbmcuDQo+Pg0KPj4NCj4+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMgYi9kcml2ZXJzL3hlbi9n
cmFudC1kbWEtb3BzLmMNCj4+IGluZGV4IDA0NWMxODA1YjJkNS4uOTY4M2NlMDc1YmM5IDEwMDY0
NA0KPj4gLS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiArKysgYi9kcml2ZXJz
L3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+IEBAIC0xMCw2ICsxMCw3IEBADQo+PiAgIMKgI2luY2x1
ZGUgPGxpbnV4L21vZHVsZS5oPg0KPj4gICDCoCNpbmNsdWRlIDxsaW51eC9kbWEtbWFwLW9wcy5o
Pg0KPj4gICDCoCNpbmNsdWRlIDxsaW51eC9vZi5oPg0KPj4gKyNpbmNsdWRlIDxsaW51eC9vZl9w
bGF0Zm9ybS5oPg0KPj4gICDCoCNpbmNsdWRlIDxsaW51eC9wY2kuaD4NCj4+ICAgwqAjaW5jbHVk
ZSA8bGludXgvcGZuLmg+DQo+PiAgIMKgI2luY2x1ZGUgPGxpbnV4L3hhcnJheS5oPg0KPj4gQEAg
LTM3OSw2ICszODAsMTA4IEBAIGJvb2wgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRl
dmljZSAqZGV2KQ0KPj4gICDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+PiAgIMKgfQ0K
Pj4NCj4+ICsvKiBUT0RPOiBDb25zaWRlciB1c2luZyBzdGF0aWNhbGx5IGFsbG9jYXRlZCAoc3Ry
dWN0IHByb3BlcnR5IHN0YXR1cykgKi8NCj4+ICtzdGF0aWMgaW50IHhlbl9ncmFudF9kbWFfZW5h
YmxlX2RldmljZShzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wKQ0KPj4gK3sNCj4+ICvCoMKgwqDCoMKg
wqAgc3RydWN0IHByb3BlcnR5ICpzdGF0dXM7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgIHN0YXR1
cyA9IGt6YWxsb2Moc2l6ZW9mKCpzdGF0dXMpLCBHRlBfS0VSTkVMKTsNCj4+ICvCoMKgwqDCoMKg
wqAgaWYgKCFzdGF0dXMpDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4g
LUVOT01FTTsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqAgc3RhdHVzLT5uYW1lID0ga3N0cmR1cCgi
c3RhdHVzIiwgR0ZQX0tFUk5FTCk7DQo+PiArwqDCoMKgwqDCoMKgIGlmICghc3RhdHVzLT5uYW1l
KQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07DQo+PiAr
DQo+PiArwqDCoMKgwqDCoMKgIHN0YXR1cy0+dmFsdWUgPSBrc3RyZHVwKCJva2F5IiwgR0ZQX0tF
Uk5FTCk7DQo+PiArwqDCoMKgwqDCoMKgIGlmICghc3RhdHVzLT52YWx1ZSkNCj4+ICvCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5PTUVNOw0KPj4gKw0KPj4gK8KgwqDCoMKg
wqDCoCBzdGF0dXMtPmxlbmd0aCA9IHNpemVvZigib2theSIpOw0KPj4gKw0KPj4gK8KgwqDCoMKg
wqDCoCByZXR1cm4gb2ZfdXBkYXRlX3Byb3BlcnR5KG5wLCBzdGF0dXMpOw0KPj4gK30NCj4+ICsN
Cj4+ICtzdGF0aWMgaW50IHhlbl9ncmFudF9kbWFfZGlzYWJsZV9kZXZpY2Uoc3RydWN0IGRldmlj
ZV9ub2RlICpucCkNCj4+ICt7DQo+PiArwqDCoMKgwqDCoMKgIHN0cnVjdCBwcm9wZXJ0eSAqc3Rh
dHVzOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoCBzdGF0dXMgPSBremFsbG9jKHNpemVvZigqc3Rh
dHVzKSwgR0ZQX0tFUk5FTCk7DQo+PiArwqDCoMKgwqDCoMKgIGlmICghc3RhdHVzKQ0KPj4gK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07DQo+PiArDQo+PiArwqDC
oMKgwqDCoMKgIHN0YXR1cy0+bmFtZSA9IGtzdHJkdXAoInN0YXR1cyIsIEdGUF9LRVJORUwpOw0K
Pj4gK8KgwqDCoMKgwqDCoCBpZiAoIXN0YXR1cy0+bmFtZSkNCj4+ICvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHJldHVybiAtRU5PTUVNOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoCBzdGF0
dXMtPnZhbHVlID0ga3N0cmR1cCgiZGlzYWJsZWQiLCBHRlBfS0VSTkVMKTsNCj4+ICvCoMKgwqDC
oMKgwqAgaWYgKCFzdGF0dXMtPnZhbHVlKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgcmV0dXJuIC1FTk9NRU07DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgIHN0YXR1cy0+bGVuZ3Ro
ID0gc2l6ZW9mKCJkaXNhYmxlZCIpOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoCByZXR1cm4gb2Zf
dXBkYXRlX3Byb3BlcnR5KG5wLCBzdGF0dXMpOw0KPj4gK30NCj4+ICsNCj4+ICt2b2lkIHhlbl9n
cmFudF9kbWFfaGFuZGxlX3N5c3JxKGludCBrZXkpDQo+PiArew0KPj4gK8KgwqDCoMKgwqDCoCBz
dHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4gK8KgwqDCoMKgwqDCoCBjb25zdCBjaGFyICpwYXRo
Ow0KPj4gK8KgwqDCoMKgwqDCoCBib29sIGVuYWJsZTsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqAg
cHJpbnRrKCIlczogZ290IGtleSAlZFxuIiwgX19mdW5jX18sIGtleSk7DQo+PiArDQo+PiArwqDC
oMKgwqDCoMKgIHN3aXRjaCAoa2V5KSB7DQo+PiArwqDCoMKgwqDCoMKgIGNhc2UgJzAnOg0KPj4g
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGF0aCA9ICIvdmlydGlvQDIwMDAwMDAiOw0K
Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW5hYmxlID0gdHJ1ZTsNCj4+ICvCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoCBj
YXNlICcxJzoNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBhdGggPSAiL3ZpcnRp
b0AyMDAwMjAwIjsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVuYWJsZSA9IHRy
dWU7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBicmVhazsNCj4+ICsNCj4+ICvC
oMKgwqDCoMKgwqAgY2FzZSAnMic6DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBw
YXRoID0gIi92aXJ0aW9AMjAwMDAwMCI7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBlbmFibGUgPSBmYWxzZTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFr
Ow0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoCBjYXNlICczJzoNCj4+ICvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHBhdGggPSAiL3ZpcnRpb0AyMDAwMjAwIjsNCj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIGVuYWJsZSA9IGZhbHNlOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgYnJlYWs7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgIGNhc2UgJzQnOg0KPj4gK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGF0aCA9ICIvcGNpZUAxMDAwMDAwMCI7DQo+PiAr
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBlbmFibGUgPSB0cnVlOw0KPj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgYnJlYWs7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgIGNhc2Ug
JzUnOg0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGF0aCA9ICIvcGNpZUAxMDAw
MDAwMCI7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBlbmFibGUgPSBmYWxzZTsN
Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOw0KPj4gKw0KPj4gK8KgwqDC
oMKgwqDCoCBkZWZhdWx0Og0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJpbnRr
KCIlczogd3Jvbmcga2V5ICVkXG4iLCBfX2Z1bmNfXywga2V5KTsNCj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIHJldHVybjsNCj4+ICvCoMKgwqDCoMKgwqAgfQ0KPj4gKw0KPj4gK8Kg
wqDCoMKgwqDCoCBucCA9IG9mX2ZpbmRfbm9kZV9ieV9wYXRoKHBhdGgpOw0KPj4gK8KgwqDCoMKg
wqDCoCBpZiAoIW5wKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludGso
IiVzOiBmYWlsZWQgdG8gZmluZCBub2RlIGJ5IHBhdGggJXNcbiIsIF9fZnVuY19fLA0KPj4gcGF0
aCk7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm47DQo+PiArwqDCoMKg
wqDCoMKgIH0NCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqAgaWYgKGVuYWJsZSkgew0KPj4gK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuX2dyYW50X2RtYV9lbmFibGVfZGV2aWNlKG5wKTsN
Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygiJXM6IGVuYWJsZSAlc1xu
IiwgX19mdW5jX18sIHBhdGgpOw0KPj4gK8KgwqDCoMKgwqDCoCB9IGVsc2Ugew0KPj4gK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuX2dyYW50X2RtYV9kaXNhYmxlX2RldmljZShucCk7
DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludGsoIiVzOiBkaXNhYmxlICVz
XG4iLCBfX2Z1bmNfXywgcGF0aCk7DQo+PiArwqDCoMKgwqDCoMKgIH0NCj4+ICt9DQo+PiArDQo+
PiAgIMKgYm9vbCB4ZW5fdmlydGlvX21lbV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikN
Cj4+ICAgwqB7DQo+PiAgIMKgwqDCoMKgwqDCoMKgIGlmIChJU19FTkFCTEVEKENPTkZJR19YRU5f
VklSVElPX0ZPUkNFX0dSQU5UKSB8fCB4ZW5fcHZfZG9tYWluKCkpDQo+PiBkaWZmIC0tZ2l0IGEv
ZHJpdmVycy94ZW4vbWFuYWdlLmMgYi9kcml2ZXJzL3hlbi9tYW5hZ2UuYw0KPj4gaW5kZXggYzE2
ZGY2Mjk5MDdlLi42ZGY5NmJlMWVhNDAgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL3hlbi9tYW5h
Z2UuYw0KPj4gKysrIGIvZHJpdmVycy94ZW4vbWFuYWdlLmMNCj4+IEBAIC0zMDgsNyArMzA4LDgg
QEAgc3RhdGljIHZvaWQgc3lzcnFfaGFuZGxlcihzdHJ1Y3QgeGVuYnVzX3dhdGNoDQo+PiAqd2F0
Y2gsIGNvbnN0IGNoYXIgKnBhdGgsDQo+PiAgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBnb3RvIGFnYWluOw0KPj4NCj4+ICAgwqDCoMKgwqDCoMKgwqAgaWYgKHN5c3JxX2tleSAhPSAn
XDAnKQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGFuZGxlX3N5c3JxKHN5c3Jx
X2tleSk7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvKmhhbmRsZV9zeXNycShz
eXNycV9rZXkpOyovDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fZ3JhbnRf
ZG1hX2hhbmRsZV9zeXNycShzeXNycV9rZXkpOw0KPj4gICDCoH0NCj4+DQo+PiAgIMKgc3RhdGlj
IHN0cnVjdCB4ZW5idXNfd2F0Y2ggc3lzcnFfd2F0Y2ggPSB7DQo+PiBkaWZmIC0tZ2l0IGEvaW5j
bHVkZS94ZW4veGVuLW9wcy5oIGIvaW5jbHVkZS94ZW4veGVuLW9wcy5oDQo+PiBpbmRleCBhMzRm
NDI3MWEyZTkuLmMyZGExYmMyNDA5MSAxMDA2NDQNCj4+IC0tLSBhL2luY2x1ZGUveGVuL3hlbi1v
cHMuaA0KPj4gKysrIGIvaW5jbHVkZS94ZW4veGVuLW9wcy5oDQo+PiBAQCAtMjE1LDYgKzIxNSw4
IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCB4ZW5fcHJlZW1wdGlibGVfaGNhbGxfZW5kKHZvaWQpIHsg
fQ0KPj4NCj4+ICAgwqAjZW5kaWYgLyogQ09ORklHX1hFTl9QViAmJiAhQ09ORklHX1BSRUVNUFRJ
T04gKi8NCj4+DQo+PiArdm9pZCB4ZW5fZ3JhbnRfZG1hX2hhbmRsZV9zeXNycShpbnQga2V5KTsN
Cj4+ICsNCj4+ICAgwqAjaWZkZWYgQ09ORklHX1hFTl9HUkFOVF9ETUFfT1BTDQo+PiAgIMKgdm9p
ZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpOw0KPj4gICDCoGJv
b2wgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KTsNCj4+IChFTkQp
DQo+Pg0KPj4gU28gaG93IGl0IGxvb2tzIGxpa2U6DQo+Pg0KPj4gMS4gRG9tVSBib290cyB3aXRo
b3V0IFBDSSBIb3N0IGJyaWRnZSBwcm9iZWQuIFNvIG5vdGhpbmcgUENJIHJlbGF0ZWQgaXMNCj4+
IG9ic2VydmVkIGluIERvbVUuDQo+Pg0KPj4gY2F0IC9wcm9jL2RldmljZS10cmVlL3BjaWVAMTAw
MDAwMDAvc3RhdHVzDQo+PiBkaXNhYmxlZA0KPj4NCj4+IDIuIEkgcnVuIGJhY2tlbmRzIGluIERv
bUQgYW5kIGFmdGVyIHRoYXQgaXNzdWUgYSBzaWduYWwgdG8gImVuYWJsZSINCj4+DQo+PiByb290
QGdlbmVyaWMtYXJtdjgteHQtZG9tMDp+IyB4bCBzeXNycSBEb21VIDQNCj4+DQo+PiAzLiBUaGUg
UENJIEhvc3QgYnJpZGdlIGlzIHByb2JlZCwgYW5kIGFsbCByZXF1aXJlZCBQQ0kgZGV2aWNlcyBh
cmUNCj4+IGRpc2NvdmVyZWQNCj4+DQo+PiByb290QGdlbmVyaWMtYXJtdjgteHQtZG9tMDp+IyB4
bCBjb25zb2xlIERvbVUNCj4+IFvCoCAyMzcuNDA3NjIwXSB4ZW5fZ3JhbnRfZG1hX2hhbmRsZV9z
eXNycTogZ290IGtleSA1Mg0KPj4gW8KgIDIzNy40MDgxMzNdIHBjaS1ob3N0LWdlbmVyaWMgMTAw
MDAwMDAucGNpZTogaG9zdCBicmlkZ2UNCj4+IC9wY2llQDEwMDAwMDAwIHJhbmdlczoNCj4+IFvC
oCAyMzcuNDA4MTg2XSBwY2ktaG9zdC1nZW5lcmljIDEwMDAwMDAwLnBjaWU6wqDCoMKgwqDCoCBN
RU0NCj4+IDB4MDAyMzAwMDAwMC4uMHgwMDMyZmZmZmZmIC0+IDB4MDAyMzAwMDAwMA0KPj4gW8Kg
IDIzNy40MDgyMzFdIHBjaS1ob3N0LWdlbmVyaWMgMTAwMDAwMDAucGNpZTrCoMKgwqDCoMKgIE1F
TQ0KPj4gMHgwMTAwMDAwMDAwLi4weDAxZmZmZmZmZmYgLT4gMHgwMTAwMDAwMDAwDQo+PiBbwqAg
MjM3LjQwODMxM10gcGNpLWhvc3QtZ2VuZXJpYyAxMDAwMDAwMC5wY2llOiBFQ0FNIGF0IFttZW0N
Cj4+IDB4MTAwMDAwMDAtMHgxZmZmZmZmZl0gZm9yIFtidXMgMDAtZmZdDQo+PiBbwqAgMjM3LjQw
ODQ1MV0gcGNpLWhvc3QtZ2VuZXJpYyAxMDAwMDAwMC5wY2llOiBQQ0kgaG9zdCBicmlkZ2UgdG8g
YnVzDQo+PiAwMDAwOjAwDQo+PiBbwqAgMjM3LjQwODQ5MF0gcGNpX2J1cyAwMDAwOjAwOiByb290
IGJ1cyByZXNvdXJjZSBbYnVzIDAwLWZmXQ0KPj4gW8KgIDIzNy40MDg1MTddIHBjaV9idXMgMDAw
MDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbQ0KPj4gMHgyMzAwMDAwMC0weDMyZmZmZmZmXQ0K
Pj4gW8KgIDIzNy40MDg1NDVdIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21l
bQ0KPj4gMHgxMDAwMDAwMDAtMHgxZmZmZmZmZmYgcHJlZl0NCj4+IFvCoCAyMzcuNDA5MDQzXSBw
Y2kgMDAwMDowMDowMC4wOiBbMWIzNjowMDA4XSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwDQo+PiBb
wqAgMjM3LjQ1ODA0NV0gcGNpIDAwMDA6MDA6MDEuMDogWzFhZjQ6MTA0MV0gdHlwZSAwMCBjbGFz
cyAweDAyMDAwMA0KPj4gW8KgIDIzNy41MDI1ODhdIHBjaSAwMDAwOjAwOjAxLjA6IHJlZyAweDIw
OiBbbWVtIDB4MDAwMDAwMDAtMHgwMDAwM2ZmZg0KPj4gNjRiaXQgcHJlZl0NCj4+IFvCoCAyMzcu
NTA3NDc1XSBwY2kgMDAwMDowMDowMi4wOiBbMWFmNDoxMDQyXSB0eXBlIDAwIGNsYXNzIDB4MDEw
MDAwDQo+PiBbwqAgMjM3LjU1MjcwNl0gcGNpIDAwMDA6MDA6MDIuMDogcmVnIDB4MjA6IFttZW0g
MHgwMDAwMDAwMC0weDAwMDAzZmZmDQo+PiA2NGJpdCBwcmVmXQ0KPj4gW8KgIDIzNy41NTk4NDdd
IHBjaSAwMDAwOjAwOjAxLjA6IEJBUiA0OiBhc3NpZ25lZCBbbWVtDQo+PiAweDEwMDAwMDAwMC0w
eDEwMDAwM2ZmZiA2NGJpdCBwcmVmXQ0KPj4gW8KgIDIzNy41NjA0MTFdIHBjaSAwMDAwOjAwOjAy
LjA6IEJBUiA0OiBhc3NpZ25lZCBbbWVtDQo+PiAweDEwMDAwNDAwMC0weDEwMDAwN2ZmZiA2NGJp
dCBwcmVmXQ0KPj4gW8KgIDIzNy41NjMzMjRdIHZpcnRpby1wY2kgMDAwMDowMDowMS4wOiBTZXQg
dXAgWGVuIGdyYW50IERNQSBvcHMgKHJpZA0KPj4gMHg4IHNpZCAweDEpDQo+PiBbwqAgMjM3LjU2
NDgzM10gdmlydGlvLXBjaSAwMDAwOjAwOjAxLjA6IGVuYWJsaW5nIGRldmljZSAoMDAwMCAtPiAw
MDAyKQ0KPj4gW8KgIDIzNy41ODI3MzRdIHZpcnRpby1wY2kgMDAwMDowMDowMi4wOiBTZXQgdXAg
WGVuIGdyYW50IERNQSBvcHMgKHJpZA0KPj4gMHgxMCBzaWQgMHgxKQ0KPj4gW8KgIDIzNy41ODM0
MTNdIHZpcnRpby1wY2kgMDAwMDowMDowMi4wOiBlbmFibGluZyBkZXZpY2UgKDAwMDAgLT4gMDAw
MikNCj4+IFvCoCAyMzcuNTk1NzEyXSB2aXJ0aW9fYmxrIHZpcnRpbzE6IDQvMC8wIGRlZmF1bHQv
cmVhZC9wb2xsIHF1ZXVlcw0KPj4gW8KgIDIzNy41OTYyMjddIHZpcnRpb19uZXQgdmlydGlvMCBl
bnAwczE6IHJlbmFtZWQgZnJvbSBldGgxDQo+PiBbwqAgMjM3LjYwMjQ5OV0gdmlydGlvX2JsayB2
aXJ0aW8xOiBbdmRhXSA0MDk2MDAwIDUxMi1ieXRlIGxvZ2ljYWwgYmxvY2tzDQo+PiAoMi4xMCBH
Qi8xLjk1IEdpQikNCj4+IFvCoCAyMzcuNjA2MzE3XSB4ZW5fZ3JhbnRfZG1hX2hhbmRsZV9zeXNy
cTogZW5hYmxlIC9wY2llQDEwMDAwMDAwDQo+Pg0KPj4gNC4gVGhlIHNhbWUgd2F5IHRoZSBwc2V1
ZG8taG90cmVtb3ZlIHdvdWxkIHdvcmsgKGlmIHdlIGNoYW5nZSB0aGUgc3RhdHVzDQo+PiB0byAi
ZGlzYWJsZWQiIHRoZSBjb3JyZXNwb25kaW5nIGRldmljZSBnZXRzIHJlbW92ZWQpDQo+Pg0KPj4N
Cj4+IElmIHRoaXMgcHNldWRvLWhvdHBsdWcgc291bmRzIGFwcHJvcHJpYXRlIGZvciB0aGUgZG9t
MGxlc3MsDQo+IFRoaXMgaXMgZ3JlYXQhIFllcyBJIHRoaW5rIGl0IGlzIHRvdGFsbHkgYWNjZXB0
YWJsZS4NCg0KDQpQZXJmZWN0IQ0KDQoNCj4NCj4NCj4+IHRoZSBvbmUgb2YgdGhlIG5leHQgcXVl
c3Rpb25zIHdvdWxkIGJlIHdoYXQgbWVjaGFuaXNtIHRvIHVzZSBmb3INCj4+IHNpZ25hbGxpbmcg
KGV2ZW50LCB4ZW5zdG9yZSwgd2hhdGV2ZXIpLg0KPiBGb3IgeW91ciBpbmZvcm1hdGlvbiwgd2Ug
aGFkIHRvIHNvbHZlIGEgc2ltaWxhciBpc3N1ZSBhIGZldyBtb250aHMgYWdvDQo+IHRvIGxldCBh
IGRvbVUgZGlzY292ZXIgYSBuZXdseSBhZGRlZCBhbmQgZGlyZWN0bHkgYXNzaWduZWQgcHJvZ3Jh
bW1hYmxlDQo+IGxvZ2ljIGJsb2NrLiBUaGF0IHdhcyBhbHNvIGRvbmUgYnkgYXBwbHlpbmcgRFQg
b3ZlcmxheXMsIGZpcnN0IHRvIFhlbiwNCj4gdGhlbiB0byB0aGUgZG9tVS4NCj4NCj4gSGF2ZSBh
IGxvb2sgYXQgVmlrcmFtJ3MgWGVuIFN1bW1pdCBwcmVzZW50YXRpb246DQo+IGh0dHBzOi8vdXJs
ZGVmZW5zZS5jb20vdjMvX19odHRwczovL3N0YXRpYy5zY2hlZC5jb20vaG9zdGVkX2ZpbGVzL3hl
bjIwMjIvZTgvSW50cm9kdWNlKjIwRHluYW1pYyoyMERldmljZSoyME5vZGUqMjBQcm9ncmFtbWlu
ZyoyMGZvcioyMFhlbi5wZGZfXztKU1VsSlNVbCEhR0ZfMjlkYmNRSVVCUEEheVRKR2ptbWZyZEpm
b2MtbWFnbmJrNkVjdU5zcFh4dVF5RE16SXRnYVY5bWVoSk1qMzd3N0dvX085dERDUVYzUXBpajBQ
T1JaZGlac2pCWVJPc2FSTldWalBOVXVjZyQgIFtzdGF0aWNbLl1zY2hlZFsuXWNvbV0NCj4NCj4g
V2Ugd3JvdGUgYSBzbWFsbCB4ZW5zdG9yZS1iYXNlZCBwcm90b2NvbCB0byBub3RpZnkgdGhlIGRv
bVUgYW5kIGFsc28gdG8NCj4gdHJhbmZlciB0aGUgb3ZlcmxheSB0byBpdDoNCj4NCj4gaHR0cHM6
Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vZ2l0aHViLmNvbS9YaWxpbngveGVuL2Jsb2Iv
eGxueF9yZWJhc2VfNC4xNi9kb2NzL21pc2MvYXJtL292ZXJsYXkudHh0X187ISFHRl8yOWRiY1FJ
VUJQQSF5VEpHam1tZnJkSmZvYy1tYWduYms2RWN1TnNwWHh1UXlETXpJdGdhVjltZWhKTWozN3c3
R29fTzl0RENRVjNRcGlqMFBPUlpkaVpzakJZUk9zYVJOV1hzN3hsb3VBJCAgW2dpdGh1YlsuXWNv
bV0NCj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vZ2l0aHViLmNvbS9YaWxp
bngveGVuL2Jsb2IveGxueF9yZWJhc2VfNC4xNi90b29scy9oZWxwZXJzL2dldF9vdmVybGF5LmNf
XzshIUdGXzI5ZGJjUUlVQlBBIXlUSkdqbW1mcmRKZm9jLW1hZ25iazZFY3VOc3BYeHVReURNekl0
Z2FWOW1laEpNajM3dzdHb19POXREQ1FWM1FwaWowUE9SWmRpWnNqQllST3NhUk5XWG9SM2dFanck
ICBbZ2l0aHViWy5dY29tXQ0KPg0KPiBUaGVyZSBpcyBhIGdvb2QgZGVzY3JpcHRpb24gc3RhcnRp
bmcgYXQgc2xpZGUgMTYgaW4gdGhlIFBERi4NCj4NCj4NCj4gSSBhbSBvbmx5IHNoYXJpbmcgdGhp
cyBhcyBGWUkuDQoNCg0KVmVyeSBpbnRlcmVzdGluZyBtYXRlcmlhbHMgYW5kIGltcHJlc3NpdmUg
d29yayEgSSBjYW4ndCBldmVuIGltYWdpbmUgDQp3aGF0IGl0IHRvb2sgdG8gZ2V0IGl0IHdvcmtp
bmcuDQoNCg0KDQo+IFRoaXMgVmlydGlvIHByb2JsZW0gaXMgc2ltcGxlciBiZWNhdXNlIHdlDQo+
IGFscmVhZHkga25vdyB0aGUgZGV2aWNlcyB0aGF0IGFyZSBnb2luZyB0byBiZWNvbWUgYXZhaWxh
YmxlLiBXZSBkb24ndA0KPiBuZWVkIGFuIGFjdHVhbCBEVCBvdmVybGF5IHRvIGJlIHBhc3NlZCB0
byB0aGUgZG9tVS4gU28gd2UgY291bGQgZ2V0IGF3YXkNCj4gd2l0aCBqdXN0IGEgc2luZ2xlIGlu
dGVycnVwdCBvciBhIHNpbmdsZSB4ZW5zdG9yZSBwcm9wZXJ0eS4NCg0KSSBjb21wbGV0ZWx5IGFn
cmVlIHRoYXQgZm9yIHZpcnRpbyBpdCBpcyBnb2luZyB0byBiZSBzaW1wbGVyIHRoYW4gZm9yIEZQ
R0EuDQoNCg0KPg0KPg0KPj4gTm90ZSB0aGF0IHNpZ25hbCBzaG91bGQgb25seSBiZSBzZW50IGlm
IGFsbCBiYWNrZW5kcyB3aGljaCBzZXJ2ZQ0KPj4gdmlydGlvLXBjaSBkZXZpY2VzIHdpdGhpbiB0
aGF0IFBDSSBIb3N0IGJyaWRnZSBhcmUgcmVhZHkuDQo+IFllcy4gVGhhdCBzaG91bGQgYmUgZmlu
ZSBhcyBsb25nIGFzIGFsbCB0aGUgYmFja2VuZHMgYXJlIGluIHRoZSBzYW1lDQo+IGRvbWFpbi4g
SSBjYW4gaW1hZ2luZSB0aGVyZSBjb3VsZCBiZSBkaWZmaWN1bHRpZXMgaWYgdGhlIGJhY2tlbmRz
IGFyZQ0KPiBpbiBkaWZmZXJlbnQgZG9tYWluczogYmFja2VuZC1kb21haW4tMSB3b3VsZCBoYXZl
IHRvIHRlbGwgZG9tMCB0aGF0IGl0DQo+IGlzIHJlYWR5LCB0aGVuIGJhY2tlbmQtZG9tYWluLTIg
d291bGQgaGF2ZSB0byBkbyB0aGUgc2FtZSwgdGhlbiBkb20wDQo+IGZpbmFsbHkgbm90aWZpZXMg
dGhlIGRvbVUsIG9yIHNvbWV0aGluZyBsaWtlIHRoYXQuDQo+DQo+IEFueXdheSwgSSB0aGluayB0
aGlzIGlzIGdvb2QgZW5vdWdoIHRvIHN0YXJ0IGFzIGEgc29sdXRpb24uIEV4Y2VsbGVudCENCj4N
Cj4NCj4+Pj4+IE90aGVyIGlkZWFzPw0KPj4+PiBBbm90aGVyIChjcmF6eT8pIGlkZWEgaXMgdG8g
cmV1c2UgQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQgZm9yDQo+Pj4+IGRvbTBsZXNzIHN5
c3RlbSAoSSBtZWFuIHdpdGhvdXQgInhlbixncmFudC1kbWEiIGJpbmRpbmdzIGF0IGFsbCkuDQo+
Pj4+IElmIHZpcnRpbyBiYWNrZW5kcyBhcmUgYWx3YXlzIGdvaW5nIHRvIHJ1biBpbiBEb20wIHdo
ZW4gd2UgaGF2ZSBpdCB1cA0KPj4+PiBhbmQgcnVubmluZywgdGhlbiBpdCBzaG91bGQgd29yayBh
cyBkb21pZCA9PSAwIGlzIHJlc2VydmVkIGZvciBEb20wLg0KPj4+PiBJZiB0aGVyZSBpcyBhIG5l
ZWQgdG8gcnVuIHZpcnRpbyBiYWNrZW5kcyBpbiBvdGhlciAqYmFja2VuZCogZG9tYWluIChmb3IN
Cj4+Pj4gdGhlIGRvbWFpbiBJRCB0byBiZSBhbHdheXMga25vd24gd2UgY291bGQgcmVzZXJ2ZSBh
biBJRCBmb3IgaXQsIHNvIGl0DQo+Pj4+IHdvdWxkIGJlIGEgY29uc3QgdmFsdWUpLA0KPj4+PiB3
ZSBjb3VsZCBwcm9iYWJseSBpbnRyb2R1Y2Ugc29tZXRoaW5nIGNvbmZpZ3VyYWJsZSBsaWtlDQo+
Pj4+IENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5UX0JFX0RPTUlEIHdpdGggMCBieSBkZWZh
dWx0IChvciBjbWQgbGluZQ0KPj4+PiBvcHRpb24pLg0KPj4+IFRoZSBwcm9ibGVtIGluIGEgZG9t
MGxlc3Mgc3lzdGVtIGlzIG5vdCBtdWNoIGhvdyB0byB0ZWxsIHdoaWNoIGlzIHRoZQ0KPj4+IGJh
Y2tlbmQgZG9taWQsIGJlY2F1c2UgdGhhdCBpcyBrbm93biBpbiBhZHZhbmNlIGFuZCBjb3VsZCBi
ZSBhZGRlZCB0bw0KPj4+IGRldmljZSB0cmVlIGF0IGJvb3Qgc29tZWhvdy4gVGhlIGlzc3VlIGlz
IGhvdyB0byBhc2sgdGhlIGZyb250ZW5kIHRvDQo+Pj4gIndhaXQiIGFuZCB0aGVuIGhvdyB0byB0
ZWxsIHRoZSBmcm9udGVuZCB0byAicHJvY2VlZCIgYWZ0ZXIgdGhlIGJhY2tlbmQNCj4+PiBjb21l
cyBvbmxpbmUuDQo+PiBwbGVhc2Ugc2VlIGFib3ZlLg0KPj4NCj4+DQo+PiBUbyBzdW1tYXJpemU6
DQo+Pg0KPj4gMS4gRm9yIG5vcm1hbCBjYXNlIHRoZXJlIGlzIG5vIHByb2JsZW0gd2l0aCBjb21t
dW5pY2F0aW5nIHRoZSBiYWNrZW5kDQo+PiBkb21pZCBvbiBBcm0gd2l0aCBkZXZpY2UtdHJlZSAo
bmVpdGhlciBmb3IgdmlydGlvLW1taW8gbm9yIGZvciB2aXJ0aW8tcGNpKSwNCj4+IGZvciB0aGUg
dmlydGlvLXBjaSB0aGUgVjIgKFBDSS1JT01NVSBiaW5kaW5ncykgc2hvdWxkIGJlIHVzZWQuIEZv
ciB0aGUNCj4+IGRvbTBsZXNzIHRoZXJlIHdvbid0IGJlIHByb2JsZW0gYWxzbyBhcyBJIHVuZGVy
c3Rvb2QgZnJvbSB0aGUgZGlzY3Vzc2lvbg0KPj4gKGFzIHRoZSBjb25maWd1cmF0aW9uIGlzIGtu
b3duIGluIGFkdmFuY2UpLg0KPj4gU28gSSBwcm9wb3NlIHRvIGNvbmNlbnRyYXRlIG9uIFYyLg0K
PiBZZXMgSSBhZ3JlZQ0KPg0KPg0KPj4gMi4gVGhlIHByb2JsZW0gaXMgaW4gc3VwcG9ydGluZyB2
aXJ0aW8gZm9yIHRoZSBkb20wbGVzcyBpbiBnZW5lcmFsDQo+PiBkZXNwaXRlIHdoZXRoZXIgaXQg
aXMgYSBmb3JlaWduIG9yIGdyYW50IG1hcHBpbmdzLg0KPj4gSGVyZSB3ZSB3b3VsZCBuZWVkIGEg
KHBzZXVkby0paG90cGx1ZyBvciBzb21lIG90aGVyIG1ldGhvZCB0byBzdGFydA0KPj4gb3BlcmF0
aW5nIG9ubHkgd2hlbiBiYWNrZW5kIGlzIGF2YWlsYWJsZS4NCj4gWWVzIEkgdGhpbmsgeW91IGFy
ZSByaWdodA0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:11:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:11:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427009.675814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ola1K-0006Dv-1B; Thu, 20 Oct 2022 18:11:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427009.675814; Thu, 20 Oct 2022 18:11:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ola1J-0006Do-TE; Thu, 20 Oct 2022 18:11:53 +0000
Received: by outflank-mailman (input) for mailman id 427009;
 Thu, 20 Oct 2022 18:11:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rNmt=2V=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ola1I-0006Di-H2
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:11:52 +0000
Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com
 [2a00:1450:4864:20::331])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab66db42-50a2-11ed-8fd0-01056ac49cbb;
 Thu, 20 Oct 2022 20:11:51 +0200 (CEST)
Received: by mail-wm1-x331.google.com with SMTP id l32so502429wms.2
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 11:11:51 -0700 (PDT)
Received: from [192.168.1.93] (adsl-46.176.58.194.tellas.gr. [176.58.194.46])
 by smtp.gmail.com with ESMTPSA id
 b21-20020a05600c4e1500b003a83ca67f73sm357594wmq.3.2022.10.20.11.11.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 11:11:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab66db42-50a2-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=6tbvR8liwmRMUZzHJk6Yh3h8ihkkHrt+7l54fpW+xg0=;
        b=i9MWjTTtmwMkSm8Lb1he8IxlnpgPSqcwtV6Of2M7vzpB7JdiLJLngQxacxN/9bemps
         DOPKK/wbw2Abutn+4TL3ikpFP7xoxmi0nHpkRgNf7O8BmtlT66Ce2eFz8R3hIc0b1LwQ
         oPiy7FujyTN/HI+3fp2+hFk6c9asFTSEbuCrRypumUIsOj+D36qv3SihBrVEQf8G7sbH
         aEhXBBrBOFxB1t1Z58p6/GXgl3FJ4+0REqFVSpe3nWzfKGOv+APV//qtdik4d+B81jNo
         thaeMZPvGSCEhqpkCioxawvPzVwLru+H/RNXdYM1U0eB5B2zrriAJIOH96V2MTQPBWrs
         gsPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=6tbvR8liwmRMUZzHJk6Yh3h8ihkkHrt+7l54fpW+xg0=;
        b=8Hd4B4XPrMOGQoWfq8izBPKcognZtShtBRRundPwlX72nZ7Do0GNmWb4n4SAjTexaG
         6ipwJK0KiI9T39s/LzlhtN7heeDfX8iMdEOSDDn2uJWgP5hyjh/ZescCuO3wBCLkH8z4
         5M4TeiJ+fRUOs7YgCDlZ/foobZWai0tpPNwbMkhXs3vpuMpZuukjygwUWY3wnbNnFVEX
         ieP2hlh3dBGqSM80jtyfMcaWQlxZDKz/HhUsxMRGpIU37zMPYz1cuUnAjaZBM8aoLBJj
         a0jgYxmIZQgy4doIMrSaEpzgfTEjMD5pMu/F1EfQM/sdHFrxLqg01MHW0Vkukx1v6CmN
         aiUg==
X-Gm-Message-State: ACrzQf3/hvw5i+3q1j2yL1oT2Rgqr3FoUfkOeeuw4P63BKA5HhT14HQz
	QWnBHw29B2Gni3YIvfMU56w=
X-Google-Smtp-Source: AMsMyM4d4pOnVkhOGxOVg7xfSjhRWrXwApSBU8/qpFZsQTRVq5lb9jNCpIfhXs6JoWoIWB23Fl78fA==
X-Received: by 2002:a05:600c:1614:b0:3c6:ca05:3e02 with SMTP id m20-20020a05600c161400b003c6ca053e02mr32130985wmn.116.1666289510311;
        Thu, 20 Oct 2022 11:11:50 -0700 (PDT)
Message-ID: <44fdaba0-15eb-0778-bacf-3937a36b0841@gmail.com>
Date: Thu, 20 Oct 2022 21:11:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
 <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
 <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
 <ded6c520-8f1a-6ee3-bbfa-3de7e1f74779@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <ded6c520-8f1a-6ee3-bbfa-3de7e1f74779@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/20/22 17:12, Oleksandr Tyshchenko wrote:
> 
> On 20.10.22 11:24, Xenia Ragiadakou wrote:
>> On 10/19/22 22:41, Oleksandr Tyshchenko wrote:
>>
>> Hi Oleksandr
> 
> 
> Hello Xenia
> 
> 
>>
>>>
>>> On 19.10.22 11:47, Xenia Ragiadakou wrote:
>>>
>>> Hello Xenia
>>>
>>>> On 10/19/22 03:58, Stefano Stabellini wrote:
>>>>> On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>
>>>>>> Use the same "xen-grant-dma" device concept for the PCI devices
>>>>>> behind device-tree based PCI Host controller, but with one
>>>>>> modification.
>>>>>> Unlike for platform devices, we cannot use generic IOMMU bindings
>>>>>> (iommus property), as we need to support more flexible configuration.
>>>>>> The problem is that PCI devices under the single PCI Host controller
>>>>>> may have the backends running in different Xen domains and thus have
>>>>>> different endpoints ID (backend domains ID).
>>>>>>
>>>>>> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
>>>>>> properties) which allows us to describe relationship between PCI
>>>>>> devices and backend domains ID properly.
>>>>>>
>>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> Now that I understood the approach and the reasons for it, I can
>>>>> review
>>>>> the patch :-)
>>>>>
>>>>> Please add an example of the bindings in the commit message.
>>>>>
>>>>>
>>>>>> ---
>>>>>> Slightly RFC. This is needed to support Xen grant mappings for
>>>>>> virtio-pci devices
>>>>>> on Arm at some point in the future. The Xen toolstack side is not
>>>>>> completely ready yet.
>>>>>> Here, for PCI devices we use more flexible way to pass backend domid
>>>>>> to the guest
>>>>>> than for platform devices.
>>>>>>
>>>>>> Changes V1 -> V2:
>>>>>>       - update commit description
>>>>>>       - rebase
>>>>>>       - rework to use generic PCI-IOMMU bindings instead of generic
>>>>>> IOMMU bindings
>>>>>>
>>>>>> Previous discussion is at:
>>>>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!3-vq7Edm3XfKtD5cnNjnOzDQvuo_XrhJ73yH-nPfqOkGGU0IjLG7R7MR_nAJCAPeOutHRLT44wKYwQwz3SauACie_ZAy$
>>>>>>
>>>>>> [lore[.]kernel[.]org]
>>>>>>
>>>>>> Based on:
>>>>>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1__;!!GF_29dbcQIUBPA!3-vq7Edm3XfKtD5cnNjnOzDQvuo_XrhJ73yH-nPfqOkGGU0IjLG7R7MR_nAJCAPeOutHRLT44wKYwQwz3SauAEnMDHAq$
>>>>>>
>>>>>> [git[.]kernel[.]org]
>>>>>> ---
>>>>>>     drivers/xen/grant-dma-ops.c | 87
>>>>>> ++++++++++++++++++++++++++++++++-----
>>>>>>     1 file changed, 76 insertions(+), 11 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/xen/grant-dma-ops.c
>>>>>> b/drivers/xen/grant-dma-ops.c
>>>>>> index daa525df7bdc..b79d9d6ce154 100644
>>>>>> --- a/drivers/xen/grant-dma-ops.c
>>>>>> +++ b/drivers/xen/grant-dma-ops.c
>>>>>> @@ -10,6 +10,7 @@
>>>>>>     #include <linux/module.h>
>>>>>>     #include <linux/dma-map-ops.h>
>>>>>>     #include <linux/of.h>
>>>>>> +#include <linux/pci.h>
>>>>>>     #include <linux/pfn.h>
>>>>>>     #include <linux/xarray.h>
>>>>>>     #include <linux/virtio_anchor.h>
>>>>>> @@ -292,12 +293,55 @@ static const struct dma_map_ops
>>>>>> xen_grant_dma_ops = {
>>>>>>         .dma_supported = xen_grant_dma_supported,
>>>>>>     };
>>>>>>     +static struct device_node *xen_dt_get_pci_host_node(struct device
>>>>>> *dev)
>>>>>> +{
>>>>>> +    struct pci_dev *pdev = to_pci_dev(dev);
>>>>>> +    struct pci_bus *bus = pdev->bus;
>>>>>> +
>>>>>> +    /* Walk up to the root bus to look for PCI Host controller */
>>>>>> +    while (!pci_is_root_bus(bus))
>>>>>> +        bus = bus->parent;
>>>>>> +
>>>>>> +    return of_node_get(bus->bridge->parent->of_node);
>>>>>> +}
>>>>>
>>>>> It seems silly that we need to walk the hierachy that way, but I
>>>>> couldn't find another way to do it
>>>>>
>>>>>
>>>>>> +static struct device_node *xen_dt_get_node(struct device *dev)
>>>>>> +{
>>>>>> +    if (dev_is_pci(dev))
>>>>>> +        return xen_dt_get_pci_host_node(dev);
>>>>>> +
>>>>>> +    return of_node_get(dev->of_node);
>>>>>> +}
>>>>>> +
>>>>>> +static int xen_dt_map_id(struct device *dev, struct device_node
>>>>>> **iommu_np,
>>>>>> +             u32 *sid)
>>>>>> +{
>>>>>> +    struct pci_dev *pdev = to_pci_dev(dev);
>>>>>> +    u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
>>>>>> +    struct device_node *host_np;
>>>>>> +    int ret;
>>>>>> +
>>>>>> +    host_np = xen_dt_get_pci_host_node(dev);
>>>>>> +    if (!host_np)
>>>>>> +        return -ENODEV;
>>>>>> +
>>>>>> +    ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask",
>>>>>> iommu_np, sid);
>>>>>> +    of_node_put(host_np);
>>>>>> +    return ret;
>>>>>> +}
>>>>>> +
>>>>>>     static bool xen_is_dt_grant_dma_device(struct device *dev)
>>>>>>     {
>>>>>> -    struct device_node *iommu_np;
>>>>>> +    struct device_node *iommu_np = NULL;
>>>>>>         bool has_iommu;
>>>>>>     -    iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>>>> +    if (dev_is_pci(dev)) {
>>>>>> +        if (xen_dt_map_id(dev, &iommu_np, NULL))
>>>>>> +            return false;
>>>>>> +    } else
>>>>>> +        iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>>>> +
>>>>>>         has_iommu = iommu_np &&
>>>>>>                 of_device_is_compatible(iommu_np, "xen,grant-dma");
>>>>>>         of_node_put(iommu_np);
>>>>>> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct
>>>>>> device *dev)
>>>>>>       bool xen_is_grant_dma_device(struct device *dev)
>>>>>>     {
>>>>>> +    struct device_node *np;
>>>>>> +
>>>>>>         /* XXX Handle only DT devices for now */
>>>>>> -    if (dev->of_node)
>>>>>> -        return xen_is_dt_grant_dma_device(dev);
>>>>>> +    np = xen_dt_get_node(dev);
>>>>>> +    if (np) {
>>>>>> +        bool ret;
>>>>>> +
>>>>>> +        ret = xen_is_dt_grant_dma_device(dev);
>>>>>> +        of_node_put(np);
>>>>>> +        return ret;
>>>>>> +    }
>>>>>
>>>>> We don't need to walk the PCI hierachy twice. Maybe we can add the
>>>>> of_node check directly to xen_is_dt_grant_dma_device?
>>>>>
>>>>
>>>> I think in general we could pass directly the host bridge device if
>>>> dev_is_pci(dev) (which can be retrieved with
>>>> pci_get_host_bridge_device(to_pci_dev(dev), and after done with it
>>>> pci_put_host_bridge_device(phb)).
>>>> So that, xen_is_dt_grant_dma_device() and
>>>> xen_dt_grant_init_backend_domid() won't need to discover it themselves.
>>>> This will simplify the code.
>>>
>>>
>>> Good point. I have some remark. Can we use pci_find_host_bridge()
>>> instead? This way we don't have to add #include "../pci/pci.h", and have
>>> to drop reference afterwards.
>>>
>>> With that xen_dt_get_pci_host_node() will became the following:
>>>
>>>
>>> static struct device_node *xen_dt_get_pci_host_node(struct device *dev)
>>> {
>>>        struct pci_host_bridge *bridge =
>>> pci_find_host_bridge(to_pci_dev(dev)->bus);
>>>
>>>        return of_node_get(bridge->dev.parent->of_node);
>>> }
>>>
>>
>> You are right. I prefer your version instead of the above.
> 
> 
> ok, thanks
> 
> 
>>
>>
>>>
>>> With Stefano's suggestion, we won't walk the PCI hierarchy twice when
>>> executing xen_is_grant_dma_device() for PCI device:
>>>
>>> xen_is_grant_dma_device() -> xen_is_dt_grant_dma_device() ->
>>> xen_dt_map_id() -> xen_dt_get_pci_host_node()
>>>
>>>
>>> What do you think?
>>>
>>
>> I was thinking passing the device_node along with the device in the
>> function arguments. More specifically, of doing this (not tested, just
>> an idea):
>>
>> bool xen_is_grant_dma_device(struct device *dev)
>> {
>>      struct device_node *np;
>>      bool has_iommu = false;
>>
>>      /* XXX Handle only DT devices for now */
>>      np = xen_dt_get_node(dev);
>>      if (np)
>>          has_iommu = xen_is_dt_grant_dma_device(dev, np);
>>      of_node_put(np);
>>      return has_iommu;
>> }
>>
>> static bool xen_is_dt_grant_dma_device(struct device *dev,
>>                                         struct device_node *np)
>> {
>>      struct device_node *iommu_np = NULL;
>>      bool has_iommu;
>>
>>      if (dev_is_pci(dev)) {
>>          struct pci_dev *pdev = to_pci_dev(dev);
>>      u32 id = PCI_DEVID(pdev->bus->number, pdev->devfn);
>>          of_map_id(np, id, "iommu-map", "iommu-map-mask", &iommu_np,
>> NULL);
>>      } else {
>>          iommu_np = of_parse_phandle(np, "iommus", 0);
>>      }
>>
>>      has_iommu = iommu_np && of_device_is_compatible(iommu_np,
>> "xen,grant-dma");
>>      of_node_put(iommu_np);
>>
>>      return has_iommu;
>> }
> 
> 
> I got it.
> 
> xen_is_grant_dma_device() for V3 won't call xen_dt_get_node(), but call
> xen_is_dt_grant_dma_device() directly.
> 
> static bool xen_is_dt_grant_dma_device(struct device *dev)
> {
>       struct device_node *iommu_np = NULL;
>       bool has_iommu;
> 
>       if (dev_is_pci(dev)) {
>           if (xen_dt_map_id(dev, &iommu_np, NULL))
>               return false;
>       } else if (dev->of_node)
>           iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>       else
>           return false;
> 
>       has_iommu = iommu_np &&
>               of_device_is_compatible(iommu_np, "xen,grant-dma");
>       of_node_put(iommu_np);
> 
>       return has_iommu;
> }
> 
> bool xen_is_grant_dma_device(struct device *dev)
> {
>       /* XXX Handle only DT devices for now */
>       return xen_is_dt_grant_dma_device(dev);
> }
> 
> 

Ok. One difference, that I see from the previous, is that here you don't 
use the dynamic interface when you access the dev->of_node 
(of_node_get/of_node_put). Before, this was guarded through the external 
xen_dt_get_node().

I suspect that the same needs to be done for the function 
xen_grant_setup_dma_ops(). There, also, the code walks up to the root 
bus twice.

>>
>> I 'm wondering ... is it possible for the host bridge device node to
>> have the iommus property set? meaning that all of its pci devs will
>> have the same backend?
> 
> Good question. I think, it is possible... This is technically what V1 is
> doing.
> 
> 
> Are you asking because to support "iommus" for PCI devices as well to
> describe that use-case with all PCI devices having the same endpoint ID
> (backend ID)?
> If yes, I think, this could be still described by "iommu-map" property,
> something like that (if we don't want to describe mapping for each PCI
> device one-by-one).
> 
> iommu-map = <0x0 &iommu X 0x1>;
> 
> iommu-map-mask = <0x0>;
> 
> where the X is backend ID.
> 
> 
> It feels to me that it should be written down somewhere that for
> platform devices we expect "iommus" and for PCI devices we expect
> "iommu-map/iommu-map-mask" to be present.

Thanks for the clarification, now I got it. Yes I agree.

>>
>>
>>>>
>>>>>
>>>>>>         return false;
>>>>>>     }
>>>>>> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device
>>>>>> *dev)
>>>>>>     static int xen_dt_grant_init_backend_domid(struct device *dev,
>>>>>>                            struct xen_grant_dma_data *data)
>>>>>>     {
>>>>>> -    struct of_phandle_args iommu_spec;
>>>>>> +    struct of_phandle_args iommu_spec = { .args_count = 1 };
>>>>>>     -    if (of_parse_phandle_with_args(dev->of_node, "iommus",
>>>>>> "#iommu-cells",
>>>>>> -            0, &iommu_spec)) {
>>>>>> -        dev_err(dev, "Cannot parse iommus property\n");
>>>>>> -        return -ESRCH;
>>>>>> +    if (dev_is_pci(dev)) {
>>>>>> +        if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
>>>>>> +            dev_err(dev, "Cannot translate ID\n");
>>>>>> +            return -ESRCH;
>>>>>> +        }
>>>>>> +    } else {
>>>>>> +        if (of_parse_phandle_with_args(dev->of_node, "iommus",
>>>>>> "#iommu-cells",
>>>>>> +                0, &iommu_spec)) {
>>>>>> +            dev_err(dev, "Cannot parse iommus property\n");
>>>>>> +            return -ESRCH;
>>>>>> +        }
>>>>>>         }
>>>>>>           if (!of_device_is_compatible(iommu_spec.np,
>>>>>> "xen,grant-dma") ||
>>>>>> @@ -354,6 +413,7 @@ static int
>>>>>> xen_dt_grant_init_backend_domid(struct device *dev,
>>>>>>     void xen_grant_setup_dma_ops(struct device *dev)
>>>>>>     {
>>>>>>         struct xen_grant_dma_data *data;
>>>>>> +    struct device_node *np;
>>>>>>           data = find_xen_grant_dma_data(dev);
>>>>>>         if (data) {
>>>>>> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>>>>>>         if (!data)
>>>>>>             goto err;
>>>>>>     -    if (dev->of_node) {
>>>>>> -        if (xen_dt_grant_init_backend_domid(dev, data))
>>>>>> +    np = xen_dt_get_node(dev);
>>>>>> +    if (np) {
>>>>>> +        int ret;
>>>>>> +
>>>>>> +        ret = xen_dt_grant_init_backend_domid(dev, data);
>>>>>> +        of_node_put(np);
>>>>>> +        if (ret)
>>>>>>                 goto err;
>>>>>>         } else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>>>>>>             dev_info(dev, "Using dom0 as backend\n");
>>>>>> -- 
>>>>>> 2.25.1
>>>>>>
>>>>>
>>>>
>>

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:12:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:12:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427014.675825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ola2D-0006m2-AS; Thu, 20 Oct 2022 18:12:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427014.675825; Thu, 20 Oct 2022 18:12:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ola2D-0006lv-7l; Thu, 20 Oct 2022 18:12:49 +0000
Received: by outflank-mailman (input) for mailman id 427014;
 Thu, 20 Oct 2022 18:12:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ola2C-0006ll-6w
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:12:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ola2B-000679-Ub; Thu, 20 Oct 2022 18:12:47 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ola2B-00084M-Ox; Thu, 20 Oct 2022 18:12:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DdTpJ+2PG2G1aHjyP2YH+qpG1DcnSD/i52W1U3q0bOs=; b=y8oBStDcHlVQ3Ov/PuFOFDQ1Mf
	OQDvG3voQ/wde6zSZhxTOrReJQLXB1/1E1Xd+beW81g4KZ4shPj30v11AfJkWU3KR9x98UIiEDfKF
	GyH1YZGGgbAzXUdMu4jbN5wLfMMmnsiQblHUORsNRA4Ma2rSlMTHQlvihgI8bGKXTz/k=;
Message-ID: <c3ecb453-ac2e-fd0d-d5ca-3f485d7f53a3@xen.org>
Date: Thu, 20 Oct 2022 19:12:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit pa range
To: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <20221019144913.291677-1-burzalodowa@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221019144913.291677-1-burzalodowa@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

(+ Henry)

Hi Xenia,

On 19/10/2022 15:49, Xenia Ragiadakou wrote:
> Currently, the fields 'root_order' and 'sl0' of the pa_range_info for
> the 52-bit pa range have the values 3 and 3, respectively.
> This configuration does not match any of the valid root table configurations
> for 4KB granule and t0sz 12, described in ARM DDI 0487I.a D8.2.7.
> 
> More specifically, according to ARM DDI 0487I.a D8.2.7, in order to support
> the 52-bit pa size with 4KB granule, the p2m root table needs to be configured
> either as a single table at level -1 or as 16 concatenated tables at level 0.
> Since, currently there is not support for level -1, set the 'root_order' an

Typo: s/not/no/ (I can fix it while committing)

> 'sl0' fields of the 52-bit pa_range_info according to the second approach.
> 
> Note that the values of those fields are not used so far. This patch updates
> their values only for the sake of correctness.
> 
> Fixes: 407b13a71e32 ("xen/arm: p2m don't fall over on FEAT_LPA enabled hw")
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Regarding 4.17, I am a bit split whether this should be included. On one 
hand, it would be good to have the value correct (not that I expect 
anymore to try using 52-bit on 4.17...). On the other hand, this is not 
used so there is no bug (this could also be an argument to add it 
because it is nearly risk free).

If we don't include it, I will definitely add in my list of potential 
backports.

Henry, any thoughts?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:19:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:19:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427021.675836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ola8k-0007V8-1e; Thu, 20 Oct 2022 18:19:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427021.675836; Thu, 20 Oct 2022 18:19:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ola8j-0007V1-Tl; Thu, 20 Oct 2022 18:19:33 +0000
Received: by outflank-mailman (input) for mailman id 427021;
 Thu, 20 Oct 2022 18:19:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ola8i-0007Uv-W5
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:19:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ola8i-0006Gc-HB; Thu, 20 Oct 2022 18:19:32 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ola8i-0008EG-AJ; Thu, 20 Oct 2022 18:19:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=tTDPMT/bYo1SNeZBluj8cyKZTVoPwSbGq7/2OhLv/AM=; b=VuxTyf75TrJD+hYFQXtT2xKWlE
	SPVjYAcZrxtt5g28MzAv7UbYVoa8vd5Ky9rjQdvkt3XDIEC6k1ldMAvG/lgR1AdgIfotmm1f2yp7G
	eFI0vHUQCYyVPAtgNisahSI4MRFDUAk4uaTsvb2Iovz/2S0yEk7jQgEeNlToVQeyNFBU=;
Message-ID: <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
Date: Thu, 20 Oct 2022 19:19:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
To: Stewart Hildebrand <stewart.hildebrand@amd.com>,
 xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <20221014200926.15250-1-stewart.hildebrand@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221014200926.15250-1-stewart.hildebrand@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stewart,

I nearly missed this one because it was threaded under v1. In the 
future, would you be able to send new version in a separate thread? This 
makes easier to track it.

On 14/10/2022 21:09, Stewart Hildebrand wrote:
> All functions in domain_build.c should be marked __init. This was
> spotted when building the hypervisor with -Og.
> 
> Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Henry, this patch is fixing a potential build failure on some compiler 
(at the moment we are relying on the compiler to inline 
handle_linux_pci_domain). AFAIU, the problem was introduced in Xen 4.17. 
Would you be happy if we include it in the release?

Cheers,

> 
> ---
> v1 -> v2:
>    Add Fixes: tag
>    Add patch description
> ---
>   xen/arch/arm/domain_build.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 61cda8e843..fc2961895b 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1051,8 +1051,8 @@ static void __init assign_static_memory_11(struct domain *d,
>    * The current heuristic assumes that a device is a host bridge
>    * if the type is "pci" and then parent type is not "pci".
>    */
> -static int handle_linux_pci_domain(struct kernel_info *kinfo,
> -                                   const struct dt_device_node *node)
> +static int __init handle_linux_pci_domain(struct kernel_info *kinfo,
> +                                          const struct dt_device_node *node)
>   {
>       uint16_t segment;
>       int res;

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:21:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:21:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427027.675847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaAs-0000QW-DN; Thu, 20 Oct 2022 18:21:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427027.675847; Thu, 20 Oct 2022 18:21:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaAs-0000QP-AG; Thu, 20 Oct 2022 18:21:46 +0000
Received: by outflank-mailman (input) for mailman id 427027;
 Thu, 20 Oct 2022 18:21:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olaAq-0000QH-U7
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:21:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaAp-0006Jr-VA; Thu, 20 Oct 2022 18:21:43 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaAp-0008Gn-Pe; Thu, 20 Oct 2022 18:21:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VUL6j9hkJvGUs8P542j5nlfzqMCcpYV+hgpiAM0hNBg=; b=6bwascUMd7RwUxMbSy8ag4R+iN
	tS8ekSoenccmcylPrMJDAU7tG2i4RBl6DtiAq7ubSdGNRsyUBaHfNQQQfQy8pUzsSV/9rG+MZ41r7
	TFR9eRsgZyi3giblYc/zRkaP34fDg5DKHnVtnxVZjhnwnqCJsFMYyd46JBwxiXQNm20w=;
Message-ID: <cdc3336b-1280-f571-88d2-45394d9133ba@xen.org>
Date: Thu, 20 Oct 2022 19:21:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v4 2/4] Remove extra copies of licenses and license
 headers
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
 <20221013005648.1444144-2-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221013005648.1444144-2-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 13/10/2022 01:56, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> Remove the extra copy of the GPL license and license copyright headers
> from CONTRIBUTING and the top-level COPYING.
> 
> Mention of the LICENSES/ directory and also mention the SPDX tag.
> 
> SPDX support is still in progress and COPYING files in subdirectories
> still need to be updated.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:22:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:22:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427030.675858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaBV-0000z4-MD; Thu, 20 Oct 2022 18:22:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427030.675858; Thu, 20 Oct 2022 18:22:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaBV-0000yx-JB; Thu, 20 Oct 2022 18:22:25 +0000
Received: by outflank-mailman (input) for mailman id 427030;
 Thu, 20 Oct 2022 18:22:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olaBT-0000yZ-Vk
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:22:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaBS-0006KW-Sh; Thu, 20 Oct 2022 18:22:22 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaBS-0008Tf-NS; Thu, 20 Oct 2022 18:22:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DoyG+cCJGVFZ2cis/UXgSd2X8APnobF5Uho4B+ddgxc=; b=0W20pBhnFWYDXygsjTvuzpxCaR
	64JyHVz2FkGmj9+bSBaFEtMNCefhz04YF/9PEDa2ewgLIF7qLeXXMozARE3pPyQVsD31vHLpuy8R0
	wywju4bluAKyU8JAkFoGt32V6RNxr5snQg/RDwamoEM1wXSQnFjpxkbR6v5vIdL8e+is=;
Message-ID: <303bf9d0-6ed0-22b9-8143-aa6a971ba2b2@xen.org>
Date: Thu, 20 Oct 2022 19:22:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v4 3/4] Add SPDX to CODING_STYLE
To: Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
Cc: wl@xen.org, jbeulich@suse.com, george.dunlap@citrix.com,
 andrew.cooper3@citrix.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, roger.pau@citrix.com,
 Stefano Stabellini <stefano.stabellini@amd.com>
References: <alpine.DEB.2.22.394.2210121752580.3690179@ubuntu-linux-20-04-desktop>
 <20221013005648.1444144-3-sstabellini@kernel.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221013005648.1444144-3-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 13/10/2022 01:56, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@amd.com>
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:39:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:39:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427040.675868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaSN-0002jq-8q; Thu, 20 Oct 2022 18:39:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427040.675868; Thu, 20 Oct 2022 18:39:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaSN-0002jj-68; Thu, 20 Oct 2022 18:39:51 +0000
Received: by outflank-mailman (input) for mailman id 427040;
 Thu, 20 Oct 2022 18:39:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olaSM-0002jd-NL
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:39:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaSM-0006cg-8h; Thu, 20 Oct 2022 18:39:50 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaSM-0000kc-2l; Thu, 20 Oct 2022 18:39:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=ApSeXlvRr6kjjbP2G5Q/MYoHG0NT4WzHgyAqDG3LpHw=; b=Z4/Yq4HRjjMMt49UPQbHlyd3nH
	IE7WmCtFS2kziVPQyh07RZwVWYWRnK1/IO62m1JV/qDktOdfCMuOXcyHH7wTRE5wXFYXY4XA7HAo6
	vSTCiOLuFgB0VL30ZzySeYN1x2yfdAUiQslUZaVrWpc3yiuV+PXb6MmARJP3/J8QAQVM=;
Message-ID: <60cd3b64-3b3e-f650-741e-8e09e2ddab38@xen.org>
Date: Thu, 20 Oct 2022 19:39:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>
References: <81c08d76-0937-32d1-c6ac-439c4bf33883@suse.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH v3][4.17] EFI: don't convert memory marked for runtime use
 to ordinary RAM
In-Reply-To: <81c08d76-0937-32d1-c6ac-439c4bf33883@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jan,

Sorry I missed this patch.

On 11/10/2022 10:41, Jan Beulich wrote:
> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
> higher priority than the type of the range. To avoid accessing memory at
> runtime which was re-used for other purposes, make
> efi_arch_process_memory_map() follow suit. While in theory the same would
> apply to EfiACPIReclaimMemory, we don't actually "reclaim" or clobber
> that memory (converted to E820_ACPI on x86) there (and it would be a bug
> if the Dom0 kernel tried to reclaim the range, bypassing Xen's memory
> management, plus it would be at least bogus if it clobbered that space),
> hence that type's handling can be left alone.
> 
> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
> Fixes: facac0af87ef ("x86-64: EFI runtime code")
> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:54:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:54:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427048.675886 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olafq-00057w-I8; Thu, 20 Oct 2022 18:53:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427048.675886; Thu, 20 Oct 2022 18:53:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olafq-00057p-FI; Thu, 20 Oct 2022 18:53:46 +0000
Received: by outflank-mailman (input) for mailman id 427048;
 Thu, 20 Oct 2022 18:53:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bBSw=2V=amd.com=Stewart.Hildebrand@srs-se1.protection.inumbo.net>)
 id 1olafo-00057j-W0
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:53:45 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2088.outbound.protection.outlook.com [40.107.93.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83e9b07a-50a8-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 20:53:41 +0200 (CEST)
Received: from BL1PR13CA0295.namprd13.prod.outlook.com (2603:10b6:208:2bc::30)
 by DS7PR12MB5863.namprd12.prod.outlook.com (2603:10b6:8:7a::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 18:53:38 +0000
Received: from BL02EPF0000C407.namprd05.prod.outlook.com
 (2603:10b6:208:2bc:cafe::4f) by BL1PR13CA0295.outlook.office365.com
 (2603:10b6:208:2bc::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.18 via Frontend
 Transport; Thu, 20 Oct 2022 18:53:38 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BL02EPF0000C407.mail.protection.outlook.com (10.167.241.9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Thu, 20 Oct 2022 18:53:37 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 20 Oct
 2022 13:53:37 -0500
Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Thu, 20 Oct 2022 13:53:36 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83e9b07a-50a8-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F2Vu9Iw0pk+XceZ0sTl7qjHHNx27+ulSPnPeIWL7RvJPXPAUls9edEDEdVPcbaouOKarXB/DccbbwmDET7Yc9QGe8Nv4SWxypLRSPPzpQYBAbghxCguziWATpVPO/mzuZkvhILYvnZNYJEKtt31ucLPqXHpC91jAwYenbkCBb69ajDu8dgUCbjPqenN47jz8uo6xdzHibxED0OQxapm3Gwknu9KdzNyocZ1El3aVAxLHI3ISYk5orLg5PZv/XuKJig5d8ikpvAzmlM+Dx2gG5LxgySR6EL/gsA1IVXvfzA+x1Fnbbl1eTJuTcvkp49n5wfOvx/x99vofDRCrc63NZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uY40rWtfgZZEHFVqcwLpqmRZm31oyWIoQcE/PUfLX4k=;
 b=gDyXIOUxT7B881mW33LlOgLznzWT0aUR7w2dQ1NNW/k3mwDu9nWjVXCTcxh0VkizmH6Te6srBXiwT3rOJneZVPpbpYBAu/vuPJMqPIPW6vp9m328y7KlpLr1dl8Iguom0kOcfIrUcvO4dWXfUHG2V4aEVm9hqEB0R4IZ3vgl6fSdk5JqzsB2kJMvy+Kx3OlIPBXiBOMBxTIKE/erbl54taDV3lfFiOQyxb6VI9JaBgNC48ZXweufunVgmm455Kh6LP7/ZKiZW0jEIPlNm31m+icJxxHixq0sm8+to/dxgXUrFGBMlGcd/Dsh/VKBOcSoUI2weie44pDGB/ej0MikpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uY40rWtfgZZEHFVqcwLpqmRZm31oyWIoQcE/PUfLX4k=;
 b=pBZln3GPPDBA/3Q51x5pDZQLhTtUx0kAyRxmuuVxptXF3uvLXhZP3T8WHKk0VWgmGssLxkEepCC9rGsdHecQV5+ZDlMJwXlgGkzkYBmmucebYP4qpncaW/fi2V5PMjCmI3j5OExZGtdstLxmSolkF3pTT9XcbISdXjIDVtdgbNs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <dda3b199-55ac-d557-b934-c070db8a371e@amd.com>
Date: Thu, 20 Oct 2022 14:53:35 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
Content-Language: en-US
To: Julien Grall <julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Henry Wang <Henry.Wang@arm.com>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <20221014200926.15250-1-stewart.hildebrand@amd.com>
 <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
From: Stewart Hildebrand <stewart.hildebrand@amd.com>
In-Reply-To: <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BL02EPF0000C407:EE_|DS7PR12MB5863:EE_
X-MS-Office365-Filtering-Correlation-Id: 9f8824e6-4051-4327-5aeb-08dab2cc65f6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	z33Gc6XwL1fyXyl5PSTb77rj6aZxqePrGGZroraPNTXkjLzc0i6vTHx6FZlToR8Ic5F1IgGboaX6aDc9lfey2kWBcTOjumUEl/GjYTdo3iX9xQZ0w2g3zhkBamoAkSNERNt0IJS8p0tGGpJGQ4YVzgSbqyOgSmYoIiJ46c5g7E+nOQ8PAeTX0Rxz9qi68zkNZ9D+td/3s6LU1B4fLPh6GnI+Jtrt/0m3L90osTcPbLmNI+9+KoJOSkZZQG2JuKQOztn+Lenu+hdRDxRzmND1bcJispG1bDi6R+e5jg703/e8ZYgWL8ocRD84kQ4kghB+DRQGckTdxmDC5R8jMbrCpDquztLVl5/XyKZBKsVegVE9HnGIGuMLJWrH8MmN07bLdvXZX3z8ik+GHDOK+TdVlM+7mfGCxFwvP9Vit/pZuBVyD58BVou3Kq2vMtFgV0/uR6//n6lk7/loMSFfeHuTYUm5XuK/+EMeTs0qt5snVsJn5tVld2NnjORbwIWpHfe4ZojVYTGP7FcbvEPM41qJ7K1v0UQsIIPa9/0DzTAVSvgRlYi8PKKS9fgPOuHTfqF+hFPOFFUgsWi+pzKF5QEz68bT2cu8hk/MEkg4drIy1QHzU8+itRRA+qgBjOaeKwaQC5wSiPjL1V15ghklgV3zAXXxRIja1x7S4NHLO0GghLLrO7Ngt8ZjQ4uT8ybdl4eoDjNFMNdsLj41fkCR9BujMcdjEKO0wlTh5+zlLxB4W81AoBTa0/xW0sRGco9ykWaGhBPP9/Vg4iD8wtnGL+fj/fD8CZRRNPLNYlgwQwLjFpOjgGFSW9f/GB3ABcm16lroF5rRTrpQIO27HLmagsszXg==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(4326008)(5660300002)(2906002)(70206006)(44832011)(54906003)(8676002)(8936002)(70586007)(81166007)(316002)(110136005)(356005)(83380400001)(40480700001)(41300700001)(26005)(82740400003)(16576012)(36860700001)(53546011)(478600001)(86362001)(426003)(47076005)(336012)(82310400005)(186003)(2616005)(40460700003)(31696002)(31686004)(36756003)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 18:53:37.9593
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8824e6-4051-4327-5aeb-08dab2cc65f6
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BL02EPF0000C407.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5863

On 10/20/22 14:19, Julien Grall wrote:
> Hi Stewart,

Hi Julien,

> I nearly missed this one because it was threaded under v1. In the
> future, would you be able to send new version in a separate thread? This
> makes easier to track it.

I will keep this in mind for next time.

> On 14/10/2022 21:09, Stewart Hildebrand wrote:
>> All functions in domain_build.c should be marked __init. This was
>> spotted when building the hypervisor with -Og.
>>
>> Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices

I missed parenthesis and quotes around the referenced commit. To keep it in the same format as other Fixes: tags, can you please add during commit (pending release ack)?

>> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
> 
> Acked-by: Julien Grall <jgrall@amazon.com>
> 
> Henry, this patch is fixing a potential build failure on some compiler
> (at the moment we are relying on the compiler to inline
> handle_linux_pci_domain). AFAIU, the problem was introduced in Xen 4.17.
> Would you be happy if we include it in the release?
> 
> Cheers,
> 
>>
>> ---
>> v1 -> v2:
>>    Add Fixes: tag
>>    Add patch description
>> ---
>>   xen/arch/arm/domain_build.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 61cda8e843..fc2961895b 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -1051,8 +1051,8 @@ static void __init assign_static_memory_11(struct domain *d,
>>    * The current heuristic assumes that a device is a host bridge
>>    * if the type is "pci" and then parent type is not "pci".
>>    */
>> -static int handle_linux_pci_domain(struct kernel_info *kinfo,
>> -                                   const struct dt_device_node *node)
>> +static int __init handle_linux_pci_domain(struct kernel_info *kinfo,
>> +                                          const struct dt_device_node *node)
>>   {
>>       uint16_t segment;
>>       int res;
> 
> -- 
> Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 18:56:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 18:56:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427097.675933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaiI-0007Tx-PQ; Thu, 20 Oct 2022 18:56:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427097.675933; Thu, 20 Oct 2022 18:56:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olaiI-0007Tq-MQ; Thu, 20 Oct 2022 18:56:18 +0000
Received: by outflank-mailman (input) for mailman id 427097;
 Thu, 20 Oct 2022 18:56:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olaiH-0007Ta-Fd
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 18:56:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaiH-0006wF-7x; Thu, 20 Oct 2022 18:56:17 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olaiH-0001Vx-2t; Thu, 20 Oct 2022 18:56:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=BsqcKR31UDH75rYIoEOEzJTiJkoyy/xdt4zh7gBfwlc=; b=pxpM4kjq7FEpncF+8WEF5D9FpJ
	K4tOKm/6h3cwBjdFhQkMkccgnDbszNPlmb9aHpyG0S9aDqisV5eIQ/J+Tb59tmpYHSNDCNtR+pXtK
	XxyALJocmUJwAp82ViMVScMdTcreEhfsrQKV34Fu+mNLQU78rUk0/nQ7TPYDvoGvKVDc=;
Message-ID: <921d5899-6ceb-ae0a-00d5-d708fd1dfff4@xen.org>
Date: Thu, 20 Oct 2022 19:56:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
To: Stewart Hildebrand <stewart.hildebrand@amd.com>,
 xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <20221014200926.15250-1-stewart.hildebrand@amd.com>
 <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
 <dda3b199-55ac-d557-b934-c070db8a371e@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <dda3b199-55ac-d557-b934-c070db8a371e@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 20/10/2022 19:53, Stewart Hildebrand wrote:
> On 10/20/22 14:19, Julien Grall wrote:
>> Hi Stewart,
> 
> Hi Julien,
> 
>> I nearly missed this one because it was threaded under v1. In the
>> future, would you be able to send new version in a separate thread? This
>> makes easier to track it.
> 
> I will keep this in mind for next time.
> 
>> On 14/10/2022 21:09, Stewart Hildebrand wrote:
>>> All functions in domain_build.c should be marked __init. This was
>>> spotted when building the hypervisor with -Og.
>>>
>>> Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
> 
> I missed parenthesis and quotes around the referenced commit. To keep it in the same format as other Fixes: tags, can you please add during commit (pending release ack)?

Will do.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 19:07:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 19:07:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427138.675947 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olatG-00013Q-Q1; Thu, 20 Oct 2022 19:07:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427138.675947; Thu, 20 Oct 2022 19:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olatG-00013J-N2; Thu, 20 Oct 2022 19:07:38 +0000
Received: by outflank-mailman (input) for mailman id 427138;
 Thu, 20 Oct 2022 19:07:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olatF-00013D-07
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 19:07:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olatE-0007Av-HD; Thu, 20 Oct 2022 19:07:36 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olatE-00024q-9V; Thu, 20 Oct 2022 19:07:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=AhvJHTyLy5bGSQTzLe5x1QbuD7Qhlb+kNZHuN+b6JO4=; b=P/RgjfsLrE8+9EeYK/ijEpsL75
	FO2xvdJt70A4RIxMXbYnm1fH4BELxwYxn9pW7C1X75wtETngyQwgtbIl6YEOlXDtdfrLwA4/uocgN
	SJ3I/V7euK/tRZdJzhCC3R0AcnisF91GZ/G8S6CcDoBlKXb6DaVWKlVslwIMze7HttvY=;
Message-ID: <810d2df8-baf8-370d-a7b6-0e5ceb74a986@xen.org>
Date: Thu, 20 Oct 2022 20:07:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Stefano Stabellini <sstabellini@kernel.org>, Leo Yan <leo.yan@linaro.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Mathieu Poirier <mathieu.poirier@linaro.org>,
 Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
 jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com,
 wei.liu@kernel.org, paul@xen.org
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
 <Y05w36OAVyDJwCCr@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210181253260.4587@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <alpine.DEB.2.22.394.2210181253260.4587@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 18/10/2022 20:54, Stefano Stabellini wrote:
> On Tue, 18 Oct 2022, Leo Yan wrote:
>> On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote:
>>
>> [...]
>>
>>>> Which means it takes 543us to let Dom0 to receive the notification.
>>>> You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
>>>> not have contention for CPU resources.  Seems to me, it's likely Xen
>>>> hypervisor takes long time to deliver the interrupt, note, it's not
>>>> take so long time for every skb transferring, sometimes the time for
>>>> response a notification is short (about ~10us).
>>>
>>> Good find. I think this is worth investigating further. Do you have
>>> vwfi=native in your Xen command line as well?
>>
>> Yes, I have added "sched=null" and "vwfi=native" into Xen options:
>>
>> options=noreboot dom0_mem=4096M bootscrub=0 iommu=on loglvl=error guest_loglvl=error sched=null vwfi=native
>>
>>> After that, I would add printk also in Xen with the timestamp. The event
>>> channel notification code path is the following:
>>>
>>> # domU side
>>> xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
>>> xen/arch/arm/vgic.c:vgic_to_sgi
>>> xen/arch/arm/vgic.c:vgic_inject_irq
>>> xen/arch/arm/vgic.c:vcpu_kick
>>> xen/arch/arm/gic-v2.c:gicv2_send_SGI
>>>
>>> # dom0 side
>>> xen/arch/arm/gic.c:do_sgi
>>> xen/arch/arm/traps.c:leave_hypervisor_to_guest
>>>
>>> It would be good to understand why sometimes it takes ~10us and some
>>> other times it takes ~540us
>>
>> Thanks a lot for detailed info.
>>
>> Just note, in my platform DomU enables GICv3 driver rather than GICv2.
>> This would be a bit different in the Xen code.  But it should be easy
>> for me to map to vgic-v3 files.
>>
>> I have a question for how to trace Xen system.  Outputting chars to UART
>> is time costy (usually it's millisecond level), it is not friendly to
>> use console for debugging performance issue.  I searched a bit, either
>> "xl dmesg" or xentrace can be used for capturing trace logs, one thing
>> I am not certain is if we can save Xen logs only into log buffer and
>> doesn't output to UART, so that afterwards we can use "xl dmesg" to
>> capture the logs.  Could anyone confirm for this is correct usage with
>> "xl dmesg" or I should use xentrace for this case?
> 
> I am not super familiar about this. But if you take away the console
> entirely from Xen and give it to dom0 only (no dtuart command line
> option to Xen), you should get the behavior you described:
> - no console output because Xen has no console
> - xl dmesg should still work
You are right, xl dmesg will still work. The console is built using a 
ring so if you are using "xl dmesg" you will only get the latest log in 
the ring.

xenconsoled has an option to save the hypervisor log in 
/var/log/xen/hypervisor.log (default path) if you request to dump them. 
This is an option at startup and can be set in the init.d/systemd 
configuration for Xen (see XENCONSOLED_TRACE).

That said, xentrace is better suited if you are looking for low overhead 
tracing. The console is not directly involved in the process and you can 
already benefits from the trace point sprinkled in Xen code (such as the 
scheduling).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 20:08:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 20:08:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427148.675966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olbpu-0007WW-9k; Thu, 20 Oct 2022 20:08:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427148.675966; Thu, 20 Oct 2022 20:08:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olbpu-0007WP-72; Thu, 20 Oct 2022 20:08:14 +0000
Received: by outflank-mailman (input) for mailman id 427148;
 Thu, 20 Oct 2022 20:08:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pcz+=2V=epam.com=prvs=22920ca83a=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1olbpr-0007WJ-OK
 for xen-devel@lists.xenproject.org; Thu, 20 Oct 2022 20:08:12 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9bff67f-50b2-11ed-91b5-6bf2151ebd3b;
 Thu, 20 Oct 2022 22:08:08 +0200 (CEST)
Received: from pps.filterd (m0174678.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29KFOQGN032549;
 Thu, 20 Oct 2022 20:07:56 GMT
Received: from eur03-dba-obe.outbound.protection.outlook.com
 (mail-dbaeur03lp2175.outbound.protection.outlook.com [104.47.51.175])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3kauf4kw24-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 20 Oct 2022 20:07:56 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS8PR03MB8548.eurprd03.prod.outlook.com (2603:10a6:20b:571::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Thu, 20 Oct
 2022 20:07:52 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.035; Thu, 20 Oct 2022
 20:07:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9bff67f-50b2-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O6u3clHtnu1jxJFmCGUkAtJVy2mdIwi/vn9b5cCWlLWBfYQR5UVFPpw+P+Oa9bQUDxzLDSeezldXiKp7Xr9TTOTUXt1COxjDWEKKmSvEPyLLVqkNzOqpmabFSydNdnZrfzdGOvNiIGTA3XUqqLYH3uqL3PydODvQy+9Pd81UElxCTd214eL26EjKSXi70GIa2/gc1GOyMOYE/MN6zZus9DWHK82VFXddvFIyibIlimY8UeCzNBIub8oWrMrNAjlP4hItpG7Wqtudn54o93TFU+PegTUFVjQTlnfk2WBhJ/pmU50GyophQdD3aw1i7PJzy5mCowZudT5gNqBqV4eWfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2m9KnQwL27OE8pu0wCBObFtqMlyfVXgXJeLhr4jyI4s=;
 b=WlajOkDBx/WqnsPYLahc8DEvnIC6fbvjqszLL/EXdalBqCgMehTGOA23l+9GmnN5lDfracwC1JkANn3RaaCLm21mX2YdzNtgEUUsUOaojveFGK02Npk9TGQCgxo6f+feusbqQaQUr81hnCprCnu5tuSh3IYVBCHudh3yTOGeYs2IQRDjQtJgOF2xnLh+F75FDyENs0s2nw8dRjHbMD7uqTPbTvvMTIc2bxM9QBMKkC9m73a47hLFt/ZlnQ2z7nPFoGw1o8/Haz02VNqyC/B38bAbOhk67RCIyGa0neHzwWJa0ThY+FBliP2NmGaj4tHu3VYdMMEfWxaerqvqhPX/Pg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2m9KnQwL27OE8pu0wCBObFtqMlyfVXgXJeLhr4jyI4s=;
 b=OoeYjKWVr6r7nIrPOiRcdVU/jOhT6b0VPv5yml9cPzvb6Tse07R1HP9MeACrZgKjvnygW+D32JMCkfZcah/ItEjiMuHSihWJFesnd4pLhKVjTJIs3m4wfsbxSd8MbND5eLi5RYfeCM4LD6bXxY6b7nYWLlAtEpY97FKWHwlW7gYEyX+AhfYHtb6gfxeYUCWEta5DU9Dsy1wu1UZ5pAH907lcjTnKVySPl/M8a/p3qxYhra+e0TicGB2qy3JnIeYlaoY6bUbDOkw69P3SQLduXpQBbSybNypWMVRrn9XU6bSFpH8XlZSzFBFyi9yJU40yKt7nZbaqa+W+XdhJfLenhA==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr
 Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: 
 AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64U6lSAgACDRYCAALaPgIAA1SMAgABhSgCAAELoAIAAIHAA
Date: Thu, 20 Oct 2022 20:07:52 +0000
Message-ID: <174a4c06-b95a-c817-a400-f33cccd8d545@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
 <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
 <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
 <ded6c520-8f1a-6ee3-bbfa-3de7e1f74779@epam.com>
 <44fdaba0-15eb-0778-bacf-3937a36b0841@gmail.com>
In-Reply-To: <44fdaba0-15eb-0778-bacf-3937a36b0841@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS8PR03MB8548:EE_
x-ms-office365-filtering-correlation-id: c32a919a-14a5-4473-103c-08dab2d6c516
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 YAJ0xyN4oUHgOay2fefOP5YfnfbKayP3yocHdhKMzZd4cmiYXFPVaUIBmz2oJ5ETVjz5KBwvEz50jFNNX4J/WxiuqV0i4yr1bzocWAz3NGYt1GJSnaLl22qwsHZ79JI46zID4O21x8sVXjPxjSvXWl4dA/1wYUB+ttUd053QEXIjMaE38Vw21EGXn8PcmNHpB2wZOzRxAPcsLsceMFzlgN99dTgYshQbfhe6KLixVvol9LbepS90iLUBr3VcnSUJRFmTRz5fcTfT7qYb9DubzUD4O6u8owRbTrWZkLReVkxXU6Rp/vHRmspLkBIQQHcHgndVo1Flsg5KwSbanL9q8DCLhgRsPPxdh6Gf4oAXL3K0weDCnbuqef2KWOX9LtqJszzgKCM4yivpQOf0zWZh/RhQelplBScRuhywKoTxMlVJw/CK0f4q/K7hYuHqDkzW0U72XEK+LMZ2Omz6wb/6JxiZukZVr18M2U1cor7k13rRDe8CdXSZXXG+8PIxtDD+3J6q/w0SNz982twSmCPTh6gZ4su8PZzkycz0wcRR1CfujzG/cb7eR95nRfX+epCPWNgPXUb3flkvrT2A8xTAJnmLyl2Ygi3S3hyt0qEz3RbiICEs7ghzy92XzGClTd3ILEmBshop0sqDNXTPiOOSBt1G3YwZo/HkYpwsxdOm7vSykzZdRAkOw+TPVqVHD2+6UABfrgpi8ymCin2zCgLPT+tysYHBq+jOX/MiBeio2+uTf1fhrqUMswLQdqll/PiXs2vPV8FC4tw7bbXXtgQ1vsAJs9RR6lcWRHEXt2erOZHbFNQcr0MZDr/7ufyxRofyTgyEoHH0Uaa7KqmsHCst+5nP5S7FZTHjv/Zff2Q+6jZip11/K8XQhl29UGc0+WYDgVAZZPWmknvy1cFaOi504A==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(451199015)(54906003)(31686004)(71200400001)(478600001)(6486002)(83380400001)(122000001)(66899015)(966005)(36756003)(86362001)(38100700002)(316002)(6916009)(186003)(38070700005)(2616005)(2906002)(26005)(30864003)(6512007)(41300700001)(31696002)(5660300002)(8676002)(8936002)(4326008)(66476007)(64756008)(53546011)(91956017)(66446008)(55236004)(66556008)(76116006)(66946007)(6506007)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dTVTaWFEWG9HZGYrclpPejRORUxKZmZhQVNGcXdrSDRHSlozZTV2ejFzeTVI?=
 =?utf-8?B?ZmtScU1taGNoRkxiRnBocy9rOXR5SGREQUZhaENFeHlQR2JqWjhWYzRTOHRV?=
 =?utf-8?B?MUpvc2RNb1dOK1JqelFQUWNoZHVBaEN0QStVSjFRQ205UkN2aGtldXY4SEJO?=
 =?utf-8?B?SWIwS3kxQmNXVnhyMXVqQ0tVUTdlT1ZqQ3k0bVg1NnpMVHJ5SUlzalJZb1Na?=
 =?utf-8?B?VjBOb0pxM0xoRit6anQ3a1UxYm8xSCtSY0NVSUtHaEZWbFZHK3JLVE05MEd2?=
 =?utf-8?B?ZDF4aFNOZWdDZHdha1IrelRRclRqSjI5Zk4waHdQck9KVmowbGdXTTl0RE9B?=
 =?utf-8?B?aHZjTFI2RnZQalNJR2dqRktwbmJHOGtkeFhEWUpTK2h6NS9henBqc0xNdWtM?=
 =?utf-8?B?aE1iNUpVN255aklETzNJb3c1YlNlNzJGVjg3Rmlhc1V3STF1c0lyOGZXNmVI?=
 =?utf-8?B?L3Bxc0ZLbDFlNFB4MlQ5UXdmTUpBS1NpWVhrZHVBaXJycWJia0JnMTY2MUkv?=
 =?utf-8?B?bU5DdGFtRHR2cDNNb3NaSllCVDBhU1o3M01XQUJNTi9vMzJkNSs1WHVXRGdn?=
 =?utf-8?B?QWlPUWtHcUkvenZvOHp0UlpMVlZvSXZDazZac2lFdTVsM0tYbWE0dnpGeGlW?=
 =?utf-8?B?eHRSek83NUd5UWVOL3BGVFpkRTBxMHU3dFJrUmg3N3V0YWRNSG54VU5McCsy?=
 =?utf-8?B?V2lwTHNXQ2lRY09yTnp0SitzbWpvZFM5R012ZDlmTGFXNmRESTVPaHRXVGo5?=
 =?utf-8?B?WkpkRnZwVDVMMG9MVnNjWmFLb0FHTkhkR2J2anhDYloyaStaWTNtNzVWbmhT?=
 =?utf-8?B?UW84SGwxT3UzSUZ0VGxQVFR1STVIQlo3MWoyYzFHSEVMdE9vbldkUFRDZnZY?=
 =?utf-8?B?cmlNNW5GOFNMQkdWV2s3VkVVOFBzem9BZWhkSFBtemFHQWNRb1NUYVVPb0pX?=
 =?utf-8?B?dGdVTlM0aVhSSVBpUjZ5bDZSRE56Wm1qa2JlVTJJNUtkemEwajdkeU42a0wr?=
 =?utf-8?B?S3poTzNQc2VOVC8yV3h4MFNyRU95d1AycTRPMzEwOWFHNkJrZk1OSUlYSlpB?=
 =?utf-8?B?TlpSM05wTmUrNDVTYXVqMmFHckR6MnZLSTFxM2JFWjdmU2ZHUHRUTG11ZDRM?=
 =?utf-8?B?SVZXcktMQ3A1eVoyN0hvbjVkdkUzUURMNmtRTG96NzU2OE1hdGIwVktlTHFn?=
 =?utf-8?B?dElGemRlaitYYzN4ZzdGOEIvbzBSZ2xRZTIvNDVlUUVZNENPeGhicnRjaTZI?=
 =?utf-8?B?ekllTFZJMTkwQ0N3Y1djZTZHempoaVNWd2lHbExIQUVtclVUTFhOMDNDSUVX?=
 =?utf-8?B?Vkc4bUo5biswZ1dJYmFwTlU2SVBQd2w1djNOYkRJMFdOYm11aDBxQzQyV3Z6?=
 =?utf-8?B?RVBSSFBzREJlQUNSQzh2enZPUFhYWTkwOHlxd0dPeWhpR2JDUGRVNEJKRVhI?=
 =?utf-8?B?YnhzTHNCOGZaMUJMTThCZkMydk1TK1hwTXNQS2FQZ2VTdThUMHVodFFHMTVw?=
 =?utf-8?B?STNBTUJaMGZEeWdZQjhjVHl0Z1ZLQ1htKzN6a2x2d2FDMC92d1l2SjkwcXJ1?=
 =?utf-8?B?ay9WOEl1Ym9mSGpjTW84eXovZCtiTk85TEtZZi9xOERMZmdFNHlaeFdKaVFw?=
 =?utf-8?B?V09SK2czN1ZLYmNUR0ZmWHdhSG1lL2J5d2tQMjY4NHFFSDNzcjV3OHppRWpt?=
 =?utf-8?B?aUFkT2N1U0dTQjllcWh4UHFoRjdNcG1PclNHbEVsbHlsSnYwSnpzVHVNV0Js?=
 =?utf-8?B?ckt2S0JHVEtRZzRPSzNSbTl5aGlsbXRVNWtqOHZBMThXcGJZRlNGZnA4YkJW?=
 =?utf-8?B?VmhCR1Y0clN4cEZyWFBjaUtkcWN3Wm1qekhPSWYwOGE2V25WS01nZHB0L3BV?=
 =?utf-8?B?NjVWQXU3Zjd0SFpkYmVXeHJySFVROXpaKzIwQ1ZMZ1BxYS83b1JSbkkxTTM5?=
 =?utf-8?B?dERVVGwrMHRtQ0xYUEFUdVp0dVVJTU51azlhSmZlZGVLamthMmxKM3htK2Zi?=
 =?utf-8?B?ZFNBL0dqT1grMEw2N09MWUt6YndOMUU3SG5xOU1DRWJqYitHUDgyd2EwTjgv?=
 =?utf-8?B?elhFWCtlVlpFeFRKS3VRZXVxbWpOdm1iZjgwTkc4RmR3dnc4THYzSXJmd2pP?=
 =?utf-8?B?SDlQeTJqbnRDdlBKOTFqTWx2TjI1VjFzZEVXZkFUTWJNZC9GNHBEVlpyZlZ4?=
 =?utf-8?Q?QJloqXvhHvJ9T0VwOYvpNjY=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <06C07D4DAC2ECA438CB0E345B0662E46@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c32a919a-14a5-4473-103c-08dab2d6c516
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2022 20:07:52.5336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nu30tIOBP6ydFFwxuGS1hp9ZvVZFSvi2GQUnuHEpvkD4mVR6tLjshNfkarGT6+JQK4vp2rdXKLzt1JfB+QaV8/qJxTS9QHyBOft3xEQwQ3A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8548
X-Proofpoint-ORIG-GUID: qBvB8fDB4XEYgwOQpI-L68G8FWpA4oKT
X-Proofpoint-GUID: qBvB8fDB4XEYgwOQpI-L68G8FWpA4oKT
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-20_11,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0
 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501
 lowpriorityscore=0 impostorscore=0 bulkscore=0 suspectscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210200123

DQpPbiAyMC4xMC4yMiAyMToxMSwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KSGVsbG8gWGVu
aWENCg0KDQo+IE9uIDEwLzIwLzIyIDE3OjEyLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4+DQo+PiBPbiAyMC4xMC4yMiAxMToyNCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCj4+PiBP
biAxMC8xOS8yMiAyMjo0MSwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4NCj4+PiBI
aSBPbGVrc2FuZHINCj4+DQo+Pg0KPj4gSGVsbG8gWGVuaWENCj4+DQo+Pg0KPj4+DQo+Pj4+DQo+
Pj4+IE9uIDE5LjEwLjIyIDExOjQ3LCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPj4+Pg0KPj4+
PiBIZWxsbyBYZW5pYQ0KPj4+Pg0KPj4+Pj4gT24gMTAvMTkvMjIgMDM6NTgsIFN0ZWZhbm8gU3Rh
YmVsbGluaSB3cm90ZToNCj4+Pj4+PiBPbiBTYXQsIDE1IE9jdCAyMDIyLCBPbGVrc2FuZHIgVHlz
aGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtz
YW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pj4+Pg0KPj4+Pj4+PiBVc2UgdGhlIHNhbWUg
Inhlbi1ncmFudC1kbWEiIGRldmljZSBjb25jZXB0IGZvciB0aGUgUENJIGRldmljZXMNCj4+Pj4+
Pj4gYmVoaW5kIGRldmljZS10cmVlIGJhc2VkIFBDSSBIb3N0IGNvbnRyb2xsZXIsIGJ1dCB3aXRo
IG9uZQ0KPj4+Pj4+PiBtb2RpZmljYXRpb24uDQo+Pj4+Pj4+IFVubGlrZSBmb3IgcGxhdGZvcm0g
ZGV2aWNlcywgd2UgY2Fubm90IHVzZSBnZW5lcmljIElPTU1VIGJpbmRpbmdzDQo+Pj4+Pj4+IChp
b21tdXMgcHJvcGVydHkpLCBhcyB3ZSBuZWVkIHRvIHN1cHBvcnQgbW9yZSBmbGV4aWJsZSANCj4+
Pj4+Pj4gY29uZmlndXJhdGlvbi4NCj4+Pj4+Pj4gVGhlIHByb2JsZW0gaXMgdGhhdCBQQ0kgZGV2
aWNlcyB1bmRlciB0aGUgc2luZ2xlIFBDSSBIb3N0IA0KPj4+Pj4+PiBjb250cm9sbGVyDQo+Pj4+
Pj4+IG1heSBoYXZlIHRoZSBiYWNrZW5kcyBydW5uaW5nIGluIGRpZmZlcmVudCBYZW4gZG9tYWlu
cyBhbmQgdGh1cyANCj4+Pj4+Pj4gaGF2ZQ0KPj4+Pj4+PiBkaWZmZXJlbnQgZW5kcG9pbnRzIElE
IChiYWNrZW5kIGRvbWFpbnMgSUQpLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBTbyB1c2UgZ2VuZXJpYyBQ
Q0ktSU9NTVUgYmluZGluZ3MgaW5zdGVhZCAoaW9tbXUtbWFwL2lvbW11LW1hcC1tYXNrDQo+Pj4+
Pj4+IHByb3BlcnRpZXMpIHdoaWNoIGFsbG93cyB1cyB0byBkZXNjcmliZSByZWxhdGlvbnNoaXAg
YmV0d2VlbiBQQ0kNCj4+Pj4+Pj4gZGV2aWNlcyBhbmQgYmFja2VuZCBkb21haW5zIElEIHByb3Bl
cmx5Lg0KPj4+Pj4+Pg0KPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5r
byA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+Pj4NCj4+Pj4+PiBOb3cgdGhh
dCBJIHVuZGVyc3Rvb2QgdGhlIGFwcHJvYWNoIGFuZCB0aGUgcmVhc29ucyBmb3IgaXQsIEkgY2Fu
DQo+Pj4+Pj4gcmV2aWV3DQo+Pj4+Pj4gdGhlIHBhdGNoIDotKQ0KPj4+Pj4+DQo+Pj4+Pj4gUGxl
YXNlIGFkZCBhbiBleGFtcGxlIG9mIHRoZSBiaW5kaW5ncyBpbiB0aGUgY29tbWl0IG1lc3NhZ2Uu
DQo+Pj4+Pj4NCj4+Pj4+Pg0KPj4+Pj4+PiAtLS0NCj4+Pj4+Pj4gU2xpZ2h0bHkgUkZDLiBUaGlz
IGlzIG5lZWRlZCB0byBzdXBwb3J0IFhlbiBncmFudCBtYXBwaW5ncyBmb3INCj4+Pj4+Pj4gdmly
dGlvLXBjaSBkZXZpY2VzDQo+Pj4+Pj4+IG9uIEFybSBhdCBzb21lIHBvaW50IGluIHRoZSBmdXR1
cmUuIFRoZSBYZW4gdG9vbHN0YWNrIHNpZGUgaXMgbm90DQo+Pj4+Pj4+IGNvbXBsZXRlbHkgcmVh
ZHkgeWV0Lg0KPj4+Pj4+PiBIZXJlLCBmb3IgUENJIGRldmljZXMgd2UgdXNlIG1vcmUgZmxleGli
bGUgd2F5IHRvIHBhc3MgYmFja2VuZCANCj4+Pj4+Pj4gZG9taWQNCj4+Pj4+Pj4gdG8gdGhlIGd1
ZXN0DQo+Pj4+Pj4+IHRoYW4gZm9yIHBsYXRmb3JtIGRldmljZXMuDQo+Pj4+Pj4+DQo+Pj4+Pj4+
IENoYW5nZXMgVjEgLT4gVjI6DQo+Pj4+Pj4+IMKgwqDCoMKgwqAgLSB1cGRhdGUgY29tbWl0IGRl
c2NyaXB0aW9uDQo+Pj4+Pj4+IMKgwqDCoMKgwqAgLSByZWJhc2UNCj4+Pj4+Pj4gwqDCoMKgwqDC
oCAtIHJld29yayB0byB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5zdGVhZCBvZiBn
ZW5lcmljDQo+Pj4+Pj4+IElPTU1VIGJpbmRpbmdzDQo+Pj4+Pj4+DQo+Pj4+Pj4+IFByZXZpb3Vz
IGRpc2N1c3Npb24gaXMgYXQ6DQo+Pj4+Pj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19o
dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDYxNzQ4MDQuMjAwMzAyOS0x
LW9sZWtzdHlzaEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSEzLXZxN0VkbTNYZkt0RDVj
bk5qbk96RFF2dW9fWHJoSjczeUgtblBmcU9rR0dVMElqTEc3UjdNUl9uQUpDQVBlT3V0SFJMVDQ0
d0tZd1F3ejNTYXVBQ2llX1pBeSQgDQo+Pj4+Pj4+DQo+Pj4+Pj4+DQo+Pj4+Pj4+IFtsb3JlWy5d
a2VybmVsWy5db3JnXQ0KPj4+Pj4+Pg0KPj4+Pj4+PiBCYXNlZCBvbjoNCj4+Pj4+Pj4gaHR0cHM6
Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51
eC9rZXJuZWwvZ2l0L3hlbi90aXAuZ2l0L2xvZy8/aD1mb3ItbGludXMtNi4xX187ISFHRl8yOWRi
Y1FJVUJQQSEzLXZxN0VkbTNYZkt0RDVjbk5qbk96RFF2dW9fWHJoSjczeUgtblBmcU9rR0dVMElq
TEc3UjdNUl9uQUpDQVBlT3V0SFJMVDQ0d0tZd1F3ejNTYXVBRW5NREhBcSQgDQo+Pj4+Pj4+DQo+
Pj4+Pj4+DQo+Pj4+Pj4+IFtnaXRbLl1rZXJuZWxbLl1vcmddDQo+Pj4+Pj4+IC0tLQ0KPj4+Pj4+
PiDCoMKgwqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgODcNCj4+Pj4+Pj4gKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQ0KPj4+Pj4+PiDCoMKgwqAgMSBmaWxlIGNo
YW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQ0KPj4+Pj4+Pg0KPj4+Pj4+
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+Pj4+IGIvZHJp
dmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+Pj4+IGluZGV4IGRhYTUyNWRmN2JkYy4uYjc5
ZDlkNmNlMTU0IDEwMDY0NA0KPj4+Pj4+PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMNCj4+Pj4+Pj4gKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+Pj4+IEBA
IC0xMCw2ICsxMCw3IEBADQo+Pj4+Pj4+IMKgwqDCoCAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+
DQo+Pj4+Pj4+IMKgwqDCoCAjaW5jbHVkZSA8bGludXgvZG1hLW1hcC1vcHMuaD4NCj4+Pj4+Pj4g
wqDCoMKgICNpbmNsdWRlIDxsaW51eC9vZi5oPg0KPj4+Pj4+PiArI2luY2x1ZGUgPGxpbnV4L3Bj
aS5oPg0KPj4+Pj4+PiDCoMKgwqAgI2luY2x1ZGUgPGxpbnV4L3Bmbi5oPg0KPj4+Pj4+PiDCoMKg
wqAgI2luY2x1ZGUgPGxpbnV4L3hhcnJheS5oPg0KPj4+Pj4+PiDCoMKgwqAgI2luY2x1ZGUgPGxp
bnV4L3ZpcnRpb19hbmNob3IuaD4NCj4+Pj4+Pj4gQEAgLTI5MiwxMiArMjkzLDU1IEBAIHN0YXRp
YyBjb25zdCBzdHJ1Y3QgZG1hX21hcF9vcHMNCj4+Pj4+Pj4geGVuX2dyYW50X2RtYV9vcHMgPSB7
DQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgIC5kbWFfc3VwcG9ydGVkID0geGVuX2dyYW50X2RtYV9z
dXBwb3J0ZWQsDQo+Pj4+Pj4+IMKgwqDCoCB9Ow0KPj4+Pj4+PiDCoMKgwqAgK3N0YXRpYyBzdHJ1
Y3QgZGV2aWNlX25vZGUgKnhlbl9kdF9nZXRfcGNpX2hvc3Rfbm9kZShzdHJ1Y3QgDQo+Pj4+Pj4+
IGRldmljZQ0KPj4+Pj4+PiAqZGV2KQ0KPj4+Pj4+PiArew0KPj4+Pj4+PiArwqDCoMKgIHN0cnVj
dCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPj4+Pj4+PiArwqDCoMKgIHN0cnVj
dCBwY2lfYnVzICpidXMgPSBwZGV2LT5idXM7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gK8KgwqDCoCAv
KiBXYWxrIHVwIHRvIHRoZSByb290IGJ1cyB0byBsb29rIGZvciBQQ0kgSG9zdCBjb250cm9sbGVy
ICovDQo+Pj4+Pj4+ICvCoMKgwqAgd2hpbGUgKCFwY2lfaXNfcm9vdF9idXMoYnVzKSkNCj4+Pj4+
Pj4gK8KgwqDCoMKgwqDCoMKgIGJ1cyA9IGJ1cy0+cGFyZW50Ow0KPj4+Pj4+PiArDQo+Pj4+Pj4+
ICvCoMKgwqAgcmV0dXJuIG9mX25vZGVfZ2V0KGJ1cy0+YnJpZGdlLT5wYXJlbnQtPm9mX25vZGUp
Ow0KPj4+Pj4+PiArfQ0KPj4+Pj4+DQo+Pj4+Pj4gSXQgc2VlbXMgc2lsbHkgdGhhdCB3ZSBuZWVk
IHRvIHdhbGsgdGhlIGhpZXJhY2h5IHRoYXQgd2F5LCBidXQgSQ0KPj4+Pj4+IGNvdWxkbid0IGZp
bmQgYW5vdGhlciB3YXkgdG8gZG8gaXQNCj4+Pj4+Pg0KPj4+Pj4+DQo+Pj4+Pj4+ICtzdGF0aWMg
c3RydWN0IGRldmljZV9ub2RlICp4ZW5fZHRfZ2V0X25vZGUoc3RydWN0IGRldmljZSAqZGV2KQ0K
Pj4+Pj4+PiArew0KPj4+Pj4+PiArwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikpDQo+Pj4+Pj4+
ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4geGVuX2R0X2dldF9wY2lfaG9zdF9ub2RlKGRldik7DQo+
Pj4+Pj4+ICsNCj4+Pj4+Pj4gK8KgwqDCoCByZXR1cm4gb2Zfbm9kZV9nZXQoZGV2LT5vZl9ub2Rl
KTsNCj4+Pj4+Pj4gK30NCj4+Pj4+Pj4gKw0KPj4+Pj4+PiArc3RhdGljIGludCB4ZW5fZHRfbWFw
X2lkKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9ub2RlDQo+Pj4+Pj4+ICoqaW9t
bXVfbnAsDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdTMyICpzaWQpDQo+Pj4+
Pj4+ICt7DQo+Pj4+Pj4+ICvCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2
KGRldik7DQo+Pj4+Pj4+ICvCoMKgwqAgdTMyIHJpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51
bWJlciwgcGRldi0+ZGV2Zm4pOw0KPj4+Pj4+PiArwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAq
aG9zdF9ucDsNCj4+Pj4+Pj4gK8KgwqDCoCBpbnQgcmV0Ow0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICvC
oMKgwqAgaG9zdF9ucCA9IHhlbl9kdF9nZXRfcGNpX2hvc3Rfbm9kZShkZXYpOw0KPj4+Pj4+PiAr
wqDCoMKgIGlmICghaG9zdF9ucCkNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5P
REVWOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICvCoMKgwqAgcmV0ID0gb2ZfbWFwX2lkKGhvc3RfbnAs
IHJpZCwgImlvbW11LW1hcCIsICJpb21tdS1tYXAtbWFzayIsDQo+Pj4+Pj4+IGlvbW11X25wLCBz
aWQpOw0KPj4+Pj4+PiArwqDCoMKgIG9mX25vZGVfcHV0KGhvc3RfbnApOw0KPj4+Pj4+PiArwqDC
oMKgIHJldHVybiByZXQ7DQo+Pj4+Pj4+ICt9DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gwqDCoMKgIHN0
YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikN
Cj4+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+Pj4gLcKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKmlv
bW11X25wOw0KPj4+Pj4+PiArwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBO
VUxMOw0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBib29sIGhhc19pb21tdTsNCj4+Pj4+Pj4gwqDC
oMKgIC3CoMKgwqAgaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlv
bW11cyIsIDApOw0KPj4+Pj4+PiArwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+Pj4+
Pj4gK8KgwqDCoMKgwqDCoMKgIGlmICh4ZW5fZHRfbWFwX2lkKGRldiwgJmlvbW11X25wLCBOVUxM
KSkNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOw0KPj4+Pj4+
PiArwqDCoMKgIH0gZWxzZQ0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgaW9tbXVfbnAgPSBvZl9w
YXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPj4+Pj4+PiArDQo+Pj4+
Pj4+IMKgwqDCoMKgwqDCoMKgIGhhc19pb21tdSA9IGlvbW11X25wICYmDQo+Pj4+Pj4+IMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShpb21tdV9u
cCwgInhlbixncmFudC1kbWEiKTsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgb2Zfbm9kZV9wdXQo
aW9tbXVfbnApOw0KPj4+Pj4+PiBAQCAtMzA3LDkgKzM1MSwxNyBAQCBzdGF0aWMgYm9vbCB4ZW5f
aXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QNCj4+Pj4+Pj4gZGV2aWNlICpkZXYpDQo+Pj4+
Pj4+IMKgwqDCoCDCoCBib29sIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2Ug
KmRldikNCj4+Pj4+Pj4gwqDCoMKgIHsNCj4+Pj4+Pj4gK8KgwqDCoCBzdHJ1Y3QgZGV2aWNlX25v
ZGUgKm5wOw0KPj4+Pj4+PiArDQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgIC8qIFhYWCBIYW5kbGUg
b25seSBEVCBkZXZpY2VzIGZvciBub3cgKi8NCj4+Pj4+Pj4gLcKgwqDCoCBpZiAoZGV2LT5vZl9u
b2RlKQ0KPj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHhlbl9pc19kdF9ncmFudF9kbWFf
ZGV2aWNlKGRldik7DQo+Pj4+Pj4+ICvCoMKgwqAgbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsN
Cj4+Pj4+Pj4gK8KgwqDCoCBpZiAobnApIHsNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGJvb2wg
cmV0Ow0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSB4ZW5faXNfZHRf
Z3JhbnRfZG1hX2RldmljZShkZXYpOw0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgb2Zfbm9kZV9w
dXQobnApOw0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsNCj4+Pj4+Pj4gK8Kg
wqDCoCB9DQo+Pj4+Pj4NCj4+Pj4+PiBXZSBkb24ndCBuZWVkIHRvIHdhbGsgdGhlIFBDSSBoaWVy
YWNoeSB0d2ljZS4gTWF5YmUgd2UgY2FuIGFkZCB0aGUNCj4+Pj4+PiBvZl9ub2RlIGNoZWNrIGRp
cmVjdGx5IHRvIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlPw0KPj4+Pj4+DQo+Pj4+Pg0KPj4+
Pj4gSSB0aGluayBpbiBnZW5lcmFsIHdlIGNvdWxkIHBhc3MgZGlyZWN0bHkgdGhlIGhvc3QgYnJp
ZGdlIGRldmljZSBpZg0KPj4+Pj4gZGV2X2lzX3BjaShkZXYpICh3aGljaCBjYW4gYmUgcmV0cmll
dmVkIHdpdGgNCj4+Pj4+IHBjaV9nZXRfaG9zdF9icmlkZ2VfZGV2aWNlKHRvX3BjaV9kZXYoZGV2
KSwgYW5kIGFmdGVyIGRvbmUgd2l0aCBpdA0KPj4+Pj4gcGNpX3B1dF9ob3N0X2JyaWRnZV9kZXZp
Y2UocGhiKSkuDQo+Pj4+PiBTbyB0aGF0LCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZSgpIGFu
ZA0KPj4+Pj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCgpIHdvbid0IG5lZWQgdG8g
ZGlzY292ZXIgaXQgDQo+Pj4+PiB0aGVtc2VsdmVzLg0KPj4+Pj4gVGhpcyB3aWxsIHNpbXBsaWZ5
IHRoZSBjb2RlLg0KPj4+Pg0KPj4+Pg0KPj4+PiBHb29kIHBvaW50LiBJIGhhdmUgc29tZSByZW1h
cmsuIENhbiB3ZSB1c2UgcGNpX2ZpbmRfaG9zdF9icmlkZ2UoKQ0KPj4+PiBpbnN0ZWFkPyBUaGlz
IHdheSB3ZSBkb24ndCBoYXZlIHRvIGFkZCAjaW5jbHVkZSAiLi4vcGNpL3BjaS5oIiwgYW5kIA0K
Pj4+PiBoYXZlDQo+Pj4+IHRvIGRyb3AgcmVmZXJlbmNlIGFmdGVyd2FyZHMuDQo+Pj4+DQo+Pj4+
IFdpdGggdGhhdCB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoKSB3aWxsIGJlY2FtZSB0aGUgZm9s
bG93aW5nOg0KPj4+Pg0KPj4+Pg0KPj4+PiBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlICp4ZW5f
ZHRfZ2V0X3BjaV9ob3N0X25vZGUoc3RydWN0IGRldmljZSANCj4+Pj4gKmRldikNCj4+Pj4gew0K
Pj4+PiDCoMKgIMKgwqAgwqBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UgPQ0KPj4+PiBw
Y2lfZmluZF9ob3N0X2JyaWRnZSh0b19wY2lfZGV2KGRldiktPmJ1cyk7DQo+Pj4+DQo+Pj4+IMKg
wqAgwqDCoCDCoHJldHVybiBvZl9ub2RlX2dldChicmlkZ2UtPmRldi5wYXJlbnQtPm9mX25vZGUp
Ow0KPj4+PiB9DQo+Pj4+DQo+Pj4NCj4+PiBZb3UgYXJlIHJpZ2h0LiBJIHByZWZlciB5b3VyIHZl
cnNpb24gaW5zdGVhZCBvZiB0aGUgYWJvdmUuDQo+Pg0KPj4NCj4+IG9rLCB0aGFua3MNCj4+DQo+
Pg0KPj4+DQo+Pj4NCj4+Pj4NCj4+Pj4gV2l0aCBTdGVmYW5vJ3Mgc3VnZ2VzdGlvbiwgd2Ugd29u
J3Qgd2FsayB0aGUgUENJIGhpZXJhcmNoeSB0d2ljZSB3aGVuDQo+Pj4+IGV4ZWN1dGluZyB4ZW5f
aXNfZ3JhbnRfZG1hX2RldmljZSgpIGZvciBQQ0kgZGV2aWNlOg0KPj4+Pg0KPj4+PiB4ZW5faXNf
Z3JhbnRfZG1hX2RldmljZSgpIC0+IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKCkgLT4NCj4+
Pj4geGVuX2R0X21hcF9pZCgpIC0+IHhlbl9kdF9nZXRfcGNpX2hvc3Rfbm9kZSgpDQo+Pj4+DQo+
Pj4+DQo+Pj4+IFdoYXQgZG8geW91IHRoaW5rPw0KPj4+Pg0KPj4+DQo+Pj4gSSB3YXMgdGhpbmtp
bmcgcGFzc2luZyB0aGUgZGV2aWNlX25vZGUgYWxvbmcgd2l0aCB0aGUgZGV2aWNlIGluIHRoZQ0K
Pj4+IGZ1bmN0aW9uIGFyZ3VtZW50cy4gTW9yZSBzcGVjaWZpY2FsbHksIG9mIGRvaW5nIHRoaXMg
KG5vdCB0ZXN0ZWQsIGp1c3QNCj4+PiBhbiBpZGVhKToNCj4+Pg0KPj4+IGJvb2wgeGVuX2lzX2dy
YW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4+IHsNCj4+PiDCoMKgwqDCoCBz
dHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4+IMKgwqDCoMKgIGJvb2wgaGFzX2lvbW11ID0gZmFs
c2U7DQo+Pj4NCj4+PiDCoMKgwqDCoCAvKiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNlcyBmb3Ig
bm93ICovDQo+Pj4gwqDCoMKgwqAgbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsNCj4+PiDCoMKg
wqDCoCBpZiAobnApDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoCBoYXNfaW9tbXUgPSB4ZW5faXNfZHRf
Z3JhbnRfZG1hX2RldmljZShkZXYsIG5wKTsNCj4+PiDCoMKgwqDCoCBvZl9ub2RlX3B1dChucCk7
DQo+Pj4gwqDCoMKgwqAgcmV0dXJuIGhhc19pb21tdTsNCj4+PiB9DQo+Pj4NCj4+PiBzdGF0aWMg
Ym9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+Pj4g
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApDQo+Pj4gew0KPj4+
IMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBOVUxMOw0KPj4+IMKgwqDC
oMKgIGJvb2wgaGFzX2lvbW11Ow0KPj4+DQo+Pj4gwqDCoMKgwqAgaWYgKGRldl9pc19wY2koZGV2
KSkgew0KPj4+IMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lf
ZGV2KGRldik7DQo+Pj4gwqDCoMKgwqDCoHUzMiBpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51
bWJlciwgcGRldi0+ZGV2Zm4pOw0KPj4+IMKgwqDCoMKgwqDCoMKgwqAgb2ZfbWFwX2lkKG5wLCBp
ZCwgImlvbW11LW1hcCIsICJpb21tdS1tYXAtbWFzayIsICZpb21tdV9ucCwNCj4+PiBOVUxMKTsN
Cj4+PiDCoMKgwqDCoCB9IGVsc2Ugew0KPj4+IMKgwqDCoMKgwqDCoMKgwqAgaW9tbXVfbnAgPSBv
Zl9wYXJzZV9waGFuZGxlKG5wLCAiaW9tbXVzIiwgMCk7DQo+Pj4gwqDCoMKgwqAgfQ0KPj4+DQo+
Pj4gwqDCoMKgwqAgaGFzX2lvbW11ID0gaW9tbXVfbnAgJiYgb2ZfZGV2aWNlX2lzX2NvbXBhdGli
bGUoaW9tbXVfbnAsDQo+Pj4gInhlbixncmFudC1kbWEiKTsNCj4+PiDCoMKgwqDCoCBvZl9ub2Rl
X3B1dChpb21tdV9ucCk7DQo+Pj4NCj4+PiDCoMKgwqDCoCByZXR1cm4gaGFzX2lvbW11Ow0KPj4+
IH0NCj4+DQo+Pg0KPj4gSSBnb3QgaXQuDQo+Pg0KPj4geGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uo
KSBmb3IgVjMgd29uJ3QgY2FsbCB4ZW5fZHRfZ2V0X25vZGUoKSwgYnV0IGNhbGwNCj4+IHhlbl9p
c19kdF9ncmFudF9kbWFfZGV2aWNlKCkgZGlyZWN0bHkuDQo+Pg0KPj4gc3RhdGljIGJvb2wgeGVu
X2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gew0KPj4gwqAg
wqDCoCDCoHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBOVUxMOw0KPj4gwqAgwqDCoCDC
oGJvb2wgaGFzX2lvbW11Ow0KPj4NCj4+IMKgIMKgwqAgwqBpZiAoZGV2X2lzX3BjaShkZXYpKSB7
DQo+PiDCoCDCoMKgIMKgwqDCoMKgIGlmICh4ZW5fZHRfbWFwX2lkKGRldiwgJmlvbW11X25wLCBO
VUxMKSkNCj4+IMKgIMKgwqAgwqDCoMKgwqAgwqDCoMKgIHJldHVybiBmYWxzZTsNCj4+IMKgIMKg
wqAgwqB9IGVsc2UgaWYgKGRldi0+b2Zfbm9kZSkNCj4+IMKgIMKgwqAgwqDCoMKgwqAgaW9tbXVf
bnAgPSBvZl9wYXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPj4gwqAg
wqDCoCDCoGVsc2UNCj4+IMKgIMKgwqAgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOw0KPj4NCj4+IMKg
IMKgwqAgwqBoYXNfaW9tbXUgPSBpb21tdV9ucCAmJg0KPj4gwqAgwqDCoCDCoMKgwqDCoCDCoMKg
wqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQo+
PiDCoCDCoMKgIMKgb2Zfbm9kZV9wdXQoaW9tbXVfbnApOw0KPj4NCj4+IMKgIMKgwqAgwqByZXR1
cm4gaGFzX2lvbW11Ow0KPj4gfQ0KPj4NCj4+IGJvb2wgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uo
c3RydWN0IGRldmljZSAqZGV2KQ0KPj4gew0KPj4gwqAgwqDCoCDCoC8qIFhYWCBIYW5kbGUgb25s
eSBEVCBkZXZpY2VzIGZvciBub3cgKi8NCj4+IMKgIMKgwqAgwqByZXR1cm4geGVuX2lzX2R0X2dy
YW50X2RtYV9kZXZpY2UoZGV2KTsNCj4+IH0NCj4+DQo+Pg0KPg0KPiBPay4gT25lIGRpZmZlcmVu
Y2UsIHRoYXQgSSBzZWUgZnJvbSB0aGUgcHJldmlvdXMsIGlzIHRoYXQgaGVyZSB5b3UgDQo+IGRv
bid0IHVzZSB0aGUgZHluYW1pYyBpbnRlcmZhY2Ugd2hlbiB5b3UgYWNjZXNzIHRoZSBkZXYtPm9m
X25vZGUgDQo+IChvZl9ub2RlX2dldC9vZl9ub2RlX3B1dCkuIEJlZm9yZSwgdGhpcyB3YXMgZ3Vh
cmRlZCB0aHJvdWdoIHRoZSANCj4gZXh0ZXJuYWwgeGVuX2R0X2dldF9ub2RlKCkuDQo+DQo+IEkg
c3VzcGVjdCB0aGF0IHRoZSBzYW1lIG5lZWRzIHRvIGJlIGRvbmUgZm9yIHRoZSBmdW5jdGlvbiAN
Cj4geGVuX2dyYW50X3NldHVwX2RtYV9vcHMoKS4gVGhlcmUsIGFsc28sIHRoZSBjb2RlIHdhbGtz
IHVwIHRvIHRoZSByb290IA0KPiBidXMgdHdpY2UuDQoNCg0KSG1tLCB4ZW5fZHRfZ3JhbnRfaW5p
dF9iYWNrZW5kX2RvbWlkKCkgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGlmIHdlIGRlYWwgDQp3aXRo
IGRldmljZS10cmVlIGJhc2VkIGRldmljZS4NCg0KSSB0aGluayB5b3UgYXJlIGNvbXBsZXRlbHkg
cmlnaHQsIHRoYW5rcyENCg0KSW4gb3JkZXIgdG8gYWRkcmVzcyBib3RoIHlvdXIgY29tbWVudHMs
IEkgdGhpbmsgSSBuZWVkIHRvIHJld29yayB0aGUgDQpjb2RlICh0YWtpbmcgaW50byB0aGUgYWNj
b3VudCB5b3VyIGV4YW1wbGUgd2l0aCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZSgpDQoNCnBy
b3ZpZGVkIGEgZmV3IGxldHRlcnMgYWdvIGFuZCBleHRyYXBvbGF0ZSB0aGlzIGV4YW1wbGUgdG8g
DQp4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKCkpLiBCZWxvdyB0aGUgcGF0Y2ggKG5v
dCB0ZXN0ZWQpIHdoaWNoIA0Kc2VlbXMgdG8gYWRkcmVzcyBib3RoIHlvdXIgY29tbWVudHMgKGFs
c28gSSBkcm9wcGVkDQoNCnhlbl9kdF9tYXBfaWQoKSBhbmQgc3F1YXNoZWQgeGVuX2R0X2dldF9w
Y2lfaG9zdF9ub2RlKCkgd2l0aCANCnhlbl9kdF9nZXRfbm9kZSgpKS4NCg0KDQpkaWZmIC0tZ2l0
IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9w
cy5jDQppbmRleCBkYWE1MjVkZjdiZGMuLmRhZTI0ZGJkMmVmNyAxMDA2NDQNCi0tLSBhL2RyaXZl
cnMveGVuL2dyYW50LWRtYS1vcHMuYw0KKysrIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5j
DQpAQCAtMTAsNiArMTAsNyBAQA0KIMKgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KIMKgI2lu
Y2x1ZGUgPGxpbnV4L2RtYS1tYXAtb3BzLmg+DQogwqAjaW5jbHVkZSA8bGludXgvb2YuaD4NCisj
aW5jbHVkZSA8bGludXgvcGNpLmg+DQogwqAjaW5jbHVkZSA8bGludXgvcGZuLmg+DQogwqAjaW5j
bHVkZSA8bGludXgveGFycmF5Lmg+DQogwqAjaW5jbHVkZSA8bGludXgvdmlydGlvX2FuY2hvci5o
Pg0KQEAgLTI5MiwxMiArMjkzLDMzIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX21hcF9vcHMg
eGVuX2dyYW50X2RtYV9vcHMgPSB7DQogwqDCoMKgwqDCoMKgwqAgLmRtYV9zdXBwb3J0ZWQgPSB4
ZW5fZ3JhbnRfZG1hX3N1cHBvcnRlZCwNCiDCoH07DQoNCi1zdGF0aWMgYm9vbCB4ZW5faXNfZHRf
Z3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQorc3RhdGljIHN0cnVjdCBkZXZp
Y2Vfbm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZpY2UgKmRldikNCiDCoHsNCi3CoMKg
wqDCoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICppb21tdV9ucDsNCivCoMKgwqDCoMKgwqAgaWYg
KGRldl9pc19wY2koZGV2KSkgew0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0
IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UgPSANCnBjaV9maW5kX2hvc3Rf
YnJpZGdlKHBkZXYtPmJ1cyk7DQorDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1
cm4gb2Zfbm9kZV9nZXQoYnJpZGdlLT5kZXYucGFyZW50LT5vZl9ub2RlKTsNCivCoMKgwqDCoMKg
wqAgfQ0KKw0KK8KgwqDCoMKgwqDCoCByZXR1cm4gb2Zfbm9kZV9nZXQoZGV2LT5vZl9ub2RlKTsN
Cit9DQorDQorc3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRl
dmljZSAqZGV2LA0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICpucCkN
Cit7DQorwqDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBOVUxMOw0K
IMKgwqDCoMKgwqDCoMKgIGJvb2wgaGFzX2lvbW11Ow0KDQotwqDCoMKgwqDCoMKgIGlvbW11X25w
ID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21tdXMiLCAwKTsNCivCoMKgwqDC
oMKgwqAgaWYgKGRldl9pc19wY2koZGV2KSkgew0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQorwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCB1MzIgcmlkID0gUENJX0RFVklEKHBkZXYtPmJ1cy0+bnVtYmVyLCBw
ZGV2LT5kZXZmbik7DQorDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAob2ZfbWFw
X2lkKG5wLCByaWQsICJpb21tdS1tYXAiLCAiaW9tbXUtbWFwLW1hc2siLCANCiZpb21tdV9ucCwg
TlVMTCkpDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0
dXJuIGZhbHNlOw0KK8KgwqDCoMKgwqDCoCB9IGVsc2UNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGlvbW11X25wID0gb2ZfcGFyc2VfcGhhbmRsZShucCwgImlvbW11cyIsIDApOw0KKw0K
IMKgwqDCoMKgwqDCoMKgIGhhc19pb21tdSA9IGlvbW11X25wICYmDQogwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfbnAs
ICJ4ZW4sZ3JhbnQtZG1hIik7DQogwqDCoMKgwqDCoMKgwqAgb2Zfbm9kZV9wdXQoaW9tbXVfbnAp
Ow0KQEAgLTMwNyw5ICszMjksMTcgQEAgc3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50X2RtYV9k
ZXZpY2Uoc3RydWN0IA0KZGV2aWNlICpkZXYpDQoNCiDCoGJvb2wgeGVuX2lzX2dyYW50X2RtYV9k
ZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KIMKgew0KK8KgwqDCoMKgwqDCoCBzdHJ1Y3QgZGV2
aWNlX25vZGUgKm5wOw0KKw0KIMKgwqDCoMKgwqDCoMKgIC8qIFhYWCBIYW5kbGUgb25seSBEVCBk
ZXZpY2VzIGZvciBub3cgKi8NCi3CoMKgwqDCoMKgwqAgaWYgKGRldi0+b2Zfbm9kZSkNCi3CoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiB4ZW5faXNfZHRfZ3JhbnRfZG1hX2Rldmlj
ZShkZXYpOw0KK8KgwqDCoMKgwqDCoCBucCA9IHhlbl9kdF9nZXRfbm9kZShkZXYpOw0KK8KgwqDC
oMKgwqDCoCBpZiAobnApIHsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGJvb2wgcmV0
Ow0KKw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0ID0geGVuX2lzX2R0X2dyYW50
X2RtYV9kZXZpY2UoZGV2LCBucCk7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvZl9u
b2RlX3B1dChucCk7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmV0Ow0K
K8KgwqDCoMKgwqDCoCB9DQoNCiDCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQogwqB9DQpA
QCAtMzIzLDE0ICszNTMsMjYgQEAgYm9vbCB4ZW5fdmlydGlvX21lbV9hY2Moc3RydWN0IHZpcnRp
b19kZXZpY2UgKmRldikNCiDCoH0NCg0KIMKgc3RhdGljIGludCB4ZW5fZHRfZ3JhbnRfaW5pdF9i
YWNrZW5kX2RvbWlkKHN0cnVjdCBkZXZpY2UgKmRldiwNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGEpDQogwqB7DQotwqDCoMKgwqDCoMKgIHN0
cnVjdCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYzsNCivCoMKgwqDCoMKgwqAgc3RydWN0IG9m
X3BoYW5kbGVfYXJncyBpb21tdV9zcGVjID0geyAuYXJnc19jb3VudCA9IDEgfTsNCg0KLcKgwqDC
oMKgwqDCoCBpZiAob2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3MoZGV2LT5vZl9ub2RlLCAiaW9t
bXVzIiwgDQoiI2lvbW11LWNlbGxzIiwNCi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCAwLCAmaW9tbXVfc3BlYykpIHsNCi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGRldl9lcnIoZGV2LCAiQ2Fubm90IHBhcnNlIGlvbW11cyBwcm9wZXJ0eVxuIik7DQot
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVTUkNIOw0KK8KgwqDCoMKgwqDC
oCBpZiAoZGV2X2lzX3BjaShkZXYpKSB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBz
dHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2KTsNCivCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHUzMiByaWQgPSBQQ0lfREVWSUQocGRldi0+YnVzLT5udW1iZXIsIHBkZXYt
PmRldmZuKTsNCisNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChvZl9tYXBfaWQo
bnAsIHJpZCwgImlvbW11LW1hcCIsICJpb21tdS1tYXAtbWFzayIsIA0KJmlvbW11X3NwZWMubnAs
DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGlvbW11X3NwZWMuYXJncykpIHsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCBkZXZfZXJyKGRldiwgIkNhbm5vdCB0cmFuc2xhdGUgSURcbiIpOw0K
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVNS
Q0g7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9DQorwqDCoMKgwqDCoMKgIH0gZWxz
ZSB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAob2ZfcGFyc2VfcGhhbmRsZV93
aXRoX2FyZ3MobnAsICJpb21tdXMiLCAiI2lvbW11LWNlbGxzIiwNCivCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMCwgJmlvbW11X3Nw
ZWMpKSB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2
X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCivCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVTUkNIOw0KK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfQ0KIMKgwqDCoMKgwqDCoMKgIH0NCg0KIMKgwqDCoMKg
wqDCoMKgIGlmICghb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfc3BlYy5ucCwgInhlbixn
cmFudC1kbWEiKSB8fA0KQEAgLTM1NCw2ICszOTYsNyBAQCBzdGF0aWMgaW50IHhlbl9kdF9ncmFu
dF9pbml0X2JhY2tlbmRfZG9taWQoc3RydWN0IA0KZGV2aWNlICpkZXYsDQogwqB2b2lkIHhlbl9n
cmFudF9zZXR1cF9kbWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldikNCiDCoHsNCiDCoMKgwqDCoMKg
wqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KK8KgwqDCoMKgwqDCoCBzdHJ1
Y3QgZGV2aWNlX25vZGUgKm5wOw0KDQogwqDCoMKgwqDCoMKgwqAgZGF0YSA9IGZpbmRfeGVuX2dy
YW50X2RtYV9kYXRhKGRldik7DQogwqDCoMKgwqDCoMKgwqAgaWYgKGRhdGEpIHsNCkBAIC0zNjUs
OCArNDA4LDEzIEBAIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAq
ZGV2KQ0KIMKgwqDCoMKgwqDCoMKgIGlmICghZGF0YSkNCiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgZ290byBlcnI7DQoNCi3CoMKgwqDCoMKgwqAgaWYgKGRldi0+b2Zfbm9kZSkgew0K
LcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9kdF9ncmFudF9pbml0X2JhY2tl
bmRfZG9taWQoZGV2LCBkYXRhKSkNCivCoMKgwqDCoMKgwqAgbnAgPSB4ZW5fZHRfZ2V0X25vZGUo
ZGV2KTsNCivCoMKgwqDCoMKgwqAgaWYgKG5wKSB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCBpbnQgcmV0Ow0KKw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0ID0geGVu
X2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYsIG5wLCBkYXRhKTsNCivCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIG9mX25vZGVfcHV0KG5wKTsNCivCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIGlmIChyZXQpDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBnb3RvIGVycjsNCiDCoMKgwqDCoMKgwqDCoCB9IGVsc2UgaWYgKElTX0VOQUJM
RUQoQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQpKSB7DQogwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIGRldl9pbmZvKGRldiwgIlVzaW5nIGRvbTAgYXMgYmFja2VuZFxuIik7DQoN
Cg0KRG9lcyBpdCBsb29rIG9rIG5vdz8NCg0KDQo+DQo+DQo+Pj4NCj4+PiBJICdtIHdvbmRlcmlu
ZyAuLi4gaXMgaXQgcG9zc2libGUgZm9yIHRoZSBob3N0IGJyaWRnZSBkZXZpY2Ugbm9kZSB0bw0K
Pj4+IGhhdmUgdGhlIGlvbW11cyBwcm9wZXJ0eSBzZXQ/IG1lYW5pbmcgdGhhdCBhbGwgb2YgaXRz
IHBjaSBkZXZzIHdpbGwNCj4+PiBoYXZlIHRoZSBzYW1lIGJhY2tlbmQ/DQo+Pg0KPj4gR29vZCBx
dWVzdGlvbi4gSSB0aGluaywgaXQgaXMgcG9zc2libGUuLi4gVGhpcyBpcyB0ZWNobmljYWxseSB3
aGF0IFYxIGlzDQo+PiBkb2luZy4NCj4+DQo+Pg0KPj4gQXJlIHlvdSBhc2tpbmcgYmVjYXVzZSB0
byBzdXBwb3J0ICJpb21tdXMiIGZvciBQQ0kgZGV2aWNlcyBhcyB3ZWxsIHRvDQo+PiBkZXNjcmli
ZSB0aGF0IHVzZS1jYXNlIHdpdGggYWxsIFBDSSBkZXZpY2VzIGhhdmluZyB0aGUgc2FtZSBlbmRw
b2ludCBJRA0KPj4gKGJhY2tlbmQgSUQpPw0KPj4gSWYgeWVzLCBJIHRoaW5rLCB0aGlzIGNvdWxk
IGJlIHN0aWxsIGRlc2NyaWJlZCBieSAiaW9tbXUtbWFwIiBwcm9wZXJ0eSwNCj4+IHNvbWV0aGlu
ZyBsaWtlIHRoYXQgKGlmIHdlIGRvbid0IHdhbnQgdG8gZGVzY3JpYmUgbWFwcGluZyBmb3IgZWFj
aCBQQ0kNCj4+IGRldmljZSBvbmUtYnktb25lKS4NCj4+DQo+PiBpb21tdS1tYXAgPSA8MHgwICZp
b21tdSBYIDB4MT47DQo+Pg0KPj4gaW9tbXUtbWFwLW1hc2sgPSA8MHgwPjsNCj4+DQo+PiB3aGVy
ZSB0aGUgWCBpcyBiYWNrZW5kIElELg0KPj4NCj4+DQo+PiBJdCBmZWVscyB0byBtZSB0aGF0IGl0
IHNob3VsZCBiZSB3cml0dGVuIGRvd24gc29tZXdoZXJlIHRoYXQgZm9yDQo+PiBwbGF0Zm9ybSBk
ZXZpY2VzIHdlIGV4cGVjdCAiaW9tbXVzIiBhbmQgZm9yIFBDSSBkZXZpY2VzIHdlIGV4cGVjdA0K
Pj4gImlvbW11LW1hcC9pb21tdS1tYXAtbWFzayIgdG8gYmUgcHJlc2VudC4NCj4NCj4gVGhhbmtz
IGZvciB0aGUgY2xhcmlmaWNhdGlvbiwgbm93IEkgZ290IGl0LiBZZXMgSSBhZ3JlZS4NCg0KDQpv
aywgZ29vZA0KDQoNCj4NCj4+Pg0KPj4+DQo+Pj4+Pg0KPj4+Pj4+DQo+Pj4+Pj4+IMKgwqDCoMKg
wqDCoMKgIHJldHVybiBmYWxzZTsNCj4+Pj4+Pj4gwqDCoMKgIH0NCj4+Pj4+Pj4gQEAgLTMyNSwx
MiArMzc3LDE5IEBAIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0cnVjdCB2aXJ0aW9fZGV2aWNl
DQo+Pj4+Pj4+ICpkZXYpDQo+Pj4+Pj4+IMKgwqDCoCBzdGF0aWMgaW50IHhlbl9kdF9ncmFudF9p
bml0X2JhY2tlbmRfZG9taWQoc3RydWN0IGRldmljZSAqZGV2LA0KPj4+Pj4+PiDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3Jh
bnRfZG1hX2RhdGEgKmRhdGEpDQo+Pj4+Pj4+IMKgwqDCoCB7DQo+Pj4+Pj4+IC3CoMKgwqAgc3Ry
dWN0IG9mX3BoYW5kbGVfYXJncyBpb21tdV9zcGVjOw0KPj4+Pj4+PiArwqDCoMKgIHN0cnVjdCBv
Zl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYyA9IHsgLmFyZ3NfY291bnQgPSAxIH07DQo+Pj4+Pj4+
IMKgwqDCoCAtwqDCoMKgIGlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25v
ZGUsICJpb21tdXMiLA0KPj4+Pj4+PiAiI2lvbW11LWNlbGxzIiwNCj4+Pj4+Pj4gLcKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDC
oCBkZXZfZXJyKGRldiwgIkNhbm5vdCBwYXJzZSBpb21tdXMgcHJvcGVydHlcbiIpOw0KPj4+Pj4+
PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FU1JDSDsNCj4+Pj4+Pj4gK8KgwqDCoCBpZiAoZGV2
X2lzX3BjaShkZXYpKSB7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoeGVuX2R0X21hcF9p
ZChkZXYsICZpb21tdV9zcGVjLm5wLCBpb21tdV9zcGVjLmFyZ3MpKSB7DQo+Pj4+Pj4+ICvCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIGRldl9lcnIoZGV2LCAiQ2Fubm90IHRyYW5zbGF0ZSBJRFxuIik7
DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVNSQ0g7DQo+Pj4+Pj4+
ICvCoMKgwqDCoMKgwqDCoCB9DQo+Pj4+Pj4+ICvCoMKgwqAgfSBlbHNlIHsNCj4+Pj4+Pj4gK8Kg
wqDCoMKgwqDCoMKgIGlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYtPm9mX25vZGUs
ICJpb21tdXMiLA0KPj4+Pj4+PiAiI2lvbW11LWNlbGxzIiwNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAwLCAmaW9tbXVfc3BlYykpIHsNCj4+Pj4+Pj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5
XG4iKTsNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FU1JDSDsNCj4+
Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIH0NCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgfQ0KPj4+Pj4+
PiDCoMKgwqAgwqDCoMKgwqDCoCBpZiAoIW9mX2RldmljZV9pc19jb21wYXRpYmxlKGlvbW11X3Nw
ZWMubnAsDQo+Pj4+Pj4+ICJ4ZW4sZ3JhbnQtZG1hIikgfHwNCj4+Pj4+Pj4gQEAgLTM1NCw2ICs0
MTMsNyBAQCBzdGF0aWMgaW50DQo+Pj4+Pj4+IHhlbl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9t
aWQoc3RydWN0IGRldmljZSAqZGV2LA0KPj4+Pj4+PiDCoMKgwqAgdm9pZCB4ZW5fZ3JhbnRfc2V0
dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+Pj4+IMKgwqDCoCB7DQo+Pj4+Pj4+
IMKgwqDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGE7DQo+Pj4+Pj4+
ICvCoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICpucDsNCj4+Pj4+Pj4gwqDCoMKgIMKgwqDCoMKg
wqAgZGF0YSA9IGZpbmRfeGVuX2dyYW50X2RtYV9kYXRhKGRldik7DQo+Pj4+Pj4+IMKgwqDCoMKg
wqDCoMKgIGlmIChkYXRhKSB7DQo+Pj4+Pj4+IEBAIC0zNjUsOCArNDI1LDEzIEBAIHZvaWQgeGVu
X2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSANCj4+Pj4+Pj4gKmRldikNCj4+Pj4+
Pj4gwqDCoMKgwqDCoMKgwqAgaWYgKCFkYXRhKQ0KPj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIGdvdG8gZXJyOw0KPj4+Pj4+PiDCoMKgwqAgLcKgwqDCoCBpZiAoZGV2LT5vZl9ub2RlKSB7
DQo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAoeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9k
b21pZChkZXYsIGRhdGEpKQ0KPj4+Pj4+PiArwqDCoMKgIG5wID0geGVuX2R0X2dldF9ub2RlKGRl
dik7DQo+Pj4+Pj4+ICvCoMKgwqAgaWYgKG5wKSB7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBp
bnQgcmV0Ow0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSB4ZW5fZHRf
Z3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSk7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKg
wqDCoCBvZl9ub2RlX3B1dChucCk7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAocmV0KQ0K
Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBlcnI7DQo+Pj4+Pj4+
IMKgwqDCoMKgwqDCoMKgIH0gZWxzZSBpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJT19G
T1JDRV9HUkFOVCkpIHsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkZXZfaW5mbyhk
ZXYsICJVc2luZyBkb20wIGFzIGJhY2tlbmRcbiIpOw0KPj4+Pj4+PiAtLSANCj4+Pj4+Pj4gMi4y
NS4xDQo+Pj4+Pj4+DQo+Pj4+Pj4NCj4+Pj4+DQo+Pj4NCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xl
a3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 20:28:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 20:28:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427196.676002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olc9i-0002kt-Hz; Thu, 20 Oct 2022 20:28:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427196.676002; Thu, 20 Oct 2022 20:28:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olc9i-0002km-Eb; Thu, 20 Oct 2022 20:28:42 +0000
Received: by outflank-mailman (input) for mailman id 427196;
 Thu, 20 Oct 2022 20:28:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olc9g-0002kb-Tk; Thu, 20 Oct 2022 20:28:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olc9g-0000Iq-Sf; Thu, 20 Oct 2022 20:28:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olc9g-00070Q-G6; Thu, 20 Oct 2022 20:28:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olc9g-00052k-Fe; Thu, 20 Oct 2022 20:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LC1VdF30TNIgT3T7/6e0rtGCyo98tFxJczej3Re34qE=; b=HetArZxKdoWz/J+4xO+91fO9xG
	Enz2G919UZzQMIMzWf6hFrQu4zIfi3mGPnmznn4KCQFzuWTlRgGx6FoUl2DB1RxnI7eSaSD2e27CR
	75BYMSInbYLhkfM/HXVWe8KgeyBQLaXR2p4tIzJR2Wt0mQuLivwAV2AMakTCf5ljBtjA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174146-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174146: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0c06760be3dc3f286015e18c4b1d1694e55da026
X-Osstest-Versions-That:
    xen=7110192b1df697be84a50f741651d4c3cb129504
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 20:28:40 +0000

flight 174146 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174146/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  0c06760be3dc3f286015e18c4b1d1694e55da026
baseline version:
 xen                  7110192b1df697be84a50f741651d4c3cb129504

Last test of basis   174139  2022-10-20 15:00:31 Z    0 days
Testing same since   174146  2022-10-20 18:02:03 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Peter Hoyes <Peter.Hoyes@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   7110192b1d..0c06760be3  0c06760be3dc3f286015e18c4b1d1694e55da026 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 21:00:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 21:00:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427204.676013 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olceL-00074a-2d; Thu, 20 Oct 2022 21:00:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427204.676013; Thu, 20 Oct 2022 21:00:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olceK-00074T-UR; Thu, 20 Oct 2022 21:00:20 +0000
Received: by outflank-mailman (input) for mailman id 427204;
 Thu, 20 Oct 2022 21:00:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olceJ-00074J-Ev; Thu, 20 Oct 2022 21:00:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olceJ-0000rh-A4; Thu, 20 Oct 2022 21:00:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olceI-0000QJ-Ow; Thu, 20 Oct 2022 21:00:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olceI-0003F8-OS; Thu, 20 Oct 2022 21:00:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6raqDawWlsFmy1eZsMbz0klL5gCYWsMqOlhOHQrM540=; b=Ok2C72/JqZqYr9lu+c3eT2YP5T
	/d4d1sYwNGMRlRjTa+9r7amEFx9a0uzwmxWSbXgrL5h25gpscW8Q/rUXfH/jZQfBmBTPvNAjm6Raa
	BysghEstSyyqEWXo++gTpl+enZsd2XYB3Wv7GF3HCKVOu1N30tvpeb7ee2uRZRzX0GcQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174126-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174126: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 21:00:18 +0000

flight 174126 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174126/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd   12 debian-di-install fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start   fail in 173935 REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start    fail in 173935 REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173935 REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start  fail in 173935 REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174126
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start    fail in 173935 REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   66 days
Failing since        173495  2022-10-11 14:08:01 Z    9 days   10 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    7 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 20 22:34:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 20 Oct 2022 22:34:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427216.676036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ole7K-00088B-Te; Thu, 20 Oct 2022 22:34:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427216.676036; Thu, 20 Oct 2022 22:34:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ole7K-000884-R1; Thu, 20 Oct 2022 22:34:22 +0000
Received: by outflank-mailman (input) for mailman id 427216;
 Thu, 20 Oct 2022 22:34:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ole7J-00087u-Ck; Thu, 20 Oct 2022 22:34:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ole7J-0002UM-2r; Thu, 20 Oct 2022 22:34:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ole7I-0005l7-Re; Thu, 20 Oct 2022 22:34:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ole7I-0008SC-RA; Thu, 20 Oct 2022 22:34:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Orr8IKVAOhWSSYTsRGMWaXV5aBU5oaxDqrqRwa744po=; b=wIMDhL3qNOENGjBANmOXO3u4Tx
	eMguGxr1KKk4YO3+d++n7ZrvBi6NE7N06B3X+/FkFoBe9/PqpqU/yWKGo3Zf2hODgIAX/TZ0YVlFu
	C82SrOo3k8+XPeisnyL5s3JzKxcQOWi//y0zbp9HmQESubhdlxVlqMgHvNzDX6LZBWVM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174060-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174060: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-credit1:guest-saverestore:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=214a8da23651f2472b296b3293e619fd58d9e212
X-Osstest-Versions-That:
    qemuu=8823ef1336d6c4af1a6ccdcaa8f5c0b756f3a875
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 20 Oct 2022 22:34:20 +0000

flight 174060 qemu-mainline real [real]
flight 174151 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174060/
http://logs.test-lab.xenproject.org/osstest/logs/174151/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-shadow     7 xen-install         fail pass in 174151-retest
 test-amd64-amd64-xl-credit1  17 guest-saverestore   fail pass in 174151-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174030
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174030
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174030
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174030
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174030
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt   16 saverestore-support-check fail starved in 174030
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 174030
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 174030

version targeted for testing:
 qemuu                214a8da23651f2472b296b3293e619fd58d9e212
baseline version:
 qemuu                8823ef1336d6c4af1a6ccdcaa8f5c0b756f3a875

Last test of basis   174030  2022-10-18 02:12:43 Z    2 days
Testing same since   174060  2022-10-18 20:37:04 Z    2 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  BALATON Zoltan <balaton@eik.bme.hu>
  Bernhard Beschow <shentey@gmail.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Dr. David Alan Gilbert <dgilbert@redhat.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Nicholas Piggin <npiggin@gmail.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Brook <paul@nowt.org>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Venu Busireddy <venu.busireddy@oracle.com>
  Víctor Colombo <victor.colombo@eldorado.org.br>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   8823ef1336..214a8da236  214a8da23651f2472b296b3293e619fd58d9e212 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 01:42:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 01:42:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427242.676098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olh3d-0001HX-My; Fri, 21 Oct 2022 01:42:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427242.676098; Fri, 21 Oct 2022 01:42:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olh3d-0001HP-Gx; Fri, 21 Oct 2022 01:42:45 +0000
Received: by outflank-mailman (input) for mailman id 427242;
 Fri, 21 Oct 2022 01:42:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olh3b-0001HJ-LQ
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 01:42:43 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a607f860-50e1-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 03:42:40 +0200 (CEST)
Received: from AS9PR06CA0268.eurprd06.prod.outlook.com (2603:10a6:20b:45f::19)
 by GVXPR08MB7677.eurprd08.prod.outlook.com (2603:10a6:150:3f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Fri, 21 Oct
 2022 01:42:26 +0000
Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45f:cafe::89) by AS9PR06CA0268.outlook.office365.com
 (2603:10a6:20b:45f::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.36 via Frontend
 Transport; Fri, 21 Oct 2022 01:42:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Fri, 21 Oct 2022 01:42:25 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Fri, 21 Oct 2022 01:42:25 +0000
Received: from ec79e479841d.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6018516B-0CB9-4206-9FF6-36523138E467.1; 
 Fri, 21 Oct 2022 01:42:19 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec79e479841d.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 01:42:19 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV2PR08MB8270.eurprd08.prod.outlook.com (2603:10a6:150:c1::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 01:42:16 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 01:42:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a607f860-50e1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=fHmTPnNrd1F121E45dE5ELJ8Ynas+Dr7YxUWQwWOGXI+lZF6UENWibwVI8ZfKc61FzVETfy57CKEvU4P8CWdf1L4lFZnPTLupxyNgpdFgzlPbdQ9cHACvSpQG6BExdMIUwKya0cbmYcviXZ2hqJ7WdQdiBJFg9EFaPhSdXEpaZ5bFKSXt6RrlGIRkwPFbZxhZolLAUgbYoo0PaaGHxv4FTO0pluBuQOXpWYoxsjfKAoWVPCn5lh3ncAqm566JXxqUuv2F+kAiFAMWxgPXb1VbH7wIMlVh8oKaXI1+UkHi64k91BEQU5kDOHPar0OigLanMea5xtP8dPXKZNtj93pKA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V/1RPnpsGavWjGJhRUzThYIsnin48ASuOThSJCsGEbc=;
 b=HTR9byBsRv3n5Ys0Y17mcCXYieAH2K4cxzeWknMTfo44nBD3Nhv3caoLLvinRKMSNBASKQ51nZx9SdvRK7zdAjZ1bOvYi3bVOlEB8qabA8cWBt1WevIPgo1bkM06irMMoGwzZRIex6xD9qEa1z5+UArYaqWHoGQHPx6k+Dsh/SdPmx/sun0Mlsxs0HGDvWStrJIvbxSA8KxP1YzXXMtJHWqMKVePI2pR6GFv+tqEvc18EfN1lnaVZ2w9vjz35mbd8Bqe2dBNQ2Vxv/aE8HvwHeu288ucYSiQ/GbG5mL6dMdB6oGly9QRfr7mEcWEZ2M2wxCXa1m1E2AkBZcLLZgIBQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V/1RPnpsGavWjGJhRUzThYIsnin48ASuOThSJCsGEbc=;
 b=5IWgGUhuafxXs+t1HpXeUY1S8QzAKeNrsP1GbXxWlUeE7vNsMpz3s0Ev9Bk3wsHAAQ/t/OBcS6S/TYae9+YgshCflo4sjcWmKq963JDx87QD919+6afzFl2ekLoqh2dYAVPYpi7zSe/ZHbTbbTpO5ZSJUNwxAAJ/Ue4F6iBDaJ8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QH4XRpZxX3dSBuc8KVXnSXLYis1I/5wiNDC0dIjTRrAX9s+a302h+MJaBtQjVkUMo37lR/tkHeeu5Z+RGm8SuUXTgjFT7LaUfDXgg7RlksC/6j/vXyaSQObVFg4FG3ob5bLp9yzH1KEHBEePKHY6RxBZFLvLYYliw68TbsEyWvE69yJ1aqhdQtQu6RwCj0tQR8BpnETpH2qB/ys3vuXGJVZvGH9L9mzbhLzZg6A9CRacsj1H8mz1Eghx/s+LSvxWGJ+qEo1NPE4xPXRf6mZZ1UPYfIdBvo5NksdYRDKa3xxzKMeQi4eUlLq4cDExbE4sZ4CRvpeX4Rk8RP1nwSXb3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V/1RPnpsGavWjGJhRUzThYIsnin48ASuOThSJCsGEbc=;
 b=Sme/Zem0aQxXPxD+hpKHnziP7hm7euYHR1j3xtRvLRmItQSjnMiLUrRtzHD2ImpjoMXb8mVtpAqoiPUEC+Sc3yIl2jo/wCo4fxKU5qYzVDx3yz/0nrb22k3gPCtV5CGSKOUTQ3aMLSX7rBpA/vANVMaNbuUdou43yaXzisyEYQBMY8ytisZkdOCXy1WnsxkYNX73drCzlRHZ192+pBVG2YUAPrFnYjy4nQdN2/9drNsgfq81N3fE8Pev36iEvs+JNpFktGE1+zVdvsyG0S7yqoJ4q9IMd+22yXv4J5BLZoWjJA5qfKux+gMGzTtqJDKmDvcz5AWHBkgn9HY7gBspLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V/1RPnpsGavWjGJhRUzThYIsnin48ASuOThSJCsGEbc=;
 b=5IWgGUhuafxXs+t1HpXeUY1S8QzAKeNrsP1GbXxWlUeE7vNsMpz3s0Ev9Bk3wsHAAQ/t/OBcS6S/TYae9+YgshCflo4sjcWmKq963JDx87QD919+6afzFl2ekLoqh2dYAVPYpi7zSe/ZHbTbbTpO5ZSJUNwxAAJ/Ue4F6iBDaJ8=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Xenia Ragiadakou <burzalodowa@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [4.17] RE: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit pa
 range
Thread-Topic: [4.17] RE: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit
 pa range
Thread-Index: AQHY48oesrLPZOyAMkGfn+0zDPtusq4Xl4aAgAB9ksA=
Date: Fri, 21 Oct 2022 01:42:16 +0000
Message-ID:
 <AS8PR08MB7991AE87BC1FF9E47A3F9F9D922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221019144913.291677-1-burzalodowa@gmail.com>
 <c3ecb453-ac2e-fd0d-d5ca-3f485d7f53a3@xen.org>
In-Reply-To: <c3ecb453-ac2e-fd0d-d5ca-3f485d7f53a3@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B0FD4328577CEB46B28E98B29835CB00.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV2PR08MB8270:EE_|AM7EUR03FT030:EE_|GVXPR08MB7677:EE_
X-MS-Office365-Filtering-Correlation-Id: cbba477a-3cea-4326-ab0b-08dab30581b4
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 s80SzlepkNCAVKC5b8ziX3NnJaPvbGcD7jVi55bM0mvked2Sz6S5pYETM518E7INcyGT3DXu2u0f0rXNW3J9QZeDnuLE7y7LsYbCEBzpraPMGtMpuJwy/4Yi0+rdrdyrkouBinnVE6r4cC06cX4kdZ2rDp/1VNebZGAwtiws2qYePMAwBBCsF4u4cGR/0CYsSa3J2i6IYPTBPao8wVkpfp1sn6A/BKOcP2kxuHn+KI1ash97zZve4TanxQJZLG1zvmoDlKxX+aKGauvW6GlHc+ECXfsMX7q/WMliyl8xAxe+ftgiikfrtcX8BVebQeFrMBLjQF+ulJKMozXbhyEluPsggi+v6U7M3An1Pm1E48otr8bzw6dQkZU8plO+3ch3A37obp1acv8h6Pyzw0ssit8bbvkPN5bilo9i2Ae+15U/2f3Flqp+7UDcjKjHBG8++6T5IbVzGSbF9FpVmU59n3XzlshHB534cRjnfpcBkSATn6bGcOSDRnXmGEPPhaBRIhGNAyA0n2Gle5kY8CszaMm81JQ9Cr0oC+N4Q5pIkH5knpq6n1OAqqncvFn1x25YLgRA+pjGJl2bpENqcOkelUX7XN7fXtJth9yB/f0HNNARvN2b1TKrR5WTH5YhwWTiJZdKlPkv54nmFi9LJ7GG12y4KxdtEgoLudBIBnjSO3XG8hOZIV2lEOeP7tDPkiPVvFWT5j/oCwpxDbECx5P6ySFLSY/QvmDtrSYsc0P1uk89KWkJbYnf6d8jUsJMKdAsvZtmnLIOihk3Pcmb2AKmHw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(451199015)(6506007)(186003)(7696005)(83380400001)(2906002)(5660300002)(9686003)(26005)(55016003)(54906003)(76116006)(8936002)(478600001)(8676002)(71200400001)(64756008)(52536014)(66476007)(66446008)(66946007)(4326008)(41300700001)(66556008)(110136005)(316002)(53546011)(86362001)(33656002)(38100700002)(38070700005)(122000001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8270
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9ddc5056-b1f3-4186-1f2b-08dab3057bed
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	j6Jl6D1yjf3VMa5jDqhRllUC4NTaKMI2q5arVS8IsV39NPJRsNEHHHyUSMC+BeCLlXJOgD4NvlE9oMRnMyHdEBdM9dxXPNS662O864Buuq3xtU2hvyuNXpzRuaQFTqE7E492BmL91FdWmkZb+PzfzcPtQkZoyyUSqHLOK0dcWTHH1SNRO41gviuDX8Le/VSW0LY5rfVyJHSBSfFUXcQe2APh5oKaeBJ96MzE6zZlcJZJw4uzGctZplvEnMqygntUXysPjo65DUKwq9tU2ZLYszEKuHHe7rN6XMZ5fX02c918jm8ek64XhfhJEOFV+o1ahCkaZJZpQ19uYz+dHHRZ3nfGTCPkNIpKfMwUC52OPGUj/JgoJCiyb9vZvBwauH7cYJnxE64PfQNt7j4P4r9gEFQ9IdM1E72tWJFX6QWmCrBaW846n7lqcpIVos5fKIf+6FWAaBJOmIZ3N1ZwJTyFC5LPrPxLOhysF3eN38irlYYS8wEkdknmI9GbWltJ9OOx/RJlvBg6uBiJN0bXf3HGSfU9cbV9ZeJsI18PiuJGez1zRdJgxMQwvgzBrlCM2AnxvbwHNx2mkKVzwETpKrwt1KXSXL8aETqKK3YjvDkydyHsMEimXnO5+x5Ebtj37lnf56VvhExU9EfWHYazrGECnzpwcJBBmGPCApccIjyFC1c1rGj1jD6uJgfowoDPlujDqZskPpEI2cmSM49unj/2v+3TgpUiaxXlWe6qTv2rrELnIFtOxEX83uPgbLZPEesVhfL3ywX1tdMFp+MAopvulw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199015)(36840700001)(46966006)(40470700004)(186003)(478600001)(26005)(41300700001)(53546011)(336012)(40460700003)(107886003)(9686003)(6506007)(82310400005)(4326008)(33656002)(52536014)(8936002)(86362001)(5660300002)(47076005)(7696005)(54906003)(2906002)(316002)(82740400003)(40480700001)(110136005)(36860700001)(55016003)(8676002)(81166007)(70206006)(83380400001)(70586007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 01:42:25.8031
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cbba477a-3cea-4326-ab0b-08dab30581b4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7677

SGkgSnVsaWVuIGFuZCBYZW5pYSwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBG
cm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA8Vm9sb2R5bXlyX0JhYmNodWtA
ZXBhbS5jb20+OyBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IFN1YmplY3Q6IFJl
OiBbUEFUQ0ggdjJdIHhlbi9hcm06IHAybTogZml4IHBhX3JhbmdlX2luZm8gZm9yIDUyLWJpdCBw
YSByYW5nZQ0KPiANCj4gKCsgSGVucnkpDQo+IA0KPiBIaSBYZW5pYSwNCj4gDQo+IE9uIDE5LzEw
LzIwMjIgMTU6NDksIFhlbmlhIFJhZ2lhZGFrb3Ugd3JvdGU6DQo+ID4gQ3VycmVudGx5LCB0aGUg
ZmllbGRzICdyb290X29yZGVyJyBhbmQgJ3NsMCcgb2YgdGhlIHBhX3JhbmdlX2luZm8gZm9yDQo+
ID4gdGhlIDUyLWJpdCBwYSByYW5nZSBoYXZlIHRoZSB2YWx1ZXMgMyBhbmQgMywgcmVzcGVjdGl2
ZWx5Lg0KPiA+IFRoaXMgY29uZmlndXJhdGlvbiBkb2VzIG5vdCBtYXRjaCBhbnkgb2YgdGhlIHZh
bGlkIHJvb3QgdGFibGUgY29uZmlndXJhdGlvbnMNCj4gPiBmb3IgNEtCIGdyYW51bGUgYW5kIHQw
c3ogMTIsIGRlc2NyaWJlZCBpbiBBUk0gRERJIDA0ODdJLmEgRDguMi43Lg0KPiA+DQo+ID4gTW9y
ZSBzcGVjaWZpY2FsbHksIGFjY29yZGluZyB0byBBUk0gRERJIDA0ODdJLmEgRDguMi43LCBpbiBv
cmRlciB0byBzdXBwb3J0DQo+ID4gdGhlIDUyLWJpdCBwYSBzaXplIHdpdGggNEtCIGdyYW51bGUs
IHRoZSBwMm0gcm9vdCB0YWJsZSBuZWVkcyB0byBiZQ0KPiBjb25maWd1cmVkDQo+ID4gZWl0aGVy
IGFzIGEgc2luZ2xlIHRhYmxlIGF0IGxldmVsIC0xIG9yIGFzIDE2IGNvbmNhdGVuYXRlZCB0YWJs
ZXMgYXQgbGV2ZWwgMC4NCj4gPiBTaW5jZSwgY3VycmVudGx5IHRoZXJlIGlzIG5vdCBzdXBwb3J0
IGZvciBsZXZlbCAtMSwgc2V0IHRoZSAncm9vdF9vcmRlcicgYW4NCj4gDQo+IFR5cG86IHMvbm90
L25vLyAoSSBjYW4gZml4IGl0IHdoaWxlIGNvbW1pdHRpbmcpDQo+IA0KPiA+ICdzbDAnIGZpZWxk
cyBvZiB0aGUgNTItYml0IHBhX3JhbmdlX2luZm8gYWNjb3JkaW5nIHRvIHRoZSBzZWNvbmQgYXBw
cm9hY2guDQo+ID4NCj4gPiBOb3RlIHRoYXQgdGhlIHZhbHVlcyBvZiB0aG9zZSBmaWVsZHMgYXJl
IG5vdCB1c2VkIHNvIGZhci4gVGhpcyBwYXRjaCB1cGRhdGVzDQo+ID4gdGhlaXIgdmFsdWVzIG9u
bHkgZm9yIHRoZSBzYWtlIG9mIGNvcnJlY3RuZXNzLg0KPiA+DQo+ID4gRml4ZXM6IDQwN2IxM2E3
MWUzMiAoInhlbi9hcm06IHAybSBkb24ndCBmYWxsIG92ZXIgb24gRkVBVF9MUEEgZW5hYmxlZA0K
PiBodyIpDQo+ID4gU2lnbmVkLW9mZi1ieTogWGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FA
Z21haWwuY29tPg0KPiANCj4gUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpv
bi5jb20+DQo+IA0KPiBSZWdhcmRpbmcgNC4xNywgSSBhbSBhIGJpdCBzcGxpdCB3aGV0aGVyIHRo
aXMgc2hvdWxkIGJlIGluY2x1ZGVkLiBPbiBvbmUNCj4gaGFuZCwgaXQgd291bGQgYmUgZ29vZCB0
byBoYXZlIHRoZSB2YWx1ZSBjb3JyZWN0IChub3QgdGhhdCBJIGV4cGVjdA0KPiBhbnltb3JlIHRv
IHRyeSB1c2luZyA1Mi1iaXQgb24gNC4xNy4uLikuIE9uIHRoZSBvdGhlciBoYW5kLCB0aGlzIGlz
IG5vdA0KPiB1c2VkIHNvIHRoZXJlIGlzIG5vIGJ1ZyAodGhpcyBjb3VsZCBhbHNvIGJlIGFuIGFy
Z3VtZW50IHRvIGFkZCBpdA0KPiBiZWNhdXNlIGl0IGlzIG5lYXJseSByaXNrIGZyZWUpLg0KPiAN
Cj4gSWYgd2UgZG9uJ3QgaW5jbHVkZSBpdCwgSSB3aWxsIGRlZmluaXRlbHkgYWRkIGluIG15IGxp
c3Qgb2YgcG90ZW50aWFsDQo+IGJhY2twb3J0cy4NCj4gDQo+IEhlbnJ5LCBhbnkgdGhvdWdodHM/
DQoNCkkgYW0gYWN0dWFsbHkgbW9uaXRvcmluZyB0aGlzIHBhdGNoIGZvciB0aGUgc2FtZSBxdWVz
dGlvbiB0aGF0IGlmDQp3ZSBuZWVkIHRoaXMgcGF0Y2ggZm9yIDQuMTcuDQoNCkkgc2VlIG5vIHJl
YXNvbiB0byBleGNsdWRlIHRoaXMgcGF0Y2ggc2luY2UgKDEpIHdlIHdhbnQgdG8gbWFrZSBzdXJl
DQpvdXIgY29kZSBpcyBjb3JyZWN0ICgyKSBJIGFtIHByZXR0eSBzdXJlIHdlIGFyZSBub3QgdXNp
bmcgNTIgYml0IFBBIHNvDQphcyBpbmRpY2F0ZWQgYnkgY29tbWl0IG1lc3NhZ2UgdGhpcyBwYXRj
aCBpcyBqdXN0IGZvciBjb3JyZWN0bmVzcyBhbmQNCm5vIHBvdGVudGlhbCBoYXJtIHRvIGluY2x1
ZGUgdGhpcyBwYXRjaCBpbiB0aGUgcmVsZWFzZSAocHJvYmFibHkgZXZlbg0KYmFja3BvcnRpbmcg
dGhpcyBwYXRjaCB0aWxsIHRoZSA1MiBiaXQgUEEgd2FzIGludHJvZHVjZWQ/KS4NCg0KU28gaWYg
eW91IHdvdWxkbid0IG1pbmQgY29tbWl0dGluZyB0aGlzIHBhdGNoLCB5b3UgY2FuIG9mIGNvdXJz
ZSBoYXZlDQpteToNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh
cm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAt
LQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 01:43:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 01:43:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427245.676109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olh4A-0001h9-Un; Fri, 21 Oct 2022 01:43:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427245.676109; Fri, 21 Oct 2022 01:43:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olh4A-0001h2-Qq; Fri, 21 Oct 2022 01:43:18 +0000
Received: by outflank-mailman (input) for mailman id 427245;
 Fri, 21 Oct 2022 01:43:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olh48-0001HJ-TA
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 01:43:17 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70085.outbound.protection.outlook.com [40.107.7.85])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bb1af48f-50e1-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 03:43:16 +0200 (CEST)
Received: from AS9P250CA0003.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::9)
 by DB8PR08MB5450.eurprd08.prod.outlook.com (2603:10a6:10:116::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Fri, 21 Oct
 2022 01:43:10 +0000
Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:532:cafe::96) by AS9P250CA0003.outlook.office365.com
 (2603:10a6:20b:532::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29 via Frontend
 Transport; Fri, 21 Oct 2022 01:43:10 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 01:43:09 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Fri, 21 Oct 2022 01:43:09 +0000
Received: from 9a1d3d18c706.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9187C2A3-70F9-446A-B3BA-B783279DBF36.1; 
 Fri, 21 Oct 2022 01:43:03 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9a1d3d18c706.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 01:43:03 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM9PR08MB6644.eurprd08.prod.outlook.com (2603:10a6:20b:30e::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 21 Oct
 2022 01:43:01 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 01:43:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb1af48f-50e1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OIfMpaPX3cL0sVFmND/d3o3EBA8rW0pGbNSALAzRfnhl/MICcJW3CpuK7OrSyUTLEDKtOP6j3ju/cX5NZC3919+mp7+Dd/JUrykTtuHeHHBzaTFcW4HZnsltfU4JiPuYu20eospltMGo5LwPciMOSV+zB45tl+hiOsqkyUhBj0u54/3VFO33HC9p5Y3lM5hzqwpbHhSyrJli0IS2Fh+XXmG7ePcrzMSzOa3tZAqE7aflpCTQMvsBufc3wktqG87phgOkmsZoETD8o2bCTxIZjuGQKExa9pVpu8M9t8V/6X+ZfNiYHgXONPC+mxLIZ1eycI/inzLI8OcsYf6rKihGCg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I/1lRJQoi940BYFAJ88BXjIaVMViStIp0n5oPY7StpI=;
 b=GOzb27BZKFAieD2XCX6wcGmJTS08PLkS2zDbM9vme0oB7y/xHEDQeBZ3D14n/pXru+oLeRMTOi9t2haAOuqHVUhFNFxZXmZeyYnMoSIZM6/7412GjTwfbQnZfUGBNGM4/z5IAV4reDHOX7PgdYyvFTbzzfZl3OWJgPixIk1F5V0unm4FCFz7ekiopgAkpSoMkJ16yHB+fyIXJN/k8Vc9AqQ/NSxkmAoDDxmMi3UPz0ofW8hGGjD9WEp8GB1KD1YRO6RqITExHG449+IkMfPCCcwOcGUrako9EcinYmS2Hv/ybXbUKrFBRxi4NFOm+WQ0RLNRrPlb63QBXoWqRuQpcA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I/1lRJQoi940BYFAJ88BXjIaVMViStIp0n5oPY7StpI=;
 b=6W8y2iKtcqKrgEmXGnczO0SBPu5fxnks3iKFSXKu5WTtrRR2xX1S/4L1u5H8nRY1IAcqRfMWhMPWT+yh88j+D5koevTjU31mvyfdqPsKgtr00hFH5UGAhME/LVhlXm4T9yqoeic+qD5/aVQjJ+rjpiDWk8W0h7FcQqXc85ocpf8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XZ45DSLL6o9U8EP3/QZezEDo5KpsGI0wQjaO3OrI9loo1jpUrgggQ8KVwvkD8XjBkCzSHAlO9b0dD124ZG0xctvT56OiD+hmPMFHX+oW38SmJkK/ldY1Qo106UyXEt7Zuk7t73d473zChXKx/6pvM4iK/pLmad1Yrv8e6m3wQztEsZa++y6UoCPOyy9c+FEcjFSfiBd3EMID0toSSfxipizBmclMLKdX7ARB641jD2WPh+8cfK2nnZ96dfX7OQv8W798yABwIjlLkqP/Zq2tzkcVFZkwVlt+ZBH8gIcAzwW24akPB0GZFCfACXHoqhSQlT9TQvkgyj3yRS/45WKs+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I/1lRJQoi940BYFAJ88BXjIaVMViStIp0n5oPY7StpI=;
 b=RUIRhXvXf4A8QGBltC4CBSIIvBpWRpI11krOSpyopEj6UTXMAVvXSQ4Zjf92yO/ruXB436l2w1MxvUNHS5xLev8dNVDEBEhVnOlErOw2b+HNhg9qGOnh3LInt/ZkFbjDleUVlr0I3WDi6/IFQ3sCd6ETs/b0T5c/dGGA5WCR4it24OOzadQ+C5DQYxDBiopQimZ1mkszA+U70OJPV9Y+E808qsrxiPwLs9blKysEJHxXza+W5j0LqWYKXViaqcfFA/l63s0ir93CLFfDwCMaVZTStfFrkS/TC4ND41WDq7hfYH6S7CA1nUphpeSyfG5lz5FVWSHHvG1uoBi57VKwyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I/1lRJQoi940BYFAJ88BXjIaVMViStIp0n5oPY7StpI=;
 b=6W8y2iKtcqKrgEmXGnczO0SBPu5fxnks3iKFSXKu5WTtrRR2xX1S/4L1u5H8nRY1IAcqRfMWhMPWT+yh88j+D5koevTjU31mvyfdqPsKgtr00hFH5UGAhME/LVhlXm4T9yqoeic+qD5/aVQjJ+rjpiDWk8W0h7FcQqXc85ocpf8=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Stewart Hildebrand
	<stewart.hildebrand@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
Thread-Topic: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
Thread-Index: AQHY4AkLAZG1W03ugkqkeLVQdjVQ9K4XoOsAgAB7wRA=
Date: Fri, 21 Oct 2022 01:43:01 +0000
Message-ID:
 <AS8PR08MB7991F349919947C426D29EB5922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <20221014200926.15250-1-stewart.hildebrand@amd.com>
 <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
In-Reply-To: <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: AE53891DAAE07B4E820E7F452A47E81C.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM9PR08MB6644:EE_|AM7EUR03FT006:EE_|DB8PR08MB5450:EE_
X-MS-Office365-Filtering-Correlation-Id: df4324c2-a8f3-4147-4f19-08dab3059bec
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 UU5BCsXHpV5xoHZJr0TtJtgIynKW4DwHm0M8f53FsOOecDrbaneRLTc0cqAekWT+WvMon5rK3wA9j4Kq5fnkL/r5XJIUcD453qqOzJY0xepeosxvK9UEJmscNG6OqmQ3o8W+sJJG4w3RqAhVfbby5nZPV3jVJLQEfCr7XUxR5ooo573/CzrJCMH/GUwF3s5B5h4XUZMOvQEgoTk3lU7e4m2T1eCkCh3A/wv0+Ik3215ALzP527TcEG2MyUtKC8llqpwy+GynSQFRSiyL+Y9dut3A0R/JYbz4ERlDWoiaEvfIPgm999x+OyVRcLVVu6oq3Z+TVuN6sKjaHv/9hf+BOIqeXMaFCgI6AvfwdY/jrwcGEL3+//oB2ISc0n/qecwGLX0mznwlIlEgGaI0v79g8IjoNgyORk0nUthVSdwd71L1OFp6FpS4Bwz7tXcp/C26TxexKp/mQPDH0d+S1sbe1FW8oYquVUvIMBaQkdujfInUTvJNtQIrTz7ZiLp8WUpoS1zLNzGmwQcurBnDZRIvPj4HRn3ue7at0N604K+fa1TH8hs7HUIK8sba+mgZqyOKfXwmvi5AUqZb7h464TOflhZNKKjgTHcDYX8/caXIDRFeIO51rv09jAU9BfPrd6ViZcjh7eZDLy8D23FODIBYjFY+aqbsx+MiPf7zFIBb6ctdfWW8lSa9Aup6uLBbnOZgLE8l8KsqWvd4aB5AgZHX+HFzy/oVTcwm5ENmo4cHkSOX7hvAsKaabv4qTzd8XamhQPxo1/PlxRllBI0RZBjRsw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(366004)(346002)(39860400002)(396003)(451199015)(4326008)(66946007)(66556008)(8676002)(66446008)(66476007)(122000001)(64756008)(76116006)(41300700001)(53546011)(7696005)(6506007)(38100700002)(2906002)(71200400001)(186003)(55016003)(5660300002)(9686003)(26005)(86362001)(52536014)(8936002)(38070700005)(478600001)(83380400001)(316002)(33656002)(54906003)(110136005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6644
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e9827e66-0abf-4fa6-1c3d-08dab30596fb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LVE2T7bcK1co9Fsil3o5HS0e5rwLXPtm3bN7KW6JN0EIYlkhCClR647u2kQCY2FD1VCHfkvpyjSevphkYyj7Km3NQ4TOU75SyIfCIejJ11kmTkjEljhk9SqUzAjZfff5FvzajIpGIyKdQMlmI8O0YQjRwXlRu/rR4IBfBCmnqWaRfsvYBBLodLqJu9bynRSNp9yvKq0CrBAwlnkt/9TBB5Jsh0UT+ZfuVWRVwARofyFK/Z+YZDgBMIhAxBIuQmnhrmaBEV0ax2aobUWS2G8oWER5e/GOg/dzhFkxrNPu9vwFUhGJL562wYFo4LiUD1cZw99Mev13EcOLp4xXDWQoQ/xPurkjTXO7MGv9vHi6p1E+j6EetJKuSmTRthv/Q6DsR5ne1h341NKi7IX0IHXOfszL6+nopl/rSZVvRiaLz5+7YeVD3BVaJGs/G8ENixwDg7YRGUBH55SfwNhHIthxRaEi75q29JIiFAOGzLI5GCttmKrDlu3VLBMhGkTTvkg3AwaHuPA/MBw3o208xvy+f9DqIf0D6moTfUOrokP2ljiMsRcv570Tz4rbNRSvp/r5634rOG5Y/7bGqQeR4HWxyY8+Oj+Fael71SucLJ914UapEgPy+7tW2ogRNrp+cDDdXGA3baWfdAH60Tx5X+vDTz6CMB2PmJIIargqinc4IGmyUHCri1M5ZjAa4bM4lb7qFlaqGbdC8hbU54i0RoK8JnpN5nO5ToSiv+VRaOih8dL+iL6s5ySaZ2+70scOIvRQXbzds0yMORu6HJnfs1AgSA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(46966006)(36840700001)(40470700004)(478600001)(9686003)(53546011)(26005)(110136005)(336012)(83380400001)(2906002)(107886003)(7696005)(6506007)(5660300002)(186003)(40480700001)(40460700003)(82310400005)(316002)(54906003)(8936002)(8676002)(41300700001)(52536014)(4326008)(70206006)(70586007)(36860700001)(47076005)(86362001)(55016003)(33656002)(81166007)(82740400003)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 01:43:09.7885
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: df4324c2-a8f3-4147-4f19-08dab3059bec
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5450

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIHhlbi9h
cm06IG1hcmsgaGFuZGxlX2xpbnV4X3BjaV9kb21haW4oKSBfX2luaXQNCj4gDQo+IEhpIFN0ZXdh
cnQsDQo+IA0KPiBJIG5lYXJseSBtaXNzZWQgdGhpcyBvbmUgYmVjYXVzZSBpdCB3YXMgdGhyZWFk
ZWQgdW5kZXIgdjEuIEluIHRoZQ0KPiBmdXR1cmUsIHdvdWxkIHlvdSBiZSBhYmxlIHRvIHNlbmQg
bmV3IHZlcnNpb24gaW4gYSBzZXBhcmF0ZSB0aHJlYWQ/IFRoaXMNCj4gbWFrZXMgZWFzaWVyIHRv
IHRyYWNrIGl0Lg0KPiANCj4gT24gMTQvMTAvMjAyMiAyMTowOSwgU3Rld2FydCBIaWxkZWJyYW5k
IHdyb3RlOg0KPiA+IEFsbCBmdW5jdGlvbnMgaW4gZG9tYWluX2J1aWxkLmMgc2hvdWxkIGJlIG1h
cmtlZCBfX2luaXQuIFRoaXMgd2FzDQo+ID4gc3BvdHRlZCB3aGVuIGJ1aWxkaW5nIHRoZSBoeXBl
cnZpc29yIHdpdGggLU9nLg0KPiA+DQo+ID4gRml4ZXM6IDEwNTBhN2I5MWMgeGVuL2FybTogYWRk
IHBjaS1kb21haW4gZm9yIGRpc2FibGVkIGRldmljZXMNCj4gPiBTaWduZWQtb2ZmLWJ5OiBTdGV3
YXJ0IEhpbGRlYnJhbmQgPHN0ZXdhcnQuaGlsZGVicmFuZEBhbWQuY29tPg0KPiANCj4gQWNrZWQt
Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IA0KPiBIZW5yeSwgdGhpcyBw
YXRjaCBpcyBmaXhpbmcgYSBwb3RlbnRpYWwgYnVpbGQgZmFpbHVyZSBvbiBzb21lIGNvbXBpbGVy
DQo+IChhdCB0aGUgbW9tZW50IHdlIGFyZSByZWx5aW5nIG9uIHRoZSBjb21waWxlciB0byBpbmxp
bmUNCj4gaGFuZGxlX2xpbnV4X3BjaV9kb21haW4pLiBBRkFJVSwgdGhlIHByb2JsZW0gd2FzIGlu
dHJvZHVjZWQgaW4gWGVuIDQuMTcuDQo+IFdvdWxkIHlvdSBiZSBoYXBweSBpZiB3ZSBpbmNsdWRl
IGl0IGluIHRoZSByZWxlYXNlPw0KDQpPZiBjb3Vyc2UuIFRoYW5rcyBmb3IgdGhlIHBpbmcgOikN
Cg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpL
aW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiA+DQo+ID4gLS0tDQo+
ID4gdjEgLT4gdjI6DQo+ID4gICAgQWRkIEZpeGVzOiB0YWcNCj4gPiAgICBBZGQgcGF0Y2ggZGVz
Y3JpcHRpb24NCj4gPiAtLS0NCj4gPiAgIHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyB8IDQg
KystLQ0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo
LSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgYi94
ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4gPiBpbmRleCA2MWNkYThlODQzLi5mYzI5NjE4
OTViIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+ICsr
KyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiA+IEBAIC0xMDUxLDggKzEwNTEsOCBA
QCBzdGF0aWMgdm9pZCBfX2luaXQgYXNzaWduX3N0YXRpY19tZW1vcnlfMTEoc3RydWN0DQo+IGRv
bWFpbiAqZCwNCj4gPiAgICAqIFRoZSBjdXJyZW50IGhldXJpc3RpYyBhc3N1bWVzIHRoYXQgYSBk
ZXZpY2UgaXMgYSBob3N0IGJyaWRnZQ0KPiA+ICAgICogaWYgdGhlIHR5cGUgaXMgInBjaSIgYW5k
IHRoZW4gcGFyZW50IHR5cGUgaXMgbm90ICJwY2kiLg0KPiA+ICAgICovDQo+ID4gLXN0YXRpYyBp
bnQgaGFuZGxlX2xpbnV4X3BjaV9kb21haW4oc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbywNCj4g
PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgZHRfZGV2
aWNlX25vZGUgKm5vZGUpDQo+ID4gK3N0YXRpYyBpbnQgX19pbml0IGhhbmRsZV9saW51eF9wY2lf
ZG9tYWluKHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8sDQo+ID4gKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqbm9k
ZSkNCj4gPiAgIHsNCj4gPiAgICAgICB1aW50MTZfdCBzZWdtZW50Ow0KPiA+ICAgICAgIGludCBy
ZXM7DQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 01:52:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 01:52:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427256.676123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olhCY-0003S7-TT; Fri, 21 Oct 2022 01:51:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427256.676123; Fri, 21 Oct 2022 01:51:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olhCY-0003S0-Qa; Fri, 21 Oct 2022 01:51:58 +0000
Received: by outflank-mailman (input) for mailman id 427256;
 Fri, 21 Oct 2022 01:51:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olhCX-0003Rt-Dw
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 01:51:57 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2054.outbound.protection.outlook.com [40.107.22.54])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0f74f3c-50e2-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 03:51:55 +0200 (CEST)
Received: from AM6P192CA0063.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::40)
 by PA4PR08MB6046.eurprd08.prod.outlook.com (2603:10a6:102:e4::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 01:51:52 +0000
Received: from AM7EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::29) by AM6P192CA0063.outlook.office365.com
 (2603:10a6:209:82::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Fri, 21 Oct 2022 01:51:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT010.mail.protection.outlook.com (100.127.141.22) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 21 Oct 2022 01:51:52 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Fri, 21 Oct 2022 01:51:52 +0000
Received: from f43e12d8d49c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 10E56816-F2E1-4EE2-AFD4-0BE3D38BCFEF.1; 
 Fri, 21 Oct 2022 01:51:46 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f43e12d8d49c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 01:51:46 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PAVPR08MB9745.eurprd08.prod.outlook.com (2603:10a6:102:31c::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 01:51:37 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 01:51:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0f74f3c-50e2-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=hnMuhI++YiRqsJkjr9lX+C7enQSBtPCKB3lRZ9C+i6ietfAOaF8yRuMD4tyqLvaTBWDDn/ukWnL4JOtQBSdr+KVBVIjrtcSPQWq2YtoHyKj+CtqIPefaHtCyuaPQjiGoVrx/MW9rV37CMciWZNyYBrKJadObKzXIO0XhJOW1mWDGfeCgxr8yPWcZqyXBriiIUeLA7ydPLh5vOHwhhomF8pP0Ux/csplepgS6ED8CVKL0fzexAbgFchX1xkeKb5Q0Mru3QLmNfxsOOx1/V+26EryCyyzpU2DZwJQ7JiYCXB3PDzykQnLAVO1m6B3nFcMetS9WpcHhpy67z0FFFLA78g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zguq9kvnBtCiJ0MP0VGOCtOPayaIcJTAyjeljmE1njc=;
 b=B9IwpWYxFqxZXRnbueuS4TLXH0LYq/xBQKOqo5RV+g1v81V+Q1xelEjVdyY2Fke90VpjFpdxQFQNj6KMnxPjTlp9Sg+o+57bDvkT508NTTm8vBaKXEuxZuduVRc5XkaUMJPj3Dxx4+/eHtEgJBVLMzDczCmKKgCXoNRKOK7YC+rmSTieNZwFJjmZQfoL3FXcQfsvSKegeTUESNVDtN24gFPB5BotzMtN+1YVgLBMSwNAlY43o2bor3yw6pKcFaYAeS5EL+DoilYUfTB92cgw+bJmFdCN9dSvqQfyri/KFN4MmpqKbJ6TWx4R80e8wZjmcS7kiliRTnqzn0EOoDRnvg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Zguq9kvnBtCiJ0MP0VGOCtOPayaIcJTAyjeljmE1njc=;
 b=D7eW1d9/eIyJ8lvv1Tg9GZC8rGdHLmlWFAeYas+Kml1IIYdOut0T9OpqYbkfJmqCMv5KPjynYGu+wpTcLbr6N+u4btuRlcKmYT4xAfkSnFsYknw2zVqWuGNmoiy+NRzKXumEpjZHQxhyN+K3A4ChUT+jR39h0yZwdR5GSTeNwdA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L+T8/D7BqN90lgqYtvqMax6nPcnNHsTDtifJeq8U5jFeD7tUwPYrP3giK+xzDMrRFlmSUGz2LlFD7upoFJtZjOA2UeP2eq+b3U4+/ahCIgGrKSU1QRsLrC/4TWTOfnT1+EFnvAqG5ZtERZfEgOKHRWyRjkkWZIOkveRK6S5G7JsYHIeu2yBF8sjaWyAyNRS5i6OoFxW4DqqQAhYK1xYS3ZFhrdYbY6GklLbXhkrXcuGyQS07cHNdxDiygi8pubfFD0i7y5puYg9A+k8sg2uOVSiQJnnoI7cy5Z+oSKVI8INEhtqY7+lvdk5DcG3X3GxbmWlV61W21avFTQKQ8pAvEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zguq9kvnBtCiJ0MP0VGOCtOPayaIcJTAyjeljmE1njc=;
 b=a4AIBBNZ42Y+iYFThu+6sAa1wQKvMjlx0c1Yt2dmpFdGPElNNEjEGGo/m8QNrYaKy6CIiX5hdtmtZcvzd88Uadk/aFwBYBmwN5ukr3m/awhASs4NxUNNfpLt89GJZUuWasvDqOvJnFTYJCs2KoPuJ3mjl9ej/7CilzQfsgLEXb3S55BpwYCD+nxk/t/0U24fS7C8FxF9mMw9/+kt3gTbSNyFMLPS6AaJ789f3EFYWhG1uMOzP0LFc2jLsCPhhziDze3o7jbZrPjtbqr9iUFWz9RepWd0EhFCN3/QIRQk0asvi7mIy8H2Nt7ZNezOE4rvmwn2dO0hF9pnUcYzL8k7JA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Zguq9kvnBtCiJ0MP0VGOCtOPayaIcJTAyjeljmE1njc=;
 b=D7eW1d9/eIyJ8lvv1Tg9GZC8rGdHLmlWFAeYas+Kml1IIYdOut0T9OpqYbkfJmqCMv5KPjynYGu+wpTcLbr6N+u4btuRlcKmYT4xAfkSnFsYknw2zVqWuGNmoiy+NRzKXumEpjZHQxhyN+K3A4ChUT+jR39h0yZwdR5GSTeNwdA=
From: Henry Wang <Henry.Wang@arm.com>
To: =?utf-8?B?RWR3aW4gVMO2csO2aw==?= <edvin.torok@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Christian
 Lindig <christian.lindig@citrix.com>
CC: David Scott <dave@recoil.org>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Subject: RE: [PATCH for-4.17] tools/ocaml/xenstored: fix live update exception
Thread-Topic: [PATCH for-4.17] tools/ocaml/xenstored: fix live update
 exception
Thread-Index: AQHY5KTKwWQiC9Lco0elva4YOgIdSa4YFJwg
Date: Fri, 21 Oct 2022 01:51:37 +0000
Message-ID:
 <AS8PR08MB7991F9FFD0D8BDF36084B322922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References:
 <12d90632bf881e96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com>
In-Reply-To:
 <12d90632bf881e96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: C134CD02F6B28448A303B81D9970DBE4.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PAVPR08MB9745:EE_|AM7EUR03FT010:EE_|PA4PR08MB6046:EE_
X-MS-Office365-Filtering-Correlation-Id: eeeaf7d6-bc7b-4976-32d1-08dab306d354
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Sip69zAsE4NwRzxwaZmJdP6ax5dhK3LXJy2l2cGYLvQbsDgSeCMWfYpoISApzMwJHQtaGn8GfVAvCpEhZf1x5Q3LnZVpzRSGp2XhVkJKF0///3Nfj+sBnj8Vcehc5C5YXzzaHcpnTUl10MIPSCBVbvpP5+4xP74Jx2jTbcfkWQnOiSwjR1ODNYib1HPnmFq0Zlno1scQouI0isNelvs0gP223fcM6EO3EwTzllb9ieL5M1EOj8Ev8zqTZcx/naYHRtN34QeARiqgwDpYWrj9ujy7f+xvuyFxaTkgMW4KCdeLggdJKxm0CahVvOvu0yRgPkVtwlRAegnXbgiScx1dGVrrqHpXqe7yI5lMfQJfnd8AHgq07szp5kSaaVwq7iDA/xmIX9WRaosO6M5m1EohGTxl4IwCguWt4CmbOEtxPN962WW1Dhbz8UYa60iZ1E/dLVeg7v++UOxdNZCL4No7Y/sVP48bqhIWu8c3KBzJ1DLEI/uoK4Aarq2ZbuPAI/V1ueLqUz7hdpe8q7+UUs/4WVy87SznXElRTdY6nbdyUvSibx1dOrRb/fAcxW9MXMF6IMOdmhz41RggrhVC4U/7IUwoCDljGOYmrtaJMyB9LLNcQ9lznegrBiG1l+FzYxpOSVg31P8/UpJgpDV6R8YQNqSTR4FSsgryZY8K0cb/QC05CeJpYQHR9cVcMU1dgTc3es1ArQlKNiyEQ2/GkPQFVPLP+CbkMs+86EYtn5/FLqDLvJH1/GqyHCIzyvnm9jeigjUc2phNsFqC4xIY5hoMPNi0GQKfCWg0w5pD16ikcsY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(451199015)(33656002)(8676002)(66556008)(66476007)(41300700001)(64756008)(122000001)(66446008)(186003)(38100700002)(66946007)(55016003)(9686003)(4326008)(66574015)(2906002)(76116006)(52536014)(8936002)(86362001)(26005)(83380400001)(6506007)(5660300002)(7696005)(966005)(15650500001)(316002)(38070700005)(110136005)(71200400001)(54906003)(478600001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9745
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e5590c0a-c123-45df-a8ea-08dab306ca7f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XMkeRq9w/MUTIWOk1ha0EOpFKJJgCgDpSA1gLWBNkSAlDeHIlxq0/5rgABzt1AmcZMC5uEAl6AGLU3KLDfnhUABqvAU1zXMj8EZJNKouXjDQfBW5LfEm9s+tY1qxmjBltHbG8PeAdgctx1uX0BtVTcjMCTT++4nSNaZgt92/gDv/0BVYsTivP5GQNTmzIsbS0R/Ln6x1a/W1OaQfJZIUbrwQwCO38BiJUThIoSESUkohKcpF0x12xMXbn51f8vGgdebYjOCnY6d9r07EFhTT1Lc0Z9aOQBxKX5Qp63AxeW1ENDSSGiAK179yb9/rLptA3B8Hysp471897YQGwc84AA2vOejs61wP8yX2H3qYkWn1JGhUcTiQGPlSAj0tlJM5UROEoYUzNeiSCkN6nvoBI0DN2iYpKGMLG81gIXE73VasKO+Lg0s/FDUyHVVEAH6raW+02p0OFqmVOxR1S/EfPdHFv4AuY1kQURRTR0huQB9fpviFcAILjmBAPhO6pxu/SqjyrZJFrr5JItlfZaPkbkrFU0G5LqQNgwDSTHPDwMqTmXoNk8Xdh7DSRBG/bS5pAiISEy5LPimoxkhfUNtSDc34BiQscZbvYvo6k3IkrcVQRs0a1f+OYe9LeXuabZu6xNYX2wnSd5PSFMr5N5biC+/0gk6Dv+pr327gCPB7a++gfSlSH3ab0j6W4CNdoijdGLJSkoaAFlqKS7myIO/Zxc91pEBEumew8f9uwtWhVmIkKj5UhREVc7CAVPa/bjVHfbCAzzuARjBhheZANVEv8B+FkvPbMVAd2XfyOSQbgUM=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(8936002)(52536014)(83380400001)(316002)(40460700003)(33656002)(2906002)(54906003)(110136005)(70586007)(70206006)(8676002)(336012)(40480700001)(5660300002)(186003)(55016003)(66574015)(41300700001)(4326008)(47076005)(86362001)(36860700001)(26005)(107886003)(478600001)(82310400005)(966005)(9686003)(15650500001)(81166007)(6506007)(82740400003)(7696005)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 01:51:52.2407
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eeeaf7d6-bc7b-4976-32d1-08dab306d354
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6046

SGkgRWR3aW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogRWR3aW4g
VMO2csO2ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00
LjE3XSB0b29scy9vY2FtbC94ZW5zdG9yZWQ6IGZpeCBsaXZlIHVwZGF0ZSBleGNlcHRpb24NCj4g
DQo+IER1cmluZyBsaXZlIHVwZGF0ZSB3ZSB3aWxsIGxvYWQgdGhlIC90b29sL3hlbnN0b3JlZCBw
YXRoIGZyb20gdGhlIHByZXZpb3VzDQo+IGJpbmFyeSwNCj4gYW5kIHRoZW4gdHJ5IHRvIG1rZGly
IC90b29sIGFnYWluIHdoaWNoIHdpbGwgZmFpbCB3aXRoIEVFWElTVC4NCj4gQ2hlY2sgZm9yIGV4
aXN0ZW5jZSBvZiB0aGUgcGF0aCBiZWZvcmUgY3JlYXRpbmcgaXQuDQo+IA0KPiBUaGUgd3JpdGUg
Y2FsbCB0byAvdG9vbC94ZW5zdG9yZWQgc2hvdWxkIG5vdCBuZWVkIGFueSBjaGFuZ2VzDQo+IChh
bmQgd2UgZG8gd2FudCB0byBvdmVyd3JpdGUgYW55IHByZXZpb3VzIHBhdGgsIGluIGNhc2UgaXQg
Y2hhbmdlZCkuDQo+IA0KPiBQcmlvciB0byA3MTEwMTkyYjFkZjYgbGl2ZSB1cGRhdGUgd291bGQg
d29yayBvbmx5IGlmIHRoZSBiaW5hcnkgcGF0aCB3YXMNCj4gc3BlY2lmaWVkLCBhbmQgd2l0aCA3
MTEwMTkyYjFkZjYgYW5kIHRoaXMgbGl2ZSB1cGRhdGUgYWxzbyB3b3JrcyB3aGVuDQo+IG5vIGJp
bmFyeSBwYXRoIGlzIHNwZWNpZmllZCBpbiBgeGVuc3RvcmUtY29udHJvbCBsaXZlLXVwZGF0ZWAu
DQo+IA0KPiBGaXhlczogNzExMDE5MmIxZGY2ICgidG9vbHMvb3hlbnN0b3JlZDogRml4IE94ZW5z
dG9yZWQgTGl2ZSBVcGRhdGUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBFZHdpbiBUw7Zyw7ZrIDxlZHZp
bi50b3Jva0BjaXRyaXguY29tPg0KDQpBcyBwZXIgWzFdIGRlc2NyaWJlZCwgSSB0aGluayBpdCBp
cyBxdWl0ZSByZWFzb25hYmxlIHRvIGluY2x1ZGUgdGhpcyBwYXRjaCBmb3INCjQuMTcsIGFzIHRo
aXMgcGF0Y2ggaXMgYSBidWdmaXggYW5kIHRoZSBwYXRjaCBpbiBbMV0gYWxyZWFkeSBoYXZlIHRo
ZSBhY2sgYW5kDQpyZWxlYXNlIGFjay4gQWx0aG91Z2ggSSB3b3VsZCBhbHNvIGxpa2UgdG8gaGVh
ciB0aGUgb3BpbmlvbiBmcm9tDQpDaHJpc3RpYW4gKHRoZSBvY2FtbCBtYWludGFpbmVyKSB0byBq
dXN0IHBsYXkgc2FmZS4NCg0KWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC9G
NjVDOEU1OC1FRjNELTQ3RDktQTk0RS03QjcwRUI5M0UwNjhAY2l0cml4LmNvbS8NCg0KUmVsZWFz
ZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2Fy
ZHMsDQpIZW5yeQ0KDQo+IC0tLQ0KPiAgdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5t
bCB8IDQgKysrLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv
bigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQu
bWwNCj4gYi90b29scy9vY2FtbC94ZW5zdG9yZWQveGVuc3RvcmVkLm1sDQo+IGluZGV4IGZjOTBm
Y2RlYjUuLjMyOTlmZTczZjcgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94
ZW5zdG9yZWQubWwNCj4gKysrIGIvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbA0K
PiBAQCAtMzUzLDcgKzM1Myw5IEBAIGxldCBfID0NCj4gIAkpIGluDQo+IA0KPiAgCSgqIHJlcXVp
cmVkIGZvciB4ZW5zdG9yZS1jb250cm9sIHRvIGRldGVjdCBhdmFpbGFiaWxpdHkgb2YgbGl2ZS11
cGRhdGUgKikNCj4gLQlTdG9yZS5ta2RpciBzdG9yZSBQZXJtcy5Db25uZWN0aW9uLmZ1bGxfcmln
aHRzIChTdG9yZS5QYXRoLm9mX3N0cmluZw0KPiAiL3Rvb2wiKTsNCj4gKwlsZXQgdG9vbF9wYXRo
ID0gU3RvcmUuUGF0aC5vZl9zdHJpbmcgIi90b29sIiBpbg0KPiArCWlmIG5vdCAoU3RvcmUucGF0
aF9leGlzdHMgc3RvcmUgdG9vbF9wYXRoKSB0aGVuDQo+ICsJCQkJCVN0b3JlLm1rZGlyIHN0b3Jl
DQo+IFBlcm1zLkNvbm5lY3Rpb24uZnVsbF9yaWdodHMgdG9vbF9wYXRoOw0KPiAgCVN0b3JlLndy
aXRlIHN0b3JlIFBlcm1zLkNvbm5lY3Rpb24uZnVsbF9yaWdodHMNCj4gIAkJKFN0b3JlLlBhdGgu
b2Zfc3RyaW5nICIvdG9vbC94ZW5zdG9yZWQiKQ0KPiBTeXMuZXhlY3V0YWJsZV9uYW1lOw0KPiAN
Cj4gDQo+IGJhc2UtY29tbWl0OiAwYzA2NzYwYmUzZGMzZjI4NjAxNWUxOGM0YjFkMTY5NGU1NWRh
MDI2DQo+IC0tDQo+IDIuMzQuMQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 02:11:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 02:11:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427264.676134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olhVV-0006Kz-Is; Fri, 21 Oct 2022 02:11:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427264.676134; Fri, 21 Oct 2022 02:11:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olhVV-0006Ks-FY; Fri, 21 Oct 2022 02:11:33 +0000
Received: by outflank-mailman (input) for mailman id 427264;
 Fri, 21 Oct 2022 02:11:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olhVU-0006Ki-9l; Fri, 21 Oct 2022 02:11:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olhVU-0006On-6A; Fri, 21 Oct 2022 02:11:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olhVT-0003zJ-QU; Fri, 21 Oct 2022 02:11:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olhVT-0001oY-Pz; Fri, 21 Oct 2022 02:11:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Sd00Y8keg8oegpWoxsqyTTCq+z6QUnvSLfD8sdQ0JDI=; b=get7NPPikjp044GBYOPUds8kzB
	R5kQ+dSp2y7q99qC1BWuoTckHxxnteSyuGioGeYGrPIoqDxZCe3DaOG4IeJScLjmz5uDQGU+7VvC7
	WKuJDIWhSnNjjMsllqARsqSO+XKc6Rvarolo/lYH7OLeRCgL0rJLhAZFVJgMNBlUsDeg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174133-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174133: tolerable trouble: fail/pass/starved
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-unstable:build-armhf-libvirt:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 02:11:31 +0000

flight 174133 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174133/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 173477
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174057
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174057
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174057
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174057
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174057
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174057
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174057
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174057
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174057
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-cubietruck  3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   174133  2022-10-20 11:59:00 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 03:39:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 03:39:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427276.676157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olirz-0006ZZ-VA; Fri, 21 Oct 2022 03:38:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427276.676157; Fri, 21 Oct 2022 03:38:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olirz-0006ZS-S6; Fri, 21 Oct 2022 03:38:51 +0000
Received: by outflank-mailman (input) for mailman id 427276;
 Fri, 21 Oct 2022 03:38:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olirz-0006ZI-Ca; Fri, 21 Oct 2022 03:38:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olirz-0007yj-Ab; Fri, 21 Oct 2022 03:38:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oliry-0000LP-Vh; Fri, 21 Oct 2022 03:38:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oliry-00033v-VA; Fri, 21 Oct 2022 03:38:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WU78GEKeYqis4hxpy1+6rL8oFnmd5F3OrGOqqx76MdA=; b=PPgIkGtEmKW04fESdlrOTgGZdJ
	bY7S9h5Sj29iNE4wHI8y/0DrtGHjIy9+wra/mI6C44CPzFnIOceWTiMs1NOs87CrZUUbjqM3Bn0Z7
	E0bGbIiOZq+xdJhT7Y7S8+vdwo7relNxmi3Uxu8i0Q92eEfSee6G/LiiKk4u6goHsY8w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174112-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174112: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=a58da464154cb02b5630fb42e0b0924d22aeb750
X-Osstest-Versions-That:
    libvirt=71d9836ca174997aafc4b14fb4f14d59ecc270b4
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 03:38:50 +0000

flight 174112 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174112/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174035
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174035
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174035
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              a58da464154cb02b5630fb42e0b0924d22aeb750
baseline version:
 libvirt              71d9836ca174997aafc4b14fb4f14d59ecc270b4

Last test of basis   174035  2022-10-18 04:18:52 Z    2 days
Testing same since   174112  2022-10-20 02:09:40 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Amneesh Singh <natto@weirdnatto.in>
  Cole Robinson <crobinso@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Martin Kletzander <mkletzan@redhat.com>
  Pavel Hrdina <phrdina@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   71d9836ca1..a58da46415  a58da464154cb02b5630fb42e0b0924d22aeb750 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 05:49:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 05:49:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427294.676209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olkuI-0003tZ-WF; Fri, 21 Oct 2022 05:49:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427294.676209; Fri, 21 Oct 2022 05:49:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olkuI-0003tS-Rn; Fri, 21 Oct 2022 05:49:22 +0000
Received: by outflank-mailman (input) for mailman id 427294;
 Fri, 21 Oct 2022 05:49:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yPHp=2W=redhat.com=jasowang@srs-se1.protection.inumbo.net>)
 id 1olkuI-0003bt-7V
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 05:49:22 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b9c7038-5104-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 07:49:21 +0200 (CEST)
Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com
 [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-549-gr2T5VvvN5OYPXqbO25PBA-1; Fri, 21 Oct 2022 01:49:18 -0400
Received: by mail-oa1-f70.google.com with SMTP id
 586e51a60fabf-1329a5d3272so1164516fac.17
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 22:49:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b9c7038-5104-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666331360;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vnJgyxJi0WUdobvp11tF9QEmwGMEfQeuu353PWho6+4=;
	b=MU0JeONIs+bD0r1BW1NrCrAhQRLgid7G9G9V9zY7Jv0w1Pps/zuxj48sJT2vKIaPHwun+Z
	2OeQNTg147M9QvN7zLXOrz7ctcYe/kE2OVtWi2EyWsaGyadvANX49kyx++OjvAZFhxJXmA
	xqnWUESjdls5bLc3dyCDV9PpZpuG3hg=
X-MC-Unique: gr2T5VvvN5OYPXqbO25PBA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=vnJgyxJi0WUdobvp11tF9QEmwGMEfQeuu353PWho6+4=;
        b=dtlz6rQyV/0KJ2lV6AfwZ/0BqltxtsAWvrSRg4mROGUNrRL6zOkQjg8cucfhoazDre
         8t0BJmg7TgZ3YSbmvwiufYJW0nTgy2Uie+C61ZiNcDOD5QnWTrVX8WxJWEj8ZKSy2P7g
         Hgb0g8u6PiYsRgvsEK9TfXZQH+vbxgfDiWjUhIvdwali1PUxOKWRnBdwvM20u5ZJo2Bj
         TPYfJ4WoGy1+l1kkWYIKE0V3JuTooh7IaaWnf1unuyQH/pcXo0Ps1q2XbK788fAQHNIe
         aEPnjN/kkFX8wAR9/wfOXE9hk2knfpNROKoygUOoFTVIqjPP9VyEGo5PfaQOnJp84FfS
         CcWA==
X-Gm-Message-State: ACrzQf1YtBoo4iEj4xmAv5HrCWrOuK+s98XtDOXFJrUfbkyuS5ix5wLd
	5IMzCLWh8yKYHFvoV4YIbavNzJATk1tcWUqyJdp78EdVuuLXgM8FtDPUQkR98aAazS4lGwDKOKg
	QiGRWU1cuAEauDymTHyvZ8ytyYf5h1QSJqUoE1E2eVvU=
X-Received: by 2002:a05:6871:54e:b0:13b:29b7:e2e8 with SMTP id t14-20020a056871054e00b0013b29b7e2e8mr1080447oal.35.1666331358172;
        Thu, 20 Oct 2022 22:49:18 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5OxvlAr/sRYRZ4/SWbuH4Yd8f+24dXScokHZS5516ZdOe56EquuERpXrSwO5NnOuPdkC330Zx3Mu1qjw7Szcg=
X-Received: by 2002:a05:6871:54e:b0:13b:29b7:e2e8 with SMTP id
 t14-20020a056871054e00b0013b29b7e2e8mr1080435oal.35.1666331357894; Thu, 20
 Oct 2022 22:49:17 -0700 (PDT)
MIME-Version: 1.0
References: <20221020162558.123284-1-lvivier@redhat.com>
In-Reply-To: <20221020162558.123284-1-lvivier@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 21 Oct 2022 13:49:05 +0800
Message-ID: <CACGkMEt9Hoo=GAuCUqMcBjqNvs94fEPA_GU9Z7TOh8c7Wam55Q@mail.gmail.com>
Subject: Re: [PATCH v13 00/17] qapi: net: add unix socket type support to
 netdev backend
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Durrant <paul@xen.org>, 
	Markus Armbruster <armbru@redhat.com>, Thomas Huth <thuth@redhat.com>, 
	=?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>, Greg Kurz <groug@kaod.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, David Gibson <david@gibson.dropbear.id.au>, 
	Eric Blake <eblake@redhat.com>, xen-devel@lists.xenproject.org, 
	"Michael S. Tsirkin" <mst@redhat.com>, Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>, 
	Samuel Thibault <samuel.thibault@ens-lyon.org>, Anthony Perard <anthony.perard@citrix.com>, 
	Ralph Schmieder <ralph.schmieder@gmail.com>, Stefano Brivio <sbrivio@redhat.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 21, 2022 at 12:26 AM Laurent Vivier <lvivier@redhat.com> wrote:
>
> "-netdev socket" only supports inet sockets.
>
> It's not a complex task to add support for unix sockets, but
> the socket netdev parameters are not defined to manage well unix
> socket parameters.
>
> As discussed in:
>
>   "socket.c added support for unix domain socket datagram transport"
>   https://lore.kernel.org/qemu-devel/1C0E1BC5-904F-46B0-8044-68E43E67BE60=
@gmail.com/
>
> This series adds support of unix socket type using SocketAddress QAPI str=
ucture.
>
> Two new netdev backends, "stream" and "dgram" are added, that are barely =
a copy of "socket"
> backend but they use the SocketAddress QAPI to provide socket parameters.
> And then they also implement unix sockets (TCP and UDP).
>
> Some examples of CLI syntax:
>
>   for TCP:
>
>   -netdev stream,id=3Dsocket0,addr.type=3Dinet,addr.host=3Dlocalhost,addr=
.port=3D1234
>   -netdev stream,id=3Dsocket0,server=3Doff,addr.type=3Dinet,addr.host=3Dl=
ocalhost,addr.port=3D1234
>
>   -netdev dgram,id=3Dsocket0,\
>           local.type=3Dinet,local.host=3Dlocalhost,local.port=3D1234,\
>           remote.type=3Dinet,remote.host=3Dlocalhost,remote.port=3D1235
>
>   for UNIX:
>
>   -netdev stream,id=3Dsocket0,addr.type=3Dunix,addr.path=3D/tmp/qemu0
>   -netdev stream,id=3Dsocket0,server=3Doff,addr.type=3Dunix,addr.path=3D/=
tmp/qemu0
>
>   -netdev dgram,id=3Dsocket0,\
>           local.type=3Dunix,local.path=3D/tmp/qemu0,\
>           remote.type=3Dunix,remote.path=3D/tmp/qemu1
>
>   for FD:
>
>   -netdev stream,id=3Dsocket0,addr.type=3Dfd,addr.str=3D4
>   -netdev stream,id=3Dsocket0,server=3Doff,addr.type=3Dfd,addr.str=3D5
>
>   -netdev dgram,id=3Dsocket0,local.type=3Dfd,addr.str=3D4
>
> v13:
>   - fix server default in qtest
>   - use SocketAddress in event
>   - remove unwanted meson update
>   - update error message in net_init_dgram()

I've queued this version and will send pull requests shortly.

Any future comment we can do patches on top.

Thanks

>
> v12:
>   - replace NETDEV_STREAM_EOC by NETDEV_STREAM_DISCONNECTED
>   - set server=3Doff by default
>
> v11:
>   - use qemu_set_info_str() in hw/net/xen_nic.c
>   - fix link_down state in stream client mode
>   - cleanup error case in net_stream_receive()
>   - update qapi version to 7.2
>
> v10:
>   - add Red Hat copyright
>   - initialize dgram_dst to NULL in SOCKET_ADDRESS_TYPE_FD
>   - remove redundente _stream / _dgram in functions name
>   - move net_dgram_init() into net_init_dgram()
>   - address Thomas' comments on qtest
>   - add a function qemu_set_info_str() to set info string
>   - tested stream netdev with fd type using qrap/passt and
>     "-netdev stream,addr.type=3Dfd,server=3Doff,addr.str=3D5,id=3Dnetdev0=
"
>
> v9:
>   - add events to report stream connection/disconnection
>   - remove from net/dgram.c send_fn, listen_fd, net_dgram_accept()
>     net_dgram_connect() and net_dgram_send() that are only
>     needed by net/stream.c
>   - remove from net/stream.c send_fn
>   - add Red Hat copyright
>   - add original net/socket.c Stefano's patch (EINVAL)
>
> v8:
>   - test ipv4 and ipv6 parameters (stream inet)
>   - test abstract parameter (stream unix)
>   - add SocketAddressInet supported parameters in qemu-options.hx
>     (only stream, supported by the move to QIO)
>   - with qio_channel_writev() replace (ret =3D=3D -1 && errno =3D=3D EAGA=
IN)
>     by (ret =3D=3D QIO_CHANNEL_ERR_BLOCK)
>
> v7:
>   - add qtests
>   - update parameters table in net.json
>   - update socket_uri() and socket_parse()
>
> v6:
>   - s/netdev option/-netdev option/ PATCH 4
>   - s/ / /
>   - update @NetdevStreamOptions and @NetdevDgramOptions comments
>   - update PATCH 4 description message
>   - add missing return in error case for unix stream socket
>   - split socket_uri() patch: move and rename, then change content
>
> v5:
>   - remove RFC prefix
>   - put the change of net_client_parse() into its own patch (exit() in th=
e
>     function)
>   - update comments regarding netdev_is_modern() and netdev_parse_modern(=
)
>   - update error case in net_stream_server_init()
>   - update qemu-options.hx with unix type
>   - fix HMP "info network" with unix protocol/server side.
>
> v4:
>   - net_client_parse() fails with exit() rather than with return.
>   - keep "{ 'name': 'vmnet-host', 'if': 'CONFIG_VMNET' }" on its
>     own line in qapi/net.json
>   - add a comment in qapi/net.json about parameters usage
>   - move netdev_is_modern() check to qemu_init()
>   - in netdev_is_modern(), check for JSON and use qemu_opts_do_parse()
>     to parse parameters and detect type value.
>   - add a blank line after copyright comment
>
> v3:
>   - remove support of "-net" for dgram and stream. They are only
>     supported with "-netdev" option.
>   - use &error_fatal directly in net_client_inits()
>   - update qemu-options.hx
>   - move to QIO for stream socket
>
> v2:
>   - use "stream" and "dgram" rather than "socket-ng,mode=3Dstream"
>     and ""socket-ng,mode=3Ddgram"
>   - extract code to bypass qemu_opts_parse_noisily() to
>     a new patch
>   - do not ignore EINVAL (Stefano)
>   - fix "-net" option
>
> CC: Ralph Schmieder <ralph.schmieder@gmail.com>
> CC: Stefano Brivio <sbrivio@redhat.com>
> CC: Daniel P. Berrang=C3=A9 <berrange@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
>
> Laurent Vivier (15):
>   net: introduce convert_host_port()
>   net: remove the @errp argument of net_client_inits()
>   net: simplify net_client_parse() error management
>   qapi: net: introduce a way to bypass qemu_opts_parse_noisily()
>   net: introduce qemu_set_info_str() function
>   qapi: net: add stream and dgram netdevs
>   net: stream: add unix socket
>   net: dgram: make dgram_dst generic
>   net: dgram: move mcast specific code from net_socket_fd_init_dgram()
>   net: dgram: add unix socket
>   qemu-sockets: move and rename SocketAddress_to_str()
>   qemu-sockets: update socket_uri() and socket_parse()  to be consistent
>   net: stream: move to QIO to enable additional parameters
>   tests/qtest: netdev: test stream and dgram backends
>   net: stream: add QAPI events to report connection state
>
> Stefano Brivio (2):
>   net: socket: Don't ignore EINVAL on netdev socket connection
>   net: stream: Don't ignore EINVAL on netdev socket connection
>
>  hmp-commands.hx             |   2 +-
>  hw/net/xen_nic.c            |   5 +-
>  include/net/net.h           |   7 +-
>  include/qemu/sockets.h      |   4 +-
>  monitor/hmp-cmds.c          |  23 +-
>  net/clients.h               |   6 +
>  net/dgram.c                 | 623 ++++++++++++++++++++++++++++++++++++
>  net/hub.c                   |   2 +
>  net/l2tpv3.c                |   3 +-
>  net/meson.build             |   2 +
>  net/net.c                   | 186 ++++++++---
>  net/slirp.c                 |   5 +-
>  net/socket.c                |  36 +--
>  net/stream.c                | 387 ++++++++++++++++++++++
>  net/tap-win32.c             |   3 +-
>  net/tap.c                   |  13 +-
>  net/vde.c                   |   3 +-
>  net/vhost-user.c            |   3 +-
>  net/vhost-vdpa.c            |   2 +-
>  qapi/net.json               | 115 ++++++-
>  qemu-options.hx             |  14 +
>  softmmu/vl.c                |  16 +-
>  tests/qtest/meson.build     |   1 +
>  tests/qtest/netdev-socket.c | 420 ++++++++++++++++++++++++
>  util/qemu-sockets.c         |  25 ++
>  25 files changed, 1775 insertions(+), 131 deletions(-)
>  create mode 100644 net/dgram.c
>  create mode 100644 net/stream.c
>  create mode 100644 tests/qtest/netdev-socket.c
>
> --
> 2.37.3
>
>



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 05:49:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 05:49:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427293.676197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olku6-0003c6-ND; Fri, 21 Oct 2022 05:49:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427293.676197; Fri, 21 Oct 2022 05:49:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olku6-0003bz-KM; Fri, 21 Oct 2022 05:49:10 +0000
Received: by outflank-mailman (input) for mailman id 427293;
 Fri, 21 Oct 2022 05:49:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1olku5-0003bt-7l
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 05:49:09 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 13120e88-5104-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 07:49:07 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-477-4DTeeM-2PU2WpFpu9IYBjA-1; Fri, 21 Oct 2022 01:49:02 -0400
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 689EF1C09B80;
 Fri, 21 Oct 2022 05:49:01 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 100741121315;
 Fri, 21 Oct 2022 05:48:56 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id ACD4321E6686; Fri, 21 Oct 2022 07:48:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13120e88-5104-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666331345;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QBX5KiLXbX7P8P3a+cVBh7Xtwe9pVLfUZQSamsMuzpw=;
	b=LF0NIm/57hDEF+T7TVMxv+bKmkGY6rzVlVkSOf6eSWJCQu/RE3qZTfySGFHuC2BDQhIInO
	NYMSKUGkG58G75RMsBplRqwN+uDMiuk4RSz/txZgga0EsYS6vJK7E5baJA5OtYf8UTdqH0
	QDvnMhLhkJOV66KRcJ5U+aq8vDgVsTw=
X-MC-Unique: 4DTeeM-2PU2WpFpu9IYBjA-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Paul Durrant <paul@xen.org>,  Thomas Huth
 <thuth@redhat.com>,  Daniel P. =?utf-8?Q?Berrang=C3=A9?=
 <berrange@redhat.com>,  "Dr. David
 Alan Gilbert" <dgilbert@redhat.com>,  Greg Kurz <groug@kaod.org>,  Stefano
 Stabellini <sstabellini@kernel.org>,  David Gibson
 <david@gibson.dropbear.id.au>,  Eric Blake <eblake@redhat.com>,
  xen-devel@lists.xenproject.org,  "Michael S. Tsirkin" <mst@redhat.com>,
  Stefan Weil <sw@weilnetz.de>,  Paolo Bonzini <pbonzini@redhat.com>,
  Jason Wang <jasowang@redhat.com>,  Samuel Thibault
 <samuel.thibault@ens-lyon.org>,  Anthony Perard
 <anthony.perard@citrix.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
Date: Fri, 21 Oct 2022 07:48:55 +0200
In-Reply-To: <20221020162558.123284-18-lvivier@redhat.com> (Laurent Vivier's
	message of "Thu, 20 Oct 2022 18:25:58 +0200")
Message-ID: <87pmel4th4.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3

Laurent Vivier <lvivier@redhat.com> writes:

> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.

Use cases?

Could similar event signalling be useful for other kinds of netdev
backends?

> The NETDEV_STREAM_CONNECTED event includes the URI of the destination
> address.

No more.  Easy fix: scratch "the URI of".

> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  net/stream.c  |  9 +++++++--
>  qapi/net.json | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 56 insertions(+), 2 deletions(-)
>
> diff --git a/net/stream.c b/net/stream.c
> index 95d6b910407d..cac01d4d792a 100644
> --- a/net/stream.c
> +++ b/net/stream.c
> @@ -38,6 +38,7 @@
>  #include "io/channel.h"
>  #include "io/channel-socket.h"
>  #include "io/net-listener.h"
> +#include "qapi/qapi-events-net.h"
>  
>  typedef struct NetStreamState {
>      NetClientState nc;
> @@ -168,6 +169,8 @@ static gboolean net_stream_send(QIOChannel *ioc,
>          s->nc.link_down = true;
>          qemu_set_info_str(&s->nc, "");
>  
> +        qapi_event_send_netdev_stream_disconnected(s->nc.name);
> +
>          return G_SOURCE_REMOVE;
>      }
>      buf = buf1;
> @@ -244,8 +247,8 @@ static void net_stream_listen(QIONetListener *listener,
>      uri = socket_uri(addr);
>      qemu_set_info_str(&s->nc, uri);
>      g_free(uri);
> +    qapi_event_send_netdev_stream_connected(s->nc.name, addr);
>      qapi_free_SocketAddress(addr);
> -

Don't add this blank line in PATCH 15, please.

>  }
>  
>  static void net_stream_server_listening(QIOTask *task, gpointer opaque)
> @@ -327,7 +330,6 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>          goto error;
>      }
>      g_assert(ret == 0);
> -    qapi_free_SocketAddress(addr);
>  
>      net_socket_rs_init(&s->rs, net_stream_rs_finalize, false);
>  
> @@ -338,6 +340,9 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
>                                              s, NULL);
>      s->nc.link_down = false;
>  
> +    qapi_event_send_netdev_stream_connected(s->nc.name, addr);
> +    qapi_free_SocketAddress(addr);
> +
>      return;
>  error:
>      object_unref(OBJECT(s->ioc));

Could put the qapi_free_SocketAddress() in its final place in PATCH 15
already to reduce churn.  Up to you.

> diff --git a/qapi/net.json b/qapi/net.json
> index 39388b1b6c41..c37b24717382 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -895,3 +895,52 @@
>  ##
>  { 'event': 'FAILOVER_NEGOTIATED',
>    'data': {'device-id': 'str'} }
> +
> +##
> +# @NETDEV_STREAM_CONNECTED:
> +#
> +# Emitted when the netdev stream backend is connected
> +#
> +# @netdev-id: QEMU netdev id that is connected
> +# @addr: The destination address
> +#
> +# Since: 7.2
> +#
> +# Example:
> +#
> +# <- { "event": "NETDEV_STREAM_CONNECTED",
> +#      "data": { "netdev-id": "netdev0",
> +#                "addr": { "port": "47666", "ipv6": true,
> +#                          "host": "::1", "type": "inet" } },
> +#      "timestamp": { "seconds": 1666269863, "microseconds": 311222 } }
> +#
> +# or
> +#
> +# <- { "event": "NETDEV_STREAM_CONNECTED",
> +#      "data": { "netdev-id": "netdev0",
> +#                "addr": { "path": "/tmp/qemu0", "type": "unix" } },
> +#      "timestamp": { "seconds": 1666269706, "microseconds": 413651 } }
> +#
> +##
> +{ 'event': 'NETDEV_STREAM_CONNECTED',
> +  'data': { 'netdev-id': 'str',
> +            'addr': 'SocketAddress' } }
> +
> +##
> +# @NETDEV_STREAM_DISCONNECTED:
> +#
> +# Emitted when the netdev stream backend is disconnected
> +#
> +# @netdev-id: QEMU netdev id that is disconnected
> +#
> +# Since: 7.2
> +#
> +# Example:
> +#
> +# <- { 'event': 'NETDEV_STREAM_DISCONNECTED',
> +#      'data': {'netdev-id': 'netdev0'},
> +#      'timestamp': {'seconds': 1663330937, 'microseconds': 526695} }
> +#
> +##
> +{ 'event': 'NETDEV_STREAM_DISCONNECTED',
> +  'data': { 'netdev-id': 'str' } }

Schema looks good to me.



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 05:50:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 05:50:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427299.676220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olkuy-0004u0-9m; Fri, 21 Oct 2022 05:50:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427299.676220; Fri, 21 Oct 2022 05:50:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olkuy-0004tt-4J; Fri, 21 Oct 2022 05:50:04 +0000
Received: by outflank-mailman (input) for mailman id 427299;
 Fri, 21 Oct 2022 05:50:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olkuw-0004kL-RK; Fri, 21 Oct 2022 05:50:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olkuw-0002LU-O4; Fri, 21 Oct 2022 05:50:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olkuw-0007sw-FK; Fri, 21 Oct 2022 05:50:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olkuw-00019U-Eq; Fri, 21 Oct 2022 05:50:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Jj4Mj5GqWnR7sRJrB6veFYvJ37yPRz3UZe4Ruo1Hp8g=; b=F+SXbOX5npSloc4qFOLr+yQwvJ
	TK7j36fvF0vVBy5WfUNC6IyrH84Jy7d0M+9Xskh3Bh6HFmtRBCHx2KPuL5GKZR+DAZdaCNiCcm+JY
	TWbNaEF8qZqOtKs6gnAnvKyDbt6QnIWQEXC9bgdy95lyavVzWBZTaPvIcpRWW1XnN+0k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174111-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174111: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:<job status>:broken:regression
    linux-linus:test-armhf-armhf-libvirt-raw:host-install(5):broken:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=aae703b02f92bde9264366c545e87cec451de471
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 05:50:02 +0000

flight 174111 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174111/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-libvirt-raw    <job status>                 broken
 test-armhf-armhf-libvirt-raw  5 host-install(5)        broken REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                aae703b02f92bde9264366c545e87cec451de471
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   13 days
Failing since        173470  2022-10-08 06:21:34 Z   12 days   21 attempts
Testing same since   174111  2022-10-20 01:26:57 Z    1 days    1 attempts

------------------------------------------------------------
1282 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 broken  
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-libvirt-raw broken
broken-step test-armhf-armhf-libvirt-raw host-install(5)

Not pushing.

(No revision log; it would be 121075 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:08:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:08:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427311.676230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollD2-0007Ok-3P; Fri, 21 Oct 2022 06:08:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427311.676230; Fri, 21 Oct 2022 06:08:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollD2-0007Od-0e; Fri, 21 Oct 2022 06:08:44 +0000
Received: by outflank-mailman (input) for mailman id 427311;
 Fri, 21 Oct 2022 06:08:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Jmp5=2W=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1ollD0-0007OX-G0
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:08:42 +0000
Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com
 [2a00:1450:4864:20::429])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce8ea428-5106-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 08:08:39 +0200 (CEST)
Received: by mail-wr1-x429.google.com with SMTP id f11so2766046wrm.6
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 23:08:40 -0700 (PDT)
Received: from [192.168.1.93] (adsl-70.109.242.225.tellas.gr. [109.242.225.70])
 by smtp.gmail.com with ESMTPSA id
 g15-20020adfe40f000000b00226dfac0149sm18194877wrm.114.2022.10.20.23.08.38
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 20 Oct 2022 23:08:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce8ea428-5106-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=ChZn3e9kGcPoptLn8C3xXXF9IN3U8sryoKJLNmf8AEo=;
        b=gG+uaK0wTBudUSkunxErEsYTEwQ9KMBzlzBjLLRKi8yc/QcWZjobbsdcpyGJksC84i
         nwG7j/cCIVG2EYtOH4W5p/m4s7Vb0Lz/3osP0adIknM/JfIuwNM1DyqNW6jez0DOWiEO
         kyw5WJmEQW4iOQnYLmaDVNprlF6KGNq4zPs/L71CFCdHGGAkUTZbdGb8hdguSJRk9qa4
         as2j4sWqVQ9cy8hN8PrhgT6YYknDtUVpPq+Ysb4vGwc82mUh7cw53VU4QkpaRJQA8cqA
         3E3lef2EgxjpXtPOolzMpgmg+xYckqjREn4Ugy0h/MfrEeQkvNUHjWDc0smBkz+fJyL9
         edkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=ChZn3e9kGcPoptLn8C3xXXF9IN3U8sryoKJLNmf8AEo=;
        b=N3E9+RW1Knr6HfTfPx2kuoLHbq+vW5uN7R8dJ4dT55XSe0Nk96w3AAC+7clKoecZ2Z
         3jvNUQoIULgyrjnriaTFxJA1FA6OmzdEsrGPytkVeTwyBYaKeFQ/dT0blhlHEAKomQtj
         lF3UojSTtAjh/0+AYs1rrYS5LOiYuH2/YpAniKPNbVPYrZtEZyPIyN4j6cvvaZ4XRp1J
         sxyWSY7K26y8seRaC0T/PbB1VrN+l1MwDOGWOxnZ6A1Ij024XJr/4yBTYBsT/iUrb9F0
         gTkQDIT00wDlqKGBwBCMDaZqRPsVZXYJriPDc8jhmRoIpGKqdYUwHwUmCf8zS6d9Z6Ku
         ukTQ==
X-Gm-Message-State: ACrzQf1wHTLhIpzSN+8f32hKem5cw3g4uUdxeGEvYPZ57GjEaz0jsNvL
	1cQqjJJ1PdqZJXA2tODM7s0=
X-Google-Smtp-Source: AMsMyM5qPEzHicUh5RvC1ttVo+I5BNX7gOPOLF29Ys9HkOigt24u0c12XeM7o5VM1nEPlYaKwsALhA==
X-Received: by 2002:a05:6000:1787:b0:231:9b3f:ce98 with SMTP id e7-20020a056000178700b002319b3fce98mr11164584wrg.253.1666332519731;
        Thu, 20 Oct 2022 23:08:39 -0700 (PDT)
Message-ID: <85e5cb11-ab58-5433-d456-fa831f4deccf@gmail.com>
Date: Fri, 21 Oct 2022 09:08:37 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Content-Language: en-US
To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Juergen Gross <jgross@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Oleksandr Tyshchenko <olekstysh@gmail.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
 <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
 <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
 <ded6c520-8f1a-6ee3-bbfa-3de7e1f74779@epam.com>
 <44fdaba0-15eb-0778-bacf-3937a36b0841@gmail.com>
 <174a4c06-b95a-c817-a400-f33cccd8d545@epam.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <174a4c06-b95a-c817-a400-f33cccd8d545@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/20/22 23:07, Oleksandr Tyshchenko wrote:
Hi Oleksandr
> 
> On 20.10.22 21:11, Xenia Ragiadakou wrote:
> 
> Hello Xenia
> 
> 
>> On 10/20/22 17:12, Oleksandr Tyshchenko wrote:
>>>
>>> On 20.10.22 11:24, Xenia Ragiadakou wrote:
>>>> On 10/19/22 22:41, Oleksandr Tyshchenko wrote:
>>>>
>>>> Hi Oleksandr
>>>
>>>
>>> Hello Xenia
>>>
>>>
>>>>
>>>>>
>>>>> On 19.10.22 11:47, Xenia Ragiadakou wrote:
>>>>>
>>>>> Hello Xenia
>>>>>
>>>>>> On 10/19/22 03:58, Stefano Stabellini wrote:
>>>>>>> On Sat, 15 Oct 2022, Oleksandr Tyshchenko wrote:
>>>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>>
>>>>>>>> Use the same "xen-grant-dma" device concept for the PCI devices
>>>>>>>> behind device-tree based PCI Host controller, but with one
>>>>>>>> modification.
>>>>>>>> Unlike for platform devices, we cannot use generic IOMMU bindings
>>>>>>>> (iommus property), as we need to support more flexible
>>>>>>>> configuration.
>>>>>>>> The problem is that PCI devices under the single PCI Host
>>>>>>>> controller
>>>>>>>> may have the backends running in different Xen domains and thus
>>>>>>>> have
>>>>>>>> different endpoints ID (backend domains ID).
>>>>>>>>
>>>>>>>> So use generic PCI-IOMMU bindings instead (iommu-map/iommu-map-mask
>>>>>>>> properties) which allows us to describe relationship between PCI
>>>>>>>> devices and backend domains ID properly.
>>>>>>>>
>>>>>>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>
>>>>>>> Now that I understood the approach and the reasons for it, I can
>>>>>>> review
>>>>>>> the patch :-)
>>>>>>>
>>>>>>> Please add an example of the bindings in the commit message.
>>>>>>>
>>>>>>>
>>>>>>>> ---
>>>>>>>> Slightly RFC. This is needed to support Xen grant mappings for
>>>>>>>> virtio-pci devices
>>>>>>>> on Arm at some point in the future. The Xen toolstack side is not
>>>>>>>> completely ready yet.
>>>>>>>> Here, for PCI devices we use more flexible way to pass backend
>>>>>>>> domid
>>>>>>>> to the guest
>>>>>>>> than for platform devices.
>>>>>>>>
>>>>>>>> Changes V1 -> V2:
>>>>>>>>        - update commit description
>>>>>>>>        - rebase
>>>>>>>>        - rework to use generic PCI-IOMMU bindings instead of generic
>>>>>>>> IOMMU bindings
>>>>>>>>
>>>>>>>> Previous discussion is at:
>>>>>>>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!3-vq7Edm3XfKtD5cnNjnOzDQvuo_XrhJ73yH-nPfqOkGGU0IjLG7R7MR_nAJCAPeOutHRLT44wKYwQwz3SauACie_ZAy$
>>>>>>>>
>>>>>>>>
>>>>>>>> [lore[.]kernel[.]org]
>>>>>>>>
>>>>>>>> Based on:
>>>>>>>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1__;!!GF_29dbcQIUBPA!3-vq7Edm3XfKtD5cnNjnOzDQvuo_XrhJ73yH-nPfqOkGGU0IjLG7R7MR_nAJCAPeOutHRLT44wKYwQwz3SauAEnMDHAq$
>>>>>>>>
>>>>>>>>
>>>>>>>> [git[.]kernel[.]org]
>>>>>>>> ---
>>>>>>>>      drivers/xen/grant-dma-ops.c | 87
>>>>>>>> ++++++++++++++++++++++++++++++++-----
>>>>>>>>      1 file changed, 76 insertions(+), 11 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/xen/grant-dma-ops.c
>>>>>>>> b/drivers/xen/grant-dma-ops.c
>>>>>>>> index daa525df7bdc..b79d9d6ce154 100644
>>>>>>>> --- a/drivers/xen/grant-dma-ops.c
>>>>>>>> +++ b/drivers/xen/grant-dma-ops.c
>>>>>>>> @@ -10,6 +10,7 @@
>>>>>>>>      #include <linux/module.h>
>>>>>>>>      #include <linux/dma-map-ops.h>
>>>>>>>>      #include <linux/of.h>
>>>>>>>> +#include <linux/pci.h>
>>>>>>>>      #include <linux/pfn.h>
>>>>>>>>      #include <linux/xarray.h>
>>>>>>>>      #include <linux/virtio_anchor.h>
>>>>>>>> @@ -292,12 +293,55 @@ static const struct dma_map_ops
>>>>>>>> xen_grant_dma_ops = {
>>>>>>>>          .dma_supported = xen_grant_dma_supported,
>>>>>>>>      };
>>>>>>>>      +static struct device_node *xen_dt_get_pci_host_node(struct
>>>>>>>> device
>>>>>>>> *dev)
>>>>>>>> +{
>>>>>>>> +    struct pci_dev *pdev = to_pci_dev(dev);
>>>>>>>> +    struct pci_bus *bus = pdev->bus;
>>>>>>>> +
>>>>>>>> +    /* Walk up to the root bus to look for PCI Host controller */
>>>>>>>> +    while (!pci_is_root_bus(bus))
>>>>>>>> +        bus = bus->parent;
>>>>>>>> +
>>>>>>>> +    return of_node_get(bus->bridge->parent->of_node);
>>>>>>>> +}
>>>>>>>
>>>>>>> It seems silly that we need to walk the hierachy that way, but I
>>>>>>> couldn't find another way to do it
>>>>>>>
>>>>>>>
>>>>>>>> +static struct device_node *xen_dt_get_node(struct device *dev)
>>>>>>>> +{
>>>>>>>> +    if (dev_is_pci(dev))
>>>>>>>> +        return xen_dt_get_pci_host_node(dev);
>>>>>>>> +
>>>>>>>> +    return of_node_get(dev->of_node);
>>>>>>>> +}
>>>>>>>> +
>>>>>>>> +static int xen_dt_map_id(struct device *dev, struct device_node
>>>>>>>> **iommu_np,
>>>>>>>> +             u32 *sid)
>>>>>>>> +{
>>>>>>>> +    struct pci_dev *pdev = to_pci_dev(dev);
>>>>>>>> +    u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
>>>>>>>> +    struct device_node *host_np;
>>>>>>>> +    int ret;
>>>>>>>> +
>>>>>>>> +    host_np = xen_dt_get_pci_host_node(dev);
>>>>>>>> +    if (!host_np)
>>>>>>>> +        return -ENODEV;
>>>>>>>> +
>>>>>>>> +    ret = of_map_id(host_np, rid, "iommu-map", "iommu-map-mask",
>>>>>>>> iommu_np, sid);
>>>>>>>> +    of_node_put(host_np);
>>>>>>>> +    return ret;
>>>>>>>> +}
>>>>>>>> +
>>>>>>>>      static bool xen_is_dt_grant_dma_device(struct device *dev)
>>>>>>>>      {
>>>>>>>> -    struct device_node *iommu_np;
>>>>>>>> +    struct device_node *iommu_np = NULL;
>>>>>>>>          bool has_iommu;
>>>>>>>>      -    iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>>>>>> +    if (dev_is_pci(dev)) {
>>>>>>>> +        if (xen_dt_map_id(dev, &iommu_np, NULL))
>>>>>>>> +            return false;
>>>>>>>> +    } else
>>>>>>>> +        iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>>>>>> +
>>>>>>>>          has_iommu = iommu_np &&
>>>>>>>>                  of_device_is_compatible(iommu_np, "xen,grant-dma");
>>>>>>>>          of_node_put(iommu_np);
>>>>>>>> @@ -307,9 +351,17 @@ static bool xen_is_dt_grant_dma_device(struct
>>>>>>>> device *dev)
>>>>>>>>        bool xen_is_grant_dma_device(struct device *dev)
>>>>>>>>      {
>>>>>>>> +    struct device_node *np;
>>>>>>>> +
>>>>>>>>          /* XXX Handle only DT devices for now */
>>>>>>>> -    if (dev->of_node)
>>>>>>>> -        return xen_is_dt_grant_dma_device(dev);
>>>>>>>> +    np = xen_dt_get_node(dev);
>>>>>>>> +    if (np) {
>>>>>>>> +        bool ret;
>>>>>>>> +
>>>>>>>> +        ret = xen_is_dt_grant_dma_device(dev);
>>>>>>>> +        of_node_put(np);
>>>>>>>> +        return ret;
>>>>>>>> +    }
>>>>>>>
>>>>>>> We don't need to walk the PCI hierachy twice. Maybe we can add the
>>>>>>> of_node check directly to xen_is_dt_grant_dma_device?
>>>>>>>
>>>>>>
>>>>>> I think in general we could pass directly the host bridge device if
>>>>>> dev_is_pci(dev) (which can be retrieved with
>>>>>> pci_get_host_bridge_device(to_pci_dev(dev), and after done with it
>>>>>> pci_put_host_bridge_device(phb)).
>>>>>> So that, xen_is_dt_grant_dma_device() and
>>>>>> xen_dt_grant_init_backend_domid() won't need to discover it
>>>>>> themselves.
>>>>>> This will simplify the code.
>>>>>
>>>>>
>>>>> Good point. I have some remark. Can we use pci_find_host_bridge()
>>>>> instead? This way we don't have to add #include "../pci/pci.h", and
>>>>> have
>>>>> to drop reference afterwards.
>>>>>
>>>>> With that xen_dt_get_pci_host_node() will became the following:
>>>>>
>>>>>
>>>>> static struct device_node *xen_dt_get_pci_host_node(struct device
>>>>> *dev)
>>>>> {
>>>>>         struct pci_host_bridge *bridge =
>>>>> pci_find_host_bridge(to_pci_dev(dev)->bus);
>>>>>
>>>>>         return of_node_get(bridge->dev.parent->of_node);
>>>>> }
>>>>>
>>>>
>>>> You are right. I prefer your version instead of the above.
>>>
>>>
>>> ok, thanks
>>>
>>>
>>>>
>>>>
>>>>>
>>>>> With Stefano's suggestion, we won't walk the PCI hierarchy twice when
>>>>> executing xen_is_grant_dma_device() for PCI device:
>>>>>
>>>>> xen_is_grant_dma_device() -> xen_is_dt_grant_dma_device() ->
>>>>> xen_dt_map_id() -> xen_dt_get_pci_host_node()
>>>>>
>>>>>
>>>>> What do you think?
>>>>>
>>>>
>>>> I was thinking passing the device_node along with the device in the
>>>> function arguments. More specifically, of doing this (not tested, just
>>>> an idea):
>>>>
>>>> bool xen_is_grant_dma_device(struct device *dev)
>>>> {
>>>>       struct device_node *np;
>>>>       bool has_iommu = false;
>>>>
>>>>       /* XXX Handle only DT devices for now */
>>>>       np = xen_dt_get_node(dev);
>>>>       if (np)
>>>>           has_iommu = xen_is_dt_grant_dma_device(dev, np);
>>>>       of_node_put(np);
>>>>       return has_iommu;
>>>> }
>>>>
>>>> static bool xen_is_dt_grant_dma_device(struct device *dev,
>>>>                                          struct device_node *np)
>>>> {
>>>>       struct device_node *iommu_np = NULL;
>>>>       bool has_iommu;
>>>>
>>>>       if (dev_is_pci(dev)) {
>>>>           struct pci_dev *pdev = to_pci_dev(dev);
>>>>       u32 id = PCI_DEVID(pdev->bus->number, pdev->devfn);
>>>>           of_map_id(np, id, "iommu-map", "iommu-map-mask", &iommu_np,
>>>> NULL);
>>>>       } else {
>>>>           iommu_np = of_parse_phandle(np, "iommus", 0);
>>>>       }
>>>>
>>>>       has_iommu = iommu_np && of_device_is_compatible(iommu_np,
>>>> "xen,grant-dma");
>>>>       of_node_put(iommu_np);
>>>>
>>>>       return has_iommu;
>>>> }
>>>
>>>
>>> I got it.
>>>
>>> xen_is_grant_dma_device() for V3 won't call xen_dt_get_node(), but call
>>> xen_is_dt_grant_dma_device() directly.
>>>
>>> static bool xen_is_dt_grant_dma_device(struct device *dev)
>>> {
>>>        struct device_node *iommu_np = NULL;
>>>        bool has_iommu;
>>>
>>>        if (dev_is_pci(dev)) {
>>>            if (xen_dt_map_id(dev, &iommu_np, NULL))
>>>                return false;
>>>        } else if (dev->of_node)
>>>            iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
>>>        else
>>>            return false;
>>>
>>>        has_iommu = iommu_np &&
>>>                of_device_is_compatible(iommu_np, "xen,grant-dma");
>>>        of_node_put(iommu_np);
>>>
>>>        return has_iommu;
>>> }
>>>
>>> bool xen_is_grant_dma_device(struct device *dev)
>>> {
>>>        /* XXX Handle only DT devices for now */
>>>        return xen_is_dt_grant_dma_device(dev);
>>> }
>>>
>>>
>>
>> Ok. One difference, that I see from the previous, is that here you
>> don't use the dynamic interface when you access the dev->of_node
>> (of_node_get/of_node_put). Before, this was guarded through the
>> external xen_dt_get_node().
>>
>> I suspect that the same needs to be done for the function
>> xen_grant_setup_dma_ops(). There, also, the code walks up to the root
>> bus twice.
> 
> 
> Hmm, xen_dt_grant_init_backend_domid() should only be called if we deal
> with device-tree based device.
> 
> I think you are completely right, thanks!
> 
> In order to address both your comments, I think I need to rework the
> code (taking into the account your example with xen_is_dt_grant_dma_device()
> 
> provided a few letters ago and extrapolate this example to
> xen_dt_grant_init_backend_domid()). Below the patch (not tested) which
> seems to address both your comments (also I dropped
> 
> xen_dt_map_id() and squashed xen_dt_get_pci_host_node() with
> xen_dt_get_node()).
> 
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index daa525df7bdc..dae24dbd2ef7 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>    #include <linux/module.h>
>    #include <linux/dma-map-ops.h>
>    #include <linux/of.h>
> +#include <linux/pci.h>
>    #include <linux/pfn.h>
>    #include <linux/xarray.h>
>    #include <linux/virtio_anchor.h>
> @@ -292,12 +293,33 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>           .dma_supported = xen_grant_dma_supported,
>    };
> 
> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> +static struct device_node *xen_dt_get_node(struct device *dev)
>    {
> -       struct device_node *iommu_np;
> +       if (dev_is_pci(dev)) {
> +               struct pci_dev *pdev = to_pci_dev(dev);
> +               struct pci_host_bridge *bridge =
> pci_find_host_bridge(pdev->bus);
> +
> +               return of_node_get(bridge->dev.parent->of_node);
> +       }
> +
> +       return of_node_get(dev->of_node);
> +}
> +

It does not seem right to me to expose the struct pci_host_bridge (which 
we would need to check if it is null by the way). I would prefer your 
version for the above i.e
static struct device_node *xen_dt_get_node(struct device *dev)
{
	if (dev_is_pci(dev)) {
		struct pci_bus *bus = to_pci_dev(dev)->bus;

		/* Walk up to the root bus to look for PCI Host controller */
		while (!pci_is_root_bus(bus))
			bus = bus->parent;
		return of_node_get(bus->bridge->parent->of_node);
	}

	return of_node_get(dev->of_node);
}

> +static bool xen_is_dt_grant_dma_device(struct device *dev,
> +                                       struct device_node *np)
> +{
> +       struct device_node *iommu_np = NULL;
>           bool has_iommu;
> 
> -       iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +       if (dev_is_pci(dev)) {
> +               struct pci_dev *pdev = to_pci_dev(dev);
> +               u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +
> +               if (of_map_id(np, rid, "iommu-map", "iommu-map-mask",
> &iommu_np, NULL))
> +                       return false;
> +       } else
> +               iommu_np = of_parse_phandle(np, "iommus", 0);
> +
>           has_iommu = iommu_np &&
>                       of_device_is_compatible(iommu_np, "xen,grant-dma");
>           of_node_put(iommu_np);
> @@ -307,9 +329,17 @@ static bool xen_is_dt_grant_dma_device(struct
> device *dev)
> 
>    bool xen_is_grant_dma_device(struct device *dev)
>    {
> +       struct device_node *np;
> +
>           /* XXX Handle only DT devices for now */
> -       if (dev->of_node)
> -               return xen_is_dt_grant_dma_device(dev);
> +       np = xen_dt_get_node(dev);
> +       if (np) {
> +               bool ret;
> +
> +               ret = xen_is_dt_grant_dma_device(dev, np);
> +               of_node_put(np);
> +               return ret;
> +       }
> 
>           return false;
>    }

> @@ -323,14 +353,26 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
>    }
> 
>    static int xen_dt_grant_init_backend_domid(struct device *dev,
> +                                          struct device_node *np,
>                                              struct xen_grant_dma_data *data)
>    {
> -       struct of_phandle_args iommu_spec;
> +       struct of_phandle_args iommu_spec = { .args_count = 1 };
> 
> -       if (of_parse_phandle_with_args(dev->of_node, "iommus",
> "#iommu-cells",
> -                       0, &iommu_spec)) {
> -               dev_err(dev, "Cannot parse iommus property\n");
> -               return -ESRCH;
> +       if (dev_is_pci(dev)) {
> +               struct pci_dev *pdev = to_pci_dev(dev);
> +               u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +
> +               if (of_map_id(np, rid, "iommu-map", "iommu-map-mask",
> &iommu_spec.np,
> +                               iommu_spec.args)) {
> +                       dev_err(dev, "Cannot translate ID\n");
> +                       return -ESRCH;
> +               }
> +       } else {
> +               if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
> +                               0, &iommu_spec)) {
> +                       dev_err(dev, "Cannot parse iommus property\n");
> +                       return -ESRCH;
> +               }
>           }
> 

IMO, instead of passing struct xen_grant_dma_data *data to 
xen_dt_grant_init_backend_domid(), you could pass domid_t *backend_domid 
(e.g xen_dt_grant_init_backend_domid(dev, np, &data->backend_domid)).
I think this way the internal struct xen_grant_dma_datain is manipulated 
in a single place and xen_dt_grant_init_backend_domid() does not depend 
on it.

>           if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> @@ -354,6 +396,7 @@ static int xen_dt_grant_init_backend_domid(struct
> device *dev,
>    void xen_grant_setup_dma_ops(struct device *dev)
>    {
>           struct xen_grant_dma_data *data;
> +       struct device_node *np;
> 
>           data = find_xen_grant_dma_data(dev);
>           if (data) {
> @@ -365,8 +408,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>           if (!data)
>                   goto err;
> 
> -       if (dev->of_node) {
> -               if (xen_dt_grant_init_backend_domid(dev, data))
> +       np = xen_dt_get_node(dev);
> +       if (np) {
> +               int ret;
> +
> +               ret = xen_dt_grant_init_backend_domid(dev, np, data);
> +               of_node_put(np);
> +               if (ret)
>                           goto err;
>           } else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>                   dev_info(dev, "Using dom0 as backend\n");
> 
> 
> Does it look ok now?

That is what I had in mind. I do not know if Stefano agrees with this 
approach.

>>
>>
>>>>
>>>> I 'm wondering ... is it possible for the host bridge device node to
>>>> have the iommus property set? meaning that all of its pci devs will
>>>> have the same backend?
>>>
>>> Good question. I think, it is possible... This is technically what V1 is
>>> doing.
>>>
>>>
>>> Are you asking because to support "iommus" for PCI devices as well to
>>> describe that use-case with all PCI devices having the same endpoint ID
>>> (backend ID)?
>>> If yes, I think, this could be still described by "iommu-map" property,
>>> something like that (if we don't want to describe mapping for each PCI
>>> device one-by-one).
>>>
>>> iommu-map = <0x0 &iommu X 0x1>;
>>>
>>> iommu-map-mask = <0x0>;
>>>
>>> where the X is backend ID.
>>>
>>>
>>> It feels to me that it should be written down somewhere that for
>>> platform devices we expect "iommus" and for PCI devices we expect
>>> "iommu-map/iommu-map-mask" to be present.
>>
>> Thanks for the clarification, now I got it. Yes I agree.
> 
> 
> ok, good
> 
> 
>>
>>>>
>>>>
>>>>>>
>>>>>>>
>>>>>>>>          return false;
>>>>>>>>      }
>>>>>>>> @@ -325,12 +377,19 @@ bool xen_virtio_mem_acc(struct virtio_device
>>>>>>>> *dev)
>>>>>>>>      static int xen_dt_grant_init_backend_domid(struct device *dev,
>>>>>>>>                             struct xen_grant_dma_data *data)
>>>>>>>>      {
>>>>>>>> -    struct of_phandle_args iommu_spec;
>>>>>>>> +    struct of_phandle_args iommu_spec = { .args_count = 1 };
>>>>>>>>      -    if (of_parse_phandle_with_args(dev->of_node, "iommus",
>>>>>>>> "#iommu-cells",
>>>>>>>> -            0, &iommu_spec)) {
>>>>>>>> -        dev_err(dev, "Cannot parse iommus property\n");
>>>>>>>> -        return -ESRCH;
>>>>>>>> +    if (dev_is_pci(dev)) {
>>>>>>>> +        if (xen_dt_map_id(dev, &iommu_spec.np, iommu_spec.args)) {
>>>>>>>> +            dev_err(dev, "Cannot translate ID\n");
>>>>>>>> +            return -ESRCH;
>>>>>>>> +        }
>>>>>>>> +    } else {
>>>>>>>> +        if (of_parse_phandle_with_args(dev->of_node, "iommus",
>>>>>>>> "#iommu-cells",
>>>>>>>> +                0, &iommu_spec)) {
>>>>>>>> +            dev_err(dev, "Cannot parse iommus property\n");
>>>>>>>> +            return -ESRCH;
>>>>>>>> +        }
>>>>>>>>          }
>>>>>>>>            if (!of_device_is_compatible(iommu_spec.np,
>>>>>>>> "xen,grant-dma") ||
>>>>>>>> @@ -354,6 +413,7 @@ static int
>>>>>>>> xen_dt_grant_init_backend_domid(struct device *dev,
>>>>>>>>      void xen_grant_setup_dma_ops(struct device *dev)
>>>>>>>>      {
>>>>>>>>          struct xen_grant_dma_data *data;
>>>>>>>> +    struct device_node *np;
>>>>>>>>            data = find_xen_grant_dma_data(dev);
>>>>>>>>          if (data) {
>>>>>>>> @@ -365,8 +425,13 @@ void xen_grant_setup_dma_ops(struct device
>>>>>>>> *dev)
>>>>>>>>          if (!data)
>>>>>>>>              goto err;
>>>>>>>>      -    if (dev->of_node) {
>>>>>>>> -        if (xen_dt_grant_init_backend_domid(dev, data))
>>>>>>>> +    np = xen_dt_get_node(dev);
>>>>>>>> +    if (np) {
>>>>>>>> +        int ret;
>>>>>>>> +
>>>>>>>> +        ret = xen_dt_grant_init_backend_domid(dev, data);
>>>>>>>> +        of_node_put(np);
>>>>>>>> +        if (ret)
>>>>>>>>                  goto err;
>>>>>>>>          } else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>>>>>>>>              dev_info(dev, "Using dom0 as backend\n");
>>>>>>>> -- 
>>>>>>>> 2.25.1
>>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:10:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:10:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427317.676245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollF4-0000K5-Gn; Fri, 21 Oct 2022 06:10:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427317.676245; Fri, 21 Oct 2022 06:10:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollF4-0000Jw-De; Fri, 21 Oct 2022 06:10:50 +0000
Received: by outflank-mailman (input) for mailman id 427317;
 Fri, 21 Oct 2022 06:10:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ollF2-0000Jq-IL
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:10:48 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19ffb296-5107-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 08:10:46 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 97A9B22C54;
 Fri, 21 Oct 2022 06:10:46 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 639DF1331A;
 Fri, 21 Oct 2022 06:10:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id vebXFuY3UmPVCgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 06:10:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19ffb296-5107-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666332646; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=bqLHr7xdf2s6MPXaZzVuVmeRug0iVbBjWqS+JN8wLsY=;
	b=qdbyNn41WzhxHZkEOemYZwVqnx1+UsCP1rGvHjTw2/DM0dzbU71AlbWVfTlzFbaNWDhEzS
	4G4E8NZYu4I1JQF+9iY1QFYibNacXn9Iz7rhHSsUKtS8GlSXZcFZI1Oz7N0To/wGwevBj+
	3zUPS4Jv8GmZ0roJbcxsaDh/4LViHW8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Meng Xu <mengxu@cis.upenn.edu>,
	George Dunlap <george.dunlap@citrix.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Date: Fri, 21 Oct 2022 08:10:42 +0200
Message-Id: <20221021061042.12083-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When a domain gets paused the unit runnable state can change to "not
runnable" without the scheduling lock being involved. This means that
a specific scheduler isn't involved in this change of runnable state.

In the RTDS scheduler this can result in an inconsistency in case a
unit is losing its "runnable" capability while the RTDS scheduler's
scheduling function is active. RTDS will remove the unit from the run
queue, but doesn't do so for the replenish queue, leading to hitting
an ASSERT() in replq_insert() later when the domain is unpaused again.

Fix that by removing the unit from the replenish queue as well in this
case.

Fixes: 7c7b407e7772 ("xen/sched: introduce unit_runnable_state()")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/sched/rt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index d6de25531b..960a8033e2 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -1087,6 +1087,7 @@ rt_schedule(const struct scheduler *ops, struct sched_unit *currunit,
         else if ( !unit_runnable_state(snext->unit) )
         {
             q_remove(snext);
+            replq_remove(ops, snext);
             snext = rt_unit(sched_idle_unit(sched_cpu));
         }
 
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:14:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:14:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427324.676259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollIh-00013a-4Z; Fri, 21 Oct 2022 06:14:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427324.676259; Fri, 21 Oct 2022 06:14:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollIh-00013T-1q; Fri, 21 Oct 2022 06:14:35 +0000
Received: by outflank-mailman (input) for mailman id 427324;
 Fri, 21 Oct 2022 06:14:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ollIg-00013N-6X
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:14:34 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20079.outbound.protection.outlook.com [40.107.2.79])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ff9d13f-5107-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 08:14:31 +0200 (CEST)
Received: from AS9PR06CA0598.eurprd06.prod.outlook.com (2603:10a6:20b:486::32)
 by AM8PR08MB5713.eurprd08.prod.outlook.com (2603:10a6:20b:1dc::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 21 Oct
 2022 06:14:27 +0000
Received: from VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:486:cafe::97) by AS9PR06CA0598.outlook.office365.com
 (2603:10a6:20b:486::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.36 via Frontend
 Transport; Fri, 21 Oct 2022 06:14:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT017.mail.protection.outlook.com (100.127.145.12) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.19 via Frontend Transport; Fri, 21 Oct 2022 06:14:27 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 21 Oct 2022 06:14:26 +0000
Received: from eec376f882ea.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CBC63644-DF55-414D-95C6-4B858FDBC2BA.1; 
 Fri, 21 Oct 2022 06:14:20 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eec376f882ea.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 06:14:20 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB7839.eurprd08.prod.outlook.com (2603:10a6:20b:52e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 06:14:18 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 06:14:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ff9d13f-5107-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=a4pjqNJRiMmalQWG1DwTuGWnJXHxlTbtKI0QmSakQnFJxx8/YjsoP5oX0W1OoRJV+vDfjXR7YjJbxoRjCSMzFYZeJzwZKdvb94uhakjOpw6Di0MtLapRGbmovAn6Pn0H0/2ojxYonysVMDj3jAv1Vp1QXHIpx906L4eOnHJiZsmPKh8Aghs1Xhw2wJoMRVdUoSQU/p6UGaUURhPjfRJJKxXBtpJQhSdcsNprouVMFXxiTnPSoDDMPmbnQJM3noeGSEqjTqXFGcLgl/AmiysVhVNH7KTDBNqzvUDcKCFXPUWqvBJtHJFMFQWw+Lm1UyIXHVG5TkwX1DwU+Z4ZxVutRg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TKMx7cjayhGES3G8jN+5b5BKkccbaSW3tboBnzSFJRg=;
 b=PIpnclx+SSmCg9aHql2MiX6F/qPNAbNBUFpu8tfDZQE4StAVVabA0GDZc1nfanOgKr3TcftCR+ZYAYYk5CABPuP4lLCdOXkty/tek0mBGLdGQMXwIdWInx8TVpO+CKumbx+TIS2ipQMJ77ffWjU3jPkhp4Q1039SgmMboPGznWhd7Zk46/LsP8h2wbNCupNXgHVb1zPne3DJ51ygUSoqrZbMeCAErYWG8BYT81oq+64BvBGX49c570RHxOm+wmLvZ0z7xKlobLx4ff2UIvxiTPkDUlFPM/i/w6AJ8TVEHZs/TetfgcbpJbN6tGuIkYbvDWSROxic1/U/MBUbxv+VgQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TKMx7cjayhGES3G8jN+5b5BKkccbaSW3tboBnzSFJRg=;
 b=D0CJPh5RV7UvHuf8zKIlVnFIwr2f+XJTM/7o0ft0nV8c+KfZJXz6DPbfXogxo2mfAsY9xI47Uiw7HTu6R3aNMvTXMfzC0qZLWu+QEUEnf3AL7gtx/rU9BfZA63OQnzBw+tmP4E2o5wZsdKKzLGCne0+3ZPo04ru1tlSkzr8Nowo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FkZgtrRVOZZuS1SFAi4nlaJpjsUsJUHMFW+HGIgPGa8JNDpTL93DyfwSMVjOnYWTx89zaBg2yybr568gl4lLliJrcQVWCe1evXsBOWXgCEzIPx7b8fpdOVudQC09aCzFw1B2DfpugC5fg1TtNrN5TXs8zW/CZBFpjbU6ozlQGq2Wz/JMJd36sWjpJCPAxtUgYsbzK8AdpUuXA5W64Wddvc5dPLsfZwP0qzRV/wVO43dJM149kKmDbvlclg8XSqTBquSouarBoWvp+cp7VXaxwE9HAJYFlLdJHyBNniiBXwFzMHwil7tNYQ5L2UAei5E9kbE+x1NtdFTvNDa5kObcBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TKMx7cjayhGES3G8jN+5b5BKkccbaSW3tboBnzSFJRg=;
 b=NFYHhHRwzoDZY/iGjDVRmWsU0OSMEJpXXIptxaw3eZk2mNLsFpurNlA/70S1VOkCxwEBf6WzrTcSUbGQgSTa78t6+RVALU4mSSkIEiozwOdnJO6u1zktjYnINuUitWE9HhDmgNFHr7yAgp1TgM0SHLbksdzMA/9GhHAJ0ALfppsaSuIpY7YSGLwCM1tTGyoVyZNwz+XsUciWp4/G/MPFkplKucxNAjIUFJQWwBDBY7zDQXic4jZeqobvXun99TvMLunnPDYkC9QLVyiz+Sx3mZsGNE5EbGxHEbgY/Z7F0BX7VmcNUf+LJYSXpkyxVin4AUfEzsjodxoKLEw1NSMNaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TKMx7cjayhGES3G8jN+5b5BKkccbaSW3tboBnzSFJRg=;
 b=D0CJPh5RV7UvHuf8zKIlVnFIwr2f+XJTM/7o0ft0nV8c+KfZJXz6DPbfXogxo2mfAsY9xI47Uiw7HTu6R3aNMvTXMfzC0qZLWu+QEUEnf3AL7gtx/rU9BfZA63OQnzBw+tmP4E2o5wZsdKKzLGCne0+3ZPo04ru1tlSkzr8Nowo=
From: Henry Wang <Henry.Wang@arm.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	George Dunlap <george.dunlap@citrix.com>
Subject: RE: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Thread-Topic: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Thread-Index: AQHY5RPn4YgYN4uuDkuaQs+f2Uthxa4YXmcQ
Date: Fri, 21 Oct 2022 06:14:18 +0000
Message-ID:
 <AS8PR08MB7991574CCEAE030A6236F6E2922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221021061042.12083-1-jgross@suse.com>
In-Reply-To: <20221021061042.12083-1-jgross@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 4A04E0102FFAA349A1195F3288038433.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB7839:EE_|VI1EUR03FT017:EE_|AM8PR08MB5713:EE_
X-MS-Office365-Filtering-Correlation-Id: 6153487e-333f-4842-61c3-08dab32b81ed
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LOBIVRxaaaTaxxHPTWXQOytXN+g7cAa+mC/yg4xGNKkP4Oz3AzseCEQpwsJQadKMo3xL8iGXnTbBMHVYSYZyN36oGFFZ2JGMsx9uuZNmfJJkfOgI0wqWhiFXL535djwzNYuBgfl+xRBgSI5OyaK6fB8zg/VGOXLXO6io2L5zxE5xmLrjSVJzWFVwAfEVFS/YC/P+fhzKWf9xKW5h7lI0ghFo3tkwCp3SklxuFkD+APnFeVnGwwrFruFJ8AB6w5QX6TmRYEWbsAP+uRxTaQhlb/LDz2klyGCsG+6sLH/4mAut1fsgNfv0+iRoKJrshSoUdoT5Sg3u6NbuQiR3ouoPHvbYwMHEJXIhy8pnKkOKsH1zsYdg1Trl6TSilzgk7EkNgIPhGbZMDakfdl4Uu3Lqwmz5mRBBNv6tcpMKgSu2iTlYXGAEjmHX2V8+iSgPaYczCmbMv4fKPnspbkLLa83LJlnCWvrVCmQh8k1nkXCQCNP3Tnf8Ngo4RkQf80ThuLRa221nnbL2yUg76NeAjkY9tpk26JWG+vU+QSNZuCSJy+d/xRIGFzOCSJqeW4aAvvTUPyvh1J/eFiB5sdFlx2Z/RWPX4pRSlLIgsAi6fUQL+MnStD7SIjswZdUPHxlpPHMaWvgmHwBwXONqshb0UhM4n2aV4nZImPymCBJOKVNREWL199JheXcpm2zTuAe7BA6ULL2t55WrYmFBdrp+gZ5aHSpDoLSZUibhwel/TqlnQMKs/7IQNjp50+5eGTSFSK5lN1duSTT8Nw+f1eNS379Qaw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199015)(110136005)(71200400001)(186003)(83380400001)(38100700002)(38070700005)(8936002)(122000001)(54906003)(2906002)(5660300002)(4326008)(64756008)(8676002)(52536014)(86362001)(41300700001)(7696005)(9686003)(316002)(6506007)(26005)(55016003)(66446008)(66476007)(66946007)(478600001)(66556008)(76116006)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7839
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c9f345de-0abc-46f0-f1e8-08dab32b7ca1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6yIQpPCe6egx7DCbwoBV4LfJ9/+TIkm1TyuvlBWELtFXrRmshe7TQtMJpDk3DqxNolkgWmNe5ZXvmVKQrtQ8AQcxR5V+P2RMZrSNNCWyvXl+crFLexGYSfjaIcwMSe9rNs+1slC/+rH1En2tutnouYFlbF0E6lDzNgn/t9IMqLunIZIKTWreKaWblkb/3VSYXQw+zs4UPdmSfWCA6qffwZF/kW1INBtjxYJMp5jJYx5B4asTGPpuXrYl3Hj0rCqFNX5B9qfPaO8Y5xqoZlZnJMn7wD8aFsWm25STyGxtDGSnBIWMHCst20eo9tJ49goUSrWhR0yLD7nlWbB9U37RmKPnALY4AQ+tHNU47fsxCB6m3d7GsadRxBrVgXH6gar4vuqnXseuMVxWY3QJaKsd1Kxg1YjD8yVgbKb7jeGqfifhxhpEH7M+2c0G6ymTpEwYEnuDWAO1eCbmE8xQwWE9t4uNzw9IwGuzBJ1HDHP/Dlx4HOU4Fhxgs2pSeklWQrOJlmR+GYiJi8CjggyeyQJh8dtxaAo0o+rHPCnvv59hsEcmqIvzoXAB+0H3jftlQkWmW9d0NdGLmtEpsKJfOFjlY+c+3Ry5w3Epf9u5f48SaE5yLtkzSLr3cgMd/jckrxcUaXAUWFcf0EYZohB6lX/tMPbx/zCzN2Ik3ORNvCRNyPx7aGEMI6f8o6Rm68HBLq6l9RLt3oosCxWDXdsbdBLviJTrh9/uKE30E4kWxSAPt4RYRnKxlLD3wOujqxtT+MPr1cod1PhrqKMqtnI3y10o8g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199015)(40470700004)(36840700001)(46966006)(478600001)(82310400005)(82740400003)(81166007)(36860700001)(356005)(110136005)(54906003)(86362001)(316002)(83380400001)(47076005)(107886003)(26005)(9686003)(33656002)(2906002)(186003)(40480700001)(336012)(55016003)(8676002)(4326008)(40460700003)(70586007)(70206006)(8936002)(5660300002)(52536014)(6506007)(41300700001)(7696005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 06:14:27.0192
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6153487e-333f-4842-61c3-08dab32b81ed
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5713

Hi Juergen,

> -----Original Message-----
> From: Juergen Gross <jgross@suse.com>
> Subject: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
>=20
> When a domain gets paused the unit runnable state can change to "not
> runnable" without the scheduling lock being involved. This means that
> a specific scheduler isn't involved in this change of runnable state.
>=20
> In the RTDS scheduler this can result in an inconsistency in case a
> unit is losing its "runnable" capability while the RTDS scheduler's
> scheduling function is active. RTDS will remove the unit from the run
> queue, but doesn't do so for the replenish queue, leading to hitting
> an ASSERT() in replq_insert() later when the domain is unpaused again.
>=20
> Fix that by removing the unit from the replenish queue as well in this
> case.
>=20
> Fixes: 7c7b407e7772 ("xen/sched: introduce unit_runnable_state()")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Thanks for the quick fix.

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

> ---
>  xen/common/sched/rt.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
> index d6de25531b..960a8033e2 100644
> --- a/xen/common/sched/rt.c
> +++ b/xen/common/sched/rt.c
> @@ -1087,6 +1087,7 @@ rt_schedule(const struct scheduler *ops, struct
> sched_unit *currunit,
>          else if ( !unit_runnable_state(snext->unit) )
>          {
>              q_remove(snext);
> +            replq_remove(ops, snext);
>              snext =3D rt_unit(sched_idle_unit(sched_cpu));
>          }
>=20
> --
> 2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:38:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:38:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427338.676275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollfU-0003jC-3N; Fri, 21 Oct 2022 06:38:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427338.676275; Fri, 21 Oct 2022 06:38:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollfU-0003j5-0e; Fri, 21 Oct 2022 06:38:08 +0000
Received: by outflank-mailman (input) for mailman id 427338;
 Fri, 21 Oct 2022 06:38:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GHCM=2W=epam.com=prvs=22938c9a9a=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1ollfS-0003iw-Tb
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:38:07 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9a31500-510a-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 08:38:04 +0200 (CEST)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29L2tXcp028043;
 Fri, 21 Oct 2022 06:37:58 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3kb6am2naw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 21 Oct 2022 06:37:57 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB9PR03MB7322.eurprd03.prod.outlook.com (2603:10a6:10:220::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 06:37:46 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022
 06:37:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9a31500-510a-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IelW7y/DVg4AQA+zV2VEdLSWJaoQFQ728ifWrIlJxnXT7cpARWvFVf9El5XIzoqebmWeH10FbKNLapLQttiRrjJVUaRdrcSNECkfon7aJwkDhqXoJuNKolhRO1rpod1IKgmjzx0YCuySPIqfGNRpnAItZa97wwK10HTeV6P/LDx+IYgHJO7QS1WKuBNstdiiFaO+GlvyPL4ymAMaPnA8QpdBDjemPmL0+eWjOxSWNpX+QKYh/wD9vnKiclwwECsTCrerhA/ctJbxZoON/eNcQCeNwETqN1LRLflKHGTPEGejB9BkCRFWUcaAQwtefULu1Sq1bFA2O0026MSI+Ni3AA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SgVUIzoJmiHwaJ+3dCLBLUfzTNH84CcrokhkRw7JkIY=;
 b=IAKRzWR2DRBpchT4uSm/7ku3ioplAfn3MYcoPmX/N1vUNdZeSlL42iUh1+Sg0QP0cwiv/wNsp2aOrGdjKF0kyzgxrHOZNI2Z4Tc2q4Fvjib3ttMb/12qYtzkMlEJ8uGg7KuNawOBd4idE3T45QdV9ngL1yapwuMQAfrQ2n259mSt3vR1Gmc5eH7/NCC3ohB8OBqosJasQLgwrXF+cvaqzt3/4/jeREcJTfyT6nj/5aEGXuq5PY7Rlaxp8ftHbLUAbB+5yLedRvfKgZQuDrp9rZth34NasKKE3u7cN/ZSILn/NrqjA6EGa5KJi6vwfO+MSKGfcZ2Z7KYA7yihQJiWWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=SgVUIzoJmiHwaJ+3dCLBLUfzTNH84CcrokhkRw7JkIY=;
 b=mUq7YgVjtOsKyMTr7elH4GfukjCXyGBOUfe/nxog4e68np0YTw1wv+kDiRYrTvAPuBEEUSuL+07D6AWdV+Lp/CwTxlmvEjc5AKq2c8P0on/G8QZYD2MK4P5rXklZ0dQCER+6c0Awpvk2l6wdI5pf3u2RgmDJPqujhKJq761Vwp5ooQRSf5ieNjuD7ESDzjlccrsDd5HQe3/OzgnBQEL8IyzeL1BBqqziIIHEIITwgZkwDnS0aga9gpw/KnlMMCY7G7caw9X0B6E3g+/YL01kRZOgkfydGkQsDorQVBFbNNi3YUzbHYTqMNXYfG6V5oJp2VacjLDHl9bHpJb4l61iZg==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Juergen Gross
	<jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr
 Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: 
 AQHY4Kumvdf5iGxWnUC7MiB1sxm3b64U6lSAgACDRYCAALaPgIAA1SMAgABhSgCAAELoAIAAIHAAgACn2YCAAAgkgA==
Date: Fri, 21 Oct 2022 06:37:45 +0000
Message-ID: <066cdb9d-cebe-b396-de99-d7a8ae577abe@epam.com>
References: <20221015153409.918775-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210181734440.4587@ubuntu-linux-20-04-desktop>
 <19823a2a-bc84-5458-bb69-7ac0c1b81573@gmail.com>
 <41b56c3f-1b81-a953-2e75-5a3ab8ef82a2@epam.com>
 <da0d72d1-3398-8005-1c40-b5f341ff9fc8@gmail.com>
 <ded6c520-8f1a-6ee3-bbfa-3de7e1f74779@epam.com>
 <44fdaba0-15eb-0778-bacf-3937a36b0841@gmail.com>
 <174a4c06-b95a-c817-a400-f33cccd8d545@epam.com>
 <85e5cb11-ab58-5433-d456-fa831f4deccf@gmail.com>
In-Reply-To: <85e5cb11-ab58-5433-d456-fa831f4deccf@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DB9PR03MB7322:EE_
x-ms-office365-filtering-correlation-id: 2e366f34-f2bb-4d5e-0a8a-08dab32ec3b2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 YyAYhQrBGqCWMFP//xHGIZ2kyt6gK5OAxGFFDfRNTQN6Jc24UvaX0BNyFPDisVaUjGQJnP1aB21p6KG6Plf7atnkZypRSoM7Uj0PTDp2M33+r/xsUYKnxCfi71KzO+WTfxAOccg0suRCgkTut0DPaCxWgVrtJn9rkV1H+pNgXIe+Ju42PTx14MjMHb5GPmldy9f+oaFbSV8JbpXNd1zU+11QvGQuv+0LP08qJmvDBM0H/piDaLfV0zgQ78LD9hjuQ8w4mElPaadd3lfqJEhWzmHkKuJH4Uv/9zLzmH0o3Pz2YhzjMeoKiPVtUd6OPMjnB8xMXnFl0q2KtXFrcbZfJMsTvi0cMpIT/Xh7FmZFWShfmZmhz46BRE3+ArYBWWoIohjB+OPMP/RyocjSirfhi/WhCZ917ZBVXEz1JQpsMX8amuMeja36amj/cGrZjPJQfHK/yJXE32jVFkAgK/BiT3zhv6+MN7O/5GIlYxjPtbxeRWaG+WLJbOwaEtr14jQ/qi5Mpy3f8khbd7QuU200RXEMwtJUwSi7L+FRcNcEWN68nB7D1Us+rm7TyqErWApHduDDLXSq2J0OpGa91Xe9fJNer5tUqP6l4O4pPnVYBtctpBBjHZCFqkihCXkk0y2NU4cmhwb2FmWLxEIqaxF/2WVBfJ/nyPZbnA9Ei9nGadJGbrXp9TkxFA60sB16oA07musgUzAoo4vxqLl8X8FEUtVffTh18imfQI/A4thHMpDPdXRocNmZrUmlri7uIue+JobwxznAFSIEz5djodQVcJSCHXiOW+c9/w2oBKK1FbXTQabtndRtW3GFZv9aXaV2piCukh1wqLsTMniCfK8ZH/+86Kddfng8J2KG91L8fO0u3eTAmft088+hYy2lv9fZ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(66446008)(6506007)(478600001)(4326008)(41300700001)(66556008)(5660300002)(66946007)(64756008)(76116006)(91956017)(316002)(66476007)(55236004)(71200400001)(8676002)(966005)(30864003)(6486002)(2906002)(26005)(6512007)(53546011)(2616005)(122000001)(86362001)(31696002)(186003)(8936002)(38070700005)(66899015)(31686004)(36756003)(54906003)(6916009)(83380400001)(38100700002)(21314003)(45980500001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WUY5RzdSN3ZhVk5meHFEc1d6SzVtZjFqNnNiQXJ6bzNVeUU3ZWVRY2ZHN2lP?=
 =?utf-8?B?WjV1aHE5MzAvYy9hQm0yRE0yU3JMakFXWGY3UmdPK3FleGRWRXViTEhGeEE1?=
 =?utf-8?B?OWVqTVdTclM3bHY4NVFNN1NmYWwxYmhka2NLVktMQlRjSnltYTNhVG5ZSlBE?=
 =?utf-8?B?aGdIZURrMHdyQVZKTjlMMDVFSkdxME1YeFhGcjBmd24vckVlblo5ZW1Iemg4?=
 =?utf-8?B?SnFySHlhTEt1QThOVmViU3dGai9jcVRUY1hscFpLdmhBYkJ6VVdZU2EwSkNW?=
 =?utf-8?B?aE5oOWdlY3ZCbUlSNFNEVkpyV3VtNmpvZnhHbmFMTWRLY295blpLMkZRSStu?=
 =?utf-8?B?cGdBMXhNRGp2aE9FcmNxYkdvL2NTLzJGNmdYSy9PQjdKMEExeUtJVDJYWjl0?=
 =?utf-8?B?ZS9MWmhiSHp4Q2llTlBrT0hjZ1JBVkpYRTg1K1Qrc1BmRUY2d2I0S0hseXZU?=
 =?utf-8?B?RmpqVUF3Tk1PekU0M003cnBNUUdpc2txSGhNKzh4ellFL2JBbE5meUpKSVk2?=
 =?utf-8?B?K0l0U1Vhc1hUaTc2SzQ5OEprSW8yWUZKeHphSjNBYlo3d1VPTGlpMXQvQ28y?=
 =?utf-8?B?TjJYOTRVTHhaOG9oa2xxT3NCeFM0Q2hEK0EwbHlXNWJ1bWk1OVJiK1gzQVU1?=
 =?utf-8?B?U2dPc2JxNWpyeFk3L2dyQnVLZjEwcEtHU0ZsVHloZmJJNm9CZnpJQzQybTU4?=
 =?utf-8?B?eldGYVhxMXJEMG03OFJmbXFxNXl6N0JzcE1FUzJoZ2UxOHhhTnBYZDlvTGFK?=
 =?utf-8?B?RjRiRHk2aFpkY01nazF0alBKMWlsUFZ0aTVTeFoxYzZnYml2TThuZzNUZGRp?=
 =?utf-8?B?a2VJQlkwRU02MHhMZ2dhc2tkSUltZDJDSDBBb2tDd2lNWGU3U296YlFIazhS?=
 =?utf-8?B?R25tcy9hbXI5YjV1VVpoTXpyK2RWdUJDcnNiZFZDWlNyMExvREZrbU1OZUlC?=
 =?utf-8?B?OTJ4R3BaS3RiamkxUFAxQVZQR09jMEVScDRuU3RNN0thUmNmY0NxM0FnSlVE?=
 =?utf-8?B?eVhJQXZYUTRVdnZ2VUdQYWgyQ29telpDVFJaZFFjQUpJbnNkMlJ1Qzd4eWVF?=
 =?utf-8?B?azJGZlBKUElPQVQ0SEVZNWdrSDhZR1J2VlQwNWQ5KzltTlVhdTU0dVMrUnBK?=
 =?utf-8?B?bC9TajZyVzFGZFhndWlYREhybkhRUS9NTUVQYytJMjFpS01MOFp1a2JEM3lF?=
 =?utf-8?B?SStsSzdwVStjVlhwcjE5KzhKUExWOHJ0YTlaK28zQ3EwVU92MkVKem9oc1No?=
 =?utf-8?B?V3FlY1dxM1c2dCtTZU9qUzdvRUZBWUZTTU1hWERpQlVJYWR6Zys3dXpNRDVQ?=
 =?utf-8?B?SUU2eUJEa1RucEhMVFpFOEhVZTN0NEE4a0pIUzVMelBTeFFwcUZ3TDRsREcx?=
 =?utf-8?B?ZVI3bTFHQXdaT2M3Z1BvczFnYVpPY0QveTVjeFRMWTBiOTRMU0FTcjRFc3pl?=
 =?utf-8?B?QWhsc0F6Q2h2eldxbHpMNy9vY0U4SndHanFHTmxhSjZWQkMvWUY1eU5SbUhO?=
 =?utf-8?B?aythZjRmYkJYTEdicHBNTG1DcHJ1V2kyN3g5cGJxUTFEMmIyYWZGT3Y2cSty?=
 =?utf-8?B?VkpQdDZWQk9tUVJNYlJLckZodDdPNjY5ZU0ycndsQlM4bWJWQW83djlMby9H?=
 =?utf-8?B?SXM0MkMrR2pvQ0NNamNXNytFYVU5a3NLUUxwRDU3MTlodWVlRlp6aWZBNW80?=
 =?utf-8?B?RFp2T3phQStrcktVMU10SnJBbkxqcjcxeHJVT2dGdEdFQ2hWMmhyTyt0NEcx?=
 =?utf-8?B?SVBkMkl1TXZaQTZEZWU5eXR4SlhwQkhnT24xVENxYm5IWkpRWWJ2RUtlbFZl?=
 =?utf-8?B?UkxsYjYxamcrRHRMUUlhWW1oYmpWY2FTeldCZ0hiK2kweUdFSEtna1V2TmVp?=
 =?utf-8?B?YS9BTFRPMTVOR3EzdlpSQS9yeWVrNE5od1UrZ3BHN3BPdnlSWlpaOWlCV0ZG?=
 =?utf-8?B?dnhYeVRLK0NkM09IWkE5Q3JkMEgzdmlLTm5ma0RxWi9zcUZpWlg5eDk2bjdD?=
 =?utf-8?B?OUxyZVpiK2tpcFhwOWZ0dTgwQ0RaV2VwTTJwSm9GU1FZU3RUYWx2ZGJzeU5t?=
 =?utf-8?B?bUwzeHJsVmhPNmpyMm1uWWwydjRvRVJ1dTVTdk5WWEZFbGlpMmdFVVh2Z2FV?=
 =?utf-8?B?d2UzalpFYXU3K3RMc3M2TXRPRVBKcDB5MmIwK3pUczg3VG5TdjNnejl1SDFG?=
 =?utf-8?Q?fzPp9tCLfcRO47igsxF2eoQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6A4D60A6DCA6064DB38012C278065271@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e366f34-f2bb-4d5e-0a8a-08dab32ec3b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 06:37:45.8970
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tNqc9zreA4z4TOFuB6BkzJkcYKFozzjAYesNvLS8DGAeC1MF6hqxsMuyTR3cdPCXk4EBsup8Znsgk8uXC+SBbixHoTSbtRWytFRHZP8lkxs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7322
X-Proofpoint-ORIG-GUID: VNBTNQs9HtJ2Pkw_rtuFfzpHMChiy-HJ
X-Proofpoint-GUID: VNBTNQs9HtJ2Pkw_rtuFfzpHMChiy-HJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_01,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0
 mlxscore=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210210039

DQpPbiAyMS4xMC4yMiAwOTowOCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KDQpIZWxsbyBY
ZW5pYQ0KDQo+IE9uIDEwLzIwLzIyIDIzOjA3LCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToN
Cj4gSGkgT2xla3NhbmRyDQo+Pg0KPj4gT24gMjAuMTAuMjIgMjE6MTEsIFhlbmlhIFJhZ2lhZGFr
b3Ugd3JvdGU6DQo+Pg0KPj4gSGVsbG8gWGVuaWENCj4+DQo+Pg0KPj4+IE9uIDEwLzIwLzIyIDE3
OjEyLCBPbGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+Pj4NCj4+Pj4gT24gMjAuMTAuMjIg
MTE6MjQsIFhlbmlhIFJhZ2lhZGFrb3Ugd3JvdGU6DQo+Pj4+PiBPbiAxMC8xOS8yMiAyMjo0MSwg
T2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+Pj4+Pg0KPj4+Pj4gSGkgT2xla3NhbmRyDQo+
Pj4+DQo+Pj4+DQo+Pj4+IEhlbGxvIFhlbmlhDQo+Pj4+DQo+Pj4+DQo+Pj4+Pg0KPj4+Pj4+DQo+
Pj4+Pj4gT24gMTkuMTAuMjIgMTE6NDcsIFhlbmlhIFJhZ2lhZGFrb3Ugd3JvdGU6DQo+Pj4+Pj4N
Cj4+Pj4+PiBIZWxsbyBYZW5pYQ0KPj4+Pj4+DQo+Pj4+Pj4+IE9uIDEwLzE5LzIyIDAzOjU4LCBT
dGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+Pj4+Pj4+PiBPbiBTYXQsIDE1IE9jdCAyMDIyLCBP
bGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+Pj4+Pj4+PiBGcm9tOiBPbGVrc2FuZHIgVHlz
aGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4+Pj4+Pj4NCj4+Pj4+
Pj4+PiBVc2UgdGhlIHNhbWUgInhlbi1ncmFudC1kbWEiIGRldmljZSBjb25jZXB0IGZvciB0aGUg
UENJIGRldmljZXMNCj4+Pj4+Pj4+PiBiZWhpbmQgZGV2aWNlLXRyZWUgYmFzZWQgUENJIEhvc3Qg
Y29udHJvbGxlciwgYnV0IHdpdGggb25lDQo+Pj4+Pj4+Pj4gbW9kaWZpY2F0aW9uLg0KPj4+Pj4+
Pj4+IFVubGlrZSBmb3IgcGxhdGZvcm0gZGV2aWNlcywgd2UgY2Fubm90IHVzZSBnZW5lcmljIElP
TU1VIGJpbmRpbmdzDQo+Pj4+Pj4+Pj4gKGlvbW11cyBwcm9wZXJ0eSksIGFzIHdlIG5lZWQgdG8g
c3VwcG9ydCBtb3JlIGZsZXhpYmxlDQo+Pj4+Pj4+Pj4gY29uZmlndXJhdGlvbi4NCj4+Pj4+Pj4+
PiBUaGUgcHJvYmxlbSBpcyB0aGF0IFBDSSBkZXZpY2VzIHVuZGVyIHRoZSBzaW5nbGUgUENJIEhv
c3QNCj4+Pj4+Pj4+PiBjb250cm9sbGVyDQo+Pj4+Pj4+Pj4gbWF5IGhhdmUgdGhlIGJhY2tlbmRz
IHJ1bm5pbmcgaW4gZGlmZmVyZW50IFhlbiBkb21haW5zIGFuZCB0aHVzDQo+Pj4+Pj4+Pj4gaGF2
ZQ0KPj4+Pj4+Pj4+IGRpZmZlcmVudCBlbmRwb2ludHMgSUQgKGJhY2tlbmQgZG9tYWlucyBJRCku
DQo+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+PiBTbyB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3Mg
aW5zdGVhZCANCj4+Pj4+Pj4+PiAoaW9tbXUtbWFwL2lvbW11LW1hcC1tYXNrDQo+Pj4+Pj4+Pj4g
cHJvcGVydGllcykgd2hpY2ggYWxsb3dzIHVzIHRvIGRlc2NyaWJlIHJlbGF0aW9uc2hpcCBiZXR3
ZWVuIFBDSQ0KPj4+Pj4+Pj4+IGRldmljZXMgYW5kIGJhY2tlbmQgZG9tYWlucyBJRCBwcm9wZXJs
eS4NCj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hl
bmtvIA0KPj4+Pj4+Pj4+IDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4+Pj4+
DQo+Pj4+Pj4+PiBOb3cgdGhhdCBJIHVuZGVyc3Rvb2QgdGhlIGFwcHJvYWNoIGFuZCB0aGUgcmVh
c29ucyBmb3IgaXQsIEkgY2FuDQo+Pj4+Pj4+PiByZXZpZXcNCj4+Pj4+Pj4+IHRoZSBwYXRjaCA6
LSkNCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBQbGVhc2UgYWRkIGFuIGV4YW1wbGUgb2YgdGhlIGJpbmRp
bmdzIGluIHRoZSBjb21taXQgbWVzc2FnZS4NCj4+Pj4+Pj4+DQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+
IC0tLQ0KPj4+Pj4+Pj4+IFNsaWdodGx5IFJGQy4gVGhpcyBpcyBuZWVkZWQgdG8gc3VwcG9ydCBY
ZW4gZ3JhbnQgbWFwcGluZ3MgZm9yDQo+Pj4+Pj4+Pj4gdmlydGlvLXBjaSBkZXZpY2VzDQo+Pj4+
Pj4+Pj4gb24gQXJtIGF0IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZS4gVGhlIFhlbiB0b29sc3Rh
Y2sgc2lkZSBpcyBub3QNCj4+Pj4+Pj4+PiBjb21wbGV0ZWx5IHJlYWR5IHlldC4NCj4+Pj4+Pj4+
PiBIZXJlLCBmb3IgUENJIGRldmljZXMgd2UgdXNlIG1vcmUgZmxleGlibGUgd2F5IHRvIHBhc3Mg
YmFja2VuZA0KPj4+Pj4+Pj4+IGRvbWlkDQo+Pj4+Pj4+Pj4gdG8gdGhlIGd1ZXN0DQo+Pj4+Pj4+
Pj4gdGhhbiBmb3IgcGxhdGZvcm0gZGV2aWNlcy4NCj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+IENoYW5n
ZXMgVjEgLT4gVjI6DQo+Pj4+Pj4+Pj4gwqDCoMKgwqDCoMKgIC0gdXBkYXRlIGNvbW1pdCBkZXNj
cmlwdGlvbg0KPj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoCAtIHJlYmFzZQ0KPj4+Pj4+Pj4+IMKgwqDC
oMKgwqDCoCAtIHJld29yayB0byB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5zdGVh
ZCBvZiANCj4+Pj4+Pj4+PiBnZW5lcmljDQo+Pj4+Pj4+Pj4gSU9NTVUgYmluZGluZ3MNCj4+Pj4+
Pj4+Pg0KPj4+Pj4+Pj4+IFByZXZpb3VzIGRpc2N1c3Npb24gaXMgYXQ6DQo+Pj4+Pj4+Pj4gaHR0
cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZl
bC8yMDIyMTAwNjE3NDgwNC4yMDAzMDI5LTEtb2xla3N0eXNoQGdtYWlsLmNvbS9fXzshIUdGXzI5
ZGJjUUlVQlBBITMtdnE3RWRtM1hmS3RENWNuTmpuT3pEUXZ1b19YcmhKNzN5SC1uUGZxT2tHR1Uw
SWpMRzdSN01SX25BSkNBUGVPdXRIUkxUNDR3S1l3UXd6M1NhdUFDaWVfWkF5JCANCj4+Pj4+Pj4+
Pg0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4NCj4+Pj4+Pj4+PiBbbG9yZVsuXWtlcm5lbFsuXW9yZ10N
Cj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+IEJhc2VkIG9uOg0KPj4+Pj4+Pj4+IGh0dHBzOi8vdXJsZGVm
ZW5zZS5jb20vdjMvX19odHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVs
L2dpdC94ZW4vdGlwLmdpdC9sb2cvP2g9Zm9yLWxpbnVzLTYuMV9fOyEhR0ZfMjlkYmNRSVVCUEEh
My12cTdFZG0zWGZLdEQ1Y25Oam5PekRRdnVvX1hyaEo3M3lILW5QZnFPa0dHVTBJakxHN1I3TVJf
bkFKQ0FQZU91dEhSTFQ0NHdLWXdRd3ozU2F1QUVuTURIQXEkIA0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+
Pj4NCj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4+IFtnaXRbLl1rZXJuZWxbLl1vcmddDQo+Pj4+Pj4+Pj4g
LS0tDQo+Pj4+Pj4+Pj4gwqDCoMKgwqAgZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgODcN
Cj4+Pj4+Pj4+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tDQo+Pj4+Pj4+
Pj4gwqDCoMKgwqAgMSBmaWxlIGNoYW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9u
cygtKQ0KPj4+Pj4+Pj4+DQo+Pj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50
LWRtYS1vcHMuYw0KPj4+Pj4+Pj4+IGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+
Pj4+Pj4gaW5kZXggZGFhNTI1ZGY3YmRjLi5iNzlkOWQ2Y2UxNTQgMTAwNjQ0DQo+Pj4+Pj4+Pj4g
LS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+Pj4+Pj4gKysrIGIvZHJpdmVy
cy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+Pj4+Pj4+Pj4gQEAgLTEwLDYgKzEwLDcgQEANCj4+Pj4+
Pj4+PiDCoMKgwqDCoCAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+DQo+Pj4+Pj4+Pj4gwqDCoMKg
wqAgI2luY2x1ZGUgPGxpbnV4L2RtYS1tYXAtb3BzLmg+DQo+Pj4+Pj4+Pj4gwqDCoMKgwqAgI2lu
Y2x1ZGUgPGxpbnV4L29mLmg+DQo+Pj4+Pj4+Pj4gKyNpbmNsdWRlIDxsaW51eC9wY2kuaD4NCj4+
Pj4+Pj4+PiDCoMKgwqDCoCAjaW5jbHVkZSA8bGludXgvcGZuLmg+DQo+Pj4+Pj4+Pj4gwqDCoMKg
wqAgI2luY2x1ZGUgPGxpbnV4L3hhcnJheS5oPg0KPj4+Pj4+Pj4+IMKgwqDCoMKgICNpbmNsdWRl
IDxsaW51eC92aXJ0aW9fYW5jaG9yLmg+DQo+Pj4+Pj4+Pj4gQEAgLTI5MiwxMiArMjkzLDU1IEBA
IHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX21hcF9vcHMNCj4+Pj4+Pj4+PiB4ZW5fZ3JhbnRfZG1h
X29wcyA9IHsNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIC5kbWFfc3VwcG9ydGVkID0geGVu
X2dyYW50X2RtYV9zdXBwb3J0ZWQsDQo+Pj4+Pj4+Pj4gwqDCoMKgwqAgfTsNCj4+Pj4+Pj4+PiDC
oMKgwqDCoCArc3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9wY2lfaG9zdF9u
b2RlKHN0cnVjdA0KPj4+Pj4+Pj4+IGRldmljZQ0KPj4+Pj4+Pj4+ICpkZXYpDQo+Pj4+Pj4+Pj4g
K3sNCj4+Pj4+Pj4+PiArwqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2Rldihk
ZXYpOw0KPj4+Pj4+Pj4+ICvCoMKgwqAgc3RydWN0IHBjaV9idXMgKmJ1cyA9IHBkZXYtPmJ1czsN
Cj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4gK8KgwqDCoCAvKiBXYWxrIHVwIHRvIHRoZSByb290IGJ1
cyB0byBsb29rIGZvciBQQ0kgSG9zdCANCj4+Pj4+Pj4+PiBjb250cm9sbGVyICovDQo+Pj4+Pj4+
Pj4gK8KgwqDCoCB3aGlsZSAoIXBjaV9pc19yb290X2J1cyhidXMpKQ0KPj4+Pj4+Pj4+ICvCoMKg
wqDCoMKgwqDCoCBidXMgPSBidXMtPnBhcmVudDsNCj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4gK8Kg
wqDCoCByZXR1cm4gb2Zfbm9kZV9nZXQoYnVzLT5icmlkZ2UtPnBhcmVudC0+b2Zfbm9kZSk7DQo+
Pj4+Pj4+Pj4gK30NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBJdCBzZWVtcyBzaWxseSB0aGF0IHdlIG5l
ZWQgdG8gd2FsayB0aGUgaGllcmFjaHkgdGhhdCB3YXksIGJ1dCBJDQo+Pj4+Pj4+PiBjb3VsZG4n
dCBmaW5kIGFub3RoZXIgd2F5IHRvIGRvIGl0DQo+Pj4+Pj4+Pg0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+
PiArc3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZp
Y2UgKmRldikNCj4+Pj4+Pj4+PiArew0KPj4+Pj4+Pj4+ICvCoMKgwqAgaWYgKGRldl9pc19wY2ko
ZGV2KSkNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHhlbl9kdF9nZXRfcGNpX2hv
c3Rfbm9kZShkZXYpOw0KPj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+PiArwqDCoMKgIHJldHVybiBvZl9u
b2RlX2dldChkZXYtPm9mX25vZGUpOw0KPj4+Pj4+Pj4+ICt9DQo+Pj4+Pj4+Pj4gKw0KPj4+Pj4+
Pj4+ICtzdGF0aWMgaW50IHhlbl9kdF9tYXBfaWQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3Qg
ZGV2aWNlX25vZGUNCj4+Pj4+Pj4+PiAqKmlvbW11X25wLA0KPj4+Pj4+Pj4+ICvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgdTMyICpzaWQpDQo+Pj4+Pj4+Pj4gK3sNCj4+Pj4+Pj4+PiArwqDCoMKg
IHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPj4+Pj4+Pj4+ICvCoMKg
wqAgdTMyIHJpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51bWJlciwgcGRldi0+ZGV2Zm4pOw0K
Pj4+Pj4+Pj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICpob3N0X25wOw0KPj4+Pj4+Pj4+
ICvCoMKgwqAgaW50IHJldDsNCj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4gK8KgwqDCoCBob3N0X25w
ID0geGVuX2R0X2dldF9wY2lfaG9zdF9ub2RlKGRldik7DQo+Pj4+Pj4+Pj4gK8KgwqDCoCBpZiAo
IWhvc3RfbnApDQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRU5PREVWOw0KPj4+
Pj4+Pj4+ICsNCj4+Pj4+Pj4+PiArwqDCoMKgIHJldCA9IG9mX21hcF9pZChob3N0X25wLCByaWQs
ICJpb21tdS1tYXAiLCAiaW9tbXUtbWFwLW1hc2siLA0KPj4+Pj4+Pj4+IGlvbW11X25wLCBzaWQp
Ow0KPj4+Pj4+Pj4+ICvCoMKgwqAgb2Zfbm9kZV9wdXQoaG9zdF9ucCk7DQo+Pj4+Pj4+Pj4gK8Kg
wqDCoCByZXR1cm4gcmV0Ow0KPj4+Pj4+Pj4+ICt9DQo+Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+IMKg
wqDCoMKgIHN0YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZp
Y2UgKmRldikNCj4+Pj4+Pj4+PiDCoMKgwqDCoCB7DQo+Pj4+Pj4+Pj4gLcKgwqDCoCBzdHJ1Y3Qg
ZGV2aWNlX25vZGUgKmlvbW11X25wOw0KPj4+Pj4+Pj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9u
b2RlICppb21tdV9ucCA9IE5VTEw7DQo+Pj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCBib29sIGhh
c19pb21tdTsNCj4+Pj4+Pj4+PiDCoMKgwqDCoCAtwqDCoMKgIGlvbW11X25wID0gb2ZfcGFyc2Vf
cGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21tdXMiLCAwKTsNCj4+Pj4+Pj4+PiArwqDCoMKgIGlm
IChkZXZfaXNfcGNpKGRldikpIHsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9k
dF9tYXBfaWQoZGV2LCAmaW9tbXVfbnAsIE5VTEwpKQ0KPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIHJldHVybiBmYWxzZTsNCj4+Pj4+Pj4+PiArwqDCoMKgIH0gZWxzZQ0KPj4+Pj4+
Pj4+ICvCoMKgwqDCoMKgwqDCoCBpb21tdV9ucCA9IG9mX3BhcnNlX3BoYW5kbGUoZGV2LT5vZl9u
b2RlLCAiaW9tbXVzIiwgMCk7DQo+Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKg
wqAgaGFzX2lvbW11ID0gaW9tbXVfbnAgJiYNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShpb21tdV9ucCwgDQo+Pj4+Pj4+
Pj4gInhlbixncmFudC1kbWEiKTsNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIG9mX25vZGVf
cHV0KGlvbW11X25wKTsNCj4+Pj4+Pj4+PiBAQCAtMzA3LDkgKzM1MSwxNyBAQCBzdGF0aWMgYm9v
bCANCj4+Pj4+Pj4+PiB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QNCj4+Pj4+Pj4+
PiBkZXZpY2UgKmRldikNCj4+Pj4+Pj4+PiDCoMKgwqDCoCDCoCBib29sIHhlbl9pc19ncmFudF9k
bWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4+Pj4+PiDCoMKgwqDCoCB7DQo+Pj4+
Pj4+Pj4gK8KgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4+Pj4+Pj4+ICsNCj4+Pj4+
Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIC8qIFhYWCBIYW5kbGUgb25seSBEVCBkZXZpY2VzIGZvciBu
b3cgKi8NCj4+Pj4+Pj4+PiAtwqDCoMKgIGlmIChkZXYtPm9mX25vZGUpDQo+Pj4+Pj4+Pj4gLcKg
wqDCoMKgwqDCoMKgIHJldHVybiB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShkZXYpOw0KPj4+
Pj4+Pj4+ICvCoMKgwqAgbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsNCj4+Pj4+Pj4+PiArwqDC
oMKgIGlmIChucCkgew0KPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBib29sIHJldDsNCj4+Pj4+
Pj4+PiArDQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldCA9IHhlbl9pc19kdF9ncmFudF9k
bWFfZGV2aWNlKGRldik7DQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIG9mX25vZGVfcHV0KG5w
KTsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsNCj4+Pj4+Pj4+PiArwqDC
oMKgIH0NCj4+Pj4+Pj4+DQo+Pj4+Pj4+PiBXZSBkb24ndCBuZWVkIHRvIHdhbGsgdGhlIFBDSSBo
aWVyYWNoeSB0d2ljZS4gTWF5YmUgd2UgY2FuIGFkZCB0aGUNCj4+Pj4+Pj4+IG9mX25vZGUgY2hl
Y2sgZGlyZWN0bHkgdG8geGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2U/DQo+Pj4+Pj4+Pg0KPj4+
Pj4+Pg0KPj4+Pj4+PiBJIHRoaW5rIGluIGdlbmVyYWwgd2UgY291bGQgcGFzcyBkaXJlY3RseSB0
aGUgaG9zdCBicmlkZ2UgZGV2aWNlIGlmDQo+Pj4+Pj4+IGRldl9pc19wY2koZGV2KSAod2hpY2gg
Y2FuIGJlIHJldHJpZXZlZCB3aXRoDQo+Pj4+Pj4+IHBjaV9nZXRfaG9zdF9icmlkZ2VfZGV2aWNl
KHRvX3BjaV9kZXYoZGV2KSwgYW5kIGFmdGVyIGRvbmUgd2l0aCBpdA0KPj4+Pj4+PiBwY2lfcHV0
X2hvc3RfYnJpZGdlX2RldmljZShwaGIpKS4NCj4+Pj4+Pj4gU28gdGhhdCwgeGVuX2lzX2R0X2dy
YW50X2RtYV9kZXZpY2UoKSBhbmQNCj4+Pj4+Pj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9k
b21pZCgpIHdvbid0IG5lZWQgdG8gZGlzY292ZXIgaXQNCj4+Pj4+Pj4gdGhlbXNlbHZlcy4NCj4+
Pj4+Pj4gVGhpcyB3aWxsIHNpbXBsaWZ5IHRoZSBjb2RlLg0KPj4+Pj4+DQo+Pj4+Pj4NCj4+Pj4+
PiBHb29kIHBvaW50LiBJIGhhdmUgc29tZSByZW1hcmsuIENhbiB3ZSB1c2UgcGNpX2ZpbmRfaG9z
dF9icmlkZ2UoKQ0KPj4+Pj4+IGluc3RlYWQ/IFRoaXMgd2F5IHdlIGRvbid0IGhhdmUgdG8gYWRk
ICNpbmNsdWRlICIuLi9wY2kvcGNpLmgiLCBhbmQNCj4+Pj4+PiBoYXZlDQo+Pj4+Pj4gdG8gZHJv
cCByZWZlcmVuY2UgYWZ0ZXJ3YXJkcy4NCj4+Pj4+Pg0KPj4+Pj4+IFdpdGggdGhhdCB4ZW5fZHRf
Z2V0X3BjaV9ob3N0X25vZGUoKSB3aWxsIGJlY2FtZSB0aGUgZm9sbG93aW5nOg0KPj4+Pj4+DQo+
Pj4+Pj4NCj4+Pj4+PiBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlICp4ZW5fZHRfZ2V0X3BjaV9o
b3N0X25vZGUoc3RydWN0IGRldmljZQ0KPj4+Pj4+ICpkZXYpDQo+Pj4+Pj4gew0KPj4+Pj4+IMKg
wqDCoCDCoMKgIMKgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlID0NCj4+Pj4+PiBwY2lf
ZmluZF9ob3N0X2JyaWRnZSh0b19wY2lfZGV2KGRldiktPmJ1cyk7DQo+Pj4+Pj4NCj4+Pj4+PiDC
oMKgwqAgwqDCoCDCoHJldHVybiBvZl9ub2RlX2dldChicmlkZ2UtPmRldi5wYXJlbnQtPm9mX25v
ZGUpOw0KPj4+Pj4+IH0NCj4+Pj4+Pg0KPj4+Pj4NCj4+Pj4+IFlvdSBhcmUgcmlnaHQuIEkgcHJl
ZmVyIHlvdXIgdmVyc2lvbiBpbnN0ZWFkIG9mIHRoZSBhYm92ZS4NCj4+Pj4NCj4+Pj4NCj4+Pj4g
b2ssIHRoYW5rcw0KPj4+Pg0KPj4+Pg0KPj4+Pj4NCj4+Pj4+DQo+Pj4+Pj4NCj4+Pj4+PiBXaXRo
IFN0ZWZhbm8ncyBzdWdnZXN0aW9uLCB3ZSB3b24ndCB3YWxrIHRoZSBQQ0kgaGllcmFyY2h5IHR3
aWNlIA0KPj4+Pj4+IHdoZW4NCj4+Pj4+PiBleGVjdXRpbmcgeGVuX2lzX2dyYW50X2RtYV9kZXZp
Y2UoKSBmb3IgUENJIGRldmljZToNCj4+Pj4+Pg0KPj4+Pj4+IHhlbl9pc19ncmFudF9kbWFfZGV2
aWNlKCkgLT4geGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2UoKSAtPg0KPj4+Pj4+IHhlbl9kdF9t
YXBfaWQoKSAtPiB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoKQ0KPj4+Pj4+DQo+Pj4+Pj4NCj4+
Pj4+PiBXaGF0IGRvIHlvdSB0aGluaz8NCj4+Pj4+Pg0KPj4+Pj4NCj4+Pj4+IEkgd2FzIHRoaW5r
aW5nIHBhc3NpbmcgdGhlIGRldmljZV9ub2RlIGFsb25nIHdpdGggdGhlIGRldmljZSBpbiB0aGUN
Cj4+Pj4+IGZ1bmN0aW9uIGFyZ3VtZW50cy4gTW9yZSBzcGVjaWZpY2FsbHksIG9mIGRvaW5nIHRo
aXMgKG5vdCB0ZXN0ZWQsIA0KPj4+Pj4ganVzdA0KPj4+Pj4gYW4gaWRlYSk6DQo+Pj4+Pg0KPj4+
Pj4gYm9vbCB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+
PiB7DQo+Pj4+PiDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnA7DQo+Pj4+PiDCoMKg
wqDCoMKgIGJvb2wgaGFzX2lvbW11ID0gZmFsc2U7DQo+Pj4+Pg0KPj4+Pj4gwqDCoMKgwqDCoCAv
KiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNlcyBmb3Igbm93ICovDQo+Pj4+PiDCoMKgwqDCoMKg
IG5wID0geGVuX2R0X2dldF9ub2RlKGRldik7DQo+Pj4+PiDCoMKgwqDCoMKgIGlmIChucCkNCj4+
Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBoYXNfaW9tbXUgPSB4ZW5faXNfZHRfZ3JhbnRfZG1hX2Rl
dmljZShkZXYsIG5wKTsNCj4+Pj4+IMKgwqDCoMKgwqAgb2Zfbm9kZV9wdXQobnApOw0KPj4+Pj4g
wqDCoMKgwqDCoCByZXR1cm4gaGFzX2lvbW11Ow0KPj4+Pj4gfQ0KPj4+Pj4NCj4+Pj4+IHN0YXRp
YyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldiwNCj4+
Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApDQo+Pj4+
PiB7DQo+Pj4+PiDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqaW9tbXVfbnAgPSBOVUxM
Ow0KPj4+Pj4gwqDCoMKgwqDCoCBib29sIGhhc19pb21tdTsNCj4+Pj4+DQo+Pj4+PiDCoMKgwqDC
oMKgIGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1
Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2KTsNCj4+Pj4+IMKgwqDCoMKgwqDCoHUz
MiBpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51bWJlciwgcGRldi0+ZGV2Zm4pOw0KPj4+Pj4g
wqDCoMKgwqDCoMKgwqDCoMKgIG9mX21hcF9pZChucCwgaWQsICJpb21tdS1tYXAiLCAiaW9tbXUt
bWFwLW1hc2siLCAmaW9tbXVfbnAsDQo+Pj4+PiBOVUxMKTsNCj4+Pj4+IMKgwqDCoMKgwqAgfSBl
bHNlIHsNCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBpb21tdV9ucCA9IG9mX3BhcnNlX3BoYW5k
bGUobnAsICJpb21tdXMiLCAwKTsNCj4+Pj4+IMKgwqDCoMKgwqAgfQ0KPj4+Pj4NCj4+Pj4+IMKg
wqDCoMKgwqAgaGFzX2lvbW11ID0gaW9tbXVfbnAgJiYgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUo
aW9tbXVfbnAsDQo+Pj4+PiAieGVuLGdyYW50LWRtYSIpOw0KPj4+Pj4gwqDCoMKgwqDCoCBvZl9u
b2RlX3B1dChpb21tdV9ucCk7DQo+Pj4+Pg0KPj4+Pj4gwqDCoMKgwqDCoCByZXR1cm4gaGFzX2lv
bW11Ow0KPj4+Pj4gfQ0KPj4+Pg0KPj4+Pg0KPj4+PiBJIGdvdCBpdC4NCj4+Pj4NCj4+Pj4geGVu
X2lzX2dyYW50X2RtYV9kZXZpY2UoKSBmb3IgVjMgd29uJ3QgY2FsbCB4ZW5fZHRfZ2V0X25vZGUo
KSwgYnV0IA0KPj4+PiBjYWxsDQo+Pj4+IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKCkgZGly
ZWN0bHkuDQo+Pj4+DQo+Pj4+IHN0YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNl
KHN0cnVjdCBkZXZpY2UgKmRldikNCj4+Pj4gew0KPj4+PiDCoMKgIMKgwqAgwqBzdHJ1Y3QgZGV2
aWNlX25vZGUgKmlvbW11X25wID0gTlVMTDsNCj4+Pj4gwqDCoCDCoMKgIMKgYm9vbCBoYXNfaW9t
bXU7DQo+Pj4+DQo+Pj4+IMKgwqAgwqDCoCDCoGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+Pj4g
wqDCoCDCoMKgIMKgwqDCoMKgIGlmICh4ZW5fZHRfbWFwX2lkKGRldiwgJmlvbW11X25wLCBOVUxM
KSkNCj4+Pj4gwqDCoCDCoMKgIMKgwqDCoMKgIMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+Pj4+IMKg
wqAgwqDCoCDCoH0gZWxzZSBpZiAoZGV2LT5vZl9ub2RlKQ0KPj4+PiDCoMKgIMKgwqAgwqDCoMKg
wqAgaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDAp
Ow0KPj4+PiDCoMKgIMKgwqAgwqBlbHNlDQo+Pj4+IMKgwqAgwqDCoCDCoMKgwqDCoCByZXR1cm4g
ZmFsc2U7DQo+Pj4+DQo+Pj4+IMKgwqAgwqDCoCDCoGhhc19pb21tdSA9IGlvbW11X25wICYmDQo+
Pj4+IMKgwqAgwqDCoCDCoMKgwqDCoCDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9t
bXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQo+Pj4+IMKgwqAgwqDCoCDCoG9mX25vZGVfcHV0KGlv
bW11X25wKTsNCj4+Pj4NCj4+Pj4gwqDCoCDCoMKgIMKgcmV0dXJuIGhhc19pb21tdTsNCj4+Pj4g
fQ0KPj4+Pg0KPj4+PiBib29sIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2Ug
KmRldikNCj4+Pj4gew0KPj4+PiDCoMKgIMKgwqAgwqAvKiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2
aWNlcyBmb3Igbm93ICovDQo+Pj4+IMKgwqAgwqDCoCDCoHJldHVybiB4ZW5faXNfZHRfZ3JhbnRf
ZG1hX2RldmljZShkZXYpOw0KPj4+PiB9DQo+Pj4+DQo+Pj4+DQo+Pj4NCj4+PiBPay4gT25lIGRp
ZmZlcmVuY2UsIHRoYXQgSSBzZWUgZnJvbSB0aGUgcHJldmlvdXMsIGlzIHRoYXQgaGVyZSB5b3UN
Cj4+PiBkb24ndCB1c2UgdGhlIGR5bmFtaWMgaW50ZXJmYWNlIHdoZW4geW91IGFjY2VzcyB0aGUg
ZGV2LT5vZl9ub2RlDQo+Pj4gKG9mX25vZGVfZ2V0L29mX25vZGVfcHV0KS4gQmVmb3JlLCB0aGlz
IHdhcyBndWFyZGVkIHRocm91Z2ggdGhlDQo+Pj4gZXh0ZXJuYWwgeGVuX2R0X2dldF9ub2RlKCku
DQo+Pj4NCj4+PiBJIHN1c3BlY3QgdGhhdCB0aGUgc2FtZSBuZWVkcyB0byBiZSBkb25lIGZvciB0
aGUgZnVuY3Rpb24NCj4+PiB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcygpLiBUaGVyZSwgYWxzbywg
dGhlIGNvZGUgd2Fsa3MgdXAgdG8gdGhlIHJvb3QNCj4+PiBidXMgdHdpY2UuDQo+Pg0KPj4NCj4+
IEhtbSwgeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCgpIHNob3VsZCBvbmx5IGJlIGNh
bGxlZCBpZiB3ZSBkZWFsDQo+PiB3aXRoIGRldmljZS10cmVlIGJhc2VkIGRldmljZS4NCj4+DQo+
PiBJIHRoaW5rIHlvdSBhcmUgY29tcGxldGVseSByaWdodCwgdGhhbmtzIQ0KPj4NCj4+IEluIG9y
ZGVyIHRvIGFkZHJlc3MgYm90aCB5b3VyIGNvbW1lbnRzLCBJIHRoaW5rIEkgbmVlZCB0byByZXdv
cmsgdGhlDQo+PiBjb2RlICh0YWtpbmcgaW50byB0aGUgYWNjb3VudCB5b3VyIGV4YW1wbGUgd2l0
aCANCj4+IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKCkNCj4+DQo+PiBwcm92aWRlZCBhIGZl
dyBsZXR0ZXJzIGFnbyBhbmQgZXh0cmFwb2xhdGUgdGhpcyBleGFtcGxlIHRvDQo+PiB4ZW5fZHRf
Z3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKCkpLiBCZWxvdyB0aGUgcGF0Y2ggKG5vdCB0ZXN0ZWQp
IHdoaWNoDQo+PiBzZWVtcyB0byBhZGRyZXNzIGJvdGggeW91ciBjb21tZW50cyAoYWxzbyBJIGRy
b3BwZWQNCj4+DQo+PiB4ZW5fZHRfbWFwX2lkKCkgYW5kIHNxdWFzaGVkIHhlbl9kdF9nZXRfcGNp
X2hvc3Rfbm9kZSgpIHdpdGgNCj4+IHhlbl9kdF9nZXRfbm9kZSgpKS4NCj4+DQo+Pg0KPj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBiL2RyaXZlcnMveGVuL2dyYW50
LWRtYS1vcHMuYw0KPj4gaW5kZXggZGFhNTI1ZGY3YmRjLi5kYWUyNGRiZDJlZjcgMTAwNjQ0DQo+
PiAtLS0gYS9kcml2ZXJzL3hlbi9ncmFudC1kbWEtb3BzLmMNCj4+ICsrKyBiL2RyaXZlcnMveGVu
L2dyYW50LWRtYS1vcHMuYw0KPj4gQEAgLTEwLDYgKzEwLDcgQEANCj4+IMKgIMKgI2luY2x1ZGUg
PGxpbnV4L21vZHVsZS5oPg0KPj4gwqAgwqAjaW5jbHVkZSA8bGludXgvZG1hLW1hcC1vcHMuaD4N
Cj4+IMKgIMKgI2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+PiArI2luY2x1ZGUgPGxpbnV4L3BjaS5o
Pg0KPj4gwqAgwqAjaW5jbHVkZSA8bGludXgvcGZuLmg+DQo+PiDCoCDCoCNpbmNsdWRlIDxsaW51
eC94YXJyYXkuaD4NCj4+IMKgIMKgI2luY2x1ZGUgPGxpbnV4L3ZpcnRpb19hbmNob3IuaD4NCj4+
IEBAIC0yOTIsMTIgKzI5MywzMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRtYV9tYXBfb3BzIA0K
Pj4geGVuX2dyYW50X2RtYV9vcHMgPSB7DQo+PiDCoCDCoMKgwqDCoMKgwqDCoCAuZG1hX3N1cHBv
cnRlZCA9IHhlbl9ncmFudF9kbWFfc3VwcG9ydGVkLA0KPj4gwqAgwqB9Ow0KPj4NCj4+IC1zdGF0
aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+
PiArc3RhdGljIHN0cnVjdCBkZXZpY2Vfbm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZp
Y2UgKmRldikNCj4+IMKgIMKgew0KPj4gLcKgwqDCoMKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUg
KmlvbW11X25wOw0KPj4gK8KgwqDCoMKgwqDCoCBpZiAoZGV2X2lzX3BjaShkZXYpKSB7DQo+PiAr
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3Bj
aV9kZXYoZGV2KTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBwY2lf
aG9zdF9icmlkZ2UgKmJyaWRnZSA9DQo+PiBwY2lfZmluZF9ob3N0X2JyaWRnZShwZGV2LT5idXMp
Ow0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIG9mX25vZGVf
Z2V0KGJyaWRnZS0+ZGV2LnBhcmVudC0+b2Zfbm9kZSk7DQo+PiArwqDCoMKgwqDCoMKgIH0NCj4+
ICsNCj4+ICvCoMKgwqDCoMKgwqAgcmV0dXJuIG9mX25vZGVfZ2V0KGRldi0+b2Zfbm9kZSk7DQo+
PiArfQ0KPj4gKw0KPg0KPiBJdCBkb2VzIG5vdCBzZWVtIHJpZ2h0IHRvIG1lIHRvIGV4cG9zZSB0
aGUgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSANCj4gKHdoaWNoIHdlIHdvdWxkIG5lZWQgdG8gY2hl
Y2sgaWYgaXQgaXMgbnVsbCBieSB0aGUgd2F5KS4gSSB3b3VsZCANCj4gcHJlZmVyIHlvdXIgdmVy
c2lvbiBmb3IgdGhlIGFib3ZlIGkuZQ0KPiBzdGF0aWMgc3RydWN0IGRldmljZV9ub2RlICp4ZW5f
ZHRfZ2V0X25vZGUoc3RydWN0IGRldmljZSAqZGV2KQ0KPiB7DQo+IMKgwqDCoMKgaWYgKGRldl9p
c19wY2koZGV2KSkgew0KPiDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGNpX2J1cyAqYnVzID0gdG9f
cGNpX2RldihkZXYpLT5idXM7DQo+DQo+IMKgwqDCoMKgwqDCoMKgIC8qIFdhbGsgdXAgdG8gdGhl
IHJvb3QgYnVzIHRvIGxvb2sgZm9yIFBDSSBIb3N0IGNvbnRyb2xsZXIgKi8NCj4gwqDCoMKgwqDC
oMKgwqAgd2hpbGUgKCFwY2lfaXNfcm9vdF9idXMoYnVzKSkNCj4gwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCBidXMgPSBidXMtPnBhcmVudDsNCj4gwqDCoMKgwqDCoMKgwqAgcmV0dXJuIG9mX25vZGVf
Z2V0KGJ1cy0+YnJpZGdlLT5wYXJlbnQtPm9mX25vZGUpOw0KPiDCoMKgwqDCoH0NCj4NCj4gwqDC
oMKgwqByZXR1cm4gb2Zfbm9kZV9nZXQoZGV2LT5vZl9ub2RlKTsNCj4gfQ0KDQoNCm9rLCB3aWxs
IHJldHVybiBpdCBiYWNrDQoNCg0KPg0KPj4gK3N0YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9k
bWFfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldiwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0
cnVjdCBkZXZpY2Vfbm9kZSAqbnApDQo+PiArew0KPj4gK8KgwqDCoMKgwqDCoCBzdHJ1Y3QgZGV2
aWNlX25vZGUgKmlvbW11X25wID0gTlVMTDsNCj4+IMKgIMKgwqDCoMKgwqDCoMKgIGJvb2wgaGFz
X2lvbW11Ow0KPj4NCj4+IC3CoMKgwqDCoMKgwqAgaW9tbXVfbnAgPSBvZl9wYXJzZV9waGFuZGxl
KGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPj4gK8KgwqDCoMKgwqDCoCBpZiAoZGV2X2lz
X3BjaShkZXYpKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGNp
X2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2KTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIHUzMiByaWQgPSBQQ0lfREVWSUQocGRldi0+YnVzLT5udW1iZXIsIHBkZXYtPmRldmZu
KTsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChvZl9tYXBfaWQo
bnAsIHJpZCwgImlvbW11LW1hcCIsICJpb21tdS1tYXAtbWFzayIsDQo+PiAmaW9tbXVfbnAsIE5V
TEwpKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJl
dHVybiBmYWxzZTsNCj4+ICvCoMKgwqDCoMKgwqAgfSBlbHNlDQo+PiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBpb21tdV9ucCA9IG9mX3BhcnNlX3BoYW5kbGUobnAsICJpb21tdXMiLCAw
KTsNCj4+ICsNCj4+IMKgIMKgwqDCoMKgwqDCoMKgIGhhc19pb21tdSA9IGlvbW11X25wICYmDQo+
PiDCoCDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvZl9kZXZpY2VfaXNf
Y29tcGF0aWJsZShpb21tdV9ucCwgDQo+PiAieGVuLGdyYW50LWRtYSIpOw0KPj4gwqAgwqDCoMKg
wqDCoMKgwqAgb2Zfbm9kZV9wdXQoaW9tbXVfbnApOw0KPj4gQEAgLTMwNyw5ICszMjksMTcgQEAg
c3RhdGljIGJvb2wgeGVuX2lzX2R0X2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0DQo+PiBkZXZpY2Ug
KmRldikNCj4+DQo+PiDCoCDCoGJvb2wgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRl
dmljZSAqZGV2KQ0KPj4gwqAgwqB7DQo+PiArwqDCoMKgwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9k
ZSAqbnA7DQo+PiArDQo+PiDCoCDCoMKgwqDCoMKgwqDCoCAvKiBYWFggSGFuZGxlIG9ubHkgRFQg
ZGV2aWNlcyBmb3Igbm93ICovDQo+PiAtwqDCoMKgwqDCoMKgIGlmIChkZXYtPm9mX25vZGUpDQo+
PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4geGVuX2lzX2R0X2dyYW50X2Rt
YV9kZXZpY2UoZGV2KTsNCj4+ICvCoMKgwqDCoMKgwqAgbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2
KTsNCj4+ICvCoMKgwqDCoMKgwqAgaWYgKG5wKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCBib29sIHJldDsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHJldCA9IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldiwgbnApOw0KPj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgb2Zfbm9kZV9wdXQobnApOw0KPj4gK8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsNCj4+ICvCoMKgwqDCoMKgwqAgfQ0KPj4NCj4+IMKg
IMKgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsNCj4+IMKgIMKgfQ0KPg0KPj4gQEAgLTMyMywx
NCArMzUzLDI2IEBAIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0cnVjdCB2aXJ0aW9fZGV2aWNl
ICpkZXYpDQo+PiDCoCDCoH0NCj4+DQo+PiDCoCDCoHN0YXRpYyBpbnQgeGVuX2R0X2dyYW50X2lu
aXRfYmFja2VuZF9kb21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLA0KPj4gwqAgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHN0cnVjdCANCj4+IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YSkNCj4+IMKg
IMKgew0KPj4gLcKgwqDCoMKgwqDCoCBzdHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzIGlvbW11X3NwZWM7
DQo+PiArwqDCoMKgwqDCoMKgIHN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYyA9IHsg
LmFyZ3NfY291bnQgPSAxIH07DQo+Pg0KPj4gLcKgwqDCoMKgwqDCoCBpZiAob2ZfcGFyc2VfcGhh
bmRsZV93aXRoX2FyZ3MoZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwNCj4+ICIjaW9tbXUtY2VsbHMi
LA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDAsICZp
b21tdV9zcGVjKSkgew0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2X2Vycihk
ZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+IC3CoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVNSQ0g7DQo+PiArwqDCoMKgwqDCoMKgIGlmIChkZXZf
aXNfcGNpKGRldikpIHsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBw
Y2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgdTMyIHJpZCA9IFBDSV9ERVZJRChwZGV2LT5idXMtPm51bWJlciwgcGRldi0+ZGV2
Zm4pOw0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKG9mX21hcF9p
ZChucCwgcmlkLCAiaW9tbXUtbWFwIiwgImlvbW11LW1hcC1tYXNrIiwNCj4+ICZpb21tdV9zcGVj
Lm5wLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBpb21tdV9zcGVjLmFyZ3MpKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3QgdHJhbnNsYXRl
IElEXG4iKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCByZXR1cm4gLUVTUkNIOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfQ0KPj4g
K8KgwqDCoMKgwqDCoCB9IGVsc2Ugew0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
aWYgKG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKG5wLCAiaW9tbXVzIiwgDQo+PiAiI2lvbW11
LWNlbGxzIiwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+PiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2Ug
aW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCByZXR1cm4gLUVTUkNIOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgfQ0KPj4gwqAgwqDCoMKgwqDCoMKgwqAgfQ0KPj4NCj4NCj4gSU1PLCBpbnN0ZWFkIG9m
IHBhc3Npbmcgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YSB0byANCj4geGVuX2R0X2dy
YW50X2luaXRfYmFja2VuZF9kb21pZCgpLCB5b3UgY291bGQgcGFzcyBkb21pZF90IA0KPiAqYmFj
a2VuZF9kb21pZCAoZS5nIHhlbl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoZGV2LCBucCwg
DQo+ICZkYXRhLT5iYWNrZW5kX2RvbWlkKSkuDQo+IEkgdGhpbmsgdGhpcyB3YXkgdGhlIGludGVy
bmFsIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGFpbiBpcyANCj4gbWFuaXB1bGF0ZWQgaW4gYSBz
aW5nbGUgcGxhY2UgYW5kIHhlbl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoKSANCj4gZG9l
cyBub3QgZGVwZW5kIG9uIGl0Lg0KDQpBbHRob3VnaCBJIHRoaW5rIGl0IGlzIG5vdCBkaXJlY3Rs
eSByZWxhdGVkIHRvIGN1cnJlbnQgcGF0Y2gsIEkgYWdyZWUgd2UgDQpjb3VsZCBtYWtlIHRoaXMg
Y2hhbmdlIGFzIHdlIHRvdWNoIHRoZSBsaXN0IG9mIGFyZ3VtZW50cyBmb3IgDQp4ZW5fZHRfZ3Jh
bnRfaW5pdF9iYWNrZW5kX2RvbWlkKCkgYW55d2F5Lg0KDQoNCg0KPg0KPg0KPj4gwqAgwqDCoMKg
wqDCoMKgwqAgaWYgKCFvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShpb21tdV9zcGVjLm5wLCANCj4+
ICJ4ZW4sZ3JhbnQtZG1hIikgfHwNCj4+IEBAIC0zNTQsNiArMzk2LDcgQEAgc3RhdGljIGludCB4
ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKHN0cnVjdA0KPj4gZGV2aWNlICpkZXYsDQo+
PiDCoCDCoHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2KQ0K
Pj4gwqAgwqB7DQo+PiDCoCDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRh
ICpkYXRhOw0KPj4gK8KgwqDCoMKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4NCj4+
IMKgIMKgwqDCoMKgwqDCoMKgIGRhdGEgPSBmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShkZXYpOw0K
Pj4gwqAgwqDCoMKgwqDCoMKgwqAgaWYgKGRhdGEpIHsNCj4+IEBAIC0zNjUsOCArNDA4LDEzIEBA
IHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gwqAg
wqDCoMKgwqDCoMKgwqAgaWYgKCFkYXRhKQ0KPj4gwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgIGdvdG8gZXJyOw0KPj4NCj4+IC3CoMKgwqDCoMKgwqAgaWYgKGRldi0+b2Zfbm9kZSkg
ew0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHhlbl9kdF9ncmFudF9pbml0
X2JhY2tlbmRfZG9taWQoZGV2LCBkYXRhKSkNCj4+ICvCoMKgwqDCoMKgwqAgbnAgPSB4ZW5fZHRf
Z2V0X25vZGUoZGV2KTsNCj4+ICvCoMKgwqDCoMKgwqAgaWYgKG5wKSB7DQo+PiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCBpbnQgcmV0Ow0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgcmV0ID0geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYsIG5w
LCBkYXRhKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG9mX25vZGVfcHV0KG5w
KTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChyZXQpDQo+PiDCoCDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4g
wqAgwqDCoMKgwqDCoMKgwqAgfSBlbHNlIGlmIChJU19FTkFCTEVEKENPTkZJR19YRU5fVklSVElP
X0ZPUkNFX0dSQU5UKSkgew0KPj4gwqAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRl
dl9pbmZvKGRldiwgIlVzaW5nIGRvbTAgYXMgYmFja2VuZFxuIik7DQo+Pg0KPj4NCj4+IERvZXMg
aXQgbG9vayBvayBub3c/DQo+DQo+IFRoYXQgaXMgd2hhdCBJIGhhZCBpbiBtaW5kLiANCg0KDQpH
cmVhdCwgdGhhbmtzIQ0KDQoNCg0KPiBJIGRvIG5vdCBrbm93IGlmIFN0ZWZhbm8gYWdyZWVzIHdp
dGggdGhpcyBhcHByb2FjaC4NCg0KDQpXZSB3aWxsIHNlZQ0KDQoNCj4NCj4+Pg0KPj4+DQo+Pj4+
Pg0KPj4+Pj4gSSAnbSB3b25kZXJpbmcgLi4uIGlzIGl0IHBvc3NpYmxlIGZvciB0aGUgaG9zdCBi
cmlkZ2UgZGV2aWNlIG5vZGUgdG8NCj4+Pj4+IGhhdmUgdGhlIGlvbW11cyBwcm9wZXJ0eSBzZXQ/
IG1lYW5pbmcgdGhhdCBhbGwgb2YgaXRzIHBjaSBkZXZzIHdpbGwNCj4+Pj4+IGhhdmUgdGhlIHNh
bWUgYmFja2VuZD8NCj4+Pj4NCj4+Pj4gR29vZCBxdWVzdGlvbi4gSSB0aGluaywgaXQgaXMgcG9z
c2libGUuLi4gVGhpcyBpcyB0ZWNobmljYWxseSB3aGF0IA0KPj4+PiBWMSBpcw0KPj4+PiBkb2lu
Zy4NCj4+Pj4NCj4+Pj4NCj4+Pj4gQXJlIHlvdSBhc2tpbmcgYmVjYXVzZSB0byBzdXBwb3J0ICJp
b21tdXMiIGZvciBQQ0kgZGV2aWNlcyBhcyB3ZWxsIHRvDQo+Pj4+IGRlc2NyaWJlIHRoYXQgdXNl
LWNhc2Ugd2l0aCBhbGwgUENJIGRldmljZXMgaGF2aW5nIHRoZSBzYW1lIA0KPj4+PiBlbmRwb2lu
dCBJRA0KPj4+PiAoYmFja2VuZCBJRCk/DQo+Pj4+IElmIHllcywgSSB0aGluaywgdGhpcyBjb3Vs
ZCBiZSBzdGlsbCBkZXNjcmliZWQgYnkgImlvbW11LW1hcCIgDQo+Pj4+IHByb3BlcnR5LA0KPj4+
PiBzb21ldGhpbmcgbGlrZSB0aGF0IChpZiB3ZSBkb24ndCB3YW50IHRvIGRlc2NyaWJlIG1hcHBp
bmcgZm9yIGVhY2ggUENJDQo+Pj4+IGRldmljZSBvbmUtYnktb25lKS4NCj4+Pj4NCj4+Pj4gaW9t
bXUtbWFwID0gPDB4MCAmaW9tbXUgWCAweDE+Ow0KPj4+Pg0KPj4+PiBpb21tdS1tYXAtbWFzayA9
IDwweDA+Ow0KPj4+Pg0KPj4+PiB3aGVyZSB0aGUgWCBpcyBiYWNrZW5kIElELg0KPj4+Pg0KPj4+
Pg0KPj4+PiBJdCBmZWVscyB0byBtZSB0aGF0IGl0IHNob3VsZCBiZSB3cml0dGVuIGRvd24gc29t
ZXdoZXJlIHRoYXQgZm9yDQo+Pj4+IHBsYXRmb3JtIGRldmljZXMgd2UgZXhwZWN0ICJpb21tdXMi
IGFuZCBmb3IgUENJIGRldmljZXMgd2UgZXhwZWN0DQo+Pj4+ICJpb21tdS1tYXAvaW9tbXUtbWFw
LW1hc2siIHRvIGJlIHByZXNlbnQuDQo+Pj4NCj4+PiBUaGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0
aW9uLCBub3cgSSBnb3QgaXQuIFllcyBJIGFncmVlLg0KPj4NCj4+DQo+PiBvaywgZ29vZA0KPj4N
Cj4+DQo+Pj4NCj4+Pj4+DQo+Pj4+Pg0KPj4+Pj4+Pg0KPj4+Pj4+Pj4NCj4+Pj4+Pj4+PiDCoMKg
wqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsNCj4+Pj4+Pj4+PiDCoMKgwqDCoCB9DQo+Pj4+Pj4+
Pj4gQEAgLTMyNSwxMiArMzc3LDE5IEBAIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0cnVjdCAN
Cj4+Pj4+Pj4+PiB2aXJ0aW9fZGV2aWNlDQo+Pj4+Pj4+Pj4gKmRldikNCj4+Pj4+Pj4+PiDCoMKg
wqDCoCBzdGF0aWMgaW50IHhlbl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoc3RydWN0IGRl
dmljZSANCj4+Pj4+Pj4+PiAqZGV2LA0KPj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRh
ICpkYXRhKQ0KPj4+Pj4+Pj4+IMKgwqDCoMKgIHsNCj4+Pj4+Pj4+PiAtwqDCoMKgIHN0cnVjdCBv
Zl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYzsNCj4+Pj4+Pj4+PiArwqDCoMKgIHN0cnVjdCBvZl9w
aGFuZGxlX2FyZ3MgaW9tbXVfc3BlYyA9IHsgLmFyZ3NfY291bnQgPSAxIH07DQo+Pj4+Pj4+Pj4g
wqDCoMKgwqAgLcKgwqDCoCBpZiAob2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3MoZGV2LT5vZl9u
b2RlLCAiaW9tbXVzIiwNCj4+Pj4+Pj4+PiAiI2lvbW11LWNlbGxzIiwNCj4+Pj4+Pj4+PiAtwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAwLCAmaW9tbXVfc3BlYykpIHsNCj4+Pj4+Pj4+PiAtwqDCoMKg
wqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsN
Cj4+Pj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FU1JDSDsNCj4+Pj4+Pj4+PiArwqDC
oMKgIGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYg
KHhlbl9kdF9tYXBfaWQoZGV2LCAmaW9tbXVfc3BlYy5ucCwgDQo+Pj4+Pj4+Pj4gaW9tbXVfc3Bl
Yy5hcmdzKSkgew0KPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRldl9lcnIoZGV2
LCAiQ2Fubm90IHRyYW5zbGF0ZSBJRFxuIik7DQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgcmV0dXJuIC1FU1JDSDsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgfQ0KPj4+Pj4+
Pj4+ICvCoMKgwqAgfSBlbHNlIHsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKG9mX3Bh
cnNlX3BoYW5kbGVfd2l0aF9hcmdzKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsDQo+Pj4+Pj4+Pj4g
IiNpb21tdS1jZWxscyIsDQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCAwLCAmaW9tbXVfc3BlYykpIHsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBk
ZXZfZXJyKGRldiwgIkNhbm5vdCBwYXJzZSBpb21tdXMgcHJvcGVydHlcbiIpOw0KPj4+Pj4+Pj4+
ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVNSQ0g7DQo+Pj4+Pj4+Pj4gK8KgwqDC
oMKgwqDCoMKgIH0NCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+Pj4+Pj4+PiDCoMKg
wqDCoCDCoMKgwqDCoMKgIGlmICghb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfc3BlYy5u
cCwNCj4+Pj4+Pj4+PiAieGVuLGdyYW50LWRtYSIpIHx8DQo+Pj4+Pj4+Pj4gQEAgLTM1NCw2ICs0
MTMsNyBAQCBzdGF0aWMgaW50DQo+Pj4+Pj4+Pj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9k
b21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+Pj4+Pj4+Pj4gwqDCoMKgwqAgdm9pZCB4ZW5fZ3Jh
bnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4+Pj4+Pj4gwqDCoMKgwqAg
ew0KPj4+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAq
ZGF0YTsNCj4+Pj4+Pj4+PiArwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnA7DQo+Pj4+Pj4+
Pj4gwqDCoMKgwqAgwqDCoMKgwqDCoCBkYXRhID0gZmluZF94ZW5fZ3JhbnRfZG1hX2RhdGEoZGV2
KTsNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIGlmIChkYXRhKSB7DQo+Pj4+Pj4+Pj4gQEAg
LTM2NSw4ICs0MjUsMTMgQEAgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2
aWNlDQo+Pj4+Pj4+Pj4gKmRldikNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIGlmICghZGF0
YSkNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBlcnI7DQo+Pj4+Pj4+
Pj4gwqDCoMKgwqAgLcKgwqDCoCBpZiAoZGV2LT5vZl9ub2RlKSB7DQo+Pj4+Pj4+Pj4gLcKgwqDC
oMKgwqDCoMKgIGlmICh4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSkp
DQo+Pj4+Pj4+Pj4gK8KgwqDCoCBucCA9IHhlbl9kdF9nZXRfbm9kZShkZXYpOw0KPj4+Pj4+Pj4+
ICvCoMKgwqAgaWYgKG5wKSB7DQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGludCByZXQ7DQo+
Pj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSB4ZW5fZHRfZ3JhbnRf
aW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSk7DQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKg
IG9mX25vZGVfcHV0KG5wKTsNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAgaWYgKHJldCkNCj4+
Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVycjsNCj4+Pj4+
Pj4+PiDCoMKgwqDCoMKgwqDCoMKgIH0gZWxzZSBpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJ
UlRJT19GT1JDRV9HUkFOVCkpIHsNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
ZGV2X2luZm8oZGV2LCAiVXNpbmcgZG9tMCBhcyBiYWNrZW5kXG4iKTsNCj4+Pj4+Pj4+PiAtLSAN
Cj4+Pj4+Pj4+PiAyLjI1LjENCj4+Pj4+Pj4+Pg0KPj4+Pj4+Pj4NCj4+Pj4+Pj4NCj4+Pj4+DQo+
Pj4NCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:41:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:41:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427344.676287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olliR-000598-Ld; Fri, 21 Oct 2022 06:41:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427344.676287; Fri, 21 Oct 2022 06:41:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olliR-000591-Ik; Fri, 21 Oct 2022 06:41:11 +0000
Received: by outflank-mailman (input) for mailman id 427344;
 Fri, 21 Oct 2022 06:41:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olliQ-00058v-4b
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:41:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5699e6dc-510b-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 08:41:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8711D1F74D;
 Fri, 21 Oct 2022 06:41:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 410EA1331A;
 Fri, 21 Oct 2022 06:41:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ZFk6DgE/UmNzGQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 06:41:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5699e6dc-510b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666334465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=l6+8li/xkPStgG0g5SOE7ou6M3apXJUsg3dBlESsAzk=;
	b=ZkoYFXIcx0HKwKcyRNtezkNMA1amOZ1hkdjnMhAJOnlxcEkAG1dcj+8ggZBf8L9MAJ5F+n
	AUtpFZ37c5Z5OIBjz+KREctrW7teqgCZujLSEImZZ7anckAimtvQsrCWBmIzE5cCrIPUX6
	gPvDDk8eMeHctYxVSvs862KQXpkyAls=
Message-ID: <c6fffd83-510e-91cf-5946-faee9541613c@suse.com>
Date: Fri, 21 Oct 2022 08:41:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Jan Beulich <jbeulich@suse.com>
Cc: Juergen Gross <jgross@suse.de>, Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel <xen-devel@lists.xenproject.org>
References: <20200323000946.GH18599@mail-itl>
 <20200929142730.GA25731@mail-itl>
 <d243c1b5-712d-a958-0b6c-b232eb4edc80@suse.com>
 <20200929151627.GE1482@mail-itl>
 <ea53b845-5edf-a61e-62ae-7ababc30b3e0@suse.com>
 <20210131021526.GB6354@mail-itl> <YWHDIQC3K8J3LD8+@mail-itl>
 <YwJZ3X0HpT9w6Veh@mail-itl> <b1df84d5-a1ca-3019-16a7-36d0bb568779@suse.com>
 <YwNTu1fL7uITg0OZ@mail-itl> <YymUZCfLZRWl6xr5@mail-itl>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <YymUZCfLZRWl6xr5@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------H00NuK3sFK0ZqermQGRELYts"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------H00NuK3sFK0ZqermQGRELYts
Content-Type: multipart/mixed; boundary="------------gaAGEaRcUEl0v0LiFNiKWivE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Jan Beulich <jbeulich@suse.com>
Cc: Juergen Gross <jgross@suse.de>, Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 xen-devel <xen-devel@lists.xenproject.org>
Message-ID: <c6fffd83-510e-91cf-5946-faee9541613c@suse.com>
Subject: Re: [Xen-devel] Xen crash after S3 suspend - Xen 4.13 and newer
References: <20200323000946.GH18599@mail-itl>
 <20200929142730.GA25731@mail-itl>
 <d243c1b5-712d-a958-0b6c-b232eb4edc80@suse.com>
 <20200929151627.GE1482@mail-itl>
 <ea53b845-5edf-a61e-62ae-7ababc30b3e0@suse.com>
 <20210131021526.GB6354@mail-itl> <YWHDIQC3K8J3LD8+@mail-itl>
 <YwJZ3X0HpT9w6Veh@mail-itl> <b1df84d5-a1ca-3019-16a7-36d0bb568779@suse.com>
 <YwNTu1fL7uITg0OZ@mail-itl> <YymUZCfLZRWl6xr5@mail-itl>
In-Reply-To: <YymUZCfLZRWl6xr5@mail-itl>

--------------gaAGEaRcUEl0v0LiFNiKWivE
Content-Type: multipart/mixed; boundary="------------fmUtr4b5oYRktqIyT06Qtra3"

--------------fmUtr4b5oYRktqIyT06Qtra3
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjAuMDkuMjIgMTI6MjIsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gTW9uLCBBdWcgMjIsIDIwMjIgYXQgMTI6MDA6MjdQTSArMDIwMCwgTWFyZWsgTWFy
Y3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0KPj4gT24gTW9uLCBBdWcgMjIsIDIwMjIgYXQg
MTE6NTM6NTBBTSArMDIwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMjEuMDguMjAy
MiAxODoxNCwgTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIHdyb3RlOg0KPj4+PiBPbiBT
YXQsIE9jdCAwOSwgMjAyMSBhdCAwNjoyODoxN1BNICswMjAwLCBNYXJlayBNYXJjenlrb3dz
a2ktR8OzcmVja2kgd3JvdGU6DQo+Pj4+PiBPbiBTdW4sIEphbiAzMSwgMjAyMSBhdCAwMzox
NTozMEFNICswMTAwLCBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgd3JvdGU6DQo+Pj4+
Pj4gSSdtIHJlc3VycmVjdGluZyB0aGlzIHRocmVhZCBhcyBpdCB3YXMgcmVjZW50bHkgbWVu
dGlvbmVkIGVsc2V3aGVyZS4gSQ0KPj4+Pj4+IGNhbiBzdGlsbCByZXByb2R1Y2UgdGhlIGlz
c3VlIG9uIHRoZSByZWNlbnQgc3RhZ2luZyBicmFuY2ggKDlkYzY4N2YxNTUpLg0KPj4+Pj4+
DQo+Pj4+Pj4gSXQgZmFpbHMgYWZ0ZXIgdGhlIGZpcnN0IHJlc3VtZSAobm90IGFsd2F5cywg
YnV0IGZyZXF1ZW50IGVub3VnaCB0bw0KPj4+Pj4+IGRlYnVnIGl0KS4gQXQgbGVhc3Qgb25l
IGd1ZXN0IG5lZWRzIHRvIGJlIHJ1bm5pbmcgLSB3aXRoIGp1c3QgKFBWKSBkb20wDQo+Pj4+
Pj4gdGhlIGNyYXNoIGRvZXNuJ3QgaGFwcGVuIChhdCBsZWFzdCBmb3IgdGhlIH44IHRpbWVz
IGluIGEgcm93IEkgdHJpZWQpLg0KPj4+Pj4+IElmIHRoZSBmaXJzdCByZXN1bWUgd29ya3Ms
IHRoZSBzZWNvbmQgKGFsbW9zdD8pIGFsd2F5cyB3aWxsIGZhaWwgYnV0DQo+Pj4+Pj4gd2l0
aCBhIGRpZmZlcmVudCBzeW1wdG9tcyAtIGRvbTAga2VybmVsIGxvY2t1cHMgKGF0IGxlYXN0
IHNvbWUgb2YgaXRzDQo+Pj4+Pj4gdmNwdXMpLiBJIGhhdmVuJ3QgZGVidWdnZWQgdGhpcyBv
bmUgeWV0IGF0IGFsbC4NCj4+Pj4+Pg0KPj4+Pj4+IEFueSBoZWxwIHdpbGwgYmUgYXBwcmVj
aWF0ZWQsIEkgY2FuIGFwcGx5IHNvbWUgZGVidWcgcGF0Y2hlcywgY2hhbmdlDQo+Pj4+Pj4g
Y29uZmlndXJhdGlvbiBldGMuDQo+Pj4+Pg0KPj4+Pj4gVGhpcyBzdGlsbCBoYXBwZW5zIG9u
IDQuMTQuMy4gTWF5YmUgaXQgaXMgcmVsYXRlZCB0byBmcmVlaW5nIHBlcmNwdQ0KPj4+Pj4g
YXJlYXMsIGFzIGl0IGNhdXNlZCBvdGhlciBpc3N1ZXMgd2l0aCBzdXNwZW5kIHRvbz8gSnVz
dCBhIHRob3VnaHQuLi4NCj4+Pj4NCj4+Pj4gSSBoYXZlIHJlcHJvZHVjZWQgdGhpcyBvbiBj
dXJyZW50IHN0YWdpbmcoKikuIEFuZCBJIGNhbiByZXByb2R1Y2UgaXQNCj4+Pj4gcmVsaWFi
bHkuIEFuZCBhbHNvLCBJIGdvdCAoSSBiZWxpZXZlKSBjbG9zZWx5IHJlbGF0ZWQgY3Jhc2gg
d2l0aCBjcmVkaXQxDQo+Pj4+IHNjaGVkdWxlci4NCj4+Pj4NCj4+Pj4gKCopIEl0IGlzbid0
IHBsYWluIHN0YWdpbmcsIGl0J3Mgb25lIHdpdGggbXkgeGhjaSBjb25zb2xlIHBhdGNoZXMg
b24NCj4+Pj4gdG9wLCBpbmNsdWRpbmcgYXR0ZW1wdCB0byBtYWtlIGl0IHN1cnZpdmUgUzMu
IEkgYmVsaWV2ZSB0aGUgb25seQ0KPj4+PiByZWxldmFudCBwYXJ0IHRoZXJlIGlzIHN0aWNr
aW5nIHNldF90aW1lcigpIGludG8gY29uc29sZSByZXN1bWUgcGF0aCAob3INCj4+Pj4ganVz
dCBoYXZpbmcgYSB0aW1lciB3aXRoIHJhdGhlciBzaG9ydCBkZWxheSByZWdpc3RlcmVkKS4g
VGhlIGFjdHVhbCB0cmVlDQo+Pj4+IGF0IGh0dHBzOi8vZ2l0aHViLmNvbS9tYXJtYXJlay94
ZW4vdHJlZS9tYXN0ZXIteHVlMi1kZWJ1ZywgaW5jbHVkaW5nDQo+Pj4+IHF1aXRlIGEgbG90
IG9mIGRlYnVnIHByaW50cyBhbmQgZGVidWcgaGFja3MuDQo+Pj4+DQo+Pj4+IFNwZWNpZmlj
IGNyYXNoIHdpdGggY3JlZGl0MjoNCj4+DQo+PiAoWEVOKSBBc3NlcnRpb24gJ2MycnFkKHNj
aGVkX3VuaXRfbWFzdGVyKHVuaXQpKSA9PSBzdmMtPnJxZCcgZmFpbGVkIGF0IGNvbW1vbi9z
Y2hlZC9jcmVkaXQyLmM6MjI3NA0KPj4gKFhFTikgLS0tLVsgWGVuLTQuMTctdW5zdGFibGUg
IHg4Nl82NCAgZGVidWc9eSAgVGFpbnRlZDogICBDICAgIF0tLS0tDQo+PiAoWEVOKSBDUFU6
ICAgIDEwDQo+PiAoWEVOKSBSSVA6ICAgIGUwMDg6WzxmZmZmODJkMDQwMjQ3YTRkPl0gY3Jl
ZGl0Mi5jI2NzY2hlZDJfdW5pdF93YWtlKzB4MTUyLzB4MTU0DQo+PiAoWEVOKSBSRkxBR1M6
IDAwMDAwMDAwMDAwMTAwODMgICBDT05URVhUOiBoeXBlcnZpc29yIChkMHYwKQ0KPj4gKFhF
TikgcmF4OiBmZmZmODMwMjUxNzc4MjMwICAgcmJ4OiBmZmZmODMwMjUxNzY4Y2IwICAgcmN4
OiAwMDAwMDAzMjExMWQ2MDAwDQo+PiAoWEVOKSByZHg6IGZmZmY4MzAyNTE1YzFlYjAgICBy
c2k6IDAwMDAwMDAwMDAwMDAwMDYgICByZGk6IGZmZmY4MzAyNTE3NjkwMDANCj4+IChYRU4p
IHJicDogZmZmZjgzMDI1MTVjZmQ5MCAgIHJzcDogZmZmZjgzMDI1MTVjZmQ3MCAgIHI4OiAg
ZmZmZjgzMDI1MTc2OTAwMA0KPj4gKFhFTikgcjk6ICAwMDAwMDAwMDAwMDAwMDAwICAgcjEw
OiAwMDAwMDAwMDAwMDAwMDAwICAgcjExOiAwMDAwMDAwMDAwMDAwMDAwDQo+PiAoWEVOKSBy
MTI6IGZmZmY4MzAyNTE3NjhkZDAgICByMTM6IGZmZmY4MzAyNTE1YzFkMDAgICByMTQ6IDAw
MDAwMDAwMDAwMDAwMDYNCj4+IChYRU4pIHIxNTogZmZmZjgyZDA0MDVkZGI0MCAgIGNyMDog
MDAwMDAwMDA4MDA1MDAzMyAgIGNyNDogMDAwMDAwMDAwMDM3MjY2MA0KPj4gKFhFTikgY3Iz
OiAwMDAwMDAwMjJmMmExMDAwICAgY3IyOiBmZmZmODg4MTAxMjczOGUwDQo+PiAoWEVOKSBm
c2I6IDAwMDA3NDRiZjZhMGRiODAgICBnc2I6IGZmZmY4ODgyNTU2MDAwMDAgICBnc3M6IDAw
MDAwMDAwMDAwMDAwMDANCj4+IChYRU4pIGRzOiAwMDAwICAgZXM6IDAwMDAgICBmczogMDAw
MCAgIGdzOiAwMDAwICAgc3M6IGUwMTAgICBjczogZTAwOA0KPj4gKFhFTikgWGVuIGNvZGUg
YXJvdW5kIDxmZmZmODJkMDQwMjQ3YTRkPiAoY3JlZGl0Mi5jI2NzY2hlZDJfdW5pdF93YWtl
KzB4MTUyLzB4MTU0KToNCj4+IChYRU4pICBkZiBlOCA2ZiBiZiBmZiBmZiBlYiBhZCA8MGY+
IDBiIGYzIDBmIDFlIGZhIDU1IDQ4IDg5IGU1IDQxIDU3IDQxIDU2IDQxIDU1DQo+PiAoWEVO
KSBYZW4gc3RhY2sgdHJhY2UgZnJvbSByc3A9ZmZmZjgzMDI1MTVjZmQ3MDoNCj4+IChYRU4p
ICAgIGZmZmY4MzAyNTE3NGIwMDAgZmZmZjgzMDI1MTc2OGNiMCBmZmZmODMwMjUxNzc4Mjcw
IGZmZmY4MmQwNDA1YzQyOTgNCj4+IChYRU4pICAgIGZmZmY4MzAyNTE1Y2ZkZDggZmZmZjgy
ZDA0MDI0ZmNiOCAwMDAwMDAwMDAwMDAwMjAyIGZmZmY4MzAyNTE3NzgyNzANCj4+IChYRU4p
ICAgIGZmZmY4MzAyNTE3NGIwMDAgMDAwMDAwMDAwMDAwMDAwMSBmZmZmODMwMjUxNzY5MDE4
IDAwMDAwMDAwMDAwMDAwMDANCj4+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjgz
MDI1MTVjZmU0OCBmZmZmODJkMDQwMjBhOGM5IGZmZmY4ODgyNTU2YWVkYzANCj4+IChYRU4p
ICAgIDAwMDAwMDAwMDAwMDAwMDMgMDAwMDE5MTA1MzdlNjIzZSAwMDAwMDAwYjk4OGY3OGE2
IDAwMDAwMDAwNTlkNGE3MTYNCj4+IChYRU4pICAgIDAwMDAxOTAxZjMwZmE0MWUgMDAwMDAw
MDIxN2Y5NmFmNiAwMDAwMDAwMDAwMDAwMDAwIGZmZmY4MzAyNTE3NGIwMDANCj4+IChYRU4p
ICAgIGZmZmY4MzAyNTE3NTYwMDAgMDAwMDAwMDAwMDAwMDAwMiAwMDAwMDAwMDAwMDAwMDAx
IGZmZmY4MzAyNTE1Y2ZlNzANCj4+IChYRU4pICAgIGZmZmY4MmQwNDAyZjc5NjggZmZmZjgz
MDI1MTc1NjAwMCBmZmZmODMwMjUxNWNmZWY4IDAwMDAwMDAwMDAwMDAwMTgNCj4+IChYRU4p
ICAgIGZmZmY4MzAyNTE1Y2ZlZTggZmZmZjgyZDA0MDJlYzZkZSAwMDAwMDAwMDAwMDAwMDAw
IGZmZmZmZmZmODJmMTU3ZTANCj4+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAw
MDAwMDAwMDAwMCBmZmZmODMwMjUxNWNmZWY4IDAwMDAwMDAwMDAwMDAwMDANCj4+IChYRU4p
ICAgIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjgzMDI1MTVjZmZmZiBmZmZmODMwMjUxNzU2MDAw
IDAwMDAwMDAwMDAwMDAwMDANCj4+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAw
MDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAwIDAwMDA3Y2ZkYWVhMzAwZTcNCj4+IChYRU4p
ICAgIGZmZmY4MmQwNDAyMDEyYmQgMDAwMDAwMDAwMDAwMDAwMCBmZmZmZmZmZjgyYzUxMTIw
IGZmZmY4ODgxMDAzNmNmMDANCj4+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDIgMDAwMDAw
MDAwMDAxZTEyMCAwMDAwMDAwMDAwMDAwMDAyIDAwMDAwMDAwMDAwMDAyNDYNCj4+IChYRU4p
ICAgIGZmZmZmZmZmODJmMTU3ZTAgMDAwMDAwMDAwMDAwMDAwMSAwMDAwMDAwMDAwMDAwMDAw
IDAwMDAwMDAwMDAwMDAwMTgNCj4+IChYRU4pICAgIGZmZmZmZmZmODFlNGEzMGEgMDAwMDAw
MDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAyIDAwMDAwMDAwMDAwMDAwMDENCj4+IChYRU4p
ICAgIDAwMDAwMTAwMDAwMDAwMDAgZmZmZmZmZmY4MWU0YTMwYSAwMDAwMDAwMDAwMDBlMDMz
IDAwMDAwMDAwMDAwMDAyNDYNCj4+IChYRU4pICAgIGZmZmZjOTAwNGFlZjdjMTggMDAwMDAw
MDAwMDAwZTAyYiBmYjVlZTM5OGQyMTRiMTBjIGViNWVmMzk4YzIxNGExMGMNCj4+IChYRU4p
ICAgIGViNTZmMzkwYzIxY2ExMDQgZWJkNmYzMTBjMjljYTE4NCAwMDAwZTAxMDAwMDAwMDBh
IGZmZmY4MzAyNTE3NTYwMDANCj4+IChYRU4pICAgIDAwMDAwMDMyMTEwMTYwMDAgMDAwMDAw
MDAwMDM3MjY2MCAwMDAwMDAwMDAwMDAwMDAwIDgwMDAwMDAyOTYzZTEwMDINCj4+IChYRU4p
IFhlbiBjYWxsIHRyYWNlOg0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjQ3YTRkPl0gUiBj
cmVkaXQyLmMjY3NjaGVkMl91bml0X3dha2UrMHgxNTIvMHgxNTQNCj4+IChYRU4pICAgIFs8
ZmZmZjgyZDA0MDI0ZmNiOD5dIEYgdmNwdV93YWtlKzB4ZmQvMHgyNjcNCj4+IChYRU4pICAg
IFs8ZmZmZjgyZDA0MDIwYThjOT5dIEYgY29tbW9uX3ZjcHVfb3ArMHgxNzgvMHg1ZDENCj4+
IChYRU4pICAgIFs8ZmZmZjgyZDA0MDJmNzk2OD5dIEYgZG9fdmNwdV9vcCsweDY5LzB4MjI2
DQo+PiAoWEVOKSAgICBbPGZmZmY4MmQwNDAyZWM2ZGU+XSBGIHB2X2h5cGVyY2FsbCsweDU3
NS8weDY1Nw0KPj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjAxMmJkPl0gRiBsc3Rhcl9lbnRl
cisweDEzZC8weDE1MA0KPj4gKFhFTikNCj4+IChYRU4pDQo+PiAoWEVOKSAqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+PiAoWEVOKSBQYW5pYyBvbiBDUFUg
MTA6DQo+PiAoWEVOKSBBc3NlcnRpb24gJ2MycnFkKHNjaGVkX3VuaXRfbWFzdGVyKHVuaXQp
KSA9PSBzdmMtPnJxZCcgZmFpbGVkIGF0IGNvbW1vbi9zY2hlZC9jcmVkaXQyLmM6MjI3NA0K
Pj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKg0KPiAN
Cj4gT2ssIEkgdGhpbmsgSSBmaWd1cmVkIGl0IG91dCENCj4gDQo+IEkgYWRkZWQgYSBmdW5j
dGlvbiB0aGF0IHZlcmlmaWVzIHJ1biBxdWV1ZXMgb2YgYWxsIHRoZSBzY2hlZCB1bml0cywg
YW5kDQo+IGNhbGxlZCBpdCBiYXNpY2FsbHkgZXZlcnkgb3RoZXIgbGluZSBvbiB0aGUgcmVz
dW1lIHBhdGguIFRoZSBkZWJ1Zw0KPiBmdW5jdGlvbiAoaWYgYW55Ym9keSBpcyBpbnRlcmVz
dGVkKToNCj4gDQo+ICAgICAgdm9pZCB2ZXJpZnlfc2NoZWRfdW5pdHModm9pZCkNCj4gICAg
ICB7DQo+ICAgICAgICAgIHN0cnVjdCBkb21haW4gKmQ7DQo+ICAgICAgICAgIGNvbnN0IHN0
cnVjdCBzY2hlZF91bml0ICp1bml0Ow0KPiAgICAgICAgICANCj4gICAgICAgICAgZm9yX2Vh
Y2hfZG9tYWluICggZCApDQo+ICAgICAgICAgIHsNCj4gICAgICAgICAgICAgIGZvcl9lYWNo
X3NjaGVkX3VuaXQgKCBkLCB1bml0ICkNCj4gICAgICAgICAgICAgIHsNCj4gICAgICAgICAg
ICAgICAgICBpZiAoIGMycnFkKHNjaGVkX3VuaXRfbWFzdGVyKHVuaXQpKSAhPSBjc2NoZWQy
X3VuaXQodW5pdCktPnJxZCApDQo+ICAgICAgICAgICAgICAgICAgew0KPiAgICAgICAgICAg
ICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgImQlZCBzY2hlZCB1bml0ICVkOiBy
cT0lZCwgdW5pdCBtYXN0ZXIgJWQsIHJxPSVkXG4iLA0KPiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGQtPmRvbWFpbl9pZCwgdW5pdC0+dW5pdF9pZCwNCj4gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBjc2NoZWQyX3VuaXQodW5pdCktPnJxZCA/IGNzY2hlZDJfdW5p
dCh1bml0KS0+cnFkLT5pZCA6IC0xLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHNjaGVkX3VuaXRfbWFzdGVyKHVuaXQpLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGMycnFkKHNjaGVkX3VuaXRfbWFzdGVyKHVuaXQpKS0+aWQpOw0KPiAgICAgICAgICAg
ICAgICAgICAgICBXQVJOX09OKDEpOw0KPiAgICAgICAgICAgICAgICAgIH0NCj4gICAgICAg
ICAgICAgIH0NCj4gICAgICAgICAgfQ0KPiAgICAgIH0NCj4gDQo+IEl0IGFwcGVhcnMgdGhh
dCByZXN0b3JlX3ZjcHVfYWZmaW5pdHkoKSBpcyByZXNwb25zaWJsZSwgc3BlY2lmaWNhbGx5
DQo+IHRoaXMgcGFydDoNCj4gDQo+IDEyMTYgICAgICAgICAvKg0KPiAxMjE3ICAgICAgICAg
ICogUmUtYXNzaWduIHRoZSBpbml0aWFsIHByb2Nlc3NvciBhcyBhZnRlciByZXN1bWUgd2Ug
aGF2ZSBubw0KPiAxMjE4ICAgICAgICAgICogZ3VhcmFudGVlIHRoZSBvbGQgcHJvY2Vzc29y
IGhhcyBjb21lIGJhY2sgdG8gbGlmZSBhZ2Fpbi4NCj4gMTIxOSAgICAgICAgICAqDQo+IDEy
MjAgICAgICAgICAgKiBUaGVyZWZvcmUsIGhlcmUsIGJlZm9yZSBhY3R1YWxseSB1bnBhdXNp
bmcgdGhlIGRvbWFpbnMsIHdlIHNob3VsZA0KPiAxMjIxICAgICAgICAgICogc2V0IHYtPnBy
b2Nlc3NvciBvZiBlYWNoIG9mIHRoZWlyIHZDUFVzIHRvIHNvbWV0aGluZyB0aGF0IHdpbGwN
Cj4gMTIyMiAgICAgICAgICAqIG1ha2Ugc2Vuc2UgZm9yIHRoZSBzY2hlZHVsZXIgb2YgdGhl
IGNwdXBvb2wgaW4gd2hpY2ggdGhleSBhcmUgaW4uDQo+IDEyMjMgICAgICAgICAgKi8NCj4g
Li4uDQo+IDEyNDkgICAgICAgICByZXMgPSBnZXRfc2NoZWRfcmVzKGNwdW1hc2tfYW55KGNw
dW1hc2tfc2NyYXRjaF9jcHUoY3B1KSkpOw0KPiAxMjUwICAgICAgICAgc2NoZWRfc2V0X3Jl
cyh1bml0LCByZXMpOw0KPiAxMjUxDQo+IDEyNTIgICAgICAgICBzcGluX3VubG9ja19pcnEo
bG9jayk7DQo+IDEyNTMNCj4gMTI1NCAgICAgICAgIC8qIHYtPnByb2Nlc3NvciBtaWdodCBo
YXZlIGNoYW5nZWQsIHNvIHJlYWNxdWlyZSB0aGUgbG9jay4gKi8NCj4gMTI1NSAgICAgICAg
IGxvY2sgPSB1bml0X3NjaGVkdWxlX2xvY2tfaXJxKHVuaXQpOw0KPiAxMjU2ICAgICAgICAg
cmVzID0gc2NoZWRfcGlja19yZXNvdXJjZSh1bml0X3NjaGVkdWxlcih1bml0KSwgdW5pdCk7
DQo+IDEyNTcgICAgICAgICBzY2hlZF9zZXRfcmVzKHVuaXQsIHJlcyk7DQo+IDEyNTggICAg
ICAgICBzcGluX3VubG9ja19pcnEobG9jayk7DQo+IDEyNTkNCj4gMTI2MCAgICAgICAgIGlm
ICggb2xkX2NwdSAhPSBzY2hlZF91bml0X21hc3Rlcih1bml0KSApDQo+IDEyNjEgICAgICAg
ICAgICAgc2NoZWRfbW92ZV9pcnFzKHVuaXQpOw0KPiANCj4gSXQgY2FsbHMgc2NoZWRfc2V0
X3JlcygpIGRpcmVjdGx5LCB3aGljaCBhc3NpZ25zIHNjaGVkIHJlc291cmNlcywgYnV0DQo+
IGRvZXMgX25vdF8gYWRqdXN0IHJ1bnF1ZXVlcyAoaWYgbmV3IHBjcHUgaGFwcGVuIHRvIGJl
IGFzc2lnbmVkIHRvDQo+IGFub3RoZXIgcnVucXVldWUgdGhhbiB0aGUgb25lIGZyb20gcHJl
dmlvdXMgcGNwdSkuDQo+IA0KPiBJIGhhdmUgdHdvIChub24gZXhjbHVzaXZlKSBpZGVhcyBo
ZXJlOg0KPiAxLiBJZiBvbGRfY3B1IGlzIGFjdHVhbGx5IHN0aWxsIGF2YWlsYWJsZSwgZG8g
bm90IG1vdmUgaXQgYXQgYWxsLg0KPiAyLiBVc2Ugc2NoZWRfbWlncmF0ZSgpIGluc3RlYWQg
b2Ygc2NoZWRfc2V0X3JlcygpLg0KPiANCj4gSGVyZSBpcyB0aGUgcGF0Y2ggdGhhdCBmaXhl
cyBpdCBmb3IgbWU6DQo+IC0tLTg8LS0tDQo+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL3Nj
aGVkL2NvcmUuYyBiL3hlbi9jb21tb24vc2NoZWQvY29yZS5jDQo+IGluZGV4IDgzNDU1ZmJk
ZTFjOC4uZGNmMjAyZDhiMzA3IDEwMDY0NA0KPiAtLS0gYS94ZW4vY29tbW9uL3NjaGVkL2Nv
cmUuYw0KPiArKysgYi94ZW4vY29tbW9uL3NjaGVkL2NvcmUuYw0KPiBAQCAtMTI0NiwxOSAr
MTI0NiwyOSBAQCB2b2lkIHJlc3RvcmVfdmNwdV9hZmZpbml0eShzdHJ1Y3QgZG9tYWluICpk
KQ0KPiAgICAgICAgICAgICAgIH0NCj4gICAgICAgICAgIH0NCj4gICANCj4gLSAgICAgICAg
cmVzID0gZ2V0X3NjaGVkX3JlcyhjcHVtYXNrX2FueShjcHVtYXNrX3NjcmF0Y2hfY3B1KGNw
dSkpKTsNCj4gKyAgICAgICAgLyogUHJlZmVyIG9sZCBjcHUgaWYgYXZhaWxhYmxlLiAqLw0K
PiArICAgICAgICBpZiAoIGNwdW1hc2tfdGVzdF9jcHUob2xkX2NwdSwgY3B1bWFza19zY3Jh
dGNoX2NwdShjcHUpKSApDQo+ICsgICAgICAgICAgICByZXMgPSBnZXRfc2NoZWRfcmVzKG9s
ZF9jcHUpOw0KPiArICAgICAgICBlbHNlDQo+ICsgICAgICAgICAgICByZXMgPSBnZXRfc2No
ZWRfcmVzKGNwdW1hc2tfYW55KGNwdW1hc2tfc2NyYXRjaF9jcHUoY3B1KSkpOw0KPiAgICAg
ICAgICAgc2NoZWRfc2V0X3Jlcyh1bml0LCByZXMpOw0KPiAgIA0KPiAgICAgICAgICAgc3Bp
bl91bmxvY2tfaXJxKGxvY2spOw0KPiAgIA0KPiAtICAgICAgICAvKiB2LT5wcm9jZXNzb3Ig
bWlnaHQgaGF2ZSBjaGFuZ2VkLCBzbyByZWFjcXVpcmUgdGhlIGxvY2suICovDQo+IC0gICAg
ICAgIGxvY2sgPSB1bml0X3NjaGVkdWxlX2xvY2tfaXJxKHVuaXQpOw0KPiAtICAgICAgICBy
ZXMgPSBzY2hlZF9waWNrX3Jlc291cmNlKHVuaXRfc2NoZWR1bGVyKHVuaXQpLCB1bml0KTsN
Cj4gLSAgICAgICAgc2NoZWRfc2V0X3Jlcyh1bml0LCByZXMpOw0KPiAtICAgICAgICBzcGlu
X3VubG9ja19pcnEobG9jayk7DQo+IC0NCj4gKyAgICAgICAgLyoNCj4gKyAgICAgICAgICog
SWYgZGlmZmVyZW50IGNwdSB3YXMgY2hvc2VuLCBpdCB3YXMgcmFuZG9tLCBsZXQgc2NoZWR1
bGVyIGRvIHByb3Blcg0KPiArICAgICAgICAgKiBkZWNpc2lvbi4NCj4gKyAgICAgICAgICov
DQo+ICAgICAgICAgICBpZiAoIG9sZF9jcHUgIT0gc2NoZWRfdW5pdF9tYXN0ZXIodW5pdCkg
KQ0KPiArICAgICAgICB7DQo+ICsgICAgICAgICAgICAvKiB2LT5wcm9jZXNzb3IgbWlnaHQg
aGF2ZSBjaGFuZ2VkLCBzbyByZWFjcXVpcmUgdGhlIGxvY2suICovDQo+ICsgICAgICAgICAg
ICBsb2NrID0gdW5pdF9zY2hlZHVsZV9sb2NrX2lycSh1bml0KTsNCj4gKyAgICAgICAgICAg
IHJlcyA9IHNjaGVkX3BpY2tfcmVzb3VyY2UodW5pdF9zY2hlZHVsZXIodW5pdCksIHVuaXQp
Ow0KPiArICAgICAgICAgICAgc2NoZWRfbWlncmF0ZSh1bml0X3NjaGVkdWxlcih1bml0KSwg
dW5pdCwgcmVzLT5tYXN0ZXJfY3B1KTsNCj4gKyAgICAgICAgICAgIHNwaW5fdW5sb2NrX2ly
cShsb2NrKTsNCj4gKw0KPiAgICAgICAgICAgICAgIHNjaGVkX21vdmVfaXJxcyh1bml0KTsN
Cj4gKyAgICAgICAgfQ0KPiAgICAgICB9DQo+ICAgDQo+ICAgICAgIHJjdV9yZWFkX3VubG9j
aygmc2NoZWRfcmVzX3JjdWxvY2spOw0KPiAtLS04PC0tLQ0KPiANCj4gSSBoYXZlIHNldmVy
YWwgZG91YnRzIGhlcmU6DQo+IA0KPiAxLiBJZiBvbGRfY3B1IGlzIGF2YWlsYWJsZSwgaXMg
c2NoZWRfc2V0X3JlcygpIG5lZWRlZCBhdCBhbGw/DQo+IDIuIFNob3VsZCBib3RoIGNhbGxz
IGJlIGNoYW5nZWQgdG8gc2NoZWRfbWlncmF0ZSgpPyBDdXJyZW50bHkgSSBjaGFuZ2VkDQo+
ICAgICBvbmx5IHRoZSBzZWNvbmQgb25lLCBpbiBjYXNlIHNjaGVkdWxlciBjb3VsZCBiZSBj
b25mdXNlZCBhYm91dA0KPiAgICAgb2xkX2NwdSBub3QgYmVpbmcgYXZhaWxhYmxlIGFueW1v
cmUuDQo+IDMuIEFyZSB0aGVyZSBhbnkgZXh0cmEgbG9ja2luZyByZXF1aXJlbWVudHMgZm9y
IHNjaGVkX21pZ3JhdGUoKSBhdCB0aGlzDQo+ICAgICBzdGFnZT8gVGhlIGxvbmcgY29tbWVu
dCBhYm92ZSBzY2hlZF91bml0X21pZ3JhdGVfc3RhcnQoKSBzdWdnZXN0cw0KPiAgICAgdGhl
cmUgbWlnaHQgYmUsIGJ1dCBJJ20gbm90IHN1cmUgaWYgdGhhdCdzIHJlYWxseSB0aGUgY2Fz
ZSBkdXJpbmcNCj4gICAgIHJlc3VtZS4NCj4gNC4gUmVsYXRlZCB0byB0aGUgYWJvdmUgLSBz
aG91bGQgdGhhd19kb21haW5zKCkgYmUgbW9kaWZpZWQgdG8gY2FsbA0KPiAgICAgcmVzdG9y
ZV92Y3B1X2FmZmluaXR5KCkgZm9yIGFsbCBkb21haW5zIGZpcnN0LCBhbmQgdW5wYXVzZSBv
bmx5DQo+ICAgICBsYXRlcj8gVGhhdCBjb3VsZCByZWR1Y2UgbG9ja2luZyByZXF1aXJlbWVu
dHMsIEkgZ3Vlc3MuDQo+IA0KDQpMb29raW5nIGludG8gdGhpcyBpbiBtb3JlIGRldGFpbCBJ
IHRoaW5rIHRoZSBmaXggaXMgbXVjaCBlYXNpZXIuDQoNCkluIGNhc2UgYSBjcHUgaXNuJ3Qg
Y29taW5nIHVwIGFnYWluIGFmdGVyIHN1c3BlbmQsIGNwdV9kaXNhYmxlX3NjaGVkdWxlcigp
DQpmb3IgdGhpcyBjcHUgd2lsbCBiZSBjYWxsZWQuIFRoaXMgd2lsbCBkbyB0aGUgbmVlZGVk
IHZjcHUgbWlncmF0aW9uLCBzbyB3ZQ0KY2FuIGp1c3QgcmVtb3ZlIHJlc3RvcmVfdmNwdV9h
ZmZpbml0eSgpIGNvbXBsZXRlbHkgd2l0aG91dCBhbnkgbmVlZCBmb3INCnJlcGxhY2VtZW50
Lg0KDQpJJ2xsIHdyaXRlIGEgcGF0Y2guDQoNCg0KSnVlcmdlbg0K
--------------fmUtr4b5oYRktqIyT06Qtra3
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------fmUtr4b5oYRktqIyT06Qtra3--

--------------gaAGEaRcUEl0v0LiFNiKWivE--

--------------H00NuK3sFK0ZqermQGRELYts
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNSPwAFAwAAAAAACgkQsN6d1ii/Ey87
dgf/TF5ozEKkGUa49DmUwejCsoygFKnOQvvbr0HvGoQKNlEQ0UhFaiq4EdgXT0BStwPn4ttxO94q
vOlYwPhuQ73Brgd+PGyosUgVeIBnezPg5u/L/GiEAqp5SZBdeCMSLakDsxcdpU57DilK85Hhsoq2
ryReuFA1+48SOCgboYNV0Vwh3djxxT8jvrYqO8S01pd+AsEURFifU7cChCSYjAZ0Fx2M/XooRKK8
d36CbpbsDNEyPu1uoTpBdk/3C0Fu1ogcREb8NUaI3Ihj4BoVrgFcTAQOnc/nFSDbYAPVDgeOLd5M
Wu7RHRxu95orVys/+cxi1gvItacRUe/33w0TO7Xtxw==
=wLJj
-----END PGP SIGNATURE-----

--------------H00NuK3sFK0ZqermQGRELYts--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:47:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:47:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427349.676298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollo6-0005sw-B4; Fri, 21 Oct 2022 06:47:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427349.676298; Fri, 21 Oct 2022 06:47:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollo6-0005sp-8C; Fri, 21 Oct 2022 06:47:02 +0000
Received: by outflank-mailman (input) for mailman id 427349;
 Fri, 21 Oct 2022 06:47:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1ollo4-0005rC-P4
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:47:00 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 284c7fd4-510c-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 08:46:59 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-214-excxtAtJM-aWvuXQ-q56Cw-1; Fri, 21 Oct 2022 02:46:53 -0400
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC8168688D1;
 Fri, 21 Oct 2022 06:46:52 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 848D31759E;
 Fri, 21 Oct 2022 06:46:52 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 73EDE21E6686; Fri, 21 Oct 2022 08:46:51 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 284c7fd4-510c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666334817;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=jpXOT60aSEVePNxPzhS7Cx5BChB4JcWs66WBHAn2u+s=;
	b=H4YF/HSnqa5ksNrXdejw5usaNF0Eu4tic502FgdpPFYZEXHnkErYebOC3woRCdcGBu1qzc
	5K/uc3upd4KKLelk+RKV5Wx7/K5z/7xRJ0eFIR2jBvdiowCBXSKaJOZzQCsTDFpSYxGHs5
	JilQ5nGen7vzVAHXTC6LKoUNsjIx7+o=
X-MC-Unique: excxtAtJM-aWvuXQ-q56Cw-1
From: Markus Armbruster <armbru@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,  qemu-devel@nongnu.org,  Paul
 Durrant <paul@xen.org>,  Thomas Huth <thuth@redhat.com>,  Daniel P.
 =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>,  Greg Kurz <groug@kaod.org>,  Stefano Stabellini
 <sstabellini@kernel.org>,  David Gibson <david@gibson.dropbear.id.au>,
  Eric Blake <eblake@redhat.com>,  xen-devel@lists.xenproject.org,
  "Michael S. Tsirkin" <mst@redhat.com>,  Stefan Weil <sw@weilnetz.de>,
  Paolo Bonzini <pbonzini@redhat.com>,  Samuel Thibault
 <samuel.thibault@ens-lyon.org>,  Anthony Perard
 <anthony.perard@citrix.com>,  Ralph Schmieder <ralph.schmieder@gmail.com>,
  Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v13 00/17] qapi: net: add unix socket type support to
 netdev backend
References: <20221020162558.123284-1-lvivier@redhat.com>
	<CACGkMEt9Hoo=GAuCUqMcBjqNvs94fEPA_GU9Z7TOh8c7Wam55Q@mail.gmail.com>
Date: Fri, 21 Oct 2022 08:46:51 +0200
In-Reply-To: <CACGkMEt9Hoo=GAuCUqMcBjqNvs94fEPA_GU9Z7TOh8c7Wam55Q@mail.gmail.com>
	(Jason Wang's message of "Fri, 21 Oct 2022 13:49:05 +0800")
Message-ID: <87h6zx4qsk.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5

Jason Wang <jasowang@redhat.com> writes:

> I've queued this version and will send pull requests shortly.
>
> Any future comment we can do patches on top.

Please give Laurent and me a few hours to try to improve PATCH 17's
commit message.  Which you could then integrate without a respin.



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:47:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:47:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427351.676309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olloO-0006JV-JK; Fri, 21 Oct 2022 06:47:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427351.676309; Fri, 21 Oct 2022 06:47:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olloO-0006JH-Fp; Fri, 21 Oct 2022 06:47:20 +0000
Received: by outflank-mailman (input) for mailman id 427351;
 Fri, 21 Oct 2022 06:47:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=maBo=2W=oracle.com=dan.carpenter@srs-se1.protection.inumbo.net>)
 id 1olloN-0005rC-KW
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:47:19 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 331d81d2-510c-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 08:47:17 +0200 (CEST)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29L5OieU012724;
 Fri, 21 Oct 2022 06:46:58 GMT
Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com
 (iadpaimrmta03.appoci.oracle.com [130.35.103.27])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k7ndtr46v-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 21 Oct 2022 06:46:58 +0000
Received: from pps.filterd
 (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5)
 with ESMTP id 29L5Daa8007137; Fri, 21 Oct 2022 06:46:57 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46])
 by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id
 3k8hrdjm4r-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 21 Oct 2022 06:46:56 +0000
Received: from MWHPR1001MB2365.namprd10.prod.outlook.com
 (2603:10b6:301:2d::28) by DS7PR10MB4973.namprd10.prod.outlook.com
 (2603:10b6:5:38d::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 06:46:54 +0000
Received: from MWHPR1001MB2365.namprd10.prod.outlook.com
 ([fe80::1b8e:540e:10f0:9aec]) by MWHPR1001MB2365.namprd10.prod.outlook.com
 ([fe80::1b8e:540e:10f0:9aec%4]) with mapi id 15.20.5676.031; Fri, 21 Oct 2022
 06:46:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 331d81d2-510c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc
 : subject : message-id : references : content-type : in-reply-to :
 mime-version; s=corp-2022-7-12;
 bh=6hKG2KqTnTud9V9LvgscRjsffi64dBQ91yNsXurffcE=;
 b=lYBV+4VoVm9xhQN06OuAvbadCV4C3mxjsy5BpBYRG+240zYWoDxbDVOq3yRTfpeLr7c3
 1cpKgOBvoX4c2r6pODb2H/AUo7uhkkrh6DqBUFnjFMyRBkzdIuZq95Fs4NYc+rZbPobB
 0XqeBLOVhImS5khLW2ULYbECkpScGst9U0c10KHvhLcIZZG4Ni4KqT7sjMmu77zV5wbA
 vQezJrmxFCxa6jZmQLO3KqdndZG4dd7J9OBTCVKB90CUhpIgiMPktqKlhHRbm/1Nedu1
 ctdx/EAYCUT9DZ2mDAnlYWsxx+E8omQoChs8Z8pdK9OdmmYa6FNOyQXLy4eqE4YwT2J9 9w== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kGNZsh2LTd7xR9ZrQz0NjC6fwxBZrSZm8ZMMT+1++vDwC3G55motMF8wChLJh/myhVdpfwhPtBWx7jFK9N5Tx/YnzhNivQZfvf3zp+RbXVbTM9OG2WtPPnGXYpvFYWmKwQM8T4dqAgmCBLgyhAzVGEcUhnjh5mO3rR9hHAhp6G2i39MmsyvHvU2Z+OTDOHnuIMW5vwJVx6eAV036GqxTmeVtKjWSVaddXMf4YLnLSTsuEeXjnSlbl8qWLXl+wTElHUJQtUxh7fEaxXq3t1xRM+U/YhH4SCNH2pJsUH9XMNtf4jkQfRTra6ErGXZopvx1mLdcslEOMK7hQ2kECMrS7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6hKG2KqTnTud9V9LvgscRjsffi64dBQ91yNsXurffcE=;
 b=hMwReJxSzz8TRuyFn7CNHJa+yx25dJSbOlQ4aIKBkOO61ddc+M/IYTRIsagCgLcYZfSWIYyB2KSF6uPTCoXdjlq/H0RyqHZtu4N7Vj6AYKpQST51+mA0a2fOECZHW4f0z3mms70NjsIJAIcLIjRsL/VZQ6qB2GhPQXJsV4m37YEjzoy0rlmdU7SDl59yvptIaZWiKW5l8QrnlOKMfLgWlM1eFGooobk2qzaf5W6HIVIyXE+F2S93iu5svZhRE+uxKVdrUf6LQO7F7n73bQx8avJmQGCN/VQYQ883LCz+w/8Kt87lJLQkbQSQT71jDLOfL0URGaPe/l4mCDYY8Q3NPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6hKG2KqTnTud9V9LvgscRjsffi64dBQ91yNsXurffcE=;
 b=q89NzoNgAnH80CpqDag25EdaFXIWUmfe+DWOPj2WKi5TWLq6ioLFO9k3BelaTu+fl3nBMr5SpdeHfaAIX/IdEBlvh/c1Fbwta0CWh9vWtBqo7cirQ9I4PUb9MzhKkYlKEHes3K6xEkA+Uy9HwrOIkWUtjC4GqniUj4cSpO3QEjY=
Date: Fri, 21 Oct 2022 09:46:42 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] x86/xen: silence smatch warning in pmu_msr_chk_emulated()
Message-ID: <Y1JAUj2gPSQv6esQ@kadam>
References: <20221020113759.17402-1-jgross@suse.com>
 <47668d94-6b55-2894-fa6d-82b1f17312bf@suse.com>
 <26bae6db-0e17-2b54-4046-0e85b26f6401@suse.com>
 <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7fad3782-daf5-654c-f89d-e4dfb92bbf8f@oracle.com>
X-ClientProxiedBy: JNAP275CA0003.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4c::8)
 To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2365:EE_|DS7PR10MB4973:EE_
X-MS-Office365-Filtering-Correlation-Id: f3e022d3-d041-4a79-96bc-08dab3300a41
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	8hcWECTk8psI8+Zy8H6My4nbI+ZcX5tZvA39s2t9I5cqG0cKflul1t8cMTPr6cSmEKIxGf65t18BGZ0Y0mYnqt7UPwqGRAxAUNaq+8COoXzb2a7UdqhZu9qq2wILHLTMSd1gPA522I2Y+hCpXnW/Xq3T8kq1HqaOuhbmape9E3q9+zs78Tjg6srImgu2VeGRiBfLt76aTpxFVaojK5eGpUupZXSafnrpUtiM+a91JGB6UJXtyw/u5dpxfDsK1eDU2Z2ygAaY/dXoAu5jn0R0d8i263fGSZw2SdTu0HqS5B6eFh8CeJTxYozZ8PkKKhFewNycul5LqohlKUGeEfcOg1OzDm3qtKJ+uQLRrEVYdlF7rHW9Vkzq0GpAHaE1C7UMuwgOIMDggAPjjxrq4M8OSoESU5LLAc+kJfynPXzmfbxaqfc7548p4DFIj2C1U10LfyjHLuPPn5Xd6UKlfzlVp8ThNhxHQL6kfdvujQcSl9N3Z6GVrho3iwEoWa2Qg6YOo82bBWzeRl5lqla4iBrFawLL0n7UlBJqDkosyQ309cceMD/dgWpaS1Zm4J005a0rwb32SU63zmjEVCb901j7loGcKy9Jrqocw1c0orudMYyXvy7VHQ0YjJdIw004n/axhny3Sxdq9rMo980A4qvSEd6FJ9ZAYZjhCaT78BizmPBs82QZZ/ChgzuI3+8/7A1I
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(6506007)(478600001)(4326008)(41300700001)(6666004)(66556008)(5660300002)(66946007)(316002)(66476007)(44832011)(8676002)(2906002)(6486002)(26005)(6512007)(9686003)(53546011)(186003)(38100700002)(83380400001)(86362001)(6862004)(8936002)(7416002)(33716001)(54906003)(6636002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Xpl6xn2GPW6jug3GTFR8hGCfEN6q0ROVuEWEn6hzkllxmfIzerHA25cVj0Bg?=
 =?us-ascii?Q?VjH/vDjXIZQs66uystJgbX2vxpxef0+V/4ykSKwHQyVQ8Gx1pzASIHWo0UlJ?=
 =?us-ascii?Q?1lp+cSjDXWvv5Xm0VZZLQG/GUy1YxyRVbYAiRs6ggoMtKY5NA2L33xyBkpaZ?=
 =?us-ascii?Q?r41A2SBJQxZ4d9QAk4KqFwBQjt6WfejkS6SFA7cBc1jZbHdzZh/JpI+RcjI2?=
 =?us-ascii?Q?UOqRMIWcfUY1H9Rts7RkRLKXjlPofUBGqbliL5cXSAeJrAXK+XpiTq3jfjsi?=
 =?us-ascii?Q?EmdvdI2GjMnnUpLRNZBdZqJwb+5D2ZpGBnTfFLCqewvdcb+DkkXBNQ8zrJso?=
 =?us-ascii?Q?2zfm44Jo05WQQmICeqOlWzLd4x9jP2aUCt3UtQvx1KXX8mE/zyzUrI+sWxDw?=
 =?us-ascii?Q?3JjFy+OtInNmmjMrvyzgw5ZEqUiyk6xAnGoe51dADGxBjMMFLftul4SgYYKi?=
 =?us-ascii?Q?myh8TtyW8/zhSBGgehLDprlm2raDbK+7rq0wJtF8dDFLTkgYjXUa5dq/vVuM?=
 =?us-ascii?Q?NdE4heEH3iJfVxrJSpAsU3OYIkfUmWnGX4MLBAnorJHRz46B5Rgd1ze+6/f4?=
 =?us-ascii?Q?vL4Ux+gDUiG3uejrjZGN3UgaMuKQ1rRVr96L8zBtMmvH/k/3Pe0utj6vp2mA?=
 =?us-ascii?Q?ABYSsfffq/vkw4RU3e4Q0UPeoIcOovrp4XMTlGZ6oMGq+d8WvS7pUOn/B6Vl?=
 =?us-ascii?Q?DXwJY0DHI9vwIC7X2mneOnqJyPTKVKNt1VazOA22Dl8rCgzmj+H/uUBCiYKd?=
 =?us-ascii?Q?ZDCtdiQOB6sS8iklQHpwCdzSuxq0J1A+MpChimuukzsJWbzMFazxAea3yd17?=
 =?us-ascii?Q?+qG+Tc1VGcmjShImjyoI0yHFnvNE62KM10XKeCgMd53/yT1O06Z3b/QsQ5cT?=
 =?us-ascii?Q?Zr2M5jdglYLLU2xT2xnjWYtT/IQYTicag4i6yKLEtQ0xMpVyNe3NDbLdyNUS?=
 =?us-ascii?Q?X+ZtdhuujmKSVypV3rBbbqejuIBseYWOzt20GGFTxLX4bgE2u6rVzJQLuPvs?=
 =?us-ascii?Q?HTnfDbV7KqioLqGnyz8Ph+E6qmb3W7sgVKjZOMjNWnz7854ANr5vvc4/dcvq?=
 =?us-ascii?Q?7do3W+Rl1I/u7FszKJWnY/XXiA+B1IiN24sdXPnMzSENON2xYsIeiywEeFkA?=
 =?us-ascii?Q?R6WinN+OH1ZvBPCzhYnVrcXYUUOXGZ+McAs6UowFFdH+L5GNwyHU73Pq0fFK?=
 =?us-ascii?Q?QS/LWZ55j41on8ig1I6P2spC5GQxSrSif7JyQWRaSlvk/R5SUeeCSRpHA8xK?=
 =?us-ascii?Q?51T7AisWZfc7JSMMo9pVFOU0NEUYjcOvPr0kQ4nvgx6U1bL63dRgBTxxsBhV?=
 =?us-ascii?Q?0pdIEACHQoR3UoHprFOjZl6PNzSO22y57omxv75pnaoNu04Tck47PO7LpFEr?=
 =?us-ascii?Q?5SVDefW95yUSzI/bmPt8InvEgFxB75Hg1XcRo5FX0cuRifULJEanHlUPgfxs?=
 =?us-ascii?Q?vXvCc1GWM7WHsEt0Z7FTNljlGcHbq5jC9bGSqP/1MCfd4IFHJSjChyd4vJ4b?=
 =?us-ascii?Q?HBBWBz+DuyCWU2Z5YldbnlizY6ATONFwlaGVXNsvD1SOlOo2mpaZrfLWNaLs?=
 =?us-ascii?Q?pFTFqnTfXCnW6vCt6I8Gs6qzK6tipNaulIUXF039jBY3MMBJ4OszuwA/FArd?=
 =?us-ascii?Q?PA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3e022d3-d041-4a79-96bc-08dab3300a41
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 06:46:54.4937
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EJva7RV6icfEVWOYyv6o+5SkosDAYgaiOlv5mEEoyuh6vJ5shPU+mrvLaKLQVoPDr5wzZlMpgxuHyDLMiPW6pJJt4fiPNNihA25IX7JW43Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4973
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_01,2022-10-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210210039
X-Proofpoint-ORIG-GUID: lWUr-6OeCEpUV5LmE2Sj5fp7xhUYx1ev
X-Proofpoint-GUID: lWUr-6OeCEpUV5LmE2Sj5fp7xhUYx1ev

On Thu, Oct 20, 2022 at 10:22:17AM -0400, Boris Ostrovsky wrote:
> 
> On 10/20/22 9:34 AM, Juergen Gross wrote:
> > On 20.10.22 15:16, Jan Beulich wrote:
> > > On 20.10.2022 13:37, Juergen Gross wrote:
> > > > Commit 8714f7bcd3c2 ("xen/pv: add fault recovery control to pmu msr
> > > > accesses") introduced code resulting in a warning issued by the smatch
> > > > static checker, claiming to use an uninitialized variable.
> > > > 
> > > > This is a false positive, but work around the warning nevertheless.
> > > 
> > > The risk of introducing a problem might be quite low here, but in general
> > > it exists: With the adjustment you remove any chance of the compiler
> > > spotting a missing initialization before use. And I'm not convinced using
> > > 0 in such a case would actually be ending up sufficiently benign.
> > 
> > Hmm, an alternative would be to initialize it to -1 and add a test for the
> > index to be >= 0 before using it.
> > 
> > Or to live with the smash warning with the chance, that a compiler might be
> > warning for the same reason in the future.
> 
> 
> Is smatch complaining about both variables or just index?

Just "index".

> There are two cases in is_intel_pmu_msr() where it returns true but
> index is not set so perhaps that's what bothers smatch?

Yep.  The "index" variable *is* undefined when it's passed so Smatch
is correct in what it's saying.  But it's is not used on that path
inside the function so it's harmless.

> It shold not complain if is_intel_pmu_msr() returns false.

Correct.

I kind of like the patch.  We generally say "fix the checker and don't
silence the warning" but in this case I feel like the checker is doing
the best possible thing and I'm not going to fix it.  Trying to silence
this warning in Smatch would come with some real downsides.

regards,
dan carpenter



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:50:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:50:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427360.676320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollrU-0007sK-6v; Fri, 21 Oct 2022 06:50:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427360.676320; Fri, 21 Oct 2022 06:50:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollrU-0007sD-3a; Fri, 21 Oct 2022 06:50:32 +0000
Received: by outflank-mailman (input) for mailman id 427360;
 Fri, 21 Oct 2022 06:50:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yPHp=2W=redhat.com=jasowang@srs-se1.protection.inumbo.net>)
 id 1ollrS-0007s6-Np
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:50:30 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a40f50df-510c-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 08:50:26 +0200 (CEST)
Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com
 [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-653-JvB9qQ5uO7-pKpIUC1SLhw-1; Fri, 21 Oct 2022 02:50:21 -0400
Received: by mail-oa1-f70.google.com with SMTP id
 586e51a60fabf-13305999f45so1249229fac.18
 for <xen-devel@lists.xenproject.org>; Thu, 20 Oct 2022 23:50:21 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a40f50df-510c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666335025;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XOzz6RqxEFeDgZOvB1fTWZ3fuSCGIDuMSc6tKtrk8+s=;
	b=YVu21WPyAEtms3VE7lk+X7rgL13OEY+xcmmTG3AHIT4DNMeuRqWOKtJD/VrXGgxKxqBXwz
	4NhWVTMVqaVmznx9x100fyv+conFESz1FWDeAnPtPTzaJW1BhHFNiE5Xap5P7Z7k68cn+l
	DHqyjuLlDouiwQZLGkqh6uJdEttry2Y=
X-MC-Unique: JvB9qQ5uO7-pKpIUC1SLhw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=XOzz6RqxEFeDgZOvB1fTWZ3fuSCGIDuMSc6tKtrk8+s=;
        b=ewgL0LZl6CdpfxnABRk4cUBr5N+nOSICOZpB7JPx22hzqAVN8yBqWKvC1OIqmgVs1r
         oaRL9VcyB3M8wmqvVhdWkvxT/ufvVmFv4CB5y9YXxl/ztWvZTfRlou2HlnMqtqZEj9up
         lj//myniSYTJFkWC1MEnzYxnvErw6sJ+Rm0xQAA5c3ESOOpR4sklaBeMqBzvZ3y85zon
         sUKg4VUNT6fOSsU7sHDBOFSISVTQZkxH/18AEUK0t0O+9NZUXu4IT3Nfjl0zSZno9dcr
         TY8lSwB3xvEcm3vGrbwvA0+AJGVVyJKImcdAjpGlrX18TwmcV3ZeYMDenFgaF8NdVRWL
         S6lA==
X-Gm-Message-State: ACrzQf1b2T/zUK6DgOSjr7NGftRngTkGw8daQ7y54ieB2U2XfRCV0AIM
	gneNgydNBNC6z/j/rs9Lw89/a8x0JpYnMd1DXbtHAFonM4lDLvq+1mdLG0VMtpZlgx5m8p47bnc
	NwL9fmncf2s0mPBFDjCdUykPH1JXMN28fm3zP9URiyTc=
X-Received: by 2002:a05:6808:1985:b0:354:d7cf:9acb with SMTP id bj5-20020a056808198500b00354d7cf9acbmr9563868oib.280.1666335021210;
        Thu, 20 Oct 2022 23:50:21 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4MsrSkczxgyL5VrPWYzqqA1GHmIu6vGijSgB1rVxOImIbAyk3VP+uSlEbR8x7X/fkgKZMWn8pgX5+JVE+IwmU=
X-Received: by 2002:a05:6808:1985:b0:354:d7cf:9acb with SMTP id
 bj5-20020a056808198500b00354d7cf9acbmr9563848oib.280.1666335020995; Thu, 20
 Oct 2022 23:50:20 -0700 (PDT)
MIME-Version: 1.0
References: <20221020162558.123284-1-lvivier@redhat.com> <CACGkMEt9Hoo=GAuCUqMcBjqNvs94fEPA_GU9Z7TOh8c7Wam55Q@mail.gmail.com>
 <87h6zx4qsk.fsf@pond.sub.org>
In-Reply-To: <87h6zx4qsk.fsf@pond.sub.org>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 21 Oct 2022 14:50:09 +0800
Message-ID: <CACGkMEsnq2pFaLwBpzpCSiD8jZrx77SUTn_6JhGG9jKe1PJkwA@mail.gmail.com>
Subject: Re: [PATCH v13 00/17] qapi: net: add unix socket type support to
 netdev backend
To: Markus Armbruster <armbru@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org, Paul Durrant <paul@xen.org>, 
	Thomas Huth <thuth@redhat.com>, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, 
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>, Greg Kurz <groug@kaod.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, David Gibson <david@gibson.dropbear.id.au>, 
	Eric Blake <eblake@redhat.com>, xen-devel@lists.xenproject.org, 
	"Michael S. Tsirkin" <mst@redhat.com>, Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>, 
	Samuel Thibault <samuel.thibault@ens-lyon.org>, Anthony Perard <anthony.perard@citrix.com>, 
	Ralph Schmieder <ralph.schmieder@gmail.com>, Stefano Brivio <sbrivio@redhat.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 21, 2022 at 2:46 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> Jason Wang <jasowang@redhat.com> writes:
>
> > I've queued this version and will send pull requests shortly.
> >
> > Any future comment we can do patches on top.
>
> Please give Laurent and me a few hours to try to improve PATCH 17's
> commit message.  Which you could then integrate without a respin.

Ok.

Thanks

>



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 06:58:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 06:58:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427367.676337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollyt-0000G9-1Z; Fri, 21 Oct 2022 06:58:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427367.676337; Fri, 21 Oct 2022 06:58:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ollys-0000G2-Ud; Fri, 21 Oct 2022 06:58:10 +0000
Received: by outflank-mailman (input) for mailman id 427367;
 Fri, 21 Oct 2022 06:58:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ollyr-0000Fw-WD
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 06:58:10 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b839c6be-510d-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 08:58:08 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4EA532198A;
 Fri, 21 Oct 2022 06:58:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC0651331A;
 Fri, 21 Oct 2022 06:58:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 024iOP9CUmOBIgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 06:58:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b839c6be-510d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666335488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=CqRLRdqWLjqI6TmcVqgWhEybkthICIUip1XaP6CyOv0=;
	b=tzfNNmM3GDb1pkUb5Ysqqt+MqZFrNHVZL622NJJ7YAYJ5NH94dQ9PVhgKTQWbqYe2l4pfu
	PbTh82Gl2CLjOnOskMjQ56NhFtnkU3W4b3uzfKBlIqmcqmnlKiyW4kUKBjfjTBUuIbQWXM
	Rp6N5eJ2V9YCGhNCuGYMXCm2xhZ/518=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>,
	Henry Wang <Henry.Wang@arm.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by removing it
Date: Fri, 21 Oct 2022 08:58:06 +0200
Message-Id: <20221021065806.14316-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When the system is coming up after having been suspended,
restore_vcpu_affinity() is called for each domain in order to adjust
the vcpu's affinity settings in case a cpu didn't come to live again.

The way restore_vcpu_affinity() is doing that is wrong, because the
specific scheduler isn't being informed about a possible migration of
the vcpu to another cpu. Additionally the migration is often even
happening if all cpus are running again, as it is done without check
whether it is really needed.

As cpupool management is already calling cpu_disable_scheduler() for
cpus not having come up again, and cpu_disable_scheduler() is taking
care of eventually needed vcpu migration in the proper way, there is
simply no need for restore_vcpu_affinity().

So just remove restore_vcpu_affinity() completely.

Fixes: 8a5d50dd0b04 ("xen: sched: simplify ACPI S3 resume path.")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/x86/acpi/power.c |  3 --
 xen/common/sched/core.c   | 70 ---------------------------------------
 xen/include/xen/sched.h   |  1 -
 3 files changed, 74 deletions(-)

diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index 1bb4d78392..b76f673acb 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -159,10 +159,7 @@ static void thaw_domains(void)
 
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
-    {
-        restore_vcpu_affinity(d);
         domain_unpause(d);
-    }
     rcu_read_unlock(&domlist_read_lock);
 }
 
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 83455fbde1..358fa077e3 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1196,76 +1196,6 @@ static void sched_reset_affinity_broken(const struct sched_unit *unit)
         v->affinity_broken = false;
 }
 
-void restore_vcpu_affinity(struct domain *d)
-{
-    unsigned int cpu = smp_processor_id();
-    struct sched_unit *unit;
-
-    ASSERT(system_state == SYS_STATE_resume);
-
-    rcu_read_lock(&sched_res_rculock);
-
-    for_each_sched_unit ( d, unit )
-    {
-        spinlock_t *lock;
-        unsigned int old_cpu = sched_unit_master(unit);
-        struct sched_resource *res;
-
-        ASSERT(!unit_runnable(unit));
-
-        /*
-         * Re-assign the initial processor as after resume we have no
-         * guarantee the old processor has come back to life again.
-         *
-         * Therefore, here, before actually unpausing the domains, we should
-         * set v->processor of each of their vCPUs to something that will
-         * make sense for the scheduler of the cpupool in which they are in.
-         */
-        lock = unit_schedule_lock_irq(unit);
-
-        cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
-                    cpupool_domain_master_cpumask(d));
-        if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
-        {
-            if ( sched_check_affinity_broken(unit) )
-            {
-                sched_set_affinity(unit, unit->cpu_hard_affinity_saved, NULL);
-                sched_reset_affinity_broken(unit);
-                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
-                            cpupool_domain_master_cpumask(d));
-            }
-
-            if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
-            {
-                /* Affinity settings of one vcpu are for the complete unit. */
-                printk(XENLOG_DEBUG "Breaking affinity for %pv\n",
-                       unit->vcpu_list);
-                sched_set_affinity(unit, &cpumask_all, NULL);
-                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
-                            cpupool_domain_master_cpumask(d));
-            }
-        }
-
-        res = get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)));
-        sched_set_res(unit, res);
-
-        spin_unlock_irq(lock);
-
-        /* v->processor might have changed, so reacquire the lock. */
-        lock = unit_schedule_lock_irq(unit);
-        res = sched_pick_resource(unit_scheduler(unit), unit);
-        sched_set_res(unit, res);
-        spin_unlock_irq(lock);
-
-        if ( old_cpu != sched_unit_master(unit) )
-            sched_move_irqs(unit);
-    }
-
-    rcu_read_unlock(&sched_res_rculock);
-
-    domain_update_node_affinity(d);
-}
-
 /*
  * This function is used by cpu_hotplug code via cpu notifier chain
  * and from cpupools to switch schedulers on a cpu.
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 557b3229f6..072e4846aa 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1019,7 +1019,6 @@ void vcpu_set_periodic_timer(struct vcpu *v, s_time_t value);
 void sched_setup_dom0_vcpus(struct domain *d);
 int vcpu_temporary_affinity(struct vcpu *v, unsigned int cpu, uint8_t reason);
 int vcpu_set_hard_affinity(struct vcpu *v, const cpumask_t *affinity);
-void restore_vcpu_affinity(struct domain *d);
 int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
                          struct xen_domctl_vcpuaffinity *vcpuaff);
 
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 07:06:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 07:06:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427372.676348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olm6e-0001qN-Rw; Fri, 21 Oct 2022 07:06:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427372.676348; Fri, 21 Oct 2022 07:06:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olm6e-0001qG-Oa; Fri, 21 Oct 2022 07:06:12 +0000
Received: by outflank-mailman (input) for mailman id 427372;
 Fri, 21 Oct 2022 07:06:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olm6c-0001qA-HG
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 07:06:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d59a659b-510e-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 09:06:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 354041F74D;
 Fri, 21 Oct 2022 07:06:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D7FA413A0E;
 Fri, 21 Oct 2022 07:06:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id hJs2M95EUmOKJgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 07:06:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d59a659b-510e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666335967; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vdcj9F9eh61DDb4NOAa7NQ6U9MiEGwzNy6Cji5VCinI=;
	b=T0nH5MkvwcXNMynb0Hv9RU93HzP5sENRaWmKcMZ/0DNdfI2bPR4elPTb2rSwGUuXImn1m+
	8schTLfcIYL3aXHSguwslAu/TaIE2vlR6udlovEzHdAy4KS0h8FRUip+B5OOupdSdcb+V5
	D6i+a77k+3HyIxRn2j0MfoHmygnKZfI=
Message-ID: <6ac5b62c-1679-b55b-e3aa-00ac395ce89c@suse.com>
Date: Fri, 21 Oct 2022 09:06:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Content-Language: en-US
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>, Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
References: <20221021065806.14316-1-jgross@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <20221021065806.14316-1-jgross@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------V0Lgz7AxECG2WEjAShDry3mi"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------V0Lgz7AxECG2WEjAShDry3mi
Content-Type: multipart/mixed; boundary="------------ZpkzQmT2h3MuH7n9jntZmdwg";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>, Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= <marmarek@invisiblethingslab.com>
Message-ID: <6ac5b62c-1679-b55b-e3aa-00ac395ce89c@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
References: <20221021065806.14316-1-jgross@suse.com>
In-Reply-To: <20221021065806.14316-1-jgross@suse.com>

--------------ZpkzQmT2h3MuH7n9jntZmdwg
Content-Type: multipart/mixed; boundary="------------6xoUVHxulvbL46hNCfxLgJvX"

--------------6xoUVHxulvbL46hNCfxLgJvX
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMTAuMjIgMDg6NTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IFdoZW4gdGhlIHN5
c3RlbSBpcyBjb21pbmcgdXAgYWZ0ZXIgaGF2aW5nIGJlZW4gc3VzcGVuZGVkLA0KPiByZXN0
b3JlX3ZjcHVfYWZmaW5pdHkoKSBpcyBjYWxsZWQgZm9yIGVhY2ggZG9tYWluIGluIG9yZGVy
IHRvIGFkanVzdA0KPiB0aGUgdmNwdSdzIGFmZmluaXR5IHNldHRpbmdzIGluIGNhc2UgYSBj
cHUgZGlkbid0IGNvbWUgdG8gbGl2ZSBhZ2Fpbi4NCj4gDQo+IFRoZSB3YXkgcmVzdG9yZV92
Y3B1X2FmZmluaXR5KCkgaXMgZG9pbmcgdGhhdCBpcyB3cm9uZywgYmVjYXVzZSB0aGUNCj4g
c3BlY2lmaWMgc2NoZWR1bGVyIGlzbid0IGJlaW5nIGluZm9ybWVkIGFib3V0IGEgcG9zc2li
bGUgbWlncmF0aW9uIG9mDQo+IHRoZSB2Y3B1IHRvIGFub3RoZXIgY3B1LiBBZGRpdGlvbmFs
bHkgdGhlIG1pZ3JhdGlvbiBpcyBvZnRlbiBldmVuDQo+IGhhcHBlbmluZyBpZiBhbGwgY3B1
cyBhcmUgcnVubmluZyBhZ2FpbiwgYXMgaXQgaXMgZG9uZSB3aXRob3V0IGNoZWNrDQo+IHdo
ZXRoZXIgaXQgaXMgcmVhbGx5IG5lZWRlZC4NCj4gDQo+IEFzIGNwdXBvb2wgbWFuYWdlbWVu
dCBpcyBhbHJlYWR5IGNhbGxpbmcgY3B1X2Rpc2FibGVfc2NoZWR1bGVyKCkgZm9yDQo+IGNw
dXMgbm90IGhhdmluZyBjb21lIHVwIGFnYWluLCBhbmQgY3B1X2Rpc2FibGVfc2NoZWR1bGVy
KCkgaXMgdGFraW5nDQo+IGNhcmUgb2YgZXZlbnR1YWxseSBuZWVkZWQgdmNwdSBtaWdyYXRp
b24gaW4gdGhlIHByb3BlciB3YXksIHRoZXJlIGlzDQo+IHNpbXBseSBubyBuZWVkIGZvciBy
ZXN0b3JlX3ZjcHVfYWZmaW5pdHkoKS4NCj4gDQo+IFNvIGp1c3QgcmVtb3ZlIHJlc3RvcmVf
dmNwdV9hZmZpbml0eSgpIGNvbXBsZXRlbHkuDQo+IA0KPiBGaXhlczogOGE1ZDUwZGQwYjA0
ICgieGVuOiBzY2hlZDogc2ltcGxpZnkgQUNQSSBTMyByZXN1bWUgcGF0aC4iKQ0KDQpUaGlz
IEZpeGVzOiB0YWcgaXMgd3JvbmcuIEl0IHNob3VsZCBiZToNCg0KRml4ZXM6IDhhMDRlYWE4
ZWE4MyAoInhlbi9zY2hlZDogbW92ZSBzb21lIHBlci12Y3B1IGl0ZW1zIHRvIHN0cnVjdCBz
Y2hlZF91bml0IikNCg0KDQpKdWVyZ2VuDQo=
--------------6xoUVHxulvbL46hNCfxLgJvX
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6xoUVHxulvbL46hNCfxLgJvX--

--------------ZpkzQmT2h3MuH7n9jntZmdwg--

--------------V0Lgz7AxECG2WEjAShDry3mi
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNSRN4FAwAAAAAACgkQsN6d1ii/Ey/H
7Af+IrAtBUD8GyzT48WlLphugwuW2g64puj7inFbMKfCH3GmoL7iL0I6b6bsrsMnkQrUODzwJz3R
g5J78hb8ZuEwTpg1IX7djqkg4dSoq2cU1OBemQsueE7qjLYbLFdmHvA18GoxYR+22PQhG3M/diFR
YxAOUMvh/s7Xw4E7ppaUuAK1G0c+NxRMxlTEvlFNHZNgxJVoFKftwWHhey9n5OwsJKJuL3jVHMSl
Hf5KIxG83atRQxMd24A8z39QDn4uJYvbMKr+/hi17/B/Ms+3wIcxO2Ugdn68Cmo1XNUWH6Ti631J
5VCMrv6mlWen2IdLG9Lq0Ml2aulY5C0WK+zf7j770g==
=2vhO
-----END PGP SIGNATURE-----

--------------V0Lgz7AxECG2WEjAShDry3mi--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 07:48:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 07:48:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427383.676377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmlj-0006QF-7D; Fri, 21 Oct 2022 07:48:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427383.676377; Fri, 21 Oct 2022 07:48:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmlj-0006Q8-3i; Fri, 21 Oct 2022 07:48:39 +0000
Received: by outflank-mailman (input) for mailman id 427383;
 Fri, 21 Oct 2022 07:48:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=chjt=2W=citrix.com=prvs=286a1e6c2=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1olmlh-0006Q2-P2
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 07:48:37 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c3a3e6ba-5114-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 09:48:35 +0200 (CEST)
Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 03:48:27 -0400
Received: from BL0PR03MB4161.namprd03.prod.outlook.com (2603:10b6:208:6e::27)
 by SJ0PR03MB6599.namprd03.prod.outlook.com (2603:10b6:a03:388::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 07:48:22 +0000
Received: from BL0PR03MB4161.namprd03.prod.outlook.com
 ([fe80::f917:c565:10a9:e14c]) by BL0PR03MB4161.namprd03.prod.outlook.com
 ([fe80::f917:c565:10a9:e14c%7]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 07:48:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3a3e6ba-5114-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666338515;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=AHS34pg5GW2Zd+8WAOXQURwcDmuIJ1v3T14Y91kF8xY=;
  b=Of0q4AG18AU3EFL+sz35VZb02lXW6fKRwY6d2c/udgxJrNJ0yS+aFda0
   JS9AuMfgta2v7YjPlgpqxmEYxh3QkLEN0IXerSrRxTgvh35wMJoEYZFth
   3A6jMljATOY9lHaTDCVyud0kYboCG7IOrDzVd+LsQ8TRFPRd1W7TiUXuN
   0=;
X-IronPort-RemoteIP: 104.47.59.170
X-IronPort-MID: 82848223
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:DGk85aPnzeW5ygbvrR2LlsFynXyQoLVcMsEvi/4bfWQNrUpz1WMEz
 WNNC26OMvncM2rzft9xPdzipxkCvcXXm4VqTgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo4WtB1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eHcobp8BvEFh13
 9sJczcJUC2pu+Dsz+fuIgVsrpxLwMjDGqo64ysl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF+RTM+vJfD2v7lWSd1JDmMMDUYcCLTMMTmkeeq
 mPJ12/4HgsbJJqUzj/tHneE1rWfwXOhAtl6+LuQzcx7qUC9mUsvIUc5c0H4/MmT0VasVIcKQ
 6AT0m90xUQoz2SLQ9/nTluHqXiLlhcGXpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2
 1SV2dTzClRHvLSLRFqH+7yTrDf0PjIaRVLufgcBRAoBptXm/oc6i0uVSs45SfHtyNroBTv33
 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CChRqcBO51lmW8g
 UU=
IronPort-HdrOrdr: A9a23:zhkNGazGnEbYEbcdVyKTKrPxmuskLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk80hqQFm7X5XI3SFjUO3VHFEGgM1/qE/9SNIUzDH6tmpN
 9dmstFeZDN5DpB/KDHCWCDer5OruVvsprY/Ns2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL
 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63
 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR
 /30lMd1opImjTslyqO0GbQMkHboUoTAjnZuBOlaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya
 pOm3mUrpxNEHr77W3AD0ihbWAUqqOYmwtUrQcotQ0obaIOLLtK6YAP9kJcF5kNWCr89YA8Ce
 FrSMXR/uxff1+WZ23Q+jAH+q3mYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/
 nNdq5oiLZNRMkLar8VPpZIfeKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4uKfaWK
 6xJW+wmVRCCH4GU/f+raGj2iq9MFmVTHDq1txU4YR/t/n1WKfrWBfzOmwTrw==
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208,217";a="82848223"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m0K+smPd5irxxcseW+vIstcwcbR4fzdv1M5fr97DM08OckgN/+B1ZCPi5bVbPKcKM0gidlU3lUm3BFAMaN5zQLmTps+bxjsX30WU9OTxfgoy/EH/LYve+QnE/eXWupeU/SPBzLj/SzKOpmGyLOL0zwwJAYm3d/Of1VhXFSQGTXXQO7P9aDo/ZQuFcuc5LGF9xdfzjkAIPIt19mTD5Lhvtcy4eIX9nrkIMV/ah2tg+Kc/sg3m4THTfMnaIu8/ZgvaI92Fmz3qRaQqPeIUK9ddsvL18Jwsj6FmOb+A+7aP7ECyFRSQpUhEIr/2gxSVeNpmOP648bwPHC3LDzeyOqo8xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AHS34pg5GW2Zd+8WAOXQURwcDmuIJ1v3T14Y91kF8xY=;
 b=aiDDWRQ1LYLM+x81fhtZJEaLpLnhL5BFZOzbI0tIoJJk4b9t83nrcgPRwMoaqw3UG5YIGNtMCf+IcbOWJ9FLVt6EYP1JovA1uZkr76BDnhpKFmeR3z4inx5UYhCVZbVdeYx+T3pq5Smocmnwj0V0pKnxauGe8UdDXRNQdghjKx8ptUqw7v5xzXZQvh3llGddnyqVNmkm6P5YJ8Tcb8A/acImUr5RtLCenKaftcJRNW3qhUeJrEVGHH4T9H6fjKdIuyz0mMFGO/+MakvSeoKTun/3FGsbl2IauM2fVOB9gTr0shQIO0uCBVFzXYTxPDb9tyjAwJdObnYz8tWwkmqFqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AHS34pg5GW2Zd+8WAOXQURwcDmuIJ1v3T14Y91kF8xY=;
 b=nITmGXOYfPxVdXvoF6wDa5w+SfVNJPBdic/AekZwpNVKd07GPPmm//Y/YmSTs+Z11LzLU6ub4rfbDfQWb4X6ztPl9dLozHVXYmBbjcvS2I1hmL5I5RehAWkADRuN1Ag/kR4tfbXsFkogIzY1H/2IVvIpYrZNZalsf+eMh0d6Kws=
From: Christian Lindig <christian.lindig@citrix.com>
To: Edwin Torok <edvin.torok@citrix.com>
CC: Henry Wang <Henry.Wang@arm.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>,
	David Scott <dave@recoil.org>, Rob Hoes <Rob.Hoes@citrix.com>
Subject: Re: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Topic: [PATCH for-4.17] tools/oxenstored: Fix Oxenstored Live Update
Thread-Index: AQHY5HiAcD24hk9GgUi1cSkdE1Fmrq4XOrgAgABGQYCAAPkRgA==
Date: Fri, 21 Oct 2022 07:48:21 +0000
Message-ID: <C4ADF58A-9B82-45BE-9FD3-E9AD55557EE7@citrix.com>
References: <20221020113810.20844-1-andrew.cooper3@citrix.com>
 <AS8PR08MB79914FC06AE997ABF32780E4922A9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <F65C8E58-EF3D-47D9-A94E-7B70EB93E068@citrix.com>
In-Reply-To: <F65C8E58-EF3D-47D9-A94E-7B70EB93E068@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BL0PR03MB4161:EE_|SJ0PR03MB6599:EE_
x-ms-office365-filtering-correlation-id: 1fc45ec3-9b1f-4995-f77b-08dab338a06c
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 63pZKuZB3BXd+RI5VS8MIHBvidMLKNP4C7TsXHUJLcxSeEIf1yUSLwL1/qkJpaHXstpgnSrKDu6RcU5bQliozkA3ya6eA3Oo4Kqt3jypg1usNG/90dNVqOOPyalTSu5PzXhwmtqybhh8/oBMlSJL0sO9/0xcC88JwRshn2udrukAeFTg+qXYaWAmhHzmrRM/O6O6Q3eeIj+jq93pjHlU7TDRsvW/WMSwPXRJkMG5Oa3162ZHK9P3m2iq0bzN9qHa1EGBM/i+kfTlZ7lBlYca33pQtsLMqB8oTUcnjzyufIP3/zu81kD2x0mmCJlMbxwZlGO8DvZQgnIBmalcFCwjNVACnmo/mGoWqu6Fd45h6/+vEkB/grF3+bgI3vF+FDJQMLs7+s5R7Zz6gClJkQZd3OhCMe5f5j+8XR5gPfNtRDc1pHgtTQ32/ZUdqFOLXUqLi8Z8TUYSGTIPmORLccTuFHFXfJMdfWfLQ7xzoYnFMOuI8t9cJVLJ3h5sm0yTQr1pVdd0odnGbVhD/YLQm4NLYdr2yLs1kB+YD/JlRrmKxXDOMFszscuVS92YTpfyn5ijgnfT88S+Viu33HK9kwfVNHFpe7TFkxk/AYAst7+8/OZeRaiAbkhCze8lkF8i5MbIaNbfhZjtu0ApEJcRQ+GrBBEP1gA6AB2CBC+yl5BWLJvajtj9Vm05OfyNbumoIudETZKOZn/JqYpv71Fv6m3vyynl1L6ZYXoYeghapN2hF+pUKo51HLAXYdUdXkPfNQbrXaoOiJIQwSMGANOpY/Gp/7QiuO2S2jWnJOW8r7cgOPqI+8dj6qz+tOIYYktT1uWqBv1QUMccTaitWpHyZ+RXaZkYjIFsxfdJsitPr/B3U7I=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR03MB4161.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199015)(41300700001)(122000001)(6486002)(966005)(38070700005)(38100700002)(478600001)(166002)(82960400001)(71200400001)(8936002)(6512007)(6862004)(76116006)(86362001)(37006003)(66946007)(54906003)(6636002)(83380400001)(36756003)(4744005)(91956017)(107886003)(66556008)(66476007)(66446008)(64756008)(316002)(6506007)(8676002)(53546011)(2906002)(15650500001)(2616005)(4326008)(26005)(186003)(5660300002)(44832011)(33656002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?5AiTsQedUzZxXL6QyiM0S8VWLbpmrt8m+koTUK9QRkDUPgXch6RgtkMi/IjM?=
 =?us-ascii?Q?paf6eLkYBWE/rxA8LR345FSEY7RF3WM/4DrcC4AbWDzhOk4eeSdnMkrQRMzN?=
 =?us-ascii?Q?w7HYHjRc17JtgVTvMphrbYO0uuBdoTCRlxi4MysgMItDdJT5saKlg8RGBuNq?=
 =?us-ascii?Q?xjmax5KgVhge+354i9cVL9VIDZaDUoJiFy+x4BDfuntCigqJPj++Z0iR7aCt?=
 =?us-ascii?Q?2R9dl6bSJyZZ7gSk6ib78eFYViUR56YFZmL80TDNhyATMAAzrkblfTTV4o1U?=
 =?us-ascii?Q?BUKtW28hLNdoSLRvreXPKYLrUhZx0/M51JMcIyMZyjZlxHiioNGRLED2/8X+?=
 =?us-ascii?Q?/dnjUOCzFPCSf7EL5yOGmtvO3Jk77AuhTO9N5D1huZw5LQriPDSmvJxYP9xT?=
 =?us-ascii?Q?2ZQUU6v8OfINORcl0R6RJkVYdxCcXErIL1xSVenKP5N1oG/SG4c1inQhHFSL?=
 =?us-ascii?Q?z8vUMTRca9xo62wAj7NUUrxHHpcrXcVnbjYQVAM5ncK2S8K4Kz6WApKY2FoP?=
 =?us-ascii?Q?f62Rx3QpabRrGoVBBxgW23kOrKtuvqPI/V5AceBAzblJJ4jzq3F46xwBe3yl?=
 =?us-ascii?Q?Ye+MAoD6QwZ24nHDaUctW4IeRqGZef9QW9VbVx2xWp/Tfd5fnC7daIAO6rzd?=
 =?us-ascii?Q?PSyEr5KlXx1wZayjXwrH2IPhOO9SH0zzAK0ohMzO7sTmEVi90bfSiP/nnyNF?=
 =?us-ascii?Q?qL8Bi4QKdH4jptrnJ0LyLSj/ZD4GRqqmrO0Ka7QE0JqFkP1tX6K/+qq66M7H?=
 =?us-ascii?Q?kEFPmvRf5zGRkxP7W53Lm5MtUnVoqsNHHI8p7WlipmfekmMEfRtAAfVctGtZ?=
 =?us-ascii?Q?yrLrmjYLCUb+ZvhywxlrFpiw47nC6nI8wwmzT+JzUFP2NkbJcKwTmzYkQ1tj?=
 =?us-ascii?Q?eh9mx16tmMQQSxNdhQDPQpDwQ5gSVBJtUpCoWVJt6cHspuJ1pSYbq8eGiCcr?=
 =?us-ascii?Q?QbWyA+ybJQyfrHJ/HGtBVK3Mo7ZnRsMk1Vex4t/gikZRQ/V0pgV/Kf+30WMN?=
 =?us-ascii?Q?7ewRjZ3l3pOjfFK4I86OTRncP2L+XITSolkHzWAl4qxPagUBj3uVwEOJ+IWq?=
 =?us-ascii?Q?xWHWxTzZZ7HcfTv8TgtyOwvp18eoDeTVCCfVMlCkFF3BUpMJ9IhgHLMXtVUq?=
 =?us-ascii?Q?4qZgzfzv/hVzQRXgZLq67BZkmUYXPpfSASkZtykDz6hvR00jEn8CiJnjABbn?=
 =?us-ascii?Q?luyZ8Uc3T0GgiR9RpF8WrT5QM6if+FgSamgG3BRKXO0vDwETbgqmTIrk1b1/?=
 =?us-ascii?Q?yTTo4rzZInWv/F0i3jiMZknXmjDg1vMfZj9sTm7wheRb7t8UIIsIzNnSnuYo?=
 =?us-ascii?Q?hprgNszhuoSi0BgTOyUKHhQbewZhTdeLXtKPU8R2MOUSciLnbZAi+hHW2G+x?=
 =?us-ascii?Q?lqR7l+6SWIgF2VQTRldWTgggsT5ntxbSLOmwSX5znWf25C5d3PgxvSEqv2Ir?=
 =?us-ascii?Q?KFBgZY0lCzrc7t4TrpVXGBb5p5KCb3t8SwH3y0exVjI9pEVer+9jwjRPAw7Z?=
 =?us-ascii?Q?z9IGYdR0t+2zmdBSpLYbu1/d3Xtii10tgh0RVw4ETjJaWBrDVXNOpz964Dcb?=
 =?us-ascii?Q?ii+GlAL2N1IvREvUNK43uyprMwb7wVUNQeqWIV3iIunFWYZMjEkFk1aCzG5b?=
 =?us-ascii?Q?qXjHg9sbq6U6QPuqDAN49nM=3D?=
Content-Type: multipart/alternative;
	boundary="_000_C4ADF58A9B8245BE9FD3E9AD55557EE7citrixcom_"
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR03MB4161.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc45ec3-9b1f-4995-f77b-08dab338a06c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 07:48:21.7226
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CMJ7gegSJMI359yJzLMqoGI5VR5FDJbP/Pxhdlzpbt2vVy9QP6va1VTAayAegV9j1knuDKf2xBDfE+F0h7ccR3SDp7x2jGpqtag1BI676gQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6599

--_000_C4ADF58A9B8245BE9FD3E9AD55557EE7citrixcom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable



On 20 Oct 2022, at 17:56, Edwin Torok <edvin.torok@citrix.com<mailto:edvin.=
torok@citrix.com>> wrote:

Further testing has revealed another bug, patch here:
https://lore.kernel.org/xen-devel/12d90632bf881e96e0b6c256df193f00df187dc1.=
1666284745.git.edvin.torok@citrix.com/T/#u

For convenience the commit is also available from git:
https://github.com/edwintorok/xen/commit/12d90632bf881e96e0b6c256df193f00df=
187dc1

With both of these patches a smoketest 'xenstore-control live-update' with =
a stopped toolstack works now.

Acked-by: Christian Lindig <christian.lindig@citrix.com<mailto:christian.li=
ndig@citrix.com>>


--_000_C4ADF58A9B8245BE9FD3E9AD55557EE7citrixcom_
Content-Type: text/html; charset="us-ascii"
Content-ID: <93DC32BE136C734F874738A34B746DDC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
</head>
<body style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; line-break:=
 after-white-space;" class=3D"">
<br class=3D"">
<div><br class=3D"">
<blockquote type=3D"cite" class=3D"">
<div class=3D"">On 20 Oct 2022, at 17:56, Edwin Torok &lt;<a href=3D"mailto=
:edvin.torok@citrix.com" class=3D"">edvin.torok@citrix.com</a>&gt; wrote:</=
div>
<br class=3D"Apple-interchange-newline">
<div class=3D""><span style=3D"caret-color: rgb(0, 0, 0); font-family: Menl=
o-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; =
font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0=
px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-t=
ext-stroke-width: 0px; text-decoration: none; float: none; display: inline =
!important;" class=3D"">Further
 testing has revealed another bug, patch here:</span><br style=3D"caret-col=
or: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal=
; text-align: start; text-indent: 0px; text-transform: none; white-space: n=
ormal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
none;" class=3D"">
<a href=3D"https://lore.kernel.org/xen-devel/12d90632bf881e96e0b6c256df193f=
00df187dc1.1666284745.git.edvin.torok@citrix.com/T/#u" style=3D"font-family=
: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: no=
rmal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: =
start; text-indent: 0px; text-transform: none; white-space: normal; widows:=
 auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stro=
ke-width: 0px;" class=3D"">https://lore.kernel.org/xen-devel/12d90632bf881e=
96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com/T/#u</a><b=
r style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size=
: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; le=
tter-spacing: normal; text-align: start; text-indent: 0px; text-transform: =
none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0p=
x; text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">For
 convenience the commit is also available from git:</span><br style=3D"care=
t-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 11px; font-st=
yle: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: n=
ormal; text-align: start; text-indent: 0px; text-transform: none; white-spa=
ce: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decorat=
ion: none;" class=3D"">
<a href=3D"https://github.com/edwintorok/xen/commit/12d90632bf881e96e0b6c25=
6df193f00df187dc1" style=3D"font-family: Menlo-Regular; font-size: 11px; fo=
nt-style: normal; font-variant-caps: normal; font-weight: 400; letter-spaci=
ng: normal; orphans: auto; text-align: start; text-indent: 0px; text-transf=
orm: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-te=
xt-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=3D"">https://g=
ithub.com/edwintorok/xen/commit/12d90632bf881e96e0b6c256df193f00df187dc1</a=
><br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-s=
ize: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400;=
 letter-spacing: normal; text-align: start; text-indent: 0px; text-transfor=
m: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width:=
 0px; text-decoration: none;" class=3D"">
<br style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-si=
ze: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform=
: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: =
0px; text-decoration: none;" class=3D"">
<span style=3D"caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-=
size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400=
; letter-spacing: normal; text-align: start; text-indent: 0px; text-transfo=
rm: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width=
: 0px; text-decoration: none; float: none; display: inline !important;" cla=
ss=3D"">With
 both of these patches a smoketest 'xenstore-control live-update' with a st=
opped toolstack works now.</span></div>
</blockquote>
</div>
<br class=3D"">
<div class=3D"">
<div style=3D"margin: 0px; font-stretch: normal; font-size: 11px; line-heig=
ht: normal; font-family: Menlo;" class=3D"">
<span style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">Acke=
d-by: Christian Lindig &lt;<a href=3D"mailto:christian.lindig@citrix.com" c=
lass=3D"">christian.lindig@citrix.com</a>&gt;</span></div>
</div>
<div class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures"=
 class=3D""><br class=3D"">
</span></div>
</body>
</html>

--_000_C4ADF58A9B8245BE9FD3E9AD55557EE7citrixcom_--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 07:50:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 07:50:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427389.676388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmnR-0007oU-Ku; Fri, 21 Oct 2022 07:50:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427389.676388; Fri, 21 Oct 2022 07:50:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmnR-0007oN-I0; Fri, 21 Oct 2022 07:50:25 +0000
Received: by outflank-mailman (input) for mailman id 427389;
 Fri, 21 Oct 2022 07:50:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=chjt=2W=citrix.com=prvs=286a1e6c2=christian.lindig@srs-se1.protection.inumbo.net>)
 id 1olmnQ-0007oF-De
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 07:50:24 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 02aabf47-5115-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 09:50:22 +0200 (CEST)
Received: from mail-mw2nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 03:50:19 -0400
Received: from BL0PR03MB4161.namprd03.prod.outlook.com (2603:10b6:208:6e::27)
 by SN4PR03MB6750.namprd03.prod.outlook.com (2603:10b6:806:211::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Fri, 21 Oct
 2022 07:50:17 +0000
Received: from BL0PR03MB4161.namprd03.prod.outlook.com
 ([fe80::f917:c565:10a9:e14c]) by BL0PR03MB4161.namprd03.prod.outlook.com
 ([fe80::f917:c565:10a9:e14c%7]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 07:50:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02aabf47-5115-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666338622;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=HaPfP+NZXDV0k3oeQwlzMMBo3EA5m69EX33dDOguIbE=;
  b=DlqtV3OWQa39npAoP4XnzQe4ciKg4l/szKcdqStvSuqDNNMaBFCX+Hkb
   d6glfs/NPcQ38TbzHSXSEDXJ9UAbuPL2SDk/DsBEsdwUFe9eb8qzpdPFN
   rk/mNB45BKw3/VcF6eIyvPl2Klf3gNPgzI6uUpKOJsa7zorr/4UT3nLch
   8=;
X-IronPort-RemoteIP: 104.47.55.107
X-IronPort-MID: 83213623
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:PWcbq6my82r/A8PFdJqmyrXo5gyzJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJLXmGBaf2INGD3LtpxYNi+9hkCvcDdzIVkQQdopCk8RSMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkPKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfK0ges
 tIqGT82Tj+olfC3+Y2Wcc5Xr5F2RCXrFNt3VnBI6xj8VK5jZK+ZBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6KlFMZPLvFabI5fvSBRd9UhVqZr
 2SA+2X/DhAVHNee1SCE4jSngeqncSbTCNlITebmrKUCbFu7w2o9ARcITASHj/iwyRWBac8cB
 E0uw397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMM/WzECz
 FKCmNLtQzt1v9W9Vna15rqS6zSoNkA9DWIEfz5CcgID7PHquoR1hRXKJuuPC4awh9zxXDTvm
 TaDqXFmg61J1JZUkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5
 BAs8/VyJshTZX1RvERhmNkwIYw=
IronPort-HdrOrdr: A9a23:2InL2qugY/CABeMh5izPl+Gr7skC1YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ
 uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf
 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU
 z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq
 iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5TOObFuF4O5gLZvi3+9Kq1wah7S+cQiCq
 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P
 nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEfQI5tllulEU5XHNcrWGDzGTkwymM29pPhaCtHHWp
 +ISeBrP8M=
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208";a="83213623"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sa/6jgqutBpMlk7WRmKolUsDFeu0vDhSAlLc+YCMzeslhlsD5qSsJFV+qzohmG9wkWxsObzW94HkPC96ZzMV5Ao+comWg97HT9BYX0K8Q//BkBpnsxmxNHwKkZuIOIfIoigp3ZtHnFOjMbCpnoWHhhaOGT+svr+k+h2fRzA93/X4kpTigzoqZz4QhB1k7lzRiTQzFVEYTbM9kLcoSsQZ8NwSMl2dUPTlkr4/JbDYCPlqxHEdLpSU3Hdm9KD+0CCltvR7lsPyP8SKu/szIDFKa9p0bTgp6AeSwGldQhu7t+rn1YB2iCxQzR1C0dLF35A4eg8TLdyPEBJqEvgnSyCb8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HaPfP+NZXDV0k3oeQwlzMMBo3EA5m69EX33dDOguIbE=;
 b=ctxkSIBv893ODW2qRErPiHbyYBqOEz11HTzugQLiEqxaIm3Fj37kddA4b89ZoaWicq2tVc9YQ+WLmrvY2eVznbsT1nw0J/rwEIyFU4n6p5wAFqzvrX2gswnrGfXLg35ndRqqh9wTqTmmThRt2bqnnffTnK3Gc/kJ4cQDWERTdiPpiHbaiPWKWuo2aoopX4UYTrPi8yx7W20pLgBD7V+2mAlic80gkAonojbre8jhGMGU/7/TZPjdOpCSRM8mLdstAGTv9QiwIvOH23j/RhQNuWKvHMyhZFFcx/KakzUMkrA+8Qqg11MAPzVOY5Ed1fAJ6O10vhgOinBOOWXTZlV2Yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HaPfP+NZXDV0k3oeQwlzMMBo3EA5m69EX33dDOguIbE=;
 b=Z0bJT0iNV5V3oDZTVrRSPbaLLvwcTYftwscWrfqQc2Wsd88Ml215kMmnPYEzZKmMKCC7yS3WDdjnMlDIoBd74RRH/3BOGalAnhL3EDTJN16JzImhKV4XTbB9deVp9mTMzDL2yPVr2J+8fOD9mFINHm91fgDabDsuLZCfFyNXTMA=
From: Christian Lindig <christian.lindig@citrix.com>
To: Edwin Torok <edvin.torok@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>,
	Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH for-4.17] tools/ocaml/xenstored: fix live update exception
Thread-Topic: [PATCH for-4.17] tools/ocaml/xenstored: fix live update
 exception
Thread-Index: AQHY5KTJYQJiWLa1lkaa66iTW6pU/q4YejoA
Date: Fri, 21 Oct 2022 07:50:16 +0000
Message-ID: <B49FE4B3-77B1-4525-A6B8-C7CCA83CBC48@citrix.com>
References:
 <12d90632bf881e96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com>
In-Reply-To:
 <12d90632bf881e96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BL0PR03MB4161:EE_|SN4PR03MB6750:EE_
x-ms-office365-filtering-correlation-id: 4cb54149-1fe8-43ad-773f-08dab338e516
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 vICRyakRQWJadb3uFU3IBWiHtNvLXDMNZvBYRt+YFH5N3pVEtgnO++cXWo57pp9QBGef4+K2tQg+IBUDz5UXCS0sF4QiwLbdU7OFcagS49YmtdbJKW6h5xQgmTla7E3xMIIvrTJ2eulIsrygrhaIOcMxBuYpR5urmtrJHl4+WPr9Ryq09htpLA92tVDwCRVUd/bRZ9zRsDX11fx4uyTrKsooHTqOGtja1hh71vNxar5uePKKTMiUpfEwuA1ifveU4JHujL7EYzpBeEUSIOTebinpYVh0OjysBvkib2WFk+6nIdnYh4axc6aMqUY2CzU4rroyJpf/nOz/Kw48p5ftx+TDrftyNDSHwUAPJtC8wMhi40TTcV3rcV4V6E4rOS9PDj1LwQ6vsFdLz9u/DAybQxq0o7aeRx9Y5ZZIMrA4sSRovbw8U28XmvnvfFevxXf2+yntloMOwpwcANC57/InfpKlX5+MLK39FuBGVwy9fX1ebLCwoaKrX4PUVb+xuT/bqGkqSP62T1Vod3uNSC8Xp6FN7YrzFMR45Uj80frp+YFZx0ssKFaHW+WBVK7wpTu6DwjDo4MDfipg2LnDChUt2NrHaE5SDb7BkAPwau5fIGi1xojRaIWeU2+PgVxPH1Vs+nJdRnJJTTwHqikapkRJKMUfsKCSq7lT+1RLuMR+9wEBc4IAlztBzJ8ZT4TPcb0DuwIeXPmCFqkzmQBHHNoajKiss7IRk7hW2Nn2E8hjvakweUHaRSKLmsEjwbD2HdztGX7/FvHfLPm9umPCTNosCv0/Kodt9xWkEM4+fYvpRCk=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR03MB4161.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199015)(66574015)(36756003)(38070700005)(83380400001)(86362001)(33656002)(107886003)(38100700002)(122000001)(91956017)(82960400001)(66946007)(6636002)(64756008)(66476007)(66556008)(44832011)(15650500001)(37006003)(2616005)(5660300002)(54906003)(8676002)(316002)(66446008)(6862004)(6486002)(186003)(71200400001)(2906002)(478600001)(8936002)(4326008)(53546011)(6512007)(76116006)(26005)(41300700001)(6506007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?c1JlcTJPWnJyNnhCUThWSUVSSmdpbkNnd3hUWHNhNjNjeXhiaVhiRG02NXBK?=
 =?utf-8?B?ZDFnMnpsUlN5c2grZGp6UHRIbFd1UlRma0N2ZGsxOUJ2emZZNXdKREFiSmlq?=
 =?utf-8?B?d2pDZ1lOTmdYWVVDVHBNSDdTTytKYVNQZ2NFV2g3YnZJN0R0WldLV0s2NE1U?=
 =?utf-8?B?ZXN3N0ZXeVJ6bmo1WWlCR21kL1lnbDRXYi9QUlZ1T2RBUEZhclZXTXNmbnlN?=
 =?utf-8?B?UHNYRmVsQUVWUnB6Y1FzMnl0bTJkOXVIck1ISVE1NkcwMzcyZGhpZUd5dnVn?=
 =?utf-8?B?MGdIblNVWWdrS3pFUXByeTJEazVmZC9nTUpudWVZNlU5UFc4UmxBS3psR0Rk?=
 =?utf-8?B?MXhvK1JNNXoxN3Q1WVlKQm42eitjd3YzSjNCU0pBaitVN3Rwbm1FSnBpdnBO?=
 =?utf-8?B?NjZySUtqYVV3WDdFTjBMTksvT0dROXJOd3c0R2dyMGowLyswUVJkSmdLSHRR?=
 =?utf-8?B?eldKUi9HU1hGdzVWV0RiRFByd005WWVGM3YyWGZLYmh6bkt3cVRNb0RoMFQ2?=
 =?utf-8?B?ZmZsdjdpblZTRUd4OG5vVGtVTk1GbVRJWnNZbDhPMUNXUWNQdUhvZUFRSDJ6?=
 =?utf-8?B?T1RsU0RtZUNHYnJKVm8vMjNPQ3pHdHMzT0lNd0Z5M3NSN1daYjM4TWloSm4w?=
 =?utf-8?B?Vy9KU3E1dkozc05SUjNoR0svZTRmRHdBUFRoZmJBb0ZCYXFMR0ZEQ3M5dG9m?=
 =?utf-8?B?eStGNTRvVSsweUJZR0RJMVl0c3NBNytLM0dsV0I5VEJQV3gwYkhCeUxINjhM?=
 =?utf-8?B?UGdpWlpLUU5Bc2RyN3NtaGo3ZDRJRzVibWJrMnFTWlFoRFZsSC9UY2R0aXQ3?=
 =?utf-8?B?cFBjRnRRbTl5akw0ZHd6RHN3clJGb0I1MldqVGcvdEF4MHBHdDkvcDJwN3Iw?=
 =?utf-8?B?UDhMVVQ3YXJKN05xRjdoeVV1Z2Z0NDcyYStQYTA0UkxvNnk3c0VLYjBCUjRa?=
 =?utf-8?B?ZXlHdjgwckpSeWhDZjlZRnJGNE5GYUNhWXJDQnhPbFdhYk0rZnY2VlFmZmsz?=
 =?utf-8?B?Q3ZIUlBkYmgyQnBWcWd1aHZ3LzU5a0JRTGgrL2dQemE1alNaajFaU0xBaXVw?=
 =?utf-8?B?SkVkZWlzMlZlMkVJY3FlVDhLYjZqTkdreTMxc3FxUnJMaWtpRXV2R2NtZ1kv?=
 =?utf-8?B?OVdpZXpKUW51U3kzUU51eTFvTE5nUWx6eUF1NHQ3WXNzd1c4RjQ5T1c4eCtt?=
 =?utf-8?B?NTdWZ3hIQm1wQkhVK1FaZWdsakJaV2pZMStDUkxhL3RkNEZPWkNoU2xCZlBu?=
 =?utf-8?B?UjJkNzVwTmRHcSttWTl3VUpZMEhIdFRhanpQT3I2V0dITXRhVEJnelc2c08w?=
 =?utf-8?B?S0RXTU9DQnVPcXNieTlOekcybWRaMmI3cUwxbmdoV01BNUxZU25OU2tvSTds?=
 =?utf-8?B?VWJJazZuVW9sdU0ydWVMNXh3ejV2Zk90N0xrSEczZjRwQ0orT2Y3NExSUm1i?=
 =?utf-8?B?WmdVV20vVkNCT2pvOGtIWERqRWRiM3B0M21HZklaMHdTM0trblJlejN1TlI2?=
 =?utf-8?B?RnRIZkJ6OWlhejBYOHlFMERCb2tTMVhFUUVVTm5idlBSQ0xGRTJ5UzhXQWI5?=
 =?utf-8?B?VWF2OU1Ib3dLSmdDQXBad3ZHZXpibGV4N01BcEU0cDM4VWdpZVhrNHk2TUxE?=
 =?utf-8?B?UldMT1dhUS9UU3FhWHdOdWJGeklUb1ZTc2xXMkNpVFczUndESENXdEhERmZs?=
 =?utf-8?B?OEgzc2RWK0VPSjFyV2lmNTFPeWNhaXBIZlZyUDhLR0Y5Q3B3SlpkRGhtQ1BN?=
 =?utf-8?B?OVE3aFZVeWo0NTJqZVZsdUxESXFiVkpQTENRL3ZzcWVyVGZrSkdzZ3JLa3dl?=
 =?utf-8?B?QUc4NFppSWhyOVVlZWMxamdPQzNHNnFORTcxZEVPaXRtNUU5TklFVUlzY09U?=
 =?utf-8?B?RWNxNEt2ajNJUW9vdzJ0NkVIRjlicytRTktxRG1rSEthYnF0N3BkZ1FZT0lH?=
 =?utf-8?B?djlYeGJGUktDcTNsZm15QkRFMi9DTmc2UzU0T0h5cmV4UXdHcVYrTGRTOWNZ?=
 =?utf-8?B?aG1PZEFmTER1WFhjWTFidjFMbS9kcEI2aDcyTzh4NE1hNWRSTVB0bXZHbGNi?=
 =?utf-8?B?aEcwWGlmRUZ4aWJYVFVOWDdQd0dxVkQ5SmhzOUhrcDF3eHJCMEh2NzBrSk40?=
 =?utf-8?B?akJDMkw3QUl6MkphYWdjN1hOZkYyVndwSkI4emFiVm9uQzJORFdPMnFPV2Va?=
 =?utf-8?Q?O4uFCWJ15rUrNJzbxl7p/So=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AB7B4CEAEE026F44975B20025FCCE908@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR03MB4161.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb54149-1fe8-43ad-773f-08dab338e516
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 07:50:16.9185
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0LiMuCISVY5TOjlKbUmtjWL600bxImu2b7abJ4qUkQ+PtoCVnI+d1vrSW86FyQTXDBn41f08GFmc9d2+4D77QnF75KgAQtC0vBDPgtNeNLI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR03MB6750

DQoNCj4gT24gMjAgT2N0IDIwMjIsIGF0IDE3OjU0LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jv
a0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IER1cmluZyBsaXZlIHVwZGF0ZSB3ZSB3aWxsIGxv
YWQgdGhlIC90b29sL3hlbnN0b3JlZCBwYXRoIGZyb20gdGhlIHByZXZpb3VzIGJpbmFyeSwNCj4g
YW5kIHRoZW4gdHJ5IHRvIG1rZGlyIC90b29sIGFnYWluIHdoaWNoIHdpbGwgZmFpbCB3aXRoIEVF
WElTVC4NCj4gQ2hlY2sgZm9yIGV4aXN0ZW5jZSBvZiB0aGUgcGF0aCBiZWZvcmUgY3JlYXRpbmcg
aXQuDQo+IA0KPiBUaGUgd3JpdGUgY2FsbCB0byAvdG9vbC94ZW5zdG9yZWQgc2hvdWxkIG5vdCBu
ZWVkIGFueSBjaGFuZ2VzDQo+IChhbmQgd2UgZG8gd2FudCB0byBvdmVyd3JpdGUgYW55IHByZXZp
b3VzIHBhdGgsIGluIGNhc2UgaXQgY2hhbmdlZCkuDQo+IA0KPiBQcmlvciB0byA3MTEwMTkyYjFk
ZjYgbGl2ZSB1cGRhdGUgd291bGQgd29yayBvbmx5IGlmIHRoZSBiaW5hcnkgcGF0aCB3YXMNCj4g
c3BlY2lmaWVkLCBhbmQgd2l0aCA3MTEwMTkyYjFkZjYgYW5kIHRoaXMgbGl2ZSB1cGRhdGUgYWxz
byB3b3JrcyB3aGVuDQo+IG5vIGJpbmFyeSBwYXRoIGlzIHNwZWNpZmllZCBpbiBgeGVuc3RvcmUt
Y29udHJvbCBsaXZlLXVwZGF0ZWAuDQo+IA0KPiBGaXhlczogNzExMDE5MmIxZGY2ICgidG9vbHMv
b3hlbnN0b3JlZDogRml4IE94ZW5zdG9yZWQgTGl2ZSBVcGRhdGUiKQ0KPiBTaWduZWQtb2ZmLWJ5
OiBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiAtLS0NCj4gdG9vbHMv
b2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbCB8IDQgKysrLQ0KPiAxIGZpbGUgY2hhbmdlZCwg
MyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMv
b2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbCBiL3Rvb2xzL29jYW1sL3hlbnN0b3JlZC94ZW5z
dG9yZWQubWwNCj4gaW5kZXggZmM5MGZjZGViNS4uMzI5OWZlNzNmNyAxMDA2NDQNCj4gLS0tIGEv
dG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbA0KPiArKysgYi90b29scy9vY2FtbC94
ZW5zdG9yZWQveGVuc3RvcmVkLm1sDQo+IEBAIC0zNTMsNyArMzUzLDkgQEAgbGV0IF8gPQ0KPiAJ
KSBpbg0KPiANCj4gCSgqIHJlcXVpcmVkIGZvciB4ZW5zdG9yZS1jb250cm9sIHRvIGRldGVjdCBh
dmFpbGFiaWxpdHkgb2YgbGl2ZS11cGRhdGUgKikNCj4gLQlTdG9yZS5ta2RpciBzdG9yZSBQZXJt
cy5Db25uZWN0aW9uLmZ1bGxfcmlnaHRzIChTdG9yZS5QYXRoLm9mX3N0cmluZyAiL3Rvb2wiKTsN
Cj4gKwlsZXQgdG9vbF9wYXRoID0gU3RvcmUuUGF0aC5vZl9zdHJpbmcgIi90b29sIiBpbg0KPiAr
CWlmIG5vdCAoU3RvcmUucGF0aF9leGlzdHMgc3RvcmUgdG9vbF9wYXRoKSB0aGVuDQo+ICsJCQkJ
CVN0b3JlLm1rZGlyIHN0b3JlIFBlcm1zLkNvbm5lY3Rpb24uZnVsbF9yaWdodHMgdG9vbF9wYXRo
Ow0KPiAJU3RvcmUud3JpdGUgc3RvcmUgUGVybXMuQ29ubmVjdGlvbi5mdWxsX3JpZ2h0cw0KPiAJ
CShTdG9yZS5QYXRoLm9mX3N0cmluZyAiL3Rvb2wveGVuc3RvcmVkIikgU3lzLmV4ZWN1dGFibGVf
bmFtZTsNCg0KSSBub3RpY2UgaW5jb25zaXN0ZW50IGluZGVudGF0aW9uIGJ1dCBsZXQncyBpZ25v
cmUgdGhhdCBvciBmaXggaXQgYmVmb3JlIHRoZSBjb21taXR0aW5nLg0KDQpBY2tlZC1ieTogQ2hy
aXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXguY29tPg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:00:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:00:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427397.676405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmwd-0000BO-LF; Fri, 21 Oct 2022 07:59:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427397.676405; Fri, 21 Oct 2022 07:59:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmwd-0000BH-Gu; Fri, 21 Oct 2022 07:59:55 +0000
Received: by outflank-mailman (input) for mailman id 427397;
 Fri, 21 Oct 2022 07:59:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xRpv=2W=citrix.com=prvs=286e1060a=edvin.torok@srs-se1.protection.inumbo.net>)
 id 1olmwc-0000B0-EA
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 07:59:54 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5766a2a3-5116-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 09:59:53 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5766a2a3-5116-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666339193;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=JuPSkEVXaJjMkq42I+yC8YUIvudAydl1dIqUndfnzLU=;
  b=Y8ip/oW9LLOcMI+G5enK1Vqodceeg1V+uTRcKT+IGELr4uVkN4h/F45Y
   0HqOKyksmdS4kcqguWiZmlJIUcFRCBKxTEPf3x7pUFecZma0wov1ZAzfp
   5zlC5+3bJ3rUOP96xNEuyxpjXKLm75v/1ZfMHpvjIgucc17F9BEFRxNsw
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83214158
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VfVbwa2KyFaG8jTI9PbD5d9xkn2cJEfYwER7XKvMYLTBsI5bp2AHn
 2BJUWqOPv2LNjOgcoh2OY3goBwGupCGnNM3GQs+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlB5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUZ5MttH2diz
 sBfB2tWQRGDuKH10umkH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8aBIw/mqG0gWP4cBVTqU6PpLpx6G/WpOB0+Oi2aoOJI4HaLSlTtn6Wt
 kf3/FjePgATDPrAlwrV2XiswdaayEsXX6pNTeblp5aGmma75mEVEgxQalK9rtGwkEv4UNVaQ
 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36
 rOXt9L3KCZxtpGudTWyrey7rDONemsHdnBXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJJN3g/
 9yZhHNg3utO1Kbnw43+pAma2Gz0+vAlWyZvvm3qsnSZAhSVjWJPT6ih8hDl4PlJN+51pXHR7
 SFfy6ByAA3jZKxhdRBhos1XR9lFBN7falUwZGKD+bF4qFxBHFbzFb28GBkkeC9U3j8sIFcFm
 nP7twJL/4N0N3C3d6JxaI/ZI510k/a6TYi/BqmPNoomjn1NmOmvpnoGiam4hjqFraTRuftnZ
 cfznTiEUR729piLPBLpHrxAgNfHNwg1xH/JRICT8ilLJYG2PSbPIZ9caQPmRrlgsMu5TPD9r
 o832z2ikE4EDoUTo0D/rOYuELz9BSdiXs2r9pwOK4Zu4GNOQQkcNhMY+pt5E6QNokifvr2gE
 q2VMqOA9GfCuA==
IronPort-HdrOrdr: A9a23:fnInNqE30+vEZuKppLqE5MeALOsnbusQ8zAXP0AYc3Jom6uj5q
 eTdZUgpHvJYVkqOE3I9ertBEDiewK4yXcW2/hzAV7KZmCP0wHEEGgL1/qF/9SKIUzDH4Bmup
 uIC5IOauHNMQ==
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208";a="83214158"
From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= <edvin.torok@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= <edvin.torok@citrix.com>, "Christian
 Lindig" <christian.lindig@citrix.com>, Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH for-4.17 v2] tools/ocaml/xenstored: fix live update exception
Date: Fri, 21 Oct 2022 08:59:25 +0100
Message-ID: <4a89f1f44cb171e1f92dae2401a580a10fd0c5a0.1666339129.git.edvin.torok@citrix.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

During live update we will load the /tool/xenstored path from the previous binary,
and then try to mkdir /tool again which will fail with EEXIST.
Check for existence of the path before creating it.

The write call to /tool/xenstored should not need any changes
(and we do want to overwrite any previous path, in case it changed).

Prior to 7110192b1df6 live update would work only if the binary path was
specified, and with 7110192b1df6 and this live update also works when
no binary path is specified in `xenstore-control live-update`.

Fixes: 7110192b1df6 ("tools/oxenstored: Fix Oxenstored Live Update")
Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
---
 tools/ocaml/xenstored/xenstored.ml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml
index fc90fcdeb5..acc7290627 100644
--- a/tools/ocaml/xenstored/xenstored.ml
+++ b/tools/ocaml/xenstored/xenstored.ml
@@ -353,7 +353,9 @@ let _ =
 	) in
 
 	(* required for xenstore-control to detect availability of live-update *)
-	Store.mkdir store Perms.Connection.full_rights (Store.Path.of_string "/tool");
+	let tool_path = Store.Path.of_string "/tool" in
+	if not (Store.path_exists store tool_path) then
+		Store.mkdir store Perms.Connection.full_rights tool_path;
 	Store.write store Perms.Connection.full_rights
 		(Store.Path.of_string "/tool/xenstored") Sys.executable_name;
 

base-commit: 0c06760be3dc3f286015e18c4b1d1694e55da026
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:02:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:02:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427404.676416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmys-00027X-8T; Fri, 21 Oct 2022 08:02:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427404.676416; Fri, 21 Oct 2022 08:02:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olmys-00027Q-5e; Fri, 21 Oct 2022 08:02:14 +0000
Received: by outflank-mailman (input) for mailman id 427404;
 Fri, 21 Oct 2022 08:02:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xRpv=2W=citrix.com=prvs=286e1060a=edvin.torok@srs-se1.protection.inumbo.net>)
 id 1olmyr-00027K-8Z
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 08:02:13 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a9e3b188-5116-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 10:02:11 +0200 (CEST)
Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 04:01:33 -0400
Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7)
 by DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 21 Oct
 2022 08:01:29 +0000
Received: from SJ0PR03MB5888.namprd03.prod.outlook.com
 ([fe80::a093:1d6d:9e9:cbfa]) by SJ0PR03MB5888.namprd03.prod.outlook.com
 ([fe80::a093:1d6d:9e9:cbfa%6]) with mapi id 15.20.5723.033; Fri, 21 Oct 2022
 08:01:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9e3b188-5116-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666339331;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=gA0NvLnL3Fdi9ealQa+fLB0ppRWib8sd7dPdiRQcZ6A=;
  b=VfFnGi7Beip/HhKLzyI+g89T0gkbzMg8bCbPqKXaCAUjZxb6lbEjoNXU
   +2AYLkmcwO408HkpzdF0FOLsDk8yUXfdzGj5kLJWr3MY/GCX9kgnUQtvF
   9nQInjwvJ9kwZc6Z2hbvym7u25mg+zNLL7j9eOmIWIxr1w7hrrIF3B3zf
   Q=;
X-IronPort-RemoteIP: 104.47.55.177
X-IronPort-MID: 82330148
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:4GSqVKx7N2Oc1lVfNad6t+cBxyrEfRIJ4+MujC+fZmUNrF6WrkVUz
 GFJDz3Ub6zbYGD9Ltl3bti18hwFvsfcyYNkSldvpSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC5wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5L9rGT5tr
 ccjdnMzbRKypL21mb7lY7w57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvDe7IA9ZidABNPLYdsKLQ4NJmVyfp
 UrN/njjAwFcP9uaodaA2iL23bSXxH+rMG4UPOCm6P0zjFq1/WNJT0YMDneZqMCCuFHrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAIRyBMQMYrv8g3QXotz
 FDht8ztLSxitvuSU3313peZqymjfxccK2AqbDUBCwAC5rHeTJobixvOSpNpFv6zh9isQzXom
 WnV8245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5
 SRsdxS2hAzWMaywqQ==
IronPort-HdrOrdr: A9a23:IEppLqAKFnwyxF3lHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U
 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca
 Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z
 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkWwqc5Ew6sN5m1q
 VXm2qfqppMFBvF2D/w/t7SSnhR5wOJSepLq59ts5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+
 djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+
 DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ
 zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw
 ==
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208";a="82330148"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l8H0snc/oBXPu2kwd9UsA7bGOmIRLrPhfsLDeBdfar8hpc2Wk3g8tZQBxNg3B1WptNcVVtYUJ2M4vte/gXEtObXaKvA54woUajWR+FXvxz+aIGzsAuWfMkI1CLmzvTWv4hBznKPfX+MBZQoKgdU7JIyoex2E969ujut6pw4LWo7+DLn6HSueS+h0I8CPDzUyckeTzDYGmVS0hdTtuqWdf75iqOClXelAggLg3IvdVNtevF2h4oJczR1xvs5zVydqmt/f23yEzO4zsy/oWj4edgsA3lFE4kppi4DVfJI+GcSQA9vOODehXY1wmgeKLmT0xSVl1oCRwaVRK0jW74pEKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gA0NvLnL3Fdi9ealQa+fLB0ppRWib8sd7dPdiRQcZ6A=;
 b=FwimdSidqSLnoKe7uYRHuyJ+V4kKwVp1XGzaMbkpa1KvNS/g0/aj5pFHj9tssZcrwYVVUv7ue9ikgNSA79OAhPGsPgHhy+vE/m3eiR/9yRQz+GVHkrz+cea1rzuA9gEB7XlLfLBlBPt1RCeijxbn3Mfc7sRZJMiZsZbYaR87ukmhmUKft11YEhlo0nrGmQCPt5mw5WS8YAtheLSCslBdI7oUwfPipQxP/VN7kBIkH57mIPFCSmWXpn2F3RJzeIIUyFvtK/t3h3lpCW5yVbP3JfPM6EWJJig0RK1+GgToJeiidGV5IHwSUtk4F94ys/z1D1CwbWyH+hxm6Df+j1JctA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gA0NvLnL3Fdi9ealQa+fLB0ppRWib8sd7dPdiRQcZ6A=;
 b=NofoeGeSyoLqi4kAQ6BEGx3gkMiOreFJ4ei98Sss6O+YKtGzv2YxTTkKSGHNUlM4EO2DFwx4QCkroyltELz2sw36Etv1Djhqhb27eRI5URwSWmn6RVjqJPduSItYiEkRwkhUsRe+pc2dBSI0eEY9iry9+O07KXSCQr3Jy/ZJk8Q=
From: Edwin Torok <edvin.torok@citrix.com>
To: Christian Lindig <christian.lindig@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, David Scott <dave@recoil.org>,
	Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: Re: [PATCH for-4.17] tools/ocaml/xenstored: fix live update exception
Thread-Topic: [PATCH for-4.17] tools/ocaml/xenstored: fix live update
 exception
Thread-Index: AQHY5KTJuDEKM//4x0G7vfjVpiIJ8K4YejoAgAADIQA=
Date: Fri, 21 Oct 2022 08:01:28 +0000
Message-ID: <D6E18B43-7A98-4E89-84E0-17D3F5ACB2B4@citrix.com>
References:
 <12d90632bf881e96e0b6c256df193f00df187dc1.1666284745.git.edvin.torok@citrix.com>
 <B49FE4B3-77B1-4525-A6B8-C7CCA83CBC48@citrix.com>
In-Reply-To: <B49FE4B3-77B1-4525-A6B8-C7CCA83CBC48@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR03MB5888:EE_|DS7PR03MB5608:EE_
x-ms-office365-filtering-correlation-id: 45e2d284-2cf7-44c9-6e7f-08dab33a759d
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 BCPwgUPkt0SFdUyNPNFjEccNP7+HaeaDNWF++mUn6oOL9t64623A4nzoeanV+Z39Zm3xsSIIBUxncvgON65qn5YXZ344z0LBdxDSoeh74eXXoZ+LfaLNmlAgk0Iasp9aVHLMAyBYS7C5464RSsJ9RYEAHInCZ3orC6meyc5m+A6ghfzLMnchMVzCpoIc7Ynap9eQOy3m9u1xVUafdM6ny07TCbpsunCtmhFSEja0x6J23lrTSHSCE3W7LvskNt+pO94G1VKHmTiyntwUELoR26GAWg/TS8lRsNl77xb/8+iQT6oDtUgwZbZ+skissE0+VH8Pdzp+6YBmZt5Bzbed7dofwBD0j9kuF0jFWxg8fyd9gtltjUkizSbnkH0RRIfxFMysOaDQtOlIXopY2BG2c4cf0r6IpohnEOumF5H/tAVbUROlRa7wmgV125nGuuqWnQ9WhN2aoZHtDlXryduYYYyd29DROTQnFz4V8LycJyyis9n+7Ji53db3qMoHcY3gcyoJH3g8qN3THPQocSO7BVi3QqQ04KyaN/Q/5PYxx6A7zuZrQu26f0WZS3GmShD1F/qog61KPINOhMladTsXDM0Dl0GFF64t5aozn1tArO7mNvIib5f4N9+LdhWPcxpx2nCWppYJo7v2xM1tVR4j4UgK0jSlfSex8DAZiyUpfjhUdaLdJjtqMJ13a4PbskVYnSRrgvbWFWa8s/VK1A05MCvHPTCaWJSSQFmwFXNYIfXfqCDAHk15bWSuX9LP7shtO6udPBd7eu7gd3doJVFFxqiBv/hWywSiYTaVgke3dyEIQ9YV+znriM/ucnRUHzUyzFF7xnoGSC7ORbwWmI58ew==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199015)(66574015)(82960400001)(38070700005)(83380400001)(36756003)(33656002)(86362001)(107886003)(38100700002)(122000001)(91956017)(66556008)(66946007)(76116006)(6636002)(54906003)(316002)(71200400001)(15650500001)(6862004)(37006003)(5660300002)(66476007)(53546011)(2616005)(186003)(2906002)(966005)(6506007)(6486002)(8936002)(4326008)(64756008)(6512007)(66446008)(478600001)(26005)(41300700001)(8676002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?enluUFMwKzlCdFpKQjdDN051SWFrb3llVlh6QXRtaGRhSEppdHlwTmRaMEgz?=
 =?utf-8?B?Q2RSbkRBc3gzcHhnSUlMTU85a3J3TU8rUjd5YjZ6Z24wUmdkZ3FHYnd3TE95?=
 =?utf-8?B?QktTU2lzMTJGVHNtN1NlVWZCeUJkbDY0SzdnemVkODYyT0VGL3EzVTE0WXpn?=
 =?utf-8?B?VHZsSUt1U0VwRlpTazZRVmRxSzNOblZMT2dLTVRIM2lBTXp1SVY2bjY4SnJI?=
 =?utf-8?B?am5OaGV4TGFXWWRNZEI5ZFhQUlIvMFpCNGhUWjMvcXJMRzRWRXYxdmNPYWRM?=
 =?utf-8?B?QjJsd1AzM0FITVVVejNoc1ZKR0laVzFEUlk1RHBIOWhqckpRQ1ByZy9uS05L?=
 =?utf-8?B?SFVwMlBWV2dXemZsdEZOelBoNDJnME1VWjlrdTJqaUVOelJ6OEw5OURnSXdD?=
 =?utf-8?B?eHA3bmhSdjJ5bVJyd1dlaXhYYm1CY1o4aHlxanlRZlBiNXFmUnZkMVRPZFdm?=
 =?utf-8?B?SWhwNDNWWHFYb25YY3RpK2pNYkdpbkd5QWsxcExiOFRXcDVSTjlBRTNMWERN?=
 =?utf-8?B?MEpOMEl5NW9sbGdDd25iSEVHR1Y5WHd1ZElTS2RPUDVSV2N5ZkZSMmNnUm1V?=
 =?utf-8?B?SkdkQmlkNVBSQ0ZEeXBFR1I4bHRsRXNaYUtLZ2RLK2o5UVJrcTEzL3ZIVzJI?=
 =?utf-8?B?eGlqb2ZHSGMxd1RhdWJGdFI1U0xCZEtqb0llbmozR2x3Y1gyTUtueS9EemVr?=
 =?utf-8?B?eGdVeDFwR25PQjF4NWJ2aFREWUZuSUFUOE1jNEhjeVNqTWg4ek5pWDdwdDhv?=
 =?utf-8?B?ZC9POXgvamdIL3d5UGxHWERvK1ljSEgxK3NQV1BvNlJWeXFzallteFoxNFZ0?=
 =?utf-8?B?ajl6Mk9KYlNZYlRXeVQ1bGNuM1hoaDR0NWE2NzVMcTNncXlkYldkVEFKOGlN?=
 =?utf-8?B?aEU4aHN5RGoxWG91M2tTS2xOa1QxTENYOUN4aTFnMmJucVlpcjN3TUx5L3g4?=
 =?utf-8?B?d015Qi9ONzVpVS85Yk5hSEpBakU2ZllxOFVSQ3BIT0cvb0U2aXJrYjFWZ3dj?=
 =?utf-8?B?RUFDTmh2QStCSXJNak9qVFBpVERNTUZ1cTRQNk1pL09lK09wTUVHUmxYSjlv?=
 =?utf-8?B?a0pPUkk5TDltT1E4VjdkbEd6L0xVUEFCQis4ZUI3WVdyWm5teDFwQ2JYZURH?=
 =?utf-8?B?a0xBUzB0cklCeXBjek1CL1FtcWttWitSUUJMVXRka1pKTXRyejdHMzd5RlA5?=
 =?utf-8?B?Vk9YaE05YzUyaGVKZFRHL2p6eTBDS2QwSjBub2VaV0thS0ZjTDZmME5SaXFU?=
 =?utf-8?B?ejZRRXg2VzVsTWpqOVJVczVyU2pTU1dBNkc4dGpQWlcwNG1qWXdmR3RPT0or?=
 =?utf-8?B?WkdCcGJmQjZQcUo3MzNrVjZKVkZnenFuZFFtTDNsdm1VODJNVVV1WFpmeDhs?=
 =?utf-8?B?Q0c4UEtwbGNwT2lqYlNNSzhiODBvOTJWUFdFaHRXK3JEc3VyaklaUkkzOVgz?=
 =?utf-8?B?VVRpbXdQb0VjU2hYYzJUNFRIUndMUWMxNlY1Y01XbWQ3NU5LNy9ma2ZBUmZy?=
 =?utf-8?B?eUZ2Q0tMTFlhZUw2V2krVThJZ2d2bkk3NjFoMWxkOXYvQldNOVMvMzJrc2JB?=
 =?utf-8?B?RDRzOXdRU1JVaTlzVDhvRFpINHEyQ2V4UEJQYUN4Qnh6clJIZkJoc29CRjNo?=
 =?utf-8?B?L0tJNmF6andlRXpySnE4WmVJeTZMVDVxbTZBZnBRU1libzV4UGZuU3lNUHRm?=
 =?utf-8?B?MHhnUWhNQTBzOXVGLzhXTDZZZ0RsNXRreGFocU95Y2FXWDVvNmhySW5yVzNk?=
 =?utf-8?B?TjZQYXZFQkZCRTh4Lzc0RnQ2Qk1iUG1NYXNjT3ZrT2tsQWF2bjhVR0ZDMThT?=
 =?utf-8?B?RDd3eWUrdmVNbno0NXZNalltU0luL2MzS2krMzVVWU5nZ2F6bDcrSDRlTVQ5?=
 =?utf-8?B?eXg2cHorczQzVFJRcmJZMUJ0UklndkVpQmYwOEdDQzF2dnJKSGQvNnZ0RjZ1?=
 =?utf-8?B?eHNpd29tbENJelZKd01rMkdmbUJjVVA4K2JrME95VVM5eWpqY3h0aThnSjNK?=
 =?utf-8?B?UWJFdG9FOXAxcjdoMnRMMUZjVHBqS21JMXJCUDNNNXZrbHQwaFBYMW5Ud2ZX?=
 =?utf-8?B?Nzd4Z01YYlMzUGJ5dllYUVhFUUlGaFppY1lzWFVQNUF2b1p4ejFoeFhuNS9O?=
 =?utf-8?B?bk5ZbXhuK0dZeUJjWGdoSVYxaHM5NUhPOTRnMmhxM0tZcGZMb0pwNXFuT2hT?=
 =?utf-8?B?ZGc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9B65CB6F6081204185C4C6005171E3B9@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45e2d284-2cf7-44c9-6e7f-08dab33a759d
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 08:01:28.8760
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5TQD4Q3tVhaNPWlLM9sLtAEwyrwllBzsm2kwav2RW6/fxmHNKBUFLF+edz78hlLi6DzAR/uU2r7mdtbxRhfDLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5608

DQoNCj4gT24gMjEgT2N0IDIwMjIsIGF0IDA4OjUwLCBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3Rp
YW4ubGluZGlnQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gDQo+IA0KPj4gT24gMjAgT2N0IDIw
MjIsIGF0IDE3OjU0LCBFZHdpbiBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPiB3cm90
ZToNCj4+IA0KPj4gRHVyaW5nIGxpdmUgdXBkYXRlIHdlIHdpbGwgbG9hZCB0aGUgL3Rvb2wveGVu
c3RvcmVkIHBhdGggZnJvbSB0aGUgcHJldmlvdXMgYmluYXJ5LA0KPj4gYW5kIHRoZW4gdHJ5IHRv
IG1rZGlyIC90b29sIGFnYWluIHdoaWNoIHdpbGwgZmFpbCB3aXRoIEVFWElTVC4NCj4+IENoZWNr
IGZvciBleGlzdGVuY2Ugb2YgdGhlIHBhdGggYmVmb3JlIGNyZWF0aW5nIGl0Lg0KPj4gDQo+PiBU
aGUgd3JpdGUgY2FsbCB0byAvdG9vbC94ZW5zdG9yZWQgc2hvdWxkIG5vdCBuZWVkIGFueSBjaGFu
Z2VzDQo+PiAoYW5kIHdlIGRvIHdhbnQgdG8gb3ZlcndyaXRlIGFueSBwcmV2aW91cyBwYXRoLCBp
biBjYXNlIGl0IGNoYW5nZWQpLg0KPj4gDQo+PiBQcmlvciB0byA3MTEwMTkyYjFkZjYgbGl2ZSB1
cGRhdGUgd291bGQgd29yayBvbmx5IGlmIHRoZSBiaW5hcnkgcGF0aCB3YXMNCj4+IHNwZWNpZmll
ZCwgYW5kIHdpdGggNzExMDE5MmIxZGY2IGFuZCB0aGlzIGxpdmUgdXBkYXRlIGFsc28gd29ya3Mg
d2hlbg0KPj4gbm8gYmluYXJ5IHBhdGggaXMgc3BlY2lmaWVkIGluIGB4ZW5zdG9yZS1jb250cm9s
IGxpdmUtdXBkYXRlYC4NCj4+IA0KPj4gRml4ZXM6IDcxMTAxOTJiMWRmNiAoInRvb2xzL294ZW5z
dG9yZWQ6IEZpeCBPeGVuc3RvcmVkIExpdmUgVXBkYXRlIikNCj4+IFNpZ25lZC1vZmYtYnk6IEVk
d2luIFTDtnLDtmsgPGVkdmluLnRvcm9rQGNpdHJpeC5jb20+DQo+PiAtLS0NCj4+IHRvb2xzL29j
YW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgfCA0ICsrKy0NCj4+IDEgZmlsZSBjaGFuZ2VkLCAz
IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4+IA0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xz
L29jYW1sL3hlbnN0b3JlZC94ZW5zdG9yZWQubWwgYi90b29scy9vY2FtbC94ZW5zdG9yZWQveGVu
c3RvcmVkLm1sDQo+PiBpbmRleCBmYzkwZmNkZWI1Li4zMjk5ZmU3M2Y3IDEwMDY0NA0KPj4gLS0t
IGEvdG9vbHMvb2NhbWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbA0KPj4gKysrIGIvdG9vbHMvb2Nh
bWwveGVuc3RvcmVkL3hlbnN0b3JlZC5tbA0KPj4gQEAgLTM1Myw3ICszNTMsOSBAQCBsZXQgXyA9
DQo+PiAJKSBpbg0KPj4gDQo+PiAJKCogcmVxdWlyZWQgZm9yIHhlbnN0b3JlLWNvbnRyb2wgdG8g
ZGV0ZWN0IGF2YWlsYWJpbGl0eSBvZiBsaXZlLXVwZGF0ZSAqKQ0KPj4gLQlTdG9yZS5ta2RpciBz
dG9yZSBQZXJtcy5Db25uZWN0aW9uLmZ1bGxfcmlnaHRzIChTdG9yZS5QYXRoLm9mX3N0cmluZyAi
L3Rvb2wiKTsNCj4+ICsJbGV0IHRvb2xfcGF0aCA9IFN0b3JlLlBhdGgub2Zfc3RyaW5nICIvdG9v
bCIgaW4NCj4+ICsJaWYgbm90IChTdG9yZS5wYXRoX2V4aXN0cyBzdG9yZSB0b29sX3BhdGgpIHRo
ZW4NCj4+ICsJCQkJCVN0b3JlLm1rZGlyIHN0b3JlIFBlcm1zLkNvbm5lY3Rpb24uZnVsbF9yaWdo
dHMgdG9vbF9wYXRoOw0KPj4gCVN0b3JlLndyaXRlIHN0b3JlIFBlcm1zLkNvbm5lY3Rpb24uZnVs
bF9yaWdodHMNCj4+IAkJKFN0b3JlLlBhdGgub2Zfc3RyaW5nICIvdG9vbC94ZW5zdG9yZWQiKSBT
eXMuZXhlY3V0YWJsZV9uYW1lOw0KPiANCj4gSSBub3RpY2UgaW5jb25zaXN0ZW50IGluZGVudGF0
aW9uIGJ1dCBsZXQncyBpZ25vcmUgdGhhdCBvciBmaXggaXQgYmVmb3JlIHRoZSBjb21taXR0aW5n
Lg0KPiANCj4gQWNrZWQtYnk6IENocmlzdGlhbiBMaW5kaWcgPGNocmlzdGlhbi5saW5kaWdAY2l0
cml4LmNvbT4NCj4gDQoNCg0KVGhhbmtzLCBmaXhlZCBpbmRlbnRhdGlvbiBoZXJlOiBodHRwczov
L2dpdGh1Yi5jb20vZWR3aW50b3Jvay94ZW4vY29tbWl0LzRhODlmMWY0NGNiMTcxZTFmOTJkYWUy
NDAxYTU4MGExMGZkMGM1YTANCkFuZCB2MiBwYXRjaCBzaG91bGQgc2hvdyB1cCBvbiB0aGUgTUwg
d2l0aCB0aGUgMiBhY2tzIGluY2x1ZGVkIGFuZCBmaXhlZCBpbmRlbnRhdGlvbiBzb29uIHRvby4N
Cg0KQmVzdCByZWdhcmRzLA0KLS1FZHdpbg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:06:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:06:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427411.676427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oln2q-0002s0-Tc; Fri, 21 Oct 2022 08:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427411.676427; Fri, 21 Oct 2022 08:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oln2q-0002rt-Qg; Fri, 21 Oct 2022 08:06:20 +0000
Received: by outflank-mailman (input) for mailman id 427411;
 Fri, 21 Oct 2022 08:06:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1mzs=2W=citrix.com=prvs=28632f022=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oln2p-0002rm-8o
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 08:06:19 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c931e83-5117-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 10:06:17 +0200 (CEST)
Received: from mail-dm6nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 04:06:14 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN8PR03MB4977.namprd03.prod.outlook.com (2603:10b6:408:de::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Fri, 21 Oct
 2022 08:06:12 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 08:06:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c931e83-5117-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666339577;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=oBBXKcPklp326C9bkH7mVNGCsVSdgT3RZmSK1wEZp14=;
  b=GldPad8qkegKJsWPLQsrbpYylMeSqo4MILsb7liKbOW1IFpHecerA8a0
   zETvgigOH+zh6V6vyeDEO5vR4rb5YiN5rqr0Ut+kbI04UQfULnvqRXn+R
   8MpkDsVKcqa0AhITMfJxLifw2ipQRl2QvNXNQ9jSr196FrN0myITlgYBu
   Q=;
X-IronPort-RemoteIP: 104.47.58.103
X-IronPort-MID: 82849266
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:pm5NUq6ExJp9NEP1qoqnkAxRtGjHchMFZxGqfqrLsTDasY5as4F+v
 mMeDWuFb66NNGGmetl+Po7j/BkB7cXVztAyQQZl+3wyHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZnPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5aXCJsr
 NMSFQxUYz6Cmuuag52ccuJV05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLl2Sd05C0WDbRUvWMSd9YgQCzo
 WXe8n6iKhobKMae2XyO9XfEaurnzXmrBNNISuPQGvhCm2bO4jU0OTgveGSG5tOC1GCeQ4NkJ
 BlBksYphe1onKCxdfH3RzWxpH+JuE5aV9c4O+818gaW0YLP/h2UQGMDS1ZpbN0gqd9zRjEw0
 FKNt83mCCYps7CPT3+ZsLCOoluaKXhLBWwPfykJSU0C+daLiIs0lBPUCNF4DLSykMb2CBn32
 TmBqCV4jLIW5eYX2KGr1VTGhS+wvJ/PTx5z6gi/dmek6Ax+TJSoa4yh9R7Q6vMoBIqQUFTHv
 HECgMWYxOQPC4yd0i2LXOgJWrqu4p6tMCXVqUx+A547sT+q/haLbY1WpT1zOkptGsIFYiPyJ
 l/evxtL451eN2fsarV4C6qpBtgn17rIFNLrTPnYY9NCJJ9re2e6EDpGYEeR2yXhlRYqmKRmY
 ZODK5/0VjAdFLhtyyewS6EFy7g3yysixGTVA5fm0xCg1rnYb3mQIVsYDGazgikCxPvsiG3oH
 xx3bqNmFz03vDXCXxTq
IronPort-HdrOrdr: A9a23:LoL846hBX6pYAe1qXO/U7LMD1nBQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+
 O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208";a="82849266"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MPNGgz2deE7FY6Rf9LzkGjBk3JSbMRSCvJf/AnoIdhWpBEGvR16XNPmAB+8GrBx9uHUsuIzYuSo0BPuMCwdmknp50HmuEj42et0oXpEtVHNT9Le8eoy/pRkqpAIRSeohrXVpKCstQgAdJpGW8ogIWQrjncRJlhqjCklrpZbTrZvpH5Ok2zkjKRUR0N6FAF2gjdg5veiz7UQciw0WPAiXTxxW9YCfNe3RL/dYazLp2Kr+JETxj8E2hVAFQ9PmxjLdpuAQHQCOO2zNLcvcvSq0pumFFGSnqj9h3Jg3X0innwp7xwCgE6wfQNGWpm1DHj/0rwSQO3OyLeEJuYJOtQIRow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oBBXKcPklp326C9bkH7mVNGCsVSdgT3RZmSK1wEZp14=;
 b=CTwFINXPamva51jFdFtys3sJtBOdj9XIv3BxXZWM7ePd0CRr4wWJ04iJg9o8lfiLq+fVqzCsC53xzwNzXHs8FjhkJAx/g9XmqDoGIJTylGqhtP2GWeA9lm5z5PRYZecW6DvhkO9ipHUHhreIrKocCzBqjbpcBCSNcL8XZdjJKzhHm/8xOXk4KWKt4jWRAHFHDkQSpcfzIWwBaEAzFy8whk7KctFOQvSSxcbYQJxmrPUO28UFbP/4mkucMfp+TO7lfyluyRwGVmAxw6VjwWT8dbtoIyVk8vZe+7xwtgK/fGDM7Vy/OB8SOpEXCA5RUi3OEfxZntjBiOLsiS7RqmbaSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oBBXKcPklp326C9bkH7mVNGCsVSdgT3RZmSK1wEZp14=;
 b=l1PJ0/FpLC4LLKhAAWC2STBDMuHKg70zBAgmCjdcWl6lnjkXhhfJaf751qVXDexRkA1xaxUFXW6OMb7m8hUyYdPF4VZpiaSNV7M9HyYYEccEnyKnpPCJZbJRE04xwXMqqojqUbEB3qHC2JZXZ3y8X/cnOBJ5RjG6PiZZq1GE/2A=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Borislav Petkov <bp@alien8.de>, Juergen Gross <jgross@suse.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>, Boris Ostrovsky
	<boris.ostrovsky@oracle.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo
 Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, "H.
 Peter Anvin" <hpa@zytor.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "Peter Zijlstra (Intel)"
	<peterz@infradead.org>
Subject: Re: [PATCH] x86/xen: simplify sysenter and syscall setup
Thread-Topic: [PATCH] x86/xen: simplify sysenter and syscall setup
Thread-Index: AQHY5Hg6cWouKk4hAkKcpxKDANECg64XKDGAgAFW1YA=
Date: Fri, 21 Oct 2022 08:06:11 +0000
Message-ID: <bd3e990b-e2a7-bbf0-7e2f-259e6a353393@citrix.com>
References: <20221020113619.17204-1-jgross@suse.com>
 <Y1EzXQP3/Pn3bme+@zn.tnic>
In-Reply-To: <Y1EzXQP3/Pn3bme+@zn.tnic>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN8PR03MB4977:EE_
x-ms-office365-filtering-correlation-id: f5ae6c2b-07ca-4e78-1d0c-08dab33b1e10
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 wsT0uQx+PfonUVCQ3aNLODgNCReWAXKEb7UPVF5P7zUlbFRDSEKJ/IqUw1DKo7C7PjaSocmYS5Qa7r8yLKnaEj+5B/KxRSCWO9LOyuireZwxRh6LgN/OJXmRXTufNmcJkj/hRahiH+qRHjJOgbkKBgt5OFG1HFCfstxlSVvUkXHjTQ11ZXErcXGmmzz7CbO3SJlmRoDnLwCa54NkPT8mxzwoCby5euttz7vdFbKSCNaItLoI2IWQkIXZpMnoQtyXWGUbhL3H6Vtw006g+447B8pRiVovCnB+wwbTWD//elS9oswOgCqGTt339/uNk838UYXEJiP8LH+18O9OXKxOmtPCeeg3zxvy/mDx1L2Avwn9JxTDM1uvaTiEypvth3YQtC52oeYMUawEnRQujt2S6KSb/aiOoR1pTsHbgZ1h5aZHiD3IJQ5eZVJbh2U6HI41qNTK3t94Vm7zuqMc6du8fI2cbkMZhoo1kC398piytAsmfdlYYFjAwSJ5orzYAPCEIsu72q4Mm8GAH5RmIHAJrBa7R0ppj/H2OZgo1aw9BnTyBR2du5wO/ASpZNEugyd7pae0pC3YHvdrlybYBxd8WE06fm3yPcWU/v1iPfUD9JVsci/2ZcQ2fPY5p9vMGxpm1EnjlqJDCzn+Wnln76GER7179j8O0mkTEMFFuAcTKCYTDGOeITjry5SbLjjK39FLkcZBY1SByCF1Ph0jOWNAfqIGIJNsJWnF4IH+QWQa3DJKfbXLrUQUocj/gpdwhMXU6liURWbDcyipKGmNasWJAGGWbSxgOOp+4Ug4oISmdH/j7I/IXaCY6OXscvYTZ4Y/YKY5K0k23cuv4/kyHgwm7g==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(136003)(39860400002)(346002)(451199015)(6512007)(83380400001)(186003)(53546011)(6506007)(76116006)(2616005)(66946007)(64756008)(66446008)(26005)(8676002)(91956017)(8936002)(66476007)(4326008)(2906002)(7416002)(478600001)(5660300002)(54906003)(110136005)(316002)(41300700001)(6486002)(71200400001)(66556008)(122000001)(36756003)(31696002)(86362001)(82960400001)(38100700002)(38070700005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dU02QjRwbFVDajJLL2d5QnVKVkt4dklrcXFQY3dUN3FBc1c5OGZ6YVY3V0E0?=
 =?utf-8?B?aS83OFM2T25zWHc0UkFrTEl4NzU1Y1ROK1dlRFdaR1k2REVZKzQ1UkFtN0FS?=
 =?utf-8?B?OFpxbWU4YmJEYkFaQTF4T1ZZWjh3Ukg2LzZtN25JZjBhZStDNHhJNjZuakda?=
 =?utf-8?B?b1E2ZFdLWmIyS2h3emRJQ2xaY2Jncndua0ZvQmZxRjk5WCs5S2JLSzhoS3Jm?=
 =?utf-8?B?bys5Q0pmS1k3dnRPVWdQRmd3S2k2T2V6TEpYUEpxd2p6RWFYRGJUY1dHS3hn?=
 =?utf-8?B?YVJZNTAvVi9URTc2ZWZaQzAyZThieTBpaTlxRUxyRDF6dmdNRng0SVcxZ3NJ?=
 =?utf-8?B?d283c2ExVU0yOVJrTjYreFB3eXVRbnBuSUZKWjJGbDdCblU1ZjM1eWIzNFRO?=
 =?utf-8?B?YlZQdFdjWG1oM0dETzF6azlCTXZDc0dPNmc2MGk0U0liMHhQd3cwTnNXdGZL?=
 =?utf-8?B?NWpOVzZtMVJTVHExSXNiVitqRVRkamU2T01KQ0xiSC9YcmhtUTdySWtRRWVX?=
 =?utf-8?B?SnFmSXF6bVBSSjM4V3RDTkEyNTRBOHVZbldZYm00blBHTUFXd3BFQktxL29x?=
 =?utf-8?B?cEhHKzJqOUhCY2c0YUFZSDBsRnBlRmE5M3RsWXp3RHlTTVhIdUVFT290Q2ZH?=
 =?utf-8?B?QWVHQlUrSHRVejVBbHk3b1ZqZ1VOYjQvRkZEdWxpSTdCUC9ZNGYxZTh5Zkht?=
 =?utf-8?B?bEV6SU1taUdveUQ0bFVUZzM4VUhQWEdNa0dXQkZYN0ZSZVppNDdNMEdvUUY0?=
 =?utf-8?B?UlhWZFdmMFR5SGE0UTJGQ0g0cGpSaHRtUnUvZmFBcWM2blM2QnNUQUJsMmgz?=
 =?utf-8?B?TUVMYWdmemlacll2YlZqZ29rYm9WWmROM25mNWdxOFJOTW5WOXQvQmlxR3JL?=
 =?utf-8?B?OWltN2tUdzFUb3B5aHoyemhXNktFSlB0cllrNGpCSmE2TjR2TGlKbWh2eTQ0?=
 =?utf-8?B?MWF0TGlEcGJrR3JISXp4cTJLdmlWYVllaUNkK01CNHN3WHNSN0N5ckp1SGt5?=
 =?utf-8?B?a1VqdWZoZWpidDcxT1hSRXh0d0pGRENWS0FLejVMUXJ2eFg1U0YveWh5ak5B?=
 =?utf-8?B?MlFYN2ZJUWxwRDZLUjhSd29yY2QvaURUWUNFQnpCNmNCMXVKMFdvaDZjaGNR?=
 =?utf-8?B?dm5RaGlCRUUzc25uVUdrOVpIc09UZ3B3S0ZiR2JYVkh5ZW9OM2NZWlF1NzN5?=
 =?utf-8?B?aDhvMURuQWpueldtcWd3Yjg5RkNCM09qdThwNUwvS21xbFFaQUJqNDBmaWtU?=
 =?utf-8?B?TDU2RFFsLzNiQlArYWE2SW1SNTZ0WkpkRnNnaDFiSUlyNGsvM2F5TnpxRG1U?=
 =?utf-8?B?ZTNYMFRGb2EzaEF4RjQ4MjcwWk1XYkZGcDZIQ2xXaTM2ekk2eXBMcEJKZ3pZ?=
 =?utf-8?B?bkpBbitidHlOV0svVk9TbWk2N2dXN0I2STg5ZFMyNmd0cnIyOEJBZUM3d2tx?=
 =?utf-8?B?WDAreFZaMEZ6OEJEWnY1a3poS2E0aGplc1g2VlBvWDRYRFUzYTZTa3NYMk1k?=
 =?utf-8?B?bTFIVUNIbGZiVCtHRkZVR0QrN01PT1BvUWxENlpXZkhpNm4ySDFqeHJ1SmZD?=
 =?utf-8?B?V3UwVm5MVm1aWGROcmlZUHR4angvaThlKzhzUHpTejFmSWhnU2lLN0dkOVoy?=
 =?utf-8?B?MUlmYmlveTBFblhDTFg1dEpGZXVpUTdwbVArV3BURDA1N214OHp3ZnFpZDdB?=
 =?utf-8?B?ZG1pemlsMVlLWHd4RE1NbUxCTkV0SGVRQnd0NEJTWFdUK3ZXbVNwWCtDc081?=
 =?utf-8?B?M09RelIzaXRqOTA5bkdPS1hVdElEc0dkeFR2MXZ2ckllSjFJQnRkV1hhT2sz?=
 =?utf-8?B?UFJJY3BudCtoUVhvYU9hb1pTMmV3S2pPZTIwTXYvcXozamd6ZkRISEhqZ3NF?=
 =?utf-8?B?M29wZjNHbXJXWk9yUkQ5czBYNW12SmpNMTQwSjI1aGUzV0dwSDhSQldMNkpZ?=
 =?utf-8?B?MHhkWlgrVEFIUFowR2d3Q3hSQWlMUXRURWFscjk5VU1abG9DMTJ5RUNoVXhX?=
 =?utf-8?B?RXkvRzNidFVPMkhLaDFqb3c3K3hueG5BZDZxNWhVb1JjMTVweEJtcVVOYVlR?=
 =?utf-8?B?K2R5MlRsQjlGNHVxMmZxSm41SzFXOXhXdER5UU1hdCtXRkVBeEpWZWh0dTlm?=
 =?utf-8?Q?WLzDVy1W6RWD8Uc5A5QahPBZC?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DC66E6DB72847C488FB88ABB5CB81418@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5ae6c2b-07ca-4e78-1d0c-08dab33b1e10
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 08:06:11.4848
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: n9W5pmHAXYfpBen5DniHkn6uYDodX6bJF8IjNbdy+CaeqPFF1K0DmyhaJyYXzFAw+ClEX/UK4Vdo2Q2tNcdact9RC95LfhpnnOxyhYr3gWY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4977

T24gMjAvMTAvMjAyMiAxMjozOSwgQm9yaXNsYXYgUGV0a292IHdyb3RlOg0KPiBPbiBUaHUsIE9j
dCAyMCwgMjAyMiBhdCAwMTozNjoxOVBNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4g
eGVuX2VuYWJsZV9zeXNlbnRlcigpIGFuZCB4ZW5fZW5hYmxlX3N5c2NhbGwoKSBjYW4gYmUgc2lt
cGxpZmllZCBhIGxvdC4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv
c3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+ICBhcmNoL3g4Ni94ZW4vc2V0dXAuYyB8IDIzICsrKysr
Ky0tLS0tLS0tLS0tLS0tLS0tDQo+PiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwg
MTcgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3hlbi9zZXR1cC5j
IGIvYXJjaC94ODYveGVuL3NldHVwLmMNCj4+IGluZGV4IGNmYTk5ZThmMDU0Yi4uMGYzM2VkNmQz
YTdiIDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYveGVuL3NldHVwLmMNCj4+ICsrKyBiL2FyY2gv
eDg2L3hlbi9zZXR1cC5jDQo+PiBAQCAtOTEwLDE3ICs5MTAsOSBAQCBzdGF0aWMgaW50IHJlZ2lz
dGVyX2NhbGxiYWNrKHVuc2lnbmVkIHR5cGUsIGNvbnN0IHZvaWQgKmZ1bmMpDQo+PiAgDQo+PiAg
dm9pZCB4ZW5fZW5hYmxlX3N5c2VudGVyKHZvaWQpDQo+PiAgew0KPj4gLQlpbnQgcmV0Ow0KPj4g
LQl1bnNpZ25lZCBzeXNlbnRlcl9mZWF0dXJlOw0KPj4gLQ0KPj4gLQlzeXNlbnRlcl9mZWF0dXJl
ID0gWDg2X0ZFQVRVUkVfU1lTRU5URVIzMjsNCj4+IC0NCj4+IC0JaWYgKCFib290X2NwdV9oYXMo
c3lzZW50ZXJfZmVhdHVyZSkpDQo+PiAtCQlyZXR1cm47DQo+PiAtDQo+PiAtCXJldCA9IHJlZ2lz
dGVyX2NhbGxiYWNrKENBTExCQUNLVFlQRV9zeXNlbnRlciwgeGVuX2VudHJ5X1NZU0VOVEVSX2Nv
bXBhdCk7DQo+PiAtCWlmKHJldCAhPSAwKQ0KPj4gLQkJc2V0dXBfY2xlYXJfY3B1X2NhcChzeXNl
bnRlcl9mZWF0dXJlKTsNCj4+ICsJaWYgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TWVNFTlRF
UjMyKSAmJg0KPiBDYW4geW91IHN3aXRjaCB0aGF0IGFuZCBiZWxvdyB0byBjcHVfZmVhdHVyZV9l
bmFibGVkKCkgd2hpbGUgYXQgaXQsIHBscz8NCg0KV2h5Pw0KDQpUaGlzIGZ1bmN0aW9uIChzaG91
bGQpIGJlIGNhbGxlZCBvbiB0aGUgQlNQIG9ubHkgKGJlY2F1c2UgWGVuJ3MgQVBJIGxldHMNCnRo
aXMgYmUgc3BlY2lmaWVkIHdoZW4gc3RhcnRpbmcgQVBzKS4NCg0KV2hldGhlciBpdCdzIG9uY2Us
IG9yIG9uZSBwZXIgY3B1LCBpdCBkb2Vzbid0IG1hdHRlci4NCg0KY3B1X2ZlYXR1cmVfZW5hYmxl
ZCgpIHB1dHMgaW4gYW4gb3V0LW9mLWxpbmUgdGh1bmsgKHdoaWNoIGlzIHdoYXQNCmFjdHVhbGx5
IGdldHMgdXNlZCksIGFuZCBhIHBhdGNoYWJsZSBjb2RlIHNlY3Rpb24uDQoNClRleHQgcGF0Y2hp
bmcgd2lsbCBoYXBwZW4gYXQgbGVhc3Qgb25jZSB0byBvcnBoYW4gdGhlIG91dC1vZi1saW5lIHRo
dW5rLA0KcHJvYmFibHkgYWZ0ZXIgdGhlIGxhc3QgdGltZSBpdCBnZXRzIHVzZWQsIHRoZW4gdGhl
biBtYXliZSBhZ2FpbiBsYXRlcg0KdG8gY2xlYXIgdGhlIGZlYXR1cmUuwqAgRXZlbiBpZiB5b3Ug
aGFkIHNldmVyYWwgbWlsbGlvbiBDUFVzLCB0aGVyZSdzIG5vDQp3YXkgdGhlIG92ZXJoZWFkIG9m
IGNwdV9mZWF0dXJlX2VuYWJsZWQoKSBpcyB3b3J0aCBpdCBoZXJlLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:14:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:14:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427416.676438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olnAR-0004Jl-MS; Fri, 21 Oct 2022 08:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427416.676438; Fri, 21 Oct 2022 08:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olnAR-0004Je-Jb; Fri, 21 Oct 2022 08:14:11 +0000
Received: by outflank-mailman (input) for mailman id 427416;
 Fri, 21 Oct 2022 08:14:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=opYQ=2W=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olnAQ-0004JY-OJ
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 08:14:10 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32429e1c-5118-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 10:13:09 +0200 (CEST)
Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com
 [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-632-arVwFlfzMYW4mpJfNF84Gw-1; Fri, 21 Oct 2022 04:14:04 -0400
Received: by mail-qt1-f197.google.com with SMTP id
 22-20020ac85756000000b0039cf0d41e2cso1849961qtx.13
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 01:14:04 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 x12-20020a05620a448c00b006ec5238eb97sm9314643qkp.83.2022.10.21.01.14.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 01:14:02 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32429e1c-5118-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666340045;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=M1oGuY3hYz1kP2fGJ81Oc7oOoKcRc84nCKNZWEROOKo=;
	b=fjFUuOLuT0D4e2fMq1yTS03ykSDK6ojaOUG+fkN/1BAJDkkpNu0KpeYsYjH7fuwFH2mPcw
	6S2MHaQSkzdIyrXYoI7GAw2y5ZkUH5xryBSXPIdfShQf2h/YeVZ4dP9MislSiYv/N7HjhI
	l0/GqvNwDBmyqPXNyLB8jhOdmECyYAA=
X-MC-Unique: arVwFlfzMYW4mpJfNF84Gw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=M1oGuY3hYz1kP2fGJ81Oc7oOoKcRc84nCKNZWEROOKo=;
        b=6rZRvrjBeCot99xXcYLdlUgumuZb7N3BBXImw06MjcaY+CVNWSMgFSvqVpe31i2eYR
         84ChLcsv+qN2/NJtD+eWJBL9T77bLl4aQSt4LoVdkNNiKWWjTCN1iA0Afdyw3OKHWWOX
         sN2+ecsM1e9Qig7VgCQ3lWmzUYY0CTYldqU9TmnuJKT6B2qgqM9s9mdELoQ50edefNHC
         HiyHThqKVaccoH8fsz6dRPcvHV5xduQwEWs6ocXJFiDlIy1xX9qXA994IdhUlHLus/1u
         PgVwOnZ+XTZVA1ZW6uqhofRGjdotP6OxMsxKNTq/eddbjglQ9tmJEtQvTHPLPevh3mRM
         FdoA==
X-Gm-Message-State: ACrzQf1CGS1lkFz9p5tJiTrbMY9llmWdO9ytfAqhvYPPQBhtVWwPx8T2
	FZFsq6rcDkS8oPRM4tSYv8jXv9pgY7Vmfck7qMi9+AvwtdD94Y6e0IYCbG15PMbcytbhYu+uD5v
	a72H+uymWMHmeN2oELdbfc54nlPI=
X-Received: by 2002:a05:6214:c66:b0:4b2:5ca6:8a84 with SMTP id t6-20020a0562140c6600b004b25ca68a84mr15316582qvj.110.1666340043927;
        Fri, 21 Oct 2022 01:14:03 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6EslkviabCZJhy0eEKOVBAOOvIh0Y7TqQQHkO5cMXDG3L45V/wluujErL+SDw5ogHtSxfBng==
X-Received: by 2002:a05:6214:c66:b0:4b2:5ca6:8a84 with SMTP id t6-20020a0562140c6600b004b25ca68a84mr15316560qvj.110.1666340043675;
        Fri, 21 Oct 2022 01:14:03 -0700 (PDT)
Message-ID: <52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
Date: Fri, 21 Oct 2022 10:13:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Durrant <paul@xen.org>,
 Thomas Huth <thuth@redhat.com>, =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?=
 <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Greg Kurz <groug@kaod.org>, Stefano Stabellini <sstabellini@kernel.org>,
 David Gibson <david@gibson.dropbear.id.au>, Eric Blake <eblake@redhat.com>,
 xen-devel@lists.xenproject.org, "Michael S. Tsirkin" <mst@redhat.com>,
 Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>,
 Jason Wang <jasowang@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Anthony Perard <anthony.perard@citrix.com>
References: <20221020162558.123284-1-lvivier@redhat.com>
 <20221020162558.123284-18-lvivier@redhat.com> <87pmel4th4.fsf@pond.sub.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <87pmel4th4.fsf@pond.sub.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 07:48, Markus Armbruster wrote:
> Laurent Vivier <lvivier@redhat.com> writes:
> 
>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
> 
> Use cases?

This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost 
and to restart passt.

I have also a patch to add a "reconnect=seconds" option, but I didn't want to add it to 
this series.

> 
> Could similar event signalling be useful for other kinds of netdev
> backends?

I was wondering, but it becomes more complicated to be generic.

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:21:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:21:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427422.676452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olnHE-0005pC-GG; Fri, 21 Oct 2022 08:21:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427422.676452; Fri, 21 Oct 2022 08:21:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olnHE-0005p5-C8; Fri, 21 Oct 2022 08:21:12 +0000
Received: by outflank-mailman (input) for mailman id 427422;
 Fri, 21 Oct 2022 08:21:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olnHD-0005oI-77
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 08:21:11 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2befd6b6-5119-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 10:20:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7D1642293C;
 Fri, 21 Oct 2022 08:21:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 26F9C1331A;
 Fri, 21 Oct 2022 08:21:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rPgECHJWUmObUQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 08:21:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2befd6b6-5119-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666340466; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uX9o9PYJhdJZeUz3Er72UTs/X4+CPAFUfI3wOc5u00g=;
	b=Gwulg3eDAvYZL60xX8YC8AYdK/Y+3fT2EYVzsutcMyfhdoqktFypfC8dxYcag/ObZW62Fg
	dal3bLbIxfkzbvHy9fxKnqWut3e4Sv/FYsjcHadRZLbCMpitJS5J0Nj5M9yjiux/uUHPYk
	SfYexHwrzaYTBn43EEYeG/tzWYKjpII=
Message-ID: <6eb2c033-ea00-8015-fe4f-0438f9790b77@suse.com>
Date: Fri, 21 Oct 2022 10:21:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] x86/xen: simplify sysenter and syscall setup
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Borislav Petkov <bp@alien8.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "Peter Zijlstra (Intel)" <peterz@infradead.org>
References: <20221020113619.17204-1-jgross@suse.com>
 <Y1EzXQP3/Pn3bme+@zn.tnic> <bd3e990b-e2a7-bbf0-7e2f-259e6a353393@citrix.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <bd3e990b-e2a7-bbf0-7e2f-259e6a353393@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------WavFKfeHApFt8Lp6zKlzfJ03"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------WavFKfeHApFt8Lp6zKlzfJ03
Content-Type: multipart/mixed; boundary="------------uP38kK7JYLb5sWnjgN4evDg9";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Borislav Petkov <bp@alien8.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "Peter Zijlstra (Intel)" <peterz@infradead.org>
Message-ID: <6eb2c033-ea00-8015-fe4f-0438f9790b77@suse.com>
Subject: Re: [PATCH] x86/xen: simplify sysenter and syscall setup
References: <20221020113619.17204-1-jgross@suse.com>
 <Y1EzXQP3/Pn3bme+@zn.tnic> <bd3e990b-e2a7-bbf0-7e2f-259e6a353393@citrix.com>
In-Reply-To: <bd3e990b-e2a7-bbf0-7e2f-259e6a353393@citrix.com>

--------------uP38kK7JYLb5sWnjgN4evDg9
Content-Type: multipart/mixed; boundary="------------NsylYV4bbPiEAniRCNr0uGoi"

--------------NsylYV4bbPiEAniRCNr0uGoi
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMTAuMjIgMTA6MDYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDIwLzEwLzIw
MjIgMTI6MzksIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4+IE9uIFRodSwgT2N0IDIwLCAy
MDIyIGF0IDAxOjM2OjE5UE0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4geGVu
X2VuYWJsZV9zeXNlbnRlcigpIGFuZCB4ZW5fZW5hYmxlX3N5c2NhbGwoKSBjYW4gYmUgc2lt
cGxpZmllZCBhIGxvdC4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg
PGpncm9zc0BzdXNlLmNvbT4NCj4+PiAtLS0NCj4+PiAgIGFyY2gveDg2L3hlbi9zZXR1cC5j
IHwgMjMgKysrKysrLS0tLS0tLS0tLS0tLS0tLS0NCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCA2
IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQ0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBh
L2FyY2gveDg2L3hlbi9zZXR1cC5jIGIvYXJjaC94ODYveGVuL3NldHVwLmMNCj4+PiBpbmRl
eCBjZmE5OWU4ZjA1NGIuLjBmMzNlZDZkM2E3YiAxMDA2NDQNCj4+PiAtLS0gYS9hcmNoL3g4
Ni94ZW4vc2V0dXAuYw0KPj4+ICsrKyBiL2FyY2gveDg2L3hlbi9zZXR1cC5jDQo+Pj4gQEAg
LTkxMCwxNyArOTEwLDkgQEAgc3RhdGljIGludCByZWdpc3Rlcl9jYWxsYmFjayh1bnNpZ25l
ZCB0eXBlLCBjb25zdCB2b2lkICpmdW5jKQ0KPj4+ICAgDQo+Pj4gICB2b2lkIHhlbl9lbmFi
bGVfc3lzZW50ZXIodm9pZCkNCj4+PiAgIHsNCj4+PiAtCWludCByZXQ7DQo+Pj4gLQl1bnNp
Z25lZCBzeXNlbnRlcl9mZWF0dXJlOw0KPj4+IC0NCj4+PiAtCXN5c2VudGVyX2ZlYXR1cmUg
PSBYODZfRkVBVFVSRV9TWVNFTlRFUjMyOw0KPj4+IC0NCj4+PiAtCWlmICghYm9vdF9jcHVf
aGFzKHN5c2VudGVyX2ZlYXR1cmUpKQ0KPj4+IC0JCXJldHVybjsNCj4+PiAtDQo+Pj4gLQly
ZXQgPSByZWdpc3Rlcl9jYWxsYmFjayhDQUxMQkFDS1RZUEVfc3lzZW50ZXIsIHhlbl9lbnRy
eV9TWVNFTlRFUl9jb21wYXQpOw0KPj4+IC0JaWYocmV0ICE9IDApDQo+Pj4gLQkJc2V0dXBf
Y2xlYXJfY3B1X2NhcChzeXNlbnRlcl9mZWF0dXJlKTsNCj4+PiArCWlmIChib290X2NwdV9o
YXMoWDg2X0ZFQVRVUkVfU1lTRU5URVIzMikgJiYNCj4+IENhbiB5b3Ugc3dpdGNoIHRoYXQg
YW5kIGJlbG93IHRvIGNwdV9mZWF0dXJlX2VuYWJsZWQoKSB3aGlsZSBhdCBpdCwgcGxzPw0K
PiANCj4gV2h5Pw0KPiANCj4gVGhpcyBmdW5jdGlvbiAoc2hvdWxkKSBiZSBjYWxsZWQgb24g
dGhlIEJTUCBvbmx5IChiZWNhdXNlIFhlbidzIEFQSSBsZXRzDQo+IHRoaXMgYmUgc3BlY2lm
aWVkIHdoZW4gc3RhcnRpbmcgQVBzKS4NCg0KTm8sIHRoaXMgaXMgdHJ1ZSBmb3IgdGhlIHN5
c2NhbGwgY2FsbGJhY2sgb25seS4gdGhlIHN5c2VudGVyIGFuZCB0aGUgc3lzY2FsbDMyDQpj
YWxsYmFja3MgY2FuIG9ubHkgYmUgc2V0IHZpYSBYZW4gdG9vbHMgb3Igb24gdGhlIGxvY2Fs
IGNwdSBieSByZWdpc3RlcmluZy4NCg0KPiANCj4gV2hldGhlciBpdCdzIG9uY2UsIG9yIG9u
ZSBwZXIgY3B1LCBpdCBkb2Vzbid0IG1hdHRlci4NCg0KSXQgZG9lcy4NCg0KDQpKdWVyZ2Vu
DQo=
--------------NsylYV4bbPiEAniRCNr0uGoi
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------NsylYV4bbPiEAniRCNr0uGoi--

--------------uP38kK7JYLb5sWnjgN4evDg9--

--------------WavFKfeHApFt8Lp6zKlzfJ03
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNSVnEFAwAAAAAACgkQsN6d1ii/Ey/C
bggAkxDmRLgLQ3prqBFrN51n3XUJr98tqT3lMGJtyzWNw2ihVqPrg9I1L9e672N4XYd3OYzurj5h
QGHTsALHrCHgw2Y1J0d0vpjj962ByY0hoDvEqcdR3BG8sC7Nlqk/zLUwRxwg9sEZ4X38obrltrZZ
6Y/2XXDvIaammWb64pcvZpyIXb6unPy+G0UL+5KJjGTJLNXLB/keaqWXTIqSKe6iXLE7w8aA274T
DPMOywd/dmpNN8yjzYX1rUC+V7jv5mNVMi5p6qAPg9JzeLSoPAU490Q33P6a5NiIf+Aja6Zsv2Zw
0U+tTnzNOxD6bt4fYF/W2PADwFU6VFw+6L6lK1LzlA==
=zF00
-----END PGP SIGNATURE-----

--------------WavFKfeHApFt8Lp6zKlzfJ03--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:26:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:26:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427429.676466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olnMR-0006bf-7H; Fri, 21 Oct 2022 08:26:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427429.676466; Fri, 21 Oct 2022 08:26:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olnMR-0006bY-3y; Fri, 21 Oct 2022 08:26:35 +0000
Received: by outflank-mailman (input) for mailman id 427429;
 Fri, 21 Oct 2022 08:26:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olnMP-0006bO-U6; Fri, 21 Oct 2022 08:26:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olnMP-0005om-P8; Fri, 21 Oct 2022 08:26:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olnMP-0001UB-Hb; Fri, 21 Oct 2022 08:26:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olnMP-00040U-H9; Fri, 21 Oct 2022 08:26:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kidNb4P87Z8GT6WQKoeOqxHRzzVTq5iy4L4U4hl3XFg=; b=27o9KJm4JFvK9u5Qq3qjkUNjFo
	YcljRvs7reP2KOKfj/VeYz85yekz8SBWqM1M8tyAfVL4l5GoIS3x211HcjjAL4oUkDfIjWX+K1X7s
	Vxd98qW7/ni8/4VtzRdeO/lUxg8xCD0IL0nhcm4kk8fzlJC+wbztItFHKB8P4DNS/uvQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174119-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174119: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 08:26:33 +0000

flight 174119 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174119/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174119
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174063 pass in 174119
 test-amd64-i386-xl-xsm        7 xen-install      fail in 174063 pass in 174119
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174063 pass in 174119
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173987
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 174063
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 174063

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd      12 debian-di-install       fail blocked in 172547
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174063 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174063 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174063 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174063 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174063 n/a
 build-armhf                   2 hosts-allocate           starved in 174063 n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   66 days
Failing since        173494  2022-10-11 13:38:08 Z    9 days   11 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    8 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 08:44:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 08:44:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427438.676483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olndR-0000dD-NT; Fri, 21 Oct 2022 08:44:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427438.676483; Fri, 21 Oct 2022 08:44:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olndR-0000d6-Ka; Fri, 21 Oct 2022 08:44:09 +0000
Received: by outflank-mailman (input) for mailman id 427438;
 Fri, 21 Oct 2022 08:44:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=opYQ=2W=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olndQ-0000d0-Nt
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 08:44:08 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85c44ef3-511c-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 10:44:07 +0200 (CEST)
Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com
 [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-612-oKeQ5cWLMm6vNCCiXxiRYw-1; Fri, 21 Oct 2022 04:44:04 -0400
Received: by mail-qt1-f199.google.com with SMTP id
 cc18-20020a05622a411200b0039cdeb3a699so1906203qtb.23
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 01:44:04 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 f7-20020ac84707000000b003431446588fsm7668132qtp.5.2022.10.21.01.44.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 01:44:03 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85c44ef3-511c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666341846;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OgtnC9HGsNuLdyZttExUaJKDQyO65ihPNHSrfyWjW4k=;
	b=Cgv0eDtpdgc+Ds5CmZdp9WFZoFpbWCp7mVGmz/nO11DMCyzS8DyDQomoc8G4JgQFJq3Ive
	LV/I5UQbgSAUmXiJk4v2OgD9uP3L8hdBIYbZpMG48ZdehS8OHg+B423Gv/KPKwa8Uuo9sM
	ADS7RxNSA5rxUr4pnP3EW2fqgDSJGIg=
X-MC-Unique: oKeQ5cWLMm6vNCCiXxiRYw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=OgtnC9HGsNuLdyZttExUaJKDQyO65ihPNHSrfyWjW4k=;
        b=Qju/N0Cgi5QXdTOd8ycztq8GL0nwVW7efDex9dFNqKMcRbZFEAADFm5Wu0q86GCS5K
         YOSgTrHLtHqgTbzJGP0tiayxfPMKwXZbroV94k4t6MhiCw3HPHUB7kG80Chn2xQdGgS6
         vdm3GwX0vErJqqriKtaZj+2h8BWl5UNTGkC3Qgl1tyqVpbIBLVI1eytmXVCIQzBX/so3
         WK0VNxDMKN9RCD6+u7EgtHMOVar4V/nIKvQzgSGAEnD63Rd/GXZEV5vRy3MaML40WsJX
         1BiuQPhQYcxJYsUmg/lChLdziqJf1ICUu/pP68VP1fTWO2WtWLHgVpVj44FMePKmJKyt
         suzQ==
X-Gm-Message-State: ACrzQf2p3ef5uUBUSEaRwSIdXmhd7Jd8IMtmpVQ3RmFqVicodxOe81Wa
	ws8AnL3wBPNJ9JGU1wNfxhQpG2XE2n7YkTJRZ/WVGoQ9iTZd6CnQJ8wM4AK6OsDApG7Ws5swbhn
	3+3tumF7fO+TMsVhUycm1aqHlIUM=
X-Received: by 2002:a05:6214:d08:b0:4b1:7127:f615 with SMTP id 8-20020a0562140d0800b004b17127f615mr15634939qvh.92.1666341844224;
        Fri, 21 Oct 2022 01:44:04 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6JJsnzxeixtY63ogvNQl94ky4fV5fZcMZxPyI0H491y9Vc3Mp02kLYSv2y4rUpZ7nrpzuTvg==
X-Received: by 2002:a05:6214:d08:b0:4b1:7127:f615 with SMTP id 8-20020a0562140d0800b004b17127f615mr15634924qvh.92.1666341843987;
        Fri, 21 Oct 2022 01:44:03 -0700 (PDT)
Message-ID: <b595c7fe-bf31-7cc1-e7ed-cad390875bad@redhat.com>
Date: Fri, 21 Oct 2022 10:43:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v13 00/17] qapi: net: add unix socket type support to
 netdev backend
To: Jason Wang <jasowang@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Durrant <paul@xen.org>,
 Thomas Huth <thuth@redhat.com>, =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?=
 <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Greg Kurz <groug@kaod.org>, Stefano Stabellini <sstabellini@kernel.org>,
 David Gibson <david@gibson.dropbear.id.au>, Eric Blake <eblake@redhat.com>,
 xen-devel@lists.xenproject.org, "Michael S. Tsirkin" <mst@redhat.com>,
 Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 Ralph Schmieder <ralph.schmieder@gmail.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221020162558.123284-1-lvivier@redhat.com>
 <CACGkMEt9Hoo=GAuCUqMcBjqNvs94fEPA_GU9Z7TOh8c7Wam55Q@mail.gmail.com>
 <87h6zx4qsk.fsf@pond.sub.org>
 <CACGkMEsnq2pFaLwBpzpCSiD8jZrx77SUTn_6JhGG9jKe1PJkwA@mail.gmail.com>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <CACGkMEsnq2pFaLwBpzpCSiD8jZrx77SUTn_6JhGG9jKe1PJkwA@mail.gmail.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 08:50, Jason Wang wrote:
> On Fri, Oct 21, 2022 at 2:46 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Jason Wang <jasowang@redhat.com> writes:
>>
>>> I've queued this version and will send pull requests shortly.
>>>
>>> Any future comment we can do patches on top.
>>
>> Please give Laurent and me a few hours to try to improve PATCH 17's
>> commit message.  Which you could then integrate without a respin.
> 

I'm going to send a new version, only patches 15 and 17 change.
I moved some changes from PATCH 17 to 15 as asked by Markus,
I have updated the commit message for patch 17:

     net: stream: add QAPI events to report connection state

     The netdev reports NETDEV_STREAM_CONNECTED event when the backend
     is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.

     The NETDEV_STREAM_CONNECTED event includes the destination address.

     This allows a system manager like libvirt to detect when the server
     fails.

     For instance with passt:

     { 'execute': 'qmp_capabilities' }
     { "return": { } }
     { "timestamp": { "seconds": 1666341395, "microseconds": 505347 },
         "event": "NETDEV_STREAM_CONNECTED",
         "data": { "netdev-id": "netdev0",
             "addr": { "path": "/tmp/passt_1.socket", "type": "unix" } } }

     [killing passt here]

     { "timestamp": { "seconds": 1666341430, "microseconds": 968694 },
         "event": "NETDEV_STREAM_DISCONNECTED",
         "data": { "netdev-id": "netdev0" } }

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:12:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:12:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427450.676512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olo4t-0004Kd-9C; Fri, 21 Oct 2022 09:12:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427450.676512; Fri, 21 Oct 2022 09:12:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olo4t-0004KW-6Q; Fri, 21 Oct 2022 09:12:31 +0000
Received: by outflank-mailman (input) for mailman id 427450;
 Fri, 21 Oct 2022 09:12:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1olo4r-0004KQ-QC
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:12:29 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 58245798-5120-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 11:11:28 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-593-qEtzvub4OaazuZhJHrPKIQ-1; Fri, 21 Oct 2022 05:12:22 -0400
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com
 [10.11.54.2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34F27101A52A;
 Fri, 21 Oct 2022 09:12:22 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id D804A40E9783;
 Fri, 21 Oct 2022 09:12:21 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id C5CC921E675B; Fri, 21 Oct 2022 11:12:20 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58245798-5120-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666343547;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qreRhXMURe1cGQAjM1jaeJIUg5mfmfbyjf20udgeVoY=;
	b=UZeSQTGXSbO62oZ5aXW86ELelgqf9/aT+9vue5dvE+PYTGje18NyCrxZ6T0ITcUVugyupI
	fb3C5ib59jRzmDsdES1h9Mo8sOdhDTghBAx4VB0Z6za0fHps7jKI6AVI+x1HR++Btzg7po
	1dL8NAjunRKxqkmJKV950io5n6nu8Z4=
X-MC-Unique: qEtzvub4OaazuZhJHrPKIQ-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Paul Durrant <paul@xen.org>,  Thomas Huth
 <thuth@redhat.com>,  Daniel P. =?utf-8?Q?Berrang=C3=A9?=
 <berrange@redhat.com>,  "Dr. David
 Alan Gilbert" <dgilbert@redhat.com>,  Greg Kurz <groug@kaod.org>,  Stefano
 Stabellini <sstabellini@kernel.org>,  David Gibson
 <david@gibson.dropbear.id.au>,  Eric Blake <eblake@redhat.com>,
  xen-devel@lists.xenproject.org,  "Michael S. Tsirkin" <mst@redhat.com>,
  Stefan Weil <sw@weilnetz.de>,  Paolo Bonzini <pbonzini@redhat.com>,
  Jason Wang <jasowang@redhat.com>,  Samuel Thibault
 <samuel.thibault@ens-lyon.org>,  Anthony Perard
 <anthony.perard@citrix.com>, Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
Date: Fri, 21 Oct 2022 11:12:20 +0200
In-Reply-To: <52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com> (Laurent
	Vivier's message of "Fri, 21 Oct 2022 10:13:59 +0200")
Message-ID: <87lep935hn.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2

Cc: Stefano Brivio

Laurent Vivier <lvivier@redhat.com> writes:

> On 10/21/22 07:48, Markus Armbruster wrote:
>> Laurent Vivier <lvivier@redhat.com> writes:
>> 
>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
>>
>> Use cases?
>
> This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.

Let's add something like this to the commit message:

    This lets libvirt notice when the connection is lost somehow, and
    restart the peer (such as passt).

Who's working on the libvirt part?

> I have also a patch to add a "reconnect=seconds" option, but I didn't want to add it to this series.

It's okay to mention future work in commit messages, but not required.

>> Could similar event signalling be useful for other kinds of netdev
>> backends?
>
> I was wondering, but it becomes more complicated to be generic.

Making something complicated and generic where a simpler special
solution would do is the worst.

Not quite as bad (but still plenty bad) is making a few special
solutions first, then replace them all with a generic solution.

I believe we should have a good, hard think on possible applications of
a generic solution now.

There is no need to hold back this series for that.

If we conclude a generic solution is called for, we better replace this
special solution before it becomes ABI.  Either by replacing it before
we release it, or by keeping it unstable until we replace it.



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:16:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:16:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427457.676529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olo8R-00051H-S1; Fri, 21 Oct 2022 09:16:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427457.676529; Fri, 21 Oct 2022 09:16:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olo8R-00051A-PG; Fri, 21 Oct 2022 09:16:11 +0000
Received: by outflank-mailman (input) for mailman id 427457;
 Fri, 21 Oct 2022 09:16:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VH1f=2W=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1olo8Q-000514-KA
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:16:10 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe35db74-5120-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 11:16:07 +0200 (CEST)
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12)
 by DU2PR04MB9113.eurprd04.prod.outlook.com (2603:10a6:10:2f4::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 09:16:04 +0000
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022
 09:16:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe35db74-5120-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VCq46dwvJaXP9/6TjckZ5bqdMSgM5o/XbLN2E6fYfz41AxWrCVy4j44evJobGYC+oyeSkE7azoLJCnYgjj5qnaL6BydVsrDVTQNRw1uCsjl3/jKbe5ZgmXJdkc4grIz4z+S02Q4WYGk3MP6a9veTgVSa2PyTUYVEUpqKgjwamSkS9s0DBQ1ZBV8LxFht7c3KOHtCvG3PUJKSfW3u5rC6afIYCvcjbQjThnNvni49/7E14mi/QQX/apeqhzP2j3plFWeRHrYsrWG0/Q9CLNJxZY37QwWbRwm55NuqBaRhjy9GzmVoR+SSH71dWT3Hc6tGDQtvw+eFItO3gGIRfdicUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yO0j/2y578dOj0tcJr9z1CwMrLdfXmWA9omaP0NToyM=;
 b=WTd1Ahug6EX7Q71wO7qFaWjKBmFevAvJ0GzQ20FXdNghmNSjISv/scoMAFCCdN2g2iMgUb1sXwLAn92Ga/W3FgGGNec3KDlCNqBXAokHx1mrQkhkDWdnftZ49KCW5yxQrYyn9F4vRXHrq93tBAjpwmwbSyH2elfmOEH8K6/v38xiJqCFyccVm0mQqS+yiqcqr7xF7yc6wUlK3kSXofNLfI9Zlp91Jl0kC5sAHRT0geNstT0U3LWVlunkY+U3yq0hP5Km/hCd1sPf58qbY1I9eQ5CfbSijdTDQHEKvmcArdu7CQWfk/fLK+Arq0fyUz27zm6QnKQ8sakvYrrgkgOoxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yO0j/2y578dOj0tcJr9z1CwMrLdfXmWA9omaP0NToyM=;
 b=A12qIZFu1xP7IRlIuJcthyJ0Hnj1JGvVQ/SKmLwhprtWKaBmZNfM2WB1+MApBZFDdMfjnTD6M8+Wt7JCr01afdNIDad/WUvNNWpQFLR/AKLgHwqRJQ6+60UleMi0c6v4uX22SRz3o9vmPuWuQekqn3qsWkJTJN5ILi0kEmDdOiQujxlu+0hBQz6dy19POV4X4VPVdAqa8wiC6woac/0LmBrZ56fMaB8AS83LB7Qd1VSaZjBDhC9L0eIO+aVkiEZlRw++yfUU0uLetJP7cmlic29TbyKvnM5+pD/SeFCpBkElF2R3fg5qeP7bfjGf0h9hdUsl3DdqcI+/GC3qya/Xpg==
From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, "julien@xen.org" <julien@xen.org>,
	"wl@xen.org" <wl@xen.org>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "Henry.Wang@arm.com"
	<Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Thread-Topic: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Thread-Index: AQHY5Rp63crRdqzTYU65u4+DFjIN7K4YbPgAgAAkTQA=
Date: Fri, 21 Oct 2022 09:16:03 +0000
Message-ID: <c90c17683100b77d614d90e108de0324c2eaf667.camel@suse.com>
References: <20221021065806.14316-1-jgross@suse.com>
	 <6ac5b62c-1679-b55b-e3aa-00ac395ce89c@suse.com>
In-Reply-To: <6ac5b62c-1679-b55b-e3aa-00ac395ce89c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.46.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|DU2PR04MB9113:EE_
x-ms-office365-filtering-correlation-id: d125e30d-00e8-4b7a-749c-08dab344e0fc
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 1I14s8iNhDyF+0NSlokBp4BYBbqNHGbnT6IHmeb5YWWA1n1xq+REVBLke9QX49fQ74LA1jDove3yxm1q8r1eiVUpf7wDI6G9NwyNdgNKaj0bxqvgS1DJpRdcQ7gtN80ISKFL0FfGbEx5yZqPX70cutPRk6kFAfYY6GYH9FDZv45ZwQPxErpY+b8gsgBEx8iDkrZRIyk5k5IMk71ILT6fC6W2kgzbxDGszcZZqm8mpk+DFTjNTXb2MdVF2yeCdbm5035sdlmApkEmCwCnf+X6qH3TeqGps3G2QBs4GItwfc8OphuzYzYP6E40zZwwINWIex1g+Pccit97mw7m1GRgo7IL3TwEywGE/fuZW6JjCBRP2ep25fAIA+dLDh461hJs3rmInMSkMEgt3siRYeCK5WzryBz1GzuTjuHGEqH6WGKcHkh7kUIUdl2IuNyeYaTKEj2F3Bxc7VvhHnj94X63O77EaNhMVMCtnr7nFoFg/X+Xn1G07iX4fr2yMZGi833rwOJYhJ4rFWiJatw8u2QHrHrt6t/hy6cIiudXleh/yK8yu2AqLWPNbzHflVukW+Br5rDEo/9tT8WJC6OdlgL6dSoHl/Z0USFX+RXLdt+BD1sAF+hksAsyNAX3Bgo8RuYxWQaVycvj4Qn+8c5pXCrOlauzd0hvPix4jVFGIL7zhIMiS2Zf99Mtw+aVZPsBQ3x0TkxSdtpoP5j6pjIpHoMgtbJqPzz8uoulwkNSduCFBmL3gtPN6LtzLmh061n+mkhIHc67HAVyI3X5nVZm5XziZQ8H+W5KPTbncCZMuBAxJT09KAQoqc6ZFMAnRQDgUJ5RYAYT1gqWa6tQfarxUG08lw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(53546011)(91956017)(186003)(38100700002)(2616005)(66946007)(6512007)(6506007)(5660300002)(26005)(4001150100001)(8936002)(41300700001)(478600001)(71200400001)(316002)(110136005)(6486002)(66446008)(4326008)(64756008)(966005)(66476007)(76116006)(8676002)(66556008)(54906003)(83380400001)(36756003)(2906002)(99936003)(122000001)(38070700005)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?b0ltYnRYR1ArNWpvM2VTQitoZyt3eG14SFJxTFZlOFNObWZ1Zi9TNWhDU2dD?=
 =?utf-8?B?MTE0OFNXYmVzdi9kOGh6UWdWWXNGTXBRMU5vZEJYa3RVQUNSNWp6cU96SytE?=
 =?utf-8?B?VVV0YVRWYVgwek5ZSVNYU0FySXFEN1NQUWd5d2RoMUZjdThvVk5BMmNDTVlU?=
 =?utf-8?B?WGI1ZC8zUkQzemtLYTZHd0UraU91WUYwTDBUY2xKVUxVUFhSZi92MG42Zjd5?=
 =?utf-8?B?SXozcTkyUjZjUS9JY3REVVpkUWg3a3lMUnh5MGlYaEVCVllUYzdSYlVibjhB?=
 =?utf-8?B?VWpxVGRMS000SHl4U2VsMXdKc3ZYc0ticjVrc0FiS3FlWHRSM1pvb2tJcm5j?=
 =?utf-8?B?OUZTMUdmS0hmRDYvcVdyVjdNNVZKNzNXVjEvd1o4aW9hbXNpSDBza3BtYzF1?=
 =?utf-8?B?L1Q3NlI0SzNQUy9JSFJ6M3lmVzR2M3d4TFJudGJKVHUxTXpVZmY5RnJob24r?=
 =?utf-8?B?Z3d1UHl3QWR4ZE9kVmFRTzFiRlBBMTBvYUF5SllqZFNXQ2JhZGxyOFhSWWt5?=
 =?utf-8?B?K2ZHZ2tTWHZxTWZhL0w3RUVYbHBhRmJwV0p1TjdMV1JPUHRNNkQwRkxwZldE?=
 =?utf-8?B?ZmhOR1Nnem0zUUNLMzJBV2tTUHJQdlNpSjB0ZG9tUVVuMGxGVzNQQWl4T1Jr?=
 =?utf-8?B?RzVVbWkvVTdOUEt0Y3pvM2RaVlcwck9oYy90R0VSQ0c0Q09EMjBoR3dSbnlF?=
 =?utf-8?B?YVhYRDFhUU0xdG5FaU5yNUFCcnpIRjhJWnhLQkNSZVhwc0RKaWRtSGM5cVFl?=
 =?utf-8?B?VTNaUnpKSnRVY3JTdjJYSkh0eUoyYTk2Tlg3UkVJQ21HdlZtVE4rWVhTcjhR?=
 =?utf-8?B?VTV3b1M2M00xZyt6enZ2T2JScFJiM0pKbmtzMk5Gb3gxMlR6aXNGeVBZRWNx?=
 =?utf-8?B?Z0NhWUJkakJaZEU5ZWU4ejZzbmtVSlBpVytPVk9Uc1FpbDBkS0NuL0Z1Tzlp?=
 =?utf-8?B?NWdUMWR3L2xyb3kwMWtsNzgyK1g2SGNJT0tUQlM5eVVVWGh4dk92R2wxSks1?=
 =?utf-8?B?ODVJY05rTmNZS3k1S0VYTU41R0RNNWR1SGkrWStlcmpqVTJlQWN5YmJ6dkto?=
 =?utf-8?B?NU9WekI0VWwvVVBvMWpuZTg3MVNCL1hCb09RSjQzTlFGMTU5bkhndzU1Qy9l?=
 =?utf-8?B?NmUzajVDTGJ6cTRvVzF6N2gvWVNFNkpTZ0xrZnBOcXdEZTRaZ3BNNWNub3Q2?=
 =?utf-8?B?RyttU3l5ZkVCbm9ISTE3K3BzazREYU5LaGMxVlkzVmNpdlQzZjBWamY0T0RK?=
 =?utf-8?B?RXk2aVQvUW45bTBNWUVMSHBHSHdWWDlmbmtRbXR1TUJnRjRNV05NOVZzSjhV?=
 =?utf-8?B?WXdEUmF2SjFaMFdVMHJ6bjg4aysycHMzSFZ6cnprYnUvUHVLT1NCSFpJVzFN?=
 =?utf-8?B?S2xYeDJJRlVHbDM0STN2cGtDemFTaGNtamVLUjlianEwdktrOG9iSlVlR29E?=
 =?utf-8?B?L2FkM21NemN0Zk9heWEzNkZETXU2c1Rxd2VBZzJKeUlqdzRDTG5OL0hMbGFM?=
 =?utf-8?B?ZVZqK0IrY2pnMUZCajMxYS9uNHk3dnhaclplSk0reVYyTEJxYlY0SkQwelhi?=
 =?utf-8?B?eTgwaGZ5U2E3Z3c4WGRvNWNWVlJZQ0cwOFEzdThBd0QvZXo0cEhXSHhaVXFm?=
 =?utf-8?B?Qnc2YkNsTG0xa2xBVHBRTXFpRW1LeEplMDBFZC9zeUNGaEpvdFpIaXF4dDhw?=
 =?utf-8?B?Ui9WWGQ5WFNYNTM4M25oellxTFFMN0FDV2lxRWJ5a2cwZ0k1NFlCQ1BnMVNK?=
 =?utf-8?B?RHVXbXRPcEVRUVdtaGVWRTdqVXBlcDJ2dUllK1hhTkx0NEUzSEphSTkycThi?=
 =?utf-8?B?UlNEYnEzdXpxZE9WSVpNcGFrSUhRQWl1R0V6eDViZDh1ZUZMYmdVck9IL2JF?=
 =?utf-8?B?V0FSbURjamtGNzgzc01YeGI2TkQ0VW9ocEpNSTRKTkViWWcxYnd1d0RhelNU?=
 =?utf-8?B?QkJORlRHeWFSakhIaFp5eUFlUnJud1g3Z1hFTU9zUVdFcVE4amZ2Q0RCSGtF?=
 =?utf-8?B?Q2ZndkRGa1FhMnZjZFIzZDZkSjdNWFY2N3JMSlNla05hS1FwNlRPSENkd1I3?=
 =?utf-8?B?T05pL2FGOVlkYzcyQkNEbUxqR3Z1Mkp5bmR3U2RNWGNaUGtxcS80dnlQSE0x?=
 =?utf-8?Q?QwwNbytL8u6KiG1bg+8IrRMGn?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-Cy9cMsz9GUKdVKBZA0bD"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d125e30d-00e8-4b7a-749c-08dab344e0fc
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 09:16:03.9979
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: P0mQnjti0T3GpckkC3A1wVo70D4P3SBAkVsxmY3UIM//MshE8/0alaO0xbiaOS9W9cmLV1id7/IpZcliTtl6Wg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9113

--=-Cy9cMsz9GUKdVKBZA0bD
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-10-21 at 09:06 +0200, Juergen Gross wrote:
> On 21.10.22 08:58, Juergen Gross wrote:
> > When the system is coming up after having been suspended,
> > restore_vcpu_affinity() is called for each domain in order to
> > adjust
> > the vcpu's affinity settings in case a cpu didn't come to live
> > again.
> >=20
> > The way restore_vcpu_affinity() is doing that is wrong, because the
> > specific scheduler isn't being informed about a possible migration
> > of
> > the vcpu to another cpu. Additionally the migration is often even
> > happening if all cpus are running again, as it is done without
> > check
> > whether it is really needed.
> >=20
> > As cpupool management is already calling cpu_disable_scheduler()
> > for
> > cpus not having come up again, and cpu_disable_scheduler() is
> > taking
> > care of eventually needed vcpu migration in the proper way, there
> > is
> > simply no need for restore_vcpu_affinity().
> >=20
> > So just remove restore_vcpu_affinity() completely.
> >=20
> > Fixes: 8a5d50dd0b04 ("xen: sched: simplify ACPI S3 resume path.")
>=20
> This Fixes: tag is wrong. It should be:
>=20
> Fixes: 8a04eaa8ea83 ("xen/sched: move some per-vcpu items to struct
> sched_unit")
>=20
Acked-by: Dario Faggioli <dfaggioli@suse.com>

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-Cy9cMsz9GUKdVKBZA0bD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNSY1IACgkQFkJ4iaW4
c+5N5hAAp3PzhaCR8w5rMQo4aDuDxw3ElTgH8+/7BTg8+/byMb4fHCtC693/au6h
WPBfofzgBEU66ruZaOaR04S4Ig8JOi2iawqt0kBDKBjjwTjVCCetNLPi4iC/6ViK
zrP3TMvHYRQth2AIGe5Bb+u9uJRSQvwcL1I4CGdOf7sdznaklgZY2jsOW3fTzPYh
98zFiwyDvAYT65wFOSPwtJ4jngy3ij1byv71AzdaQao2eS9odMoW6jPWz/KNrFXV
k4h4yanprDv3gIXLqbyFJSFNUM/8bmDLrPAPN7YLGzQloObmdDNyhvl7u4iVh/Fv
LeN+zHapdXqyTZpS2dSAhkwLrXOz7ER2zDB+e8sGhQz+fXi777gthOESeZ3AsOSi
rrK/IUlmAt1/vBHyDE7jFP6HaUuLEry0Barj/4WCAXw4HmmARAjmNomqnXfnh3ok
rjn+TFVwHJZPNQ5H4ZpIlhDyQhH6gG3qK8bOBBq6PTXQet7chBcM4Ij+i0tFM8GR
Kyt8t12c1asZ0pMDrKGRsZy0pKTvVPPpijY1JFalrWHmBbhG718hzBuxvOzT9VCU
dGcKdeG+UdrQvXAy2wWFcw0BxUms2PwP8x4zN2p/O3aSR/8azf7ZG+DG93uHSS4Y
AY8E5TSxCQoFiSlPDZad/Aoz3oBnfWq6GX7WY6/uyNS/x16qjeE=
=/p1c
-----END PGP SIGNATURE-----

--=-Cy9cMsz9GUKdVKBZA0bD--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:21:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:21:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427466.676546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloDI-0006Sx-KB; Fri, 21 Oct 2022 09:21:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427466.676546; Fri, 21 Oct 2022 09:21:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloDI-0006Sq-H2; Fri, 21 Oct 2022 09:21:12 +0000
Received: by outflank-mailman (input) for mailman id 427466;
 Fri, 21 Oct 2022 09:21:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oloDG-0006Sk-Gh
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:21:10 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b16c24c4-5121-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 11:21:07 +0200 (CEST)
Received: from DU2PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:10:234::11)
 by DBAPR08MB5655.eurprd08.prod.outlook.com (2603:10a6:10:1ab::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 09:20:54 +0000
Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:234:cafe::7f) by DU2PR04CA0036.outlook.office365.com
 (2603:10a6:10:234::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 09:20:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Fri, 21 Oct 2022 09:20:54 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Fri, 21 Oct 2022 09:20:54 +0000
Received: from 9ec6fed39e22.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 99AC81E5-215A-4A45-9389-262DAA10E83F.1; 
 Fri, 21 Oct 2022 09:20:47 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ec6fed39e22.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 09:20:47 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS1PR08MB7449.eurprd08.prod.outlook.com (2603:10a6:20b:4df::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 09:20:44 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 09:20:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b16c24c4-5121-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ZvAgAvaUAOwpVpWI8hUaGyZkdfepUgRbE2c8mPiO6O8wT3nXggoizWtgODQwO2nojJvkTTfwBv517X3h9mKE5HV0aRVTgrzHdll5SEXiLNfhxCugqhrPqBpqrbvJyt+S6XRACcOSw6tyAubflqv4GPyHvHTNimwg7Rgp++3Z2nY5mhQTyv48pQW4jYeDW3Q5I5TdwB+l/+GjDt/WbhTgvOgFBeDi9wRj1SR1Sjnqqlt9Hz8BnR8+2usNYvMF/FBc6SPYUlZ6SrjeSeH9DrzWoLPFcDOwFVmoOBLdyPCfzljz9WoD/4vmK4wL43bv4i+odAFBJgbeJLmT1/BPhlVfnw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QRo9cwduNcbGQfH3paCPshEx6Ju0ep5rgG2LRB/zWkw=;
 b=I0IpfCdNf2bNF4gjy90ONzLHra8TjnBwThAFTlXBUlIOcWDBaGz2mBSFPhbRze3Xc/qA7WtTwsVM+LCwc6kSX8hrSEAwz4CoCwuE08PUn59ZFbAlLwp+sptMnMdIIErOrOFeiYIPZS+iF+w87ox5pV+Y5Ci3ekdD9hGBokaDmgOirsd17exohg5xzjAxZBYRu4ELlyZdmSlnlxIe2QEV8651daRmlcY2eqAu0IdD5J+ejNV7j2ut/0ifBmV09eqfQWHFwsXApKEmnc3yVzvL1vaRCoRN3PieF/Jca3c4ciiuCLGA+i2eHW39WW3j7bDzd7/Jd2aP56gUwtN4M3yBWg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QRo9cwduNcbGQfH3paCPshEx6Ju0ep5rgG2LRB/zWkw=;
 b=z32D9oA0uBzBPm9E+KFKlrHDvTliG8RimmgmVQXj0RHCzfkueb1SQ+msdpsdwLyJt+Ie8kUrFcKycLASGs78k/upqupSMAo1zDsRcNRRvC6VRuNBMzTnw6IWmx4JMAQC51kmr8uzeInBAqn+UwdKK7bpNLJmZhvJ8vZOkigbGTo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gR7TBROpEb1ItZ4TWgD2carUnzcDe/eg91Vv2pJQQKxmUAfeDhqalwpFo5u8pbWfVfRAQpA1QJ7I1gHKIu/pF0ozocgEt+nQoH4cy1+09Hv7apfn85dReOFkVd5TrK4qysqSjF/JIjP+tSWJmBuQH9kogASgLyqxhtdItygUECVBtPQrCNkjQ1cxeTtpj38/KDsJYSS2fMYtQcJ43GGAEvowQyhzizLkbvXvSkUgnSKdhpY/Arx6f+06kWryJl3iDwBlccLZGN3jA/gAfyGKQI/SzXwbkrYUB4qAStN5ljuQLahkz8fsGfChePnTqYARMCv7H0s8mjHYGWznRYNX0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QRo9cwduNcbGQfH3paCPshEx6Ju0ep5rgG2LRB/zWkw=;
 b=StR10vsICyyFPNrjqSmmHV6T14aS34Q9CssU0+wpqdsj0R+7hrLUmnoP1NBz5x/eodXgZv1SzUCo5ye7X8uB+ibDimmo9c0fMPfABjwJmyp23668qLL3vE0GQL3Y8VSY+LlebXuCsPUJI0yFVe7rexDh0KNFSsf7c6CnIkVVWPCX5Qwg67KxjIxRRYe0ZNiiq0Rk7DGY1lN8vIQ9t4aj16td3IRTh4lrlbu4ZeiHtqVSMCG/hKIuLrsSqYgLj/drWfK0il3Lozj+NMqhsfZ5ezXmvG69iawS/38MYOlAlNabUwAOycZkJ8vA1zcpLMr5LTsjbIkU+PXiJI3/BvP6ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QRo9cwduNcbGQfH3paCPshEx6Ju0ep5rgG2LRB/zWkw=;
 b=z32D9oA0uBzBPm9E+KFKlrHDvTliG8RimmgmVQXj0RHCzfkueb1SQ+msdpsdwLyJt+Ie8kUrFcKycLASGs78k/upqupSMAo1zDsRcNRRvC6VRuNBMzTnw6IWmx4JMAQC51kmr8uzeInBAqn+UwdKK7bpNLJmZhvJ8vZOkigbGTo=
From: Henry Wang <Henry.Wang@arm.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Dario Faggioli <dfaggioli@suse.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
Subject: RE: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Thread-Topic: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Thread-Index: AQHY5RqBnzBJia4a50i9lxNo6dG1Ha4YknlQ
Date: Fri, 21 Oct 2022 09:20:44 +0000
Message-ID:
 <AS8PR08MB79915E4690AAB336937050DB922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221021065806.14316-1-jgross@suse.com>
In-Reply-To: <20221021065806.14316-1-jgross@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 40322221D150BB4995102D32E87D8A49.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS1PR08MB7449:EE_|DBAEUR03FT048:EE_|DBAPR08MB5655:EE_
X-MS-Office365-Filtering-Correlation-Id: 20c6708c-ff00-4231-e3c9-08dab3458e1c
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 G8CXawUF/4KzphPGg8yyXtTR+eEc+UzY42/KfKWa8UjbrBdJ7bf2VUAi1M8BLc6hr0ndNTUGqwsLbRqXPLLQS3TCIqYMDiaAxze1wi4mryJC+fAC1zDCYAnm0JLWc1SWIITndbrVfbzywBZ3a+3fM3TkSOdtll8/cURPKztyzN0vhojlVAyJPe1qqMtcWJug8+aA65nyMou1LLZiaOwfhse6KuEExxN7/p/yxZmh3KHYLY66QaZ6VzYlAi6SZWeARMQNgd768KC4FjPoi81twXe/FIMu6Z8P7NKzEttE5CoIuGcwyhgGv6rs7KhFCDeAbY6DV2luUqObSFy/fMenWe1iuF2bRjzSjtPfWI2OdGbmDO1klJ+gs8Fy4SO4gck9JUFlobu3D8MNcBUgeb/Av/sA5Fqzs4OBTFvv6gxp6A0flBx3Z8Jm8VgMNhFXNo4iZYKIdjJctJwrsfKlaX1/w5Ue/UfTzdc6xf0TRNJ3nNOeGINU7MkQqW+L+cPaJuExAHuibcbg8NQuHdIpOH06JeZLEwOPbygUlYRrdPPWxRlJLuNlhrKDxdogjVh1QjvEQuayRPV/S87pNfhxMQ4nypz9VHztwXURSYmDPRaCbp4IC929i0I/RRz0Cal4MBC+n+3hqzOx+EL4SDAVYGmOSUbFL6Dz4Idtf7xdqNTo6XqfzYT/ZJJx9o3DPDKcaEWxqi6N3WOEj3pPbPHV9c8g7bMKO9+JN89M7YDRUtKCOz1pJhbTnYMk6QgwCM9Umdvbo4TUANNW/GnPXDNVcfhtew==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(71200400001)(2906002)(33656002)(186003)(122000001)(478600001)(38070700005)(26005)(86362001)(66556008)(66446008)(66946007)(64756008)(66476007)(66574015)(4326008)(54906003)(38100700002)(8676002)(110136005)(76116006)(52536014)(8936002)(55016003)(6506007)(41300700001)(83380400001)(7696005)(9686003)(5660300002)(316002)(7416002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7449
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	56eb52c6-b15c-4749-0e89-08dab345884f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	K4OWmAlp1fOkTJNlpMW8vcRsqXAAPAPKItGKPaBoYBOAotnHsocudGBjU8WrEN6P2iHTrQ6cvSLGoba/K0Q3M2MbqUPo4/XBkmONC9W/5ZY/s+p5N6+jLNISlbPdWXKUvkCjbImpRGnHK2xgFbMbiI1qCqhhX/C2Vr+q/KP5CV/JZrRbP94OQGivu1BPpzJpXSBmu0KXdGz2wQT69Uoa5qhH9dlipXyt4lA9HlW0GlSrM5z7T1pVnMH09Gx9Nii/rQmOP048M9egxjU5tVcxT6fV8NpBlCVwLfvbrRCKl+9FLShOy946zM+zV97OV02GvDknFPGl4uEZQTysRnWbZM//tPCjbroDaxy2h/86FtOGl7V7Pf/J5DaFMED+L96S0GkNt+KtbP6v56Xw2izDd4MYMNrxbtVFgevww9Zw0RDcuGEaRIhOadq4p0CkZXgDKw3L2CBdAiYHYaMx06Vwllb3aK9BzHGRDu9z4VjyeNL50NRKCDfLlPYV0YsT4DgOjNJKHgwhvPm/gql+YqNX1QfuYB8DqE0Ds+LshQElMTg11fOpN7Gti2QpU1nOk5BIv3Xz77gP30cgkCu3YwjmmiE/c0x3geUrTbKBkyWQ6b7NkXenxBej5JIVurXz0nGqRQ7Afj/hw4fe/pSjJ64uwQOZ92J2SvEcnjumqoH6+pGwGMjZK0dXmwelXb5rDeHwy5d+M6b1OkmTzocs0bCvIY32FPb/Ff1aRaO1SDXNl1ujmUVtAMW/ee+XXJdZqjWfLDoVUlae5EWwHEdnJjn0OQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(83380400001)(40480700001)(55016003)(6506007)(47076005)(33656002)(82310400005)(66574015)(81166007)(52536014)(8936002)(356005)(82740400003)(4326008)(7696005)(41300700001)(70586007)(40460700003)(70206006)(86362001)(26005)(110136005)(54906003)(9686003)(2906002)(316002)(107886003)(5660300002)(8676002)(186003)(478600001)(36860700001)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 09:20:54.4719
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 20c6708c-ff00-4231-e3c9-08dab3458e1c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5655

SGkgSnVlcmdlbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IFN1YmplY3Q6IFtQQVRDSC1mb3ItNC4xN10g
eGVuL3NjaGVkOiBmaXggcmVzdG9yZV92Y3B1X2FmZmluaXR5KCkgYnkgcmVtb3ZpbmcNCj4gaXQN
Cj4gDQo+IFdoZW4gdGhlIHN5c3RlbSBpcyBjb21pbmcgdXAgYWZ0ZXIgaGF2aW5nIGJlZW4gc3Vz
cGVuZGVkLA0KPiByZXN0b3JlX3ZjcHVfYWZmaW5pdHkoKSBpcyBjYWxsZWQgZm9yIGVhY2ggZG9t
YWluIGluIG9yZGVyIHRvIGFkanVzdA0KPiB0aGUgdmNwdSdzIGFmZmluaXR5IHNldHRpbmdzIGlu
IGNhc2UgYSBjcHUgZGlkbid0IGNvbWUgdG8gbGl2ZSBhZ2Fpbi4NCj4gDQo+IFRoZSB3YXkgcmVz
dG9yZV92Y3B1X2FmZmluaXR5KCkgaXMgZG9pbmcgdGhhdCBpcyB3cm9uZywgYmVjYXVzZSB0aGUN
Cj4gc3BlY2lmaWMgc2NoZWR1bGVyIGlzbid0IGJlaW5nIGluZm9ybWVkIGFib3V0IGEgcG9zc2li
bGUgbWlncmF0aW9uIG9mDQo+IHRoZSB2Y3B1IHRvIGFub3RoZXIgY3B1LiBBZGRpdGlvbmFsbHkg
dGhlIG1pZ3JhdGlvbiBpcyBvZnRlbiBldmVuDQo+IGhhcHBlbmluZyBpZiBhbGwgY3B1cyBhcmUg
cnVubmluZyBhZ2FpbiwgYXMgaXQgaXMgZG9uZSB3aXRob3V0IGNoZWNrDQo+IHdoZXRoZXIgaXQg
aXMgcmVhbGx5IG5lZWRlZC4NCj4gDQo+IEFzIGNwdXBvb2wgbWFuYWdlbWVudCBpcyBhbHJlYWR5
IGNhbGxpbmcgY3B1X2Rpc2FibGVfc2NoZWR1bGVyKCkgZm9yDQo+IGNwdXMgbm90IGhhdmluZyBj
b21lIHVwIGFnYWluLCBhbmQgY3B1X2Rpc2FibGVfc2NoZWR1bGVyKCkgaXMgdGFraW5nDQo+IGNh
cmUgb2YgZXZlbnR1YWxseSBuZWVkZWQgdmNwdSBtaWdyYXRpb24gaW4gdGhlIHByb3BlciB3YXks
IHRoZXJlIGlzDQo+IHNpbXBseSBubyBuZWVkIGZvciByZXN0b3JlX3ZjcHVfYWZmaW5pdHkoKS4N
Cj4gDQo+IFNvIGp1c3QgcmVtb3ZlIHJlc3RvcmVfdmNwdV9hZmZpbml0eSgpIGNvbXBsZXRlbHku
DQo+IA0KPiBGaXhlczogOGE1ZDUwZGQwYjA0ICgieGVuOiBzY2hlZDogc2ltcGxpZnkgQUNQSSBT
MyByZXN1bWUgcGF0aC4iKQ0KPiBSZXBvcnRlZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3Jl
Y2tpDQo+IDxtYXJtYXJla0BpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiBTaWduZWQtb2ZmLWJ5
OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNClJlbGVhc2UtYWNrZWQtYnk6IEhl
bnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNvbT4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:22:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:22:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427471.676557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloE9-000750-3R; Fri, 21 Oct 2022 09:22:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427471.676557; Fri, 21 Oct 2022 09:22:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloE9-00074t-07; Fri, 21 Oct 2022 09:22:05 +0000
Received: by outflank-mailman (input) for mailman id 427471;
 Fri, 21 Oct 2022 09:22:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sW6B=2W=gmail.com=salvatore.bonaccorso@srs-se1.protection.inumbo.net>)
 id 1oloE8-00074j-8w
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:22:04 +0000
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com
 [2a00:1450:4864:20::52a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af2bedaf-5121-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 11:21:03 +0200 (CEST)
Received: by mail-ed1-x52a.google.com with SMTP id r14so3472357edc.7
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 02:22:03 -0700 (PDT)
Received: from eldamar.lan (c-82-192-242-114.customer.ggaweb.ch.
 [82.192.242.114]) by smtp.gmail.com with ESMTPSA id
 nb36-20020a1709071ca400b00780f24b797dsm11445031ejc.108.2022.10.21.02.22.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 21 Oct 2022 02:22:01 -0700 (PDT)
Received: by eldamar.lan (Postfix, from userid 1000)
 id 97626BE2DE0; Fri, 21 Oct 2022 11:22:00 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
X-Inumbo-ID: af2bedaf-5121-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-disposition:mime-version:message-id:subject:cc:to:from:date
         :sender:from:to:cc:subject:date:message-id:reply-to;
        bh=WXeFO3tUDl+b4UBpDrafdYBgxDIIGsV6RGnq49HKvNI=;
        b=hGMYaCIQsODSXmUvaY7dBUd2U2fMUgPvXW4wWk5uDSx1XjF78IynDgvKXOhCLulFBl
         8hXFr2eXM1Zx4OJNqXEkXVYSIhHAizQoeTh/jpsyv8RR4l3NzW63pGBrf42ZXbULdxTu
         S2O5YjTt49V8LazCHhtJvkJ2zVYI45/rFtbvbosZCKi27vi/GX0txr2FgCVjp6FC8uyI
         49MAsnenU1EKvKMcWv8IWfGIpCmXyObx+JdGzZ/7r8V8ZcTknvDVkzPpdCtH/VyqnZHU
         brE0r+V8+EcugxdCWjm5DOpRW45lXk9obU7MuHjbnGPc2BbpjVtF+Dpd3x+t23gdR/KN
         8PmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-disposition:mime-version:message-id:subject:cc:to:from:date
         :sender:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=WXeFO3tUDl+b4UBpDrafdYBgxDIIGsV6RGnq49HKvNI=;
        b=VTrVZMPwKHUEmNFn482oLYu7Qy3RcvG24YQ94mTe0J3C8epROmY4MQHtb2aqOj+SNB
         /ZV4ZWq9aXpoJHizmbyzbB+pUV80iYCSj4uf3hPmKsu5uVAD78Asy8jj1QW3xIYbBQDC
         eEqpr9Kv7/4umB53JURtYGrIgx5Yco0Q6WSmBCbzTk5D+tSi5a3aRx2yNT8jt4+3vZ7H
         YtPTPO8MIhv+qmUTBkXiSp6u+n1ydq+WEiRX6eBPFsfYmh5IQHIkj1FlYcQPfPs2HoAb
         SGPG4HrQ26xPhA9KiQk/DiSgdB5yx+T+cxXC0A0XHNOEpO/TD9eWIz0WTUe51L0ShPbO
         QpXQ==
X-Gm-Message-State: ACrzQf3avrkWqhhuY6yba5MjfdtEpraBgPDw3IQjNG/WL7VoiTws1bev
	iCWV990hUb+E3yzFUbIzlvw=
X-Google-Smtp-Source: AMsMyM6kVJkpq4aVxDJwEu5TH4lJhVBGtKdR/DRP6PPqVKrAR+U8WqfRUdPGImQBGmUZTH1RlEwYeg==
X-Received: by 2002:a05:6402:f18:b0:460:cf08:2b41 with SMTP id i24-20020a0564020f1800b00460cf082b41mr6034825eda.400.1666344122646;
        Fri, 21 Oct 2022 02:22:02 -0700 (PDT)
Sender: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
Date: Fri, 21 Oct 2022 11:22:00 +0200
From: Salvatore Bonaccorso <carnil@debian.org>
To: "James E.J. Bottomley" <jejb@linux.ibm.com>,
	sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com,
	suganath-prabu.subramani@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	MPT-FusionLinux.pdl@broadcom.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org, adi@kriegisch.at
Subject: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Message-ID: <Y1JkuKTjVYrOWbvm@eldamar.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

We got the following report in Debian after an update from 5.10.140 to
the current 5.10.149. Full quoting below (from
https://bugs.debian.org/1022126). Does this ring some bell about known
regressions?
On Thu, Oct 20, 2022 at 05:21:03PM +0200, Adi Kriegisch wrote:
> Package: linux-image-5.10.0-19-amd64
> Version: 5.10.149-1
> Severity: important
> 
> Dear maintainers,
> 
> with the upgrade to the latest bullseye kernel (5.10.149-1), our xen setup
> is unbootable due to swiotlb buffer errors:
>   | sd 0:0:0:0: scsi_dma_map failed: request for 401408 bytes!
> and
>   | mpt3sas 0000:01:00.0: swiotlb buffer is full (sz: 401408 bytes),
>   |     total 32768 (slots), used 0 (slots)
> (the byte sizes vary between boots).
> 
> After reading bug #850425[1], we also tried to force 32bit mode in the
> mpt3sas driver by specifying a dom0 memory below 4G; this lets the machine
> boot, but almost immediately after that fails with the same error. Notable
> difference is that the used slots are 128.
> 
> Xen commandline:
>   dom0_mem=4096M,max:4096M dom0_max_vcpus=4 dom0_vcpus_pin
>   ucode=scan xpti=dom0=false,domu=true gnttab_max_frames=128
> 
> Using dom0-iommu=map-inclusive in some combinations with swiotlb on the
> kernel commandline gives us some used slots (way below 128) in the error
> message even in 64bit dma mode in the mpt3sas driver.
> 
> The kernel works when booted without xen. We'd be more than happy to get
> pointers on how to fix that issue or patches to test!
> 
> Thanks for your help!
> 
> -- Adi
> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850425

Regards,
Salvatore


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:23:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:23:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427476.676568 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloFV-0007f6-Fx; Fri, 21 Oct 2022 09:23:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427476.676568; Fri, 21 Oct 2022 09:23:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloFV-0007ez-Cs; Fri, 21 Oct 2022 09:23:29 +0000
Received: by outflank-mailman (input) for mailman id 427476;
 Fri, 21 Oct 2022 09:23:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VH1f=2W=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1oloFU-0007et-Hz
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:23:28 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2072.outbound.protection.outlook.com [40.107.20.72])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 04f45a63-5122-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 11:23:27 +0200 (CEST)
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12)
 by AS8PR04MB8834.eurprd04.prod.outlook.com (2603:10a6:20b:42d::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 09:23:26 +0000
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022
 09:23:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04f45a63-5122-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=boUYgBlT5IBRArLnlv8G431/C2pKh+temL1vIueFP+QfYxMGg1f5vDP86ScrXtxzfDVfwZI7iM6SFX0npZ/AMXyIrjIwNMckqH0aF5MMaEGOL1FAEEKOedFbzkwlWMARcKIGqgvtPL1xqfri7okQJt5S6fpUInY85WGRhgrd4vP0D6Mgk3i9EFjYbO/pzSSt/Gvgb8+0LoEMarVOAMwAlNIM15sMVPukr1wlbNgpC62u+qQ06xvZghxnErclHTp9kKxDMlqoUf9qPfUODtbogVUbY5tzjSPJqBaxe1tTu6zInBajLV45YNkcBd1sAnOM6aKS4aksJB4NXpDw2rSz7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wx0rnd57G2IRJXD8NGFjsu49No24LVjnChtXOXFczLs=;
 b=BhvBm1BKaaUR1gBXPwe+8v2n8S/L+uGv3pVNz/feSKV36W1uow5M/yLpoN/HeN4MrgWnSoTGGOTGwB3prHSbKUcjwVFwpV5X23Z+cOnRyfKSsi6d5yvubJnojZrJ71zFV8vlYOF+EHv7i4qcWX7YdfuyJaRHTwfHJAu7+NXqUYmuKeWxJ+dONWJyvp8tlUyCYJOAtyQAEQ3DSzKiLIcJ5f7wnaeTkTe1S2qLjMZNhKOTDfEfjRI38PdEASLkSEIcPd9oi8c44s9UV3Tt8uPc7gFvCCldRXGdrRhjsDuqfzrdP9gYvqRwhA/an7N3IXrdPwVPlS6ah2vAmF5+nd0zGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wx0rnd57G2IRJXD8NGFjsu49No24LVjnChtXOXFczLs=;
 b=THr3TmdiZHBOAwY3CUH1P+K0AwSiFYOUnjbOyTSGQTZyaocTn7HUhUqsvSgsYka+yAXDEdOIjKTM/uwGpG116NfEDElT7zfbZ7AGttM8dym2RvlVrojJZUIifLclFld9D/KDH3MLwLK+mjiQzKnfky/iXjwJSqxB6vSIPii2qVhjwQ+GGGgmay/CKaarsEZNuwUoVcbBtIS3qwmo1Ch8voTRG2WL5E6W3YEXEZhKfs54ErsmhA5rMNcXkFn5GGx8GqYyyXV81WZk6GCZvMDRgBYjDrWFGLaZ+mtcmBfQmyr1BuVaOhlUMAIOM2Xtr5bEqiwT3jnznWL97f2gOholTg==
From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Henry.Wang@arm.com" <Henry.Wang@arm.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>
Subject: Re: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Thread-Topic: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Thread-Index: AQHY5RPdyv7HUa7jcEWPdT3S+dSn164Yk2EA
Date: Fri, 21 Oct 2022 09:23:26 +0000
Message-ID: <75b00338429b8d87a8adece923529899f7985354.camel@suse.com>
References: <20221021061042.12083-1-jgross@suse.com>
In-Reply-To: <20221021061042.12083-1-jgross@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.46.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|AS8PR04MB8834:EE_
x-ms-office365-filtering-correlation-id: 3d2f9d1d-f53b-4743-4669-08dab345e87f
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 hrtmES7+9UU0TPxbLz2JfCrtupI35GFEpq7eG1d170PcsamHK2oiwpVmFiM2o6e1ItuEYW5V0/B+8dj6TJyY2Epwq/Axn6MhoMmr3L9IlnrjE6Vt6iYo3bU9QvVsVdXoPws2wk6JCTfzAWE+N9eg2DNzQNfUkqqR6E1yhlbyG/Sq2+YLg9wo0KycaIdaBJlxh6S/VaMcNEBdyJqpKksedayf+MzHiNUICwv0Y0mSkenkEV+e+CWgYEKIfyvREhf+We1utpo/lZBTqoBZXv8a4c55bZ/y3FAGcGcaVQBGkrl+Qgyz5FIv28mfvJ2ZUnUHPKcweodOINdykd65hAmzKj/i5yo35YxmJGBDWWI8cLjEcKvQHKv4ahQG1d6y+b+vUatJu/idI8NNCCxvz0RcEY0iPpWoVGA4EGVOaFCHdJOmT+IUIIoi10zzm5b+1FRVxPQT6/vrtMrcSdD1IYp+9HLOk8Kb5wb4rGwH557bYmInNAjO0rhp41hM2t3JA9T3aYXJbEtSS1QxIihLEmHV3TAZUHdOOXwAkz4twyJe+ZS8Wy8/byWSa+jjyowJ66J9NlcKQN61ncTYuWt5m9rzbIgt4EeSsGybnDQvhl9/QEe8YtcBv27yBy5kvPUw23GoTErbuS8C/l4SuWVUhF8u078GvxZLTyYuYYaeWamDAqKjddeBetNIpXp9/FqEdXl5p55RbDK05J3kB7oeVXbyOnyydrrjtFbJAXlPNtauJvwlP+eszytMsAb28VGHef9F1LeHrF7F6FaRC7tuR/i4ICveS3gyCm8FDxVN+ye2wpWkcA1FIUUiRKvjbs+bAJj6iEwLgPlipurnkeTV+v4ksQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199015)(54906003)(36756003)(122000001)(2616005)(86362001)(4001150100001)(99936003)(2906002)(38100700002)(91956017)(38070700005)(83380400001)(6506007)(186003)(8936002)(8676002)(71200400001)(26005)(110136005)(478600001)(4326008)(76116006)(316002)(66946007)(64756008)(66446008)(66476007)(66556008)(966005)(6486002)(5660300002)(41300700001)(6512007);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?YXpTd2RnVmZRcHFVQU8vNE5zZjN5UExCYWtQdWpNQ2ZTQkdhbDJrQ0pXUGZY?=
 =?utf-8?B?MFh4S05xZFdZbUFsVkcyWEJyb0IzOHA4VzJKQlZWTThiK2x4UHRQdkxYWWlL?=
 =?utf-8?B?V05XMUNpdkFsbFM2ZzRacjhrZ0VweXBleWlPb0pDRHpRdDBaQ2d4bHkwaGp5?=
 =?utf-8?B?SmgzbHNwMUhjZ3MwUWNkUTIxTkc5dlhZVHlXd2VHd28vaVU4Z1V2SXY1R0RQ?=
 =?utf-8?B?NXZKenlSeS9FMDBub2E3TmFTZW1mQjIzd2VUUDI5YTJZZ0FKdlVIaE9kdUFk?=
 =?utf-8?B?L2FqTmxQRUxFUXNaL3JYeTRjUEhyb3dlYVZXQUlNemNwUUNMbVQrZTZ5eUh6?=
 =?utf-8?B?aXJOeGZhN3NPVHg1a21KK2w2N1E1dFI1bThyc2NYdTgxK0RtQnpVak5zS1RV?=
 =?utf-8?B?cFhNSldwN0ZlRVNhUGFpU0xmYnZmOGV5LzZ6Z1Jpa0xydStmR2hxaTVlS3Fl?=
 =?utf-8?B?OFRoSWZJQVZsR2pwUmZod0dWRTlsK1ROSEJ4azZWYUlXZW9HNGltejdaQXNL?=
 =?utf-8?B?ZGZnWFlTTUMvNVJLVUttZTR1SGNZUUhaR1AxdVRLZCtpa2xZSUw5dlJTdUZl?=
 =?utf-8?B?L3hleGRKUXRqSjZmWThOM094Sm8ra2xldHlMcjlZMjlyeXR2akNSZE9qeVEy?=
 =?utf-8?B?d0x0Tk4yenEvNmswcWl1dDM3dXk0OVZEWkVqYm9VWTdYSjl4YVpKTStjRmtp?=
 =?utf-8?B?c1NQMkhwdDRoRis1ODlmZlZ1bGdBK28xcy9PUmNzQVkwQi9SdUNQQjdvUEVr?=
 =?utf-8?B?Ti9CT0VtcTE5ME02cWVlUTE0MDZpR241MmFIK1YvUnBaSnpzTXZJWkU3Y240?=
 =?utf-8?B?aCs0bUFNVnoxTFJrRVAxSUlSVm41alM3MktvVmxDdnJIOW5GbFo3M3c3aUsx?=
 =?utf-8?B?dGRCT3pWZm1LVWFFbGRzOU1kdEQ1UDl3RnVITHpLZmtJZlducGQ2Umx5QlVs?=
 =?utf-8?B?Y2M4M3ZzT2NZNFZLNmRzcytvdHpJM3U0SXpxRzZhb1BEVDRtdGVYN3F5ZWhM?=
 =?utf-8?B?TEZ4elpZYnFZU3J4dFdtakdKdmdYaGJZWlJNdFNkbUZMYjVmcjlsZElscFhD?=
 =?utf-8?B?TmdvNGhqZFFEcDh0M3VQVEdJNFptS2piREVnU1ZwNkM5VnhjQnJWQmg4SGE3?=
 =?utf-8?B?K3g5MUhQTmpuK1VvRjBLZjNLUzFQMC9xR3NzbTJ5b2RXdlNaNlIzcURGa0RH?=
 =?utf-8?B?TEh2Q1hKc2N4T28wanRLWmRLd0puTjNFa25lSjlqQ1g4SlpxSzNVNWNDeHc0?=
 =?utf-8?B?V0dYUWIwS0xveHFpK3hnaVdQMnF0clpSM0tueG5ZSVFjZUQrUnJqRVA5RzAx?=
 =?utf-8?B?cUthdlZkNU9GU3ljT2FMaG5vR1FHaFJ6dFVTLy8vM0w1ejkvNHBPOTMzZ011?=
 =?utf-8?B?S0R4OVpaeTJWMVJwcEFDNFNwRURMWnAvUUZmcHNPVnpCWFltcm96bFZhWm1u?=
 =?utf-8?B?UkMyK3Y4NEQxOHdoZi9XNEdJNCtSRjh5S3gyMjlBSWJXbnpnMWpxTGpSVTZv?=
 =?utf-8?B?K0kxM2xDUkxMUy9uaVFzbTREejBEWWZONENydUMrM3licTU0bWl1WkhuckdV?=
 =?utf-8?B?aDZ1Y1NGN2o1TmhiNjVuZnRnUXB3WWprOUlIOUcwVzZlTjhaY3FDTjlFUEpS?=
 =?utf-8?B?RmxVT2l3b3pBdEhVakFIY3diNlJoemlWYVZhMTBLN1RUdm9zR2psZ092enhZ?=
 =?utf-8?B?VGp5Qk5oM1BsOFZZcUcyZ1Q5RXhNZzlLLzRzOWhpL1hwSXpQc1FBZEJBSzdv?=
 =?utf-8?B?VkR3NnZkVU55ZVg2MG1lT0tyVFZzNk5scXRJcVdHeGxRS3c5SENJWnQ2dmVY?=
 =?utf-8?B?TkVNWm0ybjUwTUJ6Skt3b3ZGdzN3dFo4U2NnRmVBVTFiaXpRZ3dIMzJlVnFH?=
 =?utf-8?B?YWtyd0NCcHlJeElVNE9EalNRZU1VN1NNdDhablBBNmJ1MDY2YW5ZYjg2Mmoz?=
 =?utf-8?B?MDVNTS82YWlaY0JEWWd2K21HYjIydXl4QzZRbmFJMmpoQzgzNHI4ZDlOOCtx?=
 =?utf-8?B?b3lWNXJRa0pxUmVMZnk2S21Senk4MEpBcjhxbzZmVWEzamlDbFkxK1lrN1Zy?=
 =?utf-8?B?OWVSV0FGd3Y2WXpaakVRR3pLb3FxYnY2bmg3c3RoMFVlOXZyYjVCazhObXZW?=
 =?utf-8?Q?AarybCV1j0ZSGM6O+hfZdjklQ?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-MjRzm2dLCQb7hmJKJURq"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d2f9d1d-f53b-4743-4669-08dab345e87f
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 09:23:26.0804
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SLp44CHXUGh9GXFW9SJjVZd2/Zc4HWjpCsAlc/VsXVuCnAkvKFo6ICbgaixD8V3Vp2xP0OozRQOAHnHGBMcypg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8834

--=-MjRzm2dLCQb7hmJKJURq
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-10-21 at 08:10 +0200, Juergen Gross wrote:
> When a domain gets paused the unit runnable state can change to "not
> runnable" without the scheduling lock being involved. This means that
> a specific scheduler isn't involved in this change of runnable state.
>=20
> In the RTDS scheduler this can result in an inconsistency in case a
> unit is losing its "runnable" capability while the RTDS scheduler's
> scheduling function is active. RTDS will remove the unit from the run
> queue, but doesn't do so for the replenish queue, leading to hitting
> an ASSERT() in replq_insert() later when the domain is unpaused
> again.
>=20
> Fix that by removing the unit from the replenish queue as well in
> this
> case.
>=20
Ah, ok... So, all is fine until what could happen during rt_schedule(),
was "just" that the currently running task, not only is descheduled,
but it also became !runnable.

In fact, in this case, the unit itself is not in the runq, but it can
be in the replq. However, since it still has the RTDS_scheduled flag
set, either:
1) we reach rt_context_saved(), which remove it from replq, before any=C2=
=A0
   replq_insert;
2) rt_unit_wake() is called, but due to RTDS_scheduled, it may only do=C2=
=A0
   replq_reinsert(), which is fine with the unit being already there.

However, what can also happen in rt_schedule() is that we remove from
the runq an unit that was not running, and hence does not have the
RTDS_scheduled flat set. In which case, rt_context_saved() doesn't do
anything to it (of course!). And as soon as rt_unit_wake() happens, it
does replq_insert(), which is not fine with finding the replenishment
event in the queue already.

So, yes... And good catch! :-P


> Fixes: 7c7b407e7772 ("xen/sched: introduce unit_runnable_state()")
> Signed-off-by: Juergen Gross <jgross@suse.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-MjRzm2dLCQb7hmJKJURq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNSZQ0ACgkQFkJ4iaW4
c+7GyBAA7AmNzn/bNMWac1Fk/QtTV8x8GOQZC4pNEaweGUGoz4qDINldUL5N9NXM
kVkwHtFO1QNDlZVIePPb7HlAipbQSpIU7CU5e1rW03wUG4DEa/L50ZM/q9Uc+Lt6
ofZQzktDR/cr9HX2t9ChERUNpxiy6hcod2sjx5E+e+K+NcI4Zu3jxIfYFtZhabwE
Y9VFka1XbbTR9gbc4fW9J069kTMayULhALfeiQw/6mfLgbfpLTbrOJY8Y18MFhDx
Y3ntt/Q24g+fQLTghW1bfDRlSDgOLg7UhSJUDF/8oC2+0i0pKfu7lLWStZEQN2E9
w2+A21Lp75pPPOxFMp652yQ6FtZYsdGftaMd6fnk8DcYkUn1tCqVMhXE806qgqcC
IXyJWW2Pd+wN21PuOqxMLTb+OLdeBvaIkIiXlyTcxs9aGQnvEqurPMXOBsN4a2n4
KPFhKqSOgF+9pCWcxCPZq02AofQAI490l1fHt+hKOn53/KwdfYyqPrlqt4aAMVEd
HekRxdtkOC1GKQhMU/In0rpLyUZEi/Y344L8oTNScK70Kh0FTcnKvbSEEqfurKHF
xBoSMze0nrxJSOdCQAAwjkyek6xX/29PXMgip9zahtoq6JLnjYm8+28TrOh6P1bc
/Yr8RLhBkk3Hd3xrhd8ibjDHDILCuwTVEIIPzdZOf6iWkZWslxQ=
=lvsp
-----END PGP SIGNATURE-----

--=-MjRzm2dLCQb7hmJKJURq--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:31:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:31:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427484.676585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloNA-0000nV-CP; Fri, 21 Oct 2022 09:31:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427484.676585; Fri, 21 Oct 2022 09:31:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloNA-0000nO-9T; Fri, 21 Oct 2022 09:31:24 +0000
Received: by outflank-mailman (input) for mailman id 427484;
 Fri, 21 Oct 2022 09:31:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oloN8-0000nI-Og
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:31:22 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f2a7e7a-5123-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 11:31:21 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 652C71F8DD;
 Fri, 21 Oct 2022 09:31:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 342AC13A0E;
 Fri, 21 Oct 2022 09:31:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xHtcC+hmUmOLegAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 09:31:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f2a7e7a-5123-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666344680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=66VORuuRGgtD11eadp0v6/ucFeH/DC5nWV02hBdGj8Q=;
	b=nIpBl5ZWwNpjsyS/76Q2FZw5hcYWY9KeI/OnSeX2yPJ0sexktUJsAHlXR+z1ifMPoig0SE
	JwpD8lrlQw5BZa1zIxkJy7JL8Ll/MrsPRunY68YUI2reiVaE4Q7knXfXUcHQyi7JBF6Tdn
	+kDDAH1NVDi0bhjBFAB+mSJnwDLc4rY=
From: Juergen Gross <jgross@suse.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	sstabellini@kernel.org
Subject: [GIT PULL] xen: branch for v6.1-rc2
Date: Fri, 21 Oct 2022 11:31:19 +0200
Message-Id: <20221021093119.25978-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Linus,

Please git pull the following tag:

 git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc2-tag

xen: branch for v6.1-rc2

It contains just 2 fixes for the new "virtio with grants" feature.


Thanks.

Juergen

 drivers/xen/grant-dma-ops.c | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

Oleksandr Tyshchenko (2):
      xen/virtio: Handle cases when page offset > PAGE_SIZE properly
      xen/virtio: Convert PAGE_SIZE/PAGE_SHIFT/PFN_UP to Xen counterparts


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:36:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:36:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427490.676600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloSC-0001Yz-Uh; Fri, 21 Oct 2022 09:36:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427490.676600; Fri, 21 Oct 2022 09:36:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloSC-0001Ys-S4; Fri, 21 Oct 2022 09:36:36 +0000
Received: by outflank-mailman (input) for mailman id 427490;
 Fri, 21 Oct 2022 09:36:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=opYQ=2W=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1oloSA-0001Ym-OQ
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:36:34 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d91bc124-5123-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 11:36:33 +0200 (CEST)
Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com
 [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-570-96pLP3jJPdmmKXwGW4wsTw-1; Fri, 21 Oct 2022 05:36:30 -0400
Received: by mail-qk1-f200.google.com with SMTP id
 bk21-20020a05620a1a1500b006be9f844c59so2961557qkb.9
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 02:36:30 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 y13-20020a05620a25cd00b006bbf85cad0fsm9523029qko.20.2022.10.21.02.36.26
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 02:36:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d91bc124-5123-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666344992;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=K6+Nj7rw2ygq8wV7bZt+IrcWSvF1WDIQyRmejPr4x8M=;
	b=UswBF7Jx7bMXKnubRrcXa5mzsv010M864jp9zu9cYxZgrHskTU3nr6OwlFLsmzwsQ9EPt+
	OnFyS5IIRS30yrjRQhytrAeP3kQWXr+VBBRm+NGCzKOV3GaR89BWgQa2wMghxHOG8T2MiM
	xoivHoivMXoJ6+PVPk0WvPMOjvSj/gM=
X-MC-Unique: 96pLP3jJPdmmKXwGW4wsTw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=K6+Nj7rw2ygq8wV7bZt+IrcWSvF1WDIQyRmejPr4x8M=;
        b=LksuQcRd93qTQGw8/6CuDYoPoR281K4Ntiwjtk05YdCpgUlQcdDqF1KZBuSZMPaAz+
         B5OHp7jSdy9VR7ClN4WqDOlcBUfjCNcN64bG+sgDn4hUPSuH7wFpKYSmGAq6th6upBv5
         cZE4+t+z6ltOxMfoujzkmJ807d2t3Qwx1+MDl4KaKe9nmh/GCHMa4C+83njHuBmTwDLM
         EwEGfxQKqVMwwrIxz6y01qUG1YJd91FkGtcWT5dt1cAqg+dNgxfZjfQKD7aigt81aKH9
         xrld7a1xa+5qdS1LcYpXtZmSqTVz6fqYSykV96EUm1wSBech3Hih3PBuJYWP0I+R+dN/
         9luw==
X-Gm-Message-State: ACrzQf3IRERvz65iMpdFQlcb6l3YlHMbNdB5/y7AYUFqAbjh608ucN/t
	33Va3KMDzp5IrzatURRxoBbcbk2HOJKSm7w/1UWdt3Fzka5R/qKUozbxgNXYqozWPTcmLzMf1V5
	LLi/1E1fnHBrrEz79t3WLelDTMag=
X-Received: by 2002:a37:ccc:0:b0:6eb:1095:e4d9 with SMTP id 195-20020a370ccc000000b006eb1095e4d9mr12992355qkm.93.1666344989793;
        Fri, 21 Oct 2022 02:36:29 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6LsNXsHJn0Hr35ZPPaELK7ir7BhcrwNfcxWQB/0oflDEFJ401P6SW83Ra/iR14SaWEQZaN6w==
X-Received: by 2002:a37:ccc:0:b0:6eb:1095:e4d9 with SMTP id 195-20020a370ccc000000b006eb1095e4d9mr12992340qkm.93.1666344989540;
        Fri, 21 Oct 2022 02:36:29 -0700 (PDT)
Message-ID: <30b445bb-a268-d2c9-209f-3b2390746749@redhat.com>
Date: Fri, 21 Oct 2022 11:36:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
To: Markus Armbruster <armbru@redhat.com>, Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Durrant <paul@xen.org>,
 Thomas Huth <thuth@redhat.com>, =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?=
 <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Greg Kurz <groug@kaod.org>, Stefano Stabellini <sstabellini@kernel.org>,
 David Gibson <david@gibson.dropbear.id.au>, Eric Blake <eblake@redhat.com>,
 xen-devel@lists.xenproject.org, "Michael S. Tsirkin" <mst@redhat.com>,
 Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221020162558.123284-1-lvivier@redhat.com>
 <20221020162558.123284-18-lvivier@redhat.com> <87pmel4th4.fsf@pond.sub.org>
 <52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
 <87lep935hn.fsf@pond.sub.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <87lep935hn.fsf@pond.sub.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 11:12, Markus Armbruster wrote:
> Cc: Stefano Brivio
> 
> Laurent Vivier <lvivier@redhat.com> writes:
> 
>> On 10/21/22 07:48, Markus Armbruster wrote:
>>> Laurent Vivier <lvivier@redhat.com> writes:
>>>
>>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
>>>
>>> Use cases?
>>
>> This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.
> 
> Let's add something like this to the commit message:
> 
>      This lets libvirt notice when the connection is lost somehow, and
>      restart the peer (such as passt).
> 
> Who's working on the libvirt part?
> 
>> I have also a patch to add a "reconnect=seconds" option, but I didn't want to add it to this series.
> 
> It's okay to mention future work in commit messages, but not required.
> 
>>> Could similar event signalling be useful for other kinds of netdev
>>> backends?
>>
>> I was wondering, but it becomes more complicated to be generic.
> 
> Making something complicated and generic where a simpler special
> solution would do is the worst.
> 
> Not quite as bad (but still plenty bad) is making a few special
> solutions first, then replace them all with a generic solution.
> 
> I believe we should have a good, hard think on possible applications of
> a generic solution now.
> 
> There is no need to hold back this series for that.
> 
> If we conclude a generic solution is called for, we better replace this
> special solution before it becomes ABI.  Either by replacing it before
> we release it, or by keeping it unstable until we replace it.
> 

I sent the v14 few minutes before this email.

Jason, perhaps we can remove PATCH 17 from the series and only merge PATCH 1 to 16?

I will resend PATCH 17 in a new series with the reconnect option patch once this series is 
merged.

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:37:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:37:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427494.676611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloSv-00026h-7I; Fri, 21 Oct 2022 09:37:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427494.676611; Fri, 21 Oct 2022 09:37:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloSv-00026a-4g; Fri, 21 Oct 2022 09:37:21 +0000
Received: by outflank-mailman (input) for mailman id 427494;
 Fri, 21 Oct 2022 09:37:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VH1f=2W=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1oloSt-00020Y-QU
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:37:20 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2043.outbound.protection.outlook.com [40.107.20.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d1112f99-5123-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 11:36:19 +0200 (CEST)
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12)
 by PAXPR04MB8624.eurprd04.prod.outlook.com (2603:10a6:102:21b::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 21 Oct
 2022 09:37:17 +0000
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022
 09:37:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1112f99-5123-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hYMyHQE+sbMbRVy9yHWyE6/E4GfUggqrYo1pj+H9X39//V6uO3cs/tJNwZVlLeP5AoSuUu5qPg3dpulSqDZ63CCf59oe2LnsC4WydUr4U9k2rOwN1F0ORJT6Yyk0NXThT/mTgLnNthgPKTpIefigtbVlKYUMX3VGcNUD4vFiEQwD1oUk8OHeaX6s24iFD6hFe+QrOEK7+pwpEhFyq51X4/255Gn9GCaxBXJDlrQLNe7vreshMIhqhQnAtkXYXfs48iQyurzG2afSxd3juGQDCfdhTtAQienk5aGDSZoMFVmGYX1ZGFzLA+iZlYRLiga959GwopDRZku24XzInhnzHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lD/kD27MU97TTDhFYxcqdUuePGSrZO2yQ+QnXV941vk=;
 b=kOP4XkKrtjo2IG4Avagzipsy58yHsLLRfdqXaz5NbwMQDl0SbCyajBGjy+ZllV+QIOA07x/a2YNWZSBc103F/4JQ/TCEnmwGaOMYWNP0cmMJ01OV8YZDnorbFkcpkieVHuHQghDKKoHuBdGuQ0Q8wkkFhtFzmCANvTn2WhM5xGji+XETqmiaJWdGxD4Nj4yMAcYerD2XHtGvBoGOIfkI1q0fflZL1OCLNeX3I1G+9jlSFjtipHm61DZ9pLM7Bj+SoSaWhcLBTsdTZifZ6IRZfHfPJ/Janc+sp+4qlyAqIodsb3DKp7nwB1fMfmdFoKgPnkr+G81ZbjZJUYl6cIdnrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lD/kD27MU97TTDhFYxcqdUuePGSrZO2yQ+QnXV941vk=;
 b=hn+ohjoF+XUSkLUZIQ4L3V6huuNT2jpS7DxOk96Ky12qHbrBexR/EoT/VXLDCQ61kUy+2mR7c3pEQ7IN1FLD8pCRb/id0w/D9Mgmf1sYxGqoaTGdeRDn00pUbH9codYAclrq9Xi4+2e26IaSxChAoWyk34e5xdzd/3diuuDrhIXQ+OKwwxueJQZ8Yz73iPcXbSCzJJGeeuq7HRJev4cBAkM8fH80cegzAaNoJ/c0jFom4AWx6N1Su5gttFBg1JERBEzksTBwHgjzFLdtgiHAynMK6HGsJ52Y5RVRqT6xLPfdVHtLcDAoVYYdINGf+sszx3sIMUKUx7NX1gOouGTluA==
From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Henry.Wang@arm.com" <Henry.Wang@arm.com>, "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>, "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>
Subject: Re: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Thread-Topic: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
Thread-Index: AQHY5RPdyv7HUa7jcEWPdT3S+dSn164Yl0EA
Date: Fri, 21 Oct 2022 09:37:17 +0000
Message-ID: <e661d49da44ff2f6d17ab7371f10bb38ae61369f.camel@suse.com>
References: <20221021061042.12083-1-jgross@suse.com>
In-Reply-To: <20221021061042.12083-1-jgross@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.46.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|PAXPR04MB8624:EE_
x-ms-office365-filtering-correlation-id: ab133433-55b4-4a3d-54a4-08dab347d7c9
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 QGm4+9VGgcDSor8PdAWylv93gRf1M0aeHe2K0b8QVwQ4r19qp3oQ4Vxmhk0gmyMoplnhMYwkiEgmdD+hYmdFem6Wd0NDL6M/pYsRbAmAc/UC6hkAC9kZetrL7A8DV611CJEj/yM5B4GF0f4h9Wu724Ka4T6PdW8R5Yg27HGF2F52nQ2VsjrPU5ItGKbbxPQuq6wlwZnz/QwdjeISd6l131t4+252Fw0M2g6LtBzc5Cvfa1Y9gWXG34DlGbUR0RAREYFOFdKOpZrvH1v4quKNqi7rGebo0uYOaPk+9+B2eSa+48yOHFnCxfhvC5iOmUe0RWdCwUVvvyqt6iV3t8H+faS0PK/jehc8Leuzvv36+Iyuqr0wXQK7hYZAZQce+si5/18U+7vjg+t0m0x9SkOhum2Nj2fC7Fhr3aekh7WwVhlMF4kOVtid0nRqWSx6++r6N99m/Hb23US8pFTE9mL/VxbiE7LY8qAUk/lHdyz0V6+N90aeWGZj3U89N6dRJesfwo5IvqvTQMj0yjoVGQd9pKJV1yQKfvVl+W/h3TQUkvBEJeplBWW+TPQketP9V4CzpV46NxU0H48X87FxXKf3iuP43TiqhrcEO7otDZ28mbJ2YUhyDgpI7ibdkvy0iXX69RhzMUukqLYrBhMngHcpQ0Lxw3Wq/0jK83Cj85gbnCqLqUTXdxBbp43bPzdWidFBrNIgDJyD2dV6xwhWcw7nf9DVmNPun9gkXi0TaKnDDWGRadXvKDD+CVQnn0tj1mCXx5p1XsdHC6PYj2Nz/WDBmsXSKHFXr2lTQdchyxYL3+zGFBCxSZb0MHgwY+vrKZPh3Zgsl7sUWgSDWZxglDSywQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199015)(6506007)(4001150100001)(478600001)(316002)(122000001)(86362001)(38100700002)(38070700005)(99936003)(91956017)(186003)(66946007)(66556008)(64756008)(71200400001)(6486002)(76116006)(41300700001)(8676002)(4326008)(110136005)(2616005)(66446008)(8936002)(966005)(66476007)(5660300002)(54906003)(2906002)(26005)(6512007)(36756003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MERmSVhKbEVlRlhwT0liMXBQZ1p6bHduRS9uRk9VbmdpU0hJOGZOMFMyUEhx?=
 =?utf-8?B?bVlhc0ppZkxvYUNQQW9jYWVjclA5eC9oOUZCVSs1NElQV295U3hpL3VJenM2?=
 =?utf-8?B?R1ZnZjZWMlc2azFhU0l2ZXpUZ2ZDL1djTHEyMjcwYW5WUXYyN1g3bDBON0ZY?=
 =?utf-8?B?TW5ld050N1dGTXhqQXdzSjVpMnN6am0zaFQvWEYvK2hQdU45UEI1b2Q0UzA4?=
 =?utf-8?B?R3JYUktYKzhPWVVuMENnSkxiaFJiS0xPbm8zcElZRnFNbWRtNlhjQzZTSzhi?=
 =?utf-8?B?MVJsMS9LMitRSVd6OWMyMVhBekVtdE5lNjFyeW9DL29EMnhtWTFsN3lkSmtr?=
 =?utf-8?B?SnliemJkMDI3QkY2S0xnTWZHRWJuKzRsaGViRFZMaFVlZHFGMSsrWjFJUTFU?=
 =?utf-8?B?bWs1cWpTYkE2U2o1R1VCRHozelprNGViNmdDL2JoZGxvaWF6SlNVZ0p2T2lH?=
 =?utf-8?B?OWJrYmNyK0t2Y2dSSlQ3ZEVGR2s1eWJYNGs5RlZ5dnlCb0RTa3crakJHWHdF?=
 =?utf-8?B?VC90VnZ6Vkx5RlErd1dzcEtqR2RFYWs1bTR5cW05Q3V3dkk3Sm9DRFVUaklu?=
 =?utf-8?B?ZFpzWjBYRUx0UjVWVnlBbXYzSUppb3VUSU91aXhqVGV1OTZQb1hOK2Q3SEZW?=
 =?utf-8?B?LzBVclNDYTdhOVM0UVRFOGZIb0tVY1diVTlqNFk4S2VLRkU1SExQRENvaVB1?=
 =?utf-8?B?YnpSaVhrVUtiUkt6bVlqQXJ6R2s4Q0h0SWFjV1cwcnF0QkZmQzFDZDExK0dI?=
 =?utf-8?B?K3Y3Tm03V2g5OU9QSk8vSjE3Q092bW9YNDlPMmg5NnE4b2dpVWhHRlNyY0Rv?=
 =?utf-8?B?Z1g0WS9lWFB2RDEzV0oydmxXSVJuNVRUeFBlYUVkQkpsZDA3V1RUMWRoTzR5?=
 =?utf-8?B?TUtGTHdrMURHVmpYUU5xTVplOG5VaGR2SkZQODlhREpXWTd3VkNXdzBNUmNB?=
 =?utf-8?B?amVNS1EzVTNzWXRPTkpKT3FpVnZsN2ROVFZxY2krQWdSb0VOK2c3OXBNZkZC?=
 =?utf-8?B?YjJTT21zYVBGbnR6NEF5Y2kyaFBpaU9VSGdNZnRlbnZPVTI5L0g5UFgzSzFP?=
 =?utf-8?B?bkJGWHhaMm9tVFJ1eWkxTDZSVnpDbjFDc1QyOWlyOExMNUk2cTU1bDZGTytT?=
 =?utf-8?B?Q1VUK09pODQzM3dWbHFqdWhaMVpqbFkzZkszWGZpNy9QQzF0ZzR5TUhRRkpL?=
 =?utf-8?B?d3F0eDI4bnpUVmFHajFhQk1yZlYvU3lSR3FmT0FoZENpcVBUM0hWVk1WSGp0?=
 =?utf-8?B?aXQxdU1sa01pMmlER3R0cjlXR3kxWkZVSk40L0hsWm9BVnF2MkhrQjhmK0cr?=
 =?utf-8?B?d3RPSDNoU0NzM1g2SzVyVjhCZXBWam5xbU8wK05scVNCREMwdjhKeU1aOWUr?=
 =?utf-8?B?OGJJN2lHUnVmR0ZxeGQxRXJWRyt2VjF6aVlDdC9ubmlCRXJQcmVsTkgwNm1W?=
 =?utf-8?B?M1poTk1hRThTUkZMMnh5RWhvMkNXN3pkSFA5b2FDbGt5OE1zeG82bnFlTzAz?=
 =?utf-8?B?a2hNVjdDN0VlRDFsRGM5cFF6TFFHNEU3UGFqUzVHbUs0YnJiOWs3NzQxQnNI?=
 =?utf-8?B?WUVBbjNuVjE4bHdEcGpvakpJbXhrRGY2cXZaOS9hTUpyTmNySDNJeWlTMTdG?=
 =?utf-8?B?c1BjUW9iZm9ueTFxZVJUY3R3aG1jNVJzZWNINzZVOGNMY3NrcFN1TmpobzVs?=
 =?utf-8?B?bklRS3ZnN3dsRmo2MHR2RUM0ZC9FWXc5Tk01SnRFL1IrV3RUYjFvYkFZM0ly?=
 =?utf-8?B?Qzlnc1ZucFVFM3NSYUtBM2plMjZodmQ5d0ZBNzNlYTh1dVdrcnRIRkdta0Mx?=
 =?utf-8?B?UmR0cGhuaHQ3MURBVEpOczJQQVZvMXRhdXB0NFNPc29xZExIcFpucUYySHVv?=
 =?utf-8?B?MC85TTBwY2R1a1pvQkhlU0h6QXFpaTZLZmZDREdUZXpGd1hRYU5RTXBNM25V?=
 =?utf-8?B?bDB2eERBMWFLRWFoUGxSaTEwTEZ2M0dvZUd3bXB6aE9tWW9GMUtCd2hVRjJo?=
 =?utf-8?B?U1dJOWxMMXp3djRmemd4STcyTGQ3VWpBdHd4ZE9QZXZub2tHaTNTM2JRRWha?=
 =?utf-8?B?bnVMZko4YlhDRytZakdqN1pHTWU3Tm1CNHU3b2Z3ZU9YcWlqQXorM3N1Vzdk?=
 =?utf-8?Q?oMYOat+JMgdMJVMgZ1B6mH8MV?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-2SM/KrvKGYYRkZ2NlYjP"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab133433-55b4-4a3d-54a4-08dab347d7c9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 09:37:17.0379
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2xnvcpY9GFNq495mFrKiXI9cZ9DIj2Z+Xv8pOfyZhHc4QFbYZtUWV8/hABuRFxlFz8taC+duc+QvSupV5YmB/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8624

--=-2SM/KrvKGYYRkZ2NlYjP
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Ok, and now, something not really related to the bug being fixed here,
but about the code that is being touched:

On Fri, 2022-10-21 at 08:10 +0200, Juergen Gross wrote:
> diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
> index d6de25531b..960a8033e2 100644
> --- a/xen/common/sched/rt.c
> +++ b/xen/common/sched/rt.c
> @@ -1087,6 +1087,7 @@ rt_schedule(const struct scheduler *ops, struct
> sched_unit *currunit,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else if ( !unit_runnable=
_state(snext->unit) )
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
q_remove(snext);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 replq=
_remove(ops, snext);
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
snext =3D rt_unit(sched_idle_unit(sched_cpu));
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
> =C2=A0
So, adding a few more context here, the code looks like this:

        snext =3D runq_pick(ops, cpumask_of(sched_cpu), cur_cpu);

        if ( snext =3D=3D NULL )
            snext =3D rt_unit(sched_idle_unit(sched_cpu));
        else if ( !unit_runnable_state(snext->unit) )
        {
            q_remove(snext);
            snext =3D rt_unit(sched_idle_unit(sched_cpu));
        }

Basically, we've tried to pick-up the highest priority task from the
runqueue. If snext is NULL, the runqueue was just empty, so we pick up
idle (and then, later, we'll check whether the currently running unit
is still runnable; and if it is, we'll continue to run it, of course).

However, it can happen that --e.g., due to core-scheduling-- we picked
up a unit that, despite being in the runqueue, is not runnable. At this
point what we do is removing it from the runqueue (to avoid picking it
up again) and we go for idle.

Now, I may be missing/misremembering something, but it looks to me that
it's possible that there are other runnable units in the runqueue. And
if that's the case, why do we just pick idle and move on, instead of
continuing trying?

Juergen... Am I missing or misremembering any fundamental reason why we
cannot continue to scan the runqueue until the first runnable unit (if
any) is found?

Of course, this is not really related with the bug this patch is
fixing, which is correct and should be applied, no matter what the
outcome of this subthread will be. :-)

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-2SM/KrvKGYYRkZ2NlYjP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNSaEwACgkQFkJ4iaW4
c+5+Tg/+Jq2Z4SsUS1ODdpZY7TkgFdHnYhDrZrDf2B72R8nsKa6ZaX9vQJdCjPzQ
Hdgn6xl6KaJh1VXsfdnYnkysdyzR55W4L9AkUWm1E3akXR9BqV886zqj+k41yuva
yhJ2JJUqjRr0oHmDNj5Ay9xAqYp7XPab0opf/T/BfoTBdsvS7pVmD933QE1uh3dG
L0bj8x5WoFyR54V7xFPWP1f5Zpn2mSbEYE48UnnQ6rKozzmIDNdti8EtV9YERR35
jdHuYbXUJE9KhcA1CqXwmeXnf4Dw5QdLKRLAXudNMLTlSWLApSoi2D+bFnn9w46R
+ACY3nVGUBqoGqAbZ9zcgdorBZTJcQI983pJdRXyU9Vxp4T+47wTOBbYTxRAqVev
pUPh/Sr9ZLwnBjz+5jmdH+jJEyOKE+GQSm9/ILvJ6yfdlTE64KyCV0g34OkSXVkX
w7OcZJ+kE5t3/7kv8EeDnIcyo/W4Gje1VB7nVp+VDQxGpFgkZqKDz0zq1l6q67Bd
7JsZE97opULfP2uHh+w2Iw9oQF1KeiBtMLM7PRb/hulkVKg74U3k7EDt13pBa4TZ
q1D6vhQcIlhTl3OV6nq5x/i0dcwFLQ+36iUJXVENDt0ybMgMKVu0rQGvpw6qMF+i
8rAaFRyFI+xI2Us2/WEjYirrgvDckZQz69ZfDEXOFy5RcFni9vk=
=s3V8
-----END PGP SIGNATURE-----

--=-2SM/KrvKGYYRkZ2NlYjP--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:41:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:41:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427501.676622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloWi-0003ah-RT; Fri, 21 Oct 2022 09:41:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427501.676622; Fri, 21 Oct 2022 09:41:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloWi-0003aa-Od; Fri, 21 Oct 2022 09:41:16 +0000
Received: by outflank-mailman (input) for mailman id 427501;
 Fri, 21 Oct 2022 09:41:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1oloWi-0003aU-18
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:41:16 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d6b4faa-5124-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 11:40:15 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-647-3FGA5yS9Nvm9-naxw_QUsA-1; Fri, 21 Oct 2022 05:41:07 -0400
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com
 [10.11.54.10])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF596185A7AE;
 Fri, 21 Oct 2022 09:41:06 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id A437540F156;
 Fri, 21 Oct 2022 09:41:06 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 8F84E21E675B; Fri, 21 Oct 2022 11:41:05 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d6b4faa-5124-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666345274;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tnyF06QSYZDYFQcAMt2EoCOKDh9Ezhx8aWqcenWAlts=;
	b=hXOuMdHRiALieEJIeR6Evr/7bIhWEkHzikM1zVl/n3QkQ0NF6qRGZRMjerQLq3aiNiKLXd
	VAAsNlq50UtdsSzlpEMDmUrd6LBV+9R0AtoaYPo5p2RDZIz75tNNqV9K4jxuKDHxpBK40v
	M7kP1dGaqhOhAlObm4zTBzKCQUg8yrw=
X-MC-Unique: 3FGA5yS9Nvm9-naxw_QUsA-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,  qemu-devel@nongnu.org,  Paul Durrant
 <paul@xen.org>,  Thomas Huth <thuth@redhat.com>,  Daniel P. =?utf-8?Q?Ber?=
 =?utf-8?Q?rang=C3=A9?=
 <berrange@redhat.com>,  "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
  Greg Kurz <groug@kaod.org>,  Stefano Stabellini <sstabellini@kernel.org>,
  David Gibson <david@gibson.dropbear.id.au>,  Eric Blake
 <eblake@redhat.com>,  xen-devel@lists.xenproject.org,  "Michael S.
 Tsirkin" <mst@redhat.com>,  Stefan Weil <sw@weilnetz.de>,  Paolo Bonzini
 <pbonzini@redhat.com>,  Samuel Thibault <samuel.thibault@ens-lyon.org>,
  Anthony Perard <anthony.perard@citrix.com>,  Stefano Brivio
 <sbrivio@redhat.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
	<87lep935hn.fsf@pond.sub.org>
	<30b445bb-a268-d2c9-209f-3b2390746749@redhat.com>
Date: Fri, 21 Oct 2022 11:41:05 +0200
In-Reply-To: <30b445bb-a268-d2c9-209f-3b2390746749@redhat.com> (Laurent
	Vivier's message of "Fri, 21 Oct 2022 11:36:24 +0200")
Message-ID: <87bkq5345q.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10

Laurent Vivier <lvivier@redhat.com> writes:

> On 10/21/22 11:12, Markus Armbruster wrote:
>> Cc: Stefano Brivio
>> 
>> Laurent Vivier <lvivier@redhat.com> writes:
>> 
>>> On 10/21/22 07:48, Markus Armbruster wrote:
>>>> Laurent Vivier <lvivier@redhat.com> writes:
>>>>
>>>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
>>>>
>>>> Use cases?
>>>
>>> This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.
>> 
>> Let's add something like this to the commit message:
>> 
>>      This lets libvirt notice when the connection is lost somehow, and
>>      restart the peer (such as passt).
>> 
>> Who's working on the libvirt part?
>> 
>>> I have also a patch to add a "reconnect=seconds" option, but I didn't want to add it to this series.
>> 
>> It's okay to mention future work in commit messages, but not required.
>> 
>>>> Could similar event signalling be useful for other kinds of netdev
>>>> backends?
>>>
>>> I was wondering, but it becomes more complicated to be generic.
>> 
>> Making something complicated and generic where a simpler special
>> solution would do is the worst.
>> 
>> Not quite as bad (but still plenty bad) is making a few special
>> solutions first, then replace them all with a generic solution.
>> 
>> I believe we should have a good, hard think on possible applications of
>> a generic solution now.
>> 
>> There is no need to hold back this series for that.
>> 
>> If we conclude a generic solution is called for, we better replace this
>> special solution before it becomes ABI.  Either by replacing it before
>> we release it, or by keeping it unstable until we replace it.
>> 
>
> I sent the v14 few minutes before this email.
>
> Jason, perhaps we can remove PATCH 17 from the series and only merge PATCH 1 to 16?
>
> I will resend PATCH 17 in a new series with the reconnect option patch once this series is 
> merged.

Certainly works for me.  Thanks for your patience!



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:42:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:42:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427505.676632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloY7-0004Ao-6I; Fri, 21 Oct 2022 09:42:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427505.676632; Fri, 21 Oct 2022 09:42:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oloY7-0004Ah-3g; Fri, 21 Oct 2022 09:42:43 +0000
Received: by outflank-mailman (input) for mailman id 427505;
 Fri, 21 Oct 2022 09:42:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Xpxf=2W=redhat.com=sbrivio@srs-se1.protection.inumbo.net>)
 id 1oloXV-00040x-5B
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:42:05 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e48a4f8-5124-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 11:42:04 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-246-r7AfPqY6NQ-Q2yMecedJPg-1; Fri, 21 Oct 2022 05:41:58 -0400
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
 [10.11.54.7])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7DF2B857F92;
 Fri, 21 Oct 2022 09:41:47 +0000 (UTC)
Received: from maya.cloud.tilaa.com (ovpn-208-31.brq.redhat.com [10.40.208.31])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A586141C6A9;
 Fri, 21 Oct 2022 09:41:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e48a4f8-5124-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666345323;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HWFs6Ey6gOSX0j5UiIYZMTxWGzZHU1ACMbPbsoVaxIc=;
	b=OCRTGITt+SQ+zzpk8fS2zJCWgieFKncyz/gdi30WlZ+hzZE2ptMznhcQ7Q/WTVtDpIWdX2
	AGERqAFeP1cojD4AhOanljCHOl1gYJn63BNM07mallsLjN0DIjWHvD36y2wKFw1LkbEqtP
	PYK88piWCL0bRpWG9zi0kqDzoPwDfmc=
X-MC-Unique: r7AfPqY6NQ-Q2yMecedJPg-1
Date: Fri, 21 Oct 2022 11:40:52 +0200
From: Stefano Brivio <sbrivio@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org, Paul Durrant
 <paul@xen.org>, Thomas Huth <thuth@redhat.com>, "Daniel P. =?UTF-8?B?QmVy?=
 =?UTF-8?B?cmFuZ8Op?=" <berrange@redhat.com>, "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>, Greg Kurz <groug@kaod.org>, Stefano Stabellini
 <sstabellini@kernel.org>, David Gibson <david@gibson.dropbear.id.au>, Eric
 Blake <eblake@redhat.com>, xen-devel@lists.xenproject.org, "Michael S.
 Tsirkin" <mst@redhat.com>, Stefan Weil <sw@weilnetz.de>, Paolo Bonzini
 <pbonzini@redhat.com>, Jason Wang <jasowang@redhat.com>, Samuel Thibault
 <samuel.thibault@ens-lyon.org>, Anthony Perard <anthony.perard@citrix.com>,
 Laine Stump <laine@redhat.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
Message-ID: <20221021114052.339f6aac@elisabeth>
In-Reply-To: <87lep935hn.fsf@pond.sub.org>
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
	<87lep935hn.fsf@pond.sub.org>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7

[Cc: Laine, full quote]

On Fri, 21 Oct 2022 11:12:20 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Cc: Stefano Brivio
> 
> Laurent Vivier <lvivier@redhat.com> writes:
> 
> > On 10/21/22 07:48, Markus Armbruster wrote:  
> >> Laurent Vivier <lvivier@redhat.com> writes:
> >>   
> >>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> >>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.  
> >>
> >> Use cases?  
> >
> > This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.  
> 
> Let's add something like this to the commit message:
> 
>     This lets libvirt notice when the connection is lost somehow, and
>     restart the peer (such as passt).
> 
> Who's working on the libvirt part?

Laine Stump and myself. Nothing to show yet, though.

> > I have also a patch to add a "reconnect=seconds" option, but I didn't want to add it to this series.  
> 
> It's okay to mention future work in commit messages, but not required.
> 
> >> Could similar event signalling be useful for other kinds of netdev
> >> backends?  
> >
> > I was wondering, but it becomes more complicated to be generic.  
> 
> Making something complicated and generic where a simpler special
> solution would do is the worst.
> 
> Not quite as bad (but still plenty bad) is making a few special
> solutions first, then replace them all with a generic solution.
> 
> I believe we should have a good, hard think on possible applications of
> a generic solution now.
> 
> There is no need to hold back this series for that.
> 
> If we conclude a generic solution is called for, we better replace this
> special solution before it becomes ABI.  Either by replacing it before
> we release it, or by keeping it unstable until we replace it.

-- 
Stefano



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 09:46:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 09:46:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427512.676644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olobX-0004sI-La; Fri, 21 Oct 2022 09:46:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427512.676644; Fri, 21 Oct 2022 09:46:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olobX-0004sB-Ix; Fri, 21 Oct 2022 09:46:15 +0000
Received: by outflank-mailman (input) for mailman id 427512;
 Fri, 21 Oct 2022 09:46:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VH1f=2W=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1olobV-0004s5-Rm
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 09:46:13 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2050.outbound.protection.outlook.com [40.107.103.50])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f0c5aeb-5125-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 11:45:13 +0200 (CEST)
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com (2603:10a6:102:1be::12)
 by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 09:46:10 +0000
Received: from PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca]) by PAXPR04MB8366.eurprd04.prod.outlook.com
 ([fe80::64e2:acbd:4d56:fcca%5]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022
 09:46:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f0c5aeb-5125-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FXr0xneFeqF7t5efilawGLaNeFH72IvwwVoPsrpOT0ZTOflJVBz/NDjwNv7G5g2gV4k5aD8v30H5IjW//6OIFMWUrbNKi5g5EOlYrtSnOBtHv0xEHBzuDkpmdy9zpLAARBC2Hw7jK0UFGbijBDn+TXnTp867XDKGjDUQ0EHq5LscoMptkRJKoFd+zagDo/Ys96dw/9Gggrf/2gYQgQaYHkee219PL2PRLaskdMiYcWPr2vFtoSPww3khwcX9RDgfLu4iG4ihFTd+QZWqdheg47HfLVq4iEgwJf1S9CMXL7Jdf7WaFwUAL5DlHxlcwha3p3lCwntUVKAglxktW9pj9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pbaUhrPzOyoQfGzuUbY90ly4Jm7GEJnjoyzzbmaYVYY=;
 b=D84scHj+hcFQ1TaxrIIouHbjtjBBQAWGAyUfsAobBPJtKFewWplBDVFY0khyBJzUacYVv8euJPuYu/sDG9dSGfRgEax88PqJV0wZBUSqpXi/h2eKysowUta8X0Mk2LJms9xocgCjpbbSn6pnHDYg7Mkyyv1NsjBEZRI8fMRzounX9Rb2aHJCw+fTQZ2Q6+C3RuZzQhHBMDMh8uKR/zbpTWDy3kwGt109OSkEYcvtFAhKnvSRHQPLKTftZK3A6yhYBzu9cXe/HDOaJP8s9rOx7YD6IJIt7QoY2G6G8KBdytx/LaGUkCJwjwe1xileLucQk9gWYDhCwlTCgkITIfUGVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pbaUhrPzOyoQfGzuUbY90ly4Jm7GEJnjoyzzbmaYVYY=;
 b=aBHfG1stdPXdgMRFaNTSJsJzbCRw0hgwi+hbCJcZLtgQkWC4ZGjLrIWtI9Kq2c4Dj/AymvATu2aQ5pETMbvsSh12J8WYcM/anMtGsSoncQLACI8tnsQ1mRugVkzxUu6QY/0/3Kh1emJznrHfUqNHZi9VRY4XA/y5VpHtfeoewKeXD1N19ZIxYfY6BQlr7R5Lxh6urCdDtZVDqqvxMyaaLXoeCHEg3k9wJ0RBYjOtEOEbX2A7v6LeyQLyde0CYfJCUNhZQcr/djcQalCkOyup9qIkyxBsWqQKBepiwnQQ8HfGCAJ1R55S2hql+O5+n2WHzFMwjwMgm5L5v7SutdegUw==
From: Dario Faggioli <dfaggioli@suse.com>
To: Juergen Gross <jgross@suse.com>, "Mykyta_Poturai@epam.com"
	<Mykyta_Poturai@epam.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>,
	"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, "julien@xen.org"
	<julien@xen.org>
Subject: Re: [PATCH 17/19] xen: don't free percpu areas during suspend
Thread-Topic: [PATCH 17/19] xen: don't free percpu areas during suspend
Thread-Index: AQHY2jgm2f/PHlobT0esfUs820FvA64CyFEAgBXnIgA=
Date: Fri, 21 Oct 2022 09:46:10 +0000
Message-ID: <ce5af168d2889aca8e4475da9103f3718213836c.camel@suse.com>
References: <cover.1665137247.git.mykyta_poturai@epam.com>
	 <37f0f84cdaf47b1efda59f0368998183dff88a3b.1665137247.git.mykyta_poturai@epam.com>
	 <87437234-02ce-b18e-8442-c081de259ed9@suse.com>
In-Reply-To: <87437234-02ce-b18e-8442-c081de259ed9@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.46.0 (by Flathub.org)) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PAXPR04MB8366:EE_|DU2PR04MB8824:EE_
x-ms-office365-filtering-correlation-id: 3fb7b11c-c8c6-40f4-588c-08dab34915b4
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 wPgd9+KXZ7FiPGylkM5puNy2hHAUHrj0ELjN0eD/3AyJin4arZ/Cpaf36NfzHGVtTly8xV0tkhyQ9F1XZna/xG5AYCclTqP5/UyfpAI++ARShlKr3gi+Rb06qD3bMTHcQ4TvQvyhBJ08V2p4babhifEyvmKGRl3uBQrmqLDb598CQEHwHA5NOXxTffwLvCTdLpXo8030Vr5ACKrPl0iFs5kacRm8X/g2bL2wxxmUV9b69lV6RYF8DwcAAA5lxeOBK6YFAN0YsLIFoKBsYlffhFlFTyMhs/uwHxT6CUb2P+1Esd8pzWxC1U47Osj8DFWNggXVo8yFtpWys6Yv/HsqPvHwZtU7JuS0Caofiinm04mhbT4YVThnP6ZBWObBM26EvT8GT9dm5uaZlziChtKIhl0v51xKlUq3lQw34DYAVjjjk07/m73dy9TyFCYHMl8rDX/4vhytYDpJlsSxLh41iswNAx1XUAJAaXEEt+vfH8KziJse8OfkEBwmPjvUAnWVZY7WQOcd60DqAf64L1fHXeQNEh9vdM3vg8QOVbr1MPcBtGMYpsUtTGcGx9XFhFwFQxWJX7BZsBnaSqmk/3FrwX94H3JBZBv7gy8S7Kh1HtBL7pvHzYoKFAkt4drqqPKM//13crtYF+EJjIUy6Wa3A7TkfMMVIMh4VSnhcRHpSNSW3wKt9klwYbMjQXBq50RRfFSqttBL9RgwJIxhm6SBpfpp4GfkRnlCH9ENpdl2qzT7iMWPUH6LX+HwSFSaeo544dUnp/lwNhLrxkILrbeqJSl84Czf5Aafyljo+aW8ujuHn4cXj+ryAQS29MsJ5RsqNoedzKwLUN2h7YmPaZPLAw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199015)(86362001)(54906003)(2906002)(38100700002)(6512007)(26005)(5660300002)(4326008)(66476007)(8936002)(41300700001)(91956017)(53546011)(8676002)(64756008)(66946007)(66446008)(66556008)(76116006)(6506007)(110136005)(4744005)(38070700005)(316002)(186003)(2616005)(71200400001)(36756003)(966005)(6486002)(478600001)(99936003)(122000001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?aFAyMlhzWG5WMjJZU0x2RU5OdTZlanVUN2lucjhmVDVRR2grTldWOWhhVldh?=
 =?utf-8?B?SEpGZkFhNFR5WVZaQW02a0xjSFh5MWpYZFNkZnRFUWl3cWJUZjhkQllhL0Rn?=
 =?utf-8?B?S3cwYm1FM3BJOFhpRUF5TUdvbmtlY3ZPU0ZRQ1hKWDh0Ull5ZnJEZmoxODZn?=
 =?utf-8?B?WVYzRDd1OW1EUzl0OUs0Q0RWZkNpZHE2UWJVUFJ6MVcxSFhmMjRlbWFwRWEv?=
 =?utf-8?B?TkJmTlhXaTJhSlhMcFE2UVhPQ2hGUitkaktKTFo3clA3N0RQT1EyR1FrOEdZ?=
 =?utf-8?B?VVVsR0w3aUFaSHdlNkNvYS9kTEZxSmlPa2hzWjdzUUZ3YS8rRkpRYllzc1li?=
 =?utf-8?B?RlFqRy84bWt2NXIxVXdHQ1N5TXJiUlhCTHFVTFR4cGpHTjFETGk1ckl5OUFk?=
 =?utf-8?B?eEhBZS9jdldDK0l0MVk2UnA1T1d0NUxBVVQzNDhEbGVmejdSeUZhSGF3V3BI?=
 =?utf-8?B?T3BpOTBFZm5zbVpJOUVtWnNzWFoyRUMwaitBRkVEcGJxcktBZERvNGZIL21P?=
 =?utf-8?B?eEh3VFJBbURCOGhmYlRsOXZkczJDVFZUUDhTbk9FblUzd0MvUEZRR2NzZ2ho?=
 =?utf-8?B?NFNpNitBZmtxelY3N3ZQWTRUek12RlU5Q1ZWRy9LR2FZd04xNENRMHpXV2pI?=
 =?utf-8?B?MHVCZjlQZ1g1U2ZQbjNqNm1VNGZjMmZMZVVuM1ZDWnZ4MHRNbWhYYnIzYllX?=
 =?utf-8?B?Q29JblMrZGFxdEo5QjFjM1dBWnpDSUU1V1AzNG9sNk9VeHJycEtHTHBoNzNm?=
 =?utf-8?B?ZXNJeE5UckY1ZTRHQ1FVbFlBT2phQzIvOTBzaE44ZG1iQ1AwRVErUGlwQVhp?=
 =?utf-8?B?VlpCNUI4VG42dWxEbmlPRUdqS1l3NExZS3o2WGFEdmQzY1VWRlNISFBvRERF?=
 =?utf-8?B?UW5kbmc3cXZUaVVNQU5Kcll3RlJWZnFJNG11Vlk2SUpwdGR2eUU0L1pOT0NG?=
 =?utf-8?B?dTd4SWthWUlVL3FmYkErTkRmMC8raDZFU2tYWkloQTB1QjZoVk9HQ1FMMnA0?=
 =?utf-8?B?VkpQcUNwQk0vVnUrc29ONWVUeHpVbGZmekdpUTJTSzRTV2xUZElzVWl2aEJs?=
 =?utf-8?B?ckZQaTBoMzByZVF0SDQzUnBPa3N1YXFWTXB1bzRZbmJGRnQ3V0RTZTY1dUtH?=
 =?utf-8?B?cmM4YW80ZzF5VFpRRnZya2o1c2pQVzdCTXBBR2tjS2RWL3RYQXFtamY3eW5Z?=
 =?utf-8?B?TkM1VU5EbHM5cC81ZlBWMTVMdE9BdU5VODZsTEVlTUltQ1JvS2Z0ci9FV3ow?=
 =?utf-8?B?ZURBb3lLVUlpVklLZyt0MFRrQWJoUG81blNrK1l1aUw1bVdScGxMUGFqODZW?=
 =?utf-8?B?V21URVNwMnc4SmVCcHIvdnI0OXo5S2hmSDNLcVNXWkZrQjVUZ0tYUEM5bWY2?=
 =?utf-8?B?dEJUc0g2bDBaYzBrdWV3cjg4VGpaZWZBYzJSUXpYd24rZGxKOG5yRHBhNFEv?=
 =?utf-8?B?ZkdNamxsQ2tGRXlUK0t2TlRQQUd4R3IxQ3lQZC9icnNWTXVFNjdLOHZDRFVP?=
 =?utf-8?B?T1hlekIzaDRMaDVkRlFDT3gxcmlPQUpwcGR6d3ltcE1ZRTArMTBNcXJiRUti?=
 =?utf-8?B?THdRZDZhSC9UT0JheGFGWFYzRVVtdzQ0eENLYXpQUDR3Yi9tbkRTWnh5LzJK?=
 =?utf-8?B?UXBOVmVIb1EzQ0J6dE80ekVkT3F4OEZVOXJybmlWdDlzY2t4cVNKd0xmeUd6?=
 =?utf-8?B?a2REb1NrQVdmaDQwM3VhRDRlOS9kclZlTlQ4R0pIbUNDT2YwTXNaeVdHTklt?=
 =?utf-8?B?SmRIR0VMeU5yTnMwZlo3NFEwSFhzTXBOTHFJSmV3Wi9selJDSDVnYU5jUlVl?=
 =?utf-8?B?VTU0djRtNitTVk03dmxrZEh0aVY1cW00K1hpOTN1K2dmd2docGozUXRCNVNJ?=
 =?utf-8?B?ZFI2UVQ0TlFETnJrc25QOEZVNSt6MzJLTElieWlYcExrak1JQ2Q0cmhjbEFQ?=
 =?utf-8?B?N3RtTmJpVThLMmhFTlljaVpMT1VKWndscTRCUTZhL1h1dkZ4NWVXVjVycFRE?=
 =?utf-8?B?REJFZGQ2Z1pGR3V0WitkWjUvZ09VbVJSQ3BiVk5vNkNQUENmQmFRY01kZkRT?=
 =?utf-8?B?cWF6bFFBK05aVTJ1ZVk5dWM2NlQ0L3RsMnJtZ2JEZDdFUjY0bEY2ZFh0ZmRM?=
 =?utf-8?Q?D0+MsoCrG347rMQQEGwzgCzoh?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-Fivi7lOC3uudUZC7hjLu"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fb7b11c-c8c6-40f4-588c-08dab34915b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 09:46:10.4471
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Nf+Czuk2hVn11LJWlDi0p/IL8QdbW55OYC6YGznegsa7Ue7o9d/h070NO2nAzejt/phudGxoy59RtHsncKFK4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824

--=-Fivi7lOC3uudUZC7hjLu
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2022-10-07 at 13:17 +0200, Juergen Gross wrote:
> On 07.10.22 12:32, Mykyta Poturai wrote:
> >=20
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> I can't remember having written this patch. The one I remember was
> for
> x86.
>=20
> > Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
>=20
> I doubt that, reasoning see above.
>=20
Right. In fact, I can't find any records of having sent an email with
such a tag... Or to have ever even replied to any patch sent from this
email address, for what matters.

Thanks and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-Fivi7lOC3uudUZC7hjLu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmNSamEACgkQFkJ4iaW4
c+6wAw/9F+ahc27QyR1p1WBN5DC0eDHukQpPt+zcA11klyZTlrfKWgFEuXTYnGFD
azjILH486qV5VHHmV5EFG57wavRiGuxp5+Sk62FzGWfkwJWq5nqUC0+PZAzZGMoJ
5K/4nxaKKawgKEw1FmL3BQaIWjpvAbVTca5Crb2y+u+7q2co1JIOfO7VisEDYIrK
oRgSEMOEyEu9ShtUB1exZScrNUhgOD9JHaMNMEWW0ZFxtpvE/mxydwZopHmHIcKh
D8Pz1REhXUFEyiJPlWHgdWIiehdZbgCxYQMsqsMKHsrw27hdmzRQfexDOjsTclYe
vUs4H4sEyv+lNxP6GP0gc9omcknnEr2li5FvYpB6CFezb3h59B/3r42k8nAzYpy1
b8dVEsWbrodBr3JhC8mmDV2m/tV8vJ6s9ApUvkCBguca1YS95pH0sV66xBudRvn9
IWLB7qGx1FCvBDR7Me7gp8mT6hBoAeXpGffYwpusO4L4WPoJR6nfkxmEE8ctt3QB
8yrUsR46Gi01Qeslu5LtotiGTWHl3gdhkkxA+Xm9vLPNG6188FAQbIdkxaeYOt4q
OwkJfldxOVWbv7X2+j2GNevFqdTw+w/wnGIpwc5saf/FAc9ui0z/38hzXTqgFk6I
tELrqBUFsDMskUpu+p9vqO3osjMqkh+ty9I011xyAwoqf6sRkFM=
=Z8zG
-----END PGP SIGNATURE-----

--=-Fivi7lOC3uudUZC7hjLu--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:05:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427517.676654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olouT-0007Xs-7o; Fri, 21 Oct 2022 10:05:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427517.676654; Fri, 21 Oct 2022 10:05:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olouT-0007Xl-4W; Fri, 21 Oct 2022 10:05:49 +0000
Received: by outflank-mailman (input) for mailman id 427517;
 Fri, 21 Oct 2022 10:05:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RYXF=2W=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olouR-0007Xf-5a
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:05:47 +0000
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [2a00:1450:4864:20::42c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ca679280-5127-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:04:46 +0200 (CEST)
Received: by mail-wr1-x42c.google.com with SMTP id bp11so3736287wrb.9
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 03:05:45 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 l24-20020a1c7918000000b003b50428cf66sm2082907wme.33.2022.10.21.03.05.43
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 03:05:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca679280-5127-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=GB+pI3kGAuzpQoXTGpIpiRRFsRdWt5+i8pDVrDo5vB4=;
        b=CzmN+f1TmY8uBHSiAVNQ6zxNfaxGebmiadC1wQAKTZhLYj4FiEtIhMWq0tQPVm0SLK
         XacWht1NGqaR6Y2jUwfAX6IhcpakVK5I5Ftql2ljjangwJsABF4wCMYf/+1KhfnO8qeN
         +nXSa8G/ckLYCwIq5ePsKdGZU2tzFcH1uNhkaHxhtFOVnnTCpJMGdOS9MeubZtkYvuAG
         priGcqXsO1s7WMpoaZIqaQD3k1Rr6tmYW3Cht+70sThqlFsHIdS0KmJ9BG3/PuTq2vzq
         cTibJzhhXONM9xOhAM6lWBPZb3cKY0M1XDdOM33WnNtrOtlwJBh7x8n6Gg9EpsEBfjbl
         h33w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=GB+pI3kGAuzpQoXTGpIpiRRFsRdWt5+i8pDVrDo5vB4=;
        b=5uib6/s+mxPWsIQ0MGNAFlPPVXuVorxjGzmhvH7YXALHHHNgqewtM6ojr7NXPeRmgk
         XdNjcn1+SJQUQ5cU74wlLgqDQ+IF0Pu4ma5+sGVzWzKgHInOu/MRMhoOAMxjoe1FPXwd
         isL86l0OAzRz7IDeozSyyBLpkTSt9hXOc2PRdR47OEJaYjcn8I2SudpXSaExpRVemj6n
         1/HwsyMPPI53x4m3Ej7uJvCq5MLCFuxjPMSnLdSOHRuVbVkeShV2c/5dIehWwgqGXA9H
         mo8eCDvX9sYectpbXOjyrJTxYG+rOWhLypJ69nmEa71MRCBdwbMEsmYf5ITET6FaM7TU
         oK4Q==
X-Gm-Message-State: ACrzQf1wMyVpSU0OQnM2wdKM+i1Bpn5qBW1hPE43HzeFnp1mzxH0+pOg
	j8sNi1TgW/SOPmr4WXxyuC0HYA==
X-Google-Smtp-Source: AMsMyM56sq1HIy0HWbcR0IYJtQwp46T1S4N7uaKz29DxhotsSlDQw6YPcANPVrmEUULyqMfgiJqRig==
X-Received: by 2002:adf:ee84:0:b0:22c:d1fd:71d4 with SMTP id b4-20020adfee84000000b0022cd1fd71d4mr11781164wro.350.1666346745235;
        Fri, 21 Oct 2022 03:05:45 -0700 (PDT)
Message-ID: <1f769d00-cf50-abaf-f078-f301959156b9@linaro.org>
Date: Fri, 21 Oct 2022 12:05:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v14 15/17] net: stream: move to QIO to enable additional
 parameters
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, xen-devel@lists.xenproject.org,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>, Stefan Weil <sw@weilnetz.de>,
 David Gibson <david@gibson.dropbear.id.au>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Markus Armbruster <armbru@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-16-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221021090922.170074-16-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 21/10/22 11:09, Laurent Vivier wrote:
> Use QIOChannel, QIOChannelSocket and QIONetListener.
> This allows net/stream to use all the available parameters provided by
> SocketAddress.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   net/stream.c    | 492 +++++++++++++++++-------------------------------
>   qemu-options.hx |   4 +-
>   2 files changed, 178 insertions(+), 318 deletions(-)

> -static void net_stream_accept(void *opaque)
> +static void net_stream_server_listening(QIOTask *task, gpointer opaque)
>   {
>       NetStreamState *s = opaque;
> -    struct sockaddr_storage saddr;
> -    socklen_t len;
> -    int fd;
> -
> -    for (;;) {
> -        len = sizeof(saddr);
> -        fd = qemu_accept(s->listen_fd, (struct sockaddr *)&saddr, &len);
> -        if (fd < 0 && errno != EINTR) {
> -            return;
> -        } else if (fd >= 0) {
> -            qemu_set_fd_handler(s->listen_fd, NULL, NULL, NULL);
> -            break;
> -        }
> -    }
> +    QIOChannelSocket *listen_sioc = QIO_CHANNEL_SOCKET(s->listen_ioc);
> +    SocketAddress *addr;
> +    int ret;
>   
> -    s->fd = fd;
> -    s->nc.link_down = false;
> -    net_stream_connect(s);
> -    switch (saddr.ss_family) {
> -    case AF_INET: {
> -        struct sockaddr_in *saddr_in = (struct sockaddr_in *)&saddr;
> -
> -        qemu_set_info_str(&s->nc, "connection from %s:%d",
> -                          inet_ntoa(saddr_in->sin_addr),
> -                          ntohs(saddr_in->sin_port));
> -        break;
> +    if (listen_sioc->fd < 0) {
> +        qemu_set_info_str(&s->nc, "connection error");
> +        return;
>       }
> -    case AF_UNIX: {
> -        struct sockaddr_un saddr_un;
>   
> -        len = sizeof(saddr_un);
> -        getsockname(s->listen_fd, (struct sockaddr *)&saddr_un, &len);
> -        qemu_set_info_str(&s->nc, "connect from %s", saddr_un.sun_path);
> -        break;
> -    }
> -    default:
> -        g_assert_not_reached();
> +    addr = qio_channel_socket_get_local_address(listen_sioc, NULL);
> +    g_assert(addr != NULL);

Missing propagating Error* (observed in v12).

> +    ret = qemu_socket_try_set_nonblock(listen_sioc->fd);
> +    if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
> +        qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
> +                          addr->u.fd.str, -ret);
> +        return;
>       }
> +    g_assert(ret == 0);
> +    qapi_free_SocketAddress(addr);
> +
> +    s->nc.link_down = true;
> +    s->listener = qio_net_listener_new();
> +
> +    net_socket_rs_init(&s->rs, net_stream_rs_finalize, false);
> +    qio_net_listener_set_client_func(s->listener, net_stream_listen, s, NULL);
> +    qio_net_listener_add(s->listener, listen_sioc);
>   }
>   
>   static int net_stream_server_init(NetClientState *peer,
> @@ -283,105 +286,61 @@ static int net_stream_server_init(NetClientState *peer,
>   {
>       NetClientState *nc;
>       NetStreamState *s;
> -    int fd, ret;
> +    QIOChannelSocket *listen_sioc = qio_channel_socket_new();
>   
> -    switch (addr->type) {
> -    case SOCKET_ADDRESS_TYPE_INET: {
> -        struct sockaddr_in saddr_in;
> -
> -        if (convert_host_port(&saddr_in, addr->u.inet.host, addr->u.inet.port,
> -                              errp) < 0) {
> -            return -1;
> -        }
> -
> -        fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
> -        if (fd < 0) {
> -            error_setg_errno(errp, errno, "can't create stream socket");
> -            return -1;
> -        }
> -        qemu_socket_set_nonblock(fd);
> +    nc = qemu_new_net_client(&net_stream_info, peer, model, name);
> +    s = DO_UPCAST(NetStreamState, nc, nc);
>   
> -        socket_set_fast_reuse(fd);
> +    s->listen_ioc = QIO_CHANNEL(listen_sioc);
> +    qio_channel_socket_listen_async(listen_sioc, addr, 0,
> +                                    net_stream_server_listening, s,
> +                                    NULL, NULL);
>   
> -        ret = bind(fd, (struct sockaddr *)&saddr_in, sizeof(saddr_in));
> -        if (ret < 0) {
> -            error_setg_errno(errp, errno, "can't bind ip=%s to socket",
> -                             inet_ntoa(saddr_in.sin_addr));
> -            closesocket(fd);
> -            return -1;
> -        }
> -        break;
> -    }
> -    case SOCKET_ADDRESS_TYPE_UNIX: {
> -        struct sockaddr_un saddr_un;
> -
> -        ret = unlink(addr->u.q_unix.path);
> -        if (ret < 0 && errno != ENOENT) {
> -            error_setg_errno(errp, errno, "failed to unlink socket %s",
> -                             addr->u.q_unix.path);
> -            return -1;
> -        }
> +    return 0;
> +}
>   
> -        saddr_un.sun_family = PF_UNIX;
> -        ret = snprintf(saddr_un.sun_path, sizeof(saddr_un.sun_path), "%s",
> -                       addr->u.q_unix.path);
> -        if (ret < 0 || ret >= sizeof(saddr_un.sun_path)) {
> -            error_setg(errp, "UNIX socket path '%s' is too long",
> -                       addr->u.q_unix.path);
> -            error_append_hint(errp, "Path must be less than %zu bytes\n",
> -                              sizeof(saddr_un.sun_path));
> -            return -1;
> -        }
> +static void net_stream_client_connected(QIOTask *task, gpointer opaque)
> +{
> +    NetStreamState *s = opaque;
> +    QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(s->ioc);
> +    SocketAddress *addr;
> +    gchar *uri;
> +    int ret;
>   
> -        fd = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
> -        if (fd < 0) {
> -            error_setg_errno(errp, errno, "can't create stream socket");
> -            return -1;
> -        }
> -        qemu_socket_set_nonblock(fd);
> -
> -        ret = bind(fd, (struct sockaddr *)&saddr_un, sizeof(saddr_un));
> -        if (ret < 0) {
> -            error_setg_errno(errp, errno, "can't create socket with path: %s",
> -                             saddr_un.sun_path);
> -            closesocket(fd);
> -            return -1;
> -        }
> -        break;
> -    }
> -    case SOCKET_ADDRESS_TYPE_FD:
> -        fd = monitor_fd_param(monitor_cur(), addr->u.fd.str, errp);
> -        if (fd == -1) {
> -            return -1;
> -        }
> -        ret = qemu_socket_try_set_nonblock(fd);
> -        if (ret < 0) {
> -            error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
> -                             name, fd);
> -            return -1;
> -        }
> -        break;
> -    default:
> -        error_setg(errp, "only support inet or fd type");
> -        return -1;
> +    if (sioc->fd < 0) {
> +        qemu_set_info_str(&s->nc, "connection error");
> +        goto error;
>       }
>   
> -    ret = listen(fd, 0);
> -    if (ret < 0) {
> -        error_setg_errno(errp, errno, "can't listen on socket");
> -        closesocket(fd);
> -        return -1;
> +    addr = qio_channel_socket_get_remote_address(sioc, NULL);
> +    g_assert(addr != NULL);

Ditto (Error*).

> +    uri = socket_uri(addr);
> +    qemu_set_info_str(&s->nc, uri);
> +    g_free(uri);
> +
> +    ret = qemu_socket_try_set_nonblock(sioc->fd);
> +    if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
> +        qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
> +                          addr->u.fd.str, -ret);
> +        qapi_free_SocketAddress(addr);
> +        goto error;
>       }
> +    g_assert(ret == 0);
>   
> -    nc = qemu_new_net_client(&net_stream_info, peer, model, name);
> -    s = DO_UPCAST(NetStreamState, nc, nc);
> -    s->fd = -1;
> -    s->listen_fd = fd;
> -    s->nc.link_down = true;
>       net_socket_rs_init(&s->rs, net_stream_rs_finalize, false);
>   
> -    qemu_set_fd_handler(s->listen_fd, net_stream_accept, NULL, s);
> -    return 0;
> +    /* Disable Nagle algorithm on TCP sockets to reduce latency */
> +    qio_channel_set_delay(s->ioc, false);
> +
> +    s->ioc_read_tag = qio_channel_add_watch(s->ioc, G_IO_IN, net_stream_send,
> +                                            s, NULL);
> +    s->nc.link_down = false;
> +    qapi_free_SocketAddress(addr);
> +
> +    return;
> +error:
> +    object_unref(OBJECT(s->ioc));
> +    s->ioc = NULL;
>   }



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:13:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427526.676674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp1r-0000fO-6d; Fri, 21 Oct 2022 10:13:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427526.676674; Fri, 21 Oct 2022 10:13:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp1r-0000fH-3v; Fri, 21 Oct 2022 10:13:27 +0000
Received: by outflank-mailman (input) for mailman id 427526;
 Fri, 21 Oct 2022 10:13:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olp1p-0000fB-QS
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:13:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olp1p-0007pj-GX; Fri, 21 Oct 2022 10:13:25 +0000
Received: from 54-240-197-236.amazon.com ([54.240.197.236]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olp1p-0003LU-8v; Fri, 21 Oct 2022 10:13:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=zPU85ctGBCqxipdBxl4mwOw439wAD/OxwYaONlkpccw=; b=wDjm8foaSplRWMOpRuLAS/wMOD
	pCGVKQpYwHBqrU9YPacHMDM17QSv42gfFSaAzcxYEtVuVV3yskMU+w8Q39WEEYQVm+R0CbozQRv02
	T2UOU04UABHxfcMK8TPiFwIvezFKYPuOu9O54+5K7PsNy/5ppgsOMVwTYg6JyFIV7NYE=;
Message-ID: <bd5beb0d-ff36-2956-5990-1928d52609a3@xen.org>
Date: Fri, 21 Oct 2022 11:13:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
Content-Language: en-US
From: Julien Grall <julien@xen.org>
To: Stewart Hildebrand <stewart.hildebrand@amd.com>,
 xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>
References: <20221014025354.30248-1-stewart.hildebrand@amd.com>
 <20221014200926.15250-1-stewart.hildebrand@amd.com>
 <fe6ac13f-70c4-8d15-20b5-a52ec88f394d@xen.org>
 <dda3b199-55ac-d557-b934-c070db8a371e@amd.com>
 <921d5899-6ceb-ae0a-00d5-d708fd1dfff4@xen.org>
In-Reply-To: <921d5899-6ceb-ae0a-00d5-d708fd1dfff4@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 20/10/2022 19:56, Julien Grall wrote:
> On 20/10/2022 19:53, Stewart Hildebrand wrote:
>> On 10/20/22 14:19, Julien Grall wrote:
>>> Hi Stewart,
>>
>> Hi Julien,
>>
>>> I nearly missed this one because it was threaded under v1. In the
>>> future, would you be able to send new version in a separate thread? This
>>> makes easier to track it.
>>
>> I will keep this in mind for next time.
>>
>>> On 14/10/2022 21:09, Stewart Hildebrand wrote:
>>>> All functions in domain_build.c should be marked __init. This was
>>>> spotted when building the hypervisor with -Og.
>>>>
>>>> Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
>>
>> I missed parenthesis and quotes around the referenced commit. To keep 
>> it in the same format as other Fixes: tags, can you please add during 
>> commit (pending release ack)?
> 
> Will do.

The commit ID was also too short. Xen (and Linux) moved to 12 characters 
because 10 is not enough anymore to uniquely distinguish a commit.

You can ask git to change its default value by adding the following 
lines in either the global config or per-repo one:

[core]
         abbrev = 12

It is now committed.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:14:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:14:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427531.676686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp33-0001D9-ID; Fri, 21 Oct 2022 10:14:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427531.676686; Fri, 21 Oct 2022 10:14:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp33-0001D2-E5; Fri, 21 Oct 2022 10:14:41 +0000
Received: by outflank-mailman (input) for mailman id 427531;
 Fri, 21 Oct 2022 10:14:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olp31-00013k-Rl
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:14:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ba6caa1-5129-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 12:14:39 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 6114122865;
 Fri, 21 Oct 2022 10:14:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FFE413A0E;
 Fri, 21 Oct 2022 10:14:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id hsjdCQ5xUmNBFAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 10:14:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ba6caa1-5129-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666347278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=No7Yx/o1GPE15QfLjpHngpXcw+ynzm2wDJm35rvOGUg=;
	b=abxvCX3sWW9tO9nCb9H/xUdvzhX806HuzxcmONtEMCiImv/13UMxPYUH/b4zqjciM8Itrv
	HvtFSBzlbii+c59JOfopmy8hUSDodXJW0dv+T1CZQnO+fKmlRGTNBZL3sbLbT5nh1CZ7ux
	KrDpcR49ashh5S6Z11QDBSOcRB0Mio4=
Message-ID: <1e3fd219-ffb4-acfb-5dfc-1a4ae054c7e7@suse.com>
Date: Fri, 21 Oct 2022 12:14:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Henry.Wang@arm.com" <Henry.Wang@arm.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>
References: <20221021061042.12083-1-jgross@suse.com>
 <e661d49da44ff2f6d17ab7371f10bb38ae61369f.camel@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
In-Reply-To: <e661d49da44ff2f6d17ab7371f10bb38ae61369f.camel@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------4s5Q1iqXxscEwEYR9FGhUM02"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------4s5Q1iqXxscEwEYR9FGhUM02
Content-Type: multipart/mixed; boundary="------------3I8Dmcc120wZ91svG0Yo6OkS";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Dario Faggioli <dfaggioli@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Henry.Wang@arm.com" <Henry.Wang@arm.com>,
 "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
 "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>
Message-ID: <1e3fd219-ffb4-acfb-5dfc-1a4ae054c7e7@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix race in RTDS scheduler
References: <20221021061042.12083-1-jgross@suse.com>
 <e661d49da44ff2f6d17ab7371f10bb38ae61369f.camel@suse.com>
In-Reply-To: <e661d49da44ff2f6d17ab7371f10bb38ae61369f.camel@suse.com>

--------------3I8Dmcc120wZ91svG0Yo6OkS
Content-Type: multipart/mixed; boundary="------------HNIk8s7LGod1Ir7fTZzZRzfn"

--------------HNIk8s7LGod1Ir7fTZzZRzfn
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMTAuMjIgMTE6MzcsIERhcmlvIEZhZ2dpb2xpIHdyb3RlOg0KPiBPaywgYW5kIG5v
dywgc29tZXRoaW5nIG5vdCByZWFsbHkgcmVsYXRlZCB0byB0aGUgYnVnIGJlaW5nIGZpeGVk
IGhlcmUsDQo+IGJ1dCBhYm91dCB0aGUgY29kZSB0aGF0IGlzIGJlaW5nIHRvdWNoZWQ6DQo+
IA0KPiBPbiBGcmksIDIwMjItMTAtMjEgYXQgMDg6MTAgKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mg
d3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9zY2hlZC9ydC5jIGIveGVuL2Nv
bW1vbi9zY2hlZC9ydC5jDQo+PiBpbmRleCBkNmRlMjU1MzFiLi45NjBhODAzM2UyIDEwMDY0
NA0KPj4gLS0tIGEveGVuL2NvbW1vbi9zY2hlZC9ydC5jDQo+PiArKysgYi94ZW4vY29tbW9u
L3NjaGVkL3J0LmMNCj4+IEBAIC0xMDg3LDYgKzEwODcsNyBAQCBydF9zY2hlZHVsZShjb25z
dCBzdHJ1Y3Qgc2NoZWR1bGVyICpvcHMsIHN0cnVjdA0KPj4gc2NoZWRfdW5pdCAqY3VycnVu
aXQsDQo+PiAgwqDCoMKgwqDCoMKgwqDCoCBlbHNlIGlmICggIXVuaXRfcnVubmFibGVfc3Rh
dGUoc25leHQtPnVuaXQpICkNCj4+ICDCoMKgwqDCoMKgwqDCoMKgIHsNCj4+ICDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgcV9yZW1vdmUoc25leHQpOw0KPj4gK8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgcmVwbHFfcmVtb3ZlKG9wcywgc25leHQpOw0KPj4gIMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBzbmV4dCA9IHJ0X3VuaXQoc2NoZWRfaWRsZV91bml0KHNjaGVkX2NwdSkp
Ow0KPj4gIMKgwqDCoMKgwqDCoMKgwqAgfQ0KPj4gICANCj4gU28sIGFkZGluZyBhIGZldyBt
b3JlIGNvbnRleHQgaGVyZSwgdGhlIGNvZGUgbG9va3MgbGlrZSB0aGlzOg0KPiANCj4gICAg
ICAgICAgc25leHQgPSBydW5xX3BpY2sob3BzLCBjcHVtYXNrX29mKHNjaGVkX2NwdSksIGN1
cl9jcHUpOw0KPiANCj4gICAgICAgICAgaWYgKCBzbmV4dCA9PSBOVUxMICkNCj4gICAgICAg
ICAgICAgIHNuZXh0ID0gcnRfdW5pdChzY2hlZF9pZGxlX3VuaXQoc2NoZWRfY3B1KSk7DQo+
ICAgICAgICAgIGVsc2UgaWYgKCAhdW5pdF9ydW5uYWJsZV9zdGF0ZShzbmV4dC0+dW5pdCkg
KQ0KPiAgICAgICAgICB7DQo+ICAgICAgICAgICAgICBxX3JlbW92ZShzbmV4dCk7DQo+ICAg
ICAgICAgICAgICBzbmV4dCA9IHJ0X3VuaXQoc2NoZWRfaWRsZV91bml0KHNjaGVkX2NwdSkp
Ow0KPiAgICAgICAgICB9DQo+IA0KPiBCYXNpY2FsbHksIHdlJ3ZlIHRyaWVkIHRvIHBpY2st
dXAgdGhlIGhpZ2hlc3QgcHJpb3JpdHkgdGFzayBmcm9tIHRoZQ0KPiBydW5xdWV1ZS4gSWYg
c25leHQgaXMgTlVMTCwgdGhlIHJ1bnF1ZXVlIHdhcyBqdXN0IGVtcHR5LCBzbyB3ZSBwaWNr
IHVwDQo+IGlkbGUgKGFuZCB0aGVuLCBsYXRlciwgd2UnbGwgY2hlY2sgd2hldGhlciB0aGUg
Y3VycmVudGx5IHJ1bm5pbmcgdW5pdA0KPiBpcyBzdGlsbCBydW5uYWJsZTsgYW5kIGlmIGl0
IGlzLCB3ZSdsbCBjb250aW51ZSB0byBydW4gaXQsIG9mIGNvdXJzZSkuDQo+IA0KPiBIb3dl
dmVyLCBpdCBjYW4gaGFwcGVuIHRoYXQgLS1lLmcuLCBkdWUgdG8gY29yZS1zY2hlZHVsaW5n
LS0gd2UgcGlja2VkDQo+IHVwIGEgdW5pdCB0aGF0LCBkZXNwaXRlIGJlaW5nIGluIHRoZSBy
dW5xdWV1ZSwgaXMgbm90IHJ1bm5hYmxlLiBBdCB0aGlzDQo+IHBvaW50IHdoYXQgd2UgZG8g
aXMgcmVtb3ZpbmcgaXQgZnJvbSB0aGUgcnVucXVldWUgKHRvIGF2b2lkIHBpY2tpbmcgaXQN
Cj4gdXAgYWdhaW4pIGFuZCB3ZSBnbyBmb3IgaWRsZS4NCj4gDQo+IE5vdywgSSBtYXkgYmUg
bWlzc2luZy9taXNyZW1lbWJlcmluZyBzb21ldGhpbmcsIGJ1dCBpdCBsb29rcyB0byBtZSB0
aGF0DQo+IGl0J3MgcG9zc2libGUgdGhhdCB0aGVyZSBhcmUgb3RoZXIgcnVubmFibGUgdW5p
dHMgaW4gdGhlIHJ1bnF1ZXVlLiBBbmQNCj4gaWYgdGhhdCdzIHRoZSBjYXNlLCB3aHkgZG8g
d2UganVzdCBwaWNrIGlkbGUgYW5kIG1vdmUgb24sIGluc3RlYWQgb2YNCj4gY29udGludWlu
ZyB0cnlpbmc/DQo+IA0KPiBKdWVyZ2VuLi4uIEFtIEkgbWlzc2luZyBvciBtaXNyZW1lbWJl
cmluZyBhbnkgZnVuZGFtZW50YWwgcmVhc29uIHdoeSB3ZQ0KPiBjYW5ub3QgY29udGludWUg
dG8gc2NhbiB0aGUgcnVucXVldWUgdW50aWwgdGhlIGZpcnN0IHJ1bm5hYmxlIHVuaXQgKGlm
DQo+IGFueSkgaXMgZm91bmQ/DQoNCk5vLiBUaGlzIGNvZGUgd2FzIGludHJvZHVjZWQgaW4g
dGhlIFJGQyBWMiBzZXJpZXMgb2YgY29yZSBzY2hlZHVsaW5nLg0KQW5kIGl0IHdhcyBub3Qg
dGhlIHJlc3VsdCBvZiBhIHByZXZpb3VzIGRpc2N1c3Npb24gb24geGVuLWRldmVsLg0KDQo+
IE9mIGNvdXJzZSwgdGhpcyBpcyBub3QgcmVhbGx5IHJlbGF0ZWQgd2l0aCB0aGUgYnVnIHRo
aXMgcGF0Y2ggaXMNCj4gZml4aW5nLCB3aGljaCBpcyBjb3JyZWN0IGFuZCBzaG91bGQgYmUg
YXBwbGllZCwgbm8gbWF0dGVyIHdoYXQgdGhlDQo+IG91dGNvbWUgb2YgdGhpcyBzdWJ0aHJl
YWQgd2lsbCBiZS4gOi0pDQoNCkkgY2FuIHdyaXRlIGFub3RoZXIgcGF0Y2ggdHJ5aW5nIHRv
IGZpeCB0aGF0LCBidXQgdGhhdCBzaG91bGRuJ3QgYmUNCjQuMTcgbWF0ZXJpYWwgSU1ITy4N
Cg0KDQpKdWVyZ2VuDQo=
--------------HNIk8s7LGod1Ir7fTZzZRzfn
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------HNIk8s7LGod1Ir7fTZzZRzfn--

--------------3I8Dmcc120wZ91svG0Yo6OkS--

--------------4s5Q1iqXxscEwEYR9FGhUM02
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNScQ0FAwAAAAAACgkQsN6d1ii/Ey9T
wwf/TZPF5oy4YLchRpBmGFYbHZda6yENDh2mV+ekxnCPD+GAoEDn+W3cCqngFTsR49MZPOIzRG9y
tsTecP3mvHsn5AMD7mcQEjQP6Npf62iRymc03OiYOWffXgN614x3taTIBf2bm54MpJM671sseTlU
Y3BGfnuwuAk29IqEys8XaJ4A4bHd1sDGADM+cnXULFuhidwvUL0xRPlUru5LJO32lTzZBbeibFUI
kLh4Xo0x0PwKYi2Dxi15r/BP+Ui/pUMRrMtgbqN5LpjWY9xMXFpbqT1uMJ/HNS70bzeI7fW8iPVJ
Diti0yqGEZi8fXrMKJ/EemTjF1VCJqWDGOrvxDWENA==
=3yMh
-----END PGP SIGNATURE-----

--------------4s5Q1iqXxscEwEYR9FGhUM02--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:15:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:15:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427534.676697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp3Z-0001qC-Px; Fri, 21 Oct 2022 10:15:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427534.676697; Fri, 21 Oct 2022 10:15:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp3Z-0001q5-N5; Fri, 21 Oct 2022 10:15:13 +0000
Received: by outflank-mailman (input) for mailman id 427534;
 Fri, 21 Oct 2022 10:15:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olp3Y-0001oX-9d
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:15:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olp3Y-0007re-2T; Fri, 21 Oct 2022 10:15:12 +0000
Received: from 54-240-197-236.amazon.com ([54.240.197.236]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olp3X-0003PI-RT; Fri, 21 Oct 2022 10:15:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=/8u8+zco2y9CslAFeSm9UDDuJ8qWMDuBULNqBkJNWrY=; b=Kzdwyx9tWLI4t2MD375DrT5IVF
	Z/caO9V0+FY+Cd08cIniEaKauC/GMqcXvyrul3gq6z8eCt2+lrC9gT99ryjQVdAJKTI0xChPENs4J
	Kpme7ZcpgN6JNlDJuNsoqy+m0hN5j3RI8mRY844IkmVgTAXOwp/ty439dk5QqwpUjaOI=;
Message-ID: <89639d8e-b2a4-a191-0d59-9bd8c5bbb7c0@xen.org>
Date: Fri, 21 Oct 2022 11:15:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [4.17] RE: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit
 pa range
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, Xenia Ragiadakou
 <burzalodowa@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221019144913.291677-1-burzalodowa@gmail.com>
 <c3ecb453-ac2e-fd0d-d5ca-3f485d7f53a3@xen.org>
 <AS8PR08MB7991AE87BC1FF9E47A3F9F9D922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991AE87BC1FF9E47A3F9F9D922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 21/10/2022 02:42, Henry Wang wrote:
> Hi Julien and Xenia,

Hi Henry,


>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> <Volodymyr_Babchuk@epam.com>; Henry Wang <Henry.Wang@arm.com>
>> Subject: Re: [PATCH v2] xen/arm: p2m: fix pa_range_info for 52-bit pa range
>>
>> (+ Henry)
>>
>> Hi Xenia,
>>
>> On 19/10/2022 15:49, Xenia Ragiadakou wrote:
>>> Currently, the fields 'root_order' and 'sl0' of the pa_range_info for
>>> the 52-bit pa range have the values 3 and 3, respectively.
>>> This configuration does not match any of the valid root table configurations
>>> for 4KB granule and t0sz 12, described in ARM DDI 0487I.a D8.2.7.
>>>
>>> More specifically, according to ARM DDI 0487I.a D8.2.7, in order to support
>>> the 52-bit pa size with 4KB granule, the p2m root table needs to be
>> configured
>>> either as a single table at level -1 or as 16 concatenated tables at level 0.
>>> Since, currently there is not support for level -1, set the 'root_order' an
>>
>> Typo: s/not/no/ (I can fix it while committing)
>>
>>> 'sl0' fields of the 52-bit pa_range_info according to the second approach.
>>>
>>> Note that the values of those fields are not used so far. This patch updates
>>> their values only for the sake of correctness.
>>>
>>> Fixes: 407b13a71e32 ("xen/arm: p2m don't fall over on FEAT_LPA enabled
>> hw")
>>> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
>>
>> Reviewed-by: Julien Grall <jgrall@amazon.com>
>>
>> Regarding 4.17, I am a bit split whether this should be included. On one
>> hand, it would be good to have the value correct (not that I expect
>> anymore to try using 52-bit on 4.17...). On the other hand, this is not
>> used so there is no bug (this could also be an argument to add it
>> because it is nearly risk free).
>>
>> If we don't include it, I will definitely add in my list of potential
>> backports.
>>
>> Henry, any thoughts?
> 
> I am actually monitoring this patch for the same question that if
> we need this patch for 4.17.
> 
> I see no reason to exclude this patch since (1) we want to make sure
> our code is correct (2) I am pretty sure we are not using 52 bit PA so
> as indicated by commit message this patch is just for correctness and
> no potential harm to include this patch in the release (probably even
> backporting this patch till the 52 bit PA was introduced?).
> 
> So if you wouldn't mind committing this patch, you can of course have
> my:

Thanks for the feedback. I am happy to commit it. So...

> 
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

I have now done it with your tag added.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:18:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:18:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427544.676713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp76-0002Ya-Ae; Fri, 21 Oct 2022 10:18:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427544.676713; Fri, 21 Oct 2022 10:18:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olp76-0002YT-7a; Fri, 21 Oct 2022 10:18:52 +0000
Received: by outflank-mailman (input) for mailman id 427544;
 Fri, 21 Oct 2022 10:18:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RYXF=2W=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olp74-0002YN-Ly
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:18:50 +0000
Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com
 [2a00:1450:4864:20::42d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9da8e5e2-5129-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:17:50 +0200 (CEST)
Received: by mail-wr1-x42d.google.com with SMTP id a14so1264204wru.5
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 03:18:49 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 e9-20020a5d5009000000b0022e3d7c9887sm18427284wrt.101.2022.10.21.03.18.46
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 03:18:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9da8e5e2-5129-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=gSvLyqT2me3HwSX6zm/t5Hpc98ZaHpehQTZBKXuZF2o=;
        b=PZWl2AiJok3eJRD/+48hjCoQcX8/5ZIhFwo9HyNB94SJ3qoTnTU7D94wGDxEomBxAB
         CIVlCjw3ftJm7h/3+aQzjFjaOGwphovUFlccAvvjHlDXcZhfg8rn14C8brEVfbvIOLST
         PG74pnUZhk/Mrv+cZjt+6lXXncFe/CZnwmoMusJLFZID2ih23+3zpJj2lg7ivQB6nSuP
         WukR7G7o7x5o/BMyrR06XfSuSfgGp15g+hFZlmSACSOIv4PNYk54i3C8YUu9nZM0j6Mf
         H2KG4Br8hZatH7gFjPEbszjid8RIH6RPzEwRJjAsWGzNVFZ5/YOlxKRBS+67kCcDFmlU
         4p8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=gSvLyqT2me3HwSX6zm/t5Hpc98ZaHpehQTZBKXuZF2o=;
        b=dsvx94UNOidVtPbDNiCMyY+qx7ISW6AP5E2xSF4mXjiXgqD5/tBznbUF6ZWuQfgV/t
         UeVm6rXmy6MvlsrAHF2h0LpjMfDellr8cWCcoc1XyIoVt3oNZt8YF6zGQgA7Y5QNPpO4
         6nbt6z422/ZQFzZB/t0Z+B8UuXF0WTyt7VRyC/DJ5+A6OxPUB9RPiG2uNkRHEIVHUzV5
         yOGOsK7HhAxwM8gKkzCYRrXCZ7lGsFzTrAOgia6gNhtTHUstUdrBP5/p5FFdc97OeWqr
         tNEBZmr7WnvRrEY/IJuL4muApyiyF5uBxTv7mf+FObkJpJAJ4KPFUkl2ChiBV+DJKUpb
         IQrA==
X-Gm-Message-State: ACrzQf3y+ND6AspMSY/1GHQRDzemC47PUx1OBvAruZBxqCsd5W3mloL8
	WR5fmmbuSizS1qFZWi08teOT6Q==
X-Google-Smtp-Source: AMsMyM4J2oFrG2ayVaLyVj/gKPYm/vOmdGpMXDgE2bXapnVZsvvxjFKhOy/05+vEq1gluYAIazV3rg==
X-Received: by 2002:a5d:65d0:0:b0:236:580e:c3f9 with SMTP id e16-20020a5d65d0000000b00236580ec3f9mr384228wrw.101.1666347529225;
        Fri, 21 Oct 2022 03:18:49 -0700 (PDT)
Message-ID: <e6470da4-41a9-b625-1298-3d92532aa61d@linaro.org>
Date: Fri, 21 Oct 2022 12:18:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v14 13/17] qemu-sockets: move and rename
 SocketAddress_to_str()
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, xen-devel@lists.xenproject.org,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>, Stefan Weil <sw@weilnetz.de>,
 David Gibson <david@gibson.dropbear.id.au>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Markus Armbruster <armbru@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-14-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221021090922.170074-14-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 21/10/22 11:09, Laurent Vivier wrote:
> Rename SocketAddress_to_str() to socket_uri() and move it to
> util/qemu-sockets.c close to socket_parse().
> 
> socket_uri() generates a string from a SocketAddress while
> socket_parse() generates a SocketAddress from a string.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   include/qemu/sockets.h |  2 +-
>   monitor/hmp-cmds.c     | 23 +----------------------
>   util/qemu-sockets.c    | 20 ++++++++++++++++++++
>   3 files changed, 22 insertions(+), 23 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:30:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:30:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427552.676736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpIW-00050x-Fu; Fri, 21 Oct 2022 10:30:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427552.676736; Fri, 21 Oct 2022 10:30:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpIW-00050q-D8; Fri, 21 Oct 2022 10:30:40 +0000
Received: by outflank-mailman (input) for mailman id 427552;
 Fri, 21 Oct 2022 10:30:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7rba=2W=gmail.com=marcandre.lureau@srs-se1.protection.inumbo.net>)
 id 1olpIV-00050k-AU
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:30:39 +0000
Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com
 [2a00:1450:4864:20::231])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 43b7f6b9-512b-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:29:38 +0200 (CEST)
Received: by mail-lj1-x231.google.com with SMTP id a6so3096539ljq.5
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 03:30:37 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43b7f6b9-512b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=ecbgzTx5kkKqhfD1JzEDQDcRA9B6flaQVttOqmED40o=;
        b=bhHryH4rSBrKqSLuXz2GisoSbHPfxp/jIjIAw4aEa+6AYJvV35VqAocKCj+s5Sxqrg
         wY7Sd9wV0dqavfFxqAu5A1SP6FyUFMZPlb4hEKWJSOuVScnxVP5u1+CvthLKbanYJMZ3
         /rCRJnSyo7XiZh2RNrxu2xK6+ZZPDbrzQJlU+0NJNdGsZnWVdM1zUTxlaA+DEPChQ0Zm
         cGBmLAC9pRPPTxpLVmK7wemjaqlgo4uEHpUPCEmPTMylF2EZvZhubdpBktNt1gc80wfp
         CmB3msVn3MrN5AGOPFma+fX485pjH2/eur+s0tyjaGmOcJH4tK39NIJYrxXFzocLxnHS
         HUew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=ecbgzTx5kkKqhfD1JzEDQDcRA9B6flaQVttOqmED40o=;
        b=dgrtrXfQLAzxfdUcGSvb6xw5mGvr/HzpRqtIrDLk3DCZ6KAvy1xjTxuXL76XWQWlfl
         BATgltN+qwRrRCZOlM6Wd1WHbnoxsPAKZeV11/7MJr6oTo3AyoFVKyFJXQBQwrOaHSeS
         jUkguMWZABSfkfwJsRJY+xwVVbriWb+PDTjugULYAS+YbT2h2fa17MSVG11dIotI2jgX
         pAmCKkpZu2hQh3T9rziCGuAn09UsllPUTi7/soHGc5BBPfQBGuPox04nKFl9vcrUPjjQ
         AfuRrcd/mexvOThCL+41X7siPyryt6iD6XKBN4dYgw0FkAQYtAXfHLI7x24lTtg5lqTx
         TSLA==
X-Gm-Message-State: ACrzQf1VC4lmHzCzZ7KpKcrFH6Bt0pAUH1eR3u2Y+hgBrxHu8sreNlw0
	l7cpTem7gR6lc1RHIz0jz23KXK63AAWz3GoZYs0=
X-Google-Smtp-Source: AMsMyM5laRrguDLwGDPckEAxWuG3o609ngeu4rUrrE+BjI5y+CTyQmtidB1XzM/gQ5ajtA+GfJIh9cwRnbFnleUWsic=
X-Received: by 2002:a2e:804d:0:b0:26f:c663:2c79 with SMTP id
 p13-20020a2e804d000000b0026fc6632c79mr6235716ljg.289.1666348237089; Fri, 21
 Oct 2022 03:30:37 -0700 (PDT)
MIME-Version: 1.0
References: <20221021090922.170074-1-lvivier@redhat.com> <20221021090922.170074-14-lvivier@redhat.com>
In-Reply-To: <20221021090922.170074-14-lvivier@redhat.com>
From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Date: Fri, 21 Oct 2022 14:30:24 +0400
Message-ID: <CAJ+F1C+sgKTezxFOA4b7efXkvz2c5x6TVeCVH2wFykeC5wGa2Q@mail.gmail.com>
Subject: Re: [PATCH v14 13/17] qemu-sockets: move and rename SocketAddress_to_str()
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>, xen-devel@lists.xenproject.org, 
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, 
	Stefan Weil <sw@weilnetz.de>, David Gibson <david@gibson.dropbear.id.au>, 
	Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>, Eric Blake <eblake@redhat.com>, 
	"Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, 
	Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, 
	Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>, 
	=?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>
Content-Type: multipart/alternative; boundary="000000000000be72d305eb88ee09"

--000000000000be72d305eb88ee09
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Fri, Oct 21, 2022 at 2:03 PM Laurent Vivier <lvivier@redhat.com> wrote:

> Rename SocketAddress_to_str() to socket_uri() and move it to
> util/qemu-sockets.c close to socket_parse().
>
> socket_uri() generates a string from a SocketAddress while
> socket_parse() generates a SocketAddress from a string.
>

Tbh, as we are renaming functions here, I would follow good glib/C
conventions and use the type name in lower case as prefix. I would also not
use "URI", which should be reserved for RFC3986 compliant forms.

So instead, I'd suggest to rename to:

char *socket_address_to_string(SocketAddress *addr);

SocketAddress *socket_address_new_from_string(const char *str, Error **errp=
)

my 2c


> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  include/qemu/sockets.h |  2 +-
>  monitor/hmp-cmds.c     | 23 +----------------------
>  util/qemu-sockets.c    | 20 ++++++++++++++++++++
>  3 files changed, 22 insertions(+), 23 deletions(-)
>
> diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
> index db4bedb6fa20..214058d8e307 100644
> --- a/include/qemu/sockets.h
> +++ b/include/qemu/sockets.h
> @@ -58,6 +58,7 @@ NetworkAddressFamily inet_netfamily(int family);
>  int unix_listen(const char *path, Error **errp);
>  int unix_connect(const char *path, Error **errp);
>
> +char *socket_uri(SocketAddress *addr);
>  SocketAddress *socket_parse(const char *str, Error **errp);
>  int socket_connect(SocketAddress *addr, Error **errp);
>  int socket_listen(SocketAddress *addr, int num, Error **errp);
> @@ -141,5 +142,4 @@ SocketAddress
> *socket_address_flatten(SocketAddressLegacy *addr);
>   * Return 0 on success.
>   */
>  int socket_address_parse_named_fd(SocketAddress *addr, Error **errp);
> -
>  #endif /* QEMU_SOCKETS_H */
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index bab86c5537e1..01b789a79e62 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -199,27 +199,6 @@ void hmp_info_mice(Monitor *mon, const QDict *qdict)
>      qapi_free_MouseInfoList(mice_list);
>  }
>
> -static char *SocketAddress_to_str(SocketAddress *addr)
> -{
> -    switch (addr->type) {
> -    case SOCKET_ADDRESS_TYPE_INET:
> -        return g_strdup_printf("tcp:%s:%s",
> -                               addr->u.inet.host,
> -                               addr->u.inet.port);
> -    case SOCKET_ADDRESS_TYPE_UNIX:
> -        return g_strdup_printf("unix:%s",
> -                               addr->u.q_unix.path);
> -    case SOCKET_ADDRESS_TYPE_FD:
> -        return g_strdup_printf("fd:%s", addr->u.fd.str);
> -    case SOCKET_ADDRESS_TYPE_VSOCK:
> -        return g_strdup_printf("tcp:%s:%s",
> -                               addr->u.vsock.cid,
> -                               addr->u.vsock.port);
> -    default:
> -        return g_strdup("unknown address type");
> -    }
> -}
> -
>  void hmp_info_migrate(Monitor *mon, const QDict *qdict)
>  {
>      MigrationInfo *info;
> @@ -382,7 +361,7 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdic=
t)
>          monitor_printf(mon, "socket address: [\n");
>
>          for (addr =3D info->socket_address; addr; addr =3D addr->next) {
> -            char *s =3D SocketAddress_to_str(addr->value);
> +            char *s =3D socket_uri(addr->value);
>              monitor_printf(mon, "\t%s\n", s);
>              g_free(s);
>          }
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index 83f4bd6fd211..9f6f655fd526 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -1077,6 +1077,26 @@ int unix_connect(const char *path, Error **errp)
>      return sock;
>  }
>
> +char *socket_uri(SocketAddress *addr)
> +{
> +    switch (addr->type) {
> +    case SOCKET_ADDRESS_TYPE_INET:
> +        return g_strdup_printf("tcp:%s:%s",
> +                               addr->u.inet.host,
> +                               addr->u.inet.port);
> +    case SOCKET_ADDRESS_TYPE_UNIX:
> +        return g_strdup_printf("unix:%s",
> +                               addr->u.q_unix.path);
> +    case SOCKET_ADDRESS_TYPE_FD:
> +        return g_strdup_printf("fd:%s", addr->u.fd.str);
> +    case SOCKET_ADDRESS_TYPE_VSOCK:
> +        return g_strdup_printf("tcp:%s:%s",
> +                               addr->u.vsock.cid,
> +                               addr->u.vsock.port);
> +    default:
> +        return g_strdup("unknown address type");
> +    }
> +}
>
>  SocketAddress *socket_parse(const char *str, Error **errp)
>  {
> --
> 2.37.3
>
>
>

--=20
Marc-Andr=C3=A9 Lureau

--000000000000be72d305eb88ee09
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi<br></div><br><div class=3D"gmail_quote=
"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 21, 2022 at 2:03 PM Lau=
rent Vivier &lt;<a href=3D"mailto:lvivier@redhat.com">lvivier@redhat.com</a=
>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ren=
ame SocketAddress_to_str() to socket_uri() and move it to<br>
util/qemu-sockets.c close to socket_parse().<br>
<br>
socket_uri() generates a string from a SocketAddress while<br>
socket_parse() generates a SocketAddress from a string.<br></blockquote><di=
v><br></div><div>Tbh, as we are renaming functions here, I would follow goo=
d glib/C conventions and use the type name in lower case as prefix. I would=
 also not use &quot;URI&quot;, which should be reserved for RFC3986 complia=
nt forms.</div><div><br></div><div>So instead, I&#39;d suggest to rename to=
:</div><div><br></div><div>char *socket_address_to_string(SocketAddress *ad=
dr);</div><div><br></div><div>SocketAddress *socket_address_new_from_string=
(const char *str, Error **errp)</div><div><br></div><div>my 2c</div><div><b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Signed-off-by: Laurent Vivier &lt;<a href=3D"mailto:lvivier@redhat.com" tar=
get=3D"_blank">lvivier@redhat.com</a>&gt;<br>
Reviewed-by: David Gibson &lt;<a href=3D"mailto:david@gibson.dropbear.id.au=
" target=3D"_blank">david@gibson.dropbear.id.au</a>&gt;<br>
Reviewed-by: Dr. David Alan Gilbert &lt;<a href=3D"mailto:dgilbert@redhat.c=
om" target=3D"_blank">dgilbert@redhat.com</a>&gt;<br>
Acked-by: Michael S. Tsirkin &lt;<a href=3D"mailto:mst@redhat.com" target=
=3D"_blank">mst@redhat.com</a>&gt;<br>
---<br>
=C2=A0include/qemu/sockets.h |=C2=A0 2 +-<br>
=C2=A0monitor/hmp-cmds.c=C2=A0 =C2=A0 =C2=A0| 23 +----------------------<br=
>
=C2=A0util/qemu-sockets.c=C2=A0 =C2=A0 | 20 ++++++++++++++++++++<br>
=C2=A03 files changed, 22 insertions(+), 23 deletions(-)<br>
<br>
diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h<br>
index db4bedb6fa20..214058d8e307 100644<br>
--- a/include/qemu/sockets.h<br>
+++ b/include/qemu/sockets.h<br>
@@ -58,6 +58,7 @@ NetworkAddressFamily inet_netfamily(int family);<br>
=C2=A0int unix_listen(const char *path, Error **errp);<br>
=C2=A0int unix_connect(const char *path, Error **errp);<br>
<br>
+char *socket_uri(SocketAddress *addr);<br>
=C2=A0SocketAddress *socket_parse(const char *str, Error **errp);<br>
=C2=A0int socket_connect(SocketAddress *addr, Error **errp);<br>
=C2=A0int socket_listen(SocketAddress *addr, int num, Error **errp);<br>
@@ -141,5 +142,4 @@ SocketAddress *socket_address_flatten(SocketAddressLega=
cy *addr);<br>
=C2=A0 * Return 0 on success.<br>
=C2=A0 */<br>
=C2=A0int socket_address_parse_named_fd(SocketAddress *addr, Error **errp);=
<br>
-<br>
=C2=A0#endif /* QEMU_SOCKETS_H */<br>
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c<br>
index bab86c5537e1..01b789a79e62 100644<br>
--- a/monitor/hmp-cmds.c<br>
+++ b/monitor/hmp-cmds.c<br>
@@ -199,27 +199,6 @@ void hmp_info_mice(Monitor *mon, const QDict *qdict)<b=
r>
=C2=A0 =C2=A0 =C2=A0qapi_free_MouseInfoList(mice_list);<br>
=C2=A0}<br>
<br>
-static char *SocketAddress_to_str(SocketAddress *addr)<br>
-{<br>
-=C2=A0 =C2=A0 switch (addr-&gt;type) {<br>
-=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_INET:<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;tcp:%s:%s&quot;,<=
br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.inet.host,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.inet.port);<br>
-=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_UNIX:<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;unix:%s&quot;,<br=
>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.q_unix.path);<br>
-=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_FD:<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;fd:%s&quot;, addr=
-&gt;u.fd.str);<br>
-=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_VSOCK:<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;tcp:%s:%s&quot;,<=
br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.vsock.cid,<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.vsock.port);<br>
-=C2=A0 =C2=A0 default:<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup(&quot;unknown address type&quo=
t;);<br>
-=C2=A0 =C2=A0 }<br>
-}<br>
-<br>
=C2=A0void hmp_info_migrate(Monitor *mon, const QDict *qdict)<br>
=C2=A0{<br>
=C2=A0 =C2=A0 =C2=A0MigrationInfo *info;<br>
@@ -382,7 +361,7 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)=
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0monitor_printf(mon, &quot;socket address:=
 [\n&quot;);<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0for (addr =3D info-&gt;socket_address; ad=
dr; addr =3D addr-&gt;next) {<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 char *s =3D SocketAddress_to_str=
(addr-&gt;value);<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 char *s =3D socket_uri(addr-&gt;=
value);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0monitor_printf(mon, &quot;\=
t%s\n&quot;, s);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0g_free(s);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c<br>
index 83f4bd6fd211..9f6f655fd526 100644<br>
--- a/util/qemu-sockets.c<br>
+++ b/util/qemu-sockets.c<br>
@@ -1077,6 +1077,26 @@ int unix_connect(const char *path, Error **errp)<br>
=C2=A0 =C2=A0 =C2=A0return sock;<br>
=C2=A0}<br>
<br>
+char *socket_uri(SocketAddress *addr)<br>
+{<br>
+=C2=A0 =C2=A0 switch (addr-&gt;type) {<br>
+=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_INET:<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;tcp:%s:%s&quot;,<=
br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.inet.host,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.inet.port);<br>
+=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_UNIX:<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;unix:%s&quot;,<br=
>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.q_unix.path);<br>
+=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_FD:<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;fd:%s&quot;, addr=
-&gt;u.fd.str);<br>
+=C2=A0 =C2=A0 case SOCKET_ADDRESS_TYPE_VSOCK:<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup_printf(&quot;tcp:%s:%s&quot;,<=
br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.vsock.cid,<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0addr-&gt;u.vsock.port);<br>
+=C2=A0 =C2=A0 default:<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return g_strdup(&quot;unknown address type&quo=
t;);<br>
+=C2=A0 =C2=A0 }<br>
+}<br>
<br>
=C2=A0SocketAddress *socket_parse(const char *str, Error **errp)<br>
=C2=A0{<br>
-- <br>
2.37.3<br>
<br>
<br>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature">Marc-Andr=C3=A9 Lureau<br></div></div>

--000000000000be72d305eb88ee09--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:35:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:35:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427558.676747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpNK-0005lo-63; Fri, 21 Oct 2022 10:35:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427558.676747; Fri, 21 Oct 2022 10:35:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpNK-0005lh-2g; Fri, 21 Oct 2022 10:35:38 +0000
Received: by outflank-mailman (input) for mailman id 427558;
 Fri, 21 Oct 2022 10:35:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1olpNI-0005lQ-HM
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:35:36 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f4ca3c33-512b-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:34:35 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-449-3eY7vKtJMmWUC5Xz_P5i2w-1; Fri, 21 Oct 2022 06:35:31 -0400
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A5E5185A7A3;
 Fri, 21 Oct 2022 10:35:30 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 281612024CBF;
 Fri, 21 Oct 2022 10:35:30 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 11F0C21E6686; Fri, 21 Oct 2022 12:35:29 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4ca3c33-512b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666348534;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wOEGEZqptswKIUfgBEEm4tgnEbbBtNC3oZfW8NqaNe0=;
	b=O+TCiuSXwLedaKyc2JsnmmXQGmxmpZYK3D+BYcHZg1BRoW91VMxO8m7eqdJRHCaSW4DVOJ
	/ZCsVy6pd8eOJJ4AqAvvHNnflR+p2l7kZZJ9R/lORG2Qjp0XrqtaZIr/nk01lZXFkqA9g3
	7AQSJ9/nhLRMIrjDt7Z7SKkqnJw4R+g=
X-MC-Unique: 3eY7vKtJMmWUC5Xz_P5i2w-1
From: Markus Armbruster <armbru@redhat.com>
To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,  qemu-devel@nongnu.org,  Thomas
 Huth <thuth@redhat.com>,  xen-devel@lists.xenproject.org,  "Dr. David Alan
 Gilbert" <dgilbert@redhat.com>,  Anthony Perard
 <anthony.perard@citrix.com>,  Stefan Weil <sw@weilnetz.de>,  David Gibson
 <david@gibson.dropbear.id.au>,  Stefano Stabellini
 <sstabellini@kernel.org>,  Paul Durrant <paul@xen.org>,  Eric Blake
 <eblake@redhat.com>,  "Michael S. Tsirkin" <mst@redhat.com>,  Jason Wang
 <jasowang@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Samuel
 Thibault <samuel.thibault@ens-lyon.org>,  Greg Kurz <groug@kaod.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>
Subject: Re: [PATCH v14 15/17] net: stream: move to QIO to enable additional
 parameters
References: <20221021090922.170074-1-lvivier@redhat.com>
	<20221021090922.170074-16-lvivier@redhat.com>
	<1f769d00-cf50-abaf-f078-f301959156b9@linaro.org>
Date: Fri, 21 Oct 2022 12:35:29 +0200
In-Reply-To: <1f769d00-cf50-abaf-f078-f301959156b9@linaro.org> ("Philippe
	=?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Fri, 21 Oct 2022 12:05:42
 +0200")
Message-ID: <87tu3x1n2m.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4

Philippe Mathieu-Daud=C3=A9 <philmd@linaro.org> writes:

> On 21/10/22 11:09, Laurent Vivier wrote:
>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>> This allows net/stream to use all the available parameters provided by
>> SocketAddress.
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>   net/stream.c    | 492 +++++++++++++++++-------------------------------
>>   qemu-options.hx |   4 +-
>>   2 files changed, 178 insertions(+), 318 deletions(-)
>
>> -static void net_stream_accept(void *opaque)
>> +static void net_stream_server_listening(QIOTask *task, gpointer opaque)
>>   {
>>       NetStreamState *s =3D opaque;
>> -    struct sockaddr_storage saddr;
>> -    socklen_t len;
>> -    int fd;
>> -
>> -    for (;;) {
>> -        len =3D sizeof(saddr);
>> -        fd =3D qemu_accept(s->listen_fd, (struct sockaddr *)&saddr, &le=
n);
>> -        if (fd < 0 && errno !=3D EINTR) {
>> -            return;
>> -        } else if (fd >=3D 0) {
>> -            qemu_set_fd_handler(s->listen_fd, NULL, NULL, NULL);
>> -            break;
>> -        }
>> -    }
>> +    QIOChannelSocket *listen_sioc =3D QIO_CHANNEL_SOCKET(s->listen_ioc);
>> +    SocketAddress *addr;
>> +    int ret;
>>   -    s->fd =3D fd;
>> -    s->nc.link_down =3D false;
>> -    net_stream_connect(s);
>> -    switch (saddr.ss_family) {
>> -    case AF_INET: {
>> -        struct sockaddr_in *saddr_in =3D (struct sockaddr_in *)&saddr;
>> -
>> -        qemu_set_info_str(&s->nc, "connection from %s:%d",
>> -                          inet_ntoa(saddr_in->sin_addr),
>> -                          ntohs(saddr_in->sin_port));
>> -        break;
>> +    if (listen_sioc->fd < 0) {
>> +        qemu_set_info_str(&s->nc, "connection error");
>> +        return;
>>       }
>> -    case AF_UNIX: {
>> -        struct sockaddr_un saddr_un;
>>   -        len =3D sizeof(saddr_un);
>> -        getsockname(s->listen_fd, (struct sockaddr *)&saddr_un, &len);
>> -        qemu_set_info_str(&s->nc, "connect from %s", saddr_un.sun_path);
>> -        break;
>> -    }
>> -    default:
>> -        g_assert_not_reached();
>> +    addr =3D qio_channel_socket_get_local_address(listen_sioc, NULL);
>> +    g_assert(addr !=3D NULL);
>
> Missing propagating Error* (observed in v12).

*If* this is really a programming error: what about &error_abort?

[...]



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:37:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:37:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427565.676757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpP9-0006Ov-GI; Fri, 21 Oct 2022 10:37:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427565.676757; Fri, 21 Oct 2022 10:37:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpP9-0006Oo-DY; Fri, 21 Oct 2022 10:37:31 +0000
Received: by outflank-mailman (input) for mailman id 427565;
 Fri, 21 Oct 2022 10:37:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ExZL=2W=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1olpP8-0006Oe-1I
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:37:30 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2049.outbound.protection.outlook.com [40.107.21.49])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38b6639a-512c-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:36:29 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8424.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 21 Oct
 2022 10:37:26 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 21 Oct 2022
 10:37:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38b6639a-512c-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VIPnP/f78/cJ4Hx7qnFmuZcNf566S1qN6TvaazUbOoibv+KylsQn20fsuzIJOlxAr56JF1agsUd53CjpQeofA1nX8Wt4GoK3Na6kvF9ZOeGrAIlPvdHBX8NpZHYX/StynS2CRyBvzYB/LyGrOx444SXQjKaFLNh3fSBPGE2xCobiRJDnkMGFlJ33AoqbmZvpOpS8ZVQacsCGG0zch2+7wm7uB6gLQ/UGXgM1jgiGiWAZwp9CjfaIC6xGhNmfyOVIhfDVF/73wy/Wd/YNNLhlKlmWvVsUj4hPAxmfn6r84+K2XH47AWXv369wDKw1MLtfUxGenPBJv6X/ELcwIYjMGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=88Qep+hB+jSsnapbBIAqBKuOXczQAF8cRIZAj48FMio=;
 b=K0e0TPdqrckX5m8/4XCQ+9e4RrEAuCeE4hx96mXFT2NA39FktBlcCRw1b6CYrjH9UycYFDi6Yrz5oWUsSVtF7FhLyHW8d7sE73FPrKZnOCvSMq+ws5NMYWLVESnp8cPeCaD5Z93SbCf/jgQtHpsvpazm8Hb/QYSyAaQtbJ1TYo5aNjHC7kl0q8I3qSTWCahSheGYLfgz9xHvb+CbGQV5LAUWqTq1zh2ZV8YlVsh5EbIbVoNlBj0YRLxh4M2cuvrqT59kKIXKD9N2e8Sc5cE7OIO/6XkbUa4AY4InrhyKJKngTjVmbCFSw8bXkzZ0QZqt0XkDusnYJj6wMSQYkPrGGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=88Qep+hB+jSsnapbBIAqBKuOXczQAF8cRIZAj48FMio=;
 b=msWPkf7D9Jt4Qb4qzPF6UpffnLHXW7sBgz/sWRDcWGFL5u1f3/ITAZZkCxIETFddnJVxl6tWQHniiMXNGdlwBpiQTIv3mFe6BHrTWm0mhvu+gDhtr3hkfsY+2oN8py/5O4z5D2gaA2AZTysaZpsv6xFdv4DpZlcJspo+SD1e+JfwwxJcHhqGRABu/BkC03HDs+LlQV81FHHVTBEaqlTaMUaW6IWSTryNLODw6mlvGl0yTpFQcXK/8xLYbNt/zWQ8W86Jap4nEdHuu1XL8lOWGSnLN9fOR5GRwSrPSbTLzBuzCGNX+jeJ6T121KP5bdW13ZQsEy6nU8AiBP7MSJzE4A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2b767003-487a-d463-3a74-92d834fc8e11@suse.com>
Date: Fri, 21 Oct 2022 12:37:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>, Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org
References: <20221021065806.14316-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221021065806.14316-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8424:EE_
X-MS-Office365-Filtering-Correlation-Id: 959b0abb-9227-4481-72e8-08dab3503efc
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ypv4O1LUWzW7RCoyePC7eimWc+kYrSaoq/gXK8GWzQmbnaCPNmw6hLhFAGJP93uRTMqOKNMNvQHPrWCn8nUaEMvKH5BWRLc9vBHlZrWQ7XIchaocisTjCcEsBqWXaeqTCIbYSarBJxePqrgecqLFacrzoqFPtksbTNGplzfxFmwgspco/uXuqkj2PSmn7nHLfXnu+acT0AH8Ku+mmHOTHdOyL+8v4L7ppXvnzoqc7M1b4+CP1vgKZmjMV9vmDnZmjjkcxsHQJLJW0JlpgpPY+2DOeNyDIPFtM5j0NPXTsFtxKd9HXN2edOQe+syfziuB8VtnRBIyrqlq1DFRkLxUi4ie9HdBqyYJY+cgVthQGzUvdcLLUJLwDIH5Lm8EHHHFozGc357gl1uSKa8XmTjFoqlW5YhDbpAnvS3mGzQmXtll25WMbrWMw9cg6ZvMp6/yt4irP9sjkheVn/ZucP+gsnRdIGBjBtlkBtmtjVTy4Wix8K5gLf2DKCuE+8sh5n4T1Zw/1zW234eCUDkMSUTTH3tebno5E7/YI1vz6DEmSJ0c1lTXRqWqYvZVZE04/1dzmMEMgu9hoLeUUEimihUhgbIkdBB2EZ2Fzl6kbqceJuXTDy3Ihnqr0tIRF3RLklJacZit1Tc/gmteLOQq1vVMi9rC29TDwKvCOKZDjBnyddIAWb8kPgwq0jPoF5eHCTvP8yWDKv0sdJ15nuYrettYBFmYKHSCcwhFIuiJ90yLymeEiUEN9oYTO/QFwnjzEw7UiiyX+vdifBwjMR1fQUT+TZo+VtbvQV3r7JpJWBYcpOw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(39860400002)(396003)(136003)(376002)(451199015)(36756003)(31696002)(86362001)(38100700002)(31686004)(83380400001)(5660300002)(6862004)(186003)(2616005)(53546011)(26005)(6512007)(6506007)(54906003)(2906002)(6486002)(478600001)(8676002)(37006003)(316002)(4326008)(6636002)(66476007)(41300700001)(66556008)(8936002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXAxMk1abHhiSGhZWno2UWNpR3RwSmdRUmxoSis5alhxNGx1UmJ2eE9WbHRJ?=
 =?utf-8?B?ZWw1ZWZtb0dtL0tFYmZsRGd6V2dKSVAyVUtDOTRrMll1ckpjRVVjVVhMNjB0?=
 =?utf-8?B?d1hDRlE1b1VQVk52Z1pqUVFPNDE3MG1Ud2JaQ0JNbkpvbDM3c0U3TFZGaFQ2?=
 =?utf-8?B?SndzTU51cWdPUzdQUFVkOS9IUG1QSjVKa1Vna0VJVENacFhiMGFUbjdaVk1y?=
 =?utf-8?B?Z1VERndibzNrU0kyWVowUWVGTGZjVmFYeXNEUVpmRzc1YkpUOUxUVVpuS3RF?=
 =?utf-8?B?MFpjcTlVcVpUOWlHTUtKb1VvclZlTURPQUl3Z1dDYTc5WGlRK3V1UVc1REtX?=
 =?utf-8?B?ZW14bVQwUFJRU2pPSFVtbDdxcXZ5Zjg4cXNTM3pueGlUdzZEUjhvS2VGbXdp?=
 =?utf-8?B?cDY0a0VzNEFIS2ppOUN2YXQxaXI0dGpreTNVV3FZRXduSEpDbnFkYVZZeWVq?=
 =?utf-8?B?UDFWdGU5RTdkclR3cHpRRE9YMkUxN2N1aytnWlp6alFuY1ZwOHk2VU5jbXhp?=
 =?utf-8?B?SllUQU02YThZckoyQkp1VVdIdkdmdW0yUjNRZ3Vhc0pkRFY2Wks3NUlUZkVP?=
 =?utf-8?B?cHlDa2tYY3BPbzlpb3UwRVlIS2N0YlZQWVhxcEFtYXZIRC9qeVBxVHpRNjd6?=
 =?utf-8?B?M1JKZmVmV2pJTENVeU0xSXVSWXpUY1ZvOVl5S0FTRjgrQm51cDY1NzlVdTM3?=
 =?utf-8?B?TUozaXVZQkRNbHJTeTFWZXlSQXU1enhFNmNwd3g5MndrTFMxejF4cktaZXNp?=
 =?utf-8?B?VWFiN1NEVWNOb2J4cTNySTRxTmE4MGxRRXdVL21vdDNWV0N2SlFjYXZHcEUr?=
 =?utf-8?B?NWxkd1RKMFIxTWx5eThIY1ViNFFrRE8rMTA2SU1JNnRnNFdIa1FxbzFYelkr?=
 =?utf-8?B?bnFvd1dBYncvY1piRTBVTGo1T3ZKa2VOTy9aM3FkZ3Zsdlk1ZzlmZHhNbVEx?=
 =?utf-8?B?MFNlOTVIbk0zZWtqbGwyUEFqMWNpWTQ5RFFGWlUwWDhSZVdRbGtQYnB6NTBC?=
 =?utf-8?B?N1lTVXBiRVVqTmVCejVyTFIvdFg4c1orNVhSS0VzMDdUYXgxNi80MzhHZE15?=
 =?utf-8?B?U29obU93RDgwWVdRcGs5c0V5WHdlUlVpbjVqdi83TFdlS1BzWkw1TnJiZitw?=
 =?utf-8?B?RForU0E0Mzg1WDAvNE5vc3JmZVE3c3l5QlRadUJOZ1hYc1hKcW9Icnp0R1hS?=
 =?utf-8?B?ZGZmYW95OTNOZG9yZVBnRW5ldStCb1FaRlFHekVrcm0xTENJeGhMaHNmWGpX?=
 =?utf-8?B?Z2dCQ2RSa1V4Rit6R3BDY05nUmxQM1RPUUxOUDVmWkU5Q1hUWVIxV0F3YmNj?=
 =?utf-8?B?NDJkQUFBSzN1dkRFT2JaOEg0a1FLSE94OExmSzhnRTk2a0E2N1R5UmVKQ2hM?=
 =?utf-8?B?UGhMd04wcEZiZmRpVThkUW1JR3Z6QXBudXZmSno1bVNOcFhSR1k0M0dFN05D?=
 =?utf-8?B?RFh0UUtwdmE2cEFITFlYdFNCbVRwWUtPMWdMNU1kVlFHOFViSnVKWWlxNmZw?=
 =?utf-8?B?OHBoM1dPZ281TGxsTmtmV0cxLzk3a3VjK0UzbmZCMVJMN1FuSTk2WmtnRkZq?=
 =?utf-8?B?WXN1dzJGSE1UMWFQeVEreFg4VTlCdWhaNVFGVFJsZ2pianlLYzUxc1NMK1Nj?=
 =?utf-8?B?c2oveDl1TURTeEpwQnJKWnRzRTI1SlBnbWpocWlTeWc0VFFuTEtFVDhlSk5T?=
 =?utf-8?B?cS80bXBzK1VFVWZHd2lRc2pxNE9abW4rUkVBYmt3ZFFOU0xkSVlzNGFNVXNk?=
 =?utf-8?B?UmdKSEdrWjVFaXZibWRabkRLMGdrZXYrS05HdlZlZFMrSElrNFNkek9WMzNo?=
 =?utf-8?B?TG4xaHBxaUNWWFVyaExhbzQ1a1crdVRpcDMxeVlIMkpLRGwrRHdzTEdBOFBz?=
 =?utf-8?B?bXlubWJsZ0hMNW5Fd3AzajNCOC9mRVR3OWpKbVEzMmVmQkxQbnpxOWNJaU04?=
 =?utf-8?B?eXhUL2lDbUZyODk0dnhaYXBlRnd6RUt0NzNuUVBTRW1IaTMyMGRzWHgxK1U5?=
 =?utf-8?B?eGh1eEpKR0F4VVpaVmRFSTJtMWhKazNrcFVaMFM3azMwT0lVemVsNXZNYzdW?=
 =?utf-8?B?MFF0Q2JXUUxpYktlejFuY29RUmY0am85MDBpL2NIMkdDaEhVZmt6aHJ1ZmNt?=
 =?utf-8?Q?X1KouO0/VEBJz2u3ZTUGqii58?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 959b0abb-9227-4481-72e8-08dab3503efc
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 10:37:26.2927
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Kp8E6epVTlZVzJ+aeeEVr7gsNhA0VVbuOhNdH1izcglG/mcF+HQBZRjZ/X/oibC7rRdGep4R5dcUsDQSCZuGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8424

On 21.10.2022 08:58, Juergen Gross wrote:
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -1196,76 +1196,6 @@ static void sched_reset_affinity_broken(const struct sched_unit *unit)
>          v->affinity_broken = false;
>  }

My pre-push build test failed because the function above ...

> -void restore_vcpu_affinity(struct domain *d)
> -{
> -    unsigned int cpu = smp_processor_id();
> -    struct sched_unit *unit;
> -
> -    ASSERT(system_state == SYS_STATE_resume);
> -
> -    rcu_read_lock(&sched_res_rculock);
> -
> -    for_each_sched_unit ( d, unit )
> -    {
> -        spinlock_t *lock;
> -        unsigned int old_cpu = sched_unit_master(unit);
> -        struct sched_resource *res;
> -
> -        ASSERT(!unit_runnable(unit));
> -
> -        /*
> -         * Re-assign the initial processor as after resume we have no
> -         * guarantee the old processor has come back to life again.
> -         *
> -         * Therefore, here, before actually unpausing the domains, we should
> -         * set v->processor of each of their vCPUs to something that will
> -         * make sense for the scheduler of the cpupool in which they are in.
> -         */
> -        lock = unit_schedule_lock_irq(unit);
> -
> -        cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
> -                    cpupool_domain_master_cpumask(d));
> -        if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
> -        {
> -            if ( sched_check_affinity_broken(unit) )
> -            {
> -                sched_set_affinity(unit, unit->cpu_hard_affinity_saved, NULL);
> -                sched_reset_affinity_broken(unit);

... has its only use removed here. It didn't seem appropriate for me to
go and silently remove that function as well.

Jan

> -                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
> -                            cpupool_domain_master_cpumask(d));
> -            }
> -
> -            if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
> -            {
> -                /* Affinity settings of one vcpu are for the complete unit. */
> -                printk(XENLOG_DEBUG "Breaking affinity for %pv\n",
> -                       unit->vcpu_list);
> -                sched_set_affinity(unit, &cpumask_all, NULL);
> -                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
> -                            cpupool_domain_master_cpumask(d));
> -            }
> -        }
> -
> -        res = get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)));
> -        sched_set_res(unit, res);
> -
> -        spin_unlock_irq(lock);
> -
> -        /* v->processor might have changed, so reacquire the lock. */
> -        lock = unit_schedule_lock_irq(unit);
> -        res = sched_pick_resource(unit_scheduler(unit), unit);
> -        sched_set_res(unit, res);
> -        spin_unlock_irq(lock);
> -
> -        if ( old_cpu != sched_unit_master(unit) )
> -            sched_move_irqs(unit);
> -    }
> -
> -    rcu_read_unlock(&sched_res_rculock);
> -
> -    domain_update_node_affinity(d);
> -}
> -
>  /*
>   * This function is used by cpu_hotplug code via cpu notifier chain
>   * and from cpupools to switch schedulers on a cpu.
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 557b3229f6..072e4846aa 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1019,7 +1019,6 @@ void vcpu_set_periodic_timer(struct vcpu *v, s_time_t value);
>  void sched_setup_dom0_vcpus(struct domain *d);
>  int vcpu_temporary_affinity(struct vcpu *v, unsigned int cpu, uint8_t reason);
>  int vcpu_set_hard_affinity(struct vcpu *v, const cpumask_t *affinity);
> -void restore_vcpu_affinity(struct domain *d);
>  int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
>                           struct xen_domctl_vcpuaffinity *vcpuaff);
>  



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:39:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:39:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427570.676769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpRN-0006zc-UE; Fri, 21 Oct 2022 10:39:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427570.676769; Fri, 21 Oct 2022 10:39:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpRN-0006zV-Py; Fri, 21 Oct 2022 10:39:49 +0000
Received: by outflank-mailman (input) for mailman id 427570;
 Fri, 21 Oct 2022 10:39:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olpRM-0006zN-H5
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:39:48 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aefc994f-512c-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 12:39:47 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3D00F222E0;
 Fri, 21 Oct 2022 10:39:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 02E2B1331A;
 Fri, 21 Oct 2022 10:39:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IEXQOfJ2UmOQIgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 10:39:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aefc994f-512c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666348787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=SxgbxSMyb0IFJGx0g8YtqshvcZalAQw+dJK/WArNEog=;
	b=txepUFtSN5gyKNLYR8SWIaXWBdY49vmiII+MfWBoopNd8Y2zNTTyFUfW2GHxYIJq3csZx6
	WzW4YPCVzZbOS73PXpu0P0oLBDSmi95iaLP0UDCOG8I3VUVO1a9RMepIgAPeLkBkymXRty
	FUOnlsXDfjFMF+oCpDAhVjlrzTHNmwM=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Meng Xu <mengxu@cis.upenn.edu>,
	George Dunlap <george.dunlap@citrix.com>
Subject: [PATCH] xen/sched: try harder to find a runnable unit in rt_schedule()
Date: Fri, 21 Oct 2022 12:39:45 +0200
Message-Id: <20221021103945.4416-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of directly falling back to the idle unit in case the top
unit from the run queue happened to be not runnable, consult the run
queue again.

Suggested-by: Dario Faggioli <dfaggioli@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/common/sched/rt.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index 960a8033e2..1f8d074884 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -1080,15 +1080,20 @@ rt_schedule(const struct scheduler *ops, struct sched_unit *currunit,
     }
     else
     {
-        snext = runq_pick(ops, cpumask_of(sched_cpu), cur_cpu);
-
-        if ( snext == NULL )
-            snext = rt_unit(sched_idle_unit(sched_cpu));
-        else if ( !unit_runnable_state(snext->unit) )
+        while ( true )
         {
+            snext = runq_pick(ops, cpumask_of(sched_cpu), cur_cpu);
+
+            if ( snext == NULL )
+            {
+                snext = rt_unit(sched_idle_unit(sched_cpu));
+                break;
+            }
+            if ( unit_runnable_state(snext->unit) )
+                break;
+
             q_remove(snext);
             replq_remove(ops, snext);
-            snext = rt_unit(sched_idle_unit(sched_cpu));
         }
 
         /* if scurr has higher priority and budget, still pick scurr */
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:43:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:43:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427575.676780 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpUe-0008Oy-CF; Fri, 21 Oct 2022 10:43:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427575.676780; Fri, 21 Oct 2022 10:43:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpUe-0008Or-97; Fri, 21 Oct 2022 10:43:12 +0000
Received: by outflank-mailman (input) for mailman id 427575;
 Fri, 21 Oct 2022 10:43:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olpUc-0008Ol-TC
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:43:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 276c5174-512d-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 12:43:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6AB771F8CA;
 Fri, 21 Oct 2022 10:43:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 163191331A;
 Fri, 21 Oct 2022 10:43:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4EkCBL13UmN4JAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 10:43:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 276c5174-512d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666348989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=LzF3OBwfwloab9Lcfqr3ZlCK1ou/gF3cemkZ/4InwNI=;
	b=VvwzxUrHQFggLe6RzGhUv5YnJYOxRsCWTcRpyhILH3mRIYNiemiSFhfFWLQdnrufhYGKnR
	Zfx49CsHwebDZ1/gvYfzqb/eR7MJreogF2FDjyUlquJ1Dla9RkgrYCdQPVCW+7FLRn3gGZ
	3PneqyZlrSCKocm/FpmMcuUTd7kBXkk=
Message-ID: <0d80d3e3-11ec-22b4-cfc2-a315a9186f67@suse.com>
Date: Fri, 21 Oct 2022 12:43:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>, Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org
References: <20221021065806.14316-1-jgross@suse.com>
 <2b767003-487a-d463-3a74-92d834fc8e11@suse.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <2b767003-487a-d463-3a74-92d834fc8e11@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------ilnUQI7pNegR0xZs4M2FNX3m"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------ilnUQI7pNegR0xZs4M2FNX3m
Content-Type: multipart/mixed; boundary="------------KjJKFiKXCjJ8uY5d6TfPZypm";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>, Henry Wang <Henry.Wang@arm.com>,
 =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org
Message-ID: <0d80d3e3-11ec-22b4-cfc2-a315a9186f67@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
References: <20221021065806.14316-1-jgross@suse.com>
 <2b767003-487a-d463-3a74-92d834fc8e11@suse.com>
In-Reply-To: <2b767003-487a-d463-3a74-92d834fc8e11@suse.com>

--------------KjJKFiKXCjJ8uY5d6TfPZypm
Content-Type: multipart/mixed; boundary="------------jXU0xbZSfm0tFGHl5LwuPOPr"

--------------jXU0xbZSfm0tFGHl5LwuPOPr
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjEuMTAuMjIgMTI6MzcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyMS4xMC4yMDIy
IDA4OjU4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2NvbW1vbi9zY2hl
ZC9jb3JlLmMNCj4+ICsrKyBiL3hlbi9jb21tb24vc2NoZWQvY29yZS5jDQo+PiBAQCAtMTE5
Niw3NiArMTE5Niw2IEBAIHN0YXRpYyB2b2lkIHNjaGVkX3Jlc2V0X2FmZmluaXR5X2Jyb2tl
bihjb25zdCBzdHJ1Y3Qgc2NoZWRfdW5pdCAqdW5pdCkNCj4+ICAgICAgICAgICB2LT5hZmZp
bml0eV9icm9rZW4gPSBmYWxzZTsNCj4+ICAgfQ0KPiANCj4gTXkgcHJlLXB1c2ggYnVpbGQg
dGVzdCBmYWlsZWQgYmVjYXVzZSB0aGUgZnVuY3Rpb24gYWJvdmUgLi4uDQo+IA0KPj4gLXZv
aWQgcmVzdG9yZV92Y3B1X2FmZmluaXR5KHN0cnVjdCBkb21haW4gKmQpDQo+PiAtew0KPj4g
LSAgICB1bnNpZ25lZCBpbnQgY3B1ID0gc21wX3Byb2Nlc3Nvcl9pZCgpOw0KPj4gLSAgICBz
dHJ1Y3Qgc2NoZWRfdW5pdCAqdW5pdDsNCj4+IC0NCj4+IC0gICAgQVNTRVJUKHN5c3RlbV9z
dGF0ZSA9PSBTWVNfU1RBVEVfcmVzdW1lKTsNCj4+IC0NCj4+IC0gICAgcmN1X3JlYWRfbG9j
aygmc2NoZWRfcmVzX3JjdWxvY2spOw0KPj4gLQ0KPj4gLSAgICBmb3JfZWFjaF9zY2hlZF91
bml0ICggZCwgdW5pdCApDQo+PiAtICAgIHsNCj4+IC0gICAgICAgIHNwaW5sb2NrX3QgKmxv
Y2s7DQo+PiAtICAgICAgICB1bnNpZ25lZCBpbnQgb2xkX2NwdSA9IHNjaGVkX3VuaXRfbWFz
dGVyKHVuaXQpOw0KPj4gLSAgICAgICAgc3RydWN0IHNjaGVkX3Jlc291cmNlICpyZXM7DQo+
PiAtDQo+PiAtICAgICAgICBBU1NFUlQoIXVuaXRfcnVubmFibGUodW5pdCkpOw0KPj4gLQ0K
Pj4gLSAgICAgICAgLyoNCj4+IC0gICAgICAgICAqIFJlLWFzc2lnbiB0aGUgaW5pdGlhbCBw
cm9jZXNzb3IgYXMgYWZ0ZXIgcmVzdW1lIHdlIGhhdmUgbm8NCj4+IC0gICAgICAgICAqIGd1
YXJhbnRlZSB0aGUgb2xkIHByb2Nlc3NvciBoYXMgY29tZSBiYWNrIHRvIGxpZmUgYWdhaW4u
DQo+PiAtICAgICAgICAgKg0KPj4gLSAgICAgICAgICogVGhlcmVmb3JlLCBoZXJlLCBiZWZv
cmUgYWN0dWFsbHkgdW5wYXVzaW5nIHRoZSBkb21haW5zLCB3ZSBzaG91bGQNCj4+IC0gICAg
ICAgICAqIHNldCB2LT5wcm9jZXNzb3Igb2YgZWFjaCBvZiB0aGVpciB2Q1BVcyB0byBzb21l
dGhpbmcgdGhhdCB3aWxsDQo+PiAtICAgICAgICAgKiBtYWtlIHNlbnNlIGZvciB0aGUgc2No
ZWR1bGVyIG9mIHRoZSBjcHVwb29sIGluIHdoaWNoIHRoZXkgYXJlIGluLg0KPj4gLSAgICAg
ICAgICovDQo+PiAtICAgICAgICBsb2NrID0gdW5pdF9zY2hlZHVsZV9sb2NrX2lycSh1bml0
KTsNCj4+IC0NCj4+IC0gICAgICAgIGNwdW1hc2tfYW5kKGNwdW1hc2tfc2NyYXRjaF9jcHUo
Y3B1KSwgdW5pdC0+Y3B1X2hhcmRfYWZmaW5pdHksDQo+PiAtICAgICAgICAgICAgICAgICAg
ICBjcHVwb29sX2RvbWFpbl9tYXN0ZXJfY3B1bWFzayhkKSk7DQo+PiAtICAgICAgICBpZiAo
IGNwdW1hc2tfZW1wdHkoY3B1bWFza19zY3JhdGNoX2NwdShjcHUpKSApDQo+PiAtICAgICAg
ICB7DQo+PiAtICAgICAgICAgICAgaWYgKCBzY2hlZF9jaGVja19hZmZpbml0eV9icm9rZW4o
dW5pdCkgKQ0KPj4gLSAgICAgICAgICAgIHsNCj4+IC0gICAgICAgICAgICAgICAgc2NoZWRf
c2V0X2FmZmluaXR5KHVuaXQsIHVuaXQtPmNwdV9oYXJkX2FmZmluaXR5X3NhdmVkLCBOVUxM
KTsNCj4+IC0gICAgICAgICAgICAgICAgc2NoZWRfcmVzZXRfYWZmaW5pdHlfYnJva2VuKHVu
aXQpOw0KPiANCj4gLi4uIGhhcyBpdHMgb25seSB1c2UgcmVtb3ZlZCBoZXJlLiBJdCBkaWRu
J3Qgc2VlbSBhcHByb3ByaWF0ZSBmb3IgbWUgdG8NCj4gZ28gYW5kIHNpbGVudGx5IHJlbW92
ZSB0aGF0IGZ1bmN0aW9uIGFzIHdlbGwuDQoNCldlaXJkIEkgZGlkbid0IHNwb3QgdGhhdC4N
Cg0KSSdsbCB1cGRhdGUgdGhlIHBhdGNoLg0KDQoNCkp1ZXJnZW4NCg0K
--------------jXU0xbZSfm0tFGHl5LwuPOPr
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------jXU0xbZSfm0tFGHl5LwuPOPr--

--------------KjJKFiKXCjJ8uY5d6TfPZypm--

--------------ilnUQI7pNegR0xZs4M2FNX3m
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNSd7wFAwAAAAAACgkQsN6d1ii/Ey8P
HwgAgDW8hrpErkceD1RaXGhqQ+lt2BLDfudGgVsKGXt0U4xBf+xR6zthjBkEiCmYmKP/HVucw3Dp
dkOOe4xOrTyUezyVUygi19nXTZudJ6cPZEg0w+yQNNDULdO5MTX9dptiRFKo2oa2Nr4P5J/mT1fM
3MKNjQj7cVgq+tTnUWNE+6DgOXPdG9O/U/+AwwInaMjQ0FSiXaFHgJV3g3QJejyKnav8hugnlNB/
1Lndlk1evyq5SeF9QVjay+Y4AhhhCa5rID/o1dcBvPy1ZZ2BqJ3HEf5Mob5Mfc53HNyKuEj7WUAO
3djOzC2QfpPvZyzZMxBPR3Ue6d0Ly79v8XeC/L4jaQ==
=efAo
-----END PGP SIGNATURE-----

--------------ilnUQI7pNegR0xZs4M2FNX3m--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:44:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:44:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427581.676795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpVW-0000aD-SK; Fri, 21 Oct 2022 10:44:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427581.676795; Fri, 21 Oct 2022 10:44:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpVW-0000a6-OW; Fri, 21 Oct 2022 10:44:06 +0000
Received: by outflank-mailman (input) for mailman id 427581;
 Fri, 21 Oct 2022 10:44:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=opYQ=2W=redhat.com=lvivier@srs-se1.protection.inumbo.net>)
 id 1olpVV-0000Pz-9r
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:44:05 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 23ea166c-512d-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:43:04 +0200 (CEST)
Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com
 [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-647-JvMOhRKmM4KX9qQXO3c1Ag-1; Fri, 21 Oct 2022 06:43:54 -0400
Received: by mail-qt1-f199.google.com with SMTP id
 22-20020ac85756000000b0039cf0d41e2cso2199578qtx.13
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 03:43:54 -0700 (PDT)
Received: from [192.168.100.30] ([82.142.8.70])
 by smtp.gmail.com with ESMTPSA id
 bz12-20020a05622a1e8c00b0039a1146e0e1sm7904582qtb.33.2022.10.21.03.43.50
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 03:43:52 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23ea166c-512d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666349043;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qlhzrGdNNXcUHQesRH8bQ4YpN+DZcGJ2lAA8SoLbHRk=;
	b=eiL3r1Gxe6pIH1OXM1yFBnUYPyyAiWFPdqAsB5n72RkpnM/QqYXKLe/Tt7xb+++RisvCbb
	ugqwj9iqIcO0MFzbOQkHQUx1E3kkOubSbsYdyaxGAeIq8IXJMkdZ9VfYgFCI8sZhXmISu0
	1GGbFhrSH6DBB/6ZKJ834Rmzs2vakr8=
X-MC-Unique: JvMOhRKmM4KX9qQXO3c1Ag-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=qlhzrGdNNXcUHQesRH8bQ4YpN+DZcGJ2lAA8SoLbHRk=;
        b=1xxryqZ9XLEtcBTNIMmoPWZkuBaaZPyOE0wFt7af2qLCBkq5dAsf0JxJ0H+NBVGG2l
         1Eto+uYpVcpWpWb6C4QQKY9gTgSlgw0NfxvLVWaESj+oY1EI3P+Z/CAoRTVaEcjpK3xg
         1fLYEsOiRLVtcBv3V++fiAqrKc/j9i37psVEoZ4RdYOT36Akd9PFq9bHNzS4Hl1DOEao
         o2dokiIaujhLbB742Ef0/Gop3YX8z7svqWjqoB/G3iYNG2gWzFl2ZbLJ3jaz3/QG9Glo
         7KV+6Ae64BUex8+AD31B3nAKQCTY5JwfX5DXzwVgloUq5mOVH9IKpx3B1Pu/P3U8Z/Q5
         5iDw==
X-Gm-Message-State: ACrzQf1klkdlMl5y+r1WzJIs+I8yc1sX8pjRtyjKd0wqnNZAyVqtWC6S
	ezHIbA7tdKRqpPoLSnxV5h2Trp7sBD1NDpH+ys5sk60Ag2ArotuFDyAngqY3ncSLzIK2sGWCZ+M
	wEYsyq8mSehA6/3z7QdryzPdhz5M=
X-Received: by 2002:a05:620a:178b:b0:6ee:e0a3:1f27 with SMTP id ay11-20020a05620a178b00b006eee0a31f27mr13228088qkb.267.1666349033810;
        Fri, 21 Oct 2022 03:43:53 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM611EjOL522oIGakwDiiXV4Y0dKdy9c7EPJKbB8GjbY87oLC9A+yV2u/dKW1Qlv9YtxTj59wQ==
X-Received: by 2002:a05:620a:178b:b0:6ee:e0a3:1f27 with SMTP id ay11-20020a05620a178b00b006eee0a31f27mr13228065qkb.267.1666349033545;
        Fri, 21 Oct 2022 03:43:53 -0700 (PDT)
Message-ID: <881f1b6d-ac9f-a144-0e13-622981f02130@redhat.com>
Date: Fri, 21 Oct 2022 12:43:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v14 15/17] net: stream: move to QIO to enable additional
 parameters
To: Markus Armbruster <armbru@redhat.com>,
 =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
 xen-devel@lists.xenproject.org, "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>, Anthony Perard <anthony.perard@citrix.com>,
 Stefan Weil <sw@weilnetz.de>, David Gibson <david@gibson.dropbear.id.au>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-16-lvivier@redhat.com>
 <1f769d00-cf50-abaf-f078-f301959156b9@linaro.org>
 <87tu3x1n2m.fsf@pond.sub.org>
From: Laurent Vivier <lvivier@redhat.com>
In-Reply-To: <87tu3x1n2m.fsf@pond.sub.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/21/22 12:35, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> On 21/10/22 11:09, Laurent Vivier wrote:
>>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>>> This allows net/stream to use all the available parameters provided by
>>> SocketAddress.
>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>>    net/stream.c    | 492 +++++++++++++++++-------------------------------
>>>    qemu-options.hx |   4 +-
>>>    2 files changed, 178 insertions(+), 318 deletions(-)
>>
>>> -static void net_stream_accept(void *opaque)
>>> +static void net_stream_server_listening(QIOTask *task, gpointer opaque)
>>>    {
>>>        NetStreamState *s = opaque;
>>> -    struct sockaddr_storage saddr;
>>> -    socklen_t len;
>>> -    int fd;
>>> -
>>> -    for (;;) {
>>> -        len = sizeof(saddr);
>>> -        fd = qemu_accept(s->listen_fd, (struct sockaddr *)&saddr, &len);
>>> -        if (fd < 0 && errno != EINTR) {
>>> -            return;
>>> -        } else if (fd >= 0) {
>>> -            qemu_set_fd_handler(s->listen_fd, NULL, NULL, NULL);
>>> -            break;
>>> -        }
>>> -    }
>>> +    QIOChannelSocket *listen_sioc = QIO_CHANNEL_SOCKET(s->listen_ioc);
>>> +    SocketAddress *addr;
>>> +    int ret;
>>>    -    s->fd = fd;
>>> -    s->nc.link_down = false;
>>> -    net_stream_connect(s);
>>> -    switch (saddr.ss_family) {
>>> -    case AF_INET: {
>>> -        struct sockaddr_in *saddr_in = (struct sockaddr_in *)&saddr;
>>> -
>>> -        qemu_set_info_str(&s->nc, "connection from %s:%d",
>>> -                          inet_ntoa(saddr_in->sin_addr),
>>> -                          ntohs(saddr_in->sin_port));
>>> -        break;
>>> +    if (listen_sioc->fd < 0) {
>>> +        qemu_set_info_str(&s->nc, "connection error");
>>> +        return;
>>>        }
>>> -    case AF_UNIX: {
>>> -        struct sockaddr_un saddr_un;
>>>    -        len = sizeof(saddr_un);
>>> -        getsockname(s->listen_fd, (struct sockaddr *)&saddr_un, &len);
>>> -        qemu_set_info_str(&s->nc, "connect from %s", saddr_un.sun_path);
>>> -        break;
>>> -    }
>>> -    default:
>>> -        g_assert_not_reached();
>>> +    addr = qio_channel_socket_get_local_address(listen_sioc, NULL);
>>> +    g_assert(addr != NULL);
>>
>> Missing propagating Error* (observed in v12).
> 
> *If* this is really a programming error: what about &error_abort?

assert() informs the compiler that following code will not use addr with a NULL value, I 
don't think &error_abort does that. This could avoid an error report in code static analyzer.

Thanks,
Laurent



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:44:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:44:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427583.676809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpVi-0000zY-3p; Fri, 21 Oct 2022 10:44:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427583.676809; Fri, 21 Oct 2022 10:44:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpVi-0000zR-15; Fri, 21 Oct 2022 10:44:18 +0000
Received: by outflank-mailman (input) for mailman id 427583;
 Fri, 21 Oct 2022 10:44:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w2wL=2W=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1olpVg-0000Pz-DU
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:44:16 +0000
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com
 [2607:f8b0:4864:20::1035])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2a42b5c8-512d-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:43:15 +0200 (CEST)
Received: by mail-pj1-x1035.google.com with SMTP id
 f8-20020a17090a664800b00212464cd49fso2470544pjm.4
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 03:44:14 -0700 (PDT)
Received: from leoy-huanghe.lan (211-75-219-199.hinet-ip.hinet.net.
 [211.75.219.199]) by smtp.gmail.com with ESMTPSA id
 m2-20020a1709026bc200b0017fe9b038fdsm14399292plt.14.2022.10.21.03.44.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 21 Oct 2022 03:44:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a42b5c8-512d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=AwaPy+d6LI3STQKC7/Jh5UQQU+g4aL+S/nlqVl1s8uU=;
        b=NDZeKF4LQxZ2fpVGg1ulP3boB/V5ZWXAn7zMLdE5zD6ljc6uE1AvGYyCvj/ETO6gKD
         mg1Qabwszg7vboaVarzAlrlZC0i7Jf6lsT+XlijLfAs2/FeVlS6IRlGjfZamgdyvcZWl
         yzYEWQjXS3L43tYlDCRrEefLoUV5FwsJffoAnzIhl/EGuZJfZNE6NavvMUJcEVk+UlZJ
         20325QiyFIiIjxfNgetarY7xjbwhozYtoY9K39ze07Bf+7Mmk5B4vmjkqEiIN/T5+pgZ
         /l45B7JXm7i6yPCodFexyO62PXWUvjh2hqV2V6PCEQNVunQHly9St2j+qDL0EXFOFWFq
         NzfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=AwaPy+d6LI3STQKC7/Jh5UQQU+g4aL+S/nlqVl1s8uU=;
        b=o+1T4yNdaosYWjGsUFGmc1i8g9bVNn7rckB8ZLHaAX3Qs829fvSDJswyIYpn1ali3A
         IwbXkiEAsHc7S8cHcLS+Hv6Yk7KAjk/0WcF6Dj+qxPcQImRNJ8AenEWHbWSA5fzI4+ig
         Ag7Yc+xm3HHyUayUb8s+LdESCqdzx74U1t5okbxbYMTtQ9te9D8xc/3j0GrZZhVVSW7f
         MqXfzPawiWrOPonNqBWupT8nZ/Xgk4mD1XAH06eICsirqV4GwOpFwaZ8KSefB11RGj6Q
         6cX67e1vh1HlfD0MrjvPjomqEzx58nnCOORJZaLxQiRxPuvL7e664ZfTZcy/OfCr2eZd
         RqTw==
X-Gm-Message-State: ACrzQf38QFtA7cizpojpgzWpvmBf9ihAANJnj6nmSYwo1QAwCvYSl0vr
	tnPWOr6hBja25fFS2d8nmvzKjA==
X-Google-Smtp-Source: AMsMyM4V5GmxNTnHDNQrQIOVowh4fLCtBJlHOjVmTAA7uegaHFff/FAmiMFfcLgR5yxOGcjFVxNUUw==
X-Received: by 2002:a17:90a:990d:b0:212:d772:1ab4 with SMTP id b13-20020a17090a990d00b00212d7721ab4mr665069pjp.184.1666349053168;
        Fri, 21 Oct 2022 03:44:13 -0700 (PDT)
Date: Fri, 21 Oct 2022 18:44:05 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y1J39UsPlM8htxFx@leoy-huanghe.lan>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>

Hi Stefano and all,

On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote:

[...]

> > We can see DomU sends notification with timestamp (raw counter) is
> > 4989078592 and Dom0 receives the interrupt with timestamp 4989092169.
> > Since Dom0 and DomU use the same time counter and the counter
> > frequency is 25MHz, so we can get the delta value (in macroseconds):
> > 
> >     (4989092169 - 4989078592) / 25000000 * 1000 * 1000
> >   = 543us
> > 
> > Which means it takes 543us to let Dom0 to receive the notification.
> > You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
> > not have contention for CPU resources.  Seems to me, it's likely Xen
> > hypervisor takes long time to deliver the interrupt, note, it's not
> > take so long time for every skb transferring, sometimes the time for
> > response a notification is short (about ~10us).
> 
> Good find. I think this is worth investigating further. Do you have
> vwfi=native in your Xen command line as well?
> 
> After that, I would add printk also in Xen with the timestamp. The event
> channel notification code path is the following:
> 
> # domU side
> xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
> xen/arch/arm/vgic.c:vgic_to_sgi
> xen/arch/arm/vgic.c:vgic_inject_irq
> xen/arch/arm/vgic.c:vcpu_kick
> xen/arch/arm/gic-v2.c:gicv2_send_SGI
> 
> # dom0 side
> xen/arch/arm/gic.c:do_sgi
> xen/arch/arm/traps.c:leave_hypervisor_to_guest
> 
> It would be good to understand why sometimes it takes ~10us and some
> other times it takes ~540us

Some updates for why it takes several hundreds us for Xen backend driver
to respond interrupt.  The short answer is the vcpu running Xen backend
driver needs to switch context, even I have set options "sched=null
vwfi=native" in Xen command line.

So please see below detailed logs for how the things happen.

Let's take the timestamp 3842008681 as the start point, it's the time
for Xen backend driver sending out notification (xennet_notify_tx_irq);
at the timestamp 3842008885 the Xen hypervisor injects the interrupt
(it's about ~8us duration from the start point).

And then at the timestamp 3842008935 it invokes vcpu_kick() to kick the
virtual CPU for running Xen forend driver, you could see
VCPU_PROCESSOR is 11 and VCPU_ID is 9 for dom0, the duration is
10.16us from the start point.

The key point is at this point the vcpu's is_running is 0, this is
different from the case without long latency which vcpu's is_running
is 1.  IIUC, Xen hypervisor needs to take time to restore the vcpu's
context, thus we can see the virtual CPU 9 in Dom0 starts to run at
the timestamp 3842016505.

3842008548              pub-310   [001]    67.352980: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842008548
3842008652              pub-310   [001]    67.352984: bprint:               xennet_tx_setup_grant: id=52 ref=820 offset=2 len=1514 TSC: 3842008652
3842008681              pub-310   [001]    67.352985: bprint:               xennet_start_xmit: xennet_notify_tx_irq: TSC: 3842008681
3842008689 (XEN) leave_hypervisor_to_guest: CPU_ID: 0 TSC: 3842008689
3842008766 (XEN) EVTCHNOP_send: CPU_ID: 2 TSC: 3842008766
3842008885 (XEN) vgic_inject_irq: CPU_ID: 2 TSC: 3842008885
3842008929 (XEN) leave_hypervisor_to_guest: CPU_ID: 14 TSC: 3842008929
3842008935 (XEN) vcpu_kick: VCPU_PROCESSOR: 11 VCPU_ID: 9 is_running 0 TSC: 3842008935
3842009049 (XEN) leave_hypervisor_to_guest: CPU_ID: 2 TSC: 3842009049
3842009322              pub-310   [001]    67.353011: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842009322
3842009374              pub-310   [001]    67.353013: bprint:               xennet_tx_setup_grant: id=12 ref=780 offset=2050 len=1514 TSC: 3842009374
3842009584              pub-310   [001]    67.353021: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842009584
3842009625 (XEN) leave_hypervisor_to_guest: CPU_ID: 15 TSC: 3842009625
3842009633              pub-310   [001]    67.353023: bprint:               xennet_tx_setup_grant: id=83 ref=851 offset=2 len=1514 TSC: 3842009633
3842009853              pub-310   [001]    67.353032: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842009853
3842009899              pub-310   [001]    67.353034: bprint:               xennet_tx_setup_grant: id=5 ref=773 offset=2050 len=1514 TSC: 3842009899
3842010080              pub-310   [001]    67.353041: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010080
3842010121              pub-310   [001]    67.353043: bprint:               xennet_tx_setup_grant: id=85 ref=853 offset=2 len=1514 TSC: 3842010121
3842010316              pub-310   [001]    67.353050: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010316
3842010359              pub-310   [001]    67.353052: bprint:               xennet_tx_setup_grant: id=9 ref=777 offset=2050 len=1514 TSC: 3842010359
3842010553              pub-310   [001]    67.353060: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010553
3842010599              pub-310   [001]    67.353062: bprint:               xennet_tx_setup_grant: id=35 ref=803 offset=2 len=1514 TSC: 3842010599
3842010792              pub-310   [001]    67.353069: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010792
3842010838              pub-310   [001]    67.353071: bprint:               xennet_tx_setup_grant: id=17 ref=785 offset=2 len=1514 TSC: 3842010838
3842011032              pub-310   [001]    67.353079: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842011032
3842011072              pub-310   [001]    67.353081: bprint:               xennet_tx_setup_grant: id=18 ref=786 offset=2 len=1514 TSC: 3842011072
3842011124 (XEN) leave_hypervisor_to_guest: CPU_ID: 12 TSC: 3842011124
3842011265              pub-310   [001]    67.353088: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842011265
3842011309              pub-310   [001]    67.353090: bprint:               xennet_tx_setup_grant: id=86 ref=854 offset=3074 len=606 TSC: 3842011309
3842012807 (XEN) leave_hypervisor_to_guest: CPU_ID: 6 TSC: 3842012807
3842013038 (XEN) leave_hypervisor_to_guest: CPU_ID: 10 TSC: 3842013038
3842013568 (XEN) vgic_inject_irq: CPU_ID: 23 TSC: 3842013568
3842013639 (XEN) vcpu_kick: VCPU_PROCESSOR: 23 VCPU_ID: 10 is_running 1 TSC: 3842013639
3842013769 (XEN) leave_hypervisor_to_guest: CPU_ID: 4 TSC: 3842013769
3842013955 (XEN) leave_hypervisor_to_guest: CPU_ID: 8 TSC: 3842013955
3842014327 (XEN) leave_hypervisor_to_guest: CPU_ID: 5 TSC: 3842014327
3842014381              pub-310   [001]    67.353213: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842014381
3842014433              pub-310   [001]    67.353215: bprint:               xennet_tx_setup_grant: id=89 ref=857 offset=2050 len=1514 TSC: 3842014433
3842014621              pub-310   [001]    67.353223: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842014621
3842014663              pub-310   [001]    67.353224: bprint:               xennet_tx_setup_grant: id=38 ref=806 offset=2 len=1514 TSC: 3842014663
3842014852              pub-310   [001]    67.353232: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842014852
3842014909              pub-310   [001]    67.353234: bprint:               xennet_tx_setup_grant: id=4 ref=772 offset=2 len=1422 TSC: 3842014909
3842015153 (XEN) leave_hypervisor_to_guest: CPU_ID: 1 TSC: 3842015153
3842015345 (XEN) leave_hypervisor_to_guest: CPU_ID: 3 TSC: 3842015345
3842015823 (XEN) leave_hypervisor_to_guest: CPU_ID: 13 TSC: 3842015823
3842016505           <idle>-0     [009]    95.098859: bprint:               xenvif_tx_interrupt: xenvif_tx_interrupt: TSC: 3842016505
3842016635           <idle>-0     [009]    95.098863: bprint:               xenvif_tx_build_gops.constprop.0: id=52 ref=820 offset=2 len=1514 TSC: 3842016635
3842016648 (XEN) leave_hypervisor_to_guest: CPU_ID: 9 TSC: 3842016648
3842016671           <idle>-0     [009]    95.098865: bprint:               xenvif_tx_build_gops.constprop.0: id=12 ref=780 offset=2050 len=1514 TSC: 3842016671
3842016700           <idle>-0     [009]    95.098866: bprint:               xenvif_tx_build_gops.constprop.0: id=83 ref=851 offset=2 len=1514 TSC: 3842016700
3842016725           <idle>-0     [009]    95.098867: bprint:               xenvif_tx_build_gops.constprop.0: id=5 ref=773 offset=2050 len=1514 TSC: 3842016725

I did another two experiments.

One experiment is I tried to append option "dom0_max_vcpus=16" into Xen
command line, the purpose is I want to allocate 16 virtual CPUs for dom0
and 4 virtual CPUs for domU, and my system has 32 physical CPUs, in
theory the physical CPUs are sufficient for dom0 and domU, but I
didn't see any performance improvement with option
"dom0_max_vcpus=16".

Another experiment is to append option "dom0_vcpus_pin" in Xen command
line, this can allow the virtual CPU pins on physical CPU so can avoid
context switching.  With this option, I can see the throughput is
improved from 128.26 Mbits/s to 180.3 Mbits/s.  But this result is far
from the ideal throughput (800+Mbits/s).

One thing I need to explore is to measure the duration for copying
data via grant table (based on the log we can see xennet driver setup
grant table and then xenvif driver fetches data from grant table).  I
will compare the duration for two directions (from dom0 to domU and
from domU to dom0).  This part might impact the performance heavily.

Thanks,
Leo


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:47:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:47:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427593.676821 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpZ8-0001ym-JG; Fri, 21 Oct 2022 10:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427593.676821; Fri, 21 Oct 2022 10:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpZ8-0001yf-GN; Fri, 21 Oct 2022 10:47:50 +0000
Received: by outflank-mailman (input) for mailman id 427593;
 Fri, 21 Oct 2022 10:47:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zhrr=2W=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1olpZ6-0001yZ-Bv
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:47:48 +0000
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb39f43e-512d-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:47:45 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 8DA803200583;
 Fri, 21 Oct 2022 06:47:42 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Fri, 21 Oct 2022 06:47:43 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 21 Oct 2022 06:47:38 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb39f43e-512d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1666349262; x=
	1666435662; bh=BKrThsSHd2dY6s2MvGu8SZPANjCrL3zT8QZ9BWHePeM=; b=h
	nMefmewy13PD7ufHm+auo5FNZfkDji+kfmHpMSYlC5/9Hgj5LkDN9pAymSwCW5P4
	88/4q6hvuFVaw22YZ7xm7cMDuHN+kBKc07GI7cYbPOaQX/XNPGz6WiXMoHS2ghLt
	xGmT18J4K2Aj3AFbexZ4I1q2G3Ykp2aZd8SKyVyCUd5W++S/5vdwqxAr4jw+p6gA
	so/A3C2abF0MgPLgyI3vxPqqZyWRsLc+8iC7eJQTbtbzVnkbn7hU7M3oOq3KTGkM
	cWs8u6sjaM5zM2KusYmwGSKwbdiqcWrR31nS9cfqlKGJflr6vh19IGDnA6BPJlMo
	q+nBnkJhNmCKw4jkQ/FNA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1666349262; x=1666435662; bh=BKrThsSHd2dY6s2MvGu8SZPANjCr
	L3zT8QZ9BWHePeM=; b=dU4qBwPoV8719JGDkc4835Tl2v6m/d6q+IKHj6L9fv/Q
	Pg4Zof/iNmNryJZ7ycPZPWZUS4xrEJA2jRxyyBUpZ0LiyaMNAfDrdPMREk/5boa1
	SXNC7OxGAJogeyOB6qjbD4ZtFNMQlpvCbkarihmZfmFHjGo5W2mJqHq3Dh3hVIHI
	ZfYZgEbBGRMYQUeMJffRkPg4GGQrcBK7SzGWcB3oKWDiqMRBreTqFFj4Z2ehrgkw
	V2+PZQTCCRTnvRZi/AEHkIheIa15IYaQUZBII7eb49+YOrq7Sou7yAsSIY/zBhZa
	q++iSyzZZbTocb2jbSyEp5CFvtt4TFop7WP5oLquVg==
X-ME-Sender: <xms:zXhSY-dXcDW4gJE85cbRp65-IxUzND2HBszft8hyMZQrxGS3X1dAtw>
    <xme:zXhSY4MTuVLlvK1rGHM9ZU7_Jg_PRNLtnUWeKVnD9EfxLlZyI2kjWwcL8Q6agwjUi
    3ZWe25Rbox_QQ>
X-ME-Received: <xmr:zXhSY_hYeQ5w9PMdpqH0GX2U019QQIvA7zHT4d9tmt0wHqwTHXGdRU7sr5n0>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelkedgfeduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:zXhSY78dHYkM1n3XmJyR0m6ZUZoi2wMmLbwNboO2B760-lHjVEC11Q>
    <xmx:zXhSY6sId9Q1OGlUvcOfdCBVB2N1_etd4gyyDrF9EqijpgktSWiNJQ>
    <xmx:zXhSYyHvAjE-Haxb_cyHrEDInr1i8R4T_afyTvBcmNnxzWFeNva1Jw>
    <xmx:znhSY4BvkCd5gYeawj_WsSnkN6QUy29mrOm2wGVeo32lWkK4X8-SuQ>
Feedback-ID: i1568416f:Fastmail
Date: Fri, 21 Oct 2022 12:47:35 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it
Message-ID: <Y1J4x6gRYXoyo5Mc@mail-itl>
References: <20221021065806.14316-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="lD+LUEZELFm9I3Zc"
Content-Disposition: inline
In-Reply-To: <20221021065806.14316-1-jgross@suse.com>


--lD+LUEZELFm9I3Zc
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 21 Oct 2022 12:47:35 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by
 removing it

On Fri, Oct 21, 2022 at 08:58:06AM +0200, Juergen Gross wrote:
> When the system is coming up after having been suspended,
> restore_vcpu_affinity() is called for each domain in order to adjust
> the vcpu's affinity settings in case a cpu didn't come to live again.
>=20
> The way restore_vcpu_affinity() is doing that is wrong, because the
> specific scheduler isn't being informed about a possible migration of
> the vcpu to another cpu. Additionally the migration is often even
> happening if all cpus are running again, as it is done without check
> whether it is really needed.
>=20
> As cpupool management is already calling cpu_disable_scheduler() for
> cpus not having come up again, and cpu_disable_scheduler() is taking
> care of eventually needed vcpu migration in the proper way, there is
> simply no need for restore_vcpu_affinity().
>=20
> So just remove restore_vcpu_affinity() completely.
>=20
> Fixes: 8a5d50dd0b04 ("xen: sched: simplify ACPI S3 resume path.")
> Reported-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab=
=2Ecom>
> Signed-off-by: Juergen Gross <jgross@suse.com>

I can only test it on a different configuration right now, but I can
confirm with this patch applied the system survives S3 (and it did
crashed without it at least once on this config).

With the now-unused function (also noticed by Jan) dealt with, you can add =
my:

Tested-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>


> ---
>  xen/arch/x86/acpi/power.c |  3 --
>  xen/common/sched/core.c   | 70 ---------------------------------------
>  xen/include/xen/sched.h   |  1 -
>  3 files changed, 74 deletions(-)
>=20
> diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
> index 1bb4d78392..b76f673acb 100644
> --- a/xen/arch/x86/acpi/power.c
> +++ b/xen/arch/x86/acpi/power.c
> @@ -159,10 +159,7 @@ static void thaw_domains(void)
> =20
>      rcu_read_lock(&domlist_read_lock);
>      for_each_domain ( d )
> -    {
> -        restore_vcpu_affinity(d);
>          domain_unpause(d);
> -    }
>      rcu_read_unlock(&domlist_read_lock);
>  }
> =20
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 83455fbde1..358fa077e3 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -1196,76 +1196,6 @@ static void sched_reset_affinity_broken(const stru=
ct sched_unit *unit)
>          v->affinity_broken =3D false;
>  }
> =20
> -void restore_vcpu_affinity(struct domain *d)
> -{
> -    unsigned int cpu =3D smp_processor_id();
> -    struct sched_unit *unit;
> -
> -    ASSERT(system_state =3D=3D SYS_STATE_resume);
> -
> -    rcu_read_lock(&sched_res_rculock);
> -
> -    for_each_sched_unit ( d, unit )
> -    {
> -        spinlock_t *lock;
> -        unsigned int old_cpu =3D sched_unit_master(unit);
> -        struct sched_resource *res;
> -
> -        ASSERT(!unit_runnable(unit));
> -
> -        /*
> -         * Re-assign the initial processor as after resume we have no
> -         * guarantee the old processor has come back to life again.
> -         *
> -         * Therefore, here, before actually unpausing the domains, we sh=
ould
> -         * set v->processor of each of their vCPUs to something that will
> -         * make sense for the scheduler of the cpupool in which they are=
 in.
> -         */
> -        lock =3D unit_schedule_lock_irq(unit);
> -
> -        cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
> -                    cpupool_domain_master_cpumask(d));
> -        if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
> -        {
> -            if ( sched_check_affinity_broken(unit) )
> -            {
> -                sched_set_affinity(unit, unit->cpu_hard_affinity_saved, =
NULL);
> -                sched_reset_affinity_broken(unit);
> -                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_aff=
inity,
> -                            cpupool_domain_master_cpumask(d));
> -            }
> -
> -            if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
> -            {
> -                /* Affinity settings of one vcpu are for the complete un=
it. */
> -                printk(XENLOG_DEBUG "Breaking affinity for %pv\n",
> -                       unit->vcpu_list);
> -                sched_set_affinity(unit, &cpumask_all, NULL);
> -                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_aff=
inity,
> -                            cpupool_domain_master_cpumask(d));
> -            }
> -        }
> -
> -        res =3D get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)));
> -        sched_set_res(unit, res);
> -
> -        spin_unlock_irq(lock);
> -
> -        /* v->processor might have changed, so reacquire the lock. */
> -        lock =3D unit_schedule_lock_irq(unit);
> -        res =3D sched_pick_resource(unit_scheduler(unit), unit);
> -        sched_set_res(unit, res);
> -        spin_unlock_irq(lock);
> -
> -        if ( old_cpu !=3D sched_unit_master(unit) )
> -            sched_move_irqs(unit);
> -    }
> -
> -    rcu_read_unlock(&sched_res_rculock);
> -
> -    domain_update_node_affinity(d);
> -}
> -
>  /*
>   * This function is used by cpu_hotplug code via cpu notifier chain
>   * and from cpupools to switch schedulers on a cpu.
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 557b3229f6..072e4846aa 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -1019,7 +1019,6 @@ void vcpu_set_periodic_timer(struct vcpu *v, s_time=
_t value);
>  void sched_setup_dom0_vcpus(struct domain *d);
>  int vcpu_temporary_affinity(struct vcpu *v, unsigned int cpu, uint8_t re=
ason);
>  int vcpu_set_hard_affinity(struct vcpu *v, const cpumask_t *affinity);
> -void restore_vcpu_affinity(struct domain *d);
>  int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
>                           struct xen_domctl_vcpuaffinity *vcpuaff);
> =20
> --=20
> 2.35.3
>=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--lD+LUEZELFm9I3Zc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNSeMgACgkQ24/THMrX
1yyHAQgAkNfI118UqI8K4l+iNoRqBx/1N9XlfbfOvFiIfytM8k4BlxJEAzy5TmeE
P132Oi3RQfbZuXjxgTav4u869w7H5pep7EF6TwhVNUlPGDUYU4FwjOOlDxD3b6tF
gpNl+S0nE3SLVP6bUSV9sKfY+ObxjwbfykR29xB/XP2/5icq9u5pX02Tce0SECPH
MGr+WSMP2TBLG2duaJ41SoEfU5PVDBEyPlQtrrCkbiIrOFBtJS4RKXkg0bc4zZiK
E604ZQ+rjhb0i95m7x3gotJnfLkKS8i+bkkDnqVLHkZwxBR73sNPmv//QfyE2lBp
Y6DEAeXIUId1HaNXwL/osOX9CM+gXw==
=e07O
-----END PGP SIGNATURE-----

--lD+LUEZELFm9I3Zc--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:50:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:50:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427600.676831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpbt-0003Ok-4T; Fri, 21 Oct 2022 10:50:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427600.676831; Fri, 21 Oct 2022 10:50:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpbt-0003Od-1g; Fri, 21 Oct 2022 10:50:41 +0000
Received: by outflank-mailman (input) for mailman id 427600;
 Fri, 21 Oct 2022 10:50:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1olpbs-0003OX-JV
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:50:40 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3351a39f-512e-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:50:39 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B3ECD21FC2;
 Fri, 21 Oct 2022 10:50:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5F3FF1331A;
 Fri, 21 Oct 2022 10:50:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KDTZFX55UmPAKAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 10:50:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3351a39f-512e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666349438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ks5E3OIk9erHpwx/r8PUpwIk+tFEFyRztR1vnSLhO1g=;
	b=lxehLAypw4S4TyAa0wzcdfPY5WyjgGsDJZvd8VcohNtQT+SsNBOUha4X0mtEP+1LT1gUOq
	Z0YNM+oT1cA2y0uEs3iO3zM6kXFLEimUOgdaXny0cuIwCdcBfVNnd/XOOWol1C9l+sbI9C
	Om0a5O8KUKBkFxUNOfPBLVIAkbkBmP8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>,
	Henry Wang <Henry.Wang@arm.com>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Subject: [PATCH v2] xen/sched: fix restore_vcpu_affinity() by removing it
Date: Fri, 21 Oct 2022 12:50:26 +0200
Message-Id: <20221021105026.16186-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When the system is coming up after having been suspended,
restore_vcpu_affinity() is called for each domain in order to adjust
the vcpu's affinity settings in case a cpu didn't come to live again.

The way restore_vcpu_affinity() is doing that is wrong, because the
specific scheduler isn't being informed about a possible migration of
the vcpu to another cpu. Additionally the migration is often even
happening if all cpus are running again, as it is done without check
whether it is really needed.

As cpupool management is already calling cpu_disable_scheduler() for
cpus not having come up again, and cpu_disable_scheduler() is taking
care of eventually needed vcpu migration in the proper way, there is
simply no need for restore_vcpu_affinity().

So just remove restore_vcpu_affinity() completely, together with the
no longer used sched_reset_affinity_broken().

Fixes: 8a04eaa8ea83 ("xen/sched: move some per-vcpu items to struct sched_unit")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- also remove sched_reset_affinity_broken() (Jan Beulich)
---
 xen/arch/x86/acpi/power.c |  3 --
 xen/common/sched/core.c   | 78 ---------------------------------------
 xen/include/xen/sched.h   |  1 -
 3 files changed, 82 deletions(-)

diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c
index 1bb4d78392..b76f673acb 100644
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@@ -159,10 +159,7 @@ static void thaw_domains(void)
 
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
-    {
-        restore_vcpu_affinity(d);
         domain_unpause(d);
-    }
     rcu_read_unlock(&domlist_read_lock);
 }
 
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 83455fbde1..23fa6845a8 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1188,84 +1188,6 @@ static bool sched_check_affinity_broken(const struct sched_unit *unit)
     return false;
 }
 
-static void sched_reset_affinity_broken(const struct sched_unit *unit)
-{
-    struct vcpu *v;
-
-    for_each_sched_unit_vcpu ( unit, v )
-        v->affinity_broken = false;
-}
-
-void restore_vcpu_affinity(struct domain *d)
-{
-    unsigned int cpu = smp_processor_id();
-    struct sched_unit *unit;
-
-    ASSERT(system_state == SYS_STATE_resume);
-
-    rcu_read_lock(&sched_res_rculock);
-
-    for_each_sched_unit ( d, unit )
-    {
-        spinlock_t *lock;
-        unsigned int old_cpu = sched_unit_master(unit);
-        struct sched_resource *res;
-
-        ASSERT(!unit_runnable(unit));
-
-        /*
-         * Re-assign the initial processor as after resume we have no
-         * guarantee the old processor has come back to life again.
-         *
-         * Therefore, here, before actually unpausing the domains, we should
-         * set v->processor of each of their vCPUs to something that will
-         * make sense for the scheduler of the cpupool in which they are in.
-         */
-        lock = unit_schedule_lock_irq(unit);
-
-        cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
-                    cpupool_domain_master_cpumask(d));
-        if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
-        {
-            if ( sched_check_affinity_broken(unit) )
-            {
-                sched_set_affinity(unit, unit->cpu_hard_affinity_saved, NULL);
-                sched_reset_affinity_broken(unit);
-                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
-                            cpupool_domain_master_cpumask(d));
-            }
-
-            if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
-            {
-                /* Affinity settings of one vcpu are for the complete unit. */
-                printk(XENLOG_DEBUG "Breaking affinity for %pv\n",
-                       unit->vcpu_list);
-                sched_set_affinity(unit, &cpumask_all, NULL);
-                cpumask_and(cpumask_scratch_cpu(cpu), unit->cpu_hard_affinity,
-                            cpupool_domain_master_cpumask(d));
-            }
-        }
-
-        res = get_sched_res(cpumask_any(cpumask_scratch_cpu(cpu)));
-        sched_set_res(unit, res);
-
-        spin_unlock_irq(lock);
-
-        /* v->processor might have changed, so reacquire the lock. */
-        lock = unit_schedule_lock_irq(unit);
-        res = sched_pick_resource(unit_scheduler(unit), unit);
-        sched_set_res(unit, res);
-        spin_unlock_irq(lock);
-
-        if ( old_cpu != sched_unit_master(unit) )
-            sched_move_irqs(unit);
-    }
-
-    rcu_read_unlock(&sched_res_rculock);
-
-    domain_update_node_affinity(d);
-}
-
 /*
  * This function is used by cpu_hotplug code via cpu notifier chain
  * and from cpupools to switch schedulers on a cpu.
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 557b3229f6..072e4846aa 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -1019,7 +1019,6 @@ void vcpu_set_periodic_timer(struct vcpu *v, s_time_t value);
 void sched_setup_dom0_vcpus(struct domain *d);
 int vcpu_temporary_affinity(struct vcpu *v, unsigned int cpu, uint8_t reason);
 int vcpu_set_hard_affinity(struct vcpu *v, const cpumask_t *affinity);
-void restore_vcpu_affinity(struct domain *d);
 int vcpu_affinity_domctl(struct domain *d, uint32_t cmd,
                          struct xen_domctl_vcpuaffinity *vcpuaff);
 
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 10:55:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 10:55:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427605.676843 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpgm-00048Z-O9; Fri, 21 Oct 2022 10:55:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427605.676843; Fri, 21 Oct 2022 10:55:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpgm-00048S-LH; Fri, 21 Oct 2022 10:55:44 +0000
Received: by outflank-mailman (input) for mailman id 427605;
 Fri, 21 Oct 2022 10:55:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1olpgl-00048L-AD
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 10:55:43 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e75d6198-512e-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 12:55:41 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-39-1VDSkEuqP8Ka01rnX2mVLA-1; Fri, 21 Oct 2022 06:55:37 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com
 [10.11.54.8])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A1F4811E75;
 Fri, 21 Oct 2022 10:55:37 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id CC052C5FEC0;
 Fri, 21 Oct 2022 10:55:36 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id A5D6221E6936; Fri, 21 Oct 2022 12:55:35 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e75d6198-512e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666349740;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fL4PnehEm8f13PDLz7kiV4oIdcucSxynau12gJFqJSA=;
	b=CWq4ueXocTojoZ25G8nhze41Rj+G66jv1GjsakP0IZ6ufxgytb/kxkIABhD7YDwZdVmrbp
	m7L//HWpDc93wfAda35ptBYTGbEPRp1j9PNSqJLW3ERNtP0XsuikzuNnlwYtGFxm4noViI
	97uauPpdwUY+D/tRIrF6q9VFhMVCAtE=
X-MC-Unique: 1VDSkEuqP8Ka01rnX2mVLA-1
From: Markus Armbruster <armbru@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,  qemu-devel@nongnu.org,  Paul
 Durrant <paul@xen.org>,  Thomas Huth <thuth@redhat.com>,  =?utf-8?Q?Danie?=
 =?utf-8?Q?l_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David Alan
 Gilbert"
 <dgilbert@redhat.com>,  Greg Kurz <groug@kaod.org>,  Stefano Stabellini
 <sstabellini@kernel.org>,  David Gibson <david@gibson.dropbear.id.au>,
  Eric Blake <eblake@redhat.com>,  xen-devel@lists.xenproject.org,
  "Michael S. Tsirkin" <mst@redhat.com>,  Stefan Weil <sw@weilnetz.de>,
  Paolo Bonzini <pbonzini@redhat.com>,  Jason Wang <jasowang@redhat.com>,
  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Anthony Perard
 <anthony.perard@citrix.com>,  Laine Stump <laine@redhat.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
	<87lep935hn.fsf@pond.sub.org> <20221021114052.339f6aac@elisabeth>
Date: Fri, 21 Oct 2022 12:55:35 +0200
In-Reply-To: <20221021114052.339f6aac@elisabeth> (Stefano Brivio's message of
	"Fri, 21 Oct 2022 11:40:52 +0200")
Message-ID: <87o7u51m54.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8

Stefano Brivio <sbrivio@redhat.com> writes:

> [Cc: Laine, full quote]
>
> On Fri, 21 Oct 2022 11:12:20 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Cc: Stefano Brivio
>> 
>> Laurent Vivier <lvivier@redhat.com> writes:
>> 
>> > On 10/21/22 07:48, Markus Armbruster wrote:  
>> >> Laurent Vivier <lvivier@redhat.com> writes:
>> >>   
>> >>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>> >>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.  
>> >>
>> >> Use cases?  
>> >
>> > This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.  
>> 
>> Let's add something like this to the commit message:
>> 
>>     This lets libvirt notice when the connection is lost somehow, and
>>     restart the peer (such as passt).
>> 
>> Who's working on the libvirt part?
>
> Laine Stump and myself. Nothing to show yet, though.

Good enough for me :)

[...]



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 11:08:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 11:08:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427610.676854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpsl-0005lR-Tq; Fri, 21 Oct 2022 11:08:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427610.676854; Fri, 21 Oct 2022 11:08:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpsl-0005lK-Pe; Fri, 21 Oct 2022 11:08:07 +0000
Received: by outflank-mailman (input) for mailman id 427610;
 Fri, 21 Oct 2022 11:08:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1mzs=2W=citrix.com=prvs=28632f022=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olpsk-0005l8-2T
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 11:08:06 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a0591d95-5130-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 13:08:03 +0200 (CEST)
Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 07:07:59 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SA0PR03MB5611.namprd03.prod.outlook.com (2603:10b6:806:bf::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 21 Oct
 2022 11:07:56 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 11:07:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0591d95-5130-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666350483;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=1q+SXao/O4tCvCbHRfo58mEzeauQ/uzK8NowfFpLEns=;
  b=P5kG0A5pWTieCK3MpdcYajF6CMrdxzWI8WuGVwFFcoVn8Gvupch5i8T7
   RDrTo/eWyJRHz8ud1ky4xtZZVDlSqeUz//FwQ1W2Kjrl+aeB3hHLdLhQC
   6Jc7nayJwVqeQ9laEUGZU3fvrXkqhim1/TM14ylXEkAVa3x7URlG1rQ//
   A=;
X-IronPort-RemoteIP: 104.47.70.105
X-IronPort-MID: 83254189
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3AqzwhEaAMU5XdMhVWkefolAYPlx7EJoYKDSr04?=
 =?us-ascii?q?L1icEF8aCcT4heQU07ArUqNFxZbRdHnUmJwcRT8AexJdDrOOQsxw/KwnzBVt?=
 =?us-ascii?q?Y21JjzeJeG6eYGzdhbNoMhgYURaVpsw33cKaHaoaMlynJCRidbIOQfu5N3kt?=
 =?us-ascii?q?2qZvhJLVypltq6FC2hH7nhEi9dx9x+WE5ojWKRqpH4B5jJY6h4mzY0UBGZn/?=
 =?us-ascii?q?pwxs9m2z+ZQo3RRQKvgW60uC579f/57hSLsZRZULv6HhIxr7eCJhnSxC2SB7?=
 =?us-ascii?q?+qhAur3ncYQj8IWyMnsRQnviIhUWp/jUyRHdlicUy1vexzbVXDeL0oYObD6Q?=
 =?us-ascii?q?GLtQ+UQIbJwJ9RaD6rxMb/Wnwc5DRpALBxO/nCkPF3LHUXTrfheoXn8ePOzw?=
 =?us-ascii?q?FNjmpCAdaTI4JKsRjm41WANWcEVitZLJbQmmVMVTtTc/Qfofs4t0A7N6AI7e?=
 =?us-ascii?q?Zf78c53fYtB5fB1xVQE67XFsXCSSVsqUsSAqqYe0d+VOYpkMgfipCSqJUCmS?=
 =?us-ascii?q?xnSN8jwHwryjwE9h9JfAl9s9p+sBrlhJv2qDo9R9AN9xr0cm5rB8mCPOYxYn?=
 =?us-ascii?q?N+8ILdfuIU47vVDEPwlxWmzL4gXB9EuZ4odsfGJVTL2VSefS0EGPogJOUTfM?=
 =?us-ascii?q?A+DqovWSY41DSLI16VT5M91Vij8vCnUrUII4cniTvHPE2oB07/jkIRULQT4O?=
 =?us-ascii?q?VMKx2M4x0DKEBaLQ4RtE3/UjyyXcYavCzo8ufuS7e2LivCIcu60YhKcBqz42?=
 =?us-ascii?q?Uf+hjW6FpsorbPaP07g5vO30s18lAgvpkkid8ZmnjRiRQHsv89MaqZ1mJruv?=
 =?us-ascii?q?tiskKa+KxTImAxvm07Nfi/ZPr4vGtgZsehbH2UThllHGZ6J9+eh8yi8rt8Ms?=
 =?us-ascii?q?PSYmHH7TFCSxcPtBAmQOB38f5vW0Wshk5jXemJc6nEfuBxjNZ3CyC9yqtSwc?=
 =?us-ascii?q?bSnndBZMjWGs2+6vSzppYh/1BSTV7voly2dljEAT25wBFDXVxWedXeg4kMEO?=
 =?us-ascii?q?7hdDX/lF6wg13tngZgcoJWFOvBmH4U5MJXkRw8Z8oww/kZYVci46B7ffXWY7?=
 =?us-ascii?q?iDXfddhc381wcwg7u1gt5iSdFFRDho1OzkkIh9lIDvCquZ1podUZrsBlDvh0?=
 =?us-ascii?q?BeCDoX+xT8MYCL8ALWv1II3Oa6bdtiyzXBbXAAyS/bMF3l2qvz+ZdqfAgEtK?=
 =?us-ascii?q?t2wxSWMZOYObbHhocyt8e9SNOxw6t9PSrgkNcXBk9KIagXb9rNtT/Z5IbpWH?=
 =?us-ascii?q?eoh0UQ0VLS47uxwvcxFIWNt30aYLF/mySE0WIjqv/rDWpgqKg7+Z56YC/Z/k?=
 =?us-ascii?q?0p+Q2TFZwnNNPTYqI73bBJBfcimJvdLKb0V96mbeGJZR4G+FvKOM1bMqyBxE?=
 =?us-ascii?q?iPCoDPCNL134JNrKcSjfD0qwUapXvl7vi6H10NVORsd+mjQ8HLJ42thi3uvv?=
 =?us-ascii?q?/j4BLxzlg+K4K9PKs4GoeXK2GrbylM3FHbXQJMPJJQIYzEyyayskTZyNJyUO?=
 =?us-ascii?q?DmCGoIk0nOmMKYi8vzyR7pPBg3O19XeM9GIDS1a/dEDJsMVpdfBsRranj/ux?=
 =?us-ascii?q?dQSaOML+1TRg3GPoR6GMVnnTr1ZWg2GNv6x2JSAhJnKsJ9TaSr8KI66Fb6v/?=
 =?us-ascii?q?hRIDP2HX/888b0h5CVs7dvzIkgnEaMHPox+fdzDVStEZLWayeP24QNeQec5n?=
 =?us-ascii?q?ZNZ9fzwqmiSFoF6S15Vs2gjXVeqcSLvHzer5k6orpkXFUTdFMK0s3zx6JUPu?=
 =?us-ascii?q?Jo+CKGAUnBI17vA7K6lkAwAodwiWwi6sKR+Ld9VkKTZ0lDtTn6Samaa+cy8C?=
 =?us-ascii?q?YSnCrzSQUlvWgBz0L1mN+T9RNZMNpTkX1CPJv+5Dps2YFLDciRtUirZ1QJV0?=
 =?us-ascii?q?lzr6opISJV9AWoN7rUuXLFBAHqcJ6Km+1t+g06hiAB/wrfr829jwkRGqliLv?=
 =?us-ascii?q?+5V0nbu/7Yh4pYAhlscUG43JX8wbZfU6WvaE1TxQASet0eALPm4LDUDCg6is?=
 =?us-ascii?q?h6q1U913nnjk8tHWpy+KPTCTb25Enw/bkqZBf0IoLp2CuW3uxs8ei+CKdhc4?=
 =?us-ascii?q?J5yvO0shUvQIMRjMHzRGaxcjPE1wtq6/7aoay66M+K5TudoZ3kOKRReWDPgd?=
 =?us-ascii?q?n+NO537NtJ0D47WMTdUQDRgU3udMlFmZKL4Amm8py7ZhAuVRcboZLB5l4zqb?=
 =?us-ascii?q?EQl+YLTMPtlvMTpI1GQFI9G5+0rMAyRUj5dNd0t71bU91qhvLe4lCFqz9XMo?=
 =?us-ascii?q?HAxbQ7a8QyHQV0KVlpzN1R382P26dhIcCgrOqLqeKVF8LECMNNnW6MWx3P33?=
 =?us-ascii?q?mOIeX9CuNpsA+IOvu7q4V8bXTM9AJkCrulhF32rcv2fyWD9mGPJRFD7FEAWS?=
 =?us-ascii?q?rHoZGkoQz6GcV07jMcSvzI2kySueKKen27jNWNhAolv2YMl+7kyDLvK0r2Wh?=
 =?us-ascii?q?QUcm2BFuNjQ3h19e6/2KHoVLruRupTe6vRhRm6eP8dwu+xeO57JcQAzPxtop?=
 =?us-ascii?q?u5Eyj27SBs3BsHkObYNNXscrGcOMo+KU5eb+KTmW0SQmFcHs0VmFMiVGExE7?=
 =?us-ascii?q?rRLunUFVD8UPSE4nfx7iHPVoA815yKitEG8iSTJc24/jMF05xCsD1lTZok0r?=
 =?us-ascii?q?v8050/YZ0aWKTSOv5/G/Ygx5TQxp6a5p9ncoUsaMDqiYGfUoWDyu3RPEu7RW?=
 =?us-ascii?q?6kAUUNfm8iNrqJMnkvCpkIlJ4iKw2PyKFcROKs4LS6nOMF+jI47VvFbpkz76?=
 =?us-ascii?q?PEWlAAgL+i0QaMzUhHV+zDG7VV71OXPzlnL3M04gAZklsu85hah6YB0J9KTF?=
 =?us-ascii?q?nq4nwBbHbwaf/T5Z/jmNvT9ZM7lRUQyF+t40npJyCggaJrhBhv4i6F8l+UA/?=
 =?us-ascii?q?+fz3FM=3D?=
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208";a="83254189"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h/ERgk/FasxgZcVEB+upE40um5GXefiekg/B3ZYlnIquwvGsvffRSMAvi4VlptkG4TmUrR6FSHjTYG4Y/kCNjiFHDmSSxaWcA2vJesXStho1lyG9P4nURu/71p1yFkmnlnVqBLXzPjytDFWSD+7KzliO29c0UoP9zFd4ys936qV91VKg61muoDU2JW85HoAlOIHH/pNepK0mbetBvYXffRm5WyRmR+6RghhIx8CHjmLsH5GqOSL3aGJimjgVrH0RtfkSs2IJxVbfiUi5zQBXZmTwNUnCrhYgLqhJPhFqDOMGPri75N2ijruI/BXVw0QZon+8CgG7+3pYf1T7f+lULA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1q+SXao/O4tCvCbHRfo58mEzeauQ/uzK8NowfFpLEns=;
 b=aiz/W5fMVbaaWb6V8IJcxvnk+s9sZ0GfaZGOHbfuLcYhbu/h6IN2sXDfHp+1P4giLvxw0BWolHxsMuLyBcz96ZRISDn143BaJwFSe/sgk8W2sMKqxoNvn+rf6c3o/9ozPK25hQkMT7rFBuMVwLhIg7es+bwO7diIFVGbOlGfNN5yFyL1f020kZ8C9+wrtBxBLyFBxRSpVFMAxtPlDwB72b1OozIMGr7bMuhOwJviZsmxv0P8CP0wKCj17aBEERFKwlBjw9zX8uabMctMkh8QvkkDN9JzOG5t8Slm9LnYztU4kUFObaHm7H/vPIqjiV5seM7WUxzM3qV5DymVEj+Z1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1q+SXao/O4tCvCbHRfo58mEzeauQ/uzK8NowfFpLEns=;
 b=k7jSz4XBgSzKxsXwZqRW/3y9AzC3iP2k5jF1pEGGrdzUG1CIPZ23Z832YGaWkF4Ge8IKv9TXVBPjX9tCXCNNWgYMePkbn0naWkQo5/mQk1Fa5RACPA5RmVUlSG7e2lr6pi27rGyt/nqqFeygAqLksAwUesaFY+zVq53GnXK24LQ=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>, George Dunlap <George.Dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Dario Faggioli
	<dfaggioli@suse.com>, Henry Wang <Henry.Wang@arm.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v2] xen/sched: fix restore_vcpu_affinity() by removing it
Thread-Topic: [PATCH v2] xen/sched: fix restore_vcpu_affinity() by removing it
Thread-Index: AQHY5TsCDBxhIyGpEE69vEHtm4vF364YsEgA
Date: Fri, 21 Oct 2022 11:07:56 +0000
Message-ID: <5ff6c502-dfd2-c0f8-9776-c6a974aa2bb1@citrix.com>
References: <20221021105026.16186-1-jgross@suse.com>
In-Reply-To: <20221021105026.16186-1-jgross@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SA0PR03MB5611:EE_
x-ms-office365-filtering-correlation-id: 90d45a00-e8a5-48f7-3cf0-08dab35481f2
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 pri6W66VGOyRwrNlBx7Pws/uQY9MbNXEG0242Iobhk3i2VpnaqNSYBRhJ/NYfMxNYf+BK6BhOQusNTcZ5iaRO41CXyVyRE2PEVAvcJANwLnpNOHcU6paIGNMEoOn8L0KUa6i6q2uMq0gQMx2kC329dCoe4D+xjguCkkEx26RZK1Pg6dQWgWtilMyjnZnfks2YRTFD4m4mYady+mfQU/IRufZl0jsKDCkxHDs40bjJrk2EjhoRM2XVYooZSfzh1hGnLV2Rx/U2qPvtAcsrp2pGPxBeOljVYVF2IIQNpjFsa0kD1lzMHJztwpVAqiHQnqUY/ikk7QVNDZ8QoiFtwcyinudYHHMBhoHan0i/s8DhrOk+Q06avSRz4mR/088Cbg7h28ZMO7tlBrhjOVJdFLUpHWcNUmn6AfW5tTKz3cAwGkSuDztsmlglr77FAb9NgyUHbtJGsUOWCxKvHKPty89F6Dstse5FP7lz4D8JQIuYtq9yKdkHKm5jsOfXe5KLarOV3FehkSxXg/dY43CLz7GD8rCIDpxo2KTGpg71PvHu5ZbGuoeX3nZFtFPA1/9ZDsQbMZZLF+2u3sVidn57852k9LX67YPkruwo8F765NepKXgmomSehjBDnK752p0lFtI9cIahYjoI1UXoVgvJHT3uqsrng813i55SdkAsT79pSPqf0kGlIlpRUaBiWSVvr+8ST9aIP1aGrkf530tWDQ3Jo27TiptH5s+CsA8Is8LUu2ZlAp2EoMC16MMlhRqtPrSLIxIXk0s8OX3V6woVgjIUIG+DCdw1xfda56vhCNtcPBCKuzyMZwnGrTRP7rW3lMkFCMGF3eUb92fxtHGG8VgXg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199015)(186003)(66574015)(31686004)(36756003)(86362001)(31696002)(71200400001)(2906002)(122000001)(38070700005)(38100700002)(82960400001)(83380400001)(26005)(2616005)(53546011)(6512007)(6506007)(8676002)(41300700001)(316002)(66556008)(4326008)(91956017)(6486002)(478600001)(64756008)(66446008)(110136005)(8936002)(66476007)(76116006)(66946007)(54906003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?QXJPN0JxM2dGaVE4dnBrcHQwNjM3Um56SEwxRE9sUDd0U0gzaEt4dDNDeXhC?=
 =?utf-8?B?VHVQL285RE1oRWJuejdaR2RKYUhyMGZJQVlYeG82TUo5a2ZacXlsV0Y0YzA0?=
 =?utf-8?B?WllwU2VlQ29XV2E1ci81anVDTkhPYU02TW9jTXo0clJCTjZoYlVKYWlVTjAr?=
 =?utf-8?B?U0MydHNMc3RGMmVqZzVqdlRNeXBoT0NwQ3dMek9EaXBxWFkzTkd1OHFsajNu?=
 =?utf-8?B?TlRCZTUvd0tGVm1SMXZVSFRYM0poTmlxbGIzckF1QzhzSHI5TWhpOGp2c3BP?=
 =?utf-8?B?ZXB0Ynh4TFNlOXM5R291Y0RabFJEZDVyVGJvc0lIR09EK0h3Uklpb3J6aFNm?=
 =?utf-8?B?eFg3YTd1V2NXc3N2WVVsK2VMOTF0N3hyUks0S3F1UHRBeFdidWltVWxtY1hm?=
 =?utf-8?B?dllwK281bk5HOXNRbmczYlFwRmhrY3AySVRDRVZ2dW9QbFVNOG5JZ1RBSU8r?=
 =?utf-8?B?Q1UyNVlXK0VMY09OWGxUV2RPVVFMc0JjVnZhUGxKcUhkOWU5WDQ0akN4eHYz?=
 =?utf-8?B?VmplVW5nS0kwUks1T0tsWmNtS2kzTktYcXlUd0VjMW81UHBjM2p4bXZiQzhq?=
 =?utf-8?B?SlhWaU9nOSt4R2srQ0hnN0YzT2JNZDluK3NuZjRRcmh0dTA5TUpCUURhVDdY?=
 =?utf-8?B?eS8rdXlYcm8wNlNkZjFONVpzOXFHR2hUUjlpdUU5SEg3SVJUdzdVdWZLUkFq?=
 =?utf-8?B?eTY4OS9tZ29xVUZQSng2YU9UMklSZy9Pb29GRU80NkNBZGxiOUhIOHFMd0hX?=
 =?utf-8?B?Znc0bVdaYktld2pleFdoaHRpL1MvYkIyMHdkeEM2c1pHLytSOHllYVZpMVd4?=
 =?utf-8?B?a1VSWGRxamhaSzF4ZFhjTTBSemE2YmkvMEUrL3NleHBKMDRlcDQyWFhvSzFF?=
 =?utf-8?B?Q0FLSmNRZmU0NTh1NkhYTmZYeGRuOGFBZGhCd2I3TE5kcndvQjYxbUV3TzNy?=
 =?utf-8?B?a2dyR2JTalRJY0g5OVpGZXJ4MWNLRDBzdTkvWXI4L0o2N3pjSGhxb01nenFl?=
 =?utf-8?B?Nnk2cUhmSjB1cmpCa29nT0YzbjBCbWFWUzlpK3liYkhFVXhTdmxoYmFoaHUw?=
 =?utf-8?B?UnMxZlJ2N29ZSEljVWEwa1hFTFdmcTlBZmw1c3UrRDYxc0JkaGY3TTBmdjY3?=
 =?utf-8?B?SjhnYjJVT1VoZTVpc1R6N1Y3UGtDam5Ha1dpNTltNjlBRXJlWi9KaXZiMmNr?=
 =?utf-8?B?cmZhcmpwbHhNcmh1WWxMR3FIbHRSVzRVTXVmZTVOTjRJaU1RMUsrVDN2RGJz?=
 =?utf-8?B?QXpnSUxQN3RoTE5yZVBrNktBT0VueG0zNDVSbVVqZE9rV1ZiRlFiVTRIZWps?=
 =?utf-8?B?aHd5Rm84Sk5ld2ZKRHRhS2dGKzIzemYxaVdHVW9lcWFKSi9DcDdBcUhJVTJQ?=
 =?utf-8?B?VXF2Y05UYWVEaXR4elpGbmJYUDBSYVQ4aVB1bUdzcE1EbGNzYytPV0tsU1RY?=
 =?utf-8?B?VG9SemMvQTJXd0VLRzJsaHV1Zm85UytodDNYZEpheDhFQWtmK3hKV1M0Qk1Q?=
 =?utf-8?B?Ky9wZytrd3dpSVNlQ2huSS9FcnJUbjk1aEhodGdEak0zU0ZrN3JaY1FqRUVJ?=
 =?utf-8?B?QWtqZjdyVWVPMS9CZi9FdVFzYktwRE1BdmpZV2VWNStPeEs3VHRJRFlVd0Ny?=
 =?utf-8?B?T0RNbVoxUi9jdGtlUTFuVm81a1FVR1YvODlTdW9Va1o3VE5UaUNzUFl4Sjlm?=
 =?utf-8?B?UklRQkhaRzNXZzE0TE5TeDVxQlhjeERZL3ZzTlNHS25hektBMjhydU1IaTI5?=
 =?utf-8?B?V0JSU2VjaHVyTk5uMng3eUZvU2NIQmRpcnBvdkxPcUtwdTNOQ2hyMUhsUnRU?=
 =?utf-8?B?ZXdSek80QjZiUlZzcEI0eG1kYzJCUUk3VVZCaGdETmR3WWhnb1JBNUNYakcy?=
 =?utf-8?B?Q1B0M3RocW8xZ216TkxNdWE2cUJIM2lpNVhuWUJ0SXZSRUNmNDdBWTJxWFZP?=
 =?utf-8?B?ZUNzMitBYkZOdnM3dEx2b0pnenc5UWJ3Mi9KNkkrMHNKcktuYWhnTy9sRmZh?=
 =?utf-8?B?TTRSb1hoMWFHekNiS1h2Mk1MeW9TalQvTjhqd3JBY1hrZmdvYmNtS1RpUTBy?=
 =?utf-8?B?VUxKYy9XSWlhdWJYMndUNEJZTjRwRjJwbGFMVXlQNnhQeXVwaXFXeGRPcnZV?=
 =?utf-8?B?NFlDZlllOEV0dytJc2lzdVhmOGtrL3lYcmY3NjJsbTBFZUNpN2ZyWCtMdExK?=
 =?utf-8?B?SXc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4FFE6FCF997E37439A383C38399E61BD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90d45a00-e8a5-48f7-3cf0-08dab35481f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 11:07:56.4326
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2NYY6vGrD+Cxj8iO4h0+5VkTMlIa9xmSskLQC/JF9bXMqLISwb+vYBik1j8AxUxj5SYdMofulMnBTeUGjrDC+LnZ3WL89GbEvEzVnpMhItU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5611

T24gMjEvMTAvMjAyMiAxMTo1MCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gV2hlbiB0aGUgc3lz
dGVtIGlzIGNvbWluZyB1cCBhZnRlciBoYXZpbmcgYmVlbiBzdXNwZW5kZWQsDQo+IHJlc3RvcmVf
dmNwdV9hZmZpbml0eSgpIGlzIGNhbGxlZCBmb3IgZWFjaCBkb21haW4gaW4gb3JkZXIgdG8gYWRq
dXN0DQo+IHRoZSB2Y3B1J3MgYWZmaW5pdHkgc2V0dGluZ3MgaW4gY2FzZSBhIGNwdSBkaWRuJ3Qg
Y29tZSB0byBsaXZlIGFnYWluLg0KPg0KPiBUaGUgd2F5IHJlc3RvcmVfdmNwdV9hZmZpbml0eSgp
IGlzIGRvaW5nIHRoYXQgaXMgd3JvbmcsIGJlY2F1c2UgdGhlDQo+IHNwZWNpZmljIHNjaGVkdWxl
ciBpc24ndCBiZWluZyBpbmZvcm1lZCBhYm91dCBhIHBvc3NpYmxlIG1pZ3JhdGlvbiBvZg0KPiB0
aGUgdmNwdSB0byBhbm90aGVyIGNwdS4gQWRkaXRpb25hbGx5IHRoZSBtaWdyYXRpb24gaXMgb2Z0
ZW4gZXZlbg0KPiBoYXBwZW5pbmcgaWYgYWxsIGNwdXMgYXJlIHJ1bm5pbmcgYWdhaW4sIGFzIGl0
IGlzIGRvbmUgd2l0aG91dCBjaGVjaw0KPiB3aGV0aGVyIGl0IGlzIHJlYWxseSBuZWVkZWQuDQo+
DQo+IEFzIGNwdXBvb2wgbWFuYWdlbWVudCBpcyBhbHJlYWR5IGNhbGxpbmcgY3B1X2Rpc2FibGVf
c2NoZWR1bGVyKCkgZm9yDQo+IGNwdXMgbm90IGhhdmluZyBjb21lIHVwIGFnYWluLCBhbmQgY3B1
X2Rpc2FibGVfc2NoZWR1bGVyKCkgaXMgdGFraW5nDQo+IGNhcmUgb2YgZXZlbnR1YWxseSBuZWVk
ZWQgdmNwdSBtaWdyYXRpb24gaW4gdGhlIHByb3BlciB3YXksIHRoZXJlIGlzDQo+IHNpbXBseSBu
byBuZWVkIGZvciByZXN0b3JlX3ZjcHVfYWZmaW5pdHkoKS4NCj4NCj4gU28ganVzdCByZW1vdmUg
cmVzdG9yZV92Y3B1X2FmZmluaXR5KCkgY29tcGxldGVseSwgdG9nZXRoZXIgd2l0aCB0aGUNCj4g
bm8gbG9uZ2VyIHVzZWQgc2NoZWRfcmVzZXRfYWZmaW5pdHlfYnJva2VuKCkuDQo+DQo+IEZpeGVz
OiA4YTA0ZWFhOGVhODMgKCJ4ZW4vc2NoZWQ6IG1vdmUgc29tZSBwZXItdmNwdSBpdGVtcyB0byBz
dHJ1Y3Qgc2NoZWRfdW5pdCIpDQo+IFJlcG9ydGVkLWJ5OiBNYXJlayBNYXJjenlrb3dza2ktR8Oz
cmVja2kgPG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+IEFja2VkLWJ5OiBEYXJp
byBGYWdnaW9saSA8ZGZhZ2dpb2xpQHN1c2UuY29tPg0KPiBSZWxlYXNlLWFja2VkLWJ5OiBIZW5y
eSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jv
c3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KRm9yIHdob21ldmVyIGNvbW1pdHMgdGhpcywgTWFyZWsn
cyBULWJ5IG9uIHYxIHNwZWNpZmljYWxseSBpbmNsdWRlZCB0aGUNCmRlbHRhIGluY2x1ZGluZyBp
biB2MiwgYW5kIGlzIHRoZXJlZm9yZSBzdGlsbCBhcHBsaWNhYmxlLg0KDQp+QW5kcmV3DQoNCj4g
LS0tDQo+IFYyOg0KPiAtIGFsc28gcmVtb3ZlIHNjaGVkX3Jlc2V0X2FmZmluaXR5X2Jyb2tlbigp
IChKYW4gQmV1bGljaCkNCj4gLS0tDQo+ICB4ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jIHwgIDMg
LS0NCj4gIHhlbi9jb21tb24vc2NoZWQvY29yZS5jICAgfCA3OCAtLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gIHhlbi9pbmNsdWRlL3hlbi9zY2hlZC5oICAgfCAgMSAt
DQo+ICAzIGZpbGVzIGNoYW5nZWQsIDgyIGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEv
eGVuL2FyY2gveDg2L2FjcGkvcG93ZXIuYyBiL3hlbi9hcmNoL3g4Ni9hY3BpL3Bvd2VyLmMNCj4g
aW5kZXggMWJiNGQ3ODM5Mi4uYjc2ZjY3M2FjYiAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gveDg2
L2FjcGkvcG93ZXIuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jDQo+IEBAIC0x
NTksMTAgKzE1OSw3IEBAIHN0YXRpYyB2b2lkIHRoYXdfZG9tYWlucyh2b2lkKQ0KPiAgDQo+ICAg
ICAgcmN1X3JlYWRfbG9jaygmZG9tbGlzdF9yZWFkX2xvY2spOw0KPiAgICAgIGZvcl9lYWNoX2Rv
bWFpbiAoIGQgKQ0KPiAtICAgIHsNCj4gLSAgICAgICAgcmVzdG9yZV92Y3B1X2FmZmluaXR5KGQp
Ow0KPiAgICAgICAgICBkb21haW5fdW5wYXVzZShkKTsNCj4gLSAgICB9DQo+ICAgICAgcmN1X3Jl
YWRfdW5sb2NrKCZkb21saXN0X3JlYWRfbG9jayk7DQo+ICB9DQo+ICANCj4gZGlmZiAtLWdpdCBh
L3hlbi9jb21tb24vc2NoZWQvY29yZS5jIGIveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMNCj4gaW5k
ZXggODM0NTVmYmRlMS4uMjNmYTY4NDVhOCAxMDA2NDQNCj4gLS0tIGEveGVuL2NvbW1vbi9zY2hl
ZC9jb3JlLmMNCj4gKysrIGIveGVuL2NvbW1vbi9zY2hlZC9jb3JlLmMNCj4gQEAgLTExODgsODQg
KzExODgsNiBAQCBzdGF0aWMgYm9vbCBzY2hlZF9jaGVja19hZmZpbml0eV9icm9rZW4oY29uc3Qg
c3RydWN0IHNjaGVkX3VuaXQgKnVuaXQpDQo+ICAgICAgcmV0dXJuIGZhbHNlOw0KPiAgfQ0KPiAg
DQo+IC1zdGF0aWMgdm9pZCBzY2hlZF9yZXNldF9hZmZpbml0eV9icm9rZW4oY29uc3Qgc3RydWN0
IHNjaGVkX3VuaXQgKnVuaXQpDQo+IC17DQo+IC0gICAgc3RydWN0IHZjcHUgKnY7DQo+IC0NCj4g
LSAgICBmb3JfZWFjaF9zY2hlZF91bml0X3ZjcHUgKCB1bml0LCB2ICkNCj4gLSAgICAgICAgdi0+
YWZmaW5pdHlfYnJva2VuID0gZmFsc2U7DQo+IC19DQo+IC0NCj4gLXZvaWQgcmVzdG9yZV92Y3B1
X2FmZmluaXR5KHN0cnVjdCBkb21haW4gKmQpDQo+IC17DQo+IC0gICAgdW5zaWduZWQgaW50IGNw
dSA9IHNtcF9wcm9jZXNzb3JfaWQoKTsNCj4gLSAgICBzdHJ1Y3Qgc2NoZWRfdW5pdCAqdW5pdDsN
Cj4gLQ0KPiAtICAgIEFTU0VSVChzeXN0ZW1fc3RhdGUgPT0gU1lTX1NUQVRFX3Jlc3VtZSk7DQo+
IC0NCj4gLSAgICByY3VfcmVhZF9sb2NrKCZzY2hlZF9yZXNfcmN1bG9jayk7DQo+IC0NCj4gLSAg
ICBmb3JfZWFjaF9zY2hlZF91bml0ICggZCwgdW5pdCApDQo+IC0gICAgew0KPiAtICAgICAgICBz
cGlubG9ja190ICpsb2NrOw0KPiAtICAgICAgICB1bnNpZ25lZCBpbnQgb2xkX2NwdSA9IHNjaGVk
X3VuaXRfbWFzdGVyKHVuaXQpOw0KPiAtICAgICAgICBzdHJ1Y3Qgc2NoZWRfcmVzb3VyY2UgKnJl
czsNCj4gLQ0KPiAtICAgICAgICBBU1NFUlQoIXVuaXRfcnVubmFibGUodW5pdCkpOw0KPiAtDQo+
IC0gICAgICAgIC8qDQo+IC0gICAgICAgICAqIFJlLWFzc2lnbiB0aGUgaW5pdGlhbCBwcm9jZXNz
b3IgYXMgYWZ0ZXIgcmVzdW1lIHdlIGhhdmUgbm8NCj4gLSAgICAgICAgICogZ3VhcmFudGVlIHRo
ZSBvbGQgcHJvY2Vzc29yIGhhcyBjb21lIGJhY2sgdG8gbGlmZSBhZ2Fpbi4NCj4gLSAgICAgICAg
ICoNCj4gLSAgICAgICAgICogVGhlcmVmb3JlLCBoZXJlLCBiZWZvcmUgYWN0dWFsbHkgdW5wYXVz
aW5nIHRoZSBkb21haW5zLCB3ZSBzaG91bGQNCj4gLSAgICAgICAgICogc2V0IHYtPnByb2Nlc3Nv
ciBvZiBlYWNoIG9mIHRoZWlyIHZDUFVzIHRvIHNvbWV0aGluZyB0aGF0IHdpbGwNCj4gLSAgICAg
ICAgICogbWFrZSBzZW5zZSBmb3IgdGhlIHNjaGVkdWxlciBvZiB0aGUgY3B1cG9vbCBpbiB3aGlj
aCB0aGV5IGFyZSBpbi4NCj4gLSAgICAgICAgICovDQo+IC0gICAgICAgIGxvY2sgPSB1bml0X3Nj
aGVkdWxlX2xvY2tfaXJxKHVuaXQpOw0KPiAtDQo+IC0gICAgICAgIGNwdW1hc2tfYW5kKGNwdW1h
c2tfc2NyYXRjaF9jcHUoY3B1KSwgdW5pdC0+Y3B1X2hhcmRfYWZmaW5pdHksDQo+IC0gICAgICAg
ICAgICAgICAgICAgIGNwdXBvb2xfZG9tYWluX21hc3Rlcl9jcHVtYXNrKGQpKTsNCj4gLSAgICAg
ICAgaWYgKCBjcHVtYXNrX2VtcHR5KGNwdW1hc2tfc2NyYXRjaF9jcHUoY3B1KSkgKQ0KPiAtICAg
ICAgICB7DQo+IC0gICAgICAgICAgICBpZiAoIHNjaGVkX2NoZWNrX2FmZmluaXR5X2Jyb2tlbih1
bml0KSApDQo+IC0gICAgICAgICAgICB7DQo+IC0gICAgICAgICAgICAgICAgc2NoZWRfc2V0X2Fm
ZmluaXR5KHVuaXQsIHVuaXQtPmNwdV9oYXJkX2FmZmluaXR5X3NhdmVkLCBOVUxMKTsNCj4gLSAg
ICAgICAgICAgICAgICBzY2hlZF9yZXNldF9hZmZpbml0eV9icm9rZW4odW5pdCk7DQo+IC0gICAg
ICAgICAgICAgICAgY3B1bWFza19hbmQoY3B1bWFza19zY3JhdGNoX2NwdShjcHUpLCB1bml0LT5j
cHVfaGFyZF9hZmZpbml0eSwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcHVwb29s
X2RvbWFpbl9tYXN0ZXJfY3B1bWFzayhkKSk7DQo+IC0gICAgICAgICAgICB9DQo+IC0NCj4gLSAg
ICAgICAgICAgIGlmICggY3B1bWFza19lbXB0eShjcHVtYXNrX3NjcmF0Y2hfY3B1KGNwdSkpICkN
Cj4gLSAgICAgICAgICAgIHsNCj4gLSAgICAgICAgICAgICAgICAvKiBBZmZpbml0eSBzZXR0aW5n
cyBvZiBvbmUgdmNwdSBhcmUgZm9yIHRoZSBjb21wbGV0ZSB1bml0LiAqLw0KPiAtICAgICAgICAg
ICAgICAgIHByaW50ayhYRU5MT0dfREVCVUcgIkJyZWFraW5nIGFmZmluaXR5IGZvciAlcHZcbiIs
DQo+IC0gICAgICAgICAgICAgICAgICAgICAgIHVuaXQtPnZjcHVfbGlzdCk7DQo+IC0gICAgICAg
ICAgICAgICAgc2NoZWRfc2V0X2FmZmluaXR5KHVuaXQsICZjcHVtYXNrX2FsbCwgTlVMTCk7DQo+
IC0gICAgICAgICAgICAgICAgY3B1bWFza19hbmQoY3B1bWFza19zY3JhdGNoX2NwdShjcHUpLCB1
bml0LT5jcHVfaGFyZF9hZmZpbml0eSwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBj
cHVwb29sX2RvbWFpbl9tYXN0ZXJfY3B1bWFzayhkKSk7DQo+IC0gICAgICAgICAgICB9DQo+IC0g
ICAgICAgIH0NCj4gLQ0KPiAtICAgICAgICByZXMgPSBnZXRfc2NoZWRfcmVzKGNwdW1hc2tfYW55
KGNwdW1hc2tfc2NyYXRjaF9jcHUoY3B1KSkpOw0KPiAtICAgICAgICBzY2hlZF9zZXRfcmVzKHVu
aXQsIHJlcyk7DQo+IC0NCj4gLSAgICAgICAgc3Bpbl91bmxvY2tfaXJxKGxvY2spOw0KPiAtDQo+
IC0gICAgICAgIC8qIHYtPnByb2Nlc3NvciBtaWdodCBoYXZlIGNoYW5nZWQsIHNvIHJlYWNxdWly
ZSB0aGUgbG9jay4gKi8NCj4gLSAgICAgICAgbG9jayA9IHVuaXRfc2NoZWR1bGVfbG9ja19pcnEo
dW5pdCk7DQo+IC0gICAgICAgIHJlcyA9IHNjaGVkX3BpY2tfcmVzb3VyY2UodW5pdF9zY2hlZHVs
ZXIodW5pdCksIHVuaXQpOw0KPiAtICAgICAgICBzY2hlZF9zZXRfcmVzKHVuaXQsIHJlcyk7DQo+
IC0gICAgICAgIHNwaW5fdW5sb2NrX2lycShsb2NrKTsNCj4gLQ0KPiAtICAgICAgICBpZiAoIG9s
ZF9jcHUgIT0gc2NoZWRfdW5pdF9tYXN0ZXIodW5pdCkgKQ0KPiAtICAgICAgICAgICAgc2NoZWRf
bW92ZV9pcnFzKHVuaXQpOw0KPiAtICAgIH0NCj4gLQ0KPiAtICAgIHJjdV9yZWFkX3VubG9jaygm
c2NoZWRfcmVzX3JjdWxvY2spOw0KPiAtDQo+IC0gICAgZG9tYWluX3VwZGF0ZV9ub2RlX2FmZmlu
aXR5KGQpOw0KPiAtfQ0KPiAtDQo+ICAvKg0KPiAgICogVGhpcyBmdW5jdGlvbiBpcyB1c2VkIGJ5
IGNwdV9ob3RwbHVnIGNvZGUgdmlhIGNwdSBub3RpZmllciBjaGFpbg0KPiAgICogYW5kIGZyb20g
Y3B1cG9vbHMgdG8gc3dpdGNoIHNjaGVkdWxlcnMgb24gYSBjcHUuDQo+IGRpZmYgLS1naXQgYS94
ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaCBiL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oDQo+IGluZGV4
IDU1N2IzMjI5ZjYuLjA3MmU0ODQ2YWEgMTAwNjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9z
Y2hlZC5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9zY2hlZC5oDQo+IEBAIC0xMDE5LDcgKzEw
MTksNiBAQCB2b2lkIHZjcHVfc2V0X3BlcmlvZGljX3RpbWVyKHN0cnVjdCB2Y3B1ICp2LCBzX3Rp
bWVfdCB2YWx1ZSk7DQo+ICB2b2lkIHNjaGVkX3NldHVwX2RvbTBfdmNwdXMoc3RydWN0IGRvbWFp
biAqZCk7DQo+ICBpbnQgdmNwdV90ZW1wb3JhcnlfYWZmaW5pdHkoc3RydWN0IHZjcHUgKnYsIHVu
c2lnbmVkIGludCBjcHUsIHVpbnQ4X3QgcmVhc29uKTsNCj4gIGludCB2Y3B1X3NldF9oYXJkX2Fm
ZmluaXR5KHN0cnVjdCB2Y3B1ICp2LCBjb25zdCBjcHVtYXNrX3QgKmFmZmluaXR5KTsNCj4gLXZv
aWQgcmVzdG9yZV92Y3B1X2FmZmluaXR5KHN0cnVjdCBkb21haW4gKmQpOw0KPiAgaW50IHZjcHVf
YWZmaW5pdHlfZG9tY3RsKHN0cnVjdCBkb21haW4gKmQsIHVpbnQzMl90IGNtZCwNCj4gICAgICAg
ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeGVuX2RvbWN0bF92Y3B1YWZmaW5pdHkgKnZjcHVh
ZmYpOw0KPiAgDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 11:14:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 11:14:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427618.676871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpyc-0007G2-ON; Fri, 21 Oct 2022 11:14:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427618.676871; Fri, 21 Oct 2022 11:14:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olpyc-0007Fv-LW; Fri, 21 Oct 2022 11:14:10 +0000
Received: by outflank-mailman (input) for mailman id 427618;
 Fri, 21 Oct 2022 11:14:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RYXF=2W=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olpyb-0007Fp-AD
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 11:14:09 +0000
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com
 [2a00:1450:4864:20::32e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7add9bc5-5131-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 13:14:07 +0200 (CEST)
Received: by mail-wm1-x32e.google.com with SMTP id v11so1958502wmd.1
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 04:14:07 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 g19-20020a05600c4ed300b003c409244bb0sm2597555wmq.6.2022.10.21.04.14.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 04:14:06 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7add9bc5-5131-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=4SKfLPpIAxLCKbWZj1rohu1DCFOrNb7lblpLi8/L+LI=;
        b=xInPVt1c+V3/2r7ppFz23gNCyv9l9uxiAA/nY4vxJt5CERGzduWZJF/3PrQ29nVZll
         PDrtPg7TuYjMZjvkKVP3pP7dziw6pIWExNRQ74Dk9TgI/ov/OS7+VtJJMhTKvHT0TS9z
         c684zAdgZR+NrzMZs71Afit3RbNtRSvT7tt/I90SBGWP5R4E8VfkgKx6+/tXwfbYU8EN
         vmM59MdGPtkRjOYJNi0iaDr+MjnbG/TV4VGjEsqYLxIVIj23m3j3NqY7Y0v8xG0v5EEo
         m9jDPdBWDWsh65sQvn7Z4b0iqtGnVJCaOk/jNEsugrX3zOR2H1Y3sCxz5Z8su3jdr2E9
         1ytg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=4SKfLPpIAxLCKbWZj1rohu1DCFOrNb7lblpLi8/L+LI=;
        b=3j41+xZ0F8qUmyg4n5ZxSjB5DHykOrAq2Y9HVdInjTE1ZVKRWXsfM4L/LLUWjl6RQG
         LXTflQeQYGBFz6kggZhvpi3iA1cW3DI9kLKLsEMd7F5QIWAmgXoXxWQBLYAwHi/QQrwE
         QGwqX1eHPAwXeR0x548n23tNJN95/AtgA8NRWctUh7RhFVmSi4mWxEncEukIba/vLKbk
         A+AFO483RH+asDwsgFsn5wAuM6Czgqx1c3DLTNfhS4gQawxmB4TkXtOdx+TYoHk/8GpZ
         Dkd6LA8+LUa5Phul7RnB35S7mZsSt3O1xsg0fY03xholIgQ2VKLbanmmhgUXfP2SqH++
         woZQ==
X-Gm-Message-State: ACrzQf0btLkNJnYCXK0glNAnD5COQyDJtKfM9+JFjbmGlX26xA0zM3aT
	ZGgTvzhlhNvKoXaGMEISTXkyDQ==
X-Google-Smtp-Source: AMsMyM4eRM31QS1cseB+pg9IudfD59DN0nTBURKobOBUuxodf107u7nF7oHkKhfEXtf+lQ+njTfv0Q==
X-Received: by 2002:a05:600c:1c24:b0:3c6:c206:9ac0 with SMTP id j36-20020a05600c1c2400b003c6c2069ac0mr33363005wms.172.1666350847231;
        Fri, 21 Oct 2022 04:14:07 -0700 (PDT)
Message-ID: <92533e71-500d-b816-1d06-0740d50e3ec8@linaro.org>
Date: Fri, 21 Oct 2022 13:14:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v14 12/17] net: dgram: add unix socket
Content-Language: en-US
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, xen-devel@lists.xenproject.org,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>, Stefan Weil <sw@weilnetz.de>,
 David Gibson <david@gibson.dropbear.id.au>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Markus Armbruster <armbru@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>,
 Stefano Brivio <sbrivio@redhat.com>
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-13-lvivier@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <20221021090922.170074-13-lvivier@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 21/10/22 11:09, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Acked-by: Markus Armbruster <armbru@redhat.com> (QAPI schema)
> ---
>   net/dgram.c     | 55 ++++++++++++++++++++++++++++++++++++++++++++++++-
>   qapi/net.json   |  2 +-
>   qemu-options.hx |  1 +
>   3 files changed, 56 insertions(+), 2 deletions(-)
> 
> diff --git a/net/dgram.c b/net/dgram.c
> index e581cc62f39f..9f7bf3837653 100644
> --- a/net/dgram.c
> +++ b/net/dgram.c
> @@ -426,6 +426,7 @@ int net_init_dgram(const Netdev *netdev, const char *name,
>       SocketAddress *remote, *local;
>       struct sockaddr *dest_addr;
>       struct sockaddr_in laddr_in, raddr_in;
> +    struct sockaddr_un laddr_un, raddr_un;
>       socklen_t dest_len;
>   
>       assert(netdev->type == NET_CLIENT_DRIVER_DGRAM);
> @@ -465,7 +466,8 @@ int net_init_dgram(const Netdev *netdev, const char *name,
>           }
>       } else {
>           if (local->type != SOCKET_ADDRESS_TYPE_FD) {
> -            error_setg(errp, "type=inet requires remote parameter");
> +            error_setg(errp,
> +                       "type=inet or type=unix requires remote parameter");

Thanks for updating.

> @@ -546,6 +595,10 @@ int net_init_dgram(const Netdev *netdev, const char *name,
>                             inet_ntoa(raddr_in.sin_addr),
>                             ntohs(raddr_in.sin_port));
>           break;
> +    case SOCKET_ADDRESS_TYPE_UNIX:
> +        qemu_set_info_str(&s->nc, "udp=%s:%s",
> +                          laddr_un.sun_path, raddr_un.sun_path);
> +        break;

"udp"?


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 11:31:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 11:31:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427627.676893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olqFl-0001Oh-DD; Fri, 21 Oct 2022 11:31:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427627.676893; Fri, 21 Oct 2022 11:31:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olqFl-0001Oa-AG; Fri, 21 Oct 2022 11:31:53 +0000
Received: by outflank-mailman (input) for mailman id 427627;
 Fri, 21 Oct 2022 11:31:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=i13X=2W=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1olqFk-0001OU-F9
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 11:31:52 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f4448adf-5133-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 13:31:51 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-425-L3yhJ8jiMyK3C_XSd5RBOw-1; Fri, 21 Oct 2022 07:31:49 -0400
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F77138012DC;
 Fri, 21 Oct 2022 11:31:48 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C12FC10DF8;
 Fri, 21 Oct 2022 11:31:47 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id A2B0821E675B; Fri, 21 Oct 2022 13:31:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4448adf-5133-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666351909;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=p9dg7OvxbchOZSWhRuiUBoYJ1VdXWRMHMPlqUTGmjY4=;
	b=B7xvkFAkWDKlQfGJ4cMhjtVtIyAYVt/eAO4bBY4LgNJbjdEpIlr/+yFBnWMC9Ol01QlnBp
	vcYJvTcoCVvQN7gy8PNXoMShLdSPzJp3fIHoeF4sCGyQsb6FxC3kmgtkfxACCBzhPOQbbX
	RpAs/CnZXMUM7lw68+fluxLdEcYfRcM=
X-MC-Unique: L3yhJ8jiMyK3C_XSd5RBOw-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
  qemu-devel@nongnu.org,
  Thomas Huth <thuth@redhat.com>,  xen-devel@lists.xenproject.org,  "Dr.
 David Alan Gilbert" <dgilbert@redhat.com>,  Anthony Perard
 <anthony.perard@citrix.com>,  Stefan Weil <sw@weilnetz.de>,  David Gibson
 <david@gibson.dropbear.id.au>,  Stefano Stabellini
 <sstabellini@kernel.org>,  Paul Durrant <paul@xen.org>,  Eric Blake
 <eblake@redhat.com>,  "Michael S. Tsirkin" <mst@redhat.com>,  Jason Wang
 <jasowang@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Samuel
 Thibault <samuel.thibault@ens-lyon.org>,  Greg Kurz <groug@kaod.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>
Subject: Re: [PATCH v14 15/17] net: stream: move to QIO to enable additional
 parameters
References: <20221021090922.170074-1-lvivier@redhat.com>
	<20221021090922.170074-16-lvivier@redhat.com>
	<1f769d00-cf50-abaf-f078-f301959156b9@linaro.org>
	<87tu3x1n2m.fsf@pond.sub.org>
	<881f1b6d-ac9f-a144-0e13-622981f02130@redhat.com>
Date: Fri, 21 Oct 2022 13:31:46 +0200
In-Reply-To: <881f1b6d-ac9f-a144-0e13-622981f02130@redhat.com> (Laurent
	Vivier's message of "Fri, 21 Oct 2022 12:43:49 +0200")
Message-ID: <871qr11kgt.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5

Laurent Vivier <lvivier@redhat.com> writes:

> On 10/21/22 12:35, Markus Armbruster wrote:
>> Philippe Mathieu-Daud=C3=A9 <philmd@linaro.org> writes:
>>=20
>>> On 21/10/22 11:09, Laurent Vivier wrote:
>>>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>>>> This allows net/stream to use all the available parameters provided by
>>>> SocketAddress.
>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>>> ---
>>>>    net/stream.c    | 492 +++++++++++++++++----------------------------=
---
>>>>    qemu-options.hx |   4 +-
>>>>    2 files changed, 178 insertions(+), 318 deletions(-)
>>>
>>>> -static void net_stream_accept(void *opaque)
>>>> +static void net_stream_server_listening(QIOTask *task, gpointer opaqu=
e)
>>>>    {
>>>>        NetStreamState *s =3D opaque;
>>>> -    struct sockaddr_storage saddr;
>>>> -    socklen_t len;
>>>> -    int fd;
>>>> -
>>>> -    for (;;) {
>>>> -        len =3D sizeof(saddr);
>>>> -        fd =3D qemu_accept(s->listen_fd, (struct sockaddr *)&saddr, &=
len);
>>>> -        if (fd < 0 && errno !=3D EINTR) {
>>>> -            return;
>>>> -        } else if (fd >=3D 0) {
>>>> -            qemu_set_fd_handler(s->listen_fd, NULL, NULL, NULL);
>>>> -            break;
>>>> -        }
>>>> -    }
>>>> +    QIOChannelSocket *listen_sioc =3D QIO_CHANNEL_SOCKET(s->listen_io=
c);
>>>> +    SocketAddress *addr;
>>>> +    int ret;
>>>> -    s->fd =3D fd;
>>>> -    s->nc.link_down =3D false;
>>>> -    net_stream_connect(s);
>>>> -    switch (saddr.ss_family) {
>>>> -    case AF_INET: {
>>>> -        struct sockaddr_in *saddr_in =3D (struct sockaddr_in *)&saddr;
>>>> -
>>>> -        qemu_set_info_str(&s->nc, "connection from %s:%d",
>>>> -                          inet_ntoa(saddr_in->sin_addr),
>>>> -                          ntohs(saddr_in->sin_port));
>>>> -        break;
>>>> +    if (listen_sioc->fd < 0) {
>>>> +        qemu_set_info_str(&s->nc, "connection error");
>>>> +        return;
>>>>        }
>>>> -    case AF_UNIX: {
>>>> -        struct sockaddr_un saddr_un;
>>>> -        len =3D sizeof(saddr_un);
>>>> -        getsockname(s->listen_fd, (struct sockaddr *)&saddr_un, &len);
>>>> -        qemu_set_info_str(&s->nc, "connect from %s", saddr_un.sun_pat=
h);
>>>> -        break;
>>>> -    }
>>>> -    default:
>>>> -        g_assert_not_reached();
>>>> +    addr =3D qio_channel_socket_get_local_address(listen_sioc, NULL);
>>>> +    g_assert(addr !=3D NULL);
>>>
>>> Missing propagating Error* (observed in v12).
>>=20
>> *If* this is really a programming error: what about &error_abort?
>
> assert() informs the compiler that following code will not use addr with =
a NULL value, I=20
> don't think &error_abort does that. This could avoid an error report in c=
ode static analyzer.

I'd expect Coverity to see right through it.

Static analyzers with a less global view won't, of course.

For what it's worth, there are about a thousand uses of &error_abort
outside tests/.  I'm not aware of them confusing static analyzers we
care about.

I like &error_abort, because it makes the program crash when we try to
put the error into &error_abort, with an informative message.  This is
often right where things go wrong[*].  I personally don't care much
about the better message, but others do.  The better stack backtrace has
been quite useful to me.

Let's use &error_abort, and throw in the assert when a static analyzer
we care about needs it.


[*] error_propagate() messes this up.  That's why the comments in
error.h ask you to do without when practical.



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 11:51:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 11:51:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427632.676905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olqYW-000405-0K; Fri, 21 Oct 2022 11:51:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427632.676905; Fri, 21 Oct 2022 11:51:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olqYV-0003zy-Th; Fri, 21 Oct 2022 11:51:15 +0000
Received: by outflank-mailman (input) for mailman id 427632;
 Fri, 21 Oct 2022 11:51:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yW2F=2W=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1olqYT-0003zs-JS
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 11:51:14 +0000
Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com
 [2a00:1450:4864:20::32f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a1098b96-5136-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 13:51:05 +0200 (CEST)
Received: by mail-wm1-x32f.google.com with SMTP id
 n16-20020a05600c4f9000b003c17bf8ddecso3918048wmq.0
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 04:50:59 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 o10-20020a1c750a000000b003b4868eb6bbsm2833399wmc.23.2022.10.21.04.50.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 21 Oct 2022 04:50:58 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id B0F351FFB7;
 Fri, 21 Oct 2022 12:50:57 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1098b96-5136-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=3mSZUsrqSSadkGkHHFnqrEyoSiIuzQvl8N+m4auRe10=;
        b=de/4B7OR1i5Ot62hL7rwTo79MIkjbcNmnGSGOgBykNJx+l9T4V0MrNWEB5xR3rUVDY
         U1DEvVmorZXJ0RY0WSAhUGQEsEf7slHBEryHPiSrUVijQgiE3y4LBs/IxK7xkxTa2T1C
         lOH5UskzfU7NNJWew/A3ToOpwZafMuJmgfw7SCvZ9n8EavjQx45f9a+7opy2WKQTvKuI
         V+OvDaddAu78FRt0b4tD3osbYhXtUWlKC+VW/DpNycvbDSD+CNWlAs7Tk4sHPCOAvFyV
         rxS3MM6sAKwbZTx5CA3zgdFInkUVX7f8At1FP43x+41lxmDlOJxcgbevb3p2o0bTc/S7
         aotg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=3mSZUsrqSSadkGkHHFnqrEyoSiIuzQvl8N+m4auRe10=;
        b=3euHJwVF3aLbDm2zqQK0hhyC/iXe7/aqzJyODR7PyNf6QbmodFB09RtwoWXzR89z3y
         nwcikMe8JOVdV7//4OhsMf+WkhfrbzFkDjFpWUyiHrQ2YJry5TFokpDa822x09ENZIYU
         cO83okp9hbpiV9Dgp+tCGKwwtLgTL6Bbv7Jx/9WmAgVDHMW6ILVssAjcbAS7P2Z2B8qQ
         yFWsYg6d64/UoenVe2Arblay1zKQh19kcqBhfIVdH1Empl9DD3betl4igo/4PNle0anR
         3xz8s2EdZs8RbcvryeBQ8H+XeoQsbJMkIKGUVgpdPWeqxaz1RffF+FDqDGnzz33VzP6s
         UrAg==
X-Gm-Message-State: ACrzQf11qEBV9+iMkHsS36Bhl4LUkpcLFyfC3aOOlA+X002RTiU3wTjl
	HLoM4Pspu0EvEjG/+C15qLVg8A==
X-Google-Smtp-Source: AMsMyM4oR5TFW4/6DiOciJaRtY8e7fiqQ+pp18OB9d8iuF5paztNN48vLjQbmjeA3EDZJPvB0KlRvQ==
X-Received: by 2002:a1c:5446:0:b0:3c4:1854:abc0 with SMTP id p6-20020a1c5446000000b003c41854abc0mr13041585wmi.7.1666353058697;
        Fri, 21 Oct 2022 04:50:58 -0700 (PDT)
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-7-lvivier@redhat.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, xen-devel@lists.xenproject.org, "Dr.
 David Alan Gilbert" <dgilbert@redhat.com>, Anthony Perard
 <anthony.perard@citrix.com>, Stefan Weil <sw@weilnetz.de>, David Gibson
 <david@gibson.dropbear.id.au>, Stefano Stabellini
 <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>, Eric Blake
 <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang
 <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Markus
 Armbruster <armbru@redhat.com>, Samuel Thibault
 <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>, =?utf-8?Q?Dan?=
 =?utf-8?Q?iel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, Stefano Brivio
 <sbrivio@redhat.com>,
 qemu-devel@nongnu.org
Subject: Re: [PATCH v14 06/17] qapi: net: add stream and dgram netdevs
Date: Fri, 21 Oct 2022 12:43:33 +0100
In-reply-to: <20221021090922.170074-7-lvivier@redhat.com>
Message-ID: <87fsfh75um.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Laurent Vivier <lvivier@redhat.com> writes:

> Copied from socket netdev file and modified to use SocketAddress
> to be able to introduce new features like unix socket.
>
<snip>
> index eb38e5dc40bc..396c1d11e1e2 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2772,6 +2772,18 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
>      "-netdev socket,id=3Dstr[,fd=3Dh][,udp=3Dhost:port][,localaddr=3Dhos=
t:port]\n"
>      "                configure a network backend to connect to another n=
etwork\n"
>      "                using an UDP tunnel\n"
> +    "-netdev stream,id=3Dstr[,server=3Don|off],addr.type=3Dinet,addr.hos=
t=3Dhost,addr.port=3Dport\n"
> +    "-netdev stream,id=3Dstr[,server=3Don|off],addr.type=3Dfd,addr.str=
=3Dfile-descriptor\n"
> +    "                configure a network backend to connect to another n=
etwork\n"
> +    "                using a socket connection in stream mode.\n"
> +    "-netdev dgram,id=3Dstr,remote.type=3Dinet,remote.host=3Dmaddr,remot=
e.port=3Dport[,local.type=3Dinet,local.host=3Daddr]\n"
> +    "-netdev dgram,id=3Dstr,remote.type=3Dinet,remote.host=3Dmaddr,remot=
e.port=3Dport[,local.type=3Dfd,local.str=3Dfile-descriptor]\n"
> +    "                configure a network backend to connect to a multica=
st maddr and port\n"
> +    "                use ``local.host=3Daddr`` to specify the host addre=
ss to send packets from\n"
> +    "-netdev dgram,id=3Dstr,local.type=3Dinet,local.host=3Daddr,local.po=
rt=3Dport[,remote.type=3Dinet,remote.host=3Daddr,remote.port=3Dport]\n"
> +    "-netdev dgram,id=3Dstr,local.type=3Dfd,local.str=3Dfile-descriptor\=
n"
> +    "                configure a network backend to connect to another n=
etwork\n"
> +    "                using an UDP tunnel\n"
>  #ifdef CONFIG_VDE
>      "-netdev vde,id=3Dstr[,sock=3Dsocketpath][,port=3Dn][,group=3Dgroupn=
ame][,mode=3Doctalmode]\n"
>      "                configure a network backend to connect to port 'n' =
of a vde switch\n"

While the option documentation is good it might be worth taking some
additional time to document the wider networking stack. It is a topic
that often sees confusion amongst users and is a complex area of
functionality.

At a minimum a bit of preamble around DEFHEADING(Network option:) to
explain how devices and backends interact might help users understand
the context for the individual options themselves before launching
directly into explaining each one.

We also have some stuff on the wiki:

  https://wiki.qemu.org/Documentation/Networking
  https://wiki.qemu.org/Documentation/Networking/NAT

that might be worth sanitising and transcribing into a section of the
system emulation manual. We can then point to :ref:`networking` in the
options documentation so the user doesn't have to piece together
disparate bits of online information themselves.

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 12:21:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 12:21:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427645.676916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olr1a-0007pW-Si; Fri, 21 Oct 2022 12:21:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427645.676916; Fri, 21 Oct 2022 12:21:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olr1a-0007pP-P8; Fri, 21 Oct 2022 12:21:18 +0000
Received: by outflank-mailman (input) for mailman id 427645;
 Fri, 21 Oct 2022 12:21:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olr1Z-0007pF-9q; Fri, 21 Oct 2022 12:21:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olr1Z-0001ob-2z; Fri, 21 Oct 2022 12:21:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olr1Y-0005aE-Mp; Fri, 21 Oct 2022 12:21:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olr1Y-0001Gq-M6; Fri, 21 Oct 2022 12:21:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zRfY3cygQlvcWYSxA8EHVvffzDDMnvMCZu0VOM2tLeg=; b=E20i21FPfiWLf8RbPRucAFfzWX
	r4jXpHHd8HLdtpbkumyLLDxiNLSTX6hpzKWRxwD536tNLK6FzUEuJInFrsLj4Dt5ksKqpI0g9wDmN
	Tu4ODLHqwPHBBoN1wKPMd/TgLzwKBS10hhnNnyZeK6Bb/d2HBOSAFkS661pEgcuf1Oug=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174136-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-upstream-4.16-testing test] 174136: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-upstream-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    qemu-upstream-4.16-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-upstream-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-upstream-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=62dd49f2172fb7dfe8d4223bfa45aede05155328
X-Osstest-Versions-That:
    qemuu=107951211a8d17658e1aaa0c23a8cf29f8806ad8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 12:21:16 +0000

flight 174136 qemu-upstream-4.16-testing real [real]
flight 174191 qemu-upstream-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174136/
http://logs.test-lab.xenproject.org/osstest/logs/174191/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd  7 xen-install   fail pass in 174191-retest
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174191-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 168659
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 168659
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 168659
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 168659
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 168659
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 168659
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 168659
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 168659
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 qemuu                62dd49f2172fb7dfe8d4223bfa45aede05155328
baseline version:
 qemuu                107951211a8d17658e1aaa0c23a8cf29f8806ad8

Last test of basis   168659  2022-03-17 11:11:40 Z  218 days
Testing same since   174136  2022-10-20 14:10:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Haochen Tong <i@hexchain.org>
  Jason Wang <jasowang@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   107951211a..62dd49f217  62dd49f2172fb7dfe8d4223bfa45aede05155328 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 12:54:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 12:54:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427667.676943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrXb-00035Q-Kd; Fri, 21 Oct 2022 12:54:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427667.676943; Fri, 21 Oct 2022 12:54:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrXb-00035J-Hw; Fri, 21 Oct 2022 12:54:23 +0000
Received: by outflank-mailman (input) for mailman id 427667;
 Fri, 21 Oct 2022 12:54:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olrXa-000359-KL; Fri, 21 Oct 2022 12:54:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olrXa-0002RR-Hw; Fri, 21 Oct 2022 12:54:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olrXa-0006dB-29; Fri, 21 Oct 2022 12:54:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olrXa-00009q-1d; Fri, 21 Oct 2022 12:54:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SBIgz2Xc+G93pYXizv8ld47QcH04yM8zwTx1k4Cmxpk=; b=x2F6IFso9Sk8cYiYi98C3yov/U
	4lDhPbEzIirXua0YHT7/FO1ZN/Pr+TJ65LX/F0Q/cLLzrLnlBlo1ENGisJFvtTUTs4dNH54dOVPRp
	i4F58NBWF2SWFPWLypMnPEAL+MPYbvI9hYG+iyicrIgpd5OydrGIne12adMVOH6iV6no=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174192-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174192: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f838b956779ff8a0b94636462f3c6d95c3adeb73
X-Osstest-Versions-That:
    xen=0c06760be3dc3f286015e18c4b1d1694e55da026
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 12:54:22 +0000

flight 174192 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174192/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f838b956779ff8a0b94636462f3c6d95c3adeb73
baseline version:
 xen                  0c06760be3dc3f286015e18c4b1d1694e55da026

Last test of basis   174146  2022-10-20 18:02:03 Z    0 days
Testing same since   174192  2022-10-21 10:00:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Lindig <christian.lindig@citrix.com>
  Edwin Török <edvin.torok@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   0c06760be3..f838b95677  f838b956779ff8a0b94636462f3c6d95c3adeb73 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 13:14:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 13:14:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427674.676954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrrC-0005ef-9z; Fri, 21 Oct 2022 13:14:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427674.676954; Fri, 21 Oct 2022 13:14:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrrC-0005eY-6w; Fri, 21 Oct 2022 13:14:38 +0000
Received: by outflank-mailman (input) for mailman id 427674;
 Fri, 21 Oct 2022 13:14:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olrrA-0005eO-NW; Fri, 21 Oct 2022 13:14:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olrrA-0002mT-Iw; Fri, 21 Oct 2022 13:14:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olrrA-0007ZV-6T; Fri, 21 Oct 2022 13:14:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olrrA-0000Pm-61; Fri, 21 Oct 2022 13:14:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tBjIPs0/l/vXJLxTnSxawojoNUVeROEoECP0JTEzvUQ=; b=31CGxbcoNJrFlLsBzMbAmD8mdr
	Fwy+Y+B6p9ocpE39Si8nkIqZ6M6nFtShi0Sac1Om+Az6XeOunwntf+pTzynqDhpQhBhSEZajTHjT0
	3C7YgWB6R8M5cwoyFjziR4rP+kT+z2RS30/CmTSctrRGlh9GeZ+4PcQlS+vtEDhDg6h8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174134-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174134: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.14-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 13:14:36 +0000

flight 174134 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174134/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start    fail in 174078 REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174134
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174134
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174134
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174134
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174134
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906
 test-amd64-i386-xl-shadow     7 xen-install                fail pass in 174078
 test-arm64-arm64-xl-xsm       8 xen-boot                   fail pass in 174078
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174078

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174078 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174078 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174078 n/a
 build-armhf-libvirt           2 hosts-allocate           starved in 174078 n/a

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   66 days
Failing since        173496  2022-10-11 14:08:01 Z    9 days   10 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    8 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 13:20:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 13:20:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427683.676968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrx5-0007EO-6j; Fri, 21 Oct 2022 13:20:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427683.676968; Fri, 21 Oct 2022 13:20:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrx5-0007EH-3f; Fri, 21 Oct 2022 13:20:43 +0000
Received: by outflank-mailman (input) for mailman id 427683;
 Fri, 21 Oct 2022 13:20:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RYXF=2W=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1olrx3-0007EB-K9
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 13:20:41 +0000
Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com
 [2a00:1450:4864:20::436])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 286cc3e2-5143-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 15:20:40 +0200 (CEST)
Received: by mail-wr1-x436.google.com with SMTP id a3so4958400wrt.0
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 06:20:40 -0700 (PDT)
Received: from [10.50.0.10]
 (ec2-54-194-108-71.eu-west-1.compute.amazonaws.com. [54.194.108.71])
 by smtp.gmail.com with ESMTPSA id
 f18-20020adff452000000b0022584c82c80sm18829340wrp.19.2022.10.21.06.20.37
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 06:20:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 286cc3e2-5143-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=fclBL2DpDYJrYU1BjyQuOIQ/MO5tKMgq37veQJeQ2n4=;
        b=FSBb67Bt1oZuJV6sOvlww0UJMA+bSH0WGVgnpYeTqP6H21Ju+WifYioUQAeL0Nojtk
         Z81sVaaMW50wPC77SAXzQPzQn3MkICX1KWjdWC4rEd6Asr/d9glTKj9ssYm/TY/E+Zje
         eKKrFQb6KQj0l9G+sXGCrAUg/b8jIvpIDDqW2WJQY4B1aZ8lWwCBCBngWofPok/o+8KJ
         f3QpbeawwQAyFFrJfDNL7M94T9UDPv1RTUPouKnpCuH6UJbc5hGzsBsFbDaN0V/8KCR1
         WXhNP+Dx4QWh4L/UlRa2mIpXMIkKjtzp7Gf8SaMwCkoqJNGJGjvZnKjtrcK5ryDzEgEV
         OZRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=fclBL2DpDYJrYU1BjyQuOIQ/MO5tKMgq37veQJeQ2n4=;
        b=gNG47FDMpLnJnqV0L1EPybkfKry7pBJLLrhzgqhOdyEabVBfMpQgqogoLxLJcPawhx
         br7xXNUHCsV9hmhvT6j1qGk1b+f6XumMl8QmO8okBorjCoIQWrU3ZQze7aH76+i9LufB
         dt+GOatTGBiBnizpBioRAt15GbePyQj1BSqbVVs6Jfd5a4t72uX5sqK8Axs9eOc7Am7p
         De0P2XtuZV7QrMCFksrhFkXzLqi4ecD8AZ+LwqznP/PAG6HMQRwRGavc8jRl8A1CZsPO
         NHOs+NK9bEHRtM6uwO68tei2AREY6NBEpAMZ5YLFzuVqy64R5OBLZ0Cd/YkLlUwWKV2k
         8AzA==
X-Gm-Message-State: ACrzQf2rRciWsLqg3sdJNCaRPKNBRydtS87Myb2GTyWbTmU80u0KC6zp
	a1IOpR7C0MT4arNqgeNtpZ5weA==
X-Google-Smtp-Source: AMsMyM5e+Pbh1hb3QzRiLSLXWqIsw5ixTNWz9T3X6aT1kKxl5LI+D4J2QxglQZ8ZWWf5VOIdNxh+jw==
X-Received: by 2002:a05:6000:18a1:b0:230:f9fb:c83 with SMTP id b1-20020a05600018a100b00230f9fb0c83mr12373772wri.329.1666358439681;
        Fri, 21 Oct 2022 06:20:39 -0700 (PDT)
Message-ID: <34aef1b8-c8bb-995f-c9ee-0c9c982620c5@linaro.org>
Date: Fri, 21 Oct 2022 15:20:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Subject: Re: [PATCH v14 15/17] net: stream: move to QIO to enable additional
 parameters
Content-Language: en-US
To: Markus Armbruster <armbru@redhat.com>, Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
 xen-devel@lists.xenproject.org, "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>, Anthony Perard <anthony.perard@citrix.com>,
 Stefan Weil <sw@weilnetz.de>, David Gibson <david@gibson.dropbear.id.au>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-16-lvivier@redhat.com>
 <1f769d00-cf50-abaf-f078-f301959156b9@linaro.org>
 <87tu3x1n2m.fsf@pond.sub.org>
 <881f1b6d-ac9f-a144-0e13-622981f02130@redhat.com>
 <871qr11kgt.fsf@pond.sub.org>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <871qr11kgt.fsf@pond.sub.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 21/10/22 13:31, Markus Armbruster wrote:
> Laurent Vivier <lvivier@redhat.com> writes:
> 
>> On 10/21/22 12:35, Markus Armbruster wrote:
>>> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>>>
>>>> On 21/10/22 11:09, Laurent Vivier wrote:
>>>>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>>>>> This allows net/stream to use all the available parameters provided by
>>>>> SocketAddress.
>>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>>>> ---
>>>>>     net/stream.c    | 492 +++++++++++++++++-------------------------------
>>>>>     qemu-options.hx |   4 +-
>>>>>     2 files changed, 178 insertions(+), 318 deletions(-)

>>>>> +    addr = qio_channel_socket_get_local_address(listen_sioc, NULL);
>>>>> +    g_assert(addr != NULL);
>>>>
>>>> Missing propagating Error* (observed in v12).
>>>
>>> *If* this is really a programming error: what about &error_abort?
>>
>> assert() informs the compiler that following code will not use addr with a NULL value, I
>> don't think &error_abort does that. This could avoid an error report in code static analyzer.
> 
> I'd expect Coverity to see right through it.
> 
> Static analyzers with a less global view won't, of course.
> 
> For what it's worth, there are about a thousand uses of &error_abort
> outside tests/.  I'm not aware of them confusing static analyzers we
> care about.
> 
> I like &error_abort, because it makes the program crash when we try to
> put the error into &error_abort, with an informative message.  This is
> often right where things go wrong[*].  I personally don't care much
> about the better message, but others do.  The better stack backtrace has
> been quite useful to me.

I concur:

   qemu-system-x86_64: socket family 0 unsupported

VS:

    ERROR:../../net/stream.c:321:net_stream_client_connected: assertion
failed: (addr != NULL)

https://lore.kernel.org/qemu-devel/6fa6b9e5-fede-0f68-752f-0c0d8fa3494f@linaro.org/

> 
> Let's use &error_abort, and throw in the assert when a static analyzer
> we care about needs it.
> 
> 
> [*] error_propagate() messes this up.  That's why the comments in
> error.h ask you to do without when practical.
> 
> 



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 13:23:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 13:23:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427688.676979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrzW-0007pT-JI; Fri, 21 Oct 2022 13:23:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427688.676979; Fri, 21 Oct 2022 13:23:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olrzW-0007pM-GX; Fri, 21 Oct 2022 13:23:14 +0000
Received: by outflank-mailman (input) for mailman id 427688;
 Fri, 21 Oct 2022 13:23:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNjg=2W=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olrzV-0007pE-6k
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 13:23:13 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on2082.outbound.protection.outlook.com [40.107.212.82])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7916f7c9-5143-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 15:22:56 +0200 (CEST)
Received: from BN8PR07CA0007.namprd07.prod.outlook.com (2603:10b6:408:ac::20)
 by BY5PR12MB4885.namprd12.prod.outlook.com (2603:10b6:a03:1de::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 13:23:07 +0000
Received: from BN8NAM11FT038.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ac:cafe::d4) by BN8PR07CA0007.outlook.office365.com
 (2603:10b6:408:ac::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Fri, 21 Oct 2022 13:23:07 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT038.mail.protection.outlook.com (10.13.176.246) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 13:23:06 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:23:06 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 06:23:05 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 08:23:04 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7916f7c9-5143-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JCWgwozbxZ61cm9wexhEIwNLK8exdWF/0CdKzbEFbLYX5yhYjBjNm2NnggzbZiLK7WkqOOZsUmwQ+S2Ge4qeknxsDWGVvHDR4cKFKy03W9BemixnMiVnFACj2SvRkvmu/zCNp3OKF+9F0S4O8T+QpX6yXsalWj1zvTOmoeP4LUYzrcH9U7bNx2ZqAtnTz79AWM8ZIlOnx97H2eDjgy9tSS7O0y9MpUzM3k6O/epYZWDvSw5wHZqGKwWRaqQVyVsonp6yf4zKrGn7FvJgTL4SQKv7dtPpZ9vlEU/xQw5A9KDVCtSoioxs0J+52avmLDSpzJoPf3jgn+YDtQYXF+bNeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=42HDqeoTp2iFQDneQaRiYdhWYX5iZ0QaGLIVWemtNg4=;
 b=nSInzib65va4t/vWxrTOvR1iuY6YBESJr+rpjNDonsyktP/Ez8inFKDfBtmS0NWMBATxJzi485cS7SVf2luA01F7k1taln0yVPJscFypeAJl4rmDP4kF7dlsf9entpnTKPrYZ+INpEI9/rN3foDFuZLgvYjlGySVJgf7WwdfD+Obsg5PrIs+MQpRiSiF71uK/AJfvZlZQrWukQvnjHu1EoVe/e+r7B0nry7ka/VlSKe80GxZHOmhWPsOvEh67Ok0/0uEOHjg82BTpVEr3uEMV0Btc3zykVanWpoDeTPdn1B8xtNCSGcF2/p6FcAVDImL9UfAMu5ouAG1mrzIDy+Ihg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=42HDqeoTp2iFQDneQaRiYdhWYX5iZ0QaGLIVWemtNg4=;
 b=G9GquSI3rmYHLfZvRTA1PELyOoImejWPeSUV0CdfJKOB2XsuLmMmPwbpNSj4SyBDW2EhNCGbfbbo/YIITZoVkb3UaKPOZgMZF7xazDbxRCEvziD/3cr87FzyaS5Md5KI2aR+/GrQcf2gHm8YDinGQorw3te3mGPath7iSw3zy3w=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>
Subject: [for-4.17] automation: Build Xen according to the type of the job
Date: Fri, 21 Oct 2022 15:22:38 +0200
Message-ID: <20221021132238.16056-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT038:EE_|BY5PR12MB4885:EE_
X-MS-Office365-Filtering-Correlation-Id: 70ea1f3a-1545-48e4-cf98-08dab36763fb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rkiNPgVjpEQ+A4x31gGDp0V+wdvxji3zX8SEBBLXv0xOiSihLt7ZR5aTmK+D4GIDApusfL0sDaxOKV0bBh/dX6PYalANTR+V9G5eyUoGF+G6antxwygopSgqjVRsFhc8NF+DUb1imhkQcyF9qcNXjvT5IVqKkk8K87nJQAkx/wuKvO3i27lQkRSUIPDIZLFINClrm86qC39qRW3MefOh+FsJWzrrXOFdVdSpjGJf3IpEghQM9gm4aQ+1cAqU8bcE03doUPffemBswYo+pog+au4M4H/h0CK5Tg4o+mw8T/yTnU1RPM78q4ZPoEWKU2gSsOHDL8auK8a2UbGG6PRYGYT8rvTlxK+IyLIHvyK1EAhYylo/2IDsxtEZjDkJTxSK+eus/n62d2xvKYfWoRXWfbFt2xYIhw7v9p2u67X01J1Mb3Ki0pfj53MjMKzXnguLckXgWOuBsbui2hpSMU1hcBUn/E1mQedIPZj4NpTh1gFXshDNSG/HfbRctbgEdSwiWUj9zpX89wKQZKjLA11tmlGeP/qq6ua++YTDl6XGhdjYFf4Q2D0oG6SIONBtV9T8dvDP+prLjuUdk+dZ6kxTRsiCkKP10SGdsKPF6J5DJ4NhyaEGkGPnUWD0RSRgLIJ5k2YpTNJ1R5lyHIPLBN1MWsjJoKtoImQ3jtOzXK3CjlH5YKMEigIb5D5AbgveLuZGRM9RMEMMDSr8GvUvuptQGrkViWBNIg8m1Tvn2u19tmdaLIwwysb1MaM+n5H0r2gk1jPJVLG3k5qGVfenjHrniG8zd844rNk+RgZ8vEaDZn1pp0OJtANkmdEgsyjqv7M7
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(356005)(47076005)(6666004)(81166007)(86362001)(316002)(5660300002)(8676002)(8936002)(41300700001)(70206006)(26005)(40460700003)(70586007)(4326008)(40480700001)(186003)(336012)(2906002)(426003)(54906003)(6916009)(1076003)(82310400005)(44832011)(2616005)(36756003)(36860700001)(478600001)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 13:23:06.6171
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 70ea1f3a-1545-48e4-cf98-08dab36763fb
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT038.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4885

All the build jobs exist in two flavors: debug and non-debug, where the
former sets 'debug' variable to 'y' and the latter to 'n'. This variable
is only being recognized by the toolstack, because Xen requires
enabling/disabling debug build via e.g. menuconfig/config file.
As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
set to a default value ('y' for unstable and 'n' for stable branches),
regardless of the type of the build job.

Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Xen used debug variable to control the build type before switching to Kconfig.
Support for GitLab CI was added later, which means that this issue was always
present. This is a low risk for 4.17 with a benefit of being able to test Xen
in both debug and non-debug versions.
---
 automation/scripts/build | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index 8c0882f3aa33..a5934190634b 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -21,12 +21,13 @@ if [[ "${RANDCONFIG}" == "y" ]]; then
     make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
     hypervisor_only="y"
 else
+    echo "CONFIG_DEBUG=${debug}" > xen/.config
+
     if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
-        echo "${EXTRA_XEN_CONFIG}" > xen/.config
-        make -j$(nproc) -C xen olddefconfig
-    else
-        make -j$(nproc) -C xen defconfig
+        echo "${EXTRA_XEN_CONFIG}" >> xen/.config
     fi
+
+    make -j$(nproc) -C xen olddefconfig
 fi
 
 # Save the config file before building because build failure causes the script
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 13:32:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 13:32:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427694.676993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ols8G-0000yh-Hz; Fri, 21 Oct 2022 13:32:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427694.676993; Fri, 21 Oct 2022 13:32:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ols8G-0000ya-Eo; Fri, 21 Oct 2022 13:32:16 +0000
Received: by outflank-mailman (input) for mailman id 427694;
 Fri, 21 Oct 2022 13:32:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1mzs=2W=citrix.com=prvs=28632f022=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ols8F-0000yU-31
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 13:32:15 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bbbc05b7-5144-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 15:31:58 +0200 (CEST)
Received: from mail-dm6nam10lp2106.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.106])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 09:32:02 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5293.namprd03.prod.outlook.com (2603:10b6:208:1ec::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 21 Oct
 2022 13:31:59 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 13:31:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbbc05b7-5144-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666359133;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=U7ecJ63b83PMhoYMKYCzCTrAj1icQz4tQWStVl75Eks=;
  b=FX/omiuqp2SIIMVuImRFWUAzQOP+objh0otVs6fC2RBzDLbbMOBFBQS6
   WLOUOtWqq19O8ASv8rOlMJtgpXu3GyTgtzK38aO9MIX0y5SiXbbzTU85d
   wE7uQL3LN83+08yb6JdvhQCjf/99Lc4QbVnlQ5u3ydTwujoFzgkmIOeD1
   g=;
X-IronPort-RemoteIP: 104.47.58.106
X-IronPort-MID: 85773770
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:e1U/86CxOQy1CBVW//Xiw5YqxClBgxIJ4kV8jS/XYbTApG8h1TIHz
 mFNX2rUPqzeZGChft93O4608kMDvpLQztdlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K6r4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2l1BI44uc10AFpxr
 90VczMgVj+krtq5lefTpulE3qzPLeHNFaZG4jRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvN+8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toi/z2bSQwnuTtIQ6O7uCr/xz3hqvxTYcCCNVWmDnjtazhRvrMz5YA
 wlOksY0loA39UerR927WAeqrXqstxsQHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3
 UPPmMnmbRRkuaeZTn+1/b6OoTS/fyMSKAcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdOTz22
 SHMkyE4iJ0al8tN3KK+lW0rmBqpr5nNCwIwuAPeWzv96hsjPdb7IYu19VLc8PBMap6DSUWMt
 2QFnM7Y6/0SCZaKl2qGR+Bl8KyV2stp+Qb02TZHd6TNPRz2k5J/Vei8OA1DGXo=
IronPort-HdrOrdr: A9a23:2e/AiaN1PIFZm8BcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+
 Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu
 UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+
 jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI
 SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
X-IronPort-AV: E=Sophos;i="5.95,200,1661832000"; 
   d="scan'208";a="85773770"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MSSH40t++3t9mmbq3DVSbgUJWrZpnx3rfFhQrwwh21l4knZs2HfOcYmcZMfqZHfG75RDAREUUm53RSKUbxrlAZV+zLYHw+F99HzOJZ0/gR8/sw7mJtM/5vM9slA0q4x08b5Y/x6SPXp/yAVLK/Rdd+XlShYew4nN5m4pi+RTd5F/Z+orMk/qxfua0R2ObS6SMZCf5KACXALqWc30xTT6gwdA28kRseWxJu4yzqOUtKkgh+86QmkqiunyU3uzJ4vZ9lgrY/Grp241R8wHAmA/gGmqdWw/9De80Bw1y+obFElhBsn+LQiZJJSn5YkBe2XR+wh8erkY6ar/l0R4J5PXfg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U7ecJ63b83PMhoYMKYCzCTrAj1icQz4tQWStVl75Eks=;
 b=DY/3LP90DtBZDkRCad+iSmLVqfhqkAj0w6rSb6sd3uAW22JPcSNEa49isbDVzn/Xah4YblrX44beZnhiYSYx2ae5gcgrXOKY6xLmwIYM8gYVszvpNjinMGctmW+X/SoVANpW/iYULcEbfbif76QgnHHO/YrWhGZsJArSqRzQIyvQiyQZa6FKY2i86IwSfLQ3LiiCxNs+a4XiZBdPxjUMiF3Srl2kNzOTe6k+CVNSxZYyCcuuY6mi6g5/40rQoZ5LqbZS12RsuhVNT+3lp1alFEalZg5roOoDJhB9gs0ZvonUHwoxwwGwyP+Pj0NZjJ5WJe6n/Km0Td23vByDTyFjjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U7ecJ63b83PMhoYMKYCzCTrAj1icQz4tQWStVl75Eks=;
 b=GDQJSCkcT/gU484W775iXD6QpgCHnahYgXIavQN9uqmGe2XOSif7VO8Gutn9a7sqHd1/n2V3X6boro2aYdAZrjYKQ5drOKicDauO7qhZgdwZxzpZ8uRSsz+qGW1dH7ITiDRX2S/X+0JUiYDWj9kcB8QU9P+KMQxTemCiRkbqv3g=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [for-4.17] automation: Build Xen according to the type of the job
Thread-Topic: [for-4.17] automation: Build Xen according to the type of the
 job
Thread-Index: AQHY5VBUk9XVwulUUUausYFLiYVWqa4Y2FsA
Date: Fri, 21 Oct 2022 13:31:59 +0000
Message-ID: <9eb64ced-d04a-d406-e1da-86691ba79be6@citrix.com>
References: <20221021132238.16056-1-michal.orzel@amd.com>
In-Reply-To: <20221021132238.16056-1-michal.orzel@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5293:EE_
x-ms-office365-filtering-correlation-id: 9c3856ab-e4c9-416c-83fc-08dab368a158
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 1QsNlZHDS7GsFXAjPnDV4CEDbGFRbO8B10jz4oGGwdZPWB/9A8L9hPHQ2+CDsXEqqMJBSfkaMZPuvWvBbinahw9W1FXN5mHiQyA2HEtyThGsjotmJ0/+cRvoyoGERYG8JYjrox4pQnbHdoB5cnNWtkDgqs/Fo+WQ94fIW9MHAOJzpwScWYDpv2DbWAIclR63ARtnmuXG2l58VbIPXST6AFhsCUf8IdR7QVVUFb01Pj2EYTJnRMYCV+yYuI2p30NmySc5dN6DXsjIU59GsOmgEG+e+Us+S3tgBRR9x6fF11Z22a4lFC1MP9x95+SKHyCUW2b5snCqlHpqV35Thu73nsAPZwoIynWhOsnNjCx0wMKwNaUbO5WmQicJ58RcsAHGj4kfgs4IQfKSJ0yMfpSZirHUsvA1XZjwX3NqDY/0AkXA/fybJHFmCyAtDiXNkBZgxIkLDBEUW1RmK56431elX4cVTw5rqwUjwyQLQCOKW/81LjMEIBHDsCrPOtH7Jj75CA/B+1y6D+T7YFkW+hlW5PADTKkB9jkOlnabR4jUj81ycYaT2ZZLwbV8JOq8mxIgcBF5BxxvrjCkos55WmoD9Z4G9OK0K/WOkkzh97m3A+SAHEBrmvCAuro1oDeoclkgL/LX8AiUQmsZlBvbBIxZDfbMB/74PYGPILRrdnipglEFgy72dhj9xuft1G2zVvD1wx7odzV1ZebPOp1YMwMRGaq/mpvBmJfRNpDJVlXQrpVjv2ap0O3NzYtjET4K4Q2jiKhBtATkLLuEeLbDcMZg7vwzzcmEp2eBqfHQn4F9zrL5MwES4Lkovsryx0vwlF93SIONC26oHmjacZaeqTAu8A==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(451199015)(2616005)(6512007)(53546011)(31696002)(76116006)(26005)(6506007)(66556008)(186003)(66946007)(31686004)(91956017)(66446008)(66476007)(64756008)(4326008)(8676002)(316002)(41300700001)(478600001)(36756003)(6486002)(38070700005)(110136005)(86362001)(2906002)(83380400001)(71200400001)(54906003)(5660300002)(38100700002)(82960400001)(122000001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?M1B4YytMeDZwRnQ0NXpodXFjcTNHeHVvSW8vQjVoU2FvMXc4VS9lbDVFUkw2?=
 =?utf-8?B?VnltWG9ta0FsTG9xbUpLUzViZ1l2YjcxR3gzcnRnMUgyRGI1NW1nemZ4cVZO?=
 =?utf-8?B?VEExOEVvMTB1WGFkbzY2ak44VisraHBZc2l6Umc1MkY4NHdkaWkrVnB0Qldo?=
 =?utf-8?B?MHF2enEwNzUrUVJ1dUtEaGQyeG1oSEFvR29HaFM0d29yK0xDUUhNQVExdTVj?=
 =?utf-8?B?SGJZVit1MFBudUk5NDNuUS9hRWRhcmtmb0NwMDM4UENpOGN4b2tKRGlxNlBB?=
 =?utf-8?B?ZXZxMUFLNVBGV2xsU1BaTWw0Tm1BeXJUR0JEQU9BaUl3cVlkMDB2dDZEbG43?=
 =?utf-8?B?N1NFMEZMVnU2MkxFM0Y0Y1IxaE1PNk9UWDJBN3NGWnM2cURVSW8rK3lQUDFr?=
 =?utf-8?B?VEFyenYrS3V1WHcxZlB6WjNhVnFneDQwZWUvQ05odHRtL3Q0eFNwOGZlWUQ0?=
 =?utf-8?B?ZFpKZnF5dXFGTG05bUY2amwvMTFTK0FBNFhJUFVDZTFrSk5TWDhwOEgwQzdh?=
 =?utf-8?B?aDlacHA4VTZyWlJXVnlWaEVQcEswV2lLVit6SGdUd1dRQnljdEdPVUJJUHU5?=
 =?utf-8?B?cU9JZy9FLzBRK2NxbDduUzdyaGptcnlxWWd0N2dSRHdqSHVGYjUrK1o4alli?=
 =?utf-8?B?S2xzRWF1aEJLMm90d0hrSjJXQzRDSm1nTDU4T2Z5dFY5dE5aYm1pWHNJL1ZW?=
 =?utf-8?B?SzRKbVc3SWs3S2ZGL2dVQXZXVUJFY2t1VlM1K2poRWJRU3cvekZEOHh2dkRr?=
 =?utf-8?B?OXVBRElibm5VMjFId0ZVeDBvYW4rUW9SOHZBZDl3V3RvTnB2MmZZbDN1NytF?=
 =?utf-8?B?aUVETzhZTXI2R3V0QmFKZ0hERy9RVWthSHEzY056ODRTZzY1TUVGZEVIdDlz?=
 =?utf-8?B?L2RRNmdteWNoSEVNcjdyUXlaRVBDZnpycTNIVXM0aUNwTDh1TmUwKzMydysx?=
 =?utf-8?B?Uk8wVWJjdUhYOEJyZ3JGK3JySFplUWtqM29hT2g2Und0a1Mwd3NCQWRvdWcx?=
 =?utf-8?B?LzB5ZGJpYUc0TmljbnFKaHI0NHRkOWw4Y0dyN1oyVVR2VnoxMnkzZFUwSXBs?=
 =?utf-8?B?M0ZlSm80aktFbFdIWFNnOGp5Q1NmVE53bUxUVHZOZGR6eUxoRUpLWkEvY3ZF?=
 =?utf-8?B?RFNiaDltNXRPcmo5SnMwTjhiVU5ielRLc0hKQ3pvMXNueFlEejJMZGNqVFlG?=
 =?utf-8?B?SXJKbkc1MlNZclE5TEFpWkYwY2psalNWVHhQV21PRUVqckFWVnJYc0pUeWtZ?=
 =?utf-8?B?ZzgvMGNkendtTjlMSVR4WC91RkpHMGdiY3FTdUI3N2pyeFlKVUY1K0hLL3ph?=
 =?utf-8?B?ZG1nOWl2NDY4aTdGUXg3RjB0QlkwZXZqVmtTdUJIVUNsMmVUdVpoeVM3RW5V?=
 =?utf-8?B?cHZYZWlIUkJFWHZXWGNpN2k1N3NudU9GTVRhZ0hmL1BDVW9vSzRRejU2RG1k?=
 =?utf-8?B?WmpZbG5yMDEvNnZPUjlmQTMxWEJTWVVBVVFwTUhacXhZZkV6b2xrMnFyQmVw?=
 =?utf-8?B?VFpOSTFuQmdSelNXdTkzUHhvVDdlaWhqZzUyVTA1L21HQU1oeXBETGpkcDdS?=
 =?utf-8?B?Q0NPNWxVdUJzckVRRWxXRHpuUmhDc3F3ejZmcHN1TzJyMXdGUVMxTGF4OFMw?=
 =?utf-8?B?L1FBZVpOcWJLcmd5MVZLY3VwMXpib2RFaHJsOFprMFVwTTVXNFlDNUhIOVdl?=
 =?utf-8?B?U1lBQzR6aVNkNkhWUlRtbUN1eDJhbDgwRlczQ0JaUnJQK1lwT0RWZE0xQTBG?=
 =?utf-8?B?ME5pcE5NcGo1cVBrV2MxV0pZUEt3ZEFZdXpML2ZSN2p3L1hlUmZ1a2N6UDhT?=
 =?utf-8?B?bXloNVlGb1Q0MFZpSWw2aU1BUG10amtoUDkvMnhXUTIwbnEwb055K1hpRmRK?=
 =?utf-8?B?bFdDQ2hLVkZFT0pKa3VFZUp1VGY0QzJpNE1FdHpML3ZuYmhERmRLMTdacktZ?=
 =?utf-8?B?VUVpdWRQUWFLNnhQZUtKV21KcG1aMWNKOSt0aHc1Q0t4bnl4eXYyKzJlSk9T?=
 =?utf-8?B?TUhKV0d3Um9MbzRuZ3U4dlpuc3l4VmtRbEV0TEFoK1FvK2IrRHR4bCtMZDM1?=
 =?utf-8?B?VG9WVkJmTUVacXJCc0xZdnBnMkl0MXRrQnVIUksybDJEMElIdE50SEdlSFcw?=
 =?utf-8?B?UVVjLzc3d2JkeXVnUmtsQWFvTDNpUUd4bDQ5b0dMVXJkc0VoOWl6ZkZuVWh5?=
 =?utf-8?B?YlE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7CFED7CEDF11674294B81344E733CEBD@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c3856ab-e4c9-416c-83fc-08dab368a158
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 13:31:59.0781
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: D95R+hQhoBd1QDK1q2eCHh+uItZ40SoVg2Bua7v7RSI95eCP9WlgS9ZSfOLHUo/bhWOoFZTmVfz8NGuq0aNWaWjoQCVaoCSN+MY9UEPUlII=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5293

T24gMjEvMTAvMjAyMiAxNDoyMiwgTWljaGFsIE9yemVsIHdyb3RlOg0KPiBBbGwgdGhlIGJ1aWxk
IGpvYnMgZXhpc3QgaW4gdHdvIGZsYXZvcnM6IGRlYnVnIGFuZCBub24tZGVidWcsIHdoZXJlIHRo
ZQ0KPiBmb3JtZXIgc2V0cyAnZGVidWcnIHZhcmlhYmxlIHRvICd5JyBhbmQgdGhlIGxhdHRlciB0
byAnbicuIFRoaXMgdmFyaWFibGUNCj4gaXMgb25seSBiZWluZyByZWNvZ25pemVkIGJ5IHRoZSB0
b29sc3RhY2ssIGJlY2F1c2UgWGVuIHJlcXVpcmVzDQo+IGVuYWJsaW5nL2Rpc2FibGluZyBkZWJ1
ZyBidWlsZCB2aWEgZS5nLiBtZW51Y29uZmlnL2NvbmZpZyBmaWxlLg0KPiBBcyBhIGNvcm9sbGFy
eSwgd2UgZW5kIHVwIGJ1aWxkaW5nL3Rlc3RpbmcgWGVuIHdpdGggQ09ORklHX0RFQlVHIGFsd2F5
cw0KPiBzZXQgdG8gYSBkZWZhdWx0IHZhbHVlICgneScgZm9yIHVuc3RhYmxlIGFuZCAnbicgZm9y
IHN0YWJsZSBicmFuY2hlcyksDQo+IHJlZ2FyZGxlc3Mgb2YgdGhlIHR5cGUgb2YgdGhlIGJ1aWxk
IGpvYi4NCj4NCj4gRml4IHRoaXMgYmVoYXZpb3IgYnkgc2V0dGluZyBDT05GSUdfREVCVUcgYWNj
b3JkaW5nIHRvIHRoZSAnZGVidWcnIHZhbHVlLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwg
T3J6ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPg0KPiAtLS0NCj4gWGVuIHVzZWQgZGVidWcgdmFy
aWFibGUgdG8gY29udHJvbCB0aGUgYnVpbGQgdHlwZSBiZWZvcmUgc3dpdGNoaW5nIHRvIEtjb25m
aWcuDQo+IFN1cHBvcnQgZm9yIEdpdExhYiBDSSB3YXMgYWRkZWQgbGF0ZXIsIHdoaWNoIG1lYW5z
IHRoYXQgdGhpcyBpc3N1ZSB3YXMgYWx3YXlzDQo+IHByZXNlbnQuIFRoaXMgaXMgYSBsb3cgcmlz
ayBmb3IgNC4xNyB3aXRoIGEgYmVuZWZpdCBvZiBiZWluZyBhYmxlIHRvIHRlc3QgWGVuDQo+IGlu
IGJvdGggZGVidWcgYW5kIG5vbi1kZWJ1ZyB2ZXJzaW9ucy4NCg0KQm90aCBzZXJpZXMgd2VyZSBm
bG9hdGluZyBhcm91bmQgZm9yIGFnZXMgYmVmb3JlIGJlaW5nIGFjY2VwdGVkLsKgIEl0J3MNCnF1
aXRlIHBvc3NpYmxlIHRoYXQgb25lIGJpdHJvdHRlZCBhcm91bmQgdGhlIG90aGVyLg0KDQpUaGlz
IHNob3VsZCBiZSBiYWNrcG9ydGVkLCBhbmQgdGhlcmVmb3JlIHNob3VsZCBiZSBjb25zaWRlcmVk
IGZvciA0LjE3DQphdCB0aGlzIHBvaW50Lg0KDQpJcyB0aGVyZSBhIEdpdGxhYiBDSSBydW4gd2hp
Y2ggaW5jbHVkZXMgdGhpcyBwYXRjaD8NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 13:47:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 13:47:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427702.677010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olsMi-0002kZ-0w; Fri, 21 Oct 2022 13:47:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427702.677010; Fri, 21 Oct 2022 13:47:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olsMh-0002kS-UN; Fri, 21 Oct 2022 13:47:11 +0000
Received: by outflank-mailman (input) for mailman id 427702;
 Fri, 21 Oct 2022 13:47:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1olsMg-0002kM-Nx
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 13:47:10 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60062.outbound.protection.outlook.com [40.107.6.62])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id da8ac905-5146-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 15:47:07 +0200 (CEST)
Received: from AS9PR06CA0596.eurprd06.prod.outlook.com (2603:10a6:20b:486::31)
 by PAVPR08MB9433.eurprd08.prod.outlook.com (2603:10a6:102:319::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 13:47:05 +0000
Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:486:cafe::31) by AS9PR06CA0596.outlook.office365.com
 (2603:10a6:20b:486::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.36 via Frontend
 Transport; Fri, 21 Oct 2022 13:47:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 13:47:05 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Fri, 21 Oct 2022 13:47:04 +0000
Received: from 04a402a7427e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 167D069D-4641-49AE-96EA-3CEDCDE443F4.1; 
 Fri, 21 Oct 2022 13:46:58 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04a402a7427e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 13:46:58 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB8419.eurprd08.prod.outlook.com (2603:10a6:20b:567::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 13:46:57 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 13:46:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da8ac905-5146-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=XmcmxlC4OhHpQLfWEisuso8Q1wDxLbvqpXLfm/QFgQt7AVr4+9b32GtzEz4z0mMVkhJ9qGRnjvDmV2CbUCBuFrIRlcXklnpml4EFAtvDiLV0AqYNHAaFU5LAbKxmJFa93jN/IxwZKnb9iKXoVQxpDtAJCjHLDzw5v/ldT+eGHklf/ZU5iKCyO2Ug+3g54Mm6aMzKt30uTMp5pwBx1HholJ6cv8GuUt5NzGeq9OLGnJrveLQFNtsbIBLzJBjovS0U6ETHeMaADR9xBtI3jskLeDWiWSCdk7XdTaY0lhZjivGZvaRZoacagTN+oLshkXgR/OUyhBSHMdSZGbVF+You+g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GD4iChV8i1eBkRb6dA9fhmlqyI+MJFhCQBl1YC85M6w=;
 b=V1wI8swbnCIOZycFmjKt6WEGyskDSlwvzRCPAZfOCPmRbqq0tayYdR5fJxA4CYZYAL1B0fGkWxRQaQ9VMUs6CU5fta8U/uRlpw3y5rlEQrIA3a8EUhFAJfciO3/53fCfOQgL+HSx9YKRQvck22eGP1rmdjGQ/FZiAexRwtZCtF/RzO21U5pKI2tJa/XkdvdWUZOJR/bVDcboBiEw/adsAdSHIRpFpPbcOWflUFYrtdwR9ihB3e1CoFSoDNvZMo47f8FhPbKHe2SFYij6I/G66TbH1v1qN/bFRhWw3qKPFHtNS0zbZr0ZXO9u/2RMuHTuy/D8oyrWW89sTmlU4maTpw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GD4iChV8i1eBkRb6dA9fhmlqyI+MJFhCQBl1YC85M6w=;
 b=1W8c6VZKG9ire5g9ujABNJ+uy1mWh2UqniQEvgHhTODX3PEyoHOv2PtlNHvmxsG+Y6d936RFYJElTOpSKfY5R1+ORfc2mpIhF2+h0a7GYg+Aj7bR9K4BiI3Kl5tFnW0xd0732wnFsMbwBYtSk4JaRQ9BMmmRdyOqGMdTRwoFCew=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jbizueFyyg7nNQ4KD967uaqca+kGuWS0uHCeycP7ChMllyijodA0RAR9i/m8sx6LC5IgF+8Iv/dziwr0tk0Y8YzC6XdP8i3AXnPt/vt3JPcXf+0ePevF1Vb2iLndcq/ozdvU9qlGRS8aOgXGe366nsJsSs+a2QG05u9rk625oNzMwmRAsGBzih7YhECWzyJ96lWAMsjE+AiZnn9XhaiMJX7/MX79fMc2kiEuBlC/NTNIuhcLt1JCVX1DQwpv0HKoD5Cg/eUqVDfU9QpoaTEgqzxAqB48QtFEBOUVuSwueBN5Py50e5DyFr+N/0ssKl5s9KgFMAVoKJCAShyX0vP6Hg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GD4iChV8i1eBkRb6dA9fhmlqyI+MJFhCQBl1YC85M6w=;
 b=RfJP/tzuWfw2Vsk7SRoqeo8FFndVeL4E0CWEtU4dxMCZVg1GDPh3D3iMStOLNr2zsYoozBW3sVBiHpKSIPV7UDn3JQRhrB3/wQbcrrwoHFfoH2TzB6ZwDZ3GZu784K23MjYtgI9QYa8spZV9+qLLNHpeZysAjgYlpJe3CrhooOLyN04fbaeg3sj6EiAP4Ym0cowU2PGVC5EK6FRnIcckqDcUmDPZFdFFqkMxVkAzdWeIAwDb5DIWu8hSesnAIlPG6bakiTLnAN8UuuHK20uBajEGq+MlhtGgAUzZGRV7ILTgAUlflNVG4eSaxm2XULCP9lAZVFjhKiCcM/igA9wqJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GD4iChV8i1eBkRb6dA9fhmlqyI+MJFhCQBl1YC85M6w=;
 b=1W8c6VZKG9ire5g9ujABNJ+uy1mWh2UqniQEvgHhTODX3PEyoHOv2PtlNHvmxsG+Y6d936RFYJElTOpSKfY5R1+ORfc2mpIhF2+h0a7GYg+Aj7bR9K4BiI3Kl5tFnW0xd0732wnFsMbwBYtSk4JaRQ9BMmmRdyOqGMdTRwoFCew=
From: Henry Wang <Henry.Wang@arm.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: RE: [for-4.17] automation: Build Xen according to the type of the job
Thread-Topic: [for-4.17] automation: Build Xen according to the type of the
 job
Thread-Index: AQHY5VBH0to+UdgFKUq0Sje61MU0ya4Y3HCQ
Date: Fri, 21 Oct 2022 13:46:56 +0000
Message-ID:
 <AS8PR08MB79918F72BB0A6554A55887DD922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221021132238.16056-1-michal.orzel@amd.com>
In-Reply-To: <20221021132238.16056-1-michal.orzel@amd.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: CD67E81D073A4B428E6052E6B3A0EC9D.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB8419:EE_|AM7EUR03FT045:EE_|PAVPR08MB9433:EE_
X-MS-Office365-Filtering-Correlation-Id: b463419a-bc28-43eb-c48f-08dab36abd55
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ypefU0R6gpIz/We2ph2f1NxvkYA9Fb/mtsR6FxwpHnJqWi86muFUy7gdxjJ7TucDNoAH4/mWMsqidHIQ730e5tiOAMNN5jh+pSrUpFVSGfVU2eIxc28EZ1VoX5TW/XC1cSmIH8A4OwwlCJPd4zw15UlNNgmLepxFALXz4KXNJZMfNQp3LPzFB3vYZhyFuNzEfUKqvJzEyOf9y/r5h8uQa90FmNdlPNKsMEJ+cpkK6YjcABf28mzo/NqDkVRhYAOnl0hB3AH6FKGTeDkl3q3tcpa+v5MAb+zxEpaZ5cYP1UJtF7AMlu7OQMfkhnDyMmyD1B2Hgvez2k9QhNEzvD8imh+vSoMMDRdodBmFviyHM7xeN+Vq7YqiTK/gWbX3IREPNqpfiKJ9FkgQbFwX6lWw82EyR3KO2iZTPvu3ukwsPb+nBtD1aB9XWo/5oi2fejQf9FxLtvAR0rA4sP0u2LIIbkZzFeqzeYSxCh24GuSQQgu7IDv8GxQpzQsGvtEYp/A/eYnsAy6dR2v6Jx/z7I+Rji4ZjJpxbiX10/v3UO8j7uppEK2TxkkcJ7k+ag+xhtTb6ERS02NF8+yLbMusHIrn0Xw+1K6SeYkH61+8UbheV4yh0hHVir7hu5k8L/0MzcDTAgcldvvs9MVBgMeh5SRBIJAnIddaDM1W29/uCiOcsXg65Fs6zna8oaIrGrQgx+7gNz6dR0MP+grJAFpByGHo9RSAxHs8OvlqspzmPSFh2XuqzZsx8oPpx86LTCLLpl8WGvOmMYx1Np8BN3yqeg64BQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199015)(71200400001)(122000001)(38070700005)(478600001)(110136005)(54906003)(66446008)(316002)(41300700001)(76116006)(66946007)(52536014)(8936002)(64756008)(7696005)(9686003)(4326008)(6506007)(8676002)(66476007)(66556008)(26005)(5660300002)(86362001)(2906002)(38100700002)(186003)(83380400001)(33656002)(4744005)(55016003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8419
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	96c99b6a-7529-41a1-9f82-08dab36ab875
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ItoEUrjjGqEZUAFGNzlbs1IlrbxF32UQZLWMfrg8U/m7ut1EAgq6tAwazxMcfpIq8kGcmjh5LTyHKJwhWWkCnRHFG1a55m4kpbJC0S6RBuZi6fjvCL89oWFOs17bB2RFxo/p1qWbOSpube7u4f6exNXnRxSiEDPQ9J8XkXrNuphiBHUyJn3tuc0Ds/qN8K+t1NRXdlMG388VAHtkHowiWRuE7GITW4U25+aG/xnaZBRmg+uKnUAYPO8uN5IK0Tumtx8wj//Ie4xbKzlMZrI/4mlBnf0OysJfolQ+YMBXlC51QdFGy75VJEE6Exp9eDOEF8QwrKypNP0tkZR0AEu26d3dL1vKRLeEDFXew/9hR2zgK/naJfzJZTyUQ6EWRqGlMz2+8F6tpMj8IgK9Mx8FgQ6yX53WRZtpp7jzmtlM/ZvLEObqajzQDCTZkIRbijdct1m2PydRlmWlGKU0N+ZsnJIKKYUKcRL7+SRhYG+xKHN3Av1DWngzRcxobalHfm8wvBknhKYcGkek4FjyT5YQWSqeeZMjWUQ2xImSYD9biMjq8BKrPHiSDWMArNLbsrX3/jRvLP2tw1/fKL+nseObZpROtR/XWsoYY5IO80SiasjKYNNeQW2dqUoxIJhj7fpBtmo6NUzMt0Yw4LARcVVI/5WW07ZyhnuvflolS2GNAR8Wz9Z0giDQyKcNpw7XWnwbSwcHNn8+zdtsOt22IjjAJrcoCDEYQADCpwGr6nvzqN/IOV9aAN/LBCp6WVgj0zLqbP/54fcMsH74tiBVpgQhrg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(4326008)(110136005)(54906003)(316002)(8676002)(70206006)(70586007)(107886003)(478600001)(86362001)(6506007)(7696005)(82310400005)(55016003)(8936002)(186003)(41300700001)(40480700001)(40460700003)(26005)(9686003)(52536014)(5660300002)(336012)(4744005)(2906002)(36860700001)(33656002)(47076005)(356005)(83380400001)(82740400003)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 13:47:05.0141
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b463419a-bc28-43eb-c48f-08dab36abd55
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9433

Hi Michal,

> -----Original Message-----
> From: Michal Orzel <michal.orzel@amd.com>
> Subject: [for-4.17] automation: Build Xen according to the type of the jo=
b
>=20
> All the build jobs exist in two flavors: debug and non-debug, where the
> former sets 'debug' variable to 'y' and the latter to 'n'. This variable
> is only being recognized by the toolstack, because Xen requires
> enabling/disabling debug build via e.g. menuconfig/config file.
> As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
> set to a default value ('y' for unstable and 'n' for stable branches),
> regardless of the type of the build job.
>=20
> Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.
>=20
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 14:32:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 14:32:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427707.677021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olt4J-0008BP-8a; Fri, 21 Oct 2022 14:32:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427707.677021; Fri, 21 Oct 2022 14:32:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olt4J-0008BI-4j; Fri, 21 Oct 2022 14:32:15 +0000
Received: by outflank-mailman (input) for mailman id 427707;
 Fri, 21 Oct 2022 14:32:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNjg=2W=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olt4H-0008BC-Hn
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 14:32:13 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2062.outbound.protection.outlook.com [40.107.95.62])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c784373-514d-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 16:31:56 +0200 (CEST)
Received: from BN9PR03CA0118.namprd03.prod.outlook.com (2603:10b6:408:fd::33)
 by SN7PR12MB7324.namprd12.prod.outlook.com (2603:10b6:806:29b::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 14:32:07 +0000
Received: from BN8NAM11FT024.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:fd:cafe::86) by BN9PR03CA0118.outlook.office365.com
 (2603:10b6:408:fd::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 14:32:07 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT024.mail.protection.outlook.com (10.13.177.38) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 14:32:07 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 09:32:06 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Fri, 21 Oct 2022 09:32:05 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c784373-514d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LJ2KliLCJsANIGHW60bMto0YvJfm7Z/FDj6YLh8Xey0F1WKKQVjfeNBik07fM2FCszj9tbd2gakSCro9cbhqFl0GSAFIhWP+rKhhOpKHgoRzjQUEbMCRfAwOE6jmIJ+t/GTKhcmDR42I1Jae4Q1R/xY2h3eg5M+Tybx7jlsRgHZoCSXmPWbCIX0THFikCtnMMfpOXCoGcRYFAnHpV+Gk61bI7HDwAvX8QU9qq5IyYNwMvJKpEpFpd2jphL3P2/XCks+fDUKFduqT+RnNUOsWvFe6p+O4uanGR9aOLlwf0dS9eXzgZ4WDP9FE5/6/8GqJ+QxJpKmvkkvAIp/W1R1Iuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yM3HIDm85n8qkkEkG7xtgzz+b/Am+ZT80vERxF7D4JI=;
 b=LYdKtfsCWL+9Y6GzGee7uos5cmXMk9nXCVnBVWNYGGPR7MLkzj8Fa/Ji1yRISeiCkZKGaDpFUxE5AkQGx5vhGwNx5kAwURwwvGiHjh0j80b6bDMMA9ZYBCouL7/E83hTgwg15N+0TK/5hEdSPhdRuxVqHaTowCmUUq6m2nz5S6tArFcrflOf0M0U1jvMdA0PIYstEuC6YnH+mQcDuQkyUrZfwevq/Ucaz68UlLokWU5EvNAh6eBFZlQKJ7aW95EvM6GJduDgGV6g4NDyCkFM9cFrK8dvumeZr1qK5/0tG7jJOh3MRYsCXS3IS279CKGwu8x1PGhCHASNlkDw55kItQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yM3HIDm85n8qkkEkG7xtgzz+b/Am+ZT80vERxF7D4JI=;
 b=Qhwo6K3tTqHTuaGpoKTu4IB48arjK/03xmR5nOYEPfu4d2h3//fWzlcvo+wwFuDQoKL9EsX+NpwVk70bhgy8SuRjSQkrlu8CsrIVsToEDlZZIj7LDF4e1ciH7lDsAVWRZu1Bh7XfwJZOs/2UPj1RQgGd+ojR2m4V34p4TRBOOJo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <38c918ee-ee21-8887-f48f-f74e2e0a9862@amd.com>
Date: Fri, 21 Oct 2022 16:32:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [for-4.17] automation: Build Xen according to the type of the job
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>
References: <20221021132238.16056-1-michal.orzel@amd.com>
 <9eb64ced-d04a-d406-e1da-86691ba79be6@citrix.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <9eb64ced-d04a-d406-e1da-86691ba79be6@citrix.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT024:EE_|SN7PR12MB7324:EE_
X-MS-Office365-Filtering-Correlation-Id: 87504479-1226-44b8-cce0-08dab37107eb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FCpBoB9AOfDF+dQbAuL8dDpzrPKGa0RhvQtUY2MgAQJV07uiAqwzUV0xzplAGPKIgpVrQMybjoOXChNU57KWQMUS9HN0+q4WqUYPSVt16A+SjGyssDgUEGuPOFIR2fYzehSn4YoQJD9mIVS8uFXVfbh1IiYcU5RIwnQa+PuM72vWVhGXETDHC+drQcKClFmoQ/EW1Ldht8ciL8b6eEw3IZmPwr7vCRZcjtFG0cpD2CxM8Hmm+RMndeI0jziNW1iaQl1QCEESx+bNYh/jAz3vlaXHY0Lx/a6W+OS5A7A0ZVnk7upQJaDZKj4bVUjgYLqZw5Ee746RFj0oAPs9SD6ja3gL4JKS36FPMgxbGtYgU9Jkdc/O07pKnr8CFRnlzJEb4XonBLIjwySpS1JcbUOmEH3StFRaxULKL4cD8iYezCV5YZIIbeYeFCvV2RCLYQhZStnmIeVcUpWpBysblrKBjMh3zuPK/Alpuy7sCbdbE5WY3gGUAVApC5061QUO/hMGiSEjz9bcZ9MnZLBfo97UI+DsWV2LrTclOrpPbENP5jrpAK+Zsnf9FGOF7RoDbNtMAwctPWUCRTeT0aZ0yo3s7OS/Xag411/a+b+05q5hNUANhFQTIyVtLQa7l7mE+SeAy888qCIV4ftwXYrdFli/FLkfZd88n+qKg0df6MkSDkLjQ3aBmsLclgK6SJ3leUxgO/JpnTmSWGFRDS5yZn5MU3rZe2sLVpOogvScEBcjIQEQ6X4/d5iTLA4zrp4zZ7goiDNd0RR9YN1E/MymtzFqZ0xnRTNKLD+0oEy2s6A1FM9g+sCXHExrUSKKgu0YdDqDWFerIDq1u3N9jtKfWUiJKalBSHptNODcW37HlhFPfXA=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(31696002)(40460700003)(356005)(36860700001)(83380400001)(336012)(47076005)(8936002)(86362001)(5660300002)(44832011)(82740400003)(81166007)(41300700001)(110136005)(4326008)(16576012)(53546011)(82310400005)(186003)(2906002)(54906003)(966005)(70586007)(70206006)(8676002)(316002)(26005)(40480700001)(2616005)(478600001)(426003)(36756003)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 14:32:07.1448
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 87504479-1226-44b8-cce0-08dab37107eb
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT024.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7324

Hi Andrew,

On 21/10/2022 15:31, Andrew Cooper wrote:
> 
> 
> On 21/10/2022 14:22, Michal Orzel wrote:
>> All the build jobs exist in two flavors: debug and non-debug, where the
>> former sets 'debug' variable to 'y' and the latter to 'n'. This variable
>> is only being recognized by the toolstack, because Xen requires
>> enabling/disabling debug build via e.g. menuconfig/config file.
>> As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
>> set to a default value ('y' for unstable and 'n' for stable branches),
>> regardless of the type of the build job.
>>
>> Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>> ---
>> Xen used debug variable to control the build type before switching to Kconfig.
>> Support for GitLab CI was added later, which means that this issue was always
>> present. This is a low risk for 4.17 with a benefit of being able to test Xen
>> in both debug and non-debug versions.
> 
> Both series were floating around for ages before being accepted.  It's
> quite possible that one bitrotted around the other.
> 
> This should be backported, and therefore should be considered for 4.17
> at this point.
> 
> Is there a Gitlab CI run which includes this patch?

I submitted the one here not long ago:
https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/673396949

and there is already one failure in Arm boot-cpupools test because the script sets null
scheduler for the domain which is not present in non-debug build...

> 
> ~Andrew

~Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 14:32:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 14:32:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427708.677031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olt4d-0008UY-GU; Fri, 21 Oct 2022 14:32:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427708.677031; Fri, 21 Oct 2022 14:32:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olt4d-0008UR-Dh; Fri, 21 Oct 2022 14:32:35 +0000
Received: by outflank-mailman (input) for mailman id 427708;
 Fri, 21 Oct 2022 14:32:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JRa2=2W=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1olt4c-0008Tl-8h
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 14:32:34 +0000
Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com
 [2a00:1450:4864:20::330])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32c8e467-514d-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 16:32:32 +0200 (CEST)
Received: by mail-wm1-x330.google.com with SMTP id t4so2287935wmj.5
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 07:32:32 -0700 (PDT)
Received: from [192.168.1.175] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 j30-20020adfa55e000000b0021e51c039c5sm19956585wrb.80.2022.10.21.07.32.30
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 07:32:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32c8e467-514d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=yWfsfJk5hx3YdnSCVx+J9ZQWPQB2UtKYVlioTVCoe6Q=;
        b=LKo9gIspEGDjZ5aujnedyRII5wlF2qeUzXGeiMpsBP8KzPel8RQ4EHiqaRK/Ooe6eM
         CNbHd0JEIit91La08aVhUMVI8XnwgigNfHC0AoTyzVraxCaHtiU5kQ/6PaLw3ZL3vB1M
         qB/ak4yXhKchaGqgi1UIxkOM/176T0ZCUeW4Co8OmuncjNBexYBRIpMbPd8EC+Ptgjzv
         tCcJNK48GeoP7LqUt9ZLxaCpW2MvF4cU1Wit46thHzdGtkM5hYOvrIRwqFNd9PgKbc23
         0xIyFjSXHhY50Ax/nEPRmUSBTAZK9PNu/COj+aA604wuukAA42DVTXkofZ8Pkn9czSFr
         a1Kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=yWfsfJk5hx3YdnSCVx+J9ZQWPQB2UtKYVlioTVCoe6Q=;
        b=1xOoI8b/whGbZ5ZOzOaqqTsoeT+0s+JIux83rgYjC2o8cr2Njh+UYlAHk++OaM1S3Z
         VpAXaGkpQNiJjVtv8FN8Y7aDCUqYTAXmfFJ7EggCUEKZCR2W/gG59f4gR+M3nl55MgZp
         Fdz54mCTNgWGUJC4vFlLe0VAvuuebOuvGVwybnS5Ai6qC+XnBSLNXfzZKqXnMZt0G0w5
         L2jS7pocd/RV7Hiqj/fsybsZBxYFjmmRqqY6iV6MDCuelloNqkeF7TTSslM4SMypB2mi
         5/8+CxO5GF+rSSlB9/I5+HzFzUumQTj/W5Bf9qNVDyRov0wHDY9Ahz81Bv61Dn2+QGOv
         9kCw==
X-Gm-Message-State: ACrzQf1tOGRvfAQeOHWFYRbO8XR/zuAsjUnxzIotUXcbIjhR/OzOxs4F
	p9fTyP05iKYns6KfCOhUskQ=
X-Google-Smtp-Source: AMsMyM4m7QMb4HUpEeZenI17Ikl+Hrp2wTwl3mJq8owhR+d9LsT36DIEWUaKn5r5wQTgH9bO9gbXVQ==
X-Received: by 2002:a05:600c:3384:b0:3c6:f25a:96e9 with SMTP id o4-20020a05600c338400b003c6f25a96e9mr21595334wmp.112.1666362751960;
        Fri, 21 Oct 2022 07:32:31 -0700 (PDT)
Message-ID: <e9120354-e72e-2774-c382-45ab0cb76220@gmail.com>
Date: Fri, 21 Oct 2022 17:32:30 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>
References: <20220718211521.664729-1-volodymyr_babchuk@epam.com>
 <20220718211521.664729-5-volodymyr_babchuk@epam.com>
 <b4554a1f-73ab-7a46-591b-ccb5bb34ea1f@suse.com> <87ilntgzpj.fsf@epam.com>
 <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com>
Content-Language: en-US
From: Oleksandr <olekstysh@gmail.com>
In-Reply-To: <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Hello all.


On 19.07.22 13:40, Jan Beulich wrote:
> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
>> Jan Beulich <jbeulich@suse.com> writes:
>>
>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
>>>> iounmap(), but not added corresponding include.
>>>>
>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
>>> I don't think there's any active issue with the "missing" include:
>>> That's only a problem once Arm has vPCI code enabled? In which
>>> case I don't think a Fixes: tag is warranted.
>> Fair enough. May I ask committer to drop this tag?
> I had taken respective note already, in case I end up committing this.
> But this is the last patch of the series, so I can only guess whether
> it might be okay to go in ahead of the other three patches.
>
> Jan


I am wondering, where this patch could be 4.17 material?

The patch series seem to get stuck, but the current patch just adds a 
missing include to fix a build on Arm, so it is completely independent. 
I agree, there is no issue with the current code base as vPCI is 
disabled on Arm, so nothing to fix right now. But as PCI 
passthrough/vPCI on Arm is in the development stage, the developers 
enable that support in their builds. I think the risk is rather low than 
high.



-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 14:40:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 14:40:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427717.677043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oltCU-0001qT-Be; Fri, 21 Oct 2022 14:40:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427717.677043; Fri, 21 Oct 2022 14:40:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oltCU-0001qM-8U; Fri, 21 Oct 2022 14:40:42 +0000
Received: by outflank-mailman (input) for mailman id 427717;
 Fri, 21 Oct 2022 14:40:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=gujA=2W=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1oltCS-0001qG-Uf
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 14:40:41 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2060.outbound.protection.outlook.com [40.107.104.60])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4bc7289e-514e-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 16:40:24 +0200 (CEST)
Received: from AS9PR06CA0123.eurprd06.prod.outlook.com (2603:10a6:20b:467::14)
 by AM0PR08MB5347.eurprd08.prod.outlook.com (2603:10a6:208:17f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Fri, 21 Oct
 2022 14:40:35 +0000
Received: from VI1EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:467:cafe::8) by AS9PR06CA0123.outlook.office365.com
 (2603:10a6:20b:467::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.36 via Frontend
 Transport; Fri, 21 Oct 2022 14:40:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT062.mail.protection.outlook.com (100.127.145.26) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Fri, 21 Oct 2022 14:40:35 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Fri, 21 Oct 2022 14:40:34 +0000
Received: from f8afb7375ed1.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 ADB9B166-C4A2-421F-915F-8315FF6B510D.1; 
 Fri, 21 Oct 2022 14:40:24 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f8afb7375ed1.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 14:40:24 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB8304.eurprd08.prod.outlook.com (2603:10a6:10:40c::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Fri, 21 Oct
 2022 14:40:20 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 14:40:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4bc7289e-514e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=f/NbYJsJ2COhpMjsdce9OdOr8mhBFN/+YhKFkYRSJDUbxuGgT+0vjOO461i6I7/mythHre8DVPXb4VntQr4mfxybXJLsIDsDR2BFQpqWWre7rVMWhowriITLjkniGh7uGDlA4B/6Bs8VDT5NFDZclGrQjmWyleGoV7idoSIlSklhcVgPv63bZLTxH3BMlzhKFKW1cQfN9301JwDKsecq+KdWzf+64XIhWqfA/ZZX8OOi6tB4uKF/uwlO1MsPgAJq9j4dBMeDavCONOglmy8s2l1Uv+glKbSP5M3THsnh8QN1x5KxCJ6gaU5O8LympH+U0nUiCEc9OerFJBqk1zWrEg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4DhfaRwzrj7R7Idn7agp7jd2sNNMTdVmTJhcXH2ttPE=;
 b=CbcNj9c8ArRo7gVXzg4U0v8xQ3qijF9VK61RH+ZgOn80XUGccj6clM8DX9zVhqN5yFMF2jqkYeUSH0CErFXQyyh/mhgn7E6gAkzi5QRlr2hy79w7QlHgbOz6gm/fKq/gciONX2cZMThxuAVG3//fqFhkBRyPhfFsLLldW5QwPPOzRRQ3sbJX0uj5a9ALUP/FwDkaC5SyO6CD6tjCLrGo0sXCSh1r+B823x/IkFyo+NHJxAjakXJdjBGmy8SfbyZtKw67du5tmpVt7rUoJlaYnR8j6XqnO8YYB2uyuX4pbG4d2V7awxLGTRbGnq7nOZ4I+/jx00HQMosv4kNT41HOxg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4DhfaRwzrj7R7Idn7agp7jd2sNNMTdVmTJhcXH2ttPE=;
 b=ESrqdY7cOpuHC4g3Cq5rwM0TfjJrpBEw5abDFgp+84YuB+ixki+PDqF9qgO7U9P7oIfzpj3G+RlCEQBwNztvawHpi+FjLE3otRf98SCnkUlXx/HW/tGdGVB3gDdQKH3JbhLBpvFFLt3Cd/vUgkwITyWk5aellIGDEaJI2n/mlvc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kh84EcLqflwr+t9203NG7zwCpfVrDUGfmX45RTxj0CGee/FOCevGYX4sI2jDmzAotwDtYiKIoVBnd0qA4fuoMeFDJvH/tyYDqyLhUlBo2GodwxitXmrjtlwsK0/MPg3jAQqSOAQY8kQQaLTT8HxiVBga/nQZeKnOVUXcwRkUY9O2tNx8aNQEq63vEIi2i5n5wVltEGAqg1w/lCnk79PET681ogTLDCFEm9bTwL40CbDYiS2RhFAFWjFU3nuo+8rwUkUvmpx5BTbxp6jlPBgoDD8vZm8GjEBPJpoWa54xBGtWYoKG89g8EHpaYe/UNtpEVcMoeBT4S0AsgLDYsixQqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4DhfaRwzrj7R7Idn7agp7jd2sNNMTdVmTJhcXH2ttPE=;
 b=Dg4+TJUl9/nWFgAqStYmpRVcMC4hwii/kQSZGLH008hx03jmKDjftnta+REuEUtJ48KSgGtaCv+1sdr2uQiCMcPSWQupOmiQWT69UY7NJWtQTIiQ+rDHVkzu/L6P5ff7kMEE2T66eAHFSv02O6Sg7Qp/X5/nESq8vlIyqSif9eeURUE0QvIUeXVfVrPoWOeyabD7LMfJ+jQahPf0GiYobkQbpas435QJDwmOvGH8HsbL6jVtakF8Yo+nprT9sMD3OZ6HDtdvVlzITagzQ+m0wAAaPhz/d8u61TiYa2OV94UiG5sMykXAUf0BEmz4hMd+ieMT+YEoYysKX6HHSFfbAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4DhfaRwzrj7R7Idn7agp7jd2sNNMTdVmTJhcXH2ttPE=;
 b=ESrqdY7cOpuHC4g3Cq5rwM0TfjJrpBEw5abDFgp+84YuB+ixki+PDqF9qgO7U9P7oIfzpj3G+RlCEQBwNztvawHpi+FjLE3otRf98SCnkUlXx/HW/tGdGVB3gDdQKH3JbhLBpvFFLt3Cd/vUgkwITyWk5aellIGDEaJI2n/mlvc=
From: Henry Wang <Henry.Wang@arm.com>
To: Oleksandr <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Jan Beulich
	<jbeulich@suse.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Julien Grall <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
Subject: RE: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Thread-Topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Thread-Index: AQHYmuuJ09LC1x/2uEWs942YY/fNVK2FNeCAgABJdQCAAALGgICT+/QAgAAA3ZA=
Date: Fri, 21 Oct 2022 14:40:19 +0000
Message-ID:
 <AS8PR08MB7991C3933F253BE49BA61B76922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20220718211521.664729-1-volodymyr_babchuk@epam.com>
 <20220718211521.664729-5-volodymyr_babchuk@epam.com>
 <b4554a1f-73ab-7a46-591b-ccb5bb34ea1f@suse.com> <87ilntgzpj.fsf@epam.com>
 <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com>
 <e9120354-e72e-2774-c382-45ab0cb76220@gmail.com>
In-Reply-To: <e9120354-e72e-2774-c382-45ab0cb76220@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: ED7BD6521A943E47A6C3B30FF2FFF8EF.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB8304:EE_|VI1EUR03FT062:EE_|AM0PR08MB5347:EE_
X-MS-Office365-Filtering-Correlation-Id: 84dc4cfb-3d9b-456d-2843-08dab37236d4
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Zf8EGicFl9X2qbk/inrmsLQjw6mAfKl2eY0N8mP1sW5dcXc15Ffe6kD6r7TCB5ullL2zAHYjDaIFSrGXctAU59TL5b0J8huMTs8eFzrgwPKUaSQ1bY1oSDqFRb/xH8kLuIX8r3MBnV932SRdtXFGxgWG122MTs5ezhIsFVd4fopWHSF1liaxdNDTJvExmoGH3K4n+rGj+Pqk49IbCngRgnNAQKWSTzroN+B6yg6eGBJYnochFLGahH8SRQ3u9WMCeo+jQm9m46GnvGtOo6MoK198pE3s6enhByjZKPbm4WgfknzOoq4/XVdqbt9ZPuAi5EMJo15QiQD6Jo1Sg00eJGp0ThHsLMUlB9NO5tMonRZMRiQtyK89edweYWlqRMmoxGhmvv37DIlU73LbA1wuxJoy66L0DhjWjXqIF6p1t7scKB+JnrAi0NnvcUvYBTepKLQai87ynEINZxGyKP3yYnvDmuNz7Ik3iDFnyamVch7cbqHt3Ol/9QVWs3WDOZnz/7iP4laf9v/0jS9EZhEuu3+gThyDsQ8kkPPDb6Q8J84B9KsLfyGSq76Zj6nOpKyIbnFNSX5v7pxdIJfWSpNTqdnOl6+FzTlhOJw2diSRYjVbQXq11dfFCqw/hjCjlwv+uFQe1RKMRwhdI5nRcd06IwfqJo7huGCeMZ1A0VfYBQIzgQqYgrjj2FdWKGZwT1jIHIGB4RGIO3TxP0OT12j+dhgnFyswsWUZ6wUWyKaSjClm+68AF0Ce+HUi0WtFQZ0esgo/fOlEcNWmj+VD18/5lA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199015)(8676002)(186003)(38070700005)(83380400001)(38100700002)(86362001)(122000001)(7696005)(2906002)(41300700001)(5660300002)(52536014)(71200400001)(55016003)(8936002)(64756008)(26005)(316002)(6506007)(9686003)(53546011)(76116006)(66556008)(66476007)(66446008)(4326008)(6916009)(66946007)(478600001)(54906003)(33656002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8304
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ba0b3a81-02af-4ea0-108c-08dab3722d29
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/XrhTC1WibxMS9Mtb8J9YScwy18hFUzz8qMOBwyNAgCSXlA3uABy19NaHoYqv2LMHJlNHUchPVDEd3ecQRV21Mqyw6lYm+DuP2rrp4hp7YhZCDDxS6gsMtS4fxhuv1K900q+Ad0ZiOin7ng0ZiYhXxSUY5Ri72pOfU6t+3TzkoeDHQVZerkIdBq8P0q3u00APUfJ2HWYggWH3eS9m75H5epTXQ6tEjRvZgU0kflL72UnthwbviXKZsuP/ZtdHKY2Ax4c8Y+nAF+TsQYoP4HsdJ4shZAm5y5NtqPfM8efOsHobNQBkIJ4tvnRQONIh28VkDASSaBU1jP8nqRBU+xphz+Vf/lAjT7oUrhqhC6+fgHbq79vcvWHFvIv59kw6mxbJj7h/EWG18m9sVPXMm/+SSiymKg+d+bO2Hk/FJuOULgQLCxy5G/hKZFzHXXnrczCiWhYprMigR/+NWzC1R7XKPo015vftZouhw4xhPfWUNlnKLv6mLLXVTvvHsOuwonc1ogNbqPtoXtaCbCl26ZUZgOsgpcrTAJOHWBTzU669ZGfoRkXtajDm5QpaM3vACXrWdtlytLbmC9AAJZGSh5zgpCEQQnBOSdzpJ7HLfMP0/XmA81ZPe0XFd0LUSC7UdNe5q1Y4u4H+S4K0zUm6M20PHG/XMGI2j65uN8MFpIyG3eE0R2A9fihThLCXflPtLX4ObAKYiC2loHoGnDifOKmm9Cbpyk6D0K7hdKWeqWsr2/Y870bwsvO8A09279Zj9InmOa7i9AW4GyIMY50sWwFDQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(33656002)(2906002)(36860700001)(6862004)(47076005)(356005)(82740400003)(5660300002)(8676002)(81166007)(54906003)(186003)(336012)(4326008)(83380400001)(7696005)(53546011)(478600001)(6506007)(9686003)(82310400005)(86362001)(70206006)(70586007)(26005)(55016003)(41300700001)(52536014)(316002)(8936002)(40480700001)(40460700003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 14:40:35.2770
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 84dc4cfb-3d9b-456d-2843-08dab37236d4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5347

KCsgQXJtIG1haW50YWluZXJzKQ0KDQpIaSBPbGVrc2FuZHIsDQoNCj4gLS0tLS1PcmlnaW5hbCBN
ZXNzYWdlLS0tLS0NCj4gRnJvbTogT2xla3NhbmRyIDxvbGVrc3R5c2hAZ21haWwuY29tPg0KPiBT
dWJqZWN0OiBSZTogW1BBVENIIHYyIDQvNF0gdnBjaTogaW5jbHVkZSB4ZW4vdm1hcC5oIHRvIGZp
eCBidWlsZCBvbiBBUk0NCj4gSGVsbG8gYWxsLg0KPiBPbiAxOS4wNy4yMiAxMzo0MCwgSmFuIEJl
dWxpY2ggd3JvdGU6DQo+ID4gT24gMTkuMDcuMjAyMiAxMjozMiwgVm9sb2R5bXlyIEJhYmNodWsg
d3JvdGU6DQo+ID4+IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JpdGVzOg0KPiA+
Pg0KPiA+Pj4gT24gMTguMDcuMjAyMiAyMzoxNSwgVm9sb2R5bXlyIEJhYmNodWsgd3JvdGU6DQo+
ID4+Pj4gUGF0Y2ggYjRmMjExNjA2MDExICgidnBjaS9tc2l4OiBmaXggUEJBIGFjY2Vzc2VzIikg
aW50cm9kdWNlZCBjYWxsIHRvDQo+ID4+Pj4gaW91bm1hcCgpLCBidXQgbm90IGFkZGVkIGNvcnJl
c3BvbmRpbmcgaW5jbHVkZS4NCj4gPj4+Pg0KPiA+Pj4+IEZpeGVzOiBiNGYyMTE2MDYwMTEgKCJ2
cGNpL21zaXg6IGZpeCBQQkEgYWNjZXNzZXMiKQ0KPiA+Pj4gSSBkb24ndCB0aGluayB0aGVyZSdz
IGFueSBhY3RpdmUgaXNzdWUgd2l0aCB0aGUgIm1pc3NpbmciIGluY2x1ZGU6DQo+ID4+PiBUaGF0
J3Mgb25seSBhIHByb2JsZW0gb25jZSBBcm0gaGFzIHZQQ0kgY29kZSBlbmFibGVkPyBJbiB3aGlj
aA0KPiA+Pj4gY2FzZSBJIGRvbid0IHRoaW5rIGEgRml4ZXM6IHRhZyBpcyB3YXJyYW50ZWQuDQo+
ID4+IEZhaXIgZW5vdWdoLiBNYXkgSSBhc2sgY29tbWl0dGVyIHRvIGRyb3AgdGhpcyB0YWc/DQo+
ID4gSSBoYWQgdGFrZW4gcmVzcGVjdGl2ZSBub3RlIGFscmVhZHksIGluIGNhc2UgSSBlbmQgdXAg
Y29tbWl0dGluZyB0aGlzLg0KPiA+IEJ1dCB0aGlzIGlzIHRoZSBsYXN0IHBhdGNoIG9mIHRoZSBz
ZXJpZXMsIHNvIEkgY2FuIG9ubHkgZ3Vlc3Mgd2hldGhlcg0KPiA+IGl0IG1pZ2h0IGJlIG9rYXkg
dG8gZ28gaW4gYWhlYWQgb2YgdGhlIG90aGVyIHRocmVlIHBhdGNoZXMuDQo+ID4NCj4gPiBKYW4N
Cj4gDQo+IA0KPiBJIGFtIHdvbmRlcmluZywgd2hlcmUgdGhpcyBwYXRjaCBjb3VsZCBiZSA0LjE3
IG1hdGVyaWFsPw0KPiANCj4gVGhlIHBhdGNoIHNlcmllcyBzZWVtIHRvIGdldCBzdHVjaywgYnV0
IHRoZSBjdXJyZW50IHBhdGNoIGp1c3QgYWRkcyBhDQo+IG1pc3NpbmcgaW5jbHVkZSB0byBmaXgg
YSBidWlsZCBvbiBBcm0sIHNvIGl0IGlzIGNvbXBsZXRlbHkgaW5kZXBlbmRlbnQuDQo+IEkgYWdy
ZWUsIHRoZXJlIGlzIG5vIGlzc3VlIHdpdGggdGhlIGN1cnJlbnQgY29kZSBiYXNlIGFzIHZQQ0kg
aXMNCj4gZGlzYWJsZWQgb24gQXJtLCBzbyBub3RoaW5nIHRvIGZpeCByaWdodCBub3cuIEJ1dCBh
cyBQQ0kNCj4gcGFzc3Rocm91Z2gvdlBDSSBvbiBBcm0gaXMgaW4gdGhlIGRldmVsb3BtZW50IHN0
YWdlLCB0aGUgZGV2ZWxvcGVycw0KPiBlbmFibGUgdGhhdCBzdXBwb3J0IGluIHRoZWlyIGJ1aWxk
cy4gSSB0aGluayB0aGUgcmlzayBpcyByYXRoZXIgbG93IHRoYW4NCj4gaGlnaC4NCg0KSXQgc2Vl
bXMgcmVhc29uYWJsZSB0byBtZSwgYnV0IEkgYW0gY3VyaW91cyBhYm91dCB3aGF0IEFybSBtYWlu
dGFpbmVycw0KYW5kIFBDSSBtYWludGFpbmVycyB0aGluay4gRnJvbSB0aGUgaGlzdG9yeSBkaXNj
dXNzaW9uIGluIHRoaXMgdGhyZWFkIEkNCnRoaW5rIGl0IGlzIHByZXR0eSBzYWZlIHRvIGluY2x1
ZGUgdGhpcyBpbiA0LjE3LiBUaGFua3MgZm9yIHRoZSBwaW5nLg0KDQpLaW5kIHJlZ2FyZHMsDQpI
ZW5yeQ0KDQoNCj4gDQo+IA0KPiANCj4gLS0NCj4gUmVnYXJkcywNCj4gDQo+IE9sZWtzYW5kciBU
eXNoY2hlbmtvDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 14:54:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 14:54:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427723.677054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oltPP-0003VK-JM; Fri, 21 Oct 2022 14:54:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427723.677054; Fri, 21 Oct 2022 14:54:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oltPP-0003VD-G2; Fri, 21 Oct 2022 14:54:03 +0000
Received: by outflank-mailman (input) for mailman id 427723;
 Fri, 21 Oct 2022 14:54:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=MvAv=2W=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1oltPN-0003V4-MD
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 14:54:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29604d4e-5150-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 16:53:45 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 450FF1F8E1;
 Fri, 21 Oct 2022 14:53:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0B7DF13A0E;
 Fri, 21 Oct 2022 14:53:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id jue5AIeyUmPpLwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 21 Oct 2022 14:53:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29604d4e-5150-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666364039; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=ypwwZtddv/zbC+omssU6L3ECl6BXc92riOBC2cN9wvM=;
	b=PFV1mf5IhuJxOyLsor7uWtWecOb6oD/v1vV7NF2IBaNSbndlVmIsjkqjRU/w8IyHSrQMR+
	OmDYemgNNUSI+p/ZDFTOaF5ynFk8eVECHkogq8oBxG9tcpYk8PRt33PUaBR8bksv2TOmQ8
	NA2jtzCXURlIfklWtJfd6iemBGcJTLY=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after suspend
Date: Fri, 21 Oct 2022 16:53:57 +0200
Message-Id: <20221021145357.17931-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today all timers are migrated to cpu 0 when the system is being
suspended. They are not migrated back after resuming the system again.

This results (at least) to problems with the credit scheduler, as the
timer isn't handled on the cpu it was expected to occur.

Add migrating the scheduling related timers of a specific cpu from cpu
0 back to its original cpu when that cpu has gone up when resuming the
system.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
This is an alternative approach to this one:
https://lists.xen.org/archives/html/xen-devel/2022-09/msg00510.html
---
 xen/common/sched/core.c    | 23 +++++++++++++++
 xen/common/sched/cpupool.c |  2 ++
 xen/common/sched/credit.c  | 13 +++++++++
 xen/common/sched/private.h | 10 +++++++
 xen/common/sched/rt.c      | 58 ++++++++++++++++++++++++++------------
 5 files changed, 88 insertions(+), 18 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 23fa6845a8..142d03ade5 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1284,6 +1284,29 @@ static int cpu_disable_scheduler_check(unsigned int cpu)
     return 0;
 }
 
+/*
+ * Called after a cpu has come up again in a suspend/resume cycle.
+ * Migrate all timers for this cpu (they have been migrated to cpu 0 when the
+ * cpu was going down).
+ * Note that only timers related to a physical cpu are migrated, not the ones
+ * related to a vcpu or domain.
+ */
+void sched_migrate_timers(unsigned int cpu)
+{
+    struct sched_resource *sr;
+
+    rcu_read_lock(&sched_res_rculock);
+
+    sr = get_sched_res(cpu);
+    if ( sr->master_cpu == cpu )
+    {
+        migrate_timer(&sr->s_timer, cpu);
+        sched_move_timers(sr->scheduler, sr);
+    }
+
+    rcu_read_unlock(&sched_res_rculock);
+}
+
 /*
  * In general, this must be called with the scheduler lock held, because the
  * adjust_affinity hook may want to modify the vCPU state. However, when the
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index b2c6f520c3..bdf6030ab0 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1035,6 +1035,8 @@ static int cf_check cpu_callback(
     case CPU_ONLINE:
         if ( system_state <= SYS_STATE_active )
             rc = cpupool_cpu_add(cpu);
+        else
+            sched_migrate_timers(cpu);
         break;
     case CPU_DOWN_PREPARE:
         /* Suspend/Resume don't change assignments of cpus to cpupools. */
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index 47945c2834..f2cd3d9da3 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -614,6 +614,18 @@ init_pdata(struct csched_private *prv, struct csched_pcpu *spc, int cpu)
     spc->nr_runnable = 0;
 }
 
+static void cf_check
+csched_move_timers(const struct scheduler *ops, struct sched_resource *sr)
+{
+    struct csched_private *prv = CSCHED_PRIV(ops);
+    struct csched_pcpu *spc = sr->sched_priv;
+
+    if ( sr->master_cpu == prv->master )
+        migrate_timer(&prv->master_ticker, prv->master);
+
+    migrate_timer(&spc->ticker, sr->master_cpu);
+}
+
 /* Change the scheduler of cpu to us (Credit). */
 static spinlock_t *cf_check
 csched_switch_sched(struct scheduler *new_ops, unsigned int cpu,
@@ -2264,6 +2276,7 @@ static const struct scheduler sched_credit_def = {
     .switch_sched   = csched_switch_sched,
     .alloc_domdata  = csched_alloc_domdata,
     .free_domdata   = csched_free_domdata,
+    .move_timers    = csched_move_timers,
 };
 
 REGISTER_SCHEDULER(sched_credit_def);
diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h
index 0126a4bb9e..0527a8c70d 100644
--- a/xen/common/sched/private.h
+++ b/xen/common/sched/private.h
@@ -331,6 +331,8 @@ struct scheduler {
                                     struct xen_sysctl_scheduler_op *);
     void         (*dump_settings)  (const struct scheduler *);
     void         (*dump_cpu_state) (const struct scheduler *, int);
+    void         (*move_timers)    (const struct scheduler *,
+                                    struct sched_resource *);
 };
 
 static inline int sched_init(struct scheduler *s)
@@ -485,6 +487,13 @@ static inline int sched_adjust_cpupool(const struct scheduler *s,
     return s->adjust_global ? s->adjust_global(s, op) : 0;
 }
 
+static inline void sched_move_timers(const struct scheduler *s,
+                                     struct sched_resource *sr)
+{
+    if ( s->move_timers )
+        s->move_timers(s, sr);
+}
+
 static inline void sched_unit_pause_nosync(const struct sched_unit *unit)
 {
     struct vcpu *v;
@@ -622,6 +631,7 @@ struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu, bool aff_alloc);
 void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu);
 int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *mem);
 int sched_move_domain(struct domain *d, struct cpupool *c);
+void sched_migrate_timers(unsigned int cpu);
 struct cpupool *cpupool_get_by_id(unsigned int poolid);
 void cpupool_put(struct cpupool *pool);
 int cpupool_add_domain(struct domain *d, unsigned int poolid);
diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index 1f8d074884..d443cd5831 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -750,6 +750,27 @@ rt_switch_sched(struct scheduler *new_ops, unsigned int cpu,
     return &prv->lock;
 }
 
+static void move_repl_timer(struct rt_private *prv, unsigned int old_cpu)
+{
+    cpumask_t *online = get_sched_res(old_cpu)->cpupool->res_valid;
+    unsigned int new_cpu = cpumask_cycle(old_cpu, online);
+
+    /*
+     * Make sure the timer run on one of the cpus that are still available
+     * to this scheduler. If there aren't any left, it means it's the time
+     * to just kill it.
+     */
+    if ( new_cpu >= nr_cpu_ids )
+    {
+        kill_timer(&prv->repl_timer);
+        dprintk(XENLOG_DEBUG, "RTDS: timer killed on cpu %d\n", old_cpu);
+    }
+    else
+    {
+        migrate_timer(&prv->repl_timer, new_cpu);
+    }
+}
+
 static void cf_check
 rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
@@ -759,25 +780,25 @@ rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     spin_lock_irqsave(&prv->lock, flags);
 
     if ( prv->repl_timer.cpu == cpu )
-    {
-        cpumask_t *online = get_sched_res(cpu)->cpupool->res_valid;
-        unsigned int new_cpu = cpumask_cycle(cpu, online);
+        move_repl_timer(prv, cpu);
 
-        /*
-         * Make sure the timer run on one of the cpus that are still available
-         * to this scheduler. If there aren't any left, it means it's the time
-         * to just kill it.
-         */
-        if ( new_cpu >= nr_cpu_ids )
-        {
-            kill_timer(&prv->repl_timer);
-            dprintk(XENLOG_DEBUG, "RTDS: timer killed on cpu %d\n", cpu);
-        }
-        else
-        {
-            migrate_timer(&prv->repl_timer, new_cpu);
-        }
-    }
+    spin_unlock_irqrestore(&prv->lock, flags);
+}
+
+static void cf_check
+rt_move_timers(const struct scheduler *ops, struct sched_resource *sr)
+{
+    unsigned long flags;
+    struct rt_private *prv = rt_priv(ops);
+    unsigned int old_cpu;
+
+    spin_lock_irqsave(&prv->lock, flags);
+
+    old_cpu = prv->repl_timer.cpu;
+    if ( prv->repl_timer.status != TIMER_STATUS_invalid &&
+         prv->repl_timer.status != TIMER_STATUS_killed &&
+         !cpumask_test_cpu(old_cpu, sr->cpupool->res_valid) )
+        move_repl_timer(prv, old_cpu);
 
     spin_unlock_irqrestore(&prv->lock, flags);
 }
@@ -1561,6 +1582,7 @@ static const struct scheduler sched_rtds_def = {
     .sleep          = rt_unit_sleep,
     .wake           = rt_unit_wake,
     .context_saved  = rt_context_saved,
+    .move_timers    = rt_move_timers,
 };
 
 REGISTER_SCHEDULER(sched_rtds_def);
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 14:56:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 14:56:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427729.677068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oltSB-0004BR-3h; Fri, 21 Oct 2022 14:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427729.677068; Fri, 21 Oct 2022 14:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oltSB-0004BK-0G; Fri, 21 Oct 2022 14:56:55 +0000
Received: by outflank-mailman (input) for mailman id 427729;
 Fri, 21 Oct 2022 14:56:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=scaJ=2W=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1oltS9-0004BC-0N
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 14:56:53 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80042.outbound.protection.outlook.com [40.107.8.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 985d22a3-5150-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 16:56:51 +0200 (CEST)
Received: from AS9PR04CA0119.eurprd04.prod.outlook.com (2603:10a6:20b:531::15)
 by AS8PR08MB9624.eurprd08.prod.outlook.com (2603:10a6:20b:617::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 14:56:49 +0000
Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:531:cafe::cc) by AS9PR04CA0119.outlook.office365.com
 (2603:10a6:20b:531::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26 via Frontend
 Transport; Fri, 21 Oct 2022 14:56:49 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 14:56:48 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Fri, 21 Oct 2022 14:56:48 +0000
Received: from 93ec7cc1da45.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 11B51ACF-C84C-4B81-87B0-53E32E730C96.1; 
 Fri, 21 Oct 2022 14:56:36 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 93ec7cc1da45.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 21 Oct 2022 14:56:36 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com (2603:10a6:208:104::24)
 by AS8PR08MB6038.eurprd08.prod.outlook.com (2603:10a6:20b:23f::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 14:56:34 +0000
Received: from AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::8ef6:111f:6067:acd3]) by AM0PR08MB3778.eurprd08.prod.outlook.com
 ([fe80::8ef6:111f:6067:acd3%7]) with mapi id 15.20.5723.035; Fri, 21 Oct 2022
 14:56:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 985d22a3-5150-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=YGtSxNE5myEVmeZVr4nwGmHWhkPAtZyFt2cU7ljqFCFAfMna8Wa1+yp/DAgveqHlZ000Y7e34E8y/U2CJEEDksX7gp9872FpW6tu/KNsFUe1YsKe3/rYG347Sjo/NGcDZHev1QnWBJa4/ZEVHSem6lHDMbZRZ63tOMuj1+xHLmZ/sHOWDO8rZZpR4MdLz79NJLmNjq5oiR2K6oGcfolzJk1z9816vKLBgFwV/+OHpPYCzTc/Bv82pHc9NMQ1S4/e95KCiH6K13y1Q/kdweJR6q1a0zSb5Khv7ZuD8+U3w9ju94KSXsg00W8uv1CwpvSJZLXabOGCUgYSrgA5OOFWoQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=N+AJTeUqYNtxnch9ejq92GsYm13vJfj9SOXeRKb1HDc=;
 b=a+13BAqc6dCzbI0vlAUAdIE/AyzFL3Wl9bolHs2eod/2pSREkmuW6/KbRJ+Xdifookk3ff/iC4BV4IdN8wJ86kHrGtouMbuM+jlSLSlwdNrFD1zOXA+BuThQkSo6pmuMSIuFZ4PfPdrm9SmP+aBkq8QNhlaS2uOFfGknBQiJraYXijrSNB0M27JKr4DnhL45YsQr54OzPaSoukvXPpIATW9PFdOgRPyXYYSoejGyJ2Ghrr1RJa4yPcSIMknEIWoNJnz/g0eHAijuCOydCW4BjHe3AVkYgITniTanAzHNEt43dlDPXbrdOV+slwx6A3gUkKZSeGBeEbmpKVb9eVQROQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=N+AJTeUqYNtxnch9ejq92GsYm13vJfj9SOXeRKb1HDc=;
 b=osQ7xukSJBuB1mH1lwIQr1gWqfgtrJ1PnA2Y8TahB5w13XgT95cF88BpI9f4EAwDKttfloLOrnupdRxTCpOc808HRfmaNOKCbXkTe0kKVw1KaOVYq7ocENToPgZRBHAreqqnIWelDwO3cvWJNXqVOp3PogWX0M4usZU103+otxE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9b48faae844691c9
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lzfO3JzAtCLuGcxXSEDpC0OwPgrpUzHRauBHLsXaJkSipYl4S9kimjIxPdKb1h73WB5UtYkxr8IJr9rwmQ4G+djmtYlvYRpVQWipqbF9NPiOyr49Gh503yw1cbxK7t1g6dSoA82NM6AXILV0OLTAMjGxuGVEcH75f/bx/N/sx1EMIzSwC37AojccN+7t0S/p5eD+bWyRB9iBzpFXssIrDGx+ianmPutmXPOnKhdsMo4Wl+27J5ADDSLfVNZaQFLdeZdu5/LSZlv0kXQzPnx0p6Sqci98BTL4QKPgKh0KorSyrxavfD6tYn54IIyGNwL6Pb0C+n+BPnsHf4VZ5eDVEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=N+AJTeUqYNtxnch9ejq92GsYm13vJfj9SOXeRKb1HDc=;
 b=SNz722bPrgctMZ2J/Dn4nFjJ8cnmxbZ7a/EB2aDmEElzCx8zu1DHgQrgT7I8UCra/epo1Pv6+UlNz+LFGa+/c7szDy81y/H2MNdtrxaijDdITysN3RWL0sEBS89YXSREcqs1amehKyWaQ+owsGdADxtTgKcS4DhZOq0F5duh7p239nLyJCfrMTzP5jS3uS6M51NK91mwIulM/812fMxrCN0zQzn2a5fuMw+S9l6orRc9d7RnH4OtOLjxwt+0A12xcTslUsF2sqh1lYlFb3kqcNVWYFMC6A1V9nslWiDeM17pwxbRhucF4EpxYmcFC7To5l5UDutnylgHbZ9LDfDFzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=N+AJTeUqYNtxnch9ejq92GsYm13vJfj9SOXeRKb1HDc=;
 b=osQ7xukSJBuB1mH1lwIQr1gWqfgtrJ1PnA2Y8TahB5w13XgT95cF88BpI9f4EAwDKttfloLOrnupdRxTCpOc808HRfmaNOKCbXkTe0kKVw1KaOVYq7ocENToPgZRBHAreqqnIWelDwO3cvWJNXqVOp3PogWX0M4usZU103+otxE=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Henry Wang <Henry.Wang@arm.com>
CC: Oleksandr <olekstysh@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>
Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Thread-Topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Thread-Index:
 AQHYmuuiv6EaG5L7CkOUEJgfIhzZ362FNeCAgABJ9YCAAAJFgICT+/QAgAACL4CAAASKgA==
Date: Fri, 21 Oct 2022 14:56:34 +0000
Message-ID: <0F295AC7-1D2C-4F5D-A421-9440CEB2B5FA@arm.com>
References: <20220718211521.664729-1-volodymyr_babchuk@epam.com>
 <20220718211521.664729-5-volodymyr_babchuk@epam.com>
 <b4554a1f-73ab-7a46-591b-ccb5bb34ea1f@suse.com> <87ilntgzpj.fsf@epam.com>
 <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com>
 <e9120354-e72e-2774-c382-45ab0cb76220@gmail.com>
 <AS8PR08MB7991C3933F253BE49BA61B76922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
In-Reply-To:
 <AS8PR08MB7991C3933F253BE49BA61B76922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3778:EE_|AS8PR08MB6038:EE_|AM7EUR03FT006:EE_|AS8PR08MB9624:EE_
X-MS-Office365-Filtering-Correlation-Id: 56b17453-6530-4964-6556-08dab3747acc
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jVdxz0qPTibB1tsNMz4aPuESZymAWZeyvher7o69KfUkqfL8y+vyXYXnF0oS/KVEFwrZDFINlQR1Glamw70jgK8L3+ieM4YhPFvTkmihw+KNuyD+dgx8JdLryvSe3vktjpcR91/hnU7RdUcJk0RzHhumwKRyIu4ITFUwughGV3q0W9wpW7HyK185E4yDfx8JIvx2kOxRY7HJJ5A0wvGviVLwcehCkazYzaxi6UJhOBFwba7YtyGNvg5xoNjhi0Bzr4PXdKMSs5Ms7jRl2k9V6+ITRpRj84c6UL7hm7KIZWNeFst6F7LZ51wZ4/w1Y5crVpCVlv1/c/0ia/uIluApe51mIxZI9evnPbmjRCJp+1Hj7HSaf/fPX8jbIRBhPkcDGpIPw7yHD/PWdh7A7arWNLxZ3UkJYLPM98dP9AjRVZjJfjPZR8Zx04m0vVUBohcRowlTOS+Le1lORwAzgk9QlPdzPXVcAYux1yf8zxhknnt8LOXIhg3b2qsPBMBBznKxnlfyqnIq3Trn4mFHX8HkGLcz0OIYvnkOR/JKYN9XMi0ESdTjqyGx8FSZooQLXVo/hKBAbQ2muLAjkFLPdsAgf9a3ZFgM09nkYY6a3TygEyCDxb5PPms+OWyAHf7/QbJ8mlQXVo3Q3xTrjy/mzQbqYzDlIfvt7wpMmQY610BMVIkUO9fumKizHf/BrW9jRtk5JkkCrKi/JnGZC/eNkKwD/KHpNL6XICR6HQQ2e/JQpUEEc0M5HYEQ9wIFtEQHaRglwQy3DqnrqT+OwEXcfGW81f+iPdz4PoGzhALXXo6Cep0=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3778.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(451199015)(2906002)(86362001)(33656002)(36756003)(38100700002)(38070700005)(122000001)(83380400001)(5660300002)(53546011)(186003)(2616005)(6506007)(26005)(6512007)(71200400001)(6486002)(54906003)(41300700001)(478600001)(6862004)(6636002)(37006003)(8676002)(91956017)(66476007)(66446008)(64756008)(76116006)(316002)(66556008)(8936002)(4326008)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <50AD676810409C47B8789C1F010A5E1D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6038
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c74edc65-c552-405b-0369-08dab3747274
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dl8h7OiAV6xa05r8Nt6MKAyBJl3mTNcAY9ECWcfgnp6sUp3TCHCTKQ4jyDmjoXKv/NvXL08C8yqKQskNFxGoLwAPMqTdVDcEQhA3DIIM93J/XFQRvcnuc3xkoqTKJWWVaQw/VdfZO4CyKWXPD9kei5Cfm02eE0hvWafhqJEo2TTzC9y79q33tn5SfIuAlg0jyRIvmfasSc1XHTladFKC+PWCR+eh8uOWC+aG9nqQqoQTF1NYlpOianUID6q8d5rPtXiCktI1N71aIMD7DGBHUX7o8Sje22arDy6mNPUIVzUjOhURbODirgf45mIA/m7RFs0u6dqBVIQTjklQSKtOX9B4XGCG2ySgpinszTd7UfpR7lrBO+qNArQUBz5d23Y/Klb6FIEM3Iy573bh7J62GHMmdpx5wnWgX0ickjM8T1qi/BKTws94w+heVEXReK3mkRxVUMumlTmSwxLeVehuz2i1Crv7yzJAkcybc5uGDfJR481fA2dkqA2NuNbc4eVqdSrpPpOa13PggPW7rpqAGEvYhasIjWQznwBuEW3Mwhe1QD+rsEviI8DY2y3Bsbb87kxOy+JgPsWDCoEhaQ2DNpq4V/NzLrYStS1+uNFqyCNz1pXWfzzEvTjfI6gwPpkCbNdZ/oXpUJV5SV2kI5Yh7xw6QaM1VQLgyEa2vIlqRpTAexhsng6P7d+BQDTWwtWZMwdUascEPm0vUkcdD9mkBDW8bDmx8Z2xInbFTl11COJ8LprFaWUnEScA/7iOTWDohs0uY1IVluR+eyf7fQSvzQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(356005)(54906003)(86362001)(4326008)(47076005)(6636002)(8676002)(70206006)(41300700001)(316002)(6506007)(5660300002)(26005)(83380400001)(37006003)(8936002)(36860700001)(6862004)(336012)(40480700001)(70586007)(36756003)(53546011)(107886003)(6512007)(81166007)(6486002)(82740400003)(186003)(33656002)(40460700003)(2906002)(478600001)(82310400005)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 14:56:48.3671
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 56b17453-6530-4964-6556-08dab3747acc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9624

Hi,

> On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote:
>=20
> (+ Arm maintainers)
>=20
> Hi Oleksandr,
>=20
>> -----Original Message-----
>> From: Oleksandr <olekstysh@gmail.com>
>> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>> Hello all.
>> On 19.07.22 13:40, Jan Beulich wrote:
>>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
>>>> Jan Beulich <jbeulich@suse.com> writes:
>>>>=20
>>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
>>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call t=
o
>>>>>> iounmap(), but not added corresponding include.
>>>>>>=20
>>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
>>>>> I don't think there's any active issue with the "missing" include:
>>>>> That's only a problem once Arm has vPCI code enabled? In which
>>>>> case I don't think a Fixes: tag is warranted.
>>>> Fair enough. May I ask committer to drop this tag?
>>> I had taken respective note already, in case I end up committing this.
>>> But this is the last patch of the series, so I can only guess whether
>>> it might be okay to go in ahead of the other three patches.
>>>=20
>>> Jan
>>=20
>>=20
>> I am wondering, where this patch could be 4.17 material?
>>=20
>> The patch series seem to get stuck, but the current patch just adds a
>> missing include to fix a build on Arm, so it is completely independent.
>> I agree, there is no issue with the current code base as vPCI is
>> disabled on Arm, so nothing to fix right now. But as PCI
>> passthrough/vPCI on Arm is in the development stage, the developers
>> enable that support in their builds. I think the risk is rather low than
>> high.
>=20
> It seems reasonable to me, but I am curious about what Arm maintainers
> and PCI maintainers think. From the history discussion in this thread I
> think it is pretty safe to include this in 4.17. Thanks for the ping.

I think this can safely go in for 4.17.

Cheers
Bertrand

>=20
> Kind regards,
> Henry
>=20
>=20
>>=20
>>=20
>>=20
>> --
>> Regards,
>>=20
>> Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:31:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:31:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427735.677082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu00-0000An-J1; Fri, 21 Oct 2022 15:31:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427735.677082; Fri, 21 Oct 2022 15:31:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu00-0000Ab-G6; Fri, 21 Oct 2022 15:31:52 +0000
Received: by outflank-mailman (input) for mailman id 427735;
 Fri, 21 Oct 2022 15:31:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oltzy-0000AU-VH
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:31:51 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam04hn2217.outbound.protection.outlook.com [52.100.161.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 79cf14bd-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:31:48 +0200 (CEST)
Received: from BN9PR03CA0218.namprd03.prod.outlook.com (2603:10b6:408:f8::13)
 by MN0PR12MB6127.namprd12.prod.outlook.com (2603:10b6:208:3c5::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 15:31:45 +0000
Received: from BN8NAM11FT098.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:f8:cafe::56) by BN9PR03CA0218.outlook.office365.com
 (2603:10b6:408:f8::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:31:45 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT098.mail.protection.outlook.com (10.13.177.196) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:31:44 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:31:41 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:31:41 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:31:40 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79cf14bd-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CByo2xcbgorMXAd8gbvXKbaSVRO6/1gDjSz2wRDImyEH0qAYi5lSHHNEacHFU1SI0bpSyP4L6Xumob7z8e9CqmwUHX1CwJq3ffYUi1hFteuvxZ8z/W7+xQcgkHhR6mx49ZokHcPloNJGh/OkwQR592pIO7ZwsxffgyEKoy6Q83DGYfN7256vesHtjm75FixSzunuG+5+SrwTkehO/XrgSu/XzVmvlAoVEnCJgEujjM7V9NCE4ELkhlUU42fD/uheu1IoGZ37aT4inCzoObVSTLnWzzq1+ylYngq141wiN2YBxi+udK+zBAELL7Be8G918VCNyY3knp8Q6KmDwBCDNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J5B3TqJ58VJAkItxAN9gqSaQ9XwjpKLxd/rGzStRCyQ=;
 b=oQNneGlqtEgwtnNhgjn2s46GUdIXk7WzktbTXtph1Ua8lS/n4anUfKRgW4n6y59xKoGtQSu1yrwyI3rdwFIAPuU1TtpTZwx/80xr93opkNDQAWnjqNv1GNbFMNgXTZTPVMDh+X/xkVOxu7YmauCEafNLuFhtS9Iuqd7T1PfZJWWlWkyYbKYYdPANZd8z7WiL1YQBsgI/Kp49hiNzWiF/t3+khVp3Kffvdwv/xc7IoHVPEjTAECcv8MwusuJVvwflurbfEoKZqvuxA8d66gSeW1fTCFzQwUyMtA5gZQMuXfi+klBEReWZujJarLAyAd1aYFB+goq1D59eI9VKnsQpCg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J5B3TqJ58VJAkItxAN9gqSaQ9XwjpKLxd/rGzStRCyQ=;
 b=UmWDB72Tl18AeTS8tGSoRz5oSlH6RPYhAXkame/erAxRaCw5iAVYsWBFjLjZoVxJYcAWDRWQ0bcQjd9yTMd0Dqmtjm/NE1I8D1p5iflxVBeLLKc8rmD5TorXOD+25VE+P0goZGQXTN09m+DOmPmvjc4E5yLHZuP1ithWHA4Rwdo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 00/12] Arm: Enable GICv3 for AArch32
Date: Fri, 21 Oct 2022 16:31:16 +0100
Message-ID: <20221021153128.44226-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT098:EE_|MN0PR12MB6127:EE_
X-MS-Office365-Filtering-Correlation-Id: b40479c9-53ea-469f-b4bd-08dab3795c74
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	=?us-ascii?Q?bzS9r9DJSXaGJHYY+kyzTT52cN7XEsMv8CdVyK4DxUIXHt10IGnAN5IkR6l6?=
 =?us-ascii?Q?eOOqk2J2g8GIeMuI7W2CvpZ9iYaSt/03jgG2sgNMzM96R7EFqyWb44AOf5ls?=
 =?us-ascii?Q?RpX+zpirVdeoYjacl12Ht0NIj0h9LYn3ipNFu7fzSy3VR+nxHQC6SPRLSfgt?=
 =?us-ascii?Q?qkWXMYZQDatZwFZ/aZWmCx7WNBWQg7B+3yzlZJI3nnawesH3faBUYemLji4q?=
 =?us-ascii?Q?Jc2IsY/qXqw/SrkmsNOSyFHTvWbB3qcCzQDrK7VLbfZJKsE8bZMtqtCCBqwQ?=
 =?us-ascii?Q?bhUkbEPrcGehnOlR3+umAdn9fzxd4jv/3qjcLNoDEuESwBlrbh6eIbwsiUEt?=
 =?us-ascii?Q?QEZuE0QYCv53o9YnN9DB5rN6HFLMOJ5hErQ0XSfPTRkgfxR22VzNUD/QOLUB?=
 =?us-ascii?Q?UiwtewrSMGOfMkrUiXKji47lOD/TmGxcYUb/1cgnrVkyrRwdwTMSCy3gizf5?=
 =?us-ascii?Q?svOkWoxwp7534YY/hs5unQ6tk+T+V42fKEpE0KL8ETuXpJZ4c+jObeTaIlZ/?=
 =?us-ascii?Q?XBwUESp1JAVDSdH3XkcFqAp/WugV0ycH4riRN8vPzfZWrDIHr/PJWLvNlukj?=
 =?us-ascii?Q?GmLSUa95u29DSLK6HNpPIsWZHN0DUHLbJSEfMEUfj3WH4TLmnRKGEqxD0Ha/?=
 =?us-ascii?Q?pTNMuXTE2mG/dUBfciTnwlhShXRXV7cw4sAB0TSe+lk+3BkU28ULeagGgxCi?=
 =?us-ascii?Q?J1+xro7ee3w77A4Xv2ZUgaZrlL4fJ1/KrdZxXCPbdljLRDt1C6/uGDNvgCmN?=
 =?us-ascii?Q?Wem+dhI3Cp+/X5fyb1Kd6u57hLh+nL+rZw4HT+qaKbWiAqk8zncUiLVryHUV?=
 =?us-ascii?Q?LoIDyHope4IG56kdtNpHkOujtBxMeAvCls43TD4lQpIFGzkvSsnVAjAMyPCg?=
 =?us-ascii?Q?Zl/Le856ysCfrTcv/cs/7hZdqw0+CX9znnoXDoUWLSlkakdjitt0CDrabre0?=
 =?us-ascii?Q?F8N9pzmyrFcjkHLDDiTIjr+lrhg2mB7uMDcxGlOl1uUvLzE6is4CruC4ll/4?=
 =?us-ascii?Q?7DDFyFanCt19cXOsSZzEHLyV2YY9yZWwhUNZ0PAzyk9vWamwEOBIxFCKr+3m?=
 =?us-ascii?Q?scxSkpLsQB4r0272ymXR/hL7UXwotIhjjrUHkrs/r7WM1VYzWo3PUV3fqjTR?=
 =?us-ascii?Q?3JT/8u9DmeJOSiRrkPYuLV0sI0tcqjIwCFBZhdxr8EIYBmgqEl4dOudwaXlp?=
 =?us-ascii?Q?oXWRpLUbRdJaZPt4mesaKLdH2ZF2Sxrvk2QgsQmHEVoVVxVFtODsgCzyAh4?=
 =?us-ascii?Q?=3D?=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:OSPM;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(40470700004)(36840700001)(46966006)(40480700001)(356005)(426003)(186003)(47076005)(2906002)(336012)(82740400003)(83380400001)(40460700003)(36860700001)(1076003)(82310400005)(36756003)(81166007)(54906003)(5660300002)(8936002)(70206006)(316002)(2616005)(478600001)(6916009)(41300700001)(8676002)(26005)(6666004)(70586007)(4326008)(36900700001)(11215385002);DIR:OUT;SFP:1501;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:31:44.9444
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b40479c9-53ea-469f-b4bd-08dab3795c74
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT098.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6127

Hi All,

Please find the following patches to enable GICv3 for AArch32.
This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system)

Let me know your thoughts.

Ayan Kumar Halder (12):
  Arm: GICv3: Sysreg emulation is applicable for Aarch64 only
  Arm: GICv3: Move the macros to compute the affnity level to
    arm64/arm32
  Arm: GICv3: Enable vreg_reg64_* macros for AArch32
  Arm: GICv3: Emulate GICR_TYPER on AArch32
  Arm: GICv3: Emulate GICR_PENDBASER and GICR_PROPBASER on AArch32
  Arm: GICv3: Emulate of ICC_SGI1R on AArch32
  Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
  Arm: GICv3: Define ICH_AP0R<n> and ICH_AP1R<n> for AArch32
  Arm: GICv3: Define GIC registers for AArch32
  Arm: GICv3: Use ULL instead of UL for 64bits
  Arm: GICv3: Define macros to read/write 64 bit
  Arm: GICv3: Enable GICv3 for AArch32

 xen/arch/arm/Kconfig                       |   2 +-
 xen/arch/arm/gic-v3-its.c                  |  20 ++--
 xen/arch/arm/gic-v3-lpi.c                  |   8 +-
 xen/arch/arm/gic-v3.c                      | 132 ++++++++++-----------
 xen/arch/arm/include/asm/arm32/io.h        |   4 +
 xen/arch/arm/include/asm/arm32/processor.h |  10 ++
 xen/arch/arm/include/asm/arm32/sysregs.h   |  80 +++++++++++++
 xen/arch/arm/include/asm/arm64/processor.h |  13 ++
 xen/arch/arm/include/asm/arm64/sysregs.h   |   7 +-
 xen/arch/arm/include/asm/cpufeature.h      |   1 +
 xen/arch/arm/include/asm/gic_v3_defs.h     |  24 ++--
 xen/arch/arm/include/asm/gic_v3_its.h      |   2 +-
 xen/arch/arm/include/asm/processor.h       |  14 ---
 xen/arch/arm/include/asm/vreg.h            |  23 ++--
 xen/arch/arm/vgic-v3-its.c                 |  17 +--
 xen/arch/arm/vgic-v3.c                     |  26 ++--
 16 files changed, 242 insertions(+), 141 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427736.677093 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0F-0000WQ-0j; Fri, 21 Oct 2022 15:32:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427736.677093; Fri, 21 Oct 2022 15:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0E-0000WJ-TS; Fri, 21 Oct 2022 15:32:06 +0000
Received: by outflank-mailman (input) for mailman id 427736;
 Fri, 21 Oct 2022 15:32:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0E-0000AU-6a
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:06 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 837e7f1a-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:05 +0200 (CEST)
Received: from BN9PR03CA0428.namprd03.prod.outlook.com (2603:10b6:408:113::13)
 by MN0PR12MB6319.namprd12.prod.outlook.com (2603:10b6:208:3c0::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 15:32:01 +0000
Received: from BN8NAM11FT018.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:113:cafe::a) by BN9PR03CA0428.outlook.office365.com
 (2603:10b6:408:113::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:01 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT018.mail.protection.outlook.com (10.13.176.89) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:00 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:31:57 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:31:57 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:31:56 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 837e7f1a-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TvKMrSFQZIOHJ7gnjFo3DdY1BYe4UPKoPSiML4Yak3GkmL2v4nkvK95CS+Zh90KioQzb320IOqgmstXr9au1ExlUBziJo16ypJoU+oWWUio6GyBElab6WRcck26bFHjFFxnDQoVN+8/Dk5NS6DK9uKf66JmVaI52sIXHjrWHtT1dlNt1vuCzQcCUK/4FDYPZXfzJlbrcQacLniJ82VpfsOS1p6L7Sq9AzN1HpE70ebo04XQ1a4jYkUUd9IZba3STRAat/kloSKG6Ad/csdwxWhFIvVl2A1grX6TIjALwiBIXuEuJ1aOYqIeSiqXTvqCgBlFSYC/OfvjmXg1oWFG2Ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yeM/jQyVI4e8F7utEeCiyfeBbYsSPRRaablKg4pztz8=;
 b=bdozwgnoU+6QNEp92sWervpQNY5MKpk5AsKKpgs4Bibf+kpt0Bs6r3FCM9r5M1IZIl8/hUkIXaTRGE3Dr5bk02EHVBRYStfhZ3qhghloQpeKS+SjbFZ+mPPYV7NjVuJSsiQq1MuPx4cBHLlQBubnJ6vDB/ZdN3FSMdf3O1pYH7jD/QMoQ91ed2MwMQx6WC37PZFUahvFR+/EYY2EpX6T61Y42yY1TKIatVFA6yxaRcfWt0cLGp/RkrMs/7zCEofQwGqISJKQRKXkV3BTG8fOkRFZzU/ZxVFF86MobChxbFJLGIUqhY/d/5StrJ2IApgFomP9MPhj1fiNjOMnVTLtpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yeM/jQyVI4e8F7utEeCiyfeBbYsSPRRaablKg4pztz8=;
 b=u5SR6+eSKTujNXMLvsodjnMzGcIu3+DWGhsviQfMpib8JEN1A4uUr0RFvjidQWaeMpCB99ikxnZvc4js4/bhrjEYV8tE2/SaYua0CUoLfEj1ypY/wb6OtjFMymryj7o46FinPU1I/JwxmZhKtYSjJgsc6tAE1ZzFhphCPdj1igY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 01/12] Arm: GICv3: Sysreg emulation is applicable for Aarch64 only
Date: Fri, 21 Oct 2022 16:31:17 +0100
Message-ID: <20221021153128.44226-2-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT018:EE_|MN0PR12MB6319:EE_
X-MS-Office365-Filtering-Correlation-Id: ef95849f-fcec-4e2a-42cf-08dab37965f0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xbE6eyyPJmD9Tb/YTpKB+sPbR8jeBrzmY4TukGJNKkkDHivDPYM3LPKG9J/QU5cYmpQGOyANQjROI+aev2++RaTZg6LzwTBuk1JFX8newkIiBRXw7Rq7JogoHzvm6nTh3OZx+RxI+Wpz6yyJnaqKT8TlnK1Kh9Dc7p34g6vJi4lNaqzoEZTjDgzb9TxqTak8IpRd5gHFEy/wywxLGxn2OWgNhZvkswfwPPhypKpnRC5QVotfGaGKRdqETOMJVjQfesZfXpm0ckrhbDebNAmNi3R4+J5BwbcngPSyJIhuM5hdDgTX8VFztQ8zbiWv+sHVf487URmlHiw0iVjNkl7j98CFAB2u1uuLJxNRnI7lUun1VPkflOniDeRoYkNiQjXqm/OtpKO9QU7y9JHiJEJJuinE4+wrWiXAMjKB7lJCh9v9JFf+Er9nyjP+l1asFQenQqVrXBPcd6pkbbGY+zUR/tHbHJkOfLrzVbCngqzZWjsADwhCccS4v4hJxNKX/ywkaR3sI1+VAcMd6+O1U/s3gA/vvfD/yKpFOc7zsw2iTnhUR/eEs4pGxjTAAcxYcB/38IGp5z76g76I5Y47uV/2q6aLln8Kfpu5jPmpqjI/lB9PTx2vdHMrZ3F+AE7qGv1JgeUB7F8nfX8PeqiFHXvLu1P9gE3HMvFJ/UTY4rDQEOLKBQt+bTV6CNO8u47pa3uEE9JzbwnFr22QXPA7RCv6LmL+zLU8szzG6YF8U/VX7w+fWybA/6YxbfDPlrpFSAX0Yib9moqpad9tzVYPd/9IckMYUGBfU6w76SH9KcWS9YQ=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(70586007)(82740400003)(6666004)(5660300002)(186003)(8936002)(1076003)(36860700001)(40460700003)(336012)(36756003)(40480700001)(2616005)(41300700001)(70206006)(4326008)(8676002)(426003)(47076005)(26005)(2906002)(478600001)(82310400005)(356005)(81166007)(316002)(54906003)(6916009)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:00.8537
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ef95849f-fcec-4e2a-42cf-08dab37965f0
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT018.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6319

Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
only. This is when MSR, MRS, System instruction execution in AArch64 state
is trapped, that is not reported using EC 0b000000, 0b000001 or 0b000111.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/vgic-v3.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..c31140eb20 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1520,6 +1520,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs *regs, uint64_t *r,
     }
 }
 
+#ifdef CONFIG_ARM_64
 static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
 {
     struct hsr_sysreg sysreg = hsr.sysreg;
@@ -1540,6 +1541,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
         return false;
     }
 }
+#endif
 
 static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr)
 {
@@ -1563,8 +1565,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs *regs, union hsr hsr)
 {
     switch (hsr.ec)
     {
+#ifdef CONFIG_ARM_64
     case HSR_EC_SYSREG:
         return vgic_v3_emulate_sysreg(regs, hsr);
+#endif
     case HSR_EC_CP15_64:
         return vgic_v3_emulate_cp64(regs, hsr);
     default:
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427738.677104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0J-0000rJ-8M; Fri, 21 Oct 2022 15:32:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427738.677104; Fri, 21 Oct 2022 15:32:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0J-0000rA-51; Fri, 21 Oct 2022 15:32:11 +0000
Received: by outflank-mailman (input) for mailman id 427738;
 Fri, 21 Oct 2022 15:32:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0H-0000AU-Rs
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:09 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2058.outbound.protection.outlook.com [40.107.243.58])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85ce2734-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:08 +0200 (CEST)
Received: from BN9PR03CA0182.namprd03.prod.outlook.com (2603:10b6:408:f9::7)
 by CH3PR12MB7497.namprd12.prod.outlook.com (2603:10b6:610:153::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 15:32:05 +0000
Received: from BN8NAM11FT056.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:f9:cafe::4a) by BN9PR03CA0182.outlook.office365.com
 (2603:10b6:408:f9::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:05 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT056.mail.protection.outlook.com (10.13.177.26) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:05 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:02 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:32:01 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:31:59 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85ce2734-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HAPcqhL4ZQ5vW8bZHmPTeXLgEl6MsnCldQZYVvfmqu07YUu5xrMVQEu5GbW4Q8A6lG1EWlKorgaSeWcsJppin5Y7VjHr2gd4JFXRCDjABwETZVl6h2tYBD8DuU2wp61nDuXAtN96jNzk75YTgTkvQACwnArd8z3O/g+TYeQiZlyIOvZbIMR1UXUQeqHtUQTnONZA0hah2x9eJP5ZM8FCwJXBJW3tgxYEhzcbmZHk4Tr+r/pqfL80t+/S/AWS+dEl6AJy3QY6USRsao8Gp+u41Ty7ITUUyxr5vB1xt7pRzpfIhz+8pKgaCFoUhyKqy71Qy0WtvYdNnGgn3/Bz71YUHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8IcGxl8RRMIxH3os3XBZf6ggKOB0EWQZFW1lSNxYXBw=;
 b=g/BVc3AMrCTigM7m701cngmO8GDhMsv4tyvzH9bAfAV33muxvwhwDLuzy6UxaIekP1MVL05696KkoxoPLwpmzcScTEKxvuXlQXKc3EvtGjcfru/5e7scFBnCPprcdECqjiPVlqpTcVjRtUXcwWBsnqYem12Rs2HudpnwbIjHM/wF59cnhJRt2+1a3mSXqWbibAXD9LX35J3rFmh86JBQUfDbM8yfuCWechYykhko0842rzlssoQzF6JKoe6SZBVum6fFo1c05CA7Cc2kZRbn5T36Emwy4Hscj38ZgRPFsS0TG6Le43z9i+HF8N8ejN2mJ1JiemJo6iu+fht3r9A/DA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8IcGxl8RRMIxH3os3XBZf6ggKOB0EWQZFW1lSNxYXBw=;
 b=eFNjPX7dqWpnRAcPMPFN8zsTkEIQ6xrCsIcJXgdtg8crIYtdMCOull1JIptSh0QGy9aFejeFcosSrQUW/wsqnD1aS8czyr37wuqjBH5wVQdorf+UwzFmA4kg1/1f6+qjyl8ZtlFFCyFL1AOiSnH5YEedpuayJUfcU7cfb2aFddM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 02/12] Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32
Date: Fri, 21 Oct 2022 16:31:18 +0100
Message-ID: <20221021153128.44226-3-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT056:EE_|CH3PR12MB7497:EE_
X-MS-Office365-Filtering-Correlation-Id: 306a0c7a-cd74-45fc-b6b6-08dab379687f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xRAKep4aX+Wez7T1xQTkOI4t+8TrMrwbL0KKC70pc+keeJRcflLu41uNaDCeKMMzyopjn4HLDXVi5q92Ep53klYwibnGxap5D9+c8ifxq7BeYKkxuP/yDLP+eTJX1cmDBTArwsBLmX2YUgy5Uhi27vYLtjBx2rb/VvUEx1jLBZWGKeOQ8cLDfSBmuGt1EpIqIcF+hSWhPBAUduA5lMasrZiN+GyzEVvkTWsQYFy/Nipbor7QPX57FbnTH/0X0/XwyzYx4y7kAgw5UbQR+WsCp6h5+XxKjD66PhrV5vvXT+gy+ws22vrWZG+Vpwq6UOh9SThZD1CZVQvbWGELTe/L/ftN662nZaH0FTdk46dnRDFfxeV++hp0egAXFRfRfVbWpZJJIXjhNk3aXgj4mYN8erCAs0J3vjmWp/DsGMkBZ/OW9D9I7jXZHzRZMQEYm+8fO0UkQYvKUWfHKuA6y2oxaQld7mJ8ssGFwqBTAZewGYM8OgjJ4d24y6PZDc6SknXV8h98PgHIaRd18vPUB6e9PcRPx1DgPJBXMLSYQ04ynYqCNKL5ZFtVhanTWSAnfaXUO5KqUFU9j7uTgtAc791N1ogEqDXO2oyvt48iBGRJ/NyMpUU6Ukk/TpoLFi2adeNz65MRbnAHg8hpRN9HrfNllGwYWvHUL+Z8ljt3kP3+tPvfHk3q7uAuBkm6XrF0Gv5CtdneI3nx3Xi3q6bZg8Eq2hxBSJt/IdtixXxNbwpeQTzehvnMsldiBjF9maNvCD0fDZ2kdi/G3lSmExjkwLZS5t1VqUGZ+uRLm7yym5qbjkUs/zy3Es08z819zzScuLbdXWN7SsmOTqMvOPKEa/PYDUHTxayCI72H99/NCBki6rIyxBdlr9DqjfGWO/YnQpM4
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(316002)(6916009)(41300700001)(54906003)(186003)(8936002)(47076005)(426003)(40480700001)(2616005)(26005)(6666004)(2906002)(70586007)(336012)(1076003)(5660300002)(70206006)(83380400001)(36756003)(40460700003)(4326008)(8676002)(478600001)(82310400005)(81166007)(356005)(82740400003)(966005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:05.1492
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 306a0c7a-cd74-45fc-b6b6-08dab379687f
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT056.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7497

Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
include/asm/cputype.h#L14 , these macros are specific for arm64.

When one computes MPIDR_LEVEL_SHIFT(3), it crosses the width of a 32
bit register.

Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
asm/cputype.h#L54  , these macros are specific for arm32.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/include/asm/arm32/processor.h | 10 ++++++++++
 xen/arch/arm/include/asm/arm64/processor.h | 13 +++++++++++++
 xen/arch/arm/include/asm/processor.h       | 14 --------------
 3 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/include/asm/arm32/processor.h b/xen/arch/arm/include/asm/arm32/processor.h
index 4e679f3273..3e03ce78dc 100644
--- a/xen/arch/arm/include/asm/arm32/processor.h
+++ b/xen/arch/arm/include/asm/arm32/processor.h
@@ -56,6 +56,16 @@ struct cpu_user_regs
     uint32_t pad1; /* Doubleword-align the user half of the frame */
 };
 
+/*
+ * Macros to extract affinity level. Picked from kernel
+ */
+
+#define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1)
+#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
+
+#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
+    ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK)
+
 #endif
 
 #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
diff --git a/xen/arch/arm/include/asm/arm64/processor.h b/xen/arch/arm/include/asm/arm64/processor.h
index c749f80ad9..c026334eec 100644
--- a/xen/arch/arm/include/asm/arm64/processor.h
+++ b/xen/arch/arm/include/asm/arm64/processor.h
@@ -84,6 +84,19 @@ struct cpu_user_regs
     uint64_t sp_el1, elr_el1;
 };
 
+/*
+ * Macros to extract affinity level. picked from kernel
+ */
+
+#define MPIDR_LEVEL_BITS_SHIFT  3
+#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
+
+#define MPIDR_LEVEL_SHIFT(level) \
+         (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
+
+#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
+         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
+
 #undef __DECL_REG
 
 #endif /* __ASSEMBLY__ */
diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
index 1dd81d7d52..7d90c3b5f2 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -118,20 +118,6 @@
 #define MPIDR_INVALID       (~MPIDR_HWID_MASK)
 #define MPIDR_LEVEL_BITS    (8)
 
-
-/*
- * Macros to extract affinity level. picked from kernel
- */
-
-#define MPIDR_LEVEL_BITS_SHIFT  3
-#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
-
-#define MPIDR_LEVEL_SHIFT(level) \
-         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
-
-#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
-         (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
-
 #define AFFINITY_MASK(level)    ~((_AC(0x1,UL) << MPIDR_LEVEL_SHIFT(level)) - 1)
 
 /* TTBCR Translation Table Base Control Register */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427739.677115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0K-00018w-KY; Fri, 21 Oct 2022 15:32:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427739.677115; Fri, 21 Oct 2022 15:32:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0K-00018n-Ec; Fri, 21 Oct 2022 15:32:12 +0000
Received: by outflank-mailman (input) for mailman id 427739;
 Fri, 21 Oct 2022 15:32:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0J-0000nK-33
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:11 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2080.outbound.protection.outlook.com [40.107.94.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 860af235-5155-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 17:32:09 +0200 (CEST)
Received: from BN9PR03CA0672.namprd03.prod.outlook.com (2603:10b6:408:10e::17)
 by IA1PR12MB6281.namprd12.prod.outlook.com (2603:10b6:208:3e7::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Fri, 21 Oct
 2022 15:32:05 +0000
Received: from BN8NAM11FT045.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:10e:cafe::45) by BN9PR03CA0672.outlook.office365.com
 (2603:10b6:408:10e::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:05 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT045.mail.protection.outlook.com (10.13.177.47) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:05 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:04 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:03 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 860af235-5155-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S5NlqKIp2AhLESUckS4yH+T0Ohi/XfCzEd5yvIohnxN/OV00rUc0xpXYcSdgEzuhlqGuUqwbtZiwyos2vdQN7vu9DCFjBl3rYCV71sNA6+/6ioq9AT9uuDf07vIJoFav8TOa9s03iaHG0PJY5d14XQs7+zYHskZo/RuUG6/8Nf9vnbMVpPCnzsF3uOg7h97+KE17TaWhaQzSwsIuoITv797nZaHPxMtmktS8K0N41ql3TwtM+xiPlyQDu7Qa8KFtE9xjHwTQH8ZxNiv6bFsB/vHltJqJMpME3LChm/5/+Nqq2Oy28QIIb1XumFCV94J6uyd8+zPGegKz0R5nYB6x0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JJMSyBlDQwvi9L8pMaAlcyuBO1JJuHAXtoeiZrBPh7s=;
 b=K3FEwDhy2a3PJp2oqwC6cJwgrnrn7WEtt8qOgWOtKQJZqHo0+gBdGxIXV1KpJWX4Q4I1CifVU6TPDoSUYZL6xl471fL/13Iehu2dlUsvc0P63kMU74cSgHu9mWPdLrYf3TPvR8hFC9a6TfGe71upyC+CR9YTnxP7jjSJpGRZPmTK14UZBDzSORv1/3hwb9l/y9D1wSZ6R0e0T+I+93+74RIRwpGKdfLZQXhg+eg4FP3bOFqi8PM6Uq/M5MbRaIzIqeexe1G1Sh6wA6mDxj3UODOMLw4LV2l2DDwt6JSoBqlQefUZZn26cZX/LXXc2BhJiZY+J48DNYTNCfibA+BwMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JJMSyBlDQwvi9L8pMaAlcyuBO1JJuHAXtoeiZrBPh7s=;
 b=3o0/SSfkbHhknX3IrVxL6bc0UGHdwMnsIQ/rlnsAiYczlhUuGswNln7Y0FmBNdS5SwpwTF7pXYxiJ2cS22GjHfcWlcQNof1EAb6NAzYuIXjG/9XkT1uYiKNR58F2VMLfEA27KAgsbnOT5HGIMw77gAXqWTsXTqRCrqcW+8G+xv8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for AArch32
Date: Fri, 21 Oct 2022 16:31:19 +0100
Message-ID: <20221021153128.44226-4-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT045:EE_|IA1PR12MB6281:EE_
X-MS-Office365-Filtering-Correlation-Id: 8f385dee-6892-49c2-dbac-08dab379686e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pgVOpVJYvg1kjNgiGfm4vFwxKUi8YM199IJ5Y7gquURQM0k+AP1yLzh2rnQa6v1n7E1ckKgjTruXh1sY8RoX5995p4h7vRQ8mIRfWqmSriFeBfl/EPaWfukCLsOUCqcC1L1hMlFcfeW8qc4Zfefykv/yWTDBVHgxCMQHMeI++xPqTAbx4TStB2ewcykIk8E2x2qyl4EkD9mUT2VIPMtzr7BTolxq3K2rNbvNy1FFvw817MW4W/kV5cCNk4T0f/r/OZ+K7p2ETiuCpt/9m5S3i+C73uw8peQ448Iddn+4ZntKd+r5P2vXmRUkvSucVi0RdOlE9CbZD+5w6zm+0o+bvGFG+tlvYoGzj3D4Ud6QhfK4QnyGThGQbDtunDSLuw3fDopMkbLd4COrci3b53A+ydwKqJFfUrtyxrThjh7MEFfGE5gD0Z5qWaPjRQa6N2ME3vgIJwHVpBYVmLIlTEVEh+9RGH/WAj0Kk3at29oTuoRrO2uhxjYiF5VIug/9yo+Qn8dAYV9Pb8KjyIG409TrXseo+16lArBEmH4t7eQbtCvnGa8G2lfK9MGDs24djBXtwe1JK/bMwPUmxzOlgtsfDh3VR3nxrAK/I09qTQtUh+KasHXYyL7B0krTe7tC44CNHCvLrF2rfSnTBAbJodIYsK6DrhjQcEGLMZhe7aJNkUkQOOudVEnCHuym7e5PArtA1egMU7Vx9K+qOBThwZA7UZrSsSWI3rohIB/JfMzVg9WaOn6Ff+2VI5ZZjO5kygA5yHepD8icJvVBYK3D+hEH/2fuG3WRiCmAchu/FA1j4fE=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(8676002)(8936002)(41300700001)(5660300002)(2906002)(4326008)(356005)(70206006)(6916009)(82740400003)(36860700001)(478600001)(26005)(6666004)(70586007)(316002)(186003)(36756003)(82310400005)(54906003)(40480700001)(40460700003)(2616005)(81166007)(1076003)(336012)(83380400001)(426003)(47076005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:05.0388
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f385dee-6892-49c2-dbac-08dab379686e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT045.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6281

In some situations (eg GICR_TYPER), the hypervior may need to emulate
64bit registers in aarch32 mode. In such situations, the hypervisor may
need to read/modify the lower or upper 32 bits of the 64 bit register.

In aarch32, 64 bit is represented by unsigned long long. Thus, we need
to change the prototype accordingly.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/include/asm/vreg.h | 23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h
index f26a70d024..ac6e702c5c 100644
--- a/xen/arch/arm/include/asm/vreg.h
+++ b/xen/arch/arm/include/asm/vreg.h
@@ -95,7 +95,7 @@ static inline bool vreg_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr
  * Note that the alignment fault will always be taken in the guest
  * (see B3.12.7 DDI0406.b).
  */
-static inline register_t vreg_reg_extract(unsigned long reg,
+static inline register_t vreg_reg_extract(unsigned long long reg,
                                           unsigned int offset,
                                           enum dabt_size size)
 {
@@ -105,7 +105,7 @@ static inline register_t vreg_reg_extract(unsigned long reg,
     return reg;
 }
 
-static inline void vreg_reg_update(unsigned long *reg, register_t val,
+static inline void vreg_reg_update(unsigned long long *reg, register_t val,
                                    unsigned int offset,
                                    enum dabt_size size)
 {
@@ -116,7 +116,7 @@ static inline void vreg_reg_update(unsigned long *reg, register_t val,
     *reg |= ((unsigned long)val & mask) << shift;
 }
 
-static inline void vreg_reg_setbits(unsigned long *reg, register_t bits,
+static inline void vreg_reg_setbits(unsigned long long *reg, register_t bits,
                                     unsigned int offset,
                                     enum dabt_size size)
 {
@@ -126,7 +126,7 @@ static inline void vreg_reg_setbits(unsigned long *reg, register_t bits,
     *reg |= ((unsigned long)bits & mask) << shift;
 }
 
-static inline void vreg_reg_clearbits(unsigned long *reg, register_t bits,
+static inline void vreg_reg_clearbits(unsigned long long *reg, register_t bits,
                                       unsigned int offset,
                                       enum dabt_size size)
 {
@@ -149,7 +149,7 @@ static inline void vreg_reg##sz##_update(uint##sz##_t *reg,             \
                                          register_t val,                \
                                          const mmio_info_t *info)       \
 {                                                                       \
-    unsigned long tmp = *reg;                                           \
+    unsigned long long tmp = *reg;                                      \
                                                                         \
     vreg_reg_update(&tmp, val, info->gpa & (offmask),                   \
                     info->dabt.size);                                   \
@@ -161,7 +161,7 @@ static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
                                           register_t bits,              \
                                           const mmio_info_t *info)      \
 {                                                                       \
-    unsigned long tmp = *reg;                                           \
+    unsigned long long tmp = *reg;                                      \
                                                                         \
     vreg_reg_setbits(&tmp, bits, info->gpa & (offmask),                 \
                      info->dabt.size);                                  \
@@ -173,7 +173,7 @@ static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
                                             register_t bits,            \
                                             const mmio_info_t *info)    \
 {                                                                       \
-    unsigned long tmp = *reg;                                           \
+    unsigned long long tmp = *reg;                                      \
                                                                         \
     vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask),               \
                        info->dabt.size);                                \
@@ -181,15 +181,8 @@ static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
     *reg = tmp;                                                         \
 }
 
-/*
- * 64 bits registers are only supported on platform with 64-bit long.
- * This is also allow us to optimize the 32 bit case by using
- * unsigned long rather than uint64_t
- */
-#if BITS_PER_LONG == 64
-VREG_REG_HELPERS(64, 0x7);
-#endif
 VREG_REG_HELPERS(32, 0x3);
+VREG_REG_HELPERS(64, 0x7);
 
 #undef VREG_REG_HELPERS
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427740.677126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0N-0001Sv-0R; Fri, 21 Oct 2022 15:32:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427740.677126; Fri, 21 Oct 2022 15:32:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0M-0001Sn-Sr; Fri, 21 Oct 2022 15:32:14 +0000
Received: by outflank-mailman (input) for mailman id 427740;
 Fri, 21 Oct 2022 15:32:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0L-0000AU-Gs
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:13 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8815fba4-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:12 +0200 (CEST)
Received: from BN0PR02CA0060.namprd02.prod.outlook.com (2603:10b6:408:e5::35)
 by MW4PR12MB5626.namprd12.prod.outlook.com (2603:10b6:303:169::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct
 2022 15:32:08 +0000
Received: from BN8NAM11FT022.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:e5:cafe::87) by BN0PR02CA0060.outlook.office365.com
 (2603:10b6:408:e5::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:08 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT022.mail.protection.outlook.com (10.13.176.112) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:08 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:07 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:06 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8815fba4-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GcHTjNjvS1jAWXNebH74PccSqFd7KGuR4XsHHqC949oyBqFmesrNeZiUILyKL0H+kJh10wu1bzOeboChKVqjLSoOqBUBrwDei9e0L6HvLDDTocAkfOOKsNRCvnh8ie/zP6nlH9ORtshnrSiLJgjVLgZiIteTgr50QZEQLDhX1dgapMEIoOPyKPlJ3QxogM7kmxNSGXsBSGK6pMbi+qrdrdMH52PRi7DMzSBJqJhOLA20s/ZzHBC9EhwU65R5YZ1/1HAnX/TgTJapTWYFU6OsyL7HGhz58ZnJ7DCxQlYemStOktCRq/MVzxc+7/8yI2vEZfJB4v3hG0S5Ht8uUsc5rA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=d3z1fYyjNNFULchMYPGXqvwacdX9nW9qmaUMKuj/M3A=;
 b=MXflJ8A/mAsFIuDw3RbocJkvWeyj3ljYnRh7dEPcEtVjGN/iuwbH8UYhXamWaPIJUvsINmdx+KIKhhArJTJ9BUFT/77zT8u44UpTYA4V8FLFMiXsQ45v34TiD/KM13PzTNHVJRxcE6U06QrRojLca8Pyv8hcZmyHByXOrYw5wPXL+SJwQrCsG+xPNtDoJxyWB9YQNZyQ0VL1vBPPMeae3dxgseX5JHlmL+CKyxYo9LJxMpC2JGgeNCsMiVg6zOQv9UmjpPrHeNQ1SgOXekl6p/JdcHdp6T/RQCuRaOYrEe4vTpgl41t4M+yV3gOCOa3AzISDfDrAmzYZxJyuUhGTzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=d3z1fYyjNNFULchMYPGXqvwacdX9nW9qmaUMKuj/M3A=;
 b=x+hjeR/kGqA+zLETj2Ta8PT0VHLtXwEcYfjOM7y47E1UG6w71hunllmtn67YqsOKy8fQ/bSZdB4U+6tUaXhOIJz7Drs5OpsJ6QjF9rpR4dQUEjVbPRd/xXreAylmjGtPL3MbFZ62S82GzurFZL5MllNxpmfme5SZvVpgFiHfl9M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 04/12] Arm: GICv3: Emulate GICR_TYPER on AArch32
Date: Fri, 21 Oct 2022 16:31:20 +0100
Message-ID: <20221021153128.44226-5-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT022:EE_|MW4PR12MB5626:EE_
X-MS-Office365-Filtering-Correlation-Id: 8d5d9836-905d-4508-a848-08dab3796a6a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dhxz+fe6OvZFIQrAnIXbWKmMqu89GV6SlAMrlJzxfn5zcHHyJtplTlDsCdfCkYR3f6KF4fSYAMtcFH1ixhVk1iBg/qe6Iow8q1yXsSUMH5JjSm10OVRtPKd8lH35qFz2+XPE+GVPMHh+0FPEZMqoOvgrCOVmYRwf0FoEm/xEbZLnZIM1+mxoV+w24lL3LXc1tKEVQHnm3eOsbJvJjxEbYVNXQ8mcEIxKppa+s1MhmJ4tmxDh3FMOtBXxb3I0YQkDb1DIhLGm3sIsFzNgSZPHD8D5XRzEQe5T/OiXuX3g71fUqEDlEFl7aoXvrpbxhLf1yMtUdJhcWWz/ro4lYfNHanGE+iWwuBhi02sRCz8gAghErTm/61ZUNTlUViIu5VSnCUKC+WyB0wll+95zcwpbIeM95+sypb7RkdeLWXv1WMh6MNPMDfy1ILt8NBLtw6q2X2JnnO62qKHTR5PJyI3KHxuPAmR7SliuZKjBLTibgfYkonyq7oOV89jRaj+W6LUM9qIPJO8+T82tTgAjaNgtk+oQ4kBFAav17tKDTvJYmkFxwsDl50NF0+sZDG/E4sq68T8NhWWFr5oV3tgGMEWWILosmfsW/Y/zW7DUZWGoyzuE4jTJnWvoI/F96MyFP3DgZwusd2r9qrgeWCpZsCxdSZ1rmRXGj0+IlzgMUHyc16KGWvZgbke3c3lAw1QjiOzqmIGTsex74zQTXoEuKfxfk8H9TcW66Tym8HSL8E/hMzmk5eiHKcZCm2vBMJDvUtYcYaEJdbla96zenzFI/jZwzhac7BzmDJLKstTk1Pxutww=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(40460700003)(26005)(6666004)(1076003)(83380400001)(36860700001)(478600001)(336012)(47076005)(186003)(426003)(5660300002)(40480700001)(8936002)(2616005)(6916009)(54906003)(316002)(4326008)(70206006)(8676002)(41300700001)(82310400005)(70586007)(36756003)(2906002)(356005)(82740400003)(81166007)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:08.3667
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d5d9836-905d-4508-a848-08dab3796a6a
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT022.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5626

Refer Arm IHI 0069H ID020922,
The upper 32 bits of GICR_TYPER represent the affinity
whereas the lower 32 bits represent the other bits (eg processor
number, etc).
MPIDR_AFFINITY_LEVEL() returns a 32 bit number on aarch32. Thus, this
is appended to return GICR_TYPER register.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/vgic-v3.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index c31140eb20..d86b41a39f 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -190,14 +190,18 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
 
     case VREG64(GICR_TYPER):
     {
-        uint64_t typer, aff;
+        uint64_t typer;
+        uint32_t aff;
 
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
-        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 |
-               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 |
-               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 |
-               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32);
+        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 24 |
+               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 16 |
+               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 8 |
+               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0));
         typer = aff;
+
+        typer = typer << 32;
+
         /* We use the VCPU ID as the redistributor ID in bits[23:8] */
         typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT;
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427742.677137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0Q-0001ng-9X; Fri, 21 Oct 2022 15:32:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427742.677137; Fri, 21 Oct 2022 15:32:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0Q-0001nL-4y; Fri, 21 Oct 2022 15:32:18 +0000
Received: by outflank-mailman (input) for mailman id 427742;
 Fri, 21 Oct 2022 15:32:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0P-0000AU-1Z
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:17 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2062.outbound.protection.outlook.com [40.107.243.62])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 89796854-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:14 +0200 (CEST)
Received: from BN9PR03CA0408.namprd03.prod.outlook.com (2603:10b6:408:111::23)
 by DM4PR12MB5343.namprd12.prod.outlook.com (2603:10b6:5:389::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Fri, 21 Oct
 2022 15:32:11 +0000
Received: from BN8NAM11FT004.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:111:cafe::8c) by BN9PR03CA0408.outlook.office365.com
 (2603:10b6:408:111::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:11 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT004.mail.protection.outlook.com (10.13.176.164) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:11 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:11 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:32:11 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:09 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89796854-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KyC52lAKrdJCWtQeH8ppbu9A/YSUSSGN48VtUYdt2T5F2MtHym4wyo9/RpjnhsHFc3C7uFp31ZSqjR9uqhXFrM2sMGJ6DLWJp+e+rXezlHsQOc82hjKqEEK7hTRuxRtMMyjSA8V8QjnE2zCGw/YeRB3TzUjONzQd6rakOTzpmklfTTG4Xjg+DadjlTRStmKHSP7NDT+i4Ci7NSbjUH5Pe4CGUa4/9bRmYRRyMXrO2ofswV/BxJnGj6b0mNsR/60swda3AjMTr0W7u6+p8hI9IrIHPKW2sUQ6MaJYK0iN+7R5FYfQnvd+OUMfRFimoIQWqZT5nzEHwTJMnFDn9dyLKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gPgkkVq3jzhGPzK3vFYET+rhULKJ5e0Fp+JMaHHlwXk=;
 b=ffbSuDT4lJ7MYatfzhwu0WEmw0l3QTQF8z2U5FGQgXNnx1dLoqGb/DC+S5TxAYVcbGeq3jEmpF9xG+Kp/DE5CqotERWS3J++LVV16f2Fj9Tym0Ece61761531EGWpoWS1uyPfLeLOnWxAgqAWTVSQ6U0NE3adiLAhcfXrCxkqjNoInkA6Kvt35PYJIQiohtG3b1U6KNlhMXqLpr+ZOauqSI6JqejO+/rjN5y6w+tu1Uz2CcPJK51uHaJpsHAmyszDwE508dkCYzK9ZhU/UH8oz9LzABs+zDn2OaJqFN6cx7RlIld5Gg+I2aHqSRZJFMEj/2pq4EC1CYoTGbm3v6gYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gPgkkVq3jzhGPzK3vFYET+rhULKJ5e0Fp+JMaHHlwXk=;
 b=Ulyy+/odbrQ5n+fTBLLIhzw+GIso9i34NCn2++zW+oSLk8uxgY5J4Lsw61vZTJg+t0Ysa7kdlD1TlESt4d4I4+FXjBdNzAjUdHwnIdZFgkkpzJ3UeFIkajMMyXrDFLrt/dtNJYOjm4cvzrdm2zucZYliPb+kxoJCERMV4zUnu54=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 05/12] Arm: GICv3: Emulate GICR_PENDBASER and GICR_PROPBASER on AArch32
Date: Fri, 21 Oct 2022 16:31:21 +0100
Message-ID: <20221021153128.44226-6-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT004:EE_|DM4PR12MB5343:EE_
X-MS-Office365-Filtering-Correlation-Id: 0df10cb3-4e2d-421b-79bb-08dab3796c6e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	l9GOfyapDhb4HMYPkXnT60+LCACh8lYXr2DoeXX57VFfW1/K18LQVYcyDu2Q/zBG3cG/azTDXpXcpcMxTgmDMQVLtgFTMi47Icndmev5W106/5N5u7+c6GwRuBSCbZkcmMACR17WuN8irt/QqKQJtdgDkP4zu02HjV86WSGPQFCL76RnFzIdyts58q3hxFu3IIzU/WF8pJPuoW/u3s6Tn8aJdH1bMp6ZdaOMvzj6jZEvQ2l1Oyw+ChCYlsfFvcjkMStIBehX30/XxwcIw7U3FRz25nu3lqMEG18Q2wgzgK8cxEw58bD4MnApS66iJt7zvTMUggr0cerpEJxNXso63TdrwcH+rDjqdPR+CzJmBQs24luNrddOMoQecNEFZ1S6IoAEClVpVMrJNRWSi17LMtwv26zu2qVjkNSRpfud6AkCEidjMTnQ+v7ohHTWfC0GQrbWIQ5pSVRud7OHOPymlT03v6s0CBomzl5oSf0G09P0B8bEHXlzi5F4Q/tVkd+bPlh/RRn35uaPaJIhd3KA6dsRlvvM2zA1WWn6o4PLA2uErOC4msSeYxNDzC3hrMLR/I8RQVLR11VWXghOhEodT9fhb944p2qcIfEihffAA1T7oUvWaO7bGxlSszez6Fy6f4xxb9kH/yS7C5oxNyeIkad/njt9Uvf81P7K8eHbwPeKEdrzL8lkEsCLt/Ba6+k18YpzQv+ddJLWiBdLtuZ/IqJoxg+8mEs0ZgiT6dnMi+oA77hL0/i5ruNzSHDAH3WzkRelGcmaREb1M9P92oVLArqW5+hVPLaWAe0g1mG3vmd5tnT8kE7vcKPbtQNu13FS
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(41300700001)(2906002)(356005)(47076005)(186003)(83380400001)(26005)(2616005)(81166007)(82740400003)(5660300002)(426003)(1076003)(8936002)(82310400005)(8676002)(40460700003)(40480700001)(336012)(478600001)(70586007)(6666004)(4326008)(54906003)(70206006)(316002)(36756003)(6916009)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:11.7628
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0df10cb3-4e2d-421b-79bb-08dab3796c6e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT004.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5343

'unsigned long long' is defined as 64 bit across both aarch32 and aarch64.
So, use 'ULL' for 64 bit word instead of UL which is 32 bits for aarch32.
GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/include/asm/gic_v3_defs.h | 16 ++++++++--------
 xen/arch/arm/vgic-v3.c                 |  6 ++++--
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 728e28d5e5..48a1bc401e 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -134,15 +134,15 @@
 
 #define GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT         56
 #define GICR_PROPBASER_OUTER_CACHEABILITY_MASK               \
-        (7UL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT)
+        (7ULL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT)
 #define GICR_PROPBASER_SHAREABILITY_SHIFT               10
 #define GICR_PROPBASER_SHAREABILITY_MASK                     \
-        (3UL << GICR_PROPBASER_SHAREABILITY_SHIFT)
+        (3ULL << GICR_PROPBASER_SHAREABILITY_SHIFT)
 #define GICR_PROPBASER_INNER_CACHEABILITY_SHIFT         7
 #define GICR_PROPBASER_INNER_CACHEABILITY_MASK               \
-        (7UL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT)
+        (7ULL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT)
 #define GICR_PROPBASER_RES0_MASK                             \
-        (GENMASK(63, 59) | GENMASK(55, 52) | GENMASK(6, 5))
+        (GENMASK_ULL(63, 59) | GENMASK_ULL(55, 52) | GENMASK_ULL(6, 5))
 
 #define GICR_PENDBASER_SHAREABILITY_SHIFT               10
 #define GICR_PENDBASER_INNER_CACHEABILITY_SHIFT         7
@@ -152,11 +152,11 @@
 #define GICR_PENDBASER_INNER_CACHEABILITY_MASK               \
 	(7UL << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT)
 #define GICR_PENDBASER_OUTER_CACHEABILITY_MASK               \
-        (7UL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT)
-#define GICR_PENDBASER_PTZ                              BIT(62, UL)
+        (7ULL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT)
+#define GICR_PENDBASER_PTZ                              BIT(62, ULL)
 #define GICR_PENDBASER_RES0_MASK                             \
-        (BIT(63, UL) | GENMASK(61, 59) | GENMASK(55, 52) |  \
-         GENMASK(15, 12) | GENMASK(6, 0))
+        (BIT(63, ULL) | GENMASK_ULL(61, 59) | GENMASK_ULL(55, 52) |  \
+         GENMASK_ULL(15, 12) | GENMASK_ULL(6, 0))
 
 #define DEFAULT_PMR_VALUE            0xff
 
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index d86b41a39f..9f31360f56 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -254,14 +254,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VREG64(GICR_PENDBASER):
     {
         unsigned long flags;
+        uint64_t value;
 
         if ( !v->domain->arch.vgic.has_its )
             goto read_as_zero_64;
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
 
         spin_lock_irqsave(&v->arch.vgic.lock, flags);
-        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
-        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
+        value = v->arch.vgic.rdist_pendbase;
+        value &= ~GICR_PENDBASER_PTZ;    /* WO, reads as 0 */
+        *r = vreg_reg64_extract(value, info);
         spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
         return 1;
     }
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427743.677148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0S-00029k-Jn; Fri, 21 Oct 2022 15:32:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427743.677148; Fri, 21 Oct 2022 15:32:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0S-00029b-F3; Fri, 21 Oct 2022 15:32:20 +0000
Received: by outflank-mailman (input) for mailman id 427743;
 Fri, 21 Oct 2022 15:32:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0R-0000nK-2V
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:19 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b8a4905-5155-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 17:32:18 +0200 (CEST)
Received: from DM6PR13CA0027.namprd13.prod.outlook.com (2603:10b6:5:bc::40) by
 CY5PR12MB6180.namprd12.prod.outlook.com (2603:10b6:930:23::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.21; Fri, 21 Oct 2022 15:32:15 +0000
Received: from CY4PEPF0000B8EF.namprd05.prod.outlook.com
 (2603:10b6:5:bc:cafe::1c) by DM6PR13CA0027.outlook.office365.com
 (2603:10b6:5:bc::40) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:15 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EF.mail.protection.outlook.com (10.167.241.11) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 15:32:14 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:13 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:12 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b8a4905-5155-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n9UYVDfYKLN7hUjEzZdFXyB5fc48PmkoSwhgjhT3vz05q8JOvXGAsEseA7c3xJbcl481KHAj+YTLCRj7lOakU7oGCWeZz9jsgz6kRPI349iWq20oQ+NctiIbMKE6dihza3v444V8CkHTr7GXtrE80CQlY+Ej3gJDQvzg7OawlpkVtPjhZ7P6HLyKNsxKoGb1Z10tH4u54wWzipmfT9A9YW7D/Qwy2PwjZvjtpJS/0qJ5MuuAnyieIlk89WlnPOnYLZPxilJ7liwswzfXIr8fds89ehr8hE29EXzj4DXgSodc/YYhE9ubTB+UqvWN3QC8nFfbrRlORFTlYiw01AVEvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qLgWVOt1DQu03UMiS7oEpaPHJ6p9hu7nypVok0V2YKI=;
 b=lWnw82peHetD5cfrEB8KlJaRMnQjUv8TTLPe7HxWmVIsY7IF0vbrFy7x4bR3O5Ik02R0lBLlcRMjXM2ILdGPO10JTQqmDzqzu/VqMQMvNnijZemcY3rHxD+njLIhf7PAdQlzuX7nDxP1/1mBtXnUuAIEcJphtA7qff/tCVWy+m/u4q8W3VScdgIUXwNFsz5FuBFtL7N1rn2D/K8tOW3PR9tF+EhM6y5UubLA3yFq24w8iyvgrlst9b9U3IRx8jOwioC4iH68TcXuILkjNOKXh3Qk3WVgTu+HZCui+zOLADLieOj4Fx/s/5my3BeeO7ohWCZdmRCIR924V7mTQEOpdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qLgWVOt1DQu03UMiS7oEpaPHJ6p9hu7nypVok0V2YKI=;
 b=CqaEY6X15ctal43GnekMmBOuPCw/Zq1DAGH0wIqoQs6LvRocH3YdiPcJCVajo5uw/cOWFxECRlsLoc4ps5Pq8jXOAuymG0jaz/9lFL7OlhhhecleuZ9ZcCui42HG9kXVVaUOGWdFm56ZBb9sLz0XQ3vTy6iX5hqm6OnaCGGKTbc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 06/12] Arm: GICv3: Emulate of ICC_SGI1R on AArch32
Date: Fri, 21 Oct 2022 16:31:22 +0100
Message-ID: <20221021153128.44226-7-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EF:EE_|CY5PR12MB6180:EE_
X-MS-Office365-Filtering-Correlation-Id: d8b442ed-71db-4171-2304-08dab3796e26
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	459vLuwI9rmjAhrpJ7NdCx/Z+zqYT1q+tAqLpmwWg1eNWNBENpOW8oF007w2TbqUdHEtgPAqmibqnrNO8SlLelC4ln/K7mnO31o5B8ZjcxpIvhaxG7UeoKRXWBrRUhjneDyG9V4nN2NKl+E/e9I/Grbnuts/64styNr/OsKmh2M/yYbxLKFASSRGoSlI/1lldHTaVXzOQXcY2OT0/XNJ6JHkB+fhWDolQdrY3VUs1urydq542ZLOYj7U/I/q+jfw4cjhbrfQtz3yY/6/7gj2EIpCmaQsDtJf8lOUYi20FmIzLXXM9jzXvR3hFdfDKsxJ2sXayfM5GgTBJJqcYDytiGb+jcuFawG/oqHkrgiUExV9GA640oYeA97kfNRE00UdwGkoSTZSbXA3RlJH/4w4ylwe3i0ciGYuTeEeKunobzFtauYOXiDaNtYKoabDEcNGosPy7A6cTfYyf75OqpCecXGZLuUYVXI7yaU4MN81k9PXdSuiM1F/eFK//jfagUNlMNday/PYClsNrBYd2KAmfQ4z9TeXJ0m98KDcvmOWI84OeZ6uMOFuQNzaE5SlhhLjt9HfTh77gVhQvgsIG2JHNBy0YO+kE1D+vz4enmRLQWr9FNe5023YjLGHgzAibCkdSv3Zg0E46dYOx1VNmSd+oK2bJpKrCOrZolqtDqcN/wi1wFLE4qz3AOFNwLl6A5JGf+sPVrMlsLLkDwDW/YSjLuEYjhDQ1Q1k2ZROIYNJpKpQI/D67ovE7VexsjDk9HlAOecTuYLCOhVA5mTZ64/N0p5ftRHYaoP1o4ijMk7gslg=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(6916009)(54906003)(70586007)(83380400001)(5660300002)(8676002)(4326008)(2616005)(70206006)(4744005)(1076003)(186003)(40460700003)(26005)(41300700001)(36756003)(8936002)(316002)(336012)(6666004)(2906002)(47076005)(426003)(40480700001)(82310400005)(81166007)(82740400003)(356005)(36860700001)(478600001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:14.5660
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d8b442ed-71db-4171-2304-08dab3796e26
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EF.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6180

Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on
Aarch32 systems. Thus, the prototype needs to change to reflect this.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/vgic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 9f31360f56..48e8ef95d2 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1482,7 +1482,7 @@ write_reserved:
     return 1;
 }
 
-static bool vgic_v3_to_sgi(struct vcpu *v, register_t sgir)
+static bool vgic_v3_to_sgi(struct vcpu *v, uint64_t sgir)
 {
     int virq;
     int irqmode;
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427747.677159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0Z-0002k6-WE; Fri, 21 Oct 2022 15:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427747.677159; Fri, 21 Oct 2022 15:32:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0Z-0002jp-Pk; Fri, 21 Oct 2022 15:32:27 +0000
Received: by outflank-mailman (input) for mailman id 427747;
 Fri, 21 Oct 2022 15:32:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0Y-0000AU-4R
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:26 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on2063.outbound.protection.outlook.com [40.107.212.63])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f59fa01-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:24 +0200 (CEST)
Received: from DS7PR06CA0034.namprd06.prod.outlook.com (2603:10b6:8:54::18) by
 CH2PR12MB5514.namprd12.prod.outlook.com (2603:10b6:610:62::9) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.35; Fri, 21 Oct 2022 15:32:21 +0000
Received: from CY4PEPF0000B8EA.namprd05.prod.outlook.com
 (2603:10b6:8:54:cafe::2a) by DS7PR06CA0034.outlook.office365.com
 (2603:10b6:8:54::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:21 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EA.mail.protection.outlook.com (10.167.241.6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 15:32:20 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:17 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:16 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f59fa01-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l2gv/0G4+wuOp1E0CdQnkSG9yYNdonBA7eGT+0sPg1p7s7LY2iAiox5aGvF9gIx2fqe216wdanN9SfdLcpMfUIDtJRem+qiUse/5CJ7tQ4wNV1zE3G2Jg0jirbGt3MfcLxZwv16/fUWw/wiRmvut+lY0FjHHeuRojAMlgKwY6tCZLK6QmuTKU6QyITRecYnRWo9ldDbgMrKlcNIBBENnqVoK9QbUKhTOsOtlrTibRxA+5qAkRJuJZFdBlBvjQ7DXzBw3mst+Ji41az1E3HJGn3EWpoy9XCiB/IUkZu9ZJ3INjxzZDUWVrTPSqDvdmukvOkpGOLOcrLLHE4egUNqNMA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tmDx4afjf7Hk3KdCSZeZ9Tvo7rmO4RVpxVthRWoG+NA=;
 b=dT5xvxLzwuin0Rqh4maljLRQ1bV6Hx9kiSbUVQ8b90FYiPoQsefRnKALwiAFllgVCczZFPqlSdWHAPNQAc1xnuGYp6qtBEsC1HR6KrPCvkVSQt5uaKRb5udTE+arnbnjVfRDuQOQTpksKlYlS8TljOwfyPiFHPjemDHZalEpHXqCnHGoOg9+lM5tUY0BJdtkThlkbI2nbbOCWjYGeUjZ4wjnjaFBa45LKIep/yVWfxtDxZwQ9sAAg7UZdLTEIJdXT2alTM+Zaa+88knwjcagR9LkBz6XvgJVucScyye4so9SGDzqJDBJ7YQVeLHa8/pqiq7FHVaZ/mH5nYRRNYGZ/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tmDx4afjf7Hk3KdCSZeZ9Tvo7rmO4RVpxVthRWoG+NA=;
 b=YxqWZlkByLXfOZqz/gaRBgS0MJldkNvzfoX7L/sNCkJC1nmZTw4reb1568LFstDNYJ6XPAsP9C1hI+QDgLBgNEEE71JZGznygDDYSPAGqgJmLrsMe+BsOQ1rS1idzAq9N3gqVCZTOcqjhwG6L0pw03/rfdGCI5I7yeoQFupze94=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 07/12] Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
Date: Fri, 21 Oct 2022 16:31:23 +0100
Message-ID: <20221021153128.44226-8-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EA:EE_|CH2PR12MB5514:EE_
X-MS-Office365-Filtering-Correlation-Id: 656ac450-729b-4212-7b4b-08dab37971b7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lTbYthDK2Ef/Y/g+gf0RLANT9h8Ixr1enPSqD/KxR9WOM540/f1ytOjBVhXbb67b6e9CeUwUKXtgLrNTzhDks6ZDshg94U0w32g8ARCPqyd4PKLXFRwiSp7F44csWxcoIEhYqR/YJon9JB7SzuVJm+nICVw+5g+nDvidmV1p0bNzOcQpNO5doHoyoHO18pVSltOXzTpwTIWff/L76RxVoSDrlsKv4RfwbDjIs/nfpAuiMlArmPJBOmEZM1IbGTsK+uv6LMZqp55u9PXSacFCKXVkcSHkJzKREr2abfBmZ1WYHWz5vBRL0qHvMLCQl3z78javsiYDmD21FMIKBUp0SRCFnV2P4yyuMlxhQ1uJK0H0ciJgkwTotai6qgML/RwOOImPWxC3vSCACl3sEWNOZBnJNQQJgJ3BfSrDywd0Mmuxj6CE7dXpISwFHURGONiIoXzwAS+USk24be3dEuH414XvjO/8dtuWgDq/igqwPGEkWkNKW/KHCIt5oK/XT74mfkxTcn23Q1E6PYkCEsD53kgbsmNKJrfbVJZnfijXkyzclq6tAy91d/XRVbiFxbdHuLDYKnYj7VpWgQoV80aT77UwB9MmmlbIshPZFugHXaLqjBruY7B9d7DZX9inqHmo2OSLW2oPXFN/9M8AFf0XMYHZSmdd5VV/g8YG5o2jRQdBuKljNc4BeXcQ826aunQBc1ljq9qZxQZ3L85aHDR483D1DqIGKQIde1yY1KQzuDfyQM83uxyzL3Z8RqCwbVq+jl6mE5OVy2R+jHxiMzdH8gLSdUjiMVBVSXZBsx8RaxA=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(1076003)(478600001)(186003)(2616005)(2906002)(36860700001)(8676002)(26005)(41300700001)(316002)(6916009)(40480700001)(70586007)(40460700003)(6666004)(36756003)(4326008)(81166007)(82740400003)(5660300002)(82310400005)(54906003)(30864003)(8936002)(356005)(70206006)(47076005)(426003)(336012)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:20.4267
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 656ac450-729b-4212-7b4b-08dab37971b7
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EA.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5514

Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers

AArch64 System register ICH_LR<n>_EL2 bits [31:0] are architecturally
mapped to AArch32 System register ICH_LR<n>[31:0].
AArch64 System register ICH_LR<n>_EL2 bits [63:32] are architecturally
mapped to AArch32 System register ICH_LRC<n>[31:0].

Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for Aarch32.
For AArch32, the link register is stored as :-
(((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2

Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and
AArch64.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/gic-v3.c                    | 132 +++++++++++------------
 xen/arch/arm/include/asm/arm32/sysregs.h |  52 +++++++++
 xen/arch/arm/include/asm/arm64/sysregs.h |   7 +-
 xen/arch/arm/include/asm/gic_v3_defs.h   |   6 +-
 4 files changed, 126 insertions(+), 71 deletions(-)

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 018fa0dfa0..8b4b168e78 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v)
     switch ( gicv3_info.nr_lrs )
     {
     case 16:
-        v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2);
+        v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15);
     case 15:
-        v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2);
+        v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14);
     case 14:
-        v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2);
+        v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13);
     case 13:
-        v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2);
+        v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12);
     case 12:
-        v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2);
+        v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11);
     case 11:
-        v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2);
+        v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10);
     case 10:
-        v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2);
+        v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9);
     case 9:
-        v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2);
+        v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8);
     case 8:
-        v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2);
+        v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7);
     case 7:
-        v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2);
+        v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6);
     case 6:
-        v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2);
+        v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5);
     case 5:
-        v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2);
+        v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4);
     case 4:
-        v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2);
+        v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3);
     case 3:
-        v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2);
+        v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2);
     case 2:
-        v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2);
+        v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1);
     case 1:
-         v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2);
+         v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0);
          break;
     default:
          BUG();
@@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v)
     switch ( gicv3_info.nr_lrs )
     {
     case 16:
-        WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2);
+        WRITE_SYSREG_LR(15, v->arch.gic.v3.lr[15]);
     case 15:
-        WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2);
+        WRITE_SYSREG_LR(14, v->arch.gic.v3.lr[14]);
     case 14:
-        WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2);
+        WRITE_SYSREG_LR(13, v->arch.gic.v3.lr[13]);
     case 13:
-        WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2);
+        WRITE_SYSREG_LR(12, v->arch.gic.v3.lr[12]);
     case 12:
-        WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2);
+        WRITE_SYSREG_LR(11, v->arch.gic.v3.lr[11]);
     case 11:
-        WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2);
+        WRITE_SYSREG_LR(10, v->arch.gic.v3.lr[10]);
     case 10:
-        WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2);
+        WRITE_SYSREG_LR(9, v->arch.gic.v3.lr[9]);
     case 9:
-        WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2);
+        WRITE_SYSREG_LR(8, v->arch.gic.v3.lr[8]);
     case 8:
-        WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2);
+        WRITE_SYSREG_LR(7, v->arch.gic.v3.lr[7]);
     case 7:
-        WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2);
+        WRITE_SYSREG_LR(6, v->arch.gic.v3.lr[6]);
     case 6:
-        WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2);
+        WRITE_SYSREG_LR(5, v->arch.gic.v3.lr[5]);
     case 5:
-        WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2);
+        WRITE_SYSREG_LR(4, v->arch.gic.v3.lr[4]);
     case 4:
-        WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2);
+        WRITE_SYSREG_LR(3, v->arch.gic.v3.lr[3]);
     case 3:
-        WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2);
+        WRITE_SYSREG_LR(2, v->arch.gic.v3.lr[2]);
     case 2:
-        WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2);
+        WRITE_SYSREG_LR(1, v->arch.gic.v3.lr[1]);
     case 1:
-        WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2);
+        WRITE_SYSREG_LR(0, v->arch.gic.v3.lr[0]);
         break;
     default:
          BUG();
@@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr)
 {
     switch ( lr )
     {
-    case 0: return READ_SYSREG(ICH_LR0_EL2);
-    case 1: return READ_SYSREG(ICH_LR1_EL2);
-    case 2: return READ_SYSREG(ICH_LR2_EL2);
-    case 3: return READ_SYSREG(ICH_LR3_EL2);
-    case 4: return READ_SYSREG(ICH_LR4_EL2);
-    case 5: return READ_SYSREG(ICH_LR5_EL2);
-    case 6: return READ_SYSREG(ICH_LR6_EL2);
-    case 7: return READ_SYSREG(ICH_LR7_EL2);
-    case 8: return READ_SYSREG(ICH_LR8_EL2);
-    case 9: return READ_SYSREG(ICH_LR9_EL2);
-    case 10: return READ_SYSREG(ICH_LR10_EL2);
-    case 11: return READ_SYSREG(ICH_LR11_EL2);
-    case 12: return READ_SYSREG(ICH_LR12_EL2);
-    case 13: return READ_SYSREG(ICH_LR13_EL2);
-    case 14: return READ_SYSREG(ICH_LR14_EL2);
-    case 15: return READ_SYSREG(ICH_LR15_EL2);
+    case 0: return READ_SYSREG_LR(0);
+    case 1: return READ_SYSREG_LR(1);
+    case 2: return READ_SYSREG_LR(2);
+    case 3: return READ_SYSREG_LR(3);
+    case 4: return READ_SYSREG_LR(4);
+    case 5: return READ_SYSREG_LR(5);
+    case 6: return READ_SYSREG_LR(6);
+    case 7: return READ_SYSREG_LR(7);
+    case 8: return READ_SYSREG_LR(8);
+    case 9: return READ_SYSREG_LR(9);
+    case 10: return READ_SYSREG_LR(10);
+    case 11: return READ_SYSREG_LR(11);
+    case 12: return READ_SYSREG_LR(12);
+    case 13: return READ_SYSREG_LR(13);
+    case 14: return READ_SYSREG_LR(14);
+    case 15: return READ_SYSREG_LR(15);
     default:
         BUG();
     }
@@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val)
     switch ( lr )
     {
     case 0:
-        WRITE_SYSREG(val, ICH_LR0_EL2);
+        WRITE_SYSREG_LR(0, val);
         break;
     case 1:
-        WRITE_SYSREG(val, ICH_LR1_EL2);
+        WRITE_SYSREG_LR(1, val);
         break;
     case 2:
-        WRITE_SYSREG(val, ICH_LR2_EL2);
+        WRITE_SYSREG_LR(2, val);
         break;
     case 3:
-        WRITE_SYSREG(val, ICH_LR3_EL2);
+        WRITE_SYSREG_LR(3, val);
         break;
     case 4:
-        WRITE_SYSREG(val, ICH_LR4_EL2);
+        WRITE_SYSREG_LR(4, val);
         break;
     case 5:
-        WRITE_SYSREG(val, ICH_LR5_EL2);
+        WRITE_SYSREG_LR(5, val);
         break;
     case 6:
-        WRITE_SYSREG(val, ICH_LR6_EL2);
+        WRITE_SYSREG_LR(6, val);
         break;
     case 7:
-        WRITE_SYSREG(val, ICH_LR7_EL2);
+        WRITE_SYSREG_LR(7, val);
         break;
     case 8:
-        WRITE_SYSREG(val, ICH_LR8_EL2);
+        WRITE_SYSREG_LR(8, val);
         break;
     case 9:
-        WRITE_SYSREG(val, ICH_LR9_EL2);
+        WRITE_SYSREG_LR(9, val);
         break;
     case 10:
-        WRITE_SYSREG(val, ICH_LR10_EL2);
+        WRITE_SYSREG_LR(10, val);
         break;
     case 11:
-        WRITE_SYSREG(val, ICH_LR11_EL2);
+        WRITE_SYSREG_LR(11, val);
         break;
     case 12:
-        WRITE_SYSREG(val, ICH_LR12_EL2);
+        WRITE_SYSREG_LR(12, val);
         break;
     case 13:
-        WRITE_SYSREG(val, ICH_LR13_EL2);
+        WRITE_SYSREG_LR(13, val);
         break;
     case 14:
-        WRITE_SYSREG(val, ICH_LR14_EL2);
+        WRITE_SYSREG_LR(14, val);
         break;
     case 15:
-        WRITE_SYSREG(val, ICH_LR15_EL2);
+        WRITE_SYSREG_LR(15, val);
         break;
     default:
         return;
@@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v)
     if ( v == current )
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i));
+            printk("   HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i));
     }
     else
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]);
+            printk("   VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]);
     }
 }
 
diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
index 6841d5de43..f3b4dfbca8 100644
--- a/xen/arch/arm/include/asm/arm32/sysregs.h
+++ b/xen/arch/arm/include/asm/arm32/sysregs.h
@@ -62,9 +62,61 @@
 #define READ_SYSREG(R...)       READ_SYSREG32(R)
 #define WRITE_SYSREG(V, R...)   WRITE_SYSREG32(V, R)
 
+#define ICH_LR_REG(INDEX)        ICH_LR ## INDEX ## _EL2
+#define ICH_LRC_REG(INDEX)       ICH_LRC ## INDEX ## _EL2
+
+#define READ_SYSREG_LR(INDEX)    ((((uint64_t) \
+                                 (READ_SYSREG(ICH_LRC_REG(INDEX)))) << 32) | \
+                                 (READ_SYSREG(ICH_LR_REG(INDEX))))
+
+#define WRITE_SYSREG_LR(INDEX, V) WRITE_SYSREG \
+                                  (V&0xFFFFFFFF, ICH_LR_REG(INDEX)); \
+                                  WRITE_SYSREG(V>>32, ICH_LRC_REG(INDEX));
+
 /* MVFR2 is not defined on ARMv7 */
 #define MVFR2_MAYBE_UNDEFINED
 
+#define ___CP32(a,b,c,d,e)   a,b,c,d,e
+#define __LR0_EL2(x)              ___CP32(p15,4,c12,c12,x)
+#define __LR8_EL2(x)              ___CP32(p15,4,c12,c13,x)
+
+#define __LRC0_EL2(x)             ___CP32(p15,4,c12,c14,x)
+#define __LRC8_EL2(x)             ___CP32(p15,4,c12,c15,x)
+
+#define ICH_LR0_EL2               __LR0_EL2(0)
+#define ICH_LR1_EL2               __LR0_EL2(1)
+#define ICH_LR2_EL2               __LR0_EL2(2)
+#define ICH_LR3_EL2               __LR0_EL2(3)
+#define ICH_LR4_EL2               __LR0_EL2(4)
+#define ICH_LR5_EL2               __LR0_EL2(5)
+#define ICH_LR6_EL2               __LR0_EL2(6)
+#define ICH_LR7_EL2               __LR0_EL2(7)
+#define ICH_LR8_EL2               __LR8_EL2(0)
+#define ICH_LR9_EL2               __LR8_EL2(1)
+#define ICH_LR10_EL2              __LR8_EL2(2)
+#define ICH_LR11_EL2              __LR8_EL2(3)
+#define ICH_LR12_EL2              __LR8_EL2(4)
+#define ICH_LR13_EL2              __LR8_EL2(5)
+#define ICH_LR14_EL2              __LR8_EL2(6)
+#define ICH_LR15_EL2              __LR8_EL2(7)
+
+#define ICH_LRC0_EL2               __LRC0_EL2(0)
+#define ICH_LRC1_EL2               __LRC0_EL2(1)
+#define ICH_LRC2_EL2               __LRC0_EL2(2)
+#define ICH_LRC3_EL2               __LRC0_EL2(3)
+#define ICH_LRC4_EL2               __LRC0_EL2(4)
+#define ICH_LRC5_EL2               __LRC0_EL2(5)
+#define ICH_LRC6_EL2               __LRC0_EL2(6)
+#define ICH_LRC7_EL2               __LRC0_EL2(7)
+#define ICH_LRC8_EL2               __LRC8_EL2(0)
+#define ICH_LRC9_EL2               __LRC8_EL2(1)
+#define ICH_LRC10_EL2              __LRC8_EL2(2)
+#define ICH_LRC11_EL2              __LRC8_EL2(3)
+#define ICH_LRC12_EL2              __LRC8_EL2(4)
+#define ICH_LRC13_EL2              __LRC8_EL2(5)
+#define ICH_LRC14_EL2              __LRC8_EL2(6)
+#define ICH_LRC15_EL2              __LRC8_EL2(7)
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* __ASM_ARM_ARM32_SYSREGS_H */
diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h
index 54670084c3..d45fe815f9 100644
--- a/xen/arch/arm/include/asm/arm64/sysregs.h
+++ b/xen/arch/arm/include/asm/arm64/sysregs.h
@@ -469,8 +469,11 @@
     asm volatile("mrs  %0, "__stringify(name) : "=r" (_r));         \
     _r; })
 
-#define READ_SYSREG(name)     READ_SYSREG64(name)
-#define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name)
+#define READ_SYSREG(name)          READ_SYSREG64(name)
+#define WRITE_SYSREG(v, name)      WRITE_SYSREG64(v, name)
+#define ICH_LR_REG(index)          ICH_LR ## index ## _EL2
+#define WRITE_SYSREG_LR(index, v)  WRITE_SYSREG(v, ICH_LR_REG(index))
+#define READ_SYSREG_LR(index)      READ_SYSREG(ICH_LR_REG(index))
 
 #endif /* _ASM_ARM_ARM64_SYSREGS_H */
 
diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 48a1bc401e..87115f8b25 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -185,9 +185,9 @@
 #define ICH_LR_HW_SHIFT              61
 #define ICH_LR_GRP_MASK              0x1
 #define ICH_LR_GRP_SHIFT             60
-#define ICH_LR_MAINTENANCE_IRQ       (1UL<<41)
-#define ICH_LR_GRP1                  (1UL<<60)
-#define ICH_LR_HW                    (1UL<<61)
+#define ICH_LR_MAINTENANCE_IRQ       (1ULL<<41)
+#define ICH_LR_GRP1                  (1ULL<<60)
+#define ICH_LR_HW                    (1ULL<<61)
 
 #define ICH_VTR_NRLRGS               0x3f
 #define ICH_VTR_PRIBITS_MASK         0x7
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427751.677171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0j-0003Qc-CM; Fri, 21 Oct 2022 15:32:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427751.677171; Fri, 21 Oct 2022 15:32:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0j-0003QV-7E; Fri, 21 Oct 2022 15:32:37 +0000
Received: by outflank-mailman (input) for mailman id 427751;
 Fri, 21 Oct 2022 15:32:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0h-0000nK-VA
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:36 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2048.outbound.protection.outlook.com [40.107.95.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95743862-5155-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 17:32:35 +0200 (CEST)
Received: from BN0PR04CA0068.namprd04.prod.outlook.com (2603:10b6:408:ea::13)
 by MN0PR12MB6320.namprd12.prod.outlook.com (2603:10b6:208:3d3::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 15:32:29 +0000
Received: from BN8NAM11FT116.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ea:cafe::9c) by BN0PR04CA0068.outlook.office365.com
 (2603:10b6:408:ea::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:29 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT116.mail.protection.outlook.com (10.13.176.67) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:29 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:28 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:32:28 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:26 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95743862-5155-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LCflJa5RW1stIJ0XSN8idXlezFaQPTLTbOH7NT15NMDytCmKGs8DtLAdAs4S0PURoUqsukvr9Nx/HZD/6NP0EdlMRheV7o/DLLxOBhTZ0bgN9uFd3IxybBCDYYNFizqWZf6OQJmUocSXXOXVYAzFZqftGGz6vUrWdRY2HC0kYZwmndfQt4OKb4Zpscf22XX6BULfWW4iuLnJIhNWwrVHZOaG6YJ2m1CBFPEtZQ4B2leO0MdkBtIrR5tAmUsoDOGFZohG7GB3AN6PA3X4VgcdzucpmBJuwt+eSK+qN5CggxqUozamt9U2X9FTrZRNd7oGzYhM8/eRG5lv4yMPU9m2UQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MJFsGpb2ciX52+9uagvBqLQ7Orc8YQkpkj/yfzPJyKs=;
 b=f/qWUsSYDcJH96/mad++MnZpYnVwnhqJRs5wTvQyrkQSdJLQRg+ryTSQ36tcPgxcYHkTd/3j31dGLyRIpn1Ys7wbPlyM7zNpgXsiDmYdHTaL4pO6JpMg/otukL6H1x+NGiS0mcQrTI+wOeMOWCA7hbO+zqQ+orXZ/DVveH9h6m+FzZjS/5sgmzKwLX9pa540lZh8SBSTTjFZiJklbwusHyugtTsgs3JCR/OT8boopvug7Vfgsf5R0jB3iXWVmLzlFhQy5n4rFQyX1YfLM01Q3JMJMnkPYrYMo6KvHFnD4fXmwx3AFAa+RmCL3yu87baHn9+D4G7cQZPJxbkbZAW6FQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MJFsGpb2ciX52+9uagvBqLQ7Orc8YQkpkj/yfzPJyKs=;
 b=KTgZX2N+k7IHrQYl1x29gzhOkfvMojwk8o60kPYgjbCIheWurgSpklDkErPhPmEGFBoo0iIipfCLD2kUn8VdESLgrKd0VmFACtgBFxqJHVFpb4N95YT11U1Phy0RTFTWIASStXK4S3kQ52SZlS1AAdTykjI/8Bxsu0F7leht8Ds=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 09/12] Arm: GICv3: Define GIC registers for AArch32
Date: Fri, 21 Oct 2022 16:31:25 +0100
Message-ID: <20221021153128.44226-10-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT116:EE_|MN0PR12MB6320:EE_
X-MS-Office365-Filtering-Correlation-Id: bae72055-30f9-40eb-2721-08dab37976d0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SrPB+O+VX9a7l+kIZegZ2CrKSovbvs5vQk6h4soiDC95vnGM9OGLDpt4uGZcGT1V4qXNEBcsNWE++NaUq01sj3Ms9XYzs7Mr1VQDJhBCyLmrv+Ru6K4znVvH3sqpcyUWZODaxdEpBn2BJezDil+KpN2ZDG2xOqjWI5cMWK7HDaGdaTr9OPa7hyuM59qfAzMlzq7hVKWYK6nf2JB9yD1nMZeUuzJmvLe/xUkELYdMdvMVisHO3rfLkGrHKknUjHOd4u34DndP+UyyZJMbwSLKWRDYhV15PCXgMhMRK5Gq+ffau4feRsINCuJyeDeds6zGbS/U/sH679EPc8o1SCCcO/nwPnwetRFpaUQas489Yfppx9SZHI7jHMABpFzivyvJuiBVsyXp13tnpHFt3o8Br3yKcVa6xDrZvBbnq9vz6glljR8tqzRRU4sPLLXLtmVRZDZkja3iYQp1ErITMvNStfDKmf8h3xNoOKyG+rqoaFtTvBmrdTA5CKoqjHIYAH45tdhRuf33PVg8bcf/ZXQrZLA08K078kfVszjoO+/2V5ATfeFGdwvAGPrBea+vpMIblfcxQ6p/0uAf2nNNvTtBlvvHVJodtrPQRWPY1jnUdiod1Djngfq32GeOpQQ/Cm2qXNh1EyICe/NWeVo9aw01dZsL5NaO3eUOe5GMmAJg8RJuCg8axBPKFKyTewz/bcrRdRMIHbZI1jl6EVhtBS09HAQklwZ9rO0TN8CTvg1daohuWV/4zE0qolQxE1HTTo1MBtFQgwtSarv28L/87Hi1Uf+8RJpPfmExB8elIE4roK1TBwKxErsA3idRy47CTgHv
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(478600001)(41300700001)(316002)(4326008)(54906003)(8936002)(6916009)(8676002)(70206006)(70586007)(36860700001)(47076005)(40480700001)(356005)(81166007)(186003)(82740400003)(1076003)(2616005)(40460700003)(426003)(26005)(82310400005)(83380400001)(336012)(36756003)(2906002)(5660300002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:29.1645
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bae72055-30f9-40eb-2721-08dab37976d0
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT116.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6320

Refer "Arm IHI 0069H ID020922"
12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt
Group 1 Register
12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register
12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register
12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register
12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register
12.5.24 ICC_SRE, Interrupt Controller System Register Enable register
12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register
12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1
12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1
12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1
12.5.6 ICC_CTLR, Interrupt Controller Control Register
12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register
12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/include/asm/arm32/sysregs.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
index 693da22324..d2c5a115f9 100644
--- a/xen/arch/arm/include/asm/arm32/sysregs.h
+++ b/xen/arch/arm/include/asm/arm32/sysregs.h
@@ -129,6 +129,22 @@
 #define ICH_AP1R2_EL2             __AP1Rx_EL2(2)
 #define ICH_AP1R3_EL2             __AP1Rx_EL2(3)
 
+#define ICC_SGI1R_EL1             p15,0,c12
+
+#define ICC_SRE_EL2               p15,4,c12,c9,5
+#define ICH_VTR_EL2               p15,4,c12,c11,1
+#define ICH_HCR_EL2               p15,4,c12,c11,0
+
+#define ICC_PMR_EL1               p15,0,c4,c6,0
+#define ICC_SRE_EL1               p15,0,c12,c12,5
+#define ICC_DIR_EL1               p15,0,c12,c11,1
+#define ICC_EOIR1_EL1             p15,0,c12,c12,1
+#define ICC_IAR1_EL1              p15,0,c12,c12,0
+#define ICC_BPR1_EL1              p15,0,c12,c12,3
+#define ICC_CTLR_EL1              p15,0,c12,c12,4
+#define ICC_IGRPEN1_EL1           p15,0,c12,c12,7
+#define ICH_VMCR_EL2              p15,4,c12,c11,7
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* __ASM_ARM_ARM32_SYSREGS_H */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:32:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:32:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427753.677181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0p-00048M-L7; Fri, 21 Oct 2022 15:32:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427753.677181; Fri, 21 Oct 2022 15:32:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu0p-00048B-Gn; Fri, 21 Oct 2022 15:32:43 +0000
Received: by outflank-mailman (input) for mailman id 427753;
 Fri, 21 Oct 2022 15:32:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0o-0000nK-FH
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:42 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2050.outbound.protection.outlook.com [40.107.220.50])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99164067-5155-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 17:32:41 +0200 (CEST)
Received: from DS7PR06CA0025.namprd06.prod.outlook.com (2603:10b6:8:54::31) by
 PH7PR12MB7235.namprd12.prod.outlook.com (2603:10b6:510:206::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Fri, 21 Oct
 2022 15:32:37 +0000
Received: from CY4PEPF0000B8EA.namprd05.prod.outlook.com
 (2603:10b6:8:54:cafe::84) by DS7PR06CA0025.outlook.office365.com
 (2603:10b6:8:54::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:37 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EA.mail.protection.outlook.com (10.167.241.6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 15:32:37 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:35 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:32:35 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:34 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99164067-5155-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YGRLw49Iz2wznc96DnBagju+OSoTmzDGiZUhF6Js7xPNxrTcibG+X1ACXY2ji+5Q55kETUjVImDIhrvtUpKfJLGkXXWNLrgSoEhINMk4dSvA/FmaiooP/X8yCYKlo5c5bgkI/dh7JbrWBl96eUaxMepabOJYGZDqi4m6xiBVsgfADg5cgi7Y70/tI1pLWk4CQl9jbjQuW5s3rD6+HcQi22KN4QN07UwT3nW3bF9vdRC8XxvmyR48KCKWk5cv87+8s6TdQjb21eZLC/dcalsnNPFxeFnON21wzY0awl8MJkqQpWvIdx5XvHMqV+DHaQNTsn7ZkjRHqjLXfM+T3r9M3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ai9EcEkOkTt5okEc7oZTbCy/K+W9d1rnSC3OXLOLx8M=;
 b=dr6VRYFrR0Tk1FzqPTVSjT4iCGgOfKAb8P9XPFTMfhzlARBWRWsco+phSjOug/d+/CcPl/fsDqS8i9VsqZoAsBv1DZUg+Kgb6ODajHECZx7tzWfkTA1RBA+ZNXDy+c6KUP+nfXnGzjxTP81zQAmy4a0ShaO1stGgY96y9eWuFXaIqylZ0WlCKRwgyMj9HGNQHecUxyLNcmPc2/qRTctrC2GWzuFxDyOLNbWTzonXKBbJPD01E/PdgSu71meYKYmYxG49F4wH45tdzTABRg3nXQ1lbSxdg7gBmjYerE1YXP3CgkebZv0BniPYIy6f6nGBtQmF8I7HWnYZ73PwU2oJXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ai9EcEkOkTt5okEc7oZTbCy/K+W9d1rnSC3OXLOLx8M=;
 b=YoR6uuInlrhLxjNJA14dCBq2Tb9pnEUzPfIpuZilwIANVdRFSyIe6KFG0BVNQeQuviWaY5yHphynIneCI6RV8+FItRpxgyv4liAuCNYUNmZOAicr+Qg1PzKxj3L9cbfptUYp7CACLG6E3byx0bVE4uWZMGmbW9bmZVVwHl021zQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 11/12] Arm: GICv3: Define macros to read/write 64 bit
Date: Fri, 21 Oct 2022 16:31:27 +0100
Message-ID: <20221021153128.44226-12-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EA:EE_|PH7PR12MB7235:EE_
X-MS-Office365-Filtering-Correlation-Id: 3b8cce88-def7-4af0-afa1-08dab3797bd4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HUIINYLI1+i7t8hUz+WcQmMMKNEXfdBy3olTo7KijNvpqxtPGeZjJTs9J8Hh/bZMMBe3P/6EiY1lhfvBXYBWbPX2SrkNE1Pk31IeOH5sw+9iClEXpvxc50Ldc2PjZu78T0+ODDaGHmYP1PNWeMJii4svX1j6H6zh+XUO3/JtokKMN0B0yI7Z/dmkfHCGXB0OjMvkHSFneFw3aVBn66jveJ9AJLW5/t3lr36ZCaRCgpgRZ58cIB1W1aBoy8sboJmHwmsjEFGxO+l0Qfil/Ffi6LhDCHSNn0ULmmyk3jnHkH0ELAcflLxdvJXTG8FWZiammIuDO9aKpPGFnoELceaf1e1M3z9FxSixqTOKweoCiQrflyER9WGN7v9j08tJASdruo2uLozpyNTi2QDlTlT33nMkrxOeFC2O7JQ38/jti8O7TzHUtCR8PHF0ec//3UO35h7olLAk9YjnUOVzOHvLBgJCsI+LnIb77FXeI6vFp1OaBnqgGn8Tiu5+E61bkJP48i1Sz7Z7haFJlp4sAu2z7mJYYyxvtzo/AAumYwDKESUgw8bSeXV6lqx3yThrXXepxBPnSj03pzaxuTA2wlHyR+1U0fsm+/Qh3ZNzCwUl/Wm9q0x9CDqwZmob5BEdmCndlqnovoP0SQiLUCgxpByoaaxXuuX39uWbgK+Ymu6ad48eFjNVnCXApHCwyspxfnptdjaGCik9bctNEvHRyheH4gp/Ka3QvxtiYD1IlaM2nWm8SNk+8bBB1fGon2UkPbZ4QbXGnXajTn6tjeAB3qLzcdhu7X5zVGIEbhxlGRX7SPKuh5kCT2zvuWQG5z5WiaL0
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(8936002)(316002)(26005)(2616005)(36860700001)(5660300002)(6666004)(336012)(70586007)(4326008)(8676002)(41300700001)(70206006)(1076003)(186003)(2906002)(40480700001)(36756003)(40460700003)(82310400005)(54906003)(81166007)(426003)(6916009)(356005)(47076005)(82740400003)(478600001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:37.5203
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b8cce88-def7-4af0-afa1-08dab3797bd4
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EA.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7235

Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs.
This in turn calls readl_relaxed()/writel_relaxed() twice for the lower
and upper 32 bits.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/include/asm/arm32/io.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h
index 73a879e9fb..6a5f563fbc 100644
--- a/xen/arch/arm/include/asm/arm32/io.h
+++ b/xen/arch/arm/include/asm/arm32/io.h
@@ -80,10 +80,14 @@ static inline u32 __raw_readl(const volatile void __iomem *addr)
                                         __raw_readw(c)); __r; })
 #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \
                                         __raw_readl(c)); __r; })
+#define readq_relaxed(c) ({ u64 __r = (le64_to_cpu(readl_relaxed(c+4)) << 32) | \
+                                        readl_relaxed(c); __r; })
 
 #define writeb_relaxed(v,c)     __raw_writeb(v,c)
 #define writew_relaxed(v,c)     __raw_writew((__force u16) cpu_to_le16(v),c)
 #define writel_relaxed(v,c)     __raw_writel((__force u32) cpu_to_le32(v),c)
+#define writeq_relaxed(v,c)     writel_relaxed(((uint64_t)v&0xffffffff), c); \
+                                    writel_relaxed((((uint64_t)v)>>32), (c+4));
 
 #define readb(c)                ({ u8  __v = readb_relaxed(c); __iormb(); __v; })
 #define readw(c)                ({ u16 __v = readw_relaxed(c); __iormb(); __v; })
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:35:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:35:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427769.677191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu39-0005xE-0r; Fri, 21 Oct 2022 15:35:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427769.677191; Fri, 21 Oct 2022 15:35:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu38-0005x7-UN; Fri, 21 Oct 2022 15:35:06 +0000
Received: by outflank-mailman (input) for mailman id 427769;
 Fri, 21 Oct 2022 15:35:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0h-0000AU-BN
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:35 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2041.outbound.protection.outlook.com [40.107.223.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 94cc1aef-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:34 +0200 (CEST)
Received: from CY5PR19CA0096.namprd19.prod.outlook.com (2603:10b6:930:83::24)
 by SA3PR12MB7951.namprd12.prod.outlook.com (2603:10b6:806:318::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 15:32:31 +0000
Received: from CY4PEPF0000B8E8.namprd05.prod.outlook.com
 (2603:10b6:930:83:cafe::24) by CY5PR19CA0096.outlook.office365.com
 (2603:10b6:930:83::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:30 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8E8.mail.protection.outlook.com (10.167.241.4) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 21 Oct 2022 15:32:29 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:24 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:23 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94cc1aef-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=klCJXEHjosTAKu7Dj7CGmuOFBwGJ8X5MSzpGwJwuAzMjPuYEIgdnHonT35WY0u6CUevfktSdEFDYd7s4xqkSUn2FDqQtCNBp8ShItH3YYjBrVXUVnNKIXFgmMCSk6BWVd246AcbIIixWjdKukAUlShg2QA06r43L9mcSTFTVSMcXdblMmcCx1phxR3HPybNh+Oi885RVP3oslU8Nx4XyoCS3T55w7AMr+fDciGSqnZYJWQSkY7xw7VZ14zzgvN+Fx/uy6aXPRs8mLEn9Q22/nS32upzgUgMB8t7L+rhNaQnljnZNt5QfIrB4eD4SF4reV3nrh8JG73+IwnXI67XylA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wYaQtT0b/pESxMwe1f+rFfaaV2COA/hSqXIyQ3/U1lc=;
 b=FtKFr4e+9EDjN/IKfXrIfcrjMzcXw1SeP/qz7EYy0Im4piLWyU70dTH/VIUVd0/Br8NK916jsnm9Vf/hgDjtVkeiFeIa9x2GTdPfbhx25cy38Oiz4aQ1NodSIOVXycvi0CgsiJ/1pddAtwitlgxurLDvqugzOU9Hv/DgM3a/gTQkD/vtwZBQjoFVbbbCA7k9dFhswjuZGpDU4VMRUearZ9gkB+peIFpzuQ0V/hsbTxBuIbw16aW2TOJHEFTXOsPsbOiFXqD9MHWiKph5e/4QaIKu7eCy4eN5KYO/7rdVJrTwyuPsEiO5rez6Y5nboSmAw35wmAXHL9ibg1mfXdvDfA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wYaQtT0b/pESxMwe1f+rFfaaV2COA/hSqXIyQ3/U1lc=;
 b=cIXP9mrrPWPtjLSk3bbweMhUdrvzBisQp5zLVgJsxObmRw2jFolfWU5167boCBRCcSyuWQRNuYqvgzgeTViXHDfuhRxpLB0rEIH3vGxiLJA60T/xAGTEkXf8bx7K0bew1WyHl3HZVoMJCoGVJIeFYxr24uftjoaVG+uV3qMU5R4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 08/12] Arm: GICv3: Define ICH_AP0R<n> and ICH_AP1R<n> for AArch32
Date: Fri, 21 Oct 2022 16:31:24 +0100
Message-ID: <20221021153128.44226-9-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8E8:EE_|SA3PR12MB7951:EE_
X-MS-Office365-Filtering-Correlation-Id: 4e145c3d-9219-480a-45fa-08dab379773b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7FJqjnSe0FzfMuExIrH0jTmtfI6ezT4GfiHPDzOw43WDaVDM+n95anoMVTObwx+71lD67NYYhCfnVnSaFOJ1LHtVAufuAJOZaBFfZiwUZhqsJHF3GjrIl4CdCtYssHVRfvHjBRcnf/DkaPU3DMODiou61fHXxTPE+GA9WYk37ZaIKpQBYCD0U+z2/mUjzOn23U16eeY5q4F/wyzfKwQi8SRl6jvfT0wHBYtwAuLh8f/jKWPxPhaXxXmmhTiRjJF/knD9K/0f4Vg4J+JGZyTQ+T5c9YtoL3DeBH5ztE6E4UHmDfYG2dMtx+V+iM4KGummnUwnipzMxyn5Kke4V20aQBtQwo4ewfgJIAIUgglmtX9KCGQ1NjzIAj7rf71FJ7a/TixF6xrQhhuYVpSHSTavMQOWwSLFoOqGAPa4xyxYOMd97cR7Yl4yLz0/TzIzb72Dsf5TSqodMWaOlAxeKz/0nLo39O/qjBj50vhU73UOCfYzpa5SZnl14MPLgpQDhiAezxVHEjzL3ONF1GYmZLkQpyNW1NsV0FbJQliDUhPPY5h1RynsNsIOA+1aSJ5D8R/sCYzWrtfaPF6muohdtzwu5x4vv1pP7tyQxhpyD+s/gI9L0mYV3nSYCWXPnN/mf3IMSJ6NZ0d7eOw0xtCaS9KSAghBzEwtlJ8J6aOkFgo6B5NBNRLAJN4FGeN4WO2m6jnFWuevckHDU+9S39+IZF+OKAUBPG3XhZrzGHi+jAv5N60yJ3SRzr9m3QhF01igefCVT/ej2jcQO2Dj7W+diNylGRdSVS3LFuDNd9X6lvXQGPLOCvmSX6rRNhxXyG1AD8B5
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(2906002)(478600001)(81166007)(1076003)(186003)(82740400003)(40460700003)(356005)(6916009)(316002)(36756003)(8676002)(41300700001)(54906003)(4326008)(82310400005)(70586007)(70206006)(5660300002)(8936002)(2616005)(36860700001)(336012)(47076005)(426003)(40480700001)(26005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:29.6165
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e145c3d-9219-480a-45fa-08dab379773b
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8E8.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7951

Refer "Arm IHI 0069H ID020922",
12.7.1 - Interrupt Controller Hyp Active Priorities Group0 Registers 0-3
12.7.2 - Interrupt Controller Hyp Active Priorities Group1 Registers 0-3

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/include/asm/arm32/sysregs.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
index f3b4dfbca8..693da22324 100644
--- a/xen/arch/arm/include/asm/arm32/sysregs.h
+++ b/xen/arch/arm/include/asm/arm32/sysregs.h
@@ -117,6 +117,18 @@
 #define ICH_LRC14_EL2              __LRC8_EL2(6)
 #define ICH_LRC15_EL2              __LRC8_EL2(7)
 
+#define __AP0Rx_EL2(x)            ___CP32(p15,4,c12,c8,x)
+#define ICH_AP0R0_EL2             __AP0Rx_EL2(0)
+#define ICH_AP0R1_EL2             __AP0Rx_EL2(1)
+#define ICH_AP0R2_EL2             __AP0Rx_EL2(2)
+#define ICH_AP0R3_EL2             __AP0Rx_EL2(3)
+
+#define __AP1Rx_EL2(x)            ___CP32(p15,4,c12,c9,x)
+#define ICH_AP1R0_EL2             __AP1Rx_EL2(0)
+#define ICH_AP1R1_EL2             __AP1Rx_EL2(1)
+#define ICH_AP1R2_EL2             __AP1Rx_EL2(2)
+#define ICH_AP1R3_EL2             __AP1Rx_EL2(3)
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* __ASM_ARM_ARM32_SYSREGS_H */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:35:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:35:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427783.677203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu3J-0006PI-AO; Fri, 21 Oct 2022 15:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427783.677203; Fri, 21 Oct 2022 15:35:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu3J-0006Ox-6B; Fri, 21 Oct 2022 15:35:17 +0000
Received: by outflank-mailman (input) for mailman id 427783;
 Fri, 21 Oct 2022 15:35:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0j-0000AU-Rk
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:38 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam04on2087.outbound.protection.outlook.com [40.107.100.87])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 969c6a9c-5155-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 17:32:36 +0200 (CEST)
Received: from BN9PR03CA0668.namprd03.prod.outlook.com (2603:10b6:408:10e::13)
 by LV2PR12MB5918.namprd12.prod.outlook.com (2603:10b6:408:174::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Fri, 21 Oct
 2022 15:32:33 +0000
Received: from BN8NAM11FT113.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:10e:cafe::d8) by BN9PR03CA0668.outlook.office365.com
 (2603:10b6:408:10e::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:33 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT113.mail.protection.outlook.com (10.13.176.163) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:32 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:32 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:32:32 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:30 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 969c6a9c-5155-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EXR9udSPO1VIxLfy0Eib8Gmn8jzDPzhDN8GM8uh+DYFRv3H912QVNAqDuVGwGPji0k89eBCPSbghlRQ3L10mlcX4262wIhGQz8K03A1BRDaVUivtZwODKpwwPvIFJ+gd033wdHOWt2oGkxzVAmmENtFQDnZmxTaLKtdP7P1A3NvK3gmHGJjd98BODLvRu0x+2hPckec4i4mShoccDYGYw8C1hKg0rn0crqiCG1HmBgHrdRTXmo+nC/PDJBl6GdmeYFXl0E8js+x9Qb5FZUgAyDBz6U6ULYHSBDcomiuCHcjqEgvN60ygPHdPrX2S3Nbs+pMomu9zKAMbKBM04e+lAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yfSatt3fhyxCfsYWEQ3wGF9JEz5WBpn1wXBs+rdPAtQ=;
 b=mYtynWzztFAIXMiFBRmGDMsfojwqUak9vqh4L+2oMZLFWxHEQNPxxt6a7c60wUYbsA4QMFWCRF/QUKPBZkT+48GQmslFRbzhNAEwqpawMD4ZZYP56dBzXq017KideDVEZ2JnUewna7EQ5bqXGapfk7EdCAURDlJdmI6Njqud4e2soMn/kYbSwINv2Rf35nlCFEFQy5chozx+LF6CKS49ehQ7bYUf1jczCHenrABWwgGATCqQIl0lyqrxISZ03xT/+laSm1MasRz3ENLod0M33DVvlwW6tDTA2xyzW1GsxJrAW2fhHZrZph5F2nIQi5GoXuDfzoyFL8y8eguqB25efA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yfSatt3fhyxCfsYWEQ3wGF9JEz5WBpn1wXBs+rdPAtQ=;
 b=VTVRbs/1YNpzqD2+loG+LhTGnmw35nhiu31WO42kp0KkRkTl9VnGzLO6spin36pkNWitVBZyncxkJPivXIV+EFDuxRoCJ3DBWjZDSQOl6YHBuGbbJlxV+cQDFvHWwz7CjmIOCEX0hb6xgTZEL1zog3g9/4GN8bcE+XLjxs04sxI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 10/12] Arm: GICv3: Use ULL instead of UL for 64bits
Date: Fri, 21 Oct 2022 16:31:26 +0100
Message-ID: <20221021153128.44226-11-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT113:EE_|LV2PR12MB5918:EE_
X-MS-Office365-Filtering-Correlation-Id: 2ee603b3-888e-414e-b599-08dab379790d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NMQxIhQKx73s8kdC3DZ7VaYVPnLcgQz6jk0QIrAVKDOs53IXcDE6hM4E8i0fIXteDSHo5dNcV6cGWFWkKYqICaxD4dVeRh53B/tL8eWChw9SR3s5Y+IEnvWCw0NNnWgkBddGajx+i6/c4ySxd0/w5e2TtRYvgG4AmLEBhL3NER95b/KipVJCBj1CFqBaDCpyGIYSVPfDKZygxGtd+KLh8LwbNhcTjqnQbTf3pWiU7ixy72c4v8OovmpWQwkeJg+zTVQgWwWC2xAX+ldK/kZ39o1qfainAVDzodZ/aDIiAiw/weH0+4z+9UpF0T3nCpBHil9X+k3HW89w+h0p89/egovMoqBXuDkRIHGziGNDTB7hOkxmv/cTR46F09V8veq7BLaSwZEJB1v874RRFHWfxBPxiPkFBRVmYlBTdOxjT/DrUUBBNtw5vZmOW/0LVup24mf/6XoLv1Q2YCxcsSw1PsD9sMF4d9jIM6pBboQ+dTWNya50Rzjav5U1MOlv1k0gUAgB4PyOGKAon2QgbTbqWi/v4Vys94vja/8pp1lRrowdVNEg98lN3emEstq9GMM2wgfFPbTnUkWPc2gqOVIFGMgBZlMYyQvZSHXqaiIiyDAd6/v+OEbt/cTqbWrLA9+VEiYZrbR/Vt4H/YEzZ5fOMoOem01x34atv/CqCSkJNVKjeOrHnoVRxBP3VZ6Tbf0fYzN0L8IpqV+LMJCxKd16S0ppChTz56P+iu49E/MyN9lXkHlPTHpYj9XGJzuVU9ByYJCL9nHxEv1mB1+QdlpFNA2wQgATua5jtIDSqAEK5BE=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(36840700001)(40470700004)(46966006)(4326008)(2906002)(336012)(8936002)(41300700001)(186003)(40460700003)(1076003)(5660300002)(6666004)(36756003)(26005)(478600001)(426003)(2616005)(47076005)(8676002)(70206006)(70586007)(356005)(83380400001)(81166007)(82310400005)(316002)(82740400003)(6916009)(54906003)(36860700001)(40480700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:32.9390
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ee603b3-888e-414e-b599-08dab379790d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT113.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5918

"unsigned long long" is defined as 64 bits on AArch64 and AArch32
Thus, one should this instead of "unsigned long" which is 32 bits
on AArch32.

Also use 'PRIu64' instead of 'lx' to print uint64_t.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/gic-v3-its.c              | 20 ++++++++++----------
 xen/arch/arm/gic-v3-lpi.c              |  8 ++++----
 xen/arch/arm/gic-v3.c                  |  4 ++--
 xen/arch/arm/include/asm/gic_v3_defs.h |  2 +-
 xen/arch/arm/include/asm/gic_v3_its.h  |  2 +-
 xen/arch/arm/vgic-v3-its.c             | 17 +++++++++--------
 6 files changed, 27 insertions(+), 26 deletions(-)

diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index e217c21bf8..dd056a3140 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -163,7 +163,7 @@ static int gicv3_its_wait_commands(struct host_its *hw_its)
 static uint64_t encode_rdbase(struct host_its *hw_its, unsigned int cpu,
                               uint64_t reg)
 {
-    reg &= ~GENMASK(51, 16);
+    reg &= ~GENMASK_ULL(51, 16);
 
     reg |= gicv3_get_redist_address(cpu, hw_its->flags & HOST_ITS_USES_PTA);
 
@@ -219,7 +219,7 @@ static int its_send_cmd_mapd(struct host_its *its, uint32_t deviceid,
     {
         ASSERT(size_bits <= its->evid_bits);
         ASSERT(size_bits > 0);
-        ASSERT(!(itt_addr & ~GENMASK(51, 8)));
+        ASSERT(!(itt_addr & ~GENMASK_ULL(51, 8)));
 
         /* The number of events is encoded as "number of bits minus one". */
         size_bits--;
@@ -273,9 +273,9 @@ int gicv3_its_setup_collection(unsigned int cpu)
 
 #define BASER_ATTR_MASK                                           \
         ((0x3UL << GITS_BASER_SHAREABILITY_SHIFT)               | \
-         (0x7UL << GITS_BASER_OUTER_CACHEABILITY_SHIFT)         | \
-         (0x7UL << GITS_BASER_INNER_CACHEABILITY_SHIFT))
-#define BASER_RO_MASK   (GENMASK(58, 56) | GENMASK(52, 48))
+         (0x7ULL << GITS_BASER_OUTER_CACHEABILITY_SHIFT)         | \
+         (0x7ULL << GITS_BASER_INNER_CACHEABILITY_SHIFT))
+#define BASER_RO_MASK   (GENMASK_ULL(58, 56) | GENMASK_ULL(52, 48))
 
 /* Check that the physical address can be encoded in the PROPBASER register. */
 static bool check_baser_phys_addr(void *vaddr, unsigned int page_bits)
@@ -287,13 +287,13 @@ static bool check_baser_phys_addr(void *vaddr, unsigned int page_bits)
 
 static uint64_t encode_baser_phys_addr(paddr_t addr, unsigned int page_bits)
 {
-    uint64_t ret = addr & GENMASK(47, page_bits);
+    uint64_t ret = addr & GENMASK_ULL(47, page_bits);
 
     if ( page_bits < 16 )
         return ret;
 
     /* For 64K pages address bits 51-48 are encoded in bits 15-12. */
-    return ret | ((addr & GENMASK(51, 48)) >> (48 - 12));
+    return ret | ((addr & GENMASK_ULL(51, 48)) >> (48 - 12));
 }
 
 static void *its_map_cbaser(struct host_its *its)
@@ -310,7 +310,7 @@ static void *its_map_cbaser(struct host_its *its)
     if ( !buffer )
         return NULL;
 
-    if ( virt_to_maddr(buffer) & ~GENMASK(51, 12) )
+    if ( virt_to_maddr(buffer) & ~GENMASK_ULL(51, 12) )
     {
         xfree(buffer);
         return NULL;
@@ -446,7 +446,7 @@ static int gicv3_disable_its(struct host_its *hw_its)
         udelay(1);
     } while ( NOW() <= deadline );
 
-    printk(XENLOG_ERR "ITS@%lx not quiescent.\n", hw_its->addr);
+    printk(XENLOG_ERR "ITS@%" PRIu64 " not quiescent.\n", hw_its->addr);
 
     return -ETIMEDOUT;
 }
@@ -999,7 +999,7 @@ static void add_to_host_its_list(paddr_t addr, paddr_t size,
     its_data->size = size;
     its_data->dt_node = node;
 
-    printk("GICv3: Found ITS @0x%lx\n", addr);
+    printk("GICv3: Found ITS 0x%" PRIu64 "\n", addr);
 
     list_add_tail(&its_data->entry, &host_its_list);
 }
diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 61d90eb386..9ca74bc321 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -134,7 +134,7 @@ void gicv3_set_redist_address(paddr_t address, unsigned int redist_id)
 uint64_t gicv3_get_redist_address(unsigned int cpu, bool use_pta)
 {
     if ( use_pta )
-        return per_cpu(lpi_redist, cpu).redist_addr & GENMASK(51, 16);
+        return per_cpu(lpi_redist, cpu).redist_addr & GENMASK_ULL(51, 16);
     else
         return per_cpu(lpi_redist, cpu).redist_id << 16;
 }
@@ -253,7 +253,7 @@ static int gicv3_lpi_allocate_pendtable(unsigned int cpu)
         return -ENOMEM;
 
     /* Make sure the physical address can be encoded in the register. */
-    if ( virt_to_maddr(pendtable) & ~GENMASK(51, 16) )
+    if ( virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16) )
     {
         xfree(pendtable);
         return -ERANGE;
@@ -281,7 +281,7 @@ static int gicv3_lpi_set_pendtable(void __iomem *rdist_base)
         return -ENOMEM;
     }
 
-    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16)));
+    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16)));
 
     val  = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
     val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT;
@@ -329,7 +329,7 @@ static int gicv3_lpi_set_proptable(void __iomem * rdist_base)
             return -ENOMEM;
 
         /* Make sure the physical address can be encoded in the register. */
-        if ( (virt_to_maddr(table) & ~GENMASK(51, 12)) )
+        if ( (virt_to_maddr(table) & ~GENMASK_ULL(51, 12)) )
         {
             xfree(table);
             return -ERANGE;
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 8b4b168e78..35eaa30c67 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v)
     if ( v == current )
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i));
+            printk("   HW_LR[%d]=%" PRIu64 "\n", i, gicv3_ich_read_lr(i));
     }
     else
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]);
+            printk("   VCPU_LR[%d]=%" PRIu64 "\n", i, v->arch.gic.v3.lr[i]);
     }
 }
 
diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 87115f8b25..3a24bd4825 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -195,7 +195,7 @@
 
 #define ICH_SGI_IRQMODE_SHIFT        40
 #define ICH_SGI_IRQMODE_MASK         0x1
-#define ICH_SGI_TARGET_OTHERS        1UL
+#define ICH_SGI_TARGET_OTHERS        1ULL
 #define ICH_SGI_TARGET_LIST          0
 #define ICH_SGI_IRQ_SHIFT            24
 #define ICH_SGI_IRQ_MASK             0xf
diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h
index fae3f6ecef..5ae50b18ea 100644
--- a/xen/arch/arm/include/asm/gic_v3_its.h
+++ b/xen/arch/arm/include/asm/gic_v3_its.h
@@ -38,7 +38,7 @@
 #define GITS_PIDR2                      GICR_PIDR2
 
 /* Register bits */
-#define GITS_VALID_BIT                  BIT(63, UL)
+#define GITS_VALID_BIT                  BIT(63, ULL)
 
 #define GITS_CTLR_QUIESCENT             BIT(31, UL)
 #define GITS_CTLR_ENABLE                BIT(0, UL)
diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
index 58d939b85f..2b7bb17800 100644
--- a/xen/arch/arm/vgic-v3-its.c
+++ b/xen/arch/arm/vgic-v3-its.c
@@ -96,13 +96,13 @@ typedef uint16_t coll_table_entry_t;
  * in the lowest 5 bits of the word.
  */
 typedef uint64_t dev_table_entry_t;
-#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK(51, 8))
+#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK_ULL(51, 8))
 #define DEV_TABLE_ITT_SIZE(x) (BIT(((x) & GENMASK(4, 0)) + 1, UL))
 #define DEV_TABLE_ENTRY(addr, bits)                     \
         (((addr) & GENMASK(51, 8)) | (((bits) - 1) & GENMASK(4, 0)))
 
 #define GITS_BASER_RO_MASK       (GITS_BASER_TYPE_MASK | \
-                                  (0x1fL << GITS_BASER_ENTRY_SIZE_SHIFT))
+                                  (0x1fLL << GITS_BASER_ENTRY_SIZE_SHIFT))
 
 /*
  * The physical address is encoded slightly differently depending on
@@ -112,10 +112,10 @@ typedef uint64_t dev_table_entry_t;
 static paddr_t get_baser_phys_addr(uint64_t reg)
 {
     if ( reg & BIT(9, UL) )
-        return (reg & GENMASK(47, 16)) |
+        return (reg & GENMASK_ULL(47, 16)) |
                 ((reg & GENMASK(15, 12)) << 36);
     else
-        return reg & GENMASK(47, 12);
+        return reg & GENMASK_ULL(47, 12);
 }
 
 /* Must be called with the ITS lock held. */
@@ -414,7 +414,7 @@ static int update_lpi_property(struct domain *d, struct pending_irq *p)
     if ( !d->arch.vgic.rdists_enabled )
         return 0;
 
-    addr = d->arch.vgic.rdist_propbase & GENMASK(51, 12);
+    addr = d->arch.vgic.rdist_propbase & GENMASK_ULL(51, 12);
 
     ret = access_guest_memory_by_ipa(d, addr + p->irq - LPI_OFFSET,
                                      &property, sizeof(property), false);
@@ -897,7 +897,8 @@ out_unlock:
 
 static void dump_its_command(uint64_t *command)
 {
-    gdprintk(XENLOG_WARNING, "  cmd 0x%02lx: %016lx %016lx %016lx %016lx\n",
+    gdprintk(XENLOG_WARNING, "  cmd 0x%" PRIu64 ": %" PRIu64
+             "%" PRIu64 "%" PRIu64 "%" PRIu64 "\n",
              its_cmd_get_command(command),
              command[0], command[1], command[2], command[3]);
 }
@@ -909,7 +910,7 @@ static void dump_its_command(uint64_t *command)
  */
 static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its)
 {
-    paddr_t addr = its->cbaser & GENMASK(51, 12);
+    paddr_t addr = its->cbaser & GENMASK_ULL(51, 12);
     uint64_t command[4];
 
     ASSERT(spin_is_locked(&its->vcmd_lock));
@@ -1122,7 +1123,7 @@ read_as_zero_64:
 
 read_impl_defined:
     printk(XENLOG_G_DEBUG
-           "%pv: vGITS: RAZ on implementation defined register offset %#04lx\n",
+           "%pv: vGITS: RAZ on implementation defined register offset %" PRIx64 "#04llx\n",
            v, info->gpa & 0xffff);
     *r = 0;
     return 1;
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:35:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:35:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427787.677208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu3J-0006Xd-Sg; Fri, 21 Oct 2022 15:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427787.677208; Fri, 21 Oct 2022 15:35:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olu3J-0006VY-Pf; Fri, 21 Oct 2022 15:35:17 +0000
Received: by outflank-mailman (input) for mailman id 427787;
 Fri, 21 Oct 2022 15:35:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sJ2K=2W=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1olu0s-0000nK-KO
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 15:32:46 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9b7cbddc-5155-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 17:32:45 +0200 (CEST)
Received: from BN9PR03CA0133.namprd03.prod.outlook.com (2603:10b6:408:fe::18)
 by BY5PR12MB4934.namprd12.prod.outlook.com (2603:10b6:a03:1db::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 15:32:41 +0000
Received: from BN8NAM11FT019.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:fe:cafe::26) by BN9PR03CA0133.outlook.office365.com
 (2603:10b6:408:fe::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 15:32:40 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT019.mail.protection.outlook.com (10.13.176.158) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 15:32:38 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 10:32:38 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 08:32:38 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 10:32:37 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b7cbddc-5155-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nRxhGPFbxYDRO9zMl/lx+SHV4PWR848MqNciroSK5XAX6916Je4ksQVOcQP0oMqoH2mZ7QKo6lyUY8B3bCv+gV8LQRCJV00Il1s/zlH1jPuokASA7FH68fP/51T3tEI3qF42/URSe5s4vVg2CIdSmJIJ+LhHxDSMkDAJQ/NM+nbD5+OIy11XrM+zI2CoGoDNfNuK+yTR9kvA85SYqyEEzx5h+t8leO9+SqlOEQUIkO+/Hz20vDk+ww/45sqApa/73HlCSFfKeTZGof30KzEHbApCvkYQIkUmLbYRnWMfvYgoHP55H/hQb6VA7I3mE2PvtHlkZ/Mmfr+FSta8ZxlJYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gaPWf9DnJA/XGQug9i0zfhmL9v2rXPG9m6XEPCJ3yPc=;
 b=a7nbptSvZlhIMjiGWh2f1p2yR9lp83s/nO17HLYwrN+W8Mgy1M6gvrQIDj3XsYOrFGykD5eW3HiUL0AS5ZVFlkqPuZC2O/DE74uolm+M7uwHZoEr148RzjUYfuFgOi8OiAuvfPplEQj80RB2DZ9TWxCq24iR0X4hPVaZfV8se/2AZmmq5rhGZ/buQ4rW5y68nTwroVW0+F3r2Z15dYMRtMLXZyObFEIRDSY9LUVYQbe1jgEv6wMcJK50uWeGl8cpNnk0+maKlyUyouAleywaDQJ3x3WntHo+YIoJvOvObOe1k2u5OF6X06Lpug5jRQ4PaopQca4PwUnj72wWgi+LsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip
 is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org
 smtp.mailfrom=amd.com; dmarc=temperror action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gaPWf9DnJA/XGQug9i0zfhmL9v2rXPG9m6XEPCJ3yPc=;
 b=GPEVX+OhZAS3Dd4dNkt9pND2oXYMgO6EYNzKmHRX5930F4hN/6OzoF8xKw9zq6eS8OVL0EsLNjs5VCx3LyOra8cPdUqJlvmhAYH5UAFYfAE+o9e8l+MJkW+00cRZriMJHNFDBkag4HtHFN/2+kFC1AEzwKHZPJyW/eflnLbSh2s=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=temperror action=none header.from=amd.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of amd.com: DNS Timeout)
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [RFC PATCH v1 12/12] Arm: GICv3: Enable GICv3 for AArch32
Date: Fri, 21 Oct 2022 16:31:28 +0100
Message-ID: <20221021153128.44226-13-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221021153128.44226-1-ayankuma@amd.com>
References: <20221021153128.44226-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT019:EE_|BY5PR12MB4934:EE_
X-MS-Office365-Filtering-Correlation-Id: a17336cc-1fcf-465b-2cc7-08dab3797cab
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bIBS/nvJCZDQrv5kEfuB4dPzwawjRwZ6mX4nruadHaHCHWGJxT0dWFV3+1oiS4IP48GhJpq3D7RjFrVy8Tm24OPLoshfAcbhn7Dv3o3PCk6sCYYpW+BuovZO1kcjcQ4BH47pnXNjX8cETiCfoSk6khKrHJN1IOCsKZrr3WvCcJEsBei6QpOBBSmL2NbTqliYHljnlUHwJdm6c32V2/zX71I6Wh1JZ1AsZqBiB1GnJnIA1l55vQc4TMHalIZq1g81dC4KuwHvg0kGuwwDbZyvl5ABqRLXMfU6j+zXSiIjXiOya1NbnCw6HG3tj3nEPC73peLmwzlBGxsyY2uxJ6dXnNZ3qgsXV1n+XTAeoFlYQvZoOqRUzfi8fEUjcpenmibdsK10wnkYFajp+ETjvqOB0q4TvW+OdXQGJgU8B3iwjNnfnpEprkkukT8WrGQQAcshGejDaC3IqyT1ipoLvZ0d6Oqdfp4WsfzXNANU0FAev9r2C9fT6TXxPQvyaEetqZdpft1OQVJllBF2GTqKU9luiMR7laSVzbjfKvvg4wMAciSiknVoE2cvzNnsLyZyc6BC8Lx2eiDA/TLjMzAQYU13f3Ya0Gh9kDlFqcg/+FvYCPVlAyKOLIdviITxSfL6kno6Ei2FtGsTk2gl6WYtxOe2iQewo9k4CxqJL8OQ4bQuR0dymT+fekO8IFjPau2ZvT7YwXt3QyJtxcNLsz6EzhPj0UDteoy8sS97C59MdSfDj238hlSbAGdwux+3LZzVMArTGJYzviALOEawnKlt9Gh+HB73kcQ+SHOUI+08m5bexcM=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(1076003)(426003)(186003)(47076005)(2616005)(6666004)(63350400001)(26005)(336012)(40460700003)(83380400001)(5660300002)(40480700001)(36860700001)(2906002)(82310400005)(316002)(41300700001)(54906003)(478600001)(8936002)(8676002)(6916009)(4326008)(70586007)(70206006)(63370400001)(36756003)(356005)(82740400003)(81166007)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 15:32:38.9885
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a17336cc-1fcf-465b-2cc7-08dab3797cab
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT019.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4934

Refer ARM DDI 0487G.b ID072021,
D13.2.86 -
ID_PFR1_EL1, AArch32 Processor Feature Register 1

GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32

One can now enable GICv3 on AArch32 systems.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/Kconfig                  | 2 +-
 xen/arch/arm/include/asm/cpufeature.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 1fe5faf847..5eaf21b8e0 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -41,7 +41,7 @@ config ARM_EFI
 
 config GICV3
 	bool "GICv3 driver"
-	depends on ARM_64 && !NEW_VGIC
+	depends on (ARM_64 || ARM_32) && !NEW_VGIC
 	default y
 	---help---
 
diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h
index c86a2e7f29..c8ca09d1c3 100644
--- a/xen/arch/arm/include/asm/cpufeature.h
+++ b/xen/arch/arm/include/asm/cpufeature.h
@@ -31,6 +31,7 @@
 #define cpu_has_jazelle   (boot_cpu_feature32(jazelle) > 0)
 #define cpu_has_thumbee   (boot_cpu_feature32(thumbee) == 1)
 #define cpu_has_aarch32   (cpu_has_arm || cpu_has_thumb)
+#define cpu_has_gicv3     (boot_cpu_feature32(gic) >= 1)
 
 #ifdef CONFIG_ARM_32
 #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 15:56:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 15:56:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427805.677224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluNZ-0001Zd-JV; Fri, 21 Oct 2022 15:56:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427805.677224; Fri, 21 Oct 2022 15:56:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluNZ-0001ZW-Gz; Fri, 21 Oct 2022 15:56:13 +0000
Received: by outflank-mailman (input) for mailman id 427805;
 Fri, 21 Oct 2022 15:56:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluNY-0001ZM-3n; Fri, 21 Oct 2022 15:56:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluNY-0005p8-2j; Fri, 21 Oct 2022 15:56:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluNX-00074i-BG; Fri, 21 Oct 2022 15:56:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oluNX-0001GR-Ao; Fri, 21 Oct 2022 15:56:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=U8aq+vHf/xjcWPQwilDcbB6GocW3Pyyhcq/WdzVuMH0=; b=n6X9gU2OwPLjVIYOI/p8UqJc7u
	WJkSmYR+B6QmkzK3kha2jmg5mD/cfLHMiMJ1w0ajyzBM+6TQlDpv2H9sTVXX1rEDu/sVu+Y1WzsV4
	Ie4Y8KVKMnna6rIUbJq+Is+qUi7gtZ1SE8W/SrFmmVbY8jWX3970xo0h6qyR21OER3QA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174201-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174201: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
X-Osstest-Versions-That:
    xen=f838b956779ff8a0b94636462f3c6d95c3adeb73
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 15:56:11 +0000

flight 174201 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174201/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340
baseline version:
 xen                  f838b956779ff8a0b94636462f3c6d95c3adeb73

Last test of basis   174192  2022-10-21 10:00:58 Z    0 days
Testing same since   174201  2022-10-21 13:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dario Faggioli <dfaggioli@suse.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@amd.com>
  Xenia Ragiadakou <burzalodowa@gmail.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f838b95677..73c62927f6  73c62927f64ecb48f27d06176befdf76b879f340 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 16:01:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 16:01:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427812.677236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluSa-0003WH-6u; Fri, 21 Oct 2022 16:01:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427812.677236; Fri, 21 Oct 2022 16:01:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluSa-0003WA-46; Fri, 21 Oct 2022 16:01:24 +0000
Received: by outflank-mailman (input) for mailman id 427812;
 Fri, 21 Oct 2022 16:01:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluSY-0003W0-FL; Fri, 21 Oct 2022 16:01:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluSY-0006Sl-BM; Fri, 21 Oct 2022 16:01:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluSX-0007To-Vr; Fri, 21 Oct 2022 16:01:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oluSX-0005VU-VO; Fri, 21 Oct 2022 16:01:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=IM1q3R8Iely4AirytPB2bbkpcEAPxRN8x/Js0WQXa6U=; b=VwZAzaFjVRtb16xZnFmlAUFyNB
	d7KC8sszyJO2m1yfOMDbmdaPDvwj8PjB+atYuhkNsbeK2FW5CCoDFClIGIvFJm3DPScIX4usFk0sl
	DsgjOEI9m4Fxb7lw/W7Utllk9rxPPmuifexrnCeyWudST29aa8/G7y5eE2Bzg8Cv862o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174155-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174155: tolerable trouble: fail/pass/starved - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking
    qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    qemuu=0529245488865038344d64fff7ee05864d3d17f6
X-Osstest-Versions-That:
    qemuu=214a8da23651f2472b296b3293e619fd58d9e212
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 16:01:21 +0000

flight 174155 qemu-mainline real [real]
flight 174206 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174155/
http://logs.test-lab.xenproject.org/osstest/logs/174206/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 174206-retest
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 174206-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174060
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174060
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174060
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174060
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174060
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-seattle   3 hosts-allocate               starved  n/a

version targeted for testing:
 qemuu                0529245488865038344d64fff7ee05864d3d17f6
baseline version:
 qemuu                214a8da23651f2472b296b3293e619fd58d9e212

Last test of basis   174060  2022-10-18 20:37:04 Z    2 days
Testing same since   174155  2022-10-20 22:37:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Anders Roxell <anders.roxell@linaro.org>
  Baruch Siach <baruch@tkos.co.il>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  starved 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   214a8da236..0529245488  0529245488865038344d64fff7ee05864d3d17f6 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 16:07:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 16:07:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427822.677252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluYa-0004MW-2I; Fri, 21 Oct 2022 16:07:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427822.677252; Fri, 21 Oct 2022 16:07:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluYZ-0004MP-VW; Fri, 21 Oct 2022 16:07:35 +0000
Received: by outflank-mailman (input) for mailman id 427822;
 Fri, 21 Oct 2022 16:07:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluYY-0004MF-MQ; Fri, 21 Oct 2022 16:07:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluYY-0006aH-HC; Fri, 21 Oct 2022 16:07:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluYY-00085x-5u; Fri, 21 Oct 2022 16:07:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oluYY-0005p5-5P; Fri, 21 Oct 2022 16:07:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=q4OnwKACVOeERfGmdkKtsR8b5WMbiESQkZuXyMnQl9Q=; b=bcsGLuU47LFMrtxQN/swv5yPxD
	ZOMrkviksu3yhzDS6TJM2WOBVqLadES6cfQBu6eUap99OeCgFqdpjxoIzPHZqU1ydyaMANmcawEPj
	Ko0uV2VKW23C6TFzjzlfblIpy6vDslszOpsLTwOEIJW2wI1TErH1O2v9ekssmR40iCZM=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-armhf-armhf-xl-multivcpu
Message-Id: <E1oluYY-0005p5-5P@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 16:07:34 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-armhf-armhf-xl-multivcpu
testid guest-start

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174207/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-multivcpu.guest-start.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-multivcpu.guest-start --summary-out=tmp/174207.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-armhf-armhf-xl-multivcpu guest-start
Searching for failure / basis pass:
 174070 fail [host=arndale-metrocentre] / 172623 [host=arndale-lakeside] 172548 [host=arndale-westfield] 172130 ok.
Failure / basis pass flights: 174070 / 172130
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9d6915ca91519271a79bc6190a31f0af89e339b2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#0dc9b78a46813d61533b2bb0f7ef897a06a273be-9d6915ca91519271a79bc6190a31f0af89e339b2 git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad\
 8-107951211a8d17658e1aaa0c23a8cf29f8806ad8 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#48b67651746f3124b0d5d30147180f1238d2e9c6-1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Loaded 10001 nodes in revision graph
Searching for test results:
 173759 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173882 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173986 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d618fe05bf93a8884619e9362bfc5636da55e347 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174070 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9d6915ca91519271a79bc6190a31f0af89e339b2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174137 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6
 174141 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9d6915ca91519271a79bc6190a31f0af89e339b2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174158 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 917a7e3f347adb0721ff161a68309f51f621eec5 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174161 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d63242bd69a0e3eaa39afd644b634f60f384b278 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174163 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 406ad0582a3df7af498ec4f0adee1a95ceeae64f 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174169 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 943635d8f8486209e4e48966507ad57963e96284
 174171 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 e85e2a3c17b6cd38de041cdaf14d9efdcdabad1a
 174176 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 914fc8e8b4cc003e90d51bee0aef54687358530a
 174181 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174186 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174194 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174198 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174199 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174204 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174207 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 172130 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6
 172548 [host=arndale-westfield]
 172623 [host=arndale-lakeside]
 173493 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173511 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173702 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173603 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Searching for interesting versions
 Result found: flight 172130 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x555cc6dbbfd8) HASH(0x555cc6ca5f00) HASH(0x555cc6cc1300) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56\
 b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 914fc8e8b4cc003e90d51bee0aef54687358530a, results HASH(0x555cc6dac280) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 943635d8f8486209e4e48966507ad57963e96284, results HASH(0x555cc6cd\
 78b8) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 406ad0582a3df7af498ec4f0adee1a95ceeae64f 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x555cc6cd4688) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d63242bd69a0e3eaa39afd644b634f60f384b278 10795\
 1211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x555cc6cd0678) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 917a7e3f347adb0721ff161a68309f51f621eec5 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x555cc6ccc640) For basis failure, parent searc\
 h stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 0dc9b78a46813d61533b2bb0f7ef897a06a273be 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 48b67651746f3124b0d5d30147180f1238d2e9c6, results HASH(0x555cc6cc4710) HASH(0x555cc6ce1c08) Result found: flight 173493 (fail), for basis failure (at ancestor ~662)
 Repro found: flight 174137 (pass), for basis pass
 Repro found: flight 174141 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 174186 (pass), for last pass
 Result found: flight 174194 (fail), for first failure
 Repro found: flight 174198 (pass), for last pass
 Repro found: flight 174199 (fail), for first failure
 Repro found: flight 174204 (pass), for last pass
 Repro found: flight 174207 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174207/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 154 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-multivcpu.guest-start.{dot,ps,png,html,svg}.
----------------------------------------
174207: tolerable ALL FAIL

flight 174207 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/174207/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-armhf-armhf-xl-multivcpu 14 guest-start            fail baseline untested


jobs:
 test-armhf-armhf-xl-multivcpu                                fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 16:21:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 16:21:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427830.677267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olulY-0006jt-8I; Fri, 21 Oct 2022 16:21:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427830.677267; Fri, 21 Oct 2022 16:21:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olulY-0006jm-5M; Fri, 21 Oct 2022 16:21:00 +0000
Received: by outflank-mailman (input) for mailman id 427830;
 Fri, 21 Oct 2022 16:20:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNjg=2W=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olulW-0006jg-1i
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 16:20:58 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2074.outbound.protection.outlook.com [40.107.220.74])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 567451af-515c-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 18:20:56 +0200 (CEST)
Received: from BN9PR03CA0472.namprd03.prod.outlook.com (2603:10b6:408:139::27)
 by DM4PR12MB5988.namprd12.prod.outlook.com (2603:10b6:8:6b::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 21 Oct
 2022 16:20:52 +0000
Received: from BN8NAM11FT092.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:139:cafe::c3) by BN9PR03CA0472.outlook.office365.com
 (2603:10b6:408:139::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 16:20:52 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT092.mail.protection.outlook.com (10.13.176.180) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 16:20:52 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 11:20:51 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Fri, 21 Oct 2022 11:20:50 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 567451af-515c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KsE+dxReofOzdV6f/MZG5vWOBCavjGPBJNmPweJxGiefccyTmSWAjSHXhZ0sIwKSR+uYmduwwl5jtBS1jC3iKZuenwFhKHnZcz+eGRVQqyWrkwB0wX5sSQ/YnOv0ePuTw+kmP4txtdX6NlDREwexdQLJLlEvsL+UaZiZhGyKFzK+fdOplRvf9yhmJ99FydhX9IdpKMfAacJmUleuU/sdwWIcwu7qQSwbNKAlnLDY/1lbMPKV5ynGE0zwCRzz8l5edj3hgrfbLkZSrNsxa6jKKuEC7J3bSV2N49Qz7wbDDDRthorUmaskJregyoDo+Mgw0tcPMoLI70zmwGja1dr5nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ODAHQoqaVA/zNiZHnEHhtbbtF5AEf8NrJip2WZhnx+Y=;
 b=bsRP7uFc3Ds4dfcE441RBVLAEsxhIqGkk+IRAO58/pjmOpcIDyVUU5V8E/aPk8PVda6nwan98AFZw+KBdicwAESosgrjQXgGs2of8mbnJezXIYlnA+WB/movWsQbMjZmc9rXxzVBHWV7RoUEF02XZqraHE0VuVveiW3KSqrpS3ThI066HO47N9VA2QtX2v+TdxxzvdANB6IJRGP+BJrbA1Egfa63bdo2G3CFN5KpMnOL2RyNP6+8q4dJAL7LJou8fdlBrRG5C38q9tuwUfx0+OhItNRpxgARGk+NwNUcn2winakp4HVGIBZIub6XfNpy01SyLAzH6/9+r4otuIQFOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ODAHQoqaVA/zNiZHnEHhtbbtF5AEf8NrJip2WZhnx+Y=;
 b=2f1BuOYCFgblbYbTGeUCu0et2ZoZwLwJKxptFX//IbI8IS4xUs1vH8x0TWBjEerlcRfDXaOb4Qq7BxRqkXh0qK2+5cKORQAG1RzGAFFh/Qc621aI8PbLbHYF0itw/lTonvEGM1idDMJEanzaqYnrDu07winkzq+/8RLqYVtkVxo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <b48e5c1e-190d-30eb-fdb8-cde5e4224658@amd.com>
Date: Fri, 21 Oct 2022 18:20:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [for-4.17] automation: Build Xen according to the type of the job
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>
References: <20221021132238.16056-1-michal.orzel@amd.com>
 <9eb64ced-d04a-d406-e1da-86691ba79be6@citrix.com>
 <38c918ee-ee21-8887-f48f-f74e2e0a9862@amd.com>
In-Reply-To: <38c918ee-ee21-8887-f48f-f74e2e0a9862@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT092:EE_|DM4PR12MB5988:EE_
X-MS-Office365-Filtering-Correlation-Id: 748cfdb1-db13-4ad0-b86f-08dab380393f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qwtY7/xyiNH6FGxxnis/G8USgk18tVtnnGsovbIXZqoI3zFhQUjLE2OAkbn13flt8/gsnVbFuiu4MG6OH4Nd59jTKQCGe10LrIVGPxwBH2JDOg1tn2v0CxHnOgouh0fvnHiejCffKiK4nMLzlkQz3FZJphIo/Hkx51Q0uzJoj/qmo9HbYfLJPGca1MpZ3xQuq+irBH36h5l+ikaDbdNYyTI5nnhUcDtNIyDj9Mm3/DmyD3BcWIp0IqSKlm4V40egsKRuY7q6G4smLFDbSoktwkcfmHtPBtsU/3A225894W+T8QkifQVORpLQvcEyO2UDXhC1e9UKzafZ0R9DFDGde+TVkNcUphtBwIY4ZllhqSAd4RbiD88gG3wzueSVWpOQsJwWRUfRG4O2EhUxW+hekMIyu9LSwByvvPXv4rIF2u5qiR54GbFK45naHx10lh+UNSKt0VXywUAFxxNWK8hJgafY4tM3pk+vJnIqfoH4thhGsMmC0bVUM8X/AGSByFesPAIhCwGy/wjK1nRXMMjupq5Vocp7K62mpxV7/oo64guiU+GdUAlA/OjMWRIqX61Ae/lwISdkb1QPkktg0Ww8FDnTUAQ5uX6/p85d4JAdw84eezCZgnkIgH7PpT15gqaS0ZXabbYSeMxDlAdQR1wwkUHA2X78H1INm8VcrMEPgsFULV0q9p0tTVt81MoXCsR60zmrF1vUoi2X4T74k1TNOSFjxMCFHSP94CKwe1FbFyTrhT6tu35eNEOxMp3ZY1uqW7AhoFTrXVun+/VeGzdsyT8J6qWVGHM+bwhTBFbQ5oNirrger8agGTpD7LndI2Gf4y2ZMdqy1RzyoKfKfO0KB0+bnP5gt8e+qbtrV1g0Y98=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(336012)(31696002)(186003)(40460700003)(86362001)(2616005)(83380400001)(82740400003)(81166007)(356005)(40480700001)(82310400005)(36860700001)(8936002)(54906003)(31686004)(110136005)(47076005)(16576012)(316002)(4326008)(70586007)(70206006)(426003)(8676002)(41300700001)(478600001)(53546011)(26005)(45080400002)(5660300002)(44832011)(966005)(2906002)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 16:20:52.3540
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 748cfdb1-db13-4ad0-b86f-08dab380393f
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT092.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5988


On 21/10/2022 16:32, Michal Orzel wrote:
> 
> 
> Hi Andrew,
> 
> On 21/10/2022 15:31, Andrew Cooper wrote:
>>
>>
>> On 21/10/2022 14:22, Michal Orzel wrote:
>>> All the build jobs exist in two flavors: debug and non-debug, where the
>>> former sets 'debug' variable to 'y' and the latter to 'n'. This variable
>>> is only being recognized by the toolstack, because Xen requires
>>> enabling/disabling debug build via e.g. menuconfig/config file.
>>> As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
>>> set to a default value ('y' for unstable and 'n' for stable branches),
>>> regardless of the type of the build job.
>>>
>>> Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>> ---
>>> Xen used debug variable to control the build type before switching to Kconfig.
>>> Support for GitLab CI was added later, which means that this issue was always
>>> present. This is a low risk for 4.17 with a benefit of being able to test Xen
>>> in both debug and non-debug versions.
>>
>> Both series were floating around for ages before being accepted.  It's
>> quite possible that one bitrotted around the other.
>>
>> This should be backported, and therefore should be considered for 4.17
>> at this point.
>>
>> Is there a Gitlab CI run which includes this patch?
> 
> I submitted the one here not long ago:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F673396949&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7Cd091891dbc3a4144356d08dab37120ae%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638019595719666762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=r6qIERShnnovl57xvY%2Fo8eKozAy9NBlqyj0le56ZClY%3D&amp;reserved=0
> 
> and there is already one failure in Arm boot-cpupools test because the script sets null
> scheduler for the domain which is not present in non-debug build...

The CI finished running the pipeline and it looks like the null sched issue is the only one (at least this means that this patch is worth having).
I will push a fix for the boot-cpupools test (I will also mark it as for-4.17).

> 
>>
>> ~Andrew
> 
> ~Michal
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 16:30:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 16:30:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427835.677277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluv6-0008Im-5F; Fri, 21 Oct 2022 16:30:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427835.677277; Fri, 21 Oct 2022 16:30:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oluv6-0008If-2b; Fri, 21 Oct 2022 16:30:52 +0000
Received: by outflank-mailman (input) for mailman id 427835;
 Fri, 21 Oct 2022 16:30:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluv4-0008IV-Ul; Fri, 21 Oct 2022 16:30:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluv4-0006yu-OW; Fri, 21 Oct 2022 16:30:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oluv4-0000wc-9g; Fri, 21 Oct 2022 16:30:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oluv4-0000Fr-9C; Fri, 21 Oct 2022 16:30:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4o/QHJBc//e+wQ6n6NbFF6d4/iSA1BRJvvWq730Xv3M=; b=IUR2wEMXHLnJtK52ZqlI3gD1F0
	BdZMwNTAClIx0XYx8jguO8Oqbostsk8l3eqaApdQUKZ+Y/Kga1XmnCDJh5ZQRtGg1LgXX3esF66N4
	rMbi78KCx5VF3tOcsSmiD7077eifBnY/JXXk+iyZvLiiQ/2RH5/vslHaRK9T3i6YIOzc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174165-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174165: tolerable trouble: fail/pass/starved - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-unstable:build-armhf:hosts-allocate:starved:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0c06760be3dc3f286015e18c4b1d1694e55da026
X-Osstest-Versions-That:
    xen=9029bc265cdf2bd63376dde9fdd91db4ce9c0586
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 16:30:50 +0000

flight 174165 xen-unstable real [real]
flight 174205 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174165/
http://logs.test-lab.xenproject.org/osstest/logs/174205/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-examine-bios  6 xen-install         fail pass in 174205-retest
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 174205-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174133
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174133
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174133
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174133
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174133
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174133
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174133
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174133
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174133
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-examine      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a
 test-arm64-arm64-xl-seattle   3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  0c06760be3dc3f286015e18c4b1d1694e55da026
baseline version:
 xen                  9029bc265cdf2bd63376dde9fdd91db4ce9c0586

Last test of basis   174133  2022-10-20 11:59:00 Z    1 days
Testing same since   174165  2022-10-21 02:14:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
  Borislav Petkov <bp@suse.de>
  Christian Lindig <christian.lindig@citrix.com>
  Daniel P. Smith <dpsmith@apertussolutions.com>
  George Dunlap <george.dunlap@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Julien Grall <jgrall@amazon.com>
  Peter Hoyes <Peter.Hoyes@arm.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>
  Zhang Rui <rui.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     starved 
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  starved 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9029bc265c..0c06760be3  0c06760be3dc3f286015e18c4b1d1694e55da026 -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 16:52:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 16:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427891.677477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvGE-0004l0-A8; Fri, 21 Oct 2022 16:52:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427891.677477; Fri, 21 Oct 2022 16:52:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvGE-0004kt-6t; Fri, 21 Oct 2022 16:52:42 +0000
Received: by outflank-mailman (input) for mailman id 427891;
 Fri, 21 Oct 2022 16:52:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olvGC-0004kn-WD
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 16:52:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olvGC-0007Ul-4V; Fri, 21 Oct 2022 16:52:40 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olvGB-00005l-U1; Fri, 21 Oct 2022 16:52:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=rNAHhd7S3FOCyRv5Y30603mfan5Bm8aHVgUxVRLs5NU=; b=ryRCba2qerdrYzwQ5NY0icA2Qu
	l0pQT5HBqcuWyxTcw4qkJktHNELGdmWQdVwNkuvyYVA1Tn2tSLajJIo+4y1UlM6HeabiGsebtgG0y
	CHJEMWH8EvXNdjqtPbWK2kjS4xYgry8WE30Juey6ckP9QjqGX2G2XCvdf+r1tHIIV+VM=;
Message-ID: <e5144326-2784-0d3a-b7af-453bcf6ac3b1@xen.org>
Date: Fri, 21 Oct 2022 17:52:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 08/12] Revert "xen/arm: setup: Add Xen as boot module
 before printing all boot modules"
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
 george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com,
 wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech,
 lucmiccio@gmail.com, Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-9-carlo.nonato@minervasys.tech>
 <a073d250-ade5-8048-e638-025dcf90ba96@xen.org>
 <CAG+AhRUn6ntUDc1tNqKsGjAn1mNH=hhU1tn6tTLKxF_q5tZNdQ@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CAG+AhRUn6ntUDc1tNqKsGjAn1mNH=hhU1tn6tTLKxF_q5tZNdQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/09/2022 14:54, Carlo Nonato wrote:
> Hi Julien,

Hi Carlo,

> On Sat, Sep 10, 2022 at 4:01 PM Julien Grall <julien@xen.org> wrote: > Do you have any suggestions? Is it ok to add the print to this very patch
> explaining why I added that (since it would edit the clean revert)?

I would consider to the call to early_print_info() after the Xen module 
is created.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 16:53:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 16:53:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427895.677488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvHN-0005HO-Ju; Fri, 21 Oct 2022 16:53:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427895.677488; Fri, 21 Oct 2022 16:53:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvHN-0005HH-GT; Fri, 21 Oct 2022 16:53:53 +0000
Received: by outflank-mailman (input) for mailman id 427895;
 Fri, 21 Oct 2022 16:53:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNjg=2W=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1olvHM-0005H9-Ft
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 16:53:52 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id efb13a76-5160-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 18:53:50 +0200 (CEST)
Received: from BN9PR03CA0612.namprd03.prod.outlook.com (2603:10b6:408:106::17)
 by BY5PR12MB4935.namprd12.prod.outlook.com (2603:10b6:a03:1d9::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Fri, 21 Oct
 2022 16:53:45 +0000
Received: from BN8NAM11FT012.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:106:cafe::ba) by BN9PR03CA0612.outlook.office365.com
 (2603:10b6:408:106::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Fri, 21 Oct 2022 16:53:45 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT012.mail.protection.outlook.com (10.13.177.55) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Fri, 21 Oct 2022 16:53:44 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 11:53:44 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 21 Oct
 2022 11:53:43 -0500
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 21 Oct 2022 11:53:42 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: efb13a76-5160-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S4Skq+tL9ZrTeaWtwvK2Wai7pV/XJXb2ufOYnA7caGBL2jpP7N/79CRpVGF7alycepzvP1KF1vgDTrMY+8x0nRUwMx6y9GNSXqAkhI7lE6tWlByJlOBfwh1ZBR8Nf0gYWEtNKlfpKFazkOHu/JNI5bStxV7X7ytT8YqQCG6ZI/MGKo78Y5iHt4/TK2uvAh4cJ4gxdUeji6c32vlN+dNaqFlKSU58gZ+wwNIgEwC+sjM7ZEYipaONaGu/0C4/mFPDR7pa3qpvJ1mdbGb1n/yvV9my6E2erd8XxNKKpItgxJRvQBbOVEPqmCtdTLlBg7iYGzCOeYtqrcFp+O0PkKGwag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fIPnwdLEH/hxki/6fg7zi/AAYz+XnzsGm7q1VuCQFho=;
 b=iKn4sEtXE8sPWK5+cYJ73xBAb5LMG9k+c6kR9qKop6t26KJKpva25USEuGnZ2bD2aIZc6f6AqKLmdx0d4CJOf4Ac7zJZabqyHccgB5B5gHZFWvY45oU2tjQZ03P0pnkj7yXNiPEGUpbXq5KuTSJrJ9AW58ir8HYJ7DGlDogJKy5ginjR98FpgE/kZGodj9j4edAyq8w5yIVHplePy8ZVwqm+VS46OuU3DT1pTzTX/b1k7xyDt3Jagz80AyzjUHt4iYnJ02Scb/ryJJzKUCI5H0PKw/4JBtzKA+Vn5LUUKNPxLnT62/2HAMpFC+mvuqz6EXXhAzJUX3fiq7HN+Etpew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fIPnwdLEH/hxki/6fg7zi/AAYz+XnzsGm7q1VuCQFho=;
 b=JXl8sFEAfPiF2TjsvmbgYrytwXEp3tbdJJNK1aHJ5e9nmnnd2+VUB463LWDCgsWYf/Xsf/5lucFn69BE0NTA6F8WWJs3MMwLDhCwRLaNNwB8xAnJdSqbyK3GnxSJGaQmfAjOHPL6UaI8N7e2GxOxdYWv8JSHlfdkGI0HTNnbBug=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>
Subject: [for-4.17] automation: Do not use null scheduler for boot cpupools test
Date: Fri, 21 Oct 2022 18:53:41 +0200
Message-ID: <20221021165341.7905-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT012:EE_|BY5PR12MB4935:EE_
X-MS-Office365-Filtering-Correlation-Id: b312ccd4-e500-4d9e-2dd2-08dab384d0f8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jCDW35/ggetLjIewtb6FOnPBKLHv+73HSvSJ5cTzjuuqgnbSgXZ8u8R39OjELcy69dnHCGJG8cY6AiaKT6kPVAlTyU8vAcgwzhVQkRjSYyaBYZXSMMlGkH5slgxr3Ev3QZpmGov0yBzhKST6d7lOZzVcBgnp2lnMDC+lzv/Xlpcby2JY6FfRlhtvIQJVm1H3LHPyLO332fzSyj8SkVrmvFB2PCE15PUbYjToIkzhn251w503aLbkz0zgSknnVp4KpaIpkDYZSVt0s47QQ58mQr0cxEhbBAIxqGI0FNXkp89/V9+DR8L4d4AMWZy7rAJXoAEIJ0Mbup/UPvTbE+6tvmYx9C96+3C7vUJh7XjU1ryBgq1yT50bMpLsTS7JjEAfyBRP8/65WfNoTgTjHhmVCeFYofZLhIwz5Q2Y3/8G0EWAn3KRuXz5ZN3GuM3+edTkMVwQEa/2n9exh76itb9+dsGzAUIKBzrRjv9JLMcF5fLEFUTZVYZRKndmoAjFbMc+w3OJqPeXG1yKeAp1zZRH7oFNYfyOZ/FwjVJuNk+uwY4ajzc/qJgn/T5WGFhZXqxR0XcxWz5zLB4xaLn/Qwd6w9wDifAVqJ90M+eVXj95mWfYqGlfPMqesnbPxN/nf6bRc4hCp+eB8FLaaZZI7AOZrgPu8WEFB63gb7igFnIPZQe5DCk2L70qxGYaqTH1IYkZpR1vqEwetPD1r0BQn9l7yIAWrEPpLImQHMrxlkAaLWT+bz9HlBO2ECmoxObZfXcOPVvKc00/dTqOvjqYrSqwOK1PhSeM9P/ypxkZfWkE8yh3AXctqxR4Sjth1+3S5oCGLiChOKmli4ZHZ0Io/kdthQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(5660300002)(478600001)(54906003)(316002)(44832011)(8676002)(6916009)(4326008)(26005)(186003)(336012)(1076003)(2906002)(966005)(2616005)(41300700001)(8936002)(82310400005)(356005)(82740400003)(426003)(47076005)(40460700003)(36756003)(36860700001)(70586007)(83380400001)(70206006)(81166007)(86362001)(40480700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 16:53:44.8858
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b312ccd4-e500-4d9e-2dd2-08dab384d0f8
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT012.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4935

Null scheduler is not enabled on non-debug Xen builds so the current
test can lead to a failure on such jobs. We still want to test that we
can assign the cpupool to a domU with a different scheduler than default
one (credit2). Switch to credit as it is enabled by default.

Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
This patch acts as a prerequisite before merging the following patch:
https://lore.kernel.org/xen-devel/20221021132238.16056-1-michal.orzel@amd.com/
(to which Henry already gave RAB), that helped to find the issue described
in the comment.
---
 automation/scripts/qemu-smoke-arm64.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh
index 5b566072f72a..a5d8d135b659 100755
--- a/automation/scripts/qemu-smoke-arm64.sh
+++ b/automation/scripts/qemu-smoke-arm64.sh
@@ -29,10 +29,10 @@ fi
 fi
 
 if [[ "${test_variant}" == "boot-cpupools" ]]; then
-    # Check if domU0 (id=1) is assigned to Pool-1 with null scheduler
+    # Check if domU0 (id=1) is assigned to Pool-1 with credit scheduler
     passed="${test_variant} test passed"
     dom0_check="
-if xl list -c 1 | grep -q Pool-1 && xl cpupool-list Pool-1 | grep -q Pool-1; then
+if xl list -c 1 | grep -q Pool-1 && xl cpupool-list Pool-1 | grep -q credit; then
     echo ${passed}
 fi
 "
@@ -140,7 +140,7 @@ fi
 
 if [[ "${test_variant}" == "boot-cpupools" ]]; then
     echo '
-CPUPOOL[0]="cpu@1 null"
+CPUPOOL[0]="cpu@1 credit"
 DOMU_CPUPOOL[0]=0
 NUM_CPUPOOLS=1' >> binaries/config
 fi
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 17:14:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 17:14:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427904.677505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvbi-00085I-CV; Fri, 21 Oct 2022 17:14:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427904.677505; Fri, 21 Oct 2022 17:14:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvbi-00085B-9o; Fri, 21 Oct 2022 17:14:54 +0000
Received: by outflank-mailman (input) for mailman id 427904;
 Fri, 21 Oct 2022 17:14:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olvbg-000853-J2
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 17:14:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olvbf-0007s3-Vd; Fri, 21 Oct 2022 17:14:51 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olvbf-0003OK-JC; Fri, 21 Oct 2022 17:14:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0uAdr35mhRY7TqWTg9FZFmGhMRUKSR6/4j/lfC7n9AE=; b=ohPfqAgUMhLyMb/KFpZXOx590Q
	URuW3VpiH2mMdaRO+la/oQPLC2GKXx/xDr01a40lKmxqMOJNP0jmQwNXQAV8rs/DkatEksFMpbZTJ
	CLIqRGeSn6B1zf/aQ/mioKuh57DQes9c83aKdEsiDGpvXIZ6Ifhr3LyD8MCn3EIY9WGU=;
Message-ID: <08956082-c194-8bae-cb25-44e4e3227689@xen.org>
Date: Fri, 21 Oct 2022 18:14:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 01/12] xen/arm: add cache coloring initialization
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-2-carlo.nonato@minervasys.tech>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220826125111.152261-2-carlo.nonato@minervasys.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Carlo,

On 26/08/2022 13:51, Carlo Nonato wrote:
> This commit adds the cache coloring support initialization, Kconfig options,
> command line parameters and the initial documentation.
> The initialization consists of an auto probing of the cache layout
> necessary to retrieve the LLC way size which is used to compute the
> number of available colors. The Dom0 colors are then initialized with default
> colors (all available ones) if not provided from the command line, and
> they are checked for bad configuration.
> 
> It also adds a debug-key to dump general cache coloring info.
> This includes LLC way size, total available colors and the mask used to
> extract colors from physical addresses.
> 
> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> ---
>   docs/misc/arm/cache-coloring.rst     | 112 ++++++++++++++
>   docs/misc/xen-command-line.pandoc    |  22 +++
>   xen/arch/arm/Kconfig                 |  16 ++
>   xen/arch/arm/Makefile                |   1 +
>   xen/arch/arm/coloring.c              | 222 +++++++++++++++++++++++++++
>   xen/arch/arm/include/asm/coloring.h  |  31 ++++
>   xen/arch/arm/include/asm/processor.h |  16 ++
>   xen/arch/arm/setup.c                 |   8 +
>   8 files changed, 428 insertions(+)
>   create mode 100644 docs/misc/arm/cache-coloring.rst
>   create mode 100644 xen/arch/arm/coloring.c
>   create mode 100644 xen/arch/arm/include/asm/coloring.h
> 
> diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
> new file mode 100644
> index 0000000000..c7adcb0f1f
> --- /dev/null
> +++ b/docs/misc/arm/cache-coloring.rst
> @@ -0,0 +1,112 @@
> +Xen cache coloring user guide
> +=============================
> +
> +The cache coloring support in Xen allows to reserve Last Level Cache (LLC)
> +partition for Dom0, DomUs and Xen itself. Currently only ARM64 is supported.
> +
> +In order to enable and use it, few steps are needed.
> +
> +- Enable cache coloring in Xen configuration file.
> +
> +        CONFIG_CACHE_COLORING=y
> +- If needed, change the maximum number of colors in Xen configuration file
> +  (refer to menuconfig help for value meaning and when it should be changed).
> +
> +        CONFIG_MAX_CACHE_COLORS=<n>
> +- Assign colors to Dom0 using the `Color selection format`_ (see
> +  `Coloring parameters`_ for more documentation pointers).
> +
> +Background
> +**********
> +
> +Cache hierarchy of a modern multi-core CPU typically has first levels dedicated
> +to each core (hence using multiple cache units), while the last level is shared
> +among all of them. Such configuration implies that memory operations on one
> +core (e.g. running a DomU) are able to generate interference on another core
> +(e.g .hosting another DomU). Cache coloring allows eliminating this
> +mutual interference, and thus guaranteeing higher and more predictable
> +performances for memory accesses.
> +The key concept underlying cache coloring is a fragmentation of the memory
> +space into a set of sub-spaces called colors that are mapped to disjoint cache
> +partitions. Technically, the whole memory space is first divided into a number
> +of subsequent regions. Then each region is in turn divided into a number of
> +subsequent sub-colors. The generic i-th color is then obtained by all the
> +i-th sub-colors in each region.
> +
> +.. raw:: html
> +
> +    <pre>
> +                            Region j            Region j+1
> +                .....................   ............
> +                .                     . .
> +                .                       .
> +            _ _ _______________ _ _____________________ _ _
> +                |     |     |     |     |     |     |
> +                | c_0 | c_1 |     | c_n | c_0 | c_1 |
> +           _ _ _|_____|_____|_ _ _|_____|_____|_____|_ _ _
> +                    :                       :
> +                    :                       :...         ... .
> +                    :                            color 0
> +                    :...........................         ... .
> +                                                :
> +          . . ..................................:
> +    </pre>
> +
> +There are two pragmatic lesson to be learnt.
> +
> +1. If one wants to avoid cache interference between two domains, different
> +   colors needs to be used for their memory.
> +
> +2. Color assignment must privilege contiguity in the partitioning. E.g.,
> +   assigning colors (0,1) to domain I  and (2,3) to domain  J is better than
> +   assigning colors (0,2) to I and (1,3) to J.
> +
> +How to compute the number of colors
> +***********************************
> +
> +To compute the number of available colors for a specific platform, the size of
> +a LLC way and the page size used by Xen must be known. The first parameter can
> +be found in the processor manual or can be also computed dividing the total
> +cache size by the number of its ways. The second parameter is the minimum amount
> +of memory that can be mapped by the hypervisor, thus dividing the way size by
> +the page size, the number of total cache partitions is found. So for example,
> +an Arm Cortex-A53 with a 16-ways associative 1 MiB LLC, can isolate up to 16
> +colors when pages are 4 KiB in size.
> +
> +Cache layout is probed automatically by Xen itself, but a possibility to
> +manually set the way size it's left to the user to overcome failing situations
> +or for debugging/testing purposes. See `Coloring parameters`_ section for more
> +information on that.
> +
> +Colors selection format
> +***********************
> +
> +Regardless of the memory pool that has to be colored (Xen, Dom0/DomUs),
> +the color selection can be expressed using the same syntax. In particular a
> +comma-separated list of colors or ranges of colors is used.
> +Ranges are hyphen-separated intervals (such as `0-4`) and are inclusive on both
> +sides.
> +
> +Note that:
> + - no spaces are allowed between values.
> + - no overlapping ranges or duplicated colors are allowed.
> + - values must be written in ascending order.
> +
> +Examples:
> +
> ++---------------------+-----------------------------------+
> +|**Configuration**    |**Actual selection**               |
> ++---------------------+-----------------------------------+
> +|  1-2,5-8            | [1, 2, 5, 6, 7, 8]                |
> ++---------------------+-----------------------------------+
> +|  4-8,10,11,12       | [4, 5, 6, 7, 8, 10, 11, 12]       |
> ++---------------------+-----------------------------------+
> +|  0                  | [0]                               |
> ++---------------------+-----------------------------------+
> +
> +Coloring parameters
> +*******************
> +
> +LLC way size (as previously discussed) and Dom0 colors can be set using the
> +appropriate command line parameters. See the relevant documentation in
> +"docs/misc/xen-command-line.pandoc".
> \ No newline at end of file
> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
> index 9a79385a37..910ebeb2eb 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -889,6 +889,14 @@ Controls for the dom0 IOMMU setup.
>   
>       Incorrect use of this option may result in a malfunctioning system.
>   
> +### dom0-colors (arm64)
> +> `= List of [ <integer> | <integer>-<integer> ]`
> +
> +> Default: `All available colors`
> +
> +Specify dom0 color configuration. If the parameter is not set, all available
> +colors are chosen and the user is warned on Xen's serial console.
> +
>   ### dom0_ioports_disable (x86)
>   > `= List of <hex>-<hex>`
>   
> @@ -1631,6 +1639,20 @@ This option is intended for debugging purposes only.  Enable MSR_DEBUGCTL.LBR
>   in hypervisor context to be able to dump the Last Interrupt/Exception To/From
>   record with other registers.
>   
> +### llc-way-size (arm64)
> +> `= <size>`
> +
> +> Default: `Obtained from the hardware`
> +
> +Specify the way size of the Last Level Cache. This parameter is only useful with
> +cache coloring support enabled. It is an optional, expert-only parameter and it
> +is used to calculate the number of available colors on the platform. It can be
> +obtained by dividing the total LLC size by the number of its associative ways.
> +By default, the value is automatically computed by probing the hardware, but in
> +case of specific needs, it can be manually set. Those include failing probing
> +and debugging/testing purposes so that it's possibile to emulate platforms with
> +different number of supported colors.
> +
>   ### loglvl
>   > `= <level>[/<rate-limited level>]` where level is `none | error | warning | info | debug | all`
>   
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 33e004d702..8acff9682c 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -131,6 +131,22 @@ config ARM64_BTI
>   	  Branch Target Identification support.
>   	  This feature is not supported in Xen.
>   
> +config CACHE_COLORING
> +	bool "Last Level Cache (LLC) coloring" if EXPERT
> +	default n
> +	depends on ARM_64
> +
> +config MAX_CACHE_COLORS
> +	int "Maximum number of cache colors"
> +	default 128
> +	range 0 65536
> +	depends on CACHE_COLORING
> +	help
> +	  This config value is an upper bound for the actual number of cache colors
> +	  supported by the architecture. Xen preallocates this amount of cache
> +	  colors at boot. Note that if, at any time, a color configuration with more
> +	  colors than the maximum will be employed an error will be produced.
> +
>   config TEE
>   	bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED
>   	default n
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 4d076b278b..12940ba761 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -67,6 +67,7 @@ obj-$(CONFIG_SBSA_VUART_CONSOLE) += vpl011.o
>   obj-y += vsmc.o
>   obj-y += vpsci.o
>   obj-y += vuart.o
> +obj-$(CONFIG_CACHE_COLORING) += coloring.o

The Makefile should be ordered alphabetically based on the filename. So 
please move this to correct position.

>   
>   extra-y += xen.lds
>   
> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
> new file mode 100644
> index 0000000000..c010ebc01b
> --- /dev/null
> +++ b/xen/arch/arm/coloring.c
> @@ -0,0 +1,222 @@
> +/*
> + * xen/arch/arm/coloring.c
> + *
> + * Coloring support for ARM
> + *
> + * Copyright (C) 2019 Xilinx Inc.
> + *
> + * Authors:
> + *    Luca Miccio <lucmiccio@gmail.com>
> + *    Carlo Nonato <carlo.nonato@minervasys.tech>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +#include <xen/errno.h>
> +#include <xen/keyhandler.h>
> +#include <xen/param.h>
> +#include <xen/types.h>
> +
> +#include <asm/coloring.h>
> +#include <asm/processor.h>
> +#include <asm/sysregs.h>
> +
> +/* Size of a LLC way */
> +static unsigned int llc_way_size;
> +/* Number of colors available in the LLC */
> +static unsigned int max_colors;
> +/* Mask to retrieve coloring relevant bits */
> +static uint64_t addr_col_mask;

IIUC, this is meant to be applied on a host physical address. If so, 
please use 'paddr_t' rather than uint64_t. Same below.

> +
> +#define addr_to_color(addr) (((addr) & addr_col_mask) >> PAGE_SHIFT)
> +#define addr_set_color(addr, color) (((addr) & ~addr_col_mask) \
> +                                     | ((color) << PAGE_SHIFT))

I don't see any use of addr_to_color() and addr_set_color() below. So it 
is not clear to me what is the type of 'color'. This may need to be 
casted to (paddr_t).

But as the helpers are quite small, it would be better to introduce the 
macros where they are used.

> +
> +static unsigned int dom0_colors[CONFIG_MAX_CACHE_COLORS];
> +static unsigned int dom0_num_colors;
> +
> +/*
> + * Parse the coloring configuration given in the buf string, following the
> + * syntax below.
> + *
> + * COLOR_CONFIGURATION ::= COLOR | RANGE,...,COLOR | RANGE
> + * RANGE               ::= COLOR-COLOR
> + *
> + * Example: "0,2-6,15-16" represents the set of colors: 0,2,3,4,5,6,15,16.
> + */
> +static int parse_color_config(const char *buf, unsigned int *colors,
> +                              unsigned int *num_colors)
> +{
> +    const char *s = buf;
> +
> +    if ( !colors || !num_colors )
> +        return -EINVAL;
> +
> +    while ( *s != '\0' )
> +    {
> +        if ( *s != ',' )
> +        {
> +            unsigned int color, start, end;
> +
> +            start = simple_strtoul(s, &s, 0);
> +
> +            if ( *s == '-' )    /* Range */
> +            {
> +                s++;
> +                end = simple_strtoul(s, &s, 0);
> +            }
> +            else                /* Single value */
> +                end = start;
> +
> +            if ( start > end ||
> +                 *num_colors + end - start >= CONFIG_MAX_CACHE_COLORS )

In theory, *num_colors + end - start could overflow. I would also check 
that given you are sanity checking the values.

Lastly, may I ask to surround *num_colors + end - start with ()? This 
would make easier to read.

> +                return -EINVAL;
> +            for ( color = start; color <= end; color++ )
> +                colors[(*num_colors)++] = color;
> +        }
> +        else
> +            s++;
> +    }
> +
> +    return *s ? -EINVAL : 0;
> +}
> +
> +size_param("llc-way-size", llc_way_size);
> +
> +static int __init parse_dom0_colors(const char *s)
> +{
> +    return parse_color_config(s, dom0_colors, &dom0_num_colors);
> +}
> +custom_param("dom0-colors", parse_dom0_colors);
> +
> +/* Return the LLC way size by probing the hardware */
> +static unsigned int get_llc_way_size(void)
> +{
> +    register_t ccsidr_el1;
> +    register_t clidr_el1 = READ_SYSREG(CLIDR_EL1);
> +    register_t csselr_el1 = READ_SYSREG(CSSELR_EL1);
> +    register_t id_aa64mmfr2_el1 = READ_SYSREG(ID_AA64MMFR2_EL1);
> +    uint32_t ccsidr_numsets_shift = CCSIDR_NUMSETS_SHIFT;
> +    uint32_t ccsidr_numsets_mask = CCSIDR_NUMSETS_MASK;
> +    unsigned int n, line_size, num_sets;
> +
> +    for ( n = CLIDR_CTYPEn_LEVELS;
> +          n != 0 && !((clidr_el1 >> CLIDR_CTYPEn_SHIFT(n)) & CLIDR_CTYPEn_MASK);
> +          n-- );
> +
> +    if ( n == 0 )
> +        return 0;
> +
> +    WRITE_SYSREG(((n - 1) & CCSELR_LEVEL_MASK) << CCSELR_LEVEL_SHIFT,
> +                 CSSELR_EL1);
> +    isb();
> +
> +    ccsidr_el1 = READ_SYSREG(CCSIDR_EL1);
> +
> +    /* Arm ARM: (Log2(Number of bytes in cache line)) - 4 */
> +    line_size = 1 << ((ccsidr_el1 & CCSIDR_LINESIZE_MASK) + 4);
> +
> +    /* If FEAT_CCIDX is enabled, CCSIDR_EL1 has a different bit layout */
> +    if ( (id_aa64mmfr2_el1 >> ID_AA64MMFR2_CCIDX_SHIFT) & 0x7 )
> +    {
> +        ccsidr_numsets_shift = CCSIDR_NUMSETS_SHIFT_FEAT_CCIDX;
> +        ccsidr_numsets_mask = CCSIDR_NUMSETS_MASK_FEAT_CCIDX;
> +    }
> +    /* Arm ARM: (Number of sets in cache) - 1 */
> +    num_sets = ((ccsidr_el1 >> ccsidr_numsets_shift) & ccsidr_numsets_mask) + 1;
> +
> +    printk(XENLOG_INFO "LLC found: L%u (line size: %u bytes, sets num: %u)\n",
> +           n, line_size, num_sets);
> +
> +    /* Restore value in CSSELR_EL1 */
> +    WRITE_SYSREG(csselr_el1, CSSELR_EL1);
> +    isb();
> +
> +    return line_size * num_sets;
> +}
> +
> +static bool check_colors(unsigned int *colors, unsigned int num_colors)
> +{
> +    int i;

i should not be signed. So please use "unsigned int".

> +
> +    if ( num_colors > max_colors )
> +        return false;
> +
> +    for ( i = 0; i < num_colors; i++ )
> +        if ( colors[i] >= max_colors )
> +            return false;
> +
> +    return true;
> +}
> +
> +static unsigned int set_default_domain_colors(unsigned int *colors)
> +{
> +    unsigned int i;
> +
> +    if ( !colors )
> +        return 0;
I find a bit odd that we return 0 if 'colors' is NULL. In what situation 
do you expect 'colors' to be NULL? Is this a programming error?

> + > +    for ( i = 0; i < max_colors; i++ )
> +        colors[i] = i;

Coding style: Newline please.

> +    return max_colors;
> +}
> +
> +static void dump_coloring_info(unsigned char key)
> +{
> +    printk("'%c' pressed -> dumping coloring general info\n", key);
> +    printk("LLC way size: %u KiB\n", llc_way_size >> 10);
> +    printk("Number of LLC colors supported: %u\n", max_colors);
> +    printk("Address color mask: 0x%lx\n", addr_col_mask);
> +}
> +
> +bool __init coloring_init(void)
> +{
> +    if ( !llc_way_size && !(llc_way_size = get_llc_way_size()) )
> +    {
> +        printk(XENLOG_ERR
> +               "Probed LLC way size is 0 and no custom value provided\n");
> +        return false;
> +    }
> +
> +    max_colors = llc_way_size / PAGE_SIZE;
> +    /* The maximum number of colors must be a power of 2 in order to correctly
> +       map colors to bits of an address. */
> +    ASSERT((max_colors & (max_colors - 1)) == 0);
> +    addr_col_mask = (max_colors - 1) << PAGE_SHIFT;
> +
> +    if ( !dom0_num_colors )
> +    {
> +        printk(XENLOG_WARNING
> +               "Dom0 color config not found. Using default (all colors)\n");
> +        dom0_num_colors = set_default_domain_colors(dom0_colors);
> +    }
> +
> +    if ( !check_colors(dom0_colors, dom0_num_colors) )
> +    {
> +        printk(XENLOG_ERR "Bad color config for Dom0\n");
> +        return false;
> +    }
> +
> +    register_keyhandler('K', dump_coloring_info, "dump coloring info", 1);
> +
> +    return true;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
> new file mode 100644
> index 0000000000..dd7eff5f07
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/coloring.h
> @@ -0,0 +1,31 @@
> +/*
> + * xen/arm/include/asm/coloring.h
> + *
> + * Coloring support for ARM
> + *
> + * Copyright (C) 2019 Xilinx Inc.
> + *
> + * Authors:
> + *    Luca Miccio <lucmiccio@gmail.com>
> + *    Carlo Nonato <carlo.nonato@minervasys.tech>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +#ifndef __ASM_ARM_COLORING_H__
> +#define __ASM_ARM_COLORING_H__
> +
> +#include <xen/init.h>
> +
> +bool __init coloring_init(void);
> +
> +#endif /* !__ASM_ARM_COLORING_H__ */

Missing emags magic as you added in coloring.c.

> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
> index 1dd81d7d52..85ff0caf1e 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -18,6 +18,22 @@
>   #define CTR_IDC_SHIFT       28
>   #define CTR_DIC_SHIFT       29
>   
> +/* CCSIDR Current Cache Size ID Register */
> +#define CCSIDR_LINESIZE_MASK            0x7
> +#define CCSIDR_NUMSETS_SHIFT            13
> +#define CCSIDR_NUMSETS_MASK             0x3FFF
> +#define CCSIDR_NUMSETS_SHIFT_FEAT_CCIDX 32
> +#define CCSIDR_NUMSETS_MASK_FEAT_CCIDX  0xFFFFFF

Please use ULL here otherwise someone using MASK << SHIFT will have the 
expected result.

My preference would be that all the MASK should have the same type. So 
this is easier to spot any mistake.

> +
> +/* CCSELR Cache Size Selection Register */
> +#define CCSELR_LEVEL_MASK  0x7
> +#define CCSELR_LEVEL_SHIFT 1
> +
> +/* CLIDR Cache Level ID Register */
> +#define CLIDR_CTYPEn_SHIFT(n) (3 * (n - 1))
> +#define CLIDR_CTYPEn_MASK     0x7
> +#define CLIDR_CTYPEn_LEVELS   7
> +
>   #define ICACHE_POLICY_VPIPT  0
>   #define ICACHE_POLICY_AIVIVT 1
>   #define ICACHE_POLICY_VIPT   2
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 500307edc0..c02f21c0e6 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -53,6 +53,9 @@
>   #include <asm/setup.h>
>   #include <xsm/xsm.h>
>   #include <asm/acpi.h>
> +#ifdef CONFIG_CACHE_COLORING
> +#include <asm/coloring.h>
> +#endif

I would rather prefer if the #ifdef are moved in the header. So...

>   
>   struct bootinfo __initdata bootinfo;
>   
> @@ -930,6 +933,11 @@ void __init start_xen(unsigned long boot_phys_offset,
>       printk("Command line: %s\n", cmdline);
>       cmdline_parse(cmdline);
>   
> +#ifdef CONFIG_CACHE_COLORING
> +    if ( !coloring_init() )

... a stub for coloring_init() is provided and we avoid sprinkling the 
common code with #ifdef.

> +        panic("Xen Coloring support: setup failed\n");
> +#endif
> +
>       setup_mm();
>   
>       /* Parse the ACPI tables for possible boot-time configuration */

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 17:21:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 17:21:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427910.677516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvhv-0001HJ-8D; Fri, 21 Oct 2022 17:21:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427910.677516; Fri, 21 Oct 2022 17:21:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvhv-0001HC-5L; Fri, 21 Oct 2022 17:21:19 +0000
Received: by outflank-mailman (input) for mailman id 427910;
 Fri, 21 Oct 2022 17:21:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1mzs=2W=citrix.com=prvs=28632f022=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olvht-0001H4-C3
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 17:21:17 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c36367fc-5164-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 19:21:15 +0200 (CEST)
Received: from mail-sn1anam02lp2042.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 13:21:12 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BLAPR03MB5603.namprd03.prod.outlook.com (2603:10b6:208:29b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 21 Oct
 2022 17:21:09 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 17:21:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c36367fc-5164-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666372875;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=jjfyHLihhuhnu/YJf6pwiYxfMAD85K4XcXo40A5JsQ8=;
  b=NH8Emrsnn3tLMue6a6+ot6LzzcwRNuXHAtAi6H4N348XLV6OHqIaH9CZ
   Spp+JshpXnP1CXbYhgY7tLSi19aHm7B3ItC98WBtO4olWG829ZTXyj+V7
   j17OvJDmV9SBRyEb10kGlr4rWi7ABqqJGc7z5yhfX0OdnziJGPjDZs60k
   k=;
X-IronPort-RemoteIP: 104.47.57.42
X-IronPort-MID: 83689072
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:z4gSM6OVlx7MsrfvrR15lsFynXyQoLVcMsEvi/4bfWQNrUp01jFRx
 2IXXWDUOanZM2H8fot+Ooqw9hlU7MWGz9NhGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo4WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eYqtJx+0rIj1y+
 McZdB1XSTCMicCX6efuIgVsrpxLwMjDGqo64isl9heASPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTJ/8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toiny1r6XwnmTtIQ6E7q/z/pD3gSqn3EoGUdKf0OU+Ou+oxvrMz5YA
 wlOksY0loA39UerR927WAeqrXqstxsQHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3
 UPPmMnmbRRkuaeZTn+1/b6OoTS/fyMSKAcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdOTz22
 SHMkyE4iJ0al8tN3KK+lW0rmBqpr5nNCxUzvwzRV2f9tAdhPtb5Pcqv9ETR6utGIMCBVF6ds
 XMYms+YqucTEZWKky/LS+IIdF2028u43PTnqQYHN/EcG/6FoRZPoag4DOlCGXpU
IronPort-HdrOrdr: A9a23:EON/w6y53H0jiXQAKWjYKrPxj+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD
 AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo
 SOBK4=
X-IronPort-AV: E=Sophos;i="5.95,202,1661832000"; 
   d="scan'208";a="83689072"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jP09fAKJwSSl2rdD0bgqt9s3vTzLe9q/ODTPOGDr1XfDvuoSYMgZ4VWM20WT4P7oONiRw/+aIE4wOteRWVzVIFX++rSJ1OfmHCdH3gHUXx4HAomt0lZoOhLAh5PbJhjiNzIwg/UYnf/Cmo8/QxZbvwaVlKX/FZnhF8llKf6tg5C2HZtXfT8N7UG6ExNEdPviDCsJgSX+1fJ69efZFzEkShLkiOcq9zNE41CEewztEe1L9dOh5O2koQCLlqWEMjcSRnN8wMENpC/Kh2AoUBbR1IgbsrARLJf2rjYL7gAFCzja6152ombrj60qaXf2sGb2Hd7efu5yD6nkIsVG8/3deA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jjfyHLihhuhnu/YJf6pwiYxfMAD85K4XcXo40A5JsQ8=;
 b=S+swa9xcN/P2hPNFNrg41j0ogfm3jdL+D28OtNYRiK0wLbjQOFY5nUgAlMldQLJi2rcKrQOMqu/4Wn5les+CUYvx4/hKKMTY9twRtdvy0sl11wlZPNAPJNwBNIant5szNpIcPe+xBjr6v2LSYhkrfE8aeyU3gtC8dlpaCud45depq7D6JYK4yhPHJ0ZWuQ4SWfAbzyugnKWtcH++FzyoUxFOe6/H1fBUTv9/eItk4ciUuvasE/kMDs9l5Lwnh0XcbOXNpTNLyvP2joS+3s0MhhjU80wumU3HUEUFfqwSLaWZfgwajzA8cf1JkWWuQq+178YkmgRKVuH8EPKijeAztA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jjfyHLihhuhnu/YJf6pwiYxfMAD85K4XcXo40A5JsQ8=;
 b=aAa6ElXzGpmPtzNMWKKLF7tx1wW+oxpTmlVvbZKFevS+GRIaNSQNG/OX+0hV8+E8tm7IqAiKLXKI3Txw5SWGvkhgiMXQwVfDPwLT+e87yZVS14+KOHO/cM/JDvxKWsiWpz5z11//eFDoIB2NGlpXspoUHmgC8/9BWlTE/AIbvkI=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Michal Orzel <michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
Thread-Topic: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
Thread-Index: AQHY5W3J3NgQRSiY5kiY+kL0DoKe0q4ZGCaA
Date: Fri, 21 Oct 2022 17:21:09 +0000
Message-ID: <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
References: <20221021165341.7905-1-michal.orzel@amd.com>
In-Reply-To: <20221021165341.7905-1-michal.orzel@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5603:EE_
x-ms-office365-filtering-correlation-id: 7a78b67d-1de2-479b-eb83-08dab388a4f3
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 XytZRB4LdxX0Sqm6rl4paZBJ6kBNiyF4qlI823/83xV/AIkiRLtywPRURx3D3VllpvbEnhcq8Vb0PM2RjB/fw6ykRNx39597Ymch4+McyGk7jXqrLzPc1fpCcrsV4kt3Gu0KnzvO+66jsSOKQtIAyCV0abPDNUzeWnPNr92sifeqUD6v0rLNJG21Os2Io8+PN8YKLfV/+MXY3Uz9k+QvjRKMH+UJsMIpJaMekbpp78R/qdsORCO9cfbmzOPv3DLVhwicCVG/HJDoQ1spwRSFHJYCk+cu24wMdg8aiS8ehN+i4ouBUhoJ3M3hVPIT8fZhV0YF8B9xfnTarxzilNMoZNjxtgkp4pGPGUdFRgCQtT4kcOqywMUCguWO1ntzclo5aV6ZfH4OuXXdFcdW9RsXVwZDJyUQ052DcmlU5XJqvMgWKNIB7XJUcBSkbLlSIZsA0mc3M8Z2d3tkOfrkuTRySUDR15bMP/wQDbn2VILrQK4TxXYLIys7EzXQHduTc4FMuNKCjSLfQhrnGER940nDnsCD/elxAnckhhLA9SaGd9gYiL54tmx7Om1n7i32zK9ROlv3bnf75l91ijOGIS0neCXFX/q+OJCkiuOyzJAK/z2jCF+6uhTV+vnLKlPkEcTp91rtn4VDYyZUfpUXc/xsRu10UwfbAqAZhHh2BPyHxKWte3CgzLGcqkAQZWl37B8wA1Sk1+bfbm6IsCtQIIiDkuuHlDKCCk6AggEedUjgNfd2/78GRk/tjnlv7HMiz6aWtUDOMB/OWTW5umuxTtcoxyotuwJ7l3mRVw24Q1Am9pyCb1woIMJVgb6v+gPKARAf6McjuUkxNxLjPwFEo0zU8Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199015)(478600001)(122000001)(38070700005)(6486002)(31686004)(71200400001)(54906003)(316002)(91956017)(8676002)(6512007)(64756008)(76116006)(66946007)(6506007)(5660300002)(66556008)(66476007)(66446008)(4326008)(53546011)(36756003)(41300700001)(26005)(8936002)(2906002)(83380400001)(31696002)(2616005)(38100700002)(186003)(82960400001)(110136005)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?WTZCdWtVUVhoUXFVZ0ZZTkh2YWR3NjJTMUROR0RiRFhzTk9iSUR4KzJVVlpm?=
 =?utf-8?B?Vk1YdE45UnlYS1c0Tm1EaUlseWRsd1dudFVZb25nUjYvQldKOXVlQmZ1eTNZ?=
 =?utf-8?B?OUVtbUl4ZWtWOVhZaFhvdS83ODJ3bHVRQ2djQkp3UW9aYnFaSWlBYi84NTdw?=
 =?utf-8?B?Smc4TVkzeE91UXkvSndNbHA4aHB1bENEbVgvQkpDZDJMUGQ5c2NTK0NSTWxk?=
 =?utf-8?B?Nko1WTBYN251SXc4WVRtclhHSUtkTTVrNnZPRU9VaFp3UHpkMG1BcHFaRHRD?=
 =?utf-8?B?WVVBZDVERmROS21rL245SW54WUEzSkQ4eEVHTjN2eW9wOFFpb1FRM090Z0Np?=
 =?utf-8?B?NVpoa1ZZc1RWTHZQbFlJelVJMDFzbGdrcmRSYnZ3YTR4UENQUUZpMU9MZHNK?=
 =?utf-8?B?WHQyY3NXKzUwRUp6eW5TZVVzekw3Uko2M1JIS01WSS9PYWhiejdVeEdsTk1k?=
 =?utf-8?B?T1dYMlg1M2tXVStlY2EzRHdMMElRd3FHN0VxMlB4KythYUdWZkMzM2N3K0lz?=
 =?utf-8?B?N1BnVkQ5eE9Wc3QrYzJEYXMvUXZ5SDRqVFlMWU96ejZpR21ZQkdCN3l3SHRN?=
 =?utf-8?B?TEJFMTRuRmcxSm5pM1ZsZVNwUEViMGFmRWRmSEdXS3kvQmdHR0Rib3VPUDEy?=
 =?utf-8?B?QUFDK3FRQi9CcVBaYU93SEVMK1JDY05WVjFrVEE3ZWxGa1ZaVkVoTk1Zazcw?=
 =?utf-8?B?aXF2bEp5V2p3RFduRWxUSjBha1lZSTBLNXRIQkJFajdCL3kxUzNQZDBldkQ5?=
 =?utf-8?B?MjRzOUxHd0hBdjQ1Mit0eG9RZmk1b2NxU1dhOXVGK2NobkJHN2pDbjhQaklW?=
 =?utf-8?B?STk2RmR6MHJMeGUzWFFVY29sZ1Z3MmM4eVFkNTZIM0p5UERZZzd6UTQyTzRT?=
 =?utf-8?B?eURBVDViVU4wdzhZcVhURnRNUUNRK21vQmtnUDE5bVkyQkFyVENiVEI2Mkkv?=
 =?utf-8?B?UGlLamFxV2QxZWpkZUlROWpSdFpsVWdSMWttcEZ5S2Q1Q2pRdTZhOEw1VUtB?=
 =?utf-8?B?OWd2VG10MGxwaGE1M1hyOVVUTk1LU3lDZ0xnSEM0NnlxVXpZVXBWbGwwOUF6?=
 =?utf-8?B?SXRIczhOaEZ1S0ZiTzdCN0dzeFRIRG5VZ0RKak1uNmN1WUpUSW1XRWExeUpn?=
 =?utf-8?B?bWJNRXUxUnNab2ZGNXZ1QmRUMDhCSVViTVlmZG55QzZTVjBDVzljMXFmeDdS?=
 =?utf-8?B?N3JoaFZhbWNLVXJTN0JzalVvZUhydU80TE1xWnc1STh4b3VxQ2pRQkxHWm5v?=
 =?utf-8?B?M0NpWlZxM1ByVHNuM3llV2lBQlZWaENoWmxEcHZLclV0dkVYUytVdDFkekpK?=
 =?utf-8?B?Rzc4RUVhV25TWm9iM3NtWi9xS1JUTjJZd2M5WllJSGhLMGs4cDFSYVNyYXFU?=
 =?utf-8?B?RDZXeUdlQUJPL3JkZ0hSaFpFSlQ4OTNCSnpIbXNDYk1jNXorcTRiSGlsRjdY?=
 =?utf-8?B?aHE5WVR5TGgwM0pVZ3pVL0RNRExRcEdwVDA1S3hMSzlWY285M2MyQTc3YXQ2?=
 =?utf-8?B?UjNaVWJvMk43Z2J1RVJvNWcxVEdzL1AveHRWZGJRdlVFc2Z2VGtjWkxMODRN?=
 =?utf-8?B?MlFSMjAzdWJUMTkxVUlBbzVSdzkwZDhPZDkrOWJTTndlZDRQYS83STVoZ2d6?=
 =?utf-8?B?YWdOWGVXY0N1OUpOUXV5Y3draDJOc3M5WUNrRUVRM0hBaXRQTmhBdDdYYzBj?=
 =?utf-8?B?QUNzMENoV1dabWZWcWVwZUtMSjNTVFY4T1JCOC9vR3FWR2xtQldzbU1BYjVH?=
 =?utf-8?B?K0hkVTNKa3E2MDIyL0JhcnV0RU1PWHFrZ1VDWXYwNlV6THljWHhONDF6NHVL?=
 =?utf-8?B?YjhiRzdmMGZ3bXkzZCtKSUhwdktROWlNRlhQajhDSmdpQWdtTGhxVll3dGY1?=
 =?utf-8?B?ajRSM0grOVFYalIxT2R6SVZZUXFsblE5TUd4T0J1bnQycnFSbzNaZ0tvUENh?=
 =?utf-8?B?bk1YVXFWOTluQTIyY245VEIwMGM0UTJxdFNTM1pPTVYyeGZuYWl1TVFiTlkx?=
 =?utf-8?B?cndlYzlBeHBhd3Fnb1k3UTFrMjduMUF3eGFCYktQN3dtblVkTjhTb2VacVhE?=
 =?utf-8?B?SlJEWjRDelkzeDdpS1lwQXNZRCtDZnR0NkI3d0ZGZm8rcmFsek1uWEF3WmJT?=
 =?utf-8?B?V2N5TVFINEVNMWIySjl2dWNWNHY2c1h0d01tQWhmTHY3anNYaGZnL3JrRita?=
 =?utf-8?B?OEE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C35859A99D454D4583698333A8E268EA@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a78b67d-1de2-479b-eb83-08dab388a4f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 17:21:09.0407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cAxwrroDnKUxC/Rp3ap8hkmVihN/Npnzd0898sLTNDPtWVpbHjwh9Po1SlF/nYGBTte0nMhxT9tMgAw4VLVjWt37DMkbaQGaSR0aD8Qowms=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5603

T24gMjEvMTAvMjAyMiAxNzo1MywgTWljaGFsIE9yemVsIHdyb3RlOg0KPiBOdWxsIHNjaGVkdWxl
ciBpcyBub3QgZW5hYmxlZCBvbiBub24tZGVidWcgWGVuIGJ1aWxkcyBzbyB0aGUgY3VycmVudA0K
PiB0ZXN0IGNhbiBsZWFkIHRvIGEgZmFpbHVyZSBvbiBzdWNoIGpvYnMuIFdlIHN0aWxsIHdhbnQg
dG8gdGVzdCB0aGF0IHdlDQo+IGNhbiBhc3NpZ24gdGhlIGNwdXBvb2wgdG8gYSBkb21VIHdpdGgg
YSBkaWZmZXJlbnQgc2NoZWR1bGVyIHRoYW4gZGVmYXVsdA0KPiBvbmUgKGNyZWRpdDIpLiBTd2l0
Y2ggdG8gY3JlZGl0IGFzIGl0IGlzIGVuYWJsZWQgYnkgZGVmYXVsdC4NCj4NCj4gRml4ZXM6IDM2
ZTNmNDE1ODc3OCAoImF1dG9tYXRpb246IEFkZCBhIG5ldyBqb2IgZm9yIHRlc3RpbmcgYm9vdCB0
aW1lIGNwdXBvb2xzIG9uIGFybTY0IikNCj4gU2lnbmVkLW9mZi1ieTogTWljaGFsIE9yemVsIDxt
aWNoYWwub3J6ZWxAYW1kLmNvbT4NCg0KL3NpZ2ggLSBJJ20gc3VyZSBJIG5hY2tlZCB0aGF0IHN0
dXBpZGl0eSB0byBiZWdpbiB3aXRoLsKgIGFwcGFyZW50bHkgbm90Li4uDQoNCkl0IGlzIHRvdGFs
bHkgYm9ndXMgZm9yIENPTkZJR19ERUJVRyB0byBpbmZsdWVuY2UgbG9naWNhbCBjaHVua3Mgb2YN
CmZ1bmN0aW9uYWxpdHkgbGlrZSB0aGlzLsKgIFRoZSBDSSBzY3JpcHQgaXMgZ29vZCBpbiBpdHMg
Y3VycmVudCBmb3JtLg0KDQpSVERTIGFuZCBBUklOQyBzaG91bGQgYmUgZGVmYXVsdCBuLg0KDQpO
VUxMIGlzIG1vcmUgdHJpY2t5LsKgIFBWX1NISU0gaXMgZXhwbGljaXRseSBzZWN1cml0eSBzdXBw
b3J0ZWQsIGFuZCBoYXMNCmJlZW4gZm9yIHllYXJzLCBzbyB0aGUgIlVOU1VQUE9SVEVEIiBpcyBi
b2d1cywgd2hhdGV2ZXIgdGhlIGRlZmF1bHQgaXMuDQoNCkFzIE5VTEwgaXMgZXhwbGljaXRseSB0
ZXN0ZWQgaW4gQ0ksIGl0J3MgY2xlYXJseSBzdXBwb3J0ZWQsIGFuZCBwcm9iYWJseQ0Kb3VnaHQg
dG8gYmUgb24gZGVmYXVsdC4NCg0KDQpQbGVhc2UgaW5zdGVhZCBmaXggS2NvbmZpZyB0byBub3Qg
YmUgYnJva2VuLsKgIFRoYXQgd2lsbCBiZSBhIGZhciBiZXR0ZXINCmZpeCBvdmVyYWxsIGZvciBw
ZW9wbGUuDQoNCkFzIGEgbW9yZSBnZW5lcmFsIG5vdGUsIHRlc3RzIHdoaWNoIGFyZSB1c2luZyBu
b24tZGVmYXVsdCBwaWVjZXMgb2YNCmxvZ2ljIG91Z2h0IHRvIGFjdGl2YXRlIHRoZW0gZXhwbGlj
aXRseS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 17:24:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 17:24:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427915.677527 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvkl-0001st-Ot; Fri, 21 Oct 2022 17:24:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427915.677527; Fri, 21 Oct 2022 17:24:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvkl-0001sm-KD; Fri, 21 Oct 2022 17:24:15 +0000
Received: by outflank-mailman (input) for mailman id 427915;
 Fri, 21 Oct 2022 17:24:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JRa2=2W=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1olvkl-0001se-4a
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 17:24:15 +0000
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [2a00:1450:4864:20::42b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ede1399-5165-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 19:24:14 +0200 (CEST)
Received: by mail-wr1-x42b.google.com with SMTP id w18so6024283wro.7
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 10:24:14 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 k2-20020a5d6e82000000b0022ccae2fa62sm19434778wrz.22.2022.10.21.10.24.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 21 Oct 2022 10:24:12 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ede1399-5165-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=TUDQoD3HFruzS+T2pXmbko4NFchZqtcIPSOZUX4d550=;
        b=ITMQlOUOpKIaUb753f69rhurvrbbWWrVSvFktbbmPh7tmWLRF3eR/90Ui4xQ3sf6lg
         T3UjNTi4gbpv3zs0ziHMJJeyBWb9EX3bXKB51VtEwdWQDA21roxTplZ1zU5VylENRoGv
         WXiq7x9aKTkqpEvuhsK82qZb0LuoD0/ge38Sm1QQd4hX7zYe7oShFlwyjTGEP07ZAaiK
         /n5U6w2CZ7/qShG4kFFFTgiBGK+2BRJfn94qsmg84ASr97i1cuY+0llqZmRwQ+skjjfk
         bIZGPME2oS53l46ziNYQ8BsuWyX9mzAALAb2X99LkS0ku++bKL0cZptXG+deegNOQWr6
         oXCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=TUDQoD3HFruzS+T2pXmbko4NFchZqtcIPSOZUX4d550=;
        b=vZFeywvpT2I0k0liTmfQLaZCQnXbbJEJSll0JCEJONXXJ8BA9J7DfuzWX76O2pV3oP
         6+P0IS2PIbAtf9RwYfUW02x/gnEK3WkTstYGllP+8xOXRLZ2Itztk8sxZ3pZwg+yYLKO
         FfxsopLoIOejirRCXCWKWpzor2cFOIZPMnCC2BPJPnEZ0JQryc+OYVVBQQovuuoKmgAe
         ilX+qbEbYh4CRWesbjWgAG/dmZbbgzCO12zQ2YsbifUqGJlbu/recs1rvHkmX/oCgShO
         QtdN1cDLR6gRx0c5t7n4c9aEvhLwlRUUYAh4me/l6MVBqF7+V4HR39vzaeIO7KfsA+X9
         1QPw==
X-Gm-Message-State: ACrzQf2QtmnQsSRooxR2FPJsq+SdyEy5icl2BF3c3ZF2OTy1pj/pSscd
	29vxAa/lLanOi0qvmLcr18iZXgD043U=
X-Google-Smtp-Source: AMsMyM7cpK0FOcQrHC09rUmFCtFtUK6wzLIOLlA1V3/FyhaQt9J57gGebYe6YylFQ+DmvNp+rMG5eg==
X-Received: by 2002:adf:cf06:0:b0:236:4c12:47a7 with SMTP id o6-20020adfcf06000000b002364c1247a7mr4878514wrj.543.1666373052898;
        Fri, 21 Oct 2022 10:24:12 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V3] xen/virtio: Handle PCI devices which Host controller is described in DT
Date: Fri, 21 Oct 2022 20:24:08 +0300
Message-Id: <20221021172408.77397-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Use the same "xen-grant-dma" device concept for the PCI devices
behind device-tree based PCI Host controller, but with one modification.
Unlike for platform devices, we cannot use generic IOMMU bindings
(iommus property), as we need to support more flexible configuration.
The problem is that PCI devices under the single PCI Host controller
may have the backends running in different Xen domains and thus have
different endpoints ID (backend domains ID).

Add ability to deal with generic PCI-IOMMU bindings (iommu-map/
iommu-map-mask properties) which allows us to describe relationship
between PCI devices and backend domains ID properly.

To avoid having to look up for the PCI Host bridge twice and reduce
the amount of checks pass an extra struct device_node *np to both
xen_dt_grant_init_backend_domid() and xen_is_dt_grant_dma_device().
While at it also pass domid_t *backend_domid instead of
struct xen_grant_dma_data *data to the former.

So with current patch the code expects iommus property for the platform
devices and iommu-map/iommu-map-mask properties for PCI devices.

The example of generated by the toolstack iommu-map property
for two PCI devices 0000:00:01.0 and 0000:00:02.0 whose
backends are running in different Xen domains with IDs 1 and 2
respectively:
iommu-map = <0x08 0xfde9 0x01 0x08 0x10 0xfde9 0x02 0x08>;

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
Here, for PCI devices we use more flexible way to pass backend domid to the guest
than for platform devices.

Changes V1 -> V2:
   - update commit description
   - rebase
   - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings

Changes V2 -> V3:
   - update commit description, add an example
   - drop xen_dt_map_id() and squash xen_dt_get_pci_host_node() with
     xen_dt_get_node()
   - pass struct device_node *np to xen_is_dt_grant_dma_device() and
     xen_dt_grant_init_backend_domid()
   - pass domid_t *backend_domid instead of struct xen_grant_dma_data *data
     to xen_dt_grant_init_backend_domid()

Previous discussion is at:
https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/20221015153409.918775-1-olekstysh@gmail.com/

Based on:
https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
---
 drivers/xen/grant-dma-ops.c | 80 ++++++++++++++++++++++++++++++-------
 1 file changed, 66 insertions(+), 14 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index daa525df7bdc..76b29d20aeee 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/dma-map-ops.h>
 #include <linux/of.h>
+#include <linux/pci.h>
 #include <linux/pfn.h>
 #include <linux/xarray.h>
 #include <linux/virtio_anchor.h>
@@ -292,12 +293,37 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
-static bool xen_is_dt_grant_dma_device(struct device *dev)
+static struct device_node *xen_dt_get_node(struct device *dev)
 {
-	struct device_node *iommu_np;
+	if (dev_is_pci(dev)) {
+		struct pci_dev *pdev = to_pci_dev(dev);
+		struct pci_bus *bus = pdev->bus;
+
+		/* Walk up to the root bus to look for PCI Host controller */
+		while (!pci_is_root_bus(bus))
+			bus = bus->parent;
+
+		return of_node_get(bus->bridge->parent->of_node);
+	}
+
+	return of_node_get(dev->of_node);
+}
+
+static bool xen_is_dt_grant_dma_device(struct device *dev,
+					struct device_node *np)
+{
+	struct device_node *iommu_np = NULL;
 	bool has_iommu;
 
-	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
+	if (dev_is_pci(dev)) {
+		struct pci_dev *pdev = to_pci_dev(dev);
+		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
+
+		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_np, NULL))
+			return false;
+	} else
+		iommu_np = of_parse_phandle(np, "iommus", 0);
+
 	has_iommu = iommu_np &&
 		    of_device_is_compatible(iommu_np, "xen,grant-dma");
 	of_node_put(iommu_np);
@@ -307,9 +333,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
 
 bool xen_is_grant_dma_device(struct device *dev)
 {
+	struct device_node *np;
+
 	/* XXX Handle only DT devices for now */
-	if (dev->of_node)
-		return xen_is_dt_grant_dma_device(dev);
+	np = xen_dt_get_node(dev);
+	if (np) {
+		bool ret;
+
+		ret = xen_is_dt_grant_dma_device(dev, np);
+		of_node_put(np);
+		return ret;
+	}
 
 	return false;
 }
@@ -323,14 +357,26 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
 }
 
 static int xen_dt_grant_init_backend_domid(struct device *dev,
-					   struct xen_grant_dma_data *data)
+					   struct device_node *np,
+					   domid_t *backend_domid)
 {
-	struct of_phandle_args iommu_spec;
+	struct of_phandle_args iommu_spec = { .args_count = 1 };
 
-	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
-			0, &iommu_spec)) {
-		dev_err(dev, "Cannot parse iommus property\n");
-		return -ESRCH;
+	if (dev_is_pci(dev)) {
+		struct pci_dev *pdev = to_pci_dev(dev);
+		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
+
+		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_spec.np,
+				iommu_spec.args)) {
+			dev_err(dev, "Cannot translate ID\n");
+			return -ESRCH;
+		}
+	} else {
+		if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
+				0, &iommu_spec)) {
+			dev_err(dev, "Cannot parse iommus property\n");
+			return -ESRCH;
+		}
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
@@ -346,7 +392,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
 	 * The endpoint ID here means the ID of the domain where the
 	 * corresponding backend is running
 	 */
-	data->backend_domid = iommu_spec.args[0];
+	*backend_domid = iommu_spec.args[0];
 
 	return 0;
 }
@@ -354,6 +400,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
 void xen_grant_setup_dma_ops(struct device *dev)
 {
 	struct xen_grant_dma_data *data;
+	struct device_node *np;
 
 	data = find_xen_grant_dma_data(dev);
 	if (data) {
@@ -365,8 +412,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	if (!data)
 		goto err;
 
-	if (dev->of_node) {
-		if (xen_dt_grant_init_backend_domid(dev, data))
+	np = xen_dt_get_node(dev);
+	if (np) {
+		int ret;
+
+		ret = xen_dt_grant_init_backend_domid(dev, np, &data->backend_domid);
+		of_node_put(np);
+		if (ret)
 			goto err;
 	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
 		dev_info(dev, "Using dom0 as backend\n");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 17:26:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 17:26:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427920.677537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvmV-0002Zi-37; Fri, 21 Oct 2022 17:26:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427920.677537; Fri, 21 Oct 2022 17:26:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvmV-0002Zb-04; Fri, 21 Oct 2022 17:26:03 +0000
Received: by outflank-mailman (input) for mailman id 427920;
 Fri, 21 Oct 2022 17:26:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olvmT-0002ZT-Py
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 17:26:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olvmS-00085s-JC; Fri, 21 Oct 2022 17:26:00 +0000
Received: from 54-240-197-236.amazon.com ([54.240.197.236]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olvmS-0003qB-By; Fri, 21 Oct 2022 17:26:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AsxB9Sl6mZH8WBJEcs4TjcSIZKpYwIPbeEV1vL6bZKQ=; b=x7vlH/fbpH/cFM++IGY/hpv0Nb
	4SL6i3pBqIu6MOS0qpLArGO4r4vSSZ0vZ9PL6Cm/6gCgmLa6VVwote/ibBMveuOPu10vIz6K23GFH
	AnkgOdeMNCtcxFww8MrUggWnHqzrQgpgT4tYfVbjqXPE3LzCsHeIEHqyesL5jZjRDmU8=;
Message-ID: <b800a6a8-97da-bfb3-81bb-230592ce19e1@xen.org>
Date: Fri, 21 Oct 2022 18:25:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for
 domains
Content-Language: en-US
To: Wei Chen <Wei.Chen@arm.com>, Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-3-carlo.nonato@minervasys.tech>
 <fe58de74-8bf5-50df-eb32-2d479758bfd8@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <fe58de74-8bf5-50df-eb32-2d479758bfd8@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 26/09/2022 07:39, Wei Chen wrote:
> 
> 
> On 2022/8/26 20:51, Carlo Nonato wrote:
>> This commit adds array pointers to domains as well as to the hypercall
>> and configuration structure employed in domain creation. The latter is 
>> used
>> both by the toolstack and by Xen itself to pass configuration data to the
>> domain creation function, so the XEN_GUEST_HANDLE macro must be 
>> adopted to be
>> able to access guest memory in the first case. This implies special 
>> care for
>> the copy of the configuration data into the domain data, meaning that a
>> discrimination variable for the two possible code paths (coming from 
>> Xen or
>> from the toolstack) is needed.
>>
>> The initialization and free functions for colored domains are also added.
>> The former is responsible for allocating and populating the color array
>> of the domain and it also checks for configuration issues. One of those
>> issues is enabling both coloring and directmap for the domain because 
>> they
>> contradicts one another. Since that, Dom0 must not be created with the
>> directmap flag.
>> The latter instead frees allocated memory.
>>
>> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
>> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
>> ---
>>   docs/misc/arm/cache-coloring.rst    |  7 ++--
>>   xen/arch/arm/coloring.c             | 56 +++++++++++++++++++++++++++++
>>   xen/arch/arm/domain.c               | 11 ++++++
>>   xen/arch/arm/domain_build.c         | 13 +++++--
>>   xen/arch/arm/include/asm/coloring.h |  7 ++++
>>   xen/arch/arm/include/asm/domain.h   |  4 +++
>>   xen/include/public/arch-arm.h       |  8 +++++
>>   7 files changed, 102 insertions(+), 4 deletions(-)
>>
>> diff --git a/docs/misc/arm/cache-coloring.rst 
>> b/docs/misc/arm/cache-coloring.rst
>> index c7adcb0f1f..345d97cb56 100644
>> --- a/docs/misc/arm/cache-coloring.rst
>> +++ b/docs/misc/arm/cache-coloring.rst
>> @@ -13,7 +13,7 @@ In order to enable and use it, few steps are needed.
>>     (refer to menuconfig help for value meaning and when it should be 
>> changed).
>>           CONFIG_MAX_CACHE_COLORS=<n>
>> -- Assign colors to Dom0 using the `Color selection format`_ (see
>> +- Assign colors to domains using the `Color selection format`_ (see
>>     `Coloring parameters`_ for more documentation pointers).
>>   Background
>> @@ -109,4 +109,7 @@ Coloring parameters
>>   LLC way size (as previously discussed) and Dom0 colors can be set 
>> using the
>>   appropriate command line parameters. See the relevant documentation in
>> -"docs/misc/xen-command-line.pandoc".
>> \ No newline at end of file
>> +"docs/misc/xen-command-line.pandoc".
>> +
>> +Note that if no color configuration is provided for domains, they 
>> fallback to
>> +the default one, which corresponds simply to all available colors.
>> \ No newline at end of file
>> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
>> index c010ebc01b..2b37cda067 100644
>> --- a/xen/arch/arm/coloring.c
>> +++ b/xen/arch/arm/coloring.c
>> @@ -22,6 +22,7 @@
>>    * along with this program.  If not, see 
>> <http://www.gnu.org/licenses/>.
>>    */
>>   #include <xen/errno.h>
>> +#include <xen/guest_access.h>
>>   #include <xen/keyhandler.h>
>>   #include <xen/param.h>
>>   #include <xen/types.h>
>> @@ -211,6 +212,61 @@ bool __init coloring_init(void)
>>       return true;
>>   }
>> +int domain_coloring_init(struct domain *d,
>> +                         const struct xen_arch_domainconfig *config)
>> +{
>> +    if ( is_domain_direct_mapped(d) )
>> +    {
>> +        printk(XENLOG_ERR
>> +               "Can't enable coloring and directmap at the same time 
>> for %pd\n",
>> +               d);
>> +        return -EINVAL;
>> +    }
>> +
>> +    if ( is_hardware_domain(d) )
>> +    {
>> +        d->arch.colors = dom0_colors;
>> +        d->arch.num_colors = dom0_num_colors;
>> +    }
>> +    else if ( config->num_colors == 0 )
>> +    {
>> +        printk(XENLOG_WARNING
>> +               "Color config not found for %pd. Using default\n", d);
>> +        d->arch.colors = xzalloc_array(unsigned int, max_colors);
>> +        d->arch.num_colors = set_default_domain_colors(d->arch.colors);
>> +    }
>> +    else
>> +    {
>> +        d->arch.colors = xzalloc_array(unsigned int, 
>> config->num_colors);
>> +        d->arch.num_colors = config->num_colors;
>> +        if ( config->from_guest )
>> +            copy_from_guest(d->arch.colors, config->colors, 
>> config->num_colors);
>> +        else
>> +            memcpy(d->arch.colors, config->colors.p,
>> +                   sizeof(unsigned int) * config->num_colors);
>> +    }
>> +
>> +    if ( !d->arch.colors )
>> +    {
>> +        printk(XENLOG_ERR "Colors allocation failed for %pd\n", d);
>> +        return -ENOMEM;
>> +    }
>> +
>> +    if ( !check_colors(d->arch.colors, d->arch.num_colors) )
>> +    {
> 
> If we add xfree(d->arch.colors) here for non-hw domains, is it possible 
> to make this function have a complete fallback process? And I know 
> currently, this is handled in domain_coloring_free.

arch_domain_destroy() (and therefore domain_coloring_free()) will always 
be called by arch_domain_create(). So here you will want to use XFREE() 
to avoid a double free.

However, I would just rely on the free() in domain_coloring_free().

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 17:33:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 17:33:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427926.677548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvu4-00047s-W9; Fri, 21 Oct 2022 17:33:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427926.677548; Fri, 21 Oct 2022 17:33:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olvu4-00047l-Ta; Fri, 21 Oct 2022 17:33:52 +0000
Received: by outflank-mailman (input) for mailman id 427926;
 Fri, 21 Oct 2022 17:33:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olvu3-00047b-TZ; Fri, 21 Oct 2022 17:33:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olvu3-0008Ey-N3; Fri, 21 Oct 2022 17:33:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olvu3-0002Yq-80; Fri, 21 Oct 2022 17:33:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olvu3-0003LK-7F; Fri, 21 Oct 2022 17:33:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uLOl7Y6zBi/u16d88LH5UBLcVAD7uq8gq8eJSFfEhbM=; b=yeIPsL0OxZxf9ZvtVaBwtCwUxX
	QsghcescmLoH8K7vCXoWpR5rlaOVXTK2CiIAnBLGAjJS8FnMijaulfyR2jJk8a+1hIUBjKbcXfCPY
	ol84aotlIMlFCOWWWSCKGx0RywugKoDwDucFkp4j8Qi02pupf+KW+uv738g/6l5Rwhgc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174140-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174140: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 17:33:51 +0000

flight 174140 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174140/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 174140
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 174070 pass in 174140
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174070 pass in 174140
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 174070

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   64 days
Testing same since   173493  2022-10-11 13:07:01 Z   10 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 18:02:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 18:02:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427933.677560 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olwLU-0007wn-8r; Fri, 21 Oct 2022 18:02:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427933.677560; Fri, 21 Oct 2022 18:02:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olwLU-0007wg-4t; Fri, 21 Oct 2022 18:02:12 +0000
Received: by outflank-mailman (input) for mailman id 427933;
 Fri, 21 Oct 2022 18:02:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olwLS-0007wa-Ap
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 18:02:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olwLR-0000OI-H2; Fri, 21 Oct 2022 18:02:09 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olwLR-0005er-91; Fri, 21 Oct 2022 18:02:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=noiIDH3dq9L/0b3PrhDwsO9243ZycCuTsd4vLj6lMao=; b=q4lM6OI055jdlS6/JzYGGXAZ+h
	uLGhCMA7GIyDEkbmNWdRwsVyYofFFoZEoikuuWTd/9/g9XZ9AcDO2Fp2xC8XNmhRflL/0y5SZWYzs
	WVxA6GhJIodIdwMtQZZ4UWHK4xK3sSIKVjzsm7IO78iJwB/dJk8zd8hdSIyG66ZtxP4g=;
Message-ID: <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org>
Date: Fri, 21 Oct 2022 19:02:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for
 domains
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-3-carlo.nonato@minervasys.tech>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220826125111.152261-3-carlo.nonato@minervasys.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Carlo,

On 26/08/2022 13:51, Carlo Nonato wrote:
> This commit adds array pointers to domains as well as to the hypercall
> and configuration structure employed in domain creation. The latter is used
> both by the toolstack and by Xen itself to pass configuration data to the
> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be
> able to access guest memory in the first case. This implies special care for
> the copy of the configuration data into the domain data, meaning that a
> discrimination variable for the two possible code paths (coming from Xen or
> from the toolstack) is needed.

So this means that a toolstack could set from_guest. I know the 
toolstack is trusted... However, we should try to limit when the trust 
when this is possible.

In this case, I would consider to modify the prototype of 
domain_create() to pass internal information.

> 
> The initialization and free functions for colored domains are also added.
> The former is responsible for allocating and populating the color array
> of the domain and it also checks for configuration issues. One of those
> issues is enabling both coloring and directmap for the domain because they
> contradicts one another. Since that, Dom0 must not be created with the
> directmap flag.
> The latter instead frees allocated memory.
> 
> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> ---
>   docs/misc/arm/cache-coloring.rst    |  7 ++--
>   xen/arch/arm/coloring.c             | 56 +++++++++++++++++++++++++++++
>   xen/arch/arm/domain.c               | 11 ++++++
>   xen/arch/arm/domain_build.c         | 13 +++++--
>   xen/arch/arm/include/asm/coloring.h |  7 ++++
>   xen/arch/arm/include/asm/domain.h   |  4 +++
>   xen/include/public/arch-arm.h       |  8 +++++
>   7 files changed, 102 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
> index c7adcb0f1f..345d97cb56 100644
> --- a/docs/misc/arm/cache-coloring.rst
> +++ b/docs/misc/arm/cache-coloring.rst
> @@ -13,7 +13,7 @@ In order to enable and use it, few steps are needed.
>     (refer to menuconfig help for value meaning and when it should be changed).
>   
>           CONFIG_MAX_CACHE_COLORS=<n>
> -- Assign colors to Dom0 using the `Color selection format`_ (see
> +- Assign colors to domains using the `Color selection format`_ (see
>     `Coloring parameters`_ for more documentation pointers).
>   
>   Background
> @@ -109,4 +109,7 @@ Coloring parameters
>   
>   LLC way size (as previously discussed) and Dom0 colors can be set using the
>   appropriate command line parameters. See the relevant documentation in
> -"docs/misc/xen-command-line.pandoc".
> \ No newline at end of file
> +"docs/misc/xen-command-line.pandoc".
> +
> +Note that if no color configuration is provided for domains, they fallback to
> +the default one, which corresponds simply to all available colors.
> \ No newline at end of file
> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
> index c010ebc01b..2b37cda067 100644
> --- a/xen/arch/arm/coloring.c
> +++ b/xen/arch/arm/coloring.c
> @@ -22,6 +22,7 @@
>    * along with this program.  If not, see <http://www.gnu.org/licenses/>.
>    */
>   #include <xen/errno.h>
> +#include <xen/guest_access.h>
>   #include <xen/keyhandler.h>
>   #include <xen/param.h>
>   #include <xen/types.h>
> @@ -211,6 +212,61 @@ bool __init coloring_init(void)
>       return true;
>   }
>   
> +int domain_coloring_init(struct domain *d,
> +                         const struct xen_arch_domainconfig *config)
> +{
> +    if ( is_domain_direct_mapped(d) )
> +    {
> +        printk(XENLOG_ERR
> +               "Can't enable coloring and directmap at the same time for %pd\n",
> +               d);
> +        return -EINVAL;
> +    }
> +
> +    if ( is_hardware_domain(d) )
> +    {
> +        d->arch.colors = dom0_colors;
> +        d->arch.num_colors = dom0_num_colors;
> +    }

I think it would be better if we allocate an array also for the HW 
domain. This is not going to require too much extra memory and will help 
the code to be simpler.

I would also pass the color to domain_create(). So there is no logic 
specific to the HW domain here.

> +    else if ( config->num_colors == 0 )
> +    {
> +        printk(XENLOG_WARNING
> +               "Color config not found for %pd. Using default\n", d);
> +        d->arch.colors = xzalloc_array(unsigned int, max_colors);
> +        d->arch.num_colors = set_default_domain_colors(d->arch.colors);
Ah, so your check in set_default_domain_colors() is here to cater this 
case? I would prefer if we check the allocation before using it. This 
will make it more obvious compare to expecting 
set_default_domain_colors() checking for NULL.

> +    }
> +    else
> +    {
> +        d->arch.colors = xzalloc_array(unsigned int, config->num_colors);
> +        d->arch.num_colors = config->num_colors;
> +        if ( config->from_guest )
> +            copy_from_guest(d->arch.colors, config->colors, config->num_colors);
> +        else
> +            memcpy(d->arch.colors, config->colors.p,
> +                   sizeof(unsigned int) * config->num_colors);

See my remark above.

> +    }
> +
> +    if ( !d->arch.colors )
> +    {
> +        printk(XENLOG_ERR "Colors allocation failed for %pd\n", d);
> +        return -ENOMEM;
> +    }
> +
> +    if ( !check_colors(d->arch.colors, d->arch.num_colors) )
> +    {
> +        printk(XENLOG_ERR "Bad color config for %pd\n", d);
> +        return -EINVAL;
> +    }
> +
> +    return 0;
> +}
> +
> +void domain_coloring_free(struct domain *d)
> +{
> +    if ( !is_hardware_domain(d) )
> +        xfree(d->arch.colors);
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2d6253181a..c6fa8adc99 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -23,6 +23,9 @@
>   #include <xen/wait.h>
>   
>   #include <asm/alternative.h>
> +#ifdef CONFIG_CACHE_COLORING
> +#include <asm/coloring.h>
> +#endif
>   #include <asm/cpuerrata.h>
>   #include <asm/cpufeature.h>
>   #include <asm/current.h>
> @@ -712,6 +715,11 @@ int arch_domain_create(struct domain *d,
>       ioreq_domain_init(d);
>   #endif
>   
> +#ifdef CONFIG_CACHE_COLORING

When !CONFIG_CACHE_COLORING, we should check that the color is not 
specified.

> +    if ( (rc = domain_coloring_init(d, &config->arch)) )
> +        goto fail;
> +#endif
> +
>       /* p2m_init relies on some value initialized by the IOMMU subsystem */
>       if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
>           goto fail;
> @@ -807,6 +815,9 @@ void arch_domain_destroy(struct domain *d)
>                          get_order_from_bytes(d->arch.efi_acpi_len));
>   #endif
>       domain_io_free(d);
> +#ifdef CONFIG_CACHE_COLORING
> +    domain_coloring_free(d);
> +#endif

See my remark in patch #1 about the #ifdef.

>   }
>   
>   void arch_domain_shutdown(struct domain *d)
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 3fd1186b53..4d4cb692fc 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -33,6 +33,12 @@
>   #include <xen/grant_table.h>
>   #include <xen/serial.h>
>   
> +#ifdef CONFIG_CACHE_COLORING
> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged
> +#else
> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap
> +#endif

I can't remember if I asked it before and it doesn't seem to written 
everywhere. This check suggest that it is not possible to use the same 
Xen binary for coloring and non-coloring.

At the moment, we have been able to have all the features in the same 
Xen binary. So what are the reasons for this restriction?

> +
>   static unsigned int __initdata opt_dom0_max_vcpus;
>   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>   
> @@ -3399,7 +3405,10 @@ static int __init construct_dom0(struct domain *d)
>       /* type must be set before allocate_memory */
>       d->arch.type = kinfo.type;
>   #endif
> -    allocate_memory_11(d, &kinfo);
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )

Even if we can't have a single Xen binary yet, I would prefer if we 
avoid using directly IS_ENABLED(CONFIG_CACHE_COLORING). Instead it would 
be better to provide an helper that check whether the domain has cache 
coloring is enabled.

That helper could use IS_ENABLED(CONFIG_CACHE_COLORING) if that still 
wanted. The advantage is we make it easier to modify the code.

> +        allocate_memory(d, &kinfo);
> +    else
> +        allocate_memory_11(d, &kinfo);
>       find_gnttab_region(d, &kinfo);
>   
>       /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */
> @@ -3455,7 +3464,7 @@ void __init create_dom0(void)
>       if ( iommu_enabled )
>           dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>   
> -    dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap);
> +    dom0 = domain_create(0, &dom0_cfg, XEN_DOM0_CREATE_FLAGS);
>       if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
>           panic("Error creating domain 0\n");
>   
> diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
> index dd7eff5f07..60c8b1f079 100644
> --- a/xen/arch/arm/include/asm/coloring.h
> +++ b/xen/arch/arm/include/asm/coloring.h
> @@ -25,7 +25,14 @@
>   #define __ASM_ARM_COLORING_H__
>   
>   #include <xen/init.h>
> +#include <xen/sched.h>
> +
> +#include <public/arch-arm.h>
>   
>   bool __init coloring_init(void);
>   
> +int domain_coloring_init(struct domain *d,
> +                         const struct xen_arch_domainconfig *config);
> +void domain_coloring_free(struct domain *d);
> +
>   #endif /* !__ASM_ARM_COLORING_H__ */
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 26a8348eed..291f7c375d 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -58,6 +58,10 @@ struct arch_domain
>   #ifdef CONFIG_ARM_64
>       enum domain_type type;
>   #endif

NIT: Newline here please. So we keep each feature in their own block.

> +#ifdef CONFIG_CACHE_COLORING
> +    unsigned int *colors;
> +    unsigned int num_colors;
> +#endif >
>       /* Virtual MMU */
>       struct p2m_domain p2m;
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index c8b6058d3a..adf843a7a1 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>   #define XEN_DOMCTL_CONFIG_TEE_NONE      0
>   #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>   
> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);

You don't seem to use "color_t" outside of arch-arm.h and we already 
define guest handle for "unsigned int". So can they be used?

> +
>   struct xen_arch_domainconfig {
>       /* IN/OUT */
>       uint8_t gic_version;
> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
>        *
>        */
>       uint32_t clock_frequency;
> +    /* IN */
> +    uint8_t from_guest;

There is an implicit padding here and ...
> +    /* IN */
> +    uint16_t num_colors;

... here. For the ABI, we are trying to have all the padding explicit. 
So the layout of the structure is clear.

Also, DOMCTL is an unstable ABI, so I think it would not be necessary to 
check the padding are zeroed. If it were a stable ABI, then we would 
need to check so they can be re-used in the future.

> +    /* IN */
> +    XEN_GUEST_HANDLE(color_t) colors;
>   };

Lastly, assuming this is the first patch touching the domctl for next 
release, you will want to bump the XEN_DOMCTL_INTERFACE_VERSION.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 18:04:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 18:04:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427940.677573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olwNv-00009G-Qk; Fri, 21 Oct 2022 18:04:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427940.677573; Fri, 21 Oct 2022 18:04:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olwNv-000099-Nj; Fri, 21 Oct 2022 18:04:43 +0000
Received: by outflank-mailman (input) for mailman id 427940;
 Fri, 21 Oct 2022 18:04:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olwNv-000093-1H
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 18:04:43 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olwNu-0000QP-EI; Fri, 21 Oct 2022 18:04:42 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olwNu-0005jD-7T; Fri, 21 Oct 2022 18:04:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=qX9ztqqvdAniN2MPIi/9AtVmrtAfGtZ3JRH6Aajp1Mg=; b=n8XJqM+oflvZ4ap5y4ERQoEQCr
	tD5nNLEeRbju1BKaHpNiNAZCuLRyHM1c99AT2HyhQ0CFSmvmZqS8T+iLDVFXyOwEdNSdrC++DrU5G
	YPLKV+scjLyqkVz7uWLee9DWyORuXE2cdkTcKYCrepJAnd3+Aadr0F/2ZFTxVGBGXfrg=;
Message-ID: <e69c4786-9938-8f95-0f7f-fa59783ec03c@xen.org>
Date: Fri, 21 Oct 2022 19:04:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for
 domains
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org, Andrew Cooper <andrew.cooper3@citrix.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: george.dunlap@citrix.com, jbeulich@suse.com, stefano.stabellini@amd.com,
 wl@xen.org, marco.solieri@unimore.it, andrea.bastoni@minervasys.tech,
 lucmiccio@gmail.com, Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-3-carlo.nonato@minervasys.tech>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220826125111.152261-3-carlo.nonato@minervasys.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 26/08/2022 13:51, Carlo Nonato wrote:
>   #endif /* !__ASM_ARM_COLORING_H__ */
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 26a8348eed..291f7c375d 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -58,6 +58,10 @@ struct arch_domain
>   #ifdef CONFIG_ARM_64
>       enum domain_type type;
>   #endif
> +#ifdef CONFIG_CACHE_COLORING
> +    unsigned int *colors;
> +    unsigned int num_colors;
> +#endif
>   
>       /* Virtual MMU */
>       struct p2m_domain p2m;
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index c8b6058d3a..adf843a7a1 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>   #define XEN_DOMCTL_CONFIG_TEE_NONE      0
>   #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>   
> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);
> +
>   struct xen_arch_domainconfig {
>       /* IN/OUT */
>       uint8_t gic_version;
> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
>        *
>        */
>       uint32_t clock_frequency;
> +    /* IN */
> +    uint8_t from_guest;
> +    /* IN */
> +    uint16_t num_colors;
> +    /* IN */
> +    XEN_GUEST_HANDLE(color_t) colors;
>   };
>   #endif /* __XEN__ || __XEN_TOOLS__ */


I forgot to mention. I think the golang and OCaml bindings will also 
need to be re-generated. Andrew, Anthony, can you confirm?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 18:09:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 18:09:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427945.677585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olwSm-0000yS-CD; Fri, 21 Oct 2022 18:09:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427945.677585; Fri, 21 Oct 2022 18:09:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olwSm-0000yL-8S; Fri, 21 Oct 2022 18:09:44 +0000
Received: by outflank-mailman (input) for mailman id 427945;
 Fri, 21 Oct 2022 18:09:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1olwSk-0000yF-Kq
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 18:09:42 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olwSk-0000Vo-2z; Fri, 21 Oct 2022 18:09:42 +0000
Received: from 54-240-197-228.amazon.com ([54.240.197.228]
 helo=[192.168.29.168]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1olwSj-0005r6-S9; Fri, 21 Oct 2022 18:09:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+T4RkEbI6zCOBK4wp26Gs1MMOk7hkFIxuPFCHmlR9M8=; b=DKgk7gduhrGBEPbvKKy+XlbCL0
	DxaxvQExzcpSGZ5gc5m6iI3XaSLRkqPq2EoMB13f1wEqxS26UR+L5337EUpsP5YUmJ1MYgJJHnc5v
	D7n+6/IjPrI7esdDLVgTBLl6e3RJcf8V6cXUQsGHW8rxsWNsdJtq2GvAarwFAcfvB3gA=;
Message-ID: <daf3cb72-2708-ec13-c618-fc02c0dc5cb4@xen.org>
Date: Fri, 21 Oct 2022 19:09:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 04/12] tools/xl: add support for cache coloring
 configuration
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>,
 Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-5-carlo.nonato@minervasys.tech>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220826125111.152261-5-carlo.nonato@minervasys.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Carlo,

This patch seems to be missing the tools maintainers/reviewers. I have 
added them now.

I am not sure what you are to generate the CCs. If you are not aware, we 
have a script that will add the correct maintainers/reviewers for each 
patch. The script is called "scripts/add_maintainers.pl" and can be used 
after generating the patches.

Cheers,

On 26/08/2022 13:51, Carlo Nonato wrote:
> Add a new "colors" parameter that defines the color assignment for a
> domain. The user can specify one or more color ranges using the same
> syntax used everywhere else for color config described in the documentation.
> The parameter is defined as a list of strings that represent the
> color ranges.
> Also documentation is added.
> 
> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> ---
>   docs/man/xl.cfg.5.pod.in         | 10 ++++++
>   tools/libs/light/libxl_create.c  | 12 ++++++++
>   tools/libs/light/libxl_types.idl |  1 +
>   tools/xl/xl_parse.c              | 52 ++++++++++++++++++++++++++++++--
>   4 files changed, 73 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index b2901e04cf..5f53cec8bf 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -2880,6 +2880,16 @@ Currently, only the "sbsa_uart" model is supported for ARM.
>   
>   =back
>   
> +=over 4
> +
> +=item B<colors=[ "COLORS_RANGE", "COLORS_RANGE", ...]>
> +
> +Specify the LLC color configuration for the guest. B<COLORS_RANGE> can be either
> +a single color value or a hypen-separated closed interval of colors
> +(such as "0-4").
> +
> +=back
> +
>   =head3 x86
>   
>   =over 4
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index b9dd2deedf..94c511912c 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -615,6 +615,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>       struct xs_permissions rwperm[1];
>       struct xs_permissions noperm[1];
>       xs_transaction_t t = 0;
> +    DECLARE_HYPERCALL_BUFFER(unsigned int, colors);
>   
>       /* convenience aliases */
>       libxl_domain_create_info *info = &d_config->c_info;
> @@ -676,6 +677,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>               goto out;
>           }
>   
> +        if (d_config->b_info.num_colors) {
> +            size_t bytes = sizeof(unsigned int) * d_config->b_info.num_colors;
> +            colors = xc_hypercall_buffer_alloc(ctx->xch, colors, bytes);
> +            memcpy(colors, d_config->b_info.colors, bytes);
> +            set_xen_guest_handle(create.arch.colors, colors);
> +            create.arch.num_colors = d_config->b_info.num_colors;
> +            create.arch.from_guest = 1;
> +            LOG(DEBUG, "Setup %u domain colors", d_config->b_info.num_colors);
> +        }
> +
>           for (;;) {
>               uint32_t local_domid;
>               bool recent;
> @@ -922,6 +933,7 @@ retry_transaction:
>       rc = 0;
>    out:
>       if (t) xs_transaction_end(ctx->xsh, t, 1);
> +    if (colors) xc_hypercall_buffer_free(ctx->xch, colors);
>       return rc;
>   }
>   
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index d634f304cd..642173af1a 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -557,6 +557,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>       ("ioports",          Array(libxl_ioport_range, "num_ioports")),
>       ("irqs",             Array(uint32, "num_irqs")),
>       ("iomem",            Array(libxl_iomem_range, "num_iomem")),
> +    ("colors",           Array(uint32, "num_colors")),
>       ("claim_mode",	     libxl_defbool),
>       ("event_channels",   uint32),
>       ("kernel",           string),
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 1b5381cef0..7f8fbbfb4c 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -1220,8 +1220,9 @@ void parse_config_data(const char *config_source,
>       XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms,
>                      *usbctrls, *usbdevs, *p9devs, *vdispls, *pvcallsifs_devs;
>       XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs,
> -                   *mca_caps;
> -    int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps;
> +                   *mca_caps, *colors;
> +    int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps,
> +        num_colors;
>       int pci_power_mgmt = 0;
>       int pci_msitranslate = 0;
>       int pci_permissive = 0;
> @@ -1370,6 +1371,53 @@ void parse_config_data(const char *config_source,
>       if (!xlu_cfg_get_long (config, "maxmem", &l, 0))
>           b_info->max_memkb = l * 1024;
>   
> +    if (!xlu_cfg_get_list(config, "colors", &colors, &num_colors, 0)) {
> +        int k, p, cur_index;
> +
> +        b_info->num_colors = 0;
> +        /* Get number of colors based on ranges */
> +        for (i = 0; i < num_colors; i++) {
> +            uint32_t start = 0, end = 0;
> +
> +            buf = xlu_cfg_get_listitem(colors, i);
> +            if (!buf) {
> +                fprintf(stderr,
> +                    "xl: Unable to get element %d in colors range list\n", i);
> +                exit(1);
> +            }
> +
> +            if (sscanf(buf, "%u-%u", &start, &end) != 2) {
> +                if (sscanf(buf, "%u", &start) != 1) {
> +                    fprintf(stderr, "xl: Invalid color range: %s\n", buf);
> +                    exit(1);
> +                }
> +                end = start;
> +            }
> +            else if (start > end) {
> +                fprintf(stderr,
> +                        "xl: Start color is greater than end color: %s\n", buf);
> +                exit(1);
> +            }
> +
> +            /* Check for overlaps */
> +            for (k = start; k <= end; k++) {
> +                for (p = 0; p < b_info->num_colors; p++)
> +                    if (b_info->colors[p] == k) {
> +                        fprintf(stderr, "xl: Overlapped ranges not allowed\n");
> +                        exit(1);
> +                    }
> +            }
> +
> +            cur_index = b_info->num_colors;
> +            b_info->num_colors += (end - start) + 1;
> +            b_info->colors = (uint32_t *)realloc(b_info->colors,
> +                                sizeof(*b_info->colors) * b_info->num_colors);
> +
> +            for (k = start; k <= end; k++)
> +                b_info->colors[cur_index++] = k;
> +        }
> +    }
> +
>       if (!xlu_cfg_get_long (config, "vcpus", &l, 0)) {
>           vcpus = l;
>           if (libxl_cpu_bitmap_alloc(ctx, &b_info->avail_vcpus, l)) {

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 19:01:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 19:01:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427951.677599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olxGv-0007fV-7B; Fri, 21 Oct 2022 19:01:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427951.677599; Fri, 21 Oct 2022 19:01:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olxGv-0007fO-3o; Fri, 21 Oct 2022 19:01:33 +0000
Received: by outflank-mailman (input) for mailman id 427951;
 Fri, 21 Oct 2022 19:01:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1mzs=2W=citrix.com=prvs=28632f022=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olxGt-0007fI-QN
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 19:01:31 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c4152db6-5172-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 21:01:29 +0200 (CEST)
Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 15:01:08 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DS7PR03MB5430.namprd03.prod.outlook.com (2603:10b6:5:2c9::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Fri, 21 Oct
 2022 19:01:01 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 19:01:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4152db6-5172-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666378889;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=qilwvmJ6SzWIy26zLCXFDIh2qV9fRmIr13OxR7GzFEQ=;
  b=SeCGV91ErwolBbo0QAx8nYF8RS6kuVIQfvbetknWh9w6UqiGf8OXS7R1
   /mULtHLZBHGvUOcbkVbwRUxDowS1s7DS6q1tBLTMn/EuXjBdYulCHiBiO
   /UuCC9BYSpWBu/1zSDOJfmH821Ys9CVmv8jEmrqbnFLWapCtpnOoz5RKJ
   Q=;
X-IronPort-RemoteIP: 104.47.73.168
X-IronPort-MID: 82377226
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:XTUnk6jyB+8mwklYWfOfF5nWX161QBEKZh0ujC45NGQN5FlHY01je
 htvW26FOf6KY2bwLtF/Pdvl8BkBu5WEmIJrTANtri41QyMb9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmP6kT5jcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWVO7
 +MCC2ogVx2Ou+7qzLv8E+JQ19t2eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVIhuFTuGIO9ltiibMNZhEuH4
 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurAtlNS+fiqJaGhnWrn3BMMw9KbmK24uu90EvgfvFvC
 hAtr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6
 VaPkPvgHzkpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptz8+oc6i0qTSs45SfDlyNroBTv33
 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CAs56s8K7xooG9g
 UU5
IronPort-HdrOrdr: A9a23:q0yrjK0HxvsmegWU1QfPKwqjBRFyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O
 UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTObNSRP5uw/zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY
 fABK5r
X-IronPort-AV: E=Sophos;i="5.95,202,1661832000"; 
   d="scan'208";a="82377226"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TGwVpFqf8rhf6hfQn26uzzkg7SepbxpaQKLLu+OauCOqvAAKFEmpjBFqQgtfSokbkU3CXmdhxaIMxFWvTVgZJDoUluft6SE6oJMdMUECwpTGi1PdZBGisN98xrGH3CaXrDcMIqaMRRBgpynZeMgDcO9YHO3XLo4l3+R8IJ2nKxQr/jc9R+vmhW6Sy6pYfr2gkTCxYmfV5X6xua6yNODyDucqYEsLYigh3vzPxRyT4uYzoz858Thv5WZ+Y11dXTvJlZyH3lGcdPKgHjXPzhJlmQ3o83N1QN8yKNiVpOgWNh/7qhRQRDmTsp+zDHjkpTes1gQ+AHM/tmc19nhvwU6hSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qilwvmJ6SzWIy26zLCXFDIh2qV9fRmIr13OxR7GzFEQ=;
 b=jnO8bVMD2Jiwx2dJC6Az24E68QixEDquAan8STcXtgLFlDYGVVLRuNXdrGrMyUwV+KfcDfUyTBSOH45uFyuRg3S9yN5K5DRj7IDUnCEPXDatNjBshb3IQELjJwPxPUlPvvOcbmnMF0Nr2GR6hNzhDbkb3gdzLk13+xJ8BMx2cp+L0G0nrHCRwjZ22wJzUdGKDQXe+K5ztGVG6iX+rnbdJa+GQ5hTn+eXuK0w7a0iemuINX0vP/WV6UnVhXCKB+74i0+u51qzivk60OUWdBzhsSNNv3rbdnB25JRO3BdCuZ/mBtH6gMiTk33bbLUc5Sf81AExVv/nEphA4+7pq64zpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qilwvmJ6SzWIy26zLCXFDIh2qV9fRmIr13OxR7GzFEQ=;
 b=pawym1VvGWwIk1fh+oqsLoS4AyN/oKfHF3Fe1zhuHta1Bx2XEj3tbcKC3VZu6jK0roqawXK5jZbyun02bG3IiP/2Zsn/HRxO0iQ2Dbniy0LTDyTZLk6BEIJHRL2D82TCYBjT+LCmL55mqzQWlXEq4fYE9yFn97Qfnm+f8+uAiLs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Henry.Wang@arm.com" <Henry.Wang@arm.com>, Wei Liu <wl@xen.org>, Anthony
 Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.17?] test/vpci: enable by default
Thread-Topic: [PATCH for-4.17?] test/vpci: enable by default
Thread-Index: AQHY5G6FfAZD2+fTa0a3sP1MAXO4Za4ZNg6A
Date: Fri, 21 Oct 2022 19:01:01 +0000
Message-ID: <ba118539-4c07-d03a-9b52-a7a45e3d16f0@citrix.com>
References: <20221020102706.29267-1-roger.pau@citrix.com>
In-Reply-To: <20221020102706.29267-1-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5430:EE_
x-ms-office365-filtering-correlation-id: c7e1c821-5012-4cb9-c35c-08dab39698ca
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 3lukfrO0/WCNNDYq8BUtAkk6xk1w9HWelbjvPVCPuv+SgE72cmd1x1+72IqLQd0gnx6w0H+q5UQvmM+PXifPW99DI76CpIHSTn13XMoVRprtroRXlSdbOyUFYTdK5X7VYFB3qDGxmJhxfPh+mjbYOMTel2VmmQCgKJuYBlnodcUnPrjw6iKdJlcIhylo3eGV+nzbrIeVlUQMCFNlmgzL98LQk6M1F9QyOQuPYuAdIgaiK3KI2Lbrroxh1AhZAprAwENpqv9OAsbDgv/Y5n3EYoXhAPcNWvs8wbfKVqyRaQH5+biic8OZHqhezbG1DTOURfQWZlMvLFuU6vcQQEZzgxd1pZ/Eamk5sDb4hoNwvCYIIWn5RZA9uwo6DeOa99Z1Bm7ezDx4xCLT8e4KJJUdefZmJlrtCw64Lif6LE1/5Vw9chOjW3bNs1QKcUcDfntrzxjzONLINpojA2+4IgePqkACysg4EgIgjBwWL6bq0PVpA+z01amL3B1uRB59BeKFn2Q1o1cShjBGmF0Qk0RnutunIUzQ2PtwMQTUf0iXylt6Ux7OXdbHrVFP0VGXHMf5sWkaj1zFcGHvRChMMEpPFADX2FCFBvc6lUylLaLnzwe38qrh/Fop3+fHRW8lrK8ZOkh9WcTpYqnEXcIhBOhR1A2HiiKJa2BSbNRqw8lP/hj7OTLcLrGv8hvWuO1/f113LvfJT+b6LkzofKfBX5l/4sSTwiNFJbMwKcS6U3Fvu3eu5lxsbS+LAtaCyLhL0ayqOHvLfNFMCayKPITs6DBmACQ7TBls7iPeenr0Gur3kFlrY7yIKkWoZKScFFHxp1ngupKMADwWWH2xBLhS7NNYmQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199015)(107886003)(66446008)(4326008)(36756003)(110136005)(54906003)(91956017)(316002)(6506007)(66556008)(53546011)(8936002)(41300700001)(64756008)(5660300002)(38100700002)(122000001)(38070700005)(82960400001)(2616005)(186003)(8676002)(2906002)(66946007)(66476007)(86362001)(31686004)(83380400001)(76116006)(478600001)(26005)(71200400001)(6486002)(6512007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?REJXbnkyb0xuNlRTby83NEVLc0lPQTBiMlYrTkFIRTZNWDZnczEvOTBDRWVu?=
 =?utf-8?B?bG01M1hUODZQajNDbTRQWGpveUVweWo0UWNFeGpnTnozVktwWHhNcWw5akZR?=
 =?utf-8?B?Qmg5clZZZlVlcnB1UWc4bXU5RmU1ZlZjOWZyTlJzNWZMVzY1U09uSXF0NG5k?=
 =?utf-8?B?S2FqdktQdG9qamJONktza1c0UTlmUTRHTXpiUFB6K2ZkeGVlcnB6SktvaDJ2?=
 =?utf-8?B?SGs1UDVOdVBjQ1EzNW44cC9DRjVTTk1hdkhsdlhDMFVRUnBVWWRFWHBueGVR?=
 =?utf-8?B?ZXNESmVhOXp4eUNlL0U2bk1XOUJOWjZueU1sN3RDTytsaThSdVVGNkZoa2lv?=
 =?utf-8?B?SGRaTExQSWczK2IyTU9qT3YyWmJ1a1VXbDh1dktOME5SS01Sa3p0SXMvOENJ?=
 =?utf-8?B?UHYyWkZLK1YyV2xJRWwrTXNsckV5SkxHQ2Y1VFhUK2VjQjlEdFpKVzNncVR0?=
 =?utf-8?B?U0E0OFMvTFBtVCtDa2cxSWN4dlpIYitPQWhObEVZUkZLbmRXbUFXU010UWkz?=
 =?utf-8?B?QTRLYVBqNVRWSGMzNE9oZlBLSVpEdU1QNmZIVnpoVVNrdGlXaEN4SUhZTTdv?=
 =?utf-8?B?eHZmTzRiMGR1SU1GeExmUTVPK3pzK2xiY1dDUWNrbGJPdjVObEwvbmltdlFs?=
 =?utf-8?B?cnRtclpXcVhxK1JCVWZjK1JVQTdML2tEbXdFQVZmV25TTEJxeis3TEdMeVpC?=
 =?utf-8?B?cW1uWkIyNWU5cnBVWS9JYzZtKzhpaHMrakdXVjNUUVp0ZXFxVVc1c2FIQncv?=
 =?utf-8?B?NG9LdGNnUFNSQ0FVV1dsckhtMFZSdlhtY1ZtMmQwTFpsQUlDUER2R2NVWUt0?=
 =?utf-8?B?Sk9BL01BdkJnY0IxZ1VFNnRjNXNRelZaRUhiRTNWN2FBeFdpcHk3aW12ZDZY?=
 =?utf-8?B?S3c3QUNLcm9TUkxEa2ZZVzdnbDIxbUxmSjhEVUtFUnRReUZFVEszRWdnNmh6?=
 =?utf-8?B?YmpBYkRsb3pZdERWSm5iTXhwdld2WGQvN1UxZXlobkJNOU5EaGhPWVpHRkJX?=
 =?utf-8?B?NUJyVTNEN0s0QkE4Z0NGdG05UzhYNUEydjNEMHJBaTUrL1N3dFZHSmNpTE4v?=
 =?utf-8?B?TW9nMXhsZ0dMdWVyNlNQRnlvS1EwU3NTYjN5dUdITm9KQnRndXZOT3pybldx?=
 =?utf-8?B?NlRPcUV3U0Z4WElielVVTDNUTFNyMEprWFQwYzl6QjBUUTJqRzRKazZJQnZI?=
 =?utf-8?B?ZVVRREE1OGExZ2FkSnozb2FPWDdxdTlyNEtZZlNrUERLWmUrci9sZExNR01D?=
 =?utf-8?B?U1M2djBBWkJ4YXpEU0c0Q3BWMUdFdHhiR2RaYWhSanZUWkQxNnFOUWJzRXNB?=
 =?utf-8?B?dWhDSVpxazlqNUhFRldoQmpaZmMwWWt5dkVDSlpFWWU5WFlwTHhXYU5GMFNj?=
 =?utf-8?B?azZLaDBMS0gzaUJ5NVRKQUl3eFNIc3FqMDJ4VWEyWTcrY2NjenR1RjNRYjZx?=
 =?utf-8?B?TlFkck1vb2JkT2laRGI0Mzl2cVM0Szkxd3NLZ1BWalFpVGdsUEhJNytmdG13?=
 =?utf-8?B?K25NNHZkNFN4Nzh0R1dRQVgvM0xRTmQxSDlmOWVpcmZLUktrUlBuNmJwRlhy?=
 =?utf-8?B?Zmtib0ZFY2pMVmFxbHZJVmxSUldLKzhBNklCdUlKdUZJb3RhRlJlRit2OFU4?=
 =?utf-8?B?eWNoeXFValk2cnJ6ZHRHejRPVExiVzhnQXNqZFFPMytmNlAzR0RuZWM5MUFh?=
 =?utf-8?B?Y05iblNCVCtMSHRSamhDb3BRcVorVHhPVWw0eVJUVkoxcTBIWlFUcktsVHAv?=
 =?utf-8?B?MW1QcU1NNklDdVhETndqRG9QTnBOclpaWE9iUlJBa051WmxWU3lWMG00UnBW?=
 =?utf-8?B?MTdEdkRTU0YyeE9BZ2tLMEdic2IwVzVRU3d6VVkxTEg1aXpCSFY4dmtlMEpJ?=
 =?utf-8?B?MGdHUlNoQnlFcy9WS0R0eVZESzJaVU5yUEszOGpzd0VyZmJUeHZibnJOWnJ0?=
 =?utf-8?B?OWNnUmliMjdIbENnZld2ZmJZZjU4ZFVVQmRjM2hGcURpN3RYT0lrYUNGYXpZ?=
 =?utf-8?B?d3FzOTIyL3d0K05ic1RxM2dacWRZbDFoVDV4Rm5vY1NpYjRNTXlTNngydzRQ?=
 =?utf-8?B?Z3h1aGZCUzViaXVZOXhhTU91VWIwVnNucGNUZUdFWTVqSjUzbjlVK2NWRXBU?=
 =?utf-8?Q?HUlIVeDe8pzZyYY1lbSrkoRSb?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E8CAD264BC2BED4393D167C842046582@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7e1c821-5012-4cb9-c35c-08dab39698ca
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 19:01:01.5925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: obLaO19H93+PTASok4vj7yllciG7HzKIMnNAWVybpYLjnbhQ9PcBcfvj0F8ccwXNhs7NW2UX3cAMypmvtJxsQN4q5V3aDTY5Hc0SXv1dAWE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5430

T24gMjAvMTAvMjAyMiAxMToyNywgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBDT05GSUdfSEFT
X1BDSSBpcyBub3QgZGVmaW5lZCBmb3IgdGhlIHRvb2xzIGJ1aWxkLCBhbmQgYXMgYSByZXN1bHQg
dGhlDQo+IHZwY2kgaGFybmVzcyB3b3VsZCBuZXZlciBnZXQgYnVpbGQuICBGaXggdGhpcyBieSBi
dWlsZGluZyBpdA0KPiB1bmNvbmRpdGlvbmFsbHksIHRoZXJlJ3Mgbm90aGluZyBhcmNoIHNwZWNp
ZmljIGluIGl0Lg0KPg0KPiBSZXBvcnRlZC1ieTogQW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3Bl
cjNAY2l0cml4LmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIu
cGF1QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBXaGlsZSBub3Qgc3RyaWN0bHkgYSBidWdmaXgsIEkg
dGhpbmsgaXQncyB3b3J0aCBhZGRpbmcgdGhpcyBjaGFuZ2UgdG8gdGhlDQo+IHJlbGVhc2UgaW4g
b3JkZXIgdG8gYWx3YXlzIGJ1aWxkIHRoZSB2cGNpIHRlc3QgaGFyZG5lc3MgYW5kIHByZXZlbnQg
aXQNCj4gZnJvbSBiaXRyb3R0aW5nLg0KPiAtLS0NCj4gIHRvb2xzL3Rlc3RzL01ha2VmaWxlIHwg
MiArLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+
DQo+IGRpZmYgLS1naXQgYS90b29scy90ZXN0cy9NYWtlZmlsZSBiL3Rvb2xzL3Rlc3RzL01ha2Vm
aWxlDQo+IGluZGV4IDMzZTMyNzMwYzQuLmQ5OTE0NmQ1NmEgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xz
L3Rlc3RzL01ha2VmaWxlDQo+ICsrKyBiL3Rvb2xzL3Rlc3RzL01ha2VmaWxlDQo+IEBAIC0xMCw3
ICsxMCw3IEBAIFNVQkRJUlMtJChDT05GSUdfWDg2KSArPSB4ODZfZW11bGF0b3INCj4gIGVuZGlm
DQo+ICBTVUJESVJTLXkgKz0geGVuc3RvcmUNCj4gIFNVQkRJUlMteSArPSBkZXByaXYNCj4gLVNV
QkRJUlMtJChDT05GSUdfSEFTX1BDSSkgKz0gdnBjaQ0KPiArU1VCRElSUy15ICs9IHZwY2kNCg0K
SSdtIGFmcmFpZCB0aGlzIGlzIG9ubHkgaGFsZiB0aGUgZml4LsKgIFRoZSBvdGhlciBoYWxmIGlz
Og0KDQpkaWZmIC0tZ2l0IGEvdG9vbHMvdGVzdHMvdnBjaS9NYWtlZmlsZSBiL3Rvb2xzL3Rlc3Rz
L3ZwY2kvTWFrZWZpbGUNCmluZGV4IDUwNzViYzJiZTI4Yy4uMzM2OTA0OTU4ZjZhIDEwMDY0NA0K
LS0tIGEvdG9vbHMvdGVzdHMvdnBjaS9NYWtlZmlsZQ0KKysrIGIvdG9vbHMvdGVzdHMvdnBjaS9N
YWtlZmlsZQ0KQEAgLTIyLDYgKzIyLDggQEAgZGlzdGNsZWFuOiBjbGVhbg0KwqANCsKgLlBIT05Z
OiBpbnN0YWxsDQrCoGluc3RhbGw6DQorwqDCoMKgwqDCoMKgICQoSU5TVEFMTF9ESVIpICQoREVT
VERJUikkKExJQkVYRUNfQklOKQ0KK8KgwqDCoMKgwqDCoCAkKElOU1RBTExfUFJPRykgJChUQVJH
RVQpICQoREVTVERJUikkKExJQkVYRUNfQklOKQ0KwqANCsKgdnBjaS5jOiAkKFhFTl9ST09UKS94
ZW4vZHJpdmVycy92cGNpL3ZwY2kuYw0KwqDCoMKgwqDCoMKgwqAgIyBSZW1vdmUgaW5jbHVkZXMg
YW5kIGFkZCB0aGUgdGVzdCBoYXJuZXNzIGhlYWRlcg0KDQpzbyBpdCBjYW4gYWN0dWFsbHkgZ2V0
IGRlcGxveWVkIHNvbWV3aGVyZSB1c2VmdWwuDQoNCn5BbmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 19:08:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 19:08:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427956.677609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olxNe-0008S2-SK; Fri, 21 Oct 2022 19:08:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427956.677609; Fri, 21 Oct 2022 19:08:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olxNe-0008Rv-Pl; Fri, 21 Oct 2022 19:08:30 +0000
Received: by outflank-mailman (input) for mailman id 427956;
 Fri, 21 Oct 2022 19:08:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QljK=2W=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olxNc-0008Rp-Vg
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 19:08:29 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bcdfb8de-5173-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 21:08:26 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 51E9961F3C;
 Fri, 21 Oct 2022 19:08:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 102EAC433C1;
 Fri, 21 Oct 2022 19:08:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bcdfb8de-5173-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666379303;
	bh=vsquIKFbPGFjQLcdz5lPZnbWtZFyrvdvchLUS9v9ONM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=XG8HqBZGj5MHALBw2RK03qvuK7kigga8Du+ZFAu2etdNpNMRqzD6fWgiaC2UfOZdn
	 YJrQFKQJhYj+1HXGDnNvX6lvjSq3BJVXsf0MiHOEwZcGRz2IPkT9YR3VnxrWNaPh+D
	 RS77+jwHJpRr1I9JOM9H2V84hWku/MzIqwpWCtLjsp2iQ0I9QEDX7BzvLHzVOEyC/2
	 YE2w896GnLEgXKAeOtqWpPY2jvLaQ30e1wDnAdPEiYZ46rEhpGOVeKXVjqLB+yUsWy
	 dJmaER8tEfroWVYbezXl/8ED0WDrCOiHFIoG/3xwS/MJtSfT/3LH5W5agPkFFY+tWX
	 wKq+Mhb8buwvg==
Date: Fri, 21 Oct 2022 12:08:21 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Henry Wang <Henry.Wang@arm.com>
Subject: Re: [for-4.17] automation: Build Xen according to the type of the
 job
In-Reply-To: <20221021132238.16056-1-michal.orzel@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210211208140.3873@ubuntu-linux-20-04-desktop>
References: <20221021132238.16056-1-michal.orzel@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 21 Oct 2022, Michal Orzel wrote:
> All the build jobs exist in two flavors: debug and non-debug, where the
> former sets 'debug' variable to 'y' and the latter to 'n'. This variable
> is only being recognized by the toolstack, because Xen requires
> enabling/disabling debug build via e.g. menuconfig/config file.
> As a corollary, we end up building/testing Xen with CONFIG_DEBUG always
> set to a default value ('y' for unstable and 'n' for stable branches),
> regardless of the type of the build job.
> 
> Fix this behavior by setting CONFIG_DEBUG according to the 'debug' value.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Xen used debug variable to control the build type before switching to Kconfig.
> Support for GitLab CI was added later, which means that this issue was always
> present. This is a low risk for 4.17 with a benefit of being able to test Xen
> in both debug and non-debug versions.
> ---
>  automation/scripts/build | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/automation/scripts/build b/automation/scripts/build
> index 8c0882f3aa33..a5934190634b 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -21,12 +21,13 @@ if [[ "${RANDCONFIG}" == "y" ]]; then
>      make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
>      hypervisor_only="y"
>  else
> +    echo "CONFIG_DEBUG=${debug}" > xen/.config
> +
>      if [[ -n "${EXTRA_XEN_CONFIG}" ]]; then
> -        echo "${EXTRA_XEN_CONFIG}" > xen/.config
> -        make -j$(nproc) -C xen olddefconfig
> -    else
> -        make -j$(nproc) -C xen defconfig
> +        echo "${EXTRA_XEN_CONFIG}" >> xen/.config
>      fi
> +
> +    make -j$(nproc) -C xen olddefconfig
>  fi
>  
>  # Save the config file before building because build failure causes the script
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 19:36:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 19:36:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427966.677627 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olxow-0003fB-46; Fri, 21 Oct 2022 19:36:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427966.677627; Fri, 21 Oct 2022 19:36:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olxow-0003f4-1E; Fri, 21 Oct 2022 19:36:42 +0000
Received: by outflank-mailman (input) for mailman id 427966;
 Fri, 21 Oct 2022 19:36:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QljK=2W=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olxou-0003ex-Hy
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 19:36:40 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id adc197f3-5177-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 21:36:38 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 3BD2261F0F;
 Fri, 21 Oct 2022 19:36:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCA30C433D6;
 Fri, 21 Oct 2022 19:36:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adc197f3-5177-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666380996;
	bh=3wUmFemuLRRB8bEr2Ii+cnTcFCjf12B7K2pMzadxGFU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=hnrE9cm/sOFyN7TbJI+MdR2Hx7MID/LrJyxtmigKZ71r4+EIZgeU2z2oX3bVrqhGA
	 yOyLvKC6sNKmZvy2rZe+urQz5QT8/q57MZveSxaEfvj6lwHcSBn8UukBuxS96bs8WO
	 c0dqtShyxpi5JbWnDLpkslSLyilWcbXafW956Pj5Xbf7pe4B6gy5knnv5vOQtfWkLz
	 kYt1mRMT6NX+lnuDBOhz4fpq6dOloygcXsqYlJRRnnTSHNzFxJ+3eYuOblEcKyNnED
	 JtXkqRHiw9QruCafMWJpUoA9dRz40WhCUDGlTP7XM+ESAk/9cOAXDwU98hHdEjLZDQ
	 0Lp5XW2iQbXng==
Date: Fri, 21 Oct 2022 12:36:34 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
cc: Michal Orzel <michal.orzel@amd.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Henry Wang <Henry.Wang@arm.com>
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot cpupools
 test
In-Reply-To: <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
Message-ID: <alpine.DEB.2.22.394.2210211211090.3873@ubuntu-linux-20-04-desktop>
References: <20221021165341.7905-1-michal.orzel@amd.com> <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1601944633-1666380495=:3873"
Content-ID: <alpine.DEB.2.22.394.2210211228190.3873@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1601944633-1666380495=:3873
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210211228191.3873@ubuntu-linux-20-04-desktop>

On Fri, 21 Oct 2022, Andrew Cooper wrote:
> On 21/10/2022 17:53, Michal Orzel wrote:
> > Null scheduler is not enabled on non-debug Xen builds so the current
> > test can lead to a failure on such jobs. We still want to test that we
> > can assign the cpupool to a domU with a different scheduler than default
> > one (credit2). Switch to credit as it is enabled by default.
> >
> > Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
> > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> 
> /sigh - I'm sure I nacked that stupidity to begin with.  apparently not...
> 
> It is totally bogus for CONFIG_DEBUG to influence logical chunks of
> functionality like this.  The CI script is good in its current form.
> 
> RTDS and ARINC should be default n.
> 
> NULL is more tricky.  PV_SHIM is explicitly security supported, and has
> been for years, so the "UNSUPPORTED" is bogus, whatever the default is.
> 
> As NULL is explicitly tested in CI, it's clearly supported, and probably
> ought to be on default.
> 
> 
> Please instead fix Kconfig to not be broken.  That will be a far better
> fix overall for people.
> 
> As a more general note, tests which are using non-default pieces of
> logic ought to activate them explicitly.


I agree with you, but first let me clarify the word "supported".


In Xen Project "supported" implies extra efforts to follow the security
process and of course the security team should be on board with it. If
we say "supported, non security supported" we don't need to follow the
security process but still we sign up for backporting fixes to the
stable tree. It is less extra effort but still some extra effort is
involved.

So, this specific issue aside, I think that as we expand the testing
capabilities of gitlab-ci, we'll have tests for things that are not
necessarily neither "supported" nor "supported, non security supported".


For the NULL scheduler, it is clearly important to many users so it
would be valuable to move it to "supported, non security supported" and
enabling it by default in the build. I don't recall if we still have any
known outstanding issues with it. I think we need a separate email
thread for that discussion and I would understand if the decision is not
to change NULL support status for the 4.17 release (maybe for the 4.18
release?).


In any case, we don't need CONFIG_DEBUG to enable CONFIG_UNSUPPORTED. It
is just that UNSUPPORTED and NULL don't get enabled by default in the
non-DEBUG build. So to fix gitlab-ci, we can simply enable
CONFIG_UNSUPPORTED explicitly for the builds where we need it
(alpine-3.12-gcc-arm64-boot-cpupools).
--8323329-1601944633-1666380495=:3873--


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 20:08:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 20:08:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427971.677638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olyJv-0007Ne-KQ; Fri, 21 Oct 2022 20:08:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427971.677638; Fri, 21 Oct 2022 20:08:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olyJv-0007NX-H4; Fri, 21 Oct 2022 20:08:43 +0000
Received: by outflank-mailman (input) for mailman id 427971;
 Fri, 21 Oct 2022 20:08:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QljK=2W=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olyJu-0007NR-Pk
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 20:08:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 282091fe-517c-11ed-91b5-6bf2151ebd3b;
 Fri, 21 Oct 2022 22:08:41 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C71D1B82C98;
 Fri, 21 Oct 2022 20:08:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B79BC433C1;
 Fri, 21 Oct 2022 20:08:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 282091fe-517c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666382918;
	bh=JvVuwGFgzjcQue281gO7KLG4H7q04b7BOWjJNOmrTUA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oyARZFzA3Rybv6jI7P9f+9HpWEf0RZJ0DACP+ZaQMq1CVLeiwU24NZVXLzIKoYa2r
	 NFXpTq4n9sZGDkVpC3qrsj9MOSXfl/tPXQA/DZHI8ZTw2sWsVrwqakbg+/kAvXZuLn
	 Hvev14eUbaecZGUxS0huWBMslcXIVMKkrWue+hBc1gkvPBjk29bmJ9TGR7Z1MhE0eM
	 VqA6GCek1wJR3c5dsZAw9SYczD9rqAaeMhReSIJZrj5ypvUBVXXsTmVJ8oc9TPMMux
	 GWFvazRrepCZWvKVcXDNRkvbJ8f4zAqraXGwYcJms2WdCdvrw4z4yRlL7Sa7ypOovC
	 tWjNnkZjOkU4A==
Date: Fri, 21 Oct 2022 13:08:36 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V3] xen/virtio: Handle PCI devices which Host controller
 is described in DT
In-Reply-To: <20221021172408.77397-1-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210211258050.3873@ubuntu-linux-20-04-desktop>
References: <20221021172408.77397-1-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 21 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the same "xen-grant-dma" device concept for the PCI devices
> behind device-tree based PCI Host controller, but with one modification.
> Unlike for platform devices, we cannot use generic IOMMU bindings
> (iommus property), as we need to support more flexible configuration.
> The problem is that PCI devices under the single PCI Host controller
> may have the backends running in different Xen domains and thus have
> different endpoints ID (backend domains ID).
> 
> Add ability to deal with generic PCI-IOMMU bindings (iommu-map/
> iommu-map-mask properties) which allows us to describe relationship
> between PCI devices and backend domains ID properly.
> 
> To avoid having to look up for the PCI Host bridge twice and reduce
> the amount of checks pass an extra struct device_node *np to both
> xen_dt_grant_init_backend_domid() and xen_is_dt_grant_dma_device().
> While at it also pass domid_t *backend_domid instead of
> struct xen_grant_dma_data *data to the former.
> 
> So with current patch the code expects iommus property for the platform
> devices and iommu-map/iommu-map-mask properties for PCI devices.
> 
> The example of generated by the toolstack iommu-map property
> for two PCI devices 0000:00:01.0 and 0000:00:02.0 whose
> backends are running in different Xen domains with IDs 1 and 2
> respectively:
> iommu-map = <0x08 0xfde9 0x01 0x08 0x10 0xfde9 0x02 0x08>;
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> than for platform devices.
> 
> Changes V1 -> V2:
>    - update commit description
>    - rebase
>    - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> 
> Changes V2 -> V3:
>    - update commit description, add an example
>    - drop xen_dt_map_id() and squash xen_dt_get_pci_host_node() with
>      xen_dt_get_node()
>    - pass struct device_node *np to xen_is_dt_grant_dma_device() and
>      xen_dt_grant_init_backend_domid()
>    - pass domid_t *backend_domid instead of struct xen_grant_dma_data *data
>      to xen_dt_grant_init_backend_domid()
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/20221015153409.918775-1-olekstysh@gmail.com/
> 
> Based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
> ---
>  drivers/xen/grant-dma-ops.c | 80 ++++++++++++++++++++++++++++++-------
>  1 file changed, 66 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index daa525df7bdc..76b29d20aeee 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>  #include <linux/module.h>
>  #include <linux/dma-map-ops.h>
>  #include <linux/of.h>
> +#include <linux/pci.h>
>  #include <linux/pfn.h>
>  #include <linux/xarray.h>
>  #include <linux/virtio_anchor.h>
> @@ -292,12 +293,37 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> +static struct device_node *xen_dt_get_node(struct device *dev)
>  {
> -	struct device_node *iommu_np;
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		struct pci_bus *bus = pdev->bus;
> +
> +		/* Walk up to the root bus to look for PCI Host controller */
> +		while (!pci_is_root_bus(bus))
> +			bus = bus->parent;
> +
> +		return of_node_get(bus->bridge->parent->of_node);
> +	}
> +
> +	return of_node_get(dev->of_node);
> +}
> +
> +static bool xen_is_dt_grant_dma_device(struct device *dev,
> +					struct device_node *np)
> +{
> +	struct device_node *iommu_np = NULL;
>  	bool has_iommu;
>  
> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +
> +		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_np, NULL))
> +			return false;
> +	} else
> +		iommu_np = of_parse_phandle(np, "iommus", 0);
> +
>  	has_iommu = iommu_np &&
>  		    of_device_is_compatible(iommu_np, "xen,grant-dma");
>  	of_node_put(iommu_np);

I think we can remove xen_is_dt_grant_dma_device and just call
xen_dt_grant_init_backend_domid passing a NULL backend_domid?

It is a bit annoying that we are basically doing the same device tree
parsing twice in a row given that the callers do:

	if (xen_is_grant_dma_device(dev))
		xen_grant_setup_dma_ops(dev);

Maybe we could move the backend_domid allocation and setting to
xen_dt_grant_init_backend_domid, which would end up being done from
the xen_is_grant_dma_device() call chain, and only leave setting
dev->dma_ops from xen_grant_setup_dma_ops().

This way the parsing would be done only once? What do you think? This
suggestion is optional, I am OK also with only removing
xen_is_dt_grant_dma_device.


> @@ -307,9 +333,17 @@ static bool xen_is_dt_grant_dma_device(struct device *dev)
>  
>  bool xen_is_grant_dma_device(struct device *dev)
>  {
> +	struct device_node *np;
> +
>  	/* XXX Handle only DT devices for now */
> -	if (dev->of_node)
> -		return xen_is_dt_grant_dma_device(dev);
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		bool ret;
> +
> +		ret = xen_is_dt_grant_dma_device(dev, np);
> +		of_node_put(np);
> +		return ret;
> +	}
>  
>  	return false;
>  }
> @@ -323,14 +357,26 @@ bool xen_virtio_mem_acc(struct virtio_device *dev)
>  }
>  
>  static int xen_dt_grant_init_backend_domid(struct device *dev,
> -					   struct xen_grant_dma_data *data)
> +					   struct device_node *np,
> +					   domid_t *backend_domid)
>  {
> -	struct of_phandle_args iommu_spec;
> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
>  
> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> -			0, &iommu_spec)) {
> -		dev_err(dev, "Cannot parse iommus property\n");
> -		return -ESRCH;
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +
> +		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_spec.np,
> +				iommu_spec.args)) {
> +			dev_err(dev, "Cannot translate ID\n");
> +			return -ESRCH;
> +		}
> +	} else {
> +		if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
> +				0, &iommu_spec)) {
> +			dev_err(dev, "Cannot parse iommus property\n");
> +			return -ESRCH;
> +		}
>  	}
>  
>  	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> @@ -346,7 +392,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>  	 * The endpoint ID here means the ID of the domain where the
>  	 * corresponding backend is running
>  	 */
> -	data->backend_domid = iommu_spec.args[0];
> +	*backend_domid = iommu_spec.args[0];
>  
>  	return 0;
>  }
> @@ -354,6 +400,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>  void xen_grant_setup_dma_ops(struct device *dev)
>  {
>  	struct xen_grant_dma_data *data;
> +	struct device_node *np;
>  
>  	data = find_xen_grant_dma_data(dev);
>  	if (data) {
> @@ -365,8 +412,13 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  	if (!data)
>  		goto err;
>  
> -	if (dev->of_node) {
> -		if (xen_dt_grant_init_backend_domid(dev, data))
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		int ret;
> +
> +		ret = xen_dt_grant_init_backend_domid(dev, np, &data->backend_domid);
> +		of_node_put(np);
> +		if (ret)
>  			goto err;
>  	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
>  		dev_info(dev, "Using dom0 as backend\n");
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 21:06:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 21:06:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427979.677655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzDi-0005J4-TB; Fri, 21 Oct 2022 21:06:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427979.677655; Fri, 21 Oct 2022 21:06:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzDi-0005Ix-Ob; Fri, 21 Oct 2022 21:06:22 +0000
Received: by outflank-mailman (input) for mailman id 427979;
 Fri, 21 Oct 2022 21:06:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olzDh-0005Im-EA; Fri, 21 Oct 2022 21:06:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olzDh-0003ln-Aw; Fri, 21 Oct 2022 21:06:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1olzDg-0006T2-T9; Fri, 21 Oct 2022 21:06:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1olzDg-0003uM-SY; Fri, 21 Oct 2022 21:06:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0vrnN8aaatCMeAbocLoDdR/LhU5gXPEnd7QdZMQxvTg=; b=SgmUBhznHbyYwjQ+TAX/gdIDdD
	YY4hD2srNUIA4FUknkMIQcKOoSQgzKaKd0ml8pnyg7DRyJ5KlNlS191CdIX+RmxpQtXJfBQ38cIdK
	dCg+PY8RasVrxd73HV6fTMH+lkfmVJ0Ec1vdv588dQ5gni1T21lNYeA26taPeJVuLN74=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174152-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174152: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 21 Oct 2022 21:06:20 +0000

flight 174152 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174152/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174152
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935
 test-amd64-i386-libvirt-xsm   7 xen-install                fail pass in 174126

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 174126 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174126 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174126 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174126 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174126 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174126 n/a
 build-armhf                   2 hosts-allocate           starved in 174126 n/a

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   67 days
Failing since        173495  2022-10-11 14:08:01 Z   10 days   11 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    8 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 21:14:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 21:14:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427988.677669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzLL-0006qJ-RF; Fri, 21 Oct 2022 21:14:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427988.677669; Fri, 21 Oct 2022 21:14:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzLL-0006qC-NX; Fri, 21 Oct 2022 21:14:15 +0000
Received: by outflank-mailman (input) for mailman id 427988;
 Fri, 21 Oct 2022 21:14:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QljK=2W=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olzLJ-0006q6-Nj
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 21:14:13 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d647046-5185-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 23:14:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6284861F8A;
 Fri, 21 Oct 2022 21:14:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F0FBC433C1;
 Fri, 21 Oct 2022 21:14:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d647046-5185-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666386847;
	bh=x8ql3IN6/9IyGm/rSegdtnRtnypTJTXH9eN/KGLgEn4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=eNaaQJFfixVCNl6Jw+R4ozoyqk0zb0qkiTF1nXxeEbuTMn2avHwNfhoWFTD7Qdnjk
	 Mn2LqD2Sg8BSQWoY2b5284sijZchTJNoBcqQdyt8lsYt6pY1p+5ME8eAAl3bMmcnXZ
	 tv5XJOc1ZmjmPFk1OAnLnR5gpJ3VKvx5IziVBmroOCW9NF59QveRqNuEdVkeAtpvP7
	 mMPlLu4+9quzaaRnbecy+12Z8Tn7TMMDIHFfxXGhfNRud7RkkvkN3ISFMt34b4NGhN
	 owY4uePZRIdIrm1Q0yW6Z0gqPhxZ0bf50EwNvmiHVLaOPP9EgxkVHbuOu8DEmDrmM2
	 7ZlY47v4rx/oQ==
Date: Fri, 21 Oct 2022 14:14:04 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Leo Yan <leo.yan@linaro.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Xen Develop <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Mathieu Poirier <mathieu.poirier@linaro.org>, 
    Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>, 
    jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, 
    wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <Y1J39UsPlM8htxFx@leoy-huanghe.lan>
Message-ID: <alpine.DEB.2.22.394.2210211341440.3873@ubuntu-linux-20-04-desktop>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop> <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop> <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop> <Y1J39UsPlM8htxFx@leoy-huanghe.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 21 Oct 2022, Leo Yan wrote:
> Hi Stefano and all,
> 
> On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote:
> 
> [...]
> 
> > > We can see DomU sends notification with timestamp (raw counter) is
> > > 4989078592 and Dom0 receives the interrupt with timestamp 4989092169.
> > > Since Dom0 and DomU use the same time counter and the counter
> > > frequency is 25MHz, so we can get the delta value (in macroseconds):
> > > 
> > >     (4989092169 - 4989078592) / 25000000 * 1000 * 1000
> > >   = 543us
> > > 
> > > Which means it takes 543us to let Dom0 to receive the notification.
> > > You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should
> > > not have contention for CPU resources.  Seems to me, it's likely Xen
> > > hypervisor takes long time to deliver the interrupt, note, it's not
> > > take so long time for every skb transferring, sometimes the time for
> > > response a notification is short (about ~10us).
> > 
> > Good find. I think this is worth investigating further. Do you have
> > vwfi=native in your Xen command line as well?
> > 
> > After that, I would add printk also in Xen with the timestamp. The event
> > channel notification code path is the following:
> > 
> > # domU side
> > xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
> > xen/arch/arm/vgic.c:vgic_to_sgi
> > xen/arch/arm/vgic.c:vgic_inject_irq
> > xen/arch/arm/vgic.c:vcpu_kick
> > xen/arch/arm/gic-v2.c:gicv2_send_SGI
> > 
> > # dom0 side
> > xen/arch/arm/gic.c:do_sgi
> > xen/arch/arm/traps.c:leave_hypervisor_to_guest
> > 
> > It would be good to understand why sometimes it takes ~10us and some
> > other times it takes ~540us
> 
> Some updates for why it takes several hundreds us for Xen backend driver
> to respond interrupt.  The short answer is the vcpu running Xen backend
> driver needs to switch context, even I have set options "sched=null
> vwfi=native" in Xen command line.
> 
> So please see below detailed logs for how the things happen.
> 
> Let's take the timestamp 3842008681 as the start point, it's the time
> for Xen backend driver sending out notification (xennet_notify_tx_irq);
> at the timestamp 3842008885 the Xen hypervisor injects the interrupt
> (it's about ~8us duration from the start point).
> 
> And then at the timestamp 3842008935 it invokes vcpu_kick() to kick the
> virtual CPU for running Xen forend driver, you could see
> VCPU_PROCESSOR is 11 and VCPU_ID is 9 for dom0, the duration is
> 10.16us from the start point.
> 
> The key point is at this point the vcpu's is_running is 0, this is
> different from the case without long latency which vcpu's is_running
> is 1.  IIUC, Xen hypervisor needs to take time to restore the vcpu's
> context, thus we can see the virtual CPU 9 in Dom0 starts to run at
> the timestamp 3842016505.

is_running should be always 1 with the NULL scheduler and vwfi=native.
That is because VMs are never descheduled. Please double-check.

If you are really running with the NULL scheduler, then I would
investigate why the vCPU has is_running == 0 because it should not
happen.


Now regarding the results, I can see the timestamp 3842008681 for
xennet_notify_tx_irq, 3842008885 for vgic_inject_irq, and 3842008935 for
vcpu_kick. Where is the corresponding TSC for the domain receiving the
notification?

Also for the other case, starting at 3842016505, can you please
highlight the timestamp for vgic_inject_irq, vcpu_kick, and also the one
for the domain receiving the notification?

The most interesting timestamps would be the timestamp for vcpu_kick in
"notification sending domain" [a], the timestamp for receiving the
interrupt in the Xen on pCPU for the "notification receiving domain"
[b], and the timestamp for the "notification receiving domain" getting
the notification [c].

If really context switch is the issue, then the interesting latency
would be between [a] and [b].



> 3842008548              pub-310   [001]    67.352980: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842008548
> 3842008652              pub-310   [001]    67.352984: bprint:               xennet_tx_setup_grant: id=52 ref=820 offset=2 len=1514 TSC: 3842008652
> 3842008681              pub-310   [001]    67.352985: bprint:               xennet_start_xmit: xennet_notify_tx_irq: TSC: 3842008681
> 3842008689 (XEN) leave_hypervisor_to_guest: CPU_ID: 0 TSC: 3842008689
> 3842008766 (XEN) EVTCHNOP_send: CPU_ID: 2 TSC: 3842008766
> 3842008885 (XEN) vgic_inject_irq: CPU_ID: 2 TSC: 3842008885
> 3842008929 (XEN) leave_hypervisor_to_guest: CPU_ID: 14 TSC: 3842008929
> 3842008935 (XEN) vcpu_kick: VCPU_PROCESSOR: 11 VCPU_ID: 9 is_running 0 TSC: 3842008935
> 3842009049 (XEN) leave_hypervisor_to_guest: CPU_ID: 2 TSC: 3842009049
> 3842009322              pub-310   [001]    67.353011: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842009322
> 3842009374              pub-310   [001]    67.353013: bprint:               xennet_tx_setup_grant: id=12 ref=780 offset=2050 len=1514 TSC: 3842009374
> 3842009584              pub-310   [001]    67.353021: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842009584
> 3842009625 (XEN) leave_hypervisor_to_guest: CPU_ID: 15 TSC: 3842009625
> 3842009633              pub-310   [001]    67.353023: bprint:               xennet_tx_setup_grant: id=83 ref=851 offset=2 len=1514 TSC: 3842009633
> 3842009853              pub-310   [001]    67.353032: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842009853
> 3842009899              pub-310   [001]    67.353034: bprint:               xennet_tx_setup_grant: id=5 ref=773 offset=2050 len=1514 TSC: 3842009899
> 3842010080              pub-310   [001]    67.353041: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010080
> 3842010121              pub-310   [001]    67.353043: bprint:               xennet_tx_setup_grant: id=85 ref=853 offset=2 len=1514 TSC: 3842010121
> 3842010316              pub-310   [001]    67.353050: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010316
> 3842010359              pub-310   [001]    67.353052: bprint:               xennet_tx_setup_grant: id=9 ref=777 offset=2050 len=1514 TSC: 3842010359
> 3842010553              pub-310   [001]    67.353060: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010553
> 3842010599              pub-310   [001]    67.353062: bprint:               xennet_tx_setup_grant: id=35 ref=803 offset=2 len=1514 TSC: 3842010599
> 3842010792              pub-310   [001]    67.353069: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842010792
> 3842010838              pub-310   [001]    67.353071: bprint:               xennet_tx_setup_grant: id=17 ref=785 offset=2 len=1514 TSC: 3842010838
> 3842011032              pub-310   [001]    67.353079: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842011032
> 3842011072              pub-310   [001]    67.353081: bprint:               xennet_tx_setup_grant: id=18 ref=786 offset=2 len=1514 TSC: 3842011072
> 3842011124 (XEN) leave_hypervisor_to_guest: CPU_ID: 12 TSC: 3842011124
> 3842011265              pub-310   [001]    67.353088: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842011265
> 3842011309              pub-310   [001]    67.353090: bprint:               xennet_tx_setup_grant: id=86 ref=854 offset=3074 len=606 TSC: 3842011309
> 3842012807 (XEN) leave_hypervisor_to_guest: CPU_ID: 6 TSC: 3842012807
> 3842013038 (XEN) leave_hypervisor_to_guest: CPU_ID: 10 TSC: 3842013038
> 3842013568 (XEN) vgic_inject_irq: CPU_ID: 23 TSC: 3842013568
> 3842013639 (XEN) vcpu_kick: VCPU_PROCESSOR: 23 VCPU_ID: 10 is_running 1 TSC: 3842013639
> 3842013769 (XEN) leave_hypervisor_to_guest: CPU_ID: 4 TSC: 3842013769
> 3842013955 (XEN) leave_hypervisor_to_guest: CPU_ID: 8 TSC: 3842013955
> 3842014327 (XEN) leave_hypervisor_to_guest: CPU_ID: 5 TSC: 3842014327
> 3842014381              pub-310   [001]    67.353213: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842014381
> 3842014433              pub-310   [001]    67.353215: bprint:               xennet_tx_setup_grant: id=89 ref=857 offset=2050 len=1514 TSC: 3842014433
> 3842014621              pub-310   [001]    67.353223: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842014621
> 3842014663              pub-310   [001]    67.353224: bprint:               xennet_tx_setup_grant: id=38 ref=806 offset=2 len=1514 TSC: 3842014663
> 3842014852              pub-310   [001]    67.353232: bprint:               xennet_start_xmit: xennet_start_xmit: TSC: 3842014852
> 3842014909              pub-310   [001]    67.353234: bprint:               xennet_tx_setup_grant: id=4 ref=772 offset=2 len=1422 TSC: 3842014909
> 3842015153 (XEN) leave_hypervisor_to_guest: CPU_ID: 1 TSC: 3842015153
> 3842015345 (XEN) leave_hypervisor_to_guest: CPU_ID: 3 TSC: 3842015345
> 3842015823 (XEN) leave_hypervisor_to_guest: CPU_ID: 13 TSC: 3842015823
> 3842016505           <idle>-0     [009]    95.098859: bprint:               xenvif_tx_interrupt: xenvif_tx_interrupt: TSC: 3842016505
> 3842016635           <idle>-0     [009]    95.098863: bprint:               xenvif_tx_build_gops.constprop.0: id=52 ref=820 offset=2 len=1514 TSC: 3842016635
> 3842016648 (XEN) leave_hypervisor_to_guest: CPU_ID: 9 TSC: 3842016648
> 3842016671           <idle>-0     [009]    95.098865: bprint:               xenvif_tx_build_gops.constprop.0: id=12 ref=780 offset=2050 len=1514 TSC: 3842016671
> 3842016700           <idle>-0     [009]    95.098866: bprint:               xenvif_tx_build_gops.constprop.0: id=83 ref=851 offset=2 len=1514 TSC: 3842016700
> 3842016725           <idle>-0     [009]    95.098867: bprint:               xenvif_tx_build_gops.constprop.0: id=5 ref=773 offset=2050 len=1514 TSC: 3842016725
> 
> I did another two experiments.
> 
> One experiment is I tried to append option "dom0_max_vcpus=16" into Xen
> command line, the purpose is I want to allocate 16 virtual CPUs for dom0
> and 4 virtual CPUs for domU, and my system has 32 physical CPUs, in
> theory the physical CPUs are sufficient for dom0 and domU, but I
> didn't see any performance improvement with option
> "dom0_max_vcpus=16".
>
> Another experiment is to append option "dom0_vcpus_pin" in Xen command
> line, this can allow the virtual CPU pins on physical CPU so can avoid
> context switching.  With this option, I can see the throughput is
> improved from 128.26 Mbits/s to 180.3 Mbits/s.  But this result is far
> from the ideal throughput (800+Mbits/s).

Actually this should not happen: like before, dom0_vcpus_pin does
nothing with the NULL scheduler and only changes things for credit. Are
you really sure you are running the tests with sched=null vwfi=native?


> One thing I need to explore is to measure the duration for copying
> data via grant table (based on the log we can see xennet driver setup
> grant table and then xenvif driver fetches data from grant table).  I
> will compare the duration for two directions (from dom0 to domU and
> from domU to dom0).  This part might impact the performance heavily.



From xen-devel-bounces@lists.xenproject.org Fri Oct 21 21:18:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 21:18:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.427996.677690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzPX-0007Yq-Hy; Fri, 21 Oct 2022 21:18:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 427996.677690; Fri, 21 Oct 2022 21:18:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzPX-0007Yj-Cq; Fri, 21 Oct 2022 21:18:35 +0000
Received: by outflank-mailman (input) for mailman id 427996;
 Fri, 21 Oct 2022 21:18:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Jmp5=2W=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1olzPV-0007Yd-4R
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 21:18:33 +0000
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com
 [2a00:1450:4864:20::42f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea25033b-5185-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 23:18:32 +0200 (CEST)
Received: by mail-wr1-x42f.google.com with SMTP id w18so6884225wro.7
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 14:18:32 -0700 (PDT)
Received: from [192.168.1.93] (adsl-214.109.242.138.tellas.gr.
 [109.242.138.214]) by smtp.gmail.com with ESMTPSA id
 f9-20020a5d5689000000b002322bff5b3bsm139163wrv.54.2022.10.21.14.18.30
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 14:18:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea25033b-5185-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=CHuXkRFBZYtj/pjD6zKPtNSshkc/314CFEhvMMU9mwo=;
        b=niIfW1yfMtq0D2LTeMfiS9sOxGaBehdJBUcuBvMrKvFA2iw+bdC7pfoDOMbXDR3zVX
         HGf6EM8VB+IS74RbUa9f78ZzEZdzgHz82o0iyROjPmlNWY50QcLutzmSBxB2bmME78rW
         OHpFTQO0QC1IAzuJ/3ymrVMr+PKPUgW/Ze2t+qC2X7bKMZoyLJRrarfix2AazpmxzrMM
         daw/QukFBe99VabzJLhg5/wM/QQBJkEhL2AOr2u7GRk6DCHb/59Eegdp7U8y86+3FQ8c
         aVgRwZhZtcmQnpOE5csG+4fR+wmK0G+bqYM7jPeYB4eifsrp2Nevus5auJMxB7/uWRLx
         Fh0w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=CHuXkRFBZYtj/pjD6zKPtNSshkc/314CFEhvMMU9mwo=;
        b=gTtIinKBcklV1dtpHQ9cpu2osaPa0sWY/RP+SB84NaqL1rd99Xk2RLYXlJ7nVlbp/4
         kjUmOzyrmBxTSwJwrAF+RLXYCXhz+AhjY3Y11mj5z0+uUF8mR4wwAfQPlGp2pH3oicMO
         SAbBlDiDWezixbd8SU4WJiRkOaYGLG1vcxglcUHLTv4K2qsbUPZ2mN/LbbKgQ/oUPGoE
         4f/oNxKGR+nDjtO7qiaDxGSFjmXJNAFdcpPxbxedUpl7k8moHOTpBdeiVV4geGCZgnXX
         spFvsz1c/aJHHMzHXHpbM3FDIb1lAhdDaI4bwJaHDk2hTVwNgiZVdEYcN52F5ZW5Wzjt
         B7Dw==
X-Gm-Message-State: ACrzQf1n6z3YEgT+cgxnVDtHAY5jeWwz/pSUV8UmupwQ4bsv5pR0PfVB
	i+CAKodECwa3vkyQhm6F5Q4=
X-Google-Smtp-Source: AMsMyM7X5g0JHIzxvGeWgZaN7szR8h31ISW4jQB3ilgR48779q5Rrlrd7unYcBALOj5cyVPbYS7S3Q==
X-Received: by 2002:a5d:4887:0:b0:226:ed34:7bbd with SMTP id g7-20020a5d4887000000b00226ed347bbdmr12940819wrq.561.1666387111447;
        Fri, 21 Oct 2022 14:18:31 -0700 (PDT)
Message-ID: <cb67c768-1a05-e5d5-efed-9a282c6a8c2a@gmail.com>
Date: Sat, 22 Oct 2022 00:18:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v1 02/12] Arm: GICv3: Move the macros to compute the
 affnity level to arm64/arm32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-3-ayankuma@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221021153128.44226-3-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 18:31, Ayan Kumar Halder wrote:
Hi Ayan

> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
> include/asm/cputype.h#L14 , these macros are specific for arm64.
> 
> When one computes MPIDR_LEVEL_SHIFT(3), it crosses the width of a 32
> bit register.
> 
> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
> asm/cputype.h#L54  , these macros are specific for arm32.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/arm32/processor.h | 10 ++++++++++
>   xen/arch/arm/include/asm/arm64/processor.h | 13 +++++++++++++
>   xen/arch/arm/include/asm/processor.h       | 14 --------------
>   3 files changed, 23 insertions(+), 14 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/processor.h b/xen/arch/arm/include/asm/arm32/processor.h
> index 4e679f3273..3e03ce78dc 100644
> --- a/xen/arch/arm/include/asm/arm32/processor.h
> +++ b/xen/arch/arm/include/asm/arm32/processor.h
> @@ -56,6 +56,16 @@ struct cpu_user_regs
>       uint32_t pad1; /* Doubleword-align the user half of the frame */
>   };
>   
> +/*
> + * Macros to extract affinity level. Picked from kernel
> + */
> +
> +#define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1)
> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
> +
> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
> +    ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK)
> +
>   #endif
>   
>   #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
> diff --git a/xen/arch/arm/include/asm/arm64/processor.h b/xen/arch/arm/include/asm/arm64/processor.h
> index c749f80ad9..c026334eec 100644
> --- a/xen/arch/arm/include/asm/arm64/processor.h
> +++ b/xen/arch/arm/include/asm/arm64/processor.h
> @@ -84,6 +84,19 @@ struct cpu_user_regs
>       uint64_t sp_el1, elr_el1;
>   };
>   
> +/*
> + * Macros to extract affinity level. picked from kernel
> + */
> +
> +#define MPIDR_LEVEL_BITS_SHIFT  3
> +#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
> +
> +#define MPIDR_LEVEL_SHIFT(level) \
> +         (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
> +
> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
> +         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
> +
>   #undef __DECL_REG
>   
>   #endif /* __ASSEMBLY__ */
> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
> index 1dd81d7d52..7d90c3b5f2 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -118,20 +118,6 @@
>   #define MPIDR_INVALID       (~MPIDR_HWID_MASK)
>   #define MPIDR_LEVEL_BITS    (8)
>   
> -
> -/*
> - * Macros to extract affinity level. picked from kernel
> - */
> -
> -#define MPIDR_LEVEL_BITS_SHIFT  3
> -#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
> -
> -#define MPIDR_LEVEL_SHIFT(level) \
> -         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
> -
> -#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
> -         (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
> -
>   #define AFFINITY_MASK(level)    ~((_AC(0x1,UL) << MPIDR_LEVEL_SHIFT(level)) - 1)
>   
>   /* TTBCR Translation Table Base Control Register */

Since only the definition of the MPIDR_AFFINITY_LEVEL() differs, maybe 
you could add only this one to the arch specific headers e.g
for arm64:
#define MPIDR_LEVEL_SHIFT(level) \
     (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
for arm32:
#define MPIDR_LEVEL_SHIFT(level) \
     ((level) << MPIDR_LEVEL_BITS_SHIFT)

But in any case don't forget to add parentheses around the macro 
parameters when an operator acts on them to avoid trouble with operator 
precedence (MISRA-C Rule 20.7 :))

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 21:42:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 21:42:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428003.677706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzmX-0002UP-DW; Fri, 21 Oct 2022 21:42:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428003.677706; Fri, 21 Oct 2022 21:42:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzmX-0002UI-AP; Fri, 21 Oct 2022 21:42:21 +0000
Received: by outflank-mailman (input) for mailman id 428003;
 Fri, 21 Oct 2022 21:42:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QljK=2W=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1olzmW-0002UC-AM
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 21:42:20 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3be3d2d0-5189-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 23:42:17 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D5172B80D41;
 Fri, 21 Oct 2022 21:42:17 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B12EC433C1;
 Fri, 21 Oct 2022 21:42:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3be3d2d0-5189-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666388536;
	bh=VDT5xpjT8drmZJ4No67YEEeavjHtQyhNdIGj00yOoOg=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EvU+R5fVEhflETGpyw3PqyJOye73pk4cqaLIYYt5MHGjCOZpnx7bMoDY9snounZnr
	 2PnLDoKCJ70YlQ8V2ZPP92BBIDQbi67fqwk1qxplRfuvGGYOOWrqoPmdA98mbAeJbZ
	 YNZ1Y3E4TT+BkBYe965oD4ztiJ8Tad+ma5RdW38nmypUzz1Empgv23+HvOkIrgpfjk
	 7ePf3US3eu9hZYkPtkNkyM94uOFyHDO/nH4wXeZbrlb9nU5OjqIMHIJOtOgEPRW1yv
	 8Rtsz/f3FzjHtIUUl+EVQ1qKHILcZsKHxkdJNTXp+pvJ7ppBYmqBnlnBKvvCE2sGNO
	 vvijhvBFTrrLQ==
Date: Fri, 21 Oct 2022 14:42:14 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] automation: test.yaml: Introduce templates to reduce
 the overhead
In-Reply-To: <20221019164246.5487-1-michal.orzel@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210211423560.3873@ubuntu-linux-20-04-desktop>
References: <20221019164246.5487-1-michal.orzel@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 19 Oct 2022, Michal Orzel wrote:
> At the moment, we define lots of test jobs in test.yaml, that make use
> of the same configuration sections like variables, tags, artifacts.
> Introduce templates (hidden jobs whose names start with a dot) to
> reduce the overhead and simplify the file (more than 100 lines saved).
> This way, the actual jobs can only specify sections that are unique
> to them.
> 
> Most of the test jobs specify the same set of prerequisite jobs under needs
> property with just one additional being unique to the job itself. Introduce
> YAML anchors for that purpose, because when using extends, the needs property
> is not being merged (the parent property overwrites the child one).

I like the patch. Replying here on top because the diff below is not
very helpful.

When you say that "extends" overwrites the properties, do you mean that
"needs" in qemu-smoke-dom0-arm64-gcc overwrites "needs" in .qemu-arm64,
when qemu-smoke-dom0-arm64-gcc includes .qemu-arm64?


If there is no way to solve the overwrite problem then it is OK to use
YAML achors but is it possible to define the anchors outside of
.qemu-arm64/.qemu-arm32 ? It would make things a lot clearer in the
code. Maybe under a top level "definitions" key? The point is that
.qemu-arm64 and .qemu-arm32 should use the anchor rather than define the
anchor.

I wouldn't call it qemu-arm64-needs because it has things
like alpine-3.12-arm64-rootfs-export and kernel-5.19-arm64-export that
are not required by qemu-system-aarch64-6.0.0-arm64-export. If anything
qemu-system-aarch64-6.0.0-arm64-export needs CONTAINER:
debian:unstable-arm64v8.

So I would call the anchor something like "arm64-test-needs". Same
comment for the arm32 anchor.


> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> ---
> This patch is based on the CI next branch where we already have several
> patches (already acked) to be merged into staging after the release:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next
> 
> Tested pipeline:
> https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/671114820
> ---
>  automation/gitlab-ci/test.yaml | 266 ++++++++++-----------------------
>  1 file changed, 80 insertions(+), 186 deletions(-)
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 92e0a1f7c510..fc0884b12082 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -7,32 +7,12 @@
>      - /^coverity-tested\/.*/
>      - /^stable-.*/
>  
> -# Test jobs
> -build-each-commit-gcc:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> -    XEN_TARGET_ARCH: x86_64
> -    CC: gcc
> -  script:
> -    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
> -    - mv ../build-each-commit-gcc.log .
> -  artifacts:
> -    paths:
> -      - '*.log'
> -    when: always
> -  needs: []
> -  tags:
> -    - x86_64
> -
> -qemu-smoke-dom0-arm64-gcc:
> +.qemu-arm64:
>    extends: .test-jobs-common
>    variables:
>      CONTAINER: debian:unstable-arm64v8
> -  script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> -  needs:
> -    - alpine-3.12-gcc-arm64
> +    LOGFILE: qemu-smoke-arm64.log
> +  needs: &qemu-arm64-needs
>      - alpine-3.12-arm64-rootfs-export
>      - kernel-5.19-arm64-export
>      - qemu-system-aarch64-6.0.0-arm64-export

LOGFILE should be listed among the artifacts (and maybe we can remove
*.log if it has become redundant?)


> @@ -44,17 +24,13 @@ qemu-smoke-dom0-arm64-gcc:
>    tags:
>      - arm64
>  
> -qemu-smoke-dom0-arm64-gcc-debug:
> +.qemu-arm32:
>    extends: .test-jobs-common
>    variables:
>      CONTAINER: debian:unstable-arm64v8
> -  script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> -  needs:
> -    - alpine-3.12-gcc-debug-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> +    LOGFILE: qemu-smoke-arm32.log
> +  needs: &qemu-arm32-needs
> +    - qemu-system-aarch64-6.0.0-arm32-export
>    artifacts:
>      paths:
>        - smoke.serial
> @@ -63,16 +39,11 @@ qemu-smoke-dom0-arm64-gcc-debug:
>    tags:
>      - arm64
>  
> -qemu-alpine-x86_64-gcc:
> +.qemu-x86-64:
>    extends: .test-jobs-common
>    variables:
>      CONTAINER: debian:stretch
> -  script:
> -    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-x86_64.log
> -  needs:
> -    - alpine-3.12-gcc
> -    - alpine-3.12-rootfs-export
> -    - kernel-5.10.74-export
> +    LOGFILE: qemu-smoke-x86-64.log
>    artifacts:
>      paths:
>        - smoke.serial
> @@ -81,214 +52,137 @@ qemu-alpine-x86_64-gcc:
>    tags:
>      - x86_64
>  
> -qemu-smoke-dom0less-arm64-gcc:
> +# Test jobs
> +build-each-commit-gcc:
>    extends: .test-jobs-common
>    variables:
> -    CONTAINER: debian:unstable-arm64v8
> +    CONTAINER: debian:stretch
> +    XEN_TARGET_ARCH: x86_64
> +    CC: gcc
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> -  needs:
> -    - alpine-3.12-gcc-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> +    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
> +    - mv ../build-each-commit-gcc.log .
>    artifacts:
>      paths:
> -      - smoke.serial
>        - '*.log'
>      when: always
> +  needs: []
>    tags:
> -    - arm64
> +    - x86_64
> +
> +qemu-smoke-dom0-arm64-gcc:
> +  extends: .qemu-arm64
> +  script:
> +    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - *qemu-arm64-needs
> +    - alpine-3.12-gcc-arm64
> +
> +qemu-smoke-dom0-arm64-gcc-debug:
> +  extends: .qemu-arm64
> +  script:
> +    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - *qemu-arm64-needs
> +    - alpine-3.12-gcc-debug-arm64
> +
> +qemu-smoke-dom0less-arm64-gcc:
> +  extends: .qemu-arm64
> +  script:
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - *qemu-arm64-needs
> +    - alpine-3.12-gcc-arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-debug:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm64-needs
>      - alpine-3.12-gcc-debug-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-staticmem:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm64-needs
>      - alpine-3.12-gcc-arm64-staticmem
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-debug-staticmem:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm64-needs
>      - alpine-3.12-gcc-debug-arm64-staticmem
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-boot-cpupools:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm64-needs
>      - alpine-3.12-gcc-arm64-boot-cpupools
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm64-needs
>      - alpine-3.12-gcc-debug-arm64-boot-cpupools
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0-arm32-gcc:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm32
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
> +    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm32-needs
>      - debian-unstable-gcc-arm32
> -    - qemu-system-aarch64-6.0.0-arm32-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0-arm32-gcc-debug:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm32
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
> +    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *qemu-arm32-needs
>      - debian-unstable-gcc-arm32-debug
> -    - qemu-system-aarch64-6.0.0-arm32-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
> +
> +qemu-alpine-x86_64-gcc:
> +  extends: .qemu-x86-64
> +  script:
> +    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - alpine-3.12-gcc
> +    - alpine-3.12-rootfs-export
> +    - kernel-5.10.74-export
>  
>  qemu-smoke-x86-64-gcc:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-stretch-gcc-debug
> -  tags:
> -    - x86_64
>  
>  qemu-smoke-x86-64-clang:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-unstable-clang-debug
> -  tags:
> -    - x86_64
>  
>  qemu-smoke-x86-64-gcc-pvh:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-stretch-gcc-debug
> -  tags:
> -    - x86_64
>  
>  qemu-smoke-x86-64-clang-pvh:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-unstable-clang-debug
> -  tags:
> -    - x86_64
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 21:47:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 21:47:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428009.677716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzrg-0003EV-4q; Fri, 21 Oct 2022 21:47:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428009.677716; Fri, 21 Oct 2022 21:47:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzrg-0003EO-1o; Fri, 21 Oct 2022 21:47:40 +0000
Received: by outflank-mailman (input) for mailman id 428009;
 Fri, 21 Oct 2022 21:47:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0ozE=2W=kernel.org=pr-tracker-bot@srs-se1.protection.inumbo.net>)
 id 1olzrf-0003EI-2e
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 21:47:39 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9faf046-5189-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 23:47:37 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id AAD2E61F8A;
 Fri, 21 Oct 2022 21:47:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPS id 1FFE3C433D7;
 Fri, 21 Oct 2022 21:47:36 +0000 (UTC)
Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org
 (localhost.localdomain [127.0.0.1])
 by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id
 F361AE270E0; Fri, 21 Oct 2022 21:47:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9faf046-5189-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666388856;
	bh=J7+fm1rjaT/LZD3cv5obF8wpb4IoLIy0LmAjPcWm1xo=;
	h=Subject:From:In-Reply-To:References:Date:To:Cc:From;
	b=gmvfrcw4LP9OjQHWubzsf642byo/MXHY1DN8t52f4itWDgPcUIO+6Dgo+jSSrxEc/
	 eJpYzZdP0Evq65K5nosLhn1tgPfh26KtfREeINRkOE5RIvU+RQ48IfnLl+SUiOs5ca
	 HQgmk86qs0r/qXjaxB3nXvXHVDjz/3OCQplPsD7bpkI0xCNHogy/eds4X9zLtLcg4V
	 aGHQ/l4xa2U8yEJGspocsIEHacRQfFgiz5VBo3a47QAjUBGZZzwZjIZcAzh/Cx1wLu
	 0XOsyI0PyS/EA7hCKe+et1//XLYKhW9Qjg/hx/8ze9BifFWOl3JVDMTSVkPIVoHkTE
	 2zq7NMft+snyw==
Subject: Re: [GIT PULL] xen: branch for v6.1-rc2
From: pr-tracker-bot@kernel.org
In-Reply-To: <20221021093119.25978-1-jgross@suse.com>
References: <20221021093119.25978-1-jgross@suse.com>
X-PR-Tracked-List-Id: <linux-kernel.vger.kernel.org>
X-PR-Tracked-Message-Id: <20221021093119.25978-1-jgross@suse.com>
X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc2-tag
X-PR-Tracked-Commit-Id: a383dcb1cca8305497877119fba0a320f41fe853
X-PR-Merge-Tree: torvalds/linux.git
X-PR-Merge-Refname: refs/heads/master
X-PR-Merge-Commit-Id: 1d61754caa8c69f566504e63c8b3f3a2df0954c8
Message-Id: <166638885598.26127.18249995136071823508.pr-tracker-bot@kernel.org>
Date: Fri, 21 Oct 2022 21:47:35 +0000
To: Juergen Gross <jgross@suse.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org

The pull request you sent on Fri, 21 Oct 2022 11:31:19 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.1-rc2-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1d61754caa8c69f566504e63c8b3f3a2df0954c8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 21:54:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 21:54:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428014.677728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzyY-0004fP-SZ; Fri, 21 Oct 2022 21:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428014.677728; Fri, 21 Oct 2022 21:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1olzyY-0004fI-PL; Fri, 21 Oct 2022 21:54:46 +0000
Received: by outflank-mailman (input) for mailman id 428014;
 Fri, 21 Oct 2022 21:54:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1mzs=2W=citrix.com=prvs=28632f022=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1olzyX-0004f9-CR
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 21:54:45 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6a7027a-518a-11ed-8fd0-01056ac49cbb;
 Fri, 21 Oct 2022 23:54:42 +0200 (CEST)
Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 21 Oct 2022 17:54:39 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BY5PR03MB5079.namprd03.prod.outlook.com (2603:10b6:a03:1f2::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Fri, 21 Oct
 2022 21:54:37 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022
 21:54:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a7027a-518a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666389282;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=MTM44QIRosRDx17R3zhLd01xMJIi3N3uJ2zQrcgmz6o=;
  b=K2RFRTXYeH4MuwtadaOc52XpiJFnHrJOBwjI8prt6G82h1PTgJhtgZQg
   OFvtuc/LuRpubb3NwYjeaXxC82JjDEcxoAEkctmHtlaHRIzAgHy2Cp9ME
   HgKpnLdGh+McGsGKdOW3z88XHqm6SidaWiXmL9trwoanWKLT7Z41v7TyY
   o=;
X-IronPort-RemoteIP: 104.47.51.41
X-IronPort-MID: 83271664
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:0wD4Y6uON77Qmo617oLc+mBrGufnVEVfMUV32f8akzHdYApBsoF/q
 tZmKTiOPviJMGGkLdt/bd62/E9Xu8CHxoM3TwtlqXtnRnxD+JbJXdiXEBz9bniYRiHhoOCLz
 O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiefHgZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPaoS5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklE6
 6cVCmhVfCuyrPq46omYY+lM258seZyD0IM34hmMzBn/JNN+G9XpZfyP4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWKilAouFTuGIO9ltiibMNZhEuH4
 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurA9hNTePmqpaGhnW62kkSFTJIaGH4iqOJrQmnY9dmL
 0w9r39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOtsU7WDgr3
 V+hhM7yCHpkt7j9dJ6G3rKdrDf3My5MK2YHPXAAVVFdv4Clp5wvhBXSSNolCLSyktD+BTD3x
 XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjjNAt9RDGJ9W7GV1A==
IronPort-HdrOrdr: A9a23:IomuHagn0FukzRRld4z8/AbSvXBQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+
 O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.95,203,1661832000"; 
   d="scan'208";a="83271664"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UvoV/FEfW3iRpuMfjlJWSMfKXfCRySU9HFYTwXLKD9j2M3lY04l3719uNmZhSn21ERCtn6ujJqmwKXoWMscvo+km4q/VmfBrvVdnvuGlRipN8qMdqmmWpfwAgFFGEYUXUdskuoYQaB3vtE2fLdMWOvxMwUfLI3hXO/6QJjavhR0SE4of2fE6aEoSzxW4ddjH+Jss4NV9pTOwMXx9AUIqrt7JpZXR2N8u6kcLwK0QiK592o7GpgjA5Jbwnks1q+seXcEHvpHrbycurZsfylkYaKdbOc5acjCt4Ov1T4yOiCr5o4rXUCYu2lIsD+vIeGTZ4noiyG5LVdazuunxlgYqLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MTM44QIRosRDx17R3zhLd01xMJIi3N3uJ2zQrcgmz6o=;
 b=bRA0tZSQyy7HsZ1idMDuU0mpfq+Sa4wWl/yeQg+qYs0BqrIzLkrInGhUIsk+Mw2z5/5EqxiBzdywjGhnrMQ4yz7WxisesniGbWdEmyZgCD6VMIbxlFFHJQCL1/I0uvDuttncCo/njl+mOi/fZb/PGNFclPS3ymntiA0S0fdVKX3poYog2/vBLfmG1B/+gHHAGmyxM3Wg70q8FmsWOQm/A0i/z0bOgcBJXdUCfH+j11PjTkJF9MSbPHm8u0+PRc7W6D6RMlCf212xUB7b9QiNXR0OWhfdPVdNGhacw9JNhq16d4pQisA8OQb2G7sjGYutLGNqC3GsRr3Ia9bR2TPTqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MTM44QIRosRDx17R3zhLd01xMJIi3N3uJ2zQrcgmz6o=;
 b=EAmz1rZXecBM40gY6PTxdkk2TX4y9TdRf1IyPCGdvp+XLhAxh8z/3HCXJrI6lBV6O8d+bLpcBq4mhI8keeUz+A0aEViqK+1T/Fezjd2EnvsnRdrhbpFxbH/O4M+wStRhpV4NDZ6kQg57JEtzPTRXC2DPfITeSKi5917jTZsaJUs=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>
Subject: Re: Intended behavior/usage of SSBD setting
Thread-Topic: Intended behavior/usage of SSBD setting
Thread-Index: AQHY5HNYUBb0Vi2AEkSsX9Q44WPHHa4ZZoQA
Date: Fri, 21 Oct 2022 21:54:36 +0000
Message-ID: <8c7de7ed-6242-f444-55fc-9eb16084b7bf@citrix.com>
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
In-Reply-To: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BY5PR03MB5079:EE_
x-ms-office365-filtering-correlation-id: f3552046-6b0a-4c7e-8b6d-08dab3aed8d9
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 nXou4FTreY4Mm9ZRK+XTfZsMAhdnOiljXCo1LldjY4Gv7f22ZQ89v57t9jLlaJBi5SHReW4VPx0YzKpenpOTerED4Iv5IDI4st5NddVya4NyixXiA02huJHmSYRzpHO6nrY30U7PfADBV5xE45nV7Q+EqSwQ2+AZK6Vqvhm3qqg2NvsDShBrkOz0Rwe10LnzLSqKUDat0aJaP5SKwieUMnLPip0eIoWazggpuBuHa+Ne2VRYiXyzWctseANVun8KiBFxJiiJizWzeTMEbVFRMjEdT8OXshrqNZ7/c9+qMEaGoF1O+xzytSwhuMcYPHRBrWw5druBFE7eGmar0inOJverAs/CkIGhwJPdW+HC4ZpxsxlW0xP0AbbBMo8yVm9Va9KbWLqxkyQintCf00Xx9XFxmtH8AXJZkNTTAnhhQ3OiZERTEDlEfjKJo2MRW2CoBpZN3SEgSuU1nnw0XUADwpt8g3qtxUfZrP7fMCBFs2q28QV/pBfxYRknSTDgGWuJD1vWBRE8zX6adqZhKvyCHi227WTacYlp704hH2cZKR1HiYH1431abn0HZ6E5jyXDOvokY8dgEG1VSE7rgMjcKXl1MgyYjbevU9f5hRizsnNja6THiKMHNySOrIngCYtI9nlCxvxYZCD9V9l/a8W5AHxEde9yelmnw+qZ4Q1S2MM8axyd3/ms5GzmzZPIr+8onRgCpGd2C+c4NR2GyWtnmjWdQUCO7WeZ1PErRUIVnNhyodxZeS6YfFKqhXL/aubKnuO7u1ZOmousleEa8xRi/zYP5q3DushGsTMzmeLqIhz92VQ+ryeZFO+HAMTJzkcAP+KW/5AWp+mDEmRG1aGBt4uca6QMXyssAmcLtnX2nds=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199015)(31686004)(66899015)(6512007)(53546011)(26005)(478600001)(6486002)(966005)(6506007)(36756003)(71200400001)(2906002)(83380400001)(31696002)(8936002)(86362001)(2616005)(38100700002)(110136005)(316002)(186003)(66476007)(122000001)(41300700001)(76116006)(66946007)(91956017)(8676002)(38070700005)(5660300002)(64756008)(66446008)(66556008)(4326008)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?YVp1Ylk4NFpLZ2ZNYmJYMUJIeUg4eDAwQVhqTGlhdmFJNVNQUFF3bWhFNzhZ?=
 =?utf-8?B?ZkNWZHpGcVVYdGZzVGRxRW5VaTdMNmNOUHNia2NOdWFERjdJR3U0cC9pOG1v?=
 =?utf-8?B?ZW9OT3dHbjVDWXJVZmZWVjA2USsrd2tOQWdRSXBrYjFFVXdQeWsrTHcxOXNi?=
 =?utf-8?B?UlFBZW0yRGJZQ0dyWEN5NmFtMDBsUitzckF1djAvUDVvMWRKSzd1UmRCMFlx?=
 =?utf-8?B?TEFDckx1Vk5qbU03MklwZG1PY2Y0UFlTelc1SnVoTERtMk1qZlNnT0t1aDdH?=
 =?utf-8?B?SUczaUFJL1FsUXdCZ1FnYi9STTE3aWtmVTVXNUlVS0xub292Z01JU2k4cGJH?=
 =?utf-8?B?bEF5SmNZRGt3SDhySjBINll6ZGJEMU9WVVkzeHN6NEoyWHgzUXJyUFpFS0xn?=
 =?utf-8?B?S3dRNmxoVHJINitIbmZxMjhnS29CSzY3WEtobm1xR1lxQmpsdExkR0RmaU5t?=
 =?utf-8?B?Q3pRTnFPR3NVa1RJYS9YYVZBZ3lnamxIc0h1azV3Vlp4b1pxUkthZm5RVmNn?=
 =?utf-8?B?RmJ6UE90cnQ3Vmo1QUhVeldJbjhGYUQ5TklaUStPaktPdENCc3ZMWFFPMEt3?=
 =?utf-8?B?UnR6eWIwTFBCTkRCQko3ZEZEcnRxT3hRTlpXRkJGRXRySVBUUUt0Z29TenZW?=
 =?utf-8?B?VGpwUXdFbzNtVlNCVm5ZVnZ4dFFuQThyczJseFFTd3NscExMb1ZhbUxjbzFV?=
 =?utf-8?B?alQraHhaQy9veHNWTitJSHV5bzFSMGJ0QUhCVndGTm1rcHZhWkNHTG1xeHgw?=
 =?utf-8?B?MnNBaVRJTk8yY3YrZWFRczBTRjFScVRpZTdZS1VFK1FpMmdLMS9UejlQS25L?=
 =?utf-8?B?eXpoMDJiTnBKQXZrMUdDaUlSN3BWaFhNaHIwNERJOU05RTFrZ1hoMVJoWktv?=
 =?utf-8?B?ZmxXRFpPYkwzMlE5bEs5RFRhaWhsRThMVCtCNlFSeFZndVNJeWNUU2xrVlhX?=
 =?utf-8?B?dUxaa3Y2Z3k3dkdNYWNIQ212MDB1UWRCVUM4VERtamREVWUrb0VPaTBuaktN?=
 =?utf-8?B?eURXdTFaelJFalZ2MTVzMjNVMnNSbjhmTUcyQU10aHdRL1l1dmFkRkxCRita?=
 =?utf-8?B?MVVKbktISWtqOVBhUGJxWW0yTmVpTldncktpRHgwUEJYNDJuK3ZJWTVxd1ZT?=
 =?utf-8?B?V3IwY1NuakNmK0J5T1FYS0Rwc3M3ZTFyMGFxaXdYTTBDZ3pNaHZwOTg1b0d4?=
 =?utf-8?B?ZXFrdUFFaTNJY2xRRy9LWlhxUHlYQ2FJYmQxK0trTkV5VVFOc00wR2FjbHhP?=
 =?utf-8?B?MUVNSm1DVVpmWmhGbkFyUjA1QjJyYjgyWDVYOUdQM0VzaERpTzhqZSt2Z3NW?=
 =?utf-8?B?VjQrcmFKSnBmV0tOTWNiQVV1THBVeGdtVi8rWDI5ejFUNnczMjU1MkdkYWxG?=
 =?utf-8?B?aTVJRUNjVHJiSWxiUytxbk5UNTRTSlNXWWQyNytQckNDQjVWT2ZqN3orOFI0?=
 =?utf-8?B?amt6bW1pNGJ4QnVkWTJUbWxuZTI0NEpsMWpYanJoOEkwTWhhMzh6S2JTZFlx?=
 =?utf-8?B?dW14cDdpTWxCVEZ4enpRSFBIOGVBOHFISEh5NTNyT3dNZjBUazlrNnJGTjNJ?=
 =?utf-8?B?ZGpSOWRCRmYydXhIQ3ZCU1IwR25UN3pGcGIxYVY4TVI0TzE4bktqSml6ZmdL?=
 =?utf-8?B?ck1hZGRwNXFtTUlUQmx1b0VxWElUMjcxeDNuYTBOdnlST05iQUdKQ3VsM09U?=
 =?utf-8?B?dENqMitCMkVrU2V6THdwWFI1TFNBQXR2M1BmVE9HYkdLMFdvZ1QwbUMrcWwx?=
 =?utf-8?B?YW9kWnloaWRMLzJNSWZ3VXNwZFpScStiVkFrVXJIaU1SOWFNSTdBL1ptUmFj?=
 =?utf-8?B?WXFrZnZBalVzamhhdDR2U011NGlKRzJQbHFyb3NieCtYanY2WFByWVBDWFpP?=
 =?utf-8?B?aUlDWEwrQjhDakdLci9McFJEQWxFT0F6cmxVQ05NTThoMWo5VmxaOGJTa0pO?=
 =?utf-8?B?NXhJOEl1WEVXS0VxMVZBLzZTTE1vd0EySEJkelYzYWFNVWxDUjlpZTlUb0dh?=
 =?utf-8?B?SERpUVg4cDBONnhqNDBGaXNoN2pLc0lXZGgvM1hHc1ZraklWbjFVZitVS1FP?=
 =?utf-8?B?aktSa1RVR2EyVU1lYUp6Z1ZrRGhtamtjMjV5TlpVVGVyNGorcTFXYnNVRThr?=
 =?utf-8?Q?LCh8iG7+hhg4iX3Xtw3AOUzeC?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2B2DBA1A4FBBF944A196C3528622DD63@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3552046-6b0a-4c7e-8b6d-08dab3aed8d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 21:54:36.9851
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8jRhhRpgXvUYenrhqrL/0vd3mwTY9ZE848twqhy6+t/pIZej+2ccrvljC+VamidsyNrwKbvYmBxpRzxSr9cYBx8FANhFQGMXNQ3hj6pUHQU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5079

T24gMjAvMTAvMjAyMiAxMjowMSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gSGVsbG8sDQo+
DQo+IEFzIHBhcnQgb2Ygc29tZSBmb2xsb3cgdXAgaW1wcm92ZW1lbnRzIHRvIG15IFZJUlRfU1BF
Q19DVFJMIHNlcmllcyB3ZQ0KPiBoYXZlIGJlZW4gZGlzY3Vzc2luZyB3aGF0IHRoZSB1c2FnZSBv
ZiBTU0JEIHNob3VsZCBiZSBmb3IgdGhlDQo+IGh5cGVydmlzb3IgaXRzZWxmLiAgVGhlcmUncyBj
dXJyZW50bHkgYSBgc3BlYy1jdHJsPXNzYmRgIG9wdGlvbiBbMF0sDQo+IHRoYXQgaGFzIGFuIG91
dCBvZiBkYXRlIGRlc2NyaXB0aW9uLCBhcyBub3cgU1NCRCBpcyBhbHdheXMgb2ZmZXJlZCB0bw0K
PiBndWVzdHMgb24gQU1EIGhhcmR3YXJlLCBlaXRoZXIgdXNpbmcgU1BFQ19DVFJMIG9yIFZJUlRf
U1BFQ19DVFJMLg0KPg0KPiBJdCBoYXMgYmVlbiBwb2ludGVkIG91dCBieSBBbmRyZXcgdGhhdCB0
b2dnbGluZyBTU0JEIG9uIEFNRCB1c2luZw0KPiBWSVJUX1NQRUNfQ1RSTCBvciB0aGUgbm9uLWFy
Y2hpdGVjdHVyYWwgd2F5IChNU1JfQU1ENjRfTFNfQ0ZHKSBjYW4NCj4gaGF2ZSBhIGhpZ2ggaW1w
YWN0IG9uIHBlcmZvcm1hbmNlLCBhbmQgaGVuY2Ugc3dpdGNoaW5nIGl0IG9uIGV2ZXJ5DQo+IGd1
ZXN0IDwtPiBoeXBlcnZpc29yIGNvbnRleHQgc3dpdGNoIGlzIGxpa2VseSBhIHZlcnkgaGlnaA0K
PiBwZXJmb3JtYW5jZSBwZW5hbHR5Lg0KPg0KPiBJdCdzIGJlZW4gc3VnZ2VzdGVkIHRoYXQgaXQg
Y291bGQgYmUgbW9yZSBhcHByb3ByaWF0ZSB0byBydW4gWGVuIHdpdGgNCj4gdGhlIGd1ZXN0IFNT
QkQgc2VsZWN0aW9uIG9uIHRob3NlIHN5c3RlbXMsIGhvd2V2ZXIgdGhhdCBjbGFzaGVzIHdpdGgN
Cj4gdGhlIGN1cnJlbnQgaW50ZW50IG9mIHRoZSBgc3BlYy1jdHJsPXNzYmRgIG9wdGlvbi4NCj4N
Cj4gSSBob3BlIEkgaGF2ZSBjYXB0dXJlZCB0aGUgZXhwcmVzc2VkIG9waW5pb25zIGNvcnJlY3Rs
eSBpbiB0aGUgdGV4dA0KPiBhYm92ZS4NCj4NCj4gSSBzZWUgdHdvIHdheXMgdG8gc29sdmUgdGhp
czoNCj4NCj4gICogS2VlcCB0aGUgY3VycmVudCBsb2dpYyBmb3Igc3dpdGNoaW5nIFNTQkQgb24g
Z3Vlc3QgPC0+IGh5cGVydmlzb3INCj4gICAgY29udGV4dCBzd2l0Y2gsIGJ1dCBvbmx5IHVzZSBp
dCBpZiBgc3BlYy1jdHJsPXNzYmRgIGlzIHNldCBvbiB0aGUNCj4gICAgY29tbWFuZCBsaW5lLg0K
Pg0KPiAgKiBSZW1vdmUgdGhlIGxvZ2ljIGZvciBzd2l0Y2hpbmcgU1NCRCBvbiBndWVzdCA8LT4g
aHlwZXJ2aXNvciBjb250ZXh0DQo+ICAgIHN3aXRjaCwgaWdub3JlIHNldHRpbmcgb2YgYHNwZWMt
Y3RybD1zc2JkYCBvbiB0aG9zZSBzeXN0ZW1zIGFuZCBydW4NCj4gICAgaHlwZXJ2aXNvciBjb2Rl
IHdpdGggdGhlIGd1ZXN0IHNlbGVjdGlvbiBvZiBTU0JELg0KPg0KPiBXaGljaCBoYXMgcmFpc2Vk
IG1lIHRoZSBxdWVzdGlvbiBvZiB3aGV0aGVyIHRoZXJlJ3MgYW4gdXNlIGNhc2UNCj4gZm9yIGFs
d2F5cyBydW5uaW5nIGh5cGVydmlzb3IgY29kZSB3aXRoIFNTQkQgZW5hYmxlZCwgb3IgdGhhdCdz
IG5vDQo+IGxvbmdlciByZWxldmFudCBpZiB3ZSBhbHdheXMgb2ZmZXIgZ3Vlc3RzIGEgd2F5IGZv
ciB0aGVtIHRvIHRvZ2dsZSB0aGUNCj4gc2V0dGluZyB3aGVuIHJlcXVpcmVkLg0KPg0KPiBJIHdv
dWxkIGxpa2UgdG8gc2V0dGxlIG9uIGEgd2F5IGZvcndhcmQsIHNvIHdlIGNhbiBnZXQgdGhpcyBm
aXhlZA0KPiBiZWZvcmUgNC4xNy4NCj4NCj4gVGhhbmtzLCBSb2dlci4NCj4NCj4gWzBdIGh0dHBz
Oi8veGVuYml0cy54ZW4ub3JnL2RvY3MvdW5zdGFibGUvbWlzYy94ZW4tY29tbWFuZC1saW5lLmh0
bWwjc3BlYy1jdHJsLXg4Ng0KDQpUaGVyZSBhcmUgbWFueSBpc3N1ZXMgYXQgcGxheSBoZXJlLsKg
IE5vdCBsZWFzdCB0aGF0IHZpcnQgc3BlYyBjdHJsIGlzDQp0ZWNobmljYWxseSBhIGxlZnRvdmVy
IHRhc2sgdGhhdCBvdWdodCB0byBmb3JjZSBhIHJlLWlzc3VlIG9mIFhTQS0yNjMuDQoNCkFjY2Vz
c2luZyBNU1JzIChldmVuIHJlYWRpbmcpIGlzIHZlcnkgZXhwZW5zaXZlLCB0eXBpY2FsbHkgPjFr
IGN5Y2xlcy7CoA0KVGhlIGNvcmUgQ0ZHIHJlZ2lzdGVycyBhcmUgbW9yZSBleHBlbnNpdmUgdGhh
biBtb3N0LCBiZWNhdXNlIHRoZXkncmUNCmludGVuZGVkIHRvIGJlIGNvbmZpZ3VyZWQgb25jZSBh
ZnRlciByZXNldCBhbmQgdGhlbiBsZWZ0IGFsb25lLg0KDQpUaHJvdWdob3V0IHRoZSBzcGVjdWxh
dGlvbiB3b3JrLCB3ZSd2ZSBzZWVuIGNyaXBwbGluZyBwZXJmb3JtYW5jZSBoaXRzDQpmcm9tIGFj
Y2Vzc2luZyBNU1JzIGluIGZhc3RwYXRocy7CoCBUaGUgZmFjdCB3ZSdyZSBmb3JjZWQgdG8gdXNl
IE1TUnMgaW4NCmZhc3RwYXRocyBldmVuIG9uIG5ldyBDUFVzIHdpdGggYnVpbHQgaW4gKHJhdGhl
ciB0aGFuIHJldHJvZml0dGVkKQ0Kc3BlY3VsYXRpb24gc3VwcG9ydCBpcyBpcyBhbiBhcmVhIG9m
IGNvbmNlcm4gc3RpbGwgYmVpbmcgd29ya2VkIG9uIHdpdGgNCnRoZSBDUFUgdmVuZG9ycy4NCg0K
Q2FzZSBpbiBwb2ludC7CoCBXZSBmb3VuZCBmb3IgWFNBLTM5OCB0aGF0IHRvZ2dsaW5nIEFNRCdz
DQpNU1JfU1BFQ19DVFJMLklCUlMgb24gdGhlIFBWIGVudHJ5cGF0aCB3YXMgc28gYmFkIHRoYXQg
c2V0dGluZyBpdA0KdW5pbGF0ZXJhbGx5IGJlaGluZCB0aGUgYmFjayBvZiBQViBndWVzdHMgd2Fz
IHRoZSBmYXN0ZXIgb3B0aW9uLsKgDQooQW5vdGhlciB0b2RvIGlzIHRvIHN0b3AgZG9pbmcgdGhp
cyBvbiBJbnRlbCBlSUJSUyBzeXN0ZW1zLCBhbmQgdGhpcw0Kd2lsbCByZWNvdmVyIHVzIGEgZGVj
ZW50IGNodW5rIG9mIHBlcmZvcm1hbmNlLikNCg0KDQpTU0JEIG1pdGlnYXRpb25zIGFyZSAocmln
aHRseSBvciB3cm9uZ2x5KSBvZmYgYnkgZGVmYXVsdCBmb3IgcGVyZm9ybWFuY2UNCnJlYXNvbnMu
wqAgQU1EIGFyZSBsZXNzIGFmZmVjdGVkIHRoYW4gSW50ZWwsIGZvciBtaWNyb2FyY2hpdGVjdHVy
YWwNCnJlYXNvbnMgd2hpY2ggYXJlIGRpc2N1c3NlZCBpbiByZWxldmFudCB3aGl0ZXBhcGVycywg
YW5kIHdoaWNoIGFyZQ0KZXhwZWN0ZWQgdG8gcmVtYWluIHRydWUgZm9yIGZ1dHVyZSBDUFVzLg0K
DQpXaGVuIFhlbiBkb2Vzbid0IGNhcmUgYWJvdXQgdGhlIHByb3RlY3RpbmcgaXRzZWxmIGFnYWlu
c3QgU1NCRCBieQ0KZGVmYXVsdCwgSSBndWFyYW50ZWUgeW91IHRoYXQgaXQgd2lsbCBiZSBmYXN0
ZXIgdG8gb21pdCB0aGUgTVNSIGFjY2Vzc2VzDQphbmQgcnVuIGluIHRoZSBndWVzdCBrZXJuZWwn
cyBjaG9pY2UsIHRoYW4gdG8gY2xlYXIgdGhlIFNTQkQNCnByb3RlY3Rpb24uwqAgV2Ugc2ltcGx5
IGRvbid0IHNwZW5kIGxvbmcgZW5vdWdoIGluIHRoZSBoeXBlcnZpc29yIGZvciB0aGUNCmhpdCBh
Z2FpbnN0IG1lbW9yeSBhY2Nlc3NlcyB0byBkd2FyZiB0aGUgaGl0IGZvciBNU1IgYWNjZXNzZXMg
dGFrZW4gb24NCmVudHJ5L2V4aXQuDQoNClRoZSByZWFzb24gd2UgcHV0IGluIHNwZWMtY3RybD1z
c2JkIHdhcyBhcyBhIHN0b3BnYXAsIGJlY2F1c2UgYXQgdGhlDQp0aW1lIHdlIGRpZG4ndCBrbm93
IGhvdyBiYWQgU1NCIHJlYWxseSB3YXMsIGFuZCBpdCB3YXMgZGVjaWRlZCB0aGF0IHRoZQ0KYWRt
aW4gc2hvdWxkIGhhdmUgYSBiaWcgaGFtbWVyIHRvIHVzZSBpZiB0aGV5IHJlYWxseSBuZWVkZWQu
DQoNCldoZW4gWGVuIGRvZXMgY2FyZSBhYm91dCBwcm90ZWN0aW5nIGl0c2VsZiwgdGhlIGFib3Zl
IHJlYXNvbmluZyBiaXRlcw0KYmFjayBoYXJkLsKgIEJlY2F1c2Ugd2Ugc3BlbmQgKG9yIHNob3Vs
ZCBiZSBzcGVuZGluZyEpID45OSUgb2YgdGltZSBpbg0KdGhlIGd1ZXN0LCB0aGUgaGl0IHRvIG1l
bW9yeSBhY2Nlc3NlcyBpcyBmYXIgbW9yZSBsaWtlbHkgdG8gYmUgYWJsZQ0KZHdhcmYgdGhlIGhp
dCBmcm9tIHRoZSBNU1IgYWNjZXNzZXMsIGJ1dCBub3csIHRoZSBkb21pbmF0aW5nIGZhY3RvciBm
b3INCnBlcmZvcm1hbmNlIGlzIHRoZSB2bWV4aXQgcmF0ZS4NCg0KVGhlIHByb2JsZW0gaXMgdGhh
dCBpZiB5b3UndmUgZ290IGEgY29tcGxldGVseSBjb21wdXRlIGJvdW5kIHdvcmtsb2FkLA0KdGhl
cmUgYXJlIHZlcnkgZmV3IGV4aXRzLCB3aGlsZSBpZiB5b3UndmUgZ290IGFuIElPIGJvdW5kIHdv
cmtsb2FkLA0KdGhlcmUgYXJlIHBsZW50eSBvZiBleGl0cy7CoCBJIGhvbmVzdGx5IGRvbid0IGtu
b3cgaWYgaXQgd2lsbCBiZSBtb3JlDQplZmZpY2llbnQgdG8gbGVhdmUgU1NCRCBhY3RpdmUgdW5p
bGF0ZXJhbGx5ICh3aGV0aGVyIG9yIG5vdCB3ZSBoaWRlDQp0aGlzLCBlLmcuIHN5bnRoZXNpemlu
ZyBTU0JfTk8pLCBvciB0byBsZXQgdGhlIGd1ZXN0IHJ1biB3aXRoIGl0IGtlcm5lbHMNCmNob2lj
ZS7CoCBJIHN1c3BlY3QgdGhlIGFuc3dlciBpcyBkaWZmZXJlbnQgd2l0aCBkaWZmZXJlbnQgd29y
a2xvYWRzLg0KDQoNCkJ1dCwgb25lIG90aGVyIGZhY3RvciBoZWxwcyB1cy7CoCBHaXZlbiB0aGF0
IHRoZSBkZWZhdWx0IGlzIGZhc3QgKHJhdGhlcg0KdGhhbiBzZWN1cmUpLCBhbnlvbmUgb3B0aW5n
IGluIHRvIHNwZWMtY3RybD1zc2JkIGlzIHNheWluZyAiSSBjYXJlIG1vcmUNCmFib3V0IHNlY3Vy
aXR5IHRoYW4gcGVyZm9ybWFuY2UiLCBhdCB3aGljaCBwb2ludCB3ZSBjYW4gc2ltcGxpZnkgd2hh
dCB3ZQ0KZG8gYmVjYXVzZSB3ZSBkb24ndCBuZWVkIHRvIGNhdGVyIHRvIGV2ZXJ5b25lLg0KDQoN
CkFzIGEgc2xpZ2h0IHRhbmdlbnQsIHRoZXJlIGlzIGEgY29zdCB0byBoYXZpbmcgdG9vIG1hbnkg
b3B0aW9ucywgd2hpY2gNCm11c3Qgbm90IGJlIGlnbm9yZWQuwqAgWGVuJ3Mgc3BlY3VsYXRpb24g
c2FmZXR5IGlzIGZhciB0b28gY29tcGxpY2F0ZWQNCmFscmVhZHkgYW5kIG5lZWRzIHRvIGdldCBt
b3JlIHNpbXBsZTsgdGhpcyBoYXMgYSBtYXRlcmlhbCBpbXBhY3Qgb24gaG93DQplYXN5IGl0IGlz
IHRvIGZvbGxvdywgYW5kIGhvdyBlYXN5IGl0IHRvIG1ha2UgY2hhbmdlcy4NCg0KSXQgaXMgdGhl
IHdheSBpdCBpcyBiZWNhdXNlIHdlJ3ZlIGhhZCA2IHllYXJzIG9mIGRyaXAgZmVlZGluZyBvbmUN
CnByb2JsZW0gYWZ0ZXIgYW5vdGhlciwgYW5kIGhhdmVuJ3QgaGFkIHRoZSB0aW1lIHRvIHRha2Ug
YSBzdGVwIGFuZA0KZGVzaWduIHNvbWV0aGluZyBtb3JlIHNlbnNpYmxlIGZyb20gaGF2aW5nIDYg
eWVhcnMgb2YNCmtub3dsZWRnZS9sZWFybmluZ3MgYXMgYSBiYXNpcy7CoCBUaGVyZSBhcmUgZGVm
aW5pdGVseSB0aGluZ3Mgd2hpY2ggSQ0Kd291bGQgaGF2ZSBkb25lIGRpZmZlcmVudGx5LCBpZiA2
IHllYXJzIGFnbywgSSdkIGtub3duIHdoYXQgSSBrbm93IG5vdywNCmFuZCBwYXJ0IG9mIHRoZSBy
ZWFzb24gd2h5IHRoZSByZWNlbnQgc3BlY3VsYXRpb24gc2VjdXJpdHkgd29yayBoYXMNCnRha2Vu
IHNvIG11Y2ggZWZmb3J0IGlzIGJlY2F1c2UgaXQgaGFzIGludm9sdmVkIHJld29ya2luZyB0aGUg
ZWZmb3J0DQp3aGljaCBjYW1lIGJlZm9yZSwgdG8gYSBkZWFkbGluZSB3aGljaCBuZXZlciBoYXMg
ZW5vdWdoIHRpbWUgdG8gcGxhbg0KcHJvcGVybHkgd2l0aGluLg0KDQoNClNvLCBmaXJzdCBxdWVz
dGlvbiwgZG8gd2UgY2FyZSBhYm91dCBoYXZpbmcgYW4gIlNTQkQgYWN0aXZlIHdoaWxlIGluDQpY
ZW4iIG1vZGU/DQoNClByb2JhYmx5IHllcywgYmVjYXVzZSB3ZSBhKSBzdGlsbCBkb24ndCBoYXZl
IGEgd29ya2luZyBzb2x1dGlvbiBmb3IgUFYNCmd1ZXN0cyBvbiBBTUQgYW5kIGIpIHdobyBrbm93
cyBpZiB0aGVyZSdzIHNvbWV0aGluZyBmYXIgd29yc2UgbHVya2luZyBpbg0KdGhlIGZ1dHVyZS7C
oCBTb2RzIGxhdyBzYXlzIHRoYXQgaWYgd2UgZGVjaWRlIG5vIGhlcmUsIGl0IHdpbGwgYmUNCmNy
aXRpY2FsIGZvciBzb21lIGZ1dHVyZSBpc3N1ZS4NCg0KQnV0IGFzIGl0J3Mgb2ZmIGJ5IGRlZmF1
bHQgYW5kIG5vb25lJ3MgbWFkZSBoYXMgbWFkZSBhbnkgbm9pc2UgYWJvdXQNCmhhdmluZyBpdCBv
biwgd2Ugb3VnaHQgdG8gcHJpb3JpdGlzZSBzaW1wbGljaXR5Lg0KDQpHaXZlbiB0aGF0IG9mZiBp
cyB0aGUgZGVmYXVsdCwgYnV0IHdlIGtub3cgdGhhdCBrZXJuZWxzIGRvIG9mZmVyIGl0IHRvDQp1
c2Vyc3BhY2UsIGFuZCBpdCBkb2VzIGdldCB1c2VkIGJ5IGNlcnRhaW4gcHJvY2Vzc2VzLCB3ZSBu
ZWVkIHRvDQpwcmlvcml0aXNlIHBlcmZvcm1hbmNlLsKgIEFuZCBoZXJlLCB0aGlzIGlzIG5ldCBz
eXN0ZW0gcGVyZm9ybWFuY2UsIG5vdA0KImVuc3VyZSBpdCdzIG9mZiB3aGVuZXZlciBpdCBjYW4g
YmUiLsKgIEhhdmluZyBYZW4gcnVuIGluIHRoZSBndWVzdA0Ka2VybmVsJ3MgY2hvaWNlIG9mIHZh
bHVlIHdpbGwgcmVzdWx0IGluIG11Y2ggYmV0dGVyIG92ZXJhbGwgcGVyZm9ybWFuY2UsDQp0aGFu
IHRyeWluZyB0byBtb2RpZnkgdGhlIHNldHRpbmcgaW4gdGhlIFZNZW50cnkvZXhpdCBwYXRoLg0K
DQoNClNvcnJ5IHRoYXQgdGhpcyBpcyBhIHZlcnkgbG9uZyBhbmQgc29tZXdoYXQgb3BlbiBlbmRl
ZCBhbnN3ZXIsIGJ1dCBpdCBpcw0KZ2VudWluZWx5IHRoZSBsZXZlbCBvZiBjb21wbGV4aXR5IEkg
Z3JhcHBsZSB3aXRoIG9uIGV2ZXJ5IHNlY3VyaXR5IGlzc3VlDQppbiB0aGlzIGFyZWEuDQoNCn5B
bmRyZXcNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 22:02:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 22:02:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428021.677745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om06D-0006E5-P5; Fri, 21 Oct 2022 22:02:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428021.677745; Fri, 21 Oct 2022 22:02:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om06D-0006Dy-L7; Fri, 21 Oct 2022 22:02:41 +0000
Received: by outflank-mailman (input) for mailman id 428021;
 Fri, 21 Oct 2022 22:02:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1om06B-0006Ds-I8
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 22:02:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1om068-0004mc-Hb; Fri, 21 Oct 2022 22:02:36 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1om068-0008Il-9x; Fri, 21 Oct 2022 22:02:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=RfGouTLT2U5jEb0lWbfH1vE7DwS/WvTls4YB2mlYxEU=; b=C3euaVH3287MExPCYVyB4aBww5
	awo7hW8jdc27UjrzxzlPM4dU1Udqv4kSCfC/W8L4/nPbCdjHpgWfx0FLqziKynJpF6Pwzgbg+yqKu
	O0Hg91Wi9RQIqdTB/5gUFjUG+w6LnTVtfQBctwT2YpLSKPnc3gthZ7QasLvE30tpetBA=;
Message-ID: <58c2c77a-c61c-fa14-9d92-0dabac814a15@xen.org>
Date: Fri, 21 Oct 2022 23:02:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
To: Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Michal Orzel <michal.orzel@amd.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Doug Goldstein <cardoe@cardoe.com>, Henry Wang <Henry.Wang@arm.com>
References: <20221021165341.7905-1-michal.orzel@amd.com>
 <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
 <alpine.DEB.2.22.394.2210211211090.3873@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2210211211090.3873@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 21/10/2022 20:36, Stefano Stabellini wrote:
> For the NULL scheduler, it is clearly important to many users so it
> would be valuable to move it to "supported, non security supported" and
> enabling it by default in the build. I don't recall if we still have any
> known outstanding issues with it. I think we need a separate email
> thread for that discussion and I would understand if the decision is not
> to change NULL support status for the 4.17 release (maybe for the 4.18
> release?).

At the moment, I am tracking two major issues for NULL scheduler:
  - ED25BE5E-D695-4763-B97A-78D6040E2341@amazon.com
  - alpine.DEB.2.22.394.2201051615060.2060010@ubuntu-linux-20-04-desktop 
(reported by you)

Have they been fixed? If not, then I don't think can be moved to 
"supported, not security supported" because it would fall over basic setup.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 21 22:07:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 21 Oct 2022 22:07:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428026.677755 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om0Ap-0006u7-90; Fri, 21 Oct 2022 22:07:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428026.677755; Fri, 21 Oct 2022 22:07:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om0Ap-0006u0-6J; Fri, 21 Oct 2022 22:07:27 +0000
Received: by outflank-mailman (input) for mailman id 428026;
 Fri, 21 Oct 2022 22:07:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Jmp5=2W=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1om0Ao-0006tu-4K
 for xen-devel@lists.xenproject.org; Fri, 21 Oct 2022 22:07:26 +0000
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com
 [2a00:1450:4864:20::42a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id be0d59ee-518c-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 00:07:24 +0200 (CEST)
Received: by mail-wr1-x42a.google.com with SMTP id j7so7086835wrr.3
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 15:07:24 -0700 (PDT)
Received: from [192.168.1.93] (adsl-70.109.242.225.tellas.gr. [109.242.225.70])
 by smtp.gmail.com with ESMTPSA id
 l34-20020a05600c1d2200b003c6edc05159sm792761wms.1.2022.10.21.15.07.22
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 21 Oct 2022 15:07:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be0d59ee-518c-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=0fWkAaj/64/KGu+nvR8DXTnwG0ewY89q8R5CdE5ZIdU=;
        b=IZh3S4JOy0AKzGnUnUZM/ZtQR48BvqSNa8bXbB00CceY2K1DlMuow+QRn33upujkz5
         RAv34Ti0tduCKv8hEasnZ7w4fywmKv31Om7tTgn1A7k42roO+bbxgajPhd5TyfFZuR8g
         Y/gWSo0oXDUwl8G4sGyc3tqqKHI+NwWrNOoDUACJcRZtu6z7T0d9eMeWmuGoLt5dLmfl
         SXPR03sO1UJChyYpcxdVKb+RvExnsQibrqHYucvAT5IrZSGu+OFO852gEDPplHAZKosv
         +dhzuSDyK6f4WPRoc6CgzEMXnuJnhwWpES2X3QJEN8idaJLreqr2l3+Kndmy6kFhWU1R
         DJ1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=0fWkAaj/64/KGu+nvR8DXTnwG0ewY89q8R5CdE5ZIdU=;
        b=dZlOja77RCaOTYzRBI4R8jHgl/ZeABgZZs6EyVHtBIfwgxXBdiQxMf2FDEObkXXkby
         y+vBxPhb9ZtZ/W52hoCCOBSh7BxkSayq/UotVX/OSqplyKmRQ2V2ALjjryPQojZjXOML
         InCh5Ix2LQfV7LsJLUiu6XQ1Wug8U9sIsefTpHt7SGT8BGTatIRYcJxU0SKpN/KWvSu1
         EHMsgqPonsr7aS4QPM1E/0WAE6RTIv5tYUUIjLCh2TuAFSvF84dBmsVgMRZGwe54bsrJ
         T4EWzWmcMtKE9US88CYHwCNUO3HPaauoAEs3ibTNedLUrcgA2t4PIPMU8V7VwTAirYLE
         FGcQ==
X-Gm-Message-State: ACrzQf3yfa5+qsx+NC64tDcjWGlVTG0n3lD9aoLS4y9aM6pUCacdDQfr
	wvwehcFSrh7p/qczczEfJt4=
X-Google-Smtp-Source: AMsMyM4R4UY+On0MBm7AFMnZs3L12yFoJsWKlMS9Ojr90JLNCD+ori15UrkX00Rryx8rSmzr5PyASQ==
X-Received: by 2002:a05:6000:170b:b0:22e:44d0:6bae with SMTP id n11-20020a056000170b00b0022e44d06baemr13452403wrc.99.1666390044100;
        Fri, 21 Oct 2022 15:07:24 -0700 (PDT)
Message-ID: <24feccd2-c90e-2abd-ebc3-4219bd15e380@gmail.com>
Date: Sat, 22 Oct 2022 01:07:22 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v1 04/12] Arm: GICv3: Emulate GICR_TYPER on AArch32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-5-ayankuma@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221021153128.44226-5-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 18:31, Ayan Kumar Halder wrote:
Hi Ayan

> Refer Arm IHI 0069H ID020922,
> The upper 32 bits of GICR_TYPER represent the affinity
> whereas the lower 32 bits represent the other bits (eg processor
> number, etc).
> MPIDR_AFFINITY_LEVEL() returns a 32 bit number on aarch32. Thus, this
> is appended to return GICR_TYPER register.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/vgic-v3.c | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index c31140eb20..d86b41a39f 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -190,14 +190,18 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>   
>       case VREG64(GICR_TYPER):
>       {
> -        uint64_t typer, aff;
> +        uint64_t typer;
> +        uint32_t aff;
>   
>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 |
> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 |
> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 |
> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32);
> +        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 24 |
> +               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 16 |
> +               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 8 |
> +               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0));
>           typer = aff;
> +
> +        typer = typer << 32;
> +
>           /* We use the VCPU ID as the redistributor ID in bits[23:8] */
>           typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT;
>   

I don't see an issue I just want to propose alternatives that I think 
would reduce the changes, hopefully without breaking it.
So, other ways would be either to assign v->arch.vmpidr to a new 
variable uint64_t vmpidr and operate on this (without changing the 
shifts), or to leave the type of aff uint64_t, adjust the shifts and do 
typer = aff << 32.

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 00:22:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 00:22:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428038.677785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om2HO-0004eS-QE; Sat, 22 Oct 2022 00:22:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428038.677785; Sat, 22 Oct 2022 00:22:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om2HO-0004eL-NE; Sat, 22 Oct 2022 00:22:22 +0000
Received: by outflank-mailman (input) for mailman id 428038;
 Sat, 22 Oct 2022 00:22:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om2HN-0004eB-Fg; Sat, 22 Oct 2022 00:22:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om2HN-0007dw-CI; Sat, 22 Oct 2022 00:22:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om2HM-0001np-Qo; Sat, 22 Oct 2022 00:22:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1om2HM-00071T-QP; Sat, 22 Oct 2022 00:22:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PWj6UiFoGi5I1qDFZH7HzUjf7p9t0iIa1PjIRlmtIqk=; b=5mGmDbKq6Kf8r7y+dSFvb0mO8j
	ngvWupbi+vfPYBhBSq0zOK24Pws9NMQfYOZX7ZBDBDcm0JZYK4ab6fBYvc2bouYjUWIVXU4RKsOWh
	TAX/ctdNvZoy6xA26wr+JlyrCmWiPXAQv/QRZRFtn0kB2werDb8zdFge+N0IS686ihZY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174183-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174183: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 00:22:20 +0000

flight 174183 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174183/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173987 REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start    fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-vhd   12 debian-di-install fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start   fail in 173987 REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start  fail in 173987 REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174183
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174063 pass in 174183
 test-amd64-i386-xl-xsm        7 xen-install      fail in 174063 pass in 174183
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174063 pass in 174183
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173987
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 174063
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 174063

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start    fail in 173987 REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd      12 debian-di-install       fail blocked in 172547
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174063 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   67 days
Failing since        173494  2022-10-11 13:38:08 Z   10 days   12 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    9 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 00:50:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 00:50:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428048.677801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om2ik-00083d-3z; Sat, 22 Oct 2022 00:50:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428048.677801; Sat, 22 Oct 2022 00:50:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om2ik-00083W-0r; Sat, 22 Oct 2022 00:50:38 +0000
Received: by outflank-mailman (input) for mailman id 428048;
 Sat, 22 Oct 2022 00:50:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wiZN=2X=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1om2ii-00083Q-Ut
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 00:50:37 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr00041.outbound.protection.outlook.com [40.107.0.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8925c28e-51a3-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 02:50:34 +0200 (CEST)
Received: from AM6P193CA0037.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::14)
 by PAXPR08MB7395.eurprd08.prod.outlook.com (2603:10a6:102:2bb::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Sat, 22 Oct
 2022 00:50:32 +0000
Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8e:cafe::6e) by AM6P193CA0037.outlook.office365.com
 (2603:10a6:209:8e::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Sat, 22 Oct 2022 00:50:32 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Sat, 22 Oct 2022 00:50:31 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Sat, 22 Oct 2022 00:50:31 +0000
Received: from 3d2b69b1863a.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 86CD84AE-B35F-4D78-AA0E-A1B383D78F3B.1; 
 Sat, 22 Oct 2022 00:50:25 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3d2b69b1863a.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Sat, 22 Oct 2022 00:50:25 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB7713.eurprd08.prod.outlook.com (2603:10a6:10:3bf::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.36; Sat, 22 Oct
 2022 00:50:22 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5723.034; Sat, 22 Oct 2022
 00:50:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8925c28e-51a3-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=HqofmzV/7Oi4kavfo6tGjfhsAId1YaPEyrQipv9vqzg3lTfPkLoPhUt5t0cCy39w26p77cBFnrAGBq4+fmdycv4zSS7gPYdS5ZASW8LIIFli5kxT7L0JorzB4XseQ8nF+j2le4xHizOhRZgCL0sSiS7MHT6sx9fOJA9TJPMCd6gYRbyLw+4ETM5UnHZ8Mu2LMC0ATOWvLtd5Pq/eMKfXhuNAon+h4/rptZnZy+MHtKqXjsXYOD/N95Qa00WI/wnCztOsfvgUIiQ/Z8k9Snf/+A8jY/RYbpUlnisFxYwLHFkd/X8HMVZkGA50nu29QgP/5FdEQ/Glq5Fx+AmT8lYynw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dTOHKlBuV9kI5cFgDUwzJGcibkdLXMyp3fOv54mXaDc=;
 b=jGXRFpuM4awAKSzvSotOvgDirKEPVFl5qJgCC/FzkOXfBfP2YRApayP/11gLXXZxZ/2x3k7OD0f7nqlMGLXoaHJkATaCagHpws5K5mTQpWV3DLE8zx96BWkQ3BshABgJHqL+FJRMhfEZWA9CLFrMiuwIqY7Q4orbL7ewA1+cvfqYfUqPMagTtxrH7RuMEP06hfYRrTlZHXy37G4+rW0BrpdEHHiCtf2bQ7folp5FrVKqlBDPtRqA3XrRxZnUXhGnOagZzVgN9h3A6ypd7W5khss1yXBuP8krYOKxQ1exO6mzLyycYxVb5pDp3JHR+6wOWgGgehBtB5yl/W7zXcXn4A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dTOHKlBuV9kI5cFgDUwzJGcibkdLXMyp3fOv54mXaDc=;
 b=aBmB7meiIiCnWomefqvdojtk0C6vwPw4kLIPVEVHvQYD8PwSokeEyfY68XRll5Pqrp6S1JG0QB/EbVM2tf+NclmkzITfvCKZssT4kO8c1ObA3xEE+oXfn+GhWYqtOzL6RmF7a5dzAvXvqH7Jso+xgeILGe7RA1j4985yBMRUKFw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MOpl/Kz4P21D4lxyp4+bnZUYPPqHJGxR83WaOXwNNR7QWObt2Ia0Rs8n7iQNP6KKcGvB5A/G9IZi6MntCKgFkehXdey7l4Y/+f8FOVmz9MGCYUb1NTFX1EFknpdERVXY2FwPD42r1rhQNnRL5eBy/hrUT3Bg3TbeyviRbtst+jg7qlnSOW1OzvacRcWcuXV0473AX0O5F9C3yBo4pRj/sndbJsNrINKrQ1tXEmAXO+JhLvwgGgMKCrfdVJd+rLy2iLkichSAc9qGx0YL3Am1Nfg/PiJ8k1nxN5fglkbePxr2WFtUFoqzzzMtU0LKhuz8s9NazL4DPVR+dAgelMa7vg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dTOHKlBuV9kI5cFgDUwzJGcibkdLXMyp3fOv54mXaDc=;
 b=mKnmk/mnKISjyBy/qZevjFe5fV8lbEWqnWypQ4MlQHmbhzAeoGRNR/7SkU7M0oejQi6Gvp3jDihfXn4ZYWugDFNhF2Sh4DihIzyjM+3U98tnbTQGGFkvFz2unrfNfRf/xx8VaYAXC14TU7zCdSGAzImitB632w+M+UFSmDcNrzFA5b2IU6EKAMiT1gj8Dlsa59K/Fl2T3zZobnbVEJi3q6g5ump0BQhT5F3E9pVB3oNSrjvFxKVO8Im4E0gYH60LJ5Opp8py+kZo2FTFBKBhGgcLMkez1XzkYgwMInHBpIvjlDSHd4I9tUTZZRC5QtSCh3g35m4ZTE3Y4ipPN/dDAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=dTOHKlBuV9kI5cFgDUwzJGcibkdLXMyp3fOv54mXaDc=;
 b=aBmB7meiIiCnWomefqvdojtk0C6vwPw4kLIPVEVHvQYD8PwSokeEyfY68XRll5Pqrp6S1JG0QB/EbVM2tf+NclmkzITfvCKZssT4kO8c1ObA3xEE+oXfn+GhWYqtOzL6RmF7a5dzAvXvqH7Jso+xgeILGe7RA1j4985yBMRUKFw=
From: Henry Wang <Henry.Wang@arm.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>, Oleksandr
	<olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Jan Beulich
	<jbeulich@suse.com>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, Julien Grall <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>
Subject: RE: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Thread-Topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Thread-Index:
 AQHYmuuJ09LC1x/2uEWs942YY/fNVK2FNeCAgABJdQCAAALGgICT+/QAgAAA3ZCAAAXcAIAApa8w
Date: Sat, 22 Oct 2022 00:50:21 +0000
Message-ID:
 <AS8PR08MB7991E3C3897AF89E969F6412922C9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20220718211521.664729-1-volodymyr_babchuk@epam.com>
 <20220718211521.664729-5-volodymyr_babchuk@epam.com>
 <b4554a1f-73ab-7a46-591b-ccb5bb34ea1f@suse.com> <87ilntgzpj.fsf@epam.com>
 <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com>
 <e9120354-e72e-2774-c382-45ab0cb76220@gmail.com>
 <AS8PR08MB7991C3933F253BE49BA61B76922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <0F295AC7-1D2C-4F5D-A421-9440CEB2B5FA@arm.com>
In-Reply-To: <0F295AC7-1D2C-4F5D-A421-9440CEB2B5FA@arm.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B4821A212E9F5F44AA979614AFF0F333.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB7713:EE_|AM7EUR03FT025:EE_|PAXPR08MB7395:EE_
X-MS-Office365-Filtering-Correlation-Id: 0e4c10e2-36b4-453a-bd97-08dab3c76c09
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 nVqy5XJBvcIRbsGKBLgd1Zl5wG57pnkeFG1yPGYy9+092K1jv/r0fk6H3BZIqa7VWxXjhkur4miqxK+2t2sy7fly2igbKsKnkVeW+rpCGStGVFyioZUPpr4vIcrrp97pzc96QW9QLGu72Y0gGyoAsOcUrfQhnHd/6LnR6mYMCnomDDGx9O4vkadpjID4WtmzuL9itLTs6PD31STRNMHrwrXBIHF6s38r8bynjvUh5odWaNdujw2nx0bS2/7SM9LcavUaQKMb/2d4FkbryfFOiwi5egbjrixWA8m4k1soIpjapoXDmyTRZWkU8RQpa83scGrmKWtEnPt9C2wxBamuWlgYC/E6HchC/N8b6uwBQRXjmYc11jYGQy9PIJHFh0ZqfCysap6j1lFCd1g6gHUZLwHP1DRJKRZLvxe+Ylud+EkXz7bG4CXZ6PlunSJ1eN64467a7f5EQG4QlzmU4/0KSrz+JyafOTQdvo3mzweO43fAXWm7n9tVkXGe3GgLb3ZbQ8s8DmWppzcUrj6PHKCRd6D+lthpKyydLta/wZAFgsuXnS9ZcfMEqz1oUtZj/sN5wyTU4frqA2/iPedD/cvcASepFDHHNnlCl7vHm/CdHT5iUnZd3CWye0seXlwIRDSsRzUgu31MsxpjCtVMLLG08DOTer3vipooMRjpO0i/SknSTZfcvUcvsGAfrkNXpLViUE1+wBuSb5QDd0FpHDdXUOco9VZe1uROECAJZcG31GU316w6WRSxbFBLGWO/mUMA+JlNdk3Ofqp7s1kETNYxVA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199015)(122000001)(53546011)(6506007)(66946007)(76116006)(66476007)(7696005)(66556008)(316002)(66446008)(8676002)(64756008)(4326008)(110136005)(54906003)(33656002)(71200400001)(2906002)(41300700001)(186003)(55016003)(83380400001)(9686003)(26005)(86362001)(52536014)(5660300002)(8936002)(38100700002)(38070700005)(478600001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7713
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	361d385a-f216-4f8c-9350-08dab3c765b0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8dVIqKgSp38pW+1FebRrCLlpQ6rhuUtTT11h3VFu5vgIPWRMZh97Hkf7jCTnTwRkEmEkRrteu8AH+owLDwo/r+v0B9K0U6l1vrecI5eTcv+mHZwOHga1pm1OADgA7aHvVvLbz8yEgv5nkEYuQmUMsfMlaFIUeQW8eR9JwEsBTH2MpHXltIP36Vcx7hIvBiWoxZ0nOlSm7HzgSZktW6S6BXkso+gVOAOJsQaZw1WcZaG0dhQbA8NIC9ua7sNDIEVApm59yb4sUb1qRObPvq1QUV0fKn2QGk0Nf/Ob2iu1dy8eRpHXd5aSQZwSWlYE/XljGSm03p4EI1sShJ753zPawQhZdrvKnmkPz/jmC+Fdk657QsLYhYH5JhInChgmV9sq6pKa8BN6/yxiV8K/x34x4pvC3gL5H/Y7b9u9rcNUH1gNkiG9F5ztgfgDu10VnPGmFdyb76zyt7TfuCzTrQMEs5Ix7U6z1X/wVTkigjr1zAKdaP2GwJh314YIejy1ur+ytUIx9i76pgs8b4UoTxttbpBOXFIbgKFXwOso1uFVDfvyx6+W4YVrfiWL6w738uccpHJrJfLIT1h9PzaExlh6CHocjD2rVkf1ffe5J5muLUq3fnRW/M+igamSGLu5MvqACcY+uQBh2oEC2UcLxX/D/zEcbNUo0Yn3vUJiempYfxSoXJdEaVkNtX2L9Cce7IMNZ++yxC3CYCIfUKl08DnGr1OpUmJAlssOOh8CVRj8riolRzMX6th5/eJN/B9g/E2oQBVk8CZZtUOrtnrc75+3ag==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(26005)(52536014)(81166007)(2906002)(7696005)(9686003)(356005)(336012)(8936002)(82310400005)(53546011)(36860700001)(6506007)(83380400001)(47076005)(82740400003)(5660300002)(41300700001)(55016003)(186003)(40480700001)(478600001)(54906003)(33656002)(107886003)(316002)(70586007)(70206006)(40460700003)(8676002)(86362001)(4326008)(110136005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2022 00:50:31.8163
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e4c10e2-36b4-453a-bd97-08dab3c76c09
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7395

Hi Bertrand,

> -----Original Message-----
> From: Bertrand Marquis <Bertrand.Marquis@arm.com>
> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>=20
> Hi,
>=20
> > On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote:
> >
> > (+ Arm maintainers)
> >
> > Hi Oleksandr,
> >
> >> -----Original Message-----
> >> From: Oleksandr <olekstysh@gmail.com>
> >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on A=
RM
> >> Hello all.
> >> On 19.07.22 13:40, Jan Beulich wrote:
> >>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
> >>>> Jan Beulich <jbeulich@suse.com> writes:
> >>>>
> >>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
> >>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call=
 to
> >>>>>> iounmap(), but not added corresponding include.
> >>>>>>
> >>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> >>>>> I don't think there's any active issue with the "missing" include:
> >>>>> That's only a problem once Arm has vPCI code enabled? In which
> >>>>> case I don't think a Fixes: tag is warranted.
> >>>> Fair enough. May I ask committer to drop this tag?
> >>> I had taken respective note already, in case I end up committing this=
.
> >>> But this is the last patch of the series, so I can only guess whether
> >>> it might be okay to go in ahead of the other three patches.
> >>>
> >>> Jan
> >>
> >>
> >> I am wondering, where this patch could be 4.17 material?
> >>
> >> The patch series seem to get stuck, but the current patch just adds a
> >> missing include to fix a build on Arm, so it is completely independent=
.
> >> I agree, there is no issue with the current code base as vPCI is
> >> disabled on Arm, so nothing to fix right now. But as PCI
> >> passthrough/vPCI on Arm is in the development stage, the developers
> >> enable that support in their builds. I think the risk is rather low th=
an
> >> high.
> >
> > It seems reasonable to me, but I am curious about what Arm maintainers
> > and PCI maintainers think. From the history discussion in this thread I
> > think it is pretty safe to include this in 4.17. Thanks for the ping.
>=20
> I think this can safely go in for 4.17.
>=20
> Cheers
> Bertrand

Thanks for the feedback :) Feel free to add my:

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


>=20
> >
> > Kind regards,
> > Henry
> >
> >
> >>
> >>
> >>
> >> --
> >> Regards,
> >>
> >> Oleksandr Tyshchenko
>=20



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 01:02:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 01:02:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428054.677813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om2uA-0007xl-8F; Sat, 22 Oct 2022 01:02:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428054.677813; Sat, 22 Oct 2022 01:02:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om2uA-0007xe-5O; Sat, 22 Oct 2022 01:02:26 +0000
Received: by outflank-mailman (input) for mailman id 428054;
 Sat, 22 Oct 2022 01:02:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om2u8-0007xU-T9; Sat, 22 Oct 2022 01:02:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om2u8-0006dx-Pk; Sat, 22 Oct 2022 01:02:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om2u8-0005SC-I5; Sat, 22 Oct 2022 01:02:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1om2u8-0004tn-Ha; Sat, 22 Oct 2022 01:02:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Jjh+CEbqHDOQhT4mXeNuSXygWYM3ioegM43o305eIuY=; b=3y7kvjhAf8K1ZPLGNIXkwpmtIr
	3n37/uXdNLNnzBr4JLlTeSkG/KJygaiDFbBMPgSdKIHAjWVtkzPm3pJnVtdA2FOmqrO9Zs/yXCTZl
	Aa4v0kzeSuevr3iCeGiM16Ig7YBf4NfvXX/KjfuM9YJDtjdORxjRfRmoMCIpS4S1xUx4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174174-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174174: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e35184f321518acadb681928a016da21a9a20c13
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 01:02:24 +0000

flight 174174 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174174/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                e35184f321518acadb681928a016da21a9a20c13
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   14 days
Failing since        173470  2022-10-08 06:21:34 Z   13 days   22 attempts
Testing same since   174174  2022-10-21 05:53:21 Z    0 days    1 attempts

------------------------------------------------------------
1328 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 123948 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 03:53:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 03:53:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428077.677872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om5Zw-0008Vs-Tj; Sat, 22 Oct 2022 03:53:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428077.677872; Sat, 22 Oct 2022 03:53:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om5Zw-0008Vj-Ns; Sat, 22 Oct 2022 03:53:44 +0000
Received: by outflank-mailman (input) for mailman id 428077;
 Sat, 22 Oct 2022 03:53:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7k0s=2X=gmail.com=liu.denton@srs-se1.protection.inumbo.net>)
 id 1om5Zv-0008Vd-FT
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 03:53:43 +0000
Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com
 [2607:f8b0:4864:20::532])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d6fad9b-51bd-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 05:53:41 +0200 (CEST)
Received: by mail-pg1-x532.google.com with SMTP id 78so4170876pgb.13
 for <xen-devel@lists.xenproject.org>; Fri, 21 Oct 2022 20:53:41 -0700 (PDT)
Received: from generichostname (136-25-1-99.cab.webpass.net. [136.25.1.99])
 by smtp.gmail.com with ESMTPSA id
 p184-20020a625bc1000000b005618189b0ffsm15930477pfb.104.2022.10.21.20.53.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 21 Oct 2022 20:53:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d6fad9b-51bd-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=OJ3ihIRL9MraIVj9GE5SrhQO6XWcgV8rR2mvmSML20E=;
        b=QxzZKKIpfaY6qBU4kQ+KTqHvuXrEFztvWHqr2EZSQA2VzukverFpOVy5ZrjBIiIA7b
         lUsVla6Iyns0/9rRL+TkBEHq4+xGWveC6PFCR+MS+1hkn50dVdy74BqRJW1Ef3u28FU1
         RyHm7cDABG12QKbLaAx4DSrPWuzUOurTmoF+qzg85xIGRjiXfvM28JLer7tR8ajmjl77
         sjwqtjXMTAZ7522MAj5dXpRR4V59vcdTVP6n4iUEcCMY+PnTzE90STLJtWBryjhS5pHG
         gy/w0RCrrRBawYjwif/AzcpnPPDWpkYdoexKoOs7gngl5b6vXS+8UeijuBgdl0vOLiT8
         PYqQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=OJ3ihIRL9MraIVj9GE5SrhQO6XWcgV8rR2mvmSML20E=;
        b=1RwsdcQxU7pr2YPUy7/IyeYxpAq2Ze/JmmkKVwaeWuBct0MDpvzmPgC/2QUQtTRwPm
         K5gPAixz0ny6ojUWiCXCpapWyMnrYej8phYwijFwEGmEv/D/wqME+OCW/5/V55cFpsvj
         2oTngk+NRVpegrdDiKk74vx/zMat+OwZihfUX+oFT9RQUfO9Dz/hfIqwnDsVH7p/+k2J
         R6ZqnuGcYQg8gqjQijnehMuLxtsv3N7fywTfmOqnT/vwnLwWPc0O6YhEmLTdBuTiHF0Z
         NBDkbh4BwF1/Pwm/IEEBQonfdBZD/2PbgSEKypFVN55GtlqzLef/iUoT1+T/6h7zDEM5
         180w==
X-Gm-Message-State: ACrzQf1YBeuYqcLHTnbsUt2xDCy2fB8Anaf2VsXlT3qPEGYeGb5du/P2
	6WXI0K9I6PqDzHl8Par42dbCCCsZPZg=
X-Google-Smtp-Source: AMsMyM42y17bWkB/OFdTCrRm2xJDaYzraXMJRGfoX6jL/pbSMEDC528hQBUz2iqOxlgqLU8GmLUu3A==
X-Received: by 2002:a63:6c07:0:b0:457:523c:4bd0 with SMTP id h7-20020a636c07000000b00457523c4bd0mr18881225pgc.101.1666410819578;
        Fri, 21 Oct 2022 20:53:39 -0700 (PDT)
Date: Fri, 21 Oct 2022 20:53:36 -0700
From: Denton Liu <liu.denton@gmail.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <Y1NpQKadAS1EgY1c@generichostname>
References: <20221017103532.845293-1-liu.denton@gmail.com>
 <20221018131235.5e70f0bc.olaf@aepfle.de>
 <Y06w0Oda0sHTHPNW@generichostname>
 <20221018161821.149ee6fd.olaf@aepfle.de>
 <Y0+CzFbQXxYiqgPC@generichostname>
 <20221020171306.45c275f9.olaf@aepfle.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221020171306.45c275f9.olaf@aepfle.de>

Hi Olaf,

On Thu, Oct 20, 2022 at 05:13:06PM +0200, Olaf Hering wrote:
> After reading the patch again, the newly added documentation states:
> "This option should be a path to a kernel image."
> 
> I think it needs to be more specific: is it expecting an absolute path, or just the basename of the desired image?

Thanks for the feedback, it should be an absolute path. I can submit a
new version of the patch later. However, before I do so, are you still
a NAK on the general idea?

-Denton


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 04:31:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 04:31:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428086.677889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om6AK-0004Xp-P6; Sat, 22 Oct 2022 04:31:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428086.677889; Sat, 22 Oct 2022 04:31:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om6AK-0004Xi-M2; Sat, 22 Oct 2022 04:31:20 +0000
Received: by outflank-mailman (input) for mailman id 428086;
 Sat, 22 Oct 2022 04:31:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om6AJ-0004XW-7t; Sat, 22 Oct 2022 04:31:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om6AJ-0002J8-3f; Sat, 22 Oct 2022 04:31:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1om6AI-00015d-T0; Sat, 22 Oct 2022 04:31:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1om6AI-0002b0-SY; Sat, 22 Oct 2022 04:31:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t/Wna+HpRSHO2G2QCHVFxCDyuOznmPVe3FUmIpx4bo8=; b=app7hpnopPoJcuZbzEf5q7q5pU
	QvaSBhbCURoTzZUh/U/DcRPBEy4L394J7zGEiJrKpUXUWpVK6VqJts2pkj7F5CzA09duN683XQdEf
	mNQKAo/YjJlWOTwBY+aurr+Nz8kxEfuq7049w61aNFQIXz6rzPxWG0rbMfMJPAbDxdHk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174168-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174168: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=f1d63048b76bae8d9dd5c2f693a6df64c8117538
X-Osstest-Versions-That:
    libvirt=a58da464154cb02b5630fb42e0b0924d22aeb750
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 04:31:18 +0000

flight 174168 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174168/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174112
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174112
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174112
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              f1d63048b76bae8d9dd5c2f693a6df64c8117538
baseline version:
 libvirt              a58da464154cb02b5630fb42e0b0924d22aeb750

Last test of basis   174112  2022-10-20 02:09:40 Z    2 days
Testing same since   174168  2022-10-21 03:40:58 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gogo Gogsi <linux.hr@protonmail.com>
  Ján Tomko <jtomko@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Peter Krempa <pkrempa@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   a58da46415..f1d63048b7  f1d63048b76bae8d9dd5c2f693a6df64c8117538 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 06:28:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 06:28:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428109.677935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om7ze-0000hP-Mx; Sat, 22 Oct 2022 06:28:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428109.677935; Sat, 22 Oct 2022 06:28:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om7ze-0000hI-K6; Sat, 22 Oct 2022 06:28:26 +0000
Received: by outflank-mailman (input) for mailman id 428109;
 Sat, 22 Oct 2022 06:28:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=65bH=2X=aepfle.de=olaf@srs-se1.protection.inumbo.net>)
 id 1om7zd-0000hC-Do
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 06:28:25 +0000
Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de
 [85.215.255.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ba7b6a98-51d2-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 08:28:23 +0200 (CEST)
Received: from sender by smtp.strato.de (RZmta 48.2.0 AUTH)
 with ESMTPSA id z9e8dfy9M6SL7by
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
 (Client did not present a certificate);
 Sat, 22 Oct 2022 08:28:21 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba7b6a98-51d2-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1666420102;
    s=strato-dkim-0002; d=aepfle.de;
    h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date:
    From:Subject:Sender;
    bh=23FJD2PUTBFkSkSRbZ2gtwNWOatC1seYKW6e9NyIfzY=;
    b=pkOhad0GZNO5+6QCReehqHDtsYvRdRydcvP6dgfk8FiAs4TkrngDgHanvZJ7DKfWLr
    apqElnGt10YJs7Ylv1gB+NZGLQV4XTzOm1dS16w63po86pmKGAfjJJ7IKB6VpyK5DBuz
    mo9vfwKOK6vqTaaZD7/iHC0mdPHsFFhze35/bE2EyvmEJMm21Dhf8wdgqeDdTWkCfEMV
    hKFw1SACmQJ06Wvc+/kGDoid8dFVfzyR9F8+weAZYqvKjzkAmsH+O2IG8r7HjBjZm1k8
    xjC2Rrtus57bc1PwjBTe1n5OYrg2rrmnYnu+23y67rTOOictHZlacpfw23itA6e7BC9d
    Uv+g==
Authentication-Results: strato.com;
    dkim=none
X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR4VUeIOBm64+d+5WUw9HQ/QxYfWfC38zdrSEMTow=="
X-RZG-CLASS-ID: mo00
Date: Sat, 22 Oct 2022 08:28:07 +0200
From: Olaf Hering <olaf@aepfle.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>, Oskari
 Pirhonen <xxc3ncoredxx@gmail.com>, mathieu.desnoyers@efficios.com,
 rharwood@redhat.com, samuel.thibault@ens-lyon.org,
 debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <20221022082807.35eda90d.olaf@aepfle.de>
In-Reply-To: <Y1NpQKadAS1EgY1c@generichostname>
References: <20221017103532.845293-1-liu.denton@gmail.com>
	<20221018131235.5e70f0bc.olaf@aepfle.de>
	<Y06w0Oda0sHTHPNW@generichostname>
	<20221018161821.149ee6fd.olaf@aepfle.de>
	<Y0+CzFbQXxYiqgPC@generichostname>
	<20221020171306.45c275f9.olaf@aepfle.de>
	<Y1NpQKadAS1EgY1c@generichostname>
X-Mailer: Claws Mail 20220819T065813.516423bc hat ein Softwareproblem, kann man nichts machen.
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Pazjidgh6E1Mr6=hT1MRHjX";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/Pazjidgh6E1Mr6=hT1MRHjX
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Fri, 21 Oct 2022 20:53:36 -0700 Denton Liu <liu.denton@gmail.com>:

> Thanks for the feedback, it should be an absolute path. I can submit a
> new version of the patch later. However, before I do so, are you still
> a NAK on the general idea?

It is not clear to me how useful it will be in practice.
In the end I have no saying about what goes into grub.git.


Olaf

--Sig_/Pazjidgh6E1Mr6=hT1MRHjX
Content-Type: application/pgp-signature
Content-Description: Digitale Signatur von OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmNTjXcACgkQ86SN7mm1
DoAUMw//TcGWCOQNUSJwXET9QTk8g5aFUsxP+XT+WNCNq7ZUfzbN5qPWZMTrfm6A
l6rO+N0+Rg/9XNGFCVzVPPf/RXxxBRPnQCEnBMwPqVqKzY+xB58YhKu7F5vs/clb
rVnz7upVLrFnEJ33kmpzLb0RHiwnwht+xzpB8d3iEs3BkUIhMYBLjrwg60nBEWtj
Y3cKltJb3Vol02ay4IT0K29mgCYXRj/nniBsMAkhFzzXfaJHi2v2jjRtjmq6HMW3
fNZ+OyjCj6TtgxKTorTBVs5QBV6JJ35+RwY0nz3XMofl9vWJxRp9XEr/rO47u6to
8y3BWOIOUWN+T296NdeNlVsyK74Nfaeb7Phkm6dl6EQqTYP932Pq3d8y+Cw555oP
CVjnCxIajHzwZBQKrFgARAkBS81/g6gRnWTLJBgXK5EQod5yO9pHX/S/BaVORiDW
Mmb4MnhU71zzDgaBFrBefKL2Quwkb8XENIHw6dm8dep5lLLURWE8rs85QhEmWl/r
afqrsFzlLE7lujnhe9HkWfUcl317fqZq7Ockizp3FKhZSqyohX43hMR6AJ+ElhuP
2J/Vj1Eo/xqaqHTMS2ghSpb61PkpVqJ0Vp9gy1Hq2Q3i/u3F7hF4q2TsT8XoTVap
7ZYHPjyT9Ipj+5bO/j+Zxo0jnQceBfkw/3gohx8vk6nzQA6K1fg=
=5hVy
-----END PGP SIGNATURE-----

--Sig_/Pazjidgh6E1Mr6=hT1MRHjX--


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 06:44:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 06:44:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428117.677946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om8FA-00039I-2G; Sat, 22 Oct 2022 06:44:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428117.677946; Sat, 22 Oct 2022 06:44:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om8F9-00039B-Uw; Sat, 22 Oct 2022 06:44:27 +0000
Received: by outflank-mailman (input) for mailman id 428117;
 Sat, 22 Oct 2022 06:44:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+8dK=2X=epam.com=prvs=22944a94c8=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1om8F8-000395-4b
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 06:44:26 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f69035ad-51d4-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 08:44:24 +0200 (CEST)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29M6UH4l003034;
 Sat, 22 Oct 2022 06:44:12 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3kc9gj0541-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 22 Oct 2022 06:44:11 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by AS4PR03MB8277.eurprd03.prod.outlook.com (2603:10a6:20b:4ff::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Sat, 22 Oct
 2022 06:44:07 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5723.035; Sat, 22 Oct 2022
 06:44:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f69035ad-51d4-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nYkj3FE+7XOQfYQoz0xjdAV0756p2qTA837cqwrrfx5KgfGcJpjD2SkPgRUq8t5YbJTb746SDEyzSjQ7AennZYygIdw0ebQM2B5ZsvXvbR/+oLWJAsLoB0WJJB6krgdvuGftbHaEhQyaYwbH7cLQOu78B1vbIChQmuBxxzlUUNbMfROmi2KDBOL17E6GYSMtgzTyDPBsgfauCyAiuhBvmD26+sYcBaWFWEpW3F1NC/u7+XsTw5toc1rmZ2qwikSEZ9t1hKub611TDIHMso2wRp4T80nrVFxtv785nGVlwttAYwhNeaWNhpOAc1OthrqlzBOrYSlMEQaQWwCJ/v1vFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iqHsloh15oamvoyWlNeNfCbMYn7Hk52xvV34QkjnddE=;
 b=kYDsOy/uIDwaSI/5/0g2lC70KsNQ8W5q3RZ7Egiy3V8Si3VML8wW9VK7o8SM7g/Nbj5uULEyJw7uXsoI+Km4ImciA9PK/7DLNRwXYvihS34mJoryd0XDSKqTOvcEtNGy4Z5gSjXtV7SH2ZKX2hBjWWO3GmfxPLwU6yKo8toYlk28Qks4U9m93W1Jj8QY3cqt02a12Bh1w1sBCjNf4dW67lHtI8ECiJXbWRp47AvUMAc+qAWubKAYjRloVNJINFoKQi2H9pxeACXqVnB0l2HfU8wDHb+eUFCi22SflFbHMTz1d8qypXsFLOZe0fT1wxQRnPhlu0/bCcGRveHn/wZvvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iqHsloh15oamvoyWlNeNfCbMYn7Hk52xvV34QkjnddE=;
 b=lzRXOzxXHspnWUMtksN6DpWptm5QtrsxyP1OqmjonSvrSqsBvdHvUP2cjUeuEH1etG+NgtjQPtwHJLMIsBnGCLmZmK3+eG2IAyYC4JV1saUlFYpW14nbBd+28rWaih5b2+lwA9i/A/NX6e4ngHxOvSpHGV9ohlndtWwywRHmB+1s/QVSnyH7b79/0ytkd+WI41Ob9qXwtRH+yI+cOQAdgIrthdwY+EtrI7c05XtKFkXf1Rk2kwe3aOO5cPkpXKBhfX3WxfCzDgNGB/K82WEIaymOBIu9Kqa/5ggJZ+eUsdymAOpE+QHRcAeCv4oU2D7KzvwOHj05I512O8yAm0AFgw==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Xenia
 Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V3] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V3] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY5XHz83EOKasQhkiM6N76eMhvp64ZRukAgACxiAA=
Date: Sat, 22 Oct 2022 06:44:06 +0000
Message-ID: <339d6029-8a96-6c8d-b6b7-64af956ff886@epam.com>
References: <20221021172408.77397-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210211258050.3873@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2210211258050.3873@ubuntu-linux-20-04-desktop>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|AS4PR03MB8277:EE_
x-ms-office365-filtering-correlation-id: 91c0ee3e-c9bb-4873-9e9f-08dab3f8d130
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mclay29dHYDM/Fub7ZCoTuG07yZT4AXaDANomAvFT0FvKmEENXGephhElhCCDQukgY2k115maYVwFhQUhKm+hFqWNtfFXhOhTzFB/T8mcOevs8za0djl+eCS96gNOyKD7We91f1SwCYGLVTGL7dS5rsf90dl7xyplwhuk0L0O3spB8mCnnkzTjOriVWCQY0BPB/TOEKDt6fAjqCNqcEiVDmZmlPpOb96Q5c5KUPAB6nLlVY+Mrt84bLkmP0gf4gsFHffWmyzGsLxjqxygy1M1PA2gL2IPcLkPPd+fDDwBUnqqRos2Rdr/7MxCnhuHSGLmZXxYR5PTHwTT8sYNrPMWtQtQPhvQXVq+/l3sVN1oKD1YprBZp7vULiWSktRmZOSyH49m+Vijg53jsdz570hSVlakCaNCZq+F1z7/xyZChs+07kKxPlQcyEFh5cgtS0VJyx6aEegXciEptqp4ufY2dU4CvMCLk2sS6zAA2oIFZygFwrvQxe19f77sQ1vLOmUC8dOnITcOYfAqecbGbeAGM1JEFy7lv00cdPxQz/mIyu1seCqQw+nKI/rSF8DMzBOVGwSJKHvGqFoZku7jfjTiPnlArDvHFaYS4e1Y2R55kbUz5mlhg0DRpvlFPPHT5V3sB9oqJH08uiErPlan/6osPV7i3csdKuP0DNDUJJdHndfef3VRhoKt9JNgS1QOfSBSictQSDgFouNnZaOp8POy46FfdYn/MD+Fza87/MSuUBt4lkPJwCFWAELVSjZOGpTkb2lGc7/BbdqD40eZyiXzhVAZbqiC38ZPaAeB98SQQI0iv6vEfBfb1U/MSoaHQiesiGOnWS0wpuJQDkgIm1VOEC0hUuGEMGyqswd5PACNabTROa9Syp7cFjY1DMU9BjK
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(366004)(39860400002)(136003)(346002)(451199015)(66446008)(76116006)(66476007)(64756008)(8676002)(66556008)(4326008)(91956017)(66946007)(54906003)(6916009)(122000001)(36756003)(316002)(31696002)(2906002)(38100700002)(83380400001)(2616005)(6506007)(26005)(6512007)(53546011)(55236004)(41300700001)(86362001)(38070700005)(5660300002)(8936002)(966005)(6486002)(71200400001)(186003)(66899015)(478600001)(31686004)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?SE1TSTlwVHRmemRqcVZlZUZKdGJVVUhmQ2tBL3hSWU9xbXdwaFFxRDg4dWUx?=
 =?utf-8?B?RllVREhsWUFPZDFPWTJTQi9FVHdMTVFyWmpQM2psUUtGZVcxa3Q1aXp1ZUg4?=
 =?utf-8?B?Yjhvd1lsRDhwR01XQXRkOE5qVVFGT2prOUdKMElRSU5pSnJEUUtNOWN2MVFk?=
 =?utf-8?B?ckkxN0tMMVd3M3Ryb0IzTDYxSzRyVVBLT2JGd0V1SVpvUC9abGRBR2p0RG8y?=
 =?utf-8?B?b2x1Wk52cEFJdE1JUDZ6YnhtN0w4dzVMZ2pMOStpRHozYUFQWXpBQjE3MHRD?=
 =?utf-8?B?RmdJUTF4OW9DSGdkZzVaZHlQR3AvZDZOVG1ydFc2cWc1RlFEaHpISThvRGZI?=
 =?utf-8?B?Ym1hbWIwVUJ0MUR0c0NTKzdEazVIdzlpSWVQU3RWcG5ET0UrT3hCSEptaEgv?=
 =?utf-8?B?eEluS2JodW5FZGNxSFBSemlNU1dHZHdvak9CbGh0eFA3NWpvVmZYb0tpaFJi?=
 =?utf-8?B?MzlHdDdvQjVFL0ZjTmJod3I2TCtocTVEbVVIK0RoQnJLUjdjbjZtSkJ3RzJs?=
 =?utf-8?B?bGt3T2M3L09nU1IrUWYrcm5VaC9NMm5XUzV0U2I0bml4VWtZTUdCQVZQV010?=
 =?utf-8?B?NDdqS21iS2NidEdwMUpDa2wra254RVFUVXE3NnVBaUoyUmcrTXF2U1B4a1Bi?=
 =?utf-8?B?MVZuaDBJeWR4VDJuNFBqTzdMR3hHeGJPNlRUSDFaNjZHcHJ4eHNOUXdSMDNE?=
 =?utf-8?B?YzRUU3ppaFBONllnMk5pMkhFcVRZTlB3TnZqRjZhUWsvbldzV1VvQ2R6dzdD?=
 =?utf-8?B?Y2RmSWVkODc1Znc4YjhuZWlUQmFLYjhrbDZxaFh2TmJXOFhhS0RJcEpnV2Vr?=
 =?utf-8?B?NHBIZExQaW1SbHNBb1RyTEg0QTBZMVo1WjRyaE9wdUc0NlU0OHFKeGJWTGdE?=
 =?utf-8?B?cnA2elM3ai9aYnNkMW9DSW1lbmNoeC9GTHZmSUZEb0NLNzhOTUVxQjdYdWJx?=
 =?utf-8?B?THN0SEowVlpwYUxFeTFzekQzMmpNeVdVTFBtRzJnZ3RnT3RvMXUydFRmZzVz?=
 =?utf-8?B?UnFrblJ1NFE0REE3SlhiUUMzUy9pREVDQTNOWHpLWUNJS3l3WVg4SGFCUjQv?=
 =?utf-8?B?VmRtdWI0dFo3VjVsOGJ0SzJYNXQyNVgrdjJmZmRyOHRHcndnN29LNzlnZ0Q2?=
 =?utf-8?B?R0g5N2dWbCsveU45NHRaMFlHWDIvNXpCM21vZEdmQlBONEI5clNMRXBqSUFx?=
 =?utf-8?B?V3RzMFBEZUUxNXNVOG9Ba0xoOVV4bzF3aHhjK3lxcHhCejBqbDh1VlZrUmJV?=
 =?utf-8?B?Vk5UNmRKRWttRElLUHNpTFU3clpOUGZZeW9rRkdIWkhuRG9zcVkyS2QzTUpT?=
 =?utf-8?B?ZWFGeHBiRUw4QmlEZnZBaXRvNmpNUTRsSEtQZHdHd2ZhNjg2MlZ1aVo3Umk0?=
 =?utf-8?B?ZjUrVG5VUE5ZbkU4MSt6K1hvQXMvd3QyQWU0RVdib3BLVGtDSjlpWEJ1d0FE?=
 =?utf-8?B?NFJqc0JPTWtBSkhGNUk4Y3hCYjJscGFEM1JaNHJPUGNWMjhFbGhBTDNLSWRD?=
 =?utf-8?B?cWZPa2lISTdpMDhSMHVFbVgzMjVXOGIzRGxpSGVNaFpGSFJHMDdHWm1lNFF5?=
 =?utf-8?B?aXdwYm1tRXNQRTJDeHNkNWNqTERpazZlL3FHNGxGU1dRMUxTTklrdktOWVFV?=
 =?utf-8?B?alJHOGJoMVo0V05kVGY5UGRqbDFWK29rSnk0bVpnclJ3WkFOdkNWR01wUnZv?=
 =?utf-8?B?WVZ2a1U5NWxXRVpxUW5jcW5ReEVpbzV1TVgza0N6MTFyMFZvM0RCQkV2RjNG?=
 =?utf-8?B?OXZMc3RVQWtWZG9ubithd1ZJVlUxMlBQNkJabVhlZzQyRG9oclphR1A2anJi?=
 =?utf-8?B?YjJlcFFtaUp5Y2tGcGhiTjdPZXpva3NxNUFZdEEwUUkxTGp5dCt0WGRxbTlh?=
 =?utf-8?B?eWVrRTNIRS9pL3FwZk9Xa0J0UEFiY0ZWOVY2bG4veDJuRkdvSTlRa3VUU2dB?=
 =?utf-8?B?akp4MzJaWU1ZRFkyK3FWU0NQWDlTSTJXZ0FCQ3FiU0lGMmREOWdTdkdFSTlP?=
 =?utf-8?B?MEJPb2JLai95OE9nYkx2aGdRSXhmWVA3bU9rWXR4OWFIT3Bzdk43UEIrTElI?=
 =?utf-8?B?OTM2MTFPcjJTWVJxUTlUeTJkaXl3Z0wvQXZLWUFGc3RGalpWU2xnb0pmdGUz?=
 =?utf-8?B?S3FOQjI4YklTY1FwT2hLUjhkVTVlN25ZelFzZ3ZQU0lNNENSbkZOcWd0LzBi?=
 =?utf-8?Q?YYJNq2OROzjZ2ofNGxqvwFM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DF616FB981271D4C94F0A60ABBE19D67@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91c0ee3e-c9bb-4873-9e9f-08dab3f8d130
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2022 06:44:06.8763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TZayKiK/urE/jq1hNciu9TV0KeVa2ss6cL71gM4AKNgCtCJLGuh1fgC+Yb7NwbLKhMXf5SmOlrRrPzhPjSs254GI/qK/rMOPFBshqoWNIl4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR03MB8277
X-Proofpoint-ORIG-GUID: CnqQJrHArjXtkQseUE9ecRNN8ScZZHDY
X-Proofpoint-GUID: CnqQJrHArjXtkQseUE9ecRNN8ScZZHDY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0
 spamscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015
 suspectscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210220041

DQpPbiAyMS4xMC4yMiAyMzowOCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KDQpIZWxsbyBT
dGVmYW5vDQoNCj4gT24gRnJpLCAyMSBPY3QgMjAyMiwgT2xla3NhbmRyIFR5c2hjaGVua28gd3Jv
dGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29A
ZXBhbS5jb20+DQo+Pg0KPj4gVXNlIHRoZSBzYW1lICJ4ZW4tZ3JhbnQtZG1hIiBkZXZpY2UgY29u
Y2VwdCBmb3IgdGhlIFBDSSBkZXZpY2VzDQo+PiBiZWhpbmQgZGV2aWNlLXRyZWUgYmFzZWQgUENJ
IEhvc3QgY29udHJvbGxlciwgYnV0IHdpdGggb25lIG1vZGlmaWNhdGlvbi4NCj4+IFVubGlrZSBm
b3IgcGxhdGZvcm0gZGV2aWNlcywgd2UgY2Fubm90IHVzZSBnZW5lcmljIElPTU1VIGJpbmRpbmdz
DQo+PiAoaW9tbXVzIHByb3BlcnR5KSwgYXMgd2UgbmVlZCB0byBzdXBwb3J0IG1vcmUgZmxleGli
bGUgY29uZmlndXJhdGlvbi4NCj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgUENJIGRldmljZXMgdW5k
ZXIgdGhlIHNpbmdsZSBQQ0kgSG9zdCBjb250cm9sbGVyDQo+PiBtYXkgaGF2ZSB0aGUgYmFja2Vu
ZHMgcnVubmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFpbnMgYW5kIHRodXMgaGF2ZQ0KPj4gZGlm
ZmVyZW50IGVuZHBvaW50cyBJRCAoYmFja2VuZCBkb21haW5zIElEKS4NCj4+DQo+PiBBZGQgYWJp
bGl0eSB0byBkZWFsIHdpdGggZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgKGlvbW11LW1hcC8N
Cj4+IGlvbW11LW1hcC1tYXNrIHByb3BlcnRpZXMpIHdoaWNoIGFsbG93cyB1cyB0byBkZXNjcmli
ZSByZWxhdGlvbnNoaXANCj4+IGJldHdlZW4gUENJIGRldmljZXMgYW5kIGJhY2tlbmQgZG9tYWlu
cyBJRCBwcm9wZXJseS4NCj4+DQo+PiBUbyBhdm9pZCBoYXZpbmcgdG8gbG9vayB1cCBmb3IgdGhl
IFBDSSBIb3N0IGJyaWRnZSB0d2ljZSBhbmQgcmVkdWNlDQo+PiB0aGUgYW1vdW50IG9mIGNoZWNr
cyBwYXNzIGFuIGV4dHJhIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAgdG8gYm90aA0KPj4geGVuX2R0
X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCgpIGFuZCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2Rldmlj
ZSgpLg0KPj4gV2hpbGUgYXQgaXQgYWxzbyBwYXNzIGRvbWlkX3QgKmJhY2tlbmRfZG9taWQgaW5z
dGVhZCBvZg0KPj4gc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YSB0byB0aGUgZm9ybWVy
Lg0KPj4NCj4+IFNvIHdpdGggY3VycmVudCBwYXRjaCB0aGUgY29kZSBleHBlY3RzIGlvbW11cyBw
cm9wZXJ0eSBmb3IgdGhlIHBsYXRmb3JtDQo+PiBkZXZpY2VzIGFuZCBpb21tdS1tYXAvaW9tbXUt
bWFwLW1hc2sgcHJvcGVydGllcyBmb3IgUENJIGRldmljZXMuDQo+Pg0KPj4gVGhlIGV4YW1wbGUg
b2YgZ2VuZXJhdGVkIGJ5IHRoZSB0b29sc3RhY2sgaW9tbXUtbWFwIHByb3BlcnR5DQo+PiBmb3Ig
dHdvIFBDSSBkZXZpY2VzIDAwMDA6MDA6MDEuMCBhbmQgMDAwMDowMDowMi4wIHdob3NlDQo+PiBi
YWNrZW5kcyBhcmUgcnVubmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFpbnMgd2l0aCBJRHMgMSBh
bmQgMg0KPj4gcmVzcGVjdGl2ZWx5Og0KPj4gaW9tbXUtbWFwID0gPDB4MDggMHhmZGU5IDB4MDEg
MHgwOCAweDEwIDB4ZmRlOSAweDAyIDB4MDg+Ow0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtz
YW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+IC0tLQ0K
Pj4gU2xpZ2h0bHkgUkZDLiBUaGlzIGlzIG5lZWRlZCB0byBzdXBwb3J0IFhlbiBncmFudCBtYXBw
aW5ncyBmb3IgdmlydGlvLXBjaSBkZXZpY2VzDQo+PiBvbiBBcm0gYXQgc29tZSBwb2ludCBpbiB0
aGUgZnV0dXJlLiBUaGUgWGVuIHRvb2xzdGFjayBzaWRlIGlzIG5vdCBjb21wbGV0ZWx5IHJlYWR5
IHlldC4NCj4+IEhlcmUsIGZvciBQQ0kgZGV2aWNlcyB3ZSB1c2UgbW9yZSBmbGV4aWJsZSB3YXkg
dG8gcGFzcyBiYWNrZW5kIGRvbWlkIHRvIHRoZSBndWVzdA0KPj4gdGhhbiBmb3IgcGxhdGZvcm0g
ZGV2aWNlcy4NCj4+DQo+PiBDaGFuZ2VzIFYxIC0+IFYyOg0KPj4gICAgIC0gdXBkYXRlIGNvbW1p
dCBkZXNjcmlwdGlvbg0KPj4gICAgIC0gcmViYXNlDQo+PiAgICAgLSByZXdvcmsgdG8gdXNlIGdl
bmVyaWMgUENJLUlPTU1VIGJpbmRpbmdzIGluc3RlYWQgb2YgZ2VuZXJpYyBJT01NVSBiaW5kaW5n
cw0KPj4NCj4+IENoYW5nZXMgVjIgLT4gVjM6DQo+PiAgICAgLSB1cGRhdGUgY29tbWl0IGRlc2Ny
aXB0aW9uLCBhZGQgYW4gZXhhbXBsZQ0KPj4gICAgIC0gZHJvcCB4ZW5fZHRfbWFwX2lkKCkgYW5k
IHNxdWFzaCB4ZW5fZHRfZ2V0X3BjaV9ob3N0X25vZGUoKSB3aXRoDQo+PiAgICAgICB4ZW5fZHRf
Z2V0X25vZGUoKQ0KPj4gICAgIC0gcGFzcyBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wIHRvIHhlbl9p
c19kdF9ncmFudF9kbWFfZGV2aWNlKCkgYW5kDQo+PiAgICAgICB4ZW5fZHRfZ3JhbnRfaW5pdF9i
YWNrZW5kX2RvbWlkKCkNCj4+ICAgICAtIHBhc3MgZG9taWRfdCAqYmFja2VuZF9kb21pZCBpbnN0
ZWFkIG9mIHN0cnVjdCB4ZW5fZ3JhbnRfZG1hX2RhdGEgKmRhdGENCj4+ICAgICAgIHRvIHhlbl9k
dF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoKQ0KPj4NCj4+IFByZXZpb3VzIGRpc2N1c3Npb24g
aXMgYXQ6DQo+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5l
bC5vcmcveGVuLWRldmVsLzIwMjIxMDA2MTc0ODA0LjIwMDMwMjktMS1vbGVrc3R5c2hAZ21haWwu
Y29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhM2NaaVJ5MFNjcTgtZGlicnh5RkdVbEFJaHdhN1V3Um1y
Q0FHLXFkdmtBRzVOSW5ZUFpfbWJMVE10c1pfRjRHb25vd2tldHRyLWRjUk8zVEFzX2duLTF4Y0xr
Nzd4ZyQgIFtsb3JlWy5da2VybmVsWy5db3JnXQ0KPj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92
My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIyMTAxNTE1MzQwOS45MTg3
NzUtMS1vbGVrc3R5c2hAZ21haWwuY29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhM2NaaVJ5MFNjcTgt
ZGlicnh5RkdVbEFJaHdhN1V3Um1yQ0FHLXFkdmtBRzVOSW5ZUFpfbWJMVE10c1pfRjRHb25vd2tl
dHRyLWRjUk8zVEFzX2duLTF4d1JqWDlHUSQgIFtsb3JlWy5da2VybmVsWy5db3JnXQ0KPj4NCj4+
IEJhc2VkIG9uOg0KPj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vZ2l0Lmtl
cm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3hlbi90aXAuZ2l0L2xvZy8/aD1mb3It
bGludXMtNi4xX187ISFHRl8yOWRiY1FJVUJQQSEzY1ppUnkwU2NxOC1kaWJyeHlGR1VsQUlod2E3
VXdSbXJDQUctcWR2a0FHNU5JbllQWl9tYkxUTXRzWl9GNEdvbm93a2V0dHItZGNSTzNUQXNfZ24t
MXpWT3k4V0tnJCAgW2dpdFsuXWtlcm5lbFsuXW9yZ10NCj4+IC0tLQ0KPj4gICBkcml2ZXJzL3hl
bi9ncmFudC1kbWEtb3BzLmMgfCA4MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0t
LS0tDQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMo
LSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJp
dmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBpbmRleCBkYWE1MjVkZjdiZGMuLjc2YjI5ZDIw
YWVlZSAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4gKysr
IGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jDQo+PiBAQCAtMTAsNiArMTAsNyBAQA0KPj4g
ICAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+DQo+PiAgICNpbmNsdWRlIDxsaW51eC9kbWEtbWFw
LW9wcy5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgvb2YuaD4NCj4+ICsjaW5jbHVkZSA8bGludXgv
cGNpLmg+DQo+PiAgICNpbmNsdWRlIDxsaW51eC9wZm4uaD4NCj4+ICAgI2luY2x1ZGUgPGxpbnV4
L3hhcnJheS5oPg0KPj4gICAjaW5jbHVkZSA8bGludXgvdmlydGlvX2FuY2hvci5oPg0KPj4gQEAg
LTI5MiwxMiArMjkzLDM3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX21hcF9vcHMgeGVuX2dy
YW50X2RtYV9vcHMgPSB7DQo+PiAgIAkuZG1hX3N1cHBvcnRlZCA9IHhlbl9ncmFudF9kbWFfc3Vw
cG9ydGVkLA0KPj4gICB9Ow0KPj4gICANCj4+IC1zdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRf
ZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiArc3RhdGljIHN0cnVjdCBkZXZpY2Vf
bm9kZSAqeGVuX2R0X2dldF9ub2RlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgew0KPj4gLQlz
dHJ1Y3QgZGV2aWNlX25vZGUgKmlvbW11X25wOw0KPj4gKwlpZiAoZGV2X2lzX3BjaShkZXYpKSB7
DQo+PiArCQlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IHRvX3BjaV9kZXYoZGV2KTsNCj4+ICsJCXN0
cnVjdCBwY2lfYnVzICpidXMgPSBwZGV2LT5idXM7DQo+PiArDQo+PiArCQkvKiBXYWxrIHVwIHRv
IHRoZSByb290IGJ1cyB0byBsb29rIGZvciBQQ0kgSG9zdCBjb250cm9sbGVyICovDQo+PiArCQl3
aGlsZSAoIXBjaV9pc19yb290X2J1cyhidXMpKQ0KPj4gKwkJCWJ1cyA9IGJ1cy0+cGFyZW50Ow0K
Pj4gKw0KPj4gKwkJcmV0dXJuIG9mX25vZGVfZ2V0KGJ1cy0+YnJpZGdlLT5wYXJlbnQtPm9mX25v
ZGUpOw0KPj4gKwl9DQo+PiArDQo+PiArCXJldHVybiBvZl9ub2RlX2dldChkZXYtPm9mX25vZGUp
Ow0KPj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2Rldmlj
ZShzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiArCQkJCQlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wKQ0K
Pj4gK3sNCj4+ICsJc3RydWN0IGRldmljZV9ub2RlICppb21tdV9ucCA9IE5VTEw7DQo+PiAgIAli
b29sIGhhc19pb21tdTsNCj4+ICAgDQo+PiAtCWlvbW11X25wID0gb2ZfcGFyc2VfcGhhbmRsZShk
ZXYtPm9mX25vZGUsICJpb21tdXMiLCAwKTsNCj4+ICsJaWYgKGRldl9pc19wY2koZGV2KSkgew0K
Pj4gKwkJc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQo+PiArCQl1MzIg
cmlkID0gUENJX0RFVklEKHBkZXYtPmJ1cy0+bnVtYmVyLCBwZGV2LT5kZXZmbik7DQo+PiArDQo+
PiArCQlpZiAob2ZfbWFwX2lkKG5wLCByaWQsICJpb21tdS1tYXAiLCAiaW9tbXUtbWFwLW1hc2si
LCAmaW9tbXVfbnAsIE5VTEwpKQ0KPj4gKwkJCXJldHVybiBmYWxzZTsNCj4+ICsJfSBlbHNlDQo+
PiArCQlpb21tdV9ucCA9IG9mX3BhcnNlX3BoYW5kbGUobnAsICJpb21tdXMiLCAwKTsNCj4+ICsN
Cj4+ICAgCWhhc19pb21tdSA9IGlvbW11X25wICYmDQo+PiAgIAkJICAgIG9mX2RldmljZV9pc19j
b21wYXRpYmxlKGlvbW11X25wLCAieGVuLGdyYW50LWRtYSIpOw0KPj4gICAJb2Zfbm9kZV9wdXQo
aW9tbXVfbnApOw0KPiBJIHRoaW5rIHdlIGNhbiByZW1vdmUgeGVuX2lzX2R0X2dyYW50X2RtYV9k
ZXZpY2UgYW5kIGp1c3QgY2FsbA0KPiB4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkIHBh
c3NpbmcgYSBOVUxMIGJhY2tlbmRfZG9taWQ/DQo+DQo+IEl0IGlzIGEgYml0IGFubm95aW5nIHRo
YXQgd2UgYXJlIGJhc2ljYWxseSBkb2luZyB0aGUgc2FtZSBkZXZpY2UgdHJlZQ0KPiBwYXJzaW5n
IHR3aWNlIGluIGEgcm93IGdpdmVuIHRoYXQgdGhlIGNhbGxlcnMgZG86DQo+DQo+IAlpZiAoeGVu
X2lzX2dyYW50X2RtYV9kZXZpY2UoZGV2KSkNCj4gCQl4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhk
ZXYpOw0KPg0KPiBNYXliZSB3ZSBjb3VsZCBtb3ZlIHRoZSBiYWNrZW5kX2RvbWlkIGFsbG9jYXRp
b24gYW5kIHNldHRpbmcgdG8NCj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCwgd2hp
Y2ggd291bGQgZW5kIHVwIGJlaW5nIGRvbmUgZnJvbQ0KPiB0aGUgeGVuX2lzX2dyYW50X2RtYV9k
ZXZpY2UoKSBjYWxsIGNoYWluLCBhbmQgb25seSBsZWF2ZSBzZXR0aW5nDQo+IGRldi0+ZG1hX29w
cyBmcm9tIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKCkuDQo+DQo+IFRoaXMgd2F5IHRoZSBwYXJz
aW5nIHdvdWxkIGJlIGRvbmUgb25seSBvbmNlPyBXaGF0IGRvIHlvdSB0aGluaz8gVGhpcw0KPiBz
dWdnZXN0aW9uIGlzIG9wdGlvbmFsLCBJIGFtIE9LIGFsc28gd2l0aCBvbmx5IHJlbW92aW5nDQo+
IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlLg0KDQpvaywgSSB3aWxsIHRoaW5rIGFib3V0IHN1
Y2ggb3B0aW1pemF0aW9uIGFuZCB3aWxsIHByb3ZpZGUgbXkgdGhvdWdodHMgDQphYm91dCBpdCBv
ciBhIHBhdGNoLiBCdXQsIEkgdGhpbmsgaXQgc2hvdWxkIGJlIGEgc2VwYXJhdGUgcGF0Y2ggKGlm
IA0KbmVlZHMgYmUpLA0KDQphcyBpbiBjdXJyZW50IHBhdGNoIHdlIGRvbid0IGNoYW5nZSBhbnl0
aGluZyBpbiB0aGF0IHJlZ2FyZCwgd2UganVzdCANCmltcGxlbWVudA0KDQoiaWYgKGRldl9pc19w
Y2koZGV2KSkgeyAuLi4gfSIgY29uZGl0aW9uIGZvciANCnhlbl9pc19kdF9ncmFudF9kbWFfZGV2
aWNlKCkgYW5kIHhlbl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoKS4NCg0KDQoNCj4NCj4N
Cj4+IEBAIC0zMDcsOSArMzMzLDE3IEBAIHN0YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFf
ZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+ICAgDQo+PiAgIGJvb2wgeGVuX2lzX2dyYW50
X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+PiArCXN0cnVjdCBkZXZp
Y2Vfbm9kZSAqbnA7DQo+PiArDQo+PiAgIAkvKiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNlcyBm
b3Igbm93ICovDQo+PiAtCWlmIChkZXYtPm9mX25vZGUpDQo+PiAtCQlyZXR1cm4geGVuX2lzX2R0
X2dyYW50X2RtYV9kZXZpY2UoZGV2KTsNCj4+ICsJbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsN
Cj4+ICsJaWYgKG5wKSB7DQo+PiArCQlib29sIHJldDsNCj4+ICsNCj4+ICsJCXJldCA9IHhlbl9p
c19kdF9ncmFudF9kbWFfZGV2aWNlKGRldiwgbnApOw0KPj4gKwkJb2Zfbm9kZV9wdXQobnApOw0K
Pj4gKwkJcmV0dXJuIHJldDsNCj4+ICsJfQ0KPj4gICANCj4+ICAgCXJldHVybiBmYWxzZTsNCj4+
ICAgfQ0KPj4gQEAgLTMyMywxNCArMzU3LDI2IEBAIGJvb2wgeGVuX3ZpcnRpb19tZW1fYWNjKHN0
cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYpDQo+PiAgIH0NCj4+ICAgDQo+PiAgIHN0YXRpYyBpbnQg
eGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiAt
CQkJCQkgICBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhKQ0KPj4gKwkJCQkJICAgc3Ry
dWN0IGRldmljZV9ub2RlICpucCwNCj4+ICsJCQkJCSAgIGRvbWlkX3QgKmJhY2tlbmRfZG9taWQp
DQo+PiAgIHsNCj4+IC0Jc3RydWN0IG9mX3BoYW5kbGVfYXJncyBpb21tdV9zcGVjOw0KPj4gKwlz
dHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzIGlvbW11X3NwZWMgPSB7IC5hcmdzX2NvdW50ID0gMSB9Ow0K
Pj4gICANCj4+IC0JaWYgKG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKGRldi0+b2Zfbm9kZSwg
ImlvbW11cyIsICIjaW9tbXUtY2VsbHMiLA0KPj4gLQkJCTAsICZpb21tdV9zcGVjKSkgew0KPj4g
LQkJZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+IC0J
CXJldHVybiAtRVNSQ0g7DQo+PiArCWlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+ICsJCXN0cnVj
dCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihkZXYpOw0KPj4gKwkJdTMyIHJpZCA9IFBDSV9E
RVZJRChwZGV2LT5idXMtPm51bWJlciwgcGRldi0+ZGV2Zm4pOw0KPj4gKw0KPj4gKwkJaWYgKG9m
X21hcF9pZChucCwgcmlkLCAiaW9tbXUtbWFwIiwgImlvbW11LW1hcC1tYXNrIiwgJmlvbW11X3Nw
ZWMubnAsDQo+PiArCQkJCWlvbW11X3NwZWMuYXJncykpIHsNCj4+ICsJCQlkZXZfZXJyKGRldiwg
IkNhbm5vdCB0cmFuc2xhdGUgSURcbiIpOw0KPj4gKwkJCXJldHVybiAtRVNSQ0g7DQo+PiArCQl9
DQo+PiArCX0gZWxzZSB7DQo+PiArCQlpZiAob2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3MobnAs
ICJpb21tdXMiLCAiI2lvbW11LWNlbGxzIiwNCj4+ICsJCQkJMCwgJmlvbW11X3NwZWMpKSB7DQo+
PiArCQkJZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+
ICsJCQlyZXR1cm4gLUVTUkNIOw0KPj4gKwkJfQ0KPj4gICAJfQ0KPj4gICANCj4+ICAgCWlmICgh
b2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUoaW9tbXVfc3BlYy5ucCwgInhlbixncmFudC1kbWEiKSB8
fA0KPj4gQEAgLTM0Niw3ICszOTIsNyBAQCBzdGF0aWMgaW50IHhlbl9kdF9ncmFudF9pbml0X2Jh
Y2tlbmRfZG9taWQoc3RydWN0IGRldmljZSAqZGV2LA0KPj4gICAJICogVGhlIGVuZHBvaW50IElE
IGhlcmUgbWVhbnMgdGhlIElEIG9mIHRoZSBkb21haW4gd2hlcmUgdGhlDQo+PiAgIAkgKiBjb3Jy
ZXNwb25kaW5nIGJhY2tlbmQgaXMgcnVubmluZw0KPj4gICAJICovDQo+PiAtCWRhdGEtPmJhY2tl
bmRfZG9taWQgPSBpb21tdV9zcGVjLmFyZ3NbMF07DQo+PiArCSpiYWNrZW5kX2RvbWlkID0gaW9t
bXVfc3BlYy5hcmdzWzBdOw0KPj4gICANCj4+ICAgCXJldHVybiAwOw0KPj4gICB9DQo+PiBAQCAt
MzU0LDYgKzQwMCw3IEBAIHN0YXRpYyBpbnQgeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21p
ZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiAgIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMo
c3RydWN0IGRldmljZSAqZGV2KQ0KPj4gICB7DQo+PiAgIAlzdHJ1Y3QgeGVuX2dyYW50X2RtYV9k
YXRhICpkYXRhOw0KPj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0KPj4gICANCj4+ICAgCWRh
dGEgPSBmaW5kX3hlbl9ncmFudF9kbWFfZGF0YShkZXYpOw0KPj4gICAJaWYgKGRhdGEpIHsNCj4+
IEBAIC0zNjUsOCArNDEyLDEzIEBAIHZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0
IGRldmljZSAqZGV2KQ0KPj4gICAJaWYgKCFkYXRhKQ0KPj4gICAJCWdvdG8gZXJyOw0KPj4gICAN
Cj4+IC0JaWYgKGRldi0+b2Zfbm9kZSkgew0KPj4gLQkJaWYgKHhlbl9kdF9ncmFudF9pbml0X2Jh
Y2tlbmRfZG9taWQoZGV2LCBkYXRhKSkNCj4+ICsJbnAgPSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsN
Cj4+ICsJaWYgKG5wKSB7DQo+PiArCQlpbnQgcmV0Ow0KPj4gKw0KPj4gKwkJcmV0ID0geGVuX2R0
X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYsIG5wLCAmZGF0YS0+YmFja2VuZF9kb21pZCk7
DQo+PiArCQlvZl9ub2RlX3B1dChucCk7DQo+PiArCQlpZiAocmV0KQ0KPj4gICAJCQlnb3RvIGVy
cjsNCj4+ICAgCX0gZWxzZSBpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9H
UkFOVCkpIHsNCj4+ICAgCQlkZXZfaW5mbyhkZXYsICJVc2luZyBkb20wIGFzIGJhY2tlbmRcbiIp
Ow0KPj4gLS0gDQo+PiAyLjI1LjENCj4+DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNo
Y2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 07:19:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 07:19:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428126.677964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om8n8-0006vM-Ro; Sat, 22 Oct 2022 07:19:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428126.677964; Sat, 22 Oct 2022 07:19:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om8n8-0006vF-P3; Sat, 22 Oct 2022 07:19:34 +0000
Received: by outflank-mailman (input) for mailman id 428126;
 Sat, 22 Oct 2022 07:19:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+E3x=2X=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1om8n7-0006v9-Fw
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 07:19:33 +0000
Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com
 [2a00:1450:4864:20::436])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dfc59a13-51d9-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 09:19:32 +0200 (CEST)
Received: by mail-wr1-x436.google.com with SMTP id w18so8114583wro.7
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 00:19:32 -0700 (PDT)
Received: from [192.168.1.93] (adsl-70.109.242.225.tellas.gr. [109.242.225.70])
 by smtp.gmail.com with ESMTPSA id
 ba3-20020a0560001c0300b002365254ea42sm3813037wrb.1.2022.10.22.00.19.30
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 22 Oct 2022 00:19:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfc59a13-51d9-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=f1dZlb9EtBi62yLpMWc4suMSx0l7x1OxvekcJ6t2eXw=;
        b=WxclziSTWUwmBpLQ1rlfrbFPKFw1cXITk2bR4GNyyqbY3rsO5qAb3RRLwLmLuEUCzA
         An9eqkpVmU9vjVF/8TH3FJYg9dKr73G2jTY3oxT3I9BxjFh+wQ8dcbTP15i+XFlwaJG+
         fF08nn+HfdUMxMZfSyxtBVl1uetK4/2C5r1aELHeo+Xg+o48i+hk7yaVzu0t9MnU5ksg
         P0ShFHEjNZLdcmgWxbw8Cl0p0nHnznB1msigLyYz6poezsSGsE4CpgAfHCSF3/8X3m45
         c5p86Sd9OuR+tWe2VVaJTC3gew84A0O160jUdH5AgIhkmJPibGzR8rKlxDDvwasGHut7
         YqDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=f1dZlb9EtBi62yLpMWc4suMSx0l7x1OxvekcJ6t2eXw=;
        b=L+H2/9qNEwzbF0iyPNhcN8h4UeEuVqPoB4cpAWW3FvewAX4I9gYpESdXuTlHJAxuD7
         8Fbv6PjBmHLrKcSo5XjkwaQlt3skobbRKlTBMFgMsQxZjCbcZE/LMobXarumLciDSg58
         0IskoaG9u/0VYjSh1NpNBc4ucoVt40rKfGfx9qzAnDVpMraCEiYY2YQwYg+TICKIdDu5
         ynzICJ/qjX86Al9WT9yEUpIc1S/wkiIKkAbWifOjUIHF9SAbqIfqfKgOXYocSgNLgB7s
         JX+knGsj4acRpUZKuR+kkJn+7Zs9UrOJP9YkwrB8vrD82/cIf+v0ZiFv8JtCd9YLJ1sg
         yT5Q==
X-Gm-Message-State: ACrzQf2fIU4mzNO3vwla2zR0si8JKRreE2h3RCffHJMCOiTEBcbhCITk
	dzp39e0mopwzi/sG/JwZoIk=
X-Google-Smtp-Source: AMsMyM7SNqesrZYQEbsHqUjbESKxUC3p7D968rbkW6MBa9mgB0eSKqJy7Z6fQz/5sZxkyWPL4S4rTg==
X-Received: by 2002:adf:e785:0:b0:236:5998:67a0 with SMTP id n5-20020adfe785000000b00236599867a0mr2795685wrm.414.1666423171823;
        Sat, 22 Oct 2022 00:19:31 -0700 (PDT)
Message-ID: <c587e513-8862-ca44-3c1d-a54bb01e0c3b@gmail.com>
Date: Sat, 22 Oct 2022 10:19:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v1 11/12] Arm: GICv3: Define macros to read/write 64
 bit
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-12-ayankuma@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221021153128.44226-12-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 18:31, Ayan Kumar Halder wrote:
Hi Ayan

> Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs.
> This in turn calls readl_relaxed()/writel_relaxed() twice for the lower
> and upper 32 bits.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/arm32/io.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h
> index 73a879e9fb..6a5f563fbc 100644
> --- a/xen/arch/arm/include/asm/arm32/io.h
> +++ b/xen/arch/arm/include/asm/arm32/io.h
> @@ -80,10 +80,14 @@ static inline u32 __raw_readl(const volatile void __iomem *addr)
>                                           __raw_readw(c)); __r; })
>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \
>                                           __raw_readl(c)); __r; })
> +#define readq_relaxed(c) ({ u64 __r = (le64_to_cpu(readl_relaxed(c+4)) << 32) | \
> +                                        readl_relaxed(c); __r; })

Maybe you wanted to write sth like

(((u64)readl_relaxed((c) + 4) << 32) | readl_relaxed(c))

readl_relaxed returns a u32 value so no byteorder conversions are needed 
at this stage. Also, you need to add parentheses around macro parameter 
c because an operator performs on it.

>   
>   #define writeb_relaxed(v,c)     __raw_writeb(v,c)
>   #define writew_relaxed(v,c)     __raw_writew((__force u16) cpu_to_le16(v),c)
>   #define writel_relaxed(v,c)     __raw_writel((__force u32) cpu_to_le32(v),c)
> +#define writeq_relaxed(v,c)     writel_relaxed(((uint64_t)v&0xffffffff), c); \
> +                                    writel_relaxed((((uint64_t)v)>>32), (c+4));
>   
>   #define readb(c)                ({ u8  __v = readb_relaxed(c); __iormb(); __v; })
>   #define readw(c)                ({ u16 __v = readw_relaxed(c); __iormb(); __v; })

And

writel_relaxed((u32)v, c); writel_relaxed((u32)((v) >> 32), (c) + 4);

v is already u64 and writel_relaxed() expects a u32. Here as well, you 
need to add parentheses around macro parameter c because an operator 
performs on it.

I am wondering if the parts of the register need to be accessed in a 
specific order.

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 08:00:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 08:00:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428139.677987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om9QN-000427-Ey; Sat, 22 Oct 2022 08:00:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428139.677987; Sat, 22 Oct 2022 08:00:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1om9QN-00041X-8f; Sat, 22 Oct 2022 08:00:07 +0000
Received: by outflank-mailman (input) for mailman id 428139;
 Sat, 22 Oct 2022 08:00:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W6F3=2X=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1om9QL-0003f1-Fg
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 08:00:05 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88fa207d-51df-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 10:00:04 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 35238B82E2C;
 Sat, 22 Oct 2022 08:00:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC2C4C4347C;
 Sat, 22 Oct 2022 08:00:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88fa207d-51df-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666425601;
	bh=WOtLqPtfTzhG6xYKuXLzf9SXFlrNx350kTurMW1iEWw=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=0LCuBtS9J8zCXCeiOIcEq/bt0xKzDvb9q5k5RZDel+NFT7DxWETPCOGBFEeWGNQbB
	 BcSD/RJmPEGyLRmCHk2tKei1unDmZGIXa1q1N777LKlHX1rLy8eb9Yp4LyrYaR5d8K
	 R6ZC++I1FW9vPHa1RNkkc1LBMCSVprNghSbFulcY=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.19 553/717] x86/entry: Work around Clang __bdos() bug
Date: Sat, 22 Oct 2022 09:27:12 +0200
Message-Id: <20221022072522.841821313@linuxfoundation.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221022072415.034382448@linuxfoundation.org>
References: <20221022072415.034382448@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 0ed2e487a693..9b1a58dda935 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -765,6 +765,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -774,7 +775,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Sat Oct 22 09:17:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 09:17:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428152.678010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omAdV-0003Nh-Ae; Sat, 22 Oct 2022 09:17:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428152.678010; Sat, 22 Oct 2022 09:17:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omAdV-0003Na-7p; Sat, 22 Oct 2022 09:17:45 +0000
Received: by outflank-mailman (input) for mailman id 428152;
 Sat, 22 Oct 2022 09:17:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omAdU-0003NQ-7g; Sat, 22 Oct 2022 09:17:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omAdU-0007q0-6b; Sat, 22 Oct 2022 09:17:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omAdT-0004nZ-R7; Sat, 22 Oct 2022 09:17:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omAdT-0001LS-Qh; Sat, 22 Oct 2022 09:17:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9iukgo+8gComI/boqcNuNNhkl4weOA5pnA2945l3Dqc=; b=w3/bfScCvL2NBnN13IiM3LQnfi
	icUdCjPbokvHnBuNKoVRYDgAPNm/3lZGTBVr3YDk1efaoUo63SQilCS9Lx2O77klD6SF6XCapAVt0
	cGAnlKSJ8Mhlill3R8FKBARg3bk5pUoD1SQ6Uj5TWKmSOWt+I3JzVPoYgHZX5+HWmP/c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174243-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174243: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=913a308df934952bcbedacb6baa8bd023a25b978
X-Osstest-Versions-That:
    ovmf=c6720db5ddffec747bb0b2830e528511b1a4bfb2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 09:17:43 +0000

flight 174243 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174243/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 913a308df934952bcbedacb6baa8bd023a25b978
baseline version:
 ovmf                 c6720db5ddffec747bb0b2830e528511b1a4bfb2

Last test of basis   174116  2022-10-20 03:43:46 Z    2 days
Testing same since   174243  2022-10-22 07:10:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bob Feng <bob.c.feng@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c6720db5dd..913a308df9  913a308df934952bcbedacb6baa8bd023a25b978 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 10:01:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 10:01:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428163.678033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBJF-0000FQ-O3; Sat, 22 Oct 2022 10:00:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428163.678033; Sat, 22 Oct 2022 10:00:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBJF-0000FJ-LN; Sat, 22 Oct 2022 10:00:53 +0000
Received: by outflank-mailman (input) for mailman id 428163;
 Sat, 22 Oct 2022 10:00:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omBJE-0000FD-FC
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 10:00:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBJD-00009x-Sq; Sat, 22 Oct 2022 10:00:51 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBJD-0005Zt-LI; Sat, 22 Oct 2022 10:00:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=fGc0cTgD0Ah+JdkVXzFVtAnxHUEGwmB4FgoQfhcSP20=; b=C+jk5WIBdheHSpZFbGLb9Ddzgb
	vfbMKtZ1K68tF6mF7r5Nrs0UYehbV51bL6rvJrhg1g5AtAsN10cD3uWbQYYMumZSqu8g8zwLoIWCu
	DkvK/3PRdJrqCLq6RAb1eYcGFK2C/k0gbK2cynbxeYFxS24v55BFhPtMzZEDd4wMalXM=;
Message-ID: <eaf6c1e1-a765-be2f-24d6-0f63050c17df@xen.org>
Date: Sat, 22 Oct 2022 11:00:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v1 01/12] Arm: GICv3: Sysreg emulation is applicable
 for Aarch64 only
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-2-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221021153128.44226-2-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
> only. This is when MSR, MRS, System instruction execution in AArch64 state
> is trapped, that is not reported using EC 0b000000, 0b000001 or 0b000111.

I don't understand the second sentence. However, what matter here is the 
fact the system registers are 64-bit only.

The change itself, looks ok to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 10:13:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 10:13:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428169.678046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBVR-0001qm-Td; Sat, 22 Oct 2022 10:13:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428169.678046; Sat, 22 Oct 2022 10:13:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBVR-0001qf-R1; Sat, 22 Oct 2022 10:13:29 +0000
Received: by outflank-mailman (input) for mailman id 428169;
 Sat, 22 Oct 2022 10:13:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omBVQ-0001qZ-7H
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 10:13:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBVP-0000Nx-SC; Sat, 22 Oct 2022 10:13:27 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBVP-00069L-Jg; Sat, 22 Oct 2022 10:13:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=upKHsJJcUik/JV2PMLlgWajEp2ZMzINyoWgNkr25668=; b=Yy1lmDCzAQOGtohL8ArhKXRdH2
	6IKx1DU0cd1V8lmc3vIZlFBdPPhHt37BF2KqPdQ9VfAApiDX+PmL/waqyd6v5re6YMYDEkKVrXwTl
	HMuCNVSkydOA3GVW0bVMHV2lgxmd3QleO1LqVW0RFrM0L/j2W8WJbOJ/m99jXcvkiAuM=;
Message-ID: <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
Date: Sat, 22 Oct 2022 11:13:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-4-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for
 AArch32
In-Reply-To: <20221021153128.44226-4-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

Title: The code you are modifying below is not GICv3 specific. I would 
suggest the following title:

xen/arm: vreg: Support vreg_reg64_* helpers on Aarch32

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> In some situations (eg GICR_TYPER), the hypervior may need to emulate
> 64bit registers in aarch32 mode. In such situations, the hypervisor may
> need to read/modify the lower or upper 32 bits of the 64 bit register.
> 
> In aarch32, 64 bit is represented by unsigned long long. Thus, we need
> to change the prototype accordingly.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/vreg.h | 23 ++++++++---------------
>   1 file changed, 8 insertions(+), 15 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h
> index f26a70d024..ac6e702c5c 100644
> --- a/xen/arch/arm/include/asm/vreg.h
> +++ b/xen/arch/arm/include/asm/vreg.h
> @@ -95,7 +95,7 @@ static inline bool vreg_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr
>    * Note that the alignment fault will always be taken in the guest
>    * (see B3.12.7 DDI0406.b).
>    */
> -static inline register_t vreg_reg_extract(unsigned long reg,
> +static inline register_t vreg_reg_extract(unsigned long long reg,
>                                             unsigned int offset,
>                                             enum dabt_size size)
>   {
> @@ -105,7 +105,7 @@ static inline register_t vreg_reg_extract(unsigned long reg,
>       return reg;
>   }
>   
> -static inline void vreg_reg_update(unsigned long *reg, register_t val,
> +static inline void vreg_reg_update(unsigned long long *reg, register_t val,
>                                      unsigned int offset,
>                                      enum dabt_size size)
>   {
> @@ -116,7 +116,7 @@ static inline void vreg_reg_update(unsigned long *reg, register_t val,
>       *reg |= ((unsigned long)val & mask) << shift;
>   }
>   
> -static inline void vreg_reg_setbits(unsigned long *reg, register_t bits,
> +static inline void vreg_reg_setbits(unsigned long long *reg, register_t bits,
>                                       unsigned int offset,
>                                       enum dabt_size size)
>   {
> @@ -126,7 +126,7 @@ static inline void vreg_reg_setbits(unsigned long *reg, register_t bits,
>       *reg |= ((unsigned long)bits & mask) << shift;
>   }
>   
> -static inline void vreg_reg_clearbits(unsigned long *reg, register_t bits,
> +static inline void vreg_reg_clearbits(unsigned long long *reg, register_t bits,
>                                         unsigned int offset,
>                                         enum dabt_size size)
>   {
> @@ -149,7 +149,7 @@ static inline void vreg_reg##sz##_update(uint##sz##_t *reg,             \
>                                            register_t val,                \
>                                            const mmio_info_t *info)       \
>   {                                                                       \
> -    unsigned long tmp = *reg;                                           \
> +    unsigned long long tmp = *reg;                                      \
>                                                                           \
>       vreg_reg_update(&tmp, val, info->gpa & (offmask),                   \
>                       info->dabt.size);                                   \
> @@ -161,7 +161,7 @@ static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
>                                             register_t bits,              \
>                                             const mmio_info_t *info)      \
>   {                                                                       \
> -    unsigned long tmp = *reg;                                           \
> +    unsigned long long tmp = *reg;                                      \
>                                                                           \
>       vreg_reg_setbits(&tmp, bits, info->gpa & (offmask),                 \
>                        info->dabt.size);                                  \
> @@ -173,7 +173,7 @@ static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>                                               register_t bits,            \
>                                               const mmio_info_t *info)    \
>   {                                                                       \
> -    unsigned long tmp = *reg;                                           \
> +    unsigned long long tmp = *reg;                                      \
>                                                                           \
>       vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask),               \
>                          info->dabt.size);                                \
> @@ -181,15 +181,8 @@ static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>       *reg = tmp;                                                         \
>   }
>   
> -/*
> - * 64 bits registers are only supported on platform with 64-bit long.
> - * This is also allow us to optimize the 32 bit case by using
> - * unsigned long rather than uint64_t
> - */

The comment above explain why we never use uint64_t in the helpers 
above. IIRC, the compiler would end up to use 2 registers on AArch32 
even for the vreg_reg32_* helpers. I wanted to avoid that and would like 
like to today. Can you check the code generated?

For other options, I would consider to either:
   1) Fold vreg_reg_* in the macros.
   2) Write a separate vreg_reg64_*

My preference would be 1).

If we are planning to keep the code with "unsigned long long", then I 
think this should be addressed in the commit message.

> -#if BITS_PER_LONG == 64
> -VREG_REG_HELPERS(64, 0x7);
> -#endif
>   VREG_REG_HELPERS(32, 0x3);
> +VREG_REG_HELPERS(64, 0x7);

Regardless what I wrote above, the code movement seems to be unwarranted.
>   
>   #undef VREG_REG_HELPERS
>   

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 10:20:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 10:20:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428175.678062 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBbl-0002bk-Ma; Sat, 22 Oct 2022 10:20:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428175.678062; Sat, 22 Oct 2022 10:20:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBbl-0002bB-HR; Sat, 22 Oct 2022 10:20:01 +0000
Received: by outflank-mailman (input) for mailman id 428175;
 Sat, 22 Oct 2022 10:19:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omBbj-0002YP-Bb
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 10:19:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBbi-0000UN-Bb; Sat, 22 Oct 2022 10:19:58 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBbi-0006H3-4R; Sat, 22 Oct 2022 10:19:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=eXk3fb+T0fBBruJFK/IsBZxIl2QBKqAda3zBSlJJQms=; b=HXqCu/PG3LEJTFjWHUZPSM3U/I
	t5r8Qjbt/mOV9L5WDuDe0hdbXmbMllUqSJrDWjkdd9nzi4E5z07dwrZSjvC2tm0V0nPEP9ooUg0O7
	oJOG3+t9KTH5a5DJBeRh3R1vOk5OsRodlpoO2VxB3IUVCMbjHcikUjNY/rMkXqgnLOO4=;
Message-ID: <03b0e8c8-f50a-f73c-e8a7-72883b23886e@xen.org>
Date: Sat, 22 Oct 2022 11:19:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Xenia Ragiadakou <burzalodowa@gmail.com>,
 Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-5-ayankuma@amd.com>
 <24feccd2-c90e-2abd-ebc3-4219bd15e380@gmail.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH v1 04/12] Arm: GICv3: Emulate GICR_TYPER on AArch32
In-Reply-To: <24feccd2-c90e-2abd-ebc3-4219bd15e380@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 21/10/2022 23:07, Xenia Ragiadakou wrote:
> On 10/21/22 18:31, Ayan Kumar Halder wrote:
> Hi Ayan
> 
>> Refer Arm IHI 0069H ID020922,
>> The upper 32 bits of GICR_TYPER represent the affinity
>> whereas the lower 32 bits represent the other bits (eg processor
>> number, etc).
>> MPIDR_AFFINITY_LEVEL() returns a 32 bit number on aarch32. Thus, this
>> is appended to return GICR_TYPER register.

The last sentence doesn't seem to match your modification below.

>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> ---
>>   xen/arch/arm/vgic-v3.c | 14 +++++++++-----
>>   1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>> index c31140eb20..d86b41a39f 100644
>> --- a/xen/arch/arm/vgic-v3.c
>> +++ b/xen/arch/arm/vgic-v3.c
>> @@ -190,14 +190,18 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct 
>> vcpu *v, mmio_info_t *info,
>>       case VREG64(GICR_TYPER):
>>       {
>> -        uint64_t typer, aff;
>> +        uint64_t typer;
>> +        uint32_t aff;
>>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>> -        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 |
>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 |
>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 |
>> -               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32);
>> +        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 24 |
>> +               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 16 |
>> +               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 8 |
>> +               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0));
>>           typer = aff;
>> +
>> +        typer = typer << 32;

I find the "typer = aff; typer = typer << 32" quite confusing to read. 
In fact, my first instinct would be to combine the two but this would do 
the wrong thing. So I would prefer if we use a different approach (see 
below).

>> +
>>           /* We use the VCPU ID as the redistributor ID in bits[23:8] */
>>           typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT;
> 
> I don't see an issue I just want to propose alternatives that I think 
> would reduce the changes, hopefully without breaking it.
> So, other ways would be either to assign v->arch.vmpidr to a new 
> variable uint64_t vmpidr and operate on this (without changing the 
> shifts), or to leave the type of aff uint64_t, adjust the shifts and do 
> typer = aff << 32.

How about making MPIDR_AFFINITY_LEVEL returning a 64-bit value? The 
other option would be to use what Xenia's last option. I.e:

" to level the type of aff uint64_t, adjust the shifts and do typer = 
aff << 32". This would need a suitable comment though explain why the 
shift can't be fold.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 10:32:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 10:32:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428180.678072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBnO-0004tN-N8; Sat, 22 Oct 2022 10:32:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428180.678072; Sat, 22 Oct 2022 10:32:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBnO-0004tG-JR; Sat, 22 Oct 2022 10:32:02 +0000
Received: by outflank-mailman (input) for mailman id 428180;
 Sat, 22 Oct 2022 10:32:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omBnN-0004sK-HX; Sat, 22 Oct 2022 10:32:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omBnN-0000hW-Eh; Sat, 22 Oct 2022 10:32:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omBnM-0006Ql-VO; Sat, 22 Oct 2022 10:32:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omBnM-0005Hg-Ut; Sat, 22 Oct 2022 10:32:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CYyYyzE9z7s+susf2EJTTw4UcxjPwUUxyqT3oK+0ztM=; b=Ojss5/bu36bSsPtoYjJMnIpygl
	wyic/7f4S0wNMUlO5n/XwKT6IIn9CDQdXK7APZjtABpvKfl+gop59Tbda2SfbbXAXtzfRqpjH6qh0
	OQAVg8+goGqbC0+lfLQAKigjGuuNQKssJPjNX93DORDw0On+z3KqxeeNXKmeZuf0ECpE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174210-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174210: tolerable trouble: fail/pass/starved - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-unstable:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
X-Osstest-Versions-That:
    xen=0c06760be3dc3f286015e18c4b1d1694e55da026
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 10:32:00 +0000

flight 174210 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174210/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174165
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174165
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174165
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174165
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174165
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174165
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174165
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174165
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174165
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340
baseline version:
 xen                  0c06760be3dc3f286015e18c4b1d1694e55da026

Last test of basis   174165  2022-10-21 02:14:06 Z    1 days
Testing same since   174210  2022-10-21 16:38:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Lindig <christian.lindig@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  Edwin Török <edvin.torok@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@amd.com>
  Xenia Ragiadakou <burzalodowa@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   0c06760be3..73c62927f6  73c62927f64ecb48f27d06176befdf76b879f340 -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 10:37:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 10:37:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428194.678106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBsk-0005tR-P7; Sat, 22 Oct 2022 10:37:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428194.678106; Sat, 22 Oct 2022 10:37:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omBsk-0005tK-M3; Sat, 22 Oct 2022 10:37:34 +0000
Received: by outflank-mailman (input) for mailman id 428194;
 Sat, 22 Oct 2022 10:37:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omBsj-0005tE-Ik
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 10:37:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBsj-0000ni-6Z; Sat, 22 Oct 2022 10:37:33 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omBsj-00074K-1F; Sat, 22 Oct 2022 10:37:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=2CduYiqWsULcvnkxSKtwhciMIeBevBYKrPQA75rigkE=; b=rRkciWRoR+G6uGMhmJMSMVimEt
	PePxpoqTgEcN09LupVS00wRZYqfINGbmyZlNyjl50SWuzrjnghuj9Edrn7DnSM51qzZYGXS4pdgfK
	DMINF3G3TLZAaaHr3gM10aOz7vIpJDdGcI/thgkHFvv9PMuDoi1gGLupXJMjP/y9EKcE=;
Message-ID: <d784a0e7-c9c4-a87d-2aee-ac6554c61b26@xen.org>
Date: Sat, 22 Oct 2022 11:37:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-6-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH v1 05/12] Arm: GICv3: Emulate GICR_PENDBASER and
 GICR_PROPBASER on AArch32
In-Reply-To: <20221021153128.44226-6-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

Title: To me, it reads as if you provide a brand new code for emulating 
the registers. However, below, you are only fixing the code. So how about:

"xen/arm: gicv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host"

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> 'unsigned long long' is defined as 64 bit across both aarch32 and aarch64.
> So, use 'ULL' for 64 bit word instead of UL which is 32 bits for aarch32.
> GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/gic_v3_defs.h | 16 ++++++++--------
>   xen/arch/arm/vgic-v3.c                 |  6 ++++--
>   2 files changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
> index 728e28d5e5..48a1bc401e 100644
> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
> @@ -134,15 +134,15 @@
>   
>   #define GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT         56
>   #define GICR_PROPBASER_OUTER_CACHEABILITY_MASK               \
> -        (7UL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT)
> +        (7ULL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT)
>   #define GICR_PROPBASER_SHAREABILITY_SHIFT               10
>   #define GICR_PROPBASER_SHAREABILITY_MASK                     \
> -        (3UL << GICR_PROPBASER_SHAREABILITY_SHIFT)
> +        (3ULL << GICR_PROPBASER_SHAREABILITY_SHIFT)
>   #define GICR_PROPBASER_INNER_CACHEABILITY_SHIFT         7
>   #define GICR_PROPBASER_INNER_CACHEABILITY_MASK               \
> -        (7UL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT)
> +        (7ULL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT)
>   #define GICR_PROPBASER_RES0_MASK                             \
> -        (GENMASK(63, 59) | GENMASK(55, 52) | GENMASK(6, 5))
> +        (GENMASK_ULL(63, 59) | GENMASK_ULL(55, 52) | GENMASK_ULL(6, 5))
>   
>   #define GICR_PENDBASER_SHAREABILITY_SHIFT               10
>   #define GICR_PENDBASER_INNER_CACHEABILITY_SHIFT         7
> @@ -152,11 +152,11 @@
>   #define GICR_PENDBASER_INNER_CACHEABILITY_MASK               \
>   	(7UL << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT)
>   #define GICR_PENDBASER_OUTER_CACHEABILITY_MASK               \
> -        (7UL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT)
> -#define GICR_PENDBASER_PTZ                              BIT(62, UL)
> +        (7ULL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT)
> +#define GICR_PENDBASER_PTZ                              BIT(62, ULL)
>   #define GICR_PENDBASER_RES0_MASK                             \
> -        (BIT(63, UL) | GENMASK(61, 59) | GENMASK(55, 52) |  \
> -         GENMASK(15, 12) | GENMASK(6, 0))
> +        (BIT(63, ULL) | GENMASK_ULL(61, 59) | GENMASK_ULL(55, 52) |  \
> +         GENMASK_ULL(15, 12) | GENMASK_ULL(6, 0))rer
>   
>   #define DEFAULT_PMR_VALUE            0xff
>   
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index d86b41a39f..9f31360f56 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -254,14 +254,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>       case VREG64(GICR_PENDBASER):
>       {
>           unsigned long flags;
> +        uint64_t value;
>   
>           if ( !v->domain->arch.vgic.has_its )
>               goto read_as_zero_64;
>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>   
>           spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> +        value = v->arch.vgic.rdist_pendbase;
> +        value &= ~GICR_PENDBASER_PTZ;    /* WO, reads as 0 */
> +        *r = vreg_reg64_extract(value, info);

The commit message suggests the code would only be replacing "UL" with 
"ULL". But here, you are doing more than that. The code is re-order so 
PTZ is cleared before extracting the value.

I agree the existing code was wrong if the guest was using 32-bit access 
and your new approach is correct. Can you split the change in a separate 
patch? (Please add a Fixes tag as well).

>           spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>           return 1;
>       }

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 10:46:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 10:46:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428200.678120 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omC1W-0007OZ-NT; Sat, 22 Oct 2022 10:46:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428200.678120; Sat, 22 Oct 2022 10:46:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omC1W-0007OS-Ko; Sat, 22 Oct 2022 10:46:38 +0000
Received: by outflank-mailman (input) for mailman id 428200;
 Sat, 22 Oct 2022 10:46:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omC1V-0007OM-2s
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 10:46:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omC1U-0000vu-BY; Sat, 22 Oct 2022 10:46:36 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omC1U-0007XO-5g; Sat, 22 Oct 2022 10:46:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=K5TKwJV1rjxZBEEN1koO3DY4ZNll8HMN3a0w67D4g7A=; b=ZS2ArrvcOTk1sNd7XApAG/aAg+
	fVy5XYcJBNoUMdUvvqscdSSE7lNKNwtOeNCfQ7KF+F63E5yn4qEYC/qKUEARHM/BC2Brfr4dB+BMB
	tE6KbDQ63mWGMF5HPqrJj4hwSSY7jNwZzSXvFDaBVx2tsDJ0wFMOkPRfR4Y2rTgQrWgI=;
Message-ID: <1de3eac1-0ca5-5ff8-58e4-6e1cadd58ca0@xen.org>
Date: Sat, 22 Oct 2022 11:46:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v1 06/12] Arm: GICv3: Emulate of ICC_SGI1R on AArch32
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-7-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221021153128.44226-7-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Title: Similar to the previous patch, you are fixing the existing emulation.

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on
> Aarch32 systems. Thus, the prototype needs to change to reflect this.
At first, it wasn't obvious why changing the prototype is enough. So it 
would be good to explain it in the commit message.

> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/vgic-v3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 9f31360f56..48e8ef95d2 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -1482,7 +1482,7 @@ write_reserved:
>       return 1;
>   }
>   
> -static bool vgic_v3_to_sgi(struct vcpu *v, register_t sgir)
> +static bool vgic_v3_to_sgi(struct vcpu *v, uint64_t sgir)
>   {
>       int virq;
>       int irqmode;

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:04:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:04:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428205.678131 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCIJ-0001Ot-56; Sat, 22 Oct 2022 11:03:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428205.678131; Sat, 22 Oct 2022 11:03:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCIJ-0001Om-1j; Sat, 22 Oct 2022 11:03:59 +0000
Received: by outflank-mailman (input) for mailman id 428205;
 Sat, 22 Oct 2022 11:03:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omCIG-0001Og-VM
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 11:03:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCIG-0001F9-G2; Sat, 22 Oct 2022 11:03:56 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCIF-0008Hk-V1; Sat, 22 Oct 2022 11:03:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=i6yQIH5Mj8Y/imZqcOIddzumszrDzdTAVM0D01X/jc8=; b=WAOC0i/oHeg5O/Kme97boyn0PF
	xT+XLMxkjFSqg8KEut90LP+B0VfHa+p8c8GkRCfVcSZBorlUFLsrwzTAPfOFwUdsEifMnpWpxK4CE
	pOvhOr5qgo5gPb0pyf5gm8zxbktYSZ2gJNHm/ns4sUFo8NSi030gGLObSzuBw0Q+r34w=;
Message-ID: <c1290406-9ec4-97f7-efad-8279dec39123@xen.org>
Date: Sat, 22 Oct 2022 12:03:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-8-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH v1 07/12] Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
In-Reply-To: <20221021153128.44226-8-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

Title: Xen doesn't emulate ICH_LR* (we don't expose them to the guest). 
Instead Xen will use the registers and your patch provides wrappers to 
use access the registers on 32-bit host.

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
> index 6841d5de43..f3b4dfbca8 100644
> --- a/xen/arch/arm/include/asm/arm32/sysregs.h
> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h
> @@ -62,9 +62,61 @@
>   #define READ_SYSREG(R...)       READ_SYSREG32(R)
>   #define WRITE_SYSREG(V, R...)   WRITE_SYSREG32(V, R)
>   
> +#define ICH_LR_REG(INDEX)        ICH_LR ## INDEX ## _EL2
> +#define ICH_LRC_REG(INDEX)       ICH_LRC ## INDEX ## _EL2
> +
> +#define READ_SYSREG_LR(INDEX)    ((((uint64_t) \
> +                                 (READ_SYSREG(ICH_LRC_REG(INDEX)))) << 32) | \
> +                                 (READ_SYSREG(ICH_LR_REG(INDEX))))

This is a bit dense to read. Also, we should use READ_CP64() when 
dealing with arm32 only code. So how about (formatting will need to be 
done):

#define READ_SYSREG_LR(INDEX) ({   \
     uint32_t lrc_ = READ_CP64(ICH_LRC_REG(INDEX)); \
     uint32_t lr_ = READ_CP64(ICH_LR_REG(INDEX));   \
                                                    \
     (uint64_t)(lrc_ << 32) | lr_;
})

> +
> +#define WRITE_SYSREG_LR(INDEX, V) WRITE_SYSREG \
> +                                  (V&0xFFFFFFFF, ICH_LR_REG(INDEX)); \
> +                                  WRITE_SYSREG(V>>32, ICH_LRC_REG(INDEX));
This code is fragile. If V is a function call, then you will call it 
twice. You want something like:

do {
   uint64_t v_ = (V);

   WRITE_SYSREG(v_ & 0xFFFFFFFF, ICH_LR_REG(INDEX));
   WRITE_SYSREG(v_ >> 32, ICH_LRC_REG(INDEX));
} while(0);

And maybe replacing the opencoding Fs with GENMASK.

> +
>   /* MVFR2 is not defined on ARMv7 */
>   #define MVFR2_MAYBE_UNDEFINED
>   
> +#define ___CP32(a,b,c,d,e)   a,b,c,d,e

I am not entirely sure why you need to define __CP32() here. However, 
co-processors registers should be defined in asm/cpregs.h rather than 
arm32/sysregs.h.

> +#define __LR0_EL2(x)              ___CP32(p15,4,c12,c12,x)
> +#define __LR8_EL2(x)              ___CP32(p15,4,c12,c13,x)
> +
> +#define __LRC0_EL2(x)             ___CP32(p15,4,c12,c14,x)
> +#define __LRC8_EL2(x)             ___CP32(p15,4,c12,c15,x)
> +
> +#define ICH_LR0_EL2               __LR0_EL2(0)
> +#define ICH_LR1_EL2               __LR0_EL2(1)
> +#define ICH_LR2_EL2               __LR0_EL2(2)
> +#define ICH_LR3_EL2               __LR0_EL2(3)
> +#define ICH_LR4_EL2               __LR0_EL2(4)
> +#define ICH_LR5_EL2               __LR0_EL2(5)
> +#define ICH_LR6_EL2               __LR0_EL2(6)
> +#define ICH_LR7_EL2               __LR0_EL2(7)
> +#define ICH_LR8_EL2               __LR8_EL2(0)
> +#define ICH_LR9_EL2               __LR8_EL2(1)
> +#define ICH_LR10_EL2              __LR8_EL2(2)
> +#define ICH_LR11_EL2              __LR8_EL2(3)
> +#define ICH_LR12_EL2              __LR8_EL2(4)
> +#define ICH_LR13_EL2              __LR8_EL2(5)
> +#define ICH_LR14_EL2              __LR8_EL2(6)
> +#define ICH_LR15_EL2              __LR8_EL2(7)
> +
> +#define ICH_LRC0_EL2               __LRC0_EL2(0)
> +#define ICH_LRC1_EL2               __LRC0_EL2(1)
> +#define ICH_LRC2_EL2               __LRC0_EL2(2)
> +#define ICH_LRC3_EL2               __LRC0_EL2(3)
> +#define ICH_LRC4_EL2               __LRC0_EL2(4)
> +#define ICH_LRC5_EL2               __LRC0_EL2(5)
> +#define ICH_LRC6_EL2               __LRC0_EL2(6)
> +#define ICH_LRC7_EL2               __LRC0_EL2(7)
> +#define ICH_LRC8_EL2               __LRC8_EL2(0)
> +#define ICH_LRC9_EL2               __LRC8_EL2(1)
> +#define ICH_LRC10_EL2              __LRC8_EL2(2)
> +#define ICH_LRC11_EL2              __LRC8_EL2(3)
> +#define ICH_LRC12_EL2              __LRC8_EL2(4)
> +#define ICH_LRC13_EL2              __LRC8_EL2(5)
> +#define ICH_LRC14_EL2              __LRC8_EL2(6)
> +#define ICH_LRC15_EL2              __LRC8_EL2(7)
> +
>   #endif /* __ASSEMBLY__ */
>   
>   #endif /* __ASM_ARM_ARM32_SYSREGS_H */
> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h
> index 54670084c3..d45fe815f9 100644
> --- a/xen/arch/arm/include/asm/arm64/sysregs.h
> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h
> @@ -469,8 +469,11 @@
>       asm volatile("mrs  %0, "__stringify(name) : "=r" (_r));         \
>       _r; })
>   
> -#define READ_SYSREG(name)     READ_SYSREG64(name)
> -#define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name)
> +#define READ_SYSREG(name)          READ_SYSREG64(name)
> +#define WRITE_SYSREG(v, name)      WRITE_SYSREG64(v, name)

Please don't re-indent existing macro. This is only introducing 
unnecessary extra churn.

> +#define ICH_LR_REG(index)          ICH_LR ## index ## _EL2
> +#define WRITE_SYSREG_LR(index, v)  WRITE_SYSREG(v, ICH_LR_REG(index))
> +#define READ_SYSREG_LR(index)      READ_SYSREG(ICH_LR_REG(index))
>   
>   #endif /* _ASM_ARM_ARM64_SYSREGS_H */
>   
> diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
> index 48a1bc401e..87115f8b25 100644
> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
> @@ -185,9 +185,9 @@
>   #define ICH_LR_HW_SHIFT              61
>   #define ICH_LR_GRP_MASK              0x1
>   #define ICH_LR_GRP_SHIFT             60
> -#define ICH_LR_MAINTENANCE_IRQ       (1UL<<41)
> -#define ICH_LR_GRP1                  (1UL<<60)
> -#define ICH_LR_HW                    (1UL<<61)
> +#define ICH_LR_MAINTENANCE_IRQ       (1ULL<<41)
> +#define ICH_LR_GRP1                  (1ULL<<60)
> +#define ICH_LR_HW                    (1ULL<<61)
>   
>   #define ICH_VTR_NRLRGS               0x3f
>   #define ICH_VTR_PRIBITS_MASK         0x7

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:04:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:04:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428208.678142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCJG-0001vB-DS; Sat, 22 Oct 2022 11:04:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428208.678142; Sat, 22 Oct 2022 11:04:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCJG-0001v2-Ag; Sat, 22 Oct 2022 11:04:58 +0000
Received: by outflank-mailman (input) for mailman id 428208;
 Sat, 22 Oct 2022 11:04:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omCJF-0001tn-9D
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 11:04:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCJE-0001GC-VR; Sat, 22 Oct 2022 11:04:56 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCJE-0008Ld-Oz; Sat, 22 Oct 2022 11:04:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=N7FSh7BHuRInGQ10YMDMsVppU0t5+7Kg6xMMGERbrN8=; b=pcApPJrxa3HnqkgA1OqyIVCdCC
	rgM1fiz6syhT4TlcG465gVn0nmvqpcKwd9Rryq0XTBLFKa4kCGFfG9VtMxIIDgbNrJTqquAJQ2ykr
	OQz3Hanv+qtZXN1eLJ1naoKDyNfYTIg9SMAyfresFMJxiGglcNMHcK7SVY6/FYzRASpE=;
Message-ID: <e6c5a136-15d3-831f-0d20-2cda3ec9d46b@xen.org>
Date: Sat, 22 Oct 2022 12:04:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v1 08/12] Arm: GICv3: Define ICH_AP0R<n> and
 ICH_AP1R<n> for AArch32
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-9-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221021153128.44226-9-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> Refer "Arm IHI 0069H ID020922",
> 12.7.1 - Interrupt Controller Hyp Active Priorities Group0 Registers 0-3
> 12.7.2 - Interrupt Controller Hyp Active Priorities Group1 Registers 0-3
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/arm32/sysregs.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
> index f3b4dfbca8..693da22324 100644
> --- a/xen/arch/arm/include/asm/arm32/sysregs.h
> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h

As the previous patch, the define should be declared in cpregs.h.

> @@ -117,6 +117,18 @@
>   #define ICH_LRC14_EL2              __LRC8_EL2(6)
>   #define ICH_LRC15_EL2              __LRC8_EL2(7)
>   
> +#define __AP0Rx_EL2(x)            ___CP32(p15,4,c12,c8,x)
> +#define ICH_AP0R0_EL2             __AP0Rx_EL2(0)
> +#define ICH_AP0R1_EL2             __AP0Rx_EL2(1)
> +#define ICH_AP0R2_EL2             __AP0Rx_EL2(2)
> +#define ICH_AP0R3_EL2             __AP0Rx_EL2(3)
> +
> +#define __AP1Rx_EL2(x)            ___CP32(p15,4,c12,c9,x)
> +#define ICH_AP1R0_EL2             __AP1Rx_EL2(0)
> +#define ICH_AP1R1_EL2             __AP1Rx_EL2(1)
> +#define ICH_AP1R2_EL2             __AP1Rx_EL2(2)
> +#define ICH_AP1R3_EL2             __AP1Rx_EL2(3)
> +
>   #endif /* __ASSEMBLY__ */
>   
>   #endif /* __ASM_ARM_ARM32_SYSREGS_H */

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:06:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:06:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428214.678153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCKH-0002ZF-Oe; Sat, 22 Oct 2022 11:06:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428214.678153; Sat, 22 Oct 2022 11:06:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCKH-0002Z8-LB; Sat, 22 Oct 2022 11:06:01 +0000
Received: by outflank-mailman (input) for mailman id 428214;
 Sat, 22 Oct 2022 11:06:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omCKG-0002Yr-3I
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 11:06:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCKF-0001HQ-OB; Sat, 22 Oct 2022 11:05:59 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCKF-0008Nx-Ic; Sat, 22 Oct 2022 11:05:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=fKt7Iquz+05LK/SruQ+8oOkN3I2zKyEsbCtZLs04c6U=; b=25nnaDPotuAW1voQpPDy4Wp8vh
	EC/JX2t2e+SaS41gw8r+xyxtDUENB9UlIHsveithiW9YMfdRQOpSJ3rnXfzsbq6y22LzmoDCxB6Cy
	l+NtPfGngs/d7GPUXUZCazDD9F1XeP+bNs2zcwVHh/yYIfWW//NcDHw0sqEzQi7lfjKg=;
Message-ID: <f69393dc-7a5e-bf63-e12c-a0ac655a8573@xen.org>
Date: Sat, 22 Oct 2022 12:05:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v1 09/12] Arm: GICv3: Define GIC registers for AArch32
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-10-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221021153128.44226-10-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> Refer "Arm IHI 0069H ID020922"
> 12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt
> Group 1 Register
> 12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register
> 12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register
> 12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register
> 12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register
> 12.5.24 ICC_SRE, Interrupt Controller System Register Enable register
> 12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register
> 12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1
> 12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1
> 12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1
> 12.5.6 ICC_CTLR, Interrupt Controller Control Register
> 12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register
> 12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/arm32/sysregs.h | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
> index 693da22324..d2c5a115f9 100644
> --- a/xen/arch/arm/include/asm/arm32/sysregs.h
> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h

Same as the previous two patches. This should be defined in cpregs.h

> @@ -129,6 +129,22 @@
>   #define ICH_AP1R2_EL2             __AP1Rx_EL2(2)
>   #define ICH_AP1R3_EL2             __AP1Rx_EL2(3)
>   
> +#define ICC_SGI1R_EL1             p15,0,c12
> +
> +#define ICC_SRE_EL2               p15,4,c12,c9,5
> +#define ICH_VTR_EL2               p15,4,c12,c11,1
> +#define ICH_HCR_EL2               p15,4,c12,c11,0
> +
> +#define ICC_PMR_EL1               p15,0,c4,c6,0
> +#define ICC_SRE_EL1               p15,0,c12,c12,5
> +#define ICC_DIR_EL1               p15,0,c12,c11,1
> +#define ICC_EOIR1_EL1             p15,0,c12,c12,1
> +#define ICC_IAR1_EL1              p15,0,c12,c12,0
> +#define ICC_BPR1_EL1              p15,0,c12,c12,3
> +#define ICC_CTLR_EL1              p15,0,c12,c12,4
> +#define ICC_IGRPEN1_EL1           p15,0,c12,c12,7
> +#define ICH_VMCR_EL2              p15,4,c12,c11,7
> +
>   #endif /* __ASSEMBLY__ */
>   
>   #endif /* __ASM_ARM_ARM32_SYSREGS_H */

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:13:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:13:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428222.678170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCR8-00045N-I1; Sat, 22 Oct 2022 11:13:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428222.678170; Sat, 22 Oct 2022 11:13:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCR8-00045D-EW; Sat, 22 Oct 2022 11:13:06 +0000
Received: by outflank-mailman (input) for mailman id 428222;
 Sat, 22 Oct 2022 11:13:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omCR6-000457-OY
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 11:13:04 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCR6-0001Pq-BT; Sat, 22 Oct 2022 11:13:04 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCR6-0000OE-5W; Sat, 22 Oct 2022 11:13:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=MmJ6OPiOh2JUzzqLxy83W312Aw1c00QrFfmDrVzWh/g=; b=VhRCSO1b2LG2548Ydlurc2tsoq
	x4qxkDH0Fj8MXU0ditNWZY1CXQhtyQKdzTZb6ByDhUnPcYr0hSsdx36BqWFmut5fFLYJjjnyu0DAl
	p6BzE8Y4U1bp4AyCLG3Pdkxy5gFJIQJodVGR+Ni9CPaO1r6Bk/8NYibZvfjy7jRRntyk=;
Message-ID: <491953d9-af20-0f9a-429c-c1342efc77d3@xen.org>
Date: Sat, 22 Oct 2022 12:13:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-11-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH v1 10/12] Arm: GICv3: Use ULL instead of UL for 64bits
In-Reply-To: <20221021153128.44226-11-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> "unsigned long long" is defined as 64 bits on AArch64 and AArch32
> Thus, one should this instead of "unsigned long" which is 32 bits
> on AArch32.
> 
> Also use 'PRIu64' instead of 'lx' to print uint64_t.

This is not quite a simple change of type. Now, the values will be 
printed in decimal rather than hexadecimal. Any particular reason why 
you didn't go with PRIx64?

[...]

> diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
> index 87115f8b25..3a24bd4825 100644
> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
> @@ -195,7 +195,7 @@
>   
>   #define ICH_SGI_IRQMODE_SHIFT        40
>   #define ICH_SGI_IRQMODE_MASK         0x1
> -#define ICH_SGI_TARGET_OTHERS        1UL
> +#define ICH_SGI_TARGET_OTHERS        1ULL
>   #define ICH_SGI_TARGET_LIST          0
>   #define ICH_SGI_IRQ_SHIFT            24
>   #define ICH_SGI_IRQ_MASK             0xf
> diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h
> index fae3f6ecef..5ae50b18ea 100644
> --- a/xen/arch/arm/include/asm/gic_v3_its.h
> +++ b/xen/arch/arm/include/asm/gic_v3_its.h
> @@ -38,7 +38,7 @@
>   #define GITS_PIDR2                      GICR_PIDR2
>   
>   /* Register bits */
> -#define GITS_VALID_BIT                  BIT(63, UL)
> +#define GITS_VALID_BIT                  BIT(63, ULL)
>   
>   #define GITS_CTLR_QUIESCENT             BIT(31, UL)
>   #define GITS_CTLR_ENABLE                BIT(0, UL)
> diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
> index 58d939b85f..2b7bb17800 100644
> --- a/xen/arch/arm/vgic-v3-its.c
> +++ b/xen/arch/arm/vgic-v3-its.c
> @@ -96,13 +96,13 @@ typedef uint16_t coll_table_entry_t;
>    * in the lowest 5 bits of the word.
>    */
>   typedef uint64_t dev_table_entry_t;
> -#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK(51, 8))
> +#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK_ULL(51, 8))
>   #define DEV_TABLE_ITT_SIZE(x) (BIT(((x) & GENMASK(4, 0)) + 1, UL))
>   #define DEV_TABLE_ENTRY(addr, bits)                     \
>           (((addr) & GENMASK(51, 8)) | (((bits) - 1) & GENMASK(4, 0)))
>   
>   #define GITS_BASER_RO_MASK       (GITS_BASER_TYPE_MASK | \
> -                                  (0x1fL << GITS_BASER_ENTRY_SIZE_SHIFT))
> +                                  (0x1fLL << GITS_BASER_ENTRY_SIZE_SHIFT))

While you are modifying it, shouldn't this be ULL?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:15:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:15:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428228.678180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCT7-0004jc-0y; Sat, 22 Oct 2022 11:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428228.678180; Sat, 22 Oct 2022 11:15:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCT6-0004jV-US; Sat, 22 Oct 2022 11:15:08 +0000
Received: by outflank-mailman (input) for mailman id 428228;
 Sat, 22 Oct 2022 11:15:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omCT5-0004jL-Au; Sat, 22 Oct 2022 11:15:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omCT5-0001Rr-A2; Sat, 22 Oct 2022 11:15:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omCT4-0007YS-Sc; Sat, 22 Oct 2022 11:15:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omCT4-0005WI-SB; Sat, 22 Oct 2022 11:15:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jduODl6c+z/pi0jmjU6vsh8qUetCg78uTst0Y8/O2K4=; b=5wMDFFOFiZQS43AibopCtbkhma
	+t1f2SE/PeivCobJ4CX9pMMXUoqJMdeDPUxsgMBhlKCrlOQMPII9Hr8iihgnn+38D0RZQcKZv6ap8
	LUY1kWc7RFoC822FdLo46/n6wU51ZGQYk+YPFqFauTllpClRVvQS1DkNJeDaVOpnPZ5M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174250-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174250: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=2355f0c09c52d6979f9f471b23816f3081cc946b
X-Osstest-Versions-That:
    ovmf=913a308df934952bcbedacb6baa8bd023a25b978
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 11:15:06 +0000

flight 174250 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174250/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 2355f0c09c52d6979f9f471b23816f3081cc946b
baseline version:
 ovmf                 913a308df934952bcbedacb6baa8bd023a25b978

Last test of basis   174243  2022-10-22 07:10:26 Z    0 days
Testing same since   174250  2022-10-22 09:41:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rebecca Cran <rebecca@bsdio.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   913a308df9..2355f0c09c  2355f0c09c52d6979f9f471b23816f3081cc946b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:25:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:25:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428237.678197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCd7-0006KV-1c; Sat, 22 Oct 2022 11:25:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428237.678197; Sat, 22 Oct 2022 11:25:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCd6-0006KO-VL; Sat, 22 Oct 2022 11:25:28 +0000
Received: by outflank-mailman (input) for mailman id 428237;
 Sat, 22 Oct 2022 11:25:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omCd6-0006KI-Kq
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 11:25:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCd6-0001c2-A2; Sat, 22 Oct 2022 11:25:28 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCd6-0000pZ-2K; Sat, 22 Oct 2022 11:25:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=z+cwlXg6MdquqcivDRdP5k0NvZOBUUXiyGR0buOOG9Y=; b=XXP4T6cH2CACxJADmoAQUM0d1L
	C7Jk0IAAZARghEZuVkRWV0MMyA2MiYV8CXxhl7P4NOEzbfhpAmaKhJR2KCGL4N/VrmNKWLvBTM+Wz
	XQ4ngGM/NAkbqJc3uKSYYNR/afFNjz9FaLr1aJWe+PnDFRt+7oXOL2MTKUtvMWbDrwzU=;
Message-ID: <4fef02bd-80e7-f24a-5496-4f35d1e5060c@xen.org>
Date: Sat, 22 Oct 2022 12:25:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-12-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC PATCH v1 11/12] Arm: GICv3: Define macros to read/write 64
 bit
In-Reply-To: <20221021153128.44226-12-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs.
> This in turn calls readl_relaxed()/writel_relaxed() twice for the lower
> and upper 32 bits.

This needs an explanation why we can't use "strd/ldrd". And the same 
would have to be duplicated in the code below.

> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/include/asm/arm32/io.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h
> index 73a879e9fb..6a5f563fbc 100644
> --- a/xen/arch/arm/include/asm/arm32/io.h
> +++ b/xen/arch/arm/include/asm/arm32/io.h
> @@ -80,10 +80,14 @@ static inline u32 __raw_readl(const volatile void __iomem *addr)
>                                           __raw_readw(c)); __r; })
>   #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \
>                                           __raw_readl(c)); __r; })
> +#define readq_relaxed(c) ({ u64 __r = (le64_to_cpu(readl_relaxed(c+4)) << 32) | \
> +                                        readl_relaxed(c); __r; })

All the read*_relaxed are provide atomic read. This is not guaranteed by 
your new helper. The name should be different (maybe 
readq_relaxed_non_atomic()) to make clear of the difference.

I also don't quite understand the implementation. The value returned by 
readl_relaxed() is already in the CPU endianess. So why do you call 
le64_to_cpu() on top?

>   
>   #define writeb_relaxed(v,c)     __raw_writeb(v,c)
>   #define writew_relaxed(v,c)     __raw_writew((__force u16) cpu_to_le16(v),c)
>   #define writel_relaxed(v,c)     __raw_writel((__force u32) cpu_to_le32(v),c)
> +#define writeq_relaxed(v,c)     writel_relaxed(((uint64_t)v&0xffffffff), c); \
> +                                    writel_relaxed((((uint64_t)v)>>32), (c+4));

This needs to be surrounded with do { } while (0), otherwise the 
following would not properly work:

if ( foo )
   writeq_relaxed(v, c);

Similarly, if 'v' is a call, then it will end up to be called twice.

>   
>   #define readb(c)                ({ u8  __v = readb_relaxed(c); __iormb(); __v; })
>   #define readw(c)                ({ u16 __v = readw_relaxed(c); __iormb(); __v; })

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 11:29:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 11:29:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428243.678212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCgm-0006xC-IK; Sat, 22 Oct 2022 11:29:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428243.678212; Sat, 22 Oct 2022 11:29:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omCgm-0006x5-Ff; Sat, 22 Oct 2022 11:29:16 +0000
Received: by outflank-mailman (input) for mailman id 428243;
 Sat, 22 Oct 2022 11:29:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omCgl-0006wz-PX
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 11:29:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCgl-0001gs-Cj; Sat, 22 Oct 2022 11:29:15 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omCgl-0000u9-6y; Sat, 22 Oct 2022 11:29:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Uuz/7lKD86dTjwGh224ZTNJXIx9Q1aBDUaTErXakFZY=; b=yIzmBpi9wjuxdxSh8rPKfXnxGK
	ThDw76adtf4WDNa8HDEIABlyE2L8yar1WLDMAkzaQVncqc8dKZpxAWCr/XgIeUcF28pz8VFqS9ko4
	ubRaAqSJVi58cIaaNlo805gbRjcjq/BK2o/HnL+AhAHto0Apj9co2f4TpT5XRVBadydE=;
Message-ID: <d2a66788-be95-82bc-0c35-a168bf117d9a@xen.org>
Date: Sat, 22 Oct 2022 12:29:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v1 12/12] Arm: GICv3: Enable GICv3 for AArch32
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-13-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221021153128.44226-13-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 21/10/2022 16:31, Ayan Kumar Halder wrote:
> Refer ARM DDI 0487G.b ID072021,
> D13.2.86 -
> ID_PFR1_EL1, AArch32 Processor Feature Register 1
> 
> GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32
> 
> One can now enable GICv3 on AArch32 systems.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/Kconfig                  | 2 +-
>   xen/arch/arm/include/asm/cpufeature.h | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 1fe5faf847..5eaf21b8e0 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -41,7 +41,7 @@ config ARM_EFI
>   
>   config GICV3
>   	bool "GICv3 driver"
> -	depends on ARM_64 && !NEW_VGIC
> +	depends on (ARM_64 || ARM_32) && !NEW_VGIC

(ARM_64 || ARM_32) will always be true. So this can be dropped.

Furthermore, I wonder whether we should update SUPPORT.md with the 
support state for GICv3 on 32-bit. I would be fine if we already mark it 
as "supported, not security supported". But I am not sure about security 
supported until further testing.

Any opinions?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 12:12:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 12:12:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428262.678225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omDMY-0003rt-0o; Sat, 22 Oct 2022 12:12:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428262.678225; Sat, 22 Oct 2022 12:12:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omDMX-0003rl-Ty; Sat, 22 Oct 2022 12:12:25 +0000
Received: by outflank-mailman (input) for mailman id 428262;
 Sat, 22 Oct 2022 12:12:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omDMW-0003rb-NZ; Sat, 22 Oct 2022 12:12:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omDMW-0002Ow-Ie; Sat, 22 Oct 2022 12:12:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omDMW-00016q-13; Sat, 22 Oct 2022 12:12:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omDMW-0000r3-0P; Sat, 22 Oct 2022 12:12:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+8a9h9EzWBbCs2Uu35TErsqGcwzNWa0ZC8iyykpY8DE=; b=Nn/dmTg2jn9N8etIzxuUZYH18z
	wWgc1NnIZ5NuqoNVwmNhYlrsWDkXyZxpKtcHS5ARsbabvjy+fnyDAYnQr5eZcIPLl9uSXT9ojU4HW
	O2eYPNZsUkRHndde+OQ8UmWuA4APfWCGTPb+R9dhxT2w4ReKbU6TKjpiLHS6uOpC+52A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174202-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174202: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 12:12:24 +0000

flight 174202 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174202/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174202
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174202
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174202
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174202
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174202
 test-amd64-i386-xl-shadow     7 xen-install      fail in 174134 pass in 174202
 test-arm64-arm64-xl-xsm       8 xen-boot         fail in 174134 pass in 174202
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174134 pass in 174202
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906
 test-amd64-amd64-xl-qemut-ws16-amd64  8 xen-boot           fail pass in 174134
 test-amd64-i386-xl-vhd        7 xen-install                fail pass in 174134
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174134

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop  fail in 174134 like 172550
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 174134 like 172550
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   67 days
Failing since        173496  2022-10-11 14:08:01 Z   10 days   11 attempts
Testing same since   173650  2022-10-13 00:06:56 Z    9 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 13:28:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 13:28:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428279.678267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omEY4-0002we-2F; Sat, 22 Oct 2022 13:28:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428279.678267; Sat, 22 Oct 2022 13:28:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omEY3-0002wX-UQ; Sat, 22 Oct 2022 13:28:23 +0000
Received: by outflank-mailman (input) for mailman id 428279;
 Sat, 22 Oct 2022 13:28:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omEY3-0002wN-3U; Sat, 22 Oct 2022 13:28:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omEY3-0003bo-0B; Sat, 22 Oct 2022 13:28:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omEY2-0005Wc-J2; Sat, 22 Oct 2022 13:28:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omEY2-0007zC-IR; Sat, 22 Oct 2022 13:28:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8ggP04atz1hq2FAFGyrDNvCLTQ5WssJMrVkU1fiF0Kc=; b=YMTZ8VAFFjE6x0pl5XLcsbYqRB
	jSnk/87RgFY2kIJj/8njEfUhbicHf2xLSS4zFar3iWfssPDoYPpp3oI1nhsypnFVhaphB6atVWA21
	7RsdKOYYVizV/XHUt1cPdCeP51+yYy2qO6D+3t8q/eX1m1UHxiedwJqgdL9Y3NkySPBQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174225-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174225: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:build-arm64-libvirt:libvirt-build:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 13:28:22 +0000

flight 174225 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174225/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174225
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174063 pass in 174225
 test-amd64-i386-xl-xsm        7 xen-install      fail in 174063 pass in 174225
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174063 pass in 174225
 test-arm64-arm64-libvirt-xsm 14 guest-start      fail in 174183 pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 174183 pass in 173987
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 174063
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 174063
 test-amd64-i386-xl-qemut-debianhvm-amd64  7 xen-install    fail pass in 174183
 test-amd64-i386-libvirt-pair 22 guests-nbd-mirror/debian   fail pass in 174183

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd      12 debian-di-install       fail blocked in 172547
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174063 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174183 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174183 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174183 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174183 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174183 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174183 n/a
 build-armhf                   2 hosts-allocate           starved in 174183 n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   67 days
Failing since        173494  2022-10-11 13:38:08 Z   10 days   13 attempts
Testing same since   173610  2022-10-12 17:10:45 Z    9 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 14:38:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 14:38:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428291.678290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omFda-000246-8Q; Sat, 22 Oct 2022 14:38:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428291.678290; Sat, 22 Oct 2022 14:38:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omFda-00023z-5T; Sat, 22 Oct 2022 14:38:10 +0000
Received: by outflank-mailman (input) for mailman id 428291;
 Sat, 22 Oct 2022 14:38:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omFdZ-00023p-KN; Sat, 22 Oct 2022 14:38:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omFdZ-0004nk-Fw; Sat, 22 Oct 2022 14:38:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omFdZ-00027A-3O; Sat, 22 Oct 2022 14:38:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omFdZ-0003ta-2V; Sat, 22 Oct 2022 14:38:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F8lSYIMIF1BeV4ATXhDfrZdP6psncjikvl4DDKAwWbY=; b=o24uKvQ+2IKIcruEGEHSVSf7rw
	6ucRwQ0EtG7HA3BKD6163O6hxSijSLU3KUDQuoBDPGOEPLXT2Djhdo04OnePndHebcvF1QEvlV8aW
	m4hrMTuIaVf2GEjIGfrRVVfgCZxtWwUGLDpuwigcE2Zjf2cQ3hcIYSmVUpBrcLUnj694=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174212-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174212: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.16-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 14:38:09 +0000

flight 174212 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174212/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173493 REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start    fail in 173493 REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173493 REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 174212
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 174070 pass in 174212
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174070 pass in 174212
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 174070

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   65 days
Testing same since   173493  2022-10-11 13:07:01 Z   11 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428300.678323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG36-0005wf-Va; Sat, 22 Oct 2022 15:04:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428300.678323; Sat, 22 Oct 2022 15:04:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG36-0005wY-SZ; Sat, 22 Oct 2022 15:04:32 +0000
Received: by outflank-mailman (input) for mailman id 428300;
 Sat, 22 Oct 2022 15:04:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG34-0005gS-UH
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:30 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG34-0005Ej-KM; Sat, 22 Oct 2022 15:04:30 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG34-00023n-Bx; Sat, 22 Oct 2022 15:04:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=LrFyBh0VUTegwiGKJOtrjeyi3WyVFq/ISvEVIIaZGsA=; b=AAFJwHuto9C4duL4FSkEqoCtlP
	IE4EkzYWr1SxtkKMvT7OGYRG343lAdKaP/wBcQRdFz+M13Pa9uFisba+1GfigJnRj5lc2VLJz5z0d
	TLwtIjCXabD3CPG7IxsVCS3Ji0DWrrJmbeRL9PXpxPezJLCDCE6AV5F+su26hGS478S4=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 02/12] xen/arm32: head: Jump to the runtime mapping in enable_mmu()
Date: Sat, 22 Oct 2022 16:04:12 +0100
Message-Id: <20221022150422.17707-3-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

At the moment, enable_mmu() will return to an address in the 1:1 mapping
and each path are responsible to switch to the runtime mapping.

In a follow-up patch, the behavior to switch to the runtime mapping
will become more complex. So to avoid more code/comment duplication,
move the switch in enable_mmu().

Lastly, take the opportunity to replace load from literal pool with
mov_w.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm32/head.S | 51 ++++++++++++++++++++++++---------------
 1 file changed, 31 insertions(+), 20 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index a558c2a6876e..163bd6596dec 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -167,19 +167,12 @@ past_zImage:
         bl    check_cpu_mode
         bl    cpu_init
         bl    create_page_tables
-        bl    enable_mmu
 
-        /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
-        ldr   r0, =primary_switched
-        mov   pc, r0
+        /* Address in the runtime mapping to jump to after the MMU is enabled */
+        mov_w lr, primary_switched
+        b     enable_mmu
+
 primary_switched:
-        /*
-         * The 1:1 map may clash with other parts of the Xen virtual memory
-         * layout. As it is not used anymore, remove it completely to
-         * avoid having to worry about replacing existing mapping
-         * afterwards.
-         */
-        bl    remove_identity_mapping
         bl    setup_fixmap
 #ifdef CONFIG_EARLY_PRINTK
         /* Use a virtual address to access the UART. */
@@ -223,12 +216,10 @@ GLOBAL(init_secondary)
         bl    check_cpu_mode
         bl    cpu_init
         bl    create_page_tables
-        bl    enable_mmu
-
 
-        /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
-        ldr   r0, =secondary_switched
-        mov   pc, r0
+        /* Address in the runtime mapping to jump to after the MMU is enabled */
+        mov_w lr, secondary_switched
+        b     enable_mmu
 secondary_switched:
         /*
          * Non-boot CPUs need to move on to the proper pagetables, which were
@@ -523,9 +514,12 @@ virtphys_clash:
 ENDPROC(create_page_tables)
 
 /*
- * Turn on the Data Cache and the MMU. The function will return on the 1:1
- * mapping. In other word, the caller is responsible to switch to the runtime
- * mapping.
+ * Turn on the Data Cache and the MMU. The function will return
+ * to the virtual address provided in LR (e.g. the runtime mapping).
+ *
+ * Inputs:
+ *   r9 : paddr(start)
+ *   lr : Virtual address to return to
  *
  * Clobbers r0 - r3
  */
@@ -551,7 +545,24 @@ enable_mmu:
         dsb                          /* Flush PTE writes and finish reads */
         mcr   CP32(r0, HSCTLR)       /* now paging is enabled */
         isb                          /* Now, flush the icache */
-        mov   pc, lr
+
+        /*
+         * The MMU is turned on and we are in the 1:1 mapping. Switch
+         * to the runtime mapping.
+         */
+        mov_w r0, 1f
+        mov   pc, r0
+1:
+        /*
+         * The 1:1 map may clash with other parts of the Xen virtual memory
+         * layout. As it is not used anymore, remove it completely to
+         * avoid having to worry about replacing existing mapping
+         * afterwards.
+         *
+         * On return this will jump to the virtual address requested by
+         * the caller.
+         */
+        b     remove_identity_mapping
 ENDPROC(enable_mmu)
 
 /*
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428298.678301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG33-0005Ql-Bf; Sat, 22 Oct 2022 15:04:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428298.678301; Sat, 22 Oct 2022 15:04:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG33-0005Qe-8v; Sat, 22 Oct 2022 15:04:29 +0000
Received: by outflank-mailman (input) for mailman id 428298;
 Sat, 22 Oct 2022 15:04:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG32-0005QY-DO
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:28 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG32-0005EK-0T; Sat, 22 Oct 2022 15:04:28 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG31-00023n-Kq; Sat, 22 Oct 2022 15:04:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=ii/EgQwOpf6vztGl40kGWEvUN8FQW87A5MXJcWq8PS8=; b=3m6HXS
	imK6E4zbxJHxRT1x8YlaJHMtXbr+IQ1PwAwMXyT4fATc3PiP3SoYxUbSl8W6ayKrQCaae0nTU7msZ
	JlZiN4ixuvV2arf4VYENP290xcIV8ntBxK/AgXpHpHvuui7LEN5TKp5TBuy6gFgRCdWjlP/nFmiti
	/nS/QOEmTaY=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 00/12] xen/arm: Don't switch TTBR while the MMU is on
Date: Sat, 22 Oct 2022 16:04:10 +0100
Message-Id: <20221022150422.17707-1-julien@xen.org>
X-Mailer: git-send-email 2.37.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Hi all,

Currently, Xen on Arm will switch TTBR whilst the MMU is on. This is
similar to replacing existing mappings with new ones. So we need to
follow a break-before-make sequence.

When switching the TTBR, we need to temporary disable the MMU
before updating the TTBR. This means the page-tables must contain an
identity mapping.

The current memory layout is not very flexible and has an higher chance
to clash with the identity mapping.

On Arm64, we have plenty of unused virtual address space Therefore, we can
simply reshuffle the layout to leave the first part of the virtual
address space empty.

On Arm32, the virtual address space is already quite full. Even if we
find space, it would be necessary to have a dynamic layout. So a
different approach will be necessary. The chosen one is to have
a temporary mapping that will be used to jumped from the ID mapping
to the runtime mapping (or vice versa). The temporary mapping will
be overlapping with the domheap area as it should not be used when
switching on/off the MMU.

The Arm32 part is not yet addressed in this version. The series is
sent as an early RFC to gather some feedback on the approach.

After this series, most of Xen page-table code should be compliant
with the Arm Arm. The last two issues I am aware of are:
 - domheap: Mappings are replaced without using the Break-Before-Make
   approach.
 - The cache is not cleaned/invalidated when updating the page-tables
   with Data cache off (like during early boot).

The long term plan is to get rid of boot_* page tables and then
directly use the runtime pages. This means for coloring, we will
need to build the pages in the relocated Xen rather than the current
Xen.

For convience, I pushed a branch with everything applied:

https://xenbits.xen.org/git-http/people/julieng/xen-unstable.git
branch boot-pt-rework-v2

Cheers,

Julien Grall (12):
  xen/arm: Clean-up the memory layout
  xen/arm32: head: Jump to the runtime mapping in enable_mmu()
  xen/arm32: head: Introduce an helper to flush the TLBs
  xen/arm32: head: Remove restriction where to load Xen
  xen/arm32: head: Widen the use of the temporary mapping
  xen/arm: Enable use of dump_pt_walk() early during boot
  xen/arm64: Rework the memory layout
  xen/arm: mm: Allow xen_pt_update() to work with the current root table
  xen/arm: mm: Allow dump_hyp_walk() to work on the current root table
  xen/arm64: mm: Introduce helpers to prepare/enable/disable the
    identity mapping
  xen/arm64: mm: Rework switch_ttbr()
  xen/arm64: smpboot: Directly switch to the runtime page-tables

 xen/arch/arm/arm32/head.S           | 253 ++++++++++++++++++----------
 xen/arch/arm/arm32/smpboot.c        |   4 +
 xen/arch/arm/arm64/Makefile         |   1 +
 xen/arch/arm/arm64/head.S           |  86 +++++-----
 xen/arch/arm/arm64/mm.c             | 160 ++++++++++++++++++
 xen/arch/arm/arm64/smpboot.c        |  15 +-
 xen/arch/arm/domain_page.c          |   9 +
 xen/arch/arm/include/asm/arm32/mm.h |   4 +
 xen/arch/arm/include/asm/arm64/mm.h |  12 ++
 xen/arch/arm/include/asm/config.h   |  63 +++++--
 xen/arch/arm/include/asm/mm.h       |   2 +
 xen/arch/arm/include/asm/setup.h    |  11 ++
 xen/arch/arm/include/asm/smp.h      |   1 +
 xen/arch/arm/mm.c                   | 105 +++++++-----
 xen/arch/arm/smpboot.c              |   1 +
 15 files changed, 536 insertions(+), 191 deletions(-)
 create mode 100644 xen/arch/arm/arm64/mm.c

-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428301.678328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG37-00060B-Af; Sat, 22 Oct 2022 15:04:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428301.678328; Sat, 22 Oct 2022 15:04:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG37-0005yx-5D; Sat, 22 Oct 2022 15:04:33 +0000
Received: by outflank-mailman (input) for mailman id 428301;
 Sat, 22 Oct 2022 15:04:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG36-0005uq-GX
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG35-0005F3-VY; Sat, 22 Oct 2022 15:04:31 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG35-00023n-NO; Sat, 22 Oct 2022 15:04:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=Aq7wpCbgRD2Vz4E/mFWzygsJQJEQlpBo6MNpZAyyP2k=; b=jLrM12Dsvy2hP6/Yl/UU4IfHli
	tE/rnoYeF37V7m2umvUB3zJYTUwW2ycFg3Dh9a+uUuwC/1XhIOQx5i686vAmW4Lm9PfCJMpOOdXkl
	4wPnCNAZ7uTkHvJi3hvDLKHliuNH1ALN8C9MGY+qh2VUzvbJ37/QrLcf9A6uQxGLAc7E=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 03/12] xen/arm32: head: Introduce an helper to flush the TLBs
Date: Sat, 22 Oct 2022 16:04:13 +0100
Message-Id: <20221022150422.17707-4-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The sequence for flushing the TLBs is 4 instruction long and often
require an explanation how it works.

So create an helper and use it in the boot code (switch_ttbr() is left
alone for now).

Note that in secondary_switched, we were also flushing the instruction
cache and branch predictor. Neither of them was necessary because:
    * We are only supporting IVIPT cache on arm32, so the instruction
      cache flush is only necessary when executable code is modified.
      None of the boot code is doing that.
    * The instruction cache is not invalidated and misprediction is not
      a problem at boot.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/arm32/head.S | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 163bd6596dec..aeaa8d105aeb 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -66,6 +66,21 @@
         add   \rb, \rb, r10
 .endm
 
+/*
+ * Flush local TLBs
+ *
+ * tmp1:    Scratch register
+ *
+ * See asm/arm32/flushtlb.h for the explanation of the sequence.
+ */
+.macro flush_xen_tlb_local tmp1
+        /* See asm/arm32/flushtlb.h for the explanation of the sequence. */
+        dsb   nshst
+        mcr   CP32(\tmp1, TLBIALLH)
+        dsb   nsh
+        isb
+.endm
+
 /*
  * Common register usage in this file:
  *   r0  -
@@ -233,11 +248,7 @@ secondary_switched:
         mcrr  CP64(r4, r5, HTTBR)
         dsb
         isb
-        mcr   CP32(r0, TLBIALLH)     /* Flush hypervisor TLB */
-        mcr   CP32(r0, ICIALLU)      /* Flush I-cache */
-        mcr   CP32(r0, BPIALL)       /* Flush branch predictor */
-        dsb                          /* Ensure completion of TLB+BP flush */
-        isb
+        flush_xen_tlb_local r0
 
 #ifdef CONFIG_EARLY_PRINTK
         /* Use a virtual address to access the UART. */
@@ -530,8 +541,7 @@ enable_mmu:
          * The state of the TLBs is unknown before turning on the MMU.
          * Flush them to avoid stale one.
          */
-        mcr   CP32(r0, TLBIALLH)     /* Flush hypervisor TLBs */
-        dsb   nsh
+        flush_xen_tlb_local r0
 
         /* Write Xen's PT's paddr into the HTTBR */
         load_paddr r0, boot_pgtable
@@ -606,12 +616,7 @@ remove_identity_mapping:
         strd  r2, r3, [r0, r1]
 
 identity_mapping_removed:
-        /* See asm/arm32/flushtlb.h for the explanation of the sequence. */
-        dsb   nshst
-        mcr   CP32(r0, TLBIALLH)
-        dsb   nsh
-        isb
-
+        flush_xen_tlb_local r0
         mov   pc, lr
 ENDPROC(remove_identity_mapping)
 
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428299.678312 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG35-0005gl-KF; Sat, 22 Oct 2022 15:04:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428299.678312; Sat, 22 Oct 2022 15:04:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG35-0005gc-HT; Sat, 22 Oct 2022 15:04:31 +0000
Received: by outflank-mailman (input) for mailman id 428299;
 Sat, 22 Oct 2022 15:04:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG33-0005bG-Qk
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG33-0005EU-8k; Sat, 22 Oct 2022 15:04:29 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG33-00023n-0E; Sat, 22 Oct 2022 15:04:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=8yMgJ3Zo7YUfciDmg8O8H51lri8h2DniSD/vMf2ZgB0=; b=fA5FYHWKEQe3gYp/s4qosX/hwu
	pblmvc47+ckOeyAmI3mxJ1GPfHOcazR4Qtxw1Wvnhn1UuQ0sjjwD6jZHc/atbD6T+Q3Ua+RDi5oZl
	lBtcmIWSZ+LJBPnPXLZvq6q6tbTGP47Uxp809dtDetYsZdrRfmQCeyDwWGppF/PJAy3M=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Date: Sat, 22 Oct 2022 16:04:11 +0100
Message-Id: <20221022150422.17707-2-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

In a follow-up patch, the base address for the common mappings will
vary between arm32 and arm64. To avoid any duplication, define
every mapping in the common region from the previous one.

Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
XEN_VIRT_*.

Take the opportunity to add missing *_SIZE for some mappings.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----
    Changes in v2:
        - Use _AT(vaddr_t, ...) to build on 32-bit.
        - Drop COMMON_VIRT_START
---
 xen/arch/arm/include/asm/config.h | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 0fefed1b8aa9..80d81f127f7e 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -107,14 +107,19 @@
  *  Unused
  */
 
-#define XEN_VIRT_START         _AT(vaddr_t,0x00200000)
-#define FIXMAP_ADDR(n)        (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE)
+#define XEN_VIRT_START          _AT(vaddr_t, MB(2))
+#define XEN_VIRT_SIZE           _AT(vaddr_t, MB(2))
 
-#define BOOT_FDT_VIRT_START    _AT(vaddr_t,0x00600000)
-#define BOOT_FDT_VIRT_SIZE     _AT(vaddr_t, MB(4))
+#define FIXMAP_VIRT_START       (XEN_VIRT_START + XEN_VIRT_SIZE)
+#define FIXMAP_VIRT_SIZE        _AT(vaddr_t, MB(2))
+
+#define FIXMAP_ADDR(n)          (FIXMAP_VIRT_START + (n) * PAGE_SIZE)
+
+#define BOOT_FDT_VIRT_START     (FIXMAP_VIRT_START + FIXMAP_VIRT_SIZE)
+#define BOOT_FDT_VIRT_SIZE      _AT(vaddr_t, MB(4))
 
 #ifdef CONFIG_LIVEPATCH
-#define LIVEPATCH_VMAP_START   _AT(vaddr_t,0x00a00000)
+#define LIVEPATCH_VMAP_START    (BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE)
 #define LIVEPATCH_VMAP_SIZE    _AT(vaddr_t, MB(2))
 #endif
 
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428302.678345 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG38-0006SN-NO; Sat, 22 Oct 2022 15:04:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428302.678345; Sat, 22 Oct 2022 15:04:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG38-0006Rj-GT; Sat, 22 Oct 2022 15:04:34 +0000
Received: by outflank-mailman (input) for mailman id 428302;
 Sat, 22 Oct 2022 15:04:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG37-0006ER-Oi
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG37-0005FJ-E9; Sat, 22 Oct 2022 15:04:33 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG37-00023n-2c; Sat, 22 Oct 2022 15:04:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=COY44H32x9kH/5zABdsyCdrltsywfscNwpMjZ93lTes=; b=SmHLcaOwqGyhAlfIGviJS/KwBm
	EJ8Wz2gTn2egYr/gUfOxOQKXs8Da+z+8+NZm5T4kIcf9BGpviwGMgO155jS2t2O9lDR7JBJv24KKP
	YcvjbHHVunJUFWlShjTni5953qd5nt7wmhC9qhKfuOw4IMKA3qXkOmD6DchhN/3yIBTA=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load Xen
Date: Sat, 22 Oct 2022 16:04:14 +0100
Message-Id: <20221022150422.17707-5-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

At the moment, bootloaders can load Xen anywhere in memory but the
region 2MB - 4MB. While I am not aware of any issue, we have no way
to tell the bootloader to avoid that region.

In addition to that, in the future, Xen may grow over 2MB if we
enable feature like UBSAN or GCOV. To avoid widening the restriction
on the load address, it would be better to get rid of it.

When the identity mapping is clashing with the Xen runtime mapping,
we need an extra indirection to be able to replace the identity
mapping with the Xen runtime mapping.

Reserve a new memory region that will be used to temporarily map Xen.
For convenience, the new area is re-using the same first slot as the
domheap which is used for per-cpu temporary mapping after a CPU has
booted.

Furthermore, directly map boot_second (which cover Xen and more)
to the temporary area. This will avoid to allocate an extra page-table
for the second-level and will helpful for follow-up patches (we will
want to use the fixmap whilst in the temporary mapping).

Lastly, some part of the code now needs to know whether the temporary
mapping was created. So reserve r12 to store this information.

Signed-off-by: Julien Grall <jgrall@amazon.com>
----

    Changes in v2:
        - Patch added
---
 xen/arch/arm/arm32/head.S         | 139 ++++++++++++++++++++++++++----
 xen/arch/arm/domain_page.c        |   9 ++
 xen/arch/arm/include/asm/config.h |  14 +++
 xen/arch/arm/mm.c                 |  14 +++
 4 files changed, 161 insertions(+), 15 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index aeaa8d105aeb..54725c90993c 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -35,6 +35,9 @@
 #define XEN_FIRST_SLOT      first_table_offset(XEN_VIRT_START)
 #define XEN_SECOND_SLOT     second_table_offset(XEN_VIRT_START)
 
+/* Offset between the early boot xen mapping and the runtime xen mapping */
+#define XEN_TEMPORARY_OFFSET      (TEMPORARY_XEN_VIRT_START - XEN_VIRT_START)
+
 #if defined(CONFIG_EARLY_PRINTK) && defined(CONFIG_EARLY_PRINTK_INC)
 #include CONFIG_EARLY_PRINTK_INC
 #endif
@@ -95,7 +98,7 @@
  *   r9  - paddr(start)
  *   r10 - phys offset
  *   r11 - UART address
- *   r12 -
+ *   r12 - Temporary mapping created
  *   r13 - SP
  *   r14 - LR
  *   r15 - PC
@@ -447,6 +450,9 @@ ENDPROC(cpu_init)
  *   r9 : paddr(start)
  *   r10: phys offset
  *
+ * Output:
+ *   r12: Was a temporary mapping created?
+ *
  * Clobbers r0 - r4, r6
  *
  * Register usage within this function:
@@ -486,7 +492,11 @@ create_page_tables:
         /*
          * Setup the 1:1 mapping so we can turn the MMU on. Note that
          * only the first page of Xen will be part of the 1:1 mapping.
+         *
+         * In all the cases, we will link boot_third_id. So create the
+         * mapping in advance.
          */
+        create_mapping_entry boot_third_id, r9, r9
 
         /*
          * Find the first slot used. If the slot is not XEN_FIRST_SLOT,
@@ -503,8 +513,7 @@ create_page_tables:
         /*
          * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the
          * 1:1 mapping will use its own set of page-tables from the
-         * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle
-         * it.
+         * third level.
          */
         get_table_slot r1, r9, 2     /* r1 := second slot */
         cmp   r1, #XEN_SECOND_SLOT
@@ -515,13 +524,33 @@ create_page_tables:
 link_from_second_id:
         create_table_entry boot_second_id, boot_third_id, r9, 2
 link_from_third_id:
-        create_mapping_entry boot_third_id, r9, r9
+        /* Good news, we are not clashing with Xen virtual mapping */
+        mov   r12, #0                /* r12 := temporary mapping not created */
         mov   pc, lr
 
 virtphys_clash:
-        /* Identity map clashes with boot_third, which we cannot handle yet */
-        PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n")
-        b     fail
+        /*
+         * The identity map clashes with boot_third. Link boot_first_id and
+         * map Xen to a temporary mapping. See switch_to_runtime_mapping
+         * for more details.
+         */
+        PRINT("- Virt and Phys addresses clash  -\r\n")
+        PRINT("- Create temporary mapping -\r\n")
+
+        /*
+         * This will override the link to boot_second in XEN_FIRST_SLOT.
+         * The page-tables are not live yet. So no need to use
+         * break-before-make.
+         */
+        create_table_entry boot_pgtable, boot_second_id, r9, 1
+        create_table_entry boot_second_id, boot_third_id, r9, 2
+
+        /* Map boot_second (cover Xen mappings) to the temporary 1st slot */
+        mov_w r0, TEMPORARY_XEN_VIRT_START
+        create_table_entry boot_pgtable, boot_second, r0, 1
+
+        mov   r12, #1                /* r12 := temporary mapping created */
+        mov   pc, lr
 ENDPROC(create_page_tables)
 
 /*
@@ -530,9 +559,10 @@ ENDPROC(create_page_tables)
  *
  * Inputs:
  *   r9 : paddr(start)
+ *  r12 : Was the temporary mapping created?
  *   lr : Virtual address to return to
  *
- * Clobbers r0 - r3
+ * Clobbers r0 - r5
  */
 enable_mmu:
         PRINT("- Turning on paging -\r\n")
@@ -560,21 +590,79 @@ enable_mmu:
          * The MMU is turned on and we are in the 1:1 mapping. Switch
          * to the runtime mapping.
          */
-        mov_w r0, 1f
-        mov   pc, r0
+        mov   r5, lr                /* Save LR before overwritting it */
+        mov_w lr, 1f                /* Virtual address in the runtime mapping */
+        b     switch_to_runtime_mapping
 1:
+        mov   lr, r5                /* Restore LR */
         /*
-         * The 1:1 map may clash with other parts of the Xen virtual memory
-         * layout. As it is not used anymore, remove it completely to
-         * avoid having to worry about replacing existing mapping
-         * afterwards.
+         * At this point, either the 1:1 map or the temporary mapping
+         * will be present. The former may clash with other parts of the
+         * Xen virtual memory layout. As both of them are not used
+         * anymore, remove them completely to avoid having to worry
+         * about replacing existing mapping afterwards.
          *
          * On return this will jump to the virtual address requested by
          * the caller.
          */
-        b     remove_identity_mapping
+        teq   r12, #0
+        beq   remove_identity_mapping
+        b     remove_temporary_mapping
 ENDPROC(enable_mmu)
 
+/*
+ * Switch to the runtime mapping. The logic depends on whether the
+ * runtime virtual region is clashing with the physical address
+ *
+ *  - If it is not clashing, we can directly jump to the address in
+ *    the runtime mapping.
+ *  - If it is clashing, create_page_tables() would have mapped Xen to
+ *    a temporary virtual address. We need to switch to the temporary
+ *    mapping so we can remove the identity mapping and map Xen at the
+ *    correct position.
+ *
+ * Inputs
+ *    r9: paddr(start)
+ *   r12: Was a temporary mapping created?
+ *    lr: Address in the runtime mapping to jump to
+ *
+ * Clobbers r0 - r4
+ */
+switch_to_runtime_mapping:
+        /*
+         * Jump to the runtime mapping if the virt and phys are not
+         * clashing
+         */
+        teq   r12, #0
+        beq   ready_to_switch
+
+        /* We are still in the 1:1 mapping. Jump to the temporary Virtual address. */
+        mov_w r0, 1f
+        add   r0, r0, #XEN_TEMPORARY_OFFSET /* r0 := address in temporary mapping */
+        mov   pc, r0
+
+1:
+        /* Remove boot_second_id */
+        mov   r2, #0
+        mov   r3, #0
+        adr_l r0, boot_pgtable
+        get_table_slot r1, r9, 1            /* r1 := first slot */
+        lsl   r1, r1, #3                    /* r1 := first slot offset */
+        strd  r2, r3, [r0, r1]
+
+        flush_xen_tlb_local r0
+
+        /* Map boot_second into boot_pgtable */
+        mov_w r0, XEN_VIRT_START
+        create_table_entry boot_pgtable, boot_second, r0, 1
+
+        /* Ensure any page table updates are visible before continuing */
+        dsb   nsh
+
+ready_to_switch:
+        mov   pc, lr
+ENDPROC(switch_to_runtime_mapping)
+
 /*
  * Remove the 1:1 map from the page-tables. It is not easy to keep track
  * where the 1:1 map was mapped, so we will look for the top-level entry
@@ -620,6 +708,27 @@ identity_mapping_removed:
         mov   pc, lr
 ENDPROC(remove_identity_mapping)
 
+/*
+ * Remove the temporary mapping of Xen starting at TEMPORARY_XEN_VIRT_START.
+ *
+ * Clobbers r0 - r1
+ */
+remove_temporary_mapping:
+        /* r2:r3 := invalid page-table entry */
+        mov   r2, #0
+        mov   r3, #0
+
+        adr_l r0, boot_pgtable
+        mov_w r1, TEMPORARY_XEN_VIRT_START
+        get_table_slot r1, r1, 1     /* r1 := first slot */
+        lsl   r1, r1, #3             /* r1 := first slot offset */
+        strd  r2, r3, [r0, r1]
+
+        flush_xen_tlb_local r0
+
+        mov  pc, lr
+ENDPROC(remove_temporary_mapping)
+
 /*
  * Map the UART in the fixmap (when earlyprintk is used) and hook the
  * fixmap table in the page tables.
diff --git a/xen/arch/arm/domain_page.c b/xen/arch/arm/domain_page.c
index 71182575f95a..3c59db697f26 100644
--- a/xen/arch/arm/domain_page.c
+++ b/xen/arch/arm/domain_page.c
@@ -58,7 +58,16 @@ bool init_domheap_mappings(unsigned int cpu)
     first_idx = first_table_offset(DOMHEAP_VIRT_START);
     for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ )
     {
+        lpae_t *entry = &root[first_idx + i];
         lpae_t pte = mfn_to_xen_entry(mfn_add(mfn, i), MT_NORMAL);
+
+        /*
+         * The domheap is overlapping with the temporary Xen mapping and
+         * the boot code is responsible to remove the latter mapping.
+         * So we can avoid break-before-make here.
+         */
+        ASSERT(!lpae_is_valid(*entry));
+
         pte.pt.table = 1;
         write_pte(&root[first_idx + i], pte);
     }
diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 80d81f127f7e..f381c471f67a 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -148,6 +148,20 @@
 /* Number of domheap pagetable pages required at the second level (2MB mappings) */
 #define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT)
 
+/*
+ * The temporary area is overlapping with the domheap area. This may
+ * be used to create an alias of the first slot containing Xen mappings
+ * when turning on/off the MMU.
+ */
+#define TEMPORARY_AREA_FIRST_SLOT    (first_table_offset(DOMHEAP_VIRT_START))
+
+/* Calculate the address in the temporary area */
+#define TEMPORARY_AREA_ADDR(addr)                           \
+     (((addr) & ~XEN_PT_LEVEL_MASK(1)) |                    \
+      (TEMPORARY_AREA_FIRST_SLOT << XEN_PT_LEVEL_SHIFT(1)))
+
+#define TEMPORARY_XEN_VIRT_START    TEMPORARY_AREA_ADDR(XEN_VIRT_START)
+
 #else /* ARM_64 */
 
 #define SLOT0_ENTRY_BITS  39
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 6ccffeaea57d..726211c77917 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -176,6 +176,9 @@ static void __init __maybe_unused build_assertions(void)
 #define CHECK_SAME_SLOT(level, virt1, virt2) \
     BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2))
 
+#define CHECK_DIFFERENT_SLOT(level, virt1, virt2) \
+    BUILD_BUG_ON(level##_table_offset(virt1) == level##_table_offset(virt2))
+
 #ifdef CONFIG_ARM_64
     CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0));
     CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START);
@@ -183,7 +186,18 @@ static void __init __maybe_unused build_assertions(void)
     CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0));
     CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START);
 
+    /*
+     * For arm32, the temporary mapping will re-use the domheap
+     * first slot and the second slots will match.
+     */
+#ifdef CONFIG_ARM_32
+    CHECK_SAME_SLOT(first, TEMPORARY_XEN_VIRT_START, DOMHEAP_VIRT_START);
+    CHECK_DIFFERENT_SLOT(first, XEN_VIRT_START, TEMPORARY_XEN_VIRT_START);
+    CHECK_SAME_SLOT(second, XEN_VIRT_START, TEMPORARY_XEN_VIRT_START);
+#endif
+
 #undef CHECK_SAME_SLOT
+#undef CHECK_DIFFERENT_SLOT
 }
 
 void dump_pt_walk(paddr_t ttbr, paddr_t addr,
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428303.678356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3B-0006oc-0g; Sat, 22 Oct 2022 15:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428303.678356; Sat, 22 Oct 2022 15:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3A-0006oC-SU; Sat, 22 Oct 2022 15:04:36 +0000
Received: by outflank-mailman (input) for mailman id 428303;
 Sat, 22 Oct 2022 15:04:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG39-0006dX-68
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG38-0005Fe-PM; Sat, 22 Oct 2022 15:04:34 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG38-00023n-HR; Sat, 22 Oct 2022 15:04:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=U7Bs1tv4lv2AoxbGaVwYFTs7PIaGixTCOovZNTpsEgM=; b=kK2i5xvpxX4Nmrs+NH1/2f+vlF
	R9lXFaAX6GoByLqMYcRmDC3Kch4F3R2zRMWAApxMuBofLeluTGCXpFYoW6dqUsGUcwJ5wsQwVXeYk
	hn7odKv8glHnWN6+aNt+tvNzYf/GgL6hXIZ2SUtsciItctg04CgpSXONjBAymjX280rU=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 05/12] xen/arm32: head: Widen the use of the temporary mapping
Date: Sat, 22 Oct 2022 16:04:15 +0100
Message-Id: <20221022150422.17707-6-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

At the moment, the temporary mapping is only used when the virtual
runtime region of Xen is clashing with the physical region.

In follow-up patches, we will rework how secondary CPU bring-up works
and it will be convenient to use the fixmap area for accessing
the root page-table (it is per-cpu).

Rework the code to use temporary mapping when the Xen physical address
is not overlapping with the temporary mapping.

This also has the advantage to simplify the logic to identity map
Xen.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----

Even if this patch is rewriting part of the previous patch, I decided
to keep them separated to help the review.

The "folow-up patches" are still in draft at the moment. I still haven't
find a way to split them nicely and not require too much more work
in the coloring side.

I have provided some medium-term goal in the cover letter.

    Changes in v2:
        - Patch added
---
 xen/arch/arm/arm32/head.S | 82 +++++++--------------------------------
 1 file changed, 15 insertions(+), 67 deletions(-)

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 54725c90993c..e5df7cf757db 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -461,7 +461,6 @@ ENDPROC(cpu_init)
 create_page_tables:
         /* Prepare the page-tables for mapping Xen */
         ldr   r0, =XEN_VIRT_START
-        create_table_entry boot_pgtable, boot_second, r0, 1
         create_table_entry boot_second, boot_third, r0, 2
 
         /* Setup boot_third: */
@@ -481,67 +480,37 @@ create_page_tables:
         cmp   r1, #(XEN_PT_LPAE_ENTRIES<<3) /* 512*8-byte entries per page */
         blo   1b
 
-        /*
-         * If Xen is loaded at exactly XEN_VIRT_START then we don't
-         * need an additional 1:1 mapping, the virtual mapping will
-         * suffice.
-         */
-        cmp   r9, #XEN_VIRT_START
-        moveq pc, lr
-
         /*
          * Setup the 1:1 mapping so we can turn the MMU on. Note that
          * only the first page of Xen will be part of the 1:1 mapping.
-         *
-         * In all the cases, we will link boot_third_id. So create the
-         * mapping in advance.
          */
+        create_table_entry boot_pgtable, boot_second_id, r9, 1
+        create_table_entry boot_second_id, boot_third_id, r9, 2
         create_mapping_entry boot_third_id, r9, r9
 
         /*
-         * Find the first slot used. If the slot is not XEN_FIRST_SLOT,
-         * then the 1:1 mapping will use its own set of page-tables from
-         * the second level.
+         * Find the first slot used. If the slot is not the same
+         * as XEN_TMP_FIRST_SLOT, then we will want to switch
+         * to the temporary mapping before jumping to the runtime
+         * virtual mapping.
          */
         get_table_slot r1, r9, 1     /* r1 := first slot */
-        cmp   r1, #XEN_FIRST_SLOT
-        beq   1f
-        create_table_entry boot_pgtable, boot_second_id, r9, 1
-        b     link_from_second_id
-
-1:
-        /*
-         * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the
-         * 1:1 mapping will use its own set of page-tables from the
-         * third level.
-         */
-        get_table_slot r1, r9, 2     /* r1 := second slot */
-        cmp   r1, #XEN_SECOND_SLOT
-        beq   virtphys_clash
-        create_table_entry boot_second, boot_third_id, r9, 2
-        b     link_from_third_id
+        cmp   r1, #TEMPORARY_AREA_FIRST_SLOT
+        bne   use_temporary_mapping
 
-link_from_second_id:
-        create_table_entry boot_second_id, boot_third_id, r9, 2
-link_from_third_id:
-        /* Good news, we are not clashing with Xen virtual mapping */
+        mov_w r0, XEN_VIRT_START
+        create_table_entry boot_pgtable, boot_second, r0, 1
         mov   r12, #0                /* r12 := temporary mapping not created */
         mov   pc, lr
 
-virtphys_clash:
+use_temporary_mapping:
         /*
-         * The identity map clashes with boot_third. Link boot_first_id and
-         * map Xen to a temporary mapping. See switch_to_runtime_mapping
-         * for more details.
+         * The identity mapping is not using the first slot
+         * TEMPORARY_AREA_FIRST_SLOT. Create a temporary mapping.
+         * See switch_to_runtime_mapping for more details.
          */
-        PRINT("- Virt and Phys addresses clash  -\r\n")
         PRINT("- Create temporary mapping -\r\n")
 
-        /*
-         * This will override the link to boot_second in XEN_FIRST_SLOT.
-         * The page-tables are not live yet. So no need to use
-         * break-before-make.
-         */
         create_table_entry boot_pgtable, boot_second_id, r9, 1
         create_table_entry boot_second_id, boot_third_id, r9, 2
 
@@ -677,33 +646,12 @@ remove_identity_mapping:
         /* r2:r3 := invalid page-table entry */
         mov   r2, #0x0
         mov   r3, #0x0
-        /*
-         * Find the first slot used. Remove the entry for the first
-         * table if the slot is not XEN_FIRST_SLOT.
-         */
+        /* Find the first slot used and remove it */
         get_table_slot r1, r9, 1     /* r1 := first slot */
-        cmp   r1, #XEN_FIRST_SLOT
-        beq   1f
-        /* It is not in slot 0, remove the entry */
         ldr   r0, =boot_pgtable      /* r0 := root table */
         lsl   r1, r1, #3             /* r1 := Slot offset */
         strd  r2, r3, [r0, r1]
-        b     identity_mapping_removed
-
-1:
-        /*
-         * Find the second slot used. Remove the entry for the first
-         * table if the slot is not XEN_SECOND_SLOT.
-         */
-        get_table_slot r1, r9, 2     /* r1 := second slot */
-        cmp   r1, #XEN_SECOND_SLOT
-        beq   identity_mapping_removed
-        /* It is not in slot 1, remove the entry */
-        ldr   r0, =boot_second       /* r0 := second table */
-        lsl   r1, r1, #3             /* r1 := Slot offset */
-        strd  r2, r3, [r0, r1]
 
-identity_mapping_removed:
         flush_xen_tlb_local r0
         mov   pc, lr
 ENDPROC(remove_identity_mapping)
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428304.678362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3B-0006up-ML; Sat, 22 Oct 2022 15:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428304.678362; Sat, 22 Oct 2022 15:04:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3B-0006tk-F6; Sat, 22 Oct 2022 15:04:37 +0000
Received: by outflank-mailman (input) for mailman id 428304;
 Sat, 22 Oct 2022 15:04:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG3A-0006nJ-HK
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3A-0005Fw-4X; Sat, 22 Oct 2022 15:04:36 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG39-00023n-St; Sat, 22 Oct 2022 15:04:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=8XRbJOwi2jcZkrnNl+I4D+X7AdFfSZzKWbgWtXj+qTs=; b=UKYz+4aJuQvus7mvCVGx9PT7rC
	AJ399U6sxnXab7b2gduyVC240QlG+h6PGvBK3OFy9ftrECkIS4dNxoBDKMQSRyS5UCgOobqiHaISe
	lP22AtQCYiz7v5vFXHlIvwvGdj69OFoz3G2LIeBxy3xzy7KUa9S6hEk8rwXvUM0Ems50=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 06/12] xen/arm: Enable use of dump_pt_walk() early during boot
Date: Sat, 22 Oct 2022 16:04:16 +0100
Message-Id: <20221022150422.17707-7-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

At the moment, dump_pt_walk() is using map_domain_page() to map
the page tables.

map_domain_page() is only usuable after init_domheap_mappings() is called
(arm32) or the xenheap has been initialized (arm64).

This means it can be hard to diagnose incorrect page-tables during
early boot. So update dump_pt_walk() to xen_{, un}map_table() instead.

Note that the two helpers are moved earlier to avoid forward declaring
them.

Signed-off-by: Julien Grall <jgrall@amazon.com>
---
 xen/arch/arm/mm.c | 56 +++++++++++++++++++++++------------------------
 1 file changed, 28 insertions(+), 28 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 726211c77917..306507d7bced 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -200,6 +200,30 @@ static void __init __maybe_unused build_assertions(void)
 #undef CHECK_DIFFERENT_SLOT
 }
 
+static lpae_t *xen_map_table(mfn_t mfn)
+{
+    /*
+     * During early boot, map_domain_page() may be unusable. Use the
+     * PMAP to map temporarily a page-table.
+     */
+    if ( system_state == SYS_STATE_early_boot )
+        return pmap_map(mfn);
+
+    return map_domain_page(mfn);
+}
+
+static void xen_unmap_table(const lpae_t *table)
+{
+    /*
+     * During early boot, xen_map_table() will not use map_domain_page()
+     * but the PMAP.
+     */
+    if ( system_state == SYS_STATE_early_boot )
+        pmap_unmap(table);
+    else
+        unmap_domain_page(table);
+}
+
 void dump_pt_walk(paddr_t ttbr, paddr_t addr,
                   unsigned int root_level,
                   unsigned int nr_root_tables)
@@ -239,7 +263,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
     else
         root_table = 0;
 
-    mapping = map_domain_page(mfn_add(root_mfn, root_table));
+    mapping = xen_map_table(mfn_add(root_mfn, root_table));
 
     for ( level = root_level; ; level++ )
     {
@@ -255,11 +279,11 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
             break;
 
         /* For next iteration */
-        unmap_domain_page(mapping);
-        mapping = map_domain_page(lpae_get_mfn(pte));
+        xen_unmap_table(mapping);
+        mapping = xen_map_table(lpae_get_mfn(pte));
     }
 
-    unmap_domain_page(mapping);
+    xen_unmap_table(mapping);
 }
 
 void dump_hyp_walk(vaddr_t addr)
@@ -722,30 +746,6 @@ void *ioremap(paddr_t pa, size_t len)
     return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
 }
 
-static lpae_t *xen_map_table(mfn_t mfn)
-{
-    /*
-     * During early boot, map_domain_page() may be unusable. Use the
-     * PMAP to map temporarily a page-table.
-     */
-    if ( system_state == SYS_STATE_early_boot )
-        return pmap_map(mfn);
-
-    return map_domain_page(mfn);
-}
-
-static void xen_unmap_table(const lpae_t *table)
-{
-    /*
-     * During early boot, xen_map_table() will not use map_domain_page()
-     * but the PMAP.
-     */
-    if ( system_state == SYS_STATE_early_boot )
-        pmap_unmap(table);
-    else
-        unmap_domain_page(table);
-}
-
 static int create_xen_table(lpae_t *entry)
 {
     mfn_t mfn;
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428305.678377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3D-0007M6-7S; Sat, 22 Oct 2022 15:04:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428305.678377; Sat, 22 Oct 2022 15:04:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3D-0007Je-1d; Sat, 22 Oct 2022 15:04:39 +0000
Received: by outflank-mailman (input) for mailman id 428305;
 Sat, 22 Oct 2022 15:04:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG3B-0006xc-OL
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3B-0005GJ-Fz; Sat, 22 Oct 2022 15:04:37 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3B-00023n-86; Sat, 22 Oct 2022 15:04:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=0MRxjTuvfQiTLB/kIf7fSXALDQ1KnZVYj+vhcIohuOE=; b=rM7ghcJUdNowXvTueGCjJqyj5+
	v9zPM4JYS0HUsH19D3efvdwXml/y22vUt55Do6WG0EzL0wG6/3so5RvFCbP5MaJUFD7+oBkWYVCG7
	dVzCziZM8CsuOO2ZHBFUfNksBMY98pVi6X+FsyLialsEKeGspq8RUgd7pa/N/VQmkZY8=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 07/12] xen/arm64: Rework the memory layout
Date: Sat, 22 Oct 2022 16:04:17 +0100
Message-Id: <20221022150422.17707-8-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Xen is currently not fully compliant with the Arm Arm because it will
switch the TTBR with the MMU on.

In order to be compliant, we need to disable the MMU before
switching the TTBR. The implication is the page-tables should
contain an identity mapping of the code switching the TTBR.

In most of the case we expect Xen to be loaded in low memory. I am aware
of one platform (i.e AMD Seattle) where the memory start above 512GB.
To give us some slack, consider that Xen may be loaded in the first 2TB
of the physical address space.

The memory layout is reshuffled to keep the first two slots of the zeroeth
level free. Xen will now be loaded at (2TB + 2MB). This requires a slight
tweak of the boot code because XEN_VIRT_START cannot be used as an
immediate.

This reshuffle will make trivial to create a 1:1 mapping when Xen is
loaded below 2TB.

Signed-off-by: Julien Grall <jgrall@amazon.com>
----

    Changes in v2:
        - Reword the commit message
        - Load Xen at 2TB + 2MB
        - Update the documentation to reflect the new layout
---
 xen/arch/arm/arm64/head.S         |  3 ++-
 xen/arch/arm/include/asm/config.h | 34 +++++++++++++++++++++----------
 xen/arch/arm/mm.c                 | 11 +++++-----
 3 files changed, 31 insertions(+), 17 deletions(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index ad014716db6f..23c2c7491db2 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -607,7 +607,8 @@ create_page_tables:
          * need an additional 1:1 mapping, the virtual mapping will
          * suffice.
          */
-        cmp   x19, #XEN_VIRT_START
+        ldr   x0, =XEN_VIRT_START
+        cmp   x19, x0
         bne   1f
         ret
 1:
diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index f381c471f67a..0ed9a0505080 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -72,15 +72,12 @@
 #include <xen/page-size.h>
 
 /*
- * Common ARM32 and ARM64 layout:
+ * ARM32 layout:
  *   0  -   2M   Unmapped
  *   2M -   4M   Xen text, data, bss
  *   4M -   6M   Fixmap: special-purpose 4K mapping slots
  *   6M -  10M   Early boot mapping of FDT
- *   10M - 12M   Livepatch vmap (if compiled in)
- *
- * ARM32 layout:
- *   0  -  12M   <COMMON>
+ *  10M -  12M   Livepatch vmap (if compiled in)
  *
  *  32M - 128M   Frametable: 24 bytes per page for 16GB of RAM
  * 256M -   1G   VMAP: ioremap and early_ioremap use this virtual address
@@ -90,8 +87,17 @@
  *   2G -   4G   Domheap: on-demand-mapped
  *
  * ARM64 layout:
- * 0x0000000000000000 - 0x0000007fffffffff (512GB, L0 slot [0])
- *   0  -  12M   <COMMON>
+ * 0x0000000000000000 - 0x00001fffffffffff (2TB, L0 slots [0..1])
+ *
+ *  Reserved to identity map Xen
+ *
+ * 0x0000020000000000 - 0x000028fffffffff (512TB, L0 slot [2]
+ *  (Relative offsets)
+ *   0  -   2M   Unmapped
+ *   2M -   4M   Xen text, data, bss
+ *   4M -   6M   Fixmap: special-purpose 4K mapping slots
+ *   6M -  10M   Early boot mapping of FDT
+ *  10M -  12M   Livepatch vmap (if compiled in)
  *
  *   1G -   2G   VMAP: ioremap and early_ioremap
  *
@@ -107,7 +113,17 @@
  *  Unused
  */
 
+#ifdef CONFIG_ARM_32
 #define XEN_VIRT_START          _AT(vaddr_t, MB(2))
+#else
+
+#define SLOT0_ENTRY_BITS  39
+#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS)
+#define SLOT0_ENTRY_SIZE  SLOT0(1)
+
+#define XEN_VIRT_START          (SLOT0(2) + _AT(vaddr_t, MB(2)))
+#endif
+
 #define XEN_VIRT_SIZE           _AT(vaddr_t, MB(2))
 
 #define FIXMAP_VIRT_START       (XEN_VIRT_START + XEN_VIRT_SIZE)
@@ -164,10 +180,6 @@
 
 #else /* ARM_64 */
 
-#define SLOT0_ENTRY_BITS  39
-#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS)
-#define SLOT0_ENTRY_SIZE  SLOT0(1)
-
 #define VMAP_VIRT_START  GB(1)
 #define VMAP_VIRT_SIZE   GB(1)
 
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 306507d7bced..2c6648a0dfe5 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -162,7 +162,7 @@ static void __init __maybe_unused build_assertions(void)
 #endif
     /* Page table structure constraints */
 #ifdef CONFIG_ARM_64
-    BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START));
+    BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START) < 2);
 #endif
     BUILD_BUG_ON(first_table_offset(XEN_VIRT_START));
 #ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE
@@ -507,10 +507,11 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
     phys_offset = boot_phys_offset;
 
 #ifdef CONFIG_ARM_64
-    p = (void *) xen_pgtable;
-    p[0] = pte_of_xenaddr((uintptr_t)xen_first);
-    p[0].pt.table = 1;
-    p[0].pt.xn = 0;
+    pte = pte_of_xenaddr((uintptr_t)xen_first);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+    xen_pgtable[zeroeth_table_offset(XEN_VIRT_START)] = pte;
+
     p = (void *) xen_first;
 #else
     p = (void *) cpu0_pgtable;
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428306.678389 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3F-0007lE-MG; Sat, 22 Oct 2022 15:04:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428306.678389; Sat, 22 Oct 2022 15:04:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3F-0007kr-H0; Sat, 22 Oct 2022 15:04:41 +0000
Received: by outflank-mailman (input) for mailman id 428306;
 Sat, 22 Oct 2022 15:04:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG3D-0007LY-2Q
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3C-0005Gl-SC; Sat, 22 Oct 2022 15:04:38 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3C-00023n-JX; Sat, 22 Oct 2022 15:04:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=FEIsx7P9nZwfhR6xy4wYJJIBI7buDF20ZIDRCCQ1MYk=; b=EatH+9nm1S1uIelLBdQIeXVRJ4
	f7zaA7/xk+M+MQOR98qi1v9Byaqm9xw9K6k9LO6I9xEo6tKATcjm72OvAattDy2JmT5O8L2hBxhuO
	03Ik17exSeiPixty5vcnvXHtjceMVANEz/C8/XUsokoQJpR2K+ylKzUyTq/3ROnoaXzQ=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 08/12] xen/arm: mm: Allow xen_pt_update() to work with the current root table
Date: Sat, 22 Oct 2022 16:04:18 +0100
Message-Id: <20221022150422.17707-9-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

At the moment, xen_pt_update() will only work on the runtime page tables.
In follow-up patches, we will also want to use the helper to update
the boot page tables.

All the existing callers of xen_pt_update() expects to modify the
current page-tables. Therefore, we can read the root physical address
directly from TTBR0_EL2.

Signed-off-by: Julien Grall <jgrall@amazon.com>
----

    Changes in v2:
        - Patch added
---
 xen/arch/arm/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 2c6648a0dfe5..a3f604e0e2d1 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1123,7 +1123,7 @@ static int xen_pt_update(unsigned long virt,
      *
      * XXX: Add a check.
      */
-    const mfn_t root = virt_to_mfn(THIS_CPU_PGTABLE);
+    const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2));
 
     /*
      * The hardware was configured to forbid mapping both writeable and
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:04:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:04:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428307.678394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3G-0007qe-5i; Sat, 22 Oct 2022 15:04:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428307.678394; Sat, 22 Oct 2022 15:04:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omG3F-0007oo-VC; Sat, 22 Oct 2022 15:04:41 +0000
Received: by outflank-mailman (input) for mailman id 428307;
 Sat, 22 Oct 2022 15:04:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omG3E-0007gb-Il
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:04:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3E-0005H7-6c; Sat, 22 Oct 2022 15:04:40 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3D-00023n-V0; Sat, 22 Oct 2022 15:04:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=cCCPY4hyDMzYl29pMvx1V2vjkyKfUtThF9ZI50ioPPg=; b=2pDcZnOEQPUMqLTt7QRQS/Nzb4
	FG+xo4CXu/YaYcqdqOJyQARfqf4t2VknXwgLGAdda97ep0goRCcdPJ8I0/StIPPr8jGik/gnzvYuA
	KfZ9q2xaX03idxcOfUoWiR5FeYCm5sueOlI1wdwwXlnsXtnI2MgcZCYS3EZRZ2g8eY4k=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 09/12] xen/arm: mm: Allow dump_hyp_walk() to work on the current root table
Date: Sat, 22 Oct 2022 16:04:19 +0100
Message-Id: <20221022150422.17707-10-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

dump_hyp_walk() is used to print the tables walk in case of the data or
instruction abort.

Those abort are not limited to the runtime and could happen at early
boot. However, the current implementation of dump_hyp_walk() check
that the TTBR matches the runtime page tables.

Therefore, early abort will result to a secondary abort and not
print the table walks.

Given that the function is called in the abort path, there is no
reason for us to keep the BUG_ON() in any form. So drop it.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----
    Changes in v2:
        - Patch added
---
 xen/arch/arm/mm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index a3f604e0e2d1..865780695421 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -289,13 +289,11 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
 void dump_hyp_walk(vaddr_t addr)
 {
     uint64_t ttbr = READ_SYSREG64(TTBR0_EL2);
-    lpae_t *pgtable = THIS_CPU_PGTABLE;
 
     printk("Walking Hypervisor VA 0x%"PRIvaddr" "
            "on CPU%d via TTBR 0x%016"PRIx64"\n",
            addr, smp_processor_id(), ttbr);
 
-    BUG_ON( virt_to_maddr(pgtable) != ttbr );
     dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1);
 }
 
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:13:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:13:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428349.678411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGBd-0003kk-5C; Sat, 22 Oct 2022 15:13:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428349.678411; Sat, 22 Oct 2022 15:13:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGBd-0003kd-1Y; Sat, 22 Oct 2022 15:13:21 +0000
Received: by outflank-mailman (input) for mailman id 428349;
 Sat, 22 Oct 2022 15:13:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omGBb-0003kX-Oa
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:13:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGBb-0005Rg-2a; Sat, 22 Oct 2022 15:13:19 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.29.245]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGBa-0002Xn-RD; Sat, 22 Oct 2022 15:13:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=PV8B+E1FVx9nndajCYva9nue8rk5+yNytWjbDo84q0c=; b=DVpMcAwF1aoRIWyl8u0cLaSwSt
	ctBnPxETgiPgLcQZWlJoRG/r/Sexc3S6Jhqyyzkvugs6gX0Ffr9bcpY5wItDW7m4SMk2ekcYnyQBL
	CRdkK1/am+WZWIoH+cIqsNk/038uAliQF/a4P0rqWFAkY85hJ9pU2TIAJfuho91o763g=;
Message-ID: <e1b35ac1-d413-6a08-d5c0-9b2ce43aea17@xen.org>
Date: Sat, 22 Oct 2022 16:13:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH 00/12] Arm cache coloring
Content-Language: en-US
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Carlo,

On 26/08/2022 13:50, Carlo Nonato wrote:
> - The way xl passes user space memory to Xen it's adapted from various
>    points of the xl code itself (e.g. xc_domain_node_setaffinity) and it
>    works, but it really needs attention from expert maintainers since
>    I'm not completely sure this is the correct way of doing things.
> - We still need to bring back the relocation feature (part of) in order
>    to move Xen memory to a colored space where the hypervisor could be
>    isolated from VMs interference (see the revert commit #10 and the
>    get_xen_paddr function in #12).
> - Revert commits #8 and #9 are needed because coloring has the command
>    line parsing as a prerequisite for its initialization and
>    setup_pagetables must be called after it in order to color the Xen
>    mapping. The DTB mapping is then added to the boot page tables instead
>    of the Xen ones. Probably the way this is done is a bit simplistic.
>    Looking forward for comments on the subject.
> - A temporary mapping of the old Xen code (old here means non-colored)
>    is used to reach variables in the old physical space so that secondary
>    CPUs can boot. There were some comments in the previous version on that
>    because the mapping is available for all the CPUs while only CPU0 is
>    the one supposed to access it. I'm not sure how to temporarily mapping
>    things only for the master CPU.

On Arm64, Xen will only use one set of page-tables for all the CPUs. So 
it will not be possible to have a temporary mapping for a single CPU. 
But what you can do is mapping the region and unmapping it when you are 
done.

That said, I would rather prefer if we can get rid of the old copy of 
Xen. This would means secondary CPUs will directly jump to the new Xen.

> - A lot of #ifdef for cache coloring are introduced because I prefer to
>    define functions only if they are actually needed. Let me know if you
>    prefer a different approach.

The preferred approach in Xen is to provide stub helpers in the #else part.

> - Julien posted an RFC to address a problem with the switch_ttbr function.
>    For the moment I haven't considered it since it's still a work in progress.

I have posted a new version for this:

https://lore.kernel.org/xen-devel/20221022150422.17707-1-julien@xen.org/

There are a couple of open questions about the interaction with cache 
coloring. Please have a look there.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:18:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:18:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428372.678432 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGH2-0004c9-9n; Sat, 22 Oct 2022 15:18:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428372.678432; Sat, 22 Oct 2022 15:18:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGH2-0004Z5-57; Sat, 22 Oct 2022 15:18:56 +0000
Received: by outflank-mailman (input) for mailman id 428372;
 Sat, 22 Oct 2022 15:18:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omGH1-0004T0-EP
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:18:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGH1-0005Z7-11; Sat, 22 Oct 2022 15:18:55 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3F-00023n-AF; Sat, 22 Oct 2022 15:04:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=HJNHIwwoqIJiLFkEWC04rmEHTG3YbKX/QqL6kPV2MOA=; b=wzBrGdZs8bcUtG57E0Cdqy9afo
	7x/3ytySeQc7sgoDb/oz0UZ6gdPrhuEJKrlPX0RkwVGxIapW6JZDlBrKOsqnHJiQvNu8LXFIx7PzO
	pOtx7DJX1SYParnFnNdFUacq+eB+XZuoRv1kyvSZKoiURQTG55IhyMnH2gANj8r5offE=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 10/12] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping
Date: Sat, 22 Oct 2022 16:04:20 +0100
Message-Id: <20221022150422.17707-11-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

In follow-up patches we will need to have part of Xen identity mapped in
order to safely switch the TTBR.

On some platform, the identity mapping may have to start at 0. If we always
keep the identity region mapped, NULL pointer dereference would lead to
access to valid mapping.

It would be possible to relocate Xen to avoid clashing with address 0.
However the identity mapping is only meant to be used in very limited
places. Therefore it would be better to keep the identity region invalid
for most of the time.

Two new external helpers are introduced:
    - arch_setup_page_tables() will setup the page-tables so it is
      easy to create the mapping afterwards.
    - update_identity_mapping() will create/remove the identity mapping

Signed-off-by: Julien Grall <jgrall@amazon.com>

----
    Changes in v2:
        - Remove the arm32 part
        - Use a different logic for the boot page tables and runtime
          one because Xen may be running in a different place.
---
 xen/arch/arm/arm64/Makefile         |   1 +
 xen/arch/arm/arm64/mm.c             | 121 ++++++++++++++++++++++++++++
 xen/arch/arm/include/asm/arm32/mm.h |   4 +
 xen/arch/arm/include/asm/arm64/mm.h |  12 +++
 xen/arch/arm/include/asm/setup.h    |  11 +++
 xen/arch/arm/mm.c                   |   6 +-
 6 files changed, 153 insertions(+), 2 deletions(-)
 create mode 100644 xen/arch/arm/arm64/mm.c

diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
index 6d507da0d44d..28481393e98f 100644
--- a/xen/arch/arm/arm64/Makefile
+++ b/xen/arch/arm/arm64/Makefile
@@ -10,6 +10,7 @@ obj-y += entry.o
 obj-y += head.o
 obj-y += insn.o
 obj-$(CONFIG_LIVEPATCH) += livepatch.o
+obj-y += mm.o
 obj-y += smc.o
 obj-y += smpboot.o
 obj-y += traps.o
diff --git a/xen/arch/arm/arm64/mm.c b/xen/arch/arm/arm64/mm.c
new file mode 100644
index 000000000000..9eaf545ea9dd
--- /dev/null
+++ b/xen/arch/arm/arm64/mm.c
@@ -0,0 +1,121 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#include <xen/init.h>
+#include <xen/mm.h>
+
+#include <asm/setup.h>
+
+/* Override macros from asm/page.h to make them work with mfn_t */
+#undef virt_to_mfn
+#define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
+
+static DEFINE_PAGE_TABLE(xen_first_id);
+static DEFINE_PAGE_TABLE(xen_second_id);
+static DEFINE_PAGE_TABLE(xen_third_id);
+
+/*
+ * The identity mapping may start at physical address 0. So we don't want
+ * to keep it mapped longer than necessary.
+ *
+ * When this is called, we are still using the boot_pgtable.
+ *
+ * We need to prepare the identity mapping for both the boot page tables
+ * and runtime page tables.
+ *
+ * The logic to create the entry is slightly different because Xen may
+ * be running at a different location at runtime.
+ */
+static void __init prepare_boot_identity_mapping(void)
+{
+    paddr_t id_addr = virt_to_maddr(_start);
+    lpae_t pte;
+    DECLARE_OFFSETS(id_offsets, id_addr);
+
+    if ( id_offsets[0] != 0 )
+        panic("Cannot handled ID mapping above 512GB\n");
+
+    /* Link first ID table */
+    pte = mfn_to_xen_entry(virt_to_mfn(boot_first_id), MT_NORMAL);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+
+    write_pte(&boot_pgtable[id_offsets[0]], pte);
+
+    /* Link second ID table */
+    pte = mfn_to_xen_entry(virt_to_mfn(boot_second_id), MT_NORMAL);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+
+    write_pte(&boot_first_id[id_offsets[1]], pte);
+
+    /* Link third ID table */
+    pte = mfn_to_xen_entry(virt_to_mfn(boot_third_id), MT_NORMAL);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+
+    write_pte(&boot_second_id[id_offsets[2]], pte);
+
+    /* The mapping in the third table will be created at a later stage */
+}
+
+static void __init prepare_runtime_identity_mapping(void)
+{
+    paddr_t id_addr = virt_to_maddr(_start);
+    lpae_t pte;
+    DECLARE_OFFSETS(id_offsets, id_addr);
+
+    if ( id_offsets[0] != 0 )
+        panic("Cannot handled ID mapping above 512GB\n");
+
+    /* Link first ID table */
+    pte = pte_of_xenaddr((vaddr_t)xen_first_id);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+
+    write_pte(&xen_pgtable[id_offsets[0]], pte);
+
+    /* Link second ID table */
+    pte = pte_of_xenaddr((vaddr_t)xen_second_id);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+
+    write_pte(&xen_first_id[id_offsets[1]], pte);
+
+    /* Link third ID table */
+    pte = pte_of_xenaddr((vaddr_t)xen_third_id);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+
+    write_pte(&xen_second_id[id_offsets[2]], pte);
+
+    /* The mapping in the third table will be created at a later stage */
+}
+
+void __init arch_setup_page_tables(void)
+{
+    prepare_boot_identity_mapping();
+    prepare_runtime_identity_mapping();
+}
+
+void update_identity_mapping(bool enable)
+{
+    paddr_t id_addr = virt_to_maddr(_start);
+    int rc;
+
+    if ( enable )
+        rc = map_pages_to_xen(id_addr, maddr_to_mfn(id_addr), 1,
+                              PAGE_HYPERVISOR_RX);
+    else
+        rc = destroy_xen_mappings(id_addr, id_addr + PAGE_SIZE);
+
+    BUG_ON(rc);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/include/asm/arm32/mm.h b/xen/arch/arm/include/asm/arm32/mm.h
index 8bfc906e7178..856f2dbec4ad 100644
--- a/xen/arch/arm/include/asm/arm32/mm.h
+++ b/xen/arch/arm/include/asm/arm32/mm.h
@@ -18,6 +18,10 @@ static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr)
 
 bool init_domheap_mappings(unsigned int cpu);
 
+static inline void arch_setup_page_tables(void)
+{
+}
+
 #endif /* __ARM_ARM32_MM_H__ */
 
 /*
diff --git a/xen/arch/arm/include/asm/arm64/mm.h b/xen/arch/arm/include/asm/arm64/mm.h
index aa2adac63189..807d3b2321fd 100644
--- a/xen/arch/arm/include/asm/arm64/mm.h
+++ b/xen/arch/arm/include/asm/arm64/mm.h
@@ -1,6 +1,8 @@
 #ifndef __ARM_ARM64_MM_H__
 #define __ARM_ARM64_MM_H__
 
+extern DEFINE_PAGE_TABLE(xen_pgtable);
+
 /*
  * On ARM64, all the RAM is currently direct mapped in Xen.
  * Hence return always true.
@@ -10,6 +12,16 @@ static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr)
     return true;
 }
 
+void arch_setup_page_tables(void);
+
+/*
+ * Enable/disable the identity mapping
+ *
+ * Note that nested a call (e.g. enable=true, enable=true) is not
+ * supported.
+ */
+void update_identity_mapping(bool enable);
+
 #endif /* __ARM_ARM64_MM_H__ */
 
 /*
diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h
index fdbf68aadcaa..e7a80fecec14 100644
--- a/xen/arch/arm/include/asm/setup.h
+++ b/xen/arch/arm/include/asm/setup.h
@@ -168,6 +168,17 @@ int map_range_to_domain(const struct dt_device_node *dev,
 
 extern const char __ro_after_init_start[], __ro_after_init_end[];
 
+extern DEFINE_BOOT_PAGE_TABLE(boot_pgtable);
+
+#ifdef CONFIG_ARM_64
+extern DEFINE_BOOT_PAGE_TABLE(boot_first_id);
+#endif
+extern DEFINE_BOOT_PAGE_TABLE(boot_second_id);
+extern DEFINE_BOOT_PAGE_TABLE(boot_third_id);
+
+/* Find where Xen will be residing at runtime and return an PT entry */
+lpae_t pte_of_xenaddr(vaddr_t);
+
 #endif
 /*
  * Local variables:
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 865780695421..824beed3976a 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -102,7 +102,7 @@ DEFINE_BOOT_PAGE_TABLE(boot_third);
 
 #ifdef CONFIG_ARM_64
 #define HYP_PT_ROOT_LEVEL 0
-static DEFINE_PAGE_TABLE(xen_pgtable);
+DEFINE_PAGE_TABLE(xen_pgtable);
 static DEFINE_PAGE_TABLE(xen_first);
 #define THIS_CPU_PGTABLE xen_pgtable
 #else
@@ -397,7 +397,7 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache)
         invalidate_icache();
 }
 
-static inline lpae_t pte_of_xenaddr(vaddr_t va)
+lpae_t pte_of_xenaddr(vaddr_t va)
 {
     paddr_t ma = va + phys_offset;
 
@@ -504,6 +504,8 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
 
     phys_offset = boot_phys_offset;
 
+    arch_setup_page_tables();
+
 #ifdef CONFIG_ARM_64
     pte = pte_of_xenaddr((uintptr_t)xen_first);
     pte.pt.table = 1;
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:18:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:18:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428371.678428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGH2-0004WW-39; Sat, 22 Oct 2022 15:18:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428371.678428; Sat, 22 Oct 2022 15:18:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGH1-0004Vc-S5; Sat, 22 Oct 2022 15:18:55 +0000
Received: by outflank-mailman (input) for mailman id 428371;
 Sat, 22 Oct 2022 15:18:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omGH1-0004Sv-BE
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:18:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGH1-0005Z9-30; Sat, 22 Oct 2022 15:18:55 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3G-00023n-M1; Sat, 22 Oct 2022 15:04:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=jHNNhi8K1ZRzIp2kHxExqhjCOVBUp7E2y4GDHMRrZwQ=; b=EAbp/YI5s2LGMs7xfqiFSCEvfr
	+omSA5S+O0xZRnjjbM4ArjDe7nwmI4qk3uVjEx8BXEjMeGAsFGLKWIYNp8V4LjQqFfqlbgkVzvZXr
	2fmI9hktvGrSC0L1uyKfQhOxBW4rdMD/TFhQ1zEvfY5iBog66j7JBeGBQ3sK+NE1iWxY=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 11/12] xen/arm64: mm: Rework switch_ttbr()
Date: Sat, 22 Oct 2022 16:04:21 +0100
Message-Id: <20221022150422.17707-12-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

At the moment, switch_ttbr() is switching the TTBR whilst the MMU is
still on.

Switching TTBR is like replacing existing mappings with new ones. So
we need to follow the break-before-make sequence.

In this case, it means the MMU needs to be switched off while the
TTBR is updated. In order to disable the MMU, we need to first
jump to an identity mapping.

Rename switch_ttbr() to switch_ttbr_id() and create an helper on
top to temporary map the identity mapping and call switch_ttbr()
via the identity address.

switch_ttbr_id() is now reworked to temporarily turn off the MMU
before updating the TTBR.

We also need to make sure the helper switch_ttbr() is part of the
identity mapping. So move _end_boot past it.

The arm32 code will use a different approach. So this issue is for now
only resolved on arm64.

Signed-off-by: Julien Grall <jgrall@amazon.com>

----

    Changes in v2:
        - Remove the arm32 changes. This will be addressed differently
        - Re-instate the instruct cache flush. This is not strictly
          necessary but kept it for safety.
        - Use "dsb ish"  rather than "dsb sy".

    TODO:
        * Handle the case where the runtime Xen is loaded at a different
          position.
        * Rename _end_boot to _end_id_mapping or similar
---
 xen/arch/arm/arm64/head.S     | 54 +++++++++++++++++++++++------------
 xen/arch/arm/arm64/mm.c       | 39 +++++++++++++++++++++++++
 xen/arch/arm/include/asm/mm.h |  2 ++
 xen/arch/arm/mm.c             | 14 +++++----
 4 files changed, 84 insertions(+), 25 deletions(-)

diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 23c2c7491db2..223cc7631d3b 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -812,36 +812,52 @@ fail:   PRINT("- Boot failed -\r\n")
         b     1b
 ENDPROC(fail)
 
-GLOBAL(_end_boot)
-
 /*
  * Switch TTBR
  *
  * x0    ttbr
- *
- * TODO: This code does not comply with break-before-make.
  */
-ENTRY(switch_ttbr)
-        dsb   sy                     /* Ensure the flushes happen before
-                                      * continuing */
-        isb                          /* Ensure synchronization with previous
-                                      * changes to text */
-        tlbi   alle2                 /* Flush hypervisor TLB */
-        ic     iallu                 /* Flush I-cache */
-        dsb    sy                    /* Ensure completion of TLB flush */
+ENTRY(switch_ttbr_id)
+        /* 1) Ensure any previous read/write have completed */
+        dsb    ish
+        isb
+
+        /* 2) Turn off MMU */
+        mrs    x1, SCTLR_EL2
+        bic    x1, x1, #SCTLR_Axx_ELx_M
+        msr    SCTLR_EL2, x1
+        isb
+
+        /*
+         * 3) Flush the TLBs.
+         * See asm/arm64/flushtlb.h for the explanation of the sequence.
+         */
+        dsb   nshst
+        tlbi  alle2
+        dsb   nsh
+        isb
+
+        /* 4) Update the TTBR */
+        msr   TTBR0_EL2, x0
         isb
 
-        msr    TTBR0_EL2, x0
+        /*
+         * 5) Flush I-cache
+         * This should not be necessary but it is kept for safety.
+         */
+        ic     iallu
+        isb
 
-        isb                          /* Ensure synchronization with previous
-                                      * changes to text */
-        tlbi   alle2                 /* Flush hypervisor TLB */
-        ic     iallu                 /* Flush I-cache */
-        dsb    sy                    /* Ensure completion of TLB flush */
+        /* 5) Turn on the MMU */
+        mrs   x1, SCTLR_EL2
+        orr   x1, x1, #SCTLR_Axx_ELx_M  /* Enable MMU */
+        msr   SCTLR_EL2, x1
         isb
 
         ret
-ENDPROC(switch_ttbr)
+ENDPROC(switch_ttbr_id)
+
+GLOBAL(_end_boot)
 
 #ifdef CONFIG_EARLY_PRINTK
 /*
diff --git a/xen/arch/arm/arm64/mm.c b/xen/arch/arm/arm64/mm.c
index 9eaf545ea9dd..2ede4e75ae33 100644
--- a/xen/arch/arm/arm64/mm.c
+++ b/xen/arch/arm/arm64/mm.c
@@ -31,6 +31,15 @@ static void __init prepare_boot_identity_mapping(void)
     lpae_t pte;
     DECLARE_OFFSETS(id_offsets, id_addr);
 
+    /*
+     * We will be re-using the boot ID tables. They may not have been
+     * zeroed but they should be unlinked. So it is fine to use
+     * clear_page().
+     */
+    clear_page(boot_first_id);
+    clear_page(boot_second_id);
+    clear_page(boot_third_id);
+
     if ( id_offsets[0] != 0 )
         panic("Cannot handled ID mapping above 512GB\n");
 
@@ -111,6 +120,36 @@ void update_identity_mapping(bool enable)
     BUG_ON(rc);
 }
 
+extern void switch_ttbr_id(uint64_t ttbr);
+
+typedef void (switch_ttbr_fn)(uint64_t ttbr);
+
+void __init switch_ttbr(uint64_t ttbr)
+{
+    vaddr_t id_addr = virt_to_maddr(switch_ttbr_id);
+    switch_ttbr_fn *fn = (switch_ttbr_fn *)id_addr;
+    lpae_t pte;
+
+    /* Enable the identity mapping in the boot page tables */
+    update_identity_mapping(true);
+    /* Enable the identity mapping in the runtime page tables */
+    pte = pte_of_xenaddr((vaddr_t)switch_ttbr_id);
+    pte.pt.table = 1;
+    pte.pt.xn = 0;
+    pte.pt.ro = 1;
+    write_pte(&xen_third_id[third_table_offset(id_addr)], pte);
+
+    /* Switch TTBR */
+    fn(ttbr);
+
+    /*
+     * Disable the identity mapping in the runtime page tables.
+     * Note it is not necessary to disable it in the boot page tables
+     * because they are not going to be used by this CPU anymore.
+     */
+    update_identity_mapping(false);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index 68adcac9fa8d..bff6923f3ea9 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -196,6 +196,8 @@ extern unsigned long total_pages;
 extern void setup_pagetables(unsigned long boot_phys_offset);
 /* Map FDT in boot pagetable */
 extern void *early_fdt_map(paddr_t fdt_paddr);
+/* Switch to a new root page-tables */
+extern void switch_ttbr(uint64_t ttbr);
 /* Remove early mappings */
 extern void remove_early_mappings(void);
 /* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 824beed3976a..defc54a19907 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -485,8 +485,6 @@ static void xen_pt_enforce_wnx(void)
     flush_xen_tlb_local();
 }
 
-extern void switch_ttbr(uint64_t ttbr);
-
 /* Clear a translation table and clean & invalidate the cache */
 static void clear_table(void *table)
 {
@@ -559,13 +557,17 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
     ttbr = (uintptr_t) cpu0_pgtable + phys_offset;
 #endif
 
-    switch_ttbr(ttbr);
-
-    xen_pt_enforce_wnx();
-
+    /*
+     * This needs to be setup first so switch_ttbr() can enable the
+     * identity mapping.
+     */
 #ifdef CONFIG_ARM_32
     per_cpu(xen_pgtable, 0) = cpu0_pgtable;
 #endif
+
+    switch_ttbr(ttbr);
+
+    xen_pt_enforce_wnx();
 }
 
 static void clear_boot_pagetables(void)
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:18:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:18:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428370.678421 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGH1-0004TF-O7; Sat, 22 Oct 2022 15:18:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428370.678421; Sat, 22 Oct 2022 15:18:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGH1-0004T8-LI; Sat, 22 Oct 2022 15:18:55 +0000
Received: by outflank-mailman (input) for mailman id 428370;
 Sat, 22 Oct 2022 15:18:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omGH1-0004Sq-9R
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:18:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGH0-0005Z5-TT; Sat, 22 Oct 2022 15:18:54 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omG3I-00023n-1G; Sat, 22 Oct 2022 15:04:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References:
	In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=QrKVoHX4qf0LlBAWONoW3KGm6ybNg9XRNoyqYYBQsCU=; b=yeT5y7CLP3XFkDni1Tr9DIuf6D
	qm91moVcg3R/j7l+jg7D6etvgIhU8U5cBv6Wb9JhEmFmkfc73yAbs1nFEDqm1OvHkkwd6Ji1zs5NP
	EeT7VFaoSy5eU0hMQDzCXJtgXRoPDHKtCjWurCMwa1io1yPQOb/c//MCfirq07hfpksk=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech,
	lucmiccio@gmail.com,
	carlo.nonato@minervasys.tech,
	Julien Grall <jgrall@amazon.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [RFC v2 12/12] xen/arm64: smpboot: Directly switch to the runtime page-tables
Date: Sat, 22 Oct 2022 16:04:22 +0100
Message-Id: <20221022150422.17707-13-julien@xen.org>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
References: <20221022150422.17707-1-julien@xen.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

Switching TTBR while the MMU is on is not safe. Now that the identity
mapping will not clash with the rest of the memory layout, we can avoid
creating temporary page-tables every time a CPU is brought up.

The arm32 code will use a different approach. So this issue is for now
only resolved on arm64.

Signed-off-by: Julien Grall <jgrall@amazon.com>
----

    Changes in v2:
        - Remove arm32 code
---
 xen/arch/arm/arm32/smpboot.c   |  4 ++++
 xen/arch/arm/arm64/head.S      | 29 +++++++++--------------------
 xen/arch/arm/arm64/smpboot.c   | 15 ++++++++++++++-
 xen/arch/arm/include/asm/smp.h |  1 +
 xen/arch/arm/smpboot.c         |  1 +
 5 files changed, 29 insertions(+), 21 deletions(-)

diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c
index e7368665d50d..518e9f9c7e70 100644
--- a/xen/arch/arm/arm32/smpboot.c
+++ b/xen/arch/arm/arm32/smpboot.c
@@ -21,6 +21,10 @@ int arch_cpu_up(int cpu)
     return platform_cpu_up(cpu);
 }
 
+void arch_cpu_up_finish(void)
+{
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 223cc7631d3b..8765a1570839 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -308,6 +308,7 @@ real_start_efi:
         bl    check_cpu_mode
         bl    cpu_init
         bl    create_page_tables
+        load_paddr x0, boot_pgtable
         bl    enable_mmu
 
         /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
@@ -365,29 +366,14 @@ GLOBAL(init_secondary)
 #endif
         bl    check_cpu_mode
         bl    cpu_init
-        bl    create_page_tables
+        load_paddr x0, init_ttbr
+        ldr   x0, [x0]
         bl    enable_mmu
 
         /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
         ldr   x0, =secondary_switched
         br    x0
 secondary_switched:
-        /*
-         * Non-boot CPUs need to move on to the proper pagetables, which were
-         * setup in init_secondary_pagetables.
-         *
-         * XXX: This is not compliant with the Arm Arm.
-         */
-        ldr   x4, =init_ttbr         /* VA of TTBR0_EL2 stashed by CPU 0 */
-        ldr   x4, [x4]               /* Actual value */
-        dsb   sy
-        msr   TTBR0_EL2, x4
-        dsb   sy
-        isb
-        tlbi  alle2
-        dsb   sy                     /* Ensure completion of TLB flush */
-        isb
-
 #ifdef CONFIG_EARLY_PRINTK
         /* Use a virtual address to access the UART. */
         ldr   x23, =EARLY_UART_VIRTUAL_ADDRESS
@@ -672,9 +658,13 @@ ENDPROC(create_page_tables)
  * mapping. In other word, the caller is responsible to switch to the runtime
  * mapping.
  *
- * Clobbers x0 - x3
+ * Inputs:
+ *   x0 : Physical address of the page tables.
+ *
+ * Clobbers x0 - x4
  */
 enable_mmu:
+        mov   x4, x0
         PRINT("- Turning on paging -\r\n")
 
         /*
@@ -685,8 +675,7 @@ enable_mmu:
         dsb   nsh
 
         /* Write Xen's PT's paddr into TTBR0_EL2 */
-        load_paddr x0, boot_pgtable
-        msr   TTBR0_EL2, x0
+        msr   TTBR0_EL2, x4
         isb
 
         mrs   x0, SCTLR_EL2
diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c
index 694fbf67e62a..9637f424699e 100644
--- a/xen/arch/arm/arm64/smpboot.c
+++ b/xen/arch/arm/arm64/smpboot.c
@@ -106,10 +106,23 @@ int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
 
 int arch_cpu_up(int cpu)
 {
+    int rc;
+
     if ( !smp_enable_ops[cpu].prepare_cpu )
         return -ENODEV;
 
-    return smp_enable_ops[cpu].prepare_cpu(cpu);
+    update_identity_mapping(true);
+
+    rc = smp_enable_ops[cpu].prepare_cpu(cpu);
+    if ( rc )
+        update_identity_mapping(false);
+
+    return rc;
+}
+
+void arch_cpu_up_finish(void)
+{
+    update_identity_mapping(false);
 }
 
 /*
diff --git a/xen/arch/arm/include/asm/smp.h b/xen/arch/arm/include/asm/smp.h
index 8133d5c29572..a37ca55bff2c 100644
--- a/xen/arch/arm/include/asm/smp.h
+++ b/xen/arch/arm/include/asm/smp.h
@@ -25,6 +25,7 @@ extern void noreturn stop_cpu(void);
 extern int arch_smp_init(void);
 extern int arch_cpu_init(int cpu, struct dt_device_node *dn);
 extern int arch_cpu_up(int cpu);
+extern void arch_cpu_up_finish(void);
 
 int cpu_up_send_sgi(int cpu);
 
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index f7bda3a18b48..32e1d30e087e 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -509,6 +509,7 @@ int __cpu_up(unsigned int cpu)
     init_data.cpuid = ~0;
     smp_up_cpu = MPIDR_INVALID;
     clean_dcache(smp_up_cpu);
+    arch_cpu_up_finish();
 
     if ( !cpu_online(cpu) )
     {
-- 
2.37.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:30:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:30:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428401.678461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGSb-000823-LK; Sat, 22 Oct 2022 15:30:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428401.678461; Sat, 22 Oct 2022 15:30:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGSb-00081w-IV; Sat, 22 Oct 2022 15:30:53 +0000
Received: by outflank-mailman (input) for mailman id 428401;
 Sat, 22 Oct 2022 15:30:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omGSa-00081q-9H
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:30:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGSZ-0005lf-DQ; Sat, 22 Oct 2022 15:30:51 +0000
Received: from 54-240-197-238.amazon.com ([54.240.197.238]
 helo=[192.168.29.245]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omGSZ-00034O-3b; Sat, 22 Oct 2022 15:30:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=sInZb5q0RfCvzurZG+VzUppWnv1M4vNyGRYuy5GGj9g=; b=K6S47xNImgaHkyEfKAq+Lvx6ka
	hQzfZqMt+GDJ4xjhiZBpeQWnQNWOLN3XFiCyE/sriyBVtojV44Qh/EZpdaNzap235Ls6RJWFUQL/Z
	aECGaqSmBpQejf2AqYGFXhh5Nazumg95m7v+2ubG+q2wohoTIjzESyyqZ63mqS6iM2r0=;
Message-ID: <61e8475d-868d-3ff0-041f-8f6790990ce4@xen.org>
Date: Sat, 22 Oct 2022 16:30:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v2] core-parking: fix build with gcc12 and NR_CPUS=1
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

Is this intended for 4.17?

On 09/09/2022 15:30, Jan Beulich wrote:
> Gcc12 takes issue with core_parking_remove()'s
> 
>      for ( ; i < cur_idle_nums; ++i )
>          core_parking_cpunum[i] = core_parking_cpunum[i + 1];
> 
> complaining that the right hand side array access is past the bounds of
> 1. Clearly the compiler can't know that cur_idle_nums can only ever be
> zero in this case (as the sole CPU cannot be parked).
> 
> Arrange for core_parking.c's contents to not be needed altogether, and
> then disable its building when NR_CPUS == 1.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: Disable building of core_parking.c altogether.
> 
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -10,7 +10,7 @@ config X86
>   	select ALTERNATIVE_CALL
>   	select ARCH_MAP_DOMAIN_PAGE
>   	select ARCH_SUPPORTS_INT128
> -	select CORE_PARKING
> +	select CORE_PARKING if NR_CPUS > 1
>   	select HAS_ALTERNATIVE
>   	select HAS_COMPAT
>   	select HAS_CPUFREQ
> --- a/xen/arch/x86/platform_hypercall.c
> +++ b/xen/arch/x86/platform_hypercall.c
> @@ -727,12 +727,17 @@ ret_t do_platform_op(
>           case XEN_CORE_PARKING_SET:
>               idle_nums = min_t(uint32_t,
>                       op->u.core_parking.idle_nums, num_present_cpus() - 1);
> -            ret = continue_hypercall_on_cpu(
> -                    0, core_parking_helper, (void *)(unsigned long)idle_nums);
> +            if ( CONFIG_NR_CPUS > 1 )
> +                ret = continue_hypercall_on_cpu(
> +                        0, core_parking_helper,
> +                        (void *)(unsigned long)idle_nums);
> +            else if ( idle_nums )
> +                ret = -EINVAL;
>               break;
>   
>           case XEN_CORE_PARKING_GET:
> -            op->u.core_parking.idle_nums = get_cur_idle_nums();
> +            op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1
> +                                           ? get_cur_idle_nums() : 0;
>               ret = __copy_field_to_guest(u_xenpf_op, op, u.core_parking) ?
>                     -EFAULT : 0;
>               break;
> --- a/xen/arch/x86/sysctl.c
> +++ b/xen/arch/x86/sysctl.c
> @@ -157,7 +157,7 @@ long arch_do_sysctl(
>           long (*fn)(void *);
>           void *hcpu;
>   
> -        switch ( op )
> +        switch ( op | -(CONFIG_NR_CPUS == 1) )
This code is quite confusing to read and potentially risky as you are 
are relying the top bit of 'op' to never be 1. While I am expecting this 
will ever be the case, this will be a "fun" issue to debug if this ever 
happen. So I would suggest to check CONFIG_NR_CPUS == 1 separately.

The rest of the changes looks fine to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428408.678495 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGml-0002Z1-3V; Sat, 22 Oct 2022 15:51:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428408.678495; Sat, 22 Oct 2022 15:51:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmk-0002Ys-Tw; Sat, 22 Oct 2022 15:51:42 +0000
Received: by outflank-mailman (input) for mailman id 428408;
 Sat, 22 Oct 2022 15:51:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmj-0002Ir-90
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:41 +0000
Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com
 [2a00:1450:4864:20::52c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6993cab8-5221-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 17:51:39 +0200 (CEST)
Received: by mail-ed1-x52c.google.com with SMTP id u21so16364669edi.9
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:37 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.35
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6993cab8-5221-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=ninxl7zeTOLhM6GAnaxyPElcqi5G7SjegJNvFx79Nbc=;
        b=a7yjZpmIh+NPgVpmQ4LOTpYlC+ajUZTCNned8FpjQ6Bfl88T8wOaM5iXM0tnN+kYGZ
         X/C1sDj25h5P/QGrHHqK+XxoBiHnQ4stum+01cNp+AGCOYqbw5C1t4k01h7RFAoSpsRr
         vrRTixpBo7j1TmUT87JECol3ONuirv5uSmPmagr/B4nsY8jNtDnemjijmOWsiQ/Tbwdp
         nn3AsPbv+d+BsNhkR4HLw008peu6vUrbLXsFvjn64WncHwLyBfTbqxwEVFMuqHr7ojin
         bUMTNTagGWBbV9xrxCnClgaS/9X5icVARl9Oyxyz18fVYtD/idoOg2lXQmlnqmhMAfia
         lSAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=ninxl7zeTOLhM6GAnaxyPElcqi5G7SjegJNvFx79Nbc=;
        b=JfQusgq68//wwYimQuKnQ7JfMWCW14cRdUUgYCJBRpJR3UfUBRtCfA3YMi6L6xUt28
         NVwKOadDjeh9gahLKC7w6+YJSgPQ/NsHSKizhX0HJIJdAdn6nSMHLmppWrZ06w0sz5CR
         4xOgIOjJKq7QXfLk03AsGWSuOysWdFz6rd0FvsD2gtyc1u/e5SUbDKK+fItIRQPOVXIf
         2LXod2DRSELhRsx3RxkP7KFqm6dal7ToFKCNS3SXGp1PXvp0+EIZr720wLPpgMavxaY7
         OJo5lCRy3pCLRfUfyD37uiUW0cGG3d6sCeCI1lyWKmNMz2nbTTMcH810yLIMOl7/ACLa
         GlEA==
X-Gm-Message-State: ACrzQf0UuGCsi7+Sljll/YUdiEcuqD8jIV6avCJ2xHztALlFJ0mOdf4/
	+y2LscXU3RPsNxSKwnbKvnekEbGynyIBBA==
X-Google-Smtp-Source: AMsMyM7i71NKIiUcFaiGbkODGKyUICgpneseUE2cch5z2qksy95TN57zoUZBaQnk2RokXBoBoXiFZg==
X-Received: by 2002:a17:907:6d84:b0:78d:f2b0:14c8 with SMTP id sb4-20020a1709076d8400b0078df2b014c8mr19729711ejc.749.1666453896749;
        Sat, 22 Oct 2022 08:51:36 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v3 1/9] xen/arm: add cache coloring initialization
Date: Sat, 22 Oct 2022 17:51:12 +0200
Message-Id: <20221022155120.7000-2-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This commit adds the cache coloring support initialization, Kconfig
options, command line parameters and the initial documentation.
The initialization consists of an auto probing of the cache layout
necessary to retrieve the LLC way size which is used to compute the
number of available colors. The Dom0 colors are then initialized with
default colors (all available ones) if not provided from the command line,
and they are checked for bad configuration.

It also adds a debug-key to dump general cache coloring info.
This includes LLC way size, total available colors and the mask used to
extract colors from physical addresses.

Based on original work from: Luca Miccio <lucmiccio@gmail.com>

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
v3:
- HAS_CACHE_COLORING config added
- fixed CONFIG_MAX_CACHE_COLORS range and explained why such range
- __ro_after_init for coloring globals
- stub functions in case of coloring disabled, in coloring.c (like in v1)
- check number of colors in range [2, CONFIG_MAX_CACHE_COLORS] at runtime
- LLC way size and number of colors must be a power of 2
  (explained in docs and checked at runtime)
---
 docs/misc/arm/cache-coloring.rst     | 135 +++++++++++++++
 docs/misc/xen-command-line.pandoc    |  26 +++
 xen/arch/arm/Kconfig                 |  22 +++
 xen/arch/arm/Makefile                |   1 +
 xen/arch/arm/coloring.c              | 243 +++++++++++++++++++++++++++
 xen/arch/arm/include/asm/coloring.h  |  38 +++++
 xen/arch/arm/include/asm/processor.h |  16 ++
 xen/arch/arm/setup.c                 |   7 +
 xen/common/Kconfig                   |   3 +
 9 files changed, 491 insertions(+)
 create mode 100644 docs/misc/arm/cache-coloring.rst
 create mode 100644 xen/arch/arm/coloring.c
 create mode 100644 xen/arch/arm/include/asm/coloring.h

diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
new file mode 100644
index 0000000000..b0f9a2e917
--- /dev/null
+++ b/docs/misc/arm/cache-coloring.rst
@@ -0,0 +1,135 @@
+Xen cache coloring user guide
+=============================
+
+The cache coloring support in Xen allows to reserve Last Level Cache (LLC)
+partition for Dom0, DomUs and Xen itself. Currently only ARM64 is supported.
+
+In order to enable and use it, few steps are needed.
+
+- Enable expert mode in Xen configuration file.
+
+        CONFIG_EXPERT=y
+- Enable cache coloring in Xen configuration file.
+
+        CONFIG_CACHE_COLORING=y
+- If needed, change the maximum number of colors in Xen configuration file
+  (refer to menuconfig help for value meaning and when it should be changed).
+
+        CONFIG_MAX_CACHE_COLORS=<n>
+- Assign colors to Dom0 using the `Color selection format`_ (see
+  `Coloring parameters`_ for more documentation pointers).
+
+Background
+**********
+
+Cache hierarchy of a modern multi-core CPU typically has first levels dedicated
+to each core (hence using multiple cache units), while the last level is shared
+among all of them. Such configuration implies that memory operations on one
+core (e.g. running a DomU) are able to generate interference on another core
+(e.g .hosting another DomU). Cache coloring allows eliminating this
+mutual interference, and thus guaranteeing higher and more predictable
+performances for memory accesses.
+The key concept underlying cache coloring is a fragmentation of the memory
+space into a set of sub-spaces called colors that are mapped to disjoint cache
+partitions. Technically, the whole memory space is first divided into a number
+of subsequent regions. Then each region is in turn divided into a number of
+subsequent sub-colors. The generic i-th color is then obtained by all the
+i-th sub-colors in each region.
+
+.. raw:: html
+
+    <pre>
+                            Region j            Region j+1
+                .....................   ............
+                .                     . .
+                .                       .
+            _ _ _______________ _ _____________________ _ _
+                |     |     |     |     |     |     |
+                | c_0 | c_1 |     | c_n | c_0 | c_1 |
+           _ _ _|_____|_____|_ _ _|_____|_____|_____|_ _ _
+                    :                       :
+                    :                       :...         ... .
+                    :                            color 0
+                    :...........................         ... .
+                                                :
+          . . ..................................:
+    </pre>
+
+There are two pragmatic lesson to be learnt.
+
+1. If one wants to avoid cache interference between two domains, different
+   colors needs to be used for their memory.
+
+2. Color assignment must privilege contiguity in the partitioning. E.g.,
+   assigning colors (0,1) to domain I  and (2,3) to domain  J is better than
+   assigning colors (0,2) to I and (1,3) to J.
+
+How to compute the number of colors
+***********************************
+
+To compute the number of available colors for a specific platform, the size of
+an LLC way and the page size used by Xen must be known. The first parameter can
+be found in the processor manual or can be also computed dividing the total
+cache size by the number of its ways. The second parameter is the minimum amount
+of memory that can be mapped by the hypervisor, thus dividing the way size by
+the page size, the number of total cache partitions is found. So for example,
+an Arm Cortex-A53 with a 16-ways associative 1 MiB LLC, can isolate up to 16
+colors when pages are 4 KiB in size.
+
+Cache layout is probed automatically by Xen itself, but a possibility to
+manually set the way size it's left for the user to overcome failing situations
+or for debugging/testing purposes. See `Coloring parameters`_ section for more
+information on that.
+
+Colors selection format
+***********************
+
+Regardless of the memory pool that has to be colored (Xen, Dom0/DomUs),
+the color selection can be expressed using the same syntax. In particular a
+comma-separated list of colors or ranges of colors is used.
+Ranges are hyphen-separated intervals (such as `0-4`) and are inclusive on both
+sides.
+
+Note that:
+ - no spaces are allowed between values.
+ - no overlapping ranges or duplicated colors are allowed.
+ - values must be written in ascending order.
+
+Examples:
+
++---------------------+-----------------------------------+
+|**Configuration**    |**Actual selection**               |
++---------------------+-----------------------------------+
+|  1-2,5-8            | [1, 2, 5, 6, 7, 8]                |
++---------------------+-----------------------------------+
+|  4-8,10,11,12       | [4, 5, 6, 7, 8, 10, 11, 12]       |
++---------------------+-----------------------------------+
+|  0                  | [0]                               |
++---------------------+-----------------------------------+
+
+Coloring parameters
+*******************
+
+LLC way size (as previously discussed) and Dom0 colors can be set using the
+appropriate command line parameters. See the relevant documentation in
+"docs/misc/xen-command-line.pandoc".
+
+Known issues and limitations
+****************************
+
+Cache coloring is intended only for embedded systems
+####################################################
+
+The current implementation aims to satisfy the need of predictability in
+embedded systems with small amount of memory to be managed in a colored way.
+Given that, some shortcuts are taken in the development. Expect worse
+performances on larger systems.
+
+The maximum number of colors supported is 32768
+###############################################
+
+The upper bound of the CONFIG_MAX_CACHE_COLORS range (which is an upper bound
+too) is set to 2^15 = 32768 colors because of some limitation on the domain
+configuration structure size used in domain creation. "uint16_t" is the biggest
+integer type that fit the constraint and 2^15 is the biggest power of 2 it can
+easily represent. This value is big enough for the generic case, though.
diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 68389843b2..3f04414134 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -903,6 +903,14 @@ Controls for the dom0 IOMMU setup.
 
     Incorrect use of this option may result in a malfunctioning system.
 
+### dom0-colors (arm64)
+> `= List of [ <integer> | <integer>-<integer> ]`
+
+> Default: `All available colors`
+
+Specify dom0 color configuration. If the parameter is not set, all available
+colors are chosen and the user is warned on Xen's serial console.
+
 ### dom0_ioports_disable (x86)
 > `= List of <hex>-<hex>`
 
@@ -1645,6 +1653,24 @@ This option is intended for debugging purposes only.  Enable MSR_DEBUGCTL.LBR
 in hypervisor context to be able to dump the Last Interrupt/Exception To/From
 record with other registers.
 
+### llc-way-size (arm64)
+> `= <size>`
+
+> Default: `Obtained from the hardware`
+
+Specify the way size of the Last Level Cache. This parameter is only useful with
+cache coloring support enabled. It is an optional, expert-only parameter and it
+is used to calculate the number of available colors on the platform. It can be
+obtained by dividing the total LLC size by the number of its associative ways.
+By default, the value is automatically computed by probing the hardware, but in
+case of specific needs, it can be manually set. Those include failing probing
+and debugging/testing purposes so that it's possibile to emulate platforms with
+different number of supported colors.
+An important detail to highlight is that the current implementation of the
+cache coloring technique requires the number of colors to be a power of 2, and
+consequently, also the LLC way size must be so. A value that doesn't match this
+requirement is aligned down to the previous power of 2.
+
 ### loglvl
 > `= <level>[/<rate-limited level>]` where level is `none | error | warning | info | debug | all`
 
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 1fe5faf847..c45a9c5917 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -9,6 +9,7 @@ config ARM_64
 	select 64BIT
 	select ARM_EFI
 	select HAS_FAST_MULTIPLY
+	select HAS_CACHE_COLORING
 
 config ARM
 	def_bool y
@@ -131,6 +132,27 @@ config ARM64_BTI
 	  Branch Target Identification support.
 	  This feature is not supported in Xen.
 
+config CACHE_COLORING
+	bool "Last Level Cache (LLC) coloring" if EXPERT
+	depends on HAS_CACHE_COLORING
+
+config MAX_CACHE_COLORS
+	int "Maximum number of cache colors"
+	default 128
+	range 2 32768
+	depends on CACHE_COLORING
+	help
+	  This config value is an upper bound for the actual number of cache colors
+	  supported by the architecture. Xen preallocates this amount of cache
+	  colors at boot. Refer to the documentation for how to compute the number
+	  of colors supported by the platform.
+	  The default value corresponds to an 8 MiB 16-ways LLC, which should be
+	  more than what needed in the normal case.
+	  The max value corresponds to a 2 GiB 16-ways LLC which should never be
+	  reached.
+	  Note that if, at any time, a color configuration with more colors than the
+	  maximum is employed, an error is produced.
+
 config TEE
 	bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED
 	default n
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 4d076b278b..12940ba761 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -67,6 +67,7 @@ obj-$(CONFIG_SBSA_VUART_CONSOLE) += vpl011.o
 obj-y += vsmc.o
 obj-y += vpsci.o
 obj-y += vuart.o
+obj-$(CONFIG_CACHE_COLORING) += coloring.o
 
 extra-y += xen.lds
 
diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
new file mode 100644
index 0000000000..36eea2d6c0
--- /dev/null
+++ b/xen/arch/arm/coloring.c
@@ -0,0 +1,243 @@
+/*
+ * xen/arch/arm/coloring.c
+ *
+ * Coloring support for ARM
+ *
+ * Copyright (C) 2019 Xilinx Inc.
+ *
+ * Authors:
+ *    Luca Miccio <lucmiccio@gmail.com>
+ *    Carlo Nonato <carlo.nonato@minervasys.tech>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#include <xen/bitops.h>
+#include <xen/errno.h>
+#include <xen/keyhandler.h>
+#include <xen/param.h>
+#include <xen/types.h>
+
+#include <asm/coloring.h>
+#include <asm/processor.h>
+#include <asm/sysregs.h>
+
+/* Size of an LLC way */
+static unsigned int __ro_after_init llc_way_size;
+/* Number of colors available in the LLC */
+static unsigned int __ro_after_init max_colors = CONFIG_MAX_CACHE_COLORS;
+/* Mask to retrieve coloring relevant bits */
+static uint64_t __ro_after_init addr_col_mask;
+
+#define addr_to_color(addr) (((addr) & addr_col_mask) >> PAGE_SHIFT)
+#define addr_set_color(addr, color) (((addr) & ~addr_col_mask) \
+                                     | ((color) << PAGE_SHIFT))
+
+static unsigned int dom0_colors[CONFIG_MAX_CACHE_COLORS];
+static unsigned int dom0_num_colors;
+
+/*
+ * Parse the coloring configuration given in the buf string, following the
+ * syntax below.
+ *
+ * COLOR_CONFIGURATION ::= COLOR | RANGE,...,COLOR | RANGE
+ * RANGE               ::= COLOR-COLOR
+ *
+ * Example: "0,2-6,15-16" represents the set of colors: 0,2,3,4,5,6,15,16.
+ */
+static int parse_color_config(const char *buf, unsigned int *colors,
+                              unsigned int *num_colors)
+{
+    const char *s = buf;
+
+    if ( !colors || !num_colors )
+        return -EINVAL;
+
+    while ( *s != '\0' )
+    {
+        if ( *s != ',' )
+        {
+            unsigned int color, start, end;
+
+            start = simple_strtoul(s, &s, 0);
+
+            if ( *s == '-' )    /* Range */
+            {
+                s++;
+                end = simple_strtoul(s, &s, 0);
+            }
+            else                /* Single value */
+                end = start;
+
+            if ( start > end ||
+                 *num_colors + end - start >= max_colors )
+                return -EINVAL;
+            for ( color = start; color <= end; color++ )
+                colors[(*num_colors)++] = color;
+        }
+        else
+            s++;
+    }
+
+    return *s ? -EINVAL : 0;
+}
+
+size_param("llc-way-size", llc_way_size);
+
+static int __init parse_dom0_colors(const char *s)
+{
+    return parse_color_config(s, dom0_colors, &dom0_num_colors);
+}
+custom_param("dom0-colors", parse_dom0_colors);
+
+/* Return the LLC way size by probing the hardware */
+static unsigned int __init get_llc_way_size(void)
+{
+    register_t ccsidr_el1;
+    register_t clidr_el1 = READ_SYSREG(CLIDR_EL1);
+    register_t csselr_el1 = READ_SYSREG(CSSELR_EL1);
+    register_t id_aa64mmfr2_el1 = READ_SYSREG(ID_AA64MMFR2_EL1);
+    uint32_t ccsidr_numsets_shift = CCSIDR_NUMSETS_SHIFT;
+    uint32_t ccsidr_numsets_mask = CCSIDR_NUMSETS_MASK;
+    unsigned int n, line_size, num_sets;
+
+    for ( n = CLIDR_CTYPEn_LEVELS;
+          n != 0 && !((clidr_el1 >> CLIDR_CTYPEn_SHIFT(n)) & CLIDR_CTYPEn_MASK);
+          n-- );
+
+    if ( n == 0 )
+        return 0;
+
+    WRITE_SYSREG(((n - 1) & CCSELR_LEVEL_MASK) << CCSELR_LEVEL_SHIFT,
+                 CSSELR_EL1);
+    isb();
+
+    ccsidr_el1 = READ_SYSREG(CCSIDR_EL1);
+
+    /* Arm ARM: (Log2(Number of bytes in cache line)) - 4 */
+    line_size = 1 << ((ccsidr_el1 & CCSIDR_LINESIZE_MASK) + 4);
+
+    /* If FEAT_CCIDX is enabled, CCSIDR_EL1 has a different bit layout */
+    if ( (id_aa64mmfr2_el1 >> ID_AA64MMFR2_CCIDX_SHIFT) & 0x7 )
+    {
+        ccsidr_numsets_shift = CCSIDR_NUMSETS_SHIFT_FEAT_CCIDX;
+        ccsidr_numsets_mask = CCSIDR_NUMSETS_MASK_FEAT_CCIDX;
+    }
+    /* Arm ARM: (Number of sets in cache) - 1 */
+    num_sets = ((ccsidr_el1 >> ccsidr_numsets_shift) & ccsidr_numsets_mask) + 1;
+
+    printk(XENLOG_INFO "LLC found: L%u (line size: %u bytes, sets num: %u)\n",
+           n, line_size, num_sets);
+
+    /* Restore value in CSSELR_EL1 */
+    WRITE_SYSREG(csselr_el1, CSSELR_EL1);
+    isb();
+
+    return line_size * num_sets;
+}
+
+static bool check_colors(unsigned int *colors, unsigned int num_colors)
+{
+    unsigned int i;
+
+    if ( num_colors > max_colors )
+        return false;
+
+    for ( i = 0; i < num_colors; i++ )
+        if ( colors[i] >= max_colors )
+            return false;
+
+    return true;
+}
+
+static unsigned int set_default_domain_colors(unsigned int *colors)
+{
+    unsigned int i;
+
+    if ( !colors )
+        return 0;
+
+    for ( i = 0; i < max_colors; i++ )
+        colors[i] = i;
+    return max_colors;
+}
+
+static void dump_coloring_info(unsigned char key)
+{
+    printk("'%c' pressed -> dumping coloring general info\n", key);
+    printk("LLC way size: %u KiB\n", llc_way_size >> 10);
+    printk("Number of LLC colors supported: %u\n", max_colors);
+    printk("Address color mask: 0x%lx\n", addr_col_mask);
+}
+
+bool __init coloring_init(void)
+{
+    if ( !llc_way_size && !(llc_way_size = get_llc_way_size()) )
+    {
+        printk(XENLOG_ERR
+               "Probed LLC way size is 0 and no custom value provided\n");
+        return false;
+    }
+
+    /*
+     * The maximum number of colors must be a power of 2 in order to correctly
+     * map colors to bits of an address, so also the LLC way size must be so.
+     */
+    if ( llc_way_size & (llc_way_size - 1) )
+    {
+        printk(XENLOG_WARNING "LLC way size (%u) isn't a power of 2.\n",
+               llc_way_size);
+        llc_way_size = 1U << flsl(llc_way_size);
+        printk(XENLOG_WARNING
+               "Using %u instead. Performances will be suboptimal\n",
+               llc_way_size);
+    }
+
+    max_colors = llc_way_size >> PAGE_SHIFT;
+
+    if ( max_colors < 2 || max_colors > CONFIG_MAX_CACHE_COLORS )
+    {
+        printk(XENLOG_ERR
+               "Max number of colors (%u) not in range [2, config max (%u)]\n",
+               max_colors, CONFIG_MAX_CACHE_COLORS);
+        return false;
+    }
+
+    addr_col_mask = (max_colors - 1) << PAGE_SHIFT;
+
+    if ( !dom0_num_colors )
+    {
+        printk(XENLOG_WARNING
+               "Dom0 color config not found. Using default (all colors)\n");
+        dom0_num_colors = set_default_domain_colors(dom0_colors);
+    }
+
+    if ( !check_colors(dom0_colors, dom0_num_colors) )
+    {
+        printk(XENLOG_ERR "Bad color config for Dom0\n");
+        return false;
+    }
+
+    register_keyhandler('K', dump_coloring_info, "dump coloring info", 1);
+
+    return true;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
new file mode 100644
index 0000000000..3b563d3b90
--- /dev/null
+++ b/xen/arch/arm/include/asm/coloring.h
@@ -0,0 +1,38 @@
+/*
+ * xen/arm/include/asm/coloring.h
+ *
+ * Coloring support for ARM
+ *
+ * Copyright (C) 2019 Xilinx Inc.
+ *
+ * Authors:
+ *    Luca Miccio <lucmiccio@gmail.com>
+ *    Carlo Nonato <carlo.nonato@minervasys.tech>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+#ifndef __ASM_ARM_COLORING_H__
+#define __ASM_ARM_COLORING_H__
+
+#ifdef CONFIG_CACHE_COLORING
+
+#include <xen/init.h>
+
+bool __init coloring_init(void);
+
+#else /* !CONFIG_CACHE_COLORING */
+
+static inline bool __init coloring_init(void) { return true; }
+
+#endif /* CONFIG_CACHE_COLORING */
+#endif /* __ASM_ARM_COLORING_H__ */
diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
index 1dd81d7d52..85ff0caf1e 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -18,6 +18,22 @@
 #define CTR_IDC_SHIFT       28
 #define CTR_DIC_SHIFT       29
 
+/* CCSIDR Current Cache Size ID Register */
+#define CCSIDR_LINESIZE_MASK            0x7
+#define CCSIDR_NUMSETS_SHIFT            13
+#define CCSIDR_NUMSETS_MASK             0x3FFF
+#define CCSIDR_NUMSETS_SHIFT_FEAT_CCIDX 32
+#define CCSIDR_NUMSETS_MASK_FEAT_CCIDX  0xFFFFFF
+
+/* CCSELR Cache Size Selection Register */
+#define CCSELR_LEVEL_MASK  0x7
+#define CCSELR_LEVEL_SHIFT 1
+
+/* CLIDR Cache Level ID Register */
+#define CLIDR_CTYPEn_SHIFT(n) (3 * (n - 1))
+#define CLIDR_CTYPEn_MASK     0x7
+#define CLIDR_CTYPEn_LEVELS   7
+
 #define ICACHE_POLICY_VPIPT  0
 #define ICACHE_POLICY_AIVIVT 1
 #define ICACHE_POLICY_VIPT   2
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 4395640019..acc3e4ad72 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -53,6 +53,7 @@
 #include <asm/setup.h>
 #include <xsm/xsm.h>
 #include <asm/acpi.h>
+#include <asm/coloring.h>
 
 struct bootinfo __initdata bootinfo;
 
@@ -1035,6 +1036,12 @@ void __init start_xen(unsigned long boot_phys_offset,
     printk("Command line: %s\n", cmdline);
     cmdline_parse(cmdline);
 
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+    {
+        if ( !coloring_init() )
+            panic("Xen cache coloring support: setup failed\n");
+    }
+
     setup_mm();
 
     /* Parse the ACPI tables for possible boot-time configuration */
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index f1ea3199c8..d7968127be 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -31,6 +31,9 @@ config ARCH_MAP_DOMAIN_PAGE
 config HAS_ALTERNATIVE
 	bool
 
+config HAS_CACHE_COLORING
+	bool
+
 config HAS_COMPAT
 	bool
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428407.678483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmj-0002JL-On; Sat, 22 Oct 2022 15:51:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428407.678483; Sat, 22 Oct 2022 15:51:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmj-0002JD-Kn; Sat, 22 Oct 2022 15:51:41 +0000
Received: by outflank-mailman (input) for mailman id 428407;
 Sat, 22 Oct 2022 15:51:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmi-000237-89
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:40 +0000
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
 [2a00:1450:4864:20::536])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a68df66-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:39 +0200 (CEST)
Received: by mail-ed1-x536.google.com with SMTP id l22so16367212edj.5
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:39 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.37
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:38 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a68df66-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=7YEp+6/JGCHy6EQ4ajZKOuOH14rgPIjfh8TnzifmQQA=;
        b=aKRNEZiMt7Y8LQT/O0c2wMlSjtTVslJIVI1ImdR18eAIy+Uj7tqQa34aNe83fGjTyn
         csZ1x51Um/ctWKOnVibYdBe+iPNrPr/W2Vqspcq0C5w40HFspJuJIu0TT85iqatb2zau
         FtMn2i50MyyFtCbn4mc0bNXogRomJfORGErHJQJAg3A/8zY5EfWxaA/sg2TlqK5Q+0j5
         bKbpPcpFDwYxMMq2eVDJZOLfDYpdqGlbD8PSICLXUTxRKXMHuS2bn9IF7t/wvj0TVLa3
         Qcn/vIkgJZTHILWRlYgMtQZZ6rkG4f1QO7wQlL4nCh46L1OGMB19k3bis8N87fGqyuNG
         rmoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=7YEp+6/JGCHy6EQ4ajZKOuOH14rgPIjfh8TnzifmQQA=;
        b=UH3eNWhgUqQCgnW5tmVUPllKT6gkW6hf436nH3+hjy7gZlp6UDTkjgH3AV/VwnQ9kI
         QizF9Nz/Lh6WkZApP+zb+jfZ/hxBK1N+nCsdr52EvL6XSTvi+uUgAK8XC02K8gyIfuQ1
         qQQxKtdrtpZfopKDl2nJLJBNYAXnaOYqkP2gmZu0ooJaUB+NjJMUGETszDoIJ4Z6w6aq
         PNchfr4EVB7lOnzpKMlz9538XMQME4jFOE/9Dzom4x70auwuYfwVQNbUk4wvBJ3am/mD
         zDkPHMgJ2UnjNznT9hTLvhvZ4ZVZXV3bzw0rM9KNMBAsCEwKrEWF4XI1zvM1UEWBKWqM
         e/hA==
X-Gm-Message-State: ACrzQf069DQlJNFpSwEj87yNr81uHzOsyCTGfy8Sb7lpVkguAjPa7+Uu
	bsY96w7MN1XW1g7s7/tnd0hmzbdOycKwgQ==
X-Google-Smtp-Source: AMsMyM5V1jeTHV4nPjXGbtPqbhd2eNZm97l6V2GYwTsKhRtC/q9iij/cI9UK2L8Wi96OH/ZtqnEjSg==
X-Received: by 2002:a17:906:db0d:b0:77b:a7cd:8396 with SMTP id xj13-20020a170906db0d00b0077ba7cd8396mr21339403ejb.264.1666453898534;
        Sat, 22 Oct 2022 08:51:38 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains
Date: Sat, 22 Oct 2022 17:51:13 +0200
Message-Id: <20221022155120.7000-3-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This commit adds array pointers to domains as well as to the hypercall
and configuration structure employed in domain creation. The latter is used
both by the toolstack and by Xen itself to pass configuration data to the
domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to
be able to access guest memory in the first case. This implies special care
for the copy of the configuration data into the domain data, meaning that a
discrimination variable for the two possible code paths (coming from Xen or
from the toolstack) is needed.

The initialization and free functions for colored domains are also added.
The former is responsible for allocating and populating the color array
of the domain and it also checks for configuration issues. One of those
issues is enabling both coloring and directmap for the domain because they
contradicts one another. Since that, Dom0 must not be created with the
directmap flag.
The latter instead frees allocated memory.

Based on original work from: Luca Miccio <lucmiccio@gmail.com>

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
v3:
- xfree() for colors array in case of errors in domain_coloring_init()
---
 docs/misc/arm/cache-coloring.rst    | 14 ++++++-
 xen/arch/arm/coloring.c             | 57 +++++++++++++++++++++++++++++
 xen/arch/arm/domain.c               |  7 ++++
 xen/arch/arm/domain_build.c         | 13 ++++++-
 xen/arch/arm/include/asm/coloring.h | 10 +++++
 xen/arch/arm/include/asm/domain.h   |  4 ++
 xen/include/public/arch-arm.h       |  8 ++++
 7 files changed, 110 insertions(+), 3 deletions(-)

diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
index b0f9a2e917..e8ee8fafde 100644
--- a/docs/misc/arm/cache-coloring.rst
+++ b/docs/misc/arm/cache-coloring.rst
@@ -16,7 +16,7 @@ In order to enable and use it, few steps are needed.
   (refer to menuconfig help for value meaning and when it should be changed).
 
         CONFIG_MAX_CACHE_COLORS=<n>
-- Assign colors to Dom0 using the `Color selection format`_ (see
+- Assign colors to domains using the `Color selection format`_ (see
   `Coloring parameters`_ for more documentation pointers).
 
 Background
@@ -114,6 +114,9 @@ LLC way size (as previously discussed) and Dom0 colors can be set using the
 appropriate command line parameters. See the relevant documentation in
 "docs/misc/xen-command-line.pandoc".
 
+Note that if no color configuration is provided for domains, they fallback to
+the default one, which corresponds simply to all available colors.
+
 Known issues and limitations
 ****************************
 
@@ -133,3 +136,12 @@ too) is set to 2^15 = 32768 colors because of some limitation on the domain
 configuration structure size used in domain creation. "uint16_t" is the biggest
 integer type that fit the constraint and 2^15 is the biggest power of 2 it can
 easily represent. This value is big enough for the generic case, though.
+
+
+"xen,static-mem" isn't supported when coloring is enabled
+#########################################################
+
+In the domain configuration, "xen,static-mem" allows memory to be statically
+allocated to the domain. This isn't possibile when cache coloring is enabled,
+because that memory can't be guaranteed to be of the same colors assigned to
+that domain.
diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
index 36eea2d6c0..a7b59f5aba 100644
--- a/xen/arch/arm/coloring.c
+++ b/xen/arch/arm/coloring.c
@@ -23,6 +23,7 @@
  */
 #include <xen/bitops.h>
 #include <xen/errno.h>
+#include <xen/guest_access.h>
 #include <xen/keyhandler.h>
 #include <xen/param.h>
 #include <xen/types.h>
@@ -232,6 +233,62 @@ bool __init coloring_init(void)
     return true;
 }
 
+int domain_coloring_init(struct domain *d,
+                         const struct xen_arch_domainconfig *config)
+{
+    if ( is_domain_direct_mapped(d) )
+    {
+        printk(XENLOG_ERR
+               "Can't enable coloring and directmap at the same time for %pd\n",
+               d);
+        return -EINVAL;
+    }
+
+    if ( is_hardware_domain(d) )
+    {
+        d->arch.colors = dom0_colors;
+        d->arch.num_colors = dom0_num_colors;
+    }
+    else if ( config->num_colors == 0 )
+    {
+        printk(XENLOG_WARNING
+               "Color config not found for %pd. Using default\n", d);
+        d->arch.colors = xzalloc_array(unsigned int, max_colors);
+        d->arch.num_colors = set_default_domain_colors(d->arch.colors);
+    }
+    else
+    {
+        d->arch.colors = xzalloc_array(unsigned int, config->num_colors);
+        d->arch.num_colors = config->num_colors;
+        if ( config->from_guest )
+            copy_from_guest(d->arch.colors, config->colors, config->num_colors);
+        else
+            memcpy(d->arch.colors, config->colors.p,
+                   sizeof(unsigned int) * config->num_colors);
+    }
+
+    if ( !d->arch.colors )
+    {
+        printk(XENLOG_ERR "Colors allocation failed for %pd\n", d);
+        return -ENOMEM;
+    }
+
+    if ( !check_colors(d->arch.colors, d->arch.num_colors) )
+    {
+        printk(XENLOG_ERR "Bad color config for %pd\n", d);
+        domain_coloring_free(d);
+        return -EINVAL;
+    }
+
+    return 0;
+}
+
+void domain_coloring_free(struct domain *d)
+{
+    if ( !is_hardware_domain(d) )
+        xfree(d->arch.colors);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 2d6253181a..b4dd64dff4 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -23,6 +23,7 @@
 #include <xen/wait.h>
 
 #include <asm/alternative.h>
+#include <asm/coloring.h>
 #include <asm/cpuerrata.h>
 #include <asm/cpufeature.h>
 #include <asm/current.h>
@@ -712,6 +713,10 @@ int arch_domain_create(struct domain *d,
     ioreq_domain_init(d);
 #endif
 
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) &&
+        (rc = domain_coloring_init(d, &config->arch)) )
+        goto fail;
+
     /* p2m_init relies on some value initialized by the IOMMU subsystem */
     if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
         goto fail;
@@ -807,6 +812,8 @@ void arch_domain_destroy(struct domain *d)
                        get_order_from_bytes(d->arch.efi_acpi_len));
 #endif
     domain_io_free(d);
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        domain_coloring_free(d);
 }
 
 void arch_domain_shutdown(struct domain *d)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 40e3c2e119..97f2060007 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -35,6 +35,12 @@
 
 #define STATIC_EVTCHN_NODE_SIZE_CELLS 2
 
+#ifdef CONFIG_CACHE_COLORING
+#define XEN_DOM0_CREATE_FLAGS CDF_privileged
+#else
+#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap
+#endif
+
 static unsigned int __initdata opt_dom0_max_vcpus;
 integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
 
@@ -3963,7 +3969,10 @@ static int __init construct_dom0(struct domain *d)
     /* type must be set before allocate_memory */
     d->arch.type = kinfo.type;
 #endif
-    allocate_memory_11(d, &kinfo);
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        allocate_memory(d, &kinfo);
+    else
+        allocate_memory_11(d, &kinfo);
     find_gnttab_region(d, &kinfo);
 
 #ifdef CONFIG_STATIC_SHM
@@ -4025,7 +4034,7 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
-    dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap);
+    dom0 = domain_create(0, &dom0_cfg, XEN_DOM0_CREATE_FLAGS);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
 
diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
index 3b563d3b90..0d2dfada10 100644
--- a/xen/arch/arm/include/asm/coloring.h
+++ b/xen/arch/arm/include/asm/coloring.h
@@ -27,12 +27,22 @@
 #ifdef CONFIG_CACHE_COLORING
 
 #include <xen/init.h>
+#include <xen/sched.h>
+
+#include <public/arch-arm.h>
 
 bool __init coloring_init(void);
 
+int domain_coloring_init(struct domain *d,
+                         const struct xen_arch_domainconfig *config);
+void domain_coloring_free(struct domain *d);
+
 #else /* !CONFIG_CACHE_COLORING */
 
 static inline bool __init coloring_init(void) { return true; }
+static inline int domain_coloring_init(
+    struct domain *d, const struct xen_arch_domainconfig *config) { return 0; }
+static inline void domain_coloring_free(struct domain *d) {}
 
 #endif /* CONFIG_CACHE_COLORING */
 #endif /* __ASM_ARM_COLORING_H__ */
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index 26a8348eed..291f7c375d 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -58,6 +58,10 @@ struct arch_domain
 #ifdef CONFIG_ARM_64
     enum domain_type type;
 #endif
+#ifdef CONFIG_CACHE_COLORING
+    unsigned int *colors;
+    unsigned int num_colors;
+#endif
 
     /* Virtual MMU */
     struct p2m_domain p2m;
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index c8b6058d3a..adf843a7a1 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
 #define XEN_DOMCTL_CONFIG_TEE_NONE      0
 #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
 
+__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);
+
 struct xen_arch_domainconfig {
     /* IN/OUT */
     uint8_t gic_version;
@@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
      *
      */
     uint32_t clock_frequency;
+    /* IN */
+    uint8_t from_guest;
+    /* IN */
+    uint16_t num_colors;
+    /* IN */
+    XEN_GUEST_HANDLE(color_t) colors;
 };
 #endif /* __XEN__ || __XEN_TOOLS__ */
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428410.678516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmm-00034B-P0; Sat, 22 Oct 2022 15:51:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428410.678516; Sat, 22 Oct 2022 15:51:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmm-00033a-Kh; Sat, 22 Oct 2022 15:51:44 +0000
Received: by outflank-mailman (input) for mailman id 428410;
 Sat, 22 Oct 2022 15:51:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGml-000237-IT
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:43 +0000
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com
 [2a00:1450:4864:20::52f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c818037-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:42 +0200 (CEST)
Received: by mail-ed1-x52f.google.com with SMTP id t18so830969edt.2
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:42 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c818037-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=GWHHd85SPstIESW/WFPVLjHPxgYExJgUfYdkPnInDU0=;
        b=Dzb9hYPPPu6usKi60Q6B7t7Axb6jVxsv8FSp9T/5HkFdMuiqq2YMOGyEHcJhsSYO9w
         9NMYXqhvdAKCGb53Pb67VI/NstyHbMLmjLUAhiiJk1fFpAW7Eg6UGrwdA8gqVNneKxUt
         IamPwmwA077mYZ0E3G8/mEJCFpFoTuhvOd3EzACz9TT3pA8EdaW5ylXEcm1qA1GeSsVE
         FUQRyxhSquci2Z3a2fYzlD87OXgdTQYXHYXPqKQTRNoyYDICNbMCdtGQ+YsKCHaaMtEZ
         4SDBHJbX17KM0ZhfQjo5e1SFHxrKScdtIauaPp3tPOEdISyRJhaE3XbE3r6DdkkF0enC
         wL3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=GWHHd85SPstIESW/WFPVLjHPxgYExJgUfYdkPnInDU0=;
        b=B7SH2Far6AuBO1tEeLUEVcw/FOGDGZSGbUlX/XWXbh2U58Z0Jp0vEOlzasLUD3YUvU
         ACa+u0zvZAsNStLZlJVEuAZLjl+G7vWckGWBUHfz450MRsYV1fNV2HUiknMouHJl6+BH
         5vxXjuD6CvhGouP/iPW5cE7wItW2BAw81S95sq1+0UfHZC9j2hF7EP+09MieK8knzgf8
         HjougUgp30peqMD9gS0B/gzd5k8eNcqDcoHe5qGhGL1lrxn4fvZ7Tl7JS4yZgVctsmgN
         zfuWeEDoBfOF1gcxz3PsEWB7gGtWHIAA1qilUTHRqB8yF426mSYRcELIuz89/qieysG7
         gtFA==
X-Gm-Message-State: ACrzQf1rUqojlzSmCDdYWKMNm4nQtHi0qwjH1fbLnP7exPc8a7bSu4+e
	CXTWe982hDHNQzt0XGT+q5cqpSis6hKzzA==
X-Google-Smtp-Source: AMsMyM48uO6b+yWqGGzt/FDnV9UW58EoI4CDbhHjPxBWpSaUb+u1xH8OKvvBLb0srWjWjtKkern7Yw==
X-Received: by 2002:a05:6402:5ca:b0:43b:6e01:482c with SMTP id n10-20020a05640205ca00b0043b6e01482cmr23173185edx.189.1666453902137;
        Sat, 22 Oct 2022 08:51:42 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v3 4/9] tools/xl: add support for cache coloring configuration
Date: Sat, 22 Oct 2022 17:51:15 +0200
Message-Id: <20221022155120.7000-5-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a new "colors" parameter that defines the color assignment for a
domain. The user can specify one or more color ranges using the same
syntax used everywhere else for color config described in the
documentation. The parameter is defined as a list of strings that represent
the color ranges.
Also documentation is added.

Based on original work from: Luca Miccio <lucmiccio@gmail.com>

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
 docs/man/xl.cfg.5.pod.in         | 10 ++++++
 tools/libs/light/libxl_create.c  | 12 ++++++++
 tools/libs/light/libxl_types.idl |  1 +
 tools/xl/xl_parse.c              | 52 ++++++++++++++++++++++++++++++--
 4 files changed, 73 insertions(+), 2 deletions(-)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b2901e04cf..5f53cec8bf 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -2880,6 +2880,16 @@ Currently, only the "sbsa_uart" model is supported for ARM.
 
 =back
 
+=over 4
+
+=item B<colors=[ "COLORS_RANGE", "COLORS_RANGE", ...]>
+
+Specify the LLC color configuration for the guest. B<COLORS_RANGE> can be either
+a single color value or a hypen-separated closed interval of colors
+(such as "0-4").
+
+=back
+
 =head3 x86
 
 =over 4
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index b9dd2deedf..94c511912c 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -615,6 +615,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
     struct xs_permissions rwperm[1];
     struct xs_permissions noperm[1];
     xs_transaction_t t = 0;
+    DECLARE_HYPERCALL_BUFFER(unsigned int, colors);
 
     /* convenience aliases */
     libxl_domain_create_info *info = &d_config->c_info;
@@ -676,6 +677,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
             goto out;
         }
 
+        if (d_config->b_info.num_colors) {
+            size_t bytes = sizeof(unsigned int) * d_config->b_info.num_colors;
+            colors = xc_hypercall_buffer_alloc(ctx->xch, colors, bytes);
+            memcpy(colors, d_config->b_info.colors, bytes);
+            set_xen_guest_handle(create.arch.colors, colors);
+            create.arch.num_colors = d_config->b_info.num_colors;
+            create.arch.from_guest = 1;
+            LOG(DEBUG, "Setup %u domain colors", d_config->b_info.num_colors);
+        }
+
         for (;;) {
             uint32_t local_domid;
             bool recent;
@@ -922,6 +933,7 @@ retry_transaction:
     rc = 0;
  out:
     if (t) xs_transaction_end(ctx->xsh, t, 1);
+    if (colors) xc_hypercall_buffer_free(ctx->xch, colors);
     return rc;
 }
 
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index d634f304cd..642173af1a 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -557,6 +557,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
     ("ioports",          Array(libxl_ioport_range, "num_ioports")),
     ("irqs",             Array(uint32, "num_irqs")),
     ("iomem",            Array(libxl_iomem_range, "num_iomem")),
+    ("colors",           Array(uint32, "num_colors")),
     ("claim_mode",	     libxl_defbool),
     ("event_channels",   uint32),
     ("kernel",           string),
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 1b5381cef0..e6b2c7acff 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -1220,8 +1220,9 @@ void parse_config_data(const char *config_source,
     XLU_ConfigList *cpus, *vbds, *nics, *pcis, *cvfbs, *cpuids, *vtpms,
                    *usbctrls, *usbdevs, *p9devs, *vdispls, *pvcallsifs_devs;
     XLU_ConfigList *channels, *ioports, *irqs, *iomem, *viridian, *dtdevs,
-                   *mca_caps;
-    int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps;
+                   *mca_caps, *colors;
+    int num_ioports, num_irqs, num_iomem, num_cpus, num_viridian, num_mca_caps,
+        num_colors;
     int pci_power_mgmt = 0;
     int pci_msitranslate = 0;
     int pci_permissive = 0;
@@ -1370,6 +1371,53 @@ void parse_config_data(const char *config_source,
     if (!xlu_cfg_get_long (config, "maxmem", &l, 0))
         b_info->max_memkb = l * 1024;
 
+    if (!xlu_cfg_get_list(config, "colors", &colors, &num_colors, 0)) {
+        int k, p, cur_index = 0;
+
+        b_info->num_colors = 0;
+        /* Get number of colors based on ranges */
+        for (i = 0; i < num_colors; i++) {
+            uint32_t start = 0, end = 0;
+
+            buf = xlu_cfg_get_listitem(colors, i);
+            if (!buf) {
+                fprintf(stderr,
+                    "xl: Unable to get element %d in colors range list\n", i);
+                exit(1);
+            }
+
+            if (sscanf(buf, "%u-%u", &start, &end) != 2) {
+                if (sscanf(buf, "%u", &start) != 1) {
+                    fprintf(stderr, "xl: Invalid color range: %s\n", buf);
+                    exit(1);
+                }
+                end = start;
+            }
+            else if (start > end) {
+                fprintf(stderr,
+                        "xl: Start color is greater than end color: %s\n", buf);
+                exit(1);
+            }
+
+            /* Check for overlaps */
+            for (k = start; k <= end; k++) {
+                for (p = 0; p < b_info->num_colors; p++) {
+                    if (b_info->colors[p] == k) {
+                        fprintf(stderr, "xl: Overlapped ranges not allowed\n");
+                        exit(1);
+                    }
+                }
+            }
+
+            b_info->num_colors += (end - start) + 1;
+            b_info->colors = (uint32_t *)realloc(b_info->colors,
+                                sizeof(*b_info->colors) * b_info->num_colors);
+
+            for (k = start; k <= end; k++)
+                b_info->colors[cur_index++] = k;
+        }
+    }
+
     if (!xlu_cfg_get_long (config, "vcpus", &l, 0)) {
         vcpus = l;
         if (libxl_cpu_bitmap_alloc(ctx, &b_info->avail_vcpus, l)) {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428411.678527 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmp-0003OT-31; Sat, 22 Oct 2022 15:51:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428411.678527; Sat, 22 Oct 2022 15:51:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmo-0003OK-VY; Sat, 22 Oct 2022 15:51:46 +0000
Received: by outflank-mailman (input) for mailman id 428411;
 Sat, 22 Oct 2022 15:51:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmn-000237-Na
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:45 +0000
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com
 [2a00:1450:4864:20::530])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ddd540c-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:44 +0200 (CEST)
Received: by mail-ed1-x530.google.com with SMTP id m15so16315002edb.13
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:44 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:43 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ddd540c-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=3IqxEd6ecjPYBOtLoN10L6xas1AQwaOpYMS5dlVn26c=;
        b=AnibrlyVna0JrSAb+Wcx608MliwsWks84GNTUO3gu30o7DKgQLNyjjYMPpMdcVWfk8
         dvd+CjWrZ+hH3VD8aIIEh/Vuk+I8wRj9n93vfsUDYUWsObo9orS1EpxSX4ONEJgdkB6i
         8r+96FmkVCI4Zia20IHhdH8OO/hTK0BmunIay8Kx5n1OL8J/Rp/q5kMwZKwZTvTtPZbk
         c6axh+eNWabSv+VkBWw+0k9B0J6j3uoy+RyBu116L4xzXBEJFLNyLDcT2zn9FDy1cn0f
         pWQqtdFrD+fLM90dNR15b1KUZCQDi9+sLS+V38hiXf8oN9dtPtsRYDpbWoN3t2L6Q3dG
         2Tpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=3IqxEd6ecjPYBOtLoN10L6xas1AQwaOpYMS5dlVn26c=;
        b=zzFTw+JWFKGnCEChIQk/PQn3BMegkvl4nPwP3KOYM1zRMGVWtVHmAjn75fPbq0Ed3g
         Qfs0QyeMEUvWur7W+ByWg+o13f7tLNF6KAJnCqPQ9+Rp+Kahx1NCuBSRDScFQm4/66P9
         zrEOKMcGZvVByLL8vlIszfbUYr5BIEylmtg9XsPWO8qj2ggO4UZUk4a35wP8MSZAd0kd
         zezZGAl5WRr1yEALxjjZC1zQkrHB3uG95XEgqtwv5F8rK7wWXZGAD0aqkxc/N+84yJEe
         Tj8JBY8D5/zOmLy9c/QiUlHiA4YTugPo4J9fbOX2g5mtF+mxVyQegq222SOg3W8fQKUt
         JD7Q==
X-Gm-Message-State: ACrzQf0RieeIULocoQlcajLJ2xu0M8rpqfHFRskEstUO06Oxp4GM3gnQ
	G6Qo8rC6AD+mJlZMPz4jLQoRjZHluEae1g==
X-Google-Smtp-Source: AMsMyM5kZAsF9pqs0EPB0QqBNlKxkIbAGyFH/lxOkA1oUz5eDfTOahALIsuwSHfCwkMqxwaJ5ad07Q==
X-Received: by 2002:a17:907:2c4f:b0:78d:eebe:f413 with SMTP id hf15-20020a1709072c4f00b0078deebef413mr20626768ejc.221.1666453904210;
        Sat, 22 Oct 2022 08:51:44 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v3 5/9] xen/arm: add support for cache coloring configuration via device-tree
Date: Sat, 22 Oct 2022 17:51:16 +0200
Message-Id: <20221022155120.7000-6-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This commit adds the "colors" Device Tree attribute that can be used for
DomUs and Dom0less color configurations. The syntax is the same used
for every color config.

Based on original work from: Luca Miccio <lucmiccio@gmail.com>

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
 docs/misc/arm/cache-coloring.rst      | 45 +++++++++++++++++++++++++++
 docs/misc/arm/device-tree/booting.txt |  4 +++
 xen/arch/arm/coloring.c               | 17 ++++++++++
 xen/arch/arm/domain_build.c           | 13 ++++++++
 xen/arch/arm/include/asm/coloring.h   |  5 +++
 5 files changed, 84 insertions(+)

diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
index e8ee8fafde..dd2e851a26 100644
--- a/docs/misc/arm/cache-coloring.rst
+++ b/docs/misc/arm/cache-coloring.rst
@@ -114,6 +114,51 @@ LLC way size (as previously discussed) and Dom0 colors can be set using the
 appropriate command line parameters. See the relevant documentation in
 "docs/misc/xen-command-line.pandoc".
 
+DomUs colors can be set either in the xl configuration file (relative
+documentation at "docs/man/xl.cfg.pod.5.in") or via Device Tree, also for
+Dom0less configurations, as in the following example:
+
+.. raw:: html
+
+    <pre>
+        xen,xen-bootargs = "console=dtuart dtuart=serial0 dom0_mem=1G dom0_max_vcpus=1 sched=null llc-way-size=64K xen-colors=0-1 dom0-colors=2-6";
+        xen,dom0-bootargs "console=hvc0 earlycon=xen earlyprintk=xen root=/dev/ram0"
+
+        dom0 {
+            compatible = "xen,linux-zimage" "xen,multiboot-module";
+            reg = <0x0 0x1000000 0x0 15858176>;
+        };
+
+        dom0-ramdisk {
+            compatible = "xen,linux-initrd" "xen,multiboot-module";
+            reg = <0x0 0x2000000 0x0 20638062>;
+        };
+
+        domU0 {
+            #address-cells = <0x1>;
+            #size-cells = <0x1>;
+            compatible = "xen,domain";
+            memory = <0x0 0x40000>;
+            colors = "4-8,10,11,12";
+            cpus = <0x1>;
+            vpl011 = <0x1>;
+
+            module@2000000 {
+                compatible = "multiboot,kernel", "multiboot,module";
+                reg = <0x2000000 0xffffff>;
+                bootargs = "console=ttyAMA0";
+            };
+
+            module@30000000 {
+                compatible = "multiboot,ramdisk", "multiboot,module";
+                reg = <0x3000000 0xffffff>;
+            };
+        };
+    </pre>
+
+Please refer to the relative documentation in
+"docs/misc/arm/device-tree/booting.txt".
+
 Note that if no color configuration is provided for domains, they fallback to
 the default one, which corresponds simply to all available colors.
 
diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index c47a05e0da..3aa493c66d 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -162,6 +162,10 @@ with the following properties:
 
     An integer specifying the number of vcpus to allocate to the guest.
 
+- colors
+    A string specifying the color configuration for the guest. Refer to
+    "docs/misc/arm/cache_coloring.rst" for syntax.
+
 - vpl011
 
     An empty property to enable/disable a virtual pl011 for the guest to
diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
index cf8aa8a2ca..685a431c3d 100644
--- a/xen/arch/arm/coloring.c
+++ b/xen/arch/arm/coloring.c
@@ -273,8 +273,11 @@ int domain_coloring_init(struct domain *d,
         if ( config->from_guest )
             copy_from_guest(d->arch.colors, config->colors, config->num_colors);
         else
+        {
             memcpy(d->arch.colors, config->colors.p,
                    sizeof(unsigned int) * config->num_colors);
+            xfree(config->colors.p);
+        }
     }
 
     if ( !d->arch.colors )
@@ -305,6 +308,20 @@ void domain_dump_coloring_info(struct domain *d)
     print_colors(d->arch.colors, d->arch.num_colors);
 }
 
+void prepare_color_domain_config(struct xen_arch_domainconfig *config,
+                                 const char *colors_str)
+{
+    unsigned int num_colors;
+
+    config->colors.p = xzalloc_array(unsigned int, max_colors);
+    if ( !config->colors.p )
+        panic("Unable to allocate cache colors\n");
+
+    if ( parse_color_config(colors_str, config->colors.p, &num_colors) )
+        panic("Error parsing the color configuration\n");
+    config->num_colors = (uint16_t)num_colors;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 97f2060007..b95e655331 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -25,6 +25,7 @@
 #include <asm/platform.h>
 #include <asm/psci.h>
 #include <asm/setup.h>
+#include <asm/coloring.h>
 #include <asm/cpufeature.h>
 #include <asm/domain_build.h>
 #include <xen/event.h>
@@ -3826,6 +3827,7 @@ void __init create_domUs(void)
     struct dt_device_node *node;
     const struct dt_device_node *cpupool_node,
                                 *chosen = dt_find_node_by_path("/chosen");
+    const char *colors_str;
 
     BUG_ON(chosen == NULL);
     dt_for_each_child_node(chosen, node)
@@ -3914,6 +3916,17 @@ void __init create_domUs(void)
             d_cfg.cpupool_id = pool_id;
         }
 
+        if ( !dt_property_read_string(node, "colors", &colors_str) )
+        {
+            if ( !IS_ENABLED(CONFIG_CACHE_COLORING) )
+                printk(XENLOG_WARNING
+                       "Property 'colors' found, but coloring is disabled\n");
+            else if ( dt_find_property(node, "xen,static-mem", NULL) )
+                panic("static-mem isn't allowed when coloring is enabled\n");
+            else
+                prepare_color_domain_config(&d_cfg.arch, colors_str);
+        }
+
         /*
          * The variable max_init_domid is initialized with zero, so here it's
          * very important to use the pre-increment operator to call
diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
index a16736819e..549eb408a3 100644
--- a/xen/arch/arm/include/asm/coloring.h
+++ b/xen/arch/arm/include/asm/coloring.h
@@ -38,6 +38,9 @@ int domain_coloring_init(struct domain *d,
 void domain_coloring_free(struct domain *d);
 void domain_dump_coloring_info(struct domain *d);
 
+void prepare_color_domain_config(struct xen_arch_domainconfig *config,
+                                 const char *colors_str);
+
 #else /* !CONFIG_CACHE_COLORING */
 
 static inline bool __init coloring_init(void) { return true; }
@@ -45,6 +48,8 @@ static inline int domain_coloring_init(
     struct domain *d, const struct xen_arch_domainconfig *config) { return 0; }
 static inline void domain_coloring_free(struct domain *d) {}
 static inline void domain_dump_coloring_info(struct domain *d) {}
+static inline void prepare_color_domain_config(
+    struct xen_arch_domainconfig *config, const char *colors_str) {}
 
 #endif /* CONFIG_CACHE_COLORING */
 #endif /* __ASM_ARM_COLORING_H__ */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428409.678500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGml-0002gg-IH; Sat, 22 Oct 2022 15:51:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428409.678500; Sat, 22 Oct 2022 15:51:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGml-0002dq-Cl; Sat, 22 Oct 2022 15:51:43 +0000
Received: by outflank-mailman (input) for mailman id 428409;
 Sat, 22 Oct 2022 15:51:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmj-000237-P9
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:41 +0000
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com
 [2a00:1450:4864:20::530])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b7dbd17-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:41 +0200 (CEST)
Received: by mail-ed1-x530.google.com with SMTP id m15so16314590edb.13
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:41 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b7dbd17-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=44pwASrsnAtpDyfghbc69EETaGukeSYMbtotZhaVziA=;
        b=67egSdyQL5j+k0rN/iWcaUcLI1czr9vtDoWgZlfZPgZ/pUhPe8QBKsSV9mAAbyz1dD
         DxTEvp9iYYSk0yajTw62FmJ5xf1qz3SwLM1s3nO9ChGgAz/86GBvGFjwTzsTZQ8ln2I/
         R8nCjfauW+gTeK8K/OYu0J6Wxv7MKhmzgNENwro9MOUWiOSeXHwMvY8/pa7d7dlB+utn
         1/VD+x0DQUbO3STeE3w7KVxFwNpgGQtTbwv+AKEVSRkfbl/AONqXFlLYfxSVGiBje+5g
         GQAZEsGVuRiG2KBNB9itfOKRTZibjbn3vYiz5xo7s4V/OlOijTo9+r3YNNNipcIkrIUL
         lnGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=44pwASrsnAtpDyfghbc69EETaGukeSYMbtotZhaVziA=;
        b=AZIeJzQFwiYfzOy4JasOyfoA2dgvIG/6RqjhOZl7GCmdf8oP7aYM/NjQaVUtm+KHBr
         F8lH8Vk+J5mkWrXJeH1XFGRMcVUNZa+hZUCM7mh2b6XfnyIC2IR8HCbfop0tRyLz3WH4
         FOWkKJcdBix+wEv0XHdttCBFOJ82FmUHoSk4h397Tn/i1Vdej3ZmWYjzKrw54LpeHlzy
         GuxuPr6lI6yxoQz3D9mgEEV1C1CKjOzQzvdGwvaf2fjKs9w5ae6h8tg++1kMVXq5yus3
         gRuYGmcVjpuAeNazDJ70PlGdLUC1wZBYUc8GSKzMf9QOZEJ0VrX46W8pV52Pg3Y8wFUl
         HLBA==
X-Gm-Message-State: ACrzQf05dtd+eiJlAhyDaJEGHtJtdDDEqSI9v/Mv/imUVqLdpdfIhbJI
	ggH6i2wH9P2pa6YksWkWCiiAUwnAd+c6bA==
X-Google-Smtp-Source: AMsMyM6fXvk7dOHt5Y489MTW7mh6g9xd/jtS5DU9BKHmegYyol5/wT6I/wSwGz3b79bgbfbPVrA7Hg==
X-Received: by 2002:a17:907:75c6:b0:79c:d3f4:4a14 with SMTP id jl6-20020a17090775c600b0079cd3f44a14mr6524923ejc.61.1666453900285;
        Sat, 22 Oct 2022 08:51:40 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Marco Solieri <marco.solieri@minervasys.tech>,
	Carlo Nonato <carlo.nonato@minervasys.tech>
Subject: [PATCH v3 3/9] xen/arm: dump cache colors in domain info debug-key
Date: Sat, 22 Oct 2022 17:51:14 +0200
Message-Id: <20221022155120.7000-4-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

This commit adds cache colors to the information dumped with the domain
info debug-key.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
---
 xen/arch/arm/coloring.c             | 16 ++++++++++++++++
 xen/arch/arm/domain.c               |  2 ++
 xen/arch/arm/include/asm/coloring.h |  2 ++
 3 files changed, 20 insertions(+)

diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
index a7b59f5aba..cf8aa8a2ca 100644
--- a/xen/arch/arm/coloring.c
+++ b/xen/arch/arm/coloring.c
@@ -172,6 +172,16 @@ static unsigned int set_default_domain_colors(unsigned int *colors)
     return max_colors;
 }
 
+static void print_colors(unsigned int *colors, unsigned int num_colors)
+{
+    unsigned int i;
+
+    printk("[ ");
+    for ( i = 0; i < num_colors; i++ )
+        printk("%u ", colors[i]);
+    printk("]\n");
+}
+
 static void dump_coloring_info(unsigned char key)
 {
     printk("'%c' pressed -> dumping coloring general info\n", key);
@@ -289,6 +299,12 @@ void domain_coloring_free(struct domain *d)
         xfree(d->arch.colors);
 }
 
+void domain_dump_coloring_info(struct domain *d)
+{
+    printk("Domain %pd has %u colors: ", d, d->arch.num_colors);
+    print_colors(d->arch.colors, d->arch.num_colors);
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index b4dd64dff4..b174a192d4 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1083,6 +1083,8 @@ int domain_relinquish_resources(struct domain *d)
 void arch_dump_domain_info(struct domain *d)
 {
     p2m_dump_info(d);
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        domain_dump_coloring_info(d);
 }
 
 
diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
index 0d2dfada10..a16736819e 100644
--- a/xen/arch/arm/include/asm/coloring.h
+++ b/xen/arch/arm/include/asm/coloring.h
@@ -36,6 +36,7 @@ bool __init coloring_init(void);
 int domain_coloring_init(struct domain *d,
                          const struct xen_arch_domainconfig *config);
 void domain_coloring_free(struct domain *d);
+void domain_dump_coloring_info(struct domain *d);
 
 #else /* !CONFIG_CACHE_COLORING */
 
@@ -43,6 +44,7 @@ static inline bool __init coloring_init(void) { return true; }
 static inline int domain_coloring_init(
     struct domain *d, const struct xen_arch_domainconfig *config) { return 0; }
 static inline void domain_coloring_free(struct domain *d) {}
+static inline void domain_dump_coloring_info(struct domain *d) {}
 
 #endif /* CONFIG_CACHE_COLORING */
 #endif /* __ASM_ARM_COLORING_H__ */
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428406.678472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmg-00023L-AM; Sat, 22 Oct 2022 15:51:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428406.678472; Sat, 22 Oct 2022 15:51:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmg-00023E-7l; Sat, 22 Oct 2022 15:51:38 +0000
Received: by outflank-mailman (input) for mailman id 428406;
 Sat, 22 Oct 2022 15:51:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGme-000237-F1
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:36 +0000
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com
 [2a00:1450:4864:20::52f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66fea70d-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:34 +0200 (CEST)
Received: by mail-ed1-x52f.google.com with SMTP id z97so16335700ede.8
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:33 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.31
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66fea70d-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=/jVBSsJ9+eO182bhm4hzhFdzePeCxIyKg2P2EmAkMEE=;
        b=Yff+Fopw3K4BIyPa1RKnQFQW9HLtMY57AV80steTB6khTg/Urfb6tb4G27gpoZxDD+
         tmJUjT5SEHc9ZtP3xYUImF/GjP2XnAQrU01YN7met8BDVYqk+2SlQlbQ2QHExWKRx8cu
         eeTwnFHdvHYmOaTgMcz0cCiA7JvB0fRAFSuavtynMOP2btwoPO7YfPyZsiUZJgL/V2PP
         qOIhLFlEiweS4RvyYvbTKxnCfzS4uRmYj+oyHgVU/R4UsNs3OMTyQR9VM0fzMUZGE/xn
         iyw7WyxhufSO4w/zX5vGTTsiVGA6mbK9Yy4ytXvaefuhsP8dbrscoPbYyzex+erw8w+y
         6bzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=/jVBSsJ9+eO182bhm4hzhFdzePeCxIyKg2P2EmAkMEE=;
        b=2JnWTplVuTu3fEf/lVXFQ5gmUD6kCKGletjLxeQ0w1E7lWa9cW1I9ZqoWZ6zt2+Oqw
         XH8PsSxFdv0qTu8b3rayhRrcqa+kt6MYBBJ74PfQg0laG1K86CAeO9aInTRradKOTXRQ
         9RrHOPzc73PFZbLHRMIQyFSCHdmVQFxcUjzN87FC1aPiX7mMTNwhtbkM150k4jz4sHpP
         kqfgCBWX86OYBNkBMOGvE85LRdTfNpAEbrGJ8JxJqyT32OiC/dFJbZxn41PEqaXhLPO2
         VAii2uX96Ls4ed6YCNBmplihokNYgBPMVJ8dtVM63sQ261nXNm1iAc8Tj8s2FpmPNLb+
         hISQ==
X-Gm-Message-State: ACrzQf11113UsPAhx0McRhmrf/cQ1iNBcDvZVNlv+V3wGS1JnPgB5yF+
	C6jqp98JCDtx/jkEaIuup40dBBDPxw4HHA==
X-Google-Smtp-Source: AMsMyM4XCclR/lk6sFXOuBZmMUvApnhtgJRznwMEP+4Z8SVBz7vc6VKTGcbyjAQQq8aSynPP71Ezjw==
X-Received: by 2002:a17:907:a4a:b0:77b:c1b2:479a with SMTP id be10-20020a1709070a4a00b0077bc1b2479amr17627956ejc.109.1666453892625;
        Sat, 22 Oct 2022 08:51:32 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 0/9] Arm cache coloring
Date: Sat, 22 Oct 2022 17:51:11 +0200
Message-Id: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Shared caches in multi-core CPU architectures represent a problem for
predictability of memory access latency. This jeopardizes applicability
of many Arm platform in real-time critical and mixed-criticality
scenarios. We introduce support for cache partitioning with page
coloring, a transparent software technique that enables isolation
between domains and Xen, and thus avoids cache interference.

When creating a domain, a simple syntax (e.g. `0-3` or `4-11`) allows
the user to define assignments of cache partitions ids, called colors,
where assigning different colors guarantees no mutual eviction on cache
will ever happen. This instructs the Xen memory allocator to provide
the i-th color assignee only with pages that maps to color i, i.e. that
are indexed in the i-th cache partition.

The proposed implementation supports the dom0less feature.
The proposed implementation doesn't support the static-mem feature.
The solution has been tested in several scenarios, including Xilinx Zynq
MPSoCs.

Commits structure:
- [1-3] Coloring initialization, cache layout auto-probing and coloring
  data for domains.
- [4-5] xl and Device Tree support for coloring.
- [6] New page allocator for domain memory that implement the cache
  coloring mechanism.
- [7-9] Coloring support for Xen.

Global changes in v3:
- fixed a compilation error because of a forgotten "\"
- replaced some #ifdef with if ( IS_ENABLED )
- other minor changes (docs, typos, variable types, style, etc.)
- better acknowledged Luca Miccio as the original author
- removed #8 since the bootmodule address and size can be replaced without
  the need of this particular revert
- removed #9 since it wasn't a clean revert and thanks to Julien things can
  be done in a smarter way sticking with map_pages_to_xen() (see new #9)

Open points:
- The allocator proposed in #6 works only with order-0 pages and inserts
  them in a sorted list using a linear search. This behavior can be slow if
  large amount of memory is given to it, so the user is warned in the
  documentation for that.
  In a following patch, that I'm going to send separately, a simple buddy
  allocator that indexes pages by color is presented. It can serve higher
  order pages and doesn't need the linear search. Unfortunately, it has
  some flaws that I will discuss there.
- I will address the latest v2 comments from Julien in v4

Acknowledgements
----------------

This work is sponsored by Xilinx Inc., and supported by University of
Modena and Reggio Emilia and Minerva Systems.

Carlo Nonato (6):
  xen/arm: add cache coloring initialization
  xen/arm: add cache coloring initialization for domains
  tools/xl: add support for cache coloring configuration
  xen/arm: add support for cache coloring configuration via device-tree
  Revert "xen/arm: Remove unused BOOT_RELOC_VIRT_START"
  xen/arm: add cache coloring support for Xen

Luca Miccio (3):
  xen/arm: dump cache colors in domain info debug-key
  xen/common: add cache coloring allocator for domains
  xen/arm: add Xen cache colors command line parameter

 docs/man/xl.cfg.5.pod.in              |  10 +
 docs/misc/arm/cache-coloring.rst      | 229 ++++++++++++++
 docs/misc/arm/device-tree/booting.txt |   4 +
 docs/misc/xen-command-line.pandoc     |  49 +++
 tools/libs/light/libxl_create.c       |  12 +
 tools/libs/light/libxl_types.idl      |   1 +
 tools/xl/xl_parse.c                   |  52 +++-
 xen/arch/arm/Kconfig                  |  34 +++
 xen/arch/arm/Makefile                 |   1 +
 xen/arch/arm/alternative.c            |   9 +-
 xen/arch/arm/arm64/head.S             |  48 +++
 xen/arch/arm/coloring.c               | 411 ++++++++++++++++++++++++++
 xen/arch/arm/domain.c                 |   9 +
 xen/arch/arm/domain_build.c           |  26 +-
 xen/arch/arm/include/asm/coloring.h   |  91 ++++++
 xen/arch/arm/include/asm/config.h     |   4 +-
 xen/arch/arm/include/asm/domain.h     |   4 +
 xen/arch/arm/include/asm/mm.h         |  19 +-
 xen/arch/arm/include/asm/processor.h  |  16 +
 xen/arch/arm/mm.c                     |  95 +++++-
 xen/arch/arm/p2m.c                    |   7 +-
 xen/arch/arm/psci.c                   |   4 +-
 xen/arch/arm/setup.c                  |  81 ++++-
 xen/arch/arm/smpboot.c                |   3 +-
 xen/arch/arm/xen.lds.S                |   2 +-
 xen/common/Kconfig                    |   3 +
 xen/common/page_alloc.c               | 259 ++++++++++++++--
 xen/include/public/arch-arm.h         |   8 +
 xen/include/xen/mm.h                  |  43 +++
 29 files changed, 1487 insertions(+), 47 deletions(-)
 create mode 100644 docs/misc/arm/cache-coloring.rst
 create mode 100644 xen/arch/arm/coloring.c
 create mode 100644 xen/arch/arm/include/asm/coloring.h

-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428412.678538 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGms-0003lK-F7; Sat, 22 Oct 2022 15:51:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428412.678538; Sat, 22 Oct 2022 15:51:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGms-0003l3-As; Sat, 22 Oct 2022 15:51:50 +0000
Received: by outflank-mailman (input) for mailman id 428412;
 Sat, 22 Oct 2022 15:51:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmq-000237-VP
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:49 +0000
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com
 [2a00:1450:4864:20::52f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f4a21bc-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:47 +0200 (CEST)
Received: by mail-ed1-x52f.google.com with SMTP id w8so14079932edc.1
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:47 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:45 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f4a21bc-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=pm5NZV8ivNJJW7gXCvwFeNKDFFL/u9QvZuT7iBhn0cY=;
        b=WPbIgg1doPwjYuKhOlGtc/aH2wgwy2ZV2CEVKTDP6YwXiF8Nydigs3jRl5R9ySgBKe
         pgaavScDWQsgig3qvibbeMllwXemi2mzEipFRaErVqutLw2vONANBb/g82zyj2sBG9gl
         +o3zHVIfpMmM0DWvDWMWCue4upt4aUeG0IjPPS5W6fSeFJZ2fJwYzf9Jf9kEjZahv66k
         nmC2uWfzfdmTHPAfyodYkbZWxDaqV8MCeoyd7CkhhDS+7VVe1p65BgUwKI2UpRSj6H7a
         asuXUKz6PXmwoM6Rmn58Kd0kJG4eEhay1IVpKl8jGknFeS19xU3pfHM++x0o0qZq5Lcy
         dxgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=pm5NZV8ivNJJW7gXCvwFeNKDFFL/u9QvZuT7iBhn0cY=;
        b=wlGZvxTtZl/ieCbmouNMICjMSZmO66xvPESKPkebQrCDC8z5yK/KBmPKX06ioTAX77
         FwoIKrDKBnE8B/QuV5K7b68bpeNPbuIMZc3QwIh4odJBq876thr24+M/0OJVCgmSIjzU
         L3bFU9fFAv9JI/9UHnmEACekVN96P9+vwsXVGR54cWfCGWa3b8V+X3yFqa0SSov1CKb1
         uaRsp9qxA15wEpwSCiZFD2H+s1JtxySlQyDnHFbKU53IOaVsC/bweu5YumMXkDpPC/Yu
         dSAoeeUp3//Q93JQuiOjeJOVXJwzhtrg5mWnZew5tcreVfmz8YMPJdOsm1BK5mSXfGZZ
         ANXQ==
X-Gm-Message-State: ACrzQf2zZ79qtNA/twGTQnEp279RGdT1NmoaXcbreIWsJIkKVX5URRyG
	n5NeMc/AQALzsdXNx42UtTsNQZNi9zgBaA==
X-Google-Smtp-Source: AMsMyM4QsEmAhIsc/c6qFUJDWgdszNUuPr24Jg9tFKoIrRyZOdA/6zRVpZL/EhrKZDzjb+1We2vmOA==
X-Received: by 2002:a17:907:d93:b0:78d:fe7a:f1fe with SMTP id go19-20020a1709070d9300b0078dfe7af1femr20970678ejc.721.1666453906124;
        Sat, 22 Oct 2022 08:51:46 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Marco Solieri <marco.solieri@minervasys.tech>,
	Carlo Nonato <carlo.nonato@minervasys.tech>
Subject: [PATCH v3 6/9] xen/common: add cache coloring allocator for domains
Date: Sat, 22 Oct 2022 17:51:17 +0200
Message-Id: <20221022155120.7000-7-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

This commit adds a new memory page allocator that implements the cache
coloring mechanism. The allocation algorithm follows the given domain color
configuration and maximizes contiguity in the page selection of multiple
subsequent requests.

Pages are stored in a color-indexed array of lists, each one sorted by
machine address, that is called the colored heap. A simple initialization
function computes the color of any available page and inserts it in the
corresponding list. When a domain requests a page, the allocator takes one
from the subset of lists whose colors equals the domain configuration. It
chooses the page with the highest machine address such that contiguous
pages are sequentially allocated, if this is made possible by a color
assignment which includes adjacent colors.

The allocator can handle only requests with order equals to 0 since the
single color granularity is represented in memory by one page.

The buddy allocator must coexist with the colored one because the Xen heap
isn't colored. For this reason a new Kconfig option and a command line
parameter are added to let the user set the amount of memory reserved for
the buddy allocator. Even when cache coloring is enabled, this memory isn't
managed by the colored allocator.

Colored heap information is dumped in the dump_heap() debug-key function.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
---
v3:
- fixed PGC_colored bits values
- merged debug-key for dump_color_heap() with the one for dump_heap()
- number of pages for each color in an array to easily dump color heap info
- heap_lock in colored allocator to ensure atomicity and clarify it with a
  comment
- added page_list_add_{next|prev} to add pages in the middle of the list
- p2m tables use pages of same colors as domain
- CONFIG_BUDDY_ALLOCATOR_SIZE is now an int (MiB)
- buddy allocator reserved size is now respected as configured in Kconfig
- removed useless functions and refactored the code
- fixed PGC_colored flag that was removed when a page was allocated
- merged with #7 since it would have been too small
---
 docs/misc/arm/cache-coloring.rst    |  39 ++++-
 docs/misc/xen-command-line.pandoc   |  14 ++
 xen/arch/arm/Kconfig                |  12 ++
 xen/arch/arm/coloring.c             |  10 ++
 xen/arch/arm/include/asm/coloring.h |   6 +
 xen/arch/arm/include/asm/mm.h       |   3 +
 xen/arch/arm/p2m.c                  |   7 +-
 xen/common/page_alloc.c             | 259 +++++++++++++++++++++++++---
 xen/include/xen/mm.h                |  43 +++++
 9 files changed, 371 insertions(+), 22 deletions(-)

diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
index dd2e851a26..0c89278aee 100644
--- a/docs/misc/arm/cache-coloring.rst
+++ b/docs/misc/arm/cache-coloring.rst
@@ -16,6 +16,9 @@ In order to enable and use it, few steps are needed.
   (refer to menuconfig help for value meaning and when it should be changed).
 
         CONFIG_MAX_CACHE_COLORS=<n>
+- If needed, change the amount of memory reserved for the buddy allocator either
+  from the Xen configuration file, via the CONFIG_BUDDY_ALLOCATOR_SIZE value,
+  or with the command line option. See `Colored allocator and buddy allocator`.
 - Assign colors to domains using the `Color selection format`_ (see
   `Coloring parameters`_ for more documentation pointers).
 
@@ -162,6 +165,18 @@ Please refer to the relative documentation in
 Note that if no color configuration is provided for domains, they fallback to
 the default one, which corresponds simply to all available colors.
 
+Colored allocator and buddy allocator
+*************************************
+
+The colored allocator distributes pages based on color configurations of
+domains so that each domains only gets pages of its own colors.
+The colored allocator is meant as an alternative to the buddy allocator because
+its allocation policy is by definition incompatible with the generic one. Since
+the Xen heap is not colored yet, we need to support the coexistence of the two
+allocators and some memory must be left for the buddy one.
+The buddy allocator memory can be reserved from the Xen configuration file or
+with the help of a command-line option.
+
 Known issues and limitations
 ****************************
 
@@ -182,7 +197,6 @@ configuration structure size used in domain creation. "uint16_t" is the biggest
 integer type that fit the constraint and 2^15 is the biggest power of 2 it can
 easily represent. This value is big enough for the generic case, though.
 
-
 "xen,static-mem" isn't supported when coloring is enabled
 #########################################################
 
@@ -190,3 +204,26 @@ In the domain configuration, "xen,static-mem" allows memory to be statically
 allocated to the domain. This isn't possibile when cache coloring is enabled,
 because that memory can't be guaranteed to be of the same colors assigned to
 that domain.
+
+Colored allocator can only make use of order-0 pages
+####################################################
+
+The cache coloring technique relies on memory mappings and on the smallest
+amount of memory that can be mapped to achieve the maximum number of colors
+(cache partitions) possible. This amount is what is normally called a page and,
+in Xen terminology, the order-0 page is the smallest one. The fairly simple
+colored allocator currently implemented, makes use only of such pages.
+It must be said that a more complex one could, in theory, adopt higher order
+pages if the colors selection contained adjacent colors. Two subsequent colors,
+for example, can be represented by an order-1 page, four colors correspond to
+an order-2 page, etc.
+
+Fail to boot colored DomUs with large memory size
+#################################################
+
+If the Linux kernel used for Dom0 does not contain the upstream commit
+3941552aec1e04d63999988a057ae09a1c56ebeb and uses the hypercall buffer device,
+colored DomUs with memory size larger then 127 MB cannot be created. This is
+caused by the default limit of this buffer of 64 pages. The solution is to
+manually apply the above patch, or to check if there is an updated version of
+the kernel in use for Dom0 that contains this change.
diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 3f04414134..25a59dd6a9 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -299,6 +299,20 @@ can be maintained with the pv-shim mechanism.
     cause Xen not to use Indirect Branch Tracking even when support is
     available in hardware.
 
+### buddy-alloc-size (arm64)
+> `= <size>`
+
+> Default: `64M`
+
+Amount of memory reserved for the buddy allocator when colored allocator is
+active. This options is parsed only when cache coloring support is enabled.
+The colored allocator is meant as an alternative to the buddy allocator,
+because its allocation policy is by definition incompatible with the
+generic one. Since the Xen heap systems is not colored yet, we need to
+support the coexistence of the two allocators for now. This parameter, which is
+optional and for expert only, it's used to set the amount of memory reserved to
+the buddy allocator.
+
 ### clocksource (x86)
 > `= pit | hpet | acpi | tsc`
 
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index c45a9c5917..4cfa75b2ef 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -153,6 +153,18 @@ config MAX_CACHE_COLORS
 	  Note that if, at any time, a color configuration with more colors than the
 	  maximum is employed, an error is produced.
 
+config BUDDY_ALLOCATOR_SIZE
+	int "Buddy allocator reserved memory size (MiB)"
+	default "64"
+	depends on CACHE_COLORING
+	help
+	  Amount of memory reserved for the buddy allocator to work alongside
+	  the colored one. The colored allocator is meant as an alternative to the
+	  buddy allocator because its allocation policy is by definition
+	  incompatible with the generic one. Since the Xen heap is not colored yet,
+	  we need to support the coexistence of the two allocators and some memory
+	  must be left for the buddy one.
+
 config TEE
 	bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED
 	default n
diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
index 685a431c3d..2cae215cd2 100644
--- a/xen/arch/arm/coloring.c
+++ b/xen/arch/arm/coloring.c
@@ -322,6 +322,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config,
     config->num_colors = (uint16_t)num_colors;
 }
 
+unsigned int page_to_color(const struct page_info *pg)
+{
+    return addr_to_color(page_to_maddr(pg));
+}
+
+unsigned int get_max_colors(void)
+{
+    return max_colors;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
index 549eb408a3..0147f95968 100644
--- a/xen/arch/arm/include/asm/coloring.h
+++ b/xen/arch/arm/include/asm/coloring.h
@@ -31,6 +31,8 @@
 
 #include <public/arch-arm.h>
 
+struct page_info;
+
 bool __init coloring_init(void);
 
 int domain_coloring_init(struct domain *d,
@@ -41,6 +43,10 @@ void domain_dump_coloring_info(struct domain *d);
 void prepare_color_domain_config(struct xen_arch_domainconfig *config,
                                  const char *colors_str);
 
+unsigned int page_to_color(const struct page_info *pg);
+
+unsigned int get_max_colors(void);
+
 #else /* !CONFIG_CACHE_COLORING */
 
 static inline bool __init coloring_init(void) { return true; }
diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index 68adcac9fa..e848fa4adf 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -128,6 +128,9 @@ struct page_info
 #else
 #define PGC_static     0
 #endif
+/* Page is cache colored */
+#define _PGC_colored      PG_shift(4)
+#define PGC_colored       PG_mask(1, 4)
 /* ... */
 /* Page is broken? */
 #define _PGC_broken       PG_shift(7)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 8449f97fe7..9ac7dc6216 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -661,7 +661,12 @@ static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry)
 
     ASSERT(!p2m_is_valid(*entry));
 
-    page = alloc_domheap_page(NULL, 0);
+    /* If cache coloring is enabled, p2m tables are allocated using the domain
+     * coloring configuration to prevent cache interference. */
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        page = alloc_domheap_page(p2m->domain, MEMF_no_refcount);
+    else
+        page = alloc_domheap_page(NULL, 0);
     if ( page == NULL )
         return -ENOMEM;
 
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 62afb07bc6..fe214cd6ac 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -150,6 +150,9 @@
 #define p2m_pod_offline_or_broken_hit(pg) 0
 #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL)
 #endif
+#ifdef CONFIG_HAS_CACHE_COLORING
+#include <asm/coloring.h>
+#endif
 
 #ifndef PGC_static
 #define PGC_static 0
@@ -231,6 +234,14 @@ static bool __read_mostly scrub_debug;
 #define scrub_debug    false
 #endif
 
+/* Memory required for buddy allocator to work with colored one */
+#ifdef CONFIG_BUDDY_ALLOCATOR_SIZE
+static unsigned long __initdata buddy_alloc_size =
+    CONFIG_BUDDY_ALLOCATOR_SIZE << 20;
+#else
+    static unsigned long __initdata buddy_alloc_size = 0;
+#endif
+
 /*
  * Bit width of the DMA heap -- used to override NUMA-node-first.
  * allocation strategy, which can otherwise exhaust low memory.
@@ -440,7 +451,180 @@ mfn_t __init alloc_boot_pages(unsigned long nr_pfns, unsigned long pfn_align)
     BUG();
 }
 
+static DEFINE_SPINLOCK(heap_lock);
 
+/* Initialise fields which have other uses for free pages. */
+static void init_free_page_fields(struct page_info *pg)
+{
+    pg->u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
+    page_set_owner(pg, NULL);
+}
+
+#ifdef CONFIG_CACHE_COLORING
+/*************************
+ * COLORED SIDE-ALLOCATOR
+ *
+ * Pages are stored by their color in separate lists. Each list defines a color
+ * and it is initialized during end_boot_allocator, where each page's color
+ * is calculated and the page itself is put in the correct list.
+ * After initialization there will be N lists where N is the number of
+ * available colors on the platform.
+ * The {free|alloc}_color_heap_page overwrite pg->count_info, but they do it in
+ * the same way as the buddy allocator corresponding functions do:
+ * protecting the access with a critical section using heap_lock.
+ */
+typedef struct page_list_head colored_pages_t;
+static colored_pages_t *__ro_after_init _color_heap;
+static unsigned long *__ro_after_init free_colored_pages;
+
+#define color_heap(color) (&_color_heap[color])
+
+static void free_color_heap_page(struct page_info *pg)
+{
+    struct page_info *pos;
+    unsigned int color = page_to_color(pg);
+    colored_pages_t *head = color_heap(color);
+
+    spin_lock(&heap_lock);
+
+    pg->count_info = PGC_state_free | PGC_colored;
+    page_set_owner(pg, NULL);
+    free_colored_pages[color]++;
+
+    page_list_for_each( pos, head )
+    {
+        if ( page_to_maddr(pos) < page_to_maddr(pg) )
+            break;
+    }
+
+    page_list_add_next(pg, pos, head);
+
+    spin_unlock(&heap_lock);
+}
+
+static struct page_info *alloc_color_heap_page(unsigned int memflags,
+                                               const unsigned int *colors,
+                                               unsigned int num_colors)
+{
+    struct page_info *pg = NULL;
+    unsigned int i, color;
+    bool need_tlbflush = false;
+    uint32_t tlbflush_timestamp = 0;
+
+    spin_lock(&heap_lock);
+
+    for ( i = 0; i < num_colors; i++ )
+    {
+        struct page_info *tmp;
+
+        if ( page_list_empty(color_heap(colors[i])) )
+            continue;
+
+        tmp = page_list_first(color_heap(colors[i]));
+        if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) )
+            pg = tmp;
+    }
+
+    if ( !pg )
+    {
+        spin_unlock(&heap_lock);
+        return NULL;
+    }
+
+    pg->count_info = PGC_state_inuse | PGC_colored;
+
+    if ( !(memflags & MEMF_no_tlbflush) )
+        accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp);
+
+    init_free_page_fields(pg);
+    flush_page_to_ram(mfn_x(page_to_mfn(pg)),
+                      !(memflags & MEMF_no_icache_flush));
+
+    color = page_to_color(pg);
+    free_colored_pages[color]--;
+    page_list_del(pg, color_heap(color));
+
+    spin_unlock(&heap_lock);
+
+    if ( need_tlbflush )
+        filtered_flush_tlb_mask(tlbflush_timestamp);
+
+    return pg;
+}
+
+static void __init init_color_heap_pages(struct page_info *pg,
+                                         unsigned long nr_pages)
+{
+    unsigned int i;
+
+    if ( !_color_heap )
+    {
+        unsigned int max_colors = get_max_colors();
+
+        _color_heap = xmalloc_array(colored_pages_t, max_colors);
+        BUG_ON(!_color_heap);
+        free_colored_pages = xzalloc_array(unsigned long, max_colors);
+        BUG_ON(!free_colored_pages);
+
+        for ( i = 0; i < max_colors; i++ )
+            INIT_PAGE_LIST_HEAD(color_heap(i));
+    }
+
+    printk(XENLOG_DEBUG
+           "Init color heap with %lu pages starting from: %#"PRIx64"\n",
+           nr_pages, page_to_maddr(pg));
+
+    for ( i = 0; i < nr_pages; i++ )
+        free_color_heap_page(&pg[i]);
+}
+
+static struct page_info *alloc_color_domheap_page(struct domain *d,
+                                                  unsigned int memflags)
+{
+    struct page_info *pg;
+
+    pg = alloc_color_heap_page(memflags, d->arch.colors, d->arch.num_colors);
+    if ( !pg )
+        return NULL;
+
+    if ( !(memflags & MEMF_no_owner) )
+    {
+        if ( memflags & MEMF_no_refcount )
+            pg->count_info |= PGC_extra;
+        if ( assign_page(pg, 0, d, memflags) )
+        {
+            free_color_heap_page(pg);
+            return NULL;
+        }
+    }
+
+    return pg;
+}
+
+static void dump_color_heap(void)
+{
+    unsigned int color;
+
+    printk("Dumping coloring heap info\n");
+    for ( color = 0; color < get_max_colors(); color++ )
+        printk("Color heap[%u]: %lu pages\n", color, free_colored_pages[color]);
+}
+
+integer_param("buddy-alloc-size", buddy_alloc_size);
+
+#else /* !CONFIG_CACHE_COLORING */
+
+static void __init init_color_heap_pages(struct page_info *pg,
+                                         unsigned long nr_pages) {}
+static struct page_info *alloc_color_domheap_page(struct domain *d,
+                                                  unsigned int memflags)
+{
+    return NULL;
+}
+static void free_color_heap_page(struct page_info *pg) {}
+static void dump_color_heap(void) {}
+
+#endif /* CONFIG_CACHE_COLORING */
 
 /*************************
  * BINARY BUDDY ALLOCATOR
@@ -462,7 +646,6 @@ static unsigned long node_need_scrub[MAX_NUMNODES];
 static unsigned long *avail[MAX_NUMNODES];
 static long total_avail_pages;
 
-static DEFINE_SPINLOCK(heap_lock);
 static long outstanding_claims; /* total outstanding claims by all domains */
 
 unsigned long domain_adjust_tot_pages(struct domain *d, long pages)
@@ -1027,10 +1210,7 @@ static struct page_info *alloc_heap_pages(
             accumulate_tlbflush(&need_tlbflush, &pg[i],
                                 &tlbflush_timestamp);
 
-        /* Initialise fields which have other uses for free pages. */
-        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
-        page_set_owner(&pg[i], NULL);
-
+        init_free_page_fields(&pg[i]);
     }
 
     spin_unlock(&heap_lock);
@@ -1926,24 +2106,49 @@ static unsigned long avail_heap_pages(
 void __init end_boot_allocator(void)
 {
     unsigned int i;
+    unsigned long buddy_pages;
 
-    /* Pages that are free now go to the domain sub-allocator. */
-    for ( i = 0; i < nr_bootmem_regions; i++ )
+    buddy_pages = PFN_DOWN(buddy_alloc_size);
+
+    if ( !IS_ENABLED(CONFIG_CACHE_COLORING) )
     {
-        struct bootmem_region *r = &bootmem_region_list[i];
-        if ( (r->s < r->e) &&
-             (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) )
+        /* Pages that are free now go to the domain sub-allocator. */
+        for ( i = 0; i < nr_bootmem_regions; i++ )
         {
-            init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
-            r->e = r->s;
-            break;
+            struct bootmem_region *r = &bootmem_region_list[i];
+            if ( (r->s < r->e) &&
+                (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) )
+            {
+                init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
+                r->e = r->s;
+                break;
+            }
         }
     }
+
     for ( i = nr_bootmem_regions; i-- > 0; )
     {
-        struct bootmem_region *r = &bootmem_region_list[i];
+        struct bootmem_region *r;
+
+        if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+            r = &bootmem_region_list[nr_bootmem_regions - i - 1];
+        else
+            r = &bootmem_region_list[i];
+
+        if ( buddy_pages && (r->s < r->e) )
+        {
+            unsigned long pages = MIN(r->e - r->s, buddy_pages);
+            init_heap_pages(mfn_to_page(_mfn(r->s)), pages);
+            r->s += pages;
+            buddy_pages -= pages;
+        }
         if ( r->s < r->e )
-            init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
+        {
+            if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+                init_color_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
+            else
+                init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
+        }
     }
     nr_bootmem_regions = 0;
 
@@ -2344,7 +2549,8 @@ int assign_pages(
 
         for ( i = 0; i < nr; i++ )
         {
-            ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_static)));
+            ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_static |
+                                          PGC_colored)));
             if ( pg[i].count_info & PGC_extra )
                 extra_pages++;
         }
@@ -2429,6 +2635,15 @@ struct page_info *alloc_domheap_pages(
 
     ASSERT_ALLOC_CONTEXT();
 
+    /* Only domains are supported for coloring */
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) && d )
+    {
+        /* Colored allocation must be done on 0 order */
+        if ( order )
+            return NULL;
+        return alloc_color_domheap_page(d, memflags);
+    }
+
     bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
                                       bits ? : (BITS_PER_LONG+PAGE_SHIFT));
 
@@ -2546,7 +2761,10 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
             scrub = 1;
         }
 
-        free_heap_pages(pg, order, scrub);
+        if ( pg->count_info & PGC_colored )
+            free_color_heap_page(pg);
+        else
+            free_heap_pages(pg, order, scrub);
     }
 
     if ( drop_dom_ref )
@@ -2653,6 +2871,9 @@ static void cf_check dump_heap(unsigned char key)
             continue;
         printk("Node %d has %lu unscrubbed pages\n", i, node_need_scrub[i]);
     }
+
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        dump_color_heap();
 }
 
 static __init int cf_check register_heap_trigger(void)
@@ -2785,9 +3006,7 @@ static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
          * to PGC_state_inuse.
          */
         pg[i].count_info = PGC_static | PGC_state_inuse;
-        /* Initialise fields which have other uses for free pages. */
-        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
-        page_set_owner(&pg[i], NULL);
+        init_free_page_fields(&pg[i]);
     }
 
     spin_unlock(&heap_lock);
diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
index a925028ab3..0d48502e75 100644
--- a/xen/include/xen/mm.h
+++ b/xen/include/xen/mm.h
@@ -297,6 +297,37 @@ page_list_add_tail(struct page_info *page, struct page_list_head *head)
     }
     head->tail = page;
 }
+static inline void
+_page_list_add(struct page_info *new, struct page_info *prev,
+               struct page_info *next)
+{
+    new->list.prev = page_to_pdx(prev);
+	new->list.next = page_to_pdx(next);
+	prev->list.next = page_to_pdx(new);
+	next->list.prev = page_to_pdx(new);
+}
+static inline void
+page_list_add_next(struct page_info *new, struct page_info *prev,
+                   struct page_list_head *head)
+{
+	struct page_info *next = page_list_next(prev, head);
+
+    if ( !next )
+        page_list_add_tail(new, head);
+    else
+        _page_list_add(new, prev, next);
+}
+static inline void
+page_list_add_prev(struct page_info *new, struct page_info *next,
+                   struct page_list_head *head)
+{
+	struct page_info *prev = page_list_prev(next, head);
+
+    if ( !prev )
+        page_list_add(new, head);
+    else
+        _page_list_add(new, prev, next);
+}
 static inline bool_t
 __page_list_del_head(struct page_info *page, struct page_list_head *head,
                      struct page_info *next, struct page_info *prev)
@@ -449,6 +480,18 @@ page_list_add_tail(struct page_info *page, struct page_list_head *head)
     list_add_tail(&page->list, head);
 }
 static inline void
+page_list_add_next(struct page_info *new, struct page_info *prev,
+                   struct page_list_head *head)
+{
+	page_list_add_tail(new, &prev->list);
+}
+static inline void
+page_list_add_prev(struct page_info *new, struct page_info *next,
+                   struct page_list_head *head)
+{
+    page_list_add(new, &next->list);
+}
+static inline void
 page_list_del(struct page_info *page, struct page_list_head *head)
 {
     list_del(&page->list);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428413.678549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmu-00044W-2N; Sat, 22 Oct 2022 15:51:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428413.678549; Sat, 22 Oct 2022 15:51:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmt-000446-Te; Sat, 22 Oct 2022 15:51:51 +0000
Received: by outflank-mailman (input) for mailman id 428413;
 Sat, 22 Oct 2022 15:51:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmr-000237-Vd
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:50 +0000
Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com
 [2a00:1450:4864:20::531])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fdc77bb-5221-11ed-8fd0-01056ac49cbb;
 Sat, 22 Oct 2022 17:51:48 +0200 (CEST)
Received: by mail-ed1-x531.google.com with SMTP id r14so16373436edc.7
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:48 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fdc77bb-5221-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=9CIJ7divhUZIF+Qnvd1Yc7OiBLngKxwy0fDcbHW1K4I=;
        b=bekSxZNXaB5EPog/MFSBYw65rHFpFZbEwHZNfxoGEjS6gxoEIRWu19yT+PZNGELIJ4
         xpF7je+WIHIPIGcV2LP3zO3L7O7e6l8Z7qyfCLNqq74i7X8B0U1+DLGGhzojcqdSisBL
         2ZrlhXCoqovBjr0nnw8bSSnsxjlXnxZU+uNMC6EM8W9qvcWks8mrbX5C0PsjrPBZv9g3
         GnG/OnRWmCeRIwtmQmts6kudaiPb7HEHa6L2CoUfALvPe9+JGGDqv2UyHMfWsdvSaBwp
         f22JwHITKgKLtVvD+fbvABX604gHpTA5KE6bObc+gJ58esYS0gxIP+2gohyHmT3QSfwG
         GDhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=9CIJ7divhUZIF+Qnvd1Yc7OiBLngKxwy0fDcbHW1K4I=;
        b=KlCpTpGT6aOj8/h268cz3dadUW+t7ue+7xlLYVZR5+LFlUTZp7z0eWhpR0MEIbusU6
         4JOPgflE7ttQCs207n3J821f3Nn9zUUXvBfpnijzqFyY1ilUmSEbrMyTqgRNmVvcC2y4
         z7ZkklimPsVG4fXkZj5WUiu69Wi3OtXXTpHCmbsJ6vTX0mAjcvZDUNKYHxuYtat7qMcl
         qb+GBNn9tjXErzmE9nYYvY9HbE/pBUEtP38Vnl3h1f85EVzZ3vNZXEdM2SYPeRMXE9Nh
         r1fGzNrH1wIVafhkjUfFrK1UWhLqfm5iLpAi5n4QTZ7zaDxqPG3ioGytIJJJwz40k7xw
         bZCw==
X-Gm-Message-State: ACrzQf1XgLwa+OeTzY6S6RoV085RyeGhvPl6SvRgEKfreYIoWDAYZP0c
	Icd0iyCgCuIASDlRdAO94IDfUBcInmxz8w==
X-Google-Smtp-Source: AMsMyM50hk0OxRgELBNWkoU6ZbKGwa3xx//p0nYsglz1A0zAss4XsD2nGCLTYRlYITflNQS7oGe5DQ==
X-Received: by 2002:a17:906:ef8c:b0:78d:46b7:6847 with SMTP id ze12-20020a170906ef8c00b0078d46b76847mr20078591ejb.241.1666453907785;
        Sat, 22 Oct 2022 08:51:47 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v3 7/9] Revert "xen/arm: Remove unused BOOT_RELOC_VIRT_START"
Date: Sat, 22 Oct 2022 17:51:18 +0200
Message-Id: <20221022155120.7000-8-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This reverts commit 0c18fb76323bfb13615b6f13c98767face2d8097.

Cache coloring support for Xen needs to relocate Xen code and data in a new
colored physical space. The BOOT_RELOC_VIRT_START will be used as the
virtual base address for a temporary mapping to this new space.

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
v3:
- new revert because the commit reverted was introduced after v2
---
 xen/arch/arm/include/asm/config.h | 4 +++-
 xen/arch/arm/mm.c                 | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
index 0fefed1b8a..ca6f775668 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -77,7 +77,8 @@
  *   2M -   4M   Xen text, data, bss
  *   4M -   6M   Fixmap: special-purpose 4K mapping slots
  *   6M -  10M   Early boot mapping of FDT
- *   10M - 12M   Livepatch vmap (if compiled in)
+ *   10M - 12M   Early relocation address (used when relocating Xen)
+ *               and later for livepatch vmap (if compiled in)
  *
  * ARM32 layout:
  *   0  -  12M   <COMMON>
@@ -113,6 +114,7 @@
 #define BOOT_FDT_VIRT_START    _AT(vaddr_t,0x00600000)
 #define BOOT_FDT_VIRT_SIZE     _AT(vaddr_t, MB(4))
 
+#define BOOT_RELOC_VIRT_START  _AT(vaddr_t,0x00a00000)
 #ifdef CONFIG_LIVEPATCH
 #define LIVEPATCH_VMAP_START   _AT(vaddr_t,0x00a00000)
 #define LIVEPATCH_VMAP_SIZE    _AT(vaddr_t, MB(2))
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 6ccffeaea5..a81b8f9286 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -154,6 +154,7 @@ static void __init __maybe_unused build_assertions(void)
     /* 2MB aligned regions */
     BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK);
     BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK);
+    BUILD_BUG_ON(BOOT_RELOC_VIRT_START & ~SECOND_MASK);
     /* 1GB aligned regions */
 #ifdef CONFIG_ARM_32
     BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK);
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428414.678560 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmv-0004MJ-Do; Sat, 22 Oct 2022 15:51:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428414.678560; Sat, 22 Oct 2022 15:51:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmv-0004Kr-7L; Sat, 22 Oct 2022 15:51:53 +0000
Received: by outflank-mailman (input) for mailman id 428414;
 Sat, 22 Oct 2022 15:51:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmt-0002Ir-5o
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:51 +0000
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com
 [2a00:1450:4864:20::52b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 710265bf-5221-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 17:51:50 +0200 (CEST)
Received: by mail-ed1-x52b.google.com with SMTP id a67so16325495edf.12
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:50 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 710265bf-5221-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=1+bXc+eUGwUw9pKJuzS9R2sHd4FPFFlOJJczFfA/Xfo=;
        b=SVMkJvKI59q+DF9RWoWnNA6MKfFZUQcGyxWuatT+x2LZl5gR2Kg+Qc7ue1fjFSf7nK
         qz/eSC0BnYzjP/3cdfdw9A5D7VmKK/ZkcZ7QJbBDgR4GhNgFVbFhmjCi7vMfZBvWUCNI
         vSs4ICN8sY8Xa0EDQ5xLsHpHnSpXJyyQD9UoXpPQYtrfLEmKdDNwpMyeqX2iMwc2yahK
         wc7qJOixltKVQjM710TXVHLFEGSvJRHZxelQxpLM6Tk6EublMbKQf1jTuO/TNy+4I5/p
         vinPxcmFIegiSpEI1eQEj5NkoiuwLwxe1VfEdwj5XcYDujxaNl0Z/7Cnc8cK4WloaTk6
         +f2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=1+bXc+eUGwUw9pKJuzS9R2sHd4FPFFlOJJczFfA/Xfo=;
        b=vQPojUkQEVzFvPph2mRv1uMYGAliUyVCuvLqBAI38LYLgOR3ayh8391C57Y2KfRHNT
         Os9qPoLpcygiNFErQNrBwbYN8oHcuCn/kO6kUnXhYmGKYdQjKmXs5FwjAhvHAW/3Y+vD
         bCNkbg4jvO3wed1vcwZZcPUn6WP5L5U/zW8sVuVBvdE60JQ7rWAKKAuFkzGSF+xUpgnm
         MHJNPjy6Y8OBsOoaSu7uW5BWsngKEmi/IvyMnEnW43q8WhjoohYyEUDM4GRfJAJjr/wP
         giB0/biL2ZduCJR/xJ0JSf4CCzM+Jm0BT6NWi6oWxcTPupM9j4fPBD5cXOLWW5Who1KZ
         CErQ==
X-Gm-Message-State: ACrzQf3YsuRyibeU3LR1g6qiLFQNuB2gW7b2JiyqaJqgo6272oP3r1QW
	bLDVy/4Qgwc4Rx0pzHmxLxNxQv52aTUKWQ==
X-Google-Smtp-Source: AMsMyM5ezc5fcL/vFULr76ElxNM4qMC5gC1Qkvy2d09jfd8RqYnGhxgcRvLDj/ICdEDQ8rNj6bI16g==
X-Received: by 2002:a17:906:ee89:b0:73d:70c5:1a4e with SMTP id wt9-20020a170906ee8900b0073d70c51a4emr19526601ejb.683.1666453909648;
        Sat, 22 Oct 2022 08:51:49 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	Marco Solieri <marco.solieri@minervasys.tech>,
	Carlo Nonato <carlo.nonato@minervasys.tech>
Subject: [PATCH v3 8/9] xen/arm: add Xen cache colors command line parameter
Date: Sat, 22 Oct 2022 17:51:19 +0200
Message-Id: <20221022155120.7000-9-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Luca Miccio <lucmiccio@gmail.com>

This commit adds a new command line parameter to configure Xen cache
colors. These colors can be dumped with the cache coloring info debug-key.

By default, Xen uses the first color.
Benchmarking the VM interrupt response time provides an estimation of
LLC usage by Xen's most latency-critical runtime task. Results on Arm
Cortex-A53 on Xilinx Zynq UltraScale+ XCZU9EG show that one color, which
reserves 64 KiB of L2, is enough to attain best responsiveness.

More colors are instead very likely to be needed on processors whose L1
cache is physically-indexed and physically-tagged, such as Cortex-A57.
In such cases, coloring applies to L1 also, and there typically are two
distinct L1-colors. Therefore, reserving only one color for Xen would
senselessly partitions a cache memory that is already private, i.e.
underutilize it. The default amount of Xen colors is thus set to one.

Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
---
 docs/misc/arm/cache-coloring.rst  |  8 ++++----
 docs/misc/xen-command-line.pandoc |  9 +++++++++
 xen/arch/arm/coloring.c           | 30 ++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+), 4 deletions(-)

diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
index 0c89278aee..80eb259dfa 100644
--- a/docs/misc/arm/cache-coloring.rst
+++ b/docs/misc/arm/cache-coloring.rst
@@ -19,8 +19,8 @@ In order to enable and use it, few steps are needed.
 - If needed, change the amount of memory reserved for the buddy allocator either
   from the Xen configuration file, via the CONFIG_BUDDY_ALLOCATOR_SIZE value,
   or with the command line option. See `Colored allocator and buddy allocator`.
-- Assign colors to domains using the `Color selection format`_ (see
-  `Coloring parameters`_ for more documentation pointers).
+- Assign colors to each memory pool (Xen, Dom0/DomUs) using the
+  `Color selection format`_ for `Coloring parameters`_ configuration.
 
 Background
 **********
@@ -113,8 +113,8 @@ Examples:
 Coloring parameters
 *******************
 
-LLC way size (as previously discussed) and Dom0 colors can be set using the
-appropriate command line parameters. See the relevant documentation in
+LLC way size (as previously discussed), Xen colors and Dom0 colors can be set
+using the appropriate command line parameters. See the relevant documentation in
 "docs/misc/xen-command-line.pandoc".
 
 DomUs colors can be set either in the xl configuration file (relative
diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 25a59dd6a9..d831cf1196 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2754,6 +2754,15 @@ In the case that x2apic is in use, this option switches between physical and
 clustered mode.  The default, given no hint from the **FADT**, is cluster
 mode.
 
+### xen-colors (arm64)
+> `= List of [ <integer> | <integer>-<integer> ]`
+
+> Default: `0: the lowermost color`
+
+Specify Xen color configuration.
+Two colors are most likely needed on platforms where private caches are
+physically indexed, e.g. the L1 instruction cache of the Arm Cortex-A57.
+
 ### xenheap_megabytes (arm32)
 > `= <size>`
 
diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
index 2cae215cd2..80c76c057f 100644
--- a/xen/arch/arm/coloring.c
+++ b/xen/arch/arm/coloring.c
@@ -32,6 +32,10 @@
 #include <asm/processor.h>
 #include <asm/sysregs.h>
 
+/* By default Xen uses the lowest color */
+#define XEN_DEFAULT_COLOR       0
+#define XEN_DEFAULT_NUM_COLORS  1
+
 /* Size of an LLC way */
 static unsigned int __ro_after_init llc_way_size;
 /* Number of colors available in the LLC */
@@ -43,6 +47,9 @@ static uint64_t __ro_after_init addr_col_mask;
 #define addr_set_color(addr, color) (((addr) & ~addr_col_mask) \
                                      | ((color) << PAGE_SHIFT))
 
+static unsigned int xen_colors[CONFIG_MAX_CACHE_COLORS];
+static unsigned int xen_num_colors;
+
 static unsigned int dom0_colors[CONFIG_MAX_CACHE_COLORS];
 static unsigned int dom0_num_colors;
 
@@ -94,6 +101,12 @@ static int parse_color_config(const char *buf, unsigned int *colors,
 
 size_param("llc-way-size", llc_way_size);
 
+static int __init parse_xen_colors(const char *s)
+{
+    return parse_color_config(s, xen_colors, &xen_num_colors);
+}
+custom_param("xen-colors", parse_xen_colors);
+
 static int __init parse_dom0_colors(const char *s)
 {
     return parse_color_config(s, dom0_colors, &dom0_num_colors);
@@ -188,6 +201,8 @@ static void dump_coloring_info(unsigned char key)
     printk("LLC way size: %u KiB\n", llc_way_size >> 10);
     printk("Number of LLC colors supported: %u\n", max_colors);
     printk("Address color mask: 0x%lx\n", addr_col_mask);
+    printk("Xen colors: ");
+    print_colors(xen_colors, xen_num_colors);
 }
 
 bool __init coloring_init(void)
@@ -225,6 +240,21 @@ bool __init coloring_init(void)
 
     addr_col_mask = (max_colors - 1) << PAGE_SHIFT;
 
+    if ( !xen_num_colors )
+    {
+        printk(XENLOG_WARNING
+               "Xen color config not found. Using default color: %u\n",
+               XEN_DEFAULT_COLOR);
+        xen_colors[0] = XEN_DEFAULT_COLOR;
+        xen_num_colors = XEN_DEFAULT_NUM_COLORS;
+    }
+
+    if ( !check_colors(xen_colors, xen_num_colors) )
+    {
+        printk(XENLOG_ERR "Bad color config for Xen\n");
+        return false;
+    }
+
     if ( !dom0_num_colors )
     {
         printk(XENLOG_WARNING
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 15:51:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 15:51:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428415.678571 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmw-0004fg-UH; Sat, 22 Oct 2022 15:51:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428415.678571; Sat, 22 Oct 2022 15:51:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omGmw-0004en-NP; Sat, 22 Oct 2022 15:51:54 +0000
Received: by outflank-mailman (input) for mailman id 428415;
 Sat, 22 Oct 2022 15:51:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omGmv-0002Ir-HI
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 15:51:53 +0000
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com
 [2a00:1450:4864:20::530])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 721860be-5221-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 17:51:52 +0200 (CEST)
Received: by mail-ed1-x530.google.com with SMTP id m16so16266780edc.4
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 08:51:52 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 z61-20020a509e43000000b00461816beef9sm894623ede.14.2022.10.22.08.51.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 08:51:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 721860be-5221-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=ZFHU6JLoOi1I0YfuDm34fjeeyfPVBZKSuGjuzgCHudY=;
        b=V4QBmMQvl4H72FfQBamm+SgPnsEFHKKbQ9hb1KjqZ75bMEG5AA2dkLikxDHouFocM0
         lH0UxPXCCDyJBvhDN2UbCQsrxbjUHTM3WwcVgvTS/gQCtQ1inVVVckkYiGKEEZTNqyY9
         RCdQwDV70Vx24HPQusiR0pPv5EVDUULAmX+VyVAE3anhkQ3nlPnC9A6t+B4+txHkesvg
         j+F72ItnBlZIcRE0nNdboGDLGhZXdMXT/aEgLZ2KFpFjofwZMjeDJ7/Zoj1jUEskvwmw
         4X9qbSpXI1Brs+9fUM84NU6+VsdDhhnSXBpakC+dLvHRrX6SfxvqYSIPTZQWhlUaa4fW
         LPew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=ZFHU6JLoOi1I0YfuDm34fjeeyfPVBZKSuGjuzgCHudY=;
        b=mlCgoOSCypLp+uqV/8laP6xG1hLgTAhXfB3Oj/bTXYH+J8uezfkUVhpX17MfXsVDlM
         m+8xzPRGVPBByqnXhAGHwo1Zo+eRch0oBGhu/XCcktb69PQIzYF3SPq9uunfjeFsDtdF
         2u/p6ty8XVfLLBkPdshuTDSwlpDxmwceqp0so110RgcA3usf93X+mmmpchpeqyBiBs2f
         uq4qyV7leiVFxgQAEsl4PSiEtIHpiILksWmIbRufB0Mt0Gj5pHI5Vo4lNO5hYuiM4I1E
         2LR7nSOhx5WNVYEOj4Wv7qYRuAnmGaqqTBnbVIRc+3xlBpwRocKjP28ah+AjFWCRRkKZ
         zEow==
X-Gm-Message-State: ACrzQf3dXZm5DdnPP+Bx7xEWjPrmIPtSuyrZanVC8kaEoE9s2QRrHLiX
	KyM0A0qysHRzbS9VdwEJIcWmV6wpurBEYQ==
X-Google-Smtp-Source: AMsMyM7MXEiV5in+yFRYTeR2PvQuRsyLJ2/ximIm+nzAuVzWY1nblZJrbtht2OvIaG2j8sizGnZD4A==
X-Received: by 2002:a17:906:5dce:b0:78d:e71a:6e0 with SMTP id p14-20020a1709065dce00b0078de71a06e0mr20198391ejv.360.1666453911187;
        Sat, 22 Oct 2022 08:51:51 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Marco Solieri <marco.solieri@minervasys.tech>
Subject: [PATCH v3 9/9] xen/arm: add cache coloring support for Xen
Date: Sat, 22 Oct 2022 17:51:20 +0200
Message-Id: <20221022155120.7000-10-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This commit adds the cache coloring support for Xen own physical space.

It extends the implementation of setup_pagetables to make use of Xen cache
coloring configuration. Page tables construction is essentially the same
except for the fact that the physical addresses, in case of cache coloring,
are taken from the translation of a new, temporary, virtual space that is
physically colored.

The temporary mapping is also used to relocate Xen to the new physical
space starting at the address taken from the old get_xen_paddr() function
which is brought back for the occasion.
The temporary mapping is finally converted to a mapping of the "old"
(meaning the original physical space) Xen code, so that the boot CPU can
actually address the variables and functions used by secondary CPUs.
This happens when the boot CPU needs to bring up other CPUs (psci.c and
smpboot.c) and when the TTBR value is passed to them
(init_secondary_pagetables).

Finally, since the alternative framework needs to remap the Xen text and
inittext sections, this operation must be done in a coloring-aware way.
The function xen_remap_colored() is introduced for that.

Based on original work from: Luca Miccio <lucmiccio@gmail.com>

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
---
v3:
- changed next_xen_colored() to xen_colored_mfn() to work with MFNs instead
  of addresses
- new macro for_each_xen_colored_mfn to iterate over Xen colored MFNs
- new function xen_remap_colored() to remap colored Xen instead of
  __vmap_colored()
- use map_pages_to_xen() instead of custom mapping function during
  setup_pagetables() (thanks to Julien)
- reintroduce relocate_xen() to switch to colored space
- removed useless virt_to_maddr_colored()
---
 xen/arch/arm/alternative.c          |  9 ++-
 xen/arch/arm/arm64/head.S           | 48 +++++++++++++++
 xen/arch/arm/coloring.c             | 38 ++++++++++++
 xen/arch/arm/include/asm/coloring.h | 30 +++++++++
 xen/arch/arm/include/asm/mm.h       | 16 ++++-
 xen/arch/arm/mm.c                   | 94 ++++++++++++++++++++++++++---
 xen/arch/arm/psci.c                 |  4 +-
 xen/arch/arm/setup.c                | 74 ++++++++++++++++++++++-
 xen/arch/arm/smpboot.c              |  3 +-
 xen/arch/arm/xen.lds.S              |  2 +-
 10 files changed, 297 insertions(+), 21 deletions(-)

diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
index f03cd943c6..a795aeec98 100644
--- a/xen/arch/arm/alternative.c
+++ b/xen/arch/arm/alternative.c
@@ -28,6 +28,7 @@
 #include <asm/alternative.h>
 #include <asm/atomic.h>
 #include <asm/byteorder.h>
+#include <asm/coloring.h>
 #include <asm/cpufeature.h>
 #include <asm/insn.h>
 #include <asm/page.h>
@@ -220,8 +221,12 @@ void __init apply_alternatives_all(void)
      * The text and inittext section are read-only. So re-map Xen to
      * be able to patch the code.
      */
-    xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
-                    VMAP_DEFAULT);
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        xenmap = xen_remap_colored(xen_mfn, xen_size);
+    else
+        xenmap = __vmap(&xen_mfn, 1U << xen_order, 1, 1, PAGE_HYPERVISOR,
+                        VMAP_DEFAULT);
+
     /* Re-mapping Xen is not expected to fail during boot. */
     BUG_ON(!xenmap);
 
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index ad014716db..71cffb54fe 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -813,6 +813,54 @@ ENDPROC(fail)
 
 GLOBAL(_end_boot)
 
+/* Copy Xen to new location and switch TTBR
+ * x0    ttbr
+ * x1    source address
+ * x2    destination address
+ * x3    length
+ *
+ * Source and destination must be word aligned, length is rounded up
+ * to a 16 byte boundary.
+ *
+ * MUST BE VERY CAREFUL when saving things to RAM over the copy */
+ENTRY(relocate_xen)
+        /* Copy 16 bytes at a time using:
+         *   x9: counter
+         *   x10: data
+         *   x11: data
+         *   x12: source
+         *   x13: destination
+         */
+        mov     x9, x3
+        mov     x12, x1
+        mov     x13, x2
+
+1:      ldp     x10, x11, [x12], #16
+        stp     x10, x11, [x13], #16
+
+        subs    x9, x9, #16
+        bgt     1b
+
+        /* Flush destination from dcache using:
+         * x9: counter
+         * x10: step
+         * x11: vaddr
+         */
+        dsb   sy        /* So the CPU issues all writes to the range */
+
+        mov   x9, x3
+        ldr   x10, =dcache_line_bytes /* x10 := step */
+        ldr   x10, [x10]
+        mov   x11, x2
+
+1:      dc    cvac, x11
+
+        add   x11, x11, x10
+        subs  x9, x9, x10
+        bgt   1b
+
+        b switch_ttbr
+
 /*
  * Switch TTBR
  *
diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
index 80c76c057f..857a798d8a 100644
--- a/xen/arch/arm/coloring.c
+++ b/xen/arch/arm/coloring.c
@@ -27,6 +27,7 @@
 #include <xen/keyhandler.h>
 #include <xen/param.h>
 #include <xen/types.h>
+#include <xen/vmap.h>
 
 #include <asm/coloring.h>
 #include <asm/processor.h>
@@ -362,6 +363,43 @@ unsigned int get_max_colors(void)
     return max_colors;
 }
 
+mfn_t xen_colored_mfn(mfn_t mfn)
+{
+    paddr_t maddr = mfn_to_maddr(mfn);
+    unsigned int i, color = addr_to_color(maddr);
+
+    for( i = 0; i < xen_num_colors; i++ )
+    {
+        if ( color == xen_colors[i] )
+            return mfn;
+        else if ( color < xen_colors[i] )
+            return maddr_to_mfn(addr_set_color(maddr, xen_colors[i]));
+    }
+
+    /* Jump to next color space (llc_way_size bytes) and use the first color */
+    return maddr_to_mfn(addr_set_color(maddr + llc_way_size, xen_colors[0]));
+}
+
+void *xen_remap_colored(mfn_t xen_mfn, paddr_t xen_size)
+{
+    unsigned int i;
+    void *xenmap;
+    mfn_t *xen_colored_mfns = xmalloc_array(mfn_t, xen_size >> PAGE_SHIFT);
+
+    if ( !xen_colored_mfns )
+        panic("Can't allocate colored MFNs\n");
+
+    for_each_xen_colored_mfn( xen_mfn, i )
+    {
+        xen_colored_mfns[i] = xen_mfn;
+    }
+
+    xenmap = vmap(xen_colored_mfns, xen_size >> PAGE_SHIFT);
+    xfree(xen_colored_mfns);
+
+    return xenmap;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
index 0147f95968..6e9c1212f5 100644
--- a/xen/arch/arm/include/asm/coloring.h
+++ b/xen/arch/arm/include/asm/coloring.h
@@ -27,10 +27,31 @@
 #ifdef CONFIG_CACHE_COLORING
 
 #include <xen/init.h>
+#include <xen/lib.h>
 #include <xen/sched.h>
 
 #include <public/arch-arm.h>
 
+/*
+ * Amount of memory that we need to map in order to color Xen. The value
+ * depends on the maximum number of available colors of the hardware. The
+ * memory size is pessimistically calculated assuming only one color is used,
+ * which means that any pages belonging to any other color has to be skipped.
+ */
+#define XEN_COLOR_MAP_SIZE \
+    ROUNDUP((_end - _start) * get_max_colors(), XEN_PADDR_ALIGN)
+
+/**
+ * Iterate over each Xen mfn in the colored space.
+ * @mfn:    the current mfn. The first non colored mfn must be provided as the
+ *          starting point.
+ * @i:      loop index.
+ */
+#define for_each_xen_colored_mfn(mfn, i)        \
+    for ( i = 0, mfn = xen_colored_mfn(mfn);    \
+          i < (_end - _start) >> PAGE_SHIFT;    \
+          i++, mfn = xen_colored_mfn(mfn_add(mfn, 1)) )
+
 struct page_info;
 
 bool __init coloring_init(void);
@@ -47,8 +68,13 @@ unsigned int page_to_color(const struct page_info *pg);
 
 unsigned int get_max_colors(void);
 
+mfn_t xen_colored_mfn(mfn_t mfn);
+void *xen_remap_colored(mfn_t xen_fn, paddr_t xen_size);
+
 #else /* !CONFIG_CACHE_COLORING */
 
+#define XEN_COLOR_MAP_SIZE (_end - _start)
+
 static inline bool __init coloring_init(void) { return true; }
 static inline int domain_coloring_init(
     struct domain *d, const struct xen_arch_domainconfig *config) { return 0; }
@@ -56,6 +82,10 @@ static inline void domain_coloring_free(struct domain *d) {}
 static inline void domain_dump_coloring_info(struct domain *d) {}
 static inline void prepare_color_domain_config(
     struct xen_arch_domainconfig *config, const char *colors_str) {}
+static inline void *xen_remap_colored(mfn_t xen_fn, paddr_t xen_size)
+{
+    return NULL;
+}
 
 #endif /* CONFIG_CACHE_COLORING */
 #endif /* __ASM_ARM_COLORING_H__ */
diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
index e848fa4adf..f3f76a20b3 100644
--- a/xen/arch/arm/include/asm/mm.h
+++ b/xen/arch/arm/include/asm/mm.h
@@ -195,12 +195,26 @@ extern unsigned long total_pages;
 
 #define PDX_GROUP_SHIFT SECOND_SHIFT
 
+#ifdef CONFIG_CACHE_COLORING
+#define virt_to_boot_virt(virt) (virt - XEN_VIRT_START + BOOT_RELOC_VIRT_START)
+#define set_value_for_secondary(var, val)                       \
+    *(typeof(var) *)(virt_to_boot_virt((vaddr_t)&var)) = val;   \
+    clean_dcache(var);
+#else
+#define virt_to_boot_virt(virt) (virt)
+#define set_value_for_secondary(var, val)   \
+    var = val;                              \
+    clean_dcache(var);
+#endif
+
 /* Boot-time pagetable setup */
-extern void setup_pagetables(unsigned long boot_phys_offset);
+extern void setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr);
 /* Map FDT in boot pagetable */
 extern void *early_fdt_map(paddr_t fdt_paddr);
 /* Remove early mappings */
 extern void remove_early_mappings(void);
+/* Remove early coloring mappings */
+extern void remove_coloring_mappings(void);
 /* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the
  * new page table */
 extern int init_secondary_pagetables(int cpu);
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index a81b8f9286..4721fd4a04 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -33,6 +33,7 @@
 
 #include <xsm/xsm.h>
 
+#include <asm/coloring.h>
 #include <asm/fixmap.h>
 #include <asm/setup.h>
 
@@ -105,6 +106,9 @@ DEFINE_BOOT_PAGE_TABLE(boot_third);
 static DEFINE_PAGE_TABLE(xen_pgtable);
 static DEFINE_PAGE_TABLE(xen_first);
 #define THIS_CPU_PGTABLE xen_pgtable
+#ifdef CONFIG_CACHE_COLORING
+static DEFINE_PAGE_TABLE(xen_colored_temp);
+#endif
 #else
 #define HYP_PT_ROOT_LEVEL 1
 /* Per-CPU pagetable pages */
@@ -364,7 +368,11 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache)
 
 static inline lpae_t pte_of_xenaddr(vaddr_t va)
 {
+#ifdef CONFIG_CACHE_COLORING
+    paddr_t ma = virt_to_maddr(virt_to_boot_virt(va));
+#else
     paddr_t ma = va + phys_offset;
+#endif
 
     return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL);
 }
@@ -450,6 +458,7 @@ static void xen_pt_enforce_wnx(void)
     flush_xen_tlb_local();
 }
 
+extern void relocate_xen(uint64_t ttbr, void *src, void *dst, size_t len);
 extern void switch_ttbr(uint64_t ttbr);
 
 /* Clear a translation table and clean & invalidate the cache */
@@ -459,9 +468,54 @@ static void clear_table(void *table)
     clean_and_invalidate_dcache_va_range(table, PAGE_SIZE);
 }
 
-/* Boot-time pagetable setup.
- * Changes here may need matching changes in head.S */
-void __init setup_pagetables(unsigned long boot_phys_offset)
+#ifdef CONFIG_CACHE_COLORING
+static void __init create_coloring_temp_mappings(paddr_t xen_paddr)
+{
+    lpae_t pte;
+    unsigned int i;
+    mfn_t mfn = maddr_to_mfn(xen_paddr);
+
+    for_each_xen_colored_mfn( mfn, i )
+    {
+        pte = mfn_to_xen_entry(mfn, MT_NORMAL);
+        pte.pt.table = 1; /* level 3 mappings always have this bit set */
+        xen_colored_temp[i] = pte;
+    }
+
+    pte = mfn_to_xen_entry(virt_to_mfn(xen_colored_temp), MT_NORMAL);
+    pte.pt.table = 1;
+    write_pte(&boot_second[second_table_offset(BOOT_RELOC_VIRT_START)], pte);
+}
+
+void __init remove_coloring_mappings(void)
+{
+    int rc;
+
+    /* destroy the _PAGE_BLOCK mapping */
+    rc = modify_xen_mappings(BOOT_RELOC_VIRT_START,
+                             BOOT_RELOC_VIRT_START + SZ_2M,
+                             _PAGE_BLOCK);
+    BUG_ON(rc);
+}
+#else
+static void __init create_coloring_temp_mappings(paddr_t xen_paddr) {}
+void __init remove_coloring_mappings(void) {}
+#endif /* CONFIG_CACHE_COLORING */
+
+/*
+ * Boot-time pagetable setup with coloring support
+ * Changes here may need matching changes in head.S
+ *
+ * The coloring support consists of:
+ * - Create a temporary colored mapping that conforms to Xen color selection.
+ * - pte_of_xenaddr takes care of translating the virtual addresses to the
+ *   new colored physical space and the returns the pte, so that the page table
+ *   initialization can remain the same.
+ * - Copy Xen to the new colored physical space by exploiting the temporary
+ *   mapping.
+ * - Update TTBR0_EL2 with the new root page table address.
+ */
+void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
 {
     uint64_t ttbr;
     lpae_t pte, *p;
@@ -469,6 +523,9 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
 
     phys_offset = boot_phys_offset;
 
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        create_coloring_temp_mappings(xen_paddr);
+
 #ifdef CONFIG_ARM_64
     p = (void *) xen_pgtable;
     p[0] = pte_of_xenaddr((uintptr_t)xen_first);
@@ -515,13 +572,30 @@ void __init setup_pagetables(unsigned long boot_phys_offset)
     pte.pt.table = 1;
     xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte;
 
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+    {
+        ttbr = virt_to_maddr(virt_to_boot_virt((vaddr_t)xen_pgtable));
+        relocate_xen(ttbr, _start, (void *)BOOT_RELOC_VIRT_START,
+                     _end - _start);
+        /*
+        * Keep original Xen memory mapped because secondary CPUs still point to it
+        * and a few variables needs to be accessed by the master CPU in order to
+        * let them boot. This mapping will also replace the one created at the
+        * beginning of setup_pagetables.
+        */
+        map_pages_to_xen(BOOT_RELOC_VIRT_START,
+                         maddr_to_mfn(XEN_VIRT_START + phys_offset),
+                         SZ_2M >> PAGE_SHIFT, PAGE_HYPERVISOR_RW | _PAGE_BLOCK);
+    }
+    else
+    {
 #ifdef CONFIG_ARM_64
-    ttbr = (uintptr_t) xen_pgtable + phys_offset;
+        ttbr = (uintptr_t) xen_pgtable + phys_offset;
 #else
-    ttbr = (uintptr_t) cpu0_pgtable + phys_offset;
+        ttbr = (uintptr_t) cpu0_pgtable + phys_offset;
 #endif
-
-    switch_ttbr(ttbr);
+        switch_ttbr(ttbr);
+    }
 
     xen_pt_enforce_wnx();
 
@@ -552,8 +626,8 @@ int init_secondary_pagetables(int cpu)
 
     /* Set init_ttbr for this CPU coming up. All CPus share a single setof
      * pagetables, but rewrite it each time for consistency with 32 bit. */
-    init_ttbr = (uintptr_t) xen_pgtable + phys_offset;
-    clean_dcache(init_ttbr);
+    set_value_for_secondary(init_ttbr, virt_to_maddr(xen_pgtable));
+
     return 0;
 }
 #else
@@ -1109,7 +1183,7 @@ static int xen_pt_update(unsigned long virt,
      *
      * XXX: Add a check.
      */
-    const mfn_t root = virt_to_mfn(THIS_CPU_PGTABLE);
+    const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2));
 
     /*
      * The hardware was configured to forbid mapping both writeable and
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 0c90c2305c..4782f64c17 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -49,8 +49,8 @@ int call_psci_cpu_on(int cpu)
 {
     struct arm_smccc_res res;
 
-    arm_smccc_smc(psci_cpu_on_nr, cpu_logical_map(cpu), __pa(init_secondary),
-                  &res);
+    arm_smccc_smc(psci_cpu_on_nr, cpu_logical_map(cpu),
+                  __pa(virt_to_boot_virt((vaddr_t)init_secondary)), &res);
 
     return PSCI_RET(res);
 }
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index acc3e4ad72..6ad68b7f7e 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -465,7 +465,7 @@ static void * __init relocate_fdt(paddr_t dtb_paddr, size_t dtb_size)
     return fdt;
 }
 
-#ifdef CONFIG_ARM_32
+#if defined (CONFIG_ARM_32) || (CONFIG_CACHE_COLORING)
 /*
  * Returns the end address of the highest region in the range s..e
  * with required size and alignment that does not conflict with the
@@ -557,7 +557,9 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e,
     }
     return e;
 }
+#endif
 
+#ifdef CONFIG_ARM_32
 /*
  * Find a contiguous region that fits in the static heap region with
  * required size and alignment, and return the end address of the region
@@ -631,6 +633,62 @@ static paddr_t __init next_module(paddr_t s, paddr_t *end)
     return lowest;
 }
 
+#ifdef CONFIG_CACHE_COLORING
+/**
+ * get_xen_paddr - get physical address to relocate Xen to
+ *
+ * Xen is relocated to as near to the top of RAM as possible and
+ * aligned to a XEN_PADDR_ALIGN boundary.
+ */
+static paddr_t __init get_xen_paddr(uint32_t xen_size)
+{
+    struct meminfo *mi = &bootinfo.mem;
+    paddr_t min_size;
+    paddr_t paddr = 0;
+    int i;
+
+    min_size = (xen_size + (XEN_PADDR_ALIGN-1)) & ~(XEN_PADDR_ALIGN-1);
+
+    /* Find the highest bank with enough space. */
+    for ( i = 0; i < mi->nr_banks; i++ )
+    {
+        const struct membank *bank = &mi->bank[i];
+        paddr_t s, e;
+
+        if ( bank->size >= min_size )
+        {
+            e = consider_modules(bank->start, bank->start + bank->size,
+                                 min_size, XEN_PADDR_ALIGN, 0);
+            if ( !e )
+                continue;
+
+#ifdef CONFIG_ARM_32
+            /* Xen must be under 4GB */
+            if ( e > 0x100000000ULL )
+                e = 0x100000000ULL;
+            if ( e < bank->start )
+                continue;
+#endif
+
+            s = e - min_size;
+
+            if ( s > paddr )
+                paddr = s;
+        }
+    }
+
+    if ( !paddr )
+        panic("Not enough memory to relocate Xen\n");
+
+    printk("Placing Xen at 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
+           paddr, paddr + min_size);
+
+    return paddr;
+}
+#else
+static paddr_t __init get_xen_paddr(uint32_t xen_size) { return 0; }
+#endif
+
 static void __init init_pdx(void)
 {
     paddr_t bank_start, bank_size, bank_end;
@@ -1013,8 +1071,6 @@ void __init start_xen(unsigned long boot_phys_offset,
     /* Initialize traps early allow us to get backtrace when an error occurred */
     init_traps();
 
-    setup_pagetables(boot_phys_offset);
-
     smp_clear_cpu_maps();
 
     device_tree_flattened = early_fdt_map(fdt_paddr);
@@ -1040,8 +1096,13 @@ void __init start_xen(unsigned long boot_phys_offset,
     {
         if ( !coloring_init() )
             panic("Xen cache coloring support: setup failed\n");
+        xen_bootmodule->size = XEN_COLOR_MAP_SIZE;
+        xen_bootmodule->start = get_xen_paddr(xen_bootmodule->size);
     }
 
+    setup_pagetables(boot_phys_offset, xen_bootmodule->start);
+    device_tree_flattened = early_fdt_map(fdt_paddr);
+
     setup_mm();
 
     /* Parse the ACPI tables for possible boot-time configuration */
@@ -1156,6 +1217,13 @@ void __init start_xen(unsigned long boot_phys_offset,
 
     setup_virt_paging();
 
+    /*
+     * The removal is done earlier than discard_initial_modules beacuse the
+     * livepatch init uses a virtual address equal to BOOT_RELOC_VIRT_START.
+     * Remove coloring mappings to expose a clear state to the livepatch module.
+     */
+    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
+        remove_coloring_mappings();
     do_initcalls();
 
     /*
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index f7bda3a18b..e7166ad79b 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -470,8 +470,7 @@ int __cpu_up(unsigned int cpu)
     init_data.cpuid = cpu;
 
     /* Open the gate for this CPU */
-    smp_up_cpu = cpu_logical_map(cpu);
-    clean_dcache(smp_up_cpu);
+    set_value_for_secondary(smp_up_cpu, cpu_logical_map(cpu));
 
     rc = arch_cpu_up(cpu);
 
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 92c2984052..333589c344 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -210,7 +210,7 @@ SECTIONS
        . = ALIGN(POINTER_ALIGN);
        __bss_end = .;
   } :text
-  _end = . ;
+  _end = ALIGN(PAGE_SIZE);
 
   /* Section for the device tree blob (if any). */
   .dtb : { *(.dtb) } :text
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 16:09:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 16:09:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428470.678590 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omH3D-0001EY-UP; Sat, 22 Oct 2022 16:08:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428470.678590; Sat, 22 Oct 2022 16:08:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omH3D-0001ER-Ro; Sat, 22 Oct 2022 16:08:43 +0000
Received: by outflank-mailman (input) for mailman id 428470;
 Sat, 22 Oct 2022 16:08:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=U686=2X=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1omH3C-0001EL-RL
 for xen-devel@lists.xenproject.org; Sat, 22 Oct 2022 16:08:42 +0000
Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com
 [2a00:1450:4864:20::531])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb65f452-5223-11ed-91b5-6bf2151ebd3b;
 Sat, 22 Oct 2022 18:08:41 +0200 (CEST)
Received: by mail-ed1-x531.google.com with SMTP id l22so16468479edj.5
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 09:08:40 -0700 (PDT)
Received: from carlo-ubuntu.home (62-11-205-162.dialup.tiscali.it.
 [62.11.205.162]) by smtp.gmail.com with ESMTPSA id
 h4-20020aa7de04000000b004574f4326b8sm15161999edv.30.2022.10.22.09.08.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 22 Oct 2022 09:08:39 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb65f452-5223-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=UjYxLgKE9BIwghdyhvJJrQiwKJ/kxI+aQRPF1P0TnhY=;
        b=nhYLmtH/crhVLLtM4Pf7DB4bdzvWNyWZ8Ci4IuyKDlbpMJfc9oMIaxl9RW149dSVjn
         XjofFhWkGG5PRMjgXlw2XMR53pagdD5hVLwslOIp46bD+aAzNG+Ns/yu3NSpyUgPdTvT
         TO6YMi4iCLYnLGzNGbgvHvjnv1t5OA/Ak3XuoEdlsG2z+66eBRB7JdetSfC9UMRGH4og
         CB7EoVCg3XQJcYKJ9sgmXsViqBfpDxB1m2OsImAcHNZltpB7K17E8IqjkWkK/ig49w/D
         v9XDPkkI2ZJjGTwYJ0ZZLcWt015oRS6PhKOcMQz/1TDBuB6Yq5AodrVP2tPxfaccliGp
         BS5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=UjYxLgKE9BIwghdyhvJJrQiwKJ/kxI+aQRPF1P0TnhY=;
        b=eDgzoHaBvoYC8TAUiGWehtntrEhBsuCjOKT8+eSu9rdQWKGLRxmsMho7yQm+jl6wlz
         6zhogTWSDvFOehWpntrs65HXcPwn9BLyAUWW4U+MQqcWEXfzkvhpwsyDRsN6rxLwhmp4
         a+cWcXDPF5PnXTIA319DepcaShghwnBmcTePmvtbLeK8NKs0oJYSo7Mgqq5fkUTaknUm
         KXLF8KpkoIz6jQ3qhxU4uiFH8Vx+RM2DPF0MXIX15mefuTDI9+RxKrAp/L7odyJ6W2Io
         iLDK4R8wKjF+Ztf1bmggZdMiv+NN6U41emrDP+pB/Th8YQc2qOfKy/VxpQv9LFUqR2K5
         1sag==
X-Gm-Message-State: ACrzQf2SaSyvzZeMr4dsCp//B2vGMPODAtSTmuyguyxHxE75EBv/bVZw
	nVoZZl5D+OV8sRTbVYr1Br8Kk4KUxZZ0EQ==
X-Google-Smtp-Source: AMsMyM5naKmkC/7tH53BW9mSVnYPJloViX/B7M11kkDQfeBfLCS5f/Z0FCN/CQ9/AbVv+gN+V3cTDA==
X-Received: by 2002:aa7:cb87:0:b0:43b:e650:6036 with SMTP id r7-20020aa7cb87000000b0043be6506036mr23070560edt.350.1666454920235;
        Sat, 22 Oct 2022 09:08:40 -0700 (PDT)
From: Carlo Nonato <carlo.nonato@minervasys.tech>
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it,
	andrea.bastoni@minervasys.tech,
	lucmiccio@gmail.com,
	Carlo Nonato <carlo.nonato@minervasys.tech>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [RFC PATCH] xen/common: cache colored buddy allocator for domains
Date: Sat, 22 Oct 2022 18:08:37 +0200
Message-Id: <20221022160837.8497-1-carlo.nonato@minervasys.tech>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This commit replaces the colored allocator for domains with a simple buddy
allocator indexed also by colors, so that it can allocate pages based on
some coloring configuration.

It applies on top of Arm cache coloring (v3) as sent to the mailing list.

This has two benefits:
 - order can now be greater than 0 if the color config contains a
   sufficient number of adjacent colors starting from an order aligned
   one;
 - same benefits of the normal buddy: constant time alloc and free
   (constant with respect to the number of pages, not for the number of
   colors);

But also one "big" cons:
 - given the way Xen queries the allocator, it can only serve larger pages
   first and only when a domain runs out of those, it can go with the smaller
   ones. Let's say that domain 0 has 31 colors out of 32 total (0-30 out of
   0-31). The order-4 pages (0-15) are allocated first and then the order-3
   (16-23, since 0-7 and 8-15 are all already allocated), and then order-2
   and so on. The result is... the domain practically uses only one half of
   the colors that it should.

Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
---
 xen/common/page_alloc.c | 202 ++++++++++++++++++++++++++++------------
 1 file changed, 141 insertions(+), 61 deletions(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index fe214cd6ac..f20de1c891 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -462,67 +462,133 @@ static void init_free_page_fields(struct page_info *pg)
 
 #ifdef CONFIG_CACHE_COLORING
 /*************************
- * COLORED SIDE-ALLOCATOR
+ * COLORED BUDDY ALLOCATOR
  *
- * Pages are stored by their color in separate lists. Each list defines a color
- * and it is initialized during end_boot_allocator, where each page's color
- * is calculated and the page itself is put in the correct list.
- * After initialization there will be N lists where N is the number of
- * available colors on the platform.
- * The {free|alloc}_color_heap_page overwrite pg->count_info, but they do it in
- * the same way as the buddy allocator corresponding functions do:
- * protecting the access with a critical section using heap_lock.
+ * A simplified version of the buddy allocator with the addition of colors to
+ * serve pages based on coloring configuration.
+ * Pages are divided in lists by color and order, so the total space needed
+ * for the heap is greater than the normal one. The matrix of colors x orders
+ * page lists is linearized since not every color can use any order.
  */
 typedef struct page_list_head colored_pages_t;
 static colored_pages_t *__ro_after_init _color_heap;
 static unsigned long *__ro_after_init free_colored_pages;
+static unsigned int max_color_order;
 
-#define color_heap(color) (&_color_heap[color])
+#define order_mask(order) ((1UL << (order)) - 1)
+#define color_index_of_order(color, order) ((color) & order_mask(order))
+#define color_align_to_order(color, order) ((color) & ~order_mask(order))
+#define color_heap_pos(color, order) \
+    ((((1 << max_color_order) + (color)) >> (order)) - 1)
+#define color_heap(color, order) (&_color_heap[color_heap_pos(color, order)])
 
-static void free_color_heap_page(struct page_info *pg)
+static void free_color_heap_pages(struct page_info *pg, unsigned int order)
 {
-    struct page_info *pos;
-    unsigned int color = page_to_color(pg);
-    colored_pages_t *head = color_heap(color);
+    unsigned int i, color = page_to_color(pg);
+
+    ASSERT(color_index_of_order(color, order) == 0);
 
     spin_lock(&heap_lock);
 
-    pg->count_info = PGC_state_free | PGC_colored;
-    page_set_owner(pg, NULL);
-    free_colored_pages[color]++;
+    for ( i = 0; i < (1 << order); i++ )
+    {
+        pg[i].count_info = PGC_state_free | PGC_colored;
+        page_set_owner(&pg[i], NULL);
+        free_colored_pages[page_to_color(&pg[i])]++;
+    }
 
-    page_list_for_each( pos, head )
+    for ( ; order < max_color_order; order++ )
     {
-        if ( page_to_maddr(pos) < page_to_maddr(pg) )
+        unsigned long mask = 1UL << order;
+        struct page_info *merge = pg + ((color & mask) ? -mask : mask);
+
+        if ( !page_state_is(merge, free) || (PFN_ORDER(merge) != order) )
             break;
+
+        if ( color & mask )
+        {
+            pg = merge;
+            color -= mask;
+        }
+
+        page_list_del(merge, color_heap(color, order));
     }
 
-    page_list_add_next(pg, pos, head);
+    PFN_ORDER(pg) = order;
+    page_list_add(pg, color_heap(color, order));
 
     spin_unlock(&heap_lock);
 }
 
-static struct page_info *alloc_color_heap_page(unsigned int memflags,
-                                               const unsigned int *colors,
-                                               unsigned int num_colors)
+static struct page_info *find_free_color_heap_page(unsigned int color,
+                                                   unsigned int order)
+{
+    struct page_info *pg = NULL;
+    unsigned int buddy_order, buddy_color;
+
+    ASSERT(color_index_of_order(color, order) == 0);
+
+    for ( buddy_order = order; buddy_order <= max_color_order; buddy_order++ )
+    {
+        pg = page_list_remove_head(color_heap(
+            color_align_to_order(color, buddy_order), buddy_order));
+        if ( pg )
+            break;
+    }
+
+    if ( !pg )
+        return NULL;
+
+    buddy_color = page_to_color(pg);
+
+    while ( buddy_order != order )
+    {
+        unsigned long mask = (1U << --buddy_order);
+        struct page_info *half = pg + mask;
+
+        if ( color & mask )
+        {
+            page_list_add(pg, color_heap(buddy_color, buddy_order));
+            pg = half;
+            buddy_color += mask;
+        }
+        else
+            page_list_add(half, color_heap(buddy_color + mask, buddy_order));
+    }
+
+    return pg;
+}
+
+static struct page_info *alloc_color_heap_pages(unsigned int order,
+                                                unsigned int memflags,
+                                                unsigned int *colors,
+                                                unsigned int num_colors)
 {
     struct page_info *pg = NULL;
-    unsigned int i, color;
+    unsigned int i, color = 0;
+    unsigned long mask = order_mask(order);
     bool need_tlbflush = false;
     uint32_t tlbflush_timestamp = 0;
+    mfn_t mfn;
 
     spin_lock(&heap_lock);
 
+    /* Search for 2^order contiguous colors */
     for ( i = 0; i < num_colors; i++ )
     {
-        struct page_info *tmp;
+        unsigned int index = colors[i] & mask;
+
+        if ( index == 0 )
+            color = colors[i];
 
-        if ( page_list_empty(color_heap(colors[i])) )
+        if ( colors[i] != color )
             continue;
 
-        tmp = page_list_first(color_heap(colors[i]));
-        if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) )
-            pg = tmp;
+        if ( index == mask &&
+             (pg = find_free_color_heap_page(colors[i] & ~mask, order)) )
+            break;
+
+        color++;
     }
 
     if ( !pg )
@@ -531,59 +597,77 @@ static struct page_info *alloc_color_heap_page(unsigned int memflags,
         return NULL;
     }
 
-    pg->count_info = PGC_state_inuse | PGC_colored;
-
-    if ( !(memflags & MEMF_no_tlbflush) )
-        accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp);
+    for ( i = 0; i < (1 << order); i++ )
+    {
+        pg[i].count_info = PGC_state_inuse | PGC_colored;
 
-    init_free_page_fields(pg);
-    flush_page_to_ram(mfn_x(page_to_mfn(pg)),
-                      !(memflags & MEMF_no_icache_flush));
+        if ( !(memflags & MEMF_no_tlbflush) )
+            accumulate_tlbflush(&need_tlbflush, &pg[i], &tlbflush_timestamp);
 
-    color = page_to_color(pg);
-    free_colored_pages[color]--;
-    page_list_del(pg, color_heap(color));
+        init_free_page_fields(&pg[i]);
+        free_colored_pages[page_to_color(&pg[i])]--;
+    }
 
     spin_unlock(&heap_lock);
 
     if ( need_tlbflush )
         filtered_flush_tlb_mask(tlbflush_timestamp);
 
+    mfn = page_to_mfn(pg);
+    for ( i = 0; i < (1U << order); i++ )
+        flush_page_to_ram(mfn_x(mfn) + i, !(memflags & MEMF_no_icache_flush));
+
     return pg;
 }
 
 static void __init init_color_heap_pages(struct page_info *pg,
                                          unsigned long nr_pages)
 {
-    unsigned int i;
+    unsigned long s, e;
 
     if ( !_color_heap )
     {
         unsigned int max_colors = get_max_colors();
+        unsigned int color_heap_num = (2 * max_colors) - 1;
+        unsigned int i;
 
-        _color_heap = xmalloc_array(colored_pages_t, max_colors);
+        max_color_order = flsl(max_colors) - 1;
+
+        _color_heap = xmalloc_array(colored_pages_t, color_heap_num);
         BUG_ON(!_color_heap);
         free_colored_pages = xzalloc_array(unsigned long, max_colors);
         BUG_ON(!free_colored_pages);
-
-        for ( i = 0; i < max_colors; i++ )
-            INIT_PAGE_LIST_HEAD(color_heap(i));
+        for ( i = 0; i < color_heap_num; i++ )
+            INIT_PAGE_LIST_HEAD(&_color_heap[i]);
     }
 
     printk(XENLOG_DEBUG
            "Init color heap with %lu pages starting from: %#"PRIx64"\n",
            nr_pages, page_to_maddr(pg));
 
-    for ( i = 0; i < nr_pages; i++ )
-        free_color_heap_page(&pg[i]);
+    s = mfn_x(page_to_mfn(pg));
+    e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1));
+
+    while ( s < e )
+    {
+        unsigned int inc_order = min_t(unsigned int, max_color_order,
+                                       flsl(e - s) - 1);
+
+        if ( s )
+            inc_order = min(inc_order, ffsl(s) - 1U);
+        free_color_heap_pages(mfn_to_page(_mfn(s)), inc_order);
+        s += (1UL << inc_order);
+    }
 }
 
-static struct page_info *alloc_color_domheap_page(struct domain *d,
-                                                  unsigned int memflags)
+static struct page_info *alloc_color_domheap_pages(struct domain *d,
+                                                   unsigned int order,
+                                                   unsigned int memflags)
 {
     struct page_info *pg;
 
-    pg = alloc_color_heap_page(memflags, d->arch.colors, d->arch.num_colors);
+    pg = alloc_color_heap_pages(order, memflags, d->arch.colors,
+                                d->arch.num_colors);
     if ( !pg )
         return NULL;
 
@@ -591,9 +675,9 @@ static struct page_info *alloc_color_domheap_page(struct domain *d,
     {
         if ( memflags & MEMF_no_refcount )
             pg->count_info |= PGC_extra;
-        if ( assign_page(pg, 0, d, memflags) )
+        if ( assign_page(pg, order, d, memflags) )
         {
-            free_color_heap_page(pg);
+            free_color_heap_pages(pg, order);
             return NULL;
         }
     }
@@ -616,12 +700,13 @@ integer_param("buddy-alloc-size", buddy_alloc_size);
 
 static void __init init_color_heap_pages(struct page_info *pg,
                                          unsigned long nr_pages) {}
-static struct page_info *alloc_color_domheap_page(struct domain *d,
-                                                  unsigned int memflags)
+static struct page_info *alloc_color_domheap_pages(struct domain *d,
+                                                   unsigned int order,
+                                                   unsigned int memflags)
 {
     return NULL;
 }
-static void free_color_heap_page(struct page_info *pg) {}
+static void free_color_heap_pages(struct page_info *pg, unsigned int order) {}
 static void dump_color_heap(void) {}
 
 #endif /* CONFIG_CACHE_COLORING */
@@ -2637,12 +2722,7 @@ struct page_info *alloc_domheap_pages(
 
     /* Only domains are supported for coloring */
     if ( IS_ENABLED(CONFIG_CACHE_COLORING) && d )
-    {
-        /* Colored allocation must be done on 0 order */
-        if ( order )
-            return NULL;
-        return alloc_color_domheap_page(d, memflags);
-    }
+        return alloc_color_domheap_pages(d, order, memflags);
 
     bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
                                       bits ? : (BITS_PER_LONG+PAGE_SHIFT));
@@ -2762,7 +2842,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
         }
 
         if ( pg->count_info & PGC_colored )
-            free_color_heap_page(pg);
+            free_color_heap_pages(pg, order);
         else
             free_heap_pages(pg, order, scrub);
     }
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sat Oct 22 19:49:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 19:49:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428488.678637 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omKUf-0005wW-RP; Sat, 22 Oct 2022 19:49:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428488.678637; Sat, 22 Oct 2022 19:49:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omKUf-0005wP-Or; Sat, 22 Oct 2022 19:49:17 +0000
Received: by outflank-mailman (input) for mailman id 428488;
 Sat, 22 Oct 2022 19:49:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omKUe-0005wF-2R; Sat, 22 Oct 2022 19:49:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omKUe-0002Et-0W; Sat, 22 Oct 2022 19:49:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omKUd-0004eh-Ho; Sat, 22 Oct 2022 19:49:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omKUd-0006F5-HM; Sat, 22 Oct 2022 19:49:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=j7vTyG/IDMUgwoNo7AR/pdCXdkV16gxgWcks1TD8SCE=; b=M94wrWvN1+Y0s3QDBM8Zrmskvc
	gCxg1qpnm28PWFexYkYDrGu6bN1jjyI37skKj2RLZynDrLAlhgHP5CodnpkX0QkdrbrSGLpQ3IDFF
	/8L+IccfXxDoX+q+GXgMUO1ZDZfiOmOJ5KjJ+jopnF11++XW4+sHn3C08R5+fjNMke9I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174265-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174265: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=6fd754ec0fe96511cc48e3babe1a1b650fb3994f
X-Osstest-Versions-That:
    ovmf=2355f0c09c52d6979f9f471b23816f3081cc946b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 19:49:15 +0000

flight 174265 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174265/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 6fd754ec0fe96511cc48e3babe1a1b650fb3994f
baseline version:
 ovmf                 2355f0c09c52d6979f9f471b23816f3081cc946b

Last test of basis   174250  2022-10-22 09:41:23 Z    0 days
Testing same since   174265  2022-10-22 13:40:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chao Li <lichao@loongson.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   2355f0c09c..6fd754ec0f  6fd754ec0fe96511cc48e3babe1a1b650fb3994f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 20:12:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 20:12:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428495.678649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omKrM-0000u0-Lz; Sat, 22 Oct 2022 20:12:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428495.678649; Sat, 22 Oct 2022 20:12:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omKrM-0000tt-JJ; Sat, 22 Oct 2022 20:12:44 +0000
Received: by outflank-mailman (input) for mailman id 428495;
 Sat, 22 Oct 2022 20:12:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omKrL-0000tj-25; Sat, 22 Oct 2022 20:12:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omKrK-0002jT-UE; Sat, 22 Oct 2022 20:12:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omKrK-0006u6-II; Sat, 22 Oct 2022 20:12:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omKrK-0007fM-EN; Sat, 22 Oct 2022 20:12:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=axbwoRYmv8x2b2qyDjcymLB1sIRd+exK351vQ1EonSM=; b=ZQabmlKg6hRjXIaNH/tvdjEwlN
	SUM+J7lJQuG8e4AA8E85GnMnhDBf2e1ODSgDSYeLZ/tm1Yq4i7zseXq5IlPiAoA4wyTCOzy7DwCGI
	gRwbwkayF7CGp3IhkO5bmv3EMzXuGv+uPdOOOS6tWq6HEjWjNzI9FmZt4bhRYs84UGgU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174226-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174226: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=bd8e963412c8e676fc73ae456f311cdcabe8642d
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 20:12:42 +0000

flight 174226 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174226/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                bd8e963412c8e676fc73ae456f311cdcabe8642d
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   15 days
Failing since        173470  2022-10-08 06:21:34 Z   14 days   23 attempts
Testing same since   174226  2022-10-22 01:13:18 Z    0 days    1 attempts

------------------------------------------------------------
1343 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 125713 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 22 22:14:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 22 Oct 2022 22:14:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428511.678672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omMkc-0004Z9-QX; Sat, 22 Oct 2022 22:13:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428511.678672; Sat, 22 Oct 2022 22:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omMkc-0004Z2-M9; Sat, 22 Oct 2022 22:13:54 +0000
Received: by outflank-mailman (input) for mailman id 428511;
 Sat, 22 Oct 2022 22:13:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omMkb-0004Ys-Qs; Sat, 22 Oct 2022 22:13:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omMkb-0004n5-Kb; Sat, 22 Oct 2022 22:13:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omMkb-00051T-3A; Sat, 22 Oct 2022 22:13:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omMkb-0002lJ-2f; Sat, 22 Oct 2022 22:13:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=N2yjbxfcAdQDc/kX5NPi1dGsJKc3KEhtSWjmnrYO6Xg=; b=Hzw98Zl4fsdhYox9mGSwF2iBkw
	2YVL6fsEbf8WUr4RHIChPW6DNZKESx4EsUjCAgU8TTbt06hyJUmqTzBtkh6ov7UgxzVO0LCGqEEbq
	BFwzX5p6K0iMkWdlxyo4MSIxhxSl5IGh5mR4ltiV44E1huPCYG5OaTpB25qoqhg3E7m8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174216-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174216: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug
    xen-4.13-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 22 Oct 2022 22:13:53 +0000

flight 174216 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174216/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174216
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935
 test-amd64-i386-libvirt-xsm   7 xen-install                fail pass in 174126
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 174152

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 174126 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174126 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174126 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174126 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174126 n/a
 build-armhf                   2 hosts-allocate           starved in 174126 n/a

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   68 days
Failing since        173495  2022-10-11 14:08:01 Z   11 days   12 attempts
Testing same since   173657  2022-10-13 01:09:08 Z    9 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 23 01:27:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 01:27:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428526.678707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omPm4-0005I1-B7; Sun, 23 Oct 2022 01:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428526.678707; Sun, 23 Oct 2022 01:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omPm4-0005Hu-84; Sun, 23 Oct 2022 01:27:36 +0000
Received: by outflank-mailman (input) for mailman id 428526;
 Sun, 23 Oct 2022 01:27:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FW87=2Y=gmail.com=bart.vanassche@srs-se1.protection.inumbo.net>)
 id 1omPm3-0005Ho-Me
 for xen-devel@lists.xenproject.org; Sun, 23 Oct 2022 01:27:35 +0000
Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com
 [209.85.214.178]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ddff8fe1-5271-11ed-91b5-6bf2151ebd3b;
 Sun, 23 Oct 2022 03:27:33 +0200 (CEST)
Received: by mail-pl1-f178.google.com with SMTP id u6so5590683plq.12
 for <xen-devel@lists.xenproject.org>; Sat, 22 Oct 2022 18:27:33 -0700 (PDT)
Received: from [192.168.3.219] ([98.51.102.78])
 by smtp.gmail.com with ESMTPSA id
 ij19-20020a170902ab5300b0017f7628cbddsm17072020plb.30.2022.10.22.18.27.30
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 22 Oct 2022 18:27:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ddff8fe1-5271-11ed-91b5-6bf2151ebd3b
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:content-language:references
         :cc:to:subject:from:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=pxn8/fWqKk5uwYUJmeV2YNZEprvktpSj+qw+5kOjvoM=;
        b=v5F7p1TeJG0xXKZwebXyF2QOv1FQ/eT2ISG6/88HDpp+8nPjG7kb9dMIN5p/nFBqMB
         4b6/6jvylelSsPNJV+X0NpKmDgc0XJIf6lYIfhpb+/fxD8IT2o8iReyAvOirmsMBLPK8
         V+tMARN3Ja0RukSvWybj0st8nbB4WfkFyWPgLwuqWdZ0g2nklawAXdo7PyhRbB7pBCiZ
         gFmL51ckQU++uuzx3vqkDvqufmR01xGNTNWkqszDc59l0sH00igZuv8o0xhyylHasSuS
         WnUPB1onYyOvHXqoyyYIF0HHLFxAOT2p01xXtjcpKQjn7WqjPzvWbqsHJEdLH1nWPBSp
         KXXw==
X-Gm-Message-State: ACrzQf3H2C1LX/FnDluPIbPXFerYp2IsRfJrcvb5OIxsQJmME9KMYGw6
	JG9M9O/zOF9d0EwcSRdpBaQ=
X-Google-Smtp-Source: AMsMyM6MSB9NjdfgmovwHqQUK96cfTfpitw7tk0jtz+QWDu6K7xgPFAtY6xG/ZCfPr6Q6f+esTP33g==
X-Received: by 2002:a17:902:8544:b0:183:baae:cf8d with SMTP id d4-20020a170902854400b00183baaecf8dmr27148429plo.96.1666488451973;
        Sat, 22 Oct 2022 18:27:31 -0700 (PDT)
Message-ID: <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
Date: Sat, 22 Oct 2022 18:27:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
From: Bart Van Assche <bvanassche@acm.org>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
To: Salvatore Bonaccorso <carnil@debian.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>, sathya.prakash@broadcom.com,
 sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
 xen-devel@lists.xenproject.org, adi@kriegisch.at,
 Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
Content-Language: en-US
In-Reply-To: <Y1JkuKTjVYrOWbvm@eldamar.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/21/22 02:22, Salvatore Bonaccorso wrote:
> We got the following report in Debian after an update from 5.10.140 to
> the current 5.10.149. Full quoting below (from
> https://bugs.debian.org/1022126). Does this ring some bell about known
> regressions?

Only three mpt3sas changes are new in v5.10.149 compared to v5.10.140:
$ git log --format=oneline v5.10.140..v5.10.149
2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return value check of dma_get_required_mask()
e7fafef9830c4a01e60f76e3860a9bef0262378d scsi: mpt3sas: Force PCIe scatterlist allocations to be within same 4 GB region
ea10a652ad2ae2cf3eced6f632a5c98f26727057 scsi: mpt3sas: Fix use-after-free warning

Sreekanth and Suganath, can you help with bisecting this issue? For the
full report, see also https://lore.kernel.org/linux-scsi/Y1JkuKTjVYrOWbvm@eldamar.lan/.

Thanks,

Bart.


From xen-devel-bounces@lists.xenproject.org Sun Oct 23 03:33:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 03:33:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428532.678718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omRjw-0001ad-Fx; Sun, 23 Oct 2022 03:33:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428532.678718; Sun, 23 Oct 2022 03:33:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omRjw-0001aW-Bb; Sun, 23 Oct 2022 03:33:32 +0000
Received: by outflank-mailman (input) for mailman id 428532;
 Sun, 23 Oct 2022 03:33:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omRju-0001aM-P8; Sun, 23 Oct 2022 03:33:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omRju-00015K-L0; Sun, 23 Oct 2022 03:33:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omRju-0006LL-2Q; Sun, 23 Oct 2022 03:33:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omRju-0002z8-1g; Sun, 23 Oct 2022 03:33:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D+CrlBOXX8kuXDalH2H/YqUn15goo2IE/VBfgJ6IqcY=; b=tnXkTnY1dSqFcDEVWYx7HxoJQM
	snizHselaK+/wsYzCMFYw5aFE4ehijU4jcBRlK4wJQ9EEXFY0sr12rve2oirO0rOXX/CK2ox4PhIr
	HZtJjIWkJwZLNYTBNn1/7qGD5a4kYKrftbfd9xZKDdC011zgt2zBRlMzBXg+sJirN3to=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174252-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174252: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:build-arm64-pvops:kernel-build:fail:regression
    xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-unstable:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
X-Osstest-Versions-That:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 03:33:30 +0000

flight 174252 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174252/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 174210

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 10 xen-install/src_host       fail pass in 174210
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 174210

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 174210 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174210 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174210 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174210
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174210
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174210
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174210
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174210
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174210
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174210
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174210
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174210
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt   16 saverestore-support-check fail starved in 174210
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 174210
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 174210
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174210 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174210 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174210 n/a
 build-armhf-libvirt           2 hosts-allocate           starved in 174210 n/a

version targeted for testing:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340
baseline version:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340

Last test of basis   174252  2022-10-22 10:34:14 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 23 07:44:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 07:44:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428561.678792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omVex-0001Im-JG; Sun, 23 Oct 2022 07:44:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428561.678792; Sun, 23 Oct 2022 07:44:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omVex-0001If-Fl; Sun, 23 Oct 2022 07:44:39 +0000
Received: by outflank-mailman (input) for mailman id 428561;
 Sun, 23 Oct 2022 07:44:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omVew-0001IV-Gi; Sun, 23 Oct 2022 07:44:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omVew-0005gd-Bd; Sun, 23 Oct 2022 07:44:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omVew-0003hw-3g; Sun, 23 Oct 2022 07:44:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omVew-0004AW-3F; Sun, 23 Oct 2022 07:44:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=KAbm/XyAEiI0PoMiTgVtshPZZLrZkUSYNCOyasqq0kM=; b=tESNEZ/ypYscf7sOV1LFhjFAgD
	xG/n1U8UTORlHcBL8IKZzi55cs+3Bikz2PG79905+O3tk/fVGImivwSydKoGycUGHDWUwlxn3PevO
	eUd/rFeovkOzUYjnizw66J4b766G79lBOmxaPfi8JNjPUkeZtnvzGAYl2hs6lH+n7sR0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174258-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174258: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 07:44:38 +0000

flight 174258 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174258/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174258
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174258
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174258
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174258
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174258
 test-amd64-amd64-xl-qemut-ws16-amd64  8 xen-boot fail in 174202 pass in 174258
 test-amd64-i386-xl-vhd        7 xen-install      fail in 174202 pass in 174258
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174202 pass in 174258
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906
 test-amd64-i386-xl-shadow    22 guest-start/debian.repeat  fail pass in 174202

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   68 days
Failing since        173496  2022-10-11 14:08:01 Z   11 days   12 attempts
Testing same since   173650  2022-10-13 00:06:56 Z   10 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 23 08:16:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 08:16:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428575.678818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omW9z-0005Kl-Km; Sun, 23 Oct 2022 08:16:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428575.678818; Sun, 23 Oct 2022 08:16:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omW9z-0005Ke-Gf; Sun, 23 Oct 2022 08:16:43 +0000
Received: by outflank-mailman (input) for mailman id 428575;
 Sun, 23 Oct 2022 08:16:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omW9y-0005KU-5x; Sun, 23 Oct 2022 08:16:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omW9y-0006lu-0q; Sun, 23 Oct 2022 08:16:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omW9x-0004sa-Ok; Sun, 23 Oct 2022 08:16:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omW9x-0003wo-OE; Sun, 23 Oct 2022 08:16:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=gJw2VNJ8ie2y0bDoyJfRTyAkPKwMmoDI7DzDzjHZ7aI=; b=j9gCFtFbcbkqFMAdvd2FUG99Ih
	jN/CVB1OXahT4KcGPscP6iSMulcjt/eOTLSdYGvNwzSOYGpPIfx5z8z0glkNsM2N+k6gw7U7U/FSz
	oRjaQ1syRsBqyNZ3GdNsr7dQ5cp8FKCpS2ysmavqHL/JP157EpyOAafR1n6zfew0qDsk=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-armhf-armhf-xl-arndale
Message-Id: <E1omW9x-0003wo-OE@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 08:16:41 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-armhf-armhf-xl-arndale
testid guest-start

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174296/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-arndale.guest-start.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-arndale.guest-start --summary-out=tmp/174296.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-armhf-armhf-xl-arndale guest-start
Searching for failure / basis pass:
 174212 fail [host=arndale-lakeside] / 172623 ok.
Failure / basis pass flights: 174212 / 172623
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#444260d45ec2a84e8f8c192b3539a3cd5591d009-c6720db5ddffec747bb0b2830e528511b1a4bfb2 git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad\
 8-62dd49f2172fb7dfe8d4223bfa45aede05155328 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#cea5ed49bb5716698a11312a3f38bc8865cd1e67-1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Loaded 15006 nodes in revision graph
Searching for test results:
 173759 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173882 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173986 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d618fe05bf93a8884619e9362bfc5636da55e347 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174070 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9d6915ca91519271a79bc6190a31f0af89e339b2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174140 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174209 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174217 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174230 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fdb4de628120a8736ee47522d1941e3ad3bdf8a 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174212 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174238 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6a2b20ff97e4256970644a07f74a4c5655bf5072 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174251 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4364d661685d4806b8fb66ff76eaece7ea6a4426 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174262 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 f5959ed715e19cf2844656477dbf74c2f576c9d4
 174274 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 e8882bcfe35520e950ba60acd6e67e65f1ce90a8
 174279 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174282 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 32cb81501c8b858fe9a451650804ec3024a8b364
 174289 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174293 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174294 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174296 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174286 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 172623 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 173493 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173511 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173702 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173603 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Searching for interesting versions
 Result found: flight 172623 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x559a14fa7e78) HASH(0x559a14f592a0) HASH(0x559a14f86d38) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56\
 b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 f5959ed715e19cf2844656477dbf74c2f576c9d4, results HASH(0x559a14fa9b80) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 4364d661685d4806b8fb66ff76eaece7ea6a4426 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x559a14f5\
 ccb0) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6a2b20ff97e4256970644a07f74a4c5655bf5072 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x559a14fa2940) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fdb4de628120a8736ee47522d1941e3ad3bdf8a 10795\
 1211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x559a14f8a148) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 444260d45ec2a84e8f8c192b3539a3cd5591d009 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x559a14f85030) HASH(0x559a14f91088) Result fou\
 nd: flight 173493 (fail), for basis failure (at ancestor ~675)
 Repro found: flight 174209 (pass), for basis pass
 Repro found: flight 174212 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 174279 (pass), for last pass
 Result found: flight 174286 (fail), for first failure
 Repro found: flight 174289 (pass), for last pass
 Repro found: flight 174293 (fail), for first failure
 Repro found: flight 174294 (pass), for last pass
 Repro found: flight 174296 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174296/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 154 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-arndale.guest-start.{dot,ps,png,html,svg}.
----------------------------------------
174296: tolerable ALL FAIL

flight 174296 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/174296/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-armhf-armhf-xl-arndale  14 guest-start             fail baseline untested


jobs:
 test-armhf-armhf-xl-arndale                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Sun Oct 23 08:32:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 08:32:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428584.678832 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omWPO-0007mm-5f; Sun, 23 Oct 2022 08:32:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428584.678832; Sun, 23 Oct 2022 08:32:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omWPO-0007mf-1M; Sun, 23 Oct 2022 08:32:38 +0000
Received: by outflank-mailman (input) for mailman id 428584;
 Sun, 23 Oct 2022 08:32:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omWPM-0007mV-Bs; Sun, 23 Oct 2022 08:32:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omWPM-00071O-9s; Sun, 23 Oct 2022 08:32:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omWPL-0005J2-TN; Sun, 23 Oct 2022 08:32:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omWPL-0007UI-Sx; Sun, 23 Oct 2022 08:32:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6vz+1QCOjh4uiouRci2JxBOAszhLhVcIVt9tXcyAKUY=; b=4hNRqJLV+Zb9yoL3bKa7gSjb39
	SBTAio9hXLyOTqHBccNgCARYgNokBnmzKTQROsWkE2OFQw7r8+dn8wwlaA7J5J2V6ppio77mnOQ5K
	SWQJjtNc/rviy2qkr/girIYC2t5Fpzhn8gyZkDpmmbWX3YnAJ8Gi5u2b+i8XyB2I40N4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174263-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174263: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:build-arm64-libvirt:libvirt-build:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-pair:guests-nbd-mirror/debian:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-intel:guest-saverestore:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 08:32:35 +0000

flight 174263 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174263/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547
 build-arm64-libvirt           6 libvirt-build  fail in 174225 REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174263
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174063 pass in 174263
 test-amd64-i386-xl-xsm        7 xen-install      fail in 174063 pass in 174263
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174063 pass in 174263
 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 174225 pass in 174263
 test-amd64-i386-libvirt-pair 22 guests-nbd-mirror/debian fail in 174225 pass in 174263
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173987
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 174063
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 174063
 test-amd64-amd64-dom0pvh-xl-intel 17 guest-saverestore     fail pass in 174225

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 174225 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 174225 n/a
 test-arm64-arm64-xl-vhd      12 debian-di-install       fail blocked in 172547
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174063 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174063 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174063 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174063 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174063 n/a
 build-armhf                   2 hosts-allocate           starved in 174063 n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   68 days
Failing since        173494  2022-10-11 13:38:08 Z   11 days   14 attempts
Testing same since   173610  2022-10-12 17:10:45 Z   10 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 23 14:29:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 14:29:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428609.678890 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ombyU-0007rg-V1; Sun, 23 Oct 2022 14:29:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428609.678890; Sun, 23 Oct 2022 14:29:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ombyU-0007rZ-SL; Sun, 23 Oct 2022 14:29:14 +0000
Received: by outflank-mailman (input) for mailman id 428609;
 Sun, 23 Oct 2022 14:29:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ombyT-0007rO-4k; Sun, 23 Oct 2022 14:29:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ombyS-0004RT-V0; Sun, 23 Oct 2022 14:29:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ombyS-0000hh-IR; Sun, 23 Oct 2022 14:29:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ombyS-0006hk-Hx; Sun, 23 Oct 2022 14:29:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jxZgyUDYzqWELIHLW7HQZLxvZt8vuVr5q6QzPEu4OzA=; b=nxsEE+odrUj3ZGRpvxH3RO/zA3
	rKgD5O9wBtZaGu7XH1nRR7SZWnaW4/Tus1oUybTEiJAcbKBZa8oIzzQoR/+TIXkrGUnIFB/687pZy
	Ki/xgmPd7gAHemfnBoFHFmaY5Q8RrWDsjUtv2pgaxUz3TEKgXPc2aVM1Br3azjJ8Sknk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174277-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174277: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4da34b7d175dc99b8befebd69e96546c960d526c
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 14:29:12 +0000

flight 174277 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174277/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                4da34b7d175dc99b8befebd69e96546c960d526c
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   15 days
Failing since        173470  2022-10-08 06:21:34 Z   15 days   24 attempts
Testing same since   174277  2022-10-22 20:17:05 Z    0 days    1 attempts

------------------------------------------------------------
1351 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               fail    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 126628 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 23 15:37:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 15:37:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428618.678908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omd1y-0006aX-QO; Sun, 23 Oct 2022 15:36:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428618.678908; Sun, 23 Oct 2022 15:36:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omd1y-0006aQ-NP; Sun, 23 Oct 2022 15:36:54 +0000
Received: by outflank-mailman (input) for mailman id 428618;
 Sun, 23 Oct 2022 15:36:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omd1x-0006aG-HF; Sun, 23 Oct 2022 15:36:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omd1x-0005Wd-Di; Sun, 23 Oct 2022 15:36:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omd1w-0002qI-Ta; Sun, 23 Oct 2022 15:36:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omd1w-0007Pa-T4; Sun, 23 Oct 2022 15:36:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LxGSRR9+6DrapclnvGvc3tkIP2jznr1YnXho/ChZ8Z4=; b=NrKnxDAXiCTcg/Z52zk1iZvbly
	st/o6v2bChWNakYrt/1OU4cx66a+X5e4UcyDuVK6XBirP6hEXl1wAyAOXDcFlWeajglXdoKljda/o
	1xUQVqqAtjgksJ/PcWBXz9IQXZTCwAeSwnJoSwlFcqekPbudJAykmAY4+xHO92Te27pY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174267-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174267: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 15:36:52 +0000

flight 174267 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174267/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 174267
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 174070 pass in 174267
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174070 pass in 174267
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 174070

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   66 days
Testing same since   173493  2022-10-11 13:07:01 Z   12 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 23 22:15:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 23 Oct 2022 22:15:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428664.679006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omjF6-0003Hy-HT; Sun, 23 Oct 2022 22:14:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428664.679006; Sun, 23 Oct 2022 22:14:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omjF6-0003Hr-CN; Sun, 23 Oct 2022 22:14:52 +0000
Received: by outflank-mailman (input) for mailman id 428664;
 Sun, 23 Oct 2022 22:14:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omjF4-0003Hh-EM; Sun, 23 Oct 2022 22:14:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omjF4-0004LC-8q; Sun, 23 Oct 2022 22:14:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omjF3-0005GR-Sq; Sun, 23 Oct 2022 22:14:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omjF3-0005v3-SO; Sun, 23 Oct 2022 22:14:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0t+ptFjOo+LGp1Guf58b657AsZZt4c/Zf1zDt1YAd2Y=; b=PsHpQbFhpXqLO1db5qPvo/ZZOP
	gtka9A5I8sCPz7gTdtcBBkYCtgmJLf2k99N42DdwsN9Q8cUKy2KJmvb0EDe2db8/j75SXws+/VAsE
	zCfLT88ONK/FfNdonMNh59hB4btWc72CS+2zNPstOaRMdp7655fwg0c5zCVRZQMRJkyQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174285-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174285: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:build-arm64-pvops:kernel-build:fail:regression
    xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
X-Osstest-Versions-That:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 23 Oct 2022 22:14:49 +0000

flight 174285 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174285/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64-pvops             6 kernel-build   fail in 174252 REGR. vs. 174285

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 174252 pass in 174285
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 174252 pass in 174285
 test-amd64-i386-xl-qemut-debianhvm-amd64  7 xen-install    fail pass in 174252
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host       fail pass in 174252
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 174252

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-examine      1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl           1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 174252 n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 174252 n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174252
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174252
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174252
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174252
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174252
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174252
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174252
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174252
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174252
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174252
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174252
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174252
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340
baseline version:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340

Last test of basis   174285  2022-10-23 03:39:05 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 04:52:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 04:52:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428702.679107 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ompRf-0007YZ-1M; Mon, 24 Oct 2022 04:52:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428702.679107; Mon, 24 Oct 2022 04:52:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ompRe-0007YR-SO; Mon, 24 Oct 2022 04:52:14 +0000
Received: by outflank-mailman (input) for mailman id 428702;
 Mon, 24 Oct 2022 04:52:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ompRd-0007YH-Qj; Mon, 24 Oct 2022 04:52:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ompRd-0002Lb-NA; Mon, 24 Oct 2022 04:52:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ompRd-0001an-Dx; Mon, 24 Oct 2022 04:52:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ompRd-0005kf-DN; Mon, 24 Oct 2022 04:52:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ScCFQRaHS5XdPtYbvy8mFtsm6xK03ydskNPJRkcRznA=; b=ixRDumGxAAY/2s7stF0NpNFBBg
	oUgoOFVXoFLYRjLO/YnVvYKGqtmaIu90lOEK4zk9pWhIiwlBMkTETUZSqnZCYyZmi+2ZpsJ9BeVBq
	hSzQdt+SDIBpGPgc7JUCCENGw+zkbk3UZRw0WeF6LAL55gdYmOlLC7P23MIStyFIan24=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174300-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174300: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 04:52:13 +0000

flight 174300 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174300/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174300
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174300
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174300
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174300
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174300
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   69 days
Failing since        173496  2022-10-11 14:08:01 Z   12 days   13 attempts
Testing same since   173650  2022-10-13 00:06:56 Z   11 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 06:29:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 06:29:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428722.679154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omqxf-00019G-MD; Mon, 24 Oct 2022 06:29:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428722.679154; Mon, 24 Oct 2022 06:29:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omqxf-000199-JQ; Mon, 24 Oct 2022 06:29:23 +0000
Received: by outflank-mailman (input) for mailman id 428722;
 Mon, 24 Oct 2022 06:29:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omqxf-000193-2a
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 06:29:23 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31af4890-5365-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 08:29:21 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8452.eurprd04.prod.outlook.com (2603:10a6:20b:348::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 06:29:19 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 06:29:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31af4890-5365-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AHnFws4d3EOXbZ5IUIxXiqQIkRh6dA5MtqwfgPryY4K52uVf6hTdqtOCyqeT2tDid2+07Z6rXuIBoOSzeTwFYLtPJ5yxB2LDvnGTmBJoLr2JnIvE+t7lMwKb++Q9GquiE6LLjtjdvk/j9vrEhvfvAQWV5JXofGS1z/Nd59hC1zmvLYaOQNO1i7UavzJh4D8ra7ACLaCymXUyW2dZWBfZTsSl12QsEitxoLuxyaFfeaWOImVyo0WNS7BzRWtsbOp7IlRSZGSOd9lrrrAFB9+1Nf/SI3DMLTgKyhJV7n18bjRzmkbjB6tb8o9uM5fgUYq4ReecvuZjjBvhym3+zFucCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BHGNyKFE2AC+GLgXEhXXxSBj4nMmw4mzOEhWJfF2H1E=;
 b=GV45z3thXmwAoykMpH6xSZCethwPzEi7P6uVjjPF3FRwLrGZFkWY4tUhZ6NwnH0yEzXSqqVQ/KfubpdRVBQVsrW5khZIMZ/h0FeCDDpX1L01y2SbxxWJyR23kMgcJc77FdZ/jfPXLR09PTRnPmBze72TcSc+zW7299PZ7jYIfHCyYYnHW8R4xHinttlrQjdMur/fRm86bkqGXvoSM/1wtRkIXYEQWmuEAfs3UcDakUKrWgoOvg1m2F8G4YdBP3S6lttm/KqwYdVhc6bxuwvM0NpyT0GHCtzCpZRRNdEmWvW7PQXSLMpv4ryBkDR2S2mSWLZKgN5RuUCz0aW/qcNxBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BHGNyKFE2AC+GLgXEhXXxSBj4nMmw4mzOEhWJfF2H1E=;
 b=IgujZ9x7oIQx6Xrx4Bi7Zqb5RJGpiz3u53Pf4Y4PLp9etatdwsQmuoaNEkySZP2eh8zThLy/535UbTztxt2uizJ0kObTfMM5tpURaasiKFIIUOABg9OGOBUStm0lLjoQ3VQyFHLX/AgAvO3DkgEWrFf7P4IwY6fecD3xVY2iDonafivgQz7ioy3p3XrxD8A4H/Fcg+hbNISioac9dt19cingRWBOd+TyqME+Vs430rE8dziEOlb2XPM7gNz5jAD2sI1ZsB647SzyfbsQWTBvcUsRVmQ3Zthq6p30PNSeQ4NYEmBa55QP1FDVfwgI/ZfF7C9D5hRge00EWoHhqaCHRQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a5c6ba1b-88c1-fc0f-9d9d-2610f0fe2de2@suse.com>
Date: Mon, 24 Oct 2022 08:29:19 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Doug Goldstein <cardoe@cardoe.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Henry Wang
 <Henry.Wang@arm.com>, Michal Orzel <michal.orzel@amd.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221021165341.7905-1-michal.orzel@amd.com>
 <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0091.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a9::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8452:EE_
X-MS-Office365-Filtering-Correlation-Id: f87d3a62-d328-4f16-a33d-08dab5891491
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jhM7Wk9kqftdY1EDciq++gsX3cYikR5dWA0dUY6Smc21fs8yfhNEKhbYJgCB6gjlt1vmZvqbc0oR4RpPsgzaTzxnl74yM7flQ8pzjOA+VidSE+DM21eSMVtfAoqIX9CMGSygpycuaZ+HsqYcPN4zC5dLcINisSUfIJ5S+muBXzRI43sbTP2A1mDxoS+WLQ/QG/9ErBTD+paFujhZtaXpuO+LX8eTc6FuRH0ACaoFYY6b6rOGHY5xqY/xySYLL1fDSqleG11O4ANyffADfz2pxoY7U3POmPWE4YaHYgxNTG6E481/KfvG81C3VzmF2P9UqthZdn5SNgMwTC6roiy7IlqY5tepElCjFpre4xnUVdy4k3JYqbHi0EG1bAuGqN1lmfajMeBOILDjdW7d199GFKo4FUD3Bq5w6HlF/rGLkhb8N5Vg28k+qVVUTXxiYbzkZhBRf4GwEsdtnFGGNGld0sY2qoUPIEL1xsLjOFEGIAH8amnBKDe/oRhJeRnljKI19UBrAO80sGCxlK1izG/EJ/ssAegCKdW1JqiWZZrVZTqNQ3hKcSRuQx1xnSmEwlAkcwDII6G9KiQENSj1KZbKO5UkGLCLU6VeAIY3sn81oPraaKdZ/maHcmjYk7GmDFFryf5c+yLLks/1Qx+2XpYSaJ0AW7eRYNmJY9ugz4bz/MlMS7vb5v3SiMDadf4nC4/RwXzNKDWLboJlx2ZB6k7IH41LY5OwP4AnD0E/nmTF26mEfdEk2LNd6xFQMQKO8j27fIHBTHgG25WMD44hk9MYl+BZuZKiurf1SA2/7sLNiMw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(53546011)(66946007)(6506007)(8676002)(66476007)(4326008)(83380400001)(66556008)(2906002)(2616005)(36756003)(41300700001)(26005)(6512007)(5660300002)(478600001)(186003)(31696002)(8936002)(86362001)(38100700002)(31686004)(6486002)(316002)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bE5Ua2hUMS8wbmxnL0xPZ0QycXgwL1p3ODlRa0J0YzVFdkwzNVEwUkhyYVNZ?=
 =?utf-8?B?WlUxaENVYUQ2dXNBLzBRaUYxSUZhYTBUdXhKcytCTDNFWFNsS0N1bnlZTHdu?=
 =?utf-8?B?b25iYVg4U0lsVGtPV3pMeEY1dTkvMUJkVmhYeEZRaUZ1Q1hUZkdBWmhOaEMz?=
 =?utf-8?B?ekNQekVZek00SmJlaEVWaEh1OEdxUFh5S2xmeTNPQlVteTdubjdSVGJCcEFP?=
 =?utf-8?B?Vm5GUFAxUzBxbW9ZbUo0M0VrZU4zMDBxNVNFS1hOcWQwc2ZZenRkTHNYUXpm?=
 =?utf-8?B?ME1JWUN1VkNyZ3lFcmp1UWMralVzUG5lK1FxYyt2SkRZb1FWWXY1QndpYWhy?=
 =?utf-8?B?b0JFS2pMY0U4ekhNMjNLSzRzWE5VcWxxWnZna2dHcUNOTGNOREY3N0ZoY1h6?=
 =?utf-8?B?dmZGWFU1bGlkYk9XUVkzUmJIemNlRXNkUXZaV2VqMlJuZ0lrS3c2MU8wS1px?=
 =?utf-8?B?NjBVTFRJRDQrWUZVTCtoWGpSWXo5aW1oeitDK0Q2Q04zL20wdnlLMVZMZFJ6?=
 =?utf-8?B?czY2YzBGWnRsQUNMWEVwOEwxOTJkZHFPWXRwQ01mZVpDWnF4SG9OWHkxSmVi?=
 =?utf-8?B?UWRkbUdYaUwyMmNtRklib0JCQldnMjRCR2VsYWo5cjVBcjRqRGhFRjBaOG9p?=
 =?utf-8?B?U1lKSGNFN1gwWS9BUUtyN3RSRXBueThUZDU4Zk9yTmZUa2taOS9rb2lnQXlL?=
 =?utf-8?B?SWtoWTFvQkJqMGtrbUZ0dkM3RWt0ZGRxU282dG1zZEpCL0h2dlMrRC9vWlBE?=
 =?utf-8?B?UE4yQ3l6bS82T1hJUXZMS0o1RThLalkyWFgxODA4dVZyLzdJSzVjWTJwMTZS?=
 =?utf-8?B?Skp4S2o0ZkNtNktUbnF2MFU0WkQvYzdIQTRVSkc0M2NnTUV0bUc3aEpoZ1h3?=
 =?utf-8?B?a1FvTGV4ZHJ4R2ZmT29QYjROeDlIRHEzVWNQUlNLa1RBcXJJeSttMnVEV2di?=
 =?utf-8?B?UU5DK29FWGxqRGFQd0pmZnFGZHhjV3FqbU5ER2E5cTcwTEY2OFB4blNQWjZR?=
 =?utf-8?B?eC90WTFCUnh2dGxaMUJhS2VoblNBL2N2bnowOGNBZStaSkwvMnpNNysxZG1r?=
 =?utf-8?B?T3ZjQ2hMS040ODR4ci9VaVNXaGVORmxyVEMvVDA0RTVoWFA1a2NKUXRDMTNs?=
 =?utf-8?B?ZTJ6TDROeWgyVHMyNWtaQmUvbjhUTGtKOVp1N1pkUDhGOCtyTjd2SXpMZUJM?=
 =?utf-8?B?VkExTWRNWXRjTzNXNEcxY2d5TzJrR1krMTUrVmhBZTVRVW5jQVVuNkVZbE1w?=
 =?utf-8?B?Tlc4cDZ6ejVoTjROazhJSzF6aUVRT0JvVEk5SEVzNU9Yc2tzSWVnbDI1MXIr?=
 =?utf-8?B?VHo0RDNhL3RpVFpiWEdTQUhxalBLd2VjdENWNlU1a3RUSER4MmRWNnhyc0RU?=
 =?utf-8?B?QkhEV1BGNWhGOS9TM3RzYXQ0OUxPQ25TMmRmREl4MjNnVFZZekFJbHBNTHpH?=
 =?utf-8?B?QWtJMXJHdmlhZ09qc2xPdkhtVjh5SCs1enFSYnU1TlUrYVlIUVZ5VWh5WEY0?=
 =?utf-8?B?RFBUck9jUW94QnNTY1NIQW93SDR2VHVZbHQ4VVJLdmZLSUhNcUdTSDI3ZThs?=
 =?utf-8?B?K29PNVYvTTZ0YUN5YyszOGdONWk2ZHBuU0d6WWxSd2lxRlEvekJpb0U2ek9t?=
 =?utf-8?B?a3RpUUFqYkoxTU5TaUpOTVp0Qmgya3p0eEM3dWRDQ3A1SWkwTCtvU2IxRmZ0?=
 =?utf-8?B?WlFYU3BZdlM2cHBhOWoyN0s1S0VwUXFORFRmQ0VLdXAycjF3M1NpMzI1amgr?=
 =?utf-8?B?Mk1FK1phZTNidVJ1b0hIaWkvdjBDYVY2T2NIYXFuY1d6SDh6UVZaQnN3OEdO?=
 =?utf-8?B?bjJFL2c0dEltUmFzWU5FOTEzdW0yMGY0eFIrdHNsYW1haG5Qa0hpWU5aaGxP?=
 =?utf-8?B?cC9CZlg0OVdJalpwVnlUbVJmSjZxanNRMDVjOExVUU1uZ1JkRzQwY3I3RWF1?=
 =?utf-8?B?bGRkYlBRWkJYNytJeng0WGtmY255cmdXck9FVVNMcjVqMlVkaTVvUUJGMXJK?=
 =?utf-8?B?TXhvcURMN2daRlFXOFdrcW8ycTRUeitzUlN3Q01BcHFKWk1kbWJTWWNKRjdH?=
 =?utf-8?B?YUw2aCtCcG0yQ25QQTJFS2F0U0MySTkyV0gwMk5oQmlCNk1uSjBCWG5FT05D?=
 =?utf-8?Q?VUubwN0ue9ET2cRxdmALyxzpI?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f87d3a62-d328-4f16-a33d-08dab5891491
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 06:29:18.8457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KCOZgVpyaJYLxjQRviawi6NFJcq53/y7RblnNRM796Iw2Bw0+2IMaVZRquDxfrfr5TVjYGyK05rBZOTB8nBc5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8452

On 21.10.2022 19:21, Andrew Cooper wrote:
> On 21/10/2022 17:53, Michal Orzel wrote:
>> Null scheduler is not enabled on non-debug Xen builds so the current
>> test can lead to a failure on such jobs. We still want to test that we
>> can assign the cpupool to a domU with a different scheduler than default
>> one (credit2). Switch to credit as it is enabled by default.
>>
>> Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> 
> /sigh - I'm sure I nacked that stupidity to begin with.  apparently not...
> 
> It is totally bogus for CONFIG_DEBUG to influence logical chunks of
> functionality like this.  The CI script is good in its current form.

Assuming you mean defaults of settings, I'm afraid I see nothing bogus
there at all. What's wrong with enabling more functionality by default
in debug builds, for people to easily use/test them? Yet keeping
unsupported stuff off by default in release builds? That said, ...

> RTDS and ARINC should be default n.
> 
> NULL is more tricky.  PV_SHIM is explicitly security supported, and has
> been for years, so the "UNSUPPORTED" is bogus, whatever the default is.
> 
> As NULL is explicitly tested in CI, it's clearly supported, and probably
> ought to be on default.

... the state of the NULL scheduler wrt its use by the shim has been
puzzling me before.

> Please instead fix Kconfig to not be broken.  That will be a far better
> fix overall for people.
> 
> As a more general note, tests which are using non-default pieces of
> logic ought to activate them explicitly.

Imo _this_ is the immediate course of action to take. What the appropriate
settings are in Kconfig may be less straightforward to determine (see also
Stefano's and Julien's replies).

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 06:35:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 06:35:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428729.679171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omr34-0002Zu-Cm; Mon, 24 Oct 2022 06:34:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428729.679171; Mon, 24 Oct 2022 06:34:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omr34-0002Zn-9V; Mon, 24 Oct 2022 06:34:58 +0000
Received: by outflank-mailman (input) for mailman id 428729;
 Mon, 24 Oct 2022 06:34:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omr33-0002Zh-7g
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 06:34:57 +0000
Received: from EUR03-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur03on2058.outbound.protection.outlook.com [40.107.103.58])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f953e4fc-5365-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 08:34:56 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7881.eurprd04.prod.outlook.com (2603:10a6:10:1ea::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 06:34:53 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 06:34:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f953e4fc-5365-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iZo4Ub7RDZBXMWppqGMH+PWjiQcOiv50HuWLRca93e6RREKOTJExIty290tv6TwuhYdYCevPs33FhddIWMRRmjsCvSeAycBUYqpzOGvkDqhBtxXIcL+Xt5m860O+I1rayaFkErS16+IYoGUl1CYaKYeoLlSIGib9DkbrgoaK91tbCqhIvaj9TSYz7qAlaLUe7OCfKXr+erEK4ng03lvLQiFO+G3kD1MyIFV7FhLsxlfxb5fug8LfucfWA2nglaQcYJRrKQ+cvxusShd9FlOTVXeUhdkt3CVybLupj3QiRir1D02Hsf6GNQUybSNX0I3gYGzng7sDyMcJyA08kgEbxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eMFVx3NCTtS9VNeZ7Tqh/Nhwxwj5zHe6sTNS/yqPdew=;
 b=Uo2Wb0vKD4bVBo9rR9EVUDf6SW70kFLPc2EmPJLd7tZdGOfZfv4pGyvvAVt8tx6dToFuTr0u8zBSvB5WnHNOa4JuaY1zf/S0d69oWz+VevT3I3QZeFYjgPk6A7gicuzmj3EeZ3BfxJcHs8e5bN6StC+saH0LfqxBkyU9tMsRRUrZx9myhiNXJXlZIjilO3Vy41MYaZv9ONJtn3VWdkXwu91qTr2soGa3jFwMTguBv1RwJI6KfU+WXGrZzRrX0nNpn9se+zKo4ge6l1riFgFdV467qz7/g0bT9+DXzsfjIUbIvg1GUFzW5HTOAX1AU35iER49RTsF73UfmNDR+qF0Wg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eMFVx3NCTtS9VNeZ7Tqh/Nhwxwj5zHe6sTNS/yqPdew=;
 b=jh8zAXwyIpTsl+dv6VapY62BIM5hDykMJwX3V0pAw4ju87D2oPN/rAaptuM+dEk52LMsACl/NQwegGT47+5k3DFaRLnmfhMPFkYUJbmXdj8XxdkHf4kVT23OXnnSfYuFTZxKetcxoFDCwk7qkbR4R8Q2pd9qIlKXIcLU74cEskJ1AB4TaZOOhTYNXbx4le+UTM5fqO0c7wHc80xM0mZBtbLOBji7Fd4Yetf5SvAX5qnWxcugbnXGBhMuft9Y8YWJpmBpBhRDdsyu0iKocupToIC+4QGfOpwzJIACWtchHneGt49F4W6ucNv8xpFOo8xlE6Q5a+Lip1CwfOtKvOJM4g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <917becba-92fe-7f4e-380c-cfcf182a5b38@suse.com>
Date: Mon, 24 Oct 2022 08:34:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Julien Grall
 <julien@xen.org>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Oleksandr <olekstysh@gmail.com>
References: <20220718211521.664729-1-volodymyr_babchuk@epam.com>
 <20220718211521.664729-5-volodymyr_babchuk@epam.com>
 <b4554a1f-73ab-7a46-591b-ccb5bb34ea1f@suse.com> <87ilntgzpj.fsf@epam.com>
 <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com>
 <e9120354-e72e-2774-c382-45ab0cb76220@gmail.com>
 <AS8PR08MB7991C3933F253BE49BA61B76922D9@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <0F295AC7-1D2C-4F5D-A421-9440CEB2B5FA@arm.com>
 <AS8PR08MB7991E3C3897AF89E969F6412922C9@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <AS8PR08MB7991E3C3897AF89E969F6412922C9@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0064.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7881:EE_
X-MS-Office365-Filtering-Correlation-Id: ae3cebd4-2e7f-49f1-2cf8-08dab589dc2d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tnze5/UNgrnWbIdalgAN5W2RvGf+jBfXuw3tRAoZvd77cStuwRN5YVE99yqjXPdI8hK+nFHIR7o/aj9rioVVy/jv4eA3WgSlYamK+n4SGzgCWzzGly4vjyuujLONS9KnIx5+2tSE6gWzu/CMNVn1ROkS1v09uZyp76OZjXmUoCpS7paskQtnNOtaXfu5VfLnmlqlsCIBWPwR6okSy/Gjlm+5O7iMPtgj4bY+sl67eBhURMbjHouFr7J0muFlT2x9hjiJjBWCntUwTMiP4uI6rt3S0xFIbt6tn3TWK9cmOpu98tkq+5c3PnTU1MVlsGvThsg7w5UKeTzD6SWqsY22uz2PkEpxqQm0Zob6S67gJJpJhR7TXbBsSgYkc0nAWIsUMqEQj1WZC2HsyTb5Spz1/aW9Sh+OXSxC2f7MicA6PrS81S4evh1vn3S2Jo2ENOjrBEV+KKvFH4mvV0L1SbrApSkRybwuxaxvTzsYnfy+o7CF+GYMpYhE1tLkiKn52eSRMD/q7uecp6/tHtmZRx8SsE1/3qIVnRQ3vfGzm/V+7GWm7gbH3aSiINtyDHbmjda7UYVlZHSor0JDvPBdwg8J3p3LEQ1fHDRPeFzXZxtp62PBzmF0jKt6Atc7STAK21wYlxrDwLS90lkWjzw5hG9jwV65lDgYFxk4YlaKVXHKCnh60eN1AO2l8IFf16abS7VhUiR+kFUL1BT4ItlCFfQLTbmTqWqbK18hwt3WPXBkCOhQBOenUdONQgH7P93qtBMkpdhe7O1kMc6Fpzd/wUCyCT54GqqquUZ3u25qOW2yFBw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(31686004)(36756003)(4326008)(38100700002)(6486002)(66556008)(41300700001)(83380400001)(86362001)(31696002)(186003)(53546011)(6512007)(8936002)(2616005)(2906002)(316002)(6506007)(5660300002)(8676002)(478600001)(66946007)(110136005)(26005)(54906003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dzRvVVVIdUpZa1VnbE9WOEtxR2hSVmg0Z09hSVlyeU9FeGRmbHVMUGtBNktP?=
 =?utf-8?B?ald6RUN0cThjRHUzV2lHeTVGMU5kYVRNWndZQk42STVJWndzYU9Uc212UzNB?=
 =?utf-8?B?MzdzclRmRkdROTZ1dHFjVE44MmNtaUJSOWVBMnFpdWM5TjNuYk1JZFR2ZVNN?=
 =?utf-8?B?THQxQ2g1Z1pPWWl6RmxhTSt2ckxOMDE5OGdMczh4cnJDdUVLek9WT0QxaHpm?=
 =?utf-8?B?N0hUbGh4bFNNV0FwWEo0ZzhCWmdRV216aGdwcDlGVld5NEZuakpsamNLc2RF?=
 =?utf-8?B?NWdTSVlXTGJKS1NKWHlnUk8yQmpUVzNvZkR5QVRjSHlFR3RvR1ZnN0hkcmQw?=
 =?utf-8?B?cG1zSWZvTW5hcU50eVorekkwaGxTbklTY3RtMHdXdDJTeEJEaU1iWmZPZHp2?=
 =?utf-8?B?ZzExMFdCT1l1cFVQcU1NaUFmVHRtVkwrUEpRMUtycHpGTzgwSVZqRDV0UExR?=
 =?utf-8?B?ZHd0bXNjdGZNZEFsQXkzdmlNRlFjSnpScHlPaHVjQy9ONzNiQmQydDBoL3Zp?=
 =?utf-8?B?OUVXbnZOam1yOUxVMzlCK0IzWVhRL0gwTWIwNUJzZUorcXp3ZjZ1OGR6WVhr?=
 =?utf-8?B?LzVZeWJ6bjJ5ZEpUVHNMTG5nUFNoZXZKV25DTUovdkg0NzdsSG9aaDdnazZG?=
 =?utf-8?B?VlR3RHZvZXhyUVJxaGQwaGE2ZWVyVGJKcFJ0aFRuWk1vVXpmREk5REsvZ2R3?=
 =?utf-8?B?WUdSS0NjWVg0eXo0YURuQVE5TllYUTFIZDF1TktJZ1ZEdWpWWVFzaTFyb080?=
 =?utf-8?B?WldBTnQ2YkgrUUFXNWpqTHFMVTVheEJDZStrdTQxaXBneUdsbzZMWkQ5TzJa?=
 =?utf-8?B?ait5emZDV3FCMW5zaVdsMG10V3E4bldSQWR2bDZOeDRhcTNTZzhZK1JCT25C?=
 =?utf-8?B?OU9Sd2sxeGFwVnA2cWNUNHZEU2IzZjU5ekR2Z3g4eGRUMmVRK01Hb2FhWFFq?=
 =?utf-8?B?WlVjbXVZZ0JheGxMSGZkRGNCUUZPRmlDR1k1ZGRLUG4xeEtoY2U0a1BSb3BI?=
 =?utf-8?B?eVF2TjdWMGl3VlYrb2s4SjBFWk1NTng5OVhkeXkzRUl2NUpvYlcrai80enY0?=
 =?utf-8?B?SEJWZEpDUnVNRFAzY2JBbHMxaEpxRnRxNmpQWmhOeXMwLzFHMlUyeWpqNWVu?=
 =?utf-8?B?N2dxZDJRQkpTOW9ZTHVYUXhaaUFTL1VBR1lCdDFGSE9MN1IwTEIya1l1RHpT?=
 =?utf-8?B?U09iVnVXV0Q3dnV4NlNhRm5mMTU2clBJdFVpbGd3QTV5OEFmYTJaR2UwdnZk?=
 =?utf-8?B?aDQ1WVo5RklkMnpDRkhncFkvRW1UTURCK3YzVkQ5WjZCWXlrQVlMNjZCNDhC?=
 =?utf-8?B?SnlRUTE3T1BGNWxkNmEwLzZtbXplcXcwbFpLQU9mMmU0QXd1cWlYd0hPMll6?=
 =?utf-8?B?aHhlTXR4c1pUK1NnTlN0bjlIZS9HTW5ydXhQVXRsTVdJUnhkZlM4ellscmFH?=
 =?utf-8?B?SU9xU2tXUUI4cWJ3NXpGNndvSkt2Y0ZQYTlRak5FWmpMT3NreUJ6R0czRG1T?=
 =?utf-8?B?V1hZUzNiODJ1c24ydFEzUGd5KzdRMm4wdm9CdzBMUjh5VXpnY1VGcUk1RnpG?=
 =?utf-8?B?d3FiVDNLSGtxSXpHU3hUZWtVRWI0amZhS0R4eGZGODdoeXZ2ZUlCM3JGUGZR?=
 =?utf-8?B?VDB6QlB2VU15QVFZUEhXOFRiYXdWc0NjekUrbkNtUDljcnhMRDFhazZFaHdm?=
 =?utf-8?B?Qk55UGxtYm5DWTF3VDdwN2gxODk1WUJhVk9sQVcwNmlYbVhlenJVR2kyRWl6?=
 =?utf-8?B?bXFHRWFLYVJxY005d0xxb1IvVHl0aEZHV2RwdTdVNStnWGZRS2dQa0t0VVVu?=
 =?utf-8?B?dE1vd1V5dVl1UWNqSDFlQ0JXT3k3Mys2d3dLZXRGSUtzZUJ6bzJnYXlaT0g1?=
 =?utf-8?B?RXkrMktvZ3Nxeml5S3hUYTRjYlFsQXVWOVEwMDlzUWpYYUp6NE13VEFINHJF?=
 =?utf-8?B?b2dvNWVvM1VYVFowR0RxR0NlKzgraEtuQkxSSWNyY1ZJMXZXdFNJUzBoTnJU?=
 =?utf-8?B?ZVlHT2JDaUxyWE5TdDgvSDMwNHVTR0l1UkVUQlorSHdmSVN3Nk5qZm1rWWFk?=
 =?utf-8?B?YXJVTkREQkRiL2lvWmZ4SEk2eWlBd2NpcEorbXZ1N0NQK0FuamtCZm4yZzVp?=
 =?utf-8?Q?hpWN2LJebFB2JoPsYA4NGKTRr?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae3cebd4-2e7f-49f1-2cf8-08dab589dc2d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 06:34:53.6691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gnadk6YTc6tljVB6BAQ1rvYFJ0EnV3LNSj4eagsi+6pszgvOP3PSWZmgM6rmMCvfTxv18nNagn02zXxiHZFMbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7881

On 22.10.2022 02:50, Henry Wang wrote:
>> -----Original Message-----
>> From: Bertrand Marquis <Bertrand.Marquis@arm.com>
>> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>>
>>> On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote:
>>>
>>> (+ Arm maintainers)
>>>
>>>> -----Original Message-----
>>>> From: Oleksandr <olekstysh@gmail.com>
>>>> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
>>>> On 19.07.22 13:40, Jan Beulich wrote:
>>>>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
>>>>>> Jan Beulich <jbeulich@suse.com> writes:
>>>>>>
>>>>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
>>>>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
>>>>>>>> iounmap(), but not added corresponding include.
>>>>>>>>
>>>>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
>>>>>>> I don't think there's any active issue with the "missing" include:
>>>>>>> That's only a problem once Arm has vPCI code enabled? In which
>>>>>>> case I don't think a Fixes: tag is warranted.
>>>>>> Fair enough. May I ask committer to drop this tag?
>>>>> I had taken respective note already, in case I end up committing this.
>>>>> But this is the last patch of the series, so I can only guess whether
>>>>> it might be okay to go in ahead of the other three patches.
>>>>>
>>>>> Jan
>>>>
>>>>
>>>> I am wondering, where this patch could be 4.17 material?
>>>>
>>>> The patch series seem to get stuck, but the current patch just adds a
>>>> missing include to fix a build on Arm, so it is completely independent.
>>>> I agree, there is no issue with the current code base as vPCI is
>>>> disabled on Arm, so nothing to fix right now. But as PCI
>>>> passthrough/vPCI on Arm is in the development stage, the developers
>>>> enable that support in their builds. I think the risk is rather low than
>>>> high.
>>>
>>> It seems reasonable to me, but I am curious about what Arm maintainers
>>> and PCI maintainers think. From the history discussion in this thread I
>>> think it is pretty safe to include this in 4.17. Thanks for the ping.
>>
>> I think this can safely go in for 4.17.
>>
>> Cheers
>> Bertrand
> 
> Thanks for the feedback :) Feel free to add my:
> 
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Okay, recorded, but first of all this patch needs Roger's ack.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 06:45:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 06:45:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428734.679181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrD3-00045p-BP; Mon, 24 Oct 2022 06:45:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428734.679181; Mon, 24 Oct 2022 06:45:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrD3-00045i-8b; Mon, 24 Oct 2022 06:45:17 +0000
Received: by outflank-mailman (input) for mailman id 428734;
 Mon, 24 Oct 2022 06:45:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omrD1-00045c-Aj
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 06:45:15 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60078.outbound.protection.outlook.com [40.107.6.78])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6989e557-5367-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 08:45:13 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DBBPR04MB7930.eurprd04.prod.outlook.com (2603:10a6:10:1ea::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 06:45:12 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 06:45:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6989e557-5367-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NKkkkjPLMd4OdqLmfhSnGTUAxGF/hY3l3dwCfPFWivutOUMOk0h5IOcTFgdSlQNYavQwPoGbZyJdmr5RObYN/ngpQNqN+C4lT3HrIjBjCsrO5xW0HnvW91OAGEjRbh72ek7SkztqgCZCFEmxpgzy4eG+j0doUT97lgd5ebx2h7sysO1WRcpZugumQOkiMfR7V+EFGE9Yj8CNYlo7hBxGWLj1AYcB0gFKKabudA81l4k58p3kZB1wbo6oSe4oSoprO8MVHjOaAVL7Vfq6+OFWrANird+xCAwyZgn1Znw6sYMgjJZYlpr4MpWUuoNQ0KzFm154PnLb1BOZXTsC9oPtdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jmy7+wzwZM2+j3JxQJ8Ata5ltaguYsH2KHmX7vWAQMk=;
 b=DOnpr+kkbE+FhOP7n7dOMKIOofZJyC5/bhGe1ERcF5267e5LJb94rW3vgHS2gzuq5/q5uHwjceQE/L7ssBN6bUy7o9AQcELduMiYM2wYC7NvDSnbQUVFRcNls9BoLbufWZgeIZ88xQTNhTg1tehekMV24jh+BHMKC7WNiNHgU9wzGqL/xA6lwY6Uk4QpfuCoyEBP1ouFH9hT3hbk7+901wkJUlZt24xj8nhewn0okZ8otvPkznofTSSF/7ilx00NtUHtguKF3T2PeasN1/nIQls/FmuOWrVKObQQlqrhsfgBLHOHyQ515z8RRAaNTeYmGN2rtEKCiwYMLDeDBuPOVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jmy7+wzwZM2+j3JxQJ8Ata5ltaguYsH2KHmX7vWAQMk=;
 b=N+wjsZPUzbQkAxcwXDpF1xyn4GjHAwFyrQtyJx7466ggnppgwyNsSq9ilVIak6fwiGOsbdDYRfW4Mkb5EwaIEE6TONLfYFicQ/GyEM++7EdfZgyH2BrAnMlEdNCOwW+WLf9Jie8K8qn5KP3Lqaq4LGcJAjzaA+C0pX26zkwB3Q6/pwsqBK4//LahlCLQGKQdVKp2h0TNtkn7ZghweV6ja9U/mzhFSdzOU1OdYuWpShV7LpLFz8jFBD/D5V8e1GQXnf9qSEsi4S+laROpXRfjzVrVknb16P4pNo2V/kZQTVxpBBlA6B5vfd8q8X/sKhHDRdDWZs2BwliI4aqd+ellsQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <435610e2-4fc4-6a9c-3fcc-c6d6ab42cdc1@suse.com>
Date: Mon, 24 Oct 2022 08:45:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Intended behavior/usage of SSBD setting
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
 <8c7de7ed-6242-f444-55fc-9eb16084b7bf@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8c7de7ed-6242-f444-55fc-9eb16084b7bf@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7930:EE_
X-MS-Office365-Filtering-Correlation-Id: 5b8060a9-aefc-4694-db10-08dab58b4cce
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JrKXQu///44o19u19y9ZIxB7MkJbqN7lL41iEdClaKokqQcxPXA+BTFJEg8R1d/YBOFuma7+mhwfIx3fUjIXAkX2SzhS4MGl65MYj0dKs9FjdLJ2K18YjmFA3L8LEOotZnT/UJ3TKE0+JAU6NBSDiNoGeuqSAb9zd6/0QHELzd9qXxhD1lERiecJP3DoCy5yXMib9lAgmAowiKOVPgeIYyzuRx2h6Wa8X0vW+OdYFb3aj7XhFFX295iCjcMd2fT+Di1TNA8/M66HleKVOHyMzzgMBOpEFYXUjt0nTl5HorHZzpWhzBMvvnk0rM4G6TvydePrueTiySoZrhfBnMdh/1wMvymKwaF+mDuv6mB+kFiLb4W+CZpMDJq5MLd4MUIYrD5xMUHnhoq/PSqCg34wk/z+tTEUZ0xGkKSCAClbs6b4teakeJnhIscZfh5uU/R+DehZgzQxUlKJuorvULdmM5jCB/EbOsepSwIXpEcbVkQfoNzM7cMUT8DPM+w/Fjd3juVPURBOb7krEZLI+S+iCSlnNSg41NfC+t8lUaf7fmACIzIh53FJmg5QZgEs233SY02TuewkV1l91yEiNobrPDrW9UfZAQsb4K9k9RReUNcNlbs47IFgbOYWDiYIgrIPhR7PGqOBmWpr4+p2wws3Y3zuR3q5TAX/w1A0sF2xFw9w1i6FwMjQunkqg7t0wFifMjUF3WMji/s4giSp5ASmdAxpFYGsRu6sv7sxvKPx+oXGLynJqqBx+k+Any25egImhrMJQS3cp5KStD9TaarKzCMUC9VHR0c8Kj88HaDG5eNm0nvAUe+XRBEn8tIaUWV59n4SCGDgJ872gLB1+iSs+Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(31686004)(66899015)(53546011)(316002)(6512007)(26005)(54906003)(6916009)(36756003)(66476007)(4326008)(8676002)(66556008)(86362001)(31696002)(66946007)(41300700001)(8936002)(5660300002)(2906002)(6666004)(478600001)(6506007)(966005)(6486002)(83380400001)(38100700002)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eUxRQ212elc5TkRDQXZORkZHVnVkNDA3TFUvZy85aGtXbEJVZjFDQXNRRlZi?=
 =?utf-8?B?ODZSM0ttbTRzcjhVU3AzQXl4WUpOaGtuZllJV09kQ0FHRVR4WHgvUjJPVVNj?=
 =?utf-8?B?eGhJODdQaEZubEYyMHB2T1Ewc2R2VlB5VWxCbjZrT090NStCN3g5UW9KZXhy?=
 =?utf-8?B?ZGF6WU5DTXhKbHZadkZuaFNpakl6WDBRbWVNaW5XMUdlSVdVbHhrMDBPeXMz?=
 =?utf-8?B?dFk3Y0xlYjlnT1Fra2llRUdYa2ZPb2NJS3ovaklZY05nalMybWF6UVpWYitr?=
 =?utf-8?B?NC9wc2dSOE0rd3oza0pWbCsyVzM5eEFCVDRZdnNXV1dabGdQM25mS2l6MTZa?=
 =?utf-8?B?ZTQ4UXViM1ZJNE5tU3Q2amdVSndOTHBFTGZSeWdlMmtQUEdWMS9uTTN0SXFY?=
 =?utf-8?B?eUNLbjRtbUVLc0ZEVFFpdXdpUXh5bTZlblUzaUhhaWtUOENlcElSR0FFclYy?=
 =?utf-8?B?S3NuMGlmNVdmb0thTmR1UFJQenlHc08vMk40bnJyaTZQWEpDRU1RRmZXVUVW?=
 =?utf-8?B?ZHZMUXludWtOU3A1U2w5UzBIWVcyaGZYVXRiRHdMdFlmbVF6SFhTTXRycFdu?=
 =?utf-8?B?SlN2UG56UEpIS0ZDa2VLZ1RYQ0FwZWJxaFRsM1dGV3VCQXlwNUc2d3BrSjh4?=
 =?utf-8?B?UEErWFJHaS9kVDZjNFR4bENURzc3dGsvZnFBZm90SDN3SWp6SkttR09GS1Yw?=
 =?utf-8?B?RFlDSGVDZngxUWZGYlVaek0zRVh5ZmNWdWFWU2EzNktSVFA1RzdxbUJJcWdU?=
 =?utf-8?B?R05XOVgxVWsxRlN3N2t4eG14WFN2bWlwWUhrQk1nc0krd05KODFGN2JCZGJj?=
 =?utf-8?B?V1JHYldhRHl3REhDVGd4ZE83OSt5MW1lNnpOWXZaTlBIUDBkbk5wMk5WWENn?=
 =?utf-8?B?cExaeld6RTM3Y3NXb0RyQ21acGhBM1k5V3BjSzhSY1FzUW9zVEtaY2cveUc2?=
 =?utf-8?B?Q0VrVjg0WFRzdFRacXNiT0ZWcnUybGVsakxrVmVzOWhkalJmNkdRM1oxOHkv?=
 =?utf-8?B?TFp2T2VtL1p5L3AvMzMzNWswVEwyenJ6dGk2R0wyeCtLMDFsa1lDTGpPUEth?=
 =?utf-8?B?WC9mcUZSMHRZOEc1NUlRc1FSbThKWmRaUW9CMTNCVmdLSkk5NGVrRzI3eEZH?=
 =?utf-8?B?Rm1sRDlZQ2I1UzFGVDVNUW1zZE01TVhZT2IrTDNCQllHaDh6Wk1GcG1MY1Rj?=
 =?utf-8?B?OU9ybVpZN0cwSElQVngzT2pDd20rcXBiK0F5dDN2QUZoMkJMOUtXWDBYaFZL?=
 =?utf-8?B?OS84Tm04WktSYXVQMXQ5a3dsL2EwTkQ3N2VKQ2Nqd21wTEFMOHZraE4vZE1v?=
 =?utf-8?B?aWhSMlJBUjVjQ0E3STlMYVNlS21SaEdZYko4Z3ZRRlVTZWNOU0pmRHJQK0s4?=
 =?utf-8?B?VEFLVThnczQyM3gyZlNtVUtING03Q0ZrbVBzNkJOa0F5UkhGRDJvMGhISzM3?=
 =?utf-8?B?MnpWem1sTmNLSk9jN0hKdDFVamxDVER4ZXlTMXZsL0FPeDhaZUhEVTk0cFNy?=
 =?utf-8?B?dWVmTmJ6NER0bE5qb2loZ0tiLytjdnZsSVBVYzR6OFA3aUp1K1E3cnhrVEZQ?=
 =?utf-8?B?UFRhUVVib1V3UEMySlN2WEZYRkVEMGFNdWd5WTdaMFBDMTRSNU9VaXBOdUIw?=
 =?utf-8?B?dHVEZjNJcHA0VzFUWDZUQWxjS3NHWU5KVm8yMWZTTUYwejFsUjkzWFhicURR?=
 =?utf-8?B?aTVrREpvN3ZPWmxrT3BOSldONzRyRm83VmFHSDhTdWRDaC9MSGlad08rNnJY?=
 =?utf-8?B?ajhvVDhyUTlJUStTazJzSVZjTEJmUHIvN1JHWUE1RFBvU2lDMWhQUGdmWHpH?=
 =?utf-8?B?bVdOd3ZPaC9JWjlzMXE1TEx5bnJrUkxUWXhDOEEvQis5Z0FJYVZGMVRteUxv?=
 =?utf-8?B?RXhyUUw0UWhIV0k5NDZJdm1sK1NTR2JkbVJvTGN3WWdhdWV3dGpLa0VkeXlH?=
 =?utf-8?B?U0hRc0gxWGhwcEJqTThRQStsTFdvUy84Ymd1b0V1dFZrWDlhR2E0NTg2elNG?=
 =?utf-8?B?SENxVFVrN214Y0IzaUE5bHVrdDRRRnkyeStJc1J0d25tQnhzUUZ4ZjVJNVlK?=
 =?utf-8?B?ZUpINWNoTWU3elIxVFYxdUNnV3JPZS9VVVhaQUx0QnlBNTVzWnc2TFVlWVZS?=
 =?utf-8?Q?OBIt5BvBbL++i6n0MwsPyNfxw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b8060a9-aefc-4694-db10-08dab58b4cce
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 06:45:12.1146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o44lrPBeHm1I90dVtAQpVu8NsUN/I25D9Oyh6Ee7eqNBvQlpzT2cjXdUi/jyktjm+Gx9VyhdR5scucqbO8wvpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7930

On 21.10.2022 23:54, Andrew Cooper wrote:
> On 20/10/2022 12:01, Roger Pau Monné wrote:
>> Hello,
>>
>> As part of some follow up improvements to my VIRT_SPEC_CTRL series we
>> have been discussing what the usage of SSBD should be for the
>> hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
>> that has an out of date description, as now SSBD is always offered to
>> guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
>>
>> It has been pointed out by Andrew that toggling SSBD on AMD using
>> VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
>> have a high impact on performance, and hence switching it on every
>> guest <-> hypervisor context switch is likely a very high
>> performance penalty.
>>
>> It's been suggested that it could be more appropriate to run Xen with
>> the guest SSBD selection on those systems, however that clashes with
>> the current intent of the `spec-ctrl=ssbd` option.
>>
>> I hope I have captured the expressed opinions correctly in the text
>> above.
>>
>> I see two ways to solve this:
>>
>>  * Keep the current logic for switching SSBD on guest <-> hypervisor
>>    context switch, but only use it if `spec-ctrl=ssbd` is set on the
>>    command line.
>>
>>  * Remove the logic for switching SSBD on guest <-> hypervisor context
>>    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
>>    hypervisor code with the guest selection of SSBD.
>>
>> Which has raised me the question of whether there's an use case
>> for always running hypervisor code with SSBD enabled, or that's no
>> longer relevant if we always offer guests a way for them to toggle the
>> setting when required.
>>
>> I would like to settle on a way forward, so we can get this fixed
>> before 4.17.
>>
>> Thanks, Roger.
>>
>> [0] https://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#spec-ctrl-x86
> 
> There are many issues at play here.  Not least that virt spec ctrl is
> technically a leftover task that ought to force a re-issue of XSA-263.
> 
> Accessing MSRs (even reading) is very expensive, typically >1k cycles. 
> The core CFG registers are more expensive than most, because they're
> intended to be configured once after reset and then left alone.
> 
> Throughout the speculation work, we've seen crippling performance hits
> from accessing MSRs in fastpaths.  The fact we're forced to use MSRs in
> fastpaths even on new CPUs with built in (rather than retrofitted)
> speculation support is is an area of concern still being worked on with
> the CPU vendors.
> 
> Case in point.  We found for XSA-398 that toggling AMD's
> MSR_SPEC_CTRL.IBRS on the PV entrypath was so bad that setting it
> unilaterally behind the back of PV guests was the faster option. 
> (Another todo is to stop doing this on Intel eIBRS systems, and this
> will recover us a decent chunk of performance.)
> 
> 
> SSBD mitigations are (rightly or wrongly) off by default for performance
> reasons.  AMD are less affected than Intel, for microarchitectural
> reasons which are discussed in relevant whitepapers, and which are
> expected to remain true for future CPUs.
> 
> When Xen doesn't care about the protecting itself against SSBD by
> default, I guarantee you that it will be faster to omit the MSR accesses
> and run in the guest kernel's choice, than to clear the SSBD
> protection.  We simply don't spend long enough in the hypervisor for the
> hit against memory accesses to dwarf the hit for MSR accesses taken on
> entry/exit.
> 
> The reason we put in spec-ctrl=ssbd was as a stopgap, because at the
> time we didn't know how bad SSB really was, and it was decided that the
> admin should have a big hammer to use if they really needed.
> 
> When Xen does care about protecting itself, the above reasoning bites
> back hard.  Because we spend (or should be spending!) >99% of time in
> the guest, the hit to memory accesses is far more likely to be able
> dwarf the hit from the MSR accesses, but now, the dominating factor for
> performance is the vmexit rate.
> 
> The problem is that if you've got a completely compute bound workload,
> there are very few exits, while if you've got an IO bound workload,
> there are plenty of exits.  I honestly don't know if it will be more
> efficient to leave SSBD active unilaterally (whether or not we hide
> this, e.g. synthesizing SSB_NO), or to let the guest run with it kernels
> choice.  I suspect the answer is different with different workloads.
> 
> 
> But, one other factor helps us.  Given that the default is fast (rather
> than secure), anyone opting in to spec-ctrl=ssbd is saying "I care more
> about security than performance", at which point we can simplify what we
> do because we don't need to cater to everyone.
> 
> 
> As a slight tangent, there is a cost to having too many options, which
> must not be ignored.  Xen's speculation safety is far too complicated
> already and needs to get more simple; this has a material impact on how
> easy it is to follow, and how easy it to make changes.
> 
> It is the way it is because we've had 6 years of drip feeding one
> problem after another, and haven't had the time to take a step and
> design something more sensible from having 6 years of
> knowledge/learnings as a basis.  There are definitely things which I
> would have done differently, if 6 years ago, I'd known what I know now,
> and part of the reason why the recent speculation security work has
> taken so much effort is because it has involved reworking the effort
> which came before, to a deadline which never has enough time to plan
> properly within.
> 
> 
> So, first question, do we care about having an "SSBD active while in
> Xen" mode?
> 
> Probably yes, because we a) still don't have a working solution for PV
> guests on AMD and b) who knows if there's something far worse lurking in
> the future.  Sods law says that if we decide no here, it will be
> critical for some future issue.
> 
> But as it's off by default and noone's made has made any noise about
> having it on, we ought to prioritise simplicity.
> 
> Given that off is the default, but we know that kernels do offer it to
> userspace, and it does get used by certain processes, we need to
> prioritise performance.  And here, this is net system performance, not
> "ensure it's off whenever it can be".  Having Xen run in the guest
> kernel's choice of value will result in much better overall performance,
> than trying to modify the setting in the VMentry/exit path.

My takeaway from this reply of yours is: By default run with the guest's
choice, while (I'm less certain here) you're undecided about the behavior
with "spec-ctrl=ssbd". Please could you make explicit whether this is a
correct understanding of mine?

Jan

> Sorry that this is a very long and somewhat open ended answer, but it is
> genuinely the level of complexity I grapple with on every security issue
> in this area.
> 
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 06:47:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 06:47:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428740.679193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrEz-0004k8-Qz; Mon, 24 Oct 2022 06:47:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428740.679193; Mon, 24 Oct 2022 06:47:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrEz-0004k1-NY; Mon, 24 Oct 2022 06:47:17 +0000
Received: by outflank-mailman (input) for mailman id 428740;
 Mon, 24 Oct 2022 06:47:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omrEx-0004jr-Q0; Mon, 24 Oct 2022 06:47:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omrEx-0004a9-KF; Mon, 24 Oct 2022 06:47:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omrEx-0007s8-7m; Mon, 24 Oct 2022 06:47:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omrEx-0005XQ-7G; Mon, 24 Oct 2022 06:47:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Mh2r8qabbeZ1wcTuKGUfjOA/VQQYKVPWjDdGbEfy9Oo=; b=jBU88gm3brETxH4LWeMRez6S1E
	dEB+sj8Aq0JhkLGL9F3oA3gnjf2yMEKD/pyl7uNe5W7uQ0lefOnd/4cs9fQPmgWvh177k+5fQKqTr
	55NFt5HML4l5A9RuVc5nSMPK7/8p99wF4u9ftAcA/IATshJT2/bIMIqFsX6/jVsWZtWQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174280-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174280: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug
    xen-4.13-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.13-testing:test-amd64-amd64-xl-pvshim:guest-localmigrate/x10:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.13-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 06:47:15 +0000

flight 174280 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174280/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174280
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail in 174216 pass in 174280
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935
 test-amd64-i386-libvirt-xsm   7 xen-install                fail pass in 174126
 test-amd64-i386-qemut-rhel6hvm-amd  7 xen-install          fail pass in 174216
 test-amd64-amd64-xl-pvshim   20 guest-localmigrate/x10     fail pass in 174216

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 174126 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174126 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174126 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174126 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174126 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174126 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174126 n/a
 build-armhf                   2 hosts-allocate           starved in 174126 n/a

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   69 days
Failing since        173495  2022-10-11 14:08:01 Z   12 days   13 attempts
Testing same since   173657  2022-10-13 01:09:08 Z   11 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 07:16:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 07:16:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428751.679215 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrgz-0008Mc-8h; Mon, 24 Oct 2022 07:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428751.679215; Mon, 24 Oct 2022 07:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrgz-0008MV-63; Mon, 24 Oct 2022 07:16:13 +0000
Received: by outflank-mailman (input) for mailman id 428751;
 Mon, 24 Oct 2022 07:16:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tdD1=2Z=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1omrgx-0008MP-Qu
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 07:16:11 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b7af580d-536b-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 09:16:04 +0200 (CEST)
Received: from DS7PR03CA0077.namprd03.prod.outlook.com (2603:10b6:5:3bb::22)
 by DS7PR12MB5911.namprd12.prod.outlook.com (2603:10b6:8:7c::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 24 Oct
 2022 07:15:59 +0000
Received: from DM6NAM11FT061.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:3bb:cafe::74) by DS7PR03CA0077.outlook.office365.com
 (2603:10b6:5:3bb::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27 via Frontend
 Transport; Mon, 24 Oct 2022 07:15:59 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT061.mail.protection.outlook.com (10.13.173.138) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 07:15:58 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 02:15:57 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 24 Oct 2022 02:15:42 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7af580d-536b-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gUq3C/8/yiKxQy3eoRbLRCZ4q0em8fZ2hpVrGkiHDtXwLlrXpAJgGUlKFdX6GATAbuOYAfJoyQhDhR1KTzFdVywGOVr64wBixolSbbUrt1+j1QoPCWl1xYq6tEHqxWdbq+3c1qIQ6N52DxfENP0mnhUJuglax8adyZbhSwPzlKaHbG+NuG79dLSaIrBsPo5/L4Y5x1jQt5qkqyYpjjb9pnPXT+BCe3gRmCbQ0TdXFaI1/9tsfuJXRrObT1bynBCJcvYulQrkKXUCVmflJzl1kX14t/dkaXE3/8tVq+LsVDweYh0YPcHLrr4CaPulVHhygq4/wDvqB91+5fdJFmrSJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZgHiBQ/44sNd/SB4hB3n+crBYmw51aO1I6Gz5eztZ9M=;
 b=CCGiBQsPsWboWb32r9/EbSQA13q79JSMr2TmLqtg+dF7DdiDpmfjBv2jILZfyJYJTSVmij74M+9B3HNw88pBrMqi4KQqJT0yIpG/Gfa2TKVZ2BrC3sKMceIGhs3L9H9IDp60oItPXPHdw8Og+tQY3UJp2lEb0BapYmY0mmGGjPoY5z5DqpcoS7WaZQaYfbgAjV0ZP9LjxnTmgLIMy72bAd/HPIyDCbcCKplRSrzcVFjQcYGas19APjAalDQxvp9alLFSX1xoFdxAiL+wR1BFI9PuQpBzBMrk8x7C5U8xNr2iYp5QNstRfoWNeAZRXNr/gzop7vrorV928SfNZCvfFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZgHiBQ/44sNd/SB4hB3n+crBYmw51aO1I6Gz5eztZ9M=;
 b=viehAIf7F3cN2GYpnWQwB6xPwc+VMI4NJUEUYukKEeR46SM9ppfdo5b61lw2vAFADi8NUAvHhZWxoblmhy20XpPRtUeYcuzoHvGPfnBQoQO4MvXehv7BFN6mhSwW2HMSqTixpnuRuWaCJSvE99062xbbsbqz3NZDHYxwJ4RmoO0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <76b7f236-f99d-7600-3958-6a92943b564c@amd.com>
Date: Mon, 24 Oct 2022 09:15:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
To: Stefano Stabellini <sstabellini@kernel.org>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>, Jan Beulich
	<jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>, Henry Wang <Henry.Wang@arm.com>
References: <20221021165341.7905-1-michal.orzel@amd.com>
 <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
 <alpine.DEB.2.22.394.2210211211090.3873@ubuntu-linux-20-04-desktop>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <alpine.DEB.2.22.394.2210211211090.3873@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT061:EE_|DS7PR12MB5911:EE_
X-MS-Office365-Filtering-Correlation-Id: c8d34c4b-d0ef-4105-f36d-08dab58f99bc
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	joHy93JEuUE7OiORb2Qj6ZjRXQfrYXnqwHx9mlCi54O6KO0IKz11EVXhCKdlGW2Iv9xtyeU2l36U90Ivfn7ObzqKXgWkT01Hx+DS7nqeayUUrSiNOa8b2d/cpNr2zrICWOWT7hX9oHBVfn2WD24aFrz0P7pxwOOQrlCoKsK8IgdA6sTL4e7gCwlRXjupBY53s8Iiu4zo/h6V68314B5G0kKbIwVzdI2DSu4/gbXaGzYHlSgI7DRwygvKzJdFUL4blIJLOHZ+FRYsqGICUjFI0axUhb6V8jVCOq+C/TZela3/d79iEIpPYn254oUxVZzxB8ri5KqYGHYlpyYSLpleR/0FaLMefp4ySZEJzH2bKQkXzOaBXOUEA3tULvuhVCARINV7NudHxS7zv0wyR157zSQEMkVGs4k4AawhIHrMrmrro69HkKFTkXXgQMUJh+sLpfEzMx2qfeibLsdzrxWLW8uCL26ZK7PHwV4Swz+q0YyAUbcrJmOw8I5TNRI9ikdtw04GuAcLEwfYMb2M7M5p2JWORf6mE+q4MBHjD0vUDpB58LoqHjucg+hZz83Z7XNy/uj6fFUlM+BqNuEQ2X0pxkBcr/JH4EGNB+lqF7lmIm6VOP7IB8T/ZGKZQKIQmhN03FEFY5tJCePvHigr5I7aquZe4hSUlEhlmHCBU2yrtJvblf4iKY2SRxQNY5jaBfSNSliv7emLd18EdfkTPOPnl6j3+zGS67Y3ncDdBIrAhXCfdajiCm6+UQ8k4W8n/FSsgJLtVh9ZsIXob96uHebnoA/Cq72QT3EfadGAivqE1cRjN9UJWPWIYsXRdEnvjTC1uv2FVLU3tC1ncqg92EXviA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199015)(40470700004)(46966006)(36840700001)(36860700001)(31696002)(81166007)(40460700003)(356005)(83380400001)(47076005)(8936002)(336012)(44832011)(5660300002)(82740400003)(8676002)(186003)(110136005)(86362001)(16576012)(82310400005)(4326008)(53546011)(54906003)(70206006)(316002)(40480700001)(70586007)(2906002)(41300700001)(26005)(2616005)(426003)(36756003)(478600001)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 07:15:58.9813
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c8d34c4b-d0ef-4105-f36d-08dab58f99bc
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT061.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5911

Replying to all,

On 21/10/2022 21:36, Stefano Stabellini wrote:
> 
> 
> On Fri, 21 Oct 2022, Andrew Cooper wrote:
>> On 21/10/2022 17:53, Michal Orzel wrote:
>>> Null scheduler is not enabled on non-debug Xen builds so the current
>>> test can lead to a failure on such jobs. We still want to test that we
>>> can assign the cpupool to a domU with a different scheduler than default
>>> one (credit2). Switch to credit as it is enabled by default.
>>>
>>> Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>
>> /sigh - I'm sure I nacked that stupidity to begin with.  apparently not...
>>
>> It is totally bogus for CONFIG_DEBUG to influence logical chunks of
>> functionality like this.  The CI script is good in its current form.
>>
>> RTDS and ARINC should be default n.
>>
>> NULL is more tricky.  PV_SHIM is explicitly security supported, and has
>> been for years, so the "UNSUPPORTED" is bogus, whatever the default is.
>>
>> As NULL is explicitly tested in CI, it's clearly supported, and probably
>> ought to be on default.
>>
>>
>> Please instead fix Kconfig to not be broken.  That will be a far better
>> fix overall for people.
>>
>> As a more general note, tests which are using non-default pieces of
>> logic ought to activate them explicitly.
> 
> 
> I agree with you, but first let me clarify the word "supported".
> 
> 
> In Xen Project "supported" implies extra efforts to follow the security
> process and of course the security team should be on board with it. If
> we say "supported, non security supported" we don't need to follow the
> security process but still we sign up for backporting fixes to the
> stable tree. It is less extra effort but still some extra effort is
> involved.
> 
> So, this specific issue aside, I think that as we expand the testing
> capabilities of gitlab-ci, we'll have tests for things that are not
> necessarily neither "supported" nor "supported, non security supported".
> 
> 
> For the NULL scheduler, it is clearly important to many users so it
> would be valuable to move it to "supported, non security supported" and
> enabling it by default in the build. I don't recall if we still have any
> known outstanding issues with it. I think we need a separate email
> thread for that discussion and I would understand if the decision is not
> to change NULL support status for the 4.17 release (maybe for the 4.18
> release?).
> 
> 
> In any case, we don't need CONFIG_DEBUG to enable CONFIG_UNSUPPORTED. It
> is just that UNSUPPORTED and NULL don't get enabled by default in the
> non-DEBUG build. So to fix gitlab-ci, we can simply enable
> CONFIG_UNSUPPORTED explicitly for the builds where we need it
> (alpine-3.12-gcc-arm64-boot-cpupools).

Given that there are still diverging opinions \wrt making use of DEBUG
to influence enabling/disabling some functionalities in the code, I would
opt for modifying the CI job to explicitly specify the required config options,
just like I did for static-mem test. The necessary options to enable NULL are:
CONFIG_EXPERT=y
CONFIG_UNSUPPORTED=y
CONFIG_SCHED_NULL=y

This will fix the issue and allow us to continue with 4.17 release.
Given the outstanding issues reported by Julien, it would be challenging to
try to mark the NULL scheduler as supported, not security supported for this release.

Besides that, I think that Andrew still has a valid point. We seem to use DEBUG
only in Kconfig.debug (obvious choice) and sched/Kconfig. So this is not something
common to rely on DEBUG to enable logical functionalities (why did we make this exception for schedulers?).
Having said that, I think the discussion on whether to switch to default n
instead of default DEBUG or not is still valid and requires more people to give feedback.

~Michal




From xen-devel-bounces@lists.xenproject.org Mon Oct 24 07:26:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 07:26:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428758.679226 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrqd-0001VH-9U; Mon, 24 Oct 2022 07:26:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428758.679226; Mon, 24 Oct 2022 07:26:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omrqd-0001VA-6n; Mon, 24 Oct 2022 07:26:11 +0000
Received: by outflank-mailman (input) for mailman id 428758;
 Mon, 24 Oct 2022 07:26:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omrqc-0001V4-00
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 07:26:10 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c8f5b8d-536d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 09:26:01 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7325.eurprd04.prod.outlook.com (2603:10a6:800:1af::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 07:25:59 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 07:25:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c8f5b8d-536d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yu1OAr9bbNPUeIz3liHC+lbbzWZav4XNvf+JvBZfrcIMs5M45dfM9mESU0P0mA1jlMWoZc2sB5E5stNKGmMz2/FbrAmvMukpEv07Zt1KYzbFj2C+34/JWcE49YArXD+rgaWKZBiyNTuhA5WYcJJQw8qb/3cbd02uZDuAJaLec8WJut52ZQYPRoncwb5B8Eqf6lphOfQwSvf1n6hXwDcwiiSXJNbsIDDPYgCgj7aIl4fu/bLk0ZzIT0PXZ7YMvHNhI41zIhAAYHwUxyNc1PNMZ2uFNmuVof01lM1aPqjUxKUbXwmrKclACtD3wjpZA+H6+4W7mcYSn1Whp+s3L3dzRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uPaDHwW2Nd27hbTBtl7yBYj4ui9VHqKZz/zBBXiF8uA=;
 b=W0KQHi3vnEOJm8oCijW9TtWOYlQqoXO50S3cuC4RQqQHu4IpzxtsfckMN9YG2Du8RwozL90FYA3VZOxwMRsAZOTHyaro5j/Dj4fmnPYaIXahMv1Ppw+v6tzLup0jIwYi9eDAFLtjtu+UTsqKugke9YP1+YRp5iaRBQA7KN12hNKSkT0ESKQ328ISgBf2r+yTlW8YO/Nt7nO228SpmVX0ZZvELdpEPuQDV5ABMN7ycTvKkQJ2OwltHK7ldS/dpXPTt8oYiczehLYsxOITrRWpXrki6YhETYBOOAZfhF1QuG9tfEvGpLUVg6URuZnKwcWM50ZKeFyC2DIzNHcIruemJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uPaDHwW2Nd27hbTBtl7yBYj4ui9VHqKZz/zBBXiF8uA=;
 b=BOC2U0Mqz2XR1sgEPiKie1uybj6YEtQO0DcWtnO5bqcdD80MZaJa8qMdwZzFhDJ3vGaFHrU1+iAMd4DmU/hQTaTk1j7TvDoOfE+g4UtUNyJ+Vfi4/4xESWnHQnpyH9A/jFLLOBMSSnl0PljbxP90+CKzSWxLUMEcBPbJfT/DRiTKOaYVntRxuuzRU+b+c9dxxMke89j9dVr0uHDFSRL2ouHNO3vKw+Arkz2BHl5SBpSkOyvENQ6hhwFPMn2WGwyt3BXT52tPuMuExmjn8/oQmVJZ3Lgav6QT7YnwvlIvEZUtfeCe+Mr9OmLjOzc5OPXPXLrk46MZkb3Yy4iGaWL5fw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8b2d008b-526f-dc36-71d6-81b653bbf467@suse.com>
Date: Mon, 24 Oct 2022 09:26:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2][4.17?] core-parking: fix build with gcc12 and
 NR_CPUS=1
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Henry Wang <Henry.Wang@arm.com>
References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com>
 <61e8475d-868d-3ff0-041f-8f6790990ce4@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <61e8475d-868d-3ff0-041f-8f6790990ce4@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7325:EE_
X-MS-Office365-Filtering-Correlation-Id: 1d0a05dd-3914-47c3-bcc0-08dab590ff5f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UxClFyCk8Lvs+LqQTG0Ggt9zxEp/PUwiKH0Fv11c17UCw1zO7VR+VH4LpxmSY2la7E/q3hbCkXSl1ziKzq7sXY5JNT6XsC/YIo5qw3MHq0bOyUOgbCx4JreyvWxtJ/bxgGIEskh1a2ctShxKBSE0ABLgtMCmWKRnXlqzY4ag8tfuenPQSr7Mf9EwySNBA3OVr2w4b1El+xDfYGX5ETbu5hgyieN2EFlsEw0I4AE+749z7l2KgFQFxyfECoYF4wpsxh+o2sGWzXCyjHyanxO3J/gNLBMS4lVoCOtw3JrekZlyDiioTklRfnecyVxGqD7bNuNw3qgr8+W9DVLQFbjMNsM5/Ufg8/0VRhFY2Ew9TGqSh1E2wfwwQG9LF4P9DuLvCow40jIcsVTJioBJjGdIOG5nefsCNIDaEpXgJlrGYqRArQduhZZfqChsYOdhUHLDN3wDMsmAlsB6mXso8Uzm1yQg+Ho+oZJTiiEMw9XSE3D4PFV/k1aK9M7e+xm6RRuxxz/98Iuzdn6RVlfnp6NV2LHzi66OInj/i/1VG7Fe1lYp0CRmzEftm3AqZb2CWKAF4C8jinTy0gG5jCDr4ZQlsEyi/FlNcJVOAizl837paHqoat+xUAAki5rhADKDEZW5us605ZA3YvGBLLaExGZSK/tdSCBRuMiuzFdXuZ8Q1Xqrv83YPt9kLOLTzTioAvyFtTqyQBAMbCqKoiYKdttrKv+1RGCS8mHK/UOabni8di1sjhDYxOg5yHamhSl0sB0zOzlS0DcpXp6r7UGOa8qfEzEnr/zJE8U+Ph55jJw8s/g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(39850400004)(396003)(346002)(451199015)(186003)(2616005)(83380400001)(31696002)(86362001)(38100700002)(2906002)(41300700001)(8936002)(54906003)(5660300002)(478600001)(53546011)(66946007)(26005)(6666004)(6486002)(4326008)(66556008)(66476007)(6506007)(316002)(6916009)(8676002)(6512007)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGE2RDRkem5nYkdwZHFuVXRacFNReDNzUjAzcVYvQURGU0FXUUJWbDNTaU1a?=
 =?utf-8?B?YnVhYWpnQWlOUk5uMC84bC9JSkVtWjFTRGJwYWJVNFZCK2VxMnEwWTZIRUN2?=
 =?utf-8?B?K2MzQTZEMmJQMFNUNHFQcnVqZC9TcXJRc3lEaHRuV0NPNXpJeTA3K2tOSE81?=
 =?utf-8?B?QkZ2WVo1QTErTVRMMHJGMjM4Rjd6c25KUFhONHZFdlgrV1FBZUlCSThjbUJ0?=
 =?utf-8?B?bGlVdFJFSUlPVmRtaUU1NDJpYmRmOGdMTkdYT00yaUVVbVdTT01ndEh5RjdZ?=
 =?utf-8?B?WXIwTGx0cEJobDdBKzg3c2ZpMzNWN0w3SlE3RVlUakdGdzFDTjYxbVk5UUdH?=
 =?utf-8?B?UTR6R3lTQVpoVjE2dm5HVTVma3lsdFhKU0MwaTY1M2Rid2t2WThvT3NxTDZn?=
 =?utf-8?B?VEJpWjBtYzJvcFp6RDlQTWgzRHpzM25tRkRZdlFRVnBabWJJV1pPZUdJTkZo?=
 =?utf-8?B?c0ZhdUlWSFRJSEU0MENWVHdJdmxuVkxyeUdSMktWanJuQzl0eGh3WFRzSDB3?=
 =?utf-8?B?TldvRVk5MEV1bk9jSFVUdDV2WGtqU2lUeHhGd1RMQ2ZSTklKSnVObCtrVGl0?=
 =?utf-8?B?YXpBL3F6aE95SW9BcFdGQi9kbkpBZzZKUklaMFpzNDhMbVExcFd1WjFFTCtR?=
 =?utf-8?B?bEhlQUVKZGlnUFFpdnJHWnpkSmpvRytveXQySFV4S2Fkb1NvQXBTSVNtQklF?=
 =?utf-8?B?VXZlbGFHcWEzQUxUTk1vWlNOWmJJMUt4Rm9xZk1WUnowYXZpQTJyaytvWjNi?=
 =?utf-8?B?eUVOWGNrREdKdzVwWERBcmNlU2N6dGEwbG5YcU5vb1ZpLzZHN05zakdoY2pi?=
 =?utf-8?B?czZJdkFvS05nWmQ4bkhLRCs5cFIraTZJaUZ1NlhoZnY0MGwrOXJjVlUweUJj?=
 =?utf-8?B?QnM5d3hmM3NTSm1pNThURlUySjRibitZdXFVdW9id2xxSTIwNjluV1ZjRUw3?=
 =?utf-8?B?WnZnbXo1NkhGcXhtWk5Pc0Z3eWNFQjlsR290UTZ5ZVNhWU9xUXk5eUhaSWxm?=
 =?utf-8?B?WkhwL05JWFJOcFRuTWp1V21JbTdTZW1yaVk4ZzFncUg1UlpPeGs1NDdRUkZi?=
 =?utf-8?B?SC9mbUpLSDRyREFXRVYvWHJkZDc0c01WWlVEWFBhWkY3VWNqSjhwUFRPTk1X?=
 =?utf-8?B?WUp1YUNQb2NjYjF0U0VIelJDTkQyRkxSWWpmYllGM2R5MlBnOStjY1oraW8y?=
 =?utf-8?B?UVk1VU1mN3NtcFVDaWgyV3pWRVNMQ2pZYlZGLytVYmI0UFcvdWMvWGFkbTB1?=
 =?utf-8?B?eStVRFF0Umg4L2x4b0NhYW5UZVh1OWtoWVorcXllSlkwUmhweTlZd3pzNGNJ?=
 =?utf-8?B?aUtnY2pzZFBUKzhIVVpSTHVxcHFFVHlGalpGY3FaY0FUWElMeUhNdkduNHJz?=
 =?utf-8?B?R1gyMlV1Zi9QdGNOMG0zS1dWUVc3S3ZTM1B0R2ZOZHdtbnE3RFB2amwzNW05?=
 =?utf-8?B?cUh2bGZKNTNJa3ErdHJoUUdUdUh6TTdQOFplZU82d0hDejFNV0xuUTZicThw?=
 =?utf-8?B?VG9sQUhxS2NZNXZyODFML1laUS9KR1NHK2d2N0pZRno4Zi9JZzJSeWx3Yzkw?=
 =?utf-8?B?Vzl1YkwxaXArbkFrSFA1c3RKakdvRW9jVkpyZk5hV2YyRUU0RUJUUTQvbC9r?=
 =?utf-8?B?enFzUkJIMnVoN01vaXZnMCtMaXJSemFuMDl0cEZpd3RwaGRpdTlWVHRqcmVt?=
 =?utf-8?B?aDg1ZkZEQTRWYnhkeUhvNXora0FPbVBKRW5PT3g1WU9FYVJyUmVITkt6Yk10?=
 =?utf-8?B?d3RWOUttNjNUeFZjZ2RxclErazRhR01wcnB5eWsxTVROMjdLdktOQUtjZGRY?=
 =?utf-8?B?Z2w3SWxKMEYzeGJGdHdvU1EwS2xlUXNBbHBybUFyQ0dpV2JhckZOSGptWFJR?=
 =?utf-8?B?WHd1WkFZOVplUEZ4ZHlvNHYyMTlVdFlZd3lpbkRTVzU5VVgvSjBNbWNvT2lX?=
 =?utf-8?B?Q05hdUdlQkVFMVNxYkNHdm4zWUcxRUJNT0Y4ejdQWVlTcHVKci91YmsvZ0JG?=
 =?utf-8?B?M3VodURWeG1sdXoxTkVEQUtVcUMxaTlXY2x0V1M3ZWd5NG1hbW5tUnFZTDhj?=
 =?utf-8?B?WnNIK1k1eEVMWjV0anBWMER5dU0rbHkzaFNxYjhDTCtPS3BoTkFFTkZSNEdO?=
 =?utf-8?Q?vK5bKBYQJv5dKvuJajgI0oElw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d0a05dd-3914-47c3-bcc0-08dab590ff5f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 07:25:59.1978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yn7EDE3qrN5pUK7mylG6DeBST1ccRUs76JQR8CwsN8dY37YjsSfgZeMMB0TbhrkuHSJVJUfZrAd0UIb7tYg7Mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7325

On 22.10.2022 17:30, Julien Grall wrote:
> Is this intended for 4.17?

Well, yes, it was meant to be - it has been ...

> On 09/09/2022 15:30, Jan Beulich wrote:

... well over a month since it was sent.

>> --- a/xen/arch/x86/sysctl.c
>> +++ b/xen/arch/x86/sysctl.c
>> @@ -157,7 +157,7 @@ long arch_do_sysctl(
>>           long (*fn)(void *);
>>           void *hcpu;
>>   
>> -        switch ( op )
>> +        switch ( op | -(CONFIG_NR_CPUS == 1) )
> This code is quite confusing to read and potentially risky as you are 
> are relying the top bit of 'op' to never be 1. While I am expecting this 
> will ever be the case, this will be a "fun" issue to debug if this ever 
> happen. So I would suggest to check CONFIG_NR_CPUS == 1 separately.

You're aware that we use this pattern in a few other places already (I
guess in my local tree I have one or two which aren't upstream yet)? Just
grep for "switch[^_].*[|]" to see them. Also note that it's not just the
top bit of "op" - we merely assume "op" will never be ~0. Personally I
prefer this way of coding the logic, but if at least one of the other x86
maintainers agreed with you, I'd be okay to switch to using a separate
if().

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 08:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 08:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428766.679238 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omsdD-0007Fi-Bv; Mon, 24 Oct 2022 08:16:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428766.679238; Mon, 24 Oct 2022 08:16:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omsdD-0007Fb-8Q; Mon, 24 Oct 2022 08:16:23 +0000
Received: by outflank-mailman (input) for mailman id 428766;
 Mon, 24 Oct 2022 08:16:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tdD1=2Z=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1omsdB-0007FU-80
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 08:16:21 +0000
Received: from NAM04-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam04on2086.outbound.protection.outlook.com [40.107.101.86])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2224fe3f-5374-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 10:16:18 +0200 (CEST)
Received: from MW2PR16CA0054.namprd16.prod.outlook.com (2603:10b6:907:1::31)
 by DM6PR12MB4878.namprd12.prod.outlook.com (2603:10b6:5:1b8::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 08:16:13 +0000
Received: from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com
 (2603:10b6:907:1:cafe::53) by MW2PR16CA0054.outlook.office365.com
 (2603:10b6:907:1::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend
 Transport; Mon, 24 Oct 2022 08:16:13 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 08:16:13 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 03:16:12 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 24 Oct 2022 03:16:11 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2224fe3f-5374-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G80o2hPu6niqGTGO3njO6IHsIZWdMZ32XaqvtB1KFYSxCSTC0rFcbEFln5jmncc/I1MkI6dB7hujnwGIfcJTX7KA+gorwe+KG233/C84C7eklcRnPancYASXT7v/13Q+EVmSRFZL1gAeEwv+aDZWXgdaIljuVUSD1Yr1eqQZSuXAGKc8uWg8glAqNPpzEgvVRWPo+tUC6c0xZpEFuw3VWyP5evCgrjBOQBx1ao5BGD5p81mnLqVtEDB9TP6o6FmAKCdqMVI2uWr9qBXD24uZrCqQdbgTgrBfYX+bG9ICWp/cQeR84QQj8mW75HXFFZQ5Axx8+W8RGghVeEbJDDGGeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wk2Y9yK7WBt7KWOq90CCS2QxqN/YLUqoukI6Pqkb+Zw=;
 b=PMrrbix5ebyat1ICJGF9HdcdmmEVhVhzVkw1yxZXzgvUjYEL1fFOmQFFKiYxpOmbeYyURzQxSqDMPL8tbAKRturvc7fWSBWmht2//gHJUw5JI6jBn/iSR7m/OKOJX8g5CPcNdxUQKs/01q8AqIE+Fe+V6qg+r5Nmahluz/rsqN5FqzKnYNISZdj9X5j4p1JXy4bMJGuIyT10GUkVHlxkyPODvbeGCt7XSn+qCpDd0I9ZnIl380m40+WJo2X2Z52zHbtMm7aYcvZPtfHJIsNtud2dCd1lya2pzjbV8zgiwO4uXJd6pgEbZA93rfd5n0WODwy1VTXBXldgOyvvCb1EYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wk2Y9yK7WBt7KWOq90CCS2QxqN/YLUqoukI6Pqkb+Zw=;
 b=uA5VdeKT4h+AGFperhKtn4hQ8uqOGimrRSVkNxYGxWZuhta9HpWHiT27xxiP4HwdWkLCGIPnWjNiR2tTguIY/pSJ6bifD4Lv2TTb14KKEQ/RxaSqSyOnn3RZQyc6GzMMJ0h7ovNqr5yxjEORn5tJ/vGsNR7WLQr8eaFpFuApuVA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <b9da39df-8ec0-9255-1345-445f2a5b56e6@amd.com>
Date: Mon, 24 Oct 2022 10:16:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] automation: test.yaml: Introduce templates to reduce the
 overhead
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
CC: <xen-devel@lists.xenproject.org>, Doug Goldstein <cardoe@cardoe.com>
References: <20221019164246.5487-1-michal.orzel@amd.com>
 <alpine.DEB.2.22.394.2210211423560.3873@ubuntu-linux-20-04-desktop>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <alpine.DEB.2.22.394.2210211423560.3873@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT034:EE_|DM6PR12MB4878:EE_
X-MS-Office365-Filtering-Correlation-Id: d394ad75-6832-467b-ee06-08dab598041d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gye52XFDyajG8Ja21MMnjCKtwIPyDvmzExP2ZmCNttY6pbF5NF1E87l3VeMbWQR9hJIg7hwXACez71sZ4hT5Ru90a5aJmfQclajShJdw4VSIOM1TdCOLXnUqO8HuYS7DGaxtrkLB0UmkTk66i6DzRi8d+Jms5/U0giC1GHy+Jz7U4QzSSJqQ/UGoYbdz9NglV9ZOmMqeW/xVjpSRkRxjoTdEI2LM9sx2zBKN5pe2Mge1bSGZm4Rc5Yc4u4v3IrChKzP2XmNsC6IXm7QRotd8+BLvFLkRarqAeTqDE87fk38qDRgaH7QOrj1Ea0Gv1KGMiZYREMSWZjC4O2xhQ1l/ZZOQpHkS3OKbwqM3NFj6oFQ8SXfaVCPTnIm3U0zW8WhMslK6VaT9pG9Om8BMMXrDxp/z/N4FIVnEcP0pXVP0UIF2wiSuF+wTAlMezsFgio0LsciAJJ3Z+zGEtIm7fiasObcsxh+C55UO4k+IsQh+DFl381KZbc59KiAsTIDTo15OodlaYtPHN+wvXUYvD98CcN9vh68KCENdfScsKvk7Av9hq50KxhnIbsjSOaZG11KN6LRJTjjnKajbt5HJi3B2FQUi+hMDz2K29uDz74sKF+qbhZEpSNYm6fpcVfe4oxeQReVY+BRkQYdbjflkoKmSQ0pjlJHfnceAqqbt3rozGuRBji96OhIlsJcCFYYyDg99lbbFfvHV8Ckyh4fOEEOusejrwDfik4Tv2qPLrDDmNHo1v3NR6W/CCYWJeGpPCLpGMW4sl8hse3K4D8y6F6etREL5NQ35Ctx3y6IW0PtKnLVTBoOhJvDly3hYU7BipBkNVS6JYHd9JWyVYRzqz46ITuAY2MTjxiAUa28vPndRDLY8sPfQB2h8Kb22LfFgmK1sKse6iyi6Dcw32cKbFSDtVQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(966005)(86362001)(31696002)(45080400002)(83380400001)(31686004)(478600001)(426003)(70586007)(16576012)(70206006)(53546011)(54906003)(5660300002)(4326008)(36756003)(26005)(41300700001)(8936002)(6916009)(8676002)(336012)(47076005)(82310400005)(40460700003)(186003)(2616005)(2906002)(44832011)(36860700001)(316002)(356005)(81166007)(40480700001)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 08:16:13.3354
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d394ad75-6832-467b-ee06-08dab598041d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT034.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4878

Hi Stefano,

On 21/10/2022 23:42, Stefano Stabellini wrote:
> 
> 
> On Wed, 19 Oct 2022, Michal Orzel wrote:
>> At the moment, we define lots of test jobs in test.yaml, that make use
>> of the same configuration sections like variables, tags, artifacts.
>> Introduce templates (hidden jobs whose names start with a dot) to
>> reduce the overhead and simplify the file (more than 100 lines saved).
>> This way, the actual jobs can only specify sections that are unique
>> to them.
>>
>> Most of the test jobs specify the same set of prerequisite jobs under needs
>> property with just one additional being unique to the job itself. Introduce
>> YAML anchors for that purpose, because when using extends, the needs property
>> is not being merged (the parent property overwrites the child one).
> 
> I like the patch. Replying here on top because the diff below is not
> very helpful.
> 
> When you say that "extends" overwrites the properties, do you mean that
> "needs" in qemu-smoke-dom0-arm64-gcc overwrites "needs" in .qemu-arm64,
> when qemu-smoke-dom0-arm64-gcc includes .qemu-arm64?
Yes, exactly. The behavior depends on the property. For example, the variables
section is merged but needs end up being overwritten. This is because the extends
does not merge the keys (variables uses key: value, whereas needs does not).

> 
> 
> If there is no way to solve the overwrite problem then it is OK to use
> YAML achors but is it possible to define the anchors outside of
> .qemu-arm64/.qemu-arm32 ? It would make things a lot clearer in the
> code. Maybe under a top level "definitions" key? The point is that
> .qemu-arm64 and .qemu-arm32 should use the anchor rather than define the
> anchor.
It is possible to define anchors outside qemu-arm64/arm32. I decided to
define them in these jobs because for me it looked cleaner (less lines of code).
But I'm ok to carve them out if that is what you prefer. This would
require dropping the needs property from the extend jobs, as they cannot make use
of the anchors (overwrite issue), and using the anchors from real jobs (just like I did in this patch).
So we would have:

.arm64-test-needs: &arm64-test-needs
  - alpine-3.12-arm64-rootfs-export
  - kernel-5.19-arm64-export
  - qemu-system-aarch64-6.0.0-arm64-export

.qemu-arm64:
  extends: .test-jobs-common
  variables:
    CONTAINER: debian:unstable-arm64v8
    LOGFILE: qemu-smoke-arm64.log
  artifacts:
    paths:
      - smoke.serial
      - '*.log'
    when: always
  tags:
    - arm64

qemu-smoke-dom0-arm64-gcc:
  extends: .qemu-arm64
  script:
    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
  needs:
    - *arm64-test-needs
    - alpine-3.12-gcc-arm64


> 
> I wouldn't call it qemu-arm64-needs because it has things
> like alpine-3.12-arm64-rootfs-export and kernel-5.19-arm64-export that
> are not required by qemu-system-aarch64-6.0.0-arm64-export. If anything
> qemu-system-aarch64-6.0.0-arm64-export needs CONTAINER:
> debian:unstable-arm64v8.
> 
> So I would call the anchor something like "arm64-test-needs". Same
> comment for the arm32 anchor.
Ok, this naming sounds good to me.

> 
> 
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>> ---
>> This patch is based on the CI next branch where we already have several
>> patches (already acked) to be merged into staging after the release:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Ftree%2Fnext&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7Ca83af11b062b431b4f0908dab3ad2162%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638019853419768862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=TZxie442G%2Bm6SP%2FemyPuv8dwCDXAv1Wxwe22yGQZaB4%3D&amp;reserved=0
>>
>> Tested pipeline:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F671114820&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7Ca83af11b062b431b4f0908dab3ad2162%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638019853419768862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=tMwGAZUKyvDp%2BxmVdxUD1kg3uMagWdO2P1DjF5O3b2M%3D&amp;reserved=0
>> ---
>>  automation/gitlab-ci/test.yaml | 266 ++++++++++-----------------------
>>  1 file changed, 80 insertions(+), 186 deletions(-)
>>
>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
>> index 92e0a1f7c510..fc0884b12082 100644
>> --- a/automation/gitlab-ci/test.yaml
>> +++ b/automation/gitlab-ci/test.yaml
>> @@ -7,32 +7,12 @@
>>      - /^coverity-tested\/.*/
>>      - /^stable-.*/
>>
>> -# Test jobs
>> -build-each-commit-gcc:
>> -  extends: .test-jobs-common
>> -  variables:
>> -    CONTAINER: debian:stretch
>> -    XEN_TARGET_ARCH: x86_64
>> -    CC: gcc
>> -  script:
>> -    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
>> -    - mv ../build-each-commit-gcc.log .
>> -  artifacts:
>> -    paths:
>> -      - '*.log'
>> -    when: always
>> -  needs: []
>> -  tags:
>> -    - x86_64
>> -
>> -qemu-smoke-dom0-arm64-gcc:
>> +.qemu-arm64:
>>    extends: .test-jobs-common
>>    variables:
>>      CONTAINER: debian:unstable-arm64v8
>> -  script:
>> -    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
>> -  needs:
>> -    - alpine-3.12-gcc-arm64
>> +    LOGFILE: qemu-smoke-arm64.log
>> +  needs: &qemu-arm64-needs
>>      - alpine-3.12-arm64-rootfs-export
>>      - kernel-5.19-arm64-export
>>      - qemu-system-aarch64-6.0.0-arm64-export
> 
> LOGFILE should be listed among the artifacts (and maybe we can remove
> *.log if it has become redundant?)
*.log is not redundant because we have 4 logs to be stored, e.g.:
- smoke.serial
- config.log
- build.log
- qemu-smoke-arm64.log aka LOGFILE

So we can either have this:
artifacts:
  paths:
    - smoke.serial
    - '*.log'

or this:
artifacts:
  paths:
    - smoke.serial
    - ${LOGFILE}
    - '*.log'

I would prefer the former (just as it is now) but if you prefer the latter, it is ok.

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 09:07:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 09:07:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428771.679249 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtQw-00045Y-3O; Mon, 24 Oct 2022 09:07:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428771.679249; Mon, 24 Oct 2022 09:07:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtQw-00045R-0P; Mon, 24 Oct 2022 09:07:46 +0000
Received: by outflank-mailman (input) for mailman id 428771;
 Mon, 24 Oct 2022 09:07:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tdD1=2Z=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1omtQv-00045L-Ds
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 09:07:45 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2066.outbound.protection.outlook.com [40.107.220.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50ff264c-537b-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 11:07:43 +0200 (CEST)
Received: from DS7P222CA0002.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::30) by
 DM4PR12MB5167.namprd12.prod.outlook.com (2603:10b6:5:396::10) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.21; Mon, 24 Oct 2022 09:07:40 +0000
Received: from DM6NAM11FT096.eop-nam11.prod.protection.outlook.com
 (2603:10b6:8:2e:cafe::bc) by DS7P222CA0002.outlook.office365.com
 (2603:10b6:8:2e::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend
 Transport; Mon, 24 Oct 2022 09:07:40 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT096.mail.protection.outlook.com (10.13.173.145) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 09:07:39 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 04:07:39 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 02:07:38 -0700
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 24 Oct 2022 04:07:37 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50ff264c-537b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KmZOscGbt+jv7+pEHaJV3IbGvIHSYmTLIfQT23tLK3+gNDT1+wDUMfhXoKOdQTaRTzwLe20xNLH3EEVQGH6ZAZ+kA/bk8Tmsruv4nVql+Y1x7sBZJ81sKf/IveXGBaACkaBHvb1ZTc1Ylji+QPC1MfG36J/5/A1P4xhiM3mABc1GCxbIcmX5I6nMg8f1W5bqxIb6r0Q4yMTeXoTDduzQ24kTKQgivdWol13tlv9QwGBeLjzpQf3kx6sL+PowtyHwXHGdgYzpJno9ynjdeKVm4DhMJuJSYsc3Hlo4P6jh6zV8K17kIjTBSVXRCz0Oxz/iCOLedo2hpj6xorRot32spg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yccG669GhBoAImAUDk8VGKK0cfD0e+yrcyvnxEv50Dg=;
 b=WkRMBY1f7YPqbZQ/LddcjzcoDrHGBFqGKq/kIcZcKj6FP4Sy9bm90R5poKdF1A+cy54YyabIsEujEJX4Zd720JsRpwHPWfdVZ/K1kVU6lqgQQXMOLpvR2vQlBbhx9/wV3CSvI4SeVcAClp3iM8E1UTEr3Axh1fbUgwLqMVMRWHM/67HncNCOMe9dI8PFVGUQwXedKAb7uDIsaM8NMZKJieoDmPFT5AOgDajnCau7MQ3r3N0RDJjY6oWUH9nED34GILZI46zqsQvLGo6f++qwn2+WgoC1My9WJSBMTuDgwx0lJ65ieBJvGbXKV5g1PB0CnsWjJCXZrilLhhv/wnKEzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yccG669GhBoAImAUDk8VGKK0cfD0e+yrcyvnxEv50Dg=;
 b=XudA72pLwTb5BONcISPGQtumTnieTmTUsnNgYNC7mDULyL6GJKuxoWdKzjqbv5arEaJKQbj6mzRjJC2KpacW4W8w4RbJZZdg4eusQPPAyCl6vrdvxLNoMfu3TpnrYKnAlIhnAUopDavEnYF4PD6ipRyDd5CapFaYqXhamdbU6iI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
Date: Mon, 24 Oct 2022 11:07:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
Subject: Deadcode discussion based on Arm NS phys timer
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT096:EE_|DM4PR12MB5167:EE_
X-MS-Office365-Filtering-Correlation-Id: c24b9fc0-f9ec-4b53-6071-08dab59f33c2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AbU228Xwl0Usw1ZCnJqyjFdbpAUEUkLU4coe6POShLESrXJSQmwP0/yfua78HEMLecjgtScQ0jhsa4BsM3WOlF6GQjzbuIbthi7SF+W1QUFT76ZQehCAHW55dvss7qc+3WCaIxpgdrCkvEIkvoFUpZH/0tBWr1WyBOV3jsN/C5EVEjMMobYS7bJbbJxcigclwnJwxmZnqK6qBnsBn/bsIltYJKR1842Zy58LyV3ScdyvK4NGLccxNq/g1DilQO2lspkYEQSQ8NAdyOJtttbXEz4rqaApYj/+R3fF9k7IdlCqLjc/w/AFchvc9M43QksOgyqBZtsz3RZBiRxABc4Q7huKI6eV72Dmb5WZ5YJ2IUrqFPLBIqY4UU2hXICJKTd/8aeYDZkpFO88MWAJeDYyRGO4exsvqD3GByOyyReFkQIEXYboBX9SRVUgOCj8ae6tXCNavRXSHQjLlG2UrjC/OrKlu4fi9nAgKLmH+CHbfWblLXwfG3+36188zJnsivPV598U/JSYnvjco/suoTO9qukwr9UKfrfnsuzahl5UQSaoplL5RPr4ciSyLupYRWQ1+LeLiNu45rfzhVAO0aTZXiJxDlUhnfmGlQcTMxsu/f528v4nJuALVWYIRwjpqWmTLVardSZqpGOEVWu+Sb2H+y27sxTKWqa4aPGhuu9YhAupbjDBXqv36wcaOc28K3CJrjSxXnqf56y7Jb5qiocNPZCqUVQtl+4gwyFwKuPHQez/flqrSH50a3SvxO+5GwfWQmuA6pR9JUQcuJvp3tugzqYwJhU4k/EK4iWLQ/r5+6bvhbCtlFDbrH5F1XTdxPX/LJRt2ajLS6FuGuz9gPW6kA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(40470700004)(36840700001)(46966006)(8936002)(16576012)(316002)(54906003)(36860700001)(426003)(6916009)(47076005)(40480700001)(70206006)(2616005)(186003)(2906002)(5660300002)(44832011)(8676002)(4326008)(40460700003)(336012)(70586007)(86362001)(31696002)(83380400001)(36756003)(26005)(41300700001)(478600001)(82740400003)(81166007)(66899015)(82310400005)(31686004)(356005)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 09:07:39.8525
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c24b9fc0-f9ec-4b53-6071-08dab59f33c2
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT096.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5167

Hello,

Recently I came across a deadcode in Xen Arm arch timer code. Briefly speaking, we are routing
the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use of it (as it uses the hypervisor timer CNTHP).
This timer is fully emulated, which means that there is nothing that can trigger such IRQ. This code is
a left over from early days, where the CNTHP was buggy on some models and we had to use the CNTP instead.

As far as the problem itself is not really interesting, it raises a question of what to do with a deadcode,
as there might be/are other deadcode places in Xen. One may say that it is useful to keep it, because one day,
someone might need it when dealing with yet another broken HW. Such person would still need to modify the other
part of the code (e.g. reprogram_timer), but there would be less work required overall. Personally, I'm not in favor of
such approach, because we should not really support possible scenarios with broken HW (except for erratas listing known issues).
Also, as part of the certification/FUSA process, there should be no deadcode and we should have explanation for every block of code.

There are different ways to deal with a deadcode:
1. Get rid of it completely
2. Leave it as it is
3. Admit that it can be useful one day and:
  3.1. protect it with #if 0
  3.2. protect it with a new Kconfig option (disabled by default) using #ifdef
  3.3. protect it with a new Kconfig option (disabled by default) using IS_ENABLED (to make sure code always compile)
  3.4. protect it with a command line option (allowing to choose the timer to be used by Xen)
...

Let me know what you think.

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 09:15:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 09:15:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428777.679259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtYi-0005bE-VF; Mon, 24 Oct 2022 09:15:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428777.679259; Mon, 24 Oct 2022 09:15:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtYi-0005b7-Sb; Mon, 24 Oct 2022 09:15:48 +0000
Received: by outflank-mailman (input) for mailman id 428777;
 Mon, 24 Oct 2022 09:15:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1omtYi-0005b1-8Y
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 09:15:48 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 70a719e3-537c-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 11:15:46 +0200 (CEST)
Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 05:15:20 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA1PR03MB6497.namprd03.prod.outlook.com (2603:10b6:806:1c4::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 09:15:18 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.027; Mon, 24 Oct 2022
 09:15:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70a719e3-537c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666602946;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=f4CL+ZSG6e/fVrBBWOzcAwZ1/nz14wSE5gXp0QWqDlM=;
  b=QU9foz1pmCjhT5q1UHBnkRT4TeeK/dvgu4CGLIRZhtexDgxpR5hW1C7V
   OOdCgVvEZmfN9yDt4yhv0PTppb3gPZJhKV3AMHDAg0MOEaNWgzOpaZzoe
   Vy7S/4A/PP6RlYMDsJ8QvZaZeX9FBpADbpHajbv2z2UiTUeNJ/eI2a4MF
   M=;
X-IronPort-RemoteIP: 104.47.70.105
X-IronPort-MID: 82460059
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:4hCEZKNovd7QtevvrR2/lsFynXyQoLVcMsEvi/4bfWQNrUpxgjAPz
 2MbW26Db/aCa2H1ct50btvi8k4BuZaBnYBgQAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo42tC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eZ6sE8fR6Wnt15
 ds2MDRXbkDZ3MGz6efuIgVsrpxLwMjDGqo64ykl5xeGSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsH8BTM/fdfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPk2bbqirx14cjmwvYYIwZHuGo6sdLw2ezwHA2NTw8aHyS9KzRZkmWHog3x
 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv
 neWm/v5CDopt6eaIU9x7Z+RpDK2fCITcmkLYHZcSRNfuoG+5oYukhjIU9BvVravicH4Ei3xx
 DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr7hu+lTOZJv7CV1GU=
IronPort-HdrOrdr: A9a23:c9eIwK+Uz/SJnxCZisVuk+FDdb1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe
 ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d
 FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp
 T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK
 g=
X-IronPort-AV: E=Sophos;i="5.95,207,1661832000"; 
   d="scan'208";a="82460059"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ArVaPxWpqPb9SFArRn6rpsgenIDAwx6ATNSAcqtHjMI56GaKwbgwYnysQz8o3aqhaXwHji6uClbwtGVe/rQ2ap1UEWG4/lP2Kf+QcNfOX7GUbnAg05HqeOZnsOp2OnYrPBCuKsohYp66lC2ZP6xAbSf6yO6u8zHMPGHccJewPfb4kR76WSFbwklDEaoGBSDKX675u5sMDrHJAQY7zJxfLEX17OP/oGb5WIxJ2IB8njaGVMCoTgSL62CbUe49vP8HNbGUDEEyHwJAQh66jtzsUkxuHBwpj85dAo3dicSwDrfZHG5NttPH2FtxsXIZzaGArC0ISPWkzTTLXXk5gjX0uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K5+1lkwkbKm2lGolHyPNAs6iJWgMx/TbQAUcDeuqN1A=;
 b=guUKlhrB0IGkotBWZgl+a3YY+bwsiP++b5d9U/j6EFvuOZtxEStdHEgYQx9wYR3mzm7GlDxwxQtTpTysOh7jcoiWUxSFQ8GSKRxVD4GI0tB/bPqJs0KGOE6N5O6mzyTVD6lE77XjlY0RL9EJ+ZpoSa1HFGG+MsAhOIeD8jJR3XnL9eBqJnYuosBktCce/YWcrb/wtY3dAZhNB3b8bNNcb5fyZE3cnZakACFWHYmiZM4HzJ9RNA8BPmLtEO3QxUzXFxLYfAIZ59xf9ydYc5BdLlw/WTr8WlF5mrYbHb/VIh7ZgOx41kmF9SzAyGPTbFET9SzuB7APdLfQ0CermSn9gQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K5+1lkwkbKm2lGolHyPNAs6iJWgMx/TbQAUcDeuqN1A=;
 b=Jb2TfJ8+jYTW/zPtc/ONzVdtY4pjZdFfIqq5vCifd4c4sLe1VQjIIp3YCKrZ2pWkj3u6qlxWv9H8Zp2VtcWWQSBAwGtz6dcSH2xt9xPbLH5zBBmVJGWvCD7w8F0ApiEAAjidRk9OuzQZz22Q8CFUTtjcBoHPWCcNKe21iWTICpQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 11:15:13 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Henry.Wang@arm.com" <Henry.Wang@arm.com>, Wei Liu <wl@xen.org>,
	Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH for-4.17?] test/vpci: enable by default
Message-ID: <Y1ZXoRkvgKxiMdZI@Air-de-Roger>
References: <20221020102706.29267-1-roger.pau@citrix.com>
 <ba118539-4c07-d03a-9b52-a7a45e3d16f0@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ba118539-4c07-d03a-9b52-a7a45e3d16f0@citrix.com>
X-ClientProxiedBy: LO4P123CA0157.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6497:EE_
X-MS-Office365-Filtering-Correlation-Id: 318fc172-df68-4d56-d9ab-08dab5a044e4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NP97yuKHG9xvxpG6LrXbcTxohgaKM9RovACalUmRPJgsWtbphkl4tEYUpui4xvDTmnpM8UQNGYG641TUEuXUKVP82ztd9DvpWH4FmoyC2G5mKvJ1Eu0/AyUHX/Iq3VtqHZWe3w8KpsprIlENb8yDZzUUKlK/DgedOtL1to7qXgAifI4OBTKa0SnrrkGz/iEovIWO6utk+IwFlkYUzEkjtIPAvxptHEoNCZHr6d7s7a+qYmrxg/qhUj4/sueojhX2Wm8zbdnXlWt+N/1WrbLSEwGv3VvQheMM31jT+zghmAJ8+kUfRgrStlTty5m5K3HRjGjynu+64HCVlal+XKZxVdZB6c14iVEQ4C35bsVmy3cnvl+PzjNX9uYKw7WGtHeVrcAe7JAFDaOQVbk1+bWReDg5yRq9jSvR8KgXnfel2abzKFx3XQZrQJ9DBf5qmTtGvcnCj7wkHSd51TC6VWsRb/xQfzR0xX4lMFlcmQ5Ham0C/aW6/GCl5vhhHeJw5LAHvefq3v54BwMLZHhZaKPKXh5uCUSZU1AmF79DDrLwnXqynghBrEKIJkUxAPV8oodNv8q3+ymfOu5748JZJO8VmKkOGea9wZ8X36/VZPHK0GTV74Fdk75y9ZlRgKy51BHXR47nVul8Jr3zSFQQJiN8EbqesYhJLNDMmwB4CcaKOFfyeSGwKbOKXFG2Zox4K4axMgXhCIFslKFE5mTrMlGgZQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(346002)(366004)(136003)(39860400002)(376002)(451199015)(2906002)(5660300002)(9686003)(6862004)(6512007)(26005)(41300700001)(186003)(8936002)(33716001)(38100700002)(82960400001)(86362001)(83380400001)(85182001)(54906003)(6636002)(316002)(478600001)(6486002)(53546011)(107886003)(6666004)(8676002)(6506007)(66946007)(4326008)(66556008)(66476007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3BmR05LcG9idlBHMTJNcjYxOW5VY0pFYmo3ZDNyMi9pc3phTEg1cmZvMzJp?=
 =?utf-8?B?R2pqNmhJYVo1dUtHamhkcGpqV3RCNkZIaVRVMDR6bStZRmRhZGdiY1NDMS9C?=
 =?utf-8?B?RGp1aGpOeExkekFQdG1KaHNjZUd2cGtxTVI4R0M2UUhocFVEVWMrYlhmRzJG?=
 =?utf-8?B?S25obldXL2Z5b09lSGVvWllxUG11WHU0Q1JkKzlOREtSa0lVdkpObXlLL1pJ?=
 =?utf-8?B?bEJ2YzFpMG5Hd2FYUkFSSld5cDFFSW9JelRwRTd4YjJUUy9qVC90OFMyM1Qy?=
 =?utf-8?B?YTFZSUpML3hXcTlQWWgyck5IRUdVQ2QzWHpDTzJST2I3QkN4SjZhb29PbHpI?=
 =?utf-8?B?ZmlDTm5JVHJKd2N5R2ZVZUVCTEZ3cHorR1VkZXB0NXU0UnJEdzlMeVRSNFlB?=
 =?utf-8?B?OGlMSGh2aGJPVU5FVlIyV3ArQkFkQVNQQjNzTWxhbW9yek9DY1JFc2RsWUE0?=
 =?utf-8?B?T2hET3BhWVNST1FNYWFTdFhMYzV3MXptWld0aXdwdGRuT25OZ2NURDZjUzZ2?=
 =?utf-8?B?bDBUWFY3aGxvZXVmdzdISGdGeEVtVENYT2dNYk1kbitUZzd4SVFlQ1FnNHFz?=
 =?utf-8?B?WitrdUlWOGV1Y1VQOUZCdC96Y1A3TWpzZm9wUkpibHh0cHh2NGl1eE9HZmZs?=
 =?utf-8?B?eTdMWjZFam82bWd2VGpZRlVvOUw2bWJnWlg3U2laMjRyQ040b0dUZk12SmVr?=
 =?utf-8?B?QmRMZnZ1ME5QMWk0S2NUSEs3UFZoSEEyVFRZOXpCMldMN1hHNWJwT05jTEVR?=
 =?utf-8?B?LzY5ejNmd0VrSFp1aWtTclczR015VmdGd0RCeDRGR3Z0YnpnNWNBM3RQRTNt?=
 =?utf-8?B?VnBVaFNOQjMyTVNVM0hMeVdIR1laR0NVdCtxYmNvZ3pLVXFiQy9hRm1zV0Rv?=
 =?utf-8?B?eVFTZUhsUFNLa1JxSHAwdkxOWDRiUGFWMFZDeHF0cEUyMzV4b3lkcVBwZW85?=
 =?utf-8?B?U1FKN1RsV25qYW4zMC91QnhCWGt0TUlVQThmUWVVV2tDbmZNUmZtMysrNUUx?=
 =?utf-8?B?QnlJOGJ4V0hlLy9yekRicFRKNnRUOWZETjNGa3RSTUZ4ZTB2bFU2V1NCdW96?=
 =?utf-8?B?T2VuRFA0RnFlSTRJWkUwMHlZZGRxSDR1MzRrOVRKdjNPaGhZY0oyUmdIVDh1?=
 =?utf-8?B?Q2RDSXNBMUdlODRqQWhRazBXL0xJbkZua29UNWppdWxGTVhRdGkwS2Q4TGNR?=
 =?utf-8?B?Q3A1QWFjdGtxdlpnMVhRbjhndWNEZUtaeXpsYThtOGRYekp4Q01Ud2dOam9z?=
 =?utf-8?B?cUR3U3o4ZXpIenkrdTcwZGpyRmJJbkx4THROZnhRUUFiVnEwOHZyNjAySHJj?=
 =?utf-8?B?c2drR3NGQmhCdzBFMDVVVFdpTEZLMVJoS1E1MFY4REN3bHhFUTQza1JITHlH?=
 =?utf-8?B?UW9mRGE2YVBERkg1dFVNMHdtcEZzS3ZIMjNKeXIrZlB6anhITHpYU0w3N0pE?=
 =?utf-8?B?dlZMK3FoQno3WUo3YnBwMTBPeENBeENKRkZoay9ld0RjZ3VaNXo2R1diNHo5?=
 =?utf-8?B?MzkzVG1FTVBhODNaUDNXa0t1Z0kyRnJickNDMWdpbmRUb3dRWXBKWmV0d1c3?=
 =?utf-8?B?YmRqQit0b3JpejNjbnVpTWp3OWVTbkVidTI2NktDTitKVnlWRFdoUithMmFE?=
 =?utf-8?B?OVpYemVTZ1RVNUlFL2xUV1FxMEpSWFQ4UDFzaE1ub2VRZXFvaHRLZnZ2ZWNq?=
 =?utf-8?B?cVhKVlJmbkFmSzNBUWpDUXhzYnhnaWFQUnpLY0cvY1JoOWNLZGtTWXRlTUtt?=
 =?utf-8?B?RE8rNDNlQUlMYnpMNDNTQWhYQlZ1a2dUUENKQjlsN1BxcUJ1blVodlRLYlZv?=
 =?utf-8?B?UjVRdXNDTkJoRDFxNGl6VXU3VkNOcHlOU0IwY1pobWhWaXFMVnBJdWFEYlNq?=
 =?utf-8?B?SHpaajFlWU1pcUJScVl5Y2dtOUQ5R1B3SSt1UEhTWXlJczdZMks3WVNkbjQz?=
 =?utf-8?B?ZlZHZXFWMmwwWXNkcVJUMGpDNlZtMEQ3dFdhZFAvaVRIbmhCRE9iNmUwNis2?=
 =?utf-8?B?RENSQXJSSktHRHBrL0xETXVhK3l0eFp5SlFKVWo2aXRYL0hxU3cwUVZXRDhB?=
 =?utf-8?B?akRaUXJPY1hwT3hDZENRZzVldmcxTHRxcWNFRGRDR3k3Mmxub3NlT0NnUWhz?=
 =?utf-8?Q?4hJqJW//9Ld4v7U2VjU/08Amj?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 318fc172-df68-4d56-d9ab-08dab5a044e4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 09:15:18.4401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N/e94yxhJuG2nkUpZWUZV6Uy+UCOSRoGhKA5++Ordk2SHe8VedTY4BGV5NfJXtkRDuPgqY9Pf4EqiONq6S0AQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6497

On Fri, Oct 21, 2022 at 07:01:01PM +0000, Andrew Cooper wrote:
> On 20/10/2022 11:27, Roger Pau Monne wrote:
> > CONFIG_HAS_PCI is not defined for the tools build, and as a result the
> > vpci harness would never get build.  Fix this by building it
> > unconditionally, there's nothing arch specific in it.
> >
> > Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > While not strictly a bugfix, I think it's worth adding this change to the
> > release in order to always build the vpci test hardness and prevent it
> > from bitrotting.
> > ---
> >  tools/tests/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/tests/Makefile b/tools/tests/Makefile
> > index 33e32730c4..d99146d56a 100644
> > --- a/tools/tests/Makefile
> > +++ b/tools/tests/Makefile
> > @@ -10,7 +10,7 @@ SUBDIRS-$(CONFIG_X86) += x86_emulator
> >  endif
> >  SUBDIRS-y += xenstore
> >  SUBDIRS-y += depriv
> > -SUBDIRS-$(CONFIG_HAS_PCI) += vpci
> > +SUBDIRS-y += vpci
> 
> I'm afraid this is only half the fix.  The other half is:
> 
> diff --git a/tools/tests/vpci/Makefile b/tools/tests/vpci/Makefile
> index 5075bc2be28c..336904958f6a 100644
> --- a/tools/tests/vpci/Makefile
> +++ b/tools/tests/vpci/Makefile
> @@ -22,6 +22,8 @@ distclean: clean
>  
>  .PHONY: install
>  install:
> +       $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> +       $(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)
>  
>  vpci.c: $(XEN_ROOT)/xen/drivers/vpci/vpci.c
>         # Remove includes and add the test harness header
> 
> so it can actually get deployed somewhere useful.

For now I just wanted to get it to be built by default.  It wasn't
clear to me we want this installed, as it's a standalone unit test
that could be executed as part of the build phase (doesn't require
interaction with any hypercalls).

It's also currently built using HOSTCC, so installing on the target
would be wrong for cross-builds.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 09:33:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 09:33:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428784.679277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtpW-00082e-G6; Mon, 24 Oct 2022 09:33:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428784.679277; Mon, 24 Oct 2022 09:33:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtpW-00082X-D8; Mon, 24 Oct 2022 09:33:10 +0000
Received: by outflank-mailman (input) for mailman id 428784;
 Mon, 24 Oct 2022 09:33:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1omtpV-00081x-3Z
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 09:33:09 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dcfb55fa-537e-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 11:33:07 +0200 (CEST)
Received: from mail-mw2nam04lp2168.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 05:33:04 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6171.namprd03.prod.outlook.com (2603:10b6:408:100::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Mon, 24 Oct
 2022 09:33:02 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.027; Mon, 24 Oct 2022
 09:33:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcfb55fa-537e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666603987;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=o3PxMiKk8fGLdyp/6PCXW4K8zFXNKLvzCqDIn116cpU=;
  b=GLUONP40E/qZvDxpC6g4ed+9k2WzShzAWkUTvY+o+xNiEC+Cq50ctl4o
   tt/bdSk1V7BiPPMkvj7/1N91jETKWEWDAuf2r5l9wqe6LAd0k6G0h2dwg
   3khygy5kCMzg0I8oVi3Z+sCgEBjR+vhpbLIjxZ6qMk/1xw2rzYZ0LB6V0
   o=;
X-IronPort-RemoteIP: 104.47.73.168
X-IronPort-MID: 82460870
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:U9lT2a8AOl1ib/JdsSvIDrUDl3+TJUtcMsCJ2f8bNWPcYEJGY0x3n
 GNNWj+HPKreY2WkedskPo/gpkJQvZGBy9QwGVc4+S08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5AdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sJ6JWpBr
 M4BFG0EYC+tpuOZ5baGWtA506zPLOGzVG8ekldJ6GmFSNMZG9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxujaDpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toijw2LefwnuTtIQ6OLi++99n3Xiv/E8+MQAUcnGnmammlRvrMz5YA
 wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9+4FHhRqubyRDHeCrLGdqGvuPTBPdDFSIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w
 HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCQJuLpzm07hl6Y0z4=
IronPort-HdrOrdr: A9a23:uiEoBaoJkTmQgKZueQ6Vh8kaV5uwL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM
 Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/
 Gnl7d6TnebCAIqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP8f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aiSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7svVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wU9HdwGOtt5Dt
 //Q9RVfYF1P7ErhJ1GdZY8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d
 /8bG8=
X-IronPort-AV: E=Sophos;i="5.95,207,1661832000"; 
   d="scan'208";a="82460870"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ac72fGv6sjVJdLMe31238WmUa/2TRmRJp8jhFqNMoPaS9fKiu/ooCKxvguPDZANX/9OTn8oRrDq74GqGBVlPGnE/Z1h14sFV0VEZhyY8PoB24Ai0HpSR0jdlqNGfF9f4DH3F9LHYqEVQlwZkm5a3dqVV9VETIjETkNBBaksKNKAxd5dGFVleWWt9K00XX8XAp60jnPKY/ecVYce/SohwHMu9VShQQFOcDce+JkJ/ZuYT4adlIJgrfsBCITsADNeIGpvcAhVV17Vy4COOfAKzzw2a3PvgDgm9aB2TlSrpDJqJSRfZ+IZzqfkt8DW7nemWkhzZf7WoIBkSVfG8tO/3SA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=num82eOTp+aDlWsSmX4EjOt+inGJTQzuvs3yD3MMkec=;
 b=SFIKTEC8j5oaCFKlITjXR4r6p2ZmaCwctuxtC0qIGPOetf+AQExyrzCW9Sc86TBJ7JFP9ujtABkpG3ur6yVFNJ0na3BQe1Z2aUlKyeHl9keRwQ5dMPDZYDL/7eiBuq4uyM6qsj0anX4aj3m8wS3vtC7vVXIW2GZP5WWDAwhjZ2Dv07hEzB/kHA+wsWv82nqazhyQvrx8mOgzH03uTT06/AVDuqlXrxA+BQAclrTMWkDMP127uZLrHxgwznDP0CeYuR/1ratzbbnuh6xtDvqFQ1i49LL8V7eqrMXaIp69EUQcK6lf0CIdGOQV+LjoFcccI5XX3bTi+q7KTuqK1fl+SQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=num82eOTp+aDlWsSmX4EjOt+inGJTQzuvs3yD3MMkec=;
 b=qtBnhoKJjOB1vRKkFw7tpuS66jJVZYcN7jFc3DVoIFitO77UX95mIzy4gJV4JaJHyqPoxfBjbtx+JiRUnB4tEN5+YkHeobpI5imPj9Ljcf60WfjPBsXPr4qfB0jF7i6OUMMU6BG5Y5SmgzhQG3vnn5yT9YXdID4Dr/4l/OPslbw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 11:32:56 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Intended behavior/usage of SSBD setting
Message-ID: <Y1ZbyK3ynB0WYS3s@Air-de-Roger>
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
 <8c7de7ed-6242-f444-55fc-9eb16084b7bf@citrix.com>
 <435610e2-4fc4-6a9c-3fcc-c6d6ab42cdc1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <435610e2-4fc4-6a9c-3fcc-c6d6ab42cdc1@suse.com>
X-ClientProxiedBy: LO4P123CA0520.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6171:EE_
X-MS-Office365-Filtering-Correlation-Id: db771a87-f826-430c-6023-08dab5a2bed9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UDmn17LVCzY0Oa+bf7s3F2rIS9laNb1C2eiOXNTJ3IRipmKKnRPL7VE54t6MJO9PPYYhTmQPknTZO9F1DelSbOoB/dfI1mJKMT0ukkq++4zMur+/wZjmqPKmHUvhCup62ZUCGmd84lfS+0YhSQIgZ99TQYjUsNRneKGC+NHs0crpLjeO9c41uAJq1hQxJQV4rRQYQgGXdLqIB0WqVOVnFaRAtYr8oAccHAfCKCwy+VYIUqn96Hq8vyXKrCNZ0vfVEoBnmrUXpuW3zLHs9m7t0E6JMgpTk+G33w8nKFzzrMlB3bfeQR09bxd8xEQ5l5WxukWxGosn1mrpZaekFRDmqyNb2DVsRbwW/7iwb/Fw1EYK/yvq2ngtla8L1L/XKS6VSJmVFmjRxskwNbo/oyII3R501UN9RpZlq/ZFz4mf3tPSGPyT6RWmR+JCP3hTzSsNv4iJNiyqFCkzVgHDT9NiBHKGvCNgQhuzbDARDXB6tgXtr8dn6P0Ja+3Nr5GXMR/xaG7CnT88IQwwpWxWW1aVeYD/dmAFjunUwcaa2SPUYiAOLePrmx+KVzSlR6Ql6sXhFeB15WpJnteuUfmIDK1YHbXNO6g3PbKHkQiauRj2GTLw1WpyVCgJOzrMH4vMfxNrGJ2QE4LDZPoEyOnYueBvkv/oVP9r3tmhvFXqxKJ4Sr9DmwtZuiGgZs2V+egEIJB7ile9aN4wnR1qJ55cgivIVRLSE1Dj/jAQZ0hMcpgDySse6cGOk7dVO1Ofh1YhcnY6
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199015)(33716001)(2906002)(85182001)(66899015)(66946007)(66556008)(66476007)(5660300002)(966005)(6666004)(82960400001)(316002)(38100700002)(8676002)(8936002)(41300700001)(4326008)(110136005)(6636002)(86362001)(6486002)(6512007)(26005)(9686003)(186003)(478600001)(83380400001)(6506007)(53546011);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDViSDN0bThMNW5mQWlReHpOOWlRTUUzVDBZNVo1ZDdQUG4vUUhoU24rM0o4?=
 =?utf-8?B?ZHJYVDVpZGo5aWpzM01JNFdRQ1JHc25JSWpnRkMyMkRSdWhucVQ5MjA3c0RJ?=
 =?utf-8?B?enBJRFpiaWN4V200eWU2S0JlYitGUE9mSU9tcEZpNFIvclI4ejhIRXZzWDIv?=
 =?utf-8?B?bmdXR0p2a2JtQ01NUXFmUnhUaUwvSGdQMklJTEkzQlVuZmtGWExXRHBiUURQ?=
 =?utf-8?B?RFp0MTZ6NlhaZS9JMi9vVVp3a2RQdkViM1hkWm5iMTNyTHFwbnl3N2hyTHd3?=
 =?utf-8?B?NXNLMlZHVEdnd2dwZm9SNG5JeSsrNXlxY0RTZjA0dHJRYkwra1JzN3ZJY3Zo?=
 =?utf-8?B?dnAzZi9ZNHNCNmxPMzg3Z0NGYjJOZ0dGU09vcTRQbzIyUVFWVS83RUNYL293?=
 =?utf-8?B?YWNXZEo3dFRtZGNVMzBBYkx1NHlFRXozUTFQb0RUMEMvc3lxeEtqeTVySk1L?=
 =?utf-8?B?emdDRU51N1NZTERPbThCZmx6M3dENzRQdWIvdU0zeTNSWlIzb2NrZU1TcUl6?=
 =?utf-8?B?b1BoakJpZzlaNDFtY1J0QnIrZGRwaWJ2UVRCQlljWnF0dUtYbGRmeVVjQ0RH?=
 =?utf-8?B?RmhJdTIvMk1xbXlCLzN4L1hDaUhrNkc3V2xPYnhRNmN0ZSsydElKLzhzbUlw?=
 =?utf-8?B?MTQ2aVhlcm1WcFp6NmJTa1UyUVFRV2kzdHd5WDdiUDY5VmFWTTZPYzBzdU5a?=
 =?utf-8?B?SHdtTThNbGdlWXBMdStGZGNnWXhhRTUwZzYySnJxdFp4eVpiR2V2eHRDclZX?=
 =?utf-8?B?SmdaV0NTbEo3bzFLNVA5QnlJQ3FIZXR0REVuRUlBWUwwTnE5VjkzYUJ4dUJT?=
 =?utf-8?B?NUpRL2VTZ215THNvNHlnNVMxeFN3anptUjVxaVZSQ1Y2eDRyVDIxZWxrRlYw?=
 =?utf-8?B?YitkSFY3RkozZVRDRlpSUlBjaHMvRU9ydW5YbmtlUnhXV0xzZmNDSklDRkFu?=
 =?utf-8?B?YWN4OTAva28zbEZ0VzhzTnNhOUVOZDVCcUtQZnBKQm1lZS9JdW5TR2lDYys4?=
 =?utf-8?B?UzFKOU1oK1hsL0dGK21nZGwrZW5KUHhNL09tT2I5NkZNYjZnNEVpcWJHeUti?=
 =?utf-8?B?TThnYU8velJaeXpMQ2p5Mm54WmtwbDhBVU9Nc25uTFNxTVdXV0FkZ2pYdy9y?=
 =?utf-8?B?Y0Q5L1lYNDVLdGRhaHdCbjJzK2NFS09rRzIzQW5rKzNYWXRReFo5ZnV4U0dp?=
 =?utf-8?B?Zm82ZSszeW9tb2xUV1hyYmJUVHBYNkFaVmZ3VE9Ka2o0TDdPOUdNNTd6dS9k?=
 =?utf-8?B?Y2J0QWxTVC96Y0NkNmxveFMweU82UDVHTC9SUmhxTm5VaDVsQXBadDlZcFp2?=
 =?utf-8?B?TmxzanBQaUtkcmFQTjZCdHdhMjFVbXZpaGVzZ2ZSOVByVFF6QmNabUM5Zlcx?=
 =?utf-8?B?cGhxcWhXTXhnYk5CaFpCUGhHNVFlM1QwNDViS2htNGlvUmJiNEFmbzZHL0Rq?=
 =?utf-8?B?MEY3bFVGVENRQ2dUYVNCMEk5TGhtOTdDeXJSUVZDdzRtdllQdjAzZ1lJS3l6?=
 =?utf-8?B?TVl4bGdsL3dsMEJpMXRKOThJV0F2cC9EYXZIamNzODU0c0pHT25qdkkvdlhJ?=
 =?utf-8?B?WEN6T1pWMDF3NjdlMzhjOTFMbFd3dGdEeUk4Q1V3NkFHa0psdFpheDJzVjBK?=
 =?utf-8?B?dVlaQnZSNGloZzVVTGJZY3FYYWVPUXR3aEx1MTBjVjJXTmdFWUZmcGlqMXF0?=
 =?utf-8?B?R0RVaHlZZ3RKZnVCYTVXU3FaREpyRnZQOVRRRmdRaXpuQzBpOWw4YnovZUMv?=
 =?utf-8?B?WThjU0llZTc3cEVuT3V3bGNEUEMwQ0pydzh1OTZ5MFNYdTU5cFY3S1Bobkdr?=
 =?utf-8?B?c0p1YU9WU3RkM25zQUowU2tKTkNTeGYrdm53MDVsc3Z5THNmTXU4L080SWVn?=
 =?utf-8?B?ZGNCbVdMU2xJeWVwMVlmdURLUGVMaE4yR0Z6Skl2MmZRaTF3ZXV6NlpZRVJ1?=
 =?utf-8?B?RmJDb0VoWlZTRzllelhZTVAzc09PRldqUXZ1ZmpuWmNYS01DVE8rNWRwR3B6?=
 =?utf-8?B?L1EzcTRab1VIUnp2c2VGSGEybWsycmxtK2lKTkU3alRoQkM4ZmlyNm1reThr?=
 =?utf-8?B?cVVCTnVlS2NpTVBUUTkrd1hRM0thelhYd3Vod2xMRENLNGlZMG0yTmtzOW9a?=
 =?utf-8?Q?xmuI5yCLx4XTpVctcOBan7sYX?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db771a87-f826-430c-6023-08dab5a2bed9
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 09:33:02.0561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CFJQWM0kMpDY7JxSjMZKW0ufcE+FMIyvC6DDnvMgtuKtB2+9/64E32jzx+xSYySt8DC+7/aIKcyWg3y/RIX95w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6171

On Mon, Oct 24, 2022 at 08:45:07AM +0200, Jan Beulich wrote:
> On 21.10.2022 23:54, Andrew Cooper wrote:
> > On 20/10/2022 12:01, Roger Pau Monné wrote:
> >> Hello,
> >>
> >> As part of some follow up improvements to my VIRT_SPEC_CTRL series we
> >> have been discussing what the usage of SSBD should be for the
> >> hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
> >> that has an out of date description, as now SSBD is always offered to
> >> guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
> >>
> >> It has been pointed out by Andrew that toggling SSBD on AMD using
> >> VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
> >> have a high impact on performance, and hence switching it on every
> >> guest <-> hypervisor context switch is likely a very high
> >> performance penalty.
> >>
> >> It's been suggested that it could be more appropriate to run Xen with
> >> the guest SSBD selection on those systems, however that clashes with
> >> the current intent of the `spec-ctrl=ssbd` option.
> >>
> >> I hope I have captured the expressed opinions correctly in the text
> >> above.
> >>
> >> I see two ways to solve this:
> >>
> >>  * Keep the current logic for switching SSBD on guest <-> hypervisor
> >>    context switch, but only use it if `spec-ctrl=ssbd` is set on the
> >>    command line.
> >>
> >>  * Remove the logic for switching SSBD on guest <-> hypervisor context
> >>    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
> >>    hypervisor code with the guest selection of SSBD.
> >>
> >> Which has raised me the question of whether there's an use case
> >> for always running hypervisor code with SSBD enabled, or that's no
> >> longer relevant if we always offer guests a way for them to toggle the
> >> setting when required.
> >>
> >> I would like to settle on a way forward, so we can get this fixed
> >> before 4.17.
> >>
> >> Thanks, Roger.
> >>
> >> [0] https://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#spec-ctrl-x86
> > 
> > There are many issues at play here.  Not least that virt spec ctrl is
> > technically a leftover task that ought to force a re-issue of XSA-263.
> > 
> > Accessing MSRs (even reading) is very expensive, typically >1k cycles. 
> > The core CFG registers are more expensive than most, because they're
> > intended to be configured once after reset and then left alone.
> > 
> > Throughout the speculation work, we've seen crippling performance hits
> > from accessing MSRs in fastpaths.  The fact we're forced to use MSRs in
> > fastpaths even on new CPUs with built in (rather than retrofitted)
> > speculation support is is an area of concern still being worked on with
> > the CPU vendors.
> > 
> > Case in point.  We found for XSA-398 that toggling AMD's
> > MSR_SPEC_CTRL.IBRS on the PV entrypath was so bad that setting it
> > unilaterally behind the back of PV guests was the faster option. 
> > (Another todo is to stop doing this on Intel eIBRS systems, and this
> > will recover us a decent chunk of performance.)
> > 
> > 
> > SSBD mitigations are (rightly or wrongly) off by default for performance
> > reasons.  AMD are less affected than Intel, for microarchitectural
> > reasons which are discussed in relevant whitepapers, and which are
> > expected to remain true for future CPUs.
> > 
> > When Xen doesn't care about the protecting itself against SSBD by
> > default, I guarantee you that it will be faster to omit the MSR accesses
> > and run in the guest kernel's choice, than to clear the SSBD
> > protection.  We simply don't spend long enough in the hypervisor for the
> > hit against memory accesses to dwarf the hit for MSR accesses taken on
> > entry/exit.
> > 
> > The reason we put in spec-ctrl=ssbd was as a stopgap, because at the
> > time we didn't know how bad SSB really was, and it was decided that the
> > admin should have a big hammer to use if they really needed.
> > 
> > When Xen does care about protecting itself, the above reasoning bites
> > back hard.  Because we spend (or should be spending!) >99% of time in
> > the guest, the hit to memory accesses is far more likely to be able
> > dwarf the hit from the MSR accesses, but now, the dominating factor for
> > performance is the vmexit rate.
> > 
> > The problem is that if you've got a completely compute bound workload,
> > there are very few exits, while if you've got an IO bound workload,
> > there are plenty of exits.  I honestly don't know if it will be more
> > efficient to leave SSBD active unilaterally (whether or not we hide
> > this, e.g. synthesizing SSB_NO), or to let the guest run with it kernels
> > choice.  I suspect the answer is different with different workloads.
> > 
> > 
> > But, one other factor helps us.  Given that the default is fast (rather
> > than secure), anyone opting in to spec-ctrl=ssbd is saying "I care more
> > about security than performance", at which point we can simplify what we
> > do because we don't need to cater to everyone.
> > 
> > 
> > As a slight tangent, there is a cost to having too many options, which
> > must not be ignored.  Xen's speculation safety is far too complicated
> > already and needs to get more simple; this has a material impact on how
> > easy it is to follow, and how easy it to make changes.
> > 
> > It is the way it is because we've had 6 years of drip feeding one
> > problem after another, and haven't had the time to take a step and
> > design something more sensible from having 6 years of
> > knowledge/learnings as a basis.  There are definitely things which I
> > would have done differently, if 6 years ago, I'd known what I know now,
> > and part of the reason why the recent speculation security work has
> > taken so much effort is because it has involved reworking the effort
> > which came before, to a deadline which never has enough time to plan
> > properly within.
> > 
> > 
> > So, first question, do we care about having an "SSBD active while in
> > Xen" mode?
> > 
> > Probably yes, because we a) still don't have a working solution for PV
> > guests on AMD and b) who knows if there's something far worse lurking in
> > the future.  Sods law says that if we decide no here, it will be
> > critical for some future issue.
> > 
> > But as it's off by default and noone's made has made any noise about
> > having it on, we ought to prioritise simplicity.
> > 
> > Given that off is the default, but we know that kernels do offer it to
> > userspace, and it does get used by certain processes, we need to
> > prioritise performance.  And here, this is net system performance, not
> > "ensure it's off whenever it can be".  Having Xen run in the guest
> > kernel's choice of value will result in much better overall performance,
> > than trying to modify the setting in the VMentry/exit path.
> 
> My takeaway from this reply of yours is: By default run with the guest's
> choice, while (I'm less certain here) you're undecided about the behavior
> with "spec-ctrl=ssbd". Please could you make explicit whether this is a
> correct understanding of mine?

 * spec-ctrl=ssbd -> SSBD always on, expose VIRT_SSBD
   (VIRT_SPEC_CTRL.SSBD) but guest setting won't be propagated to
   platform.  As a future improvement also expose SSB_NO in that
   case.

 * spec-ctrl=no-ssbd -> Run hypervisor code with guest SSBD selection
   depending on hardware support.

Default to `spec-ctrl=no-ssbd`.

Would that be an accurate?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 09:35:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 09:35:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428790.679288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtrY-0000Fl-0f; Mon, 24 Oct 2022 09:35:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428790.679288; Mon, 24 Oct 2022 09:35:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omtrX-0000Fe-Td; Mon, 24 Oct 2022 09:35:15 +0000
Received: by outflank-mailman (input) for mailman id 428790;
 Mon, 24 Oct 2022 09:35:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HqnR=2Z=citrix.com=prvs=28966b5d3=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1omtrW-0000FW-Fp
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 09:35:14 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 27d11433-537f-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 11:35:13 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27d11433-537f-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666604112;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=GgMa8rYA1ciCZeYPHkS/Somdhm2GHgBCD7eJmLHr/1I=;
  b=Glu7gxaOhq3DVrR6IxRFfAt6hU+tgwjtVkXJzBPmAs5OK7oSUoabSfJ2
   42itbzC+OrhdEOQL7G6XrNJ8kK2avYoGWwjOykfyeRDd+X4QedwtTeH3D
   KNeMBR3CUIGd6VpnopYvN9Q+xXr/HcVc7uyUOy+0a/rFZBLd11z3+BMwT
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82979779
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SmhODq9vT7KfpjWveVcWDrUDrX6TJUtcMsCJ2f8bNWPcYEJGY0x3z
 GIdXzuFM6nYZ2CgLY9zYN+y80MAvMfcydNiSgNtqy48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5AdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0ttTW0MUq
 fA4Eh4EdQKkmuX1367mV8A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI
 ZNEN3w/N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9KobbGpQKwRfwS
 mTu+VakUhQwL9ukmB2b1lKcv9DRpi35R9dHfFG/3qEz2wDCroAJMzUMUkCxu/6+iUiWVNdWK
 khS8S0rxYAt8GS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebRwn0
 EWY2ezgAzNHuaeQD3ma89+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznc/I5MvTpgv3PNzjr0
 ReXq2shm+gOpJtev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5
 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS
 BWC0e+yzMUJVJdPUUOQS9vrY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ
 8nGLJ70Ui5EU/sPIN+KqwA1iOFD+8zD7TmLGcCTI+qPjdJym0J5uZ9aaQDTP4jVHYuPoRnP8
 sY3Cid540w3bQEKWQGOqdR7BQlTdRATXMmmw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp
 SjlBBcGmACl3hUq62yiMxheVV8mZr4nxVpTAMDmFQzAN6QLCWp30JoiSg==
IronPort-HdrOrdr: A9a23:8TIsV698TzEUBn+UFZRuk+DUI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+MjztCWE7gr5N0tBpTntAsW9qBDnhPtICOsqTNSftWDd0QPCRuxfBOPZslrd8kbFl9K1u5
 0OT0EHMqyTMWRH
X-IronPort-AV: E=Sophos;i="5.95,207,1661832000"; 
   d="scan'208";a="82979779"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, Anthony PERARD <anthony.perard@citrix.com>, "George
 Dunlap" <george.dunlap@citrix.com>, Nick Rosbrook <rosbrookn@gmail.com>, "Wei
 Liu" <wl@xen.org>
Subject: [XEN PATCH for-4.17] tools/golang: Remove existing *.gen.go before re-creating them
Date: Mon, 24 Oct 2022 10:34:55 +0100
Message-ID: <20221024093455.39969-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

In cases where we don't have permission to write to the existing
*.gen.go, we should be able to remove them and recreate them.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

For 4.17:
    Without this, it is possible that the Gitlab CI got in a state
    where writing to the file would fail, but removing it and creating
    a new one should work.

    This issue have been observed only on `fedora-gcc*` jobs as fedora
    is our only container that have `golang` installed. And it runs
    the build as a `user` instead of `root.
---
 tools/golang/xenlight/gengotypes.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/golang/xenlight/gengotypes.py b/tools/golang/xenlight/gengotypes.py
index 9fec60602d..ed0122874f 100644
--- a/tools/golang/xenlight/gengotypes.py
+++ b/tools/golang/xenlight/gengotypes.py
@@ -45,6 +45,7 @@ def xenlight_golang_generate_types(path = None, types = None, comment = None):
     if path is None:
         path = 'types.gen.go'
 
+    os.unlink(path)
     with open(path, 'w') as f:
         if comment is not None:
             f.write(comment)
@@ -209,6 +210,7 @@ def xenlight_golang_generate_helpers(path = None, types = None, comment = None):
     if path is None:
         path = 'helpers.gen.go'
 
+    os.unlink(path)
     with open(path, 'w') as f:
         if comment is not None:
             f.write(comment)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:03:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:03:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428797.679305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuIm-0003ir-8w; Mon, 24 Oct 2022 10:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428797.679305; Mon, 24 Oct 2022 10:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuIm-0003ik-67; Mon, 24 Oct 2022 10:03:24 +0000
Received: by outflank-mailman (input) for mailman id 428797;
 Mon, 24 Oct 2022 10:03:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omuIl-0003ie-Fo
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:03:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omuIi-0008QT-79; Mon, 24 Oct 2022 10:03:20 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225]
 helo=[192.168.4.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omuIh-0008Jw-Vf; Mon, 24 Oct 2022 10:03:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=KVGmDcLDALE1UjmcPsxOOf/Jnio0oRbU5tW5EsTX0O8=; b=mZU+VzJf/+pSrG62i9LDDOI8wD
	qkcp8e4OSjOnPRM5MdoWPbMmSyQqfJk+YMrJtZeSclj2CefCP1mnJHhs95BNjC4NZnoDnWQ3zz+zw
	e6bq1oD18J9ttfPIlhQH3zfpUiQMapdsv5zGoXWJ2toXIrecbjVRH/WBvn0XQqFsT+ok=;
Message-ID: <b9868745-8e8a-01f2-818b-2efe7b5df5cf@xen.org>
Date: Mon, 24 Oct 2022 11:03:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [PATCH v2][4.17?] core-parking: fix build with gcc12 and
 NR_CPUS=1
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Henry Wang <Henry.Wang@arm.com>
References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com>
 <61e8475d-868d-3ff0-041f-8f6790990ce4@xen.org>
 <8b2d008b-526f-dc36-71d6-81b653bbf467@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <8b2d008b-526f-dc36-71d6-81b653bbf467@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 24/10/2022 08:26, Jan Beulich wrote:
> On 22.10.2022 17:30, Julien Grall wrote:
>> Is this intended for 4.17?
> 
> Well, yes, it was meant to be - it has been ...
> 
>> On 09/09/2022 15:30, Jan Beulich wrote:
> 
> ... well over a month since it was sent.
> 
>>> --- a/xen/arch/x86/sysctl.c
>>> +++ b/xen/arch/x86/sysctl.c
>>> @@ -157,7 +157,7 @@ long arch_do_sysctl(
>>>            long (*fn)(void *);
>>>            void *hcpu;
>>>    
>>> -        switch ( op )
>>> +        switch ( op | -(CONFIG_NR_CPUS == 1) )
>> This code is quite confusing to read and potentially risky as you are
>> are relying the top bit of 'op' to never be 1. While I am expecting this
>> will ever be the case, this will be a "fun" issue to debug if this ever
>> happen. So I would suggest to check CONFIG_NR_CPUS == 1 separately.
> 
> You're aware that we use this pattern in a few other places already (I
> guess in my local tree I have one or two which aren't upstream yet)? Just
> grep for "switch[^_].*[|]" to see them.

I could only spot two upstream in arch/x86/hvm/svm/svm.c and 
arch/x86/hvm/vmx/vmx.c.

But I am not convinced this is a good enough reason to continue to use 
this approach. There are a few bad code examples in Xen and we have been 
pushing against continue to spread certain construct.

> Also note that it's not just the
> top bit of "op" - we merely assume "op" will never be ~0.
Yes, I misread the code.

> Personally I
> prefer this way of coding the logic, but if at least one of the other x86
> maintainers agreed with you, I'd be okay to switch to using a separate
> if().

I am curious why, is it just a matter of taste?

If you really want to go down this route, then I think you should add 
"ASSERT(op != ~0U);" to catch someone introducing a value match that one 
we exclude.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:05:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:05:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428802.679315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuL3-0004Ju-M9; Mon, 24 Oct 2022 10:05:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428802.679315; Mon, 24 Oct 2022 10:05:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuL3-0004Jn-JM; Mon, 24 Oct 2022 10:05:45 +0000
Received: by outflank-mailman (input) for mailman id 428802;
 Mon, 24 Oct 2022 10:05:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tdD1=2Z=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1omuL2-0004Jg-Dt
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:05:44 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b072a1d-5383-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 12:05:42 +0200 (CEST)
Received: from DM6PR08CA0035.namprd08.prod.outlook.com (2603:10b6:5:80::48) by
 PH7PR12MB6954.namprd12.prod.outlook.com (2603:10b6:510:1b7::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 10:05:39 +0000
Received: from DM6NAM11FT066.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:80:cafe::3b) by DM6PR08CA0035.outlook.office365.com
 (2603:10b6:5:80::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25 via Frontend
 Transport; Mon, 24 Oct 2022 10:05:39 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT066.mail.protection.outlook.com (10.13.173.179) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 10:05:39 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 05:05:37 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 03:05:37 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 24 Oct 2022 05:05:36 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b072a1d-5383-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=giqtVBAxTHKspMB9wB24mQFQHYWe45oZpxMLgvyzz62TILr+sxlRpbJA1odjxhvukp5sUX0N1wugKuCUJkG2Cj5f0x8cWpE/GJwmNLs+oy1nNXBdV1Mc0V6m8NG7r9IXjqcrQsVYQI8fJtKNDYzvBGa7nYQThAp4HpN7aedp7ivPSIYbMDJ0DVKbe2KSQTUGYjDR9F83K8QRwwpX1eS15syZlMc/mI/13Vi1mNCdEn7Zu45SYau7irfF+6TB/OW8CfnP6fhpduMDPYRYuuylnkM1sT+KHfq9KhjQLQDKDfb1tu+68kqNbBiR973gtV8Dl0/lFnkC0NXm0f5FPRQZhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jxdh7z1RpU2y6bgq109Srd+Y2p8XscsWMuLz0iwZ6eg=;
 b=ENoswiOFlTQ+V5LeUWuR7Wk/XbRR2pij47eyCHmsNC1rlFfS08rUD6kSxZG7Yz/IB4R9dYyRBXPUWqy6oK2JNeRkiv6j3P4m6JsSSGV69soeXdYVYN6O4JU/683IGiO0IUYGcDl3B8Ff/8TalqlelTSU3ymfE0NozLKEE+o/T2q/x6C/KZdT/9LhQzmaF6Tk4qB/eE1O5U6PKfnQUu34GkEYqr4xenOVdVwlp+whlM9FUG+uQfYQIjKVsne9vpYfmWQHwQWSeVgOQoJLnPmprY01p5lfPpPfMDH8mRg2gOXQx3Rgi3Adg0XgDvijjkMzJwJdwWuqMZQTb7tmgblcGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jxdh7z1RpU2y6bgq109Srd+Y2p8XscsWMuLz0iwZ6eg=;
 b=gfEFl4PwNtNG+CXAtAnQQLjFdjAjRepfsZ6cIurVOQjh2RrTRFzlqoIfSrXos9GaGTmjxTYPk8+7HrUd0cxnX+SAtEe3UkHrOfz6/74HU81TZXVikxSi1y8AcIBMMc08fPuekjSRW7cJwKVpxM+yPRiY/607prLs/ykDii0Ay/c=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values
Date: Mon, 24 Oct 2022 12:05:36 +0200
Message-ID: <20221024100536.12874-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT066:EE_|PH7PR12MB6954:EE_
X-MS-Office365-Filtering-Correlation-Id: 3cf20d81-8ef9-4d19-49ea-08dab5a74d8d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uJBDclfRBPaEZWBbmS+LjwexHEv6CakCJApyTZR9HAmPE6zwu4ViFc41EMXvJNFkvs9uGNHLsuib6ojWwIpxsKavSexe94qY6c7mpjsRabVKMvkS5/h1aVao4oxb+hmROR4m1dKjVBNQF1r9S11b5A8m1VrRV+VZJ/MVij+GcUTxyEJtQuqt2Np8qOKCCr9OWqW1kYHl0HLsOHpaY2eTN8mPaiZvXLuHjKJPu2kpzKwLgWotRcyBUmytT+0SKUJuLjyo5Y2W7rWWcsjROzeq3DE2CiK1AM/HJd6c/t6RP8FYGPuVLfK0knji3Rp6h0UcYoF/W1SN979et4XWZvbncXsFjL6LEfGjC8hxONUz+zm//1GASwQCvigF3kr2A2F8mxTP3T+K5JcPvbqyFkrlJIuc5paVs5HeWI4TjjY1Dy6y9izrrPboQmXWLuesPIPBeXvQ/0ChbBGuISBEMp9lgSE02ShPpkTxhJHgnpquJWHtBpJb0872hKoEOj9RLkhHlaCh3AjckByi8+r3HbH0Z0J6PRbmeY7+s7hF0PqWf1BVaGlonpBdeR/0QX83930naa9CCXJcALUZc+ZIzE8w7mwpK8PpTJHm4lDfeQbcowzt56LupReFoGOSL7xFuNtIE7TBpvLEmOYUQl66oVbQeUwPWudF4KFcbfzS0WLMZifvEoEYkv4RfVNqR2+B9UAfA4v7GsnTx5iznRSI1zTcScKVTNHmlWBUhd5NOK15uH9t6ziuUHQl+1kJwma4bhqYz+YMoi0ADUSleWNuPY1O+6HsY4SUj7eNVOirTFYYDEZrHAYz42WOgo+lgvhJG9s9
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(186003)(2616005)(5660300002)(47076005)(83380400001)(81166007)(356005)(86362001)(336012)(41300700001)(36860700001)(426003)(1076003)(82740400003)(40460700003)(2906002)(44832011)(54906003)(82310400005)(8936002)(26005)(6916009)(40480700001)(70586007)(8676002)(478600001)(4326008)(316002)(70206006)(36756003)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:05:39.0836
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cf20d81-8ef9-4d19-49ea-08dab5a74d8d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT066.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6954

Make use of the macros defined in asm/pl011-uart.h instead of hardcoding
the values. Also, take the opportunity to fix the file extension in a
top-level comment.

No functional change intended.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
 xen/arch/arm/arm64/debug-pl011.inc | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/xen/arch/arm/arm64/debug-pl011.inc b/xen/arch/arm/arm64/debug-pl011.inc
index 1928a2e3ffbb..d82f2f1de197 100644
--- a/xen/arch/arm/arm64/debug-pl011.inc
+++ b/xen/arch/arm/arm64/debug-pl011.inc
@@ -1,5 +1,5 @@
 /*
- * xen/arch/arm/arm64/debug-pl011.S
+ * xen/arch/arm/arm64/debug-pl011.inc
  *
  * PL011 specific debug code
  *
@@ -16,6 +16,8 @@
  * GNU General Public License for more details.
  */
 
+ #include <asm/pl011-uart.h>
+
 /*
  * PL011 UART initialization
  * xb: register which containts the UART base address
@@ -23,13 +25,13 @@
  */
 .macro early_uart_init xb, c
         mov   x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE % 16)
-        strh  w\c, [\xb, #0x28]      /* -> UARTFBRD (Baud divisor fraction) */
+        strh  w\c, [\xb, #FBRD]      /* -> UARTFBRD (Baud divisor fraction) */
         mov   x\c, #(7372800 / CONFIG_EARLY_UART_PL011_BAUD_RATE / 16)
-        strh  w\c, [\xb, #0x24]      /* -> UARTIBRD (Baud divisor integer) */
+        strh  w\c, [\xb, #IBRD]      /* -> UARTIBRD (Baud divisor integer) */
         mov   x\c, #0x60             /* 8n1 */
-        str   w\c, [\xb, #0x2C]      /* -> UARTLCR_H (Line control) */
-        ldr   x\c, =0x00000301       /* RXE | TXE | UARTEN */
-        str   w\c, [\xb, #0x30]      /* -> UARTCR (Control Register) */
+        str   w\c, [\xb, #LCR_H]     /* -> UARTLCR_H (Line control) */
+        ldr   x\c, =(RXE | TXE | UARTEN)
+        str   w\c, [\xb, #CR]        /* -> UARTCR (Control Register) */
 .endm
 
 /*
@@ -39,8 +41,8 @@
  */
 .macro early_uart_ready xb, c
 1:
-        ldrh  w\c, [\xb, #0x18]      /* <- UARTFR (Flag register) */
-        tst   w\c, #0x8              /* Check BUSY bit */
+        ldrh  w\c, [\xb, #FR]        /* <- UARTFR (Flag register) */
+        tst   w\c, #BUSY             /* Check BUSY bit */
         b.ne  1b                     /* Wait for the UART to be ready */
 .endm
 
@@ -50,7 +52,7 @@
  * wt: register which contains the character to transmit
  */
 .macro early_uart_transmit xb, wt
-        strb  \wt, [\xb]             /* -> UARTDR (Data Register) */
+        strb  \wt, [\xb, #DR]        /* -> UARTDR (Data Register) */
 .endm
 
 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:06:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:06:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428806.679327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuMB-0004rr-0s; Mon, 24 Oct 2022 10:06:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428806.679327; Mon, 24 Oct 2022 10:06:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuMA-0004rk-UL; Mon, 24 Oct 2022 10:06:54 +0000
Received: by outflank-mailman (input) for mailman id 428806;
 Mon, 24 Oct 2022 10:06:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=smss=2Z=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1omuM9-0004rV-5U
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:06:53 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94d5a045-5383-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 12:06:52 +0200 (CEST)
Received: from DU2PR04CA0044.eurprd04.prod.outlook.com (2603:10a6:10:234::19)
 by DB4PR08MB9192.eurprd08.prod.outlook.com (2603:10a6:10:3fb::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Mon, 24 Oct
 2022 10:06:50 +0000
Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:234:cafe::88) by DU2PR04CA0044.outlook.office365.com
 (2603:10a6:10:234::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Mon, 24 Oct 2022 10:06:50 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 24 Oct 2022 10:06:49 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Mon, 24 Oct 2022 10:06:49 +0000
Received: from 35a82b6d175c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 267915AD-22B7-4161-BFFB-EAD1381FCDEE.1; 
 Mon, 24 Oct 2022 10:06:43 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35a82b6d175c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 24 Oct 2022 10:06:43 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM0PR08MB5521.eurprd08.prod.outlook.com (2603:10a6:208:18a::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 10:06:42 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 10:06:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94d5a045-5383-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=CgAxS4v0WvVsvBUkERKoJpAn8ZMED9QcGuU/fpsEWioRxPaxogI8o9SUyAMief2dAGASrKDUUlqqOPkBUBR+fM/xyXXJoe5PzdBi//lCnGC6SPaydzYcBd/SI31IqhIzHx/tVlOMPRqlUMsDTXW+9cVF9al7xjgqP3i+SBKmauELNAZgFvozVbNb1lWxA9/mEaINY7OjSFlaXYel92+ElqUSc+8V/3qtO1htuSCu+Eh/HiREoi7XRfmbFpji54oVtnKTaIgFL5YEL9AIE6ZQNACy/+qzATiVOouaF+sRLQoFQsWA0ay2XhOZyYiWp7SUb1XNa7gk/4s1ArtP0n4dgA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vHSOAM9cz3HYxb2meNSJMTfre4ZFZdxUU8qU9e6Rv0w=;
 b=PiaKPolovkdkYNa33uPNvjvlrPrTfWlVgUW3i6B8I85bHKIRCARP8wUss8dBvHRBy/dW5q51wsYti8iUkyrfIFJWFewC3kanMhCJeSRNrD9TEprgVQqpKC2IGW8sWjI4+EQMIeY+xLPvD5eubpZQSn1oNPvlFOCjuyNO7ZMsyMBORd8X7RM9yFOgtYx07EqBQHvpMjKB0Qj8sa7ZPaJ6VKCl4aB5rWl6rYmB/CCIYg5XA0B29GIkcLBr8yvbGmXOhIu83HYchDw14FbwLlxLnQIKhP1yMiWIyhVTpBN0HwXS08r/86A4gHOf3mvkUCBfDPB/yk7vrmuEsFmM00fbbg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vHSOAM9cz3HYxb2meNSJMTfre4ZFZdxUU8qU9e6Rv0w=;
 b=eSQs/BnILY4CudTfKm/KlySSJN6+D4dl2ZOpXtndWbtk3TXk9FUnE07qBmIzQZQGHNZ40YKjeGNerRQDava5S2BpDuAeIxyVepTrrb8IC7jG3SNW094KIDbzil3DKxeQriBlKRV25Eq4qBiyuo2AN2MXpLRLGpEv5/2s60KrECw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: e098678c999f5c35
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LxU8rBrQkgQQ3U9UHg2Tc2OhqZHqiq0iiSGVLewuYqPMK3U80By9NVt7QTLQjrY2BZma0o2lFwuvjLGrWTItc2CRBzKKz/qWG62epESGRfYLBlIgX2x+ZP8UzBVMleYXa1Tk2Abrch5w34K0l1Cdzcp4NNDSAlqe/DyRqV8XCe1lR6TtkUOqIS/pNVhxYXHg8vkd7FAuEM7uA/FxyrNdYgVJM+xId7DpTVCNxkKjX93uDOPV3TCYNTT0JJMMI6VKxcE52HfEebT3zO9aKxQ/h187J5nADVZLSK1VSfWjpYmqQdzlJQ1boQynY6jgr20b4Al6B3cn1eiu3KnwG4QQ+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vHSOAM9cz3HYxb2meNSJMTfre4ZFZdxUU8qU9e6Rv0w=;
 b=Y/YswKnTKw19Y7dXiEPPZYqDped1q79G7p0htuI64F0GSQlGj+8hdXPYXCp3aZB71RtqjoslZ8fVd4kwrzKEyvVjp6t1UUDf15FAM3RhBHLGxuVY6LP7XMYZIrnwI5H4qR3LhvQ1gTRwOLUJE6QGz55SJ8agaUAbIlA4P4rKe5xu4BjEH7epurUUiNKC9Syz0jIEoyFz99xKFtBONNn9mE8dzjESdwlTyCg4qBcio0B09wnJ00HJ+kvnNgcIFEkJj+9wyWmYWtBAVIwESPUYbl5yAliS7CqbA9NoQgWK6myIERMLQ5QKhMqTnFS4HTCCE0q36aPa9xqX27AS+IBFHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vHSOAM9cz3HYxb2meNSJMTfre4ZFZdxUU8qU9e6Rv0w=;
 b=eSQs/BnILY4CudTfKm/KlySSJN6+D4dl2ZOpXtndWbtk3TXk9FUnE07qBmIzQZQGHNZ40YKjeGNerRQDava5S2BpDuAeIxyVepTrrb8IC7jG3SNW094KIDbzil3DKxeQriBlKRV25Eq4qBiyuo2AN2MXpLRLGpEv5/2s60KrECw=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Thread-Topic: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Thread-Index: AQHY5HCY/1GJrkxfi0yPJz1IUtcgr64dV76A
Date: Mon, 24 Oct 2022 10:06:42 +0000
Message-ID: <AE2C68A9-4276-444C-B227-F079D330EB8A@arm.com>
References: <20221020104146.29841-1-ayankuma@amd.com>
In-Reply-To: <20221020104146.29841-1-ayankuma@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AM0PR08MB5521:EE_|DBAEUR03FT025:EE_|DB4PR08MB9192:EE_
X-MS-Office365-Filtering-Correlation-Id: 438b77c3-5e7d-4af4-2eff-08dab5a777ba
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 k3SZiyi2aaWbBCLjepWz1tUUs8wziPTTytGHdBMQ0NN3Ks+7jUDwT3SbApZ1AZIjf5FLXITnKbObGiQpumbnvGEmAzvJGyEpIsR7hu6fumfEY0S4CDkyIKEqWRGvBRZHpYGRlhpVIql29WhLa2YmWA6hiTH8UA+fDgaGozfh7nrjhMQodwHmDIi3YrqMwzTmEghbBHZfwJqCB9h2azYhQrrebg3VsFRlpgtkPn+fznaUPT/PQNteRsp0vHCLMnFwPmoNTgWneuq6OdAyyYeJswG8ikWVKjr4NvAm6j/2DNprLSfvF3w04iUwkS9DlYRO5+lkwkh/Wo+QtEzZIuCNNJ4fGwfQJZNlnFB54+xLqrobPv2Kg7yQyMc8kGoD0XCszggAU6Q+51/6UDiCg+r0dXghSJ7PzND84GAF3a5sRkC5q49WAwl5/OkSC8CIi7Py4iGTjA1Z0ibpc54EJ+fiHrULQIjKVzFpS2hLYXJx5p1UHOnBvwkkeUTS/1Jz7riWAxox8gmhbNrmuwFuWSZKYwMZXjdXzw1yXriXh34frEnVqyxaT9Kju24qvkeroKS2Sr5uqzNJVUMRiTp/l8rXvsZnIoh60VwrfbrRPvspVDhVKGed4ZnPQ5QM/Ap5hRHFu0c+7O0hlTtS9WmYX14IGcgWyhy04s1atZ/I6axatUTNGKshB9yPQkF8rBXn0A+AD9Bl4s4hhXWoy8oTf7fsY+FqdPH+wgr1OREyXg36LP9RFwmts2X9bZjQuzNoiqnm0E+3oNfiV0gZX2O5Rn5axv0xzRyIHZcByxNhwuQLN4c=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199015)(33656002)(38070700005)(6916009)(54906003)(36756003)(2906002)(5660300002)(8936002)(66946007)(66556008)(66476007)(66446008)(64756008)(8676002)(4326008)(41300700001)(86362001)(76116006)(316002)(6506007)(91956017)(26005)(6512007)(53546011)(83380400001)(186003)(2616005)(38100700002)(71200400001)(6486002)(122000001)(478600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <B2CFBC18262EFC448A66CA845D7ED81B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5521
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bb55d65b-39f9-4b08-4f5d-08dab5a7731f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oC3p/G+rM5d1ZFSUU197KZKxEJCvWD1r3QFm1YWormaSSHDta0QoGxOh32RtEjOB+Jow9HbxrfKYzFEvHD5F5s/YTaFjh5ISvub95Xa5JZ1RAEu9uC8a5KVM+zLwCAxo0PUV5z0b0qgyUodBpM/b887pKzFEU4yycwFncmLz7dhncft6gnOrbYoFj4LPcbXrD5rmZcYmZjZfW+H7TJbW03PpvWu1+BIFvQaAvHOG2SfaAF70gjiKJ+B0eZD5Eu2lI2dEScFqIE/Ivjd50R3TUWiuwnFI3ytVRa2r6SMO//Gl73sTahvmxNkDgtnQJDejKttqpad/6yxU/HxI7Yl5cWHpmlzX6F7g6MtaIKcBaW3raHwUCgj7fSu6VG9u2zP4YA4jVHqG+wzlPgpUgfupc3zR8lPlKRMhkAdh8y0yXMJfEcdzqdAMcPRXlk03XiHGVi/KhQ/SnTrOkLpuCN+RlXQLuGTOFy62a2hrpQV8tthlp0hEPKtM2/L6Vwbpfuwbfbyf3EC702/091TaUike42rjJIXgozkuB4leBQ0Trsp0ZynUne3r1s0he392+v0mX5A9c+AwJXI6X1WUceCh0kZXJG2dHyJ1N6+HUpMf0eOa5Ib0su9smlrf4dIxp11AXSZkZRMXYUaJi9k7AqXNHsn/gqxUet47rzKx1qjfBNWXNowI5GstSXmKRxJkyQ/2FYVK8EMKynDEog6PhoJYQ0Z1heLZH4RaDZyi433fmro=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(36840700001)(46966006)(2906002)(36756003)(6862004)(47076005)(81166007)(82740400003)(41300700001)(8936002)(33656002)(8676002)(86362001)(54906003)(4326008)(70206006)(70586007)(5660300002)(316002)(336012)(83380400001)(6512007)(6486002)(186003)(2616005)(356005)(82310400005)(40480700001)(36860700001)(26005)(53546011)(107886003)(6506007)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:06:49.9046
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 438b77c3-5e7d-4af4-2eff-08dab5a777ba
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9192

SGkgQXlhbiwNCg0KPiBPbiAyMCBPY3QgMjAyMiwgYXQgMTE6NDEsIEF5YW4gS3VtYXIgSGFsZGVy
IDxheWFua3VtYUBhbWQuY29tPiB3cm90ZToNCj4gDQo+IFJlZmVyIEdJQyB2MyBzcGVjaWZpY2F0
aW9uIChBcm0gSUhJIDAwNjlIIElEMDIwOTIyKSwgSUdSUE1PRFIgKHNpbWlsYXIgdG8NCj4gSUdS
T1VQUikgaXMgcmVsZXZhbnQgb25seSB3aGVuIHRoZSBndWVzdHMgcnVuIGluIHNlY3VyZS9ub24t
c2VjdXJlIG1vZGUuDQoNClRoaXMgc2VudGVuY2UgaXMgYSBiaXQgbWlzbGVhZGluZyBhcyBndWVz
dHMgYXJlIGFsd2F5cyBydW5uaW5nIGluIGVpdGhlciBzZWN1cmUgb3Igbm9uLXNlY3VyZS4NCldl
IHNob3VsZCBqdXN0IHNheSB0aGF0IHdlIGRvIG5vdCB3YW50IGd1ZXN0IHRvIGNoYW5nZSB0aGUg
Z3JvdXAgb2YgaW50ZXJydXB0cyBzbyB3ZSBkbyBhcyBpZiBhbGwgZ3Vlc3RzIGFyZSBydW5uaW5n
IGluIG5vbi1zZWN1cmUuDQoNCj4gQXMgWGVuIGRvZXMgbm90IGltcGxlbWVudCBzZWN1cml0eSBl
eHRlbnNpb25zIGZvciBndWVzdHMsIHNvIHRoZSByZWdpc3RlcnMNCj4gYXJlIGVtdWxhdGVkIGFz
IHJlYWQgYXMgemVyby93cml0ZSBpZ25vcmUuDQoNCkkgd291bGQgcmVwaHJhc2UgdGhpcyBhcyDi
gJxYZW4gZG9lcyBzdXBwb3J0IHRvIHJ1biBpbiBzZWN1cmUgbW9kZSBzbyBlbXVsYXRlIGFsbCBy
ZWdpc3RlcnMgYXMgdGhlIGhhcmR3YXJlIGRvZXMgaW4gbm9uLXNlY3VyZS7igJ0NCg0KT24gYSBz
aWRlIG5vdGUsIHRoZSBxdWVzdGlvbiBtaWdodCBjb21lIGF0IHNvbWUgcG9pbnQgaWYgd2Ugc3Vw
cG9ydCB0byBydW4gZnJvbSBzZWN1cmUgbW9kZSBvbiBoYXJkd2FyZSBzdXBwb3J0aW5nIGl0LCBp
dCBjb3VsZCBiZSB0aGF0IGRvbTAgb3IgWGVuIGl0c2VsZiB3b3VsZCBuZWVkIHRvIG1vZGlmeSB0
aG9zZS4NCg0KVGhlIGNvZGUgaXMgb2ssIGp1c3QgdGhlIGNvbW1pdCBtZXNzYWdlIHdvdWxkIG5l
ZWQgYSBiaXQgb2YgcmV3b3JrIEkgdGhpbmsuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4g
U2lnbmVkLW9mZi1ieTogQXlhbiBLdW1hciBIYWxkZXIgPGF5YW5rdW1hQGFtZC5jb20+DQo+IC0t
LQ0KPiANCj4gT2JzZXJ2ZWQgdGhlIGlzc3VlIHdoaWxlIHJ1bm5pbmcgWmVwaHlyIG9uIFI1Mi4N
Cj4gQWxzbywgZm91bmQgdGhhdCBLVk0gaGFzIHNpbWlsYXIgYmVoYXZpb3VyLg0KPiANCj4gQ2hh
bmdlcyBmcm9tOi0NCj4gdjEgLSBNb3ZlZCB0aGUgZGVmaW5pdGlvbnMgb2YgR0lDRF9JR1JQTU9E
UiwgR0lDRF9JR1JQTU9EUk4gdG8gZ2ljX3YzDQo+IHNwZWNpZmljIGhlYWRlci4NCj4gDQo+IHhl
bi9hcmNoL2FybS9pbmNsdWRlL2FzbS9naWNfdjNfZGVmcy5oIHwgMiArKw0KPiB4ZW4vYXJjaC9h
cm0vdmdpYy12My5jICAgICAgICAgICAgICAgICB8IDQgKysrKw0KPiAyIGZpbGVzIGNoYW5nZWQs
IDYgaW5zZXJ0aW9ucygrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRl
L2FzbS9naWNfdjNfZGVmcy5oIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2dpY192M19kZWZz
LmgNCj4gaW5kZXggMzRlZDVmODU3ZC4uNzI4ZTI4ZDVlNSAxMDA2NDQNCj4gLS0tIGEveGVuL2Fy
Y2gvYXJtL2luY2x1ZGUvYXNtL2dpY192M19kZWZzLmgNCj4gKysrIGIveGVuL2FyY2gvYXJtL2lu
Y2x1ZGUvYXNtL2dpY192M19kZWZzLmgNCj4gQEAgLTMwLDYgKzMwLDggQEANCj4gI2RlZmluZSBH
SUNEX0NMUlNQSV9OU1IgICAgICAgICAgICAgICgweDA0OCkNCj4gI2RlZmluZSBHSUNEX1NFVFNQ
SV9TUiAgICAgICAgICAgICAgICgweDA1MCkNCj4gI2RlZmluZSBHSUNEX0NMUlNQSV9TUiAgICAg
ICAgICAgICAgICgweDA1OCkNCj4gKyNkZWZpbmUgR0lDRF9JR1JQTU9EUiAgICAgICAgICAgICAg
ICAoMHhEMDApDQo+ICsjZGVmaW5lIEdJQ0RfSUdSUE1PRFJOICAgICAgICAgICAgICAgKDB4RDdD
KQ0KPiAjZGVmaW5lIEdJQ0RfSVJPVVRFUiAgICAgICAgICAgICAgICAgKDB4NjAwMCkNCj4gI2Rl
ZmluZSBHSUNEX0lST1VURVIzMiAgICAgICAgICAgICAgICgweDYxMDApDQo+ICNkZWZpbmUgR0lD
RF9JUk9VVEVSMTAxOSAgICAgICAgICAgICAoMHg3RkQ4KQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2Fy
Y2gvYXJtL3ZnaWMtdjMuYyBiL3hlbi9hcmNoL2FybS92Z2ljLXYzLmMNCj4gaW5kZXggN2ZiOTlh
OWZmMi4uMGMyM2Y2ZGY5ZCAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL3ZnaWMtdjMuYw0K
PiArKysgYi94ZW4vYXJjaC9hcm0vdmdpYy12My5jDQo+IEBAIC02ODUsNiArNjg1LDcgQEAgc3Rh
dGljIGludCBfX3ZnaWNfdjNfZGlzdHJfY29tbW9uX21taW9fcmVhZChjb25zdCBjaGFyICpuYW1l
LCBzdHJ1Y3QgdmNwdSAqdiwNCj4gICAgIHN3aXRjaCAoIHJlZyApDQo+ICAgICB7DQo+ICAgICBj
YXNlIFZSQU5HRTMyKEdJQ0RfSUdST1VQUiwgR0lDRF9JR1JPVVBSTik6DQo+ICsgICAgY2FzZSBW
UkFOR0UzMihHSUNEX0lHUlBNT0RSLCBHSUNEX0lHUlBNT0RSTik6DQo+ICAgICAgICAgLyogV2Ug
ZG8gbm90IGltcGxlbWVudCBzZWN1cml0eSBleHRlbnNpb25zIGZvciBndWVzdHMsIHJlYWQgemVy
byAqLw0KPiAgICAgICAgIGlmICggZGFidC5zaXplICE9IERBQlRfV09SRCApIGdvdG8gYmFkX3dp
ZHRoOw0KPiAgICAgICAgIGdvdG8gcmVhZF9hc196ZXJvOw0KPiBAQCAtNzgxLDYgKzc4Miw3IEBA
IHN0YXRpYyBpbnQgX192Z2ljX3YzX2Rpc3RyX2NvbW1vbl9tbWlvX3dyaXRlKGNvbnN0IGNoYXIg
Km5hbWUsIHN0cnVjdCB2Y3B1ICp2LA0KPiAgICAgc3dpdGNoICggcmVnICkNCj4gICAgIHsNCj4g
ICAgIGNhc2UgVlJBTkdFMzIoR0lDRF9JR1JPVVBSLCBHSUNEX0lHUk9VUFJOKToNCj4gKyAgICBj
YXNlIFZSQU5HRTMyKEdJQ0RfSUdSUE1PRFIsIEdJQ0RfSUdSUE1PRFJOKToNCj4gICAgICAgICAv
KiBXZSBkbyBub3QgaW1wbGVtZW50IHNlY3VyaXR5IGV4dGVuc2lvbnMgZm9yIGd1ZXN0cywgd3Jp
dGUgaWdub3JlICovDQo+ICAgICAgICAgZ290byB3cml0ZV9pZ25vcmVfMzI7DQo+IA0KPiBAQCAt
MTE5Miw2ICsxMTk0LDcgQEAgc3RhdGljIGludCB2Z2ljX3YzX2Rpc3RyX21taW9fcmVhZChzdHJ1
Y3QgdmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+ICAgICBjYXNlIFZSQU5HRTMyKEdJQ0Rf
SUNBQ1RJVkVSLCBHSUNEX0lDQUNUSVZFUk4pOg0KPiAgICAgY2FzZSBWUkFOR0UzMihHSUNEX0lQ
UklPUklUWVIsIEdJQ0RfSVBSSU9SSVRZUk4pOg0KPiAgICAgY2FzZSBWUkFOR0UzMihHSUNEX0lD
RkdSLCBHSUNEX0lDRkdSTik6DQo+ICsgICAgY2FzZSBWUkFOR0UzMihHSUNEX0lHUlBNT0RSLCBH
SUNEX0lHUlBNT0RSTik6DQo+ICAgICAgICAgLyoNCj4gICAgICAgICAgKiBBYm92ZSBhbGwgcmVn
aXN0ZXIgYXJlIGNvbW1vbiB3aXRoIEdJQ1IgYW5kIEdJQ0QNCj4gICAgICAgICAgKiBNYW5hZ2Ug
aW4gY29tbW9uDQo+IEBAIC0xMzc5LDYgKzEzODIsNyBAQCBzdGF0aWMgaW50IHZnaWNfdjNfZGlz
dHJfbW1pb193cml0ZShzdHJ1Y3QgdmNwdSAqdiwgbW1pb19pbmZvX3QgKmluZm8sDQo+ICAgICBj
YXNlIFZSQU5HRTMyKEdJQ0RfSUNBQ1RJVkVSLCBHSUNEX0lDQUNUSVZFUk4pOg0KPiAgICAgY2Fz
ZSBWUkFOR0UzMihHSUNEX0lQUklPUklUWVIsIEdJQ0RfSVBSSU9SSVRZUk4pOg0KPiAgICAgY2Fz
ZSBWUkFOR0UzMihHSUNEX0lDRkdSLCBHSUNEX0lDRkdSTik6DQo+ICsgICAgY2FzZSBWUkFOR0Uz
MihHSUNEX0lHUlBNT0RSLCBHSUNEX0lHUlBNT0RSTik6DQo+ICAgICAgICAgLyogQWJvdmUgcmVn
aXN0ZXJzIGFyZSBjb21tb24gd2l0aCBHSUNSIGFuZCBHSUNEDQo+ICAgICAgICAgICogTWFuYWdl
IGluIGNvbW1vbiAqLw0KPiAgICAgICAgIHJldHVybiBfX3ZnaWNfdjNfZGlzdHJfY29tbW9uX21t
aW9fd3JpdGUoInZHSUNEIiwgdiwgaW5mbywNCj4gLS0gDQo+IDIuMTcuMQ0KPiANCg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:09:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428813.679338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuOe-0005ZN-Ie; Mon, 24 Oct 2022 10:09:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428813.679338; Mon, 24 Oct 2022 10:09:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuOe-0005ZG-Fq; Mon, 24 Oct 2022 10:09:28 +0000
Received: by outflank-mailman (input) for mailman id 428813;
 Mon, 24 Oct 2022 10:09:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K33j=2Z=citrix.com=prvs=28997e893=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1omuOd-0005Z7-Hi
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:09:27 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id efd70cb2-5383-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 12:09:26 +0200 (CEST)
Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 06:09:21 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CO6PR03MB6259.namprd03.prod.outlook.com (2603:10b6:5:359::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 10:09:19 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5723.034; Mon, 24 Oct 2022
 10:09:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: efd70cb2-5383-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666606166;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=grys+4P5GcmRdhTc6X0D2ylf+A8Zr53c44RRir2OzAM=;
  b=Sk0OoIpqXniqCjWayTD5V+HUAROZr2Zx5DBFcVbOIaf8iPuyoNRLvY2a
   V0ok/sRnox1D+brbnI6t6DMjtgMsWE/9AIXOjeqNemcA/eEUzohL/MucD
   dVcvPu6lcstNz04IoK/nriSiLUIGme3fD2lh1aPj8ojT/zB95KG4s7CAp
   o=;
X-IronPort-RemoteIP: 104.47.70.105
X-IronPort-MID: 82462921
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:aTtMjqAxoTXaohVW/8Diw5YqxClBgxIJ4kV8jS/XYbTApG9z3zBWy
 jQYUWyFb/mKYTf3KIogPt+08k9Q6J/VzYUxQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K6u4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kqZ7AeufxoIlpu1
 r9ECGpTZBqFvuaplefTpulE3qzPLeHNFaZG4jRK626cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWIA7gvN+MLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj
 mnH4374ElcRM9n3JT+toijw2LWex3qTtIQ6N7yUptpmumaq7DItMAUmc0uphfO+oxvrMz5YA
 wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4GOQg5AaA4qHd+QqeCy4PSTspQMc9qMY8SDgu1
 1mIt9DkHzpitPuSU3313peZqymjfxccK2AqbDUBCwAC5rHLpYA4jhvLCNF5AqOxptTwFXf7x
 DXihDgzgfAfgNAG042//EvbmHS8q57RVAk36w7LGGW/4WtEiJWNYoWp7R3R66lGJYPAFl2Z5
 iFcxo6Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBO
 Sc/ZSs5CEdvAUaX
IronPort-HdrOrdr: A9a23:v+g6GarbXQuOlbQT7ZtK6S4aV5uIL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U
 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK
 Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V
 KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z
 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdVJsX6t
 M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pWVFZ9l/1pwKpuKuZ3IAvqrIQ8VO
 V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u
 TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ
 zEFEhVsGYjEnieffFmHKc7hywlbF/NLggFkPsulqSRkoeMNIbDIGmEVE0kldemrrEWHtDbMs
 zDSq5rPw==
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="82462921"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BVNtmvCm3dzWdtiTSiz5bjjd6/FqVx5kzhjgGIwKJoINKu5eaeu+UMHaw5CwPOZxcL8aNQT1PFLX3mMTRwAmey2lR690gx5l4IG1UWvZkYC4rsHn8JiYj9IvdO52iiVvYm8LrkIDiwZzQ09Bm6Fu+BYfZpGrBOqjRgIitc9yhrmx8kyojlOfgH2A5WdNQtmOc1i2Iw+Na0aDQWZ3nDNVTg/Nj/+R+miqOwtgJgg0SaO4eUTP3xQ6Rwh4CoWpX/dWXihWrCZodLO7fydNdEQFy8iGs9SFrsrv7xmFU6qRPyhT4DnNfBk/hKOWL4ZNxKvoTs41cleLSozzKR9Xjuaiwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=grys+4P5GcmRdhTc6X0D2ylf+A8Zr53c44RRir2OzAM=;
 b=nPzjEUDyGUObRjBuIQMV/E1zLdFZ/O9jQxmBdqp0vCSChtU8okU/3ToATKGp+nNvjxO6qkDGvCk0N3BFvvRh6RO0oxpqZYsnoqlt1DNqq3kvL1BOL9I38uCSCzun7yUs2+5HnuypaAmgzdQSCUgHdKag+hOa9sqBE3Gp663x5EOt/RULFIzbyRoJezur50pqYrZdFqMAX4yLyDUpBT3kRuec8Y+9BM6VFTPDn4m5dpnkTKJBfU1PRtjeSQmOH/vPHqn84ZCOSYOvMlgDvQZ5e7UTeIduL3dyjYLnE11Dd2IJv4RH+7Ycc+LxMwjRI2IrmwI0KEEGNdP/QZwlZlrUpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=grys+4P5GcmRdhTc6X0D2ylf+A8Zr53c44RRir2OzAM=;
 b=esOvV+xeXFwoHaALAZkE9p6LkaEidGM9ukKC5ys+zX+lUEsBYFGlNxpX06pLk+qbB060RfL2+Ol2030qDHV8tpODufJzip6yWUXIb6Tyz8JT9TdVnCxp6ujPQ8s63dQzuEPa3k9qVjxILwNg/rRV3PJBlHnNtYCdPgPzmG5ytn4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Henry Wang <Henry.Wang@arm.com>, Michal Orzel
	<michal.orzel@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
Thread-Topic: [for-4.17] automation: Do not use null scheduler for boot
 cpupools test
Thread-Index: AQHY5W3J3NgQRSiY5kiY+kL0DoKe0q4ZGCaAgAQA44CAAD12AA==
Date: Mon, 24 Oct 2022 10:09:18 +0000
Message-ID: <0879d7fb-5908-f169-05de-650e801e89ea@citrix.com>
References: <20221021165341.7905-1-michal.orzel@amd.com>
 <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com>
 <a5c6ba1b-88c1-fc0f-9d9d-2610f0fe2de2@suse.com>
In-Reply-To: <a5c6ba1b-88c1-fc0f-9d9d-2610f0fe2de2@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CO6PR03MB6259:EE_
x-ms-office365-filtering-correlation-id: 38ebe710-9626-4b96-703b-08dab5a7d06f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 nnfH+BH/N8AjMMOdctYB1Jwm7M4j8PyGOzA6Xy97hvLI/steZ/ItaoX58RipwxrMHrkNM1s2WZYXlnSdIPVez8phJTCk+ismQpz3oe6IzVBPGihYvFNv6yIIiaZawtmI4obFFGupUhlxE8AX3Uc+03412DzOqk90zh+Snz55kK5B8WIIFYqWy7F3y1uYnnMkPliBuztCyWw4tSSxnfG3Rax6V68LZeQ783ib8ysdosKtFTxQxbhSMFm0Oj5SAGvrHtiVcMit0XAIIUuAIi9lb8+uOGBw2MYBhTo1FiENY0UVaxrdCMzo12eSSuCkxQYzVlMMhqOye3/VFNdD1bcp4jJ6oURS1N0LHshj3ZpX/BtPEeNj2htleLE6/GiXmOOjyNKcDeKeIofl/JIQsrbAdzDo0WOUE397/P/xuSbuubPMLyAJLpQQ+dVfLeO7VjwhRQYwS+j1K4T3vnQsRWpaS20tD2X/WPSxWmwmsU2XFiPffvDefM2YZOUjrr8dANDdT/livm8OP1/Z7PhWxJ4m79mCl+qhmxDFxyZcS75N5rC5WPbIehwIWng3GF+2/LEoUuE3Y7JNq2bs/OiRkH3rDYhkH9iWHP6IlyC9nw6Dl75RFvLlfMEcUSbKCfUuc1gflqOZP9cNjUc+QJ9jDnorh5C0ZuSVtB6eX5H/XTOfoXrG5x6yeQdLHZKYPdCxhY7M44GIE2orE/5Dd2xogXUy/7IuWbVJ/AcKtvDe31qy06ajO0fwivHMqHC4ePSfxhgVqaQGPPUEFdzIZw2da/U8PyWevXtu31HExT6aPN5mW+vBvxjieLHiZg9yj189UWLyqpt/hiYTl4yswmggz8xiRg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(451199015)(26005)(41300700001)(8936002)(5660300002)(6916009)(76116006)(54906003)(66476007)(64756008)(66946007)(66446008)(53546011)(6506007)(36756003)(4326008)(8676002)(6512007)(316002)(66556008)(91956017)(82960400001)(38070700005)(122000001)(38100700002)(2906002)(2616005)(186003)(83380400001)(31696002)(86362001)(6486002)(478600001)(31686004)(71200400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VDJyZWRvaUcvRURIR0tVU3BJbWg0QjdWWVUwMThIN2tKbDJGb2tNUnJZSVZE?=
 =?utf-8?B?SjNMUFhjTzFLSFRoRUE2NmUrbjJXOWpFZytmSHVna3BWT0kzMWkycG9JSVFp?=
 =?utf-8?B?YUJoTndLQkJuZlYzY2c0L0MzdGRZQXVjNXBrR2h1TVlLV1J1MDJSTk14ckg2?=
 =?utf-8?B?Sk5vZWNKby9KQVdobEZkVEowcWo1amJET21HZUhldExkbDBFWWtjdEE5TGVu?=
 =?utf-8?B?T0ZkRUtNdnRlNkVSRDUyOHpYTmgzdmtVL1ZDeTdhR2hHbFJyaXBNRFhVTDEz?=
 =?utf-8?B?T1o4R2lCNVp5eTFDbGlTZEtSbGdveWFwci9sM21rYmxQRXpPSUxWc28yYnVu?=
 =?utf-8?B?MG00em9USkxnZWxPbzhOTTM0MWlHaXVvZEc1NXoyd20wVXBDcVc1dFV5YStD?=
 =?utf-8?B?Z2RXV1JVMFhYcGdnQ0xabDFDTDV5cDg5WjFsMFJNSWZac2hhY28vU0RvMHUv?=
 =?utf-8?B?aGZxOVc5UUcrSk1rd3YzWlpGT0hpVHRHa05qUlVEVHE0ejZjWUlXRUVQbVlP?=
 =?utf-8?B?WEJoQXJ2N0w0STJadWpVUnd1dnFRS1RpdXBNVjZWY3MrVkhsV0JuVEkxVnRC?=
 =?utf-8?B?MnprL1Q5eDVmcmRXdzN3WGJjamdURHpKbjBXZHU5RnExU3hOblZhakdPTDht?=
 =?utf-8?B?ZHJ0dGRWWThEc3kvWVBvOFlDV0c3c1FJNFNpOHpLMzh2S0JkYmJRVDZCcmgz?=
 =?utf-8?B?RTU4WTFGN2tPV2pPcGxjR3VpTXBZQlZwa2FvWExOamtWZWxESDVKL2p5ZTFP?=
 =?utf-8?B?dVdMOHNCb2E2bWpjKyszQnp2NmNkT2E1T2Z2STU4SDNicnhQWEc3N0Q2b2Jn?=
 =?utf-8?B?S1dSN3J2YVpPWlpBYTR3b0ZvL1FGTkNyVFFKTWxDN0R1ZEQrWmFjMlN1cm9K?=
 =?utf-8?B?ZE9PMXUrNmFYeVJURHcwYUJxZGp5ZTJuQXZFdkwxd0NqR1hWaG5XRVpyZyta?=
 =?utf-8?B?OS8xK3Z3eG13TkU5YUUvVCs3cTQzRzgyM200aWxxakJ2Z3J5ZGdwcCtXZktE?=
 =?utf-8?B?OHZGbkYrZU5TMC80TU9pc0I4T0VGQmgxUzcyaWNkeXZVM0RJUkIrS2hZWVpD?=
 =?utf-8?B?emRPbjl4ekdVQmp0Q1M0UFdaUEMxSlhIUzBlUEJSaldRUTNCT0ZGTDMrQmRu?=
 =?utf-8?B?NmFHRHRVK3B0bUgvMFZnL21CazZjSjhZSStZN3grWWFlWXFmZGc3ZW85TkIz?=
 =?utf-8?B?K0htRy9sTk5IUStORTlmYmdNOTdCd0VNbHNOTXNGVUpCNndQMnNFbkRWTEtH?=
 =?utf-8?B?Y29janl5LzlOc253YlU4UjlYODdGM3NVNDNWRHoySUgxTTh1WUhXb2luZHpE?=
 =?utf-8?B?QnZoYUJDOWxtSGtYN1RqcFVMSkV6Q2sxcTQ0T2RNNkgydi9RaDBXVVdHd29R?=
 =?utf-8?B?Zm9aaWlhQlZZS25yVC9uUmtTL0l2aTdWTzBEaFBHQ3hlOTQ5a0tzSHduVUxK?=
 =?utf-8?B?UnpOcnpDSU14TjFnV2Npb2pFY0Iyd21DZlcwNlZLTjJEQkVXRmxjVEFraFI0?=
 =?utf-8?B?MnFSVHRUTk5ETGNOYUVKWG9PTG42VUFJa01QTmZIMHVWKzFlcyt4Ry9icWVW?=
 =?utf-8?B?YjNhTzN1MmYyQW1mcEVVTGVzTTN6OVZ2ekN4ZVZ0NW5aaHBMWFlUOFBPRmh6?=
 =?utf-8?B?WEdPbkRKT2dJMVE5NnUva2UxeGtRWHpjQWllRDJaYVhNK20xelhvQU1YdFg2?=
 =?utf-8?B?djdYQkRsV1Vic05SRVNmQ1FXaUM0TzBrUXdid1c1NU5vWkhpVnZKRU1SVi9p?=
 =?utf-8?B?VU51amYyc0I5V3NYWlRHMjdWUk9mZTZBa25USStIYjY0ak9aUUhoUjBaSEtJ?=
 =?utf-8?B?MWJNZ1FIUk9qTnpWWlFacVlyNmlXb2U1V2kxZEpWUmZFcU9TQmMzMUQ0MjlN?=
 =?utf-8?B?emp1UDlLVE9kcCtyVThXb1k2WmdLYnRrblBYZHdvSGVzeGxoZHRXOVdwbmxY?=
 =?utf-8?B?c1V3TVo4SzRETmE0RjNDMFN5ODZLNnBQOUFFSjZvSzNBaU5keVNXZUdsVUl1?=
 =?utf-8?B?YUlrWk41YnByMlMxZ2VBMmNESnUrVmJ0b0IrRDhGMjFsR05OWXFLOVo4bDlX?=
 =?utf-8?B?NjVPMlRxMVZXZTJHQkpzUEVLdXEvb1pnc1hCT1J0enFoUUtvRWE0d2Zwc2lT?=
 =?utf-8?Q?aPC4ler9LbtarIuGEwtOIyZjf?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0FD87CB89D002742912518B51E91E8AB@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38ebe710-9626-4b96-703b-08dab5a7d06f
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 10:09:18.6851
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uFnRMTaiAYd9KzHwnrLyHo1ggT+Tp/NKVGZyvzGbvawXbqGam+Miy5iuwPms6kJKl6725b06G5xN9HGPVcyxZ+A9ql/Fk+62LxoKtoz636k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6259

T24gMjQvMTAvMjAyMiAwNzoyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIxLjEwLjIwMjIg
MTk6MjEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyMS8xMC8yMDIyIDE3OjUzLCBNaWNo
YWwgT3J6ZWwgd3JvdGU6DQo+Pj4gTnVsbCBzY2hlZHVsZXIgaXMgbm90IGVuYWJsZWQgb24gbm9u
LWRlYnVnIFhlbiBidWlsZHMgc28gdGhlIGN1cnJlbnQNCj4+PiB0ZXN0IGNhbiBsZWFkIHRvIGEg
ZmFpbHVyZSBvbiBzdWNoIGpvYnMuIFdlIHN0aWxsIHdhbnQgdG8gdGVzdCB0aGF0IHdlDQo+Pj4g
Y2FuIGFzc2lnbiB0aGUgY3B1cG9vbCB0byBhIGRvbVUgd2l0aCBhIGRpZmZlcmVudCBzY2hlZHVs
ZXIgdGhhbiBkZWZhdWx0DQo+Pj4gb25lIChjcmVkaXQyKS4gU3dpdGNoIHRvIGNyZWRpdCBhcyBp
dCBpcyBlbmFibGVkIGJ5IGRlZmF1bHQuDQo+Pj4NCj4+PiBGaXhlczogMzZlM2Y0MTU4Nzc4ICgi
YXV0b21hdGlvbjogQWRkIGEgbmV3IGpvYiBmb3IgdGVzdGluZyBib290IHRpbWUgY3B1cG9vbHMg
b24gYXJtNjQiKQ0KPj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs
QGFtZC5jb20+DQo+PiAvc2lnaCAtIEknbSBzdXJlIEkgbmFja2VkIHRoYXQgc3R1cGlkaXR5IHRv
IGJlZ2luIHdpdGguwqAgYXBwYXJlbnRseSBub3QuLi4NCj4+DQo+PiBJdCBpcyB0b3RhbGx5IGJv
Z3VzIGZvciBDT05GSUdfREVCVUcgdG8gaW5mbHVlbmNlIGxvZ2ljYWwgY2h1bmtzIG9mDQo+PiBm
dW5jdGlvbmFsaXR5IGxpa2UgdGhpcy7CoCBUaGUgQ0kgc2NyaXB0IGlzIGdvb2QgaW4gaXRzIGN1
cnJlbnQgZm9ybS4NCj4gQXNzdW1pbmcgeW91IG1lYW4gZGVmYXVsdHMgb2Ygc2V0dGluZ3MsIEkn
bSBhZnJhaWQgSSBzZWUgbm90aGluZyBib2d1cw0KPiB0aGVyZSBhdCBhbGwuDQoNCkl0J3MgYSBj
b21wbGV0ZSB2aW9sYXRpb24gb2YgYW55IHJlYXNvbmFibGUgaW50ZXJwcmV0YXRpb24gb2YgREVC
VUcuDQoNCkFwYXJ0IGZyb20gY3JlYXRpbmcgdGhlIGJ1ZyBhdCB0aGUgY2VudHJlIG9mIHRoaXMg
dGhyZWFkLCBvbmUgZG9lcyBub3QNCnR1cm4gb24gREVCVUcgdG8gZ2V0IGF0IHRoaXMgZnVuY3Rp
b25hbGl0eSBpbiB0aGUgZmlyc3QgcGxhY2UsIHNvIHRoZQ0Kb3B0aW9ucyBzaG91bGQgbm90IGJl
IGludGVybGlua2VkLg0KDQo+PiBSVERTIGFuZCBBUklOQyBzaG91bGQgYmUgZGVmYXVsdCBuLg0K
Pj4NCj4+IE5VTEwgaXMgbW9yZSB0cmlja3kuwqAgUFZfU0hJTSBpcyBleHBsaWNpdGx5IHNlY3Vy
aXR5IHN1cHBvcnRlZCwgYW5kIGhhcw0KPj4gYmVlbiBmb3IgeWVhcnMsIHNvIHRoZSAiVU5TVVBQ
T1JURUQiIGlzIGJvZ3VzLCB3aGF0ZXZlciB0aGUgZGVmYXVsdCBpcy4NCj4+DQo+PiBBcyBOVUxM
IGlzIGV4cGxpY2l0bHkgdGVzdGVkIGluIENJLCBpdCdzIGNsZWFybHkgc3VwcG9ydGVkLCBhbmQg
cHJvYmFibHkNCj4+IG91Z2h0IHRvIGJlIG9uIGRlZmF1bHQuDQo+IC4uLiB0aGUgc3RhdGUgb2Yg
dGhlIE5VTEwgc2NoZWR1bGVyIHdydCBpdHMgdXNlIGJ5IHRoZSBzaGltIGhhcyBiZWVuDQo+IHB1
enpsaW5nIG1lIGJlZm9yZS4NCg0KTlVMTCBpcyBleGFjdGx5IHdoYXQgdGhlIHNoaW0gd2FudHMs
IGFuZCBpdCBnZXRzIHRob3JvdWdoIHRlc3RpbmcuDQoNClRoZSBvbmx5IHJlbWFpbmluZyBwcm9i
bGVtIGlzIHRoZSBwYXBlcndvcmsuwqAgTlVMTCBpcyBhbHJlYWR5ICJzZWN1cml0eQ0Kc3VwcG9y
dGVkIGluIHB2IHNoaW0iLCBoZW5jZSB0aGUgdW5zdXBwb3J0ZWQgdGFnIGlzIGJvZ3VzLg0KDQp+
QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:22:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:22:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428819.679352 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omubZ-0007xo-Ok; Mon, 24 Oct 2022 10:22:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428819.679352; Mon, 24 Oct 2022 10:22:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omubZ-0007xh-M5; Mon, 24 Oct 2022 10:22:49 +0000
Received: by outflank-mailman (input) for mailman id 428819;
 Mon, 24 Oct 2022 10:22:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omubX-0007xZ-VL
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:22:48 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2075.outbound.protection.outlook.com [40.107.247.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cdba9596-5385-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 12:22:47 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU0PR04MB9441.eurprd04.prod.outlook.com (2603:10a6:10:359::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 10:22:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 10:22:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdba9596-5385-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zx0rF9MTZ9XPZX8nbVmNQFDsEF3GndsGNNH7eVT0p6PnMdrc3ax51bSt4tsAcWrz11BePpkqGp7y7X3M5OAOhsNlHzC7iULAbrw9IwRzw0tIvTmCImpJeDlrp8voKYWvnyjf4PKeSg58f6H+ya3pzh69CX3HhuAVEZtUXLeeFik93VudEh0qnGA+FI9dXNyiibZHDiHCrE0wx94gJXqsQVmWeNr1hIGqoIaTtIGZbWXr5BtKCOFy4FjvwoZjBLjAy+nyll2rCVSHXVhh5Q+3pX0lQjnDTvayJaXcYB0xB92nJ5hbZW3aZvzsPxJhQ0Inqflc7W4OjDMdQXj+EO9YOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JrsT4oz+McSEWWlkWatxfRsA6DzxpFX4soqNNQbN5vc=;
 b=DTL858Kd/JOssYsjaHiOw4qRkYCD6zNSXzaObSplC/9/7PZd6AkV+y4dqPL4OXSjsbAzesZB1sVQMlen4akZ2vPXo31Lh9/+J1c/EA9nrIPM1g5Xl3nVnlG6nYb0D4YWjTxaIT07PkW2w9FQ845OI382SjvmctIGtmcRnVpPxQO7+WyZp1LdM7wsf0AC3CPF7tg6leLV0bwCBV7MTvk+fa7Cdk7/l0wsN2fypVBranlstwShgrFApYjOApbk4pU0t7yGDrQVUpnyg+GpxrrELHDUrSBEX8Rk7JvVGZeSEqzZk/0/dTF7FATe3Jc0ozNKVIgHfhNQ4TAVaxkbYpP1tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JrsT4oz+McSEWWlkWatxfRsA6DzxpFX4soqNNQbN5vc=;
 b=ONHN+g808Hfjb0FlDJrq2cnUFmIcldEGRm3s5mND0oyIe/UFS/C09SRSMSdHTtRwQ1paztMEpbfsfi0X35xEcwB7ClrBhlNg9zqMbvbBMMKuXg+3omQiJw6biHZUU82H4pwP6lKro6EJG1aCaLj3sXSptQiSNkAjkXC0+mg9c5Qai68kYyHLmpHAeYgyWc1XP5gBK41Dr4gTRKrGLiWC+0LOuhcL85f9IBKgCJK378FMM5X/am1wmIhHmBlKasew8HGQv7bfbjYWw5nXcgImul0ZQ17FadFe0cLR3Vv9Kbr8wTvvln2hXbkl0ut2iPGzCJ1uzCs0x7DnViWIBY7sOA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0ba35141-c31f-5f0c-f9bb-26a07bad0edb@suse.com>
Date: Mon, 24 Oct 2022 12:22:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2][4.17?] core-parking: fix build with gcc12 and
 NR_CPUS=1
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Henry Wang <Henry.Wang@arm.com>
References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com>
 <61e8475d-868d-3ff0-041f-8f6790990ce4@xen.org>
 <8b2d008b-526f-dc36-71d6-81b653bbf467@suse.com>
 <b9868745-8e8a-01f2-818b-2efe7b5df5cf@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b9868745-8e8a-01f2-818b-2efe7b5df5cf@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0037.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9441:EE_
X-MS-Office365-Filtering-Correlation-Id: 8ac8ac18-bcf2-4386-86c7-08dab5a9b0a5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0HIkQ0WjL6cmMSxBDJgVy0VrLDKZUvG5MkX9IibQbYTIv38JH4BD60YjwBao8ReP5Nlbnl0JV5lIj6BM6hsoCeecYa3uYWSZm+YbpjW53aWPqMdUjMm69ea6JvNUaoLlaAzFwhMs7ErEFocOfdN109Rot/h1c+sZ8TcIOu/o6I+freHe8Ru2sZIbZVPl/pWSIuysRaAaHB3mZlMG7OUzdsUSpCvSRY0i0R1L53T0HqkNiGj0GGtW3ZuuTzX2NXkKTliZ6BHWFpGZs7n5Np1adcwv/5wMkahlIX8MzbbYGVcHNYQCqhc8TFoGA+zdarH9Sa3TUHF7tdfpV8UILJNLnxdqgA+TPbMq9bwqSl7EtLRT/vgtJWzps9QFXnK+mBGrL7KpljrW3LWmV9PZ/Eliwgq4rXz/rBIcRSRf6yqSqaK3sVk9AuO96S2ovZs1VokEsojna7C0115eWd1knS/ZM87+S19sAnTWECoLupeQjTh3p07VHlrla2LulGDdbPeoHo0Xw3+aqjKoAwKyyGtxdYzHr74BQ6wIRY7pjDEHETP2tQeS1h7EMQS8YNGY2pPaoiCmVtPXQ/mFvSO8bAWsJHTd2YQ8MzrXOv9j/QK8AavZOHs4JbcUI5hL4M3J74yxqfDQUvuKgtrFAl4PCgpfDUx5F/L4yFluhg48SVTB6E3OAnAfveph5bnjkZse/iWQfV7OFaoVGKglHGt/eSyDqRG2ycpb9kAJqRK4Kno108K8OqPltwbdTU8SuuEZuFXBzTNXLaf4MGBKPnBAjwXKnNkI21Ydzoyo4LmloO0lboQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199015)(31686004)(6506007)(316002)(53546011)(6512007)(26005)(54906003)(6916009)(36756003)(4326008)(8676002)(66476007)(86362001)(31696002)(66556008)(41300700001)(66946007)(8936002)(5660300002)(2906002)(478600001)(6486002)(83380400001)(38100700002)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aFBZNHJGSWdXdnpxM0dYUDdjSzcyTGhDaWJyeGVGL2J5UDF1aG85UkVBTWZm?=
 =?utf-8?B?NC9Nc3FTMkJMNG1LWHZBcVo0QXo2NHcxUkRLbXpMUXczRXVkSnJLNGVLaGZZ?=
 =?utf-8?B?N1JleGZhYngxQXc2UzdvdmlINU1IRjVBUG55ZUJwVzNyRmQ0dVF1UVF5L2pB?=
 =?utf-8?B?WTBqTGI0OU5LTVhXRXNmWEtsUXVjcGR5dEhzcmRaSXhBanVFSnJSRGJyNm05?=
 =?utf-8?B?VVI0RFQ0RWlpWUp6L3JYMW43UDk3cEVoMk1GbFBvMUw4K1VkZXlaMWZhZzhm?=
 =?utf-8?B?VzRaVWprYnhnQjgyT2l3TnErajVEU291MGc0Q1QyTkhaTGlpNzhxaWFsL01i?=
 =?utf-8?B?TitUWUZlMTRaMjdoQkNCYUpEMzg5Nlhqb2tSUVVySitOcTRLYzhsaUFGczFl?=
 =?utf-8?B?bEtKS2ViMzg2ZlpmYWtMRS91cXN2SnNKTDdXTlpLM2NrZ3Z3Vkx2ZmxqLzc3?=
 =?utf-8?B?OTVXU3AvSE84MnlyOUdkV3R5OTFucmQwNnIvcHh0cG1WNHFsdVdBa0RtYXk0?=
 =?utf-8?B?TUZlY3UxSWlYSWlvcDRMQWxNWlQ3UmF1MEJaTG5BbVhmMCtlWUFDRUVld2ti?=
 =?utf-8?B?OHZkRk9CQjBKWXFKaVByZVlnQ25XVFVYY3ltWGtaUWx3WVc5WSswS3pyWkdn?=
 =?utf-8?B?aC9SU2Q3bHp5OGlmL2RqWU9udWxMb1QrODR0dHU1Y05GR2U1SmNYTThPTHlt?=
 =?utf-8?B?cFUvbWNlYS95VlhBNmRpa3Zmcm1BNnl3ajNTcHlwZ3drQ1ZUbnpkUGx5emR2?=
 =?utf-8?B?dTVZRWxkc3NueEJXcXZjVjd2c1IvdXJYbjZEb1YyeE1VdXFVMktndW1yYVVZ?=
 =?utf-8?B?WU9ZaWZ0Q1ozUldOMDkvN0ZjV0g3c0ErWHBDUlE4Rk1pMTlPVE1xOUNRYjhx?=
 =?utf-8?B?anJWTWduMEFleEF2R2piN3d2cSt4L0MxZlVvN2JhdGVMVGt2SnFpRzdIanV5?=
 =?utf-8?B?T3lsa2tHczZrL3ZlZkVyWFczaW5oUXpiUkVGUk5ZeFovbklLMk5PS3lVUFBS?=
 =?utf-8?B?YmhUaTBiekVmMzdiRDdJMDdZTWhrSzB1MEF3SEIwZHNoV3M5NlA0SWR2b2Fh?=
 =?utf-8?B?Ryt0WlpCa1pjQzk3bTRpbEVmZjVQQnhJMFl1aWRCcmY4YW9jYjJjQVBUNmJH?=
 =?utf-8?B?Um9YT096dVE3aE91YXlUV1JWcXZzbDFueXo1RDhZRzNsQUhXSWRkQlZtczVk?=
 =?utf-8?B?MzQ4YVpLc0F4ZmpXbVZ1bU9JNHBFazJZSjhHREFjSU1SM0xtZ1YyRUJMSW01?=
 =?utf-8?B?K0dIekZ1bFdsUEliNmpxUFZnK2hpeDgyVVhhbnQzQVJGdFNLckFoK2ZvUFJx?=
 =?utf-8?B?cEpLdzVudFJ4dlI0eUFlUWJQcWFvbTdJM3hUSGdabWhZMUc0RVFnWi9FdHNL?=
 =?utf-8?B?ZERKL2E4VkVRL2FOb2FJZ0FtVTJ3MVlqU1dTaERaeUxzdiswK0ZoUlBJYklS?=
 =?utf-8?B?OVEvM2dtNHk3YnJoY0tPb2wrSllTQmsvbmJjeHlXQlFTVjhpOThhN3poR21n?=
 =?utf-8?B?RzdxMGppa1MzSVVNZFAvNFhKakwzVFkrRG9xZHlzdzhHbG1iZ1Vja2VRbGh4?=
 =?utf-8?B?bXR1bXM4NW5iRmp6SGhqSW50NHhFMnJQcVpaT0ZuTy9xOHVGMFpMOGpUMnhG?=
 =?utf-8?B?OHpLVUdubS9KTlpPMS9QMWVXL2I1M0xZM2FUOTloM0FRb2MydUk0M2EyT1Fs?=
 =?utf-8?B?UStPL3liV2R0NWpRUndhRVVGdGtoNXNTSEJXd2d3VllsZk9Fb0lXM2lReWw3?=
 =?utf-8?B?YmUvYU5ZeEl1c2lXdkxDbndYek1sbDduN2U5aVNIaHMwdE5GWDBQSWF0Q2FN?=
 =?utf-8?B?WE43NG5uSmdBdTdna2diMWQxSkhPMXZpTlZOT291cFpoR3VjYUErVmlKQjFH?=
 =?utf-8?B?WDdqeTFVNytUVy9KR0d0c2w3MmJJVU1QZmNaUXFBTFNEMG9iTElEUllhSlFC?=
 =?utf-8?B?L0FwVTJHM2ViSks3cXNKNG96RzlLaWo3Y2doRE1DN2U4VjBZc09QamFtTjJ6?=
 =?utf-8?B?bHFnSUlIL3Zlbkx0WmFkaFNRSzQzejhHNmtieTZFT2h2Q044bW1EKzlJZm04?=
 =?utf-8?B?dFczdUlWbDMrREhhVjRJTCttUGN6M3NUSjlGa3RuWUlaaGJUSE9ZdmlBWXl2?=
 =?utf-8?Q?NTU+9SlOPkr6ItQRvB8Xc3BQO?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac8ac18-bcf2-4386-86c7-08dab5a9b0a5
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:22:44.6272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ZEIwQ7Ott+6opsepmXe5UaVbhL0OxM2BZ0BN5/4dzBb3ESgfiWfpzNWRzLBbr0MQRYhW9cnHDYZsXTCHz99VA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9441

On 24.10.2022 12:03, Julien Grall wrote:
> Hi Jan,
> 
> On 24/10/2022 08:26, Jan Beulich wrote:
>> On 22.10.2022 17:30, Julien Grall wrote:
>>> Is this intended for 4.17?
>>
>> Well, yes, it was meant to be - it has been ...
>>
>>> On 09/09/2022 15:30, Jan Beulich wrote:
>>
>> ... well over a month since it was sent.
>>
>>>> --- a/xen/arch/x86/sysctl.c
>>>> +++ b/xen/arch/x86/sysctl.c
>>>> @@ -157,7 +157,7 @@ long arch_do_sysctl(
>>>>            long (*fn)(void *);
>>>>            void *hcpu;
>>>>    
>>>> -        switch ( op )
>>>> +        switch ( op | -(CONFIG_NR_CPUS == 1) )
>>> This code is quite confusing to read and potentially risky as you are
>>> are relying the top bit of 'op' to never be 1. While I am expecting this
>>> will ever be the case, this will be a "fun" issue to debug if this ever
>>> happen. So I would suggest to check CONFIG_NR_CPUS == 1 separately.
>>
>> You're aware that we use this pattern in a few other places already (I
>> guess in my local tree I have one or two which aren't upstream yet)? Just
>> grep for "switch[^_].*[|]" to see them.
> 
> I could only spot two upstream in arch/x86/hvm/svm/svm.c and 
> arch/x86/hvm/vmx/vmx.c.
> 
> But I am not convinced this is a good enough reason to continue to use 
> this approach. There are a few bad code examples in Xen and we have been 
> pushing against continue to spread certain construct.

Sure. But these were introduced consciously and deliberately, iirc.

>> Also note that it's not just the
>> top bit of "op" - we merely assume "op" will never be ~0.
> Yes, I misread the code.
> 
>> Personally I
>> prefer this way of coding the logic, but if at least one of the other x86
>> maintainers agreed with you, I'd be okay to switch to using a separate
>> if().
> 
> I am curious why, is it just a matter of taste?

I think so. It's not written down anywhere that such constructs should
not be used.

> If you really want to go down this route, then I think you should add 
> "ASSERT(op != ~0U);" to catch someone introducing a value match that one 
> we exclude.

No, such an assertion would be checking user input; a caller might
deliberately pass this (invalid) value.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:41:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:41:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428834.679371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omutJ-00024b-JW; Mon, 24 Oct 2022 10:41:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428834.679371; Mon, 24 Oct 2022 10:41:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omutJ-00024U-Ez; Mon, 24 Oct 2022 10:41:09 +0000
Received: by outflank-mailman (input) for mailman id 428834;
 Mon, 24 Oct 2022 10:41:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omutH-00024M-Ri
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:41:07 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5ad09b98-5388-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 12:41:02 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8435.eurprd04.prod.outlook.com (2603:10a6:20b:346::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Mon, 24 Oct
 2022 10:41:00 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 10:41:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ad09b98-5388-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G3O3udprfWj6SyhVCK5ZuTOiEXCT4qEPAn1CyriG+v9QE7fJk0wmNZS1PiAgZfA4/ZA8wCF/Ifof+zk93wNpfCuKGNKrz7IxQApNvMKK7+yrin1dLTtQ0YLTQqLu7CwmUuIQbGOc/eTb2yKmbI36s/NGzP9jXgLoCJadODEUCaK4ainR5nHQiVKwTnjs60laU2iaTzXu6uchAcLOE6ckbn3+XLvHMZUFPhAGp9esceq3gydwaL1Ek0QhjCl2MwMPClTFO1TtjmF4v5SfO2CbvXe4wrcl+3Bt4Kmp+X2oK2qVBimsMngybBz5K5mtk1OJQ1ycUZ+wPJ/cBQvF9SenEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jh+J6624ZaVZldKM+fCNAYKoBTLef+wSp6DgeWmBK04=;
 b=DUmGvty1S27iZXOIykAN3k6kmKx2uH4BKvS3SnwqK+HL75hKKAhlPEVMmNQDgI3v65kVJSfCCHiQP7Zd0BL8jl1ol6AIb4N0DkKbjjXgm7LjyVoU61+sC7EY4Z6eP1LWjeVci4jzVm3OQQ9t4LhN1Zz+A95iJcW8ZGzhP3F3qRvX6h6XVdhZrco9PwckroWKD25dsvIKXmzREQy9mzGborCUvqt+XecSTPXCN01W6Dg5LCZaYmtq4SqkCd1C7Xp3nrnTsBQCNyZteksvdF6oUOlprWcN02K280ixdjNCZCKarXlmhwnO7OYU5PdyJ/uZTGqFRM0HxPQ3bV2w6wwo5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jh+J6624ZaVZldKM+fCNAYKoBTLef+wSp6DgeWmBK04=;
 b=0B6yaaSN0OPM+g7afdAD4EhJudSpQPzu/d8usSJfsrW6AyEkyaG94iadsOWGWYozbIrOOgS3unf4cDmhZa2/AUcr5dIOfWW7bHQ8PGSgGyT1vCL4DRSYsMHFo8Bg0zGjXnw1KeQK6qM1sImsyzNTJK6s5P7FRvNruzqDNkFz4qynkjpVjyNzQIpwq0N0i25T+/0qI3Im14DS6swQogy1TbJlwgMXDTxc/0OdX1n4iqkScMm+uyj9weKn2yZ9npCE7S7UgQFwgmAKc+oJMCITS8MEjslSBm7lQ8BePobQzAOYgS+HlWF6llezhjlNpDTaeTvQe+n7muQ8+b1FUkZFgQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <832b338a-fee5-6334-b91c-d492f3179c8e@suse.com>
Date: Mon, 24 Oct 2022 12:40:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: Intended behavior/usage of SSBD setting
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <Y1Eqk6D0dBDR4m4u@Air-de-Roger>
 <8c7de7ed-6242-f444-55fc-9eb16084b7bf@citrix.com>
 <435610e2-4fc4-6a9c-3fcc-c6d6ab42cdc1@suse.com>
 <Y1ZbyK3ynB0WYS3s@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1ZbyK3ynB0WYS3s@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8435:EE_
X-MS-Office365-Filtering-Correlation-Id: 0d4161d0-6207-405a-3054-08dab5ac3dd8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rsgMbjNpsry4Hgsoi/qPn9LrGVoDKvC4ZrygprxoxflJihTJxqVYIewlXw4GWVOCi5fpk+QZqbZhQ7H0fzmFW9dJkidhw5fj4P5slEczm5Kb/MKj25bckTBr/Lo+AA86JTY5kZR5ZzMTQGmb0IK/C3unXCbR8AZJFX4iNpfD2qlITJWqko8jlI+S3ROudoDPrJe9kf329Iw5PdsaKpTlxU3/pgZ3aWJ4sZS0pOXDxh4OpXNznl3u/J0DVf67f3ehE02uHry2zYEk5eEiYhb3VSPmvyibI/zjP7zt6MX+0D9Fe52FxNT4Jbk6NIJBEl1MOoglIGk21EHnfg31auYS93CSDeFVlSh0IY4EdfcytU20oCoZUlgSoEAwwKxEBegZY1CVWJFUVFUdmq1y2v+cfuLDqDRj7ULaYqGVAunCGESTe8bnXQbQUyhnaowDjboBkHtd3draLqYItKMVRit+KW+LyuNyTigUCwaRL2sUB0ws2zBxhzQGdLdOMv0UOkPKv5YsL6fQ3aZaon9GZ8MdobVQs51Ne2gYC4XcUvZHLYmbbdPbjX0cK2kRkhNgWwEV8itl3amVWLEOjhTKJJ8ekKnjBAvHCRt3Hj6OYlrUfZFWB4QV4Ymm2AA9t1K4syKgWxtj6PZg5+DqocuxsQ67p83La7in50aYluUvv5NJDOvCondmzTiONWGEslp+MgPhCg2rNrNQqfx8yf1pzrDWBF95P/0blk5L/K090rO5fHc/ICCmSH4UPljh/pObCUiBqQ00WoNgNxCwgCtqsOowLYBZJO7lozNNIeOs3IHjAkdoiqWO9q/Tjou8B0C6+VQxt8aCb7lg2YQ1HOt6LeCKAw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(39860400002)(376002)(346002)(451199015)(41300700001)(26005)(66476007)(38100700002)(66899015)(8936002)(4326008)(66946007)(66556008)(31686004)(86362001)(31696002)(186003)(83380400001)(966005)(478600001)(6486002)(6506007)(2616005)(6512007)(53546011)(6916009)(54906003)(316002)(8676002)(2906002)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c1E4OTZNb2xDSkZuYnA0L2RhMVlERmV4U3RpZ2Q4VnFaSXNQQm80OWdwTDVM?=
 =?utf-8?B?RVgzOFpualNxcVl3a05MNXRDVkViUXZyMUNpV09qaUg3ZnVIOWhiWnR5QUZx?=
 =?utf-8?B?Z3UrVjlKYUJ6dnYrWXB5em4zODBEUkhNUDBQNTFyZVo3VzJsK0lZQjRhREV2?=
 =?utf-8?B?aTFzS1hFb2RQeTVRMkpES3NGdzk4S2kxUEtKdGVLejcrMnZaUGc3WUprZlVa?=
 =?utf-8?B?bTY2WUk1dis4WTFGQ252QnoyRTgyMmluYmhMRHFFSU4zZm5QMk56allWc0pr?=
 =?utf-8?B?R3VQV2VwRXEydFpHcG5ETmIreU41cjdhVklMTmo0OXBMdk9wUEdqeU9jZ3lv?=
 =?utf-8?B?aVVyT0FsRU9yL0J2YTc3M00rTHpKWWRreDB2bTlzdlRGSkVucEJtL1hiS2RU?=
 =?utf-8?B?OUYxQS8zc2FXbkhOdkFjcXBweDFmelIyMEMvYnhhWW55bThDOWQ3dWVNdDVN?=
 =?utf-8?B?YlZ2d1ZZZngyekZ6OUxXWHlxZTIxQzYvV3lqOU5ObzU0Y1ZWdkwwTE41WENm?=
 =?utf-8?B?VVVwZmY2NWVXK05VRFUwWTJvaCtwTU1NcnVMcHhHb3J3SjF1cFoxNGdjcWE2?=
 =?utf-8?B?cUIwenlYUUJvMkxpcDJMcW5WcW1sam1iOTNLQ25KY05rM2s4YkFYR3ZqUEx5?=
 =?utf-8?B?OUdiZjB5STVWZlZBWDNVb0xqVkZtUFZEc3BvenE5dUNnL0xrdm8zbjV2NlNl?=
 =?utf-8?B?aWRveVFaMFMxZVBWV3oxSFRTYVdIVS80R3p2Mm1uVWZSZ25HN3FwTlVCd1V1?=
 =?utf-8?B?MGJ2RVJCMHBYOXM1dXRERjFaaXRZak91bW5GejNkSVlYTWFzbHdTSFI3VExH?=
 =?utf-8?B?ZSt5VUdKdS9zemhKVjlYQVFOZlB4djNCbWEyd2ptdlMrb09aR1JSakcvb2Zm?=
 =?utf-8?B?bUJ6dXkrYTByY3k5R3hVeCs0M2pVVjh4Q0xZMnRaYVRZdzM4WTMyV2dSSXpW?=
 =?utf-8?B?ejZYb3ErQmZyeHRhTXliaFhQMzZqNTA1OU1aQXdnTk9VaXRvMkhwMlVYZkpV?=
 =?utf-8?B?RENVVGV6YmtzQ0FQNVJGdGxaNVFNQm43SVVTdlVBL2RRWEkyUGIzL1p0Q3JI?=
 =?utf-8?B?M1hHV3JKK2JxYUU3OU4wNVByN0dwOGdDZk14MFFrajI1RXE1cXNNbFZDVlhT?=
 =?utf-8?B?VUZkL0piL2p6V1gzdzg4TlowWUN2WlFvVys3blYrS1pFMmQ4VHRRc1lnSUpm?=
 =?utf-8?B?V1pWQnpYVFY0NjdFemJtOUVkRzRndCtlTmtpVHpoSXdjNjkwbW9QVXVwcWxo?=
 =?utf-8?B?TUxYczBpSEVUcVU1Qm00M3FGNEg2MDg4T0pOdDRaeUFjNmJ0QmtxeVpZRVBh?=
 =?utf-8?B?NllkeFFVNlFkUnR1aDhPMzVDeHk5VlVqQVB1UzY2dzFGNW5uRHNSSjQ4SXVR?=
 =?utf-8?B?cnp1RTdpZ25uUWZXK1NjalUyR1ZTUjFoanB3dlpyT1VhbUJHRVIvNS9ka2JM?=
 =?utf-8?B?eEdISkswVk90emEzNjM1K0JDL2dmUkxhYjVhQWc4ZHRIRWlVa1Z4aktEMTN1?=
 =?utf-8?B?ZHQ1UE1LdWowV1I3S29INVUwMGRRZTBIV3psVUdZenlBRStWTTBVK3ZBWVM4?=
 =?utf-8?B?L05XcWxxeS8rMDhRT09zd2h1UUJjek5UMjFOLzd0RzhKSU41V1hJU3ZLTXdt?=
 =?utf-8?B?dC9xaWpBeGhuUnhRODBtZmEwWW9ncTJDUi85cStyOFlaNGZra0VXMmVpL0RK?=
 =?utf-8?B?RkpWUlBxbzVQMnl0OFFJQ1NBYlZkVnNDOHRMMzkrcFlMbHdYampzamxXVUJU?=
 =?utf-8?B?bWVPb1R1OTEwNHpyREROUlRkNnlEek5yTGQ2cTBpUG1rWXQ1dVhZTE1tNEJG?=
 =?utf-8?B?cW03RllUaXZLRVQ0WTJYbkFHQXZGSWcyUHNvTEFDUW96L200M0tCUWIzUjVj?=
 =?utf-8?B?WHlZZmphek84ZDJzb1RuRzRPOFRidE96QzJ6K1p3Mkh5K0VDSVl0Z2tBYUJD?=
 =?utf-8?B?YkhCVlNCOXlxbm9pWk1QL0NNQWo4Sk9sNEErbGJCNlhKY0p2eVlIaWRDMW5W?=
 =?utf-8?B?aXptaS9VWmZQb0lmWk5XNTFjTzZobzgwSndDaGdFT1J6WkRaOElsNHlzQzMz?=
 =?utf-8?B?aGJXRVE5SnBqMGdkYThlZFh1cDBtaVNWMzVBUks0dFdOeTl1cGMyalR1aHR4?=
 =?utf-8?Q?bft1W4IrGAs8A2IZVsoA6IILi?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4161d0-6207-405a-3054-08dab5ac3dd8
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:41:00.4177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K5CvPtzStToIjfeaEh6aeXeKhkMLKKVdmmb/STlKiRyMbbyOCmvn3eZRCje1n3vVEuYmDmJNtaM0LoQAFzajXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8435

On 24.10.2022 11:32, Roger Pau Monné wrote:
> On Mon, Oct 24, 2022 at 08:45:07AM +0200, Jan Beulich wrote:
>> On 21.10.2022 23:54, Andrew Cooper wrote:
>>> On 20/10/2022 12:01, Roger Pau Monné wrote:
>>>> Hello,
>>>>
>>>> As part of some follow up improvements to my VIRT_SPEC_CTRL series we
>>>> have been discussing what the usage of SSBD should be for the
>>>> hypervisor itself.  There's currently a `spec-ctrl=ssbd` option [0],
>>>> that has an out of date description, as now SSBD is always offered to
>>>> guests on AMD hardware, either using SPEC_CTRL or VIRT_SPEC_CTRL.
>>>>
>>>> It has been pointed out by Andrew that toggling SSBD on AMD using
>>>> VIRT_SPEC_CTRL or the non-architectural way (MSR_AMD64_LS_CFG) can
>>>> have a high impact on performance, and hence switching it on every
>>>> guest <-> hypervisor context switch is likely a very high
>>>> performance penalty.
>>>>
>>>> It's been suggested that it could be more appropriate to run Xen with
>>>> the guest SSBD selection on those systems, however that clashes with
>>>> the current intent of the `spec-ctrl=ssbd` option.
>>>>
>>>> I hope I have captured the expressed opinions correctly in the text
>>>> above.
>>>>
>>>> I see two ways to solve this:
>>>>
>>>>  * Keep the current logic for switching SSBD on guest <-> hypervisor
>>>>    context switch, but only use it if `spec-ctrl=ssbd` is set on the
>>>>    command line.
>>>>
>>>>  * Remove the logic for switching SSBD on guest <-> hypervisor context
>>>>    switch, ignore setting of `spec-ctrl=ssbd` on those systems and run
>>>>    hypervisor code with the guest selection of SSBD.
>>>>
>>>> Which has raised me the question of whether there's an use case
>>>> for always running hypervisor code with SSBD enabled, or that's no
>>>> longer relevant if we always offer guests a way for them to toggle the
>>>> setting when required.
>>>>
>>>> I would like to settle on a way forward, so we can get this fixed
>>>> before 4.17.
>>>>
>>>> Thanks, Roger.
>>>>
>>>> [0] https://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#spec-ctrl-x86
>>>
>>> There are many issues at play here.  Not least that virt spec ctrl is
>>> technically a leftover task that ought to force a re-issue of XSA-263.
>>>
>>> Accessing MSRs (even reading) is very expensive, typically >1k cycles. 
>>> The core CFG registers are more expensive than most, because they're
>>> intended to be configured once after reset and then left alone.
>>>
>>> Throughout the speculation work, we've seen crippling performance hits
>>> from accessing MSRs in fastpaths.  The fact we're forced to use MSRs in
>>> fastpaths even on new CPUs with built in (rather than retrofitted)
>>> speculation support is is an area of concern still being worked on with
>>> the CPU vendors.
>>>
>>> Case in point.  We found for XSA-398 that toggling AMD's
>>> MSR_SPEC_CTRL.IBRS on the PV entrypath was so bad that setting it
>>> unilaterally behind the back of PV guests was the faster option. 
>>> (Another todo is to stop doing this on Intel eIBRS systems, and this
>>> will recover us a decent chunk of performance.)
>>>
>>>
>>> SSBD mitigations are (rightly or wrongly) off by default for performance
>>> reasons.  AMD are less affected than Intel, for microarchitectural
>>> reasons which are discussed in relevant whitepapers, and which are
>>> expected to remain true for future CPUs.
>>>
>>> When Xen doesn't care about the protecting itself against SSBD by
>>> default, I guarantee you that it will be faster to omit the MSR accesses
>>> and run in the guest kernel's choice, than to clear the SSBD
>>> protection.  We simply don't spend long enough in the hypervisor for the
>>> hit against memory accesses to dwarf the hit for MSR accesses taken on
>>> entry/exit.
>>>
>>> The reason we put in spec-ctrl=ssbd was as a stopgap, because at the
>>> time we didn't know how bad SSB really was, and it was decided that the
>>> admin should have a big hammer to use if they really needed.
>>>
>>> When Xen does care about protecting itself, the above reasoning bites
>>> back hard.  Because we spend (or should be spending!) >99% of time in
>>> the guest, the hit to memory accesses is far more likely to be able
>>> dwarf the hit from the MSR accesses, but now, the dominating factor for
>>> performance is the vmexit rate.
>>>
>>> The problem is that if you've got a completely compute bound workload,
>>> there are very few exits, while if you've got an IO bound workload,
>>> there are plenty of exits.  I honestly don't know if it will be more
>>> efficient to leave SSBD active unilaterally (whether or not we hide
>>> this, e.g. synthesizing SSB_NO), or to let the guest run with it kernels
>>> choice.  I suspect the answer is different with different workloads.
>>>
>>>
>>> But, one other factor helps us.  Given that the default is fast (rather
>>> than secure), anyone opting in to spec-ctrl=ssbd is saying "I care more
>>> about security than performance", at which point we can simplify what we
>>> do because we don't need to cater to everyone.
>>>
>>>
>>> As a slight tangent, there is a cost to having too many options, which
>>> must not be ignored.  Xen's speculation safety is far too complicated
>>> already and needs to get more simple; this has a material impact on how
>>> easy it is to follow, and how easy it to make changes.
>>>
>>> It is the way it is because we've had 6 years of drip feeding one
>>> problem after another, and haven't had the time to take a step and
>>> design something more sensible from having 6 years of
>>> knowledge/learnings as a basis.  There are definitely things which I
>>> would have done differently, if 6 years ago, I'd known what I know now,
>>> and part of the reason why the recent speculation security work has
>>> taken so much effort is because it has involved reworking the effort
>>> which came before, to a deadline which never has enough time to plan
>>> properly within.
>>>
>>>
>>> So, first question, do we care about having an "SSBD active while in
>>> Xen" mode?
>>>
>>> Probably yes, because we a) still don't have a working solution for PV
>>> guests on AMD and b) who knows if there's something far worse lurking in
>>> the future.  Sods law says that if we decide no here, it will be
>>> critical for some future issue.
>>>
>>> But as it's off by default and noone's made has made any noise about
>>> having it on, we ought to prioritise simplicity.
>>>
>>> Given that off is the default, but we know that kernels do offer it to
>>> userspace, and it does get used by certain processes, we need to
>>> prioritise performance.  And here, this is net system performance, not
>>> "ensure it's off whenever it can be".  Having Xen run in the guest
>>> kernel's choice of value will result in much better overall performance,
>>> than trying to modify the setting in the VMentry/exit path.
>>
>> My takeaway from this reply of yours is: By default run with the guest's
>> choice, while (I'm less certain here) you're undecided about the behavior
>> with "spec-ctrl=ssbd". Please could you make explicit whether this is a
>> correct understanding of mine?
> 
>  * spec-ctrl=ssbd -> SSBD always on, expose VIRT_SSBD
>    (VIRT_SPEC_CTRL.SSBD) but guest setting won't be propagated to
>    platform.  As a future improvement also expose SSB_NO in that
>    case.
> 
>  * spec-ctrl=no-ssbd -> Run hypervisor code with guest SSBD selection
>    depending on hardware support.
> 
> Default to `spec-ctrl=no-ssbd`.
> 
> Would that be an accurate?

This matches my view, yes.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:47:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:47:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428840.679382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuyv-0002oe-AR; Mon, 24 Oct 2022 10:46:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428840.679382; Mon, 24 Oct 2022 10:46:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuyv-0002oX-7o; Mon, 24 Oct 2022 10:46:57 +0000
Received: by outflank-mailman (input) for mailman id 428840;
 Mon, 24 Oct 2022 10:46:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OUsB=2Z=gmail.com=liu.denton@srs-se1.protection.inumbo.net>)
 id 1omuyt-0002oP-Ge
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:46:55 +0000
Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com
 [2607:f8b0:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c01eb98-5389-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 12:46:54 +0200 (CEST)
Received: by mail-pf1-x431.google.com with SMTP id y13so4080469pfp.7
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 03:46:54 -0700 (PDT)
Received: from archbookpro.localdomain (136-25-1-99.cab.webpass.net.
 [136.25.1.99]) by smtp.gmail.com with ESMTPSA id
 t2-20020a170902e84200b00185002f0c6csm19475666plg.134.2022.10.24.03.46.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 24 Oct 2022 03:46:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c01eb98-5389-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=l6AhY/GgocFiQsWx0GNRklZOZuEHSlyNVvfWDCYvBt0=;
        b=XEhzvuofVs+dNCgTlS0QKjX/d4rsXWAJPOwktzpAp81cOU/sZbjL4IMDYEH+y7El7o
         wLJSaYMmFNt+75Ze3Kv0wgfIoKbRZGV8A6LsMdhBM2GRiCpnG9kNhnpv3meNNle7EvsR
         kdeNZAsi0T9vkIzNV2sXWFrRAs/GdKBKpqp9EbxntjxgJJEFAN/JGfaxaymw9vDPDWfV
         Ikxn78mXFd9+1aw0Vps66kVSp8tZEB+PlCpxyw27xKX2xvUV4Ijt/bm2E3LIXoqGaiCd
         YkxHRTAHdyI+raELOL9qwMNWlFO8+HpL6th5KYJHDCkBYzL6gtkXW2hVSD3PjMSWnX8Z
         4Nsw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=l6AhY/GgocFiQsWx0GNRklZOZuEHSlyNVvfWDCYvBt0=;
        b=BOw5lZfxG8tgw4+PE2Eg+Qx13+x7tK2xDJANlJlkfkaWXtbIKVPhLhGCGTLLMJbOW7
         aGsOYpNqV0gSj3pnG5vCx4nYVgH1i5Gh/S2DiGg9Se+Hde6JMOHCAEuBIOCMPJ0/9/pU
         ouo/WgZlP7ez2Vxq5Omz/T6CFNv/1J6DSZ6/Ufy5tZ9JeBeYtJ2qUDkKTKBfDO+xalRR
         JZa4WlC+pAPSFFdz9EeS151k2C56CMzTrb81CxKsFGJgNVrCGseI++KV2qEHAkTx0Glq
         W9qntUvKINBWPtEWta6n7wnKpGZFAPgeib1zYYp2mA92kpyYDL9pHL3qlX6ON5ky/AMY
         qX9g==
X-Gm-Message-State: ACrzQf0Ymn18chzR+TUDj0fEPVCOpMdeJrmDVGK1T4KIV6cNocCiqe3/
	5HrIjzjYJoRFB34GarmcIL0=
X-Google-Smtp-Source: AMsMyM4dGhnPStWHW5POV8kLzymbFegcb19ywLGDoRz5SJzAZ0n8VsXrumn6qPQY1KEQSle9OFgAfQ==
X-Received: by 2002:a63:804a:0:b0:461:25fe:e7c5 with SMTP id j71-20020a63804a000000b0046125fee7c5mr28185203pgd.395.1666608412430;
        Mon, 24 Oct 2022 03:46:52 -0700 (PDT)
From: Denton Liu <liu.denton@gmail.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
	Oskari Pirhonen <xxc3ncoredxx@gmail.com>,
	mathieu.desnoyers@efficios.com,
	rharwood@redhat.com,
	samuel.thibault@ens-lyon.org,
	debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org,
	Olaf Hering <olaf@aepfle.de>
Subject: [PATCH v5] templates: introduce GRUB_TOP_LEVEL_* vars
Date: Mon, 24 Oct 2022 03:46:42 -0700
Message-Id: <20221024104642.251016-1-liu.denton@gmail.com>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

A user may wish to use an image that is not sorted as the "latest"
version as the top-level entry. For example, in Arch Linux, if a user
has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts`
gets sorted as the "latest" compared to `/boot/vmlinuz-linux`, meaning
the LTS kernel becomes the top-level entry. However, a user may wish to
use the regular kernel as the top-level default with the LTS only
existing as a backup.

This need can be seen in Arch Linux's AUR with two user-submitted
packages[0][1] providing an update hook which patches
/etc/grub.d/10_linux to move the desired kernel to the top-level. This
patch serves to solve this in a more generic way.

Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
top-level entry.

Create grub_move_to_front() as a helper function which moves entries to
the front of a list. This function does the heavy lifting of moving
the menu entry to the front in each script.

In 10_netbsd, since there isn't an explicit list variable, extract the
items that are being iterated through into a list so that we can
optionally apply grub_move_to_front() to the list before the loop.

[0]: https://aur.archlinux.org/packages/grub-linux-default-hook
[1]: https://aur.archlinux.org/packages/grub-linux-rt-default-hook

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---

Notes:
    The only file that was tested is 10_linux. I do not have access to any
    of the other images or systems so they remain untested.
    
    Changes since v4:
    
    * Update docs to specify that GRUB_TOP_LEVEL and GRUB_TOP_LEVEL_XEN take
      an absolute path
    
    * Add more justification in the commit message
    
    Changes since v3:
    
    * Fix if formatting nit
    
    * Rebase on top of latest 'master'
    
    Changes since v2:
    
    * Added more detail to GRUB_TOP_LEVEL docs
    
    * Moved GRUB_TOP_LEVEL_OS_PROBER to separate section in docs
    
    * Renamed grub_move_entry_to_front() to grub_move_to_front() and added
      code comment
    
    * Give 10_netbsd an intermediate list of images to interact with

Range-diff against v4:
1:  d3a693804 ! 1:  ee633189b templates: introduce GRUB_TOP_LEVEL_* vars
    @@ Commit message
         A user may wish to use an image that is not sorted as the "latest"
         version as the top-level entry. For example, in Arch Linux, if a user
         has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts`
    -    gets sorted as the "latest" compared to `/boot/vmlinuz-linux`. However,
    -    a user may wish to use the regular kernel as the default with the LTS
    -    only existing as a backup.
    +    gets sorted as the "latest" compared to `/boot/vmlinuz-linux`, meaning
    +    the LTS kernel becomes the top-level entry. However, a user may wish to
    +    use the regular kernel as the top-level default with the LTS only
    +    existing as a backup.
    +
    +    This need can be seen in Arch Linux's AUR with two user-submitted
    +    packages[0][1] providing an update hook which patches
    +    /etc/grub.d/10_linux to move the desired kernel to the top-level. This
    +    patch serves to solve this in a more generic way.
     
         Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
         GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
    @@ Commit message
         items that are being iterated through into a list so that we can
         optionally apply grub_move_to_front() to the list before the loop.
     
    +    [0]: https://aur.archlinux.org/packages/grub-linux-default-hook
    +    [1]: https://aur.archlinux.org/packages/grub-linux-rt-default-hook
    +
         Signed-off-by: Denton Liu <liu.denton@gmail.com>
     
     
    @@ Notes
         The only file that was tested is 10_linux. I do not have access to any
         of the other images or systems so they remain untested.
     
    +    Changes since v4:
    +
    +    * Update docs to specify that GRUB_TOP_LEVEL and GRUB_TOP_LEVEL_XEN take
    +      an absolute path
    +
    +    * Add more justification in the commit message
    +
         Changes since v3:
     
         * Fix if formatting nit
    @@ docs/grub.texi: for all respectively normal entries.
      
     +@item GRUB_TOP_LEVEL
     +@item GRUB_TOP_LEVEL_XEN
    -+This option should be a path to a kernel image. If provided, the image
    -+specified will be made the top-level entry if it is found in the scan.
    ++This option should be an absolute path to a kernel image. If provided, the
    ++image specified will be made the top-level entry if it is found in the scan.
     +
     +@item GRUB_TOP_LEVEL_OS_PROBER
     +This option should be a line of output from @command{os-prober}. As

 docs/grub.texi              | 10 ++++++++++
 util/grub-mkconfig.in       |  3 +++
 util/grub-mkconfig_lib.in   | 26 ++++++++++++++++++++++++++
 util/grub.d/10_hurd.in      |  4 ++++
 util/grub.d/10_kfreebsd.in  |  4 ++++
 util/grub.d/10_linux.in     |  4 ++++
 util/grub.d/10_netbsd.in    |  8 +++++++-
 util/grub.d/20_linux_xen.in |  7 +++++++
 util/grub.d/30_os-prober.in |  4 ++++
 9 files changed, 69 insertions(+), 1 deletion(-)

diff --git a/docs/grub.texi b/docs/grub.texi
index 0dbbdc374..641fb4ad3 100644
--- a/docs/grub.texi
+++ b/docs/grub.texi
@@ -1444,6 +1444,16 @@ for all respectively normal entries.
 The values of these options replace the values of @samp{GRUB_CMDLINE_LINUX}
 and @samp{GRUB_CMDLINE_LINUX_DEFAULT} for Linux and Xen menu entries.
 
+@item GRUB_TOP_LEVEL
+@item GRUB_TOP_LEVEL_XEN
+This option should be an absolute path to a kernel image. If provided, the
+image specified will be made the top-level entry if it is found in the scan.
+
+@item GRUB_TOP_LEVEL_OS_PROBER
+This option should be a line of output from @command{os-prober}. As
+@samp{GRUB_TOP_LEVEL}, if provided, the image specified will be made the
+top-level entry if it is found in the scan.
+
 @item GRUB_EARLY_INITRD_LINUX_CUSTOM
 @itemx GRUB_EARLY_INITRD_LINUX_STOCK
 List of space-separated early initrd images to be loaded from @samp{/boot}.
diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
index 62335d027..32c480dae 100644
--- a/util/grub-mkconfig.in
+++ b/util/grub-mkconfig.in
@@ -233,6 +233,9 @@ export GRUB_DEFAULT \
   GRUB_CMDLINE_NETBSD \
   GRUB_CMDLINE_NETBSD_DEFAULT \
   GRUB_CMDLINE_GNUMACH \
+  GRUB_TOP_LEVEL \
+  GRUB_TOP_LEVEL_XEN \
+  GRUB_TOP_LEVEL_OS_PROBER \
   GRUB_EARLY_INITRD_LINUX_CUSTOM \
   GRUB_EARLY_INITRD_LINUX_STOCK \
   GRUB_TERMINAL_INPUT \
diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in
index 634bc8a50..08953287c 100644
--- a/util/grub-mkconfig_lib.in
+++ b/util/grub-mkconfig_lib.in
@@ -218,6 +218,32 @@ version_sort ()
    esac
 }
 
+# Given an item as the first argument and a list as the subsequent arguments,
+# returns the list with the first argument moved to the front if it exists in
+# the list.
+grub_move_to_front ()
+{
+  item="$1"
+  shift
+
+  item_found=false
+  for i in "$@"; do
+    if [ "x$i" = "x$item" ]; then
+      item_found=true
+    fi
+  done
+
+  if [ "x$item_found" = xtrue ]; then
+    echo "$item"
+  fi
+  for i in "$@"; do
+    if [ "x$i" = "x$item" ]; then
+      continue
+    fi
+    echo "$i"
+  done
+}
+
 # One layer of quotation is eaten by "" and the second by sed; so this turns
 # ' into \'.
 grub_quote () {
diff --git a/util/grub.d/10_hurd.in b/util/grub.d/10_hurd.in
index a021d02c2..b317a4b14 100644
--- a/util/grub.d/10_hurd.in
+++ b/util/grub.d/10_hurd.in
@@ -229,6 +229,10 @@ submenu_indentation=""
 
 reverse_sorted_kernels=$(echo ${kernels} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_kernels=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_kernels})
+fi
+
 is_top_level=true
 
 for kernel in ${reverse_sorted_kernels}; do
diff --git a/util/grub.d/10_kfreebsd.in b/util/grub.d/10_kfreebsd.in
index 0a67decaa..83e9636e8 100644
--- a/util/grub.d/10_kfreebsd.in
+++ b/util/grub.d/10_kfreebsd.in
@@ -164,6 +164,10 @@ submenu_indentation=""
 
 reverse_sorted_list=$(echo ${list} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_list})
+fi
+
 is_top_level=true
 
 for kfreebsd in ${reverse_sorted_list}; do
diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
index c6a1ec935..7263f2983 100644
--- a/util/grub.d/10_linux.in
+++ b/util/grub.d/10_linux.in
@@ -202,6 +202,10 @@ submenu_indentation=""
 
 reverse_sorted_list=$(echo $list | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_list})
+fi
+
 is_top_level=true
 for linux in ${reverse_sorted_list}; do
   gettext_printf "Found linux image: %s\n" "$linux" >&2
diff --git a/util/grub.d/10_netbsd.in b/util/grub.d/10_netbsd.in
index dc0cd1b17..3154e9e15 100644
--- a/util/grub.d/10_netbsd.in
+++ b/util/grub.d/10_netbsd.in
@@ -146,8 +146,14 @@ pattern="^ELF[^,]*executable.*statically linked"
 # yet, so it's empty. In a submenu it will be equal to '\t' (one tab).
 submenu_indentation=""
 
+list="/netbsd $(ls -t /netbsd?* 2>/dev/null)"
+
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${list})
+fi
+
 is_top_level=true
-for k in /netbsd $(ls -t /netbsd?* 2>/dev/null) ; do
+for k in ${list}; do
   if ! grub_file_is_not_garbage "$k" ; then
     continue
   fi
diff --git a/util/grub.d/20_linux_xen.in b/util/grub.d/20_linux_xen.in
index 626aed40c..386bfb9be 100644
--- a/util/grub.d/20_linux_xen.in
+++ b/util/grub.d/20_linux_xen.in
@@ -245,6 +245,13 @@ submenu_indentation=""
 reverse_sorted_xen_list=$(echo ${xen_list} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 reverse_sorted_linux_list=$(echo ${linux_list} | tr ' ' '\n' | sed -e 's/\.old$/ 1/; / 1$/! s/$/ 2/' | version_sort -r | sed -e 's/ 1$/.old/; s/ 2$//')
 
+if [ "x$GRUB_TOP_LEVEL_XEN" != x ]; then
+  reverse_sorted_xen_list=$(grub_move_to_front "$GRUB_TOP_LEVEL_XEN" ${reverse_sorted_xen_list})
+fi
+if [ "x$GRUB_TOP_LEVEL" != x ]; then
+  reverse_sorted_linux_list=$(grub_move_to_front "$GRUB_TOP_LEVEL" ${reverse_sorted_linux_list})
+fi
+
 is_top_level=true
 
 for current_xen in ${reverse_sorted_xen_list}; do
diff --git a/util/grub.d/30_os-prober.in b/util/grub.d/30_os-prober.in
index daa603778..656301eaf 100644
--- a/util/grub.d/30_os-prober.in
+++ b/util/grub.d/30_os-prober.in
@@ -113,6 +113,10 @@ EOF
 
 used_osprober_linux_ids=
 
+if [ "x$GRUB_TOP_LEVEL_OS_PROBER" != x ]; then
+  OSPROBED=$(grub_move_to_front "$GRUB_TOP_LEVEL_OS_PROBER" ${OSPROBED})
+fi
+
 for OS in ${OSPROBED} ; do
   DEVICE="`echo ${OS} | cut -d ':' -f 1`"
   LONGNAME="`echo ${OS} | cut -d ':' -f 2 | tr '^' ' '`"
-- 
2.38.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:47:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428844.679393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuzp-0003Mo-JZ; Mon, 24 Oct 2022 10:47:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428844.679393; Mon, 24 Oct 2022 10:47:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omuzp-0003Mh-Gd; Mon, 24 Oct 2022 10:47:53 +0000
Received: by outflank-mailman (input) for mailman id 428844;
 Mon, 24 Oct 2022 10:47:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1omuzo-00039L-Di
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:47:52 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d955513-5389-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 12:47:50 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by BL0PR12MB4916.namprd12.prod.outlook.com (2603:10b6:208:1ce::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 10:47:46 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 10:47:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d955513-5389-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XKPK18TL43YTznMAZ0hpTLEBehJhD3PstFimnsvV99YguVcI0B63r2pSNKYiPaHvYrdw4/Uj0flii+VEAdVB07M6QoZxYa1Uj+2Si4AMoKh81KuCS9J5oiVtx6wCKzv008aWC0oN2RJohlvJx6B/wl09vhbTecwTotUus5faTkoilCqS3bxg5KDuOjOIf7trSDWOJQO0ZzFl4lsyy8r4Wj9RdFG6JVfjf+C8yCZNygCJ0IWpzYlEFth1BVPxVv5tI/kLT2Vlx9eL8/u7LcJxt6kkTQEgaL/czkc1+fIrvbQe/T91NU1rgTUxLO4O5bY5UdIm0jnv7Gvue6yCT6m4iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iNnGKL9Sez5Pv6RkaHdYhArAypCrVURdZJKj/LfAKok=;
 b=Py8OfBHRooUv9rfcqecJiXzfWWShrtlUpo+3HtBIcxR5IUhEiMYq48/agbrr2R6KVBqKCxD1212nJ+3hasJR9HJN9jjTFzSGgURP/feHEHnU0Yg44b+leHEkBntWxweID7pKrTwD11La02Go1G8IIs5LJQFNRokkw6ViZbFtticLDmU4rGeIdMjbnBIMWqvOggT5QJE/GnkYTzT1AfcyCgmZf9EOq3+nerhVzrag+HfH1p2jvzzH5uuBxC68/LfEOmIihl7QVtHUGRUleKv9+vBUZEXYlaVtFf41XTP7JGYfgu0SlE1hA2AAMn1rxTDOZhHJmCEIK6lS/IngqLv2TQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iNnGKL9Sez5Pv6RkaHdYhArAypCrVURdZJKj/LfAKok=;
 b=nXpk0CISVVtTf9zFV4Ni1+qmSqECzsM+3UbNdQNiIm1AcKQwqgOa+8Q8PM7cn344x38WJ7weOIGYQZUtXGYxfdK8DDUs3KxSd63Zv9cypmQbSNMXZ4LaArJCGeTlvMg4HObPwDai5A8KxK3L++PEQmSAPHNAf2Hyn19t/oZnmzs=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <e952fcd7-bab6-68ed-d884-6505e529a073@amd.com>
Date: Mon, 24 Oct 2022 11:47:40 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for
 AArch32
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-4-ayankuma@amd.com>
 <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0186.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:311::13) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BL0PR12MB4916:EE_
X-MS-Office365-Filtering-Correlation-Id: 2806e427-84b0-48fc-33d1-08dab5ad2f84
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vhSxpuhmXYEg0HT++Ip/zcTILb6tEz9/VOEFVWynDjTDm/DFNTiu9qXnQypQzI4bZMssXRko/PzsGLB8W2RmlzWu3/CocfjSgR6aSCplqTntXlSXvv+DqL6CAVJlDFrpDd2XEiCKylACGy7APwHHdK2Xs0K0aOlS5BZ+bhKZCxlALrlVj6jaPwuC/XOhK6KJ+2F+qiYuqhmgl1tXebrXhwox/Dpgu3OwC3K6tpsJ/P5r+b35xaBkS8c8cyspqAlhnQn7bymUxb1rTB8lhaiE1hbM5PqCcc1BiaX1HglRQu0+HdtGuFh3JMfwyKbd0nlWGB28dmI84USLq6J/vS4WnSticF2we3L0JnRd5SafBlAhua9uZzg0fL3MiEMUXh8VL0AEMWEGqe4JjtmRvBhi6YjLeU7zyolpdDnycrK4GItqZsONnuEtIpyERAXX5VB378dK9dzyjHM9nI5V7BykMDiq5WeGZrMA5JGB6VYGRQAbMgo/bLIOUg0eu0xW1I/92k1Bi86AtXukHvcmBa7+kyPLjnBKdkTmGSi3rkGM9bZR3ea5oso/mCTMe6jPX/w9+Avan7953AATbpdBrxzDowY2s3+w+cqhEj+Gr0EeiueTeeqQVW8Em+p58Ze5byPXkaZ6a0eCP1gTOSQegpKfykGzUkQwgVijhojzx1DQftbN3c3O/R5LlV5K3HyayR3Y2gZB8MoWSoeomUfOhNrRZfacIdJsLB9lgJQMOZj+1RRxz0MMfU6Oa8hlIo6hOztBVM9/RdtG63mOGODaBdEL0ftV4PsXpka69Af8YAMdbY8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(346002)(39850400004)(136003)(451199015)(31686004)(6512007)(53546011)(316002)(26005)(36756003)(66476007)(4326008)(8676002)(66556008)(31696002)(66946007)(41300700001)(8936002)(5660300002)(2906002)(6666004)(478600001)(6486002)(6506007)(83380400001)(38100700002)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N0RGcFl1ZlFnZ2dCa05jYlY5T1R2RGFXRE9VTlY5dXZBQ3lUODFTVjBTS0lq?=
 =?utf-8?B?QTc5d0hUWXFTbG15dDVuQnJCZDZhaTM1SVQrOHBGM2V4N3RBdlF4bkZ5ZjFR?=
 =?utf-8?B?WDJwRXJUeEc1WHZrbXMzc1hrb2Evc1pWOS9EWVNKT2RUQVgyeGxKRGJMclJk?=
 =?utf-8?B?bFpSVTdaQ2JlUGdiSlF1OXVscDJBbzloNTdIdGduQTF1MzlTdE1KUi9ZRFpV?=
 =?utf-8?B?YUxJSzJkWHl3K2xHTm9yQnNLVFRNd0VSUnNQTXhwM3grSERLTHNqSTA1aEYy?=
 =?utf-8?B?VTJSc2xKRE9kWFNIWlNVYnlBUUZlV3ZUUzBiM1V0c2c1NnNoZWEyTHZEZnJa?=
 =?utf-8?B?RjhkcVAvcFhnVk9CbG9pK2pMS21BR09KVVFIVVUyMzI0SjhSL2ZIMnYwUndZ?=
 =?utf-8?B?T1VvcFgwaEFLRVNPdGFuS2IzSERvb05oOUFRRnhmR285WW1tQ0o5VEhXMnlx?=
 =?utf-8?B?MFYySDdsRXJnOStidkZHandFaitHTzVmTlFET0xtT1BnNXNhdlFCNVZsY3Vm?=
 =?utf-8?B?ZUJ3M1h4a2s4UHlZVXh1eVUzS25YVkRYdWxwUmVaam9aSVFRVkdWT2JBZTFi?=
 =?utf-8?B?a1JLb2hQWTFNU3NUTkpncUtzNjMzWWxsRjZVYklabHJrYXBTbWNYVHR1bHRq?=
 =?utf-8?B?Vjk0THc1SldQY0JpYVYySWVKN201NEFJSE8zdWtrZmEzTnlNZjh2OGg4Qlpy?=
 =?utf-8?B?eXdIc2cxa2dBM094M1k3MElJM1doQlo5TlU1N0s2UVZqck1UM01PWVlzVjlk?=
 =?utf-8?B?VU1Pb2VnUEhHSjhySW5zSnN2RDVnanpIT01oYUVpU01YL3NuaDZDTytzV3Uw?=
 =?utf-8?B?T2FxWFhmMzF3T2tkeHQ4Tm15RzYrK0xEdFJ6TFBuQkw2aW5MUmUzSWtzTTNn?=
 =?utf-8?B?Wk1JMFNJYTRmSUhLYjhMajhGbzNWYWFGMERDNkxwaUtMczV0Ulp6Y2ZHRCtr?=
 =?utf-8?B?U2tCOWtqMEU4RVJoRXF3UFRqeGJyU215RGJaV25IVy9XM3JGdlFQVUEwZGVk?=
 =?utf-8?B?VHZkRmx5Wk1HMng1QU4wOCtjL2RtNWlaQU5RUDJLM2VCL2dBQmZmSmFKRnM5?=
 =?utf-8?B?NEpIU0JQbUUzOWhJZytnWU1ZbjlnWjYyNmdaTmRsN0dsamhXeEhCZk5DM0c0?=
 =?utf-8?B?ZTdBWDlvcmp1a1JKbU1ENzR3N1RFT3U5Vk83ZmRZQXpqNks3MjN1OWM3VUtk?=
 =?utf-8?B?ZUMwRDJxYzhrejhPT0Y3cUhtcUxaN1prZEp6WWFQTmYrSkw2WFNkWEduaHpl?=
 =?utf-8?B?YU14ZzU0UlpwM2k1Z0RCVGxGbVhmVjU3YjNRb3NxRk0zTkVVUDFWNnE4K05R?=
 =?utf-8?B?Vm41TnZCMVBXMnI0cmxxeE51Q0dZZDZlS2tYcStVZC9BYWhRSGF0Q3RwRGxE?=
 =?utf-8?B?K2d1Y2dld3BKME81VVd6WjJRZ090SCtPMHp5S3FrSUpEalUwRXVkb3FyLzVV?=
 =?utf-8?B?REdvTkxjS1RaNzZoa3E1R3YxVER2SVlNTkRTUlRsMzZZUzlMc0ZRSHZjdWt3?=
 =?utf-8?B?ZE41NVhQNGNPTEd2NCtFVWVVVjFSVndsVklJUUZ5Qlg5RzZzeG5kNW1mOWRp?=
 =?utf-8?B?d2FTeWVzZkNGWEFEOWtoZWQ0aFFpUVpDbDJYbDQya2hNWnVKanh0VzdOTkQw?=
 =?utf-8?B?ejAzUWZTMXFBVzFUUHhMa2xDWG5zSmFFbU5PTzFRNGswTzlCbDhMakNFT2gw?=
 =?utf-8?B?djVXb2VFUUorMU5iSm0vOXJoNlhIQldwMzY2ZE5keVFGSFhheXF4SnFWNWRa?=
 =?utf-8?B?Y012ZnBZTW5QbjYrVHpZZG5JYSs3NTVqZGhXS2s5VmlCa1Z0Z3RpSzFkWCsz?=
 =?utf-8?B?ZDI4c0xJSmozVXVacGxacytaL2NoQnkxdnE5MVVWK3M2K0tBczRjY2ZqSDR4?=
 =?utf-8?B?OUQ2WWk0UEg4MkhldkROWDNOcWpBY2h0bGd6eUNSelB6TVpXUjlvVC8zdm9O?=
 =?utf-8?B?Y1lQcUZ5SklqNlErQndONzhaNkF2YWcyd3l3QWJpVXliYmtxOHVNdTM3bFFD?=
 =?utf-8?B?bTU5WmZtM2JTTDRIeE9uRFowcDJzNGIxOFhEd1RNMm1WZFZIQnVlL2k2ak5J?=
 =?utf-8?B?RGRKNzROQXhmdHEwK2FHaWRHTVRKbnNwRXZ3b24vWXhjSjNHUWNKaWk0ZzZq?=
 =?utf-8?Q?Dcynl2e5+j66nGHpxs1ZojuT1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2806e427-84b0-48fc-33d1-08dab5ad2f84
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 10:47:45.9852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LCd8YwIOozq0SPblRF7nnuqwp2wPUqMUMbWzd2f/fzIB0dQy5xj23yfEFOcyqTn6cVzyLFH5aMjr+c0QqOTbaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4916


On 22/10/2022 11:13, Julien Grall wrote:
> Hi Ayan,

Hi Julien,

I need some clarification.

>
> Title: The code you are modifying below is not GICv3 specific. I would 
> suggest the following title:
>
> xen/arm: vreg: Support vreg_reg64_* helpers on Aarch32
>
> On 21/10/2022 16:31, Ayan Kumar Halder wrote:
>> In some situations (eg GICR_TYPER), the hypervior may need to emulate
>> 64bit registers in aarch32 mode. In such situations, the hypervisor may
>> need to read/modify the lower or upper 32 bits of the 64 bit register.
>>
>> In aarch32, 64 bit is represented by unsigned long long. Thus, we need
>> to change the prototype accordingly.
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> ---
>>   xen/arch/arm/include/asm/vreg.h | 23 ++++++++---------------
>>   1 file changed, 8 insertions(+), 15 deletions(-)
>>
>> diff --git a/xen/arch/arm/include/asm/vreg.h 
>> b/xen/arch/arm/include/asm/vreg.h
>> index f26a70d024..ac6e702c5c 100644
>> --- a/xen/arch/arm/include/asm/vreg.h
>> +++ b/xen/arch/arm/include/asm/vreg.h
>> @@ -95,7 +95,7 @@ static inline bool vreg_emulate_sysreg(struct 
>> cpu_user_regs *regs, union hsr hsr
>>    * Note that the alignment fault will always be taken in the guest
>>    * (see B3.12.7 DDI0406.b).
>>    */
>> -static inline register_t vreg_reg_extract(unsigned long reg,
>> +static inline register_t vreg_reg_extract(unsigned long long reg,
>>                                             unsigned int offset,
>>                                             enum dabt_size size)
>>   {
>> @@ -105,7 +105,7 @@ static inline register_t 
>> vreg_reg_extract(unsigned long reg,
>>       return reg;
>>   }
>>   -static inline void vreg_reg_update(unsigned long *reg, register_t 
>> val,
>> +static inline void vreg_reg_update(unsigned long long *reg, 
>> register_t val,
>>                                      unsigned int offset,
>>                                      enum dabt_size size)
>>   {
>> @@ -116,7 +116,7 @@ static inline void vreg_reg_update(unsigned long 
>> *reg, register_t val,
>>       *reg |= ((unsigned long)val & mask) << shift;
>>   }
>>   -static inline void vreg_reg_setbits(unsigned long *reg, register_t 
>> bits,
>> +static inline void vreg_reg_setbits(unsigned long long *reg, 
>> register_t bits,
>>                                       unsigned int offset,
>>                                       enum dabt_size size)
>>   {
>> @@ -126,7 +126,7 @@ static inline void vreg_reg_setbits(unsigned long 
>> *reg, register_t bits,
>>       *reg |= ((unsigned long)bits & mask) << shift;
>>   }
>>   -static inline void vreg_reg_clearbits(unsigned long *reg, 
>> register_t bits,
>> +static inline void vreg_reg_clearbits(unsigned long long *reg, 
>> register_t bits,
>>                                         unsigned int offset,
>>                                         enum dabt_size size)
>>   {
>> @@ -149,7 +149,7 @@ static inline void 
>> vreg_reg##sz##_update(uint##sz##_t *reg,             \
>>                                            register_t 
>> val,                \
>>                                            const mmio_info_t 
>> *info)       \
>> { \
>> -    unsigned long tmp = 
>> *reg;                                           \
>> +    unsigned long long tmp = 
>> *reg;                                      \
>> \
>>       vreg_reg_update(&tmp, val, info->gpa & 
>> (offmask),                   \
>> info->dabt.size);                                   \
>> @@ -161,7 +161,7 @@ static inline void 
>> vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
>>                                             register_t 
>> bits,              \
>>                                             const mmio_info_t 
>> *info)      \
>> { \
>> -    unsigned long tmp = 
>> *reg;                                           \
>> +    unsigned long long tmp = 
>> *reg;                                      \
>> \
>>       vreg_reg_setbits(&tmp, bits, info->gpa & 
>> (offmask),                 \
>> info->dabt.size);                                  \
>> @@ -173,7 +173,7 @@ static inline void 
>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>                                               register_t 
>> bits,            \
>>                                               const mmio_info_t 
>> *info)    \
>> { \
>> -    unsigned long tmp = 
>> *reg;                                           \
>> +    unsigned long long tmp = 
>> *reg;                                      \
>> \
>>       vreg_reg_clearbits(&tmp, bits, info->gpa & 
>> (offmask),               \
>> info->dabt.size);                                \
>> @@ -181,15 +181,8 @@ static inline void 
>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>       *reg = 
>> tmp;                                                         \
>>   }
>>   -/*
>> - * 64 bits registers are only supported on platform with 64-bit long.
>> - * This is also allow us to optimize the 32 bit case by using
>> - * unsigned long rather than uint64_t
>> - */
>
> The comment above explain why we never use uint64_t in the helpers 
> above. IIRC, the compiler would end up to use 2 registers on AArch32 
> even for the vreg_reg32_* helpers. I wanted to avoid that and would 
> like like to today. Can you check the code generated?

I am not sure I understood the comment very well.

With this patch, the disassembly is as follows :-

         vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
   28124c:   e597000c    ldr r0, [r7, #12]
VREG_REG_HELPERS(32, 0x3);
   281250:   e5d52002    ldrb    r2, [r5, #2]
   281254:   e1a02322    lsr r2, r2, #6
     unsigned long mask = VREG_REG_MASK(size);
   281258:   e3a03008    mov r3, #8
   28125c:   e1a03213    lsl r3, r3, r2
   281260:   e2633020    rsb r3, r3, #32
   281264:   e3e02000    mvn r2, #0
   281268:   e1a02332    lsr r2, r2, r3
VREG_REG_HELPERS(32, 0x3);
   28126c:   e5953010    ldr r3, [r5, #16]
   281270:   e2033003    and r3, r3, #3
     int shift = offset * 8;
   281274:   e1a03183    lsl r3, r3, #3
VREG_REG_HELPERS(32, 0x3);
   281278:   e59013f0    ldr r1, [r0, #1008] ; 0x3f0
   28127c:   e1c11312    bic r1, r1, r2, lsl r3
     *reg |= ((unsigned long)val & mask) << shift;
   281280:   e0022009    and r2, r2, r9
VREG_REG_HELPERS(32, 0x3);
   281284:   e1813312    orr r3, r1, r2, lsl r3
   281288:   e58033f0    str r3, [r0, #1008] ; 0x3f0
         v->domain->arch.vgic.ctlr &= GICD_CTL_ENABLE;
   28128c:   e597200c    ldr r2, [r7, #12]
   281290:   e59233f0    ldr r3, [r2, #1008] ; 0x3f0
   281294:   e2033001    and r3, r3, #1
   281298:   e58233f0    str r3, [r2, #1008] ; 0x3f0

Without the patch (ie original code) , the disassembly is :-

         vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
   27f8f4:   e597000c    ldr r0, [r7, #12]
VREG_REG_HELPERS(32, 0x3);
   27f8f8:   e5d52002    ldrb    r2, [r5, #2]
   27f8fc:   e1a02322    lsr r2, r2, #6
     unsigned long mask = VREG_REG_MASK(size);
   27f900:   e3a03008    mov r3, #8
   27f904:   e1a03213    lsl r3, r3, r2
   27f908:   e2633020    rsb r3, r3, #32
   27f90c:   e3e02000    mvn r2, #0
   27f910:   e1a02332    lsr r2, r2, r3
VREG_REG_HELPERS(32, 0x3);
   27f914:   e5953010    ldr r3, [r5, #16]
   27f918:   e2033003    and r3, r3, #3
     int shift = offset * 8;
   27f91c:   e1a03183    lsl r3, r3, #3
     *reg &= ~(mask << shift);
   27f920:   e5901400    ldr r1, [r0, #1024] ; 0x400
   27f924:   e1c11312    bic r1, r1, r2, lsl r3
     *reg |= ((unsigned long)val & mask) << shift;
   27f928:   e0022009    and r2, r2, r9
   27f92c:   e1813312    orr r3, r1, r2, lsl r3
VREG_REG_HELPERS(32, 0x3);
   27f930:   e5803400    str r3, [r0, #1024] ; 0x400
         v->domain->arch.vgic.ctlr &= GICD_CTL_ENABLE;
   27f934:   e597200c    ldr r2, [r7, #12]
   27f938:   e5923400    ldr r3, [r2, #1024] ; 0x400
   27f93c:   e2033001    and r3, r3, #1
   27f940:   e5823400    str r3, [r2, #1024] ; 0x400

Sorry, I can't spot the difference. :(

I had a look at commit 423e9ecdc26c4b40c8db1fcc63b3655463c29976 which 
introduced this. But I could not make out the reason from the commit 
message.

>
> For other options, I would consider to either:
>   1) Fold vreg_reg_* in the macros.

Can you explain this option a bit ?

- Ayan

>   2) Write a separate vreg_reg64_*
>
> My preference would be 1).
>
> If we are planning to keep the code with "unsigned long long", then I 
> think this should be addressed in the commit message.
>
>> -#if BITS_PER_LONG == 64
>> -VREG_REG_HELPERS(64, 0x7);
>> -#endif
>>   VREG_REG_HELPERS(32, 0x3);
>> +VREG_REG_HELPERS(64, 0x7);
>
> Regardless what I wrote above, the code movement seems to be unwarranted.
>>     #undef VREG_REG_HELPERS
>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:51:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:51:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428851.679405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omv3l-0004qU-7R; Mon, 24 Oct 2022 10:51:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428851.679405; Mon, 24 Oct 2022 10:51:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omv3l-0004qN-3I; Mon, 24 Oct 2022 10:51:57 +0000
Received: by outflank-mailman (input) for mailman id 428851;
 Mon, 24 Oct 2022 10:51:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omv3j-0004qF-OD
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:51:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omv3j-0000oo-FS; Mon, 24 Oct 2022 10:51:55 +0000
Received: from 54-240-197-225.amazon.com ([54.240.197.225]
 helo=[192.168.4.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omv3j-000437-8F; Mon, 24 Oct 2022 10:51:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cju52zw+dZv9y0EgdTJ1AQtOfp6kqJoG8nPN6WmikNg=; b=emPfF5MSM4Pncf/6ZcEqybiSdu
	d9HswK15kKM8+cH946F2+qAfhWh1dG0Puy28G2eBxzfxW3guBs39OWJ35EYag4CID3XxzrOkfisMq
	UWrHxdN6wqwElUpysbXrOMEAq9mmL1qvuXqdYHIX7Pzgrw0whLFIF2trP3nc4mm2b1zg=;
Message-ID: <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
Date: Mon, 24 Oct 2022 11:51:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: Deadcode discussion based on Arm NS phys timer
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 24/10/2022 10:07, Michal Orzel wrote:
> Hello,

Hi Michal,

> Recently I came across a deadcode in Xen Arm arch timer code. Briefly speaking, we are routing
> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use of it (as it uses the hypervisor timer CNTHP).
> This timer is fully emulated, which means that there is nothing that can trigger such IRQ. This code is
> a left over from early days, where the CNTHP was buggy on some models and we had to use the CNTP instead.
> 
> As far as the problem itself is not really interesting, it raises a question of what to do with a deadcode,
> as there might be/are other deadcode places in Xen.

There are multiple definition of deadcode. Depending on which one you 
chose, then this could cover IS_ENABLED() and possibly #ifdef. So this 
would result to a lot of places impacted with the decision.

So can you clarify what you mean by deadcode?

> One may say that it is useful to keep it, because one day,
> someone might need it when dealing with yet another broken HW. Such person would still need to modify the other
> part of the code (e.g. reprogram_timer), but there would be less work required overall. Personally, I'm not in favor of
> such approach, because we should not really support possible scenarios with broken HW (except for erratas listing known issues).

The difference between "broken HW" and "HW with known errata" is a bit 
unclear to me. Can you clarify how you would make the difference here?

In particular, at which point do you consider that the HW should not be 
supported by Xen?

> Also, as part of the certification/FUSA process, there should be no deadcode and we should have explanation for every block of code.

See above. What are you trying to cover by deadcode? Would protecting 
code with IS_ENABLED() (or #ifdef) ok?

> 
> There are different ways to deal with a deadcode: > 1. Get rid of it completely
> 2. Leave it as it is
> 3. Admit that it can be useful one day and:
>    3.1. protect it with #if 0
>    3.2. protect it with a new Kconfig option (disabled by default) using #ifdef
>    3.3. protect it with a new Kconfig option (disabled by default) using IS_ENABLED (to make sure code always compile)
>    3.4. protect it with a command line option (allowing to choose the timer to be used by Xen)
> ...
> 
> Let me know what you think.

Before answering the question, I would need some clarifications on your aim.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 10:55:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 10:55:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428856.679415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omv73-0005UO-L5; Mon, 24 Oct 2022 10:55:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428856.679415; Mon, 24 Oct 2022 10:55:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omv73-0005UH-IF; Mon, 24 Oct 2022 10:55:21 +0000
Received: by outflank-mailman (input) for mailman id 428856;
 Mon, 24 Oct 2022 10:55:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RJqm=2Z=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1omv72-0005UB-KT
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 10:55:20 +0000
Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com
 [2607:f8b0:4864:20::1036])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 58fbc8b3-538a-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 12:55:19 +0200 (CEST)
Received: by mail-pj1-x1036.google.com with SMTP id
 r61-20020a17090a43c300b00212f4e9cccdso3535472pjg.5
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 03:55:19 -0700 (PDT)
Received: from leoy-huanghe.lan (211-75-219-199.hinet-ip.hinet.net.
 [211.75.219.199]) by smtp.gmail.com with ESMTPSA id
 z126-20020a623384000000b005289a50e4c2sm19465019pfz.23.2022.10.24.03.55.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 24 Oct 2022 03:55:16 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58fbc8b3-538a-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=9tFxWka2vb7L98A6SIBW68ywvl40k4w0y0HBJmBswkg=;
        b=qaed09clz4ivQMgc1kbyApa0fLRzlBtBYx414UTUIga5D1wUkeZYH2dEL7oQkS1ltg
         aDv0l36yt7g1dHnhjeGZBnFKus4pqO+ngjMRcJCExH1u+lRN7iAk0ceG7HYOdoOgvQ4A
         OfnyqD29804gKJDfelD3Fp7QBvRZrp8NwKgygBX/CLiNn/Iez50wUtHlPISNqscdzD+y
         ug8sg7qKedfbVymnjqRkjFesYnKwB6M/Rq6GgtJ36va1KlUbo+8xFmy/RaRZgyIkZW4w
         Oeolzq7HCVasZe1FDGRqja1AUU1i4d2vB9TLU/lDCi+zN2LRBSmMbFX/R8SbutxPQvzx
         +pOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=9tFxWka2vb7L98A6SIBW68ywvl40k4w0y0HBJmBswkg=;
        b=G/BdJwDyrQ73EMaxNq/RlC0D/h70WGToESeX4VWXzH6vhPCJa0XvpLb1ZFbuK6nwQ+
         L0tsLIEQHxt49b6+R36LmnLRBUMsmsMpdl3IrlF56BNtseKKqLDXIqi5ANTLT5FOhMZP
         Hi1eKJSKDusiMuxy/mthYq1SlKZfeLofbW3Re2Y/AHg8lF5OSgPa+8ML6XLJnWZpyc1Y
         HU6Te4UCWk78E/uUZRMIBpEK1ZZBzpfQBdxCA+zO92QXuG8AjVPEHq7ocvtTqH1537+Y
         NwYI2Jx3EWzQWU58wTNU87MOC3TigIUIXovZED51YI9v8/ngNeEYZx42Ym+llxhtzr4c
         50sQ==
X-Gm-Message-State: ACrzQf2b+x+xV9Xma7YKRp1U6lChi2da9jDWOnq2PNPJzp+wdu0ZxBuD
	0s+W6W9s4005+hi7Y1FGQh7etQ==
X-Google-Smtp-Source: AMsMyM5y/RLpEUCYqclOQqumUAVE7nJIjDFbz1KDijGIlnOgF1c9/r4uDUlWVJpgQ2jWzcWj8lCaeQ==
X-Received: by 2002:a17:902:a9c6:b0:178:b2d4:f8b2 with SMTP id b6-20020a170902a9c600b00178b2d4f8b2mr32652332plr.79.1666608917243;
        Mon, 24 Oct 2022 03:55:17 -0700 (PDT)
Date: Mon, 24 Oct 2022 18:55:10 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y1ZvDt7/I9JXJh2r@leoy-huanghe.lan>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
 <Y1J39UsPlM8htxFx@leoy-huanghe.lan>
 <alpine.DEB.2.22.394.2210211341440.3873@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210211341440.3873@ubuntu-linux-20-04-desktop>

On Fri, Oct 21, 2022 at 02:14:04PM -0700, Stefano Stabellini wrote:

[...]

> > > # domU side
> > > xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi
> > > xen/arch/arm/vgic.c:vgic_to_sgi
> > > xen/arch/arm/vgic.c:vgic_inject_irq
> > > xen/arch/arm/vgic.c:vcpu_kick
> > > xen/arch/arm/gic-v2.c:gicv2_send_SGI
> > > 
> > > # dom0 side
> > > xen/arch/arm/gic.c:do_sgi
> > > xen/arch/arm/traps.c:leave_hypervisor_to_guest
> > > 
> > > It would be good to understand why sometimes it takes ~10us and some
> > > other times it takes ~540us
> > 
> > Some updates for why it takes several hundreds us for Xen backend driver
> > to respond interrupt.  The short answer is the vcpu running Xen backend
> > driver needs to switch context, even I have set options "sched=null
> > vwfi=native" in Xen command line.
> > 
> > So please see below detailed logs for how the things happen.
> > 
> > Let's take the timestamp 3842008681 as the start point, it's the time
> > for Xen backend driver sending out notification (xennet_notify_tx_irq);
> > at the timestamp 3842008885 the Xen hypervisor injects the interrupt
> > (it's about ~8us duration from the start point).
> > 
> > And then at the timestamp 3842008935 it invokes vcpu_kick() to kick the
> > virtual CPU for running Xen forend driver, you could see
> > VCPU_PROCESSOR is 11 and VCPU_ID is 9 for dom0, the duration is
> > 10.16us from the start point.
> > 
> > The key point is at this point the vcpu's is_running is 0, this is
> > different from the case without long latency which vcpu's is_running
> > is 1.  IIUC, Xen hypervisor needs to take time to restore the vcpu's
> > context, thus we can see the virtual CPU 9 in Dom0 starts to run at
> > the timestamp 3842016505.
> 
> is_running should be always 1 with the NULL scheduler and vwfi=native.
> That is because VMs are never descheduled. Please double-check.
> 
> If you are really running with the NULL scheduler, then I would
> investigate why the vCPU has is_running == 0 because it should not
> happen.

Correct for this: it's my bad that I didn't really enable NULL scheduler
in my code base.  After I enabled NULL scheduler, the latency by context
switching is dismissed.

 8963              pub-338   [002]   217.777652: bprint:               xennet_tx_setup_grant: id=60 ref=1340 offset=2 len=1514 TSC: 7892178799
 8964              pub-338   [002]   217.777662: bprint:               xennet_tx_setup_grant: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179043
 8965     ksoftirqd/12-75    [012]   255.466914: bprint:               xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2 len=1514 TSC: 7892179731
 8966     ksoftirqd/12-75    [012]   255.466915: bprint:               xenvif_tx_build_gops.constprop.0: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179761
 8967              pub-338   [002]   217.778057: bprint:               xennet_tx_setup_grant: id=60 ref=1340 offset=2050 len=1514 TSC: 7892188930
 8968              pub-338   [002]   217.778072: bprint:               xennet_tx_setup_grant: id=53 ref=1333 offset=2 len=1514 TSC: 7892189293
 8969       containerd-2965  [012]   255.467304: bprint:               xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2050 len=1514 TSC: 7892189479
 8970       containerd-2965  [012]   255.467306: bprint:               xenvif_tx_build_gops.constprop.0: id=53 ref=1333 offset=2 len=1514 TSC: 7892189533

So the xennet (Xen net forend driver) and xenvif (net backend driver)
work in parallel.  Please note, I didn't see networking performance
improvement after changed to use NULL scheduler.

Now I will compare the duration for two directions, one direction is
sending data from xennet to xenvif, and another is the reversed
direction.  It's very likely the two directions have significant
difference for sending data with grant tables, you could see in above
log, it takes 20~30us to transmit a data block (we can use the id
number and grant table's ref number to match the data block in xennet
driver and xenvif driver).

> Now regarding the results, I can see the timestamp 3842008681 for
> xennet_notify_tx_irq, 3842008885 for vgic_inject_irq, and 3842008935 for
> vcpu_kick. Where is the corresponding TSC for the domain receiving the
> notification?
> 
> Also for the other case, starting at 3842016505, can you please
> highlight the timestamp for vgic_inject_irq, vcpu_kick, and also the one
> for the domain receiving the notification?
> 
> The most interesting timestamps would be the timestamp for vcpu_kick in
> "notification sending domain" [a], the timestamp for receiving the
> interrupt in the Xen on pCPU for the "notification receiving domain"
> [b], and the timestamp for the "notification receiving domain" getting
> the notification [c].
> 
> If really context switch is the issue, then the interesting latency
> would be between [a] and [b].

Understand.  I agree that I didn't move into more details, the main
reason is Xen dmesg buffer is fragile after adding more logs, e.g.
after I added log in the function gicv3_send_sgi(), Xen will stuck
during the booting phase, and after adding logs in
leave_hypervisor_to_guest() it will introduce huge logs (so I need to
only trace for first 16 CPUs to mitigate log flood).

I think it would be better to enable xentrace for my profiling at my
side.  If I have any further data, will share back.

[...]

> > Another experiment is to append option "dom0_vcpus_pin" in Xen command
> > line, this can allow the virtual CPU pins on physical CPU so can avoid
> > context switching.  With this option, I can see the throughput is
> > improved from 128.26 Mbits/s to 180.3 Mbits/s.  But this result is far
> > from the ideal throughput (800+Mbits/s).
> 
> Actually this should not happen: like before, dom0_vcpus_pin does
> nothing with the NULL scheduler and only changes things for credit. Are
> you really sure you are running the tests with sched=null vwfi=native?

You are right.  After I changed to use NULL scheduler, dom0_vcpus_pin
doesn't improve the performance, sorry for noise and please ignore it.

Thanks,
Leo


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:00:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:00:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428862.679437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvC4-0007CJ-FT; Mon, 24 Oct 2022 11:00:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428862.679437; Mon, 24 Oct 2022 11:00:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvC4-0007CC-CE; Mon, 24 Oct 2022 11:00:32 +0000
Received: by outflank-mailman (input) for mailman id 428862;
 Mon, 24 Oct 2022 11:00:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdrL=2Z=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1omvC3-0007BR-0E
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:00:31 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 124d8f53-538b-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:00:29 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-549-GfbhPK-tPGSU8XwydhnJrA-1; Mon, 24 Oct 2022 07:00:22 -0400
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com
 [10.11.54.8])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EBC3B3C0F222;
 Mon, 24 Oct 2022 11:00:21 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id AE56BC15BB2;
 Mon, 24 Oct 2022 11:00:21 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id E471221E6936; Mon, 24 Oct 2022 13:00:19 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 124d8f53-538b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666609228;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JNAZ05a51GbUnlYYzMLPhMzSa+J+jdwJlMxR4+x/+O8=;
	b=PDHjTCCSGYvoBvrqTqfOlOR7ol696wDd5z+617aoulP8x1ODC8iX7uWezuOGy65xLT/xf/
	jT9B7qj3JCxNL3AePRYBIWzLSwzWmyV8qiKvCh7rSfe0q48M6neuWqtcX3bz0quZpg0Zj8
	P8GnCUzN1xTpISrd9P1CgpjYX1YGo7Y=
X-MC-Unique: GfbhPK-tPGSU8XwydhnJrA-1
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org,  Thomas Huth <thuth@redhat.com>,
  xen-devel@lists.xenproject.org,  "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>,  Anthony Perard <anthony.perard@citrix.com>,
  Stefan Weil <sw@weilnetz.de>,  David Gibson
 <david@gibson.dropbear.id.au>,  Stefano Stabellini
 <sstabellini@kernel.org>,  Paul Durrant <paul@xen.org>,  Eric Blake
 <eblake@redhat.com>,  "Michael S. Tsirkin" <mst@redhat.com>,  Jason Wang
 <jasowang@redhat.com>,  Paolo Bonzini <pbonzini@redhat.com>,  Samuel
 Thibault <samuel.thibault@ens-lyon.org>,  Greg Kurz <groug@kaod.org>,
  Daniel P. =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>
Subject: Re: [PATCH v14 17/17] net: stream: add QAPI events to report
 connection state
References: <20221021090922.170074-1-lvivier@redhat.com>
	<20221021090922.170074-18-lvivier@redhat.com>
Date: Mon, 24 Oct 2022 13:00:19 +0200
In-Reply-To: <20221021090922.170074-18-lvivier@redhat.com> (Laurent Vivier's
	message of "Fri, 21 Oct 2022 11:09:22 +0200")
Message-ID: <87sfjdsczg.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8

Laurent Vivier <lvivier@redhat.com> writes:

> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
>
> The NETDEV_STREAM_CONNECTED event includes the destination address.
>
> This allows a system manager like libvirt to detect when the server
> fails.
>
> For instance with passt:
>
> { 'execute': 'qmp_capabilities' }
> { "return": { } }
> { "timestamp": { "seconds": 1666341395, "microseconds": 505347 },
>     "event": "NETDEV_STREAM_CONNECTED",
>     "data": { "netdev-id": "netdev0",
>         "addr": { "path": "/tmp/passt_1.socket", "type": "unix" } } }
>
> [killing passt here]
>
> { "timestamp": { "seconds": 1666341430, "microseconds": 968694 },
>     "event": "NETDEV_STREAM_DISCONNECTED",
>     "data": { "netdev-id": "netdev0" } }
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:00:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:00:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428861.679425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvC0-0006w4-8Z; Mon, 24 Oct 2022 11:00:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428861.679425; Mon, 24 Oct 2022 11:00:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvC0-0006vx-5E; Mon, 24 Oct 2022 11:00:28 +0000
Received: by outflank-mailman (input) for mailman id 428861;
 Mon, 24 Oct 2022 11:00:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdrL=2Z=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1omvBy-0006vr-8t
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:00:26 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f044e2c-538b-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:00:24 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-257-Qtw4snbNPCawDnP8qruIEA-1; Mon, 24 Oct 2022 07:00:19 -0400
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com
 [10.11.54.1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 69972299E759;
 Mon, 24 Oct 2022 11:00:18 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C6B2440C2064;
 Mon, 24 Oct 2022 11:00:16 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id DEAAD21E6936; Mon, 24 Oct 2022 13:00:09 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f044e2c-538b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666609223;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=JPt5T8Uiv1CdWndjYYsC1Y8mTRQPX3OEHe0yHwxlQJc=;
	b=QXomIgjjRwKbLy3km5dpd9tMbrmH2ExUd65ixbtTCqHm7Yi7MFKSbC529LPFE/SnnkTH7/
	XKrcmjFWYlw7C1Wv87lcjKUpLiRYbygW6mUt4m32YnZtgh7aMtlnEE0+ECRntM0v08Ma1S
	Mp4oiKduukhbGC8HRQiMvR7hUpX3FVM=
X-MC-Unique: Qtw4snbNPCawDnP8qruIEA-1
From: Markus Armbruster <armbru@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,  qemu-devel@nongnu.org,  Paul
 Durrant <paul@xen.org>,  Thomas Huth <thuth@redhat.com>,  Daniel P.
 =?utf-8?Q?Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>,  Greg Kurz <groug@kaod.org>,  Stefano Stabellini
 <sstabellini@kernel.org>,  David Gibson <david@gibson.dropbear.id.au>,
  Eric Blake <eblake@redhat.com>,  xen-devel@lists.xenproject.org,
  "Michael S. Tsirkin" <mst@redhat.com>,  Stefan Weil <sw@weilnetz.de>,
  Paolo Bonzini <pbonzini@redhat.com>,  Jason Wang <jasowang@redhat.com>,
  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Anthony Perard
 <anthony.perard@citrix.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
	<87lep935hn.fsf@pond.sub.org>
Date: Mon, 24 Oct 2022 13:00:09 +0200
In-Reply-To: <87lep935hn.fsf@pond.sub.org> (Markus Armbruster's message of
	"Fri, 21 Oct 2022 11:12:20 +0200")
Message-ID: <87tu3tsczq.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1

Markus Armbruster <armbru@redhat.com> writes:

> Cc: Stefano Brivio
>
> Laurent Vivier <lvivier@redhat.com> writes:
>
>> On 10/21/22 07:48, Markus Armbruster wrote:
>>> Laurent Vivier <lvivier@redhat.com> writes:
>>> 
>>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.
>>>
>>> Use cases?
>>
>> This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.

[...]

>>> Could similar event signalling be useful for other kinds of netdev
>>> backends?
>>
>> I was wondering, but it becomes more complicated to be generic.
>
> Making something complicated and generic where a simpler special
> solution would do is the worst.
>
> Not quite as bad (but still plenty bad) is making a few special
> solutions first, then replace them all with a generic solution.
>
> I believe we should have a good, hard think on possible applications of
> a generic solution now.
>
> There is no need to hold back this series for that.
>
> If we conclude a generic solution is called for, we better replace this
> special solution before it becomes ABI.  Either by replacing it before
> we release it, or by keeping it unstable until we replace it.

Stefano, any thoughts on this?



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:00:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:00:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428863.679447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvCF-0007d4-P3; Mon, 24 Oct 2022 11:00:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428863.679447; Mon, 24 Oct 2022 11:00:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvCF-0007cx-M2; Mon, 24 Oct 2022 11:00:43 +0000
Received: by outflank-mailman (input) for mailman id 428863;
 Mon, 24 Oct 2022 11:00:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1omvCE-0006vr-K5
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:00:42 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2083.outbound.protection.outlook.com [40.107.243.83])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 191644b4-538b-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:00:41 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM4PR12MB6009.namprd12.prod.outlook.com (2603:10b6:8:69::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 24 Oct
 2022 11:00:38 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 11:00:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 191644b4-538b-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bKmcYQ/IOEJZSS/EKddqsHhKBWr1N9rDkYUtdH1G/DTuQmwbyDDpmNOGYGswai8JP4tOnEY/KFsqY4FKADAruW4cHRc+QYsSZVGDkh7wHBX99t2pkkrrjvCDISO092moUNnJ0/vEuQaB5rmyNwH1Z9vZdf5HYO9prS8kF+fPIiAZvH9/5bRb/MOy+KQmzc4Qtuudnh3UyF9y/bij29gRYBqyuZdLrm0UeeqOGJSsaeqa1VBvm9FP4pWsR5g6OeYlg67SZCXN6IZocCYEWyCTT7LcLuR8G2PZszrFIEJXYQmkKnf3xLd7bEStVGt9fKhCUbsxSbv7TEMPiWKpPgKA7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=873z2USUakOrS5Q5b9ZvRBO+BGLKZmBVzktkFDI0/bw=;
 b=ZzscYzpyT8NVC4K/KtKJgNx7y1Gak0MrCPv0NY6wEG/h+WSpmq25ExEX0THYKY0JVnDszsV61aY1+slHlKVG1/30aVqlPGj4uYfzj0BDLgkNpNNQLOZV/7lfEGBzgK1FLNn97cDFMgu+8sVK6/qGlMbc3OCxLQIFkzYHBMtdVphQjJjMEyGJJsFiY4y3+e7v8aXvV50Gs4hR5MlrcjimG/kWDsixf3Qz/tjKTldWkH7A+LQ1W8cFN5DUGNyhFnjPTV2LR8k0bLGDRBUyAGjpbWX8Kz+zj4iqypyfTm8SndWUEfeev6G7vEWjeD8YoJUHIDCYCknX3eM6EmPYAbugIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=873z2USUakOrS5Q5b9ZvRBO+BGLKZmBVzktkFDI0/bw=;
 b=wbNWvxw+Ef8ED6RF5n5ZuDc4W9lARrIhkCcO3SvIPdwh0BfIjwxsOM+KEUxn5ko6CMTYaQ+r5cX3/ASoLeDEeVZFbTO206+1vpuUpgxaRBmVO008sTt+0XIfThRz67ZPlV9mB3wFTGXjn3pqbkGUoWeZI4ojM4WlYoQk+wQfteE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <e0183387-8556-5fcc-2f18-003832d5cd70@amd.com>
Date: Mon, 24 Oct 2022 12:00:31 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 02/12] Arm: GICv3: Move the macros to compute the
 affnity level to arm64/arm32
To: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-3-ayankuma@amd.com>
 <cb67c768-1a05-e5d5-efed-9a282c6a8c2a@gmail.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <cb67c768-1a05-e5d5-efed-9a282c6a8c2a@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0400.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::9) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM4PR12MB6009:EE_
X-MS-Office365-Filtering-Correlation-Id: 79310a66-43f0-48e4-0a86-08dab5aefba4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3IqTENvwqGme5RxvsnYGSEIRv0PthJ0sTj0OwS8yuNICn4GwTTsMm4fTfm4w7IVTfZNBIbE5LTg98iRDa3WsvstVOLZuibWPWodVWTWyXDTctAnAQDD6PWcExA8u2mswVjpA9d8hHZwB0vqYeSoKHzZhfq3J57nKza6atyVaWRk6nzZVcm30L3IrjnxlUD34iYuY2vMz1u+BcZyf0xdzy6QP83cpG+njt38Tqp6cUUIhLarz8eWGj/3Coiapbk68+mMkr3Nyb+O9w0tvU22qEtxLeRqzsL1xfgG8OGP6pox29nnzsBNULpnRkCKIyHBYsxogN1y2y8H3T2HZronizheEV5oTTdwHWzAnLWg8g+9sG30m3/tHQQEG9BsiaZRbAq+kE7manu31o5aCUikxlhuvfqsOU86+l8q4GZVY3hvM6+r91WApzC2R1u/e+C3o5ZXr3XE9LLRSGiBtsCQSzlRkq4gTwZYucaabqf/zpyXo5UTMiDG1Kft8jYn69C6T3cQwD0/mvPkGdaV8MGbVBkbF6oYPMEXS0StJzaDMwoxoqc+bpGqIcYKHQJQF+WDnOpCzyRUikqluuwYagVy/WTv8MwUNnerkqqGamZzV4AkWCVjM7vJj+6jTCniWghK58OeseFzzso8ueHZpzVfmD1cphUmtg7XFwD91CT4ZW/TxjWHrQLkdHW8WIFNVvhAj/gah7k+sNNvosjpAlPml/fHPsYh2r1S2c8ulvSF+9+Gz6e7Aj5dNmz9F73tN9lTp9bREkdhANWkcb/Wc4sgvVTQijKJg4PhL9oEQtBxyANdShXp6bx6Tii9cy13p3yn5Q79vExDetmtK9ZiZH/VSYq1rxeF24ZtPtEreSPCKIF4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(451199015)(31696002)(36756003)(31686004)(2906002)(38100700002)(53546011)(8936002)(186003)(41300700001)(83380400001)(66476007)(5660300002)(6666004)(316002)(6512007)(2616005)(26005)(478600001)(66946007)(6486002)(66556008)(6506007)(8676002)(966005)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bTA5WEVtQzkvQVl2RzBSazBUc2s0VnJYNnIwYjRtL3d3c3ZlZytXOU9MZG5H?=
 =?utf-8?B?YWVLbnlDeTZadUJJMXF1cXg0NElEVTJhY1B6VGtMeG1JZjI5dTY0UGxwOTZ3?=
 =?utf-8?B?Tkl5VDNMV2lNRTVEVnBJOW50cXJFclF4UUNZT2YvdnhORmMzb0F0MnlKVU5Y?=
 =?utf-8?B?dWZlMUtScWkxbUtiVW1vS2JFVzZuWFBmNGVaLzJtaW5SL3pwd3RPbmtNa3hW?=
 =?utf-8?B?TEFwK21tdjBuQXdXSGUyVlhkUzJuSGlGSVQraHdQekw1eVNTMk16c2hxTXht?=
 =?utf-8?B?blVvK2oySjd0Y0xUMTFWcEpWcnRUYXdZVTFyUUQrbkU4OFpTU1Z0NThHaDkr?=
 =?utf-8?B?OHduQkhnSGYrNEw3Rnp2VFQvM0xHeEhQTWlJNlYvTnNrVWFRUGtBWXBRVWVl?=
 =?utf-8?B?V2dzUFd3SzRBMzR5VnBhN2RkaFZFWHF0L1Ftc1lvVm9MemNpMDJHQnhkNi8v?=
 =?utf-8?B?dEQ2dHp3WGZtSEJVQ3pRbzFHekV6ZXFqRXFLcHNwRlovcVJoRmdJaFRsNW0x?=
 =?utf-8?B?VDYvYXhKYmt1RVVnREJ1UWo0NnZuNVdjamYvdkxOeENkRkRWMDlKT25Da0pT?=
 =?utf-8?B?RGNGN2N0M3BqeVNjQk9hdXRxQzltTkdvaGpMdENlUWFhY1FyUWgrSjRuaVQ1?=
 =?utf-8?B?dVB2dmU5aXp6cTNYZ1JVMWo2bGlyaXhySzA0c1JLVVdUNU1KbHlLYnBwZGhT?=
 =?utf-8?B?WjhtREVUYjVMS09pYjZmWmg1V0JkMVRpVGVPRjNYTlhXMnlIUFNGdGUwSno1?=
 =?utf-8?B?SmxNYkxBdlYwc2NncVNKb1pvTkxJZFdnaHdXZkRVV2l6Uk5oLzg4UC9NdU5V?=
 =?utf-8?B?aWUyNFcrUWIwUitsUnYxdjNtRWNDZE9yOFFYeEJHYmNSNDN1K3dJMmVWUkhl?=
 =?utf-8?B?SHphVXRpblBpVUNyeXhJY29pTXlVelYzTThnbUZ4R3AySlhEbkhYSXZsRUJM?=
 =?utf-8?B?Q2taaU0vY0dsZEJ4U1A2YVNwc0RYQ2dtM2Z2TDJQMGxLSTVyK0dPOHhOb1lY?=
 =?utf-8?B?U3ZYdTBkNnY0Lzg4TnZOY0lLSEcrcWprM21PSGFDak05OTZZMk8xS1llTnp5?=
 =?utf-8?B?cXJnZnVHZmo2ZWZZRlVMTVNTNmQvaVZHWGg5U0gxdEJqMkVTSWFjY3ptV1pM?=
 =?utf-8?B?akZ2d0h6THlwMjcrL1ZKeGNEWW1HSjBjOWoybndJQTZsOUJUZURLY2ZJc2VO?=
 =?utf-8?B?ditCSExiY3ZCdUtNeVJrVU9oWmFZdXRqbWp0TlRuRENYMlRUa2VCTFlYUDNZ?=
 =?utf-8?B?M3RTZkQzNndRSStFSHRteGc4VTlEd2crTytINUdVQU9obzNnSEdneHlhdlNa?=
 =?utf-8?B?Um1haENlbDNwQUs3eFpiMlg2VkJEcW5lVFp1aml0YmpMb3dPNmpOSnZ2Ukh2?=
 =?utf-8?B?NjREb3RJZnBNQmlzSlNUeCt4ZTNzcUliemxXM2FRL0VkMnJJN1lKOTd3dGk5?=
 =?utf-8?B?VWlvM2t0YnFzV2ZBN1hHRzNlRndGRlJvV3dCc3o1VVJTUm5KUXp3blpZNC9Q?=
 =?utf-8?B?RXdmYzQyWFloRmVyV1pvUERHeDBqbjU2VzdLMGdJNVo1anlmRHBLOVRxVUdr?=
 =?utf-8?B?RTgzcHY3WGFvWHBwSVBnZGZ3WldVM2tkclZHTHJDV1VjcVo4T1N0U0NCakE2?=
 =?utf-8?B?Mk5NWGI5cjBzbWwzaS9kMmtpUFArV3FRRDNJUlNqRG1sc2U1ZnJLZ2twek93?=
 =?utf-8?B?RmVDTkluK0M3SDVaR0JYU2FmSnVwOFdLYTVRQW5xTG5OK3BlSDE4M1hjMU1L?=
 =?utf-8?B?MTQ4RFY4aDZpYWRoektVNzVqR25WdE8rZmxiZW42SGZqOWF4OFUvRkJzdng4?=
 =?utf-8?B?VG1xNWx1SkhwbWRSdmZpYk5NZFVudEpsNFBWNm91ZVNPRlVrSkhLRUlBN296?=
 =?utf-8?B?a05mMFdIZmYrbFJzeXJiRmgvYU1PQ2VrTGRBRXNTOTRJRzVoS0VJZGNMSHp5?=
 =?utf-8?B?U0Z0UXo1WDN6RTBUNjBBUzU1OWV3Z0VrQ2xBQWs4M2Y2SUZHVkxiWGIyRytn?=
 =?utf-8?B?VTBYN2I0VzU2ZDRpMDYzK25HcTA3WUdUUm5LYmpwRUJKQWtnUXh3K3lMWTNI?=
 =?utf-8?B?UlVNY1RKYXJGVlZtcmtGZElNdEdmWFF0Q2I0ekg1YVVlVU1nQzlGNzFpSzFB?=
 =?utf-8?Q?ynukmvvH4uK09loAPhpsSlFHi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79310a66-43f0-48e4-0a86-08dab5aefba4
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 11:00:37.8833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oGgLIrCsgR9xtIoIl3RDQW4FRAvMH1ySascsB0R1fhuNznGu1FEaDPtkOxb05N11r9osaAkhscYZEkeRuN1Ojg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6009


On 21/10/2022 22:18, Xenia Ragiadakou wrote:
> On 10/21/22 18:31, Ayan Kumar Halder wrote:
> Hi Ayan
Hi Xenia,
>
>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
>> include/asm/cputype.h#L14 , these macros are specific for arm64.
>>
>> When one computes MPIDR_LEVEL_SHIFT(3), it crosses the width of a 32
>> bit register.
>>
>> Refer 
>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
>> asm/cputype.h#L54  , these macros are specific for arm32.
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> ---
>>   xen/arch/arm/include/asm/arm32/processor.h | 10 ++++++++++
>>   xen/arch/arm/include/asm/arm64/processor.h | 13 +++++++++++++
>>   xen/arch/arm/include/asm/processor.h       | 14 --------------
>>   3 files changed, 23 insertions(+), 14 deletions(-)
>>
>> diff --git a/xen/arch/arm/include/asm/arm32/processor.h 
>> b/xen/arch/arm/include/asm/arm32/processor.h
>> index 4e679f3273..3e03ce78dc 100644
>> --- a/xen/arch/arm/include/asm/arm32/processor.h
>> +++ b/xen/arch/arm/include/asm/arm32/processor.h
>> @@ -56,6 +56,16 @@ struct cpu_user_regs
>>       uint32_t pad1; /* Doubleword-align the user half of the frame */
>>   };
>>   +/*
>> + * Macros to extract affinity level. Picked from kernel
>> + */
>> +
>> +#define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1)
>> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
>> +
>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>> +    ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK)
>> +
>>   #endif
>>     #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
>> diff --git a/xen/arch/arm/include/asm/arm64/processor.h 
>> b/xen/arch/arm/include/asm/arm64/processor.h
>> index c749f80ad9..c026334eec 100644
>> --- a/xen/arch/arm/include/asm/arm64/processor.h
>> +++ b/xen/arch/arm/include/asm/arm64/processor.h
>> @@ -84,6 +84,19 @@ struct cpu_user_regs
>>       uint64_t sp_el1, elr_el1;
>>   };
>>   +/*
>> + * Macros to extract affinity level. picked from kernel
>> + */
>> +
>> +#define MPIDR_LEVEL_BITS_SHIFT  3
>> +#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>> +
>> +#define MPIDR_LEVEL_SHIFT(level) \
>> +         (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>> +
>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>> +         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>> +
>>   #undef __DECL_REG
>>     #endif /* __ASSEMBLY__ */
>> diff --git a/xen/arch/arm/include/asm/processor.h 
>> b/xen/arch/arm/include/asm/processor.h
>> index 1dd81d7d52..7d90c3b5f2 100644
>> --- a/xen/arch/arm/include/asm/processor.h
>> +++ b/xen/arch/arm/include/asm/processor.h
>> @@ -118,20 +118,6 @@
>>   #define MPIDR_INVALID       (~MPIDR_HWID_MASK)
>>   #define MPIDR_LEVEL_BITS    (8)
>>   -
>> -/*
>> - * Macros to extract affinity level. picked from kernel
>> - */
>> -
>> -#define MPIDR_LEVEL_BITS_SHIFT  3
>> -#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>> -
>> -#define MPIDR_LEVEL_SHIFT(level) \
>> -         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>> -
>> -#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>> -         (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>> -
>>   #define AFFINITY_MASK(level)    ~((_AC(0x1,UL) << 
>> MPIDR_LEVEL_SHIFT(level)) - 1)
>>     /* TTBCR Translation Table Base Control Register */
>
> Since only the definition of the MPIDR_AFFINITY_LEVEL() differs, maybe 
> you could add only this one to the arch specific headers e.g
> for arm64:
> #define MPIDR_LEVEL_SHIFT(level) \
>     (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
> for arm32:
> #define MPIDR_LEVEL_SHIFT(level) \
>     ((level) << MPIDR_LEVEL_BITS_SHIFT)

Also, MPIDR_AFFINITY_LEVEL needs to be defined in arch specific headers 
as it differs between arm32 and arm64.

However, MPIDR_LEVEL_MASK can be defined in the common header (as it is 
same for arm32 and arm64).

Please let me know if it makes sense.

>
> But in any case don't forget to add parentheses around the macro 
> parameters when an operator acts on them to avoid trouble with 
> operator precedence (MISRA-C Rule 20.7 :))

Thanks for pointing it out. Yes, this is a mistake in my patches.

- Ayan



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:01:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:01:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428874.679459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvD6-00007W-Bw; Mon, 24 Oct 2022 11:01:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428874.679459; Mon, 24 Oct 2022 11:01:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvD6-00007P-7h; Mon, 24 Oct 2022 11:01:36 +0000
Received: by outflank-mailman (input) for mailman id 428874;
 Mon, 24 Oct 2022 11:01:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omvD5-00007B-7R
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:01:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omvD4-0000zo-Sm; Mon, 24 Oct 2022 11:01:34 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.4.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omvD4-0004pu-J4; Mon, 24 Oct 2022 11:01:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jxL8AFKp1d+GfBCRPkhTF7jPFaeitZf7g4NkuDQovuI=; b=dCO1sQVl8YAig9UPrb2TSamy9y
	NpVbDuQNd7M3r70XOejNrjnEk5axEkD/+T6fod8OsjD6xclTXc9r9e/kZZrNppjQlhme3hrivwtiy
	Gzl7RDwFb1hG8EChYrLv20ZzWl3ZANd+iIIVSBBD4hGreI9qVYLecmqiIzArmz7ixook=;
Message-ID: <b0b4fc69-3da3-3229-77d9-9fe0f4bf1ec3@xen.org>
Date: Mon, 24 Oct 2022 12:01:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
Subject: Re: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for
 AArch32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-4-ayankuma@amd.com>
 <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
 <e952fcd7-bab6-68ed-d884-6505e529a073@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e952fcd7-bab6-68ed-d884-6505e529a073@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 24/10/2022 11:47, Ayan Kumar Halder wrote:
> 
> On 22/10/2022 11:13, Julien Grall wrote:
>> Hi Ayan,
> 
> Hi Julien,
> 
> I need some clarification.
> 
>>
>> Title: The code you are modifying below is not GICv3 specific. I would 
>> suggest the following title:
>>
>> xen/arm: vreg: Support vreg_reg64_* helpers on Aarch32
>>
>> On 21/10/2022 16:31, Ayan Kumar Halder wrote:
>>> In some situations (eg GICR_TYPER), the hypervior may need to emulate
>>> 64bit registers in aarch32 mode. In such situations, the hypervisor may
>>> need to read/modify the lower or upper 32 bits of the 64 bit register.
>>>
>>> In aarch32, 64 bit is represented by unsigned long long. Thus, we need
>>> to change the prototype accordingly.
>>>
>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>> ---
>>>   xen/arch/arm/include/asm/vreg.h | 23 ++++++++---------------
>>>   1 file changed, 8 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/include/asm/vreg.h 
>>> b/xen/arch/arm/include/asm/vreg.h
>>> index f26a70d024..ac6e702c5c 100644
>>> --- a/xen/arch/arm/include/asm/vreg.h
>>> +++ b/xen/arch/arm/include/asm/vreg.h
>>> @@ -95,7 +95,7 @@ static inline bool vreg_emulate_sysreg(struct 
>>> cpu_user_regs *regs, union hsr hsr
>>>    * Note that the alignment fault will always be taken in the guest
>>>    * (see B3.12.7 DDI0406.b).
>>>    */
>>> -static inline register_t vreg_reg_extract(unsigned long reg,
>>> +static inline register_t vreg_reg_extract(unsigned long long reg,
>>>                                             unsigned int offset,
>>>                                             enum dabt_size size)
>>>   {
>>> @@ -105,7 +105,7 @@ static inline register_t 
>>> vreg_reg_extract(unsigned long reg,
>>>       return reg;
>>>   }
>>>   -static inline void vreg_reg_update(unsigned long *reg, register_t 
>>> val,
>>> +static inline void vreg_reg_update(unsigned long long *reg, 
>>> register_t val,
>>>                                      unsigned int offset,
>>>                                      enum dabt_size size)
>>>   {
>>> @@ -116,7 +116,7 @@ static inline void vreg_reg_update(unsigned long 
>>> *reg, register_t val,
>>>       *reg |= ((unsigned long)val & mask) << shift;
>>>   }
>>>   -static inline void vreg_reg_setbits(unsigned long *reg, register_t 
>>> bits,
>>> +static inline void vreg_reg_setbits(unsigned long long *reg, 
>>> register_t bits,
>>>                                       unsigned int offset,
>>>                                       enum dabt_size size)
>>>   {
>>> @@ -126,7 +126,7 @@ static inline void vreg_reg_setbits(unsigned long 
>>> *reg, register_t bits,
>>>       *reg |= ((unsigned long)bits & mask) << shift;
>>>   }
>>>   -static inline void vreg_reg_clearbits(unsigned long *reg, 
>>> register_t bits,
>>> +static inline void vreg_reg_clearbits(unsigned long long *reg, 
>>> register_t bits,
>>>                                         unsigned int offset,
>>>                                         enum dabt_size size)
>>>   {
>>> @@ -149,7 +149,7 @@ static inline void 
>>> vreg_reg##sz##_update(uint##sz##_t *reg,             \
>>>                                            register_t 
>>> val,                \
>>>                                            const mmio_info_t 
>>> *info)       \
>>> { \
>>> -    unsigned long tmp = 
>>> *reg;                                           \
>>> +    unsigned long long tmp = 
>>> *reg;                                      \
>>> \
>>>       vreg_reg_update(&tmp, val, info->gpa & 
>>> (offmask),                   \
>>> info->dabt.size);                                   \
>>> @@ -161,7 +161,7 @@ static inline void 
>>> vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
>>>                                             register_t 
>>> bits,              \
>>>                                             const mmio_info_t 
>>> *info)      \
>>> { \
>>> -    unsigned long tmp = 
>>> *reg;                                           \
>>> +    unsigned long long tmp = 
>>> *reg;                                      \
>>> \
>>>       vreg_reg_setbits(&tmp, bits, info->gpa & 
>>> (offmask),                 \
>>> info->dabt.size);                                  \
>>> @@ -173,7 +173,7 @@ static inline void 
>>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>>                                               register_t 
>>> bits,            \
>>>                                               const mmio_info_t 
>>> *info)    \
>>> { \
>>> -    unsigned long tmp = 
>>> *reg;                                           \
>>> +    unsigned long long tmp = 
>>> *reg;                                      \
>>> \
>>>       vreg_reg_clearbits(&tmp, bits, info->gpa & 
>>> (offmask),               \
>>> info->dabt.size);                                \
>>> @@ -181,15 +181,8 @@ static inline void 
>>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>>       *reg = 
>>> tmp;                                                         \
>>>   }
>>>   -/*
>>> - * 64 bits registers are only supported on platform with 64-bit long.
>>> - * This is also allow us to optimize the 32 bit case by using
>>> - * unsigned long rather than uint64_t
>>> - */
>>
>> The comment above explain why we never use uint64_t in the helpers 
>> above. IIRC, the compiler would end up to use 2 registers on AArch32 
>> even for the vreg_reg32_* helpers. I wanted to avoid that and would 
>> like like to today. Can you check the code generated?
> 
> I am not sure I understood the comment very well.
> 
> With this patch, the disassembly is as follows :-
> 
>          vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
>    28124c:   e597000c    ldr r0, [r7, #12]
> VREG_REG_HELPERS(32, 0x3);
>    281250:   e5d52002    ldrb    r2, [r5, #2]
>    281254:   e1a02322    lsr r2, r2, #6
>      unsigned long mask = VREG_REG_MASK(size);

Hmmm... Shouldn't this be "unsigned long long"?

>    281258:   e3a03008    mov r3, #8
>    28125c:   e1a03213    lsl r3, r3, r2
>    281260:   e2633020    rsb r3, r3, #32
>    281264:   e3e02000    mvn r2, #0
>    281268:   e1a02332    lsr r2, r2, r3
> VREG_REG_HELPERS(32, 0x3);
>    28126c:   e5953010    ldr r3, [r5, #16]
>    281270:   e2033003    and r3, r3, #3
>      int shift = offset * 8;
>    281274:   e1a03183    lsl r3, r3, #3
> VREG_REG_HELPERS(32, 0x3);
>    281278:   e59013f0    ldr r1, [r0, #1008] ; 0x3f0
>    28127c:   e1c11312    bic r1, r1, r2, lsl r3
>      *reg |= ((unsigned long)val & mask) << shift;
>    281280:   e0022009    and r2, r2, r9
> VREG_REG_HELPERS(32, 0x3);
>    281284:   e1813312    orr r3, r1, r2, lsl r3
>    281288:   e58033f0    str r3, [r0, #1008] ; 0x3f0
>          v->domain->arch.vgic.ctlr &= GICD_CTL_ENABLE;
>    28128c:   e597200c    ldr r2, [r7, #12]
>    281290:   e59233f0    ldr r3, [r2, #1008] ; 0x3f0
>    281294:   e2033001    and r3, r3, #1
>    281298:   e58233f0    str r3, [r2, #1008] ; 0x3f0
> 
> Without the patch (ie original code) , the disassembly is :-
> 
>          vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
>    27f8f4:   e597000c    ldr r0, [r7, #12]
> VREG_REG_HELPERS(32, 0x3);
>    27f8f8:   e5d52002    ldrb    r2, [r5, #2]
>    27f8fc:   e1a02322    lsr r2, r2, #6
>      unsigned long mask = VREG_REG_MASK(size);
>    27f900:   e3a03008    mov r3, #8
>    27f904:   e1a03213    lsl r3, r3, r2
>    27f908:   e2633020    rsb r3, r3, #32
>    27f90c:   e3e02000    mvn r2, #0
>    27f910:   e1a02332    lsr r2, r2, r3
> VREG_REG_HELPERS(32, 0x3);
>    27f914:   e5953010    ldr r3, [r5, #16]
>    27f918:   e2033003    and r3, r3, #3
>      int shift = offset * 8;
>    27f91c:   e1a03183    lsl r3, r3, #3
>      *reg &= ~(mask << shift);
>    27f920:   e5901400    ldr r1, [r0, #1024] ; 0x400
>    27f924:   e1c11312    bic r1, r1, r2, lsl r3
>      *reg |= ((unsigned long)val & mask) << shift;
>    27f928:   e0022009    and r2, r2, r9
>    27f92c:   e1813312    orr r3, r1, r2, lsl r3
> VREG_REG_HELPERS(32, 0x3);
>    27f930:   e5803400    str r3, [r0, #1024] ; 0x400
>          v->domain->arch.vgic.ctlr &= GICD_CTL_ENABLE;
>    27f934:   e597200c    ldr r2, [r7, #12]
>    27f938:   e5923400    ldr r3, [r2, #1024] ; 0x400
>    27f93c:   e2033001    and r3, r3, #1
>    27f940:   e5823400    str r3, [r2, #1024] ; 0x400
> 
> Sorry, I can't spot the difference. :(

If there is no difference, then it is a good sign. I was worried that 
the compiler would end up to use "strd/ldrd" which would result to more 
register allocations and therefore inefficient code.

But see above.

> 
> I had a look at commit 423e9ecdc26c4b40c8db1fcc63b3655463c29976 which 
> introduced this. But I could not make out the reason from the commit 
> message.

The reasoning would be to show that the assembly is either the same or 
no worse that then existing one with a few compilers.

> 
>>
>> For other options, I would consider to either:
>>   1) Fold vreg_reg_* in the macros.
> 
> Can you explain this option a bit ?

At the moment, we have generic helpers for vreg_reg_*. They are only 
called within the helper generated by VREG_REG_HELPERS().

If we make those helpers size specific, then the only the 64-bit helpers 
would use uint64_t local variables.

As they are only called in one place, we could fold them in the existing 
helpers.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:04:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:04:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428880.679470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvFX-0000s5-OQ; Mon, 24 Oct 2022 11:04:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428880.679470; Mon, 24 Oct 2022 11:04:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvFX-0000rw-LA; Mon, 24 Oct 2022 11:04:07 +0000
Received: by outflank-mailman (input) for mailman id 428880;
 Mon, 24 Oct 2022 11:04:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omvFV-0000rm-Tr
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:04:05 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92949d59-538b-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:04:04 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7744.eurprd04.prod.outlook.com (2603:10a6:102:c9::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 11:04:03 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 11:04:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92949d59-538b-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HGAGS9RrHjh1k2jbUmduNOCltNFDPL979I3YmW0ZkHjxjjExgZvjKCV0YIv+Muq149Z0BD5at7zN7QPy0+mlBW6/v6GmRM9tWFIhHCeldbmWNMWwWZ69JF/y6xv8gw5bWLWmYQHc/g6pEp6UFglL8s+1CK40K9OVe77kbDizVClLCNzzyzuzCIZnyoDfJkIr5gdfMo2Ei8T3chjso3uH3md6ycAq2oQ2XX9tqbGdi9F65A1787TMVQ6+1FOkDPLE5r5l8BrnPEjhHf0dwHWU7YMcrZ6a981EzS0AcXoKTdIu+9/l1/bfWmDqVBACdVyOwlJRZOd4qJzYIX/9RO51HA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XeqPmMJZ+8CnIJjSeKkGG+vz8qOWn+PJ81D0LKkR3ew=;
 b=IdblzLHAYIpaVKY2rvPYFNEsr8oWszTaFow5dTYMbaki5flFneUkJEsUsDiDJqfwlPLoePFSxi2wFgAK6ZTwE14B5MZpo9r4Kn/pGXBMwcd2KYUe2u7CsYUxOxB9b76tpOflBOdVmNmXBHI2+EWx+UHcxmPBkT2y7UXxuH2ZtfatC7vHzB3xl5PSvZNOm6fnXHBBzEx838ocXshQfaPuJ4fpWF+ulunvp+oXElg1yzeRBs+r10LhSBxQ4+g03IwoYGyk0aenF076MU0u+NxWUY3RYhb0fwxOemHJM3MzGZKg12F8yLmcSZuKW+WNWXrsbbgtYQtTmc0yRq0dQw4BjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XeqPmMJZ+8CnIJjSeKkGG+vz8qOWn+PJ81D0LKkR3ew=;
 b=aTrRi7MJ60oZKR6wmFCVLe8u8as9fRhYX8E2cXQEPYbKPqoHZ7I1TEF3SGEV7kTqJ62Y8dn3sP/RGDSw6mrUL5OO8nodDhJ3v8cdWyIHzpZLzomrd6h2MR4FT5nlkFwkyWv/2Vf8Z2ZVGVTaknv14zdz+1W6hXKMl6D1sKo8glPaMm+QLIKuQjfq5rXOSkQQOUFxaWj50NeUm70YK4pKontr3UhnWmg/2jAnx3xbjy23iVOtLUk6MKelRhn0RZxbUGIyOCwq27+zjT7YCYmf7ZQFSfHOPrcBDJ5tv/izf4Z4jth6KC7e4gUg+pVta0rAK/dgobbsCyNeUJdauLN4JQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ff8559d8-12b6-9218-94bb-8c9a731250a2@suse.com>
Date: Mon, 24 Oct 2022 13:04:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 3/6] vpci: don't assume that vpci per-device data
 exists unconditionally
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
In-Reply-To: <20221020094649.28667-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0038.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7744:EE_
X-MS-Office365-Filtering-Correlation-Id: 13418313-cbef-4906-f442-08dab5af75e1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Vvi3WnABBc4eqDEwgzO+zTQbSS4YzFtYUVNykBc8apoS3yhky+00HOL95D/uGLfxYGCItN/eP0iTBDgbhh/TyptOvV7ygDZsczkMcxhSzPSWVvE+BhV5WMgiO6N6iq1Kke+Q6/Euee4O8RneWw18Dhm+3r4YbmwmHBA3W8vmAdi2IFbRkgV5M01/+c6uHrHeWChZngfV4AdaCJtb2DDZlabHoxaSj0eUWx6JnqfHZHjyaD2u39MVkmQjjZYF7+9Q8/E9cIgKR3kPkiORP2mvesrTQJ4DpX1359MnzNa9wyhLhUazAeQvHK8hWvpGJNswEZtJtgMxJQRsw/7p6ZAKSFd2hwGfaTWCGvYZ8fMUSoHFZvYG1snUTEDqdM4ZKQ4X1yToepuV8sOojTKdshKAkAvtP1OGb3UJEL0KtkZ2IU0vhFxvAM6OGy5SaebNx6TzuSbseh70szcaywwYdNHMxCxQjBKJNh0Fcwl23jaYlLd/9MfEwZPEALVjOuELk4yPk20Wb71oovTAFlQysvHc/XvLYIp3SXt+scPF3oOHopKkBag2eArSe84vw/Kh9lTalmW3QgCDeYxeoQhaSJdiVJgy4B0CQ3F8KjV9/ckIJEQp889pV2yCh+uJnK/1V5BMy4NGHHj17dFupSHdqZH7RE2mvrxxj9DEK+2RoGrLtaX/Skewfvj50SdAZybYH8ulbGbD9bov2bTCpnp55N/cBSo1fFw1vxCN15Ga+mOV2So0jeMEh4n+MusDxcU5EVIvrM9bBncbp2jEvSKoNY+nX43wjWAFjw2UAmgdGHPzOTk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(396003)(366004)(376002)(451199015)(186003)(26005)(83380400001)(6506007)(6512007)(53546011)(316002)(31696002)(41300700001)(66946007)(66556008)(66476007)(6916009)(5660300002)(8676002)(478600001)(8936002)(2906002)(2616005)(31686004)(86362001)(4326008)(36756003)(6486002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MWI0d0RmRE5NVXBUREtCRTBTd0VibGxleUdPRUNucXp4Yk1tMmdMb3ltSTZi?=
 =?utf-8?B?RUJHelFmM3RRRDVMamlnMU5vb3hIL09QNndzcFpGbEJnMitXZy92SjVNdzla?=
 =?utf-8?B?TUxqSXFTc1JlSjVTclhaOG1haDVOR1haR0FGTWFIZkF5eHFIN2N3c1NPTDZG?=
 =?utf-8?B?L21UM0VwYlIzWWdDbnZUbUpRbmFzNU92Z21ML0ZpZE1HdkZNSXRpOTY1SnU2?=
 =?utf-8?B?T2s2a25OVFVyU3UrRFVIcUlQYi8zeklCb1hzWC9Za3liRmhxSXoyK2h2cnVL?=
 =?utf-8?B?aXlGcTlzbk1DWE5uK2s1UDJaQkNibmhHVFhrT3l4N3ZFUWZrZCtrbll4cFBm?=
 =?utf-8?B?TlJKRmhVZXpQSFJxMnlnNlNjM0FBMXQ3dk40MjA0aGdWQlE0cWtUUHM4aEJG?=
 =?utf-8?B?c3RWYm1tdThVbHpsUm1pdUVDRXNjSmNRM3FOZmpJOHdhNHpSV0VoZEpuNmpN?=
 =?utf-8?B?cnU3cUZ0Y3hsME9DWTMzV0d4TVVhNEhhOHdXNjZzbFJSbEVJN1EzQTN0bzgy?=
 =?utf-8?B?SEd4cDN5RDl0SlAzOEN0S1FDTFdmdkFHdlQ2Ym1SL0dmODR3UjJoNVYyakZW?=
 =?utf-8?B?TEVRQ2tBa0dGRjJESy90SkVyVE5RUkQ2a3BETUVmY1R6N0JaOUZxV1FuSVZs?=
 =?utf-8?B?ZjRvZFZDdDVucGtBWnp2SktxWVQ2b01iWUlaUHZQa0tld2RYL0s3TC85MnNW?=
 =?utf-8?B?MmxpYmRUR2VBOUM1QzVMVGxMS1FPZ1dZb1hTQlZEcjFhWWM0WStmaktwYTBL?=
 =?utf-8?B?cnNxVWh2YmR0bjFNZHhkdVdPWm53azhNOWNoNGRWc25lL1FnR05iOXdaM3Fr?=
 =?utf-8?B?dW5IK011NHNXREpiQ3NMUDNmVmxPYjBzNG1lS091SGltUGd2Z3VCL3J5V1Ns?=
 =?utf-8?B?Q3ZWandaM0pzbWpvS2dUQkc5M2tybUNtaDJWRG1hNFQ0MjNqNzBxeWQzV3JI?=
 =?utf-8?B?djlTamJLeGtPSVlSV3JNcnhzM2FkVU9JblNuU0Z2YUtORm8wVTZHZWc3MlQ3?=
 =?utf-8?B?TEZGR2FjYlhNdk9uUm1MZWc1YUZ6UDR3aG1kRkZKbzkyTFVZa01vL05WNWFs?=
 =?utf-8?B?NWVzMlVLY3QrNDc4emxUZHRlUG9HWHhHNWkwenNUemFqRXNuUlM2ekVGVzh4?=
 =?utf-8?B?V1lGRysrekJQbGJtdjVpcWpNRjRvcE5BMWtmMSt2MENEb0NiR2djeFNKajFN?=
 =?utf-8?B?Z1VuczZ6L01Wb05DNXRtbks1Rks1STU3MDEzMk1udVozYnJMc0F0RVNqREdR?=
 =?utf-8?B?a2VpQzdYU3pXdEs1VTFoQ0w5RHhxU2RpbW5xRHVCeGRqcUVYTVE5a3YrNERh?=
 =?utf-8?B?OXVKc202eFpsa01FWC92WEZrY3hxdTdZQWkveGRZdW9ZKzEzcWFhTTh0T3dJ?=
 =?utf-8?B?ZWk3VmVFVXZkTTJPc2RYUjBCM1RlaWI2MER2MkhiZjl3VG95NHlhdDlGOHVI?=
 =?utf-8?B?UTlBTkRMc056VFhXN0lmQ3Nic2oyT2t5dXZVUkFyd2FEWlRxSlZtYjBFRGtl?=
 =?utf-8?B?UzlOMldsVjN1bE1iRmR4SHIzZ1VTSXpvRS95YTFWWDlLeUtQQnBDa0ZTV2Rt?=
 =?utf-8?B?OTJWWlR6a1FZd3J4UkVZcXNOYUZIaVBPS2FqYmhicnBPYy9jcmVBVjV4YmFL?=
 =?utf-8?B?NzdSM3I4Ly84eVZvOGorVXN6Vkl4VzUvRVpBekZNQlNVenE2TXFUVmNzQ1oy?=
 =?utf-8?B?TzZzL3QxaTVtZzdCelR3RHBLeXlQSWR6UEhhQTE2Uk95SlBoc3NmdmZZMWtY?=
 =?utf-8?B?aEI2bU9NQ2IyZ1BHK0VSckNEWkJLQ3RyNkplSjhJbU9jQzRSb1NqaEdwemdr?=
 =?utf-8?B?WWVHY09UZDlleVUyL3lzZDFxNDRkTTJYOVpDcmM2RHhiVDBnWmxPTnYzczBQ?=
 =?utf-8?B?aHFtb0E4MmtRQkhqZURPa3RDNGUrOUxSNWJKM3l6S21BbFVlVG5HZHZnR0VO?=
 =?utf-8?B?aXFWZHBMQU5ZWDBlRytDcXl3LzRLeEl3YmlnWlhKR3ZNeXdmZ2Izd2pPQmpz?=
 =?utf-8?B?cnBkb1k3emhKTm4zblkyN3QvS3hOS0thNEhrdGJsZWtLcEgxdmErS0lpaFhz?=
 =?utf-8?B?Q09EZEhDSzBRNkM5UzBCQndLZHp6M1FLVGJVU1lRSXlQMmtCcE15QzMyLzIy?=
 =?utf-8?Q?VMBWCkDHiXd++uOgPdsML5p96?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13418313-cbef-4906-f442-08dab5af75e1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 11:04:03.0805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zS9CsJZb48CYHc0TyW8PVnXkJfWThQv1s43g1PlxZa26aY8aSplN1d9GGnYaG7XKUxXu8UGHte7CVhtFil3gAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7744

On 20.10.2022 11:46, Roger Pau Monne wrote:
> It's possible for a device to be assigned to a domain but have no
> vpci structure if vpci_process_pending() failed and called
> vpci_remove_device() as a result.  The unconditional accesses done by
> vpci_{read,write}() and vpci_remove_device() to pdev->vpci would
> then trigger a NULL pointer dereference.
> 
> Add checks for pdev->vpci presence in the affected functions.
> 
> Fixes: 9c244fdef7 ('vpci: add header handlers')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

I wonder though whether these changes are enough. Is
vpci_process_pending() immune to a pdev losing its ->vpci?

Furthermore msix_find() iterates over d->arch.hvm.msix_tables, which
looks to only ever be added to. Doesn't this list need pruning by
vpci_remove_device()? I've noticed this only because of looking at
derefs of ->vpci in msix.c - I don't think I can easily see that all
of those derefs are once again immune to a pdev losing its ->vpci.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:05:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:05:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428885.679481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvGw-0001Sf-3B; Mon, 24 Oct 2022 11:05:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428885.679481; Mon, 24 Oct 2022 11:05:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvGw-0001SY-0I; Mon, 24 Oct 2022 11:05:34 +0000
Received: by outflank-mailman (input) for mailman id 428885;
 Mon, 24 Oct 2022 11:05:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omvGu-0001Ns-Rg
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:05:32 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60049.outbound.protection.outlook.com [40.107.6.49])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c69eaae2-538b-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:05:31 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Mon, 24 Oct
 2022 11:05:30 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 11:05:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c69eaae2-538b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dx4tswjuKJMlnTG6dMeR5Zn0Y+U04nYInz0zZ1iA3Q46ccUMmBb5MM/n/89FzGdsAub55DjQjmc8zzqUimxIkk5qd9djHTP005PkdaNT8S1QETSowpIRlNFCoUofsjIperXpXNAkBw92w7UxauStun5aQzyFsNEdUMrIdJJ49IkIE2jUez0GGip2pREw3eBLFtthK2PE0u/5fpcAIUw3KVcGRgosqc14lakJChCSYlyqYaDu8se78QKq0M9ro3XvFrjD5Cr5UrrO6DIvAsaYUzYQ9PpALS+34RzzZsH7F5T99pG2W9WVAx5Dtf6xWUvxp1bmD8ElYf6J01YCQkCuKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MlJe5/4D1oQR1HBU3dGXySyqrdEtIYFmOkx3OKuw93Q=;
 b=VO1RaaU2WahEiv2cGM8dUjcj15O3SzBhRMvWR3M2JfyYJY8WcQk6SKhc6yY1xTBeKceKH2j50XiBapT7wR29349Kpbp36223HGCMcAPtSLDSwQjYs456MnDKiZZYFBeySpym0EXBPGQbFRBIQFjnvhWWkR7EWDjKz4l/wpWNBjxvCNRepj30V44uv/ow7CkB/kc2uLMiIKp/mrR3MmXtUb7a4Xw1AZhnQC9MvL/3nsF62mLvH3chc8IT7ZqdrxDeOfhrZ1uaZe2oVeDpwb1W15cxkgUo5QeRynzgcUJVLKU1+ysP0cbd9VYc6mNIYOsNelcfVMGwnOqC61GnVR+q8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MlJe5/4D1oQR1HBU3dGXySyqrdEtIYFmOkx3OKuw93Q=;
 b=mTOksvQjN2i//S2S7r0L7ULfpiwVZvVaJWNXLZCE67Z8PuOENsDO8lVzeBUVjGPQ9blJqUkPh1BOUxHPRiRBF6j96M3vLMhGDC2afi3JF1yuREpl7sWS3nVbtIS1KMFPLeDu4NhkxG8+wwttFO4Q88V8upQDe2fdp3yuWOcn2V/G4M2EN/ehFvFAEhn1/NSMJuPaPCgdZk3mADrO9xi8ru+XUYq5jFqDf8NzheMANVIot7GEBsG6pobohe6oEQoih2LQUYXloC7ft0QiTegoj+et47xbV2uzMGGPxr1ukLvHZdKM4llAhwMZGAi+Fh6eH8LGgmB8YgZCDIWYedVM0g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9e40d26-215d-eb1d-8a63-e0697c1ef164@suse.com>
Date: Mon, 24 Oct 2022 13:05:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 4/6] vpci: introduce a local vpci_bar variable to
 modify_decoding()
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-5-roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221020094649.28667-5-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0029.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::22) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9367:EE_
X-MS-Office365-Filtering-Correlation-Id: 409c6032-9a83-4cf8-6895-08dab5afaa20
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DcW807AVH06+N6n2tYUlkRnTLxyVYUs4EHMDb8u/9abKNriw0Z5uj/qFTcGnCZyv8P+AN9VQS89C4pKkRzSJt3nMf8IWbkXSzXClbopG3lWdLcGMIN9QVSQaRsH7xfWvElGOBp9Y/OVO7Pmlxx/7vmuSwTFtmB2sF5bIY6yb2ByWdMHwcLLn8u5W4gww5Fp4Nrfq58ozweVtdJoL3GB6ejS0x0p69NkZ3R8HdT4gAsbwdX92NO8p9JYo21uWnlI+yGdZxsKrF+KVKtU5Vbxdr4bGHvsb0M2Rb1gn2eOnoREEBpsS7SLV7/whNG4Yj+70i/62577ZhQbk++cfwDN5o1MCAoByW8+G1Bcj0H4KpW1uDygPDKPNErMGFFr0gIRBmecpZ53bIgLRCNNzeUqijc2YEbxSU4w5ZFSHzhqqMyld4Wog4bXzNlQiOfyq4Cl/rGO1uFRGVRRSlahtOiqSjpYZOmuZ9ptsj79Z3zJBKIf4ZGqF3I/dF5lTPgj8KJ7vIT2/WAozvdr8wjGB0AlOCKdRAjokN+ePaeWyCcDM1ijW11AtCzjFvznKPoFM1Rpk3ebE+Q1d5ZOXmavvb46Qxl4+fkykmF+iJHxXmxIAoeT3j/AxSDuNGTOJ/n1K5hPUwb//38reinyRrndLVQo/lRr4u6pxVNC6Awv7yDGcEN6/vLDXYWyurZPgWbGCOczwnUFPhb77g/VwqDglhl/2QG6CcbBCFvdxAT3WrFx0WGQFwC30w3mDN5x9RdWFgVgJybemWmSfTyjCDaE6Ogzcmi6hgj99F0ZG9J+c46OLIPQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199015)(38100700002)(31686004)(478600001)(6486002)(6512007)(8936002)(186003)(6916009)(41300700001)(316002)(36756003)(66556008)(86362001)(53546011)(8676002)(2616005)(558084003)(4326008)(31696002)(6506007)(26005)(5660300002)(66476007)(66946007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZktlRVJ1QW14MW5TQXJaVHFHZHlFWHJrVCs3aG5INHZVUzlKdlpZY0NNN0tq?=
 =?utf-8?B?Vmk1ZlpMWjBuR0N1dUlQcGNKZFRQSm5GTjdJY3BpOGdGaUJRb3FVdzd1Wklt?=
 =?utf-8?B?T2F2bFk1a2UwL2MzT1FWNEtrSktXVGlnellzTGhTSGYxRGdRbEJwRTdacytH?=
 =?utf-8?B?QWRUdlBVVTBKMmpGSnVML1pDd1RFZzRWQUdkYXQyRVducDh5dUUya3EwY3BC?=
 =?utf-8?B?YnZvSWluNHFNQlo4aXlFTmRxMUtFKy91WDVvZ1h1WldOaDI5RXNoWVVhS1hh?=
 =?utf-8?B?cFNJTlpSMXBMK3pOVThtVzc5UlphbnIrbld5Zy8wZFAxQjVUL2wvU0tIa280?=
 =?utf-8?B?S0N3REFybG5aRkNxb3EwV2lNd2g5aWZxMXJZV0lKSTNzR0RVUUkvaTg4M05y?=
 =?utf-8?B?RlVwcXFJSE5VMk9ZRm9oeWUzazJ5cXJGaStUOTVoVkd0ZXVyb2Q4eHp4UitZ?=
 =?utf-8?B?QkIrNjZnWWlZSC92clpRNWQ2UXRUQXJiMDkxcW5MODl1aFFoMHRITDRJb1Nt?=
 =?utf-8?B?ZEdPdDVvTGJDVDJudlVIbHlialRTV0gwcWtkZ1JSaTFaNk4zWXlYSG5NcGhZ?=
 =?utf-8?B?TTFrdllQN292cnZjWG1XU2lYL2V0bUdLVU9uSXpleVVqejNvb2VGOEJxeWhi?=
 =?utf-8?B?T29LemNqVnV4a2NwMHU0RFlBVmxNYnY0cHdocUxwZ1BnMmZHc1YzTWNJa0Rp?=
 =?utf-8?B?NCtrMWtkMTFOcUVrNDU1VU1TcDYzZnBWd1RhTGMxdWwrUnhMNXdUL3dyZEdp?=
 =?utf-8?B?SEdFelY3TUV6TGV4UkZGMmI4WjJ3TFQ0ZzRvTkNRQXRURjN4ODQ4WTJNV3ZX?=
 =?utf-8?B?KzU1RHpzZzYyV0dmc1ZUWkVqQzE0Wmd6T0VIaXRkaDVwanZhOFVHNDVjVUti?=
 =?utf-8?B?Qkg0YUpkcGV5czhKMEdZRTNXRGRObndoM2ZzMVlIMTVvdVVnWFE1MThkTVFv?=
 =?utf-8?B?enljcm5iT25QcVBWQWd3Uzh3Z00zbmlQaDNLNFpQbS90dmgrNkRKQ21nbWZD?=
 =?utf-8?B?bkRmYzJjRHVFZDF4YnVHaDN2dC9wN1JERVlsT0w1eDVBT2R1OWZ0WmxyOHpF?=
 =?utf-8?B?NmNqdEJTNHA1K2xiZkNWY2RMdHo3ZGJQZ0tQNmpmWEUxUUdXbnpBd01OSTJn?=
 =?utf-8?B?K1UxcFA2RFZvTm1TOEJESHkxOFM5ZWd3b29KUlk1eld1LzZsSHg2N3ZOOU5B?=
 =?utf-8?B?MDhPNXdRbHRXaHBLRnRaLzU2U2I5VU1oM0EwZVFmSHBFZE40cXd6U0N6SWx6?=
 =?utf-8?B?aFFaMzAwclIzbS9OR2VUTzZUc010YytZYm1YWWczV0JlQXRTTmtIOE5sRnVy?=
 =?utf-8?B?U0M0elV1YTFnS2x2U1Y5Mi9FbVhwanE2eDNLZzBvY2lJNUkyMFU4aEVYRFFu?=
 =?utf-8?B?Y0dDQWcrWTZWajYvdlNDcDRjOUc0UW1WSFJxWmdSdmdYVlN0N3dRMm9yYUl0?=
 =?utf-8?B?Z0wveDZqT0dRaXp5R1hoU2lIODk0MHFCMDdrZXo5RWZDMy9rWkl0NVg0M1Ev?=
 =?utf-8?B?bndXQWtjY1MwK2dKZitWZUJUMWFSanJLK1dPTDk1Y1JhTmtmK0hNVnlwY2p2?=
 =?utf-8?B?Q0IvU21PbFNXdXZtUENxQVBVcitZNjhyVk9hU3FLeitGc2hEU3loSGMvcG9k?=
 =?utf-8?B?NHVJZHBFOXkwZ2RLMHR3UVdEbXdXNWZ5c2szdUM5TXowb3RKM3FZTldkZFpq?=
 =?utf-8?B?TGJhcnNBcGs3eFBDS0s1dy9yN05FQ0JFZURJTS94dldBbENlNHZBMzdiSVh3?=
 =?utf-8?B?RHBkdmJvRkk4Y2tTZHd1YW04N1VCeUh4cm9nKzY0SEppQ2Z6eVBMVjlQTVRM?=
 =?utf-8?B?blNFYWhUZ1NBSVR4bllhR0F2eGtkMEZnbHcvQ3RmRDNCWk5uZEU3VTFjUE9j?=
 =?utf-8?B?a0tyOEtvK3ZYV2MxNktrb3ZOayt6ZVhnWXRlM0gvUXB0RFNIZTUvSzhrT1J2?=
 =?utf-8?B?blFTY1lKeU41SWZXZTVINFRhREhPd0p4V0xlbnk4elAvQUZsUGNJWElBa3BJ?=
 =?utf-8?B?U1E2a1FibjhUTXlrQkk4bnFUWm5zT0c3VDJWMGtyRUE5NVMzQjRoejMxZk9z?=
 =?utf-8?B?K3dXbVFDUjdXZGZ4OXIxTEtuK0ZXQ0c1V1BBQlFGVkg1M3dNUVhLUElaWDVZ?=
 =?utf-8?Q?dFZpa4Jh4zzbmSaacMsfPv6bh?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 409c6032-9a83-4cf8-6895-08dab5afaa20
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 11:05:30.6532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J1YYn0Rl9QgeVWeLxoCVQfjO/T31L5QRZNNKU/4ijcm5alFhtKvRotjEBHsgUWoxI+QAi9UoFbApLD2dE6c/oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9367

On 20.10.2022 11:46, Roger Pau Monne wrote:
> This is done to shorten line length in the function in preparation for
> adding further usages of the vpci_bar data structure.
> 
> No functional change.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:19:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:19:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428893.679492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUN-00036f-Es; Mon, 24 Oct 2022 11:19:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428893.679492; Mon, 24 Oct 2022 11:19:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUN-00036Y-BJ; Mon, 24 Oct 2022 11:19:27 +0000
Received: by outflank-mailman (input) for mailman id 428893;
 Mon, 24 Oct 2022 11:19:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omvUM-00036S-GD
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:19:26 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b75150ce-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:19:25 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB7840.eurprd04.prod.outlook.com (2603:10a6:102:ce::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 11:19:24 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 11:19:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b75150ce-538d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gZAk5fdYMq4mrTpbe7/ge5UguUqSHnl172nZ4ALV0MGLiapCLFgtI5jZtpZ68uWvFFpOt7zXJSyXL7o2Gd952fG0Nkq5d7xEiyifJIOa1irqmzXRIFy+wy5zpX7W7XRBxIZ29TcgFiNxsZ9vb+jOXpRYPGOAhuzFqffCuHOE1lyesIP0hht9/k9klbfYhKn68tbhaMbJZ7nbjta6XafOq9K4aZQQurJZVrRb048E7AszPufkW6nzklg0V6iKgjUz/2d8i6pYt50ySy3/KLPets7EDKZSuQoUmE1sJnkDS3iRDvZgNbR2KJYYxdCJ57PG42YpRd4lWiju+ZLcsyIQEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r8kZznpgOg5CqY/vO6wbKyA14Iki5cPMQ5lTivfHkHg=;
 b=SBdvT9r4kXj+sJlW1yNEF8ZlWey50K5QqiZGfpTWzIfRPO6LdwnyJ2jfn3SnLZBRgZHNDKAC9b5+wn7p8cyhyYz2kRrroG/w6m7G+Qkh5nR2BV8I72RW8/8eaO018p9vS9g0uQdNIdH82v3U5LwwMVSr8KBKQzzN9OVLwc3mnvbxm2yRWQ0WXmNo3i0zNkKjlm2bkciUGopG10QQY8J7o7b/TFYfbIFtKjpRs6egLmMyA6dsm5mMs39WSNtvFak8HchQxcukfyZRM24dUsj9IpL3Jh/8hJStuJUSdD+smkhHMncvrbliOsDcH7X7SqhkjoSSu2d2uIBaWhM9p42qkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r8kZznpgOg5CqY/vO6wbKyA14Iki5cPMQ5lTivfHkHg=;
 b=mYVHhWmVCr8GR0fKmVII/8R3OjRnmm/2wJdbFRVcehEth9jZ60P7xY6tqeb/qgyvG+zvqYf1qOR1u4r7Gg8F22pAClNKk8kcyz0ItANqVyGyR6ea2PGYYHI1ZBo3NEm752TB9M+dolf6nJD1hYVo0PAA5qx0QiY9p2UZebLy3nq+2QO7ApBzbj97TQwH0bgAFz5ejfe3mkB0mxx7ZRJOdzhtobfKUttZitRPmqLMLotGPzc5wQWUBy9z3XqfEfMsQL1amFNdj01a+EDYlqb52Q0EldwXGACMPv6moWPgKeCu7UNl33a/OWTkwfANSzLrs1WqWip0TqJ1PYPaOxrKrw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
Date: Mon, 24 Oct 2022 13:19:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 5/6] pci: do not disable memory decoding for
 devices
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Paul Durrant <paul@xen.org>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-6-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221020094649.28667-6-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0107.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7840:EE_
X-MS-Office365-Filtering-Correlation-Id: a2137ebf-5e4b-4b87-8ec6-08dab5b19ace
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+ZkLFoQUVopRwzabIFHwBpRmQGoMe1weekABmYcqOIR/QotzVM8myIM4Zj7AgFrrvfGdZVg72NkpcPIci2vNwQqQTALxUCcayWpPcj/eYe8sif0gVoZnOPeURZvk5S8ezm0Vszh9OXCcchzptLEs0/Ou2a0hclyLwrchxf7Jxw4Tiadu7OvfbX+POBHRnL/ciP2Cw3ZIilaosYZ76TyHiDax0Ga1G6VqaqKh2LcOZyv28OclKpKb83NZp3Vemf7ANbNH5I6Q6/m0WkWuay1ZBKc5gWiBo3CdgssejSmApB8VoxlE+PRx1v1cNrpf8oMqFbV93ctx7BerygAR0vYq+M9Uv0kPYlTH3efnz7UiWD6uJLEdRxZF439w8+u6TGlgm8JrN3WWelQcX/JIstIdBCGxl+LXwaNckmynKtWzt5DcF9TcgvHAM/2Q/K9mYNma4GL4PRg/sCG4SAklJbCUG9FqpP1gXZa/tPkZPbn5cJEaGK0TERTTNI28BADxFdu6jme0ir13IwYLrMgwG1ARIZbM7ILZmVzDzgOP9LgCku3UL4UqBoPFobMx4SGmeJOh31L4o53trP8PWKnY9yo5TOP3ahecihUsuJOTKIC9qnHXL5mKdG2UVVHa8DBqU8jCWGp4WK/siqWNiMGaVgmOjPi/6IRiFw1RgTiO+JyiXcCPUfG6sRKg6oU/ThAlX8snV+N3IwO8+8jm98rkOpSc2cIcaEm6uoZc/DoOELZ19KckUY/KwCdWUfjSSkBr4ygGh8VG09tLkhAGDWxBOYSFB0q8IWsUqofGWJ8fRbTjuTU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199015)(6486002)(478600001)(31686004)(2906002)(38100700002)(5660300002)(36756003)(41300700001)(8936002)(66476007)(66556008)(8676002)(66946007)(4326008)(316002)(86362001)(31696002)(6506007)(26005)(6512007)(53546011)(186003)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c1hBR2kxVHJvd2liQTVYUUxkT0p4ekNaaGJQc1VmZFJ1dTZKR3hNdGFJU3ZI?=
 =?utf-8?B?RVlQSFJMYytpNHZtMEgzQzMvUzBiUUllaVNoQ1F1VVRyb1FOVDF3by94ekEy?=
 =?utf-8?B?TnpDS0hyYXdEWCt4QnNaTlRSZzJHamtFalRmN0psdXVwS2J1WlQ0SVlEMEtC?=
 =?utf-8?B?Yk05aFpNVXAxay9YMEFjV3lHOUJYMGpLQlZoK3ZqYmlHQWtMMUVmWmRhSjhz?=
 =?utf-8?B?SFBOTzlIMEY4aUVyNFBUd25qdkJoZWJvWURKSDN2Zy9FbGtPUkF5bzB0YUow?=
 =?utf-8?B?dzBPcjExQmhVdDZwWW9pMFA3Zi93V0UzLzRJWUk3RUVwaGppVUY1RkRKRTM0?=
 =?utf-8?B?Y2Q2ekFJeWUzWjBvQzRjaXV0WmVsUG1MZkFjWW5uSTlTRFB4bHN2RFEwMGpT?=
 =?utf-8?B?cUdvVC8zcVh0WXpHUzRjRm9XTzErMVRneGxZVHZNRTNvMGg4Q1FpQ1NOMkZQ?=
 =?utf-8?B?bEhKMk95S1hGWGdidGJaSFE4cCtzeC9YSVpUTVh6VE1QVEVtNWQ0ejlsdU9i?=
 =?utf-8?B?OVFCWTRxWVdzd3NaSHZZbkdrYlhpYldqd3gyN0xOZDM4UC9OTGZJQTNCNC9k?=
 =?utf-8?B?VHQzcm9tNkFzYjAzbUxWQU9CWElNam9rcVhxSmpCbEtRejRRV2cxNnd1cm1a?=
 =?utf-8?B?NHFHRU44WkoveFdPR2QweHJRendsbFlQRFZIYzUrdTJlRGFSLzN1aEpCVk9i?=
 =?utf-8?B?NGhHQnkyU0xQUmREcVBGNGVuQnRuT0UrUlkyZlJLanNET1M3Z2JZdXZQd1VO?=
 =?utf-8?B?bWJoQWJuZG1kRnR3NW9TV3RSMjRlV0hla0V1c09SaHNJc0IvdW14N2hKK3R3?=
 =?utf-8?B?NTh5ejRyblhqOVVSQ1EzL0hpWnVjV0JzMkpTWFJJYUQ1WjB3dkVkaHRpcVlB?=
 =?utf-8?B?Rkt5cWdSZXpHQlFLb2NQUUlzdG5wZy9kRVNhWHE5ZkZGZ21vRUNqQ2FXUU81?=
 =?utf-8?B?NzZDSnUwakdMUnFWNXBVT3B2dFptWmdiVy9UdTZ6UzRSNWhKUjhxeWRYeS9P?=
 =?utf-8?B?UHZiR1V2R1oxMC95aXpsMnhUbU9zSnNabkZOUmRUVmFDcWM2MGk3QUY3QS91?=
 =?utf-8?B?R2w1RmJZb1R6dmFIZHJCV2NSaVBSSiszTlFyMk9kT3lxazcva3poTTJZaWMz?=
 =?utf-8?B?alF4ZG5NUUdJNzhOOVIrUUh1RE9YVExVbHpYaXZJM2xEK29IeEhEeXBxeG5t?=
 =?utf-8?B?bGJNcEViVnkrSnlKOFljL0Y5cWo4Y21ubFhwV2s0SkxiQ2xWcDJqMTZFVGV3?=
 =?utf-8?B?Nnk0eHlJaHZxN1dBUko4WTNWVFZDTTEvS0I0MFR1aFE2VzZGeWVwb28wWDNp?=
 =?utf-8?B?N3Y5SnVESUtKYVk1YW1JdVdaWFpML2VmZm1ZVURqc2RGc1NBQkJ1U1dYcVgv?=
 =?utf-8?B?M0kzS1NDS0tqbWxLSDBLY3FqbS9uTVF4eGIvYWlaSG1JVzIwOWFEWGN5Vlpy?=
 =?utf-8?B?ZEtockFsdHFUVDZvVzhWQlRIenpBZXFhVE1kaHBmdXJhUVFhV0s2RHgrUnVE?=
 =?utf-8?B?MjF5RzVEWDRsS0JmVFl4LzV1ZE8wTWYzemxoV1N5WEZ6QTVuUzJ3d1RacXpP?=
 =?utf-8?B?Q3Q3Rjg5UURrS0tkbG14bm8xYzdCdjRxN1NSQmRxazhVTndGUDZIZXVuRkNq?=
 =?utf-8?B?YWI5ZGRFUWxWVVExZnhTQTdydG1WTDBDMGwwQUhVYlZoUUV4bVdvNVJ4cko1?=
 =?utf-8?B?L3l5ZFFRcVRXMHRmdlJvMDRVRUJOZFhKQjFJc2RJY1U0Skcrc3BPMzgxM2ZN?=
 =?utf-8?B?VUpLVnJLSEcvRENyU0VKRUdKbGhUTjJBcm1PR0hxRGV5QkV0bEdlS2JSUHdT?=
 =?utf-8?B?U2JMWlRvTkdnTitEVGxxTWQ1bVphRFRaNmhyTlRWUTF2eG9oWnNKWVh4MDFH?=
 =?utf-8?B?ZEdBVytnNlg0V3F3eFdUbG1VWDVScXFSS0d0T3g5YldOMjdDaXU2Z2JHK3Zy?=
 =?utf-8?B?Qi9QUTlPNTVvZk1oSXRPa2tkRjNFRGFLRmR3VWRsYVJBZ3Z1alhIbzBtOGlk?=
 =?utf-8?B?V1cxT044amt0K1cvZkVyRllDeU0yd2ViUjY0ZlpGUTN4T0VKcjhuNVAxdHZj?=
 =?utf-8?B?ZEZKQ0F4K1o4QmRZcXIzMG1vMVJYT000TkI5QUJzc0RJdGZsQVdUMGhpYWJj?=
 =?utf-8?Q?6V2g647GfyiEMobiRI816XiW0?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2137ebf-5e4b-4b87-8ec6-08dab5b19ace
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 11:19:23.8507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: clHIZxwe0vEYfRKBXjzhPvlCHo7pPth8DEGjjD1upDn5/lhodrZnac2elPmRASx5NXOc1NT1VypXSFU5Yy5pNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7840

On 20.10.2022 11:46, Roger Pau Monne wrote:
> Commit 75cc460a1b added checks to ensure the position of the BARs from
> PCI devices don't overlap with regions defined on the memory map.
> When there's a collision memory decoding is left disabled for the
> device, assuming that dom0 will reposition the BAR if necessary and
> enable memory decoding.
> 
> While this would be the case for devices being used by dom0, devices
> being used by the firmware itself that have no driver would usually be
> left with memory decoding disabled by dom0 if that's the state dom0
> found them in, and thus firmware trying to make use of them will not
> function correctly.
> 
> The initial intent of 75cc460a1b was to prevent vPCI from creating
> MMIO mappings on the dom0 p2m over regions that would otherwise
> already have mappings established.  It's my view now that we likely
> went too far with 75cc460a1b, and Xen disabling memory decoding of
> devices (as buggy as they might be) is harmful, and reduces the set of
> hardware on which Xen works.
> 
> This commits reverts most of 75cc460a1b, and instead adds checks to
> vPCI in order to prevent misplaced BARs from being added to the
> hardware domain p2m.

Which makes me wonder: How do things work then? Dom0 then still can't
access the BAR address range, can it? Plus with this adjustment, is
...

>  Signaling on whether BARs are mapped is tracked
> in the vpci structure, so that misplaced BARs are not mapped, and thus
> Xen won't attempt to unmap them when memory decoding is disabled.
> 
> This restores the behavior of Xen for PV dom0 to the state it was
> previous to 75cc460a1b, while also introducing a more contained fix
> for the vPCI BAR mapping issues.

... this (in particular "restores the behavior") a valid description
of this change?

> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> AT Citrix we have a system with a device with the following BARs:
> 
> BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
> BAR [0, 0x1fff] -> not positioned, outside host bridge window
> 
> And memory decoding enabled by the firmware.  With the current code
> (or any of the previous fix proposals), Xen would still disable memory
> decoding for the device, and the system will freeze when attempting to
> set EFI vars.

Isn't the latter (BAR at address 0) yet another problem? I have to admit
that I'm uncertain in how far it is a good idea to try to make Xen look
to work on such a system ...

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428896.679503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUv-0003eM-Pj; Mon, 24 Oct 2022 11:20:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428896.679503; Mon, 24 Oct 2022 11:20:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUv-0003da-LZ; Mon, 24 Oct 2022 11:20:01 +0000
Received: by outflank-mailman (input) for mailman id 428896;
 Mon, 24 Oct 2022 11:20:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUu-00036S-Iq
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cbdf0728-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:19:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 144561FD87;
 Mon, 24 Oct 2022 11:19:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9654513A98;
 Mon, 24 Oct 2022 11:19:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kMjTI950VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:19:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cbdf0728-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sHEv3PMrKNnInemYrMBOWuesS2nTAxE1RBtBG3/fya4=;
	b=DU+FrXvCzuxXQKLji2130cdqJNDZWimFa17voIFRqiJi9YV6yEP/tBOuVsk/aXIYcCZ22y
	dJiA417KPEM2/2KMkoVkU4zzdd8/7BAQ4EpaiKoLTwl80ROKkpi47TqcaKS1RcNYwv6d18
	wgULj8VNsST/jnqrt41vfMG2qbcKw9k=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610399;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sHEv3PMrKNnInemYrMBOWuesS2nTAxE1RBtBG3/fya4=;
	b=DFl0JbhoaL2BQZ30SVNdzW5dYpDazf0fWLsyS8qsMNBMAzt7PPP4vh0I1oF+6Qg/vaPBp/
	dCQW5hsUlPHLLpBw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 01/21] drm/komeda: Don't set struct drm_driver.lastclose
Date: Mon, 24 Oct 2022 13:19:33 +0200
Message-Id: <20221024111953.24307-2-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as komeda uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 451746ebbe713..62dc64550793e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -10,7 +10,6 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
@@ -59,7 +58,6 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data)
 
 static const struct drm_driver komeda_kms_driver = {
 	.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
-	.lastclose			= drm_fb_helper_lastclose,
 	DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(komeda_gem_dma_dumb_create),
 	.fops = &komeda_cma_fops,
 	.name = "komeda",
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428897.679515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUx-00042x-7G; Mon, 24 Oct 2022 11:20:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428897.679515; Mon, 24 Oct 2022 11:20:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUw-00041d-VY; Mon, 24 Oct 2022 11:20:02 +0000
Received: by outflank-mailman (input) for mailman id 428897;
 Mon, 24 Oct 2022 11:20:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUv-0003Yp-8T
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cbd2bb5a-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:19:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 8A50B1FD89;
 Mon, 24 Oct 2022 11:19:59 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 18B0613357;
 Mon, 24 Oct 2022 11:19:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YANHBd90VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:19:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cbd2bb5a-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wfe4V8EQXU+OQKS3l1kyBjPu6yaqxe3odm+OUovraU8=;
	b=YoF3oacrONSUp2l94BtKx5fBnWKElJU/yogS/8MNCCGMsworisr14Y36F6Lwp4Eb2AXd6Y
	JAwp08Cr1375BWPMlmH3zexeDLYAJq12kVWRooll0fz+iQ0sTzPnocZme8JAylNQeRwCKH
	/1mWBYvnwJ6jPd9lQPRySAqxyDWa6yY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610399;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wfe4V8EQXU+OQKS3l1kyBjPu6yaqxe3odm+OUovraU8=;
	b=JSDB/UaJfrDcGAQ5TAQ9ip+VMPtSz/njXMdJqHFH3VDhzQrR1sjHbVWq7xFhcQbIPi060r
	GGZJGS/47HGv3QAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 02/21] drm/mcde: Don't set struct drm_driver.lastclose
Date: Mon, 24 Oct 2022 13:19:34 +0200
Message-Id: <20221024111953.24307-3-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as mcde uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/mcde/mcde_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 1c4482ad507d9..38c3907bb151a 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -203,7 +203,6 @@ DEFINE_DRM_GEM_DMA_FOPS(drm_fops);
 static const struct drm_driver mcde_drm_driver = {
 	.driver_features =
 		DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
-	.lastclose = drm_fb_helper_lastclose,
 	.ioctls = NULL,
 	.fops = &drm_fops,
 	.name = "mcde",
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428898.679519 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUx-00047F-JO; Mon, 24 Oct 2022 11:20:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428898.679519; Mon, 24 Oct 2022 11:20:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUx-000468-9o; Mon, 24 Oct 2022 11:20:03 +0000
Received: by outflank-mailman (input) for mailman id 428898;
 Mon, 24 Oct 2022 11:20:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUv-00036S-Iq
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc77aabb-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:00 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 483001FD8A;
 Mon, 24 Oct 2022 11:20:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E1BC13A98;
 Mon, 24 Oct 2022 11:19:59 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WNHmId90VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:19:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc77aabb-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4LfKpOswsnembvGTw5A10DEjilDnUQNy6bx3ya4350M=;
	b=m//CahVjAIiwm/8S9Rrkcalu4YtsvYMGGlJ/x4Cns20xgjuFMU4yn3EqTWSWLmkTa9FkiO
	P1egYdKroy9VxXHn0JsFcKjWtsyvCOmSPeGERoEx8TVmcqNzs14xAcL9DZvbr8t/4xCHCg
	/2U9Styzy9LPub+xgp0gbwecRUNssHg=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610400;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4LfKpOswsnembvGTw5A10DEjilDnUQNy6bx3ya4350M=;
	b=4UdU9G008irTIhYRdGZAhb4TkPgDNu7vcVNG1gFEt2csZ303NBfR+i2HKEQYQeahsz2TFN
	M+Z1LM+GGDDUmeBQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 03/21] drm/vboxvideo: Don't set struct drm_driver.lastclose
Date: Mon, 24 Oct 2022 13:19:35 +0200
Message-Id: <20221024111953.24307-4-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as vboxvideo uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index f4f2bd79a7cb6..1cd716eb17a1c 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_drv.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c
@@ -178,8 +178,6 @@ static const struct drm_driver driver = {
 	.driver_features =
 	    DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
 
-	.lastclose = drm_fb_helper_lastclose,
-
 	.fops = &vbox_fops,
 	.name = DRIVER_NAME,
 	.desc = DRIVER_DESC,
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428899.679525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUy-0004G7-6Q; Mon, 24 Oct 2022 11:20:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428899.679525; Mon, 24 Oct 2022 11:20:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUx-0004DX-Pq; Mon, 24 Oct 2022 11:20:03 +0000
Received: by outflank-mailman (input) for mailman id 428899;
 Mon, 24 Oct 2022 11:20:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUv-0003Yp-Mk
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb5b37a2-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:19:59 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 973881FD86;
 Mon, 24 Oct 2022 11:19:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03E2813357;
 Mon, 24 Oct 2022 11:19:57 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zybkOt10VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:19:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb5b37a2-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=hzNk2J1kv0hvXKhIHs7HnwozHE2hDAXgOdFZp8AywGo=;
	b=HkTG27jc1phmO2sYSspbljuTMragV3RllZDVeL22LJUT+RamYsIuqsaoqDlSHb0l9OA6q6
	GT0tqNWWqBg+tcq/3TR4T/xB1NJ2r0tlY31pSNOZnxJ/sjEt0/Pg+eWqW99hZIupGc0ZMW
	XR3pQTAbIh0q7Iv51jt/wuMpfkBc3pw=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610398;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=hzNk2J1kv0hvXKhIHs7HnwozHE2hDAXgOdFZp8AywGo=;
	b=WgrsXz4shLgIugdW3McjjV/i28ZaSykMoNzWHCg2sSAlZ3E3ktA3U8MVWkGJBmn75Oj+fQ
	sylXkr/Z8upKERDw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 00/21] drm/fb-helper: Untangle fbdev emulation and helpers
Date: Mon, 24 Oct 2022 13:19:32 +0200
Message-Id: <20221024111953.24307-1-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Separate generic fbdev emulation from the helper code that is shared
among the various fbdev implementations within DRM. Affects many drivers.

It has become apparent that our fully generic fbdev emulation will
never produce optimal results for all drivers. In its current form,
it is also hard to maintain. The goal of this patchset is to improve
readability and streamline the fbdev helper code within DRM. In the
long term, we want to get to a point where drivers or memory managers
can pick and combine the various helpers for optimal fbdev support.

Patches 1 to 8 start by preparing drivers. Setting struct drm_driver's
lastclose and output_poll_changed is not required by generic fbdev
emulation.

Two drivers depend on fb helpers implicitly including other Linux header
files. Fixing this in patches 9 and 10 allows to remove unnecesary include
statements from the fb-helper header in patch 11.

Do some renaming in patches 12 to 14.

There are currently various implementation of the fbdev I/O helpers
with varying feature sets. The fb helpers for fbdev I/O should all call
fb_sync, which is what fbdev's internal implementation does. For DRM,
damage handling needs to be performed after updating a framebuffer. The
damage worker is part of the fb helpers, but the actual update logic only
works with generic fbdev emulation. Separate the two, which also gives
other drivers an option to set their own damage handling if neccessary.
The full-featured I/O helpers can be moved under a shared implementation
and called by all drivers. Patches 15 to 18 resolve these issues.

Patch 19 changes fbdev disablement to work at the level of display
detection. If disabled, generic fbdev emulation will be initialized,
but no display will be detected. It can later be enabled by changing
the parameter in sysfs and plugging in a connector.

Patches 20 and 21 move the generic fbdev emulation into their own source
and header files and clean up the include statements throughout DRM. Many
drivers only call drm_fbdev_generic_setup() and can avoid including other
Linux header files.

Built on x86-64, aarch64, arm, ppc64le. Tested with various combinations
of bochs, i915, simpledrm.

v2:
	* fixed commit descriptions (Christian, Sergey)

Thomas Zimmermann (21):
  drm/komeda: Don't set struct drm_driver.lastclose
  drm/mcde: Don't set struct drm_driver.lastclose
  drm/vboxvideo: Don't set struct drm_driver.lastclose
  drm/amdgpu: Don't set struct drm_driver.output_poll_changed
  drm/imx/dcss: Don't set struct drm_driver.output_poll_changed
  drm/ingenic: Don't set struct drm_driver.output_poll_changed
  drm/logicvc: Don't set struct drm_driver.output_poll_changed
  drm/rockchip: Don't set struct drm_driver.output_poll_changed
  drm/panel-ili9341: Include <linux/backlight.h>
  drm/tve200: Include <linux/of.h>
  drm/fb-helper: Cleanup include statements in header file
  drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper
  drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix
  drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info
    postfix
  drm/fb-helper: Disconnect damage worker from update logic
  drm/fb-helper: Call fb_sync in I/O functions
  drm/fb-helper: Perform all fbdev I/O with the same implementation
  drm/fb_helper: Minimize damage-helper overhead
  drm/fb-helper: Always initialize generic fbdev emulation
  drm/fb-helper: Move generic fbdev emulation into separate source file
  drm/fb-helper: Remove unnecessary include statements

 drivers/gpu/drm/Makefile                      |    2 +-
 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    |    1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   |    2 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |    1 -
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |    2 -
 .../gpu/drm/arm/display/komeda/komeda_drv.c   |    2 +-
 .../gpu/drm/arm/display/komeda/komeda_kms.c   |    2 -
 drivers/gpu/drm/arm/hdlcd_crtc.c              |    1 -
 drivers/gpu/drm/arm/hdlcd_drv.c               |    2 +-
 drivers/gpu/drm/arm/malidp_drv.c              |    2 +-
 drivers/gpu/drm/armada/armada_fbdev.c         |    6 +-
 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c       |    2 +-
 drivers/gpu/drm/ast/ast_drv.c                 |    1 +
 drivers/gpu/drm/ast/ast_drv.h                 |    1 -
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |    2 +-
 drivers/gpu/drm/bridge/tc358762.c             |    2 +-
 drivers/gpu/drm/drm_crtc_helper.c             |    1 -
 drivers/gpu/drm/drm_fb_helper.c               | 1081 ++++++-----------
 drivers/gpu/drm/drm_fbdev.c                   |  512 ++++++++
 drivers/gpu/drm/drm_gem_framebuffer_helper.c  |    1 -
 drivers/gpu/drm/drm_probe_helper.c            |    1 -
 drivers/gpu/drm/etnaviv/etnaviv_drv.h         |    3 +-
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c     |    6 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c     |    2 +-
 drivers/gpu/drm/gma500/framebuffer.c          |    6 +-
 drivers/gpu/drm/gud/gud_drv.c                 |    2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |    1 +
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |    1 -
 .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |    2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c       |    2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c   |    1 -
 drivers/gpu/drm/i915/display/intel_fbdev.c    |    8 +-
 drivers/gpu/drm/imx/dcss/dcss-kms.c           |    3 +-
 drivers/gpu/drm/imx/imx-drm-core.c            |    2 +-
 drivers/gpu/drm/imx/imx-ldb.c                 |    2 +-
 drivers/gpu/drm/imx/imx-tve.c                 |    1 -
 drivers/gpu/drm/imx/parallel-display.c        |    2 +-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |    3 +-
 drivers/gpu/drm/kmb/kmb_drv.c                 |    2 +-
 drivers/gpu/drm/kmb/kmb_plane.c               |    1 -
 drivers/gpu/drm/logicvc/logicvc_drm.c         |    2 +-
 drivers/gpu/drm/logicvc/logicvc_mode.c        |    2 -
 drivers/gpu/drm/mcde/mcde_drv.c               |    3 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |    2 +-
 drivers/gpu/drm/meson/meson_drv.c             |    2 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |    1 +
 drivers/gpu/drm/mgag200/mgag200_drv.h         |    1 -
 drivers/gpu/drm/msm/msm_fbdev.c               |    4 +-
 drivers/gpu/drm/mxsfb/lcdif_drv.c             |    2 +-
 drivers/gpu/drm/mxsfb/mxsfb_drv.c             |    2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c       |   27 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c          |    6 +-
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c  |    3 +-
 drivers/gpu/drm/pl111/pl111_drv.c             |    2 +-
 drivers/gpu/drm/qxl/qxl_drv.c                 |    1 +
 drivers/gpu/drm/qxl/qxl_drv.h                 |    1 -
 drivers/gpu/drm/radeon/radeon_fb.c            |    6 +-
 drivers/gpu/drm/rcar-du/rcar_du_drv.c         |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h   |    2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c    |    2 -
 drivers/gpu/drm/solomon/ssd130x.c             |    2 +-
 drivers/gpu/drm/sti/sti_drv.c                 |    2 +-
 drivers/gpu/drm/stm/drv.c                     |    2 +-
 drivers/gpu/drm/sun4i/sun4i_drv.c             |    2 +-
 drivers/gpu/drm/tegra/fb.c                    |    8 +-
 drivers/gpu/drm/tidss/tidss_drv.c             |    2 +-
 drivers/gpu/drm/tidss/tidss_kms.c             |    1 -
 drivers/gpu/drm/tilcdc/tilcdc_drv.c           |    2 +-
 drivers/gpu/drm/tiny/arcpgu.c                 |    2 +-
 drivers/gpu/drm/tiny/bochs.c                  |    2 +-
 drivers/gpu/drm/tiny/cirrus.c                 |    2 +-
 drivers/gpu/drm/tiny/gm12u320.c               |    2 +-
 drivers/gpu/drm/tiny/hx8357d.c                |    2 +-
 drivers/gpu/drm/tiny/ili9163.c                |    2 +-
 drivers/gpu/drm/tiny/ili9225.c                |    2 +-
 drivers/gpu/drm/tiny/ili9341.c                |    2 +-
 drivers/gpu/drm/tiny/ili9486.c                |    2 +-
 drivers/gpu/drm/tiny/mi0283qt.c               |    2 +-
 drivers/gpu/drm/tiny/ofdrm.c                  |    2 +-
 drivers/gpu/drm/tiny/panel-mipi-dbi.c         |    2 +-
 drivers/gpu/drm/tiny/repaper.c                |    2 +-
 drivers/gpu/drm/tiny/simpledrm.c              |    2 +-
 drivers/gpu/drm/tiny/st7586.c                 |    2 +-
 drivers/gpu/drm/tiny/st7735r.c                |    2 +-
 drivers/gpu/drm/tve200/tve200_drv.c           |    3 +-
 drivers/gpu/drm/udl/udl_drv.c                 |    2 +-
 drivers/gpu/drm/v3d/v3d_drv.c                 |    1 -
 drivers/gpu/drm/vboxvideo/vbox_drv.c          |    4 +-
 drivers/gpu/drm/vboxvideo/vbox_main.c         |    1 -
 drivers/gpu/drm/vc4/vc4_drv.c                 |    2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c          |    1 +
 drivers/gpu/drm/virtio/virtgpu_drv.h          |    1 -
 drivers/gpu/drm/vkms/vkms_drv.c               |    2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c            |    3 +
 drivers/gpu/drm/xen/xen_drm_front_gem.c       |    1 -
 drivers/gpu/drm/xlnx/zynqmp_dpsub.c           |    2 +-
 include/drm/drm_fb_helper.h                   |   59 +-
 include/drm/drm_fbdev.h                       |   15 +
 99 files changed, 1019 insertions(+), 883 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_fbdev.c
 create mode 100644 include/drm/drm_fbdev.h


base-commit: 746559738f1335241ea686566cb654847c20d7a4
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428900.679534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUy-0004Tj-Ut; Mon, 24 Oct 2022 11:20:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428900.679534; Mon, 24 Oct 2022 11:20:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUy-0004RC-Lv; Mon, 24 Oct 2022 11:20:04 +0000
Received: by outflank-mailman (input) for mailman id 428900;
 Mon, 24 Oct 2022 11:20:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUw-00036S-J7
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:02 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ccb8c029-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BBF0821E2C;
 Mon, 24 Oct 2022 11:20:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4F7B213357;
 Mon, 24 Oct 2022 11:20:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CCeqEuB0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ccb8c029-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610400; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EW5TY2zOig0VQgLGZt6zu4ywOY5c8c72AcSCo9faV+M=;
	b=sRgtI48QF7bf+VIYrcVz0Tw2w1Cf8T/YWUiNtrjtyHZUpvRuMN53cEj5mPfHgvdecNrUsM
	XQJoc72PMyO1t5Ia3kDiDm6v98mDXtwRhGNaOBH5KLVHVN9EeHFvLMqP2ay5IW6B2p/0Dh
	+o+yXXiXkBougCJ6OpNC/5SS59yRycc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610400;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EW5TY2zOig0VQgLGZt6zu4ywOY5c8c72AcSCo9faV+M=;
	b=1eeELNAaTvtHN8xWSr5qUVKL25eVbFE3UWSwQnH4k+xW0211/wycpGLvV95zp8WdPO22+D
	qw7fQN+V4hnY6/CA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed
Date: Mon, 24 Oct 2022 13:19:36 +0200
Message-Id: <20221024111953.24307-5-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as amdgpu uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.

v2:
	* fix commit description (Christian)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c       | 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 1a06b8d724f39..dd6f9ae6fbe9f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1214,7 +1214,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev,
 
 const struct drm_mode_config_funcs amdgpu_mode_funcs = {
 	.fb_create = amdgpu_display_user_framebuffer_create,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 };
 
 static const struct drm_prop_enum_list amdgpu_underscan_enum_list[] =
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 0db2a88cd4d7b..528b8be516ff6 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -82,7 +82,6 @@
 #include <drm/drm_atomic_uapi.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_blend.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_vblank.h>
@@ -2810,7 +2809,6 @@ const struct amdgpu_ip_block_version dm_ip_block =
 static const struct drm_mode_config_funcs amdgpu_dm_mode_funcs = {
 	.fb_create = amdgpu_display_user_framebuffer_create,
 	.get_format_info = amd_get_format_info,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 	.atomic_check = amdgpu_dm_atomic_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428901.679539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUz-0004bu-Lo; Mon, 24 Oct 2022 11:20:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428901.679539; Mon, 24 Oct 2022 11:20:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUz-0004Zt-8D; Mon, 24 Oct 2022 11:20:05 +0000
Received: by outflank-mailman (input) for mailman id 428901;
 Mon, 24 Oct 2022 11:20:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUw-0003Yp-N9
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:02 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd107214-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id ABA5D21E6C;
 Mon, 24 Oct 2022 11:20:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3DADB13357;
 Mon, 24 Oct 2022 11:20:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6NJFDuF0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd107214-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KzUh1CY9McKeyFVUe5+c2z/ffAcO2RMpJv1VeOGC9tQ=;
	b=mJuvcbrCHArgybf76oDkRVpZgUITZFn7CovoyPGZ8Jtv/UeMegrPQvqhlC4gqPhmZXYyQ5
	nyw2fxZM1NKfoLBbsIZoJA6WpSIpBCD/fHNYDvp53Aw0xc20byoQ6y7tqBRhoLy+x8gwzs
	+x10SJ6gN4dZ8eoX6TqRc81bLJ3uHts=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610401;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KzUh1CY9McKeyFVUe5+c2z/ffAcO2RMpJv1VeOGC9tQ=;
	b=8g9D481esPMqcRBF31NMNzhU5N29eN97tkX3rl/iBf15e+H/kdGgypTXNXjKZ9RnTtjNHR
	RKdSYVDZGZcV18Ag==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 06/21] drm/ingenic: Don't set struct drm_driver.output_poll_changed
Date: Mon, 24 Oct 2022 13:19:38 +0200
Message-Id: <20221024111953.24307-7-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as ingenic uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.

v2:
	* fix commit description (Christian, Sergey)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index ab0515d2c420a..99f86f1ba8bee 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -1018,7 +1018,6 @@ static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = {
 
 static const struct drm_mode_config_funcs ingenic_drm_mode_config_funcs = {
 	.fb_create		= ingenic_drm_gem_fb_create,
-	.output_poll_changed	= drm_fb_helper_output_poll_changed,
 	.atomic_check		= drm_atomic_helper_check,
 	.atomic_commit		= drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428902.679549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV0-0004kk-IO; Mon, 24 Oct 2022 11:20:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428902.679549; Mon, 24 Oct 2022 11:20:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvUz-0004ir-Ue; Mon, 24 Oct 2022 11:20:05 +0000
Received: by outflank-mailman (input) for mailman id 428902;
 Mon, 24 Oct 2022 11:20:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUx-00036S-JL
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:03 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ccfece6c-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:01 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3791B21DE4;
 Mon, 24 Oct 2022 11:20:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C109713A98;
 Mon, 24 Oct 2022 11:20:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8PxcLuB0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ccfece6c-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pDwG/2ZvVtedihuD7tm996Em6sMhLiO4FmD57P041QM=;
	b=mdwZe4oCDl9UJvnRtuXrem4SfiiFBuEbsVuBcem6XZzeWKEvLFgh++5J+F0kFPZh2OwF2c
	8rR6QVpJvrZjvNSwkyboHHN0mwwyZ2/JI1FZUdMFbe0+p5YrXMyI6It+57tRSs7sXcQ/Ma
	OZ806Nd+ViS++4+DGE9xm8GZLyhfO7g=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610401;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pDwG/2ZvVtedihuD7tm996Em6sMhLiO4FmD57P041QM=;
	b=hxqccXaIzzUM0Q2daluFxMAfY0DJqTJ1PLIzkvZNd4Zm8xifYKdsxU+9OAw1FxBxz2U0YP
	1XAP5XUT21C9REAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 05/21] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed
Date: Mon, 24 Oct 2022 13:19:37 +0200
Message-Id: <20221024111953.24307-6-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as DCSS uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.

v2:
	* fix commit description (Christian)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index b4f82ebca5325..1defd6a40f11d 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -21,7 +21,6 @@ DEFINE_DRM_GEM_DMA_FOPS(dcss_cma_fops);
 
 static const struct drm_mode_config_funcs dcss_drm_mode_config_funcs = {
 	.fb_create = drm_gem_fb_create,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 	.atomic_check = drm_atomic_helper_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428904.679556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV1-0004wf-A6; Mon, 24 Oct 2022 11:20:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428904.679556; Mon, 24 Oct 2022 11:20:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV0-0004tQ-NF; Mon, 24 Oct 2022 11:20:06 +0000
Received: by outflank-mailman (input) for mailman id 428904;
 Mon, 24 Oct 2022 11:20:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUy-00036S-JZ
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:04 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cda47f88-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 29EAE21EAA;
 Mon, 24 Oct 2022 11:20:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B018613A98;
 Mon, 24 Oct 2022 11:20:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0DQ1KuF0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cda47f88-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1Wm7qKYcP3zcqB8vN6ctrVYh+kdKBx4YB6Ib1oO4WIs=;
	b=xPkb3DU7zI67ZFwwt8i+2oIu3zEy8S+ECkGZtacr+DZXiIOzuTSjP8+cV+Kw0IQBdfXUo+
	MJiMncM2IgAUUvxEIi39/XnXet5/F8YKawvYQ2EQjYeXe8iODcnDUmUI4PC7DJQDPYWDnX
	J8V/1uqou8zKm0Tyycio1hC+zvbT5b8=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610402;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1Wm7qKYcP3zcqB8vN6ctrVYh+kdKBx4YB6Ib1oO4WIs=;
	b=kIm2zNLE982JNr9RaYNRmUkTVKj1xJOWVyT/wZa+SNDh/UCrjkiXo7EdEAb/Myj9aL3fKn
	1B5bUJdL74Je4xDw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 07/21] drm/logicvc: Don't set struct drm_driver.output_poll_changed
Date: Mon, 24 Oct 2022 13:19:39 +0200
Message-Id: <20221024111953.24307-8-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as logicvc uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.

v2:
	* fix commit description (Christian)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/logicvc/logicvc_mode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/logicvc/logicvc_mode.c b/drivers/gpu/drm/logicvc/logicvc_mode.c
index d8207ffda1af9..9971950ebd4ee 100644
--- a/drivers/gpu/drm/logicvc/logicvc_mode.c
+++ b/drivers/gpu/drm/logicvc/logicvc_mode.c
@@ -10,7 +10,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mode_config.h>
@@ -26,7 +25,6 @@
 
 static const struct drm_mode_config_funcs logicvc_mode_config_funcs = {
 	.fb_create		= drm_gem_fb_create,
-	.output_poll_changed	= drm_fb_helper_output_poll_changed,
 	.atomic_check		= drm_atomic_helper_check,
 	.atomic_commit		= drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428903.679565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV2-0005C0-G5; Mon, 24 Oct 2022 11:20:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428903.679565; Mon, 24 Oct 2022 11:20:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV1-000581-N4; Mon, 24 Oct 2022 11:20:07 +0000
Received: by outflank-mailman (input) for mailman id 428903;
 Mon, 24 Oct 2022 11:20:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUy-0003Yp-Fy
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce289cad-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 9FA5D1FD8D;
 Mon, 24 Oct 2022 11:20:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1F03F13357;
 Mon, 24 Oct 2022 11:20:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oF3JBuN0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce289cad-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mu2A6Ru6vvqSAa8anfcgwfFu/Q/j4bw+8GKC1w2HMmA=;
	b=1Ddfi5oF53IDn/dEor6K/T+V/aCfrL/W6sW/tT545sWp30MAprfNOr9MyridKrSqfDtAZI
	ebbFI2M4pL1Z1uiVsH42V8grf97raXsRpVCfa5MeJaU1caiW23JgP+zW63fKCJV9agaiU5
	xY0Ai+IoQvbFvTjNyZfPs19wDgn/fJM=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610403;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mu2A6Ru6vvqSAa8anfcgwfFu/Q/j4bw+8GKC1w2HMmA=;
	b=JTRituGpMHUmE6YbaHBmk24BldH2XWaEQXgBvVXUh7zUGL5jFPvQ4ywPocisVX5tACqbjK
	as4LMfFKnyo2z+CA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 10/21] drm/tve200: Include <linux/of.h>
Date: Mon, 24 Oct 2022 13:19:42 +0200
Message-Id: <20221024111953.24307-11-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Include <linux/of.h> for of_match_ptr().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tve200/tve200_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c
index 04db72e3fa9c2..611785e097576 100644
--- a/drivers/gpu/drm/tve200/tve200_drv.c
+++ b/drivers/gpu/drm/tve200/tve200_drv.c
@@ -32,6 +32,7 @@
 #include <linux/irq.h>
 #include <linux/io.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/shmem_fs.h>
 #include <linux/slab.h>
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428905.679576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV3-0005N3-DM; Mon, 24 Oct 2022 11:20:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428905.679576; Mon, 24 Oct 2022 11:20:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV2-0005KN-M1; Mon, 24 Oct 2022 11:20:08 +0000
Received: by outflank-mailman (input) for mailman id 428905;
 Mon, 24 Oct 2022 11:20:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUz-0003Yp-0d
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:05 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce7a9d98-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 2A99A21E9E;
 Mon, 24 Oct 2022 11:20:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A51C113357;
 Mon, 24 Oct 2022 11:20:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MClwJ+N0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce7a9d98-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YkMHENyFsh6/3SjkSTuYRYMbHc7R5XzWBBCbrwJgYhc=;
	b=UL0Xm/SZ/boCID7H9JNHrmtRrt3jufekwWgojpJwcDZDOUJLVFxOogJl2v0+1qP4CEAeGU
	fRM0GF4CApRdd83X31cW2Rzd2aSdlQtJf4S4YZtJ5sXZLrj58aqT6Gv8ztwFTV2hZcAoSy
	t9VQtHXjrBPan1liZ0sZc/2fCWmDYDA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610404;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YkMHENyFsh6/3SjkSTuYRYMbHc7R5XzWBBCbrwJgYhc=;
	b=vDfrFs9N/fTxnSB8q3qlPxjXKDXlJR8QXIEAG/fSF+rYVJqcaIrdG6KxsnY74D6kAk8scf
	1FIUDLCuQMoaGJDg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 11/21] drm/fb-helper: Cleanup include statements in header file
Date: Mon, 24 Oct 2022 13:19:43 +0200
Message-Id: <20221024111953.24307-12-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Only include what we have to.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 include/drm/drm_fb_helper.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index fddd0d1af6891..e923089522896 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -32,11 +32,9 @@
 
 struct drm_fb_helper;
 
-#include <drm/drm_client.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_device.h>
 #include <linux/fb.h>
-#include <linux/kgdb.h>
+
+#include <drm/drm_client.h>
 
 enum mode_set_atomic {
 	LEAVE_ATOMIC_MODE_SET,
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428906.679583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV4-0005i3-Gu; Mon, 24 Oct 2022 11:20:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428906.679583; Mon, 24 Oct 2022 11:20:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV3-0005ar-Qa; Mon, 24 Oct 2022 11:20:09 +0000
Received: by outflank-mailman (input) for mailman id 428906;
 Mon, 24 Oct 2022 11:20:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvUz-00036S-Jq
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cdd1ddfc-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:02 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 98A751FD8B;
 Mon, 24 Oct 2022 11:20:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2E66813357;
 Mon, 24 Oct 2022 11:20:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oF+HCuJ0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdd1ddfc-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1klq8dgTEHSChmOJust/LVatEDotA0sGZfglkNp+Pao=;
	b=en9jvOW04jfUiC60HFppj7Oi/hyRFNL9iZm4h2C3wjx7GrcB8fmkGzHIIZPN++3MacVihM
	IGlFIQ4o9dY1kpVocT2xeGqRCXI8TNg/S2hDF8a8A5QKlpz5M7wkwEvKQP+VlYHh+ofsVS
	bql6rcit/v8GmmRhIhgdnUpdjivHfH4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610402;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1klq8dgTEHSChmOJust/LVatEDotA0sGZfglkNp+Pao=;
	b=725Cm9O66lYpCGvlCvlIik0hnSVzTD9as22FkjDe/R15LqYy9dj9Io/GaSo1zUXwzKiFUK
	4r4cklW8DGrv9VCw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 08/21] drm/rockchip: Don't set struct drm_driver.output_poll_changed
Date: Mon, 24 Oct 2022 13:19:40 +0200
Message-Id: <20221024111953.24307-9-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Don't set struct drm_driver.output_poll_changed. It's used to restore
the fbdev console. But as rockchip uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See the
functions drm_kms_helper_hotplug_event() and
drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.

v2:
	* fix commit description (Christian)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 092bf863110b7..7de64b0ad047f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
@@ -9,7 +9,6 @@
 #include <drm/drm.h>
 #include <drm/drm_atomic.h>
 #include <drm/drm_damage_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
@@ -101,7 +100,6 @@ rockchip_fb_create(struct drm_device *dev, struct drm_file *file,
 
 static const struct drm_mode_config_funcs rockchip_drm_mode_config_funcs = {
 	.fb_create = rockchip_fb_create,
-	.output_poll_changed = drm_fb_helper_output_poll_changed,
 	.atomic_check = drm_atomic_helper_check,
 	.atomic_commit = drm_atomic_helper_commit,
 };
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428907.679594 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV5-00061e-PP; Mon, 24 Oct 2022 11:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428907.679594; Mon, 24 Oct 2022 11:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV5-0005vM-0i; Mon, 24 Oct 2022 11:20:11 +0000
Received: by outflank-mailman (input) for mailman id 428907;
 Mon, 24 Oct 2022 11:20:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV0-0003Yp-DQ
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:06 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf1d7b36-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3C2C71FD8E;
 Mon, 24 Oct 2022 11:20:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B512613357;
 Mon, 24 Oct 2022 11:20:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SPteK+R0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf1d7b36-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OWGxAFccZF9j9qpUVGpVYG5/1nEWr1vS56GJ1OWtS3A=;
	b=QtevyFsUxvza1u9FmSTUfV39yKw5WCPVOb23eAv8FTesXCNTk3Yc+fEKQnB3ejI7FemGJf
	TH9fKaU2QfL4jTxBLwEuTHBY1GehR1wE9ExkDuUvDxNKNAgi09L9lthU2HIUt5dEmMJYgU
	Gf+VC18FOJanvCTepvhTTvygrQ6YcCk=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610405;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OWGxAFccZF9j9qpUVGpVYG5/1nEWr1vS56GJ1OWtS3A=;
	b=ebBTYQc5JdSGAqbjKd18f+GOkkQXptBn/zkI44LJUKBmFtbTzospDgP5iYSjh7RvBf07II
	R4huU2UL9xG4oBBw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix
Date: Mon, 24 Oct 2022 13:19:45 +0200
Message-Id: <20221024111953.24307-14-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as
part of unifying the naming within fbdev helpers. Adapt drivers. No
functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      | 2 +-
 drivers/gpu/drm/drm_fb_helper.c            | 8 ++++----
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  | 2 +-
 drivers/gpu/drm/gma500/framebuffer.c       | 2 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
 drivers/gpu/drm/msm/msm_fbdev.c            | 2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c    | 2 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c       | 2 +-
 drivers/gpu/drm/radeon/radeon_fb.c         | 2 +-
 drivers/gpu/drm/tegra/fb.c                 | 2 +-
 include/drm/drm_fb_helper.h                | 4 ++--
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index 38f5170c0fea6..eaae98d9377ae 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -72,7 +72,7 @@ static int armada_fbdev_create(struct drm_fb_helper *fbh,
 	if (IS_ERR(dfb))
 		return PTR_ERR(dfb);
 
-	info = drm_fb_helper_alloc_fbi(fbh);
+	info = drm_fb_helper_alloc_info(fbh);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto err_fballoc;
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 480bf4f568b7b..881e6a04fa706 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -558,7 +558,7 @@ int drm_fb_helper_init(struct drm_device *dev,
 EXPORT_SYMBOL(drm_fb_helper_init);
 
 /**
- * drm_fb_helper_alloc_fbi - allocate fb_info and some of its members
+ * drm_fb_helper_alloc_info - allocate fb_info and some of its members
  * @fb_helper: driver-allocated fbdev helper
  *
  * A helper to alloc fb_info and the members cmap and apertures. Called
@@ -570,7 +570,7 @@ EXPORT_SYMBOL(drm_fb_helper_init);
  * fb_info pointer if things went okay, pointer containing error code
  * otherwise
  */
-struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
+struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 {
 	struct device *dev = fb_helper->dev->dev;
 	struct fb_info *info;
@@ -609,7 +609,7 @@ struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
 	framebuffer_release(info);
 	return ERR_PTR(ret);
 }
-EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
+EXPORT_SYMBOL(drm_fb_helper_alloc_info);
 
 /**
  * drm_fb_helper_unregister_fbi - unregister fb_info framebuffer device
@@ -2440,7 +2440,7 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,
 	fb_helper->fb = buffer->fb;
 	fb = buffer->fb;
 
-	fbi = drm_fb_helper_alloc_fbi(fb_helper);
+	fbi = drm_fb_helper_alloc_info(fb_helper);
 	if (IS_ERR(fbi))
 		return PTR_ERR(fbi);
 
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 767afd2bfa822..8741eb0b1b604 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -63,7 +63,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
 	unsigned int size = fb->width * fb->height * fb->format->cpp[0];
 	unsigned long offset;
 
-	fbi = drm_fb_helper_alloc_fbi(helper);
+	fbi = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(fbi)) {
 		DRM_DEV_ERROR(to_dma_dev(helper->dev),
 			      "failed to allocate fb info.\n");
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index 5f502a0048ab8..6d0e3bf6435ee 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -268,7 +268,7 @@ static int psbfb_create(struct drm_fb_helper *fb_helper,
 
 	memset(dev_priv->vram_addr + backing->offset, 0, size);
 
-	info = drm_fb_helper_alloc_fbi(fb_helper);
+	info = drm_fb_helper_alloc_info(fb_helper);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto err_drm_gem_object_put;
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index d533ecd451025..05b841343ea3e 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -254,7 +254,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
 		goto out_unlock;
 	}
 
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		drm_err(&dev_priv->drm, "Failed to allocate fb_info (%pe)\n", info);
 		ret = PTR_ERR(info);
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index b373e30003203..4d9a0fcbf95b6 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -93,7 +93,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
 		goto fail;
 	}
 
-	fbi = drm_fb_helper_alloc_fbi(helper);
+	fbi = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(fbi)) {
 		DRM_DEV_ERROR(dev->dev, "failed to allocate fb info\n");
 		ret = PTR_ERR(fbi);
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index ac4bd529ae2e8..fca40124fc17c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -362,7 +362,7 @@ nouveau_fbcon_create(struct drm_fb_helper *helper,
 		}
 	}
 
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto out_unlock;
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index 92d505be53e06..ab30c64e97043 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -161,7 +161,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper,
 		goto fail;
 	}
 
-	fbi = drm_fb_helper_alloc_fbi(helper);
+	fbi = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(fbi)) {
 		dev_err(dev->dev, "failed to allocate fb info\n");
 		ret = PTR_ERR(fbi);
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index cc6754d88b819..0c6a227929db2 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -243,7 +243,7 @@ static int radeonfb_create(struct drm_fb_helper *helper,
 	rbo = gem_to_radeon_bo(gobj);
 
 	/* okay we have an object now allocate the framebuffer */
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		ret = PTR_ERR(info);
 		goto out;
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 6fe24535d0e43..a09c071f35120 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -243,7 +243,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 	if (IS_ERR(bo))
 		return PTR_ERR(bo);
 
-	info = drm_fb_helper_alloc_fbi(helper);
+	info = drm_fb_helper_alloc_info(helper);
 	if (IS_ERR(info)) {
 		dev_err(drm->dev, "failed to allocate framebuffer info\n");
 		drm_gem_object_put(&bo->gem);
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index d83e2d8e92eb9..5ec9d9c68d144 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -222,7 +222,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
 
 int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper);
 
-struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper);
+struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper);
 void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper);
 void drm_fb_helper_fill_info(struct fb_info *info,
 			     struct drm_fb_helper *fb_helper,
@@ -320,7 +320,7 @@ drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper)
 }
 
 static inline struct fb_info *
-drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
+drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 {
 	return NULL;
 }
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428909.679602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV6-0006FE-OD; Mon, 24 Oct 2022 11:20:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428909.679602; Mon, 24 Oct 2022 11:20:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV5-0006AT-V6; Mon, 24 Oct 2022 11:20:11 +0000
Received: by outflank-mailman (input) for mailman id 428909;
 Mon, 24 Oct 2022 11:20:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV0-0003Yp-VK
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:06 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cf619ef9-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:05 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AA99621ED3;
 Mon, 24 Oct 2022 11:20:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F39713A98;
 Mon, 24 Oct 2022 11:20:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gPywDuV0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf619ef9-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YwkthCOqxBk+iVdUD4bH5srZQ6x4sgqGwNjzqX0879Y=;
	b=rjLeJU2q+FTREmrIPEihrZ7w6TCEWwUym7ECOBAkAtMgABFkSf7PlrcJ64HG97GUQvNO9R
	Jtwgwt5BRzlpnJyxyqTaEeExWLyb9ut883FtCyjCIVRER3zq9NROcdZ0ox+OH0FV3+33TR
	nz8ATsDcChXn22Sz8ke13HAPVpBxlzc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610405;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YwkthCOqxBk+iVdUD4bH5srZQ6x4sgqGwNjzqX0879Y=;
	b=5TPS52dddWtDpuwwIevT2LoyfRFjnuMqzPFIH6NQg/ufeW+p36jTW5otBCmhjlzYA7Ub/+
	6hfgGN7b3yemjLAg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix
Date: Mon, 24 Oct 2022 13:19:46 +0200
Message-Id: <20221024111953.24307-15-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info()
as part of unifying the naming within fbdev helpers. Adapt drivers. No
functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      | 2 +-
 drivers/gpu/drm/drm_fb_helper.c            | 8 ++++----
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  | 2 +-
 drivers/gpu/drm/gma500/framebuffer.c       | 2 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +-
 drivers/gpu/drm/msm/msm_fbdev.c            | 2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c    | 2 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c       | 2 +-
 drivers/gpu/drm/radeon/radeon_fb.c         | 2 +-
 drivers/gpu/drm/tegra/fb.c                 | 2 +-
 include/drm/drm_fb_helper.h                | 4 ++--
 11 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index eaae98d9377ae..f02f6a5ba8320 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -155,7 +155,7 @@ void armada_fbdev_fini(struct drm_device *dev)
 	struct drm_fb_helper *fbh = priv->fbdev;
 
 	if (fbh) {
-		drm_fb_helper_unregister_fbi(fbh);
+		drm_fb_helper_unregister_info(fbh);
 
 		drm_fb_helper_fini(fbh);
 
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 881e6a04fa706..bfbb2af144060 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -612,19 +612,19 @@ struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 EXPORT_SYMBOL(drm_fb_helper_alloc_info);
 
 /**
- * drm_fb_helper_unregister_fbi - unregister fb_info framebuffer device
+ * drm_fb_helper_unregister_info - unregister fb_info framebuffer device
  * @fb_helper: driver-allocated fbdev helper, can be NULL
  *
  * A wrapper around unregister_framebuffer, to release the fb_info
  * framebuffer device. This must be called before releasing all resources for
  * @fb_helper by calling drm_fb_helper_fini().
  */
-void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
+void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper)
 {
 	if (fb_helper && fb_helper->info)
 		unregister_framebuffer(fb_helper->info);
 }
-EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
+EXPORT_SYMBOL(drm_fb_helper_unregister_info);
 
 /**
  * drm_fb_helper_fini - finialize a &struct drm_fb_helper
@@ -2497,7 +2497,7 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
 
 	if (fb_helper->info)
 		/* drm_fbdev_fb_destroy() takes care of cleanup */
-		drm_fb_helper_unregister_fbi(fb_helper);
+		drm_fb_helper_unregister_info(fb_helper);
 	else
 		drm_fbdev_release(fb_helper);
 }
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 8741eb0b1b604..86c489d945849 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -201,7 +201,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
 			drm_framebuffer_remove(fb);
 	}
 
-	drm_fb_helper_unregister_fbi(fb_helper);
+	drm_fb_helper_unregister_info(fb_helper);
 
 	drm_fb_helper_fini(fb_helper);
 }
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index 6d0e3bf6435ee..6098d936e44b6 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -383,7 +383,7 @@ static int psb_fbdev_destroy(struct drm_device *dev,
 {
 	struct drm_framebuffer *fb = fb_helper->fb;
 
-	drm_fb_helper_unregister_fbi(fb_helper);
+	drm_fb_helper_unregister_info(fb_helper);
 
 	drm_fb_helper_fini(fb_helper);
 	drm_framebuffer_unregister_private(fb);
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 05b841343ea3e..1b576c859837b 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -584,7 +584,7 @@ void intel_fbdev_unregister(struct drm_i915_private *dev_priv)
 	if (!current_is_async())
 		intel_fbdev_sync(ifbdev);
 
-	drm_fb_helper_unregister_fbi(&ifbdev->helper);
+	drm_fb_helper_unregister_info(&ifbdev->helper);
 }
 
 void intel_fbdev_fini(struct drm_i915_private *dev_priv)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 4d9a0fcbf95b6..31e1e30cb52a2 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -182,7 +182,7 @@ void msm_fbdev_free(struct drm_device *dev)
 
 	DBG();
 
-	drm_fb_helper_unregister_fbi(helper);
+	drm_fb_helper_unregister_info(helper);
 
 	drm_fb_helper_fini(helper);
 
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index fca40124fc17c..e87de7906f780 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -419,7 +419,7 @@ nouveau_fbcon_destroy(struct drm_device *dev, struct nouveau_fbdev *fbcon)
 	struct drm_framebuffer *fb = fbcon->helper.fb;
 	struct nouveau_bo *nvbo;
 
-	drm_fb_helper_unregister_fbi(&fbcon->helper);
+	drm_fb_helper_unregister_info(&fbcon->helper);
 	drm_fb_helper_fini(&fbcon->helper);
 
 	if (fb && fb->obj[0]) {
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index ab30c64e97043..98d8758048fc1 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -272,7 +272,7 @@ void omap_fbdev_fini(struct drm_device *dev)
 	if (!helper)
 		return;
 
-	drm_fb_helper_unregister_fbi(helper);
+	drm_fb_helper_unregister_info(helper);
 
 	drm_fb_helper_fini(helper);
 
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 0c6a227929db2..f06fed2030a89 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -309,7 +309,7 @@ static int radeon_fbdev_destroy(struct drm_device *dev, struct radeon_fbdev *rfb
 {
 	struct drm_framebuffer *fb = &rfbdev->fb;
 
-	drm_fb_helper_unregister_fbi(&rfbdev->helper);
+	drm_fb_helper_unregister_info(&rfbdev->helper);
 
 	if (fb->obj[0]) {
 		radeonfb_destroy_pinned_object(fb->obj[0]);
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index a09c071f35120..84b7f1dd9fb57 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -347,7 +347,7 @@ static int tegra_fbdev_init(struct tegra_fbdev *fbdev,
 
 static void tegra_fbdev_exit(struct tegra_fbdev *fbdev)
 {
-	drm_fb_helper_unregister_fbi(&fbdev->base);
+	drm_fb_helper_unregister_info(&fbdev->base);
 
 	if (fbdev->fb) {
 		struct tegra_bo *bo = tegra_fb_get_plane(fbdev->fb, 0);
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 5ec9d9c68d144..edc697a2fde24 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -223,7 +223,7 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
 int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper);
 
 struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper);
-void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper);
+void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper);
 void drm_fb_helper_fill_info(struct fb_info *info,
 			     struct drm_fb_helper *fb_helper,
 			     struct drm_fb_helper_surface_size *sizes);
@@ -325,7 +325,7 @@ drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
 	return NULL;
 }
 
-static inline void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
+static inline void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper)
 {
 }
 
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428908.679614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV8-0006Wd-1d; Mon, 24 Oct 2022 11:20:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428908.679614; Mon, 24 Oct 2022 11:20:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV7-0006RJ-2R; Mon, 24 Oct 2022 11:20:13 +0000
Received: by outflank-mailman (input) for mailman id 428908;
 Mon, 24 Oct 2022 11:20:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV0-00036S-K9
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:06 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce1d6738-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:03 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1AA231FD8C;
 Mon, 24 Oct 2022 11:20:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A06FC13B34;
 Mon, 24 Oct 2022 11:20:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YGlqJuJ0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce1d6738-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TEgpl55AepC361EexBBEYuHLTFWdn6vIDOCsAIRAdbs=;
	b=tTPj3Ajm/W7k4xAj/NjREnCuteNThvM5rK5/j9FGA2C7plkeoxu705D1SVfIq19i/Q8vDD
	Hh3loR0GZWj+xZBF42TiFg+xablbQ5RsXgTm9VOzMNBL+zTUcHbC3i3JX1ZTLBaXTF7pMH
	twjAUrF4GYnBD1Cb57pe2fKkGImYEhI=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610403;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TEgpl55AepC361EexBBEYuHLTFWdn6vIDOCsAIRAdbs=;
	b=XkLdHuGn9oWWLTzK+dldjiKNlN1DDYMycvmmFEG53dbzQ/rRcXmxp45qbnZbGAegvjt7UQ
	gXwxSlh/nr53HABQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 09/21] drm/panel-ili9341: Include <linux/backlight.h>
Date: Mon, 24 Oct 2022 13:19:41 +0200
Message-Id: <20221024111953.24307-10-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Include <linux/backlight.h> for devm_of_find_backlight().

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 39dc40cf681f0..b59472c29a40d 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -18,6 +18,7 @@
  * Copyright 2018 David Lechner <david@lechnology.com>
  */
 
+#include <linux/backlight.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428910.679628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvVB-000790-14; Mon, 24 Oct 2022 11:20:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428910.679628; Mon, 24 Oct 2022 11:20:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvV9-000720-RI; Mon, 24 Oct 2022 11:20:15 +0000
Received: by outflank-mailman (input) for mailman id 428910;
 Mon, 24 Oct 2022 11:20:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV1-0003Yp-Ni
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:07 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d00a2c37-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B4276220DA;
 Mon, 24 Oct 2022 11:20:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 359A713A98;
 Mon, 24 Oct 2022 11:20:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UFgyDOZ0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d00a2c37-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W2hXo1ZXw+fT7jNTQpjjai6MaQuUlFJ3x4yHM5t/NT8=;
	b=NmK2JPY7erjfISSjJHyuZn3S9M4HE0QY2DX64ewIKQkqdV4YW55dIfYZUFwsucHgK8EJWo
	9OqpMMbfSr3Sj4qTG661IHslL7dTlOf47A0qYZ/yUtPD5rYrjiqIr2/K1pI8y8YSUIBX7A
	u/2NuQed3cKWK0fTF/Zshk2lHorpMOI=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610406;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=W2hXo1ZXw+fT7jNTQpjjai6MaQuUlFJ3x4yHM5t/NT8=;
	b=2HdzFY+hAc4IQyzPhbPzdnFAvNOMcpZCifG7L10kN4snoDQgnsRKjQRlxM4yHitxgDoIAD
	6G6AQD9Zct0kBEBA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 16/21] drm/fb-helper: Call fb_sync in I/O functions
Date: Mon, 24 Oct 2022 13:19:48 +0200
Message-Id: <20221024111953.24307-17-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the
behavior of fbdev. Fbdev implementations of fb_read and fb_write in
struct fb_ops invoke fb_sync to synchronize with outstanding operations
before I/O. Doing the same in DRM implementations will allow us to use
them throughout DRM drivers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index f6d22cc4cd876..379e0d2f67198 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -2246,6 +2246,9 @@ static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
 	if (total_size - count < pos)
 		count = total_size - pos;
 
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
 	if (drm_fbdev_use_iomem(info))
 		ret = fb_read_screen_base(info, buf, count, pos);
 	else
@@ -2327,6 +2330,9 @@ static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
 		count = total_size - pos;
 	}
 
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
 	/*
 	 * Copy to framebuffer even if we already logged an error. Emulates
 	 * the behavior of the original fbdev implementation.
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428911.679640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvVD-0007fS-H3; Mon, 24 Oct 2022 11:20:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428911.679640; Mon, 24 Oct 2022 11:20:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvVC-0007Zo-6F; Mon, 24 Oct 2022 11:20:18 +0000
Received: by outflank-mailman (input) for mailman id 428911;
 Mon, 24 Oct 2022 11:20:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV3-0003Yp-5N
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:09 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d0c0cdee-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id F1B821FD8F;
 Mon, 24 Oct 2022 11:20:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 50C2013A98;
 Mon, 24 Oct 2022 11:20:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SNLmEud0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0c0cdee-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mIcpJgbeqPNRftPv7Q4iDJZ6HW36+TLeNbJLj/Rhtmc=;
	b=J5V9t/9FM/VDgPyc0yq6tO0GmQq6Qv25guz1Q1fY5WqdBAinoQHFhztpNq5LcTRRfUvvcT
	/NuVcNEdfBJX7fusjs7hFRkyxgbHxcWN1kfohXIkpRJAi1ty3GFGrpl4rAh+odteORdTGx
	FKkgD3un0IG2lJnoPAZi1HhvrYE46Xs=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610408;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mIcpJgbeqPNRftPv7Q4iDJZ6HW36+TLeNbJLj/Rhtmc=;
	b=CNYWcX45+/WAYm9dPFnFWlK6swVE3qJRR6m+/F0MjgXTEr5bOtQ33tW8HoXd70hS0Hn34P
	VykmHgLg4gOIWDBg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead
Date: Mon, 24 Oct 2022 13:19:50 +0200
Message-Id: <20221024111953.24307-19-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Pull the test for fb_dirty into the caller to avoid extra work
if no callback has been set. In this case no damage handling is
required and no damage area needs to be computed. Print a warning
if the damage worker runs without getting an fb_dirty callback.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++-----------
 1 file changed, 60 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 836523aef6a27..fbc5c5445fdb0 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper,
 static void drm_fb_helper_damage_work(struct work_struct *work)
 {
 	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
+	struct drm_device *dev = helper->dev;
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	struct drm_clip_rect clip_copy;
 	unsigned long flags;
 	int ret;
 
-	if (!helper->funcs->fb_dirty)
+	if (drm_WARN_ON_ONCE(dev, !helper->funcs->fb_dirty))
 		return;
 
 	spin_lock_irqsave(&helper->damage_lock, flags);
@@ -659,16 +660,12 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
 }
 EXPORT_SYMBOL(drm_fb_helper_fini);
 
-static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y,
+static void drm_fb_helper_damage(struct drm_fb_helper *helper, u32 x, u32 y,
 				 u32 width, u32 height)
 {
-	struct drm_fb_helper *helper = info->par;
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	unsigned long flags;
 
-	if (!helper->funcs->fb_dirty)
-		return;
-
 	spin_lock_irqsave(&helper->damage_lock, flags);
 	clip->x1 = min_t(u32, clip->x1, x);
 	clip->y1 = min_t(u32, clip->y1, y);
@@ -718,6 +715,7 @@ static void drm_fb_helper_memory_range_to_clip(struct fb_info *info, off_t off,
  */
 void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagereflist)
 {
+	struct drm_fb_helper *helper = info->par;
 	unsigned long start, end, min_off, max_off;
 	struct fb_deferred_io_pageref *pageref;
 	struct drm_rect damage_area;
@@ -733,17 +731,19 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli
 	if (min_off >= max_off)
 		return;
 
-	/*
-	 * As we can only track pages, we might reach beyond the end
-	 * of the screen and account for non-existing scanlines. Hence,
-	 * keep the covered memory area within the screen buffer.
-	 */
-	max_off = min(max_off, info->screen_size);
+	if (helper->funcs->fb_dirty) {
+		/*
+		 * As we can only track pages, we might reach beyond the end
+		 * of the screen and account for non-existing scanlines. Hence,
+		 * keep the covered memory area within the screen buffer.
+		 */
+		max_off = min(max_off, info->screen_size);
 
-	drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+		drm_fb_helper_memory_range_to_clip(info, min_off, max_off - min_off, &damage_area);
+		drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
+				     drm_rect_width(&damage_area),
+				     drm_rect_height(&damage_area));
+	}
 }
 EXPORT_SYMBOL(drm_fb_helper_deferred_io);
 
@@ -877,6 +877,7 @@ static ssize_t drm_fb_helper_write_screen_buffer(struct fb_info *info, const cha
 ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 				size_t count, loff_t *ppos)
 {
+	struct drm_fb_helper *helper = info->par;
 	loff_t pos = *ppos;
 	ssize_t ret;
 	struct drm_rect damage_area;
@@ -885,10 +886,12 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 	if (ret <= 0)
 		return ret;
 
-	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+	if (helper->funcs->fb_dirty) {
+		drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
+		drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
+				     drm_rect_width(&damage_area),
+				     drm_rect_height(&damage_area));
+	}
 
 	return ret;
 }
@@ -904,8 +907,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_write);
 void drm_fb_helper_sys_fillrect(struct fb_info *info,
 				const struct fb_fillrect *rect)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	sys_fillrect(info, rect);
-	drm_fb_helper_damage(info, rect->dx, rect->dy, rect->width, rect->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, rect->dx, rect->dy, rect->width, rect->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_fillrect);
 
@@ -919,8 +926,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_fillrect);
 void drm_fb_helper_sys_copyarea(struct fb_info *info,
 				const struct fb_copyarea *area)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	sys_copyarea(info, area);
-	drm_fb_helper_damage(info, area->dx, area->dy, area->width, area->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, area->dx, area->dy, area->width, area->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_copyarea);
 
@@ -934,8 +945,12 @@ EXPORT_SYMBOL(drm_fb_helper_sys_copyarea);
 void drm_fb_helper_sys_imageblit(struct fb_info *info,
 				 const struct fb_image *image)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	sys_imageblit(info, image);
-	drm_fb_helper_damage(info, image->dx, image->dy, image->width, image->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, image->dx, image->dy, image->width, image->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_imageblit);
 
@@ -1035,6 +1050,7 @@ static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf
 ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
 				size_t count, loff_t *ppos)
 {
+	struct drm_fb_helper *helper = info->par;
 	loff_t pos = *ppos;
 	ssize_t ret;
 	struct drm_rect damage_area;
@@ -1043,10 +1059,12 @@ ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
 	if (ret <= 0)
 		return ret;
 
-	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+	if (helper->funcs->fb_dirty) {
+		drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
+		drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
+				     drm_rect_width(&damage_area),
+				     drm_rect_height(&damage_area));
+	}
 
 	return ret;
 }
@@ -1062,8 +1080,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_write);
 void drm_fb_helper_cfb_fillrect(struct fb_info *info,
 				const struct fb_fillrect *rect)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	cfb_fillrect(info, rect);
-	drm_fb_helper_damage(info, rect->dx, rect->dy, rect->width, rect->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, rect->dx, rect->dy, rect->width, rect->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect);
 
@@ -1077,8 +1099,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_fillrect);
 void drm_fb_helper_cfb_copyarea(struct fb_info *info,
 				const struct fb_copyarea *area)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	cfb_copyarea(info, area);
-	drm_fb_helper_damage(info, area->dx, area->dy, area->width, area->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, area->dx, area->dy, area->width, area->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea);
 
@@ -1092,8 +1118,12 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_copyarea);
 void drm_fb_helper_cfb_imageblit(struct fb_info *info,
 				 const struct fb_image *image)
 {
+	struct drm_fb_helper *helper = info->par;
+
 	cfb_imageblit(info, image);
-	drm_fb_helper_damage(info, image->dx, image->dy, image->width, image->height);
+
+	if (helper->funcs->fb_dirty)
+		drm_fb_helper_damage(helper, image->dx, image->dy, image->width, image->height);
 }
 EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit);
 
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:20:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:20:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428912.679653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvVF-0008DK-RA; Mon, 24 Oct 2022 11:20:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428912.679653; Mon, 24 Oct 2022 11:20:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvVE-00085Q-7F; Mon, 24 Oct 2022 11:20:20 +0000
Received: by outflank-mailman (input) for mailman id 428912;
 Mon, 24 Oct 2022 11:20:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV6-0003Yp-J9
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:13 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d1accbf8-538d-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:20:09 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7FC252216A;
 Mon, 24 Oct 2022 11:20:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B199013A98;
 Mon, 24 Oct 2022 11:20:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IEYpKuh0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d1accbf8-538d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610409; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nSk2FXDEc25zzGR//kIX1RE1tNJvczIT2jFo/lnzWZs=;
	b=aswqT2C05mfTMEagSCDXCiNX74B6hYWJDoGI42x4CMXgdAvMAdgvPVXg3JPOV7lTs4GyoS
	jnf2EhP6BHLFTpspx7P7G2Hl/+gRkoqx8w2N6fbnVFQFMWNXX3siYcMowWsTegQ13AO7UB
	4ePGHgaYgvr4suFt3eW/1Nqk7q9yuBQ=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610409;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nSk2FXDEc25zzGR//kIX1RE1tNJvczIT2jFo/lnzWZs=;
	b=Ie9Ce208Cm9C7CSCcyJskr8Qut7zW4mcyAmaYrdwoGN9uQNVGR1w9BOCCN2tszF2tXyr10
	0KUOJBRn3ISuC+Dg==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file
Date: Mon, 24 Oct 2022 13:19:52 +0200
Message-Id: <20221024111953.24307-21-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Move the generic fbdev implementation into its own source and header
file. Adapt drivers. No functonal changes, but some of the internal
helpers have been renamed to fit into the drm_fbdev_ naming scheme.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/Makefile                      |   2 +-
 .../gpu/drm/arm/display/komeda/komeda_drv.c   |   2 +-
 drivers/gpu/drm/arm/hdlcd_drv.c               |   2 +-
 drivers/gpu/drm/arm/malidp_drv.c              |   2 +-
 drivers/gpu/drm/aspeed/aspeed_gfx_drv.c       |   2 +-
 drivers/gpu/drm/ast/ast_drv.c                 |   1 +
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |   2 +-
 drivers/gpu/drm/drm_fb_helper.c               | 517 +-----------------
 drivers/gpu/drm/drm_fbdev.c                   | 512 +++++++++++++++++
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c     |   2 +-
 drivers/gpu/drm/gud/gud_drv.c                 |   2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |   1 +
 .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c   |   2 +-
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c       |   2 +-
 drivers/gpu/drm/imx/dcss/dcss-kms.c           |   2 +-
 drivers/gpu/drm/imx/imx-drm-core.c            |   2 +-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c     |   2 +-
 drivers/gpu/drm/kmb/kmb_drv.c                 |   2 +-
 drivers/gpu/drm/logicvc/logicvc_drm.c         |   2 +-
 drivers/gpu/drm/mcde/mcde_drv.c               |   2 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |   2 +-
 drivers/gpu/drm/meson/meson_drv.c             |   2 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |   1 +
 drivers/gpu/drm/mxsfb/lcdif_drv.c             |   2 +-
 drivers/gpu/drm/mxsfb/mxsfb_drv.c             |   2 +-
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c  |   2 +-
 drivers/gpu/drm/pl111/pl111_drv.c             |   2 +-
 drivers/gpu/drm/qxl/qxl_drv.c                 |   1 +
 drivers/gpu/drm/rcar-du/rcar_du_drv.c         |   2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |   2 +-
 drivers/gpu/drm/solomon/ssd130x.c             |   2 +-
 drivers/gpu/drm/sti/sti_drv.c                 |   2 +-
 drivers/gpu/drm/stm/drv.c                     |   2 +-
 drivers/gpu/drm/sun4i/sun4i_drv.c             |   2 +-
 drivers/gpu/drm/tidss/tidss_drv.c             |   2 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c           |   2 +-
 drivers/gpu/drm/tiny/arcpgu.c                 |   2 +-
 drivers/gpu/drm/tiny/bochs.c                  |   2 +-
 drivers/gpu/drm/tiny/cirrus.c                 |   2 +-
 drivers/gpu/drm/tiny/gm12u320.c               |   2 +-
 drivers/gpu/drm/tiny/hx8357d.c                |   2 +-
 drivers/gpu/drm/tiny/ili9163.c                |   2 +-
 drivers/gpu/drm/tiny/ili9225.c                |   2 +-
 drivers/gpu/drm/tiny/ili9341.c                |   2 +-
 drivers/gpu/drm/tiny/ili9486.c                |   2 +-
 drivers/gpu/drm/tiny/mi0283qt.c               |   2 +-
 drivers/gpu/drm/tiny/ofdrm.c                  |   2 +-
 drivers/gpu/drm/tiny/panel-mipi-dbi.c         |   2 +-
 drivers/gpu/drm/tiny/repaper.c                |   2 +-
 drivers/gpu/drm/tiny/simpledrm.c              |   2 +-
 drivers/gpu/drm/tiny/st7586.c                 |   2 +-
 drivers/gpu/drm/tiny/st7735r.c                |   2 +-
 drivers/gpu/drm/tve200/tve200_drv.c           |   2 +-
 drivers/gpu/drm/udl/udl_drv.c                 |   2 +-
 drivers/gpu/drm/vboxvideo/vbox_drv.c          |   2 +-
 drivers/gpu/drm/vc4/vc4_drv.c                 |   2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c          |   1 +
 drivers/gpu/drm/vkms/vkms_drv.c               |   2 +-
 drivers/gpu/drm/xlnx/zynqmp_dpsub.c           |   2 +-
 include/drm/drm_fb_helper.h                   |   9 -
 include/drm/drm_fbdev.h                       |  15 +
 61 files changed, 586 insertions(+), 576 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_fbdev.c
 create mode 100644 include/drm/drm_fbdev.h

diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 6e55c47288e42..b1c3d31128094 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -117,7 +117,7 @@ drm_kms_helper-y := \
 	drm_self_refresh_helper.o \
 	drm_simple_kms_helper.o
 drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o
-drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fb_helper.o
+drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fbdev.o drm_fb_helper.o
 obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o
 
 #
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index 9fce4239d4ad4..9124d9e3f4e71 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -9,7 +9,7 @@
 #include <linux/platform_device.h>
 #include <linux/component.h>
 #include <linux/pm_runtime.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
 #include "komeda_dev.h"
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index a032003c340cc..fddcef0c373e0 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -26,7 +26,7 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modeset_helper.h>
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 1d0b0c54ccc74..7665b651bbc59 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -19,7 +19,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
index a94f1a9e8f409..fa2fec7940b23 100644
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_device.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index bbeb5defc8f5c..44f5da586dad1 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -33,6 +33,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index f7e7f4e919c77..3d3e3dee7d8ec 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
@@ -19,7 +19,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index d1afb420c6e06..f52a90263ac36 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -30,24 +30,17 @@
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/console.h>
-#include <linux/dma-buf.h>
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/slab.h>
 #include <linux/sysrq.h>
-#include <linux/vmalloc.h>
 
 #include <drm/drm_atomic.h>
-#include <drm/drm_crtc.h>
-#include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
+#include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
-#include "drm_crtc_helper_internal.h"
 #include "drm_internal.h"
 
 static bool drm_fbdev_emulation = true;
@@ -61,25 +54,6 @@ MODULE_PARM_DESC(drm_fbdev_overalloc,
 		 "Overallocation of the fbdev buffer (%) [default="
 		 __MODULE_STRING(CONFIG_DRM_FBDEV_OVERALLOC) "]");
 
-/*
- * In order to keep user-space compatibility, we want in certain use-cases
- * to keep leaking the fbdev physical address to the user-space program
- * handling the fbdev buffer.
- * This is a bad habit essentially kept into closed source opengl driver
- * that should really be moved into open-source upstream projects instead
- * of using legacy physical addresses in user space to communicate with
- * other out-of-tree kernel modules.
- *
- * This module_param *should* be removed as soon as possible and be
- * considered as a broken and legacy behaviour from a modern fbdev device.
- */
-#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
-static bool drm_leak_fbdev_smem = false;
-module_param_unsafe(drm_leak_fbdev_smem, bool, 0600);
-MODULE_PARM_DESC(drm_leak_fbdev_smem,
-		 "Allow unsafe leaking fbdev physical smem address [default=false]");
-#endif
-
 static LIST_HEAD(kernel_fb_helper_list);
 static DEFINE_MUTEX(kernel_fb_helper_lock);
 
@@ -372,80 +346,6 @@ static void drm_fb_helper_resume_worker(struct work_struct *work)
 	console_unlock();
 }
 
-static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper,
-					   struct drm_clip_rect *clip,
-					   struct iosys_map *dst)
-{
-	struct drm_framebuffer *fb = fb_helper->fb;
-	size_t offset = clip->y1 * fb->pitches[0];
-	size_t len = clip->x2 - clip->x1;
-	unsigned int y;
-	void *src;
-
-	switch (drm_format_info_bpp(fb->format, 0)) {
-	case 1:
-		offset += clip->x1 / 8;
-		len = DIV_ROUND_UP(len + clip->x1 % 8, 8);
-		break;
-	case 2:
-		offset += clip->x1 / 4;
-		len = DIV_ROUND_UP(len + clip->x1 % 4, 4);
-		break;
-	case 4:
-		offset += clip->x1 / 2;
-		len = DIV_ROUND_UP(len + clip->x1 % 2, 2);
-		break;
-	default:
-		offset += clip->x1 * fb->format->cpp[0];
-		len *= fb->format->cpp[0];
-		break;
-	}
-
-	src = fb_helper->info->screen_buffer + offset;
-	iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
-
-	for (y = clip->y1; y < clip->y2; y++) {
-		iosys_map_memcpy_to(dst, 0, src, len);
-		iosys_map_incr(dst, fb->pitches[0]);
-		src += fb->pitches[0];
-	}
-}
-
-static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper,
-				     struct drm_clip_rect *clip)
-{
-	struct drm_client_buffer *buffer = fb_helper->buffer;
-	struct iosys_map map, dst;
-	int ret;
-
-	/*
-	 * We have to pin the client buffer to its current location while
-	 * flushing the shadow buffer. In the general case, concurrent
-	 * modesetting operations could try to move the buffer and would
-	 * fail. The modeset has to be serialized by acquiring the reservation
-	 * object of the underlying BO here.
-	 *
-	 * For fbdev emulation, we only have to protect against fbdev modeset
-	 * operations. Nothing else will involve the client buffer's BO. So it
-	 * is sufficient to acquire struct drm_fb_helper.lock here.
-	 */
-	mutex_lock(&fb_helper->lock);
-
-	ret = drm_client_buffer_vmap(buffer, &map);
-	if (ret)
-		goto out;
-
-	dst = map;
-	drm_fb_helper_damage_blit_real(fb_helper, clip, &dst);
-
-	drm_client_buffer_vunmap(buffer);
-
-out:
-	mutex_unlock(&fb_helper->lock);
-
-	return ret;
-}
-
 static void drm_fb_helper_damage_work(struct work_struct *work)
 {
 	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
@@ -2322,423 +2222,10 @@ EXPORT_SYMBOL(drm_fb_helper_lastclose);
  *
  * This function can be used as the
  * &drm_mode_config_funcs.output_poll_changed callback for drivers that only
- * need to call drm_fb_helper_hotplug_event().
+ * need to call drm_fbdev.hotplug_event().
  */
 void drm_fb_helper_output_poll_changed(struct drm_device *dev)
 {
 	drm_fb_helper_hotplug_event(dev->fb_helper);
 }
 EXPORT_SYMBOL(drm_fb_helper_output_poll_changed);
-
-static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
-{
-	struct drm_device *dev = fb_helper->dev;
-	struct drm_framebuffer *fb = fb_helper->fb;
-
-	return dev->mode_config.prefer_shadow_fbdev ||
-	       dev->mode_config.prefer_shadow ||
-	       fb->funcs->dirty;
-}
-
-/* @user: 1=userspace, 0=fbcon */
-static int drm_fbdev_fb_open(struct fb_info *info, int user)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-
-	/* No need to take a ref for fbcon because it unbinds on unregister */
-	if (user && !try_module_get(fb_helper->dev->driver->fops->owner))
-		return -ENODEV;
-
-	return 0;
-}
-
-static int drm_fbdev_fb_release(struct fb_info *info, int user)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-
-	if (user)
-		module_put(fb_helper->dev->driver->fops->owner);
-
-	return 0;
-}
-
-static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)
-{
-	struct fb_info *fbi = fb_helper->info;
-	void *shadow = NULL;
-
-	if (!fb_helper->dev)
-		return;
-
-	if (fbi) {
-		if (fbi->fbdefio)
-			fb_deferred_io_cleanup(fbi);
-		if (drm_fbdev_use_shadow_fb(fb_helper))
-			shadow = fbi->screen_buffer;
-	}
-
-	drm_fb_helper_fini(fb_helper);
-
-	if (shadow)
-		vfree(shadow);
-	else if (fb_helper->buffer)
-		drm_client_buffer_vunmap(fb_helper->buffer);
-
-	drm_client_framebuffer_delete(fb_helper->buffer);
-}
-
-static void drm_fbdev_release(struct drm_fb_helper *fb_helper)
-{
-	drm_fbdev_cleanup(fb_helper);
-	drm_client_release(&fb_helper->client);
-	kfree(fb_helper);
-}
-
-/*
- * fb_ops.fb_destroy is called by the last put_fb_info() call at the end of
- * unregister_framebuffer() or fb_release().
- */
-static void drm_fbdev_fb_destroy(struct fb_info *info)
-{
-	drm_fbdev_release(info->par);
-}
-
-static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-
-	if (drm_fbdev_use_shadow_fb(fb_helper))
-		return fb_deferred_io_mmap(info, vma);
-	else if (fb_helper->dev->driver->gem_prime_mmap)
-		return fb_helper->dev->driver->gem_prime_mmap(fb_helper->buffer->gem, vma);
-	else
-		return -ENODEV;
-}
-
-static bool drm_fbdev_use_iomem(struct fb_info *info)
-{
-	struct drm_fb_helper *fb_helper = info->par;
-	struct drm_client_buffer *buffer = fb_helper->buffer;
-
-	return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem;
-}
-
-static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
-				 size_t count, loff_t *ppos)
-{
-	ssize_t ret;
-
-	if (drm_fbdev_use_iomem(info))
-		ret = drm_fb_helper_cfb_read(info, buf, count, ppos);
-	else
-		ret = drm_fb_helper_sys_read(info, buf, count, ppos);
-
-	return ret;
-}
-
-static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
-				  size_t count, loff_t *ppos)
-{
-	ssize_t ret;
-
-	if (drm_fbdev_use_iomem(info))
-		ret = drm_fb_helper_cfb_write(info, buf, count, ppos);
-	else
-		ret = drm_fb_helper_sys_write(info, buf, count, ppos);
-
-	return ret;
-}
-
-static void drm_fbdev_fb_fillrect(struct fb_info *info,
-				  const struct fb_fillrect *rect)
-{
-	if (drm_fbdev_use_iomem(info))
-		drm_fb_helper_cfb_fillrect(info, rect);
-	else
-		drm_fb_helper_sys_fillrect(info, rect);
-}
-
-static void drm_fbdev_fb_copyarea(struct fb_info *info,
-				  const struct fb_copyarea *area)
-{
-	if (drm_fbdev_use_iomem(info))
-		drm_fb_helper_cfb_copyarea(info, area);
-	else
-		drm_fb_helper_sys_copyarea(info, area);
-}
-
-static void drm_fbdev_fb_imageblit(struct fb_info *info,
-				   const struct fb_image *image)
-{
-	if (drm_fbdev_use_iomem(info))
-		drm_fb_helper_cfb_imageblit(info, image);
-	else
-		drm_fb_helper_sys_imageblit(info, image);
-}
-
-static const struct fb_ops drm_fbdev_fb_ops = {
-	.owner		= THIS_MODULE,
-	DRM_FB_HELPER_DEFAULT_OPS,
-	.fb_open	= drm_fbdev_fb_open,
-	.fb_release	= drm_fbdev_fb_release,
-	.fb_destroy	= drm_fbdev_fb_destroy,
-	.fb_mmap	= drm_fbdev_fb_mmap,
-	.fb_read	= drm_fbdev_fb_read,
-	.fb_write	= drm_fbdev_fb_write,
-	.fb_fillrect	= drm_fbdev_fb_fillrect,
-	.fb_copyarea	= drm_fbdev_fb_copyarea,
-	.fb_imageblit	= drm_fbdev_fb_imageblit,
-};
-
-static struct fb_deferred_io drm_fbdev_defio = {
-	.delay		= HZ / 20,
-	.deferred_io	= drm_fb_helper_deferred_io,
-};
-
-/*
- * This function uses the client API to create a framebuffer backed by a dumb buffer.
- *
- * The _sys_ versions are used for &fb_ops.fb_read, fb_write, fb_fillrect,
- * fb_copyarea, fb_imageblit.
- */
-static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,
-				       struct drm_fb_helper_surface_size *sizes)
-{
-	struct drm_client_dev *client = &fb_helper->client;
-	struct drm_device *dev = fb_helper->dev;
-	struct drm_client_buffer *buffer;
-	struct drm_framebuffer *fb;
-	struct fb_info *fbi;
-	u32 format;
-	struct iosys_map map;
-	int ret;
-
-	drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n",
-		    sizes->surface_width, sizes->surface_height,
-		    sizes->surface_bpp);
-
-	format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
-	buffer = drm_client_framebuffer_create(client, sizes->surface_width,
-					       sizes->surface_height, format);
-	if (IS_ERR(buffer))
-		return PTR_ERR(buffer);
-
-	fb_helper->buffer = buffer;
-	fb_helper->fb = buffer->fb;
-	fb = buffer->fb;
-
-	fbi = drm_fb_helper_alloc_info(fb_helper);
-	if (IS_ERR(fbi))
-		return PTR_ERR(fbi);
-
-	fbi->fbops = &drm_fbdev_fb_ops;
-	fbi->screen_size = sizes->surface_height * fb->pitches[0];
-	fbi->fix.smem_len = fbi->screen_size;
-	fbi->flags = FBINFO_DEFAULT;
-
-	drm_fb_helper_fill_info(fbi, fb_helper, sizes);
-
-	if (drm_fbdev_use_shadow_fb(fb_helper)) {
-		fbi->screen_buffer = vzalloc(fbi->screen_size);
-		if (!fbi->screen_buffer)
-			return -ENOMEM;
-		fbi->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST;
-
-		fbi->fbdefio = &drm_fbdev_defio;
-		fb_deferred_io_init(fbi);
-	} else {
-		/* buffer is mapped for HW framebuffer */
-		ret = drm_client_buffer_vmap(fb_helper->buffer, &map);
-		if (ret)
-			return ret;
-		if (map.is_iomem) {
-			fbi->screen_base = map.vaddr_iomem;
-		} else {
-			fbi->screen_buffer = map.vaddr;
-			fbi->flags |= FBINFO_VIRTFB;
-		}
-
-		/*
-		 * Shamelessly leak the physical address to user-space. As
-		 * page_to_phys() is undefined for I/O memory, warn in this
-		 * case.
-		 */
-#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
-		if (drm_leak_fbdev_smem && fbi->fix.smem_start == 0 &&
-		    !drm_WARN_ON_ONCE(dev, map.is_iomem))
-			fbi->fix.smem_start =
-				page_to_phys(virt_to_page(fbi->screen_buffer));
-#endif
-	}
-
-	return 0;
-}
-
-static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
-{
-	struct drm_device *dev = helper->dev;
-	int ret;
-
-	if (!drm_fbdev_use_shadow_fb(helper))
-		return 0;
-
-	/* Call damage handlers only if necessary */
-	if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
-		return 0;
-
-	if (helper->buffer) {
-		ret = drm_fb_helper_damage_blit(helper, clip);
-		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
-			return ret;
-	}
-
-	if (helper->fb->funcs->dirty) {
-		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
-		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
-			return ret;
-	}
-
-	return 0;
-}
-
-static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = {
-	.fb_probe = drm_fb_helper_generic_probe,
-	.fb_dirty = drm_fbdev_fb_dirty,
-};
-
-static void drm_fbdev_client_unregister(struct drm_client_dev *client)
-{
-	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
-
-	if (fb_helper->info)
-		/* drm_fbdev_fb_destroy() takes care of cleanup */
-		drm_fb_helper_unregister_info(fb_helper);
-	else
-		drm_fbdev_release(fb_helper);
-}
-
-static int drm_fbdev_client_restore(struct drm_client_dev *client)
-{
-	drm_fb_helper_lastclose(client->dev);
-
-	return 0;
-}
-
-static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
-{
-	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
-	struct drm_device *dev = client->dev;
-	int ret;
-
-	/* Setup is not retried if it has failed */
-	if (!fb_helper->dev && fb_helper->funcs)
-		return 0;
-
-	if (dev->fb_helper)
-		return drm_fb_helper_hotplug_event(dev->fb_helper);
-
-	if (!dev->mode_config.num_connector) {
-		drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n");
-		return 0;
-	}
-
-	drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs);
-
-	ret = drm_fb_helper_init(dev, fb_helper);
-	if (ret)
-		goto err;
-
-	if (!drm_drv_uses_atomic_modeset(dev))
-		drm_helper_disable_unused_functions(dev);
-
-	ret = drm_fb_helper_initial_config(fb_helper, fb_helper->preferred_bpp);
-	if (ret)
-		goto err_cleanup;
-
-	return 0;
-
-err_cleanup:
-	drm_fbdev_cleanup(fb_helper);
-err:
-	fb_helper->dev = NULL;
-	fb_helper->info = NULL;
-
-	drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret);
-
-	return ret;
-}
-
-static const struct drm_client_funcs drm_fbdev_client_funcs = {
-	.owner		= THIS_MODULE,
-	.unregister	= drm_fbdev_client_unregister,
-	.restore	= drm_fbdev_client_restore,
-	.hotplug	= drm_fbdev_client_hotplug,
-};
-
-/**
- * drm_fbdev_generic_setup() - Setup generic fbdev emulation
- * @dev: DRM device
- * @preferred_bpp: Preferred bits per pixel for the device.
- *                 @dev->mode_config.preferred_depth is used if this is zero.
- *
- * This function sets up generic fbdev emulation for drivers that supports
- * dumb buffers with a virtual address and that can be mmap'ed.
- * drm_fbdev_generic_setup() shall be called after the DRM driver registered
- * the new DRM device with drm_dev_register().
- *
- * Restore, hotplug events and teardown are all taken care of. Drivers that do
- * suspend/resume need to call drm_fb_helper_set_suspend_unlocked() themselves.
- * Simple drivers might use drm_mode_config_helper_suspend().
- *
- * Drivers that set the dirty callback on their framebuffer will get a shadow
- * fbdev buffer that is blitted onto the real buffer. This is done in order to
- * make deferred I/O work with all kinds of buffers. A shadow buffer can be
- * requested explicitly by setting struct drm_mode_config.prefer_shadow or
- * struct drm_mode_config.prefer_shadow_fbdev to true beforehand. This is
- * required to use generic fbdev emulation with SHMEM helpers.
- *
- * This function is safe to call even when there are no connectors present.
- * Setup will be retried on the next hotplug event.
- *
- * The fbdev is destroyed by drm_dev_unregister().
- */
-void drm_fbdev_generic_setup(struct drm_device *dev,
-			     unsigned int preferred_bpp)
-{
-	struct drm_fb_helper *fb_helper;
-	int ret;
-
-	drm_WARN(dev, !dev->registered, "Device has not been registered.\n");
-	drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n");
-
-	fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL);
-	if (!fb_helper) {
-		drm_err(dev, "Failed to allocate fb_helper\n");
-		return;
-	}
-
-	ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs);
-	if (ret) {
-		kfree(fb_helper);
-		drm_err(dev, "Failed to register client: %d\n", ret);
-		return;
-	}
-
-	/*
-	 * FIXME: This mixes up depth with bpp, which results in a glorious
-	 * mess, resulting in some drivers picking wrong fbdev defaults and
-	 * others wrong preferred_depth defaults.
-	 */
-	if (!preferred_bpp)
-		preferred_bpp = dev->mode_config.preferred_depth;
-	if (!preferred_bpp)
-		preferred_bpp = 32;
-	fb_helper->preferred_bpp = preferred_bpp;
-
-	ret = drm_fbdev_client_hotplug(&fb_helper->client);
-	if (ret)
-		drm_dbg_kms(dev, "client hotplug ret=%d\n", ret);
-
-	drm_client_register(&fb_helper->client);
-}
-EXPORT_SYMBOL(drm_fbdev_generic_setup);
diff --git a/drivers/gpu/drm/drm_fbdev.c b/drivers/gpu/drm/drm_fbdev.c
new file mode 100644
index 0000000000000..64085bc8b3809
--- /dev/null
+++ b/drivers/gpu/drm/drm_fbdev.c
@@ -0,0 +1,512 @@
+// SPDX-License-Identifier: MIT
+
+#include <linux/moduleparam.h>
+
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_drv.h>
+#include <drm/drm_fb_helper.h>
+#include <drm/drm_framebuffer.h>
+#include <drm/drm_print.h>
+
+#include <drm/drm_fbdev.h>
+
+/*
+ * In order to keep user-space compatibility, we want in certain use-cases
+ * to keep leaking the fbdev physical address to the user-space program
+ * handling the fbdev buffer.
+ * This is a bad habit essentially kept into closed source opengl driver
+ * that should really be moved into open-source upstream projects instead
+ * of using legacy physical addresses in user space to communicate with
+ * other out-of-tree kernel modules.
+ *
+ * This module_param *should* be removed as soon as possible and be
+ * considered as a broken and legacy behaviour from a modern fbdev device.
+ */
+#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
+static bool drm_leak_fbdev_smem;
+module_param_unsafe(drm_leak_fbdev_smem, bool, 0600);
+MODULE_PARM_DESC(drm_leak_fbdev_smem,
+		 "Allow unsafe leaking fbdev physical smem address [default=false]");
+#endif
+
+static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
+{
+	struct drm_device *dev = fb_helper->dev;
+	struct drm_framebuffer *fb = fb_helper->fb;
+
+	return dev->mode_config.prefer_shadow_fbdev ||
+	       dev->mode_config.prefer_shadow ||
+	       fb->funcs->dirty;
+}
+
+/* @user: 1=userspace, 0=fbcon */
+static int drm_fbdev_fb_open(struct fb_info *info, int user)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+
+	/* No need to take a ref for fbcon because it unbinds on unregister */
+	if (user && !try_module_get(fb_helper->dev->driver->fops->owner))
+		return -ENODEV;
+
+	return 0;
+}
+
+static int drm_fbdev_fb_release(struct fb_info *info, int user)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+
+	if (user)
+		module_put(fb_helper->dev->driver->fops->owner);
+
+	return 0;
+}
+
+static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)
+{
+	struct fb_info *fbi = fb_helper->info;
+	void *shadow = NULL;
+
+	if (!fb_helper->dev)
+		return;
+
+	if (fbi) {
+		if (fbi->fbdefio)
+			fb_deferred_io_cleanup(fbi);
+		if (drm_fbdev_use_shadow_fb(fb_helper))
+			shadow = fbi->screen_buffer;
+	}
+
+	drm_fb_helper_fini(fb_helper);
+
+	if (shadow)
+		vfree(shadow);
+	else if (fb_helper->buffer)
+		drm_client_buffer_vunmap(fb_helper->buffer);
+
+	drm_client_framebuffer_delete(fb_helper->buffer);
+}
+
+static void drm_fbdev_release(struct drm_fb_helper *fb_helper)
+{
+	drm_fbdev_cleanup(fb_helper);
+	drm_client_release(&fb_helper->client);
+	kfree(fb_helper);
+}
+
+/*
+ * fb_ops.fb_destroy is called by the last put_fb_info() call at the end of
+ * unregister_framebuffer() or fb_release().
+ */
+static void drm_fbdev_fb_destroy(struct fb_info *info)
+{
+	drm_fbdev_release(info->par);
+}
+
+static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+
+	if (drm_fbdev_use_shadow_fb(fb_helper))
+		return fb_deferred_io_mmap(info, vma);
+	else if (fb_helper->dev->driver->gem_prime_mmap)
+		return fb_helper->dev->driver->gem_prime_mmap(fb_helper->buffer->gem, vma);
+	else
+		return -ENODEV;
+}
+
+static bool drm_fbdev_use_iomem(struct fb_info *info)
+{
+	struct drm_fb_helper *fb_helper = info->par;
+	struct drm_client_buffer *buffer = fb_helper->buffer;
+
+	return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem;
+}
+
+static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
+				 size_t count, loff_t *ppos)
+{
+	ssize_t ret;
+
+	if (drm_fbdev_use_iomem(info))
+		ret = drm_fb_helper_cfb_read(info, buf, count, ppos);
+	else
+		ret = drm_fb_helper_sys_read(info, buf, count, ppos);
+
+	return ret;
+}
+
+static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
+				  size_t count, loff_t *ppos)
+{
+	ssize_t ret;
+
+	if (drm_fbdev_use_iomem(info))
+		ret = drm_fb_helper_cfb_write(info, buf, count, ppos);
+	else
+		ret = drm_fb_helper_sys_write(info, buf, count, ppos);
+
+	return ret;
+}
+
+static void drm_fbdev_fb_fillrect(struct fb_info *info,
+				  const struct fb_fillrect *rect)
+{
+	if (drm_fbdev_use_iomem(info))
+		drm_fb_helper_cfb_fillrect(info, rect);
+	else
+		drm_fb_helper_sys_fillrect(info, rect);
+}
+
+static void drm_fbdev_fb_copyarea(struct fb_info *info,
+				  const struct fb_copyarea *area)
+{
+	if (drm_fbdev_use_iomem(info))
+		drm_fb_helper_cfb_copyarea(info, area);
+	else
+		drm_fb_helper_sys_copyarea(info, area);
+}
+
+static void drm_fbdev_fb_imageblit(struct fb_info *info,
+				   const struct fb_image *image)
+{
+	if (drm_fbdev_use_iomem(info))
+		drm_fb_helper_cfb_imageblit(info, image);
+	else
+		drm_fb_helper_sys_imageblit(info, image);
+}
+
+static const struct fb_ops drm_fbdev_fb_ops = {
+	.owner		= THIS_MODULE,
+	DRM_FB_HELPER_DEFAULT_OPS,
+	.fb_open	= drm_fbdev_fb_open,
+	.fb_release	= drm_fbdev_fb_release,
+	.fb_destroy	= drm_fbdev_fb_destroy,
+	.fb_mmap	= drm_fbdev_fb_mmap,
+	.fb_read	= drm_fbdev_fb_read,
+	.fb_write	= drm_fbdev_fb_write,
+	.fb_fillrect	= drm_fbdev_fb_fillrect,
+	.fb_copyarea	= drm_fbdev_fb_copyarea,
+	.fb_imageblit	= drm_fbdev_fb_imageblit,
+};
+
+static struct fb_deferred_io drm_fbdev_defio = {
+	.delay		= HZ / 20,
+	.deferred_io	= drm_fb_helper_deferred_io,
+};
+
+/*
+ * This function uses the client API to create a framebuffer backed by a dumb buffer.
+ */
+static int drm_fbdev_fb_probe(struct drm_fb_helper *fb_helper,
+			      struct drm_fb_helper_surface_size *sizes)
+{
+	struct drm_client_dev *client = &fb_helper->client;
+	struct drm_device *dev = fb_helper->dev;
+	struct drm_client_buffer *buffer;
+	struct drm_framebuffer *fb;
+	struct fb_info *fbi;
+	u32 format;
+	struct iosys_map map;
+	int ret;
+
+	drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n",
+		    sizes->surface_width, sizes->surface_height,
+		    sizes->surface_bpp);
+
+	format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
+	buffer = drm_client_framebuffer_create(client, sizes->surface_width,
+					       sizes->surface_height, format);
+	if (IS_ERR(buffer))
+		return PTR_ERR(buffer);
+
+	fb_helper->buffer = buffer;
+	fb_helper->fb = buffer->fb;
+	fb = buffer->fb;
+
+	fbi = drm_fb_helper_alloc_info(fb_helper);
+	if (IS_ERR(fbi))
+		return PTR_ERR(fbi);
+
+	fbi->fbops = &drm_fbdev_fb_ops;
+	fbi->screen_size = sizes->surface_height * fb->pitches[0];
+	fbi->fix.smem_len = fbi->screen_size;
+	fbi->flags = FBINFO_DEFAULT;
+
+	drm_fb_helper_fill_info(fbi, fb_helper, sizes);
+
+	if (drm_fbdev_use_shadow_fb(fb_helper)) {
+		fbi->screen_buffer = vzalloc(fbi->screen_size);
+		if (!fbi->screen_buffer)
+			return -ENOMEM;
+		fbi->flags |= FBINFO_VIRTFB | FBINFO_READS_FAST;
+
+		fbi->fbdefio = &drm_fbdev_defio;
+		fb_deferred_io_init(fbi);
+	} else {
+		/* buffer is mapped for HW framebuffer */
+		ret = drm_client_buffer_vmap(fb_helper->buffer, &map);
+		if (ret)
+			return ret;
+		if (map.is_iomem) {
+			fbi->screen_base = map.vaddr_iomem;
+		} else {
+			fbi->screen_buffer = map.vaddr;
+			fbi->flags |= FBINFO_VIRTFB;
+		}
+
+		/*
+		 * Shamelessly leak the physical address to user-space. As
+		 * page_to_phys() is undefined for I/O memory, warn in this
+		 * case.
+		 */
+#if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
+		if (drm_leak_fbdev_smem && fbi->fix.smem_start == 0 &&
+		    !drm_WARN_ON_ONCE(dev, map.is_iomem))
+			fbi->fix.smem_start =
+				page_to_phys(virt_to_page(fbi->screen_buffer));
+#endif
+	}
+
+	return 0;
+}
+
+static void drm_fbdev_damage_blit_real(struct drm_fb_helper *fb_helper,
+				       struct drm_clip_rect *clip,
+				       struct iosys_map *dst)
+{
+	struct drm_framebuffer *fb = fb_helper->fb;
+	size_t offset = clip->y1 * fb->pitches[0];
+	size_t len = clip->x2 - clip->x1;
+	unsigned int y;
+	void *src;
+
+	switch (drm_format_info_bpp(fb->format, 0)) {
+	case 1:
+		offset += clip->x1 / 8;
+		len = DIV_ROUND_UP(len + clip->x1 % 8, 8);
+		break;
+	case 2:
+		offset += clip->x1 / 4;
+		len = DIV_ROUND_UP(len + clip->x1 % 4, 4);
+		break;
+	case 4:
+		offset += clip->x1 / 2;
+		len = DIV_ROUND_UP(len + clip->x1 % 2, 2);
+		break;
+	default:
+		offset += clip->x1 * fb->format->cpp[0];
+		len *= fb->format->cpp[0];
+		break;
+	}
+
+	src = fb_helper->info->screen_buffer + offset;
+	iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
+
+	for (y = clip->y1; y < clip->y2; y++) {
+		iosys_map_memcpy_to(dst, 0, src, len);
+		iosys_map_incr(dst, fb->pitches[0]);
+		src += fb->pitches[0];
+	}
+}
+
+static int drm_fbdev_damage_blit(struct drm_fb_helper *fb_helper,
+				 struct drm_clip_rect *clip)
+{
+	struct drm_client_buffer *buffer = fb_helper->buffer;
+	struct iosys_map map, dst;
+	int ret;
+
+	/*
+	 * We have to pin the client buffer to its current location while
+	 * flushing the shadow buffer. In the general case, concurrent
+	 * modesetting operations could try to move the buffer and would
+	 * fail. The modeset has to be serialized by acquiring the reservation
+	 * object of the underlying BO here.
+	 *
+	 * For fbdev emulation, we only have to protect against fbdev modeset
+	 * operations. Nothing else will involve the client buffer's BO. So it
+	 * is sufficient to acquire struct drm_fb_helper.lock here.
+	 */
+	mutex_lock(&fb_helper->lock);
+
+	ret = drm_client_buffer_vmap(buffer, &map);
+	if (ret)
+		goto out;
+
+	dst = map;
+	drm_fbdev_damage_blit_real(fb_helper, clip, &dst);
+
+	drm_client_buffer_vunmap(buffer);
+
+out:
+	mutex_unlock(&fb_helper->lock);
+
+	return ret;
+}
+
+static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
+{
+	struct drm_device *dev = helper->dev;
+	int ret;
+
+	if (!drm_fbdev_use_shadow_fb(helper))
+		return 0;
+
+	/* Call damage handlers only if necessary */
+	if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
+		return 0;
+
+	if (helper->buffer) {
+		ret = drm_fbdev_damage_blit(helper, clip);
+		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	if (helper->fb->funcs->dirty) {
+		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
+		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	return 0;
+}
+
+static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = {
+	.fb_probe = drm_fbdev_fb_probe,
+	.fb_dirty = drm_fbdev_fb_dirty,
+};
+
+static void drm_fbdev_client_unregister(struct drm_client_dev *client)
+{
+	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
+
+	if (fb_helper->info)
+		/* drm_fbdev_fb_destroy() takes care of cleanup */
+		drm_fb_helper_unregister_info(fb_helper);
+	else
+		drm_fbdev_release(fb_helper);
+}
+
+static int drm_fbdev_client_restore(struct drm_client_dev *client)
+{
+	drm_fb_helper_lastclose(client->dev);
+
+	return 0;
+}
+
+static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
+{
+	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
+	struct drm_device *dev = client->dev;
+	int ret;
+
+	/* Setup is not retried if it has failed */
+	if (!fb_helper->dev && fb_helper->funcs)
+		return 0;
+
+	if (dev->fb_helper)
+		return drm_fb_helper_hotplug_event(dev->fb_helper);
+
+	if (!dev->mode_config.num_connector) {
+		drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n");
+		return 0;
+	}
+
+	drm_fb_helper_prepare(dev, fb_helper, &drm_fb_helper_generic_funcs);
+
+	ret = drm_fb_helper_init(dev, fb_helper);
+	if (ret)
+		goto err;
+
+	if (!drm_drv_uses_atomic_modeset(dev))
+		drm_helper_disable_unused_functions(dev);
+
+	ret = drm_fb_helper_initial_config(fb_helper, fb_helper->preferred_bpp);
+	if (ret)
+		goto err_cleanup;
+
+	return 0;
+
+err_cleanup:
+	drm_fbdev_cleanup(fb_helper);
+err:
+	fb_helper->dev = NULL;
+	fb_helper->info = NULL;
+
+	drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret);
+
+	return ret;
+}
+
+static const struct drm_client_funcs drm_fbdev_client_funcs = {
+	.owner		= THIS_MODULE,
+	.unregister	= drm_fbdev_client_unregister,
+	.restore	= drm_fbdev_client_restore,
+	.hotplug	= drm_fbdev_client_hotplug,
+};
+
+/**
+ * drm_fbdev_generic_setup() - Setup generic fbdev emulation
+ * @dev: DRM device
+ * @preferred_bpp: Preferred bits per pixel for the device.
+ *                 @dev->mode_config.preferred_depth is used if this is zero.
+ *
+ * This function sets up generic fbdev emulation for drivers that supports
+ * dumb buffers with a virtual address and that can be mmap'ed.
+ * drm_fbdev_generic_setup() shall be called after the DRM driver registered
+ * the new DRM device with drm_dev_register().
+ *
+ * Restore, hotplug events and teardown are all taken care of. Drivers that do
+ * suspend/resume need to call drm_fb_helper_set_suspend_unlocked() themselves.
+ * Simple drivers might use drm_mode_config_helper_suspend().
+ *
+ * Drivers that set the dirty callback on their framebuffer will get a shadow
+ * fbdev buffer that is blitted onto the real buffer. This is done in order to
+ * make deferred I/O work with all kinds of buffers. A shadow buffer can be
+ * requested explicitly by setting struct drm_mode_config.prefer_shadow or
+ * struct drm_mode_config.prefer_shadow_fbdev to true beforehand. This is
+ * required to use generic fbdev emulation with SHMEM helpers.
+ *
+ * This function is safe to call even when there are no connectors present.
+ * Setup will be retried on the next hotplug event.
+ *
+ * The fbdev is destroyed by drm_dev_unregister().
+ */
+void drm_fbdev_generic_setup(struct drm_device *dev,
+			     unsigned int preferred_bpp)
+{
+	struct drm_fb_helper *fb_helper;
+	int ret;
+
+	drm_WARN(dev, !dev->registered, "Device has not been registered.\n");
+	drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n");
+
+	fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL);
+	if (!fb_helper)
+		return;
+
+	ret = drm_client_init(dev, &fb_helper->client, "fbdev", &drm_fbdev_client_funcs);
+	if (ret) {
+		kfree(fb_helper);
+		drm_err(dev, "Failed to register client: %d\n", ret);
+		return;
+	}
+
+	/*
+	 * FIXME: This mixes up depth with bpp, which results in a glorious
+	 * mess, resulting in some drivers picking wrong fbdev defaults and
+	 * others wrong preferred_depth defaults.
+	 */
+	if (!preferred_bpp)
+		preferred_bpp = dev->mode_config.preferred_depth;
+	if (!preferred_bpp)
+		preferred_bpp = 32;
+	fb_helper->preferred_bpp = preferred_bpp;
+
+	ret = drm_fbdev_client_hotplug(&fb_helper->client);
+	if (ret)
+		drm_dbg_kms(dev, "client hotplug ret=%d\n", ret);
+
+	drm_client_register(&fb_helper->client);
+}
+EXPORT_SYMBOL(drm_fbdev_generic_setup);
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index b4acc3422ba45..5bf2d019dd5c4 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -20,7 +20,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_modeset_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index 8d1630b8edac1..53e4630369c9c 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
+++ b/drivers/gpu/drm/gud/gud_drv.c
@@ -18,7 +18,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 5a2e1cac06b2e..cd3b6d6444b0d 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -17,6 +17,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_gem_vram_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
index 73ee7f25f7346..47c22b8f37acd 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
@@ -19,7 +19,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index ca127ff797f75..5462e05ad2e49 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -11,7 +11,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_simple_kms_helper.h>
 
diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index 1defd6a40f11d..4f4267c95c76e 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -7,7 +7,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 8dd8b0f912af6..a82c92f0a0d10 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
index 99f86f1ba8bee..20d8953525876 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
@@ -32,7 +32,7 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 2382ccb3ee99d..0fc46b71e5bf5 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -15,7 +15,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
index cc9a4e965f779..87bbfd55f7803 100644
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -17,7 +17,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_print.h>
 
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c
index 38c3907bb151a..52ec3f70ea087 100644
--- a/drivers/gpu/drm/mcde/mcde_drv.c
+++ b/drivers/gpu/drm/mcde/mcde_drv.c
@@ -69,7 +69,7 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 91f58db5915f5..450ba47bd8771 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -17,7 +17,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_dma_helper.h>
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index 3b24a924b7b97..c88a5eab9dad3 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -18,7 +18,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_modeset_helper_vtables.h>
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index ece6cd102dbb1..75132cfc8d6de 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -11,6 +11,7 @@
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
index 075002ed6fb09..d682b26f84c0b 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_mode_config.h>
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index b29b332ed3814..eec7c26d039f0 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -20,7 +20,7 @@
 #include <drm/drm_bridge.h>
 #include <drm/drm_connector.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index b59472c29a40d..d37fc22527e1f 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -31,7 +31,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index eb25eedb5ee00..fdc40470e1a1f 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -48,7 +48,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index 3044ca948ce22..34cda5b234100 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.c
+++ b/drivers/gpu/drm/qxl/qxl_drv.c
@@ -37,6 +37,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_gem_ttm_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index a2776f1d6f2c2..6b9e87a49e8e9 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -20,7 +20,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 813f9f8c86982..8bf0a85a59b40 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -17,7 +17,7 @@
 
 #include <drm/drm_aperture.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c
index f2795f90ea693..5a654201ff32c 100644
--- a/drivers/gpu/drm/solomon/ssd130x.c
+++ b/drivers/gpu/drm/solomon/ssd130x.c
@@ -23,7 +23,7 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 7abf010a32935..0d9607855ef66 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -14,7 +14,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
index d7914f5122dff..9e7159eef7e2c 100644
--- a/drivers/gpu/drm/stm/drv.c
+++ b/drivers/gpu/drm/stm/drv.c
@@ -18,7 +18,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index d06ffd99d86e1..63d27244268ea 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -17,7 +17,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_module.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 15cd9b91b7e2a..0c5534194cd0f 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -14,7 +14,7 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index f72755b8ea14c..3fb1e8d0e8f80 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
index bb302a3fd6b5f..4d10c5bf2e601 100644
--- a/drivers/gpu/drm/tiny/arcpgu.c
+++ b/drivers/gpu/drm/tiny/arcpgu.c
@@ -12,7 +12,7 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 04682f831544c..6cf2ad5b55fed 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -7,7 +7,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/tiny/cirrus.c
index 354d5e854a6f0..f7181b2f8369d 100644
--- a/drivers/gpu/drm/tiny/cirrus.c
+++ b/drivers/gpu/drm/tiny/cirrus.c
@@ -30,7 +30,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
diff --git a/drivers/gpu/drm/tiny/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
index 7441d992a5d7a..3a37138aeba96 100644
--- a/drivers/gpu/drm/tiny/gm12u320.c
+++ b/drivers/gpu/drm/tiny/gm12u320.c
@@ -12,7 +12,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
diff --git a/drivers/gpu/drm/tiny/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c
index 48c24aa8c28a1..eefffa46bb78d 100644
--- a/drivers/gpu/drm/tiny/hx8357d.c
+++ b/drivers/gpu/drm/tiny/hx8357d.c
@@ -18,7 +18,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/ili9163.c b/drivers/gpu/drm/tiny/ili9163.c
index 9a1a5943bee01..0aa1d84995abc 100644
--- a/drivers/gpu/drm/tiny/ili9163.c
+++ b/drivers/gpu/drm/tiny/ili9163.c
@@ -9,7 +9,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_mipi_dbi.h>
diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
index a79da2b4af647..028e63e68a883 100644
--- a/drivers/gpu/drm/tiny/ili9225.c
+++ b/drivers/gpu/drm/tiny/ili9225.c
@@ -20,7 +20,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/ili9341.c b/drivers/gpu/drm/tiny/ili9341.c
index 69b265e78096b..2a0b516ff1b44 100644
--- a/drivers/gpu/drm/tiny/ili9341.c
+++ b/drivers/gpu/drm/tiny/ili9341.c
@@ -17,7 +17,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index c80028bb1d110..f16cadc813ca7 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -16,7 +16,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c
index bc522fb3d94d1..5307d5d28df59 100644
--- a/drivers/gpu/drm/tiny/mi0283qt.c
+++ b/drivers/gpu/drm/tiny/mi0283qt.c
@@ -15,7 +15,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
index 0e1cc2369afcc..016372da72d12 100644
--- a/drivers/gpu/drm/tiny/ofdrm.c
+++ b/drivers/gpu/drm/tiny/ofdrm.c
@@ -11,7 +11,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
index 955a61d628e7c..7249cf8accec4 100644
--- a/drivers/gpu/drm/tiny/panel-mipi-dbi.c
+++ b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
@@ -16,7 +16,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
index e62f4d16b2c6b..347366a3d5767 100644
--- a/drivers/gpu/drm/tiny/repaper.c
+++ b/drivers/gpu/drm/tiny/repaper.c
@@ -26,7 +26,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index cbb100753154e..b9f541c058c55 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -15,7 +15,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c
index b6f620b902e6d..a9de2c6695d13 100644
--- a/drivers/gpu/drm/tiny/st7586.c
+++ b/drivers/gpu/drm/tiny/st7586.c
@@ -16,7 +16,7 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_atomic_helper.h>
diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c
index c36ba08acda18..4d2d43c27582f 100644
--- a/drivers/gpu/drm/tiny/st7735r.c
+++ b/drivers/gpu/drm/tiny/st7735r.c
@@ -18,7 +18,7 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_atomic_helper.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c
index 611785e097576..684f319d94c70 100644
--- a/drivers/gpu/drm/tve200/tve200_drv.c
+++ b/drivers/gpu/drm/tve200/tve200_drv.c
@@ -40,7 +40,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_module.h>
diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
index 91effdcefb6d5..6ccfc23b9134c 100644
--- a/drivers/gpu/drm/udl/udl_drv.c
+++ b/drivers/gpu/drm/udl/udl_drv.c
@@ -7,7 +7,7 @@
 
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index 1cd716eb17a1c..61cc110440a54 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_drv.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c
@@ -14,7 +14,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_managed.h>
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 2027063fdc309..94d4a6b1cd3ab 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -33,7 +33,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_vblank.h>
 
 #include <soc/bcm2835/raspberrypi-firmware.h>
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
index 0035affc3e590..70c0f49ac895b 100644
--- a/drivers/gpu/drm/virtio/virtgpu_drv.c
+++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
@@ -35,6 +35,7 @@
 #include <drm/drm_aperture.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 
 #include "virtgpu_drv.h"
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 0ffe5f0e33f75..e616d2e614dcb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -17,7 +17,7 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_file.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_ioctl.h>
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 1de2d927c32b0..27c8a8218914b 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -19,7 +19,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_device.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_fbdev.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 6581183618b89..933ca016f1224 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -285,9 +285,6 @@ int drm_fb_helper_debug_leave(struct fb_info *info);
 
 void drm_fb_helper_lastclose(struct drm_device *dev);
 void drm_fb_helper_output_poll_changed(struct drm_device *dev);
-
-void drm_fbdev_generic_setup(struct drm_device *dev,
-			     unsigned int preferred_bpp);
 #else
 static inline void drm_fb_helper_prepare(struct drm_device *dev,
 					struct drm_fb_helper *helper,
@@ -472,12 +469,6 @@ static inline void drm_fb_helper_lastclose(struct drm_device *dev)
 static inline void drm_fb_helper_output_poll_changed(struct drm_device *dev)
 {
 }
-
-static inline void
-drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
-{
-}
-
 #endif
 
 #endif
diff --git a/include/drm/drm_fbdev.h b/include/drm/drm_fbdev.h
new file mode 100644
index 0000000000000..d977087e94b6b
--- /dev/null
+++ b/include/drm/drm_fbdev.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: MIT */
+
+#ifndef DRM_FBDEV_H
+#define DRM_FBDEV_H
+
+struct drm_device;
+
+#ifdef CONFIG_DRM_FBDEV_EMULATION
+void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp);
+#else
+static inline void drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp)
+{ }
+#endif
+
+#endif
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:25:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:25:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428936.679696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvZt-0005zF-92; Mon, 24 Oct 2022 11:25:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428936.679696; Mon, 24 Oct 2022 11:25:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvZt-0005yL-0x; Mon, 24 Oct 2022 11:25:09 +0000
Received: by outflank-mailman (input) for mailman id 428936;
 Mon, 24 Oct 2022 11:25:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV2-00036S-LT
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:08 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf1417ea-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:04 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AF02F220D3;
 Mon, 24 Oct 2022 11:20:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3060213A98;
 Mon, 24 Oct 2022 11:20:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id II3yCuR0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf1417ea-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3lFh5py/uuejzjrH4enP5SeVdkJcqJZSxlFS1c3b9pk=;
	b=k6It662NZs3cD8nSbsDZ9BGpRjKZDpKVcubBKXjkRJVoui0QiU026gLrP8f7rlVYBato0s
	nacdaR3D/MXdBCJm7viFNbCfA8OukdE0H1eGgdIZmSCLNalfPQ+l9VLhpARBdFO2X4+VPc
	eTMg8K2IR63AKFnwaeA9H+VWINKHqpc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610404;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3lFh5py/uuejzjrH4enP5SeVdkJcqJZSxlFS1c3b9pk=;
	b=2SB6K3jJHZtY19hgfQ5A4Ljs4ZF+k1F52aepwcfvGlybtt6uR2xd7x4h8XMmJVjEkiVJ6c
	9wjuOHpEDp6k1iAw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper
Date: Mon, 24 Oct 2022 13:19:44 +0200
Message-Id: <20221024111953.24307-13-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Rename struct drm_fb_helper.fbdev to info. The current name is
misleading as it overlaps with generic fbdev naming conventions.
Adapt to the usual naming in fbdev drivers by calling the field
'info'. No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c            | 40 +++++++++++-----------
 drivers/gpu/drm/i915/display/intel_fbdev.c |  2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c    | 23 ++++++-------
 drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 +-
 drivers/gpu/drm/tegra/fb.c                 |  2 +-
 include/drm/drm_fb_helper.h                |  4 +--
 6 files changed, 36 insertions(+), 37 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 71edb80fe0fb9..480bf4f568b7b 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -368,7 +368,7 @@ static void drm_fb_helper_resume_worker(struct work_struct *work)
 						    resume_work);
 
 	console_lock();
-	fb_set_suspend(helper->fbdev, 0);
+	fb_set_suspend(helper->info, 0);
 	console_unlock();
 }
 
@@ -401,7 +401,7 @@ static void drm_fb_helper_damage_blit_real(struct drm_fb_helper *fb_helper,
 		break;
 	}
 
-	src = fb_helper->fbdev->screen_buffer + offset;
+	src = fb_helper->info->screen_buffer + offset;
 	iosys_map_incr(dst, offset); /* go to first pixel within clip rect */
 
 	for (y = clip->y1; y < clip->y2; y++) {
@@ -598,7 +598,7 @@ struct fb_info *drm_fb_helper_alloc_fbi(struct drm_fb_helper *fb_helper)
 		goto err_free_cmap;
 	}
 
-	fb_helper->fbdev = info;
+	fb_helper->info = info;
 	info->skip_vt_switch = true;
 
 	return info;
@@ -621,8 +621,8 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
  */
 void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
 {
-	if (fb_helper && fb_helper->fbdev)
-		unregister_framebuffer(fb_helper->fbdev);
+	if (fb_helper && fb_helper->info)
+		unregister_framebuffer(fb_helper->info);
 }
 EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
 
@@ -647,13 +647,13 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
 	cancel_work_sync(&fb_helper->resume_work);
 	cancel_work_sync(&fb_helper->damage_work);
 
-	info = fb_helper->fbdev;
+	info = fb_helper->info;
 	if (info) {
 		if (info->cmap.len)
 			fb_dealloc_cmap(&info->cmap);
 		framebuffer_release(info);
 	}
-	fb_helper->fbdev = NULL;
+	fb_helper->info = NULL;
 
 	mutex_lock(&kernel_fb_helper_lock);
 	if (!list_empty(&fb_helper->kernel_fb_list)) {
@@ -914,8 +914,8 @@ EXPORT_SYMBOL(drm_fb_helper_cfb_imageblit);
  */
 void drm_fb_helper_set_suspend(struct drm_fb_helper *fb_helper, bool suspend)
 {
-	if (fb_helper && fb_helper->fbdev)
-		fb_set_suspend(fb_helper->fbdev, suspend);
+	if (fb_helper && fb_helper->info)
+		fb_set_suspend(fb_helper->info, suspend);
 }
 EXPORT_SYMBOL(drm_fb_helper_set_suspend);
 
@@ -938,20 +938,20 @@ EXPORT_SYMBOL(drm_fb_helper_set_suspend);
 void drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper,
 					bool suspend)
 {
-	if (!fb_helper || !fb_helper->fbdev)
+	if (!fb_helper || !fb_helper->info)
 		return;
 
 	/* make sure there's no pending/ongoing resume */
 	flush_work(&fb_helper->resume_work);
 
 	if (suspend) {
-		if (fb_helper->fbdev->state != FBINFO_STATE_RUNNING)
+		if (fb_helper->info->state != FBINFO_STATE_RUNNING)
 			return;
 
 		console_lock();
 
 	} else {
-		if (fb_helper->fbdev->state == FBINFO_STATE_RUNNING)
+		if (fb_helper->info->state == FBINFO_STATE_RUNNING)
 			return;
 
 		if (!console_trylock()) {
@@ -960,7 +960,7 @@ void drm_fb_helper_set_suspend_unlocked(struct drm_fb_helper *fb_helper,
 		}
 	}
 
-	fb_set_suspend(fb_helper->fbdev, suspend);
+	fb_set_suspend(fb_helper->info, suspend);
 	console_unlock();
 }
 EXPORT_SYMBOL(drm_fb_helper_set_suspend_unlocked);
@@ -1850,7 +1850,7 @@ EXPORT_SYMBOL(drm_fb_helper_fill_info);
 /*
  * This is a continuation of drm_setup_crtcs() that sets up anything related
  * to the framebuffer. During initialization, drm_setup_crtcs() is called before
- * the framebuffer has been allocated (fb_helper->fb and fb_helper->fbdev).
+ * the framebuffer has been allocated (fb_helper->fb and fb_helper->info).
  * So, any setup that touches those fields needs to be done here instead of in
  * drm_setup_crtcs().
  */
@@ -1858,7 +1858,7 @@ static void drm_setup_crtcs_fb(struct drm_fb_helper *fb_helper)
 {
 	struct drm_client_dev *client = &fb_helper->client;
 	struct drm_connector_list_iter conn_iter;
-	struct fb_info *info = fb_helper->fbdev;
+	struct fb_info *info = fb_helper->info;
 	unsigned int rotation, sw_rotations = 0;
 	struct drm_connector *connector;
 	struct drm_mode_set *modeset;
@@ -1942,7 +1942,7 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper,
 
 	fb_helper->deferred_setup = false;
 
-	info = fb_helper->fbdev;
+	info = fb_helper->info;
 	info->var.pixclock = 0;
 	/* Shamelessly allow physical address leaking to userspace */
 #if IS_ENABLED(CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM)
@@ -2077,7 +2077,7 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper)
 	drm_setup_crtcs_fb(fb_helper);
 	mutex_unlock(&fb_helper->lock);
 
-	drm_fb_helper_set_par(fb_helper->fbdev);
+	drm_fb_helper_set_par(fb_helper->info);
 
 	return 0;
 }
@@ -2135,7 +2135,7 @@ static int drm_fbdev_fb_release(struct fb_info *info, int user)
 
 static void drm_fbdev_cleanup(struct drm_fb_helper *fb_helper)
 {
-	struct fb_info *fbi = fb_helper->fbdev;
+	struct fb_info *fbi = fb_helper->info;
 	void *shadow = NULL;
 
 	if (!fb_helper->dev)
@@ -2495,7 +2495,7 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
 {
 	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
 
-	if (fb_helper->fbdev)
+	if (fb_helper->info)
 		/* drm_fbdev_fb_destroy() takes care of cleanup */
 		drm_fb_helper_unregister_fbi(fb_helper);
 	else
@@ -2546,7 +2546,7 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
 	drm_fbdev_cleanup(fb_helper);
 err:
 	fb_helper->dev = NULL;
-	fb_helper->fbdev = NULL;
+	fb_helper->info = NULL;
 
 	drm_err(dev, "fbdev: Failed to setup generic emulation (ret=%d)\n", ret);
 
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index ab385d18ddcc3..d533ecd451025 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -627,7 +627,7 @@ void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous
 	if (!ifbdev || !ifbdev->vma)
 		goto set_suspend;
 
-	info = ifbdev->helper.fbdev;
+	info = ifbdev->helper.info;
 
 	if (synchronous) {
 		/* Flush any pending work to turn the console on, and then
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 3c7e0c9d6baf1..ac4bd529ae2e8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -231,9 +231,9 @@ void
 nouveau_fbcon_accel_save_disable(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
-	if (drm->fbcon && drm->fbcon->helper.fbdev) {
-		drm->fbcon->saved_flags = drm->fbcon->helper.fbdev->flags;
-		drm->fbcon->helper.fbdev->flags |= FBINFO_HWACCEL_DISABLED;
+	if (drm->fbcon && drm->fbcon->helper.info) {
+		drm->fbcon->saved_flags = drm->fbcon->helper.info->flags;
+		drm->fbcon->helper.info->flags |= FBINFO_HWACCEL_DISABLED;
 	}
 }
 
@@ -241,9 +241,8 @@ void
 nouveau_fbcon_accel_restore(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
-	if (drm->fbcon && drm->fbcon->helper.fbdev) {
-		drm->fbcon->helper.fbdev->flags = drm->fbcon->saved_flags;
-	}
+	if (drm->fbcon && drm->fbcon->helper.info)
+		drm->fbcon->helper.info->flags = drm->fbcon->saved_flags;
 }
 
 static void
@@ -253,8 +252,8 @@ nouveau_fbcon_accel_fini(struct drm_device *dev)
 	struct nouveau_fbdev *fbcon = drm->fbcon;
 	if (fbcon && drm->channel) {
 		console_lock();
-		if (fbcon->helper.fbdev)
-			fbcon->helper.fbdev->flags |= FBINFO_HWACCEL_DISABLED;
+		if (fbcon->helper.info)
+			fbcon->helper.info->flags |= FBINFO_HWACCEL_DISABLED;
 		console_unlock();
 		nouveau_channel_idle(drm->channel);
 		nvif_object_dtor(&fbcon->twod);
@@ -272,7 +271,7 @@ nouveau_fbcon_accel_init(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
 	struct nouveau_fbdev *fbcon = drm->fbcon;
-	struct fb_info *info = fbcon->helper.fbdev;
+	struct fb_info *info = fbcon->helper.info;
 	int ret;
 
 	if (drm->client.device.info.family < NV_DEVICE_INFO_V0_TESLA)
@@ -290,7 +289,7 @@ nouveau_fbcon_accel_init(struct drm_device *dev)
 static void
 nouveau_fbcon_zfill(struct drm_device *dev, struct nouveau_fbdev *fbcon)
 {
-	struct fb_info *info = fbcon->helper.fbdev;
+	struct fb_info *info = fbcon->helper.info;
 	struct fb_fillrect rect;
 
 	/* Clear the entire fbcon.  The drm will program every connector
@@ -586,8 +585,8 @@ nouveau_fbcon_init(struct drm_device *dev)
 	if (ret)
 		goto fini;
 
-	if (fbcon->helper.fbdev)
-		fbcon->helper.fbdev->pixmap.buf_align = 4;
+	if (fbcon->helper.info)
+		fbcon->helper.info->pixmap.buf_align = 4;
 	return 0;
 
 fini:
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index ed67dd25794c8..92d505be53e06 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -38,7 +38,7 @@ static struct drm_fb_helper *get_fb(struct fb_info *fbi);
 static void pan_worker(struct work_struct *work)
 {
 	struct omap_fbdev *fbdev = container_of(work, struct omap_fbdev, work);
-	struct fb_info *fbi = fbdev->base.fbdev;
+	struct fb_info *fbi = fbdev->base.info;
 	int npages;
 
 	/* DMM roll shifts in 4K pages: */
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index bce71c0ccc9ef..6fe24535d0e43 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -261,7 +261,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 
 	fb = fbdev->fb;
 	helper->fb = fb;
-	helper->fbdev = info;
+	helper->info = info;
 
 	info->fbops = &tegra_fb_ops;
 
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index e923089522896..d83e2d8e92eb9 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -96,7 +96,7 @@ struct drm_fb_helper_funcs {
  * @fb: Scanout framebuffer object
  * @dev: DRM device
  * @funcs: driver callbacks for fb helper
- * @fbdev: emulated fbdev device info struct
+ * @info: emulated fbdev device info struct
  * @pseudo_palette: fake palette of 16 colors
  * @damage_clip: clip rectangle used with deferred_io to accumulate damage to
  *                the screen buffer
@@ -127,7 +127,7 @@ struct drm_fb_helper {
 	struct drm_framebuffer *fb;
 	struct drm_device *dev;
 	const struct drm_fb_helper_funcs *funcs;
-	struct fb_info *fbdev;
+	struct fb_info *info;
 	u32 pseudo_palette[17];
 	struct drm_clip_rect damage_clip;
 	spinlock_t damage_lock;
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:25:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428935.679690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvZs-0005vo-Rm; Mon, 24 Oct 2022 11:25:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428935.679690; Mon, 24 Oct 2022 11:25:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvZs-0005vh-OY; Mon, 24 Oct 2022 11:25:08 +0000
Received: by outflank-mailman (input) for mailman id 428935;
 Mon, 24 Oct 2022 11:25:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV4-00036S-LC
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:10 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d0a00ad8-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:07 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4C77922168;
 Mon, 24 Oct 2022 11:20:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9AC913357;
 Mon, 24 Oct 2022 11:20:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cKFYLOZ0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0a00ad8-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610407; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=w964RYRLg+qwnS/g6KVEEcEwa/6mstU5PwBtTCJBPk8=;
	b=zTrP7NDVJUQ0MdUMGFAU2nz8/UPcAsrFx6r4+K5C+zW28q8W0cy+c6EbqBMHAkSX0FMYZQ
	pM9uFmNGTzr2AZzEy7yJvmTVlEjETGIxmhjjKXtKQIz8pswHVBE6WkBfHJusPsGj+L3gpa
	BLLxoe/q3QCyevKvxgQc5OuyEoFIGjU=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610407;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=w964RYRLg+qwnS/g6KVEEcEwa/6mstU5PwBtTCJBPk8=;
	b=jHzgZhQ3P33R3No3y1jsyQCfALIvmkXfFKe9/YojJYrYukG7p6CQ6isywIZMj6FaW2zvyL
	65qQ+fT8fnD+O6DQ==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation
Date: Mon, 24 Oct 2022 13:19:49 +0200
Message-Id: <20221024111953.24307-18-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Implement the fbdev's read/write helpers with the same functions. Use
the generic fbdev's code as template. Convert all drivers.

DRM's fb helpers must implement regular I/O functionality in struct
fb_ops and possibly perform a damage update. Handle all this in the
same functions and convert drivers. The functionality has been used
as part of the generic fbdev code for some time. The drivers don't
set struct drm_fb_helper.fb_dirty, so they will not be affected by
damage handling.

For I/O memory, fb helpers now provide drm_fb_helper_cfb_read() and
drm_fb_helper_cfb_write(). Several drivers require these. Until now
tegra used I/O read and write, although the memory buffer appears to
be in system memory. So use _sys_ helpers now.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      |   2 +
 drivers/gpu/drm/drm_fb_helper.c            | 383 ++++++++++++---------
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |   2 +
 drivers/gpu/drm/gma500/framebuffer.c       |   2 +
 drivers/gpu/drm/i915/display/intel_fbdev.c |   2 +
 drivers/gpu/drm/radeon/radeon_fb.c         |   2 +
 drivers/gpu/drm/tegra/fb.c                 |   2 +
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c         |   3 +
 include/drm/drm_fb_helper.h                |  17 +
 9 files changed, 257 insertions(+), 158 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index f02f6a5ba8320..584cee123bd8e 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -19,6 +19,8 @@
 static const struct fb_ops armada_fb_ops = {
 	.owner		= THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
+	.fb_read	= drm_fb_helper_cfb_read,
+	.fb_write	= drm_fb_helper_cfb_write,
 	.fb_fillrect	= drm_fb_helper_cfb_fillrect,
 	.fb_copyarea	= drm_fb_helper_cfb_copyarea,
 	.fb_imageblit	= drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 379e0d2f67198..836523aef6a27 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -747,30 +747,132 @@ void drm_fb_helper_deferred_io(struct fb_info *info, struct list_head *pagerefli
 }
 EXPORT_SYMBOL(drm_fb_helper_deferred_io);
 
+typedef ssize_t (*drm_fb_helper_read_screen)(struct fb_info *info, char __user *buf,
+					     size_t count, loff_t pos);
+
+static ssize_t __drm_fb_helper_read(struct fb_info *info, char __user *buf, size_t count,
+				    loff_t *ppos, drm_fb_helper_read_screen read_screen)
+{
+	loff_t pos = *ppos;
+	size_t total_size;
+	ssize_t ret;
+
+	if (info->screen_size)
+		total_size = info->screen_size;
+	else
+		total_size = info->fix.smem_len;
+
+	if (pos >= total_size)
+		return 0;
+	if (count >= total_size)
+		count = total_size;
+	if (total_size - count < pos)
+		count = total_size - pos;
+
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
+	ret = read_screen(info, buf, count, pos);
+	if (ret > 0)
+		*ppos += ret;
+
+	return ret;
+}
+
+typedef ssize_t (*drm_fb_helper_write_screen)(struct fb_info *info, const char __user *buf,
+					      size_t count, loff_t pos);
+
+static ssize_t __drm_fb_helper_write(struct fb_info *info, const char __user *buf, size_t count,
+				     loff_t *ppos, drm_fb_helper_write_screen write_screen)
+{
+	loff_t pos = *ppos;
+	size_t total_size;
+	ssize_t ret;
+	int err = 0;
+
+	if (info->screen_size)
+		total_size = info->screen_size;
+	else
+		total_size = info->fix.smem_len;
+
+	if (pos > total_size)
+		return -EFBIG;
+	if (count > total_size) {
+		err = -EFBIG;
+		count = total_size;
+	}
+	if (total_size - count < pos) {
+		if (!err)
+			err = -ENOSPC;
+		count = total_size - pos;
+	}
+
+	if (info->fbops->fb_sync)
+		info->fbops->fb_sync(info);
+
+	/*
+	 * Copy to framebuffer even if we already logged an error. Emulates
+	 * the behavior of the original fbdev implementation.
+	 */
+	ret = write_screen(info, buf, count, pos);
+	if (ret < 0)
+		return ret; /* return last error, if any */
+	else if (!ret)
+		return err; /* return previous error, if any */
+
+	*ppos += ret;
+
+	return ret;
+}
+
+static ssize_t drm_fb_helper_read_screen_buffer(struct fb_info *info, char __user *buf,
+						size_t count, loff_t pos)
+{
+	const char *src = info->screen_buffer + pos;
+
+	if (copy_to_user(buf, src, count))
+		return -EFAULT;
+
+	return count;
+}
+
 /**
- * drm_fb_helper_sys_read - wrapper around fb_sys_read
+ * drm_fb_helper_sys_read - Implements struct &fb_ops.fb_read for system memory
  * @info: fb_info struct pointer
  * @buf: userspace buffer to read from framebuffer memory
  * @count: number of bytes to read from framebuffer memory
  * @ppos: read offset within framebuffer memory
  *
- * A wrapper around fb_sys_read implemented by fbdev core
+ * Returns:
+ * The number of read bytes on success, or an error code otherwise.
  */
 ssize_t drm_fb_helper_sys_read(struct fb_info *info, char __user *buf,
 			       size_t count, loff_t *ppos)
 {
-	return fb_sys_read(info, buf, count, ppos);
+	return __drm_fb_helper_read(info, buf, count, ppos, drm_fb_helper_read_screen_buffer);
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_read);
 
+static ssize_t drm_fb_helper_write_screen_buffer(struct fb_info *info, const char __user *buf,
+						 size_t count, loff_t pos)
+{
+	char *dst = info->screen_buffer + pos;
+
+	if (copy_from_user(dst, buf, count))
+		return -EFAULT;
+
+	return count;
+}
+
 /**
- * drm_fb_helper_sys_write - wrapper around fb_sys_write
+ * drm_fb_helper_sys_write - Implements struct &fb_ops.fb_write for system memory
  * @info: fb_info struct pointer
  * @buf: userspace buffer to write to framebuffer memory
  * @count: number of bytes to write to framebuffer memory
  * @ppos: write offset within framebuffer memory
  *
- * A wrapper around fb_sys_write implemented by fbdev core
+ * Returns:
+ * The number of written bytes on success, or an error code otherwise.
  */
 ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 				size_t count, loff_t *ppos)
@@ -779,7 +881,7 @@ ssize_t drm_fb_helper_sys_write(struct fb_info *info, const char __user *buf,
 	ssize_t ret;
 	struct drm_rect damage_area;
 
-	ret = fb_sys_write(info, buf, count, ppos);
+	ret = __drm_fb_helper_write(info, buf, count, ppos, drm_fb_helper_write_screen_buffer);
 	if (ret <= 0)
 		return ret;
 
@@ -837,6 +939,119 @@ void drm_fb_helper_sys_imageblit(struct fb_info *info,
 }
 EXPORT_SYMBOL(drm_fb_helper_sys_imageblit);
 
+static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count,
+				   loff_t pos)
+{
+	const char __iomem *src = info->screen_base + pos;
+	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
+	ssize_t ret = 0;
+	int err = 0;
+	char *tmp;
+
+	tmp = kmalloc(alloc_size, GFP_KERNEL);
+	if (!tmp)
+		return -ENOMEM;
+
+	while (count) {
+		size_t c = min_t(size_t, count, alloc_size);
+
+		memcpy_fromio(tmp, src, c);
+		if (copy_to_user(buf, tmp, c)) {
+			err = -EFAULT;
+			break;
+		}
+
+		src += c;
+		buf += c;
+		ret += c;
+		count -= c;
+	}
+
+	kfree(tmp);
+
+	return ret ? ret : err;
+}
+
+/**
+ * drm_fb_helper_cfb_read - Implements struct &fb_ops.fb_read for I/O memory
+ * @info: fb_info struct pointer
+ * @buf: userspace buffer to read from framebuffer memory
+ * @count: number of bytes to read from framebuffer memory
+ * @ppos: read offset within framebuffer memory
+ *
+ * Returns:
+ * The number of read bytes on success, or an error code otherwise.
+ */
+ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf,
+			       size_t count, loff_t *ppos)
+{
+	return __drm_fb_helper_read(info, buf, count, ppos, fb_read_screen_base);
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_read);
+
+static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count,
+				    loff_t pos)
+{
+	char __iomem *dst = info->screen_base + pos;
+	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
+	ssize_t ret = 0;
+	int err = 0;
+	u8 *tmp;
+
+	tmp = kmalloc(alloc_size, GFP_KERNEL);
+	if (!tmp)
+		return -ENOMEM;
+
+	while (count) {
+		size_t c = min_t(size_t, count, alloc_size);
+
+		if (copy_from_user(tmp, buf, c)) {
+			err = -EFAULT;
+			break;
+		}
+		memcpy_toio(dst, tmp, c);
+
+		dst += c;
+		buf += c;
+		ret += c;
+		count -= c;
+	}
+
+	kfree(tmp);
+
+	return ret ? ret : err;
+}
+
+/**
+ * drm_fb_helper_cfb_write - Implements struct &fb_ops.fb_write for I/O memory
+ * @info: fb_info struct pointer
+ * @buf: userspace buffer to write to framebuffer memory
+ * @count: number of bytes to write to framebuffer memory
+ * @ppos: write offset within framebuffer memory
+ *
+ * Returns:
+ * The number of written bytes on success, or an error code otherwise.
+ */
+ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
+				size_t count, loff_t *ppos)
+{
+	loff_t pos = *ppos;
+	ssize_t ret;
+	struct drm_rect damage_area;
+
+	ret = __drm_fb_helper_write(info, buf, count, ppos, fb_write_screen_base);
+	if (ret <= 0)
+		return ret;
+
+	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
+	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
+			     drm_rect_width(&damage_area),
+			     drm_rect_height(&damage_area));
+
+	return ret;
+}
+EXPORT_SYMBOL(drm_fb_helper_cfb_write);
+
 /**
  * drm_fb_helper_cfb_fillrect - wrapper around cfb_fillrect
  * @info: fbdev registered by the helper
@@ -2183,176 +2398,28 @@ static bool drm_fbdev_use_iomem(struct fb_info *info)
 	return !drm_fbdev_use_shadow_fb(fb_helper) && buffer->map.is_iomem;
 }
 
-static ssize_t fb_read_screen_base(struct fb_info *info, char __user *buf, size_t count,
-				   loff_t pos)
-{
-	const char __iomem *src = info->screen_base + pos;
-	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
-	ssize_t ret = 0;
-	int err = 0;
-	char *tmp;
-
-	tmp = kmalloc(alloc_size, GFP_KERNEL);
-	if (!tmp)
-		return -ENOMEM;
-
-	while (count) {
-		size_t c = min_t(size_t, count, alloc_size);
-
-		memcpy_fromio(tmp, src, c);
-		if (copy_to_user(buf, tmp, c)) {
-			err = -EFAULT;
-			break;
-		}
-
-		src += c;
-		buf += c;
-		ret += c;
-		count -= c;
-	}
-
-	kfree(tmp);
-
-	return ret ? ret : err;
-}
-
-static ssize_t fb_read_screen_buffer(struct fb_info *info, char __user *buf, size_t count,
-				     loff_t pos)
-{
-	const char *src = info->screen_buffer + pos;
-
-	if (copy_to_user(buf, src, count))
-		return -EFAULT;
-
-	return count;
-}
-
 static ssize_t drm_fbdev_fb_read(struct fb_info *info, char __user *buf,
 				 size_t count, loff_t *ppos)
 {
-	loff_t pos = *ppos;
-	size_t total_size;
 	ssize_t ret;
 
-	if (info->screen_size)
-		total_size = info->screen_size;
-	else
-		total_size = info->fix.smem_len;
-
-	if (pos >= total_size)
-		return 0;
-	if (count >= total_size)
-		count = total_size;
-	if (total_size - count < pos)
-		count = total_size - pos;
-
-	if (info->fbops->fb_sync)
-		info->fbops->fb_sync(info);
-
 	if (drm_fbdev_use_iomem(info))
-		ret = fb_read_screen_base(info, buf, count, pos);
+		ret = drm_fb_helper_cfb_read(info, buf, count, ppos);
 	else
-		ret = fb_read_screen_buffer(info, buf, count, pos);
-
-	if (ret > 0)
-		*ppos += ret;
+		ret = drm_fb_helper_sys_read(info, buf, count, ppos);
 
 	return ret;
 }
 
-static ssize_t fb_write_screen_base(struct fb_info *info, const char __user *buf, size_t count,
-				    loff_t pos)
-{
-	char __iomem *dst = info->screen_base + pos;
-	size_t alloc_size = min_t(size_t, count, PAGE_SIZE);
-	ssize_t ret = 0;
-	int err = 0;
-	u8 *tmp;
-
-	tmp = kmalloc(alloc_size, GFP_KERNEL);
-	if (!tmp)
-		return -ENOMEM;
-
-	while (count) {
-		size_t c = min_t(size_t, count, alloc_size);
-
-		if (copy_from_user(tmp, buf, c)) {
-			err = -EFAULT;
-			break;
-		}
-		memcpy_toio(dst, tmp, c);
-
-		dst += c;
-		buf += c;
-		ret += c;
-		count -= c;
-	}
-
-	kfree(tmp);
-
-	return ret ? ret : err;
-}
-
-static ssize_t fb_write_screen_buffer(struct fb_info *info, const char __user *buf, size_t count,
-				      loff_t pos)
-{
-	char *dst = info->screen_buffer + pos;
-
-	if (copy_from_user(dst, buf, count))
-		return -EFAULT;
-
-	return count;
-}
-
 static ssize_t drm_fbdev_fb_write(struct fb_info *info, const char __user *buf,
 				  size_t count, loff_t *ppos)
 {
-	loff_t pos = *ppos;
-	size_t total_size;
 	ssize_t ret;
-	struct drm_rect damage_area;
-	int err = 0;
 
-	if (info->screen_size)
-		total_size = info->screen_size;
-	else
-		total_size = info->fix.smem_len;
-
-	if (pos > total_size)
-		return -EFBIG;
-	if (count > total_size) {
-		err = -EFBIG;
-		count = total_size;
-	}
-	if (total_size - count < pos) {
-		if (!err)
-			err = -ENOSPC;
-		count = total_size - pos;
-	}
-
-	if (info->fbops->fb_sync)
-		info->fbops->fb_sync(info);
-
-	/*
-	 * Copy to framebuffer even if we already logged an error. Emulates
-	 * the behavior of the original fbdev implementation.
-	 */
 	if (drm_fbdev_use_iomem(info))
-		ret = fb_write_screen_base(info, buf, count, pos);
+		ret = drm_fb_helper_cfb_write(info, buf, count, ppos);
 	else
-		ret = fb_write_screen_buffer(info, buf, count, pos);
-
-	if (ret < 0)
-		return ret; /* return last error, if any */
-	else if (!ret)
-		return err; /* return previous error, if any */
-
-	*ppos += ret;
-
-	drm_fb_helper_memory_range_to_clip(info, pos, ret, &damage_area);
-	drm_fb_helper_damage(info, damage_area.x1, damage_area.y1,
-			     drm_rect_width(&damage_area),
-			     drm_rect_height(&damage_area));
+		ret = drm_fb_helper_sys_write(info, buf, count, ppos);
 
 	return ret;
 }
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 86c489d945849..55c92372fca04 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -49,6 +49,8 @@ static const struct fb_ops exynos_drm_fb_ops = {
 	.owner		= THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_mmap        = exynos_drm_fb_mmap,
+	.fb_read	= drm_fb_helper_cfb_read,
+	.fb_write	= drm_fb_helper_cfb_write,
 	.fb_fillrect	= drm_fb_helper_cfb_fillrect,
 	.fb_copyarea	= drm_fb_helper_cfb_copyarea,
 	.fb_imageblit	= drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index 6098d936e44b6..8d5a37b8f1100 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -147,6 +147,8 @@ static const struct fb_ops psbfb_unaccel_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_setcolreg = psbfb_setcolreg,
+	.fb_read = drm_fb_helper_cfb_read,
+	.fb_write = drm_fb_helper_cfb_write,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 1b576c859837b..5575d7abdc092 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -124,6 +124,8 @@ static const struct fb_ops intelfb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_set_par = intel_fbdev_set_par,
+	.fb_read = drm_fb_helper_cfb_read,
+	.fb_write = drm_fb_helper_cfb_write,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index f06fed2030a89..c1710ed1cab83 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -80,6 +80,8 @@ static const struct fb_ops radeonfb_ops = {
 	DRM_FB_HELPER_DEFAULT_OPS,
 	.fb_open = radeonfb_open,
 	.fb_release = radeonfb_release,
+	.fb_read = drm_fb_helper_cfb_read,
+	.fb_write = drm_fb_helper_cfb_write,
 	.fb_fillrect = drm_fb_helper_cfb_fillrect,
 	.fb_copyarea = drm_fb_helper_cfb_copyarea,
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 84b7f1dd9fb57..a900300ae5bdc 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -206,6 +206,8 @@ static int tegra_fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 static const struct fb_ops tegra_fb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
+	.fb_read = drm_fb_helper_sys_read,
+	.fb_write = drm_fb_helper_sys_write,
 	.fb_fillrect = drm_fb_helper_sys_fillrect,
 	.fb_copyarea = drm_fb_helper_sys_copyarea,
 	.fb_imageblit = drm_fb_helper_sys_imageblit,
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
index 5b85b477e4c69..0f2e3e6e97864 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
@@ -29,6 +29,7 @@
 #include <linux/fb.h>
 #include <linux/pci.h>
 
+#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/ttm/ttm_placement.h>
 
@@ -611,6 +612,8 @@ static int vmw_fb_set_par(struct fb_info *info)
 
 static const struct fb_ops vmw_fb_ops = {
 	.owner = THIS_MODULE,
+	.fb_read = drm_fb_helper_sys_read,
+	.fb_write = drm_fb_helper_sys_write,
 	.fb_check_var = vmw_fb_check_var,
 	.fb_set_par = vmw_fb_set_par,
 	.fb_setcolreg = vmw_fb_setcolreg,
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 3d7a3d68dab8a..6581183618b89 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -257,6 +257,11 @@ void drm_fb_helper_sys_copyarea(struct fb_info *info,
 void drm_fb_helper_sys_imageblit(struct fb_info *info,
 				 const struct fb_image *image);
 
+ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf,
+			       size_t count, loff_t *ppos);
+ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
+				size_t count, loff_t *ppos);
+
 void drm_fb_helper_cfb_fillrect(struct fb_info *info,
 				const struct fb_fillrect *rect);
 void drm_fb_helper_cfb_copyarea(struct fb_info *info,
@@ -402,6 +407,18 @@ static inline void drm_fb_helper_sys_imageblit(struct fb_info *info,
 {
 }
 
+static inline ssize_t drm_fb_helper_cfb_read(struct fb_info *info, char __user *buf,
+					     size_t count, loff_t *ppos)
+{
+	return -ENODEV;
+}
+
+static inline ssize_t drm_fb_helper_cfb_write(struct fb_info *info, const char __user *buf,
+					      size_t count, loff_t *ppos)
+{
+	return -ENODEV;
+}
+
 static inline void drm_fb_helper_cfb_fillrect(struct fb_info *info,
 					      const struct fb_fillrect *rect)
 {
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:25:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:25:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428979.679712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvaQ-00076w-L7; Mon, 24 Oct 2022 11:25:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428979.679712; Mon, 24 Oct 2022 11:25:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvaQ-00076n-IE; Mon, 24 Oct 2022 11:25:42 +0000
Received: by outflank-mailman (input) for mailman id 428979;
 Mon, 24 Oct 2022 11:25:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV3-00036S-L4
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:09 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cffa41a3-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:06 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3182E21EEB;
 Mon, 24 Oct 2022 11:20:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF83613357;
 Mon, 24 Oct 2022 11:20:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0HEWKuV0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cffa41a3-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WYaJhA1ZHtKKCWMYOS0WRaraoDBAxhkucQ5O+wo9aPw=;
	b=0+Tl2DefcQaIYDUcMpFES9rEJY2u7yBZpXAmi4fc375AoTyYVR/7WgMN8VQcSxOqKlWIKs
	3CFjEDVT+j637v/7vkplfyZa83e9w+O0jNGK/Xta2v8V3bn8X8OrO3xpgz/NyJRhZYttrM
	A+NB3uy7keMR+cfMtO7CanoIfLgx6lY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610406;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WYaJhA1ZHtKKCWMYOS0WRaraoDBAxhkucQ5O+wo9aPw=;
	b=ZR2qVGoni5VWvUoz6IrDdy2Kg/Ns+PUOtWkhqAoYhpZ2d6bonEJBKMBrVKoHqwVyfZfnZ4
	dgC584T7huNIz1Aw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic
Date: Mon, 24 Oct 2022 13:19:47 +0200
Message-Id: <20221024111953.24307-16-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The fbdev helpers implement a damage worker that forwards fbdev
updates to the DRM driver. The worker's update logic depends on
the generic fbdev emulation. Separate the two via function pointer.

The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty,
a new callback that hides the update logic from the damage worker.
It's not possible to use the generic logic with other fbdev emulation,
because it contains additional code for the shadow buffering that
the generic emulation employs.

DRM drivers with internal fbdev emulation can set fb_dirty to their
own implementation if they require damage handling; although no such
drivers currently exist.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 75 ++++++++++++++++++++-------------
 include/drm/drm_fb_helper.h     | 15 +++++++
 2 files changed, 61 insertions(+), 29 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index bfbb2af144060..f6d22cc4cd876 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -448,35 +448,24 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper,
 
 static void drm_fb_helper_damage_work(struct work_struct *work)
 {
-	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper,
-						    damage_work);
-	struct drm_device *dev = helper->dev;
+	struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work);
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	struct drm_clip_rect clip_copy;
 	unsigned long flags;
 	int ret;
 
+	if (!helper->funcs->fb_dirty)
+		return;
+
 	spin_lock_irqsave(&helper->damage_lock, flags);
 	clip_copy = *clip;
 	clip->x1 = clip->y1 = ~0;
 	clip->x2 = clip->y2 = 0;
 	spin_unlock_irqrestore(&helper->damage_lock, flags);
 
-	/* Call damage handlers only if necessary */
-	if (!(clip_copy.x1 < clip_copy.x2 && clip_copy.y1 < clip_copy.y2))
-		return;
-
-	if (helper->buffer) {
-		ret = drm_fb_helper_damage_blit(helper, &clip_copy);
-		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
-			goto err;
-	}
-
-	if (helper->fb->funcs->dirty) {
-		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1);
-		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
-			goto err;
-	}
+	ret = helper->funcs->fb_dirty(helper, &clip_copy);
+	if (ret)
+		goto err;
 
 	return;
 
@@ -670,16 +659,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
 }
 EXPORT_SYMBOL(drm_fb_helper_fini);
 
-static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
-{
-	struct drm_device *dev = fb_helper->dev;
-	struct drm_framebuffer *fb = fb_helper->fb;
-
-	return dev->mode_config.prefer_shadow_fbdev ||
-	       dev->mode_config.prefer_shadow ||
-	       fb->funcs->dirty;
-}
-
 static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y,
 				 u32 width, u32 height)
 {
@@ -687,7 +666,7 @@ static void drm_fb_helper_damage(struct fb_info *info, u32 x, u32 y,
 	struct drm_clip_rect *clip = &helper->damage_clip;
 	unsigned long flags;
 
-	if (!drm_fbdev_use_shadow_fb(helper))
+	if (!helper->funcs->fb_dirty)
 		return;
 
 	spin_lock_irqsave(&helper->damage_lock, flags);
@@ -2111,6 +2090,16 @@ void drm_fb_helper_output_poll_changed(struct drm_device *dev)
 }
 EXPORT_SYMBOL(drm_fb_helper_output_poll_changed);
 
+static bool drm_fbdev_use_shadow_fb(struct drm_fb_helper *fb_helper)
+{
+	struct drm_device *dev = fb_helper->dev;
+	struct drm_framebuffer *fb = fb_helper->fb;
+
+	return dev->mode_config.prefer_shadow_fbdev ||
+	       dev->mode_config.prefer_shadow ||
+	       fb->funcs->dirty;
+}
+
 /* @user: 1=userspace, 0=fbcon */
 static int drm_fbdev_fb_open(struct fb_info *info, int user)
 {
@@ -2487,8 +2476,36 @@ static int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper,
 	return 0;
 }
 
+static int drm_fbdev_fb_dirty(struct drm_fb_helper *helper, struct drm_clip_rect *clip)
+{
+	struct drm_device *dev = helper->dev;
+	int ret;
+
+	if (!drm_fbdev_use_shadow_fb(helper))
+		return 0;
+
+	/* Call damage handlers only if necessary */
+	if (!(clip->x1 < clip->x2 && clip->y1 < clip->y2))
+		return 0;
+
+	if (helper->buffer) {
+		ret = drm_fb_helper_damage_blit(helper, clip);
+		if (drm_WARN_ONCE(dev, ret, "Damage blitter failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	if (helper->fb->funcs->dirty) {
+		ret = helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, clip, 1);
+		if (drm_WARN_ONCE(dev, ret, "Dirty helper failed: ret=%d\n", ret))
+			return ret;
+	}
+
+	return 0;
+}
+
 static const struct drm_fb_helper_funcs drm_fb_helper_generic_funcs = {
 	.fb_probe = drm_fb_helper_generic_probe,
+	.fb_dirty = drm_fbdev_fb_dirty,
 };
 
 static void drm_fbdev_client_unregister(struct drm_client_dev *client)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index edc697a2fde24..3d7a3d68dab8a 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -30,6 +30,7 @@
 #ifndef DRM_FB_HELPER_H
 #define DRM_FB_HELPER_H
 
+struct drm_clip_rect;
 struct drm_fb_helper;
 
 #include <linux/fb.h>
@@ -89,6 +90,20 @@ struct drm_fb_helper_funcs {
 	 */
 	int (*fb_probe)(struct drm_fb_helper *helper,
 			struct drm_fb_helper_surface_size *sizes);
+
+	/**
+	 * @fb_dirty:
+	 *
+	 * Driver callback to update the framebuffer memory. If set, fbdev
+	 * emulation will invoke this callback in regular intervals after
+	 * the framebuffer has been written.
+	 *
+	 * This callback is optional.
+	 *
+	 * Returns:
+	 * 0 on success, or an error code otherwise.
+	 */
+	int (*fb_dirty)(struct drm_fb_helper *helper, struct drm_clip_rect *clip);
 };
 
 /**
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:25:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:25:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428989.679724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvaa-0007Uw-0B; Mon, 24 Oct 2022 11:25:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428989.679724; Mon, 24 Oct 2022 11:25:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvaZ-0007Up-QL; Mon, 24 Oct 2022 11:25:51 +0000
Received: by outflank-mailman (input) for mailman id 428989;
 Mon, 24 Oct 2022 11:25:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV5-00036S-L5
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:11 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d17223f4-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:08 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id ABA7C22165;
 Mon, 24 Oct 2022 11:20:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 034EE13357;
 Mon, 24 Oct 2022 11:20:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8O1PO+d0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d17223f4-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RsAQdHzLmddns92tHuvM6Lu3vuWZMSsqH8X6KbiDvyM=;
	b=Kx1ESk/2KWWWJMh3Mri7dZecKO9mDXs/G5Kh0hAdewWvuLJo1pmQHD6rKx9LyO4DYlvE07
	UGREIOW+1c7j8jBFE461HY6tuNFiQnMEGgwugb6mTlj5JySyPdYx6wCGz/kRV3vA9LOEnU
	7GPrrBN1V+6dySJr6LCuxBMM9CtyYDY=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610408;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RsAQdHzLmddns92tHuvM6Lu3vuWZMSsqH8X6KbiDvyM=;
	b=I2Hs34Ejsna6X414YeSewXudyPLIgsJ7R9rpNpC8j9+h3eJE58RTZnzq5HJHAxqpk4Udik
	FqboT04ghHFQrhAA==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 19/21] drm/fb-helper: Always initialize generic fbdev emulation
Date: Mon, 24 Oct 2022 13:19:51 +0200
Message-Id: <20221024111953.24307-20-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Initialize the generic fbdev emulation even if it has been disabled
on the kernel command line. The hotplug and mode initialization will
fail accordingly.

The kernel parameter can still be changed at runtime and the emulation
will initialize after hotplugging the connector.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_fb_helper.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index fbc5c5445fdb0..d1afb420c6e06 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -526,11 +526,6 @@ int drm_fb_helper_init(struct drm_device *dev,
 {
 	int ret;
 
-	if (!drm_fbdev_emulation) {
-		dev->fb_helper = fb_helper;
-		return 0;
-	}
-
 	/*
 	 * If this is not the generic fbdev client, initialize a drm_client
 	 * without callbacks so we can use the modesets.
@@ -2716,9 +2711,6 @@ void drm_fbdev_generic_setup(struct drm_device *dev,
 	drm_WARN(dev, !dev->registered, "Device has not been registered.\n");
 	drm_WARN(dev, dev->fb_helper, "fb_helper is already set!\n");
 
-	if (!drm_fbdev_emulation)
-		return;
-
 	fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL);
 	if (!fb_helper) {
 		drm_err(dev, "Failed to allocate fb_helper\n");
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:25:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:25:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.428997.679734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvah-0007vo-5x; Mon, 24 Oct 2022 11:25:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 428997.679734; Mon, 24 Oct 2022 11:25:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvah-0007vf-2v; Mon, 24 Oct 2022 11:25:59 +0000
Received: by outflank-mailman (input) for mailman id 428997;
 Mon, 24 Oct 2022 11:25:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fxyk=2Z=suse.de=tzimmermann@srs-se1.protection.inumbo.net>)
 id 1omvV6-00036S-LB
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:20:12 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d25b6802-538d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:20:10 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 364C822169;
 Mon, 24 Oct 2022 11:20:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 866DC13357;
 Mon, 24 Oct 2022 11:20:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kK6cH+l0VmOYMgAAMHmgww
 (envelope-from <tzimmermann@suse.de>); Mon, 24 Oct 2022 11:20:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d25b6802-538d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1666610410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=s8EjyldAvzdOSExh8dLPvPye++M7XBzrxFcMIv6xfEg=;
	b=yXNK7WvqcfSZ73bIs91Y5i7Bf+/SN3NxlKz05cX26OSlw7GDaRM0CnD5Q8pdke1oaKAT3a
	733QKiclqV7+xhnQy1p/B6dwHMQEKlOE67NXCdjUVPQa5CG4yRbA8jQ51vzzhzFm87CwpA
	LRguV0fRfumlKaA25GcQYN5DK4EWF2k=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1666610410;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=s8EjyldAvzdOSExh8dLPvPye++M7XBzrxFcMIv6xfEg=;
	b=5iYW05vzugOpwdblq+hoaUUilaS6r1R4P1+qqdHtxMEn9I74hlGTuChnD/rLbuMU0RpEgw
	Smdzlcetm0TpzGCw==
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch,
	airlied@gmail.com,
	sam@ravnborg.org,
	javierm@redhat.com,
	mripard@kernel.org,
	maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org,
	linux-aspeed@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	etnaviv@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	linux-mips@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	nouveau@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev,
	linux-tegra@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 21/21] drm/fb-helper: Remove unnecessary include statements
Date: Mon, 24 Oct 2022 13:19:53 +0200
Message-Id: <20221024111953.24307-22-tzimmermann@suse.de>
X-Mailer: git-send-email 2.38.0
In-Reply-To: <20221024111953.24307-1-tzimmermann@suse.de>
References: <20221024111953.24307-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove include statements for <drm/drm_fb_helper.h> where it is not
required (i.e., most of them). In a few places include other header
files that are required by the source code.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c  | 1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c     | 1 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h        | 1 -
 drivers/gpu/drm/arm/hdlcd_crtc.c                | 1 -
 drivers/gpu/drm/ast/ast_drv.h                   | 1 -
 drivers/gpu/drm/bridge/tc358762.c               | 2 +-
 drivers/gpu/drm/drm_crtc_helper.c               | 1 -
 drivers/gpu/drm/drm_gem_framebuffer_helper.c    | 1 -
 drivers/gpu/drm/drm_probe_helper.c              | 1 -
 drivers/gpu/drm/etnaviv/etnaviv_drv.h           | 3 ++-
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 -
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c     | 1 -
 drivers/gpu/drm/imx/imx-ldb.c                   | 2 +-
 drivers/gpu/drm/imx/imx-tve.c                   | 1 -
 drivers/gpu/drm/imx/parallel-display.c          | 2 +-
 drivers/gpu/drm/kmb/kmb_plane.c                 | 1 -
 drivers/gpu/drm/mgag200/mgag200_drv.h           | 1 -
 drivers/gpu/drm/qxl/qxl_drv.h                   | 1 -
 drivers/gpu/drm/rockchip/rockchip_drm_drv.h     | 2 +-
 drivers/gpu/drm/tidss/tidss_kms.c               | 1 -
 drivers/gpu/drm/v3d/v3d_drv.c                   | 1 -
 drivers/gpu/drm/vboxvideo/vbox_main.c           | 1 -
 drivers/gpu/drm/virtio/virtgpu_drv.h            | 1 -
 drivers/gpu/drm/xen/xen_drm_front_gem.c         | 1 -
 24 files changed, 6 insertions(+), 24 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index 491d4846fc02c..e1320edfc5274 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -26,7 +26,6 @@
 
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/amdgpu_drm.h>
 #include "amdgpu.h"
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index dd6f9ae6fbe9f..b32b387599b5c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -40,7 +40,6 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_gem_framebuffer_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_vblank.h>
 
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
index 37322550d7508..8a39300b1a845 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
@@ -36,7 +36,6 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_fixed.h>
 #include <drm/drm_crtc_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_probe_helper.h>
 #include <linux/i2c.h>
diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
index 7030339fa2323..ddbe1dd2d44ef 100644
--- a/drivers/gpu/drm/arm/hdlcd_crtc.c
+++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
@@ -19,7 +19,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_of.h>
diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h
index 74f41282444f6..d51b81fea9c80 100644
--- a/drivers/gpu/drm/ast/ast_drv.h
+++ b/drivers/gpu/drm/ast/ast_drv.h
@@ -38,7 +38,6 @@
 #include <drm/drm_encoder.h>
 #include <drm/drm_mode.h>
 #include <drm/drm_framebuffer.h>
-#include <drm/drm_fb_helper.h>
 
 #define DRIVER_AUTHOR		"Dave Airlie"
 
diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
index 7f4fce1aa9988..0b6a284368859 100644
--- a/drivers/gpu/drm/bridge/tc358762.c
+++ b/drivers/gpu/drm/bridge/tc358762.c
@@ -11,6 +11,7 @@
  */
 
 #include <linux/delay.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/of_graph.h>
 #include <linux/regulator/consumer.h>
@@ -19,7 +20,6 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index f5fb22e0d0337..a209659a996c7 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -43,7 +43,6 @@
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
index e35e224e6303a..e93533b86037f 100644
--- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
+++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
@@ -9,7 +9,6 @@
 #include <linux/module.h>
 
 #include <drm/drm_damage_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
index 69b0b2b9cc1c5..ef2b41b2eb7b8 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/drivers/gpu/drm/drm_probe_helper.c
@@ -36,7 +36,6 @@
 #include <drm/drm_client.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_print.h>
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index f32f4771dada7..2bb4c25565dcb 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -6,13 +6,14 @@
 #ifndef __ETNAVIV_DRV_H__
 #define __ETNAVIV_DRV_H__
 
+#include <linux/io.h>
 #include <linux/list.h>
 #include <linux/mm_types.h>
 #include <linux/sizes.h>
 #include <linux/time64.h>
 #include <linux/types.h>
 
-#include <drm/drm_fb_helper.h>
+#include <drm/drm_drv.h>
 #include <drm/drm_gem.h>
 #include <drm/etnaviv_drm.h>
 #include <drm/gpu_scheduler.h>
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
index 4a0cd22c10e21..f957552c6c507 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
@@ -19,7 +19,6 @@
 #include <linux/i2c.h>
 
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_framebuffer.h>
 
 struct hibmc_connector {
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
index 28e732f94bf2f..6c6b572987973 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
@@ -8,7 +8,6 @@
 #include <drm/drm_damage_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_format_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index 41799011f73b6..c45fc8f4744d0 100644
--- a/drivers/gpu/drm/imx/imx-ldb.c
+++ b/drivers/gpu/drm/imx/imx-ldb.c
@@ -7,6 +7,7 @@
 
 #include <linux/clk.h>
 #include <linux/component.h>
+#include <linux/i2c.h>
 #include <linux/media-bus-format.h>
 #include <linux/mfd/syscon.h>
 #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
@@ -23,7 +24,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index 6b34fac3f73a0..d64ebd2cf15e8 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -19,7 +19,6 @@
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_simple_kms_helper.h>
diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 06723b2e9b847..0fa0b590830b6 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -8,6 +8,7 @@
 #include <linux/component.h>
 #include <linux/media-bus-format.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/videodev2.h>
 
@@ -16,7 +17,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c
index a42f63f6f9573..d172a302f9024 100644
--- a/drivers/gpu/drm/kmb/kmb_plane.c
+++ b/drivers/gpu/drm/kmb/kmb_plane.c
@@ -9,7 +9,6 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_fb_dma_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem_dma_helper.h>
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.h b/drivers/gpu/drm/mgag200/mgag200_drv.h
index f0c2349404b46..9e604dbb8e448 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.h
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.h
@@ -18,7 +18,6 @@
 #include <drm/drm_connector.h>
 #include <drm/drm_crtc.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_gem_shmem_helper.h>
 #include <drm/drm_plane.h>
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 432758ad39a35..76f060810f634 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.h
+++ b/drivers/gpu/drm/qxl/qxl_drv.h
@@ -38,7 +38,6 @@
 
 #include <drm/drm_crtc.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_ttm_helper.h>
 #include <drm/drm_ioctl.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
index 1641440837af5..aeb03a57240fd 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h
@@ -9,10 +9,10 @@
 #ifndef _ROCKCHIP_DRM_DRV_H
 #define _ROCKCHIP_DRM_DRV_H
 
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_gem.h>
 
+#include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/component.h>
 
diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
index afb2879980c6c..345bcc3011e4f 100644
--- a/drivers/gpu/drm/tidss/tidss_kms.c
+++ b/drivers/gpu/drm/tidss/tidss_kms.c
@@ -10,7 +10,6 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_crtc_helper.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index e8c975b815859..478f1f0f60dec 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -22,7 +22,6 @@
 #include <linux/reset.h>
 
 #include <drm/drm_drv.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_managed.h>
 #include <uapi/drm/v3d_drm.h>
 
diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c
index c9e8b3a63c621..3b83e550f4df5 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_main.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_main.c
@@ -11,7 +11,6 @@
 #include <linux/pci.h>
 #include <linux/vbox_err.h>
 
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_damage_helper.h>
 
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h
index 9b98470593b06..b7a64c7dcc2c9 100644
--- a/drivers/gpu/drm/virtio/virtgpu_drv.h
+++ b/drivers/gpu/drm/virtio/virtgpu_drv.h
@@ -35,7 +35,6 @@
 #include <drm/drm_atomic.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_encoder.h>
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_framebuffer.h>
 #include <drm/drm_gem.h>
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index e31554d7139f1..4c95ebcdcc2d3 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -12,7 +12,6 @@
 #include <linux/scatterlist.h>
 #include <linux/shmem_fs.h>
 
-#include <drm/drm_fb_helper.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_prime.h>
 #include <drm/drm_probe_helper.h>
-- 
2.38.0



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:35:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:35:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429014.679745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvk1-0001bX-8J; Mon, 24 Oct 2022 11:35:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429014.679745; Mon, 24 Oct 2022 11:35:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvk1-0001bQ-4H; Mon, 24 Oct 2022 11:35:37 +0000
Received: by outflank-mailman (input) for mailman id 429014;
 Mon, 24 Oct 2022 11:35:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QvrT=2Z=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1omvjz-0001bF-O9
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:35:35 +0000
Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com
 [2a00:1450:4864:20::534])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9338446-538f-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:35:34 +0200 (CEST)
Received: by mail-ed1-x534.google.com with SMTP id m16so29939930edc.4
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 04:35:34 -0700 (PDT)
Received: from [192.168.1.93] (adsl-235.109.242.224.tellas.gr.
 [109.242.224.235]) by smtp.gmail.com with ESMTPSA id
 p6-20020a05640243c600b0045b4b67156fsm18307202edc.45.2022.10.24.04.35.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 24 Oct 2022 04:35:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9338446-538f-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=U0/xnVi7XSgR0494vg1vVMMuMGoGpBezzObnlHLZFRg=;
        b=lefRXcmT9E4U0tczUmleIthZ+WsAcoVrZh/KNdf+r6ZyuMSAAIseRPyFdR1GNwxO+S
         D3gue5ruOa+WPmcNpMavWeZQjO2U1wn/Xeb5+RhutPhC9WAF8DPLkvD7A4NDUQIszK+L
         ihqXmERU2HDB6fOzzw2jSEyX0eHdkx1TRJa9bx6isPwMnMZEdauOel7WT5AiO1+my3ls
         Q4SFwqotZzQhyPCmxNa/BlK/uBoomH7pjgO7KBq0CXp15kzMFvDTvztg6t5soGyH/f12
         mtOpIIMz1P48uNqZmaNQ5tYHUI+ZRmvPkgAaOx5th4Vg3t1LOc8NHOYagEuppLvkUoUK
         KieQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=U0/xnVi7XSgR0494vg1vVMMuMGoGpBezzObnlHLZFRg=;
        b=p3Ma6CUZi44kx8/NQOfJTJSvJZjBSLrpICHBEoAaUJF3appwltr8GcT8ouUcjGwwGb
         Y+CMixt11DCaspUtCbG00cVSAdSyjKsTcZ8jGeCoazXEgHZ05LWj4W9qV3x368DYUuVm
         abTuV1L6aDakJrvo+xkSp4eLIZVhKU25bzsKTj5IX1StasK9YsykGnrwk58b1Kbg686G
         aC8bkeaddyAnfyIhmChL/4Aoqo1GUJttlaLMsNJDMoQnlODfDxoUDDnh+2b9wkT/Zdox
         4W5Ot0yqjU3aQ4axDARhj2CkmjiofZlo/bHyH/T7tcgC9SCu/xrE4U2UvnOwtGb8A2g4
         otuA==
X-Gm-Message-State: ACrzQf1OLGOWxWZEWmNOTImBUQ7v8tzzahNWIPJd0jz02egvWvV/bW/a
	Q5dzQ/3qZqdEfQONbSgVSoc=
X-Google-Smtp-Source: AMsMyM6+C2Fv+w92c2oFiNyKqV5fvaty6weFFFxpUjwPuKCxTMhIDny0HgGsKDIXw5RRxNZCbuPYYw==
X-Received: by 2002:a17:907:2ceb:b0:78d:b765:c50d with SMTP id hz11-20020a1709072ceb00b0078db765c50dmr27049888ejc.73.1666611334022;
        Mon, 24 Oct 2022 04:35:34 -0700 (PDT)
Message-ID: <78306c56-7cdd-a705-f8af-0cae4e359336@gmail.com>
Date: Mon, 24 Oct 2022 14:35:31 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v1 02/12] Arm: GICv3: Move the macros to compute the
 affnity level to arm64/arm32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-3-ayankuma@amd.com>
 <cb67c768-1a05-e5d5-efed-9a282c6a8c2a@gmail.com>
 <e0183387-8556-5fcc-2f18-003832d5cd70@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <e0183387-8556-5fcc-2f18-003832d5cd70@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Ayan,

On 10/24/22 14:00, Ayan Kumar Halder wrote:
> 
> On 21/10/2022 22:18, Xenia Ragiadakou wrote:
>> On 10/21/22 18:31, Ayan Kumar Halder wrote:
>> Hi Ayan
> Hi Xenia,
>>
>>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
>>> include/asm/cputype.h#L14 , these macros are specific for arm64.
>>>
>>> When one computes MPIDR_LEVEL_SHIFT(3), it crosses the width of a 32
>>> bit register.
>>>
>>> Refer 
>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
>>> asm/cputype.h#L54  , these macros are specific for arm32.
>>>
>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>> ---
>>>   xen/arch/arm/include/asm/arm32/processor.h | 10 ++++++++++
>>>   xen/arch/arm/include/asm/arm64/processor.h | 13 +++++++++++++
>>>   xen/arch/arm/include/asm/processor.h       | 14 --------------
>>>   3 files changed, 23 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/include/asm/arm32/processor.h 
>>> b/xen/arch/arm/include/asm/arm32/processor.h
>>> index 4e679f3273..3e03ce78dc 100644
>>> --- a/xen/arch/arm/include/asm/arm32/processor.h
>>> +++ b/xen/arch/arm/include/asm/arm32/processor.h
>>> @@ -56,6 +56,16 @@ struct cpu_user_regs
>>>       uint32_t pad1; /* Doubleword-align the user half of the frame */
>>>   };
>>>   +/*
>>> + * Macros to extract affinity level. Picked from kernel
>>> + */
>>> +
>>> +#define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1)
>>> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
>>> +
>>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>> +    ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK)
>>> +

Above, since
#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
you can replace (MPIDR_LEVEL_BITS * level) with MPIDR_LEVEL_SHIFT(level) 
in the definition of MPIDR_AFFINITY_LEVEL.
You will see that it is identical to the arm64 definition
#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)

>>>   #endif
>>>     #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
>>> diff --git a/xen/arch/arm/include/asm/arm64/processor.h 
>>> b/xen/arch/arm/include/asm/arm64/processor.h
>>> index c749f80ad9..c026334eec 100644
>>> --- a/xen/arch/arm/include/asm/arm64/processor.h
>>> +++ b/xen/arch/arm/include/asm/arm64/processor.h
>>> @@ -84,6 +84,19 @@ struct cpu_user_regs
>>>       uint64_t sp_el1, elr_el1;
>>>   };
>>>   +/*
>>> + * Macros to extract affinity level. picked from kernel
>>> + */
>>> +
>>> +#define MPIDR_LEVEL_BITS_SHIFT  3
>>> +#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>>> +
>>> +#define MPIDR_LEVEL_SHIFT(level) \
>>> +         (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>> +
>>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>> +         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>>> +
>>>   #undef __DECL_REG
>>>     #endif /* __ASSEMBLY__ */
>>> diff --git a/xen/arch/arm/include/asm/processor.h 
>>> b/xen/arch/arm/include/asm/processor.h
>>> index 1dd81d7d52..7d90c3b5f2 100644
>>> --- a/xen/arch/arm/include/asm/processor.h
>>> +++ b/xen/arch/arm/include/asm/processor.h
>>> @@ -118,20 +118,6 @@
>>>   #define MPIDR_INVALID       (~MPIDR_HWID_MASK)
>>>   #define MPIDR_LEVEL_BITS    (8)
>>>   -
>>> -/*
>>> - * Macros to extract affinity level. picked from kernel
>>> - */
>>> -
>>> -#define MPIDR_LEVEL_BITS_SHIFT  3
>>> -#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>>> -
>>> -#define MPIDR_LEVEL_SHIFT(level) \
>>> -         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>> -
>>> -#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>> -         (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>>> -
>>>   #define AFFINITY_MASK(level)    ~((_AC(0x1,UL) << 
>>> MPIDR_LEVEL_SHIFT(level)) - 1)
>>>     /* TTBCR Translation Table Base Control Register */
>>
>> Since only the definition of the MPIDR_AFFINITY_LEVEL() differs, maybe 
>> you could add only this one to the arch specific headers e.g
>> for arm64:
>> #define MPIDR_LEVEL_SHIFT(level) \
>>     (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>> for arm32:
>> #define MPIDR_LEVEL_SHIFT(level) \
>>     ((level) << MPIDR_LEVEL_BITS_SHIFT)
> 
> Also, MPIDR_AFFINITY_LEVEL needs to be defined in arch specific headers 
> as it differs between arm32 and arm64.

As I point out above, there is no difference between arm32 and arm64 
regarding the definition of MPIDR_AFFINITY_LEVEL(level).

> 
> However, MPIDR_LEVEL_MASK can be defined in the common header (as it is 
> same for arm32 and arm64).
> 
> Please let me know if it makes sense.
> 
>>
>> But in any case don't forget to add parentheses around the macro 
>> parameters when an operator acts on them to avoid trouble with 
>> operator precedence (MISRA-C Rule 20.7 :))
> 
> Thanks for pointing it out. Yes, this is a mistake in my patches.
> 
> - Ayan
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:41:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:41:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429019.679755 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvpW-00030t-Rf; Mon, 24 Oct 2022 11:41:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429019.679755; Mon, 24 Oct 2022 11:41:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvpW-00030m-P0; Mon, 24 Oct 2022 11:41:18 +0000
Received: by outflank-mailman (input) for mailman id 429019;
 Mon, 24 Oct 2022 11:41:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tdD1=2Z=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1omvpV-00030g-BW
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:41:17 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2063.outbound.protection.outlook.com [40.107.243.63])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c38394ba-5390-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:41:15 +0200 (CEST)
Received: from DM6PR17CA0011.namprd17.prod.outlook.com (2603:10b6:5:1b3::24)
 by MW4PR12MB6804.namprd12.prod.outlook.com (2603:10b6:303:20d::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 11:41:12 +0000
Received: from DM6NAM11FT070.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:1b3:cafe::9) by DM6PR17CA0011.outlook.office365.com
 (2603:10b6:5:1b3::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend
 Transport; Mon, 24 Oct 2022 11:41:12 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT070.mail.protection.outlook.com (10.13.173.51) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 11:41:11 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 06:41:11 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 04:41:10 -0700
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 24 Oct 2022 06:41:09 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c38394ba-5390-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cICzWlT9frtiiDqDDXrLdoXt3YYU0+oyvhdlJXzb0R7BmdWekNdpKzNA3LLaB5CnSkLkLp4FgRAaSZ44pIFqf3EJNFcQI5PH0wwzbSnRR2Lc+hhxOYdNtgAO9ezpSbVSh5nhgP5bmv3a3vWz2cxxbWrGsjxO+31/+wTIi5IijbLJe4juddR3+SvMiuN8ihAi3MD069QPL11LVhPOO8Qzq1L1rtMbbVRlKFQrdwIoojP0zzwirBSmaS+aazla8Gu+JaAO9bipSEK2+16m3sFTsoqTzNXjTcV7uIsNk99uRveUCIn+4DhZ69XzzusfHn6h5GQLACa3URAaqRRAT9dgnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TAsp3WKl3ZQxOWYHdKdVtkrDHaMbbXOFBlB3D9HaMFE=;
 b=HGDHa9iEcXUmwWiPjW/Qq/XVfZdJnd1nvujbx2gWth+Dqo5Muif9jpJ3wWfQez+B1uQRoSwT86JObPgkrEz6tGSc4tCBuxB4i2ge79DLPgV/G2iqrd92+iMXi3VY3q8y9ckd+8vtfZScD4RCZ8qJKFN8auM0v4mo1bcRJPa5b1MuG0fJMvE174D29terrzDocD/DMAB6qcGY7haOiNIVUF1IKy/ZB+GPyj+wBqQ4joWw6maUwzlx3BhAa9GpkKHR4ApNipabPzdAvzuZgX+uRG0WENl7I+mso6tct/rjZ9KV4r3c7R3g1bkd1Jz7UsXmznYnjnvS1mGL8A1yte+SwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TAsp3WKl3ZQxOWYHdKdVtkrDHaMbbXOFBlB3D9HaMFE=;
 b=g3Mm2pSmrlse57waxbseCN8qar9yOA1BzJARc4CUqCVb7l3GEbKSZBf21FHbYoo3mOmfc+HHUbAGFaRIDyVF/S8C8UwxWPas67GvbhGrW4SuaKgC4KESTbOMrmi0yQgFzxY4tyotLvDbZj1wiuZIgpiqA6cDnNbk8ivnNRsP3Bk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
Date: Mon, 24 Oct 2022 13:41:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Deadcode discussion based on Arm NS phys timer
Content-Language: en-US
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT070:EE_|MW4PR12MB6804:EE_
X-MS-Office365-Filtering-Correlation-Id: 1be55aee-f60b-44c0-b131-08dab5b4a656
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PK+0RVKkLvsa9cTH2rkUakH5xP6Xg64qaV3EfJFqobqR2l2TkueYrIY9ifjRiF9cmyNmOV7U9QwoBwvJF3iiIbNxDR8p2pnO5AOpV1ZgFdU6pHuyPpNP4yVPHMhm7sgQz9q4reSWzRG00RXM38ZaxJ61ySh30ss5Fyfv/eIqWZXWZOJx2HctXFvI6acRzqtC5Fhy/XpG2cUBMzhHy0EnIAR+NGLbPclar4zqIxMoO2p+NkRMdifxikRCm9OXHjdynfmb7+Uny51hceG7B4AzBt0yvKr5OWXoaB2NqkM+4wytYqyQBUc2bZsq+k6cni3njdxuCg7SCsTJ3F4ISE81rLABGH8iRnCkvD7D3EwUTX74WTigffQMXeB7Ui0++WU3yUpI1m9P/MYUmTtnk1K4MiK/yES6/1lOFMR5JInmP1xS1BzKZ2tbKtjHwpfBOl/skFYfE6iqVr8xU4KOVAvwL0S//Ngb6gSCoo020JLw9z5CoJZT+FC9TZ1v4FI3bfoRNzpVaa4+pBCl4TmuEDCmoXxsDjoCHjkx5e0A1Ny9OLgMYiKdh9Gtr8Kynyvpt6Et8wLRYu70DNfAM20KxXxjGXFZtwz/XNhLKqGsK3HH4HDOSfvDy0PABSnrJkOjpWaCeHzEuPqdtOP0Bh7N0ABlgQT2mHC/NWT91Kt4NEFldCTKJbU7uaswZj1WdrqZHhUniyIs4hmdm1cxkYvCcsKqMkNsLe2fNOlDb+6usXblpcWdSNYc7yCzAU/TfLU07Rx8QV5cFJMmU/6CozAdG3exuL617Zy/P1rJi6dVCydhIVP7ih7yBsMBc4pqKbGlnq9XaoWE/4Cn+YtFBUEWHuNa9w==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(36756003)(31686004)(66899015)(36860700001)(86362001)(82740400003)(2906002)(44832011)(40460700003)(426003)(31696002)(336012)(2616005)(5660300002)(186003)(356005)(81166007)(83380400001)(47076005)(53546011)(26005)(316002)(16576012)(110136005)(54906003)(70586007)(70206006)(40480700001)(4326008)(8676002)(82310400005)(41300700001)(8936002)(478600001)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 11:41:11.5005
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1be55aee-f60b-44c0-b131-08dab5b4a656
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT070.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6804

Hi Julien,

On 24/10/2022 12:51, Julien Grall wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On 24/10/2022 10:07, Michal Orzel wrote:
>> Hello,
> 
> Hi Michal,
> 
>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly speaking, we are routing
>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use of it (as it uses the hypervisor timer CNTHP).
>> This timer is fully emulated, which means that there is nothing that can trigger such IRQ. This code is
>> a left over from early days, where the CNTHP was buggy on some models and we had to use the CNTP instead.
>>
>> As far as the problem itself is not really interesting, it raises a question of what to do with a deadcode,
>> as there might be/are other deadcode places in Xen.
> 
> There are multiple definition of deadcode. Depending on which one you
> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
> would result to a lot of places impacted with the decision.
> 
> So can you clarify what you mean by deadcode?
In the timer example, I think we have both a deadcode and unreachable code.
For the purpose of this discussion, let's take the MISRA definition of a deadcode which is a "code that can be executed
but has no effect on the functional behavior of the program". This differs from the unreachable code definition that is
a "code that cannot be executed". Setting up the IRQ for Xen is an example of a deadcode. Code within IRQ handler is an unreachable code
(there is nothing that can trigger this IRQ).

What I mean by deadcode happens to be the sum of the two cases above i.e. the code that cannot be executed as well as the code that
does not impact the functionality of the program.

> 
>> One may say that it is useful to keep it, because one day,
>> someone might need it when dealing with yet another broken HW. Such person would still need to modify the other
>> part of the code (e.g. reprogram_timer), but there would be less work required overall. Personally, I'm not in favor of
>> such approach, because we should not really support possible scenarios with broken HW (except for erratas listing known issues).
> 
> The difference between "broken HW" and "HW with known errata" is a bit
> unclear to me. Can you clarify how you would make the difference here?
> 
> In particular, at which point do you consider that the HW should not be
> supported by Xen?
I'm not saying that HW should not be supported. The difference for me between broken HW and
HW with known errata is that for the former, the incorrect behavior is often due to the early support stage,
using emulators/models instead of real HW, whereas for the latter, the HW is already released and it happens to be that it is buggy
(the HW vendor is aware of the issue and released erratas). Do we have any example in Xen for supporting broken HW,
whose vendor is not aware of the issue or did not release any errata?

> 
>> Also, as part of the certification/FUSA process, there should be no deadcode and we should have explanation for every block of code.
> 
> See above. What are you trying to cover by deadcode? Would protecting
> code with IS_ENABLED() (or #ifdef) ok?
I think this would be ok from the certification point of view (this would at least means, that we are aware of the issue
and we took some steps). Otherwise, such code is just an example of a deadcode/unreachable code.

> 
>>
>> There are different ways to deal with a deadcode: > 1. Get rid of it completely
>> 2. Leave it as it is
>> 3. Admit that it can be useful one day and:
>>    3.1. protect it with #if 0
>>    3.2. protect it with a new Kconfig option (disabled by default) using #ifdef
>>    3.3. protect it with a new Kconfig option (disabled by default) using IS_ENABLED (to make sure code always compile)
>>    3.4. protect it with a command line option (allowing to choose the timer to be used by Xen)
>> ...
>>
>> Let me know what you think.
> 
> Before answering the question, I would need some clarifications on your aim.
> 
> Cheers,
> 
> --
> Julien Grall

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:51:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:51:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429024.679767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvz5-0004Zz-PM; Mon, 24 Oct 2022 11:51:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429024.679767; Mon, 24 Oct 2022 11:51:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omvz5-0004Zs-Lb; Mon, 24 Oct 2022 11:51:11 +0000
Received: by outflank-mailman (input) for mailman id 429024;
 Mon, 24 Oct 2022 11:51:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omvz4-0004Zm-6s
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:51:10 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80053.outbound.protection.outlook.com [40.107.8.53])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2480c4fd-5392-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 13:51:06 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB9177.eurprd04.prod.outlook.com (2603:10a6:10:2f4::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 11:51:04 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 11:51:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2480c4fd-5392-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fI3JQ6fEKNRqtfrbCCDmppLbTBt+3UoK9FGxqC12yjRujP9qajeZzBVGbX6sgCFQ0GtNJ3XBvxfYE/WOqFqdMTE40fagLIjjM7dfyRQMe0Z9EPBOSXzQAMi1Zdaa+exrqngr41bM4YS/TZB4xZrc8QA7rDKpQOdH25Wq+lAKmpoApqnxAgMyw7sA542j9ntUnXGX0MiaMg90WnWOKI4ZWl6e7MZivWtjoA89uOYXu/4y3OIdQEf7n/F0wonb2l3DUMc86PS5ZZMf6SiJtROXPMsrUqNg06lZiAFotkJp1Snu2Dqy3+Vma4d57yALXW3/ZbumTrFpwSKLl+Nz+B6Xhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nsOO5qSa6P4tPxcKsTcuQ9ed9tIOZFLNAcr92Wgi71s=;
 b=HCYgwX8L7RP3OaZQvTl9c/rtkJtm7EoI0JEyFpRqF795B38YK+/IN8Dd3uJFdT8WMwNsD2rn9VfbZhZ/p9lHxCUWvZ9AbzeapXnkljscSjpwLa05At4eTvX5FLl7vsyRVxD9E1AFYkGBu75czGzp0qyB3TF5D25cjGowINe1Drs8wLHf5HCxHg2jR/XlAzDk72hPHV2RjcmNY4RhnILtKB3OP1K4WAVdLPSHE2bUNbcPAdkupxXJsOk37RKmGtmC/JcrNPszeLGy3ToG7Fe80F4Q01DlZcUAht6PXblLas9KJbV4fWVP4HGbBB8nQuM0Cuv3hZDJLNwrWod7HCejcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nsOO5qSa6P4tPxcKsTcuQ9ed9tIOZFLNAcr92Wgi71s=;
 b=RVz9YHA4AQ41VYBh/p0lckIfo9egeXl4SqDDNUdOk8HFGBGUK32C6DbiswQLlTxGVjIVNUEucfysMH40LQGlAhLLxy1mCod8Ui0w5ZtKYs35P6MB6n+1Rc0cID6y78U0IpicwXdK7E3k+/FrcFQtyZUv+ale5NA5WcebG2TPreceDMYMfrwciHCnMxF+86R2XLnHK1FCfKvUyT4W/mTOsa73jn3jnl5gkTU4dsVbb5rJDmPrmqXd10ifVL1M96a+k5NLNzhlEpwua4N1CG1GFBCFYh9+wCBsAC1/0TGHBMcfwOEMLJJWan73tjxt/+9O5WILob2113G8Kd5RgZDjkg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cc94a021-aa76-87da-0d14-e01f09377b57@suse.com>
Date: Mon, 24 Oct 2022 13:51:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 6/6] vpci: refuse BAR writes only if the BAR is
 mapped
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-7-roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221020094649.28667-7-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9177:EE_
X-MS-Office365-Filtering-Correlation-Id: 12983fff-d9f6-4557-b569-08dab5b607ab
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vPmqZdCqACgr/PmZtkqbMbrKEGuVURmXBHgEIrUrgxWMOW349jXyHRNlWV9N9MgsQFYN33iVUZ9/AffLLIJj73bMJi+wrTOamtcl+4QY2TqKdBeap9WrF+OWtunZbuk04xIJO4/zGq+ZjNGiD1ah5F7D3Mg+V3s7XdxwRDcPMY+O17Gng0s46xlmGAtgsi4IoDQ5s/h5yWCjjFDx6aMTUvAbQ4OBC0cFpZFA77e3z14oSTFd/5zEMcCFl25ZkpoeY8jvmVg7e4No6FTNKpvYeuYej0uGFWLJJdC6TP8685PTpsT3FSs92Nn3svL7RuMqVDMsv+KQjFfcHTuJq1Y8PWUG2w0PCKMKuURnslTc1yC+LaF9Ewpk28o+YAm6SeUeJs/kaxcLhati2GxBefY78fUV8MhTY9FwZL0uFui7FIqWW3uLwdJnRt81CBi3AJUYTtzBXy4UDM9fTD+hWgHkGm1ImUqe++DJ6rpY7POJ5lTG0m5CnHJ/zm2iD9BpO/xCqhPgbdrJH18C+UHiQj5raDpAXtYJ3rt81AsWUmrgGDMtomnmp6IMq7weT+ziEGyDroC0qi2gHdnJVMf0IDCWXtmQ6JCvwA8A8BS9fRb4Tn6Acg33NU+GfZckR1nVCdFo89jMUJEqWT0xswm47CV7JisOlk9ABa0AGlz/YqY6IUkSGvew2l+qhPkhrsrEZhZs2CNqI/yrQcPqEoOlLHUJgLqdiRga6ajh29N5G0pd6FpsAVVz1ii+ZIBoHRISrMEFoFkCiQ8ibR5YChrECc7ChJV5qFR141E33AOHdtqxR+g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199015)(41300700001)(31686004)(4326008)(2616005)(316002)(5660300002)(66476007)(66556008)(186003)(66946007)(2906002)(8676002)(6506007)(478600001)(53546011)(86362001)(8936002)(38100700002)(26005)(31696002)(6512007)(6916009)(36756003)(83380400001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?enZMbDJzdW1ZZ0tzcEFoSjRoaTFFZFlNMG82Ylp5bjliUXlUWkw2SURSbHJI?=
 =?utf-8?B?S1VpV0NFNmF4OGxaSHhOZGNkUm9yMzB5Wnl5bmszMnFFRzhCQXpXZk43K1Jl?=
 =?utf-8?B?a2dEWWxrMTcwSWNxRitZS2NQaGlXSjdKUmV2cnZyT2Q4QmZ6SVNyY1Q3Ujht?=
 =?utf-8?B?ZkprY0FmL1hIV0RQU2c0aXEyNGM3dW9FTytOT1ZBMFZPa1VOM2k5cm5FL1pm?=
 =?utf-8?B?MEV4aXF5aS8wOE5ySjZYUXVtQWtMclVrcFdoaTdFeG9EZWdzdGxkb1VVNWpB?=
 =?utf-8?B?UXhBN1FWMTk3SzR2b3gwc0xkODRPUWVtajBMTnZSZ2F0d0M3MmFWNHpEaExx?=
 =?utf-8?B?bFRUZFZiVUtzQWJTSTIvVmpRTWEwem1MRUJMQkY4NXgrMHhXZTZEQ2s4UjZK?=
 =?utf-8?B?K2xGQlpIS2I1Rk9mRDMyLzRDekoyZ3FRWG5sdHZ0d2pXK0lVQWFwdVBOSEJD?=
 =?utf-8?B?L0s2aEY0dmFqcVovaVFnV1pzOXRyYWhTSHc3NUo2dTNkOTYvKzk2ejcxN014?=
 =?utf-8?B?VDFJRHhxZjlXNFFLVy9VVDFxZDI1dGF4S3k5ZU1sSFYveHFmUllBcUNTQU9r?=
 =?utf-8?B?THZGb3lwRndpUHdMY0pteEVqTEJ6S2NRTWd0QTdJcUI3NWN1U0ovZ3JqVnF3?=
 =?utf-8?B?eWRiNTBUZmFNNzMzTEFYTktBWi9WRVVxdDh5czB3T3VOdkEyUHA1clAxVE5z?=
 =?utf-8?B?MS9JcGNyUnhTQXcydXBXeUQ5SWRoOFc2SmFVbkN0dVZlOW1MV0puT2lyME1m?=
 =?utf-8?B?WEhhb3o1Z2dDQzRMMHFqZEtOMUhVdW5pNGIvZ3VLL2RLZTMvam5HeS90d2Nu?=
 =?utf-8?B?UkExUTlPaFFzUVM4d1Rzai9aS0dJd1plaSt2UGJhWm5IMGtDL01jdTNPSzVH?=
 =?utf-8?B?QmNaWWNqY01KQVdlQWVsMUpsdDRyZkYxWTBmSnB6TXo5UTI2UmxnaVprQjZC?=
 =?utf-8?B?OFBhMjl1WjdSUituTVQvTlZLOHBISkhmSnRzT1VXSW80QmZ3K0I4TzZtWVQ0?=
 =?utf-8?B?T1gzcElDa0w1MlRZTVZKa1g2RUQ1N01DRHhmZTRBc25tV1FuZFhBeUVKSkF0?=
 =?utf-8?B?Sk5WeW1LelNtT01jUmI0SjcxeHhtRm1YdXRPZWV1OG5UeC9ZYWVjRWtuaG9y?=
 =?utf-8?B?RkxsL3VFVkUvS2xaYWZJejVpa1hRWm03T0swTGlYMjZtMVBpMkRQN2RVbXQ5?=
 =?utf-8?B?cHZtcjUzS1hDaStZUXIzd3M1dENCU3hXeFF2TnZpbGZYRjJrYm9wNzlxUkNF?=
 =?utf-8?B?djZnNTNHcUVOejFaTm1ncWFYV0dJMjRlYjVYMm9sdE5nS2VMUTZjZjhUQkx4?=
 =?utf-8?B?U2FXQTN2Nk55VndHanN5VWI3NGw0MGJ5UC9SL1dIbnViUW15Y1Y4YVM3SEdP?=
 =?utf-8?B?NHRkZ3VVVExheEdCOTQ0TlpHWFk3Y1JVWHBybWFMSVRJK3gvVis0VDZ3c1pQ?=
 =?utf-8?B?VHBFZjJ3OVpYeHBJNUdoZEVyVXF0WGlVczZZczVoeHErYXJzQm44b0k1ZmFY?=
 =?utf-8?B?cGxUUm5Mc0xtUGpTQk4yamFlKzBoeUlldW4vYytlQllDaTBjalN5cG9HSXJW?=
 =?utf-8?B?ZWRaYXZwNllpa2MxZ2t1Y2VqTS9zMitCMFMzQlNrVVZ3cEI0UXBBSGdSRWcz?=
 =?utf-8?B?blo3QnVsdnRWeWFaZmNIZWNOSGNTb3d1V0M1WnlLcUxmZjBJdk9KYU9veURw?=
 =?utf-8?B?OHVLZkNtcVQ5SEpFdVNqRTR0Z3g0YnZwNlpScmU0SDBaY3R2bWorYWN2SUVM?=
 =?utf-8?B?TGRFVWZiaFZSK0Y5TG43ZXhIK0FXLzVpb0hnQjh6NzBsLzU1SW8zTVpMdDJM?=
 =?utf-8?B?MGZzNmc3eVRSazh6Yk4vT1RMN1YvNm5kelhHVmh3amxLd1BqUE1RN2NwQWd5?=
 =?utf-8?B?UVk4UTduVC9sc3JjUlZ1K0paMmd0NFgvcFVLeVd1Q2NzWlRDWm5Qalo2R1pR?=
 =?utf-8?B?UloxYjJ5UXk2bC9EVnR5SkpPbEkrL0VLZDg3RCswKzlVdW9Kam1Ra016d2JZ?=
 =?utf-8?B?WGdsZDdVTVU2MDgzaHYwQTNjbnVIUGpnaHRHS1hSaEJWWFp0cW1SOExHZTJD?=
 =?utf-8?B?NmJUdjh5THZsTVJsaGNncU12S2lJMFpKaDQ0Rml2T1JVK2RKUEJIcnVGZHFI?=
 =?utf-8?Q?l/07QUi5YaWwqSVGg0CJAnRp9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12983fff-d9f6-4557-b569-08dab5b607ab
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 11:51:04.5746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CXmVphLcnV+gTM4BQqVwqV1cFCp8GYfS86gj7XXaCtk4+cAFGqCj/wxy0ews5vayKKKUvcPaxz+Q96gg3d5E/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9177

On 20.10.2022 11:46, Roger Pau Monne wrote:
> Writes to the BARs are ignored if memory decoding is enabled for the
> device, and the same happen with ROM BARs if the write is an attempt
> to change the position of the BAR without disabling it first.
> 
> The reason of ignoring such writes is a limitation in Xen, as it would
> need to unmap the BAR, change the address, and remap the BAR at the
> new position, which the current logic doesn't support.
> 
> Some devices however seem to have the memory decoding bit hardcoded to
> enabled, and attempts to disable it don't get reflected on the
> command register.

This isn't compliant with the spec, is it? It looks to contradict both
"When a 0 is written to this register, the device is logically
disconnected from the PCI bus for all accesses except configuration
accesses" and "Devices typically power up with all 0's in this
register, but Section 6.6 explains some exceptions" (quoting from the
old 3.0 spec, which I have readily to hand). The referenced section
then says "Such devices are required to support the Command register
disabling function described in Section 6.2.2".

How does any arbitrary OS go about sizing the BARs of such a device?

> This causes issues for well behaved guests that disable memory
> decoding and then try to size the BARs, as vPCI will think memory
> decoding is still enabled and ignore the write.
> 
> Since vPCI doesn't explicitly care about whether the memory decoding
> bit is disabled as long as the BAR is not mapped in the guest p2m use
> the information in the vpci_bar to check whether the BAR is mapped,
> and refuse writes only based on that information.

>From purely a vPCI pov this looks to be a plausible solution (or
should I better say workaround). I guess the two pieces of code that
you alter would benefit from a comment as to it being intentional to
_not_ check the command register (anymore).

> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -388,7 +388,7 @@ static void cf_check bar_write(
>      else
>          val &= PCI_BASE_ADDRESS_MEM_MASK;
>  
> -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
> +    if ( bar->enabled )
>      {
>          /* If the value written is the current one avoid printing a warning. */
>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
> @@ -425,7 +425,7 @@ static void cf_check rom_write(
>      uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
>      bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
>  
> -    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
> +    if ( rom->enabled && new_enabled )
>      {
>          gprintk(XENLOG_WARNING,
>                  "%pp: ignored ROM BAR write with memory decoding enabled\n",

The log message wording then wants adjustment, I guess?

What about

    if ( !(cmd & PCI_COMMAND_MEMORY) || header->rom_enabled == new_enabled )

a few lines down from here? Besides still using the command register
value here not looking very consistent, wouldn't header->rom_enabled
here an in the intermediate if() also better be converted to
rom->enabled for consistency?

Then again - is you also dropping the check of header->rom_enabled
actually correct? While both are written to the same value by
modify_decoding(), both rom_write() and init_bars() can bring the
two booleans out of sync afaics.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:52:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:52:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429029.679778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omw0V-0005Cn-6Y; Mon, 24 Oct 2022 11:52:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429029.679778; Mon, 24 Oct 2022 11:52:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omw0V-0005Cg-3x; Mon, 24 Oct 2022 11:52:39 +0000
Received: by outflank-mailman (input) for mailman id 429029;
 Mon, 24 Oct 2022 11:52:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DVco=2Z=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1omw0U-0005Ca-MJ
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:52:38 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 579bc4e5-5392-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:52:32 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 997D4B811B9;
 Mon, 24 Oct 2022 11:52:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC97EC433C1;
 Mon, 24 Oct 2022 11:52:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 579bc4e5-5392-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666612355;
	bh=pKq6STDJUV1Dof39xPqd3W5VALSdKIfQtmFHciFElP0=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=nCFTPgKQGeLisWi3MP4ZDMRgdadGnvR9sOSwMqMjhxkJPELIgUwDqoJmMlOHaKVH/
	 dBErm38Fovc6YuRRX7pHaSzbN/jRyl/yPQaY72mj30JZPLLQUP3EjMSIBntTeQW1Oh
	 k1f/4/a/69+cmVcV8WT6dCrQtRFXeUQNMfEatQO4=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.14 165/210] x86/entry: Work around Clang __bdos() bug
Date: Mon, 24 Oct 2022 13:31:22 +0200
Message-Id: <20221024113002.320074738@linuxfoundation.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221024112956.797777597@linuxfoundation.org>
References: <20221024112956.797777597@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 88d084a57b14..3f38541c28d2 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -753,6 +753,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -762,7 +763,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Mon Oct 24 11:58:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 11:58:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429035.679788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omw5s-0005yu-S2; Mon, 24 Oct 2022 11:58:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429035.679788; Mon, 24 Oct 2022 11:58:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omw5s-0005yn-PK; Mon, 24 Oct 2022 11:58:12 +0000
Received: by outflank-mailman (input) for mailman id 429035;
 Mon, 24 Oct 2022 11:56:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bpnB=2Z=broadcom.com=sreekanth.reddy@srs-se1.protection.inumbo.net>)
 id 1omw4h-0005wE-Cf
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 11:56:59 +0000
Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com
 [2607:f8b0:4864:20::d2e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f2655c8b-5392-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 13:56:52 +0200 (CEST)
Received: by mail-io1-xd2e.google.com with SMTP id o65so7478171iof.4
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 04:56:57 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2655c8b-5392-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=broadcom.com; s=google;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=lD7LGgh6GZHw9ScZHsBO6BNcRH7clG3Dp0WsJuipINE=;
        b=Tutp3cpQBXNIp//qwPX8o9vD/+wBVKBqdt+83RA0ln6uHA8pGQgGc/+82dOtS1duC7
         5TD2qSeXqSzII+m6E17/sMqDLH4Mp1988hgEYFsRdCQpQEBmBBTZ3br4hn5o14i+RvES
         vfoiwZwV6KbE6N4t2h7kPTojS0N8sll/BHTRU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=lD7LGgh6GZHw9ScZHsBO6BNcRH7clG3Dp0WsJuipINE=;
        b=AVDlzKaT+PsyHh9JTbZx5YM193yL/zI/Q+FKdOG9a9ZfAaORpWZ4fs/k2zyPXl4bBE
         bW7Je5xnQiPK6xCR0f6sSYXTYbmB7y27uI6SmSkiR4Fbn8jwpoSufVCsZfmwEpPlQCkI
         C4o7xsUvQjawKCeAwIZBGk6cZ2c+4sT9YXhXaYtlr2PVSDCaUDH6Nu89wHAKhwrqJQmH
         AHWxBwiYQLBVtCkmYSiPdN9roEmpCGfZl5NUgrxwqgxA3NVR8W/N/6YPVo5LKTD6C40c
         vAQRqEptmHfrb5gK2NJsF2sGoWZy9+SX2UmtdxzUNGFSEJxtlzobK/SzilDgjI/MFpWC
         IkLA==
X-Gm-Message-State: ACrzQf1TymAHoBvtgMxn5yA5i0Vuq/lW+iM6QnTw4hD5h41sXEXSa/le
	HwH3Amq0NSS1sipKFbYvnn3/UUSXIyR1QEGDyqAjVA==
X-Google-Smtp-Source: AMsMyM679MO3yAC93JYcpIzYICFZTxmBQ36woWKdu4O0Q6zf7hvaFvC+P16x3sbIZl751nVIrjtULTkWp4W2oXpZTG8=
X-Received: by 2002:a05:6638:272c:b0:363:e601:cb62 with SMTP id
 m44-20020a056638272c00b00363e601cb62mr21164710jav.284.1666612616150; Mon, 24
 Oct 2022 04:56:56 -0700 (PDT)
MIME-Version: 1.0
References: <Y1JkuKTjVYrOWbvm@eldamar.lan> <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
In-Reply-To: <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
From: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Date: Mon, 24 Oct 2022 17:26:44 +0530
Message-ID: <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
To: Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, sathya.prakash@broadcom.com, 
	suganath-prabu.subramani@broadcom.com, 
	"Martin K. Petersen" <martin.petersen@oracle.com>, MPT-FusionLinux.pdl@broadcom.com, 
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, 
	xen-devel@lists.xenproject.org, adi@kriegisch.at
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256;
	boundary="000000000000fb727505ebc67c06"

--000000000000fb727505ebc67c06
Content-Type: text/plain; charset="UTF-8"

On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 10/21/22 02:22, Salvatore Bonaccorso wrote:
> > We got the following report in Debian after an update from 5.10.140 to
> > the current 5.10.149. Full quoting below (from
> > https://bugs.debian.org/1022126). Does this ring some bell about known
> > regressions?
>
> Only three mpt3sas changes are new in v5.10.149 compared to v5.10.140:
> $ git log --format=oneline v5.10.140..v5.10.149
> 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return value check of dma_get_required_mask()
> e7fafef9830c4a01e60f76e3860a9bef0262378d scsi: mpt3sas: Force PCIe scatterlist allocations to be within same 4 GB region
> ea10a652ad2ae2cf3eced6f632a5c98f26727057 scsi: mpt3sas: Fix use-after-free warning
>
> Sreekanth and Suganath, can you help with bisecting this issue? For the
> full report, see also https://lore.kernel.org/linux-scsi/Y1JkuKTjVYrOWbvm@eldamar.lan/.

This issue is getting observed after having the below patch changes,
2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return
value check of dma_get_required_mask()

What is happening is that on Xen hypervisor, this
dma_get_required_mask() API always returns a 32 bit DMA mask. I.e. It
says that the minimum DMA mask required to access the host memory is
32 bit and hence mpt3sas driver is setting the DMA mask to 32bit. So,
on a 64 bit machine, if the driver set's the DMA mask to 32 bit then
SWIOTLB's bounce buffer comes into picture during IOs. Since these
bounce buffers are limited in size and hence we observe the IO hang if
the large IOs are issued.

I am not sure whether this API's return value is correct or not in the
Xen environment. If it is correct then I have to modify the driver to
not use this API and directly set the DMA mask to 64 bit if the system
is a 64bit machine.

Thanks,
Sreekanth



>
> Thanks,
>
> Bart.

--000000000000fb727505ebc67c06
Content-Type: application/pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg
gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD
VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE
AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT
AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS
MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA
vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t
rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e
aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1
e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH
cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG
MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ
KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB
/wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu
TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i
YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j
b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs
c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo
CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN
BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf
jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8
9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ
/oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ
jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC
AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v
dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5
MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB
IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG
SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E
XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J
J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u
nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv
riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj
QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N
UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH
M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU
Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V
14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy
a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/
XzCCBVUwggQ9oAMCAQICDB+3K5yLGfrPX2JJDDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC
RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg
UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwOTE1MDRaFw0yNTA5MTAwOTE1MDRaMIGU
MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU
BgNVBAoTDUJyb2FkY29tIEluYy4xGDAWBgNVBAMTD1NyZWVrYW50aCBSZWRkeTErMCkGCSqGSIb3
DQEJARYcc3JlZWthbnRoLnJlZGR5QGJyb2FkY29tLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEP
ADCCAQoCggEBAKfHWuSS7HS/Z3X455BpzG79CoaBfWr2fZFr7yoghcJInIYjYh6jeJqy113fKAfd
SWHp+u8iD9UZt55HyL7TncZAgnsQKf+iTn88Kk3bKyBEsRjXrtV5iYmY/RLAi/IcrVBRwcxUPK6s
iSD066exA9r0siY1cvv+jXyp5WMu+9gkNgRLQSfjEn3rzP+jn/OehrDGQYwmtj2qy32rcN7UhFqI
vZXeqKYupAd0/kWANIYKfeXvBSrhLTL/JLyu02jrKwUQmNeV/csW4n51mmbQyz5VRjLIaM9r93rl
EKIoHplnybLWh6glNdzUbh+wpglCjssypREDVGZjlDD7NS2Q6FUCAwEAAaOCAd0wggHZMA4GA1Ud
DwEB/wQEAwIFoDCBowYIKwYBBQUHAQEEgZYwgZMwTgYIKwYBBQUHMAKGQmh0dHA6Ly9zZWN1cmUu
Z2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNydDBBBggr
BgEFBQcwAYY1aHR0cDovL29jc3AuZ2xvYmFsc2lnbi5jb20vZ3NnY2NyM3BlcnNvbmFsc2lnbjJj
YTIwMjAwTQYDVR0gBEYwRDBCBgorBgEEAaAyASgKMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3
Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAkGA1UdEwQCMAAwSQYDVR0fBEIwQDA+oDygOoY4
aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAyMC5jcmww
JwYDVR0RBCAwHoEcc3JlZWthbnRoLnJlZGR5QGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF
BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQU90fCF++yKdqz
eSa+l3ox+Xh3bUUwDQYJKoZIhvcNAQELBQADggEBAEdSkxxx3jOPvsTAmqeChWssN7WYUZOhNQu/
+6bxE3/kn9StH6miItK87eIRsO0FFVLDJBnhWz0EGzWEliC68mV8ecDApK5douyO1VfXN8awZZ33
i/RQS2sGbz1vIfPu54rtnwXGoUiXRaSOz0pLy/JRCFyHOj+8GKauKkyrUWiD0j1xPTJ1p8/KOyKd
hPIHLRxnZxqpa2GjCtl3IYjKK8WbWx0NXkszaVTVRIn8e++VyiiH/yFXVyOEQxkZRQZWzTjPE9o/
R31F09e8yABfehc+e00bSP23FKNuA8dwS29RHLpjmd+m5EtbFGD4EUANHzCSTA89S/iWNoaWteab
v6IxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh
MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwftyuc
ixn6z19iSQwwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIFq7l/PC0jHugfQtWux6
CdKsCZRPiFaYvxZKZNy5e5noMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF
MQ8XDTIyMTAyNDExNTY1NlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD
BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG
CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBIcoRPJF8VgzJC3X0oTVSDPRp1frOubd3wuffU
6EFgkT0cfeucQY8bLVnhEI3v18Lrz/72J+bede6toF4HeXxkuyZFKv6QK2A72RmYtOIwOcjvkutP
UFMJ5ZUXgJi889aHsKmqUuPi+tdd632Ag9ryvdsjcmR7x8GRydXG4xbEUYptSLp2mIEOBZ/Dp+Dj
9p3MrPUungIhuIfCa4VO5jz447ec2ni9xMyEyg6swpad+FuAx9y1v/osKybhBnYUuRZ2hyOAMAtl
W73n34yZ24Q5DBusIfdu6S1hYobYupsKuO53WzoWbGhTkbgjGB8r75iMyrwgyfw3a9UBXfkRmb/f
--000000000000fb727505ebc67c06--


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:02:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:02:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429044.679800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omw9p-0007WL-KG; Mon, 24 Oct 2022 12:02:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429044.679800; Mon, 24 Oct 2022 12:02:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omw9p-0007WE-FZ; Mon, 24 Oct 2022 12:02:17 +0000
Received: by outflank-mailman (input) for mailman id 429044;
 Mon, 24 Oct 2022 12:02:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DVco=2Z=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1omw9n-0007W8-Nc
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:02:15 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afd4690e-5393-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:02:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 30B16B81250;
 Mon, 24 Oct 2022 12:02:14 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64D13C433D6;
 Mon, 24 Oct 2022 12:02:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afd4690e-5393-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666612932;
	bh=HDBZX01FN2W9c75Sd8NoXHb1ZhN7yyXXynCHY/64+/k=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=pND0li9PULhAZ5WGWsVwxg82gs5hly/Vnn/CKFpKa2LRY7bOsjDtEpcmCVbQwj/O2
	 gn1YSu/K3jWSnXc47NgdgmPwB9t620DY8KGXQCWZFjktH23fUfjmrYlggGyGdSzy1g
	 5UskNI2UYgsHLyuQGVhQKGGGC6UFXCP8xlpcR/RA=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.19 174/229] x86/entry: Work around Clang __bdos() bug
Date: Mon, 24 Oct 2022 13:31:33 +0200
Message-Id: <20221024113004.718917343@linuxfoundation.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221024112959.085534368@linuxfoundation.org>
References: <20221024112959.085534368@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 8f1ff8dad2ce..04bfd9c3987b 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -752,6 +752,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -761,7 +762,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:05:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:05:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429049.679811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwCP-00086J-0R; Mon, 24 Oct 2022 12:04:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429049.679811; Mon, 24 Oct 2022 12:04:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwCO-00086C-Sm; Mon, 24 Oct 2022 12:04:56 +0000
Received: by outflank-mailman (input) for mailman id 429049;
 Mon, 24 Oct 2022 12:04:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tdD1=2Z=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1omwCM-000866-Vn
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:04:54 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 113fd497-5394-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:04:53 +0200 (CEST)
Received: from MW4PR03CA0300.namprd03.prod.outlook.com (2603:10b6:303:b5::35)
 by DM4PR12MB6328.namprd12.prod.outlook.com (2603:10b6:8:a0::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 12:04:50 +0000
Received: from CO1NAM11FT063.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:b5:cafe::6) by MW4PR03CA0300.outlook.office365.com
 (2603:10b6:303:b5::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Mon, 24 Oct 2022 12:04:50 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT063.mail.protection.outlook.com (10.13.175.37) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 12:04:50 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 07:04:49 -0500
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 24 Oct 2022 07:04:48 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 113fd497-5394-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HlPCMzC7z4yW5AjrqC5LFWy1q3GDPZY2f4DdjShJ5/XsaL8R5uNvNTNTD/43il+6naYIBAYfTuI4PR8NfS8x8ElC9SpgCKbhTgP5K5/Tj3H14v6uifv+jvFttjSPpOpTbKbgVEEtQtneq9qICsYtZ7l3pXre+17K8aP7yyDe3os6YBs8f9LlhdHNKq1PU1++1YBlySkYJJlOhx21twr4s30cDdeMeTfW+UNw7vXhvdWivRa+yFU28XP3UWEGt5EFBrIqAjoo28MjhLqhlmH7Q/578VbdiQSk3jK17s/mi7XKdV0GwfeOB7ETnatU7pW3mLqIbyqWrKKDBf5cIFMoDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QCeunKUDYS7dW3EKFsxJvNMpnPsl3HJEwwfTpZQ3bMU=;
 b=X02YmLKcGiHbMi+/3rTO9VI6iQtNbN/s2z7P8hucFSwmv5xXKyxhDkC1BPUnnM2uF5amjk2jSqx21wVQ/xQBSGaG2aj7OXWGmXtA2EyABgHX/sOPQnpfWgRAf8RDNmeKfpsnLiDUo055fWtMRL6V5sHhUw1yTDGIVwjfyG8dGlcZZEkou2oNvJt3szehGpj9VBvHZHnTUY8jViZ7gN8wRBZdW3zbGhdYRnrvwG+qdInlRoupklQgQSuDiQj1bV2w/L7HTsVFyybFaQ3g/zgsxCDzeLP+C+vL8EGnFBkTYX32Wm+AT8S/kOACy7IVEBlQ0+1o73abg9A983ERrF1RIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QCeunKUDYS7dW3EKFsxJvNMpnPsl3HJEwwfTpZQ3bMU=;
 b=uD6g+9KujZpD7GuSGDFcHSD00uVEWYGF3+ZggK/dfAmftZhTVIoEvBiT35DH020EsmhLgt/B4pG6w5WEi4gKrEziIbU22dWhMinZGhjtzD2Ab6h443gVC8rgwoR6Aof46wvvvWc6N81XzC8lVyc4pId0WPhemlPEYTFkKWZtEZo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>, <Andrew.Cooper3@citrix.com>,
	<Henry.Wang@arm.com>
Subject: [for-4.17, PATCH v2] automation: Explicitly enable NULL scheduler for boot-cpupools test
Date: Mon, 24 Oct 2022 14:04:43 +0200
Message-ID: <20221024120443.16202-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT063:EE_|DM4PR12MB6328:EE_
X-MS-Office365-Filtering-Correlation-Id: f03b1416-94ea-4db4-2efe-08dab5b7f3f3
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	shicq1BTe4dC5HZeMvEYtR9ZVlVEnzg7aSU5YVAHuL50Elv5I0tunJoPUgxzYFyvyquUY/hDXAsa6pvtQF9xglC7t/PS9EXPbEila9dimPEAmgpcL+pkismDVfNq462zEYQqlP3QXsydCUodhQpBV51YzGAjwnipLE/Zn9vBqrdxgXmhgqXfZOgvU2xiOQDy/DvMmg8yoZhJG5Mn2z5Eydn7oNe7aydlpD9SD99Xj/IVqafxL4S2hFN8+da9y5H8E6lyDC7kFd90AcaErZ6SfgZhq+6x9x2n8dVZp2zB6sdaGPqQwv4tOGNqxDsY5trutWtRRa2+IFzuraCHXhpVzf7ZWlZQtRBJ6jl8UYhvrwx4apJ7hFBcBPQdths2PzBhKABj3PZT9u2kzUwEOcP+3CMF/OZf475pONUz9+0GDujOiaxwwS1BIWm+pQAnTJ1o67V3APe9i8jTQcP5rOUsKWGs8+euU3qOdr5v+CGuxUrtWi/cqX3lJwueHwri9/fI5TyAd8fdB51SCi0EbL5O8TPCbNDWHoxfo4R9Rra3+JcnFyoW7cgLTd3PaO+ItAoz1+0nNY0Ihbe2o3SrKMyEi9xhT3BoJXPMuId2wtxVDWJ/9bg5N4jXPnUd+DY5Hn2sodc9hqJ4+CA7ITSQu8gZ8GUNm/m8PAU3U2Sd0IlonT2R7j8TvFeUL6rHT9ko9VI9u9T/xb+2mJXkBNmbKtSFFonrbuNCIqss6wVa2rISpHsU+AyZKuAwoQ1IZjSvf+zVNg50NxiEBbRqAP3xM5xncSiumSaCcH86Zr3JO+UTaSazYCGWAFbqOGCkmxa/DvjB7lTGVinBlfDnCizjvJ9elQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199015)(36840700001)(46966006)(40470700004)(40460700003)(5660300002)(966005)(8936002)(36860700001)(478600001)(44832011)(82310400005)(26005)(2906002)(6916009)(54906003)(316002)(82740400003)(41300700001)(186003)(1076003)(86362001)(70206006)(40480700001)(70586007)(81166007)(356005)(4326008)(36756003)(426003)(2616005)(6666004)(8676002)(336012)(47076005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 12:04:50.1227
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f03b1416-94ea-4db4-2efe-08dab5b7f3f3
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT063.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6328

NULL scheduler is not enabled by default on non-debug Xen builds. This
causes the boot time cpupools test to fail on such build jobs. Fix the issue
by explicitly specifying the config options required to enable the NULL
scheduler.

Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Changes in v2:
- was: automation: Do not use null scheduler for boot cpupools test
- modify the commit msg/title
- explicitly enable NULL scheduler by specifying all the required options

This patch acts as a prerequisite before merging the following patch:
https://lore.kernel.org/xen-devel/20221021132238.16056-1-michal.orzel@amd.com/
(to which Henry already gave RAB), that helped to find the issue described
in the comment.

Tests shall explicitly specify the required Kconfig options for non-default
pieces of logic, thus this patch is unrelated to the discussions whether
enabling/disabling the NULL scheduler should be controlled by DEBUG or not.
---
 automation/gitlab-ci/build.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
index ddc2234faf39..716ee0b1e460 100644
--- a/automation/gitlab-ci/build.yaml
+++ b/automation/gitlab-ci/build.yaml
@@ -582,6 +582,9 @@ alpine-3.12-gcc-arm64-boot-cpupools:
   variables:
     CONTAINER: alpine:3.12-arm64v8
     EXTRA_XEN_CONFIG: |
+      CONFIG_EXPERT=y
+      CONFIG_UNSUPPORTED=y
+      CONFIG_SCHED_NULL=y
       CONFIG_BOOT_TIME_CPUPOOLS=y
 
 ## Test artifacts common
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:05:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:05:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429050.679822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwCV-0008NP-7G; Mon, 24 Oct 2022 12:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429050.679822; Mon, 24 Oct 2022 12:05:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwCV-0008NI-44; Mon, 24 Oct 2022 12:05:03 +0000
Received: by outflank-mailman (input) for mailman id 429050;
 Mon, 24 Oct 2022 12:05:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=diCp=2Z=redhat.com=sbrivio@srs-se1.protection.inumbo.net>)
 id 1omwCU-0008Ms-4w
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:05:02 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14f86b15-5394-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 14:05:00 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-260-5LUlF93eMRuhxrfgfGRSFA-1; Mon, 24 Oct 2022 08:04:55 -0400
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FA3E8065E8;
 Mon, 24 Oct 2022 12:04:54 +0000 (UTC)
Received: from maya.cloud.tilaa.com (ovpn-208-31.brq.redhat.com [10.40.208.31])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id E2E5E200C0DA;
 Mon, 24 Oct 2022 12:04:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14f86b15-5394-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666613098;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TN68KVpvR7XKYr0YdRyHBatb1VXNIh4kpbgamAYS4Zw=;
	b=hyZe1oIm3GjMDbconZbQuNvnE7S3VewWsWXE8LPa1aMmc7HhV6BY86waaT7IuTbbI7d4o0
	HiGDli3zlqjBck0QUGOCNis1vU8CQmMOabKNkdnwdwqoGiQA5CqI6OAjutvBxcAZ0JzU1/
	5Om6uNMwEIqkmLRNU06lhFvIAgInOFE=
X-MC-Unique: 5LUlF93eMRuhxrfgfGRSFA-1
Date: Mon, 24 Oct 2022 14:04:31 +0200
From: Stefano Brivio <sbrivio@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org, Paul Durrant
 <paul@xen.org>, Thomas Huth <thuth@redhat.com>, "Daniel P. =?UTF-8?B?QmVy?=
 =?UTF-8?B?cmFuZ8Op?=" <berrange@redhat.com>, "Dr. David Alan Gilbert"
 <dgilbert@redhat.com>, Greg Kurz <groug@kaod.org>, Stefano Stabellini
 <sstabellini@kernel.org>, David Gibson <david@gibson.dropbear.id.au>, Eric
 Blake <eblake@redhat.com>, xen-devel@lists.xenproject.org, "Michael S.
 Tsirkin" <mst@redhat.com>, Stefan Weil <sw@weilnetz.de>, Paolo Bonzini
 <pbonzini@redhat.com>, Jason Wang <jasowang@redhat.com>, Samuel Thibault
 <samuel.thibault@ens-lyon.org>, Anthony Perard <anthony.perard@citrix.com>,
 Laine Stump <laine@redhat.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
Message-ID: <20221024140431.2e93dd2b@elisabeth>
In-Reply-To: <87tu3tsczq.fsf@pond.sub.org>
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
	<87lep935hn.fsf@pond.sub.org>
	<87tu3tsczq.fsf@pond.sub.org>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4

On Mon, 24 Oct 2022 13:00:09 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Cc: Stefano Brivio
> >
> > Laurent Vivier <lvivier@redhat.com> writes:
> >  
> >> On 10/21/22 07:48, Markus Armbruster wrote:  
> >>> Laurent Vivier <lvivier@redhat.com> writes:
> >>>   
> >>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> >>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.  
> >>>
> >>> Use cases?  
> >>
> >> This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.  
> 
> [...]
> 
> >>> Could similar event signalling be useful for other kinds of netdev
> >>> backends?  
> >>
> >> I was wondering, but it becomes more complicated to be generic.  
> >
> > Making something complicated and generic where a simpler special
> > solution would do is the worst.
> >
> > Not quite as bad (but still plenty bad) is making a few special
> > solutions first, then replace them all with a generic solution.
> >
> > I believe we should have a good, hard think on possible applications of
> > a generic solution now.
> >
> > There is no need to hold back this series for that.
> >
> > If we conclude a generic solution is called for, we better replace this
> > special solution before it becomes ABI.  Either by replacing it before
> > we release it, or by keeping it unstable until we replace it.  
> 
> Stefano, any thoughts on this?

Actually, to me, it already looks as generic as it can be: stream
back-ends are the only ones connecting and disconnecting.

I quickly tried to think about possible, similar events for other
back-ends:

- user: handled by libslirp, there's no connection, and probably not
  much we can or want to export from libslirp itself

- tap, bridge: the closest equivalent would be interfaces changing
  states, but that's something that's also externally observable with a
  netlink socket, in case one needs to know. And in any case, it's
  logically very different from a connection or disconnection. If we
  want events for that, they should have different names

- vhost-user, vde: we could implement something similar if the need
  arises, but it should logically have a different name

- l2tpv3: stateless, same as datagram-oriented socket. No states, no
  events to report, I guess.

All in all, to me, NETDEV_STREAM_{,DIS}CONNECTED events here don't look
very "special" or hackish.

-- 
Stefano



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:14:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:14:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429059.679833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwLN-0001lt-41; Mon, 24 Oct 2022 12:14:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429059.679833; Mon, 24 Oct 2022 12:14:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwLN-0001lm-1N; Mon, 24 Oct 2022 12:14:13 +0000
Received: by outflank-mailman (input) for mailman id 429059;
 Mon, 24 Oct 2022 12:14:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DVco=2Z=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1omwLM-0001lg-2K
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:14:12 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d0263bb-5395-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 14:14:10 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id CE1E5612FE;
 Mon, 24 Oct 2022 12:14:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B814EC433D6;
 Mon, 24 Oct 2022 12:14:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d0263bb-5395-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666613648;
	bh=q35u9k51iKg4WFnPv2+Jft9j9x8EK3aRtf5Pa+iGBKU=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=N3lJStRMIfM1xWFYqREc3zv03PcsQNTZREFDYQk+pT9yVx9WozZGOrOlVilhzF22/
	 Wr5AjCofsHKgneEeFUqozvy/Km3bGtfIXKZH2yz+iNPksyqfK+Wqd9juu4GNyC7bVk
	 kuLnDNBQIeOKtz3FztqY9EbZUVna89qVxZT0rJbA=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.4 189/255] x86/entry: Work around Clang __bdos() bug
Date: Mon, 24 Oct 2022 13:31:39 +0200
Message-Id: <20221024113009.238496303@linuxfoundation.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221024113002.471093005@linuxfoundation.org>
References: <20221024113002.471093005@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 65cf405cd975..26b35e75b701 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -759,6 +759,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -768,7 +769,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:19:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:19:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429064.679844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwQ9-0002SE-N7; Mon, 24 Oct 2022 12:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429064.679844; Mon, 24 Oct 2022 12:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwQ9-0002S7-KI; Mon, 24 Oct 2022 12:19:09 +0000
Received: by outflank-mailman (input) for mailman id 429064;
 Mon, 24 Oct 2022 12:19:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=akEN=2Z=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1omwQ8-0002S1-KU
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:19:08 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0debc15f-5396-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:19:06 +0200 (CEST)
Received: from AS8P250CA0004.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::9)
 by DBBPR08MB6236.eurprd08.prod.outlook.com (2603:10a6:10:20c::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Mon, 24 Oct
 2022 12:19:03 +0000
Received: from AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::ea) by AS8P250CA0004.outlook.office365.com
 (2603:10a6:20b:330::9) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend
 Transport; Mon, 24 Oct 2022 12:19:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT030.mail.protection.outlook.com (100.127.140.180) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Mon, 24 Oct 2022 12:19:03 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Mon, 24 Oct 2022 12:19:03 +0000
Received: from 600f78acfc7a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 79D5DB03-A37E-4A84-BB17-081611B25DA2.1; 
 Mon, 24 Oct 2022 12:18:56 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 600f78acfc7a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 24 Oct 2022 12:18:56 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by PR3PR08MB5708.eurprd08.prod.outlook.com (2603:10a6:102:84::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 12:18:45 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 12:18:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0debc15f-5396-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=NbgB3KFhAHU4LMWr+knGtuHhErRgbPb1yqFZoby2qwOd5q1+g8ltdpAKQiKNa2aBVVTooVjgVn1zrVqvWC7MTSdmrxy397R1MrMx5DB/LqHs3OOx2O0ON9hwKGiZAoMLOFyc1PmKRNwk7qAsC/D2tFa64DdN1vQiV98ry2cOhGrWexcgQwo1qN5P7vMX+oKsEMj8dGqSgRwc1XNJgd9NwLvN7kgKGVSmHr8VcwOStlHTlQxCN+uRe1uK+0Om516h4m/jbXinf6iNVaWoc9acwiJ0QCqE5WJlqKTHyfc3hJO9D0KT/QMMc43SHvIzKpN6VR0S6COPWUykAU5v32iNkA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a/Sjc6jRJdXwkBkdhTMQhKo8EjZykD/bE39uMjhYWMw=;
 b=E45Y+tLl7ugXNUPmhufNmylMObqM7tScVUWPahyIKw8hTP12jWdTHUvLPkj50cQe2CE8ZdlkWmw0vTd0kV0x1UbGnzvc53m+7dWs4C4Tkc5o2uhtAt3BEtRKruDllbglW1VtmktdLAM1FKy9lxkuurHxJl0FNOKzwr9xmBFcEeRQ/jjE58nC2fbYBMlk3spnyAQokDcMybEpbzg0VqQYfTHTpdpmw/O01BPdIlV8Kn62m7T6fHL/yMvtc+rp/7TI6yvL8g9UjYi+1Wm3S2Bk29380kRIhg5Ru/K8//UGLA6Zstuyc0eFdJWEP7flFDaO1Q746yvLqDjkWH2eSa8KWQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a/Sjc6jRJdXwkBkdhTMQhKo8EjZykD/bE39uMjhYWMw=;
 b=jkjdBp4o8/BbUMrzm94m6PJyKOF4bSJc4RVnuvAh2Megxo/mjstBn5F78UC2VYWr+89fsHubkP16A0/FrHs3b3z7ctqV7tI/NwRkUKdVyLaqr/MmPPII2+K8KeD6WLnTjUPnl3oZrm1xjNJMszT5RLZDXESkU9zfny6yeaKGcWw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: e9cc4604d2963f6f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OH4kBTp0Xv4jAbnhaP+8eVdkqZq3gzfKtc7RVA7iqacYNrjZMtaXz9KMwJjKHKFOmWgOKoeIiEa4IlY3Zsv5Ai9h4kgjNxc6t7CncyQcMqMK6+8s0vPDWfiWibpQIzSqjhQ+7Few8FKbXE0NdaW48Jim+R2l11hqQOWWNXwGqcQZdRlu/uKbQdo2GN5DCKmINHf2moj8R8RyyyJLfD9GUs47SV2TSDfxzZfPN0li5JAlSwrF/tnLfZKmDPgc5e/CSPRWfSMwZ9yQf7Ioy8FNKZHdl3QdsqHz2FkaKKUpeLAoRGTQ3Y67r7qw6qV9IQFOjBTsn9VJQFAkcQ1/ciGZRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=a/Sjc6jRJdXwkBkdhTMQhKo8EjZykD/bE39uMjhYWMw=;
 b=HLNk+WA9TyLkqPAyQ6CzXW9VYpPX2mUeM1UZzMcXstNGCtcP5658Qsc+jpPBLPUviN4M64AeCgcphq/aV+bjaF77DSFkO2WR73PkRiyNRTg7bzRcQcCupb65XIJ7xsR+BjYvZgRTf4psCnN8Gv5qi2+p0OKh3Zm9Bv6KlVSkpBzH25XYjC/IKYeo2hGQAl6Gvr7P14TKVH8ZS9U79eAfd2Eoe1ZeC3vdKtPQXeHa4ssgvmr2I+hjDtFZBukEtg0cZyq4Rb6wGiHt1FbiVUThv2nurveiXPcMl32QhbS3gR/SsjxjQx8AMOqtO1Z95mJhYrzDuCxg6QgzxOFk0ckSzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=a/Sjc6jRJdXwkBkdhTMQhKo8EjZykD/bE39uMjhYWMw=;
 b=jkjdBp4o8/BbUMrzm94m6PJyKOF4bSJc4RVnuvAh2Megxo/mjstBn5F78UC2VYWr+89fsHubkP16A0/FrHs3b3z7ctqV7tI/NwRkUKdVyLaqr/MmPPII2+K8KeD6WLnTjUPnl3oZrm1xjNJMszT5RLZDXESkU9zfny6yeaKGcWw=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded
 values
Thread-Topic: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of
 hardcoded values
Thread-Index: AQHY55BMcvguN056m0ylAZ3lyVdtTa4ddmQA
Date: Mon, 24 Oct 2022 12:18:45 +0000
Message-ID: <F48F1AE0-C4B3-4614-A428-539DBFC284C8@arm.com>
References: <20221024100536.12874-1-michal.orzel@amd.com>
In-Reply-To: <20221024100536.12874-1-michal.orzel@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|PR3PR08MB5708:EE_|AM7EUR03FT030:EE_|DBBPR08MB6236:EE_
X-MS-Office365-Filtering-Correlation-Id: da0214f6-6d94-4902-8023-08dab5b9f074
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 SpK4zaxTIKUn/mek5g0jWpZ8aazCREFdTXW+asN3jVwHQPkM3FBKd+awHCPHlyWo5RbDkz3c6VQ2+rKO8JPbZgGCb1FkMi71c30peswsMjnExjmW21K1Ru+PzaRCMlCsuk6RQgvcShEc6Nk929mTcp+jah7loOAxEPxciV+hNr3FIdPGimPhoz9ss1RiSSMEJC4bEBThpE7qqELqC5tjPJD9r9B/WZ5K6WxlJiEiMLGDlf/qGsmIFCKQ8xCK4IM9fNo5txKzXvC/tlz1MYrZVGj8/xOHpBwAQ5e93IRnyTGmSZqrqmBxygTIpVEEW/YoNLBLJWPixXqPSW3BH53zgO89YGf5XPcODNg3Uy2O90mLu3IuP5ACyWxw0C9Jjj8MHaofEvYpCvspfTmXSg3OrjghnYbNpCALRd7OuUglTQ9eO4JWJrlQLZgvOd96INWoOBchXVkPNdRycsfoBF58P0rBfYPrsico2fsAIHddHphI/g/6QxGRc7z/RQwEXG1z8w6PgHHbRb6qdehe+JNRe4qoekpqUOmVVhb1xVoQlYPDMzIV9hn27xHnZZEFm6UqQakzvvLsQoZcZ55L9HX1pCOq09+Yp5fnTVQ96v2VwhJoDH82sOOCIhzuwzAG7EnNcC85zdDXuATmg8ZQ4YolbaLDUqYc9Bnb6CtA4pIMeJ/N2qZUG2J0P9QSprk6z6SOHF9HL6QF+Iysfzn5LhPqO8Mzp9JZJS/py4PN7evbYQupXP9+jhISsSfSuZtndRmpSX9/YGK1PpSrN/rH278chKHcMoIk/ilJ26ahGDjUzJE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(6916009)(4326008)(54906003)(8936002)(76116006)(66946007)(66556008)(66476007)(66446008)(26005)(91956017)(64756008)(8676002)(53546011)(41300700001)(6512007)(5660300002)(6506007)(36756003)(186003)(38070700005)(38100700002)(122000001)(4744005)(2616005)(316002)(2906002)(86362001)(478600001)(6486002)(71200400001)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23710C4E9D5F364A97A84346415CD0D9@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5708
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5ad6d901-45ae-4732-582e-08dab5b9e5cd
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eFdDhIOAH5SzRdv8JhPs1XboGfUhF6BNXJ278f9g4prw3938aPfHHMWI778c/sjJQUtZ6kFg2cGwei9fEq9MQBLcoBLhTLcR+VROBW+6+uNweZaegc4z6bpXnX2oRpcj3zqDfNfUOdWdfaaEtvpxMq7XQaJiYAiwGI9JplJlzcws0IJKN220FCYZHtvUWQnHT7/PVVXvIP286nM9sUeDXDUwFWzqy3boEHvB8085Uvi96RMfqrJbnewJ1UQSfhBdLOloJdxkTdn5FDghE9R8uvHwCSfIG1UdZ7EQoFNztgHwkrgDL5Q/Uim/D4eQqyA856FzQ3Px7JH04FVT+RCkn9ugMNDzpj2Sx/qWIgKys+a5c5SLaCEhm69YMQmCn27NQrlD1wVa6IjyZA64jytmb2qEG18iTFgvH+KdT90aOVRXNwRk9wuVf8eg4911gcrpYOgWNBYlExp5edT7RxfMXhBaB3A/PHOP7neUDex3ivGodV2wHvUytaQE5mS6d9UXfG7KGBjGk2d8nGR8q/Lnp6m0vcEShosRjWvSkk011Dlx83Wcunm8as0dm7f+uSVF7w5/kGoeZjeHLT+eSmeOGPA4FiHkJUSwu8bHRHU6Xus/iRft/cbhkpfCnWIHOKQUQLNfx7zgDxGXIaaQ4HyUQNbWXLa8OpdsZ8nMwCgjjQrr9P27QqnH8E+UpmijZh8rzkv7p2YsBIlh1tEERwhov5ZM1uE5b+j7hj8zTuRjFfrz5qrNpfgSaXP4qmAke67OPiYCnjnTV4LjSTD0HsEEog==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(36840700001)(40470700004)(46966006)(2906002)(36756003)(4744005)(316002)(41300700001)(4326008)(70206006)(70586007)(8676002)(5660300002)(478600001)(33656002)(6862004)(54906003)(8936002)(40480700001)(6486002)(356005)(81166007)(82740400003)(107886003)(36860700001)(26005)(53546011)(6506007)(86362001)(47076005)(336012)(2616005)(6512007)(186003)(40460700003)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 12:19:03.3465
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: da0214f6-6d94-4902-8023-08dab5b9f074
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT030.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6236



> On 24 Oct 2022, at 11:05, Michal Orzel <michal.orzel@amd.com> wrote:
>=20
> Make use of the macros defined in asm/pl011-uart.h instead of hardcoding
> the values. Also, take the opportunity to fix the file extension in a
> top-level comment.
>=20
> No functional change intended.
>=20
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> ---

Hi Michal,

Seems good to me!

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>




From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:29:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:29:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429070.679854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwZs-00042K-SJ; Mon, 24 Oct 2022 12:29:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429070.679854; Mon, 24 Oct 2022 12:29:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwZs-00042D-P7; Mon, 24 Oct 2022 12:29:12 +0000
Received: by outflank-mailman (input) for mailman id 429070;
 Mon, 24 Oct 2022 12:29:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DVco=2Z=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1omwZq-000427-QT
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:29:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7532eeeb-5397-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 14:29:09 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 54871B8169E;
 Mon, 24 Oct 2022 12:29:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A5BCC433D6;
 Mon, 24 Oct 2022 12:29:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7532eeeb-5397-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666614547;
	bh=aW+O/Bep5E72Knf9F5KLUligbpxqba0bCHR1Uql63Oo=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=cQtyDm7tvpANV4AlaDyclQKUJhPvkh6ix3TEF/Pmh/UHGFZ0K62W+PbDuPCK1TCwq
	 gLqfRAKygujAdEWgsogkoaxob480dvaiC6ZKlQCPN4bBzOSfbRwq+QAK+cF94ZrYO7
	 m2rmpZ/eLuonEkxUyNpu0DUjvi4+ZyEHPwupMz3w=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.10 302/390] x86/entry: Work around Clang __bdos() bug
Date: Mon, 24 Oct 2022 13:31:39 +0200
Message-Id: <20221024113035.871644092@linuxfoundation.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221024113022.510008560@linuxfoundation.org>
References: <20221024113022.510008560@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 804c65d2b95f..815030b7f6fa 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -768,6 +768,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -777,7 +778,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:30:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:30:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429073.679866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwai-0004qG-67; Mon, 24 Oct 2022 12:30:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429073.679866; Mon, 24 Oct 2022 12:30:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwai-0004pI-1n; Mon, 24 Oct 2022 12:30:04 +0000
Received: by outflank-mailman (input) for mailman id 429073;
 Mon, 24 Oct 2022 12:30:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=hdrL=2Z=redhat.com=armbru@srs-se1.protection.inumbo.net>)
 id 1omwag-0004Ra-R3
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:30:02 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9420c54b-5397-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:30:01 +0200 (CEST)
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-599-AMNzz533PcWqfjPTKcwZtQ-1; Mon, 24 Oct 2022 08:29:49 -0400
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com
 [10.11.54.2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 46285185A78F;
 Mon, 24 Oct 2022 12:29:49 +0000 (UTC)
Received: from blackfin.pond.sub.org (unknown [10.39.195.118])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id EA8A340C6FA3;
 Mon, 24 Oct 2022 12:29:47 +0000 (UTC)
Received: by blackfin.pond.sub.org (Postfix, from userid 1000)
 id 3BDE921E6936; Mon, 24 Oct 2022 14:29:46 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9420c54b-5397-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666614600;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ugzIHUs7cdf/Kh5OtlOT6I99mijCPbdrWfAqkmqdgDM=;
	b=DJThtJFD95Mt2gjNJohdDZf2rOexKNSowaeHLVU5wzqxPvntpexygzpfGydQSs2u29v5Ec
	4dSLuiBQLJotYOFK1rZgjKD2PC9gtX4MUs9bVqfVbot5utJnR+IcComgB/krWTl+m8GOt1
	cUQKJheHCMa3nRZYWJfG5rZxn7KwxPY=
X-MC-Unique: AMNzz533PcWqfjPTKcwZtQ-1
From: Markus Armbruster <armbru@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,  qemu-devel@nongnu.org,  Paul
 Durrant <paul@xen.org>,  Thomas Huth <thuth@redhat.com>,  =?utf-8?Q?Danie?=
 =?utf-8?Q?l_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,  "Dr. David Alan
 Gilbert"
 <dgilbert@redhat.com>,  Greg Kurz <groug@kaod.org>,  Stefano Stabellini
 <sstabellini@kernel.org>,  David Gibson <david@gibson.dropbear.id.au>,
  Eric Blake <eblake@redhat.com>,  xen-devel@lists.xenproject.org,
  "Michael S. Tsirkin" <mst@redhat.com>,  Stefan Weil <sw@weilnetz.de>,
  Paolo Bonzini <pbonzini@redhat.com>,  Jason Wang <jasowang@redhat.com>,
  Samuel Thibault <samuel.thibault@ens-lyon.org>,  Anthony Perard
 <anthony.perard@citrix.com>,  Laine Stump <laine@redhat.com>
Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report
 connection state
References: <20221020162558.123284-1-lvivier@redhat.com>
	<20221020162558.123284-18-lvivier@redhat.com>
	<87pmel4th4.fsf@pond.sub.org>
	<52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com>
	<87lep935hn.fsf@pond.sub.org> <87tu3tsczq.fsf@pond.sub.org>
	<20221024140431.2e93dd2b@elisabeth>
Date: Mon, 24 Oct 2022 14:29:46 +0200
In-Reply-To: <20221024140431.2e93dd2b@elisabeth> (Stefano Brivio's message of
	"Mon, 24 Oct 2022 14:04:31 +0200")
Message-ID: <87o7u1qu9x.fsf@pond.sub.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2

Stefano Brivio <sbrivio@redhat.com> writes:

> On Mon, 24 Oct 2022 13:00:09 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Markus Armbruster <armbru@redhat.com> writes:
>> 
>> > Cc: Stefano Brivio
>> >
>> > Laurent Vivier <lvivier@redhat.com> writes:
>> >  
>> >> On 10/21/22 07:48, Markus Armbruster wrote:  
>> >>> Laurent Vivier <lvivier@redhat.com> writes:
>> >>>   
>> >>>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend
>> >>>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.  
>> >>>
>> >>> Use cases?  
>> >>
>> >> This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt.  
>> 
>> [...]
>> 
>> >>> Could similar event signalling be useful for other kinds of netdev
>> >>> backends?  
>> >>
>> >> I was wondering, but it becomes more complicated to be generic.  
>> >
>> > Making something complicated and generic where a simpler special
>> > solution would do is the worst.
>> >
>> > Not quite as bad (but still plenty bad) is making a few special
>> > solutions first, then replace them all with a generic solution.
>> >
>> > I believe we should have a good, hard think on possible applications of
>> > a generic solution now.
>> >
>> > There is no need to hold back this series for that.
>> >
>> > If we conclude a generic solution is called for, we better replace this
>> > special solution before it becomes ABI.  Either by replacing it before
>> > we release it, or by keeping it unstable until we replace it.  
>> 
>> Stefano, any thoughts on this?
>
> Actually, to me, it already looks as generic as it can be: stream
> back-ends are the only ones connecting and disconnecting.
>
> I quickly tried to think about possible, similar events for other
> back-ends:
>
> - user: handled by libslirp, there's no connection, and probably not
>   much we can or want to export from libslirp itself
>
> - tap, bridge: the closest equivalent would be interfaces changing
>   states, but that's something that's also externally observable with a
>   netlink socket, in case one needs to know. And in any case, it's
>   logically very different from a connection or disconnection. If we
>   want events for that, they should have different names
>
> - vhost-user, vde: we could implement something similar if the need
>   arises, but it should logically have a different name
>
> - l2tpv3: stateless, same as datagram-oriented socket. No states, no
>   events to report, I guess.
>
> All in all, to me, NETDEV_STREAM_{,DIS}CONNECTED events here don't look
> very "special" or hackish.

Thanks!



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:45:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:45:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429080.679877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwpn-00072b-Et; Mon, 24 Oct 2022 12:45:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429080.679877; Mon, 24 Oct 2022 12:45:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwpn-00072U-BK; Mon, 24 Oct 2022 12:45:39 +0000
Received: by outflank-mailman (input) for mailman id 429080;
 Mon, 24 Oct 2022 12:45:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1omwpl-00072O-Op
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:45:37 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c02521da-5399-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 14:45:35 +0200 (CEST)
Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 08:45:32 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB5552.namprd03.prod.outlook.com (2603:10b6:a03:288::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 12:45:30 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022
 12:45:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c02521da-5399-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666615535;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=khTCeKKg3igYrCwYZzMCfblErcIm6btX80pM2C+fKIk=;
  b=KJQgf70nz7l73SEWomdjvFhRHotZX31riXqqqk+dRvSBhVjxU3EG1lVd
   +Jji1yXNZMlb4oPKGOlIrsPvHVzlsEiRI/AXYdgXUSLKegzkTSmRbMFM/
   AgHkr0vLLrOWdpCCf3Yruforsp/nh5m/JbjoVaKCrr0JBaOuE8CJT0YZf
   o=;
X-IronPort-RemoteIP: 104.47.56.169
X-IronPort-MID: 83389069
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3Asmh7AK8oFmMhnYH0pnArDrVtTnXEyJsLBUUsX?=
 =?us-ascii?q?f1Ep+oz8vayuhV8yJ73PPB8VjkiIqRVR6oqiDZNU05uCsLcQJaoguFu7eu1O?=
 =?us-ascii?q?NQhlI7w+waK85O8q+NT/4WP7pEhYAjnV2bCfSXkiylgmDPm+2Y7KJM0r73KU?=
 =?us-ascii?q?i3KZJgNjtvuiXfYxy441lej3EJ15mIn16KO7VXj8+59pjM87V2gwJxGxF0lK?=
 =?us-ascii?q?AS5kVS794+w+eJc581nPipOJ5oK0+E0VEPUuhv+1ohrqcrXbVu0muLFT8xM3?=
 =?us-ascii?q?jGowWoT/kXwteLcmL+7zA/kY81UNyYc8lhEV0AYc6rOOWvjehqex6WhlISmm?=
 =?us-ascii?q?SwnffiXELOEl7ec3OM3pdIdEmVByxJNwnPrSIH6u4bvUYIY12eIrEoZHMCg4?=
 =?us-ascii?q?MoVfBQYct9W1aGL7geBEqr49F0awPuz8w96n9UlTnyAHHo04Q/q0Q5OyD7I7?=
 =?us-ascii?q?BrETpXFQWDSOZDzHFz2JLXFMHqIDV89Wuns79D7Ta+ZAVudmEHfslmZ4NfTe?=
 =?us-ascii?q?bDuvprJ79FPy+fjf0TEzWhqdKQ4UcTjZzED2Lq3YHHpIdnvHi/H4K9xFs/rg?=
 =?us-ascii?q?/DJLzhtjOBkBW3LPqhMMO3KjXrYwXGLz0T2SAuUFN7SteQ/RkLn62py9xS53?=
 =?us-ascii?q?i2Q2sIeMxvitATNNYVl0linTsYQYV3g1lePMxVtHEGuVFMTn3/ttXa0rcynI?=
 =?us-ascii?q?/F+dlX5Cuj86kwwe6dokI81BOCtc7ZP8QHJHeju/cWauJ6VIL11tpan9pBb0?=
 =?us-ascii?q?EsgDNGXgh9/p/kYY/QR11BRvvTO6ICyXSxGBel85Gh2S+wCWuOwpVw5BbEGj?=
 =?us-ascii?q?wXdGZ5BA/B3hkKiqoYvMw04Un1P9VrBKUxA9SDErGwrwl5J3y+jGrzyIW0TQ?=
 =?us-ascii?q?wLpSrgp+u5Quoj4fWMjWKvQ64P7wSd8hILRFCzcdZmsbImFdJbta6Sduok80?=
 =?us-ascii?q?Ia4WZlYD5o/z6v7alLg5phOiqqWwgYORbvh3g6hpZdbv6k9IHiglohFRzBOt?=
 =?us-ascii?q?t2TlPH/+s2p0mSGeiFu1yWIPwbFIiPMFIVRoA9EmctDWKWYvu5RjxZ2wX7MU?=
 =?us-ascii?q?wdMUjNhM3aMfLF8ZUG3G47JYpwFfcRaeEbf52vWhoGV+hW+AahmmXgauVX+l?=
 =?us-ascii?q?YBbBctCe+oG75CVDdTo9rl4t2hb/9ZNkQ46Wcgu4mJezTeeXOgHhZZG2vMjk?=
 =?us-ascii?q?OJu1F4Z8EkiFpZ2LiM3xbV0zI55Wo/6dDx+f2swND+IV2nSxZKz3h0C7uMx+?=
 =?us-ascii?q?RIEh6R+zJu0XMho8mX+XWWJ91d+iFSUn47cIzmRbhgfEqFQoIWikLQfV8Y3/?=
 =?us-ascii?q?ZS4NhWsNOjvaurnvuRAKPvbc6mdTgB9RjqM1XVovwD0nvcTfT+PWnHRHAGxq?=
 =?us-ascii?q?u7ZQBL+WwVmlAjC6/A158Ct5MJOJFFTCvk+Rt+uaMBUiumpad4IqLtgH/NTm?=
 =?us-ascii?q?TVXSKG92JAqq6/ggfvvafCaBJKNiYcsGJxwfqnPTobvzefTJAiIiciDWYpJP?=
 =?us-ascii?q?QpDGZddjIov113Yyk0snEqJc6tZ3xz1qC1h/P0V7vGtg1RUI/m98GUBFNFz/?=
 =?us-ascii?q?4VGl40POHJ7lyYXOYbUN6kCxPVPUValAZwAxogrBoY73uE2uOz3AlRHWH8eX?=
 =?us-ascii?q?6sGpkO2lOUdgqIcwCfRbv/ccQURmoUio7LQKts4clgJbfwbma070771Kq03b?=
 =?us-ascii?q?P94TDsKMv3ZS5fCk19Y/vL+IkWdcohUU5IzZSM8GdRVsT7gv/0fqMXHiibn2?=
 =?us-ascii?q?uASJIMMFr9zTf1zfBbkinseU824dTjGa16O+778K/HVGy2l9SYK+MaN5hLES?=
 =?us-ascii?q?aX7d8OqqySLRjW1e/RkT+PFiilDzHXW2BHr1dspK0cz91a6T3ZEx21mLi6Bo?=
 =?us-ascii?q?ngLjfzB9ljZa7Nh0rTkSfMjDTIIi7AClHnYHS99X2z5v+UT9Nddz21CmnMuY?=
 =?us-ascii?q?PVQ/qrDL0oaHnwqj1iXvK8cuphaUF3JaKfXsjXeBDIAiVeE1F8P2sn3+bteN?=
 =?us-ascii?q?C32yyBn/qawhOzLwF+8KG2xtfZoUvpWlC3phj0oIwVT8JWttsW3h2HkX5Qiy?=
 =?us-ascii?q?XTs9YGvxdMzoOevKD3PaQamKWSQpiQyLRW7xSRmrSWtQsIeANSLJbfW9YBWN?=
 =?us-ascii?q?vy6FejbkvXzD3wJEiz7u0DI5T0VetSSXkI4Sk1FsF6q/ppMu5oQiIAo8Zhh0?=
 =?us-ascii?q?kiQhNfuy0DzYcYnIDvqAldGNN52fScKs8KrnbXH8qorxUCIaqpI9qA1HTxoc?=
 =?us-ascii?q?jPpyO5/GzJ9YAMAbZWK8VHDw5wPW5lr2IHoS4iLr6HBCXfpitd1JlgorBBC4?=
 =?us-ascii?q?7d4Y+tRwurYkxijXKheejK3Hz1GzyFAQbTxClCqZkvZ00mEcfEbNZ+6PprRe?=
 =?us-ascii?q?TSQDo78b9qQfAwWYecp0F4nuIGF/64RpbooDYBlOzkLkGuy6l5mUK2DsFZrP?=
 =?us-ascii?q?3Xl09mcJPkO4oFY?=
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="83389069"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NC97ugPIuJvhxIb6aGnp2HloaMCv2yIc39WVOwaZpEwsFocnWjDeXnRzaMdwTwBSbw+G6Yij2HOY8DZQ9CQhlfBpuAsAIeoOdxBhPh0XtJOHTiW05Q4ltMFH7ez2e4/aRo+2jccFd5BVwNgc5s/Bn4QRTvj44V+l3GnnhoTXxMyA1oWID7GyJJfcK228xYBgbTyIyonxqFSsnf9DfATahS/skxBFJ/80DywcG4wkcDvze2BERBTRmGkNZqBRvyVs8xfZVirBaqnFZPJClQImUalKF9iySBo7BqOzaXojv+cq63IrukTXrAYlxS40/bFY01WXOkKxBfj0W2+4pVXHyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CYglnLr7u2WVkJnTDNyIpIYcFDZjiMFM9S28GAh3mTI=;
 b=AxliQlc85rkJNtQQTfDYVSwB81zzsrzgF/FexS3waWlwho0XhIDXGUMPIt1+yTZuIg+reEYu3oh+7QzWNQIwFbaImcHAx3rkV1GjctvJj4w5McSjrR5wQdprFHazPDFVYwPhcbZpf11oKFx5KTyehhm6AeXTiT63vmWMnnhF4nRpakkevhoGoA9272MbSWqhD2C+KeQv/I/I/2SvvvYVJitkY5KtpZ7ciL6I4ZmchKXwP74UX1pSkup5lGslMLNVBtIfUrj+FKdc45kjHzXx+aBHR7lUR5aitUqC672td1MIq7okeh0ogdR1UwY/4RXIrbMbMuJHNgUv1vByeSZ5vA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CYglnLr7u2WVkJnTDNyIpIYcFDZjiMFM9S28GAh3mTI=;
 b=Nzi8levRgUtFuqkQ0eunSXAZxC0rgpNtkonLoRA/UiNfner2wFf6N9ipNieoGUPsxlUIGRw1/aky6jvzb88Rs2D16wTgX4nhyHzDyfBEUgvXFP2ofnWNHTsGnTh209U36knveTVE/bM4gW2TLYxJCCuEMNUlrZ2CjLRIqNlxGsc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 14:45:24 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH for-4.17 5/6] pci: do not disable memory decoding for
 devices
Message-ID: <Y1aI5Lbi3sysIZVv@Air-de-Roger>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-6-roger.pau@citrix.com>
 <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
X-ClientProxiedBy: LNXP265CA0073.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:76::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5552:EE_
X-MS-Office365-Filtering-Correlation-Id: 26605783-f963-41ba-af9f-08dab5bda214
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o3smJg+9ilzTLkMf7Bvrs2WHpca1CFIONYGJfs0JBuOI2me9Igo1yF8EEIRW13rXgokqKCTOl8Ql7tEwHl0FEEVukh8Xa/mj2QJRIdi/SWiBtgVzk1tQx4PwATQo2R2/IJ62ozO055P8FcKUqjXkynu81yXNlmqksKWuj9jVxF+ip+YExLyJcATHhTP69pbMhxJmqFeh65Fooj0OMvMhS2y+MoIXSSX7MWnmmcb1a9/PBnHkTEIMMSzlsgdUf7oLbcKGDleRPE6SFDeNEUtVITW0czkgB9JTY/A7ZE2rLyiYj6sxrO/VE/SFE2rZr2ipRTH+Ux466GAviY2c3rwDi6jykMOk69iyEFVsp2tzF9y33p7G2rVfyHAs6emcVQrWB4NkUB141nvxpyaWa6qGyKUqbSycO78bH4tJhjqB4+84zC0d0AV+neuUY2M0dTn/2bPu8y2uAkpFIvw0wrPiCk1sjkKpWHT7x1bH8q0ikc+0xnx2/N6QzUa1XYRQ9d+kOMuvWUfEYfXL84FYC7CtMd/FDYo2WNE/M1B8XztJSvf+zckvZsQ2jnLB9E0Em1G959FbpcirUJ3f6xgg7TKbSpasi3iJjaegUI48u4xuyx/A7sZ40PHUsc2rCxSJyq7tukMrDqnwkP1k9Wpi9F3JlkjtascrpMlj49CDsl4ZWs1vTn9QMVjWrl8TZxqSJmXTPQgwnEcrnEbObhPnFV0nVw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(136003)(366004)(346002)(376002)(396003)(451199015)(26005)(41300700001)(8936002)(6666004)(6916009)(5660300002)(9686003)(6512007)(66556008)(66946007)(66476007)(53546011)(85182001)(4326008)(8676002)(6506007)(2906002)(316002)(33716001)(82960400001)(38100700002)(186003)(86362001)(83380400001)(6486002)(478600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MzhDb1IzMGl3bk5VTVVCZFNoUVdaZHlTeHpzak5Hd0RvcmJFcHBFTE5GaXdw?=
 =?utf-8?B?d3lDaGE4YWV4TVBIeFpVdGFpK2FWYUFkNm13N1dOdE5PNXdOWmpTQ3pGdUZT?=
 =?utf-8?B?Y3VweCtZRmo5K1M2VWFHREdvSndaSGtzTlVBdVZBMXl4dzhvUGxLenUyb0xw?=
 =?utf-8?B?cmQ0NHF2TSt4eWRCeGtURllQdzdCY0ZucmkrVUtwWDlkdHFvaGNMb1krck1G?=
 =?utf-8?B?VTE1YndIQ3Jac2w1emE4L2Z1SWUraWcvdmg4Q244cU5OdHdicTUydjZBbVE2?=
 =?utf-8?B?WlFqVEtuZzMyeEVDeWNOZDhYY2lFemF4RzZzbmhKaFZvTEN2NXZESlVHb0NH?=
 =?utf-8?B?cEh6RTQrb3QxbnY3alQ5c080WG4yNzJZSmZrbFZYZnpXN3dzMHFqVDRwY0VR?=
 =?utf-8?B?TFhGSGdBR3JKaEZhRUpHcGhWTEdqL3dCNkZjRlVVU1ZuNmNldFJGZzBsdk95?=
 =?utf-8?B?bnkxQWllaEtKOEkrYlY0dFRyaDFaTTVYb3hUVEhHVGNyTWUzeXhpbEF3c2lE?=
 =?utf-8?B?RG1rc0wyQkxCTC85c0lRaktpUXdMQ0M4SU54eFQ2WGRjdStva0ZIZFlONjgx?=
 =?utf-8?B?c1g3TVI4WGhvNkhwdnBSLzJ3d0NCQUxvQ2ZJUDZtMkhWS0E3dHF3NTE1WEpC?=
 =?utf-8?B?N2hkN0tjUmlqeFY3ODR4TksrejlLVEtUSDhXUFczSVZWczFnWE5uNkdEME4r?=
 =?utf-8?B?anR3Nkg4YnYrUVZIRkFJQUdzTkpGbWpJeGR5WEU0dndVbEdrRzVuRW5BbldZ?=
 =?utf-8?B?SG10Wmd4VFVUTlp2Tm15c3dFdzBaZlp5a09JMEtoakd2aUdCY0RYc090cmdk?=
 =?utf-8?B?azZhNzlpNnV6MTVvY1huOFk5Qy9UTzA3eS95N0hLV3pSYW5QVWNjYTlGTmE4?=
 =?utf-8?B?bG9Xd2hJVXZzaFEzV3Zvb01vSkZTck1SNVZFazRCWkE0aTh1aHNNaHRuM0RM?=
 =?utf-8?B?UC9zRWIxZFowUnBvblRJejE0Y2taMkdJYWxUVi8xWFhGK2VnMFlXK1dWa3Z5?=
 =?utf-8?B?RDRXZ2VYQ21kVlBkYVJNQ0RONFNid0ZWSFFTTnhCdFpRTzQzYi9DUjNGS0hI?=
 =?utf-8?B?TVp3eWx1cEdqa0tnRm1aRU1wUjNFdndXUzMwMXgveDdMb0QxK0Z2Tks3bDI1?=
 =?utf-8?B?RVZnZXB6ZDlRV0Mwb3RFeFRnTVNhMlRjd2FBNXVxeWl1VzlUNVY4OEljdmZY?=
 =?utf-8?B?dVVyVGI2MnErOVhNYjN3SEpkNUM0ZHlReTkxR0x2cVNZVVE5b2dDLzQvUjFM?=
 =?utf-8?B?QW80QjhKaExHUHFYUDhNeFMyUVJUWHhhT0xjdTJuR2V3YkVWRnA0c25LZ0p2?=
 =?utf-8?B?S0lGNzYxRkRNaEpibVpidlNjMVBudVRuS3FCcXRjRlAyTVRhQmoyaXJtR05S?=
 =?utf-8?B?SzlGZ2VxWTE1UEpRYThPcFQyd1NFdDYrQVNWZkwxWkp1aUNhaXEwR1Y0YzBO?=
 =?utf-8?B?TkdIUUVKZXlUN3g1dVQyTGxXdE5MTUQzRUFuN0paNGVVeGlmWmpuaGY0L1RY?=
 =?utf-8?B?elBzbU5mRzlLQmRSdjFmTU9lVnVoL2VUL3psZ25KSWFiRWxNSVhlM1pVa1lH?=
 =?utf-8?B?b1d1anVKMUJjNnc4QVNudWgydGFSK3QrMWVudEV4OHMvT0I4V0RXdHdmNy9H?=
 =?utf-8?B?UWZERDNsZDhZVXZvMGN2ZUlHVnQ1T1F3MXlTWWFQL2pUTW5nUXFJcXB0ZS9s?=
 =?utf-8?B?cDd4RXlhLzVtMGZvRmlQblhSbHVhcy9jWTZlVUxaaDVrNit1Y3B6SExEM2hH?=
 =?utf-8?B?T1IvRmpRekowMzkwOE4wUEFmeDQ2dEF4bE9jaVRGM3h0R0JqWU5SVVdSVXJa?=
 =?utf-8?B?YS95NnlENzJSbmlzeWRIWUt3aFhWNW04R3pOaFltcHJvcVZLU0svWG9Qc1E2?=
 =?utf-8?B?UUQxTnhsOWgwcmJmNDgwUkZ6N2xnK1ZzTWdCMjNlc3hkMXBTbng1aXh2c0Ja?=
 =?utf-8?B?RGFQSTdBcnluenhGVkc5RnVzL2kxRWREVzk0MmNmVHk2SkJjY1VtZUxBRW5v?=
 =?utf-8?B?NkZDOCtpWmhEakZMYWtaQTFVczQ0ZGxMU01XNmtZOTIvTHIzclVmZUtJcnVz?=
 =?utf-8?B?OGkyaWx4OG9qWGkyRDZWWElXVnFzRVZnREF0bEpJcEhKNHFxMFpsVXJXMnEr?=
 =?utf-8?Q?bljOjXeHKNEdi5MGXRgqj9m0c?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26605783-f963-41ba-af9f-08dab5bda214
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 12:45:30.1726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nWCotFrGyAc3uTWovyDcYdgYPUMdzdzMW8bunqT1NJm1vdIxnRjxrmUQ79ZP1SXwJHq039GlNLM1yhsSSG/0jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5552

On Mon, Oct 24, 2022 at 01:19:22PM +0200, Jan Beulich wrote:
> On 20.10.2022 11:46, Roger Pau Monne wrote:
> > Commit 75cc460a1b added checks to ensure the position of the BARs from
> > PCI devices don't overlap with regions defined on the memory map.
> > When there's a collision memory decoding is left disabled for the
> > device, assuming that dom0 will reposition the BAR if necessary and
> > enable memory decoding.
> > 
> > While this would be the case for devices being used by dom0, devices
> > being used by the firmware itself that have no driver would usually be
> > left with memory decoding disabled by dom0 if that's the state dom0
> > found them in, and thus firmware trying to make use of them will not
> > function correctly.
> > 
> > The initial intent of 75cc460a1b was to prevent vPCI from creating
> > MMIO mappings on the dom0 p2m over regions that would otherwise
> > already have mappings established.  It's my view now that we likely
> > went too far with 75cc460a1b, and Xen disabling memory decoding of
> > devices (as buggy as they might be) is harmful, and reduces the set of
> > hardware on which Xen works.
> > 
> > This commits reverts most of 75cc460a1b, and instead adds checks to
> > vPCI in order to prevent misplaced BARs from being added to the
> > hardware domain p2m.
> 
> Which makes me wonder: How do things work then? Dom0 then still can't
> access the BAR address range, can it?

It does allow access on some situations where the previous arrangement
didn't work because it wholesale disabled memory decoding for the
device.

So if it's only one BAR that's misplaced the rest will still get added
to the dom0 p2m and be accessible, because memory decoding won't be
turned off for the device.

> Plus with this adjustment, is
> ...
> 
> >  Signaling on whether BARs are mapped is tracked
> > in the vpci structure, so that misplaced BARs are not mapped, and thus
> > Xen won't attempt to unmap them when memory decoding is disabled.
> > 
> > This restores the behavior of Xen for PV dom0 to the state it was
> > previous to 75cc460a1b, while also introducing a more contained fix
> > for the vPCI BAR mapping issues.
> 
> ... this (in particular "restores the behavior") a valid description
> of this change?

Yes, it restores the previous behavior for PV dom0, as memory decoding
is no longer turned off for any devices regardless of where the BARs
are positioned.

> > Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > AT Citrix we have a system with a device with the following BARs:
> > 
> > BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
> > BAR [0, 0x1fff] -> not positioned, outside host bridge window
> > 
> > And memory decoding enabled by the firmware.  With the current code
> > (or any of the previous fix proposals), Xen would still disable memory
> > decoding for the device, and the system will freeze when attempting to
> > set EFI vars.
> 
> Isn't the latter (BAR at address 0) yet another problem?

It's a BAR that hasn't been positioned by the firmware AFAICT.  Which
is a bug in the firmware but shouldn't prevent Xen from booting.

In the above system address 0 is outside of the PCI host bridge
window, so even if we mapped the BAR and memory decoding for the
device was enabled accessing such BAR wouldn't work.

> I have to admit
> that I'm uncertain in how far it is a good idea to try to make Xen look
> to work on such a system ...

PV dom0 works on a system like the above prior to c/s 75cc460a1b, so I
would consider 75cc460a1b to be a regression for PV dom0 setups.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:49:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:49:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429085.679887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwtf-0007el-Uj; Mon, 24 Oct 2022 12:49:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429085.679887; Mon, 24 Oct 2022 12:49:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwtf-0007ee-Rs; Mon, 24 Oct 2022 12:49:39 +0000
Received: by outflank-mailman (input) for mailman id 429085;
 Mon, 24 Oct 2022 12:49:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1omwte-0007eW-6J
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:49:38 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2040.outbound.protection.outlook.com [40.107.220.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4fba2e48-539a-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:49:36 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CH2PR12MB4921.namprd12.prod.outlook.com (2603:10b6:610:62::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 12:49:31 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 12:49:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fba2e48-539a-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Wg7ULXFWVksvPXrzSgdQXRUfAFQBsBHO+nJhdGfRSsQ6wE5066UqPtdvmSMuZ1K+8hfIuwlS+Cbz82XMXtA42pFCRnzLUePebgd5OqHGCLqsjYclmjRimRgLiYlcl0zMZ3QZj1meq28q55AihaHrj13boO6aIT1OeFUvlXOuGPhNjKZkxyCyjk6PjXhQsNgL7alf7ExbGJqg/puFDH3+Q7x9KLFuDDgzUD5UzKRF9zK28nSZhsmfUQQ0w1wVgsvZzCuOxkjDaRfiaFPuGOkOfP+iNblslEA3s2bSCO2ep84czqdALppM+OLN4r7DD1O3lsPYbBFBallzUggqzlLCzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U2E6jJtujNJaUdC56zk3jKCTfbugn5oe+esTUanRLHw=;
 b=aPAlGCTspb/WzLuY1AWYEn/lVUq0gWH4+WKFjsT+roIZIuah5TPeECAbmTakaA1xrkQDN+GHVegB5twzao3N3AkD/EaO/0l9YSsE5/g6emY2wLScYeG6pmRzvK9g6jfeICusIs2+xoIL8JJ/fObMk+V0PtbNSxND5Kltyr4f3gjehHPJZIyKzDcqfwsvPDfqyoq0HNHeltotRsZM2z8zRjyjqZAtPAWykNXdklmUyyn2GCY3dOdIclxGDH9hhfAh/Qpg/IjKSjk3GxgLvTjKPevNznCdZxgZFAcSqErXD2iWCDyvcAUgEmwFWJi8WedNmdcAzW3PMP1Yi3pjTNJrzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U2E6jJtujNJaUdC56zk3jKCTfbugn5oe+esTUanRLHw=;
 b=J0ckd3m26xP26tMt3Jdnj1zkGkzl7uaohjcZawowrMR+UGQohxQiZ8AWqtzAro/bNkQgbU0UyjRHXH+HiK7/HPD+enrR4REaf2PvOmJc/rlbCEtRCnpeqE2Gy65t4R+sKdbHC/jOmF8oba64s8eIuGUdjYiSeUBkK/4Bsv3Rz4E=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <a27873a3-3697-9a67-16aa-f4340dc622aa@amd.com>
Date: Mon, 24 Oct 2022 13:49:26 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for
 AArch32
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-4-ayankuma@amd.com>
 <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
 <e952fcd7-bab6-68ed-d884-6505e529a073@amd.com>
 <b0b4fc69-3da3-3229-77d9-9fe0f4bf1ec3@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <b0b4fc69-3da3-3229-77d9-9fe0f4bf1ec3@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0411.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::20) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH2PR12MB4921:EE_
X-MS-Office365-Filtering-Correlation-Id: 1c943a36-8dd6-48d7-91c8-08dab5be31c5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5AtKRWquLlixidaK7TW7290PIsqqwpZIAqHecIIj/h6JdXLh6jA18Mh6nXs6rE0L1Y2cj64P9313GkwMxzgcUGIL/EfYQJlXZN9OmyJyhNKfgeEwHK49XX5ZxKdYhIQm6HG667IvEGjlSxi2vhkAiITogpwqLPZuf2t2dlREbFLO6dAqFFD2lGilL5MEGxGWeZjymjJqjlRRvRf7Yo8nHb66dHHnZc/S5xV+sZxnP6U8hsMIGtTavI5MLtCB7bQZgPNqPNqyo0HFGGZVDDsyAzw0UIkbl3dtQdIlNiWN57XEISZKhq7up505gm6Erf7NT8X2iOMlQ8NKbytUs7191DGPJSDMcJFJrXI4ViNs6xVbbPZt4nKwwrMHfTorkQfiT2iW5RqdnxRcmChcUPg35F90UwQ4JxKbLznGuszBKP6b1Tc19hIWDOZvD1ITdL4uY6hywCRlft108JU4Qzuz35ZyGXAzo8Ds+1K2xBfqt9rXeFucFwIxFZmGaRTBbb57SegqfGje0gA8NOrAHiP1FrFEv+VIJ5/Wja/wxHDWtZ+V5ddAsxwt2654+G4Y0Ehk8B5hx2z/kLReZs4riCtvkp+5tOFu9PkGxOfZni4ktPkCXUhndkl2acRriVtRpuQgUJIUzmWcI8fYRcd3Vzhai+C1yWm5Wa2gwdeApaSOzYNNo/bvmzEXNTLHzRmmAl/zMhuqyzo1i/jY2NH0Nx7QuAlF2QgrELaZ+pIj1YCLJPz/hABrWA6i0vrlOHDEe6/Ae6Q4FtvsOar2tMXKMkHUJ1Vj2JuCL+rqVIeIGJBhEPY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(396003)(39860400002)(376002)(136003)(451199015)(31696002)(83380400001)(6486002)(31686004)(478600001)(53546011)(66946007)(66556008)(6666004)(4326008)(36756003)(6506007)(8676002)(6512007)(41300700001)(26005)(8936002)(5660300002)(38100700002)(2906002)(2616005)(186003)(66476007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Sm5TTU14NWVWOUNvaVpReFVmaXhZVXdnbXAyL2t1UTEyR3BybitSR2Q3WVlL?=
 =?utf-8?B?eDJqTDVUbXkzV0gxWFBOQ2liR3ZjeUlvckwxQzgzMGNVRktMSU1WY2djOGZ3?=
 =?utf-8?B?cFN4aVIwQnFFMG5taFArbHA5YkZIMlZWUnBOWWh4NE5LcEJkNm0zMVh0a2Vh?=
 =?utf-8?B?dUdtSjZ5SXRDT0ZnR1Y1dUloSW1aVkVPTFFPUFNGWGRpcXM5SjB3SmxqRDZG?=
 =?utf-8?B?MFZpTlBTQS9JSzhwN1NYT2hua2FoLzkrT2tLMm1BNGFZSGN4RlZ2Njl4WlRG?=
 =?utf-8?B?MVFKY1l2Sm9qaWxrSGlsamF0eWpMUGFEbDRSSWpKNE1TOXJta1I5Nm1CU0xS?=
 =?utf-8?B?RldZbEw2aEtURzk5dVBoaXBEeGs2TldKQnFidmlzRzZhUGQ4VUZPajF3NVFz?=
 =?utf-8?B?YnUxaG1kLzhFOVYrUnpoMlZVT0Z6dVEvNzZWb1hmWDBxRGkybnd4Ykh1SVhN?=
 =?utf-8?B?eVR3N3pqVW5GSTE5dVlGN2F3MkhFelhBWTdlZWI0OElhZGRBUlN4VTMwOFY1?=
 =?utf-8?B?N2ZnZjdTYjVjNjYxRzZqbTRudGtuUGxLUHFSRWhFaWh0RzcrWmp4V2Rkd3Zw?=
 =?utf-8?B?MU9nRThjMzdoQUJ6VEdhK0szVVJwYVIzdVlqVGpOeWIydGlpTGFaZUpJWlB2?=
 =?utf-8?B?SXFOWStDVnphVVFqMUJ6N1lYcmRIR2g4Mis1aVB0RFgxM2RQa0N1eW92WFNG?=
 =?utf-8?B?aUZUTVZUVm96azVBVzQxZU5ubjZSSm15VjdxVEFYZFQwc0dlbWsvKzM4bUhs?=
 =?utf-8?B?a0ZoNWlSbHkySUhNL0x3QUJqY0pJTDkwZFZrVzJVdmJYY2RxVkgxVnZsZ20v?=
 =?utf-8?B?UCsxaWNIelFtRFVMc1RhR080VFpxTzBINktoZnBkRUlwVjR0UlN3eXNXSE9p?=
 =?utf-8?B?QnRCREo4ZUhDaWlDUVJiZll3QVRpenJ2dnBWTHhQbUduUXZuWXJrUDZkRGVk?=
 =?utf-8?B?cGViM1AyVDhESlFXbGFjcHZSMDRaREZIN0pQTVY4UzBSSkREMzRkOU1PWFpF?=
 =?utf-8?B?dS94bEtnZ3prdzUxNGo2b0tHM3dVK2dwQXIwc2VuMVNiUmtmamJjc1JSS0Fi?=
 =?utf-8?B?Q05sbkRCY20zV0p4OUhkTVVLd1A3bUIxd0hSaGoxKzNjb1gwYTJvRm1xN1Zx?=
 =?utf-8?B?OXFpTXRnNFZSWS9abHRqZkxMSno2SWw3VG1pcysxUUJOWUxwMWUyS1d1K1Bt?=
 =?utf-8?B?ZzJCeENOd0Z2NmZVL0V0Z1lHQVRiYU8vRmdHbG9ZR1N6Y2lKcC9IRTYrelhK?=
 =?utf-8?B?cHAyaHBtOW1KamM5c2JLUUNCT1k2ZmNLVWhmT1pvTi9QcEt4YWd3Ui84UVNk?=
 =?utf-8?B?UnA3M2kwRnBicERUWU9EQWdOMWZzNWtmdnFZWjdpOEN1UytWaGdyYkg5aUg1?=
 =?utf-8?B?MkZvc1dDKzYrYVhFRnA5T3Rpb2pJdFp4WlQ5RHpMZThlTlBZZkowMCtDSlNJ?=
 =?utf-8?B?S2Nnb1NhVnFraVlFSWpiWDhNUjY2cTJhOWtmUStaWFdjanpmd3RKbHQzRk1r?=
 =?utf-8?B?NWF5WkVRRDhTV2htSGtaK0dha2hkZkJZbVZIa0VtWEh3TENGMm5CN2JGQWJX?=
 =?utf-8?B?QUhYSFBxc2ozQWJWb1lxV1BwWDliV2ZSZTFhaU1CS3JHUHBidFdPeTg0WWZv?=
 =?utf-8?B?R3N1ckdYSjFiWUFzVjI4Y1hVeEJjZUNCekF6OU1qbVpRNFV2dHZZWmxWVVQ3?=
 =?utf-8?B?b1F5VC9BaUxwSnRTWEEweW1wRFl1bzNHZ1A4dlYwWFNxT2h6Z1BDVXgzYXhF?=
 =?utf-8?B?dGsvQzJJV0hRNFVJVkZjUlBleWZCZk1xTE53S2FZbUN0U2h5VUFOTUhscE1r?=
 =?utf-8?B?R3RlUHVZTTBERlVwSnZtb1ZweVZVcmRFQkp4RjZmSzI2VFlWakxQWWdIWW1Q?=
 =?utf-8?B?WEFSdG1XTC9EYThZa3NCZGVHdFNXQlFNYng0aXFKTDloWFlnb3VFTkNFWmpy?=
 =?utf-8?B?aWlmanNXQTdpWjFQZ2ZaTGJHaW9PMXBiWkZwUnZTbGQzOVVLZldqUm5HbGJr?=
 =?utf-8?B?Yy90c2FScmtjaUU3VTVoZkNheWRuYlEvQW5nU1B0VTRsNFhzd1BZdnlCTUVx?=
 =?utf-8?B?amx6U2xvTjNzVUdxTmI0N3BGT0tKNnFOd3gwemphbEpzSFpoRWt1Ly9CbWJK?=
 =?utf-8?Q?JU0tA5/4c7J332oyvZt2qWAPn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c943a36-8dd6-48d7-91c8-08dab5be31c5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 12:49:31.1510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QtLqxbpBBLtyMnWm0nQOV8D5OH8HPxKaFgTrS+p0I0YAfcfsdYjPI6Wd/tMYy2QY0oYp5Plmt05ny62iAf8Q0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4921


On 24/10/2022 12:01, Julien Grall wrote:
>
>
> On 24/10/2022 11:47, Ayan Kumar Halder wrote:
>>
>> On 22/10/2022 11:13, Julien Grall wrote:
>>> Hi Ayan,
>>
>> Hi Julien,
>>
>> I need some clarification.
>>
>>>
>>> Title: The code you are modifying below is not GICv3 specific. I 
>>> would suggest the following title:
>>>
>>> xen/arm: vreg: Support vreg_reg64_* helpers on Aarch32
>>>
>>> On 21/10/2022 16:31, Ayan Kumar Halder wrote:
>>>> In some situations (eg GICR_TYPER), the hypervior may need to emulate
>>>> 64bit registers in aarch32 mode. In such situations, the hypervisor 
>>>> may
>>>> need to read/modify the lower or upper 32 bits of the 64 bit register.
>>>>
>>>> In aarch32, 64 bit is represented by unsigned long long. Thus, we need
>>>> to change the prototype accordingly.
>>>>
>>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>>> ---
>>>>   xen/arch/arm/include/asm/vreg.h | 23 ++++++++---------------
>>>>   1 file changed, 8 insertions(+), 15 deletions(-)
>>>>
>>>> diff --git a/xen/arch/arm/include/asm/vreg.h 
>>>> b/xen/arch/arm/include/asm/vreg.h
>>>> index f26a70d024..ac6e702c5c 100644
>>>> --- a/xen/arch/arm/include/asm/vreg.h
>>>> +++ b/xen/arch/arm/include/asm/vreg.h
>>>> @@ -95,7 +95,7 @@ static inline bool vreg_emulate_sysreg(struct 
>>>> cpu_user_regs *regs, union hsr hsr
>>>>    * Note that the alignment fault will always be taken in the guest
>>>>    * (see B3.12.7 DDI0406.b).
>>>>    */
>>>> -static inline register_t vreg_reg_extract(unsigned long reg,
>>>> +static inline register_t vreg_reg_extract(unsigned long long reg,
>>>>                                             unsigned int offset,
>>>>                                             enum dabt_size size)
>>>>   {
>>>> @@ -105,7 +105,7 @@ static inline register_t 
>>>> vreg_reg_extract(unsigned long reg,
>>>>       return reg;
>>>>   }
>>>>   -static inline void vreg_reg_update(unsigned long *reg, 
>>>> register_t val,
>>>> +static inline void vreg_reg_update(unsigned long long *reg, 
>>>> register_t val,
>>>>                                      unsigned int offset,
>>>>                                      enum dabt_size size)
>>>>   {
>>>> @@ -116,7 +116,7 @@ static inline void vreg_reg_update(unsigned 
>>>> long *reg, register_t val,
>>>>       *reg |= ((unsigned long)val & mask) << shift;
>>>>   }
>>>>   -static inline void vreg_reg_setbits(unsigned long *reg, 
>>>> register_t bits,
>>>> +static inline void vreg_reg_setbits(unsigned long long *reg, 
>>>> register_t bits,
>>>>                                       unsigned int offset,
>>>>                                       enum dabt_size size)
>>>>   {
>>>> @@ -126,7 +126,7 @@ static inline void vreg_reg_setbits(unsigned 
>>>> long *reg, register_t bits,
>>>>       *reg |= ((unsigned long)bits & mask) << shift;
>>>>   }
>>>>   -static inline void vreg_reg_clearbits(unsigned long *reg, 
>>>> register_t bits,
>>>> +static inline void vreg_reg_clearbits(unsigned long long *reg, 
>>>> register_t bits,
>>>>                                         unsigned int offset,
>>>>                                         enum dabt_size size)
>>>>   {
>>>> @@ -149,7 +149,7 @@ static inline void 
>>>> vreg_reg##sz##_update(uint##sz##_t *reg,             \
>>>>                                            register_t 
>>>> val,                \
>>>>                                            const mmio_info_t 
>>>> *info)       \
>>>> { \
>>>> -    unsigned long tmp = 
>>>> *reg;                                           \
>>>> +    unsigned long long tmp = 
>>>> *reg;                                      \
>>>> \
>>>>       vreg_reg_update(&tmp, val, info->gpa & 
>>>> (offmask),                   \
>>>> info->dabt.size);                                   \
>>>> @@ -161,7 +161,7 @@ static inline void 
>>>> vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
>>>>                                             register_t 
>>>> bits,              \
>>>>                                             const mmio_info_t 
>>>> *info)      \
>>>> { \
>>>> -    unsigned long tmp = 
>>>> *reg;                                           \
>>>> +    unsigned long long tmp = 
>>>> *reg;                                      \
>>>> \
>>>>       vreg_reg_setbits(&tmp, bits, info->gpa & 
>>>> (offmask),                 \
>>>> info->dabt.size);                                  \
>>>> @@ -173,7 +173,7 @@ static inline void 
>>>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>>>                                               register_t 
>>>> bits,            \
>>>>                                               const mmio_info_t 
>>>> *info)    \
>>>> { \
>>>> -    unsigned long tmp = 
>>>> *reg;                                           \
>>>> +    unsigned long long tmp = 
>>>> *reg;                                      \
>>>> \
>>>>       vreg_reg_clearbits(&tmp, bits, info->gpa & 
>>>> (offmask),               \
>>>> info->dabt.size);                                \
>>>> @@ -181,15 +181,8 @@ static inline void 
>>>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>>>       *reg = tmp; \
>>>>   }
>>>>   -/*
>>>> - * 64 bits registers are only supported on platform with 64-bit long.
>>>> - * This is also allow us to optimize the 32 bit case by using
>>>> - * unsigned long rather than uint64_t
>>>> - */
>>>
>>> The comment above explain why we never use uint64_t in the helpers 
>>> above. IIRC, the compiler would end up to use 2 registers on AArch32 
>>> even for the vreg_reg32_* helpers. I wanted to avoid that and would 
>>> like like to today. Can you check the code generated?
>>
>> I am not sure I understood the comment very well.
>>
>> With this patch, the disassembly is as follows :-
>>
>>          vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
>>    28124c:   e597000c    ldr r0, [r7, #12]
>> VREG_REG_HELPERS(32, 0x3);
>>    281250:   e5d52002    ldrb    r2, [r5, #2]
>>    281254:   e1a02322    lsr r2, r2, #6
>>      unsigned long mask = VREG_REG_MASK(size);
>
> Hmmm... Shouldn't this be "unsigned long long"?

The function looks like

static inline void vreg_reg_update(unsigned long long *reg, register_t val,
                                    unsigned int offset,
                                    enum dabt_size size)
{
     unsigned long mask = VREG_REG_MASK(size);
     int shift = offset * 8;

     *reg &= ~(mask << shift);
     *reg |= ((unsigned long)val & mask) << shift;
}

>
>>    281258:   e3a03008    mov r3, #8
>>    28125c:   e1a03213    lsl r3, r3, r2
>>    281260:   e2633020    rsb r3, r3, #32
>>    281264:   e3e02000    mvn r2, #0
>>    281268:   e1a02332    lsr r2, r2, r3
>> VREG_REG_HELPERS(32, 0x3);
>>    28126c:   e5953010    ldr r3, [r5, #16]
>>    281270:   e2033003    and r3, r3, #3
>>      int shift = offset * 8;
>>    281274:   e1a03183    lsl r3, r3, #3
>> VREG_REG_HELPERS(32, 0x3);
>>    281278:   e59013f0    ldr r1, [r0, #1008] ; 0x3f0
>>    28127c:   e1c11312    bic r1, r1, r2, lsl r3
>>      *reg |= ((unsigned long)val & mask) << shift;
>>    281280:   e0022009    and r2, r2, r9
>> VREG_REG_HELPERS(32, 0x3);
>>    281284:   e1813312    orr r3, r1, r2, lsl r3
>>    281288:   e58033f0    str r3, [r0, #1008] ; 0x3f0
>>          v->domain->arch.vgic.ctlr &= GICD_CTL_ENABLE;
>>    28128c:   e597200c    ldr r2, [r7, #12]
>>    281290:   e59233f0    ldr r3, [r2, #1008] ; 0x3f0
>>    281294:   e2033001    and r3, r3, #1
>>    281298:   e58233f0    str r3, [r2, #1008] ; 0x3f0
>>
>> Without the patch (ie original code) , the disassembly is :-
>>
>>          vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
>>    27f8f4:   e597000c    ldr r0, [r7, #12]
>> VREG_REG_HELPERS(32, 0x3);
>>    27f8f8:   e5d52002    ldrb    r2, [r5, #2]
>>    27f8fc:   e1a02322    lsr r2, r2, #6
>>      unsigned long mask = VREG_REG_MASK(size);
>>    27f900:   e3a03008    mov r3, #8
>>    27f904:   e1a03213    lsl r3, r3, r2
>>    27f908:   e2633020    rsb r3, r3, #32
>>    27f90c:   e3e02000    mvn r2, #0
>>    27f910:   e1a02332    lsr r2, r2, r3
>> VREG_REG_HELPERS(32, 0x3);
>>    27f914:   e5953010    ldr r3, [r5, #16]
>>    27f918:   e2033003    and r3, r3, #3
>>      int shift = offset * 8;
>>    27f91c:   e1a03183    lsl r3, r3, #3
>>      *reg &= ~(mask << shift);
>>    27f920:   e5901400    ldr r1, [r0, #1024] ; 0x400
>>    27f924:   e1c11312    bic r1, r1, r2, lsl r3
>>      *reg |= ((unsigned long)val & mask) << shift;
>>    27f928:   e0022009    and r2, r2, r9
>>    27f92c:   e1813312    orr r3, r1, r2, lsl r3
>> VREG_REG_HELPERS(32, 0x3);
>>    27f930:   e5803400    str r3, [r0, #1024] ; 0x400
>>          v->domain->arch.vgic.ctlr &= GICD_CTL_ENABLE;
>>    27f934:   e597200c    ldr r2, [r7, #12]
>>    27f938:   e5923400    ldr r3, [r2, #1024] ; 0x400
>>    27f93c:   e2033001    and r3, r3, #1
>>    27f940:   e5823400    str r3, [r2, #1024] ; 0x400
>>
>> Sorry, I can't spot the difference. :(
>
> If there is no difference, then it is a good sign. I was worried that 
> the compiler would end up to use "strd/ldrd" which would result to 
> more register allocations and therefore inefficient code.
>
> But see above.
>
>>
>> I had a look at commit 423e9ecdc26c4b40c8db1fcc63b3655463c29976 which 
>> introduced this. But I could not make out the reason from the commit 
>> message.
>
> The reasoning would be to show that the assembly is either the same or 
> no worse that then existing one with a few compilers.
>
>>
>>>
>>> For other options, I would consider to either:
>>>   1) Fold vreg_reg_* in the macros.
>>
>> Can you explain this option a bit ?
>
> At the moment, we have generic helpers for vreg_reg_*. They are only 
> called within the helper generated by VREG_REG_HELPERS().
>
> If we make those helpers size specific, then the only the 64-bit 
> helpers would use uint64_t local variables.
>
> As they are only called in one place, we could fold them in the 
> existing helpers.

Just to make sure, I understand this. The code would look like below


#define VREG_REG_HELPERS(type, offmask)                         \

static inline void vreg_reg_##type##_update(type *reg, register_t val, 
        \

     const mmio_info_t *info)        \

{                                                  \

unsigned long mask = VREG_REG_MASK(size);                     \

unsigned int offset = info->gpa & (offmask);                             
       \

int shift = offset * 8;                                            \

*reg &= ~(mask << shift);                                            \
*reg |= ((unsigned long)val & mask) << shift;                         
           \

}


#define vreg_reg_update(reg, val, info)     \

do {                        \

     if (sizeof(reg) == 4)                 \

           vreg_reg_uint32_t_update(reg, val, info);                \

     else if (sizeof(reg) == 8)               \

         vreg_reg_uint64_t_update(reg, val, info);              \

     else                           \

         BUG();                        \

} while(0);                           \


Similar implementation will be for vreg_reg_clearbits(), 
vreg_reg_setbits() and vreg_reg_extract()


VREG_REG_HELPERS(uint32_t, 0x3);

VREG_REG_HELPERS(uint64_t, 0x7);


And the functions would be invoked as follows :-

vreg_update(&priority, r, info);

Is this the correct understanding ?

>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:51:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:51:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429090.679899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwv7-0000cz-E5; Mon, 24 Oct 2022 12:51:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429090.679899; Mon, 24 Oct 2022 12:51:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwv7-0000co-BN; Mon, 24 Oct 2022 12:51:09 +0000
Received: by outflank-mailman (input) for mailman id 429090;
 Mon, 24 Oct 2022 12:51:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DVco=2Z=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1omwv5-0000ch-Nv
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:51:07 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 85b69ed6-539a-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:51:06 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C93D361257;
 Mon, 24 Oct 2022 12:51:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6FA0C433D7;
 Mon, 24 Oct 2022 12:51:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85b69ed6-539a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666615864;
	bh=Ni3aGGiJlZu9KJ4N6LRidb1HrO9afGdBuz4Hc+sk+7o=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=XkDDpBvk3m6XzfDi6bZn8+6Pz04RhH12WWAc6LwqhLRNinUdBjaqdg8tiFhrJ9a3f
	 E5XZbUC9lphaAO2nd0x8RD2hG/026m5/rkI1PYmkbuTnebRPDA1cqFoo0KGmv3+ols
	 0N1vBndWfaGcH8yunl4dh0iJ6Eujs/JiSQUR4o8o=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.15 412/530] x86/entry: Work around Clang __bdos() bug
Date: Mon, 24 Oct 2022 13:32:36 +0200
Message-Id: <20221024113103.742966550@linuxfoundation.org>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221024113044.976326639@linuxfoundation.org>
References: <20221024113044.976326639@linuxfoundation.org>
User-Agent: quilt/0.67
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kees Cook <keescook@chromium.org>

[ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]

Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
offset. Work around this by using a direct assignment of an empty
instance. Avoids this warning:

../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
tribute-warning]
                        __write_overflow_field(p_size_field, size);
                        ^

which was isolated to the memset() call in xen_load_idt().

Note that this looks very much like another bug that was worked around:
https://github.com/ClangBuiltLinux/linux/issues/1592

Cc: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: xen-devel@lists.xenproject.org
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Link: https://lore.kernel.org/lkml/41527d69-e8ab-3f86-ff37-6b298c01d5bc@oracle.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/x86/xen/enlighten_pv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 133ef31639df..561aad13412f 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -759,6 +759,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
 	static DEFINE_SPINLOCK(lock);
 	static struct trap_info traps[257];
+	static const struct trap_info zero = { };
 	unsigned out;
 
 	trace_xen_cpu_load_idt(desc);
@@ -768,7 +769,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
 	out = xen_convert_trap_info(desc, traps, false);
-	memset(&traps[out], 0, sizeof(traps[0]));
+	traps[out] = zero;
 
 	xen_mc_flush();
 	if (HYPERVISOR_set_trap_table(traps))
-- 
2.35.1





From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:55:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:55:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429098.679910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwzj-0001L1-22; Mon, 24 Oct 2022 12:55:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429098.679910; Mon, 24 Oct 2022 12:55:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omwzi-0001Ku-VQ; Mon, 24 Oct 2022 12:55:54 +0000
Received: by outflank-mailman (input) for mailman id 429098;
 Mon, 24 Oct 2022 12:55:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Czee=2Z=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1omwzi-0001Kl-2R
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:55:54 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3114cc96-539b-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:55:53 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6B2691FD8E;
 Mon, 24 Oct 2022 12:55:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1898813A79;
 Mon, 24 Oct 2022 12:55:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EEmOBFiLVmOeagAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 24 Oct 2022 12:55:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3114cc96-539b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666616152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=doG6HZnZCoVKaGw+wo/WVrDGL+eOY9VhqR01LjBiG/k=;
	b=HfxIHM2+JmZUl9g4XsZz67Ez89BG4CQew93Ibamd0l2IDF3ydJyH43+tX8csurg9RxBGFc
	IW+os+DmG7gY+T3mqa/3GQt87PE+wZNr91AROX7E2pGrtKnJ0uM8O/GxEeRoCDGGolffcV
	/5+K+/KQ9Vigv6UUppntuZaQGg/imcI=
Message-ID: <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
Date: Mon, 24 Oct 2022 14:55:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Content-Language: en-US
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------S7L73GZ7QwBj4qRYR6bALgT0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------S7L73GZ7QwBj4qRYR6bALgT0
Content-Type: multipart/mixed; boundary="------------8nAfY0HuTJjjgFAPh5D6KU35";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
Message-ID: <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
In-Reply-To: <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>

--------------8nAfY0HuTJjjgFAPh5D6KU35
Content-Type: multipart/mixed; boundary="------------cFpTspK8fz03bLJT6EfskpoB"

--------------cFpTspK8fz03bLJT6EfskpoB
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMTAuMjIgMTM6NTYsIFNyZWVrYW50aCBSZWRkeSB3cm90ZToNCj4gT24gU3VuLCBP
Y3QgMjMsIDIwMjIgYXQgNjo1NyBBTSBCYXJ0IFZhbiBBc3NjaGUgPGJ2YW5hc3NjaGVAYWNt
Lm9yZz4gd3JvdGU6DQo+Pg0KPj4gT24gMTAvMjEvMjIgMDI6MjIsIFNhbHZhdG9yZSBCb25h
Y2NvcnNvIHdyb3RlOg0KPj4+IFdlIGdvdCB0aGUgZm9sbG93aW5nIHJlcG9ydCBpbiBEZWJp
YW4gYWZ0ZXIgYW4gdXBkYXRlIGZyb20gNS4xMC4xNDAgdG8NCj4+PiB0aGUgY3VycmVudCA1
LjEwLjE0OS4gRnVsbCBxdW90aW5nIGJlbG93IChmcm9tDQo+Pj4gaHR0cHM6Ly9idWdzLmRl
Ymlhbi5vcmcvMTAyMjEyNikuIERvZXMgdGhpcyByaW5nIHNvbWUgYmVsbCBhYm91dCBrbm93
bg0KPj4+IHJlZ3Jlc3Npb25zPw0KPj4NCj4+IE9ubHkgdGhyZWUgbXB0M3NhcyBjaGFuZ2Vz
IGFyZSBuZXcgaW4gdjUuMTAuMTQ5IGNvbXBhcmVkIHRvIHY1LjEwLjE0MDoNCj4+ICQgZ2l0
IGxvZyAtLWZvcm1hdD1vbmVsaW5lIHY1LjEwLjE0MC4udjUuMTAuMTQ5DQo+PiAyYjlhYmEw
YzVkNThlMTQxZTMyYmIxYmI0YzdjZDkxZDE5ZjA3NWI4IHNjc2k6IG1wdDNzYXM6IEZpeCBy
ZXR1cm4gdmFsdWUgY2hlY2sgb2YgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCkNCj4+IGU3ZmFm
ZWY5ODMwYzRhMDFlNjBmNzZlMzg2MGE5YmVmMDI2MjM3OGQgc2NzaTogbXB0M3NhczogRm9y
Y2UgUENJZSBzY2F0dGVybGlzdCBhbGxvY2F0aW9ucyB0byBiZSB3aXRoaW4gc2FtZSA0IEdC
IHJlZ2lvbg0KPj4gZWExMGE2NTJhZDJhZTJjZjNlY2VkNmY2MzJhNWM5OGYyNjcyNzA1NyBz
Y3NpOiBtcHQzc2FzOiBGaXggdXNlLWFmdGVyLWZyZWUgd2FybmluZw0KPj4NCj4+IFNyZWVr
YW50aCBhbmQgU3VnYW5hdGgsIGNhbiB5b3UgaGVscCB3aXRoIGJpc2VjdGluZyB0aGlzIGlz
c3VlPyBGb3IgdGhlDQo+PiBmdWxsIHJlcG9ydCwgc2VlIGFsc28gaHR0cHM6Ly9sb3JlLmtl
cm5lbC5vcmcvbGludXgtc2NzaS9ZMUprdUtUalZZck9XYnZtQGVsZGFtYXIubGFuLy4NCj4g
DQo+IFRoaXMgaXNzdWUgaXMgZ2V0dGluZyBvYnNlcnZlZCBhZnRlciBoYXZpbmcgdGhlIGJl
bG93IHBhdGNoIGNoYW5nZXMsDQo+IDJiOWFiYTBjNWQ1OGUxNDFlMzJiYjFiYjRjN2NkOTFk
MTlmMDc1Yjggc2NzaTogbXB0M3NhczogRml4IHJldHVybg0KPiB2YWx1ZSBjaGVjayBvZiBk
bWFfZ2V0X3JlcXVpcmVkX21hc2soKQ0KPiANCj4gV2hhdCBpcyBoYXBwZW5pbmcgaXMgdGhh
dCBvbiBYZW4gaHlwZXJ2aXNvciwgdGhpcw0KPiBkbWFfZ2V0X3JlcXVpcmVkX21hc2soKSBB
UEkgYWx3YXlzIHJldHVybnMgYSAzMiBiaXQgRE1BIG1hc2suIEkuZS4gSXQNCj4gc2F5cyB0
aGF0IHRoZSBtaW5pbXVtIERNQSBtYXNrIHJlcXVpcmVkIHRvIGFjY2VzcyB0aGUgaG9zdCBt
ZW1vcnkgaXMNCj4gMzIgYml0IGFuZCBoZW5jZSBtcHQzc2FzIGRyaXZlciBpcyBzZXR0aW5n
IHRoZSBETUEgbWFzayB0byAzMmJpdC4gU28sDQo+IG9uIGEgNjQgYml0IG1hY2hpbmUsIGlm
IHRoZSBkcml2ZXIgc2V0J3MgdGhlIERNQSBtYXNrIHRvIDMyIGJpdCB0aGVuDQo+IFNXSU9U
TEIncyBib3VuY2UgYnVmZmVyIGNvbWVzIGludG8gcGljdHVyZSBkdXJpbmcgSU9zLiBTaW5j
ZSB0aGVzZQ0KPiBib3VuY2UgYnVmZmVycyBhcmUgbGltaXRlZCBpbiBzaXplIGFuZCBoZW5j
ZSB3ZSBvYnNlcnZlIHRoZSBJTyBoYW5nIGlmDQo+IHRoZSBsYXJnZSBJT3MgYXJlIGlzc3Vl
ZC4NCj4gDQo+IEkgYW0gbm90IHN1cmUgd2hldGhlciB0aGlzIEFQSSdzIHJldHVybiB2YWx1
ZSBpcyBjb3JyZWN0IG9yIG5vdCBpbiB0aGUNCj4gWGVuIGVudmlyb25tZW50LiBJZiBpdCBp
cyBjb3JyZWN0IHRoZW4gSSBoYXZlIHRvIG1vZGlmeSB0aGUgZHJpdmVyIHRvDQo+IG5vdCB1
c2UgdGhpcyBBUEkgYW5kIGRpcmVjdGx5IHNldCB0aGUgRE1BIG1hc2sgdG8gNjQgYml0IGlm
IHRoZSBzeXN0ZW0NCj4gaXMgYSA2NGJpdCBtYWNoaW5lLg0KDQpQbGVhc2UgcmVjaGVjayB0
aGUgYmFja3BvcnRlZCBwYXRjaCBpbiA1LjEwLnkuIEl0IGlzIF93cm9uZ18uIFRoZSBiYWNr
cG9ydA0KaGFzOg0KDQotLS0gYS9kcml2ZXJzL3Njc2kvbXB0M3Nhcy9tcHQzc2FzX2Jhc2Uu
Yw0KKysrIGIvZHJpdmVycy9zY3NpL21wdDNzYXMvbXB0M3Nhc19iYXNlLmMNCkBAIC0yOTkz
LDcgKzI5OTMsNyBAQCBfYmFzZV9jb25maWdfZG1hX2FkZHJlc3Npbmcoc3RydWN0IE1QVDNT
QVNfQURBUFRFUiAqaW9jLCANCnN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KDQogICAgICAgICBp
ZiAoaW9jLT5pc19tY3B1X2VuZHBvaW50IHx8DQogICAgICAgICAgICAgc2l6ZW9mKGRtYV9h
ZGRyX3QpID09IDQgfHwgaW9jLT51c2VfMzJiaXRfZG1hIHx8DQotICAgICAgICAgICBkbWFf
Z2V0X3JlcXVpcmVkX21hc2soJnBkZXYtPmRldikgPD0gMzIpDQorICAgICAgICAgICBkbWFf
Z2V0X3JlcXVpcmVkX21hc2soJnBkZXYtPmRldikgPD0gRE1BX0JJVF9NQVNLKDMyKSkNCiAg
ICAgICAgICAgICAgICAgaW9jLT5kbWFfbWFzayA9IDMyOw0KICAgICAgICAgLyogU2V0IDYz
IGJpdCBETUEgbWFzayBmb3IgYWxsIFNBUzMgYW5kIFNBUzM1IGNvbnRyb2xsZXJzICovDQog
ICAgICAgICBlbHNlIGlmIChpb2MtPmhiYV9tcGlfdmVyc2lvbl9iZWxvbmdlZCA+IE1QSTJf
VkVSU0lPTikNCg0KV2hpbGUgdGhlIHVwc3RyZWFtIHBhdGNoIGhhczoNCg0KKyAgICAgICBp
ZiAoaW9jLT5pc19tY3B1X2VuZHBvaW50IHx8IHNpemVvZihkbWFfYWRkcl90KSA9PSA0IHx8
DQorICAgICAgICAgICBkbWFfZ2V0X3JlcXVpcmVkX21hc2soJnBkZXYtPmRldikgPD0gMzIp
IHsNCiAgICAgICAgICAgICAgICAgaW9jLT5kbWFfbWFzayA9IDMyOw0KKyAgICAgICAgICAg
ICAgIGNvaGVyZW50X2RtYV9tYXNrID0gZG1hX21hc2sgPSBETUFfQklUX01BU0soMzIpOw0K
DQoNCkp1ZXJnZW4NCg0K
--------------cFpTspK8fz03bLJT6EfskpoB
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------cFpTspK8fz03bLJT6EfskpoB--

--------------8nAfY0HuTJjjgFAPh5D6KU35--

--------------S7L73GZ7QwBj4qRYR6bALgT0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNWi1cFAwAAAAAACgkQsN6d1ii/Ey9+
lwf/Yha8xaMGxH8Q4ckxdIAJvEQrji9rS53M62NlunVEMWVsKeUqsrmPASDUET/YhTByyi7+moWO
DDioRZgOVuaMudP+cIwEtQ8eYvUv30uFaIOvKlFwsO2li5l50mVCAT0/5dax0+H5vXWpKsVPlZ4z
SgcnpWUamA5goQNHUA0EoyFQpxucuiC1w7u7yBEIEVm2VmzyNrayou76j+GLEBGD+I/A9PzWHju/
8UOSLt3jYmY6t/RXCar2Rk5qaMQqoTCPM6rynWO1Lpy30dH+hMl4+tXW2o2p5EdJBpj/maCB02KB
W4KDn2wxmur5vSpRqI4Ha/OdjqmHe55PW1h5Mv/IFw==
=CPv9
-----END PGP SIGNATURE-----

--------------S7L73GZ7QwBj4qRYR6bALgT0--


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 12:56:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 12:56:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429095.679920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omx0G-0001p0-AO; Mon, 24 Oct 2022 12:56:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429095.679920; Mon, 24 Oct 2022 12:56:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omx0G-0001ot-7m; Mon, 24 Oct 2022 12:56:28 +0000
Received: by outflank-mailman (input) for mailman id 429095;
 Mon, 24 Oct 2022 12:51:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bvlc=2Z=linux.ibm.com=jejb@srs-se1.protection.inumbo.net>)
 id 1omwvp-000187-3K
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 12:51:53 +0000
Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
 [148.163.158.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a09ba47d-539a-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 14:51:51 +0200 (CEST)
Received: from pps.filterd (m0127361.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29OCERSb023714;
 Mon, 24 Oct 2022 12:51:31 GMT
Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com
 [169.53.41.122])
 by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kdthg12fh-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 24 Oct 2022 12:51:30 +0000
Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1])
 by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29OCZbsn008186;
 Mon, 24 Oct 2022 12:51:30 GMT
Received: from b03cxnp08028.gho.boulder.ibm.com
 (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20])
 by ppma04dal.us.ibm.com with ESMTP id 3kc859pu97-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 24 Oct 2022 12:51:29 +0000
Received: from b03ledav004.gho.boulder.ibm.com
 (b03ledav004.gho.boulder.ibm.com [9.17.130.235])
 by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
 29OCpUoi8651402
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 24 Oct 2022 12:51:30 GMT
Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 434BA7805E;
 Mon, 24 Oct 2022 13:34:16 +0000 (GMT)
Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 72A6E7805C;
 Mon, 24 Oct 2022 13:34:14 +0000 (GMT)
Received: from [IPv6:2601:5c4:4300:c551:a71:90ff:fec2:f05b] (unknown
 [9.163.14.162])
 by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP;
 Mon, 24 Oct 2022 13:34:14 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a09ba47d-539a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject :
 from : reply-to : to : cc : date : in-reply-to : references : content-type
 : content-transfer-encoding : mime-version; s=pp1;
 bh=oXDo6OOAGRuOx2/tHyuwWdEtQtQZtp/beyJbpXTtQo4=;
 b=koxkd2YZZzRZMplg4caN1FtHR1Q0XA5I+p8f2rdYg9ihhsA14PzT4ltccH92+cxpqlsx
 5SqzFOEtiN+XMmSJK7MLubY02QztDq2WVmEzGKfrdyLcWtV1Wj3xC0Vl3p1l9a/VBKk9
 5tZ25nCzmJjk5ZOBC7Sq1Ji5f5VaQn68hxk0T4uJGj3PFUIkk1uL1zkJ1pmgpxmUTvaL
 rvOt7RAsrsT0fWolYucTyXwMEZe9qLbStdP6jYNiA66qHNiZutRAiXdgq42/jgEFunz8
 BOvxZODTyLVyT47aizWlW+J1fQxz5bSZZEXvN7agYONaoiaoYrD7V2/OqhBXUeiSGjwp aA== 
Message-ID: <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
From: James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Bart Van Assche
	 <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, sathya.prakash@broadcom.com,
        suganath-prabu.subramani@broadcom.com,
        "Martin K. Petersen"
	 <martin.petersen@oracle.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        adi@kriegisch.at
Date: Mon, 24 Oct 2022 08:51:25 -0400
In-Reply-To: <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
	 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
	 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 
X-TM-AS-GCONF: 00
X-Proofpoint-GUID: rf1s4aY2JsG8kj3ndnjkEqcdP00oZW8p
X-Proofpoint-ORIG-GUID: rf1s4aY2JsG8kj3ndnjkEqcdP00oZW8p
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-24_03,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 impostorscore=0 bulkscore=0 clxscore=1011 spamscore=0 suspectscore=0
 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210240077

On Mon, 2022-10-24 at 17:26 +0530, Sreekanth Reddy wrote:
> On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche <bvanassche@acm.org>
> wrote:
> > On 10/21/22 02:22, Salvatore Bonaccorso wrote:
> > > We got the following report in Debian after an update from
> > > 5.10.140 to
> > > the current 5.10.149. Full quoting below (from
> > > https://bugs.debian.org/1022126). Does this ring some bell about
> > > known
> > > regressions?
> > 
> > Only three mpt3sas changes are new in v5.10.149 compared to
> > v5.10.140:
> > $ git log --format=oneline v5.10.140..v5.10.149
> > 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return
> > value check of dma_get_required_mask()
> > e7fafef9830c4a01e60f76e3860a9bef0262378d scsi: mpt3sas: Force PCIe
> > scatterlist allocations to be within same 4 GB region
> > ea10a652ad2ae2cf3eced6f632a5c98f26727057 scsi: mpt3sas: Fix use-
> > after-free warning
> > 
> > Sreekanth and Suganath, can you help with bisecting this issue? For
> > the
> > full report, see also 
> > https://lore.kernel.org/linux-scsi/Y1JkuKTjVYrOWbvm@eldamar.lan/.
> 
> This issue is getting observed after having the below patch changes,
> 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return
> value check of dma_get_required_mask()
> 
> What is happening is that on Xen hypervisor, this
> dma_get_required_mask() API always returns a 32 bit DMA mask. I.e. It
> says that the minimum DMA mask required to access the host memory is
> 32 bit and hence mpt3sas driver is setting the DMA mask to 32bit.

This sounds entirely correct because the VM is booted with (from the
original debian bug report):

dom0_mem=4096M,max:4096M dom0_max_vcpus=4 dom0_vcpus_pin
  ucode=scan xpti=dom0=false,domu=true gnttab_max_frames=128

So it has no memory above 4GB and thus 32 bit addressing is the minimum
required.  If you boot a machine with >4GB and Xen still returns a 32
bit mask here, then we have a Xen problem.

>  So, on a 64 bit machine, if the driver set's the DMA mask to 32 bit
> then SWIOTLB's bounce buffer comes into picture during IOs. Since
> these bounce buffers are limited in size and hence we observe the IO
> hang if the large IOs are issued.

Why is the SWIOTLB active if all the physical memory in the VM is
within the range of the DMA mask?  If this is really happening, it
sounds like a SWIOTLB bug.

> I am not sure whether this API's return value is correct or not in
> the Xen environment. If it is correct then I have to modify the
> driver to not use this API and directly set the DMA mask to 64 bit if
> the system is a 64bit machine.

The original design of the API is to describe exactly the minimum
direct DMA requirements.  There are a large number of cards with
multiple DMA register formats, the most common being to use either a
compact 32 bit or an expanded 64 bit register to describe a page
location.  The former gives 39 bits of addressing and the latter 64. 
If the DMA mask is 39 bits or below as described by this API, then the
card can use the compact address form.

James




From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:01:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:01:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429107.679932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omx5O-0003LQ-Td; Mon, 24 Oct 2022 13:01:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429107.679932; Mon, 24 Oct 2022 13:01:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omx5O-0003LJ-Qg; Mon, 24 Oct 2022 13:01:46 +0000
Received: by outflank-mailman (input) for mailman id 429107;
 Mon, 24 Oct 2022 13:01:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1omx5N-0003LD-8G
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:01:45 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam04on2046.outbound.protection.outlook.com [40.107.102.46])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 018512d4-539c-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 15:01:43 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM6PR12MB4861.namprd12.prod.outlook.com (2603:10b6:5:1bd::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Mon, 24 Oct
 2022 13:01:39 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 13:01:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 018512d4-539c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AhO2evAsDXrD1fO/sq3QQRjYmR7NfAe9bGuZsNY2FHtIADsVA51JN+vwYxygd9Ko8FRZUtzc+/+HoIijbkNsKZ5jbV2cF0uugLtiA4zuOcHFF6Em0Qm4nEHtRv02zAraeApXYJA8vcO/8jJZMCLfd0do3cQ0hdA2M4kDsFlmG7G5hBGoTQhmop6zs4zwHlnUR7nI6J7bBzovagcK2erujHHA0h+WMT+hTdhplq6JmycLgQlV7gbSuMupWnE7A/O/CDEyyo8E3myAYJncczE5l75dS9hb23njzM74ZVRVfv9S7wBOJmF30v9k1XHFADibdwrNx35lF8bsPiZthRWQNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5C0oVIfsrAO3fcfHdXqKiEqM1E5j+OU0Oi3+W3RM3Pg=;
 b=IFdYHqKm1UnJR7SRMekCwidNmMCZF6CHInUZdPI74GufGynr7/QvoPPjLfQI3dewiC+kASverC2QrlEhpuKp9lsRDsHGmWddNFm3UyeEgCSDEQeH2GM8qTDjmW9kWdL5w+0cvcoVan4WZjcwPQt3kveY01ohb3+Ms8Jm0XMTKfUpDr2y7y5mFg0A44uS4pajzHAlxTVAJb+g8SHkqwop8zsOD4fpmcOuJIJ58K7ZzCxXgVJdic25FM5Z7nPcEzncBViSVmTBLXOva7PC7UJjCP0mN/3JlXrgZlp/JlNL5WiX88thWkJ0SXmtoyyT53CDWLLdKd/l/syypogd6a1hUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5C0oVIfsrAO3fcfHdXqKiEqM1E5j+OU0Oi3+W3RM3Pg=;
 b=b0jdF6wJ0AD3FYv4rsTn59n/HwdNdLOb/pAA1KQVYAuAyMC8MLIkG+utKn8uiRCSwlvpgHxj/p0JozYRJdq7zXXi6ywHoOL7Ocbf+IWfqwJUmFe9Efy0LjWGOxV3/7JrUMKIpuNYTc4OprZC5nNR/qO32ztlcC3EI1cMm4QzGW8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <76f1b4fc-90bd-f55f-5624-f5d011bdaa9f@amd.com>
Date: Mon, 24 Oct 2022 14:01:33 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 02/12] Arm: GICv3: Move the macros to compute the
 affnity level to arm64/arm32
To: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-3-ayankuma@amd.com>
 <cb67c768-1a05-e5d5-efed-9a282c6a8c2a@gmail.com>
 <e0183387-8556-5fcc-2f18-003832d5cd70@amd.com>
 <78306c56-7cdd-a705-f8af-0cae4e359336@gmail.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <78306c56-7cdd-a705-f8af-0cae4e359336@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0437.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::10) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4861:EE_
X-MS-Office365-Filtering-Correlation-Id: 3d2e5bd3-31d4-4224-0b2d-08dab5bfe3de
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cUTBDiE0800y5MtTtONZat2q0G3fuhoro5P1iqVMCWaw8hwkIaXEI7TuOH4KmN5I+aErPdzB8UGPy2ZkqIAcvAxQJKtvUzVzn3do4LB2eEY2NTerUULO5UVzhqqo9C/fcu1lLT+A/ymP7TEWBQ0TIpVmEH8YIjDO6EADGKZi+vV840ecn4Qdb+9LC3kQBdNxXaIkQ0+PYFYQkNHB6ZG8iC86j+9zAzYrrXJ4pKofTGgiuokDwV+b10GQftWOquH+hIDJqwQlZOsyG7hkhNsj6fd/p2JudTFYTH+u9TX8240BVPNJJdoRaW1VhOyfa+PZHvnFBpinlWDL+TRhb4z9TiX/hr+bHSWcAU09ZPmTurrCFGF1OjHOJTF9IY+/FqNZ/qeOiGwtCehUYNsl/oX3Zbs/EQLYiOxPDl4hqt/D95R9gb0Z7h31tmROL+O5I/M9gwBiA+odFgORWzZQLI7Znj2JX7vL0268tdJCCWtQ4Da/qugVsYXnkYDqujw017fa2wgowZAbZbX45oxe+/3yapTNlkV4nXWwC+sXqjK4k6xgZdaUBAUsVfcODg5SFeNLT7JUwbiw5X5XcdkwT6G2clcWPlTLpTcoCDBdpEYCV+vJaAZh6v/Snid78RZA/EBKkPpdTVLBKKLZ3nRnP4KyKMZikz40Kb8+UGFufAK6tpJeiarZlhvcfUAkdo2nGNe/vh/xbeTBIHK8ZBzXz7O0sTaWtQUS/6a7UdO1URk8E0lQvNyYhz1LK/47ynOC81ggPHb4Em1uT0LVznhZpsAfy7XX9sHN9bKjmiUKPA//LjBMfIkJgDeZkYBJpmpCuKn27Ez2or5dfFseVLlzglwcrKYWyrzODSlGHzic6vzSiuE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199015)(2616005)(2906002)(36756003)(316002)(41300700001)(6506007)(6666004)(8936002)(31696002)(66476007)(66556008)(966005)(31686004)(6486002)(5660300002)(8676002)(4326008)(53546011)(26005)(478600001)(38100700002)(186003)(6512007)(83380400001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VU9wVVZKRS9rV3dQS29LR1F6YUhoVi8yWnZkOXhHWm1TZXV3dmpmNmhmZXdU?=
 =?utf-8?B?UmVYZGk2NXQvaW9LUzBudXFGMzd2VjBKTEViMS9ZcUwvTTBMdk50eW50Z0ZQ?=
 =?utf-8?B?L2x4RDdCY3VWMS84c1pML3ZpNVlDMHFTZk9QNmZaVFUvTWQ1K3hBM0piUktK?=
 =?utf-8?B?SWoveEJ0cEJ0TG1zek5LK2JVOVFPaThHL2pHSXdYaFQ1NVVGRjlMRkJtalhX?=
 =?utf-8?B?Zk9KOTRzMkloUlRrQ3BIYWYzalV6SWRKRnNpUmlGdmlhTU5XYWwrRytEb1Vz?=
 =?utf-8?B?VklhOFhSYTZ6RE1pREdXeHkvMFpwQzcwMVZwSHQyb2x0WTV0cUJWNkh0Q3lG?=
 =?utf-8?B?aDNsOWNkNjFMTTVRa0tMYkpyQ1I4ck9xdE9uaWhWWVgwT0hKQ04wbGwrMGUy?=
 =?utf-8?B?aGJWNXJ4MG9adlFidzYzWDBOVFM5aXVFVlFQdGgrVnA3cDRPb0FTNHVVMGtt?=
 =?utf-8?B?cFJ1YkErQTdGdjYyVkFoWlorcCt2c3V5TzAySDBwd2IySW1kZWY3VHVlM1No?=
 =?utf-8?B?TG1PcUdvNFN1SVBLdVp2VUtPc0NLb1ZxYVJCVmJqTnhFTXV1NG1MSjlaTHdu?=
 =?utf-8?B?aHk5TTBXajZrS043OUF4QnlOUUFtRzlyVm13NjVQL2hpdlA2bzBTQTdKTm5Y?=
 =?utf-8?B?KzN2MlFDeU43TDBWaXNIZ2xsejhkWW9LbSt0UzBEYUt1clJ5c2ozZ3E3L3Z3?=
 =?utf-8?B?MTJXS3VhelZHZ3ZTOG5VVUFRWTREai9hcWZFN1BrL0N5MkhoMFJLZGsvanc5?=
 =?utf-8?B?NlF5c2ZhdktiT0ZjUkVSalo5NFVYanlOVzdaRmxMUU9WODl2MWs5TXhyWGdw?=
 =?utf-8?B?TndTWVBkajAyWHNnZ2hySHg4RVlQdGdpMGZBZUtBR2kzS3Bmb0l3RHpncmFM?=
 =?utf-8?B?MXRsMm0wQWxqQ1lnbm1WUjg0NGYwanFlTkV3eXNGbFJFbTZNcklBSUJqS055?=
 =?utf-8?B?Z2ovWTQrM2lkd0R6SHhWNGVQc3o1UTFDOTJWN1ZUU2lyRkVvNjJZYWpYTFlM?=
 =?utf-8?B?YngyMVkzeVpqRmtCNnMwN21QR2JaMUUzTVd6ZFcycFZJNExRR2FtWTFzSm8v?=
 =?utf-8?B?RGpsdk9QTlRQbXlrSlJ2SWdwNnRZUzl2clVTeThWTGQxSVRTZDVzY0NpVXk1?=
 =?utf-8?B?eDl5TUNtbDMwVWZmVWZKU3FDc3FBNWczWDNOYnBVQ1Z0OUxtM2xpb08wRUwv?=
 =?utf-8?B?dElKbFJnYkxtVmcwQ3NNakxRVXJWZ3VLRlBrNjNSVTN4VlZlc2pPZ1RET2FN?=
 =?utf-8?B?bGNqMnljNHZYbnMyMmNpMEQ2OVZhTEZuTERMZUNDZ3ppaGVpS1RVbkxTenJn?=
 =?utf-8?B?WDlhanZjSjZQYmh2dTliQ0ZCWnBFNHBpaTNwYkY4SUlLRXE0Y1pjMWx4Uys1?=
 =?utf-8?B?c2VKNmlEZm5PSDRvZlN3N2FXWnhYWjR2Vkp6a0VlNE9DNHR6bEVSMHdNcHlP?=
 =?utf-8?B?R00vSmw5UHNKS0VMS1FWaHNCSjYxV2w3Qm1Zc2YvTi80RUtXTnpGbHRlcFV6?=
 =?utf-8?B?cG5tc3l3dE9RRzgrSHVMZnRaOWJxR3h1YWtLZm80SVcxR1V5VWwrUUZ1VXp2?=
 =?utf-8?B?RVZKZDlac3k2dE9KRzRWK0h2S3F6eHp4eTFrSUFZcE1zM0lybG9XT0x0TEpq?=
 =?utf-8?B?RHhZTzhxQm5hZnRFQnNHN0lEU1hEY0Y5TzdlM28zYzEwWjBkTDVMTVRlaThC?=
 =?utf-8?B?REpYWi9sYks5K1VjTUV6RkVPbHJaZmtzbHZLTGVHaXdDT0dnZDl5bnBJVFVU?=
 =?utf-8?B?R1RRcWVPWFJBM0lCK2hmc2VMbU0rR01xN0FWbzdpODlTSzZDU3ZlYUo0SkFD?=
 =?utf-8?B?WHA3ZFhiNktuK1BoeVlrWFdIdG41R1hSRHZIalF5QW5RWWJjZFhLK1RNN1Ax?=
 =?utf-8?B?S1RSR2hoekdnSEN2a0ZYVTAxK2k0a09VaGpwTTlrdkRKRVRsdnRqL2dDLzZz?=
 =?utf-8?B?RG1xYmxpR0p2RFBNS2N6ZzZRYkpwUUpqcjNKL0Z5bXkyVGRKSGMrY1lOUW5T?=
 =?utf-8?B?SHcvRDBqeFZwZmd6ZzR3RDFQRE9QSXB0MUlFd1JsSDRWU3BvMFdCcWhwbTNP?=
 =?utf-8?B?WTJyeGw1QVl0WlRGdk9ZckYwVzdzN3RIVUVNU0xVTTdlYnI4RG9FVnVNbU1S?=
 =?utf-8?Q?vkyU2R/Q+UdZE4HoHP75TpUYU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d2e5bd3-31d4-4224-0b2d-08dab5bfe3de
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:01:39.5050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vKa0li4QqAOXZq4VKyIlN/KDij8gNAHus+vlPYlkf0xitQlBGcnuhJJYQwgvSfZ9M6fVMpJdHS+RAhDgDWdzXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4861


On 24/10/2022 12:35, Xenia Ragiadakou wrote:
> Hi Ayan,
Hi Xenia,
>
> On 10/24/22 14:00, Ayan Kumar Halder wrote:
>>
>> On 21/10/2022 22:18, Xenia Ragiadakou wrote:
>>> On 10/21/22 18:31, Ayan Kumar Halder wrote:
>>> Hi Ayan
>> Hi Xenia,
>>>
>>>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
>>>> include/asm/cputype.h#L14 , these macros are specific for arm64.
>>>>
>>>> When one computes MPIDR_LEVEL_SHIFT(3), it crosses the width of a 32
>>>> bit register.
>>>>
>>>> Refer 
>>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
>>>> asm/cputype.h#L54  , these macros are specific for arm32.
>>>>
>>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>>> ---
>>>>   xen/arch/arm/include/asm/arm32/processor.h | 10 ++++++++++
>>>>   xen/arch/arm/include/asm/arm64/processor.h | 13 +++++++++++++
>>>>   xen/arch/arm/include/asm/processor.h       | 14 --------------
>>>>   3 files changed, 23 insertions(+), 14 deletions(-)
>>>>
>>>> diff --git a/xen/arch/arm/include/asm/arm32/processor.h 
>>>> b/xen/arch/arm/include/asm/arm32/processor.h
>>>> index 4e679f3273..3e03ce78dc 100644
>>>> --- a/xen/arch/arm/include/asm/arm32/processor.h
>>>> +++ b/xen/arch/arm/include/asm/arm32/processor.h
>>>> @@ -56,6 +56,16 @@ struct cpu_user_regs
>>>>       uint32_t pad1; /* Doubleword-align the user half of the frame */
>>>>   };
>>>>   +/*
>>>> + * Macros to extract affinity level. Picked from kernel
>>>> + */
>>>> +
>>>> +#define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1)
>>>> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
>>>> +
>>>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>>> +    ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK)
>>>> +
>
> Above, since
> #define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
> you can replace (MPIDR_LEVEL_BITS * level) with 
> MPIDR_LEVEL_SHIFT(level) in the definition of MPIDR_AFFINITY_LEVEL.
> You will see that it is identical to the arm64 definition
> #define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)

Currently, MPIDR_AFFINITY_LEVEL(mpidr, 3) differs between arm32 and arm64:-

In arm32 :- (mpidr >> 24) & 0xff

In arm64 :- (mpidr >> 32) & 0xff

I think this is what is expected. See xen/arch/arm/gic-v3.c ,

static inline uint64_t gicv3_mpidr_to_affinity(int cpu)
{
      uint64_t mpidr = cpu_logical_map(cpu);
      return (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 |
              MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 |
              MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8  |
              MPIDR_AFFINITY_LEVEL(mpidr, 0));
}

>
>>>>   #endif
>>>>     #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
>>>> diff --git a/xen/arch/arm/include/asm/arm64/processor.h 
>>>> b/xen/arch/arm/include/asm/arm64/processor.h
>>>> index c749f80ad9..c026334eec 100644
>>>> --- a/xen/arch/arm/include/asm/arm64/processor.h
>>>> +++ b/xen/arch/arm/include/asm/arm64/processor.h
>>>> @@ -84,6 +84,19 @@ struct cpu_user_regs
>>>>       uint64_t sp_el1, elr_el1;
>>>>   };
>>>>   +/*
>>>> + * Macros to extract affinity level. picked from kernel
>>>> + */
>>>> +
>>>> +#define MPIDR_LEVEL_BITS_SHIFT  3
>>>> +#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>>>> +
>>>> +#define MPIDR_LEVEL_SHIFT(level) \
>>>> +         (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>>> +
>>>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>>> +         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>>>> +
>>>>   #undef __DECL_REG
>>>>     #endif /* __ASSEMBLY__ */
>>>> diff --git a/xen/arch/arm/include/asm/processor.h 
>>>> b/xen/arch/arm/include/asm/processor.h
>>>> index 1dd81d7d52..7d90c3b5f2 100644
>>>> --- a/xen/arch/arm/include/asm/processor.h
>>>> +++ b/xen/arch/arm/include/asm/processor.h
>>>> @@ -118,20 +118,6 @@
>>>>   #define MPIDR_INVALID       (~MPIDR_HWID_MASK)
>>>>   #define MPIDR_LEVEL_BITS    (8)
>>>>   -
>>>> -/*
>>>> - * Macros to extract affinity level. picked from kernel
>>>> - */
>>>> -
>>>> -#define MPIDR_LEVEL_BITS_SHIFT  3
>>>> -#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>>>> -
>>>> -#define MPIDR_LEVEL_SHIFT(level) \
>>>> -         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>>> -
>>>> -#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>>> -         (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>>>> -
>>>>   #define AFFINITY_MASK(level)    ~((_AC(0x1,UL) << 
>>>> MPIDR_LEVEL_SHIFT(level)) - 1)
>>>>     /* TTBCR Translation Table Base Control Register */
>>>
>>> Since only the definition of the MPIDR_AFFINITY_LEVEL() differs, 
>>> maybe you could add only this one to the arch specific headers e.g
>>> for arm64:
>>> #define MPIDR_LEVEL_SHIFT(level) \
>>>     (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>> for arm32:
>>> #define MPIDR_LEVEL_SHIFT(level) \
>>>     ((level) << MPIDR_LEVEL_BITS_SHIFT)
>>
>> Also, MPIDR_AFFINITY_LEVEL needs to be defined in arch specific 
>> headers as it differs between arm32 and arm64.
>
> As I point out above, there is no difference between arm32 and arm64 
> regarding the definition of MPIDR_AFFINITY_LEVEL(level).

Please see above and let me know if it makes sense.

- Ayan

>
>>
>> However, MPIDR_LEVEL_MASK can be defined in the common header (as it 
>> is same for arm32 and arm64).
>>
>> Please let me know if it makes sense.
>>
>>>
>>> But in any case don't forget to add parentheses around the macro 
>>> parameters when an operator acts on them to avoid trouble with 
>>> operator precedence (MISRA-C Rule 20.7 :))
>>
>> Thanks for pointing it out. Yes, this is a mistake in my patches.
>>
>> - Ayan
>>
>


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:11:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:11:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429113.679942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxF6-0004vY-UY; Mon, 24 Oct 2022 13:11:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429113.679942; Mon, 24 Oct 2022 13:11:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxF6-0004vR-Rt; Mon, 24 Oct 2022 13:11:48 +0000
Received: by outflank-mailman (input) for mailman id 429113;
 Mon, 24 Oct 2022 13:11:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1omxF5-0004vJ-Dc
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:11:47 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam04on2040.outbound.protection.outlook.com [40.107.102.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 683bf440-539d-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 15:11:45 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DS7PR12MB6023.namprd12.prod.outlook.com (2603:10b6:8:85::7) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.30; Mon, 24 Oct 2022 13:11:41 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 13:11:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 683bf440-539d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J5d1VlAymniBN9mKVDJBbS5V+tCH+mMI/C3fJkVptyOm8dXFUj089I3HHXGF6yqVkkrXrvkc4epH68R//0SXxMkQvvKoFwYXMx8ZY9RTxGQjIoPuY4psNLXg4E2X/rwg2OfVG0Rj5NnNxMVbwkaWM+KuXySx0rDEzOqL9o86pyj60l1nu5FnYhRq2kADUUwVNXH7WkgKws5IOtBRzg7Epb80cSD/ixcu5lFTOK/7pJWCIZmgN3qoSVkUPf72xXq/OzvGLsqXk1OWh3pYtJckAkfY5unt7QO83aaI+rebv/KlS69wYEtCpaQneoFhlejHp97NZw+23YeWVI0WAXjyNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tBItgm1w+sMKoFUqkZV+1XlL9+Y668dBbVjjrOuktUc=;
 b=ULfefAMP9L4RFAVuYy7WqSxzdqalJtJtoEiaZYawRF6WrTWHa14MqFOap4a96EYE4f5TdfbNEzT7xxN473Ov0/MpxiIeJKweJv9NcukBDMqAL+tquBdMeMnE0ak1Qr4gkF0DIBoA1ufxhmkulAUpdcMnyuRzJW6C/R6BAoORZmU/wl6sGM2feHfCjm8KV/swxxrJlJqmJPWoEsXzPLhy1KMGr+wOLrM7R4QV3mWmieO17H7tmK/fERKigk/IJTnl4xbc+6/WgeyYMgC0MfWNAZgeM8jyhqXBmkQeHIKzCTIP0wvsDPxniahD1UjB9AwnndTi9h94Fwz0cmKfbnlQRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tBItgm1w+sMKoFUqkZV+1XlL9+Y668dBbVjjrOuktUc=;
 b=mqSLbKPOA7ucWAOzNkQQWx1UKuO6MWPE0RPEaFSZnp8OUhMIGcG523lysE6EnAc/MibE1HqB4vcdMSmnnXfFughy1aia7lrwNvE2LS3oMgMJtyTP3ODfVDFrO0EaEOAYxmiGuRTHZrZRCGzpO2Du60M6c2mpKIcFPN/dH9E/aw4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <ba43677f-903b-f30c-76e4-1668cdab2cc2@amd.com>
Date: Mon, 24 Oct 2022 14:11:35 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "stefanos@xilinx.com" <stefanos@xilinx.com>, "julien@xen.org"
 <julien@xen.org>, "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>
References: <20221020104146.29841-1-ayankuma@amd.com>
 <AE2C68A9-4276-444C-B227-F079D330EB8A@arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <AE2C68A9-4276-444C-B227-F079D330EB8A@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0029.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ae::9) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS7PR12MB6023:EE_
X-MS-Office365-Filtering-Correlation-Id: 779faba5-8a43-425d-316e-08dab5c14a9b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	plWqi1NiMF8Y9httFs89QqS8T17N7278FCMZhOM2h+/w0Pl8wfir3Khons6N6qcjpA0c0Ef6dAmJ1zg4vbQ2PuB0FnPxnPi+1urI2ft52jkNdnHWPpJF/xOF/Vpv1Lui+cs0zqP7Sun4vgh9tL7Y9hgwFK+IEkK9D5eDATyKhCFH59An+A245opmtY87pGfKpokfbmBbWF1mo0x/jeqPLhmGX9PiHQFth7++OpcQr9jwgHqGVmztPT203SEGTjJMclwP6VW2MtRYCvR76Ewd2RgTbZ66VyqozLtWC9m+dU8NJz1zf5ykCd+c0uGkUsHrHvhXpolGQ9tvYVObsfsseRf0mTViCb5SHMwBSlAHIhUell8h+2xxeeQf1BMVR/max7y/Ay3LadPdS5JPjJVhOfAk/JWwqvsI+ajiUKfRyDzFLTASgW8sxXmODkGlh2OlY7y2IjRpcdlfK/i6PtCMfLZjX7KIhnrYix39a0B/USKX6ddfg8evTpF14OADLu5Vx1AUJmcS7HM4KCO3qug/qQxZUbUPgd+IeG/Sy5nc9Vdl39VjmxORqujRcL1kUJtF+GHlnTPd/kZDBsI2z4hy5zjZmtsKbzqdV5LZOO6Kwc3sekIPtUDbrCIjdN+gK1epwdTTBgocpIvrnyCJgmsW3RntwU7iO5wiwwrinztZqPEq6IEYouKve7XHEjFHWprv8c8HbXO2DVWagRea3o4CBvxNHXhI3TXBLNYBiz9bX79di1sT17plKr+AddlD5bIWFPwfIe9HmTeVN9hRMTfypQadCcF9F/7wnXjPbYLZj/jb+MrPW0r+T4lZvQPXlrRx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(451199015)(4326008)(31686004)(966005)(6486002)(478600001)(38100700002)(2616005)(6506007)(6916009)(36756003)(83380400001)(186003)(316002)(54906003)(66946007)(8676002)(6666004)(66556008)(66476007)(31696002)(26005)(41300700001)(6512007)(53546011)(2906002)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QUN4YWd4bFFaek5ZVXpnMGtsQ2N0STc3cXJWY3FuNlhFVllXMVp3MFR5NEc2?=
 =?utf-8?B?b0JubzBPUzdydVhvbGFDZ3UyU09mZms4bXdqaGZielVZeS9yVEVnK3FnYjJi?=
 =?utf-8?B?bFI5cWxmL3RhcnZ1NWRoMU9MT2gvcXBjL1ZlUlVUR3FLRmdUd21uVmxMeXcx?=
 =?utf-8?B?ZG9aeWJkeTBDcHkxUE1SeHZEdFk5ZS9CcCtURDhyVnVjcjhaVC9KUlRvVWFF?=
 =?utf-8?B?N0JpYnlwSWJ2aUNFRGJTa2N3eFFKRWlTczdDZk90NVlTbVFQWnBpOTRUaU10?=
 =?utf-8?B?VFBpekF6SnRac21DWHpMc1dUYVZibld0NDdDNXVzTnFnaU9GeEZoYlU0aEpt?=
 =?utf-8?B?Ly9yeEEzYVRLaE95OXF5T2hDZm41QkdHZml2bXdZaE1yaUVGMVErck9LMzIw?=
 =?utf-8?B?M0NzSVBhNytSSVA1WmU4bG5KS215amVNV1NjNVVpT21tcWtRMTlYM3pPVkFS?=
 =?utf-8?B?Q29aUUZJc1laTHVhaE82VDgrenlwaFZIWWpMcU9UNStmMC82VWJOMFNMbDVX?=
 =?utf-8?B?QUFJdGs4d1dHTkpkRm81QmhLUzluWnBDV1FHcG9ONFlLWWxZazFBZTRVdklD?=
 =?utf-8?B?QjA2MVlMSjdURUZITFVuL2ZidTJaYU1qc0c3SWttQWplajdISUVQdGhXclV5?=
 =?utf-8?B?V2crS0JwVW50R0ozdnZWWWxyaE9GVjlvNzlXTHhKenIyS25uYnZqcnlQb1Iv?=
 =?utf-8?B?djNZeE4yRUFCSUx0UWZ4VTRyMEFHWXcwQ0FGYnJYODdJaysrbE9tOUN5a1d1?=
 =?utf-8?B?YU9SYXhJcjZzbHhpVDRnd2RnVmFLcTZUQTdrWGJmN1RaZElDSzMwNkRSTzVC?=
 =?utf-8?B?WGpkWTZvZWxNNEpEakNTQTZrRkVlTWU0dVRVR1dxVG10Nk1Nd3JMWkwvdEhw?=
 =?utf-8?B?QnpoSUJ6T0xlenNtZWFxMDJXS0JSWHNmVGNZRWlQVEZrVEV0MVJLdW1OYzJh?=
 =?utf-8?B?N2NqOG55TkFhSVVzbkFXTEZ3ZVdaUmtzNGlrc1hObThUQXhJR09kT3NYR1hB?=
 =?utf-8?B?RFJRMU1sK05HM3BaK0MzQkNZU0dpOHA0VVVKUnFydGFVNlhCditjWW51UHpm?=
 =?utf-8?B?NUlvMUpBdm83Z2pmSTUvcjMvOXFFeEFPTU55aGdwdllMWkhyQ0tmai9ZY2JU?=
 =?utf-8?B?SkFBZ2Uvd2VEVkhneTl2QVhoWGh6ejR1NTZRMHdBaXFISnJrVjVBdFA0Y2d5?=
 =?utf-8?B?cWJkRDUzOTNZTURMSjJEZk9qUzlhYkVicXo1TlVVeWRqOUdjcmM3ZUVpb0Jk?=
 =?utf-8?B?VG9HWHU4ZkV1M2hyOEdvOExwM2J3QnJocnkyanNNU240NlBlRk9RY0doZ2d0?=
 =?utf-8?B?M1ROdlZTVjdacjIzeWR1NStwbDFLZFVjRGZCcGNLQmp3djFwbVk0SnJRWXdN?=
 =?utf-8?B?RStmTDExaDM2d2pJb3dpaFNBRldkNWF5Ymd5Q3hnb1E5ZE9XeEdnVDZRb1pi?=
 =?utf-8?B?WWpxZlJ2ckwwN01rZVhpZGkwWXI4aU9IT00vc0prOWFRZEhJb0hBalBBWFhq?=
 =?utf-8?B?ZGk3SE9GRGp4bElvUEZJMWZMc3Y1a3AwZ3JUWng1eVM2dWpFL0hTMitaZEhy?=
 =?utf-8?B?UThiVEpqSERLQldVUkx0eTlpTWc2SWt0VWV4QzZDYmd1Z0prcHMyTlF2MTlR?=
 =?utf-8?B?N0ZRQngxNjRMU0w0eUpMS2I1Y3ZpWks0WHlUMS9vRitqUGFIbmh0cWcvS0ZO?=
 =?utf-8?B?UnpWKzQxUTc4Z09VdElaalh4YTJVYkF1VCswTWlvdFlIRXRmanh1YW42YVl3?=
 =?utf-8?B?RUFMUzZ6Y3NDSllGTlh3T3NaYlFhR3kwaUJKVG5sd1g2RDRFRUFXUFMyc2Vw?=
 =?utf-8?B?Z3pMZzY4MjhQeWU0Y3FYMkRLSFRzRS9tOW9kVGI0QkRWUXlMcEsrc3Y0U0FC?=
 =?utf-8?B?MExaT0dIcXdyaWdkOHp0djJOb2Q5VXpLQVdyS3E2QlZ0Q2dFbHAzYjJ0aVhQ?=
 =?utf-8?B?bHcyd1ZEZHBEUFFPdDZUQUkvNUlraFZ3Yk5IYk9oQ2ZMK01VWk1mNGxXNTVX?=
 =?utf-8?B?ZjJHRm5QeXhkeUdEaHBrY1VsSmxHTVAwSndxQ0pLcE8xaXhkNXRMQzZHdFcz?=
 =?utf-8?B?S3N4bHh3Q3RLUW9ldWo0ZW9Dc3VINkRnQkNSUEt6QUh3eU1nUm00cDdDZ05o?=
 =?utf-8?Q?tx0UIrbmTvroPzwVUPORK9zqk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 779faba5-8a43-425d-316e-08dab5c14a9b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:11:41.3846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kAkpxaoojxPsU5Biw45f7rHPsVsepdYrAEP917zcgqcgSE8507Bhdz/md75SEZUl4eUdfu2uP5xhF3sPGrJrIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6023


On 24/10/2022 11:06, Bertrand Marquis wrote:
> Hi Ayan,
Hi Bertrand,
>
>> On 20 Oct 2022, at 11:41, Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>
>> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
>> IGROUPR) is relevant only when the guests run in secure/non-secure mode.
> This sentence is a bit misleading as guests are always running in either secure or non-secure.

Oh, my understanding from the comment "We do not implement security 
extensions for guests" is that Xen does not allow guests to run in 
secure mode.

Also, does Xen itself ever run in secure mode ? I thought it was no.

>From https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions

"The primary requirement is that the hypervisor must be launched in 
Non-Secure Hypervisor mode only."

> We should just say that we do not want guest to change the group of interrupts so we do as if all guests are running in non-secure.
>
>> As Xen does not implement security extensions for guests, so the registers
>> are emulated as read as zero/write ignore.
> I would rephrase this as “Xen does support to run in secure mode so emulate all registers as the hardware does in non-secure.”

Do you mean ?

" Xen does *not* support *guests* to run in secure mode so emulate all 
registers as the hardware does in non-secure. "

- Ayan

>
> On a side note, the question might come at some point if we support to run from secure mode on hardware supporting it, it could be that dom0 or Xen itself would need to modify those.
>
> The code is ok, just the commit message would need a bit of rework I think.
>
> Cheers
> Bertrand
>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> ---
>>
>> Observed the issue while running Zephyr on R52.
>> Also, found that KVM has similar behaviour.
>>
>> Changes from:-
>> v1 - Moved the definitions of GICD_IGRPMODR, GICD_IGRPMODRN to gic_v3
>> specific header.
>>
>> xen/arch/arm/include/asm/gic_v3_defs.h | 2 ++
>> xen/arch/arm/vgic-v3.c                 | 4 ++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
>> index 34ed5f857d..728e28d5e5 100644
>> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
>> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
>> @@ -30,6 +30,8 @@
>> #define GICD_CLRSPI_NSR              (0x048)
>> #define GICD_SETSPI_SR               (0x050)
>> #define GICD_CLRSPI_SR               (0x058)
>> +#define GICD_IGRPMODR                (0xD00)
>> +#define GICD_IGRPMODRN               (0xD7C)
>> #define GICD_IROUTER                 (0x6000)
>> #define GICD_IROUTER32               (0x6100)
>> #define GICD_IROUTER1019             (0x7FD8)
>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>> index 7fb99a9ff2..0c23f6df9d 100644
>> --- a/xen/arch/arm/vgic-v3.c
>> +++ b/xen/arch/arm/vgic-v3.c
>> @@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
>>      switch ( reg )
>>      {
>>      case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>          /* We do not implement security extensions for guests, read zero */
>>          if ( dabt.size != DABT_WORD ) goto bad_width;
>>          goto read_as_zero;
>> @@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
>>      switch ( reg )
>>      {
>>      case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>          /* We do not implement security extensions for guests, write ignore */
>>          goto write_ignore_32;
>>
>> @@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info,
>>      case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
>>      case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
>>      case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>          /*
>>           * Above all register are common with GICR and GICD
>>           * Manage in common
>> @@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
>>      case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
>>      case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
>>      case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>          /* Above registers are common with GICR and GICD
>>           * Manage in common */
>>          return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
>> -- 
>> 2.17.1
>>


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:20:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:20:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429118.679954 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxNm-0006SF-Pb; Mon, 24 Oct 2022 13:20:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429118.679954; Mon, 24 Oct 2022 13:20:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxNm-0006S8-MF; Mon, 24 Oct 2022 13:20:46 +0000
Received: by outflank-mailman (input) for mailman id 429118;
 Mon, 24 Oct 2022 13:20:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Czee=2Z=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1omxNl-0006S2-Er
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:20:45 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa0723a0-539e-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 15:20:44 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D40D02213C;
 Mon, 24 Oct 2022 13:20:43 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78FAB13357;
 Mon, 24 Oct 2022 13:20:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mhzHGyuRVmNIeAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 24 Oct 2022 13:20:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa0723a0-539e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666617643; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=sHBLuiMwnA8vneJD/y631wvIrPqdbeaAk1VJvORMBPs=;
	b=O/RU9fxrsH2ba+KdtTWinFMRVldY7tMWlhqpZiQCPXllCaErxDVueMznrbznDeI1DmzoPh
	xdf34QScHE6ptVYb+Vnb9Zc5umM8msuWMc/c8VzCv1MUQqUkZPRZ8Pc72VFMCCsf1LGGUl
	Tp9nG5hDe9SfvPa/qF/S1QTzUFV39Q0=
Message-ID: <30a056c8-071f-4259-3253-75e718af619d@suse.com>
Date: Mon, 24 Oct 2022 15:20:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: jejb@linux.ibm.com, Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
In-Reply-To: <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------gOALCS2n06jZ1galIJq0LM4A"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------gOALCS2n06jZ1galIJq0LM4A
Content-Type: multipart/mixed; boundary="------------mB8BSwhtZarR0gI4al0uD1q2";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: jejb@linux.ibm.com, Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
Message-ID: <30a056c8-071f-4259-3253-75e718af619d@suse.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
In-Reply-To: <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>

--------------mB8BSwhtZarR0gI4al0uD1q2
Content-Type: multipart/mixed; boundary="------------Cd4S1bW6l9Vep0Vez9WtewrK"

--------------Cd4S1bW6l9Vep0Vez9WtewrK
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMTAuMjIgMTQ6NTEsIEphbWVzIEJvdHRvbWxleSB3cm90ZToNCj4gT24gTW9uLCAy
MDIyLTEwLTI0IGF0IDE3OjI2ICswNTMwLCBTcmVla2FudGggUmVkZHkgd3JvdGU6DQo+PiBP
biBTdW4sIE9jdCAyMywgMjAyMiBhdCA2OjU3IEFNIEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFz
c2NoZUBhY20ub3JnPg0KPj4gd3JvdGU6DQo+Pj4gT24gMTAvMjEvMjIgMDI6MjIsIFNhbHZh
dG9yZSBCb25hY2NvcnNvIHdyb3RlOg0KPj4+PiBXZSBnb3QgdGhlIGZvbGxvd2luZyByZXBv
cnQgaW4gRGViaWFuIGFmdGVyIGFuIHVwZGF0ZSBmcm9tDQo+Pj4+IDUuMTAuMTQwIHRvDQo+
Pj4+IHRoZSBjdXJyZW50IDUuMTAuMTQ5LiBGdWxsIHF1b3RpbmcgYmVsb3cgKGZyb20NCj4+
Pj4gaHR0cHM6Ly9idWdzLmRlYmlhbi5vcmcvMTAyMjEyNikuIERvZXMgdGhpcyByaW5nIHNv
bWUgYmVsbCBhYm91dA0KPj4+PiBrbm93bg0KPj4+PiByZWdyZXNzaW9ucz8NCj4+Pg0KPj4+
IE9ubHkgdGhyZWUgbXB0M3NhcyBjaGFuZ2VzIGFyZSBuZXcgaW4gdjUuMTAuMTQ5IGNvbXBh
cmVkIHRvDQo+Pj4gdjUuMTAuMTQwOg0KPj4+ICQgZ2l0IGxvZyAtLWZvcm1hdD1vbmVsaW5l
IHY1LjEwLjE0MC4udjUuMTAuMTQ5DQo+Pj4gMmI5YWJhMGM1ZDU4ZTE0MWUzMmJiMWJiNGM3
Y2Q5MWQxOWYwNzViOCBzY3NpOiBtcHQzc2FzOiBGaXggcmV0dXJuDQo+Pj4gdmFsdWUgY2hl
Y2sgb2YgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCkNCj4+PiBlN2ZhZmVmOTgzMGM0YTAxZTYw
Zjc2ZTM4NjBhOWJlZjAyNjIzNzhkIHNjc2k6IG1wdDNzYXM6IEZvcmNlIFBDSWUNCj4+PiBz
Y2F0dGVybGlzdCBhbGxvY2F0aW9ucyB0byBiZSB3aXRoaW4gc2FtZSA0IEdCIHJlZ2lvbg0K
Pj4+IGVhMTBhNjUyYWQyYWUyY2YzZWNlZDZmNjMyYTVjOThmMjY3MjcwNTcgc2NzaTogbXB0
M3NhczogRml4IHVzZS0NCj4+PiBhZnRlci1mcmVlIHdhcm5pbmcNCj4+Pg0KPj4+IFNyZWVr
YW50aCBhbmQgU3VnYW5hdGgsIGNhbiB5b3UgaGVscCB3aXRoIGJpc2VjdGluZyB0aGlzIGlz
c3VlPyBGb3INCj4+PiB0aGUNCj4+PiBmdWxsIHJlcG9ydCwgc2VlIGFsc28NCj4+PiBodHRw
czovL2xvcmUua2VybmVsLm9yZy9saW51eC1zY3NpL1kxSmt1S1RqVllyT1didm1AZWxkYW1h
ci5sYW4vLg0KPj4NCj4+IFRoaXMgaXNzdWUgaXMgZ2V0dGluZyBvYnNlcnZlZCBhZnRlciBo
YXZpbmcgdGhlIGJlbG93IHBhdGNoIGNoYW5nZXMsDQo+PiAyYjlhYmEwYzVkNThlMTQxZTMy
YmIxYmI0YzdjZDkxZDE5ZjA3NWI4IHNjc2k6IG1wdDNzYXM6IEZpeCByZXR1cm4NCj4+IHZh
bHVlIGNoZWNrIG9mIGRtYV9nZXRfcmVxdWlyZWRfbWFzaygpDQo+Pg0KPj4gV2hhdCBpcyBo
YXBwZW5pbmcgaXMgdGhhdCBvbiBYZW4gaHlwZXJ2aXNvciwgdGhpcw0KPj4gZG1hX2dldF9y
ZXF1aXJlZF9tYXNrKCkgQVBJIGFsd2F5cyByZXR1cm5zIGEgMzIgYml0IERNQSBtYXNrLiBJ
LmUuIEl0DQo+PiBzYXlzIHRoYXQgdGhlIG1pbmltdW0gRE1BIG1hc2sgcmVxdWlyZWQgdG8g
YWNjZXNzIHRoZSBob3N0IG1lbW9yeSBpcw0KPj4gMzIgYml0IGFuZCBoZW5jZSBtcHQzc2Fz
IGRyaXZlciBpcyBzZXR0aW5nIHRoZSBETUEgbWFzayB0byAzMmJpdC4NCj4gDQo+IFRoaXMg
c291bmRzIGVudGlyZWx5IGNvcnJlY3QgYmVjYXVzZSB0aGUgVk0gaXMgYm9vdGVkIHdpdGgg
KGZyb20gdGhlDQo+IG9yaWdpbmFsIGRlYmlhbiBidWcgcmVwb3J0KToNCj4gDQo+IGRvbTBf
bWVtPTQwOTZNLG1heDo0MDk2TSBkb20wX21heF92Y3B1cz00IGRvbTBfdmNwdXNfcGluDQo+
ICAgIHVjb2RlPXNjYW4geHB0aT1kb20wPWZhbHNlLGRvbXU9dHJ1ZSBnbnR0YWJfbWF4X2Zy
YW1lcz0xMjgNCj4gDQo+IFNvIGl0IGhhcyBubyBtZW1vcnkgYWJvdmUgNEdCIGFuZCB0aHVz
IDMyIGJpdCBhZGRyZXNzaW5nIGlzIHRoZSBtaW5pbXVtDQo+IHJlcXVpcmVkLiAgSWYgeW91
IGJvb3QgYSBtYWNoaW5lIHdpdGggPjRHQiBhbmQgWGVuIHN0aWxsIHJldHVybnMgYSAzMg0K
PiBiaXQgbWFzayBoZXJlLCB0aGVuIHdlIGhhdmUgYSBYZW4gcHJvYmxlbS4NCg0KRG9tMCBp
cyAobm9ybWFsbHkpIGEgUFYgZG9tYWluLCBzbyB0aGUgcGh5c2ljYWwgbWVtb3J5IGNhbiBi
ZSBzdGlsbCBhYm92ZQ0KNCBHQiBldmVuIHdpdGggZG9tMF9tZW0gc2V0IHRvIDRHQi4NCg0K
QnV0IHBsZWFzZSBzZWUgbXkgb3RoZXIgcmVwbHkgdG8gdGhpcyB0aHJlYWQuIEkgdGhpbmsg
YXQgbGVhc3Qgb25lIG9mIHRoZQ0KYmFja3BvcnRzIGlzIHBsYWluIHdyb25nLg0KDQoNCkp1
ZXJnZW4NCg==
--------------Cd4S1bW6l9Vep0Vez9WtewrK
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Cd4S1bW6l9Vep0Vez9WtewrK--

--------------mB8BSwhtZarR0gI4al0uD1q2--

--------------gOALCS2n06jZ1galIJq0LM4A
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNWkSsFAwAAAAAACgkQsN6d1ii/Ey+2
4Qf/UAfTnu9pQMa1zwS/7U86zvqC37V71kwwlCH9EGA55zHHS86vLn81W7BIirwwvNI1Pap23nLb
zdOwW3Sr2LgVAVP3ybq3PWkk4qk87226wVGfik0jjR9VBYNjr4YWulW6EjWwhp6TAdx4cU7SVr8D
cmNNv4LFnSqyKCubLoaacDdqjK+6tUMT0jS9jGW7LqccgDoeK5gtSrZz3D1XEA2GZA2xZw5WchMA
3phzCdOGHtafYNDVAumtJI6zFEcB8iF7ceCylBtfA8aEQiNgu+3dC9ycCsDp4dc5qhYmW5vWnbeh
VzGSuo1Hx/1zBiYuWkPflLTuMkY6sXRDx0IH9JJA0w==
=w3zw
-----END PGP SIGNATURE-----

--------------gOALCS2n06jZ1galIJq0LM4A--


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:21:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:21:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429120.679965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxOM-0006xQ-2S; Mon, 24 Oct 2022 13:21:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429120.679965; Mon, 24 Oct 2022 13:21:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxOL-0006xJ-Vc; Mon, 24 Oct 2022 13:21:21 +0000
Received: by outflank-mailman (input) for mailman id 429120;
 Mon, 24 Oct 2022 13:21:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QvrT=2Z=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1omxOK-0006x8-QV
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:21:20 +0000
Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com
 [2a00:1450:4864:20::52d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf31c4f3-539e-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 15:21:19 +0200 (CEST)
Received: by mail-ed1-x52d.google.com with SMTP id a67so31140322edf.12
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 06:21:19 -0700 (PDT)
Received: from [192.168.1.93] (adsl-67.109.242.136.tellas.gr. [109.242.136.67])
 by smtp.gmail.com with ESMTPSA id
 dk24-20020a0564021d9800b0045b910b0542sm18362632edb.15.2022.10.24.06.21.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 24 Oct 2022 06:21:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf31c4f3-539e-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=Bu11lnAeABjv2oJyt1x12pNcwXirk7pNFh3seWOOQjY=;
        b=SqUnt5lr8t07Qq796sxIeAkp1sAPI8dZsgAVH5YG7I/UroBeKg4NtHEhxBZC+5efZy
         Wbu+jZwD5pz6E0qaJyjJ5ZoZO8RR1kzcWtf81huL2/ei3Pq5OHcUZdQLsnkH/xZV+UdA
         viHnqddrnWGc7470Y+VosRKQ4fOntHKYusd7KLd5e93MjfVze8gyAdsrx9nzVVPgrR46
         mEXO5lP2CWqT/lBFReiRfZGnsMGoW3JF3Gyo4Yo1tw2HqQw/0IRahyYkdye9kUZEW2vm
         Ze4WbvEGPRvwP1NTVKIBU/IgAiffl1WUt9wvtwROt7+ETj/j5GDepE1kQFk/E11E4hgC
         JLpQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Bu11lnAeABjv2oJyt1x12pNcwXirk7pNFh3seWOOQjY=;
        b=4Gix5GXDpHrrS1gr+z6B+yDc6tjH3HbPkkLV9WZzWZus9ZTYC9zruhA+a6J5/G2ogB
         HhBrgmi+3jo2SYBN4TegfVcPNDGqKCYGXq5q/iJrZU1PrpOx6KSvdxlxSPVPzozIFtH1
         DisiUDyUgm2g3AeMsXYvq6HFhgg/gxS/x2heEVRxicoAna/NfcLHXUxNbcBUriD3q8Se
         GqVeXeuiUZuAVHTA12zdN656KYff7+NvOxIE67xVxun7MLaKkL8FP4Lgh6FDYnKLm9LK
         P5iawqA7l9EQ+TpqpCuX0RyxQOqJlzkZZATkycyt/KfeWTdFmuflAogMu4mov9JHgYqf
         gDhw==
X-Gm-Message-State: ACrzQf0vc0L/UxsteTM9DWJ1pvQZCGiApi6ZcGaa3FZHf8JcwzgXqirX
	UbljMSe/QGhIRSsjgBOZ0UY=
X-Google-Smtp-Source: AMsMyM7EZ09WYgSQBnjEQa3/C6WStUHBK9s/tiUuEdJ2G2BaNArmsZJENzW6wmK5yQ8ppfRq/jOMIw==
X-Received: by 2002:a05:6402:50cd:b0:45d:109d:676c with SMTP id h13-20020a05640250cd00b0045d109d676cmr31868606edb.344.1666617679092;
        Mon, 24 Oct 2022 06:21:19 -0700 (PDT)
Message-ID: <e03fad8b-daf8-b91f-cc1f-bf1450ecb924@gmail.com>
Date: Mon, 24 Oct 2022 16:21:16 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC PATCH v1 02/12] Arm: GICv3: Move the macros to compute the
 affnity level to arm64/arm32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-3-ayankuma@amd.com>
 <cb67c768-1a05-e5d5-efed-9a282c6a8c2a@gmail.com>
 <e0183387-8556-5fcc-2f18-003832d5cd70@amd.com>
 <78306c56-7cdd-a705-f8af-0cae4e359336@gmail.com>
 <76f1b4fc-90bd-f55f-5624-f5d011bdaa9f@amd.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <76f1b4fc-90bd-f55f-5624-f5d011bdaa9f@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/24/22 16:01, Ayan Kumar Halder wrote:
> 
> On 24/10/2022 12:35, Xenia Ragiadakou wrote:
>> Hi Ayan,
> Hi Xenia,
>>
>> On 10/24/22 14:00, Ayan Kumar Halder wrote:
>>>
>>> On 21/10/2022 22:18, Xenia Ragiadakou wrote:
>>>> On 10/21/22 18:31, Ayan Kumar Halder wrote:
>>>> Hi Ayan
>>> Hi Xenia,
>>>>
>>>>> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
>>>>> include/asm/cputype.h#L14 , these macros are specific for arm64.
>>>>>
>>>>> When one computes MPIDR_LEVEL_SHIFT(3), it crosses the width of a 32
>>>>> bit register.
>>>>>
>>>>> Refer 
>>>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
>>>>> asm/cputype.h#L54  , these macros are specific for arm32.
>>>>>
>>>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>>>> ---
>>>>>   xen/arch/arm/include/asm/arm32/processor.h | 10 ++++++++++
>>>>>   xen/arch/arm/include/asm/arm64/processor.h | 13 +++++++++++++
>>>>>   xen/arch/arm/include/asm/processor.h       | 14 --------------
>>>>>   3 files changed, 23 insertions(+), 14 deletions(-)
>>>>>
>>>>> diff --git a/xen/arch/arm/include/asm/arm32/processor.h 
>>>>> b/xen/arch/arm/include/asm/arm32/processor.h
>>>>> index 4e679f3273..3e03ce78dc 100644
>>>>> --- a/xen/arch/arm/include/asm/arm32/processor.h
>>>>> +++ b/xen/arch/arm/include/asm/arm32/processor.h
>>>>> @@ -56,6 +56,16 @@ struct cpu_user_regs
>>>>>       uint32_t pad1; /* Doubleword-align the user half of the frame */
>>>>>   };
>>>>>   +/*
>>>>> + * Macros to extract affinity level. Picked from kernel
>>>>> + */
>>>>> +
>>>>> +#define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1)
>>>>> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
>>>>> +
>>>>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>>>> +    ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK)
>>>>> +
>>
>> Above, since
>> #define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level)
>> you can replace (MPIDR_LEVEL_BITS * level) with 
>> MPIDR_LEVEL_SHIFT(level) in the definition of MPIDR_AFFINITY_LEVEL.
>> You will see that it is identical to the arm64 definition
>> #define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
> 
> Currently, MPIDR_AFFINITY_LEVEL(mpidr, 3) differs between arm32 and arm64:-
> 
> In arm32 :- (mpidr >> 24) & 0xff
> 
> In arm64 :- (mpidr >> 32) & 0xff

Correct. This is the case because the MPIDR_LEVEL_SHIFT(level) differs 
between arm32 and arm64.
The definition of MPIDR_AFFINITY_LEVEL is common in both.
More specifically, for level 3,
#define MPIDR_LEVEL_SHIFT(level) \
     ((level) << MPIDR_LEVEL_BITS_SHIFT)
#define MPIDR_AFFINITY_LEVEL(mpidr, level) \

     (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
gives (mpidr >> 24) & 0xff
While
#define MPIDR_LEVEL_SHIFT(level) \

     (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
     (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
gives (mpidr >> 32) & 0xff

> 
> I think this is what is expected. See xen/arch/arm/gic-v3.c ,
> 
> static inline uint64_t gicv3_mpidr_to_affinity(int cpu)
> {
>       uint64_t mpidr = cpu_logical_map(cpu);
>       return (MPIDR_AFFINITY_LEVEL(mpidr, 3) << 32 |
>               MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16 |
>               MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8  |
>               MPIDR_AFFINITY_LEVEL(mpidr, 0));
> }
> 
>>
>>>>>   #endif
>>>>>     #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
>>>>> diff --git a/xen/arch/arm/include/asm/arm64/processor.h 
>>>>> b/xen/arch/arm/include/asm/arm64/processor.h
>>>>> index c749f80ad9..c026334eec 100644
>>>>> --- a/xen/arch/arm/include/asm/arm64/processor.h
>>>>> +++ b/xen/arch/arm/include/asm/arm64/processor.h
>>>>> @@ -84,6 +84,19 @@ struct cpu_user_regs
>>>>>       uint64_t sp_el1, elr_el1;
>>>>>   };
>>>>>   +/*
>>>>> + * Macros to extract affinity level. picked from kernel
>>>>> + */
>>>>> +
>>>>> +#define MPIDR_LEVEL_BITS_SHIFT  3
>>>>> +#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>>>>> +
>>>>> +#define MPIDR_LEVEL_SHIFT(level) \
>>>>> +         (((1 << level) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>>>> +
>>>>> +#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>>>> +         ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>>>>> +
>>>>>   #undef __DECL_REG
>>>>>     #endif /* __ASSEMBLY__ */
>>>>> diff --git a/xen/arch/arm/include/asm/processor.h 
>>>>> b/xen/arch/arm/include/asm/processor.h
>>>>> index 1dd81d7d52..7d90c3b5f2 100644
>>>>> --- a/xen/arch/arm/include/asm/processor.h
>>>>> +++ b/xen/arch/arm/include/asm/processor.h
>>>>> @@ -118,20 +118,6 @@
>>>>>   #define MPIDR_INVALID       (~MPIDR_HWID_MASK)
>>>>>   #define MPIDR_LEVEL_BITS    (8)
>>>>>   -
>>>>> -/*
>>>>> - * Macros to extract affinity level. picked from kernel
>>>>> - */
>>>>> -
>>>>> -#define MPIDR_LEVEL_BITS_SHIFT  3
>>>>> -#define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
>>>>> -
>>>>> -#define MPIDR_LEVEL_SHIFT(level) \
>>>>> -         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>>>> -
>>>>> -#define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>>>>> -         (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
>>>>> -
>>>>>   #define AFFINITY_MASK(level)    ~((_AC(0x1,UL) << 
>>>>> MPIDR_LEVEL_SHIFT(level)) - 1)
>>>>>     /* TTBCR Translation Table Base Control Register */
>>>>
>>>> Since only the definition of the MPIDR_AFFINITY_LEVEL() differs, 
>>>> maybe you could add only this one to the arch specific headers e.g
>>>> for arm64:
>>>> #define MPIDR_LEVEL_SHIFT(level) \
>>>>     (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
>>>> for arm32:
>>>> #define MPIDR_LEVEL_SHIFT(level) \
>>>>     ((level) << MPIDR_LEVEL_BITS_SHIFT)
>>>
>>> Also, MPIDR_AFFINITY_LEVEL needs to be defined in arch specific 
>>> headers as it differs between arm32 and arm64.
>>
>> As I point out above, there is no difference between arm32 and arm64 
>> regarding the definition of MPIDR_AFFINITY_LEVEL(level).
> 
> Please see above and let me know if it makes sense.
> 
> - Ayan
> 
>>
>>>
>>> However, MPIDR_LEVEL_MASK can be defined in the common header (as it 
>>> is same for arm32 and arm64).
>>>
>>> Please let me know if it makes sense.
>>>
>>>>
>>>> But in any case don't forget to add parentheses around the macro 
>>>> parameters when an operator acts on them to avoid trouble with 
>>>> operator precedence (MISRA-C Rule 20.7 :))
>>>
>>> Thanks for pointing it out. Yes, this is a mistake in my patches.
>>>
>>> - Ayan
>>>
>>

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:22:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:22:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429129.679976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxPb-0007dw-Hf; Mon, 24 Oct 2022 13:22:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429129.679976; Mon, 24 Oct 2022 13:22:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxPb-0007dp-Ef; Mon, 24 Oct 2022 13:22:39 +0000
Received: by outflank-mailman (input) for mailman id 429129;
 Mon, 24 Oct 2022 13:22:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=smss=2Z=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1omxPZ-0007cK-G6
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:22:37 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ec7e2137-539e-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 15:22:36 +0200 (CEST)
Received: from AM7PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:20b:100::31)
 by AS2PR08MB10111.eurprd08.prod.outlook.com (2603:10a6:20b:62d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 13:22:33 +0000
Received: from VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:100:cafe::e9) by AM7PR02CA0021.outlook.office365.com
 (2603:10a6:20b:100::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19 via Frontend
 Transport; Mon, 24 Oct 2022 13:22:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT065.mail.protection.outlook.com (100.127.144.171) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Mon, 24 Oct 2022 13:22:33 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Mon, 24 Oct 2022 13:22:33 +0000
Received: from 64c6b23c766a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 244069C2-0C5B-4BD5-81E6-71B0328FE2FE.1; 
 Mon, 24 Oct 2022 13:22:26 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 64c6b23c766a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 24 Oct 2022 13:22:26 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB9814.eurprd08.prod.outlook.com (2603:10a6:20b:615::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 13:22:24 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 13:22:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec7e2137-539e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=h4LZgxv71UrXwWljPSOkwR0b+N4yXFgcj0Puz7nRwlbrJQP5OloAoCYPoi5HwYSen7tuOZJamHSOuk59KGIhfALHSBJDa/wHpvIckfL/0iT5gfl29EShtfx+oufP2xECRzP70wHLylIBNGI8ugDdWtbdkMY4DWhXCb4yhZ0Ky5yNLiYxE6REbUAxrRNOthlUaTpg6EAuiTDcABAJcHsmtvf8GavS19yQusFHpbSgBuaDpiC1bp81cwonR3+vXgOfhW1i/cSfAZA0O6lP1/D4ZI/vLRG+Q9g3OWR+i0ZNM/Or7dsWUK9n/GdcFEfMvup4MBLER3HJ0CkSiHea+7PEEw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fV+l8s9ynY6OCdNQaZuRBc1JZ1B0WK839huWElfwNYQ=;
 b=Eiv6ccP9V5K2vtJUwqoRJVe55LhKd1RFNTAbc95UieSshpGY6dcapXp5boKQdhK0+YaX3bpjQwA2V+v8TnUOpjooMD/kowmbbnWjU0pw7nVR7HSD6HlCHKssK85xhCGLgn+pF5/97rv60faqAFbVKvZxNoiGkhflgbgYVvsyt0De4MzJlfNN6YZl9lKVRfhoSgCHsZelTqQ490Cg2W+x+XdQ+Fnv5Gn4fTAShzlaYmwthiwlEbkckNtAnfocJqDDLvcIKYSyyQiNuoKt5dNFblyzuKuiEgFsapwuXWwXtrVgP7nkt1YWPvfXhQz/ArRN6LdMDEVSxqiWk+/ikKEvQQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fV+l8s9ynY6OCdNQaZuRBc1JZ1B0WK839huWElfwNYQ=;
 b=uaGnY8wcoan5a8/RXYYkIJLcNVuouQ4Em/0tNxN8FsI6nGXuaWDwJCwOXv00GHYLxAma+RpGaOPZo/4+4byV701+00ozPcp7DJGK302TNnSWaMIuW2H3zBowkfve7s8fP5HjbjIQ548MjWrw74JBL3QlrzWz46yYSso5llbXNsQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3df7fe4210ca75bd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=irPyM3Mv5Hrut2cURwc2g9HhPzXup/N0kLfo31TpfsnPcCGDkB+GPCMMGxJ2jlazlEpu0kQncQF+mtp6hRwtLYeAjbPd37bVclWXWA7CJnnTHgV4V4YYHmt+u1oakaEr6ehImJzUrQURTGErl0Wtk5DPY5FYUxh4NStaS2CloRL9Dbe3PGrZXEJJ5TbCszUbxeAkjOobRz4pFzz41SHBSiAWVsKsg9LoanXhW+j92f2ANkRihYc+zhNBteIDL5mg37s/pywCYpr4nM26J1LhZ55Dyz/Fvm2R20z+uNPsFHaFjWLmVPO6BacDaTugXNfAxWRG9zaxXH9iSzuNjtmRPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fV+l8s9ynY6OCdNQaZuRBc1JZ1B0WK839huWElfwNYQ=;
 b=njkl8qLzLcveo+8YrJiPceXGdVbZKjjpdfEIHWwNKQdl8nwdCV9cU/Eeg+PRWv6UsM5DLcXeNp052Zbx8XMLA67GxPNt0q9e7ZsJ7jdz+nfgMgb2Wb7GmaTLUmzdPvW2wba9VCNjvqP8VZFBe3+D5UmWGom0+CwnKA4mAhpFZiEJ+I4HKi3FKyJp56PdpDa9qb/4gLfKudQGj6J71wue/f/m8gI1foiCG+iisn6HQwxJ3kSpl/M5pOdlNA3resbGII1heb/6m/0rSskTvuJUFEMkvzvlOTFUqbZnKVJsKYamZ0YkJzz6xmelW87i+24JP6Tn7tSxL1bjDQGP2x5Qug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fV+l8s9ynY6OCdNQaZuRBc1JZ1B0WK839huWElfwNYQ=;
 b=uaGnY8wcoan5a8/RXYYkIJLcNVuouQ4Em/0tNxN8FsI6nGXuaWDwJCwOXv00GHYLxAma+RpGaOPZo/4+4byV701+00ozPcp7DJGK302TNnSWaMIuW2H3zBowkfve7s8fP5HjbjIQ548MjWrw74JBL3QlrzWz46yYSso5llbXNsQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Thread-Topic: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Thread-Index: AQHY5HCY/1GJrkxfi0yPJz1IUtcgr64dV76AgAAzqYCAAAMFgA==
Date: Mon, 24 Oct 2022 13:22:23 +0000
Message-ID: <F8CD5734-B62A-403E-B888-AA24053A9F03@arm.com>
References: <20221020104146.29841-1-ayankuma@amd.com>
 <AE2C68A9-4276-444C-B227-F079D330EB8A@arm.com>
 <ba43677f-903b-f30c-76e4-1668cdab2cc2@amd.com>
In-Reply-To: <ba43677f-903b-f30c-76e4-1668cdab2cc2@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB9814:EE_|VI1EUR03FT065:EE_|AS2PR08MB10111:EE_
X-MS-Office365-Filtering-Correlation-Id: 72ce3ca2-fd8b-4cd5-ae72-08dab5c2cf72
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 LUsNuRwFZvvDfEsRZWDukfvb25htyfYF5dHHjH0gFWjR7hbk/HxgOlmckQGYt2vVj+YuV2F/YSoqV3RroImL9Y0NxvLCFbfKSu2V36H6WtQEfddJZCrNbi6khYx+oTR/bk6O7hy8dNF+3vDppXMChqbght5mTtm8pVdEnaGc17cNxTVCTY0xK8k8gpCrvaxX1mT16zY+XByOYcg+8A3ni01J08MPKVZJ5v4A1DqmjfS5RNdbouU7QZbh0misCCd7j7vvC1nmjWmQAmiMyRCp4oMcSr0W8TpsS4ZGmLWAaC392xX4i9Q02e1L5sXySaAx61QSAupzsIrozt+vXz4fU5d8BkPWvQYikCAQlRO7yue6Du33ExXIQ31F5TZGlO8UAmTY0pasqi08dbvcRbUU38A3cduiqDiOKJhRZWb+iOTJ0tAp/iO2pGZZsbvtOtgG87HCjLW0NfUnbusEo2VfT0ZM14tTQz4qsD4E+Gy3Qba1D7/s+2ZjjFNYBOMfKwd8NAvKt+RYEeOI1HTiH6Ialgqnde4M8gqJTvjIFRugrliZ6tFuZnyxezOo1vHKAdiORk303K12+osGNSD098DqUYpDJ3eWI7KOnn8OswXzhzNlBbP16RWdqMaoXnBEgIWVm63P5n2Kkm4NcIsgk91zj7HOEUZvsQHgBswXmdFuu7t2jSH8+2ELxEmmqmJWBCH2dsXJE+W0KOlEiPowxtbiSo4ndyNQZBSR1H/QMtuUk8VEaTtefI0a6JQahSP13/tT7K1k0ZEqH/cyAlaKULoD7b4X7yl0N3xLYCS/D4TvreWI31O/lhV9hqPb+8BB93VEBkBH/xHqmO8xoltK4TfNfg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199015)(36756003)(33656002)(186003)(38100700002)(122000001)(83380400001)(8936002)(4326008)(91956017)(76116006)(2906002)(66556008)(66476007)(66446008)(8676002)(66946007)(64756008)(54906003)(6916009)(5660300002)(41300700001)(86362001)(316002)(2616005)(53546011)(6506007)(71200400001)(26005)(6512007)(38070700005)(478600001)(966005)(6486002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <83810C997712CB428EC919FE0D17448B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9814
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5daa0fa4-7e54-42d1-642f-08dab5c2c96d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lCMU9bv6o+floiZirMkkPp5wojQCIq2zXSCXsddwUVl1FpZaH2UIRPKVKvfSbOkwR+3r5azv//ui8AVDMu3JUMK4NnuSJURjaIHMXEbeMZFm2H2O2+SNdWVR8uWpfdlVC7e2zbloy7ezdroVTDb7xKCFV7IR4KqUd1R4733y4oko3pY8ZgIloAFwTcqNRY8Rvgag+/6ABRuBsgrHK8nOeu0qhThSY4p+jOYpRuAupZf9i/vj0DUPQije+3PdK50txRsN0L9aHWeD2ttnp2ZNYKu4+cbtnoAlA9qqVVbBmxz2Rq5NGx68gsCefUq37QMOjCaAuEiCD81yvsgMVuWGanzxkJ0EEgknZlRoWK/rGNjB40BAPzxomNYh9q3bUsNKJh3NG+D61gNM8zqr28/XtbAdbA+XhmodcIPom4NpMuwwP9kOG+6EnsbTRnApi0HHGkGt3nQZnYJTlmYrqtalr2MBrRmIWWpN2NEhpHqhjM9LLo4qWwe7HvqV9OMsP5ttibVx9q3+TiNYIezfQsTxkxJsNxDYk3fJqVCJD70BI7TH/eT3a/isU4MiA8j9F9Q7/o2OHVL9pwVSl6+JM6+YroWTjRCWi36wwSvnP6ZdZLvdrboJD6pfQMBOI6bniyoBFwCQRwLoQwext5mUTJv3mQuB7VrBN1B2da2TDm59vjmyDNzOnMzP/ZuUK1LY0VQxyy1c+tI4n9dyXsq7g6iza2BnzpkVKO1zGuDyl+jmaOzfxxz37194SqmSXjOMCPfpB7eYgFZyLdQkEcGxv8gbojkOd7fvZsuMjv2pYMcc0i8=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(47076005)(86362001)(33656002)(36860700001)(8936002)(82740400003)(81166007)(356005)(336012)(6862004)(5660300002)(70586007)(70206006)(41300700001)(8676002)(4326008)(2906002)(53546011)(82310400005)(6506007)(6486002)(107886003)(26005)(2616005)(40460700003)(40480700001)(36756003)(6512007)(54906003)(966005)(316002)(478600001)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:22:33.3622
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 72ce3ca2-fd8b-4cd5-ae72-08dab5c2cf72
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10111

SGkgQXlhbiwNCg0KPiBPbiAyNCBPY3QgMjAyMiwgYXQgMTQ6MTEsIEF5YW4gS3VtYXIgSGFsZGVy
IDxheWFua3VtYUBhbWQuY29tPiB3cm90ZToNCj4gDQo+IA0KPiBPbiAyNC8xMC8yMDIyIDExOjA2
LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgQXlhbiwNCj4gSGkgQmVydHJhbmQsDQo+
PiANCj4+PiBPbiAyMCBPY3QgMjAyMiwgYXQgMTE6NDEsIEF5YW4gS3VtYXIgSGFsZGVyIDxheWFu
a3VtYUBhbWQuY29tPiB3cm90ZToNCj4+PiANCj4+PiBSZWZlciBHSUMgdjMgc3BlY2lmaWNhdGlv
biAoQXJtIElISSAwMDY5SCBJRDAyMDkyMiksIElHUlBNT0RSIChzaW1pbGFyIHRvDQo+Pj4gSUdS
T1VQUikgaXMgcmVsZXZhbnQgb25seSB3aGVuIHRoZSBndWVzdHMgcnVuIGluIHNlY3VyZS9ub24t
c2VjdXJlIG1vZGUuDQo+PiBUaGlzIHNlbnRlbmNlIGlzIGEgYml0IG1pc2xlYWRpbmcgYXMgZ3Vl
c3RzIGFyZSBhbHdheXMgcnVubmluZyBpbiBlaXRoZXIgc2VjdXJlIG9yIG5vbi1zZWN1cmUuDQo+
IA0KPiBPaCwgbXkgdW5kZXJzdGFuZGluZyBmcm9tIHRoZSBjb21tZW50ICJXZSBkbyBub3QgaW1w
bGVtZW50IHNlY3VyaXR5IGV4dGVuc2lvbnMgZm9yIGd1ZXN0cyIgaXMgdGhhdCBYZW4gZG9lcyBu
b3QgYWxsb3cgZ3Vlc3RzIHRvIHJ1biBpbiBzZWN1cmUgbW9kZS4NCj4gDQo+IEFsc28sIGRvZXMg
WGVuIGl0c2VsZiBldmVyIHJ1biBpbiBzZWN1cmUgbW9kZSA/IEkgdGhvdWdodCBpdCB3YXMgbm8u
DQo+IA0KPiBGcm9tIGh0dHBzOi8vd2lraS54ZW5wcm9qZWN0Lm9yZy93aWtpL1hlbl9BUk1fd2l0
aF9WaXJ0dWFsaXphdGlvbl9FeHRlbnNpb25zDQo+IA0KPiAiVGhlIHByaW1hcnkgcmVxdWlyZW1l
bnQgaXMgdGhhdCB0aGUgaHlwZXJ2aXNvciBtdXN0IGJlIGxhdW5jaGVkIGluIE5vbi1TZWN1cmUg
SHlwZXJ2aXNvciBtb2RlIG9ubHkuIg0KDQpGb3IgYSBsb25nIHRpbWUgdGhlcmUgd2FzIG5vIEVM
MiBpbiBzZWN1cmUgbW9kZSBzbyB0aGF0IHdhcyBub3QgZXZlbiBwb3NzaWJsZS4NClRoaXMgaGFz
IGJlZW4gaW50cm9kdWNlZCBpbiB0aGUgcGFzdCB5ZWFyIGJ1dCBub2JvZHkgZXZlciB0ZXN0ZWQg
dGhhdCBhcGFydCBmcm9tIHRoZSB3b3JrIG9uIFI4MiBhbmQgUjUyLg0KDQpTbyBmb3Igbm93LCBY
ZW4gbXVzdCBiZSBsYXVuY2hlZCBpbiBub24gc2VjdXJlIG1vZGUsIGFueSBvdGhlciBzZXR1cCBp
cyB1bnN1cHBvcnRlZCAobWlnaHQgd29yayB0aG91Z2gpLg0KDQo+IA0KPj4gV2Ugc2hvdWxkIGp1
c3Qgc2F5IHRoYXQgd2UgZG8gbm90IHdhbnQgZ3Vlc3QgdG8gY2hhbmdlIHRoZSBncm91cCBvZiBp
bnRlcnJ1cHRzIHNvIHdlIGRvIGFzIGlmIGFsbCBndWVzdHMgYXJlIHJ1bm5pbmcgaW4gbm9uLXNl
Y3VyZS4NCj4+IA0KPj4+IEFzIFhlbiBkb2VzIG5vdCBpbXBsZW1lbnQgc2VjdXJpdHkgZXh0ZW5z
aW9ucyBmb3IgZ3Vlc3RzLCBzbyB0aGUgcmVnaXN0ZXJzDQo+Pj4gYXJlIGVtdWxhdGVkIGFzIHJl
YWQgYXMgemVyby93cml0ZSBpZ25vcmUuDQo+PiBJIHdvdWxkIHJlcGhyYXNlIHRoaXMgYXMg4oCc
WGVuIGRvZXMgc3VwcG9ydCB0byBydW4gaW4gc2VjdXJlIG1vZGUgc28gZW11bGF0ZSBhbGwgcmVn
aXN0ZXJzIGFzIHRoZSBoYXJkd2FyZSBkb2VzIGluIG5vbi1zZWN1cmUu4oCdDQo+IA0KPiBEbyB5
b3UgbWVhbiA/DQo+IA0KPiAiIFhlbiBkb2VzICpub3QqIHN1cHBvcnQgKmd1ZXN0cyogdG8gcnVu
IGluIHNlY3VyZSBtb2RlIHNvIGVtdWxhdGUgYWxsIHJlZ2lzdGVycyBhcyB0aGUgaGFyZHdhcmUg
ZG9lcyBpbiBub24tc2VjdXJlLiAiDQoNCkEgZ3Vlc3QgaXMgYWx3YXlzIHJ1bm5pbmcgaW4gdGhl
IHNhbWUgbW9kZSBhcyBYZW4uDQoNClRoZXJlIGlzIGEgcXVlc3Rpb24gZm9yIGd1ZXN0IHJ1bm5p
bmcgaW4gc2VjdXJlIG1vZGUgd2hlbiAoaWYpIFhlbiB3aWxsIHJ1biBpbiBzZWN1cmUgbW9kZTog
d2hhdCByaWdodHMgY2FuIHdlIGdpdmUgdG8gZ3Vlc3QgPw0KRnJvbSB0aGUgdGhlb3J5IHBvaW50
IG9mIHZpZXcsIGl0IGRvZXMgbm90IG1ha2Ugc2Vuc2UgZm9yIGEgZ3Vlc3QgdG8gcGxheSB3aXRo
IHRoZSBncm91cHMgSSB0aGluaywgYXMgaW50ZXJydXB0IG1hbmFnZW1lbnQgaXMgdG8gYmUgZG9u
ZSBieSBYZW4uDQoNClNvIEkgdGhpbmsgaXQgbWFrZXMgc2Vuc2UgdG8gc2F5IHRoYXQgdGhvc2Ug
aGFyZHdhcmUgcmVnaXN0ZXJzIGFyZSBub3QgYWNjZXNzaWJsZSB0byBYZW4gZ3Vlc3RzIGFzIFhl
biB3aWxsIGhhdmUgdG8gYmUgdGhlIG9uZSBwcm9ncmFtbWluZyBpbnRlcnJ1cHQgdG8gYmUgZmly
ZWQgaW4gc2VjdXJlIG9yIG5vbiBzZWN1cmUgd29ybGQuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0K
PiANCj4gLSBBeWFuDQo+IA0KPj4gDQo+PiBPbiBhIHNpZGUgbm90ZSwgdGhlIHF1ZXN0aW9uIG1p
Z2h0IGNvbWUgYXQgc29tZSBwb2ludCBpZiB3ZSBzdXBwb3J0IHRvIHJ1biBmcm9tIHNlY3VyZSBt
b2RlIG9uIGhhcmR3YXJlIHN1cHBvcnRpbmcgaXQsIGl0IGNvdWxkIGJlIHRoYXQgZG9tMCBvciBY
ZW4gaXRzZWxmIHdvdWxkIG5lZWQgdG8gbW9kaWZ5IHRob3NlLg0KPj4gDQo+PiBUaGUgY29kZSBp
cyBvaywganVzdCB0aGUgY29tbWl0IG1lc3NhZ2Ugd291bGQgbmVlZCBhIGJpdCBvZiByZXdvcmsg
SSB0aGluay4NCj4+IA0KPj4gQ2hlZXJzDQo+PiBCZXJ0cmFuZA0KPj4gDQo+Pj4gU2lnbmVkLW9m
Zi1ieTogQXlhbiBLdW1hciBIYWxkZXIgPGF5YW5rdW1hQGFtZC5jb20+DQo+Pj4gLS0tDQo+Pj4g
DQo+Pj4gT2JzZXJ2ZWQgdGhlIGlzc3VlIHdoaWxlIHJ1bm5pbmcgWmVwaHlyIG9uIFI1Mi4NCj4+
PiBBbHNvLCBmb3VuZCB0aGF0IEtWTSBoYXMgc2ltaWxhciBiZWhhdmlvdXIuDQo+Pj4gDQo+Pj4g
Q2hhbmdlcyBmcm9tOi0NCj4+PiB2MSAtIE1vdmVkIHRoZSBkZWZpbml0aW9ucyBvZiBHSUNEX0lH
UlBNT0RSLCBHSUNEX0lHUlBNT0RSTiB0byBnaWNfdjMNCj4+PiBzcGVjaWZpYyBoZWFkZXIuDQo+
Pj4gDQo+Pj4geGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2dpY192M19kZWZzLmggfCAyICsrDQo+
Pj4geGVuL2FyY2gvYXJtL3ZnaWMtdjMuYyAgICAgICAgICAgICAgICAgfCA0ICsrKysNCj4+PiAy
IGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQ0KPj4+IA0KPj4+IGRpZmYgLS1naXQgYS94
ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZ2ljX3YzX2RlZnMuaCBiL3hlbi9hcmNoL2FybS9pbmNs
dWRlL2FzbS9naWNfdjNfZGVmcy5oDQo+Pj4gaW5kZXggMzRlZDVmODU3ZC4uNzI4ZTI4ZDVlNSAx
MDA2NDQNCj4+PiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vZ2ljX3YzX2RlZnMuaA0K
Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9naWNfdjNfZGVmcy5oDQo+Pj4gQEAg
LTMwLDYgKzMwLDggQEANCj4+PiAjZGVmaW5lIEdJQ0RfQ0xSU1BJX05TUiAgICAgICAgICAgICAg
KDB4MDQ4KQ0KPj4+ICNkZWZpbmUgR0lDRF9TRVRTUElfU1IgICAgICAgICAgICAgICAoMHgwNTAp
DQo+Pj4gI2RlZmluZSBHSUNEX0NMUlNQSV9TUiAgICAgICAgICAgICAgICgweDA1OCkNCj4+PiAr
I2RlZmluZSBHSUNEX0lHUlBNT0RSICAgICAgICAgICAgICAgICgweEQwMCkNCj4+PiArI2RlZmlu
ZSBHSUNEX0lHUlBNT0RSTiAgICAgICAgICAgICAgICgweEQ3QykNCj4+PiAjZGVmaW5lIEdJQ0Rf
SVJPVVRFUiAgICAgICAgICAgICAgICAgKDB4NjAwMCkNCj4+PiAjZGVmaW5lIEdJQ0RfSVJPVVRF
UjMyICAgICAgICAgICAgICAgKDB4NjEwMCkNCj4+PiAjZGVmaW5lIEdJQ0RfSVJPVVRFUjEwMTkg
ICAgICAgICAgICAgKDB4N0ZEOCkNCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZnaWMt
djMuYyBiL3hlbi9hcmNoL2FybS92Z2ljLXYzLmMNCj4+PiBpbmRleCA3ZmI5OWE5ZmYyLi4wYzIz
ZjZkZjlkIDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9hcmNoL2FybS92Z2ljLXYzLmMNCj4+PiArKysg
Yi94ZW4vYXJjaC9hcm0vdmdpYy12My5jDQo+Pj4gQEAgLTY4NSw2ICs2ODUsNyBAQCBzdGF0aWMg
aW50IF9fdmdpY192M19kaXN0cl9jb21tb25fbW1pb19yZWFkKGNvbnN0IGNoYXIgKm5hbWUsIHN0
cnVjdCB2Y3B1ICp2LA0KPj4+ICAgICBzd2l0Y2ggKCByZWcgKQ0KPj4+ICAgICB7DQo+Pj4gICAg
IGNhc2UgVlJBTkdFMzIoR0lDRF9JR1JPVVBSLCBHSUNEX0lHUk9VUFJOKToNCj4+PiArICAgIGNh
c2UgVlJBTkdFMzIoR0lDRF9JR1JQTU9EUiwgR0lDRF9JR1JQTU9EUk4pOg0KPj4+ICAgICAgICAg
LyogV2UgZG8gbm90IGltcGxlbWVudCBzZWN1cml0eSBleHRlbnNpb25zIGZvciBndWVzdHMsIHJl
YWQgemVybyAqLw0KPj4+ICAgICAgICAgaWYgKCBkYWJ0LnNpemUgIT0gREFCVF9XT1JEICkgZ290
byBiYWRfd2lkdGg7DQo+Pj4gICAgICAgICBnb3RvIHJlYWRfYXNfemVybzsNCj4+PiBAQCAtNzgx
LDYgKzc4Miw3IEBAIHN0YXRpYyBpbnQgX192Z2ljX3YzX2Rpc3RyX2NvbW1vbl9tbWlvX3dyaXRl
KGNvbnN0IGNoYXIgKm5hbWUsIHN0cnVjdCB2Y3B1ICp2LA0KPj4+ICAgICBzd2l0Y2ggKCByZWcg
KQ0KPj4+ICAgICB7DQo+Pj4gICAgIGNhc2UgVlJBTkdFMzIoR0lDRF9JR1JPVVBSLCBHSUNEX0lH
Uk9VUFJOKToNCj4+PiArICAgIGNhc2UgVlJBTkdFMzIoR0lDRF9JR1JQTU9EUiwgR0lDRF9JR1JQ
TU9EUk4pOg0KPj4+ICAgICAgICAgLyogV2UgZG8gbm90IGltcGxlbWVudCBzZWN1cml0eSBleHRl
bnNpb25zIGZvciBndWVzdHMsIHdyaXRlIGlnbm9yZSAqLw0KPj4+ICAgICAgICAgZ290byB3cml0
ZV9pZ25vcmVfMzI7DQo+Pj4gDQo+Pj4gQEAgLTExOTIsNiArMTE5NCw3IEBAIHN0YXRpYyBpbnQg
dmdpY192M19kaXN0cl9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZv
LA0KPj4+ICAgICBjYXNlIFZSQU5HRTMyKEdJQ0RfSUNBQ1RJVkVSLCBHSUNEX0lDQUNUSVZFUk4p
Og0KPj4+ICAgICBjYXNlIFZSQU5HRTMyKEdJQ0RfSVBSSU9SSVRZUiwgR0lDRF9JUFJJT1JJVFlS
Tik6DQo+Pj4gICAgIGNhc2UgVlJBTkdFMzIoR0lDRF9JQ0ZHUiwgR0lDRF9JQ0ZHUk4pOg0KPj4+
ICsgICAgY2FzZSBWUkFOR0UzMihHSUNEX0lHUlBNT0RSLCBHSUNEX0lHUlBNT0RSTik6DQo+Pj4g
ICAgICAgICAvKg0KPj4+ICAgICAgICAgICogQWJvdmUgYWxsIHJlZ2lzdGVyIGFyZSBjb21tb24g
d2l0aCBHSUNSIGFuZCBHSUNEDQo+Pj4gICAgICAgICAgKiBNYW5hZ2UgaW4gY29tbW9uDQo+Pj4g
QEAgLTEzNzksNiArMTM4Miw3IEBAIHN0YXRpYyBpbnQgdmdpY192M19kaXN0cl9tbWlvX3dyaXRl
KHN0cnVjdCB2Y3B1ICp2LCBtbWlvX2luZm9fdCAqaW5mbywNCj4+PiAgICAgY2FzZSBWUkFOR0Uz
MihHSUNEX0lDQUNUSVZFUiwgR0lDRF9JQ0FDVElWRVJOKToNCj4+PiAgICAgY2FzZSBWUkFOR0Uz
MihHSUNEX0lQUklPUklUWVIsIEdJQ0RfSVBSSU9SSVRZUk4pOg0KPj4+ICAgICBjYXNlIFZSQU5H
RTMyKEdJQ0RfSUNGR1IsIEdJQ0RfSUNGR1JOKToNCj4+PiArICAgIGNhc2UgVlJBTkdFMzIoR0lD
RF9JR1JQTU9EUiwgR0lDRF9JR1JQTU9EUk4pOg0KPj4+ICAgICAgICAgLyogQWJvdmUgcmVnaXN0
ZXJzIGFyZSBjb21tb24gd2l0aCBHSUNSIGFuZCBHSUNEDQo+Pj4gICAgICAgICAgKiBNYW5hZ2Ug
aW4gY29tbW9uICovDQo+Pj4gICAgICAgICByZXR1cm4gX192Z2ljX3YzX2Rpc3RyX2NvbW1vbl9t
bWlvX3dyaXRlKCJ2R0lDRCIsIHYsIGluZm8sDQo+Pj4gLS0gDQo+Pj4gMi4xNy4xDQo+Pj4gDQoN
Cg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:30:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:30:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429137.679987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxWh-0008O1-9o; Mon, 24 Oct 2022 13:29:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429137.679987; Mon, 24 Oct 2022 13:29:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxWh-0008Nu-75; Mon, 24 Oct 2022 13:29:59 +0000
Received: by outflank-mailman (input) for mailman id 429137;
 Mon, 24 Oct 2022 13:29:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omxWf-0008No-PO
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:29:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omxWf-0003dn-98; Mon, 24 Oct 2022 13:29:57 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.4.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omxWf-0003Ub-2V; Mon, 24 Oct 2022 13:29:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=aM/riF4vECwYAPhwt8ZTiViVnrX0guPpxaOLGkWHUCY=; b=rdKc/kGpGtaIZvLmv9KZPDWhic
	Gaf5Wc38FmxOrXrLttieI8ahWTC8CoNO0UhbLQJclH4h2B2D8bxP/4gxXdt5e+cHCRxXHMkliWK9U
	MbNnvjldiViuauI5/I8WnnlbmygvDqkzV+w2w38rl4pYLuFz7X1TDZTZOL9lw0NRnz4k=;
Message-ID: <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
Date: Mon, 24 Oct 2022 14:29:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Deadcode discussion based on Arm NS phys timer
To: Michal Orzel <michal.orzel@amd.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 24/10/2022 12:41, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> 
> On 24/10/2022 12:51, Julien Grall wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> On 24/10/2022 10:07, Michal Orzel wrote:
>>> Hello,
>>
>> Hi Michal,
>>
>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly speaking, we are routing
>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use of it (as it uses the hypervisor timer CNTHP).
>>> This timer is fully emulated, which means that there is nothing that can trigger such IRQ. This code is
>>> a left over from early days, where the CNTHP was buggy on some models and we had to use the CNTP instead.
>>>
>>> As far as the problem itself is not really interesting, it raises a question of what to do with a deadcode,
>>> as there might be/are other deadcode places in Xen.
>>
>> There are multiple definition of deadcode. Depending on which one you
>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
>> would result to a lot of places impacted with the decision.
>>
>> So can you clarify what you mean by deadcode?
> In the timer example, I think we have both a deadcode and unreachable code.
> For the purpose of this discussion, let's take the MISRA definition of a deadcode which is a "code that can be executed
> but has no effect on the functional behavior of the program". This differs from the unreachable code definition that is
> a "code that cannot be executed". Setting up the IRQ for Xen is an example of a deadcode. Code within IRQ handler is an unreachable code
> (there is nothing that can trigger this IRQ).
> 
> What I mean by deadcode happens to be the sum of the two cases above i.e. the code that cannot be executed as well as the code that
> does not impact the functionality of the program.
> 
>>
>>> One may say that it is useful to keep it, because one day,
>>> someone might need it when dealing with yet another broken HW. Such person would still need to modify the other
>>> part of the code (e.g. reprogram_timer), but there would be less work required overall. Personally, I'm not in favor of
>>> such approach, because we should not really support possible scenarios with broken HW (except for erratas listing known issues).
>>
>> The difference between "broken HW" and "HW with known errata" is a bit
>> unclear to me. Can you clarify how you would make the difference here?
>>
>> In particular, at which point do you consider that the HW should not be
>> supported by Xen?
> I'm not saying that HW should not be supported. The difference for me between broken HW and
> HW with known errata is that for the former, the incorrect behavior is often due to the early support stage,
> using emulators/models instead of real HW, whereas for the latter, the HW is already released and it happens to be that it is buggy
> (the HW vendor is aware of the issue and released erratas). 

Thanks for the clarification. What I would call broken is anything that 
can't be fixed in software. For a not too fictional example, an HW where 
PCI devices are using the same stream ID. So effectively, passthrough 
can't be safely supported.

Regarding, not yet released HW, I don't think Xen should have workaround 
for them. I wouldn't even call it "broken" because they are not yet 
released and it is common to have bug in early revision.

> Do we have any example in Xen for supporting broken HW,
> whose vendor is not aware of the issue or did not release any errata?
I will not cite any HW on the ML. But from my experience, the vendors 
are not very vocal about issues in public (some don't even seem to have 
public doc). The best way to find the issues is to look at Linux commit.

> 
>>
>>> Also, as part of the certification/FUSA process, there should be no deadcode and we should have explanation for every block of code.
>>
>> See above. What are you trying to cover by deadcode? Would protecting
>> code with IS_ENABLED() (or #ifdef) ok?
> I think this would be ok from the certification point of view (this would at least means, that we are aware of the issue
> and we took some steps). Otherwise, such code is just an example of a deadcode/unreachable code.

Thanks for the clarification. So the exact approach will depend on the 
context....

> 
>>
>>>
>>> There are different ways to deal with a deadcode: > 1. Get rid of it completely
>>> 2. Leave it as it is

... this is my preference in the context of the timer. If the other 
don't like it, then 1 would be my preference.

In general, my preference would be either 3.3 or 3.2 (see below).

>>> 3. Admit that it can be useful one day and:
>>>     3.1. protect it with #if 0

#if 0 should not be used in Xen code. IMHO this is the worse of all the 
world.

>>>     3.2. protect it with a new Kconfig option (disabled by default) using #ifdef
>>>     3.3. protect it with a new Kconfig option (disabled by default) using IS_ENABLED (to make sure code always compile)

I would prefer 3.3 over 3.2. 3.2 would be used if it is too difficult to 
get the code compiled when !IS_ENABLED.

Similar to one if this is to move all the affected code in a separate 
file with using obj-$(CONFIG...). That would only work for large chunk 
of code and would be preferred over 3.2.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:36:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:36:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429143.679998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxdK-0001Rc-1Z; Mon, 24 Oct 2022 13:36:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429143.679998; Mon, 24 Oct 2022 13:36:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxdJ-0001RV-TY; Mon, 24 Oct 2022 13:36:49 +0000
Received: by outflank-mailman (input) for mailman id 429143;
 Mon, 24 Oct 2022 13:36:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omxdI-0001RP-6y
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:36:48 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2078.outbound.protection.outlook.com [40.107.20.78])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e79f8f86-53a0-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 15:36:46 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8719.eurprd04.prod.outlook.com (2603:10a6:102:21e::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 13:36:44 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 13:36:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e79f8f86-53a0-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PyqPWmJS8gcfLjmGOCu+8PFQzgZpTKV5Fg42YCwD6QenGiEOhF0bHKK0tr59GuKN8UMviqlhTll+kfClJdyR4cu+g9+eT3zhv8lkCNmQVe6VXaaYpsC9kb5ObMU7Yl+7raimwCapf9Ll0HshbSqH8adww6rWF94gV6lX+cfFOOSa6etIzxFkLKjWVTtYUk/UiZgSOVdcxoHddNreiUqe/FWf8Z9XDVUqUv0nJRwllrKIC7sZS2EQchv3tfK3diFZsb3B3UAeefEpbARG9RfQd/J1WzVZZxHLrKZS9hUEkft4jQatmQI5zXBLew84ZrogP+LTm4yLJQXvOAiDHvHebw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fQVVnHeufOgRvgilYAy2o7HB/4N387WL7jJGgdpiO3k=;
 b=nffkiqyqWMPpAl+MTC1U2hU7YArtHjzrurwtGJjYICmvdEW1zNmsINUdaGA4op5vkDZpSH6XcT1CZ9wnNSwHgtIx7C70ufHrEA2DxqSKYiylkcWM9rcuJZTrwd8jgoRX6bmQ9Ot/PshlYcrnG3BoXmmFrQx9Mxz9RE06KGEwsl2yo3Umj9RaqcYSRUKF6a8ycBJXmOeNl5lwwt8lTHToLfNwRSdxNDb9/q51hM8PQX0HJfJb9VNFwgv5bYMnbWx3Qr9Bt9TlHFpPPRXyMtUH0IajhROxoVR3G/mOcQ+2i8a8lGeOGjUEnW/SuCi4Csk6Fgpl48Y9b1VThhF71++CYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fQVVnHeufOgRvgilYAy2o7HB/4N387WL7jJGgdpiO3k=;
 b=oNBtpSdMmSs3C2P5+XKfO9h0duOslVxQhh86VLnLHV6yN4uRNH4pEjODYVvP/l5QUL9T5Roi3yCMcGQrXwA0sFH6OhzLEge1DSUWS4Bhs9Pn2+a9rM4JI/N7OHg/VUlpXJRBQ41SpCuhuqcgEdtQw7WU9JIuGn3M919DBFWo+OgQ9OY8PjEcIbvnK8VxcG5/Emx/yN2D0K5b4Wv3Fcf/P3mupHQUOdHNgu/hWbjAW+VMiyXfvkniEQAzpQrQXrhp6JXfhf57O7qn+AaukPUf3kJLF6czAH7G7H7lLBf5KiNVUdTVsZY0atRjRpySt9pd44fVqCdGR3SNTkqJFnHJJQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a49e42d4-90e0-8f8f-f0fa-f199d39c171d@suse.com>
Date: Mon, 24 Oct 2022 15:36:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Tim Deegan <tim@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
 <Y0k6RSI0VJhTVmEi@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y0k6RSI0VJhTVmEi@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0105.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::6) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8719:EE_
X-MS-Office365-Filtering-Correlation-Id: b1e49f0d-e1d4-4bf9-e0e3-08dab5c4ca3b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SFiz/LYgoI1HxA0nxsbBf7wajdcQI6fjU0PDTvNmKWsRA5jhy9Q1H4ZOoupBKtOLwrlAkNJiuJxJg0Ykrmrmsuldz5sxpdq7y6sx9BFwKDYgUJZ9+TWEAAV4LgIdOT/MkjgRstvVfWkUVz+uw2gjeyMxyN1QDI4jg2MNXhvBK77dA5j2nG+ePKm2KAGi5KWhhKrixxy/JKiJDgdR7zyRCaDVCdSKOZItZJYfyHTBiBzfeSfoch1uO3m0BSsfhnXX6Qg2OhZVMJQ/+/EjWcLCz+KEh83O/wnH6KxSzv3gz/cVq07PGDd0s5QfMoipQmZosfzuS6FO70zZT7us4Kt0LechzNsdG8gYUrXBzmTnMwzMRnEE85LBMhMI1GEntlyMeu15R27dVuUMBE8V4GwI9/ORRp9T9Q9+vyr0Wx9Y6RWVwUcVtSmjm+rKoLti/QreGOmKtj6/4ZTGncR+gE3h3b98RaoJRjMzHbWgump0Yj9x/cJLOJgNGAAh2h5Hzqayc/2EukyA+zBlq/6CCxu5CREDNmWxbZgBYFXLzFsUR7r485hIbHaLeY0KNzeIHJbfpnOYKooysFKAawA0B7dnRqk9CxUyACE8eNGyOOCFdzoKnvjHto/rlDS86lPAIWkiT4T9+p2qEhHO5eNFXMmBc0KJprTHsRpSx162FL1c9pVzyXUZ6t1HmLJzavEyGRVyvD8Nr4hUcdKITpC6go4yvLlpxkC1tzi+09kDiUFzftCdabchJ0CNv1OrlOTsIwzUwhs07QLiY0YV5hQWX46rP5o81aayLA0RJjIgJ02BDes=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199015)(86362001)(31696002)(83380400001)(6486002)(31686004)(478600001)(66476007)(66946007)(53546011)(8676002)(54906003)(66556008)(4326008)(36756003)(6506007)(6512007)(26005)(41300700001)(8936002)(6916009)(5660300002)(38100700002)(186003)(2906002)(2616005)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0dJZUQwTG81OVhVazh5L0FseDNDV2xCMHFGbWZSOFFXeU5NSUVGVE9IbXRX?=
 =?utf-8?B?VFlXL0g2SitxVDNoMjFZT2hLZ1RzM2lZOGNuUnJacGlrVVdlUUNyZ2s1M3Jw?=
 =?utf-8?B?S0tGT2ZVZGUvZXpKQUlSUU1WZ2VzbXFnb2F1NnA5bUEwZ2V2ZjFmRXVscXhB?=
 =?utf-8?B?cUxMVUJPUTlsY0NQUS85czZOTjFaeGQrdVZmRWt1bERiY2J5WGgwSXdrRlc0?=
 =?utf-8?B?WDA2MmFVQjkrRXZKWTlISStQM2JCR0lSWUlwSE9KSXJlS0xlbkRacHpzcWhP?=
 =?utf-8?B?R0Rvd0RtdzA1M25jMFdUSFk2Lzh1ZEpPckkrVm14a1J4cWIzSHFoclRhUGdJ?=
 =?utf-8?B?bkllcU9OMTN2ekRBSlo5a1VwOVZRMVh0dU9oRFEyOWROdmtvL1IvcnVyK3U0?=
 =?utf-8?B?dVdDR3hFaWRUK0J2eVB2aFVldVhINVBHTlcvZUViRjNDWDZsaGRNeW1mR1RG?=
 =?utf-8?B?dmRjRlhQbSs5YTRub3dpWjd0Z1hxeFhrUnBVL0tGSDZILy9kNk1lN3V4d1po?=
 =?utf-8?B?a2JQSm9zcGI2UUlSRzMyUTJoN2tiem11SSt5RCtMNWtpZWEyemVnV01JYUZJ?=
 =?utf-8?B?bTBvY2R6VmM1WXB2di9pS0NKSHdid0NyZFpMLzErUDIvRlE1MTZsNlBSbjRB?=
 =?utf-8?B?MmdLUEV6NFBjNGZTcHhwT2dJRjczKzFNT2MzZldwWFBLZHRoSGpMT0l2aVN0?=
 =?utf-8?B?ZlB3UEhPb2tiOFdNOVZWdW0vN2FKdVdrY0FOckRpVlVjWTlwV3VNbFpkcmh5?=
 =?utf-8?B?YXd2MWdYa28ydzl6ZGZOS0RsbTZOSUZUeVVTZ1owbWFBWGZVM2tFZURUWWty?=
 =?utf-8?B?TVJtV05pdUpkdTd1QlBlL1ZONElXdHoyNm5mcUlacFNiSVVDdE9uZXRUd3JS?=
 =?utf-8?B?SGozZWpreTNULzV1d08xZ0VVdjNmMGNEUXUya0E2MGRtRXNIL1dtYlkzWkto?=
 =?utf-8?B?V2w4aVRFWm12bFYzSDNrYjhJazE5Sm9aYmw1V0dNTkFidWhmS08yUkVPeFFB?=
 =?utf-8?B?cFhEL2FjVmRRYThXbzVhclBtUlZFZTIzOHRMTGV0WjRmYS84MkE3YkpYWEsy?=
 =?utf-8?B?R0szQzBmN3laemxkaHhzSHlwQ0U3c29ON1gyc1hKTUxsV3lMTDd1aCtuaGYw?=
 =?utf-8?B?OTNmWVZzeXhwbklQbXlYSk5XYkVCNk9YQjZBbzhLSWRrNm1NMlZMaXVxbHlM?=
 =?utf-8?B?S0hkNkRBSG9GdVpIVUloZ01MbWIxeE9nVUNEblBKOTNzbjdNK0diQ3VoWWhx?=
 =?utf-8?B?UTh5UEpLTXpVTjVKT2dSU2liaExoQW9SZTdLQy94UnZ1YnZoRFpPWGJmYnhm?=
 =?utf-8?B?azVxd25OWmI4bmxvS0pxUjA5UUh5dlBhbUtXcGo5UlZlSmRQcmpIcTZ2UzEv?=
 =?utf-8?B?UkVWUytuL0dVaXJPZitIdEJhMWZ2cE55UkNWRHg4eitJcUIxZnVVMDRZRmpC?=
 =?utf-8?B?WXFLSjJCQkNVTHA0cmRNallvMFlleFY1RVAwanhIc2NHZmFPNURxTlg2NVFu?=
 =?utf-8?B?anpzWVYyMWJHQnFWUDY1VXg2TEV4VGxLcDJETGxSWGRPazAxUVlaL1dPdm1z?=
 =?utf-8?B?VkxaWVNzd3ZTZHdUamJETzdmdUFubnJDUStBWVBXM0dBVVc5N1dDaW9qNk8v?=
 =?utf-8?B?TUhkTGYzdTlGY052N2txaVFvRlZ5YlVRUmw2bzBHZHQvY29Rc3J6eE9ZV3Nk?=
 =?utf-8?B?S1pNK2lOeHhhTE41Rzc4SDc2MThnaCtISU9zVHJqb1BaeUF3S0tCbzBEUGlF?=
 =?utf-8?B?MjJ0UVZIMDBPSWROci8zZW0ydEc2dTlWQVRyYUNNZVc0YVl1eVJiMEcyTk9n?=
 =?utf-8?B?T1NiOEthRHJnc3JtQjhsMUNSZ2M2UUN6RGhqYktWSFMxMHhFeVVPVnFtVEl5?=
 =?utf-8?B?bENmQWwrVHl5ZDRvTEZWN1JuK1RFWEs5SHRGU2ZJSnErMUlIOGd2aG5EdTRx?=
 =?utf-8?B?NkRxUXJpWVRuSE5wdUtESHRaRVozQnB5eU40VXZCWWdQREdnZWVQY2hHZXJC?=
 =?utf-8?B?OXhzS2JZQzh4R2Zvand3OG4vSDRUUWFiNzIwdlE2anRBMmhXWm9yNXZBcHJX?=
 =?utf-8?B?NHI5a1JBWDN6VDFUaDMvWTZuYldjb3pZcU1HcjMyRGsxRHFIeWxVazFoWG9h?=
 =?utf-8?Q?KyLOAO4KXiYK4Pb3K4xKGhtuN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1e49f0d-e1d4-4bf9-e0e3-08dab5c4ca3b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:36:43.9048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WKQmAfihSS31+Q+0F94Bi5mc7hTaRu2RiJcre0tWiW3GclNdlmp19BklcscrQ9VXn+RLQTmCDWaGVKQazg8mNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8719

On 14.10.2022 12:30, Roger Pau Monné wrote:
> On Fri, Oct 14, 2022 at 10:49:55AM +0200, Jan Beulich wrote:
>> The addition of a call to shadow_blow_tables() from shadow_teardown()
>> has resulted in the "no vcpus" related assertion becoming triggerable:
>> If domain_create() fails with at least one page successfully allocated
>> in the course of shadow_enable(), or if domain_create() succeeds and
>> the domain is then killed without ever invoking XEN_DOMCTL_max_vcpus.
>>
>> The assertion's comment was bogus anyway: Shadow mode has been getting
>> enabled before allocation of vCPU-s for quite some time. Convert the
>> assertion to a conditional: As long as there are no vCPU-s, there's
>> nothing to blow away.
>>
>> Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively")
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> A similar assertion/comment pair exists in _shadow_prealloc(); the
>> comment is similarly bogus, and the assertion could in principle trigger
>> e.g. when shadow_alloc_p2m_page() is called early enough. Replace those
>> at the same time by a similar early return, here indicating failure to
>> the caller (which will generally lead to the domain being crashed in
>> shadow_prealloc()).
> 
> It's my understanding we do care about this because a control domain
> could try to populate the p2m before calling XEN_DOMCTL_max_vcpus, and
> hence could trigger the ASSERT, as otherwise asserting would be fine.
> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

In a discussion amongst maintainers we've settled Andrew's reservations.
May I please ask for a release-ack for this change, so it can go in (as
a bug fix on top of the recent batch of XSAs)?

Thanks, Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:40:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:40:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429151.680008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxh1-0002tm-Jj; Mon, 24 Oct 2022 13:40:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429151.680008; Mon, 24 Oct 2022 13:40:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxh1-0002tf-H3; Mon, 24 Oct 2022 13:40:39 +0000
Received: by outflank-mailman (input) for mailman id 429151;
 Mon, 24 Oct 2022 13:40:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NhUR=2Z=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1omxh0-0002tY-7t
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:40:38 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2056.outbound.protection.outlook.com [40.107.21.56])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 70696bf9-53a1-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 15:40:37 +0200 (CEST)
Received: from DB6PR0801CA0043.eurprd08.prod.outlook.com (2603:10a6:4:2b::11)
 by AS8PR08MB6616.eurprd08.prod.outlook.com (2603:10a6:20b:319::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 13:40:31 +0000
Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:2b:cafe::3e) by DB6PR0801CA0043.outlook.office365.com
 (2603:10a6:4:2b::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25 via Frontend
 Transport; Mon, 24 Oct 2022 13:40:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Mon, 24 Oct 2022 13:40:31 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Mon, 24 Oct 2022 13:40:31 +0000
Received: from ca38d9adef7c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 57D24602-DA1E-46AB-BFFC-3341383A3C9D.1; 
 Mon, 24 Oct 2022 13:40:24 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca38d9adef7c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 24 Oct 2022 13:40:24 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by GV2PR08MB8270.eurprd08.prod.outlook.com (2603:10a6:150:c1::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 13:40:22 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 13:40:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70696bf9-53a1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=DzNxL7qpTU84HtqNhZlDhv31qd1Ma1QCbO59aMN2tz6raIwKy+m1kKZ8Sd4/uDS32mCHN/NIVKs1UJAlUuZdEcMitpx958mS+4gisSdsz+9K9d521CWTnN/b98wZXRUeCOOdQ16dsqyC2sm9hVgTDrQUFDdqFOmIPhAU3rhj4UJ7NBbC81JXXlG6zMMqTM8rraqY7FIsyAFESTAIEBiu6FgmPF71z75vgeCBwPhHKL292Ra6QBhB0QgACdxYlIFVawcRMz3HINUVnKLIidi2zPGN49vaElXZqYIHWXDH96Fcc5NvzDZDP5QoopbfPu75ySZruM8c7keLEqLX3HNgig==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j0ItPbOspEdCHok4Ih/WxAAsJ2IOsyYpmPSTWbnXDn0=;
 b=EqqrJ0t90/qvNmT7U1lnaoUfXSG5gf6N3aNWPUxdYQu39DzqQ+YUDy+XdLfYxrpcnza+qrLStevLg49L5GMkXTIiyrw1jAy1nPW9vL6vO1Tcx5CScFN5/Fml+oVJ+MFir1GS2V6iNcREktoSwNds7ArE1dJ7DOeWqDxANfeiLpsnpQaao4kSVYIQ1tCmF+YHNacBxKLbdM+3jdisJ2GAiX4iqXueNqzFZbpZ7Ls1hf05XkVnlKwfVLyL7qN6Z2UGuWjwWv/TWCQFHbYDspTyZ1sGsNJ/IVM8TL9IhgO2/7CvhLgQ4sfZvYtvhlgS0jDYoCCC8I6BwiNLv6yELk0VyA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j0ItPbOspEdCHok4Ih/WxAAsJ2IOsyYpmPSTWbnXDn0=;
 b=eUrecez72lZY35RvP14xJJ/33zcauKjOobWdLRjHL73kDYtMoeCJZmU2Kv2+WrtIYftGKLLmVdLBI5yEHZDzwEQ+Tj6Wr4flqbPM9FlBHLlAAy9o5DHBgqBr/Gn4LwJe66/ObrYQjRAEU0ly/TDn2r9EbDecTf2cD/UG9R3Aj34=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JTQVexDiI0On6rS/t/6HYxLGGW5ZOwVdw8ma8ne2hdCKzgxk2STy3EBO1cRAXuRuyv/2elipJTG4YpLeYz2ub2lACEClo0Xxf3WlUTVWsemdE35WIMkb8QxZJSRPKS5PWMlQeH3KL5XOssrQOMQo1ZnyQ6PwgPCdpm5hQUIh2pIhMify2mNINcNAODJu4iygLI6Qe9sCDEo53Dv5i8VwSLSjDZIxsxvd4JUTr5BXGVF0wM+JXwkANd1uAAmb6Un08KGdQ9qYYw6ulXeDveJ8OUm12MACd6QPcCWqYE89QR1XI8F38LZqHGKIsmzm2VqGdNo3+wBZ1bVtq3r/sU1d5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j0ItPbOspEdCHok4Ih/WxAAsJ2IOsyYpmPSTWbnXDn0=;
 b=A8V6dXkzKiZg/dTFnxI2asWPThzJsQIPdb57CmRwWCUBa30oewrrL/+7dwDwJBcyBMCIp8jUcM6SI51rOJds54Gok+ZvCozJ7s7tZE81+nHHyFH1eQZL72JNplJB1zQ/w9nGEdyTvpXNZ1Dfk7ZEdKcA5UxoglrLhTUVQQNdzJBAEfm0+69lqigqhDivd19Nr5LopR6sD4DRHVjYCzpHUyr55TznGMkiCPFRtgwxIBcP2vqFaHU3p4h72ZEawZSBsIlblH0rO9mIz1zX49TFkU9AGB8L+fBT32BBQc+Ciuj8aCyUW6KmBI6dMV5HKB9mdVylO7cCvMF4mLz52u7bFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j0ItPbOspEdCHok4Ih/WxAAsJ2IOsyYpmPSTWbnXDn0=;
 b=eUrecez72lZY35RvP14xJJ/33zcauKjOobWdLRjHL73kDYtMoeCJZmU2Kv2+WrtIYftGKLLmVdLBI5yEHZDzwEQ+Tj6Wr4flqbPM9FlBHLlAAy9o5DHBgqBr/Gn4LwJe66/ObrYQjRAEU0ly/TDn2r9EbDecTf2cD/UG9R3Aj34=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, Tim Deegan
	<tim@xen.org>, George Dunlap <george.dunlap@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: RE: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Thread-Topic: [PATCH][4.17] x86/shadow: drop (replace) bogus assertions
Thread-Index: AQHY36n+iILu5HD1FUmlvrXgbBOgba4NsKGAgA/rWACAAADm4A==
Date: Mon, 24 Oct 2022 13:40:21 +0000
Message-ID:
 <AS8PR08MB7991B0BEB04D02AB91BAA3BD922E9@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <e447da22-23d6-d3db-313d-4e4ca009c3df@suse.com>
 <Y0k6RSI0VJhTVmEi@Air-de-Roger>
 <a49e42d4-90e0-8f8f-f0fa-f199d39c171d@suse.com>
In-Reply-To: <a49e42d4-90e0-8f8f-f0fa-f199d39c171d@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 5260DD7CD4B1394289A6C36D187A060B.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|GV2PR08MB8270:EE_|DBAEUR03FT018:EE_|AS8PR08MB6616:EE_
X-MS-Office365-Filtering-Correlation-Id: 97222271-2a22-4eb1-5373-08dab5c551cb
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Fjh7ElhJPKn5EAcyzLcC0Ar5stcFZzqeUkWZ+qTtHCl5M3cg3sI+tCqz9sM1OKGYXzVq/SxC06U5xIjAHiA21zmZB+KhPaLBbdNSv8q9qDhvsBglA2IyDbzaGep2vK78LHiWxleInATbFzSaSgdgA4+vcU0I3MTjo5qaRZVLpx9INx8cweNNR6+yl2U2hNFQpQVK8rB8NJc4elRyD0kP0YffbrwZfhDWVpl1dDdgNrzY0JVoTFL7945B3638nv5FaqhA9KryT5upS9MWBpGgXfS4mg8Qf+41pU4DS0PcA9fSy4rrW7zlXk3mAXmL7/3AGZLtmEXrPeEwt5+KTBGdwR0NJZ3iD9nnRCVvC1c3NYwxK8u/9c9ybqjq78BD7I3mwGVm1HWllQLmhckdklbGUExgo8WU1HiIAl09C7VdwvPK5niWQVIxpn97Sh4Io53xxHoLpzyB5Eka3K5AQhF0AtucGVUuG3R5KdQFciVy+NfQ89hi+FzIDcV4U3pKVVdS+LRwoHSwLqC/HM0GXY/C2bFe2IRp2cuqOo7VnZ4XDszJCUQoTXJNaSLxTxZDllHmlWkAyyShVMk8BPorgzGiYtO4hOjHzoRDNxols8lRkeNi8a5OHsh6HTN4SzWSxGyppBjhBiIDSjffQNvB7LHsaUhA32F753nPiIGGrGjXG40bvr6mipXf/k2YfSIulobikGoxZL1C2HFYgG8m79YHIpv7snuUxCPxgqZjfu8zqVi1vuFH3YLWIEP96mAH2JkdtV8z0p30NLiJ7fvjk3537Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199015)(66476007)(66446008)(66946007)(8676002)(66556008)(4326008)(33656002)(64756008)(6916009)(54906003)(76116006)(41300700001)(86362001)(2906002)(316002)(83380400001)(9686003)(478600001)(186003)(6506007)(55016003)(38070700005)(122000001)(71200400001)(53546011)(26005)(38100700002)(7696005)(8936002)(52536014)(5660300002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8270
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	32fe857c-d930-461b-c6fc-08dab5c54c34
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ltTubmh5WxW3XcZ5x61XtZ9JH62xxzWtZNI2LRoQyQU1QWb073xEyjk5GtXfG20piv2DWX2eSq9ey1IqL5ZjfFDF/3MjcsxR18GagQqP4oqCYJ3N3dr11OTDBvbUClLaufTmTzDsh8Hi3OpRCa98CVl+sg+cpSgAWkvmilUEMt8f1XWJDPg6xrytdEe0/tXdeeQd9XAZkF5o0GPJFQc6VSj4ivsndhpyA2wYLexGLHIxvMyrTnkZUg2YdxDBPpQLDspriYT7xN0+2A1OcLpgHIU1fNw3TlkVdhmaZyZisWW3EgyIzZCWc7sN4lZBp8NDIya/doaztHtqLHg1AeHVp8Qu0fPb4KPiE2SDwN+Gymu9KLAQSNOqnpfqpK1qNy4e3U7SkRht1bkhyDa76v44I/qqunrCGyQws/5ZSM5uOrZfAm1stiCVwqX9mEoGXMZ2zKSWAyZso0jqBnocegBl9KUX+gkhOB6JChtUodEgp4VHbXI7oLtmiCIJHxOi9F9GDJQIJ+wbuzMw7ZDEjonFTA100r7zWxXVco7oAg2tLixNdlQ8Ond6v400FYn0OEiSNaXu5xnfRnm1D0/Al4q592D/OetnUzbCdWq8dcEV5zfy8o8nbOl4PNpwDNsTD5pM4aWINM1lI8Z1l9tHT3YGnYjDb/RxvqevUz+/VixsnoN+lsRJnjVsCD+ftjiUV+BeAaapoPdnz3v3SX+PeCIR3/YT1HzGJxMU+2+2xfYgx2xGEbs4bWRBDbBhdp2gklkDH/roK6goNek1XPYMRTYVHg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(70586007)(70206006)(8676002)(40460700003)(86362001)(6862004)(4326008)(54906003)(316002)(8936002)(5660300002)(52536014)(33656002)(83380400001)(40480700001)(53546011)(41300700001)(55016003)(81166007)(356005)(82310400005)(26005)(82740400003)(107886003)(7696005)(478600001)(6506007)(186003)(336012)(47076005)(36860700001)(9686003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:40:31.1810
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 97222271-2a22-4eb1-5373-08dab5c551cb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6616

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF1bNC4xN10geDg2
L3NoYWRvdzogZHJvcCAocmVwbGFjZSkgYm9ndXMgYXNzZXJ0aW9ucw0KPiANCj4gT24gMTQuMTAu
MjAyMiAxMjozMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToNCj4gPiBPbiBGcmksIE9jdCAxNCwg
MjAyMiBhdCAxMDo0OTo1NUFNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPj4gVGhlIGFk
ZGl0aW9uIG9mIGEgY2FsbCB0byBzaGFkb3dfYmxvd190YWJsZXMoKSBmcm9tIHNoYWRvd190ZWFy
ZG93bigpDQo+ID4+IGhhcyByZXN1bHRlZCBpbiB0aGUgIm5vIHZjcHVzIiByZWxhdGVkIGFzc2Vy
dGlvbiBiZWNvbWluZyB0cmlnZ2VyYWJsZToNCj4gPj4gSWYgZG9tYWluX2NyZWF0ZSgpIGZhaWxz
IHdpdGggYXQgbGVhc3Qgb25lIHBhZ2Ugc3VjY2Vzc2Z1bGx5IGFsbG9jYXRlZA0KPiA+PiBpbiB0
aGUgY291cnNlIG9mIHNoYWRvd19lbmFibGUoKSwgb3IgaWYgZG9tYWluX2NyZWF0ZSgpIHN1Y2Nl
ZWRzIGFuZA0KPiA+PiB0aGUgZG9tYWluIGlzIHRoZW4ga2lsbGVkIHdpdGhvdXQgZXZlciBpbnZv
a2luZyBYRU5fRE9NQ1RMX21heF92Y3B1cy4NCj4gPj4NCj4gPj4gVGhlIGFzc2VydGlvbidzIGNv
bW1lbnQgd2FzIGJvZ3VzIGFueXdheTogU2hhZG93IG1vZGUgaGFzIGJlZW4NCj4gZ2V0dGluZw0K
PiA+PiBlbmFibGVkIGJlZm9yZSBhbGxvY2F0aW9uIG9mIHZDUFUtcyBmb3IgcXVpdGUgc29tZSB0
aW1lLiBDb252ZXJ0IHRoZQ0KPiA+PiBhc3NlcnRpb24gdG8gYSBjb25kaXRpb25hbDogQXMgbG9u
ZyBhcyB0aGVyZSBhcmUgbm8gdkNQVS1zLCB0aGVyZSdzDQo+ID4+IG5vdGhpbmcgdG8gYmxvdyBh
d2F5Lg0KPiA+Pg0KPiA+PiBGaXhlczogZTdhYTU1YzBhYWIzICgieDg2L3AybTogZnJlZSB0aGUg
cGFnaW5nIG1lbW9yeSBwb29sDQo+IHByZWVtcHRpdmVseSIpDQo+ID4+IFJlcG9ydGVkLWJ5OiBB
bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiA+Pg0KPiA+PiBBIHNp
bWlsYXIgYXNzZXJ0aW9uL2NvbW1lbnQgcGFpciBleGlzdHMgaW4gX3NoYWRvd19wcmVhbGxvYygp
OyB0aGUNCj4gPj4gY29tbWVudCBpcyBzaW1pbGFybHkgYm9ndXMsIGFuZCB0aGUgYXNzZXJ0aW9u
IGNvdWxkIGluIHByaW5jaXBsZSB0cmlnZ2VyDQo+ID4+IGUuZy4gd2hlbiBzaGFkb3dfYWxsb2Nf
cDJtX3BhZ2UoKSBpcyBjYWxsZWQgZWFybHkgZW5vdWdoLiBSZXBsYWNlDQo+IHRob3NlDQo+ID4+
IGF0IHRoZSBzYW1lIHRpbWUgYnkgYSBzaW1pbGFyIGVhcmx5IHJldHVybiwgaGVyZSBpbmRpY2F0
aW5nIGZhaWx1cmUgdG8NCj4gPj4gdGhlIGNhbGxlciAod2hpY2ggd2lsbCBnZW5lcmFsbHkgbGVh
ZCB0byB0aGUgZG9tYWluIGJlaW5nIGNyYXNoZWQgaW4NCj4gPj4gc2hhZG93X3ByZWFsbG9jKCkp
Lg0KPiA+DQo+ID4gSXQncyBteSB1bmRlcnN0YW5kaW5nIHdlIGRvIGNhcmUgYWJvdXQgdGhpcyBi
ZWNhdXNlIGEgY29udHJvbCBkb21haW4NCj4gPiBjb3VsZCB0cnkgdG8gcG9wdWxhdGUgdGhlIHAy
bSBiZWZvcmUgY2FsbGluZyBYRU5fRE9NQ1RMX21heF92Y3B1cywNCj4gYW5kDQo+ID4gaGVuY2Ug
Y291bGQgdHJpZ2dlciB0aGUgQVNTRVJULCBhcyBvdGhlcndpc2UgYXNzZXJ0aW5nIHdvdWxkIGJl
IGZpbmUuDQo+ID4NCj4gPj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1
c2UuY29tPg0KPiA+DQo+ID4gQWNrZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj
aXRyaXguY29tPg0KPiANCj4gSW4gYSBkaXNjdXNzaW9uIGFtb25nc3QgbWFpbnRhaW5lcnMgd2Un
dmUgc2V0dGxlZCBBbmRyZXcncyByZXNlcnZhdGlvbnMuDQo+IE1heSBJIHBsZWFzZSBhc2sgZm9y
IGEgcmVsZWFzZS1hY2sgZm9yIHRoaXMgY2hhbmdlLCBzbyBpdCBjYW4gZ28gaW4gKGFzDQo+IGEg
YnVnIGZpeCBvbiB0b3Agb2YgdGhlIHJlY2VudCBiYXRjaCBvZiBYU0FzKT8NCg0KQWJzb2x1dGVs
eS4gVGhhbmtzIGZvciBub3RpY2luZy4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8
SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBUaGFu
a3MsIEphbg0K


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:41:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:41:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429155.680020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxi5-0003R8-UC; Mon, 24 Oct 2022 13:41:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429155.680020; Mon, 24 Oct 2022 13:41:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxi5-0003R1-RR; Mon, 24 Oct 2022 13:41:45 +0000
Received: by outflank-mailman (input) for mailman id 429155;
 Mon, 24 Oct 2022 13:41:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omxi4-0003Qv-FB
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:41:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omxi3-0003rD-Vn; Mon, 24 Oct 2022 13:41:43 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.4.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omxi3-00042Y-Of; Mon, 24 Oct 2022 13:41:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=q1mebNq4mBwcBiH8MbFQbAb1pm3sXjsk1AW26I9mJwk=; b=g/cm0xC5f0SWrNOKyYqfFPp8qv
	AYjaMgaVpmOS8IFZEYMioGYqeVCiwoIH4NN4upzRDuHI7npzRJgJRtIPLsdqxaeFZs6S3gli2hGUB
	n0iOg4+CS7Fa8GBWYM22T4RxHNsIpvYWvrAlx5e/jEr/VwQxn4FUnYTnkVwoz+qP1vGg=;
Message-ID: <e083c3c3-3978-4339-ab5b-030d32d05325@xen.org>
Date: Mon, 24 Oct 2022 14:41:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for
 AArch32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-4-ayankuma@amd.com>
 <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
 <e952fcd7-bab6-68ed-d884-6505e529a073@amd.com>
 <b0b4fc69-3da3-3229-77d9-9fe0f4bf1ec3@xen.org>
 <a27873a3-3697-9a67-16aa-f4340dc622aa@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <a27873a3-3697-9a67-16aa-f4340dc622aa@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 24/10/2022 13:49, Ayan Kumar Halder wrote:
> 
> On 24/10/2022 12:01, Julien Grall wrote:
>>
>>
>> On 24/10/2022 11:47, Ayan Kumar Halder wrote:
>>>
>>> On 22/10/2022 11:13, Julien Grall wrote:
>>>> Hi Ayan,
>>>
>>> Hi Julien,
>>>
>>> I need some clarification.
>>>
>>>>
>>>> Title: The code you are modifying below is not GICv3 specific. I 
>>>> would suggest the following title:
>>>>
>>>> xen/arm: vreg: Support vreg_reg64_* helpers on Aarch32
>>>>
>>>> On 21/10/2022 16:31, Ayan Kumar Halder wrote:
>>>>> In some situations (eg GICR_TYPER), the hypervior may need to emulate
>>>>> 64bit registers in aarch32 mode. In such situations, the hypervisor 
>>>>> may
>>>>> need to read/modify the lower or upper 32 bits of the 64 bit register.
>>>>>
>>>>> In aarch32, 64 bit is represented by unsigned long long. Thus, we need
>>>>> to change the prototype accordingly.
>>>>>
>>>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>>>> ---
>>>>>   xen/arch/arm/include/asm/vreg.h | 23 ++++++++---------------
>>>>>   1 file changed, 8 insertions(+), 15 deletions(-)
>>>>>
>>>>> diff --git a/xen/arch/arm/include/asm/vreg.h 
>>>>> b/xen/arch/arm/include/asm/vreg.h
>>>>> index f26a70d024..ac6e702c5c 100644
>>>>> --- a/xen/arch/arm/include/asm/vreg.h
>>>>> +++ b/xen/arch/arm/include/asm/vreg.h
>>>>> @@ -95,7 +95,7 @@ static inline bool vreg_emulate_sysreg(struct 
>>>>> cpu_user_regs *regs, union hsr hsr
>>>>>    * Note that the alignment fault will always be taken in the guest
>>>>>    * (see B3.12.7 DDI0406.b).
>>>>>    */
>>>>> -static inline register_t vreg_reg_extract(unsigned long reg,
>>>>> +static inline register_t vreg_reg_extract(unsigned long long reg,
>>>>>                                             unsigned int offset,
>>>>>                                             enum dabt_size size)
>>>>>   {
>>>>> @@ -105,7 +105,7 @@ static inline register_t 
>>>>> vreg_reg_extract(unsigned long reg,
>>>>>       return reg;
>>>>>   }
>>>>>   -static inline void vreg_reg_update(unsigned long *reg, 
>>>>> register_t val,
>>>>> +static inline void vreg_reg_update(unsigned long long *reg, 
>>>>> register_t val,
>>>>>                                      unsigned int offset,
>>>>>                                      enum dabt_size size)
>>>>>   {
>>>>> @@ -116,7 +116,7 @@ static inline void vreg_reg_update(unsigned 
>>>>> long *reg, register_t val,
>>>>>       *reg |= ((unsigned long)val & mask) << shift;
>>>>>   }
>>>>>   -static inline void vreg_reg_setbits(unsigned long *reg, 
>>>>> register_t bits,
>>>>> +static inline void vreg_reg_setbits(unsigned long long *reg, 
>>>>> register_t bits,
>>>>>                                       unsigned int offset,
>>>>>                                       enum dabt_size size)
>>>>>   {
>>>>> @@ -126,7 +126,7 @@ static inline void vreg_reg_setbits(unsigned 
>>>>> long *reg, register_t bits,
>>>>>       *reg |= ((unsigned long)bits & mask) << shift;
>>>>>   }
>>>>>   -static inline void vreg_reg_clearbits(unsigned long *reg, 
>>>>> register_t bits,
>>>>> +static inline void vreg_reg_clearbits(unsigned long long *reg, 
>>>>> register_t bits,
>>>>>                                         unsigned int offset,
>>>>>                                         enum dabt_size size)
>>>>>   {
>>>>> @@ -149,7 +149,7 @@ static inline void 
>>>>> vreg_reg##sz##_update(uint##sz##_t *reg,             \
>>>>>                                            register_t 
>>>>> val,                \
>>>>>                                            const mmio_info_t 
>>>>> *info)       \
>>>>> { \
>>>>> -    unsigned long tmp = 
>>>>> *reg;                                           \
>>>>> +    unsigned long long tmp = 
>>>>> *reg;                                      \
>>>>> \
>>>>>       vreg_reg_update(&tmp, val, info->gpa & 
>>>>> (offmask),                   \
>>>>> info->dabt.size);                                   \
>>>>> @@ -161,7 +161,7 @@ static inline void 
>>>>> vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
>>>>>                                             register_t 
>>>>> bits,              \
>>>>>                                             const mmio_info_t 
>>>>> *info)      \
>>>>> { \
>>>>> -    unsigned long tmp = 
>>>>> *reg;                                           \
>>>>> +    unsigned long long tmp = 
>>>>> *reg;                                      \
>>>>> \
>>>>>       vreg_reg_setbits(&tmp, bits, info->gpa & 
>>>>> (offmask),                 \
>>>>> info->dabt.size);                                  \
>>>>> @@ -173,7 +173,7 @@ static inline void 
>>>>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>>>>                                               register_t 
>>>>> bits,            \
>>>>>                                               const mmio_info_t 
>>>>> *info)    \
>>>>> { \
>>>>> -    unsigned long tmp = 
>>>>> *reg;                                           \
>>>>> +    unsigned long long tmp = 
>>>>> *reg;                                      \
>>>>> \
>>>>>       vreg_reg_clearbits(&tmp, bits, info->gpa & 
>>>>> (offmask),               \
>>>>> info->dabt.size);                                \
>>>>> @@ -181,15 +181,8 @@ static inline void 
>>>>> vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
>>>>>       *reg = tmp; \
>>>>>   }
>>>>>   -/*
>>>>> - * 64 bits registers are only supported on platform with 64-bit long.
>>>>> - * This is also allow us to optimize the 32 bit case by using
>>>>> - * unsigned long rather than uint64_t
>>>>> - */
>>>>
>>>> The comment above explain why we never use uint64_t in the helpers 
>>>> above. IIRC, the compiler would end up to use 2 registers on AArch32 
>>>> even for the vreg_reg32_* helpers. I wanted to avoid that and would 
>>>> like like to today. Can you check the code generated?
>>>
>>> I am not sure I understood the comment very well.
>>>
>>> With this patch, the disassembly is as follows :-
>>>
>>>          vreg_reg32_update(&v->domain->arch.vgic.ctlr, r, info);
>>>    28124c:   e597000c    ldr r0, [r7, #12]
>>> VREG_REG_HELPERS(32, 0x3);
>>>    281250:   e5d52002    ldrb    r2, [r5, #2]
>>>    281254:   e1a02322    lsr r2, r2, #6
>>>      unsigned long mask = VREG_REG_MASK(size);
>>
>> Hmmm... Shouldn't this be "unsigned long long"?
> 
> The function looks like

Right. My question was why is this still a "unsigned long" with your 
patch? If the caller wanted to access the top 32-bit of a 64-bit value...

> 
> static inline void vreg_reg_update(unsigned long long *reg, register_t val,
>                                     unsigned int offset,
>                                     enum dabt_size size)
> {
>      unsigned long mask = VREG_REG_MASK(size);
>      int shift = offset * 8;
> 
>      *reg &= ~(mask << shift);


... we would have 'mask << 32' which is AFAIU "undefined" because 'mask' 
is 'unsigned long'. Same...


>      *reg |= ((unsigned long)val & mask) << shift;

... here. The operation would need to be done on 64-bit rather than 32-bit.

>>>
>>>>
>>>> For other options, I would consider to either:
>>>>   1) Fold vreg_reg_* in the macros.
>>>
>>> Can you explain this option a bit ?
>>
>> At the moment, we have generic helpers for vreg_reg_*. They are only 
>> called within the helper generated by VREG_REG_HELPERS().
>>
>> If we make those helpers size specific, then the only the 64-bit 
>> helpers would use uint64_t local variables.
>>
>> As they are only called in one place, we could fold them in the 
>> existing helpers.
> 
> Just to make sure, I understand this. The code would look like below
> 
> #define VREG_REG_HELPERS(type, offmask)                         \
> 
> static inline void vreg_reg_##type##_update(type *reg, register_t val, 
>         \
> 
>      const mmio_info_t *info)        \
> 
> {                                                  \
> 
> unsigned long mask = VREG_REG_MASK(size);                     \
> 
> unsigned int offset = info->gpa & (offmask);       \
> 
> int shift = offset * 8;                                            \
> 
> *reg &= ~(mask << shift);                                            \
> *reg |= ((unsigned long)val & mask) << shift;           \
> 
> }

This implementation is not correct for 64-bit register. It would need to 
look like (untested):

static inline void vreg_reg##sz##_update(uint##sz##_t *reg,
                                          register_t val,
                                          const mmio_info_t *info)
{
     uint##sz##_t tmp = *reg;
     uint##sz##_t mask = VREG_REG_MASK(info->dabt.size);
     unsigned int offset = info->gap & (offsetmask);

     *reg &= ~(mask << shift);
     *reg |= ((uint##sz##_t)val & mask) << shift;
}

> 
> 
> #define vreg_reg_update(reg, val, info)     \
> 
> do {                        \
> 
>      if (sizeof(reg) == 4)                 \
> 
>            vreg_reg_uint32_t_update(reg, val, info);                \
> 
>      else if (sizeof(reg) == 8)               \
> 
>          vreg_reg_uint64_t_update(reg, val, info);              \
> 
>      else                           \
> 
>          BUG();                        \
> 
> } while(0);                           \

After your change above, nobody will call vreg_reg_update(). So no need 
to re-implement the function. You can simply drop it.

> 
> 
> Similar implementation will be for vreg_reg_clearbits(), 
> vreg_reg_setbits() and vreg_reg_extract()
> 
> 
> VREG_REG_HELPERS(uint32_t, 0x3);
> 
> VREG_REG_HELPERS(uint64_t, 0x7);
> 
> 
> And the functions would be invoked as follows :-
> 
> vreg_update(&priority, r, info);

The code should use vreg_reg<sz>_update() rather than the generic one. 
At least it will be clear from the caller which size is expected.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 13:59:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 13:59:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429164.680035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxzB-0005EC-Em; Mon, 24 Oct 2022 13:59:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429164.680035; Mon, 24 Oct 2022 13:59:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omxzB-0005E5-BK; Mon, 24 Oct 2022 13:59:25 +0000
Received: by outflank-mailman (input) for mailman id 429164;
 Mon, 24 Oct 2022 13:59:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omxz9-0005Dz-SY
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 13:59:23 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0fdfab0c-53a4-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 15:59:22 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7284.eurprd04.prod.outlook.com (2603:10a6:20b:1dc::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 13:59:20 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 13:59:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fdfab0c-53a4-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BIfN1peJjQsThpSXq4U0OuTA6rXwpeBnkuFz1Wx8DlmTsTpSAd4rrVmyAm6DXwK7n1luwnJ4mt5QfqjTk0ozmfIc87ZT/3ihv1JXNCwNQz3Hy8nZlLxhmH/zmFpcHPJKu1EsxInP56AerWhb5VWrdg+gfqmWeTSjHWgtv6OPaOCyAv7Pqz7ebLy+Zr5c6RucvXONnB74fhCDnDURBz26h/rpDTYFyp0THai2X8EGepB4E1qCiynNYYSoS7w5Y+HnHlaDjLoHNPPnOG0J4REasIcplU5pSwHDFOQx8lG4nRU3J2sqkSPjdvUHIlP/foaZcASQpWslzfAYF8NrpBShKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rzW76HaIhRVE8PDvR7iHadZ0BBffyIqYRW9ZWyBNlJ8=;
 b=BTTWpSWBsNeCAVZ4L5yM7GzSAGJ6SXq2ka8VyIPL7jQBjEGxH2lRZD+TEfBU5/dVl5QjIjUukGK1yYGG43THoxJElClXn7VgcLUBQN+R8Lo/6RzO8Zp8lvcESIKtF8izuOdrE3niAc+h3U3wiSsaswsUfxRBkQ4mrnVdJQSRkd1gfCBiJ9jQJvYFQve4lRCZr7+ucwvr6VgYia7Y6b2Kzu4yKoDqVk9lvEUjOg9lZQmrdQJLi/8KjbMSMSzc6wBJMCyqCvVRwPo/EY8i3c3A5DJFOogKVGFdLy7Cm8Zo9amRcBPQmy/z0gaiYTj1gj4EXO32ADPBJZ6tAeSGr3gInQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rzW76HaIhRVE8PDvR7iHadZ0BBffyIqYRW9ZWyBNlJ8=;
 b=fXC/s7DvCahPw5ViJQ6rgje9LF/5xYhB8pWNu7FN41wp+q7So18GGx1J5VItSzfnaiDv8IAInhb4BHhlckkOwrd/9jwVzTZlGOwR7w+LBtLOykqUBEJb0OiYKuduBDaNwyKZ495XdT4O+5YMBvdbKckkVeAmp6ABd9gKvl9yFCX65NrV4dswvQqBdvv/x1Bbts3ZTiXGtzn/+QKekTi0bJHNC8VK0O8sjLmLz/cf5KQRbVWu0YN4zm4yuq06SEG4h4fhm0+bwydfHb19o9xpXONeOwsCoU8VgyLEaeVz3WAdDE7zHpzPblNGHrp2C9o/7llTKQkai1MAoLSEbWKbmw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <730158ce-d168-5dbf-38cc-78cdedcfe33e@suse.com>
Date: Mon, 24 Oct 2022 15:59:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 5/6] pci: do not disable memory decoding for
 devices
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul@xen.org>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-6-roger.pau@citrix.com>
 <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
 <Y1aI5Lbi3sysIZVv@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1aI5Lbi3sysIZVv@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS8PR07CA0042.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::29) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7284:EE_
X-MS-Office365-Filtering-Correlation-Id: 52ea5602-f599-4023-b6b0-08dab5c7f274
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aQmkRnInDHDNclidibOu5Pj/dLhj/eOOq3gkHRvEXwTlOwqXL8SHK9sdSlWUZh9dLHZAAvPn+COPkaUu8Oa+0xlRkMxzzF5xgi1rFzGdGJr/bB2ZqvxigWLVsfRXu4SR6s7BLGAVgAz6HRIDuEn7qQ0xo5zpFsY0mPlyLsz3sOtTyvr2t7eNLwva4/bQZrrfTsKweokJ9Q6Pk1sAqc5WcWotbvflPHvItINF8uNPmaATGEDtWmPyvNrdIUnGWcT8JQCiPwq82Pja12EPFiMimgRXTUfcNM5tBKw3d056CBeAAMb3QTseXmfLEAUsZGuZwDkB36igD7r7wkR62InSHh0P8UmV7wwBoDqvq//8oPjsgU3BpUcPXqvylEMr0rGVMNAR3u9u28+U1g+MokPuWdakVoPcPmN1+ii7SCoNxrYmtSOzdHdetneOHvmwil+x6jtVe/CT9yKLlzG6p+0mx5EgTO2i8vTZjwHOjcSv7GHBwBCMS37IA+3+c46l6XEMODtbxeOBcjsb6KElWbuck9YlOYVbQhaN63hipJe2W2zA64v6bR6RqQaC5ktk7FSEtlSRHGw9bZDzbhAcAT5fVLfyGHbqGtVLRZCh3pBCky+03GN5ly9oNF4EnkOfA616FbvMAenFaYdlOdNoNYJ6P+t8gFKhpQMp+Vq6txD1BGszJIBC++QAUzRttas1/D2MZqZV2fzCtE6qdNf9znyWk01x+mGI3rphN6lUK6XcPKl/5kJi1qbesjfzeH+Ju5N/LC2oK6LC2GP1UO1KplD2yRPWdtkSd2y0O+YJ4xbIEnM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(39860400002)(376002)(451199015)(31686004)(6506007)(6512007)(53546011)(316002)(26005)(36756003)(6916009)(66476007)(66556008)(4326008)(31696002)(86362001)(8676002)(66946007)(41300700001)(8936002)(5660300002)(2906002)(478600001)(6486002)(83380400001)(38100700002)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUtXckNuRzZFeXNGelZoVUF6ZnV6cjRZcnJzWHJ6L2hPRHRLRVhzeml6b2pT?=
 =?utf-8?B?QUJJSE93WkJtZWw1N09xUE16T2xrZHpvUDdrZ1J0QkN4eEpzdWtvRUljc1RO?=
 =?utf-8?B?elBGcmovSVJHbUFEdXRxK09RMHRJUFhSYmFGQUp4UmhVZSttcmNrNEhQN3ow?=
 =?utf-8?B?ZlFLV3pYM0w3UGtpeUxQYTJQZzJpTWt3UlRyVFJpY0VOWFdPVjVBZXQ3K2cx?=
 =?utf-8?B?dXAyZnQrb25EYTdwSGpaZ3BJTW1ocjFpajltQkhKRFc5MWpBc3J4S0dUY2pJ?=
 =?utf-8?B?VHlCaHRDUkhreWtlWXRNU095eldqejB3UmhNdTlWMTV3eFBRY2l6QlJ0TVRy?=
 =?utf-8?B?V1BMVFBRb0JuYlh1d3lnbVZxREJaSk93REtEVjNPRE56MWNsa2FUYVVDekdv?=
 =?utf-8?B?SEZneWNBdjI4VkVCd3FPaWdPTkR1YW1la081TXdjYTBRZHdrWHdOQ3FUT0xG?=
 =?utf-8?B?NVhsUGJqU3lQaEo5NkVNZ1NzQTVoSzEzc1FNM3o1M1lGM0k2Z2wvY1JsSmJs?=
 =?utf-8?B?cWMxREQ3Q1M2YWllWFlYWDVZSHBXeG9laE9qS2lHc3ZNTDM1QnFJeE1Tb3JR?=
 =?utf-8?B?cjhRdnQ1NG1EUHJQQ2NjTFA1QzR2bDh0cXlzMWFES1huZEZPVEJVRGJzdmI1?=
 =?utf-8?B?RkIzeTYzNEJqWnpaWTdXMjVxbzNFcFFIZTRIYnkwSExUQlkxeWtBeGMxaDB5?=
 =?utf-8?B?MVhqeGFFMTV4VTcwTWlWTFRCN0h1NE1UZ3prWCthM1l1RDJEc2NOWk04WmEr?=
 =?utf-8?B?QXhNQXpVTHU0WHAwdjUvVVBNbUNEZzNzcnlEUm5TUGtBQjN5blBFYmVnMnRW?=
 =?utf-8?B?cS9ubUhVQTVGUTVyMDl2RG0wbG4wbk5waUlSRk80QTBrdFpOUkIvQUVWWWZ1?=
 =?utf-8?B?SEVtajZSQ0pKWEhYbnNtS0Q2SzJmakkzekZodzVPbFZIUG9mRU9ja0VNaUQ2?=
 =?utf-8?B?ZmRVbnBjNi9xK1daYzZHWXF0djJMYm4yVzU4Um5oQ01aZlBWSVQxQjF5RjBM?=
 =?utf-8?B?VEwyVy90NHA3NFE5b3VkQ2MrV2V2Nld0L3hyeDZVVVZ4VnhXUURLTWVMQ2Vv?=
 =?utf-8?B?RWVHTmpRb0Y0VkVCK05RVHVVNGVpekpnK1Q5SkFLNnNBK2RRVUFjenlOSzRs?=
 =?utf-8?B?S3JPNTFUS25ZVjZxQW1udHUvWHpFR0h5bzl4anRBUEZLc0tXSWxvbGlZa3ly?=
 =?utf-8?B?UFFJOEYyVFlydnRDYSsrSk0xclNqQlBCdFRaM3NZV2xWdytBVFBFRlk3bk9n?=
 =?utf-8?B?NlZNT01wSmpMUUlnZjJ3TnNpVE13SzJTNDA2SzhUUDFPWFZsZ3p1SFVtb2hZ?=
 =?utf-8?B?YzNxZWxtT1lkVy9qRFgyQno1SVJ6WHVYZHRDek1MbFc5L1J2OUc3aGFoM1Qy?=
 =?utf-8?B?a3p5RC9PamZvQ09qcFAxNDA3REloWlRrNklJWFdibmZ1TllBbUxlZmlmLyt4?=
 =?utf-8?B?OHM3bFlXTTNEVzRoNjc3azVUeGdQTDZiaU5TQVAwNDJXTmtocTA4M0l0T1RS?=
 =?utf-8?B?aUNnZXFjRCtnUlZiN0p4RUxpdUpCZmNja1BHZUJlSEZ5eHZ5aVpDcTkrQyt0?=
 =?utf-8?B?dk5sbHBCMDJFdjFrbGtiS0F4elYyaDNHSnVNbmhaendSWldXMEh0emhHR0ha?=
 =?utf-8?B?aXBZZVpQV1QzSHlUdDdqRVMzTlR5OThYZnNDd1o4QnIwdkFEcnBUR09zZUFN?=
 =?utf-8?B?a3RoSEJ2N2d1NlEzcml5ZWNiOHM1SUNYMlpRbG9ORXFtbExza2hvSUxzUEc0?=
 =?utf-8?B?ZGJVd3MzdWFobGtaenRJTFFqbEM0ZkJzNjE1c3JyS3o0cDVFZ0tjSlAwWkxs?=
 =?utf-8?B?KzFON05leGprSkVESDIwaEtaVkZWUFY2c2F4RjBDSXNzendJV1N6NXVCTGFi?=
 =?utf-8?B?MTA3N3lUcVRLZzMzdmhsRU9za25NcGw3S0NsVG5sR2FBVlhSVGJkcEl3bUxB?=
 =?utf-8?B?VVQwT1Z2eGpkNUJMMjZLQi9hTzZjMlgwTnZkVzhNcFlXa3lzeTFRcHhkNE1H?=
 =?utf-8?B?akhIRkZDR1haNXUwNVNqR0MzMWZxai9JNGlSRTBOb0tabFA3TUxldisrdmJp?=
 =?utf-8?B?OThZandLM3B3NTA3RzhLaHRJd2FzM1hsNGdOUXJwNTlVYjFPR01WWXZLTUdt?=
 =?utf-8?Q?qY9Obrjeffd3BX6yXMv4q7D3i?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ea5602-f599-4023-b6b0-08dab5c7f274
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:59:19.8294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K85HPQpvLyKv9D135RWkUMa8HTowXrRduaYwLqyEd/UtRDRkr9GqSM+gZa73AFM8MmBGCR+RuTMGigtA9vT38A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7284

On 24.10.2022 14:45, Roger Pau Monné wrote:
> On Mon, Oct 24, 2022 at 01:19:22PM +0200, Jan Beulich wrote:
>> On 20.10.2022 11:46, Roger Pau Monne wrote:
>>> Commit 75cc460a1b added checks to ensure the position of the BARs from
>>> PCI devices don't overlap with regions defined on the memory map.
>>> When there's a collision memory decoding is left disabled for the
>>> device, assuming that dom0 will reposition the BAR if necessary and
>>> enable memory decoding.
>>>
>>> While this would be the case for devices being used by dom0, devices
>>> being used by the firmware itself that have no driver would usually be
>>> left with memory decoding disabled by dom0 if that's the state dom0
>>> found them in, and thus firmware trying to make use of them will not
>>> function correctly.
>>>
>>> The initial intent of 75cc460a1b was to prevent vPCI from creating
>>> MMIO mappings on the dom0 p2m over regions that would otherwise
>>> already have mappings established.  It's my view now that we likely
>>> went too far with 75cc460a1b, and Xen disabling memory decoding of
>>> devices (as buggy as they might be) is harmful, and reduces the set of
>>> hardware on which Xen works.
>>>
>>> This commits reverts most of 75cc460a1b, and instead adds checks to
>>> vPCI in order to prevent misplaced BARs from being added to the
>>> hardware domain p2m.
>>
>> Which makes me wonder: How do things work then? Dom0 then still can't
>> access the BAR address range, can it?
> 
> It does allow access on some situations where the previous arrangement
> didn't work because it wholesale disabled memory decoding for the
> device.
> 
> So if it's only one BAR that's misplaced the rest will still get added
> to the dom0 p2m and be accessible, because memory decoding won't be
> turned off for the device.

Right - without a per-BAR disable there can only be all or nothing. In
the end if things work with this adjustment, the problem BAR cannot
really be in use aiui. I wonder what you would propose we do if on
another system such a BAR is actually in use.

>> Plus with this adjustment, is
>> ...
>>
>>>  Signaling on whether BARs are mapped is tracked
>>> in the vpci structure, so that misplaced BARs are not mapped, and thus
>>> Xen won't attempt to unmap them when memory decoding is disabled.
>>>
>>> This restores the behavior of Xen for PV dom0 to the state it was
>>> previous to 75cc460a1b, while also introducing a more contained fix
>>> for the vPCI BAR mapping issues.
>>
>> ... this (in particular "restores the behavior") a valid description
>> of this change?
> 
> Yes, it restores the previous behavior for PV dom0, as memory decoding
> is no longer turned off for any devices regardless of where the BARs
> are positioned.

It restores one aspect of behavior but then puts in place another
restriction.

>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>> ---
>>> AT Citrix we have a system with a device with the following BARs:
>>>
>>> BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
>>> BAR [0, 0x1fff] -> not positioned, outside host bridge window
>>>
>>> And memory decoding enabled by the firmware.  With the current code
>>> (or any of the previous fix proposals), Xen would still disable memory
>>> decoding for the device, and the system will freeze when attempting to
>>> set EFI vars.
>>
>> Isn't the latter (BAR at address 0) yet another problem?
> 
> It's a BAR that hasn't been positioned by the firmware AFAICT.  Which
> is a bug in the firmware but shouldn't prevent Xen from booting.
> 
> In the above system address 0 is outside of the PCI host bridge
> window, so even if we mapped the BAR and memory decoding for the
> device was enabled accessing such BAR wouldn't work.

It's mere luck I would say that in this case the BAR is outside the
bridge's window. What if this was a device integrated in the root
complex?

>> I have to admit
>> that I'm uncertain in how far it is a good idea to try to make Xen look
>> to work on such a system ...
> 
> PV dom0 works on a system like the above prior to c/s 75cc460a1b, so I
> would consider 75cc460a1b to be a regression for PV dom0 setups.

Agreed, in a way it is a regression. In another way it is deliberate
behavior to not accept bogus configurations. The difficulty is to
find a reasonable balance between allowing Xen to work in such cases
and guarding Xen from suffering follow-on issues resulting from such
misconfiguration. After all if this system later was impacted by the
bad BAR(s), connecting the misbehavior to the root cause might end
up quite a bit more difficult.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 14:31:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 14:31:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429175.680045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omyTv-0001D0-2E; Mon, 24 Oct 2022 14:31:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429175.680045; Mon, 24 Oct 2022 14:31:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omyTu-0001Ct-Vg; Mon, 24 Oct 2022 14:31:10 +0000
Received: by outflank-mailman (input) for mailman id 429175;
 Mon, 24 Oct 2022 14:31:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omyTt-0001Cj-Pf; Mon, 24 Oct 2022 14:31:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omyTt-0004kv-IX; Mon, 24 Oct 2022 14:31:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omyTt-0003lq-0H; Mon, 24 Oct 2022 14:31:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omyTs-0005z4-TR; Mon, 24 Oct 2022 14:31:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3Z3fEG+IxkkGvGLuOc2A6n6f77/jMLn3aR55FExUXrs=; b=KZDlp0oTqSSsPZQw2WXGuO8XRq
	19F6ft2TT9lVSjR57pj8YlARxNisWrmIbZC/rQVkAtcFqOgNgZcMzfDJbVcUau5ZzTnfoHzgNcHId
	MPunrcv8DtNzOotCwaq71lVSt1yQUDg4wlOjhCaRk3MlFp8zZQtxTO0VX3c+6oYzb43c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174337-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174337: trouble: broken/fail/pass/starved
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-pygrub:<job status>:broken:regression
    xen-unstable:test-amd64-amd64-pygrub:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-unstable:build-armhf-libvirt:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:hosts-allocate:starved:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
X-Osstest-Versions-That:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 14:31:08 +0000

flight 174337 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174337/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-pygrub         <job status>                 broken

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-pygrub       5 host-install(5)          broken pass in 174285
 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 174285 pass in 174337
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174285 pass in 174337
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 174285 pass in 174337

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 174285 like 174252
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174285 like 174252
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174285 like 174252
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174285 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174285 never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174285 never pass
 test-amd64-i386-libvirt-pair 10 xen-install/src_host         fail  like 174252
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174285
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174285
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174285
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174285
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174285
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174285
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174285
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174285
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174285
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-arndale   3 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-credit1   3 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-multivcpu  3 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-vhd       3 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-cubietruck  3 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-rtds      3 hosts-allocate               starved  n/a
 test-armhf-armhf-xl-credit2   3 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340
baseline version:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340

Last test of basis   174337  2022-10-24 01:51:43 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      broken  
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-pygrub broken
broken-step test-amd64-amd64-pygrub host-install(5)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 14:44:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 14:44:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429185.680057 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omyh5-0002ne-98; Mon, 24 Oct 2022 14:44:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429185.680057; Mon, 24 Oct 2022 14:44:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omyh5-0002nX-4x; Mon, 24 Oct 2022 14:44:47 +0000
Received: by outflank-mailman (input) for mailman id 429185;
 Mon, 24 Oct 2022 14:44:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omyh4-0002nK-EH; Mon, 24 Oct 2022 14:44:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omyh4-0004z0-Ab; Mon, 24 Oct 2022 14:44:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1omyh3-0004Tn-Uk; Mon, 24 Oct 2022 14:44:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1omyh3-0004Do-UK; Mon, 24 Oct 2022 14:44:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9DiVRfFWixXV6Hmb+UnPW2phwwvCxqIGCjL7BdNvLLw=; b=nzEPPHBzqJA1RCWpO9qfH0Bm6m
	EyC36PrHis942QdeEbCu7a+YDnTT9uLc1HXPRg3nlD4Ys9MFoes8tHr2JPe59zEs5ruezlgtXr59E
	Tu4ZWyqFWCo60PLRf09l8mAedOi6bXIrr/oEhGGi5wsDMUheGqfIjScVW8kzT4or1Dd0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174365-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174365: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d
X-Osstest-Versions-That:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 14:44:45 +0000

flight 174365 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174365/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d
baseline version:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340

Last test of basis   174201  2022-10-21 13:00:27 Z    3 days
Testing same since   174365  2022-10-24 11:02:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dario Faggioli <dfaggioli@suse.com>
  Juergen Gross <jgross@suse.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   73c62927f6..fce1f381f7  fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:00:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:00:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429195.680067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omyvh-0004Sx-I5; Mon, 24 Oct 2022 14:59:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429195.680067; Mon, 24 Oct 2022 14:59:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omyvh-0004Sq-F9; Mon, 24 Oct 2022 14:59:53 +0000
Received: by outflank-mailman (input) for mailman id 429195;
 Mon, 24 Oct 2022 14:59:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=akEN=2Z=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1omyvg-0004Sk-Jq
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 14:59:52 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70040.outbound.protection.outlook.com [40.107.7.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 81fc1f7d-53ac-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 16:59:50 +0200 (CEST)
Received: from DBBPR09CA0011.eurprd09.prod.outlook.com (2603:10a6:10:c0::23)
 by PAXPR08MB6749.eurprd08.prod.outlook.com (2603:10a6:102:13d::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 14:59:45 +0000
Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:c0:cafe::b5) by DBBPR09CA0011.outlook.office365.com
 (2603:10a6:10:c0::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16 via Frontend
 Transport; Mon, 24 Oct 2022 14:59:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.19 via Frontend Transport; Mon, 24 Oct 2022 14:59:44 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Mon, 24 Oct 2022 14:59:44 +0000
Received: from c1c0b63ad1b5.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0EF06B90-D7D0-4564-B945-64E9FC9A90AA.1; 
 Mon, 24 Oct 2022 14:59:33 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c1c0b63ad1b5.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 24 Oct 2022 14:59:33 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by DU0PR08MB7691.eurprd08.prod.outlook.com (2603:10a6:10:3a5::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 14:59:31 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 14:59:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81fc1f7d-53ac-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=oJq1LyYmPA0ZBXDTSdml/fGfU87+yDbKKG4fMnoi7Z4Q1blckXcwNKjJHKBoMRMJ1fscdV2XntW2milBOfXVWHnggLFspp2BU6YRrHmdG4ORpqqn0AxkwxdBwSU6AM8srZyzaNB5pnvApTrwdMXWDkUWgnyVOufJlERm7xqkC2/117C8dmbtoKiOWqSTlOADqvubmTUPuqGw+hnr2Tw/s+bFdUzJrsZN5TBfYAP2ATlfPQgptq6EN59UM7UpuO4Bwx79UBwotrq7ySevzSEW0raGsIIQ9e0JnufMb/D2VMmdzMTPt8CGPOVs7/Zdn1YrGiKEoX2hrP6UDNZK/u2WFg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yRldwzwg/dN/KKy0HYQfQI789UQ5QZ5brzYGi/rfunE=;
 b=QShvns8NJgy39qvPCfkKZvqu14oRH2/tPjtQWha7TV5uivNBwDBGkamLTIzYacNpExfr9DC5D4Jx9si2Di/QPZfGe9bcCc0XidntD1Zw6ag2qwflY5ggDkqYNTVAS8LshsfAXPQZ5wHtaXSrXXlroRXc4gE0eA+adOVo2hEmjT14sDHqUMoA+3Zy+Ep8g/oS8MFZ+MvYoQ0KFy9tyGDPges527vcJYIGCmAjemqUsP6NsOzr/3CF3NQEG9Xp7pNhHHRveHHjMvyKkwy5BXibAMpESWoX8imMdhpsc53838kl8EdrgIRjZ5PQ4T7MbGlfBuylXbRc+pPJhNe6938KjQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yRldwzwg/dN/KKy0HYQfQI789UQ5QZ5brzYGi/rfunE=;
 b=z7dY+2fZtAWig0Tya/JOFsTKy4sg9r9Pae1coJXsGmbIPKqkUL8wPLyJtzcCz6CR/KU1QN2FEiAKJ4YIDOpKe5ox7bG3cSqmmrh8YaSRSKpFdGZbJ1LigUuvoK8a5WThWbP2oMVRXlqMWmCr8JTuMtibZwhA+jIOwSONAqF+IPE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 1a695eda3ff6bbdf
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uk9cU37MkLv1xXgO/tgbpjVCikSrI4TrPTMOWPJNUM+6GQd5dfS8Xch4Wi/lQoveYg6VV0zskfe0GmerM1AtmIzT7k9TnxUzpZX4k53G6sKbiEsHF45e/kmrL2Uj4gtxxix0gg3fYYu9HxzptFn+1WXIWwVqHbRA3R9y8DNxuiUQqoB6Cy3ye2ujTAqPyJo4qR56bI5URlQNILof1d6fPHze5J27XqQ2uVH4LIo12lkqYLFDsUYM60dl8KCBnYHlxtCSxEo7J7Tpb74GzUvro986Qeh5sgd4NGtSG7shosPlJhxaxJpIzXpljFZrKpZvu+YLZ+lC0bfPzp8R+E1S2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yRldwzwg/dN/KKy0HYQfQI789UQ5QZ5brzYGi/rfunE=;
 b=E2KJuMd0AIiM0mtvIlekkm0wZo4cVenz9pGiOTSNJ4Xr/Qq8Ukve0tlZGlddN715MvbMSikHtaL/pLwF3qW+sOdpMQzCesoXK6dK13gFL+G8oWCAWRH5sLCWUnS6+smggu/npelw3VsN+AaUlJaLmXP7yd+K+3yyGXDpYqxdo3C1xl0c4p66tlVPrtJGmOlkXGanwUroilcUCeY6a6u3GyBKGHl5Z8VSrQ+5mlBXur3i/l6EPN4srv0OhqdF0MO4Lk0ND4CX3o+j92PNC8+cVgw5spF1VdcXs6S7qBr/9WnoZiFva2BuL7l7t2otvR5aGlDz6HJl3RYK9Nzkx1RyHA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yRldwzwg/dN/KKy0HYQfQI789UQ5QZ5brzYGi/rfunE=;
 b=z7dY+2fZtAWig0Tya/JOFsTKy4sg9r9Pae1coJXsGmbIPKqkUL8wPLyJtzcCz6CR/KU1QN2FEiAKJ4YIDOpKe5ox7bG3cSqmmrh8YaSRSKpFdGZbJ1LigUuvoK8a5WThWbP2oMVRXlqMWmCr8JTuMtibZwhA+jIOwSONAqF+IPE=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
	"marco.solieri@minervasys.tech" <marco.solieri@minervasys.tech>,
	"lucmiccio@gmail.com" <lucmiccio@gmail.com>, "carlo.nonato@minervasys.tech"
	<carlo.nonato@minervasys.tech>, Julien Grall <jgrall@amazon.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Thread-Topic: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Thread-Index: AQHY5ieonqQkHk83Kkm5zIRZSvwGdq4dph+A
Date: Mon, 24 Oct 2022 14:59:30 +0000
Message-ID: <193111E4-4D06-48AC-89AC-637CFF3DB37B@arm.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-2-julien@xen.org>
In-Reply-To: <20221022150422.17707-2-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|DU0PR08MB7691:EE_|DBAEUR03FT035:EE_|PAXPR08MB6749:EE_
X-MS-Office365-Filtering-Correlation-Id: dddb08d1-ebca-49d7-4fe3-08dab5d0632a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 yLSSZ37HbkETT9l38AvEcd6YvoDJEuguvpSVnbktmkLp0+RZf6CpR7fVeMUa0CCldgVWHoMxtfEgJWRAxbG2TNq4srYZDCsMsljXAKFMYfIq0FtpJYm13J+sRyHxaCN8Iziq0k0DH3nliWJ/AHq5gFMoSXxJcfbiHqE3+ivcQLQW4yW1potD48+k3ls3ZiPELBKsnyRkXYpApuoIzQPFAdm7dPrdKUbE7FMiyfdqMfQhagWgrpe3oF/KYRlQRmibc3IUImyrOHHDqMCb3wcCqtDDRMXMOsC8260ZhbwaIDChW08qnIt/6EFtJpaEhwa7DMGx9Fg9+/zgZO/A1ANfXX/8SY4JFT2Uy/FI+TKgzyjS0Z0uTCrmP9D7Mm96uFfnriyh94E96ASZGjeqfEYC2y3igpXLflXHrr3CbCaWRGJhD1LGCyKi9QjaPJcnpzOOmUJ2ZNQT/kT8Ty+iJI96NBr4mD/4BLFnvv7ZmEnxtyyrpc2estvla8o9OgYL2iu4Ew7tNGUJVsCYuj6ZMloAOW2nE6ugfjKpPjHfhpFWz7S6BDWWqc9bqVriZ/WpAgp6Bf5ACTZK7GvAe5gTrNBE5rkrTGNCJOMMs2OCyMclKi+6K+j4vMyE8LfSPZYZHK1/5rPwSCcch89V8uKUbdWP+JvRwgeFim8zpTml/6PqGvIEpx/UTppghOVMEZs+mdLexGYrACs4IkW3Aybc1BIzjHKb7s6R0tV0UZxhypQ7otuTt7sMgUXy9D/1mAunycE2oQKtsMbjEyvqeRJ+ORIgliz8ME1sNGLMvIHfno5UZUGrl4mFpcJqgURRvzhZ7weHuDjHel386KyCXn+SVZSNOOFymYxZgK69rMZMwlSVAes=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(39850400004)(376002)(366004)(451199015)(6916009)(66556008)(33656002)(6486002)(38070700005)(38100700002)(2906002)(478600001)(41300700001)(5660300002)(36756003)(8676002)(4744005)(71200400001)(8936002)(91956017)(76116006)(64756008)(66446008)(66476007)(316002)(4326008)(66946007)(6512007)(186003)(54906003)(2616005)(26005)(122000001)(86362001)(53546011)(6506007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6C673C7C9FEE9444905E309EAE30B91D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7691
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	54542097-21b2-44b3-9379-08dab5d05a6e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	712JJWtWGitIDqSb079Fe1jP3cxksu6P1IaxvDNOD7efNU8TjMQYELcTSZgoDN3Vdu/B3WvOvcVsjx8uzyJjhKhbD6lNy9Gv5XVRsz4W0lG/OUb4qg032Bkk9iPRl/UBgoVEmmgbOPADmAiLyNKo75mVHc7ROXMFjNc3P045NbtUMk6oRnArXz+6kF51g4dtyKZfs0+fmv3Bz9Bm3Vpu7papnM14drw/ZJxnvGnd3o7xsotK2SpqMWg0SlMKOD0YBmymWU1VjmYt3NU5BFZOp7ZXTWvwrc0nIoS6ypETrE5S2KdxufcWJ5iNVaTCYpt9oVVBWsf3gbv7FPfSpUMY4hUkwG17DJ4KwNZYbAIarL8dhYMzOgVg4cN9Ec+ILfF5IZr/Lr7AEvWlI2T5rnD4ZiLGTGWBssQsXOy9c5JL4Fi81Fcm3MId1h0U3rffb2O4aBNNbEC7pSeiJ4H/WsGJ+UGgU4W2ZTwoA7By9oNVknz5tFCdanAjEZjw34dDJTguF7/2RgHLjutMGMxai3Wa6/iE7bbkzzbVkk+LnXlA9J6oiBEiqNrNZJP7XyFmQrgVbPV/YgdToK9J77bsxjOln6Xq0Sx+YGjZcMUYxbHEOXrCqqAK0uLhaFUKsZU/ViirPinClCOeJT3HRHXe5zkDHvupv3OQXZ9TD+aUEy5JRIZIkqxxMiplPaa1fgq4zdmwYw55QjPCCZVuq3pGJ9O2B0s2vSgELkwKVrQp5O6C4d36uRxKMnfMyZaQrJyNU3wOZUVyY3mv62xbLob65b7/9A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(107886003)(53546011)(2616005)(6506007)(26005)(6512007)(47076005)(36860700001)(336012)(186003)(2906002)(40460700003)(40480700001)(4744005)(82310400005)(54906003)(6486002)(316002)(478600001)(41300700001)(5660300002)(6862004)(8936002)(70206006)(70586007)(4326008)(8676002)(86362001)(36756003)(33656002)(82740400003)(81166007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 14:59:44.7888
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dddb08d1-ebca-49d7-4fe3-08dab5d0632a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6749



> On 22 Oct 2022, at 16:04, Julien Grall <julien@xen.org> wrote:
>=20
> From: Julien Grall <jgrall@amazon.com>
>=20
> In a follow-up patch, the base address for the common mappings will
> vary between arm32 and arm64. To avoid any duplication, define
> every mapping in the common region from the previous one.
>=20
> Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
> XEN_VIRT_*.
>=20
> Take the opportunity to add missing *_SIZE for some mappings.
>=20
> Signed-off-by: Julien Grall <jgrall@amazon.com>
>=20
> ----
>    Changes in v2:
>        - Use _AT(vaddr_t, ...) to build on 32-bit.
>        - Drop COMMON_VIRT_START
> ---

Hi Julien,

Looks ok for me.

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>





From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:00:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:00:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429193.680078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omywP-0005ox-Vy; Mon, 24 Oct 2022 15:00:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429193.680078; Mon, 24 Oct 2022 15:00:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omywP-0005oq-TF; Mon, 24 Oct 2022 15:00:37 +0000
Received: by outflank-mailman (input) for mailman id 429193;
 Mon, 24 Oct 2022 14:58:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EgVH=2Z=kriegisch.at=adi@srs-se1.protection.inumbo.net>)
 id 1omyuM-0004RS-Ub
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 14:58:30 +0000
Received: from sternum.kriegisch.at (orion.kriegisch.at [83.215.238.18])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50fa893e-53ac-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 16:58:28 +0200 (CEST)
Received: from stargate.ley23.wien.funkfeuer.at ([78.41.113.217]
 helo=kriegisch.at) by sternum.kriegisch.at with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <adi@kriegisch.at>)
 id 1omyu0-0002ld-2B; Mon, 24 Oct 2022 16:58:08 +0200
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50fa893e-53ac-11ed-91b5-6bf2151ebd3b
Date: Mon, 24 Oct 2022 16:58:05 +0200
From: Adi Kriegisch <adi@kriegisch.at>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Salvatore Bonaccorso <carnil@debian.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	sathya.prakash@broadcom.com, suganath-prabu.subramani@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	adi@kriegisch.at
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Message-ID: <20221024145805.GF23159@kriegisch.at>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="8GpibOaaTibBMecb"
Content-Disposition: inline
In-Reply-To: <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)


--8GpibOaaTibBMecb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,


On Mon, Oct 24, 2022 at 05:26:44PM +0530, Sreekanth Reddy wrote:
> On Sun, Oct 23, 2022 at 6:57 AM Bart Van Assche <bvanassche@acm.org> wrot=
e:
> >
> > On 10/21/22 02:22, Salvatore Bonaccorso wrote:
> > > We got the following report in Debian after an update from 5.10.140 to
> > > the current 5.10.149. Full quoting below (from
> > > https://bugs.debian.org/1022126). Does this ring some bell about known
> > > regressions?
> >
> > Only three mpt3sas changes are new in v5.10.149 compared to v5.10.140:
> > $ git log --format=3Doneline v5.10.140..v5.10.149
> > 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return valu=
e check of dma_get_required_mask()
> > e7fafef9830c4a01e60f76e3860a9bef0262378d scsi: mpt3sas: Force PCIe scat=
terlist allocations to be within same 4 GB region
> > ea10a652ad2ae2cf3eced6f632a5c98f26727057 scsi: mpt3sas: Fix use-after-f=
ree warning
> >
> > Sreekanth and Suganath, can you help with bisecting this issue? For the
> > full report, see also https://lore.kernel.org/linux-scsi/Y1JkuKTjVYrOWb=
vm@eldamar.lan/.
>=20
> This issue is getting observed after having the below patch changes,
> 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return
> value check of dma_get_required_mask()
reverting this patch fixed the issue for us.
=20
> What is happening is that on Xen hypervisor, this
> dma_get_required_mask() API always returns a 32 bit DMA mask. I.e. It
> says that the minimum DMA mask required to access the host memory is
> 32 bit and hence mpt3sas driver is setting the DMA mask to 32bit. So,
> on a 64 bit machine, if the driver set's the DMA mask to 32 bit then
> SWIOTLB's bounce buffer comes into picture during IOs. Since these
> bounce buffers are limited in size and hence we observe the IO hang if
> the large IOs are issued.
I am not sure about what is going on here but while reverting the above
patch, I added a printk right above the if:
  | printk("dma_get_required_mask =3D%lld\n",dma_get_required_mask(&pdev->d=
ev));
which always (as in booting dom0 with 2GB, 4GB, 16GB and booting bare metal
with 256GB) returns 4294967295 (DMA_BIT_MASK(32)).

> I am not sure whether this API's return value is correct or not in the
> Xen environment. If it is correct then I have to modify the driver to
> not use this API and directly set the DMA mask to 64 bit if the system
> is a 64bit machine.
Obviously, our server always reports a 32bit mask which works just fine in
the bare metal case but does not in the xen dom0 case. Is there anything I
can do to help tracking the issue down?

thanks and all the best,
    Adi
=20
> Thanks,
> Sreekanth
>=20
>=20
>=20
> >
> > Thanks,
> >
> > Bart.



--8GpibOaaTibBMecb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEENxTTbbOruRNI5poKdER8DqmFXL8FAmNWp/UACgkQdER8DqmF
XL8X7g/+IOpyoxnAR8DTvE8i6qUMGJWtskT+9h3q1NddPIpQapOKF/zSDg0W5uYf
pi00CcwXueCfZXPhgp+AjLFdPI5FRYlH6Nq8kMCoaDJ2Q8KVmogUgu7q5SQqLhAc
M0GBTLiwhdyAKXDuo0EqSGzycGzvf8QWL3gtTQnOrxSI/ChOoQGV4IMVpGi/r6Nr
yLL/58H6E5bODj+hDBbFx5dLoiXJAOoCJZsVv9p3Y76RDbIok+HU9u6dbhg/eXrS
2uGd7nciFlSOVSwmUoOtUaaqhCh78QmL3ZxAK0fCJ1/4yBsllMOP22ATD+Xnz5zl
B5RSCNpT5n4i4eJfQWQzBz7uaSS+IHquryboncg1Fa4URORPg+SjZuPiJarZbq6+
b9g3e7d7FjKcMTuUrxv0fjPyBV8IlGHZ8DSuykmwZ7p5RQ97tkuhjAH/3GBsb3Lz
DY7vhpUwvTM5D/G3S7tQoBfL+EjlwC5XmH55olbrA2h3Ete+0SUTeqmUjw676Ak4
NHmwzmDXmVR+YQeFNEnWNtzBzUQEYJHi1TslzWmWPDiQ+mX4LlsFy3KhUET1482O
0HHdbtycrMZQJWW9yGuocWCavQOAoOJMfxf8WNRER1H+YJGdbh850wR7/rRUFPWz
rX9Whv1jnnr8R5ztyiVCNUmSvLyVFwRT26K6VRxjaqg04p8Stys=
=AvSb
-----END PGP SIGNATURE-----

--8GpibOaaTibBMecb--


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:04:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:04:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429206.680090 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omz0T-0006Xf-GH; Mon, 24 Oct 2022 15:04:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429206.680090; Mon, 24 Oct 2022 15:04:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omz0T-0006XY-DG; Mon, 24 Oct 2022 15:04:49 +0000
Received: by outflank-mailman (input) for mailman id 429206;
 Mon, 24 Oct 2022 15:04:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1omz0R-0006XP-9t
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 15:04:47 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ffe2965-53ad-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 17:04:43 +0200 (CEST)
Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 11:04:22 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB5056.namprd03.prod.outlook.com (2603:10b6:208:1b2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Mon, 24 Oct
 2022 15:04:21 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022
 15:04:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ffe2965-53ad-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666623882;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=3vxSWai/x7YVhv/3LVpA/Let223PEwV/k3jF29YcV+g=;
  b=HkyyMaW4aqsDgyfZ2kBcHKGhLPDIUiIqv54d+qdxlZXyiBFRqvNTNPkn
   LXfYiSRGMiX0wWlNSA2IwS+qEIXIkGZuN3BD+dTYd/tTNPu3eNnVLJcO2
   kQjYWt27karxXEad8IDYeDMpiXUkFjjwPF+MQld/BL0nY3sS5hhiCjylR
   8=;
X-IronPort-RemoteIP: 104.47.55.101
X-IronPort-MID: 82484344
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:K2MAIK+6yRu1n8KNrLRrDrUDl3+TJUtcMsCJ2f8bNWPcYEJGY0x3y
 WMaWmrSaf6Da2H0cookbI618EoF75+Dy4djSgFk/yE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5ABmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0v5wM313x
 6cVEy1XQS3a2ruu3rucafY506zPLOGzVG8ekldJ6GiBSNMZG9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujCKpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toijw1rOUwX+TtIQ6OISqzsF0nASp4DY6URQcT3/qrcmYlRvrMz5YA
 wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9+4FHhRqubyRDHeCrLGdqGrqPTBPdDdbIygZUQEC/t/v5pkpiQ7CRcpiF6jzicDpHTb3w
 HaBqy1Wa6gvsPPnHp6TpTjv6w9AbLCQJuLpzm07hl6Y0z4=
IronPort-HdrOrdr: A9a23:PGzLmammpLli2kDMNMg9x0rGr6XpDfPJimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKPTOWwVdASbsP0WKM+V3d8kHFh41gPO
 JbAtND4b7LfCRHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaFp2IhD0JbjpzfHcGJjWvUvECZe
 ChD4d81k2dUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInpy6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zUYIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6R9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF79tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcoa+d
 FVfY7hDcttAB2nhyizhBgv/DXsZAV5Iv6+eDlPhiTPuAIm3EyQzCMjtb8idzk7hdEAoqJ/lp
 X525RT5c5zp/AtHNxA7cc6ML6K4z/2MGbxGVPXB2jbP4c6HF+Ig6LLwdwOlZGXkdozvdMPpK
 g=
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="82484344"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b4e1pM0P9wZBLt80cj5oe3PurMKCaHw/QXOaRLCyJk1FJJj2orzD/7CrNb9nyzWe+iOth1ZbvrFpFYX3/MIBm17JzLryaBbA7aUJkMIaB7Ss1PCsGdkLnkdvjaBEztLiejDP81gc21oBoigdYbqxeuYrq9TW1lfWumSjz22Kk+yIBPdHBH33Hj6/CAts5rBxcn9xbap1SUrlzh60rmaB4Tb+PAc3a9tcKVSmF/y3KON5IPupzsMJ0e9yC2OLXijmW7ifBjVj/m/PH3ASG4Tb0fYe6wI2Op03PtpnZ+ICx6vh6fq6ix3wqZj/m3+2KGdDEZSJyYTiiJR57RvUalKdhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wY/FMlcRPFDBZIEYTMjtgmpieWNWtqEmprrtNPF4HVs=;
 b=kPokHmYoLOuGFEcPElIq8jh/RkuBwIZsqdIF5V3gV3i+6e2Yp9L73/JpcEBUixuhCK5oi6TRD/JFiAVrnc9EwBfrLZfrQLAYf6dWNDgVXTnhksqTgwBn1QFg6BBUHYpnrEJX6b/goR8jBpffDXmKb9ioxFlMJzN2oCSx1BWFd/ioDVqbM3QZxvFmmffnQ2sdwTSJFu9HBmsVzlx/6Z/3QfEU8NwRux1BNhqop5c0f0+S7EdhQB/6Z/JcCy2A4Jtzri7X6I2B9Vs6FgMJ5RhhNAgMDZTXFjGipfiubY2+7+fA8JDfAQlg126rj9gbAA/FRHlLgVzdszV5OU09o9T48w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wY/FMlcRPFDBZIEYTMjtgmpieWNWtqEmprrtNPF4HVs=;
 b=HypEi7btVECjTwbyfHiHItnl+TI9EoaHwMJPFSD5/4ExBB9iQjS/5J+HLKFMbppp2BWVT2iKl3O2t27tVIOANKWB4HrdU8R5+HBJu6WzEeCoFDSKTHLwB/LfHb3su8tmUdGUKDZcm2ygXDzgH1yuNaoMGlUp127wwf1cckb/bPU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 17:04:16 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 6/6] vpci: refuse BAR writes only if the BAR is
 mapped
Message-ID: <Y1apcHK6O7IDWlKF@Air-de-Roger>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-7-roger.pau@citrix.com>
 <cc94a021-aa76-87da-0d14-e01f09377b57@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cc94a021-aa76-87da-0d14-e01f09377b57@suse.com>
X-ClientProxiedBy: LO4P123CA0126.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:192::23) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5056:EE_
X-MS-Office365-Filtering-Correlation-Id: 80a23646-50cf-4ad0-bbbf-08dab5d107ad
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+hR7jEpuhVGz/UXrAM8omUqo7MuMC2HLKCGRbdg7PudHrXeurLO/b2OGoSnu12hpnfQ32goZFHQ71MtTQJwVKMdf9B2jAsuyCS1nZlWGVOpYZ9eYUg7vBkAIzFmOcoExh2XGNOExa1sWFK2nux1pZ1Dz0Tb0JW+CnujXKlZ0NQhUDN45E0eY8VveUJ2dnvYHrKPIxiAibz4FWkWfml8uj15WQTJPiQIxX/OMM3kwW0Lf3hP/8gG6XXJaiXEpJ6ihaQ2aCfPyMbkpmm5EsCU8bTvt4/Mspg1yPJWr6AGhR4tZyKmDpl01q0jcXB1rObglt1We8OrJ4nPydYwJTZZziKZ7DK9WCZcYdH2BObf+uS/4yiQzuHAscHrRJMu2xf9s6z00bYUx0fGibABb6S6l0sncc9ojtgDxy2h+kwE6vCKbH5EjJF2PJWL8L/lK9CA6yUl4kQjK4l0t/9PNtkLlG138/aIYMTqAmAMMyh3vA4rnBla7rPKycKmig05EN1rfj/C6TYebyEGIoIzycAlZc4Vd8rUb9eZ271cc3FXbsfAqsZuLwlfzBKQwNHdXt3oNrLySrkyDnvCx3zFpJ6SzFfGwz/aXTqmlEXsr6EV3EgqHdQKoNVC52C1G/xkT9PVb23vXamwnWfvYnFi5wvz672SNLfHOAw+ypy3XJ8CNKpkF6pU195lkXUWsr7FlHI1k7Q0zpoOc1nGiLigSvzhLkA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(451199015)(66476007)(53546011)(4326008)(478600001)(6666004)(41300700001)(66556008)(66946007)(316002)(5660300002)(8676002)(26005)(6506007)(6486002)(6512007)(2906002)(9686003)(86362001)(186003)(83380400001)(82960400001)(38100700002)(8936002)(33716001)(6916009)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z2tJY3ZuR3gzcmY0VkdBamk4NzY2QjVkUEpsdkJRenYwUVNIV3o4UlFIbXM5?=
 =?utf-8?B?eW12UmFpUGNjOUpwRXlTbmo0L0x1UkpLbTJWTEsybSs5dlpjU3kwUEhrelZo?=
 =?utf-8?B?UHE5U2Z4Rmh2SUdheldWeW1NbnF1RldyOW9HY2JhY3lPd3lLS3BYSnV2ZStJ?=
 =?utf-8?B?SkdWVzllMStPUXQyakNjUENDa0UraDFyMm4rRTBrcjgycDRpbURrRDM0SnJ3?=
 =?utf-8?B?a1FoWHZqSkdVVTcrdU95aFpyaEZzRTRueWE5dVEwajlMV0M5ejE2K21rREc2?=
 =?utf-8?B?TXh0S3VzS3IvS0NuUUpkclZBcUhkeFdkMGU3V05tSktoRENRK2lMTXNiK2FF?=
 =?utf-8?B?VUlyanhnZFk3VmR2L2dFd284b3NrWTV2alovQzJWRGt6cUNLYllUNGpoMzhw?=
 =?utf-8?B?YkdubkpGcFFNOEVPbEpnQWg5VldWbzhmTWh3TzhoUUNPUHBEUXpBYmNlL0Fm?=
 =?utf-8?B?UkZDdUg5QWtncEUzOWNjMUNJZzZYTzN5aGJyRUFlenZySEt0QUppSEFPaG9G?=
 =?utf-8?B?K1p1WEdka1Y1eGtJTm5sRkt0Uk5xYVdHcG9WQnZwaGZaR3hjWU1xS3preHhT?=
 =?utf-8?B?MWxaYjNWeit4TEpIRHVjWi9ZdDBPb2tMRzBNQllBK0hybnROLzgzbksrNkox?=
 =?utf-8?B?VmlsQmw4T3hGN2RETUo1REpuM1hNeEc4QjEyakNZRmdTU09kTXFERUNsdHIz?=
 =?utf-8?B?RUs3K1MrWVZFcGY1ZnErYnpaQUErV2MwMFlQcDdnQzIzckQ1V2xndHdXMlpE?=
 =?utf-8?B?cmVwMHR3bDc5akd1VXJ6ZWtVRmtBVlV1SndXUXBoV3lmNm9qODNDZVIzMity?=
 =?utf-8?B?eUR0TjR5aEt3SFdLNUFhRjI5Q0NUS3NwVFp2UzJ5TE9NU0t5M0Y4ZG9GUnVx?=
 =?utf-8?B?cXV6WEk4NVZYQS9Lamw0WU1VU2JYTVV2Y253RnpjMjFqNlJBSGgreVVqOGZR?=
 =?utf-8?B?dHFCTnlYSTU3WnBjNWwvbUkvclM1MlZ0UUZJcXhUb3hIZ3RqQlVVY1ZONnRr?=
 =?utf-8?B?WnFwMTBvMmVPQlA0S09ZZ1o1RFVtcnRoQy9aVWJQcFZzMDllTlB0L1V3TVVu?=
 =?utf-8?B?cUlDZE9FWG1DTFJsRmIwSXcvQTIzL09Ba2pQdlNZc0JLNHNMazFZK0tYcUJV?=
 =?utf-8?B?OEZaUlErRjBOcHhzK1N5R3VYZU9kL09CQTd1VmFNNWtUeFNlenFEelJMZ2xj?=
 =?utf-8?B?L3pQQkRQanhVNUM1dkF4QmtvdXZ0NFZyUytHSG5Qd1dPNFE4N0Y2NzcyZ0M0?=
 =?utf-8?B?QmRMQ1A5STZZTW9ISW93am10T1h0RWZBbldHcTkrNFc1dTJNR0VOWTlXTksx?=
 =?utf-8?B?WWd6RjRTb3pacUpjMVpneFdXYWRpUVl6b0xyVlZJL3lycnh1aE1nV3YwdEgz?=
 =?utf-8?B?dVBFdjNGL2pIL2dZWmRiRUdoZkc3aWxjNCtwdUtBRjltVFdYaFQ2YWtsb01W?=
 =?utf-8?B?dnFYdjVsUWtacmJBZVFOTmJuQkxSKzNTVkpvK1JYWWg2SE9rbVdkZVlZaGdF?=
 =?utf-8?B?WkR1NVQzdG1LZDNEcm1ObHY3TWZFcDVrb2c1TUxHUmxFR0pEUW15b2pHVnlw?=
 =?utf-8?B?bmFFL0RiL1dPcDBwUG9wMk5GQ0RZdUgzODA4Wml5NTdxRFlRbDVxVmxrSFAv?=
 =?utf-8?B?YVlTUC9vU2w0MmtnVDhEK2NKN2RTY3VWN3dDOHJkd1BDZXpJNUs4V1ZPNk5n?=
 =?utf-8?B?OWVNT3pZY0J3aGhVblA1NUJ5QUlSTG1rVFNNM1NsV054UFk2Qk5xUDNuUzFV?=
 =?utf-8?B?ejd3dG5EU0dabm5WdHFmZ3FlSkJZNlFCb2dXQTNCZGlseURzejZYdGJaSm9v?=
 =?utf-8?B?WjB3MW5aS2Ezam5hK1ZRSjE4dnRYdHZiTkdTdHNRYTlGR2t3SVpqaHNadWlq?=
 =?utf-8?B?Q0JEYXordWd5ZW5SOTZJdlVpbEJTa2tFdytJOFN4V1l5SU5hVkk2eGhMZStt?=
 =?utf-8?B?UDd0L3F5cUpnQkFXMWNtTWRIdXRTZFlRdjBFVzNTUXg0V1Vuc2t3bmJFOFkw?=
 =?utf-8?B?eGhISGNzRUNpRkhtTjVPRTFJQVl6RHB2cTdhM2JNZTNsMlVZcVhRMVdCMWxT?=
 =?utf-8?B?L3ZvWi9BSjVlUWtNUnV0OGthb2RBMFYrWDFWcWt0Y2ljL1FvSWI4QWFCU1V2?=
 =?utf-8?Q?fe68g/hn8TMVO/KWkVEUFClQT?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80a23646-50cf-4ad0-bbbf-08dab5d107ad
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 15:04:21.0933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KRIDAU6N1LR7htQLXowXX4lokUfsIRv/9dvZcGyJkIVQRxH9SBwBS2BOroi+VnBIjIoqcjQN9i46TBhDP173iA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5056

On Mon, Oct 24, 2022 at 01:51:03PM +0200, Jan Beulich wrote:
> On 20.10.2022 11:46, Roger Pau Monne wrote:
> > Writes to the BARs are ignored if memory decoding is enabled for the
> > device, and the same happen with ROM BARs if the write is an attempt
> > to change the position of the BAR without disabling it first.
> > 
> > The reason of ignoring such writes is a limitation in Xen, as it would
> > need to unmap the BAR, change the address, and remap the BAR at the
> > new position, which the current logic doesn't support.
> > 
> > Some devices however seem to have the memory decoding bit hardcoded to
> > enabled, and attempts to disable it don't get reflected on the
> > command register.
> 
> This isn't compliant with the spec, is it? It looks to contradict both
> "When a 0 is written to this register, the device is logically
> disconnected from the PCI bus for all accesses except configuration
> accesses" and "Devices typically power up with all 0's in this
> register, but Section 6.6 explains some exceptions" (quoting from the
> old 3.0 spec, which I have readily to hand). The referenced section
> then says "Such devices are required to support the Command register
> disabling function described in Section 6.2.2".

It's unclear to me whether setting the bit to 0 is plain ignored, or
just fails to be reflected on the command register.

> How does any arbitrary OS go about sizing the BARs of such a device?

AFAICT from Linux behavior, an OS would just set to 0 the memory
decoding command register bit and write the value, but there's no
check afterwards that the returned value from a read of the register
still has memory decoding disabled.   Xen does exactly the same:
attempt to toggle the bit but don't check the value written.

> > This causes issues for well behaved guests that disable memory
> > decoding and then try to size the BARs, as vPCI will think memory
> > decoding is still enabled and ignore the write.
> > 
> > Since vPCI doesn't explicitly care about whether the memory decoding
> > bit is disabled as long as the BAR is not mapped in the guest p2m use
> > the information in the vpci_bar to check whether the BAR is mapped,
> > and refuse writes only based on that information.
> 
> From purely a vPCI pov this looks to be a plausible solution (or
> should I better say workaround). I guess the two pieces of code that
> you alter would benefit from a comment as to it being intentional to
> _not_ check the command register (anymore).

Ack.

> > --- a/xen/drivers/vpci/header.c
> > +++ b/xen/drivers/vpci/header.c
> > @@ -388,7 +388,7 @@ static void cf_check bar_write(
> >      else
> >          val &= PCI_BASE_ADDRESS_MEM_MASK;
> >  
> > -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
> > +    if ( bar->enabled )
> >      {
> >          /* If the value written is the current one avoid printing a warning. */
> >          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
> > @@ -425,7 +425,7 @@ static void cf_check rom_write(
> >      uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
> >      bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
> >  
> > -    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
> > +    if ( rom->enabled && new_enabled )
> >      {
> >          gprintk(XENLOG_WARNING,
> >                  "%pp: ignored ROM BAR write with memory decoding enabled\n",
> 
> The log message wording then wants adjustment, I guess?

Hm, I think the message is fine for the purposes here, vPCI is indeed
ignoring a write with memory decoding enabled, or else rom->enabled
would be false.

Or are you arguing that the message is already wrong in the current
context and should instead be:

"ignored ROM BAR write with memory decoding and ROM enabled"

> What about
> 
>     if ( !(cmd & PCI_COMMAND_MEMORY) || header->rom_enabled == new_enabled )
> 
> a few lines down from here? Besides still using the command register
> value here not looking very consistent, wouldn't header->rom_enabled
> here an in the intermediate if() also better be converted to
> rom->enabled for consistency?
> 
> Then again - is you also dropping the check of header->rom_enabled
> actually correct?

rom->enabled should only be set when both the ROM is enabled and
memory decoding is also enabled for the device.

> While both are written to the same value by
> modify_decoding(), both rom_write() and init_bars() can bring the
> two booleans out of sync afaics.

Right, bar->enabled is not a clone of header->rom_enabled, as the
later only caches the ROM BAR enable bit, while the former caches both
header->rom_enabled and whether memory decoding is also enabled (and
the BAR is mapped).

The usage of command register value in the checks below is indeed
dubious, as the purpose of the change is tono trust the value of
the memory decoding bit in the command register.

I think the only way is to cache the Xen intended value of the memory
decoding command register bit for it's usage in rom_write().

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:39:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:39:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429221.680100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzY5-0001jY-8U; Mon, 24 Oct 2022 15:39:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429221.680100; Mon, 24 Oct 2022 15:39:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzY5-0001jR-5m; Mon, 24 Oct 2022 15:39:33 +0000
Received: by outflank-mailman (input) for mailman id 429221;
 Mon, 24 Oct 2022 15:39:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QvrT=2Z=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1omzY4-0001jL-AT
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 15:39:32 +0000
Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com
 [2a00:1450:4864:20::634])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d2b3fa6-53b2-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 17:39:31 +0200 (CEST)
Received: by mail-ej1-x634.google.com with SMTP id kt23so404896ejc.7
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 08:39:30 -0700 (PDT)
Received: from [192.168.1.93] (adsl-235.109.242.224.tellas.gr.
 [109.242.224.235]) by smtp.gmail.com with ESMTPSA id
 15-20020a170906328f00b007933047f930sm25891ejw.157.2022.10.24.08.39.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 24 Oct 2022 08:39:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d2b3fa6-53b2-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=esmhnhHFIe2Ujg1U7XAoozwzNzCLUpinlNTIJUCh4Pk=;
        b=HJj35EQAF02Z+C2xzkSIU9Ype0BxK766yMfzeKS9ZqmMcm7V3lFr19JWXxaAx3dgfF
         70Rtc84puCUDzFY9elkMfl7euow7lERGpL8NGRwvNbuNsMuXcyu3itDJNPE9Qr4Tt5Bj
         0sUsoagBnXB9C4iRNSuMY8f9Wf0EgLwr+Jxam7iQjozbSQ+2s9CrMtM3n8TX2Ai00Mc/
         tj98IgYNZvJQrTXJw2sWSsv2vi85c9Y+zf6s4VkUOQvZ/t7AxPHi2gy2igyL57X2gHV4
         golLI97UCvIsNpXGzEVSOZWrsMToBqJkf/cGDJgsyvhxOkkxTb4KjBeUVE9I5+21XLyj
         mWTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=esmhnhHFIe2Ujg1U7XAoozwzNzCLUpinlNTIJUCh4Pk=;
        b=b+rfJSYrhZ0lNPcLTHNOfhfL8TUW83M/GzAT8mQQtH4JB0YJ9uZGCJdQdQlckzo3uc
         dirYOReRJqh1v0aPvYgekdpQSjjU8PiDlhDaPy05BChACMwQRI1mvg1RG6XYXIvAp+NI
         pqGOHElqCMUwRA26d+MbvrX/zJcRc+laTxnx/szG2Uz/IYoxa2x22ebgGPlxACrv/fex
         xzR85xKx9tWhxFPfITfuNSKbkWlD7rz2UFUDv3DEoXd7feDruouqmYD6lex2vrpKDu3C
         Y8W+to0e/P+JZoNVnzIyIElj5PxH9xqdavATLkyMgq+cJ91ZCSPdpBCBcf+1q1Jsqr3c
         3xFw==
X-Gm-Message-State: ACrzQf3K4i8urrCMCSZ7Jt2FgyENRCHHbFoAbdsALLaY4WrMH1ODShB5
	GqC5BOaOAip1POu91LLceO8=
X-Google-Smtp-Source: AMsMyM4Ed+uvUG4XENTSta0eWZE2lk1UYlbCbu8Mmmg5wag6a+3wR/pV3WHfaZVZiw6wTrbeZbYuXg==
X-Received: by 2002:a17:906:4a09:b0:78d:b6bb:ff5f with SMTP id w9-20020a1709064a0900b0078db6bbff5fmr27126076eju.538.1666625970443;
        Mon, 24 Oct 2022 08:39:30 -0700 (PDT)
Message-ID: <8202b890-5aea-f785-55dd-970d82f50d37@gmail.com>
Date: Mon, 24 Oct 2022 18:39:27 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC v2 00/12] xen/arm: Don't switch TTBR while the MMU is on
Content-Language: en-US
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
 carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221022150422.17707-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Julien

On 10/22/22 18:04, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Hi all,
> 
> Currently, Xen on Arm will switch TTBR whilst the MMU is on. This is
> similar to replacing existing mappings with new ones. So we need to
> follow a break-before-make sequence.
> 
> When switching the TTBR, we need to temporary disable the MMU
> before updating the TTBR. This means the page-tables must contain an
> identity mapping.
> 
> The current memory layout is not very flexible and has an higher chance
> to clash with the identity mapping.
> 
> On Arm64, we have plenty of unused virtual address space Therefore, we can
> simply reshuffle the layout to leave the first part of the virtual
> address space empty.
> 
> On Arm32, the virtual address space is already quite full. Even if we
> find space, it would be necessary to have a dynamic layout. So a
> different approach will be necessary. The chosen one is to have
> a temporary mapping that will be used to jumped from the ID mapping
> to the runtime mapping (or vice versa). The temporary mapping will
> be overlapping with the domheap area as it should not be used when
> switching on/off the MMU.
> 
> The Arm32 part is not yet addressed in this version. The series is
> sent as an early RFC to gather some feedback on the approach.
> 
> After this series, most of Xen page-table code should be compliant
> with the Arm Arm. The last two issues I am aware of are:
>   - domheap: Mappings are replaced without using the Break-Before-Make
>     approach.
>   - The cache is not cleaned/invalidated when updating the page-tables
>     with Data cache off (like during early boot).
> 
> The long term plan is to get rid of boot_* page tables and then
> directly use the runtime pages. This means for coloring, we will
> need to build the pages in the relocated Xen rather than the current
> Xen.
> 
> For convience, I pushed a branch with everything applied:
> 
> https://xenbits.xen.org/git-http/people/julieng/xen-unstable.git
> branch boot-pt-rework-v2

Are you sure that the branch has been pushed remotely? If yes, ignore.

> 
> Cheers,
> 
> Julien Grall (12):
>    xen/arm: Clean-up the memory layout
>    xen/arm32: head: Jump to the runtime mapping in enable_mmu()
>    xen/arm32: head: Introduce an helper to flush the TLBs
>    xen/arm32: head: Remove restriction where to load Xen
>    xen/arm32: head: Widen the use of the temporary mapping
>    xen/arm: Enable use of dump_pt_walk() early during boot
>    xen/arm64: Rework the memory layout
>    xen/arm: mm: Allow xen_pt_update() to work with the current root table
>    xen/arm: mm: Allow dump_hyp_walk() to work on the current root table
>    xen/arm64: mm: Introduce helpers to prepare/enable/disable the
>      identity mapping
>    xen/arm64: mm: Rework switch_ttbr()
>    xen/arm64: smpboot: Directly switch to the runtime page-tables
> 
>   xen/arch/arm/arm32/head.S           | 253 ++++++++++++++++++----------
>   xen/arch/arm/arm32/smpboot.c        |   4 +
>   xen/arch/arm/arm64/Makefile         |   1 +
>   xen/arch/arm/arm64/head.S           |  86 +++++-----
>   xen/arch/arm/arm64/mm.c             | 160 ++++++++++++++++++
>   xen/arch/arm/arm64/smpboot.c        |  15 +-
>   xen/arch/arm/domain_page.c          |   9 +
>   xen/arch/arm/include/asm/arm32/mm.h |   4 +
>   xen/arch/arm/include/asm/arm64/mm.h |  12 ++
>   xen/arch/arm/include/asm/config.h   |  63 +++++--
>   xen/arch/arm/include/asm/mm.h       |   2 +
>   xen/arch/arm/include/asm/setup.h    |  11 ++
>   xen/arch/arm/include/asm/smp.h      |   1 +
>   xen/arch/arm/mm.c                   | 105 +++++++-----
>   xen/arch/arm/smpboot.c              |   1 +
>   15 files changed, 536 insertions(+), 191 deletions(-)
>   create mode 100644 xen/arch/arm/arm64/mm.c
> 

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:45:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:45:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429229.680112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzdh-0003H6-1K; Mon, 24 Oct 2022 15:45:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429229.680112; Mon, 24 Oct 2022 15:45:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzdg-0003Gz-Tf; Mon, 24 Oct 2022 15:45:20 +0000
Received: by outflank-mailman (input) for mailman id 429229;
 Mon, 24 Oct 2022 15:45:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1omzdg-0003Gt-5n
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 15:45:20 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id db25d622-53b2-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 17:45:18 +0200 (CEST)
Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 11:45:11 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6601.namprd03.prod.outlook.com (2603:10b6:303:128::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Mon, 24 Oct
 2022 15:45:08 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022
 15:45:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db25d622-53b2-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666626318;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Dxe7k6DSxaQxf/PQnS4TwHgZiw34blUqEfl7lJC/Wns=;
  b=D/dl0P/yAWMKh1gLsHtN/o3DZ58A9wJwQgF3L4bcpxXoMxcdUghlwJqb
   CcJlUl6ZyEySTdCStv9fitz1udTeBolCEVIRtZtawvRa+cvNLdB4VGh0Y
   FZnBtu1+UqMb0yfU6pT3EdSLToy0bZkNfVuy8uUamWW/ZYT/4X6AJ286M
   8=;
X-IronPort-RemoteIP: 104.47.51.47
X-IronPort-MID: 85914126
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:78oLRqn2xEPkkM/xKkAJ7Cvo5gybJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIWWWiFMqnYZzP3c9sjaoji9UgG6MSGzYVlHlNlqS5hHiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWG1ep
 OE3JzU0XyuIntmnxOy9e9Fsr5F2RCXrFNt3VnBI6xj8Vaxja7aaBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqui6Pk2Sd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iLx17aTxHmlMG4UPJ+iyK9Ro1yX+lEWJ1pGD2KQjKeXskHrDrqzL
 GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvBHTVytJWFRHTb8a2bxQ5eIgAQJG4GICUCFA0M5oG8pJlp1k6QCNF+DKSyk9v5Xynqx
 CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb/D2B0wTA3Ncp9Ebs=
IronPort-HdrOrdr: A9a23:uuOq8a5i0Kq9lUBBfQPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ
 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa
 Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN
 MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9
 gsAp4Y6o2mcfVmHJ6VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="85914126"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QgvJWuMbcfYe4zAeXK0kxnxT3e7A/06l+o2Cf7NVZdzGVquxacf4rALo4knI7l4lq3UubJsUPjmtmzyEjFrRHqBWhIwj2tCXxEuGpftY0UTz3z1I1Zx2ScmW9k+eZxRscLQClfCL1iABUhMguAVVaGXTZrk0eq8uKXc6H7QM8g7jFieWwy3Buone9smAqgvh12HffLRPMdTOPKc8IIVez3P3CAYdNbYld/Fdrh4jNrZXq8d6tsUPK6kVnLQwYNAA/lBJZ0mM0tuhmv7maYOU+CZN0hFQvH6sLlIHZRFQFqqXvgWuaULDh+S3NPcqVCG2eY1+gsbQJ5jNyfjQu9OAtA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RKWsM/xhzADHISPFyavQE8JYWV4KUiN3xi1vW7pAttY=;
 b=Pyk7Xk5qnDEA06XK30YAMr+3NqH0WjHBk3Eky3hFtYR/13so4h6/iIQMPsIpkzGMkE7rb8QuGH2Yia1TEhPX2tmYxbvXhRQaVnaGEAIIwDLMBnFa5xnqNmEVggMsxIiPzqDF+OlWVoqjBxf4CaGT0zCK7vutZPT9xAkqEozddMI7qmekInXivP+7AHk62HltfdKWzd/oeYbhM1KOCTSwIg40F9qbK39/Qy1SOSxfR5q95E6J4iigOttK+5LbcVs0H4YALdFGQWkXKlpunzb7B4DazDtOJbt5fTmy20SZNtZvYymkqooFwmJaGTxvHKvjbChXIP9kFErRAmODEParQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RKWsM/xhzADHISPFyavQE8JYWV4KUiN3xi1vW7pAttY=;
 b=ajRht9d3OHOnwlIFw6lmMt4TMEt07VmjVtfQBigawVGA8fWBC4EAAHNevHpmRgVgdeVDB1cyQ4aIsTGYow4MUk4qcY8Dy5i/reG/UVvwPxRNp51mP/PLDH27/oTv1036r91ASZhdcGL6vaOBGhemF8CWXX3Ytaoq/1H1KvjF1FQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 17:45:03 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH for-4.17 5/6] pci: do not disable memory decoding for
 devices
Message-ID: <Y1ay/zIPSpODqsNY@Air-de-Roger>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-6-roger.pau@citrix.com>
 <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
 <Y1aI5Lbi3sysIZVv@Air-de-Roger>
 <730158ce-d168-5dbf-38cc-78cdedcfe33e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <730158ce-d168-5dbf-38cc-78cdedcfe33e@suse.com>
X-ClientProxiedBy: LO4P123CA0261.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::14) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6601:EE_
X-MS-Office365-Filtering-Correlation-Id: 53131d07-92fa-4ef0-859a-08dab5d6ba5d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MOSXdw7+jcYycIkNJ+Zx8YrhfUfjJjNLBQGNngcjtMjKlkLOnPZbx4SDvdv+uguYzTDZRfGhqrAWu1/cFJDEvkEhHmTfx9bGtWn1aZo+TlLQ9dcnLYcNasUPubtVm6SSV9KuOGVq0vY1vIxJRHMxrWJ9V+s8qo1k8Doqj1uUKbPT5H/FIZ3UvWciFQ/3BiK+nWYYUbNVRytu13GLrGchUZD3+xAmd00qXs5CxvV1ZqhGogcl4SiEdpSdt9JkDk3Wge5wv30Oyvxg6f0ht2oiYtbHos/6rRatrXttEVsfO7P9YZ3mhe/ds1dku5yPTmLhrWmYv1qb9axntgohvcLVX3biCyGVAmFvrOvIUBtz3iQ4JOEXWHjuHuD0cpJFkF4lqZUBmyymokuOTFoZqW4Dv+GsEUHZsx2uf77WEpWRF05e9iAyM31jOWBzp7h9tLiCd2rHizXVsFKciBiSV6dd7jIiI9hb5wRdVcupRIjVsaf/nDuCBLzTPxjYG4+UaSASR0m77lCXSf4D01+FRWLl5FQnKFL60OMQ/93nDboHA69mB3p1JkYQF+I0RsmeIVSZKM97Nx3/zFZs1fvY2xt7yr8Y0fYaouSPJo/Ju4u2sEARCS0z4cItvebqbjw2qI7fwo8Yft+BVxSLX/Ar5vfWDAXbnXmkuGL9dQFilBv2uQs+zBqnLVCHih0/Go0+6ucbPvpPZq+mr4iBCiZSfPHk+Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(39860400002)(136003)(346002)(396003)(376002)(366004)(451199015)(6486002)(186003)(2906002)(66899015)(478600001)(26005)(5660300002)(9686003)(66946007)(86362001)(316002)(6916009)(6506007)(33716001)(41300700001)(85182001)(4326008)(8676002)(66556008)(66476007)(53546011)(38100700002)(6666004)(6512007)(8936002)(82960400001)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QlFuWkxvT3BiN08wT1BXeTdQRlZFTDhxd2JFc004M0c4QkpKUUZiSkdXK0h1?=
 =?utf-8?B?Z3B5MWlyQll3UTY2SUh1eEE4aEIwRGp2M0R0MjFWMVpiWkM3OHlXNC9UbXpt?=
 =?utf-8?B?NGk4dFI5MytLVWNaSnNDb0VtVS93TlZTd08zTHRDVlA2cWdCK1pIQ2hSVTBn?=
 =?utf-8?B?a2VaS0lmSUhiWXN6dWwrRFc2TGd4Q0JiSzNIdTFJRnFRR0V6cDgzZFpLeWFN?=
 =?utf-8?B?T3ZWRTBMVkU3UjkxVTNYdWh1Vy9CbzVpWEtEUU1RV000UTNNOW02K3R5aXhs?=
 =?utf-8?B?UWp5SkdOd2tZcks4WjBJT1Nyb0NGdVdwZVdob3VOSUNYMXhjNFNsRzB3Tkx5?=
 =?utf-8?B?cG1jSlN0My9iM0x5Z2pza0REUUE0WDZEcno1RzA5TlVIbFZTa2hCRWZieUdX?=
 =?utf-8?B?Nmhod200VnBKbFF3WlNOR1BRNk9vSnVJaFlhUXJwb2c2dkZFZ3BUNEF4OVlF?=
 =?utf-8?B?MlN0VVV2QmZhUzZTS05WbmRRVlgyQUtvZlMxV3l5cUZDbllJNWJJQjMvTXI1?=
 =?utf-8?B?M3MxOVJ4Y3EyZEQrZ2pINkplNlF2RGdtSGJ6TmJXMTVDYWppWk1KSGxxRlJu?=
 =?utf-8?B?eEZFazJBR3J4L3AzUnpGMkpCYUpwVFFoZE5hT01MTlBtNGMxeEFVcVNxTnZ0?=
 =?utf-8?B?K2xWcndHeCtiVzRyUUZGSTV0K25jL2ZCSWZqcWs3MC84c2x2ZHBNSGJ0ZkxB?=
 =?utf-8?B?dkE0VzZJUUNXYXFXNTJCNmFUenArM0Y4djY3WWk0R3NmdTNIWWdzdk9FMmFn?=
 =?utf-8?B?VHUxK1NZcTVCWWdqYU81SGhialB0NmdqNkxPemdVM0ZieXpjUlBEVG1kZm92?=
 =?utf-8?B?SEg0SFcvZTNpR1lieDNxNWw1eE15VjVPQm4wT2Vta2ZxZGpSMW9OUFNvRGJC?=
 =?utf-8?B?NlE2MlVyNGgrUU51WnFrcXo1OUgzazIyeWJhcEc5OWR6ZTJZa2czckc4aURX?=
 =?utf-8?B?ZDNYeG5zZUd4Ymt5OG5LVXBDY1N0L3BTUkRkV2xlOW1scXlnMkZoK2gzaXdM?=
 =?utf-8?B?b0lsVHk0aUhJRXlnK3Y4UkVwd0hPanNqN0dRcDlxTHdTZ3hhZjg2THZ6aTl5?=
 =?utf-8?B?d0pUNVNzZTRjUytBTFc1MzNyNElCek03UGJSNXg3cjRsMUZDaCtMa01EQmlw?=
 =?utf-8?B?cE1rOVRCV2RBT1lBdlZxWFh6ZzNFanRyYVBvby9MWHBmT0lyT09QMHA1TzFz?=
 =?utf-8?B?MEpSNHVSelluUTFnTXNlQmQ1NjFDOWswWCtCdUQrVmg1OVZMOWJZVU16M3li?=
 =?utf-8?B?R0tXY1p1UU9BQ2VnZnIzRmNmdVNCNE51ZEVWNGh3SGdHRlZoaEN5VDJYUnll?=
 =?utf-8?B?UWxRUEJNVEtBaGNRb3ArdWNoTUZ3dUxqeFE3N1ZyNDZyc1kwaTlWT2Noa3Fu?=
 =?utf-8?B?VXJBWDJldXB0b2o2eWpUbndPRHNZRHp1cm5SeEowcVgyS0poLzNhUThmYVZl?=
 =?utf-8?B?VjU4TUpMM1liN3hWQkRkK2pMUlBSTTFwSUd2Tjk1Q1hpOC90OXFqTWdwMnRT?=
 =?utf-8?B?WC9BOFZxK0dkRFhjaU1ITG9zNllzaVN0dUtZaGd3TldXZnVtdjR2a1Y5WVkx?=
 =?utf-8?B?L1hlVUU0SFRqQzZ6eFh3bGw5ZnZPR2d6RGRZblFpeU1pcEFvUEpSRXVKVXQx?=
 =?utf-8?B?WnQwa1hBQ3ZNZHk0YTcyNXZNM3M4LzhMWHByM1pndFMvNnFDQ0FkTUppQVdX?=
 =?utf-8?B?V05zLzR6YVVvRy9IZGFtRm9JelZWNW9KWEk5N2ZZMUQrUFl1R05RKzlsUVNk?=
 =?utf-8?B?OUVtck5NUldIUXlqa3Z3YXFvc1N3UDI1bzJBelE2OEtYWjNoZURnUUw0Rkxr?=
 =?utf-8?B?RVlvNnhHYUNkSUJxMmU2c3RkaXc3T3pBUzZBenB2MVhlcnZ5d0dZU0tOK0RK?=
 =?utf-8?B?QVA3RlBHNkNWWUMrWGQxaHJHRi9zZmx1a01iUDZodG91UWxOcGVxQ2l4SGxI?=
 =?utf-8?B?V1Erb0tmVU95MzZEV0xnME13aG5WQ3ZScnhUMHk2Z0ZnSml2NitTZEErVm5W?=
 =?utf-8?B?Qjl4ZjNoL3JoREEyT0ZNc0RFMlo1dkRFZVlPaDNnMUNzWUc4OTl4TGJmbmli?=
 =?utf-8?B?bUxabEc1K3FuYWlTMFp4Z0YzeVNxNCt5bTdtbnR6YUlmTG8wNWpVaStYbVBv?=
 =?utf-8?Q?i65C44UfwZwq7k+BjehcfSWcC?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53131d07-92fa-4ef0-859a-08dab5d6ba5d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 15:45:08.2697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PCEaZ794rktq4Rfn/mrxMEBQlJmtdp6JbVms/OFElvim5/i7OvnSWyL1AaaXqISCS/IbFXG+DCFfvyKSMA92cA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6601

On Mon, Oct 24, 2022 at 03:59:18PM +0200, Jan Beulich wrote:
> On 24.10.2022 14:45, Roger Pau Monné wrote:
> > On Mon, Oct 24, 2022 at 01:19:22PM +0200, Jan Beulich wrote:
> >> On 20.10.2022 11:46, Roger Pau Monne wrote:
> >>> Commit 75cc460a1b added checks to ensure the position of the BARs from
> >>> PCI devices don't overlap with regions defined on the memory map.
> >>> When there's a collision memory decoding is left disabled for the
> >>> device, assuming that dom0 will reposition the BAR if necessary and
> >>> enable memory decoding.
> >>>
> >>> While this would be the case for devices being used by dom0, devices
> >>> being used by the firmware itself that have no driver would usually be
> >>> left with memory decoding disabled by dom0 if that's the state dom0
> >>> found them in, and thus firmware trying to make use of them will not
> >>> function correctly.
> >>>
> >>> The initial intent of 75cc460a1b was to prevent vPCI from creating
> >>> MMIO mappings on the dom0 p2m over regions that would otherwise
> >>> already have mappings established.  It's my view now that we likely
> >>> went too far with 75cc460a1b, and Xen disabling memory decoding of
> >>> devices (as buggy as they might be) is harmful, and reduces the set of
> >>> hardware on which Xen works.
> >>>
> >>> This commits reverts most of 75cc460a1b, and instead adds checks to
> >>> vPCI in order to prevent misplaced BARs from being added to the
> >>> hardware domain p2m.
> >>
> >> Which makes me wonder: How do things work then? Dom0 then still can't
> >> access the BAR address range, can it?
> > 
> > It does allow access on some situations where the previous arrangement
> > didn't work because it wholesale disabled memory decoding for the
> > device.
> > 
> > So if it's only one BAR that's misplaced the rest will still get added
> > to the dom0 p2m and be accessible, because memory decoding won't be
> > turned off for the device.
> 
> Right - without a per-BAR disable there can only be all or nothing. In
> the end if things work with this adjustment, the problem BAR cannot
> really be in use aiui. I wonder what you would propose we do if on
> another system such a BAR is actually in use.

dom0 would have to change the position of the BAR to a suitable place
and then use it.  Linux dom0 does already reposition bogus BARs of
devices.

> >> Plus with this adjustment, is
> >> ...
> >>
> >>>  Signaling on whether BARs are mapped is tracked
> >>> in the vpci structure, so that misplaced BARs are not mapped, and thus
> >>> Xen won't attempt to unmap them when memory decoding is disabled.
> >>>
> >>> This restores the behavior of Xen for PV dom0 to the state it was
> >>> previous to 75cc460a1b, while also introducing a more contained fix
> >>> for the vPCI BAR mapping issues.
> >>
> >> ... this (in particular "restores the behavior") a valid description
> >> of this change?
> > 
> > Yes, it restores the previous behavior for PV dom0, as memory decoding
> > is no longer turned off for any devices regardless of where the BARs
> > are positioned.
> 
> It restores one aspect of behavior but then puts in place another
> restriction.

I assume the other restriction is about moving the check to vPCI code
rather than disabling memory decoding?

It restores the behavior for PV dom0, and keeps a more 'contained' fix
for PVH dom0.

> 
> >>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>> ---
> >>> AT Citrix we have a system with a device with the following BARs:
> >>>
> >>> BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
> >>> BAR [0, 0x1fff] -> not positioned, outside host bridge window
> >>>
> >>> And memory decoding enabled by the firmware.  With the current code
> >>> (or any of the previous fix proposals), Xen would still disable memory
> >>> decoding for the device, and the system will freeze when attempting to
> >>> set EFI vars.
> >>
> >> Isn't the latter (BAR at address 0) yet another problem?
> > 
> > It's a BAR that hasn't been positioned by the firmware AFAICT.  Which
> > is a bug in the firmware but shouldn't prevent Xen from booting.
> > 
> > In the above system address 0 is outside of the PCI host bridge
> > window, so even if we mapped the BAR and memory decoding for the
> > device was enabled accessing such BAR wouldn't work.
> 
> It's mere luck I would say that in this case the BAR is outside the
> bridge's window. What if this was a device integrated in the root
> complex?

I would expect dom0 to reposition the BAR, but doesn't a root complex
also have a set of windows in decodes accesses from (as listed in ACPI
_CRS method for the device), and hence still need BARs to be
positioned at certain ranges in order to be accessible?

> >> I have to admit
> >> that I'm uncertain in how far it is a good idea to try to make Xen look
> >> to work on such a system ...
> > 
> > PV dom0 works on a system like the above prior to c/s 75cc460a1b, so I
> > would consider 75cc460a1b to be a regression for PV dom0 setups.
> 
> Agreed, in a way it is a regression. In another way it is deliberate
> behavior to not accept bogus configurations. The difficulty is to
> find a reasonable balance between allowing Xen to work in such cases
> and guarding Xen from suffering follow-on issues resulting from such
> misconfiguration. After all if this system later was impacted by the
> bad BAR(s), connecting the misbehavior to the root cause might end
> up quite a bit more difficult.

IMO we should strive to boot (almost?) everywhere Linux (or your
chosen dom0 OS) also boots, since that's what users expect.

I would assume if the system was impacted by the bad BARs, it would
also affect the dom0 OS when booting natively on such platform.

What we do right now with memory decoding already leads to a very
difficult to diagnose issue, as on the above example calling an UEFI
runtime method completely freezes the box (no debug keys, no watchdog
worked).

So I think leaving the system PCI devices as-is and letting dom0 deal
with the conflicts is likely a better option than playing with the
memory decoding bits.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:46:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:46:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429233.680122 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzfE-0003pS-BO; Mon, 24 Oct 2022 15:46:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429233.680122; Mon, 24 Oct 2022 15:46:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzfE-0003pL-8j; Mon, 24 Oct 2022 15:46:56 +0000
Received: by outflank-mailman (input) for mailman id 429233;
 Mon, 24 Oct 2022 15:46:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1omzfD-0003pF-1K
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 15:46:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omzfC-00061f-J5; Mon, 24 Oct 2022 15:46:54 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.4.141]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1omzfC-0001PY-BG; Mon, 24 Oct 2022 15:46:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ULTtl8PVHx2ckDx28jZKPX2oTrw1nuKEx+tTDRt8vP0=; b=yM+a/Yt6Xmt9miO2tPi+6pVy2O
	mvX4w7854X5cOSW4LgV6FovYCbiwFWzqmkaza0yKyYz15EEqFMImfJUSOpMGPqR6UaPQo+jl3XmHk
	Lnz+90S8HEiXI9x95UmRcfpE7ofGdluylRbi/mOGQqC7NTXYVZpK4Az7ixxM9zkCIbB0=;
Message-ID: <dc8b1ef5-c878-c773-0e73-51833e10e633@xen.org>
Date: Mon, 24 Oct 2022 16:46:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC v2 00/12] xen/arm: Don't switch TTBR while the MMU is on
Content-Language: en-US
To: Xenia Ragiadakou <burzalodowa@gmail.com>, xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
 carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <8202b890-5aea-f785-55dd-970d82f50d37@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <8202b890-5aea-f785-55dd-970d82f50d37@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 24/10/2022 16:39, Xenia Ragiadakou wrote:
> Hi Julien

Hi Xenia,

> 
> On 10/22/22 18:04, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Hi all,
>>
>> Currently, Xen on Arm will switch TTBR whilst the MMU is on. This is
>> similar to replacing existing mappings with new ones. So we need to
>> follow a break-before-make sequence.
>>
>> When switching the TTBR, we need to temporary disable the MMU
>> before updating the TTBR. This means the page-tables must contain an
>> identity mapping.
>>
>> The current memory layout is not very flexible and has an higher chance
>> to clash with the identity mapping.
>>
>> On Arm64, we have plenty of unused virtual address space Therefore, we 
>> can
>> simply reshuffle the layout to leave the first part of the virtual
>> address space empty.
>>
>> On Arm32, the virtual address space is already quite full. Even if we
>> find space, it would be necessary to have a dynamic layout. So a
>> different approach will be necessary. The chosen one is to have
>> a temporary mapping that will be used to jumped from the ID mapping
>> to the runtime mapping (or vice versa). The temporary mapping will
>> be overlapping with the domheap area as it should not be used when
>> switching on/off the MMU.
>>
>> The Arm32 part is not yet addressed in this version. The series is
>> sent as an early RFC to gather some feedback on the approach.
>>
>> After this series, most of Xen page-table code should be compliant
>> with the Arm Arm. The last two issues I am aware of are:
>>   - domheap: Mappings are replaced without using the Break-Before-Make
>>     approach.
>>   - The cache is not cleaned/invalidated when updating the page-tables
>>     with Data cache off (like during early boot).
>>
>> The long term plan is to get rid of boot_* page tables and then
>> directly use the runtime pages. This means for coloring, we will
>> need to build the pages in the relocated Xen rather than the current
>> Xen.
>>
>> For convience, I pushed a branch with everything applied:
>>
>> https://xenbits.xen.org/git-http/people/julieng/xen-unstable.git
>> branch boot-pt-rework-v2
> 
> Are you sure that the branch has been pushed remotely? If yes, ignore.

I forgot to push it. It should now be pushed.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 15:56:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 15:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429239.680133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzoX-0005PK-7g; Mon, 24 Oct 2022 15:56:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429239.680133; Mon, 24 Oct 2022 15:56:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzoX-0005PD-57; Mon, 24 Oct 2022 15:56:33 +0000
Received: by outflank-mailman (input) for mailman id 429239;
 Mon, 24 Oct 2022 15:56:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omzoU-0005P7-Tw
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 15:56:31 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6c0c5ddf-53b4-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 17:56:29 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB9100.eurprd04.prod.outlook.com (2603:10a6:10:2f3::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Mon, 24 Oct
 2022 15:56:26 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 15:56:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c0c5ddf-53b4-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JVHdPBrUIYPqGe1pZ20jPUymUfe+9VNlCNEeavyb2JcLCQGzwLjET33fPO+Uc8HqslTThvmfN/FDgUAOJsYZ+IYrSY5mPET/bqTtFBPqMXFlUi1xGM3gHOQ4yXseXAY81UAkkz5tTk2xrnNijJU4UlHUgXyZpiIytniDWzjhpMDsFsn6a05mnnsVbvTJ6fNXbBEkoMwbKKJ5hQULZV1OVEgSHv6Ka9CT1jvqPKEqS2Lxe/djcKJu+l1KwkOBmH1trhV5AEImdr8728pKateAV9AhPYYuqjkX2oBbZ/Bih2yW12BGPfk5b6UE8g/AK+oCnTqFyrDCQYsqveKstAJ3Ug==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KxL015ye25JaB+u+T4WKhG34ZmwUdObg3fYJa5grYxI=;
 b=VxW2/hYPHVtzyKkpY7fZ0+wCNEtcq5EXQPDzKENdRKaFKdek+WNwxNuPizMMCK4Ye6iKLPbUKHMnWqR2ghyRL/4CSCl6W2Og+QQZZBu7PJaFl/xwytCwKICcPUGChMau/TCwToohWRlOn4c79fFRYCF80bt867kUvCLSpCYPlBy63cnMsHvYFk/m+w86MVgqJHn9UrkJKXyuAqnmRQj53n7H4nVw7oMn/A7DrwV9fRZXKrpq5QCZpJDz+25G4Hcl62UufcUMWfD8SUA7M+vWYWhw+FCBsbX8Ic3pZH7o9sfqyrf1hbfNajuZgSF491EOuY6rH/n6uP/BhpJEPgBAuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KxL015ye25JaB+u+T4WKhG34ZmwUdObg3fYJa5grYxI=;
 b=mbjUqzHJ+0pJRaKWLxnPuDWMcYIrNGSGzlmUIr+yDeEzRm0gb2ri3vpiYwp/5B8Kb2agPPRmc/9s/QVY+4JSNhKjjaFHWMIsO9SoRYFKVOJoB9IziI+SibuFVOu9s/DY0Jayta9+37p5eKrdg2Xx0x15rerxWryHgeRgZuzxJ6HBCooEYOxPjQ7/JDjU6E4R2VGe//lBSGUJM6/D+OQpQutJosgQt1uCpJ3P9tL3wGmssd6yjd7yDpbMxaRpyYxyrQkg34ufHlav2CumPdSS00EA5IaxQCFovhpNtAHkENJVy/AsjJRd3yk9DGNQL6lo0b/LaeH4ggznxr1cqRa1Dw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <82a69c5c-3174-cee0-932b-3141df6454a2@suse.com>
Date: Mon, 24 Oct 2022 17:56:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 5/6] pci: do not disable memory decoding for
 devices
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul@xen.org>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-6-roger.pau@citrix.com>
 <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
 <Y1aI5Lbi3sysIZVv@Air-de-Roger>
 <730158ce-d168-5dbf-38cc-78cdedcfe33e@suse.com>
 <Y1ay/zIPSpODqsNY@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1ay/zIPSpODqsNY@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9100:EE_
X-MS-Office365-Filtering-Correlation-Id: d7181d9d-0882-4ae4-d9e8-08dab5d84e8e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SQm7eK1J882vwbsh6OgPhoarQldQidGcpezkRcjUft/Gv4AGvV/YJY1/0Up/IF8DfxZp4Cgm0wZ8tJfATlv1dMNTu0zBtiRw4L3OoFDaZOx4Vx6GIM/VkaW9grYeWkfnYRlWH7hYpYHsimDqFPNFSaQtIjxsN25mVrUSK+iw2j0uUE1R2v6uFbcqrhGxm09MHMKHMlFcoBkfdXAKMwcI6ASyf8NCs5yUIDe6xRjMKhp1VPSuK0t8Xl+mKz7By5Z1vu2HEczidK2bfCL0STTwwA0oOCrvq7v/ZTl+jfdmgANNnmykMI4BH10KZXePbir5r8jJTJkCQjU32kK55TGj6ljJoz6EWiNgO67+3xxMqIyAFAumr0XNlQqv+lspFwsWjZro546DiIgxaWYQ1sJRpCfYiNeMyDi3BclZKmFgEondrV6PF3jPIDyjJY3pd08J6Pyc0q8TD6mqwoxd4aZddijFvRAuDBjIEQte9yNlEdFT5rklEMIjwWq2DjSfnXRRwidiHTpelDDRGgs+yc/XPG7FizSQPJaIjYGrB4cWRp3KHCDLzCSN7ZmyPfGXuqmt3u3WYig8IhDelX6Mg9LQAWupc3DH7Ba6MOKUOyglJo+hb2GW5E3LKv9xWeS2rPQV6wwmxmk76pzO0nxM0LrlFHr84fjakEA7EQ7hXz/XJZQKxBSqDBSlebZLQ8U3d2++1UiYRPINBIAlgWd28oLZon+rtuW21XGSiHs/LJfZDrKb6GwTeV2I4VuIljZCBP81pZ+VZ6oMBkRG1rcy/gn9vnDw0k1cykSl3sG3ERcGt14=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(136003)(376002)(366004)(451199015)(6916009)(6512007)(316002)(53546011)(186003)(31696002)(8936002)(83380400001)(66946007)(2616005)(66476007)(86362001)(6506007)(5660300002)(66556008)(41300700001)(8676002)(36756003)(2906002)(4326008)(26005)(31686004)(66899015)(38100700002)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZEZzRUNMVy8yRGlucGhLRTF4YWh6Q1dOMkxJZUtST3ladzVzcDdidkIySWl5?=
 =?utf-8?B?V3lpZy9DelJCaVBnNUVGTXd4NHFzN1JTVm90dnpBejUxT0cyTmNOZG9CK2to?=
 =?utf-8?B?TFJJT2s2SzlYL3k5NHh4UnpONjNkTEYwaHRXeFJ4aEFjbERVL3NLS0JsbXI3?=
 =?utf-8?B?OXcrTHlQTHNvQ3kvbW9mSFN1aVRmMGFnY3hRckJHYXVxSEUzeEpsVi93TFcw?=
 =?utf-8?B?WjVvOTVOWE9pN29XV2VMRDJmQjFGTXYzeEhBRFg3SkU1cExiZDJaV29WclVL?=
 =?utf-8?B?TjlNMGlLRUo5LzZCbmRTQVRJZWRqUUJlU1NFR1hCL3FkN1didW9sdTRSVS9s?=
 =?utf-8?B?dTY3akRROTYzQXdxY1MyN29HRzlpQmxkMUFYQU1kbzVDcE1xT0dNcGdQV1kv?=
 =?utf-8?B?ZXVJK1ArMDd0N3hiVk9xR3BKV3R2VzhJU0hqWk1xd25sQ2xLelVONU5OZTA4?=
 =?utf-8?B?M3lsVE9DUnJET2lkbGJ4aXEyQjN2aXMwZmpwTGpub0dRSWZ4UkpTTGljYVFM?=
 =?utf-8?B?RmRKZnozdkpoWkNRRWlIU2luTnpHVytUdDFWSEJIcFMwaEJTTElhVURFMTJm?=
 =?utf-8?B?c0tHOENBTWh5b1pWNHpadTRsUHBVeTlSRHRHS0NQOEdwMlVscGJrTjFJbHFj?=
 =?utf-8?B?T3IralBma1l5NWFsVkVEakNIMnRid0xYU3ZQZE81R0RtblNqdE1obEU3WlE4?=
 =?utf-8?B?MkZpbjV3V2FScGpRWENyNEQ0ZkJOSXF5dzVRM0xWcjBnSmtqTzBYTytHY1hS?=
 =?utf-8?B?dWtBQzA4WGR0Uyt1NW1UdE5GdjJzc0FoczM5UVVud0pHRVRsRmlNcS9BcWRs?=
 =?utf-8?B?ZGRhQXBqeGpQYWpCQTVZS2VnT0RPNENGU2RjbnV2MkJ1V2tSUWZCT21XK0xD?=
 =?utf-8?B?S3dyQ2hyT3duaXVIa0h1NjdSYVhQTEUvNW8xVTdDYVB6WUovUGJPTTZNbnBB?=
 =?utf-8?B?RGFtUTVIQ3hTVkxQV2xoNnlCMUJmMDR1Wk9uQ1lrdkUxc1ZrYjEvREFLTndH?=
 =?utf-8?B?RlMxaEdWQk9mdGFnR1M3SnhmaUY5UFlXNE1oRTN2dXdLb1RibXRIYWV4Y1NC?=
 =?utf-8?B?NkpGM1RnYlNkWnhybFZTczZPTUFOclJQUjM3WGgrYm9FYVAvdjdVUXQ0VkhH?=
 =?utf-8?B?cXIwY1RHNzNSV1Awb3FTZThNYXhuRjZBNVJldkhZSnl6VDEzMWpKRC9JSFFV?=
 =?utf-8?B?UzhqWERCZFUxU3AraWdvZkdENGlBRFJtQ3VsbU1GcEdSMzdBMWZvUVppQUVn?=
 =?utf-8?B?RW95UFh1UzI1aElLakt3MVhnTFdxZEZlSjFhVktGYzB2OThHVi9zaTNKUm5o?=
 =?utf-8?B?RzlCWkU0dExLWDRNMnM0aEEyTC85amRBSUgreG1ibE50NUxYbnc1dCszWWQ3?=
 =?utf-8?B?MHI0OVhBSDg0WGV3Wnd6bzh1aEVkQk9VM3F2R205ZnpGem80NGJ2RVo2QmVL?=
 =?utf-8?B?aEdFNnh6TEp0c3gxMFllejRzREp5WEN3NXpHcEMwNVZ2M0RJL3RlTzVzNGV2?=
 =?utf-8?B?ODQvRzBsOVVMTzVFWVFaN2Q0TjFiV0tqOTdiNFFKRUNJVWdCN3d0VWVxeW84?=
 =?utf-8?B?K0VRd09BQUpCTnpic1Zwdmp3eEpPcTVjQ3ArSnduSUJ1d210MWQzaEFuY2Fa?=
 =?utf-8?B?anlyQkxnSHUxZm1lMnNUbHJYM1dveGtPb2xuOHFaZWM0OUVndTVFVE5PL2ZG?=
 =?utf-8?B?TUs5RkRHV0ZZMnRjdlp4MTRwM29xN0lQMlJ0YUlFZi9LVWlxb1haVUx2bTM3?=
 =?utf-8?B?T0t5dDgzTC9JdzZuZ1dkR3g5bC9RbU4yK25SeDVxYzJjKzh5RWlYYThrcHVG?=
 =?utf-8?B?RE43S004UHNPSUxyV1Z0azFIWDJBSUc2U0YrUHJxRzk2TlJFaFdKNzRVdlBw?=
 =?utf-8?B?RGx4c2RHbzR6blJrUU1xRFlRWEVycVcwOXJNU0w4UTBvd2RJaUtaek10WktH?=
 =?utf-8?B?RXo2WFAzODVuWDZIVWsrRU5hREx2TldRcHBheG45aHEyQ2NKajl2bjVBUkJh?=
 =?utf-8?B?Tlk4UTdqdlp5ZXZiRi9VaURoL1kzNncyaHFBaGxVU1pRMWZLU2pSa2FYUXRI?=
 =?utf-8?B?Rmk1V0FzcE5ZRGN4d082czZDMlpXb2pIZkNkY0VQTGtaVG5wWDVNWnhodSs3?=
 =?utf-8?Q?lbfsEulN6EgBPf62/I8kPf7MB?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7181d9d-0882-4ae4-d9e8-08dab5d84e8e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 15:56:26.3457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RjTSdKta1jlrKd+sjSX9zYCZrqfsFtZzFuGDLQh/eqe+NWK4+WG9a0w8Z1XPR9Aq4js2Jdo/X50nNaWRKI+VFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9100

On 24.10.2022 17:45, Roger Pau Monné wrote:
> On Mon, Oct 24, 2022 at 03:59:18PM +0200, Jan Beulich wrote:
>> On 24.10.2022 14:45, Roger Pau Monné wrote:
>>> On Mon, Oct 24, 2022 at 01:19:22PM +0200, Jan Beulich wrote:
>>>> On 20.10.2022 11:46, Roger Pau Monne wrote:
>>>>> Commit 75cc460a1b added checks to ensure the position of the BARs from
>>>>> PCI devices don't overlap with regions defined on the memory map.
>>>>> When there's a collision memory decoding is left disabled for the
>>>>> device, assuming that dom0 will reposition the BAR if necessary and
>>>>> enable memory decoding.
>>>>>
>>>>> While this would be the case for devices being used by dom0, devices
>>>>> being used by the firmware itself that have no driver would usually be
>>>>> left with memory decoding disabled by dom0 if that's the state dom0
>>>>> found them in, and thus firmware trying to make use of them will not
>>>>> function correctly.
>>>>>
>>>>> The initial intent of 75cc460a1b was to prevent vPCI from creating
>>>>> MMIO mappings on the dom0 p2m over regions that would otherwise
>>>>> already have mappings established.  It's my view now that we likely
>>>>> went too far with 75cc460a1b, and Xen disabling memory decoding of
>>>>> devices (as buggy as they might be) is harmful, and reduces the set of
>>>>> hardware on which Xen works.
>>>>>
>>>>> This commits reverts most of 75cc460a1b, and instead adds checks to
>>>>> vPCI in order to prevent misplaced BARs from being added to the
>>>>> hardware domain p2m.
>>>>
>>>> Which makes me wonder: How do things work then? Dom0 then still can't
>>>> access the BAR address range, can it?
>>>
>>> It does allow access on some situations where the previous arrangement
>>> didn't work because it wholesale disabled memory decoding for the
>>> device.
>>>
>>> So if it's only one BAR that's misplaced the rest will still get added
>>> to the dom0 p2m and be accessible, because memory decoding won't be
>>> turned off for the device.
>>
>> Right - without a per-BAR disable there can only be all or nothing. In
>> the end if things work with this adjustment, the problem BAR cannot
>> really be in use aiui. I wonder what you would propose we do if on
>> another system such a BAR is actually in use.
> 
> dom0 would have to change the position of the BAR to a suitable place
> and then use it.  Linux dom0 does already reposition bogus BARs of
> devices.

Yet that still can't realistically work if the firmware expects the
BAR at the address recorded in the EFI memory map entry.

>>>> Plus with this adjustment, is
>>>> ...
>>>>
>>>>>  Signaling on whether BARs are mapped is tracked
>>>>> in the vpci structure, so that misplaced BARs are not mapped, and thus
>>>>> Xen won't attempt to unmap them when memory decoding is disabled.
>>>>>
>>>>> This restores the behavior of Xen for PV dom0 to the state it was
>>>>> previous to 75cc460a1b, while also introducing a more contained fix
>>>>> for the vPCI BAR mapping issues.
>>>>
>>>> ... this (in particular "restores the behavior") a valid description
>>>> of this change?
>>>
>>> Yes, it restores the previous behavior for PV dom0, as memory decoding
>>> is no longer turned off for any devices regardless of where the BARs
>>> are positioned.
>>
>> It restores one aspect of behavior but then puts in place another
>> restriction.
> 
> I assume the other restriction is about moving the check to vPCI code
> rather than disabling memory decoding?
> 
> It restores the behavior for PV dom0, and keeps a more 'contained' fix
> for PVH dom0.

Ouch, I'm sorry: I didn't pay attention to the "restore" applying to PV
(the similarity of the acronyms made me read "PVH" despite it being "PV").

>>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>> ---
>>>>> AT Citrix we have a system with a device with the following BARs:
>>>>>
>>>>> BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
>>>>> BAR [0, 0x1fff] -> not positioned, outside host bridge window
>>>>>
>>>>> And memory decoding enabled by the firmware.  With the current code
>>>>> (or any of the previous fix proposals), Xen would still disable memory
>>>>> decoding for the device, and the system will freeze when attempting to
>>>>> set EFI vars.
>>>>
>>>> Isn't the latter (BAR at address 0) yet another problem?
>>>
>>> It's a BAR that hasn't been positioned by the firmware AFAICT.  Which
>>> is a bug in the firmware but shouldn't prevent Xen from booting.
>>>
>>> In the above system address 0 is outside of the PCI host bridge
>>> window, so even if we mapped the BAR and memory decoding for the
>>> device was enabled accessing such BAR wouldn't work.
>>
>> It's mere luck I would say that in this case the BAR is outside the
>> bridge's window. What if this was a device integrated in the root
>> complex?
> 
> I would expect dom0 to reposition the BAR, but doesn't a root complex
> also have a set of windows in decodes accesses from (as listed in ACPI
> _CRS method for the device), and hence still need BARs to be
> positioned at certain ranges in order to be accessible?

Possibly; I guess I haven't learned enough of how this works at the
root complex. Yet still an unassigned BAR might end up overlapping a
valid window.

>>>> I have to admit
>>>> that I'm uncertain in how far it is a good idea to try to make Xen look
>>>> to work on such a system ...
>>>
>>> PV dom0 works on a system like the above prior to c/s 75cc460a1b, so I
>>> would consider 75cc460a1b to be a regression for PV dom0 setups.
>>
>> Agreed, in a way it is a regression. In another way it is deliberate
>> behavior to not accept bogus configurations. The difficulty is to
>> find a reasonable balance between allowing Xen to work in such cases
>> and guarding Xen from suffering follow-on issues resulting from such
>> misconfiguration. After all if this system later was impacted by the
>> bad BAR(s), connecting the misbehavior to the root cause might end
>> up quite a bit more difficult.
> 
> IMO we should strive to boot (almost?) everywhere Linux (or your
> chosen dom0 OS) also boots, since that's what users expect.
> 
> I would assume if the system was impacted by the bad BARs, it would
> also affect the dom0 OS when booting natively on such platform.
> 
> What we do right now with memory decoding already leads to a very
> difficult to diagnose issue, as on the above example calling an UEFI
> runtime method completely freezes the box (no debug keys, no watchdog
> worked).
> 
> So I think leaving the system PCI devices as-is and letting dom0 deal
> with the conflicts is likely a better option than playing with the
> memory decoding bits.

Maybe. None of the workarounds really feel very good.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 16:02:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 16:02:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429245.680145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omztl-0007Qj-VE; Mon, 24 Oct 2022 16:01:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429245.680145; Mon, 24 Oct 2022 16:01:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omztl-0007Qc-SV; Mon, 24 Oct 2022 16:01:57 +0000
Received: by outflank-mailman (input) for mailman id 429245;
 Mon, 24 Oct 2022 16:01:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1omztk-0007QU-DJ
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 16:01:56 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2bb8a6a3-53b5-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 18:01:53 +0200 (CEST)
Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 12:01:49 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BLAPR03MB5458.namprd03.prod.outlook.com (2603:10b6:208:29d::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 16:01:42 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022
 16:01:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bb8a6a3-53b5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666627312;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/7YTJ5jtLxHhn3HvjoLJ/O9AjcKjyGb6Gk+fqzzE+pw=;
  b=clOHfEqXXoZ1s+wpG6m0KprqMhweYiJ7zMlMnbYp2Y6F+/eGThqmDEYN
   QTNqTF8ABw40WrsaFzlDPmkCLUaavOPkBPqVZRm2YCfRwFcxvxEThXdlK
   8TfXOyj267k3vIAWdYs7H2/sbAnBqZ5NfXfrl7sfj4Qp2Z3lWMuGn0vxS
   o=;
X-IronPort-RemoteIP: 104.47.57.170
X-IronPort-MID: 83812020
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:uj8DcaBKerwQoBVW/z7iw5YqxClBgxIJ4kV8jS/XYbTApGgk1GFWy
 WAfXGuFM6rbYWKhetwnaNyw8UxQvcKDndRnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K6u4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kdB5wC2u92MF1X3
 vATJBsvUAKii+G5lefTpulE3qzPLeHNFaZG4zRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAH7gvK/cLb4ECKpOB1+KLqP9fPPMSDWO1en1qCp
 3KA9GP8av0fHIzEmWPfqij07gPJtR+hBK41JaCHyqBj0GC2+0M9FT8Nf2Lu9JFVjWb7AbqzM
 Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQXO
 kShmtroAXljteOTQHfEr7OM92rtYW4SMHMIYjICQU0d+d7/rYovjxXJCNF+DKqyid6zEjb1q
 9yXkBUDa3wopZZj/82GEZrv2lpAerChotYJ2zjq
IronPort-HdrOrdr: A9a23:xEoub6w/3Gw7oD+TCBuLKrPxt+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scy9qFfnhOZICO4qTMyftWjdyRKVxeRZgbcKrAeBJ8STzJ8/6U
 4kSdkFNDSSNykEsS+Z2njeLz9I+rDunsGVbKXlvhFQpGlRGt1dBmxCe2Km+yNNNWt77c1TLu
 vg2iMLnUvXRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIG/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF9nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvGOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA
 BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1sop5PzuN+d3B+3Z
 W1Dk1ZrsAxciYoV9MNOA4ge7rCNoWfe2O6DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK
 j8
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="83812020"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YoedF3Z1Ji+DlkMs+ZEeWBDgZmHyIv5WJzH3t90xr/nQDhncZfq2U7AFkcDVopSvo7W6J/G6+JB6LGwSk9TIiRFPzrHHPnyfGUNwFzar/5OKguF18jisuKHqYJkVBNZ1v+j09QbBUvMnvZ3ofmP9wze6DyqQJEHFRF5RFid93NGwIzej0U8bkN+TUxeHLa2ZlKqy8TKDycx3rKgHclHZ0wUyE6yHsVd+4nUktMnpJ3pbyuYTwmsIPozu6kz6wGHzGfeOLnhl/B/rr6byUCvDYt6CF/4nn/wzlyaD2+2iZR9Lm+swSHYBm3sN54C5b8kFPf4Zq1z5ZcvuV/r8/KauLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PAJAk5Sf/jyvgnBaKzr7y6t3VDPFMx4lhZjIXYCMNJg=;
 b=hC60zy4G/UeEK85msF9Cq9x7wAIx2VARhR572NZPqPa/f6O0amBzCinFg4flNq/JFuUuorHw+/8Ki6aIqN8+GBCZDKmEvldwXBdHGKAAYBe7mf1JcX6faXym5iTW2c6gR88WodUgERYR47BnOHyajsostXBQT0nO4Lso+EAiCOLWCb6MTwsJ6ivmBSmDQimYLytKvJen7v6c8sZCbX4dXSLoEKDfVKwzjvtPH6P0jkW75y6ugRo4KNsiN42EWxIB5zh+MDNhj084ISlSAV22J2rIS984u2ANQCCji8XxohsmiVtCL1O8C2/0O9j8UVmlDAHf/jJVkLIxFq4H37Vk1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PAJAk5Sf/jyvgnBaKzr7y6t3VDPFMx4lhZjIXYCMNJg=;
 b=cIkfBEj4L55CRx/SmtjEvv5SSgknQz170EJ6bwY2NTj26wwiniPWw2mxmCQ+iK/getUyz1bEvmSrT+FxPNG2Kv3b2SU/MkRxDUldl9DYviXBI8P/7t+nRpJWpXGMBTYunY5TFKxYtkcLechBoKgQlf9vdnyzoS68hVR9H3oiPhg=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 18:01:37 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 3/6] vpci: don't assume that vpci per-device
 data exists unconditionally
Message-ID: <Y1a24cSD9zVZFHn/@Air-de-Roger>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-4-roger.pau@citrix.com>
 <ff8559d8-12b6-9218-94bb-8c9a731250a2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ff8559d8-12b6-9218-94bb-8c9a731250a2@suse.com>
X-ClientProxiedBy: LO4P123CA0254.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:194::7) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5458:EE_
X-MS-Office365-Filtering-Correlation-Id: 286b16c0-2a32-44f7-532a-08dab5d90ac6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Dk4MVID+iKa96TWBizyiHKWACLj2G5Hb2zuXyEAWmWVNB3FPwCTDG3AyO/rz8hTuLU8c2fmwHfmFsStRNJDSL3tD0i6Vs4Q0OzxT8X1RuPfz3wCco1v0guAAw+qf2JlqUhnH0aHxZFI2WgQkWWspwAzgPAArK+HusrOF5WpHb2fwFCsEXTaeE7n48eyaKNBmug4KwqmfaJ/08n8GokSV1c1VvxZvmv7iW+UTtPccCgrS/WnI9FROQhY2rYprWuUPfNPaw8TXS5dPgQXKTBc2oUlrXaHAu/2gBbsf72wC7gcuaJfgPvn6x/81uSAfR9sbIO8Qmy0FZQV8uPPthOsDM0juJnAPtOyUbQ+H+wdXZ4UPDN8SJ8lk2qjFminc7LHsKhjVwBLduwUhaS0BXzBo9hpSZcC3yOSEMf74z/Vv0wDzFBw7RaZltIGMDfEPrQsCPAMdYnU4nITHV5FjvOr71lB8qKZIgdMCAfINBOgYRK95r0aIIjhg+2Dwu23yj7YbldAxbHCilgAAoxkNiVEZZuB0JBCVGmkQmXRyd3r5hr5VPSKB9xkdQKS8CbGCWJ2Oq3TcCU/fEqApoCPNDMEXR45S7rcLpmNpgOwCzNh/VbhKn81lrXye1+IBMrMAjwT5Q/nTkjJtWPj5QrYPoaeJ2WX5SNTFuYRgcqXYXEzLAJPtBPtHZxZr+0VEvo5gLZuYpA/PDvmotDznd/jHoO0Ucg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(396003)(376002)(39860400002)(366004)(346002)(451199015)(6486002)(478600001)(38100700002)(83380400001)(33716001)(53546011)(6916009)(85182001)(82960400001)(186003)(66476007)(4326008)(66556008)(8676002)(66946007)(8936002)(9686003)(26005)(6506007)(86362001)(2906002)(316002)(41300700001)(6666004)(6512007)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGV5VnVFUGVJQVk4SUhsMk5wdm0zd3pHenE5MHl3cXdxYVhjaStSVGJLTlB4?=
 =?utf-8?B?Wk10WTFFZjVFeHpmZk5lTzVXZ2R6Y3R4VDhiSzRZczdXMTlsbXpxZGhKS1Np?=
 =?utf-8?B?WUdGcmpqRFF0UXZGaFlYSFlRRTlUaU0yVGc3Yjc3V2NDR0tTL0VKMkI2N0t4?=
 =?utf-8?B?TEcwd1dYUk12ZWErOC82M3B6MnhEOUNPMitpSFBJN1VrbUtsSUF5UjBtN0ZD?=
 =?utf-8?B?QkIvMFhUdlV4cktOdmNoajk0THpieDJBRStaajBQTEcrMFd2YWN6L1J3RWxn?=
 =?utf-8?B?ZytQNHBXK3BESkpRWnVDbFEyS081QXJsS0RXSmlJRGNqVjdhQTVTVzEvVk1M?=
 =?utf-8?B?T3pFZnZKNDNwS3drWXROYjdjMDYyckM0YVJIMVZkem1KSWptS3pXVlc5d2pl?=
 =?utf-8?B?bUV2SVh5bDljYWsvYTJaNmIzQ0dUd1RGbVNEbHQrQUovT1JFVGwvKzM3NUtn?=
 =?utf-8?B?NmcrckVERlVnSHNjVG93TytRZmZVQ001N1NYSjlrU05KbHN6V1JMSDduLzVl?=
 =?utf-8?B?MEc4U3ZXZGcydXZ1cHR4d013VDJCU2U3SDRYT2tUNDNrU0JyWEI4Z2FKczEv?=
 =?utf-8?B?b3JFVG5idXVXeFhvWHlMT2drYm9RN0VMNlJrTmJIL3dYNkNhYnRJOFU2dXh6?=
 =?utf-8?B?ak1zQXRCRlN6aytUSWRPaEc3a3YwcXlNblFuVzg1WkFOSlBuZzhGTW5KZ0d3?=
 =?utf-8?B?LzRkUjFlSFplYzdZTUQ4anBCV0VPc0ZORFNFRjBUMzVtUEtjcTB6ZjU2WUtC?=
 =?utf-8?B?SnpPM2JwNTc3bzRXWEhpV0s0NHJUZ01OWmNYeUVtZzNFWnh0V2o1WGpEWkk5?=
 =?utf-8?B?Q3ZRSExIaExkUHloUUhMMjViZWR3eXVkYUZZOUo3M3ZTdVNpTXpLTUVocjha?=
 =?utf-8?B?RVc3S3lmcEE2TUwvOTJHY1dVYW1BY2JLWG5FWkpVOUI4clFrMXcySW9sOGhv?=
 =?utf-8?B?SjRCRHc3YzhwV0MzMlBNNDZaMWkzbE5WbzZoZFlJd1lTYm5KSlpaNmUzTDJk?=
 =?utf-8?B?WFJhUEVIWVduTUFlZDVGM3ZGNDlCUDZaZVU0KzZuYkQ2ditNRlc5Ry9Xd0R3?=
 =?utf-8?B?RTVxc3ZPa3dRZ0YySWpXcVpUMmhxZ0x2cGF1YkxPSGc2a21LSlg0cnRibzRL?=
 =?utf-8?B?VTFNcGUwWWQzeVNSckhPWmlSM2JZT0IreWlXZnhoRVdhcHp5eFFMQm5hZ0hq?=
 =?utf-8?B?YlgrKzdjZlp1UUk0Z0hwVWNFbFN4VjFUSW5sU0xhNjZ2a0IweUFpQ3FNSzBj?=
 =?utf-8?B?RjNxUjBscnBhSmxWekYxQnFXR3M0KzFWTlFrTmtWWFp5TXlWUUJoRXEvMVo3?=
 =?utf-8?B?dGQzdkoxNlQvVlpERnhvZzV1am9yQi9oUHd4ekw1VjYydjZGM1pqMStvUXF2?=
 =?utf-8?B?cWduZ3RoVWsxVFJ0Zm1zRWMwTTQ3Ui83RkkvdUtNeGZCVWhWQjJLWGEvalo3?=
 =?utf-8?B?SjFaZjd2bXJoUGdMUHdEZGo4RjlIMW1WUDEyS1lybVlXYkhBNkJuTy9BZVA0?=
 =?utf-8?B?dHlLV3pRZHpaQlh5RkVURVg4NnJjSHdIYUFML1BUbUovWGQ4WDBWNDRtY2VH?=
 =?utf-8?B?WFBCU2VRdGhVdW9VNXpDa1NtdlkydXpyVWlNQnhKS1ZZR3FQUzkrNXRTeGhR?=
 =?utf-8?B?TTNFV2ZqcmY5RHdlNUFGYUVUWFhnVUd5cVRRa1hoZVZHSXFHeEJUbWltUU5L?=
 =?utf-8?B?WUhRMkVacjAvazRGTFVTMTBJTG8wSnk3RHVPdFZTR3RHWmVaWkZSbGtQbElE?=
 =?utf-8?B?dnJYQVd4R0NIQVlERlgzaEF0TW1waXVIR1dZYVBhR2d4ZVFjRDdwRitFTkZo?=
 =?utf-8?B?TEVrRVNzWE56OUx0bmxhRWdLNXhqSzJpMTJhakFuaEt0eDNhaE5HZC8vR3Va?=
 =?utf-8?B?ZDhDUVJiMkwycTZjL25HTlRjdStSSXE2QVZSV05oVDFVYlEwSzJTbUJENXlN?=
 =?utf-8?B?bVhDOGhTQ2pFcnQvR0tscWVKV0tDaUlPQVI1a3d6UFBxRlFoeEdZeDFHMkdN?=
 =?utf-8?B?dEgwTnhic3B1RnF6Q1hHWUtZOE9WdVNsQkJqMTM0ODZjL2ttSzlJcmZZSDFK?=
 =?utf-8?B?ZEZYOE1Lb2NJOFRDYkdDc2c4WGdpcnBxM0pNQVBPUDdCSVh0cmdvaVVzclkz?=
 =?utf-8?Q?1kIFggKBRDJ1AvGyFyrEcwKp0?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 286b16c0-2a32-44f7-532a-08dab5d90ac6
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:01:42.2458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sxeXroy6bp4j5Iv0rmWChA/iYfjKpJt8LM3Y9j/0IXx5XfrV+tZYQAqQhFlCf87CuGGivJYmXId18ksLaNBu0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5458

On Mon, Oct 24, 2022 at 01:04:01PM +0200, Jan Beulich wrote:
> On 20.10.2022 11:46, Roger Pau Monne wrote:
> > It's possible for a device to be assigned to a domain but have no
> > vpci structure if vpci_process_pending() failed and called
> > vpci_remove_device() as a result.  The unconditional accesses done by
> > vpci_{read,write}() and vpci_remove_device() to pdev->vpci would
> > then trigger a NULL pointer dereference.
> > 
> > Add checks for pdev->vpci presence in the affected functions.
> > 
> > Fixes: 9c244fdef7 ('vpci: add header handlers')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> I wonder though whether these changes are enough. Is
> vpci_process_pending() immune to a pdev losing its ->vpci?

I think this is safe so far because the only place where
vpci_remove_device() gets called that doesn't also deassign the device
from the domain is vpci_process_pending(), and in that error path it
also clears any pending work.  Since the device no longer has ->vpci
handlers  no further calls to vpci_process_pending() can happen.

> Furthermore msix_find() iterates over d->arch.hvm.msix_tables, which
> looks to only ever be added to. Doesn't this list need pruning by
> vpci_remove_device()? I've noticed this only because of looking at
> derefs of ->vpci in msix.c - I don't think I can easily see that all
> of those derefs are once again immune to a pdev losing its ->vpci.

I think you are correct, we are missing a
list_del(&pdev->vpci->msix->next) in vpci_remove_device().  We will
however have locking issues with this, as msix_find() doesn't take any
locks, neither do it's callers.  I guess this will be fixed as part of
the lager add vPCI locking series.  Will add another patch to the
series with the MSIX table removal.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 16:03:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 16:03:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429249.680156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzvL-0007zP-9T; Mon, 24 Oct 2022 16:03:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429249.680156; Mon, 24 Oct 2022 16:03:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzvL-0007zI-6N; Mon, 24 Oct 2022 16:03:35 +0000
Received: by outflank-mailman (input) for mailman id 429249;
 Mon, 24 Oct 2022 16:03:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omzvK-0007z6-0u
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 16:03:34 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140089.outbound.protection.outlook.com [40.107.14.89])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68a97912-53b5-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 18:03:32 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7972.eurprd04.prod.outlook.com (2603:10a6:20b:236::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 16:03:30 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 16:03:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68a97912-53b5-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T3pvuORjQphDk+SZGs9Wk4Jj9cydMT65VNxittxsJ4lNDQgts1Barh2f1knT3uALBlQLiYlzPaTdwEj5NijUXkykXaFZHl7B56EEGEiYSGUdsLExcX0hikRv1en8KMbzS8Erx+mxfwj9Wq4EBtMIwdYnIfAc3q6uBfcLPjEb8fnuk70JknQ8NsRR6eMt5bnuDEl3EUquDS9aNF59NcIvfZirsGhsLoFtxlvSCe4gviRp0jFcLSIXTxDolxacVqY1csNzgGLSWTnca/FKMqwuiEHZXrC+PyQNijI/nAeAv+UMTufYF3rTfrdz3+YwL8IdXsEDnX9uNanL9iIzVyUoXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bJiqYHYM3F2tuyHStKtr5L59tMOD3GIy2fs7vuXLenE=;
 b=UMFsWW9qFBUJfI74PeoJOZKbfQOQ4gVo4SH/OFmTsv+/7Qjkbwj3s7U7MQqHRt4EwDTMdyNCX/wuUXnMAyAgyLd7uiUzu1pUaeF+v/aYvpDRpPrE2k0S3OQ7dWYwzvfWz+PNCUdCHLaNDNOw/2oP6axJZAI+9kfcw1VVHvBGgpWPidW8FINl45GOJ/ZP2l3zVNhyBdlY/PwrIg1H3Utb3qs/RM2DH9KkexB7wJruP40B+jLn+EbFmVQnsrs+ZXFfGZtB/TjFeaWHdtH8aKBreJw+bKn0rvJg2rWNpmYtJUH432OJ0KCKeQzgwGbXoK6tylgNhWktMuOMjGggYf9Qxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bJiqYHYM3F2tuyHStKtr5L59tMOD3GIy2fs7vuXLenE=;
 b=M0tgES4JEq+OXSwEIvlO14cysn2SB/JoT/6mH/I8/kNp14tsTRQ4dk9j2QEsp6f2ZBMHSuJ36Vahss6wFYe8LVluamKAX2UuNJK3e3xvu8lyEfKlCJ5Fv/OVhP/P/A+89zv8pPUbsSv1/kKg6dFx+2E90NKhPepnSgByUlAiP/OY+DWny0ZCPMovIRzvdkVbn92CDJIFKPGlx50JFo/CmRjzxxPlnB1OfEsx22Jfx+ncnFLSRmkS8cTDifoIqmYcjnV9jdXJhwi7t0vG2SyIvyBoTXrqEwXUnrmld7NNnhSQ8nevXivDJXrPVvS86w3WzIFMuhLk2Yot/CDjrSYwhw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8755ff2f-f775-2ca1-5969-462ab05c6493@suse.com>
Date: Mon, 24 Oct 2022 18:03:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 6/6] vpci: refuse BAR writes only if the BAR is
 mapped
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-7-roger.pau@citrix.com>
 <cc94a021-aa76-87da-0d14-e01f09377b57@suse.com>
 <Y1apcHK6O7IDWlKF@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1apcHK6O7IDWlKF@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR04CA0179.eurprd04.prod.outlook.com
 (2603:10a6:20b:530::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7972:EE_
X-MS-Office365-Filtering-Correlation-Id: 363c2729-0f9f-416b-471e-08dab5d94b3a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ftMucM6KK0x2CJ4FlQvXSGQD7qTGXMNXRebSTosH89qyFPxq4gIVautGfHGK1erEZ0v3Qkrb7sNw5FoPpgr5rdcqKbAqM8/VSjU1pcqJUWqMMgQOu4PCLC7WRVxbCyOgIaMBoYekJMwlcTVFCCAKwKsYqEXgntPDrXqTBm4aKp+oAbn94otzOqjyOiILSQ88S3VhTe8pKAROQdANgurTrdq91U8rfDFd2CBnT2xv65GeqvDgTBiKgFHN7hB8ovWWmtWtnqRZQQsDWwhzMxpfzgDJcj5mAwvUK+jRGDpudhvT29tt3LGnvVZMqQl4P3LnE8KlrncuxMCbmWIo+8sVK4IUGfPjCJ9RsFCkF9dk1VWsDWKVoO29oPaK736JWlY7K0IFSksa0pOj5Q4KIOy7+dqwYHId6l8v0mRq/EmxCtvVURAeqKv1sGnAf6UaJZ+nUy8vsORRTXlNX/pH8PvURlaMIN8SH2GzdaGDg0KuhvLq+7MrnP81PEE4SjtaUkbKixWL2OklFO/65+DnfEknYJZg56LucTrJNHrTWHAmeLKIm4OHWV9dhebez/2+ZcUBkn3Y/qa1Vk/DYLiPEhfuRDv+eLoJyxGN5WXJjG1Z/XiL8xTXnAZNLnd3AifEw+CjHRsKRRczDL1CDmbY7ikac8GnRfe9wQgq78TQUncQJ7Ml00H8KgikKQnfuJMPXGbL5qhH8GnX5qdM4BAmjCvILwsJAoY39Xr8H8zxkhb2qvxNkFdF/6cTuNbY/jpU7MjrykxD7NMfpJs6aqTFfrdDru4gcKQaRPYLAVnvS5RxljA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(346002)(39860400002)(396003)(451199015)(31686004)(36756003)(86362001)(31696002)(2906002)(38100700002)(186003)(2616005)(83380400001)(6506007)(53546011)(66946007)(4326008)(6486002)(66556008)(6512007)(26005)(66476007)(316002)(6916009)(8676002)(5660300002)(8936002)(41300700001)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SU5JMjJDYlk2MVdvNE5KdmsyU1VYb0FZL01iTENsaVc0ZFRHQXFvTTloc1Ex?=
 =?utf-8?B?Q1ZrbkE4TnYvNGFTNnZYT285QlJxc2RLd3B3ZTA0b0tFRFQxR29uMkZOUUNk?=
 =?utf-8?B?cmZmOFJJM05rWlZKaDJFV0RjZ05Ceis3eVlsakRZdEJrLy9hcldZV1J1VGJn?=
 =?utf-8?B?NFMza0FjcmJJanE3ejR3dnF4NVcrSzc1MXB1U21JQUZSZmFYdDZtWHc2bWhU?=
 =?utf-8?B?NnB2ZDhZV1RBNGRFMUxNTzczdUxNS2FIUnF2cC9qSFlLQ2hBZzZxTXh1VGx2?=
 =?utf-8?B?UFNyd2RuWTdBSGtNbTNYc1UxUXl6YkJvSkVab2Zuajlrd0ZFQ0VSMytuNSt0?=
 =?utf-8?B?WVhWL3EzMzhTVzdXM1JTQ01vRU1uTGU4SG81NUdoR1BSVDRxY1luSWZSd1hn?=
 =?utf-8?B?L0NqM2xhS3hpQ1oyMHBsak5SQnJtN0t3akNxSVR2QlBXQzJwTExoa29rRGVN?=
 =?utf-8?B?WnhWMmJRTGlLQ1pERWlRbjNXek9oQXlpcllQbklqcDdIVWg4L2lWeHVGcERk?=
 =?utf-8?B?TGU1MitRRGVWNzQxWVZ2VzhHQTdaWUdxSDE0WEYyYU41aU9JNENNS2t3K1d5?=
 =?utf-8?B?ak9qWVh0bW1ETUJwWDhMY3plRXV0a0lqQU85a2FkUUVxMDl3VWJrY1NKZVFq?=
 =?utf-8?B?eVpaalQ2dkkvQk1wWk8xSnBVMGdVWFdwWDJTTXhqNGFTYzEvcTRmVWYvclN4?=
 =?utf-8?B?VFVmN04vVTI2WmdIVFR0ZGtPc3ZTeTJEdUpSd3FZUEpwenVlcGxkYlpyRm83?=
 =?utf-8?B?WlFsTGZYYzNDQUJIMy8vbWJEMEwxNHlkREdSWjhma2dLV3VrOWViSW9iU0p3?=
 =?utf-8?B?TmFVMGFnWE9rSmZ0RjdKZE5VUnhxU1lqUGRLbEZ1Q2huNkJCdG5ERWRzTlRh?=
 =?utf-8?B?Q3JaWkh0VzVFZFBvMFBGdjVYWDE1M3BycVRxYnJ1MEZXY1d2K2gxQnRuZVZx?=
 =?utf-8?B?cCt4YW9YQXdiQUU5a09QaWJBaGlZMFZJdWc0UkxmZ29wV210TDlCakdkczZF?=
 =?utf-8?B?VmtmSEt3ZDhUNEMvWGJOQUdmUGtpem5qeUFCck5CamJOamNqdGxaaXl0NTN5?=
 =?utf-8?B?N29BREo0NUd4cWJtbTN0clJ1aXRvV2gweTgwR3pkOVdMendYSHRybXBKUC8z?=
 =?utf-8?B?UkJEZXdFOGZZdFNjSUpoSmJpMm9KKzlTRGNkWTgycUlXOENqTE1YYjN5ZkhW?=
 =?utf-8?B?YlRlbXdZYzRZSmcwWTlnV0hBWWwzZkFiams4OEF5ZEdydzZiVndDeFJ4cTZl?=
 =?utf-8?B?Q3ZvM1VPK3dWRkYyK0hjMS9LZmlyVkRqVTN6UVBVL2loMGdyaUxxaWZ2YmtT?=
 =?utf-8?B?VVlZdDZuN3FiTFBxSU1rOU5RM01wWUF3WFRnMHZvNHBIZ01WT285TVBod0Zm?=
 =?utf-8?B?OFErZUNwSlFucDN6eHhNZjEzbFVnWXBMMmVuN0txbDBteXNJL3cxSHQrNldD?=
 =?utf-8?B?a1JZZmpDTGpIZi96U0RTK1QwdjJ2OXBpdDFmazV2V0tjSFhkM1MxQTdGRVc3?=
 =?utf-8?B?emYxd2RrQzVEM3hpT0wvdThoVlVIUWRCOFdTL09tQ1lEMjZqbVZsS3ZJN2xi?=
 =?utf-8?B?UEZ1Vlp5UHUvaFhGbHFhRVNBRitTTVpTbXg4NGFpa0ViNWcrQTY4RFBIUDM4?=
 =?utf-8?B?Q3dVaEFRT2Q2djlPbWpBMEtJM2wyU0J3VVJxTHlYMkxhZkdsdGdIRGI5bXJw?=
 =?utf-8?B?T3k1WUp0dC9qQzgyS3pOdG1WWkJyU29NTVEzRmJsZnJMQjIrZnc0Q203Yjcz?=
 =?utf-8?B?dGdOQ1l4ZGMwMmk1YWZ0T2wrVVZLUExQaDFzdXczeFN3bW5ZbzJEbmRwU2Zn?=
 =?utf-8?B?cnM1Sy9JdFhIb0dkYXd5RE1oRzlSdjhKeGpneUZDQjRYNFlJVWVPY0RoZVFk?=
 =?utf-8?B?aUh0VXpYT2RYK0xMSDV4d0NqcE0zakRTZElZa29hWWFyT3JlbHVOYy84OGxk?=
 =?utf-8?B?ZmdacjZ2TERLY3ZuUzNCc3Fnc1UydXcwREx2U1A5QlRTbmN5aVl2UjNVS2lp?=
 =?utf-8?B?R1BhZDJDUTBYd3BZVmFicnJXWWlWMzdXaVFOL3k5cmEwYXdkMHE1VHU0Szg3?=
 =?utf-8?B?SnZBbWx6akQ3RURLb1R0c2hqTCs1bUhUWnNDOW01R0taRG1MdlhWT2pQdWVq?=
 =?utf-8?Q?/nEjW6/qaPJFUP+K2O1W1gUKw?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 363c2729-0f9f-416b-471e-08dab5d94b3a
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:03:30.2237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GHqMKmX+roIth8nonrmNa+Z6RcJp39/5EaS7flKb8A5w3aeYtrTEN+88yniH5HRi4mcMfkaPlGROGEdntn0NPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7972

On 24.10.2022 17:04, Roger Pau Monné wrote:
> On Mon, Oct 24, 2022 at 01:51:03PM +0200, Jan Beulich wrote:
>> On 20.10.2022 11:46, Roger Pau Monne wrote:
>>> Writes to the BARs are ignored if memory decoding is enabled for the
>>> device, and the same happen with ROM BARs if the write is an attempt
>>> to change the position of the BAR without disabling it first.
>>>
>>> The reason of ignoring such writes is a limitation in Xen, as it would
>>> need to unmap the BAR, change the address, and remap the BAR at the
>>> new position, which the current logic doesn't support.
>>>
>>> Some devices however seem to have the memory decoding bit hardcoded to
>>> enabled, and attempts to disable it don't get reflected on the
>>> command register.
>>
>> This isn't compliant with the spec, is it? It looks to contradict both
>> "When a 0 is written to this register, the device is logically
>> disconnected from the PCI bus for all accesses except configuration
>> accesses" and "Devices typically power up with all 0's in this
>> register, but Section 6.6 explains some exceptions" (quoting from the
>> old 3.0 spec, which I have readily to hand). The referenced section
>> then says "Such devices are required to support the Command register
>> disabling function described in Section 6.2.2".
> 
> It's unclear to me whether setting the bit to 0 is plain ignored, or
> just fails to be reflected on the command register.
> 
>> How does any arbitrary OS go about sizing the BARs of such a device?
> 
> AFAICT from Linux behavior, an OS would just set to 0 the memory
> decoding command register bit and write the value, but there's no
> check afterwards that the returned value from a read of the register
> still has memory decoding disabled.   Xen does exactly the same:
> attempt to toggle the bit but don't check the value written.

Sure - both assume that the bit is writable in the first place. Yet
altering the BARs when the write had no effect is not really correct.

>>> --- a/xen/drivers/vpci/header.c
>>> +++ b/xen/drivers/vpci/header.c
>>> @@ -388,7 +388,7 @@ static void cf_check bar_write(
>>>      else
>>>          val &= PCI_BASE_ADDRESS_MEM_MASK;
>>>  
>>> -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
>>> +    if ( bar->enabled )
>>>      {
>>>          /* If the value written is the current one avoid printing a warning. */
>>>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>>> @@ -425,7 +425,7 @@ static void cf_check rom_write(
>>>      uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
>>>      bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
>>>  
>>> -    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
>>> +    if ( rom->enabled && new_enabled )
>>>      {
>>>          gprintk(XENLOG_WARNING,
>>>                  "%pp: ignored ROM BAR write with memory decoding enabled\n",
>>
>> The log message wording then wants adjustment, I guess?
> 
> Hm, I think the message is fine for the purposes here, vPCI is indeed
> ignoring a write with memory decoding enabled, or else rom->enabled
> would be false.
> 
> Or are you arguing that the message is already wrong in the current
> context and should instead be:
> 
> "ignored ROM BAR write with memory decoding and ROM enabled"

No, my point rather was that we're no longer checking for memory decoding
to be disabled. Aiui we still require that the guest has cleared its view
of the bit, so I guess the messages could still be viewed as applicable.
Personally I'd prefer disambiguation.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 16:07:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 16:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429254.680167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzye-0000Fl-Pd; Mon, 24 Oct 2022 16:07:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429254.680167; Mon, 24 Oct 2022 16:07:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1omzye-0000Fe-Mo; Mon, 24 Oct 2022 16:07:00 +0000
Received: by outflank-mailman (input) for mailman id 429254;
 Mon, 24 Oct 2022 16:06:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ny4u=2Z=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1omzyd-0000FY-Fz
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 16:06:59 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60041.outbound.protection.outlook.com [40.107.6.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e2ef8f1e-53b5-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 18:06:58 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7972.eurprd04.prod.outlook.com (2603:10a6:20b:236::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct
 2022 16:06:57 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Mon, 24 Oct 2022
 16:06:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2ef8f1e-53b5-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IPCvP761SPk0gUeX20qgGUyorRvQvLc43QTVXkO7bNt5HT7ZzSSuioSF3f26MW9/sh7JUetDCJjXMLtIDPSo5Okx5nSBLNNnvOhzV+iZ+0D/xrIVPyiytXiosd1qhiixb7hNb472jAAGnJemy4by/wCfkiP2IrRvJO4HgIl5WcQC+JTwU+v0eOr5MqSE8KwwHmX8L5TC4k38OsQpOs1+V8tq4ZUiCrLXh8oyswXVOxF+JoUPKpdd+DuYsjdpxtbM76L8VHND92k+YjBYj4SMNvLHASO5ORpV9P6QPlaZ+eWPbdtG5MO/FGXmh3Sl8FRepXtjSHW+Yn5zImTC0YAupQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ixLkR1K9Q55B9dQyLI2XMpKJenS/ngAxUQrrBiLHQss=;
 b=ltU+oNFbLfhV+aWobF/JFqJUgOBD7J1EIFjT5f6HN0lEM0Jx+diqGWbCR88yXSkw3dpn0gMnBc4JUUvbu2mHRyU59T0nFl1vRuEG/bbTkVFJUnnt10m7hyovHNl4H1g0Jg0xftcFMgpm/Z68e1lALz1JTlrVK8+ZqDWnbObpAbG0BZAXoUdchEFpVc2xFKmLfgOk3lgRgFSc1Qaq8DYziK14JCb/zplwfaezJyRPD81iHlocg8qJ1v7UvBbDL4JEGyRwtLOZdZtiIMZp69LHft5nx8TW53iJ3xPdQtfyzTJxyu50fBrknlDS5iyKvHGuHkS4UmWkOjLAiYya1IQb5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ixLkR1K9Q55B9dQyLI2XMpKJenS/ngAxUQrrBiLHQss=;
 b=de5v9rvn3afcrTr4oqG8SEumTYbDCHrjfU3sAs28krS90GdDz+gM3G+ZCY55vd0OTS5KMlFy+IBJlHsMQ2HVUw/jUFi0TM/E46iN4LBKtnQvWKG0M3vFsXLSjrA2mvUz6agL1g/0CumXWoWu9EnhjHapvIVcEV/DBpFiNSmHdplNpKum8jmbbaWTCF/RyTvQ1GXR7/QPoUutUso7L/+zaRNCJcETr4F7X4yJ9f8iJ9Y9UsTA/wPfDe3CNfs/1Og+n/wvYefnKhNIY3hVZ0i3aaCgbf+w6l1pQhAvrNbdJLp6tAqtRvFS5GqupdfRvUD5D2jYrlJHLckQ8jVqGg8q7g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <40a4b054-1f1c-e87c-c909-93f0bd4b7ee5@suse.com>
Date: Mon, 24 Oct 2022 18:06:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH for-4.17 3/6] vpci: don't assume that vpci per-device data
 exists unconditionally
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-4-roger.pau@citrix.com>
 <ff8559d8-12b6-9218-94bb-8c9a731250a2@suse.com>
 <Y1a24cSD9zVZFHn/@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1a24cSD9zVZFHn/@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS8PR07CA0001.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7972:EE_
X-MS-Office365-Filtering-Correlation-Id: 12c17b42-a27b-474e-55a8-08dab5d9c65e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0H5G2WgNwaXnLj5rPym+Q5pmwq9J/ES/4MnT3LsXW+n+TkeFFiQ+ryUNPjmsUo5b75Imck7s+PfOZ6fziKgZ+z8wY2vW23nMGqzX42cGfVw0bpxBy2ZmVrM7z+5jrMxmw0KCw94+i1yH8Ed1ZjzFda1rEPXLoPzkpGQ/PTKZBB2/wkMJcDz8CRw6DIHG06aZ+4aKjck0HvmMXWaSTO1pByF4bLgdq98amaAUcY/JBqQb/zSKuFVyWSIBO/MjlycfGSTeXmJfoYy3ltNzKS/mWuCMu1teRIswQ5MqLz9At3kKw3DSS8uGZ6vTF+xhMR2YnyvxfXWakla2fTgvmkrr2BL6Gn200oreOmhu+QEXFA3cu+6a7OsGoOfBjwsqDGR3VGEbq+zh9hrS5zoFufUqBm880AokS31Qrx2yNNV8YCJtSPaS7rLadsUMsgRM+1eADGLy+r34W4/hd4weRfN//jw98lZiQJjUR6OruSdYvGD1QNKvWZX9DSCvxLttRae2t63h8XqQqKCEf0Qw0HCQSPmVX0HHNaHNEzvPLgLWa7Zg54f++VuxE3bMaLreKvQDac3MX2OY84w2g2Uxb+nyVWnZ7gwI47uKVl4ApzZrPd7VtUDAmZGPXRsNOcptJlL6VIBAU8adIbal9s0h1gl/hEYMSODhXf4RmtqrgfDqmn5WZYcOAF/ESKLjI5ppnWi9jGw93jNEo0ewObz4sVszeQ8JelHP7dLDGklZObq9/dj0zemPmnHBuPgwDEekcWnR08yMkzLZ2OLrLQTcKd7GGQeEDw8UuTOHUMQmZfckuzk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(346002)(39860400002)(396003)(451199015)(31686004)(36756003)(86362001)(31696002)(2906002)(38100700002)(186003)(2616005)(83380400001)(6506007)(53546011)(66946007)(4326008)(6486002)(66556008)(6512007)(26005)(66476007)(316002)(6916009)(8676002)(5660300002)(4744005)(8936002)(41300700001)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0RDa1RrL1RodkNnK04vMjFjNVU5WTU2WTN4a0kxeTJtR1JudGx5VHljU3BD?=
 =?utf-8?B?bFVTNG9EeVM2Yy9CclhvTkx5MzlLR0lPaGM2ZVY2ZnVpMENVSmhBanV5YXMw?=
 =?utf-8?B?QVg3YjFHTjdkenV0M3JVZVpoNVQxSTVIWXpCb3JuNTRlbHpISXlaVjBoN1FY?=
 =?utf-8?B?MjQvdVpLOHpIQ2h6WDZ2Y29wcTBBNnRDd04rWERPYk5EMFZwWXhKcndEc1pR?=
 =?utf-8?B?RTVOcHJvZFhBbkt5bUJGcnJFaGpPWFdJZEl0Y1BSUGNjaFUweGQ1TVFKMitI?=
 =?utf-8?B?cVp4OGkwQjVIY0JoRWYwVDVwSDYyN2VCUExHVTRWVElma1hsejJrUUV2THRm?=
 =?utf-8?B?WFBmTHRsc2JsTkxaTDJTUXY5UHFsanNicHkxUlRQUWJjU0t6KzN2R0phZWhS?=
 =?utf-8?B?dGxJYWN0VXBpTThTUmQvK0dNeE5hQTJCMmFSRjRkenFtTlVFQWx2WWFKbnQv?=
 =?utf-8?B?dVZFSTRKWlhIMERZK1RYMWV4VE9kVmNHYTQxTnBhQ3AxN2tRMnF6eWRaQ3VW?=
 =?utf-8?B?Y2dObXlPMkc4a0dwbkt5V1V3Y2ZWM3MrK3JxZXU1TmpMUzRjUm01bG9uMzBC?=
 =?utf-8?B?SVpvbFRGM1NFWjBPbE5HOG5BOWZLek9QT01FSFFUZnREcW0vTDg5SktnaDJK?=
 =?utf-8?B?VisyOUhmTloxSnFkSVN6U3NkRHJuNXdQbmtpWXhadjV3WXJBaExIL2ttdm9K?=
 =?utf-8?B?Y3VqcDltYUpiRWlhSERZT2RKR0xvbHNobVBJMlRwYmFkRXJzVVJVU2s3Z1c0?=
 =?utf-8?B?M1h3UFN1b3pEa3lWRFJyQUNIUjhZa3pFTTB4SkVUYnFKS3pIVzBDUzFzT3hi?=
 =?utf-8?B?UTgxSTdIS0tpVmtmWDNqVGZYMmFnSnpkZHcwRE95U1ZGenhhcWRteXh5eFk2?=
 =?utf-8?B?OGcwU284ZE5KMWcvUDIrcjU3RnhweVhVdE53QlZXMUZheTZ4MG9jcUM3eDg1?=
 =?utf-8?B?UEM3QXJHbVMwK0cvckdrMjZ5L0picmpwS2NLTlc5SjJpekc2dGhlMVFadks5?=
 =?utf-8?B?RmxTSm1yM2lVVVFWM0dTaUgzamlGWE5TcUpBRXlBUFRRQmxPd09qZTVVVFli?=
 =?utf-8?B?YW9CMFYvbVJadkt3OVpQVlNHMU82am5hNVRPVkh5Ykk0dCt3V2lBWEpsT05t?=
 =?utf-8?B?SXp1ZUJNbTUzL05LK2tEdkxDMS9COThDVnA5bmdLTXRvVlVqaUhab2FOQjhq?=
 =?utf-8?B?bmlJZmEwckhVc0xUb0RuSjIvYzRWQ2JySUpnVUdLT2hGcmFESjROSWhtZ2dy?=
 =?utf-8?B?WWEvWW9IaGU0MmYxU2VlYW9Vd1JSZzhzS3FHdDdVVE5TeUZJQm9IMWk0d3Y5?=
 =?utf-8?B?ZjBrZTdHcjFKeE5CbURLanA5cHBYemRHcDFPOUEzeUg0NCtDaVBGQ0lMc3h4?=
 =?utf-8?B?b0ZxK0lPbkk0ZTdXK1k2TG1JdUJIS3hQWW9Md1dMOFZrR2hOMmlaZzY2cXlL?=
 =?utf-8?B?QnlSdDZQczdOOGNMSmlZOG9RakZlcCtUM2xVMnhXeUJpemZFZXNZa0UyeWxW?=
 =?utf-8?B?azVIOEQ5SVJZKytlYXR6N2o0anIrOUtyMFdDV3RDMlRwTDJuUXQ4dmNuZ1hX?=
 =?utf-8?B?QXozNDllMFBKN1BCWHR2MStWMWhBMXhzNjFVUm9Ub0dIVXN5S2oxMWUvWjQv?=
 =?utf-8?B?UmxXMjJicHpPL2hwT21UTU03a1pEWDV4TlBDT0hFeHMrV2pudnBFTnVYa2ha?=
 =?utf-8?B?VDMwSytDR0ZMcUMreHowVFUyU0Y0T0U3KzF1OTZyQnRnN3lLcDFhYVpOa20x?=
 =?utf-8?B?MHU2ZWlETjRKR2dra2trN2hDaGQxZUkrcFpyRTd2SDlIeS9SYm1PWnRKcy9P?=
 =?utf-8?B?M3owUW0zOFYzUnhoYzJ3YzdjdDF5djA1TWdkcEhKSU5pcjA4cVJ2MXFiZEpT?=
 =?utf-8?B?d2ZYTEdaTHdJUjl4eHlMaHJwRTBWVU5GMzFaUDZENjBQWGJycUFnbTVWbDdE?=
 =?utf-8?B?TzNDcThtbUJBVWFUanlDck83bWk3YTZucm4xck1rYnhMSVBtdGpSNVFJa2lV?=
 =?utf-8?B?cW96QVFzQ2laZ1lVaHJMNWZiYzI3bXdSZ2N3ZjR5ZHFlZHA4cXhzK1FUcUtK?=
 =?utf-8?B?WDRYbEdpYVNVaWVVQ3MrWGNpMlBFd3JqR1UwVlZKWmE0NmpPalBxRVcxSm92?=
 =?utf-8?Q?OCuFfk6fWw9b7NK9V6IpvichE?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12c17b42-a27b-474e-55a8-08dab5d9c65e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:06:56.8510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pcDHG5rZsocYWndhdueBRCrFojaHpmW1y2qHmGceS7FwM20v3QLBrCr6TeFlN+4eywgfbQT+UDtguBkCXALLLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7972

On 24.10.2022 18:01, Roger Pau Monné wrote:
> On Mon, Oct 24, 2022 at 01:04:01PM +0200, Jan Beulich wrote:
>> Furthermore msix_find() iterates over d->arch.hvm.msix_tables, which
>> looks to only ever be added to. Doesn't this list need pruning by
>> vpci_remove_device()? I've noticed this only because of looking at
>> derefs of ->vpci in msix.c - I don't think I can easily see that all
>> of those derefs are once again immune to a pdev losing its ->vpci.
> 
> I think you are correct, we are missing a
> list_del(&pdev->vpci->msix->next) in vpci_remove_device().  We will
> however have locking issues with this, as msix_find() doesn't take any
> locks, neither do it's callers.  I guess this will be fixed as part of
> the lager add vPCI locking series.  Will add another patch to the
> series with the MSIX table removal.

But the locking issue the isn't new then: List insertion can also disturb
msix_find(), can't it?

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 16:24:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 16:24:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429261.680178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on0Fc-0002jV-Cj; Mon, 24 Oct 2022 16:24:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429261.680178; Mon, 24 Oct 2022 16:24:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on0Fc-0002jO-9m; Mon, 24 Oct 2022 16:24:32 +0000
Received: by outflank-mailman (input) for mailman id 429261;
 Mon, 24 Oct 2022 16:24:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kmwR=2Z=citrix.com=prvs=289ef416b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1on0Fa-0002jI-VP
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 16:24:31 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 543aa7f6-53b8-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 18:24:28 +0200 (CEST)
Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 12:24:26 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6358.namprd03.prod.outlook.com (2603:10b6:a03:390::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Mon, 24 Oct
 2022 16:24:23 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022
 16:24:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 543aa7f6-53b8-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666628669;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=l5fo4k8VEPzwarmaqxdMubm97VniYkAyd3tFpyG7L+I=;
  b=NoW2MZbBetZFsM8l+GZaA5q2etTHZyTL9e9tJeqGxP9DIpyHxAj+VCHH
   Suup+AupCI3O8r0e0T/dGQlqGwRgGmt7B2l0K8+g/LrX95cEHFRsq9IZ7
   MoH2ipSpTOMx9JbPs25uslQVKRZn+gkJWyTTISalwIJUBg6abhDhF0eu3
   s=;
X-IronPort-RemoteIP: 104.47.66.47
X-IronPort-MID: 83814002
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ZshDnqlOvQp3IuO4/EjzrWLo5gybJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIWXGHVb/6CYWX1Kop+aYm+pxxUupSGndMwSFBr/y81QyMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkOagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAWdxr
 NhbDTc0ZAGPiNqz+ZiWUfJ+r5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6Pk2Sd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL31raTxXuhMG4UPKTg2qNGkV6O/WhQJU0dclLlo/mfkHfrDrqzL
 GRRoELCt5Ma9kamU938VB2Qu2Ofs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k
 FiTkLvBHTVytJWFRHTb8a2bxQ5eIgAQJG4GICobFw0M5oC5pJlp1k6QCNF+DKSyk9v5Xynqx
 CyHpzQ/gLNVitMX06K8/hbMhDfESoX1czPZLz7/BgqNhj6Vrqb/D2B0wTA3Ncp9Ebs=
IronPort-HdrOrdr: A9a23:jyxq/KBhS4g3ozPlHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN
 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d
 enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr18jegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvS/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kda11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa
 dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvjklLYIk7zU9HakGOul5Dt
 T/Q9pVfY51P74rhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc=
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="83814002"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bEDCm000oDcd8jeBJUXuhJZg15pweHbaneceIMqAqgA0zl7lxAubxiqbFXcDZv+ac7aEWFu3mERa12dpuPerwHo3qSDwCE5Xcxz7woqr0u0vaTn03sImSa9jKjozDZlmSrLotHKOA4f8YYJBcxm+iFVgC8QILhqzwt/798o7jqtA03UUBdNej7pJHaoZRuktoHSGkYNsDImo2I1XA8ktsM1gVFtnr+5ughD+jpzxjTVYDEleMFNcnB16D0p82ZEvcYDZnTTt5WcZUwnQMJ/HOcYJtT+zMrANnBfm05eskuMoDravBKMcoIo3ABXM5I5nzwma+hVLqYMo3/yDgWh0+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZigO/gQjqVWEg8aaqoQcxIujc0MZwkn33D5jwnxXdxY=;
 b=aXNK6XDUx5es8UYhEcb8WGtJ3mJPAObX/nrWtmRT6twDwPh8/qNmaoNPEl6EcuZRCABALJ/RGHcvIJZElRWIb0qlIXm1LfITgDBX+RbCPTEl+/vRFfBAEIz/zEPYVbRGuRXl0Kbxu4q1yl1hr+bo2mPWnySvegtoKnwYjDICfwykrNeZFHeGPiaavyrUEVbgXCoyMkZ8n6Q4qiNAkjhCFwHxLOl60x3gzws0qpDkD6oRWLTyh5HRtz1pBBrD2X6vfGxIdeMhkRYwOmaILwflnCG7weT8+XmpBpZQTWumJ12YYgcQMwnnnE6r3MQbr+mj29INnwEo941d2ODVyHoYRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZigO/gQjqVWEg8aaqoQcxIujc0MZwkn33D5jwnxXdxY=;
 b=WP9HWTu/3TwaeWsgmjDKF+KgA91V6Ao2MlS52mr/B2y99X27L2OLYS0dQr7QamG7RtA4GE8cf4WJoLr+O+z9tzjCxxvagOekQax/0zRh0hJEXl/hCC6h8DcMbiJx4TiF0r/xKxIaHkKOkzqvbsdAUnWL/h5sTgrFeR1eiBYsrmQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Mon, 24 Oct 2022 18:24:15 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH for-4.17 5/6] pci: do not disable memory decoding for
 devices
Message-ID: <Y1a8L3CEOgfKScqj@Air-de-Roger>
References: <20221020094649.28667-1-roger.pau@citrix.com>
 <20221020094649.28667-6-roger.pau@citrix.com>
 <4c960f12-6561-d8e9-c1bf-8da18243ca6b@suse.com>
 <Y1aI5Lbi3sysIZVv@Air-de-Roger>
 <730158ce-d168-5dbf-38cc-78cdedcfe33e@suse.com>
 <Y1ay/zIPSpODqsNY@Air-de-Roger>
 <82a69c5c-3174-cee0-932b-3141df6454a2@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <82a69c5c-3174-cee0-932b-3141df6454a2@suse.com>
X-ClientProxiedBy: LO4P123CA0445.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6358:EE_
X-MS-Office365-Filtering-Correlation-Id: c9b73d12-b863-492d-67d4-08dab5dc3513
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e38EptzmDpgSwr7JmGGN5nj3NhSF/ubG2hBekvHPrLJCt0ldugHgwg6eDf/Vaom5EbHGdnnoRE4nku+Ria1WZqxYXtXxiFI2+SO2G4FGpyfoTd+gcnh4xdaGEDRhgwj5OjpkDOtngGaXo8ZPQXnfX0duK1Fw6fivhN/ly3pXlE+Ls8gwHolp6k8lLNZERVauvzu2Bqms8mHkI1WKhkDZuDg/e0CnLAA8U6Ui4DbcnN8gXqTxFOkCdpSkR3l6ygGts8cQkRMIIfaFr6nubCfDKnl20CDqi16p7grVargzg4XXDKtAkXp2R0iP2r5k0clUohnYVSbsKG+Dxx6rEVcDUTQ9JjUXp3Pd4pvT2oGIPsIzM8sGjSnqhKI2n1kMjRPzDlyvhwi8AvdwDLPq2wbMJPQ5P34OwhsQix3wg544jPcTMn9/p7nkdcJV5E8ZEXIaq2EE1bEwspJ/7nWKDL8+T41KMYsWHW8jeaqUU8NVBZ7wvU6BDRDQvOPN56MiQWwVNxQIaoj6j9Q68sfYrRRkGD8SBD01Ikg4MbpxwE2tDXqgCcKK7hD8kNWdvcRKD9aH0endQ9sPUyfIueRWMRcxmjFLTc9xWtL2xi5r2JQ8AXeTlcRz1K8icqB70WQtMa4dw9QA3VEwdLyMnMxhM3emj9aKx8GaHF0m5CKqEfNknAOqWaDgcRoN8E+41hRFVRgFQmlPZrbpsGTj/qTJTb7WkA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(85182001)(66899015)(38100700002)(82960400001)(5660300002)(66476007)(66556008)(66946007)(8936002)(83380400001)(86362001)(6916009)(9686003)(26005)(6512007)(186003)(316002)(6486002)(478600001)(2906002)(33716001)(6666004)(53546011)(8676002)(41300700001)(4326008)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEpRVWw5THBPSXVMWUVwYzFVeklPbkRTTXVRcUduT2hoMkJFaG9CQlBXUUNC?=
 =?utf-8?B?KzdsbXA5RDF6YVlzQjBaU0tGMWtGOUZkTGRxT2gwQW13eEM1bHR0eVVMNmNq?=
 =?utf-8?B?QkhJQkcyWTJ6V3pVM0tXNHJ3NkVydlNqVVgzUDQ3L09PQjNXUDZydHhMb1JQ?=
 =?utf-8?B?aWJrNGpJU2F4ZnByd2J0NFFVeDhSQXMzbXRhNjMySCtaMUo2UUxZcTNzR0tt?=
 =?utf-8?B?TjllT0JCQkh3VUFHY1BHNldIc0NmYWxCR1lGeTk3cmY3elR3dHNwWmU3QTA5?=
 =?utf-8?B?cjMzbTZ4cXZRejU4OXNUWm5QRW05QThUL0puZHRmSDBMUlNoY0xsRzBKOVBJ?=
 =?utf-8?B?SFkraElndldZUzFPOHI2bVhHU0FvY2RIQWl0K2xjZS9FNFBWcitmMkRIeUtm?=
 =?utf-8?B?Ym8wc0x5WlpFU0NIVjVqTWxVSjN2UkdxdVhKY2Yrb0RoU3NPWTVMM21ySk9h?=
 =?utf-8?B?ZFpwNXBlSEN3RUZQY01WRmdHMUhaSmpzaGMxU2ZIY09GczFoOEFZVEhiMTJq?=
 =?utf-8?B?Y3QyL0g2eWlSQ014LzNvNHJIT1BkR0s1QmVFMGZCSmlpaldRdVU4cHJOZjNp?=
 =?utf-8?B?Qm9IYkM4MnlkRUhweFlrVU5OZlBKaVF0RGprWlJGbmxWY090aUdVbWl1WGRU?=
 =?utf-8?B?blNFU0lNTFNUWG1Ec2hiMXpMM01odDZRZjJ4VjhBdTVXQmQvaEN4Y2loYmFE?=
 =?utf-8?B?Sjl4R1dWUVNmQlhkWFEvbU1OSkdiSVZuRnliMk9qR2lYbS96SjlYQ3J2OFVm?=
 =?utf-8?B?ajdud0xCMjBtdi9yMFVMSTNORGptMmxEQmlLRm96SWdReGNKVnZaQXUyKzN3?=
 =?utf-8?B?bkIxVHNqcXJNd1h6dzlYUFJTdWNyYWdwZU5RN3FkQjdaenJkRTg2ZUYyWFJW?=
 =?utf-8?B?dUo5OGZQUTB1WVpLTmFyVE8vb2l3R2VtRTQwR21LUmVKdGlYTVFhMHZZK2R2?=
 =?utf-8?B?RVB4NXU2Z3NYcU1IdW44Q0pTRUZTQnkrNzhaMXNSdWptRFlxdm1Ia3ppZlpk?=
 =?utf-8?B?L21wRzF5djhsVGZETzlHVEhrUmtuYVBSQjZEcHFLT2tkSTFoUzlGejYrZFBx?=
 =?utf-8?B?SXdib3dwa1BCaVhhbldKd3FDR1M5WUt6VTA5Y2lkcnFGdXdsM1RpK3ZOZ3d0?=
 =?utf-8?B?UVAzOEhUQ2hQdlpSV0NrQU9BaG9lZWVUMlc1WFMxVWtWQzZzQ2ZFV05wdWl1?=
 =?utf-8?B?RjBCY24yMm5YaThoV3dxd2tTaU5VUDNvS0Q2eTdCTDh2ejRsVzh5c2Zpd1pQ?=
 =?utf-8?B?RXFkbFIwcHB4V0sxTlExcFNGZjRUUitmWHdOKy9iMWJwekVvOTM0V3pnTmtl?=
 =?utf-8?B?WG9MUUdBWi9QeWRDMUNudTZwYzY2Wmt2R3h5ZmR2MFExWFdVZGh0djhqZUhR?=
 =?utf-8?B?WVhsc2tMcEgwUkkwaWxZbWEyNEx0bjdSWHRIcjBlcTRxMlJPM1FSdENEN1ZK?=
 =?utf-8?B?M2VwOUJab1hBUU4vZENwK2ZMMW9VVzhHTURzZXRXSzkvYWZudnBQbmMvWlhk?=
 =?utf-8?B?NzhBR0VPUVJsMFFYS3dNTnI3QTkxVlpGVWNiMWNXeHZhcDFTU2pmSENiU3BN?=
 =?utf-8?B?VzkvMnVTeTJ2Y3E1bGQxaUY0aXFKSlZmOFRVOSt1dmlKaFYxQ1BMTDhFVW95?=
 =?utf-8?B?OXVrS0pNQVJKc2pNYmhxQmxkS01RSUN4cG5lTWw2Qzgyc1hLYzR1ZWlXL3Vi?=
 =?utf-8?B?RnpRM2Uxc1E5ZU5DRVNzUlZldkdDVENZVHYwR1FLUnllcStWeSsrYUVhSkJ1?=
 =?utf-8?B?TlArODlqRDloT2RxUkdPckUxTW44b0hKQUlwd0d4QjE5R0ZlY3g4M2VDVjRM?=
 =?utf-8?B?TnZOaGJnVC96bkl2ZmZtaFhJVXd0TStzdW9zWko0clI1ZUhibUNIMlM4RFVh?=
 =?utf-8?B?NG4xY0VYdVlNRzJxOGljcFJOOCtGTzR1Zy8zMzJSOEVZUDBXQ2FZSnJ4M1Qx?=
 =?utf-8?B?c1NRZ2Vjb3UxclZ6QTVaWDBHNTBQUXEyM0pudWRNL0l3TFZuY1dtby8waVNY?=
 =?utf-8?B?d2RuT3I4WFMvem1zZDlPWU1KN3M2dmt5NklHcmg4eWRnczJ2SVcycUFQSGRW?=
 =?utf-8?B?YjhkbHdqUy9oNEp1cEplbThNZlhXaVJoNEZZWHJKaUNmTEFyeUM1RDRtcXpH?=
 =?utf-8?B?Qk16ZDNRcC9hcEZmWnVaUDl4WlNIMm9WNElSZE9vN2toU2gxRUVKK1JvSmNp?=
 =?utf-8?B?TkE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9b73d12-b863-492d-67d4-08dab5dc3513
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:24:22.5973
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VlHg3uD2qh31F6mCddAjPxVRcdRXmPt3pbcFwqtKtVqTIDclCjAodw5v8TsFZ/GvHpPdN9jKs6kqbdcR3P8y5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6358

On Mon, Oct 24, 2022 at 05:56:25PM +0200, Jan Beulich wrote:
> On 24.10.2022 17:45, Roger Pau Monné wrote:
> > On Mon, Oct 24, 2022 at 03:59:18PM +0200, Jan Beulich wrote:
> >> On 24.10.2022 14:45, Roger Pau Monné wrote:
> >>> On Mon, Oct 24, 2022 at 01:19:22PM +0200, Jan Beulich wrote:
> >>>> On 20.10.2022 11:46, Roger Pau Monne wrote:
> >>>>> Commit 75cc460a1b added checks to ensure the position of the BARs from
> >>>>> PCI devices don't overlap with regions defined on the memory map.
> >>>>> When there's a collision memory decoding is left disabled for the
> >>>>> device, assuming that dom0 will reposition the BAR if necessary and
> >>>>> enable memory decoding.
> >>>>>
> >>>>> While this would be the case for devices being used by dom0, devices
> >>>>> being used by the firmware itself that have no driver would usually be
> >>>>> left with memory decoding disabled by dom0 if that's the state dom0
> >>>>> found them in, and thus firmware trying to make use of them will not
> >>>>> function correctly.
> >>>>>
> >>>>> The initial intent of 75cc460a1b was to prevent vPCI from creating
> >>>>> MMIO mappings on the dom0 p2m over regions that would otherwise
> >>>>> already have mappings established.  It's my view now that we likely
> >>>>> went too far with 75cc460a1b, and Xen disabling memory decoding of
> >>>>> devices (as buggy as they might be) is harmful, and reduces the set of
> >>>>> hardware on which Xen works.
> >>>>>
> >>>>> This commits reverts most of 75cc460a1b, and instead adds checks to
> >>>>> vPCI in order to prevent misplaced BARs from being added to the
> >>>>> hardware domain p2m.
> >>>>
> >>>> Which makes me wonder: How do things work then? Dom0 then still can't
> >>>> access the BAR address range, can it?
> >>>
> >>> It does allow access on some situations where the previous arrangement
> >>> didn't work because it wholesale disabled memory decoding for the
> >>> device.
> >>>
> >>> So if it's only one BAR that's misplaced the rest will still get added
> >>> to the dom0 p2m and be accessible, because memory decoding won't be
> >>> turned off for the device.
> >>
> >> Right - without a per-BAR disable there can only be all or nothing. In
> >> the end if things work with this adjustment, the problem BAR cannot
> >> really be in use aiui. I wonder what you would propose we do if on
> >> another system such a BAR is actually in use.
> > 
> > dom0 would have to change the position of the BAR to a suitable place
> > and then use it.  Linux dom0 does already reposition bogus BARs of
> > devices.
> 
> Yet that still can't realistically work if the firmware expects the
> BAR at the address recorded in the EFI memory map entry.

I was thinking about the BAR at address 0, rather than the BAR in the
EfiMemoryMappedIO region.

dom0 OS would need to avoid moving it, but that would also apply when
running natively on the platform.  The behavior when running as a dom0
won't change vs the native behavior, which is what we should aim for.

> >>>>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> >>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>>>> ---
> >>>>> AT Citrix we have a system with a device with the following BARs:
> >>>>>
> >>>>> BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
> >>>>> BAR [0, 0x1fff] -> not positioned, outside host bridge window
> >>>>>
> >>>>> And memory decoding enabled by the firmware.  With the current code
> >>>>> (or any of the previous fix proposals), Xen would still disable memory
> >>>>> decoding for the device, and the system will freeze when attempting to
> >>>>> set EFI vars.
> >>>>
> >>>> Isn't the latter (BAR at address 0) yet another problem?
> >>>
> >>> It's a BAR that hasn't been positioned by the firmware AFAICT.  Which
> >>> is a bug in the firmware but shouldn't prevent Xen from booting.
> >>>
> >>> In the above system address 0 is outside of the PCI host bridge
> >>> window, so even if we mapped the BAR and memory decoding for the
> >>> device was enabled accessing such BAR wouldn't work.
> >>
> >> It's mere luck I would say that in this case the BAR is outside the
> >> bridge's window. What if this was a device integrated in the root
> >> complex?
> > 
> > I would expect dom0 to reposition the BAR, but doesn't a root complex
> > also have a set of windows in decodes accesses from (as listed in ACPI
> > _CRS method for the device), and hence still need BARs to be
> > positioned at certain ranges in order to be accessible?
> 
> Possibly; I guess I haven't learned enough of how this works at the
> root complex. Yet still an unassigned BAR might end up overlapping a
> valid window.

Right, but if the BAR overlaps a valid window it could be seen as
correctly positioned, and in any case that would be for dom0 to deal
with.

What we care about is BARs no overlapping regions on the memory map,
so that we can setup a valid p2m for dom0.

> >>>> I have to admit
> >>>> that I'm uncertain in how far it is a good idea to try to make Xen look
> >>>> to work on such a system ...
> >>>
> >>> PV dom0 works on a system like the above prior to c/s 75cc460a1b, so I
> >>> would consider 75cc460a1b to be a regression for PV dom0 setups.
> >>
> >> Agreed, in a way it is a regression. In another way it is deliberate
> >> behavior to not accept bogus configurations. The difficulty is to
> >> find a reasonable balance between allowing Xen to work in such cases
> >> and guarding Xen from suffering follow-on issues resulting from such
> >> misconfiguration. After all if this system later was impacted by the
> >> bad BAR(s), connecting the misbehavior to the root cause might end
> >> up quite a bit more difficult.
> > 
> > IMO we should strive to boot (almost?) everywhere Linux (or your
> > chosen dom0 OS) also boots, since that's what users expect.
> > 
> > I would assume if the system was impacted by the bad BARs, it would
> > also affect the dom0 OS when booting natively on such platform.
> > 
> > What we do right now with memory decoding already leads to a very
> > difficult to diagnose issue, as on the above example calling an UEFI
> > runtime method completely freezes the box (no debug keys, no watchdog
> > worked).
> > 
> > So I think leaving the system PCI devices as-is and letting dom0 deal
> > with the conflicts is likely a better option than playing with the
> > memory decoding bits.
> 
> Maybe. None of the workarounds really feel very good.

Hence this last suggestion which limits the workarounds to PVH dom0
only, thus limiting the interaction of Xen with PCI devices as much as
possible.  I think it's an appropriate compromise between being able
to boot as PVH dom0 and not playing with the PCI device memory
decoding bits.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 16:59:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 16:59:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429273.680189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on0mz-0006Mn-0z; Mon, 24 Oct 2022 16:59:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429273.680189; Mon, 24 Oct 2022 16:59:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on0my-0006Mg-UQ; Mon, 24 Oct 2022 16:59:00 +0000
Received: by outflank-mailman (input) for mailman id 429273;
 Mon, 24 Oct 2022 16:58:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RDLv=2Z=bombadil.srs.infradead.org=BATV+126e47513ec1fd56a858+7001+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1on0mv-0006Ma-NV
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 16:58:59 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:3::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 23d5550b-53bd-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 18:58:55 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1on0me-002PNe-1e; Mon, 24 Oct 2022 16:58:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23d5550b-53bd-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=sD1/9KUepwxnnbZHmOxcQ0nb2LDnGCi+U3tMVxTFuSE=; b=ShSp2+NTgj4NbO//OTI9ybjHre
	/+4idaGTfOP2cZZepFuVzG6VTj106A725AmvchWCyGPhWW0ULuEu9DESP6S6HnDAZcwb/1eiFs/Ci
	j5KU9irR0d90+K8+3LNua77wdl1V/SNAlKyMa/t7P4h2siKyDhWQ6pyEHXHIrybXYLUutHjNs+QHK
	nhFt5+e0jO/84nYFbMU3YyCT27pYCUZFLRZuUQcj1KLM9OcabmPUK6f8sQY93XZBo642wxbKfXltd
	aw1qFRMAKxER3crTMWbM10pDCoXSJKAtbHaxOXAIv1nUG8KRZtBNUY3iMbLLUKak3RZjS0oBe4a1r
	AWDX7Z2g==;
Date: Mon, 24 Oct 2022 09:58:40 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Juergen Gross <jgross@suse.com>
Cc: jejb@linux.ibm.com, Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Salvatore Bonaccorso <carnil@debian.org>,
	sathya.prakash@broadcom.com, suganath-prabu.subramani@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	adi@kriegisch.at
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Message-ID: <Y1bEQMS5SNTbZO/3@infradead.org>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
 <30a056c8-071f-4259-3253-75e718af619d@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <30a056c8-071f-4259-3253-75e718af619d@suse.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Mon, Oct 24, 2022 at 03:20:43PM +0200, Juergen Gross wrote:
> Dom0 is (normally) a PV domain, so the physical memory can be still above
> 4 GB even with dom0_mem set to 4GB.

Which means that we need to ensure the DMA ops for Xen-PV (which is
always xen-swiotlb I think?) need to return DMA_BIT_MASK(64) or whatever
is the highest possible address.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 16:59:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 16:59:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429274.680200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on0nS-0006mQ-98; Mon, 24 Oct 2022 16:59:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429274.680200; Mon, 24 Oct 2022 16:59:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on0nS-0006mJ-6D; Mon, 24 Oct 2022 16:59:30 +0000
Received: by outflank-mailman (input) for mailman id 429274;
 Mon, 24 Oct 2022 16:59:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GI/c=2Z=intel.com=tamas.lengyel@srs-se1.protection.inumbo.net>)
 id 1on0nR-0006Ma-2b
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 16:59:29 +0000
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 35afac73-53bd-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 18:59:25 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Oct 2022 09:59:10 -0700
Received: from mprakash-mobl.amr.corp.intel.com (HELO ubuntu.localdomain)
 ([10.212.103.22])
 by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Oct 2022 09:59:08 -0700
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35afac73-53bd-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1666630765; x=1698166765;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=cIgjQoZ7vxuC/i2lSZmYDXohIiSi9UuPb1px2tV3KLg=;
  b=Jjnj74sm6jYTpmD/YCNVoV3AuEC2YIxB0Vv375j/iANnimMOMQu90Q0M
   iqLQ6BiVrD3hGwHoQ3TqIsCBK++nRctn33uNQ86EUGzyMK2Fva0+k8DSe
   tdYWi1zEm/Ns629cuNa27Skc2Ux8FWTj9gX/FJAWbpZH+PukbS3XWL6wU
   8Cr7yOt3ejODgPamf6VUh1X7n8Ejf+q+oDMWgszpnzN8wCC6W37Ifyfjj
   EpPd7Z80apOeGHfMAZtE4j0Z78HvEHgUWd8ON1VOpIAxF+iDHpKfPm4YR
   H8fWQXDTTJ6EGLtJBYs7gclmQReeFzzTNFCILrR7jmWcbDL1JqOJ/5Z1P
   Q==;
X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="309160171"
X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; 
   d="scan'208";a="309160171"
X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="736483876"
X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; 
   d="scan'208";a="736483876"
From: Tamas K Lengyel <tamas.lengyel@intel.com>
To: xen-devel@lists.xenproject.org
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Date: Mon, 24 Oct 2022 12:58:54 -0400
Message-Id: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a handful
of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by an
external privileged tool is necessary, thus we extend the domctl to allow for
querying for any guest MSRs. To remain compatible with the existing setup if
no specific MSR is requested via the domctl the default list is returned.

Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
 tools/include/xenctrl.h              |  4 +++
 tools/libs/ctrl/xc_domain.c          | 35 ++++++++++++++++++++++++++
 tools/libs/guest/xg_sr_save_x86_pv.c |  2 ++
 xen/arch/x86/cpu/vpmu.c              | 10 ++++++++
 xen/arch/x86/cpu/vpmu_amd.c          |  7 ++++++
 xen/arch/x86/cpu/vpmu_intel.c        | 37 ++++++++++++++++++++++++++++
 xen/arch/x86/domctl.c                | 35 +++++++++++++++++---------
 xen/arch/x86/include/asm/vpmu.h      |  2 ++
 8 files changed, 120 insertions(+), 12 deletions(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 0c8b4c3aa7..04244213bf 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -872,6 +872,10 @@ int xc_vcpu_getinfo(xc_interface *xch,
                     uint32_t vcpu,
                     xc_vcpuinfo_t *info);
 
+typedef struct xen_domctl_vcpu_msr xc_vcpumsr_t;
+int xc_vcpu_get_msrs(xc_interface *xch, uint32_t domid, uint32_t vcpu,
+                     uint32_t count, xc_vcpumsr_t *msrs);
+
 long long xc_domain_get_cpu_usage(xc_interface *xch,
                                   uint32_t domid,
                                   int vcpu);
diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 14c0420c35..d3a7e1fea6 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -2201,6 +2201,41 @@ int xc_domain_soft_reset(xc_interface *xch,
     domctl.domain = domid;
     return do_domctl(xch, &domctl);
 }
+
+int xc_vcpu_get_msrs(xc_interface *xch, uint32_t domid, uint32_t vcpu,
+                     uint32_t count, xc_vcpumsr_t *msrs)
+{
+    int rc;
+    DECLARE_DOMCTL;
+    domctl.cmd = XEN_DOMCTL_get_vcpu_msrs;
+    domctl.domain = domid;
+    domctl.u.vcpu_msrs.vcpu = vcpu;
+    domctl.u.vcpu_msrs.msr_count = count;
+
+    if ( !msrs )
+    {
+        if ( (rc = xc_domctl(xch, &domctl)) < 0 )
+            return rc;
+
+        return domctl.u.vcpu_msrs.msr_count;
+    }
+    else
+    {
+        DECLARE_HYPERCALL_BOUNCE(msrs, count * sizeof(xc_vcpumsr_t), XC_HYPERCALL_BUFFER_BOUNCE_BOTH);
+
+        if ( xc_hypercall_bounce_pre(xch, msrs) )
+            return -1;
+
+        set_xen_guest_handle(domctl.u.vcpu_msrs.msrs, msrs);
+
+        rc = do_domctl(xch, &domctl);
+
+        xc_hypercall_bounce_post(xch, msrs);
+
+        return rc;
+    }
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/tools/libs/guest/xg_sr_save_x86_pv.c b/tools/libs/guest/xg_sr_save_x86_pv.c
index 4964f1f7b8..7ac313bf3f 100644
--- a/tools/libs/guest/xg_sr_save_x86_pv.c
+++ b/tools/libs/guest/xg_sr_save_x86_pv.c
@@ -719,6 +719,8 @@ static int write_one_vcpu_msrs(struct xc_sr_context *ctx, uint32_t id)
         goto err;
     }
 
+    memset(buffer, 0, buffersz);
+
     set_xen_guest_handle(domctl.u.vcpu_msrs.msrs, buffer);
     if ( xc_domctl(xch, &domctl) < 0 )
     {
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 64cdbfc48c..438dfbe196 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -651,6 +651,16 @@ void vpmu_dump(struct vcpu *v)
         alternative_vcall(vpmu_ops.arch_vpmu_dump, v);
 }
 
+int vpmu_get_msr(struct vcpu *v, unsigned int msr, uint64_t *val)
+{
+    ASSERT(v != current);
+
+    if ( !vpmu_is_set(vcpu_vpmu(v), VPMU_CONTEXT_ALLOCATED) )
+        return -EOPNOTSUPP;
+
+    return alternative_call(vpmu_ops.get_msr, v, msr, val);
+}
+
 long do_xenpmu_op(
     unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg)
 {
diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c
index 58794a16f0..75bd68e541 100644
--- a/xen/arch/x86/cpu/vpmu_amd.c
+++ b/xen/arch/x86/cpu/vpmu_amd.c
@@ -518,6 +518,12 @@ static int cf_check svm_vpmu_initialise(struct vcpu *v)
     return 0;
 }
 
+static int cf_check amd_get_msr(struct vcpu *v, unsigned int msr, uint64_t *val)
+{
+    /* TODO in case an external tool needs access to these MSRs */
+    return -ENOSYS;
+}
+
 #ifdef CONFIG_MEM_SHARING
 static int cf_check amd_allocate_context(struct vcpu *v)
 {
@@ -535,6 +541,7 @@ static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = {
     .arch_vpmu_save = amd_vpmu_save,
     .arch_vpmu_load = amd_vpmu_load,
     .arch_vpmu_dump = amd_vpmu_dump,
+    .get_msr = amd_get_msr,
 
 #ifdef CONFIG_MEM_SHARING
     .allocate_context = amd_allocate_context,
diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c
index b91d818be0..b4b6ecfb15 100644
--- a/xen/arch/x86/cpu/vpmu_intel.c
+++ b/xen/arch/x86/cpu/vpmu_intel.c
@@ -898,6 +898,42 @@ static int cf_check vmx_vpmu_initialise(struct vcpu *v)
     return 0;
 }
 
+static int cf_check core2_vpmu_get_msr(struct vcpu *v, unsigned int msr,
+                                       uint64_t *val)
+{
+    int type, index, ret = 0;
+    struct vpmu_struct *vpmu = vcpu_vpmu(v);
+    struct xen_pmu_intel_ctxt *core2_vpmu_cxt = vpmu->context;
+    uint64_t *fixed_counters = vpmu_reg_pointer(core2_vpmu_cxt, fixed_counters);
+    struct xen_pmu_cntr_pair *xen_pmu_cntr_pair =
+        vpmu_reg_pointer(core2_vpmu_cxt, arch_counters);
+
+    if ( !is_core2_vpmu_msr(msr, &type, &index) )
+        return -EINVAL;
+
+    vcpu_pause(v);
+
+    if ( msr == MSR_CORE_PERF_GLOBAL_OVF_CTRL )
+        *val = core2_vpmu_cxt->global_ovf_ctrl;
+    else if ( msr == MSR_CORE_PERF_GLOBAL_STATUS )
+        *val = core2_vpmu_cxt->global_status;
+    else if ( msr == MSR_CORE_PERF_GLOBAL_CTRL )
+        *val = core2_vpmu_cxt->global_ctrl;
+    else if ( msr >= MSR_CORE_PERF_FIXED_CTR0 &&
+              msr < MSR_CORE_PERF_FIXED_CTR0 + fixed_pmc_cnt )
+        *val = fixed_counters[msr - MSR_CORE_PERF_FIXED_CTR0];
+    else if ( msr >= MSR_P6_PERFCTR(0) && msr < MSR_P6_PERFCTR(arch_pmc_cnt) )
+        *val = xen_pmu_cntr_pair[msr - MSR_P6_PERFCTR(0)].counter;
+    else if ( msr >= MSR_P6_EVNTSEL(0) && msr < MSR_P6_EVNTSEL(arch_pmc_cnt) )
+        *val = xen_pmu_cntr_pair[msr - MSR_P6_EVNTSEL(0)].control;
+    else
+        ret = -EINVAL;
+
+    vcpu_unpause(v);
+
+    return ret;
+}
+
 static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = {
     .initialise = vmx_vpmu_initialise,
     .do_wrmsr = core2_vpmu_do_wrmsr,
@@ -907,6 +943,7 @@ static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = {
     .arch_vpmu_save = core2_vpmu_save,
     .arch_vpmu_load = core2_vpmu_load,
     .arch_vpmu_dump = core2_vpmu_dump,
+    .get_msr = core2_vpmu_get_msr,
 
 #ifdef CONFIG_MEM_SHARING
     .allocate_context = core2_vpmu_alloc_resource,
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index e9bfbc57a7..c481aa8575 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -1104,8 +1104,7 @@ long arch_do_domctl(
             break;
 
         ret = -EINVAL;
-        if ( (v == curr) || /* no vcpu_pause() */
-             !is_pv_domain(d) )
+        if ( v == curr )
             break;
 
         /* Count maximum number of optional msrs. */
@@ -1127,36 +1126,48 @@ long arch_do_domctl(
 
                 vcpu_pause(v);
 
-                for ( j = 0; j < ARRAY_SIZE(msrs_to_send); ++j )
+                for ( j = 0; j < ARRAY_SIZE(msrs_to_send) && i < vmsrs->msr_count; ++j )
                 {
                     uint64_t val;
-                    int rc = guest_rdmsr(v, msrs_to_send[j], &val);
+                    int rc;
+
+                    if ( copy_from_guest_offset(&msr, vmsrs->msrs, i, 1) )
+                    {
+                        ret = -EFAULT;
+                        break;
+                    }
+
+                    msr.index = msr.index ?: msrs_to_send[j];
+
+                    rc = guest_rdmsr(v, msr.index, &val);
 
                     /*
                      * It is the programmers responsibility to ensure that
-                     * msrs_to_send[] contain generally-read/write MSRs.
+                     * the msr requested contain generally-read/write MSRs.
                      * X86EMUL_EXCEPTION here implies a missing feature, and
                      * that the guest doesn't have access to the MSR.
                      */
                     if ( rc == X86EMUL_EXCEPTION )
                         continue;
+                    if ( rc == X86EMUL_UNHANDLEABLE )
+                        ret = vpmu_get_msr(v, msr.index, &val);
+                    else
+                        ret = (rc == X86EMUL_OKAY) ? 0 : -ENXIO;
 
-                    if ( rc != X86EMUL_OKAY )
+                    if ( ret )
                     {
                         ASSERT_UNREACHABLE();
-                        ret = -ENXIO;
                         break;
                     }
 
                     if ( !val )
                         continue; /* Skip empty MSRs. */
 
-                    if ( i < vmsrs->msr_count && !ret )
+                    msr.value = val;
+                    if ( copy_to_guest_offset(vmsrs->msrs, i, &msr, 1) )
                     {
-                        msr.index = msrs_to_send[j];
-                        msr.value = val;
-                        if ( copy_to_guest_offset(vmsrs->msrs, i, &msr, 1) )
-                            ret = -EFAULT;
+                        ret = -EFAULT;
+                        break;
                     }
                     ++i;
                 }
diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h
index 05e1fbfccf..2fcf570b25 100644
--- a/xen/arch/x86/include/asm/vpmu.h
+++ b/xen/arch/x86/include/asm/vpmu.h
@@ -47,6 +47,7 @@ struct arch_vpmu_ops {
     int (*arch_vpmu_save)(struct vcpu *v, bool_t to_guest);
     int (*arch_vpmu_load)(struct vcpu *v, bool_t from_guest);
     void (*arch_vpmu_dump)(const struct vcpu *);
+    int (*get_msr)(struct vcpu *v, unsigned int msr, uint64_t *val);
 
 #ifdef CONFIG_MEM_SHARING
     int (*allocate_context)(struct vcpu *v);
@@ -117,6 +118,7 @@ void vpmu_save(struct vcpu *v);
 void cf_check vpmu_save_force(void *arg);
 int vpmu_load(struct vcpu *v, bool_t from_guest);
 void vpmu_dump(struct vcpu *v);
+int vpmu_get_msr(struct vcpu *v, unsigned int msr, uint64_t *val);
 
 static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
 {
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 17:28:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 17:28:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429287.680211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1FQ-00024F-LM; Mon, 24 Oct 2022 17:28:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429287.680211; Mon, 24 Oct 2022 17:28:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1FQ-000248-Hm; Mon, 24 Oct 2022 17:28:24 +0000
Received: by outflank-mailman (input) for mailman id 429287;
 Mon, 24 Oct 2022 17:28:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=K33j=2Z=citrix.com=prvs=28997e893=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1on1FO-000242-VG
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 17:28:23 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 406d70c1-53c1-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 19:28:21 +0200 (CEST)
Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 24 Oct 2022 13:28:10 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by PH0PR03MB6940.namprd03.prod.outlook.com (2603:10b6:510:16e::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Mon, 24 Oct
 2022 17:28:06 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Mon, 24 Oct 2022
 17:28:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 406d70c1-53c1-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666632501;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=OBf5iH04IB6LpL1AZHt/qQEG78BHFOYBu4nXeDYqywE=;
  b=KC2VCRpDXWcuqZC4GzhrTqZPXkTF/4Pc6mU2709jPlZXBMcAvBVcUfOZ
   PvCKMVnAmBsYHjJK1vaSpNU4aefvMAnRKMi7iA57XcoEoHDUOZwy/24ic
   +VV70wcjsAIVHVP3+u96VZkjkCSjjU9WijVCW+YXh0HZYqGKGWB+OEOA6
   Q=;
X-IronPort-RemoteIP: 104.47.58.105
X-IronPort-MID: 85922227
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:/ZBQxKyHEI1zQ6+QP116t+f9xirEfRIJ4+MujC+fZmUNrF6WrkVRy
 zEZD2+PbKqOYTP2edEjb46z8xsG78DdyYQwHQVsrCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwvepPMUZh9
 tkjeGo8TAGKn+CR3uuHc7w57igjBJGD0II3nFhFlGmcIdN4BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuuzW7IA9ZidABNPL8fNCQSNoTtUGfv
 m/cpEzyAw0ANczZwj2Amp6prr+SzHmhAthNfFG+3tJbvnihmnIDMQctS3CloeicrE/gZs0Kf
 iT4/QJr98De7neDTtL9dxy+rmSNshMVV5xXCeJSwAOC0K3P+C6CG3MJCDVGbbQOtsI0TxQu1
 1mUj5XoDzkpu7qQIVqG7LqZrjq0JShTN2IOaT4sRxEC6tXop4R1hRXKJv5pDqezh8buEjH96
 zmBqW45nbp7pcUCzaO6+XjLjjitr56PSRQ6ji3MV36l/wo/fJSsZIWz6XDR9/FJII2eSx+Ku
 31ss9OD4+kIBI2N0TSXSe8QWqq07eyMNTTagHZlBZ4o+z+q/jioeoU4yDR3PltoNIAcdCPke
 lTevytW/pZYOHbsZqhyC6qUM/hv47X7FNPjcvHSc8oIepR1XAWd+yhibkmVmWvqlSAElaA5J
 Ifeas23DF4EBql9ijm7XeEQ1fks3C9W7WfSQ43riheqy7yTYFaLRrofdliDdOY06OWDugq92
 8ZSMY6GxgtSVMX6YzLL6sgDIFYSN385CJvq7ctNeYarKwZnMGI7CvLewKgqe8psg8xoevzg+
 3i8XgpUzQT5jHiecQGSMCk7NfXoQIp1qm89MWo0J1G01nM/YIGpqqACa58werph/+tmpRJpc
 8Q4lwy7KqwnYlz6F/41NPERcKQKmMyXuD+z
IronPort-HdrOrdr: A9a23:LPnCT6DEu0qfnkflHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U
 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca
 Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G
 DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z
 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK
 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+
 djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+
 DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ
 zQOWkowVLau3iefPFm8Kc7gSwlGl/NLAgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcPHmZw
 ==
X-IronPort-AV: E=Sophos;i="5.95,209,1661832000"; 
   d="scan'208";a="85922227"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ODDwyf9zr+RH+7QCM2lHAFfYLX7kTGZi8MGrcIY/hW/SCt+ySO7GpAMBr8n8fpM7FPaYyf/7CtzR+3kUeEOHigVW/mPZUd09OYK87McFN3dgiBJLIAbb3NGOEpT5/cDuiAPwxbg5BvfkWyHDGeliNyu8nj0gNhA5TXPJ1oNgeS8Yzz/L3Xg1PK+uBWXTIz4mstORafYk45DoJaZu9wbL5fGf8LA16r/rBUWnVfchO6Hwt3NlPnUBnmv7rWPtWI7PfEFgoWAuVpOkvzfTjDUxcXRqUA1nng2LX5ygAGBELM7ZTtjfNVtrYxDXckYhXOBC2iTyVYJ5+oSMMQG9uMeLzw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OBf5iH04IB6LpL1AZHt/qQEG78BHFOYBu4nXeDYqywE=;
 b=ld/LaSYcsDZGRwlSwusWoQwE8L0Qs69KqzEyhUyXqHcGKaxV0E2p3nHftQKWq3Hf4y+SoI7i9Hx9OsdsGHtdPKd+u5IVA4xN8B77i5AsZ/9Khm953WS6Ol6L+SsXDx0rNlmurrHbFald/3JdVK9B+z6ck/S8hgIvv4puGcPTOKLUB7s70Jl2ZsZAmK0Q/7l0LNQ/gaZm0hzCsk1tNHOI5DX5DDMeMPYwQZGNjEUM3rSMCZ8OGiJlwFZMllkAtNIN59QatPZ/MqiHiqSZQ8rxb/zy2wlvzvEj+di5qj1B1VHNUFUr+i1BwppicaT3knDkzTpzNF4x1GgDnPmdJiu0hQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OBf5iH04IB6LpL1AZHt/qQEG78BHFOYBu4nXeDYqywE=;
 b=Hc/8W3Bs13Yk7dFHmO2sKgxMCbWtrfVNJV8H52FJ5WVoSe8X+htDemzoKKfnSXP+BIJRRbrnn383tZYXqAq6uxPrzDMU4qi1m8EBORreST9JNtXrJUDmI71ZLBpF8RE0fjYa8xq9dWeBg7AjenBu71KKZgcYSY0b+wM19gRCEKw=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Christoph Hellwig <hch@infradead.org>, Juergen Gross <jgross@suse.com>
CC: "jejb@linux.ibm.com" <jejb@linux.ibm.com>, Sreekanth Reddy
	<sreekanth.reddy@broadcom.com>, Bart Van Assche <bvanassche@acm.org>,
	Salvatore Bonaccorso <carnil@debian.org>, "sathya.prakash@broadcom.com"
	<sathya.prakash@broadcom.com>, "suganath-prabu.subramani@broadcom.com"
	<suganath-prabu.subramani@broadcom.com>, "Martin K. Petersen"
	<martin.petersen@oracle.com>, "MPT-FusionLinux.pdl@broadcom.com"
	<MPT-FusionLinux.pdl@broadcom.com>, "linux-scsi@vger.kernel.org"
	<linux-scsi@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "adi@kriegisch.at" <adi@kriegisch.at>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Thread-Topic: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Thread-Index:
 AQHY5S6guM11mZi1eU2dnhLTM/dNx64bMt2AgAJCJQCAAA9HgIAACC+AgAA85QCAAAg5gA==
Date: Mon, 24 Oct 2022 17:28:05 +0000
Message-ID: <858a4288-46ac-d423-a529-b3b77b7fbc8a@citrix.com>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
 <30a056c8-071f-4259-3253-75e718af619d@suse.com>
 <Y1bEQMS5SNTbZO/3@infradead.org>
In-Reply-To: <Y1bEQMS5SNTbZO/3@infradead.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB6940:EE_
x-ms-office365-filtering-correlation-id: c8a01dec-0293-45f3-f9f8-08dab5e51cbe
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 LgeZPGJlxGQHvfhWPySeLJGQ8zUhipmqzsv49fJM5/u85It5KveC/pYOCANkWaJ23yZCXGyLd+HQraldxiYcz4QrVHrHkXn4w8ftsPSbkVoMlwwVzACdAwcwWLA6IcRp2ciMbDRWNwsCpGIifmGih6v+cSYGVqS3Evr01NM/GugNnKVlXrp91Hop7YnZjOyO90KRwFsS9QEo7MF40kxU6Li5jjTel0t2H2X8ispnYVH+w0Ayzwt96ASf09WVwoJjbSvArxY1Q2iW7KZm+FxgGC/6K6malADf5SkoSY2lm6cUypEdqGTgVeBvg+I/wcPFjMNgaCvuiHjTwdAHhAMDAww8GgFnEtGd8AQOXILcjeMFdYi2PuBP+/BO4S04fkS7k8FxIWkKp3pIU1CttCZ9H3JKopUc8SyWAy6pxhXspjHnbAgUPiR68+/PWFC2u8kwgiKtl1JPDxKC2ij6FWsvjJg3RFNiADrswQzRiP5u1+NJBETZziaIWrWvi+04bBqVwuPVWkSGFAJy6vH7qhzq2QtCHk1B752/krF9I6MB/kDhoxXvZHwB7UPtTfv8396UHxnDlLqHSZStgm1GSEq2fr1hAsRvrMB3AH+gXviZkVPqpizvGhWHb+FDkcRGlsG+1Nu99ViONZ9O2lNMqpC55FKv8dRVil6DdHKpE+fqomCmrByQ+XZtZDxc1NB4/NmJKWqOE58pfwuz2wtGQ9D7RXELbSr0RcBP2OO5P+aINoDHMnqrEz9BbW25G44QPp0BsNoYwUyfRPLdO8EdrdfyltFFssK9BlYQZDvWpHi86A2pNqZgKtJA+3JErqLHPAKu+djv1DUTIxv7yvJykvWB8QhIPaiGcShWtqTup2ZQRRsmhuCtLOAgKeuq6y6pZ9jr
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199015)(76116006)(31686004)(110136005)(54906003)(6506007)(66946007)(6512007)(53546011)(8936002)(2616005)(64756008)(66446008)(4326008)(2906002)(41300700001)(91956017)(7416002)(186003)(82960400001)(38070700005)(66556008)(66476007)(38100700002)(122000001)(26005)(8676002)(5660300002)(316002)(478600001)(71200400001)(6486002)(83380400001)(31696002)(36756003)(86362001)(42413004)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bkdtcGRINitiSDVwTUk4c1VxREpEMzZJVjE5bFlVMGR3WUpYOFlCQ3BJaC9D?=
 =?utf-8?B?Y29uaWk2Mjcva2N0VHR5c01zTU9RYk84ZDBQVVFQZTlzZktzTlZZV3EyaDgz?=
 =?utf-8?B?bWlMbEtGSnJKTkhqRTN5cWFYN0pJRlA3Yi9CN2xCUUNUSjB5K1liMGZWckd5?=
 =?utf-8?B?RFhNWm9lcGFjZU85dGlpN1lDdnM4aU9lYmtpRWdOZ2hsZXUwZjdqdkpOSndI?=
 =?utf-8?B?ZGNTNHZxOXZSQ1JQeTQzTVhyVStNVFJCWXJWT2dNdUo4L3ZpcmQrL0F6N0xl?=
 =?utf-8?B?SjJ6NWQ5dWF0SUhlb256cTlGbFp4cFBPbTRseXg0N0VZQTc3akw4WDJROVRp?=
 =?utf-8?B?cHJoYkhIRElDVWN2UXdGTm8zUHhtTXFkZkVpMENvOUFCQXFkRzZWWnlDQUNj?=
 =?utf-8?B?THlWWU1WT3VHNW15cTFRTUQ0bDRsM29MckdDL3kza1QvdHVoV1Z2QkhjVkQ3?=
 =?utf-8?B?RjlIa3VDZnU4MXBLa3I0VjZjeVlMMk1CN2l0WEIyNkx1dzhac1FacjA4WlNq?=
 =?utf-8?B?T3M5ZmtEZVk0bElQbTZPZWxLVG5xNlZydGpYbUxkZGZqSS8wc2RQWENuVWJR?=
 =?utf-8?B?dmp3d25qZHZSVUVBR05WN1VlbHlyT2F5RWljOWpxQ1hUbzVXL3d0U1ZKSmJq?=
 =?utf-8?B?L0RWUHdUMnAyR1NRSWpoVzllZVBGcjc5T2RxR1NGQlFJb09scVpMeitqN29W?=
 =?utf-8?B?elNPVHhuTDEwdlk2b0EySEtTb0dVWlNYQ1RCcXVWQ3ZJOC9XWmNFc2l4R3NH?=
 =?utf-8?B?QmpHT2dRalh3OWtzeThYYzRJUzdLYUU2T3d3dUExSXB5RjUxb0x5eUFQT1FT?=
 =?utf-8?B?L05yNExLWnQrZVlDUmdFWjlkVUxZRHFwNnoxT2s3Z0V4T3YrcHJaQjZEbzFn?=
 =?utf-8?B?dzBoVUl5aDJSOG1UWkpBOE5oQU9VLzliS2ZPK3dkTEJ5aE9MOXVuU1U3cnR2?=
 =?utf-8?B?UGVxOTZFM3JzbTNzUFBBNy9RK0RlRlJCQ3M5VHVpR2h2RHFxa0lncVdxVTN4?=
 =?utf-8?B?YzhIMUxGazVCYW9JRVNsd05sbFhpeERSMlZCelZwL0p4anFPVGFCRlB1UWJs?=
 =?utf-8?B?RTVQWlpSdHRNdVRjMWYwMUZOUWJOMEhmWWlKUVRmSTJwZlF5MDRPVUhldHNR?=
 =?utf-8?B?eGdUb0Rld2R6QmI4ZURZMTQxaW1XL1FwZm9CRE9TYmhQRStnRGhwNlRtYmFP?=
 =?utf-8?B?MmRYMFowc3Z0d1FzTVJxaGhtdmRKd1pqSndlajJ3bUNrQkVpemF4bkRGcU9M?=
 =?utf-8?B?QjFtTEdsTE9yb0R1eFdLVmEwbDEvRnRGU3NPU21QdExjMFA5ZkxJbGJZZmJL?=
 =?utf-8?B?cStzMjJITkZyemd0d3ZLZlhIS2wwRlAvMHBUUW91UE50alpLVDJzZFcwa0o4?=
 =?utf-8?B?TVU0eDI1Ym4wWmpoa00vNGZ2N05zSUtnOVdWUW9EWTRsWVhCWHZISnBrYm1S?=
 =?utf-8?B?UENzd2k3SENhVG95bnpGaW11K0xRMlQramxOSUEzb1MzVERiaUpFZ3lrZGVE?=
 =?utf-8?B?Q0t4MXB2STN3VGR3SzdxbmI2Z3dGbWNKR1VWaS9CRU5VSDRpUDZpZi81RnRJ?=
 =?utf-8?B?MGFHQlBsdlBydno1V0ZFby8vdGlYK3E3OVF4aWpxaGgvTkNJSktoRjA2M0Nt?=
 =?utf-8?B?aHBPY0p5SnlFZjU5bUw0Z3RTOEdNWEwvWERNQXlncFd0bDlUUk9UOGNpRHFj?=
 =?utf-8?B?UStaUUlrTVNWVk1TVkZUMTlEcllwUFRtSFhnanEwejYreFdRTURyVFB3dFhN?=
 =?utf-8?B?Q3NBUE5EZVZHckIzK0owK2FodjFSMFdZajdLZWx6alluQVJDMXhEYnZodGFy?=
 =?utf-8?B?RDlVc0tzdm9yM0R4R3NYeVFzTWJhMkRsdy9XQSt6dE9SS1VJUjJ0bGdBNmpq?=
 =?utf-8?B?djR5UGNQdGpGS1RaOWNMVmtVVkFBa2svMnhXVWMvM2Y3UmphblVVcDNiNFpT?=
 =?utf-8?B?UE81aWRxL2FnWWx6Qk1MMEtyMG44Yms5aW40aERWdzZzZ0YxVjVNdlU1MFZB?=
 =?utf-8?B?RmEvc0s2SFRFSEZEME1PL3NqcTJ4L2tSM1NDQUxEelFyL1VPR2hsOWpYVElL?=
 =?utf-8?B?MnoyZW9WSUpuR3JlNFNGVGhLdGsreUdGdVA4LzFFdHBPSllJSmgwNWtIRkRZ?=
 =?utf-8?Q?luWpc++N6E9VRgIqIvnJ4loC1?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DB3D38FAB1990F4AB62E657DC3966ED8@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8a01dec-0293-45f3-f9f8-08dab5e51cbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 17:28:06.0137
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9lNqpXGdZlwzmrzjjxMlqv/faPeall/g9qnys8YflWeuHQqvBr/Yc5FqcUI7p8SJtno/Ct4AW5atwtRifkeGGVLNjgcysEdQ6t3AC/h8j1I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6940

T24gMjQvMTAvMjAyMiAxNzo1OCwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+IE9uIE1vbiwg
T2N0IDI0LCAyMDIyIGF0IDAzOjIwOjQzUE0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+
PiBEb20wIGlzIChub3JtYWxseSkgYSBQViBkb21haW4sIHNvIHRoZSBwaHlzaWNhbCBtZW1vcnkg
Y2FuIGJlIHN0aWxsIGFib3ZlDQo+PiA0IEdCIGV2ZW4gd2l0aCBkb20wX21lbSBzZXQgdG8gNEdC
Lg0KPiBXaGljaCBtZWFucyB0aGF0IHdlIG5lZWQgdG8gZW5zdXJlIHRoZSBETUEgb3BzIGZvciBY
ZW4tUFYgKHdoaWNoIGlzDQo+IGFsd2F5cyB4ZW4tc3dpb3RsYiBJIHRoaW5rPykgbmVlZCB0byBy
ZXR1cm4gRE1BX0JJVF9NQVNLKDY0KSBvciB3aGF0ZXZlcg0KPiBpcyB0aGUgaGlnaGVzdCBwb3Nz
aWJsZSBhZGRyZXNzLg0KDQpYZW4gdHJpZXMgdG8gYWxsb2NhdGUgbWVtb3J5IGZyb20gdGhlIHRv
cCBkb3duLCBpbiBvcmRlciB0byBrZWVwIHRoZSBsb3cNCm1lbW9yeSBmcmVlIGZvciBzcGVjaWFs
IHB1cnNlcy7CoCAoMzJiaXQgUFYgZ3Vlc3RzIHN0cmljdGx5IG5lZWQgdG8gbGl2ZQ0KYmVsb3cg
dGhlIDEyOEcgYm91bmRhcnkgaW4gaG9zdCBwaHlzaWNhbCBzcGFjZSBmb3IgQUJJIHJlYXNvbnMs
IGFuZA0KWGVuJ3Mgc3RydWN0IHZjcHUgbmVlZHMgdG8gYmUgYmVsb3cgdGhlIDRHIGJvdW5kYXJ5
IGZvciBjb21wYXRpYmlsaXR5DQp3aXRoIHNvbWUgcHJvY2Vzc29ycy4pDQoNClRoaXMgbWVhbnMg
dGhhdCBhIDY0Yml0IFBWIGRvbTAgZW5kcyB1cCBvY2N1cHlpbmcgdGhlIGhpZ2hlc3QgYWRkcmVz
c2VzDQppbiBSQU0uwqAgTmF0dXJhbGx5LCB0aGlzIGlzIGEgcHJvYmxlbSBmb3IgZGV2aWNlcyB3
aGljaCBjYW4ndCBkbyA2NGJpdCBETUEuDQoNClRoZSB4ZW4tc3dpb3RsYiBpcyBhIHJlZ2lvbiAo
ZGVmYXVsdCAxMjhNIGlpcmMpIHdoaWNoIGRvbTAgcmVxdWVzdHMgb2YNClhlbiBkdXJpbmcgc3Rh
cnR1cC7CoCBJdCBpcyBiZWxvdyB0aGUgNEcgYm91bmRhcnksIGFuZCBwaHlzaWNhbGx5DQpjb250
aWd1b3VzICh1bmxpa2UgbW9zdCBvZiB0aGUgcmVzdCBvZiBQViBndWVzdCBtZW1vcnkpLg0KDQpI
ZW5jZSBpdCdzIGEgc3VpdGFibGUgYm91bmNlIGJ1ZmZlciBmb3IgYW55IDMyLWJpdC1vbmx5IGRl
dmljZXMuDQoNCkkgZG9uJ3Qga25vdyBleGFjdGx5IGhvdyB0aGlzIHRyYW5zbGF0ZXMgdG8gTGlu
dXggaW50ZXJuYWxzLCBidXQgbW9zdA0KZGV2aWNlcyBhcmUgZmluZSBhbmQgaXQncyByb3V0aW5l
bHkgdGhlIG1wdDIvM3NhcyBkcml2ZXJzIHdoaWNoDQplbmNvdW50ZXIgcHJvYmxlbXMuwqAgSXQg
d291bGQgYmUgbG92ZWx5IGlmIHdlIGNvdWxkIGdldCB0byB0aGUgYm90dG9tIG9mDQp0aGlzIGZv
ciBvbmNlIGFuZCBmb3IgYWxsLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 17:30:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 17:30:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429292.680222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1Ho-0003PU-1c; Mon, 24 Oct 2022 17:30:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429292.680222; Mon, 24 Oct 2022 17:30:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1Hn-0003PN-Ul; Mon, 24 Oct 2022 17:30:51 +0000
Received: by outflank-mailman (input) for mailman id 429292;
 Mon, 24 Oct 2022 17:30:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RDLv=2Z=bombadil.srs.infradead.org=BATV+126e47513ec1fd56a858+7001+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1on1Hm-0003PH-1z
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 17:30:50 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:3::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99233b8c-53c1-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 19:30:49 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1on1Hd-002Ta1-SO; Mon, 24 Oct 2022 17:30:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99233b8c-53c1-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=R2CozcFHwiChhVIqs9e1K7KGsaZbKqtzxGeJtPv9o4I=; b=kIseVJ2df1bajoZTbCM6NTSzk3
	aAMcxXbtdOSJSoQJcJ5AwEtJfcHjIKlO54CzW1473JnXWY+4pbRjbCnbhZkHDnFMSYQI16SHsQ0Un
	C5HUIGuZI3Vj+yi1EJ73edNhXPpC7mWC/77d38X96cylJ45BjMRtPVupLNQ3MekhFWX1tMFRA/mik
	PidTxoEXuf4sxtY10c52U0iGpLcR889au95SDPugZ9kZ9aGB1BmsNG/p1Y3hezN49AE1g7PlzKIz6
	fBFxfL+yAc8Z7lM8uL8Nrf82mLnCBBDMeXHT7NPasxJeFoithuIP6hPw4h5SOmwzH9LS46qQFYM9e
	zw2/RcCw==;
Date: Mon, 24 Oct 2022 10:30:41 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Salvatore Bonaccorso <carnil@debian.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	sathya.prakash@broadcom.com, suganath-prabu.subramani@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	adi@kriegisch.at
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Message-ID: <Y1bLwUkCgElIBNdU@infradead.org>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Mon, Oct 24, 2022 at 05:26:44PM +0530, Sreekanth Reddy wrote:
> This issue is getting observed after having the below patch changes,
> 2b9aba0c5d58e141e32bb1bb4c7cd91d19f075b8 scsi: mpt3sas: Fix return
> value check of dma_get_required_mask()

Looking at this commit it seems odd.  dma_get_required_mask() should
only be used as an optimization for hardware that actually benefits
from a lower DMA Mask.  That means either classic PCI that requires
DAC cycles, or firmware architectures like aic7xxx that do need
additional overhead.  I don't think either is the case for mpt3sas,
so I think (in addition to fixing up the Xen required mask), mpt3sas
should do something like:

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 4e981ccaac4163..295942a8989780 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -2992,8 +2992,7 @@ _base_config_dma_addressing(struct MPT3SAS_ADAPTER *ioc, struct pci_dev *pdev)
 	struct sysinfo s;
 	u64 coherent_dma_mask, dma_mask;
 
-	if (ioc->is_mcpu_endpoint || sizeof(dma_addr_t) == 4 ||
-	    dma_get_required_mask(&pdev->dev) <= DMA_BIT_MASK(32)) {
+	if (ioc->is_mcpu_endpoint) {
 		ioc->dma_mask = 32;
 		coherent_dma_mask = dma_mask = DMA_BIT_MASK(32);
 	/* Set 63 bit DMA mask for all SAS3 and SAS35 controllers */


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 17:33:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 17:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429298.680233 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1Jv-00041P-DU; Mon, 24 Oct 2022 17:33:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429298.680233; Mon, 24 Oct 2022 17:33:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1Jv-00041I-Ad; Mon, 24 Oct 2022 17:33:03 +0000
Received: by outflank-mailman (input) for mailman id 429298;
 Mon, 24 Oct 2022 17:33:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RDLv=2Z=bombadil.srs.infradead.org=BATV+126e47513ec1fd56a858+7001+infradead.org+hch@srs-se1.protection.inumbo.net>)
 id 1on1Ju-000419-3n
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 17:33:02 +0000
Received: from bombadil.infradead.org (bombadil.infradead.org
 [2607:7c80:54:3::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7ee3212-53c1-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 19:33:01 +0200 (CEST)
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red
 Hat Linux)) id 1on1Jk-002Tzq-40; Mon, 24 Oct 2022 17:32:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7ee3212-53c1-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding
	:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:
	Sender:Reply-To:Content-ID:Content-Description;
	bh=rmYsPiQAe01mPUbVVVEiS6SzJmrWKoOMvVqAUcXlI3E=; b=tv4ds0D7DIvDaukA98ZSEiuXsj
	5bqFYvG7Kxc26coWWzyB01UmgmfRdJ9NHPgGN6+MQ7K4t49rWSudQCsuaeA2oImMNf7NVrvZZ9/uD
	LvzpmEf/Q3O+XSsEElVRnf67XBDZEQpKYSLXlClNzP2bbrz/OL+1qNcB8wfxo54awzWM5rIQW5SQ/
	mR7WVWNmsqKU02JvuN3+2ectX7Y6LsXwS8vxfIVuIqrpT2VhpH1Qyb4ulEE9SK5kFgYa/qJZTiELn
	BbRs/CqIvv5s4bT0EFrEYnFdKZlIxXYw4/DTUf4Iv1wnoozDaByH7HaF9dz2HWVwJ+sJRQ7vuPAgn
	7hdtcQuA==;
Date: Mon, 24 Oct 2022 10:32:52 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Christoph Hellwig <hch@infradead.org>, Juergen Gross <jgross@suse.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Salvatore Bonaccorso <carnil@debian.org>,
	"sathya.prakash@broadcom.com" <sathya.prakash@broadcom.com>,
	"suganath-prabu.subramani@broadcom.com" <suganath-prabu.subramani@broadcom.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"MPT-FusionLinux.pdl@broadcom.com" <MPT-FusionLinux.pdl@broadcom.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"adi@kriegisch.at" <adi@kriegisch.at>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Message-ID: <Y1bMRNhmq41/y3Jb@infradead.org>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com>
 <30a056c8-071f-4259-3253-75e718af619d@suse.com>
 <Y1bEQMS5SNTbZO/3@infradead.org>
 <858a4288-46ac-d423-a529-b3b77b7fbc8a@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <858a4288-46ac-d423-a529-b3b77b7fbc8a@citrix.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Mon, Oct 24, 2022 at 05:28:05PM +0000, Andrew Cooper wrote:
> I don't know exactly how this translates to Linux internals, but most
> devices are fine and it's routinely the mpt2/3sas drivers which
> encounter problems.� It would be lovely if we could get to the bottom of
> this for once and for all.

So to summarize my two mails:  I think te use of dma_get_required_mask
in mpt3sas is wrong, and the dma_get_required_mask return value from
xen-swiotlb is also wrong.  Fixing either one should fix this problem,
and I think we should fix both.


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 17:41:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 17:41:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429304.680244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1S8-0005XL-6P; Mon, 24 Oct 2022 17:41:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429304.680244; Mon, 24 Oct 2022 17:41:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on1S8-0005XE-3X; Mon, 24 Oct 2022 17:41:32 +0000
Received: by outflank-mailman (input) for mailman id 429304;
 Mon, 24 Oct 2022 17:41:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3GNr=2Z=denx.de=pavel@srs-se1.protection.inumbo.net>)
 id 1on1S7-0005X8-3y
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 17:41:31 +0000
Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 173309e3-53c3-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 19:41:29 +0200 (CEST)
Received: by jabberwock.ucw.cz (Postfix, from userid 1017)
 id 23CFA1C0040; Mon, 24 Oct 2022 19:41:28 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 173309e3-53c3-11ed-8fd0-01056ac49cbb
Date: Mon, 24 Oct 2022 19:41:27 +0200
From: Pavel Machek <pavel@denx.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 174/229] x86/entry: Work around Clang __bdos() bug
Message-ID: <20221024174127.GC25198@duo.ucw.cz>
References: <20221024112959.085534368@linuxfoundation.org>
 <20221024113004.718917343@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT"
Content-Disposition: inline
In-Reply-To: <20221024113004.718917343@linuxfoundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)


--KN5l+BnMqAQyZLvT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Kees Cook <keescook@chromium.org>
>=20
> [ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]
>=20
> Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=
=3Dy
> and CONFIG_UBSAN_BOUNDS=3Dy when operating on an array with a dynamic
> offset. Work around this by using a direct assignment of an empty
> instance. Avoids this warning:
>=20
> ../include/linux/fortify-string.h:309:4: warning: call to __write_overflo=
w_field declared with 'warn
> ing' attribute: detected write beyond size of field (1st parameter); mayb=
e use struct_group()? [-Wat
> tribute-warning]
>                         __write_overflow_field(p_size_field, size);
>                         ^
>=20
> which was isolated to the memset() call in xen_load_idt().
>=20
> Note that this looks very much like another bug that was worked around:
> https://github.com/ClangBuiltLinux/linux/issues/1592

We don't have CONFIG_UBSAN_BOUNDS in 4.19, so maybe we don't need this
one?

Best regards,
								Pavel
							=09
> +++ b/arch/x86/xen/enlighten_pv.c
> @@ -752,6 +752,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
>  {
>  	static DEFINE_SPINLOCK(lock);
>  	static struct trap_info traps[257];
> +	static const struct trap_info zero =3D { };
>  	unsigned out;
> =20
>  	trace_xen_cpu_load_idt(desc);
> @@ -761,7 +762,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
>  	memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
> =20
>  	out =3D xen_convert_trap_info(desc, traps, false);
> -	memset(&traps[out], 0, sizeof(traps[0]));
> +	traps[out] =3D zero;
> =20
>  	xen_mc_flush();
>  	if (HYPERVISOR_set_trap_table(traps))
> --=20
> 2.35.1
>=20
>=20

--=20
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--KN5l+BnMqAQyZLvT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY1bORwAKCRAw5/Bqldv6
8ncbAJ9IUs8w/7hTCthPKhWGY8O+PVF6zACglL4ohEfyPjuKQnuAt70ZrDtKMoA=
=ONRr
-----END PGP SIGNATURE-----

--KN5l+BnMqAQyZLvT--


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:19:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:19:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429314.680255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on22s-0000rj-2m; Mon, 24 Oct 2022 18:19:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429314.680255; Mon, 24 Oct 2022 18:19:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on22r-0000rc-VG; Mon, 24 Oct 2022 18:19:29 +0000
Received: by outflank-mailman (input) for mailman id 429314;
 Mon, 24 Oct 2022 18:19:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on22q-0000rW-IH
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:19:28 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12hn2213.outbound.protection.outlook.com [52.100.166.213])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 63d1ecbd-53c8-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 20:19:26 +0200 (CEST)
Received: from MW4PR04CA0352.namprd04.prod.outlook.com (2603:10b6:303:8a::27)
 by PH7PR12MB6905.namprd12.prod.outlook.com (2603:10b6:510:1b7::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Mon, 24 Oct
 2022 18:19:23 +0000
Received: from CO1NAM11FT039.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:8a:cafe::3a) by MW4PR04CA0352.outlook.office365.com
 (2603:10b6:303:8a::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27 via Frontend
 Transport; Mon, 24 Oct 2022 18:19:22 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT039.mail.protection.outlook.com (10.13.174.110) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 18:19:21 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 13:19:20 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 24 Oct 2022 13:19:19 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63d1ecbd-53c8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vxbd7WIoiMXFOwnr8n4jepXsw1Q5DS5Ud+z8WlAqDYs1TK9gMm/uAV41KLMEVi+z1IelGDzSvcyj6vDr7oD6+PF18WfyaBhAEJuZlz76ibeyZMnS7MKlc9FTEbnpzXzPfURkstExO7glCe67RqYkG097gfhM5eFtv17Ta5RUinMSotByU1JMfn86Erpkxxqf/WX9PP6/DoXSS0DopH1NBbT0IF11QX72yMhDVW57MOaMNHmgqs1hsOgd/CITx4nOTkQsmmg0q4p8Jre+IaVmcrarEq45ZESr8WuyO59A938mIck31VN160zPnrA+kRoVDWryqX4zDqlCaLLDDPlWUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J5B3TqJ58VJAkItxAN9gqSaQ9XwjpKLxd/rGzStRCyQ=;
 b=T/EKsq+B3cL8DN3thiImCJF8cZNK9RKzRCP+wHGj8SeQlvhjOXFOD1mrs+cqkbjaCau5GDAFMxTbqA7bwOl/J3bK6Hl9AxFVutmDMpN5+mLN2fL/Iozgfh4BLKJAWIYrmk1NHzA+IwJhv5uziiMYpUImodpUrVR/6kJp4Et3TfJ0siRHVWAnxdHh56i6W94M5CDVY+Vyh0zhLAkd1mHZkpCuFwtGEz1Ecb6zTOy+Rk5kG96d0XEjyk7+6UZTrhbVErdCckvJcFdcf5qQOvh5sZqqgDrgZsTOnWi+aJPjb1bdU4NO5+c/llvtIjjKxJXiGb4erAuFtKj+cRrKNIIogw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J5B3TqJ58VJAkItxAN9gqSaQ9XwjpKLxd/rGzStRCyQ=;
 b=YQ/0D5Fmfd0//KxExben+BO5qEVK6lpTQQZii4eIMbhUHtgtfFV1s/rRlQZoyfoZjg04ZXLr6l73wNgjv9ueBy7tWljLjyCeLeLNxO3rQmABJ78V58KwEAqni8a8UZQ0OFwP+oG+ajQCF4MfGEWe4osccBzuXp/EoMj8gDlf+3k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, <michalo@amd.com>,
	Ayan Kumar Halder <ayankuma@amd.com>
Subject: [RFC PATCH v1 00/12] Arm: Enable GICv3 for AArch32
Date: Mon, 24 Oct 2022 19:19:04 +0100
Message-ID: <20221024181917.60416-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT039:EE_|PH7PR12MB6905:EE_
X-MS-Office365-Filtering-Correlation-Id: 1c2983bd-22eb-49b4-c535-08dab5ec462c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	=?us-ascii?Q?f3Qm2FUr1u+BdkV3joZ2mNxbEEikTviXoEVU61AH93uCQKT9nS5jf+Ng0EHh?=
 =?us-ascii?Q?5LF8JXOVI47uuG5+YgBC1uEhOtGwXXdO7CUjOb/GUKY6AL1v9asYSjzrN5DI?=
 =?us-ascii?Q?Sz2QmQ8NHDnwz9cKPPR49gUe3u+w/hdW/fECDM3EL8nVCOJnZhzow2zMT612?=
 =?us-ascii?Q?xHYczkuZF/jJSauFF8JR0WhfXd1FoCMXrKCCDqjAYiQqhcN+pfXNfFhC48qb?=
 =?us-ascii?Q?Ors18mZbqmetX8ovT+cwfrVHVb8GFEvNBgIrjq0I6vXGH4l0FLSprdZbZ1/L?=
 =?us-ascii?Q?KhSLUZDyL5+BfspE8h3LcZ5fbLFs5A4a+CK3gDLd9lgAjj+Ite00jA0gZvzd?=
 =?us-ascii?Q?oCqxjg/EHlUgnRKMQZpI47D5RKyewfOljMElbAtFTCGrRsgkQoMv5sh+aDtA?=
 =?us-ascii?Q?Otu1DwBUVNY5WAbyM3p7r+OTUpKJKXVR7wErOxAdmRkQrKYrS2XfR4Aj7s75?=
 =?us-ascii?Q?+ZNU9NQKlyh59ltfAScWUalgMSyzZ4yIfnpRls3NKJo1dE3ZbJmVh1u5J+4I?=
 =?us-ascii?Q?7KRX++a9FJzBz4N9zNkvYaMD2Rh4Booszy54kzyp4crg+JbvxCGYNFHqmQFL?=
 =?us-ascii?Q?dNbgOEU1k53FFLMWPfTGcEU2sGswVuf5ZT5UXZ10rJUCBzk0BH2GXrxwSr5B?=
 =?us-ascii?Q?TVLshR2E2MuQ6jXTEN5L0nvSAZ3cH7El5MtxLRKfikD276B4IJXjuSY5zKkG?=
 =?us-ascii?Q?9kzrvxS8QF7RSB29n9MDajvwt5fPiV5zAIRdSo3BePE8FzSCI8+Wj+0ZmoQ2?=
 =?us-ascii?Q?9v9+5Whfax0QPQUThcX4jsQIF/z2CAlSPqZRDxxZsdUVlqaP6cq9qHUGr+Qc?=
 =?us-ascii?Q?y6MMSGHJ582Y14hyXPwAX5TBktSxeMnuDVE3hylpO20YhmRa1E0kpfU274X6?=
 =?us-ascii?Q?B14vOAmrvelWWB4KoBSTbIVS59Wdjf0rwft7DcPrpayO+spK7kcDNzUvNfaQ?=
 =?us-ascii?Q?XohRDzkZwvvBjfPm8Rzy4LZ/mjfP39v+Qfp/5kJdqiFEhBqLFoKUNsM6Bid4?=
 =?us-ascii?Q?54Drn2hQOFOATL+cYlDrns4QBiY1GNBUDar50f665ueaSneEGEccauhA5Gk4?=
 =?us-ascii?Q?gFN+a9LtY6P69CNOABKN5iqmOwMTH9wHh08y5/8868yudVL/Ustl/euIeh5O?=
 =?us-ascii?Q?ThCPfzn3ptTyw9G8N3GiTF5lUhRokLCA0zn5FacX+qN6BRbLrRZOYXd8/xlk?=
 =?us-ascii?Q?mJnJW682sfVmYBa0quV8DjhpCxQKN1iE97NyjbW8IY8kk23AONfS4FG9XO8?=
 =?us-ascii?Q?=3D?=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:OSPM;SFS:(13230022)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(426003)(83380400001)(47076005)(81166007)(356005)(36860700001)(82740400003)(8936002)(70586007)(70206006)(5660300002)(8676002)(4326008)(41300700001)(82310400005)(2906002)(6666004)(26005)(2616005)(40460700003)(1076003)(336012)(54906003)(6916009)(478600001)(36756003)(316002)(40480700001)(186003)(36900700001)(11215385002);DIR:OUT;SFP:1501;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 18:19:21.8876
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c2983bd-22eb-49b4-c535-08dab5ec462c
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT039.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6905

Hi All,

Please find the following patches to enable GICv3 for AArch32.
This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system)

Let me know your thoughts.

Ayan Kumar Halder (12):
  Arm: GICv3: Sysreg emulation is applicable for Aarch64 only
  Arm: GICv3: Move the macros to compute the affnity level to
    arm64/arm32
  Arm: GICv3: Enable vreg_reg64_* macros for AArch32
  Arm: GICv3: Emulate GICR_TYPER on AArch32
  Arm: GICv3: Emulate GICR_PENDBASER and GICR_PROPBASER on AArch32
  Arm: GICv3: Emulate of ICC_SGI1R on AArch32
  Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
  Arm: GICv3: Define ICH_AP0R<n> and ICH_AP1R<n> for AArch32
  Arm: GICv3: Define GIC registers for AArch32
  Arm: GICv3: Use ULL instead of UL for 64bits
  Arm: GICv3: Define macros to read/write 64 bit
  Arm: GICv3: Enable GICv3 for AArch32

 xen/arch/arm/Kconfig                       |   2 +-
 xen/arch/arm/gic-v3-its.c                  |  20 ++--
 xen/arch/arm/gic-v3-lpi.c                  |   8 +-
 xen/arch/arm/gic-v3.c                      | 132 ++++++++++-----------
 xen/arch/arm/include/asm/arm32/io.h        |   4 +
 xen/arch/arm/include/asm/arm32/processor.h |  10 ++
 xen/arch/arm/include/asm/arm32/sysregs.h   |  80 +++++++++++++
 xen/arch/arm/include/asm/arm64/processor.h |  13 ++
 xen/arch/arm/include/asm/arm64/sysregs.h   |   7 +-
 xen/arch/arm/include/asm/cpufeature.h      |   1 +
 xen/arch/arm/include/asm/gic_v3_defs.h     |  24 ++--
 xen/arch/arm/include/asm/gic_v3_its.h      |   2 +-
 xen/arch/arm/include/asm/processor.h       |  14 ---
 xen/arch/arm/include/asm/vreg.h            |  23 ++--
 xen/arch/arm/vgic-v3-its.c                 |  17 +--
 xen/arch/arm/vgic-v3.c                     |  26 ++--
 16 files changed, 242 insertions(+), 141 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:21:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:21:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429319.680265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on24h-0002GI-HU; Mon, 24 Oct 2022 18:21:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429319.680265; Mon, 24 Oct 2022 18:21:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on24h-0002GB-EY; Mon, 24 Oct 2022 18:21:23 +0000
Received: by outflank-mailman (input) for mailman id 429319;
 Mon, 24 Oct 2022 18:21:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on24g-0002G5-8N
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:21:22 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on2072.outbound.protection.outlook.com [40.107.92.72])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a86d2892-53c8-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 20:21:21 +0200 (CEST)
Received: from MW4PR04CA0068.namprd04.prod.outlook.com (2603:10b6:303:6b::13)
 by BN9PR12MB5291.namprd12.prod.outlook.com (2603:10b6:408:104::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Mon, 24 Oct
 2022 18:21:17 +0000
Received: from CO1NAM11FT090.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:6b:cafe::c0) by MW4PR04CA0068.outlook.office365.com
 (2603:10b6:303:6b::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26 via Frontend
 Transport; Mon, 24 Oct 2022 18:21:17 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT090.mail.protection.outlook.com (10.13.175.152) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 18:21:16 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 13:21:15 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 11:21:15 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 24 Oct 2022 13:21:14 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a86d2892-53c8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=itXPX+BDmO/hZxgNGd6itSu6N7YEwRDM3no2MNj6vE2TQBsH3p1nE0k/HBPbl46QGq3US0CdDi7byJICG4/sE6Cf0QG0e3+x43XBW3Z0AxVAGfBaUE18CkzPI6o00RBVB5pLMppyY7z6nxCdvoCuhcLbMS3ASHn7J3kJtSNvbRBmleb3FSZ0SPJTZ4kAhbtJWNLwdl9Fv4niPuNSAZDYgxKQmvqS7YebU4c8oYlNgtJW20ZoSCagFgeE2bdlbuMYdzh31xtEdYTQmeqZevkzjDQsI9X56sHTnmC3B1oewA2SROdJ0e9emctBlVf2ndHTTcCOQ+HZahLpEeI5yy0kUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yeM/jQyVI4e8F7utEeCiyfeBbYsSPRRaablKg4pztz8=;
 b=HdmKkWR8qOc8sz7BVkkH7enI3wmE/cf2EtoM8s9H+NBVaVvMANu327JcggFW1+m5DFoXEOOdwszpvFUqcE8mDemW2XfiQzN4tK1/cuyCxEpGpv+n+2cmY5oa99CNofgotT/WgHi6yHEYx33FEiV0vKbyg9w5lGvH1mQ7dZNXwG9eO/zpN1cIpSjqIfiqGwlJvbmMou63XR7NJYg4KLjPRHBCsldBlVWDLG2gi8+r3TanhcCSa6oVCAXOhoRE0+UC1wuSwxs+qvxuPMw7eQbrlD8qzJsS1S8sH7VoOTM/h64pAKMvM1TcRadlkgvvl+cz1lfiKQQ8453lj9GcM+oMVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yeM/jQyVI4e8F7utEeCiyfeBbYsSPRRaablKg4pztz8=;
 b=K/glthB24nksoCoK03hquKEtnGx+F8DO2EeFCyRu/t328k2HAGXaUnxN+0U9dyicS0Lr0wiOJM58ZgKE73mPKrCswdBR28w7ZlNXr3yb6Hpb9jXFN4pKSiwfYbt35tczeNB8OitqVs//1ughaFsk/dc1vFo5esd09/vOKRUN42A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, <michalo@amd.com>,
	Ayan Kumar Halder <ayankuma@amd.com>
Subject: [RFC PATCH v1 01/12] Arm: GICv3: Sysreg emulation is applicable for Aarch64 only
Date: Mon, 24 Oct 2022 19:19:05 +0100
Message-ID: <20221024181917.60416-2-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221024181917.60416-1-ayankuma@amd.com>
References: <20221024181917.60416-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT090:EE_|BN9PR12MB5291:EE_
X-MS-Office365-Filtering-Correlation-Id: e7d79043-67fc-49f3-c1bd-08dab5ec8a92
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OQFXLdbH/CX3VKAIydvPBx+sFFuQleKtm7bCpYjGYlyzJP0kUw4/aV9UIsOl0OhnkgXK6uiCTZQzK0EDIMA+MO09HjaC3ep5NBK6NNqfkGvSz0peO4///0PHvmVx93DU25c6aJ6dhKDEXPfQnNMomYyDKLFmCq0c7x1azpmm9SWGdPjp0ZJbfw/aSeVhSA4HuPg+rVo1IUBFruulVFXVRrF2xb9IhExvwV1HG924rJjwSmWxoPh9x4B3HIJprD/unvrOt3viHIdwatgmDREGrtdy4eB2ZhkkK6+jK3yXyaW5TtTyinTkmT6ohzXxQUl6iIKoSwG/9qAJZjNorNPORd668EINgsPB2kYfhRLPE6W/HIGqdbq9qLcDobMmkeSNwtCDU+J8Qk9z5jAcoFF9Y5PUFL5p4fUJe2GhrbASQThLtgWU4xLQFCevBiLk+yw+Jy7Z/23TcsbrNQdcFz/6FxDpWLQ55+AFBfkRCUJPwphhSpvH9GASo5zgIyIN96mqhGnaN4jy0BpqoH3GuzCji9DPOWs3NIwF4Uf4qlWYb6GRB7Tmn9l+3qIKfAZMUYT221wyhxWPLUDUMuOpOJ4X793p5VhZElqAwoE6X62ZSdw6GazUv7U03ZbkqyqQK0U/P7jsWPj5MF5UuaN5L5eCQVcsKhcVIAGn4255m4dX/X2QUXBOdCxiUz3sHyHxXbonjCOmZQovLL1RdFvpr0XhqiWIe4jpE6vJ4axuT/N0bRhtFMmf034CJDjjSW6gK1L+t7lWHNeAiFv1Kv/379f7ztorlZDSLRjQYIdYIBzm3EA=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(41300700001)(40460700003)(82310400005)(478600001)(356005)(81166007)(54906003)(316002)(6916009)(6666004)(36860700001)(5660300002)(36756003)(2906002)(186003)(47076005)(336012)(82740400003)(70586007)(4326008)(8676002)(1076003)(70206006)(40480700001)(26005)(2616005)(426003)(8936002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 18:21:16.6254
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e7d79043-67fc-49f3-c1bd-08dab5ec8a92
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT090.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5291

Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
only. This is when MSR, MRS, System instruction execution in AArch64 state
is trapped, that is not reported using EC 0b000000, 0b000001 or 0b000111.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/vgic-v3.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..c31140eb20 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1520,6 +1520,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs *regs, uint64_t *r,
     }
 }
 
+#ifdef CONFIG_ARM_64
 static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
 {
     struct hsr_sysreg sysreg = hsr.sysreg;
@@ -1540,6 +1541,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
         return false;
     }
 }
+#endif
 
 static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr)
 {
@@ -1563,8 +1565,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs *regs, union hsr hsr)
 {
     switch (hsr.ec)
     {
+#ifdef CONFIG_ARM_64
     case HSR_EC_SYSREG:
         return vgic_v3_emulate_sysreg(regs, hsr);
+#endif
     case HSR_EC_CP15_64:
         return vgic_v3_emulate_cp64(regs, hsr);
     default:
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:23:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:23:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429325.680277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on26g-0002sA-U4; Mon, 24 Oct 2022 18:23:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429325.680277; Mon, 24 Oct 2022 18:23:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on26g-0002s3-R8; Mon, 24 Oct 2022 18:23:26 +0000
Received: by outflank-mailman (input) for mailman id 429325;
 Mon, 24 Oct 2022 18:23:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on26f-0002rv-PA
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:23:25 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11hn2220.outbound.protection.outlook.com [52.100.172.220])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1c15b3a-53c8-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 20:23:24 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by PH0PR12MB5484.namprd12.prod.outlook.com (2603:10b6:510:eb::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Mon, 24 Oct
 2022 18:23:20 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 18:23:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1c15b3a-53c8-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LpTNXUJizdCh4s09tYtXQg4ElrrGBkTOKeGL05yuDqclewH++Pz5F1NEOuZSA3U8trQyPGsNFKNMSizecc7nzZ9y+nUjyGFYLC2TLUgGrltEXU9xyek3oCkoulT5wObjnALJpL9GlW2Cnbv+olARtsdQscQlVUvDw9CQvsdrDRt4izhB1ymPrOvz2PI3Q+GEza+5IOC3OFgXHOQTmNTVLt6CqWRZhMxj6WxEk26ZzsDpy2xRZQHK05xPHnCv9+SgJY9Pflo8q/+y+gt1E3PJFWra7E5SQaJvBcBwk5rLIg4XrzEKMj0EDw+AFLpaqX2Pv4dm4KHL4XrdA2LpI//Phg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TRItKjpgSE6luuTmK1leJybAIODKGpR0/UJh+Ns5K64=;
 b=MEO+kd1WtvdcV6kBHnsu48JPbSCPHgJimQ39vdDjZSOw5SzKqtZsxiMF2oSopFc5mpCDQvt3PYOxAKyuEWCtXGH4e5Wxeo4Hu2pHygHMg6zd7F9I5U/ONVxham/R2fboRgBQGnGwyDqYN2uKVOubIGnv4dgZgIAlTVmHj6fZiQjtq6Hpk6Lj6g+yzA8QXL4ezM7fXIzEJ8wmY3WHaltPJ5jxKJ/C2nRq+dc4nsjzbJxOjdkvzIk+moOzTlugjX3TzCUhyTp1BtecEcXE7mGnV5T9PTi9/S+9FqIkCfejLDzkskO/caIPIK5BOdJ5zECk6pZV1qtxiowF8Un4hjAKsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TRItKjpgSE6luuTmK1leJybAIODKGpR0/UJh+Ns5K64=;
 b=BQ6bSFZkBekY5FYG9JKKCTtljqy0/e3PTby3z0Zg1mFglgNWcPPpuf/AMdUeoyER9siVTJEjzL8N/2VayThPLo1uCkWMNyvYJKWudWc2zeUffS6qFL1y5ut8vH3rN8MQHoUxy8ZwvMDpMMV0qPBk5aEpiVZh5aMbJEhRrdNmjnk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <37395a5a-e014-c8a3-8209-6b056ed4fe01@amd.com>
Date: Mon, 24 Oct 2022 19:23:14 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 00/12] Arm: Enable GICv3 for AArch32
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michalo@amd.com
References: <20221024181917.60416-1-ayankuma@amd.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221024181917.60416-1-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0417.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::8) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|PH0PR12MB5484:EE_
X-MS-Office365-Filtering-Correlation-Id: 6c2203ba-4bec-464e-d108-08dab5ecd424
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?dFA5TjVEQXVZSkd3ZXlQamViamEvQStSNFlZNlYzdDlPTHZLMTNEVktNS0sv?=
 =?utf-8?B?bm52OExyOGxrT2tlRTB2S3doMXJSYjU5S2VDdTFYb2ZDUzdZVnVYTThjZTFu?=
 =?utf-8?B?cGN4dGlBa1VZOW5nR2hrRW55V21MeSt1cEgvTDM1QWd5bU1DQXd4dU1BVmsy?=
 =?utf-8?B?Y3hidUVHTzdWWEIwV0Zad2ZOK1ROVkpxMGdVMWlTTTVuNTM0MkZjQndkR0M5?=
 =?utf-8?B?TFBtOUFYdi81QURYRUd0OC9kQUhtdlNvNFJyVTE4ZHVyZ3UvQ2cxWU82eFdL?=
 =?utf-8?B?YXhNSXc2OW9ZZTZ5SkdiT04rdUY3VitjSE9nVmpsbmlRNGJBeStGKzJUUXlt?=
 =?utf-8?B?bG1JRmFSdERvWVZHQkhVWWFmTkFqQ3QxN3F0d20vMFcyeWJJVktGZ2ZoZmRs?=
 =?utf-8?B?MEpudWczenN5TGpKV0Q1OFBKUHBKSEYwMFRJRHF6WURZS2dXMGFRNXl6ajNw?=
 =?utf-8?B?NG91Ny9wL0wzeXArc1FwVmpHSU9pVElQRmxhL1pRd3duY3hneVA4R2l0Y1No?=
 =?utf-8?B?VkNveGZOS3NjNzZCYUFHcWdWM0I3UHZqWHNrOXFGOEJLa2gvTmZvQUQ2WDFT?=
 =?utf-8?B?S2VMNFArSXpBcmIxZi9XRUlYRSthdm1PZy9aZEs2a0JCWTFhcTVCWDU0bDFG?=
 =?utf-8?B?Ni9ZNmxiVGk0RjJNSDBOaGRxNlhCcnJzK2d5TU95SnZiZk1FOG9CcTVuVDd6?=
 =?utf-8?B?RDFTRzZjRTBoRWlOeDJrREZDdDNTNE0wNitPbHpjTnpkSVhQbUhSS0tUMTVo?=
 =?utf-8?B?U3phVGRnNk5pU0h2WmpFWWJCamgyY1ByTWV6TVl0cHlCbk8xL2hURVlnbHEx?=
 =?utf-8?B?cjBqa05BUmttWnRYcmsrWFJuaCtXb3BCbVYxQ3BYaDcyenJLU0FRWnlHNkF4?=
 =?utf-8?B?QlRUVUtSYXRQVU1SMXpGSDFRcjVQb2RqeE1xU29UNHV6cWhSN0t0d0Y5SXNo?=
 =?utf-8?B?bmtXZ1pxamN2M3htRjdMS0RYVG5jeTZjUnZsbWlNYWtsdStqMjdrRzVFV3ZN?=
 =?utf-8?B?N1o1TWJabGxKYVR1NW9BZlJtTmVMcW9ZZjd5Uk5BdWxHdm9aYjFGakJ6bFlK?=
 =?utf-8?B?a2pwWGNVNjYrNEJ5cEdOTkdveXZ4R01sTndBTEEyTFFxWVd5WVk1SDVpNVNM?=
 =?utf-8?B?bGhFTjJiZXJiRkE0VnJFU3V4L0lWODFkT1NiNFdzLzdQcGR4RW5yRHgwYVpG?=
 =?utf-8?B?cXZkRDNBQ3FRa0JLM1pld0tQb2hiSHpsbUZOdHpqR1Q3YzU3dHVZYlB5T0JV?=
 =?utf-8?B?WkZqejVkZUNmK0ExcWdBc3hwQjc0aVN5MktydytVV3MydnBzQk1TRmo5Wk4v?=
 =?utf-8?B?M2hDSHJvclk5OGNiN0ZpMFA2RGZSWjdDSFo1c2VZM3h5NjVjZVVSQXVMbWVS?=
 =?utf-8?B?MHhCYUJNRmczcDQ3WTB1dFpuMW1INm92TXJFR0JCVEtPTUZtTzN3KzFMY3Zl?=
 =?utf-8?B?RS9hdGpWemNDMTdYby94N3g3b0tMeDQ2OUlJS0lKYmQvT2E4bkowakhXc0Rk?=
 =?utf-8?B?Kzh3QTBYK294VUVsVU0zNFJFb2Fmd0VjbTUxaFE2TDFRYjNNRS8rMXd0aVYw?=
 =?utf-8?B?SDMzTjdRQXNIN2hiZzdrYTIzNlgxek9kSXJvdWUyQkszclNMNC9UTERSa1Ru?=
 =?utf-8?B?RjZzKzd3Z2VoNXQ0MWpwZEovVUlsWnc9PQ==?=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:5;SRV:;IPV:NLI;SFV:SPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:OSPM;SFS:(13230022)(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(451199015)(31686004)(6512007)(53546011)(316002)(26005)(36756003)(66556008)(66476007)(4326008)(8676002)(31696002)(66946007)(41300700001)(8936002)(5660300002)(2906002)(6666004)(6486002)(478600001)(6916009)(6506007)(83380400001)(186003)(38100700002)(2616005)(43740500002)(45980500001)(11215385002);DIR:OUT;SFP:1501;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTI3UWtUcXpoc3FvazhxeXNCbkt2VERzWXI0d3NLOUtPcnZvZ0g1VW04VXhU?=
 =?utf-8?B?c0lMTlNYdUU1M1kxV1BqYmtycmNlc2UvS0d2S2o3enFhR0MzQnFwdWQ1SG5G?=
 =?utf-8?B?eXJ4d21BTjl1OTNRWFFkY3NUekkwaXgvcmE5ZkF3VFZZckwzUnByTzE4TmdG?=
 =?utf-8?B?anBvb1ZYM096YUo0ZjdTSVNLRVZxTlBabFdEa2kxV0RCc0h5QnFlT0JTZ2J1?=
 =?utf-8?B?Q3VtMXdScUMydStwaEhIWENINzY0R3EybmlLb3FRSlBPeU9vSTI3QytDWWhT?=
 =?utf-8?B?Y29tN3pGL3VvZmRnd0gyY20zb2lWWUVvWHJZSVhNSTUzSDVsWmVGUk5tU2sr?=
 =?utf-8?B?aHd6aUszaFlwMG5sZjA1Vk9YNDFOTUhYdW9hSm9TZWFBUEhXVWJMd2ZJR2Ft?=
 =?utf-8?B?V3NUZDhKb2FjRzk3UTFQYnRBTjUrREpHUVNiRjlYNVc5cHBKTTNKcGJxRjhv?=
 =?utf-8?B?MXpubVozZEpSaSsxT21NZ2pKK2NFQ0djNHVwYWRKSW9JdzVCUmhCSTZQQUFl?=
 =?utf-8?B?ZXJUSnpiMTJaWlJzU1FoZDE0cXgzZjVwaGtkK0VhRi9wMmdjc3dvY2NhUVZZ?=
 =?utf-8?B?VndmSlJCU014Wm14NWJSczk1NGtUWDltOE1HNjk5UmZ0STJYbUJpdWNmYkE4?=
 =?utf-8?B?ZDdydEFQMkJyUHN3TmMvY01KUmxmZ2hsdlVyVENtamhXMFdvQkczR0JMcFJv?=
 =?utf-8?B?M00yVUNHQjdWcUdsRXZSRUhuZUpId2I0dCtmYVF4MUpxd2JDWVdXZUltbUhM?=
 =?utf-8?B?MWFLU0p0dlA2c0lMeG55dDgzUEV4YThkKytvWisvTGJCL1lDNHBnZVJOOUVM?=
 =?utf-8?B?bHYxK3J0QTl0VkxVVWZxbXZ4cEpjM1lpU1ZRQS9RN1l2U3FGSkJsRXBMSzA4?=
 =?utf-8?B?bkM5c2llaVlVR0ZUbTRmZjAxMTU2bUNjbk9MTXBlbUhaLzZXdGVZRlNnWDI5?=
 =?utf-8?B?V1BmcjdHd05vKzdkdGpaRFI3bml5R2NYR0lJODR4NDQxZ1A1L0FGMW5WU0FT?=
 =?utf-8?B?WkREL3dlOWJwdnUwWDY5cHpRR1BicEdCQTZLR2pJYklwYnUyNXNlYkhaclhM?=
 =?utf-8?B?MkVUSmUxOXRITDNTZEVEMFVpWnB4RVZyL28rRGN3ajlYWk9QbVhuNGY3QnNM?=
 =?utf-8?B?V01YUVlUeTZFSktkNk9oV21tVzVZbCt2d0RrM1NtaFhFOGFkQ2tMVXZvRTRs?=
 =?utf-8?B?eWJXTWk5Y1hqbTNJVDg3dklHTS9kK2dMN2tya0VSbHp1ditDQ25XdnZMZmU1?=
 =?utf-8?B?TCt1R2VIN09IbExOaWNvWnlaVmxuVWFDbldGc2daYUxlaVEzU2dzdW5hYytI?=
 =?utf-8?B?ZURRejNhOFlSVEJ3NFlKY2Flb0hNVXI1WE13ak9kbkMwalEvcTBxd1ZqeUJZ?=
 =?utf-8?B?UDJsOG5yRmY4VHl1UVNDNVdRanEwVStNOCs4N2ptYUowOU9DZGFvOTZhb0J3?=
 =?utf-8?B?bTh0K1VKOXN4VXBKdXNyczE2ZFVXeVg0SWF4WllEYzBjNUVHT1NqNmVpRFVn?=
 =?utf-8?B?aEJvWThoVmxlK0ZpaGNXcW1CQ243eVdiOGgxdmJEUDliVDNjMDZvQmVNU0Fv?=
 =?utf-8?B?TUNnWDdRRnpOancwdjZkYVFJeUdvQVZ1NlYvN2VMOW5LejQxWTNzWDhXb3Fo?=
 =?utf-8?B?YVlkcU5TRG5wdTJLWW9RVm9MWTRWTHZXWEgzZWFDemgyMUZXaFBaUnhvTkJU?=
 =?utf-8?B?Wncwb0VtajdxRVVnc3FLSE8rVXRiTVh3M21tYUFkNG8xaWVRRG5uRXQ3K2pD?=
 =?utf-8?B?V2s5WjB3YmJjUENpSkp1VFcrd1g3NjRMaGx6ZmF1L0p0R1U2Zkg0MTA4MzRR?=
 =?utf-8?B?eXpJMytHL2ZISS9GWVlDN2RFU1ZESVFsY1l2TFRFWEtmbnZwV0FXclc1TzlZ?=
 =?utf-8?B?cXYzUnp3WDFQd0NLdlRMTkJ5SlJRVWVVTFlqS3dQaHEwRzFTdkxnUlBNZUVS?=
 =?utf-8?B?QTJ0c1Q5SW0vcmZpVW1RVmtFZDJtTVdDU3dPSm5LeEw4OFEyTTRGL2NEMWYy?=
 =?utf-8?B?S0lSakM1TmcrNitKQUl0K0tGamFUb3ZVUlY0K0I1K29ZVG5BL2VQcGVqU0Y2?=
 =?utf-8?B?TjEzbXRUWXJCeEFsYktJL2Y3WkZreVU0cXpUUVhzSDRkVThTRUhxZHhNcmFq?=
 =?utf-8?Q?loCya/MeEMC/QJ07nvA8c6j3o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2203ba-4bec-464e-d108-08dab5ecd424
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 18:23:20.4938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VkCiuVU8W1rPOtOiJYIv8J9G6/eNy7YTGqXTvdLemyIfSEWjzqhnWOjQk0FYuu4gd6NASz5xeIGCB/s0MQU17g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5484


On 24/10/2022 19:19, Ayan Kumar Halder wrote:
> Hi All,
>
> Please find the following patches to enable GICv3 for AArch32.
> This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system)
>
> Let me know your thoughts.
NACK. Please ignore this. I have sent by mistake.
>
> Ayan Kumar Halder (12):
>    Arm: GICv3: Sysreg emulation is applicable for Aarch64 only
>    Arm: GICv3: Move the macros to compute the affnity level to
>      arm64/arm32
>    Arm: GICv3: Enable vreg_reg64_* macros for AArch32
>    Arm: GICv3: Emulate GICR_TYPER on AArch32
>    Arm: GICv3: Emulate GICR_PENDBASER and GICR_PROPBASER on AArch32
>    Arm: GICv3: Emulate of ICC_SGI1R on AArch32
>    Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
>    Arm: GICv3: Define ICH_AP0R<n> and ICH_AP1R<n> for AArch32
>    Arm: GICv3: Define GIC registers for AArch32
>    Arm: GICv3: Use ULL instead of UL for 64bits
>    Arm: GICv3: Define macros to read/write 64 bit
>    Arm: GICv3: Enable GICv3 for AArch32
>
>   xen/arch/arm/Kconfig                       |   2 +-
>   xen/arch/arm/gic-v3-its.c                  |  20 ++--
>   xen/arch/arm/gic-v3-lpi.c                  |   8 +-
>   xen/arch/arm/gic-v3.c                      | 132 ++++++++++-----------
>   xen/arch/arm/include/asm/arm32/io.h        |   4 +
>   xen/arch/arm/include/asm/arm32/processor.h |  10 ++
>   xen/arch/arm/include/asm/arm32/sysregs.h   |  80 +++++++++++++
>   xen/arch/arm/include/asm/arm64/processor.h |  13 ++
>   xen/arch/arm/include/asm/arm64/sysregs.h   |   7 +-
>   xen/arch/arm/include/asm/cpufeature.h      |   1 +
>   xen/arch/arm/include/asm/gic_v3_defs.h     |  24 ++--
>   xen/arch/arm/include/asm/gic_v3_its.h      |   2 +-
>   xen/arch/arm/include/asm/processor.h       |  14 ---
>   xen/arch/arm/include/asm/vreg.h            |  23 ++--
>   xen/arch/arm/vgic-v3-its.c                 |  17 +--
>   xen/arch/arm/vgic-v3.c                     |  26 ++--
>   16 files changed, 242 insertions(+), 141 deletions(-)
>


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:24:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:24:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429330.680288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on27R-0003PE-7w; Mon, 24 Oct 2022 18:24:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429330.680288; Mon, 24 Oct 2022 18:24:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on27R-0003P7-57; Mon, 24 Oct 2022 18:24:13 +0000
Received: by outflank-mailman (input) for mailman id 429330;
 Mon, 24 Oct 2022 18:24:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on27P-0003Ms-SQ
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:24:11 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0d4ed4cf-53c9-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 20:24:11 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CH2PR12MB4103.namprd12.prod.outlook.com (2603:10b6:610:7e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Mon, 24 Oct
 2022 18:24:06 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 18:24:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d4ed4cf-53c9-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k7G2iDyQE2kqLJExg2Gy5UHAStagd/ciqRvx2s9diXInK/fuWdDzyKrdAf6tPBVzSYzo0MsD/6kRFRHHNuzq97v6jvyC0Ml/F4cJUv8MnlZ87SeplIj/JyMdylEjEfzZjQYE1IGl2qrlBqZ2fN/V/c/pcIFiIvJ2ElFb4azKirRmo6AfPj1cCJ1OD8dHq233+eJlIDCbTGlic/kZN0RJU8Dyc2HuOu+ObBFFmukwXsGvV9X7tp5sHfRy65XuFexIu21V8e2iKhhA7y5ctLpHIPQfoGdyL4dikgHAKIr6MYzQoCKI4l7f9WOuBYY3Re5IwLsyb7nvmFvEi/qkKSMoBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MeJ/sUw4e5ZI0zFYwZA414Hze1AbzQ3gOj4SPGbq2Y8=;
 b=kq+Xs9YSfqxQm8b/kz1iIgjMBnmxoaPocI4S2jiqBLMfejTGa5K/U3YuCVz6cf2aM0NmG1b9dTiDV3J04mgzX6sR37YaO3RqmPbDy+Uwqj6VU+JwY7XzJAm7m1OluK+u6LojtQhiAv0mMH2SgJvNKOq9HaD8n3RyXdsdY1+rb6vM0qeyBvlHQafkSw64ax4hSGwmqP9pe2k3VaVWHH/a7vuq3F1/1vynoMZSHRS7j+OxebFYhFWtihNRJpTGfMXx+spNESYFlFeBtYLD6a5FscTQaMvmxit1dM6ROdK06wRuL6TCKVRJKxRdr2+ppGgv7Qdt5/1DA03PdyqgsaDT4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MeJ/sUw4e5ZI0zFYwZA414Hze1AbzQ3gOj4SPGbq2Y8=;
 b=SyWXKUHKojN5IN1jUM4RX3+lwcm0p8e4vXz6ccM+x6aqjJcvKtxMuV8FYteQcvkGCE4biL/E5p3IA7jB05Ibddj1g8EeE6FrYeXSMgxA6bqDUXXTt65P2DyMNZWvEudgVucmhUAXrM8iKW5NVxtXYAmTDMXD/JggsMp8sHSPKvU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <a31a753a-2e2f-8191-7d48-af96d9bd43b0@amd.com>
Date: Mon, 24 Oct 2022 19:24:00 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 01/12] Arm: GICv3: Sysreg emulation is applicable
 for Aarch64 only
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, michalo@amd.com
References: <20221024181917.60416-1-ayankuma@amd.com>
 <20221024181917.60416-2-ayankuma@amd.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221024181917.60416-2-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0424.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::15) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH2PR12MB4103:EE_
X-MS-Office365-Filtering-Correlation-Id: bd311988-895e-4247-59fd-08dab5ecefae
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	l/e/ZNwuqHojPyhU/gWWQ0aFwN22eHqLs8d9r2CrKkkx8CfxmgY3sJfvH5vGs90uYjQgmDst836L+dvglLG9WfLTulmRyFwZ+Ojhm/qcrk3w/tb9p7ai0bllym6M1O40540oIdxRg/tr1fhqEVZGpJ2uleVu+SCCD63McUF0J8QjLH+ZP+rkeHHxSi68z5RlzpvOszw5g4iDdXSgfgD6xN0hGxQBvALRRVZkpz4TMCC0Bjx8pkvp2XOTvt83ClUfGoz0kDwxuTf2UPOVX0zsIIBAI6AqTkxy3kn/obm3XttrubD26m/LNBWONaLbq5KLKFI01chg1noaNiRX/0TuGaZKxVeCgApuDSBjcRHna4G69WDfkTYtznWCnIQ2PM1HqdA4fRZVQqUR3B5W7UxaPtcjHiDDroK+e/a/mPrbncuaVw2ccCW96TQcXTzrfvd5KvGRuKDHl5gAeJTQG2xWuBlQ/zF735H1CAG0/9GmI7FMb9vfWNVRzgFrvjgsZDaooZ5UDRO9dxZ6+iv9K5732X2hHuMt1CVOQ/6DzsRj8L9DRnusKdPgoLBQzuSEIMnvkn9/mLdhTtALjYNo8+Y/tLkbRr218IMNpnuWIPgWJNSo9vgHqU7IWgprKMdPI9FXkI43Ew2VJX+1SW8tR7W4Mr9q3DyID4qz6RutEcQCuZP/pnPeecwqYyfDtidYcaEBp6hyP4oTH4LB/D8mhMAj9Hddv4/M6EilRJq0pb84LxzsXL5Lx2x84ylMXu/fq40rIJkISDGL8M6F5aSrx97RYHjDSURcpNeKvP6Hz4yg7Ck=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(366004)(376002)(136003)(451199015)(53546011)(31686004)(4326008)(6486002)(5660300002)(8676002)(186003)(6512007)(478600001)(26005)(38100700002)(2906002)(36756003)(2616005)(8936002)(316002)(6506007)(31696002)(41300700001)(66556008)(6666004)(6916009)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aVB6T3M3TlRIRnVqamdLNkV5enB6RUUzSWtrR2hLaTIxVHFPSEpnUXdCWFFn?=
 =?utf-8?B?cDlaNlVsZHBkcmFYNWhMSnJITWs5RXcrNk91OFZxVnpIcER3RU56a0d5MVhW?=
 =?utf-8?B?bkVTNmplUVhhQllILzFDbDg4NDBhcTBNQjhSOWMvemltNnhXRHNUSjVHSC9H?=
 =?utf-8?B?ODdzNmpBUlcwK0JpU2NqSzZEWkk2ekg0T1IrM3VqUlhSdlFMTVNPelVMSXpG?=
 =?utf-8?B?aFduMHlRWWk3SWFycDRxaHV0b3lmWEttUVBRQUNZTFIvTEY4Y1JTLzFncW5X?=
 =?utf-8?B?bnE5T1pZeGhmdlhCaWQ1RnRIeEpXWFFqZDlJQm9iN2ZsK1E1TEt2UVZneXdh?=
 =?utf-8?B?Mm5PYWtnOVR4WktNVDJ5Y2xKa2tWTnQvdUVYbm91T1g1NVZFZU5BelA4Nk9H?=
 =?utf-8?B?cm82ZlFFWkhIV2owSHFGbng2K2wwQjU4YnhDR1NWTWg1ZjhybHRWOE1iOWt0?=
 =?utf-8?B?K1l3NmpzY0h6MFQ4UUtLN29iMHNXSmNQNnRrT2JzTVJiZG45QW95ay91ejQw?=
 =?utf-8?B?dzV0UzhLUUhkd0xhTStkRVp6RU5HQ3k0WVFOM20xOEJpZVZoR0Q1dnRuT1I1?=
 =?utf-8?B?SzdVeWM5R0d5REtXSU1hR2N3STY3OUtSSWJRZlJTRkhuOUxycHhnSXpXN0Mr?=
 =?utf-8?B?OHkrRVpHZGlIeitvbzc2Z08rQmZhWXR5dnlQdFc2YjN2MkczQTBwYzIyOGtz?=
 =?utf-8?B?Q0VXSmRPM0RkaW16bmY0MDd3VDJDM0QwVDZLWkh6VlBkbzJLWDl2UkVndW0y?=
 =?utf-8?B?YnZTRnEzRnV0U3U0SE9oVDM3TTA3TGl2MnhhdlRwV3dKd3pNc0M5Mnl5UUNJ?=
 =?utf-8?B?MzZGb1kvekc4ZCtYZndsVjR6a2k3RjNrLzFKaTZMdVo1ZzU1NWlYSGZSRmZX?=
 =?utf-8?B?cGhNbzYrRGVLcTFWSFM0eS9iWUZsZ3M1bzFvVnQxbXZTUkhoZEVOYVR2dURp?=
 =?utf-8?B?b21md2ZTc29YQkFYVXNZdG9JanNrTmtucS83aHJ0RU1mOHhZUjI2bGJ5TWNU?=
 =?utf-8?B?Q1M4VDlEZ2ZtMDN2R0ZnMnNsd21vb1FKbTFuZ0Iwc20xVFYrZVdEREt5WjZI?=
 =?utf-8?B?WHNZWklHZUQyeHdPWTF4aGR1YnZsWFUzZlNwank0ZDd1c2tHMy95Mml2UTVy?=
 =?utf-8?B?MktKRTh5ZERhUG94RTBJVTNDektrWFo2bFc2UUZtWkpDUW9MWHN5SkpoM3h4?=
 =?utf-8?B?NmVZME41K1Jzbnc5RXBGT2pELzNKS1I5VEV4ZEVCdjRpamxzaTF5NnJuV3Q0?=
 =?utf-8?B?MHFNZW1QYjQ1UER3akZHcFpTWU1CVlhTdVhZUzNlQWZoMFRTUjI3eW1DVjgv?=
 =?utf-8?B?c0JCL1pwZ2gyeXZOWkg3Q1NoTC9SVlJMWGJNWHRCcUxHWGNIWnJiZUQwQWgy?=
 =?utf-8?B?b2lyMVNJTUhDOENYU1puUkZVSnQrM1Z1OUFVL0Z5RkFrU01LclhORCtHaEht?=
 =?utf-8?B?VkNLUUVvN24vYmM0K2VQUHFUVzhqU2kxN2VHc1cwblJIeWwzUnFIeU40ZkVY?=
 =?utf-8?B?dStSeDZxOFozSkJJcExXV2EwdlZJaTNrOEVkQXNmSnJzeDlnbEp5S2Y0ZEdT?=
 =?utf-8?B?LzNpSHN6dWdnYXRnWDBVbUJDYWF5OFdDMkJHa0tGKytLN21odVJyZUtING1i?=
 =?utf-8?B?WDZHUEpTcEhmWXViMmh2SVFCd3M1cm5ScWVWNFVOeEsvQ1ZoYWlHYXpRZGxN?=
 =?utf-8?B?TVZVS2Y4ZVZRQ0loVjFWWVdXNDB3UzExQmJIbGYwVVg5NUxxampxYnhTVkNE?=
 =?utf-8?B?TG5ZcXB5bFc5cm1tMzMreTFHK25EYXc1T0ZIMWF4VkN6YlIyUndReVhVSmZY?=
 =?utf-8?B?cHNkQlJXM3k3Sys5bm45UGtPMkZKWFAwdTR0VktlUEZhL1BJTDBCMWtiR2Js?=
 =?utf-8?B?VHRVaUNIcHAwb2Fyb0NBNVB3Y2Z4M1c1RTJDUFBxYlI5VUFXWFVuRm1ONzg0?=
 =?utf-8?B?ZnFDeGQ4MXRyd21zbHZrakFja3MzK0NVMlc2WFZZc2x4cEFPOUpPN0VldVli?=
 =?utf-8?B?UEVsOGgxdWxMM3NZeEwyem01YUhVL25QWE1ST1FDSld5R3g3dk9oYzBWOStu?=
 =?utf-8?B?WFV4UXVnaVNXdVQzeXFKTG04aGcvb2VQa1BDRFBKV2lkcktITFBUQTNLQWps?=
 =?utf-8?Q?wbIlrVJPLvXkQHmIuJmjpqFKu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd311988-895e-4247-59fd-08dab5ecefae
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 18:24:06.6311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PufghB+PMXebkgqgzYyyO+7GCc2e2j3xCCyRMI3A/iYr898Me2qIzf2Xt3+3IFavsYjkFbeeO85RSz6HACcp1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4103

NACK, Please ignore this. I have sent by mistake.

On 24/10/2022 19:19, Ayan Kumar Halder wrote:
> Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
> only. This is when MSR, MRS, System instruction execution in AArch64 state
> is trapped, that is not reported using EC 0b000000, 0b000001 or 0b000111.
>
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
>   xen/arch/arm/vgic-v3.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..c31140eb20 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -1520,6 +1520,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs *regs, uint64_t *r,
>       }
>   }
>   
> +#ifdef CONFIG_ARM_64
>   static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
>   {
>       struct hsr_sysreg sysreg = hsr.sysreg;
> @@ -1540,6 +1541,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
>           return false;
>       }
>   }
> +#endif
>   
>   static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr)
>   {
> @@ -1563,8 +1565,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs *regs, union hsr hsr)
>   {
>       switch (hsr.ec)
>       {
> +#ifdef CONFIG_ARM_64
>       case HSR_EC_SYSREG:
>           return vgic_v3_emulate_sysreg(regs, hsr);
> +#endif
>       case HSR_EC_CP15_64:
>           return vgic_v3_emulate_cp64(regs, hsr);
>       default:


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:25:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:25:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429336.680299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on28l-00048P-Me; Mon, 24 Oct 2022 18:25:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429336.680299; Mon, 24 Oct 2022 18:25:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on28l-00048I-Ja; Mon, 24 Oct 2022 18:25:35 +0000
Received: by outflank-mailman (input) for mailman id 429336;
 Mon, 24 Oct 2022 18:25:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on28k-00048A-Gi
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:25:34 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2068.outbound.protection.outlook.com [40.107.95.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3e810d53-53c9-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 20:25:33 +0200 (CEST)
Received: from BN9PR03CA0320.namprd03.prod.outlook.com (2603:10b6:408:112::25)
 by PH0PR12MB7078.namprd12.prod.outlook.com (2603:10b6:510:21d::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Mon, 24 Oct
 2022 18:25:29 +0000
Received: from BN8NAM11FT079.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:112:cafe::f5) by BN9PR03CA0320.outlook.office365.com
 (2603:10b6:408:112::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Mon, 24 Oct 2022 18:25:29 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT079.mail.protection.outlook.com (10.13.177.61) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 18:25:29 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 13:25:28 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 24 Oct 2022 13:25:26 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e810d53-53c9-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KnEey0Fjx347cCS6a1ye5qSl/p+sKGt87jVhmjJk1Qnpcm+m4jlHaFBTzrzqtnh0O4BmZi+63zNFFDNU0G9Zopd/Qn6BOG9670EDIgxhmXBpLadJ5/Tg/R7OfD+cLZCfHUGvT5brbSND8SXR7t8z/8dGvZJ9bOokEsgcOQ1+MXyrmVU1KeNlhYtiqWGbAS98WO9LFCpEK5kyDj7fnkVOS9GvX6HrLPkOKcanPpaVPLVRmmHo2sRdoc/I/31Hpo502LwfM+RJnMl/TkJIl/BuLxsTDt7KCfnjPxf+QQf1imJOfBDTxTGSi1P0kCl9+Uq0uTBYppmpA6ck94YJBLbQqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9MocgCiMwjGKC6jmWCbUClFO/S1BbEXwKRDuBTLT5nY=;
 b=ae57cdxg7/KUY9t2yvhuRXgeMCwPfHh9AdTHcxS13gSmhUVUvugjfJ0s6gDgNSQjOwpVk7no0VOHbDP6nrZUvXUxQuzMiBUcT7NCQnzanpiCaKxfCDfyWWFCsZKgy9FrLlSdVaiuy9pv0CdkqTE2Dq9Xz8hGCBlmDJ45Qm10xx00h2vEqjydH3J2VtgsFmP9pEq7EknGDRia8tK7ng9ttQvNoIacjnUVTU6Kf00gbD4p7jSCPEaqwhUhmttayGx4ERYVF4Wtb26IWPYkGwZchUYWREisSo2V0KIGFoydlPFtqgg0kcfvdXIc+z/G0DnVg606q9afbKO/FHWP8ncqEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9MocgCiMwjGKC6jmWCbUClFO/S1BbEXwKRDuBTLT5nY=;
 b=pQ1x494/c5WIHjAZhCxUfVIIQLMtpmOvMN4PKSbaRET69I+pUmmCXScmD1KKHx4GdOWXdKJnBEmtl0TH9XAx8OeMPLwg/KNmGNppCIH2apA1WFEiuuol5u9c99NQ6ss0NZ5/gzg3VBJVq43ZzpBhOdJxJyuNe+zRVB4ddr75CXQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>, <michalo@amd.com>,
	Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v3 01/13] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Date: Mon, 24 Oct 2022 19:25:18 +0100
Message-ID: <20221024182518.65002-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT079:EE_|PH0PR12MB7078:EE_
X-MS-Office365-Filtering-Correlation-Id: 2a2da696-f8e8-4e1a-5d68-08dab5ed20e8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v8XQ8HA17MSaPNS3CXX+muZklSQuTNVzr9ug7J46vBVW/zYD+5hxpZRPYe8Sy3sMZJsjNnMivIDjJwiBIWPm8Gnm9DTfO8IIDZxoiPVGyEK+4WqwgOK2Gebl/Nw1U8otAo6oWDIQkrgG+BxL9OQVhLb5SnV3XYjfDeUROQ2IEJS7UNsdZV9BGry9N87VgcBuxariyD1E7VvuQQB5S9tvdi3pdo1KIszCn0WHBCFDM/cRXr9mTJmRwlbYYwzB9rUwo6kXEsG6Wgc8hJyui9EA+iROtX1mBwAnO37s80YoIlCDbpPs3k+FE3APf8bOkBDnjzf+Nig5TASWHTBOswFa+3PvR/yRwuEjjyLXflL+BOCpxcr0YzC0VXE8q340eeTSg0FOwWxo1v0n/HvrVp4NohP4mAuKZOQJe9dLUG83wctkyudDe+T30mcJyFAh+pv4YfXkD2j/R2exORsx16CqtoOyprx9jL9QouNvwOe57jUVtzyyN9wcFZ9Rzb7b96dNrCCVHjoX0cisvE93u013453B+r8GdWMqtpemgErPxHR1fEHkzXQdVOrW7WmxnfsSt7k0+bUTKLK8CxSZA54YGd009vEHCDML6RG4AMPULntBIwi1Zn3yMRQYcQ5R3eBfCWzfIBAPmEWPpyYd8bjTqWs96wQE4hgg8uWjTx0WXq/4jDFrYhKt3E7pCwIgBRBkaGPokzCBg/RCwL1ot3CnKe0Q5dEVs2QP2QPx53qvxaZxA7pe3Zv1Ax5VJmQIEAtcLOAv0CvS5ZqoLSA5CmENuOBqRn9lY6btyzt/UtXf38g=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(36860700001)(36756003)(1076003)(478600001)(83380400001)(6666004)(47076005)(81166007)(356005)(316002)(82740400003)(426003)(40480700001)(336012)(2906002)(2616005)(6916009)(8676002)(41300700001)(54906003)(5660300002)(26005)(4326008)(186003)(40460700003)(82310400005)(8936002)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 18:25:29.0009
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2da696-f8e8-4e1a-5d68-08dab5ed20e8
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT079.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7078

Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR is emulated
as RAZ / WI for the guests as "GICD_CTLR.ARE_S==0" is true.
Xen is currently supported to run in non-secure mode, so guests will run in
non-secure mode only.

Also, if Xen was supposed to run in secure mode with guests, the programming
of the interrupts (ie whether it belongs to secure/non secure and group 0/1)
will be done by Xen only. The guests will not be allowed to change this.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Observed the issue while running Zephyr on R52.
Also, found that KVM has similar behaviour.

Changes from:-
v1 - Moved the definitions of GICD_IGRPMODR, GICD_IGRPMODRN to gic_v3
specific header.

v2 - Updated the commit message.

 xen/arch/arm/include/asm/gic_v3_defs.h | 2 ++
 xen/arch/arm/vgic-v3.c                 | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 34ed5f857d..728e28d5e5 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -30,6 +30,8 @@
 #define GICD_CLRSPI_NSR              (0x048)
 #define GICD_SETSPI_SR               (0x050)
 #define GICD_CLRSPI_SR               (0x058)
+#define GICD_IGRPMODR                (0xD00)
+#define GICD_IGRPMODRN               (0xD7C)
 #define GICD_IROUTER                 (0x6000)
 #define GICD_IROUTER32               (0x6100)
 #define GICD_IROUTER1019             (0x7FD8)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 7fb99a9ff2..0c23f6df9d 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, read zero */
         if ( dabt.size != DABT_WORD ) goto bad_width;
         goto read_as_zero;
@@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
     switch ( reg )
     {
     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* We do not implement security extensions for guests, write ignore */
         goto write_ignore_32;
 
@@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /*
          * Above all register are common with GICR and GICD
          * Manage in common
@@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
+    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
         /* Above registers are common with GICR and GICD
          * Manage in common */
         return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:28:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:28:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429342.680310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2Bw-0004mM-4j; Mon, 24 Oct 2022 18:28:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429342.680310; Mon, 24 Oct 2022 18:28:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2Bw-0004mF-1V; Mon, 24 Oct 2022 18:28:52 +0000
Received: by outflank-mailman (input) for mailman id 429342;
 Mon, 24 Oct 2022 18:28:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on2Bu-0004m9-Nc
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:28:50 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2048.outbound.protection.outlook.com [40.107.96.48])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b376bd83-53c9-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 20:28:49 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM6PR12MB4561.namprd12.prod.outlook.com (2603:10b6:5:2ac::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct
 2022 18:28:44 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.026; Mon, 24 Oct 2022
 18:28:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b376bd83-53c9-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VPNePxQA4cOTUo728MT7/hQl5lVXaD6BNj3yhlusRDe5xoIUCGcHC6qGNuBA3WQ9UrzID2004YdkkxguTfGNh5ApslMXgt4+j3VpTdqNzJdwECe1FyFs5s4SrH54AhYA8JAL4dLelBcJmpL3TfVeXVCMmczDgXqmmuTPDx5btARhmaNs+DpRnDDGHOfBm1Qx2PMiFJ+pUlU/P3nl3ewbCLytPuRZ2bLXx7fuNKHGkMyfe9SaP0m98VbKgIS3F+OMYaBqHUy2QlejStvr9HnUlrj1Njnps36ma4KsUI3Rgq+UtD4+8FRVTLXJPssC3M2nhYB1+fKL77YHUOi9RKjAyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ipa5zbm/riYkk9XDmnfmhMaJUxeYgVAjYPpTlvYMJho=;
 b=Ruchb+rBlrpZeVC1fw5vqTBCeKZ6E4qmsgVcbdN/3RhRhqQMVYyhfR+8FXRLcwTZod/uLm0yhaQH4xW2clU7cOW2G5Po+k/2qMr8bUyyOS9VdaOJYFvDppwS96X198EgtfAyspbWQK35bO9/nt7qxP/T641kt9w5v459toaMphqPfsxyn33z/Opm6nEGMvlrtO90TmWYVg9NbkZyJnkk2kFnqziXkb3dTdiIpU8Y8/5Bhia8TtVmzNMEbX2RQAE49CRUrjLJSeYV+mMm2Y4lh1hTaOxDfCRAW2+E8G0J2QM+Ohd4dVjHDRzaTr34eRXyqkw7EBWIvRfwTgelDM9jRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ipa5zbm/riYkk9XDmnfmhMaJUxeYgVAjYPpTlvYMJho=;
 b=ndIxmnw4FG2a+XEORlejAZAUl8F64Y9QT4v3K9oIZJKZYoqX0JG3bowlnmRFv3byGJatKTLxFOxM4EtWjQ3Bbnsg2HJ8/LwME9F5kSoS7Q0ri7JwgJrdDurXeaq9L/9z2ym7wsXKGIEdTSmxwygLc85X69f84d7mdaJpqMQIdII=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <3c37a51f-5286-ea84-8497-4b1f25014c04@amd.com>
Date: Mon, 24 Oct 2022 19:28:38 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v2] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "stefanos@xilinx.com" <stefanos@xilinx.com>, "julien@xen.org"
 <julien@xen.org>, "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>
References: <20221020104146.29841-1-ayankuma@amd.com>
 <AE2C68A9-4276-444C-B227-F079D330EB8A@arm.com>
 <ba43677f-903b-f30c-76e4-1668cdab2cc2@amd.com>
 <F8CD5734-B62A-403E-B888-AA24053A9F03@arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <F8CD5734-B62A-403E-B888-AA24053A9F03@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0661.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:316::15) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4561:EE_
X-MS-Office365-Filtering-Correlation-Id: 0b9da197-6563-4bed-66e3-08dab5ed955c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nC9MF5cmRdGVUD46hWuzvUxvAO7gu8uxx5YGiWs5FcslFIkLSL1V4XVygBu9oPMHQrvCrGRMslZDtjVM8nNGEWPXw2nquRk14Wpy7JQ7RewEngh1PftO7lVbJp/N2H7UMqhevSaEA6hejbksf2Y9nBMHVpmVkg/k//gRhnRMvrRbJcWTTsWdssjCJ04UcFNM9H1PO2rHDOV8v3WZVZBu/DuoPfntz3MnjwXUOTduQKExZf6/Mig5gpmFGHNAteMqLihY3tD1xCTXFNkNdInj30UWvAsGCfveXY+A41EM6UKTHQSK4m6fmglH+YV0QHhrxyT/v2FRFpdlNoYiM5K6Mz+aL31n5equsLDnc5Ge2e/duRS4IctZTs2+KVUps6ruNLfO1TZPcWSJFJ+bCA75KIk5gtHnjyhKIvqCgn37eyOcEh0AnXMqYAkMLdrVp+pJzHA4jnsoyEtvt1H7TGCRkju6nYNTBiSnEvnzU/YgKskjY1YxmxrsBI3NAYHTGoRUmqBaKnOxIZ8Z4ACVhGWCvPyrucG3BFiRk0Np/JTI0DSi/rL5Q2t4jahKKs/TFAm9a69jlMcqnIM/NVrXybJ4wPZvBZ5nz7kgCOy5liPD+1EfDsc8Pr/I7g+D0KwAOvIG3oB1AryCc+T7rpFiC86/1xwa3avzXiNcPsYwDGUfZW6kGqmK3epWrsjQYgglw/xgnxhBg1lawXz8fptxWrMfTyTHt8QAcTiLkrzXda3Zrc21fm8X9+mZfaPdFxuaFLZbJjFgeCY5FG9y6/FenBhH0xM6W3rvakJr0mIoW3aWEG2JD4G7gph9MUqqGXnzEujf
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199015)(2906002)(6512007)(8936002)(53546011)(6916009)(5660300002)(2616005)(26005)(54906003)(41300700001)(316002)(36756003)(6666004)(186003)(31686004)(6486002)(966005)(31696002)(83380400001)(478600001)(6506007)(66946007)(66556008)(66476007)(4326008)(38100700002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZDdFZElnMWI4eFZNSTRlYnNaVnUzTTBreGVtR3pBeXhCald1M2UvanpUVTBr?=
 =?utf-8?B?cG5tY1dlbnFQR1NhWlRySVFtSFdCWk9hYlhGSHlSV09aeFM3akp3YzZ5eVdF?=
 =?utf-8?B?dUdTQVBBekNyQnpESlJReUtOOHl1akxSLzV2TlpLS0tNK3VZVnU1SUFrOHE4?=
 =?utf-8?B?SGwwdzQvNWVMQVZEREZTWG9hVWRxSENuQlFhMU81a1RRdGUxMmpZNDdZeGJr?=
 =?utf-8?B?Q2RZbHRRbnBuckNsb2RRTkhVRU1pNzdKbUlWbDRRZWE5R3VKMFphcXhRMEQ4?=
 =?utf-8?B?QlBSN1BmdmlHU1JMM1JjdmFTVWVDWWFlL0RpVzQyLzJ5Vm0zZWxnbUh5NGIy?=
 =?utf-8?B?a0ZPWDdoUE94U0ZxSWRXelJKWG96bGdQNmhjUFlLa2NCcDg3bnBIVTBBOXlO?=
 =?utf-8?B?cU9KbVRjU0tZNzlBMGR5cXYzblZkM0pML0dqNmxLN0lvdC9XaWVCb0NHYjFX?=
 =?utf-8?B?UmUrUEJWWDMvb3ZDaVdIUFJIR2lqbm12NmtzWVc5RG9ZcUhnZFpqWk11VW9I?=
 =?utf-8?B?YWpSeWRCYkZEbHNlNjBOTzJrZDQxQ2I0SnZpcko0b1lUbXQ3S1JMZ0hYbE9S?=
 =?utf-8?B?U1hOd2piNWV3cXRpWDhyZWMveUtYWHFuVUtOZE9Jb0JRMmljYjhkQ2ZYQnly?=
 =?utf-8?B?bklQMWJKMUtLVlo0L2hhWUJHZ1JKVW9VZE01NkdCYUZEdVR4WDhPdUozRy83?=
 =?utf-8?B?K1VkYkZGSWRHU2tORFdjcHU3a3pMZERwZWpGcjNQT2h2dkEyck11YWlWdFdR?=
 =?utf-8?B?dndXWVYvdS9pVllrVFppMStwaVc3K0JsSUtoSTJ4ZFB3d3hiR0pXcmNkcHlF?=
 =?utf-8?B?SUFRZTdqR29KblhOT3ZKUGQ1ZXplN2s3TVdvY011bFZrYVFtVHJZcDc4dE45?=
 =?utf-8?B?TDhzOXhYZFdyUU9NU2pvNDBSOEdKY3YxY3h1cEdMZTg2YXBQQS9oV1N5K240?=
 =?utf-8?B?elBJaGc1Zm5rSXFpVXZzRSt6MFdkc21Wb09UczkxUWFJd0toSWFjKzdrMG4v?=
 =?utf-8?B?ckQ4cXBCR2gyL3k5Y21LbXA0RDZReUpkMzJPWi94emVNK1Vrb1R6SEVhTTZo?=
 =?utf-8?B?R0ZHTnUrNmx1Z0owaDAwc2pJdUNyTXhWMUhEWGFneUNDb29tSnYxcis1aXFN?=
 =?utf-8?B?cTErdnlTYStPaXRZR012NmdhQXBuTHdlZCthQmtJd2szV0owdmpKeFZHczh6?=
 =?utf-8?B?Y0piaUJHaTN6MVpGVEtiWEdQWkUxRDB1bWx3cmFzcmtoTkw3QmdJenlMdm9B?=
 =?utf-8?B?R3A5Q0JVOXV3REMvTUFGMlBZS3oyVUQ2SGlTMGJXOERBTmFvZGE2UThIN2d1?=
 =?utf-8?B?d0RJRURSb3M2eXo2RVlvaW9PRTRwQ3pWTFFLTkRONENwUHBnZEdJbkZjdnB0?=
 =?utf-8?B?VVhqSDNPZG5MMHYwN1JSeVkvUU1JdGw0REVsc2N4dHNodjJaK3JzNlhMR3RM?=
 =?utf-8?B?VmJLa1d0R0d1bnB6ZVNVdUZQVVdtR3FRTkxpWmlicGlycUFhVi9McEN6cnVH?=
 =?utf-8?B?UHkvOGJDQWJWemliVjJzYWZrZCtCNVFabXdkUis3YW0zUTFVa2xRVzhsVDZy?=
 =?utf-8?B?Z3NwVENqS0NMUGNiNXNmTDNsNHhIYUxTVGp3MHRhRHd6OUZwOVVUa0F5L1BJ?=
 =?utf-8?B?aG5EUlRGYlNPWDhkZ3VWRjJRaUYwYWhoQWVCVTRKZDFJbS8zTnN0SXpiNTRQ?=
 =?utf-8?B?NSs4ZDdKbmZMTWFpYmJEWVFLQVVja1Y5Qzd6RzRqNlZvRE9KMFNGc1VPQ0Q4?=
 =?utf-8?B?OTlGWUhIZy9MYjFNU0hjeVpXVkJ0cko2bGpCamhBZE9pZnltMUYyNHhrNzVE?=
 =?utf-8?B?YXVFWGtSNVVTbzNBSWFkRWZmczVsQzc1eFlLOGZQTVNBd0xmNXFvRXVxdHQv?=
 =?utf-8?B?dGVQNjdBcWY2ckE5RkVDTjBtT2JyWGw0TlVjSUs1ZitKaUF6VURYa0RDRzhw?=
 =?utf-8?B?NnZkdEpsWDhieWRJUEZza0poejlQNjljc1J2SWRaWXlsUjluNnBBYkZYd2py?=
 =?utf-8?B?Tmp1YWl0bk55VUpPN2tDb0xpc3VDb1NoOStzZm9qa01KaE1YMTV3TkVoQk5v?=
 =?utf-8?B?SjYzYW1rMXlaVFVZVWRiZ2FNNVhsR1VmWmRMcnlzMG90eG1sR0FkdDVrMVdj?=
 =?utf-8?Q?Un0MtHxB9BA8q4dszPHao+XTX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b9da197-6563-4bed-66e3-08dab5ed955c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 18:28:44.6583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z/3Hz7PeEpJL8w3JdR3h+gXq/BNwQho11rXSpdFTsWM7pD2ZreSgZwWx6Fw9SOKpSvEte4gOGs2Jc+ZIxv460Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4561


On 24/10/2022 14:22, Bertrand Marquis wrote:
> Hi Ayan,
Hi Bertrand,
>
>> On 24 Oct 2022, at 14:11, Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>
>>
>> On 24/10/2022 11:06, Bertrand Marquis wrote:
>>> Hi Ayan,
>> Hi Bertrand,
>>>> On 20 Oct 2022, at 11:41, Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>>>
>>>> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
>>>> IGROUPR) is relevant only when the guests run in secure/non-secure mode.
>>> This sentence is a bit misleading as guests are always running in either secure or non-secure.
>> Oh, my understanding from the comment "We do not implement security extensions for guests" is that Xen does not allow guests to run in secure mode.
>>
>> Also, does Xen itself ever run in secure mode ? I thought it was no.
>>
>>  From https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions
>>
>> "The primary requirement is that the hypervisor must be launched in Non-Secure Hypervisor mode only."
> For a long time there was no EL2 in secure mode so that was not even possible.
> This has been introduced in the past year but nobody ever tested that apart from the work on R82 and R52.
>
> So for now, Xen must be launched in non secure mode, any other setup is unsupported (might work though).
>
>>> We should just say that we do not want guest to change the group of interrupts so we do as if all guests are running in non-secure.
>>>
>>>> As Xen does not implement security extensions for guests, so the registers
>>>> are emulated as read as zero/write ignore.
>>> I would rephrase this as “Xen does support to run in secure mode so emulate all registers as the hardware does in non-secure.”
>> Do you mean ?
>>
>> " Xen does *not* support *guests* to run in secure mode so emulate all registers as the hardware does in non-secure."
> A guest is always running in the same mode as Xen.
>
> There is a question for guest running in secure mode when (if) Xen will run in secure mode: what rights can we give to guest ?
>  From the theory point of view, it does not make sense for a guest to play with the groups I think, as interrupt management is to be done by Xen.
>
> So I think it makes sense to say that those hardware registers are not accessible to Xen guests as Xen will have to be the one programming interrupt to be fired in secure or non secure world.

Many thanks for the explanation. It makes sense.

I have sent out "[XEN v3 01/13] GICv3: Emulate GICD_IGRPMODR as RAZ / 
WI" with the updated commit message.

- Ayan

>
> Cheers
> Bertrand
>
>> - Ayan
>>
>>> On a side note, the question might come at some point if we support to run from secure mode on hardware supporting it, it could be that dom0 or Xen itself would need to modify those.
>>>
>>> The code is ok, just the commit message would need a bit of rework I think.
>>>
>>> Cheers
>>> Bertrand
>>>
>>>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>>>> ---
>>>>
>>>> Observed the issue while running Zephyr on R52.
>>>> Also, found that KVM has similar behaviour.
>>>>
>>>> Changes from:-
>>>> v1 - Moved the definitions of GICD_IGRPMODR, GICD_IGRPMODRN to gic_v3
>>>> specific header.
>>>>
>>>> xen/arch/arm/include/asm/gic_v3_defs.h | 2 ++
>>>> xen/arch/arm/vgic-v3.c                 | 4 ++++
>>>> 2 files changed, 6 insertions(+)
>>>>
>>>> diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
>>>> index 34ed5f857d..728e28d5e5 100644
>>>> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
>>>> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
>>>> @@ -30,6 +30,8 @@
>>>> #define GICD_CLRSPI_NSR              (0x048)
>>>> #define GICD_SETSPI_SR               (0x050)
>>>> #define GICD_CLRSPI_SR               (0x058)
>>>> +#define GICD_IGRPMODR                (0xD00)
>>>> +#define GICD_IGRPMODRN               (0xD7C)
>>>> #define GICD_IROUTER                 (0x6000)
>>>> #define GICD_IROUTER32               (0x6100)
>>>> #define GICD_IROUTER1019             (0x7FD8)
>>>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>>>> index 7fb99a9ff2..0c23f6df9d 100644
>>>> --- a/xen/arch/arm/vgic-v3.c
>>>> +++ b/xen/arch/arm/vgic-v3.c
>>>> @@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
>>>>      switch ( reg )
>>>>      {
>>>>      case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
>>>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>>>          /* We do not implement security extensions for guests, read zero */
>>>>          if ( dabt.size != DABT_WORD ) goto bad_width;
>>>>          goto read_as_zero;
>>>> @@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const char *name, struct vcpu *v,
>>>>      switch ( reg )
>>>>      {
>>>>      case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
>>>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>>>          /* We do not implement security extensions for guests, write ignore */
>>>>          goto write_ignore_32;
>>>>
>>>> @@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info,
>>>>      case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
>>>>      case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
>>>>      case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
>>>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>>>          /*
>>>>           * Above all register are common with GICR and GICD
>>>>           * Manage in common
>>>> @@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info,
>>>>      case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
>>>>      case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
>>>>      case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
>>>> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>>>>          /* Above registers are common with GICR and GICD
>>>>           * Manage in common */
>>>>          return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
>>>> -- 
>>>> 2.17.1
>>>>


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:44:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:44:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429349.680321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2Qd-0007Ad-FG; Mon, 24 Oct 2022 18:44:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429349.680321; Mon, 24 Oct 2022 18:44:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2Qd-0007AW-BV; Mon, 24 Oct 2022 18:44:03 +0000
Received: by outflank-mailman (input) for mailman id 429349;
 Mon, 24 Oct 2022 18:44:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on2Qc-0007AM-3N; Mon, 24 Oct 2022 18:44:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on2Qb-0001CD-Gr; Mon, 24 Oct 2022 18:44:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on2Qa-0003cb-UM; Mon, 24 Oct 2022 18:44:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1on2Qa-0000rd-TF; Mon, 24 Oct 2022 18:44:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lBueMEq6k6fgC+YFnU42JEe5xJDyh024CK6VS/vhLvk=; b=e8dcoTMwRgL8WayGHl1ly2s2V7
	iL73cumZhFkDkp4Aa/vlUQRXGuG39lo450UcRDvxDxsbvtFocOn06xnB5JyLODfssocdJ+7VQQbyq
	7awcdzStRsLJyeiHLBqAfy818MRK1xnOw7NE3RbyoOXDS10dKQKhJPhCrWV0kzIFKi/k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174302-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174302: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-dom0pvh-xl-intel:guest-saverestore:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-livepatch:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 18:44:00 +0000

flight 174302 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174302/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 174263 REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 174263 REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start    fail in 174263 REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174302
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174063 pass in 174302
 test-amd64-i386-xl-xsm        7 xen-install      fail in 174063 pass in 174302
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174063 pass in 174302
 test-amd64-amd64-dom0pvh-xl-intel 17 guest-saverestore fail in 174263 pass in 174302
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173987
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 174063
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 174063
 test-amd64-i386-livepatch     7 xen-install                fail pass in 174263
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174263

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd      12 debian-di-install       fail blocked in 172547
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174063 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174063 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174063 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174063 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174063 n/a
 build-armhf                   2 hosts-allocate           starved in 174063 n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   70 days
Failing since        173494  2022-10-11 13:38:08 Z   13 days   15 attempts
Testing same since   173610  2022-10-12 17:10:45 Z   12 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    fail    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:49:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:49:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429359.680332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2VW-0007wD-7P; Mon, 24 Oct 2022 18:49:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429359.680332; Mon, 24 Oct 2022 18:49:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2VW-0007w6-3z; Mon, 24 Oct 2022 18:49:06 +0000
Received: by outflank-mailman (input) for mailman id 429359;
 Mon, 24 Oct 2022 18:49:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on2VU-0007vw-L4; Mon, 24 Oct 2022 18:49:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on2VU-0001Hg-Ij; Mon, 24 Oct 2022 18:49:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on2VU-0003uE-3Y; Mon, 24 Oct 2022 18:49:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1on2VU-0005Yi-33; Mon, 24 Oct 2022 18:49:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AVdPqLK8eSKOOdOEms/l472Br3CYVM0BpnNdAY+VVDM=; b=prZkVXO1rk3EO+yIeyQ9nMd3vy
	Yu5/usg3EdCYAnTfcUEZng9Z13IbFWZmrLj0JjjU2r1Jtmnse1eyX0T/FzMNmRrWHhkpf4X03TMN6
	KHwzaJl1FENtcfi1NfCh09l0sY1g2pfeA7gQDHx0MDv6nQXFl/OcHz9YGShABGBowA3E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174366-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174366: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=a92dc2bb30ba65ae25d2f417677eb7ef9a6a0fef
X-Osstest-Versions-That:
    xen=fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 18:49:04 +0000

flight 174366 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174366/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  a92dc2bb30ba65ae25d2f417677eb7ef9a6a0fef
baseline version:
 xen                  fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d

Last test of basis   174365  2022-10-24 11:02:08 Z    0 days
Testing same since   174366  2022-10-24 15:03:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   fce1f381f7..a92dc2bb30  a92dc2bb30ba65ae25d2f417677eb7ef9a6a0fef -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 18:50:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 18:50:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429366.680342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2XD-0000rJ-Iy; Mon, 24 Oct 2022 18:50:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429366.680342; Mon, 24 Oct 2022 18:50:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on2XD-0000rC-Fv; Mon, 24 Oct 2022 18:50:51 +0000
Received: by outflank-mailman (input) for mailman id 429366;
 Mon, 24 Oct 2022 18:50:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bvlc=2Z=linux.ibm.com=jejb@srs-se1.protection.inumbo.net>)
 id 1on2XB-0000r6-K6
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 18:50:49 +0000
Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
 [148.163.158.5]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c5b66a9c-53cc-11ed-8fd0-01056ac49cbb;
 Mon, 24 Oct 2022 20:50:48 +0200 (CEST)
Received: from pps.filterd (m0127361.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29OIhxjL013482;
 Mon, 24 Oct 2022 18:50:33 GMT
Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com
 [169.53.41.122])
 by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ke08186ju-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 24 Oct 2022 18:50:32 +0000
Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1])
 by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29OIZdMR010259;
 Mon, 24 Oct 2022 18:50:32 GMT
Received: from b03cxnp08025.gho.boulder.ibm.com
 (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17])
 by ppma04dal.us.ibm.com with ESMTP id 3kc859smrk-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 24 Oct 2022 18:50:32 +0000
Received: from b03ledav004.gho.boulder.ibm.com
 (b03ledav004.gho.boulder.ibm.com [9.17.130.235])
 by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
 29OIoTeg852552
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 24 Oct 2022 18:50:29 GMT
Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id C8FFC7805E;
 Mon, 24 Oct 2022 19:33:28 +0000 (GMT)
Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id E0F9D7805C;
 Mon, 24 Oct 2022 19:33:26 +0000 (GMT)
Received: from [IPv6:2601:5c4:4300:c551:a71:90ff:fec2:f05b] (unknown
 [9.163.14.162])
 by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP;
 Mon, 24 Oct 2022 19:33:26 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5b66a9c-53cc-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject :
 from : reply-to : to : cc : date : in-reply-to : references : content-type
 : mime-version; s=pp1; bh=IzJ7jg6e3PsQHKVoduFzkG/km7Wk0osi8XmusOE2sXA=;
 b=nzL8f6khTCzPknLo8CVeewd0NK1kxuz8CG0FQWxXYl5bzwBEWmvUT4EcqfQlUCtvi2BB
 PF3gIIhzJfabnEUjD5mGo5kJ+sGlWG0cgMDOgUjCncy53tn9D4OLL9YgqQIPIT4HWnDN
 DSIYGAw+0WfdBHGhmDP3D9/x6IO24vT2omVw3laBmf5aoqHGsUJNzfTk4o4p/evWDTDe
 oz+zLgwPVRq2rRCgZwSGO6vCd0ZZm4690L4nlc3u5UE2qGD+fItmYvV3a5wRfJpWr7JD
 xr+mbp9g8hh37VaVSSFyOxe67KmI+7kxeclbrRy3h1vC0oEz7abxs0gz13LPs9+7L0dd mA== 
Message-ID: <aa9ebdef1f1dbfceb5a32f5f437b865861976957.camel@linux.ibm.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
From: James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To: Juergen Gross <jgross@suse.com>,
        Sreekanth Reddy
	 <sreekanth.reddy@broadcom.com>,
        Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, sathya.prakash@broadcom.com,
        suganath-prabu.subramani@broadcom.com,
        "Martin K. Petersen"
	 <martin.petersen@oracle.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        adi@kriegisch.at
Date: Mon, 24 Oct 2022 14:50:26 -0400
In-Reply-To: <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
	 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
	 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
	 <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-OsMKRDmTTv0MyMAb4mqc"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
X-TM-AS-GCONF: 00
X-Proofpoint-GUID: EFS9Q0lFOaGkRL_FiH7rYr8o07kVNk6r
X-Proofpoint-ORIG-GUID: EFS9Q0lFOaGkRL_FiH7rYr8o07kVNk6r
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-24_05,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 mlxscore=0
 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1011
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210240111


--=-OsMKRDmTTv0MyMAb4mqc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2022-10-24 at 14:55 +0200, Juergen Gross wrote:
[...]
> Please recheck the backported patch in 5.10.y. It is _wrong_. The
> backport
> has:
>=20
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -2993,7 +2993,7 @@ _base_config_dma_addressing(struct
> MPT3SAS_ADAPTER *ioc,=20
> struct pci_dev *pdev)
>=20
>          if (ioc->is_mcpu_endpoint ||
>              sizeof(dma_addr_t) =3D=3D 4 || ioc->use_32bit_dma ||
> -           dma_get_required_mask(&pdev->dev) <=3D 32)
> +           dma_get_required_mask(&pdev->dev) <=3D DMA_BIT_MASK(32))
>                  ioc->dma_mask =3D 32;
>          /* Set 63 bit DMA mask for all SAS3 and SAS35 controllers */
>          else if (ioc->hba_mpi_version_belonged > MPI2_VERSION)
>=20
> While the upstream patch has:
>=20
> +       if (ioc->is_mcpu_endpoint || sizeof(dma_addr_t) =3D=3D 4 ||
> +           dma_get_required_mask(&pdev->dev) <=3D 32) {
>                  ioc->dma_mask =3D 32;
> +               coherent_dma_mask =3D dma_mask =3D DMA_BIT_MASK(32);
>=20

That's not the upstream commit.  The quoted upstream patch in the
stable commit is:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3De0e0747de0ea3dd87cdbb0393311e17471a9baf1

Which has the same diff as you quoted for the stable tree.

James


--=-OsMKRDmTTv0MyMAb4mqc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iHUEABMIAB0WIQTnYEDbdso9F2cI+arnQslM7pishQUCY1becgAKCRDnQslM7pis
hSQsAQCC7A2xVu85X8YkyFbTrfUGtyIwNToEhWGfvxT9jzz20QD+JhzALYu83cJ2
RUsBjRW335CWiHkcm1rQRKHqXvW0RsM=
=vyiC
-----END PGP SIGNATURE-----

--=-OsMKRDmTTv0MyMAb4mqc--



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 19:30:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 19:30:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429388.680354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on39P-0005Lw-GL; Mon, 24 Oct 2022 19:30:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429388.680354; Mon, 24 Oct 2022 19:30:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on39P-0005Lp-D1; Mon, 24 Oct 2022 19:30:19 +0000
Received: by outflank-mailman (input) for mailman id 429388;
 Mon, 24 Oct 2022 19:30:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZViS=2Z=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1on39O-0005Lj-7A
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 19:30:18 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2084.outbound.protection.outlook.com [40.107.243.84])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 489e78f6-53d2-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 21:30:15 +0200 (CEST)
Received: from DS7PR05CA0052.namprd05.prod.outlook.com (2603:10b6:8:2f::30) by
 SN7PR12MB7345.namprd12.prod.outlook.com (2603:10b6:806:298::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 24 Oct
 2022 19:30:12 +0000
Received: from DM6NAM11FT094.eop-nam11.prod.protection.outlook.com
 (2603:10b6:8:2f:cafe::34) by DS7PR05CA0052.outlook.office365.com
 (2603:10b6:8:2f::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.8 via Frontend
 Transport; Mon, 24 Oct 2022 19:30:12 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT094.mail.protection.outlook.com (10.13.172.195) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 19:30:12 +0000
Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 14:30:11 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com
 (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct
 2022 14:30:11 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 24 Oct 2022 14:30:10 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 489e78f6-53d2-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WrY444qC/OTxm+yZmQvZDFYiqxCHPZJ3CuiN0vr5kKuX8u0iITPVPw/nrdA8DWEfdl0QCPuH74dM8eJvXPpBzvrJYQrpT7QwuEe25cs2K3vPxGc7Z1vC4l7nrZ4S7qA45lB3fyXirqbSIMJHpnLh8zdFb4nTDvGanZ5UpiXsPyESsPPlLskf0keAfrfFbX3t+0sA2GljDZHF0GX196hajzKx3Oh5G354Ms2ycltAWuiEO7PDnfk/G1V+n+vMDlw5KbScQMgfwcv+KqZ94XckoOhntire2lBuvdhnuwYMgyW/pESCwCZVMibN+XUkXab60GYnvs7rDjkKumu14Sjr3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=My2CdENgSSvX0A0wOdfMQ6XHEcFLH5icgIUZaNeQLPY=;
 b=dSPxSeIgXsK3L7/qtnwYieHWaypCaXsZhoRQ93m20+ZjmAP+IPaPGyleBrbNki4flX/5Ao8diahbBlfxDeVyqMoRcBdsq/Jbzn1K8RtRIdlZwiJ9DlN03g14Z59zvkEfCHKgVpUoblRA3CrhpcPBIy0AhLlM8xqoup98uU6nAFf46QW9GeR7R8qEStMeKuPUpd8G3BooBmm/lZ1L2NPdkF2wq0/+p+OPySnR8mhEDN77/hgzqQmRMFlAkVt1NIr7zbHj+0PgV+XmlA37u8+V7if65Wgrtoa+rlEuwvmEDTRb38aUqsOJQ+HL6pZCGsoL7ch2S4CMZo8Tt5wJzxValg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=My2CdENgSSvX0A0wOdfMQ6XHEcFLH5icgIUZaNeQLPY=;
 b=V8WTCvhtS013o1CnFk6suXvzd18ni+1Lyp4VYYRSCDqbCxcxP1QPhWS7r6GqLQ6ViE2Qnuk3+L4TFtnlfRb8R76EITLo26DvncV9lABmGxGZBpBh+ddGIiFRKqEaCZ1XVFoX7aJ9To7GEMRK+jnAGvmLgJVZaCKyO0EKAxgUWRI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<andre.przywara@arm.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit guests
Date: Mon, 24 Oct 2022 20:30:02 +0100
Message-ID: <20221024193002.57888-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT094:EE_|SN7PR12MB7345:EE_
X-MS-Office365-Filtering-Correlation-Id: c8d63ace-0f62-4e09-d257-08dab5f62b6f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hddS1p0hLRzbDq5y9rlodPwX5CWGReypLe02li/Q8vDh9NEebOJhezG8pcRBF3Y3zP0jNWb+71FB3IOzcGsb5kAGajIknCMfarIQoG9J9Fe0h9qXoqIA7sxlZ08Od+0GMERPJCFz8Sg5zy4/reZ6gNNBHPEXeCvCywuj9u+7KAD8ak97wnnvVwsgG66ju1PGgr/ulFJ0CWvqHvFItknxeZLftplri0LzfVswVg2XV3eMqoEMb0t/BU8TGAaY3UCnuYKKwIh2L8JDM6b+D96C/H6jf9mAzxPI7XbNj3ucgWSMlwf/sFv5ftSirMu7vE/57pF5wyH0U71TRdA6doXzZoQa2KYw3DnG9xbfl4hDW02MrA7lZIcafueLGNmWLc06cX6nh+qk0DoelNO7pENjhCStLODPNHfPmaaF1ME8fVqehS2FPA0xsSjmgiEisst426nJmAcmImUM9lQSeNCGNgeSu5quPXj0ZK5OUUVyAlKGjqznk6Uxm9JEJdY4wkPPTutGACgmF71kENeUSCVZKyssCcqYhpSTdc2kXBWWF44SG81fRbR6QFmRsNIqqR4cQ6yWvATfaumgNjZfFzwBOmEUXFumCESZih9vy0zS5/BS0Va7ii6+VIsH/bjax22C1Dr62BE/1z0fq2HhNIdCH4G3owoOEzqyN48MKgxT6oKVP24R8IWVs65p1A2WHy5ix1ilhQ6UOfzSSAJq/HX4m61QwvrnjtEgwXk6Ri1RlKoaxcdiHUKo9Iiksb3EL7rolaZNMIW1+GJn8ytHnwK0jCEVdggZxlmbhviNtBG36qzKe0MAKX8vf/A/kTbnQ2+l
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(40470700004)(46966006)(36840700001)(426003)(36860700001)(40460700003)(47076005)(36756003)(356005)(82740400003)(82310400005)(6666004)(40480700001)(70586007)(70206006)(83380400001)(81166007)(8676002)(6916009)(5660300002)(54906003)(316002)(336012)(2616005)(2906002)(186003)(1076003)(8936002)(4326008)(478600001)(41300700001)(26005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 19:30:12.0896
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c8d63ace-0f62-4e09-d257-08dab5f62b6f
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT094.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7345

If a guest is running in 32 bit mode and it tries to access
"GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
will return the value stored "v->arch.vgic.rdist_pendbase + 4".
This will be stored in a 32bit register.

The 32bit register is then modified bitwise with a mask (ie GICR_PENDBASER_PTZ,
it clears the 62nd bit) which is greater than 32 bits. This will give an
incorrect result.

The correct thing to do here is to store the value of
"v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
vreg_reg64_extract() which will extract 32 bits from the given offset.

Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from:-

v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
appropriate commit message.

 xen/arch/arm/vgic-v3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..7930ab6330 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -250,14 +250,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VREG64(GICR_PENDBASER):
     {
         unsigned long flags;
+        uint64_t val;
 
         if ( !v->domain->arch.vgic.has_its )
             goto read_as_zero_64;
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
 
         spin_lock_irqsave(&v->arch.vgic.lock, flags);
-        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
-        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
+        val = v->arch.vgic.rdist_pendbase;
+        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
+        *r = vreg_reg64_extract(val, info);
         spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
         return 1;
     }
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 21:33:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 21:33:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429405.680365 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on54a-0000sQ-93; Mon, 24 Oct 2022 21:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429405.680365; Mon, 24 Oct 2022 21:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on54a-0000sJ-5i; Mon, 24 Oct 2022 21:33:28 +0000
Received: by outflank-mailman (input) for mailman id 429405;
 Mon, 24 Oct 2022 21:33:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IvXY=2Z=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1on54Y-0000sD-Ms
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 21:33:26 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 7cebd552-53e3-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 23:33:24 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76D69D6E;
 Mon, 24 Oct 2022 14:33:29 -0700 (PDT)
Received: from slackpad.lan (unknown [172.31.20.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 201963F7B4;
 Mon, 24 Oct 2022 14:33:21 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7cebd552-53e3-11ed-91b5-6bf2151ebd3b
Date: Mon, 24 Oct 2022 22:31:56 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
 <stefanos@xilinx.com>, <julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
 <bertrand.marquis@arm.com>
Subject: Re: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit
 guests
Message-ID: <20221024223156.0ccb1074@slackpad.lan>
In-Reply-To: <20221024193002.57888-1-ayankuma@amd.com>
References: <20221024193002.57888-1-ayankuma@amd.com>
Organization: Arm Ltd.
X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 24 Oct 2022 20:30:02 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi,

> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 32bit register.
> 
> The 32bit register is then modified bitwise with a mask (ie GICR_PENDBASER_PTZ,
> it clears the 62nd bit) which is greater than 32 bits. This will give an
> incorrect result.
> 
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>

Indeed, the patch looks good to me. Also checked the other users of
vreg_reg64_extract(), they seem to be all correct, by first building
the value, then running the extract function on the final result.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> 
> Changes from:-
> 
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> appropriate commit message.
> 
>  xen/arch/arm/vgic-v3.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..7930ab6330 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -250,14 +250,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>      case VREG64(GICR_PENDBASER):
>      {
>          unsigned long flags;
> +        uint64_t val;
>  
>          if ( !v->domain->arch.vgic.has_its )
>              goto read_as_zero_64;
>          if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>  
>          spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> +        val = v->arch.vgic.rdist_pendbase;
> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> +        *r = vreg_reg64_extract(val, info);
>          spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>          return 1;
>      }



From xen-devel-bounces@lists.xenproject.org Mon Oct 24 21:56:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 21:56:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429411.680375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on5QM-0003Ro-1c; Mon, 24 Oct 2022 21:55:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429411.680375; Mon, 24 Oct 2022 21:55:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on5QL-0003Rh-VI; Mon, 24 Oct 2022 21:55:57 +0000
Received: by outflank-mailman (input) for mailman id 429411;
 Mon, 24 Oct 2022 21:55:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vZoK=2Z=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1on5QL-0003Rb-6P
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 21:55:57 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a28dded7-53e6-11ed-91b5-6bf2151ebd3b;
 Mon, 24 Oct 2022 23:55:55 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 06216B80D69;
 Mon, 24 Oct 2022 21:55:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A329EC433D6;
 Mon, 24 Oct 2022 21:55:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a28dded7-53e6-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666648550;
	bh=NYGxCRzxfM+0SHWVqqDieMTwmG9V0rHis3PBlohkpoQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=RjgLhq/MjT7ZWgcxGX2JWjjgODDDFXgC1XFWFSv2ObpciwF9WMoHSKfPjI5B/Z3cU
	 vvyJObiI/P2bKW8R1wF95AfG1OhTSzB+DX2Ujfzmo4JkimOt13ILu63Qa/x7keRKND
	 U0u68CsYHE+UvUWl/NC3LRgr0GMgCLN+BZCGQf0klySv+J9a+RYRJ0i5ABNTnILcSV
	 9IIISXp45A/p+06LAldBJztuHADOAha1SMm7cdkvwENa1DdaISJSiblHLK8u4gSzAV
	 aEz+w/6xQm9Vb6ZxRUA2PxmS3Kdf4AqltRjMiTY3M1F3O3JqavhywxMS0UttYAhFIy
	 ipRFps05MHPfg==
Date: Mon, 24 Oct 2022 14:55:42 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Andrew Cooper <Andrew.Cooper3@citrix.com>, Julien Grall <julien@xen.org>, 
    Jan Beulich <jbeulich@suse.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Doug Goldstein <cardoe@cardoe.com>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [for-4.17] automation: Do not use null scheduler for boot cpupools
 test
In-Reply-To: <76b7f236-f99d-7600-3958-6a92943b564c@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210241455240.1151068@ubuntu-linux-20-04-desktop>
References: <20221021165341.7905-1-michal.orzel@amd.com> <b1f7c77b-6e39-85e9-074e-0e31ed9648db@citrix.com> <alpine.DEB.2.22.394.2210211211090.3873@ubuntu-linux-20-04-desktop> <76b7f236-f99d-7600-3958-6a92943b564c@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 24 Oct 2022, Michal Orzel wrote:
> Replying to all,
> 
> On 21/10/2022 21:36, Stefano Stabellini wrote:
> > 
> > 
> > On Fri, 21 Oct 2022, Andrew Cooper wrote:
> >> On 21/10/2022 17:53, Michal Orzel wrote:
> >>> Null scheduler is not enabled on non-debug Xen builds so the current
> >>> test can lead to a failure on such jobs. We still want to test that we
> >>> can assign the cpupool to a domU with a different scheduler than default
> >>> one (credit2). Switch to credit as it is enabled by default.
> >>>
> >>> Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
> >>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> >>
> >> /sigh - I'm sure I nacked that stupidity to begin with.  apparently not...
> >>
> >> It is totally bogus for CONFIG_DEBUG to influence logical chunks of
> >> functionality like this.  The CI script is good in its current form.
> >>
> >> RTDS and ARINC should be default n.
> >>
> >> NULL is more tricky.  PV_SHIM is explicitly security supported, and has
> >> been for years, so the "UNSUPPORTED" is bogus, whatever the default is.
> >>
> >> As NULL is explicitly tested in CI, it's clearly supported, and probably
> >> ought to be on default.
> >>
> >>
> >> Please instead fix Kconfig to not be broken.  That will be a far better
> >> fix overall for people.
> >>
> >> As a more general note, tests which are using non-default pieces of
> >> logic ought to activate them explicitly.
> > 
> > 
> > I agree with you, but first let me clarify the word "supported".
> > 
> > 
> > In Xen Project "supported" implies extra efforts to follow the security
> > process and of course the security team should be on board with it. If
> > we say "supported, non security supported" we don't need to follow the
> > security process but still we sign up for backporting fixes to the
> > stable tree. It is less extra effort but still some extra effort is
> > involved.
> > 
> > So, this specific issue aside, I think that as we expand the testing
> > capabilities of gitlab-ci, we'll have tests for things that are not
> > necessarily neither "supported" nor "supported, non security supported".
> > 
> > 
> > For the NULL scheduler, it is clearly important to many users so it
> > would be valuable to move it to "supported, non security supported" and
> > enabling it by default in the build. I don't recall if we still have any
> > known outstanding issues with it. I think we need a separate email
> > thread for that discussion and I would understand if the decision is not
> > to change NULL support status for the 4.17 release (maybe for the 4.18
> > release?).
> > 
> > 
> > In any case, we don't need CONFIG_DEBUG to enable CONFIG_UNSUPPORTED. It
> > is just that UNSUPPORTED and NULL don't get enabled by default in the
> > non-DEBUG build. So to fix gitlab-ci, we can simply enable
> > CONFIG_UNSUPPORTED explicitly for the builds where we need it
> > (alpine-3.12-gcc-arm64-boot-cpupools).
> 
> Given that there are still diverging opinions \wrt making use of DEBUG
> to influence enabling/disabling some functionalities in the code, I would
> opt for modifying the CI job to explicitly specify the required config options,
> just like I did for static-mem test. The necessary options to enable NULL are:
> CONFIG_EXPERT=y
> CONFIG_UNSUPPORTED=y
> CONFIG_SCHED_NULL=y
> 
> This will fix the issue and allow us to continue with 4.17 release.
> Given the outstanding issues reported by Julien, it would be challenging to
> try to mark the NULL scheduler as supported, not security supported for this release.

Yes, sounds good


> Besides that, I think that Andrew still has a valid point. We seem to use DEBUG
> only in Kconfig.debug (obvious choice) and sched/Kconfig. So this is not something
> common to rely on DEBUG to enable logical functionalities (why did we make this exception for schedulers?).
> Having said that, I think the discussion on whether to switch to default n
> instead of default DEBUG or not is still valid and requires more people to give feedback.

Yeah


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 22:11:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 22:11:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429417.680386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on5fd-0005v3-HO; Mon, 24 Oct 2022 22:11:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429417.680386; Mon, 24 Oct 2022 22:11:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on5fd-0005uw-El; Mon, 24 Oct 2022 22:11:45 +0000
Received: by outflank-mailman (input) for mailman id 429417;
 Mon, 24 Oct 2022 22:11:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on5fc-0005um-90; Mon, 24 Oct 2022 22:11:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on5fc-0004jc-6S; Mon, 24 Oct 2022 22:11:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1on5fb-0006RP-LA; Mon, 24 Oct 2022 22:11:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1on5fb-0006CT-Kh; Mon, 24 Oct 2022 22:11:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HFwiR9nMyLAIK2Pp4vYQchTXmY2zta5QQdspVDEqy1A=; b=cHSXofHzTusRJrV8WNAnFSG32H
	YjYuZj2TVE/oorUrrgKHQBYDUjvkU4Pu/ZqcFPrAHADKlkIypTdHQE8pFMHqBEir4Hf23IXxlU/xn
	yg7XXjpirFR/z69QT3PRP6iFW5xq6GCb8HfJMPiUc/YNL8muW3IGDl/tRcRNn0fRbCa8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174354-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174354: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=4d29da411fa031031a90ec713ad826570e9117d7
X-Osstest-Versions-That:
    ovmf=6fd754ec0fe96511cc48e3babe1a1b650fb3994f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 24 Oct 2022 22:11:43 +0000

flight 174354 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174354/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 4d29da411fa031031a90ec713ad826570e9117d7
baseline version:
 ovmf                 6fd754ec0fe96511cc48e3babe1a1b650fb3994f

Last test of basis   174265  2022-10-22 13:40:31 Z    2 days
Testing same since   174354  2022-10-24 06:40:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  JessyX Wu <jessyx.wu@intel.com>
  Wu, JessyX <jessyx.wu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6fd754ec0f..4d29da411f  4d29da411fa031031a90ec713ad826570e9117d7 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 24 23:05:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 24 Oct 2022 23:05:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429441.680404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on6VC-0002zs-IV; Mon, 24 Oct 2022 23:05:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429441.680404; Mon, 24 Oct 2022 23:05:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on6VC-0002zl-Dh; Mon, 24 Oct 2022 23:05:02 +0000
Received: by outflank-mailman (input) for mailman id 429441;
 Mon, 24 Oct 2022 23:05:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8/mz=2Z=tklengyel.com=tamas@srs-se1.protection.inumbo.net>)
 id 1on6VA-0002zf-SQ
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2022 23:05:01 +0000
Received: from MTA-11-3.privateemail.com (mta-11-3.privateemail.com
 [198.54.122.105]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 466db457-53f0-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 01:04:59 +0200 (CEST)
Received: from mta-11.privateemail.com (localhost [127.0.0.1])
 by mta-11.privateemail.com (Postfix) with ESMTP id C849018000A4
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 19:04:54 -0400 (EDT)
Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com
 [209.85.219.174])
 by mta-11.privateemail.com (Postfix) with ESMTPA id A37C518000A2
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 19:04:54 -0400 (EDT)
Received: by mail-yb1-f174.google.com with SMTP id o70so12655113yba.7
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 16:04:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 466db457-53f0-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com;
	s=default; t=1666652694;
	bh=pC7Rl/r4SDQt5avi2u9wQXNDCm/wER4FHrGcJDmY8Is=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=oCTN8UcixYyyRUtFAQs0LK0aD+Liu49tXLU+Cg+WAVC7A/UILwBy/KPBc39LDjchu
	 FgJfEFHmBqK8IkZEktKP3FW+T9awhp5GePkotz4glh+YmjQ+ew9YTSHYxgyD5wWnDx
	 AkRGzekb6Ki10+H1Bf2kMvqAiI0hlvaapgi6ovfHQwlZbsHSnpCNG6N+UTGtD8Zs9Q
	 rVGPt4/Qf8x5NXJoiVBtqa9BW3zba3MhcqRxiZnQDSxG+Jtet4G7NzKZgenHhuFAuq
	 aReDuDPC9trtTPYSMXk0BgKAkqYbq6awSdx1vKyzhcia5gvIA8qaDBJkwqv1xDbPqG
	 jgMOzWCmU47rQ==
X-Gm-Message-State: ACrzQf2soumT5XizAbSDbcvc49jmLpGdFlZkJ4F6/rHxk7R2zk7b73jo
	LbX6N5MwWbcx+MhyxGAigMt5aK379hvozekBt6g=
X-Google-Smtp-Source: AMsMyM570MzfEHG+h6//NTCAyCssTuVZ33kcVRI8jBPeUBf66hJktS6hWXxssnPRAxN1/K8iLQWj7FGo5PMNC7Y8Szs=
X-Received: by 2002:a5b:2ce:0:b0:6c9:b257:5229 with SMTP id
 h14-20020a5b02ce000000b006c9b2575229mr27373640ybp.136.1666652693856; Mon, 24
 Oct 2022 16:04:53 -0700 (PDT)
MIME-Version: 1.0
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com> <bb3be891-1dad-43db-da69-f20a471ccdb7@suse.com>
In-Reply-To: <bb3be891-1dad-43db-da69-f20a471ccdb7@suse.com>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Mon, 24 Oct 2022 19:04:17 -0400
X-Gmail-Original-Message-ID: <CABfawhm-YHwO08f_tgN_-X1=2+U4krtaVv3UUoaFm6NJEhzVMA@mail.gmail.com>
Message-ID: <CABfawhm-YHwO08f_tgN_-X1=2+U4krtaVv3UUoaFm6NJEhzVMA@mail.gmail.com>
Subject: Re: [PATCH 06/10] x86/mem-sharing: copy GADDR based shared guest areas
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Content-Type: multipart/alternative; boundary="000000000000c816b805ebcfd1f2"
X-Virus-Scanned: ClamAV using ClamSMTP

--000000000000c816b805ebcfd1f2
Content-Type: text/plain; charset="UTF-8"

> @@ -1987,7 +2056,10 @@ int mem_sharing_fork_reset(struct domain
>
>   state:
>      if ( reset_state )
> +    {
>          rc = copy_settings(d, pd);
> +        /* TBD: What to do here with -ERESTART? */

Generally speaking the fork reset operation does not support "restarting".
While in the memory op path the error can be propagated back to the
toolstack and have it re-issue it, on the monitor reply path that's not
possible. But the important question is where does the -ERESTART come
from?  What I think would happen here though is that -ERESTART may happen
during the initial fork op and that can fail, but if it succeeded, then
during reset it can't happen since everything would be already allocated
and mapped, the only thing during reset that would be done is the page
copying.

Tamas

--000000000000c816b805ebcfd1f2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br><br>&gt; @@ -1987,7 +2056,10 @@ int mem_sharing_fo=
rk_reset(struct domain<br>&gt;<br>&gt; =C2=A0 state:<br>&gt; =C2=A0 =C2=A0 =
=C2=A0if ( reset_state )<br>&gt; + =C2=A0 =C2=A0{<br>&gt; =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0rc =3D copy_settings(d, pd);<br><div>&gt; + =C2=A0 =C2=A0 =
=C2=A0 =C2=A0/* TBD: What to do here with -ERESTART? */</div><div><br></div=
><div>Generally speaking the fork reset operation does not support &quot;re=
starting&quot;. While in the memory op path the error can be propagated bac=
k to the toolstack and have it re-issue it, on the monitor reply path that&=
#39;s not possible. But the important question is where does the -ERESTART =
come from?=C2=A0 What I think would happen here though is that -ERESTART ma=
y happen during the initial fork op and that can fail, but if it succeeded,=
 then during reset it can&#39;t happen since everything would be already al=
located and mapped, the only thing during reset that would be done is the p=
age copying.</div><div><br></div><div>Tamas<br></div></div>

--000000000000c816b805ebcfd1f2--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 01:14:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 01:14:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429449.680423 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8Vr-0006c3-KM; Tue, 25 Oct 2022 01:13:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429449.680423; Tue, 25 Oct 2022 01:13:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8Vr-0006bw-Gt; Tue, 25 Oct 2022 01:13:51 +0000
Received: by outflank-mailman (input) for mailman id 429449;
 Tue, 25 Oct 2022 01:13:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1on8Vq-0006ba-5B
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 01:13:50 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 473bf088-5402-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 03:13:48 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 8112F616FA;
 Tue, 25 Oct 2022 01:13:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89548C433B5;
 Tue, 25 Oct 2022 01:13:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 473bf088-5402-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666660427;
	bh=/7ZDKTBmVbDxYRoypverc9XDjamz3U72xPqoy1OKOiM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=WsxovWJxXiodDhe0fHQlNbLR2VNA9l0EjnEIy9NgnNATZq48d4I6RlMQq8A+4PwBd
	 ijRsx/bX/qI60H5TLwfsr3lCHsJvvbrE5wZQQHiGrgQrv9Nb3RfJDOYQ135r+OejRO
	 XWt5pyKaiayLAtxa7GzpvN2kgOaYi36yYr9WRwXeCj7o+x7ydNL1Jhf7k7OSdohLAw
	 WEVBm3Ov4U95lzpt/4dOBXotDbzDybYa+uZTgIysNrrJ6kvxt/w+sNQbAKsXCRqih5
	 Foonq4VUQdKOfekTIr6inw+0Yh32J7PLhM/2qtjbFkfO+DaFxvUpN+4yAtUhrfzmzZ
	 JqbzoVEQG8d+A==
Date: Mon, 24 Oct 2022 18:13:45 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Andrew.Cooper3@citrix.com, 
    Henry.Wang@arm.com
Subject: Re: [for-4.17, PATCH v2] automation: Explicitly enable NULL scheduler
 for boot-cpupools test
In-Reply-To: <20221024120443.16202-1-michal.orzel@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210241810200.1151068@ubuntu-linux-20-04-desktop>
References: <20221024120443.16202-1-michal.orzel@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 24 Oct 2022, Michal Orzel wrote:
> NULL scheduler is not enabled by default on non-debug Xen builds. This
> causes the boot time cpupools test to fail on such build jobs. Fix the issue
> by explicitly specifying the config options required to enable the NULL
> scheduler.
> 
> Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time cpupools on arm64")
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

I would like a release-ack by Henry on this

> ---
> Changes in v2:
> - was: automation: Do not use null scheduler for boot cpupools test
> - modify the commit msg/title
> - explicitly enable NULL scheduler by specifying all the required options
> 
> This patch acts as a prerequisite before merging the following patch:
> https://lore.kernel.org/xen-devel/20221021132238.16056-1-michal.orzel@amd.com/
> (to which Henry already gave RAB), that helped to find the issue described
> in the comment.
> 
> Tests shall explicitly specify the required Kconfig options for non-default
> pieces of logic, thus this patch is unrelated to the discussions whether
> enabling/disabling the NULL scheduler should be controlled by DEBUG or not.
> ---
>  automation/gitlab-ci/build.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index ddc2234faf39..716ee0b1e460 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -582,6 +582,9 @@ alpine-3.12-gcc-arm64-boot-cpupools:
>    variables:
>      CONTAINER: alpine:3.12-arm64v8
>      EXTRA_XEN_CONFIG: |
> +      CONFIG_EXPERT=y
> +      CONFIG_UNSUPPORTED=y
> +      CONFIG_SCHED_NULL=y
>        CONFIG_BOOT_TIME_CPUPOOLS=y
>  
>  ## Test artifacts common
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 01:15:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 01:15:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429454.680435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8Xq-0007E4-0Y; Tue, 25 Oct 2022 01:15:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429454.680435; Tue, 25 Oct 2022 01:15:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8Xp-0007Dx-TG; Tue, 25 Oct 2022 01:15:53 +0000
Received: by outflank-mailman (input) for mailman id 429454;
 Tue, 25 Oct 2022 01:15:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1on8Xo-0007Dl-L1
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 01:15:52 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8fe1c092-5402-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 03:15:51 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 97A97616FE;
 Tue, 25 Oct 2022 01:15:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6987DC433D7;
 Tue, 25 Oct 2022 01:15:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fe1c092-5402-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666660549;
	bh=O4HwmCgTJmsMYtBlL/vTbq/qpgGlH+zi7yjo6BeKI8E=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=oKhM41tPo4F7+06N0g0Ub8dC5hQuAt2+aSx7AcEo+m8NdQRCSSJCvD8OC/SploX47
	 MMqFzjXIpuz18gItGnQ3VIscA2mvpDaDcn/MIeB5s4HIVT36ASiJ55xoV3WhjmzI9y
	 zn8ruheq2WjzTJ+mB9YgoIp191SwYHqyDt1gq2x2sxIk+CCCgWcAfakZGPV2vJ4A/E
	 rr+ZGfVM7NtW4WQYauXWj/4R85Wyv8+X10q/b9N2TnQnWHB4UyUacl4NYqb6/UmnVa
	 pJjXMa3unIUZfBWWl7XutGW9VAG1IATEcuhOIOfS8Zdxe/X/VdOwrq3fPZE/veeHxW
	 keQOJwDdl57KA==
Date: Mon, 24 Oct 2022 18:15:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH] automation: test.yaml: Introduce templates to reduce
 the overhead
In-Reply-To: <b9da39df-8ec0-9255-1345-445f2a5b56e6@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210241815010.1151068@ubuntu-linux-20-04-desktop>
References: <20221019164246.5487-1-michal.orzel@amd.com> <alpine.DEB.2.22.394.2210211423560.3873@ubuntu-linux-20-04-desktop> <b9da39df-8ec0-9255-1345-445f2a5b56e6@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 24 Oct 2022, Michal Orzel wrote:
> Hi Stefano,
> 
> On 21/10/2022 23:42, Stefano Stabellini wrote:
> > 
> > 
> > On Wed, 19 Oct 2022, Michal Orzel wrote:
> >> At the moment, we define lots of test jobs in test.yaml, that make use
> >> of the same configuration sections like variables, tags, artifacts.
> >> Introduce templates (hidden jobs whose names start with a dot) to
> >> reduce the overhead and simplify the file (more than 100 lines saved).
> >> This way, the actual jobs can only specify sections that are unique
> >> to them.
> >>
> >> Most of the test jobs specify the same set of prerequisite jobs under needs
> >> property with just one additional being unique to the job itself. Introduce
> >> YAML anchors for that purpose, because when using extends, the needs property
> >> is not being merged (the parent property overwrites the child one).
> > 
> > I like the patch. Replying here on top because the diff below is not
> > very helpful.
> > 
> > When you say that "extends" overwrites the properties, do you mean that
> > "needs" in qemu-smoke-dom0-arm64-gcc overwrites "needs" in .qemu-arm64,
> > when qemu-smoke-dom0-arm64-gcc includes .qemu-arm64?
> Yes, exactly. The behavior depends on the property. For example, the variables
> section is merged but needs end up being overwritten. This is because the extends
> does not merge the keys (variables uses key: value, whereas needs does not).
> 
> > 
> > 
> > If there is no way to solve the overwrite problem then it is OK to use
> > YAML achors but is it possible to define the anchors outside of
> > .qemu-arm64/.qemu-arm32 ? It would make things a lot clearer in the
> > code. Maybe under a top level "definitions" key? The point is that
> > .qemu-arm64 and .qemu-arm32 should use the anchor rather than define the
> > anchor.
> It is possible to define anchors outside qemu-arm64/arm32. I decided to
> define them in these jobs because for me it looked cleaner (less lines of code).
> But I'm ok to carve them out if that is what you prefer. This would
> require dropping the needs property from the extend jobs, as they cannot make use
> of the anchors (overwrite issue), and using the anchors from real jobs (just like I did in this patch).

Yes that makes sense


> So we would have:
> 
> .arm64-test-needs: &arm64-test-needs
>   - alpine-3.12-arm64-rootfs-export
>   - kernel-5.19-arm64-export
>   - qemu-system-aarch64-6.0.0-arm64-export
> 
> .qemu-arm64:
>   extends: .test-jobs-common
>   variables:
>     CONTAINER: debian:unstable-arm64v8
>     LOGFILE: qemu-smoke-arm64.log
>   artifacts:
>     paths:
>       - smoke.serial
>       - '*.log'
>     when: always
>   tags:
>     - arm64
> 
> qemu-smoke-dom0-arm64-gcc:
>   extends: .qemu-arm64
>   script:
>     - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
>   needs:
>     - *arm64-test-needs
>     - alpine-3.12-gcc-arm64

This looks better, thanks!

 
> > 
> > I wouldn't call it qemu-arm64-needs because it has things
> > like alpine-3.12-arm64-rootfs-export and kernel-5.19-arm64-export that
> > are not required by qemu-system-aarch64-6.0.0-arm64-export. If anything
> > qemu-system-aarch64-6.0.0-arm64-export needs CONTAINER:
> > debian:unstable-arm64v8.
> > 
> > So I would call the anchor something like "arm64-test-needs". Same
> > comment for the arm32 anchor.
> Ok, this naming sounds good to me.
> 
> > 
> > 
> >> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> >> ---
> >> This patch is based on the CI next branch where we already have several
> >> patches (already acked) to be merged into staging after the release:
> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fsstabellini%2Fxen%2F-%2Ftree%2Fnext&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7Ca83af11b062b431b4f0908dab3ad2162%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638019853419768862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=TZxie442G%2Bm6SP%2FemyPuv8dwCDXAv1Wxwe22yGQZaB4%3D&amp;reserved=0
> >>
> >> Tested pipeline:
> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fxen-project%2Fpeople%2Fmorzel%2Fxen-orzelmichal%2F-%2Fpipelines%2F671114820&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7Ca83af11b062b431b4f0908dab3ad2162%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638019853419768862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=tMwGAZUKyvDp%2BxmVdxUD1kg3uMagWdO2P1DjF5O3b2M%3D&amp;reserved=0
> >> ---
> >>  automation/gitlab-ci/test.yaml | 266 ++++++++++-----------------------
> >>  1 file changed, 80 insertions(+), 186 deletions(-)
> >>
> >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> >> index 92e0a1f7c510..fc0884b12082 100644
> >> --- a/automation/gitlab-ci/test.yaml
> >> +++ b/automation/gitlab-ci/test.yaml
> >> @@ -7,32 +7,12 @@
> >>      - /^coverity-tested\/.*/
> >>      - /^stable-.*/
> >>
> >> -# Test jobs
> >> -build-each-commit-gcc:
> >> -  extends: .test-jobs-common
> >> -  variables:
> >> -    CONTAINER: debian:stretch
> >> -    XEN_TARGET_ARCH: x86_64
> >> -    CC: gcc
> >> -  script:
> >> -    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
> >> -    - mv ../build-each-commit-gcc.log .
> >> -  artifacts:
> >> -    paths:
> >> -      - '*.log'
> >> -    when: always
> >> -  needs: []
> >> -  tags:
> >> -    - x86_64
> >> -
> >> -qemu-smoke-dom0-arm64-gcc:
> >> +.qemu-arm64:
> >>    extends: .test-jobs-common
> >>    variables:
> >>      CONTAINER: debian:unstable-arm64v8
> >> -  script:
> >> -    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> >> -  needs:
> >> -    - alpine-3.12-gcc-arm64
> >> +    LOGFILE: qemu-smoke-arm64.log
> >> +  needs: &qemu-arm64-needs
> >>      - alpine-3.12-arm64-rootfs-export
> >>      - kernel-5.19-arm64-export
> >>      - qemu-system-aarch64-6.0.0-arm64-export
> > 
> > LOGFILE should be listed among the artifacts (and maybe we can remove
> > *.log if it has become redundant?)
> *.log is not redundant because we have 4 logs to be stored, e.g.:
> - smoke.serial
> - config.log
> - build.log
> - qemu-smoke-arm64.log aka LOGFILE
> 
> So we can either have this:
> artifacts:
>   paths:
>     - smoke.serial
>     - '*.log'
> 
> or this:
> artifacts:
>   paths:
>     - smoke.serial
>     - ${LOGFILE}
>     - '*.log'
> 
> I would prefer the former (just as it is now) but if you prefer the latter, it is ok.

I agree with the former


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 01:30:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 01:30:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429463.680452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8lQ-0000Qs-A5; Tue, 25 Oct 2022 01:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429463.680452; Tue, 25 Oct 2022 01:29:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8lQ-0000Ql-7A; Tue, 25 Oct 2022 01:29:56 +0000
Received: by outflank-mailman (input) for mailman id 429463;
 Tue, 25 Oct 2022 01:29:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1on8lP-0000Qf-2l
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 01:29:55 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86b98302-5404-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 03:29:53 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id E7282B816AD;
 Tue, 25 Oct 2022 01:29:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F01E3C433B5;
 Tue, 25 Oct 2022 01:29:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86b98302-5404-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666661391;
	bh=LKH0BsMeCNGK04ojDNl7xuPPsda44v9i3p/GMQsLUrk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=thtgkuroxICQfkoGf5rOQLopKlAcdkJTvdfEdi+lUi0F0d9Imf2K9wHgJ5U38DJuz
	 HHfXAJ17vZXzu/gBER0EgtDN+iMcxLKvo9Q09VjYSCGupapRVp6EW+EzeC2KybwERo
	 gUsqWKTBTpk60aAgnDUiEPEyRz4kvJGTdw0ddYbDS3UkjOnxK4TbLUUQZxpFBnN/Xk
	 r8JRYIbQZ5h7TqmKmFOs8BNwpyBQLzg3vEh56c8d0qPG9hQyhi06Ve99WMAEDDc9pV
	 MdX5DA88tOwHnQ2MdQo/naR2svNtVM+VDEE4K6AcRqv2UJJsaP/194mHJOz4t0RTUH
	 4jjtOlrPiig3Q==
Date: Mon, 24 Oct 2022 18:29:49 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Michal Orzel <michal.orzel@amd.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: Deadcode discussion based on Arm NS phys timer
In-Reply-To: <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
Message-ID: <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com> <8691e100-4548-9752-8e7e-b292643cae83@xen.org> <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com> <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 24 Oct 2022, Julien Grall wrote:
> > On 24/10/2022 12:51, Julien Grall wrote:
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > > 
> > > 
> > > On 24/10/2022 10:07, Michal Orzel wrote:
> > > > Hello,
> > > 
> > > Hi Michal,
> > > 
> > > > Recently I came across a deadcode in Xen Arm arch timer code. Briefly
> > > > speaking, we are routing
> > > > the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use
> > > > of it (as it uses the hypervisor timer CNTHP).
> > > > This timer is fully emulated, which means that there is nothing that can
> > > > trigger such IRQ. This code is
> > > > a left over from early days, where the CNTHP was buggy on some models
> > > > and we had to use the CNTP instead.
> > > > 
> > > > As far as the problem itself is not really interesting, it raises a
> > > > question of what to do with a deadcode,
> > > > as there might be/are other deadcode places in Xen.
> > > 
> > > There are multiple definition of deadcode. Depending on which one you
> > > chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
> > > would result to a lot of places impacted with the decision.
> > > 
> > > So can you clarify what you mean by deadcode?
> > In the timer example, I think we have both a deadcode and unreachable code.
> > For the purpose of this discussion, let's take the MISRA definition of a
> > deadcode which is a "code that can be executed
> > but has no effect on the functional behavior of the program". This differs
> > from the unreachable code definition that is
> > a "code that cannot be executed". Setting up the IRQ for Xen is an example
> > of a deadcode. Code within IRQ handler is an unreachable code
> > (there is nothing that can trigger this IRQ).
> > 
> > What I mean by deadcode happens to be the sum of the two cases above i.e.
> > the code that cannot be executed as well as the code that
> > does not impact the functionality of the program.
> > 
> > > 
> > > > One may say that it is useful to keep it, because one day,
> > > > someone might need it when dealing with yet another broken HW. Such
> > > > person would still need to modify the other
> > > > part of the code (e.g. reprogram_timer), but there would be less work
> > > > required overall. Personally, I'm not in favor of
> > > > such approach, because we should not really support possible scenarios
> > > > with broken HW (except for erratas listing known issues).
> > > 
> > > The difference between "broken HW" and "HW with known errata" is a bit
> > > unclear to me. Can you clarify how you would make the difference here?
> > > 
> > > In particular, at which point do you consider that the HW should not be
> > > supported by Xen?
> > I'm not saying that HW should not be supported. The difference for me
> > between broken HW and
> > HW with known errata is that for the former, the incorrect behavior is often
> > due to the early support stage,
> > using emulators/models instead of real HW, whereas for the latter, the HW is
> > already released and it happens to be that it is buggy
> > (the HW vendor is aware of the issue and released erratas). 
> 
> Thanks for the clarification. What I would call broken is anything that can't
> be fixed in software. For a not too fictional example, an HW where PCI devices
> are using the same stream ID. So effectively, passthrough can't be safely
> supported.
> 
> Regarding, not yet released HW, I don't think Xen should have workaround for
> them. I wouldn't even call it "broken" because they are not yet released and
> it is common to have bug in early revision.
> 
> > Do we have any example in Xen for supporting broken HW,
> > whose vendor is not aware of the issue or did not release any errata?
> I will not cite any HW on the ML. But from my experience, the vendors are not
> very vocal about issues in public (some don't even seem to have public doc).
> The best way to find the issues is to look at Linux commit.
> 
> > 
> > > 
> > > > Also, as part of the certification/FUSA process, there should be no
> > > > deadcode and we should have explanation for every block of code.
> > > 
> > > See above. What are you trying to cover by deadcode? Would protecting
> > > code with IS_ENABLED() (or #ifdef) ok?
> > I think this would be ok from the certification point of view (this would at
> > least means, that we are aware of the issue
> > and we took some steps). Otherwise, such code is just an example of a
> > deadcode/unreachable code.
> 
> Thanks for the clarification. So the exact approach will depend on the
> context....
>
> > > > There are different ways to deal with a deadcode: > 1. Get rid of it
> > > > completely
> > > > 2. Leave it as it is
> 
> ... this is my preference in the context of the timer.

>From a certification point of view, the fewer lines of code the better,
and ideally all the lines of code used for the certified build should be
testable and used.

So I think 2. is the lest useful option from a certification
perspective. For this reason, I'd prefer another alternative.


> If the other don't like it, then 1 would be my preference.
> 
> In general, my preference would be either 3.3 or 3.2 (see below).

I also think that 3.2 and 3.3 are good options for the general case. For
the timer, I can see why 1 is your (second) preference and I am fine
with 1 as well.


> > > > 3. Admit that it can be useful one day and:
> > > >     3.1. protect it with #if 0
> 
> #if 0 should not be used in Xen code. IMHO this is the worse of all the world.
> 
> > > >     3.2. protect it with a new Kconfig option (disabled by default)
> > > > using #ifdef
> > > >     3.3. protect it with a new Kconfig option (disabled by default)
> > > > using IS_ENABLED (to make sure code always compile)
> 
> I would prefer 3.3 over 3.2. 3.2 would be used if it is too difficult to get
> the code compiled when !IS_ENABLED.
> 
> Similar to one if this is to move all the affected code in a separate file
> with using obj-$(CONFIG...). That would only work for large chunk of code and
> would be preferred over 3.2.



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 01:35:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 01:35:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429469.680467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8qV-0001zO-4f; Tue, 25 Oct 2022 01:35:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429469.680467; Tue, 25 Oct 2022 01:35:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8qU-0001zH-UW; Tue, 25 Oct 2022 01:35:10 +0000
Received: by outflank-mailman (input) for mailman id 429469;
 Tue, 25 Oct 2022 01:35:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1on8qU-0001y8-1j
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 01:35:10 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130055.outbound.protection.outlook.com [40.107.13.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4154549f-5405-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 03:35:07 +0200 (CEST)
Received: from AS4P192CA0012.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::20)
 by PAVPR08MB9699.eurprd08.prod.outlook.com (2603:10a6:102:31e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Tue, 25 Oct
 2022 01:35:00 +0000
Received: from VI1EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:5da:cafe::30) by AS4P192CA0012.outlook.office365.com
 (2603:10a6:20b:5da::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 01:35:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT034.mail.protection.outlook.com (100.127.144.165) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 25 Oct 2022 01:34:59 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Tue, 25 Oct 2022 01:34:58 +0000
Received: from a7622d7f2350.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 63DE547D-CF02-4C4D-860F-CF5DE72A686C.1; 
 Tue, 25 Oct 2022 01:34:53 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7622d7f2350.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 01:34:53 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9954.eurprd08.prod.outlook.com (2603:10a6:20b:638::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 01:34:49 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Tue, 25 Oct 2022
 01:34:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4154549f-5405-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=S7slj3cDWrGOMMgCiOFEOMQXPazSGAZ/gHxsJkJjneTJZAbhOBt61zNfmX1nfm/6UlSfbh1vCgS7vLk0osGU+HOtjFJf6ZmNHj5ac9sjnOIyReskvGbgHgtSJVLzY3Fe2gZyJ02PmU9yNEjs5m2bIQlquZD7pU8YExyMRth1doGVi7FJAa36+a8Ca93sBjvJZHRp8X8s1bpmr7hbVA1V0RAaX2KN87hXqKZDzvTIMe/DZ7TIrB8R8YukNd65xPPRjMZzips/6FF1JU9bitrPIGP0zuBe9mZS/v/RZtSMZ/9kpNuQq/5vGo4x2i1J1ZTG6BVWsz79tPlw1wK39RRLKA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QoqdFGHZfe9bo5NAlol0Mzq2Y+3sE2s88KNckVqwgAI=;
 b=cpkc08hkXxZ/jfDnhZ51Fccm7sMEyOj14Mphxqa2FbL4xVnvpukCXdhoOKEfT2je60YN6NsLvDL5KGUyKJ7LS7paktYVnroXpmRsiyh2DfCFoYQhMFFaV002tqb2Iywz9jabmJ9eSkem+GYWUy0QGmyediSeh6oZHdj04Wf2jwhElh5bBUUf9ad9So93UmrF/4kC4nBVnVdaNjxAXtEVmz65MFQhQk36Ngf7HBNKQ55JT7ILOVemzHuJ8f/9BOrMnESjtw3zlCIz01AXyvZ90Q5MzwODRxnf9/kJXwDMKlylHroJARz35BJjx3iCjUi5eYeRvIoEoE4N745nkTL6+A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QoqdFGHZfe9bo5NAlol0Mzq2Y+3sE2s88KNckVqwgAI=;
 b=p/x42PoQPLUEctyOLhnt/f59rHkRzuVAhGy7Ni/9oN68EU+yr2mOXHzgzP+rVOG49LCNPV8aM4kD639VYlZqiQPG9AbhmTxI4dXHgnh96GNV7XCoIQ4o1S8Uq1YkmV4O+Uwc479QrgtQIQ66J52zmeUeg85nHrRSqnuQKXNtrGs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bomybA0vYaouKrA/7PSUbThqCHXIZwq7yTou0A+YuOdu0IKd3jqY4O9RI7BPYpNLJNB0VguEZfj0ADtj3UDW2dQ+MIe5HUFTLKpPLDXUwXSEXcKEKNK+Hxrto95eSfOJeHaPmGVxX0VgNySQC5QhsrA+C66zNHUINKU+bpXIw7nIpJSUu8G3MvFOyLOHXZcmIPYwZFtunL8DXsWACQ5tbRQARFnPO1Z3VTtUVnPvBRMwGM8/gaMhhUke1d1XuNu5WWN/3CGz5rKUnJGYb8k0SdAvdS1glyS0ALvS6Tnvu2qC5q32NhrLwV/Dvew0EQTzStTniFYV8aqqV0fcSNB/Zw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QoqdFGHZfe9bo5NAlol0Mzq2Y+3sE2s88KNckVqwgAI=;
 b=QNRKPbHg99owKUhoV+FnB7JcrL0Gg7e76Rru5xZr2HTQVyuDIS1X42PYx7g+EeNQSrF26J27Dqe5nqp+/HgV5yP6z9vNQ/udydMG/CKlmZdFn9EsfGXszkFjEZnVsxgfi7gjDOfMOlgaYKP+SNh/dFOrom3BJxqo+/P3tNrxdHFeNo1K3Jc67ugJXIFdXXfOFRfJh0K8gTJXDwD5Ar1JaYrP/nch44u7CGNEwMBXmQhMI37D1F8Fy6iKgALM3uzVvlr3W0qbZFNj4OCb39P3+BiAnq9Febyif87+aZuNB6s6TRej+dd5ffYAg2Jztqh0rFNf4UrjNpuCsMZpvQJpXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QoqdFGHZfe9bo5NAlol0Mzq2Y+3sE2s88KNckVqwgAI=;
 b=p/x42PoQPLUEctyOLhnt/f59rHkRzuVAhGy7Ni/9oN68EU+yr2mOXHzgzP+rVOG49LCNPV8aM4kD639VYlZqiQPG9AbhmTxI4dXHgnh96GNV7XCoIQ4o1S8Uq1YkmV4O+Uwc479QrgtQIQ66J52zmeUeg85nHrRSqnuQKXNtrGs=
From: Henry Wang <Henry.Wang@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>, Michal Orzel
	<michal.orzel@amd.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>, "Andrew.Cooper3@citrix.com"
	<Andrew.Cooper3@citrix.com>
Subject: RE: [for-4.17, PATCH v2] automation: Explicitly enable NULL scheduler
 for boot-cpupools test
Thread-Topic: [for-4.17, PATCH v2] automation: Explicitly enable NULL
 scheduler for boot-cpupools test
Thread-Index: AQHY56Dh3WoyrbPBzESSx3/Zf+sWVa4eTsyAgAAFwFA=
Date: Tue, 25 Oct 2022 01:34:43 +0000
Message-ID:
 <AS8PR08MB799168EFE670DE74F2EAD86792319@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221024120443.16202-1-michal.orzel@amd.com>
 <alpine.DEB.2.22.394.2210241810200.1151068@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210241810200.1151068@ubuntu-linux-20-04-desktop>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: DDEF1D1DC8E50B4F87D4AE5EA6CE25E7.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9954:EE_|VI1EUR03FT034:EE_|PAVPR08MB9699:EE_
X-MS-Office365-Filtering-Correlation-Id: 4995ce3d-26b3-4dd0-22f4-08dab6292128
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 AqB7WwTHe4u3ii2njESdaedQH2SI5vxh7k9zr4l1T9NG11SpQQfwqzzmeyxYY/teWCR47CbeBFI3hwFGXkl8O3fNM9HylJ8KEwxnUCrDP6n+8VPoYqj3vuDjcv+0qn4gpI+HHvl7ldfjt5b7HJ/i/M6d5l3xxRh+Hf/tkuKVI7Q1qgDcvLyz4xz4cN6IDxrzuMbi4MWKMwCFWZJIjifQaLRUFOso4CV0WC/fhkgU7+xjZK1Uup8kqIXorkYw4fc+VhsYhJyK+QV6poEl0vAPVZjTyb3Jz9vGRewqgWwoJcpOk19qhmAjZXmdH5ZFyS4o+6RvxB2myD3V11lS1Lp6lpq5jIwY/YcQdNdLlS3m6rOmhkuOIDUlF9K0jurapEg0WMeydTphfW5/+4uGDCksJRshZmDuG54MxeMgKM6i7QvhlCcvGDLQP5b1KZTLg4wtis5xL4LSPvvX3V6qeSHv5XIYaH23HOeMzvcAAL0ncld+BVWkb0JQOtHn7aGYVl9gcTmY1ELxOdpOWVnYq85j91z+9lexFg0CfACqyL1E9sB08Hc/rAFSem0nAqnhUhsXaca0zMhTpOw1I5czjttkLUc4GYMjtlSbkkb3s6TOGrzfkaHFP5HkakNMyHYVbiaQBLnmdkZ3g8EK8bR6Umne5OZztyIgjhlKCbO2+yZpLgTTm6GZvqqkfYMvtexUvJ2QDf7HR5UDyNB/YljjuNo96Bx5oi5D4uYuVKTAT0u+MuXMk7Ccxlm+nbdyR17G4OzGQvK9+l2NX889NIfvPqfg/Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(71200400001)(83380400001)(86362001)(478600001)(110136005)(8676002)(4326008)(7696005)(41300700001)(9686003)(26005)(5660300002)(316002)(76116006)(66946007)(64756008)(66446008)(66476007)(66556008)(6506007)(54906003)(52536014)(8936002)(38100700002)(122000001)(33656002)(55016003)(186003)(4744005)(2906002)(38070700005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9954
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a93c62a4-e29b-4d27-319b-08dab62917c0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vzEUPBUp0BZwytGGZ3lmKOnHGZ/Aj6MynIz9dvUWBiDbVZcMXhJCj4oqfYk5TsTlvrUnRJKPkJrmBVSrDik4IKseJ1P0mkQw7l7ISXOHiL+WlF0KVNgn1GI7IYBDB8z3+cGFExp/1rOUB6iaofeZROhdvMRq9Llom055VE5VZ3CLEl1B8gM10RZuBgTHR0IgLJnB+trfuFZTBEqozxOMS7oOGBxUt/IT1bJVnYeX/HJz/GIJAAWGYCpXu16LTV0ollqXTICOEpYPdF5dphPaNbH3cJHb7Q+zqT6N7MT+AXLbgjf+m2QDLG1lvtUdtlT9hi5+9H0u78QhQdP3jCD7cJGX86BJJXbHdVn8pJcwzSSTg43KlVIsZ7OWmXL5Dl1llO0udexyOiYst0JqZ92RLYJwBU0LH4QtZlCq8EVVmGY0sM8G26ohymriTfCM3r/OrXw6aWlJEMUBH4afU0mM49WhdU7Mn8heRrw4WiDbeEmJSCzowfoAnVq3TqTbxvfcGJKTsXYG32AuMdiZO53KwaV3w9WcpUdDLpWu0vewlw+o0fcXPU/XHBxfLD4noSQtxslFeIeyogNd5ScjcqtDLv2Qrce435hbBKmYVpojKRNzBoTxeq5jwHIZOGjs6ttCprW9QkNkCBlkLrDF0lCGupTqF/iGe0UO7dA9vCqd8SeHL/RxfsmY5IzC0e6wHGicrBhI+UMpF++4xjwbU6Y9muihBdn0IjnnjUyLmJIwu2h6/Dk/LVJwk0LFnv9ImqkdZ+rt912HbaZrdiKYEPcaXQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199015)(36840700001)(40470700004)(46966006)(186003)(8936002)(5660300002)(2906002)(4744005)(36860700001)(82740400003)(336012)(83380400001)(47076005)(86362001)(33656002)(356005)(81166007)(54906003)(26005)(110136005)(478600001)(9686003)(40480700001)(40460700003)(70586007)(316002)(55016003)(107886003)(70206006)(41300700001)(8676002)(4326008)(52536014)(6506007)(7696005)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 01:34:59.1445
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4995ce3d-26b3-4dd0-22f4-08dab6292128
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9699

Hi Stefano and Michal,

> -----Original Message-----
> From: Stefano Stabellini <sstabellini@kernel.org>
> Subject: Re: [for-4.17, PATCH v2] automation: Explicitly enable NULL
> scheduler for boot-cpupools test
>=20
> On Mon, 24 Oct 2022, Michal Orzel wrote:
> > NULL scheduler is not enabled by default on non-debug Xen builds. This
> > causes the boot time cpupools test to fail on such build jobs. Fix the =
issue
> > by explicitly specifying the config options required to enable the NULL
> > scheduler.
> >
> > Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time
> cpupools on arm64")
> > Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>=20
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>=20
> I would like a release-ack by Henry on this

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 01:37:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 01:37:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429473.680477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8sl-0002aJ-ES; Tue, 25 Oct 2022 01:37:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429473.680477; Tue, 25 Oct 2022 01:37:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1on8sl-0002aC-BF; Tue, 25 Oct 2022 01:37:31 +0000
Received: by outflank-mailman (input) for mailman id 429473;
 Tue, 25 Oct 2022 01:37:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1on8sj-0002a1-Qs
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 01:37:29 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2056.outbound.protection.outlook.com [40.107.247.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92570e43-5405-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 03:37:26 +0200 (CEST)
Received: from AM6P195CA0057.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::34)
 by PAXPR08MB6655.eurprd08.prod.outlook.com (2603:10a6:102:15d::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 01:37:19 +0000
Received: from AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:87:cafe::b8) by AM6P195CA0057.outlook.office365.com
 (2603:10a6:209:87::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27 via Frontend
 Transport; Tue, 25 Oct 2022 01:37:19 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT007.mail.protection.outlook.com (100.127.140.242) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Tue, 25 Oct 2022 01:37:18 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Tue, 25 Oct 2022 01:37:18 +0000
Received: from 75660960c6f0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 48317792-CA1D-427C-8AB9-D97FFCBDDB56.1; 
 Tue, 25 Oct 2022 01:37:11 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 75660960c6f0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 01:37:11 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9954.eurprd08.prod.outlook.com (2603:10a6:20b:638::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 01:37:10 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Tue, 25 Oct 2022
 01:37:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92570e43-5405-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=EtSECTB1te3b9s3gd4DEiNURB83Ihwxpqc/GIlTsvPmheR6f9/Msv+4JR+MN6YwB6ggZXAgeOd3gwE/I5/aL26/oZ5u2sFBIEshtG29wJOhUkjXaZ8p16zYmrB3E0Cypz7JrJJUKExIcagf3DMh+qwyoA/o9hGFWZQT/e8FsxgYxNmydaXRJh+gKwZ/5axfGvDZKpTXqBaPzFCB+EiZtExtpuZPJn5Ye7Jla0E/qIwcY9hzXaFSr24Z/xgR0YsOOrBB0p47eluKjVWAFJqCpRbdzyF88Woso2Ticat+3AsxEl5TTuW4aBHYxCLVQ8cSe8FVPySX8D9oKJTIsiJK/RA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sy4GetQrtuFJxe2BCgivJMT2+U89l6xSoj67JwFAm3g=;
 b=UgixAHEsZBMZIi38JVAmWk12t0c1nIybDNCYAvhZKVocOyBhocz+fae1Dsl0Ri/+uP6lRBUsGqX5wFTeMkOocs/1u8+sfi7SC15sfEsvIMRRZV+20cSwksVe0e3C3us1ZAoUo/GImc0UkS/wTSjc/EdZ/qfiZsVpkIyg18j1y4gESPy2lzUgnDMMrqwCguiQZAuSQ1rHJ5UFTu4tM2Il6xeWGkurq/zNIsaIIIBU9Weugq8PQe6KKcKq7E3gpHko63ivP+QGIn+0ed3x8yTieKgR/olMgiAfS1UJ8sdtEFyWSP+yt1dDJOtmqC5llb4mzCdw2AJybdTamCzunJ6ESA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sy4GetQrtuFJxe2BCgivJMT2+U89l6xSoj67JwFAm3g=;
 b=1442AuybxYy1wYuSnudn66QsxXnuZxnY99sWTXs4dRqUWZmKo6tJOXd/GEjL96qCpTNkEge1aK9XeIOFJR3MhZ2n0YXBsn1XNtmgMpAYnmNcit4YSL8E0c+nQhUoU7CsqviQLSLjsRUcXJwIVl0EQuKhRfZAK3q2/jWw5z3YjZI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LZGQQIkixQSqSlIR94hrKwabnRmS5pdQD7/9fbYM7oLRkcANLbzmU4m1mkR/W4POLWGIrFRDTqKgfr5uTH2kVcOFDFlULoCzDrvkJEflm2gf5ScLNeAwpy0WrNRsM0xJIg/J20eObhGExkuziOVcrRJEqCVkesQIHeh8Jzorf5UVi/CWNQ4ut2sBSz1WMYkShRizeprtBwQFYO2DI/Rj8ZEbBCQHiMVPbtqfEfIvG6st4PlwnDbRsJNJb5174F4SPn/dpbugxkzBBKjOj6Umw+BWQHey2YsF514nMxJVJgnMJzMBcuNLCeUpiP3WRncQethAvOyoGZwzrbSHXMsU2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sy4GetQrtuFJxe2BCgivJMT2+U89l6xSoj67JwFAm3g=;
 b=ef7m/X1kTDxQPI4Lo12qdf1TSrR0Xk7Sj2YCvFkWiTTsHg9eGf6tGfqA6ZSao2xRcFbjOnouZ/kGBkfSefIgau8MQr5/BOCFnzrnaFp7Q3pRnKx1eKrHCWFDv83TUer2H0AFjwqhDcqJ504HVhJ2mrnenbOsuoUeHuecqCjBPS+BAQEiHIcAmKpTavP3e8nOUkNHe0WCyZXMXXFttpfbEa3vpgoRmXZdp8IaG3vV6gZQG4aW2XDee6luVUpWqS3MrCehqvwbJgeckKqBa8B1NmF4ruafGfpNDFJYvlkYvteGyy010f4HxIIMLi3lZMW2vGfVXhVkaQivmfDuRUvyCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sy4GetQrtuFJxe2BCgivJMT2+U89l6xSoj67JwFAm3g=;
 b=1442AuybxYy1wYuSnudn66QsxXnuZxnY99sWTXs4dRqUWZmKo6tJOXd/GEjL96qCpTNkEge1aK9XeIOFJR3MhZ2n0YXBsn1XNtmgMpAYnmNcit4YSL8E0c+nQhUoU7CsqviQLSLjsRUcXJwIVl0EQuKhRfZAK3q2/jWw5z3YjZI=
From: Henry Wang <Henry.Wang@arm.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"xen-announce@lists.xenproject.org" <xen-announce@lists.xenproject.org>,
	"xen-users@lists.xenproject.org" <xen-users@lists.xenproject.org>
Subject: Xen 4.17 rc2
Thread-Topic: Xen 4.17 rc2
Thread-Index: AdjoEhxyixPCcedBRYu3jXFHtM5cvQ==
Date: Tue, 25 Oct 2022 01:37:10 +0000
Message-ID:
 <AS8PR08MB79910CE0A7D0DD8EF27280DA92319@AS8PR08MB7991.eurprd08.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 7247F90ABC07064098E482DE10019132.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9954:EE_|AM7EUR03FT007:EE_|PAXPR08MB6655:EE_
X-MS-Office365-Filtering-Correlation-Id: cc4c267e-6360-40e0-7c0b-08dab6297456
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 JNrDULuHSW3h/v4dhY8xDxu3YnQJK7ipRzXpB8Zx3prTCu7l6lHuunYxdBl+BZJoWh/7a1JWUP39EKbQ2qBdBpuHdRnmJyizGxg9Z2lvz0hxhkDtkOGybAx0RFQv/yXBjO28GOu2Q6bWO0BCA407vpHJtlBvt5MZCV2yiyP/ZhU2ETIuOhIHpVxHbnGqz05T7W9ZKB6BdDK+AmN0ASsH9FhP2oXP5idnFC1BLLUDPQCAhwrSls8JBbRrYaQnkWWD3M9Jc6uxQH2C6ZYyhCzrP6rMCmOCirJlTosub2Nt6hqo1wU+EdXrMTq/Of5Qf6WXc2+Swq+wMFbnTf7leoa7JAP/0mDxYDMDAJebBZIxi9zcxXyg/shUw8idGD7RVP0MiFHxDLlUrr3+Ub4NdVfzSZ9uIlUe8xdA+SNTO5Fwq69NnNOWSBDuySBlYdSadbe3PwcFUfu8iK4hrvI6M7xhfR6upM2lUqlMzlE5wN3MSy5kwnUSTNTGr/7WKDIy96D6SzEIfJGlN7XDi7SIPq0pI5ZA/J1lU6KsazYVAuvEpUr7ys5azYDRIy6asyGY5rs9h4XwNNlEnr5mLx8Wj6okgTGAebOLFeZWnfRYq2sFd+UnTIZO9hR61Jz7U+1Q7noYPMnVPCuOpCKIeIrQ4f0lA/PPGRF67jTuU5wWMSTx/iFzUjA86l687YuokxdNCEkal7bDczhkMZN5Tx4cBcB+lhlfInQE+X7XhG0KElg45udL8e8R0t9E2QzzVFilHfJ1ulQMyaTKaAWAH7ycesoSHm6cS5yKEDPuL0I7RODugCE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199015)(71200400001)(83380400001)(86362001)(478600001)(966005)(110136005)(8676002)(7696005)(41300700001)(9686003)(26005)(450100002)(5660300002)(316002)(76116006)(66946007)(64756008)(66446008)(66476007)(66556008)(6506007)(52536014)(8936002)(38100700002)(122000001)(33656002)(7116003)(55016003)(186003)(4744005)(2906002)(38070700005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9954
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2fc3abc5-82c9-4f40-ede3-08dab6296f6f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bguSmOFImGLZm9UTA9cqSvyHhvXqOfU851H0MVk2K+OQ52zChWa/+6OYpyY25uhvD8nYLuUNjRUq5ymo/MSmp5hvOdgdxZv2U06hMvOZ1fPRwxjIeKffDQmLaX5bfa4+3K01jsvl/b96f/du2GzrOVJK134kiW+9/GvUkMYENZE8vIAGp38rxHCxzcOdtru1jfKKWNcrp62QtYwDpz25TrWFDKwFOkgFoly4y9aKN8d2TXf7fKbXVGmyKv9cLTMpwfhpPkeCvgkJowDS5j4gxK7/PW2FfBIBFDkv5qo60cCAxZnsJ+aXXmhN/PchZsKZh6s74A0r8EfE0Fymn1+asnB8ptleRlboOEYsi3IgZbSSsNArot+d22FrujRKYUZXJWecFlHJXeGJ08p7hPSBtODS8SF8wEgsZJjcLtv/zLqG80XNUcQ/d/JQrNVHa0Wca7kayFkm1y2deVH9F+4fSunI37vzgvsevCQrxX6i+vuYZ64i8F+8enNjGollzE/bN42r5oPeIRcTTEyv580isgVMHc4srIG7ZvMdFo5n3CRblKzxuqD/VGXPEPq92q4lVCqV3ckvE9Cq2QtIvfPNOVxMdW3r7eJKB7qBloH9wRiZMXjY9Hp9s7eY1aoZOSOsvoMekedLjTUa0J6xeP/t/f0L4cUoBL4Z04qn3xkzf0jee6QJPirHetCZFPnEkCcuW0qm48CLIvdmKQCve/7t6j5gNpLnuDW4nXfg1tuxQjHwel9Vdk2ahRLMF4IdTUMoDVuO2JHW3SOzWdyzTk8w37kTZ2Wf7j4mjUmRTVn/EfU=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(5660300002)(36860700001)(70206006)(70586007)(33656002)(8676002)(316002)(40460700003)(55016003)(450100002)(110136005)(52536014)(82740400003)(7116003)(40480700001)(81166007)(8936002)(356005)(41300700001)(83380400001)(47076005)(26005)(9686003)(7696005)(336012)(82310400005)(186003)(6506007)(86362001)(4744005)(966005)(478600001)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 01:37:18.7148
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cc4c267e-6360-40e0-7c0b-08dab6297456
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6655

Hi all,

Xen 4.17 rc2 is tagged. You can check that out from xen.git:

git://xenbits.xen.org/xen.git 4.17.0-rc2

For your convenience there is also a tarball at:
https://downloads.xenproject.org/release/xen/4.17.0-rc2/xen-4.17.0-rc2.tar.=
gz

And the signature is at:
https://downloads.xenproject.org/release/xen/4.17.0-rc2/xen-4.17.0-rc2.tar.=
gz.sig

Please send bug reports and test reports to xen-devel@lists.xenproject.org.
When sending bug reports, please CC relevant maintainers and me
(Henry.Wang@arm.com).

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 03:21:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 03:21:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429536.680529 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onAVU-0006nG-R7; Tue, 25 Oct 2022 03:21:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429536.680529; Tue, 25 Oct 2022 03:21:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onAVU-0006n9-OW; Tue, 25 Oct 2022 03:21:36 +0000
Received: by outflank-mailman (input) for mailman id 429536;
 Tue, 25 Oct 2022 03:21:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=F3CU=22=gmail.com=xxc3ncoredxx@srs-se1.protection.inumbo.net>)
 id 1onAVT-0006n3-OF
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 03:21:35 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 20a9cdd5-5414-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 05:21:34 +0200 (CEST)
Received: by mail-wr1-x431.google.com with SMTP id z14so5287495wrn.7
 for <xen-devel@lists.xenproject.org>; Mon, 24 Oct 2022 20:21:34 -0700 (PDT)
Received: from dj3ntoo (171.sub-72-110-15.myvzw.com. [72.110.15.171])
 by smtp.gmail.com with ESMTPSA id
 h10-20020a05600c314a00b003b47b80cec3sm9933587wmo.42.2022.10.24.20.21.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 24 Oct 2022 20:21:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20a9cdd5-5414-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc
         :subject:date:message-id:reply-to;
        bh=eTnwREWlqkIf0C+tQK1BYatGy5JJBtcEmRypgG1tfC8=;
        b=FFlo3E3AJ6gVOkkZ877m15eYpdvi+2vc0258y0EJSMrwws0Qo8aEbAQ3uYBO3mBpGV
         29QAPHVYzNVTF4prYWv/UTK3lKC6OSvgQwp9ZfKhRazFNHnHbVdjntwpi+GwA5aCimBw
         MgCszF0dO8q2g+Nd0Uav92QDdAbINLMaNgdO7vkutDTjenvwxTS9C6/nl9FfzFnRTdel
         FG0ZIqArzUpturRNSoiqH5h93JmWsnlzcg/Ty1wnill8/+H/weU2I7c4LZ142npcYi5M
         0oHYgDleI9J8zFhVLzTSRRNMpSASd8Le6RyNXEfVEPrXiGQ3Ea6Q2BreFCv+b7QD1YnW
         Fobg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references
         :mail-followup-to:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=eTnwREWlqkIf0C+tQK1BYatGy5JJBtcEmRypgG1tfC8=;
        b=iIJkJGZyd2j6dcNzZCPM77V2dwTVH0/FMeJFOB/GPI2/huyNP/ruXToFCYEs5Rkiap
         rmRG4BdeMJVGvyyLjhKIJQYMmHi+Eg89QcQIOytaeAX+mga2X8fCVZ7CZxh6vVt62sYz
         6OC7Z/iTuBl4nwRyJAAkVmK4KFZ57kTkGETekBn9/mO4FZd9AINotm9qUZPxpOtEaPmU
         wBgs89WTdMHHfEBXyINZFfeVW/Jvsr+uS39KuJSAx77KeSB0huoxfAvD5d6Ro/9xWtCd
         kxMBYtUUeTtbBX1WAwXIuKQlcXD6vcOg0xtEptJF+Aa+HRkl+bPttUG9SIP3w7JqPBKA
         pjdg==
X-Gm-Message-State: ACrzQf1tK0rvfhx9dtYLg4Lc1tWuC1WUx/znkSo1P/P+Kl+7MUpBZnuh
	86r/Q7N4A3szgIqqso3d+xE=
X-Google-Smtp-Source: AMsMyM5XJApCOKG2D9tkZVO19Ozd/wp3HBGy2skSFF6/cK/qNc8usr9jwO5pYpUtNZW+RUggIAoVPw==
X-Received: by 2002:a05:6000:a09:b0:236:6b18:6b30 with SMTP id co9-20020a0560000a0900b002366b186b30mr7544228wrb.356.1666668093838;
        Mon, 24 Oct 2022 20:21:33 -0700 (PDT)
Date: Mon, 24 Oct 2022 22:21:25 -0500
From: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
To: grub-devel@gnu.org
Cc: Denton Liu <liu.denton@gmail.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org, Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v5] templates: introduce GRUB_TOP_LEVEL_* vars
Message-ID: <Y1dWNXeWlLUdxbFm@dj3ntoo>
Mail-Followup-To: grub-devel@gnu.org, Denton Liu <liu.denton@gmail.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	mathieu.desnoyers@efficios.com, rharwood@redhat.com,
	samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org,
	xen-devel@lists.xenproject.org, Olaf Hering <olaf@aepfle.de>
References: <20221024104642.251016-1-liu.denton@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="M+Fpb3cxK4PU3FTu"
Content-Disposition: inline
In-Reply-To: <20221024104642.251016-1-liu.denton@gmail.com>


--M+Fpb3cxK4PU3FTu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 24, 2022 at 03:46:42 -0700, Denton Liu wrote:
> A user may wish to use an image that is not sorted as the "latest"
> version as the top-level entry. For example, in Arch Linux, if a user
> has the LTS and regular kernels installed, `/boot/vmlinuz-linux-lts`
> gets sorted as the "latest" compared to `/boot/vmlinuz-linux`, meaning
> the LTS kernel becomes the top-level entry. However, a user may wish to
> use the regular kernel as the top-level default with the LTS only
> existing as a backup.
>=20
> This need can be seen in Arch Linux's AUR with two user-submitted
> packages[0][1] providing an update hook which patches
> /etc/grub.d/10_linux to move the desired kernel to the top-level. This
> patch serves to solve this in a more generic way.
>=20
> Introduce the GRUB_TOP_LEVEL, GRUB_TOP_LEVEL_XEN and
> GRUB_TOP_LEVEL_OS_PROBER variables to allow users to specify the
> top-level entry.
>=20
> Create grub_move_to_front() as a helper function which moves entries to
> the front of a list. This function does the heavy lifting of moving
> the menu entry to the front in each script.
>=20
> In 10_netbsd, since there isn't an explicit list variable, extract the
> items that are being iterated through into a list so that we can
> optionally apply grub_move_to_front() to the list before the loop.
>=20
> [0]: https://aur.archlinux.org/packages/grub-linux-default-hook
> [1]: https://aur.archlinux.org/packages/grub-linux-rt-default-hook
>=20
> Signed-off-by: Denton Liu <liu.denton@gmail.com>

Reviewed-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>

I've tested it on Linux, but the other platforms and os-prober are still
untested.

- Oskari

--M+Fpb3cxK4PU3FTu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQfOU+JeXjo4uxN6vCp8he9GGIfEQUCY1dWLwAKCRCp8he9GGIf
EQlWAP9KzyNwrmNeoh+pUYxfKaD0KqahfOci3jRBPT5HTjkWsgD6Ags50AtOFgwZ
xGBmMRE5PQwxdn1oBD84vPzhTLcF9wM=
=b5NF
-----END PGP SIGNATURE-----

--M+Fpb3cxK4PU3FTu--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 04:32:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 04:32:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429546.680549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onBbs-00066r-2u; Tue, 25 Oct 2022 04:32:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429546.680549; Tue, 25 Oct 2022 04:32:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onBbs-00066k-0I; Tue, 25 Oct 2022 04:32:16 +0000
Received: by outflank-mailman (input) for mailman id 429546;
 Tue, 25 Oct 2022 04:32:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ep8Y=22=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1onBbq-00066e-AB
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 04:32:14 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fead01cb-541d-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 06:32:12 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id DFC4A22055;
 Tue, 25 Oct 2022 04:32:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78062134CA;
 Tue, 25 Oct 2022 04:32:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id z5uIG8tmV2NWMgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 25 Oct 2022 04:32:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fead01cb-541d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666672331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7slYQYXkLjxXSTb9Jmeg4pGsOIyxx4med/b1FY0v2wM=;
	b=OvRCnC/1X/LLTSN+t4KH5CIzknOCg51f0jnD6BYkfdeEo2k8YOJ/bTMPjZBHNWHZAx8SQr
	vUf9w+fvU0mrI84wOpke1m7Nj/DAcGFwnT06b4NBOqL5g/rzRdb3grXfouVeH+gNl6TMXS
	/GmE8IuWTBUb6CPstr6mIJw6OTUEI24=
Message-ID: <59eab6d2-6710-a941-6e7d-7efe8dcf0f1b@suse.com>
Date: Tue, 25 Oct 2022 06:32:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: jejb@linux.ibm.com, Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
 <aa9ebdef1f1dbfceb5a32f5f437b865861976957.camel@linux.ibm.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
In-Reply-To: <aa9ebdef1f1dbfceb5a32f5f437b865861976957.camel@linux.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------0rlDa9SQfT94UR4QIRjJLU0o"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------0rlDa9SQfT94UR4QIRjJLU0o
Content-Type: multipart/mixed; boundary="------------nQfmobi3WurtVZY3p8acHADl";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: jejb@linux.ibm.com, Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
Message-ID: <59eab6d2-6710-a941-6e7d-7efe8dcf0f1b@suse.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
 <aa9ebdef1f1dbfceb5a32f5f437b865861976957.camel@linux.ibm.com>
In-Reply-To: <aa9ebdef1f1dbfceb5a32f5f437b865861976957.camel@linux.ibm.com>

--------------nQfmobi3WurtVZY3p8acHADl
Content-Type: multipart/mixed; boundary="------------Tyxf3ySWUJiDFRHH0ip3jqDx"

--------------Tyxf3ySWUJiDFRHH0ip3jqDx
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMTAuMjIgMjA6NTAsIEphbWVzIEJvdHRvbWxleSB3cm90ZToNCj4gT24gTW9uLCAy
MDIyLTEwLTI0IGF0IDE0OjU1ICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPiBbLi4u
XQ0KPj4gUGxlYXNlIHJlY2hlY2sgdGhlIGJhY2twb3J0ZWQgcGF0Y2ggaW4gNS4xMC55LiBJ
dCBpcyBfd3JvbmdfLiBUaGUNCj4+IGJhY2twb3J0DQo+PiBoYXM6DQo+Pg0KPj4gLS0tIGEv
ZHJpdmVycy9zY3NpL21wdDNzYXMvbXB0M3Nhc19iYXNlLmMNCj4+ICsrKyBiL2RyaXZlcnMv
c2NzaS9tcHQzc2FzL21wdDNzYXNfYmFzZS5jDQo+PiBAQCAtMjk5Myw3ICsyOTkzLDcgQEAg
X2Jhc2VfY29uZmlnX2RtYV9hZGRyZXNzaW5nKHN0cnVjdA0KPj4gTVBUM1NBU19BREFQVEVS
ICppb2MsDQo+PiBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+DQo+PiAgICAgICAgICAgaWYg
KGlvYy0+aXNfbWNwdV9lbmRwb2ludCB8fA0KPj4gICAgICAgICAgICAgICBzaXplb2YoZG1h
X2FkZHJfdCkgPT0gNCB8fCBpb2MtPnVzZV8zMmJpdF9kbWEgfHwNCj4+IC0gICAgICAgICAg
IGRtYV9nZXRfcmVxdWlyZWRfbWFzaygmcGRldi0+ZGV2KSA8PSAzMikNCj4+ICsgICAgICAg
ICAgIGRtYV9nZXRfcmVxdWlyZWRfbWFzaygmcGRldi0+ZGV2KSA8PSBETUFfQklUX01BU0so
MzIpKQ0KPj4gICAgICAgICAgICAgICAgICAgaW9jLT5kbWFfbWFzayA9IDMyOw0KPj4gICAg
ICAgICAgIC8qIFNldCA2MyBiaXQgRE1BIG1hc2sgZm9yIGFsbCBTQVMzIGFuZCBTQVMzNSBj
b250cm9sbGVycyAqLw0KPj4gICAgICAgICAgIGVsc2UgaWYgKGlvYy0+aGJhX21waV92ZXJz
aW9uX2JlbG9uZ2VkID4gTVBJMl9WRVJTSU9OKQ0KPj4NCj4+IFdoaWxlIHRoZSB1cHN0cmVh
bSBwYXRjaCBoYXM6DQo+Pg0KPj4gKyAgICAgICBpZiAoaW9jLT5pc19tY3B1X2VuZHBvaW50
IHx8IHNpemVvZihkbWFfYWRkcl90KSA9PSA0IHx8DQo+PiArICAgICAgICAgICBkbWFfZ2V0
X3JlcXVpcmVkX21hc2soJnBkZXYtPmRldikgPD0gMzIpIHsNCj4+ICAgICAgICAgICAgICAg
ICAgIGlvYy0+ZG1hX21hc2sgPSAzMjsNCj4+ICsgICAgICAgICAgICAgICBjb2hlcmVudF9k
bWFfbWFzayA9IGRtYV9tYXNrID0gRE1BX0JJVF9NQVNLKDMyKTsNCj4+DQo+IA0KPiBUaGF0
J3Mgbm90IHRoZSB1cHN0cmVhbSBjb21taXQuICBUaGUgcXVvdGVkIHVwc3RyZWFtIHBhdGNo
IGluIHRoZQ0KPiBzdGFibGUgY29tbWl0IGlzOg0KPiANCj4gaHR0cHM6Ly9naXQua2VybmVs
Lm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L2NvbW1p
dC8/aWQ9ZTBlMDc0N2RlMGVhM2RkODdjZGJiMDM5MzMxMWUxNzQ3MWE5YmFmMQ0KPiANCj4g
V2hpY2ggaGFzIHRoZSBzYW1lIGRpZmYgYXMgeW91IHF1b3RlZCBmb3IgdGhlIHN0YWJsZSB0
cmVlLg0KDQpIbW0sIHNvbWV0aGluZyBpcyBmaXNoeSBoZXJlLg0KDQpMb29raW5nIGF0IHRo
ZSBzb3VyY2UgaW4gY3VycmVudCBIRUFEIG9mIExpbnVzJyB0cmVlIHNob3dzIG1lOg0KDQpz
dGF0aWMgaW50DQpfYmFzZV9jb25maWdfZG1hX2FkZHJlc3Npbmcoc3RydWN0IE1QVDNTQVNf
QURBUFRFUiAqaW9jLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCnsNCiAgICAgICAgIHN0cnVj
dCBzeXNpbmZvIHM7DQogICAgICAgICB1NjQgY29oZXJlbnRfZG1hX21hc2ssIGRtYV9tYXNr
Ow0KDQogICAgICAgICBpZiAoaW9jLT5pc19tY3B1X2VuZHBvaW50IHx8IHNpemVvZihkbWFf
YWRkcl90KSA9PSA0IHx8DQogICAgICAgICAgICAgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCZw
ZGV2LT5kZXYpIDw9IDMyKSB7DQogICAgICAgICAgICAgICAgIGlvYy0+ZG1hX21hc2sgPSAz
MjsNCiAgICAgICAgICAgICAgICAgY29oZXJlbnRfZG1hX21hc2sgPSBkbWFfbWFzayA9IERN
QV9CSVRfTUFTSygzMik7DQogICAgICAgICAvKiBTZXQgNjMgYml0IERNQSBtYXNrIGZvciBh
bGwgU0FTMyBhbmQgU0FTMzUgY29udHJvbGxlcnMgKi8NCg0KVGhpcyBkb2Vzbid0IGxvb2sg
bGlrZSBjb21taXQgZTBlMDc0N2RlMGVhM2RkIGhhcyBiZWVuIGFwcGxpZWQuDQoNCmdpdCBs
b2cgZHJpdmVycy9zY3NpL21wdDNzYXMvbXB0M3Nhc19iYXNlLmMgZG9lc24ndCBzaG93IGl0
IGVpdGhlci4NCg0KZ2l0IG5hbWUtcmV2IGUwZTA3NDdkZTBlYTNkZCB0ZWxscyBtZSBpdCBz
aG91bGQgYmUgaW4gdjYuMC1yYzcuDQoNCg0KSnVlcmdlbg0K
--------------Tyxf3ySWUJiDFRHH0ip3jqDx
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------Tyxf3ySWUJiDFRHH0ip3jqDx--

--------------nQfmobi3WurtVZY3p8acHADl--

--------------0rlDa9SQfT94UR4QIRjJLU0o
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNXZssFAwAAAAAACgkQsN6d1ii/Ey/Y
3Af/efKnoC1Imin1iahcfGy7nwXfrkxVY6xpdMTvy7aPOpWfaGhNmhnHHXVtpJlO408kzc1Sy27U
Ko5KmC/Af6NLkqbvd6lW/INkvHOHPJ1XxIJyoncP3IFEbJL8xDCrl41d3dQ0w0ReohCPFXvkhgTN
OeJgohZxj1MIOS15J6Vk/EYYCz03s0IpsgWythrDdZ9VAnqbpCSHuQ/+cVaDthsRY+4eDzGKi/3O
PkBrDltkaB0L/Y2kzH1P6eRez+P+mfts3zUvhM1sVdTB4d0O+ZRiOV8wQxrkhpp1wMt+iu7qXg7Y
TmayCYxmAnUTqq6kibX7wtwHkqV768lMtNGknVo29Q==
=WgiH
-----END PGP SIGNATURE-----

--------------0rlDa9SQfT94UR4QIRjJLU0o--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 04:57:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 04:57:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429553.680570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onBzh-0000M3-25; Tue, 25 Oct 2022 04:56:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429553.680570; Tue, 25 Oct 2022 04:56:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onBzg-0000Lw-V5; Tue, 25 Oct 2022 04:56:52 +0000
Received: by outflank-mailman (input) for mailman id 429553;
 Tue, 25 Oct 2022 04:56:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onBzg-0000LT-5X; Tue, 25 Oct 2022 04:56:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onBzf-0002QT-Nd; Tue, 25 Oct 2022 04:56:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onBzf-00084N-C6; Tue, 25 Oct 2022 04:56:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onBzf-0001wx-9W; Tue, 25 Oct 2022 04:56:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=n9YsOxBMMnwjqLIQORtuoNwB3LvgDQyUWeSeNbtuO1Y=; b=ZS2EbfqAHKEfmjla9T7mYXZlUV
	eAkE1ZKKC2F+8qtEjIkxF8ptrvM3apys95ARyK8RelpGsj6QsTQE0W2dnPpemL5ay3kwL1ozQd+2M
	rWsAjSuh0/X+GA8Fpb/kQzbLVjzoD4zmWWhbiyNpzWYEbrBuIV9I9jy73jyLyUL0/wAs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174314-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174314: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.16-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 04:56:51 +0000

flight 174314 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174314/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173493 REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start    fail in 173493 REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173493 REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 174314
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 174070 pass in 174314
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174070 pass in 174314
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 174070

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   67 days
Testing same since   173493  2022-10-11 13:07:01 Z   13 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 06:18:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 06:18:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429570.680602 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onDGi-0001Go-DO; Tue, 25 Oct 2022 06:18:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429570.680602; Tue, 25 Oct 2022 06:18:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onDGi-0001Gh-AP; Tue, 25 Oct 2022 06:18:32 +0000
Received: by outflank-mailman (input) for mailman id 429570;
 Tue, 25 Oct 2022 06:18:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onDGg-0001Gb-PI
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 06:18:30 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d791e3fa-542c-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 08:18:29 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6856.eurprd04.prod.outlook.com (2603:10a6:20b:108::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 06:18:27 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 06:18:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d791e3fa-542c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XtM3vD01AT7swj+zuesGnMxf+4HWB0s5DrJwAOnOGcU3/Jh/t6pmzAUqpMFDvx3pXmLYvsQNycFfJlIcPoz6QFDyIjuzuhtnvArOumq46qywDIn2AKmu6reftSH4GVXBW0eJMagG/4xvy4Cc4HrA2QoJk8UGPHTspp2vg4p7Z6tTICcMYjxczDey53BU/ww4BVCpbuB65PD74v12x0cT+PI5G7AuuV8vCtdXer3zYbt3oLsHwpfgFTyVz7LORrvSk8ZIDj8+N3kmpqYk6QZLegFbjwUxoWbPWwrY4p/mRbIY8D8BhyTmm17y8Wdrpp15PNZuVwXeSdSOnX5UMESjQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gFIPPrLjiVLFR4k5kNiKuRCDW0ZWacj8mAmtecTVxgo=;
 b=GtWuPJBqATYdRbYBqyijz/F5dyl0kK6BZ35lTLQ51ieGHfecgse08pq6+YdDlbBkFKpqheTBBbBdbM1l7t7qELws9o9e3g1YigwOaCkjnaFVhPiH9jyor0BwdOqJouy3aPHfu97ywJMIn9rNQqRLCkIkwr4tSTuZJZCRHf9DvFRGUwkJd1g8TkU1kvUOC4NO+Ne0bNsXFLVksjSqC+I9HwoS5cEIVhLOq7dBJJKQ/EIvdBiUpgaqPQiXjFfTflb6QtOCledAO/LuKExbfbSai7jUkcw2BSpLEVBcRFtID+TXz1VmyczX/fgWy64gUkYfBIcfnaszF5fzkJneDMPwxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gFIPPrLjiVLFR4k5kNiKuRCDW0ZWacj8mAmtecTVxgo=;
 b=pmucJeg8kXoof5OtWDA0Xg9J5dj7nCcY08pH3ZvRSP7HHKBiqAiNaDSyt3kVCha+et6yC0Mn3wb4XyIikwxcInrhw5awjOemuw3FCdSMD9Jws06rfQNC6L62La2EsvqfLPkcp9cMc+03x558kDBs2+awZSzjYFo02TT85nt38y9qesv3nN7YYu9vtSiN42gRE+b/8xogFnBGIBYA4v8CDERN4VpK5VZoIK4rhxYurImi8GgBzImFSCfOEleJoern+BEKve/PtnkZoJGzEscx+MZgyhtYYxtfTCwYE86EA7eOe3lacJ1Tme/I11koD9R1qUxGN4X6+3IRQ3mGaTFMzQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e6f92dcb-d371-b3e0-50f2-595834020bb5@suse.com>
Date: Tue, 25 Oct 2022 08:18:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 06/10] x86/mem-sharing: copy GADDR based shared guest
 areas
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <bcab8340-6bfd-8dfc-efe1-564e520b3a06@suse.com>
 <bb3be891-1dad-43db-da69-f20a471ccdb7@suse.com>
 <CABfawhm-YHwO08f_tgN_-X1=2+U4krtaVv3UUoaFm6NJEhzVMA@mail.gmail.com>
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawhm-YHwO08f_tgN_-X1=2+U4krtaVv3UUoaFm6NJEhzVMA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0093.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6856:EE_
X-MS-Office365-Filtering-Correlation-Id: e9a07bda-9850-47e3-54fe-08dab650bae1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iTGZXzKBrkMVkiJR1mCTOzZbNFIFPsfe2Xf/MRYfJnk9SzfnYz83vRG9lpVlluysedgiL7xus12xT45sas6jk8zWXbjefOzCnjOwAr2kMKyqypRXd10AvywD5gTDJMxez9vxc08ydymaSxH8jwERFB1f0yzsknVtedbELsbyxBjdqpdP8dRztPhoOhwXqrxUYxC7OlK6/6HoOK9Jr+ztOMRm1/lR0ZxINUxbzcZGt1xCq99twAgayTXJQ4DlwSYISBsqyDXD+TVlArRvI+ozQ5WVQxNYpH30xz5vL4r4e5myF/uD1FfXXhmCos1Zcj2qZJ/oL+Z5gtWD7hdL4mxBQ2S7vZeYOJGOVbtIJpf5Ko6y7rPXnGGTXN3SSYaPsFjfRqzaq79CFr2JsN3w2w1XngVOHshFddimh1Xwc1psJJxpLNpp+vNteaMsOUHJiYjjIpJP5Vwmc5Kz9efuQUCNDOUlqLHueDA9MEICvJKW57AV9zFS4nG3w2ETQiGFq8NACNQpVFKOk1iCzQv6T3/Z3YryOTm7pv7kbWZQnDzS7Jll2hIcayfCiWYAnihTEXfj6ElPpobUSWUTbf2s6uqEix/wQ6fk2/VauMqywdaZqyBYzkLb096W3aO9idHxVVdcQ/KCuIntDfONN6XTbPn/PqbCU8UHBIVL5sNMkDTeuKYLQbEAKOGGavvtncHuedIFpkg5KekOOPOpkQbSzr5hrBHkzH5qknhMudJjYCpYEEAxOddhz2lPslBWSvY2fu3qiLi4/+I5hI/P49dnhKdLTukTUACIC92HrqVtVNvzVEI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(31696002)(86362001)(36756003)(31686004)(38100700002)(2906002)(2616005)(478600001)(6506007)(53546011)(6512007)(26005)(186003)(83380400001)(6486002)(54906003)(6916009)(316002)(66946007)(66556008)(66476007)(8676002)(4326008)(41300700001)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T3RBMXBHajhDakxtaGJCQUJMM0JZbTZwY2NzWml6cjVORGo5QXNDdDg4dGM1?=
 =?utf-8?B?cFNEbU1jdWxHSmFMYUIzczR3Y2oxWEhuU25xYXYyYVh4b1RDOFJGSnFGOUNi?=
 =?utf-8?B?aFRqd2RPb0lLT05CRU1NWkJZcVQ1Z1BtRi9VbHNmSFE0SnZhVEpPb3BrUWZJ?=
 =?utf-8?B?VEN3RXZVUEdnV2pQcENmdm9hUkZ5VTNVM2pkYnJreHFNUnBISXMrMllXSTU5?=
 =?utf-8?B?aFhqYWQzcEt2SDN1ZzMwRURtNmkvcjlQaDYwRWZJNkhyRUNVNFVwa3hXcEti?=
 =?utf-8?B?ckd6RjJkQk5LSi8vY09aMFNpKzk4RXlVVXI2d1Uwbmw3dlhFaEZ0YnZOak15?=
 =?utf-8?B?QXZBQ29xeVpiVFJkMGpORHN5aGpOd3ZVdXRCOWhEWFhPdWNTT0J0U2prc2Qv?=
 =?utf-8?B?YUNSbDJHVDg3TzA1ZzVKOHdKZUhjbDZJSXRDMWo1MlFQUitwTEw1SzhmL0Zh?=
 =?utf-8?B?MEZvaU9JTEltUE83MUMwU2w5aEY2RGlFTC9pNDVCRnhHWUU3eGRRc2pMSFIr?=
 =?utf-8?B?SGVMVkROdTNyL0lzcE0xaWVYK09FQ0E1dXFURkFETVFnTzdMN01INzF4K0t0?=
 =?utf-8?B?VFdsL1Y2N3RxRVZLM3NUVDBmaDJRc3U0aG5JbWJWTWk2Mm10aEZQRi9Vc0Qv?=
 =?utf-8?B?T0gyOVMwN3lQOXNSN0x3cG84OVgwejNZQTBoajRVakZPcmtDbHZVME1UMFdO?=
 =?utf-8?B?a2dYQkdScUhxbFdQUDhPTU9qTU12V3NJRHRiY2hzY1pvM0h2YlhoanpLakhB?=
 =?utf-8?B?SW0rTzBPR1ZPWW5lSFNJb0M2OW9HQWJOYVNRc3haeXNuWEFITS9DSkI3YzFW?=
 =?utf-8?B?Z3VpRHdkTk5leGtxWUVEZVoyQVgvd3lVazM2endyVXVLd1dSSHRKRFBEMEFz?=
 =?utf-8?B?M29RNmZlQ0JNNFdleDNDYnpnVGhxZkhnUUttb2FCcklwa1VxRGh5THdpLzJ1?=
 =?utf-8?B?N0JTTVNRUFppZHo1Z09pMm5jVmJZZTFENkV1M0ZzY3BBTG9EUzE5MTVJR3pB?=
 =?utf-8?B?WEtxRU5XUUx4VEJRVlhvcTcrNGQ3bkd4UFFGdjVvQUFnL09rZXRBNHlETS9W?=
 =?utf-8?B?aEd0NWp4cDRqNHFqbVAxK2hFNWRZNGJ1dUpsSHBOTXoxNVNiTDVOSmRvNEZE?=
 =?utf-8?B?U0xCWDhyZ2tVM29NNTJISU9RZlplVldPRzh1ODZFY2lXT3BicWNhYmJscTVt?=
 =?utf-8?B?dFFUOHVNaFA4ekdQZ1RaUTNUWjdmR3oyNWpzU2E5MnFSb01ickl1TjdYMWtF?=
 =?utf-8?B?b05JTzZtSzlqSmZCZ1pYZ3l5bXZKK1NOS2RWcnhGSkRyWVVvYzRYMUZXYkdv?=
 =?utf-8?B?NkNHSG5kNVErRUsyWGgxckVrWjVCSml2bnRDdWRudlVnK3hlUGtiOU11WUMy?=
 =?utf-8?B?bWlBWENCZkIyb043ZFNFT3VuOWh5T2FpM2lCV3pVWEtMQ2NhWFF4dDM1VS9l?=
 =?utf-8?B?b3c0bm5RUmZHQmVjM2kvRS83N1dqM05GQy9kZXQrdFA1Qmhhb1kvOEY1NEI0?=
 =?utf-8?B?aUVYYUZPYUZRVDlUUFIzODRZckVEZTA4ajZIN3NkdFdqcVREV01XQ2FUeUJE?=
 =?utf-8?B?cFJRWmpmRlEveE1vTkZBM0t3N09ZTDExWUJCNmZmRDM0UTdPc1YwYTNwS2Ri?=
 =?utf-8?B?TXlISjE2UndhYkpIdDltc01WaEcrMzI2b3U1bjk5bFhVazBKandzOEw1Qy9i?=
 =?utf-8?B?ZlZrNnZrYlpXKzR3TngyazNxVm85R1U3d05TZVY4L2drNHEzWU1TbHZiblBN?=
 =?utf-8?B?THF4azZwVFlzK1JSVzRNUE84VlBQeHBhV1NSRVkybUZPMjBHdForYjF2S3J6?=
 =?utf-8?B?ZldxQUdCQ0R2MjEwTDY4TC9HamI5S0x0MGJwaUdEQWtINU8vbTVVZ3hUajd4?=
 =?utf-8?B?VzJOL0tkS2JLazJja2x1bUw2bWlESStQRU1QekZrcUhMcysvSEkvNkRJQzlQ?=
 =?utf-8?B?cnFUdCtWT1UrR2hIeCs1d2pYQVl5K2dhaUdxRFZQZ1BpY2FRUjV4d2dLaGRG?=
 =?utf-8?B?LzlCc0l0WFJOaWE0RkRnYzFvbWtnNUQ0MHpRVEltQThoaUhwb1VPTjIxTUpJ?=
 =?utf-8?B?eFBOOW1Qeis3Z2dtWnZkaURzTVNqdUoydnRtR2hrY21xazZKSXR5SnM0dEtY?=
 =?utf-8?Q?NO3UGrfpk/D9Y8ijyDj26WJoW?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9a07bda-9850-47e3-54fe-08dab650bae1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:18:27.6721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bvyA3PqlIwgZ65aHl1m6yJbGgxjTLYKqRtnBf5KQfE46KKjtJ96Gkxu56PXUzd+A2GfrPH6t/EUhNKKc0Fv3Zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6856

On 25.10.2022 01:04, Tamas K Lengyel wrote:
>> @@ -1987,7 +2056,10 @@ int mem_sharing_fork_reset(struct domain
>>
>>   state:
>>      if ( reset_state )
>> +    {
>>          rc = copy_settings(d, pd);
>> +        /* TBD: What to do here with -ERESTART? */
> 
> Generally speaking the fork reset operation does not support "restarting".
> While in the memory op path the error can be propagated back to the
> toolstack and have it re-issue it, on the monitor reply path that's not
> possible. But the important question is where does the -ERESTART come
> from?

>From map_guest_area() when d's hypercall deadlock mutex is busy. I
guess d is fully paused here, but checking for that to avoid the vCPU
pausing in map_guest_area() would end up fragile, I'm afraid.

Speaking of which - for the use of map_guest_area() here I guess it's
wrong for the function to have a local variable named "currd". I didn't
have this use here in mind when writing that function ...

>  What I think would happen here though is that -ERESTART may happen
> during the initial fork op and that can fail, but if it succeeded, then
> during reset it can't happen since everything would be already allocated
> and mapped, the only thing during reset that would be done is the page
> copying.

As per above I don't think there's any dependency on initial fork vs reset
here.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 06:38:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 06:38:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429580.680621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onDZz-0003sQ-25; Tue, 25 Oct 2022 06:38:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429580.680621; Tue, 25 Oct 2022 06:38:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onDZy-0003sJ-VB; Tue, 25 Oct 2022 06:38:26 +0000
Received: by outflank-mailman (input) for mailman id 429580;
 Tue, 25 Oct 2022 06:38:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Ep8Y=22=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1onDZx-0003sD-75
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 06:38:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9fb1fe08-542f-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 08:38:24 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7436B22098;
 Tue, 25 Oct 2022 06:38:23 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B1F1134CA;
 Tue, 25 Oct 2022 06:38:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SZExBV+EV2MCZgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 25 Oct 2022 06:38:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fb1fe08-542f-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666679903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=6R8DV1I3DLA59p8MCxfr1ZPZBKIlTM1sKCHImg6KD0I=;
	b=qLk7xvs/Q3GGVLfl8+KQI/CfylZOZs4GnLnUBCkMLxGehesPWPpbZYCrIxFVwoAxb888TF
	05m5RERkfZj9A8uk49xjZRpLbMA6JZqt39ZZproFZl++5QArddWJ7GkQ/SOydgw7i2QXke
	iKK4S9dz45VZOhyNOiY7uPU2YuiW5FY=
Message-ID: <947cb58c-9b3b-c018-0b46-66122ea1ce46@suse.com>
Date: Tue, 25 Oct 2022 08:38:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
Content-Language: en-US
From: Juergen Gross <jgross@suse.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
In-Reply-To: <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------8yuOl9h0grkLiTIM0SMWn7UE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------8yuOl9h0grkLiTIM0SMWn7UE
Content-Type: multipart/mixed; boundary="------------nM63vNz4QQMxJ1qOUEto0weU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
 Bart Van Assche <bvanassche@acm.org>
Cc: Salvatore Bonaccorso <carnil@debian.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>, sathya.prakash@broadcom.com,
 suganath-prabu.subramani@broadcom.com,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
 adi@kriegisch.at
Message-ID: <947cb58c-9b3b-c018-0b46-66122ea1ce46@suse.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
 <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
 <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
 <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
In-Reply-To: <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>

--------------nM63vNz4QQMxJ1qOUEto0weU
Content-Type: multipart/mixed; boundary="------------riRNKW1nBDfZOTdj5zDjO7LH"

--------------riRNKW1nBDfZOTdj5zDjO7LH
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjQuMTAuMjIgMTQ6NTUsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IE9uIDI0LjEwLjIy
IDEzOjU2LCBTcmVla2FudGggUmVkZHkgd3JvdGU6DQo+PiBPbiBTdW4sIE9jdCAyMywgMjAy
MiBhdCA2OjU3IEFNIEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPiB3cm90
ZToNCj4+Pg0KPj4+IE9uIDEwLzIxLzIyIDAyOjIyLCBTYWx2YXRvcmUgQm9uYWNjb3JzbyB3
cm90ZToNCj4+Pj4gV2UgZ290IHRoZSBmb2xsb3dpbmcgcmVwb3J0IGluIERlYmlhbiBhZnRl
ciBhbiB1cGRhdGUgZnJvbSA1LjEwLjE0MCB0bw0KPj4+PiB0aGUgY3VycmVudCA1LjEwLjE0
OS4gRnVsbCBxdW90aW5nIGJlbG93IChmcm9tDQo+Pj4+IGh0dHBzOi8vYnVncy5kZWJpYW4u
b3JnLzEwMjIxMjYpLiBEb2VzIHRoaXMgcmluZyBzb21lIGJlbGwgYWJvdXQga25vd24NCj4+
Pj4gcmVncmVzc2lvbnM/DQo+Pj4NCj4+PiBPbmx5IHRocmVlIG1wdDNzYXMgY2hhbmdlcyBh
cmUgbmV3IGluIHY1LjEwLjE0OSBjb21wYXJlZCB0byB2NS4xMC4xNDA6DQo+Pj4gJCBnaXQg
bG9nIC0tZm9ybWF0PW9uZWxpbmUgdjUuMTAuMTQwLi52NS4xMC4xNDkNCj4+PiAyYjlhYmEw
YzVkNThlMTQxZTMyYmIxYmI0YzdjZDkxZDE5ZjA3NWI4IHNjc2k6IG1wdDNzYXM6IEZpeCBy
ZXR1cm4gdmFsdWUgDQo+Pj4gY2hlY2sgb2YgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCkNCj4+
PiBlN2ZhZmVmOTgzMGM0YTAxZTYwZjc2ZTM4NjBhOWJlZjAyNjIzNzhkIHNjc2k6IG1wdDNz
YXM6IEZvcmNlIFBDSWUgDQo+Pj4gc2NhdHRlcmxpc3QgYWxsb2NhdGlvbnMgdG8gYmUgd2l0
aGluIHNhbWUgNCBHQiByZWdpb24NCj4+PiBlYTEwYTY1MmFkMmFlMmNmM2VjZWQ2ZjYzMmE1
Yzk4ZjI2NzI3MDU3IHNjc2k6IG1wdDNzYXM6IEZpeCB1c2UtYWZ0ZXItZnJlZSANCj4+PiB3
YXJuaW5nDQo+Pj4NCj4+PiBTcmVla2FudGggYW5kIFN1Z2FuYXRoLCBjYW4geW91IGhlbHAg
d2l0aCBiaXNlY3RpbmcgdGhpcyBpc3N1ZT8gRm9yIHRoZQ0KPj4+IGZ1bGwgcmVwb3J0LCBz
ZWUgYWxzbyANCj4+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1zY3NpL1kxSmt1
S1RqVllyT1didm1AZWxkYW1hci5sYW4vLg0KPj4NCj4+IFRoaXMgaXNzdWUgaXMgZ2V0dGlu
ZyBvYnNlcnZlZCBhZnRlciBoYXZpbmcgdGhlIGJlbG93IHBhdGNoIGNoYW5nZXMsDQo+PiAy
YjlhYmEwYzVkNThlMTQxZTMyYmIxYmI0YzdjZDkxZDE5ZjA3NWI4IHNjc2k6IG1wdDNzYXM6
IEZpeCByZXR1cm4NCj4+IHZhbHVlIGNoZWNrIG9mIGRtYV9nZXRfcmVxdWlyZWRfbWFzaygp
DQo+Pg0KPj4gV2hhdCBpcyBoYXBwZW5pbmcgaXMgdGhhdCBvbiBYZW4gaHlwZXJ2aXNvciwg
dGhpcw0KPj4gZG1hX2dldF9yZXF1aXJlZF9tYXNrKCkgQVBJIGFsd2F5cyByZXR1cm5zIGEg
MzIgYml0IERNQSBtYXNrLiBJLmUuIEl0DQo+PiBzYXlzIHRoYXQgdGhlIG1pbmltdW0gRE1B
IG1hc2sgcmVxdWlyZWQgdG8gYWNjZXNzIHRoZSBob3N0IG1lbW9yeSBpcw0KPj4gMzIgYml0
IGFuZCBoZW5jZSBtcHQzc2FzIGRyaXZlciBpcyBzZXR0aW5nIHRoZSBETUEgbWFzayB0byAz
MmJpdC4gU28sDQo+PiBvbiBhIDY0IGJpdCBtYWNoaW5lLCBpZiB0aGUgZHJpdmVyIHNldCdz
IHRoZSBETUEgbWFzayB0byAzMiBiaXQgdGhlbg0KPj4gU1dJT1RMQidzIGJvdW5jZSBidWZm
ZXIgY29tZXMgaW50byBwaWN0dXJlIGR1cmluZyBJT3MuIFNpbmNlIHRoZXNlDQo+PiBib3Vu
Y2UgYnVmZmVycyBhcmUgbGltaXRlZCBpbiBzaXplIGFuZCBoZW5jZSB3ZSBvYnNlcnZlIHRo
ZSBJTyBoYW5nIGlmDQo+PiB0aGUgbGFyZ2UgSU9zIGFyZSBpc3N1ZWQuDQo+Pg0KPj4gSSBh
bSBub3Qgc3VyZSB3aGV0aGVyIHRoaXMgQVBJJ3MgcmV0dXJuIHZhbHVlIGlzIGNvcnJlY3Qg
b3Igbm90IGluIHRoZQ0KPj4gWGVuIGVudmlyb25tZW50LiBJZiBpdCBpcyBjb3JyZWN0IHRo
ZW4gSSBoYXZlIHRvIG1vZGlmeSB0aGUgZHJpdmVyIHRvDQo+PiBub3QgdXNlIHRoaXMgQVBJ
IGFuZCBkaXJlY3RseSBzZXQgdGhlIERNQSBtYXNrIHRvIDY0IGJpdCBpZiB0aGUgc3lzdGVt
DQo+PiBpcyBhIDY0Yml0IG1hY2hpbmUuDQo+IA0KPiBQbGVhc2UgcmVjaGVjayB0aGUgYmFj
a3BvcnRlZCBwYXRjaCBpbiA1LjEwLnkuIEl0IGlzIF93cm9uZ18uIFRoZSBiYWNrcG9ydA0K
PiBoYXM6DQo+IA0KPiAtLS0gYS9kcml2ZXJzL3Njc2kvbXB0M3Nhcy9tcHQzc2FzX2Jhc2Uu
Yw0KPiArKysgYi9kcml2ZXJzL3Njc2kvbXB0M3Nhcy9tcHQzc2FzX2Jhc2UuYw0KPiBAQCAt
Mjk5Myw3ICsyOTkzLDcgQEAgX2Jhc2VfY29uZmlnX2RtYV9hZGRyZXNzaW5nKHN0cnVjdCBN
UFQzU0FTX0FEQVBURVIgKmlvYywgDQo+IHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPiANCj4g
IMKgwqDCoMKgwqDCoMKgIGlmIChpb2MtPmlzX21jcHVfZW5kcG9pbnQgfHwNCj4gIMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgc2l6ZW9mKGRtYV9hZGRyX3QpID09IDQgfHwgaW9jLT51c2Vf
MzJiaXRfZG1hIHx8DQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoCBkbWFfZ2V0X3JlcXVpcmVk
X21hc2soJnBkZXYtPmRldikgPD0gMzIpDQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoCBkbWFf
Z2V0X3JlcXVpcmVkX21hc2soJnBkZXYtPmRldikgPD0gRE1BX0JJVF9NQVNLKDMyKSkNCj4g
IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpb2MtPmRtYV9tYXNrID0gMzI7DQo+
ICDCoMKgwqDCoMKgwqDCoCAvKiBTZXQgNjMgYml0IERNQSBtYXNrIGZvciBhbGwgU0FTMyBh
bmQgU0FTMzUgY29udHJvbGxlcnMgKi8NCj4gIMKgwqDCoMKgwqDCoMKgIGVsc2UgaWYgKGlv
Yy0+aGJhX21waV92ZXJzaW9uX2JlbG9uZ2VkID4gTVBJMl9WRVJTSU9OKQ0KPiANCj4gV2hp
bGUgdGhlIHVwc3RyZWFtIHBhdGNoIGhhczoNCj4gDQo+ICvCoMKgwqDCoMKgwqAgaWYgKGlv
Yy0+aXNfbWNwdV9lbmRwb2ludCB8fCBzaXplb2YoZG1hX2FkZHJfdCkgPT0gNCB8fA0KPiAr
wqDCoMKgwqDCoMKgwqDCoMKgwqAgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCZwZGV2LT5kZXYp
IDw9IDMyKSB7DQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaW9jLT5kbWFf
bWFzayA9IDMyOw0KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb2hlcmVudF9k
bWFfbWFzayA9IGRtYV9tYXNrID0gRE1BX0JJVF9NQVNLKDMyKTsNCg0KU29ycnkgZm9yIHRo
aXMgbWlzdGFrZSBvZiBtaW5lLCB3aGljaCBzZWVtcyB0byBoYXZlIGJlZW4gY2F1c2VkIGJ5
IGEgZ2l0DQppbmNvbnNpc3RlbmN5LCBhcyB0aGUgdXBzdHJlYW0gc291cmNlIGlzIHN0aWxs
IHNob3dpbmcgdGhlIGxpbmUNCg0KICAgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCZwZGV2LT5k
ZXYpIDw9IDMyDQoNCkkgZGlkbid0IGRvdWJsZSBjaGVjayB3aGljaCB1cHN0cmVhbSBwYXRj
aCB3YXMgcmVmZXJlbmNlZCBieSB0aGUgYmFja3BvcnQNCnBhdGNoLCBidXQgbG9va2VkIGF0
IHRoZSBvdXRwdXQgb2YgImdpdCBibGFtZSIgdG8gbG9vayBhdCB0aGUgbGFzdCBwYXRjaA0K
b2xkZXIgdGhhbiB0aGUgYmFja3BvcnQgY2hhbmdpbmcgdGhlIGxpbmUgaW4gcXVlc3Rpb24u
DQoNCkkgZGlkbid0IGV2ZW4gdGhpbmsgb2YgdGhlIHBvc3NpYmlsaXR5IHRoYXQgZ2l0IGNv
dWxkIGJlIHdyb25nLg0KDQoNCkp1ZXJnZW4NCg==
--------------riRNKW1nBDfZOTdj5zDjO7LH
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------riRNKW1nBDfZOTdj5zDjO7LH--

--------------nM63vNz4QQMxJ1qOUEto0weU--

--------------8yuOl9h0grkLiTIM0SMWn7UE
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNXhF4FAwAAAAAACgkQsN6d1ii/Ey+g
tgf8DuQqI6HCeB09SqhHX1fb3zsMHrAthxXwZ2ZKcIPPFCAk8J3Xh38yqqYNB2hzrNDYnaE1lVGq
RqDKSi8V1eb30EEyaLJ+m1Q7r4w1HmHhh7TvKQT7R7Mks/NhjjS2JY9eBXVtf70WT8rFHexv2H6v
TEfxeMIemy9+Fv/+JGE+k+YYdSqYnKyhswnP3nTglH10bJ3GDdPu4viK65nBxz0M4yBzFRbBJkfZ
vUoFuHq/Z/J+3UBUJu7+HfLTLMRfafilkmoLz7npAdHQA67yR2rU2prjqUAyYj5xMRoIJ6o0+MEl
R7aEREV+I3lt2VGVRgGMZMnM/82Nqt5+AJRGsoRSuQ==
=meIc
-----END PGP SIGNATURE-----

--------------8yuOl9h0grkLiTIM0SMWn7UE--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 07:12:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 07:12:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429590.680638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onE6Z-0008MC-MF; Tue, 25 Oct 2022 07:12:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429590.680638; Tue, 25 Oct 2022 07:12:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onE6Z-0008M5-JY; Tue, 25 Oct 2022 07:12:07 +0000
Received: by outflank-mailman (input) for mailman id 429590;
 Tue, 25 Oct 2022 07:12:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onE6Y-0008Ly-7l
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 07:12:06 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5274ce19-5434-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 09:12:02 +0200 (CEST)
Received: from MW4PR03CA0240.namprd03.prod.outlook.com (2603:10b6:303:b9::35)
 by LV2PR12MB5965.namprd12.prod.outlook.com (2603:10b6:408:172::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 25 Oct
 2022 07:11:59 +0000
Received: from CO1NAM11FT059.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:b9:cafe::b3) by MW4PR03CA0240.outlook.office365.com
 (2603:10b6:303:b9::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26 via Frontend
 Transport; Tue, 25 Oct 2022 07:11:58 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT059.mail.protection.outlook.com (10.13.174.160) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 07:11:58 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 02:11:56 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 25 Oct 2022 02:11:55 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5274ce19-5434-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ADSBy+sEbRz3pKQJzRDbOz6zW5nz9oGcwuZfOY9pAY7k3iQYrqs27rrBhMN2iAXLlSiV953daeTn0dzgOWnHWzDlDveYxTLd8Mh9QG0bBZ6gfkMz6iYxiSYLRSFMoWK11yq956R38s9BFW/eZLXB9xqHVL8mY679F3EBS7/wXxlZtvpctiF391d1QB3SHLgckN62frrZICgJ6mDkMXnUaUMeC5pCZ09ulVo8t9Y3V4+c6lqgLW7cnkhUjPrqo0earuxs30Y+EJrIkyrD5kft2qrteXRfgvXKBcMUrclK6KK+yfQWhdPbP9i950XlDATlis5dTJydVi1p+HiIdm8ADA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s60BJEcvxeK1+2zS14ot2I/lAGyI3PTzqa93cEn7rQs=;
 b=XzT5Lk8NiVsaXjNL+CZBNjpxawsjwz8S1Nc0WcGeAxjZQ+t/T7EC2yBLEtDGpCMgiJdJZ0JOGNSjc5ZBh8IjcqHb3AOKa5H346EZzRc6q34N8LkjwGtLgUpq/V/x2jX7GCDGlZgYMi2LJvXVh7tOAij4lIlhhCa5P1sgblT6WhG+bPnx6GL55I+f1Zvpno8ZleBUXLoNlbU28sxzNcxHkR2Lmiyppri83/wQdRtF7ijjuM9lyWUQFd5hw6t7JPG8HVBIPGIta2fAIXyrKEp17Qz3NMB1JdxpkMTSoytu3Lx7KlOjtox9qhMYqh+WboevnzIsRTO8v7wo7F1jn7SVcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s60BJEcvxeK1+2zS14ot2I/lAGyI3PTzqa93cEn7rQs=;
 b=vKTuoXds1jab5UeD5SsTf6XFaApOQUgDyIjWFEKHFcwFJDZa4xtCHUo61Vz8L3m04vze2OBPShZARx6qMOh9z1A3II8rgnVhyOPm2wVDgYVf8nnzuTAALd/uD/rXKLnv/Y6SZbaGvTuYhZGfmdnNb62u9+tSIlObEWMQdriiTUs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
Date: Tue, 25 Oct 2022 09:11:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Deadcode discussion based on Arm NS phys timer
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
Content-Language: en-US
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT059:EE_|LV2PR12MB5965:EE_
X-MS-Office365-Filtering-Correlation-Id: f7f86529-07db-4acd-f778-08dab65834fe
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	T108pff/N6ZZbV/XZ+Ym3g7MyHquVe3pIeGudB2wJAiP/mWKHrJmuH5ohElynOQzLFwHbrjZ45CV2I+s8/ZnsoLhbyKaHK+WEghVbjQuMejR+DoVSMPfV1B75ignsldcWV8A70dVd5AJnwElAm6jI21ykjbMTyvtExROncr18HHhZIReOZbhhKnowDaBrQ+xRgK107bjQoUhPO0Xqx/LNX8Eu0rGLwMU4KWB3GFHMEUfE0t+zkHZLnJQu3Sar/kbOcs73uNEh48HCNQbzFiKE4eO8oaGwCcUeJpdmzNgxlpVHZ1IOTzwAax+Lsbj+HnfNKAmSgEwCvsOKk5X0diR0RD/PVRdl4JY1/NxoFlUiIaDXeChfLzm1JBqHvc3+2wEehZykqOh0zI9aRMX4eqInBjxUKKmaOcd6jqnzlgPtFsI+qdh1vY7u7qYGPlS1GPDUtQ/QffVv+dVEJJ8oa/bKKz0US2BrUkyuV5h2STfQrUcQ3hFCld/u7LFIMH2+ocsKAITTRJi/Op4PFPoffKlXORY2p0gbYhKmL/q5UWJp+TvGlR4Uj2G0lNLZ470FYsOXxg9Y3WOA0kvxndMiRB5xkr+Y+hOxs2vIcGLxePnozUuD/THQoDdBT/DNsinsqK3B3AmbpM0PMwrgEy1+/JUWo0RhbSdwQkXnMJ8BGw6YRSzjTSYEAasZCM136WIiVWtYobDIim0543fCHFIoUf1dDDiV32ajh6TDk+UvRAA15211g0wNh3ZQ/+GCPhk/OFGR9xlAHB1wyk8/WUwBikzxy46mqcwE+N/KTFSykNpLg2RPRqI07khbx1w+GexrmKfX8hfJBbihobwx/1iD/tWBg==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199015)(36840700001)(40470700004)(46966006)(82310400005)(6666004)(41300700001)(82740400003)(53546011)(16576012)(316002)(54906003)(5660300002)(26005)(356005)(40480700001)(110136005)(478600001)(4326008)(40460700003)(81166007)(36756003)(44832011)(8936002)(70206006)(31696002)(83380400001)(86362001)(8676002)(47076005)(426003)(336012)(186003)(31686004)(66899015)(2616005)(36860700001)(2906002)(70586007)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 07:11:58.7442
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f7f86529-07db-4acd-f778-08dab65834fe
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT059.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5965

Hi,

On 25/10/2022 03:29, Stefano Stabellini wrote:
> 
> 
> On Mon, 24 Oct 2022, Julien Grall wrote:
>>> On 24/10/2022 12:51, Julien Grall wrote:
>>>> Caution: This message originated from an External Source. Use proper
>>>> caution when opening attachments, clicking links, or responding.
>>>>
>>>>
>>>> On 24/10/2022 10:07, Michal Orzel wrote:
>>>>> Hello,
>>>>
>>>> Hi Michal,
>>>>
>>>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly
>>>>> speaking, we are routing
>>>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use
>>>>> of it (as it uses the hypervisor timer CNTHP).
>>>>> This timer is fully emulated, which means that there is nothing that can
>>>>> trigger such IRQ. This code is
>>>>> a left over from early days, where the CNTHP was buggy on some models
>>>>> and we had to use the CNTP instead.
>>>>>
>>>>> As far as the problem itself is not really interesting, it raises a
>>>>> question of what to do with a deadcode,
>>>>> as there might be/are other deadcode places in Xen.
>>>>
>>>> There are multiple definition of deadcode. Depending on which one you
>>>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
>>>> would result to a lot of places impacted with the decision.
>>>>
>>>> So can you clarify what you mean by deadcode?
>>> In the timer example, I think we have both a deadcode and unreachable code.
>>> For the purpose of this discussion, let's take the MISRA definition of a
>>> deadcode which is a "code that can be executed
>>> but has no effect on the functional behavior of the program". This differs
>>> from the unreachable code definition that is
>>> a "code that cannot be executed". Setting up the IRQ for Xen is an example
>>> of a deadcode. Code within IRQ handler is an unreachable code
>>> (there is nothing that can trigger this IRQ).
>>>
>>> What I mean by deadcode happens to be the sum of the two cases above i.e.
>>> the code that cannot be executed as well as the code that
>>> does not impact the functionality of the program.
>>>
>>>>
>>>>> One may say that it is useful to keep it, because one day,
>>>>> someone might need it when dealing with yet another broken HW. Such
>>>>> person would still need to modify the other
>>>>> part of the code (e.g. reprogram_timer), but there would be less work
>>>>> required overall. Personally, I'm not in favor of
>>>>> such approach, because we should not really support possible scenarios
>>>>> with broken HW (except for erratas listing known issues).
>>>>
>>>> The difference between "broken HW" and "HW with known errata" is a bit
>>>> unclear to me. Can you clarify how you would make the difference here?
>>>>
>>>> In particular, at which point do you consider that the HW should not be
>>>> supported by Xen?
>>> I'm not saying that HW should not be supported. The difference for me
>>> between broken HW and
>>> HW with known errata is that for the former, the incorrect behavior is often
>>> due to the early support stage,
>>> using emulators/models instead of real HW, whereas for the latter, the HW is
>>> already released and it happens to be that it is buggy
>>> (the HW vendor is aware of the issue and released erratas).
>>
>> Thanks for the clarification. What I would call broken is anything that can't
>> be fixed in software. For a not too fictional example, an HW where PCI devices
>> are using the same stream ID. So effectively, passthrough can't be safely
>> supported.
>>
>> Regarding, not yet released HW, I don't think Xen should have workaround for
>> them. I wouldn't even call it "broken" because they are not yet released and
>> it is common to have bug in early revision.
>>
>>> Do we have any example in Xen for supporting broken HW,
>>> whose vendor is not aware of the issue or did not release any errata?
>> I will not cite any HW on the ML. But from my experience, the vendors are not
>> very vocal about issues in public (some don't even seem to have public doc).
>> The best way to find the issues is to look at Linux commit.
>>
>>>
>>>>
>>>>> Also, as part of the certification/FUSA process, there should be no
>>>>> deadcode and we should have explanation for every block of code.
>>>>
>>>> See above. What are you trying to cover by deadcode? Would protecting
>>>> code with IS_ENABLED() (or #ifdef) ok?
>>> I think this would be ok from the certification point of view (this would at
>>> least means, that we are aware of the issue
>>> and we took some steps). Otherwise, such code is just an example of a
>>> deadcode/unreachable code.
>>
>> Thanks for the clarification. So the exact approach will depend on the
>> context....
>>
>>>>> There are different ways to deal with a deadcode: > 1. Get rid of it
>>>>> completely
>>>>> 2. Leave it as it is
>>
>> ... this is my preference in the context of the timer.
> 
> From a certification point of view, the fewer lines of code the better,
> and ideally all the lines of code used for the certified build should be
> testable and used.
> 
> So I think 2. is the lest useful option from a certification
> perspective. For this reason, I'd prefer another alternative.
> 
> 
>> If the other don't like it, then 1 would be my preference.
>>
>> In general, my preference would be either 3.3 or 3.2 (see below).
> 
> I also think that 3.2 and 3.3 are good options for the general case. For
> the timer, I can see why 1 is your (second) preference and I am fine
> with 1 as well.
Ok, sounds good to me. Let's still give Bertrand the chance to share his opinion.

> 
> 
>>>>> 3. Admit that it can be useful one day and:
>>>>>     3.1. protect it with #if 0
>>
>> #if 0 should not be used in Xen code. IMHO this is the worse of all the world.
I share your opinion here Julien. Unfortunately we still have quite a few examples
in the Arm code using this either to mark something as TODO or to comment out
parts of the code waiting for future support. This is mostly in SMMU code that
was taken from Linux but already diverged quite far (maybe some cleanup is necessary).

>>
>>>>>     3.2. protect it with a new Kconfig option (disabled by default)
>>>>> using #ifdef
>>>>>     3.3. protect it with a new Kconfig option (disabled by default)
>>>>> using IS_ENABLED (to make sure code always compile)
>>
>> I would prefer 3.3 over 3.2. 3.2 would be used if it is too difficult to get
>> the code compiled when !IS_ENABLED.
>>
>> Similar to one if this is to move all the affected code in a separate file
>> with using obj-$(CONFIG...). That would only work for large chunk of code and
>> would be preferred over 3.2.
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 07:37:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 07:37:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429601.680662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEUu-0002pm-Uu; Tue, 25 Oct 2022 07:37:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429601.680662; Tue, 25 Oct 2022 07:37:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEUu-0002pf-S5; Tue, 25 Oct 2022 07:37:16 +0000
Received: by outflank-mailman (input) for mailman id 429601;
 Tue, 25 Oct 2022 07:37:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zbGC=22=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1onEUt-0002pZ-Cm
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 07:37:15 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130084.outbound.protection.outlook.com [40.107.13.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d79020ee-5437-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 09:37:13 +0200 (CEST)
Received: from FR3P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::15)
 by AS4PR08MB7508.eurprd08.prod.outlook.com (2603:10a6:20b:4fa::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 07:37:08 +0000
Received: from VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:95:cafe::9e) by FR3P281CA0144.outlook.office365.com
 (2603:10a6:d10:95::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.12 via Frontend
 Transport; Tue, 25 Oct 2022 07:37:08 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT021.mail.protection.outlook.com (100.127.144.91) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Tue, 25 Oct 2022 07:37:07 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Tue, 25 Oct 2022 07:37:07 +0000
Received: from e9c3bae2b94e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A0F18671-8CB9-4B5F-B202-CAF78131D235.1; 
 Tue, 25 Oct 2022 07:37:00 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9c3bae2b94e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 07:37:00 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB6328.eurprd08.prod.outlook.com (2603:10a6:20b:33e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 25 Oct
 2022 07:36:51 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 07:36:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d79020ee-5437-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=ZpE/WYIbMZIqRA82rem/2vpsxZYnVIQwzbDFDu348l5vSJmASs+YOuvmRw9c1ldMo+dGZiiOtSh5nShkb1W3hiOYFirze8+HKzNsYxI60YB5NpeL/y2ILiku9LhxWhYxyfHmi9iNqJ5wKxoPnBwaYETzBmY4RfToyXwQ9kmGIzwkl4llJegwrt/tXvjzL47fx465rJqL7XXXAxNJkvBSvHtGwpjeixRaNfykdklr4U+Z0lWvEbO33DH4UF/Ry/DM2puUStkilyi1FFUPwoKO0FLTgZE7t2Dq/+weDZ08Q9x63QiNPRQhY0PjJObzz0PbOZlJ5M555XlqUbn6x/9LJw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0+vHZb59A5QNvyJ+NKkFl4+p37pscCh3MHGL2aQuNPI=;
 b=jfcPcJbqSHdopKWQKH7rxT55K7qjz7/FHJMgufy90A3nkovViEhHcWQ3vUE4DrgSnASJOp5RN/xNt4o8SYlyGCNduzemHKc5jXhJYiq5Co/4yHWr28AElzp6nA1PsESNvKJHGRVlx7yeG3ZQLL8nCPhxfTg1WptWPSG0E6iu5FfAntKwBG9Zzy+jdLpzMtmmDOvk8DrLn2+76jjZPsDicMeEDricMzVjzgvODcW3C5rUVOIpiph3e8spUo3dsXksV3iqgDWe5kGnmLIfstlJSHy1jZ/+c3Vk5ALtDQnp7yTTkNlnU54HqZ4r8VdgTMWnt1eRllxxdDVHd73j8Nmk4Q==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0+vHZb59A5QNvyJ+NKkFl4+p37pscCh3MHGL2aQuNPI=;
 b=b8CKcZ8Oarj9UoNqoV+DtkcUGh1r5zyx6OkAwGxPhnlBG38WDUpfJUeCiYM298oZFxWzFlQ6hzbcIZ8GRU7nJ2En1dzU/9BDyNJl4XBn1mRX1zzl67AN8pbgaVEiwJb/riHFjEMyQOhnkkd561jPO1ZjzjmnfkiLzAabzwDBdNY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 482558b6af2265d4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N0VRAWx0RZcklsp3HzPRAiVKdxJLHPdT8Nklyh3uYYCOKPh7YqUayrmudaGXiZUFjI8gIJTbm4w6DhWGGrRdxD+kKGd5HjMU6MCfTyUpuHYkr5YkB82IArSXS8PU27Cl362ZF6YC8mtBzzvYlzvG163siai6ueWifKQg3TzdoOwVmzTZjTPjrr+KI7hUSsV4icfGbLXhB1fHyPdmHjIjWEFGq3GW9GFHNI9/gSplYiIs8PZeqWHhq3vyxB6ESVa9ZAqNl9oONB1uo2iT4R+sGmJ6gDZKh+PURZX8S3kYbOo2fjLRujgMqV56lL/Uxfduwcp3ixbwQPdZVgmmPINwOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0+vHZb59A5QNvyJ+NKkFl4+p37pscCh3MHGL2aQuNPI=;
 b=TBloC0z/Mvi2tiLzjgQ2PxNdYiRNrVUNMk7YiaYZxgVS7mtifTKol89mFoq/vjyLSTcVQ85ovVLdWdqbsweC038VTfi0h0RDPeIAQ7IrZ50Ivd6qZtTWUUiBjd5kaCkkfUwvpMrSxz946hYBYFrtk46JP286/lpISLJhdeqesCx8boYH2V2ZGjtNuiiRN/qIHH9KtAjxtf3DrTBbqjuAgjdp3Q2RiIyO/iIeIwZYxMkQ96Ez0ntM7+lliB9KnyQA7avYqGB4MXgdOkk/QtrmO6grIFPMLkEc+ZmD2Xwz2Pgq+FMXWRc/gKtMHifp8DzHtsi8y3Mqu7PZXsHxbm4T9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0+vHZb59A5QNvyJ+NKkFl4+p37pscCh3MHGL2aQuNPI=;
 b=b8CKcZ8Oarj9UoNqoV+DtkcUGh1r5zyx6OkAwGxPhnlBG38WDUpfJUeCiYM298oZFxWzFlQ6hzbcIZ8GRU7nJ2En1dzU/9BDyNJl4XBn1mRX1zzl67AN8pbgaVEiwJb/riHFjEMyQOhnkkd561jPO1ZjzjmnfkiLzAabzwDBdNY=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "michalo@amd.com" <michalo@amd.com>
Subject: Re: [XEN v3 01/13] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Thread-Topic: [XEN v3 01/13] GICv3: Emulate GICD_IGRPMODR as RAZ / WI
Thread-Index: AQHY59YEGqCNePqK20O7iZ+lc5NQpK4euWmA
Date: Tue, 25 Oct 2022 07:36:50 +0000
Message-ID: <54C7F6D2-98C9-4976-92E4-3B46F82CCA20@arm.com>
References: <20221024182518.65002-1-ayankuma@amd.com>
In-Reply-To: <20221024182518.65002-1-ayankuma@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB6328:EE_|VI1EUR03FT021:EE_|AS4PR08MB7508:EE_
X-MS-Office365-Filtering-Correlation-Id: c014b8c4-0f75-4cff-5925-08dab65bb839
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DHsm1gykBPlVLK/ElpD6MfZUFLGTLzkEAX6tEr89+I7+pGCezioquG1AwU/J4ATnxSbswRvK8LShfC85NlzmPCKZreLjCKFj7eeQVSOvNnpJcwP47lejMVaKqD7pxai4Ls0G0l5SOoXdADtB7HoCOjgqhgClua1idg4VKMSVmYEfRX0XXTHNNQqxTmKHgjRj9Cmv26FZ7tSN6omksLWAFQbS1MbpVUIV2O1D88534qzKUsINweLfUv+7oTCfAxPk1Htw4RQMkeYY+PJi9fuc8vGM2Tbtct0h1okxbuHI+no7MHmPctYxmRLoXjBYzMp/95cassZoCAmFQr8JtOagXj1YGK5Rexf1GSGl/qq02U+iy7qZdHWWPdmI25rBlD1B3imSwMjGuYTwLaap5tAFrrRfKXDgAVH9ZXLkaw0/EwBWn05YMi//fxG6e42g8BvY72oBhPeXwsfvFxkUBHoOSwvlLuuqtt48qAICu4VdxMt5I6Fef6u2HPNEr5PZsmgcKdl7MkS3Gdb+JJVIZ09UFeiewunDVKNimIsZGXEfcTJqyf+jLl3GneT5Tj9Xtvlm1M8WBt5bSN3npWJvNzBgD+8G7fnJ8FFsRpA3kJH9h38+Ru6tRMA9V5SM8q2SK5WaRzQcqLbnFK10XjoYQl3JeL9ld33/PBYjSxHjyJzfr/ejnfrVqEcUfs5Lh/2A1fr8aG69ruP6XqSp6WLB6IcC8nYiUFEBiUoxYoywyqW1CQ8mMtLyQaGu4LMSOMfAOWf55vRw7PPyjFXdPbypjTNCHG2kx2I3MbjgtXzO7MCWMsY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199015)(66556008)(86362001)(53546011)(66946007)(66476007)(6916009)(36756003)(6512007)(38070700005)(316002)(6506007)(26005)(8676002)(122000001)(64756008)(66446008)(6486002)(38100700002)(76116006)(8936002)(71200400001)(478600001)(91956017)(4326008)(41300700001)(54906003)(33656002)(5660300002)(83380400001)(186003)(2906002)(2616005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21F4569C789FAB4E9334E5A2E4B7A3C1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6328
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c8778de3-df1c-43ef-f066-08dab65bae28
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	t+wImTWXtB/M1mauDQkESbg674iX2CIVl6rOOOdPi9bUJunK1LdQdDU25db0IU/m45sz/u4k4sLmtV0A8tTsjLzl6gqFLWmh1MMn/x6ZCRBc3vl2DZrpgWnLpmC/5hQm9Vr+kCFrifhI87VfdaFrDC8HUjsrd8viIpxFsxCQDWLrVvfLvCXQXp8GdgUBECnyEzw0yr9VW1egqyFX7/UmD2ejW3/nIHHH2e1xZ1g0J/WVCTAcjpbHmyHzjeR5Dnbm6Iy/EwWNTwKC9s9a9CeFo/yUPiUFNMIT1XuUhBzo6jdoeO3vda/cL3+R4ZJwPBKPyVIv9ckuTJwbym3ASUg0Le4xKrwqVH8+M0UNNhQtZ16y7UXrUvodfWOWvQe6p30gH5S7fQgO5OuK7E12bZOkXT0uMGu1jP/cqLoyr51sw8tm3qLkGvhHBrt8KCRFPgg+mFas7iCVpCZOIAXufm9SctDtmlKGBxwOa5wwiZm6VyzNStwXgYgqAyAAgHmNeMLYBZm0eK0cCXFzubGBEA/rI9CtltOj6usI1WHZLydxzNL6u+dbGstp4iADoZomsuwKaKQzpWeMiiDINMVjyE7kH8pf4iY4yzmGRZJgs3YU0LU/miKz6iEYvKN3GOGFGhC/QXJShe0QjbC/XbKACQQiU0cO5I0mxb7qU8RKcTB4OxRb3tdqmW+a1isN6dhUVd229moTfzrHuVVLC3AMKRrUNZY6EPGYMtUcZ8lt9LE0afVfxPmt+iAnif+Tzk1htZfUUCALcAr4z6ztixQEYDKtJg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(4326008)(36860700001)(356005)(6486002)(82310400005)(41300700001)(82740400003)(47076005)(6862004)(33656002)(83380400001)(86362001)(2906002)(53546011)(6512007)(8936002)(336012)(2616005)(40460700003)(186003)(81166007)(5660300002)(8676002)(478600001)(26005)(40480700001)(70586007)(316002)(70206006)(54906003)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 07:37:07.3985
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c014b8c4-0f75-4cff-5925-08dab65bb839
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7508

Hi Ayan,

> On 24 Oct 2022, at 19:25, Ayan Kumar Halder <ayankuma@amd.com> wrote:
>=20
> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR is emulated
> as RAZ / WI for the guests as "GICD_CTLR.ARE_S=3D=3D0" is true.
> Xen is currently supported to run in non-secure mode, so guests will run =
in
> non-secure mode only.
>=20
> Also, if Xen was supposed to run in secure mode with guests, the programm=
ing
> of the interrupts (ie whether it belongs to secure/non secure and group 0=
/1)
> will be done by Xen only. The guests will not be allowed to change this.

Thanks a lot this description is a lot better.

>=20
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

I do not think this is something for 4.17 so it will need to be on hold unt=
il staging reopens unless someone thinks otherwise ?

Cheers
Bertrand


> ---
>=20
> Observed the issue while running Zephyr on R52.
> Also, found that KVM has similar behaviour.
>=20
> Changes from:-
> v1 - Moved the definitions of GICD_IGRPMODR, GICD_IGRPMODRN to gic_v3
> specific header.
>=20
> v2 - Updated the commit message.
>=20
> xen/arch/arm/include/asm/gic_v3_defs.h | 2 ++
> xen/arch/arm/vgic-v3.c                 | 4 ++++
> 2 files changed, 6 insertions(+)
>=20
> diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/includ=
e/asm/gic_v3_defs.h
> index 34ed5f857d..728e28d5e5 100644
> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
> @@ -30,6 +30,8 @@
> #define GICD_CLRSPI_NSR              (0x048)
> #define GICD_SETSPI_SR               (0x050)
> #define GICD_CLRSPI_SR               (0x058)
> +#define GICD_IGRPMODR                (0xD00)
> +#define GICD_IGRPMODRN               (0xD7C)
> #define GICD_IROUTER                 (0x6000)
> #define GICD_IROUTER32               (0x6100)
> #define GICD_IROUTER1019             (0x7FD8)
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 7fb99a9ff2..0c23f6df9d 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -685,6 +685,7 @@ static int __vgic_v3_distr_common_mmio_read(const cha=
r *name, struct vcpu *v,
>     switch ( reg )
>     {
>     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>         /* We do not implement security extensions for guests, read zero =
*/
>         if ( dabt.size !=3D DABT_WORD ) goto bad_width;
>         goto read_as_zero;
> @@ -781,6 +782,7 @@ static int __vgic_v3_distr_common_mmio_write(const ch=
ar *name, struct vcpu *v,
>     switch ( reg )
>     {
>     case VRANGE32(GICD_IGROUPR, GICD_IGROUPRN):
> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>         /* We do not implement security extensions for guests, write igno=
re */
>         goto write_ignore_32;
>=20
> @@ -1192,6 +1194,7 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, =
mmio_info_t *info,
>     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
>     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
>     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>         /*
>          * Above all register are common with GICR and GICD
>          * Manage in common
> @@ -1379,6 +1382,7 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v,=
 mmio_info_t *info,
>     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
>     case VRANGE32(GICD_IPRIORITYR, GICD_IPRIORITYRN):
>     case VRANGE32(GICD_ICFGR, GICD_ICFGRN):
> +    case VRANGE32(GICD_IGRPMODR, GICD_IGRPMODRN):
>         /* Above registers are common with GICR and GICD
>          * Manage in common */
>         return __vgic_v3_distr_common_mmio_write("vGICD", v, info,
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 07:40:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 07:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429606.680673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEYS-0004Cu-F0; Tue, 25 Oct 2022 07:40:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429606.680673; Tue, 25 Oct 2022 07:40:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEYS-0004Cn-BL; Tue, 25 Oct 2022 07:40:56 +0000
Received: by outflank-mailman (input) for mailman id 429606;
 Tue, 25 Oct 2022 07:40:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zbGC=22=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1onEYQ-0004CG-L1
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 07:40:54 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2061.outbound.protection.outlook.com [40.107.21.61])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5ac18f86-5438-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 09:40:54 +0200 (CEST)
Received: from AM5PR1001CA0051.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::28) by AS8PR08MB8157.eurprd08.prod.outlook.com
 (2603:10a6:20b:54e::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 07:40:42 +0000
Received: from VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:15:cafe::c4) by AM5PR1001CA0051.outlook.office365.com
 (2603:10a6:206:15::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend
 Transport; Tue, 25 Oct 2022 07:40:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT060.mail.protection.outlook.com (100.127.144.243) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 07:40:41 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Tue, 25 Oct 2022 07:40:41 +0000
Received: from 1f0fd2415263.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 47D6622E-CB28-4D76-9D1B-0A621E7DE117.1; 
 Tue, 25 Oct 2022 07:40:35 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1f0fd2415263.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 07:40:35 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB8633.eurprd08.prod.outlook.com (2603:10a6:20b:565::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 07:40:31 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 07:40:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5ac18f86-5438-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=MBuHBkQZnmRCL1IP/Ma9ibELJnkuwAnZ7guGSMxQdno1jleXgt89CTLxmz09yq6Fj/FiwOTEBgfm8UlvaAMfJVYrE4EltO0pIA+onA5FtI0SSOtjryKMNDcdheMW1HOYi8LfhuSTFRK7v1j6vD+JEOA1univavFSgtXfKOMs5QjBK7cwHXOHuRM/gqbD0V1WPBtwIu94vAHjnYB5XijvfPutjP8ARKgDCxJqmuLPMXsf22LA6ggd12ZtdFIiRJaUtMxvTT2AMq0uX7QHLkurmoZJVgInzKc1dz/MPz7YQAkgVGmVhUsXQZK9SElgOSOQ1NLz+x/MFpTLD7W4yd2XSw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9ewpeZm/XYWzq/mwsQYghhUBYp76satYddO2KlgcCB8=;
 b=AKLGZR2c2IM6mWGYHQn+UfYjorikLGEBWJpc2ZjU9Gwxr7jheahWmuLbsQLYZLIsJ7yiVuptUKEgonIu8qe7+JDhBVo2kvavmI5Io7Q4pItvV71wfuabAokNkPimRWIIXVKnOCBFVoL6lwHreJB9LC5j25Yk/XbKzeDT5dm1F6tCPMkXIV5MUJftv3Kpw+XFMLvdMrbW7dih3fryXnZahYiWK+59NSNMJe7tdp//1blIiTvUNv+mXs2VQTfuIk3uDWN2WNIoXisDhVNKUO2lkozlMs5DIclDc3C3oJ+aUOO3papG+GJyosv3sDEuQzf5xod1GVBAfVHPQziADFvtGw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9ewpeZm/XYWzq/mwsQYghhUBYp76satYddO2KlgcCB8=;
 b=6SHlIfyQnI2yf+p0BT8EDfOu31UYilatPAOre8BvRGLyJOi8GUoBkZzvIybFClVsuxop4NnaXvtYsoC6QPQq2/gEHO9owAfzbWNfj2ZS9iGNxV2uG220UCU0SKidmjx/BKLP8z0cYYskpM12904V0RxWSYWr6YL1ptF/mCKLa9Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 98e6e87f2fc86f85
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J4oW2FOS1JMhYqD/qCIDo2eHVHXmoPOVMSQYSEDgld9QI4clDi537ZRedMMWcjz2GXFC7oT0vhDZjGfPoL6+DqSVsaRUH+5sDyfdwm+qrf/hvHWRjjk17SJlUyPluTwNR4xpKXe5AF9ndB3fvciM82NPY0IuPs84c/C1iJFW9Dt+Wlqo6oQrUsB+3Pv6Y8y25z1GF8/gU4qsyLgRs5IE8UgVzIHNsJ7+QDpb4LSCJJhr/OtOV7lkd1+eOAoyv6jb+LfcO+FW4BvhjiOQyl8KLtFyBNGWyExYGFbPS+lwSsXx4NcK0dkHAECH3jxVs7ecUHzrAZiWAdi79fz4mR6vyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9ewpeZm/XYWzq/mwsQYghhUBYp76satYddO2KlgcCB8=;
 b=KCzLMmh2YOSRejxVQxhx+2hyn6y03pDVGdW9b5ygJ7t7u7SlfxsSS5UMZSa1eSFTDGtoqNwZL5h1CuAjQbPqwSUM3xZsa0NdwE2qtdOI980i7KBxipSr+2/6jp1cdsmm39TwdTUKzzMJhggCncB9v+4UsLpAJJfbtVEWBYelK6q76A2EoQhUVsEy+ZB2+/FspWqM9Hvw6C004m3nD5LJT6lj0Vaw981Xq9GWDeqLIzUODl5TX5iZiGWksMeLJfDha+gUkQw6kkBnue01XTCy/0u3XPLRJUeqwvrniBUAU64dHnUHvJg6wFETRuF5QjQggE+4TD4b6K/crt6qzux5Hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9ewpeZm/XYWzq/mwsQYghhUBYp76satYddO2KlgcCB8=;
 b=6SHlIfyQnI2yf+p0BT8EDfOu31UYilatPAOre8BvRGLyJOi8GUoBkZzvIybFClVsuxop4NnaXvtYsoC6QPQq2/gEHO9owAfzbWNfj2ZS9iGNxV2uG220UCU0SKidmjx/BKLP8z0cYYskpM12904V0RxWSYWr6YL1ptF/mCKLa9Y=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit
 guests
Thread-Topic: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit
 guests
Thread-Index: AQHY598RF0NcPOhi1keCFg9FvX7Ft64eul4A
Date: Tue, 25 Oct 2022 07:40:31 +0000
Message-ID: <E07E3398-73E5-44D3-AA63-B755EA039B91@arm.com>
References: <20221024193002.57888-1-ayankuma@amd.com>
In-Reply-To: <20221024193002.57888-1-ayankuma@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB8633:EE_|VI1EUR03FT060:EE_|AS8PR08MB8157:EE_
X-MS-Office365-Filtering-Correlation-Id: 72e7a10f-5444-4fea-cd1c-08dab65c381b
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 zIIrgPl2gBNFt5JXb3raAP3UsypBSoOnhaw1DUcqo9ulF29e17lezmbl5wnUfXAKPjZfsVDhn0HH0yDiN7GlVE3tJiPATtSREwJZH2U1sltpC/51MlUzq9WV0zm7BUCD567Iw1a+uFDuQ2dMz6/KEFK0Cr0y2D+ntL3S2uslNdhfq4LM3X2ffpXSVqcZnjNgVN6HLpaal0HkliDGePuEUX1onDUZGvWq2i3GPpnc95RCAZrR1C53AEqDt1+BgpGRjTCIRz57N1t34/VRIqohM8iIW7u8YMV7SJM4+MRbJYLNqri9LEhN7yb1BnkRHoGm7nwqJ5VAn+t2UOoJVNFmS3OZd8Omm2pwImFSThvCfWC2DoJnm/0faj23tD+OEG3ejxVVVNe3vPIVngxwNUfGeovPa5Mw+2oJ8QUSz8p6ntvf1Xud6gYTMyeOxP4+rHDiDKtEPW6BzYaVI4NW97yEQW3uiEPKXHztJ0WMh18UZCAB1maGcUpPAGSeUrASZpiAgBVL2z3wpB2umeSOAYyDXQxOtQURmdtyA8NsWxBjq64pGeNPAyOYTy6fivYuNpW9XLXFfc82SZNB7ctSb8gTXEfnisjCBeXbGChSTmIw+CSOCfdiatBnJqK7T3iAwtpbC14vd4ekV/XiMwA1irz+pH/7OJBEs4NEyX8wFEX/bJJmYm6IW5fbpcNtfpR/efay7G22HTR3ClRu01k97BLtBsJGklo6MYUWK0XtziRbwJ8tJdmCQ+YLvGg8mYH23ICQfF/Uv/pUetPoe8q/OUF1j1+mwIVVED/hP7ljViPCWrc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(366004)(136003)(376002)(451199015)(33656002)(122000001)(6512007)(38100700002)(54906003)(6916009)(53546011)(36756003)(6506007)(26005)(316002)(8676002)(5660300002)(64756008)(8936002)(66946007)(4326008)(71200400001)(83380400001)(38070700005)(186003)(41300700001)(2616005)(86362001)(76116006)(91956017)(2906002)(6486002)(66446008)(66476007)(66556008)(478600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6FECAFBB83EB4F46BF23C2F81B075BE2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8633
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	54bc8479-73fa-4a0a-d19b-08dab65c31e3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GxHtT7LUb0XwPOkqRdeZ/tqzD5DVceCjlLfZOc/cLxgwXL2xjQXiRt7O2t0xOnny40j3F4XNq/kRaICRusFfWmfT7VoTOn8xPDconX1zxJD1CubN56Zf5l9LcKSJVEWy2LMzucy6rGgo6rgJsM6tc3Dpov3aQhJzOfWSj0z7BAeohUBzuNISgwYfiiSX6TTZRL8lohWQDv4fd9gezreov0JH8HrIhRGLH6yz47x4b33U5Gp+DCQ4F7oIkR1OkH8rc6SdKcG6gAvZgf3AwWwYpQ9SBo5Wov3wYA4DOXWnRknYVUuqctuqag7HLwjZN64KN0cieqw8tPYBsBFVE3FHc+M6mf6zjeefg3SVM7kKs04zDE4A/ZfJyTFjJWiTiSejCJN62A6rrzwfztkv5RdJeP+EpGaus8AZznDBTOiRohxA8TIZ9oEONSj9bn0K4eQNU+gTp1C4pcM2j7AwzbBFGZEYHMow63jlEkjUwefewQAbiIXy5TRhNZ0osfn/oOxBtf5Kj168mfF222U4JXp0iUqztVcKBx3GvT/PYuecpE+a2pXRWq6xj2tqX1ylLw5N0p2cSjUinnJ8p07yys4YfTy5BFsSOQkk/xChsUQ6idpuR2uNX7oqRI+aNiUtinnHUZrS0M/nnLwGTX1b7nTidGVv8Pv7uhD2NoleTDw4kR/fEXxJJrJg8cCRaCnyMLGyucUNfgaIXicvCRLtCl0QHXOCgLUjdwfJAWEECJmkIsR5H0KwTKh/ytUUSoU7uBhpRA1cZNiWcUrEZO1trx9TUg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36840700001)(40470700004)(46966006)(186003)(83380400001)(47076005)(336012)(86362001)(36860700001)(81166007)(356005)(82740400003)(40460700003)(2906002)(41300700001)(5660300002)(8936002)(6862004)(82310400005)(40480700001)(2616005)(6486002)(478600001)(26005)(6512007)(53546011)(6506007)(4326008)(8676002)(70586007)(70206006)(316002)(54906003)(36756003)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 07:40:41.9845
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 72e7a10f-5444-4fea-cd1c-08dab65c381b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8157

Hi Ayan,

> On 24 Oct 2022, at 20:30, Ayan Kumar Halder <ayankuma@amd.com> wrote:
>=20
> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extr=
act()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 32bit register.
>=20
> The 32bit register is then modified bitwise with a mask (ie GICR_PENDBASE=
R_PTZ,
> it clears the 62nd bit) which is greater than 32 bits. This will give an
> incorrect result.
>=20
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variab=
le is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
>=20
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and pr=
operty tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>

Looks good to me to.

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
>=20
> Changes from:-
>=20
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with =
an
> appropriate commit message.
>=20
> xen/arch/arm/vgic-v3.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..7930ab6330 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -250,14 +250,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcp=
u *v, mmio_info_t *info,
>     case VREG64(GICR_PENDBASER):
>     {
>         unsigned long flags;
> +        uint64_t val;
>=20
>         if ( !v->domain->arch.vgic.has_its )
>             goto read_as_zero_64;
>         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>=20
>         spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r =3D vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &=3D ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> +        val =3D v->arch.vgic.rdist_pendbase;
> +        val &=3D ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> +        *r =3D vreg_reg64_extract(val, info);
>         spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>         return 1;
>     }
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 07:46:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 07:46:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429611.680684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEde-0004zs-4z; Tue, 25 Oct 2022 07:46:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429611.680684; Tue, 25 Oct 2022 07:46:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEde-0004zl-1r; Tue, 25 Oct 2022 07:46:18 +0000
Received: by outflank-mailman (input) for mailman id 429611;
 Tue, 25 Oct 2022 07:46:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zbGC=22=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1onEdd-0004zf-0V
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 07:46:17 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1ae61da5-5439-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 09:46:16 +0200 (CEST)
Received: from ZR0P278CA0061.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::12)
 by AS4PR08MB7830.eurprd08.prod.outlook.com (2603:10a6:20b:51a::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Tue, 25 Oct
 2022 07:46:07 +0000
Received: from VI1EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:910:21:cafe::ea) by ZR0P278CA0061.outlook.office365.com
 (2603:10a6:910:21::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 07:46:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT003.mail.protection.outlook.com (100.127.144.82) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 25 Oct 2022 07:46:06 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Tue, 25 Oct 2022 07:46:05 +0000
Received: from 833335acbc57.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 AFDAA6D0-80C6-42D9-B90E-22FF37AD6AEA.1; 
 Tue, 25 Oct 2022 07:45:59 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 833335acbc57.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 07:45:59 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAWPR08MB9471.eurprd08.prod.outlook.com (2603:10a6:102:2e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 07:45:56 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 07:45:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ae61da5-5439-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=cvzFzeMR9Cen0ubs0PesEyqLvbrfDu5hhBVtNgzz3Wjl+xkZdLGCVkzvwcrZAhuDMvU/kj8tgKHiFTKxcVZagM02jbw8Uten1z8KgCl6a/5n7TSsHOoPxTA1OljklaaVL9tpuoj+ijfq7DemGOP5S4IS7erUgatXS0ets8a5HRSGnxiF+qG7WVGv1u+OhbY2/MZ+OkvPQfhlXRA5W4AJKqIKyZqntzaFiECHrcm7BmKBYreC7zessPZupOFN7Nq7G/w04b+OqH/S/3upGuV5ULShZhjZactH0TmJUQYLngDiX5GsB3sXCTA9a8j79qMijaIZkltAKibuDy3dgbYjRg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zrEkbOUnR6AsXQiT84eQ7FI+jm36E9jr/4TRrok4S8U=;
 b=BJsJRET3cOJTyfonqxGKNqCgxMsXvDBbp+d1PhQat0bpvnyQsajwzL9rMeeTovWvM8f7A+kTKX4JGjPd13At6spRKwQFU2eN2pZT+I0/0AFHf6Y/DBwkTluyfwnL3EHMgq3Yptg8nea1veHSfF/GoVp2ip+K+l0yVenJPKqWzU3E/hAKE9p7yYUWjCFjJardPob5jp/SAbtXT7mMGy6dkgzQJ6UC2ZW5Ohunw51PW6G95hjrvoNOck8uNciV5dTvvPBcK2DdXvzXFvgw5vRRu9qbuaBJ/WdXm19l7vXbJYTVHMHLfRQkradnSyDPQBd7p6bQCf68tn82Y2NH61itAA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zrEkbOUnR6AsXQiT84eQ7FI+jm36E9jr/4TRrok4S8U=;
 b=qyOmrbVDtnjsA0toHCTWL9tLW7VF137OWR8uUxirZdqSU7co6kpYON48SigQ+3R1zIXvHIoAa8SlHKMjB6pRwnTv4yz9h9p4WLgWy8HsgUrN8F0Lcfoju+ldKjcqJ490X6rlWf9YHhMC/HJ2YrPtKDas5B3n4NjMIWpX72kRtYs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: a4246da23ea3133d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DbeL+UbyL2Jij8NBq5YTcP9SHpiEDy0gGLNfuiZJVL+N6/Fnzfoi3xspvVTVlEAYVSOBEkNuFyqUGdVRikql+rEjn+Z24u2wzUl3t5sYc9lfIUVBdG3uT7ouXflsEbjqVLr4pBkQlxeNKg7HPvTYj5ivuuVKd/LqlD2tLeqkkUkTn6+hWiujgXGjbh2oUb/gQ2ykPeXO0vqrUM/Gj3G6MKcADtj1+Mjgvsie0wawxdtm+MdNPqKRJi1NxnJXC0kjT6fb97gl18wxeDyUKigSa6vn75TBaHpCsoyFjwGJRoIwmRrBVlaYroCwCol7yMbunVD6VAQDDXcr94ILiJW09g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zrEkbOUnR6AsXQiT84eQ7FI+jm36E9jr/4TRrok4S8U=;
 b=I8O4BrFtAQ+oSfHEscN61KDzd6qCAuqJSnQEndYh2e19U3vlrw9HdEOazp8xcDNWlZOAXcXYR8AgZrmQ14pkAvCNjakRU3rGdVXGgkgsgONfXlA6G5o6sRxCrvBZffThOs/Fbk+EnHQArKOeCp+L7XHxNzXufbluPgbFvADXOst+69HTiC3lAyzwCBxp22dkfeQXi9e2LrR2nXeQAV1Z3cWK71lHdNeR5g1VZvS4FMPn/mCHwAzsZXSMbKK0900L/+hj3T7DK1risiYwZNJwCbcrg+8jke00SgcjRPYeGzpKTKkR3L1Bxsb/I7nCoh23ela2bdh0H8BawJ2taauaGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zrEkbOUnR6AsXQiT84eQ7FI+jm36E9jr/4TRrok4S8U=;
 b=qyOmrbVDtnjsA0toHCTWL9tLW7VF137OWR8uUxirZdqSU7co6kpYON48SigQ+3R1zIXvHIoAa8SlHKMjB6pRwnTv4yz9h9p4WLgWy8HsgUrN8F0Lcfoju+ldKjcqJ490X6rlWf9YHhMC/HJ2YrPtKDas5B3n4NjMIWpX72kRtYs=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Deadcode discussion based on Arm NS phys timer
Thread-Topic: Deadcode discussion based on Arm NS phys timer
Thread-Index:
 AQHY54gZ+lETtnfh9UiF8D+fGFbI5q4dXjCAgAANxICAAB5kgIAAySOAgABfjwCAAAmGgA==
Date: Tue, 25 Oct 2022 07:45:56 +0000
Message-ID: <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
In-Reply-To: <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAWPR08MB9471:EE_|VI1EUR03FT003:EE_|AS4PR08MB7830:EE_
X-MS-Office365-Filtering-Correlation-Id: f2a39f5b-f285-4058-bd99-08dab65cf96e
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 YsWyCbvaOUuLVOiR71hfchndD4GSpJIOGI+EF3q/LQ7/JkJQgV+tBqPco+r6UGTtk5KxkFPkRuCjkXqhYl3WTU7MUdZZ4l7sjED1VRHR8g9s11INjFsmIIFymJmDCb+p85BWL6VwVgehy3iqP2mHYxq39Gc9SnPqMTiQN9dUGPHBsZKy6tn1GVE0htSgQNZvT41NuQpIk0QHAKPK2qRGL73c4FgRZPQ5+8z8JaX5r+i/3kl/xlYhAETjLlUflxgMtETdzDrZBwFYqnsuPC0+CL/oEcwOF7PksCfw+jyquSfjvhNmuo2JdSjJyuGglejw4v+LMl7jAydTX1EHExomZ7ABsl5GAt0EvzR+bF0tT4W70rR5xK68AmZ/+Okynk56BmvomaxzmD8xtDSgnlF63AIuibAHPvHT2TXl0St2ET3phVQdOUu3WJyiEcIbdiPOP+iIZn6m8DR+Yr0pvmilUbZCn/p7nsg+9GWrG1MH1fg6ySsBa0rwm65Ow3S96P6QaYHux1FgiPfplzJoYLuIXcvTsP/XVPO8DukR10GMq/0gsat0SZc/9Z52WBdUDh1n/+r8dYMTvp9/2ZmIY66j19gi25Bf+SMuSr+8fw/p9isoWuUSbIoqg3HMrbScGk1AHFK7zeeZKP4KPHCb8JYykq+/YsMwTgqOf8CIYl0o/AoRoZZZl3aXrpkHojonLtxoLSXvm49UtUh3mASVq96bor7baaBle3JSic6l0LQbqyowhxFNSmF2fTEaAYnypVA2IbMStMnSt85aQTADVn9ttJNTkt81vJGzQ1U1PI7Bibs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199015)(66899015)(41300700001)(54906003)(478600001)(5660300002)(6486002)(33656002)(8936002)(83380400001)(38070700005)(38100700002)(8676002)(2906002)(36756003)(64756008)(66446008)(66476007)(66556008)(66946007)(4326008)(71200400001)(316002)(6916009)(76116006)(91956017)(6512007)(2616005)(186003)(26005)(122000001)(86362001)(6506007)(53546011)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4F19440A11D6BF4CB6362C26B64F0C1A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9471
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ca4ac37c-956e-4842-d61e-08dab65cf34e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PGiL5DhRmStOESvBrFiVwJXfvRmppHTxSmb3YMV8NLBmE/2LvWFjJa79KJLWCKZr4VEwd4+nhvwthOMqBktSoG9Rg8jPSW72fdR0LyCjblnJTPwMNr0ByQ9bt9N70H12U9z11OAR9pZ5c7l4mP1+tLsHenuk/+PPTDr6BCLShg+FHZX8i6zhU2GaGPZ2pYWH8jesxeJbDIP4Asl8z74ax9IHe1Go+R+aQOvcYkQNEvoLYwGT7gipmkcoodep19jpeOfwhACWYJ259A/W9GztQRaU90zscMATwbSOaYZk/4ljHTU/LE7sUJnclmh6Jd/UOBtB7E7TsC+YfP+BuHZclXiHEoSuXcqSPZ0I+1tLWqKXP6vN+7BE1OUPhiafKtpXPhMDUc6XpotbTb52j/pcfnWK/28yv7W/VoI2RL16L/v5xkU4fJxmFXYcH1/Vqja5bOKDbTcfjHSEL2tpHOtlPjXf2mknqzF5LDdFWJ+v9tPvBc2s2+LnCePAUMB/Itt/GAaKcXvfoBnjXW0z5aEhEd+CqpJjcZjis4SocLFsscbQvZ/nCQkKRojLtToIIEtWx3TMOkPwS+NM2AAMoh0k7dsDt5CyaBlWbiRdJ7NBARasO/jgOXvP7cK9cZDS4ftiGW1vwYV0HiUc+V0nxcYifB99B/SWgmDGP5xIOVj5ZxTEe72/YvDf9VrjBiorftTm6J8Fz2zoCiyrFKW+Yf2/uNv4HHTI8Q7GwDn3WmaGi03WXUAd6RSNaeHff3Q+96PvEgB32UqqVErgRF9si7l60Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(82310400005)(66899015)(36756003)(186003)(33656002)(83380400001)(8936002)(4326008)(70206006)(8676002)(2906002)(6862004)(70586007)(5660300002)(54906003)(41300700001)(86362001)(40480700001)(316002)(81166007)(2616005)(356005)(6506007)(40460700003)(53546011)(26005)(6512007)(47076005)(82740400003)(36860700001)(336012)(478600001)(6486002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 07:46:06.2971
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f2a39f5b-f285-4058-bd99-08dab65cf96e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7830

Hi Michal,

> On 25 Oct 2022, at 08:11, Michal Orzel <michal.orzel@amd.com> wrote:
>=20
> Hi,
>=20
> On 25/10/2022 03:29, Stefano Stabellini wrote:
>>=20
>>=20
>> On Mon, 24 Oct 2022, Julien Grall wrote:
>>>> On 24/10/2022 12:51, Julien Grall wrote:
>>>>> Caution: This message originated from an External Source. Use proper
>>>>> caution when opening attachments, clicking links, or responding.
>>>>>=20
>>>>>=20
>>>>> On 24/10/2022 10:07, Michal Orzel wrote:
>>>>>> Hello,
>>>>>=20
>>>>> Hi Michal,
>>>>>=20
>>>>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefl=
y
>>>>>> speaking, we are routing
>>>>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make u=
se
>>>>>> of it (as it uses the hypervisor timer CNTHP).
>>>>>> This timer is fully emulated, which means that there is nothing that=
 can
>>>>>> trigger such IRQ. This code is
>>>>>> a left over from early days, where the CNTHP was buggy on some model=
s
>>>>>> and we had to use the CNTP instead.
>>>>>>=20
>>>>>> As far as the problem itself is not really interesting, it raises a
>>>>>> question of what to do with a deadcode,
>>>>>> as there might be/are other deadcode places in Xen.
>>>>>=20
>>>>> There are multiple definition of deadcode. Depending on which one you
>>>>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So thi=
s
>>>>> would result to a lot of places impacted with the decision.
>>>>>=20
>>>>> So can you clarify what you mean by deadcode?
>>>> In the timer example, I think we have both a deadcode and unreachable =
code.
>>>> For the purpose of this discussion, let's take the MISRA definition of=
 a
>>>> deadcode which is a "code that can be executed
>>>> but has no effect on the functional behavior of the program". This dif=
fers
>>>> from the unreachable code definition that is
>>>> a "code that cannot be executed". Setting up the IRQ for Xen is an exa=
mple
>>>> of a deadcode. Code within IRQ handler is an unreachable code
>>>> (there is nothing that can trigger this IRQ).
>>>>=20
>>>> What I mean by deadcode happens to be the sum of the two cases above i=
.e.
>>>> the code that cannot be executed as well as the code that
>>>> does not impact the functionality of the program.
>>>>=20
>>>>>=20
>>>>>> One may say that it is useful to keep it, because one day,
>>>>>> someone might need it when dealing with yet another broken HW. Such
>>>>>> person would still need to modify the other
>>>>>> part of the code (e.g. reprogram_timer), but there would be less wor=
k
>>>>>> required overall. Personally, I'm not in favor of
>>>>>> such approach, because we should not really support possible scenari=
os
>>>>>> with broken HW (except for erratas listing known issues).
>>>>>=20
>>>>> The difference between "broken HW" and "HW with known errata" is a bi=
t
>>>>> unclear to me. Can you clarify how you would make the difference here=
?
>>>>>=20
>>>>> In particular, at which point do you consider that the HW should not =
be
>>>>> supported by Xen?
>>>> I'm not saying that HW should not be supported. The difference for me
>>>> between broken HW and
>>>> HW with known errata is that for the former, the incorrect behavior is=
 often
>>>> due to the early support stage,
>>>> using emulators/models instead of real HW, whereas for the latter, the=
 HW is
>>>> already released and it happens to be that it is buggy
>>>> (the HW vendor is aware of the issue and released erratas).
>>>=20
>>> Thanks for the clarification. What I would call broken is anything that=
 can't
>>> be fixed in software. For a not too fictional example, an HW where PCI =
devices
>>> are using the same stream ID. So effectively, passthrough can't be safe=
ly
>>> supported.
>>>=20
>>> Regarding, not yet released HW, I don't think Xen should have workaroun=
d for
>>> them. I wouldn't even call it "broken" because they are not yet release=
d and
>>> it is common to have bug in early revision.
>>>=20
>>>> Do we have any example in Xen for supporting broken HW,
>>>> whose vendor is not aware of the issue or did not release any errata?
>>> I will not cite any HW on the ML. But from my experience, the vendors a=
re not
>>> very vocal about issues in public (some don't even seem to have public =
doc).
>>> The best way to find the issues is to look at Linux commit.
>>>=20
>>>>=20
>>>>>=20
>>>>>> Also, as part of the certification/FUSA process, there should be no
>>>>>> deadcode and we should have explanation for every block of code.
>>>>>=20
>>>>> See above. What are you trying to cover by deadcode? Would protecting
>>>>> code with IS_ENABLED() (or #ifdef) ok?
>>>> I think this would be ok from the certification point of view (this wo=
uld at
>>>> least means, that we are aware of the issue
>>>> and we took some steps). Otherwise, such code is just an example of a
>>>> deadcode/unreachable code.
>>>=20
>>> Thanks for the clarification. So the exact approach will depend on the
>>> context....
>>>=20
>>>>>> There are different ways to deal with a deadcode: > 1. Get rid of it
>>>>>> completely
>>>>>> 2. Leave it as it is
>>>=20
>>> ... this is my preference in the context of the timer.
>>=20
>> From a certification point of view, the fewer lines of code the better,
>> and ideally all the lines of code used for the certified build should be
>> testable and used.
>>=20
>> So I think 2. is the lest useful option from a certification
>> perspective. For this reason, I'd prefer another alternative.
>>=20
>>=20
>>> If the other don't like it, then 1 would be my preference.
>>>=20
>>> In general, my preference would be either 3.3 or 3.2 (see below).
>>=20
>> I also think that 3.2 and 3.3 are good options for the general case. For
>> the timer, I can see why 1 is your (second) preference and I am fine
>> with 1 as well.
> Ok, sounds good to me. Let's still give Bertrand the chance to share his =
opinion.

We need to get rid of dead code and removing it is not always the best solu=
tion.

If the code is or could be useful for someone some day, protecting it with =
ifdef is ok.

In the mid term we will have to introduce a lot more ifdef or IS_ENABLED in=
 the
code so that we can compile out what we do not need and code not applying t=
o
some hardware is a case where we will do that (does not mean that by defaul=
t
we will not compile it in but we will make it easier to reduce the code siz=
e for a
specific use case).

So 3.2 and 3.3 are ok for me.

>=20
>>=20
>>=20
>>>>>> 3. Admit that it can be useful one day and:
>>>>>>    3.1. protect it with #if 0
>>>=20
>>> #if 0 should not be used in Xen code. IMHO this is the worse of all the=
 world.
> I share your opinion here Julien. Unfortunately we still have quite a few=
 examples
> in the Arm code using this either to mark something as TODO or to comment=
 out
> parts of the code waiting for future support. This is mostly in SMMU code=
 that
> was taken from Linux but already diverged quite far (maybe some cleanup i=
s necessary).

Definitely the SMMU code will need some cleaning.
#if 0 are a no go from a certification point of view.

Cheers
Bertrand

>=20
>>>=20
>>>>>>    3.2. protect it with a new Kconfig option (disabled by default)
>>>>>> using #ifdef
>>>>>>    3.3. protect it with a new Kconfig option (disabled by default)
>>>>>> using IS_ENABLED (to make sure code always compile)
>>>=20
>>> I would prefer 3.3 over 3.2. 3.2 would be used if it is too difficult t=
o get
>>> the code compiled when !IS_ENABLED.
>>>=20
>>> Similar to one if this is to move all the affected code in a separate f=
ile
>>> with using obj-$(CONFIG...). That would only work for large chunk of co=
de and
>>> would be preferred over 3.2.
>>=20
>=20
> ~Michal



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 07:50:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 07:50:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429615.680694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEhk-0006P0-M8; Tue, 25 Oct 2022 07:50:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429615.680694; Tue, 25 Oct 2022 07:50:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEhk-0006Ot-JW; Tue, 25 Oct 2022 07:50:32 +0000
Received: by outflank-mailman (input) for mailman id 429615;
 Tue, 25 Oct 2022 07:50:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qdjd=22=gmail.com=vsuneja63@srs-se1.protection.inumbo.net>)
 id 1onEhj-0006On-3Y
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 07:50:31 +0000
Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com
 [2a00:1450:4864:20::634])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1f95e30-5439-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 09:50:29 +0200 (CEST)
Received: by mail-ej1-x634.google.com with SMTP id b2so10417991eja.6
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 00:50:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1f95e30-5439-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=ZSdKgLbT+qddTsa8l5SAlwxgpn6twTeI8D1SKYVHR/c=;
        b=jZTWY/OJC7nfJlRYUz0fZT0IBXvhBGsXdjrtRbny/KkfBqd16v3r3YGEJWUfu7i/L4
         IhXED9e3fHUSHP6dtwi6R9ZWbJR9z5QTWIqEqPSiEEnRFbq4Nq7CMXlU8P2w1YsfauIf
         i4/ZVegdxOtCLZny/KjYhP2A+GbgSn1u66AsDJZvSn17wX+lxeSCdmJPjaLFyAcLrDRz
         aTH3BAC6J/lm55LwrpEnxCpvisDbIxvCI2daJvMIyo925Y3+uactbc4Z+44GDtNe+sZp
         xcTpRNrE4kTLdhzI67AL0pcfYgSIrK8pFTnefaS39EGLgOOlLJUlEqBQkO1IEpEGBwsK
         Lj7A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=ZSdKgLbT+qddTsa8l5SAlwxgpn6twTeI8D1SKYVHR/c=;
        b=FwIM/fig334v5/TELTgC+8mG5A6qTRXAxw8zPZca0wEPP2dKBTPIMWLVKE3XvDTd92
         uwZkEloGKelHOA0NSY+lD1sDGX1CKPOslyS2vxpdoDlOVQknfLedqDCVxJr0tJtcE0L6
         2POPKioQrZPYdfC47OF52TA3wTPIqVCK6WN8GviVhKTtlhHCRgiOI+voS83VLBrG8tQL
         x4zi5TSBNJaMce2Svw6fC+VUKXmg5KyIuOn0RI6xCOdWg9iJmnXuy3HTyKKqQ4qHIP27
         T2wyBoXrF1eOqlmto2ajHvof266dUoI931s4CtaG88wsK+CjHc+A/p1euUs2AUhPN5sz
         6WIg==
X-Gm-Message-State: ACrzQf1MHLjVMqYtYfWRrgfRkaiymRVu7F/0kuF/gQJPfNQnW5T2aOIN
	3dYMl0NJh3yUtL5rjjdGxvPgYWgVvyu2lujJ4Og=
X-Google-Smtp-Source: AMsMyM5zyEBIsw7zMR4fIR0uBXbvENNyG3ihO+5VWWEh9kStr/ldUM6Xbz5GNcWMqETP9YpDV9ZZiMG8kCvui/nd4tk=
X-Received: by 2002:a17:906:5a4b:b0:78d:8790:d4a1 with SMTP id
 my11-20020a1709065a4b00b0078d8790d4a1mr31264783ejc.329.1666684228901; Tue, 25
 Oct 2022 00:50:28 -0700 (PDT)
MIME-Version: 1.0
References: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop>
 <CALAP8f81ojfVD9n5EMtD7DxY-8uomgENVEQH9Afz7Hk9rfaAsw@mail.gmail.com>
 <alpine.DEB.2.22.394.2210181213370.4587@ubuntu-linux-20-04-desktop> <CALAP8f9Zgue6WfAk2uRGkg=1Up2Z+eQWqvQ1_Z2=r66Z5fvKoA@mail.gmail.com>
In-Reply-To: <CALAP8f9Zgue6WfAk2uRGkg=1Up2Z+eQWqvQ1_Z2=r66Z5fvKoA@mail.gmail.com>
From: Vipul Suneja <vsuneja63@gmail.com>
Date: Tue, 25 Oct 2022 13:20:16 +0530
Message-ID: <CALAP8f-qr5523h7tmz+URaXiEYPuMEQggvqXSm+B6f_Zo9B7aA@mail.gmail.com>
Subject: Re: Porting Xen in raspberry pi4B
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, 
	oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, 
	Bertrand.Marquis@arm.com
Content-Type: multipart/alternative; boundary="0000000000006aa06005ebd729fb"

--0000000000006aa06005ebd729fb
Content-Type: text/plain; charset="UTF-8"

Hi Stefano,

Thanks!

Any input further as per the logs attached?

Regards,
Vipul Kumar

On Wed, Oct 19, 2022 at 10:49 PM Vipul Suneja <vsuneja63@gmail.com> wrote:

> Hi Stefano,
>
> Thanks for the response!
>
> I am following the same link you shared from the beginning. Tried the
> command "vncviewer localhost:0" in DOM0 but same issue "Can't open
> display", below are the logs:
>
>
>
>
>
>
>
> *root@raspberrypi4-64:~# vncviewer localhost:0TigerVNC Viewer 64-bit
> v1.11.0Built on: 2020-09-08 12:16Copyright (C) 1999-2020 TigerVNC Team and
> many others (see README.rst)See https://www.tigervnc.org
> <https://www.tigervnc.org> for information on TigerVNC.Can't open display:*
>
> Below are the netstat logs, i couldn't see anything running at port 5900
> or 5901:
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> *root@raspberrypi4-64:~# netstat -tuwx Active Internet connections (w/o
> servers)Proto Recv-Q Send-Q Local Address           Foreign Address
> State       tcp        0    164 192.168.1.39:ssh        192.168.1.38:37472
> <http://192.168.1.38:37472>      ESTABLISHED Active UNIX domain sockets
> (w/o servers)Proto RefCnt Flags       Type       State         I-Node
> Pathunix  8      [ ]         DGRAM      CONNECTED      10565 /dev/logunix
>  3      [ ]         STREAM     CONNECTED      10891
> /var/run/xenstored/socketunix  3      [ ]         STREAM     CONNECTED
>  13791 unix  3      [ ]         STREAM     CONNECTED      10843
> /var/run/xenstored/socketunix  3      [ ]         STREAM     CONNECTED
>  10573 /var/run/xenstored/socketunix  2      [ ]         DGRAM
>  CONNECTED      14510 unix  3      [ ]         STREAM     CONNECTED
>  13249 unix  2      [ ]         DGRAM      CONNECTED      13887 unix  2
>  [ ]         DGRAM      CONNECTED      10599 unix  3      [ ]
> STREAM     CONNECTED      14005 unix  3      [ ]         STREAM
> CONNECTED      13258 unix  3      [ ]         STREAM     CONNECTED
>  13248 unix  3      [ ]         STREAM     CONNECTED      14003 unix  3
>  [ ]         STREAM     CONNECTED      10572 /var/run/xenstored/socketunix
>  3      [ ]         STREAM     CONNECTED      10786
> /var/run/xenstored/socketunix  3      [ ]         DGRAM      CONNECTED
>  13186 unix  3      [ ]         STREAM     CONNECTED      10864
> /var/run/xenstored/socketunix  3      [ ]         STREAM     CONNECTED
>  10812 /var/run/xenstored/socketunix  2      [ ]         DGRAM
>  CONNECTED      14083 unix  3      [ ]         STREAM     CONNECTED
>  10813 /var/run/xenstored/socket*
>
>
>
>
>
>
>
>
>
> *unix  3      [ ]         STREAM     CONNECTED      14068 unix  3      [ ]
>         STREAM     CONNECTED      13256 unix  3      [ ]         STREAM
> CONNECTED      10571 /var/run/xenstored/socketunix  3      [ ]
> STREAM     CONNECTED      10842 unix  3      [ ]         STREAM
> CONNECTED      13985 unix  3      [ ]         DGRAM      CONNECTED
>  13185 unix  2      [ ]         STREAM     CONNECTED      13884 unix  2
>  [ ]         DGRAM      CONNECTED      14528 unix  2      [ ]         DGRAM
>      CONNECTED      13785 unix  3      [ ]         STREAM     CONNECTED
>  14034 *
>
> Attaching xen log files of /var/log/xen.
> I didn't get the role of QEMU here because as mentioned earlier, I am
> porting in raspberrypi 4B.
>
> Regards,
> Vipul Kumar
>
> On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini <
> sstabellini@kernel.org> wrote:
>
>> It usually works the way it is described in the guide:
>>
>>
>> https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest
>>
>> You don't need to install any VNC-related server software because it is
>> already provided by Xen (to be precise it is provided by QEMU working
>> together with Xen.)
>>
>> You only need the vnc client in dom0 so that you can connect, but you
>> could also run the vnc client outside from another host. So basically
>> the following should work when executed in Dom0 after creating DomU:
>>
>>   vncviewer localhost:0
>>
>> Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use
>> netstat -taunp to check if there is anything running at port 5900 or
>> 5901?
>>
>> Cheers,
>>
>> Stefano
>>
>>
>> On Tue, 18 Oct 2022, Vipul Suneja wrote:
>> > Hi Stefano,
>> >
>> > Thanks for the response!
>> >
>> > I could install tigerVNC, x11vnc & libvncserver in Dom0
>> xen-image-minimal but only manage to install libvncserver(couldn't install
>> tigervnc
>> > & x11vnc because of x11
>> > support missing, it's wayland) in DOMU custom graphical image. I tried
>> running vncviewer with IP address & port in dom0 to access the domu
>> > graphical image display as per below commands.
>> >
>> >  vncviewer 192.168.1.42:5901
>> >
>> >  But it showing can't open display, below are the logs:
>> >
>> > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901
>> >
>> > TigerVNC Viewer 64-bit v1.11.0
>> > Built on: 2020-09-08 12:16
>> > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)
>> > See https://www.tigervnc.org for information on TigerVNC.
>> > Can't open display:
>> > root@raspberrypi4-64:~/guest1#
>> >
>> > I am not exactly sure what the issue is but I thought only libvncserver
>> in DOMU could work to get access but it did not work.
>> > If TigerVNC is the issue here then is there any other VNC source which
>> could be installed for both x11 & wayland supported images?
>> >
>> > Regards,
>> > Vipul Kumar
>> >
>> > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini <
>> sstabellini@kernel.org> wrote:
>> >       VNC is typically easier to setup, because SDL needs extra
>> libraries at
>> >       build time and runtime. If QEMU is built without SDL support it
>> won't
>> >       start when you ask for SDL.
>> >
>> >       VNC should work with both x11 and wayland in your domU. It
>> doesn't work
>> >       at the x11 level, it exposes a special fbdev device in your domU
>> that
>> >       should work with:
>> >       - a graphical console in Linux domU
>> >       - x11
>> >       - wayland (but I haven't tested this so I am not 100% sure about
>> it)
>> >
>> >       When you say "it doesn't work", what do you mean? Do you get a
>> black
>> >       window?
>> >
>> >       You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
>> >       (drivers/video/fbdev/xen-fbfront.c). I would try to get a
>> graphical text
>> >       console up and running in your domU before attempting x11/wayland.
>> >
>> >       Cheers,
>> >
>> >       Stefano
>> >
>> >       On Mon, 17 Oct 2022, Vipul Suneja wrote:
>> >       > Hi,
>> >       > Thanks!
>> >       >
>> >       > I have ported xen minimal image as DOM0 & custom wayland GUI
>> based image as DOMU in raspberry pi4B. I am trying to make GUI
>> >       display up
>> >       > for guest machine. I tried using sdl, included below line in
>> guest.conf file
>> >       > vfb= [ 'sdl=1' ]
>> >       >
>> >       > But it is throwing below error:
>> >       >
>> >       > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
>> >       > Parsing config from guest1.cfg
>> >       > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain
>> 3:error on QMP socket: Connection reset by peer
>> >       > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain
>> 3:Error happened with the QMP connection to QEMU
>> >       > libxl: error: libxl_dm.c:3351:device_model_postconfig_done:
>> Domain 3:Post DM startup configs failed, rc=-26
>> >       > libxl: error: libxl_create.c:1867:domcreate_devmodel_started:
>> Domain 3:device model did not start: -26
>> >       > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device
>> Model already exited
>> >       > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain
>> 3:Non-existant domain
>> >       > libxl: error: libxl_domain.c:1137:domain_destroy_callback:
>> Domain 3:Unable to destroy guest
>> >       > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain
>> 3:Destruction of domain failed
>> >       >
>> >       > Another way is VNC, i could install tigervnc in DOM0 but same i
>> couldn't in guest machine because it doesn't support
>> >       x11(supports wayland
>> >       > only). I am completely blocked here, Need your support to
>> enable the display up.
>> >       > Any alternative of VNC which could work in both x11 & wayland
>> supported images?
>> >       >
>> >       > Any input on VNC, SDL or any other way to proceed on this?
>> Looking forward to hearing from you.
>> >       >
>> >       > Regards,
>> >       > Vipul Kumar
>> >
>> >
>> >
>
>

--0000000000006aa06005ebd729fb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Stefano,<div><br></div><div>Thanks!</div><div><br></div=
><div>Any input further as per the logs attached?</div><div><br></div><div>=
Regards,</div><div>Vipul Kumar</div></div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 19, 2022 at 10:49 PM Vipul =
Suneja &lt;<a href=3D"mailto:vsuneja63@gmail.com">vsuneja63@gmail.com</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div d=
ir=3D"ltr">Hi Stefano,<br><br>Thanks for the response!<br><br>I am followin=
g the same link you shared from the beginning. Tried the command &quot;vncv=
iewer localhost:0&quot; in DOM0 but same issue &quot;Can&#39;t open display=
&quot;, below are the logs:<br><br><b>root@raspberrypi4-64:~# vncviewer loc=
alhost:0<br><br>TigerVNC Viewer 64-bit v1.11.0<br>Built on: 2020-09-08 12:1=
6<br>Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)=
<br>See <a href=3D"https://www.tigervnc.org" target=3D"_blank">https://www.=
tigervnc.org</a> for information on TigerVNC.<br>Can&#39;t open display:</b=
><br><br>Below are the netstat logs, i couldn&#39;t see anything running at=
 port 5900 or 5901:<br><br><b>root@raspberrypi4-64:~# netstat -tuwx <br>Act=
ive Internet connections (w/o servers)<br>Proto Recv-Q Send-Q Local Address=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Foreign Address =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 State =C2=A0 =C2=A0 =C2=A0 <br>tcp =C2=A0 =C2=A0 =C2=A0 =C2=A00 =C2=
=A0 =C2=A0164 192.168.1.39:ssh =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"http:/=
/192.168.1.38:37472" target=3D"_blank">192.168.1.38:37472</a> =C2=A0 =C2=A0=
 =C2=A0ESTABLISHED <br>Active UNIX domain sockets (w/o servers)<br>Proto Re=
fCnt Flags =C2=A0 =C2=A0 =C2=A0 Type =C2=A0 =C2=A0 =C2=A0 State =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 I-Node Path<br>unix =C2=A08 =C2=A0 =C2=A0 =C2=A0[ ] =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =
=C2=A010565 /dev/log<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010891 /var=
/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013791 <br=
>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =
=C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010843 /var/run/xenstored/socket=
<br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM=
 =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010573 /var/run/xenstored/socke=
t<br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM=
 =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014510 <br>unix =C2=A03 =
=C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CO=
NNECTED =C2=A0 =C2=A0 =C2=A013249 <br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=
=A0 =C2=A013887 <br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A010599 <b=
r>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =
=C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014005 <br>unix =C2=A03 =C2=A0 =
=C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED=
 =C2=A0 =C2=A0 =C2=A013258 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A0132=
48 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STR=
EAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A014003 <br>unix =C2=A03 =C2=
=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNE=
CTED =C2=A0 =C2=A0 =C2=A010572 /var/run/xenstored/socket<br>unix =C2=A03 =
=C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CO=
NNECTED =C2=A0 =C2=A0 =C2=A010786 /var/run/xenstored/socket<br>unix =C2=A03=
 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =
=C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A013186 <br>unix =C2=A03 =C2=A0 =C2=A0 =
=C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0=
 =C2=A0 =C2=A010864 /var/run/xenstored/socket<br>unix =C2=A03 =C2=A0 =C2=A0=
 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=
=A0 =C2=A0 =C2=A010812 /var/run/xenstored/socket<br>unix =C2=A02 =C2=A0 =C2=
=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECT=
ED =C2=A0 =C2=A0 =C2=A014083 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=
=A010813 /var/run/xenstored/socket</b><br><b>unix =C2=A03 =C2=A0 =C2=A0 =C2=
=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =
=C2=A0 =C2=A014068 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013256 <br>=
unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=
=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010571 /var/run/xenstored/socket<br=
>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =
=C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A010842 <br>unix =C2=A03 =C2=A0 =
=C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED=
 =C2=A0 =C2=A0 =C2=A013985 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=
=A013185 <br>unix =C2=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=A013884 <br>unix =C2=
=A02 =C2=A0 =C2=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=
=A0 =C2=A0CONNECTED =C2=A0 =C2=A0 =C2=A014528 <br>unix =C2=A02 =C2=A0 =C2=
=A0 =C2=A0[ ] =C2=A0 =C2=A0 =C2=A0 =C2=A0 DGRAM =C2=A0 =C2=A0 =C2=A0CONNECT=
ED =C2=A0 =C2=A0 =C2=A013785 <br>unix =C2=A03 =C2=A0 =C2=A0 =C2=A0[ ] =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 STREAM =C2=A0 =C2=A0 CONNECTED =C2=A0 =C2=A0 =C2=
=A014034 </b><br><br>Attaching xen log files of /var/log/xen.<br>I didn&#39=
;t get the role of QEMU here because as mentioned earlier, I am porting in =
raspberrypi 4B.<br><div><br></div><div>Regards,</div><div>Vipul Kumar</div>=
</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">=
On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini &lt;<a href=3D"mailto:s=
stabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt; wro=
te:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">It usually w=
orks the way it is described in the guide:<br>
<br>
<a href=3D"https://www.virtuatopia.com/index.php?title=3DConfiguring_a_VNC_=
based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest" rel=3D"nor=
eferrer" target=3D"_blank">https://www.virtuatopia.com/index.php?title=3DCo=
nfiguring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_G=
uest</a><br>
<br>
You don&#39;t need to install any VNC-related server software because it is=
<br>
already provided by Xen (to be precise it is provided by QEMU working<br>
together with Xen.)<br>
<br>
You only need the vnc client in dom0 so that you can connect, but you<br>
could also run the vnc client outside from another host. So basically<br>
the following should work when executed in Dom0 after creating DomU:<br>
<br>
=C2=A0 vncviewer localhost:0<br>
<br>
Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use<br>
netstat -taunp to check if there is anything running at port 5900 or<br>
5901?<br>
<br>
Cheers,<br>
<br>
Stefano<br>
<br>
<br>
On Tue, 18 Oct 2022, Vipul Suneja wrote:<br>
&gt; Hi Stefano,<br>
&gt; <br>
&gt; Thanks for the response!<br>
&gt; <br>
&gt; I could install tigerVNC, x11vnc &amp; libvncserver in Dom0 xen-image-=
minimal but only manage to install libvncserver(couldn&#39;t install tigerv=
nc<br>
&gt; &amp; x11vnc because of x11<br>
&gt; support missing, it&#39;s wayland) in DOMU custom graphical image. I t=
ried running vncviewer with IP address &amp; port in dom0 to access the dom=
u<br>
&gt; graphical image display as per below commands.<br>
&gt; =C2=A0<br>
&gt; =C2=A0vncviewer <a href=3D"http://192.168.1.42:5901" rel=3D"noreferrer=
" target=3D"_blank">192.168.1.42:5901</a><br>
&gt; =C2=A0<br>
&gt; =C2=A0But it showing can&#39;t open display, below are the logs:<br>
&gt; =C2=A0<br>
&gt; root@raspberrypi4-64:~/guest1# vncviewer <a href=3D"http://192.168.1.4=
2:5901" rel=3D"noreferrer" target=3D"_blank">192.168.1.42:5901</a><br>
&gt; <br>
&gt; TigerVNC Viewer 64-bit v1.11.0<br>
&gt; Built on: 2020-09-08 12:16<br>
&gt; Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)=
<br>
&gt; See <a href=3D"https://www.tigervnc.org" rel=3D"noreferrer" target=3D"=
_blank">https://www.tigervnc.org</a> for information on TigerVNC.<br>
&gt; Can&#39;t open display:<br>
&gt; root@raspberrypi4-64:~/guest1#<br>
&gt; <br>
&gt; I am not exactly=C2=A0sure what the issue is but I thought only libvnc=
server in DOMU could work to get access but it did not work.=C2=A0<br>
&gt; If TigerVNC is the issue here then is there any other VNC source which=
 could be installed for both x11 &amp; wayland supported images?<br>
&gt; <br>
&gt; Regards,<br>
&gt; Vipul Kumar<br>
&gt; <br>
&gt; On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini &lt;<a href=3D"mail=
to:sstabellini@kernel.org" target=3D"_blank">sstabellini@kernel.org</a>&gt;=
 wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC is typically easier to setup, because SD=
L needs extra libraries at<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0build time and runtime. If QEMU is built wit=
hout SDL support it won&#39;t<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0start when you ask for SDL.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0VNC should work with both x11 and wayland in=
 your domU. It doesn&#39;t work<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0at the x11 level, it exposes a special fbdev=
 device in your domU that<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0should work with:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0- a graphical console in Linux domU<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0- x11<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0- wayland (but I haven&#39;t tested this so =
I am not 100% sure about it)<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0When you say &quot;it doesn&#39;t work&quot;=
, what do you mean? Do you get a black<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0window?<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0You need CONFIG_XEN_FBDEV_FRONTEND in Linux =
domU<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0(drivers/video/fbdev/xen-fbfront.c). I would=
 try to get a graphical text<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0console up and running in your domU before a=
ttempting x11/wayland.<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0Stefano<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0On Mon, 17 Oct 2022, Vipul Suneja wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Hi,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Thanks!<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; I have ported xen minimal image as DOM0=
 &amp; custom wayland GUI based image as DOMU in raspberry pi4B. I am tryin=
g to make GUI<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0display up<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; for=C2=A0guest machine. I tried using=
=C2=A0sdl, included below line in guest.conf file<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; vfb=3D [ &#39;sdl=3D1&#39; ]<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; But it is throwing below error:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; root@raspberrypi4-64:~/guest1# xl creat=
e -c guest1.cfg<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Parsing config from guest1.cfg<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_qmp.c:1400:qmp_ev_f=
d_callback: Domain 3:error on QMP socket: Connection reset by peer<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_qmp.c:1439:qmp_ev_f=
d_callback: Domain 3:Error happened with the QMP connection to QEMU<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_dm.c:3351:device_mo=
del_postconfig_done: Domain 3:Post DM startup configs failed, rc=3D-26<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_create.c:1867:domcr=
eate_devmodel_started: Domain 3:device model did not start: -26<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_aoutils.c:646:libxl=
__kill_xs_path: Device Model already exited<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_domain.c:1183:libxl=
__destroy_domid: Domain 3:Non-existant domain<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_domain.c:1137:domai=
n_destroy_callback: Domain 3:Unable to destroy guest<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; libxl: error: libxl_domain.c:1064:domai=
n_destroy_cb: Domain 3:Destruction of domain failed<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Another way is VNC, i could install tig=
ervnc in DOM0 but same i couldn&#39;t in guest machine because it doesn&#39=
;t support<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0x11(supports wayland<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; only). I am completely blocked here, Ne=
ed your support to enable the display up.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Any alternative of VNC which could work=
 in both x11 &amp; wayland supported images?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Any input on VNC, SDL or any other way =
to proceed on this? Looking forward to hearing from you.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Regards,<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0&gt; Vipul Kumar<br>
&gt; <br>
&gt; <br>
&gt; </blockquote></div>
</blockquote></div>

--0000000000006aa06005ebd729fb--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 08:07:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 08:07:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429625.680706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEyV-0000Ko-LF; Tue, 25 Oct 2022 08:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429625.680706; Tue, 25 Oct 2022 08:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onEyV-0000Kh-Hd; Tue, 25 Oct 2022 08:07:51 +0000
Received: by outflank-mailman (input) for mailman id 429625;
 Tue, 25 Oct 2022 08:07:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onEyU-0000Kb-6m
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 08:07:50 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2060.outbound.protection.outlook.com [40.107.244.60])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1c3a1411-543c-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 10:07:48 +0200 (CEST)
Received: from DM6PR05CA0059.namprd05.prod.outlook.com (2603:10b6:5:335::28)
 by DM4PR12MB7767.namprd12.prod.outlook.com (2603:10b6:8:100::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Tue, 25 Oct
 2022 08:07:44 +0000
Received: from DM6NAM11FT109.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:335:cafe::6b) by DM6PR05CA0059.outlook.office365.com
 (2603:10b6:5:335::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.8 via Frontend
 Transport; Tue, 25 Oct 2022 08:07:44 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT109.mail.protection.outlook.com (10.13.173.178) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 08:07:44 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 03:07:41 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 01:07:12 -0700
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 25 Oct 2022 03:07:11 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c3a1411-543c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gvJ3XmtDzO5eJCk6Nq+xUDXapc1KdtEUGRwv/l1fRqje5HKIunVuNkr8weQa7XLtnl5bP2/ZNuF5Fe9EtLyf1hwlf9GWwn5I/vUpW6NIx3ThoK1B3OqZEVdAq8QDCSCKplKYLpurYNDsmrAIFaC3hNglg+3e2GrJyrxr7AdygfsMj5NsB0NHdKkYtd1a4TkSpQoPT0CNCkM4tAO9zD6gsgqwpvSP/57HxyLfxre3Qd32iLW2ZvAPV5djZnJHc1nTQc+ZhmOk6raZ/qEHV1Pzwnc/8GHfV/wx47f3FqUTjihYmAHqGRjJ+cmG2er2q1RtKj7K4Ku4umSkSdb0iIVJFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AO+q60fC8oAS8vOAuaw2LYlhKXmeCxSCxPF1xUsVmq0=;
 b=MK0Ykm6tzHBdDGZ6IFYxEhJ0ELQqTnG2RMaHhLmNKMWiMX3E7k4t6+ImUTmmDE6u/2G+Fe3FTjU0UokVKipombir8BQdRKCbBaX/I07Awk3cxOyRe4vgAI/9/Qei5EbyhEuOaBAPaCxu8A+UmyLmsbsFvCinvoJpOqggjA9E4TJrh6p30b+qjIZxWxqSHPtE7Yb+e2gV5aBJ91t+lKgY+M+u48HXTD2TlNvilagjGKL3w2Y9L3ozgaN8laLl2YbiukAY9a1N9pLQYpdnPeW8dZecPjUYhZCXWGctMCk445pbg4IM0umo7N77jDWAPC1lDCPj/iuR1oufX+/bP6A5hA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AO+q60fC8oAS8vOAuaw2LYlhKXmeCxSCxPF1xUsVmq0=;
 b=Jxx9P3vWZBgqQnU4qc6Umc1CIVUWbXERSBZaTo/7ZhMCRMjkJleyHuA7yrO0hrgAbTY0k0bbu0xHR6N+nnrxwxlQoc9i+svLMOU4AWQOmjpZ3ZnYlUD5FFULG2YF5qpMRPU0+Eui6AW3NY5kbTzMLoG7RfgD+0N7h4CII+puPqc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com>
Date: Tue, 25 Oct 2022 10:07:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Deadcode discussion based on Arm NS phys timer
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
 <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT109:EE_|DM4PR12MB7767:EE_
X-MS-Office365-Filtering-Correlation-Id: a8b2ca3e-1681-4f4b-e250-08dab65fff32
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u7mlgpcUuXPZe0zFxBWdToX1ftcEGbjMG4PURWYaxtNd8VZJ74NvGHWb6isMKnTIofg2mZLr1uUpda4hp+DZyFk9WyOQKSEG5C0H5S4LUT8GH7KK3WaxjiXYo7fNPBYkKFRkqIlXT1ucPsyOcE7dwzkeOBbp+EbkTUiOk2WQJWW15OtktU51+AuR4udbtXWcCyZQzhMcbVsN8EsMvgvR7aA9pmfeSAh1JrlpNGBegq5s6dtHfZt4a0Z5gLoBCHvA+8q+TQjh3dZlw4p0nylLJ3BBgLkuj60pxvT6R79Tmi+Y6/ABmbNOeeVVx+M1OAIUWW5HwnZMBmappKRCV2P/A7MoP3vUpRLPahkecrvRLq4FEOEVdqDrgVJ6Tl6rnxojcXSgy9F4DJzmDrUx6dRN3nizOfvD9DFigd2xFhgx2e/aSVBbyJy6ul9Rid9Imxz1sfKgLx5hd9GFIVpoaNUBxRDBITA60SIAFHrhMpXQMkVWAoBuvgoMNS3n09Z5+WuDJnMDZjf7xIEaXt3RVg3KgquG4jec10TXf/luX68P3sXyhpMqNxOrDRSevwAzH9kGe0mlqA5mmGYMNsJWvbICKfyLHddseGKXFa8QAbgBL4x8PThkG/DFm/N0+hzyF3jMSQkWvrzW3OiIEvJCeTZONQFtveM5x98xts0/My+xm/gbjBMWBmji8UyoLVB8cOonKTC0KFJwgJznsyMUccjNDsycMsqf71U1YUwVyJV8YyVMi6vMynp89N3QbDRqIOyibr22q1eZfIpnII58rsHWeXsVkP/sW0jJ/8pVDl91W5RKX0w8gM4plHB+Yohjv3q3H9073YN4YzMqZ4UbWt2cEw==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(31686004)(478600001)(66899015)(31696002)(86362001)(82310400005)(82740400003)(81166007)(356005)(336012)(316002)(36860700001)(70206006)(83380400001)(2906002)(16576012)(40480700001)(6916009)(70586007)(40460700003)(47076005)(2616005)(53546011)(186003)(44832011)(5660300002)(4326008)(8936002)(41300700001)(26005)(54906003)(8676002)(426003)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 08:07:44.5238
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a8b2ca3e-1681-4f4b-e250-08dab65fff32
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT109.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7767

Hi Bertrand,

On 25/10/2022 09:45, Bertrand Marquis wrote:
> 
> 
> Hi Michal,
> 
>> On 25 Oct 2022, at 08:11, Michal Orzel <michal.orzel@amd.com> wrote:
>>
>> Hi,
>>
>> On 25/10/2022 03:29, Stefano Stabellini wrote:
>>>
>>>
>>> On Mon, 24 Oct 2022, Julien Grall wrote:
>>>>> On 24/10/2022 12:51, Julien Grall wrote:
>>>>>> Caution: This message originated from an External Source. Use proper
>>>>>> caution when opening attachments, clicking links, or responding.
>>>>>>
>>>>>>
>>>>>> On 24/10/2022 10:07, Michal Orzel wrote:
>>>>>>> Hello,
>>>>>>
>>>>>> Hi Michal,
>>>>>>
>>>>>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly
>>>>>>> speaking, we are routing
>>>>>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use
>>>>>>> of it (as it uses the hypervisor timer CNTHP).
>>>>>>> This timer is fully emulated, which means that there is nothing that can
>>>>>>> trigger such IRQ. This code is
>>>>>>> a left over from early days, where the CNTHP was buggy on some models
>>>>>>> and we had to use the CNTP instead.
>>>>>>>
>>>>>>> As far as the problem itself is not really interesting, it raises a
>>>>>>> question of what to do with a deadcode,
>>>>>>> as there might be/are other deadcode places in Xen.
>>>>>>
>>>>>> There are multiple definition of deadcode. Depending on which one you
>>>>>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
>>>>>> would result to a lot of places impacted with the decision.
>>>>>>
>>>>>> So can you clarify what you mean by deadcode?
>>>>> In the timer example, I think we have both a deadcode and unreachable code.
>>>>> For the purpose of this discussion, let's take the MISRA definition of a
>>>>> deadcode which is a "code that can be executed
>>>>> but has no effect on the functional behavior of the program". This differs
>>>>> from the unreachable code definition that is
>>>>> a "code that cannot be executed". Setting up the IRQ for Xen is an example
>>>>> of a deadcode. Code within IRQ handler is an unreachable code
>>>>> (there is nothing that can trigger this IRQ).
>>>>>
>>>>> What I mean by deadcode happens to be the sum of the two cases above i.e.
>>>>> the code that cannot be executed as well as the code that
>>>>> does not impact the functionality of the program.
>>>>>
>>>>>>
>>>>>>> One may say that it is useful to keep it, because one day,
>>>>>>> someone might need it when dealing with yet another broken HW. Such
>>>>>>> person would still need to modify the other
>>>>>>> part of the code (e.g. reprogram_timer), but there would be less work
>>>>>>> required overall. Personally, I'm not in favor of
>>>>>>> such approach, because we should not really support possible scenarios
>>>>>>> with broken HW (except for erratas listing known issues).
>>>>>>
>>>>>> The difference between "broken HW" and "HW with known errata" is a bit
>>>>>> unclear to me. Can you clarify how you would make the difference here?
>>>>>>
>>>>>> In particular, at which point do you consider that the HW should not be
>>>>>> supported by Xen?
>>>>> I'm not saying that HW should not be supported. The difference for me
>>>>> between broken HW and
>>>>> HW with known errata is that for the former, the incorrect behavior is often
>>>>> due to the early support stage,
>>>>> using emulators/models instead of real HW, whereas for the latter, the HW is
>>>>> already released and it happens to be that it is buggy
>>>>> (the HW vendor is aware of the issue and released erratas).
>>>>
>>>> Thanks for the clarification. What I would call broken is anything that can't
>>>> be fixed in software. For a not too fictional example, an HW where PCI devices
>>>> are using the same stream ID. So effectively, passthrough can't be safely
>>>> supported.
>>>>
>>>> Regarding, not yet released HW, I don't think Xen should have workaround for
>>>> them. I wouldn't even call it "broken" because they are not yet released and
>>>> it is common to have bug in early revision.
>>>>
>>>>> Do we have any example in Xen for supporting broken HW,
>>>>> whose vendor is not aware of the issue or did not release any errata?
>>>> I will not cite any HW on the ML. But from my experience, the vendors are not
>>>> very vocal about issues in public (some don't even seem to have public doc).
>>>> The best way to find the issues is to look at Linux commit.
>>>>
>>>>>
>>>>>>
>>>>>>> Also, as part of the certification/FUSA process, there should be no
>>>>>>> deadcode and we should have explanation for every block of code.
>>>>>>
>>>>>> See above. What are you trying to cover by deadcode? Would protecting
>>>>>> code with IS_ENABLED() (or #ifdef) ok?
>>>>> I think this would be ok from the certification point of view (this would at
>>>>> least means, that we are aware of the issue
>>>>> and we took some steps). Otherwise, such code is just an example of a
>>>>> deadcode/unreachable code.
>>>>
>>>> Thanks for the clarification. So the exact approach will depend on the
>>>> context....
>>>>
>>>>>>> There are different ways to deal with a deadcode: > 1. Get rid of it
>>>>>>> completely
>>>>>>> 2. Leave it as it is
>>>>
>>>> ... this is my preference in the context of the timer.
>>>
>>> From a certification point of view, the fewer lines of code the better,
>>> and ideally all the lines of code used for the certified build should be
>>> testable and used.
>>>
>>> So I think 2. is the lest useful option from a certification
>>> perspective. For this reason, I'd prefer another alternative.
>>>
>>>
>>>> If the other don't like it, then 1 would be my preference.
>>>>
>>>> In general, my preference would be either 3.3 or 3.2 (see below).
>>>
>>> I also think that 3.2 and 3.3 are good options for the general case. For
>>> the timer, I can see why 1 is your (second) preference and I am fine
>>> with 1 as well.
>> Ok, sounds good to me. Let's still give Bertrand the chance to share his opinion.
> 
> We need to get rid of dead code and removing it is not always the best solution.
> 
> If the code is or could be useful for someone some day, protecting it with ifdef is ok.
> 
> In the mid term we will have to introduce a lot more ifdef or IS_ENABLED in the
> code so that we can compile out what we do not need and code not applying to
> some hardware is a case where we will do that (does not mean that by default
> we will not compile it in but we will make it easier to reduce the code size for a
> specific use case).
> 
> So 3.2 and 3.3 are ok for me.

So we all agree that the code in the current form is a no go from certification purposes.
That is good :)

The reason why I opt for solution 1 and not the others is that in the latter case it would
mean introducing the Kconfig option to allow user to select the timer to be used by Xen.
This is not really correct. Also in the current form, it would also require adding more
code to time.c code because at the moment using CNTP for Xen would not work out of the box.
The architecture defines the hypervisor timer for a purpose. If it does not work, it means
that the HW is problematic. I agree that we would want to support such use case but I'm not
really aware of any issue like that. Adding more code and Kconfig options just because
one day someone may face issues with a new HW is something I am not a fan of.

I would agree with your solution under the condition that the code is already ready
for the timer switch.

I guess we need another round of sharing opinions.

> 
>>
>>>
>>>
>>>>>>> 3. Admit that it can be useful one day and:
>>>>>>>    3.1. protect it with #if 0
>>>>
>>>> #if 0 should not be used in Xen code. IMHO this is the worse of all the world.
>> I share your opinion here Julien. Unfortunately we still have quite a few examples
>> in the Arm code using this either to mark something as TODO or to comment out
>> parts of the code waiting for future support. This is mostly in SMMU code that
>> was taken from Linux but already diverged quite far (maybe some cleanup is necessary).
> 
> Definitely the SMMU code will need some cleaning.
> #if 0 are a no go from a certification point of view.
> 
> Cheers
> Bertrand
> 
>>
>>>>
>>>>>>>    3.2. protect it with a new Kconfig option (disabled by default)
>>>>>>> using #ifdef
>>>>>>>    3.3. protect it with a new Kconfig option (disabled by default)
>>>>>>> using IS_ENABLED (to make sure code always compile)
>>>>
>>>> I would prefer 3.3 over 3.2. 3.2 would be used if it is too difficult to get
>>>> the code compiled when !IS_ENABLED.
>>>>
>>>> Similar to one if this is to move all the affected code in a separate file
>>>> with using obj-$(CONFIG...). That would only work for large chunk of code and
>>>> would be preferred over 3.2.
>>>
>>
>> ~Michal
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 08:13:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 08:13:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429629.680717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onF3t-0001qE-7d; Tue, 25 Oct 2022 08:13:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429629.680717; Tue, 25 Oct 2022 08:13:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onF3t-0001q7-4j; Tue, 25 Oct 2022 08:13:25 +0000
Received: by outflank-mailman (input) for mailman id 429629;
 Tue, 25 Oct 2022 08:13:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onF3r-0001pt-UV; Tue, 25 Oct 2022 08:13:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onF3r-0006c2-PZ; Tue, 25 Oct 2022 08:13:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onF3r-0002XM-EL; Tue, 25 Oct 2022 08:13:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onF3r-0004dM-Df; Tue, 25 Oct 2022 08:13:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=X+x3nY9xy/lq7XDBqzxv6L5b8QzyDlWBEMqfCzAQhqo=; b=i7oT+nCy4TGFs5br0FC6lcNZbv
	b2Ip6sdvi9IkHtbtgMfRB/XjvV8hMe4nbswSEuCz+9a2ilqWF4st6uBA7DA92eD7do++na/0ffMmU
	Q4UN9/Lm17LZnlF7i79UH/vfmOeSkjyilpVepqeYV3pZQoDbMN5f+WG5UTxSom7TeQzY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174370-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174370: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=fb493ac84ebc6860e1690770fb88183effadebfb
X-Osstest-Versions-That:
    ovmf=4d29da411fa031031a90ec713ad826570e9117d7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 08:13:23 +0000

flight 174370 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174370/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 fb493ac84ebc6860e1690770fb88183effadebfb
baseline version:
 ovmf                 4d29da411fa031031a90ec713ad826570e9117d7

Last test of basis   174354  2022-10-24 06:40:39 Z    1 days
Testing same since   174370  2022-10-24 22:42:23 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Leif Lindholm <quic_llindhol@quicinc.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Yi Li <yi1.li@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   4d29da411f..fb493ac84e  fb493ac84ebc6860e1690770fb88183effadebfb -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 08:13:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 08:13:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429632.680728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onF41-000294-Fd; Tue, 25 Oct 2022 08:13:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429632.680728; Tue, 25 Oct 2022 08:13:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onF41-00028x-Cw; Tue, 25 Oct 2022 08:13:33 +0000
Received: by outflank-mailman (input) for mailman id 429632;
 Tue, 25 Oct 2022 08:13:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onF3z-00027J-PD
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 08:13:31 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e68fc449-543c-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 10:13:28 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 04:13:24 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA1PR03MB6450.namprd03.prod.outlook.com (2603:10b6:806:1c1::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 08:13:21 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 08:13:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e68fc449-543c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666685608;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=YX6jqx21pGMDg6Blul6hkJqC8sdjRaTf+MR4wZxV8eI=;
  b=eGcJ9ZhbXpcsdZUwjSvhFMdXjvu2PEE8/o0K/t6j4QA4ZF0D9dmHJeZ2
   0r+qRvAFmrES2HM1aZWWfYtR2z0LAM4HxLVvdf9ZwspMoYmBqPk5Batm6
   76NsCrYDm0JVF2nvEh8xkjwSqxOCtQzvVm7m90hYtt5B/hU8Jdx2UMIpw
   0=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 83456124
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3Al52eLK64teSsJDXgsE+KmQxR2vbMJbbHMSYv2?=
 =?us-ascii?q?y7JWF8qXhjsoshV/T9vMzAtp4WMNckWm8diJPyAfru/5I5j2gKE5yuO8bbr9?=
 =?us-ascii?q?stcgWt1nkbNJVQgTP23j6yiff2+NX+0duchnxjw64xoPKRVkX05WPaRAcXcb?=
 =?us-ascii?q?Fp0/pW8tZ6AY+7rUjAD4mi3gllc1gjwXnTE6jC15i+XeJxUV14mxZ5xk0YSZ?=
 =?us-ascii?q?pOjKn9wEDsYQtD6sJMKBvP6gmuio/OEE45dEds7mXTOUz4W7bFwkmTgTtI7G?=
 =?us-ascii?q?VH0Wvg6jagK644JxJeeCoyRPhP98H18FI7aAC5f3JfIGi3WEcmHv8PN1PtE7?=
 =?us-ascii?q?VZbwWRo9NiAerGnlHXm+aJ8nRzb3eM7+aiLgYBoF/iY2zsDcHhrd4TPJWhUL?=
 =?us-ascii?q?jW0bqFgtToSunB/FOZfHRm5jaQ/ufwsiL7Ti1HPdEEmZ2uNx+A1CcxtoFfU/?=
 =?us-ascii?q?MXoMt2Kn+4gPTSMuNkprJor1GLq2lfPbqBJbi1fllEZhLBkzZIk8pqD+MJnS?=
 =?us-ascii?q?+ox9QYazUI9K9s5H+v8BnvEcao4WRbm3OxsamQlrbv4Lu3IXJscAGqBq9hMV?=
 =?us-ascii?q?DI4ZUmMKlStRCefpyWx3bg0RY0JTnqzMC15TNcnH9LbjRlAvBfbh2zPbv+ck?=
 =?us-ascii?q?G06QWNp6IQYuKCfh9KvmaWEawbo7QgmAWIzJp0C94eFneXmdv8N6PsigUnf5?=
 =?us-ascii?q?/dqeOKuAYriVU0BQXzwJoe6twAKVwj1zf2CCdKdtiGZOc6V1w0DlRpFScTZI?=
 =?us-ascii?q?2KynH/pgxgcMak0c1j7vyFzuzCCBFSdNh1IMqxxP99czo3k+31jD6NTGBu9i?=
 =?us-ascii?q?2KPjOHHqOO6BAhtQSWzmDC/Ggl1daSVJs7S1bvPl07zKNlVhTrH6e1tcMgn9?=
 =?us-ascii?q?sCTHdSBLYNw6mE6BUbE9TlO8/TV3FZ2EHCD8nlr922M94K6ixDFv8QZtamo2?=
 =?us-ascii?q?5krBYj3FGJviPGoJh8vpjLk/z0SaJeiaLX7K68xmpUDcV6YnubkxpPuFmu0G?=
 =?us-ascii?q?mIIkFCoIy8h2//K5PIMQ2KPbXwE0M3Mu05i1SSsY0FzW4JUC6hOQ9rJoRJ0L?=
 =?us-ascii?q?cNp0diYKRgwLDAmPQGp3poYahuKqlkEd9pU84pdjhb0UsrYEFur3uOLZu6nO?=
 =?us-ascii?q?vfDlGgrjNKgqrn/rjnuDnoann3j+xDhR9vnj1lV6FYcOWe5Q5gFYKAX5tbET?=
 =?us-ascii?q?YIl3TlaSoM1rMdkgIAjrrPdvFtmMcQKjftOHgsSjlGPpHnweUU6BPsL43+Iz?=
 =?us-ascii?q?PXO/5vxeQgj5vGxwUUerPwbssdOElqWgSTROXzCmoB7yw3rzcl80Kd3VamSw?=
 =?us-ascii?q?YQ0iOmBwEjanoLyOEak/1kx4ubMPlMUvV8x6Sc2q+Kqfddd/kwmoOEIJVhvO?=
 =?us-ascii?q?5RDsM+P0iRStXvER3ddef0tyHxySQpxJ/v3NRelQgX31Scu3SrOIIy2hmjgj?=
 =?us-ascii?q?RovceydGapAs/XS5DHUToN9Ry6LJvf/PEZkl/gx2Ylw0jNWIzovdz+CtiW3L?=
 =?us-ascii?q?5UwR0YZfc+yXJ/Pp48j9NiX2jXL+5h/d65T4EM+kYoH8JhjbTbBVdnkT9Hm5?=
 =?us-ascii?q?XegkSat7CxkIuDiIBO3uM1WuFAVbk+GPKYGk6Dc23J8dlxtHkoCtd/lsAdF6?=
 =?us-ascii?q?JUMUWEe9nqxPiX9b1sl8fXqsjgK6wbGXX1rZoHtW/jFGuWWeBRbtK7SuS8cw?=
 =?us-ascii?q?bK2fYPzgl0YE8l9hkXuspqhzP+hFlpvCvbExTafAQH9mBR3wR8iuHfzQNm+8?=
 =?us-ascii?q?iGZbxo+klOQGMVozZmikXQL8dkSpQqaQ/2SWHH/2AtcYUKdTvrtTrdoB6U2c?=
 =?us-ascii?q?rhEeN54aydFk/r6ahnm8Vq49DY2K8w/HSJ64at6b1tOGK+1FE5Rl879Iljdm?=
 =?us-ascii?q?U2wjOZKF4EEYJortxTDaUy4/MdiJ0FhN8RtdPjLK4RXvL/PvoVSPndFJd+Y8?=
 =?us-ascii?q?RcRepUtPqq3IFjG/SjUMzs1/svfizOXIXpgRJRx+XMw8ccSUMiM4OV2NElTQ?=
 =?us-ascii?q?7VD1CgPuFE21A3gJl1P8yT/6qRxU+UgFEh+R6S5nUN6Q4UtgWBF3YNzcPzZA?=
 =?us-ascii?q?F54rduPjki83XtvwZZepZLBwATwd46/VIszKpdTCnsA7B4W8TWlPnA6KTF5Z?=
 =?us-ascii?q?E3TBUgu8DzarZu67RHOuui0M0lL739A3kC0krlpKobBdKaHFce6Wpacirzmw?=
 =?us-ascii?q?mK4NCw2FJxh352uWNjo5f6q6YUmRLrWbtwzWFSOINQig+6JNx5C17Bjj5ysx?=
 =?us-ascii?q?EKT2a0LhF1+CA4rIu/DMHiBZWa/H1UvpM/+puVIB9FPR6IMdDqrP0QpPHDoL?=
 =?us-ascii?q?3piaM7WHG6U9Z+LC9jDTejiEfLrlL1xWGq3ViQPKE/jcfi4zkFTjr19qDWll?=
 =?us-ascii?q?GyvT8JWNONxra/RNca3k06xHPUlWJmXb9Kcv5ohmv+OzVBCKxXgcQ9Hc7B+G?=
 =?us-ascii?q?Thqp/UqQXNyzqGblZX2lMkcLHRef0GbSFozmPIZuU+KDF+WO/t9xQQdL0flB?=
 =?us-ascii?q?RRoa18Qb8ANkArsDcYuCbR+U0lzbpnlBOeALcCNxdsYEDRESbVsFwZw5sKRA?=
 =?us-ascii?q?oCaTMxKfVpbXj4QrD9l9G7HSpHddPMg2+UT7Nv0cqytJmXiCh90owIZbZ/CF?=
 =?us-ascii?q?OvGCFxapuE77++7Z1pz5sauN9jcFuFfUA4EExY=3D?=
X-IronPort-AV: E=Sophos;i="5.95,211,1661832000"; 
   d="scan'208";a="83456124"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DxqvUWHDp4MOHLUfXaqoRuJNDHkkZcbIdF73FEG3Yt9DVV1pXOtidGU5b1noMmNhpRQQBAaObIVoePcAM9e2uS9f1gj3jP44KyEiY1CpYTKRxwjLTzkmS8dYEB+/CSNGTjIE8yUzXHhkj93FGIKtP9cXfSpBHqwIphd8Byzbq8gHoxlIl5p+T2ID6d5/IcdYvnMS6fSDNu2qaZWFtQ7MKDl8AoOfI1GN/wZ6P3u6DN3y9UI9r7NGRkTKc5sgpZxuEDffPgXsGo+aPCCXZPD6dQmCss/+yp7ruTaE8gORn9haZIX5BS0YmTOUzUNICn3FnVYLwsFbTKH4fY/74pSfKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YX6jqx21pGMDg6Blul6hkJqC8sdjRaTf+MR4wZxV8eI=;
 b=IYQMyZFEYwJDRvqyP6EK9jZF0SV4mcH4pbEEFz4FcTSF9120yFAUx6q4LW0sll91peIKlZOREIJ+5EVRAx9XJnLlxAxVZzfmRD7Bxu69T44t0d9rL5ZfthpsxIOePYY51JIzAWFyGCBgSu8T8ty0O6jlHmzJ+8/xynAhO8pc1vsLf3ndVSC/njMHeuDum2wNgONKUpjwVwWbZ5qH6+fW0/PLHTNBPELyY7P6AIG2NwWXD7+c/UUcvHw4hAwWooMFnYDeS8jegECo+8gGSQAh7BuwRSbJXzJCd15Wim6Q4Wyi+reot6JtPeEDAYyQTLMFkoGA1RuiEQQHsMg4rsUhvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YX6jqx21pGMDg6Blul6hkJqC8sdjRaTf+MR4wZxV8eI=;
 b=AIcGIEoqrr0BI4OcJctrVXz5pxOP/1c7AhLkCVJg/9DB/zKixgBqOwq/JmbsuArO/QjgyDyaPt4RU8ghqSRsiiRGGDkW6lrlsdoeEnsB9A1svrG4AJCwxHb+J6azc0EmTTtG9A0YBILIMPxO2YcAqLYPJtSz+HUy+S2tMXV63xk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 10:13:14 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@intel.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Message-ID: <Y1eamiBY0d+julWk@Air-de-Roger>
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
X-ClientProxiedBy: LO4P265CA0169.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:312::6) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6450:EE_
X-MS-Office365-Filtering-Correlation-Id: ee1ba90c-460c-4a4b-57f8-08dab660c7b1
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JGXf6o3OiM560uymIG0xw6FtXfZBcX1aCMDhpp74EdCUOMP5GwGp0ajHSQo63zugTu/d2lh0fnU45cbZ/2zCxft5bfoxFJbswTfTLD1DdSanBNV/L+7FzBTsa7TZvN76hLnHfCqT2o94GESO3y4/v29/fHh+ZZUqYZUaIZIKa9dwDA1jitWrVqf7ehZuA14f6MQZpdx3gXx9L/n5mUGQ+E83mxFoX5W8JGgCqO/E5bTtsERt8jc4xzz2Ko+XaMptgh/U6+jGmdCsQMdxAMd+CW+T64AN0ly+fdvzcfHup/vq0caeOurTpEGS18EqEJylGUMcYMSDdiEDAmGuFx36I6oL3sgPfUfCrSjrQ8ob7yoMhBeTOvVkV2w5uqsFvYbvSM1DlNFfCE4jz1r6dLL2KGuDzmYgxPmIxliJFuwwwiDaorc4uVZH3zcOio+VFY11ywoGbOR/kUcdG9qRl/YOWfa+lgCQCG9dXwzMU1kpLooQ0GlCGAzAXsJ0Vu3ggZBDYHb7RhVeTgRs4c6UpPV6NwvTxCGIcv/9gULFG0KBYyvn2U/kQJTSJxLGDKmtfaE1rjh3o51W0bjKXfwIeRy3AiYTS6wtyjXePEOgPbYn37FEhsjSR4qZFPnoZEa3V8kYRHoDlvLq96aeeAkpVK1b1ROYWF5BpLB8qim8WPa3maGDOJx6u9uf/SQpbphHqMTciFXBN/91RChygqqLQEMxpQJMBwRVhpM8ND8EyIM4R+e7UOFMseZC65MTzY9yedYd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199015)(478600001)(2906002)(6666004)(33716001)(26005)(9686003)(6512007)(6506007)(85182001)(6486002)(82960400001)(4326008)(38100700002)(5660300002)(8936002)(66556008)(66476007)(41300700001)(66946007)(186003)(8676002)(83380400001)(4744005)(86362001)(316002)(54906003)(6916009)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VEdPOGR6eDd2Y2pKRzMyM0JDQTMvd3BBd1hHbHNFY0dnNUNQZitFRTZFbU9E?=
 =?utf-8?B?ZVU5MVZkTWU0cEVjbGxoM2RFVmpURXRCMTA4SFRsTEgySGZkNStpZllGVm9v?=
 =?utf-8?B?Tm50SC9vc003ZUhvRmh5RFNsK21Kc3Qyd0V5djF2cEI2c0NoOU5hK1JQcGJv?=
 =?utf-8?B?TmdSZElOdzRjUUVrZzM4b0dhZGxTY0NsUVppSXRNT0x1Rk9mQldFajh1aHZR?=
 =?utf-8?B?azhmWm9IdmYzM3U5TTkvbHUwYjMxQm9kcDRhRG1kdjA3T0lDVkNzSHdOWktH?=
 =?utf-8?B?NHhDMFN6Y29zU0EvVW5oTGRGNFZ1R1gzNEg2by9hYi9SSVZ3MlNnUnV5UmYw?=
 =?utf-8?B?clpFazZWbFdEWW5WTVQyOUxQQW9xZ0ljcmNWZ0plUFJVWHI5aksxVVJvQ3RR?=
 =?utf-8?B?eUllTHJiOGRPeHFkVnpGcncwcVBYRjVsWEwrNnIxZVBuVWliUGg3L2p4ZTR1?=
 =?utf-8?B?aHZtcThwUmc4aGxSYStFSE1vSHV1di9OTEhQbERFa3JydUdoRExaNXJFRVRr?=
 =?utf-8?B?YThNM0grZUdJaGdaY0ZVL2tyaVRiVEJpdm8ybkJvdFYrSWMxUCtTUytoRElZ?=
 =?utf-8?B?MWxBbUs1cS9qc0lXZ25VWHMrOEpUM2d3YnYvVlljREthd1Z3VmxWZjlhNVMy?=
 =?utf-8?B?OWpTVnlUaElCc3l1QzlDcTNSQUc5UVRyQ3cxVk9lTzJHMUtwcmJhVUU0c0My?=
 =?utf-8?B?S3RzdlRMWUxTZVY5MUxUZVJoRlord1FEMTI2SlVVeTZOTnd6cFJ6ZDlKTXdo?=
 =?utf-8?B?TWlNdGVCNFdTSThkYS9XekREOUZoQVVDMWFTMG41d2JidGNoUG5RaU9MZTFN?=
 =?utf-8?B?RGR2bERMOGhIOW1hdDkvOWpybjMyVjFlWHlTYXJnUEVUZjhJSWNTWmtISDBF?=
 =?utf-8?B?a3cwb1R4UnozRmpNdktYSTNraW5IWG9XOURjdm1Lb2U4RmE0YmJTYW1Scm1L?=
 =?utf-8?B?ZUlsQTZWUyttMGIzTXVQd2VYZ2FGTEp0cjdXd1JjUktKbGJoNEF2L1Q5NDk2?=
 =?utf-8?B?clBKTndFbkNQWCtMdWptUkZxc2RILzJNQTZyTGhhSG9VNi9UMzVPZWNHZk4w?=
 =?utf-8?B?REJWZ28rK1pTSmMwSWYvVjREVmI3WnhlSVRZRU4xcGRRQW5SaXRJbzBXRXlp?=
 =?utf-8?B?Q0svZXgxdXVsOWErdi9qbS80U1YxamMxMmNjMFhBejNxSW11RjZoRldJUUxs?=
 =?utf-8?B?b0pDWGtvcE0zanZYYU9MUGxEOC95NDBaRUE2NTVodStrU0hNSitGYktPaTBo?=
 =?utf-8?B?TlltZEcrY1dtUkpBRjcrOHJreUJYRUJmZ2wwMkFHVzV4aGVsTGVuYWwxb3RN?=
 =?utf-8?B?V1daSXg2WW1tZEU2Z3JZRWxiSGJvMmNMeURpRS94MnpuUlpySWJEYy8yOG44?=
 =?utf-8?B?VGw4V2JFclhuamRCMVNKSmcwdjdtN2NkcFYrNDdlRlJJVXVFeU5yYVkxcEVJ?=
 =?utf-8?B?Wm1FN0d6bjNzc2xhZis1M2NsenBKUCtSbXV6TEM2N3E2WkhBNTV6TXlveThm?=
 =?utf-8?B?TTRQQ1pmSEt4UkVXK2lHclhZL0c0RXhIVnRSc3FNM0Y3Tk5Mendvdk05OFVS?=
 =?utf-8?B?MFk2eERjMXEyS0xCKzZ4L2JiRHI2Z09lYUlYSVFhYnl6ZHFHQ0F5ay9sTGdk?=
 =?utf-8?B?bzB1QXhyU0ZMY0w1Ym9kV05QcUdMeC9TRVVBWTN5WUdoZXorWWN2YmoyYkpG?=
 =?utf-8?B?djZISk9FZ2FmT3poengwa2x2WU9KNDNYek4zMWVIWEtKaXhLTG1MejZpSWZP?=
 =?utf-8?B?dFhnZEszUFh1ejA4QWlJQ3E3RDF5b21oOUVOYjZQOUt3V29Xekd0T0diRzEx?=
 =?utf-8?B?RGd2OVR1MENpMmdiaVpnV2dIeFlrdjRLWFl6V3dwNVdtdkVhQnRqcTVlOGJq?=
 =?utf-8?B?d2Z6SWtMREZHYm5YQXZzNEpOYS9yU2NpMXppNjNocVp4cS9mRm4xcGNNSUtR?=
 =?utf-8?B?SnBDUW5TY05naDRVLzk2UUhvSnBxMlN3bTRDTllYTmtoQTdiNTE4VnExVUtn?=
 =?utf-8?B?NlBaVWpxaVRlRFBvYzIxd3lBZXMvT051STR0d3dLMk9ROThVaW8rNlhSQnRQ?=
 =?utf-8?B?MFVtMkVWVVdMeUlZUE1yNlNDZGFKclZqUFJIenJsYlM4dVZlRkJVMGUxYytH?=
 =?utf-8?Q?vZqkToyPTBmmju6fI3heA9Nk8?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee1ba90c-460c-4a4b-57f8-08dab660c7b1
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 08:13:21.2093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ML/8cnYrM+FS02yktgHn8WepsVSJx0pDyhw1F67xztb0VkQQjV1BcpbDpOhMv0ksVDDFkAyKjgLRwXjaptM4GQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6450

On Mon, Oct 24, 2022 at 12:58:54PM -0400, Tamas K Lengyel wrote:
> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a handful
> of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by an
> external privileged tool is necessary, thus we extend the domctl to allow for
> querying for any guest MSRs. To remain compatible with the existing setup if
> no specific MSR is requested via the domctl the default list is returned.

I'm afraid I would benefit from some extra description about why you
need to introduce a separate hook instead of using the existing
do_rdmsr hook in arch_vpmu_ops (which is already hooked into
guest_rdmsr()).

Are the MSRs you are trying to fetch not accessible for the guest
itself to read?

It seems fragile to me to add such kind of hook to read MSRs that's
only used by XEN_DOMCTL_get_vcpu_msrs and not guest_rdmsr(), so it
would need some clear justification about why it's needed.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 08:20:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 08:20:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429641.680742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onFAU-000415-C6; Tue, 25 Oct 2022 08:20:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429641.680742; Tue, 25 Oct 2022 08:20:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onFAU-00040y-8i; Tue, 25 Oct 2022 08:20:14 +0000
Received: by outflank-mailman (input) for mailman id 429641;
 Tue, 25 Oct 2022 08:20:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onFAS-00040o-QI; Tue, 25 Oct 2022 08:20:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onFAS-0006jz-Ms; Tue, 25 Oct 2022 08:20:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onFAS-0002pI-BF; Tue, 25 Oct 2022 08:20:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onFAS-0001cw-9N; Tue, 25 Oct 2022 08:20:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ROQ/vPWmDXPo22Jz28dUJf+uUhBlBCfTLGSseRj/W+4=; b=jc7OO4D2X9AEBUjeOMdBZlvKSa
	YrHcDSxRMqxoSKolpr947JmoKfTrPD7PMKr617mTZ2QKaAIYsrxv1z7oIgKBuNOgdfq2jMhwLouMK
	dW6BnlZqDvidcXhcr61ghY/AI9QTZwuNp04QQ55tBfjSjLKDP9rHLxcp61twxSIwQOsk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174311-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174311: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=d47136c2801540e80f41ec7e063d8d592568ad76
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 08:20:12 +0000

flight 174311 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174311/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                d47136c2801540e80f41ec7e063d8d592568ad76
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   17 days
Failing since        173470  2022-10-08 06:21:34 Z   17 days   25 attempts
Testing same since   174311  2022-10-23 14:32:24 Z    1 days    1 attempts

------------------------------------------------------------
1373 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 129697 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 08:21:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 08:21:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429647.680753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onFBP-0004Xc-Me; Tue, 25 Oct 2022 08:21:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429647.680753; Tue, 25 Oct 2022 08:21:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onFBP-0004XV-IT; Tue, 25 Oct 2022 08:21:11 +0000
Received: by outflank-mailman (input) for mailman id 429647;
 Tue, 25 Oct 2022 08:21:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zbGC=22=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1onFBL-0004T3-B0
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 08:21:10 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f89c78b9-543d-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 10:21:06 +0200 (CEST)
Received: from AS9PR06CA0037.eurprd06.prod.outlook.com (2603:10a6:20b:463::21)
 by PA4PR08MB6093.eurprd08.prod.outlook.com (2603:10a6:102:e8::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 08:21:01 +0000
Received: from AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:463:cafe::1a) by AS9PR06CA0037.outlook.office365.com
 (2603:10a6:20b:463::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 08:21:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT024.mail.protection.outlook.com (100.127.140.238) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Tue, 25 Oct 2022 08:21:00 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Tue, 25 Oct 2022 08:21:00 +0000
Received: from 2941f3dcffc4.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2408B5F9-B3D3-4252-9444-6C704A4EA44C.1; 
 Tue, 25 Oct 2022 08:20:53 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2941f3dcffc4.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 08:20:53 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB6294.eurprd08.prod.outlook.com (2603:10a6:20b:29a::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 08:20:49 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 08:20:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f89c78b9-543d-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=E6dEfZn/+HYGBgimz9Fxo1Fq5PmKRudiNcyYO0DAxuhbtsM1e/0OHqGej4lkQYazEyRlUU0kNW8LNn99OfAStdhkY0fKsIkE4bkkh/FGA7JGPW9dsysowdJJTIXyChbwXexFJ2GzJ7cNrpB+OfX+z1zzXqHLxwKKZyre7woej6J5W2gFEU/Oq/oJmR1Mi06m8tRLh+SFlaYYQljrUmc7/dZMg6zwzqpcw4Bp+fs8lziu7+M885AjdxmAS8i4654HqZU+vz51e6bqu/GRcWEjqG+yGrjgqwH5PUrDo1mw8/81PzpJ6E9EoD6cD2XCuuwVjJR1gKdH2Pp5b6QAC0dyaQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=38omx4Mocmuhjo1i87Pr31pE5oY7c1xwekCIoTVk1x8=;
 b=E3vCAmQdP0l8Hiti+6nuZzXe7yPldanoJDRC/YFEEh8spZZyO7V6Q940BhXLya3U3zglRLUjuRhlpxrk6BlFwj+tXltm3bk5y2aVPHckuENTEhmF+/rRLjdYmCgkDJXbMPbgidALsdU1T3jPjJEyr5j19YClykAHXRczTdg82FKmLUruNdhGvkjVumAVCevwrwqjiUVFFtyzSEhFHx/E2Y3ieXaEY7syVBe7OTJO12wq8lvkS0SPBigQqbBgJ0R4snz3LndhOQGndiuMnI42WUNAlWStT496YDrrOXe3AWPbc5/Wsmwl+/AieA3DrnrujAmQLpOkw6ZRGIYEm5/SQA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=38omx4Mocmuhjo1i87Pr31pE5oY7c1xwekCIoTVk1x8=;
 b=bLBLFRCn0rHBKEK6CUUHn8qpf9YVhuKFLiuG4+WA7uM7qcEJoONXx08uS5QdMDOlwGdt7ua6R/ROrCRPvOu1qT9UFRXwiMJDWZlZlzgQq7JOOA8pAQu1554OyEVxfcOsPTszNQkmtxpsFHQhuJ0AnMMW1i61vOfpVOEvbolGKow=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: e4132f68e086deea
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B4m8g6P8HMjhWKVTGMadHP60R5I5O8iD6i+bYyvP4HIfn1PvBrCrAKD9XSPQa04kEmNTnmz8Wy0EQ56Qd7Ly+Y1XN1dEpbpstbJRSoh1/qy4Y9jWm2jzkSFRQj+rev2066DJC7hwmpsP8WHL8X/IYfnpltC1T4PaEGoqKRemh2g4eCdZ8bV0vL/vE/IAiyrCI7T5awfCJ4V8i+WNfxmVdhLbPBNxmNFTG9B1hZCZmscyQqaTOacccSBttSag/DarNBtRjOZR/2V8OwLZ0WDtWs+kxPpM9sB3deObenQdCrHW/XFBbM/N1CmO8N7t5+3cE2BOUtLwmTaEyB0BZkVfLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=38omx4Mocmuhjo1i87Pr31pE5oY7c1xwekCIoTVk1x8=;
 b=Zj0MXGGEhe4MueWYECGIwWLfiFabMGeoWRDW+/E8uOVRIz2H+iaFEQ8uGfvFlHGqFr1VcCRiqsrT3amSj23LraPPDu1RV6QlVCOUVbuokpP3MCfC2bvnM1hN0GgKNBcIXeRvQRyBR4l231TXguJkX2tLUCaOJAuPYna08Lriym1Oe8lqmhWrbvLpcFZStrc7eJMhDxi519gnXQTBb0vAyfw5rQO3ukrOh5Jq3AoMK1eldLU81pIK72WTmZUBGEzCxgbIpOBotq9XCOvHNyJrZZgh9c2Hx4jz71ej09zhHqwmezfOZjmATrcLmruAVT1KT9GK7gq/iB6GDrUVdaxCNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=38omx4Mocmuhjo1i87Pr31pE5oY7c1xwekCIoTVk1x8=;
 b=bLBLFRCn0rHBKEK6CUUHn8qpf9YVhuKFLiuG4+WA7uM7qcEJoONXx08uS5QdMDOlwGdt7ua6R/ROrCRPvOu1qT9UFRXwiMJDWZlZlzgQq7JOOA8pAQu1554OyEVxfcOsPTszNQkmtxpsFHQhuJ0AnMMW1i61vOfpVOEvbolGKow=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Deadcode discussion based on Arm NS phys timer
Thread-Topic: Deadcode discussion based on Arm NS phys timer
Thread-Index:
 AQHY54gZ+lETtnfh9UiF8D+fGFbI5q4dXjCAgAANxICAAB5kgIAAySOAgABfjwCAAAmGgIAABfAAgAADzwA=
Date: Tue, 25 Oct 2022 08:20:49 +0000
Message-ID: <7C838BB9-E8FA-4239-B851-B179CB6B7A02@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
 <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
 <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com>
In-Reply-To: <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB6294:EE_|AM7EUR03FT024:EE_|PA4PR08MB6093:EE_
X-MS-Office365-Filtering-Correlation-Id: 3eb7bf4f-be10-4f84-6510-08dab661d9ab
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 tiDYb3DBiqlDMSZG2tCCiOPoQtc7wpYGJBrfuEqctQjH4isIJd/VG2k5v5Y8zKwXZ+JN5FUUSQ+vpdf8FqxSGP2y7Dp6icrn2Uc3v6N1ncqG5GC7ixjhrFnsdp5uydHLR+9qwcENiKOIOOpnZyH7cN8GnSsfDaveZoeul0jCMQ6cvPXxTtAl6NjaPWiDH7b2Egem4E3Vpm4SAcM4NhyJyVG6H0yQnj2wVYPA3J5EDQX0GdXPA70ftMRQZDKTRLavZlGmfV7lcHUqOjuPr3zZByIy58ruh1WIqmFUyf6kvIxOlVnuoSoqr/W0CKrlyMeOhz3Vb3jiRAwYj0ipFB7wLxkmyEo0E4mP2D7KSZkFweZ5BvTYDBpOsgHRQpkdzAqCMb565nqY/Jp0uo+M52+WghHp5HGlG32sqJi4jZjCnfMD+kAXKd7H4thF7FII2SGa7lxDf7yUMW79dw7t+e6Dg3RKRSgMOPEEnk+zjtDyh8hSs48XV5e6YHcG33CxitSKm626pI2ctUl1BVgH1EAVXvH792d0tOf9ipHMy23NtYqQLAGI7yExeNWy+XuWTy4e7XdGWzBKXRK7IJW3QrGeXpjDcyltawvRabP3M7yur5YDMXSjrB597SQkhxdUielJn2heaFqmgGVldbclxGb491BpPKD4x9QepBa11mHpq39cRAUZsKFjVcV/4yGmPyZu39TVnuyQAk/V47b1ihyH5KowV3aacIOsd2+CgeFNwxY66wFBvxD9qK3/5XdGpz1fjxYBRMe0pxQ8DWrjxo2h1pr2U9zX4j7baUq1n2aJwMw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199015)(2616005)(478600001)(53546011)(6506007)(6512007)(26005)(83380400001)(186003)(2906002)(316002)(6916009)(54906003)(91956017)(8936002)(5660300002)(76116006)(71200400001)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(41300700001)(6486002)(66899015)(86362001)(36756003)(33656002)(122000001)(38100700002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <E5ECDA40BF9B7741AA05388A260C46AA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6294
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	65d166a7-af75-4d68-e711-08dab661d2e6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WWiqGrv5zecmxMnYGP396W8POaPWIfUW2KwRlo4uU5jbiOPPBafSqiFw+rYzrdGlmY16K5x4eZKLHrAt14vkSw4YtnNtBOkuZC15b5nCcNK01scMw3USAUupjn1COzz/ee24BkaYKbWEoN7TcOLBS77jaCsNN6VKpmF3wL1DakQ0kSz22pfjmr/doaTSV3pX4POw3iL+p8M3wg/0NoVemOByuAoWWK28QMNzOmW6nu5Xcgjhtz8mB5kVymLzJR4q81ObkQqJaWush3H4OsOpitSxuajpMHgTTsQl77XJLQm5DZDkkKYnXFYidl7t1iuVSn1PzBMJZ8Ayy5GbFEhjNh0vXKyX9xZ3Oh3q36s8CjHkwdjgwLU55VL1OsmeMLOdxnsYcyzYZQtuF9jOZEXO3tbGEGpP8vLSTGFpR/6olYvek9ugz/je3dQXGr/iDL6pUdbrWoXaJLxcS9MOH6U7nhd/y74Ly83rzVYubDUPGUgeNHVfFwqpslfSYl4MgENUKVDrdvpc7RMy8SacAQl8dfAzOm9lWDwoyOs104317H+Alx857HgdC7nu7sjEwTZULRKTP4N2vEbrX+v35y5sAqGT5jGwpt+sS2IZGwA2YfsjWiha37MgbNl0HRTVG/0m9ne0ZUOht122lEFfWbLefpsnKNSFdmuNrNdaSj1SMC9IwvOlvUKhfuEGVyIGUa5x6bvWPRicgoAPyqYTbM1IIvFaR4ygSEbueW3c/yOOSYjpP0wqhOoDT+KLK6rmEjWerv76tMdmBjCB6kJUcH4q4Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(6486002)(478600001)(33656002)(4326008)(6862004)(8936002)(41300700001)(8676002)(2906002)(5660300002)(54906003)(40480700001)(316002)(70586007)(36756003)(70206006)(81166007)(356005)(83380400001)(82740400003)(36860700001)(26005)(53546011)(6506007)(86362001)(47076005)(2616005)(336012)(6512007)(186003)(40460700003)(66899015)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 08:21:00.5692
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb7bf4f-be10-4f84-6510-08dab661d9ab
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT024.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6093

SGkgTWljaGFsLA0KDQo+IE9uIDI1IE9jdCAyMDIyLCBhdCAwOTowNywgTWljaGFsIE9yemVsIDxt
aWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBCZXJ0cmFuZCwNCj4gDQo+IE9u
IDI1LzEwLzIwMjIgMDk6NDUsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiANCj4+IA0KPj4g
SGkgTWljaGFsLA0KPj4gDQo+Pj4gT24gMjUgT2N0IDIwMjIsIGF0IDA4OjExLCBNaWNoYWwgT3J6
ZWwgPG1pY2hhbC5vcnplbEBhbWQuY29tPiB3cm90ZToNCj4+PiANCj4+PiBIaSwNCj4+PiANCj4+
PiBPbiAyNS8xMC8yMDIyIDAzOjI5LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+Pj4+IA0K
Pj4+PiANCj4+Pj4gT24gTW9uLCAyNCBPY3QgMjAyMiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+
Pj4+IE9uIDI0LzEwLzIwMjIgMTI6NTEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+Pj4gQ2F1
dGlvbjogVGhpcyBtZXNzYWdlIG9yaWdpbmF0ZWQgZnJvbSBhbiBFeHRlcm5hbCBTb3VyY2UuIFVz
ZSBwcm9wZXINCj4+Pj4+Pj4gY2F1dGlvbiB3aGVuIG9wZW5pbmcgYXR0YWNobWVudHMsIGNsaWNr
aW5nIGxpbmtzLCBvciByZXNwb25kaW5nLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gDQo+Pj4+Pj4+IE9u
IDI0LzEwLzIwMjIgMTA6MDcsIE1pY2hhbCBPcnplbCB3cm90ZToNCj4+Pj4+Pj4+IEhlbGxvLA0K
Pj4+Pj4+PiANCj4+Pj4+Pj4gSGkgTWljaGFsLA0KPj4+Pj4+PiANCj4+Pj4+Pj4+IFJlY2VudGx5
IEkgY2FtZSBhY3Jvc3MgYSBkZWFkY29kZSBpbiBYZW4gQXJtIGFyY2ggdGltZXIgY29kZS4gQnJp
ZWZseQ0KPj4+Pj4+Pj4gc3BlYWtpbmcsIHdlIGFyZSByb3V0aW5nDQo+Pj4+Pj4+PiB0aGUgTlMg
cGh5cyB0aW1lciAoQ05UUCkgSVJRIHRvIFhlbiwgZXZlbiB0aG91Z2ggWGVuIGRvZXMgbm90IG1h
a2UgdXNlDQo+Pj4+Pj4+PiBvZiBpdCAoYXMgaXQgdXNlcyB0aGUgaHlwZXJ2aXNvciB0aW1lciBD
TlRIUCkuDQo+Pj4+Pj4+PiBUaGlzIHRpbWVyIGlzIGZ1bGx5IGVtdWxhdGVkLCB3aGljaCBtZWFu
cyB0aGF0IHRoZXJlIGlzIG5vdGhpbmcgdGhhdCBjYW4NCj4+Pj4+Pj4+IHRyaWdnZXIgc3VjaCBJ
UlEuIFRoaXMgY29kZSBpcw0KPj4+Pj4+Pj4gYSBsZWZ0IG92ZXIgZnJvbSBlYXJseSBkYXlzLCB3
aGVyZSB0aGUgQ05USFAgd2FzIGJ1Z2d5IG9uIHNvbWUgbW9kZWxzDQo+Pj4+Pj4+PiBhbmQgd2Ug
aGFkIHRvIHVzZSB0aGUgQ05UUCBpbnN0ZWFkLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBBcyBmYXIg
YXMgdGhlIHByb2JsZW0gaXRzZWxmIGlzIG5vdCByZWFsbHkgaW50ZXJlc3RpbmcsIGl0IHJhaXNl
cyBhDQo+Pj4+Pj4+PiBxdWVzdGlvbiBvZiB3aGF0IHRvIGRvIHdpdGggYSBkZWFkY29kZSwNCj4+
Pj4+Pj4+IGFzIHRoZXJlIG1pZ2h0IGJlL2FyZSBvdGhlciBkZWFkY29kZSBwbGFjZXMgaW4gWGVu
Lg0KPj4+Pj4+PiANCj4+Pj4+Pj4gVGhlcmUgYXJlIG11bHRpcGxlIGRlZmluaXRpb24gb2YgZGVh
ZGNvZGUuIERlcGVuZGluZyBvbiB3aGljaCBvbmUgeW91DQo+Pj4+Pj4+IGNob3NlLCB0aGVuIHRo
aXMgY291bGQgY292ZXIgSVNfRU5BQkxFRCgpIGFuZCBwb3NzaWJseSAjaWZkZWYuIFNvIHRoaXMN
Cj4+Pj4+Pj4gd291bGQgcmVzdWx0IHRvIGEgbG90IG9mIHBsYWNlcyBpbXBhY3RlZCB3aXRoIHRo
ZSBkZWNpc2lvbi4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IFNvIGNhbiB5b3UgY2xhcmlmeSB3aGF0IHlv
dSBtZWFuIGJ5IGRlYWRjb2RlPw0KPj4+Pj4+IEluIHRoZSB0aW1lciBleGFtcGxlLCBJIHRoaW5r
IHdlIGhhdmUgYm90aCBhIGRlYWRjb2RlIGFuZCB1bnJlYWNoYWJsZSBjb2RlLg0KPj4+Pj4+IEZv
ciB0aGUgcHVycG9zZSBvZiB0aGlzIGRpc2N1c3Npb24sIGxldCdzIHRha2UgdGhlIE1JU1JBIGRl
ZmluaXRpb24gb2YgYQ0KPj4+Pj4+IGRlYWRjb2RlIHdoaWNoIGlzIGEgImNvZGUgdGhhdCBjYW4g
YmUgZXhlY3V0ZWQNCj4+Pj4+PiBidXQgaGFzIG5vIGVmZmVjdCBvbiB0aGUgZnVuY3Rpb25hbCBi
ZWhhdmlvciBvZiB0aGUgcHJvZ3JhbSIuIFRoaXMgZGlmZmVycw0KPj4+Pj4+IGZyb20gdGhlIHVu
cmVhY2hhYmxlIGNvZGUgZGVmaW5pdGlvbiB0aGF0IGlzDQo+Pj4+Pj4gYSAiY29kZSB0aGF0IGNh
bm5vdCBiZSBleGVjdXRlZCIuIFNldHRpbmcgdXAgdGhlIElSUSBmb3IgWGVuIGlzIGFuIGV4YW1w
bGUNCj4+Pj4+PiBvZiBhIGRlYWRjb2RlLiBDb2RlIHdpdGhpbiBJUlEgaGFuZGxlciBpcyBhbiB1
bnJlYWNoYWJsZSBjb2RlDQo+Pj4+Pj4gKHRoZXJlIGlzIG5vdGhpbmcgdGhhdCBjYW4gdHJpZ2dl
ciB0aGlzIElSUSkuDQo+Pj4+Pj4gDQo+Pj4+Pj4gV2hhdCBJIG1lYW4gYnkgZGVhZGNvZGUgaGFw
cGVucyB0byBiZSB0aGUgc3VtIG9mIHRoZSB0d28gY2FzZXMgYWJvdmUgaS5lLg0KPj4+Pj4+IHRo
ZSBjb2RlIHRoYXQgY2Fubm90IGJlIGV4ZWN1dGVkIGFzIHdlbGwgYXMgdGhlIGNvZGUgdGhhdA0K
Pj4+Pj4+IGRvZXMgbm90IGltcGFjdCB0aGUgZnVuY3Rpb25hbGl0eSBvZiB0aGUgcHJvZ3JhbS4N
Cj4+Pj4+PiANCj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBPbmUgbWF5IHNheSB0aGF0IGl0IGlzIHVzZWZ1
bCB0byBrZWVwIGl0LCBiZWNhdXNlIG9uZSBkYXksDQo+Pj4+Pj4+PiBzb21lb25lIG1pZ2h0IG5l
ZWQgaXQgd2hlbiBkZWFsaW5nIHdpdGggeWV0IGFub3RoZXIgYnJva2VuIEhXLiBTdWNoDQo+Pj4+
Pj4+PiBwZXJzb24gd291bGQgc3RpbGwgbmVlZCB0byBtb2RpZnkgdGhlIG90aGVyDQo+Pj4+Pj4+
PiBwYXJ0IG9mIHRoZSBjb2RlIChlLmcuIHJlcHJvZ3JhbV90aW1lciksIGJ1dCB0aGVyZSB3b3Vs
ZCBiZSBsZXNzIHdvcmsNCj4+Pj4+Pj4+IHJlcXVpcmVkIG92ZXJhbGwuIFBlcnNvbmFsbHksIEkn
bSBub3QgaW4gZmF2b3Igb2YNCj4+Pj4+Pj4+IHN1Y2ggYXBwcm9hY2gsIGJlY2F1c2Ugd2Ugc2hv
dWxkIG5vdCByZWFsbHkgc3VwcG9ydCBwb3NzaWJsZSBzY2VuYXJpb3MNCj4+Pj4+Pj4+IHdpdGgg
YnJva2VuIEhXIChleGNlcHQgZm9yIGVycmF0YXMgbGlzdGluZyBrbm93biBpc3N1ZXMpLg0KPj4+
Pj4+PiANCj4+Pj4+Pj4gVGhlIGRpZmZlcmVuY2UgYmV0d2VlbiAiYnJva2VuIEhXIiBhbmQgIkhX
IHdpdGgga25vd24gZXJyYXRhIiBpcyBhIGJpdA0KPj4+Pj4+PiB1bmNsZWFyIHRvIG1lLiBDYW4g
eW91IGNsYXJpZnkgaG93IHlvdSB3b3VsZCBtYWtlIHRoZSBkaWZmZXJlbmNlIGhlcmU/DQo+Pj4+
Pj4+IA0KPj4+Pj4+PiBJbiBwYXJ0aWN1bGFyLCBhdCB3aGljaCBwb2ludCBkbyB5b3UgY29uc2lk
ZXIgdGhhdCB0aGUgSFcgc2hvdWxkIG5vdCBiZQ0KPj4+Pj4+PiBzdXBwb3J0ZWQgYnkgWGVuPw0K
Pj4+Pj4+IEknbSBub3Qgc2F5aW5nIHRoYXQgSFcgc2hvdWxkIG5vdCBiZSBzdXBwb3J0ZWQuIFRo
ZSBkaWZmZXJlbmNlIGZvciBtZQ0KPj4+Pj4+IGJldHdlZW4gYnJva2VuIEhXIGFuZA0KPj4+Pj4+
IEhXIHdpdGgga25vd24gZXJyYXRhIGlzIHRoYXQgZm9yIHRoZSBmb3JtZXIsIHRoZSBpbmNvcnJl
Y3QgYmVoYXZpb3IgaXMgb2Z0ZW4NCj4+Pj4+PiBkdWUgdG8gdGhlIGVhcmx5IHN1cHBvcnQgc3Rh
Z2UsDQo+Pj4+Pj4gdXNpbmcgZW11bGF0b3JzL21vZGVscyBpbnN0ZWFkIG9mIHJlYWwgSFcsIHdo
ZXJlYXMgZm9yIHRoZSBsYXR0ZXIsIHRoZSBIVyBpcw0KPj4+Pj4+IGFscmVhZHkgcmVsZWFzZWQg
YW5kIGl0IGhhcHBlbnMgdG8gYmUgdGhhdCBpdCBpcyBidWdneQ0KPj4+Pj4+ICh0aGUgSFcgdmVu
ZG9yIGlzIGF3YXJlIG9mIHRoZSBpc3N1ZSBhbmQgcmVsZWFzZWQgZXJyYXRhcykuDQo+Pj4+PiAN
Cj4+Pj4+IFRoYW5rcyBmb3IgdGhlIGNsYXJpZmljYXRpb24uIFdoYXQgSSB3b3VsZCBjYWxsIGJy
b2tlbiBpcyBhbnl0aGluZyB0aGF0IGNhbid0DQo+Pj4+PiBiZSBmaXhlZCBpbiBzb2Z0d2FyZS4g
Rm9yIGEgbm90IHRvbyBmaWN0aW9uYWwgZXhhbXBsZSwgYW4gSFcgd2hlcmUgUENJIGRldmljZXMN
Cj4+Pj4+IGFyZSB1c2luZyB0aGUgc2FtZSBzdHJlYW0gSUQuIFNvIGVmZmVjdGl2ZWx5LCBwYXNz
dGhyb3VnaCBjYW4ndCBiZSBzYWZlbHkNCj4+Pj4+IHN1cHBvcnRlZC4NCj4+Pj4+IA0KPj4+Pj4g
UmVnYXJkaW5nLCBub3QgeWV0IHJlbGVhc2VkIEhXLCBJIGRvbid0IHRoaW5rIFhlbiBzaG91bGQg
aGF2ZSB3b3JrYXJvdW5kIGZvcg0KPj4+Pj4gdGhlbS4gSSB3b3VsZG4ndCBldmVuIGNhbGwgaXQg
ImJyb2tlbiIgYmVjYXVzZSB0aGV5IGFyZSBub3QgeWV0IHJlbGVhc2VkIGFuZA0KPj4+Pj4gaXQg
aXMgY29tbW9uIHRvIGhhdmUgYnVnIGluIGVhcmx5IHJldmlzaW9uLg0KPj4+Pj4gDQo+Pj4+Pj4g
RG8gd2UgaGF2ZSBhbnkgZXhhbXBsZSBpbiBYZW4gZm9yIHN1cHBvcnRpbmcgYnJva2VuIEhXLA0K
Pj4+Pj4+IHdob3NlIHZlbmRvciBpcyBub3QgYXdhcmUgb2YgdGhlIGlzc3VlIG9yIGRpZCBub3Qg
cmVsZWFzZSBhbnkgZXJyYXRhPw0KPj4+Pj4gSSB3aWxsIG5vdCBjaXRlIGFueSBIVyBvbiB0aGUg
TUwuIEJ1dCBmcm9tIG15IGV4cGVyaWVuY2UsIHRoZSB2ZW5kb3JzIGFyZSBub3QNCj4+Pj4+IHZl
cnkgdm9jYWwgYWJvdXQgaXNzdWVzIGluIHB1YmxpYyAoc29tZSBkb24ndCBldmVuIHNlZW0gdG8g
aGF2ZSBwdWJsaWMgZG9jKS4NCj4+Pj4+IFRoZSBiZXN0IHdheSB0byBmaW5kIHRoZSBpc3N1ZXMg
aXMgdG8gbG9vayBhdCBMaW51eCBjb21taXQuDQo+Pj4+PiANCj4+Pj4+PiANCj4+Pj4+Pj4gDQo+
Pj4+Pj4+PiBBbHNvLCBhcyBwYXJ0IG9mIHRoZSBjZXJ0aWZpY2F0aW9uL0ZVU0EgcHJvY2Vzcywg
dGhlcmUgc2hvdWxkIGJlIG5vDQo+Pj4+Pj4+PiBkZWFkY29kZSBhbmQgd2Ugc2hvdWxkIGhhdmUg
ZXhwbGFuYXRpb24gZm9yIGV2ZXJ5IGJsb2NrIG9mIGNvZGUuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBT
ZWUgYWJvdmUuIFdoYXQgYXJlIHlvdSB0cnlpbmcgdG8gY292ZXIgYnkgZGVhZGNvZGU/IFdvdWxk
IHByb3RlY3RpbmcNCj4+Pj4+Pj4gY29kZSB3aXRoIElTX0VOQUJMRUQoKSAob3IgI2lmZGVmKSBv
az8NCj4+Pj4+PiBJIHRoaW5rIHRoaXMgd291bGQgYmUgb2sgZnJvbSB0aGUgY2VydGlmaWNhdGlv
biBwb2ludCBvZiB2aWV3ICh0aGlzIHdvdWxkIGF0DQo+Pj4+Pj4gbGVhc3QgbWVhbnMsIHRoYXQg
d2UgYXJlIGF3YXJlIG9mIHRoZSBpc3N1ZQ0KPj4+Pj4+IGFuZCB3ZSB0b29rIHNvbWUgc3RlcHMp
LiBPdGhlcndpc2UsIHN1Y2ggY29kZSBpcyBqdXN0IGFuIGV4YW1wbGUgb2YgYQ0KPj4+Pj4+IGRl
YWRjb2RlL3VucmVhY2hhYmxlIGNvZGUuDQo+Pj4+PiANCj4+Pj4+IFRoYW5rcyBmb3IgdGhlIGNs
YXJpZmljYXRpb24uIFNvIHRoZSBleGFjdCBhcHByb2FjaCB3aWxsIGRlcGVuZCBvbiB0aGUNCj4+
Pj4+IGNvbnRleHQuLi4uDQo+Pj4+PiANCj4+Pj4+Pj4+IFRoZXJlIGFyZSBkaWZmZXJlbnQgd2F5
cyB0byBkZWFsIHdpdGggYSBkZWFkY29kZTogPiAxLiBHZXQgcmlkIG9mIGl0DQo+Pj4+Pj4+PiBj
b21wbGV0ZWx5DQo+Pj4+Pj4+PiAyLiBMZWF2ZSBpdCBhcyBpdCBpcw0KPj4+Pj4gDQo+Pj4+PiAu
Li4gdGhpcyBpcyBteSBwcmVmZXJlbmNlIGluIHRoZSBjb250ZXh0IG9mIHRoZSB0aW1lci4NCj4+
Pj4gDQo+Pj4+IEZyb20gYSBjZXJ0aWZpY2F0aW9uIHBvaW50IG9mIHZpZXcsIHRoZSBmZXdlciBs
aW5lcyBvZiBjb2RlIHRoZSBiZXR0ZXIsDQo+Pj4+IGFuZCBpZGVhbGx5IGFsbCB0aGUgbGluZXMg
b2YgY29kZSB1c2VkIGZvciB0aGUgY2VydGlmaWVkIGJ1aWxkIHNob3VsZCBiZQ0KPj4+PiB0ZXN0
YWJsZSBhbmQgdXNlZC4NCj4+Pj4gDQo+Pj4+IFNvIEkgdGhpbmsgMi4gaXMgdGhlIGxlc3QgdXNl
ZnVsIG9wdGlvbiBmcm9tIGEgY2VydGlmaWNhdGlvbg0KPj4+PiBwZXJzcGVjdGl2ZS4gRm9yIHRo
aXMgcmVhc29uLCBJJ2QgcHJlZmVyIGFub3RoZXIgYWx0ZXJuYXRpdmUuDQo+Pj4+IA0KPj4+PiAN
Cj4+Pj4+IElmIHRoZSBvdGhlciBkb24ndCBsaWtlIGl0LCB0aGVuIDEgd291bGQgYmUgbXkgcHJl
ZmVyZW5jZS4NCj4+Pj4+IA0KPj4+Pj4gSW4gZ2VuZXJhbCwgbXkgcHJlZmVyZW5jZSB3b3VsZCBi
ZSBlaXRoZXIgMy4zIG9yIDMuMiAoc2VlIGJlbG93KS4NCj4+Pj4gDQo+Pj4+IEkgYWxzbyB0aGlu
ayB0aGF0IDMuMiBhbmQgMy4zIGFyZSBnb29kIG9wdGlvbnMgZm9yIHRoZSBnZW5lcmFsIGNhc2Uu
IEZvcg0KPj4+PiB0aGUgdGltZXIsIEkgY2FuIHNlZSB3aHkgMSBpcyB5b3VyIChzZWNvbmQpIHBy
ZWZlcmVuY2UgYW5kIEkgYW0gZmluZQ0KPj4+PiB3aXRoIDEgYXMgd2VsbC4NCj4+PiBPaywgc291
bmRzIGdvb2QgdG8gbWUuIExldCdzIHN0aWxsIGdpdmUgQmVydHJhbmQgdGhlIGNoYW5jZSB0byBz
aGFyZSBoaXMgb3Bpbmlvbi4NCj4+IA0KPj4gV2UgbmVlZCB0byBnZXQgcmlkIG9mIGRlYWQgY29k
ZSBhbmQgcmVtb3ZpbmcgaXQgaXMgbm90IGFsd2F5cyB0aGUgYmVzdCBzb2x1dGlvbi4NCj4+IA0K
Pj4gSWYgdGhlIGNvZGUgaXMgb3IgY291bGQgYmUgdXNlZnVsIGZvciBzb21lb25lIHNvbWUgZGF5
LCBwcm90ZWN0aW5nIGl0IHdpdGggaWZkZWYgaXMgb2suDQo+PiANCj4+IEluIHRoZSBtaWQgdGVy
bSB3ZSB3aWxsIGhhdmUgdG8gaW50cm9kdWNlIGEgbG90IG1vcmUgaWZkZWYgb3IgSVNfRU5BQkxF
RCBpbiB0aGUNCj4+IGNvZGUgc28gdGhhdCB3ZSBjYW4gY29tcGlsZSBvdXQgd2hhdCB3ZSBkbyBu
b3QgbmVlZCBhbmQgY29kZSBub3QgYXBwbHlpbmcgdG8NCj4+IHNvbWUgaGFyZHdhcmUgaXMgYSBj
YXNlIHdoZXJlIHdlIHdpbGwgZG8gdGhhdCAoZG9lcyBub3QgbWVhbiB0aGF0IGJ5IGRlZmF1bHQN
Cj4+IHdlIHdpbGwgbm90IGNvbXBpbGUgaXQgaW4gYnV0IHdlIHdpbGwgbWFrZSBpdCBlYXNpZXIg
dG8gcmVkdWNlIHRoZSBjb2RlIHNpemUgZm9yIGENCj4+IHNwZWNpZmljIHVzZSBjYXNlKS4NCj4+
IA0KPj4gU28gMy4yIGFuZCAzLjMgYXJlIG9rIGZvciBtZS4NCj4gDQo+IFNvIHdlIGFsbCBhZ3Jl
ZSB0aGF0IHRoZSBjb2RlIGluIHRoZSBjdXJyZW50IGZvcm0gaXMgYSBubyBnbyBmcm9tIGNlcnRp
ZmljYXRpb24gcHVycG9zZXMuDQo+IFRoYXQgaXMgZ29vZCA6KQ0KPiANCj4gVGhlIHJlYXNvbiB3
aHkgSSBvcHQgZm9yIHNvbHV0aW9uIDEgYW5kIG5vdCB0aGUgb3RoZXJzIGlzIHRoYXQgaW4gdGhl
IGxhdHRlciBjYXNlIGl0IHdvdWxkDQo+IG1lYW4gaW50cm9kdWNpbmcgdGhlIEtjb25maWcgb3B0
aW9uIHRvIGFsbG93IHVzZXIgdG8gc2VsZWN0IHRoZSB0aW1lciB0byBiZSB1c2VkIGJ5IFhlbi4N
Cj4gVGhpcyBpcyBub3QgcmVhbGx5IGNvcnJlY3QuIEFsc28gaW4gdGhlIGN1cnJlbnQgZm9ybSwg
aXQgd291bGQgYWxzbyByZXF1aXJlIGFkZGluZyBtb3JlDQo+IGNvZGUgdG8gdGltZS5jIGNvZGUg
YmVjYXVzZSBhdCB0aGUgbW9tZW50IHVzaW5nIENOVFAgZm9yIFhlbiB3b3VsZCBub3Qgd29yayBv
dXQgb2YgdGhlIGJveC4NCj4gVGhlIGFyY2hpdGVjdHVyZSBkZWZpbmVzIHRoZSBoeXBlcnZpc29y
IHRpbWVyIGZvciBhIHB1cnBvc2UuIElmIGl0IGRvZXMgbm90IHdvcmssIGl0IG1lYW5zDQo+IHRo
YXQgdGhlIEhXIGlzIHByb2JsZW1hdGljLiBJIGFncmVlIHRoYXQgd2Ugd291bGQgd2FudCB0byBz
dXBwb3J0IHN1Y2ggdXNlIGNhc2UgYnV0IEknbSBub3QNCj4gcmVhbGx5IGF3YXJlIG9mIGFueSBp
c3N1ZSBsaWtlIHRoYXQuIEFkZGluZyBtb3JlIGNvZGUgYW5kIEtjb25maWcgb3B0aW9ucyBqdXN0
IGJlY2F1c2UNCj4gb25lIGRheSBzb21lb25lIG1heSBmYWNlIGlzc3VlcyB3aXRoIGEgbmV3IEhX
IGlzIHNvbWV0aGluZyBJIGFtIG5vdCBhIGZhbiBvZi4NCg0KSSBzZWUgMiBzb2x1dGlvbnMgaGVy
ZToNCi0gc29tZWhvdyBwdXNoIHRoZSBjb2RlIHRvIGEgZGlmZmVyZW50IGZpbGUgKG5vdCBxdWl0
ZSBzdXJlIHRoaXMgaXMgZmVhc2libGUgaGVyZSkNCi0gcmVtb3ZlIGNvbXBsZXRlbHkgdGhlIGNv
ZGUgd2l0aCBhIGNsZWFuIGNvbW1pdC4gRG9pbmcgdGhpcyBpdCB3aWxsIGJlIGVhc3kgZm9yIHNv
bWVvbmUgbmVlZGluZyB0aGlzIHRvIGxhdGVyIHJldmVydCB0aGUgcGF0Y2gNCg0KSXQgaXMgZGVm
aW5pdGVseSB0cnVlIGhlcmUgdGhhdCBhZGRpbmcgbW9yZSBjb2RlIHRvIGtlZXAgc29tZSB1bnVz
ZWQgY29kZSBkb2VzIG5vdCByZWFsbHkgbWFrZSBzZW5zZS4NCkFuZCBsZXTigJlzIGJlIHJlYWxp
c3RpYyBoZXJlLCBpZiB3ZSBuZWVkIHRoYXQgb25lIGRheSwgaXQgd2lsbCBub3QgdGFrZSBhZ2Vz
IHRvIHN1cHBvcnQgaXQgc29tZWhvdy4NCg0KQXMgc2FpZCwgZnJvbSBhIHB1cmUgY2VydGlmaWNh
dGlvbiBwb2ludCBvZiB2aWV3Og0KLSB3ZSBtdXN0IG5vdCBoYXZlIGRlYWRjb2RlDQotIHByb3Bl
ciBpZmRlZiBpcyBhY2NlcHRhYmxlDQotIGlmIDAgaXMgbm90IGFjY2VwdGFibGUNCi0gY29tbWVu
dGVkIGNvZGUgaXMgbm90IGFjY2VwdGFibGUNCg0KPiANCj4gSSB3b3VsZCBhZ3JlZSB3aXRoIHlv
dXIgc29sdXRpb24gdW5kZXIgdGhlIGNvbmRpdGlvbiB0aGF0IHRoZSBjb2RlIGlzIGFscmVhZHkg
cmVhZHkNCj4gZm9yIHRoZSB0aW1lciBzd2l0Y2guDQo+IA0KPiBJIGd1ZXNzIHdlIG5lZWQgYW5v
dGhlciByb3VuZCBvZiBzaGFyaW5nIG9waW5pb25zLg0KPiANCg0KSSBndWVzcyBzbyB5ZXMNCg0K
Q2hlZXJzDQpCZXJ0cmFuZA0KDQoNCj4+IA0KPj4+IA0KPj4+PiANCj4+Pj4gDQo+Pj4+Pj4+PiAz
LiBBZG1pdCB0aGF0IGl0IGNhbiBiZSB1c2VmdWwgb25lIGRheSBhbmQ6DQo+Pj4+Pj4+PiAgIDMu
MS4gcHJvdGVjdCBpdCB3aXRoICNpZiAwDQo+Pj4+PiANCj4+Pj4+ICNpZiAwIHNob3VsZCBub3Qg
YmUgdXNlZCBpbiBYZW4gY29kZS4gSU1ITyB0aGlzIGlzIHRoZSB3b3JzZSBvZiBhbGwgdGhlIHdv
cmxkLg0KPj4+IEkgc2hhcmUgeW91ciBvcGluaW9uIGhlcmUgSnVsaWVuLiBVbmZvcnR1bmF0ZWx5
IHdlIHN0aWxsIGhhdmUgcXVpdGUgYSBmZXcgZXhhbXBsZXMNCj4+PiBpbiB0aGUgQXJtIGNvZGUg
dXNpbmcgdGhpcyBlaXRoZXIgdG8gbWFyayBzb21ldGhpbmcgYXMgVE9ETyBvciB0byBjb21tZW50
IG91dA0KPj4+IHBhcnRzIG9mIHRoZSBjb2RlIHdhaXRpbmcgZm9yIGZ1dHVyZSBzdXBwb3J0LiBU
aGlzIGlzIG1vc3RseSBpbiBTTU1VIGNvZGUgdGhhdA0KPj4+IHdhcyB0YWtlbiBmcm9tIExpbnV4
IGJ1dCBhbHJlYWR5IGRpdmVyZ2VkIHF1aXRlIGZhciAobWF5YmUgc29tZSBjbGVhbnVwIGlzIG5l
Y2Vzc2FyeSkuDQo+PiANCj4+IERlZmluaXRlbHkgdGhlIFNNTVUgY29kZSB3aWxsIG5lZWQgc29t
ZSBjbGVhbmluZy4NCj4+ICNpZiAwIGFyZSBhIG5vIGdvIGZyb20gYSBjZXJ0aWZpY2F0aW9uIHBv
aW50IG9mIHZpZXcuDQo+PiANCj4+IENoZWVycw0KPj4gQmVydHJhbmQNCj4+IA0KPj4+IA0KPj4+
Pj4gDQo+Pj4+Pj4+PiAgIDMuMi4gcHJvdGVjdCBpdCB3aXRoIGEgbmV3IEtjb25maWcgb3B0aW9u
IChkaXNhYmxlZCBieSBkZWZhdWx0KQ0KPj4+Pj4+Pj4gdXNpbmcgI2lmZGVmDQo+Pj4+Pj4+PiAg
IDMuMy4gcHJvdGVjdCBpdCB3aXRoIGEgbmV3IEtjb25maWcgb3B0aW9uIChkaXNhYmxlZCBieSBk
ZWZhdWx0KQ0KPj4+Pj4+Pj4gdXNpbmcgSVNfRU5BQkxFRCAodG8gbWFrZSBzdXJlIGNvZGUgYWx3
YXlzIGNvbXBpbGUpDQo+Pj4+PiANCj4+Pj4+IEkgd291bGQgcHJlZmVyIDMuMyBvdmVyIDMuMi4g
My4yIHdvdWxkIGJlIHVzZWQgaWYgaXQgaXMgdG9vIGRpZmZpY3VsdCB0byBnZXQNCj4+Pj4+IHRo
ZSBjb2RlIGNvbXBpbGVkIHdoZW4gIUlTX0VOQUJMRUQuDQo+Pj4+PiANCj4+Pj4+IFNpbWlsYXIg
dG8gb25lIGlmIHRoaXMgaXMgdG8gbW92ZSBhbGwgdGhlIGFmZmVjdGVkIGNvZGUgaW4gYSBzZXBh
cmF0ZSBmaWxlDQo+Pj4+PiB3aXRoIHVzaW5nIG9iai0kKENPTkZJRy4uLikuIFRoYXQgd291bGQg
b25seSB3b3JrIGZvciBsYXJnZSBjaHVuayBvZiBjb2RlIGFuZA0KPj4+Pj4gd291bGQgYmUgcHJl
ZmVycmVkIG92ZXIgMy4yLg0KPj4+PiANCj4+PiANCj4+PiB+TWljaGFsDQo+PiANCj4gDQo+IH5N
aWNoYWwNCg0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:20:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429666.680784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG6E-0002B6-90; Tue, 25 Oct 2022 09:19:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429666.680784; Tue, 25 Oct 2022 09:19:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG6E-0002Az-6P; Tue, 25 Oct 2022 09:19:54 +0000
Received: by outflank-mailman (input) for mailman id 429666;
 Tue, 25 Oct 2022 09:19:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onG6C-0002At-SR
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:19:52 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 2d678e57-5446-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 11:19:51 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 58C9CD6E;
 Tue, 25 Oct 2022 02:19:56 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 00C493F792;
 Tue, 25 Oct 2022 02:19:47 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d678e57-5446-11ed-91b5-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.13 0/2] Backports for XSA-409 fixes
Date: Tue, 25 Oct 2022 09:19:35 +0000
Message-Id: <20221025091937.44961-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

This series is a backported series for XSA-409 fixes from master for
4.13, which cherry-picking commits:
3783e583319f arm/p2m: Rework p2m_init()
c7cff1188802 xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

Andrew Cooper (1):
  arm/p2m: Rework p2m_init()

Henry Wang (1):
  xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

 xen/arch/arm/domain.c     |  2 +-
 xen/arch/arm/p2m.c        | 58 +++++++++++++++++++++++++++++----------
 xen/include/asm-arm/p2m.h | 14 +++++++---
 3 files changed, 55 insertions(+), 19 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:20:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429667.680796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG6L-0002T7-Gn; Tue, 25 Oct 2022 09:20:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429667.680796; Tue, 25 Oct 2022 09:20:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG6L-0002Sc-DZ; Tue, 25 Oct 2022 09:20:01 +0000
Received: by outflank-mailman (input) for mailman id 429667;
 Tue, 25 Oct 2022 09:20:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onG6K-0002At-9O
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:20:00 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 329bda7e-5446-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 11:19:59 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDFD3ED1;
 Tue, 25 Oct 2022 02:20:04 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A08D53F792;
 Tue, 25 Oct 2022 02:19:56 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 329bda7e-5446-11ed-91b5-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.13 1/2] arm/p2m: Rework p2m_init()
Date: Tue, 25 Oct 2022 09:19:36 +0000
Message-Id: <20221025091937.44961-2-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221025091937.44961-1-Henry.Wang@arm.com>
References: <20221025091937.44961-1-Henry.Wang@arm.com>

From: Andrew Cooper <andrew.cooper3@citrix.com>

p2m_init() is mostly trivial initialisation, but has two fallible operations
which are on either side of the backpointer trigger for teardown to take
actions.

p2m_free_vmid() is idempotent with a failed p2m_alloc_vmid(), so rearrange
p2m_init() to perform all trivial setup, then set the backpointer, then
perform all fallible setup.

This will simplify a future bugfix which needs to add a third fallible
operation.

No practical change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
(cherry picked from commit: 3783e583319fa1ce75e414d851f0fde191a14753)
---
 xen/arch/arm/p2m.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 3196690544..fa6d0a83e9 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1698,7 +1698,7 @@ void p2m_final_teardown(struct domain *d)
 int p2m_init(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
-    int rc = 0;
+    int rc;
     unsigned int cpu;
 
     rwlock_init(&p2m->lock);
@@ -1707,11 +1707,6 @@ int p2m_init(struct domain *d)
     INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist);
 
     p2m->vmid = INVALID_VMID;
-
-    rc = p2m_alloc_vmid(d);
-    if ( rc != 0 )
-        return rc;
-
     p2m->max_mapped_gfn = _gfn(0);
     p2m->lowest_mapped_gfn = _gfn(ULONG_MAX);
 
@@ -1727,8 +1722,6 @@ int p2m_init(struct domain *d)
     p2m->clean_pte = is_iommu_enabled(d) &&
         !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK);
 
-    rc = p2m_alloc_table(d);
-
     /*
      * Make sure that the type chosen to is able to store the an vCPU ID
      * between 0 and the maximum of virtual CPUS supported as long as
@@ -1741,13 +1734,20 @@ int p2m_init(struct domain *d)
        p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID;
 
     /*
-     * Besides getting a domain when we only have the p2m in hand,
-     * the back pointer to domain is also used in p2m_teardown()
-     * as an end-of-initialization indicator.
+     * "Trivial" initialisation is now complete.  Set the backpointer so
+     * p2m_teardown() and friends know to do something.
      */
     p2m->domain = d;
 
-    return rc;
+    rc = p2m_alloc_vmid(d);
+    if ( rc )
+        return rc;
+
+    rc = p2m_alloc_table(d);
+    if ( rc )
+        return rc;
+
+    return 0;
 }
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:20:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:20:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429668.680807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG6Q-0003Nh-Ps; Tue, 25 Oct 2022 09:20:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429668.680807; Tue, 25 Oct 2022 09:20:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG6Q-0003Mz-MV; Tue, 25 Oct 2022 09:20:06 +0000
Received: by outflank-mailman (input) for mailman id 429668;
 Tue, 25 Oct 2022 09:20:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onG6P-0002yZ-92
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:20:05 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 32f0f52e-5446-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 11:20:00 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 293ECD6E;
 Tue, 25 Oct 2022 02:20:08 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D00513F792;
 Tue, 25 Oct 2022 02:19:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32f0f52e-5446-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.13 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()
Date: Tue, 25 Oct 2022 09:19:37 +0000
Message-Id: <20221025091937.44961-3-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221025091937.44961-1-Henry.Wang@arm.com>
References: <20221025091937.44961-1-Henry.Wang@arm.com>

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
which requires 6 P2M pages as the two pages will be consecutive but not
necessarily in the same L3 page table and keep a buffer, populate 16
pages as the default value to the P2M pages pool in p2m_init() at the
domain creation stage to satisfy the GICv2 requirement. For GICv3, the
above-mentioned P2M mapping is not necessary, but since the allocated
16 pages here would not be lost, hence populate these pages
unconditionally.

With the default 16 P2M pages populated, there would be a case that
failures would happen in the domain creation with P2M pages already in
use. To properly free the P2M for this case, firstly support the
optionally preemption of p2m_teardown(), then call p2m_teardown() and
p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
As non-preemptive p2m_teardown() should only return 0, use a
BUG_ON to confirm that.

Since p2m_final_teardown() is called either after
domain_relinquish_resources() where relinquish_p2m_mapping() has been
called, or from failure path of domain_create()/arch_domain_create()
where mappings that require p2m_put_l3_page() should never be created,
relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
in-code comments to refer this.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
(cherry picked from commit: c7cff1188802646eaa38e918e5738da0e84949be)
---
 xen/arch/arm/domain.c     |  2 +-
 xen/arch/arm/p2m.c        | 34 ++++++++++++++++++++++++++++++++--
 xen/include/asm-arm/p2m.h | 14 ++++++++++----
 3 files changed, 43 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 31abe7d6f9..98395173db 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1018,7 +1018,7 @@ int domain_relinquish_resources(struct domain *d)
         /* Fallthrough */
 
     case RELMEM_p2m:
-        ret = p2m_teardown(d);
+        ret = p2m_teardown(d, true);
         if ( ret )
             return ret;
 
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index fa6d0a83e9..ae0c8d23d4 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1629,7 +1629,7 @@ static void p2m_free_vmid(struct domain *d)
     spin_unlock(&vmid_alloc_lock);
 }
 
-int p2m_teardown(struct domain *d)
+int p2m_teardown(struct domain *d, bool allow_preemption)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long count = 0;
@@ -1637,6 +1637,9 @@ int p2m_teardown(struct domain *d)
     unsigned int i;
     int rc = 0;
 
+    if ( page_list_empty(&p2m->pages) )
+        return 0;
+
     p2m_write_lock(p2m);
 
     /*
@@ -1660,7 +1663,7 @@ int p2m_teardown(struct domain *d)
         p2m_free_page(p2m->domain, pg);
         count++;
         /* Arbitrarily preempt every 512 iterations */
-        if ( !(count % 512) && hypercall_preempt_check() )
+        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
         {
             rc = -ERESTART;
             break;
@@ -1680,7 +1683,20 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
+    /*
+     * No need to call relinquish_p2m_mapping() here because
+     * p2m_final_teardown() is called either after domain_relinquish_resources()
+     * where relinquish_p2m_mapping() has been called, or from failure path of
+     * domain_create()/arch_domain_create() where mappings that require
+     * p2m_put_l3_page() should never be created. For the latter case, also see
+     * comment on top of the p2m_set_entry() for more info.
+     */
+
+    BUG_ON(p2m_teardown(d, false));
     ASSERT(page_list_empty(&p2m->pages));
+
+    while ( p2m_teardown_allocation(d) == -ERESTART )
+        continue; /* No preemption support here */
     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
 
     if ( p2m->root )
@@ -1747,6 +1763,20 @@ int p2m_init(struct domain *d)
     if ( rc )
         return rc;
 
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
+     * the allocated 16 pages here would not be lost, hence populate these
+     * pages unconditionally.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+    if ( rc )
+        return rc;
+
     return 0;
 }
 
diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
index b1c9b947bb..45d535830f 100644
--- a/xen/include/asm-arm/p2m.h
+++ b/xen/include/asm-arm/p2m.h
@@ -173,14 +173,18 @@ int p2m_init(struct domain *d);
 
 /*
  * The P2M resources are freed in two parts:
- *  - p2m_teardown() will be called when relinquish the resources. It
- *    will free large resources (e.g. intermediate page-tables) that
- *    requires preemption.
+ *  - p2m_teardown() will be called preemptively when relinquish the
+ *    resources, in which case it will free large resources (e.g. intermediate
+ *    page-tables) that requires preemption.
  *  - p2m_final_teardown() will be called when domain struct is been
  *    freed. This *cannot* be preempted and therefore one small
  *    resources should be freed here.
+ *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
+ *  free the P2M when failures happen in the domain creation with P2M pages
+ *  already in use. In this case p2m_teardown() is called non-preemptively and
+ *  p2m_teardown() will always return 0.
  */
-int p2m_teardown(struct domain *d);
+int p2m_teardown(struct domain *d, bool allow_preemption);
 void p2m_final_teardown(struct domain *d);
 
 /*
@@ -245,6 +249,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
 /*
  * Direct set a p2m entry: only for use by the P2M code.
  * The P2M write lock should be taken.
+ * TODO: Add a check in __p2m_set_entry() to avoid creating a mapping in
+ * arch_domain_create() that requires p2m_put_l3_page() to be called.
  */
 int p2m_set_entry(struct p2m_domain *p2m,
                   gfn_t sgfn,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:21:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:21:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429681.680818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG7i-0004Zx-7I; Tue, 25 Oct 2022 09:21:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429681.680818; Tue, 25 Oct 2022 09:21:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG7i-0004Zo-3J; Tue, 25 Oct 2022 09:21:26 +0000
Received: by outflank-mailman (input) for mailman id 429681;
 Tue, 25 Oct 2022 09:21:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onG7g-0004ZS-QI
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:21:24 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 64e347fd-5446-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 11:21:23 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 62D36D6E;
 Tue, 25 Oct 2022 02:21:29 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 097023F792;
 Tue, 25 Oct 2022 02:21:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64e347fd-5446-11ed-91b5-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
Date: Tue, 25 Oct 2022 09:21:10 +0000
Message-Id: <20221025092112.50168-1-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1

This series is a backported series for XSA-409 fixes from master for
4.14 to 4.16, which cherry-picking commits:
3783e583319f arm/p2m: Rework p2m_init()
c7cff1188802 xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

Andrew Cooper (1):
  arm/p2m: Rework p2m_init()

Henry Wang (1):
  xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

 xen/arch/arm/domain.c     |  2 +-
 xen/arch/arm/p2m.c        | 58 +++++++++++++++++++++++++++++----------
 xen/include/asm-arm/p2m.h | 14 +++++++---
 3 files changed, 55 insertions(+), 19 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:21:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:21:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429682.680829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG7n-0004ru-GO; Tue, 25 Oct 2022 09:21:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429682.680829; Tue, 25 Oct 2022 09:21:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG7n-0004rj-DQ; Tue, 25 Oct 2022 09:21:31 +0000
Received: by outflank-mailman (input) for mailman id 429682;
 Tue, 25 Oct 2022 09:21:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onG7m-0004qz-PD
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:21:30 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 66dcda20-5446-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 11:21:27 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45ED6D6E;
 Tue, 25 Oct 2022 02:21:35 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E9DD23F792;
 Tue, 25 Oct 2022 02:21:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66dcda20-5446-11ed-8fd0-01056ac49cbb
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.14-to-4.16 1/2] arm/p2m: Rework p2m_init()
Date: Tue, 25 Oct 2022 09:21:11 +0000
Message-Id: <20221025092112.50168-2-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221025092112.50168-1-Henry.Wang@arm.com>
References: <20221025092112.50168-1-Henry.Wang@arm.com>

From: Andrew Cooper <andrew.cooper3@citrix.com>

p2m_init() is mostly trivial initialisation, but has two fallible operations
which are on either side of the backpointer trigger for teardown to take
actions.

p2m_free_vmid() is idempotent with a failed p2m_alloc_vmid(), so rearrange
p2m_init() to perform all trivial setup, then set the backpointer, then
perform all fallible setup.

This will simplify a future bugfix which needs to add a third fallible
operation.

No practical change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
(cherry picked from commit: 3783e583319fa1ce75e414d851f0fde191a14753)
---
 xen/arch/arm/p2m.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 13b06c0fe4..2642d2748c 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1699,7 +1699,7 @@ void p2m_final_teardown(struct domain *d)
 int p2m_init(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
-    int rc = 0;
+    int rc;
     unsigned int cpu;
 
     rwlock_init(&p2m->lock);
@@ -1708,11 +1708,6 @@ int p2m_init(struct domain *d)
     INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist);
 
     p2m->vmid = INVALID_VMID;
-
-    rc = p2m_alloc_vmid(d);
-    if ( rc != 0 )
-        return rc;
-
     p2m->max_mapped_gfn = _gfn(0);
     p2m->lowest_mapped_gfn = _gfn(ULONG_MAX);
 
@@ -1728,8 +1723,6 @@ int p2m_init(struct domain *d)
     p2m->clean_pte = is_iommu_enabled(d) &&
         !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK);
 
-    rc = p2m_alloc_table(d);
-
     /*
      * Make sure that the type chosen to is able to store the an vCPU ID
      * between 0 and the maximum of virtual CPUS supported as long as
@@ -1742,13 +1735,20 @@ int p2m_init(struct domain *d)
        p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID;
 
     /*
-     * Besides getting a domain when we only have the p2m in hand,
-     * the back pointer to domain is also used in p2m_teardown()
-     * as an end-of-initialization indicator.
+     * "Trivial" initialisation is now complete.  Set the backpointer so
+     * p2m_teardown() and friends know to do something.
      */
     p2m->domain = d;
 
-    return rc;
+    rc = p2m_alloc_vmid(d);
+    if ( rc )
+        return rc;
+
+    rc = p2m_alloc_table(d);
+    if ( rc )
+        return rc;
+
+    return 0;
 }
 
 /*
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:21:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:21:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429683.680840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG7r-0005Bd-Q6; Tue, 25 Oct 2022 09:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429683.680840; Tue, 25 Oct 2022 09:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG7r-0005BU-N8; Tue, 25 Oct 2022 09:21:35 +0000
Received: by outflank-mailman (input) for mailman id 429683;
 Tue, 25 Oct 2022 09:21:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onG7q-0004ZS-2G
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:21:34 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 6a4f42fc-5446-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 11:21:32 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A7DFD6E;
 Tue, 25 Oct 2022 02:21:38 -0700 (PDT)
Received: from entos-skylake.shanghai.arm.com (entos-skylake.shanghai.arm.com
 [10.169.212.207])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3CBD13F792;
 Tue, 25 Oct 2022 02:21:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a4f42fc-5446-11ed-91b5-6bf2151ebd3b
From: Henry Wang <Henry.Wang@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Henry Wang <Henry.Wang@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH for-4.14-to-4.16 2/2] xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()
Date: Tue, 25 Oct 2022 09:21:12 +0000
Message-Id: <20221025092112.50168-3-Henry.Wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221025092112.50168-1-Henry.Wang@arm.com>
References: <20221025092112.50168-1-Henry.Wang@arm.com>

Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
when the domain is created. Considering the worst case of page tables
which requires 6 P2M pages as the two pages will be consecutive but not
necessarily in the same L3 page table and keep a buffer, populate 16
pages as the default value to the P2M pages pool in p2m_init() at the
domain creation stage to satisfy the GICv2 requirement. For GICv3, the
above-mentioned P2M mapping is not necessary, but since the allocated
16 pages here would not be lost, hence populate these pages
unconditionally.

With the default 16 P2M pages populated, there would be a case that
failures would happen in the domain creation with P2M pages already in
use. To properly free the P2M for this case, firstly support the
optionally preemption of p2m_teardown(), then call p2m_teardown() and
p2m_set_allocation(d, 0, NULL) non-preemptively in p2m_final_teardown().
As non-preemptive p2m_teardown() should only return 0, use a
BUG_ON to confirm that.

Since p2m_final_teardown() is called either after
domain_relinquish_resources() where relinquish_p2m_mapping() has been
called, or from failure path of domain_create()/arch_domain_create()
where mappings that require p2m_put_l3_page() should never be created,
relinquish_p2m_mapping() is not added in p2m_final_teardown(), add
in-code comments to refer this.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Henry Wang <Henry.Wang@arm.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
(cherry picked from commit: c7cff1188802646eaa38e918e5738da0e84949be)
---
 xen/arch/arm/domain.c     |  2 +-
 xen/arch/arm/p2m.c        | 34 ++++++++++++++++++++++++++++++++--
 xen/include/asm-arm/p2m.h | 14 ++++++++++----
 3 files changed, 43 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index aae615f7d6..0fa1c0cb80 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1032,7 +1032,7 @@ int domain_relinquish_resources(struct domain *d)
             return ret;
 
     PROGRESS(p2m):
-        ret = p2m_teardown(d);
+        ret = p2m_teardown(d, true);
         if ( ret )
             return ret;
 
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 2642d2748c..3eb6f16b30 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1630,7 +1630,7 @@ static void p2m_free_vmid(struct domain *d)
     spin_unlock(&vmid_alloc_lock);
 }
 
-int p2m_teardown(struct domain *d)
+int p2m_teardown(struct domain *d, bool allow_preemption)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
     unsigned long count = 0;
@@ -1638,6 +1638,9 @@ int p2m_teardown(struct domain *d)
     unsigned int i;
     int rc = 0;
 
+    if ( page_list_empty(&p2m->pages) )
+        return 0;
+
     p2m_write_lock(p2m);
 
     /*
@@ -1661,7 +1664,7 @@ int p2m_teardown(struct domain *d)
         p2m_free_page(p2m->domain, pg);
         count++;
         /* Arbitrarily preempt every 512 iterations */
-        if ( !(count % 512) && hypercall_preempt_check() )
+        if ( allow_preemption && !(count % 512) && hypercall_preempt_check() )
         {
             rc = -ERESTART;
             break;
@@ -1681,7 +1684,20 @@ void p2m_final_teardown(struct domain *d)
     if ( !p2m->domain )
         return;
 
+    /*
+     * No need to call relinquish_p2m_mapping() here because
+     * p2m_final_teardown() is called either after domain_relinquish_resources()
+     * where relinquish_p2m_mapping() has been called, or from failure path of
+     * domain_create()/arch_domain_create() where mappings that require
+     * p2m_put_l3_page() should never be created. For the latter case, also see
+     * comment on top of the p2m_set_entry() for more info.
+     */
+
+    BUG_ON(p2m_teardown(d, false));
     ASSERT(page_list_empty(&p2m->pages));
+
+    while ( p2m_teardown_allocation(d) == -ERESTART )
+        continue; /* No preemption support here */
     ASSERT(page_list_empty(&d->arch.paging.p2m_freelist));
 
     if ( p2m->root )
@@ -1748,6 +1764,20 @@ int p2m_init(struct domain *d)
     if ( rc )
         return rc;
 
+    /*
+     * Hardware using GICv2 needs to create a P2M mapping of 8KB GICv2 area
+     * when the domain is created. Considering the worst case for page
+     * tables and keep a buffer, populate 16 pages to the P2M pages pool here.
+     * For GICv3, the above-mentioned P2M mapping is not necessary, but since
+     * the allocated 16 pages here would not be lost, hence populate these
+     * pages unconditionally.
+     */
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, 16, NULL);
+    spin_unlock(&d->arch.paging.lock);
+    if ( rc )
+        return rc;
+
     return 0;
 }
 
diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
index b733f55d48..ac4edb95ce 100644
--- a/xen/include/asm-arm/p2m.h
+++ b/xen/include/asm-arm/p2m.h
@@ -185,14 +185,18 @@ int p2m_init(struct domain *d);
 
 /*
  * The P2M resources are freed in two parts:
- *  - p2m_teardown() will be called when relinquish the resources. It
- *    will free large resources (e.g. intermediate page-tables) that
- *    requires preemption.
+ *  - p2m_teardown() will be called preemptively when relinquish the
+ *    resources, in which case it will free large resources (e.g. intermediate
+ *    page-tables) that requires preemption.
  *  - p2m_final_teardown() will be called when domain struct is been
  *    freed. This *cannot* be preempted and therefore one small
  *    resources should be freed here.
+ *  Note that p2m_final_teardown() will also call p2m_teardown(), to properly
+ *  free the P2M when failures happen in the domain creation with P2M pages
+ *  already in use. In this case p2m_teardown() is called non-preemptively and
+ *  p2m_teardown() will always return 0.
  */
-int p2m_teardown(struct domain *d);
+int p2m_teardown(struct domain *d, bool allow_preemption);
 void p2m_final_teardown(struct domain *d);
 
 /*
@@ -257,6 +261,8 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
 /*
  * Direct set a p2m entry: only for use by the P2M code.
  * The P2M write lock should be taken.
+ * TODO: Add a check in __p2m_set_entry() to avoid creating a mapping in
+ * arch_domain_create() that requires p2m_put_l3_page() to be called.
  */
 int p2m_set_entry(struct p2m_domain *p2m,
                   gfn_t sgfn,
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:22:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:22:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429693.680851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG8G-0006Cg-7o; Tue, 25 Oct 2022 09:22:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429693.680851; Tue, 25 Oct 2022 09:22:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onG8G-0006CX-5A; Tue, 25 Oct 2022 09:22:00 +0000
Received: by outflank-mailman (input) for mailman id 429693;
 Tue, 25 Oct 2022 09:21:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onG8E-0004ZS-1Z
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:21:58 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2058.outbound.protection.outlook.com [40.107.243.58])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77c6ce2d-5446-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 11:21:56 +0200 (CEST)
Received: from DM6PR02CA0077.namprd02.prod.outlook.com (2603:10b6:5:1f4::18)
 by SJ1PR12MB6241.namprd12.prod.outlook.com (2603:10b6:a03:458::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 09:21:53 +0000
Received: from DM6NAM11FT086.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:1f4:cafe::87) by DM6PR02CA0077.outlook.office365.com
 (2603:10b6:5:1f4::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 09:21:53 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT086.mail.protection.outlook.com (10.13.173.75) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 09:21:53 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 04:21:50 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 25 Oct 2022 04:21:18 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77c6ce2d-5446-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hS2Rx1p9bW7TQVJR0HiG97FpJxhQKsInhm3Zdqe/rHU994OcD2a5R80Clo+AdxZX2Mh8lCgyNL23ZJxuRo/w9R/TWPAvhxX486JIMXb2pnHOMlAOYaKLaTPN7EGKMEuM4TZWqsgcY0pCrylP0sv1iul66hgPOtJdWJWdiS2NBjkMU7JwA40foQrQEPd6rFVdzS4XOPJ7KzNU4yXFVOwODw+xK8ia/HxiZVzgEH6PcMXNWoeXM9p1JAwIugcM9ilQt3T2kLX3bngkdkiCI8w3JcTwuuhlcEfgZbEQD6K000AUvyfnKe77MDGaVHrEF6bbp4SC8N2RmEpyFWKkcWcLLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kc1OdzbUVoH/An6BsueD6Yy51rtby1vUctz6mo7jnHc=;
 b=lwnQSkpOXnkrHH8i9il3GA48s74Utuw+x7t4QH5E62dYWXm3kJA2Ldic2NpIyOSfsa6MIyJgqlIHTmq+okO4woS4H2abBZmnAqrmBwgVyKYuyC2Tkf28mQ6Q+As4PoffBfI3MLUpaDpSVhUYd9JI+D2OVIUjVk8JwAxMhhmOfFVNGh7PHgev2fbkSqNB2my9D5vYBejt6sAWZHeMJp5KjV02NjFw35n2qtjJ+BMlYuiv9BtD7YsMTjrjjDGV4ubMVNwlieE3WiHHorPvCExkd4IlybbKDfL3uMetErkvPeZrwZZn7aHieVgAjULyAjotbB2rHhfI/h7/drfMNmgvNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kc1OdzbUVoH/An6BsueD6Yy51rtby1vUctz6mo7jnHc=;
 b=M02ra2m1U6V20JTkxQWvtzueyxVvU/hq7A3LE4TGaSGRIwZVFstVKADW5Zh/1xDnXF05JXDRawIhOcgUti212Wk8H0f2wwF2ZowruvheslxBxTfVLYsmXLS912FR9L1xrF3DX1SVo0K9+oAI+qYSZhc12IdyNCIxcXRN5jSBO+Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <c5767718-bb00-da6b-8623-1bcb6c832f85@amd.com>
Date: Tue, 25 Oct 2022 11:21:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Content-Language: en-US
To: Julien Grall <julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: <marco.solieri@minervasys.tech>, <lucmiccio@gmail.com>,
	<carlo.nonato@minervasys.tech>, Julien Grall <jgrall@amazon.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-2-julien@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221022150422.17707-2-julien@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT086:EE_|SJ1PR12MB6241:EE_
X-MS-Office365-Filtering-Correlation-Id: e10c64b3-686b-48d5-d5d6-08dab66a5add
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zrk4N6JMzcVwJmRArmkDRDKUZruHMUtER6zZ6BVs+l3ZvOUjdXlhMfvvnKZ3W7APP7hAZf3hADkE6bYJonMFgCGg7Fym6vfIdR75pXwDttU38zxiTx9t3s0060tIj6lag3eLm4bThnEXrvTpyUKSURdWY8qZzQ5EqqnMxKx88WZs7SpGYwFQb1uZAJZl9AJTC4TrGiizg0KQz4EPqP1G9EhNwtS0FmEOUKh3WI8b8u/NYmGikGm2ZcaO8zl2Aw2KuRmLhQ8u+TmzDOSLjE9VgTsiV4tuD0NRoedpT1OYis7ahc3oT/Cw5qW6AdnqrD4AcMt9JP7AbqZrxTM+tFjwt61cTu2Q1wgzswYhs65g4ymKKN4SGDW4fZCiVUzO4T8bIANII2HiItbiSsPDtC1WV4M7QJVgGSNYPK8FkMsMEc9UXu5WUWtrUEiSGFijs/3CWjEzheZ7dDv0Ee6KEWlBUos8aw5PzsOROFzL3a8jtO8vB/7VmTb6W+4WtELtz7zmJl/Hgsrd1FWqBqtL3GFMsdXcpZqcPo46DdSWJAtYz7X2c4Tq8cpveMjbM1cN7axZi5r2p2qJjKfbiKh+OUV6NN357gsauOnWtf2+cN6yN9vEFCLV9yDqLIG7hmtHnZm5B9o2s4jiV+86lPUYiPrznsevkm2Hwm6bI0f/7eEyY86VG+tnno7wAA+kXnUPg6+dGd+fOjv46GBrsE+IrZcKD+bp7pzASTjs0GbTlmqFMqweYiUTyJ8mnhL+6GAAqou1HGd6c9wsq9fJALeJOGW2kUvt7CJ6by9TpzHI1pqDQ8SKVMICXqhEkGkVn0iuuUGWFK0yA/QH9zFPSy0qvuliQQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(8676002)(70586007)(8936002)(31696002)(36860700001)(478600001)(70206006)(16576012)(41300700001)(316002)(2906002)(5660300002)(54906003)(4326008)(86362001)(81166007)(44832011)(356005)(4744005)(40460700003)(82310400005)(82740400003)(110136005)(36756003)(426003)(40480700001)(31686004)(2616005)(47076005)(53546011)(336012)(186003)(26005)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 09:21:53.2841
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e10c64b3-686b-48d5-d5d6-08dab66a5add
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT086.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6241

Hi Julien,

On 22/10/2022 17:04, Julien Grall wrote:
> 
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> In a follow-up patch, the base address for the common mappings will
> vary between arm32 and arm64. To avoid any duplication, define
> every mapping in the common region from the previous one.
Maybe the following title would be better suited if you only want to touch the common mappings?
"xen/arm: Clean-up the common memory layout"

> 
> Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
> XEN_VIRT_*.
> 
> Take the opportunity to add missing *_SIZE for some mappings.
I think this sentence can be removed as the previous one already covers it.

Apart from that, wouldn't it be useful to do the cleanup for the arm32 macros
as you are here (FRAMETABLE, VMAP, {XEN/DOM}HEAP) ?

~Michal


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:45:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:45:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429707.680867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGV5-0000mr-4K; Tue, 25 Oct 2022 09:45:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429707.680867; Tue, 25 Oct 2022 09:45:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGV5-0000mk-1h; Tue, 25 Oct 2022 09:45:35 +0000
Received: by outflank-mailman (input) for mailman id 429707;
 Tue, 25 Oct 2022 09:45:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onGV4-0000me-EB
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:45:34 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam04on2061.outbound.protection.outlook.com [40.107.100.61])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c13008a1-5449-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 11:45:28 +0200 (CEST)
Received: from MW4PR03CA0337.namprd03.prod.outlook.com (2603:10b6:303:dc::12)
 by PH7PR12MB6905.namprd12.prod.outlook.com (2603:10b6:510:1b7::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 09:45:24 +0000
Received: from CO1NAM11FT051.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:dc:cafe::ba) by MW4PR03CA0337.outlook.office365.com
 (2603:10b6:303:dc::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 09:45:24 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT051.mail.protection.outlook.com (10.13.174.114) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 09:45:23 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 04:45:20 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 04:45:18 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 25 Oct 2022 04:45:17 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c13008a1-5449-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OuY/Szn4wbvP2sMUowucqeBm4McML0r7v9a+kOh8HQh7WxG/MClEBo8SI2QgxMjHHfnXlITcyp36jsfpRXrj8Z4bj/tY6UIfhsdYyDmLmNrNPk45ouYx0sSV20qmgRKs0fXvwALRWItnHzW+QIhhsahJGq0GT78CtZbH+KlUCx/7EUe2+oZty7dohp3oBOQJgZL2Td7CpE11lTdKoj49+Zv4TG46js/z2v+hwGwBZiLXKd6A1/eqr83DNMlaOXsa+TxSZ4RS9D4bq+ka4zwQQxbdvRogu7pr2YvYCsIveqcGNsP7vN37wtPR2ZJLJFWZZuUbjZMvGIDnqT8hZbqdLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XVJ24SY2srO3UWkRsdbW+YFox9PstZGdzk6L5FJN7pM=;
 b=ALfRYMlLpSJ6h+96+CXcOdUNIe2tiJBA3CM89dfIxhp2R0i0YfXMHRXg99aOBXo45SHoKVQngjpGF3/etQP59fRw5kwPS7VEo+3b771481m8BVi+iUqZHikT+edCvjUBNo8kiQPPGvWyq7yCn6AE+HensVz2/sZ2CBbz9C3o+c1Zw7jFGGIFrB0j/cFey32CxgZsV4ozF64nGtWexX1iU9kluX/BX+74EUoCfS417vhHdIM6+okH5UXfndb5fLe4DgUF+MhXnWjTBGm150BVnI5cxY/bpOg5dkLbhhPzWHKVvbFPXTnQg8/+NKp/AL1ISM77r0/JmsVtjZUYRz+Tmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XVJ24SY2srO3UWkRsdbW+YFox9PstZGdzk6L5FJN7pM=;
 b=EpX2LlsblSGetzhF1IKbWUSh5aBOrepPp4GvBu1oBTY4/xL22bXpX7QRDK07weLkVSoFZKnMfjWT8GXAsqLy5LYlHSN8yAhFIbiz5+J7p/MJzteTUVngbHl13yjT7NVEDLf9kzYPnxfG23KmBcwEgu3LOq5vxU6BbHxI0fJF+nM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <851b93a6-6116-2a81-f737-b7fd61d793f9@amd.com>
Date: Tue, 25 Oct 2022 11:45:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [RFC v2 02/12] xen/arm32: head: Jump to the runtime mapping in
 enable_mmu()
Content-Language: en-US
To: Julien Grall <julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: <marco.solieri@minervasys.tech>, <lucmiccio@gmail.com>,
	<carlo.nonato@minervasys.tech>, Julien Grall <jgrall@amazon.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-3-julien@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221022150422.17707-3-julien@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT051:EE_|PH7PR12MB6905:EE_
X-MS-Office365-Filtering-Correlation-Id: d60d0fd8-7857-43c0-95d6-08dab66da377
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ENY/gkGfVCdVJwpCW+bam2+1Ck7fIpvOtUNrQgzuNbJt7fo9sdQLM3amqzrukR/Ve+gcL8Spf3fz+CAL8hPVpnE14yVgRnlJXOwKfSUQJwojUfWdENGFFO7nmruDWu8BbLyoXh9FQz00ODb+1oubhjVfgTs5GKXyEaJIWvOojCaS+S0agXWHreOIH07W2zDT4EffBNOKKlXzBD/rq1mmRfKK9OYZVW+Vcl4Ie6zlGVXsbJx0gpC3UfmEHZm/01bhqXDbJI8T/5tSzmAvLPC4Ow9JWmx8K2LfEzkZkX0RUDXpKm6/tAqhMSk+4PG+g1Oqp8FqIVNy6Oasym7z3ivfKEE+JQyLtUhpl3BItqE+kMBbn7eFGWETX3t2U3B/0xImhQGN/nf8CCfZuTNjq6b4khOG0a9a19szCs/DxPpoIifbs9209+OVbOxB4E0+JrDbkGHQZhJyI4i0eAQP2qXB+6y0Xl/A30m5Qaip5JfBAVGWFehXg9Cz1UfaiZ4iSXb9ltloqkI/l0KnIr45qh5WcGDb0g4AD8d+rcZWYMHDC+6j+RHY8LeMVZHox/2o0TSYbVlWyNmoymLncSquzApBLXWwu+Hrm18CfRIRzebhq20o3lMMuCdjWESvqLepPM+a+UKsVx3Qlo2+Rt/bN8iSYed1d2mOjkYSLq2KBjbgLZ/rXFV+HeTWkqlupAP5ywuztEjc+Znh03zqRWGbVzSHfsKulAgk1l3wbuM8Ei2yaRFx+GaInxlN4DjHT30+oCfMYnoxgS6CDp2XFUj3DUPPqSOArz/a6OPu8UDdjW1fYBpmzti648p/giFQtkyEm7V4E4kXgwQfbjxRSPKyZGEx0WSfEtN89rSs7g/wT9UkHCQ=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(426003)(47076005)(83380400001)(356005)(86362001)(31696002)(81166007)(36860700001)(8936002)(82740400003)(70586007)(70206006)(5660300002)(44832011)(8676002)(4326008)(41300700001)(2906002)(82310400005)(53546011)(26005)(2616005)(40460700003)(36756003)(110136005)(54906003)(336012)(40480700001)(966005)(16576012)(316002)(478600001)(186003)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 09:45:23.5154
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d60d0fd8-7857-43c0-95d6-08dab66da377
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT051.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6905

Hi Julien,

On 22/10/2022 17:04, Julien Grall wrote:
> 
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> At the moment, enable_mmu() will return to an address in the 1:1 mapping
> and each path are responsible to switch to the runtime mapping.
s/are/is/

> 
> In a follow-up patch, the behavior to switch to the runtime mapping
> will become more complex. So to avoid more code/comment duplication,
> move the switch in enable_mmu().
> 
> Lastly, take the opportunity to replace load from literal pool with
> mov_w.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
>  xen/arch/arm/arm32/head.S | 51 ++++++++++++++++++++++++---------------
>  1 file changed, 31 insertions(+), 20 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index a558c2a6876e..163bd6596dec 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -167,19 +167,12 @@ past_zImage:
>          bl    check_cpu_mode
>          bl    cpu_init
>          bl    create_page_tables
> -        bl    enable_mmu
> 
> -        /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
> -        ldr   r0, =primary_switched
> -        mov   pc, r0
> +        /* Address in the runtime mapping to jump to after the MMU is enabled */
> +        mov_w lr, primary_switched
We seem to still widely use ldr instead of mov_w which is faster.
It looks like a prerequisite patch to convert all occurences or something to keep in a backlog.

> +        b     enable_mmu
> +
>  primary_switched:
> -        /*
> -         * The 1:1 map may clash with other parts of the Xen virtual memory
> -         * layout. As it is not used anymore, remove it completely to
> -         * avoid having to worry about replacing existing mapping
> -         * afterwards.
> -         */
> -        bl    remove_identity_mapping
>          bl    setup_fixmap
>  #ifdef CONFIG_EARLY_PRINTK
>          /* Use a virtual address to access the UART. */
> @@ -223,12 +216,10 @@ GLOBAL(init_secondary)
>          bl    check_cpu_mode
>          bl    cpu_init
>          bl    create_page_tables
> -        bl    enable_mmu
> -
> 
> -        /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
> -        ldr   r0, =secondary_switched
> -        mov   pc, r0
> +        /* Address in the runtime mapping to jump to after the MMU is enabled */
> +        mov_w lr, secondary_switched
> +        b     enable_mmu
>  secondary_switched:
>          /*
>           * Non-boot CPUs need to move on to the proper pagetables, which were
> @@ -523,9 +514,12 @@ virtphys_clash:
>  ENDPROC(create_page_tables)
> 
>  /*
> - * Turn on the Data Cache and the MMU. The function will return on the 1:1
> - * mapping. In other word, the caller is responsible to switch to the runtime
> - * mapping.
> + * Turn on the Data Cache and the MMU. The function will return
> + * to the virtual address provided in LR (e.g. the runtime mapping).
> + *
> + * Inputs:
> + *   r9 : paddr(start)
> + *   lr : Virtual address to return to
>   *
>   * Clobbers r0 - r3
>   */
> @@ -551,7 +545,24 @@ enable_mmu:
>          dsb                          /* Flush PTE writes and finish reads */
>          mcr   CP32(r0, HSCTLR)       /* now paging is enabled */
>          isb                          /* Now, flush the icache */
> -        mov   pc, lr
> +
> +        /*
> +         * The MMU is turned on and we are in the 1:1 mapping. Switch
> +         * to the runtime mapping.
> +         */
> +        mov_w r0, 1f
> +        mov   pc, r0
Would it be possible to stop using:
	mov pc, reg
in favor of using:
	bx reg

Some time ago I saw this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm/include/asm/assembler.h?id=6ebbf2ce437b33022d30badd49dc94d33ecfa498
which states that bx is faster.

> +1:
> +        /*
> +         * The 1:1 map may clash with other parts of the Xen virtual memory
> +         * layout. As it is not used anymore, remove it completely to
> +         * avoid having to worry about replacing existing mapping
> +         * afterwards.
> +         *
> +         * On return this will jump to the virtual address requested by
> +         * the caller.
> +         */
> +        b     remove_identity_mapping
>  ENDPROC(enable_mmu)
> 
>  /*
> --
> 2.37.1
> 
> 

Apart from that, the change looks ok.

~Michal


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 09:53:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 09:53:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429713.680878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGcV-0002Hb-Tp; Tue, 25 Oct 2022 09:53:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429713.680878; Tue, 25 Oct 2022 09:53:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGcV-0002HU-R4; Tue, 25 Oct 2022 09:53:15 +0000
Received: by outflank-mailman (input) for mailman id 429713;
 Tue, 25 Oct 2022 09:53:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onGcU-0002HO-G8
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 09:53:14 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on2062.outbound.protection.outlook.com [40.107.92.62])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d5df316c-544a-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 11:53:12 +0200 (CEST)
Received: from BN8PR07CA0034.namprd07.prod.outlook.com (2603:10b6:408:ac::47)
 by PH8PR12MB7375.namprd12.prod.outlook.com (2603:10b6:510:215::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 25 Oct
 2022 09:53:09 +0000
Received: from BN8NAM11FT094.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ac:cafe::fc) by BN8PR07CA0034.outlook.office365.com
 (2603:10b6:408:ac::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 09:53:08 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT094.mail.protection.outlook.com (10.13.176.131) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 09:53:08 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 04:53:07 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 25 Oct 2022 04:53:06 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5df316c-544a-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XOQz80UAMO7/e57TCNwy+IW3vdfnWj7dFK3ay6tP7HeUmwy10+O1dzN06a8qe0dcZpstmB1bsizFnJ1ZOD9hIEJz4W28y3KFxeAeUZ/bc1SxOyQLCI4N5rZ/5znIzyJQFJEwg+H7F5AmbW9k8sJoLXBIAfRMF4LY/fDJuvxOlAkg82HN7spHGL/Fs42uStVZnLzqaybIYlu5MJlDr4jNbVXhehnKnt8AG8TRDmYsHPSOsObyQX306PY/r2wLDlXqLYXMS+Uw73ThzJnNE9ZS4nDyklzTLCeA9fhGB+DnPF+qeMH8+fgyEExwuE3IAeo2hehBEMW4LRSrfJHAL0xuKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0YaOHtMnSNT4PZxeNifK/eY0BAagSfNYbflkwrC+ywI=;
 b=krTyagdNbDRNh78PdiR+twGTiyP8oDo3CdSMnmk9f4rNhB4NQP4Y/mxid8R6skOXgB+E4XUY46tixxrZuZrgbfzUMaup/xNK/Ubf0bg+4TjwpWC7rEDrZThpkJ7Td4iX68q6zHLYgoK030FMU57Xm6RLbAuowll0Do3q2AlZuZVD4SnRyf2/PctBtjbQqmaV8WOXdw3gyr9jwv5OVPSDuZk/Vbr3umHoQyZxC2t0d0/zj82u0paERxLcDG9K7VzxJADE/LtdxUKCAAmt35xArFuhWEOUxbI7fZRW3O7THByktQOizGOJWwL2oegR3kAokEhuGtfXISN/KF70PPWr7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0YaOHtMnSNT4PZxeNifK/eY0BAagSfNYbflkwrC+ywI=;
 b=g/yMNgzwiLStW7qUY7Bq0Zk4FLRUbEPSWHKwyhZdSp1rZSzvG8ITtPxvW7EXPcGrBkNn4xx/tOqHCmUg+xvo3U9w55TsWSgPzgjycSliDGkY/q8wjLOTtotp+DrQ/fujcvRGdON+ZotrxSRv/gvAmRDdPgqcSz06nN/AVlNciLQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <f50c3f5c-fa71-3963-d95a-d48fe801ad9e@amd.com>
Date: Tue, 25 Oct 2022 11:53:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [RFC v2 03/12] xen/arm32: head: Introduce an helper to flush the
 TLBs
Content-Language: en-US
To: Julien Grall <julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: <marco.solieri@minervasys.tech>, <lucmiccio@gmail.com>,
	<carlo.nonato@minervasys.tech>, Julien Grall <jgrall@amazon.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-4-julien@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221022150422.17707-4-julien@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT094:EE_|PH8PR12MB7375:EE_
X-MS-Office365-Filtering-Correlation-Id: 89faed8e-089c-4135-2f2a-08dab66eb87b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	O1RmdxB7k8J62CJJ3LTV12kMF2TrxtaAfrVv9zK/JKn53185UarpgnQTJANAJezy+n7OdlpOl9UHRpncJbntSirhgCp1RyfS2QxuuLb5nlsDpGSNo1+1WBmsLL3ktRlSPdA9Lojo34j1N7gRZ+KrGed94vUCKPdCyk7ELfKpdl6EZLiT+EZiJd1vPdZuvlU3Sb1+7fuklFm+3MtFEInwZJemSbqjS56T8Tlu65DUy8CKCYcwAZQOYSjU2BYIlPH49LoMJMQFcYZy0D1UWWIYVHeSgaEf6FiOSlVolC3Nt3vZaFTzmdFPrtcf1bdGFGJM/B2ZiizSVh6XnE39ulwOYxD0/FuWrYzw2+1oKipah7odiLNF2bnEFkUg8LSk/iV4RVGGKmA26YXMCqegeV5XAA3pUOb2u0JNWEJuMlkEp9fzrvNgH/bWGQ6vka3NLP6KIdfLvVp9aPsj7JXdvQKehrzq2+IHvc33MlRXzSjTZJKXySPh8ZOmHlY6FuDKBcr7EyqdJNkJf7G2jyvaIg9woUEF1FFYUcBCIlhdaXvBxbUQDbZci0MXE0v9Whdlx/Io+eiLSjD44rkqmGktmlVTXmIMtAj5xnFRA0Vye/yIbyUlrOTfr0LVdlYQ8VkchhWKVbu8uCygyWTRKbQcLp5QspnJOA7EgFqX9/ZdhS+9Flg/PhIag8you+y/w+TUPzvhjA/BXDSRL9Ov0YQUm0bIgqhG3rv2rJzBLv9gWogFB0a+F+TLpxOKYa26pzNLoJLrlJhIwao1eZ38C2TbvJyCTtS6gsGY7p2PA/g7Yi4fqDBFrWo/Z0FjUxTZbQPLerQC5B0Smzs5bYophqZvKsbtuA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(36840700001)(40470700004)(46966006)(8676002)(110136005)(8936002)(70206006)(82740400003)(316002)(26005)(53546011)(16576012)(41300700001)(86362001)(54906003)(40480700001)(70586007)(4326008)(478600001)(40460700003)(81166007)(2616005)(44832011)(36756003)(356005)(31696002)(83380400001)(82310400005)(47076005)(5660300002)(31686004)(36860700001)(186003)(2906002)(426003)(336012)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 09:53:08.3616
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 89faed8e-089c-4135-2f2a-08dab66eb87b
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT094.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7375

Hi Julien,

On 22/10/2022 17:04, Julien Grall wrote:
> 
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> The sequence for flushing the TLBs is 4 instruction long and often
> require an explanation how it works.
s/require/requires/

> 
> So create an helper and use it in the boot code (switch_ttbr() is left
> alone for now).
> 
> Note that in secondary_switched, we were also flushing the instruction
> cache and branch predictor. Neither of them was necessary because:
>     * We are only supporting IVIPT cache on arm32, so the instruction
>       cache flush is only necessary when executable code is modified.
>       None of the boot code is doing that.
>     * The instruction cache is not invalidated and misprediction is not
>       a problem at boot.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
>  xen/arch/arm/arm32/head.S | 31 ++++++++++++++++++-------------
>  1 file changed, 18 insertions(+), 13 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index 163bd6596dec..aeaa8d105aeb 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -66,6 +66,21 @@
>          add   \rb, \rb, r10
>  .endm
> 
> +/*
> + * Flush local TLBs
> + *
> + * tmp1:    Scratch register
I would love to adhere to the way of describing macro params like you did in mov_w. This would mean:
@tmp: scratch register

Apart from that, the change looks ok.

Question on the side:
Why do we use nshst in assembly and ishst in TLB helper macro?
Is it because the latter is also used to flush the inner TLBs whereas the former only local ones?

~Michal



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:00:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:00:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429722.680896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGj8-0003rl-Qk; Tue, 25 Oct 2022 10:00:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429722.680896; Tue, 25 Oct 2022 10:00:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGj8-0003r4-Mx; Tue, 25 Oct 2022 10:00:06 +0000
Received: by outflank-mailman (input) for mailman id 429722;
 Tue, 25 Oct 2022 10:00:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onGj7-0003eE-LM
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:00:05 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c81e9e06-544b-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 11:59:58 +0200 (CEST)
Received: from BN8PR15CA0057.namprd15.prod.outlook.com (2603:10b6:408:80::34)
 by MW4PR12MB6778.namprd12.prod.outlook.com (2603:10b6:303:1e8::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 10:00:00 +0000
Received: from BN8NAM11FT098.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:80:cafe::5b) by BN8PR15CA0057.outlook.office365.com
 (2603:10b6:408:80::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Tue, 25 Oct 2022 10:00:00 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT098.mail.protection.outlook.com (10.13.177.196) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 09:59:59 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 04:59:59 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 02:59:58 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Tue, 25 Oct 2022 04:59:57 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c81e9e06-544b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jd3k7n1FG6lszYIVMdf3unRBusHRz47ypM7T46rBlsG+a+oxVeh4PZJZ4nMcmdMcl1OXEp0jGah8HxAuEaOjOogow26RMqfdoS1jPTxGfPaV0tlnYQPGORsrwXIxZLJKNtKAtjJoiiLB73yUvbhNvDZczyiCSj8wpOJF09yw4y4n3DtwTA7uVjBpkRfa9NSQU1/07KwQhBQS0Kxxc/JjsSmBaljHDH/137iFcbp81yxnbQ57eDhUv1N15jwwfoH6rrq3iDKNzDqxNmlTWzPvDUfxtcf7Aj1XaPnJ5O7vnNeAnqH/TjOTQqDmmLajt/ZOOqu3wtihlwO7ROeujNnooA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R2muQrqKMBKKVld3vXW0A8SjsFRSw+bg3agKx9wtIvw=;
 b=ZApBayFSqmZ1oexMBzMZmI7YjmYQ7NewUzu78AsCmZlx6/LMGEyZhqYFw74QyFLG3En1vhmhPFlGLcJzOB7pMtk0t7lhs33Ik7RnBY0tFljb13dcmNvg0UUsD85tQCuDrXqDT6SWykB2C20b03MdxWp/bsAMjQDPfnWIHMaTLrP9gStIFXL0Y9T5WTslIKwPuXN1NmW7fbz73kJu6MUai5/3imlS1pqhcZPxY5KVz7El7tr31BOkc+vGTxE6xkQSyPmbM0Vu92ZrrJJJwDXcWeg7TIb+JJuW1mca5V7IHcttnWUSde350oeq7o0EXZeY1DoSfpf43DPsMXx2cOwUqQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R2muQrqKMBKKVld3vXW0A8SjsFRSw+bg3agKx9wtIvw=;
 b=FUUTnfHZLSjKEpsGJ0xFmpPUDcN0zPNpGvGGE4cWA0GwY/hevMSP8nWTp2kY/vWvsQgzRu3v3GT0c5P8tYkZQ1VLNMS482AGKRMKglG4XnW2aE1boFTpDGLHpGT6FUb6mpK1ddumSrBjMFEj5tV6bZ0lh1QqwCVh1M7YkZyxZwg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v2] automation: test.yaml: Introduce templates to reduce the overhead
Date: Tue, 25 Oct 2022 11:59:52 +0200
Message-ID: <20221025095952.21980-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT098:EE_|MW4PR12MB6778:EE_
X-MS-Office365-Filtering-Correlation-Id: 5f598011-5d3c-4f57-2fc2-08dab66fadc4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3a8xe18kN4CGYJUi7s9eE34OzgGbjEMhCRU+9ZuVaaPU68ryYBOf66d6gTAd8RVjHmX01wGW7OfwstwxCRn1TB4nwnnkHrSgdlgCzysbk0WDDekyG5YNVqyglNrlJ9yYfepeEb8tzHxVGEw249FC0mySeyCJERM+Pg45EEG/pzdBC1DYvmtlXnqB+YgEWDPmFUQse618R/oLO2hMoGqfdhslRyGJpmPVb9BZouHSrQ9c8c7kBUer0g0mJAZg3C0uRvfqYweXUrLRFAqQ1INN/jecBaJWOMkYpm/thJYOJamR1VLbIfo33WfmrmjzNBndMAyxPyzh96JgUkjQdmboayeRdsXo4kEOsaCCZ31XAWbhiEoSe2DyuhKPyXCmtYRhtQqXOh7R3lc4g476Q3OXC8eB6crmw1tl3jeqaLvhN07gz+tzv5ytZ0Cs3I+YaR4zozBXH9rZ5qGmEYteCmc9kASlvfnU4HBzRJr/BcnTrYBAAK/AYolbPRnyabR/sLue6JjSoEmY9/Qq7sk4PSiTIKhfRpqvcaOr5HiSC96VFUwcuSSZyALZ+FjKaNa3X5loeTvEIo5BvseSSDrUiU7+IfGguO0/gBc/oivrqVv7dmSwSn0RuISx44WmqGMTnBlwRCu3zRMv+FwC1+x0V+6ksiWEoQZiuQRVPrio/8fOBNUHHKD/Uoo0DbnS71CbhKbhtAN8rbwomPzvwOgaZH0416Wz66RVU1tQp/0pNk5r87pU1KHfHLwW44YkAqqTGkTcS/u0AQkvRVN/q7nlqZghyo8x/dsEH/zwByWiesnwn8KQRBZS5/rSPBZPH4l5PYsdBClSqkImUFl6Vhmw3Pp/vA==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(40480700001)(82740400003)(426003)(36860700001)(6916009)(2906002)(54906003)(81166007)(356005)(8936002)(40460700003)(36756003)(41300700001)(70206006)(8676002)(30864003)(44832011)(4326008)(316002)(83380400001)(5660300002)(86362001)(26005)(6666004)(70586007)(1076003)(186003)(82310400005)(336012)(2616005)(478600001)(966005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 09:59:59.8818
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f598011-5d3c-4f57-2fc2-08dab66fadc4
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT098.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6778

At the moment, we define lots of test jobs in test.yaml, that make use
of the same configuration sections like variables, tags, artifacts.
Introduce templates (hidden jobs whose names start with a dot) to
reduce the overhead and simplify the file (more than 100 lines saved).
This way, the actual jobs can only specify sections that are unique
to them.

Most of the test jobs specify the same set of prerequisite jobs under
needs property with just one additional being unique to the job itself.
Introduce YAML anchors for that purpose, because when using extends, the
needs property is not being merged (the parent property overwrites the
child one).

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Changes in v2:
 - carve out anchors from extend jobs and use better naming

This patch is based on the CI next branch where we already have several
patches (already acked) to be merged into staging after the release:
https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next
---
 automation/gitlab-ci/test.yaml | 270 ++++++++++-----------------------
 1 file changed, 83 insertions(+), 187 deletions(-)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 92e0a1f7c510..c7e0078e04f1 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -7,35 +7,32 @@
     - /^coverity-tested\/.*/
     - /^stable-.*/
 
-# Test jobs
-build-each-commit-gcc:
+.arm64-test-needs: &arm64-test-needs
+  - alpine-3.12-arm64-rootfs-export
+  - kernel-5.19-arm64-export
+  - qemu-system-aarch64-6.0.0-arm64-export
+
+.arm32-test-needs: &arm32-test-needs
+  - qemu-system-aarch64-6.0.0-arm32-export
+
+.qemu-arm64:
   extends: .test-jobs-common
   variables:
-    CONTAINER: debian:stretch
-    XEN_TARGET_ARCH: x86_64
-    CC: gcc
-  script:
-    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
-    - mv ../build-each-commit-gcc.log .
+    CONTAINER: debian:unstable-arm64v8
+    LOGFILE: qemu-smoke-arm64.log
   artifacts:
     paths:
+      - smoke.serial
       - '*.log'
     when: always
-  needs: []
   tags:
-    - x86_64
+    - arm64
 
-qemu-smoke-dom0-arm64-gcc:
+.qemu-arm32:
   extends: .test-jobs-common
   variables:
     CONTAINER: debian:unstable-arm64v8
-  script:
-    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  needs:
-    - alpine-3.12-gcc-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
+    LOGFILE: qemu-smoke-arm32.log
   artifacts:
     paths:
       - smoke.serial
@@ -44,251 +41,150 @@ qemu-smoke-dom0-arm64-gcc:
   tags:
     - arm64
 
-qemu-smoke-dom0-arm64-gcc-debug:
+.qemu-x86-64:
   extends: .test-jobs-common
   variables:
-    CONTAINER: debian:unstable-arm64v8
-  script:
-    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
-  needs:
-    - alpine-3.12-gcc-debug-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
+    CONTAINER: debian:stretch
+    LOGFILE: qemu-smoke-x86-64.log
   artifacts:
     paths:
       - smoke.serial
       - '*.log'
     when: always
   tags:
-    - arm64
+    - x86_64
 
-qemu-alpine-x86_64-gcc:
+# Test jobs
+build-each-commit-gcc:
   extends: .test-jobs-common
   variables:
     CONTAINER: debian:stretch
+    XEN_TARGET_ARCH: x86_64
+    CC: gcc
   script:
-    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-x86_64.log
-  needs:
-    - alpine-3.12-gcc
-    - alpine-3.12-rootfs-export
-    - kernel-5.10.74-export
+    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
+    - mv ../build-each-commit-gcc.log .
   artifacts:
     paths:
-      - smoke.serial
       - '*.log'
     when: always
+  needs: []
   tags:
     - x86_64
 
+qemu-smoke-dom0-arm64-gcc:
+  extends: .qemu-arm64
+  script:
+    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - *arm64-test-needs
+    - alpine-3.12-gcc-arm64
+
+qemu-smoke-dom0-arm64-gcc-debug:
+  extends: .qemu-arm64
+  script:
+    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - *arm64-test-needs
+    - alpine-3.12-gcc-debug-arm64
+
 qemu-smoke-dom0less-arm64-gcc:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm64-test-needs
     - alpine-3.12-gcc-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-debug:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm64-test-needs
     - alpine-3.12-gcc-debug-arm64
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-staticmem:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm64-test-needs
     - alpine-3.12-gcc-arm64-staticmem
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-debug-staticmem:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm64-test-needs
     - alpine-3.12-gcc-debug-arm64-staticmem
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-boot-cpupools:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm64-test-needs
     - alpine-3.12-gcc-arm64-boot-cpupools
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm64
   script:
-    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
+    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm64-test-needs
     - alpine-3.12-gcc-debug-arm64-boot-cpupools
-    - alpine-3.12-arm64-rootfs-export
-    - kernel-5.19-arm64-export
-    - qemu-system-aarch64-6.0.0-arm64-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0-arm32-gcc:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm32
   script:
-    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
+    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm32-test-needs
     - debian-unstable-gcc-arm32
-    - qemu-system-aarch64-6.0.0-arm32-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
 
 qemu-smoke-dom0-arm32-gcc-debug:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:unstable-arm64v8
+  extends: .qemu-arm32
   script:
-    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
+    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
   needs:
+    - *arm32-test-needs
     - debian-unstable-gcc-arm32-debug
-    - qemu-system-aarch64-6.0.0-arm32-export
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
-  tags:
-    - arm64
+
+qemu-alpine-x86_64-gcc:
+  extends: .qemu-x86-64
+  script:
+    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee ${LOGFILE}
+  needs:
+    - alpine-3.12-gcc
+    - alpine-3.12-rootfs-export
+    - kernel-5.10.74-export
 
 qemu-smoke-x86-64-gcc:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
   needs:
     - debian-stretch-gcc-debug
-  tags:
-    - x86_64
 
 qemu-smoke-x86-64-clang:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
   needs:
     - debian-unstable-clang-debug
-  tags:
-    - x86_64
 
 qemu-smoke-x86-64-gcc-pvh:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
   needs:
     - debian-stretch-gcc-debug
-  tags:
-    - x86_64
 
 qemu-smoke-x86-64-clang-pvh:
-  extends: .test-jobs-common
-  variables:
-    CONTAINER: debian:stretch
+  extends: .qemu-x86-64
   script:
-    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
-  artifacts:
-    paths:
-      - smoke.serial
-      - '*.log'
-    when: always
+    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
   needs:
     - debian-unstable-clang-debug
-  tags:
-    - x86_64
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:05:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:05:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429730.680919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGo8-0004lT-JM; Tue, 25 Oct 2022 10:05:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429730.680919; Tue, 25 Oct 2022 10:05:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGo8-0004lM-Fk; Tue, 25 Oct 2022 10:05:16 +0000
Received: by outflank-mailman (input) for mailman id 429730;
 Tue, 25 Oct 2022 10:05:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onGo6-0004lG-C3
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:05:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onGo5-0000AT-RT; Tue, 25 Oct 2022 10:05:13 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onGo5-0007TE-KE; Tue, 25 Oct 2022 10:05:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZS/TS1dDuhJjxa8+lfSvfXqrSym1J0iXSgax/40WI5E=; b=ptnIcvQ/m8FUjypxDU9Jn5wWwT
	4VPz6kKxREWaeVvPw2OojquooIjwxpyWiIuIT0epU4E1LoD9AxvYbzYttLUAV55Nhi6qPUElcJK3L
	t3HhkYM3gvPsghbgFqLMGGp1m1D0z/7jmSs6cTIGkvxjc/XK/x5X4BZq8mxlSZboM5kA=;
Message-ID: <f20a67c5-eee0-24b7-f410-812b3302d30b@xen.org>
Date: Tue, 25 Oct 2022 11:05:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC v2 02/12] xen/arm32: head: Jump to the runtime mapping in
 enable_mmu()
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
 carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-3-julien@xen.org>
 <851b93a6-6116-2a81-f737-b7fd61d793f9@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <851b93a6-6116-2a81-f737-b7fd61d793f9@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 25/10/2022 10:45, Michal Orzel wrote:
> Hi Julien,
> 
> On 22/10/2022 17:04, Julien Grall wrote:
>>
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> At the moment, enable_mmu() will return to an address in the 1:1 mapping
>> and each path are responsible to switch to the runtime mapping.
> s/are/is/
> 
>>
>> In a follow-up patch, the behavior to switch to the runtime mapping
>> will become more complex. So to avoid more code/comment duplication,
>> move the switch in enable_mmu().
>>
>> Lastly, take the opportunity to replace load from literal pool with
>> mov_w.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   xen/arch/arm/arm32/head.S | 51 ++++++++++++++++++++++++---------------
>>   1 file changed, 31 insertions(+), 20 deletions(-)
>>
>> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
>> index a558c2a6876e..163bd6596dec 100644
>> --- a/xen/arch/arm/arm32/head.S
>> +++ b/xen/arch/arm/arm32/head.S
>> @@ -167,19 +167,12 @@ past_zImage:
>>           bl    check_cpu_mode
>>           bl    cpu_init
>>           bl    create_page_tables
>> -        bl    enable_mmu
>>
>> -        /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
>> -        ldr   r0, =primary_switched
>> -        mov   pc, r0
>> +        /* Address in the runtime mapping to jump to after the MMU is enabled */
>> +        mov_w lr, primary_switched
> We seem to still widely use ldr instead of mov_w which is faster.

This is boot code and personally I don't think the speed will be 
noticeable here.

The reason I am switching to mov_w is because we don't need to use the 
literal pool. The literal pool add other issues when you think about the 
1:1 mapping.

> It looks like a prerequisite patch to convert all occurences or something to keep in a backlog

I have some plan for that but decided to keep that outside of this series.

> 
>> +        b     enable_mmu
>> +
>>   primary_switched:
>> -        /*
>> -         * The 1:1 map may clash with other parts of the Xen virtual memory
>> -         * layout. As it is not used anymore, remove it completely to
>> -         * avoid having to worry about replacing existing mapping
>> -         * afterwards.
>> -         */
>> -        bl    remove_identity_mapping
>>           bl    setup_fixmap
>>   #ifdef CONFIG_EARLY_PRINTK
>>           /* Use a virtual address to access the UART. */
>> @@ -223,12 +216,10 @@ GLOBAL(init_secondary)
>>           bl    check_cpu_mode
>>           bl    cpu_init
>>           bl    create_page_tables
>> -        bl    enable_mmu
>> -
>>
>> -        /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */
>> -        ldr   r0, =secondary_switched
>> -        mov   pc, r0
>> +        /* Address in the runtime mapping to jump to after the MMU is enabled */
>> +        mov_w lr, secondary_switched
>> +        b     enable_mmu
>>   secondary_switched:
>>           /*
>>            * Non-boot CPUs need to move on to the proper pagetables, which were
>> @@ -523,9 +514,12 @@ virtphys_clash:
>>   ENDPROC(create_page_tables)
>>
>>   /*
>> - * Turn on the Data Cache and the MMU. The function will return on the 1:1
>> - * mapping. In other word, the caller is responsible to switch to the runtime
>> - * mapping.
>> + * Turn on the Data Cache and the MMU. The function will return
>> + * to the virtual address provided in LR (e.g. the runtime mapping).
>> + *
>> + * Inputs:
>> + *   r9 : paddr(start)
>> + *   lr : Virtual address to return to
>>    *
>>    * Clobbers r0 - r3
>>    */
>> @@ -551,7 +545,24 @@ enable_mmu:
>>           dsb                          /* Flush PTE writes and finish reads */
>>           mcr   CP32(r0, HSCTLR)       /* now paging is enabled */
>>           isb                          /* Now, flush the icache */
>> -        mov   pc, lr
>> +
>> +        /*
>> +         * The MMU is turned on and we are in the 1:1 mapping. Switch
>> +         * to the runtime mapping.
>> +         */
>> +        mov_w r0, 1f
>> +        mov   pc, r0
> Would it be possible to stop using:
> 	mov pc, reg
> in favor of using:
> 	bx reg
> 
> Some time ago I saw this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm/include/asm/assembler.h?id=6ebbf2ce437b33022d30badd49dc94d33ecfa498
> which states that bx is faster.

See above about my statement regarding fast. I don't see the benefits 
for early boot code. So I am not keen to switch to 'bx reg' here.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:13:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:13:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429737.680929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGwU-0006EF-DH; Tue, 25 Oct 2022 10:13:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429737.680929; Tue, 25 Oct 2022 10:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onGwU-0006E8-Ab; Tue, 25 Oct 2022 10:13:54 +0000
Received: by outflank-mailman (input) for mailman id 429737;
 Tue, 25 Oct 2022 10:13:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bl8Y=22=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1onGwT-0006E2-EU
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:13:53 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b9379d5e-544d-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 12:13:52 +0200 (CEST)
Received: from DB9PR02CA0007.eurprd02.prod.outlook.com (2603:10a6:10:1d9::12)
 by AS2PR08MB8877.eurprd08.prod.outlook.com (2603:10a6:20b:5e6::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 10:13:48 +0000
Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1d9:cafe::2) by DB9PR02CA0007.outlook.office365.com
 (2603:10a6:10:1d9::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Tue, 25 Oct 2022 10:13:48 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Tue, 25 Oct 2022 10:13:47 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Tue, 25 Oct 2022 10:13:47 +0000
Received: from 7972b6f66a26.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CE100BB9-C422-4F3E-BC09-D5FFE78A7D21.1; 
 Tue, 25 Oct 2022 10:13:36 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7972b6f66a26.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 10:13:35 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by AS8PR08MB9478.eurprd08.prod.outlook.com (2603:10a6:20b:5ed::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 10:13:32 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Tue, 25 Oct 2022
 10:13:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9379d5e-544d-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=iIfYR4OWj7sLhtodbdVe4ABRHH0qcrz2aU2xpPLxI+yng6s6jzGq/0nghK8jTKnPYod9DfblqFT96EmlALXLRXbvgDpX+CoVFWSxgsu1QnkNxbkJ6RXnYmh6/aN6jeA4jHYd5RzmoXGiIr7i1veKmOD0R4Lzyr0ESaLy4uJa0cbyyuUCMAzPRPUBqAYFu/za/8a/usIio1LyTIyPqflRtknZZuEotk9A7k59X+cJBDDKK/722v6+eGjV8weUovgTcT7MDlURfH/UXj4MNL+NrT4d94pnk27AidQXu51Jf6lgAO/ilTbrGFBuegIHKKm58FXzG9J/n8zn+X2SC1Bs9Q==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eV0sSax2zUI3ikKKSJM07B1czfdYOo4pkIxA8fBQML8=;
 b=LRgdbTUe7GgY/Yqclg72rokh4vQcJa8ExS8LULQhSVOGk7AYaPoez2jM7F3aiEQPIWEzmRMBHDnpBflDlHGKJzO9DLDmc5oG22c12iqB5tw5KuBeIeMYermci2MCPkthJBmi2Vt/MzaCqG3AuksIvqB6lQkh+PiDyE3aCAJHcshtsKU4WLZBzErI4n/T22A2qWDnt6FKX42RTTRq8ZEXgkhSZPPahQoHUcd0yCk9go5t5GGVC2v0b7RjwdxsORST1quErkoYUUhmUw5qBacoZvCkeLJjTOAcUB0nuLGsw2ZjTNx84E3jR7ZkehgjsmPj2GVWjMFTSoNtvcgjqJVaBA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eV0sSax2zUI3ikKKSJM07B1czfdYOo4pkIxA8fBQML8=;
 b=wYMsBjR55MUZziYUsVqgpxeAb0GT5CGPhk7/LyFEShCNtOORNk9E0eMKzjMBGxjDXNOhgplAewAxaFPJzOPnQebc/n0SxRqkkHACm74RZnrFJLflzuBbpP8IMpAhCW88NVaH4gEitmqPSn7ubQh6pPkRWMx8m2ZF6HHPPH2BgZQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: fca29d9dddb64303
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R+npQIWpKnoluMz6sqMUywKXU7YHhSFI6LIT0IM1unN9w8wvpE0ObWvwbEL4NMM7N/82KRncywgI/1GkeuIrOTBBYqyIF5AR8Gpq2AJ3EVHjJ81MYzs0cgw94K7LdtteAxLPfHI3PkO6HufuAtO/cU2C1hMVdAGyHSZOb1ePwJMXamrX82PyrRUT6oHM4ASPwcs6adiYtxV0f8WQukJ0DBajRdyRSBRFks4Le8Dj9jpDbS8E3qmrtqHOY5X5cUxOsPgaelMlLFnURd7pknOaGb1Imc5BQpBqHNFhzc7gRtug8TBEhr6hVn3UavkM3a5NC3JUt+dmdgBX5zMT1vkMnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eV0sSax2zUI3ikKKSJM07B1czfdYOo4pkIxA8fBQML8=;
 b=VFQha9um2BLcHIy+IO8GAbAflvicmR5lWP66vMzjHJFqX2riJCHUmLecp8Qz4w3nGY6IZBIIlCTiqsnmjIjbYsUd+DqNJFlgaiu5Ul+/GbztfvcmMTvvjubT9T+F6MIbgbZB6WI+zO9LKlTaSzghVLuMoEX/VpOZgGQ+lMH4pv+AdsxFa8Zc9WwEV2UbYmFgwZDvIla0RNSeLNz6Ge6SFjLpLupP0Og7V/gMsmYbUIR2LuAYrPfz8VFN6su0GjBc68OmVQcBG8i8Lm9oNR/+9+tTreNU1of2NRbPZlut3f9+/5mBvYFIBNQd+9NicDT8Yq6IG5cwI0HRX89V2aXM2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eV0sSax2zUI3ikKKSJM07B1czfdYOo4pkIxA8fBQML8=;
 b=wYMsBjR55MUZziYUsVqgpxeAb0GT5CGPhk7/LyFEShCNtOORNk9E0eMKzjMBGxjDXNOhgplAewAxaFPJzOPnQebc/n0SxRqkkHACm74RZnrFJLflzuBbpP8IMpAhCW88NVaH4gEitmqPSn7ubQh6pPkRWMx8m2ZF6HHPPH2BgZQ=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>
Subject: [v2] Proposal for deviations in static analyser findings
Thread-Topic: [v2] Proposal for deviations in static analyser findings
Thread-Index: AQHY6FpvIduyYvAcGUOy4Pq14Ntd1A==
Date: Tue, 25 Oct 2022 10:13:32 +0000
Message-ID: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|AS8PR08MB9478:EE_|DBAEUR03FT010:EE_|AS2PR08MB8877:EE_
X-MS-Office365-Filtering-Correlation-Id: 62113d1b-a306-4dcd-fb02-08dab6719b31
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ehplrCcgonZbeWWWzgWrKxJEJKqn8H7wzXARQ4IiWo72mwvwP/3zmo2H6wm9RGU9/7EGkkAwv+4BnAKPYCO8feV5r3clqCe9M6+PFXAqF4Ex4THEl7LcNbaPjnoHv8C+dDTMAAV+es8MjYjbj076h0RbsYwLVhaQATOhiuDmOsM4P9aTtGsk9EVr37EK0c6tbJX6dMBkwga1VvXQ9cwKb6l9W3VSuk1moE83/0T1g26N1hMq386CUzwV8g6q9+wt0SSuNlGipg9VWh5cL6xXSsDz/1Ziz9C9gaQDW7OJQsZRq95JEOkAXxbJXgavDus2s1i0n3yObMEvyQxxhK5NuQMacgR4YBojhKkMOTQ/76otEzbHUK1FCzuw0bA/RU50Xce1g2k32c+ltIhqpt/yNX+zpTi8KLq5jnY1bZ8vSE/q7o90vrg9/oO7YHmZVCAp50I02qGuMcRmo19wi+Eprq+p/mlyt5aonZk/4cWXudId5wm3CkAWx8gkKa+SBgMTu17R0NovoRlB+/y47DgXGSr0KcS4rPh6BZPVjsAowLKfiURvVFMjxWQrFslgoisU6zlFO0aYLnNB0JrG3BPAb5DGUD8pXhVa6Dw4MF1vsEIQRdZhuEaKvr+mK783i1jic77Z4CehVMqXEOB6VX6jyPu89yng41e+thbjL6bf5FU9LYiIMLhMxaec8Tib06iZoZTFZrbATrY2SusVvMXTay3lKw6T1r9EG70sgaCFlF8x4txsHPXg6TUySm/2FixCJCtlSb4pNLnNsItWIiV+X1fVEXSdZQOlMu/MFz9ZblMC9ql9QmO+B1+PupM+lkh7LV/eiXocidbsC4wLSywz9JlCyWMWfq52kOFSlys8NXFM+9SZGFKrC71qwwm+AeE3
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(451199015)(41300700001)(8936002)(2906002)(5660300002)(54906003)(71200400001)(64756008)(316002)(36756003)(76116006)(66446008)(6486002)(66476007)(66556008)(91956017)(66946007)(4326008)(8676002)(6916009)(86362001)(33656002)(966005)(2616005)(478600001)(186003)(38070700005)(6506007)(122000001)(38100700002)(26005)(83380400001)(6512007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <51F12D386EEC784D905507384D503834@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9478
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bc4a07b8-6c15-4aef-e031-08dab6719207
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iJErACIEAN4e4yGqG1zCrVo5KGQQxZPMuI5GfVe8X1GqgLQU6AQoPiNwuR5xSRCWCAY4M7l0qhrC8iz0MoeDxzD0LjMwWNz61B6Czlu58PZSG9aGV78Ju5Y3Zmr4exOnvj/pZLLLCud0E1TT5yuJDzlrOElBrjTAHarL98QW3qXP3cu2SkQCfudTRRLHAi0x4O+FxmP+g/1/nzLFyCYEaorKOMyEh8qcLT78Mk0skwUKWAAHJ1kCYAS+i7R4BvIkKONqT2pF1VELTbXpk3IGrhahzR+O2q523gzB1KFc6sMsfL+DqArJmpPevvh3t6ICEDI2H8DpmGUVXgranvmby973Rx5m7ZGKgIcDntptxIYkr8uW61kCZQ8BK808GDG+ajYvjGKs2tSRHmSh8o3+OqN+qFuX43x8kJHSlXWhSLPwic60Kf2Gom7xb3nr68RR3O5/lb6KlT4iC8YBUBLj+hwpKffw7GD9WmyCym/oxPLXhrBBy7woc9y4t2mQoVRCxTNvXpRy6ODxjr8NVwylO1EP8TxezDxYKEW0AlsYKed8EWYU9WTASVrP8LXGJN30hvej9A3iBYroqaG9iY/btHZ/balVlLYuGgH45UPnWStGTB9YMYQChBw9Zc5rN+qdm7BS0D+1mEqE75E7ZbP/igrOT6bwO4HPphGGN6cotlN7UiW5ACMNlxhCyvbL3ljVRy2cnQxXnq3T62UJM2bVw8upgFEyfuGvs4GJyfwLW0Dw0D3H7blNVuMffi5P/QD+vwopkH/LoK3hGfzBW4V1BbfkQW7xNNVxgr8mHU5u0Cy4cRvV8L1a6R3ATorNU9aX/VANkc/Hu+VvG8rf4Vj9qw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(40480700001)(33656002)(47076005)(54906003)(6916009)(5660300002)(41300700001)(36756003)(107886003)(40460700003)(26005)(8936002)(6512007)(336012)(316002)(36860700001)(70206006)(2906002)(4326008)(8676002)(186003)(6506007)(82310400005)(70586007)(2616005)(81166007)(356005)(966005)(6486002)(83380400001)(86362001)(82740400003)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 10:13:47.7493
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 62113d1b-a306-4dcd-fb02-08dab6719b31
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8877

SGkgYWxsLA0KDQpUaGlzIGlzIHRoZSBWMiBvZiB0aGUgcHJvcG9zYWwgZm9yIGRldmlhdGlvbnMg
dGFnZ2luZyBpbiB0aGUgWGVuIGNvZGViYXNlLCB0aGlzIGluY2x1ZGVzDQphbGwgdGhlIGZlZWRi
YWNrcyBmcm9tIHRoZSBGdVNhIHNlc3Npb24gaGVsZCBhdCB0aGUgWGVuIFN1bW1pdCAyMDIyIGFu
ZCBhbGwgdGhlDQpmZWVkYmFja3MgcmVjZWl2ZWQgaW4gdGhlIHByZXZpb3VzIHByb3Bvc2FsIHNl
bnQgb24gdGhlIG1haWxpbmcgbGlzdC4NCg0KSGVyZSBhIGxpbmsgdG8gdGhlIHByZXZpb3VzIHRo
cmVhZDogDQpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRl
dmVsLzIwMjItMTAvbXNnMDA1NDEuaHRtbA0KDQpEb2N1bWVudGluZyB2aW9sYXRpb25zDQo9PT09
PT09PT09PT09PT09PT09PT09DQoNClN0YXRpYyBhbmFseXNlcnMgYXJlIHVzZWQgb24gdGhlIFhl
biBjb2RlYmFzZSBmb3IgYm90aCBzdGF0aWMgYW5hbHlzaXMgYW5kIE1JU1JBDQpjb21wbGlhbmNl
Lg0KVGhlcmUgbWlnaHQgYmUgdGhlIG5lZWQgdG8gc3VwcHJlc3Mgc29tZSBmaW5kaW5ncyBpbnN0
ZWFkIG9mIGZpeGluZyB0aGVtIGFuZA0KbWFueSB0b29scyBwZXJtaXQgdGhlIHVzYWdlIG9mIGlu
LWNvZGUgY29tbWVudHMgdGhhdCBzdXBwcmVzcyBmaW5kaW5ncyBzbyB0aGF0DQp0aGV5IGFyZSBu
b3Qgc2hvd24gaW4gdGhlIGZpbmFsIHJlcG9ydC4NCg0KWGVuIHdpbGwgaW5jbHVkZSBhIHRvb2wg
Y2FwYWJsZSBvZiB0cmFuc2xhdGluZyBhIHNwZWNpZmljIGNvbW1lbnQgdXNlZCBpbiBpdHMNCmNv
ZGViYXNlIHRvIHRoZSByaWdodCBwcm9wcmlldGFyeSBpbi1jb2RlIGNvbW1lbnQgdW5kZXJzdGFu
ZGFibGUgYnkgdGhlIHNlbGVjdGVkDQphbmFseXNlciB0aGF0IHN1cHByZXNzIGl0cyBmaW5kaW5n
Lg0KDQpJbiB0aGUgWGVuIGNvZGViYXNlLCB0aGVzZSB0YWdzIHdpbGwgYmUgdXNlZCB0byBkb2N1
bWVudCBhbmQgc3VwcHJlc3MgZmluZGluZ3M6DQoNCi0gU0FGLVgtc2FmZTogVGhpcyB0YWcgbWVh
bnMgdGhhdCB0aGUgbmV4dCBsaW5lIG9mIGNvZGUgY29udGFpbnMgYSBmaW5kaW5nLCBidXQNCiB0
aGUgbm9uIGNvbXBsaWFuY2UgdG8gdGhlIGNoZWNrZXIgaXMgYW5hbHlzZWQgYW5kIGRlbW9uc3Ry
YXRlZCB0byBiZSBzYWZlLg0KLSBTQUYtWC1mYWxzZS1wb3NpdGl2ZS08dG9vbD46IFRoaXMgdGFn
IG1lYW5zIHRoYXQgdGhlIG5leHQgbGluZSBvZiBjb2RlIGNvbnRhaW5zIGENCiBmaW5kaW5nLCBi
dXQgdGhlIGZpbmRpbmcgaXMgYSBidWcgb2YgdGhlIHRvb2wuDQoNClNBRiBzdGFuZHMgZm9yIFN0
YXRpYyBBbmFseXNlciBGaW5kaW5nLCB0aGUgWCBpcyBhIHBsYWNlaG9sZGVyIGZvciBhIHBvc2l0
aXZlDQpudW1iZXIsIHRoZSBudW1iZXIgYWZ0ZXIgU0FGLSBzaGFsbCBiZSBpbmNyZW1lbnRhbCBh
bmQgdW5pcXVlLCBiYXNlIHRlbg0Kbm90YXRpb24gYW5kIHdpdGhvdXQgbGVhZGluZyB6ZXJvcy4N
Cg0KRW50cmllcyBpbiB0aGUgZGF0YWJhc2Ugc2hvdWxkIG5ldmVyIGJlIHJlbW92ZWQsIGV2ZW4g
aWYgdGhleSBhcmUgbm90IHVzZWQNCmFueW1vcmUgaW4gdGhlIGNvZGUgKGlmIGEgcGF0Y2ggaXMg
cmVtb3Zpbmcgb3IgbW9kaWZ5aW5nIHRoZSBmYXVsdHkgbGluZSkuDQpUaGlzIGlzIHRvIG1ha2Ug
c3VyZSB0aGF0IG51bWJlcnMgYXJlIG5vdCByZXVzZWQgd2hpY2ggY291bGQgbGVhZCB0byBjb25m
bGljdHMNCndpdGggb2xkIGJyYW5jaGVzIG9yIG1pc2xlYWRpbmcganVzdGlmaWNhdGlvbnMuDQoN
CkFuIGVudHJ5IGNhbiBiZSByZXVzZWQgaW4gbXVsdGlwbGUgcGxhY2VzIGluIHRoZSBjb2RlIHRv
IHN1cHByZXNzIGEgZmluZGluZyBpZg0KYW5kIG9ubHkgaWYgdGhlIGp1c3RpZmljYXRpb24gaG9s
ZHMgZm9yIHRoZSBzYW1lIG5vbi1jb21wbGlhbmNlIHRvIHRoZSBjb2RpbmcNCnN0YW5kYXJkLg0K
DQpBbiBvcnBoYW4gZW50cnksIHRoYXQgaXMgYW4gZW50cnkgd2hvIHdhcyBqdXN0aWZ5aW5nIGEg
ZmluZGluZyBpbiB0aGUgY29kZSwgYnV0IGxhdGVyDQp0aGF0IGNvZGUgd2FzIHJlbW92ZWQgYW5k
IHRoZXJlIGlzIG5vIG90aGVyIHVzZSBvZiB0aGF0IGVudHJ5IGluIHRoZSBjb2RlLCBjYW4gYmUN
CnJldXNlZCBhcyBsb25nIGFzIHRoZSBqdXN0aWZpY2F0aW9uIGZvciB0aGUgZmluZGluZyBob2xk
cy4gVGhpcyBpcyBkb25lIHRvIGF2b2lkIHRoZQ0KYWxsb2NhdGlvbiBvZiBhIG5ldyBlbnRyeSB3
aXRoIGV4YWN0bHkgdGhlIHNhbWUganVzdGlmaWNhdGlvbiwgdGhhdCB3b3VsZCBsZWFkIHRvIHdh
c3RlDQpvZiBzcGFjZSBhbmQgbWFpbnRlbmFuY2UgaXNzdWVzIG9mIHRoZSBkYXRhYmFzZS4NCg0K
VGhlIGZpbGVzIHdoZXJlIHRvIHN0b3JlIGFsbCB0aGUganVzdGlmaWNhdGlvbnMgYXJlIGluIHhl
bi9kb2NzL21pc3JhLyBhbmQgYXJlDQpuYW1lZCBhcyBzYWZlLmpzb24gYW5kIGZhbHNlLXBvc2l0
aXZlLTx0b29sPi5qc29uLCB0aGV5IGhhdmUgSlNPTiBmb3JtYXQsIGVudHJpZXMNCm9mIHRoZXNl
IGZpbGVzIGhhdmUgaW5kZXBlbmRlbnQgSUQgbnVtYmVyaW5nLg0KDQpIZXJlIGlzIGFuIGV4YW1w
bGUgdG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb24gaW4gc2FmZS5qc29uOjoNCg0KfHsNCnwgICAg
InZlcnNpb24iOiAiMS4wIiwNCnwgICAgImNvbnRlbnQiOiBbDQp8ICAgICAgICB7DQp8ICAgICAg
ICAgICAgImlkIjoiU0FGLTAtc2FmZSIsDQp8ICAgICAgICAgICAgImFuYWx5c2VyIjogew0KfCAg
ICAgICAgICAgICAgICAiY3BwY2hlY2siOiAibWlzcmEtYzIwMTItMjAuNyIsDQp8ICAgICAgICAg
ICAgICAgICJjb3Zlcml0eSI6ICJtaXNyYV9jXzIwMTJfcnVsZV8yMF83X3Zpb2xhdGlvbiIsDQp8
ICAgICAgICAgICAgICAgICJlY2xhaXIiOiAiTUMzUjEuUjIwLjciDQp8ICAgICAgICAgICAgfSwN
CnwgICAgICAgICAgICAibmFtZSI6IOKAnFIyMC43IEMgbWFjcm8gcGFyYW1ldGVycyBub3QgdXNl
ZCBhcyBleHByZXNzaW9uIiwNCnwgICAgICAgICAgICAidGV4dCI6ICJUaGUgbWFjcm8gcGFyYW1l
dGVycyB1c2VkIGluIHRoaXMgW+KApl0iDQp8ICAgICAgICB9LA0KfCAgICAgICAgew0KfCAgICAg
ICAgICAgICJpZCI64oCdU0FGLTEtc2FmZSIsDQp8ICAgICAgICAgICAgImFuYWx5c2VyIjogew0K
fCAgICAgICAgICAgICAgICAiY3BwY2hlY2siOiAidW5yZWFkVmFyaWFibGUiLA0KfCAgICAgICAg
ICAgICAgICAiY292ZXJpdHkiOiAiVU5VU0VEX1ZBTFVFIg0KfCAgICAgICAgICAgIH0sDQp8ICAg
ICAgICAgICAgIm5hbWUiOiDigJxWYXJpYWJsZSBzZXQgYnV0IG5vdCB1c2VkIiwNCnwgICAgICAg
ICAgICAidGV4dCI6IOKAnEl0IGlzIHNhZmUgYmVjYXVzZSBb4oCmXSINCnwgICAgICAgIH0sDQp8
ICAgICAgICB7DQp8ICAgICAgICAgICAgImlkIjrigJ1TQUYtMi1zYWZlIiwNCnwgICAgICAgICAg
ICAiYW5hbHlzZXIiOiB7fSwNCnwgICAgICAgICAgICAibmFtZSI6ICJTZW50aW5lbCIsDQp8ICAg
ICAgICAgICAgInRleHQiOiAiIg0KfCAgICAgICAgfQ0KfCAgICBdDQp8fQ0KDQpIZXJlIGlzIGFu
IGV4YW1wbGUgdG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb24gaW4gZmFsc2UtcG9zaXRpdmUtY3Bw
Y2hlY2suanNvbjo6DQoNCnx7DQp8ICAgICJ2ZXJzaW9uIjogIjEuMCIsDQp8ICAgICJjb250ZW50
IjogWw0KfCAgICAgICAgew0KfCAgICAgICAgICAgICJpZCI6IlNBRi0wLWZhbHNlLXBvc2l0aXZl
LWNwcGNoZWNrIiwNCnwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQp8ICAgICAgICAgICAgICAg
ICJjcHBjaGVjayI6ICJtaXNyYS1jMjAxMi0yMC43Ig0KfCAgICAgICAgICAgIH0sDQp8ICAgICAg
ICAgICAg4oCcdG9vbC12ZXJzaW9u4oCdOiDigJwyLjciLA0KfCAgICAgICAgICAgICJuYW1lIjog
4oCcUjIwLjcgc2Vjb25kIG9wZXJhbmQgb2YgbWVtYmVyLWFjY2VzcyBvcGVyYXRvciIsDQp8ICAg
ICAgICAgICAgInRleHQiOiAiVGhlIHNlY29uZCBvcGVyYW5kIG9mIGEgbWVtYmVyIGFjY2VzcyBv
cGVyYXRvciBzaGFsbCBiZSBhIG5hbWUgb2YgYSBtZW1iZXIgb2YgdGhlIHR5cGUgcG9pbnRlZCB0
bywgc28gaW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UgaXQgaXMgd3JvbmcgdG8gdXNlIHBhcmVudGhl
c2VzIG9uIHRoZSBtYWNybyBwYXJhbWV0ZXIuIg0KfCAgICAgICAgfSwNCnwgICAgICAgIHsNCnwg
ICAgICAgICAgICAiaWQiOuKAnVNBRi0xLWZhbHNlLXBvc2l0aXZlLWNwcGNoZWNrIiwNCnwgICAg
ICAgICAgICAiYW5hbHlzZXIiOiB7fSwNCnwgICAgICAgICAgICDigJx0b29sLXZlcnNpb27igJ06
IOKAnCIsDQp8ICAgICAgICAgICAgIm5hbWUiOiAiU2VudGluZWwiLA0KfCAgICAgICAgICAgICJ0
ZXh0IjogIiINCnwgICAgICAgIH0NCnwgICAgXQ0KfH0NCg0KVG8gZG9jdW1lbnQgYSBmaW5kaW5n
LCBqdXN0IGFkZCBhbm90aGVyIGJsb2NrIHtbLi4uXX0gYmVmb3JlIHRoZSBzZW50aW5lbCBibG9j
aywNCnVzaW5nIHRoZSBpZCBjb250YWluZWQgaW4gdGhlIHNlbnRpbmVsIGJsb2NrIGFuZCBpbmNy
ZW1lbnQgYnkgb25lIHRoZSBudW1iZXINCmNvbnRhaW5lZCBpbiB0aGUgaWQgb2YgdGhlIHNlbnRp
bmVsIGJsb2NrLg0KDQpIZXJlIGEgYnJpZWYgZXhwbGFuYXRpb24gb2YgdGhlIGZpZWxkIGluc2lk
ZSBhbiBvYmplY3Qgb2YgdGhlICJjb250ZW50IiBhcnJheToNCi0gaWQ6IGl0IGlzIGEgdW5pcXVl
IHN0cmluZyB0aGF0IGlzIHVzZWQgdG8gcmVmZXIgdG8gdGhlIGZpbmRpbmcsIG1hbnkgZmluZGlu
Zw0KIGNhbiBiZSB0YWdnZWQgd2l0aCB0aGUgc2FtZSBpZCwgaWYgdGhlIGp1c3RpZmljYXRpb24g
aG9sZHMgZm9yIGFueSBhcHBsaWVkDQogY2FzZS4NCiBJdCB0ZWxscyB0aGUgdG9vbCB0byBzdWJz
dGl0dXRlIGEgWGVuIGluLWNvZGUgY29tbWVudCBoYXZpbmcgdGhpcyBzdHJ1Y3R1cmU6DQogLyog
U0FGLTAtc2FmZSBbLi4uXSBcKi8NCi0gYW5hbHlzZXI6IGl0IGlzIGFuIG9iamVjdCBjb250YWlu
aW5nIHBhaXIgb2Yga2V5LXZhbHVlIHN0cmluZ3MsIHRoZSBrZXkgaXMNCiB0aGUgYW5hbHlzZXIs
IHNvIGl0IGNhbiBiZSBjcHBjaGVjaywgY292ZXJpdHkgb3IgZWNsYWlyLiBUaGUgdmFsdWUgaXMg
dGhlDQogcHJvcHJpZXRhcnkgaWQgY29ycmVzcG9uZGluZyBvbiB0aGUgZmluZGluZywgZm9yIGV4
YW1wbGUgd2hlbiBjb3Zlcml0eSBpcw0KIHVzZWQgYXMgYW5hbHlzZXIsIHRoZSB0b29sIHdpbGwg
dHJhbnNsYXRlIHRoZSBYZW4gaW4tY29kZSBjb21lbnQgaW4gdGhpcyB3YXk6DQogLyogU0FGLTAt
c2FmZSBbLi4uXSBcKi8gLT4gLyogY292ZXJpdHlbY292ZXJpdHktaWRdIFwqLw0KIGlmIHRoZSBv
YmplY3QgZG9lc24ndCBoYXZlIGEga2V5LXZhbHVlLCB0aGVuIHRoZSBjb3JyZXNwb25kaW5nIGlu
LWNvZGUNCiBjb21tZW50IHdvbid0IGJlIHRyYW5zbGF0ZWQuDQotIG5hbWU6IGEgc2ltcGxlIG5h
bWUgZm9yIHRoZSBmaW5kaW5nDQotIHRleHQ6IGEgcHJvcGVyIGp1c3RpZmljYXRpb24gdG8gdHVy
biBvZmYgdGhlIGZpbmRpbmcuDQoNCg0KDQpIZXJlIGFuIGV4YW1wbGUgb2YgdGhlIHVzYWdlIG9m
IHRoZSBpbi1jb2RlIGNvbW1lbnQgdGFncyB0byBzdXBwcmVzcyBhIGZpbmRpbmcgZm9yIHRoZSBS
dWxlIDguNjoNCg0KRWNsYWlyIHJlcG9ydHMgaXQgaGVyZToNCmh0dHBzOi8vZWNsYWlyaXQuY29t
OjM3ODcvZnMvdmFyL2xpYi9qZW5raW5zL2pvYnMvWEVOL2NvbmZpZ3VyYXRpb25zL2F4aXMtVGFy
Z2V0L0FSTTY0L2F4aXMtYWdlbnQvcHVibGljL2J1aWxkcy81NDkvYXJjaGl2ZS9FQ0xBSVIvb3V0
L1BST0pFQ1QuZWNkOy9zb3VyY2VzL3hlbi9pbmNsdWRlL3hlbi9rZXJuZWwuaC5odG1sI1I1MDc0
M18xDQoNCkFsc28gY292ZXJpdHkgcmVwb3J0cyBpdCwgaGVyZSBhbiBleHRyYWN0IG9mIHRoZSBm
aW5kaW5nOg0KDQp4ZW4vaW5jbHVkZS94ZW4va2VybmVsLmg6Njg6DQogMS4gbWlzcmFfY18yMDEy
X3J1bGVfOF82X3Zpb2xhdGlvbjogRnVuY3Rpb24gIl9zdGFydCIgaXMgZGVjbGFyZWQgYnV0IG5l
dmVyIGRlZmluZWQuDQoNClRoZSBhbmFseXNlcnMgYXJlIGNvbXBsYWluaW5nIGJlY2F1c2Ugd2Ug
aGF2ZSB0aGlzIGluIHhlbi9pbmNsdWRlL3hlbi9rZXJuZWwuaCBhdCBsaW5lIDY4Og0KDQpleHRl
cm4gY2hhciBfc3RhcnRbXSwgX2VuZFtdLCBzdGFydFtdOw0KDQpUaG9zZSBhcmUgc3ltYm9scyBl
eHBvcnRlZCBieSB0aGUgbGlua2VyLCBoZW5jZSB3ZSB3aWxsIG5lZWQgdG8gaGF2ZSBhIHByb3Bl
ciBkZXZpYXRpb24gZm9yIHRoaXMgZmluZGluZy4NCg0KV2Ugd2lsbCBwcmVwYXJlIG91ciBlbnRy
eSBpbiB0aGUgZGF0YWJhc2U6DQoNCnx7DQp8ICAgICJ2ZXJzaW9uIjogIjEuMCIsDQp8ICAgICJj
b250ZW50IjogWw0KfCAgICAgICAgew0KfCAgICAgICAgW+KApl0NCnwgICAgICAgIH0sDQp8ICAg
ICAgICB7DQp8ICAgICAgICAgICAgImlkIjrigJ1TQUYtMS1zYWZlIiwNCnwgICAgICAgICAgICAi
YW5hbHlzZXIiOiB7DQp8ICAgICAgICAgICAgICAgIOKAnGVjbGFpciI6ICJNQzNSMS5SOC42IiwN
CnwgICAgICAgICAgICAgICAgImNvdmVyaXR5IjogIm1pc3JhX2NfMjAxMl9ydWxlXzhfNl92aW9s
YXRpb24iDQp8ICAgICAgICAgICAgfSwNCnwgICAgICAgICAgICAibmFtZSI6IOKAnFJ1bGUgOC42
OiBsaW5rZXIgZGVmaW5lZCBzeW1ib2xzIiwNCnwgICAgICAgICAgICAidGV4dCI6IOKAnEl0IGlz
IHNhZmUgdG8gZGVjbGFyZSB0aGlzIHN5bWJvbCBiZWNhdXNlIGl0IGlzIGRlZmluZWQgaW4gdGhl
IGxpbmtlciBzY3JpcHQuIg0KfCAgICAgICAgfSwNCnwgICAgICAgIHsNCnwgICAgICAgICAgICAi
aWQiOuKAnVNBRi0yLXNhZmUiLA0KfCAgICAgICAgICAgICJhbmFseXNlciI6IHt9LA0KfCAgICAg
ICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCnwgICAgICAgICAgICAidGV4dCI6ICIiDQp8ICAg
ICAgICB9DQp8ICAgIF0NCnx9DQoNCkFuZCB3ZSB3aWxsIHVzZSB0aGUgcHJvcGVyIHRhZyBhYm92
ZSB0aGUgdmlvbGF0aW9uIGxpbmU6DQoNCi8qIFNBRi0xLXNhZmUgW29wdGlvbmFsIHRleHRdICov
DQpleHRlcm4gY2hhciBfc3RhcnRbXSwgX2VuZFtdLCBzdGFydFtdOw0KDQpUaGlzIGVudHJ5IHdp
bGwgZml4IGFsc28gdGhlIHZpb2xhdGlvbiBvbiBfZW5kIGFuZCBzdGFydCwgYmVjYXVzZSB0aGV5
IGFyZSBvbiB0aGUgc2FtZSBsaW5lIGFuZCB0aGUNCnNhbWUg4oCcdmlvbGF0aW9uIElE4oCdLg0K
DQpBbHNvLCB0aGUgc2FtZSB0YWcgY2FuIGJlIHVzZWQgb24gb3RoZXIgc3ltYm9scyBmcm9tIHRo
ZSBsaW5rZXIgdGhhdCBhcmUgZGVjbGFyZWQgaW4gdGhlIGNvZGViYXNlLA0KYmVjYXVzZSB0aGUg
anVzdGlmaWNhdGlvbiBob2xkcyBmb3IgdGhlbSB0b28uDQoNCkNoZWVycywNCkx1Y2E=


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:31:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429746.680940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHDW-0000PL-W7; Tue, 25 Oct 2022 10:31:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429746.680940; Tue, 25 Oct 2022 10:31:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHDW-0000PE-TP; Tue, 25 Oct 2022 10:31:30 +0000
Received: by outflank-mailman (input) for mailman id 429746;
 Tue, 25 Oct 2022 10:31:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onHDV-0000P8-5d
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:31:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onHDU-0000d2-Mb; Tue, 25 Oct 2022 10:31:28 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onHDU-0008Oy-Eb; Tue, 25 Oct 2022 10:31:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=eDvmERsrdkCPddUZ49r4L0o0AtvEp/zPiu9eiteNEEI=; b=VMHOAAzC1gl/agBd5eAvA2GaXf
	MppW3PkqVqZol6G12BzZgG77dVTXJL4TdyH1SLOtvf9twYPdRqA7C4C2/dQu9PFIVq/BHXPeVkykO
	8HH+4jLTUo9NqpJ1RQRnVSsdAmWoFE3GcUehY08NA44bbLX+2esC+qe2EQ6dZ9KrkN8c=;
Message-ID: <dffca6a6-3a7c-a8ea-b61e-a37011a7afb8@xen.org>
Date: Tue, 25 Oct 2022 11:31:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
 carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-2-julien@xen.org>
 <c5767718-bb00-da6b-8623-1bcb6c832f85@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <c5767718-bb00-da6b-8623-1bcb6c832f85@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 25/10/2022 10:21, Michal Orzel wrote:
> Hi Julien,

Hi Michal,


> On 22/10/2022 17:04, Julien Grall wrote:
>>
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> In a follow-up patch, the base address for the common mappings will
>> vary between arm32 and arm64. To avoid any duplication, define
>> every mapping in the common region from the previous one.
> Maybe the following title would be better suited if you only want to touch the common mappings?
> "xen/arm: Clean-up the common memory layout"

Ok.

> 
>>
>> Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
>> XEN_VIRT_*.
>>
>> Take the opportunity to add missing *_SIZE for some mappings.
> I think this sentence can be removed as the previous one already covers it.

Yes. I will remove it.

> 
> Apart from that, wouldn't it be useful to do the cleanup for the arm32 macros
> as you are here (FRAMETABLE, VMAP, {XEN/DOM}HEAP) ?

Can you clarify? I looked at the macros and they look clean to me.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:37:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:37:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429750.680952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHIr-0001Ah-Lx; Tue, 25 Oct 2022 10:37:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429750.680952; Tue, 25 Oct 2022 10:37:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHIr-0001Aa-Hg; Tue, 25 Oct 2022 10:37:01 +0000
Received: by outflank-mailman (input) for mailman id 429750;
 Tue, 25 Oct 2022 10:37:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=N5aB=22=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onHIp-00019j-SS
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:37:00 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2080.outbound.protection.outlook.com [40.107.95.80])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f04cf852-5450-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 12:36:53 +0200 (CEST)
Received: from BN8PR04CA0050.namprd04.prod.outlook.com (2603:10b6:408:d4::24)
 by MW4PR12MB7144.namprd12.prod.outlook.com (2603:10b6:303:21b::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Tue, 25 Oct
 2022 10:36:55 +0000
Received: from BN8NAM11FT044.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:d4:cafe::6e) by BN8PR04CA0050.outlook.office365.com
 (2603:10b6:408:d4::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 10:36:55 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT044.mail.protection.outlook.com (10.13.177.219) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 10:36:54 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 05:36:53 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct
 2022 05:36:54 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Tue, 25 Oct 2022 05:36:52 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f04cf852-5450-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HfGwHwAnWciat03q37/6kpViCGv3Eg82hcMMo80muUpHe++RkGwuAKLmxzy6QpcxxdwbLYZIDFPyKk7rJIjcxTUvdhKL7HYOMg0dTahMde4eqyRb5duc38T13qU4F6r5Fq66/OvLGpaJV7R+op6q20SEZvEXm3PiPqcpW1hnF6vVlXqbeY4qp685J8Kgk8XShScyA+0BWT4iitO753NHXQ3WqwpfN4caR8Mstil+7QVgqx4rWCgkMKHoOXrSOlUCQUZBVuRHzMwaC7Lkne7FNtZIqVhBEUFnolRffU51QU5TFSz389CZLr5Z/bw0nJqaQByztbNgDbH9mhNTQNf9sA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZGoark6TZWjz1isot1pXlfv0JBfkzgQTYqdynlWpawI=;
 b=f9VJi/V0PqhOJfbgBSNnNGQ7MWehkthtXSbKZP+iigtZ8hsqJEHAO0azqdvDE++MRV89FH9A+2txR5eRHw4nv0PVx1CKNIk+txCDpQdpdMrgu4SPLJ+lO8qM2Xok3ajOufoW16pDAkpn3gr6FLZU/6wF/zXtG/p+xWFaQ9zfhyQp4R0PVsLniijyq0T1dE94zebVaY5uUXdF6BfSoAyhWC3qnjsCZNwexAWyZPMBvs4tVkkHKQTW23Bx/aY39DuMgA+JW0S5soJQfOUMmnGWYy6XEtUnbK7ucApNavnylsPqn/CMC55/tAzpWeY9KINRiuDtVzmtI3FnWqSLArmWzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZGoark6TZWjz1isot1pXlfv0JBfkzgQTYqdynlWpawI=;
 b=DhYk6MZFwxpk40C7OgLb2ix3aGBqNCjjH1XxNH8hT9b1lnKVQ2pB3dGoLrzwBY5ZX3CeVrZjhGgizqzAIvEDDM+77lvuNHU+LeKn2X1DXPnweetmo5CxbVhLAI0zD1F6AzMo4k6xV98jrZwkdwCHLsg2ZAjrlhSKTKDCrlhOWW4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <906f4f04-4c06-8e93-1c4f-90be7d508f44@amd.com>
Date: Tue, 25 Oct 2022 12:36:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Content-Language: en-US
To: Julien Grall <julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: <marco.solieri@minervasys.tech>, <lucmiccio@gmail.com>,
	<carlo.nonato@minervasys.tech>, Julien Grall <jgrall@amazon.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-2-julien@xen.org>
 <c5767718-bb00-da6b-8623-1bcb6c832f85@amd.com>
 <dffca6a6-3a7c-a8ea-b61e-a37011a7afb8@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <dffca6a6-3a7c-a8ea-b61e-a37011a7afb8@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT044:EE_|MW4PR12MB7144:EE_
X-MS-Office365-Filtering-Correlation-Id: 561d0049-dc0e-4ae2-bcda-08dab674d5f2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ss++87Ok/hXIEtnsSXze9SQByWhwM1GOGmCTZZF19B+x5+tcltiQcvrwAw3CvcEZAsAKukVyQZJWh1rhEEZ7DSvXHt25pe3avEcuUsZvhfwQdz4ExyZFudGyCSaV2s6UTBjlZ6iIa2BVOqBTyKdAEk8XseWCHI+5esvjQDsJ0hvEtEuKfbKST49d859sMNxFUOMZIZ5obZ0GkkS29NEy/D+eNQqj1bgqH1ys+KM3dQUqP0dJFlTXv0bdp2KwmBLIASmB1QYJv9k5wM8J1/H0xTizcGtLsYtVSDrq52HtvFfDhO6FQXhVImyCk/xlIDLLEhFPcjH4ZEqD3bo5dGHpkz4s21Oq53CN24JjvUC3YltULCCg2ci/UjwBQ0sqj7AHHpDs6IFu7e2bpJRdhV5DxTRvqY+El6+MPAwaxxIYl0Pqh1OsJoe2MW6DzB4/0qHb4LblTZLW/qyrbXKJz3y+iAf3eYG379e77v+FrtCYDp2ZcMpmc1gjX8yhjtvor4IiN9e1OvT0Km93YTe9IYHwJv8MB8fFey8pqfo1yK6dsFgJUpfdGpebgjqMkiNqusZh+ypwi/EtnbQaBfmVCNAF8RrtWFe4hzmAmzKqcKjSim4zdu/aP8W/8S6oykkZ0u4gMZKFRyKG1OW6iRDB7UTuV6k49kRsnPC1L1VuOMVJbRt6uHOmaT7IJeiyBSsQDXYuEnc0h0O/NQaluA/OIAvNYVGBfkQE5BlHKwLmdPTCZktOEcMrwG7KZ7mClSNzVG0cKkt5PZukoxjHPAyeqwvF2HTKfkXjE+OGC3zAMwwyK7/654gmtAnv4Jw5CPFKckH1fFSVCkjAJkyc65SLQVbQJw==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(31686004)(82740400003)(44832011)(8936002)(5660300002)(186003)(2906002)(426003)(83380400001)(336012)(47076005)(31696002)(86362001)(356005)(81166007)(26005)(110136005)(16576012)(53546011)(478600001)(40460700003)(2616005)(54906003)(4326008)(316002)(40480700001)(36860700001)(70206006)(8676002)(41300700001)(82310400005)(6666004)(70586007)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 10:36:54.7794
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 561d0049-dc0e-4ae2-bcda-08dab674d5f2
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT044.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7144

Hi,

On 25/10/2022 12:31, Julien Grall wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On 25/10/2022 10:21, Michal Orzel wrote:
>> Hi Julien,
> 
> Hi Michal,
> 
> 
>> On 22/10/2022 17:04, Julien Grall wrote:
>>>
>>>
>>> From: Julien Grall <jgrall@amazon.com>
>>>
>>> In a follow-up patch, the base address for the common mappings will
>>> vary between arm32 and arm64. To avoid any duplication, define
>>> every mapping in the common region from the previous one.
>> Maybe the following title would be better suited if you only want to touch the common mappings?
>> "xen/arm: Clean-up the common memory layout"
> 
> Ok.
> 
>>
>>>
>>> Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
>>> XEN_VIRT_*.
>>>
>>> Take the opportunity to add missing *_SIZE for some mappings.
>> I think this sentence can be removed as the previous one already covers it.
> 
> Yes. I will remove it.
> 
>>
>> Apart from that, wouldn't it be useful to do the cleanup for the arm32 macros
>> as you are here (FRAMETABLE, VMAP, {XEN/DOM}HEAP) ?
> 
> Can you clarify? I looked at the macros and they look clean to me.
> 
As you choose to make use of MB() macro, I think it would be beneficial
just from the consistency perspective to modify other places that use directly hex values.
We already do that for arm64 specific mappings, you are modifying the common ones
to adhere to this way, so as a natural consequence I would see the arm32 ones to be modified as well.

> Cheers,
> 
> --
> Julien Grall

~Michal


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:41:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:41:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429759.680969 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHNc-0002a3-9B; Tue, 25 Oct 2022 10:41:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429759.680969; Tue, 25 Oct 2022 10:41:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHNc-0002Zw-6F; Tue, 25 Oct 2022 10:41:56 +0000
Received: by outflank-mailman (input) for mailman id 429759;
 Tue, 25 Oct 2022 10:41:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onHNa-0002Zq-EM
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:41:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onHNa-0000pN-00; Tue, 25 Oct 2022 10:41:54 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onHNZ-0000X5-Oy; Tue, 25 Oct 2022 10:41:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=MF7mZZqvUSt1xgfJMx8Q3rZOLHgmvVGqPVadGreRhXU=; b=Py1xWnmSWQ/79CFZOmLPMI9lPZ
	ZlZyYsSAfee+EnqJpD8Q/d4ruwXR7CEwLGofkEc3UCjOwZAb88Dx0PwiSiqjKPgpMmrkNbgGLa2Ml
	q1NhP51VEP78cEhciGqvWXHLVZQjd5QDLkBhz+5eZmqHJ8PWwNMnz+gOZ8jlbCbllWx8=;
Message-ID: <06307d61-83b7-a01e-8782-0cf9976c5be6@xen.org>
Date: Tue, 25 Oct 2022 11:41:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC v2 03/12] xen/arm32: head: Introduce an helper to flush the
 TLBs
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
 carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-4-julien@xen.org>
 <f50c3f5c-fa71-3963-d95a-d48fe801ad9e@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f50c3f5c-fa71-3963-d95a-d48fe801ad9e@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 25/10/2022 10:53, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> On 22/10/2022 17:04, Julien Grall wrote:
>>
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The sequence for flushing the TLBs is 4 instruction long and often
>> require an explanation how it works.
> s/require/requires/

Will fix it.

> 
>>
>> So create an helper and use it in the boot code (switch_ttbr() is left
>> alone for now).
>>
>> Note that in secondary_switched, we were also flushing the instruction
>> cache and branch predictor. Neither of them was necessary because:
>>      * We are only supporting IVIPT cache on arm32, so the instruction
>>        cache flush is only necessary when executable code is modified.
>>        None of the boot code is doing that.
>>      * The instruction cache is not invalidated and misprediction is not
>>        a problem at boot.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>> ---
>>   xen/arch/arm/arm32/head.S | 31 ++++++++++++++++++-------------
>>   1 file changed, 18 insertions(+), 13 deletions(-)
>>
>> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
>> index 163bd6596dec..aeaa8d105aeb 100644
>> --- a/xen/arch/arm/arm32/head.S
>> +++ b/xen/arch/arm/arm32/head.S
>> @@ -66,6 +66,21 @@
>>           add   \rb, \rb, r10
>>   .endm
>>
>> +/*
>> + * Flush local TLBs
>> + *
>> + * tmp1:    Scratch register
> I would love to adhere to the way of describing macro params like you did in mov_w. This would mean:
> @tmp: scratch register

ok.

> 
> Apart from that, the change looks ok.
> 
> Question on the side:
> Why do we use nshst in assembly and ishst in TLB helper macro? > Is it because the latter is also used to flush the inner TLBs whereas 
the former only local ones?

nshst is sufficient for local TLBs flush.

The *_local helpers could also use 'nshst' but when they were introduced 
it wasn't clear whether 'nshst' was enough. I only got the confirmation 
after and never took the opportunity to update the code.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 10:53:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 10:53:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429766.680980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHYt-0004Br-Au; Tue, 25 Oct 2022 10:53:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429766.680980; Tue, 25 Oct 2022 10:53:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHYt-0004Bk-8A; Tue, 25 Oct 2022 10:53:35 +0000
Received: by outflank-mailman (input) for mailman id 429766;
 Tue, 25 Oct 2022 10:53:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/6Q6=22=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1onHYr-0004Be-T6
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 10:53:34 +0000
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
 [2a00:1450:4864:20::536])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43f8819d-5453-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 12:53:31 +0200 (CEST)
Received: by mail-ed1-x536.google.com with SMTP id t15so889523edd.4
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 03:53:31 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43f8819d-5453-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=6cK4YnN8c5MzhKZLWqtmaFyl9yTbv5l1WkvHjsdMUD8=;
        b=PQm9JAhM4PrVc/5dAz+Y1u13UWHdXYFwTtayF5Qsuljn4QUSykWpkMacKENAHzB9Uq
         DH6Wh2oCQX2B3jONl+zScXjdndcjQsUIRynwPI91e4hypPrDAAOk3hJQ7MITlNjAhn2T
         C6wGvt09Sb+WPlQpFV5JdMHMZGzswZ9gUN5YjVJpy+oJcnt/Ai05jYeUoUO5cPZui6LO
         B/1ZmWh5nsezfbO/BGijdG4/8dHlJUGRSIGHilocru/U+9zk2mD/b5HY9eryHodcoCiK
         zi9B7z2T/odDei1L4MXOeGrV+DEh1PKZZ52HqrrK7Gf6leIB6zbIQwwdDDYG9UqyZUXw
         4thg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=6cK4YnN8c5MzhKZLWqtmaFyl9yTbv5l1WkvHjsdMUD8=;
        b=OB91LNsAeAHVNDRwSj8PHAIROwrm88DZL3K4OfGrWQabEfRRbhiMloQxQIrhSa3ejq
         6IjlulsYcD0V+dxNQyo07EK5So7/X+PN79D8BuOs5A/UevjithLO3zM4zWgeW1aR5wYO
         yaMMFnr/dE74LhezJtOXubVPqhLwc07+G3n9JM0kZVHldPCFu7kzLaeKmZlZOfXzs0oE
         NGelPECs62uNHQHe7RRyu7oGhhmLSbLo3LZkuG7VqilXYfEiv7V/CVVbcjnXVXO2jB0o
         RNH0ZQyeMvjoX4xGRt1SGdasmsQ8dKgkCeK4vNk1uJ+DI10Q2KG2xqPr75RjPl4s1bNP
         iXOg==
X-Gm-Message-State: ACrzQf07zdQeX/0qMkiMbR8PpBAH6voOHwdYGF9kElrBinnM1JPlW+oN
	fmNzvvcp0WoZWSUD33sx+aLNp/BRgQ1cpLVs1azBGQ==
X-Google-Smtp-Source: AMsMyM4Dzt4MyzfLCXZoPMKWXIXVHc7Vnl8FbN676vjk72fNtlHO+AjT1wjsRtHQQt+opWILAlQtVVLG2qH9TAiG/QI=
X-Received: by 2002:a05:6402:2211:b0:461:5d0a:6678 with SMTP id
 cq17-20020a056402221100b004615d0a6678mr18790838edb.378.1666695211346; Tue, 25
 Oct 2022 03:53:31 -0700 (PDT)
MIME-Version: 1.0
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-3-carlo.nonato@minervasys.tech> <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org>
In-Reply-To: <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org>
From: Carlo Nonato <carlo.nonato@minervasys.tech>
Date: Tue, 25 Oct 2022 12:53:20 +0200
Message-ID: <CAG+AhRUT75hkaLZi0v0E_ozzyUY9QLHYGTamhXAoKfV2gZMwfg@mail.gmail.com>
Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, 
	stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it, 
	andrea.bastoni@minervasys.tech, lucmiccio@gmail.com, 
	Marco Solieri <marco.solieri@minervasys.tech>
Content-Type: text/plain; charset="UTF-8"

Hi Julien,

On Fri, Oct 21, 2022 at 8:02 PM Julien Grall <julien@xen.org> wrote:
>
> Hi Carlo,
>
> On 26/08/2022 13:51, Carlo Nonato wrote:
> > This commit adds array pointers to domains as well as to the hypercall
> > and configuration structure employed in domain creation. The latter is used
> > both by the toolstack and by Xen itself to pass configuration data to the
> > domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be
> > able to access guest memory in the first case. This implies special care for
> > the copy of the configuration data into the domain data, meaning that a
> > discrimination variable for the two possible code paths (coming from Xen or
> > from the toolstack) is needed.
>
> So this means that a toolstack could set from_guest. I know the
> toolstack is trusted... However, we should try to limit when the trust
> when this is possible.
>
> In this case, I would consider to modify the prototype of
> domain_create() to pass internal information.

Doing as you said isn't a bit too invasive? I should also change all the call
sites of domain_create() and this means x86 too.
Isn't there an easier way to spot a guest address? Maybe just looking at the
address value... Or maybe adding an internal flag to the do_domctl() path.

> > The initialization and free functions for colored domains are also added.
> > The former is responsible for allocating and populating the color array
> > of the domain and it also checks for configuration issues. One of those
> > issues is enabling both coloring and directmap for the domain because they
> > contradicts one another. Since that, Dom0 must not be created with the
> > directmap flag.
> > The latter instead frees allocated memory.
> >
> > Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> > Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> > ---
> >   docs/misc/arm/cache-coloring.rst    |  7 ++--
> >   xen/arch/arm/coloring.c             | 56 +++++++++++++++++++++++++++++
> >   xen/arch/arm/domain.c               | 11 ++++++
> >   xen/arch/arm/domain_build.c         | 13 +++++--
> >   xen/arch/arm/include/asm/coloring.h |  7 ++++
> >   xen/arch/arm/include/asm/domain.h   |  4 +++
> >   xen/include/public/arch-arm.h       |  8 +++++
> >   7 files changed, 102 insertions(+), 4 deletions(-)
> >
> > diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
> > index c7adcb0f1f..345d97cb56 100644
> > --- a/docs/misc/arm/cache-coloring.rst
> > +++ b/docs/misc/arm/cache-coloring.rst
> > @@ -13,7 +13,7 @@ In order to enable and use it, few steps are needed.
> >     (refer to menuconfig help for value meaning and when it should be changed).
> >
> >           CONFIG_MAX_CACHE_COLORS=<n>
> > -- Assign colors to Dom0 using the `Color selection format`_ (see
> > +- Assign colors to domains using the `Color selection format`_ (see
> >     `Coloring parameters`_ for more documentation pointers).
> >
> >   Background
> > @@ -109,4 +109,7 @@ Coloring parameters
> >
> >   LLC way size (as previously discussed) and Dom0 colors can be set using the
> >   appropriate command line parameters. See the relevant documentation in
> > -"docs/misc/xen-command-line.pandoc".
> > \ No newline at end of file
> > +"docs/misc/xen-command-line.pandoc".
> > +
> > +Note that if no color configuration is provided for domains, they fallback to
> > +the default one, which corresponds simply to all available colors.
> > \ No newline at end of file
> > diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
> > index c010ebc01b..2b37cda067 100644
> > --- a/xen/arch/arm/coloring.c
> > +++ b/xen/arch/arm/coloring.c
> > @@ -22,6 +22,7 @@
> >    * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> >    */
> >   #include <xen/errno.h>
> > +#include <xen/guest_access.h>
> >   #include <xen/keyhandler.h>
> >   #include <xen/param.h>
> >   #include <xen/types.h>
> > @@ -211,6 +212,61 @@ bool __init coloring_init(void)
> >       return true;
> >   }
> >
> > +int domain_coloring_init(struct domain *d,
> > +                         const struct xen_arch_domainconfig *config)
> > +{
> > +    if ( is_domain_direct_mapped(d) )
> > +    {
> > +        printk(XENLOG_ERR
> > +               "Can't enable coloring and directmap at the same time for %pd\n",
> > +               d);
> > +        return -EINVAL;
> > +    }
> > +
> > +    if ( is_hardware_domain(d) )
> > +    {
> > +        d->arch.colors = dom0_colors;
> > +        d->arch.num_colors = dom0_num_colors;
> > +    }
>
> I think it would be better if we allocate an array also for the HW
> domain. This is not going to require too much extra memory and will help
> the code to be simpler.

Yep.

> I would also pass the color to domain_create(). So there is no logic
> specific to the HW domain here.

If we can avoid changing domain_create(), I can simply use
struct xen_domctl_createdomain to pass this data.

> > +    else if ( config->num_colors == 0 )
> > +    {
> > +        printk(XENLOG_WARNING
> > +               "Color config not found for %pd. Using default\n", d);
> > +        d->arch.colors = xzalloc_array(unsigned int, max_colors);
> > +        d->arch.num_colors = set_default_domain_colors(d->arch.colors);
> Ah, so your check in set_default_domain_colors() is here to cater this
> case? I would prefer if we check the allocation before using it. This
> will make it more obvious compare to expecting
> set_default_domain_colors() checking for NULL.
>
> > +    }
> > +    else
> > +    {
> > +        d->arch.colors = xzalloc_array(unsigned int, config->num_colors);
> > +        d->arch.num_colors = config->num_colors;
> > +        if ( config->from_guest )
> > +            copy_from_guest(d->arch.colors, config->colors, config->num_colors);
> > +        else
> > +            memcpy(d->arch.colors, config->colors.p,
> > +                   sizeof(unsigned int) * config->num_colors);
>
> See my remark above.
>
> > +    }
> > +
> > +    if ( !d->arch.colors )
> > +    {
> > +        printk(XENLOG_ERR "Colors allocation failed for %pd\n", d);
> > +        return -ENOMEM;
> > +    }
> > +
> > +    if ( !check_colors(d->arch.colors, d->arch.num_colors) )
> > +    {
> > +        printk(XENLOG_ERR "Bad color config for %pd\n", d);
> > +        return -EINVAL;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +void domain_coloring_free(struct domain *d)
> > +{
> > +    if ( !is_hardware_domain(d) )
> > +        xfree(d->arch.colors);
> > +}
> > +
> >   /*
> >    * Local variables:
> >    * mode: C
> > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> > index 2d6253181a..c6fa8adc99 100644
> > --- a/xen/arch/arm/domain.c
> > +++ b/xen/arch/arm/domain.c
> > @@ -23,6 +23,9 @@
> >   #include <xen/wait.h>
> >
> >   #include <asm/alternative.h>
> > +#ifdef CONFIG_CACHE_COLORING
> > +#include <asm/coloring.h>
> > +#endif
> >   #include <asm/cpuerrata.h>
> >   #include <asm/cpufeature.h>
> >   #include <asm/current.h>
> > @@ -712,6 +715,11 @@ int arch_domain_create(struct domain *d,
> >       ioreq_domain_init(d);
> >   #endif
> >
> > +#ifdef CONFIG_CACHE_COLORING
>
> When !CONFIG_CACHE_COLORING, we should check that the color is not
> specified.
>
> > +    if ( (rc = domain_coloring_init(d, &config->arch)) )
> > +        goto fail;
> > +#endif
> > +
> >       /* p2m_init relies on some value initialized by the IOMMU subsystem */
> >       if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
> >           goto fail;
> > @@ -807,6 +815,9 @@ void arch_domain_destroy(struct domain *d)
> >                          get_order_from_bytes(d->arch.efi_acpi_len));
> >   #endif
> >       domain_io_free(d);
> > +#ifdef CONFIG_CACHE_COLORING
> > +    domain_coloring_free(d);
> > +#endif
>
> See my remark in patch #1 about the #ifdef.
>
> >   }
> >
> >   void arch_domain_shutdown(struct domain *d)
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 3fd1186b53..4d4cb692fc 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -33,6 +33,12 @@
> >   #include <xen/grant_table.h>
> >   #include <xen/serial.h>
> >
> > +#ifdef CONFIG_CACHE_COLORING
> > +#define XEN_DOM0_CREATE_FLAGS CDF_privileged
> > +#else
> > +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap
> > +#endif
>
> I can't remember if I asked it before and it doesn't seem to written
> everywhere. This check suggest that it is not possible to use the same
> Xen binary for coloring and non-coloring.

If coloring is enabled, all the domains are colored (even if they use
zero colors
because of the default selection). This means that they are going to use
the colored allocator. Since this all-or-nothing design, if coloring is
enabled, dom0 is assumed to be colored, which implies removing the directmap
flag. So if what you mean with "same Xen binary for coloring and non-coloring"
is to have a way to select at runtime if a domain is colored, or if Xen
itself is colored, the answer is no, we don't have this right now.

> At the moment, we have been able to have all the features in the same
> Xen binary. So what are the reasons for this restriction?

Not sure about the first sentence (you mean, until this patch?), but the
restriction is just because it's simpler. For example if we have to support
colored and non-colored domains at the same time, we probably need to
change something in the allocator (at least reserving more memory for the
buddy).

> > +
> >   static unsigned int __initdata opt_dom0_max_vcpus;
> >   integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
> >
> > @@ -3399,7 +3405,10 @@ static int __init construct_dom0(struct domain *d)
> >       /* type must be set before allocate_memory */
> >       d->arch.type = kinfo.type;
> >   #endif
> > -    allocate_memory_11(d, &kinfo);
> > +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
>
> Even if we can't have a single Xen binary yet, I would prefer if we
> avoid using directly IS_ENABLED(CONFIG_CACHE_COLORING). Instead it would
> be better to provide an helper that check whether the domain has cache
> coloring is enabled.
>
> That helper could use IS_ENABLED(CONFIG_CACHE_COLORING) if that still
> wanted. The advantage is we make it easier to modify the code.

Ok.

> > +        allocate_memory(d, &kinfo);
> > +    else
> > +        allocate_memory_11(d, &kinfo);
> >       find_gnttab_region(d, &kinfo);
> >
> >       /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */
> > @@ -3455,7 +3464,7 @@ void __init create_dom0(void)
> >       if ( iommu_enabled )
> >           dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
> >
> > -    dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap);
> > +    dom0 = domain_create(0, &dom0_cfg, XEN_DOM0_CREATE_FLAGS);
> >       if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
> >           panic("Error creating domain 0\n");
> >
> > diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
> > index dd7eff5f07..60c8b1f079 100644
> > --- a/xen/arch/arm/include/asm/coloring.h
> > +++ b/xen/arch/arm/include/asm/coloring.h
> > @@ -25,7 +25,14 @@
> >   #define __ASM_ARM_COLORING_H__
> >
> >   #include <xen/init.h>
> > +#include <xen/sched.h>
> > +
> > +#include <public/arch-arm.h>
> >
> >   bool __init coloring_init(void);
> >
> > +int domain_coloring_init(struct domain *d,
> > +                         const struct xen_arch_domainconfig *config);
> > +void domain_coloring_free(struct domain *d);
> > +
> >   #endif /* !__ASM_ARM_COLORING_H__ */
> > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> > index 26a8348eed..291f7c375d 100644
> > --- a/xen/arch/arm/include/asm/domain.h
> > +++ b/xen/arch/arm/include/asm/domain.h
> > @@ -58,6 +58,10 @@ struct arch_domain
> >   #ifdef CONFIG_ARM_64
> >       enum domain_type type;
> >   #endif
>
> NIT: Newline here please. So we keep each feature in their own block.
>
> > +#ifdef CONFIG_CACHE_COLORING
> > +    unsigned int *colors;
> > +    unsigned int num_colors;
> > +#endif >
> >       /* Virtual MMU */
> >       struct p2m_domain p2m;
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index c8b6058d3a..adf843a7a1 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
> >   #define XEN_DOMCTL_CONFIG_TEE_NONE      0
> >   #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
> >
> > +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);
>
> You don't seem to use "color_t" outside of arch-arm.h and we already
> define guest handle for "unsigned int". So can they be used?

That's because the guest handle for "unsigned int" is defined later
(in public/xen.h). We can also think of moving the coloring fields from this
struct to the common one (xen_domctl_createdomain) protecting them with
the proper #ifdef (but we are targeting only arm64...).

> > +
> >   struct xen_arch_domainconfig {
> >       /* IN/OUT */
> >       uint8_t gic_version;
> > @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
> >        *
> >        */
> >       uint32_t clock_frequency;
> > +    /* IN */
> > +    uint8_t from_guest;
>
> There is an implicit padding here and ...
> > +    /* IN */
> > +    uint16_t num_colors;
>
> ... here. For the ABI, we are trying to have all the padding explicit.
> So the layout of the structure is clear.

Isn't it true also for other fields like gic_version and tee_type?

> Also, DOMCTL is an unstable ABI, so I think it would not be necessary to
> check the padding are zeroed. If it were a stable ABI, then we would
> need to check so they can be re-used in the future.
>
> > +    /* IN */
> > +    XEN_GUEST_HANDLE(color_t) colors;
> >   };
>
> Lastly, assuming this is the first patch touching the domctl for next
> release, you will want to bump the XEN_DOMCTL_INTERFACE_VERSION.

Ok.

> Cheers,
>
> --
> Julien Grall

Thanks.

-- Carlo Nonato


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:15:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:15:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429774.680991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHuF-00070I-8Z; Tue, 25 Oct 2022 11:15:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429774.680991; Tue, 25 Oct 2022 11:15:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHuF-00070B-4r; Tue, 25 Oct 2022 11:15:39 +0000
Received: by outflank-mailman (input) for mailman id 429774;
 Tue, 25 Oct 2022 11:15:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onHuE-000705-3U
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 11:15:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onHuD-0001Po-Iw; Tue, 25 Oct 2022 11:15:37 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onHuD-0002GD-B2; Tue, 25 Oct 2022 11:15:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+uDZnxoXK9VssaAf05v2oJ+6rF1cX761cESfcrgal2I=; b=FTiiE/x4CzYTakcei5VDacn00K
	qUrJH7EPbWco8SpwMMN5UMkKmsD68OU+6w+jqmazdjPyaiTe9GGiUzyTMOiZzOP1+QFvl9/3egHix
	7ctxrilDVI8X1b0N2o1Y46L9ZmOksgpoxhPOzJPM8peEhTK6OfvPudVR2LmWxkp4YO9s=;
Message-ID: <9a996e9d-d9ce-f562-122d-1e661d25614c@xen.org>
Date: Tue, 25 Oct 2022 12:15:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for
 domains
To: Carlo Nonato <carlo.nonato@minervasys.tech>,
 xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 andrea.bastoni@minervasys.tech, lucmiccio@gmail.com,
 Marco Solieri <marco.solieri@minervasys.tech>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-3-carlo.nonato@minervasys.tech>
 <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org>
 <CAG+AhRUT75hkaLZi0v0E_ozzyUY9QLHYGTamhXAoKfV2gZMwfg@mail.gmail.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <CAG+AhRUT75hkaLZi0v0E_ozzyUY9QLHYGTamhXAoKfV2gZMwfg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 25/10/2022 11:53, Carlo Nonato wrote:
> Hi Julien,
> 
> On Fri, Oct 21, 2022 at 8:02 PM Julien Grall <julien@xen.org> wrote:
>>
>> Hi Carlo,
>>
>> On 26/08/2022 13:51, Carlo Nonato wrote:
>>> This commit adds array pointers to domains as well as to the hypercall
>>> and configuration structure employed in domain creation. The latter is used
>>> both by the toolstack and by Xen itself to pass configuration data to the
>>> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be
>>> able to access guest memory in the first case. This implies special care for
>>> the copy of the configuration data into the domain data, meaning that a
>>> discrimination variable for the two possible code paths (coming from Xen or
>>> from the toolstack) is needed.
>>
>> So this means that a toolstack could set from_guest. I know the
>> toolstack is trusted... However, we should try to limit when the trust
>> when this is possible.
>>
>> In this case, I would consider to modify the prototype of
>> domain_create() to pass internal information.
> 
> Doing as you said isn't a bit too invasive? I should also change all the call
> sites of domain_create() and this means x86 too.

Yes there will be a few calls to modify. But this is better than hacking 
the hypercall interface to cater for internal use.

> Isn't there an easier way to spot a guest address? Maybe just looking at the
> address value... 

HVM/Arm guest have a separate address space. So it is not possible to 
differentiate between guest vs hypervisor address.

> Or maybe adding an internal flag to the do_domctl() path.
IIUC, this flag would indicate whether the XEN_GUEST_HANDLE() is an 
hypervisor or guest address. Is that correct?

If so, I dislike it. I am not sure what the other maintainers think, but 
personally updating domain_create() is my preferred way.

[...]

>>>    void arch_domain_shutdown(struct domain *d)
>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>>> index 3fd1186b53..4d4cb692fc 100644
>>> --- a/xen/arch/arm/domain_build.c
>>> +++ b/xen/arch/arm/domain_build.c
>>> @@ -33,6 +33,12 @@
>>>    #include <xen/grant_table.h>
>>>    #include <xen/serial.h>
>>>
>>> +#ifdef CONFIG_CACHE_COLORING
>>> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged
>>> +#else
>>> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap
>>> +#endif
>>
>> I can't remember if I asked it before and it doesn't seem to written
>> everywhere. This check suggest that it is not possible to use the same
>> Xen binary for coloring and non-coloring.
> 
> If coloring is enabled, all the domains are colored (even if they use
> zero colors
> because of the default selection). This means that they are going to use
> the colored allocator. Since this all-or-nothing design, if coloring is
> enabled, dom0 is assumed to be colored, which implies removing the directmap
> flag. So if what you mean with "same Xen binary for coloring and non-coloring"
> is to have a way to select at runtime if a domain is colored, or if Xen
> itself is colored, the answer is no, we don't have this right now.

[...]

> 
>> At the moment, we have been able to have all the features in the same
>> Xen binary. So what are the reasons for this restriction?
> 
> Not sure about the first sentence (you mean, until this patch?),

Yes.

> but the
> restriction is just because it's simpler. For example if we have to support
> colored and non-colored domains at the same time,

I am not asking for supporting a mix of colored and non-colored domains. 
What I am asking is to have a runtime switch (rather than compile time) 
to decide whether the system is colored or not.

IOW, why can't system-wide coloring be selected at runtime?

> we probably need to
> change something in the allocator (at least reserving more memory for the
> buddy).

This sentence picked my interesting. How do you decide the size of the 
buddy today?

[...]

>>> +#ifdef CONFIG_CACHE_COLORING
>>> +    unsigned int *colors;
>>> +    unsigned int num_colors;
>>> +#endif >
>>>        /* Virtual MMU */
>>>        struct p2m_domain p2m;
>>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>>> index c8b6058d3a..adf843a7a1 100644
>>> --- a/xen/include/public/arch-arm.h
>>> +++ b/xen/include/public/arch-arm.h
>>> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>>>    #define XEN_DOMCTL_CONFIG_TEE_NONE      0
>>>    #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>>>
>>> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);
>>
>> You don't seem to use "color_t" outside of arch-arm.h and we already
>> define guest handle for "unsigned int". So can they be used?
> 
> That's because the guest handle for "unsigned int" is defined later
> (in public/xen.h).

Hmmm... And I guess we can't define "unsigned int" earlier because they 
rely on macro defined in arch-arm.h?

> We can also think of moving the coloring fields from this
> struct to the common one (xen_domctl_createdomain) protecting them with
> the proper #ifdef (but we are targeting only arm64...).

Your code is targeting arm64 but fundamentally this is an arm64 specific 
feature. IOW, this could be used in the future on other arch. So I think 
it would make sense to define it in common without the #ifdef.

@x86 maintainers, what do you think?

> 
>>> +
>>>    struct xen_arch_domainconfig {
>>>        /* IN/OUT */
>>>        uint8_t gic_version;
>>> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
>>>         *
>>>         */
>>>        uint32_t clock_frequency;
>>> +    /* IN */
>>> +    uint8_t from_guest;
>>
>> There is an implicit padding here and ...
>>> +    /* IN */
>>> +    uint16_t num_colors;
>>
>> ... here. For the ABI, we are trying to have all the padding explicit.
>> So the layout of the structure is clear.
> 
> Isn't it true also for other fields like gic_version and tee_type?

Indeed, there is missing explicit padding after gic_version. There is no 
padding necessary after 'tee_type'.

I am not asking you to fix the existing missing padding, however we 
should avoid to introduce new ones.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:17:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:17:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429778.681001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHvj-0007Zx-Io; Tue, 25 Oct 2022 11:17:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429778.681001; Tue, 25 Oct 2022 11:17:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onHvj-0007Zq-G3; Tue, 25 Oct 2022 11:17:11 +0000
Received: by outflank-mailman (input) for mailman id 429778;
 Tue, 25 Oct 2022 11:17:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EPr6=22=citrix.com=prvs=290a5f0d7=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1onHvh-0007Zd-VY
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 11:17:09 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f1b0ab4-5456-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 13:17:08 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f1b0ab4-5456-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666696628;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=VV43RUwpriwNLLfb83Bf2O9iMtUov5Ahc0lEQEZwlGk=;
  b=UsWNxIaUZ4k4GumloEsXNxvlE5nMZg7uLQObbgHINHby1URm1sTg7Rs6
   y5DhCntRlohgPOcPoNPj4cizoAZQEe1MNsGAz7RQftv4mYs/CUGQOaUoi
   5jQEn3Z2KQmI6EDz9RXU/rRjVvIhMOBVuppR6LxU399RBKbdhIOBtXBbK
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83065978
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XcBU3a1+jSHf6WjkiPbD5fJxkn2cJEfYwER7XKvMYLTBsI5bpzJWy
 DdKW2HSP66JZWTzKNl+a4i+9koDvpDXztJmHQZupC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlF5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU92OwpOWpxq
 cceCzQ9R1etu9i/77aSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqOIoLXFJoF9qqej
 mmW8GW+Uh1EDs6C7gej8l3zmMDTjTyuDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWWd1FL
 FcP0jEztqV0/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0
 FChlsnsQzdotdWopWm1r+nO62noYG5McDFENXRsoRY5D8fLhaM50CrEcYpYFo2xvvSyNw3Ky
 h+OhX1r71kMtvIj26K+9FHBpjujoJnVUwI4jjnqsnKZAhBRP9D8OdHxgbTPxbMZddvCEAHd1
 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGpxbEdMKS
 BWJ0e+02HO0FCLzBZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzhZyyv9iY
 M3BIZzE4ZMm5UNPlWTeegvg+eVzmnBWKZ37GfgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2
 483Cid+8D0GCLeWSnCOqeY7dAlaRUXX8Lir8qS7gMbYeVE4cIzgYteMqY4cl3tNw/wMyLiVp
 C3hCye1CjPX3BX6FOlDUVg7AJuHYHq1hShT0fAEVbpw50UeXA==
IronPort-HdrOrdr: A9a23:qGZGoay9mWvhdCj3IIQtKrPwJr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78
 tdmtBFeb7NMWQ=
X-IronPort-AV: E=Sophos;i="5.95,211,1661832000"; 
   d="scan'208";a="83065978"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Anthony PERARD <anthony.perard@citrix.com>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH for-4.17] libs/light: Fix build, fix missing _libxl_types_json.h
Date: Tue, 25 Oct 2022 12:16:32 +0100
Message-ID: <20221025111632.36286-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Make may not have copied "_libxl_types_json.h" into $(XEN_INCLUDE)
before starting to build the different objects.

Make sure that the generated headers are copied into $(XEN_INCLUDE)
before using them. This is achieved by telling make about which
headers are needed to use "libxl_internal.h" which use "libxl_json.h"
which uses "_libxl_types_json.h". "libxl_internal.h" also uses
"libxl.h" so add it to the list.

This also prevent `gcc` from using a potentially installed headers
from a previous version of Xen.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

This is part of in review patch "libs/light: Rework targets
prerequisites", but that much smaller patch should be enough to fix
potential build issues.

This patch fix for example `make _libxl_types.o`, when libxl generated
headers aren't generated yet, and tools/light is clean.

For 4.17:
    build fix.
---
 tools/libs/light/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index d681269229..374be1cfab 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -209,6 +209,7 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
 
 $(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h
 $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
+libxl_internal.h: $(XEN_INCLUDE)/libxl.h $(XEN_INCLUDE)/libxl_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:23:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:23:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429782.681012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onI2B-0000bE-6x; Tue, 25 Oct 2022 11:23:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429782.681012; Tue, 25 Oct 2022 11:23:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onI2B-0000b7-4A; Tue, 25 Oct 2022 11:23:51 +0000
Received: by outflank-mailman (input) for mailman id 429782;
 Tue, 25 Oct 2022 11:23:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OBMn=22=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onI29-0000b1-LL
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 11:23:49 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2055.outbound.protection.outlook.com [40.107.105.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7da12196-5457-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 13:23:46 +0200 (CEST)
Received: from AS8P189CA0053.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::19)
 by DU0PR08MB8614.eurprd08.prod.outlook.com (2603:10a6:10:402::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Tue, 25 Oct
 2022 11:23:39 +0000
Received: from VI1EUR03FT035.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:458:cafe::66) by AS8P189CA0053.outlook.office365.com
 (2603:10a6:20b:458::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Tue, 25 Oct 2022 11:23:39 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT035.mail.protection.outlook.com (100.127.145.20) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.16 via Frontend Transport; Tue, 25 Oct 2022 11:23:39 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Tue, 25 Oct 2022 11:23:38 +0000
Received: from 1fcf91e50f72.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8A129925-BFE7-4F31-8705-7D31CA600AD0.1; 
 Tue, 25 Oct 2022 11:23:32 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1fcf91e50f72.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 11:23:32 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 11:23:29 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Tue, 25 Oct 2022
 11:23:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7da12196-5457-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=e8y9jDpxCYkK/CdGF8f5e68eZEunjTMUOcRjwlNmxeMptwIaHVr7IDM2ywcUjtqjHG1uGNlBbXuR2y1lZ+JeOnCkkoW5lAu9vRAc+KehNVQgjDBM/dtq9bXAGFtFu0RJgdtc2CDoMZOKNU+M4/P03W3vI/4tlHD9E7ACbNsVDLN0rKMqNI7mMGVlPRqeHenue6/VdbiP2tQzS3VsJ00uLWLKlQgnofaKGUUf08nyIkhwpD0otrTE/WaWkCFwPV9heF0YEvsVgQFh1P0wc4LkCV/+oBrhrryFvyM6Xq/tuqgKg4D9trzC9iS2Up9C73LNjR7BzMoHaNdnXKP1zQy3QA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Rdag1Pi4i5kOuTFexg/BEcwsGNQ5jd36yl9qZlp3qk=;
 b=YMyk4R2kac8KGziz4GcfSVY4bWBUfvzd0aqoe2Wtg+JXIcktBoqcQb/pbwn33gYbURrvmrbR56/XcX3H75QKLXLKYeS1PO1pz+E1mRijro1BOfogd8HTE/qKHacsRUBfK4xAI8FSQH+2ENIOFfLy9rronV3c7fKlUH5/c/XInTCryZOhRFoW04aNGFu0ZTK5ia16fUAVPjqsZp6mzJ5cpFlIBAy+sAaZ/96/xOHnBqgyXrsCmrYRQJ2xh9x85mqDx2KMDws2LzGvsoaagwb2u7YgTNrnBDyBNaLH9qk/RRK1KjDcMoDtKCYdQxaqninhC9aeg8RkZiADJQq9blfO/w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Rdag1Pi4i5kOuTFexg/BEcwsGNQ5jd36yl9qZlp3qk=;
 b=1ztGIVh6U9jmvjwcgLzPyFyxNB09x4IyXbSacXeWN1RLBDQGERHRyJzfLYdjEkfmz/VYhyXsvVtaHHbkeb/VjjZcqbx/OU5nEpUEgU3gAS50rxWvcvTPwoEDWiJqNb8ijM3xinqy5ZJBkWLwpQGPE4Lvy0EvSK43XJe4bzG/tDY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PQqvxlEcd9NmpnZcJQjp19l031mZImsy46JI/LnFkKycTOHJDGmM4tRBX+GdnJmTlrRmNXxLzCnpOPRuVRpp66E1GvbpVHBzTkh2Ek69+PafSOYW5+YgfYL2GqQw9aGAp6NJvz9xdFz6AjfqzBeUklUct7MkcrakpLhfcrUwFzpjeuMtXzXMi64oCOLaFhAKlryD4GjAVjOW+Gu/xazyUpRa2VvGM9qy5yiqmIjzmgxq+mMmaSfISrtlB22xGHKc6wxAOccwqD5Kgpd+xj7jGpTSwtiOBwp3vAeSDT7CmvXMXLfVy7qpvpnsXP6kVx4gSwF8JJPZaOz0c6DdRUWevg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Rdag1Pi4i5kOuTFexg/BEcwsGNQ5jd36yl9qZlp3qk=;
 b=RCtQgt3hh5jc0ja/lYCGC7/zCGuGCgeYM9gEg5FF9yJ32iVrBJcYJTWTmOjDA3AUgdoyGxKC1CdUMzfPWWO+kkrTAUvcYG0z8hthbt3SrxGR6BN+KC6BJWraLTZKwJx+8kVdtVYFZmtLhBW/qX9zQvEcNQQPXx2/TbOec6/qe58DKHuG9lMoUm2mNMHxukATqee49kssbegOZAtix+9kDicKLkcFNKnPhFj/g4lzTLAu//JmXgQs+GBmzJQdLFH6TmVePd9PSAva3vzFipUVz7P+B7svtc4MiH6AdPK7/ilRCW/fj2dKdiNjGIpnCajHr3uO2YA/TFIvhwW/hnT7xA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Rdag1Pi4i5kOuTFexg/BEcwsGNQ5jd36yl9qZlp3qk=;
 b=1ztGIVh6U9jmvjwcgLzPyFyxNB09x4IyXbSacXeWN1RLBDQGERHRyJzfLYdjEkfmz/VYhyXsvVtaHHbkeb/VjjZcqbx/OU5nEpUEgU3gAS50rxWvcvTPwoEDWiJqNb8ijM3xinqy5ZJBkWLwpQGPE4Lvy0EvSK43XJe4bzG/tDY=
From: Henry Wang <Henry.Wang@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	=?iso-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: RE: [XEN PATCH for-4.17] libs/light: Fix build, fix missing
 _libxl_types_json.h
Thread-Topic: [XEN PATCH for-4.17] libs/light: Fix build, fix missing
 _libxl_types_json.h
Thread-Index: AQHY6GNYDlCeKTtqLUuFb/P6KXo5A64e93Hg
Date: Tue, 25 Oct 2022 11:23:28 +0000
Message-ID:
 <AS8PR08MB7991B8AFC1A05D6206D4ABC792319@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221025111632.36286-1-anthony.perard@citrix.com>
In-Reply-To: <20221025111632.36286-1-anthony.perard@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 2140967AEDD44147B61F4F9EAA70C3EB.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|PA4PR08MB6080:EE_|VI1EUR03FT035:EE_|DU0PR08MB8614:EE_
X-MS-Office365-Filtering-Correlation-Id: 9af7b2cd-6779-471d-2b12-08dab67b5d82
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 7KRr1Y2liO7+qZu/mQ/NurK8iXzfTYWmqHhulFJsV2BUKjeYRjSP/EJsjNg71jzAsk7qATgrAKlYGnQYIM49bvrl6by3ygXByW1PWNTCdlqdooy+eFTcyz4oi+kiobEsGWpSHnS1adGp6mGf69sHUdvj8JwPtKJsEQgox0pnT3r79tRtfWnrgqnCuIZHR7MciLFrTWW6/gVSvV3r3w0pO6m3TjdgUldviYtWoUn0XDim6pdgp5/ZZh4uoLc3hFNoIoc/Hj+lZL2bcBZOjuKYVo78m2On1EGkHw2fsZknm4nO1JOcq0pYvGAGPI8Ix8I8M/Fp7rRpO+sm7DVHuq1AoeygkszhEO9OJkOZtSif6oksl7CY4r35s08FvEeXQ9ClcN8Qxvl4BuxTNBszbhhDGGLtg1AryAe2tUINw/yiPi/09Ev3lQY7lt+V2wBluESXtvgughQVwNOsIa4PO0mG1IajvKqFjgabF5hKh83+GhmBDYKbdhBBGCSsAE4aqAVrJCafuezNUO1gYTXO++OkxWK6pUVp8MowCW0QLVQIGJxCe62EIViE8USKAY9QHxP5VvM+4LJDcjUv6MVJKHCKHsuGw9fwdnHQLEOzsAjn8FQOQkwGc8JHBE67gyEX9YYwd7fP2QQ/BO29e7RuluP6xD6zJHdu5kAxqvJq4aHav3tjYwIYa/NcklDCrwobGSczBlFTsOWiFpFttKKb8TtTrV1CCsACS4kSHJoOpDBPvlxROnRkygc6pb3W3s5zd9wPVbkaLmn6TFwPungOdunZrg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(366004)(396003)(376002)(451199015)(41300700001)(66476007)(2906002)(66556008)(52536014)(316002)(8676002)(64756008)(76116006)(66946007)(4326008)(71200400001)(5660300002)(478600001)(33656002)(110136005)(54906003)(8936002)(38100700002)(38070700005)(83380400001)(55016003)(66446008)(6506007)(7696005)(86362001)(26005)(9686003)(186003)(4744005)(122000001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bbf6fcbe-182d-46c0-aa42-08dab67b56f4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vZQ48m+I6oBEKy1C+NX6NT7rHtBjgaso+0wi1K6QOlEFjnRI7jpjv0sKbuSbmtCUeYOgcX7rBWqvoSWNRed0XyoLC+nPdEnxeyArAAg89QOuyQi/CLaUT/cEJPY++WoDSFI4YAJ8FqaLb5ESo21+pB5c3VKiOS+cHq6IjxqAbJgDFW1U/G+7/RxjPwWBGCC/4kAMsyzI66Bfjs9fkBDJ2IqQYcSSI2wNQYdqVVPvjRFJUToMPGY30mebXw1zCTE2LEFXDQeLJs5/KidYKayGR+8AbgxeEzKeAvZym5+QHeud+WEr69rXK8k7rwUwGZ7nlrAxijYewu64iOwCli4hCMpnch8rLVMAl8/fCe2m9gdqQOwS+T2gHuuWfsz/+JapNOHX1WKuxcsVhCn0PaSN0reybwxDsUFvqdV/DzSQ9HPAcDnv0/25keVoKSGNOtIIgDBLlW5oS4jDMneCEcXERGcS+druOlG1GBWKpVZKrk1obZKDqfNXZOUgKNBUeWp4YIrMpQ246jkGY8hFgmcRQlp4t6qDg3GsVc2zxS5jBEKCfnfcJujT2xjPxc6fCgKvhLOXx4N4EAlEHHFT85icVoyCndxfmYR1NRwiZCKpQaPehEyt5yxlZpII0LF7e6jk+sySptuxOV9NI2GRki/VRDpfxhF6PpNjb8f55JG1gfqkkU9FE29dD+Ate1t7TYaq6TxwxuIW8QiIdS8bJ0OSbLQBapLYagMBDvdEHsIOcj0LuJugG80lfCleR3kIT2FqU2q7eA+iAKtDnuZj9gw5cg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199015)(40470700004)(46966006)(36840700001)(86362001)(2906002)(33656002)(82740400003)(356005)(83380400001)(4744005)(5660300002)(40460700003)(186003)(6506007)(40480700001)(336012)(81166007)(7696005)(55016003)(26005)(36860700001)(107886003)(9686003)(70586007)(478600001)(54906003)(47076005)(41300700001)(110136005)(82310400005)(70206006)(4326008)(8936002)(52536014)(8676002)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 11:23:39.1140
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9af7b2cd-6779-471d-2b12-08dab67b5d82
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT035.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8614

Hi Anthony,

> -----Original Message-----
> From: Anthony PERARD <anthony.perard@citrix.com>
> Subject: [XEN PATCH for-4.17] libs/light: Fix build, fix missing
> _libxl_types_json.h
>=20
> Make may not have copied "_libxl_types_json.h" into $(XEN_INCLUDE)
> before starting to build the different objects.
>=20
> Make sure that the generated headers are copied into $(XEN_INCLUDE)
> before using them. This is achieved by telling make about which
> headers are needed to use "libxl_internal.h" which use "libxl_json.h"
> which uses "_libxl_types_json.h". "libxl_internal.h" also uses
> "libxl.h" so add it to the list.
>=20
> This also prevent `gcc` from using a potentially installed headers
> from a previous version of Xen.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:25:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:25:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429786.681024 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onI3H-00019U-Hc; Tue, 25 Oct 2022 11:24:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429786.681024; Tue, 25 Oct 2022 11:24:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onI3H-00019N-EK; Tue, 25 Oct 2022 11:24:59 +0000
Received: by outflank-mailman (input) for mailman id 429786;
 Tue, 25 Oct 2022 11:24:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onI3G-00019D-Tw; Tue, 25 Oct 2022 11:24:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onI3G-0001aC-PD; Tue, 25 Oct 2022 11:24:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onI3G-0004as-CE; Tue, 25 Oct 2022 11:24:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onI3G-0008Ns-Bh; Tue, 25 Oct 2022 11:24:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cYhCzhKOycP5+V44Upj2awni+fZKI3AyJZ+spJ8PbLo=; b=oRHLpedpc14b7Jy2RIL+JGN1wv
	EsFnX7Gm1TtdMFUUBvIaAfJvHOZFFNuZFBySGRZiVyVR4pNFA22TpYNdrIBI1f4hri34K+OJCJiAn
	4OnFfJ3R21+L67F5KyqN+QZ1S8RB+oRCQT9178zqh5VdwOfAiODWqPwPiGhCf5OVaYwg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174346-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174346: regressions - trouble: fail/pass/starved
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.14-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-amd64-i386-qemuu-rhel6hvm-amd:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-amd64-i386-xl:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-amd64-i386-qemuu-rhel6hvm-intel:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-amd64-i386-qemut-rhel6hvm-amd:hosts-allocate:starved:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 11:24:58 +0000

flight 174346 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174346/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install fail in 173906 REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install fail in 173906 REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start    fail in 173906 REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174346
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174346
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174346
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174346
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174346
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 build-armhf-libvirt           2 hosts-allocate               starved  n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  3 hosts-allocate               starved n/a
 test-amd64-i386-xl            3 hosts-allocate               starved  n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  3 hosts-allocate             starved n/a
 test-amd64-i386-qemut-rhel6hvm-amd  3 hosts-allocate               starved n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 3 hosts-allocate starved n/a

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   70 days
Failing since        173496  2022-10-11 14:08:01 Z   13 days   14 attempts
Testing same since   173650  2022-10-13 00:06:56 Z   12 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           starved 
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           starved 
 test-amd64-i386-qemuu-rhel6hvm-amd                           starved 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         starved 
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         starved 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:54:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:54:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429803.681034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIW1-0004tU-2U; Tue, 25 Oct 2022 11:54:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429803.681034; Tue, 25 Oct 2022 11:54:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIW0-0004tN-WA; Tue, 25 Oct 2022 11:54:40 +0000
Received: by outflank-mailman (input) for mailman id 429803;
 Tue, 25 Oct 2022 11:54:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onIW0-0004tH-9T
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 11:54:40 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cd486e45-545b-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 13:54:38 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8874.eurprd04.prod.outlook.com (2603:10a6:20b:409::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 11:54:37 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 11:54:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd486e45-545b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RWlkCCLzZaTDWRhsBbr6p7L+2Ruq6Z3yvyxy87rekHBs8ZRzScDY2/Oa3c2E9QIXdrC7NHvqeQS3JoJUT4VJ8PHo4FtAB6SlBx9wZPAzOARZDtVIeLBPOHNHY1+fkjPaZLVOFt/OQ2gwJB1RuozV0SQKvPBHGa8zRZFtiwmnjCHKp5vy+zr9QgGeKAyotWLlJBfe1HWZmgipYJX9L025G2Gw4E4QtwmfMJkKtqkHcplAy/8gLGyrMzb5/OSnDMAM1yRFYVhfjfM2VEVuqpLUYM4Vv98zcfnhLKMbCkxZBq42LGIa6joRrwVAwdRxc1F6EHVcASA06f2q3+hTcp4Xog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B1nSpRZyK/9ooLIPKJLAlAHQABdqLC8qj5XnYImKwiE=;
 b=WipaMNe9ByWsbPv9KtmJV6+0v/zjfJBiEwvp38/5NTrfz3cY9zMqqnQ/D+mVwZSeF5VZVhTRNXGnWHapkiEf3vKqE0DLZaKR75l39DvVDJOWVA1KXrGSfjueKXRdVtv3ScsB/DDyNVRbtcKJLyaZHDHv+/7jBXWAKe3RP06Z63Tu/3R1VYaUmGsQfS58hSRHhVHyvacG98nWEBjsD2k7hCd3DbQu7ZNOL6liRLKpcDDNX73TkBhtcC3qfwNnclo69yh0hbQTmbp2HyQfJMp7mmcmz5vH+yT2QYDwsQ0J4U/vZEQ8QEVL2Xe20y+f0nFmCYRifgsufmZV/ogEoDiTVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B1nSpRZyK/9ooLIPKJLAlAHQABdqLC8qj5XnYImKwiE=;
 b=ht6jlHfJsDCHRScVwxBkx6T6ptHP7tXfK6840jUzzueOIB787FYxUg2H7y/X1k//tbCO3v4LUJ89xZs7WcuODfXrpO2AJ6KEC2WlAD6ZT7MYj/A4/a0gopfVJfHB6PUi3PlUJPpeYjS3Gt7HYM4P27tTQO+iP8iQiVysUG0M9YGujqDrOt/eBjObf0SKEIj0z0u/gl79KgTZmbKKxqRHSDpUEde8t7UwnBuOAp+k0qDejdCeFQa1ROPuopl+f4gUdQ4xcg+SfOh3EgBhOLs8zZktp1AhtuZ8J/8Z6pItshnxOljSCIYKj+82jltWIcfku9y9/nqT8jwFAK/24RCnZA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e05a04a1-3031-97eb-683a-77630bf8e6ae@suse.com>
Date: Tue, 25 Oct 2022 13:54:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [XEN PATCH for-4.17] libs/light: Fix build, fix missing
 _libxl_types_json.h
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, Henry Wang
 <Henry.Wang@arm.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Juergen Gross
 <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20221025111632.36286-1-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221025111632.36286-1-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0159.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a2::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8874:EE_
X-MS-Office365-Filtering-Correlation-Id: 5816b51d-8d4d-4bce-029b-08dab67fb097
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3u30b5gHDSqpYt9Hnik2MiDrUHz7woMZXeBBtfgvKivXBPuORkAFuRSTW8/XfL/G454ps+YhNJ/CFc68574Hs/hRSecqHmuSMtHkslyqyUuw3jOqJkweMWSV05MkGV4wwEbqjBAQaGngEOzM/wU2Ss31CwKBeTopYlov+DIMdy9ta9sXdG3rNjBPUna5eVhEMt9gsHdyoCsrBdzIu/++HQjCzIFaBujTC7HCsZtYKUVFOHW0nCjN2SEzeFLxjMsTz4xMmIMG8gnp+wIwhN4Kb94hOi7wsC+QPI39VCsUN9kOB9/HRSiTQASBCl+3BEke4afDozbLSkp08M0HYjp/ZOvz/HLEwoft++jtDGwo/VykkUtZUGQz99IZGyUQs93K5nD8yBEmz1V0wTfp1cTy2EnaB8BN0JRYkql44rG8Th0yYhuKbzBXPiTEbkbSGFkQfG4fruxegiN1p3RiQpYJCmZt6eCjuv5oEdrZV+GnaIoJIZSblZPezbPZ/o9BYWAGoBxlzed85F9PeniIddxswD3Rl9zFsVlzGN960vvcKXhfqE8bGsyOuAL8PaHN9+//ahF7jHpZ1lXmOz2RHz1KZOI1BXSM55fECHDMgmE1AtXOModDeH2NonrNhjfsm4w+sbeIsY1OcrpLs8c2SFRh5abzSZqZa0MYM98AG4IfBzQsclPDY+GnkyLj4grop2tYalyGPuK3XNzDF1+wV3KFB1JtUXUEAt9veuC3/TpU2xWesjzVkxA5dHUREpkrUx2bOW3AblfoHa2WH4Fy1UMdsd9FyNRKfEf6WpW178PmPwo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(39860400002)(366004)(136003)(396003)(451199015)(2616005)(5660300002)(186003)(2906002)(4744005)(316002)(26005)(54906003)(6916009)(41300700001)(8936002)(53546011)(66946007)(66556008)(66476007)(6506007)(36756003)(8676002)(4326008)(38100700002)(31696002)(86362001)(31686004)(6486002)(478600001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Tmp0ZnJXcWNhVmlWWTV1b0xTSGMydjdrWXRkTjltNFl5TGh5QzZ4Q3JhYVY0?=
 =?utf-8?B?bHoxSXpJdE9uczF6TzN4Z0hJOFBjSFErUnVaM21jUk90eG1aSG1EVTlTTWFu?=
 =?utf-8?B?ZWdBSEY5L2lRQjN5bkZhL3BjSjdIS1V6bS9sRHBoU3NuU0VOU1VVaWxmdnNz?=
 =?utf-8?B?b0Z2NVFhRnpFWDRibGE3b2Rka2QzMmxLeUlvcnZncFNldU5iNGpsSjU4MEJW?=
 =?utf-8?B?UTV4c0VuK2VxWFRmNmhjelF0RXFhT0J0QUJFcE1JdUY5N0xaYlpqTktlREF4?=
 =?utf-8?B?bFFSMnE4UGg2R3gxanBNK3QrTkFGbW1QSElCSkUyRjljWm9DYk5YenNDeXJI?=
 =?utf-8?B?VTFNNlBUUXE3TkZXSllJaGI4WExFUm9nOWlYWTZRR0hhbzdmL3dYV3pWSVpj?=
 =?utf-8?B?bDB6enlkYVIyVW9aZEpQY0Vza01BQ1pnOGtKTS9ORVV6Zks3cXhDYTd0YVFN?=
 =?utf-8?B?MyttWTJJWjREYU0zZWxGcnJHanEydXdadzlDYyt3Q2cwNDdlMWJlTHVKbXBH?=
 =?utf-8?B?MkRrL1VPV2lRMHBCNXRHTlJlV0Nmby9ENjdPZlMrL3R0V1F3dFpRckZYRE92?=
 =?utf-8?B?VFBTUXJQVWJQQTVtQnA4WEl4b0dRS3BadjdtNkZwcTBSYllOZ3dhNWhGeUpm?=
 =?utf-8?B?UFBPSHZTcHpFUVdsaFZhZ1RxbjdvdW50ekI3L0Q2YTR6blN1dTBaaWIwYzJP?=
 =?utf-8?B?NmR5aWY0RUkwSGdFOS9XWWloNDNBeTc5MU1ONm15U3k2NzN2UU9uUkJPM2tY?=
 =?utf-8?B?amRJemZxbGdlckJXczlZc0NDNjR2UWxteGZDbGVkNWo5ZW0yYUlreXJYOUxw?=
 =?utf-8?B?Qzc4bkV6Ry9vK2Q4OTc4ZU44WFpwS3JhZkpBZ1B0VFlZL09HOWpvbDRuUTRK?=
 =?utf-8?B?emo0ZTkzdlVoSFRRUE9CVmd5aVlrRVRIUS9ac1oxekIrUHZtVUNYZWxxMlZi?=
 =?utf-8?B?SXBhaWx0Nk93NXlkaWt2WHQ2dVdRbVhIMUs5MEVxU0JaVGdOQWV0VTJ5bk1r?=
 =?utf-8?B?SHY3SHovT0hmTXJ2TzNVUXl5bXJ3c25TRE9FTUczQ0dKbmhpdkVKanVnOEM5?=
 =?utf-8?B?dkJ1L1l1Q0VwRjlqWnpBM2ZMRm9rcDhDU3RuNEhkUDdrOEV1dFVGWlR4UHVk?=
 =?utf-8?B?eGpDYndDYno4ODNibmkyYkZBRWNPclYyamh6bTJITFpheEVvMlBKNzB2NFNl?=
 =?utf-8?B?Ym5NZkxGd2pTMFFWSlpnT1NPUUlQMmhMVkFTL0dXREV2dGlPTjMvU1pieGpo?=
 =?utf-8?B?Vmk5ZXBEUWxmZG1lUmh2YmRMR1VJMGwvTm5HSDliMlBFa0xmQTNDakJjRVJl?=
 =?utf-8?B?QVdaZE9KNVR4K0diNTNCZEJKWWQ3RWVEaU1rTEpKd1hwUTlCLzZkRGc3SGJS?=
 =?utf-8?B?ZU1Gd0NYTDZPTXNid2FYQ3VpcmV1L1lzcG12VUJnTTlDQXU2MWQ4b1pGZU9W?=
 =?utf-8?B?RXBMbExaVjYvNTBzODA4ZlVHUVRlUnBuOXdTbjg1UjhEb1hDT1RIMEJ4ZDM0?=
 =?utf-8?B?QWNtZEl4THZQNFZLUGgrS3JDV2ZhZ0dKajAzL0xnRmNYZzRsdEZYTm1HekNC?=
 =?utf-8?B?K3BRcmZ5T3I5Yno2TENlK3UvN1hRN3pUT0RRdmhpOVh0N3FNaGc0cWFXNXpp?=
 =?utf-8?B?b1ZSYm1YSzdjU000QmlrWFFpTjNLeStHREwxcDBrdXJRUlh2cWZmS1NTbStO?=
 =?utf-8?B?VUp3eG4xK29nL1JXRENVRElxYkR0UkFlQk04QkNaSDVlUVZxcXNtdmJRN0VT?=
 =?utf-8?B?NGNuMDArQXczSHZxVFQzdWNlUzI0c2tPUjY1NnB4bXlveGJiOHdFTXdvSHFJ?=
 =?utf-8?B?emJYQm1tNTZNZTJibklxeHNjWFZBR0FkS2drQjY2ckhzOHVtOHBKNCszVnhZ?=
 =?utf-8?B?LzR0SVJmWjFwQWNPWFJrTnNDMlFERHZ3QzIxM3pJc2lXNzAzYitjQ25GN0tS?=
 =?utf-8?B?NDBMaGxSMHAvSlJXS20zK3YxSDZpRkFiSjlXcFRtdE1jOE9mNjdMQjlkOGYz?=
 =?utf-8?B?OTlMcXQwOW1WS3NZOWRtdGk4YnpUWFh2bGtnN0hKdDBUdzI1SkRHellSTEJo?=
 =?utf-8?B?b3RNUlU4K0g3ckdxN1hhTG42aFRvVVNhS3FmUXNkbE00N2xBQ0hHbFovWHhE?=
 =?utf-8?Q?rC6o0TPtT/2Nipl5WIOTR372g?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5816b51d-8d4d-4bce-029b-08dab67fb097
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 11:54:36.8791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6R0Sw5cIaHvROB5XyrsGaS8IrVA5K/0MTGWNCJQzSxnYuyM/d40GTv++WgiUS4Me42nkqMQkqFn07tMT87VsKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8874

On 25.10.2022 13:16, Anthony PERARD wrote:
> Make may not have copied "_libxl_types_json.h" into $(XEN_INCLUDE)
> before starting to build the different objects.
> 
> Make sure that the generated headers are copied into $(XEN_INCLUDE)
> before using them. This is achieved by telling make about which
> headers are needed to use "libxl_internal.h" which use "libxl_json.h"
> which uses "_libxl_types_json.h". "libxl_internal.h" also uses
> "libxl.h" so add it to the list.
> 
> This also prevent `gcc` from using a potentially installed headers
> from a previous version of Xen.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:57:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:57:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429807.681046 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIYV-0005bt-GQ; Tue, 25 Oct 2022 11:57:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429807.681046; Tue, 25 Oct 2022 11:57:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIYV-0005bm-DL; Tue, 25 Oct 2022 11:57:15 +0000
Received: by outflank-mailman (input) for mailman id 429807;
 Tue, 25 Oct 2022 11:57:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Bl8Y=22=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1onIYU-0005bg-Cp
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 11:57:14 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60078.outbound.protection.outlook.com [40.107.6.78])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29599da7-545c-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 13:57:13 +0200 (CEST)
Received: from AM5PR1001CA0048.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::25) by DB5PR08MB10162.eurprd08.prod.outlook.com
 (2603:10a6:10:4a3::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 11:57:01 +0000
Received: from AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:15:cafe::dc) by AM5PR1001CA0048.outlook.office365.com
 (2603:10a6:206:15::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend
 Transport; Tue, 25 Oct 2022 11:57:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT047.mail.protection.outlook.com (100.127.140.69) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Tue, 25 Oct 2022 11:57:00 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Tue, 25 Oct 2022 11:57:00 +0000
Received: from d50e99aefdad.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 14E850ED-1E57-4FAE-BD9E-A4437E02B1FB.1; 
 Tue, 25 Oct 2022 11:56:49 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d50e99aefdad.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 25 Oct 2022 11:56:49 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by AS2PR08MB9689.eurprd08.prod.outlook.com (2603:10a6:20b:607::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 11:56:42 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Tue, 25 Oct 2022
 11:56:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29599da7-545c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=lLSvf7jU+3xcQG4aEMYutOsdgzXOlog0K7YlOJTDgVweoW6wdknID+EjG1UkLsHcooVpIu/8segSPBd75iCjNZT19fgxNdDhFrYOWDzvT9eFV91ErmXJc1roR/6IoKtci8rz4K+qL8H5D+vhqcbJW0szAsw82vjG8W4GTxRZ4Eh2nqYApnGjxYY55LS/x/UlZNz6IHRh2vGWGs8RXKinxzh2lKvMI5fHxECrQYTnQmn/91UuJN0XJVCiFh3Oc9DP/QGcb+Ntj9oeyWnywpGMRhCe6a4GYmE+4CEwlv7hvy/sglWLw+FDC0LQtBTQEYOnqGgSa4PUjHSjRIOTr37K3g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/booS25w3XCBT0qmwMl0HbX2D62yXBNu+E+mdDSk/6o=;
 b=kOdTxNJFaRZ5XA/RQSvbJT6P6xUBVVdMAZifnbxpfGwllqQ0NQFH/NX1N3/Mckh2fmiTh6KcyDbUWwg2qC75/CfDQTeMKXP9a8NZXjsZj8AM8P28mtzar4BO+xniaL/73OTS8i93V2iCIKl1lQPy0XYU3647HaOBQ9Z9GGqUuwnxB159S9jVLMqCNkzkbVBvNc425Ym84ppoHwQdDu7WTBrGpljwAy8wMeH335awFjcDVayEw/HD1wSnbDW+8YQvdfjauKEXcsssgqzyH4+dYLwv0A55LWImlbh3C7AQAG8EhNqrh46Qd6gOgDArfb6kmqAuyLa8qkwEz323nMCvnQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/booS25w3XCBT0qmwMl0HbX2D62yXBNu+E+mdDSk/6o=;
 b=8tf1wkh5NEkNxDHwxF7YyuDhQ7+FjM7fqowTabd7I6k2Q60p8Th7xjJ0/5s40zzHCzRHV4dtec1UkeZw2O23nyOaLPhvsdDj6rmeeakhCULGocmA7AptM/SAlphzu379tKH6Rqsv76tK1g8DdfII8Rrwy9Iks6XkI1HRF8ZL63I=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 563b55afa99a0513
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hiHb4hDFJvLOxpCQpvesgYqmQC9c/zBlEU71Z850S0LTOnM1DXomp9tRZaP74tO8s+7KDts5/nrqujzC1Lt1kuypfIoL0TaggXI/Dla0rDu09XVxE+Do5jv782s4ae2zRkWk1nisIOx5yOGX6G+rUckAyLiBvTENe2MXYuC/K0msoeh1wwXfeKl8DBVgYLG4P2TbYccKkpnKmOEM5K04DLW64Z8UcPS7EA601SDpO1LfbfZK0/X7mh2qQ6io7pW1GhSt5DW2dhpRDHg6q9rhgsmSQzIQethSFT+0Lpw57sq0nE5rIvggnEnF/s1y7R+hN4io1+EA9Ouioie8tLx3Cg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/booS25w3XCBT0qmwMl0HbX2D62yXBNu+E+mdDSk/6o=;
 b=Cowt+KMEEXZVscqwSFiN2feV0pFTdXUdB5U+o9vT2sqEK4qfIYSSsfOmurk0IVrcCujdA1ZqtJLuH78DsUswGm3DnGEc6HpPXapzBBEv0x+yvwmvb2FmIRIlOwx0Lmabf5aHdBU2DP3HSS1Xh1obGoZUF+k+84CpYQR7heZVqzJH0MN92d6Tf/uOhSlPu9FBd6fGqJW7xVBGc9j5HGkEJU46Ou6HnWEQ4gdIxabwxwg+dEeJymu4m1A4YEeMwKNtTCk3Bqcx8cm7AjjKIOFEudYI7Rc8ohyvGdpHeVN4JVTHBxdkojeF7O5LfRSMRCWQkWlg3XWJOFfI5zDWTxDMaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/booS25w3XCBT0qmwMl0HbX2D62yXBNu+E+mdDSk/6o=;
 b=8tf1wkh5NEkNxDHwxF7YyuDhQ7+FjM7fqowTabd7I6k2Q60p8Th7xjJ0/5s40zzHCzRHV4dtec1UkeZw2O23nyOaLPhvsdDj6rmeeakhCULGocmA7AptM/SAlphzu379tKH6Rqsv76tK1g8DdfII8Rrwy9Iks6XkI1HRF8ZL63I=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
	"marco.solieri@minervasys.tech" <marco.solieri@minervasys.tech>,
	"lucmiccio@gmail.com" <lucmiccio@gmail.com>, "carlo.nonato@minervasys.tech"
	<carlo.nonato@minervasys.tech>, Julien Grall <jgrall@amazon.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load
 Xen
Thread-Topic: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load
 Xen
Thread-Index: AQHY5iekhdeljnYaKUO3Ilpr3vGfIK4fBWIA
Date: Tue, 25 Oct 2022 11:56:42 +0000
Message-ID: <F7ED0618-C95F-45FE-932C-A27D75DC8206@arm.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-5-julien@xen.org>
In-Reply-To: <20221022150422.17707-5-julien@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|AS2PR08MB9689:EE_|AM7EUR03FT047:EE_|DB5PR08MB10162:EE_
X-MS-Office365-Filtering-Correlation-Id: 89c32bbf-d8a2-4b4f-dc07-08dab6800696
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 SiNVs1O2+8HHPL3qGv5TrZ1UQQI1U2KZtdyzVvkP8Hlx5m6LnoALTpJ4t0dULm/ynsTSEvuoAh2Lrvj5S3uMd5iTB6/Mq0Cbt/JDIxUldwZZ45ZPraTjT1cclcb7F7k7P9ef7N62sr6mQB6RfIrRmiVLxCinc/+3faGQOGMJDfHjBUEphoqxBzeBmXNZyXMhtTPKcwYetIdTI+H/hpUQvQs9R8w1MYQ/5zgM/w2M0GdQYMeD7ZiYseeRtI66nZeuk+b7gTO7iMfZJTwfkD/HI/U4HMv+gt1Nww/bhIWKyAFlcrGrDch7ntBTaaSey+F2hNxy/JVAnqWJBfPShg+4aTcAWWDAE/Ags3VA6rRhGIkwmfvUQkewg9ttfMDQ3wIUlpOzwD84VqFczjjsB0zQ9dIvgrevkm14Lqnt/pP1DfPhuhx1BooVt2Poon7f8A1I4778YaFAhiwH8LSX8OWCAOMqJD3TTvrxQ3e3a5sv/GmWT1c3InxR5VXlGNUARoEIkHQ/bcbAJX3WzpRUx3I+3a+H4xukhcVGSs5aquEG67Jk6dckphDDfeIS1xkWdc/zHw45LE0tHBZYZX5IKXAhYAWrkhKwxRoRX43WCrKKQyJJuVPIk9KVlqWP3nCSmou1WwbtR99hcX7IJ8VBg50FzPpxUSf6SRd0Y3oTCJoxMQvBFadfPoAVsfIowOdSQmXehVKxO3Rcd1nysQH7ESgW6LLFj5Mxfa404w83cEzMOI+hxvDU5Nty6jRHgl7jdDQVXCtsRHLoZATB1DArcqPdD3ynUKDEAHmGWA4TNLYIYp4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(451199015)(66556008)(76116006)(4326008)(36756003)(186003)(66946007)(478600001)(8676002)(64756008)(66476007)(38100700002)(83380400001)(41300700001)(2906002)(91956017)(6506007)(33656002)(66446008)(53546011)(54906003)(6916009)(38070700005)(6486002)(86362001)(26005)(2616005)(6512007)(71200400001)(316002)(5660300002)(8936002)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <1BEE2A5F9645E649854A7FF73316FFFB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9689
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	01249721-0bd3-45c5-f139-08dab67ffbd5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tUdlHwxWGqSEdwvcMW2i7arSEnWVwv/GjsLnRklq6mc6L0hrbt3i7dVr8rowdxZApnVL0cdqk37i5+y0gQmZ4d5IEkbqdSMCvrqDXNzMEIinCdPFTeKAS13qjxBMv5jMu6Va6ALhFA6mafobfPNhDsSP1+etONjDHC6NwIcBruk+mjdB1und0iyLyKdHVz8TnPNi4yFnHzqFRFlf9ikb3IFp3SiFyOf6ZanIc7NNJdXJ+LU8OiJxcby6gWwkTp3pMBvVjOX16uKEgLEJ65yw5B2EPKOsaULTtTewOB+obLHgYoW2UgN2fWYe7u1lmrE/bFfU6QoIoY4Ncpx/0cSlF8yOKTs1DAtTbsKrE5y5B048AYxIwdt9+tvFxp+sy2olVQH8geB6rT+ka6Bg86ir8ymySurppzG3C4a63UjRHyhz1DpLt+k31Xw0of44J5slIh2l7FSvNC5AZb+Gj8H8bgNxV/hicO92ZftuqQnGZtJ3kTexTDFtDVo/XnrdIPWhclD/QSIW6h2XenXhSuB2uj/YNN9K60HWVJvz+PZOW8pGFX5v9CwByQhubi0zOhKfWcq47OndDN/qbhKJnvB5z6b8jiyqPkDF7F6WJ2b/p9jGsoAq2fHuMMy5DnSX3NNqryj/sZMaS/+VZOmjSXOD2R3AWL0xpEAXzloaftDilRM7IWZ0UIMkhoEIqna3q7g5Dfa3TedYPLRL3nbS3FOjCsq1mjwkj2qAlBXliatulc/jWfwPq5TlQnoE8ZcZTEQOgOKNa394tQYOLQ7b1nNIAg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199015)(36840700001)(40470700004)(46966006)(478600001)(82310400005)(107886003)(6486002)(26005)(6512007)(36756003)(53546011)(6506007)(2616005)(70586007)(70206006)(86362001)(186003)(8936002)(4326008)(41300700001)(33656002)(82740400003)(356005)(40460700003)(8676002)(81166007)(6862004)(47076005)(5660300002)(2906002)(40480700001)(54906003)(316002)(36860700001)(83380400001)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 11:57:00.8184
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 89c32bbf-d8a2-4b4f-dc07-08dab6800696
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10162

DQoNCj4gT24gMjIgT2N0IDIwMjIsIGF0IDE2OjA0LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u
b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+
DQo+IA0KPiBBdCB0aGUgbW9tZW50LCBib290bG9hZGVycyBjYW4gbG9hZCBYZW4gYW55d2hlcmUg
aW4gbWVtb3J5IGJ1dCB0aGUNCj4gcmVnaW9uIDJNQiAtIDRNQi4gV2hpbGUgSSBhbSBub3QgYXdh
cmUgb2YgYW55IGlzc3VlLCB3ZSBoYXZlIG5vIHdheQ0KPiB0byB0ZWxsIHRoZSBib290bG9hZGVy
IHRvIGF2b2lkIHRoYXQgcmVnaW9uLg0KPiANCj4gSW4gYWRkaXRpb24gdG8gdGhhdCwgaW4gdGhl
IGZ1dHVyZSwgWGVuIG1heSBncm93IG92ZXIgMk1CIGlmIHdlDQo+IGVuYWJsZSBmZWF0dXJlIGxp
a2UgVUJTQU4gb3IgR0NPVi4gVG8gYXZvaWQgd2lkZW5pbmcgdGhlIHJlc3RyaWN0aW9uDQo+IG9u
IHRoZSBsb2FkIGFkZHJlc3MsIGl0IHdvdWxkIGJlIGJldHRlciB0byBnZXQgcmlkIG9mIGl0Lg0K
PiANCj4gV2hlbiB0aGUgaWRlbnRpdHkgbWFwcGluZyBpcyBjbGFzaGluZyB3aXRoIHRoZSBYZW4g
cnVudGltZSBtYXBwaW5nLA0KPiB3ZSBuZWVkIGFuIGV4dHJhIGluZGlyZWN0aW9uIHRvIGJlIGFi
bGUgdG8gcmVwbGFjZSB0aGUgaWRlbnRpdHkNCj4gbWFwcGluZyB3aXRoIHRoZSBYZW4gcnVudGlt
ZSBtYXBwaW5nLg0KPiANCj4gUmVzZXJ2ZSBhIG5ldyBtZW1vcnkgcmVnaW9uIHRoYXQgd2lsbCBi
ZSB1c2VkIHRvIHRlbXBvcmFyaWx5IG1hcCBYZW4uDQo+IEZvciBjb252ZW5pZW5jZSwgdGhlIG5l
dyBhcmVhIGlzIHJlLXVzaW5nIHRoZSBzYW1lIGZpcnN0IHNsb3QgYXMgdGhlDQo+IGRvbWhlYXAg
d2hpY2ggaXMgdXNlZCBmb3IgcGVyLWNwdSB0ZW1wb3JhcnkgbWFwcGluZyBhZnRlciBhIENQVSBo
YXMNCj4gYm9vdGVkLg0KPiANCj4gRnVydGhlcm1vcmUsIGRpcmVjdGx5IG1hcCBib290X3NlY29u
ZCAod2hpY2ggY292ZXIgWGVuIGFuZCBtb3JlKQ0KPiB0byB0aGUgdGVtcG9yYXJ5IGFyZWEuIFRo
aXMgd2lsbCBhdm9pZCB0byBhbGxvY2F0ZSBhbiBleHRyYSBwYWdlLXRhYmxlDQo+IGZvciB0aGUg
c2Vjb25kLWxldmVsIGFuZCB3aWxsIGhlbHBmdWwgZm9yIGZvbGxvdy11cCBwYXRjaGVzICh3ZSB3
aWxsDQo+IHdhbnQgdG8gdXNlIHRoZSBmaXhtYXAgd2hpbHN0IGluIHRoZSB0ZW1wb3JhcnkgbWFw
cGluZykuDQo+IA0KPiBMYXN0bHksIHNvbWUgcGFydCBvZiB0aGUgY29kZSBub3cgbmVlZHMgdG8g
a25vdyB3aGV0aGVyIHRoZSB0ZW1wb3JhcnkNCj4gbWFwcGluZyB3YXMgY3JlYXRlZC4gU28gcmVz
ZXJ2ZSByMTIgdG8gc3RvcmUgdGhpcyBpbmZvcm1hdGlvbi4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6
IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IC0tLS0NCj4gDQo+ICAgIENoYW5n
ZXMgaW4gdjI6DQo+ICAgICAgICAtIFBhdGNoIGFkZGVkDQo+IC0tLQ0KDQpIaSBKdWxpZW4sDQoN
CknigJltIGhpdHRpbmcgYW4gYXNzZXJ0IHdpdGggdGhpcyBvbmUsIHRlc3RlZCBvbiBxZW11IGFu
ZCBmdnA6DQoNClhlbiA0LjE3LXJjDQooWEVOKSBYZW4gdmVyc2lvbiA0LjE3LXJjICh1c2VyQGhv
c3RuYW1lKSAoYXJtLXBva3ktbGludXgtZ251ZWFiaS1nY2MgKEdDQykgMTEuMy4wKSBkZWJ1Zz15
IFR1ZSBPY3QgMjUgMTA6NTE6MDYgVVRDIDIwMjINCihYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6DQoo
WEVOKSBidWlsZC1pZDogYWIxNDNiMTNmNDM5NGNlZDUzMzFkNmZmMWNlZGViZGIyZmZhZGMwNw0K
KFhFTikgUHJvY2Vzc29yOiA0MTJmYzBmMTogIkFSTSBMaW1pdGVkIiwgdmFyaWFudDogMHgyLCBw
YXJ0IDB4YzBmLHJldiAweDENCihYRU4pIDMyLWJpdCBFeGVjdXRpb246DQooWEVOKSAgIFByb2Nl
c3NvciBGZWF0dXJlczogMDAwMDExMzE6MDAwMTEwMDENCihYRU4pICAgICBJbnN0cnVjdGlvbiBT
ZXRzOiBBQXJjaDMyIEEzMiBUaHVtYiBUaHVtYi0yIFRodW1iRUUgSmF6ZWxsZQ0KKFhFTikgICAg
IEV4dGVuc2lvbnM6IEdlbmVyaWNUaW1lcg0KKFhFTikgICBEZWJ1ZyBGZWF0dXJlczogMDIwMTA1
NTUNCihYRU4pICAgQXV4aWxpYXJ5IEZlYXR1cmVzOiAwMDAwMDAwMA0KKFhFTikgICBNZW1vcnkg
TW9kZWwgRmVhdHVyZXM6IDEwMjAxMTA1IDIwMDAwMDAwDQooWEVOKSAgICAgICAgICAgICAgICAg
ICAgICAgICAgMDEyNDAwMDAgMDIxMDIyMTENCihYRU4pICAgSVNBIEZlYXR1cmVzOiAwMjEwMTEx
MCAxMzExMjExMSAyMTIzMjA0MQ0KKFhFTikgICAgICAgICAgICAgICAgIDExMTEyMTMxIDEwMDEx
MTQyIDAwMDAwMDAwDQooWEVOKSBVc2luZyBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjANCihY
RU4pIFVzaW5nIFBTQ0kgdjAuMg0KKFhFTikgU01QOiBBbGxvd2luZyA0IENQVXMNCihYRU4pIEdl
bmVyaWMgVGltZXIgSVJROiBwaHlzPTMwIGh5cD0yNiB2aXJ0PTI3IEZyZXE6IDYyNTAwIEtIeg0K
KFhFTikgR0lDdjJtIGV4dGVuc2lvbiByZWdpc3RlciBmcmFtZToNCihYRU4pICAgICAgICAgZ2lj
X3YybV9hZGRyPTAwMDAwMDAwMDgwMjAwMDANCihYRU4pICAgICAgICAgZ2ljX3YybV9zaXplPTAw
MDAwMDAwMDAwMDEwMDANCihYRU4pICAgICAgICAgZ2ljX3YybV9zcGlfYmFzZT04MA0KKFhFTikg
ICAgICAgICBnaWNfdjJtX251bV9zcGlzPTY0DQooWEVOKSBHSUN2MiBpbml0aWFsaXphdGlvbjoN
CihYRU4pICAgICAgICAgZ2ljX2Rpc3RfYWRkcj0wMDAwMDAwMDA4MDAwMDAwDQooWEVOKSAgICAg
ICAgIGdpY19jcHVfYWRkcj0wMDAwMDAwMDA4MDEwMDAwDQooWEVOKSAgICAgICAgIGdpY19oeXBf
YWRkcj0wMDAwMDAwMDA4MDMwMDAwDQooWEVOKSAgICAgICAgIGdpY192Y3B1X2FkZHI9MDAwMDAw
MDAwODA0MDAwMA0KKFhFTikgICAgICAgICBnaWNfbWFpbnRlbmFuY2VfaXJxPTI1DQooWEVOKSBH
SUN2MjogMjg4IGxpbmVzLCA0IGNwdXMgKElJRCAwMDAwMDAwMCkuDQooWEVOKSBYU00gRnJhbWV3
b3JrIHYxLjAuMSBpbml0aWFsaXplZA0KKFhFTikgSW5pdGlhbGlzaW5nIFhTTSBTSUxPIG1vZGUN
CihYRU4pIFVzaW5nIHNjaGVkdWxlcjogU01QIENyZWRpdCBTY2hlZHVsZXIgcmV2MiAoY3JlZGl0
MikNCihYRU4pIEluaXRpYWxpemluZyBDcmVkaXQyIHNjaGVkdWxlcg0KKFhFTikgIGxvYWRfcHJl
Y2lzaW9uX3NoaWZ0OiAxOA0KKFhFTikgIGxvYWRfd2luZG93X3NoaWZ0OiAzMA0KKFhFTikgIHVu
ZGVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogMA0KKFhFTikgIG92ZXJsb2FkX2JhbGFuY2VfdG9s
ZXJhbmNlOiAtMw0KKFhFTikgIHJ1bnF1ZXVlcyBhcnJhbmdlbWVudDogc29ja2V0DQooWEVOKSAg
Y2FwIGVuZm9yY2VtZW50IGdyYW51bGFyaXR5OiAxMG1zDQooWEVOKSBsb2FkIHRyYWNraW5nIHdp
bmRvdyBsZW5ndGggMTA3Mzc0MTgyNCBucw0KKFhFTikgQWxsb2NhdGVkIGNvbnNvbGUgcmluZyBv
ZiAzMiBLaUIuDQooWEVOKSBWRlAgaW1wbGVtZW50ZXIgMHg0MSBhcmNoaXRlY3R1cmUgNCBwYXJ0
IDB4MzAgdmFyaWFudCAweGYgcmV2IDB4MA0KKFhFTikgQ1BVMDogR3Vlc3QgYXRvbWljcyB3aWxs
IHRyeSAxIHRpbWVzIGJlZm9yZSBwYXVzaW5nIHRoZSBkb21haW4NCihYRU4pIEJyaW5naW5nIHVw
IENQVTENCihYRU4pIEFzc2VydGlvbiAnIWxwYWVfaXNfdmFsaWQoKmVudHJ5KScgZmFpbGVkIGF0
IGFyY2gvYXJtL2RvbWFpbl9wYWdlLmM6NjkNCihYRU4pIC0tLS1bIFhlbi00LjE3LXJjICBhcm0z
MiAgZGVidWc9eSAgTm90IHRhaW50ZWQgXS0tLS0NCihYRU4pIENQVTogICAgMA0KKFhFTikgUEM6
ICAgICAwMDI2OWFmNCBpbml0X2RvbWhlYXBfbWFwcGluZ3MrMHgxNzgvMHgxN2MNCihYRU4pIENQ
U1I6ICAgMjAwMDAwNWEgTU9ERTpIeXBlcnZpc29yDQooWEVOKSAgICAgIFIwOiAwMDJmZmU0OCBS
MTogMDAwMDAwN2YgUjI6IGJmZmY4ZjdkIFIzOiAwMDQwMDAwMA0KKFhFTikgICAgICBSNDogMDAw
YmZmZjggUjU6IDQzZmZhMDEwIFI2OiAwMDAwMDAwMSBSNzogNDNmZmEwMDANCihYRU4pICAgICAg
Ujg6IDQzZmY4MDAwIFI5OiAwMDAwMDAwMCBSMTA6MDAwMDAwMDAgUjExOjAwMmZmZTZjIFIxMjow
MDBiZmZmOA0KKFhFTikgSFlQOiBTUDogMDAyZmZlNDQgTFI6IDAwMjY5YTJjDQooWEVOKQ0KKFhF
TikgICBWVENSX0VMMjogMDAwMDAwMDANCihYRU4pICBWVFRCUl9FTDI6IDAwMDAwMDAwMDAwMDAw
MDANCihYRU4pDQooWEVOKSAgU0NUTFJfRUwyOiAzMGNkMTg3Zg0KKFhFTikgICAgSENSX0VMMjog
MDAwMDAwMzgNCihYRU4pICBUVEJSMF9FTDI6IDAwMDAwMDAwNDAxNGEwMDANCihYRU4pDQooWEVO
KSAgICBFU1JfRUwyOiAwMDAwMDAwMA0KKFhFTikgIEhQRkFSX0VMMjogMDAwMDAwMDANCihYRU4p
ICAgICAgSERGQVI6IDAwMDAwMDAwDQooWEVOKSAgICAgIEhJRkFSOiAwMDAwMDAwMA0KKFhFTikN
CihYRU4pIFhlbiBzdGFjayB0cmFjZSBmcm9tIHNwPTAwMmZmZTQ0Og0KKFhFTikgICAgMDAwMDAw
MDAgYmZmZjhmN2QgMDA0MDAwMDAgMDAyZmZlNmMgNDNmZmEwMDAgMDAwMDAwMDEgMDAyYTYwMDAg
MDAzM2IyMjQNCihYRU4pICAgIDAwMmEyZWM4IDAwMmZmZTg0IDAwMjcwMGNjIDAwMDAwMDAxIDAw
MDAwMDAwIDAwMmE2MDAwIDAwMzNiMjI0IDAwMmZmZWI0DQooWEVOKSAgICAwMDI3NjMzOCAwMDAw
MDAwMSAwMDJhNjAwMCAwMDMzYjIyNCAwMDAwMDAwMSAwMDAwMDAwMCAwMDJhNjAwMCAwMDMzYjIy
NA0KKFhFTikgICAgMDAyYTJlYzggMDAwMDAwMDAgMDAwMDAwMDAgMDAyZmZlY2MgMDAyMDE4NWMg
MDAyZmZlY2MgMDAyYWQ5NzggMDAwMDAwMDENCihYRU4pICAgIDAwMDAwMDAxIDAwMmZmZjU0IDAw
MmM3ZDgwIDExMTEyMTMxIDEwMDExMTQyIDAwMDAwMDAwIDAwMmE0NzQ0IDAwMDAwMDAwDQooWEVO
KSAgICAwMDAwMDAwMCAwMDAwOGYyMCAwMDAwNDAwMCA0ODAwMDAwMCAwMDJlMDFmMCAwMDAwMDAw
MCBjMDAwMDAwMCAwMDAwMDAwMA0KKFhFTikgICAgNDAwMDAwMDAgMDAwMDAwMDEgMDAyZTAyMDgg
MDAyYTZlODQgMDAyYTZlODAgMDAyYWZhYTAgMDAyZTMxZjAgMDAwMDAwMDANCihYRU4pICAgIGMw
MDAwMDAwIDAwMDAwMDAzIGZmZmZmZmZmIDAwMDAwMDAwIDAwMmE5MDAwIDAwMjAwMDVjIDAwMDAw
MDAwIDAwMDAwMDAwDQooWEVOKSAgICA0ODAwMDAwMCA0MDAxMDAwMCAzZmUxMDAwMCAwMDAwMDAw
MCAwMDIwMDA2NCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMA0KKFhFTikgICAgMDAwMDAwMDAg
MDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAw
MDAwMDANCihYRU4pICAgIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAw
MDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwDQooWEVOKSAgICAwMDAwMDAwMCAwMDAwMDAw
MCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMA0K
KFhFTikgICAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAw
MDAwMDAgMDAwMDAwMDAgMDAwMDAwMDANCihYRU4pICAgIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAw
MDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwDQooWEVOKSBYZW4gY2FsbCB0
cmFjZToNCihYRU4pICAgIFs8MDAyNjlhZjQ+XSBpbml0X2RvbWhlYXBfbWFwcGluZ3MrMHgxNzgv
MHgxN2MgKFBDKQ0KKFhFTikgICAgWzwwMDI2OWEyYz5dIGluaXRfZG9taGVhcF9tYXBwaW5ncysw
eGIwLzB4MTdjIChMUikNCihYRU4pICAgIFs8MDAyNzAwY2M+XSBpbml0X3NlY29uZGFyeV9wYWdl
dGFibGVzKzB4NjAvMHgxNjgNCihYRU4pICAgIFs8MDAyNzYzMzg+XSBfX2NwdV91cCsweDM4LzB4
MWQ4DQooWEVOKSAgICBbPDAwMjAxODVjPl0gY3B1X3VwKzB4ZTAvMHgxMTQNCihYRU4pICAgIFs8
MDAyYzdkODA+XSBzdGFydF94ZW4rMHhkNDAvMHgxMTM4DQooWEVOKSAgICBbPDAwMjAwMDY0Pl0g
aGVhZC5vI3ByaW1hcnlfc3dpdGNoZWQrMHg4LzB4MTgNCihYRU4pDQooWEVOKQ0KKFhFTikgKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKg0KKFhFTikgUGFuaWMgb24gQ1BV
IDA6DQooWEVOKSBBc3NlcnRpb24gJyFscGFlX2lzX3ZhbGlkKCplbnRyeSknIGZhaWxlZCBhdCBh
cmNoL2FybS9kb21haW5fcGFnZS5jOjY5DQooWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqDQooWEVOKQ0KKFhFTikgUmVib290IGluIGZpdmUgc2Vjb25kcy4uLg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 11:57:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 11:57:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429800.681059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIYn-00062A-U7; Tue, 25 Oct 2022 11:57:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429800.681059; Tue, 25 Oct 2022 11:57:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIYn-000623-Q5; Tue, 25 Oct 2022 11:57:33 +0000
Received: by outflank-mailman (input) for mailman id 429800;
 Tue, 25 Oct 2022 11:51:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=I61z=22=minervasys.tech=andrea.bastoni@srs-se1.protection.inumbo.net>)
 id 1onISs-0004pv-JK
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 11:51:26 +0000
Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com
 [2a00:1450:4864:20::32b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5a02fb96-545b-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 13:51:24 +0200 (CEST)
Received: by mail-wm1-x32b.google.com with SMTP id t4so8101840wmj.5
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 04:51:24 -0700 (PDT)
Received: from [192.168.1.23] (ip5f5be846.dynamic.kabel-deutschland.de.
 [95.91.232.70]) by smtp.gmail.com with ESMTPSA id
 m10-20020adfe0ca000000b00236627c078esm2317579wri.110.2022.10.25.04.51.22
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 25 Oct 2022 04:51:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a02fb96-545b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=u7krCdkWMVVSINdeV4hrDuqG0Kg4EO+RAA3Lmlinlcc=;
        b=hYp+babfx+MDhi9xD9OfcgSyZxOjxHzI4rI/O5JSqFbWwS4Iq8bQZkhaGbH7WCO9cx
         Pera2MtsgvxwLhapUrzoUIWfQvlmhuTggLkie1rikngWeDbGxhDgvA9uJTphaKJwdfDF
         VAyZsprPNwLMfDxIkooYEZVYDoFK23H7STRux3LBEWZX+bcwEXOaugEREL1OUYrXDfMw
         9MrENeutR7YZ1JeBg1pbqdkbw106nE8mpNrvnhG0xd5mpPgNXeBSdYRdoWWbN8ga3mEk
         /RoAoV93crO+Gay7dEpudqxZl4/jptbKm8fty8rvEMS7jra4wxLD494aHRGdMP9dQ59K
         07gQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=u7krCdkWMVVSINdeV4hrDuqG0Kg4EO+RAA3Lmlinlcc=;
        b=y2lfV2LJ4ujlw081iVjo9HafHMIBrUMBzAPt7c1MpGEQ8v28UyB2BdyOjBbgbpcD20
         qCKXLEhzcpqRfHY9uCVoJE0N4zVf1c3n9smHoS/YEta4TpDFbHChEU3kyP4JVnn89JXi
         C15I6Xca6O6CeFL1W+a9eBN2eZfOYkeDieMsaQFNwrydO9j24teaQnRHF6mlUJPIuuFJ
         80Re3j+bcQEHm3vgNJauNqgDG6uU1vpGjC2+ihQ6KKKc+ruwt+QtbAB8WYXbxiT6XDYm
         XwpppEbZJcOfwPcBoJ8I5i0GkgTXmklMRpROtaWxEtoFObcna+WP0WXxj9RKvPxIq3TZ
         Toyg==
X-Gm-Message-State: ACrzQf2lKjnsqWxWyvdSAmwjd4q/cHhvUfEcbkteKzFCwvNZ8BaS8WhM
	Q1pDr7a2C4HmzbICXVB2gwplPQ==
X-Google-Smtp-Source: AMsMyM7CiJlgJg7nsS109AOYTmPj+En7IYeIcfSQ97yMGD1bMsoHr/ooRQ99Nr8GDGX6OCY2ihdm/w==
X-Received: by 2002:a05:600c:538a:b0:3c6:c223:7ec5 with SMTP id hg10-20020a05600c538a00b003c6c2237ec5mr26201757wmb.37.1666698684194;
        Tue, 25 Oct 2022 04:51:24 -0700 (PDT)
Message-ID: <e72b1fb4-3baa-63f4-fb65-bc4a33a60082@minervasys.tech>
Date: Tue, 25 Oct 2022 13:51:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH 02/12] xen/arm: add cache coloring initialization for
 domains
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Carlo Nonato
 <carlo.nonato@minervasys.tech>, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com,
 stefano.stabellini@amd.com, wl@xen.org, marco.solieri@unimore.it,
 lucmiccio@gmail.com, Marco Solieri <marco.solieri@minervasys.tech>,
 Jan Kiszka <jan.kiszka@siemens.com>
References: <20220826125111.152261-1-carlo.nonato@minervasys.tech>
 <20220826125111.152261-3-carlo.nonato@minervasys.tech>
 <308a7afa-a3c9-b500-06c1-3d4cbe8bbf65@xen.org>
 <CAG+AhRUT75hkaLZi0v0E_ozzyUY9QLHYGTamhXAoKfV2gZMwfg@mail.gmail.com>
 <9a996e9d-d9ce-f562-122d-1e661d25614c@xen.org>
From: Andrea Bastoni <andrea.bastoni@minervasys.tech>
In-Reply-To: <9a996e9d-d9ce-f562-122d-1e661d25614c@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Julien,

On 25/10/2022 13:15, Julien Grall wrote:
> 
> 
> On 25/10/2022 11:53, Carlo Nonato wrote:
>> Hi Julien,
>>
>> On Fri, Oct 21, 2022 at 8:02 PM Julien Grall <julien@xen.org> wrote:
>>>
>>> Hi Carlo,
>>>
>>> On 26/08/2022 13:51, Carlo Nonato wrote:
>>>> This commit adds array pointers to domains as well as to the hypercall
>>>> and configuration structure employed in domain creation. The latter is used
>>>> both by the toolstack and by Xen itself to pass configuration data to the
>>>> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to be
>>>> able to access guest memory in the first case. This implies special care for
>>>> the copy of the configuration data into the domain data, meaning that a
>>>> discrimination variable for the two possible code paths (coming from Xen or
>>>> from the toolstack) is needed.
>>>
>>> So this means that a toolstack could set from_guest. I know the
>>> toolstack is trusted... However, we should try to limit when the trust
>>> when this is possible.
>>>
>>> In this case, I would consider to modify the prototype of
>>> domain_create() to pass internal information.
>>
>> Doing as you said isn't a bit too invasive? I should also change all the call
>> sites of domain_create() and this means x86 too.
> 
> Yes there will be a few calls to modify. But this is better than hacking the 
> hypercall interface to cater for internal use.
> 
>> Isn't there an easier way to spot a guest address? Maybe just looking at the
>> address value... 
> 
> HVM/Arm guest have a separate address space. So it is not possible to 
> differentiate between guest vs hypervisor address.
> 
>> Or maybe adding an internal flag to the do_domctl() path.
> IIUC, this flag would indicate whether the XEN_GUEST_HANDLE() is an hypervisor 
> or guest address. Is that correct?
> 
> If so, I dislike it. I am not sure what the other maintainers think, but 
> personally updating domain_create() is my preferred way.
> 
> [...]
> 
>>>>    void arch_domain_shutdown(struct domain *d)
>>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>>>> index 3fd1186b53..4d4cb692fc 100644
>>>> --- a/xen/arch/arm/domain_build.c
>>>> +++ b/xen/arch/arm/domain_build.c
>>>> @@ -33,6 +33,12 @@
>>>>    #include <xen/grant_table.h>
>>>>    #include <xen/serial.h>
>>>>
>>>> +#ifdef CONFIG_CACHE_COLORING
>>>> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged
>>>> +#else
>>>> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap
>>>> +#endif
>>>
>>> I can't remember if I asked it before and it doesn't seem to written
>>> everywhere. This check suggest that it is not possible to use the same
>>> Xen binary for coloring and non-coloring.
>>
>> If coloring is enabled, all the domains are colored (even if they use
>> zero colors
>> because of the default selection). This means that they are going to use
>> the colored allocator. Since this all-or-nothing design, if coloring is
>> enabled, dom0 is assumed to be colored, which implies removing the directmap
>> flag. So if what you mean with "same Xen binary for coloring and non-coloring"
>> is to have a way to select at runtime if a domain is colored, or if Xen
>> itself is colored, the answer is no, we don't have this right now.
> 
> [...]
> 
>>
>>> At the moment, we have been able to have all the features in the same
>>> Xen binary. So what are the reasons for this restriction?
>>
>> Not sure about the first sentence (you mean, until this patch?),
> 
> Yes.
> 
>> but the
>> restriction is just because it's simpler. For example if we have to support
>> colored and non-colored domains at the same time,
> 
> I am not asking for supporting a mix of colored and non-colored domains. What I 
> am asking is to have a runtime switch (rather than compile time) to decide 
> whether the system is colored or not.
> 
> IOW, why can't system-wide coloring be selected at runtime?
> 
>> we probably need to
>> change something in the allocator (at least reserving more memory for the
>> buddy).
> 
> This sentence picked my interesting. How do you decide the size of the buddy today?
> 
> [...]
> 
>>>> +#ifdef CONFIG_CACHE_COLORING
>>>> +    unsigned int *colors;
>>>> +    unsigned int num_colors;
>>>> +#endif >
>>>>        /* Virtual MMU */
>>>>        struct p2m_domain p2m;
>>>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>>>> index c8b6058d3a..adf843a7a1 100644
>>>> --- a/xen/include/public/arch-arm.h
>>>> +++ b/xen/include/public/arch-arm.h
>>>> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>>>>    #define XEN_DOMCTL_CONFIG_TEE_NONE      0
>>>>    #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>>>>
>>>> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);
>>>
>>> You don't seem to use "color_t" outside of arch-arm.h and we already
>>> define guest handle for "unsigned int". So can they be used?
>>
>> That's because the guest handle for "unsigned int" is defined later
>> (in public/xen.h).
> 
> Hmmm... And I guess we can't define "unsigned int" earlier because they rely on 
> macro defined in arch-arm.h?
> 
>> We can also think of moving the coloring fields from this
>> struct to the common one (xen_domctl_createdomain) protecting them with
>> the proper #ifdef (but we are targeting only arm64...).
> 
> Your code is targeting arm64 but fundamentally this is an arm64 specific 
> feature. IOW, this could be used in the future on other arch. So I think it 
> would make sense to define it in common without the #ifdef.

As additional information on this point, we had in the past some discussion in 
the context of cache-coloring and Jailhouse (+CC Jan):

https://groups.google.com/g/jailhouse-dev/c/K4rqZxpxa0U/m/lsvy5HXcAAAJ

x86 has CAT and RDT, and supporting software coloring was not in scope for 
Jailhouse. The discussion was more on perspective support for RISC-V.

Best,

> @x86 maintainers, what do you think?
> 
>>
>>>> +
>>>>    struct xen_arch_domainconfig {
>>>>        /* IN/OUT */
>>>>        uint8_t gic_version;
>>>> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
>>>>         *
>>>>         */
>>>>        uint32_t clock_frequency;
>>>> +    /* IN */
>>>> +    uint8_t from_guest;
>>>
>>> There is an implicit padding here and ...
>>>> +    /* IN */
>>>> +    uint16_t num_colors;
>>>
>>> ... here. For the ABI, we are trying to have all the padding explicit.
>>> So the layout of the structure is clear.
>>
>> Isn't it true also for other fields like gic_version and tee_type?
> 
> Indeed, there is missing explicit padding after gic_version. There is no padding 
> necessary after 'tee_type'.
> 
> I am not asking you to fix the existing missing padding, however we should avoid 
> to introduce new ones.
> 
> Cheers,
> 
-- 
Thanks,
Andrea Bastoni



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 12:07:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 12:07:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429825.681074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIiX-00086h-Di; Tue, 25 Oct 2022 12:07:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429825.681074; Tue, 25 Oct 2022 12:07:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIiX-00086a-9e; Tue, 25 Oct 2022 12:07:37 +0000
Received: by outflank-mailman (input) for mailman id 429825;
 Tue, 25 Oct 2022 12:07:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/6Q6=22=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1onIiV-00086U-Qw
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 12:07:35 +0000
Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com
 [2a00:1450:4864:20::635])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9bd4c5d6-545d-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 14:07:34 +0200 (CEST)
Received: by mail-ej1-x635.google.com with SMTP id d26so11813359eje.10
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 05:07:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9bd4c5d6-545d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=suLLlTbmaGDZE5pxrVu9v1HD5L7MTGFkWyKHXkRaRsY=;
        b=w4MKl3YT+DhUBTRWm/Ay0Ed7FnLISylDyybZ+0IyJZvpNzWHd+yV4Y3nzKzsuSgGa5
         LeNk2naWs9rpAJ8hWnEkxtZnnSXqEKE4djySpLnokZGRVVHoo/YAoLl+qsQQda4Tzh2V
         3M1DMEfJ/LszakFpLVrOjN+po3TRSNvxCy938f2kQDu1lMS+1zDcrcpBZpRb9Q3Kq/Im
         l8ERZ5125MAPNDrpFIh2qDH+uh29PVfh7ltrMrnC/WRZUiJVvYjpjR2yYSARjQ66xb/i
         u9TUzJTEPyoLMe7NdHmivemXW6hbY8WLXJwRZ16tx4A2gqGJfHxrqson/6t8nH+REpCp
         qrKA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=suLLlTbmaGDZE5pxrVu9v1HD5L7MTGFkWyKHXkRaRsY=;
        b=1WGvnvZSgaTS4IRSc8eFX+Gv0gZjQjnEMetCQ54QFcL3HlsLN06k+iCRzwwBmv5fsL
         rhqMrJwRQPjWKl8hwcW232IBBK3O+Ni7+gcZzxQs5aP79oAok3IRPS1dtAsCQ1jmj32a
         z91IcsZoH0ynZVowZvA0xi1k8cGAjkQZqDxzIcGf7gjOvQ4hB3INnhtp4BZV5ycZ1gpH
         BiNdU2HVOfnyEc4NWy6vzYZD7Yck3L4GEhelm+0ifZWmDwKYi2imVF1L+EhFGlI1tLAz
         ba/emmNQdxVxYxR+b8tJ14QCiFpnjYnw99v+uraK/IDWvfZq60DdjC/IZ1zEuD+70mUw
         DM7A==
X-Gm-Message-State: ACrzQf27dyTLTbyLY/PE0ixpBzQJuJxEB+jRm4xxg22b0XVjtytLd2QR
	c0MJoh1MMlM2hTza3982Z5g1Kk/HI8kjRom6T9+n0S+/E+I=
X-Google-Smtp-Source: AMsMyM4X64D1Y6/LOeyQ5dFYMN/PaV3xnws9ryQ6A7Ro+aavqv0X42WUllfgbn/aaL9FomeHulQuCbIRc254Dtf2YZM=
X-Received: by 2002:a17:907:a059:b0:7a5:587d:d315 with SMTP id
 gz25-20020a170907a05900b007a5587dd315mr11047582ejc.631.1666699653310; Tue, 25
 Oct 2022 05:07:33 -0700 (PDT)
MIME-Version: 1.0
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-3-carlo.nonato@minervasys.tech>
In-Reply-To: <20221022155120.7000-3-carlo.nonato@minervasys.tech>
From: Carlo Nonato <carlo.nonato@minervasys.tech>
Date: Tue, 25 Oct 2022 14:07:22 +0200
Message-ID: <CAG+AhRU_b7XS61DDyB6rCOQQ=mbEhHpe3pJm3B_BJpRSe+4aOg@mail.gmail.com>
Subject: Re: [PATCH v3 2/9] xen/arm: add cache coloring initialization for domains
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, 
	lucmiccio@gmail.com, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Marco Solieri <marco.solieri@minervasys.tech>
Content-Type: text/plain; charset="UTF-8"

On Sat, Oct 22, 2022 at 5:51 PM Carlo Nonato
<carlo.nonato@minervasys.tech> wrote:
>
> This commit adds array pointers to domains as well as to the hypercall
> and configuration structure employed in domain creation. The latter is used
> both by the toolstack and by Xen itself to pass configuration data to the
> domain creation function, so the XEN_GUEST_HANDLE macro must be adopted to
> be able to access guest memory in the first case. This implies special care
> for the copy of the configuration data into the domain data, meaning that a
> discrimination variable for the two possible code paths (coming from Xen or
> from the toolstack) is needed.
>
> The initialization and free functions for colored domains are also added.
> The former is responsible for allocating and populating the color array
> of the domain and it also checks for configuration issues. One of those
> issues is enabling both coloring and directmap for the domain because they
> contradicts one another. Since that, Dom0 must not be created with the
> directmap flag.
> The latter instead frees allocated memory.
>
> Based on original work from: Luca Miccio <lucmiccio@gmail.com>
>
> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> ---
> v3:
> - xfree() for colors array in case of errors in domain_coloring_init()
> ---
>  docs/misc/arm/cache-coloring.rst    | 14 ++++++-
>  xen/arch/arm/coloring.c             | 57 +++++++++++++++++++++++++++++
>  xen/arch/arm/domain.c               |  7 ++++
>  xen/arch/arm/domain_build.c         | 13 ++++++-
>  xen/arch/arm/include/asm/coloring.h | 10 +++++
>  xen/arch/arm/include/asm/domain.h   |  4 ++
>  xen/include/public/arch-arm.h       |  8 ++++
>  7 files changed, 110 insertions(+), 3 deletions(-)
>
> diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
> index b0f9a2e917..e8ee8fafde 100644
> --- a/docs/misc/arm/cache-coloring.rst
> +++ b/docs/misc/arm/cache-coloring.rst
> @@ -16,7 +16,7 @@ In order to enable and use it, few steps are needed.
>    (refer to menuconfig help for value meaning and when it should be changed).
>
>          CONFIG_MAX_CACHE_COLORS=<n>
> -- Assign colors to Dom0 using the `Color selection format`_ (see
> +- Assign colors to domains using the `Color selection format`_ (see
>    `Coloring parameters`_ for more documentation pointers).
>
>  Background
> @@ -114,6 +114,9 @@ LLC way size (as previously discussed) and Dom0 colors can be set using the
>  appropriate command line parameters. See the relevant documentation in
>  "docs/misc/xen-command-line.pandoc".
>
> +Note that if no color configuration is provided for domains, they fallback to
> +the default one, which corresponds simply to all available colors.
> +
>  Known issues and limitations
>  ****************************
>
> @@ -133,3 +136,12 @@ too) is set to 2^15 = 32768 colors because of some limitation on the domain
>  configuration structure size used in domain creation. "uint16_t" is the biggest
>  integer type that fit the constraint and 2^15 is the biggest power of 2 it can
>  easily represent. This value is big enough for the generic case, though.
> +
> +
> +"xen,static-mem" isn't supported when coloring is enabled
> +#########################################################
> +
> +In the domain configuration, "xen,static-mem" allows memory to be statically
> +allocated to the domain. This isn't possibile when cache coloring is enabled,
> +because that memory can't be guaranteed to be of the same colors assigned to
> +that domain.
> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
> index 36eea2d6c0..a7b59f5aba 100644
> --- a/xen/arch/arm/coloring.c
> +++ b/xen/arch/arm/coloring.c
> @@ -23,6 +23,7 @@
>   */
>  #include <xen/bitops.h>
>  #include <xen/errno.h>
> +#include <xen/guest_access.h>
>  #include <xen/keyhandler.h>
>  #include <xen/param.h>
>  #include <xen/types.h>
> @@ -232,6 +233,62 @@ bool __init coloring_init(void)
>      return true;
>  }
>
> +int domain_coloring_init(struct domain *d,
> +                         const struct xen_arch_domainconfig *config)
> +{
> +    if ( is_domain_direct_mapped(d) )
> +    {
> +        printk(XENLOG_ERR
> +               "Can't enable coloring and directmap at the same time for %pd\n",
> +               d);
> +        return -EINVAL;
> +    }
> +
> +    if ( is_hardware_domain(d) )
> +    {
> +        d->arch.colors = dom0_colors;
> +        d->arch.num_colors = dom0_num_colors;
> +    }
> +    else if ( config->num_colors == 0 )
> +    {
> +        printk(XENLOG_WARNING
> +               "Color config not found for %pd. Using default\n", d);
> +        d->arch.colors = xzalloc_array(unsigned int, max_colors);
> +        d->arch.num_colors = set_default_domain_colors(d->arch.colors);
> +    }
> +    else
> +    {
> +        d->arch.colors = xzalloc_array(unsigned int, config->num_colors);
> +        d->arch.num_colors = config->num_colors;
> +        if ( config->from_guest )
> +            copy_from_guest(d->arch.colors, config->colors, config->num_colors);
> +        else
> +            memcpy(d->arch.colors, config->colors.p,
> +                   sizeof(unsigned int) * config->num_colors);
> +    }
> +
> +    if ( !d->arch.colors )
> +    {
> +        printk(XENLOG_ERR "Colors allocation failed for %pd\n", d);
> +        return -ENOMEM;
> +    }
> +
> +    if ( !check_colors(d->arch.colors, d->arch.num_colors) )
> +    {
> +        printk(XENLOG_ERR "Bad color config for %pd\n", d);
> +        domain_coloring_free(d);

This results in a double free since the colors array is freed also
in arch_domain_destroy(). This will be reverted in v4.

> +        return -EINVAL;
> +    }
> +
> +    return 0;
> +}
> +
> +void domain_coloring_free(struct domain *d)
> +{
> +    if ( !is_hardware_domain(d) )
> +        xfree(d->arch.colors);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2d6253181a..b4dd64dff4 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -23,6 +23,7 @@
>  #include <xen/wait.h>
>
>  #include <asm/alternative.h>
> +#include <asm/coloring.h>
>  #include <asm/cpuerrata.h>
>  #include <asm/cpufeature.h>
>  #include <asm/current.h>
> @@ -712,6 +713,10 @@ int arch_domain_create(struct domain *d,
>      ioreq_domain_init(d);
>  #endif
>
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) &&
> +        (rc = domain_coloring_init(d, &config->arch)) )
> +        goto fail;
> +
>      /* p2m_init relies on some value initialized by the IOMMU subsystem */
>      if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
>          goto fail;
> @@ -807,6 +812,8 @@ void arch_domain_destroy(struct domain *d)
>                         get_order_from_bytes(d->arch.efi_acpi_len));
>  #endif
>      domain_io_free(d);
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
> +        domain_coloring_free(d);
>  }
>
>  void arch_domain_shutdown(struct domain *d)
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 40e3c2e119..97f2060007 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -35,6 +35,12 @@
>
>  #define STATIC_EVTCHN_NODE_SIZE_CELLS 2
>
> +#ifdef CONFIG_CACHE_COLORING
> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged
> +#else
> +#define XEN_DOM0_CREATE_FLAGS CDF_privileged | CDF_directmap
> +#endif
> +
>  static unsigned int __initdata opt_dom0_max_vcpus;
>  integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
>
> @@ -3963,7 +3969,10 @@ static int __init construct_dom0(struct domain *d)
>      /* type must be set before allocate_memory */
>      d->arch.type = kinfo.type;
>  #endif
> -    allocate_memory_11(d, &kinfo);
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
> +        allocate_memory(d, &kinfo);
> +    else
> +        allocate_memory_11(d, &kinfo);
>      find_gnttab_region(d, &kinfo);
>
>  #ifdef CONFIG_STATIC_SHM
> @@ -4025,7 +4034,7 @@ void __init create_dom0(void)
>      if ( iommu_enabled )
>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>
> -    dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap);
> +    dom0 = domain_create(0, &dom0_cfg, XEN_DOM0_CREATE_FLAGS);
>      if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
>          panic("Error creating domain 0\n");
>
> diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
> index 3b563d3b90..0d2dfada10 100644
> --- a/xen/arch/arm/include/asm/coloring.h
> +++ b/xen/arch/arm/include/asm/coloring.h
> @@ -27,12 +27,22 @@
>  #ifdef CONFIG_CACHE_COLORING
>
>  #include <xen/init.h>
> +#include <xen/sched.h>
> +
> +#include <public/arch-arm.h>
>
>  bool __init coloring_init(void);
>
> +int domain_coloring_init(struct domain *d,
> +                         const struct xen_arch_domainconfig *config);
> +void domain_coloring_free(struct domain *d);
> +
>  #else /* !CONFIG_CACHE_COLORING */
>
>  static inline bool __init coloring_init(void) { return true; }
> +static inline int domain_coloring_init(
> +    struct domain *d, const struct xen_arch_domainconfig *config) { return 0; }
> +static inline void domain_coloring_free(struct domain *d) {}
>
>  #endif /* CONFIG_CACHE_COLORING */
>  #endif /* __ASM_ARM_COLORING_H__ */
> diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
> index 26a8348eed..291f7c375d 100644
> --- a/xen/arch/arm/include/asm/domain.h
> +++ b/xen/arch/arm/include/asm/domain.h
> @@ -58,6 +58,10 @@ struct arch_domain
>  #ifdef CONFIG_ARM_64
>      enum domain_type type;
>  #endif
> +#ifdef CONFIG_CACHE_COLORING
> +    unsigned int *colors;
> +    unsigned int num_colors;
> +#endif
>
>      /* Virtual MMU */
>      struct p2m_domain p2m;
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index c8b6058d3a..adf843a7a1 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -314,6 +314,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>  #define XEN_DOMCTL_CONFIG_TEE_NONE      0
>  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>
> +__DEFINE_XEN_GUEST_HANDLE(color_t, unsigned int);
> +
>  struct xen_arch_domainconfig {
>      /* IN/OUT */
>      uint8_t gic_version;
> @@ -335,6 +337,12 @@ struct xen_arch_domainconfig {
>       *
>       */
>      uint32_t clock_frequency;
> +    /* IN */
> +    uint8_t from_guest;
> +    /* IN */
> +    uint16_t num_colors;
> +    /* IN */
> +    XEN_GUEST_HANDLE(color_t) colors;
>  };
>  #endif /* __XEN__ || __XEN_TOOLS__ */
>
> --
> 2.34.1
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 12:09:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 12:09:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429831.681085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIk4-0000EV-Or; Tue, 25 Oct 2022 12:09:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429831.681085; Tue, 25 Oct 2022 12:09:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIk4-0000EO-KY; Tue, 25 Oct 2022 12:09:12 +0000
Received: by outflank-mailman (input) for mailman id 429831;
 Tue, 25 Oct 2022 12:09:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/6Q6=22=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1onIk2-0000EG-KB
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 12:09:10 +0000
Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com
 [2a00:1450:4864:20::629])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d409501a-545d-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 14:09:08 +0200 (CEST)
Received: by mail-ej1-x629.google.com with SMTP id kt23so6346980ejc.7
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 05:09:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d409501a-545d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=Z0EMS6neoH1wLgevffmxusZO+/2W3737BWX+uyWfd0A=;
        b=vpcDohbWBC7kKW+Vs2agdu5exk4suWVVj8egUR2qTvxUSAeUIJq/k5+osn4zq260Js
         ZgacO8y/a+FfzuCOe2ewFtd79S+sj+cV5LUiqW+hrG1TD/FO+KkdcQdJL8bWFTECz3uh
         Jm6VevyrqtiNNBXarBKijZC4Wv9z1RJD7bvUSMutguXolgp9GsFGFRgqIEmYiXeA2rgn
         sBwq6TA4cMfc8drwNOOZSEW+iOpgvhPvvQCcSv0B0TWsb09U3DLey4B80VWMBIFlDFQg
         5uw0BF9Wy8u8jREQdZgq2joELNeSaMdG+h19QPiYpMfF4xxGYv4iaRk8utQ11BGr3Igl
         xT4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=Z0EMS6neoH1wLgevffmxusZO+/2W3737BWX+uyWfd0A=;
        b=748SPTALrR8KWoS+/QCg6CCM0c6z36ATARPXGVdw0vXysu1kHjA269L8SGQeI+PBY6
         RpNHexLQ5hYTwx1s60FDW0dkJEdPRkF8AJErKwwLrinwzJXv9aue8oSIqZU5+HFAZeEG
         fM52XRQnVsobUqJm30d5dQ5geacJNlbuCVI/67hQDY1gf9rEoqlnrvYtfhwHzsxzESrE
         dz306VgSvsioVmeH//tDGa5micIn9mB6+50GWgh8j2PlgZ4CywKuVdIjeBnfuvCAJeX6
         iovkv7vXb5ajg0kKWbW8O6T1OlS/abjVQv2cp00JogKywrg1YZaE6grtQn1cV/ekqTQl
         /sgw==
X-Gm-Message-State: ACrzQf1ak3wRyrTFDic46wjUq+joTZzv3j6o+NxjBqbeeiG1OUvHlQ1o
	EJuaaXdY1TGyvzRcwNDdQY9F3y25CzJ7lMFJYDRxr3/Tfz8=
X-Google-Smtp-Source: AMsMyM5CgrdLr4ireJ6jwnIFq+0FELmXZskis58ikt1/kyekup74geq6rLuVlC96TlD3+YyhS/AThnck3FD1XKYXQqk=
X-Received: by 2002:a17:907:a055:b0:7a4:48e1:65c3 with SMTP id
 gz21-20020a170907a05500b007a448e165c3mr11679641ejc.764.1666699747327; Tue, 25
 Oct 2022 05:09:07 -0700 (PDT)
MIME-Version: 1.0
References: <20221022155120.7000-1-carlo.nonato@minervasys.tech> <20221022155120.7000-7-carlo.nonato@minervasys.tech>
In-Reply-To: <20221022155120.7000-7-carlo.nonato@minervasys.tech>
From: Carlo Nonato <carlo.nonato@minervasys.tech>
Date: Tue, 25 Oct 2022 14:08:56 +0200
Message-ID: <CAG+AhRXFGG6q5mABQXgJtnswzBzzdBEmMnvBkV6o22eJekPk_w@mail.gmail.com>
Subject: Re: [PATCH v3 6/9] xen/common: add cache coloring allocator for domains
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, 
	lucmiccio@gmail.com, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
	Marco Solieri <marco.solieri@minervasys.tech>
Content-Type: text/plain; charset="UTF-8"

On Sat, Oct 22, 2022 at 5:51 PM Carlo Nonato
<carlo.nonato@minervasys.tech> wrote:
>
> From: Luca Miccio <lucmiccio@gmail.com>
>
> This commit adds a new memory page allocator that implements the cache
> coloring mechanism. The allocation algorithm follows the given domain color
> configuration and maximizes contiguity in the page selection of multiple
> subsequent requests.
>
> Pages are stored in a color-indexed array of lists, each one sorted by
> machine address, that is called the colored heap. A simple initialization
> function computes the color of any available page and inserts it in the
> corresponding list. When a domain requests a page, the allocator takes one
> from the subset of lists whose colors equals the domain configuration. It
> chooses the page with the highest machine address such that contiguous
> pages are sequentially allocated, if this is made possible by a color
> assignment which includes adjacent colors.
>
> The allocator can handle only requests with order equals to 0 since the
> single color granularity is represented in memory by one page.
>
> The buddy allocator must coexist with the colored one because the Xen heap
> isn't colored. For this reason a new Kconfig option and a command line
> parameter are added to let the user set the amount of memory reserved for
> the buddy allocator. Even when cache coloring is enabled, this memory isn't
> managed by the colored allocator.
>
> Colored heap information is dumped in the dump_heap() debug-key function.
>
> Signed-off-by: Luca Miccio <lucmiccio@gmail.com>
> Signed-off-by: Marco Solieri <marco.solieri@minervasys.tech>
> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> ---
> v3:
> - fixed PGC_colored bits values
> - merged debug-key for dump_color_heap() with the one for dump_heap()
> - number of pages for each color in an array to easily dump color heap info
> - heap_lock in colored allocator to ensure atomicity and clarify it with a
>   comment
> - added page_list_add_{next|prev} to add pages in the middle of the list
> - p2m tables use pages of same colors as domain
> - CONFIG_BUDDY_ALLOCATOR_SIZE is now an int (MiB)
> - buddy allocator reserved size is now respected as configured in Kconfig
> - removed useless functions and refactored the code
> - fixed PGC_colored flag that was removed when a page was allocated
> - merged with #7 since it would have been too small
> ---
>  docs/misc/arm/cache-coloring.rst    |  39 ++++-
>  docs/misc/xen-command-line.pandoc   |  14 ++
>  xen/arch/arm/Kconfig                |  12 ++
>  xen/arch/arm/coloring.c             |  10 ++
>  xen/arch/arm/include/asm/coloring.h |   6 +
>  xen/arch/arm/include/asm/mm.h       |   3 +
>  xen/arch/arm/p2m.c                  |   7 +-
>  xen/common/page_alloc.c             | 259 +++++++++++++++++++++++++---
>  xen/include/xen/mm.h                |  43 +++++
>  9 files changed, 371 insertions(+), 22 deletions(-)
>
> diff --git a/docs/misc/arm/cache-coloring.rst b/docs/misc/arm/cache-coloring.rst
> index dd2e851a26..0c89278aee 100644
> --- a/docs/misc/arm/cache-coloring.rst
> +++ b/docs/misc/arm/cache-coloring.rst
> @@ -16,6 +16,9 @@ In order to enable and use it, few steps are needed.
>    (refer to menuconfig help for value meaning and when it should be changed).
>
>          CONFIG_MAX_CACHE_COLORS=<n>
> +- If needed, change the amount of memory reserved for the buddy allocator either
> +  from the Xen configuration file, via the CONFIG_BUDDY_ALLOCATOR_SIZE value,
> +  or with the command line option. See `Colored allocator and buddy allocator`.
>  - Assign colors to domains using the `Color selection format`_ (see
>    `Coloring parameters`_ for more documentation pointers).
>
> @@ -162,6 +165,18 @@ Please refer to the relative documentation in
>  Note that if no color configuration is provided for domains, they fallback to
>  the default one, which corresponds simply to all available colors.
>
> +Colored allocator and buddy allocator
> +*************************************
> +
> +The colored allocator distributes pages based on color configurations of
> +domains so that each domains only gets pages of its own colors.
> +The colored allocator is meant as an alternative to the buddy allocator because
> +its allocation policy is by definition incompatible with the generic one. Since
> +the Xen heap is not colored yet, we need to support the coexistence of the two
> +allocators and some memory must be left for the buddy one.
> +The buddy allocator memory can be reserved from the Xen configuration file or
> +with the help of a command-line option.
> +
>  Known issues and limitations
>  ****************************
>
> @@ -182,7 +197,6 @@ configuration structure size used in domain creation. "uint16_t" is the biggest
>  integer type that fit the constraint and 2^15 is the biggest power of 2 it can
>  easily represent. This value is big enough for the generic case, though.
>
> -
>  "xen,static-mem" isn't supported when coloring is enabled
>  #########################################################
>
> @@ -190,3 +204,26 @@ In the domain configuration, "xen,static-mem" allows memory to be statically
>  allocated to the domain. This isn't possibile when cache coloring is enabled,
>  because that memory can't be guaranteed to be of the same colors assigned to
>  that domain.
> +
> +Colored allocator can only make use of order-0 pages
> +####################################################
> +
> +The cache coloring technique relies on memory mappings and on the smallest
> +amount of memory that can be mapped to achieve the maximum number of colors
> +(cache partitions) possible. This amount is what is normally called a page and,
> +in Xen terminology, the order-0 page is the smallest one. The fairly simple
> +colored allocator currently implemented, makes use only of such pages.
> +It must be said that a more complex one could, in theory, adopt higher order
> +pages if the colors selection contained adjacent colors. Two subsequent colors,
> +for example, can be represented by an order-1 page, four colors correspond to
> +an order-2 page, etc.
> +
> +Fail to boot colored DomUs with large memory size
> +#################################################
> +
> +If the Linux kernel used for Dom0 does not contain the upstream commit
> +3941552aec1e04d63999988a057ae09a1c56ebeb and uses the hypercall buffer device,
> +colored DomUs with memory size larger then 127 MB cannot be created. This is
> +caused by the default limit of this buffer of 64 pages. The solution is to
> +manually apply the above patch, or to check if there is an updated version of
> +the kernel in use for Dom0 that contains this change.
> diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
> index 3f04414134..25a59dd6a9 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -299,6 +299,20 @@ can be maintained with the pv-shim mechanism.
>      cause Xen not to use Indirect Branch Tracking even when support is
>      available in hardware.
>
> +### buddy-alloc-size (arm64)
> +> `= <size>`
> +
> +> Default: `64M`
> +
> +Amount of memory reserved for the buddy allocator when colored allocator is
> +active. This options is parsed only when cache coloring support is enabled.
> +The colored allocator is meant as an alternative to the buddy allocator,
> +because its allocation policy is by definition incompatible with the
> +generic one. Since the Xen heap systems is not colored yet, we need to
> +support the coexistence of the two allocators for now. This parameter, which is
> +optional and for expert only, it's used to set the amount of memory reserved to
> +the buddy allocator.
> +
>  ### clocksource (x86)
>  > `= pit | hpet | acpi | tsc`
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index c45a9c5917..4cfa75b2ef 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -153,6 +153,18 @@ config MAX_CACHE_COLORS
>           Note that if, at any time, a color configuration with more colors than the
>           maximum is employed, an error is produced.
>
> +config BUDDY_ALLOCATOR_SIZE
> +       int "Buddy allocator reserved memory size (MiB)"
> +       default "64"
> +       depends on CACHE_COLORING
> +       help
> +         Amount of memory reserved for the buddy allocator to work alongside
> +         the colored one. The colored allocator is meant as an alternative to the
> +         buddy allocator because its allocation policy is by definition
> +         incompatible with the generic one. Since the Xen heap is not colored yet,
> +         we need to support the coexistence of the two allocators and some memory
> +         must be left for the buddy one.
> +
>  config TEE
>         bool "Enable TEE mediators support (UNSUPPORTED)" if UNSUPPORTED
>         default n
> diff --git a/xen/arch/arm/coloring.c b/xen/arch/arm/coloring.c
> index 685a431c3d..2cae215cd2 100644
> --- a/xen/arch/arm/coloring.c
> +++ b/xen/arch/arm/coloring.c
> @@ -322,6 +322,16 @@ void prepare_color_domain_config(struct xen_arch_domainconfig *config,
>      config->num_colors = (uint16_t)num_colors;
>  }
>
> +unsigned int page_to_color(const struct page_info *pg)
> +{
> +    return addr_to_color(page_to_maddr(pg));
> +}
> +
> +unsigned int get_max_colors(void)
> +{
> +    return max_colors;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/arch/arm/include/asm/coloring.h b/xen/arch/arm/include/asm/coloring.h
> index 549eb408a3..0147f95968 100644
> --- a/xen/arch/arm/include/asm/coloring.h
> +++ b/xen/arch/arm/include/asm/coloring.h
> @@ -31,6 +31,8 @@
>
>  #include <public/arch-arm.h>
>
> +struct page_info;
> +
>  bool __init coloring_init(void);
>
>  int domain_coloring_init(struct domain *d,
> @@ -41,6 +43,10 @@ void domain_dump_coloring_info(struct domain *d);
>  void prepare_color_domain_config(struct xen_arch_domainconfig *config,
>                                   const char *colors_str);
>
> +unsigned int page_to_color(const struct page_info *pg);
> +
> +unsigned int get_max_colors(void);
> +
>  #else /* !CONFIG_CACHE_COLORING */
>
>  static inline bool __init coloring_init(void) { return true; }
> diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h
> index 68adcac9fa..e848fa4adf 100644
> --- a/xen/arch/arm/include/asm/mm.h
> +++ b/xen/arch/arm/include/asm/mm.h
> @@ -128,6 +128,9 @@ struct page_info
>  #else
>  #define PGC_static     0
>  #endif
> +/* Page is cache colored */
> +#define _PGC_colored      PG_shift(4)
> +#define PGC_colored       PG_mask(1, 4)
>  /* ... */
>  /* Page is broken? */
>  #define _PGC_broken       PG_shift(7)
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 8449f97fe7..9ac7dc6216 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -661,7 +661,12 @@ static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry)
>
>      ASSERT(!p2m_is_valid(*entry));
>
> -    page = alloc_domheap_page(NULL, 0);
> +    /* If cache coloring is enabled, p2m tables are allocated using the domain
> +     * coloring configuration to prevent cache interference. */
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
> +        page = alloc_domheap_page(p2m->domain, MEMF_no_refcount);
> +    else
> +        page = alloc_domheap_page(NULL, 0);
>      if ( page == NULL )
>          return -ENOMEM;

This diff can't be applied to the current master. I need to check
how things have changed in the meantime.

> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index 62afb07bc6..fe214cd6ac 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -150,6 +150,9 @@
>  #define p2m_pod_offline_or_broken_hit(pg) 0
>  #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL)
>  #endif
> +#ifdef CONFIG_HAS_CACHE_COLORING
> +#include <asm/coloring.h>
> +#endif
>
>  #ifndef PGC_static
>  #define PGC_static 0
> @@ -231,6 +234,14 @@ static bool __read_mostly scrub_debug;
>  #define scrub_debug    false
>  #endif
>
> +/* Memory required for buddy allocator to work with colored one */
> +#ifdef CONFIG_BUDDY_ALLOCATOR_SIZE
> +static unsigned long __initdata buddy_alloc_size =
> +    CONFIG_BUDDY_ALLOCATOR_SIZE << 20;
> +#else
> +    static unsigned long __initdata buddy_alloc_size = 0;
> +#endif
> +
>  /*
>   * Bit width of the DMA heap -- used to override NUMA-node-first.
>   * allocation strategy, which can otherwise exhaust low memory.
> @@ -440,7 +451,180 @@ mfn_t __init alloc_boot_pages(unsigned long nr_pfns, unsigned long pfn_align)
>      BUG();
>  }
>
> +static DEFINE_SPINLOCK(heap_lock);
>
> +/* Initialise fields which have other uses for free pages. */
> +static void init_free_page_fields(struct page_info *pg)
> +{
> +    pg->u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
> +    page_set_owner(pg, NULL);
> +}
> +
> +#ifdef CONFIG_CACHE_COLORING
> +/*************************
> + * COLORED SIDE-ALLOCATOR
> + *
> + * Pages are stored by their color in separate lists. Each list defines a color
> + * and it is initialized during end_boot_allocator, where each page's color
> + * is calculated and the page itself is put in the correct list.
> + * After initialization there will be N lists where N is the number of
> + * available colors on the platform.
> + * The {free|alloc}_color_heap_page overwrite pg->count_info, but they do it in
> + * the same way as the buddy allocator corresponding functions do:
> + * protecting the access with a critical section using heap_lock.
> + */
> +typedef struct page_list_head colored_pages_t;
> +static colored_pages_t *__ro_after_init _color_heap;
> +static unsigned long *__ro_after_init free_colored_pages;
> +
> +#define color_heap(color) (&_color_heap[color])
> +
> +static void free_color_heap_page(struct page_info *pg)
> +{
> +    struct page_info *pos;
> +    unsigned int color = page_to_color(pg);
> +    colored_pages_t *head = color_heap(color);
> +
> +    spin_lock(&heap_lock);
> +
> +    pg->count_info = PGC_state_free | PGC_colored;
> +    page_set_owner(pg, NULL);
> +    free_colored_pages[color]++;
> +
> +    page_list_for_each( pos, head )
> +    {
> +        if ( page_to_maddr(pos) < page_to_maddr(pg) )
> +            break;
> +    }
> +
> +    page_list_add_next(pg, pos, head);
> +
> +    spin_unlock(&heap_lock);
> +}
> +
> +static struct page_info *alloc_color_heap_page(unsigned int memflags,
> +                                               const unsigned int *colors,
> +                                               unsigned int num_colors)
> +{
> +    struct page_info *pg = NULL;
> +    unsigned int i, color;
> +    bool need_tlbflush = false;
> +    uint32_t tlbflush_timestamp = 0;
> +
> +    spin_lock(&heap_lock);
> +
> +    for ( i = 0; i < num_colors; i++ )
> +    {
> +        struct page_info *tmp;
> +
> +        if ( page_list_empty(color_heap(colors[i])) )
> +            continue;
> +
> +        tmp = page_list_first(color_heap(colors[i]));
> +        if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) )
> +            pg = tmp;
> +    }
> +
> +    if ( !pg )
> +    {
> +        spin_unlock(&heap_lock);
> +        return NULL;
> +    }
> +
> +    pg->count_info = PGC_state_inuse | PGC_colored;
> +
> +    if ( !(memflags & MEMF_no_tlbflush) )
> +        accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp);
> +
> +    init_free_page_fields(pg);
> +    flush_page_to_ram(mfn_x(page_to_mfn(pg)),
> +                      !(memflags & MEMF_no_icache_flush));
> +
> +    color = page_to_color(pg);
> +    free_colored_pages[color]--;
> +    page_list_del(pg, color_heap(color));
> +
> +    spin_unlock(&heap_lock);
> +
> +    if ( need_tlbflush )
> +        filtered_flush_tlb_mask(tlbflush_timestamp);
> +
> +    return pg;
> +}
> +
> +static void __init init_color_heap_pages(struct page_info *pg,
> +                                         unsigned long nr_pages)
> +{
> +    unsigned int i;
> +
> +    if ( !_color_heap )
> +    {
> +        unsigned int max_colors = get_max_colors();
> +
> +        _color_heap = xmalloc_array(colored_pages_t, max_colors);
> +        BUG_ON(!_color_heap);
> +        free_colored_pages = xzalloc_array(unsigned long, max_colors);
> +        BUG_ON(!free_colored_pages);
> +
> +        for ( i = 0; i < max_colors; i++ )
> +            INIT_PAGE_LIST_HEAD(color_heap(i));
> +    }
> +
> +    printk(XENLOG_DEBUG
> +           "Init color heap with %lu pages starting from: %#"PRIx64"\n",
> +           nr_pages, page_to_maddr(pg));
> +
> +    for ( i = 0; i < nr_pages; i++ )
> +        free_color_heap_page(&pg[i]);
> +}
> +
> +static struct page_info *alloc_color_domheap_page(struct domain *d,
> +                                                  unsigned int memflags)
> +{
> +    struct page_info *pg;
> +
> +    pg = alloc_color_heap_page(memflags, d->arch.colors, d->arch.num_colors);
> +    if ( !pg )
> +        return NULL;
> +
> +    if ( !(memflags & MEMF_no_owner) )
> +    {
> +        if ( memflags & MEMF_no_refcount )
> +            pg->count_info |= PGC_extra;
> +        if ( assign_page(pg, 0, d, memflags) )
> +        {
> +            free_color_heap_page(pg);
> +            return NULL;
> +        }
> +    }
> +
> +    return pg;
> +}
> +
> +static void dump_color_heap(void)
> +{
> +    unsigned int color;
> +
> +    printk("Dumping coloring heap info\n");
> +    for ( color = 0; color < get_max_colors(); color++ )
> +        printk("Color heap[%u]: %lu pages\n", color, free_colored_pages[color]);
> +}
> +
> +integer_param("buddy-alloc-size", buddy_alloc_size);
> +
> +#else /* !CONFIG_CACHE_COLORING */
> +
> +static void __init init_color_heap_pages(struct page_info *pg,
> +                                         unsigned long nr_pages) {}
> +static struct page_info *alloc_color_domheap_page(struct domain *d,
> +                                                  unsigned int memflags)
> +{
> +    return NULL;
> +}
> +static void free_color_heap_page(struct page_info *pg) {}
> +static void dump_color_heap(void) {}
> +
> +#endif /* CONFIG_CACHE_COLORING */
>
>  /*************************
>   * BINARY BUDDY ALLOCATOR
> @@ -462,7 +646,6 @@ static unsigned long node_need_scrub[MAX_NUMNODES];
>  static unsigned long *avail[MAX_NUMNODES];
>  static long total_avail_pages;
>
> -static DEFINE_SPINLOCK(heap_lock);
>  static long outstanding_claims; /* total outstanding claims by all domains */
>
>  unsigned long domain_adjust_tot_pages(struct domain *d, long pages)
> @@ -1027,10 +1210,7 @@ static struct page_info *alloc_heap_pages(
>              accumulate_tlbflush(&need_tlbflush, &pg[i],
>                                  &tlbflush_timestamp);
>
> -        /* Initialise fields which have other uses for free pages. */
> -        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
> -        page_set_owner(&pg[i], NULL);
> -
> +        init_free_page_fields(&pg[i]);
>      }
>
>      spin_unlock(&heap_lock);
> @@ -1926,24 +2106,49 @@ static unsigned long avail_heap_pages(
>  void __init end_boot_allocator(void)
>  {
>      unsigned int i;
> +    unsigned long buddy_pages;
>
> -    /* Pages that are free now go to the domain sub-allocator. */
> -    for ( i = 0; i < nr_bootmem_regions; i++ )
> +    buddy_pages = PFN_DOWN(buddy_alloc_size);
> +
> +    if ( !IS_ENABLED(CONFIG_CACHE_COLORING) )
>      {
> -        struct bootmem_region *r = &bootmem_region_list[i];
> -        if ( (r->s < r->e) &&
> -             (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) )
> +        /* Pages that are free now go to the domain sub-allocator. */
> +        for ( i = 0; i < nr_bootmem_regions; i++ )
>          {
> -            init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
> -            r->e = r->s;
> -            break;
> +            struct bootmem_region *r = &bootmem_region_list[i];
> +            if ( (r->s < r->e) &&
> +                (phys_to_nid(pfn_to_paddr(r->s)) == cpu_to_node(0)) )
> +            {
> +                init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
> +                r->e = r->s;
> +                break;
> +            }
>          }
>      }
> +
>      for ( i = nr_bootmem_regions; i-- > 0; )
>      {
> -        struct bootmem_region *r = &bootmem_region_list[i];
> +        struct bootmem_region *r;
> +
> +        if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
> +            r = &bootmem_region_list[nr_bootmem_regions - i - 1];
> +        else
> +            r = &bootmem_region_list[i];
> +
> +        if ( buddy_pages && (r->s < r->e) )
> +        {
> +            unsigned long pages = MIN(r->e - r->s, buddy_pages);
> +            init_heap_pages(mfn_to_page(_mfn(r->s)), pages);
> +            r->s += pages;
> +            buddy_pages -= pages;
> +        }
>          if ( r->s < r->e )
> -            init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
> +        {
> +            if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
> +                init_color_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
> +            else
> +                init_heap_pages(mfn_to_page(_mfn(r->s)), r->e - r->s);
> +        }
>      }
>      nr_bootmem_regions = 0;
>
> @@ -2344,7 +2549,8 @@ int assign_pages(
>
>          for ( i = 0; i < nr; i++ )
>          {
> -            ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_static)));
> +            ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_static |
> +                                          PGC_colored)));
>              if ( pg[i].count_info & PGC_extra )
>                  extra_pages++;
>          }
> @@ -2429,6 +2635,15 @@ struct page_info *alloc_domheap_pages(
>
>      ASSERT_ALLOC_CONTEXT();
>
> +    /* Only domains are supported for coloring */
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) && d )
> +    {
> +        /* Colored allocation must be done on 0 order */
> +        if ( order )
> +            return NULL;
> +        return alloc_color_domheap_page(d, memflags);
> +    }
> +
>      bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
>                                        bits ? : (BITS_PER_LONG+PAGE_SHIFT));
>
> @@ -2546,7 +2761,10 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
>              scrub = 1;
>          }
>
> -        free_heap_pages(pg, order, scrub);
> +        if ( pg->count_info & PGC_colored )
> +            free_color_heap_page(pg);
> +        else
> +            free_heap_pages(pg, order, scrub);
>      }
>
>      if ( drop_dom_ref )
> @@ -2653,6 +2871,9 @@ static void cf_check dump_heap(unsigned char key)
>              continue;
>          printk("Node %d has %lu unscrubbed pages\n", i, node_need_scrub[i]);
>      }
> +
> +    if ( IS_ENABLED(CONFIG_CACHE_COLORING) )
> +        dump_color_heap();
>  }
>
>  static __init int cf_check register_heap_trigger(void)
> @@ -2785,9 +3006,7 @@ static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns,
>           * to PGC_state_inuse.
>           */
>          pg[i].count_info = PGC_static | PGC_state_inuse;
> -        /* Initialise fields which have other uses for free pages. */
> -        pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER;
> -        page_set_owner(&pg[i], NULL);
> +        init_free_page_fields(&pg[i]);
>      }
>
>      spin_unlock(&heap_lock);
> diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h
> index a925028ab3..0d48502e75 100644
> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -297,6 +297,37 @@ page_list_add_tail(struct page_info *page, struct page_list_head *head)
>      }
>      head->tail = page;
>  }
> +static inline void
> +_page_list_add(struct page_info *new, struct page_info *prev,
> +               struct page_info *next)
> +{
> +    new->list.prev = page_to_pdx(prev);
> +       new->list.next = page_to_pdx(next);
> +       prev->list.next = page_to_pdx(new);
> +       next->list.prev = page_to_pdx(new);
> +}
> +static inline void
> +page_list_add_next(struct page_info *new, struct page_info *prev,
> +                   struct page_list_head *head)
> +{
> +       struct page_info *next = page_list_next(prev, head);
> +
> +    if ( !next )
> +        page_list_add_tail(new, head);
> +    else
> +        _page_list_add(new, prev, next);
> +}
> +static inline void
> +page_list_add_prev(struct page_info *new, struct page_info *next,
> +                   struct page_list_head *head)
> +{
> +       struct page_info *prev = page_list_prev(next, head);
> +
> +    if ( !prev )
> +        page_list_add(new, head);
> +    else
> +        _page_list_add(new, prev, next);
> +}
>  static inline bool_t
>  __page_list_del_head(struct page_info *page, struct page_list_head *head,
>                       struct page_info *next, struct page_info *prev)
> @@ -449,6 +480,18 @@ page_list_add_tail(struct page_info *page, struct page_list_head *head)
>      list_add_tail(&page->list, head);
>  }
>  static inline void
> +page_list_add_next(struct page_info *new, struct page_info *prev,
> +                   struct page_list_head *head)
> +{
> +       page_list_add_tail(new, &prev->list);
> +}
> +static inline void
> +page_list_add_prev(struct page_info *new, struct page_info *next,
> +                   struct page_list_head *head)
> +{
> +    page_list_add(new, &next->list);
> +}
> +static inline void
>  page_list_del(struct page_info *page, struct page_list_head *head)
>  {
>      list_del(&page->list);
> --
> 2.34.1
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 12:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 12:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429837.681095 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIoc-0001jT-C4; Tue, 25 Oct 2022 12:13:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429837.681095; Tue, 25 Oct 2022 12:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onIoc-0001jM-9T; Tue, 25 Oct 2022 12:13:54 +0000
Received: by outflank-mailman (input) for mailman id 429837;
 Tue, 25 Oct 2022 12:13:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/6Q6=22=minervasys.tech=carlo.nonato@srs-se1.protection.inumbo.net>)
 id 1onIob-0001jG-GP
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 12:13:53 +0000
Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com
 [2a00:1450:4864:20::536])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7caf34b8-545e-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 14:13:51 +0200 (CEST)
Received: by mail-ed1-x536.google.com with SMTP id x2so8633974edd.2
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 05:13:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7caf34b8-545e-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=minervasys-tech.20210112.gappssmtp.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=XPPVk7/CiDDz5EuHNpbx4V6WjnMH9Y8/ejHf18iThTg=;
        b=zFVJukIwSkogQ4jNt9+kxogaIRxaQU2yVZWe+QB6cfyoekQFKuYu9aDWnK9skwyFAT
         R4+O5luiPoTPr/63rCbG/W3mnbO1X4vbmVSXU6OT7+7dvJ4g8a1d9lkBxVDYqnw0rGAt
         7X4P1G3rqFCnOSwDr+sKsLowDvDVGILm7G3kKps2HCnm1ubDwnaIFIcpTgneUFK7xyH7
         bhOdHdUsVESs5vFmThJZus6H+7e95DyrC6aTknqyjKZpFZwvTp9PaGRivZ/+DJaTNWhZ
         VJtJgHyTEOUeEAYs5ChDpmOKc6p3ePQKrUjkXRnUqbQOCDyGCWidynRvZId675JW8I5B
         LDNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=XPPVk7/CiDDz5EuHNpbx4V6WjnMH9Y8/ejHf18iThTg=;
        b=xwIAZPbeahNQtNKEPeRvc9yubTTMBphsN2NT+MIHNqjm8OYEEsFcSCQyeP6zqVu75g
         E/AiEIXgLh5JD7o+puzsEzaiEl1oX8BDlacEX+OGp3NBSDiMH8fnqVcf4hr+AtrsO8QL
         /y8Y1zRqJj89HX3i5u2o2jkmwO1tXYeR56wvKed8XXj9xwbeVvMhvEHVmU08WH5jCZJ3
         H222tH9Zdn70AMGsEKiOr12RkVD/33vjLZIGHBrWBzLWTO8CrdyUUrUlWo7HETloEage
         +DgHsiECK78bZ3UltXHO1Mm0ll8ftCKXHPw8KDuGpsvR73IHIIvtbMWl5pte39xAA5OV
         8aEw==
X-Gm-Message-State: ACrzQf0IDPZdYKl+9SH2bj8fVMhcWdDQDJJXUHEPERtgD/gVjZ6Jsr8K
	Q4/7ltCox3/hfn4LZXuasHGW9y9V9R9SCqcTxJd94w6j3+c=
X-Google-Smtp-Source: AMsMyM61yH6RbYyNRpDGO7tbdqYCv76+0Nd2gw8NLboC6Ld6KyWTai9UOV8dfKTzks9Oxe22cS12a/CGxLyuhMeXDdw=
X-Received: by 2002:aa7:c78e:0:b0:456:c524:90ec with SMTP id
 n14-20020aa7c78e000000b00456c52490ecmr35569211eds.192.1666700030661; Tue, 25
 Oct 2022 05:13:50 -0700 (PDT)
MIME-Version: 1.0
References: <20221022160837.8497-1-carlo.nonato@minervasys.tech>
In-Reply-To: <20221022160837.8497-1-carlo.nonato@minervasys.tech>
From: Carlo Nonato <carlo.nonato@minervasys.tech>
Date: Tue, 25 Oct 2022 14:13:39 +0200
Message-ID: <CAG+AhRX-kSFQvjo=+TygUxoXcn++V3xjKUoMpC1=LDXNJf-WOw@mail.gmail.com>
Subject: Re: [RFC PATCH] xen/common: cache colored buddy allocator for domains
To: xen-devel@lists.xenproject.org
Cc: marco.solieri@unimore.it, andrea.bastoni@minervasys.tech, 
	lucmiccio@gmail.com, Andrew Cooper <andrew.cooper3@citrix.com>, 
	George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Content-Type: text/plain; charset="UTF-8"

On Sat, Oct 22, 2022 at 6:08 PM Carlo Nonato
<carlo.nonato@minervasys.tech> wrote:
>
> This commit replaces the colored allocator for domains with a simple buddy
> allocator indexed also by colors, so that it can allocate pages based on
> some coloring configuration.
>
> It applies on top of Arm cache coloring (v3) as sent to the mailing list.
>
> This has two benefits:
>  - order can now be greater than 0 if the color config contains a
>    sufficient number of adjacent colors starting from an order aligned
>    one;
>  - same benefits of the normal buddy: constant time alloc and free
>    (constant with respect to the number of pages, not for the number of
>    colors);
>
> But also one "big" cons:
>  - given the way Xen queries the allocator, it can only serve larger pages
>    first and only when a domain runs out of those, it can go with the smaller
>    ones. Let's say that domain 0 has 31 colors out of 32 total (0-30 out of
>    0-31). The order-4 pages (0-15) are allocated first and then the order-3
>    (16-23, since 0-7 and 8-15 are all already allocated), and then order-2
>    and so on. The result is... the domain practically uses only one half of
>    the colors that it should.

In case it isn't clear, less cache colors means less cache given to the
domain which results in lower performances.

> Signed-off-by: Carlo Nonato <carlo.nonato@minervasys.tech>
> ---
>  xen/common/page_alloc.c | 202 ++++++++++++++++++++++++++++------------
>  1 file changed, 141 insertions(+), 61 deletions(-)
>
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index fe214cd6ac..f20de1c891 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -462,67 +462,133 @@ static void init_free_page_fields(struct page_info *pg)
>
>  #ifdef CONFIG_CACHE_COLORING
>  /*************************
> - * COLORED SIDE-ALLOCATOR
> + * COLORED BUDDY ALLOCATOR
>   *
> - * Pages are stored by their color in separate lists. Each list defines a color
> - * and it is initialized during end_boot_allocator, where each page's color
> - * is calculated and the page itself is put in the correct list.
> - * After initialization there will be N lists where N is the number of
> - * available colors on the platform.
> - * The {free|alloc}_color_heap_page overwrite pg->count_info, but they do it in
> - * the same way as the buddy allocator corresponding functions do:
> - * protecting the access with a critical section using heap_lock.
> + * A simplified version of the buddy allocator with the addition of colors to
> + * serve pages based on coloring configuration.
> + * Pages are divided in lists by color and order, so the total space needed
> + * for the heap is greater than the normal one. The matrix of colors x orders
> + * page lists is linearized since not every color can use any order.
>   */
>  typedef struct page_list_head colored_pages_t;
>  static colored_pages_t *__ro_after_init _color_heap;
>  static unsigned long *__ro_after_init free_colored_pages;
> +static unsigned int max_color_order;
>
> -#define color_heap(color) (&_color_heap[color])
> +#define order_mask(order) ((1UL << (order)) - 1)
> +#define color_index_of_order(color, order) ((color) & order_mask(order))
> +#define color_align_to_order(color, order) ((color) & ~order_mask(order))
> +#define color_heap_pos(color, order) \
> +    ((((1 << max_color_order) + (color)) >> (order)) - 1)
> +#define color_heap(color, order) (&_color_heap[color_heap_pos(color, order)])
>
> -static void free_color_heap_page(struct page_info *pg)
> +static void free_color_heap_pages(struct page_info *pg, unsigned int order)
>  {
> -    struct page_info *pos;
> -    unsigned int color = page_to_color(pg);
> -    colored_pages_t *head = color_heap(color);
> +    unsigned int i, color = page_to_color(pg);
> +
> +    ASSERT(color_index_of_order(color, order) == 0);
>
>      spin_lock(&heap_lock);
>
> -    pg->count_info = PGC_state_free | PGC_colored;
> -    page_set_owner(pg, NULL);
> -    free_colored_pages[color]++;
> +    for ( i = 0; i < (1 << order); i++ )
> +    {
> +        pg[i].count_info = PGC_state_free | PGC_colored;
> +        page_set_owner(&pg[i], NULL);
> +        free_colored_pages[page_to_color(&pg[i])]++;
> +    }
>
> -    page_list_for_each( pos, head )
> +    for ( ; order < max_color_order; order++ )
>      {
> -        if ( page_to_maddr(pos) < page_to_maddr(pg) )
> +        unsigned long mask = 1UL << order;
> +        struct page_info *merge = pg + ((color & mask) ? -mask : mask);
> +
> +        if ( !page_state_is(merge, free) || (PFN_ORDER(merge) != order) )
>              break;
> +
> +        if ( color & mask )
> +        {
> +            pg = merge;
> +            color -= mask;
> +        }
> +
> +        page_list_del(merge, color_heap(color, order));
>      }
>
> -    page_list_add_next(pg, pos, head);
> +    PFN_ORDER(pg) = order;
> +    page_list_add(pg, color_heap(color, order));
>
>      spin_unlock(&heap_lock);
>  }
>
> -static struct page_info *alloc_color_heap_page(unsigned int memflags,
> -                                               const unsigned int *colors,
> -                                               unsigned int num_colors)
> +static struct page_info *find_free_color_heap_page(unsigned int color,
> +                                                   unsigned int order)
> +{
> +    struct page_info *pg = NULL;
> +    unsigned int buddy_order, buddy_color;
> +
> +    ASSERT(color_index_of_order(color, order) == 0);
> +
> +    for ( buddy_order = order; buddy_order <= max_color_order; buddy_order++ )
> +    {
> +        pg = page_list_remove_head(color_heap(
> +            color_align_to_order(color, buddy_order), buddy_order));
> +        if ( pg )
> +            break;
> +    }
> +
> +    if ( !pg )
> +        return NULL;
> +
> +    buddy_color = page_to_color(pg);
> +
> +    while ( buddy_order != order )
> +    {
> +        unsigned long mask = (1U << --buddy_order);
> +        struct page_info *half = pg + mask;
> +
> +        if ( color & mask )
> +        {
> +            page_list_add(pg, color_heap(buddy_color, buddy_order));
> +            pg = half;
> +            buddy_color += mask;
> +        }
> +        else
> +            page_list_add(half, color_heap(buddy_color + mask, buddy_order));
> +    }
> +
> +    return pg;
> +}
> +
> +static struct page_info *alloc_color_heap_pages(unsigned int order,
> +                                                unsigned int memflags,
> +                                                unsigned int *colors,
> +                                                unsigned int num_colors)
>  {
>      struct page_info *pg = NULL;
> -    unsigned int i, color;
> +    unsigned int i, color = 0;
> +    unsigned long mask = order_mask(order);
>      bool need_tlbflush = false;
>      uint32_t tlbflush_timestamp = 0;
> +    mfn_t mfn;
>
>      spin_lock(&heap_lock);
>
> +    /* Search for 2^order contiguous colors */
>      for ( i = 0; i < num_colors; i++ )
>      {
> -        struct page_info *tmp;
> +        unsigned int index = colors[i] & mask;
> +
> +        if ( index == 0 )
> +            color = colors[i];
>
> -        if ( page_list_empty(color_heap(colors[i])) )
> +        if ( colors[i] != color )
>              continue;
>
> -        tmp = page_list_first(color_heap(colors[i]));
> -        if ( !pg || page_to_maddr(tmp) > page_to_maddr(pg) )
> -            pg = tmp;
> +        if ( index == mask &&
> +             (pg = find_free_color_heap_page(colors[i] & ~mask, order)) )
> +            break;
> +
> +        color++;
>      }
>
>      if ( !pg )
> @@ -531,59 +597,77 @@ static struct page_info *alloc_color_heap_page(unsigned int memflags,
>          return NULL;
>      }
>
> -    pg->count_info = PGC_state_inuse | PGC_colored;
> -
> -    if ( !(memflags & MEMF_no_tlbflush) )
> -        accumulate_tlbflush(&need_tlbflush, pg, &tlbflush_timestamp);
> +    for ( i = 0; i < (1 << order); i++ )
> +    {
> +        pg[i].count_info = PGC_state_inuse | PGC_colored;
>
> -    init_free_page_fields(pg);
> -    flush_page_to_ram(mfn_x(page_to_mfn(pg)),
> -                      !(memflags & MEMF_no_icache_flush));
> +        if ( !(memflags & MEMF_no_tlbflush) )
> +            accumulate_tlbflush(&need_tlbflush, &pg[i], &tlbflush_timestamp);
>
> -    color = page_to_color(pg);
> -    free_colored_pages[color]--;
> -    page_list_del(pg, color_heap(color));
> +        init_free_page_fields(&pg[i]);
> +        free_colored_pages[page_to_color(&pg[i])]--;
> +    }
>
>      spin_unlock(&heap_lock);
>
>      if ( need_tlbflush )
>          filtered_flush_tlb_mask(tlbflush_timestamp);
>
> +    mfn = page_to_mfn(pg);
> +    for ( i = 0; i < (1U << order); i++ )
> +        flush_page_to_ram(mfn_x(mfn) + i, !(memflags & MEMF_no_icache_flush));
> +
>      return pg;
>  }
>
>  static void __init init_color_heap_pages(struct page_info *pg,
>                                           unsigned long nr_pages)
>  {
> -    unsigned int i;
> +    unsigned long s, e;
>
>      if ( !_color_heap )
>      {
>          unsigned int max_colors = get_max_colors();
> +        unsigned int color_heap_num = (2 * max_colors) - 1;
> +        unsigned int i;
>
> -        _color_heap = xmalloc_array(colored_pages_t, max_colors);
> +        max_color_order = flsl(max_colors) - 1;
> +
> +        _color_heap = xmalloc_array(colored_pages_t, color_heap_num);
>          BUG_ON(!_color_heap);
>          free_colored_pages = xzalloc_array(unsigned long, max_colors);
>          BUG_ON(!free_colored_pages);
> -
> -        for ( i = 0; i < max_colors; i++ )
> -            INIT_PAGE_LIST_HEAD(color_heap(i));
> +        for ( i = 0; i < color_heap_num; i++ )
> +            INIT_PAGE_LIST_HEAD(&_color_heap[i]);
>      }
>
>      printk(XENLOG_DEBUG
>             "Init color heap with %lu pages starting from: %#"PRIx64"\n",
>             nr_pages, page_to_maddr(pg));
>
> -    for ( i = 0; i < nr_pages; i++ )
> -        free_color_heap_page(&pg[i]);
> +    s = mfn_x(page_to_mfn(pg));
> +    e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1));
> +
> +    while ( s < e )
> +    {
> +        unsigned int inc_order = min_t(unsigned int, max_color_order,
> +                                       flsl(e - s) - 1);
> +
> +        if ( s )
> +            inc_order = min(inc_order, ffsl(s) - 1U);
> +        free_color_heap_pages(mfn_to_page(_mfn(s)), inc_order);
> +        s += (1UL << inc_order);
> +    }
>  }
>
> -static struct page_info *alloc_color_domheap_page(struct domain *d,
> -                                                  unsigned int memflags)
> +static struct page_info *alloc_color_domheap_pages(struct domain *d,
> +                                                   unsigned int order,
> +                                                   unsigned int memflags)
>  {
>      struct page_info *pg;
>
> -    pg = alloc_color_heap_page(memflags, d->arch.colors, d->arch.num_colors);
> +    pg = alloc_color_heap_pages(order, memflags, d->arch.colors,
> +                                d->arch.num_colors);
>      if ( !pg )
>          return NULL;
>
> @@ -591,9 +675,9 @@ static struct page_info *alloc_color_domheap_page(struct domain *d,
>      {
>          if ( memflags & MEMF_no_refcount )
>              pg->count_info |= PGC_extra;
> -        if ( assign_page(pg, 0, d, memflags) )
> +        if ( assign_page(pg, order, d, memflags) )
>          {
> -            free_color_heap_page(pg);
> +            free_color_heap_pages(pg, order);
>              return NULL;
>          }
>      }
> @@ -616,12 +700,13 @@ integer_param("buddy-alloc-size", buddy_alloc_size);
>
>  static void __init init_color_heap_pages(struct page_info *pg,
>                                           unsigned long nr_pages) {}
> -static struct page_info *alloc_color_domheap_page(struct domain *d,
> -                                                  unsigned int memflags)
> +static struct page_info *alloc_color_domheap_pages(struct domain *d,
> +                                                   unsigned int order,
> +                                                   unsigned int memflags)
>  {
>      return NULL;
>  }
> -static void free_color_heap_page(struct page_info *pg) {}
> +static void free_color_heap_pages(struct page_info *pg, unsigned int order) {}
>  static void dump_color_heap(void) {}
>
>  #endif /* CONFIG_CACHE_COLORING */
> @@ -2637,12 +2722,7 @@ struct page_info *alloc_domheap_pages(
>
>      /* Only domains are supported for coloring */
>      if ( IS_ENABLED(CONFIG_CACHE_COLORING) && d )
> -    {
> -        /* Colored allocation must be done on 0 order */
> -        if ( order )
> -            return NULL;
> -        return alloc_color_domheap_page(d, memflags);
> -    }
> +        return alloc_color_domheap_pages(d, order, memflags);
>
>      bits = domain_clamp_alloc_bitsize(memflags & MEMF_no_owner ? NULL : d,
>                                        bits ? : (BITS_PER_LONG+PAGE_SHIFT));
> @@ -2762,7 +2842,7 @@ void free_domheap_pages(struct page_info *pg, unsigned int order)
>          }
>
>          if ( pg->count_info & PGC_colored )
> -            free_color_heap_page(pg);
> +            free_color_heap_pages(pg, order);
>          else
>              free_heap_pages(pg, order, scrub);
>      }
> --
> 2.34.1
>


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 12:26:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 12:26:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429841.681106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onJ0Y-0003SY-EW; Tue, 25 Oct 2022 12:26:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429841.681106; Tue, 25 Oct 2022 12:26:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onJ0Y-0003SR-Bn; Tue, 25 Oct 2022 12:26:14 +0000
Received: by outflank-mailman (input) for mailman id 429841;
 Tue, 25 Oct 2022 12:26:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t1VE=22=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onJ0W-0003SL-MF
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 12:26:12 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on2061.outbound.protection.outlook.com [40.107.212.61])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33c6c753-5460-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 14:26:09 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CH0PR12MB5300.namprd12.prod.outlook.com (2603:10b6:610:d7::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Tue, 25 Oct
 2022 12:26:04 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 12:26:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33c6c753-5460-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AHzj1V/JiVtD41t8ghVGgCO9aS3XXwlWQh6AYJkBJRS5fm4NOW9yVqWMd362UINtcmqPlrHzbtMiOfQY5oGts6+G2fiiO3R5RHpZbY0QfTuk8o+ulR7bVIarunKqyHUseyy0uzLb0J7+wMXLxJ3DCc9/syzA855Ni2NIPso3p3bCOQUXBMIrS2No12pP3xM0xJlfBFT6yJOYX9awj1Uazhn5eKdUjHp5HRlhoqmKOoZTl5TfU2pWNnaFPSN/oZIXdOUitU8+qgVchpIMYHs71asXqcBrpGPt6uwmHIIYHLJcd2vL5nCZSa251gS4j62K69U5z7jfjeW86Awm7/Y3Tw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=42aTLoPmUHQxgqfWtrsiFWxqbzPntR9zF8FGdEgh8tQ=;
 b=ZkKHW4FTTbJY8+8Z5ByF/eWiOCCsj4xQvSaCnngQ13jrv75gM/YKyNGUQP0H65MDgpYN9WLa3rJhpWtnI2zv+1Lr6xaA9M749eq2U+uJBqP/PqjEDvBHij2FMMn7YKYHuOJEtdToVZaMWf2MhxmWeObqZyL2EgOSGoP9qAuIVrg+oMGMMRzF5fTqP5t0/qW5yEFFHdl1VdJg8G7srGQ5VvRrOYzlk7mZxgpANVOsi6ZhNaIBsI9fADNcq6BpUFLVbshGAQvGHyYfZkNPRDpW6adZ/ZPwpSiPJkXdEewqwaxwqIpRGnP/wPn08O7ANrV3pbAD5OnC6UTUFGh6I4iSJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=42aTLoPmUHQxgqfWtrsiFWxqbzPntR9zF8FGdEgh8tQ=;
 b=JDI1JMTkjZ9TRBz8zJ3YesmmXRBotAw9YKEA9t/A83J6IvWuPZRIA43nHIYSZhz5/PqOQfsNxrqa9uQ9in+f9o/CjcHkkynQMprBG6S8oS6gixEDprOIFjrw+aYk71c3H1DlVzxOhkF3aff4DuiiA+918iHEeRWbYmlmvilH+vk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
Date: Tue, 25 Oct 2022 13:25:52 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
To: Andre Przywara <andre.przywara@arm.com>,
 "stefanos@xilinx.com" <stefanos@xilinx.com>, Julien Grall <julien@xen.org>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
Subject: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:62::19) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH0PR12MB5300:EE_
X-MS-Office365-Filtering-Correlation-Id: 454836bc-ca3f-4d9c-50a9-08dab68415b6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kosZ5u/NRrwwpAXow4yaIgu+jrg6PsdqB7wXsYDJmkPVE8Y+TmZW1b+CxVcfBU981kXGUW7zqR6iKCK8R3BhSVVsUOIj+9d3RV8O/XalK+1dRVmyPoBVn1z6mPZ3VMLbBgZyh+jUV2mBbqapGH7nFDG3RSuWS69jsMuQ/1ylQ1bFSEfy/ISRC0s9shgfe82nddMx5hF8J6p2q6VRqV+Ky2fWPzAd5q/RasO3i5wPY981ou7v5UmCq1UYhdGIBKOmZbgIDgg2irrtREtIJlYIAReiCAsR0/bGa7w9GyJ++9/ZJZBV23nQuXQDPATicxL+IzgnVcJZtUiWjzuCWR1OyMwHY4Sa8DlvWnV4LlKMhi3NCAMqB6ocnOOkw6ehmgJJ5Wame6Jl+uKSaEmpUd1yp8K3WANkXMc9SVljXp+Wizx22s6TCMLPS3R7q82mRRhz7z0BMgOILB+ory1M2l+S1sJxl4MoD4BBdGNRoHYF/exi4yh7thDk1mDYibYR51a/3XtbiJ6kdvrBY21KsGalGHwSzMzo4Fs6heAp7elAM86VhyaWyzgoX83cekuwnisfBpvHt8fz2lHPW0NlM1TMxPluVLHTYa+/qkGdrcRujt7VWvwqlKw26F6OPStHyxpDkG90JIScV9buMwHKMZRL8IIhChoh8yBuDEHPTqj83TnXvbK2jlNXalqnROI71BmMzjXoTml3U/WFVoKgIJ1J6Uqs8zfc55fTT+X/2Dq36KvK1f32u0l8LiGytecBhThXKoSPD2ViwVS5ULri964bdbXQdqxOSEqVQqvJa7XPYbw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(366004)(346002)(451199015)(66946007)(110136005)(4326008)(6506007)(26005)(66476007)(41300700001)(36756003)(5660300002)(6512007)(8936002)(8676002)(6666004)(66556008)(316002)(83380400001)(186003)(31696002)(2906002)(38100700002)(2616005)(31686004)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TjJiTSs4Uk90VUtFSWd3STY1NzRXQm5UZ1gwZm9kNWZ0NFluaFJwRzkxZHlP?=
 =?utf-8?B?TG4zSFdVcHhCK3V6Y1NOK01vT09xUXNhaEhQVWYvQ3paMnBEL2FIYnpVcWRt?=
 =?utf-8?B?czV3YTN5UlNacVpRRndsc3pDL01lUTNQV1hoaXlRL2pzNWNING05OERTeGM4?=
 =?utf-8?B?QWdmNncwK2kxZmI1N3AzVnJRejBTSlpLQ3ZrTG8rS1owd1V5dUpOUHRkY2pE?=
 =?utf-8?B?enRxcXlpa2FGYnk5Q1JiTUZOUnlxZFRkc1RNaXZQQnl3VjdQZzArNFVhTmx5?=
 =?utf-8?B?RTdzMkh0QU9lUk13OTBwSEdGMUZrVjFyQVdrT3pXZlVZTkhZUVd0OHV6RklH?=
 =?utf-8?B?d1F0SENURW9iOG8vaWlZMFM2YVVxYmZ3c0RWOU16NjkrWUtiZ3hpLzJrSGlC?=
 =?utf-8?B?VUtBOGhQOVdIdlFaTW5GTWxYQnhCdWdUbzYvSlZna2NLQWpHZElCVW92VDFX?=
 =?utf-8?B?NDZzTXBTa1B3VUFLd3l1VXVXS1Z4eHZEd3lEbDREWnNuUE9KLzB5eHQ0M3l2?=
 =?utf-8?B?SjhYeHZDOUtTVkpvLzIreXg5eS9UNnBxN1hLVHJXTFo2T0VobzF4Y0VlMEFs?=
 =?utf-8?B?aHFvemR4T1UxNlpMMzYxcnlacTZGTmMyVUlpWHRIM0p6bUxjdVM5Vk4rRGdn?=
 =?utf-8?B?SG9sNmc1U1JadXNncjBsWDFTZk5BTWVQSkZ6MStCZVlYQ2YrZE5xMjl6UmtE?=
 =?utf-8?B?ZjNzbU4wQVJGcjBYR2xpNFZ6SWlEaGdFeHV1Q1RxTkR4TU9abVgxb0QydjFS?=
 =?utf-8?B?UGNGeE4rWG44QlVlNWR3YWhhK0pYYkFhOUkwOXpRZFhmSjhnQllkM2VrTUZG?=
 =?utf-8?B?ckdFOE5zalNtOHNpSHZxQkVGU05nUnNzM1g2NGZqUUlDVTllQ0dCVDJsamlR?=
 =?utf-8?B?cUVaN2lWSG9IQ3Vyb0pxRXFGSjB2RXVaMERsYzhsR0preDFIdnlQZFAyOHVu?=
 =?utf-8?B?OHFaZGRDdUhpQzhNWGlBOEg2UGIzMjdmS3M3NmJHV1I1b1pwbmx5bXhyNHgz?=
 =?utf-8?B?NFVUSnVKUkkxN1BHYk1kaHpXRlM2TVJnQnlDNlM3QkJoRmpIenNEb3JJUHB3?=
 =?utf-8?B?N2xqS3lxeTh0bzA4N1pFTVh6UXlodW5jMVZhVXFpcVR0NGVTZ2FNaStVbHBM?=
 =?utf-8?B?NW00WWxjdUk0UENLYVB3NHZ4RDhrVEUyVmpqZDJ2Z3JqSURkeEQ3VVhCajVO?=
 =?utf-8?B?OW00c1VEeXZlTHp0SjhlSmkzbTduR0NaSG9aWkpmdy83dzhseVZKL05sZk9n?=
 =?utf-8?B?Q3VxR3ZVdEpXN0pPcDZxMVdZRjk0MU8yRjRIYzFqV1EzZjlDS2t2L0lHZXdp?=
 =?utf-8?B?aUNrdVVIOHdTRGs5RDhUT2FLUTdCMDh6cUxWYTdndEJsVEY5Zi82RFpNV2FX?=
 =?utf-8?B?MXY1RFRIckI5anpmRk1sdjFob0M5VmtNeXN0NEMvOTlrT1pDdk9rcWFlTW9R?=
 =?utf-8?B?YWRoaFZwbDNTbmRBamM5dS9HZGtCVkp5WVdLa2llQVRsTlFvN3hmOW5aOGFP?=
 =?utf-8?B?VnRaQnFtV0txVGVkNktXMnQ3QTZRQ0xNTWNhVlFsamQzNnE3ZHEvTXpBWUVU?=
 =?utf-8?B?bVNPb1NWS3VmTDJDTU9qeVZEYno5Mjdib0lGU0Z3RWwwNUM4ZTNmNDBSN1Rm?=
 =?utf-8?B?N1U0Vnc4Q1RBc3ZqVEVNTWdEMUJzRVF1eUdpbzlBMWUvQnk1Z3d4YXBrTzR2?=
 =?utf-8?B?cTFFRE5vQUE2VzVNcXRjWTlSTVB3M0tYTTgzSXdpK3p4U0pMS3FnTkF6c2l6?=
 =?utf-8?B?OHM3bDd2N2RxNlhvY3N4MFdLMDlXK1RHOTFBZy9jUTc1UHB5V2pZa3VLb2N4?=
 =?utf-8?B?ZU05ekJjUnZKZUkwaVVTazJ5cEloRmhIcU1ReldYQkZXck5ZUWZwQUREOUlM?=
 =?utf-8?B?SElkeWVUTlVHR3dqL1U1L0pQMjJsWDRpZWwrb09qWnBVQU1uMFY3dC9yelVI?=
 =?utf-8?B?OFlMVFpZZ3dSemdyR1ZEeXllbUpraG42NVQxMWJPR2RleDNodlNNS28rWFZK?=
 =?utf-8?B?UEkzb2hVSGhnbnFrc0NzWmFxOXgxTkVrK1NENEU5THZNVmFqOUxhclF0bmJC?=
 =?utf-8?B?UnAzbllOa1cyWU1CRElrcnZtb2NKWUxMNDE5bEt5S2RhQnpvSUZSWkNLZ2FM?=
 =?utf-8?Q?A5dc2rAkxu7JRk5qfQfcHrtFQ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 454836bc-ca3f-4d9c-50a9-08dab68415b6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 12:26:04.4741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +8FQosNSKBLmBwQef1j+BRTymyhS/WrXZK6zzUaDdu9X8hqzjp4Kvy/N8SGOF+Sw8pajKRnSDG4iR+mwzqzUFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5300

Hi Andre/All,

This came up while porting Xen on R52.

Refer "ARM DDI 0568A.cID110520", B1.3.1

"A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE 
must not implement LPI support. "

Does this mean ITS is not supported on R52 ? I am assuming yes, please 
correct me if mistaken.

If the answer is no, then my next query is follows :-

diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 9ca74bc321..dea60aac0d 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
      int rc;

      /* We rely on the data structure being atomically accessible. */
-    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long));
+    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint64_t));

"unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.

Is it fine to change it as above ?

Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy 
atomicity".

"LDRD and STRD accesses to 64-bit aligned locations are 64-bit 
single-copy atomic as seen by translation table walks and accesses to 
translation tables"

Does this imply that atomicity will be retained (with the above change) 
? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so 
translation tables are irrelevant).

Kind regards,
Ayan



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 12:47:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 12:47:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429848.681124 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onJL1-00067z-8D; Tue, 25 Oct 2022 12:47:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429848.681124; Tue, 25 Oct 2022 12:47:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onJL1-00067s-5K; Tue, 25 Oct 2022 12:47:23 +0000
Received: by outflank-mailman (input) for mailman id 429848;
 Tue, 25 Oct 2022 12:47:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=S2dr=22=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1onJKz-00067m-Lk
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 12:47:21 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28dc214c-5463-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 14:47:19 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 726D1618C8;
 Tue, 25 Oct 2022 12:47:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60931C433D6;
 Tue, 25 Oct 2022 12:47:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28dc214c-5463-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1666702037;
	bh=PRmqS5H+nCp9dplF7lCxZ/svls2XGbTUgDWMeIMlsbU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=O16r+C8HYrEgaR0P0z3/hFYuLy0xAnu9sEbIfGlOOfQCoSWHULDzBxmppvxU7hE8j
	 lVYQXCmknfIwBbCNw3vBkg5PV5+lZgKV/yNUhkExYtevIQjjb1NDTJrfemJS++jSnA
	 hwV2PWwEAX3vTqQG9BkfOPcOL976KoEVpzlxurmY=
Date: Tue, 25 Oct 2022 14:47:15 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@denx.de>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
	Kees Cook <keescook@chromium.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 174/229] x86/entry: Work around Clang __bdos() bug
Message-ID: <Y1fa082Vhar2x1DM@kroah.com>
References: <20221024112959.085534368@linuxfoundation.org>
 <20221024113004.718917343@linuxfoundation.org>
 <20221024174127.GC25198@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221024174127.GC25198@duo.ucw.cz>

On Mon, Oct 24, 2022 at 07:41:27PM +0200, Pavel Machek wrote:
> Hi!
> 
> > From: Kees Cook <keescook@chromium.org>
> > 
> > [ Upstream commit 3e1730842f142add55dc658929221521a9ea62b6 ]
> > 
> > Clang produces a false positive when building with CONFIG_FORTIFY_SOURCE=y
> > and CONFIG_UBSAN_BOUNDS=y when operating on an array with a dynamic
> > offset. Work around this by using a direct assignment of an empty
> > instance. Avoids this warning:
> > 
> > ../include/linux/fortify-string.h:309:4: warning: call to __write_overflow_field declared with 'warn
> > ing' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wat
> > tribute-warning]
> >                         __write_overflow_field(p_size_field, size);
> >                         ^
> > 
> > which was isolated to the memset() call in xen_load_idt().
> > 
> > Note that this looks very much like another bug that was worked around:
> > https://github.com/ClangBuiltLinux/linux/issues/1592
> 
> We don't have CONFIG_UBSAN_BOUNDS in 4.19, so maybe we don't need this
> one?

Good point, I'll drop this from 5.4.y and older now, thanks.

greg k-h


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 13:55:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 13:55:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429862.681139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onKOg-0005Vu-CN; Tue, 25 Oct 2022 13:55:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429862.681139; Tue, 25 Oct 2022 13:55:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onKOg-0005Vn-8U; Tue, 25 Oct 2022 13:55:14 +0000
Received: by outflank-mailman (input) for mailman id 429862;
 Tue, 25 Oct 2022 13:55:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ubGb=22=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1onKOf-0005Sz-7I
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 13:55:13 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id a4084b9d-546c-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 15:55:10 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3624023A;
 Tue, 25 Oct 2022 06:55:16 -0700 (PDT)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1358F3F71A;
 Tue, 25 Oct 2022 06:55:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4084b9d-546c-11ed-91b5-6bf2151ebd3b
Date: Tue, 25 Oct 2022 14:55:06 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: "stefanos@xilinx.com" <stefanos@xilinx.com>, Julien Grall
 <julien@xen.org>, bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
Message-ID: <20221025145506.5708839c@donnerap.cambridge.arm.com>
In-Reply-To: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
References: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
Organization: ARM
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 25 Oct 2022 13:25:52 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi,

> Hi Andre/All,
>=20
> This came up while porting Xen on R52.
>=20
> Refer "ARM DDI 0568A.cID110520", B1.3.1
>=20
> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE=20
> must not implement LPI support. "
>=20
> Does this mean ITS is not supported on R52 ? I am assuming yes, please=20
> correct me if mistaken.

An ITS relies on LPIs, so yes: no ITS on a v8-R32 system. I cannot find
this restriction anymore in the v8-R64 supplement, so it would only apply
to the R52/AArch32.

>=20
> If the answer is no, then my next query is follows :-

Answering to that anyway ...

>=20
> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
> index 9ca74bc321..dea60aac0d 100644
> --- a/xen/arch/arm/gic-v3-lpi.c
> +++ b/xen/arch/arm/gic-v3-lpi.c
> @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bi=
ts)
>  =C2=A0=C2=A0=C2=A0=C2=A0 int rc;
>=20
>  =C2=A0=C2=A0=C2=A0=C2=A0 /* We rely on the data structure being atomical=
ly accessible. */
> -=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned=
 long));
> +=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint64_t=
));
>=20
> "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.
>=20
> Is it fine to change it as above ?
>=20
> Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy=20
> atomicity".
>=20
> "LDRD and STRD accesses to 64-bit aligned locations are 64-bit=20
> single-copy atomic as seen by translation table walks and accesses to=20
> translation tables"

This (and the explaining paragraph) indeed suggests that this should
work architecturally, if you use normal system memory (where you would
hold page tables). It would be confined to ARMv8 AArch32 and ARMv7 w/
LPAE, which matches Xen's requirements.

But it's only atomic if you are using ldrd/strd, which you cannot know for
sure in C, because it's up to the compiler to generate the instructions.

This is why we have that test. Changing the unsigned long to uint64_t
would make the check pointless, since the data structure is 64-bits long,
so it would always be true.

So given that you don't seem to need it, right now, it would leave the
test alone.

If you need that on AArch32 anyway, you would need to replace accesses to
the host_lpis array with inline assembly accessors, to ensure ldrd/strd
instructions. This seems doable (there are only so many places which
directly access the array members), but would need a good use case.

Cheers,
Andre

> Does this imply that atomicity will be retained (with the above change)=20
> ? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so=20
> translation tables are irrelevant).

>=20
> Kind regards,
> Ayan
>=20



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:06:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:06:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429867.681149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onKZU-00078N-BW; Tue, 25 Oct 2022 14:06:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429867.681149; Tue, 25 Oct 2022 14:06:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onKZU-00078G-8p; Tue, 25 Oct 2022 14:06:24 +0000
Received: by outflank-mailman (input) for mailman id 429867;
 Tue, 25 Oct 2022 14:06:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onKZT-000786-4w; Tue, 25 Oct 2022 14:06:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onKZT-0004QK-0b; Tue, 25 Oct 2022 14:06:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onKZS-0007bI-Pu; Tue, 25 Oct 2022 14:06:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onKZS-0003SS-PO; Tue, 25 Oct 2022 14:06:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=ZaVt/0wuu9l/rI59oa0Riu4jf4Lwosaklc5b/7Ia6x0=; b=fFebh3GssB8HH0TkIfA0644887
	2lNOnar41iWXt3HywC1YT94BryCJJUDH6KU0A+R5ch7l7OIbPwWuUDxMlwmxUqTbN9uIQjCq2x8El
	cmJHXX7YKsXL/qD0MedCjZuW2MQqRcJ5UHZhD8n2och30bTulpse+B2bWIPIzcI2czbE=;
To: xen-devel@lists.xenproject.org
Subject: [xen-4.16-testing bisection] complete test-armhf-armhf-xl-credit1
Message-Id: <E1onKZS-0003SS-PO@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 14:06:22 +0000

branch xen-4.16-testing
xenbranch xen-4.16-testing
job test-armhf-armhf-xl-credit1
testid guest-start

Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174407/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-credit1.guest-start.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-credit1.guest-start --summary-out=tmp/174407.bisection-summary --basis-template=172623 --blessings=real,real-bisect,real-retry xen-4.16-testing test-armhf-armhf-xl-credit1 guest-start
Searching for failure / basis pass:
 174314 fail [host=arndale-metrocentre] / 172623 [host=cubietruck-picasso] 172548 [host=cubietruck-gleizes] 172130 [host=cubietruck-braque] 172110 [host=arndale-westfield] 171881 ok.
Failure / basis pass flights: 174314 / 171881
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6fd754ec0fe96511cc48e3babe1a1b650fb3994f 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 7f1c89f16790fc2fa8bc88330dc896941b9b40bb 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 d77bb6e5375f19c64d182fb7b2e53138152421b5
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/osstest/ovmf.git#7f1c89f16790fc2fa8bc88330dc896941b9b40bb-6fd754ec0fe96511cc48e3babe1a1b650fb3994f git://xenbits.xen.org/qemu-xen.git#107951211a8d17658e1aaa0c23a8cf29f8806ad\
 8-62dd49f2172fb7dfe8d4223bfa45aede05155328 git://xenbits.xen.org/osstest/seabios.git#46de2eec93bffa0706e6229c0da2919763c8eb04-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#d77bb6e5375f19c64d182fb7b2e53138152421b5-1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Loaded 15006 nodes in revision graph
Searching for test results:
 173759 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173882 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 8fc06b6e19e3df93cc989b4f85877d8a7783e5bf 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173986 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 d618fe05bf93a8884619e9362bfc5636da55e347 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174070 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 9d6915ca91519271a79bc6190a31f0af89e339b2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174140 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174212 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174267 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 2355f0c09c52d6979f9f471b23816f3081cc946b 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174301 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 7f1c89f16790fc2fa8bc88330dc896941b9b40bb 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 d77bb6e5375f19c64d182fb7b2e53138152421b5
 174309 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 c6720db5ddffec747bb0b2830e528511b1a4bfb2 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174316 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 2355f0c09c52d6979f9f471b23816f3081cc946b 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174325 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3abaa281d35857cd83f9ba3fe2c5638d26388b95 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174333 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3b382f5b38b373b7bb7bf67ad0a4aab592705bd3 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174341 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ecb778d0ac62560aa172786ba19521f27bc3f650 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67
 174353 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 28d3f677ec97c98154311f64871ac48762cf980a
 174363 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 32cb81501c8b858fe9a451650804ec3024a8b364
 174314 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 6fd754ec0fe96511cc48e3babe1a1b650fb3994f 62dd49f2172fb7dfe8d4223bfa45aede05155328 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 174371 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 a603386b422f5cb4c5e2639a7e20a1d99dba2175
 174379 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 914fc8e8b4cc003e90d51bee0aef54687358530a
 174384 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174387 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174390 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174399 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 174405 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
 174407 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 44e9dcc48b81bca202a5b31926125a6a59a4c72e
 171881 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 7f1c89f16790fc2fa8bc88330dc896941b9b40bb 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 d77bb6e5375f19c64d182fb7b2e53138152421b5
 172130 [host=cubietruck-braque]
 172110 [host=arndale-westfield]
 172548 [host=cubietruck-gleizes]
 172623 [host=cubietruck-picasso]
 173493 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173511 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173702 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 e7d7f02c8e157e936855a091948757f78c7d0298 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
 173603 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
Searching for interesting versions
 Result found: flight 171881 (pass), for basis pass
 For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925, results HASH(0x55cabeeca3a0) HASH(0x55cabd1fe560) HASH(0x55cabee75008) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56\
 b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 914fc8e8b4cc003e90d51bee0aef54687358530a, results HASH(0x55cabee8ef08) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 a603386b422f5cb4c5e2639a7e20a1d99dba2175, results HASH(0x55cabee9\
 ca88) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 28d3f677ec97c98154311f64871ac48762cf980a, results HASH(0x55cabd1ffc68) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 ecb778d0ac62560aa172786ba19521f27bc3f650 10795\
 1211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55cabeea9708) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3b382f5b38b373b7bb7bf67ad0a4aab592705bd3 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55cabee9c188) For basis failure, parent searc\
 h stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 3abaa281d35857cd83f9ba3fe2c5638d26388b95 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 cea5ed49bb5716698a11312a3f38bc8865cd1e67, results HASH(0x55cabeea36c8) For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 7f1c89f16790fc2fa8bc88330dc896941b9b40bb 107951211a8d17658e1aaa0c23a8cf29f8806ad8 4\
 6de2eec93bffa0706e6229c0da2919763c8eb04 d77bb6e5375f19c64d182fb7b2e53138152421b5, results HASH(0x55cabee92c18) HASH(0x55cabee91810) Result found: flight 173493 (fail), for basis failure (at ancestor ~702)
 Repro found: flight 174301 (pass), for basis pass
 Repro found: flight 174314 (fail), for basis failure
 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 f80580f56b267c96f16f985dbf707b2f96947da4 107951211a8d17658e1aaa0c23a8cf29f8806ad8 46de2eec93bffa0706e6229c0da2919763c8eb04 3a16da801e14b8ff996b6f7408391ce488abd925
No revisions left to test, checking graph state.
 Result found: flight 174384 (pass), for last pass
 Result found: flight 174387 (fail), for first failure
 Repro found: flight 174390 (pass), for last pass
 Repro found: flight 174399 (fail), for first failure
 Repro found: flight 174405 (pass), for last pass
 Repro found: flight 174407 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Bug not present: 3a16da801e14b8ff996b6f7408391ce488abd925
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/174407/


  commit 44e9dcc48b81bca202a5b31926125a6a59a4c72e
  Author: Henry Wang <Henry.Wang@arm.com>
  Date:   Tue Oct 11 14:55:53 2022 +0200
  
      xen/arm: Allocate and free P2M pages from the P2M pool
      
      This commit sets/tearsdown of p2m pages pool for non-privileged Arm
      guests by calling `p2m_set_allocation` and `p2m_teardown_allocation`.
      
      - For dom0, P2M pages should come from heap directly instead of p2m
      pool, so that the kernel may take advantage of the extended regions.
      
      - For xl guests, the setting of the p2m pool is called in
      `XEN_DOMCTL_shadow_op` and the p2m pool is destroyed in
      `domain_relinquish_resources`. Note that domctl->u.shadow_op.mb is
      updated with the new size when setting the p2m pool.
      
      - For dom0less domUs, the setting of the p2m pool is called before
      allocating memory during domain creation. Users can specify the p2m
      pool size by `xen,domain-p2m-mem-mb` dts property.
      
      To actually allocate/free pages from the p2m pool, this commit adds
      two helper functions namely `p2m_alloc_page` and `p2m_free_page` to
      `struct p2m_domain`. By replacing the `alloc_domheap_page` and
      `free_domheap_page` with these two helper functions, p2m pages can
      be added/removed from the list of p2m pool rather than from the heap.
      
      Since page from `p2m_alloc_page` is cleaned, take the opportunity
      to remove the redundant `clean_page` in `p2m_create_table`.
      
      This is part of CVE-2022-33747 / XSA-409.
      
      Signed-off-by: Henry Wang <Henry.Wang@arm.com>
      Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
      master commit: cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7
      master date: 2022-10-11 14:28:44 +0200

pnmtopng: 176 colors found
Revision graph left in /home/logs/results/bisect/xen-4.16-testing/test-armhf-armhf-xl-credit1.guest-start.{dot,ps,png,html,svg}.
----------------------------------------
174407: tolerable ALL FAIL

flight 174407 xen-4.16-testing real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/174407/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 test-armhf-armhf-xl-credit1  14 guest-start             fail baseline untested


jobs:
 test-armhf-armhf-xl-credit1                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429878.681186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAm-00040R-Uf; Tue, 25 Oct 2022 14:44:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429878.681186; Tue, 25 Oct 2022 14:44:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAm-00040D-Qf; Tue, 25 Oct 2022 14:44:56 +0000
Received: by outflank-mailman (input) for mailman id 429878;
 Tue, 25 Oct 2022 14:44:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLAl-0003SJ-3n
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:44:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 955942b2-5473-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:44:53 +0200 (CEST)
Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:44:48 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BL1PR03MB6118.namprd03.prod.outlook.com (2603:10b6:208:31c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Tue, 25 Oct
 2022 14:44:46 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:44:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 955942b2-5473-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709093;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=kZ1OYvSe2vZ67jkOMLmPoYcVQSX4fKFKr8Ey1iCTYIQ=;
  b=hOMjDavmMX9lGIlCXK0oWZGzhViGr1dc6P8/6lv+FC473HW0p+x1DHxz
   jJKqX47RGWue+JBhf7JJnoUbJWqmwxVgEahj6M+trRhHF4N6sxhhPSFii
   uCFNje6Cs/2llnYAMJbLGy0Lgn0mBLy5Prp9dgLDW7qVvr+DgC6WCK2ah
   k=;
X-IronPort-RemoteIP: 104.47.56.174
X-IronPort-MID: 83085556
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:xOH9Xqo5/MKMidM6h63nSCxLRvxeBmI7ZBIvgKrLsJaIsI4StFCzt
 garIBmHaKyNNmL9Kdh/YYu0ph4C7MWAzdIxHgc6rXw1FH8Vo5uZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m+
 a0hDxNSURC6uOuN7L/mSK4rl+c9FZy+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+SF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efxnurBd9PStVU8NZ730KdxTcTAic5bgKgm9qdq3GXAOBAf
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2
 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEc5oRAt5tDipMQ4iUvJR9M6Saqt1ISqRXf33
 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU
 KA4pvWj
IronPort-HdrOrdr: A9a23:B2essq6eqLyaBZfNoQPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HjBEDmewKnyXcV2/hrAV7GZmXbUQSTXeVfBOfZowEIXheOj9K1tp
 0QDJSWdueAamSS5PySiGfYLz9j+qj+zEnBv5aj854Hd3AOV0gP1XYbNu7NeXcGOTWuSKBJYq
 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWySw71M7aXdi0L0i+W
 /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLbhJavmnhnQYseuv4FElnJ
 3lpAohBd167zfrcmS8sXLWqnzd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ
 g7k16xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXavoJBiKprzPLd
 MeTf01vJ1tABOnhjHizyNSKeWXLzsO9kzseDlAhiSXuwIm7kyRgXFohvD3pU1whK7Ve6M0md
 gsDZ4Y5Y2mNvVmC56VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83085556"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AG5xutlvRldI7Rvf6M+d+N9NmqH1+K1cHsck6v7k3Owuz/OreM7V4m0775B1s1/TuDrs6JkhBd9dFK0HmEUwsVH5FOmxM52668eA/UnL0gC6ED7Lt9i2UbBYlNj8vtOtDavmUK+bJuZiaHAaN6QV1aUMEF6zdR9GO2AFIYwJSVtwdj6N9JfObSNlwxFh6ZOKB1Iz73jAU5kcll8DUwrO0MfcbHoKZIJH+FFPhFW+kH6ULS8lry4cqEVEe9w4MQHVpOtpy8mqxYz4G1zZYUayLAKJdWyAAsfegAEY6HQXIb213durgHYZtkLw8HSGCok7KVQzrxeLfOMk8EcztoowYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0Y6+G/P0SSRWP2XYjLdchAyuuRyJ+VKYBcPw6vHLtIQ=;
 b=I8B+zYP/nl/9JGepU4yBqnHhlAtE6w/Q2X0HtQdQDsp3wdMbX1NTU+GpRiKDAW7UA2KRtHEwLJOzFiTL4bUNyIH4pq03X4PlyXI7dKit/HLVivuGYqS+TqNKnsM/KVGn2LAMePWbGQO9e+ZYWUib35vzaet6TvDu1u3GMZpd7EYkcH3YlRSWN2cCLfxp2GBpQAvxIqqmtLyDSxV4pl9I65b+5ja0EXP8h2St+j7EmwdmIAAXijladLhIz47AZaBQxgzC/hi8novzofelfXidRT8OS767O3yxmVM0WtxzFd0TOQBvNJGPunG/+XiSHEiq5iiuVoFAglkLmVh7fTqwAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0Y6+G/P0SSRWP2XYjLdchAyuuRyJ+VKYBcPw6vHLtIQ=;
 b=BN4MFw96t7OvEu429E3dwdQU1qc6FCMSCfWLlPRcjAOLTYtwWdAjohhOInNssx9MpZOie00tahKRtgS9xNSngANK42aWBaoL4PgBq79QfXaEo+Rd2odxk0H7n+grSRoFiydbyCsrNdJTHgbVaeHDEuftU+URasNNmLHNBzxFEZA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH for-4.17 v2 2/5] vpci/msix: remove from table list on detach
Date: Tue, 25 Oct 2022 16:44:15 +0200
Message-Id: <20221025144418.66800-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221025144418.66800-1-roger.pau@citrix.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0563.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:33b::11) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6118:EE_
X-MS-Office365-Filtering-Correlation-Id: fbf9dd58-09bc-4ab2-cb1f-08dab69775f4
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ICAfH3NlN7QfGZyxH56JPVtR0KHNRF/YaHkOW+V+WJ+acK7vAWr8JTZXdD11wWJ+WpFESNxaXKG0dYGb1PJI86BjpXbf+x974czLU3E2yK16b7YuWTu+ijB8eg4cs6z9y7sJiNz+wS/hkujK6fK2amqsPdAFb1bCqmy5q45mfRscFhkXN/+YUJ68WH5XZIm2TkNre+40W7ly97Fo9vE1CEJHX/rpQtlVTHufRmGAvtg/Z1ZDwloOCDMshPIAwE7uX9Kd09kAtpRRZhlKHUKEuXAQ6KKK+HdYWGR9vTN7LuCyaE//gXE8zjEQhRDEcKkizAcLZ7OL5dYGQtkk8sAr4kETljrgUIlGhVj+NKuC/UZwtMxjgN42EWzAdsGHKrN4EkxKvYen2LaYRCCfhYw0tJ4hqow8tvIGR6ylB/nWWvqA79F/otI7vzbnjxuSEA61Jy6Oq4tLtR1doXLIl1KQA4XCJldJlsfUKaKEM3gVXRANIzXhxlUqd8lPYDtEow8a0Uh24KTcrSC9/jMFM7AKyT0f9I0zTw8VozTOOBNnOfS+KS+ofk1rZOKOb1BQCSXJ2gwrdVZG44U82SI+ZVZNVdf4VQb3tiQaqSwfnx3H2GeRrWSemtev7nszmTmd98GKcwYU9WvNGxdP18E8C6y3RdEZKZeBl1khr8d7IyWVtfyx581QXANLVxoeutRNtmjwiED4UUqNjEWIjrnDXssmbg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(451199015)(36756003)(66946007)(83380400001)(316002)(4326008)(66556008)(6506007)(66476007)(8936002)(8676002)(54906003)(6666004)(6916009)(2616005)(1076003)(186003)(26005)(86362001)(6512007)(5660300002)(41300700001)(2906002)(478600001)(6486002)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mlg0V0dBTG9QZ2ExbDNjT3lzeHVtYTJqUVhSU0JMMUMzYm41b1AyQU9UYjBS?=
 =?utf-8?B?UktWWTNwT0QveXNiUmV6bWM5bzBMT0FhZ2I3QzFQeHN5cVJ2REhwNHN5UTNX?=
 =?utf-8?B?dC9GS1lPT1o4OUlhM1pZQnlwVzhhN2p6aTRTU09XSktVdnMyZ3B4ZDRqUkd4?=
 =?utf-8?B?ZFM0VndEU2VnTmpxSzhJbDRkMkFZelNVVG1aRGcweDJ1eGJidDNhUXNMQVAy?=
 =?utf-8?B?dFRvblpudS9LUzhjb25TODJsR2dxMyt3WDc0SUJkVTJGS2F2ZU9MV1RKREV1?=
 =?utf-8?B?WTd2SlBvQkM1S2VhV0tpanNjaTcvSFJpdjE1Q2U3VllvYk80bEU2US82Qnow?=
 =?utf-8?B?YWc3czNteDkzbzBlMGlFOTJtRGhyOUc2NDJ5OEdGYlpTRTVHT21hdlJ4eWtN?=
 =?utf-8?B?bTdINnZHWnJON2NEMzJuRkF4V2hRc1NSdjVvaHIwWGlQcTd2ZGxsclBGRDdF?=
 =?utf-8?B?QzhhdklKR2VWT0JHWERIWU1iWlB5d0cxNjI3MVhQT0pRMWRSa1dIeFFubUg4?=
 =?utf-8?B?NWVuaFBkRnRvTVYrdkVDeHVQVGZrYWR1V1VsWjI4VFFibldQT3Y4VEZldnpW?=
 =?utf-8?B?VTVpS1NkZG9Fa3NhS1ZoUWhIK3c0M2EvTkZyM2IzTTAxMjBJL1VvdnRkZXR6?=
 =?utf-8?B?Y28vUmtUR0NIQ1I1enlNcmhJOVR2Wk1yNHlwWU84S1JPcjdoUWpjVkxZdFV2?=
 =?utf-8?B?dDB5cE5wREJjRzdOcWdRcTVsZU96TWcraWVxdWx1UGxUL0NJRUQ1dWtYclQz?=
 =?utf-8?B?anBtcEdCNjQzS1ExSC9TTER4Y1c0aCs0Tm5rWnlZVkU1UXhmcFNzaDVVaE5I?=
 =?utf-8?B?NEExN2FQY1MxdnNsdUVGZFRtUWFTQmxZdEpUMk1NZ29tQmtjZmZNNmNRMDV0?=
 =?utf-8?B?QmRyaXBpbzZ6MWpMMlVEZEl4dlc0RFZWQ0FsRTlWd1pTd21GaXB4Rkpkc0cr?=
 =?utf-8?B?TDlUR0pRL0FQTVdjcHI3cDdjNElmS1lxOE5LaUpJWVFUeHBzWUZRMEZSNExD?=
 =?utf-8?B?dW1kdFJRZDBqV2JtbXJyVkF0TkdUcVUxb0ZqRkdGQTNXSGo4b3lWNG9kengy?=
 =?utf-8?B?Y25GbEhzV3JiVjRrdHZOSWF1bnd5Tm94YkF1UEg4LzZta0Z3RWIzUTVPVlVh?=
 =?utf-8?B?aUtiNXFXVjJKMHZzejd3c2wvY0w4bEZ5MjhlNURiaFg0TXhNNWY5M0V5a2NK?=
 =?utf-8?B?L1ZFWkN6K0pmcXUxWW1nSGVRS0xzTlJyMGpRRlNCM2FJZDh5YkVHYUUzWE96?=
 =?utf-8?B?SXNaazVwSmhhTkd4czdyc3MwQVUxQzlVenFpeTUxb29lT3gzSC9JbHQzblJv?=
 =?utf-8?B?STB0TkVjclkvZHJTdmxtbkNTUk5MUlMxbmtsVEpodmJqdUdxdzVHZFQ5ZklJ?=
 =?utf-8?B?Ylc3blRHbEVuNTB5TGtXZk1DcjdMWTBERUdjT1BvRlliWjI1NGJGZ2NaZGNo?=
 =?utf-8?B?eFNOYXgrTDNvMjBhTkh6OFRUV2g0YTNQd0g4OXBBWmVQVmY5WEpWekd1WmJ1?=
 =?utf-8?B?Rmx2eUEzbldDM3cxUEQvbGhSMXN1VjJlSGN2MGJDT2ZJaFlzWGNkZi9SbjZJ?=
 =?utf-8?B?eUVkV2NrNWh3cEVkUzA3ejNiTU92MkVhdW5QQkt6NnVUaDZxZkRWQ2ZsVG0r?=
 =?utf-8?B?UkN0SzVoRmdDeXpkOEpUSWhiekpNOG9zVDlrRXo1a2k4MU5KaGRtaDlYRnNC?=
 =?utf-8?B?bUNlYm5pNCtoSWtLMlpHWGhxVEJCWWZ0NENxYjZXNXNwcWY4UW5wemk2bnJx?=
 =?utf-8?B?MGtKY2xLMHJzeEFkMCtIdmhDSnVTWjR3K1lwMGxkTnhUcjZPWXRqMmVCR3Zn?=
 =?utf-8?B?N1dsMkFjYTFGb0MxN3Y3WUp4S0RXTWF3WlJwd3p3Q2Fjb1EyL0NwWHloM2hp?=
 =?utf-8?B?RlRabzRLTzJ3VFhLVFhhVzFuMFJZWmU4TVlJbDZTQndJUHFmR2ZMdWxFZitJ?=
 =?utf-8?B?b3JzMkdCN2dKOVY2U0ZYWnpkdTRUMGJIckFWT2ZaNUZoU0NiekMwWjR1VTd0?=
 =?utf-8?B?SVp3aWdBM016RWJZZXI5czc3RFJTRzRJTFNjMlgwV290dUVVbm1Ob1AvcnBI?=
 =?utf-8?B?cDN1ZEFsN3FjbFZaaG5nTk4waVBDSlJmNkY2UWl5M0ZuTWprMTRxSllQUHZu?=
 =?utf-8?B?S0h2b0Y1RVQwRnVrUTlBc1VaLzVQb2daZXB2c1l0RE1CcTQyQzJqcWhWdGQv?=
 =?utf-8?B?QXc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbf9dd58-09bc-4ab2-cb1f-08dab69775f4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:44:46.4296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BhSehKPihtWP5topdIBJlsD38OihTVkZOWKAlPs8lPiTuS9lJ4z2kdUODIOtsIDvuElaedzzaLElIdT4cekIjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6118

Teardown of MSIX vPCI related data doesn't currently remove the MSIX
device data from the list of MSIX tables handled by the domain,
leading to a use-after-free of the data in the msix structure.

Remove the structure from the list before freeing in order to solve
it.

Reported-by: Jan Beulich <jbeulich@suse.com>
Fixes: d6281be9d0 ('vpci/msix: add MSI-X handlers')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/drivers/vpci/vpci.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 647f7af679..98198dc2c9 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -51,8 +51,12 @@ void vpci_remove_device(struct pci_dev *pdev)
         xfree(r);
     }
     spin_unlock(&pdev->vpci->lock);
-    if ( pdev->vpci->msix && pdev->vpci->msix->pba )
-        iounmap(pdev->vpci->msix->pba);
+    if ( pdev->vpci->msix )
+    {
+        list_del(&pdev->vpci->msix->next);
+        if ( pdev->vpci->msix->pba )
+            iounmap(pdev->vpci->msix->pba);
+    }
     xfree(pdev->vpci->msix);
     xfree(pdev->vpci->msi);
     xfree(pdev->vpci);
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429876.681164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAf-0003Sb-Ab; Tue, 25 Oct 2022 14:44:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429876.681164; Tue, 25 Oct 2022 14:44:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAf-0003ST-7d; Tue, 25 Oct 2022 14:44:49 +0000
Received: by outflank-mailman (input) for mailman id 429876;
 Tue, 25 Oct 2022 14:44:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLAd-0003SJ-Vh
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:44:47 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90952095-5473-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:44:46 +0200 (CEST)
Received: from mail-co1nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:44:37 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BL1PR03MB6118.namprd03.prod.outlook.com (2603:10b6:208:31c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Tue, 25 Oct
 2022 14:44:35 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:44:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90952095-5473-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709086;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=8PhQOTnQuuHUhM3T+je/yvILClfsp3W7lJU0yhhLJTw=;
  b=ShJm4Se3que9WkEYqd7JgC0+sc0Kl7439RYavlrRE6uBOxt/SpWPgc5E
   16SToB9yipGVfDDk2p+q4So4435TjEHyRpAkpX4OEFwXhFTCVcOj05jtQ
   d5pCmwwox+HPJjSwvhFeAgG+ajwxw1Cl3g14fn/7fWkO3nn8YcYfhxoIM
   g=;
X-IronPort-RemoteIP: 104.47.56.168
X-IronPort-MID: 82566513
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:+ld3M6oXfaGuWCTNelwENeZlRS5eBmIpZBIvgKrLsJaIsI4StFCzt
 garIBmPOPzYa2ujfNx2Oozl8ksDvZfVy9FgSgU/qigyRSoToJuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m8
 v4IKSJTNzy5hcnm2+rgRuVWg+EGI5y+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkkoojuiF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efx36lBt9LT9VU8NZEx3uB+0s8DSYcenqLmfT6lEqCRPlmf
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2
 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsVQIY5/HzrYd1iQjAJuuPC4awh9zxXDr3m
 jaDqXFng61J1JBbkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5
 BAs8/VyJshXZX1RvERhmNkwIYw=
IronPort-HdrOrdr: A9a23:1huVyq81FFi0N4YzB29uk+E3db1zdoMgy1knxilNoENuH/Bwxv
 rFoB1E73TJYVYqN03IV+rwWpVoJkmsjaKdgLNhRItKOTOLhILGFvAH0WKP+V3d8k7Fh5NgPN
 lbAs9D4bTLZDAV7PoSiDPIaerIq+P3lZxA692urEuEGmpRGtpdBkpCe3KmO3wzYDMDKYsyFZ
 Ka6MYCjz28eU4PZsD+InUeReDMq/DCiZqjOHc9dmgawTjLqQntxK/xEhCe0BtbezRTwY06+W
 yAtwDi/K2sv9yy1xeZ/W7O6JZ9nsfn17J4dbuxo/lQDg+pphejZYxnVbHHlDcpoNu34FJvq9
 XIqwdIBbUB11rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1HkwntlmOs5/L
 NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMAjgYdq3MAiFX5uYdg99HqQ0vFoLA
 AuNrCV2B9uSyLWU5iD1VMfgeBFXRwIb2e7qwY5y4yoOgNt7Q5EJnsjtbAid0g7he0AouF/lo
 L524RT5cNzp5wtHNdALdZEZ/eLIUrwZj+JGF6uAD3cZdA60jT22tfK3Ik=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="82566513"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=flluZKBXtaJmnRSCPZ/bpW9X3G3NkLhIBN3FR+s/MjElkEZY4+qS189YVrXRwOoU9g1vmJ318oiPgGx6PFwmbE8xnCy2qu73nWi5nu3w506/IJ3XMjp7nZphhXtioWO51JnGwYHmqDnVNfP6DERJCQoC7IwEhyREQsqfjERxGYJYfaW8dHmpFTXZBKFAKmshvy9nOxUuMDgyBuNwHxYw4TyDZIEgrptKKgIbD2tdr+vwlxYvWGNI+zrt2ya3WtuIEKMEptCLr7uLxsr5+G5uLwvlAYfrq0JhczOSsH2O3jCb16uEh9Zt2CpADL/p/HiCWVeSbSaNTYQFQPjeBN+EIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e7GPUi43FdBKm4cKAasnOZrxGiaeRkj/e0kPX1lwbDM=;
 b=bnxsBtu7ZBZpX5IRHcYv2pIpTOY8F/YNzG/2ZkwrhBcpSaw0BnwtDRl8G/anCGkQUIuT70toQwIrVu0hVBKpBdi8eY5AHCJP5va00phJvpAVcvREUlTsu3Gsoo3sSK0HnlAtf+hiJW0qO2rMkA/UTbvoO1F8cD7L8bR2yon2rNpA6AYoJrjWt/TVoWPjljguTGOFiCGK+w9TjTaWxcRhDjp2ZE9AVCF54JzujwODOqJ9AYTbAG9ecPBkSwgQczyPl7L+1CMZWNFPthIbhyF5cbj/si1TyiqoweRUjcDyfzWZS8lFak3/JfT9SM3Qh3cjkbrONE90ZcU6xvr8JCbQMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e7GPUi43FdBKm4cKAasnOZrxGiaeRkj/e0kPX1lwbDM=;
 b=GJF+SBCy1gh0kND3sRyCKkSJp5NkGMYrTSY73aG9boI4eUB3Q5OxOsWdZAC1mkHioGZ1jya68gRIeGdzQM/qolaBa8eWYowt3U9Ccbn9ev0FzsSE2usdhKSCAp+0j+mDdUmBVjt1dOl5Nm57YICVQFMzbl8kZewnwlTRX3as1q4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding handling
Date: Tue, 25 Oct 2022 16:44:13 +0200
Message-Id: <20221025144418.66800-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0270.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a1::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6118:EE_
X-MS-Office365-Filtering-Correlation-Id: b084e6e8-35bd-4ebb-e594-08dab6976f84
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oD5q7s+S+Mwhb95f27QE7fCIBAn3OE1hbsywxafDOu6yJFQ7NheQKcV2iB2SQnFOIvJKg+QGibD+puDhBG3pXmBIU6as7CrhGKji2gs/7YjIg/khWqR57C0TwDnXCiRNWugY1foKHuvpbdTQu7F/H9CIa08L6FNh1qcp9fhEtSJm+Yuoj2n17h/K7UzOobU73GGkiqMGnZOJWOGTnAO9QRxcI5KCdR7PH2dfea9fIgltRfbngOmJt+LxRtOyeF3jVokrcG8A0p0xioCFq0YMMgsQI4nCKR/WithXFWwcR02oNt6u365L+66DLyEvXCf4xMuKXxcM/6Asw7d9eE/kZZhWQyRP6tJjavK4LbvC6BAGowSF+60HJinxzeeC25IEkjW0ynl6rkeGTHcinPbAZeAyrHJwXvjTmim6kP3xWe1OCqfXaorq7EFfmpdZI79c4TdqqEEt/vanWpfqMG6gaOD1B2BcdcGZ6VmfI5Tfrt2UbOJtyt4m3goN/t5KIDutDdBnl7vHbovzzDNPtqLPtuanSFNDOLQ7g4/8KD28Hj9izzzGwc7oPZ2AWXnp9x0tHP5IfFe/kELnbjM5vQjcaXZyBBzSXMyQuQ9+nidBMi9x9v+QRPlccKNqjOWm0eTh0iI3oTmT0gRAtPoR9CKuFt+EVPeiHJF7uX6pwS2aX/pTRdGsjTII4v2w5Gre0Isj0OEmv+KukHIIjgdFxmIRLg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(451199015)(36756003)(66946007)(83380400001)(316002)(4326008)(66556008)(6506007)(66476007)(8936002)(8676002)(54906003)(6666004)(6916009)(2616005)(1076003)(186003)(26005)(86362001)(6512007)(5660300002)(41300700001)(4744005)(2906002)(478600001)(6486002)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Wm1JZVlOVlEzYVhIdFNGcTkxSDBZamgreHp5VDRCZFFmZTR0S0dWbjFlWmY2?=
 =?utf-8?B?dDVHVVJQdGh0UHc2UFdQZStEZTkvaE9hT3dScmFHcWpKSjBuYzNuUzJaNTdG?=
 =?utf-8?B?elBaUDNNVXZxRkluTGk4YzRaQ3psY1RMSDlhaVkyeVFLbTA2cHptRk41Z21V?=
 =?utf-8?B?d1FWRGlEdk1ySEpFaE5CdkVqaGQvZkxVNWFUYnF2RG5USjJSb2JVRWJuMHhY?=
 =?utf-8?B?SENxSGNhRVZING9zdE5OMXJwZnBBWHVZckFidDZrTnp3N1RYKzJLWTdmMVdm?=
 =?utf-8?B?NS84ZWlNTiswekhtRGlqdUFXYjRCaDFTY1FDSm5qSEdvbmJEdnNSYUN2N0Mr?=
 =?utf-8?B?L3VYWitaNkUrWVVBY1dwWVpHdnpRU1FlblRhWXV0aEs5OHo1T0xCNXdFUWpv?=
 =?utf-8?B?T3BTbXl0Z1dQQ0lHcnZRY2cxVDg1dmF3M0pIaHh3QjF1Y2FXczBmTnNZdFVY?=
 =?utf-8?B?MmVOSVA3MmZsQTFPQUtqNHVxbUtydEgwekwzUlpoY1dTaXk3NmZKTFBaS3Jy?=
 =?utf-8?B?Y29TUEpOLy9WdmxZVThETEdleXpROTlIRGpacFhONUhBbC96dGxiYy92MlNZ?=
 =?utf-8?B?bkdPd1o0R25SV2N4MTZ2TFVXdWhOZTVFRjZyZlBaY2dNeVY4MGV6ZFFkOUo5?=
 =?utf-8?B?TENUM25sZFFLWnVPY3Q4bjZxekJiWXFEdEtBWGxFR2g1V3NEeGVkV3QwYk9P?=
 =?utf-8?B?azBteTdyOEp1dUxFK2piZG1SMWtMZ2FqMjNlUlAwL1NxbkZ1ZDhNV2VOaXln?=
 =?utf-8?B?U05xeWhrbzhZYmZ0UXJMTGRMaGtiNkFpNmNDOTgvYm5selU4SHgxT1FFMmRt?=
 =?utf-8?B?WnZIZmNjTFMyV2YzOFN5TEtRcjQxbWtudmpuNHNRSjIzekY2R09UN0Q2UXM1?=
 =?utf-8?B?YnRBOExwNE9TbVhub1FxZTJvMUQ0ZS9jeTc1blFCS2VmRXE1OXRiUG1lalQ5?=
 =?utf-8?B?ZmM0cTdGTW5JS1gvQ3N6dk0xTGhqdjlqRUlScjhrVlIvazErVXljUDc5QkNS?=
 =?utf-8?B?L3AybFpzTUtXRy92MFdzbE80S1hySnArQkhmVWlkWW1pTzFPR1dBVlVOeVpF?=
 =?utf-8?B?SDg3RTdpek5YTTFZblRaVWtlY3d6RlFkdmNaWkwrcDBNZGJUZ0g0Yno5Z1Q0?=
 =?utf-8?B?RE0wcjNrMlpRUzJkZkhtc0I3QmxGc2hVbjJoamN4QnBEUmhNM3hjVmtoUkJQ?=
 =?utf-8?B?elIwK2RSMFhhdXJ0ZEw0a0c2QWVXdmUrU1JtR3UrZTVSZ0pzR0NlTHZqYVRK?=
 =?utf-8?B?RHJyeGNpSUI1TUFab2tuOXZZWjZuaW02d1NBV2o1VlJkMjk1QXp5MVFZVXVV?=
 =?utf-8?B?ejZ1ckxHbHBPRUxPdEVTMERsS21LcjFlbEdZREs2NlJiSWhrZjZsV2NsZnIv?=
 =?utf-8?B?MFpqRHh6M2hxcGg1cTFva1RLNUZoMHprajZlaklDc29wQVpOT0t3bVZDRmFo?=
 =?utf-8?B?dWlNclg4eTZPcHhnSjFrRVFsOHMzOHBPOUw4cDhBa2E5S25jNWM5aGxOTXdI?=
 =?utf-8?B?Q1NPVXdHQU11aTdkcTNkbndpbWZ6T1ptWEIxOEZyeGNJSVJtbVFQMmwzSUxW?=
 =?utf-8?B?eDVtWTNuL251d0NJWlBpKzYrTE9vRFJGY3Vuem1xVzY3V2tUNEZ1QitldFNX?=
 =?utf-8?B?ellMc3A4ZHFPNmtGK3NZeGxxakxDekcvbmpzUHFSNnh2ZFF2a2plRkpKOHN4?=
 =?utf-8?B?SnR5OHk1dHU2aW51elc0OVIzS3prQ05sU09wbUlNN3R4bjBlNmFjVE1jc2dw?=
 =?utf-8?B?dDByMzJRQ0hiV3NMQXpjMGVnY0NTK25lYUpoNHdQdC8yNko0UDJZQVk5eGVQ?=
 =?utf-8?B?S1pKTm9pTkVES2pYaVN3dWorTWk1Wmo3WWV2TWVJZlBKTHRtdFk2ZTRNZzh1?=
 =?utf-8?B?dUREbXV5WlFwd3l2Smg5UU1xRDJVUkdSSlliUThaNTlDWVdheUJvdHAwVGNv?=
 =?utf-8?B?bkR5ZHIvdTZvRkFJbEplZHhWM2pUNy9FYVRVYmpWdE51emZrdVpLdDRZUld0?=
 =?utf-8?B?c1lGQVM1Um4wZmxJVnF2SzMyWEVqSncxeEZFYm1Oc3lsZnluR3cremVNMzFU?=
 =?utf-8?B?S3A1OVhkUTlVUnNJd0VsbW1KWEo1TjFTWXVmZXNMZWFWOERzZjkvcE12WWpz?=
 =?utf-8?B?cUNnM0dTb3V5YWxMcWJmVWdBVFdRd1lLeERCeDRJRUpFNTJOMzh4cFVWK0tE?=
 =?utf-8?B?Umc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b084e6e8-35bd-4ebb-e594-08dab6976f84
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:44:35.5206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kocVIjseQLSRMvSYSuV5b68D+0Qlyf8IWxmJtspMWNc8nwSK5iiTufibg7fz480S/f8QTzAvURo0L3yT4jx2CQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6118

Hello,

This patch series attempts to fix the regressions caused by 75cc460a1b
('xen/pci: detect when BARs are not suitably positioned') and the last
patch relaxes the check done when attempting to write to BARs with
memory decoding enabled.

I consider all of them bug fixes, albeit the last patch is not fixing a
regression (since vPCI code has always behaved this way).

Thanks, Roger.

Roger Pau Monne (5):
  vpci: don't assume that vpci per-device data exists unconditionally
  vpci/msix: remove from table list on detach
  vpci: introduce a local vpci_bar variable to modify_decoding()
  pci: do not disable memory decoding for devices
  vpci: refuse BAR writes only if the BAR is mapped

 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 52 ++++++++++++++++++--------
 xen/drivers/vpci/vpci.c       | 14 ++++---
 xen/include/xen/vpci.h        |  6 +++
 4 files changed, 52 insertions(+), 89 deletions(-)

-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429877.681175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAg-0003i0-NX; Tue, 25 Oct 2022 14:44:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429877.681175; Tue, 25 Oct 2022 14:44:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAg-0003ht-If; Tue, 25 Oct 2022 14:44:50 +0000
Received: by outflank-mailman (input) for mailman id 429877;
 Tue, 25 Oct 2022 14:44:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLAe-0003SJ-S3
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:44:49 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 928cace9-5473-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:44:47 +0200 (CEST)
Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:44:42 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB5808.namprd03.prod.outlook.com (2603:10b6:a03:2dd::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 14:44:40 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:44:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 928cace9-5473-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709087;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=DOkJEnD0h6trHJXhBif37jv2pfl7nFk1KQQXgU7n2N8=;
  b=ITdCE3bimAHrwaCxXV1Q9YieNySMc3aOeU181wO/crkbB6+zZ8XRjkBN
   V59GMnxGThWuTThYVLBGc0gAFcfTloowF2LLEC9hDsom5GJd/WI+jmp84
   /NvDJQeAIcD9/dcU95qwAEe29Kj+ukZ30Nv1gU53kITfvpHBrCTvllkYh
   A=;
X-IronPort-RemoteIP: 104.47.66.45
X-IronPort-MID: 82566521
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:X6ABna1BRykFQ35BaPbD5fNwkn2cJEfYwER7XKvMYLTBsI5bpzJUn
 zROXTyGaPfeazb9c91ya4mx80wE6MTSz9AyQQo5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlF5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUc5stxXkJr3
 sU5DzAnMxqhmry4nZi0H7wEasQLdKEHPas5k1Q5l3T8MqxjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7gzL4/Zqi4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWDYrCzx3LancSXTYJkvNry8x69TukTI/EZMWR8tXlSKrqzs4qK5c5cFQ
 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yyaUAHIVCAFIbtMOvdUzAzct0
 zehndnkGDhuu729Um+G+/GfqjbaBMQOBWoLZCtBSBRf5dDm+ds3lkiXEoslF7OphNroHz222
 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9fABYTzhRqYELukcw==
IronPort-HdrOrdr: A9a23:HsPeFaEZY+5VymBSpLqFc5HXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79
 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+tOKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+zLzGomjMlFx9fy7Yr9m
 bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHfgWK1RH5m5+BwlquCm71gn1P
 HKvhcbJsx2r0jce2mkyCGdrjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MG40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIZLH45JlO11GkbKp
 guMCmFj8wmMW9yLkqp9FWH+ebcEUjaRXy9Mws/Us/86UkloJk29Tpb+CUlpAZxyHsMceg72w
 36CNUYqFg3dL5xUUtcPpZ0fSLlMB27fTv8dESvHH/AKIYrf1rwlr+f2sRH2AjtQu1C8KcP
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="82566521"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ToKV/J6BjCbhqJKfpmfdeKTdUhCF67A3FTTifpiATNcFaV9+2AqG762hAdqnjjMZ7d7njv8vrRX3DkvRWS9bt1rPvzXDr7a04swA0yE+P98vAnqDRzZCG63/IByQn7jC/h2Bmv7UUy8ynpkQLCnc1/OJjN1bP9pZ7nRcHdHsDXC+6DMYIOEYX7Vig1h4nEBw6WQm3/t7VA2ginz1Ue+FcPsIpAq99dYYxIp1tEbmSLXNCjNH+R6NuVZ9X0Gc5IW7KIu8FgfENTubmFRWO4sslGk0IAJCEI7cRD1fck7GS73Ov8b3gjW1YfiX5Jrk1sSItAT8bhuFuiEWWEScEQbknA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E+gHaCnlEGM0dyPAS/K0/1cQ1iwF7mXhMFtAy5CGtoo=;
 b=Xcig0Ec5GNqxmoMTvVrqPXGdoo3dOCx0jnsxQCRrdpCftmVW0y1fdBvzcCp2oo+pX2uFda4I2ngHzNYhii2CBsE34GBlnlrh5YRf2+aIvlIHtmJivfGWgcEO9S5i2WlPdoXCJe2lmHmBfYqNYgPtzsgCgLMNFv20JFGW3/jRrrngnRom3lS7T6BEFD3vw++ShERN0TAIILe8pHseGziDM8CoKyarYHPIrNwdMhtPKxHjKWNWk3WaSSYVLjs0cTwqw7b3Oahg4VU139YRrpIbWWKvTYCdwAIKMwAPitngndKAq+YX0mqhtyd5PJ936Pjbn7MCDU+ASzn8LqBbMSig9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E+gHaCnlEGM0dyPAS/K0/1cQ1iwF7mXhMFtAy5CGtoo=;
 b=wwjG1KuVIr5XA2Bz7Hrbxnq2rf4ycBc/3+lQuNFCocPiaqI2kVmScfCB370GOs2POYT3wU/VdSf0ykB94NfD0hmmyw3TGaRwO+xWg0PBWwTEK2KLIPHTr69a00ur+EL5DxdWIvct+/7nKjVLi0469l/JXOC8Ah0XhYRi0MiNLsQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH for-4.17 v2 1/5] vpci: don't assume that vpci per-device data exists unconditionally
Date: Tue, 25 Oct 2022 16:44:14 +0200
Message-Id: <20221025144418.66800-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221025144418.66800-1-roger.pau@citrix.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0187.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:311::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5808:EE_
X-MS-Office365-Filtering-Correlation-Id: 1e955c7d-ab52-4a75-7a85-08dab6977233
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JBQaGP3AuzUPiCNJsQt5iIlakGRNJPSGlyUBLs9FgM5GRCY3EiczpiWIkmyh+x6nw97tJDjxGXgcsyNnTXU+Bd7ub+WQGL0CgfHdjIllNdKDLaPlOzbb2qPWC6czyXtOjD8hZ05Th0lKkQdGMWH3geNFIfYWuDShfPOT2RzLwqlBEUwCM0RSgZUyhW9VKxViRaLbmPGbIOD4FcJz+Qn1kLUNrs3CJJdFwYP6LSLRr1uNms/xihrBgEmKOVLfDmoEijAddg6bdkw1tXb5oco8JZUrM6of3uFMv8ajtTVyENwp3zS5qQ0l1HuR69UgyliGn5RiLZgh9aaSMtcPGWiebk71fQbpAubaKHOtpYJiqwrx5v8/zaKR+lGTDpJTxWjeL0XlAFEYDeiCIhNahXKtdUcYuThZdQV0rmb+P25UOlkr0HNVWQjG7QCnhn6U/b3LHuAfjFq8xJbVAt21VoJT5kKQkRxg4F931/PzihxPphwKonuzjGgQbq/2XwbVs15EbhUujlkmbgExcIykJ4lHBE8gGaiYUukqn5ImOVAQKpT88N3HUAVIVb2iE58PdODrc+JENteR9zsk9H8jcF+3S0yADnH1BidWMWnj6bT+JIJDU8OmdAK87uEPRFNWIj9cmAHUJsUHNjSAbf8TBwTHVxOsVVm4TIJgex9dbrdXKxk3v5sLTkw6FDJVDDobtKnIaqsE76vCdca4TmaXGhlSCg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(83380400001)(316002)(54906003)(6916009)(5660300002)(41300700001)(6512007)(8936002)(26005)(4326008)(66556008)(8676002)(66476007)(66946007)(86362001)(6666004)(36756003)(6506007)(2616005)(478600001)(6486002)(82960400001)(186003)(1076003)(38100700002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZnpUY3BRdDdIUUNhSEVDeFZTOFNEWTladXZ0Rm94NmozU3pDWmovaEE2d0dm?=
 =?utf-8?B?ZXh4QUM0dVNSN3l4UFBnV05ZYUx1Q3E0VWFjZGd1ZlMrVURjOGpOYVRuTWMv?=
 =?utf-8?B?NkJ3aVhaQkR4YisxOHFDVUhYRXRSREtKVlBPcGdrV1Fjby9ITTcyZXVnS1ZM?=
 =?utf-8?B?MFJuSEZQamtzbUtRSmtzMnJhaTdNeDYyd1JMdnlZR25qdHpvOXFPMkkyRTZx?=
 =?utf-8?B?aUlSQWdiZ0UxZVVROUllaFh2czRPMWNuVVYzQ0E4bm1BYjlxUGV0S2VEVThj?=
 =?utf-8?B?R0thb0tYcFpSekU3UjJ0cS9IZTl5bUd4dkdzWWxveWFXbjNZWWtmTVUyQTdM?=
 =?utf-8?B?ZTM5K3JzeGhjS2drajZ0KzFMMmMyQUdPdi9FZlhYaFRCejNsTWM2bzlzOXJC?=
 =?utf-8?B?T1VQTUR2UFhEL2VHNS9uOWsyY1BjR3ZPcFQwUzQ0TldUYittWkdNRGVuZ211?=
 =?utf-8?B?cU5GV3haaXRTb3JCRHJJL3VBS2RST29MSmsyZ08yL0h4S0JtWE5rWGIxUTRV?=
 =?utf-8?B?WnZManlLWkp4UkhBemFvanlDWmw3eGdocTIrVEZ1clB2UGhpZjlsM3pGRVpl?=
 =?utf-8?B?LzZmV2dDMnBHOTlhUHFKcVdhUFdTamZReVQ0TVM3Q0Y4VXUrVXZlYk1uOTQ4?=
 =?utf-8?B?NEwwRFFMWkZnRVdmSS9PaVpnN0JXNE9wenpUQ05FVDY4eHo1cUM2Ym8rWFZw?=
 =?utf-8?B?UEhBZ2Ztb2NYZFd1ZDNzbm9kUS9yQUswSzhsdkk5TTRFNUViT2FhQitKWFRV?=
 =?utf-8?B?cFJGcGhvRDdzOGYwaXJOQ3plQW5kUlcrWksvVVlTSVpINFdsUWpZTE9UWjFm?=
 =?utf-8?B?QkFTaFdXWjRWa3cvdm1ReUpjRnhHRTZ6a0hUenNodXNuQVh6TU8xdGpzdlVj?=
 =?utf-8?B?TnAxRFZLZndpdFNqak4xTDduV2syOXd3aXl6MDAxNnZvYjBFS0E5emxaWnJs?=
 =?utf-8?B?eG1YdktuVWNEWFZleHBCOFUwY0pQakI0a1pkb05xaUQ4UDVrZGRxcHpNZmtB?=
 =?utf-8?B?VUVPa2V0QmxDaHNjWHN3T01WdnRKM2srQmRhWlFaajFBbGRjQWxoWFNFSEZ0?=
 =?utf-8?B?TDI3dGQ5aUxVWFErb0RmSnJqZDd1Uyt6aDEvbDFaR1ZuWXhSMHdhbjd1bHd2?=
 =?utf-8?B?K2t1dFRQUExvOEw5Y1lmaDZUd0EzTjFBdWY1VWxDMUpZcHZpYkVhZmJBSEY2?=
 =?utf-8?B?OGwvRXNPK1RmY3FOcWcvU3VncnY4aGx2WHhSWlg5a1hNaGc4aGZkcWc5OFNh?=
 =?utf-8?B?S0RZRjFYUVRxNjhKMGViT1FzYTNJUURrOE5sdElYbFhzSFdkUUhOclROalpQ?=
 =?utf-8?B?K3k5VlBLbEJiaU03VERYNlZnSnBFMTZjU1dlOEo1bU10b2xVd0Uxc1N6Um9o?=
 =?utf-8?B?OUZZYkFQV1dOZ0E5ZEVCSE81TjNEUzhqRU1ySUZTYVVMT0NvRzBpUElReW1p?=
 =?utf-8?B?a3FROGtCT2FmT0dza1hSZnk2a2ZWcmFZMkFHek1IdmgyMGR1YzFHb2dueHdV?=
 =?utf-8?B?TDRuOTg5R1pXZ2VTaGFLY2ZmcERGeWgyNi9OOGdvRkR2WkhwakRlQUtucWRY?=
 =?utf-8?B?amw4WkNEYjMzai92U2Z1Y1MwR21BRCtrQ3ZORDJxbVJEK3ovblBRR0VhdVY5?=
 =?utf-8?B?U2FTYWQxeld3Q1JSSGtxNlZRVVFjQkJuKzZuY0ptWEQyOHQ4VHVHc3hLVEVS?=
 =?utf-8?B?ZjFPSkJ2eUJvNDRIc21zTUpWY2Fhd3REbHZ5dkkxamF6Njh2cXNOUXhNQ0Mx?=
 =?utf-8?B?MnBpSU0ra3BWNXJTejZSZ2lXWjQzWW9GTWNqdGtDR3YwbEhWSWovU0tjUitO?=
 =?utf-8?B?Q2tMc1hIM2hzMTJ4Y1laUzRtRHYyUnFlQ0UwNDhMRkcwZnRhcHVxeXp1KzFC?=
 =?utf-8?B?cHk3b3d1V0twNzhJeXFEYnZLZ21RSTVJZzVmWHQveGlpazh6TTZvQmp3cGpX?=
 =?utf-8?B?NThBaDBMa1pyakhlM1pVbmlROHZMOHhaWXZITVBjYUxWbGZkSFVHdXRrTUt5?=
 =?utf-8?B?L3lKbGNPdldmS1dHNjdhaXUwR241Q1ZJVDNqT3lCNU5kQnBMUXpBZVdHV3Az?=
 =?utf-8?B?ZUJnUDZ0SDNycnFUQ2hKSzZaUFBuN2VkRzNVT2NJWEJ4Y0FGa1YyM3E4dXVt?=
 =?utf-8?B?UXFEdEo1aUZSbVF3aEJrOThKZlNYWEpHeEdpc2dRQXdBT0l4MVFSdmJ6UGg5?=
 =?utf-8?B?VHc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e955c7d-ab52-4a75-7a85-08dab6977233
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:44:40.1621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ju/+8MQ+B2nAzHHq1+FIq8d2eYJ3HEALWhO+d8H2eHCBopZz2eQvAYeAc/KlT3kyUurpQGn3iLxuRzoJskXASg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5808

It's possible for a device to be assigned to a domain but have no
vpci structure if vpci_process_pending() failed and called
vpci_remove_device() as a result.  The unconditional accesses done by
vpci_{read,write}() and vpci_remove_device() to pdev->vpci would
then trigger a NULL pointer dereference.

Add checks for pdev->vpci presence in the affected functions.

Fixes: 9c244fdef7 ('vpci: add header handlers')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/vpci/vpci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index 3467c0de86..647f7af679 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -37,7 +37,7 @@ extern vpci_register_init_t *const __end_vpci_array[];
 
 void vpci_remove_device(struct pci_dev *pdev)
 {
-    if ( !has_vpci(pdev->domain) )
+    if ( !has_vpci(pdev->domain) || !pdev->vpci )
         return;
 
     spin_lock(&pdev->vpci->lock);
@@ -326,7 +326,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size)
 
     /* Find the PCI dev matching the address. */
     pdev = pci_get_pdev(d, sbdf);
-    if ( !pdev )
+    if ( !pdev || !pdev->vpci )
         return vpci_read_hw(sbdf, reg, size);
 
     spin_lock(&pdev->vpci->lock);
@@ -436,7 +436,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size,
      * Passthrough everything that's not trapped.
      */
     pdev = pci_get_pdev(d, sbdf);
-    if ( !pdev )
+    if ( !pdev || !pdev->vpci )
     {
         vpci_write_hw(sbdf, reg, size, data);
         return;
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:44:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:44:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429879.681197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAo-0004Gj-5s; Tue, 25 Oct 2022 14:44:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429879.681197; Tue, 25 Oct 2022 14:44:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAo-0004Gc-2r; Tue, 25 Oct 2022 14:44:58 +0000
Received: by outflank-mailman (input) for mailman id 429879;
 Tue, 25 Oct 2022 14:44:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLAm-0003SJ-7l
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:44:56 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 96f48f0d-5473-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:44:55 +0200 (CEST)
Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:44:53 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BL1PR03MB6118.namprd03.prod.outlook.com (2603:10b6:208:31c::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Tue, 25 Oct
 2022 14:44:51 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:44:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96f48f0d-5473-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709094;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=lK5sCkafKTg60/tnmYLI+7xQSzr6OWS0/h/M8T5Wwd8=;
  b=MfiHlO+c5Li3mT3kQY21PgNmtnZLKiQ7PedNBrMJRhltf+Xl2avlV1BM
   KVoMfH7OOfT6SExN+cm3UwZt1z57oYJd5ARFEGBt0qqYpRLfqVsGfPMFk
   moE5ioo9TzbH3fd9hCH9meMSg3zY/G+/47yyMVQHH0svDANC4/XHPTVo6
   I=;
X-IronPort-RemoteIP: 104.47.56.170
X-IronPort-MID: 83085569
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:LuUh+6NLkB4Un2bvrR2GlsFynXyQoLVcMsEvi/4bfWQNrUongTFRn
 2oeWjrVM62NMzDzcohyYIzi9UMDv5CDm9VgHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo5WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eJ44cxsxtG2ty0
 9MUJS4wYkGZn8Gq+efuIgVsrpxLwMjDGqo64ygl5haASPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9hTM+vJfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPkmLVry/y14cjmwv0eYZNM4eZ3MRajQaS3Eg/VEArSEGk9KzRZkmWHog3x
 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv
 neLld70AT1ksJWOVGmQsLyTqFuP1TM9KGYDYWoPSlID6ty6+YUr1EuQFpBkDbK/icDzFXfo2
 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk
IronPort-HdrOrdr: A9a23:tZdbLqpaqphIasjB9ksx3REaV5uhL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssSkb6Ku90KnpewK+yXcH2/hqAV7CZnivhILMFu1fBOTZslrd8kHFl9K1kJ
 0QC5SWa+eARmSS7/yKhjVQeuxIqLbozEnrv5am854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa
 vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wA+A2frfKVy1zx0eWzRAzfMJ6m
 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhuerRfb8xfT9GA+cyzpAV74RG4FqewpF491H3Wxa3u
 UkZS1QffibpUmhO11d6iGdpjUImAxel0MKj2Xoy0cL6PaJOw4SGo5Pg5lUfQDe7FdltNZg0L
 hT12bcrJZPCwjc9R6NkOQgeisa43Zcm0BS5dI7njhaS88TebVRpYsQ8AdcF4oBBjvz7MQiHP
 N1BM/R6f5KeRfCBkqp91VH0ZipRDA+Dx2GSk8Ntoic1CVXhmlwyw8dyNYElnkN+ZohQ91P5v
 jCMK5viLZSJ/VmG55VFaMEW4+6G2bNSRXDPCabJknmDrgOPzbXp5v+8NwOlZOXkVwzvegPcb
 j6ISNlXDQJCjzT4OW1rex2ziw=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83085569"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MXC1HwZlbb0htukKNOx1rt5In+5eddZUigIsEz+JkeRzbwXG8h1zQ7DI+ZLjF6v10m94mQXGEizXqL8NNUtupTOxYb7FnkscPK3VhIEJfodW6A1Sp2Jy9cBwSSL7LsiWt+Xv9+ouA3TrsSB7qW3PX3K3RqzycDrZ2/wC7pI44qYNxFUvLhbke8pPl+WP1riiHq0FD4DIL0cXPMLvl2Z4bpyy9/ClM8Agf0+dNpZoO+Y9BCB79IONEyJhFpCrm3+oeNuMJdXmtocVXQ8X/0cq/5+n60mFJzb3jzi8VShRL3CMQe/JjUXJlM03M2HfNsmErEt/V6ek6l2Rx8kWJQ4nGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XzCg1pMR0cq2iQiX6KNWMZbBy7hPZyi/638lZv3TX6Y=;
 b=PER7v8ikKMrvr1BOAo7Uh47RuN64KzzULnayJHmFtD5dzCMPogdtjQRhOypdgZdLZRCgp6gSZQhqimr/0lMOhqTNK7SdD7wY7zyHmg03mg5Tfb9SPFxEV0F7qvJ9PAwsnaNSe3KHU+HoWiIsSNYlZIntWP1ZaLxzYxjDC5LRpxS1EhdUYvQNvNgsVdCBzRc+GpnpU8lrsOz30lFgv4MXI4fM6XbzEi1zSPQUgJnolT4cf49dGPLgBdBeeZkWGLGFq6y2S9dxHWEpOEAfgugUZIgisrG/zkiyhcupHDAnIgKHy35U/1gh+XhiV6lO1RFqIB+TEv0wD2PAKo14uf4TYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XzCg1pMR0cq2iQiX6KNWMZbBy7hPZyi/638lZv3TX6Y=;
 b=PB4fpUKo3sL3ap9klgZgUl+Rkif6jTUN2VuzEk8pgnUpPehkZQASi8H+OfbciVwWb0oKq8tm0ecmynSq3Q071ulP0zg6U65XC0cRX3g953EeZTPy0oYCoZ5NTxKVZhkW89AcIFYDgtJhZ5XBsiUMFwh5QJv+do7doIkE6kGXh9Y=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH for-4.17 v2 3/5] vpci: introduce a local vpci_bar variable to modify_decoding()
Date: Tue, 25 Oct 2022 16:44:16 +0200
Message-Id: <20221025144418.66800-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221025144418.66800-1-roger.pau@citrix.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0427.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a0::31) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB6118:EE_
X-MS-Office365-Filtering-Correlation-Id: 678bf55e-af45-4dd2-3c56-08dab6977929
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LuDMlMCi9vJI9bN0Rpq/wYtD4xp0RMgI2jemhjmM/L6rxeo5Y4AHY14+s6EE0na/T7cS1ugSK6Qk4y41Tis8I0K2PNdqwSSqI+Q5ujagfFeU63hjxKBoJLfYk66mWGKNYsiGfaiYbF8cnaj+Yxf3I3O80yct+xum8I+nusQc7HDhfRNqdMdX3+BzQVIzNvIUoybrTHA2nnryjHrWVqx4p9hiRS+oFO3PfRetsnd2iw+/N3hSrrUzcbd1E0waWyt51YQG2UMvi6jK9Rs2ygsLUn7MSwWH2/yxbPibqZWHxPDt4j/2ECOL+7BA3EPScR1CE9vD33WWnQAft7Q8jxWCq11l6Eow8jI2d+bkj8zvg0vmqFWnvTMpRPlwGrV2UmyXk3wsoV/WV1ClOiTWrYamzDL1yrtnEQ61TYL3/BqBXFvXjUON4l+bU+TQUwmwI7kshKfMtLrSU+gisCnK0asmzmFhuw69DbYaQL9ZVPsNmCpUSm18yd1mAp4BjTyOeESwLrcUQP7gRvbp383wapAnnKOckh+I/ssG7l6oA4jZ5TNTk8DAPLanQeaBJ73D8Yzm+YsaJRcrACVl2wYhJFWFmHnTGFfMQPHoLZBhyiDZa5HJEKGjshPxvgLcZ6d6/pUBaPtTmx8bZNManJJoL4yQ9jXxCr+fToJo3jWboKqmnc034PQstoVCqBTIDaxHzDWnSgSj33YDqz76aoN0oJLjiA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(451199015)(36756003)(66946007)(83380400001)(316002)(4326008)(66556008)(6506007)(66476007)(8936002)(8676002)(54906003)(6666004)(6916009)(2616005)(1076003)(186003)(26005)(86362001)(6512007)(5660300002)(41300700001)(2906002)(478600001)(6486002)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YTd3OEREUVg1dFhSc3M2VHlNcHNObmZGUmQ4bWs3YitqRE1ZdUwxaDhib2dT?=
 =?utf-8?B?Nnhjb3cyVVZuOEMzTVhpVE1zcnYvRjdDdG5VMUZ4VFFldmFETnRLdFRob2ZB?=
 =?utf-8?B?V01URmpDOUJrZk1oQnd5VXlkcldqK3NwYzgzZW1GUEluTHdhL29ISWZTRFFp?=
 =?utf-8?B?T3N5dm5xVng2bFJzL3dsSzlOelR3TjMzaGdOQzlqby9xS3d1S2pYTlVxaFF2?=
 =?utf-8?B?cGxjSVNIQkdlYUpSczRFSyswais3L2xZcEdVK0l4Y0hEWVZRRkZZMXNGYkt5?=
 =?utf-8?B?dFF3T0JacUhUa1RDWU5YRkJoWENWaW9wY2V5b3lEbHBnK1JycllkUHZ6c1ha?=
 =?utf-8?B?ZW5uSzVud1ZSV2RxV2puNEdvbVhjdVhYdWxBTlhSVCsxVUduZGxGL01RSG85?=
 =?utf-8?B?eHVxSWNsMFRSRG95R01nc09NdjlvcHpob0IrRWdydko0QkFzY3B4ay8xa0RD?=
 =?utf-8?B?eDFNSVBSbVdnN2dIZFhMQ2VhNUFIRHhYTnpVY0FpUXZLekFmWElVOVc2dzl1?=
 =?utf-8?B?UGJCay9CaDlQbmNvbkJUaEFWTW5VNTN2c3QzR2kwdUhBZzc1L0dLOG1PQnNq?=
 =?utf-8?B?SVIxZWRWYWNCYURzZEF2SDJOZUdvNk9wVS91OXdsYWNmdjhXWFVhSjk5bFd6?=
 =?utf-8?B?MEkzbkRjUlcwY1NrbkJ2VkxxQVZIVjQvTHJIclRnTm1sNUVhbGRKWE9USTN3?=
 =?utf-8?B?dS96YVFqeDJZTUlpbGNYbElQam1JSkFQeVFLWkVVRmkzMVVyTE9tdlFRL1dL?=
 =?utf-8?B?RkFodjBEOUp5d3ZZbHFjdVhDOFFHVzRvOEE3ejF5ZjQyQ2gzM2tycFd3anpI?=
 =?utf-8?B?L2M3a0k5OHdxS0k5bGdVWnlOWE1LRWFKOFlRdTBOblhRVXdyOHNtZ1k3cUo4?=
 =?utf-8?B?ZVVSZFNMNFVtY0M3WVB3WTdtaDlkZHF2U1dYdWFiUTQydzBXUG5yWmI1MUsz?=
 =?utf-8?B?T0N6Q2s1UlNxbk9kYmNnYU5Wbi9EZlcvcXM5UGh5M01SZnVlNnozNytIY1oz?=
 =?utf-8?B?bkxlY1BQNlFWN0JUTnIvcXczVEY3TEVUUUZmMnNIV0hsZWhFY0ZVZXJjY1lR?=
 =?utf-8?B?VyswT2FxdkhkM09HRUY2QWQxNkQ3R3pJSXZOWUxiZXFJYW5HdHg0RmxFYWFI?=
 =?utf-8?B?TkpGdk13VytlenM5M3pKbjhrSXdsQjd6NmNZVEdPTERtUGV3ekU5ZjRGSDJF?=
 =?utf-8?B?WEE4NDA4Z1lWSVZ0WDVvUXdHQ3dxTUtXN0JFeEZ5cHFtSEhrLzBUVnlMNmNp?=
 =?utf-8?B?eXhtOENlNGl3anI2dGl0Z1dLYUJVT2I4VER2RDJJTkN4a1dQODdpNTl3bmkx?=
 =?utf-8?B?a08yQ3JRUTBIUXk2Wm5Lb1Y4WWdjRlZ4UWZhUW9Dc0I2aGFOR2RRT0F5Ni9a?=
 =?utf-8?B?b25NTEl4d2UwTUZpcW4wczZKQjhFQnhieVFQWXl0VWtHZktuUzJab3Q3anpi?=
 =?utf-8?B?Z0dUelFmMk5FOW1vS3M4OWVNNUFXM3ZoTndMa3pjbW1sQmRPYkpUbUQxZnlU?=
 =?utf-8?B?aC8vWmhhbWEyRUEwUUkzaU53c3ZPZUh5RVIrUEU0cWNTZ0EzZXJ0OHBQQi85?=
 =?utf-8?B?M3RxNFRVUzVNUFNWdytpS1Z1U1Q2L29FNVBoZktVeEEvR2FCMCtXajhNUVFY?=
 =?utf-8?B?TUpLaWpvWXY3UlZSVmJjMUdvM1ZGeFhTM2s0OW9rMzNNNUhSMkQwb3FvVjJB?=
 =?utf-8?B?bllyV09NYXV0WVdCMGVrRDcrbDhYUkUxcVdGVUVkOUtXVCtlbllUUlJGNFZr?=
 =?utf-8?B?Rk9oZkNzQ1lPV29Tbk1SVTlQRXgraXNrKzBLeGlFVytXU1A1dCtxYWcvNHN0?=
 =?utf-8?B?dkV0eVVKVEI5QURZZnVsS2xkaWgzM1dSdkZUT3BOODdScnZBUXRSRmxGZitx?=
 =?utf-8?B?WDhxd3BPQ01zRFJJTFl0ZXByeHFLZWkrd0dSUjRQcTdmZENMeXdPcXFaZFpo?=
 =?utf-8?B?NFJsUlZKUHkwN1NCZFZxNGs1bTNVb2hIRElSVEhnMFovMVlFaFRXQ0xDVFhl?=
 =?utf-8?B?ZmFQcUxWdUNtV2MwUDFTcXM0dkpRbFpGY29sSzNzOUhsWllGbGEyaGlBQnBI?=
 =?utf-8?B?dWkrRDJUZE5MSVNrNHJua0ppVU5ENkZPakNzRkxFbXY5QjFwZnZVemhVMlYx?=
 =?utf-8?B?aUV4cEROdG1yaWcvYlkvcmkydkNBcWJZUW9OYU0xTmNYemE3UGN5S1dDbXov?=
 =?utf-8?B?bHc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 678bf55e-af45-4dd2-3c56-08dab6977929
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:44:51.8377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MqasveXXwllgnazI6Mup0IB/B9Fuv0O2O11Pqz6kP6Kc2QbZlsf94zq6D8QzEOH00pLM2eHsG26pA6lDIkVPBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6118

This is done to shorten line length in the function in preparation for
adding further usages of the vpci_bar data structure.

No functional change.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/drivers/vpci/header.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index a1c928a0d2..eb9219a49a 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -103,24 +103,26 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
 
     for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
     {
-        if ( !MAPPABLE_BAR(&header->bars[i]) )
+        struct vpci_bar *bar = &header->bars[i];
+
+        if ( !MAPPABLE_BAR(bar) )
             continue;
 
-        if ( rom_only && header->bars[i].type == VPCI_BAR_ROM )
+        if ( rom_only && bar->type == VPCI_BAR_ROM )
         {
             unsigned int rom_pos = (i == PCI_HEADER_NORMAL_NR_BARS)
                                    ? PCI_ROM_ADDRESS : PCI_ROM_ADDRESS1;
-            uint32_t val = header->bars[i].addr |
+            uint32_t val = bar->addr |
                            (map ? PCI_ROM_ADDRESS_ENABLE : 0);
 
-            header->bars[i].enabled = header->rom_enabled = map;
+            bar->enabled = header->rom_enabled = map;
             pci_conf_write32(pdev->sbdf, rom_pos, val);
             return;
         }
 
         if ( !rom_only &&
-             (header->bars[i].type != VPCI_BAR_ROM || header->rom_enabled) )
-            header->bars[i].enabled = map;
+             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
+            bar->enabled = map;
     }
 
     if ( !rom_only )
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:45:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:45:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429880.681208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAt-0004eF-II; Tue, 25 Oct 2022 14:45:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429880.681208; Tue, 25 Oct 2022 14:45:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAt-0004e4-Eh; Tue, 25 Oct 2022 14:45:03 +0000
Received: by outflank-mailman (input) for mailman id 429880;
 Tue, 25 Oct 2022 14:45:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLAs-0003SJ-BF
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:45:02 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9964d07b-5473-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:45:00 +0200 (CEST)
Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:44:58 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB5808.namprd03.prod.outlook.com (2603:10b6:a03:2dd::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 14:44:56 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:44:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9964d07b-5473-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709100;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=kAAdyrIBV5b3v2jo4pvSozj+LaxTfiauFnyu5tTM1Vc=;
  b=DLqrMperFyoT35zJA53FUubjbMqiZZzbbjQuOUwWsQ4Xp1Ob2w0enkhc
   WdjdShsNKlNgm6P/172dwFVmzrpj7jcc/Lqoqg4rJ/2WjQrycM3/KdpWe
   W+MGdqS79Osglor+9J2uyoRli2eY4lL5RLXRmFzikMYGOBq8Sqr0jbLv0
   w=;
X-IronPort-RemoteIP: 104.47.66.44
X-IronPort-MID: 83892324
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:GrTWkalU8/w2SaLnMBoeeuPo5gy3J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOX2mOafvYYWDyeIx1Yd6y9kgHvpLTzNNjT1A6pHg8ESMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfGXxe1
 KRbDxU3cEqxpuuW0aijda5qv5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PkGSd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL31r6VxnmnMG4UPLS30P5hn3G2/1MsJDgtEkW1gKa61kHrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAkQzhbeZoZvck5bTUw0
 xmCmNaBLT5lvaCRSHmd3qyJtj70Mi8QRUcabDIAZRsI5Z/kuo5bs/7UZtNqEarwi8KvHzj1m
 mqOtHJm2+lVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg
 ZTOs5H2ADwmZX1VqBGwfQ==
IronPort-HdrOrdr: A9a23:ttY1oajIy5hpiP4ByAOPyAnOUnBQX0F13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hqAV7CZnichILMFu1fBOTZslnd8kHFltK1kJ
 0QCpSWa+eAcmSS8/yKhzVQeuxIqLfnzEnrv5an854Ed3AXV0gK1XYdNu/0KDwUeOEQbqBJaa
 Z0q/A30QaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGw9n8PMHyy
 zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9QwdkaWK0hIHgd
 PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgrf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L
 5X3kqC3qAnQS/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpbzPKN
 MeQv002cwmMG9zNxvizylSKZ2XLz4O9y69Mwc/Upf/6UkUoJh7p3FotvD30E1wtq7VcKM0l9
 gsAp4Y6o2mcfVmHJ6VfN1xJ/dfKla9NS4kY1jiVmjPJeUgB0/njaLRzfEc2NyKEaZ4v6fa3q
 6xG29liQ==
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83892324"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ddaiAYIhXwakw0LKgOAWdPyzFGWgZbgHtsD4Bu9Y9F74omlc6Y1+5pTFBoaC9H1x/QkebCtr2PV/Og6Rgw3lc/ubLkcDJU4zPvSGiz2NF5g/o1LsmE+NMZkCkksuf6ts7I7bGpsJDAkBbb4CR2Szut/Tsx1EogtroUI9d1yAqrl02pTv9QCPCpDhTMUBrWc+lUQcSOEcyG9z0Kmcv5B7OCAbfGr15e2W1NFwmAH4S3wKrdHtc8tptfH1ttSg9qRqh2Jsh10IV8+6AHFt/VX7RGDJV9WAJpNNHxHN5E4j1KHzcLpEiYWsTPfZqDe1rXtslVW2Ce8a/4HimzP6W5DYYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9VZPXsMkn9fam+VCRpitzkT4VDEDmOwmP7P5aKFDPN0=;
 b=nqxLUVl3imGNgKUZCMFNpumn9fQ9nTHuEcvnsvLFVdKKSxLUm0KQeMeCajqxRwW4WLzulFAl1iSt64hoeAMt+GTuRAAbtQA7p3h+uU+kmEO6pUo0T9QGpOyKL2UFe1HrUkfVWV9qI3kqzdeUu3zZyqZOaTCzcGQON/ckiyWOdmSPDP+8vvdTWet4IE/B94YvgoxFSL0Zd2U+wXPI6FS0ARiw2K1OmirUJL/Q5PtpAZAsQS95MqkFQLfa/KgAId2fProMtfdAL2PONbVD/qmxKQfsbSDpY1Vnrf3Asrqg10rBwJPYwnlLyPFKFavTVLkhjxISoOuCdjl0eT2lEADCMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9VZPXsMkn9fam+VCRpitzkT4VDEDmOwmP7P5aKFDPN0=;
 b=hoNer72MTBxE+546k55+LMnfvswn8Zv1HHQeJ/mq8ArSIl/1xiKC4u3HFFhhw/vlg59xN0wWpveLuy7iA64D8JG0gh5e0gNKtIMGOJbmzWSBRxL+z7zFl0ovA9f3X8sdcWXADK7aBEC2tmLjMIOVJtsTm7fFO0owDXlhZ9XbQ9k=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for devices
Date: Tue, 25 Oct 2022 16:44:17 +0200
Message-Id: <20221025144418.66800-5-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221025144418.66800-1-roger.pau@citrix.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0174.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:312::19) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5808:EE_
X-MS-Office365-Filtering-Correlation-Id: 21544477-07fb-4242-fe22-08dab6977bd0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aZpEGhq5xuM7SfX+0toQZIbMZjAw3nMbAzpwytrsUPe7qj1Jupibv/k3D+k31c9hPW84NizZUXmq3bC+LeRGSB+2HQh/TZpz3ICvNY/Q0AVCl5vxQ6cRPGT+0TyZkj3caSi9dOuEqe//FoVMPUCbwbddt9nt69bPyJJjs0G/5KTz0mDGsup4OxbdF5HtgWYTqINAhE8qdtRXu+fHQQj02kASQFzp+B1iK3IjAp9ae94oDFZnSm0EW0Kgwse/OGEpXNl7AA7BN6ji39mmR+wandvb/tkapVnWJravvLar5ovC5Bgl0IYbB7438GHN1vY7C7AhNE1pcTOVAD9p6CfaWWt2oZptCpkxn2/yh52G6ajZipuhfcZA5YV10aQgY3qsZ9yTCCia9gmrYlG5K7Ig+/dIbKXK+4//Cx/jWjD9eUZaMWwrZWEqoNevl0eXGqp7Q/LjanXRtMpddiQDHBB5s2Mzlua0dvAyDWepdV6sXWoK2vHMlcguYXsU+SBzKTTbjpXXoANK+reZhrx2FjQu/RGk5VjfkGxPYVE7XP1jcDx9xYna1khrsJaUY4+tAoD6WmsMQxS0MADxNvKrUxM5XvoQxEVMhWXbvNbN9iYBMPxj8g2MDNny0kbK9gFm4OJPVEsyIskL7QCc6yVyoMAtHONuAISd0HQvKP0VpNfEsJyXHZZwxAzsrWoTrG1NEYjOBA9HTwheyc3P1wXp84rUaA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(83380400001)(316002)(54906003)(6916009)(5660300002)(41300700001)(6512007)(8936002)(26005)(4326008)(66556008)(8676002)(66476007)(66946007)(86362001)(6666004)(36756003)(6506007)(2616005)(478600001)(6486002)(82960400001)(186003)(1076003)(38100700002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UE9OSnBBWSt2MWd2dkYwWU03dUpuWll3aG01anpYRzFDeCtONndUVFF3M2o0?=
 =?utf-8?B?Uyt3UXdRcjBhc3NXNm9Md1ZiNFBncVh1OGFmcTBjNkQwRFQyUzlyTVB2b1FV?=
 =?utf-8?B?YzM1czRxaUhOb2VBVmJQd25ITXJsekVxWjVPT0xzZklyT3h6c3JwRUpwcFhJ?=
 =?utf-8?B?TEZOSnVjVlRxTC9zRVUvaTR1K2oyS3JhYnZSR1BTa20wYnJMbTJpRVBib2lv?=
 =?utf-8?B?LzJqa1BoSnFvR3NiWkt5RXhNVGh3ZFl3aGtSY3JvT2tZbTRTU0JYUk1mZS9y?=
 =?utf-8?B?YVlCWkl4b1Rva0kxTTlWZFRxMExsczB4WmxIRlM1a3N6bVYwdnhpYTdpZUNs?=
 =?utf-8?B?QTEzUzNZY2pXQkRLQWdkUldBb1RPR0xCMnd2YmhiSFFwWSsxMEUrTGJMblhk?=
 =?utf-8?B?OWdhSk54VlQybXZsUDFoaHQwdDU2cGcyKzZZd1d4TlpFRFkyb2IwckRyQUtj?=
 =?utf-8?B?L3pkTS9lVkJJTGFQdDQwQURramwrM2liZkowMUVwT2JYSjhISXhBY0lYUzJ5?=
 =?utf-8?B?TDZCVTdJZllLT2dYU3g0T0FjR0NuVDJSSzFXU3MzOVFXQ1Zib3k4cFRqWExi?=
 =?utf-8?B?a3U5RXg3eVpTSUd5ZTBRYTUzMy9TVUVPbzh0bVArcThCSUh4bUdmZWxRblBn?=
 =?utf-8?B?R2srUFJJK2ZGbGYwN2RhRjY3Vy9YUmdwSm5uZFFEdnFLTWoxNGpLR3FianUy?=
 =?utf-8?B?ZXM4T01jcjRHSGpNNk1kTUVvL3RyMEZBaTJKck5GREpjblpNRGtvK0VYZ3BX?=
 =?utf-8?B?UzZBVkY1WTQwRCtZQmtiYk1GOXpmSG9JVGRuc3NyTVR6SG1GNjFuTFByVjVq?=
 =?utf-8?B?RGRIbHFoLzQ4U2VhOXdnWUFRL3RwZTdPU3BrL25UQUZhUkhMK2VCMGdLN3Fh?=
 =?utf-8?B?Ri9wdDJOQ21YUXU4WENIQjZ4cWZFN3FmdkRzdlV6THVUYW9Femd2c2crWnly?=
 =?utf-8?B?MnVVYXcxcWxGVmRQeE1IdWtJQk8xNnBmZVFTbVRPSzhmelJPTWdtU1hlRUVR?=
 =?utf-8?B?M0YrRmFjZTNPdFpHdWNwdzNGZG1aa0VhbFBaRk9kUk82dGx1QWZQeVQ1Z2t4?=
 =?utf-8?B?TVJxNEFST3lzOHdLUlhIMXgvekd5VzVENHJxOTdyNDdXRmIxS29CclNaQWY1?=
 =?utf-8?B?TE50Vnl4NGF1dzNYVkVvQlRRQXdTdHIrVmk2aTNrUjhEdlBBenV5OUpCR25L?=
 =?utf-8?B?MksxSnNyYW5pcDdLZnQ1Vk1tRDhRM0xkZGhtQzh4VHU2SVRoNnE1UjVHcU4v?=
 =?utf-8?B?Z0lFZVZ2SXZKWjBOOFZLU203VkdaZThlOHA2NHlrWEJ4Z21QcHpDK1NZVnJp?=
 =?utf-8?B?bmlpMThmejcwVGxxQTlodFNqNWVFMjArdmErbDJKM1FEaC9CbnJZRTRDZjYy?=
 =?utf-8?B?SG8zNUlzRWhiSWZOWHFVN3BXQTN5MjRXdXo5ZkpNQmxFc013TXNjTElqdkU3?=
 =?utf-8?B?enVuZlloV0YzN2VKM3hKeDBsN2NObUpOM0Y2STduUldZdHdOb2VBRjgvL25O?=
 =?utf-8?B?d3ZpSDZBRllhM0pzcGRFOGIwWmJIOFRNSlBsUzlTbDhEZ000VXQ2cWFBODRH?=
 =?utf-8?B?eVF0NXVHQSt3TWg5MmRiWE5ub0JYbUtKUU5JOE1wWGxVdTdhbzZmRWJxT2hw?=
 =?utf-8?B?KzNDQVJrWFRwSzk3akJ5Rmt0djJYZ1grVFJUK2QrRlFLd1dtWi9DS3JORzZx?=
 =?utf-8?B?V1FVcnJVV1hoTS9uMlRodEszOXVsckVDR0MyTDBsMDhsM1psRDZGQkpWd21z?=
 =?utf-8?B?ZHZhaG5uVFlxRG9YRGI1SnVHTjJEU1VkamlKdGN2OS9GM00wb1hLaytmN1Zl?=
 =?utf-8?B?amJORmlrYTduWGtjNHBaeGhPMThrekJINnBjSmdTTXg1TmVZTThYT2tRWG5s?=
 =?utf-8?B?SHdNbjFVaDBXSk0rV1FYdnczcStVOWVOY25ScHJHZVJzeFhGdllVRmgrZyta?=
 =?utf-8?B?VGRBSXpDSlZkUmxobFdJUFBVb01DalNPSFQ1OElUc2h6Q1NrUFRsbk55dExM?=
 =?utf-8?B?RjR3bmsvTC9WWVh5emNNVjM5dkdWMWM4QWZoMU5WK3hFcTgyQUFaUjlRSzNr?=
 =?utf-8?B?RjFvVGZiUVlyVnUyUEJHODFieEtsWlpaRStnNzhDRk5YdXRnQWF1Zk82YUly?=
 =?utf-8?B?M3dPcDVUNlRVdHZaMHZueXdSVUlHbUZGOHg1ZTVlQ20wUFUwOHV2TjQxbWF5?=
 =?utf-8?B?Y1E9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21544477-07fb-4242-fe22-08dab6977bd0
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:44:56.2626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kXQKxf7/VNw4V5BFWPtqP6rzxdrXdPLONEElawKQtu3Cn6ZSMxawMSpbyTgA3o/TBswShrKyZl06LgHQc87qmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5808

Commit 75cc460a1b added checks to ensure the position of the BARs from
PCI devices don't overlap with regions defined on the memory map.
When there's a collision memory decoding is left disabled for the
device, assuming that dom0 will reposition the BAR if necessary and
enable memory decoding.

While this would be the case for devices being used by dom0, devices
being used by the firmware itself that have no driver would usually be
left with memory decoding disabled by dom0 if that's the state dom0
found them in, and thus firmware trying to make use of them will not
function correctly.

The initial intent of 75cc460a1b was to prevent vPCI from creating
MMIO mappings on the dom0 p2m over regions that would otherwise
already have mappings established.  It's my view now that we likely
went too far with 75cc460a1b, and Xen disabling memory decoding of
devices (as buggy as they might be) is harmful, and reduces the set of
hardware on which Xen works.

This commits reverts most of 75cc460a1b, and instead adds checks to
vPCI in order to prevent misplaced BARs from being added to the
hardware domain p2m.  Signaling on whether BARs are mapped is tracked
in the vpci structure, so that misplaced BARs are not mapped, and thus
Xen won't attempt to unmap them when memory decoding is disabled.

This restores the behavior of Xen for PV dom0 to the state it was
previous to 75cc460a1b, while also introducing a more contained fix
for the vPCI BAR mapping issues.

Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
AT Citrix we have a system with a device with the following BARs:

BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
BAR [0, 0x1fff] -> not positioned, outside host bridge window

And memory decoding enabled by the firmware.  With the current code
(or any of the previous fix proposals), Xen would still disable memory
decoding for the device, and the system will freeze when attempting to
set EFI vars.

I'm afraid the best solution to avoid regressions caused by 75cc460a1b
is the proposal here.
---
 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 22 ++++++++++-
 2 files changed, 20 insertions(+), 71 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 149f68bb6e..b42acb8d7c 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -233,9 +233,6 @@ static void check_pdev(const struct pci_dev *pdev)
      PCI_STATUS_REC_TARGET_ABORT | PCI_STATUS_REC_MASTER_ABORT | \
      PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)
     u16 val;
-    unsigned int nbars = 0, rom_pos = 0, i;
-    static const char warn[] = XENLOG_WARNING
-        "%pp disabled: %sBAR [%#lx, %#lx] overlaps with memory map\n";
 
     if ( command_mask )
     {
@@ -254,8 +251,6 @@ static void check_pdev(const struct pci_dev *pdev)
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_BRIDGE:
-        nbars = PCI_HEADER_BRIDGE_NR_BARS;
-        rom_pos = PCI_ROM_ADDRESS1;
         if ( !bridge_ctl_mask )
             break;
         val = pci_conf_read16(pdev->sbdf, PCI_BRIDGE_CONTROL);
@@ -272,75 +267,11 @@ static void check_pdev(const struct pci_dev *pdev)
         }
         break;
 
-    case PCI_HEADER_TYPE_NORMAL:
-        nbars = PCI_HEADER_NORMAL_NR_BARS;
-        rom_pos = PCI_ROM_ADDRESS;
-        break;
-
     case PCI_HEADER_TYPE_CARDBUS:
         /* TODO */
         break;
     }
 #undef PCI_STATUS_CHECK
-
-    /* Check if BARs overlap with other memory regions. */
-    val = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
-    if ( !(val & PCI_COMMAND_MEMORY) || pdev->ignore_bars )
-        return;
-
-    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val & ~PCI_COMMAND_MEMORY);
-    for ( i = 0; i < nbars; )
-    {
-        uint64_t addr, size;
-        unsigned int reg = PCI_BASE_ADDRESS_0 + i * 4;
-        int rc = 1;
-
-        if ( (pci_conf_read32(pdev->sbdf, reg) & PCI_BASE_ADDRESS_SPACE) !=
-             PCI_BASE_ADDRESS_SPACE_MEMORY )
-            goto next;
-
-        rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size,
-                              (i == nbars - 1) ? PCI_BAR_LAST : 0);
-        if ( rc < 0 )
-            /* Unable to size, better leave memory decoding disabled. */
-            return;
-        if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr),
-                                    maddr_to_mfn(addr + size - 1)) )
-        {
-            /*
-             * Return without enabling memory decoding if BAR position is not
-             * in IO suitable memory. Let the hardware domain re-position the
-             * BAR.
-             */
-            printk(warn,
-                   &pdev->sbdf, "", PFN_DOWN(addr), PFN_DOWN(addr + size - 1));
-            return;
-        }
-
- next:
-        ASSERT(rc > 0);
-        i += rc;
-    }
-
-    if ( rom_pos &&
-         (pci_conf_read32(pdev->sbdf, rom_pos) & PCI_ROM_ADDRESS_ENABLE) )
-    {
-        uint64_t addr, size;
-        int rc = pci_size_mem_bar(pdev->sbdf, rom_pos, &addr, &size,
-                                  PCI_BAR_ROM);
-
-        if ( rc < 0 )
-            return;
-        if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr),
-                                    maddr_to_mfn(addr + size - 1)) )
-        {
-            printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr),
-                   PFN_DOWN(addr + size - 1));
-            return;
-        }
-    }
-
-    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val);
 }
 
 static void apply_quirks(struct pci_dev *pdev)
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index eb9219a49a..4d7f8f4a30 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -121,7 +121,9 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
         }
 
         if ( !rom_only &&
-             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
+             (bar->type != VPCI_BAR_ROM || header->rom_enabled) &&
+             pci_check_bar(pdev, _mfn(PFN_DOWN(bar->addr)),
+                           _mfn(PFN_DOWN(bar->addr + bar->size - 1))) )
             bar->enabled = map;
     }
 
@@ -234,9 +236,25 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 
         if ( !MAPPABLE_BAR(bar) ||
              (rom_only ? bar->type != VPCI_BAR_ROM
-                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
+                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ||
+             /* Skip BARs already in the requested state. */
+             bar->enabled == !!(cmd & PCI_COMMAND_MEMORY) )
             continue;
 
+        /*
+         * Only do BAR position checks for the hardware domain, for guests it's
+         * assumed that the hardware domain has changed the position of any
+         * problematic BARs.
+         */
+        if ( is_hardware_domain(pdev->domain) &&
+             !pci_check_bar(pdev, _mfn(start), _mfn(end)) )
+        {
+            printk(XENLOG_G_WARNING
+                   "%pp: not mapping BAR [%lx, %lx] invalid position\n",
+                   &pdev->sbdf, start, end);
+            continue;
+        }
+
         rc = rangeset_add_range(mem, start, end);
         if ( rc )
         {
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:45:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:45:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429881.681219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAy-00055u-U8; Tue, 25 Oct 2022 14:45:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429881.681219; Tue, 25 Oct 2022 14:45:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLAy-00055M-Q3; Tue, 25 Oct 2022 14:45:08 +0000
Received: by outflank-mailman (input) for mailman id 429881;
 Tue, 25 Oct 2022 14:45:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLAx-0004yW-8q
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:45:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9c669ac6-5473-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 16:45:05 +0200 (CEST)
Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:45:03 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB5808.namprd03.prod.outlook.com (2603:10b6:a03:2dd::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 14:45:01 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:45:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c669ac6-5473-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709105;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=XRI3mzs1B0cmEFtJwKBPVRLdZTaKuGUCgVHbs3Soa7U=;
  b=EM0xehqGjqvbqGd3haR3mn1TOOPUQWNC1aZr6UkT0/Al1qAtw5jsjhCy
   3rgZZp58EyFnhMLIekOtZSt9bHBsV4l21SSkQhJ4x/YX6sifPyUozVfX1
   Alp7LF/enlWPuiIdMJ89GOcld+9grf7ypTA6WPPhvoVJlEkp8KQYM/DQw
   w=;
X-IronPort-RemoteIP: 104.47.58.107
X-IronPort-MID: 82566550
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:3M4ubaDMYicRkBVW/z/iw5YqxClBgxIJ4kV8jS/XYbTApGl00mdRy
 GAbWzyHb/+DMWfycoona4yzphwPuJ7UnIVmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV
 ena+qUzA3f4nW8pWo4ow/jb8kk25K6v4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W
 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk
 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2ltA7wEpcVXJ1pJ9
 OUZA2gzdB/A3ryPlefTpulE3qzPLeHNFaZG4jRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY
 MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvN+sLb4ECKpOB1+KLqP9fPPMSDWO1en1qCp
 3KA9GP8av0fHIzFlGTbry/07gPJtQ2mYKsdG4+Hysdnw2ON5H4oJh8PS1Tu9JFVjWb7AbqzM
 Xc86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooL07gCDFy47RzhOQNU8sYk9QjlC6
 7OSt9bgBDgqvLjLT3uYr++QtWnrYXdTKnIebygZSwdD+8PkvIw4khPISJBkDbKxidr2Xzr3x
 lhmsRQDulnatuZTv43TwLwNq2jESkThJuLt2jjqYw==
IronPort-HdrOrdr: A9a23:MqZOMa29Kg6sIWeKguO/OAqjBSlyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjjfZq6z+8O3WBxB8bYYOCCggeVxe5ZnO/fKlHbexEWs9QtrJ
 uIEJIOd+EYc2IK6voSiTPQe7hA/DDEytHRuQ639QYQcegAUdAE0+4WMHf5LqUgLzM2eKbRWa
 DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REoGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUMTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt
 WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJvXfwivZv3Evoz6hNO6Ws19
 60TJiAq4s+P/P+FZgNYtvpYfHHflAlEii8R166EBDAKJwtHU7rhtre3IgVjdvaC6DgiqFC06
 j8bA==
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="82566550"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ELLtw+na07llVQnb4nJkroVA71UKIZDDO+cBTjhbp0MtsRSMFo/FGhm+tDFtRw4S26a/Ge8gATBhGzTNICaCi5hLpTkavGrAnlTyKNuc9uCzEEOogTJWHTGcf1dyy9/Qy5bKyQ3oqUmmk36jhKBYs9OAtYvR+KHZSRXoA/yjdapfN6+oeGxMyBHP1jO92Df1LAxdvsgiKvjERiGg2TOlhEso4/zOI5rgOhoEhHN+VBxfck3Nm15di5EybkOCjIzZLyw7BzylMOAF0Tndp30quiKcQLMSLqla/Lz4HMm+Ve9SWNyCFYcxeQWkOYUvbayIIdEuHb2twHJC980oe51Klw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ni/1RlXrdeaGMkzCL+CI7189B9RbrNPyY4w069aWnxk=;
 b=VvoPitA9rmo13uc7WoZFrvPvMSvHWbS6AbeNZqDTpDAIVPDuMHFqqrNR8FsdGEANixv1WjIMSMhPC6BquiYIwh/p2UV6PO/zEAjTfhFfHk2sGFrj+txcZQ7818/UnG5G220fi9vNfWfHz9cIsNzulBeWIEHTPoL2QGeDO35NCvu11DOm1awAZY4oIM/TsD9LOcqlXDLa0PzUMpOAb9NkDdasbbjKVRjGosERb86nssYtC0R63PF8o+HCarEvo2llCp2vky0NM6ELUCTTC3Qc1k0My15XHVc/KEVtlNcETfRZ6odm/UgbPT8Ws74BGcHRWbiBFVOloWO29pdKKZffBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ni/1RlXrdeaGMkzCL+CI7189B9RbrNPyY4w069aWnxk=;
 b=CJTG2obLQsBpThHFipsusmFksY2bADfO5b/AUkSoWC2l5pFtYlw58spK0b1TrCzPbRnvZ8VFVlZSGfji/1EWQZVEdtNvlTbFJqyck7Bjzb9P2P30d+qpw7kWq/e7zswPtM/dQkjCS5H6S/FqbR6YrzasrhxWRN48BfW1iAIkA20=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR is mapped
Date: Tue, 25 Oct 2022 16:44:18 +0200
Message-Id: <20221025144418.66800-6-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221025144418.66800-1-roger.pau@citrix.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0568.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:276::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB5808:EE_
X-MS-Office365-Filtering-Correlation-Id: 52e45150-27d1-49ff-d095-08dab6977ec5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4gg6rX80hMu6WjtWG/gThsz47QgWVQ60DUalK2JpM6DykUZExCQAvwXTEPO5Lu3WOQXgwuJ9yrZ6LiXNgboXBykGoqrwCs+2TVgUdwGaDaH92zjNvRPcSj4OaSWSiEN9asP7aI60KNOv4usGY9GiFp/veMwdvylk0eQ6CgCqOh5XeQUuDJ7cTL4LHbHkLcOLrnRSAp/BrXBzQ/WqRtwynm6c/912xzn7yXV4M/cxY4q2NmRB+08wri177daC8S8TRcauV3B477NM+M+3e4hGgVdpgAsf0j3SHDIRvpCUnVeShSBALieUZPUdKXJ++SNXqv/0WjzGp7mcd/yt/D4XoUaw8odZvmsKWpj1Pie1Jf/tUjCv7zN6NWILsXJcbqzR+ZqFTCRJas8iphHU6ryuLgaUP2NtiKFGMsaYM75ePx2Ul1GuFdieFQFI/jfmyIB603Hy2MtNXmnalGyGDeTVqlq4JnzLP4q0U77stQjPaRyxunkwAn0VdA+CmTpfeWgnsLpQVq8toAkH+FbW61R3xZdxComNEfrbfhZywmlAfZxBxkSxkYc7GatWVV9DKy+iWsQVM1qhy9axHxD950rzEtNYmPzLn2i8+NxLSTnyDPnysMZzeEJ+Vxyx4UdiapwSgLM5VN6GRD7EP+hSn38zJ5pewqKKAfuP8/mu5bCibYXFiJqgkJQtwB6/nF/xXBBKNtk0G7NlWobXbdfSN2RUSQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199015)(83380400001)(316002)(6916009)(5660300002)(41300700001)(6512007)(8936002)(26005)(4326008)(66556008)(8676002)(66476007)(66946007)(86362001)(107886003)(6666004)(36756003)(6506007)(2616005)(478600001)(6486002)(82960400001)(186003)(1076003)(38100700002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UWx6NVRPS1JleThGNnBMbGRxY0FrSkdBK3M2R3U4UW1XRmRxcENBTm1VaVg4?=
 =?utf-8?B?aEFSN0lzcitxaGNnM3dCNCtnVHFzU3MxdWhGelh6UGx5VElRUXRKeEU3Q1Ev?=
 =?utf-8?B?YlV3RWFqOHRnSUJ6alUvK09mNzY4VVdGcWFIYzJtcVpudzl6YXluZDd3YWFU?=
 =?utf-8?B?YlphaEdZWDcwYk8vUlBNUjFjTGJLQW53NzZ4MFZoR0djNG1LNUMwM0xMd251?=
 =?utf-8?B?RnVyUWhVMnNSZ2FxTDRFV2lBU25tUEFSeG9TQnpjK0hFc1FNMU13eXorSmEr?=
 =?utf-8?B?aEkwNkJjNjRKSHhmYmwwZGlVOFhBOE5kNHRHV1pOZ2V6eHdLcmR6bnZSWGFC?=
 =?utf-8?B?ekVkOG5ZQy84WW9jeGhaRVh4Y1kxYWxYREE4QS9uTUlVMk9uamFWUFREdW5G?=
 =?utf-8?B?RjZOZFhyaG83SS9FVW1Ma3g4ZU9PWG1oQ1pFTUN4Sm83WVZNZGRFQlI1UVBN?=
 =?utf-8?B?b1J3UFJOdTIvWDJUaW14TWVjNmNmSTgwTkpYRnd0K3NCTmhyRFpLdUFGc1Iv?=
 =?utf-8?B?b0tNc3RtWjBwd3hqRFlFWUhJQk5aSVVwN0c2SVFUSHo1WndoS1VJK1VxaHhi?=
 =?utf-8?B?ZVh4MitIc1p2Y2RFSGVqT2lUbFR6Z085TllsRG95L0VXdm8zSHRpUERTckdR?=
 =?utf-8?B?MCtPTnNkL1B1SVBDZUJXK1VZc0xuUlZqQWZBM3NmeG92TGZQckIwMnIyeFBw?=
 =?utf-8?B?dnZqaGJsYWlQenRMK1JuMStxZ2JkUFdBRnc0b0dnYmU1cEtkZVdRQUdLWEcy?=
 =?utf-8?B?VDc4dzdWTHU2SkF0YlNhZ3JBSk9BQjFOUkVaWTJEeGJBM1IzbXRTM2JaZkM4?=
 =?utf-8?B?UXZESzQrMUJkMzFUVUR3d0RoMSsrQ283c2VLb2x1cTNkZ2x3SVAyTVJsRVBi?=
 =?utf-8?B?Z1dvRDB6VDB0cXdVUG9GUVNxeU5kOFdhT1BqeW9BYjlVOFRLN3BENmg3YWlj?=
 =?utf-8?B?ZGxoZkdDOURaUWk1c1l5T3VCNVRRODZPdWFpMGUwT09Dd09YK1RVRjlwNjRZ?=
 =?utf-8?B?a0o2QVo2U2JYT2ZJTHRTQWZSSzhocTNuNnFpN2hzcS9lZXZaMGVleE1rU0pm?=
 =?utf-8?B?Y1VISXo1L2lHWnFHTmlGSEpkWGVXVm9CWTFpb1dPSFVwQmtYL2kzcjU3Uks5?=
 =?utf-8?B?VW5kY0JPVnp0OVlSL0lKTSsvdFRBQkg5enRFRGhpZUxPdlZ6ZTdYLy9GZ28r?=
 =?utf-8?B?TXFBckFsQTluQnJPVDgwMDhvMDVCYjlhN2ZmTjY1NjRPQWZBcHA0ZTdXc2du?=
 =?utf-8?B?ZVNaWWhLcHBXV3hZcmlWdjdyOGJCeDZBakp3UzJHSlpmVVdOa3REQkFURVNO?=
 =?utf-8?B?WnhmK2tSKzlTeEFINzU2RGdtekxScVdEdzBUOGVpbGVhZzlXUEQxMU96clpR?=
 =?utf-8?B?L3RuS0Jaa3Z4RXVFd2YrRkdtYVplZFM4YW9PYnNVUDFUMHVSNFRKeUdTd2xi?=
 =?utf-8?B?SFdwbWp5N0Y4WmR1MG42eVorblc3bmJhZXJkaXBZakJLTmlIZGErMko5RWlM?=
 =?utf-8?B?bjZOZzBVVjgwYnhFa0xQcFpSZnJ4Y3ZPalU0RVEvNkRTYmt2anI0cE01a2pK?=
 =?utf-8?B?VU84UGszZ1RDdFRSTFprZ2Jwa2ROSDFrOW1lQlptaVY2RlpRS1V5Z3IwNjZq?=
 =?utf-8?B?S2UvKytuUmpueWZWYVRSaE50d0g3SnhFT2RHNVo5TCt2M0xxYXg0NzVDaWJi?=
 =?utf-8?B?Yi8vSDlXQWxwQmxEMW9DYzNaL2pWdHlyczJ2alQ4enc3WVhjL05ZS3BwTHZQ?=
 =?utf-8?B?cmpydFAzOHgvRlhyWmZxS3hPR1pYcW51Sm93cXFINmpjaUJTMk4xWGRyVWlE?=
 =?utf-8?B?NDhxcllnTUw3eTdlV1RXRzc2a0xiS1RhaHJvQVRBRU5hVUdwdm5RNzlWWXY4?=
 =?utf-8?B?cjZZL0dQY2cvSG9ZUElza2p5NEc3WCtLTng1Mk5lR1BkamVBdk42OEVjY3pU?=
 =?utf-8?B?YjRiMy9qQk1odVdsNEtEUndEenlRbHk4UFd1TGh6bzB5RWZrSFE4bmJrTzlI?=
 =?utf-8?B?LzFxczllNWo1ZEhub3JBSVh1SklKTmJNWkg4bWdLT0hXbm9JbXRlc0NJcFVi?=
 =?utf-8?B?YzRMTnE1WTAvYjgyc1NMTGo2Yko0TnNpamlKcXBxeWY5MWtic3BnK3RtdVlR?=
 =?utf-8?B?ZEZNc1MybUdOSHVOME96WDkwbHl6ZXB6Y0dkREJ3blpvNnJKMVZGWFNDV0Fy?=
 =?utf-8?B?VkE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52e45150-27d1-49ff-d095-08dab6977ec5
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:45:01.2524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: inIno9macsuacieyc2E06qK6/4MhRwFXRusPqLZj64olJSk7RBABwmQgYCqLV5hf66tJUDyfLTRvMsJZgl1wgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5808

Writes to the BARs are ignored if memory decoding is enabled for the
device, and the same happen with ROM BARs if the write is an attempt
to change the position of the BAR without disabling it first.

The reason of ignoring such writes is a limitation in Xen, as it would
need to unmap the BAR, change the address, and remap the BAR at the
new position, which the current logic doesn't support.

Some devices however seem to (wrongly) have the memory decoding bit
hardcoded to enabled, and attempts to disable it don't get reflected
on the command register.

This causes issues for well behaved guests that disable memory
decoding and then try to size the BARs, as vPCI will think memory
decoding is still enabled and ignore the write.

Since vPCI doesn't explicitly care about whether the memory decoding
bit is disabled as long as the BAR is not mapped in the guest p2m use
the information in the vpci_bar to check whether the BAR is mapped,
and refuse writes only based on that information.  This workarounds
the issue, and allows guests to size and reposition the BARs properly.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Cache setting of memory decoding in command register.
 - Reword some log messages.
---
 xen/drivers/vpci/header.c | 18 ++++++++++--------
 xen/include/xen/vpci.h    |  6 ++++++
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index 4d7f8f4a30..ecd95059b2 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -128,7 +128,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
     }
 
     if ( !rom_only )
+    {
         pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
+        header->bars_mapped = map;
+    }
     else
         ASSERT_UNREACHABLE();
 }
@@ -355,13 +358,13 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 static void cf_check cmd_write(
     const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data)
 {
-    uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
+    struct vpci_header *header = data;
 
     /*
      * Let Dom0 play with all the bits directly except for the memory
      * decoding one.
      */
-    if ( (cmd ^ current_cmd) & PCI_COMMAND_MEMORY )
+    if ( header->bars_mapped != !!(cmd & PCI_COMMAND_MEMORY) )
         /*
          * Ignore the error. No memory has been added or removed from the p2m
          * (because the actual p2m changes are deferred in defer_map) and the
@@ -388,12 +391,12 @@ static void cf_check bar_write(
     else
         val &= PCI_BASE_ADDRESS_MEM_MASK;
 
-    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
+    if ( bar->enabled )
     {
         /* If the value written is the current one avoid printing a warning. */
         if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
             gprintk(XENLOG_WARNING,
-                    "%pp: ignored BAR %zu write with memory decoding enabled\n",
+                    "%pp: ignored BAR %zu write while mapped\n",
                     &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
         return;
     }
@@ -422,13 +425,12 @@ static void cf_check rom_write(
 {
     struct vpci_header *header = &pdev->vpci->header;
     struct vpci_bar *rom = data;
-    uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
     bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
 
-    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
+    if ( header->bars_mapped && header->rom_enabled && new_enabled )
     {
         gprintk(XENLOG_WARNING,
-                "%pp: ignored ROM BAR write with memory decoding enabled\n",
+                "%pp: ignored ROM BAR write while mapped\n",
                 &pdev->sbdf);
         return;
     }
@@ -440,7 +442,7 @@ static void cf_check rom_write(
          */
         rom->addr = val & PCI_ROM_ADDRESS_MASK;
 
-    if ( !(cmd & PCI_COMMAND_MEMORY) || header->rom_enabled == new_enabled )
+    if ( !header->bars_mapped || header->rom_enabled == new_enabled )
     {
         /* Just update the ROM BAR field. */
         header->rom_enabled = new_enabled;
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 67c9a0c631..d8acfeba8a 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -88,6 +88,12 @@ struct vpci {
          * is mapped into guest p2m) if there's a ROM BAR on the device.
          */
         bool rom_enabled      : 1;
+        /*
+         * Cache whether memory decoding is enabled from our PoV.
+         * Some devices have a sticky memory decoding so that can't be relied
+         * upon to know whether BARs are mapped into the guest p2m.
+         */
+        bool bars_mapped      : 1;
         /* FIXME: currently there's no support for SR-IOV. */
     } header;
 
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:58:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:58:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429905.681229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLNV-0008Hl-98; Tue, 25 Oct 2022 14:58:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429905.681229; Tue, 25 Oct 2022 14:58:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLNV-0008He-5y; Tue, 25 Oct 2022 14:58:05 +0000
Received: by outflank-mailman (input) for mailman id 429905;
 Tue, 25 Oct 2022 14:58:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OByo=22=citrix.com=prvs=29082ff5b=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1onLNU-0008HY-2F
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:58:04 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b56b4a6-5475-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:58:02 +0200 (CEST)
Received: from mail-bn1nam07lp2042.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 10:57:59 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5183.namprd03.prod.outlook.com (2603:10b6:208:19e::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 14:57:57 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 14:57:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b56b4a6-5475-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666709882;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=xTpdg1PTu3TZ6wvysef5LNvFfeZKWgF4fzcJczYzVY0=;
  b=Fu8dtWFhUi2einJ8vHYxfkDlIazjspULuKS4psbiSIu5/kaNX5MrRi+F
   DrcUGTX7J9xT7woru6T0VhBl/v09UJTNAjyC7SyP34B1PYwykJGPoxz9r
   WReGMBHpKJDUbxn8yQe2RvqPUYF/0Ro8Ko5ue2hNqeiXWKs0lJfJ21G+N
   I=;
X-IronPort-RemoteIP: 104.47.51.42
X-IronPort-MID: 83893560
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:0yAjK6owfKyBdReoPnHI6CjHkd9eBmIlZBIvgKrLsJaIsI4StFCzt
 garIBmPPf3cNGHyL9skaI/g90xUuMPWnNUyHABl/3g2EH9H9ZuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5
 NgIMA0/Xgq6l8Wk2L7rE7JR3PQIM5y+VG8fkikIITDxK98DGcqGaYOToNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OlUotitABM/KMEjCObexTklyVu
 STt+GPhDwtBHNee1SCE4jSngeqncSbTCNlCReblqKYCbFu72kwhBTBRcAeBvqOJtkGcYYIOO
 1AF9X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k
 GCAmdzBDCZq9raSTBq19L2ZsDezMig9NnIZaGkPSg5ty8HqvYUbnh/JCNF5H8aIYsbdHDjxx
 3WAqnE4jrBL0soTjf3npxbAni6moYXPQkgt/ALLU2m57wR/Iom4e4iv7lud5vFFRGqEcmS8U
 LE/s5D2xIgz4VulzkRhnM1l8GmV2su4
IronPort-HdrOrdr: A9a23:4J+okangSa2vRTd8guAk0QIgNKnpDfOPimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee
 r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+
 uzUagmccPeEQ==
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83893560"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NYu3DWEWKF/+7wUzLbLwL1byK16Q42IPzzD0JT6HLBbz3+0zGJVnFKJDdgfhc1I727b7TNL/E/vbMswhS2vsuptpEmqzPFghlecjj+u/SMXdmjsuFxEba9KemZ3t5wYF1xJVHJrMcvDfGVDJFjP4V7+ygXPBxJhetOK5ELBw3D8axjn3oUhWqT+18jKdV+1kAHSeiy9mw8acAX4b6EJWX4UezHbZ7Rg8Dy5yQCE/BHnvCRz+5vYNqgUV2i+f1bMRC/Vs736HGSqGQyYY/wFPiXg+Jj43GjrQts5S5hF8kwv/bOLHFtsQKfy6qbwpqu3eqvxBWW3ThJbSFra3Zorr7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xTpdg1PTu3TZ6wvysef5LNvFfeZKWgF4fzcJczYzVY0=;
 b=iB0hzssKvwtqdEWo4+hHxAaCS6Qb8nEuTvCt17UpkPjzlb2GCby8LekpzFj+w6F9EZbHl0uMXy9cHRuocc81Q99I2CUpVnsPs/Zdvngc0C0umKQ01tXhKc9aeC19BSob+ox0Hf5ZxzIo8DVHEESM2TXDRA2OOddM59UCMyCzD5GdBX5l9cXGJimIj2rd8uAjoYIwnWXbCtLrcSZ49YYuE+zeVaVttIeipoWHsIJ2AdRrT0iB8oZ12CFs24YRPPL3YPxkHhXiSlVgoxAx/esez9jpKPMDWA/0vFaefkI+ZQPj2p/kE+K3nTIMTb+U7P08YavCuZ26K0/qLQeDqzS2tQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xTpdg1PTu3TZ6wvysef5LNvFfeZKWgF4fzcJczYzVY0=;
 b=r3g52t8erLHByaj0zcAlvJzXr5IeBE/nvaDo8DTAuZ+kOmj9QsOO5dDu84hbSsREK/CO6Xz3HtK9A2WyAbzNk4VNSLk6awpeUh6LX6Ecpcc4JBMqg7XhVyzNJE2JvzVlHpkz/4YODf12o9vTqkjVsxcLbdXQS3fLm8GNKgoyV9Q=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Henry.Wang@arm.com" <Henry.Wang@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for
 devices
Thread-Topic: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for
 devices
Thread-Index: AQHY6IB1GZlo2uEODk66SxzrKqAIQ64fM1MA
Date: Tue, 25 Oct 2022 14:57:57 +0000
Message-ID: <46a361ba-121e-a054-da59-512e0fb6eb70@citrix.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-5-roger.pau@citrix.com>
In-Reply-To: <20221025144418.66800-5-roger.pau@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5183:EE_
x-ms-office365-filtering-correlation-id: f7d219e9-d5e8-4b07-2380-08dab6994d88
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 K+S+eEzxALNJqowbo8ymPsaUOkAR7EPdTyDXcu9D1MdpXg+7v5MN8G+5bYmuyZylBANWi2b8Uq0o7Zm2JvzTgQbl/aI7/vtzxLMKmyS5+HvY691OXSMBm0Ix6lZVbcJDJfc16J8gGRwGV6yyux+pm1Vst5wjZVI8dMHlGHj+hLAXsNHzmAEV0TgO3auFmN1Vc3BzarGq0imqP92Pib6JtMVWCDxE2+B7zMYkNjg4w5WsGoPIELNc0c6O5pDlZl85mf081WDYiA0YiVs+XOkWRUJtTjl1bik9hMYIeWaZZ5ewytq4Ufr3Ce5+UXJKB3ZptKx8I7nkFtW259hmXTXhgr2Xt6ZtoDsBEFPGMvvYl6HQpWSRCwfz3FDgHcLYbX+f/rGDcJaxq0Hpdq65F1jP4NTiPnLXxT9JxiOovxV5PpI3wyg4f+HhKHW+cRVFXspZeQO1tR0lPc5klTtIGQNlnYzZDB9QpUPWlJ1lVrHwaH/qAypqyRg4OOO+AbCdO2GZBBffn9JPPZDF/ajtdJCGOz8FFe10Zv8wOGzbBWvmp9XhVxbYO3cGTucfxxXsPmWQ/xK+nlMi/YQZYn5zaP8WOqaX48qU1drY027mb1WfdISWjgklotZ03NcnKWSkN86j13i22xgNrbCvMw6kBPcwet0cXaKWOU/3nnnOECcuscp5C0IfUf4dbgL351rmGQFo5vrL3igrIgkJtAFB5Ja12LPwz1ezv1uSUqF7OsIm7bG0IUpy5QeWwLR7x/iKGnQ6bHISEz8rFBdly9qnKIFyYn54IUenhwLK1LbqQLpwUNdnQw2f9BLw6xTGHoZEk/8kcTB36uBj0FwmbzRcyWbzzg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199015)(36756003)(31686004)(86362001)(31696002)(122000001)(2906002)(2616005)(38100700002)(186003)(82960400001)(38070700005)(83380400001)(6506007)(53546011)(76116006)(66946007)(91956017)(4326008)(6486002)(6512007)(316002)(110136005)(54906003)(71200400001)(64756008)(8676002)(66446008)(66556008)(5660300002)(66476007)(41300700001)(8936002)(26005)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?RVBINHB1WjJpSFMvazBiWGthM2QzQytESldCZnR3NGdJbU5hNWJTa1BDNmQz?=
 =?utf-8?B?Y0V3YkN3NkJEeE0yaXJQNHVTVnNvMFduRlZ6cmR0RjZieTR3bFBKbkdsalNL?=
 =?utf-8?B?alJaWEJnN2QvQ09YN0JvTHFDaEhPNVlQS0V2MEJ2QWp4SHZtbEVGYTlwVjFC?=
 =?utf-8?B?THVvayt3cHpLOHk2alR6cnhsWUVyT1Nya3h0OEVHak5IdUIwUVZrQjhhMGNK?=
 =?utf-8?B?THdtREFIYnlqMkQ0bDlKL1BPaGE2ZE0yUm9hNXQxa1FtTjJ5bWJGenZFay9B?=
 =?utf-8?B?SHFSZTdMTGp6U1ErTEN3eWIxejBDZGhzMTlPdWFReHIzOGZJYlU2N0J4Yyto?=
 =?utf-8?B?VzRDSFF0Y25lY1NucUtRVW1WQ1JqMkZWdVgyTzhDaHBvcWFWVzRRdlR0a2Zr?=
 =?utf-8?B?VVBub1Z6OUhlcVJvU3c2dFlObW55RWsxQ3VNcVlvU2t3bmQzVFJuQWwvZHlu?=
 =?utf-8?B?M2pGdnp2VitvVHpLSFNzVjZ4UmE3bFJDUkxGZlFiODhzem9zbjBQTEUvekov?=
 =?utf-8?B?L1JZMXJwZ3RmYjY2azljK1lpR1FCMmgzbjR0OTF6WnhuYUdTeW1helhyUjhB?=
 =?utf-8?B?d21VT0hzMFVqV1Q2THBuNlQ2Q240Wk9xWEJlc0JYdTJOYzBXREFTSzcvaGRu?=
 =?utf-8?B?SzRYQXZsQm9UajZaR0VpWmNjQmRPMlEwVHlOVFRFcS9nUGN5MDZRdDZGbHVI?=
 =?utf-8?B?RTBjRDloUHltSXdDM3I2bVZlRWUzN1BKc3VVSTQ0NFpJaWZqOHhaQUN0cEdT?=
 =?utf-8?B?VWQ4SVNBbmhvSDIvUVoyTzFTY3BzNDRpMFAxcWlyMlNGdCtsQ243NmJDZTF1?=
 =?utf-8?B?N0hVK0VJTG1neGxJYmg4cXB6dWZiSHFSMmRuVGl1algzZXRlSmp6aXFDZHgr?=
 =?utf-8?B?eTdHbDloQ1FIdE9rVHhXeEo1MDdzLy9jSGlWbzEvN2tkNTZUWk5wRDBOVS9X?=
 =?utf-8?B?cnJuMnUxcmxBTS9lTGV4VU96aEdjQ3BUbmluYVFJUzJRRXJDUzNRYUNXZEkr?=
 =?utf-8?B?L2k0ZWJpQWd2R1JYVzJZbURaeVc2eC9sL2ZqbVpEUC8vUHY5bHI1RnQ2eW1X?=
 =?utf-8?B?OVJHWmZkMHI3d2trcW8xNHNPb2puOVdjVHdGUi9SYmJySXh0UUo2RWQveHRi?=
 =?utf-8?B?b05JT2dtRWtnWElsOGVCU1htMnVxQTRrZll0V1F1ZmVWUU1uQmF1N1ZWY2V3?=
 =?utf-8?B?OThMOUg1SU11eTNTaWE1U0MrS1lZc3FTUW1lY1VRNFZyVit1eS9DL3c5cWE5?=
 =?utf-8?B?Y21qNktoSkZFUWhMdldZbytXUEM4YTdRNm85azdBcTh3RmlpenVTcFc4Vlg1?=
 =?utf-8?B?N2dMLysyeXlGbEFHeVRCdm4xeXd2LzVBWUhlOTRVQ0Vvd2JDUlI3bmdTZ2dI?=
 =?utf-8?B?ZFBhWDZyVm1vYWVOb0FXSU4xckxZNDdRT2hwNjVsSU9tUE5ieisyZk1aR3lZ?=
 =?utf-8?B?TzU2K2hSNmlUTlF0T3dOVGhYME95Zm9QZlFqUzZRdjVmRjk1TmxPclVEMXZE?=
 =?utf-8?B?V2xucW9pV1BTQmtzckliUXJVQTBXZ084NnE1VnhyMnlWZkFhMFZweTh5R1dr?=
 =?utf-8?B?UUpWMDJ4NGtzQlJyYnRxblY0SG50aXdJQ2RJZ0ZzTkxPK2lTMjNrMm9USkZE?=
 =?utf-8?B?c2k3SXFaSi9Vc1JVOXBSMHgwOGM1MlFCTFBaLzN3UFRsVnJKVnQ2eDl2NXVk?=
 =?utf-8?B?L1ZVcHoxU2t1VzVvVFZsRkNLbWIxcHpuZDRmYkc4MmZtUjczbTY3Nlhpb3lT?=
 =?utf-8?B?bFJIdlhydnRZcW1sdjdXbFBYNXYxZ1dEcisvT3ZraFM3RWdJOVJVWTVtU2g0?=
 =?utf-8?B?K21SQWtSMWQvbFZwUDY5ZXkwTU1ydmNFanBkYVc3RDB1OUJGRkZKNlRuTHJw?=
 =?utf-8?B?Vi81ZW94K0tLR3pEY1k0Sk9GMXROU01sSU9pSmZNVHArUUNLWGdzekFJeWhi?=
 =?utf-8?B?Y1A2Q0ZQRXA5ZVRReHlIQXpjem1KdmZmQ3VuUlhDNXk0YUM5NVc0WkEvTnlW?=
 =?utf-8?B?QnhZSFJkZ0hvOWhxOHlwMXBwa25wdXVQbmpLVVVjME4zZU9LendTZE1XbUN3?=
 =?utf-8?B?UURFMVJ1UDVkVzB6NEtZdFpzRGtPMU1razdCK3lOdThSUnJSaHhCd2lnQkFM?=
 =?utf-8?Q?/P+WCa12yRvshde9dHsXvOO13?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AF8EE6F8DF7F96489A4CF64EC4D8058A@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7d219e9-d5e8-4b07-2380-08dab6994d88
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 14:57:57.2896
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xH6HQczJacZspfKQvPlsGmrQDNLWfBUCrDQa2f2z1twm5r97FPqOgreaNa4ULZiM1VO5dTsXamqIJSgw5ydWegu1Ayb6LmXRTBKn62P0RIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5183

T24gMjUvMTAvMjAyMiAxNTo0NCwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiBDb21taXQgNzVj
YzQ2MGExYiBhZGRlZCBjaGVja3MgdG8gZW5zdXJlIHRoZSBwb3NpdGlvbiBvZiB0aGUgQkFScyBm
cm9tDQo+IFBDSSBkZXZpY2VzIGRvbid0IG92ZXJsYXAgd2l0aCByZWdpb25zIGRlZmluZWQgb24g
dGhlIG1lbW9yeSBtYXAuDQo+IFdoZW4gdGhlcmUncyBhIGNvbGxpc2lvbiBtZW1vcnkgZGVjb2Rp
bmcgaXMgbGVmdCBkaXNhYmxlZCBmb3IgdGhlDQo+IGRldmljZSwgYXNzdW1pbmcgdGhhdCBkb20w
IHdpbGwgcmVwb3NpdGlvbiB0aGUgQkFSIGlmIG5lY2Vzc2FyeSBhbmQNCj4gZW5hYmxlIG1lbW9y
eSBkZWNvZGluZy4NCj4NCj4gV2hpbGUgdGhpcyB3b3VsZCBiZSB0aGUgY2FzZSBmb3IgZGV2aWNl
cyBiZWluZyB1c2VkIGJ5IGRvbTAsIGRldmljZXMNCj4gYmVpbmcgdXNlZCBieSB0aGUgZmlybXdh
cmUgaXRzZWxmIHRoYXQgaGF2ZSBubyBkcml2ZXIgd291bGQgdXN1YWxseSBiZQ0KPiBsZWZ0IHdp
dGggbWVtb3J5IGRlY29kaW5nIGRpc2FibGVkIGJ5IGRvbTAgaWYgdGhhdCdzIHRoZSBzdGF0ZSBk
b20wDQo+IGZvdW5kIHRoZW0gaW4sIGFuZCB0aHVzIGZpcm13YXJlIHRyeWluZyB0byBtYWtlIHVz
ZSBvZiB0aGVtIHdpbGwgbm90DQo+IGZ1bmN0aW9uIGNvcnJlY3RseS4NCj4NCj4gVGhlIGluaXRp
YWwgaW50ZW50IG9mIDc1Y2M0NjBhMWIgd2FzIHRvIHByZXZlbnQgdlBDSSBmcm9tIGNyZWF0aW5n
DQo+IE1NSU8gbWFwcGluZ3Mgb24gdGhlIGRvbTAgcDJtIG92ZXIgcmVnaW9ucyB0aGF0IHdvdWxk
IG90aGVyd2lzZQ0KPiBhbHJlYWR5IGhhdmUgbWFwcGluZ3MgZXN0YWJsaXNoZWQuICBJdCdzIG15
IHZpZXcgbm93IHRoYXQgd2UgbGlrZWx5DQo+IHdlbnQgdG9vIGZhciB3aXRoIDc1Y2M0NjBhMWIs
IGFuZCBYZW4gZGlzYWJsaW5nIG1lbW9yeSBkZWNvZGluZyBvZg0KPiBkZXZpY2VzIChhcyBidWdn
eSBhcyB0aGV5IG1pZ2h0IGJlKSBpcyBoYXJtZnVsLCBhbmQgcmVkdWNlcyB0aGUgc2V0IG9mDQo+
IGhhcmR3YXJlIG9uIHdoaWNoIFhlbiB3b3Jrcy4NCj4NCj4gVGhpcyBjb21taXRzIHJldmVydHMg
bW9zdCBvZiA3NWNjNDYwYTFiLCBhbmQgaW5zdGVhZCBhZGRzIGNoZWNrcyB0bw0KPiB2UENJIGlu
IG9yZGVyIHRvIHByZXZlbnQgbWlzcGxhY2VkIEJBUnMgZnJvbSBiZWluZyBhZGRlZCB0byB0aGUN
Cj4gaGFyZHdhcmUgZG9tYWluIHAybS4gIFNpZ25hbGluZyBvbiB3aGV0aGVyIEJBUnMgYXJlIG1h
cHBlZCBpcyB0cmFja2VkDQo+IGluIHRoZSB2cGNpIHN0cnVjdHVyZSwgc28gdGhhdCBtaXNwbGFj
ZWQgQkFScyBhcmUgbm90IG1hcHBlZCwgYW5kIHRodXMNCj4gWGVuIHdvbid0IGF0dGVtcHQgdG8g
dW5tYXAgdGhlbSB3aGVuIG1lbW9yeSBkZWNvZGluZyBpcyBkaXNhYmxlZC4NCj4NCj4gVGhpcyBy
ZXN0b3JlcyB0aGUgYmVoYXZpb3Igb2YgWGVuIGZvciBQViBkb20wIHRvIHRoZSBzdGF0ZSBpdCB3
YXMNCj4gcHJldmlvdXMgdG8gNzVjYzQ2MGExYiwgd2hpbGUgYWxzbyBpbnRyb2R1Y2luZyBhIG1v
cmUgY29udGFpbmVkIGZpeA0KPiBmb3IgdGhlIHZQQ0kgQkFSIG1hcHBpbmcgaXNzdWVzLg0KPg0K
PiBGaXhlczogNzVjYzQ2MGExYiAoJ3hlbi9wY2k6IGRldGVjdCB3aGVuIEJBUnMgYXJlIG5vdCBz
dWl0YWJseSBwb3NpdGlvbmVkJykNCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8
cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiBBVCBDaXRyaXggd2UgaGF2ZSBhIHN5c3Rl
bSB3aXRoIGEgZGV2aWNlIHdpdGggdGhlIGZvbGxvd2luZyBCQVJzOg0KPg0KPiBCQVIgWzB4ZmUw
MTAsIDB4ZmUwMTBdIC0+IGluIGEgRWZpTWVtb3J5TWFwcGVkSU8gcmVnaW9uDQo+IEJBUiBbMCwg
MHgxZmZmXSAtPiBub3QgcG9zaXRpb25lZCwgb3V0c2lkZSBob3N0IGJyaWRnZSB3aW5kb3cNCg0K
VGhpcyBuZWVkcyBhIGJpdCBtb3JlIGV4cGxhbmF0aW9uIChldmVuIGlmIG9ubHkgaW4gdGhlIGVt
YWlsIHRocmVhZCkuwqANClRoZSBmaXJzdCBpdGVtIGhlcmUgaXMgcGVybWl0dGVkIHVuZGVyIHRo
ZSBVRUZJIHNwZWMsIGFuZCBleGlzdHMgb24NCnByb2R1Y3Rpb24gc3lzdGVtcy7CoCBXZSd2ZSBn
b3Qgc2V2ZXJhbCBleGFtcGxlcy4NCg0KVGhlIHNlY29uZCBoYXMgb25seSBiZWVuIHNlZW4gb24g
YW4gU0RQLCBhbmQgaXMgaG9wZWZ1bGx5IGEgZmlybXdhcmUgYnVnDQp0aGF0IGRvZXNuJ3QgZ2V0
IG91dCB0byBwcm9kdWN0aW9uLCBidXQgd2Ugc2hvdWxkIGJvb3QgbmV2ZXJ0aGVsZXNzLg0KDQp+
QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 14:59:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 14:59:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429908.681241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLOY-0000N9-JN; Tue, 25 Oct 2022 14:59:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429908.681241; Tue, 25 Oct 2022 14:59:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLOY-0000N2-GT; Tue, 25 Oct 2022 14:59:10 +0000
Received: by outflank-mailman (input) for mailman id 429908;
 Tue, 25 Oct 2022 14:59:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onLOW-0000Mw-W3
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 14:59:09 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 931a5d61-5475-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 16:59:07 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB6911.eurprd04.prod.outlook.com (2603:10a6:803:12e::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 14:59:06 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 14:59:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 931a5d61-5475-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JMqMtOJn/vr7+2TSLI9tFz5eAK6PaNaMvV3vsmdww8K0SH75BahPwpVotlo2/7ltH69RLZJ3O4taZ+Co3kD17BmWDN6ZDXqm5yruPgeJnP/esVo3ofD+h/ndl53swVZaAPhccOaylnTNL8cR36dr0wVTLEdu6UhQvnmi7Y3qvYAAtUAWHjCndG6FHyBsb6pDW4JeeqIILmjDdGCvqf6fUMRaUNMC97fNNi9NaxXI2kqcyHZ/yWNUkOsgrL3cFwNRghMz0ecJJimp3yxASOynR4BldQ2ujpNLAAuCkmwR97JXvHjIwHxSWPa1vgxkAh23+2rWmgtGopHYUrMiTdKgYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=m1wrWbC+Caq4MiSWmFjLRvB0Npf8O/zMP009kIqYEJw=;
 b=Shw5Oc+bDOWgUS1/zjqqSvO7zGZ8Dz/ZHyQ7OwhllHvyzwuO/SP/mOqCxuiYZhfGtkGiQeFX0oefsRyY7cml68WpJKfWVUtSszrEhmFxQZPODNT9WAp6IUvkb+jeBDhjJH0p92qayzU9mez99NnPHAR2PrE4JVi+Tk+NPsbbmK922G+hs5H4aWfTq+emuek2REYhuTpGkUCJddDiL9tx7jYWpF3XxWvekdot2k7l/JKLUsg2PsI7nIo+Nc8iP2DQ9RsweMcwOXNVFAJy3QNCdkZJDWPTHi4f68po+QNAs1DDM9koHtDmJFeLot+63jwtEr5ckaQTzHQ8QA2OepxkbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=m1wrWbC+Caq4MiSWmFjLRvB0Npf8O/zMP009kIqYEJw=;
 b=jgWJm3VjxVmZvySiQYA8JlFQfvbBxmN65x8kyIy8waLrxSmfsOxdnPbXY3sSI0NHF9KwKO1rvYGRuKDnxlr2IcmHLCjDQTcX6KprFLmQ/yruv3c1fSr/GaQxVB2g+GP3dCES2HSt6olz5WDHlc2zIxcZ+4Qt9kiWNwnD7yc3IQyS/4uiBdXM521T2nf6hbIwM+ePcttQhUIqucVxxREIdgbG2UlhKWti8Tc3n0pHtZo7b9n4SbisMqlXoJfapCV6oKZglKc3L5CI2Ud9/nNR0mwE+f+j54EuPvKtCq13TVlZJTnKGLnW7zpLsSN99V+0UZV1wiBJ5CR+gMpM41RpwA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fa87250d-8bfb-c915-daf5-baf8c91188ce@suse.com>
Date: Tue, 25 Oct 2022 16:59:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 2/5] vpci/msix: remove from table list on
 detach
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221025144418.66800-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a0::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6911:EE_
X-MS-Office365-Filtering-Correlation-Id: da7bd407-2848-49a5-e766-08dab6997671
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F8TqqS04xTQQPkp6cMoH+joUMlXw8w9t+ia1TKOosV+KjTB6MNSZcfKM4A6dkMzGRP0+QwSXGH+ghLiGYcvCw9wR1Zj/hX7xXnHN81eKeWg7VBgpw+rtLqD3qo653SKJMiydL+IUxC9un9V6S2O5wPzubUCBiwPK9kfmebq9wps3VK9YLWLn1FZtT96Yi7YkrxYWhZLV7fsLBJ93cOTeBEwTyPhCFNQE9OhMgR6XHmVnVuvLRsXLTJ9b5Ut0bwB45xo3L+okXJeh/kaT6Q5Qr1wU06q1O61+amK1d4lNMHbFQuJIdpR/T1xlayoty/oXYfgdbrJj0hm2omqhuKjLaOpVg6yhBfqHcCsH+3rOaDluqT6Fx82RIjPbGbm13Z8OScQOQ60ndZNqbw/KgHkOTTIGdlK85LBLbipFGl5gRTHOlbaeWAmApRhDBpgC7+SYp1JwO7sPt0BArQm/0Di9h3qumKWSpI9NZhUZZB+S+H2u8EwUpJUU2ChLlp8jvi5pyGAY7ZmK6+7XK2mYwxmWNZPtN1L1cv/7xb8irnOo+uqoPOxlgz0NyBzLhuETcbop7V0fRcftkUDEOzf8+mijOb8AdGKCOTxy++AXtUxO2mgNX8AGiPGd3lAhMPgaashxk00YN7B/EtX8OBWrVPqLVw8UpZgHX3XD5gl56CeKayxuOM/qdhgYJCf9OFINuLAJkjsYjGj3+Wx4AD91AafLru/pZ28ePOnFvndZFP+ioKZ6VE0ZlE0wsUTiWZkIXU5Z0MWIz9v2pHEttgClCoR9kngG/DZ2MCwHaU2KJmOkAx8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(376002)(136003)(39860400002)(346002)(451199015)(83380400001)(31696002)(86362001)(4326008)(41300700001)(8676002)(6486002)(478600001)(5660300002)(6512007)(8936002)(38100700002)(4744005)(316002)(26005)(66946007)(6506007)(6916009)(66556008)(66476007)(53546011)(186003)(2616005)(2906002)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZjVjdGplRXlVWkFhNzIzT00zbzgybmgrWWg2LzdyeEtadk5JcEZzaTlXWnBH?=
 =?utf-8?B?ME5TVVd1UlhSbmdxNUJSSXBQWVdzV2xNY1BUUGd2THdFdkFLZFFiN28wcEtV?=
 =?utf-8?B?YUZOendMbmdHeE1ub3gvL3VNODRRUVNIcEptL0IvY215b3NOLzRCL1puZmZh?=
 =?utf-8?B?RkN5OEQrVXRuVUhsQlc0Y0xyb2xWeWUwenBCV3doSkh6NkpkVzJZRXFiekpT?=
 =?utf-8?B?dGNkODRQdGRHWjRmWHpITHh3VFFLUGF2RGVSMVFDeUlLVG43blptdXJvYXdL?=
 =?utf-8?B?ZXZWVm1nSDh6dmdUKytoRGdkd0c5emZSMVp5TE5WVXJjV2VxclVrZDc0MWpi?=
 =?utf-8?B?UW1ocGVFS0ROaGdOTzNpa3FlSEdHNENHRTd4UXY0MklnVnJIN1l4L2VGYzdT?=
 =?utf-8?B?TE0yYTBHZXVYVzhJUVFTM0xFMWYyWmlOZXZ6QjhTQUVzMW9PSlNZUTZSWEoy?=
 =?utf-8?B?R20yU0lIZUVqbThQSnRrbjBWVzcvdTB3N09qcHVJZkpaajdmdWlaWVdJWm83?=
 =?utf-8?B?QjNxYjl5WE9zbWh6NUxnaE5rd1d1cEJvTnZRdXY3S1c1UStHTG5yVXU3Uy9R?=
 =?utf-8?B?d0RnbStHOGI4eXd4dDVrU05JaVBzd0pvRFJFOTRDVTF5WHhra0FYRENTbHk5?=
 =?utf-8?B?TGpSOFNjR1FwbjlhNld1M3ZIOWlCOHhtUTJpdmRNRjRWUHFXYXlEUEErMm93?=
 =?utf-8?B?R1prbzNiV09mSW5vQi9Jd0JIMU9NRlFXejJXNlEvTk9yOHN3b3dtaERKaUFs?=
 =?utf-8?B?c0FqeERqU25HR3VyNXBBbllBTHBRNTRwUmYxbW92bXdlWWcyNnBneSs5K242?=
 =?utf-8?B?TVN5ZUgrN1Y5RnhxZ1ZIU3EwdmNLUkJCUlB0RTgrZHc0cHFqRmNkR1BndmlB?=
 =?utf-8?B?UFp2aURJcG8zQi9IWXFzYXhvZmM2R3FRSzBINUZIbnRiSHEwU0hlNVJvTytr?=
 =?utf-8?B?R1BkZnBoQzFVeENtTjJYcjRnL3pPZnBndzR1ZW9DSnU2bG5DVmNvZnUzdVEw?=
 =?utf-8?B?TGlKbzRLMENlN3EvekpnSm5jeGhyZG1CKzMyQkVVYzdpMWFENGtrTjEzVjdn?=
 =?utf-8?B?Y0l6SC9ya2ljUUFMNkkvVUdRS2RkOFRqYnpLN0tSOWJZNW9XNUR1MENNNEcr?=
 =?utf-8?B?TTNWdm13NU12Q3hyZTV1Y3p1bVdDWVliZ0J4T0liQUtDdlpPZnVxS3ViTGJn?=
 =?utf-8?B?QUVJL3ZDTUMrVkNpMTMzQjRzYlUrb2RZa1NEbTZVZnBTR0V1anZtcDN2Vlgv?=
 =?utf-8?B?eElZaFdwRU0xSnJab3JrZGduSGdLb1FTaFFrRFQrY3h1Rk1vdUhUckdmeVNT?=
 =?utf-8?B?N3lqTWxIYzFBdk4wQUYzamhseHhIcDcxMlVlLzBHRElxV0dWbmgvSDA5RGkz?=
 =?utf-8?B?MHJwZ2ZEQXhDeWRJb1RhdEhiWThwK2FUNXRDMG9QZ2xQOStBY3RIUWRmWTgx?=
 =?utf-8?B?eElPakFYRmVUZVk0Z20wLzk1OXBWYjZhaXNKSlRmbk9NQmFDM0ZoM2J5Yk5j?=
 =?utf-8?B?bWhXQjlnbFQ5Ny9IbHhLc2pQVDIwU2xXK2crVGd4Kzg1NzIwVTUvbHlTTlAw?=
 =?utf-8?B?V3VwaDdUNHlpSFJmTXlLdjdoUDYrNVo2U3IvOWtyTGJjTWxsZTlrQTJTajI5?=
 =?utf-8?B?VDdvdmdMKzVRUzFhTlFZUU05WFZ4ZlZUVXF0VUczTWYxNGdFTHR3b3BVT1BR?=
 =?utf-8?B?TmJkQmlVeFk0MkQzUHU5VU1JdXBNMG1FMk9QTG5CRUk1UDNteVhOVXRLSGxm?=
 =?utf-8?B?MkV3dmoyQWVwUkNXYThQSUN6OWlCbEU4VGx3dUh2T1NzSVdkb0tiQnNFNDNS?=
 =?utf-8?B?WVYzK3czdjhpb21JWFNESlM1eDdDVXR2cUZaTXZrdWpNeE1iY01RRVJObzZu?=
 =?utf-8?B?c3JBR2NKNjl0cjl3YmhKVVdlanR0Zm5UcnNQVTBzc1BibVFCUE8zekpqN3B6?=
 =?utf-8?B?by82ZVA5Q0hwc3FxUnU2cTR5emhBVjg1VDhwelJNVXd0MElPTXJJL1Jub01U?=
 =?utf-8?B?bnE5NWtOVUpxbE13eVhrR25LbW5MVTNjajB3cHNDQlk2R2ZUSEpWK1QwZ09L?=
 =?utf-8?B?ZHltOWJRM0ZaKzlRSW5SS2NLellyRzQrOUlTK2FtT1hOQS82bjJwZU94K0cv?=
 =?utf-8?Q?SAzAguF7xxKEjTe3X+LGZwqkv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da7bd407-2848-49a5-e766-08dab6997671
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 14:59:06.1649
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZxgT4KnwKagKZES39eun9jguMthLKbPfx0HNBOq/5iFe5FkcA+JtjtpAA2exueTq32h2J3K9ht89zLsPODUerQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6911

On 25.10.2022 16:44, Roger Pau Monne wrote:
> Teardown of MSIX vPCI related data doesn't currently remove the MSIX
> device data from the list of MSIX tables handled by the domain,
> leading to a use-after-free of the data in the msix structure.
> 
> Remove the structure from the list before freeing in order to solve
> it.
> 
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: d6281be9d0 ('vpci/msix: add MSI-X handlers')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:01:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:01:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429912.681251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLQO-0001o0-Vr; Tue, 25 Oct 2022 15:01:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429912.681251; Tue, 25 Oct 2022 15:01:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLQO-0001nt-Sv; Tue, 25 Oct 2022 15:01:04 +0000
Received: by outflank-mailman (input) for mailman id 429912;
 Tue, 25 Oct 2022 15:01:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onLQN-0001nn-Ar
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:01:03 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2079.outbound.protection.outlook.com [40.107.105.79])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d77b7d81-5475-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 17:01:02 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 15:01:01 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 15:01:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d77b7d81-5475-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=imcGzbroxK+xi92ssHWMbffZEtI0J87e//k7155LYZr5h87N5F/tq9Q+mS0qnALNQwhn4rbTxcFk5PcitIOjpikNCqUYjZfaG4qEkNax7O4ROwFEczGrudzf6cuXl0xGopNL5t1vC38jL2D0pumJv6vQukkKdNoG9M54PNRNQB5N9m980ZIO8ofpVdsxvtuArfAi5gmj/pJtiKg0CFnvCgYoiiuebUTVeNAtAN0cF15cRcIwn5U7CnhFPhs23QhplJ+1Rka/O7j2zgk8tbCnwB1F9VlcgRqn1zwH6zOFfnkWLLPb0qsFW39IpFREEh/8UHCL9B7OlaaLbEOjqDvZ2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kt41+vpkLFHaiCgHytIXFHsNCAAi8d9QQTEDw3EnB7k=;
 b=HHLzo+/1aiL+aJ2qtaNCpovlF3awQzqN9iFLFHquSKnD2YeWOGOeb4gArgdGn12p2bXzgWPFtkJ+OkdSZ7fVLQIXshJG9t+/q3TuUs0h80vZmeUybI1/VzlukxS8qMRyAUAoHfETvxETZnOlAB833LutPGAfS0bzYiv+p1YjliZresOhB8Hb545lTzJ79t1XYjqiYTgdvIiAxnXB3lDDhZrZMCtPvlBT37bldAEqb0G2zzF9B0PyfjkbUb2JGlW+9DYgIMm5yhh1q3R83GhCmLvSWnH81cQNazj15hutq/9rOzhgaTfxf4tLfWZEMc+Utfzs668ADR3H4ueDi16MrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Kt41+vpkLFHaiCgHytIXFHsNCAAi8d9QQTEDw3EnB7k=;
 b=VYQhN/6LBgkVR+l6KeRwB/RvOGcZdqtU9BLfCt/bvSxC6S5wAJzmkN7QutpPtz8mxXwXhqJBnQdGb7POHLox9Oms5UcsFH8NqHzvQALxm/VLH3YfrTNzJKmG2Hut3BJZOGas62Ojw187wY9Jv75a1nrs4kZmOvwkp/JZ0bKDd0SoJrk6gxn0lxtN/U0/HBXsmKnKu0q1W61qpHAnMxnx7eUP/28SqkZDxJTdmCcqXpPOd/ENYfpoK4gkIXgeLghu9iPSkWHT+LzhrIa0Shkp2p7ugQQOo4vWZVoIj1wn6lmCabMx5IcMUlTkFQmwQFdHIwYzx4Vmw65OCPy+Y3YJ9Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <05920ede-87b5-7b93-a115-27751c94d437@suse.com>
Date: Tue, 25 Oct 2022 17:00:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for
 devices
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "Henry.Wang@arm.com" <Henry.Wang@arm.com>, Paul Durrant <paul@xen.org>,
 Roger Pau Monne <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-5-roger.pau@citrix.com>
 <46a361ba-121e-a054-da59-512e0fb6eb70@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <46a361ba-121e-a054-da59-512e0fb6eb70@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0071.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8602:EE_
X-MS-Office365-Filtering-Correlation-Id: 808cf51a-848e-4747-d53f-08dab699baf2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tDAVLNDFiFMatQQyUtbASxnr8ZJLIMJXzUZMvKSPaLNHbOA+9SjtOvTwAYiQMq3nNBtw5L9sVCrd2Wnok0PdiE+zCk9QpEE4ZDvQIXkSbIE0dyQmwlZw4P137CT7GdjfTOAKQv//6NgEi2dosOEvyH4BXMIdFDagZkXG8tNeN8JEirsVnfeNcdaO5CVcI6ay0bJ/f/3kKcLBpbD1QblbSa5HeQ9CAGwTCgUwXFWxjp01/eUgFEKw9jhNult86Ea3AJYRzx3KvuJJB7Qbs6d7S3b788uA0oql32nffwzAVb8Zq6F8lLaR7g/EkYQMsatDNFzyyT9ktEsQRmpthjdc0UvMO4zr+741dW62c35QLRwCBpAIRcOJPffsJyWGLA95RyP/ldAzDzscVnyY5KTOMR/1JeQ4DYYEF4g1HMxeLpp5IfWtaJ++/68V2roITX3Lpn5tS6xfjXUSOfPnyyRJh4VKDl9NB34roYt0YTA1Y11l/XWkLZiNCexwElyYIWGUBsWGWRSD7Vxt2xlY0AmaSAPUYHMYuz4dcfhzLYWGMYWwh4mNUrPvqaEccCTt8gwoUgOGXyix1DLi/bxOIdijLmGaTXiYv4y1lU0bYTFFlGuOsSpR1WYVfmGBGh1/85BWg7wjiXtUJxtoi4UteGPtJG5EPNvmVkYYbf7IC1ynZ1t9vmIyq03COuw3DSZ90VUQ2Oo0aIaLdJPVNL2QdNDTXA+hQxNvbJaQ0RHCU19Xgvt8W/dW76ujYDEW3IxS/+uv3h+/ZgZF/1uI+jelO4Ii15p2vc4AZu6LAX+ZJUNIixY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(478600001)(6486002)(41300700001)(8936002)(4326008)(5660300002)(6916009)(54906003)(66556008)(316002)(8676002)(66946007)(36756003)(66476007)(83380400001)(38100700002)(86362001)(6506007)(53546011)(31696002)(26005)(2616005)(6512007)(186003)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QmRWTUp0elIrbzdPSjJXdVAxaFJEYW4reWw4Nk95N3RhaTJOQzhlTkt0bjd4?=
 =?utf-8?B?VXMxNWtZK3BONUdYWnhGaUpMMHo1VGY2bG1DZ2dkU2YyM1J3SlJHTFpEMVU5?=
 =?utf-8?B?STQzT3d5Y0N2dFNFV0FOeUNRNnNWclEyQzB4cW5BSzlIMU44RHdQT2FkRjFL?=
 =?utf-8?B?VlRvM2tLSHBxaEs2THovN090ZkxSU3dKMkNvQWFWcU1uc1ZBT0g3a2U4RGg4?=
 =?utf-8?B?bCtMYUorc3IrNnJBT2VkUUhMZHROcXVJM3hZWnFWSEo2NVVLWllkWDlFWThJ?=
 =?utf-8?B?NmJWazVWQXZTL3A0MHI4RXhiU0gyOWE3cGlzbml6UUR2cWZGMTRUMkZ2S3VW?=
 =?utf-8?B?Rk5BNCtKU1J3UC84RzZRdXorUXpWWDhBRVI0NFZ3VnJ3NUpiTmwxeC96UDkr?=
 =?utf-8?B?SjIrUDVoRFFMYlMyUDVoRTkzZVNNOXhXQVg3a0RpcUNOdU1JcDNOUzQvMkpn?=
 =?utf-8?B?MDZTeTRacDVjTHc3Q1RucjFLd1kzQmEyL1FqK09wbGduNmpMVGt4V0pKc1hz?=
 =?utf-8?B?MS8vaDdRTkZyNjkxQUhwbko4UmtFNlFFNG1JWU1NbDZmckt5SFAwdUFsTUtY?=
 =?utf-8?B?YURrMm9nUEdQWmdWeHRzZ3VBS1J1ZFNOa2w2RFFtekRjSWtoVTBGak95Tkwr?=
 =?utf-8?B?cmZ0N0xVV1dQNnNyQmdXOTF2bm1QdkVMUjZKY2FYTjN3cGx5TzFyMW05ZEhS?=
 =?utf-8?B?TTh1ZCtkUS9Eajc4K2tINi9objdiRG9aQjc2NWUveEgwclRvKzlDUGJlT2ZP?=
 =?utf-8?B?UzNiNmc2VHR4bXErRGJhdWErNU0vWUQyU2lrL2ZhV0V6VWQyZ1NFNGJ4a3Rh?=
 =?utf-8?B?ZmhnTm5vNnFZVzBLT1Q5Tm9sd053RC93a0Vydm1lbWsxN2VqT1BjcGlrVmpi?=
 =?utf-8?B?cFlhSzloOTdqUGlKM3lsZTl2Rk9KM29KcVhsZDh1bjVTTndheFU4RzV5OFF1?=
 =?utf-8?B?aVQrdDJJNnY1YWs1VWxNOXZrUTZNa1ozaDJ3MllrQWJ5blBvbmppdkpZeUVz?=
 =?utf-8?B?enhqSU5xR2tLS0YrbjVCelVpR0hVdmRSU2R5dzBiYlBOZHgyYlZUUlBqSVZV?=
 =?utf-8?B?MGZWbDFkcFRoSTl2cmdQMjY2UlBpc2hZSGJoMU9PWCtEVEdza20vMTZUTUlm?=
 =?utf-8?B?NjhlWkRuWGJkVC9yOVdxSGx2ZHNCcWtpZE11cjB6Mnc0Q0dHK0p2cnRNUy9E?=
 =?utf-8?B?dGhObzVBV0w3d1I0UlFLbllxbVg0QXBJdS9ubExPdnJ4NW9xeExwY0IzdzRR?=
 =?utf-8?B?ZkRJd0orNURXUGsrK0dZazVzMHJjTFA5U0J4NEZIQXhrNFdjWXliWlpySmJq?=
 =?utf-8?B?elJSbUE5bXJoYUtheVFrdHV4ZjhkSUxJTVNtUjRzTU1pdW1Ibk5DODF1Nk5M?=
 =?utf-8?B?eTJobVZ0dmF2WEh5cmJuWGRsblNiTHQyS2owSmh4bXB5S3JqQmRtSGRJdjFV?=
 =?utf-8?B?NlMrR3ZFUGtxQW5SamZFZEQ0KzgvcGhDRFdTZzh0aDB3Vy9nK0phZFNtdzhQ?=
 =?utf-8?B?K3RaVm5SM0RseVY2NHBURmlTaUpxQWFIWkZaQmxBWS9zMXN5a1FCbjN0UTNY?=
 =?utf-8?B?U0ttejJZL05lNUtJdUcwQWZmZGZMNUhobDEwQXNTbldDRWFNNG4vOVJyMEJZ?=
 =?utf-8?B?ZUltR0k2M3poYytXRllHUWNYMmpQUko4Q05mR3ljeGplcVFYbnMyZnNwSy9x?=
 =?utf-8?B?bnkxYUJVQnpZZEg4bmNRY0JYWjlMcytFajRITnE3Tm5ZTHF1SGtaYzVvUWJl?=
 =?utf-8?B?MlFLNFJZb2lpRjlDbkJwQk1lbFYrRDRzeE5pUytrcUFjb3NWdkVBTExQVGh3?=
 =?utf-8?B?NkxPOFZQallqZVZIcXQvcEt4NEowZEdMbkdWQzlLVXNMQ3piWDVUeDFNNjIr?=
 =?utf-8?B?MFZtVklVWWI5eWt3OWRkNmFXM3hLKytjWTVWSFd0c3NuMFlvNFZpdHphdFhU?=
 =?utf-8?B?djd2R3h2L3dkb2I4Sk1VN1NsL0tXNW9CRDRnTjh3cWJYa0ZNNUE1aHErdzVK?=
 =?utf-8?B?ZHh4UVdKNVJ4bk05d1BBQWQ4eFBna0tnemlMMDBERmN2LzF5anhEM3lDWVEw?=
 =?utf-8?B?S1E5eThCZ3FEaUxnRDZ2aFJkcDBSZFJZYmdzWThUUUR3OFJNcitGWThhUUdv?=
 =?utf-8?Q?xVanH7tcmTlso2VvQy5zUVvO1?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 808cf51a-848e-4747-d53f-08dab699baf2
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:01:01.0168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jhrN6rsJtxiRHmDqoz5PFZh+Nx1cj77y+vlAOIGRbdgAXtbAx63Fu7VGqZRPMXUQw3DJX+WwC7DsbX7VQ2hMDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8602

On 25.10.2022 16:57, Andrew Cooper wrote:
> On 25/10/2022 15:44, Roger Pau Monne wrote:
>> Commit 75cc460a1b added checks to ensure the position of the BARs from
>> PCI devices don't overlap with regions defined on the memory map.
>> When there's a collision memory decoding is left disabled for the
>> device, assuming that dom0 will reposition the BAR if necessary and
>> enable memory decoding.
>>
>> While this would be the case for devices being used by dom0, devices
>> being used by the firmware itself that have no driver would usually be
>> left with memory decoding disabled by dom0 if that's the state dom0
>> found them in, and thus firmware trying to make use of them will not
>> function correctly.
>>
>> The initial intent of 75cc460a1b was to prevent vPCI from creating
>> MMIO mappings on the dom0 p2m over regions that would otherwise
>> already have mappings established.  It's my view now that we likely
>> went too far with 75cc460a1b, and Xen disabling memory decoding of
>> devices (as buggy as they might be) is harmful, and reduces the set of
>> hardware on which Xen works.
>>
>> This commits reverts most of 75cc460a1b, and instead adds checks to
>> vPCI in order to prevent misplaced BARs from being added to the
>> hardware domain p2m.  Signaling on whether BARs are mapped is tracked
>> in the vpci structure, so that misplaced BARs are not mapped, and thus
>> Xen won't attempt to unmap them when memory decoding is disabled.
>>
>> This restores the behavior of Xen for PV dom0 to the state it was
>> previous to 75cc460a1b, while also introducing a more contained fix
>> for the vPCI BAR mapping issues.
>>
>> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> ---
>> AT Citrix we have a system with a device with the following BARs:
>>
>> BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
>> BAR [0, 0x1fff] -> not positioned, outside host bridge window
> 
> This needs a bit more explanation (even if only in the email thread). 
> The first item here is permitted under the UEFI spec, and exists on
> production systems.  We've got several examples.

Afaict it is at best unclear whether this is really permitted. Generally
BARs are not supposed to be covered by memory map entries, be it E820 or
EFI.

Jan

> The second has only been seen on an SDP, and is hopefully a firmware bug
> that doesn't get out to production, but we should boot nevertheless.
> 
> ~Andrew



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:02:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:02:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429916.681263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLS2-0002T6-FR; Tue, 25 Oct 2022 15:02:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429916.681263; Tue, 25 Oct 2022 15:02:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLS2-0002Sz-CC; Tue, 25 Oct 2022 15:02:46 +0000
Received: by outflank-mailman (input) for mailman id 429916;
 Tue, 25 Oct 2022 15:02:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onLS0-0002Sr-G7
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:02:44 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2049.outbound.protection.outlook.com [40.107.105.49])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 13dfc05f-5476-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 17:02:43 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8602.eurprd04.prod.outlook.com (2603:10a6:20b:439::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 15:02:42 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 15:02:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13dfc05f-5476-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GVStPIylbpR67cYUM9R8oGwycs9kqzDUr3CZSqk1VKkyUrQ7ZDPfljTFM2Zhc9KviMXWMKeKVcPI87h4izt17iuKPU/WwUo5NYQHtYjH6pkBBj8nciNXStAzLHKLSToHk8tKEqcmCDGHUEug0KYSelFp+n9GLws+qijCsqkK6wAcUf5q8HziCdLBOCD2c0BJE8SItWswevrX504lmz9lf/qUgmwUhu+2S2s5W13W2XH6YdJkvn6uIZ0aAlnw+TjMwJWpZHV2euAD7C5G47TdmwwN99RZw0zyLXXKFnAN4sLbPZmQqiiXAe+4ukQK0aAKY28NXHBavRIk6Nk30ARZZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=t6pOxUAjFyK1FK5TvcDLcFUo9wRTgl/tT+vOBnYDtIU=;
 b=OVyC1NQQBbpiIEQIHQWuRbpFo44J9mm+WautaZRsPmu107hNYA901M38DzMyLLze8Mhv7VnAfQCTdwijIt0jrCAKS4pdHWOWI0utlM5TnUF/I2PvBb3D7Fy1tyCp0ssvFVB15TyjKVPsdpqSYhdaugNQja4l3qh6vjcq6mzEK4Z4B7LSupwcbOYueH4O2K8dOQ8ZDoflGBkQTC8BP/ceCjnonS6lw/S24peTP+j87MW/mHINqsUtrEWf6BsBMOtHOpyGY5uajWATsoNqv8WXq1pdjClKZv1yEfHocDl3K7t3qiDluTgySS7w9V+CT+PsuzBnPNc8eenBmuJCcY28/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=t6pOxUAjFyK1FK5TvcDLcFUo9wRTgl/tT+vOBnYDtIU=;
 b=gwdCZL/+x5OwgbRLr0a+K2CXnK7aMFt7RHv7JvD0VdoNzaTzffVama0ZB9+RhJTyw9xQHTXk5We0S3FMADl+jl5L7YAOXgwN+/V6hWd5NPQ28MIVIxcGwzyk8CptaAvs13YFjNl3MPHqcfaVgxCjOHlhXjY3NacTh9sEzJZ3omBLyBscHv+BPrSY797anegEugZJT7VC0Yi7Bz+ve4wQs87f1fqR2qM2fY8noMlVsP6KYE5fmOGliMCjqPL2Fyg6NAjp1bVHTRel+qFuf/2Ey0FRlTTfN90jnGCVfZaTK11qRop7wK2C/m3yJm6KqBltR+TWMUjdQP2YeQCZffwMUA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8a89c0fb-3d12-fcf9-7e53-d32f9904a3f6@suse.com>
Date: Tue, 25 Oct 2022 17:02:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding
 handling
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221025144418.66800-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0057.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::34) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8602:EE_
X-MS-Office365-Filtering-Correlation-Id: dff08e00-483a-49eb-800c-08dab699f790
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	g9iXAhqokr7y1dWuTv0kK7U6L7Vv9j0MWHzc16R2BB1ChghXHomFGLKy8v+n9l6qQ8TaJhDnz1N2ahdRo52r80W3fISdKX0ZONYpkXOMKBxw0j3QZ6OZpb1xWJAhqd72lvEMHhl+Y0S6zELEbt+v3RuwGOOyJRnoEP7fRifuaKj6JCq3wkhzyZSun1WcQSafKTaMvyQqn9jW9xG7psrL7vTvw3fgzUJz6cph92TUvvnrD3tD8P1uVU1P5F02VHTi7J/20JoyCCzVtvFVw6feaeOUMtlTyZpPbZbC9VSKI5h/xRSZdXbN78eezaUQmtz8PKgDuvb1a5z05BYWvE3zSByR3DE/z3c9v2Jah4N4l9BolF71WzM1Ihc+m+uKhlMJbcW2sH5iEupY+KZYJHvo0C1INZqeYd002YStji647UipxcRSGmSqS3igRmsN/0LJnov7vFALTKOj1hjjSPWGNItv+/zCqmoyGNLmH0+Z1FPx1bbR3tSxjiTCWtLMCjoJHH2HFC1Ayf/zsqq29T02T2coxw+t1wl7bL3fh9rchMNLHa6AQ2AaXum7Yw5MxTh01shbldzO/5hFq8nMpiUFIi9W8XuwxhdhHmSOGD4bQT6Xykd95hs6Lr9HSoTTWVoz5/+OAvF3Me0gF/AAaLhNCAioANy2L7hlmhKR7mmIC5OxaLzh1G7i9d+ezIrAtrllo+6agFydvJ5n+KRMaoI4kwxXAh8TrCmZciwfS2k8SfMMNVgULj8kqYcpmPD7PSxSEmeu61tZ0m+ji17Sl2eYUAGsoQFoQqt4oWH25P9iWXg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(478600001)(6486002)(41300700001)(8936002)(4326008)(5660300002)(6916009)(66556008)(316002)(8676002)(66946007)(36756003)(66476007)(83380400001)(38100700002)(86362001)(6506007)(53546011)(31696002)(26005)(2616005)(6512007)(186003)(4744005)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bi96U2ZqdVdXb3pPUXJrUldWVDl1dnhGOEhsMlBMa2NKb0x3KzRIdTJSUlBx?=
 =?utf-8?B?SGM3WWI2dGt5RjRSalQwVmh2UmtqTG9JZGswUEh6dUhmRGw5ckJkMzVyWHND?=
 =?utf-8?B?T3k3Q0JBVWFaeE1IUGhIMnNXUFZCL2tydktKeGh5clJWcUlUZ25QaUtVU1hG?=
 =?utf-8?B?R0lDcFp3eTl5aFU2b3ZETWlsaDlWRnk2V3JlcndLdHlVMWxKRitsM2syb1RK?=
 =?utf-8?B?d2VFNFVRaFJCbWk0YWxtUlFPdklBTDkyaE4rMzBBQnUwUVJXcjZzK3FTZ1kv?=
 =?utf-8?B?bE85MFNuLzN5OHJSZ0tjbGpwOE9tZjA1UXM4YVNBRGt4Uzk2dW53NHJsNVJP?=
 =?utf-8?B?TjNuSC9sWld5Yy9RUnZmZExyOGdXWG1oM2puMWdIWjdSQjhCOWNweUo3cDhW?=
 =?utf-8?B?M0liT0lUakpNa3ZWZS8rZFhqcnBYbTBSTkpRbzU2ZEhWUHgzci9sRURQWGtk?=
 =?utf-8?B?Wkd2K3F6TUthVjNTMERwbTRHNjl1Sy9zcEdjNm12eUFuM3ZVZzQzYS8rcWxn?=
 =?utf-8?B?TGJBY3kreFcxUWozM1VVOHZUZU5QOC9qSnk0ZW5CRWRXNkRUTFhzbXRZZExv?=
 =?utf-8?B?K1lGZXlwTHdxeVRFemNBZzQ1SWphQ3N3UzFjZXNWZGxLUGdSSmY1cmJGNFln?=
 =?utf-8?B?aVRNUDU5VitwMUxOaXc1cFM0bFFWRHhjbWhFcVFMK0h5bk45Q0Z1bzJIQTF2?=
 =?utf-8?B?NlJTZ0J2TkVmckg5Nkp4K2ZlOU1zVTFvWlZQNklHOHVFTU03UVh5YUlVdjFn?=
 =?utf-8?B?SUhDeFJScmlMSnZ6a2FKVUNjRkQ3TFU2UGhnSjNpSEl6RXc5cXpJYm5JYVhl?=
 =?utf-8?B?c0RnTklqejFOdDNTNER4SktWV0xWR1RNdEI4c1FxR0hoSUN2R0tjOGN4b2Vi?=
 =?utf-8?B?cU45ZkRtS05nMnBrcm90QWpFYWlVdzN3Q1Y1dTlrcDA0YlZSMmtYQkhWZmZp?=
 =?utf-8?B?QVVzZS9iNDB5ZFhLR0E4NDJpRmtiSFNXWjNzcFFjaUJlK2w3aUVqRUEyRG9M?=
 =?utf-8?B?c2g2bFFGSTI0enp0ak8xQjZXN3B6a1lUK3NSV014MDhnd2RVR2FiUTBTYnMy?=
 =?utf-8?B?MEtEVEl3ZDBTczE3WFBnSS81cXoveklsRkVnQm9lS3lFb3FNdWtqR2FOQ3Uv?=
 =?utf-8?B?S0kvRXF2elc5NzlyM2Rxc1pTRmE1bXFVMzBOY3gyTXA5U3EwVy9MR1NHa00y?=
 =?utf-8?B?UXFiY3YwTXJjajAvVnJVSnVNNmJzZVVEc05sVFJiVDBDK2sxRHdoTk9JQWpR?=
 =?utf-8?B?cGVUclFQYWovcWU2cFVOT3lYM3hVVXNnUEpSdi8zUG5rb0VoMzNtYTFJUkFz?=
 =?utf-8?B?dzJnMS9YYURSZDkzWGZlZzl5ZUNSR1NSNzFST0IwY2NESTIrd0FUNXdueXhF?=
 =?utf-8?B?ZFFVVDI5NkVCSFhuMHcrTEx1ZWhaKzJCSkhGMlE4QXlnVmZnMTN3d1Azcy9k?=
 =?utf-8?B?Zmp6bGNUbWNsdWl3VjdpSEdKc05ENnZnOEJFRDczcjN2RTI2RWJyNnlVeUJD?=
 =?utf-8?B?Y3Y5N2Q5eXd6SVJjRDEvd0ZmUzRSR1VmMUh0YzhqbU1MN2YyeWxCcjIvL01W?=
 =?utf-8?B?M0M2K3pWZ3JydjZYZVplbGdzNWprQ2c3TUF4NExCbG5aNkROdTg3aHladUJa?=
 =?utf-8?B?S1hwSVRWb1NiWm4vNS8wQVVjSVhEZ3lFSEJKaXBmMG5YZ1JZc0x0QUFWbDhV?=
 =?utf-8?B?LytTVWxDendjQmZnQlM2L1JpL09rN3dMMXFiMmFNTi9hRjBSTElsUkxoZ0pX?=
 =?utf-8?B?Y1QvcXhIcHRoa0lKUVNnQ2dTeFEwbVEwYklPM054anVQRmc0aW5kbWkwTCsw?=
 =?utf-8?B?dDgrOHRWalVVNzlBVDVoZG0wLzZycjRmd0hLR01UZkN3MTJXTXBmWGl2ekJx?=
 =?utf-8?B?YWdmdTVhZW50ZjBPbnZxTGlsSXU4TDZsaWtxQjYvckt5aFAvRy84b2VETkxq?=
 =?utf-8?B?QmJMQkxkU3liYWxqR1p2OStTOGk2eEZzbE5oTFZkZ0pEa1Q4ZDRlK3ZLS25X?=
 =?utf-8?B?VzVNK2tTUFE4dEVRdTZDU1AvMzcrMWN6cXBaOXF2QkNNRVlpWjNrTFRRUXo5?=
 =?utf-8?B?WVAwK0xzVUdROFh4M3hRZWVrVi9zMTEraDRhRGR5dEJleU42dkdSdWgzd1lw?=
 =?utf-8?Q?xqwsHl4JTC4GBRvtW273yiyl7?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dff08e00-483a-49eb-800c-08dab699f790
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:02:42.7290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hFIS/9AqQq6HNWLKcco0lsgXI0bDsfiO3RQMyDosho2zQefD1ji+Ov1tlILy8HwBwhu9+AVuCaEYVlp+xlW5Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8602

On 25.10.2022 16:44, Roger Pau Monne wrote:
> Hello,
> 
> This patch series attempts to fix the regressions caused by 75cc460a1b
> ('xen/pci: detect when BARs are not suitably positioned') and the last
> patch relaxes the check done when attempting to write to BARs with
> memory decoding enabled.
> 
> I consider all of them bug fixes, albeit the last patch is not fixing a
> regression (since vPCI code has always behaved this way).
> 
> Thanks, Roger.
> 
> Roger Pau Monne (5):
>   vpci: don't assume that vpci per-device data exists unconditionally
>   vpci/msix: remove from table list on detach
>   vpci: introduce a local vpci_bar variable to modify_decoding()
>   pci: do not disable memory decoding for devices
>   vpci: refuse BAR writes only if the BAR is mapped

Looks like you've lost Henry's release-ack that was given for all of v1
(i.e. only patch 2 isn't covered by it).

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:24:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:24:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429922.681274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLmk-0005AZ-6G; Tue, 25 Oct 2022 15:24:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429922.681274; Tue, 25 Oct 2022 15:24:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onLmk-0005AS-3R; Tue, 25 Oct 2022 15:24:10 +0000
Received: by outflank-mailman (input) for mailman id 429922;
 Tue, 25 Oct 2022 15:24:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onLmh-0005AM-Qu
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:24:07 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e79d111-5479-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 17:24:06 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 11:24:01 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6506.namprd03.prod.outlook.com (2603:10b6:303:125::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 15:23:59 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 15:23:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e79d111-5479-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666711446;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=hg3W6/4qqFM0NA8tanJ+geRPfeUzmo6bWcsqZaPHbDg=;
  b=dXVK5T8xBdNTY8nQGAEkxw+5Mq/2F31fjSNHJ0pIqo6hKcYKjW+CN/VM
   GQtVkOvnIHNHLsYKCQGoIxa3mpuO4WE9+sLWoi8rj8Vh3EiACGAYXMO5t
   PTi5swGZ9lgtcZnoIb2G3+wDMcldG1EPrHrr4l7ZXCipaJBzydWW0WVGE
   Q=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 83491442
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3A8jPezahvyrjapi3sGBy1fEQ1X17brhtd9Lp4u?=
 =?us-ascii?q?6ucsGZSdtCo9fiXrREDcFrAX2WIxW/j1+WfGzWLvwv/H6Du2j2ifQID4o8Ju?=
 =?us-ascii?q?2P6zlksR+abM4At7a5sNiYR7i4uhsItnFTuUsX/wzN8BJ2GtxSt1XszJr/cI?=
 =?us-ascii?q?ODWCayKYZdqMPmC3cCAlYY6OnreM4rqpxYTdGCirf80P3gj6rZny8VsK14x2?=
 =?us-ascii?q?j2iU4olvUjf+rGIhdYHRFH2EcfFnXWulGfLd3G9q155ZlsYxv1NlxwFcpSDX?=
 =?us-ascii?q?/FfONdiy4y1X3t75ZwtNpE4z7kXBjrVdVUPzlDJ31ljxK5pgbh/Su5Y/wmU3?=
 =?us-ascii?q?gK17YOdjE5HJ92gWVzIgDZkTlM75SM/QXSeC2Vlgha84vEz3MXf+574JOXxO?=
 =?us-ascii?q?eTFY7SyYCuLUd1VNbA+kAy5IiHFXAmsjat8VNQyRPkM7d3D9TzCdHIiPOyn+?=
 =?us-ascii?q?YF6RGFOI2UQKVaWZlXx80EhWO6jOS9ikQsH/vWGwDZwd5JN0hYMsbMLMX9Dq?=
 =?us-ascii?q?R8I2Cn0AqGmCtIz4CQZdTHee27Qq9+pFVS+hyu6YjR4A+vdHe8e/2kXA3jUh?=
 =?us-ascii?q?4yzQ4G+H0dVDyAD0yL9GL+HEt2UycyOLFiRSEO8/xlkKoWwoAsaosDK7ugT7?=
 =?us-ascii?q?kdoN9tskMi4Tg5TIsqNCiBLECOJ9rFZzgBoFG4oADQBRPiewx1Cqps5WZXzz?=
 =?us-ascii?q?WsodNthpSXlV/h5jgrf59fd8ro2h5s9ggoL2BUeEd/Tk8yWaM9wZneWD946R?=
 =?us-ascii?q?AMxhLoiHKAnenyK/jxHhUFHti5lbWEikbjqY7pKCEHlwb9q/yXERHx1oZyQp?=
 =?us-ascii?q?y35wBBXzkoZg7+jBHzeBMATqnYKPdj3fmiSAtrNQ0D64O6NkF+sM9S+qDYmx?=
 =?us-ascii?q?fnz/Nm5ElvkSoVD4hVokXKB60YUHcdiwHPxWahj50JEtpyHZQUkw4xl7BQQ1?=
 =?us-ascii?q?dannpZLb7oP2++Cfc0XQMSEdjg8C9/ljukwApkodQcuR79bW9wmLOW3/1sEG?=
 =?us-ascii?q?yOPA1daO6RRiDgq2jCuS5jrEDdV81skXUEVWyVO9yuiPUa8VWhxvf8WKxRxk?=
 =?us-ascii?q?X5U3iohFBHPNYb7UEBAx69iJbASrSuTF/6NQ3c5XFls3y4DD04EIU0yNTuRC?=
 =?us-ascii?q?mLailhBqhTO6+5BPH7hCK/ADOvrDNXZBdE2YAYSFiGJ9ieDa3p8mZLJL1gyj?=
 =?us-ascii?q?bUyANLiiwD/CEbcqrhCt6bBx+DS5cSszziJ/ukb7nONXde5WGfNL4VdBXndD?=
 =?us-ascii?q?gMidMoS+0gvVUns3KxAc4KSpn0HMyKX9CbrByhUOokuvhQmrIuiGMDqxUni4?=
 =?us-ascii?q?7XITieDN6ywb0wxqnke7JPL/56UxKwMP8ipJf2jZGnLITtXL233XfncBUqrE?=
 =?us-ascii?q?Xki4CryYHuaMrwfo97c6ozOM7s/DS8T2JBOguWmbkHE1Rr22sE9EDSqJA4ZT?=
 =?us-ascii?q?kpmdY/Copgr051qBJHirLPlK8ma/N+UfbxOVhJjwY99Y+M4IGfcpQ0veVNdD?=
 =?us-ascii?q?Ut+xlD5dJJFsdJwa5bdn80+oRK2fWU6EV4I0427prvbXaVVU6a/dKj+DI6MW?=
 =?us-ascii?q?IGs4igmnmqU1l4UYOsVpHiuoTmvGvXWfLh8e70rS8a+iG4YdZ3blvEmyDY2J?=
 =?us-ascii?q?glJKyE2qPFWu96BXCsXyHSLpXlQR243xTo6Y9nIC0gUjTfff9PBLxwLrWRcA?=
 =?us-ascii?q?Hwa1/3gLcK8LKR/uLe1oYsJRSBqsP6kt4+nH6D+lpFhJoIwJ40M+c8BJWPI7?=
 =?us-ascii?q?ZKu+2Kgk35riDr38JcOeqoLSWHmbiR3E8xbBheLlZNQW+ta3svQSD97pzveL?=
 =?us-ascii?q?Q/rauf9WGH3ye4AwisTF/zv7AlgPifKGs8GMntoSV1YlXuVUIqM/1FntefJQ?=
 =?us-ascii?q?G+fr1EkdhawQRbVe3tekrIstjjCPJmmfBYj3IinYzLzU60juqcSREjGIjRT3?=
 =?us-ascii?q?uZo+j6xFZuS/fzvBVeeMGdFIW5o3BJYnmv5VqeJIrtZHqNPiRkYndDDVUmoC?=
 =?us-ascii?q?U4dCVRywIxmbwsEIZUY7/GVfDMjSf4gzfsRD2WO5T9A0BVt2wJ2EsjE9tzZG?=
 =?us-ascii?q?1wiDcsntnldObZ+T0PE42UmmmfdQ2F1UhyiUyLTZCFbs5IbLqzeqB5z1XZhG?=
 =?us-ascii?q?HGcW9H6QIxvvd6ObmulL9zE+mEI4KhXHj+BJEMJ6h8LDV6UkNtmuKNHnuWy+?=
 =?us-ascii?q?IoJB6cNxXNsZy5PNL2qZbUNZMph72Kwd7I86c2yhRvqP1nRIj2RiTqL1IRpX?=
 =?us-ascii?q?pM+roKPT0MdjxWOjNavx2jSAmI3DbCxC8c26ez0aO054LG1PWI6MVAL/e78J?=
 =?us-ascii?q?D4FL6Es1PxmIn5UscQ7KKG/TQb55sYfOuUUUQgG3F9EQvzWcFyys4rz/Yaqt?=
 =?us-ascii?q?/TYM4UQT/tdWzPMKrxeSsZW7dBjC2haDbI5xleYtQD5S9cpjIrT9cdqgO487?=
 =?us-ascii?q?oKsxa3IbnhwavjG6sMRFDGQ/t4k1Y4tGLfdt/kWNjBmUuj3rL5uA52h7Scka?=
 =?us-ascii?q?k2V?=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83491442"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l0MsOL3oRIwUeCUuJOnZdrTe62kvEAM+9FysIk4VCJAU0ulZQZbh2EvB6IUUstA38BaDVsIX2xaA7NRogAlIT+0+3sYnRXAGaRRpbI8ansHaK794nLUCxFycNRAx7iy8HR/ws72Pk9/KHFhx5cwvg7/7kOASWYO1Vuj/wJrbxVVy+fHNeWWo8XlHC33csXLTAfxifrEzUwD5xLUfP9oTLZooAzQadfMdUK/A7d/H6Sq2KD8k7BJzNHfnsoCtRJoq9eRv4gQOQJ8pv08HBSeGvvb/Tfxzbq489QLGnvbIBm2VjL8fHaMnWpUUqy79eoJ+fx7/C6UUcqWJiWplWLS9rg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/88wvwer32U7YwhPNUHSKw72rNArH639qgiKLW7EDBU=;
 b=kN0tnVFCrvQdtODytCiIG71Ojqwh6YalRHFn17Un7UgHZqOQCo8jlSjBH0uFEMUqKhAABp/HnEyL2VMTQug6V5ODDiZeccFzhMuc0NF1wwVx/X3w37SXVgd75QI+YVp1XDoZoc3+zGnN7LrErlW91G/z8KcKJl9V/DqYcMyzqZJI1bRxdEWZ5/qTExtU6TAGKf9CrfSb2DjAYdHxPKe0AgM8lkSHX6Qp8X81n5K7TEfGsD9VhAMwbFfrJYZYa0DHxowyf1YN5mtjSGYnOSurT2Y4VarsFQ9uy6j1bS599Z8IAHCagYNFV4mZ/ytA+cQUdCJJRic2iFd62aoZRnP+Ww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/88wvwer32U7YwhPNUHSKw72rNArH639qgiKLW7EDBU=;
 b=l/hL0KyrSQzGoa8W0zrt0xbTtAyl0zVZnF4gwg2H+7dfpeotX3XmIO6Kl8u0/goX1exPJrwldU9OMuD89D5mfrIp9VBNT33JZwUtaia94v6IAVO+O3QHtmu4aCUJH4uYhIezLJ6ssSvvy5oxCHakFXLBRYLqsNKE+QLQpABo5z8=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 17:23:53 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17?] x86: also zap secondary time area handles during
 soft reset
Message-ID: <Y1f/iQaugcmhiP+0@Air-de-Roger>
References: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
X-ClientProxiedBy: LO6P123CA0025.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:313::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6506:EE_
X-MS-Office365-Filtering-Correlation-Id: 964d0480-cd56-40af-69f2-08dab69cefde
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hNL70W0EokkFumRR+Wz0LkazVVJ0WXIjzrDqCZtaxcNMoHEGaV8wpCJMJu/0mPPAqP0N7FL7QvlUWsVlq1nxnHeFnKmbJVwyMxXFmhEdLd2EzwyNgy59zdgEeydQ3oIzyS+Tc3hVifuu7U0lXYGhxu7d8Z79tgPEau/NEaVzqCC8nJZ7ZylfSOTUKowFOefA0AF9hZdFhzHG91+ZZ/LTmWV0fhvGePX2ix/M9J49Z9Z3/G4Ws+a5mv0MA3s9tQEHC5YxVGydae7KuR5xOAcEyt1PJx90BnuxhwJ1zt6B+TCy6aPy3+S2g2UWxsun7+vO1erahNEstcjqZZu/B0MlccXd/pFOiA+pKQpvBn8LDWMOJ8mriN80PmTJ2BIuTKv6ME2b3aC4BxfLsQ1Cry3oHqky/ShBOcFzK33eXkZQF+fCP5mVgqoIPiFL1ZiAXZ5QGLcL/WQ+3JW6mwlyn9dgmHymz8eq7DjXsDGVgSwExsu69yMifrEyQ2vdcyJMA2kKY4WYlNxE71TLnNfNXW+I3zbbXgButN3wXP8QsvGLHU6N9gGciwhBZdRmbYCjRkeopXykaM0t6yS3Hnimx1k5v8sBB4+01jW6bDJiEgQQvfA7plbwFT/l/XnX5PzH4SbDVFqf/yzpIUiq9Dy21SJed1TecEgn8gEYJj8z2eED5qHNr5IAxW5NclAALLUH+7zqQrOWYt+0n6uyu6OI6vM9BA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199015)(86362001)(85182001)(82960400001)(38100700002)(186003)(2906002)(6666004)(6506007)(26005)(9686003)(6512007)(478600001)(6486002)(33716001)(54906003)(6916009)(316002)(66946007)(66556008)(66476007)(8676002)(4326008)(41300700001)(8936002)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bHN1SkEyTzRlMXRkRTRyMzNqUHJ0SC92aHdLbGJYZXlwVCtvaGMyMlJsZ1ZK?=
 =?utf-8?B?R010OXF0U1NYU3dMa1pzUHJtWU1WejV3ZjRPZXV5YUl6dm9vNEwyTER2c1l1?=
 =?utf-8?B?bzZGdnFMTkxVS1JIVk95L21BUkNnVXZVM3BKTTloUHlVT1ZiQ2w3QkhiQXo2?=
 =?utf-8?B?R0lXZ2tMWVBuM28wZW96a1QxTVkrdDB3L0FVanp0cEVMWGNWZnAvaDFlRkpu?=
 =?utf-8?B?eCtmbzVZV0Z5eHJxcTNQdmU3WHY0eEg5OVNiVXB3bFB4M0ZPYTFWZFNUTjZI?=
 =?utf-8?B?d2ZSWTlGTEJqZFN5T2VjTllrWGw1MUxzb3I3bGVXMWRWVGhXMmxyRUxKSnFj?=
 =?utf-8?B?T3VDZ2svNTlpaGZwZjFjKy9VNGZBaXpZbEpEeDBndFhCVkp0MWhhU1ZHNUs1?=
 =?utf-8?B?b3RFQ0JOY3pvK29UL3QwMlBiK05MNGJ5ZnF4N1doZzNsb20xQ0ljVXpGNW5L?=
 =?utf-8?B?aC9oaFl0YzdZNGlsVHpnbGJaeTNCbUEvL0d2MXhXOUZ3RkgxQ3V6N1dnMnRK?=
 =?utf-8?B?Nkk4OUFwU0J5dEF2a2cxU2IzVWY0VWx4SktwWWpLWHZKbndpQmxNeTc2YWVG?=
 =?utf-8?B?M1Jic0FscUg3Uy9oOGE4SFlSL3hxS0VOdzI2R1I0OUdNZjgyR25jOHhjL2tr?=
 =?utf-8?B?L3NwNHlvZnB2UUdRSW05UGpwNGNKamtLSWkwOXRrTnYvVVhQQXlsTTlWOVB5?=
 =?utf-8?B?enZjZnFDR3I0MzVuUTJ2bCtaODFGNVhnRnFkVkEwZFM1YWlRb3kzbGVHZ002?=
 =?utf-8?B?TkhwL2tRaU05NWE3bUIxSWdjc2tpam5zc21JVi9uT3JGRDIxUUlGbzRISDhN?=
 =?utf-8?B?VGxtN2ZrUHA5dzRteG84OFk1WnYxVDk5bnptOXk0MDRQRVdUcnp4WTdOaCtE?=
 =?utf-8?B?dnlhdyszMS83a0Zlem8rUFI1K015a055MlZjbmQwc3NISFhiRmo4VHZacUR5?=
 =?utf-8?B?YzZBbm5UQ0JleWVNT2hKUWlkN0dXUk5EdTQ4aVpuOGpQQmg1cVJoclBwQ0NI?=
 =?utf-8?B?Wnc5NjJVMFdjTUplQUpkRTJtdDhQSlQra3Q1czFUM24zN01nZ3o2ZTFDNjg0?=
 =?utf-8?B?RWlsbS9ZR0VKQTZ3amlQM1ZjeHpkOU03OHBBNkIvZjZ6TnFoTmF6bHVnRXp2?=
 =?utf-8?B?WjJ0bWlXSGlGa2R6Y1I5ZzYrWnNWYm5QN1dTOERqMzF4MFNpaGdqR3dVWWsr?=
 =?utf-8?B?UXBsWllHQVVxdzF6NXZqaEFRbUdVVTBoa3VTSFNCd1piQ2hwWXkvamNBbnM3?=
 =?utf-8?B?M3RmYmViNG5uWm1mNXUyYjE4aWowVUZKTzMySTdYTFZhVmRjV2UxWDRKOTQx?=
 =?utf-8?B?UjZ6ODEvQ0t5bHptUlVTSkpwbkR3YWwrZlNJSGV3a1RSV0JpaHBvRWxHaUNR?=
 =?utf-8?B?UzYwZFQvZ3VFd2IvRm5DUVlaNEZoMlFZMm9JUG43SE5oZHZTNzVPSXMxVGFJ?=
 =?utf-8?B?dVFrTnAzSUg4VFJpa2RzakRJTVEvYUNYaS9yNW9TaGtTdHR4dnhMbnB3RzlP?=
 =?utf-8?B?cHdLc05ZclRJeVJYTWVDdEJ1cEdhYTI3ZENMNWR1ZlN4a1p0MlhZOC8rYjNW?=
 =?utf-8?B?alRub1QwTUZnVTZ3SDBYcDVZSFFoSnlacEp4Nnp0M2xMTFFTL0VjdGF1aExo?=
 =?utf-8?B?UWVpdmMyTnZVeTkwK2NKSUF0OHJ2aCs0VUliZUh6d3dCeGt4cHFVSnZLamRM?=
 =?utf-8?B?NENDaUthOHdNOUtoYVhUZU1FcUxrZnZyU25YMU5iL3BTYUh1a29PVXBVN29W?=
 =?utf-8?B?cUR5djZBalFKd3Evc1huZGc2UVo5Vy9PN2RGODMvclJuREJveTRqOEI4VjQw?=
 =?utf-8?B?ZVpDdFhQSEVOaGQ3WFBaTzV2OWVxU1JoNVhsanhON2w5S3MxMGpaZlIwdnRv?=
 =?utf-8?B?djcvSGxJeTdHT2ovNzR2eStwZ2pvdW43TElvaThYZWtCL3JNN1M3QW0wRlhh?=
 =?utf-8?B?NW1ValJ5Q2VVVWZnN1FDTmpDRXNTWDRmdGxicFB3U2pKbEZRUmt1ZGloTDBS?=
 =?utf-8?B?dmxaU1VNVFZxOEhOVENmYkMvbHBiZ0hINUtSZkVFRERoeTJNTGlheDhPamdt?=
 =?utf-8?B?T0c0ckpJQUhQMlZXVk1Fazk3eUlYa25oR3d5dXNGY1lOYzI1L09tcjl4c0xX?=
 =?utf-8?B?OUN4VTAzRE9aYlhjWUtkcUNOUmk0R0JwaFdpdlVTeGNGdmRqMzNaWXRDcys1?=
 =?utf-8?B?S2c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 964d0480-cd56-40af-69f2-08dab69cefde
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:23:58.9954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L55QP4jsYmQv4pH1PlWSYQ7lq9h0xs2/+XEU71oFhkd8p4QLF00Mgio5Lb67opXVSjwMrBVknh9IlNSrwCgQPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6506

On Thu, Oct 13, 2022 at 08:48:21AM +0200, Jan Beulich wrote:
> Just like domain_soft_reset() properly zaps runstate area handles, the
> secondary time area ones also need discarding to prevent guest memory
> corruption once the guest is re-started.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> To avoid another for_each_vcpu() here, domain_soft_reset() could also
> be made call a new arch_vcpu_soft_reset() out of its already present
> loop. Yet that would make the change less isolated.
> 
> In domain_soft_reset() I wonder whether, just like done here, the
> zapping of runstate area handles and vCPU info mappings wouldn't better
> be done after all operations which can fail. But perhaps for this to
> matter the domain is left in too inconsistent a state anyway if the
> function fails ...

We would need some kind of recovery anyway, so given the current code
and lack of recovery it doesn't seem to matter much.

> However, at the very least I wonder whether x86'es
> restriction to HVM shouldn't leave PV guests undisturbed if a soft-reset
> was attempted on them. Right now they not only have state partially
> clobbered, but (if the arch function is reached) they would be crashed
> unconditionally.

It's a toolstack initiated operation by a domctl, so I'm fine with
saying that it's up for the toolstack to prevent soft resets from
being attempted against PV domains.  Would be nice to reject the
operation earlier on the hypervisor, maybe by moving
arch_domain_soft_reset() earlier in domain_soft_reset() so that we
can return without crashing?

In any case it's unlikely for a domain that was attempting a soft
reset to survive the hypervisor rejecting the operation, so it doesn't
matter much whether the domain is crashed by Xen or left as-is I would
think.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:42:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:42:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429928.681285 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onM4o-0007q3-OC; Tue, 25 Oct 2022 15:42:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429928.681285; Tue, 25 Oct 2022 15:42:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onM4o-0007pw-KY; Tue, 25 Oct 2022 15:42:50 +0000
Received: by outflank-mailman (input) for mailman id 429928;
 Tue, 25 Oct 2022 15:42:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onM4n-0007pq-Dq
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:42:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aaf90c8c-547b-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 17:42:46 +0200 (CEST)
Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 11:42:44 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM4PR03MB6192.namprd03.prod.outlook.com (2603:10b6:5:39c::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 15:42:42 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 15:42:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aaf90c8c-547b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666712567;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=fWBhQuieNEHH8UlwKzAgP5MXhlATVcGoZMqweFSPHUk=;
  b=UmYweLKOCLEwfEroZSEWaLpoyqxQAybUrcXPESmQK1IZoyGJBy3cjW/C
   IhIWc2zGOBrNluZV35DHRJI85WNxfqeyxlKdH1bpEjr5Vt0J8onmnqgDP
   lqMO+aW7ijauHW8eFjT4xT6Ro5FHZAaj8Gye8jVHqQCFspnuW/ITUTpoy
   s=;
X-IronPort-RemoteIP: 104.47.55.168
X-IronPort-MID: 83466138
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:YUThK632W7jTpwaeI/bD5RBwkn2cJEfYwER7XKvMYLTBsI5bpzVTn
 DAbD26BOv7ZNzOnfdpxa9uxox4A7ZCHyYRhQVBqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlF5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUqp81UGXh21
 McXdg8zcUmshOGP8rKkH7wEasQLdKEHPas5k1Q5l3TzK6ZjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NpswA/zyQouFTpGMDSddGQA91cg26Tp
 37c/nS/CRYfXDCa4Wrerizy37Sf9c/9cK0VG56/39o1u2SKhWUyOgUdDmqE+cDs3yZSXPoac
 ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2
 Tehnc7tBDFpmK2YTzSa7Lj8hSipJSEfIGsGZCkFZQgI+d/upMc0lB2nZslnOL64iJvyAz6Y/
 tyRhC03hrFWh8hb0ay+pArDm2j1+MiPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu
 RDohvSj0QzHNrnV/ATlfQnHNOjBCyqtWNEEvWNSIg==
IronPort-HdrOrdr: A9a23:iM9PN6n9MpPH4o+SsIe4jA0U4aHpDfO3imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM
 tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq
 Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 D4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR8Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqXneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3GlpT1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYzhDc5tAB2nhk3izyhSKITGZAVyIv7GeDlJhiWt6UkYoJgjpHFoh/D2nR87heAAotd/lq
 b5259T5cFzp/8tHNxA7dg6MLqK40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd
 L6IRhliVI=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83466138"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WXaRcXc0r9l68ehayzgacWkDoLRFVKPVEu4IHvc+URNvFjmrbGAWz5GJ/SDmI44e8dGH0g7C5fO3msK1sS51HyE38JZ8ef5wBcdzyYzlksk0B/fC8IM/0J6ePFLBwQ8BJY0zh12n4D0uaWm+mMM8kEonzA72usBFLF+DuvnfeNREsnvxdBUlUOza1vXFY+Ax7pA1VrDYxh9neQcG/NYLUvJuQ2hu0zdQb803vWqPX82s80nCpy82K1orxstPNheJtjsKKYiJOPOC6S9RlujC+BWFZSN0IFtWxuB8QTQW5AczWWMjPS/vKzfUTA6AlWqmFZ2tDHxMiNn6OoZ/kJMetw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tzDEh4vH7z9yL9N9dgVx6VvWzaWaDIFkoSiaLBZVvbo=;
 b=VTPcLmCtwZDbC4VUB0L06uoNhPwYQksU2UrwEhdLZ7/L3QpqunGWhtqypkEK7P6tdDWUNdE6q86EjQU3kh26LRfUstgvL1mEtYPRNJkp/p4C2XGbZiHe/ZhyXXba1nI8IEBrGX27R7r/ZmlMCGywZP8D5uYPM6LbCEK4bYD4KFUW1fipOdLKJuwQnUzqO7XgsV3oJ3UKwrRArX2WtOXQIAzU2Bs+osDczlLqqAbIPVmyA+8EZ7Y+U9Hzb6UcPLjQzoB9PQLTSuUlC3/Hrgsc79FYofSgOf+S3wDi3x4i+CDhZCaXjBT/BqsVP3JQjS9gO5dlINxg9FBykGwPduZXMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tzDEh4vH7z9yL9N9dgVx6VvWzaWaDIFkoSiaLBZVvbo=;
 b=CueGFcn4GqhFKysGwX5/W3NAmaSBiJ7W8zRuQ0S+sBYEB/MAPS/VshCZIQwA+9jeqJjBc7EMkJ2/gxg8cOk7sATk5eqzPb0cpe3ktKTEzGga2hFdAYmG1q/QQOvaOxBuN7MQOr3OEJFzZuRYd5ih0e6ShORzLCI3xsIGkvWXPJw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 17:42:36 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] common: map_vcpu_info() wants to unshare the underlying
 page
Message-ID: <Y1gD7GmclguLZCM8@Air-de-Roger>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
X-ClientProxiedBy: LO6P123CA0019.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:313::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM4PR03MB6192:EE_
X-MS-Office365-Filtering-Correlation-Id: fbfe936e-0ca2-41ec-a96b-08dab69f8d7a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5mQoeZZHbjAjBbm9JEWYpfyiy1elD1W6PrtLxPTcanD4LMUOfXGaDsWzgR10OC98jO2YL4IV0vEHIsnbgFCXrpMLkvP2SjUcjYzezkmtUX1oJl7cfqDlyyX4GPyRQx98pzz9bnXEA5+CKQ6TpsboTPhPIlHhT0kVO6SUbxXukAp318yZ3s/H5OkL0PWrnsxDo6EQ9pkcZtlIDk90NS70cnfmsnwI0Wh4kZFfWncXl0cMRLW68YHlOiQBQ2iYnwcjg3eUiw1387gBfld+4fmDxXBm8PMZH+Ngb4WcVUcY3uDsVS8W2qmOdHlpYmnyZbIepcnZNL0ywUQWPk2UOyHGjdQVMUfNo5NFYelWp5eLDlFhpszoJqqHF6dcFWZD0l0JPC8y8LHAtxbtHDp2YNLWbjD675+1SZQy9oHEanh4tsnItlXpASY0njE5Zih4IJlzQ7vd24y75D0dpxknsvqhAbpJlcJZ3j8Ff23NAdHxNXUCU6LYhqcI/jnJGImtfa6YMBtxJIsTMcqh4W/xwRypAr852rwAGbjwTHY0SS312JLGP6YXgSVKQaaL5hew7DtCKaspdDsuYsnfKqAPht4LBFfo/xIlgyCdMrWqDwNzi95NdmLHtoyHDo2oY70HeFgfWjz+1e0xhKBlVC83R3qw/s1RNF2cB6oKHuknK+rOIFWbE5Z9Cv2PuGmvSmrkFkUKWeiCzVU9Ab5WjE02oGEnvA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199015)(85182001)(86362001)(82960400001)(6486002)(41300700001)(38100700002)(33716001)(186003)(2906002)(6666004)(66556008)(66946007)(316002)(8936002)(5660300002)(478600001)(4326008)(66476007)(6512007)(26005)(6506007)(9686003)(8676002)(54906003)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S2NEd21wZHdGUFExY2tOUk1JUzB1eGhDaHI4cEFQNTB1VkQzTC9JTGVKZWFo?=
 =?utf-8?B?c0hYNmtuaTdFd3ZNYXVyVU5hOWQ4bitUbjJ5VWRCaTE2YW1YZlZjMzVXNzA0?=
 =?utf-8?B?dVpsUU5WK0QzYUo3RDUrYU1nNWQ4OXFobXRFZWVUQWFGaEQvcWc3MU9BTGlT?=
 =?utf-8?B?UmI2NVJhcFd4SE4xaFByL0N0VXpURHpsdVRBdmw0UFdnLzZZa3kyOFkrWmZz?=
 =?utf-8?B?RHlXTGpGb2VpNnFtamhHZFFGVnlyMGlROCs2SUFkbzFadmRWK0EwYnJpNDNN?=
 =?utf-8?B?WmhONU5jYTVaWE11YnJuTkZPMzhic0Y2aUxkeDJONFY4cUtkKythSDE1TkYr?=
 =?utf-8?B?TFNMUXNwdDVVTFN3b2s5cENGUWNVS1I0SVo4UWY0eE1lWmRFSWRXbllPVFRs?=
 =?utf-8?B?NDliMk9VTk1hQ05vWXY3TFYwdjhkOUtyUHc5dU1jbTJ2QWlSQzlrc0haMS9B?=
 =?utf-8?B?S21ZMU1LNFBZOTB6TlI0d3NmOWl0cjE0ZEVyQ1FSdWpFeUpQNHowRFBTaW01?=
 =?utf-8?B?KzlpZXhYc1NFUzZ2dVdNcmI1ZnFjeXpJenB6eExQSlBZZXpoUFRBcVZWZWs4?=
 =?utf-8?B?bXRUWHZnVVdCNU0wQnVGMW1DS0hTdXJrR0Y2ZkwySHFpTFVNZllaalZ5Z2dS?=
 =?utf-8?B?N1ZGWVNwVTNuTlRyclo3TENobUF1TEFZTUFCSDRWM0FGNzQwckx5bjhweVZx?=
 =?utf-8?B?YmJlMkFQUW5hTEUxbUVyT0RuWHlnUWVBZ3Q2Ky9MeXRpb2JyQ3pFanVWRlhH?=
 =?utf-8?B?bmdmNVZKdWFVNTQzZEwydjl4bXhUc3YzckVrRGtGbWp6amZrbW9aSklaaTI0?=
 =?utf-8?B?dTRjcFBYa0FFYStoNllESnh3SW5OWitQMGhKVjU3NWkxSDY1ZnRGdTVKN1Aw?=
 =?utf-8?B?Qk9EVDFQN1UvMmZuZXc4YUYrVXpXc0FBbFZvVS9nMFQwOTZ6dmJBMkFESUZN?=
 =?utf-8?B?cG83Nk5jdFRjL2s2S2xtWXY3aEFTaUd5RHRlUkpMOThPZUpXM3RYUUk0Z0lB?=
 =?utf-8?B?dUFudFduekt5b2pDd2RBdmlzT0pYTHA2S0Y5OEJjdUI5Y0dLbU5lbStYMDNT?=
 =?utf-8?B?QmJCdC9TTHNjdmdPRzM3eXpOWnRGeCswUGZMVTBuL3l6SExxdmFDZHBWTkcr?=
 =?utf-8?B?ZjdZZC9ma1d5NGhMWmJ6Wnc3TUJSTlpLU2p0ZjJzUkJzeUF6M3FwOG9aOFhL?=
 =?utf-8?B?VW9MRW9mRGFxK0VGNlVyaVN6dngxU0lZSHhPUXNMMlRVRndnVi9nWVdHV3p5?=
 =?utf-8?B?SmJhWjlNcTdHSEVhWW9aZU9vSzM0dHhpYUw2SDRBZmZLVmh6NmF0emhqUlY4?=
 =?utf-8?B?T2tCRWUzajd3eW96eFp0RkQranhqZWdIMG03MGhRN3dFQTU0V2tuZDBlZ3kv?=
 =?utf-8?B?Tm0wQ3VvQVFKZG9tc1hDTCtXOXNKLzBrUlh3cnRjYjhwVHU3WVNzVVc3S3lH?=
 =?utf-8?B?aWt5Q2l1VnZoYlRxR05jUGRhZW9MenhhZnkybHNhR1djdnBtaDBjV1NiMmpX?=
 =?utf-8?B?b0J6N2RCdElUVjV5U1hSODFTWUl3MEd6WVB2TDVPS2Y5V29Za1lBekpSbGls?=
 =?utf-8?B?c0F0M1N5cDNXZ3luWnROUVErVW9tV2lkTncwMEpNTHVxdzlWbkpYR1p4SE90?=
 =?utf-8?B?cDQyZUZmbkNoQVBDK1FTUVdtZHpsQ3VlVEZJVnFaN0s0ZEwzRk9lZUtlZ1ZO?=
 =?utf-8?B?eTFpdmxEbGJlcnNwekZhM1liQ1VPSGJ2UUVobTVXejUycVRDemk2WC9wK0dL?=
 =?utf-8?B?WlhwazE5UmpBS0Q4UzRVME02RXhhdTNWS1hEcmVHei9YOWw5M21NOTBsLzBU?=
 =?utf-8?B?LzhmUjJ4c0liTWNlZ3FLQTVLakJreFRuRjAwb0dJTHJQdzgzR1JnUUo3R1ZI?=
 =?utf-8?B?QnQyYkZyNERxMStuTkE1Z1UrQnpnM0JtUzl0c3NreWVoWkZlSDc2OXpNd0lC?=
 =?utf-8?B?SjlKN0xWcUw5czZkeGU3c2NjdHhsQlZpcGFHYWNWbEhjQnRlcUhodlBEdHNv?=
 =?utf-8?B?MWtzM2ZIbStreldPOTdNNTFTczU4Y1p0ZjRRYXJ0SjljUlpseVZMbU41aDcv?=
 =?utf-8?B?UTM3L291RXBaMUJuTnNHYzJaeUJsT2IxSmwyUFNReFQ5RWpOZDZyK0szTVUx?=
 =?utf-8?B?dGVmQ3pQaXR3bU5zSnF6VnByR2hJQUdYdmZ3NUU2TVB4REZzOEY3eHRPTGI5?=
 =?utf-8?B?ZWc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbfe936e-0ca2-41ec-a96b-08dab69f8d7a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:42:42.1339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SHmFVFAXuGMYVQnl9iEQrq/RPwIagZ8iY8EfGiysFgOEnfr0i4smcY2c3dzP5kiWJISxR0U2sxPfvlMQkN1aQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6192

On Tue, Oct 11, 2022 at 10:48:38AM +0200, Jan Beulich wrote:
> Not passing P2M_UNSHARE to get_page_from_gfn() means there won't even be
> an attempt to unshare the referenced page, without any indication to the
> caller (e.g. -EAGAIN). Note that guests have no direct control over
> which of their pages are shared (or paged out), and hence they have no
> way to make sure all on their own that the subsequent obtaining of a
> writable type reference can actually succeed.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> Really I wonder whether the function wouldn't better use
> check_get_page_from_gfn() _and_ permit p2m_ram_rw only. Otoh the P2M
> type is stale by the time it is being looked at, so all depends on the
> subsequent obtaining of a writable type reference anyway ...
> 
> A similar issue then apparently exists in guest_wrmsr_xen() when writing
> the hypercall page. Interestingly there p2m_is_paging() is being checked
> for (but shared pages aren't).

Doesn't guest_wrmsr_xen() also needs to use UNSHARE?

I wonder if it would be helpful to introduce some kind of helper so
that all functions can use it, get_guest_writable_page() or similar.

> 
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -1484,7 +1484,7 @@ int map_vcpu_info(struct vcpu *v, unsign
>      if ( (v != current) && !(v->pause_flags & VPF_down) )
>          return -EINVAL;
>  
> -    page = get_page_from_gfn(d, gfn, NULL, P2M_ALLOC);
> +    page = get_page_from_gfn(d, gfn, NULL, P2M_UNSHARE);

I had to go look up that P2M_UNSHARE implies P2M_ALLOC for the users
of the parameter, it would be helpful to add a comment in p2m.h that
UNSHARE implies ALLOC.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:56:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:56:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429943.681295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMHu-0001Jx-0f; Tue, 25 Oct 2022 15:56:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429943.681295; Tue, 25 Oct 2022 15:56:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMHt-0001Jq-U6; Tue, 25 Oct 2022 15:56:21 +0000
Received: by outflank-mailman (input) for mailman id 429943;
 Tue, 25 Oct 2022 15:56:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onMHr-0001Ji-Vk
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:56:20 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e545d6c-547d-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 17:56:17 +0200 (CEST)
Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 11:56:13 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA2PR03MB5723.namprd03.prod.outlook.com (2603:10b6:806:118::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Tue, 25 Oct
 2022 15:56:11 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 15:56:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e545d6c-547d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666713377;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=qhDVEQCqv5MoZEpLjYCa+JM2j7X4cMiI1Nt8svj+FOw=;
  b=ZxDhrNk9aMAQFE2WaDupo7OUV80dmgJnBqoIcRx2gqtClOSMFQhAepjk
   Mfz9GkAUCo7cWCS27f1EaGaQ7lZtxIiRzIsQLudjIiDnDV5eEiqVAv/Uy
   yl6J9c/2u0cCG/TYPQzG6OaP+Qn5eurqOHAmTWPgI8QfS7wADQ0fQK0G2
   M=;
X-IronPort-RemoteIP: 104.47.59.175
X-IronPort-MID: 83092869
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ZmoSTKMQ8YO/F0vvrR2UlsFynXyQoLVcMsEvi/4bfWQNrUoggzBRy
 GMcXzuCO/eIYmGgfNx0ad608BkD6MSAmoVqTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v
 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0
 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo5WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ
 fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4
 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eJLcI/cNFIkJ3q
 9M5Mx83KRGPisOd+efuIgVsrpxLwMjDGqo64ysl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ
 s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF+RTM+vdfD2v7lWSd1JD3N9XYYJqSTNh9lUeEv
 GPWuW/+B3n2MfTPkmLUqCLy14cjmwvKR98yEKyHpsdrjVaBzV1KVjQMVgWC9KzRZkmWHog3x
 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv
 neLld70AT1ksJWOVGmQsLyTqFuaISEIKUcSaClCShEKi+QPu6k2hxPLC9pmTqi8i4SvHSmqm
 m/X6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHY1
 JTYs6ByNNwzMKw=
IronPort-HdrOrdr: A9a23:ep8W1qoPBjMAcxSQSLqrXcgaV5uwL9V00zEX/kB9WHVpm5Oj+v
 xGzc5w6farsl0ssREb9uxo9pPwJE800aQFmbX5Wo3SJzUO2VHYVb2KiLGP/9SOIU3DH4JmpM
 Rdmu1FeafN5DtB/LnHCWuDYrEdKbC8mcjH5Ns2jU0dKz2CA5sQkzuRYTzrdnGeKjM2Z6bQQ/
 Gnl7d6TnebCAIqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sP8f2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aiSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7svVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WjAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 RT5fnnlbhrmG6hHjHkVjEF+q3tYp1zJGbNfqE6gL3b79AM90oJjHfxx6Qk7wU9HdwGOtt5Dt
 //Q9RVfYF1P7ErhJ1GdZY8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d
 /8bG8=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83092869"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aJFLYY0WfGyJLqG8/M+Mf2qDYbG1c0dpdMF3H1d+MJhWtOzD0oOUGuUTLuFP8zX3iYDsffOVl6yYYY+9dFEdCdp2BbLS/UYUBl2ObxFdHNH6x5+334ZdHcV2bW7nx5ZUw7VDdSvchSdGJagTWoMIi+HaRP7+Mj5sVq5Il1xgZKtwpFiR4Rxmd/dP2tWs3GZh7XHULIJt3f3aDCnEREf5M5Dnjw8Gw4DKI/G5XXWHiqu8Raf8oCfr4VK1ZZhyIPkSq46+QNgx8bwKhC2dUOpxWOF6g6GBZScv0zMXO/B5miEePWr0WQz8qbJ9hXeSpaiJNyjpby8mamg8bfqxw1ex9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hZDuQFHlEQoie/vc/suoG/q8KQHPnYsiOMUIrMzgcAo=;
 b=gFbNKCR4Hf8/lz2jpryJd+BqLbhY7atZ2Jjh23oYj2Bl1mVMr0WujcnZ2FUPK6KXQk+q+ri+zQ27kr87XUQHwyJvNwvDpfjSaW0ylj4OJcZC+0FOw2I5AHCI6pEvDA2GuJKI6Q1ZeZZqxZLpXffvo/6L1/H6Ms4CRiOazKfNFe+oZWswo5135Bks+4hCHug8LPK3LFIQtv4SGz/0K5Ku8hBRfxWCp0xGQ/7/NJVD7OK2mkCuiO7LlipDogVliH3DLKcciwfVEvuTbqszh30lvxQPE9xjMTeH65ZZxsGxrE2EssZ1n7SN8JCeOa1w7vgPpW/96KvzuvYkQevQFnT5VQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hZDuQFHlEQoie/vc/suoG/q8KQHPnYsiOMUIrMzgcAo=;
 b=h+GI2eYRazEGLinpFc7JTzd3yUlIp86u2OB4FmGs5t7PYri5BQikiB+UVbpDiEXEdM+LL8TTera7pPqwBLHZuA1bE7IvpI2Kj/Rf9LXs/Ldnvhsd+pyl16z+Ekn+ggPXofCaE1N0fKweum0EmgbJywSyrYybWBxEH/y5+oD4jeY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 17:56:06 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Henry.Wang@arm.com" <Henry.Wang@arm.com>,
	Jan Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for
 devices
Message-ID: <Y1gHFmKzht0KYR5/@Air-de-Roger>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-5-roger.pau@citrix.com>
 <46a361ba-121e-a054-da59-512e0fb6eb70@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <46a361ba-121e-a054-da59-512e0fb6eb70@citrix.com>
X-ClientProxiedBy: LO4P265CA0211.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:33a::7) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA2PR03MB5723:EE_
X-MS-Office365-Filtering-Correlation-Id: 31cbbd66-5066-4211-a134-08dab6a16fe0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8e7Yn8yc/r+U4WOLxhRfMfaZYtz/OwTOHD4UEvtvjFKYO8XLRTeieccca1j7+1g0R4FRbxLqpuLcMm6GEsmlndMYbVmG/s/gD7E0Z++sDSPTDvE43jod5qkdLrtHHTbYrVrSu3snxJWh/NVACln4FT/DsujbobSa7xhMMIVEkXKNpu/G8GwW0QR7OGRqPe7etRFSxU5AKjKieJOPBAFZYShqh7Q2F2bbmMazmS0yV2Jyz2KbD1lPNb/+4oQrz/i4N69yJRtpMVNI8ZToDcsJJljZgmFIdqF0YMfAg2CIoYduW9v2AvbivgDNGYMrXVFWIwbrq78lnVa1amY6Gx+2OG6c/yRrvAZpmk/JqcSxGENIn4OMlFVGIhgtKlKLgxTizB+c3yXLMmoloQu7ImFH8eFfoRfl82N5cJabWt5vwmURWh7WwrNTYDfy9Q8bJoqUO3gn7PjtlZ+w2Ecjp38ABAhpU66XXfeXxE/FgP9q8Cyy+0KornWnj3gATQba0SHfCr1uF/B7dJ6jPoSBIsHLgvSrQ+TDnbolUHc1oar6VN4KU1F+KDnCAz1dU+9MSeguLWgGl9uJzvencq5e4SkvxIz0bjNzP2Oo79PdYa1mrZpqzoM2h1L5NjQJXFe/iUgUy3xh3rqvDwiMG6TIHSmR6Oz1TNcaJ0oWzK4FLAzk4r2LnWXWqXWQSSMy8Y5S4O/VS/zuc5XaqlEB6/vYOQKSug==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199015)(86362001)(83380400001)(6506007)(186003)(82960400001)(38100700002)(6486002)(2906002)(5660300002)(33716001)(41300700001)(6512007)(6862004)(8936002)(4326008)(53546011)(6636002)(478600001)(66946007)(316002)(66476007)(9686003)(66556008)(8676002)(26005)(54906003)(6666004)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Tm5wYmlneVM3NEpyTDNJUFFJUE9Mdzk3VHhvWlVUV2FxMmNYL1pjWVloRDE4?=
 =?utf-8?B?MmRtUERONmtTTndsUnp2QWp3bXZyb3lNTEhLR0R5dXB0NVhpRUl6bWhoOXZD?=
 =?utf-8?B?WW9idGgwSGdYTFptUVBBcDh0Skxvc1YyeS9OWWtJZ3QrOGdzRXZoa0JqS3A5?=
 =?utf-8?B?cEpnQ1QwK3RjM3YwblFUYythSU1WaGhEeHpUaHNjVjNBR2phdG9ZclBhZndq?=
 =?utf-8?B?WjM5aXg4bzNHYU1iZVJsWjg1R1RkZE4zRU5kb1RiMy9aNkFzaXdCSGxaYjd5?=
 =?utf-8?B?Y1lrdk5GZ0dYVjVMR2hCNDZ5YTdwWEZGc1U1NVRCSG5oMU04R3k0d0V4d1Rs?=
 =?utf-8?B?RGI5SlRRbGdmaXhZWXgrNzIrZzVJcm14TEFOdTcza21JL2VwenpwMVdMM1Bs?=
 =?utf-8?B?TnNOa0Y2ZWphUDg5b1dGMlNiaDdPM0sxc0FsYXdnV1ZRc3FqRXZtRzlidktv?=
 =?utf-8?B?Q0lFeG5jWkRhNm1uSS9LRnhJTjNBUlREUytSWklhRXpCcytjUUpxR2hyaVFR?=
 =?utf-8?B?RnB5Q0xNK3Q3STFobnMzcEFBVmEvWWRLZ1FYSmw1aENSWmcwUGhWRGREOHlQ?=
 =?utf-8?B?N1BpTVdNZE9aWEtKbjdzd1RjOThjZy8rNlc2ejI1SEVsUkV6OEhITnRmSXd4?=
 =?utf-8?B?TnZ1Y0N5eW9leWtmU1VZd3dGTTlFeWxvTUhobWdLUGZDOFVhZUltdTI2VC93?=
 =?utf-8?B?SUovWlhpNkpDT1NTWWE0VGFla2laS2lJaTUvQXNRVEVtcHgzczYvODlKU052?=
 =?utf-8?B?NUZLeWYrckNhS0VNN2dneFRmQUxQRGQyeHJHUUowTFNlZFkxZTBCNnZaTlNz?=
 =?utf-8?B?cVRPVGdFUVV2bXE1R1dHWmtEdWgyOVdVWC9ZV3ZHU203WUhVUHF3WTRLTVJL?=
 =?utf-8?B?cS9JSnI5TEJKMXBvc3N6TTBTQUo0dVFNRWJVQUJad3N1c3p2d0dkYlJ2RHI2?=
 =?utf-8?B?VXkwSEFaS0d3ZFZxVDNlNjRSRWpaanNYN1g5MDZ6dzVnNmR4STg3cDJ6Qm5N?=
 =?utf-8?B?N3ZXQThUYW8vZ2lmS0VwR1dYVnBtNjlaQmlseE14OEs1clpWbnlibjFObGhp?=
 =?utf-8?B?OEQ5Z2dZVXpWNW0zQk9uaVpPa1NHSEoyL2lDTDcyS2V3cWNUNCthalBkOVJx?=
 =?utf-8?B?WHZmYjcrM1hsRjk5bGNHSGg5Mm00elBFUVpsMkNUVEdINVRMMzU4M05CTmQv?=
 =?utf-8?B?VFNXSmdXRDVYUS8wblRRTllDVmY3WjRGQmV6Z3Y0b3ZKcWZUQmhMdmRjcWZS?=
 =?utf-8?B?V3dieDd2emUxb3M0aUxXTVZqTlF0eGs0VkdsZGxuZ3VJWElITzNCT0JBWWQ5?=
 =?utf-8?B?c0JGdnJ5bzJMdFlVT0s0Q3pQT09FVHZEeDdWWnNXQmd6akpYcC9mT2hpWFBK?=
 =?utf-8?B?ZEs5RXR1aWZTZDczdzM1VXVwakJMQlRISW5BMmVJVUhvWXhnemppTUYrR0tT?=
 =?utf-8?B?Z0llSUR1TnppSUM1THY1QlJVMnJZT1BjeStWUlJLbnZsYkgwK0VwUFBibGgw?=
 =?utf-8?B?aUE4RTJtSGU1TWg3eUQ2cWhyZXFUMzNqb21SUXVMRHlmNzlnNkttZ1JTT1dP?=
 =?utf-8?B?REJSVk5SZzRSeEw5bU1SUlMwSzFTSjAzaWxFRVN2M21iZ2ZZSitlUEZvNUFk?=
 =?utf-8?B?NUsyb09JSno4ZEtNT2xYT003czFwdWZiNXFvS1FaaVlTelMzTENWMmlqMDNM?=
 =?utf-8?B?U2lWdDZldGQ2SVdTUTl5bk5xd3FIVExVeEFjUnZVK0t3ZFZmN1VUcE4rVWR1?=
 =?utf-8?B?Zk1xa0tpaTN1SUpjdGRKT1QxNE5BeStkV0NRdkY3ZXVZUk5YdjdVR3h0KzEv?=
 =?utf-8?B?RzEySHRUN1RGZ3plSnlEM3NNS0Z2WWhpblJwYkNmcGJMRDljb0FQa3BBT2VK?=
 =?utf-8?B?Z3drRkFOdDBzWXBpNWRoTkJXbzJ6OVFRd0ZScUdtTWFtZ3BiWWNnNlozbkM4?=
 =?utf-8?B?UFZoRE9vOWNma0oyTXNnM3N4YlZQNEpLYWU0WWdIMVFEUTJoQjllRzh4K1V4?=
 =?utf-8?B?QVkycy9oYVo5VUppeTc1WWFLOGFHMk1hM1hraHBNVTRhQ21zVXpaeXA5cXpL?=
 =?utf-8?B?YVIzYmk1dU15d09IWGFGKzdTUndGRzBDeTRySnBsK1ZNVVVDSkZvWUdUR1U5?=
 =?utf-8?B?TVBCMWJROG5lR0QxajJvYVg3Z3E1eHJqVFdsR3cyeXlhVkxDUThodjc1QmZq?=
 =?utf-8?B?d3c9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31cbbd66-5066-4211-a134-08dab6a16fe0
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:56:11.5577
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ioquddsLDVWqfujB+nzu28DHkUva4M10MY7F6EMttwNLmbVtWdIX64kHjq/UYWt7qI1gOdJggp/0PwhszxSACw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5723

On Tue, Oct 25, 2022 at 02:57:57PM +0000, Andrew Cooper wrote:
> On 25/10/2022 15:44, Roger Pau Monne wrote:
> > Commit 75cc460a1b added checks to ensure the position of the BARs from
> > PCI devices don't overlap with regions defined on the memory map.
> > When there's a collision memory decoding is left disabled for the
> > device, assuming that dom0 will reposition the BAR if necessary and
> > enable memory decoding.
> >
> > While this would be the case for devices being used by dom0, devices
> > being used by the firmware itself that have no driver would usually be
> > left with memory decoding disabled by dom0 if that's the state dom0
> > found them in, and thus firmware trying to make use of them will not
> > function correctly.
> >
> > The initial intent of 75cc460a1b was to prevent vPCI from creating
> > MMIO mappings on the dom0 p2m over regions that would otherwise
> > already have mappings established.  It's my view now that we likely
> > went too far with 75cc460a1b, and Xen disabling memory decoding of
> > devices (as buggy as they might be) is harmful, and reduces the set of
> > hardware on which Xen works.
> >
> > This commits reverts most of 75cc460a1b, and instead adds checks to
> > vPCI in order to prevent misplaced BARs from being added to the
> > hardware domain p2m.  Signaling on whether BARs are mapped is tracked
> > in the vpci structure, so that misplaced BARs are not mapped, and thus
> > Xen won't attempt to unmap them when memory decoding is disabled.
> >
> > This restores the behavior of Xen for PV dom0 to the state it was
> > previous to 75cc460a1b, while also introducing a more contained fix
> > for the vPCI BAR mapping issues.
> >
> > Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > AT Citrix we have a system with a device with the following BARs:
> >
> > BAR [0xfe010, 0xfe010] -> in a EfiMemoryMappedIO region
> > BAR [0, 0x1fff] -> not positioned, outside host bridge window
> 
> This needs a bit more explanation (even if only in the email thread). 
> The first item here is permitted under the UEFI spec, and exists on
> production systems.  We've got several examples.
> 
> The second has only been seen on an SDP, and is hopefully a firmware bug
> that doesn't get out to production, but we should boot nevertheless.

I already saw the second on production systems, as is what triggered
the change in 75cc460a1b.  I might not have seen both in conjunction
on the same device on a production system.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:58:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:58:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429949.681307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMJl-0001ui-CI; Tue, 25 Oct 2022 15:58:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429949.681307; Tue, 25 Oct 2022 15:58:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMJl-0001ub-9W; Tue, 25 Oct 2022 15:58:17 +0000
Received: by outflank-mailman (input) for mailman id 429949;
 Tue, 25 Oct 2022 15:58:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onMJj-0001u2-KJ
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:58:15 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2072.outbound.protection.outlook.com [40.107.20.72])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d46fd3cf-547d-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 17:58:13 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB7521.eurprd04.prod.outlook.com (2603:10a6:20b:2df::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 15:58:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 15:58:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d46fd3cf-547d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gW8s4Die/PZFLnTMlWwnrjtwHN/rzRD/CyU+bP5FIe6EdAFXv67TuHIM5sSKX6kNJQ3R3lS3Rfv6WmzdoZEMkZW5Vw0lOJbrhwAYgOugU+iw/1seFKPHVqze8CXaVTXoMqidyjuzuRhKQ+eMjTpwj2Txy3wD0tln16+GaZeoLJ6Yj1LnMpEcHX7tFmb+hqy8c/MNcRpvgZaoA+AgDQAX8n9zR9fyv+Ps8ykabB4nuVKIiw/V8r9LnfycXYkLrO9cBVaIUuSkA5HatlyyGZkn9ebxhHfoTufisBxlnfu0WdAuQanV++AzlTJcasIlTn0et2VtB0rF3/EFwMdpofDBgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TRC46gAylqR+KERkvSuW4X0HQ7Hd1weNXfSpL0gBtG8=;
 b=oVEuT/nw1kR4NqIk7guabnypFXzK07FuRPf2rCqzlgSFSxM5DkZNliPbrsr28pQxcyi8v2ypjXj2M6jyviGYfPxV3e+fy/aszZvuvkalAxnCRxnYSZPj36e2njwZYHRDY0ixydgrSNNP3VW2Jlwb5TBVayv9SOC69SCQAZE49o3CVaRBxJDR5+Wrqz12Nj1adourF06UmmB5CQLBC3oo14YvZRkyBEJTPkGsi3oosLocIcgSHHnoN3lRy8kjfMBuLjzPxZ/NKuHLPxj3D2FUzHyupKuzlW5RaPBPPrvsNpUJkoNJxLmg+7LzA0Jph7Zz9FioibqFzXzO7lerbGi1nw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TRC46gAylqR+KERkvSuW4X0HQ7Hd1weNXfSpL0gBtG8=;
 b=50nMiNjtglULmIx9g1yXfEdm/UUm+XevPX0ywJPDiSgPQDIHfsc2HyLKwj23fpSfcxJTSQhiczZygqmpclxJiGKW6nZYJRTAS5cCD8GEbNtzCZbwrgS8Q5G3alxwqDJs+53a6H9AmmBweBtqgFMPX16GxfcCQRz7Lu+XTiWM0TEZyob+PdLIk6QzzGeQWGO4FhJNAR6V1AmMElqQCEHJ2sXRPrKnZK7kIDQjG3A19dyH7wt1n6thLKVHK1kqiGjT5qybV05iZ0MxA2Wi5qDaShtQzOR7PovGVDJNET2K+tTDxeR1FQTTx3t64fYx7MWgw5CTfDuCDLYsepS8USnBCQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <76d0ce3d-7c05-9f4c-921a-0c7e0f5d9348@suse.com>
Date: Tue, 25 Oct 2022 17:58:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH][4.17?] x86: also zap secondary time area handles during
 soft reset
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Henry Wang <Henry.Wang@arm.com>
References: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
 <Y1f/iQaugcmhiP+0@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1f/iQaugcmhiP+0@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FRYP281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::12)
 To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7521:EE_
X-MS-Office365-Filtering-Correlation-Id: a2afe673-d5a5-4b96-6ec9-08dab6a1b8a1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	h+ybTki+s3MjPRjlfQSdQo6njYwNrsNWqTlIdGH9Sim8MbaGX71pHeXPpB1cg64rg6mlerdy0iIbHmP9I3GMpstFhWGO4qMcTrbEfi71Y4ktDnptrJyqr1JMqnmGz2NteMN+a+4A+s49e9fTNMj3O2hkG0fq4m1NHuDfPVj6xgs4OWy4VN01jvlIaW5Ps2k3Z49SHDkIfPdqYJD48AzCb1VjGzWcALyvRj6W77GBC8M3m+YhzCwFwakWQawJByXm8FIcMfutKxkzpRnwlMWgbrGe91ii5bMcA+CGFsdg/f0g6GyflvTSAz5W+CxmNDGIFhnIcl6zT9oioeptgmjlYxri4cl2nRe0VKyLiJS6ghRyZ9wb2tjPQmjgUxhgBISK7eXQkHugCyT0ohhMbhOt//effHCh2YRCLlWJcF+HNayATDfW7aKlAQ7EvifMaeGuzpM0Xnetm+BM1wEv4nl5tykgplXFekV2ae/a3+Fv2czHa3M2rVLC18I3qTgtisS2oo7qsXprkrypqE+Y8OSfhyufPvjJ3Q4NJ5mtteeGys5eKuZLusY37KUGPpxfRrZm/wvXjGgGU15qTYQMM3AC9mHQZKHBApQ69gPqviYpI4Ayq7TA9pjTSHKKooKf6M1enzYmvyQFtIqJ5PDTyi1NQhKPEUpYy86/QMfUm7a8TVUhrB51qRGbWh2eKk1sSZ7OJl1fK0Llrg/wT1hLUkXvJxSaypiOzWTtfsgIwTkbWMD5KtkhgfmI5y666wNpZRij6AXZ7dGh7rhhK570KJnZmAeX1pNqth+vmlfgw57fyiU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199015)(38100700002)(54906003)(6916009)(8676002)(316002)(5660300002)(8936002)(41300700001)(66476007)(66556008)(66946007)(4326008)(53546011)(6506007)(26005)(6486002)(2616005)(6512007)(186003)(478600001)(2906002)(31696002)(36756003)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VVA4N0RoVW8zVnJTNnNVTEFNTWNHNG5YdDlqc25UNGtmeU1hSFdMTHpyTVJj?=
 =?utf-8?B?aGJ0ZVNwY3pubXFZc3lCd2xWVFIzSGo1QjNSTnZ6MGpiL1pwOFdwcDltTExx?=
 =?utf-8?B?SFY4ZDNmemdlWXlEZ1lYeGQ4RjdycXIxeGpmeW1TbFd0WTZPM2VZaEdyN2I1?=
 =?utf-8?B?RkZoR0VidUt6a2hrK0NhV2hPZ0pPUGhPS3NmN2FjYmdXWm8vRU9ndFBaZ2Vk?=
 =?utf-8?B?eUhOaTUveHE1cVhycnZ2bU05TlNjTDMzWWs5K0REcGZ3YmtZYjU0SENrS21I?=
 =?utf-8?B?K2pCdTNIcHNybUtNM1RxRlEvcmpad3k2c21QbHRXN3dRYXBwZE5IRTE4a1d3?=
 =?utf-8?B?bmp1anpsdmVPMWViSmFGWXRIOXltRTZ1UEpRUWQyQlJpWnFnY3pvOW1ZRUZV?=
 =?utf-8?B?OWYzanZxeWJINWZ1M1hKNkdtbkxHbzlBV2p3ekhzODVmVjZ3cGtYaFZRV3Qz?=
 =?utf-8?B?cFhaK1NWdGcvb25IZ1VNWHgrOHF1d3JTY25LMmhscVU1Q1FhQnRaUiszVDJo?=
 =?utf-8?B?VGIzelRvaHRSdUZPRVFmQnRVTjIxUzBoVWl0dkRRWkE2b3A2d0xpc1JSejJy?=
 =?utf-8?B?Z0YyVFE5VHMvVm1qMlBHN3RyZEE3YTRuMHlIS2NyTW1vd3pHRnpCZGV0cnl6?=
 =?utf-8?B?UzVqVXNmVEZPS2xxMjVxR0ZaTnF2RTJpN09WbEQwaDZvTE5TZUp5V3ArckJh?=
 =?utf-8?B?VVkvK1lURXlQR2tUdDZkV2VtaEdCckd2UTdqSG9WVjBiZG9JYzdsTDlJd01K?=
 =?utf-8?B?N1hSZlJzNHdXbGFqREFRbERpdk9qR1RnWUZyOVhwYXZZZDAvcjI5ak9jTk1t?=
 =?utf-8?B?emhWNC9HREx2ZTgzWmdQSWZPSklKeGJ3R1JFNWpjRjFrK2I1MVRQY3M2ckNs?=
 =?utf-8?B?Q2FjV2hvL3BoVldUZ0lrc24vdk9DOXdTR0JSVmVYMmhjNFJFbHpLVTZraWFZ?=
 =?utf-8?B?TStXSDcvdTdPR2xzY3h2TnJNM1B6OVRSWUpwdWRGWERXYTVkdkNtN0pJMlh5?=
 =?utf-8?B?MklZaGZ2S2FSQUtWdU9NSDZ6OTJWY1I5dWVOSmM2eURDUDNuM1QwYXN2eFdP?=
 =?utf-8?B?NUtpeWVrWlVKZEFlcjA5czh2UitSRlQvaDlxK0FxdTRSdDVQSDVadDZxSkE0?=
 =?utf-8?B?WU12ZkNJcjFrYldtUjFuTXhuR1REUGxXTUZ4RFB6V2lhZFFOS2hSZFhTYUVZ?=
 =?utf-8?B?NjJ3N1lKVGJYcVlOelM3TFZuMmR2NHpQVDBheHNqSTlnYWFOZ1JxZUc3emV0?=
 =?utf-8?B?N21nSXR4U09oU1FDUzlkZUtKK3hISzVFdTJGSHFQYndkQUZNRVd2MEhacCs1?=
 =?utf-8?B?NUVkNnl0YlRiZkNnMnNINjFaV25UZ1NURUV4VzdKN1NnS3IxbUFKck9vNEJx?=
 =?utf-8?B?NlB1U1dOTStJenh3andjbVZ4ZnR0T0piTWRtcEwyKzRhQThkVFU4Y2V3b2R6?=
 =?utf-8?B?UExtTDdmY3RVTlRaRmhKcVhUeC9NZjNRbUl2cUxhU3drYmRneEEzc1RTYlJQ?=
 =?utf-8?B?NEJEazVZbytDazF0WUhOQnBLZGQyTGNSOStDR3lOblU4eDZVemlGWVpiMDJj?=
 =?utf-8?B?a1pvZVJuMzk5Q3B5WUlPdWdjc3pNTUpaazBTckhHdTR2MXMzZ3JSaDJNN2Fi?=
 =?utf-8?B?M1lBUWtYOTBqc1FQOFZSWUh6TGVjZjVIUHduMGI3Nzh4R3M5aUg0NWxHNzM1?=
 =?utf-8?B?enl0TUpHM1NpNkp1UzhMb0VuS09FUDQxcUhZdlRqWWlQZjVOeVBLM3dFZkVG?=
 =?utf-8?B?VWYzRkkvUW5UM29nOXFjUmFWcWlUdEFSWFZzRmYvRHcvNWNxT1dJNVFJUDZV?=
 =?utf-8?B?dXNzZFdramFzSDlrUUJkOEVBak5nbTBrTzE4S0NUZ0FkK1c3Q2E5N2cycXJn?=
 =?utf-8?B?OGc4d01qWjJ2eDJ6ZEdwZGNjUkU2bFIyL0F0UlpKcndrUlNOR1lnajJnbWVF?=
 =?utf-8?B?QVkvdWpuY2VuT3FZSjh1RTNMMC9IMUlkdUFmZS9uZ2lGL1NnaEUyTDFVNlRW?=
 =?utf-8?B?dlRKV3dHVHNLb3NBM2Rma1pMV3QrTFIrWkxuYTBWYmJ2clJDK1I3RU1KcUFp?=
 =?utf-8?B?UEQ0Q25zeUlTUzlZUHlxRXdHMzUzOGZQbUh6ZHRGQk5heGcyU2xEaW1jZ0Fu?=
 =?utf-8?Q?+bDiP9ilTKSX/lDZFGTGmliHB?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2afe673-d5a5-4b96-6ec9-08dab6a1b8a1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:58:13.1017
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jQABtt5rAuElLcypgQNdOENqjin83bA4YJZO4ACS/w2jIxie66rd8QVoJxeVcraKCVRsZ5kFzvb/gjHi/uHPzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7521

On 25.10.2022 17:23, Roger Pau Monné wrote:
> On Thu, Oct 13, 2022 at 08:48:21AM +0200, Jan Beulich wrote:
>> Just like domain_soft_reset() properly zaps runstate area handles, the
>> secondary time area ones also need discarding to prevent guest memory
>> corruption once the guest is re-started.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

>> ---
>> To avoid another for_each_vcpu() here, domain_soft_reset() could also
>> be made call a new arch_vcpu_soft_reset() out of its already present
>> loop. Yet that would make the change less isolated.
>>
>> In domain_soft_reset() I wonder whether, just like done here, the
>> zapping of runstate area handles and vCPU info mappings wouldn't better
>> be done after all operations which can fail. But perhaps for this to
>> matter the domain is left in too inconsistent a state anyway if the
>> function fails ...
> 
> We would need some kind of recovery anyway, so given the current code
> and lack of recovery it doesn't seem to matter much.
> 
>> However, at the very least I wonder whether x86'es
>> restriction to HVM shouldn't leave PV guests undisturbed if a soft-reset
>> was attempted on them. Right now they not only have state partially
>> clobbered, but (if the arch function is reached) they would be crashed
>> unconditionally.
> 
> It's a toolstack initiated operation by a domctl, so I'm fine with
> saying that it's up for the toolstack to prevent soft resets from
> being attempted against PV domains.  Would be nice to reject the
> operation earlier on the hypervisor, maybe by moving
> arch_domain_soft_reset() earlier in domain_soft_reset() so that we
> can return without crashing?

I wasn't sure about moving arch_domain_soft_reset() as a whole, but
yes, if that wouldn't cause other interaction issues this might be
an option.

> In any case it's unlikely for a domain that was attempting a soft
> reset to survive the hypervisor rejecting the operation, so it doesn't
> matter much whether the domain is crashed by Xen or left as-is I would
> think.

I'm sorry, I don't think I understand what you're saying here. For
PV I'd very much expect the guest to survive; it may of course then
be crashed or destroyed by a further tool stack operation.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 15:59:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 15:59:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429953.681317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMLJ-0002Tf-Mq; Tue, 25 Oct 2022 15:59:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429953.681317; Tue, 25 Oct 2022 15:59:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMLJ-0002TY-KD; Tue, 25 Oct 2022 15:59:53 +0000
Received: by outflank-mailman (input) for mailman id 429953;
 Tue, 25 Oct 2022 15:59:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t1VE=22=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onMLH-0002RQ-EU
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 15:59:51 +0000
Received: from NAM02-BN1-obe.outbound.protection.outlook.com
 (mail-bn1nam07on2056.outbound.protection.outlook.com [40.107.212.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e1f00ad-547e-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 17:59:50 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM4PR12MB6397.namprd12.prod.outlook.com (2603:10b6:8:b4::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 25 Oct
 2022 15:59:46 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 15:59:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e1f00ad-547e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TpeVi+50FmrkXED0Rn71IsDBCpmYLonoHRSFOomF0pBEruzOpjXS1nZ8IlXeBKcAMoKqPDKFSVEqdcVCkUXNLpA8Yg3phxq0m/FTm3Ea/SuduGvKpBA9sHr/M3Wu7By5lbjfxsB3pLo/gjALYIvLo7ESNu3xaNQ9FkhQQkJRYhlwuvYQTPhqtGbD8nZBh+C2Idy/eM1L4l6rKKLJa/O+gOYmCk47Odcr+gCz6k75jsqnerJA6cE+LWvP7+gE5R/P8SsqqaRbk5lYjylKWqWYbKz39niXY93dPGr0Q/9FEJl898weDQCtER5+lhx/w5hPJQQcV1rkOdmtIR/C7xAGBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TCQKQzD5HwavRhiH24ue/a+nJT22VYAuQrHCwGp/X5o=;
 b=koOC/5iLi2q8zjCJNTNKC22ZDdCJnz00YEFGGSMM61g+UayE1C8p6BpVs1CwaVufGK3Nyq8klrqQSvGqRe4LzTyZlGMOB7jjuulbHC/CV/gYiAS5AIcB9I93Ujd+S4MZgnEqiXm2GgCbnR6pNjAvg7hpWI+ND7GvMgke72BnHqxgA4A+rCI/xfmJmlEhMMcx5A58W7phQwMT/5oBh9PnfZwuYtjpmrDQNwBuU3CtP+GTCIbYKGZEmSxztt6q4fPRO4lmspj7InhRqtMTKVzMQUY/xchClQNVYeDlqRW/Ss+lZ1SWTfaq8gPtb9ahKat+gcleiY9Uf5RUffG+j1p+0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TCQKQzD5HwavRhiH24ue/a+nJT22VYAuQrHCwGp/X5o=;
 b=p7atjMIeZWTeNEJra4WorITOB2xbQWC2ifkQcvQB/RSh8Q9y9R376NT9XvLZ2tlFKak+YCG5+7tr9oYYBuTtBzNjoyJo+rHV+wZ3lm7kCVfUNd2EA5jIBwjyrtXvOMlEt9j9PSo0NhWyIxWYp+9uNg2eM4m2FLlkzvGMYPwTvpU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <6799b845-08a8-3f4b-1695-d4d198833636@amd.com>
Date: Tue, 25 Oct 2022 16:59:39 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 03/12] Arm: GICv3: Enable vreg_reg64_* macros for
 AArch32
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-4-ayankuma@amd.com>
 <19fc76cf-cdf2-0321-8336-7c5a7fb09406@xen.org>
 <e952fcd7-bab6-68ed-d884-6505e529a073@amd.com>
 <b0b4fc69-3da3-3229-77d9-9fe0f4bf1ec3@xen.org>
 <a27873a3-3697-9a67-16aa-f4340dc622aa@amd.com>
 <e083c3c3-3978-4339-ab5b-030d32d05325@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <e083c3c3-3978-4339-ab5b-030d32d05325@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0383.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18f::10) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM4PR12MB6397:EE_
X-MS-Office365-Filtering-Correlation-Id: 172ee128-0ea3-4b89-5454-08dab6a1f01a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	M4eGCMfEoGK5lZGWotEUpsiXxdesHJwRE3dLWdApSRSdDiaktBvNnq59sZI5fFe3eBUOoSqW6kkrt35B351uZyhhFYOnsKJ8pHCqwQ+En/NkAaQrm7qdVgx68/Ew06+h7+EDrWO7mZ+RAu51Uv5UhFUlsLo/08fCegi4HvI1w2lseGpmj+CPzRxr+2fKmed6YmXRsyWzVE1/Vcmy4xi10W8mXr3+WVn6CpEb+vYdzFxC8Mb2Li/zjwXZSuJ/lZP2MxMkBADY3aA1PYbMOI+fv9BUF2K/itH2LZSsLLD3wV4++w8T/3SQ8LFsIyNg4DcgFN3xqCYzHDbJYRXGeryrtIffbbet3wTTze35RdE4CuxSomHblTKgsk88yCL8h8WRqRTG09s8ltaZbLgy91vm6w+EZ8+oWkH/zyuwRzYTgBugs8vHmc7jdss7kLrGDWmC/krDEIVFXWqusuR0by/GoCgkv/CgTWKZwK0162K02VFOX9PtZGJLPMXKo7cCuldaFTbNdWV+TYwcmeKwILmA4vwwbyv2wsVcjYxLwcA2sZkI8bauzYeesA86+mjEbJ22DK0mBwlrfy6x3RkbSwHol1Dx0zwP/APgVbtVNiW/z73Qk4Nqne/S7PvlO+PskJYmWKWNkBnBFKbG01pBObws8+hep2jJltFjFWuUqnV/iMoMvjMYu/kfzFOcS6DIgi6PEIRc1r1JP/9REH6C+Gh83DTR4h8y6TxGHw61hI1DoRCA33I0hT2XX/7uFUYIR6dLFx8ZUU5su2M6dVPpJbX10aNPH4h0Sb+u91khlCgX8co=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199015)(36756003)(31686004)(38100700002)(4744005)(8936002)(5660300002)(186003)(2906002)(83380400001)(31696002)(26005)(6512007)(478600001)(2616005)(6486002)(4326008)(316002)(66946007)(8676002)(66476007)(66556008)(41300700001)(6666004)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzBrRkVVSEZueUtXZXNReThGVStJUkVRL3ZFT09XZG1LZ2t1dWVlWmJpMm5z?=
 =?utf-8?B?K3dRY1pTQnJqa01iemorc2hhQnpKSlhNdXQ3azN5MkkreEZSUFdrMU9CbCto?=
 =?utf-8?B?a2k3ZWoyWHR2RU1XNUxQT3ExZW5zWDQweDI5RzhUSFpEUXR4TXBSNG82RTUw?=
 =?utf-8?B?Z2ZDeHNzLzZxMkZJeGI5UWoxY0NWRjJmRHA2UHlwWEZEeW9WaEs0cDFPWHk2?=
 =?utf-8?B?QnM4OUpBckIrK0U3OWFDMWRDeHArd05CdDhDVXVTdWx2aUo1VEZXLzFpL1BH?=
 =?utf-8?B?dXhkcmZMZHQwTUphUUdoZjgyR2hPdFdMYWlGKy9KYTViRUdWRitjM2pIU1li?=
 =?utf-8?B?cjBjeTJ4SDcwaExvNUxTZ0c4SEN1QjRSdzZlVEhCbzFZVXR1cVp1Q1dTUnFv?=
 =?utf-8?B?dUFlYkNlTE1ickF6VVIvYm54UWZFUnFkcDREZUozcTgrdnlLWnYwbUxDYmpi?=
 =?utf-8?B?UEhNbGxOQ3Zpd2ZqYVc4WWl3WWJ4ZW1SZ0YzZ09HcHFndUcyL08rd1dJOGth?=
 =?utf-8?B?VExHbEQzZk84K2xyVlFuZHg2RjI4NHhZUW0ySHQ4ZXYwc05CUFR6ZE5JYUVB?=
 =?utf-8?B?bUpoZy9yM0wxMk1uWWt4VUUwWklUWmx6RjRKVDBvako1ZS84MS9PRk9mekdN?=
 =?utf-8?B?dW5uU1Erd1d2ejJlVStZY0NrdDNpNm5ZUDZ0WVRyaUxNbFVmQ2d6QTQxOHdw?=
 =?utf-8?B?ZkxYcXcrbWxYbVJRVzVaelVOelcwSUFuREJGMGxPMzFZb2lIRXE0cW83bGNh?=
 =?utf-8?B?RHU2RDlvV0I3L0JGTlJBdXBQZGV2OW9kVXJiZHRPeHpyRW1TNHdLVEp6ZHM5?=
 =?utf-8?B?SUhIdm15K1RpNXhma2JWS3ZORWI3aDI4NFU1QVA4M2xwNENyZ1h2U2hzMDNv?=
 =?utf-8?B?aEFjZ0dIdEg1Z2xvdzgzQUVZbEgrcDJFNllEek5rcy9EZjZNcTNYNjZuNkdm?=
 =?utf-8?B?L2kyZCtFckFCRXI3cUIvK2VVRWlNWU93MndGcmVpSVRMSThsYmhMRDIvM0RZ?=
 =?utf-8?B?bmorczhPS0tMeGpRbWt4QXVFR0JxaU9HQnVkOFdkZy9nNDBhYXpBQmFGT2R2?=
 =?utf-8?B?QkFaK0tBWmY3V1Bja2NTd2RSN2pPN2JudUhMclhrcnN2cEUrMzYzcUNMVUFI?=
 =?utf-8?B?VTVVZFZ5R3k0TnNDdzczOFFQZDlrMmJ4SmNXNWFQK0JuZS9YeXl3RjFSRzVD?=
 =?utf-8?B?QjR0MDRhSWJBdUxhR0E1ZHErUVZNYXpyN1lINHpveWQ3SG0vUWtabmFkc1pE?=
 =?utf-8?B?NEU5bHJvVU16K0lDYjZnR3NPd2l0aWZaTTVwV2RwZktKZW9yNStJRW01TUd3?=
 =?utf-8?B?NitRMEYzblkvV3RRV2dWcnJpY0xkYisrSStrdWRkRmNINHBjSXhyOUd2Y3I3?=
 =?utf-8?B?RWtRVnhUWnVUdUpvUCtmRCs0TkJTaUhsL3lBUll0dWRqYnpTL1BMc3pnck1u?=
 =?utf-8?B?bUZVT25CbFVJMVUyM0ovTlBzZGFocDA0R1Nha3dKWHUvOFFZM3pZZ3BsNHNw?=
 =?utf-8?B?aS93eWxveFZ6bVVLY0ZvaG02b1NHQStoL1RTTHlTSVRHaVZvVlNRWmczaDEw?=
 =?utf-8?B?UVRQWElMNy9GcE1KanAyZ2V6YU1yM2IwSmVCeitucGdQWmZBTWpCYUZDdEsx?=
 =?utf-8?B?V1QrbnQ2KzFGZ3pIR09ub2ZTUTFpNEFpYWNPRURmcUkvdk4vWmJFNmJ5bmR6?=
 =?utf-8?B?VjFDRjAvZldXSHFlcUxjb0Z3VkRBNlM3a1NpTFRGUEN3WVdsWENoN3puYUda?=
 =?utf-8?B?ZzM0bnJGUHA3TFpEUlh3RTlLK2dtWVdBT0phSElzRTdFKzg4engvWjdmVnNW?=
 =?utf-8?B?UCt6OXpPSTVDMDI2R3A3bzNTVWszaHJ4cUVWNEZEMlRFYTZIVXlWL1laY2RK?=
 =?utf-8?B?ckdDN0g4alJ0UXZrUE1hU285Vy9rMlJ2aUNjN1d1blArRDZaMGdqZ2FEdU1W?=
 =?utf-8?B?aHhpKzh6cmt2KzRIZzFQazNYUlNrdkI1QlY5QmtCWFlaL1N4OWN5dlZmZHVD?=
 =?utf-8?B?ZDBWR3RuRGpDQ1gvdmUzeUY2bFNKdFdjVmMzNmpIbHQwOHk5QyttbXZDb0g5?=
 =?utf-8?B?S2tnbmhTR0xvWStjL2NOVDhjRXZQRUtkODJ0QWdMc2ltc2xJNUNwVDlDRHVq?=
 =?utf-8?Q?wD3pjoW3rJLcbwUXdOVLWYXQM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 172ee128-0ea3-4b89-5454-08dab6a1f01a
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 15:59:46.2781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D9ywPWxFG7lXh0S/FqAZ+uQoIV3oDGgrbS4Zxv8xI/bmO6BUYQrW8CC7ZIgeQwEvClocHQXbmcKweYJ3QkI8zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6397

Hi Julien,

> static inline void vreg_reg##sz##_update(uint##sz##_t *reg,
>                                          register_t val,
>                                          const mmio_info_t *info)
> {
>     uint##sz##_t tmp = *reg;
Drop this as we don't use tmp.
> uint##sz##_t mask = VREG_REG_MASK(info->dabt.size);
> unsigned int offset = info->gap & (offsetmask);
       int shift = offset * 8;
>
>     *reg &= ~(mask << shift);
>     *reg |= ((uint##sz##_t)val & mask) << shift;
> }

I think this is correct. Except for an improvement (as above).

Also, we will always keep this defined for both Arm32 and Arm64

VREG_REG_HELPERS(32, 0x3);
VREG_REG_HELPERS(64, 0x7);

- Ayan



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:00:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:00:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429958.681329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMMB-0004P0-4W; Tue, 25 Oct 2022 16:00:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429958.681329; Tue, 25 Oct 2022 16:00:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMMB-0004Ot-1c; Tue, 25 Oct 2022 16:00:47 +0000
Received: by outflank-mailman (input) for mailman id 429958;
 Tue, 25 Oct 2022 16:00:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onMM9-0002RQ-Sj
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:00:46 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2df8e3ae-547e-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 18:00:44 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 12:00:41 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6745.namprd03.prod.outlook.com (2603:10b6:a03:408::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Tue, 25 Oct
 2022 16:00:39 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 16:00:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2df8e3ae-547e-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666713644;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=uSJCBLPy4vtztfrhAPbsOyoKL9nzetq2PZRgZj1/ldY=;
  b=ZsE644h82ITjt7+UImmnLp03v2l3Vip4S5+oUpZemcVet95J426ttbK/
   oL0Bnj83MitpVFBLx92Rj9xawH4n9rMInuT+P6yGw7ewRTPy+8FVcv0Qs
   Xww6Hp0IktLu38gTLTKv8f0E2SiZuhW9/v203UxueouD1qK+VZ1b/pj9D
   c=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 83093316
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Mw2qC6kTLsI+I81OJwnLU93o5gywJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIXWWCHafvbMWKmeNx/PI+x9RhSvcDRnd9kGwI9qn83FSMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfGW5w5
 KExImE0Qkqdobyu+YmFcdZir5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KklwZPLvFabI5fvSQQspYhACAr
 3/u9GXlGBAKcteYzFJp91r83beexniiBur+EpW95PhPkGy23lUqCSYuUH6Xmdm/km2HDoc3x
 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ua5QeX2+zr6gCWLmEeS3hKb9lOnNc/WDgCx
 lKP2dTzClRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85i8jVf5mGa+xy9fzSTf5x
 mnTqDBk3utDy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1
 EXoUeDEhAzSJflhTBCwfdg=
IronPort-HdrOrdr: A9a23:v+YvW6Gl8g5XVzTPpLqFDZHXdLJyesId70hD6qkvc3Fom52j/f
 xGws5x6faVslkssb8b6LW90Y27MAvhHP9OkPAs1NKZMDUO11HJEGgP1/qA/9SkIVyEygc/79
 YdT0EdMqyWMbESt6+TjmiF+pQbsb+6GciT9JrjJhxWPGVXgs9bnmVE4lHxKDwNeOAKP+tPKL
 Osou584xawc3Ueacq2QlEDQuj4vtXO0LbrewQPCRIL4BSHyWrA0s+yLzGomjMlFx9fy7Yr9m
 bI1yT/+6WYqvm+jjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHffWK1RH5m5+BwlquCm71gn1P
 HKvhcbJsx2r0jce2mkyCGdqTXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t
 MH40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIeLH45JlO01GkbKp
 ghMCmFj8wmMG9yLkqp9VWH+ebcEkjaRXy9Mwg/Us/86UkkoJk29Tpa+CUlpAZwyHsMceg62w
 36CNUXqFhvdL5iUUsvPpZ0feKHTkrwfDnrDEW+ZXzaKYBvAQO8l3ew2sR82N2X
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83093316"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l6Z8bXRHytt4AaSh0HyPA607/0nT9QCQMsx2jgKLurMGt/XBUY03OhDS+D52PGCeAGpVSrX7lGyHyp04BrqUNKQgw0eSI05jjvUUuHaraIqYZod4bXVTJDt0sbRzrkGOPKer1vsT++SypT815QKoGIlUq60tebcnOJqvAjZEBF1w9Pv/Di5u0rOQ2Zokx1mNZ8ESCpJI7NCZ9aVYx/AZi4z2fiUpQ8J75R1iFWZJMAZUYzi2RdrniqXU43zJqIYMlLe3TiJNK8yYcisTn7NqSJLp5cYdUBGbFDHGTFshyOQlu30+m2VBavstCgLbXpX0uJMxHUyY61ccMro8lpuZWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iG5RKw1QfV4vTZomEBAa1AVdQ4I+aTGh9eZU5WCRjSY=;
 b=gTQGYOyYRaMpSVsjbr9BK5ejXbQSiJ8YSNKFMLLU3mXhI435PC2Y+WejKtuT/yHQgUD8BBwAUEUIZKPR+rTUoRs935Bf5qip25w2lcFwP6xGpNZ7oMODGmv3kBTEyuTLecjMcZ/ZYeR131HpApzevfomWfsxCPUf5bnRbRuKYuLMwC7EQMb9TKO0mYliDE0G+kJaV4o6XehfGWAabMBQOMA332wY3LQ2KLEbdq1AKhtDkAGsb+PIx+swgvUZw/eNY+Pj7WaDOHyX1xqhiS7W9Lzzx1gao2c7E8n1ct1cmR4VB9GRed9f5xxnxviQuNhITAjUyEGOavkuXYov1KFppA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iG5RKw1QfV4vTZomEBAa1AVdQ4I+aTGh9eZU5WCRjSY=;
 b=URhu8c1bSYDsARBe530v7ZM/dIAdZTF9eLqrwnP1N6Ap5KoDXv5QZ3wuw02mVuWoPm2qqbhDU7zzXPEkLU0NvqmfrCZHjc2puDYszPnjzdLypgjzwGXmpljS3e1wssjfmkfOLGYIXxmdwNN7OJcvy62YVvmnUlXGuPrnZ1Bpnus=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 18:00:32 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Paul Durrant <paul@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding
 handling
Message-ID: <Y1gIIPdQWKDZkNVD@Air-de-Roger>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <8a89c0fb-3d12-fcf9-7e53-d32f9904a3f6@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8a89c0fb-3d12-fcf9-7e53-d32f9904a3f6@suse.com>
X-ClientProxiedBy: LO4P265CA0233.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:315::19) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6745:EE_
X-MS-Office365-Filtering-Correlation-Id: 37a1878f-f2af-4476-4137-08dab6a20f0d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vQsVDiujbXW943YDx9TpJP+WAD5/rZo9oJxeIYmb5fW0sa5fYFi/6u/H5VvhLDLLuZUzsHK449C96+2b17+815ilbWbN+M93YHIYXq750d5no+V6tpUG+IyNiO8E85/dQRmMpZmqDWAxLvX5oEcG3K1JckzfO4GrHJhZOiL7h/+W4kZga0fXnyZUmGU+0GAK4y0nBFKgQsPUyyZQb4zKbSEPa34TIt7Y7S+wsClPyrGvmX+zCs/wOvjmzY183zW259xsMG/PmGUxTcQrohmtqxDuBRWS/yxF2qhLtSFemK6wqsk+fOLGQgsLDbGTZbc5Lkv+F0NsyZVWy2VkOCwYAId/CvePr4zEYDpVUo2NwFsEDrk1B9yWYIv679N/NSo9b0+EkeHzfil4Wdf9LuHR/J4BDX2Hlc5fQAgCaA2y+GgwHMKBLX4I0ve2DCgyoS1H+OJysXHPHokd/NB9CIKE5H0vk7mu2ZpuQUAJAvDPoGSFOVsl7MsfWD3VH1YhqUhOtKhC3gu4cbgbnH3ySrgFBsq4a6cdSuUkP2mpSMnUcYYhcRIGmR5l7Ax8e5d6D0E7pa8A66CUwa2WoFFk6r5gx21O5zkdfER3savlrTuJltWJff7yvoOi0wd6VFCuhWrC71pXmtTRg+n/iQvb1ZUoM1R5uY0m075GieZaBDbEgB2x2uVAKDPkyWjydMWuJ97j20W9eShncbMIYKkbKHNPDQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(451199015)(6666004)(41300700001)(4326008)(316002)(66556008)(5660300002)(186003)(66946007)(8676002)(2906002)(66476007)(33716001)(6506007)(478600001)(86362001)(85182001)(82960400001)(53546011)(8936002)(9686003)(26005)(6512007)(6486002)(83380400001)(38100700002)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NlhuRjYrY09Jb1UrLzZVem5GcEpQRGo2aVA4aTJQbGdNM25mb3I2Ry96ZzFi?=
 =?utf-8?B?Q2FGRWxYK05EMHFCWDM2ZFl4MEowVERwVlhqUmErZjUwMURWMHU3MDRhenFz?=
 =?utf-8?B?c0VaZ0hYc3A3NTN5OTVsK3FDN2l0clkrRGhqTGh1Y3JWTm1UVlRxL0ZJc3B5?=
 =?utf-8?B?bFpnL1ROT2JOZUQ4VUt1WFFuME1YR1NWTFdsM0tYZHptTjJnQmtjbWpEYVcx?=
 =?utf-8?B?QTVpTTUya1JqQmwyN2tUQ2VJVHVmbk9yNnB3SFk5Qy9ad01obXZZVVRyWlJ4?=
 =?utf-8?B?eTAyQ1ZqbFVqb2hZK0hSa3FQOTVja3BaMWwzaUhRWW9EM0dnTVBZL043QjlO?=
 =?utf-8?B?clNKQXVYbFN3cW41UWNPR0RyRTVSUnZXUkdJTXl5NjZjWGhOS0VrcHR1eTFE?=
 =?utf-8?B?TFlpUTduck5hWlgyS1hxdmlWZ3VHeTZTMFdRUkxGT0lEK0J1M1FYcGVPbkQr?=
 =?utf-8?B?YTh2V2ZLUXZQMFRHRE1pemp0akVaR2M5SHlid0FjbjVRemw5dmpZc1lIcnd1?=
 =?utf-8?B?bHh3MnBvSXczTlhlN09QZStRM2NIbHNBMmsvNFluUjA2MWZwMytRQUk3b1R4?=
 =?utf-8?B?UzdrSXNvVWlFWkpuZmMwczB1VkJpcjU3WmYxMEpjTGRGRzhBYUplQysrbWZB?=
 =?utf-8?B?SVpJZGxkaWgwSGY2N0NVSDBBZy9ZdVhtN3BETE9BRGM1eTRwQXhYZHBSWWlx?=
 =?utf-8?B?ZEtLbVEwa1JKS3JqQzZTOU5sVmJ2dzYwTkNmRjFPZWhDZGRqTjlCcEx0cVV4?=
 =?utf-8?B?WXlJd0FEUWx6Q0tBYldYV2NSaXd1OWVxQ2VXcGxlU1FrSFNQZjRzQkI5S053?=
 =?utf-8?B?TzRkc3hHcXl0UW5Md3hGZUVTQktEMWZpSjdiZGZVZ3pUVHM0ckI1V1pTeDFE?=
 =?utf-8?B?NDRqZU4rSXRlbVIzRVFqZTdad3Rpd2tSaGc3STlxQW0xVG95YnFrQ2NwQUdN?=
 =?utf-8?B?SUFvNXRlUTk3eHRRYjBwU3Vya0JxaENlYi95TzZkbGMzZTY4NXRaR2VNY2VR?=
 =?utf-8?B?YUJubmdpUnRteFhQMXRCM0k0aVp1QUtETlgxV0R0YWNWMnRCaGt3YnFRSTNm?=
 =?utf-8?B?U2ZCbkw0dGUxS09vaTlEcDV1MnJRMCsrMmNxUWsrbGVaT0hXZXVScGJoVFhL?=
 =?utf-8?B?WlZ5VGkzU0lOTzN4eDZRZTFadDZJdksrU0d5OGIreExIZSttZGREZ2EwRENT?=
 =?utf-8?B?cklsSDJRMXJFY2xnYk8vWloyY2NIQWZ0Nk15TUZId21ETjRlWStaUnZaN1dF?=
 =?utf-8?B?bmtjSWxTMUZPZFFtU3pWbjJIMmVrdzNlMk82RTcycWo4VHMralNJamJRUUFF?=
 =?utf-8?B?UjNaTmJUeE1uZjlYMzB6SVl2c1ZTYXQwQVJPeENMTi9kU2J6VnBzcU5XUXlF?=
 =?utf-8?B?UmttdWtUaHJpdk8reG9HSFdZZEtFZnpZWllRVjE4OTJYd0lXUHhiTnhybWlW?=
 =?utf-8?B?WnB1Y3YzQ2x5aG45VTV4UHNDMmpkcFNiVW5EWCtPV0o4R01LRGxTRlUyY1Mx?=
 =?utf-8?B?d3RFSzgrR3B0SHJhejMzUXY3N3ptbHF0MXBwcGpVUWtvVDM4TTlmeDltWEIw?=
 =?utf-8?B?aHhFaEQxYmU5NUVjRXVxdkwrdVRDTm1wZ0hONWxRT084SkZKSkJmQ2FsY0tF?=
 =?utf-8?B?SThGOW1FRnVWY3V0RmhocDRpVzBNZDB2cEFOV3ZveFdrRmdMNmRJUThuK1BD?=
 =?utf-8?B?RkF5SzZSVFFPN0dNQVAwQzhUOFFqUHQ2bzRaQnJxZjVFNGYyNDFDYXlyS01D?=
 =?utf-8?B?Q1lRZXRNS0ZuRUFIL3NSTkViT0lmZ1ZpbHlGNWtFTkE0MDd1bmxzNitrblVZ?=
 =?utf-8?B?OWpKQkJYWTYzOG53NzkxQ1M0UEtxSnVXL1JrU3ZWTXZzdmRDMWVnVHNZUkJk?=
 =?utf-8?B?cHZiWVR4cDA3RWNUL3Qwa1F3VERqYkY3bi9Hc0VlblJIQzZ5dHMwZUJNL2t1?=
 =?utf-8?B?RTQ0QUZyelNhaUxqaTIzdTh4ZUlOY29xSk5URjBDMGtFclpGN255cWhUMGhl?=
 =?utf-8?B?b251TDBqZE91cGpFcnFLRjcrZUUzSkJMUURIREpZL1BUTk8xTTFaYTdhL3I5?=
 =?utf-8?B?aGZDWjVYcGJON1pkUVJNS3BvdkRzaVpES3hxZjRBUUhpZndJdlFWMWpoRSt3?=
 =?utf-8?B?dEZDLy9kNng3UEFVbFZ0UjVJZUNnT205NG1ENnNocXFkTWV0OEpUN3RwVGZk?=
 =?utf-8?B?VkE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37a1878f-f2af-4476-4137-08dab6a20f0d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 16:00:39.1247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NeGnPHmYRTsmSqH9aFTXjsQ1v2+57gZbGkmiZqDoYXXyIiAdRgObp92rY52VrD07BF7S5urSegaCI46s59JgeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6745

On Tue, Oct 25, 2022 at 05:02:41PM +0200, Jan Beulich wrote:
> On 25.10.2022 16:44, Roger Pau Monne wrote:
> > Hello,
> > 
> > This patch series attempts to fix the regressions caused by 75cc460a1b
> > ('xen/pci: detect when BARs are not suitably positioned') and the last
> > patch relaxes the check done when attempting to write to BARs with
> > memory decoding enabled.
> > 
> > I consider all of them bug fixes, albeit the last patch is not fixing a
> > regression (since vPCI code has always behaved this way).
> > 
> > Thanks, Roger.
> > 
> > Roger Pau Monne (5):
> >   vpci: don't assume that vpci per-device data exists unconditionally
> >   vpci/msix: remove from table list on detach
> >   vpci: introduce a local vpci_bar variable to modify_decoding()
> >   pci: do not disable memory decoding for devices
> >   vpci: refuse BAR writes only if the BAR is mapped
> 
> Looks like you've lost Henry's release-ack that was given for all of v1
> (i.e. only patch 2 isn't covered by it).

I was worry about adding it again for the whole series (except patch
2), as I think release-acks are conditional to the time they are
given.  IOW: a release-ack given for a previous series sent maybe
weeks ago shouldn't be carried over because conditions to get changes
accepted might be tighter as we progress with the release.

I think Henry would be fine to reassess the suitability of the series
once it gets properly Acked.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:04:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:04:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429963.681339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMPp-00054X-Ke; Tue, 25 Oct 2022 16:04:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429963.681339; Tue, 25 Oct 2022 16:04:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMPp-00054Q-I2; Tue, 25 Oct 2022 16:04:33 +0000
Received: by outflank-mailman (input) for mailman id 429963;
 Tue, 25 Oct 2022 16:04:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onMPn-00054G-Tj; Tue, 25 Oct 2022 16:04:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onMPn-0006wZ-P9; Tue, 25 Oct 2022 16:04:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onMPn-00073j-Dh; Tue, 25 Oct 2022 16:04:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onMPn-0005PV-Cm; Tue, 25 Oct 2022 16:04:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ilHRKK8HK6ngu+6AZx2w9NdHdbWaYEQ1I0bqcPTXRts=; b=fSwUJWA4Sbl02yqzJ8b+SJblJt
	BTznW3dQi+U2Z2iQoyY2+eOzxrHqTNOazkfed0l5J98mGn81GLVt5ENF04SGmuQrZyCsX8TyU0R70
	rhoX0pKgmcGjmwAYURipsXU0N/7DGGKV6/3EHAsYBfiW/av7K7bgrTnU86o2SVIJET4M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174355-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174355: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 16:04:31 +0000

flight 174355 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174355/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174355
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   71 days
Failing since        173495  2022-10-11 14:08:01 Z   14 days   14 attempts
Testing same since   173657  2022-10-13 01:09:08 Z   12 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:04:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:04:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429966.681350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMQ1-0005OE-1v; Tue, 25 Oct 2022 16:04:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429966.681350; Tue, 25 Oct 2022 16:04:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMQ0-0005O7-V1; Tue, 25 Oct 2022 16:04:44 +0000
Received: by outflank-mailman (input) for mailman id 429966;
 Tue, 25 Oct 2022 16:04:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onMPz-0005NK-Ho
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:04:43 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb766313-547e-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 18:04:42 +0200 (CEST)
Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 12:04:36 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BLAPR03MB5473.namprd03.prod.outlook.com (2603:10b6:208:296::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 16:04:34 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 16:04:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb766313-547e-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666713882;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=wrastLq3dbl3Mn+1zNrKLfjEPmzgPvCBbdX58bWzaPw=;
  b=AfGl6lz/rtATaKbD/dwiqG6QwGeO5HLihTkIkm70PzQ0ZkrKH5WdAC29
   hq6wLQWu0mAn7Ef9YMqroJK2IhiuF5aJXzbxhIGJ9gEzdV5LPehOeJI6x
   riSZZGbQoPGCtOZRsCV6+CtpRsBzRWHaCsDRG5G4BUaDEzk8+1QwszTIe
   o=;
X-IronPort-RemoteIP: 104.47.55.176
X-IronPort-MID: 82575103
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:48MiQqmKnoFweVWwCtE7PWno5gy2J0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNCmCEaffcZWD3ftsiYI618k1Vv5GDmoQ2HFRurSs1HyMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6UqicUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRkOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHmdx9
 eBEEmE0NlObo/CUg4KjT8pNr5F2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1IZPLvFabI5fvSQQspYhACAr
 3/u9GXlGBAKcteYzFJp91r83LKQwHqjA+r+EpWl1acz3WaewFcOUiw2S3qkg8Whp2ShDoc3x
 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy
 hmOhdyBLSNrmK2YTzSa7Lj8hRO/PzIEa1ALYyAsRBEApdLkpekOYgnnS99iFOu/iI3zEDSpm
 TSS9nFh2fMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U
 LIswKByMMhm4UmxqRGw
IronPort-HdrOrdr: A9a23:Cv/QKangO9K3thFdg2ooPj3JaBbpDfO3imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM
 tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq
 Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 D4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR8Xue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqXneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3GlpT1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfYzhDc5tAB2nhk3izyhSKITGZAVyIv7GeDlJhiWt6UkYoJgjpHFoh/D2nR87heAAotd/lq
 b5259T5cFzp/8tHNxA7dg6MLqK40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd
 L6IRhliVI=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="82575103"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DYpQFUDMChOdPoRz6td+w6jWUyISxzb3FZQtP6VT4CUspy06gmlCnYID3zwltsdZWcD4+FxQIjw8MuqKIbUz/lAHCfXuLD5cJkw3H66dfpZE3jssgBwNnKGhj1g1dsGKoz2rYQgd+Dri0uZSm0TYiokabD1ST+0tLO4WE3a1vxli5+mrTvixASyPQ4HmzIRX2ovmDzVk74sHmp1Tw5gAvzWY3hexDrkwtSL1LecpsYcP3S+rcJOtWWPNQhHaxEAaDRpHrORzULTtEm95D9Q5F7d1aDAbviIipfwoDOPfOhXqQj2mDDm1a2MsO/PXcAZZltZBuPfFRcsOn6E3EqM5lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=96jn79eJjGReWi027q+gD707LOnjTQWRbOoc55ad6ws=;
 b=KkY6tYqkf0MOFRpk8ZGqH71V4YMdkufXXUJMftoFoh8rZIN8FYrsRrem56XjMMQ/wVZF6It1jFgRrk51nu+G/LGMkOrEuwj/0T6mHtbzYrKQ24QRjo+F5BAEToTYWyOfHQyhzj8N7fBhntHcDC/uJvEHiIbrDiGUfFN+neZd32Wkw0vqGH7VHdaNslBJJEC5+PT5X1CTEeUAlX6xCoiNOU8HijGGqy2B8Mub7bxQZ0HZdXieEXL50CBxssMV5zWlRqwgsX84L8UReEdFaqhLb2C+oRP81HIZUlGZOWpgaW7nKw3X0PvSEzQdhNd4Cv92UoLWbzI0JYJ+hJTYUfP4yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=96jn79eJjGReWi027q+gD707LOnjTQWRbOoc55ad6ws=;
 b=ICD5bmNJgOJT2VO6wirlrEJJzHcmDXT2z07eqU8/Z6d70R67u28bgcGkfaRLU6mDKlnaPcFrizzhT24/aTT0UGWeLuH/6/KldAG0arXkaJEG7dcq1XL7xoqS3HfVob7ZSNTyqYajigkft4I7Eqr6O38plLRCC30kE9xxmk5+QZc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 18:04:29 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH][4.17?] x86: also zap secondary time area handles during
 soft reset
Message-ID: <Y1gJDYEjARSD0F/s@Air-de-Roger>
References: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
 <Y1f/iQaugcmhiP+0@Air-de-Roger>
 <76d0ce3d-7c05-9f4c-921a-0c7e0f5d9348@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <76d0ce3d-7c05-9f4c-921a-0c7e0f5d9348@suse.com>
X-ClientProxiedBy: LO4P123CA0157.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:188::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5473:EE_
X-MS-Office365-Filtering-Correlation-Id: 8d90b0d0-090c-45cf-f2f2-08dab6a29baa
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	apS7BOpyAOmDGCtf9OgwrKKI8nqhvRleu8IuPCg1WyFfXG108ssmGqgXdYuX9v8iAmCVH7KKmW9dPu+nnDpPRx0KpGbc+xjoOBTP5kL9kYPscs/J3i0lhUYrNYvf75OmGOTLWGF7wJbyjAkKhRv7FX/cueHkATHxhH6rpifm++izVTboBWB0em/A1+bZXM+Ky/jUE3H/81GQEJex3asAELfAhTs4V0oMpawUbBj3H1HY/fLyeA0WoE0LpmbbF00idT6Gb55l02egYQq3D1V7FBGB5BdJbQQmWGOzU06eQC//3illuaEpDd5zckjMh3e0Lpa2mIt/X6xwUO6CWbnEYRJx6y570w/Obm8GpNn4y57xg/vb4c67hOxylZOq+rPsAi9FKQWJYiHv8Vy7q+U+N9CE2d1MTEEinyAvs4HAjbSzHjjQCdEVG+6fjTrsE0MMnGIycj2exUH7o3nf+bw4pm0385JXL2UY5GIEMhRjxRL2KR5MmFXeo3XKkraA46JlLQt/Zbgh8e3SNlP3hDglLkk8UMIbCxlKK4GT1eqB1oeq73Y9ENFpSj9qhAX3dpeSHPOD7Pc4y/gJeu3icQBBUyik/ZGDAp8DlQKlwgkDHiHPKuRV+NUc8t6ZY6pFoTq5jx8t7JAaoJ/4HfSBJ0dgVMTHBk8ck08s5bCKGxKv+CfAxm58xGvtmDdizLRYQzYV3Lqr8GkzCLWpAzkERaXG2Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(396003)(136003)(346002)(39860400002)(376002)(366004)(451199015)(26005)(186003)(53546011)(6666004)(6506007)(6512007)(9686003)(5660300002)(2906002)(8936002)(33716001)(478600001)(6916009)(54906003)(6486002)(4326008)(8676002)(316002)(66556008)(66946007)(66476007)(41300700001)(85182001)(86362001)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R1NoUTFRT1RSVTdReEhxNmJxZ0VzdGkrTXhDOW04S0dUU21PRjdvSWZUR2VE?=
 =?utf-8?B?TFZ2RHdTVjNGbXhiQ3JlZTRQbjNvcFdQellpMzlWbTRXbmN3bXVLdzRRQllv?=
 =?utf-8?B?UklhbUpITWM1Z1JoOWZvZHRwcGdaelpUZC9JTnowTi8xTDFpZWlQVi9vbTZi?=
 =?utf-8?B?bWRBc1BUaDVTaFh2ekRtZVdzVVpXekVPdlpjaE1CcUlFc1Q3dndXeWswblV1?=
 =?utf-8?B?L1ZaN3FacmFMOXhaN0NHeUxERlg4UzlMdEJIdUphSzJGcjdlY21mM3hHWXkv?=
 =?utf-8?B?UjN5Q092UzQrQ29wRGgzV2x2aEFoK0E2ZlJuTzh4Wjg4R01FNWJ1UnpwcUxW?=
 =?utf-8?B?MDJkYjgrSE10Ky9LK3pHekhuTGpTcXNxZ1RCV0RpZVFsLy9QN09wbENWUXQ3?=
 =?utf-8?B?cEtvamlYZXNpMW93R0NsQjFmcVpiQ0loaW1uam5HdnE2WWRjY0U5VXZnM0tG?=
 =?utf-8?B?dnhjYkhYZVFHbnZpZXVrOGNUL082KzNuaFNXdklVc1pwcVlEbzFQTVhhU05a?=
 =?utf-8?B?NWpUREVXT0ZtS2szODUyQys4dzk4RGJrd1pVZlltZmtST2pkVXJ5SkVjdlF5?=
 =?utf-8?B?Z1NUeSt5aU9iRmZkdS9CTE1DeHlBbnlVOVVkRmszWlFSSy9qeWhuQ1BTek04?=
 =?utf-8?B?RUtDMGNNNjhQRTIrSUxjazdHaTVjVWlPYkE3K1YrMEovTDJZbUJFcTBpQ3k0?=
 =?utf-8?B?dkhVVVBWRldrV0JFNDNwdkw4dzRXUjZzaExocUM1MkNyaVFWZWM2RHMxb1dy?=
 =?utf-8?B?L1dPelUxZUlhTHE0bWdtQ29FeHdwbkFxcEUzL1V5UG82Ri9HNUlLQzRwUm1K?=
 =?utf-8?B?b3FPSTFzeXZONjdVcnhzNktIenU5Ry95ckpNUlQ5WmlwVXEyOVNuM0NNeGtN?=
 =?utf-8?B?OUhaUFE2ZzA4ek9FMGlzM3M3Rm1CMFV4NVVOVkM4ZlFuWjdQYlhrbDMyNXBr?=
 =?utf-8?B?eUFRcGxiZEdtWXlucVp2L3BGV2pCb2ZQdXhodUNJNDIrcWY0R2szNzVOY3BO?=
 =?utf-8?B?SS9BeGdTc204cWR1SWtiVkhUOWtqRS9GelNBUlg4cjlkNURpQWtpckN4YllZ?=
 =?utf-8?B?UldTM1YyODJNUk53VHVacEtzeFEzdkxrZUtUaFVEM1UzWnJ1dW1QdGN6N2FN?=
 =?utf-8?B?REY5azJLREk3aitjR1FyU0FEQkZiK3ZTbW5YY3ZyY0hKaWQ3Y1RWTjRwTEZJ?=
 =?utf-8?B?clBVY1hoUzJ1c1JEaXBFRVRDaDZjL0E0QVpXSktONkZMM2NicVc4L0pNL09p?=
 =?utf-8?B?NUQ4WmlFYWVxQ243QUN4WWRodFlGeU1LSzl6Nk9BUW0xMS81RWhqcDlIOStl?=
 =?utf-8?B?UzVzR0docWdWY0JxODhwajhOYm5FaWpVRU1jMmtwV1JhV2hETHY5d3B2L0Ra?=
 =?utf-8?B?aXlYcWxCTmVKT0RlRW1ZRG9zVy9wQW5FbVZtYk8wUFk0RTNHSE9SZEZRaW5X?=
 =?utf-8?B?aDJTeVVyRENoRWJTZjhQQmRicnRtQ0pXTjRUcmlzYjVpcWR3TFBoYnp5N25w?=
 =?utf-8?B?WmFiQUkwV3dEa1ZiaG5UWWgxb01mN1dOaUdnQXM3TERycERVbjVjanMzU3BX?=
 =?utf-8?B?bzk3Y0ovaVFPdlJKd1E2YklVdE1aenRNNXdkcStlRTRMdUlkaWVXWUNjMmNa?=
 =?utf-8?B?S1BhVk1waWJNL3oyODJNSUdEeHF3aGlsSExjL1QzcXNEUUdOdFAzTGhXVk5v?=
 =?utf-8?B?dGVkS2RETEk3VHpJaHVZNTg5SndyMDFwZDJnMGgrTFk0NExCK3RLeXBRVitM?=
 =?utf-8?B?cHNpbmJlaE1NY3VHakkyMEZRWlZzK3V5eTN2bEpNSDJuTDdMQU9lV1BWNGJB?=
 =?utf-8?B?U2FIRzBhWm92ZFAvV1dKZUJ1TVdkZllidVJxZnNlNDBwTDBZN1h6d3lZK0pt?=
 =?utf-8?B?OWNsSTBILy9wQWNuYVFLbjNpcjRubDh1bXAwNS96Vmg4dnRKWmV0WDl6cy9E?=
 =?utf-8?B?RGhFVnp5UzBrdkR6NW9YbFp2b0lyb0xvQzFBR3VBa1luRlRudmFwNFFCVkxm?=
 =?utf-8?B?bFZtYmx6YStzN0pjNlpXazZGYW16bnZnTmJwSURGSE9LNjFCcG9HQWNKNjA4?=
 =?utf-8?B?dFJObjIyT0ZqTGk2bE5yaENBcWdXN1NJT3JZQ1FiLzMrblpnMGJadXBROEdQ?=
 =?utf-8?B?Uk1OOFMwU2VpLzdpcVZnQmF6eUc4dE5ta0xjc3ZUUTY3SmpyZHVrdGx3bitX?=
 =?utf-8?B?RVE9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d90b0d0-090c-45cf-f2f2-08dab6a29baa
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 16:04:34.0537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uxuVJ12qBQ4QBORxML5CqTWU0PM9G+3Y/zrMj0wGVXPMxnZe23Gjdkwh2DyX8mNxNVtcclDok/KkgVtKyEB1Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5473

On Tue, Oct 25, 2022 at 05:58:10PM +0200, Jan Beulich wrote:
> On 25.10.2022 17:23, Roger Pau Monné wrote:
> > On Thu, Oct 13, 2022 at 08:48:21AM +0200, Jan Beulich wrote:
> I wasn't sure about moving arch_domain_soft_reset() as a whole, but
> yes, if that wouldn't cause other interaction issues this might be
> an option.
> 
> > In any case it's unlikely for a domain that was attempting a soft
> > reset to survive the hypervisor rejecting the operation, so it doesn't
> > matter much whether the domain is crashed by Xen or left as-is I would
> > think.
> 
> I'm sorry, I don't think I understand what you're saying here. For
> PV I'd very much expect the guest to survive; it may of course then
> be crashed or destroyed by a further tool stack operation.

I was expecting a domain that goes to the length of preparing for a
soft reset operation to either perform such soft reset, or die as a
result (and perform a non-soft reset), as recovering into the previous
state won't be feasible.  But maybe I'm wrong.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:04:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:04:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429970.681361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMQD-0005mp-9z; Tue, 25 Oct 2022 16:04:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429970.681361; Tue, 25 Oct 2022 16:04:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMQD-0005md-6r; Tue, 25 Oct 2022 16:04:57 +0000
Received: by outflank-mailman (input) for mailman id 429970;
 Tue, 25 Oct 2022 16:04:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onMQB-0005NK-Or
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:04:55 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c3849277-547e-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 18:04:54 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB8448.eurprd04.prod.outlook.com (2603:10a6:10:2bf::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 25 Oct
 2022 16:04:51 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 16:04:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3849277-547e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ebnVgbaHztPfCylTBZF4YUNsaFC653xSJDc7ddTw8O7P4qo2Op/RKzhP7jRr98wnJaMfKpukM6UXHtBeRMrQWm8zD1jA3IkoMiX7tcZSDyLSMS2hfh3Bg0nv5rC4G9mU1aImmwWlDpeUgiX5dmlnD46nR0AIzbZblgtiIkl3bkTcPWSOUqSAxykl4WYYnv1Sn9/Yv26a4s3HnUtlOQFJMe+jeekrN3zSj8QUX8GNVYiuyRS6Ve9Zbky9lQro//U9h2+gptxuwvePM73AsCKby2SczHxGWjV1UluHPbzgXADFoIceiNBHQFSGyARRwhB6CPVReiDHfivUfWMXDJ/Fog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6FEXI0yMFe3oor7kXkJE7Q6mtVECp9cWIjTtiMKzsYQ=;
 b=ipj9ieBwHPmF0jyPDKY0pFfHuUkip/sOXX3RkZZIDUAIHlMuTuwuAQwZoCVfz+g5QwmJrSkkjgJ5uzwNwWE4QLZ1yLjpR0UTFwKLaQL2X2q27KU5bB8v8/FWYncp47Gh9ckE47/wg5yTXGJ0TTGM3uVp7tYEgDHoB3Km6q8O9I4d55fpWele42KzbTjgm5HGlhdDe5Y+G1c2yGc1V2lXg0IAtNDQyRTk9/d8aSgZU6K2dHrz9xQt5/xf1t6L0DgnPNtAk8QrG444w3KmaFxdPLz/yuE1H35icCwhPuLqScaIbtRITcPZ7GrsBkDihILD9DufZe+0XCdv4/bxwXKV+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6FEXI0yMFe3oor7kXkJE7Q6mtVECp9cWIjTtiMKzsYQ=;
 b=Ga2YKw3TVSEXWrPdRx6bIRchFWM3UXB4ONbdN5D/qCaZwRsRJjbPLuZK/Wyyh5iKYJFhwtZ2Hs5AtDwxQWn2zOvgXp9mVlpvj9y+lU0eQzPYI6bE6SgyKY7aqyedl4A8l3wXtPu6nmLfcou7EZq1fTkQkGL1OE48ciXHXL+E/ieaOg5BDS/TE0C9Vn4Bo/nY6UOtOaj0kWZrVGTBUlnZxlOB6+DPDbwcidw1Z4VXp/Gxu+iWwYqxb183n5vbBa7jHlBPzi3XBgTScelrtGyXroBvEEt3KPkuWp3+sXskUZgXK6cm5KmSS4nS0u2Tt1n25fkrW0VLHTQUMKLdM+fpBQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1780acb3-d297-edc6-3a1e-adf8b28a5262@suse.com>
Date: Tue, 25 Oct 2022 18:04:49 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] common: map_vcpu_info() wants to unshare the underlying
 page
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
 <Y1gD7GmclguLZCM8@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1gD7GmclguLZCM8@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8448:EE_
X-MS-Office365-Filtering-Correlation-Id: f79f7f76-23a2-4a2b-891f-08dab6a2a58d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	inzcGmeROUCkwN4pBKFmVYeBpFh7536h0kQmb+F5WWdCmAE2PN7sRxqbFYRAPBY1I7gDASf+W0qM391FKuiQr1x5x8Uj1Ot+P1gdDHcHdapd9HtzooItUR0y5e5fkjF7mkdtqCEaa0X09jeKke8pPC1ntffYrl/lTi9a7azQD/IGxh2Tb4uMku4u2KTZcNnH6t4hGkMbXZJPq6TzFc/IdOtuOkZ8UTWDZVMS4MR365eJBGXt9kjXI5xmadcF34pYPyYBjen0ByXSm/IHPzRGQVzl/Sfnqo9ZFexwm9gd09alNpGQqeT9j8SWMdaTnf72c0TZrRB96Y6KGXsga6u83E0CbU8SqgRyFUV69Q5+rxV6k69LJfm4+EtGReU77LkyMP6rglyJtfQtWtUULzjxYhu3wjiec5UXrHFGGpffwUoFLW5ok66glzRr0MppvyVFndZKztQYGYZn72nffylCVp/OyqBrBN7dspxIC+2T6vP1ap3AIqIh1AxJBdjyuGVuvKjpUXxG3YPTpcAT969HJ3dmhGkeKTFA6mPfZFbnmOkQapKlj2ow5B+FwbttRntKTuYK2Xn8EiV1V+571gpeOkKvrKEMTH0ccYkd0AEocNkd9mM1NakBJd1Qy+Sp3sawehYMSDFFR1WaKnDftt9Ss4Vow+fbP4yQmwuDzRpi0/fnndonrZEcnom5lJCtdC3xXMTtAkhmYzq7ylcnVWwBDCeRNju44NqEszsdhmtgmY+HaQoSuevGBzJS1l10TR9m5UsLrluR7D1XRayLcLO+aUGcVz9x9eBOMN/v7arpQZU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199015)(31686004)(36756003)(8676002)(38100700002)(8936002)(5660300002)(66476007)(6486002)(186003)(6506007)(31696002)(41300700001)(86362001)(2906002)(26005)(478600001)(54906003)(53546011)(316002)(6512007)(2616005)(6916009)(66946007)(66556008)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eCs0UUp1cUlCdmp4VkJoMHV4ejVrdkY3Z0krd1RkLzJ6N3VPTjEzYXpJMGx6?=
 =?utf-8?B?dXNZOXQvam5CaDJEK2RxNUVHK1RwTzdqWjNBekFFZTFuOUVsSmhYb1JEOTlr?=
 =?utf-8?B?NTZCdS9EUUI0cVVsdjhkTlZuMFJxc1FSTlJIZEtuT0JKUmw2VFFVTVZiNG91?=
 =?utf-8?B?a2FLMW5BL3dpcGIyMHBibFhneGtNOEpRSmNLVkV2NUtiSVU5R2JRdXlGTGp2?=
 =?utf-8?B?Rm51SDVsb1RRUHhQRmV0WHRGT2RDalFKNnBoM2xldzRuOEp6Q0ZBVnZzdXFo?=
 =?utf-8?B?VlEyRmdvR2hXY2VIWDdUNmVGbmI1bGVHaWdFeXFsSndRSW5ta3p3WXZ1Z2dG?=
 =?utf-8?B?dnEvdDBRcDIwYnVibktEbUo2QjVnVklIbnpXVU43dnZwWjJJRFZWOFdmQTBJ?=
 =?utf-8?B?L0p2OEJkMlB1d3dNeXJ3dUFyMFFKMUNrWXRLSy9hRUhNeDd6RTAxWEVTdEIv?=
 =?utf-8?B?U1VxYjdnMkR4NmczaCtKdDRrTEsyaFlaZjM0MUR1WUNBdHhtd1M5NzR4b3BZ?=
 =?utf-8?B?MDRvYXFSakM1b2pObjlzaEp1UFd2N24vWG9ITDdoVFRsMTljSi9ST3BUTEpk?=
 =?utf-8?B?VmR3SHhER1JjOVZnWDF4Z1dvSXNHZ3dtbEZuMnNFSVFwVFJXdGMwb2xTV200?=
 =?utf-8?B?cWF5cWppNVJ3VStYSUdHRnNDUkpMbUVYM2xRTWJ1RytsVlRwbHd4SjhVVmRx?=
 =?utf-8?B?SWQxejYwNTJwa3lEdEZXNWZJekpMaHQvdDNvbjhEL0laZmRCbThxdWJOV2VK?=
 =?utf-8?B?aDNUNVhOTTBaanRKRG1sUTVLWlVXM3IxdzM5U1FtRGdNN1dlMFZaaHVKUE0w?=
 =?utf-8?B?dEkzbTB0dEpKU0QwSHNXbUJuSENBaVpYMGc2SkNBeWdqSDNOSDNkWlFDWUMz?=
 =?utf-8?B?SjlJdVhIc0ZTUklrT2l6SFZiemczR1MrSjQxbTNwa29JVXU1c2R6Q01LMTVj?=
 =?utf-8?B?N3ZnaGZtMXAyN1hvMVUzamdHVzQxN2lxSXVSUjJIOFd6cTNuZk4vTHV5RHZt?=
 =?utf-8?B?TjR3MWZETUdNdzJXaThqL0VCKzVPUXZmZEZRbUFvOE5pQ0FXcmZaUi9HR0d3?=
 =?utf-8?B?NzROTklXZEY4NnRqbzBoOEZCWHVUSTV1QTRjRGhYME5QQmtpTGRPNlp4Y2pU?=
 =?utf-8?B?cHBDMEkzMUowa05KTkNtYWxFMXJXSXQyWk81dDVjNUVrSWxnT2gyM2ppRTBP?=
 =?utf-8?B?SmlPR3R3RDJYOG1vZ3A4NXZCUVVQQTg0Rk1adkh4eGFhNUxNLzhsRVI4Zm9N?=
 =?utf-8?B?ckZpVmpia0hlZGtWd0lPU2M4dkVoYWVDZDVVZnQ0RjJCTHBTMG14S0lVaGFV?=
 =?utf-8?B?cnlCZXQxK21WN0tqakxvcEQ0SUVJeFZ0Wnp6ZjlTeTAzbTJCTHM1UklkWFdl?=
 =?utf-8?B?bm9hQ0FXZ1V3WllLeUwxWU4vZG5lUnM5cUNsemd1ekJpVHhmZGlGdlo4WHpq?=
 =?utf-8?B?RVlpRG1hbTFaVjBXZ2FiZ013R3dNK1RjVm50aTAzVVhDMUpqWGwzMFlpUGlh?=
 =?utf-8?B?dlJnL2MxMjRHanFENWprMjU3MFFNczYyQUF6eG1CczVRZEx2QUcrMG9mc2Ez?=
 =?utf-8?B?OEFyWUQ4MHFNVloyaTFROFpabldGcmwxSWVnZHFSWUJtem80d3Y4azJPZXYv?=
 =?utf-8?B?ZTlqdTRVZm5xUEJ5bzF5OThNSDZTd3Jhc3ZxYVF6eDdLcXlpTUJxbTlDVXNC?=
 =?utf-8?B?Q09iVy84cUlPeGs5cE93Kzh2RmZjTTNOZjhhOE00cHpiY0x0ZXk3WjRrSjhY?=
 =?utf-8?B?bE9wbndtdWtiTWloME9nSzc3TVVFV2tvVndCOWVCS1FaUENndXFobGhFUmtr?=
 =?utf-8?B?dkV1UTVsYUpDczhVUE5jWENYRVdmYU4yZlRVRlNKUW5GR0pBSGhaVS9WdlRU?=
 =?utf-8?B?eDRGZTRicHd1cnQ3VkZMM3NSeFNtNEFBMjlTY0x2K21uMUY3dVRxN1RQenVI?=
 =?utf-8?B?WW8zcXdmcnBWbFNuV2lyQ3VjcWhkbDZQTUFPanI4UnJqNUg4TjVtQkdybWQ5?=
 =?utf-8?B?NzdXQ1JndTdPTWxicXRrL1hFaFdPQzRSZmJ5czFqRllhbjBLaUFVbmQ1dlZk?=
 =?utf-8?B?YkxabnZBbDB6QkZNMk5MZkQ2SGZodW9VWTZsNHZ2eG5LSlRqL2pwT3hCbFMr?=
 =?utf-8?Q?daqixem3VKnJTnoNQwcKUqqbM?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f79f7f76-23a2-4a2b-891f-08dab6a2a58d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 16:04:50.9662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jQcG8CW9DGQtSx2Njo6gukaGNgoQVtVVtPOaRilSKZL9ygjq3ettkAnXzgmNiW2m2gd2SL6bHU4rh2OovSrlwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8448

On 25.10.2022 17:42, Roger Pau Monné wrote:
> On Tue, Oct 11, 2022 at 10:48:38AM +0200, Jan Beulich wrote:
>> Not passing P2M_UNSHARE to get_page_from_gfn() means there won't even be
>> an attempt to unshare the referenced page, without any indication to the
>> caller (e.g. -EAGAIN). Note that guests have no direct control over
>> which of their pages are shared (or paged out), and hence they have no
>> way to make sure all on their own that the subsequent obtaining of a
>> writable type reference can actually succeed.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.

>> ---
>> Really I wonder whether the function wouldn't better use
>> check_get_page_from_gfn() _and_ permit p2m_ram_rw only. Otoh the P2M
>> type is stale by the time it is being looked at, so all depends on the
>> subsequent obtaining of a writable type reference anyway ...
>>
>> A similar issue then apparently exists in guest_wrmsr_xen() when writing
>> the hypercall page. Interestingly there p2m_is_paging() is being checked
>> for (but shared pages aren't).
> 
> Doesn't guest_wrmsr_xen() also needs to use UNSHARE?

I think so (hence I did say "A similar issue then apparently exists ...").
With the one caveat that a page that was already initialized as a hypercall
one (and was shared afterwards) wouldn't need to be unshared.

> I wonder if it would be helpful to introduce some kind of helper so
> that all functions can use it, get_guest_writable_page() or similar.

Maybe. Using check_get_page_from_gfn() would already help, I guess.

>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -1484,7 +1484,7 @@ int map_vcpu_info(struct vcpu *v, unsign
>>      if ( (v != current) && !(v->pause_flags & VPF_down) )
>>          return -EINVAL;
>>  
>> -    page = get_page_from_gfn(d, gfn, NULL, P2M_ALLOC);
>> +    page = get_page_from_gfn(d, gfn, NULL, P2M_UNSHARE);
> 
> I had to go look up that P2M_UNSHARE implies P2M_ALLOC for the users
> of the parameter, it would be helpful to add a comment in p2m.h that
> UNSHARE implies ALLOC.

Same here, plus I needed to further figure out that the same implication
missing on Arm is okay merely because they ignore the respective argument.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:07:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:07:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429979.681372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMSK-00072q-Nl; Tue, 25 Oct 2022 16:07:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429979.681372; Tue, 25 Oct 2022 16:07:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMSK-00072j-Kz; Tue, 25 Oct 2022 16:07:08 +0000
Received: by outflank-mailman (input) for mailman id 429979;
 Tue, 25 Oct 2022 16:07:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xqZt=22=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onMSJ-00072d-J4
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:07:07 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2060.outbound.protection.outlook.com [40.107.20.60])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 121db4ca-547f-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 18:07:06 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VI1PR04MB6816.eurprd04.prod.outlook.com (2603:10a6:803:12d::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Tue, 25 Oct
 2022 16:07:04 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022
 16:07:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 121db4ca-547f-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KDPN+FqH+RaQd3k9a79QIn5TyVCW8dTbwyGlKx/eXE/TCRFvILheIYANDPPwfgM44krADcLVilY8w/pjq7RkEvQ9H9rZjWZYeXWuH0M5TgDXVXHXP1iePJy0/8mjmKNTAD5HlIZxF21MyrAfswR2lfWthQvIntGF7NwsThlTQzzZRI5sa95sz5i1pKuG2RsNYQae6+SM88+01tUjKzXu1qkwXPsgtlFGJBI9x1+Je2JE2ulUU6rzunX3+vbRq2YBReIlErz4UoCH07jLNHpgej+ssTzqcOj7TK5URpIrzvkja5ZrF0b8zXKpnI3iv/USafTCF5yJRXqCPJmpo+287A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kzDs02ECJydrm9OLb34e/Go0RUqZDfEPGFdVioZAiaU=;
 b=IeubrjZQHUqOXqmDMeW3IP4C9NpD2Jp1JYMkOo82DQ68CNE5RZ9n7ZLE4dpMr63YDoSL3kG9rJryXk18edFKAQWeLTvO6+MEDkKKGM0Xo2zRq7IwjVDFKFz4ZpyuVqfn/Y+CISTIV0keemEuzSsomujx3GNz/X/eu8PWUWAImy+4EF/AZh1cQnGKTL42o/2KPSBgyxnqhJ+c9RYqG0Rc57mKmz6oNwECTYi4zBSuxQMJTIAy6ZdRC2aiFEekHIa/gkhAwTdAq1p8IhhUCluSbnYXHRe7nSiLfLHwBVEodTARljlOyLrQJ/mi8Ez7eMq0IQjkOB6ifWBoZNIZ+5lPsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kzDs02ECJydrm9OLb34e/Go0RUqZDfEPGFdVioZAiaU=;
 b=hH1C3HgUEoE5G2BcEDg2kunX5Tm4centqlkL1cfRi462eSk9/bgq68ahqT9bRLnGst3wqqLJvrojeSC/OFpt8OqWEkRaaS8Pt/YSt7+2wfF9O9k2FMdas4yGQdGIZXf7mGr3gYqEQx2VqGl9SM2Q/eGul3bnkDB960GDCyx/pmIcsIP7ABesPC0R30sJzWjJF+sSKkHPDPIP8flzr9ZMWjAxZVIxRYpQ1Zn+yJSD2FrXYxdBA/z2v+jI55qgVZmRcGvJbtge/eADQqlHXG1Kthzvcb4y5V1jKnRTiwHkuO/1xlBFoDa0tkZ1J3zOS+69+/8/lywR4Jjd9ROlq2vbfQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b9c190ee-f916-b03d-e56f-0a54d93ba948@suse.com>
Date: Tue, 25 Oct 2022 18:07:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare the
 underlying page
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
 <Y1gD7GmclguLZCM8@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1gD7GmclguLZCM8@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0014.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::7) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6816:EE_
X-MS-Office365-Filtering-Correlation-Id: 40f65f52-0ca4-4fc3-f945-08dab6a2f559
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jbqjFQTL4K0UQhBddh8VsNYGjGC8Gi5Z4EGquzWANw9/IiZUDcAMKcS6qTibELbX8AiAASlYCMpyg1H2tAgQleILf/A4FDNf0dlfQz1cJfMc7pTHDdH00Tcq5qJqbhvBJy0o5lK1l2772vD9KtM8WNE20PrTfPjR6WDy2WQy6zkJ4pCacr1BEjUdptzD3/mUAmNPaQzFqw7sB9IdhPD/8B5bQjLoXoClQyIX6DrAcPB5WbQwztfWO0FZDx3XUZJxkltEHEiJfgvZlh8Yay6geATJtKLO9DjQ4y2Y9K3BGhyKR7m5ZQ5R/LMBLb5HNUIam2Y+87/4jkUGBmtUANnImk0Qd8RwFbwRptxl70LUGtLQmpbM4zHM3t+f8F9uu3g2HS/fz6ZBRGvLv9fo+HLdCe0WMhlQL7H7PNPBJSC4ERNxhLe5dr1IuC1H0B0FFgYEKRJ3dEOT7ZEjrNvHUlY3OS/o2Jg/QManFfUX1aApz5ND1H4fwo87tIMP5eO2tb8WTJirTOVCoDoyManuM8xmxwrhoHJzYcLJpgBM2GLW05eLYqBvD3AR3vSPT+javr5yJAOHILX+sAuKNXZQe0P3J05mLx4Nw0vNVWhwNj+dMcyV0GgO6pCppD3lhXwVU+wvwth6bafb2vF6ph02iJhjZE6hdfIpzqWvRL995N29Ttgjoh2seG0mVrBqApjSDAHleuW6T+0lpULiAY+ppIrtdKzeIsajh54QNCqtoaA15ZDX1264Ge2ZA4Vk7tqAfdojP8Gfw8B7Q6h84s+eQWR0yHOyrzWfJE2chSZR35SDtco=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199015)(66476007)(8676002)(66556008)(66946007)(41300700001)(36756003)(2906002)(4326008)(6486002)(6916009)(54906003)(5660300002)(8936002)(4744005)(478600001)(316002)(83380400001)(38100700002)(26005)(53546011)(6506007)(31696002)(86362001)(6512007)(186003)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VTJmQnVaRVp3ZEQ0MGRDTWlrLzc5bUxoSnNON2xyOVhmWFRkbEhxOUxCWmpH?=
 =?utf-8?B?R1hTVVcxdjhzdTFHTkFWOXNyZTV2YlhEWEFPejRLbmhoRHVLUTlaOXhoLzlW?=
 =?utf-8?B?VWJlN3M2aEN4cVdPWmhicUJMSEZ6T29GZ0lkaUdwWFl3OVY5OUZpTmhxcHVT?=
 =?utf-8?B?bFl5QWpqSW1aZldRbHVFMXYzOUxieVhPOEoxaUpqQThSWUt4c0VoRllWdVhX?=
 =?utf-8?B?MVVyTzYxR0x5aG1jblhKS3RCMzFNbGl5ZVZYWGtLUTJPbmYraVMvdlRTazEv?=
 =?utf-8?B?Mkh4R0J0cy94d0ZmVmpqQ1dsbzQrVm9mU2E4TVNJYzdzSGJaazF6NVB6MlBN?=
 =?utf-8?B?dWVoWVB5NEk3LzUyb1NRZVN5Qkw0YzRYLytIRzlrNjk0dXZ1ZG4wbG1NVkkr?=
 =?utf-8?B?NHVYNnVzaFMwTEJnUU40NmVVS1hhWjllT05EWC9waEd6aUhscEJYVVh2NTNy?=
 =?utf-8?B?bU03Y2dxMVI0bzlxQ2RqTE1ycXcrUHFwUUlKTEtPQWNPMUYrUEhuK3FKWW91?=
 =?utf-8?B?T1NoQ1hZQTVNSytUbVh2VzVHaHNZNlNXL0ZUNXl3TFllVEtZeWhDMlhVMlFk?=
 =?utf-8?B?N043cnJpblQvSENyc21SaWUwSEpVNUFmVVl1S2NBSmhtdEZLbmdpMFNSQk1W?=
 =?utf-8?B?bjNUdEpLSHBOcUZXb1k5SWRDWXFKNEJFUzAxMVk5MTVJTmNFMTNQdEVxZ0dx?=
 =?utf-8?B?em4yVnBHbFR5MDZkSmZDQkdONXFTbHo0MElHRG9ocTVvRnFTME1GaklJdTNM?=
 =?utf-8?B?UkJlbUJteDNMQ094NzhmWGxUekNmWUJUL2s4emhwUTI0L28vZE1hbXhHWG9u?=
 =?utf-8?B?YVRITEZiV1R1YVhKNUM0TUpxU0hsZU12NXlaZEthWFAvdlhKMWtSY1lYVCs2?=
 =?utf-8?B?RUkvR3N6MytZejRpK0JzMzhadndEbkEzZ2h2MVVvekNBbFFDSGZnVTFrMDhU?=
 =?utf-8?B?RjNSbHpsa1I1NXRoUkp3YzRyek1BN2VlQUplREowZ2xPenRaY2QyZHJnblNh?=
 =?utf-8?B?WEwvbGVTeTJLUm1tdUlYanlKdUxsVEgzdXZlMGFITjlHaitYN2ZROE1oaGRx?=
 =?utf-8?B?aUNxVjZFWVJ6Q1F2Ty9kZ3d6VTRCaUVZY3N5TmxaVmJBOUZKUHhKanBaSE5w?=
 =?utf-8?B?OFZtMWdCYWdadmtaZHF0emZlR0NKOHdndEp4eDRKWWpIWlM2L0NBbFZ6SDJ1?=
 =?utf-8?B?U1JvekVPZ3ZMV1J1TmJicHFRdWI5M09WRWJZSUcyUUtxTk52MlBCWTNwU3lE?=
 =?utf-8?B?TjA5Z0FGaFdMdmU1RlJtUFNDeVdmbjdaVUU4bU9FT3plU1lQK2NpTFVZWHZq?=
 =?utf-8?B?U0RyMlZlQ3RESVE1bTZyWmNBV0xPemQ1ZktjV0dRNk1XRjBZTTdyajVDaUQ5?=
 =?utf-8?B?cFNwVEY1WEFoRGl6cFlZcE83TWFydnNwMEtLMVJVTExzdjYrUmlOVzNRMmg0?=
 =?utf-8?B?TGZHL0JEcnRKWjEzKzNqVm9nNG5sejV0NDJObjU4aHVtdzg1NjRWd3I1ODNK?=
 =?utf-8?B?cEptU3hFcTQzVTl3aFdTb0ZIdVZqVzJEcDRSRmpRZ09NdGxJVks4Nk52a2VD?=
 =?utf-8?B?b0NFVUIwWlh0c0FzYitpWlRmZmlEeFA3S3B0cWRSellXU0lnZkg3cHBvUXRK?=
 =?utf-8?B?Q08yK2VZUW5QeURvNzNUY1dVUUEvcnF6b2JNWFlScVNnNTJHemJSOTEvdVNr?=
 =?utf-8?B?VmJ4WFd1RmY2WEFRM0pySXY0V2FsMWlURWhJK1Z5NjdBTysrSVBWcWRPLzRj?=
 =?utf-8?B?NDJBNWFQNytSNnpnbXZkUU9QSExOb244RnA3YzRxVldQMndKRTF3T29ocXJR?=
 =?utf-8?B?c0NreUs3dHFmd09neG1jc2t0dmZ6aFE1TUlQaWwzQjBPcE9BY3JhQ3Azc0ZX?=
 =?utf-8?B?VkVFSVJHZHN2Qm5CWjRrMnNrZmNaU3lNYlg1bUFPZXNVdmVydWJXTTNZQ0s5?=
 =?utf-8?B?NDRvcXduRTV4MUlCSFFsV0tCU3hZWlQxUkU3SlRpNDI1bmZFdEZkVU9ZN3ZF?=
 =?utf-8?B?ZStjaXpxcFR4QmdKbUFUbDErNHRZTWFtRGRzR21mSVh3Wm9FZk5XcnNSU2VP?=
 =?utf-8?B?d1NQU3BmWUVLRVppSStQOGRxOTNJZ1lXaXN4SHBMcnk0cUZIY2VDOVFFNzBT?=
 =?utf-8?Q?csuv+2scPtTdbLGXnfi1DVprv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40f65f52-0ca4-4fc3-f945-08dab6a2f559
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 16:07:04.4711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Zxtzr+neO0WpAsM1B47M6ZK6aJxbKIdAi2rpoI38vNV6w7RPhH71vxAzzJVYN4ib0LQxevlDi1lnGifjfYJ1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6816

On 25.10.2022 17:42, Roger Pau Monné wrote:
> On Tue, Oct 11, 2022 at 10:48:38AM +0200, Jan Beulich wrote:
>> Not passing P2M_UNSHARE to get_page_from_gfn() means there won't even be
>> an attempt to unshare the referenced page, without any indication to the
>> caller (e.g. -EAGAIN). Note that guests have no direct control over
>> which of their pages are shared (or paged out), and hence they have no
>> way to make sure all on their own that the subsequent obtaining of a
>> writable type reference can actually succeed.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I didn't Cc you on the initial submission because mem-sharing isn't a
supported feature, but upon reconsideration I thought I'd at least ask
whether you would want to give this a release-ack. I don't really see
any risk associated with it.

Jan


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:18:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:18:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429985.681384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMcz-0000JP-Sy; Tue, 25 Oct 2022 16:18:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429985.681384; Tue, 25 Oct 2022 16:18:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMcz-0000JH-OX; Tue, 25 Oct 2022 16:18:09 +0000
Received: by outflank-mailman (input) for mailman id 429985;
 Tue, 25 Oct 2022 16:18:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bJBo=22=citrix.com=prvs=2902c4af2=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onMcy-0000J7-9j
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:18:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9adffab7-5480-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 18:18:06 +0200 (CEST)
Received: from mail-co1nam11lp2171.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.171])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 25 Oct 2022 12:18:03 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SA1PR03MB6467.namprd03.prod.outlook.com (2603:10b6:806:1c2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 16:17:53 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022
 16:17:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9adffab7-5480-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666714686;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=m+i4sHg7IBkkLa+Mf9gLvszUSJAZauKCbXCfioV8TnU=;
  b=Y1PjSJleNDjCvxPtLOYGrVlVZ55Dyuc8xIfnhuhQoBd8W6KQo6NVq7M1
   BaoQihWmI48aNoUObiGtcSPwk7cp00xeAb7jb+tNTCLvnJmMk8A81GzlG
   ZmE67rZzU7ds9pBhrG62IrIHQHiXi2er9t84zIgCqcvtUoR+7r/E2kkA3
   M=;
X-IronPort-RemoteIP: 104.47.56.171
X-IronPort-MID: 83497631
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3ANLWD9a+3xMfAqnQr+PSdDrVtTnXEGR8FBUUsX?=
 =?us-ascii?q?f3yWtIz9vRTsLWGvXqmPfCZcdWsP4vopu+2z3U3mJjUTX9Z/g/8x71fQczQH?=
 =?us-ascii?q?sjbQWZ1jk0CehxW279Z/Lc5tKK4qroPo3sedcJGL0wKJeJZHIJmkcJamxg03?=
 =?us-ascii?q?bSVN9VOn1zWBZYqc6YutarifwFQleknOyM+4sSnfUELZd0kIk4dPvvn7hvAz?=
 =?us-ascii?q?9EWaU/yFoeIgB65D5G2qixzmfTBFf2d97MHDq4TYIJL0WIXm+wBixsBCydLk?=
 =?us-ascii?q?IG3FCgjB0Q6hzzqEPHoN5m1/w5Sz7UvqkwjMnuJbHf3zH5nILQlVHTmamucE?=
 =?us-ascii?q?D0vXfCBx8rKi66oEBMN2vUTr6X0uid6wB4o++zy43s3kLB3ZKWqzE5HMKvTt?=
 =?us-ascii?q?tj7hW92jNvb4pOsij241YAOWWkUg91oeXftCpwG5JHkcfzQfTpNonjcEQ9Vb?=
 =?us-ascii?q?TYL8wgJGdf19p287r9yM514Mfin5wW32y9QodGGn5h9Hz24v5eCXsX59gKS1?=
 =?us-ascii?q?NZNh1CZ5+PfavAWtYqrZGWTFlPdjjXwiiIOI2doAJvDGxPsgDOvUH9Md9Lhb?=
 =?us-ascii?q?xwngW4bE7CBk1oowyJHrXJ+TmMskvxse7Ek4ZC0GhiaA9JkTxZC6KJIeb3rc?=
 =?us-ascii?q?7n35F9CzOz0ayMvjDT/wR9iLgEiHtw7n9AF9zZZQPlHxr4wM0Rvw8uShBYZB?=
 =?us-ascii?q?9topWEek2Sgq58vhbORCPsGWZWLWM2uQ52pgkSFCpzbz5SaXE9ysJbHSMQb+?=
 =?us-ascii?q?mBJD2+4TP78en2IOlUNRThEChejrLZOUFLajAVRy3lfZ8Fzsb/zGg7rUHFzR?=
 =?us-ascii?q?8aoCGncjgY1wR4PR2/MIvK94dVv9MXWug/xA6RwOWIRQcJaP1gT0zOwSiXW+?=
 =?us-ascii?q?Y7udmofSNv9S2+6gciHaOpFAj9haT0/xhKDlrdxThxCKZWNxIlXxwx53hx2b?=
 =?us-ascii?q?wHE6eLNI2ze8FYpI302TY4jCaCCzUyl7P389B6y4Wy3ZWQNCH0w/vBcdR0u1?=
 =?us-ascii?q?uCMmTA1VcxhwTSSFiD4Oazv00IN1SV82bHYvoRuiqsk/FQKhm1aXxvJwVl5g?=
 =?us-ascii?q?9+QDKGVbzlflsag2ixc6NF3NpCMuUEducFs+XRUnQpaN00PyfclumGn6rUOM?=
 =?us-ascii?q?NQyrcYhqTmx2PS5CRVOHRvoPm64YImIROahjflnRow3IjvBimAFsTkCJjX8J?=
 =?us-ascii?q?ddszaUdRXAfFKV5gXyW1UCgN2+3pcC74pUX/nebNqJ98fHyWPif+KFqDPPjk?=
 =?us-ascii?q?6Uxl1FKnp9EmDHvV6QblQkCu/TDTKUl8Mo47qyu4MQvKATr4BGrFKtVih2Ht?=
 =?us-ascii?q?F6+IASCelyTCJwPtlyPKMESYs3nHPWuhbuLGt0Jg3a05jnXhbAkD6N7FsNCM?=
 =?us-ascii?q?Q1qlR47A7YmBEgXR7KbSmuv9lQLtvz2w1/hU4GFeh81ZbjoNg+xR7AIK+6fa?=
 =?us-ascii?q?OLC9fD3/5trUul44bFv8mhBUsP8PVaOtVrb8znx2Z/shv4a+7SBeG2mMAfJI?=
 =?us-ascii?q?w5GSQw7GAwO3x/U0rVIyC1d4gUAbvZgOVkZjBsvp3vMX4A6exCELRe6pMGdE?=
 =?us-ascii?q?1loma5uPlEfVi7HBg+yizpgLJEFSei6102G5tV8xdWNWVRr+6xGKpv/onerd?=
 =?us-ascii?q?WEXz0gsCZgKeAKDPVo17hP/ClTcB+Wb5h0rrlG4MO/zFUOUXq1CqV/2pnAkq?=
 =?us-ascii?q?NCbDXmMUiRlb6NN9Vi6a4xPzBJCny9gItun0qygq5/dxOEiBhjEPF/Hm8Aet?=
 =?us-ascii?q?yrrY+yi9FQUhf1hzRT9uwkQYjoEvUHSiH+I2MA9zrEJwvIX0OloaOZmNbS7F?=
 =?us-ascii?q?a64iuVeALspS/bt9180ffxCxVXiAn2qmP9k9xskh9woKpHNiNS8qMsmdYok+?=
 =?us-ascii?q?aF3fv4vTgyWC6UoKy88vmKj9rOPg3HVJyDuG4YP4eGyw24ZoO5lEeTu2nSFv?=
 =?us-ascii?q?eibxxrmRi0OszZzk9Q5Q23QaL8v7Fw4yV2gCF0cnfHI+ZWD8zcZK0x5iT8+F?=
 =?us-ascii?q?ydEzDJcrxNWAC8UO83M9nPffytnOHq4QNyGTnSHnwXeQzNcM3QfP63wLrBHk?=
 =?us-ascii?q?xaJM/kjqjz935PzNuf61XcOMPXSpPRcfx2yHHwr5PFoNJCihIvvreI8GnnRM?=
 =?us-ascii?q?v4Gn97uCgSDlDfOwB/FvrEEg27fxWoYdEzd3uRgvlR9hCFezjU2vM287sVNc?=
 =?us-ascii?q?RPZHQj1LLGJA35bkuQCX7aMFdythx2PKFTMM4XGUmtJVg6HYqkBu3rFd29uS?=
 =?us-ascii?q?nf/HzaN8IDDWE982jBv/R9EkilDF6F0WmSIcPPzvDOdw9RXqzCHNcbfZcawe?=
 =?us-ascii?q?iW89JA+7XWnDMjgY1twTbTCwN/RMHoIaq185yMBqBj1Y4O9XgMZ0SFXr212L?=
 =?us-ascii?q?BWTHc2vkJrDAzGbA4BXeJjv+z1nu8MItSEs0bz/p1d3FFDVa2HTm4P+tNsbU?=
 =?us-ascii?q?frmuQikaYowz8sFr/s3uYGBKuX8trXeQ4/0TkQvanSEO/QKQhfEi3BvcVl96?=
 =?us-ascii?q?K/F4lKF6V/Y5BYdbNv6jCyZUB4ZOrmKnCv8?=
X-IronPort-AV: E=Sophos;i="5.95,212,1661832000"; 
   d="scan'208";a="83497631"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RANcz0hXEW84GTbf+trnjjqAqIfwlDrs3mTR1HjHDi1gbKQ/2d+z7JdszQSRZFmVviKCgkBc6c8GBjVd4/p4et765nXhqmwxIc3hQ+WQgCU2qZoEHhUQ2ku40NANbu8JkkKMxl1dPsMQy6LCDQrv+c9/UFUepv52yhGgkXjONmb+sHvaHHeYW2/rRo637Do0nhopOwdM2tCFXsAUvL5nRlaW1zs7Mg2rKmQMf4AmGrG9T8zhNER89Yl1VTXAhBFFLHMNBV5qZmmQzNEMxOBvvnpykU8N4xfMoO3k8ageBwPdKoLAX/l3sNi5j7v8p9dynhPxczEISJKmWa+Go/o5uA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T4w3HFejju8d5NqF0KPC9JTKjG5rn3zs2ISvVqta4EY=;
 b=nze6ddY3xxiYmyffZTw3FKoxUSRnNrm7HHZaZZ7nJ5AJPJgRpf5/liFn0izDglXtA22s37py+jPvxQrfqpHHkq0xjdqN2FaGeVGgQEiZ2BSGA9SrCnRhqLAfWjdcCTrUHP/h2xdTnhdTwulEsN4PW+cLdhZpwancPdFkBtCaE0g93RCO5i1f4zaBJeVdTR2imKScgnqMz0TPCtibvP3tG8pZT7gYoBEWtC/whUoKxvhPMeFzARs0mubY3+RvpxOvFm8s6s7uL9ZL/EnNkXVnTHiypod5Av6dl7V0rCISvOMoawaFHaRqb3ThbA8S9fi7JwkNbPZ74l1rfiicm6F/Cw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=T4w3HFejju8d5NqF0KPC9JTKjG5rn3zs2ISvVqta4EY=;
 b=XtZRkCV+f47drw15WNaY2g2L3ImSKW+HYPtPoznh6twJpGUvuIdarnOr0VP6l2kJ/6wP3iOjE2UEExnHmQyZH3CnVP/MA33EELh4E3E1bZn3SBHFO8aGm1pMe0d9pWC2bbIyA5yso0BVbKDEX2BS3ll4LaNHNhSGa04kQWP8YAY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Tue, 25 Oct 2022 18:17:46 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] common: map_vcpu_info() wants to unshare the underlying
 page
Message-ID: <Y1gMKgWDxjcBOlCn@Air-de-Roger>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
 <Y1gD7GmclguLZCM8@Air-de-Roger>
 <1780acb3-d297-edc6-3a1e-adf8b28a5262@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1780acb3-d297-edc6-3a1e-adf8b28a5262@suse.com>
X-ClientProxiedBy: LO2P265CA0188.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::32) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SA1PR03MB6467:EE_
X-MS-Office365-Filtering-Correlation-Id: 86286596-7030-4506-b77b-08dab6a47731
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	juWQV6zxNI51+SLk662FsB8TDMlmyT+pgMJwcGoI/zSitB3YknYTibWb5MBfKzOjIBchKQTPvEhvpUKuejwmfFUW/qkfsl0xNgLbG3nsuS1q1kqcYf5kV43LdeKIucT3tZzlurh9aCHNES6w61m9hA8eCyhPf7yC3NmObiUakwH1LZT1Iak56WwR+TrEVEhm8DMnWjObjeijsInJvZZYcsoiBFnhcnxdVxxRni9ZXHJAcCXnY5Z3srIdZnLVxpoSmoJ2iO3OyCODxoEer54l0qLdRxAXg4LjUGCh5rNOX3W2RNJdMHjnL5g/XXGa6mYQwPsIgQdJs4kiXSgvNv/k6imLIje+yWC6jB2gKOVDeq54L+aQvW4zeajS+4x4hPZiHDxuXmZ/KLZIVYYL1WE0CmoEYJ8VPfNXpV9kmEKZCJlPpEr1pHZ4SOGfo9E2LFEHPSqqjhKE3m+C8g5KESM51cRYW8yuPacmLzCJRs3ytwaJ8LuPMSJ5uPt68Mr8EB/GmPmAVABswqwoRZ7IL8egUy6MaoZrWjgZUjvAxsYpZBpp87wZQavn6ak3UGw4DCEp9xwR3Bqg1I+y4wiV3x09KAT8VnulVmlFsgArYjncJ0moaRer1wPXlfKN0XULOx8JFLZ4Z1QSWC+9fW1x2pfkQzc2Kx9CXny8StYx7TQBGG9LJQZBv5lstgYKz/XZiyhlRfEAnnN1RP+b3/E1Mrun5g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(366004)(396003)(39860400002)(136003)(376002)(451199015)(66946007)(6512007)(85182001)(86362001)(2906002)(38100700002)(82960400001)(186003)(6666004)(8676002)(6486002)(4326008)(53546011)(26005)(6506007)(6916009)(316002)(66476007)(66556008)(9686003)(5660300002)(54906003)(33716001)(4744005)(478600001)(41300700001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkVDekFkajdZcDBlekxJS3FRUWFweTFXSkdIdXgzaXRvNzRYYU1zSWtFd2ZS?=
 =?utf-8?B?SlB4VVVrMlRPeW9ibkdpV1FrOURteVF5TXFYWDF6NHp6ZkxCZStJcHVwaHJn?=
 =?utf-8?B?TlhTZTYrVGI2N1JQeE9ZT3ZZR25Yd2p6S25yZVcxVllCMmVBRVh5eVhGc1Vm?=
 =?utf-8?B?ejdkSVpPWXJ1dVR1dTFGLzVXOGNlQ01DRXZId2VvNWhuelBzbjRwL1R4L0NM?=
 =?utf-8?B?Y0VoYWhwYTY2MTd5US80am1lL1BJZmovVTFGWHM3alZCYmphc1lhb2pLcEE4?=
 =?utf-8?B?VVhJemxBNXNoTFdub2U5OExmc0hOWWE2MzBCSzRKQ1NweHJJQ1ZRQUVTcTFw?=
 =?utf-8?B?eGh5bFRtNWxiQmF3UFdLbXZDc1ZiREpqQ05LR1lNZzQ3V3ZFQk1mUHVLdFJH?=
 =?utf-8?B?RlRlTzBiaFAycStVMmRzeVRuNnk5R2x4cE1RdDgrSTVrM2JaVjZFNy9JWW5r?=
 =?utf-8?B?YlA1NDMvM3FDNDRqbHRNVzRnbmVqZ3VYZzg1c2JQLzV3cFRkcWJhSGxkdStW?=
 =?utf-8?B?Vm9lM1FLTlVtcTlncWQ1Vk5pdjM0TXhGYk5ONWZoYU9iU0VQa0hkcEl5UmxL?=
 =?utf-8?B?cm9peXQ0OUFVU0p1QlA0QmhqQU5TUVpQbkZZN09zTG15ZzZzcy9zZG1yOFAr?=
 =?utf-8?B?OTJndEJaZlZieGptTHhhSXJmWmhkWmpuWUJNMnVaVGdXczZLRDJQL2RsUHFW?=
 =?utf-8?B?OHY4OUJWUTBQYkVBRmdyMkE4M0JJV20rVU9GenRZTDZ5MXRVVkpkeHczaXZ0?=
 =?utf-8?B?Z2hGQnFNN2RybjZVMmlrQzFnMGZ6dDBzNUxuM1I0S08xbTRnMWZua21WTTQv?=
 =?utf-8?B?Z2s3RC85RWNvZXFaWWV4dmtVWW5oSFdQb3hjMk5RdUdMaHJlb2Q3b0JWbUxV?=
 =?utf-8?B?YnloZnhpdTlxbWthaDN1OGVXcUtMbWxlUm9VSXV6M2wreC96RVZzRXJxQjc2?=
 =?utf-8?B?UkxzMUxOcmw0RHBzck54Zlc1eFc5Y2cvbmtlY2cxNDBOZjVWOXVKanlZa2lI?=
 =?utf-8?B?Q0tVd1I1RG9OV1dIWDduYmszdkxPUkxBVzIrc2Zwbm5nN3RnazBtM21BMnBZ?=
 =?utf-8?B?R0EwenNodGhHSmtwZHducFZxWHlmNzZSUXg5ZVhYTGN3bG1vSUdWalIxSnM2?=
 =?utf-8?B?b0hkcnVoVlFBbmo4ZDJHU2RWZ1FTaVhOTG9oOVc2VWR1aW9pWkY2TWZQRllX?=
 =?utf-8?B?Y2Y2ZW9haVUrVk05elVPWExHekQyQWpsZWdVNEVjWUVad0xabU12Zis5YmRW?=
 =?utf-8?B?T0ZBaXZvV2lOSXN4c3hCc3JzT1RmS0pEakwvTjNXNmZaeGFNYiszNEJkdVo4?=
 =?utf-8?B?K3g3czh0OGNXZkZ1T1JpRkhsMkgrZCtrOXJIazB5VjEyNUR1d1FZOG9ZMnQ2?=
 =?utf-8?B?eDlCWkhNdEJMV1gxeUVUalJBa3hDZURxNnE0cUxjeHhwWDlWRlFLK2R4UXNQ?=
 =?utf-8?B?blVvQ28weVBLb1ZtOXczT1FUdWJuMDZpc1E3bjNTclhiSmQxM3pMeDlwSThG?=
 =?utf-8?B?eVBUUE1DalRoQmlJZkg0RVd5SjIyWG1BN0ZMZVR4bWZ1RUJZWE4rdVhqUk5Y?=
 =?utf-8?B?cTVLelA3ZkFpdXRmSWNsYmk3RTUwTndVVTdDT0hybG1hdEhPdElSc0svVjlx?=
 =?utf-8?B?TlN2VHh1RkxMdWVNbFVwKzhPYTl0VThvSG40Zm9wZ001aDVQMTQ3WTFRbVBO?=
 =?utf-8?B?cFI2KzVCMTBIcEdVcUpnNENJVlBqUCtGcUdsZDE0dVJROW9IaVNMT2xjVUZG?=
 =?utf-8?B?bG5XbEtuNW9TNGl0Q3Q2ZGZTeUpvWnVLWGFwSGV4TWJhRlhneXhNVG5mcyt6?=
 =?utf-8?B?MFVVdmEwVlFPRzNVMkZMVlVOUHNHT2tKcjIrUytoTG9HR2l4Q2NNMGlsYTVl?=
 =?utf-8?B?Y2dzKzNUayszOWk0eVRHRlV5Y3JmeSt1d2hLbjFoSSswakQ5MWZKWGN2dmZR?=
 =?utf-8?B?bHNGOFo2Ym54S3N1c3gvMlFydnRZbHZrREZ6bS9VejIzeVhLeVoxUm1Oa1Rj?=
 =?utf-8?B?Tit4SFZ4a0dpREN5RmN3QkxDYUhvWlVXaW5CUUUyUVBIVXVFQjI0OFRxNGZj?=
 =?utf-8?B?NmoxYmErQ1dYWjhTQUJLcStkREV1eWFZSTdSL2hSclVNcDJZOGVkRmRTMnFW?=
 =?utf-8?B?WVVUSWtMcVJ3TVIweHlRQWkvQ0FaNzFoTGdVek1lRmVnckY5ZG9tM3FjWk82?=
 =?utf-8?B?MHc9PQ==?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86286596-7030-4506-b77b-08dab6a47731
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 16:17:53.4489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0G1+nE31qkPBwaub0EJ5hx7sJVrHMc4bqQkO+7juncVcIkf/KZR9P5qU+7MqPg2P/Ob1p5aHH4TXtH8ks6dDbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6467

On Tue, Oct 25, 2022 at 06:04:49PM +0200, Jan Beulich wrote:
> On 25.10.2022 17:42, Roger Pau Monné wrote:
> > On Tue, Oct 11, 2022 at 10:48:38AM +0200, Jan Beulich wrote:
> >> --- a/xen/common/domain.c
> >> +++ b/xen/common/domain.c
> >> @@ -1484,7 +1484,7 @@ int map_vcpu_info(struct vcpu *v, unsign
> >>      if ( (v != current) && !(v->pause_flags & VPF_down) )
> >>          return -EINVAL;
> >>  
> >> -    page = get_page_from_gfn(d, gfn, NULL, P2M_ALLOC);
> >> +    page = get_page_from_gfn(d, gfn, NULL, P2M_UNSHARE);
> > 
> > I had to go look up that P2M_UNSHARE implies P2M_ALLOC for the users
> > of the parameter, it would be helpful to add a comment in p2m.h that
> > UNSHARE implies ALLOC.
> 
> Same here, plus I needed to further figure out that the same implication
> missing on Arm is okay merely because they ignore the respective argument.

... it's made worse by some callers using P2M_ALLOC | P2M_UNSHARE
which adds to the confusion.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:20:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:20:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429989.681394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMey-0001fV-6u; Tue, 25 Oct 2022 16:20:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429989.681394; Tue, 25 Oct 2022 16:20:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMey-0001fO-4B; Tue, 25 Oct 2022 16:20:12 +0000
Received: by outflank-mailman (input) for mailman id 429989;
 Tue, 25 Oct 2022 16:20:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8WBn=22=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1onMex-0001fI-2G
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:20:11 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e57c1c95-5480-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 18:20:10 +0200 (CEST)
Received: by mail-lj1-x22a.google.com with SMTP id b8so10978773ljf.0
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 09:20:10 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 a16-20020a2eb550000000b002770302bdffsm540136ljn.105.2022.10.25.09.20.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 25 Oct 2022 09:20:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e57c1c95-5480-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=s53x+nJuJzQXZZ8xIG3UoaBPvSj9GLUN61aOWqvjPbk=;
        b=fmlyNG02R5wPSQmaT7mCq+Tp1GXMFdyykFhnVmxVFKgk2bP+7H7mUuRdls1ejlfymv
         nwAbpLqSS4xWyJoKQ79Y47SFIikXg/70YNcmnF5fMiy+5BHQzMKfQJ/N2qR085/5+wYk
         CO+BIjE0lTKTWB2xUGnEBOmC8ul0XMgwdlrLEDojS29H+k9RX4vGj4MDy5SxjMy4MOTi
         0BKdT0jYgyAf6+KhrBvxMY8JYcphKs82gCX9r/twr2yH1P8ldvltwfOKIHj1yMZRExRw
         wLJ1p41G4IZXkpwOwXybJzpzSGdYs6VaOseQtcLhJKV1pp1zvksgE3qaJHaNpldd/3ha
         IIZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=s53x+nJuJzQXZZ8xIG3UoaBPvSj9GLUN61aOWqvjPbk=;
        b=INl0s51BukIiy2Fqo1Kro8uDuVX7HiicBeugs2bMNW5LucOv13/FIVOyecCzTqYrDz
         XFR2GxHpnp+/ejUshsfa1tNCHCUXfZm7MULpQrvlSgnEKrTtAw+6J2RuLTnpt3DJIq3i
         byJixtcSx0DZaDgRrvjbrcWIeTDMEQzWDpN5JOccJ2qulFvDSg0oAWsiXuUjT5kvfLn9
         d4iQaZB0Ga/KTE1mn3x+HQ9kOo5eMB8Y4J7yfjylGWm0L3kM/Hsu7HYudl/yMSWkYHb2
         XpYGGKZCCpdZU4bGUP6bG+u+ldxvfRSqgD8Rp5kHZ7F8TRW2qpxPwXnQAH2XjmZtW6Q5
         eE+Q==
X-Gm-Message-State: ACrzQf1Zp8jI57fNcc8qg+/DklrRs4wuTHt2lZeFt+sdAbFyQnPKkgZb
	mO9xqrbGq5u9aQW+r5GL5xlDdmqlVPk=
X-Google-Smtp-Source: AMsMyM6faqKizlNwmmsyhdfdxjCXQ6dkHWEVrkrCBzAwMgu6P/AcUuOk+eV32z0fVYbZdVn+Qd7yNQ==
X-Received: by 2002:a2e:a910:0:b0:26a:ed13:cda6 with SMTP id j16-20020a2ea910000000b0026aed13cda6mr13710361ljq.250.1666714809166;
        Tue, 25 Oct 2022 09:20:09 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V4 0/2] xen/virtio: Handle PCI devices which Host controller is described in DT
Date: Tue, 25 Oct 2022 19:20:02 +0300
Message-Id: <20221025162004.8501-1-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

Prior to V4 there was a single patch, for V4 an additional prereq patch appeared according
to the discussion at:
https://lore.kernel.org/xen-devel/alpine.DEB.2.22.394.2210211258050.3873@ubuntu-linux-20-04-desktop/

Based on:
https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1

Oleksandr Tyshchenko (2):
  xen/virtio: Optimize the setup of "xen-grant-dma" devices
  xen/virtio: Handle PCI devices which Host controller is described in
    DT

 arch/arm/xen/enlighten.c    |   2 +-
 drivers/xen/grant-dma-ops.c | 105 ++++++++++++++++++++----------------
 include/xen/arm/xen-ops.h   |   4 +-
 include/xen/xen-ops.h       |  16 ------
 4 files changed, 60 insertions(+), 67 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:20:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:20:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429990.681405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMf1-0001vz-EK; Tue, 25 Oct 2022 16:20:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429990.681405; Tue, 25 Oct 2022 16:20:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMf1-0001vs-BX; Tue, 25 Oct 2022 16:20:15 +0000
Received: by outflank-mailman (input) for mailman id 429990;
 Tue, 25 Oct 2022 16:20:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8WBn=22=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1onMez-0001rM-D1
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:20:13 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e685419e-5480-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 18:20:11 +0200 (CEST)
Received: by mail-lf1-x136.google.com with SMTP id j16so3396894lfe.12
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 09:20:11 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 a16-20020a2eb550000000b002770302bdffsm540136ljn.105.2022.10.25.09.20.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 25 Oct 2022 09:20:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e685419e-5480-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=UV2oUhVEfu6LblayNLcdu/AQ1PbbiXWA9+mIDyTGomE=;
        b=jHP8bromagJtShAR4OXQqOiiJnYOMZ99PKWZmleaWTvbqPcpz+1WleJuAYpfL7lg2D
         I6Qaq/wQzFvNdBhh5APfDP0dBEMs9x9bSepGL4BZxmDiKWc5lcm8z3EQV65vVVayn0+8
         eYL9t7oKfgH94k2clhjYAywHHF36WGOQy5Iu6BFyV//AMTlyEjF+bSTCVbTV9FHTFPjO
         lqhAEbSWveWcXPsD08vtJi9A/YilEMzV0lx/zp6Yu7wh5+vA0nGuC/8wGquRG/5J4vby
         1gSkgUzUP5Qj2w+8mVKNvowFNLA+aBXoBtFAtG3qAUkgv0b++3IOaYgwC25AgKLHpNB1
         W/dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=UV2oUhVEfu6LblayNLcdu/AQ1PbbiXWA9+mIDyTGomE=;
        b=Yfdc2TVcKlWId91w8GxeRjn9e1SzwUAr0Jjl/mkVIjw+j/PVgb5H4UKzvzqzYa+Utv
         ukhB2LmK/V1cQAQ6iIU6hxLq6HSP7nG4Pjz8oyeotWSiDhYH18SA3qiuRoYd6YM/PoXE
         S53o+e6v6BgL/kgv0L9GpmvJRF9MXWft7I7vnHp03+87kzGZu3aDgB8JmzXSIysWwKue
         Wz9uJWXv/zfg451Efp5Wu6PVTCP3BFPyKXzGQ7scrLIQyfs7RWgihfLBbfrbjsPDieT2
         CgPWtqkkKlpazNKi70pFUnygg8lfvhLRkyD5kmQPJ4LwTc4Bm+TXipq5jfQH7h44XlQQ
         Fi7Q==
X-Gm-Message-State: ACrzQf2Io71zMAmii4ocktpBVoR9gZ3TBaFoP0d5FQP8jdcWln5VVkFE
	U13v+QRSNCDNqlnVGCz4goDYipsj9q8=
X-Google-Smtp-Source: AMsMyM7vTkKKKxpLC2kahjXumjJuMQ9qspfZXCsmk6MxMMlz27MpanKsalOSPJ4gBzGwfkX8DmkhEg==
X-Received: by 2002:a19:3857:0:b0:4ac:eca1:9275 with SMTP id d23-20020a193857000000b004aceca19275mr2862744lfj.97.1666714810866;
        Tue, 25 Oct 2022 09:20:10 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V4 1/2] xen/virtio: Optimize the setup of "xen-grant-dma" devices
Date: Tue, 25 Oct 2022 19:20:03 +0300
Message-Id: <20221025162004.8501-2-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221025162004.8501-1-olekstysh@gmail.com>
References: <20221025162004.8501-1-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is needed to avoid having to parse the same device-tree
several times for a given device.

For this to work we need to install the xen_virtio_restricted_mem_acc
callback in Arm's xen_guest_init() which is same callback as x86's
PV and HVM modes already use and remove the manual assignment in
xen_setup_dma_ops(). Also we need to split the code to initialize
backend_domid into a separate function.

Prior to current patch we parsed the device-tree three times:
1. xen_setup_dma_ops()->...->xen_is_dt_grant_dma_device()
2. xen_setup_dma_ops()->...->xen_dt_grant_init_backend_domid()
3. xen_virtio_mem_acc()->...->xen_is_dt_grant_dma_device()

With current patch we parse the device-tree only once in
xen_virtio_restricted_mem_acc()->...->xen_dt_grant_init_backend_domid()

Other benefits are:
- Not diverge from x86 when setting up Xen grant DMA ops
- Drop several global functions

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
New patch
---
 arch/arm/xen/enlighten.c    |  2 +-
 drivers/xen/grant-dma-ops.c | 77 ++++++++++++++-----------------------
 include/xen/arm/xen-ops.h   |  4 +-
 include/xen/xen-ops.h       | 16 --------
 4 files changed, 30 insertions(+), 69 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 93c8ccbf2982..7d59765aef22 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -445,7 +445,7 @@ static int __init xen_guest_init(void)
 		return 0;
 
 	if (IS_ENABLED(CONFIG_XEN_VIRTIO))
-		virtio_set_mem_acc_cb(xen_virtio_mem_acc);
+		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
 
 	if (!acpi_disabled)
 		xen_acpi_guest_init();
diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index daa525df7bdc..1e797a043980 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -292,50 +292,20 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
-static bool xen_is_dt_grant_dma_device(struct device *dev)
-{
-	struct device_node *iommu_np;
-	bool has_iommu;
-
-	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
-	has_iommu = iommu_np &&
-		    of_device_is_compatible(iommu_np, "xen,grant-dma");
-	of_node_put(iommu_np);
-
-	return has_iommu;
-}
-
-bool xen_is_grant_dma_device(struct device *dev)
-{
-	/* XXX Handle only DT devices for now */
-	if (dev->of_node)
-		return xen_is_dt_grant_dma_device(dev);
-
-	return false;
-}
-
-bool xen_virtio_mem_acc(struct virtio_device *dev)
-{
-	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain())
-		return true;
-
-	return xen_is_grant_dma_device(dev->dev.parent);
-}
-
 static int xen_dt_grant_init_backend_domid(struct device *dev,
-					   struct xen_grant_dma_data *data)
+					   domid_t *backend_domid)
 {
 	struct of_phandle_args iommu_spec;
 
 	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
 			0, &iommu_spec)) {
-		dev_err(dev, "Cannot parse iommus property\n");
+		dev_dbg(dev, "Cannot parse iommus property\n");
 		return -ESRCH;
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
 			iommu_spec.args_count != 1) {
-		dev_err(dev, "Incompatible IOMMU node\n");
+		dev_dbg(dev, "Incompatible IOMMU node\n");
 		of_node_put(iommu_spec.np);
 		return -ESRCH;
 	}
@@ -346,12 +316,28 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
 	 * The endpoint ID here means the ID of the domain where the
 	 * corresponding backend is running
 	 */
-	data->backend_domid = iommu_spec.args[0];
+	*backend_domid = iommu_spec.args[0];
 
 	return 0;
 }
 
-void xen_grant_setup_dma_ops(struct device *dev)
+static int xen_grant_init_backend_domid(struct device *dev,
+					domid_t *backend_domid)
+{
+	int ret = -ENODEV;
+
+	if (dev->of_node) {
+		ret = xen_dt_grant_init_backend_domid(dev, backend_domid);
+	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain()) {
+		dev_info(dev, "Using dom0 as backend\n");
+		*backend_domid = 0;
+		ret = 0;
+	}
+
+	return ret;
+}
+
+static void xen_grant_setup_dma_ops(struct device *dev, domid_t backend_domid)
 {
 	struct xen_grant_dma_data *data;
 
@@ -365,16 +351,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
 	if (!data)
 		goto err;
 
-	if (dev->of_node) {
-		if (xen_dt_grant_init_backend_domid(dev, data))
-			goto err;
-	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
-		dev_info(dev, "Using dom0 as backend\n");
-		data->backend_domid = 0;
-	} else {
-		/* XXX ACPI device unsupported for now */
-		goto err;
-	}
+	data->backend_domid = backend_domid;
 
 	if (store_xen_grant_dma_data(dev, data)) {
 		dev_err(dev, "Cannot store Xen grant DMA data\n");
@@ -392,12 +369,14 @@ void xen_grant_setup_dma_ops(struct device *dev)
 
 bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
 {
-	bool ret = xen_virtio_mem_acc(dev);
+	domid_t backend_domid;
 
-	if (ret)
-		xen_grant_setup_dma_ops(dev->dev.parent);
+	if (!xen_grant_init_backend_domid(dev->dev.parent, &backend_domid)) {
+		xen_grant_setup_dma_ops(dev->dev.parent, backend_domid);
+		return true;
+	}
 
-	return ret;
+	return false;
 }
 
 MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
index b0766a660338..70073f5a2b54 100644
--- a/include/xen/arm/xen-ops.h
+++ b/include/xen/arm/xen-ops.h
@@ -8,9 +8,7 @@
 static inline void xen_setup_dma_ops(struct device *dev)
 {
 #ifdef CONFIG_XEN
-	if (xen_is_grant_dma_device(dev))
-		xen_grant_setup_dma_ops(dev);
-	else if (xen_swiotlb_detect())
+	if (xen_swiotlb_detect())
 		dev->dma_ops = &xen_swiotlb_dma_ops;
 #endif
 }
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index a34f4271a2e9..47f11bec5e90 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -216,26 +216,10 @@ static inline void xen_preemptible_hcall_end(void) { }
 #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
 
 #ifdef CONFIG_XEN_GRANT_DMA_OPS
-void xen_grant_setup_dma_ops(struct device *dev);
-bool xen_is_grant_dma_device(struct device *dev);
-bool xen_virtio_mem_acc(struct virtio_device *dev);
 bool xen_virtio_restricted_mem_acc(struct virtio_device *dev);
 #else
-static inline void xen_grant_setup_dma_ops(struct device *dev)
-{
-}
-static inline bool xen_is_grant_dma_device(struct device *dev)
-{
-	return false;
-}
-
 struct virtio_device;
 
-static inline bool xen_virtio_mem_acc(struct virtio_device *dev)
-{
-	return false;
-}
-
 static inline bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
 {
 	return false;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:20:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:20:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.429991.681412 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMf1-000202-QG; Tue, 25 Oct 2022 16:20:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 429991.681412; Tue, 25 Oct 2022 16:20:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMf1-0001zi-ME; Tue, 25 Oct 2022 16:20:15 +0000
Received: by outflank-mailman (input) for mailman id 429991;
 Tue, 25 Oct 2022 16:20:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8WBn=22=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1onMf0-0001rM-6V
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:20:14 +0000
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com
 [2a00:1450:4864:20::235])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e7435efd-5480-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 18:20:13 +0200 (CEST)
Received: by mail-lj1-x235.google.com with SMTP id bn35so8968089ljb.5
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 09:20:13 -0700 (PDT)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id
 a16-20020a2eb550000000b002770302bdffsm540136ljn.105.2022.10.25.09.20.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 25 Oct 2022 09:20:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7435efd-5480-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=CPiIK7IlsJ7E5VINPN3ej70LIynHg49PxYxMULv6O+g=;
        b=Mcz2WFP8uCN+2nT+Y2LCXeXAkKPmjH58QmfnmrZDOcN5K+WTU1Mcmjc/sFiQ90Bg/t
         iXNEQCCA+E/XCB83vWVHG0V6MPAib92POhRWkYfk5ka1gkSSEt+bQpjEWq/8lbYkIU47
         Qs6eTgoLMfjLQlEgA0MhoYBOoKGLl1E/5LpfAyhxMTJBUIZSjejfGvCjir8IMkmKJ0Kp
         hMc/y55iOxg9vqAcs2CTMCZNI+Vxr0Pwzx00U42fhwCvw8zAFp4qDdkLj+YdFzQCuhQp
         mbrxa+MAlZEHS/+kprmjC+KVPUcTjOvZTzB2rAWsHtjgStKg5yumkz3HxKOEOf2ahil3
         Yy2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=CPiIK7IlsJ7E5VINPN3ej70LIynHg49PxYxMULv6O+g=;
        b=OV/kwUaeNWj+fOf9jTrHyQC8LanWvG0CM+gXb0NU2WZ+cbcssYjXGuLMgpE6/bDJJs
         pgBoeewYeOnmg1vgn6Vq/lbEIF0yoOQuVHfyYWa29e7eEy6Wl8ybQt3QGICDokOFO8v4
         O5qIMnKVFgk0Ej7voJpNzPho+gg7tHCejEgkGPyC15wUyfABbhcUmssL7MAY7RCUYT/g
         0FpfsHNvazkCLBgmLKoH6o/pKiL7BYN81+TCJtU2QYHzkEr88VXGW31hxKRxLyLwwP58
         eknWsd9mWDL8dmAqpPxmmNZknDKRxRvf5ovv4EaJAK2AA7bK//i7d1o1GpieJV2bpf2n
         CZDQ==
X-Gm-Message-State: ACrzQf1hUvuCBYCekm+HLWuLWmO6sbVyZcgf7/sa6lcg8NbPv2a537e6
	21bVxFrluW5Igty7V9oLLEOHFui8KNE=
X-Google-Smtp-Source: AMsMyM62fltFfmb8eUA4lFmsFonT3s3D9baIIhB+ZUg06Ktu/2pzGx7vkhjbjBeMjDCfkQWNML2TEg==
X-Received: by 2002:a05:651c:33c:b0:277:e2b:de4a with SMTP id b28-20020a05651c033c00b002770e2bde4amr3738346ljp.55.1666714812379;
        Tue, 25 Oct 2022 09:20:12 -0700 (PDT)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Juergen Gross <jgross@suse.com>,
	Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: [PATCH V4 2/2] xen/virtio: Handle PCI devices which Host controller is described in DT
Date: Tue, 25 Oct 2022 19:20:04 +0300
Message-Id: <20221025162004.8501-3-olekstysh@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221025162004.8501-1-olekstysh@gmail.com>
References: <20221025162004.8501-1-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Use the same "xen-grant-dma" device concept for the PCI devices
behind device-tree based PCI Host controller, but with one modification.
Unlike for platform devices, we cannot use generic IOMMU bindings
(iommus property), as we need to support more flexible configuration.
The problem is that PCI devices under the single PCI Host controller
may have the backends running in different Xen domains and thus have
different endpoints ID (backend domains ID).

Add ability to deal with generic PCI-IOMMU bindings (iommu-map/
iommu-map-mask properties) which allows us to describe relationship
between PCI devices and backend domains ID properly.

To avoid having to look up for the PCI Host bridge twice and reduce
the amount of checks pass an extra struct device_node *np to
xen_dt_grant_init_backend_domid().

So with current patch the code expects iommus property for the platform
devices and iommu-map/iommu-map-mask properties for PCI devices.

The example of generated by the toolstack iommu-map property
for two PCI devices 0000:00:01.0 and 0000:00:02.0 whose
backends are running in different Xen domains with IDs 1 and 2
respectively:
iommu-map = <0x08 0xfde9 0x01 0x08 0x10 0xfde9 0x02 0x08>;

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
Here, for PCI devices we use more flexible way to pass backend domid to the guest
than for platform devices.

Changes V1 -> V2:
   - update commit description
   - rebase
   - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings

Changes V2 -> V3:
   - update commit description, add an example
   - drop xen_dt_map_id() and squash xen_dt_get_pci_host_node() with
     xen_dt_get_node()
   - pass struct device_node *np to xen_is_dt_grant_dma_device() and
     xen_dt_grant_init_backend_domid()
   - pass domid_t *backend_domid instead of struct xen_grant_dma_data *data
     to xen_dt_grant_init_backend_domid()

Changes V3 -> V4:
   - just rebase on new prereq patch
     "xen/virtio: Optimize the setup of "xen-grant-dma" devices"

Previous discussion is at:
https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/20221015153409.918775-1-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/20221021172408.77397-1-olekstysh@gmail.com/

Based on:
https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
---
---
 drivers/xen/grant-dma-ops.c | 46 +++++++++++++++++++++++++++++++------
 1 file changed, 39 insertions(+), 7 deletions(-)

diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
index 1e797a043980..9784a77fa3c9 100644
--- a/drivers/xen/grant-dma-ops.c
+++ b/drivers/xen/grant-dma-ops.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/dma-map-ops.h>
 #include <linux/of.h>
+#include <linux/pci.h>
 #include <linux/pfn.h>
 #include <linux/xarray.h>
 #include <linux/virtio_anchor.h>
@@ -292,15 +293,43 @@ static const struct dma_map_ops xen_grant_dma_ops = {
 	.dma_supported = xen_grant_dma_supported,
 };
 
+static struct device_node *xen_dt_get_node(struct device *dev)
+{
+	if (dev_is_pci(dev)) {
+		struct pci_dev *pdev = to_pci_dev(dev);
+		struct pci_bus *bus = pdev->bus;
+
+		/* Walk up to the root bus to look for PCI Host controller */
+		while (!pci_is_root_bus(bus))
+			bus = bus->parent;
+
+		return of_node_get(bus->bridge->parent->of_node);
+	}
+
+	return of_node_get(dev->of_node);
+}
+
 static int xen_dt_grant_init_backend_domid(struct device *dev,
+					   struct device_node *np,
 					   domid_t *backend_domid)
 {
-	struct of_phandle_args iommu_spec;
+	struct of_phandle_args iommu_spec = { .args_count = 1 };
 
-	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
-			0, &iommu_spec)) {
-		dev_dbg(dev, "Cannot parse iommus property\n");
-		return -ESRCH;
+	if (dev_is_pci(dev)) {
+		struct pci_dev *pdev = to_pci_dev(dev);
+		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
+
+		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_spec.np,
+				iommu_spec.args)) {
+			dev_dbg(dev, "Cannot translate ID\n");
+			return -ESRCH;
+		}
+	} else {
+		if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
+				0, &iommu_spec)) {
+			dev_dbg(dev, "Cannot parse iommus property\n");
+			return -ESRCH;
+		}
 	}
 
 	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
@@ -324,10 +353,13 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
 static int xen_grant_init_backend_domid(struct device *dev,
 					domid_t *backend_domid)
 {
+	struct device_node *np;
 	int ret = -ENODEV;
 
-	if (dev->of_node) {
-		ret = xen_dt_grant_init_backend_domid(dev, backend_domid);
+	np = xen_dt_get_node(dev);
+	if (np) {
+		ret = xen_dt_grant_init_backend_domid(dev, np, backend_domid);
+		of_node_put(np);
 	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain()) {
 		dev_info(dev, "Using dom0 as backend\n");
 		*backend_domid = 0;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Oct 25 16:26:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 16:26:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430003.681428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMkn-0003f1-Oa; Tue, 25 Oct 2022 16:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430003.681428; Tue, 25 Oct 2022 16:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onMkn-0003eu-LS; Tue, 25 Oct 2022 16:26:13 +0000
Received: by outflank-mailman (input) for mailman id 430003;
 Tue, 25 Oct 2022 16:26:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LEuh=22=epam.com=prvs=2297fba9c9=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1onMkm-0003eo-2d
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 16:26:12 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba07d881-5481-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 18:26:08 +0200 (CEST)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29PF3iDE026216;
 Tue, 25 Oct 2022 16:25:55 GMT
Received: from eur02-db5-obe.outbound.protection.outlook.com
 (mail-db5eur02lp2109.outbound.protection.outlook.com [104.47.11.109])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3kdvgdvm29-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 25 Oct 2022 16:25:55 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by DB9PR03MB7226.eurprd03.prod.outlook.com (2603:10a6:10:228::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct
 2022 16:25:52 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5746.023; Tue, 25 Oct 2022
 16:25:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba07d881-5481-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FEy/CqQNCgsAtT8gwz6wNbNhUZHmrYi8i/RkSbjdgcb0Gs+u5RgGVM7+a00fDpVMdQE1bE0a6r7m/i9XeuSEEzXPjePGXx0UtRyJ8Dg9xrJh8j5U++fe5aaJzqmhNF0Io3L2fO6LUQLiODfRSnUJF9ajk+jyEZXL7Pbx7ixgZ0Wugz077lYx+f39w2riJaycsfV0L/gSCPWYYCMj+eltEbtptqX2bT7EDmFLwL3P3w8+o0JLiQGVcX//KDbrpTV8GKAXm7/iz4wM29zKjmOt1FdUzvGrI18eYKpuwveY7DvZYsU6wN4Z+aMt5ZnUWHp7tOtnMRXfxEadk4Uur2EbnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XNlmDzl1MebTrniIcNmJecUfBBf2uZ//Sak92BmCbR4=;
 b=dAhKpHpb1Sk4VaE7PYVPINIiOgn5yC5om5qvfM9AeoyYPjs0kfqaL9ztRaea6p5eFJ/3BiZ/oFLboIKDgj9CjvKvCaQZNMz1Gj0PQUdvY6xmi4/zLLsnMWb+Cp6jLJlS4JPEGvT7W/8stuih5iL/gjqa+RI8tdZILEIMxKwvqxfq5QkqKVfj62j3YlFE6iO+S8Fdp4UUiR2UK1RAZFS/c421mT4stGMpv5Fw8QdvPp3oZLC5zPT6Slx5ujCRnDgJuYHwBqVqibwV73g4hHIMEeE8fYKw3KlgllQ9xOsgmz5qIiojT/l8YPhRT3Rq3qOgxpkVbgO8W1cG6UXhOZCYPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XNlmDzl1MebTrniIcNmJecUfBBf2uZ//Sak92BmCbR4=;
 b=W/8wDwAO2iQKEKIWRHsSfWZQZeAfd1MTNhUUuTHhYrAWuJjfac+Mffs+uIWHVtkNgWAFTwxyrf0smYmX2X05v6c0UbsiLk+dXgRwfUT5PCg0EMlwRepWvU3G28x3F7ERgfFRDKN+Jl0i+NOIEzwM3ikGN0v1XwQUZowaJ9JujBs2Cyt1IU+1svW7lz9NlST1lPa0gbE7nizP6hx12Y8REC5tsifGY+oji3fXxJAgIZ9ks3Fwu3l2m6MiYA5bSOqBKG61PXTnTKbu4qQ7zIuQPkezsocXjkuNkx/7yHL7ESauIRskWEHl0ffkaP4QI+K8Bfczro9OgGWqqdhoxzSu6w==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko <olekstysh@gmail.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Xenia
 Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V3] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Topic: [PATCH V3] xen/virtio: Handle PCI devices which Host controller
 is described in DT
Thread-Index: AQHY5XHz83EOKasQhkiM6N76eMhvp64ZRukAgACxiACABVmJAA==
Date: Tue, 25 Oct 2022 16:25:52 +0000
Message-ID: <e6f7aa56-33c9-40e8-706b-bbe54c6d26b1@epam.com>
References: <20221021172408.77397-1-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2210211258050.3873@ubuntu-linux-20-04-desktop>
 <339d6029-8a96-6c8d-b6b7-64af956ff886@epam.com>
In-Reply-To: <339d6029-8a96-6c8d-b6b7-64af956ff886@epam.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|DB9PR03MB7226:EE_
x-ms-office365-filtering-correlation-id: 737bee50-7ea5-44d1-2b50-08dab6a595b1
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ++W8z17K0Wsu3lZVBqLL1f2C6MVcm3ZdSb1Ph+4qhoBRvSxtLIiBEQQ7lX1WetOY8up3wc/fwwQcudjR+fU39yGnQ6LHtCQc2xWHivGKgLgkKIWUgs7Fi3q97waZlaxwja+v+gDLpkxawl7LcOBZPcp7zzO6q7kUWDqLFA3it8BFoghZ9VO59dLsdyHjSuteQeD2o+BwKVeFRxousGUl2lhzFGCJDsuUgjE62EC5/iWNgPOrBK29y9KjtnG7q2WITqZDt+KAbLZeMexnbmKf5Ry+RQXPGTD6Zjz1H/IawhRRd5TOQMNFk1+/XHOpTKZBInRZ5ANFdKSN1ys6e0qI+tfBI9Y/68f/rAJ+rvP/0hjDzh4bVVd8oMHbf46eqN4L1R6r/kosKO45fzxGuMUdHKQiSr+XIeEPaY7wveT6MoR9a19i4B6rqIEBINnq69Pxh5/a0vRbB1g5lT2/Hv7yXZPdBXKsLQH2obgwUgt8i+1JxjHcZvLGpZYOAwdH65D0F+M7w0dwK+dp4WjR9qKDEX9BGYJ+bSdfK2NlzhMUZ8lvaYxer5YHZgjyVEPKT7iunWlmthaELN74kG0P/0jqgqtOMQxUNoHNlzpSWuIGGupnUKID8CzOdG7ZkO5RooxJ7ZFjxAgB8fdwbHoxurfZs6ymsBCpkRE6ADdh1gQsFKlDDQ2IlZvPChNnuNDQJbFlL8L0jbmCE8Mi639Xh4Bs5F5XTS8ie3je/tM9hkq5vZ7YLEv8PMtowPYvBosTRh/eSQXQb/xJQEalqqTlNynJVLW2eKDTKs3r7VHvxW2YyKtQY3s05vPIV9RP8LWlggiqclfGTK+6AzEkeBNBtwYfMvo3c3AoQ/xMAgnN+QSqug8Jg+d/z0qRy1tPqyM1d3I9
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199015)(36756003)(8936002)(54906003)(6916009)(316002)(66946007)(4326008)(76116006)(66476007)(66446008)(64756008)(66556008)(41300700001)(8676002)(478600001)(71200400001)(6486002)(966005)(83380400001)(5660300002)(38070700005)(38100700002)(122000001)(31696002)(26005)(53546011)(6506007)(55236004)(6512007)(86362001)(186003)(2616005)(31686004)(2906002)(91956017)(66899015)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?OHp5ZEd1VER2NU9KaXBOZmhyeGc5ZVRVUTRiT1k3dzBZRFZhTFpaYXpHUTl5?=
 =?utf-8?B?UDJHV0UxTC8vTStYQXBDamoySllObGt6cHc4ZEJUMmpsK3ExTFNtTlFVMURV?=
 =?utf-8?B?VXdWRVROdWFXdVkvSzBxY2E3Y01aWEMwdzhkNmx3N2FQNzBVV05xSEg0V214?=
 =?utf-8?B?a3pzd0psd1FjeG1yZGE3a0tQVVpaVnY1WEk5OFRUcjJXSlpuZFdBdTdLUklZ?=
 =?utf-8?B?M05Lckw3d3FGTEE0R3RmcXg1RFAyZk4wclhDVHFCWFllYjNTRkJNYzhBNW9Z?=
 =?utf-8?B?d1h0c3lzVWhKcmdMU000WnhKNVc0RmFuc0VCYW1qcjAyemFrYmxhajZzVEtK?=
 =?utf-8?B?ZzQxOWNGNnU4dkVSSCtUdFNMUXVLdjZMRHNBZDVCWldmU0FWM2R0S2ppYWJS?=
 =?utf-8?B?QXNrUkxuWHU2Z3FqTis3dFdFU2IvRHRQcW4wSXk4ei85OU5ZVmNHZFBZYmVt?=
 =?utf-8?B?Vmsvd3NGRWZUWHpFQlFHalVEbXRCNmRwVFR3M3Nvd3lvUVhIRitJTUFaUGpt?=
 =?utf-8?B?OTVvK0ZNaWpvTkRuR3FDM1FEUVFJUmswbks0L0FIT2l6dHNNZGxKeHdRZkZr?=
 =?utf-8?B?Nlhza0EzTmJWNE82bm9HczVYNXNOTFJrR0pTam5qRFN6ZkR5MGFncEhxL3pD?=
 =?utf-8?B?alpuWnJMRmx1d01kZitVYXBOUVFUQkJ6N2tVNUd4N0VSb2VlQ0hQcGpCQjAx?=
 =?utf-8?B?VHVXWDVidHBDY3dHY21DWHJBU2hVanI4VmZMN1N6bk45b0IvSWNjN29PamtR?=
 =?utf-8?B?WnJwSU5RVnFnY2tYLzJJVk1DanhDS2lnS0U2M2luMjZnY2hseG8yeUN2L2hq?=
 =?utf-8?B?bnJ2UmlWMTV3RlN0L2JGSm5JbzJBd2pTQjVNYVkrVjJTSHpnSm5UUEJHWUxU?=
 =?utf-8?B?b0Ezc1VoK2JkblE2Y3MxLyt0R2tYeWRIRVZmVFZCdWxkaDlqOUozRHhzbkFF?=
 =?utf-8?B?Nm5LUmovbytwVFpXdS9jWFl3dVhQbnZPOW9PVDl4Y2N4KzByeGIzcnRvRXhl?=
 =?utf-8?B?cEZyYms1bnNuWlJaS0c1cjBTSG1tUkFjV0R5RkZUUllYSUhIdVF3ZkFuOEUr?=
 =?utf-8?B?czF6WFpna1cxVDVrcUM0RzhqNkRyMFIyTnQ2UGNZZS94YU1WSG9UNkF5RUVN?=
 =?utf-8?B?R1FKSVFkdnIzcWQ4RFJpNmNuWXBiNVYrNGczZDBUbXoyQitSR1hqaXV4WkdI?=
 =?utf-8?B?WUR1RFRBb0ZlM3crbHd2dlducUZycWpQRjB1Rm1uZFpuazlGUlBWYlpJVHZm?=
 =?utf-8?B?d3ZIc3BzWmRocDB5K09TRU1vRHlOQWIwYjk0Y1B6Ukp1YkxMci9CN1hYRk41?=
 =?utf-8?B?VG1URk53ZkZqQjMwWFQrMXpNc2FMMUcvNkE3RFcvc0U3clNIejRsdUJKbHYy?=
 =?utf-8?B?TnhhT080UjdneTlvTVlYSUlSNWhBSVY5U3YwOXRpamJWaTF1Rkh0MTRTbExG?=
 =?utf-8?B?MkltUHI4MmdHZ1M5M1dTSFBzN3M3K1pldHVGOTlPM0srQktTOU1TdmlNNnM0?=
 =?utf-8?B?eHRqdnl1emFGNnJ3OXZsb1MyQWhVSUpiZ0ExOUtlSFRoOXN3N0duV1pwbDZo?=
 =?utf-8?B?dnh4Vm1QVFI2akZXOVhOdDlqVm5FTWtkUjhSd20xQVk2V0VQS20vbFZ0dU9u?=
 =?utf-8?B?bG9hT0xPUXFTcU9McEFkem81L08zL0ZZVndpbEdxK056Wnpvc0ZsKy9qR01F?=
 =?utf-8?B?czk0NG44aTdwc1BIYVV0S2VtQi9HeUNhNXdHWVpPNXVCZHlEVkxDbFNFUDQx?=
 =?utf-8?B?aTh0Y2U2MXV4V2lOTnVkTXVSMUtUeXRDVElvZ0tJUEJaZE9HWlRSMmZlT0Nt?=
 =?utf-8?B?RVZzZFNqMXR6MmovaHZWMWJuWW5JblhZcERaSVBaeGNWR3R1MWZpK1FmRFZs?=
 =?utf-8?B?NW1pa1Rwbm0vRzNERGNuMk5od2pxeU8wc2hQc2tKNUQ3QmF2amR3blp4cWRq?=
 =?utf-8?B?SU5iZlpsZzBGVXIwNHNzSDVDQUJEOFNkQ3lvZWEybHBiaFVCWG91TGFnR3B0?=
 =?utf-8?B?Z2JZNVBXUmFtTDRkSWlvUnJpZEJVY2RtSFBjeWtMOGNrVWJPaHYrYzVnZkVG?=
 =?utf-8?B?SzNnLzRrTTN3cCtNeWNUTFB2ZDBUS1hHVFN0bWMzeGJJc1grQ2FmOGJITmVB?=
 =?utf-8?B?dUswYkhFZFc2UmQ3RUswT3gwUTByNFJUYk5adEV0Q01DandBUGhpb1BUdDRt?=
 =?utf-8?Q?BpxL5Gllr4fIqD0pTasqawA=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <F471B5F7FA397C4A8D45D0CA11F8A59D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 737bee50-7ea5-44d1-2b50-08dab6a595b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 16:25:52.2996
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: di7DhiLIK8qlhoTa1RQaXEamFvjaqNdK9OmbPsTiTJsACB7gKggOLAf6K+s1/SKyUzDGQslwUJpCYxQWFQWWS28NBjwmGPMebs1V+7Fto7U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7226
X-Proofpoint-GUID: ljfkOlVs6MFMYRXytu_kZtKBlEsReEEg
X-Proofpoint-ORIG-GUID: ljfkOlVs6MFMYRXytu_kZtKBlEsReEEg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-25_09,2022-10-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0
 priorityscore=1501 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0
 impostorscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210250093

DQpPbiAyMi4xMC4yMiAwOTo0NCwgT2xla3NhbmRyIHdyb3RlOg0KDQpIZWxsbyBTdGVmYW5vLg0K
DQo+DQo+IE9uIDIxLjEwLjIyIDIzOjA4LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+DQo+
IEhlbGxvIFN0ZWZhbm8NCj4NCj4+IE9uIEZyaSwgMjEgT2N0IDIwMjIsIE9sZWtzYW5kciBUeXNo
Y2hlbmtvIHdyb3RlOg0KPj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJf
dHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pg0KPj4+IFVzZSB0aGUgc2FtZSAieGVuLWdyYW50LWRt
YSIgZGV2aWNlIGNvbmNlcHQgZm9yIHRoZSBQQ0kgZGV2aWNlcw0KPj4+IGJlaGluZCBkZXZpY2Ut
dHJlZSBiYXNlZCBQQ0kgSG9zdCBjb250cm9sbGVyLCBidXQgd2l0aCBvbmUgDQo+Pj4gbW9kaWZp
Y2F0aW9uLg0KPj4+IFVubGlrZSBmb3IgcGxhdGZvcm0gZGV2aWNlcywgd2UgY2Fubm90IHVzZSBn
ZW5lcmljIElPTU1VIGJpbmRpbmdzDQo+Pj4gKGlvbW11cyBwcm9wZXJ0eSksIGFzIHdlIG5lZWQg
dG8gc3VwcG9ydCBtb3JlIGZsZXhpYmxlIGNvbmZpZ3VyYXRpb24uDQo+Pj4gVGhlIHByb2JsZW0g
aXMgdGhhdCBQQ0kgZGV2aWNlcyB1bmRlciB0aGUgc2luZ2xlIFBDSSBIb3N0IGNvbnRyb2xsZXIN
Cj4+PiBtYXkgaGF2ZSB0aGUgYmFja2VuZHMgcnVubmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFp
bnMgYW5kIHRodXMgaGF2ZQ0KPj4+IGRpZmZlcmVudCBlbmRwb2ludHMgSUQgKGJhY2tlbmQgZG9t
YWlucyBJRCkuDQo+Pj4NCj4+PiBBZGQgYWJpbGl0eSB0byBkZWFsIHdpdGggZ2VuZXJpYyBQQ0kt
SU9NTVUgYmluZGluZ3MgKGlvbW11LW1hcC8NCj4+PiBpb21tdS1tYXAtbWFzayBwcm9wZXJ0aWVz
KSB3aGljaCBhbGxvd3MgdXMgdG8gZGVzY3JpYmUgcmVsYXRpb25zaGlwDQo+Pj4gYmV0d2VlbiBQ
Q0kgZGV2aWNlcyBhbmQgYmFja2VuZCBkb21haW5zIElEIHByb3Blcmx5Lg0KPj4+DQo+Pj4gVG8g
YXZvaWQgaGF2aW5nIHRvIGxvb2sgdXAgZm9yIHRoZSBQQ0kgSG9zdCBicmlkZ2UgdHdpY2UgYW5k
IHJlZHVjZQ0KPj4+IHRoZSBhbW91bnQgb2YgY2hlY2tzIHBhc3MgYW4gZXh0cmEgc3RydWN0IGRl
dmljZV9ub2RlICpucCB0byBib3RoDQo+Pj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21p
ZCgpIGFuZCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZSgpLg0KPj4+IFdoaWxlIGF0IGl0IGFs
c28gcGFzcyBkb21pZF90ICpiYWNrZW5kX2RvbWlkIGluc3RlYWQgb2YNCj4+PiBzdHJ1Y3QgeGVu
X2dyYW50X2RtYV9kYXRhICpkYXRhIHRvIHRoZSBmb3JtZXIuDQo+Pj4NCj4+PiBTbyB3aXRoIGN1
cnJlbnQgcGF0Y2ggdGhlIGNvZGUgZXhwZWN0cyBpb21tdXMgcHJvcGVydHkgZm9yIHRoZSBwbGF0
Zm9ybQ0KPj4+IGRldmljZXMgYW5kIGlvbW11LW1hcC9pb21tdS1tYXAtbWFzayBwcm9wZXJ0aWVz
IGZvciBQQ0kgZGV2aWNlcy4NCj4+Pg0KPj4+IFRoZSBleGFtcGxlIG9mIGdlbmVyYXRlZCBieSB0
aGUgdG9vbHN0YWNrIGlvbW11LW1hcCBwcm9wZXJ0eQ0KPj4+IGZvciB0d28gUENJIGRldmljZXMg
MDAwMDowMDowMS4wIGFuZCAwMDAwOjAwOjAyLjAgd2hvc2UNCj4+PiBiYWNrZW5kcyBhcmUgcnVu
bmluZyBpbiBkaWZmZXJlbnQgWGVuIGRvbWFpbnMgd2l0aCBJRHMgMSBhbmQgMg0KPj4+IHJlc3Bl
Y3RpdmVseToNCj4+PiBpb21tdS1tYXAgPSA8MHgwOCAweGZkZTkgMHgwMSAweDA4IDB4MTAgMHhm
ZGU5IDB4MDIgMHgwOD47DQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNo
ZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pj4gLS0tDQo+Pj4gU2xpZ2h0
bHkgUkZDLiBUaGlzIGlzIG5lZWRlZCB0byBzdXBwb3J0IFhlbiBncmFudCBtYXBwaW5ncyBmb3Ig
DQo+Pj4gdmlydGlvLXBjaSBkZXZpY2VzDQo+Pj4gb24gQXJtIGF0IHNvbWUgcG9pbnQgaW4gdGhl
IGZ1dHVyZS4gVGhlIFhlbiB0b29sc3RhY2sgc2lkZSBpcyBub3QgDQo+Pj4gY29tcGxldGVseSBy
ZWFkeSB5ZXQuDQo+Pj4gSGVyZSwgZm9yIFBDSSBkZXZpY2VzIHdlIHVzZSBtb3JlIGZsZXhpYmxl
IHdheSB0byBwYXNzIGJhY2tlbmQgZG9taWQgDQo+Pj4gdG8gdGhlIGd1ZXN0DQo+Pj4gdGhhbiBm
b3IgcGxhdGZvcm0gZGV2aWNlcy4NCj4+Pg0KPj4+IENoYW5nZXMgVjEgLT4gVjI6DQo+Pj4gwqDC
oMKgIC0gdXBkYXRlIGNvbW1pdCBkZXNjcmlwdGlvbg0KPj4+IMKgwqDCoCAtIHJlYmFzZQ0KPj4+
IMKgwqDCoCAtIHJld29yayB0byB1c2UgZ2VuZXJpYyBQQ0ktSU9NTVUgYmluZGluZ3MgaW5zdGVh
ZCBvZiBnZW5lcmljIA0KPj4+IElPTU1VIGJpbmRpbmdzDQo+Pj4NCj4+PiBDaGFuZ2VzIFYyIC0+
IFYzOg0KPj4+IMKgwqDCoCAtIHVwZGF0ZSBjb21taXQgZGVzY3JpcHRpb24sIGFkZCBhbiBleGFt
cGxlDQo+Pj4gwqDCoMKgIC0gZHJvcCB4ZW5fZHRfbWFwX2lkKCkgYW5kIHNxdWFzaCB4ZW5fZHRf
Z2V0X3BjaV9ob3N0X25vZGUoKSB3aXRoDQo+Pj4gwqDCoMKgwqDCoCB4ZW5fZHRfZ2V0X25vZGUo
KQ0KPj4+IMKgwqDCoCAtIHBhc3Mgc3RydWN0IGRldmljZV9ub2RlICpucCB0byB4ZW5faXNfZHRf
Z3JhbnRfZG1hX2RldmljZSgpIGFuZA0KPj4+IMKgwqDCoMKgwqAgeGVuX2R0X2dyYW50X2luaXRf
YmFja2VuZF9kb21pZCgpDQo+Pj4gwqDCoMKgIC0gcGFzcyBkb21pZF90ICpiYWNrZW5kX2RvbWlk
IGluc3RlYWQgb2Ygc3RydWN0IA0KPj4+IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YQ0KPj4+IMKg
wqDCoMKgwqAgdG8geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCgpDQo+Pj4NCj4+PiBQ
cmV2aW91cyBkaXNjdXNzaW9uIGlzIGF0Og0KPj4+IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMv
X19odHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjEwMDYxNzQ4MDQuMjAwMzAy
OS0xLW9sZWtzdHlzaEBnbWFpbC5jb20vX187ISFHRl8yOWRiY1FJVUJQQSEzY1ppUnkwU2NxOC1k
aWJyeHlGR1VsQUlod2E3VXdSbXJDQUctcWR2a0FHNU5JbllQWl9tYkxUTXRzWl9GNEdvbm93a2V0
dHItZGNSTzNUQXNfZ24tMXhjTGs3N3hnJCANCj4+PiBbbG9yZVsuXWtlcm5lbFsuXW9yZ10NCj4+
PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVu
LWRldmVsLzIwMjIxMDE1MTUzNDA5LjkxODc3NS0xLW9sZWtzdHlzaEBnbWFpbC5jb20vX187ISFH
Rl8yOWRiY1FJVUJQQSEzY1ppUnkwU2NxOC1kaWJyeHlGR1VsQUlod2E3VXdSbXJDQUctcWR2a0FH
NU5JbllQWl9tYkxUTXRzWl9GNEdvbm93a2V0dHItZGNSTzNUQXNfZ24tMXh3UmpYOUdRJCANCj4+
PiBbbG9yZVsuXWtlcm5lbFsuXW9yZ10NCj4+Pg0KPj4+IEJhc2VkIG9uOg0KPj4+IGh0dHBzOi8v
dXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgv
a2VybmVsL2dpdC94ZW4vdGlwLmdpdC9sb2cvP2g9Zm9yLWxpbnVzLTYuMV9fOyEhR0ZfMjlkYmNR
SVVCUEEhM2NaaVJ5MFNjcTgtZGlicnh5RkdVbEFJaHdhN1V3Um1yQ0FHLXFkdmtBRzVOSW5ZUFpf
bWJMVE10c1pfRjRHb25vd2tldHRyLWRjUk8zVEFzX2duLTF6Vk95OFdLZyQgDQo+Pj4gW2dpdFsu
XWtlcm5lbFsuXW9yZ10NCj4+PiAtLS0NCj4+PiDCoCBkcml2ZXJzL3hlbi9ncmFudC1kbWEtb3Bz
LmMgfCA4MCANCj4+PiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tDQo+Pj4g
wqAgMSBmaWxlIGNoYW5nZWQsIDY2IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KPj4+
DQo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYyBiL2RyaXZlcnMv
eGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+IGluZGV4IGRhYTUyNWRmN2JkYy4uNzZiMjlkMjBhZWVl
IDEwMDY0NA0KPj4+IC0tLSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+ICsrKyBi
L2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4+IEBAIC0xMCw2ICsxMCw3IEBADQo+Pj4g
wqAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPg0KPj4+IMKgICNpbmNsdWRlIDxsaW51eC9kbWEt
bWFwLW9wcy5oPg0KPj4+IMKgICNpbmNsdWRlIDxsaW51eC9vZi5oPg0KPj4+ICsjaW5jbHVkZSA8
bGludXgvcGNpLmg+DQo+Pj4gwqAgI2luY2x1ZGUgPGxpbnV4L3Bmbi5oPg0KPj4+IMKgICNpbmNs
dWRlIDxsaW51eC94YXJyYXkuaD4NCj4+PiDCoCAjaW5jbHVkZSA8bGludXgvdmlydGlvX2FuY2hv
ci5oPg0KPj4+IEBAIC0yOTIsMTIgKzI5MywzNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRtYV9t
YXBfb3BzIA0KPj4+IHhlbl9ncmFudF9kbWFfb3BzID0gew0KPj4+IMKgwqDCoMKgwqAgLmRtYV9z
dXBwb3J0ZWQgPSB4ZW5fZ3JhbnRfZG1hX3N1cHBvcnRlZCwNCj4+PiDCoCB9Ow0KPj4+IMKgIC1z
dGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpkZXYp
DQo+Pj4gK3N0YXRpYyBzdHJ1Y3QgZGV2aWNlX25vZGUgKnhlbl9kdF9nZXRfbm9kZShzdHJ1Y3Qg
ZGV2aWNlICpkZXYpDQo+Pj4gwqAgew0KPj4+IC3CoMKgwqAgc3RydWN0IGRldmljZV9ub2RlICpp
b21tdV9ucDsNCj4+PiArwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+PiArwqDCoMKg
wqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQo+Pj4gK8Kg
wqDCoMKgwqDCoMKgIHN0cnVjdCBwY2lfYnVzICpidXMgPSBwZGV2LT5idXM7DQo+Pj4gKw0KPj4+
ICvCoMKgwqDCoMKgwqDCoCAvKiBXYWxrIHVwIHRvIHRoZSByb290IGJ1cyB0byBsb29rIGZvciBQ
Q0kgSG9zdCBjb250cm9sbGVyICovDQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHdoaWxlICghcGNpX2lz
X3Jvb3RfYnVzKGJ1cykpDQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYnVzID0gYnVzLT5w
YXJlbnQ7DQo+Pj4gKw0KPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gb2Zfbm9kZV9nZXQoYnVz
LT5icmlkZ2UtPnBhcmVudC0+b2Zfbm9kZSk7DQo+Pj4gK8KgwqDCoCB9DQo+Pj4gKw0KPj4+ICvC
oMKgwqAgcmV0dXJuIG9mX25vZGVfZ2V0KGRldi0+b2Zfbm9kZSk7DQo+Pj4gK30NCj4+PiArDQo+
Pj4gK3N0YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZpY2Ug
KmRldiwNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0
IGRldmljZV9ub2RlICpucCkNCj4+PiArew0KPj4+ICvCoMKgwqAgc3RydWN0IGRldmljZV9ub2Rl
ICppb21tdV9ucCA9IE5VTEw7DQo+Pj4gwqDCoMKgwqDCoCBib29sIGhhc19pb21tdTsNCj4+PiDC
oCAtwqDCoMKgIGlvbW11X25wID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYtPm9mX25vZGUsICJpb21t
dXMiLCAwKTsNCj4+PiArwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikpIHsNCj4+PiArwqDCoMKg
wqDCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSB0b19wY2lfZGV2KGRldik7DQo+Pj4gK8Kg
wqDCoMKgwqDCoMKgIHUzMiByaWQgPSBQQ0lfREVWSUQocGRldi0+YnVzLT5udW1iZXIsIHBkZXYt
PmRldmZuKTsNCj4+PiArDQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChvZl9tYXBfaWQobnAsIHJp
ZCwgImlvbW11LW1hcCIsICJpb21tdS1tYXAtbWFzayIsIA0KPj4+ICZpb21tdV9ucCwgTlVMTCkp
DQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGZhbHNlOw0KPj4+ICvCoMKgwqAg
fSBlbHNlDQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlvbW11X25wID0gb2ZfcGFyc2VfcGhhbmRsZShu
cCwgImlvbW11cyIsIDApOw0KPj4+ICsNCj4+PiDCoMKgwqDCoMKgIGhhc19pb21tdSA9IGlvbW11
X25wICYmDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBh
dGlibGUoaW9tbXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQo+Pj4gwqDCoMKgwqDCoCBvZl9ub2Rl
X3B1dChpb21tdV9ucCk7DQo+PiBJIHRoaW5rIHdlIGNhbiByZW1vdmUgeGVuX2lzX2R0X2dyYW50
X2RtYV9kZXZpY2UgYW5kIGp1c3QgY2FsbA0KPj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9k
b21pZCBwYXNzaW5nIGEgTlVMTCBiYWNrZW5kX2RvbWlkPw0KPj4NCj4+IEl0IGlzIGEgYml0IGFu
bm95aW5nIHRoYXQgd2UgYXJlIGJhc2ljYWxseSBkb2luZyB0aGUgc2FtZSBkZXZpY2UgdHJlZQ0K
Pj4gcGFyc2luZyB0d2ljZSBpbiBhIHJvdyBnaXZlbiB0aGF0IHRoZSBjYWxsZXJzIGRvOg0KPj4N
Cj4+IMKgwqDCoMKgaWYgKHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKGRldikpDQo+PiDCoMKgwqDC
oMKgwqDCoCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhkZXYpOw0KPj4NCj4+IE1heWJlIHdlIGNv
dWxkIG1vdmUgdGhlIGJhY2tlbmRfZG9taWQgYWxsb2NhdGlvbiBhbmQgc2V0dGluZyB0bw0KPj4g
eGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZCwgd2hpY2ggd291bGQgZW5kIHVwIGJlaW5n
IGRvbmUgZnJvbQ0KPj4gdGhlIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKCkgY2FsbCBjaGFpbiwg
YW5kIG9ubHkgbGVhdmUgc2V0dGluZw0KPj4gZGV2LT5kbWFfb3BzIGZyb20geGVuX2dyYW50X3Nl
dHVwX2RtYV9vcHMoKS4NCj4+DQo+PiBUaGlzIHdheSB0aGUgcGFyc2luZyB3b3VsZCBiZSBkb25l
IG9ubHkgb25jZT8gV2hhdCBkbyB5b3UgdGhpbms/IFRoaXMNCj4+IHN1Z2dlc3Rpb24gaXMgb3B0
aW9uYWwsIEkgYW0gT0sgYWxzbyB3aXRoIG9ubHkgcmVtb3ZpbmcNCj4+IHhlbl9pc19kdF9ncmFu
dF9kbWFfZGV2aWNlLg0KPg0KPiBvaywgSSB3aWxsIHRoaW5rIGFib3V0IHN1Y2ggb3B0aW1pemF0
aW9uIGFuZCB3aWxsIHByb3ZpZGUgbXkgdGhvdWdodHMgDQo+IGFib3V0IGl0IG9yIGEgcGF0Y2gu
IA0KDQpJIGhhdmUgdGhvdWdodCBhYm91dCBpdC4gWW91IHdhcyByaWdodCwgaXQgaXMgcG9zc2li
bGUgdG8gb3B0aW1pemUgDQp0aGluZ3MuIFBsZWFzZSB0YWtlIGEgbG9vayBhdDoNCg0KaHR0cHM6
Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjIxMDI1MTYyMDA0Ljg1MDEtMS1vbGVrc3R5
c2hAZ21haWwuY29tLw0KDQoNCg0KDQoNCj4gQnV0LCBJIHRoaW5rIGl0IHNob3VsZCBiZSBhIHNl
cGFyYXRlIHBhdGNoIChpZiBuZWVkcyBiZSksDQo+DQo+IGFzIGluIGN1cnJlbnQgcGF0Y2ggd2Ug
ZG9uJ3QgY2hhbmdlIGFueXRoaW5nIGluIHRoYXQgcmVnYXJkLCB3ZSBqdXN0IA0KPiBpbXBsZW1l
bnQNCj4NCj4gImlmIChkZXZfaXNfcGNpKGRldikpIHsgLi4uIH0iIGNvbmRpdGlvbiBmb3IgDQo+
IHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKCkgYW5kIHhlbl9kdF9ncmFudF9pbml0X2JhY2tl
bmRfZG9taWQoKS4NCj4NCj4NCj4NCj4+DQo+Pg0KPj4+IEBAIC0zMDcsOSArMzMzLDE3IEBAIHN0
YXRpYyBib29sIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCANCj4+PiBkZXZpY2Ug
KmRldikNCj4+PiDCoCDCoCBib29sIHhlbl9pc19ncmFudF9kbWFfZGV2aWNlKHN0cnVjdCBkZXZp
Y2UgKmRldikNCj4+PiDCoCB7DQo+Pj4gK8KgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wOw0K
Pj4+ICsNCj4+PiDCoMKgwqDCoMKgIC8qIFhYWCBIYW5kbGUgb25seSBEVCBkZXZpY2VzIGZvciBu
b3cgKi8NCj4+PiAtwqDCoMKgIGlmIChkZXYtPm9mX25vZGUpDQo+Pj4gLcKgwqDCoMKgwqDCoMKg
IHJldHVybiB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShkZXYpOw0KPj4+ICvCoMKgwqAgbnAg
PSB4ZW5fZHRfZ2V0X25vZGUoZGV2KTsNCj4+PiArwqDCoMKgIGlmIChucCkgew0KPj4+ICvCoMKg
wqDCoMKgwqDCoCBib29sIHJldDsNCj4+PiArDQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldCA9IHhl
bl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldiwgbnApOw0KPj4+ICvCoMKgwqDCoMKgwqDCoCBv
Zl9ub2RlX3B1dChucCk7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7DQo+Pj4gK8Kg
wqDCoCB9DQo+Pj4gwqAgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+Pj4gwqAgfQ0KPj4+IEBA
IC0zMjMsMTQgKzM1NywyNiBAQCBib29sIHhlbl92aXJ0aW9fbWVtX2FjYyhzdHJ1Y3QgdmlydGlv
X2RldmljZSANCj4+PiAqZGV2KQ0KPj4+IMKgIH0NCj4+PiDCoCDCoCBzdGF0aWMgaW50IHhlbl9k
dF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoc3RydWN0IGRldmljZSAqZGV2LA0KPj4+IC3CoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50
X2RtYV9kYXRhICpkYXRhKQ0KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLA0KPj4+ICvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkb21pZF90ICpiYWNrZW5kX2RvbWlkKQ0KPj4+
IMKgIHsNCj4+PiAtwqDCoMKgIHN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYzsNCj4+
PiArwqDCoMKgIHN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgaW9tbXVfc3BlYyA9IHsgLmFyZ3NfY291
bnQgPSAxIH07DQo+Pj4gwqAgLcKgwqDCoCBpZiAob2ZfcGFyc2VfcGhhbmRsZV93aXRoX2FyZ3Mo
ZGV2LT5vZl9ub2RlLCAiaW9tbXVzIiwgDQo+Pj4gIiNpb21tdS1jZWxscyIsDQo+Pj4gLcKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+Pj4gLcKgwqDCoMKgwqDCoMKg
IGRldl9lcnIoZGV2LCAiQ2Fubm90IHBhcnNlIGlvbW11cyBwcm9wZXJ0eVxuIik7DQo+Pj4gLcKg
wqDCoMKgwqDCoMKgIHJldHVybiAtRVNSQ0g7DQo+Pj4gK8KgwqDCoCBpZiAoZGV2X2lzX3BjaShk
ZXYpKSB7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNp
X2RldihkZXYpOw0KPj4+ICvCoMKgwqDCoMKgwqDCoCB1MzIgcmlkID0gUENJX0RFVklEKHBkZXYt
PmJ1cy0+bnVtYmVyLCBwZGV2LT5kZXZmbik7DQo+Pj4gKw0KPj4+ICvCoMKgwqDCoMKgwqDCoCBp
ZiAob2ZfbWFwX2lkKG5wLCByaWQsICJpb21tdS1tYXAiLCAiaW9tbXUtbWFwLW1hc2siLCANCj4+
PiAmaW9tbXVfc3BlYy5ucCwNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlv
bW11X3NwZWMuYXJncykpIHsNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkZXZfZXJyKGRl
diwgIkNhbm5vdCB0cmFuc2xhdGUgSURcbiIpOw0KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHJldHVybiAtRVNSQ0g7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIH0NCj4+PiArwqDCoMKgIH0gZWxz
ZSB7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhu
cCwgImlvbW11cyIsICIjaW9tbXUtY2VsbHMiLA0KPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
ZGV2X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+PiArwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVTUkNIOw0KPj4+ICvCoMKgwqDCoMKgwqDCoCB9
DQo+Pj4gwqDCoMKgwqDCoCB9DQo+Pj4gwqAgwqDCoMKgwqDCoCBpZiAoIW9mX2RldmljZV9pc19j
b21wYXRpYmxlKGlvbW11X3NwZWMubnAsICJ4ZW4sZ3JhbnQtZG1hIikgfHwNCj4+PiBAQCAtMzQ2
LDcgKzM5Miw3IEBAIHN0YXRpYyBpbnQgDQo+Pj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9k
b21pZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+Pj4gwqDCoMKgwqDCoMKgICogVGhlIGVuZHBvaW50
IElEIGhlcmUgbWVhbnMgdGhlIElEIG9mIHRoZSBkb21haW4gd2hlcmUgdGhlDQo+Pj4gwqDCoMKg
wqDCoMKgICogY29ycmVzcG9uZGluZyBiYWNrZW5kIGlzIHJ1bm5pbmcNCj4+PiDCoMKgwqDCoMKg
wqAgKi8NCj4+PiAtwqDCoMKgIGRhdGEtPmJhY2tlbmRfZG9taWQgPSBpb21tdV9zcGVjLmFyZ3Nb
MF07DQo+Pj4gK8KgwqDCoCAqYmFja2VuZF9kb21pZCA9IGlvbW11X3NwZWMuYXJnc1swXTsNCj4+
PiDCoCDCoMKgwqDCoMKgIHJldHVybiAwOw0KPj4+IMKgIH0NCj4+PiBAQCAtMzU0LDYgKzQwMCw3
IEBAIHN0YXRpYyBpbnQgDQo+Pj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1
Y3QgZGV2aWNlICpkZXYsDQo+Pj4gwqAgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1
Y3QgZGV2aWNlICpkZXYpDQo+Pj4gwqAgew0KPj4+IMKgwqDCoMKgwqAgc3RydWN0IHhlbl9ncmFu
dF9kbWFfZGF0YSAqZGF0YTsNCj4+PiArwqDCoMKgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnA7DQo+
Pj4gwqAgwqDCoMKgwqDCoCBkYXRhID0gZmluZF94ZW5fZ3JhbnRfZG1hX2RhdGEoZGV2KTsNCj4+
PiDCoMKgwqDCoMKgIGlmIChkYXRhKSB7DQo+Pj4gQEAgLTM2NSw4ICs0MTIsMTMgQEAgdm9pZCB4
ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+Pj4gwqDCoMKgwqDC
oCBpZiAoIWRhdGEpDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZXJyOw0KPj4+IMKgIC3C
oMKgwqAgaWYgKGRldi0+b2Zfbm9kZSkgew0KPj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAoeGVuX2R0
X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYsIGRhdGEpKQ0KPj4+ICvCoMKgwqAgbnAgPSB4
ZW5fZHRfZ2V0X25vZGUoZGV2KTsNCj4+PiArwqDCoMKgIGlmIChucCkgew0KPj4+ICvCoMKgwqDC
oMKgwqDCoCBpbnQgcmV0Ow0KPj4+ICsNCj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0geGVuX2R0
X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYsIG5wLCANCj4+PiAmZGF0YS0+YmFja2VuZF9k
b21pZCk7DQo+Pj4gK8KgwqDCoMKgwqDCoMKgIG9mX25vZGVfcHV0KG5wKTsNCj4+PiArwqDCoMKg
wqDCoMKgwqAgaWYgKHJldCkNCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVy
cjsNCj4+PiDCoMKgwqDCoMKgIH0gZWxzZSBpZiAoSVNfRU5BQkxFRChDT05GSUdfWEVOX1ZJUlRJ
T19GT1JDRV9HUkFOVCkpIHsNCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2X2luZm8oZGV2LCAi
VXNpbmcgZG9tMCBhcyBiYWNrZW5kXG4iKTsNCj4+PiAtLSANCj4+PiAyLjI1LjENCj4+Pg0KLS0g
DQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 17:27:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 17:27:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430011.681439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNhy-0002Iy-7T; Tue, 25 Oct 2022 17:27:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430011.681439; Tue, 25 Oct 2022 17:27:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNhy-0002Ir-4l; Tue, 25 Oct 2022 17:27:22 +0000
Received: by outflank-mailman (input) for mailman id 430011;
 Tue, 25 Oct 2022 17:27:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tfwf=22=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1onNhw-0002If-KG
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 17:27:20 +0000
Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com
 [2a00:1450:4864:20::534])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4737052f-548a-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 19:27:19 +0200 (CEST)
Received: by mail-ed1-x534.google.com with SMTP id a13so37459935edj.0
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 10:27:19 -0700 (PDT)
Received: from [192.168.1.93] (adsl-115.176.58.194.tellas.gr. [176.58.194.115])
 by smtp.gmail.com with ESMTPSA id
 t1-20020a50d701000000b0045bd14e241csm2058971edi.76.2022.10.25.10.27.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 25 Oct 2022 10:27:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4737052f-548a-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=EaSiIImo3JpIdKX1XllTmgX6wW97dTj/LLBn4tq/kbE=;
        b=k6GEFgmko2iv7eIA3sKE4/a2Tv+/HYyzI06MSyqdGelsHvMn7JCWBEl9t2EucOy2ju
         78JD8tdGbJCZhVO8srnL9fJw+lXJn9FWLHXXOInNEMb+30lCy8l7v1SwipffeEpfdvtJ
         LtKSHmkgdtipEHbYpNOBxLNbE4BTYpTN/P9iWkc65tIBfoDnZCZoZ/Yld7MrSdAE61zY
         2RElIXpJ2BXrnHaIcgazUiIuknWVZMSCmFPNQUKjhu2+N1BYQoRn3ewqBxaLb7d/U0Ol
         Ig4NjIsghQKJHdqYveXIz0T6Iy2QTlr+IjX35SDX0nvI3Scmeao+rN785Q4YwXTAEE4w
         b7tg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=EaSiIImo3JpIdKX1XllTmgX6wW97dTj/LLBn4tq/kbE=;
        b=MedIJfCXh9YAR+wPS8Ty1rFAyxA/Md4RkCjCp3EguLeFVIWtsUP/gFeUnFyvNvCgIH
         jVz+rK9W6VGB59+5xDuYGAm72/T0y/O3/BzANxCIefCQ1Vkp8abLFEjNorOEvhKUzEzD
         jrFUbLDlpKCzN2iONzFYbQO4+N8DRGTwoeuMAAeyqKyuWJ0VeEPw95Kfe5IjYs3LBSlP
         4UURgcZ9/Haw4VkaeYmjiLeBWjMKA0E7/eJErLKWE5wlnDOmKAIy+T3trs5CFwmKj8Qu
         3K47gp6msgskuoEse+44DbyR+2tyvUfmZjLc0Bqo1TpNk78AOY5patLwMGGqcL/Z1/3Y
         DoJw==
X-Gm-Message-State: ACrzQf3Rlbzznf7M1i3PDxviPmZB2OLXIC+lyP+jKZ5Jj/6IldvngqtZ
	ZClefB6Nt9c2Lq2KkL8Gqa8=
X-Google-Smtp-Source: AMsMyM5NTzt87MA/WplphX8cnMJ3lFLsiEj/M/U0zqtRaiH2Zf66ybz5rXmhJctErsdAPexGBskGNQ==
X-Received: by 2002:a05:6402:11c7:b0:462:549d:fbbe with SMTP id j7-20020a05640211c700b00462549dfbbemr123777edw.199.1666718839085;
        Tue, 25 Oct 2022 10:27:19 -0700 (PDT)
Message-ID: <6cab9931-8f72-9b90-bf58-f12108f84c58@gmail.com>
Date: Tue, 25 Oct 2022 20:27:16 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V4 1/2] xen/virtio: Optimize the setup of "xen-grant-dma"
 devices
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Russell King <linux@armlinux.org.uk>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221025162004.8501-1-olekstysh@gmail.com>
 <20221025162004.8501-2-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221025162004.8501-2-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/25/22 19:20, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This is needed to avoid having to parse the same device-tree
> several times for a given device.
> 
> For this to work we need to install the xen_virtio_restricted_mem_acc
> callback in Arm's xen_guest_init() which is same callback as x86's
> PV and HVM modes already use and remove the manual assignment in
> xen_setup_dma_ops(). Also we need to split the code to initialize
> backend_domid into a separate function.
> 
> Prior to current patch we parsed the device-tree three times:
> 1. xen_setup_dma_ops()->...->xen_is_dt_grant_dma_device()
> 2. xen_setup_dma_ops()->...->xen_dt_grant_init_backend_domid()
> 3. xen_virtio_mem_acc()->...->xen_is_dt_grant_dma_device()
> 
> With current patch we parse the device-tree only once in
> xen_virtio_restricted_mem_acc()->...->xen_dt_grant_init_backend_domid()
> 
> Other benefits are:
> - Not diverge from x86 when setting up Xen grant DMA ops
> - Drop several global functions
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Xenia Ragiadakou <burzalodowa@gmail.com>

I have a question unrelated to the patch.
CONFIG_XEN_VIRTIO_FORCE_GRANT cannot be used to force backend dom0 in 
case xen_dt_grant_init_backend_domid() fails?

> ---
> New patch
> ---
>   arch/arm/xen/enlighten.c    |  2 +-
>   drivers/xen/grant-dma-ops.c | 77 ++++++++++++++-----------------------
>   include/xen/arm/xen-ops.h   |  4 +-
>   include/xen/xen-ops.h       | 16 --------
>   4 files changed, 30 insertions(+), 69 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 93c8ccbf2982..7d59765aef22 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -445,7 +445,7 @@ static int __init xen_guest_init(void)
>   		return 0;
>   
>   	if (IS_ENABLED(CONFIG_XEN_VIRTIO))
> -		virtio_set_mem_acc_cb(xen_virtio_mem_acc);
> +		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
>   
>   	if (!acpi_disabled)
>   		xen_acpi_guest_init();
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index daa525df7bdc..1e797a043980 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -292,50 +292,20 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>   	.dma_supported = xen_grant_dma_supported,
>   };
>   
> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> -{
> -	struct device_node *iommu_np;
> -	bool has_iommu;
> -
> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> -	has_iommu = iommu_np &&
> -		    of_device_is_compatible(iommu_np, "xen,grant-dma");
> -	of_node_put(iommu_np);
> -
> -	return has_iommu;
> -}
> -
> -bool xen_is_grant_dma_device(struct device *dev)
> -{
> -	/* XXX Handle only DT devices for now */
> -	if (dev->of_node)
> -		return xen_is_dt_grant_dma_device(dev);
> -
> -	return false;
> -}
> -
> -bool xen_virtio_mem_acc(struct virtio_device *dev)
> -{
> -	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain())
> -		return true;
> -
> -	return xen_is_grant_dma_device(dev->dev.parent);
> -}
> -
>   static int xen_dt_grant_init_backend_domid(struct device *dev,
> -					   struct xen_grant_dma_data *data)
> +					   domid_t *backend_domid)
>   {
>   	struct of_phandle_args iommu_spec;
>   
>   	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
>   			0, &iommu_spec)) {
> -		dev_err(dev, "Cannot parse iommus property\n");
> +		dev_dbg(dev, "Cannot parse iommus property\n");
>   		return -ESRCH;
>   	}
>   
>   	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
>   			iommu_spec.args_count != 1) {
> -		dev_err(dev, "Incompatible IOMMU node\n");
> +		dev_dbg(dev, "Incompatible IOMMU node\n");
>   		of_node_put(iommu_spec.np);
>   		return -ESRCH;
>   	}
> @@ -346,12 +316,28 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>   	 * The endpoint ID here means the ID of the domain where the
>   	 * corresponding backend is running
>   	 */
> -	data->backend_domid = iommu_spec.args[0];
> +	*backend_domid = iommu_spec.args[0];
>   
>   	return 0;
>   }
>   
> -void xen_grant_setup_dma_ops(struct device *dev)
> +static int xen_grant_init_backend_domid(struct device *dev,
> +					domid_t *backend_domid)
> +{
> +	int ret = -ENODEV;
> +
> +	if (dev->of_node) {
> +		ret = xen_dt_grant_init_backend_domid(dev, backend_domid);
> +	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain()) {
> +		dev_info(dev, "Using dom0 as backend\n");
> +		*backend_domid = 0;
> +		ret = 0;
> +	}
> +
> +	return ret;
> +}
> +
> +static void xen_grant_setup_dma_ops(struct device *dev, domid_t backend_domid)
>   {
>   	struct xen_grant_dma_data *data;
>   
> @@ -365,16 +351,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
>   	if (!data)
>   		goto err;
>   
> -	if (dev->of_node) {
> -		if (xen_dt_grant_init_backend_domid(dev, data))
> -			goto err;
> -	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
> -		dev_info(dev, "Using dom0 as backend\n");
> -		data->backend_domid = 0;
> -	} else {
> -		/* XXX ACPI device unsupported for now */
> -		goto err;
> -	}
> +	data->backend_domid = backend_domid;
>   
>   	if (store_xen_grant_dma_data(dev, data)) {
>   		dev_err(dev, "Cannot store Xen grant DMA data\n");
> @@ -392,12 +369,14 @@ void xen_grant_setup_dma_ops(struct device *dev)
>   
>   bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
>   {
> -	bool ret = xen_virtio_mem_acc(dev);
> +	domid_t backend_domid;
>   
> -	if (ret)
> -		xen_grant_setup_dma_ops(dev->dev.parent);
> +	if (!xen_grant_init_backend_domid(dev->dev.parent, &backend_domid)) {
> +		xen_grant_setup_dma_ops(dev->dev.parent, backend_domid);
> +		return true;
> +	}
>   
> -	return ret;
> +	return false;
>   }
>   
>   MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
> index b0766a660338..70073f5a2b54 100644
> --- a/include/xen/arm/xen-ops.h
> +++ b/include/xen/arm/xen-ops.h
> @@ -8,9 +8,7 @@
>   static inline void xen_setup_dma_ops(struct device *dev)
>   {
>   #ifdef CONFIG_XEN
> -	if (xen_is_grant_dma_device(dev))
> -		xen_grant_setup_dma_ops(dev);
> -	else if (xen_swiotlb_detect())
> +	if (xen_swiotlb_detect())
>   		dev->dma_ops = &xen_swiotlb_dma_ops;
>   #endif
>   }
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a34f4271a2e9..47f11bec5e90 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -216,26 +216,10 @@ static inline void xen_preemptible_hcall_end(void) { }
>   #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>   
>   #ifdef CONFIG_XEN_GRANT_DMA_OPS
> -void xen_grant_setup_dma_ops(struct device *dev);
> -bool xen_is_grant_dma_device(struct device *dev);
> -bool xen_virtio_mem_acc(struct virtio_device *dev);
>   bool xen_virtio_restricted_mem_acc(struct virtio_device *dev);
>   #else
> -static inline void xen_grant_setup_dma_ops(struct device *dev)
> -{
> -}
> -static inline bool xen_is_grant_dma_device(struct device *dev)
> -{
> -	return false;
> -}
> -
>   struct virtio_device;
>   
> -static inline bool xen_virtio_mem_acc(struct virtio_device *dev)
> -{
> -	return false;
> -}
> -
>   static inline bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
>   {
>   	return false;

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 17:27:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 17:27:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430012.681450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNi6-0002Zu-Jx; Tue, 25 Oct 2022 17:27:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430012.681450; Tue, 25 Oct 2022 17:27:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNi6-0002Zn-GW; Tue, 25 Oct 2022 17:27:30 +0000
Received: by outflank-mailman (input) for mailman id 430012;
 Tue, 25 Oct 2022 17:27:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onNi5-0002ZM-C3; Tue, 25 Oct 2022 17:27:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onNi5-0008Kw-7f; Tue, 25 Oct 2022 17:27:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onNi4-00057Q-SI; Tue, 25 Oct 2022 17:27:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onNi4-0008Dh-Rq; Tue, 25 Oct 2022 17:27:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fVHP/77tYw4ydisfOCNwc3vifN3CoJKc3L41nJjHWLo=; b=J32C46YwjA2nPrHAOC0KbEUlfz
	Pnta54B8jbCIoSK7MxXKQ7e1UbHr6AHohopFQMa4GRTm0kIPeGjoqGQCeoTecYfzDppfLYiMY3Ii5
	NCqP5e0WKCTxGllaO9pWwdztKq6CUrkoPN3v4Kem4J8m46Cg/GLquRmnXRRSsdq3d7dg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174409-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174409: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4ff0811a2b0d1c715f54550f9a3632195bb6b21f
X-Osstest-Versions-That:
    xen=a92dc2bb30ba65ae25d2f417677eb7ef9a6a0fef
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 17:27:28 +0000

flight 174409 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174409/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  4ff0811a2b0d1c715f54550f9a3632195bb6b21f
baseline version:
 xen                  a92dc2bb30ba65ae25d2f417677eb7ef9a6a0fef

Last test of basis   174366  2022-10-24 15:03:34 Z    1 days
Testing same since   174409  2022-10-25 14:00:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   a92dc2bb30..4ff0811a2b  4ff0811a2b0d1c715f54550f9a3632195bb6b21f -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 17:28:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 17:28:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430022.681461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNie-0003FI-T9; Tue, 25 Oct 2022 17:28:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430022.681461; Tue, 25 Oct 2022 17:28:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNie-0003FB-Q1; Tue, 25 Oct 2022 17:28:04 +0000
Received: by outflank-mailman (input) for mailman id 430022;
 Tue, 25 Oct 2022 17:28:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tfwf=22=gmail.com=burzalodowa@srs-se1.protection.inumbo.net>)
 id 1onNid-0002vV-Vz
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 17:28:04 +0000
Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com
 [2a00:1450:4864:20::632])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60de776f-548a-11ed-8fd0-01056ac49cbb;
 Tue, 25 Oct 2022 19:28:02 +0200 (CEST)
Received: by mail-ej1-x632.google.com with SMTP id k2so14484492ejr.2
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 10:28:02 -0700 (PDT)
Received: from [192.168.1.93] (adsl-115.176.58.194.tellas.gr. [176.58.194.115])
 by smtp.gmail.com with ESMTPSA id
 e21-20020a1709062c1500b00781be3e7badsm1710130ejh.53.2022.10.25.10.28.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 25 Oct 2022 10:28:01 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60de776f-548a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=Ziuf2jyNnaY2nR2BxTPSYAC/kOKBbzM+LbjynCTvGnw=;
        b=WOb04wmiMsoRXeMJK7qNQY9vqZjXsmoXyHiXDUYW3i4CzzBvBkbvE6SOO0GICxsLRg
         H+1DZy1EbBh7b1EW0AL/0MOCuQ5mQRwYvwx2SEXjP7fmPsiTMaKMb3dXnfrOXHM8ezU+
         0FAxOlR++eDmkdOwL4XuFu8jTXgZGeIv2BtPfVTF+AgplV39pW06tvI+5AUi+JxofhZD
         LoxaCMRRAxeqpASp5iaMDdSvDktD0AQolXczSZEszz7zibpCzj8HKstEoUBsmF94xFKc
         O3EEVEZNsDBJ5WHNYSYcAXyEIjA4KJgoTW5+fn4g+eHC3HPvXftYBGoYYebBmcI80wRB
         nc8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Ziuf2jyNnaY2nR2BxTPSYAC/kOKBbzM+LbjynCTvGnw=;
        b=QA209M68/HZnjX/z0o52m4Yt6GLlrh0x0na/430G9DU1j9SSKg9yjE6jEej20zOts/
         wbId3DgD53zf+OSum8iOF1w9R8p0YiLZel3F0s18WleyVFKEcFhsEizlcfKO+x7Mknjc
         cq93GU1ogXoruZ2fo/TsPR36G+BsyeVCYdKBNp2FP6zTcA4XfJ9N7M9n3PLwmHZtsHrX
         sx4DiV3Xw+Qd1r5hedJdelVuPnMw/oKpuv+soqRO0rleNRE5xYg+fJZABvNHJKpoCLwN
         RCSjD3ynhnWuV05IhAWiuWA6HvNsBSCSI800KFDoEFCoVuMxt/ooIUi3HcJ+8TJa73iB
         qIUg==
X-Gm-Message-State: ACrzQf3VCg6xs3/kMOMiEZ5P4Hjed9t2aFsKyscyBkGiUolLWWW053Eq
	F4ggdOtUU+qB1hAfE52DelU=
X-Google-Smtp-Source: AMsMyM5Iz0hrSojDyqGBVVNearrPqTp8MX/J5TDLcFFXl1GUjqyS6ripVIfRo+/CIaiC6ASc8/AGbg==
X-Received: by 2002:a17:906:4786:b0:78d:b793:5bf6 with SMTP id cw6-20020a170906478600b0078db7935bf6mr34119042ejc.222.1666718882263;
        Tue, 25 Oct 2022 10:28:02 -0700 (PDT)
Message-ID: <03fdb0f3-614c-5ee7-592e-25facbc2344f@gmail.com>
Date: Tue, 25 Oct 2022 20:28:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V4 2/2] xen/virtio: Handle PCI devices which Host
 controller is described in DT
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Juergen Gross <jgross@suse.com>
References: <20221025162004.8501-1-olekstysh@gmail.com>
 <20221025162004.8501-3-olekstysh@gmail.com>
From: Xenia Ragiadakou <burzalodowa@gmail.com>
In-Reply-To: <20221025162004.8501-3-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/25/22 19:20, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the same "xen-grant-dma" device concept for the PCI devices
> behind device-tree based PCI Host controller, but with one modification.
> Unlike for platform devices, we cannot use generic IOMMU bindings
> (iommus property), as we need to support more flexible configuration.
> The problem is that PCI devices under the single PCI Host controller
> may have the backends running in different Xen domains and thus have
> different endpoints ID (backend domains ID).
> 
> Add ability to deal with generic PCI-IOMMU bindings (iommu-map/
> iommu-map-mask properties) which allows us to describe relationship
> between PCI devices and backend domains ID properly.
> 
> To avoid having to look up for the PCI Host bridge twice and reduce
> the amount of checks pass an extra struct device_node *np to
> xen_dt_grant_init_backend_domid().
> 
> So with current patch the code expects iommus property for the platform
> devices and iommu-map/iommu-map-mask properties for PCI devices.
> 
> The example of generated by the toolstack iommu-map property
> for two PCI devices 0000:00:01.0 and 0000:00:02.0 whose
> backends are running in different Xen domains with IDs 1 and 2
> respectively:
> iommu-map = <0x08 0xfde9 0x01 0x08 0x10 0xfde9 0x02 0x08>;
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Xenia Ragiadakou <burzalodowa@gmail.com>

> ---
> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> than for platform devices.
> 
> Changes V1 -> V2:
>     - update commit description
>     - rebase
>     - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> 
> Changes V2 -> V3:
>     - update commit description, add an example
>     - drop xen_dt_map_id() and squash xen_dt_get_pci_host_node() with
>       xen_dt_get_node()
>     - pass struct device_node *np to xen_is_dt_grant_dma_device() and
>       xen_dt_grant_init_backend_domid()
>     - pass domid_t *backend_domid instead of struct xen_grant_dma_data *data
>       to xen_dt_grant_init_backend_domid()
> 
> Changes V3 -> V4:
>     - just rebase on new prereq patch
>       "xen/virtio: Optimize the setup of "xen-grant-dma" devices"
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/20221015153409.918775-1-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/20221021172408.77397-1-olekstysh@gmail.com/
> 
> Based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
> ---
> ---
>   drivers/xen/grant-dma-ops.c | 46 +++++++++++++++++++++++++++++++------
>   1 file changed, 39 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 1e797a043980..9784a77fa3c9 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>   #include <linux/module.h>
>   #include <linux/dma-map-ops.h>
>   #include <linux/of.h>
> +#include <linux/pci.h>
>   #include <linux/pfn.h>
>   #include <linux/xarray.h>
>   #include <linux/virtio_anchor.h>
> @@ -292,15 +293,43 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>   	.dma_supported = xen_grant_dma_supported,
>   };
>   
> +static struct device_node *xen_dt_get_node(struct device *dev)
> +{
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		struct pci_bus *bus = pdev->bus;
> +
> +		/* Walk up to the root bus to look for PCI Host controller */
> +		while (!pci_is_root_bus(bus))
> +			bus = bus->parent;
> +
> +		return of_node_get(bus->bridge->parent->of_node);
> +	}
> +
> +	return of_node_get(dev->of_node);
> +}
> +
>   static int xen_dt_grant_init_backend_domid(struct device *dev,
> +					   struct device_node *np,
>   					   domid_t *backend_domid)
>   {
> -	struct of_phandle_args iommu_spec;
> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
>   
> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> -			0, &iommu_spec)) {
> -		dev_dbg(dev, "Cannot parse iommus property\n");
> -		return -ESRCH;
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +
> +		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_spec.np,
> +				iommu_spec.args)) {
> +			dev_dbg(dev, "Cannot translate ID\n");
> +			return -ESRCH;
> +		}
> +	} else {
> +		if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
> +				0, &iommu_spec)) {
> +			dev_dbg(dev, "Cannot parse iommus property\n");
> +			return -ESRCH;
> +		}
>   	}
>   
>   	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> @@ -324,10 +353,13 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>   static int xen_grant_init_backend_domid(struct device *dev,
>   					domid_t *backend_domid)
>   {
> +	struct device_node *np;
>   	int ret = -ENODEV;
>   
> -	if (dev->of_node) {
> -		ret = xen_dt_grant_init_backend_domid(dev, backend_domid);
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		ret = xen_dt_grant_init_backend_domid(dev, np, backend_domid);
> +		of_node_put(np);
>   	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain()) {
>   		dev_info(dev, "Using dom0 as backend\n");
>   		*backend_domid = 0;

-- 
Xenia


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 17:38:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 17:38:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430027.681471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNsZ-00058u-Ro; Tue, 25 Oct 2022 17:38:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430027.681471; Tue, 25 Oct 2022 17:38:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onNsZ-00058n-P4; Tue, 25 Oct 2022 17:38:19 +0000
Received: by outflank-mailman (input) for mailman id 430027;
 Tue, 25 Oct 2022 17:38:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onNsY-00058d-IP; Tue, 25 Oct 2022 17:38:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onNsY-0008Vp-FH; Tue, 25 Oct 2022 17:38:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onNsY-0005a3-2F; Tue, 25 Oct 2022 17:38:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onNsY-0006qA-1l; Tue, 25 Oct 2022 17:38:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1cD5Dt/E+YfUKYYEGdWBDn7hVxbJSp1zijv3APyRUTE=; b=PfDxCFZvrKpBpU4Q7M2KhXHfrB
	0MzM2byhWq8n9hW1O5dMLFE/Ff5OpVGMGb24z03AkYRFibCN+6CrEFKUUqnJaCG3ieaYe9yZHSGS+
	TfCiOhG/qSBmVkPK8NbRqQ44RPh3WtoL6GhZnTo+WQARo7OWe+mGYY6GsycOsQsvaxeU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174393-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174393: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=db2c22633f3c761975d8f469a0e195d8b79e1287
X-Osstest-Versions-That:
    ovmf=fb493ac84ebc6860e1690770fb88183effadebfb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 17:38:18 +0000

flight 174393 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174393/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 db2c22633f3c761975d8f469a0e195d8b79e1287
baseline version:
 ovmf                 fb493ac84ebc6860e1690770fb88183effadebfb

Last test of basis   174370  2022-10-24 22:42:23 Z    0 days
Testing same since   174393  2022-10-25 08:22:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hao A Wu <hao.a.wu@intel.com>
  Matt DeVillier <matt.devillier@gmail.com>
  Sean Rhodes <sean@starlabs.systems>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   fb493ac84e..db2c22633f  db2c22633f3c761975d8f469a0e195d8b79e1287 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 17:49:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 17:49:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430036.681482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onO3A-0006oF-Sr; Tue, 25 Oct 2022 17:49:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430036.681482; Tue, 25 Oct 2022 17:49:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onO3A-0006o8-Q6; Tue, 25 Oct 2022 17:49:16 +0000
Received: by outflank-mailman (input) for mailman id 430036;
 Tue, 25 Oct 2022 17:49:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1rbF=22=gmail.com=tamas.k.lengyel@srs-se1.protection.inumbo.net>)
 id 1onO39-0006o1-B8
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 17:49:15 +0000
Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com
 [2607:f8b0:4864:20::b30])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5649a301-548d-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 19:49:14 +0200 (CEST)
Received: by mail-yb1-xb30.google.com with SMTP id o70so15589347yba.7
 for <xen-devel@lists.xenproject.org>; Tue, 25 Oct 2022 10:49:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5649a301-548d-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=c9JWNp/nLmkGAWQf3V/yqrLvd25bACgBvOhcSzQASLs=;
        b=Z5QDDhoWnZ0ye5YiPUVmPdWWgMvMPoklJjVoDiEkBqNIA8UT9LAjDRexKoDSxIcqhM
         kZnboNWdphcMY+ppOtnpbIeagqftZ4vct5waQg1lPpxhBhj0Es6e/ER6wMDxCSvvDhST
         vjs70rFaolf7bXFXdYrNcAcrQCP5kLpDc/Z4JDAoMdwAlK4cPeZ2FJ0zJZR3CHCj/2Oj
         TlwFdRw0n3jsxEsouh9D7v24yNE5BA4fm3wCHLQJil5nGtEDQ0BNmTsg7leVyMkxj8xd
         jtmwi/WXuiJ+gGSxAaXrm3ZcNLitQUhNmccxrDz7O6u0U223C0OdK8dt8tYBcr9VOWzd
         C8tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=c9JWNp/nLmkGAWQf3V/yqrLvd25bACgBvOhcSzQASLs=;
        b=7KpdTNqMO01KIQOdO8TDOFArdaD3cflAHCQbjLfmHiP6G0FuKFIk7sEv/YCqXxM+cw
         lhGhimrP4GzkowpEVk7eVmBXvN6f7XxMdBfWh1z2+J2Iy5SuiTS3GshBUHAF8LY7V/v3
         syoSxBSdztWmVbslE+2pvWGmkV9/ZHdBci8rziKlwpwvAORVYxT+xRqbXMY7ASrWT/GD
         DkAsNM8Hk5tGKPSiuA60Xcz24aYOUn7ORuLEpGINS8dOzdab7I+umm2U/p+GE53TZ8l6
         r3ZRl2oz/mhzlgTlsP0ozDVBqmuxFvm66DQ626BrvKVB8DbhR4R6aZhMzFDOzo5RVNNb
         Elgg==
X-Gm-Message-State: ACrzQf1ypS811WnDSZ19IM2FgBuTaZYZYHTi5r/4hvFWDWEqGsl570N2
	/ETzUjIfPK2z+/msi1sdCeesRCOmhLkDfPPmY6M=
X-Google-Smtp-Source: AMsMyM4OkFCukfqmXtKP2m8La76FFvY7YCqfNUclxl96Rf94ohdFlVoXtVKtki4rw8ye2zVIFlkVCE/jtutirT523L8=
X-Received: by 2002:a25:ea08:0:b0:6bc:436f:6798 with SMTP id
 p8-20020a25ea08000000b006bc436f6798mr36481345ybd.31.1666720153292; Tue, 25
 Oct 2022 10:49:13 -0700 (PDT)
MIME-Version: 1.0
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <Y1eamiBY0d+julWk@Air-de-Roger>
In-Reply-To: <Y1eamiBY0d+julWk@Air-de-Roger>
From: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Date: Tue, 25 Oct 2022 13:48:36 -0400
Message-ID: <CABfawhk=Awfxu6iBpBtpNF_qKsEW3tMMG4EJzH3okZzdyyESxg@mail.gmail.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, xen-devel@lists.xenproject.org, 
	Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Content-Type: multipart/alternative; boundary="000000000000ad55e005ebdf8640"

--000000000000ad55e005ebdf8640
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 25, 2022 at 4:13 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
wrote:
>
> On Mon, Oct 24, 2022 at 12:58:54PM -0400, Tamas K Lengyel wrote:
> > Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a
handful
> > of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by
an
> > external privileged tool is necessary, thus we extend the domctl to
allow for
> > querying for any guest MSRs. To remain compatible with the existing
setup if
> > no specific MSR is requested via the domctl the default list is
returned.
>
> I'm afraid I would benefit from some extra description about why you
> need to introduce a separate hook instead of using the existing
> do_rdmsr hook in arch_vpmu_ops (which is already hooked into
> guest_rdmsr()).
>
> Are the MSRs you are trying to fetch not accessible for the guest
> itself to read?

No, the reason we need this different hook is because do_rdmsr assumes the
guest is reading the MSRs that are currently loaded. For external tools
where v !=3D current the vpmu context needs to be saved by pausing the vcpu
first and then the MSR content returned from the saved context.

 Tamas

--000000000000ad55e005ebdf8640
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><br><br>On Tue, Oct 25, 2022 at 4:13 AM Roger Pau Mon=
n=C3=A9 &lt;<a href=3D"mailto:roger.pau@citrix.com">roger.pau@citrix.com</a=
>&gt; wrote:<br>&gt;<br>&gt; On Mon, Oct 24, 2022 at 12:58:54PM -0400, Tama=
s K Lengyel wrote:<br>&gt; &gt; Currently the XEN_DOMCTL_get_vcpu_msrs is o=
nly capable of gathering a handful<br>&gt; &gt; of predetermined vcpu MSRs.=
 In our use-case gathering the vPMU MSRs by an<br>&gt; &gt; external privil=
eged tool is necessary, thus we extend the domctl to allow for<br>&gt; &gt;=
 querying for any guest MSRs. To remain compatible with the existing setup =
if<br>&gt; &gt; no specific MSR is requested via the domctl the default lis=
t is returned.<br>&gt;<br>&gt; I&#39;m afraid I would benefit from some ext=
ra description about why you<br>&gt; need to introduce a separate hook inst=
ead of using the existing<br>&gt; do_rdmsr hook in arch_vpmu_ops (which is =
already hooked into<br>&gt; guest_rdmsr()).<br>&gt;<br>&gt; Are the MSRs yo=
u are trying to fetch not accessible for the guest<br>&gt; itself to read?<=
br><br></div>No, the reason we need this different hook is because do_rdmsr=
 assumes the guest is reading the MSRs that are currently loaded. For exter=
nal tools where v !=3D current the vpmu context needs to be saved by pausin=
g the vcpu first and then the MSR content returned from the saved context.<=
br><div><br></div><div>=C2=A0Tamas<br></div></div>

--000000000000ad55e005ebdf8640--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 19:08:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 19:08:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430046.681500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onPHg-0007ox-Ml; Tue, 25 Oct 2022 19:08:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430046.681500; Tue, 25 Oct 2022 19:08:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onPHg-0007oq-JS; Tue, 25 Oct 2022 19:08:20 +0000
Received: by outflank-mailman (input) for mailman id 430046;
 Tue, 25 Oct 2022 19:08:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LEuh=22=epam.com=prvs=2297fba9c9=oleksandr_tyshchenko@srs-se1.protection.inumbo.net>)
 id 1onPHe-0007ok-Vz
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 19:08:19 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60af786a-5498-11ed-91b5-6bf2151ebd3b;
 Tue, 25 Oct 2022 21:08:16 +0200 (CEST)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29PHgrI4025867;
 Tue, 25 Oct 2022 19:07:49 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3kee6rsw5r-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 25 Oct 2022 19:07:48 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15)
 by VI1PR0301MB6656.eurprd03.prod.outlook.com (2603:10a6:800:17f::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Tue, 25 Oct
 2022 19:07:45 +0000
Received: from DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc]) by DB8PR03MB6108.eurprd03.prod.outlook.com
 ([fe80::93be:22b1:654c:e4bc%5]) with mapi id 15.20.5746.023; Tue, 25 Oct 2022
 19:07:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60af786a-5498-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vj9LN1rq+MxywGn4gy7UHnJXsrUBlM/UV3s8T5wA/sJa3KntaldRV2yi/JV+JZ3qf8soQPWG6xNwq9QPELsCI1Pky5YpOyS/RCTIVzmdFjaJk0szA8JBvQj4/HlcO+T0I8MYF12mp2iXMb+PJUj8YysN4lWOh2T1UcKk+DR4ymdA3xWiQsrwGbI5Ay4VbJENMZ/+Nwzh6aRlzPKdg3zl0DmCE6IqjRIzVsKk4ia9SnOGitZsxWDO13jLholZvesZWKWp8cfexzAb4GLSi/AIPKYlxU1dyNCX3mrFqe8ZH6NZpB2cB3ECD3tsspP6RujvmWsrtOVHVXVCq1bliKQa9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BfpE9kKYU67mjboo3nxvV0bHIn12MdFh+rLqbQs1nFQ=;
 b=Mflig/t5GdiFsOKMsNKteC237xHbUjmUFL0KWlewgIXgiQxFuN+1drSW1DO30RYYmCbMldxHGvFz57/10uadoovbLIEpaOLBzv0ODk6x1UMBZBOWJ9m/jLGdz5JbUA5sYxqBkJ6OMqfnB9qJTHB6t2gh8C+nCdn60SO/BwveoyuhDdeh6A6bEhRbhwzOZw3rwCB+kIfmtWQpmDNzQ4wfAORcSb6MWzCJsVFgjn1xm6qlc18xUyiTQ8cqH+/BGzcCJnnn7ICpaZ7lu4wpgjSNyl+hXc6E8G6W1rd1/GgCzHmm/akuOrjOWcwzdH93UVPP1jxLfKOm6a9ZAqTvdib2Tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BfpE9kKYU67mjboo3nxvV0bHIn12MdFh+rLqbQs1nFQ=;
 b=XA4542hk2qa6PQ4CcQ/uPWu/47cN3DR5OMCwU+zM06NMTjzg7kdeFFTiZplUDUt2gNaBghfqcBUmZK+PnjY9AKK+/A8eSsOI607czmvxp0fvS28g5eBRdNEHwaHm7fjBWEqP9jGdZvqkBUu57vfNOlcrHhPh9Zi0sik/erknz6eBk3htBrzQnRZpHqEe/jKy8H5yxMGfX6RFJV8YMpjSFWuw6Fvm6etRoAH11lVYz1BrikusGchamMuhv609pH1xEsHx/k+PXne8vXUhBTLHjzIWheMjsYV9QYErjCO5zvAKecAQYyhUiWgUCc0riIaZjnBbZQwMeaUvJeZgr71nHQ==
From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>
To: Xenia Ragiadakou <burzalodowa@gmail.com>
CC: Catalin Marinas <catalin.marinas@arm.com>,
        Russell King
	<linux@armlinux.org.uk>,
        Stefano Stabellini <sstabellini@kernel.org>,
        "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr
 Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH V4 1/2] xen/virtio: Optimize the setup of "xen-grant-dma"
 devices
Thread-Topic: [PATCH V4 1/2] xen/virtio: Optimize the setup of "xen-grant-dma"
 devices
Thread-Index: AQHY6I2t+xPyBbNkxUyOnWS/3Sy6NK4fXPIAgAAcEgA=
Date: Tue, 25 Oct 2022 19:07:44 +0000
Message-ID: <35a48c50-0bdc-e932-9fb2-9f7e89c3eb04@epam.com>
References: <20221025162004.8501-1-olekstysh@gmail.com>
 <20221025162004.8501-2-olekstysh@gmail.com>
 <6cab9931-8f72-9b90-bf58-f12108f84c58@gmail.com>
In-Reply-To: <6cab9931-8f72-9b90-bf58-f12108f84c58@gmail.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DB8PR03MB6108:EE_|VI1PR0301MB6656:EE_
x-ms-office365-filtering-correlation-id: 255e40b2-93f1-42d2-da53-08dab6bc32d4
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 ghLx19e7kY9g3vRhogM4v0U/ZJAeJvKBoPt/AfBQy68qlStZFn2Q8z1Ps/xjJnj9QDwTtE7IO+vZMnHo2YSySv0i/nSoaU+tXbOQGC4JVbt+qCwmHL+nH6eU9iwNJRaA3kWDkcbBkPpEf6h4DZqB2Xs58rVxIfASEKD7u9t6J6GGQKPTFAhRS1OO/jJCHI3xBmakXYwq5pJI0d+R2XbH0xZvYZ4AUttyfmYQwklgAWhxpk2c6lFqeu4h4fgEGWGSJWTwmLOSl6DUY/7PcfLuB16bJdrWrnVgVgH/pFtazZFO7Nj/2kPsZKsMttT6G/KSqZrD4yOZ3fckwkbtenunGiWmHsbG1FrRKEb+QDp+Km1h7Cd4CVpqdRL6D0Gu+JC9kZ7MB5fHtTOakg8Mxfw3gDmqXTJKq+Qc/CcErKrI/3WKqjat/o1C9iRd4Ai5W/Vfr4vKevgW26TWMaVMM2aOP2kEhvTFLUDgF2kM+obr39UsfOt8Vnf7M9X0W+najmkCMvQfblBi/c6aXZCR2+XzMOnqUUfToBkdIqFYcugmJSrWC40TdWO5JbLLil5gI16i6RFtvGeMgXpOkgeQgaYaXlX7PrOFM6GNcsRvWYQqsbKjIALp+ujwHpsQNMJvX/I9jc9YekSxV1hwMegfuk6MuTKazzwjFWahxkuLZ+oU5JDxTWOKEFn+ohPpySfYcJWkPctGjS+xA5Q0BwkgTLzpHBurBl30tXj1diRDQmFRbrnMCsDXiQcOlIn/Sb59LEvMmlSzUOcufw//ouJi+c5Yuy8w805fRgBBn+SlBORxRPXObWZvYReLs6gA/hFmUQsO
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(346002)(396003)(136003)(39860400002)(451199015)(31686004)(71200400001)(478600001)(6486002)(31696002)(6512007)(6916009)(54906003)(316002)(83380400001)(38100700002)(86362001)(53546011)(91956017)(66946007)(66556008)(4326008)(8676002)(64756008)(76116006)(122000001)(55236004)(66446008)(66476007)(6506007)(36756003)(186003)(2616005)(41300700001)(2906002)(26005)(38070700005)(5660300002)(8936002)(21314003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?b1VYR3ZLcm9HN3hpT0ovU01rY2I1OEtOdEhvUkxkQmZJdGpQS0JZb3pOalJm?=
 =?utf-8?B?U3RXUkgvOS9mRTlZSGpmTFRGdGpXcHoyVmFROTBCYVdBdXBHeUJSZXpoaS84?=
 =?utf-8?B?MzNobTZTcnZKM1pYM0haOGNSU3AyL3BSUnhLbnhYQVpJTGw3bE16dyttVXZG?=
 =?utf-8?B?VHpLYXp0TjRRMUIyemFXQWx2YXRuS3R3a1dCUGw3QnlVdHRSMXpuYnc3S1Q2?=
 =?utf-8?B?QUJxMkhXbEMvRFVxazd3S0dKZTIvWTkzVUhySDhXaU54ZFlWbFFDVE1QWU42?=
 =?utf-8?B?OUNzYlAwRTd0aWZPSXFFZlVoZTVPOXBtYzFTSzZpN3lWb2pTeWViczVNTGIr?=
 =?utf-8?B?RldZQ293Z0lBNENINnIvV0U3YWs4TDJ4SmtKbHJCWWoxakk5ejBHVnFnYmJH?=
 =?utf-8?B?RW1vdjVybFl3MWVrcjhFL0d6M0xWNXIyOUtpVXF5SHNmd2RLZytIeDdmWDYy?=
 =?utf-8?B?bjFrRTFWdTVyWVM3eUt5eW9SNm1qS0FQcnE4MlFqSFZMWHdyMzFka1pmOU4y?=
 =?utf-8?B?bFdraklOQ0xROFoyZlc5NTN6d2xORUhHano0OGlFOFVDbUkwL3Z2SFVLRXNn?=
 =?utf-8?B?dktFNWxsRWZlZmdVNGY1TTB1ZG1oT2dtTkNxaXEyWllqeHd3ZkVVdkRtaHlT?=
 =?utf-8?B?OCt6OEpWK0p5UUNCTXdveklpWjhzTndJeFN4T3lYaElVNUY2QzhiNmZGWnQy?=
 =?utf-8?B?dDJML1Y5SXpLVGRrMHMwaDl4SWNjR3p3ZHh5emZHb0RVVDZzZ1RudTB4ajd5?=
 =?utf-8?B?MFgwODI2SlVmdnE0SUpzdDkxM2VKNGZXdzg1eTBrK1RPb2hIdk15eE5oRk04?=
 =?utf-8?B?aHN6L2ZmcWlUNXdxc01aVHYrcStyRkVNdG83ZXFLdXJNRjIzQjZsNGhBYWZM?=
 =?utf-8?B?VlFnQk5EOE5XUjlpOEdLdUREeDY0Z2NVWGl6K3FCNm1EblNDYkJkRUdFb1VJ?=
 =?utf-8?B?S0xCaHZ0MlMvM1hSZXNxSk1HbXEydWxYNWk0THZWRlp5L1hlYUNsWTg5OW9k?=
 =?utf-8?B?cFJRWnBLYS9OcnZGZkxBVUpjZ0V1U1FUQVozOFJMYzIvSU1XSUljREpqd09y?=
 =?utf-8?B?RUpSU2NZdm5BUHpLYTFiSVlmSS9ONm9pY0l6MmhTcXppNURlSTVSYlhXRi9D?=
 =?utf-8?B?Rkdwa3hlR04rUjA5RXRLeTE2QTl5VGplcFlBdUtSYWhrNmVlR3VyYktMYXlv?=
 =?utf-8?B?eFdDb3p6ZTBrdnZFc3JISVFCeE5vRUdaY0h6MEJ2blNlS1dZQ1lQYzBZeUdN?=
 =?utf-8?B?anZVUFl1YlozenQ4VW5MNEp3RzNxaUFLNTNBRlNEanNFT21tRTNSOGwxQmFy?=
 =?utf-8?B?YmNLeDFScmxrQ2FTMUU3VlRwMVRQMFNhaVJxaHZYU1JyVUJhYlgxOG9QTVNB?=
 =?utf-8?B?ZXVoTDlENE9NdmhOMzhuU3g3WDh2N05pa2d2ZzFVbzJmSHcwTmJnTkhjeTU2?=
 =?utf-8?B?Q1JhUlNHTkprTEl0dkRNQS9HWmtabE5pazRhaUhGaUFVSzZ5d1A3ak1rNldu?=
 =?utf-8?B?aVZVQlZ5bnFIV3RFdnJoTFhQeTNRUlRrdUt4WlpINnhtMGM3cFhuUEorSUJZ?=
 =?utf-8?B?TkxQTjZLNnVqYUpVRjF0M0RWdytuc09hcENtSVJma2FXUVdYbWhGN045K3U5?=
 =?utf-8?B?TXg4dGw4ZU1PaWkrOUdKQ0xha1d2eGZVUU96MEt3dFlBeTZtRXlsckFYd1Mx?=
 =?utf-8?B?NUJiVlNWa0F0RUdGNEJaNWwxcUJHTTQ4V2VoQll5NmVpTVBTTDZ3MlFtd054?=
 =?utf-8?B?UmR0VG1MV29Sbmd0UndlS3VaaWwrZ0tEbUgvdE12TEZTeFBLWFlFa0hrZU13?=
 =?utf-8?B?NklNQjlJT1U0dnhQbVBoS2hMcjMyOWtEcEppemVUaGZUbHg0TEtuTkRKY25S?=
 =?utf-8?B?YlhTa1Vsb0xtU3hvWFVvZm53VHVBNGNmMVF4SGc4N2FPUDRHTjJTanBtcWdm?=
 =?utf-8?B?TjNSd2xwN1VpUm5ndG1IMCtpMDlNR2tqZU04NTVscWZBeTdFVzZ5ZDg5akR4?=
 =?utf-8?B?dE5pT1UxRHAyTExVMDhxeGdGTXhPSy9iRnNFU1ZlZFh3OFU3NGRGelJsQ0VD?=
 =?utf-8?B?d1Era0Fid0RqaFZNdk10RFEvOE1UVjgwdEhYOWJ3Z2cxMFN4bVFsK3MwMnMx?=
 =?utf-8?B?STl2YkpaWnNMWmh3aXJSOGh2T2xqQnVwOEcyVWhsK3laOWRBdE9FRWJGZjZF?=
 =?utf-8?Q?ZWWI9439JySfwBaFSAU1uoI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BC2A975BA4CD1C48B0A8967AC2B76551@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 255e40b2-93f1-42d2-da53-08dab6bc32d4
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 19:07:44.8638
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2TNWi1L1x+Q3ZEyIdji55YLtjs/KStfXwDZGbNW2MAxyMzKoPTCTNMma0GF3loZKVNqMZCiUvqP3VBPlj/LmQQE+Ha3ip3370B3rhDbYTNw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0301MB6656
X-Proofpoint-GUID: JL3zGaACOKOuxXqY5vLtrgH9R9zclja7
X-Proofpoint-ORIG-GUID: JL3zGaACOKOuxXqY5vLtrgH9R9zclja7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-25_12,2022-10-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=999 phishscore=0 adultscore=0 clxscore=1011 priorityscore=1501
 impostorscore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210250108

DQpPbiAyNS4xMC4yMiAyMDoyNywgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCg0KSGVsbG8gWGVu
aWENCg0KPiBPbiAxMC8yNS8yMiAxOToyMCwgT2xla3NhbmRyIFR5c2hjaGVua28gd3JvdGU6DQo+
PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5j
b20+DQo+Pg0KPj4gVGhpcyBpcyBuZWVkZWQgdG8gYXZvaWQgaGF2aW5nIHRvIHBhcnNlIHRoZSBz
YW1lIGRldmljZS10cmVlDQo+PiBzZXZlcmFsIHRpbWVzIGZvciBhIGdpdmVuIGRldmljZS4NCj4+
DQo+PiBGb3IgdGhpcyB0byB3b3JrIHdlIG5lZWQgdG8gaW5zdGFsbCB0aGUgeGVuX3ZpcnRpb19y
ZXN0cmljdGVkX21lbV9hY2MNCj4+IGNhbGxiYWNrIGluIEFybSdzIHhlbl9ndWVzdF9pbml0KCkg
d2hpY2ggaXMgc2FtZSBjYWxsYmFjayBhcyB4ODYncw0KPj4gUFYgYW5kIEhWTSBtb2RlcyBhbHJl
YWR5IHVzZSBhbmQgcmVtb3ZlIHRoZSBtYW51YWwgYXNzaWdubWVudCBpbg0KPj4geGVuX3NldHVw
X2RtYV9vcHMoKS4gQWxzbyB3ZSBuZWVkIHRvIHNwbGl0IHRoZSBjb2RlIHRvIGluaXRpYWxpemUN
Cj4+IGJhY2tlbmRfZG9taWQgaW50byBhIHNlcGFyYXRlIGZ1bmN0aW9uLg0KPj4NCj4+IFByaW9y
IHRvIGN1cnJlbnQgcGF0Y2ggd2UgcGFyc2VkIHRoZSBkZXZpY2UtdHJlZSB0aHJlZSB0aW1lczoN
Cj4+IDEuIHhlbl9zZXR1cF9kbWFfb3BzKCktPi4uLi0+eGVuX2lzX2R0X2dyYW50X2RtYV9kZXZp
Y2UoKQ0KPj4gMi4geGVuX3NldHVwX2RtYV9vcHMoKS0+Li4uLT54ZW5fZHRfZ3JhbnRfaW5pdF9i
YWNrZW5kX2RvbWlkKCkNCj4+IDMuIHhlbl92aXJ0aW9fbWVtX2FjYygpLT4uLi4tPnhlbl9pc19k
dF9ncmFudF9kbWFfZGV2aWNlKCkNCj4+DQo+PiBXaXRoIGN1cnJlbnQgcGF0Y2ggd2UgcGFyc2Ug
dGhlIGRldmljZS10cmVlIG9ubHkgb25jZSBpbg0KPj4geGVuX3ZpcnRpb19yZXN0cmljdGVkX21l
bV9hY2MoKS0+Li4uLT54ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKCkNCj4+DQo+PiBP
dGhlciBiZW5lZml0cyBhcmU6DQo+PiAtIE5vdCBkaXZlcmdlIGZyb20geDg2IHdoZW4gc2V0dGlu
ZyB1cCBYZW4gZ3JhbnQgRE1BIG9wcw0KPj4gLSBEcm9wIHNldmVyYWwgZ2xvYmFsIGZ1bmN0aW9u
cw0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJf
dHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4NCj4gUmV2aWV3ZWQtYnk6IFhlbmlhIFJhZ2lhZGFrb3Ug
PGJ1cnphbG9kb3dhQGdtYWlsLmNvbT4NCg0KVGhhbmtzIQ0KDQoNCj4NCj4gSSBoYXZlIGEgcXVl
c3Rpb24gdW5yZWxhdGVkIHRvIHRoZSBwYXRjaC4NCj4gQ09ORklHX1hFTl9WSVJUSU9fRk9SQ0Vf
R1JBTlQgY2Fubm90IGJlIHVzZWQgdG8gZm9yY2UgYmFja2VuZCBkb20wIGluIA0KPiBjYXNlIHhl
bl9kdF9ncmFudF9pbml0X2JhY2tlbmRfZG9taWQoKSBmYWlscz8NCg0KR29vZCBxdWVzdGlvbiwg
YXMgYWx3YXlzKQ0KDQoNCkN1cnJlbnQgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZpb3IgaW4g
dGhlIGNvbnRleHQgb2YgDQpDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFOVCB1c2FnZSBvbiBB
cm0gd2l0aCBkZXZpY2UtdHJlZSwNCnRoaXMgb3B0aW9uIGlzIG5vdCBhcHBsaWVkIGZvciBkZXZp
Y2UtdHJlZSBiYXNlZCBkZXZpY2VzLCBhcyBmb3IgdGhlbSB3ZSANCmhhdmUgYSB3YXkgdG8gY29t
bXVuaWNhdGUgYmFja2VuZF9kb21pZCwgc28gbm8gbmVlZCB0byBndWVzcy4NCg0KQmVsb3cgbXkg
dW5kZXJzdGFuZGluZywgd2hpY2ggbWlnaHQgYmUgd3JvbmcuDQoNClRoZSB4ZW5fZHRfZ3JhbnRf
aW5pdF9iYWNrZW5kX2RvbWlkKCkgZmFpbHVyZSBtZWFucyB0aGF0IHdlIGRpZG4ndCANCnJldHJp
ZXZlIHRoZSBiYWNrZW5kX2RvbWlkIGZyb20gdGhlIGRldmljZSBub2RlDQooZWl0aGVyIHRoZSBi
aW5kaW5ncyBpcyB3cm9uZyBvciBpdCBpcyBhYnNlbnQgYXQgYWxsLCB0aGUgbGF0ZXIgbWVhbnMg
DQp0aGF0IGRldmljZSBpcyAqbm90KiByZXF1aXJlZCB1c2UgZ3JhbnRzIGZvciB2aXJ0aW8pLg0K
SSBkb24ndCByZWFsbHkga25vdyB3aGV0aGVyIGZvcmNpbmcgdGhlIGdyYW50IHVzYWdlIHdpdGgg
ZG9taWQgPSAwIHdvdWxkIA0KYmUgdGhlIGdvb2QgaWRlYSBpbiB0aGF0IGNhc2UsIHRoaXMganVz
dCBtaWdodCBub3Qgd29yay4NCkZvciB0aGUgaW5zdGFuY2UsIGlmIHRoZSBiYWNrZW5kIGlzIG90
aGVyIHRoYW4gRG9tMCBkb21haW4gb3IgaXQgaXMgaW4gDQpEb20wIGJ1dCBkb2Vzbid0IHN1cHBv
cnQgZ3JhbnQgbWFwcGluZ3MuDQoNCiBGcm9tIG90aGVyIGhhbmQsIHRoZSBDT05GSUdfWEVOX1ZJ
UlRJT19GT1JDRV9HUkFOVCBpcyBkaXNhYmxlZCBieSANCmRlZmF1bHQsIGlmIGl0IGdldHMgZW5h
YmxlZCB0aGVuIHRoZSB1c2VyIGlzIGxpa2VseSBhd2FyZSBvZiB0aGUgDQpjb25zZXF1ZW5jZXMu
DQpJZiB3ZSB3YW50IHRvIGFsd2F5cyBob25vciBDT05GSUdfWEVOX1ZJUlRJT19GT1JDRV9HUkFO
VCwgd2Ugd291bGQgDQpsaWtlbHkgbmVlZCB0byBoYXZlICJpZiAoSVNfRU5BQkxFRChDT05GSUdf
WEVOX1ZJUlRJT19GT1JDRV9HUkFOVCkpIg0KY2hlY2sgdGhlIGZpcnN0IChiZWZvcmUgdGhlIGNo
ZWNrIGZvciBEVCBkZXZpY2UpLg0KDQoNCj4NCj4NCj4+IC0tLQ0KPj4gTmV3IHBhdGNoDQo+PiAt
LS0NCj4+IMKgIGFyY2gvYXJtL3hlbi9lbmxpZ2h0ZW4uY8KgwqDCoCB8wqAgMiArLQ0KPj4gwqAg
ZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIHwgNzcgKysrKysrKysrKysrKystLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLQ0KPj4gwqAgaW5jbHVkZS94ZW4vYXJtL3hlbi1vcHMuaMKgwqAgfMKgIDQg
Ky0NCj4+IMKgIGluY2x1ZGUveGVuL3hlbi1vcHMuaMKgwqDCoMKgwqDCoCB8IDE2IC0tLS0tLS0t
DQo+PiDCoCA0IGZpbGVzIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDY5IGRlbGV0aW9ucygt
KQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS94ZW4vZW5saWdodGVuLmMgYi9hcmNoL2Fy
bS94ZW4vZW5saWdodGVuLmMNCj4+IGluZGV4IDkzYzhjY2JmMjk4Mi4uN2Q1OTc2NWFlZjIyIDEw
MDY0NA0KPj4gLS0tIGEvYXJjaC9hcm0veGVuL2VubGlnaHRlbi5jDQo+PiArKysgYi9hcmNoL2Fy
bS94ZW4vZW5saWdodGVuLmMNCj4+IEBAIC00NDUsNyArNDQ1LDcgQEAgc3RhdGljIGludCBfX2lu
aXQgeGVuX2d1ZXN0X2luaXQodm9pZCkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsN
Cj4+IMKgIMKgwqDCoMKgwqAgaWYgKElTX0VOQUJMRUQoQ09ORklHX1hFTl9WSVJUSU8pKQ0KPj4g
LcKgwqDCoMKgwqDCoMKgIHZpcnRpb19zZXRfbWVtX2FjY19jYih4ZW5fdmlydGlvX21lbV9hY2Mp
Ow0KPj4gK8KgwqDCoMKgwqDCoMKgIHZpcnRpb19zZXRfbWVtX2FjY19jYih4ZW5fdmlydGlvX3Jl
c3RyaWN0ZWRfbWVtX2FjYyk7DQo+PiDCoCDCoMKgwqDCoMKgIGlmICghYWNwaV9kaXNhYmxlZCkN
Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fYWNwaV9ndWVzdF9pbml0KCk7DQo+PiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQtZG1hLW9wcy5jIGIvZHJpdmVycy94ZW4vZ3JhbnQtZG1h
LW9wcy5jDQo+PiBpbmRleCBkYWE1MjVkZjdiZGMuLjFlNzk3YTA0Mzk4MCAxMDA2NDQNCj4+IC0t
LSBhL2RyaXZlcnMveGVuL2dyYW50LWRtYS1vcHMuYw0KPj4gKysrIGIvZHJpdmVycy94ZW4vZ3Jh
bnQtZG1hLW9wcy5jDQo+PiBAQCAtMjkyLDUwICsyOTIsMjAgQEAgc3RhdGljIGNvbnN0IHN0cnVj
dCBkbWFfbWFwX29wcyANCj4+IHhlbl9ncmFudF9kbWFfb3BzID0gew0KPj4gwqDCoMKgwqDCoCAu
ZG1hX3N1cHBvcnRlZCA9IHhlbl9ncmFudF9kbWFfc3VwcG9ydGVkLA0KPj4gwqAgfTsNCj4+IMKg
IC1zdGF0aWMgYm9vbCB4ZW5faXNfZHRfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2aWNlICpk
ZXYpDQo+PiAtew0KPj4gLcKgwqDCoCBzdHJ1Y3QgZGV2aWNlX25vZGUgKmlvbW11X25wOw0KPj4g
LcKgwqDCoCBib29sIGhhc19pb21tdTsNCj4+IC0NCj4+IC3CoMKgwqAgaW9tbXVfbnAgPSBvZl9w
YXJzZV9waGFuZGxlKGRldi0+b2Zfbm9kZSwgImlvbW11cyIsIDApOw0KPj4gLcKgwqDCoCBoYXNf
aW9tbXUgPSBpb21tdV9ucCAmJg0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNl
X2lzX2NvbXBhdGlibGUoaW9tbXVfbnAsICJ4ZW4sZ3JhbnQtZG1hIik7DQo+PiAtwqDCoMKgIG9m
X25vZGVfcHV0KGlvbW11X25wKTsNCj4+IC0NCj4+IC3CoMKgwqAgcmV0dXJuIGhhc19pb21tdTsN
Cj4+IC19DQo+PiAtDQo+PiAtYm9vbCB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShzdHJ1Y3QgZGV2
aWNlICpkZXYpDQo+PiAtew0KPj4gLcKgwqDCoCAvKiBYWFggSGFuZGxlIG9ubHkgRFQgZGV2aWNl
cyBmb3Igbm93ICovDQo+PiAtwqDCoMKgIGlmIChkZXYtPm9mX25vZGUpDQo+PiAtwqDCoMKgwqDC
oMKgwqAgcmV0dXJuIHhlbl9pc19kdF9ncmFudF9kbWFfZGV2aWNlKGRldik7DQo+PiAtDQo+PiAt
wqDCoMKgIHJldHVybiBmYWxzZTsNCj4+IC19DQo+PiAtDQo+PiAtYm9vbCB4ZW5fdmlydGlvX21l
bV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikNCj4+IC17DQo+PiAtwqDCoMKgIGlmIChJ
U19FTkFCTEVEKENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5UKSB8fCB4ZW5fcHZfZG9tYWlu
KCkpDQo+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHRydWU7DQo+PiAtDQo+PiAtwqDCoMKgIHJl
dHVybiB4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShkZXYtPmRldi5wYXJlbnQpOw0KPj4gLX0NCj4+
IC0NCj4+IMKgIHN0YXRpYyBpbnQgeGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1
Y3QgZGV2aWNlICpkZXYsDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgc3RydWN0IHhlbl9ncmFudF9kbWFfZGF0YSAqZGF0YSkNCj4+ICvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkb21pZF90ICpiYWNrZW5kX2RvbWlk
KQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzIGlvbW11X3Nw
ZWM7DQo+PiDCoCDCoMKgwqDCoMKgIGlmIChvZl9wYXJzZV9waGFuZGxlX3dpdGhfYXJncyhkZXYt
Pm9mX25vZGUsICJpb21tdXMiLCANCj4+ICIjaW9tbXUtY2VsbHMiLA0KPj4gwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgMCwgJmlvbW11X3NwZWMpKSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgZGV2
X2VycihkZXYsICJDYW5ub3QgcGFyc2UgaW9tbXVzIHByb3BlcnR5XG4iKTsNCj4+ICvCoMKgwqDC
oMKgwqDCoCBkZXZfZGJnKGRldiwgIkNhbm5vdCBwYXJzZSBpb21tdXMgcHJvcGVydHlcbiIpOw0K
Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVNSQ0g7DQo+PiDCoMKgwqDCoMKgIH0NCj4+
IMKgIMKgwqDCoMKgwqAgaWYgKCFvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShpb21tdV9zcGVjLm5w
LCAieGVuLGdyYW50LWRtYSIpIHx8DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpb21t
dV9zcGVjLmFyZ3NfY291bnQgIT0gMSkgew0KPj4gLcKgwqDCoMKgwqDCoMKgIGRldl9lcnIoZGV2
LCAiSW5jb21wYXRpYmxlIElPTU1VIG5vZGVcbiIpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGRldl9k
YmcoZGV2LCAiSW5jb21wYXRpYmxlIElPTU1VIG5vZGVcbiIpOw0KPj4gwqDCoMKgwqDCoMKgwqDC
oMKgIG9mX25vZGVfcHV0KGlvbW11X3NwZWMubnApOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJl
dHVybiAtRVNSQ0g7DQo+PiDCoMKgwqDCoMKgIH0NCj4+IEBAIC0zNDYsMTIgKzMxNiwyOCBAQCBz
dGF0aWMgaW50IA0KPj4geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChzdHJ1Y3QgZGV2
aWNlICpkZXYsDQo+PiDCoMKgwqDCoMKgwqAgKiBUaGUgZW5kcG9pbnQgSUQgaGVyZSBtZWFucyB0
aGUgSUQgb2YgdGhlIGRvbWFpbiB3aGVyZSB0aGUNCj4+IMKgwqDCoMKgwqDCoCAqIGNvcnJlc3Bv
bmRpbmcgYmFja2VuZCBpcyBydW5uaW5nDQo+PiDCoMKgwqDCoMKgwqAgKi8NCj4+IC3CoMKgwqAg
ZGF0YS0+YmFja2VuZF9kb21pZCA9IGlvbW11X3NwZWMuYXJnc1swXTsNCj4+ICvCoMKgwqAgKmJh
Y2tlbmRfZG9taWQgPSBpb21tdV9zcGVjLmFyZ3NbMF07DQo+PiDCoCDCoMKgwqDCoMKgIHJldHVy
biAwOw0KPj4gwqAgfQ0KPj4gwqAgLXZvaWQgeGVuX2dyYW50X3NldHVwX2RtYV9vcHMoc3RydWN0
IGRldmljZSAqZGV2KQ0KPj4gK3N0YXRpYyBpbnQgeGVuX2dyYW50X2luaXRfYmFja2VuZF9kb21p
ZChzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgZG9taWRfdCAqYmFja2VuZF9kb21pZCkNCj4+ICt7DQo+PiArwqDCoMKgIGludCBy
ZXQgPSAtRU5PREVWOw0KPj4gKw0KPj4gK8KgwqDCoCBpZiAoZGV2LT5vZl9ub2RlKSB7DQo+PiAr
wqDCoMKgwqDCoMKgwqAgcmV0ID0geGVuX2R0X2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYs
IGJhY2tlbmRfZG9taWQpOw0KPj4gK8KgwqDCoCB9IGVsc2UgaWYgKElTX0VOQUJMRUQoQ09ORklH
X1hFTl9WSVJUSU9fRk9SQ0VfR1JBTlQpIHx8IA0KPj4geGVuX3B2X2RvbWFpbigpKSB7DQo+PiAr
wqDCoMKgwqDCoMKgwqAgZGV2X2luZm8oZGV2LCAiVXNpbmcgZG9tMCBhcyBiYWNrZW5kXG4iKTsN
Cj4+ICvCoMKgwqDCoMKgwqDCoCAqYmFja2VuZF9kb21pZCA9IDA7DQo+PiArwqDCoMKgwqDCoMKg
wqAgcmV0ID0gMDsNCj4+ICvCoMKgwqAgfQ0KPj4gKw0KPj4gK8KgwqDCoCByZXR1cm4gcmV0Ow0K
Pj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1
Y3QgZGV2aWNlICpkZXYsIGRvbWlkX3QgDQo+PiBiYWNrZW5kX2RvbWlkKQ0KPj4gwqAgew0KPj4g
wqDCoMKgwqDCoCBzdHJ1Y3QgeGVuX2dyYW50X2RtYV9kYXRhICpkYXRhOw0KPj4gwqAgQEAgLTM2
NSwxNiArMzUxLDcgQEAgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNl
ICpkZXYpDQo+PiDCoMKgwqDCoMKgIGlmICghZGF0YSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBn
b3RvIGVycjsNCj4+IMKgIC3CoMKgwqAgaWYgKGRldi0+b2Zfbm9kZSkgew0KPj4gLcKgwqDCoMKg
wqDCoMKgIGlmICh4ZW5fZHRfZ3JhbnRfaW5pdF9iYWNrZW5kX2RvbWlkKGRldiwgZGF0YSkpDQo+
PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVycjsNCj4+IC3CoMKgwqAgfSBlbHNlIGlm
IChJU19FTkFCTEVEKENPTkZJR19YRU5fVklSVElPX0ZPUkNFX0dSQU5UKSkgew0KPj4gLcKgwqDC
oMKgwqDCoMKgIGRldl9pbmZvKGRldiwgIlVzaW5nIGRvbTAgYXMgYmFja2VuZFxuIik7DQo+PiAt
wqDCoMKgwqDCoMKgwqAgZGF0YS0+YmFja2VuZF9kb21pZCA9IDA7DQo+PiAtwqDCoMKgIH0gZWxz
ZSB7DQo+PiAtwqDCoMKgwqDCoMKgwqAgLyogWFhYIEFDUEkgZGV2aWNlIHVuc3VwcG9ydGVkIGZv
ciBub3cgKi8NCj4+IC3CoMKgwqDCoMKgwqDCoCBnb3RvIGVycjsNCj4+IC3CoMKgwqAgfQ0KPj4g
K8KgwqDCoCBkYXRhLT5iYWNrZW5kX2RvbWlkID0gYmFja2VuZF9kb21pZDsNCj4+IMKgIMKgwqDC
oMKgwqAgaWYgKHN0b3JlX3hlbl9ncmFudF9kbWFfZGF0YShkZXYsIGRhdGEpKSB7DQo+PiDCoMKg
wqDCoMKgwqDCoMKgwqAgZGV2X2VycihkZXYsICJDYW5ub3Qgc3RvcmUgWGVuIGdyYW50IERNQSBk
YXRhXG4iKTsNCj4+IEBAIC0zOTIsMTIgKzM2OSwxNCBAQCB2b2lkIHhlbl9ncmFudF9zZXR1cF9k
bWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+IMKgIMKgIGJvb2wgeGVuX3ZpcnRpb19yZXN0
cmljdGVkX21lbV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikNCj4+IMKgIHsNCj4+IC3C
oMKgwqAgYm9vbCByZXQgPSB4ZW5fdmlydGlvX21lbV9hY2MoZGV2KTsNCj4+ICvCoMKgwqAgZG9t
aWRfdCBiYWNrZW5kX2RvbWlkOw0KPj4gwqAgLcKgwqDCoCBpZiAocmV0KQ0KPj4gLcKgwqDCoMKg
wqDCoMKgIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKGRldi0+ZGV2LnBhcmVudCk7DQo+PiArwqDC
oMKgIGlmICgheGVuX2dyYW50X2luaXRfYmFja2VuZF9kb21pZChkZXYtPmRldi5wYXJlbnQsIA0K
Pj4gJmJhY2tlbmRfZG9taWQpKSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgeGVuX2dyYW50X3NldHVw
X2RtYV9vcHMoZGV2LT5kZXYucGFyZW50LCBiYWNrZW5kX2RvbWlkKTsNCj4+ICvCoMKgwqDCoMKg
wqDCoCByZXR1cm4gdHJ1ZTsNCj4+ICvCoMKgwqAgfQ0KPj4gwqAgLcKgwqDCoCByZXR1cm4gcmV0
Ow0KPj4gK8KgwqDCoCByZXR1cm4gZmFsc2U7DQo+PiDCoCB9DQo+PiDCoCDCoCBNT0RVTEVfREVT
Q1JJUFRJT04oIlhlbiBncmFudCBETUEtbWFwcGluZyBsYXllciIpOw0KPj4gZGlmZiAtLWdpdCBh
L2luY2x1ZGUveGVuL2FybS94ZW4tb3BzLmggYi9pbmNsdWRlL3hlbi9hcm0veGVuLW9wcy5oDQo+
PiBpbmRleCBiMDc2NmE2NjAzMzguLjcwMDczZjVhMmI1NCAxMDA2NDQNCj4+IC0tLSBhL2luY2x1
ZGUveGVuL2FybS94ZW4tb3BzLmgNCj4+ICsrKyBiL2luY2x1ZGUveGVuL2FybS94ZW4tb3BzLmgN
Cj4+IEBAIC04LDkgKzgsNyBAQA0KPj4gwqAgc3RhdGljIGlubGluZSB2b2lkIHhlbl9zZXR1cF9k
bWFfb3BzKHN0cnVjdCBkZXZpY2UgKmRldikNCj4+IMKgIHsNCj4+IMKgICNpZmRlZiBDT05GSUdf
WEVODQo+PiAtwqDCoMKgIGlmICh4ZW5faXNfZ3JhbnRfZG1hX2RldmljZShkZXYpKQ0KPj4gLcKg
wqDCoMKgwqDCoMKgIHhlbl9ncmFudF9zZXR1cF9kbWFfb3BzKGRldik7DQo+PiAtwqDCoMKgIGVs
c2UgaWYgKHhlbl9zd2lvdGxiX2RldGVjdCgpKQ0KPj4gK8KgwqDCoCBpZiAoeGVuX3N3aW90bGJf
ZGV0ZWN0KCkpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZGV2LT5kbWFfb3BzID0gJnhlbl9zd2lv
dGxiX2RtYV9vcHM7DQo+PiDCoCAjZW5kaWYNCj4+IMKgIH0NCj4+IGRpZmYgLS1naXQgYS9pbmNs
dWRlL3hlbi94ZW4tb3BzLmggYi9pbmNsdWRlL3hlbi94ZW4tb3BzLmgNCj4+IGluZGV4IGEzNGY0
MjcxYTJlOS4uNDdmMTFiZWM1ZTkwIDEwMDY0NA0KPj4gLS0tIGEvaW5jbHVkZS94ZW4veGVuLW9w
cy5oDQo+PiArKysgYi9pbmNsdWRlL3hlbi94ZW4tb3BzLmgNCj4+IEBAIC0yMTYsMjYgKzIxNiwx
MCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgDQo+PiB4ZW5fcHJlZW1wdGlibGVfaGNhbGxfZW5kKHZv
aWQpIHsgfQ0KPj4gwqAgI2VuZGlmIC8qIENPTkZJR19YRU5fUFYgJiYgIUNPTkZJR19QUkVFTVBU
SU9OICovDQo+PiDCoCDCoCAjaWZkZWYgQ09ORklHX1hFTl9HUkFOVF9ETUFfT1BTDQo+PiAtdm9p
ZCB4ZW5fZ3JhbnRfc2V0dXBfZG1hX29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpOw0KPj4gLWJvb2wg
eGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KTsNCj4+IC1ib29sIHhl
bl92aXJ0aW9fbWVtX2FjYyhzdHJ1Y3QgdmlydGlvX2RldmljZSAqZGV2KTsNCj4+IMKgIGJvb2wg
eGVuX3ZpcnRpb19yZXN0cmljdGVkX21lbV9hY2Moc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldik7
DQo+PiDCoCAjZWxzZQ0KPj4gLXN0YXRpYyBpbmxpbmUgdm9pZCB4ZW5fZ3JhbnRfc2V0dXBfZG1h
X29wcyhzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+PiAtew0KPj4gLX0NCj4+IC1zdGF0aWMgaW5saW5l
IGJvb2wgeGVuX2lzX2dyYW50X2RtYV9kZXZpY2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KPj4gLXsN
Cj4+IC3CoMKgwqAgcmV0dXJuIGZhbHNlOw0KPj4gLX0NCj4+IC0NCj4+IMKgIHN0cnVjdCB2aXJ0
aW9fZGV2aWNlOw0KPj4gwqAgLXN0YXRpYyBpbmxpbmUgYm9vbCB4ZW5fdmlydGlvX21lbV9hY2Mo
c3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikNCj4+IC17DQo+PiAtwqDCoMKgIHJldHVybiBmYWxz
ZTsNCj4+IC19DQo+PiAtDQo+PiDCoCBzdGF0aWMgaW5saW5lIGJvb2wgeGVuX3ZpcnRpb19yZXN0
cmljdGVkX21lbV9hY2Moc3RydWN0IA0KPj4gdmlydGlvX2RldmljZSAqZGV2KQ0KPj4gwqAgew0K
Pj4gwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7DQo+DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5k
ciBUeXNoY2hlbmtvDQo=


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 19:48:48 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 19:48:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430144.681549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onPug-0006gL-Rf; Tue, 25 Oct 2022 19:48:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430144.681549; Tue, 25 Oct 2022 19:48:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onPug-0006gE-P6; Tue, 25 Oct 2022 19:48:38 +0000
Received: by outflank-mailman (input) for mailman id 430144;
 Tue, 25 Oct 2022 19:48:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onPuf-0006g8-LM
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 19:48:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onPuf-0002LX-8h; Tue, 25 Oct 2022 19:48:37 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onPuf-0005R2-1w; Tue, 25 Oct 2022 19:48:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HyKX2X5AbVI4lXeJdF7U76LdYRafzpFX7WSZnX6n7x0=; b=5Vh89y1j2+vWMOEug3u3yvO8Jt
	RS9jAt3A5oMuWfmaSERiOl6TsYuYX24aTqjEv2bDRTOv6PkmLGabS6iog/sutS7P+HpTpkuYw90gs
	uirPrJ9TMeAU8LWiVfBzVCESPAjrYynBEJ32YQv0nUmAXdRhaBB5dKDN0TA8kYw1YVNQ=;
Message-ID: <05c469e9-8d9a-76ac-016b-400b550dbb68@xen.org>
Date: Tue, 25 Oct 2022 20:48:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit
 guests
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, andre.przywara@arm.com,
 Henry Wang <Henry.Wang@arm.com>
References: <20221024193002.57888-1-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221024193002.57888-1-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

(+Henry)

Hi Ayan,

Adding Henry because this is something we probably want to fix in Xen 
4.17. AFAIU, the value is not used at all in Xen, so the risk is mostly 
returning a wrong value to a domain using GICv3 ITS (not officially 
supported and only expose to dom0 so far). Therefore, I would say this 
should be OK to ingest in Xen 4.17.

Anyway back to the review...

Title: Technically a 64-bit guest is equally affected because it is 
allowed to do 32-bit access. Furthermore, I would prefer if you prefix 
the title with "xen/arm" so it is clear which component you are 
touching. So I would suggest the following title:

xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER

Note that I appended a "v" to "GICv3" to make clear this is referring to 
the virtual GICv3 rather than host GICv3.

On 24/10/2022 20:30, Ayan Kumar Halder wrote:
> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 32bit register.

Not really, the result will be stored in a 64-bit register for AArch64 
host (even if for 32-bit guest). The main part is the top 32-bit of 
PENDBASER will be returned in the low 32-bit.

> 
> The 32bit register is then modified bitwise with a mask (ie GICR_PENDBASER_PTZ,
> it clears the 62nd bit) which is greater than 32 bits. This will give an
> incorrect result.

I would be explicit and say that "the bit PTZ will not be cleared as 
expected by the specification".

> 
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
> 
> Changes from:-
> 
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> appropriate commit message.
> 
>   xen/arch/arm/vgic-v3.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..7930ab6330 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -250,14 +250,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>       case VREG64(GICR_PENDBASER):
>       {
>           unsigned long flags;
> +        uint64_t val;
>   
>           if ( !v->domain->arch.vgic.has_its )
>               goto read_as_zero_64;
>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>   
>           spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> +        val = v->arch.vgic.rdist_pendbase;
> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> +        *r = vreg_reg64_extract(val, info);

As you store v->arch.vgic.rdist_pendbase, the lock can be reduced to the 
first assignment. IOW:

val = v->arch....;
spin_unlock_irq_restore();
val &= ~GIC_PENDBASER_PTZ;

That said, I think the lock could now be completely dropped in favor of 
using read_atomic() (and write_atomic()).

I am saying this even with in mind that, IIUC, R52 may not support 
64-bit atomics (see [1]). There are a few places in Xen that expect 
64-bit access to be atomic. For instance the IOREQ code is using 
guest_cmpxchg64() and a 32-build of Xen with the "case 8" commented 
write_atomic_size() will fail. So there are some rework necessary for R52.

I would also rather not want to keep a bigger hammer (i.e. the lock) for 
architecture that support 64-bit atomic access.

Cheers,

[1] 20221025145506.5708839c@donnerap.cambridge.arm.com

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 19:55:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 19:55:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430192.681582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQ1E-0000wI-2i; Tue, 25 Oct 2022 19:55:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430192.681582; Tue, 25 Oct 2022 19:55:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQ1E-0000wB-00; Tue, 25 Oct 2022 19:55:24 +0000
Received: by outflank-mailman (input) for mailman id 430192;
 Tue, 25 Oct 2022 19:55:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onQ1C-0000w1-Ca; Tue, 25 Oct 2022 19:55:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onQ1C-0002SJ-99; Tue, 25 Oct 2022 19:55:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onQ1B-0006o3-RW; Tue, 25 Oct 2022 19:55:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onQ1B-0002La-R0; Tue, 25 Oct 2022 19:55:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Fg9hD2Zu0VoGsZiT0mudLdk7axPA5vWzoq+1I4gUjaY=; b=cUWjtxXyd/D20ML9qxOfjbcw7O
	9HCqg5N7QvD3TChbMSJR23Y1sHV8QSmIXllNqQsft5mO3E5TXiHTj1l3A8fVfb+/ZLCT6iskVE33i
	By00BVxw7j1Voe/O3zWK/OteGiN16bWJhDiQSZU3NBblLwwoUJWroq0mHz1dj53ymFAw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174380-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174380: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=045072ee3ad0643254c8cb55bd47c878ddbee084
X-Osstest-Versions-That:
    libvirt=f1d63048b76bae8d9dd5c2f693a6df64c8117538
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 19:55:21 +0000

flight 174380 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174380/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174168
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174168
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174168
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              045072ee3ad0643254c8cb55bd47c878ddbee084
baseline version:
 libvirt              f1d63048b76bae8d9dd5c2f693a6df64c8117538

Last test of basis   174168  2022-10-21 03:40:58 Z    4 days
Testing same since   174380  2022-10-25 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eric van Blokland <mail@ericvanblokland.nl>
  Jiri Denemark <jdenemar@redhat.com>
  Ján Tomko <jtomko@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Peter Krempa <pkrempa@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   f1d63048b7..045072ee3a  045072ee3ad0643254c8cb55bd47c878ddbee084 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 20:06:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 20:06:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430206.681616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQBe-0002yd-CG; Tue, 25 Oct 2022 20:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430206.681616; Tue, 25 Oct 2022 20:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQBe-0002yW-8v; Tue, 25 Oct 2022 20:06:10 +0000
Received: by outflank-mailman (input) for mailman id 430206;
 Tue, 25 Oct 2022 20:06:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onQBc-0002yQ-UM
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 20:06:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onQBb-0002jl-Qg; Tue, 25 Oct 2022 20:06:07 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onQBb-0006Ph-KX; Tue, 25 Oct 2022 20:06:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=5sBGVx029vIAkKNQa85YA992R3kBkhdM8wBN1+kGVlQ=; b=MkKKKp+hs458lgoTNgl1F9DLXU
	Lu7sbMApBpiYxV8gPcAeujd6629fIpgbdeXjO9vnY7vjyxrUruhuQVPQ8XYkj4n62zzkKomqcccoq
	lLqtVaDmHeZ8cnxBG2MAB062jy905ypoX1oh3inPuXY4s7ZQH1v6QZRXgp1hg7E4pnrU=;
Message-ID: <9bec8877-25d2-8d50-6f03-523b806642b2@xen.org>
Date: Tue, 25 Oct 2022 21:06:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221025092112.50168-1-Henry.Wang@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221025092112.50168-1-Henry.Wang@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Henry,

On 25/10/2022 10:21, Henry Wang wrote:
> This series is a backported series for XSA-409 fixes from master for
> 4.14 to 4.16, which cherry-picking commits:
> 3783e583319f arm/p2m: Rework p2m_init()
> c7cff1188802 xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()

I have merged the 2 patches in Xen 4.16, 4.15 and 4.14. I noticed that 
the "released-acked-by" tags were removed.

We usually keep the commit message as-is (including tags). But I vaguely 
remember that we may have stripped the "released-acked-by" tag in the 
past. So I left it alone.

Also, it looks like the tools I am using to download the patches (b4) 
decided to move the "cherry-picked ..." line before the tags. I am not 
entirely sure why... So I have modified the commit message to re-add the 
line where you initially added (this is the correct place!).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 20:07:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 20:07:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430210.681628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQDJ-0003Z0-N6; Tue, 25 Oct 2022 20:07:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430210.681628; Tue, 25 Oct 2022 20:07:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQDJ-0003Yt-KD; Tue, 25 Oct 2022 20:07:53 +0000
Received: by outflank-mailman (input) for mailman id 430210;
 Tue, 25 Oct 2022 20:07:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onQDI-0003Yn-Ux
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 20:07:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onQDI-0002mo-D8; Tue, 25 Oct 2022 20:07:52 +0000
Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.95.108.38])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onQDI-0006U1-7D; Tue, 25 Oct 2022 20:07:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=0ijPOy6X/gbE/lY+84pSyQFSNRQqZbof40ouXZYDmQc=; b=47M3qoYFlkxddit/SQvGi3mpGM
	3BuPIwdPKV6azm1ZtT8LB8lnMYrF4vchBUdeh9IFBla+ZomugeJMcZ6/KsJ5YOq6rIeBjecjw4yYK
	Je2AjvoziceOP1eHT2MjA2UkCLnN0+V6VpfDypXD/HLMFQESHh0rWFp4uFq5FbpIjrQg=;
Message-ID: <567ef77a-58ed-c63b-11f4-f1eed0c7fb5e@xen.org>
Date: Tue, 25 Oct 2022 21:07:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC v2 01/12] xen/arm: Clean-up the memory layout
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: marco.solieri@minervasys.tech, lucmiccio@gmail.com,
 carlo.nonato@minervasys.tech, Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221022150422.17707-1-julien@xen.org>
 <20221022150422.17707-2-julien@xen.org>
 <c5767718-bb00-da6b-8623-1bcb6c832f85@amd.com>
 <dffca6a6-3a7c-a8ea-b61e-a37011a7afb8@xen.org>
 <906f4f04-4c06-8e93-1c4f-90be7d508f44@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <906f4f04-4c06-8e93-1c4f-90be7d508f44@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 25/10/2022 11:36, Michal Orzel wrote:
> Hi,
> 
> On 25/10/2022 12:31, Julien Grall wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> On 25/10/2022 10:21, Michal Orzel wrote:
>>> Hi Julien,
>>
>> Hi Michal,
>>
>>
>>> On 22/10/2022 17:04, Julien Grall wrote:
>>>>
>>>>
>>>> From: Julien Grall <jgrall@amazon.com>
>>>>
>>>> In a follow-up patch, the base address for the common mappings will
>>>> vary between arm32 and arm64. To avoid any duplication, define
>>>> every mapping in the common region from the previous one.
>>> Maybe the following title would be better suited if you only want to touch the common mappings?
>>> "xen/arm: Clean-up the common memory layout"
>>
>> Ok.
>>
>>>
>>>>
>>>> Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
>>>> XEN_VIRT_*.
>>>>
>>>> Take the opportunity to add missing *_SIZE for some mappings.
>>> I think this sentence can be removed as the previous one already covers it.
>>
>> Yes. I will remove it.
>>
>>>
>>> Apart from that, wouldn't it be useful to do the cleanup for the arm32 macros
>>> as you are here (FRAMETABLE, VMAP, {XEN/DOM}HEAP) ?
>>
>> Can you clarify? I looked at the macros and they look clean to me.
>>
> As you choose to make use of MB() macro, I think it would be beneficial
> just from the consistency perspective to modify other places that use directly hex values.
> We already do that for arm64 specific mappings, you are modifying the common ones
> to adhere to this way, so as a natural consequence I would see the arm32 ones to be modified as well.

You have a point. I will look to do it in this patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 20:08:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 20:08:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430214.681638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQEA-00045x-01; Tue, 25 Oct 2022 20:08:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430214.681638; Tue, 25 Oct 2022 20:08:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onQE9-00045q-Sz; Tue, 25 Oct 2022 20:08:45 +0000
Received: by outflank-mailman (input) for mailman id 430214;
 Tue, 25 Oct 2022 20:08:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onQE8-00045U-Fy; Tue, 25 Oct 2022 20:08:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onQE8-0002nW-EK; Tue, 25 Oct 2022 20:08:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onQE7-0007YX-Vi; Tue, 25 Oct 2022 20:08:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onQE7-0002tR-VE; Tue, 25 Oct 2022 20:08:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iy1rtPTOCZNR9KBnm8T9JRn4AvwxUAtQHEtpIyqRq/4=; b=BmJ8eRl2DzBmbkAiK0qNmhgLsP
	NmKuZl2U5beDyVD95Sy+pjrkJTNFZqZcWAdxP+V/Y9xxW9kQVMWkNrqyAXepRaibJUv487h8mhqRn
	QFiYZl4yRzsOka1FLRG+B/0Y/ZvFGCTMhe7TxrmfAxEeeGaR4A2koCvoPX8+Di8yMFFY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174368-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174368: regressions - FAIL
X-Osstest-Failures:
    xen-4.15-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.15-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-livepatch:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.15-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.15-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.15-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.15-testing:build-armhf-libvirt:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=816580afdd1730d4f85f64477a242a439af1cdf8
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 20:08:43 +0000

flight 174368 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174368/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172547
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172547
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172547
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172547
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172547
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172547

Tests which are failing intermittently (not blocking):
 test-amd64-i386-freebsd10-i386  7 xen-install    fail in 173987 pass in 174368
 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 174063 pass in 174368
 test-amd64-i386-xl-xsm        7 xen-install      fail in 174063 pass in 174368
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 174063 pass in 174368
 test-amd64-i386-livepatch     7 xen-install      fail in 174302 pass in 174368
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174302 pass in 174368
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173987
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173987
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 174063
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 174063
 test-amd64-i386-qemuu-rhel6hvm-amd  7 xen-install          fail pass in 174302
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 174302

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd      12 debian-di-install       fail blocked in 172547
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173987 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173987 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 174063 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 174063 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          starved in 174063 n/a
 build-armhf-libvirt           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl           1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           starved in 174063 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         starved in 174063 n/a
 build-armhf                   2 hosts-allocate           starved in 174063 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           starved in 174302 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         starved in 174302 n/a
 test-armhf-armhf-libvirt      1 build-check(1)           starved in 174302 n/a
 build-armhf-libvirt           2 hosts-allocate           starved in 174302 n/a

version targeted for testing:
 xen                  816580afdd1730d4f85f64477a242a439af1cdf8
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   71 days
Failing since        173494  2022-10-11 13:38:08 Z   14 days   16 attempts
Testing same since   173610  2022-10-12 17:10:45 Z   13 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 715 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 22:59:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 22:59:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430243.681688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onStA-00073p-I6; Tue, 25 Oct 2022 22:59:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430243.681688; Tue, 25 Oct 2022 22:59:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onStA-00073i-EH; Tue, 25 Oct 2022 22:59:16 +0000
Received: by outflank-mailman (input) for mailman id 430243;
 Tue, 25 Oct 2022 22:59:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onSt8-00073c-On
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 22:59:14 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4836d37-54b8-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 00:59:13 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5B931B81F83;
 Tue, 25 Oct 2022 22:59:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D3DBC433D6;
 Tue, 25 Oct 2022 22:59:10 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4836d37-54b8-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666738751;
	bh=9+KGN8zzncCSWU6QUT4wouOLxqWKGwJ/QsaEoWoIeic=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EwfbUR19cSYcW7isJiAfEScjG3rKAl18qLGhBTXTnYKL9J2/sPT/RfqF+tJb4cZ1C
	 b9qO4fIt4T8KjaDCPGLSoPDYPx5xpGezUsPp2Bkwx+CyHQluSblsVckZbPghe9+yDO
	 gjKOmBHr+IvzCGOD5HT0C1nn4CUfUDfQgIDUbu6sMuBAuDLa3eKbMRLLJenp1s7RK2
	 s5+R5slmapy7v4LHJqC60H3RBoK+j7QMHCEguEXzHToXGjmB7XeC69HO/9+SQE78M2
	 JNUF/eEjz4LB5t/bmmPwvLQ6BkSKxqiSgIPZ4N4cZLQa2dWlrZ1Ol61QOQuSRtwMfD
	 ThywQH8zYQQwg==
Date: Tue, 25 Oct 2022 15:59:08 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Michal Orzel <michal.orzel@amd.com>
cc: xen-devel@lists.xenproject.org, Doug Goldstein <cardoe@cardoe.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v2] automation: test.yaml: Introduce templates to reduce
 the overhead
In-Reply-To: <20221025095952.21980-1-michal.orzel@amd.com>
Message-ID: <alpine.DEB.2.22.394.2210251547250.1397955@ubuntu-linux-20-04-desktop>
References: <20221025095952.21980-1-michal.orzel@amd.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 25 Oct 2022, Michal Orzel wrote:
> At the moment, we define lots of test jobs in test.yaml, that make use
> of the same configuration sections like variables, tags, artifacts.
> Introduce templates (hidden jobs whose names start with a dot) to
> reduce the overhead and simplify the file (more than 100 lines saved).
> This way, the actual jobs can only specify sections that are unique
> to them.
> 
> Most of the test jobs specify the same set of prerequisite jobs under
> needs property with just one additional being unique to the job itself.
> Introduce YAML anchors for that purpose, because when using extends, the
> needs property is not being merged (the parent property overwrites the
> child one).
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v2:
>  - carve out anchors from extend jobs and use better naming
> 
> This patch is based on the CI next branch where we already have several
> patches (already acked) to be merged into staging after the release:
> https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next
> ---
>  automation/gitlab-ci/test.yaml | 270 ++++++++++-----------------------
>  1 file changed, 83 insertions(+), 187 deletions(-)
> 
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 92e0a1f7c510..c7e0078e04f1 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -7,35 +7,32 @@
>      - /^coverity-tested\/.*/
>      - /^stable-.*/
>  
> -# Test jobs
> -build-each-commit-gcc:
> +.arm64-test-needs: &arm64-test-needs
> +  - alpine-3.12-arm64-rootfs-export
> +  - kernel-5.19-arm64-export
> +  - qemu-system-aarch64-6.0.0-arm64-export
> +
> +.arm32-test-needs: &arm32-test-needs
> +  - qemu-system-aarch64-6.0.0-arm32-export
> +
> +.qemu-arm64:
>    extends: .test-jobs-common
>    variables:
> -    CONTAINER: debian:stretch
> -    XEN_TARGET_ARCH: x86_64
> -    CC: gcc
> -  script:
> -    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
> -    - mv ../build-each-commit-gcc.log .
> +    CONTAINER: debian:unstable-arm64v8
> +    LOGFILE: qemu-smoke-arm64.log
>    artifacts:
>      paths:
> +      - smoke.serial
>        - '*.log'
>      when: always
> -  needs: []
>    tags:
> -    - x86_64
> +    - arm64
>  
> -qemu-smoke-dom0-arm64-gcc:
> +.qemu-arm32:
>    extends: .test-jobs-common
>    variables:
>      CONTAINER: debian:unstable-arm64v8
> -  script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> -  needs:
> -    - alpine-3.12-gcc-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> +    LOGFILE: qemu-smoke-arm32.log
>    artifacts:
>      paths:
>        - smoke.serial
> @@ -44,251 +41,150 @@ qemu-smoke-dom0-arm64-gcc:
>    tags:
>      - arm64
>  
> -qemu-smoke-dom0-arm64-gcc-debug:
> +.qemu-x86-64:
>    extends: .test-jobs-common
>    variables:
> -    CONTAINER: debian:unstable-arm64v8
> -  script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> -  needs:
> -    - alpine-3.12-gcc-debug-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> +    CONTAINER: debian:stretch
> +    LOGFILE: qemu-smoke-x86-64.log
>    artifacts:
>      paths:
>        - smoke.serial
>        - '*.log'
>      when: always
>    tags:
> -    - arm64
> +    - x86_64
>  
> -qemu-alpine-x86_64-gcc:
> +# Test jobs
> +build-each-commit-gcc:
>    extends: .test-jobs-common
>    variables:
>      CONTAINER: debian:stretch
> +    XEN_TARGET_ARCH: x86_64
> +    CC: gcc
>    script:
> -    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-x86_64.log
> -  needs:
> -    - alpine-3.12-gcc
> -    - alpine-3.12-rootfs-export
> -    - kernel-5.10.74-export
> +    - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}} TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ../build-each-commit-gcc.log
> +    - mv ../build-each-commit-gcc.log .
>    artifacts:
>      paths:
> -      - smoke.serial
>        - '*.log'
>      when: always
> +  needs: []
>    tags:
>      - x86_64
>  
> +qemu-smoke-dom0-arm64-gcc:
> +  extends: .qemu-arm64
> +  script:
> +    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - *arm64-test-needs
> +    - alpine-3.12-gcc-arm64
> +
> +qemu-smoke-dom0-arm64-gcc-debug:
> +  extends: .qemu-arm64
> +  script:
> +    - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - *arm64-test-needs
> +    - alpine-3.12-gcc-debug-arm64
> +
>  qemu-smoke-dom0less-arm64-gcc:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm64-test-needs
>      - alpine-3.12-gcc-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-debug:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm64-test-needs
>      - alpine-3.12-gcc-debug-arm64
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-staticmem:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm64-test-needs
>      - alpine-3.12-gcc-arm64-staticmem
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-debug-staticmem:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm64-test-needs
>      - alpine-3.12-gcc-debug-arm64-staticmem
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-boot-cpupools:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm64-test-needs
>      - alpine-3.12-gcc-arm64-boot-cpupools
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm64
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee qemu-smoke-arm64.log
> +    - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm64-test-needs
>      - alpine-3.12-gcc-debug-arm64-boot-cpupools
> -    - alpine-3.12-arm64-rootfs-export
> -    - kernel-5.19-arm64-export
> -    - qemu-system-aarch64-6.0.0-arm64-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0-arm32-gcc:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm32
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
> +    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm32-test-needs
>      - debian-unstable-gcc-arm32
> -    - qemu-system-aarch64-6.0.0-arm32-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
>  
>  qemu-smoke-dom0-arm32-gcc-debug:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:unstable-arm64v8
> +  extends: .qemu-arm32
>    script:
> -    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee qemu-smoke-arm32.log
> +    - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE}
>    needs:
> +    - *arm32-test-needs
>      - debian-unstable-gcc-arm32-debug
> -    - qemu-system-aarch64-6.0.0-arm32-export
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> -  tags:
> -    - arm64
> +
> +qemu-alpine-x86_64-gcc:
> +  extends: .qemu-x86-64
> +  script:
> +    - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee ${LOGFILE}
> +  needs:
> +    - alpine-3.12-gcc
> +    - alpine-3.12-rootfs-export
> +    - kernel-5.10.74-export
>  
>  qemu-smoke-x86-64-gcc:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-stretch-gcc-debug
> -  tags:
> -    - x86_64
>  
>  qemu-smoke-x86-64-clang:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pv 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-unstable-clang-debug
> -  tags:
> -    - x86_64
>  
>  qemu-smoke-x86-64-gcc-pvh:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-stretch-gcc-debug
> -  tags:
> -    - x86_64
>  
>  qemu-smoke-x86-64-clang-pvh:
> -  extends: .test-jobs-common
> -  variables:
> -    CONTAINER: debian:stretch
> +  extends: .qemu-x86-64
>    script:
> -    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee qemu-smoke-x86-64.log
> -  artifacts:
> -    paths:
> -      - smoke.serial
> -      - '*.log'
> -    when: always
> +    - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
>    needs:
>      - debian-unstable-clang-debug
> -  tags:
> -    - x86_64
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 23:13:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 23:13:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430250.681706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onT6a-0001J4-RW; Tue, 25 Oct 2022 23:13:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430250.681706; Tue, 25 Oct 2022 23:13:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onT6a-0001Ix-Op; Tue, 25 Oct 2022 23:13:08 +0000
Received: by outflank-mailman (input) for mailman id 430250;
 Tue, 25 Oct 2022 23:13:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onT6Z-0001Io-Fw
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 23:13:07 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94722705-54ba-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 01:13:06 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 67FB3B81F98;
 Tue, 25 Oct 2022 23:13:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0924C433D6;
 Tue, 25 Oct 2022 23:13:01 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94722705-54ba-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666739583;
	bh=Qd6iE4RAuy5ZRVM7OcQwoPbhETc72fMXCkxUe0ZuCWQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=pdOhL9Z82OdmN1CvZPWmMlpejtz5j3ucXRzmSc5aD8YBFWeSsZtgeVLpkm5gX5RS4
	 LQeDoxvyikqrg8wqReVsXoUdUFuknMyzp4/EmkA9nADPQ86WvImGaitaUY4DM5SGfK
	 NBRX7bembHn4mM6ITrE2FwYAGGsvuopaOjpxicceRPV3qLqA5c0WmLhnUfXOqx6ygJ
	 iA3aXQAUdOVNU6r7XY7Yed1i+hl28TUFTlatl6LTaM05wFL9XZbdrpwMDq4mQ44/iU
	 O4bHe+Ctb0HU5yvwUC9WaMohyE8AowKombijSaMaFnfmQCnXEHz2K4mrOZo2ueL2/Q
	 zYw77Vvb89DgA==
Date: Tue, 25 Oct 2022 16:12:59 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    linux-arm-kernel@lists.infradead.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Catalin Marinas <catalin.marinas@arm.com>, 
    Russell King <linux@armlinux.org.uk>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V4 1/2] xen/virtio: Optimize the setup of "xen-grant-dma"
 devices
In-Reply-To: <20221025162004.8501-2-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210251612530.1397955@ubuntu-linux-20-04-desktop>
References: <20221025162004.8501-1-olekstysh@gmail.com> <20221025162004.8501-2-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 25 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This is needed to avoid having to parse the same device-tree
> several times for a given device.
> 
> For this to work we need to install the xen_virtio_restricted_mem_acc
> callback in Arm's xen_guest_init() which is same callback as x86's
> PV and HVM modes already use and remove the manual assignment in
> xen_setup_dma_ops(). Also we need to split the code to initialize
> backend_domid into a separate function.
> 
> Prior to current patch we parsed the device-tree three times:
> 1. xen_setup_dma_ops()->...->xen_is_dt_grant_dma_device()
> 2. xen_setup_dma_ops()->...->xen_dt_grant_init_backend_domid()
> 3. xen_virtio_mem_acc()->...->xen_is_dt_grant_dma_device()
> 
> With current patch we parse the device-tree only once in
> xen_virtio_restricted_mem_acc()->...->xen_dt_grant_init_backend_domid()
> 
> Other benefits are:
> - Not diverge from x86 when setting up Xen grant DMA ops
> - Drop several global functions
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> New patch
> ---
>  arch/arm/xen/enlighten.c    |  2 +-
>  drivers/xen/grant-dma-ops.c | 77 ++++++++++++++-----------------------
>  include/xen/arm/xen-ops.h   |  4 +-
>  include/xen/xen-ops.h       | 16 --------
>  4 files changed, 30 insertions(+), 69 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 93c8ccbf2982..7d59765aef22 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -445,7 +445,7 @@ static int __init xen_guest_init(void)
>  		return 0;
>  
>  	if (IS_ENABLED(CONFIG_XEN_VIRTIO))
> -		virtio_set_mem_acc_cb(xen_virtio_mem_acc);
> +		virtio_set_mem_acc_cb(xen_virtio_restricted_mem_acc);
>  
>  	if (!acpi_disabled)
>  		xen_acpi_guest_init();
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index daa525df7bdc..1e797a043980 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -292,50 +292,20 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> -static bool xen_is_dt_grant_dma_device(struct device *dev)
> -{
> -	struct device_node *iommu_np;
> -	bool has_iommu;
> -
> -	iommu_np = of_parse_phandle(dev->of_node, "iommus", 0);
> -	has_iommu = iommu_np &&
> -		    of_device_is_compatible(iommu_np, "xen,grant-dma");
> -	of_node_put(iommu_np);
> -
> -	return has_iommu;
> -}
> -
> -bool xen_is_grant_dma_device(struct device *dev)
> -{
> -	/* XXX Handle only DT devices for now */
> -	if (dev->of_node)
> -		return xen_is_dt_grant_dma_device(dev);
> -
> -	return false;
> -}
> -
> -bool xen_virtio_mem_acc(struct virtio_device *dev)
> -{
> -	if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain())
> -		return true;
> -
> -	return xen_is_grant_dma_device(dev->dev.parent);
> -}
> -
>  static int xen_dt_grant_init_backend_domid(struct device *dev,
> -					   struct xen_grant_dma_data *data)
> +					   domid_t *backend_domid)
>  {
>  	struct of_phandle_args iommu_spec;
>  
>  	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
>  			0, &iommu_spec)) {
> -		dev_err(dev, "Cannot parse iommus property\n");
> +		dev_dbg(dev, "Cannot parse iommus property\n");
>  		return -ESRCH;
>  	}
>  
>  	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
>  			iommu_spec.args_count != 1) {
> -		dev_err(dev, "Incompatible IOMMU node\n");
> +		dev_dbg(dev, "Incompatible IOMMU node\n");
>  		of_node_put(iommu_spec.np);
>  		return -ESRCH;
>  	}
> @@ -346,12 +316,28 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>  	 * The endpoint ID here means the ID of the domain where the
>  	 * corresponding backend is running
>  	 */
> -	data->backend_domid = iommu_spec.args[0];
> +	*backend_domid = iommu_spec.args[0];
>  
>  	return 0;
>  }
>  
> -void xen_grant_setup_dma_ops(struct device *dev)
> +static int xen_grant_init_backend_domid(struct device *dev,
> +					domid_t *backend_domid)
> +{
> +	int ret = -ENODEV;
> +
> +	if (dev->of_node) {
> +		ret = xen_dt_grant_init_backend_domid(dev, backend_domid);
> +	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain()) {
> +		dev_info(dev, "Using dom0 as backend\n");
> +		*backend_domid = 0;
> +		ret = 0;
> +	}
> +
> +	return ret;
> +}
> +
> +static void xen_grant_setup_dma_ops(struct device *dev, domid_t backend_domid)
>  {
>  	struct xen_grant_dma_data *data;
>  
> @@ -365,16 +351,7 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  	if (!data)
>  		goto err;
>  
> -	if (dev->of_node) {
> -		if (xen_dt_grant_init_backend_domid(dev, data))
> -			goto err;
> -	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT)) {
> -		dev_info(dev, "Using dom0 as backend\n");
> -		data->backend_domid = 0;
> -	} else {
> -		/* XXX ACPI device unsupported for now */
> -		goto err;
> -	}
> +	data->backend_domid = backend_domid;
>  
>  	if (store_xen_grant_dma_data(dev, data)) {
>  		dev_err(dev, "Cannot store Xen grant DMA data\n");
> @@ -392,12 +369,14 @@ void xen_grant_setup_dma_ops(struct device *dev)
>  
>  bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
>  {
> -	bool ret = xen_virtio_mem_acc(dev);
> +	domid_t backend_domid;
>  
> -	if (ret)
> -		xen_grant_setup_dma_ops(dev->dev.parent);
> +	if (!xen_grant_init_backend_domid(dev->dev.parent, &backend_domid)) {
> +		xen_grant_setup_dma_ops(dev->dev.parent, backend_domid);
> +		return true;
> +	}
>  
> -	return ret;
> +	return false;
>  }
>  
>  MODULE_DESCRIPTION("Xen grant DMA-mapping layer");
> diff --git a/include/xen/arm/xen-ops.h b/include/xen/arm/xen-ops.h
> index b0766a660338..70073f5a2b54 100644
> --- a/include/xen/arm/xen-ops.h
> +++ b/include/xen/arm/xen-ops.h
> @@ -8,9 +8,7 @@
>  static inline void xen_setup_dma_ops(struct device *dev)
>  {
>  #ifdef CONFIG_XEN
> -	if (xen_is_grant_dma_device(dev))
> -		xen_grant_setup_dma_ops(dev);
> -	else if (xen_swiotlb_detect())
> +	if (xen_swiotlb_detect())
>  		dev->dma_ops = &xen_swiotlb_dma_ops;
>  #endif
>  }
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index a34f4271a2e9..47f11bec5e90 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -216,26 +216,10 @@ static inline void xen_preemptible_hcall_end(void) { }
>  #endif /* CONFIG_XEN_PV && !CONFIG_PREEMPTION */
>  
>  #ifdef CONFIG_XEN_GRANT_DMA_OPS
> -void xen_grant_setup_dma_ops(struct device *dev);
> -bool xen_is_grant_dma_device(struct device *dev);
> -bool xen_virtio_mem_acc(struct virtio_device *dev);
>  bool xen_virtio_restricted_mem_acc(struct virtio_device *dev);
>  #else
> -static inline void xen_grant_setup_dma_ops(struct device *dev)
> -{
> -}
> -static inline bool xen_is_grant_dma_device(struct device *dev)
> -{
> -	return false;
> -}
> -
>  struct virtio_device;
>  
> -static inline bool xen_virtio_mem_acc(struct virtio_device *dev)
> -{
> -	return false;
> -}
> -
>  static inline bool xen_virtio_restricted_mem_acc(struct virtio_device *dev)
>  {
>  	return false;
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 23:14:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 23:14:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430254.681717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onT7p-0001qX-5H; Tue, 25 Oct 2022 23:14:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430254.681717; Tue, 25 Oct 2022 23:14:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onT7p-0001qP-2n; Tue, 25 Oct 2022 23:14:25 +0000
Received: by outflank-mailman (input) for mailman id 430254;
 Tue, 25 Oct 2022 23:14:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onT7o-0001qF-1p
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 23:14:24 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c24327b4-54ba-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 01:14:22 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 5F60061BF8;
 Tue, 25 Oct 2022 23:14:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEA0FC433C1;
 Tue, 25 Oct 2022 23:14:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c24327b4-54ba-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666739660;
	bh=MzpMrjWsH19E0r9kWq1TaDGhbd1xbuNvnFOB0rRZuG0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=tKirTCrkpCCd3YLx/m4i2cluGCr9cIfpNNUIUtlNsJ/DZNQjfoX454lPX3VSqBQ2p
	 zhdBBTCDI3Q/KNfgVzdKOcXyveQC0zAfn/yHE9NAStjzn9I32Wnc7r0HrWZTZU/gw9
	 s5NM24A32ZlFXUF1n5wbPgtTkHWYNV6saz+VHXhHEFIslvwIYGzQf3YRQlZSRkexc0
	 cnRFvzSqm/RaywfgWrwzuIJRuW1gPPW814LYsY4hj3Q/c3gTrLm2S5zQLuvH/NbnAM
	 acQ4G7Bu7ri3Vmx+Ka4TA9M/7IWQC7ZfyjOy4yqCejJjrl1zGDyVIY+UmbSTOvjB3c
	 obBl5/YTcTp6A==
Date: Tue, 25 Oct 2022 16:14:18 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Xenia Ragiadakou <burzalodowa@gmail.com>
Subject: Re: [PATCH V4 2/2] xen/virtio: Handle PCI devices which Host controller
 is described in DT
In-Reply-To: <20221025162004.8501-3-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210251614110.1397955@ubuntu-linux-20-04-desktop>
References: <20221025162004.8501-1-olekstysh@gmail.com> <20221025162004.8501-3-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 25 Oct 2022, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Use the same "xen-grant-dma" device concept for the PCI devices
> behind device-tree based PCI Host controller, but with one modification.
> Unlike for platform devices, we cannot use generic IOMMU bindings
> (iommus property), as we need to support more flexible configuration.
> The problem is that PCI devices under the single PCI Host controller
> may have the backends running in different Xen domains and thus have
> different endpoints ID (backend domains ID).
> 
> Add ability to deal with generic PCI-IOMMU bindings (iommu-map/
> iommu-map-mask properties) which allows us to describe relationship
> between PCI devices and backend domains ID properly.
> 
> To avoid having to look up for the PCI Host bridge twice and reduce
> the amount of checks pass an extra struct device_node *np to
> xen_dt_grant_init_backend_domid().
> 
> So with current patch the code expects iommus property for the platform
> devices and iommu-map/iommu-map-mask properties for PCI devices.
> 
> The example of generated by the toolstack iommu-map property
> for two PCI devices 0000:00:01.0 and 0000:00:02.0 whose
> backends are running in different Xen domains with IDs 1 and 2
> respectively:
> iommu-map = <0x08 0xfde9 0x01 0x08 0x10 0xfde9 0x02 0x08>;
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Slightly RFC. This is needed to support Xen grant mappings for virtio-pci devices
> on Arm at some point in the future. The Xen toolstack side is not completely ready yet.
> Here, for PCI devices we use more flexible way to pass backend domid to the guest
> than for platform devices.
> 
> Changes V1 -> V2:
>    - update commit description
>    - rebase
>    - rework to use generic PCI-IOMMU bindings instead of generic IOMMU bindings
> 
> Changes V2 -> V3:
>    - update commit description, add an example
>    - drop xen_dt_map_id() and squash xen_dt_get_pci_host_node() with
>      xen_dt_get_node()
>    - pass struct device_node *np to xen_is_dt_grant_dma_device() and
>      xen_dt_grant_init_backend_domid()
>    - pass domid_t *backend_domid instead of struct xen_grant_dma_data *data
>      to xen_dt_grant_init_backend_domid()
> 
> Changes V3 -> V4:
>    - just rebase on new prereq patch
>      "xen/virtio: Optimize the setup of "xen-grant-dma" devices"
> 
> Previous discussion is at:
> https://lore.kernel.org/xen-devel/20221006174804.2003029-1-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/20221015153409.918775-1-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/20221021172408.77397-1-olekstysh@gmail.com/
> 
> Based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git/log/?h=for-linus-6.1
> ---
> ---
>  drivers/xen/grant-dma-ops.c | 46 +++++++++++++++++++++++++++++++------
>  1 file changed, 39 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c
> index 1e797a043980..9784a77fa3c9 100644
> --- a/drivers/xen/grant-dma-ops.c
> +++ b/drivers/xen/grant-dma-ops.c
> @@ -10,6 +10,7 @@
>  #include <linux/module.h>
>  #include <linux/dma-map-ops.h>
>  #include <linux/of.h>
> +#include <linux/pci.h>
>  #include <linux/pfn.h>
>  #include <linux/xarray.h>
>  #include <linux/virtio_anchor.h>
> @@ -292,15 +293,43 @@ static const struct dma_map_ops xen_grant_dma_ops = {
>  	.dma_supported = xen_grant_dma_supported,
>  };
>  
> +static struct device_node *xen_dt_get_node(struct device *dev)
> +{
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		struct pci_bus *bus = pdev->bus;
> +
> +		/* Walk up to the root bus to look for PCI Host controller */
> +		while (!pci_is_root_bus(bus))
> +			bus = bus->parent;
> +
> +		return of_node_get(bus->bridge->parent->of_node);
> +	}
> +
> +	return of_node_get(dev->of_node);
> +}
> +
>  static int xen_dt_grant_init_backend_domid(struct device *dev,
> +					   struct device_node *np,
>  					   domid_t *backend_domid)
>  {
> -	struct of_phandle_args iommu_spec;
> +	struct of_phandle_args iommu_spec = { .args_count = 1 };
>  
> -	if (of_parse_phandle_with_args(dev->of_node, "iommus", "#iommu-cells",
> -			0, &iommu_spec)) {
> -		dev_dbg(dev, "Cannot parse iommus property\n");
> -		return -ESRCH;
> +	if (dev_is_pci(dev)) {
> +		struct pci_dev *pdev = to_pci_dev(dev);
> +		u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn);
> +
> +		if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_spec.np,
> +				iommu_spec.args)) {
> +			dev_dbg(dev, "Cannot translate ID\n");
> +			return -ESRCH;
> +		}
> +	} else {
> +		if (of_parse_phandle_with_args(np, "iommus", "#iommu-cells",
> +				0, &iommu_spec)) {
> +			dev_dbg(dev, "Cannot parse iommus property\n");
> +			return -ESRCH;
> +		}
>  	}
>  
>  	if (!of_device_is_compatible(iommu_spec.np, "xen,grant-dma") ||
> @@ -324,10 +353,13 @@ static int xen_dt_grant_init_backend_domid(struct device *dev,
>  static int xen_grant_init_backend_domid(struct device *dev,
>  					domid_t *backend_domid)
>  {
> +	struct device_node *np;
>  	int ret = -ENODEV;
>  
> -	if (dev->of_node) {
> -		ret = xen_dt_grant_init_backend_domid(dev, backend_domid);
> +	np = xen_dt_get_node(dev);
> +	if (np) {
> +		ret = xen_dt_grant_init_backend_domid(dev, np, backend_domid);
> +		of_node_put(np);
>  	} else if (IS_ENABLED(CONFIG_XEN_VIRTIO_FORCE_GRANT) || xen_pv_domain()) {
>  		dev_info(dev, "Using dom0 as backend\n");
>  		*backend_domid = 0;
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 23:25:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 23:25:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430259.681728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onTI0-0003cZ-9B; Tue, 25 Oct 2022 23:24:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430259.681728; Tue, 25 Oct 2022 23:24:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onTI0-0003cS-6D; Tue, 25 Oct 2022 23:24:56 +0000
Received: by outflank-mailman (input) for mailman id 430259;
 Tue, 25 Oct 2022 23:24:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onTHy-0003cM-7A
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 23:24:54 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a3f551b-54bc-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 01:24:52 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 551CFB81FB6;
 Tue, 25 Oct 2022 23:24:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6C49C433D6;
 Tue, 25 Oct 2022 23:24:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a3f551b-54bc-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666740290;
	bh=XKrymYmoOELPs01OO/UQUUQGqnqT3H/NVzD3tF0BGsI=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=tcaK0PZXe5g4NrpkXdH9l2NDD4AKXSW7sPsDLVRa9/mpb5MI+qkdZI2O8jdoMQ/yH
	 PfXvGZ6Z+JlFGYVQOsABboXBY1tDBMUuBYQnLPd9sA7aud7sZ4aqGAISBlrZSbaXKK
	 QYjFdWxHz6FAzIoByiLZaB/enRkUkB+OyuGV2693MhiPRIwoOv9Q89IQ/OzLfb9tSN
	 Zqfw93N5AEAZcp4+oQPEkmHb8hIPWlIGb/0CJMuv878UMzfPPtFe6Iy3/+DguO8vFX
	 Ny5ZZkt1EcNiHEnqwU94J2YtmFpd/8ZYQTRugB9O5q6y4vMSyXRwRIqIyTqN2/aazZ
	 SWMuifCaDmutQ==
Date: Tue, 25 Oct 2022 16:24:47 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <Luca.Fancellu@arm.com>
cc: Xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>
Subject: Re: [v2] Proposal for deviations in static analyser findings
In-Reply-To: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210251619090.1397955@ubuntu-linux-20-04-desktop>
References: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-355867395-1666739992=:1397955"
Content-ID: <alpine.DEB.2.22.394.2210251620370.1397955@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-355867395-1666739992=:1397955
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210251620371.1397955@ubuntu-linux-20-04-desktop>

On Tue, 25 Oct 2022, Luca Fancellu wrote:
> Hi all,
> 
> This is the V2 of the proposal for deviations tagging in the Xen codebase, this includes
> all the feedbacks from the FuSa session held at the Xen Summit 2022 and all the
> feedbacks received in the previous proposal sent on the mailing list.

It would be good to commit this proposal (when acked) as a pandoc under
xen.git/docs/misra


> Here a link to the previous thread: 
> https://lists.xenproject.org/archives/html/xen-devel/2022-10/msg00541.html
> 
> Documenting violations
> ======================
> 
> Static analysers are used on the Xen codebase for both static analysis and MISRA
> compliance.
> There might be the need to suppress some findings instead of fixing them and
> many tools permit the usage of in-code comments that suppress findings so that
> they are not shown in the final report.
> 
> Xen will include a tool capable of translating a specific comment used in its
> codebase to the right proprietary in-code comment understandable by the selected
> analyser that suppress its finding.
> 
> In the Xen codebase, these tags will be used to document and suppress findings:
> 
> - SAF-X-safe: This tag means that the next line of code contains a finding, but
>  the non compliance to the checker is analysed and demonstrated to be safe.
> - SAF-X-false-positive-<tool>: This tag means that the next line of code contains a
>  finding, but the finding is a bug of the tool.
> 
> SAF stands for Static Analyser Finding, the X is a placeholder for a positive
> number, the number after SAF- shall be incremental and unique, base ten
> notation and without leading zeros.
> 
> Entries in the database should never be removed, even if they are not used
> anymore in the code (if a patch is removing or modifying the faulty line).
> This is to make sure that numbers are not reused which could lead to conflicts
> with old branches or misleading justifications.
> 
> An entry can be reused in multiple places in the code to suppress a finding if
> and only if the justification holds for the same non-compliance to the coding
> standard.
> 
> An orphan entry, that is an entry who was justifying a finding in the code, but later
> that code was removed and there is no other use of that entry in the code, can be
> reused as long as the justification for the finding holds. This is done to avoid the
> allocation of a new entry with exactly the same justification, that would lead to waste
> of space and maintenance issues of the database.
> 
> The files where to store all the justifications are in xen/docs/misra/ and are
> named as safe.json and false-positive-<tool>.json, they have JSON format, entries
> of these files have independent ID numbering.
> 
> Here is an example to add a new justification in safe.json::
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |            "id":"SAF-0-safe",
> |            "analyser": {
> |                "cppcheck": "misra-c2012-20.7",
> |                "coverity": "misra_c_2012_rule_20_7_violation",
> |                "eclair": "MC3R1.R20.7"
> |            },
> |            "name": “R20.7 C macro parameters not used as expression",
> |            "text": "The macro parameters used in this […]"
> |        },
> |        {
> |            "id":”SAF-1-safe",
> |            "analyser": {
> |                "cppcheck": "unreadVariable",
> |                "coverity": "UNUSED_VALUE"
> |            },
> |            "name": “Variable set but not used",
> |            "text": “It is safe because […]"
> |        },
> |        {
> |            "id":”SAF-2-safe",
> |            "analyser": {},
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}
> 
> Here is an example to add a new justification in false-positive-cppcheck.json::
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |            "id":"SAF-0-false-positive-cppcheck",
> |            "analyser": {
> |                "cppcheck": "misra-c2012-20.7"
> |            },
> |            “tool-version”: “2.7",
> |            "name": “R20.7 second operand of member-access operator",
> |            "text": "The second operand of a member access operator shall be a name of a member of the type pointed to, so in this particular case it is wrong to use parentheses on the macro parameter."

Any way we can make the text max 80 chars in lengths (without breaking
the json parser)?

Also, if we are going to commit this document in xen.git, please use
consistently " instead of “


> |        },
> |        {
> |            "id":”SAF-1-false-positive-cppcheck",
> |            "analyser": {},
> |            “tool-version”: “",
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}
> 
> To document a finding, just add another block {[...]} before the sentinel block,
> using the id contained in the sentinel block and increment by one the number
> contained in the id of the sentinel block.
> 
> Here a brief explanation of the field inside an object of the "content" array:
> - id: it is a unique string that is used to refer to the finding, many finding
>  can be tagged with the same id, if the justification holds for any applied
>  case.
>  It tells the tool to substitute a Xen in-code comment having this structure:
>  /* SAF-0-safe [...] \*/

No need for the final \

Everything else looks good to me.


> - analyser: it is an object containing pair of key-value strings, the key is
>  the analyser, so it can be cppcheck, coverity or eclair. The value is the
>  proprietary id corresponding on the finding, for example when coverity is
>  used as analyser, the tool will translate the Xen in-code coment in this way:
>  /* SAF-0-safe [...] \*/ -> /* coverity[coverity-id] \*/
>  if the object doesn't have a key-value, then the corresponding in-code
>  comment won't be translated.
> - name: a simple name for the finding
> - text: a proper justification to turn off the finding.
> 
> 
> 
> Here an example of the usage of the in-code comment tags to suppress a finding for the Rule 8.6:
> 
> Eclair reports it here:
> https://eclairit.com:3787/fs/var/lib/jenkins/jobs/XEN/configurations/axis-Target/ARM64/axis-agent/public/builds/549/archive/ECLAIR/out/PROJECT.ecd;/sources/xen/include/xen/kernel.h.html#R50743_1
> 
> Also coverity reports it, here an extract of the finding:
> 
> xen/include/xen/kernel.h:68:
>  1. misra_c_2012_rule_8_6_violation: Function "_start" is declared but never defined.
> 
> The analysers are complaining because we have this in xen/include/xen/kernel.h at line 68:
> 
> extern char _start[], _end[], start[];
> 
> Those are symbols exported by the linker, hence we will need to have a proper deviation for this finding.
> 
> We will prepare our entry in the database:
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |        […]
> |        },
> |        {
> |            "id":”SAF-1-safe",
> |            "analyser": {
> |                “eclair": "MC3R1.R8.6",
> |                "coverity": "misra_c_2012_rule_8_6_violation"
> |            },
> |            "name": “Rule 8.6: linker defined symbols",
> |            "text": “It is safe to declare this symbol because it is defined in the linker script."
> |        },
> |        {
> |            "id":”SAF-2-safe",
> |            "analyser": {},
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}
> 
> And we will use the proper tag above the violation line:
> 
> /* SAF-1-safe [optional text] */
> extern char _start[], _end[], start[];
> 
> This entry will fix also the violation on _end and start, because they are on the same line and the
> same “violation ID”.
> 
> Also, the same tag can be used on other symbols from the linker that are declared in the codebase,
> because the justification holds for them too.
--8323329-355867395-1666739992=:1397955--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 23:52:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 23:52:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430267.681752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onTiF-0007dY-I7; Tue, 25 Oct 2022 23:52:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430267.681752; Tue, 25 Oct 2022 23:52:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onTiF-0007dR-FA; Tue, 25 Oct 2022 23:52:03 +0000
Received: by outflank-mailman (input) for mailman id 430267;
 Tue, 25 Oct 2022 23:52:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onTiE-0007dE-Nt
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 23:52:02 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03e67ced-54c0-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 01:52:00 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 09B10CE1FF5;
 Tue, 25 Oct 2022 23:51:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 406F0C433C1;
 Tue, 25 Oct 2022 23:51:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03e67ced-54c0-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666741913;
	bh=P0WE4LD7Cj3BDjUxnJPoK7POqFTVkOMmDWIoujPP2FA=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Sy3fXZjDPvreEYlBuQLQXdC/LUaLEo8xLz6JRDZ45iOt9bIIlR8c0Ew9sH58MAsE4
	 xTSH7UYKiDnFP2tpl33mLmIziVEjFMpoDCV5NNUU4lgcxTa1CSA/NYJ9Ee4ljB8LZk
	 lDLcan28rV+gblL6VBnD5pfzPM5gxHHcC8ylirpkfUyvsvHzpBOUp+G4WQUKx+hnQd
	 hP7kU/6tx6CDV8GDFv0BFxuS8GNV/sHR/VWv9JUcxhB9TUENgS8Yd+vQTxRqGf4G8X
	 qJ0x3C+7PXIPqK0OevSkw2EX20ymhdk4VBUUFdeCqrQHpxwOx2izwqZk6uLrGt8ZZQ
	 hpANTdS0yZZng==
Date: Tue, 25 Oct 2022 16:51:50 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Vipul Suneja <vsuneja63@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, oleksandr_andrushchenko@epam.com, 
    oleksandr_tyshchenko@epam.com, jgross@suse.com, boris.ostrovsky@oracle.com, 
    Bertrand.Marquis@arm.com
Subject: Re: Porting Xen in raspberry pi4B
In-Reply-To: <CALAP8f9Zgue6WfAk2uRGkg=1Up2Z+eQWqvQ1_Z2=r66Z5fvKoA@mail.gmail.com>
Message-ID: <alpine.DEB.2.22.394.2210251641540.1397955@ubuntu-linux-20-04-desktop>
References: <CALAP8f--jyG=ufJ9WGtL6qoeGdsykjNK85G3q50SzJm5+wOzhQ@mail.gmail.com> <alpine.DEB.2.22.394.2210171400570.2351079@ubuntu-linux-20-04-desktop> <CALAP8f81ojfVD9n5EMtD7DxY-8uomgENVEQH9Afz7Hk9rfaAsw@mail.gmail.com> <alpine.DEB.2.22.394.2210181213370.4587@ubuntu-linux-20-04-desktop>
 <CALAP8f9Zgue6WfAk2uRGkg=1Up2Z+eQWqvQ1_Z2=r66Z5fvKoA@mail.gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-90070364-1666741912=:1397955"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-90070364-1666741912=:1397955
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

Hi Vipul,

If you look at the QEMU logs, it says:

VNC server running on 127.0.0.1:5900

That is the VNC server you need to connect to. So in theory:

  vncviewer 127.0.0.1:5900

should work correctly.


If you have:

  vfb = ["type=vnc"]

in your xl config file and you have "fbdev" in your Linux guest, it
should work.

If you connect to the VNC server but you get a black screen, it might be
a guest configuration issue. I would try with a simpler guest, text only
(no X11, no Wayland) and enable the fbdev console (fbcon). See
Documentation/fb/fbcon.rst in Linux. You should be able to see a
graphical console over VNC.

If that works, then you know that the fbdev kernel driver (xen-fbfront)
works correctly.

If it doesn't work, the output of "xenstore-ls" would be interesting.

Cheers,

Stefano


On Wed, 19 Oct 2022, Vipul Suneja wrote:
> Hi Stefano,
> 
> Thanks for the response!
> 
> I am following the same link you shared from the beginning. Tried the command "vncviewer localhost:0" in DOM0 but same issue "Can't open
> display", below are the logs:
> 
> root@raspberrypi4-64:~# vncviewer localhost:0
> 
> TigerVNC Viewer 64-bit v1.11.0
> Built on: 2020-09-08 12:16
> Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)
> See https://www.tigervnc.org for information on TigerVNC.
> Can't open display:
> 
> Below are the netstat logs, i couldn't see anything running at port 5900 or 5901:
> 
> root@raspberrypi4-64:~# netstat -tuwx
> Active Internet connections (w/o servers)
> Proto Recv-Q Send-Q Local Address           Foreign Address         State      
> tcp        0    164 192.168.1.39:ssh        192.168.1.38:37472      ESTABLISHED
> Active UNIX domain sockets (w/o servers)
> Proto RefCnt Flags       Type       State         I-Node Path
> unix  8      [ ]         DGRAM      CONNECTED      10565 /dev/log
> unix  3      [ ]         STREAM     CONNECTED      10891 /var/run/xenstored/socket
> unix  3      [ ]         STREAM     CONNECTED      13791
> unix  3      [ ]         STREAM     CONNECTED      10843 /var/run/xenstored/socket
> unix  3      [ ]         STREAM     CONNECTED      10573 /var/run/xenstored/socket
> unix  2      [ ]         DGRAM      CONNECTED      14510
> unix  3      [ ]         STREAM     CONNECTED      13249
> unix  2      [ ]         DGRAM      CONNECTED      13887
> unix  2      [ ]         DGRAM      CONNECTED      10599
> unix  3      [ ]         STREAM     CONNECTED      14005
> unix  3      [ ]         STREAM     CONNECTED      13258
> unix  3      [ ]         STREAM     CONNECTED      13248
> unix  3      [ ]         STREAM     CONNECTED      14003
> unix  3      [ ]         STREAM     CONNECTED      10572 /var/run/xenstored/socket
> unix  3      [ ]         STREAM     CONNECTED      10786 /var/run/xenstored/socket
> unix  3      [ ]         DGRAM      CONNECTED      13186
> unix  3      [ ]         STREAM     CONNECTED      10864 /var/run/xenstored/socket
> unix  3      [ ]         STREAM     CONNECTED      10812 /var/run/xenstored/socket
> unix  2      [ ]         DGRAM      CONNECTED      14083
> unix  3      [ ]         STREAM     CONNECTED      10813 /var/run/xenstored/socket
> unix  3      [ ]         STREAM     CONNECTED      14068
> unix  3      [ ]         STREAM     CONNECTED      13256
> unix  3      [ ]         STREAM     CONNECTED      10571 /var/run/xenstored/socket
> unix  3      [ ]         STREAM     CONNECTED      10842
> unix  3      [ ]         STREAM     CONNECTED      13985
> unix  3      [ ]         DGRAM      CONNECTED      13185
> unix  2      [ ]         STREAM     CONNECTED      13884
> unix  2      [ ]         DGRAM      CONNECTED      14528
> unix  2      [ ]         DGRAM      CONNECTED      13785
> unix  3      [ ]         STREAM     CONNECTED      14034
> 
> Attaching xen log files of /var/log/xen.
> I didn't get the role of QEMU here because as mentioned earlier, I am porting in raspberrypi 4B.
> 
> Regards,
> Vipul Kumar
> 
> On Wed, Oct 19, 2022 at 12:43 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       It usually works the way it is described in the guide:
> 
>       https://www.virtuatopia.com/index.php?title=Configuring_a_VNC_based_Graphical_Console_for_a_Xen_Paravirtualized_domainU_Guest
> 
>       You don't need to install any VNC-related server software because it is
>       already provided by Xen (to be precise it is provided by QEMU working
>       together with Xen.)
> 
>       You only need the vnc client in dom0 so that you can connect, but you
>       could also run the vnc client outside from another host. So basically
>       the following should work when executed in Dom0 after creating DomU:
> 
>         vncviewer localhost:0
> 
>       Can you attach the Xen and QEMU logs (/var/log/xen/*)? And also use
>       netstat -taunp to check if there is anything running at port 5900 or
>       5901?
> 
>       Cheers,
> 
>       Stefano
> 
> 
>       On Tue, 18 Oct 2022, Vipul Suneja wrote:
>       > Hi Stefano,
>       >
>       > Thanks for the response!
>       >
>       > I could install tigerVNC, x11vnc & libvncserver in Dom0 xen-image-minimal but only manage to install libvncserver(couldn't
>       install tigervnc
>       > & x11vnc because of x11
>       > support missing, it's wayland) in DOMU custom graphical image. I tried running vncviewer with IP address & port in dom0 to
>       access the domu
>       > graphical image display as per below commands.
>       >  
>       >  vncviewer 192.168.1.42:5901
>       >  
>       >  But it showing can't open display, below are the logs:
>       >  
>       > root@raspberrypi4-64:~/guest1# vncviewer 192.168.1.42:5901
>       >
>       > TigerVNC Viewer 64-bit v1.11.0
>       > Built on: 2020-09-08 12:16
>       > Copyright (C) 1999-2020 TigerVNC Team and many others (see README.rst)
>       > See https://www.tigervnc.org for information on TigerVNC.
>       > Can't open display:
>       > root@raspberrypi4-64:~/guest1#
>       >
>       > I am not exactly sure what the issue is but I thought only libvncserver in DOMU could work to get access but it did not
>       work. 
>       > If TigerVNC is the issue here then is there any other VNC source which could be installed for both x11 & wayland supported
>       images?
>       >
>       > Regards,
>       > Vipul Kumar
>       >
>       > On Tue, Oct 18, 2022 at 2:40 AM Stefano Stabellini <sstabellini@kernel.org> wrote:
>       >       VNC is typically easier to setup, because SDL needs extra libraries at
>       >       build time and runtime. If QEMU is built without SDL support it won't
>       >       start when you ask for SDL.
>       >
>       >       VNC should work with both x11 and wayland in your domU. It doesn't work
>       >       at the x11 level, it exposes a special fbdev device in your domU that
>       >       should work with:
>       >       - a graphical console in Linux domU
>       >       - x11
>       >       - wayland (but I haven't tested this so I am not 100% sure about it)
>       >
>       >       When you say "it doesn't work", what do you mean? Do you get a black
>       >       window?
>       >
>       >       You need CONFIG_XEN_FBDEV_FRONTEND in Linux domU
>       >       (drivers/video/fbdev/xen-fbfront.c). I would try to get a graphical text
>       >       console up and running in your domU before attempting x11/wayland.
>       >
>       >       Cheers,
>       >
>       >       Stefano
>       >
>       >       On Mon, 17 Oct 2022, Vipul Suneja wrote:
>       >       > Hi,
>       >       > Thanks!
>       >       >
>       >       > I have ported xen minimal image as DOM0 & custom wayland GUI based image as DOMU in raspberry pi4B. I am trying to
>       make GUI
>       >       display up
>       >       > for guest machine. I tried using sdl, included below line in guest.conf file
>       >       > vfb= [ 'sdl=1' ]
>       >       >
>       >       > But it is throwing below error:
>       >       >
>       >       > root@raspberrypi4-64:~/guest1# xl create -c guest1.cfg
>       >       > Parsing config from guest1.cfg
>       >       > libxl: error: libxl_qmp.c:1400:qmp_ev_fd_callback: Domain 3:error on QMP socket: Connection reset by peer
>       >       > libxl: error: libxl_qmp.c:1439:qmp_ev_fd_callback: Domain 3:Error happened with the QMP connection to QEMU
>       >       > libxl: error: libxl_dm.c:3351:device_model_postconfig_done: Domain 3:Post DM startup configs failed, rc=-26
>       >       > libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 3:device model did not start: -26
>       >       > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model already exited
>       >       > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 3:Non-existant domain
>       >       > libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 3:Unable to destroy guest
>       >       > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 3:Destruction of domain failed
>       >       >
>       >       > Another way is VNC, i could install tigervnc in DOM0 but same i couldn't in guest machine because it doesn't support
>       >       x11(supports wayland
>       >       > only). I am completely blocked here, Need your support to enable the display up.
>       >       > Any alternative of VNC which could work in both x11 & wayland supported images?
>       >       >
>       >       > Any input on VNC, SDL or any other way to proceed on this? Looking forward to hearing from you.
>       >       >
>       >       > Regards,
>       >       > Vipul Kumar
>       >
>       >
>       >
> 
> 
> 
--8323329-90070364-1666741912=:1397955--


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 23:58:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 23:58:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430271.681763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onTo3-0008TL-7N; Tue, 25 Oct 2022 23:58:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430271.681763; Tue, 25 Oct 2022 23:58:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onTo3-0008TE-4G; Tue, 25 Oct 2022 23:58:03 +0000
Received: by outflank-mailman (input) for mailman id 430271;
 Tue, 25 Oct 2022 23:58:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onTo2-0008T4-Ha; Tue, 25 Oct 2022 23:58:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onTo2-0006Xl-Di; Tue, 25 Oct 2022 23:58:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onTo2-0004T2-1i; Tue, 25 Oct 2022 23:58:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onTo2-0002yl-1G; Tue, 25 Oct 2022 23:58:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wXg/42mEeLYeuY6fe5Y1aeDpqH/efs5Y9qm7Z1tLdcQ=; b=WQ+M6olEo8HJ9pn4tTDs51dYBi
	7LjNFzdtUsO3jk8ixzDaoCy5aOMhNHRv070AgvRpUE02jtQzxFuTv8/ihVhFvQsXFMMbtFKZbLSJW
	TNZ1QwU3JEx4nBPzKAGYQVkzQI6VtvD0+0OlZf0DinRqHbri2qpCCqw7vZrs21n2qh6c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174412-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174412: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=56035d1c8b255b33b34cd4625c26bc7d38504e30
X-Osstest-Versions-That:
    ovmf=db2c22633f3c761975d8f469a0e195d8b79e1287
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 25 Oct 2022 23:58:02 +0000

flight 174412 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174412/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 56035d1c8b255b33b34cd4625c26bc7d38504e30
baseline version:
 ovmf                 db2c22633f3c761975d8f469a0e195d8b79e1287

Last test of basis   174393  2022-10-25 08:22:32 Z    0 days
Testing same since   174412  2022-10-25 17:42:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Oliver Steffen <osteffen@redhat.com>
  Rebecca Cran <rebecca@quicinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   db2c22633f..56035d1c8b  56035d1c8b255b33b34cd4625c26bc7d38504e30 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Oct 25 23:58:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 25 Oct 2022 23:58:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430276.681773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onToP-0000Ts-HU; Tue, 25 Oct 2022 23:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430276.681773; Tue, 25 Oct 2022 23:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onToP-0000T7-DX; Tue, 25 Oct 2022 23:58:25 +0000
Received: by outflank-mailman (input) for mailman id 430276;
 Tue, 25 Oct 2022 23:58:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qfDD=22=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onToO-0000Pc-0N
 for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 23:58:24 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7f104c5-54c0-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 01:58:22 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4E6E8B81FC3;
 Tue, 25 Oct 2022 23:58:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78030C433D6;
 Tue, 25 Oct 2022 23:58:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7f104c5-54c0-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666742300;
	bh=MAEadm31jCSBRTzJcOHvB8vUgAooeOcKwmNO3sWKV+o=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=t4cByd73JFgTkgnlXjvf0NCDOUCkMZXC/AtZat8Jt7nwImkkBBk6J3vQ4PRIzAe/Q
	 Z9lLoGricFrsNmMEik9YsVFIPVe9TuFOr7fOMGIKPH5AS93cIYAyBY8ta2IOH9Yn8Y
	 g2rsvUloZpF2VVb+dndZ/KWf0onzUOe1XT/m3Wc6znxIZ3TWrpxVqRvH46Fw8X14Yl
	 OiOLEOR2zHS33f0O9rrOOIjl7o109+d3/78JD1QLW09JQAKiij6A2KLTb/9xYBQeeo
	 XE39fJ+MdHZRUxidLF/goFo05B2v29Lg4m4kHJd0/Gtkj0+dmP8hk19ZCWGnUGJ91W
	 FRT5CQUDNn1UQ==
Date: Tue, 25 Oct 2022 16:58:16 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Leo Yan <leo.yan@linaro.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Xen Develop <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    Mathieu Poirier <mathieu.poirier@linaro.org>, 
    Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>, 
    jgross@suse.com, oleksandr_tyshchenko@epam.com, boris.ostrovsky@oracle.com, 
    wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
In-Reply-To: <Y1ZvDt7/I9JXJh2r@leoy-huanghe.lan>
Message-ID: <alpine.DEB.2.22.394.2210251655420.1397955@ubuntu-linux-20-04-desktop>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop> <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan> <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop> <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop> <Y1J39UsPlM8htxFx@leoy-huanghe.lan> <alpine.DEB.2.22.394.2210211341440.3873@ubuntu-linux-20-04-desktop> <Y1ZvDt7/I9JXJh2r@leoy-huanghe.lan>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 24 Oct 2022, Leo Yan wrote:
> > If you are really running with the NULL scheduler, then I would
> > investigate why the vCPU has is_running == 0 because it should not
> > happen.
> 
> Correct for this: it's my bad that I didn't really enable NULL scheduler
> in my code base.  After I enabled NULL scheduler, the latency by context
> switching is dismissed.
> 
>  8963              pub-338   [002]   217.777652: bprint:               xennet_tx_setup_grant: id=60 ref=1340 offset=2 len=1514 TSC: 7892178799
>  8964              pub-338   [002]   217.777662: bprint:               xennet_tx_setup_grant: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179043
>  8965     ksoftirqd/12-75    [012]   255.466914: bprint:               xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2 len=1514 TSC: 7892179731
>  8966     ksoftirqd/12-75    [012]   255.466915: bprint:               xenvif_tx_build_gops.constprop.0: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179761
>  8967              pub-338   [002]   217.778057: bprint:               xennet_tx_setup_grant: id=60 ref=1340 offset=2050 len=1514 TSC: 7892188930
>  8968              pub-338   [002]   217.778072: bprint:               xennet_tx_setup_grant: id=53 ref=1333 offset=2 len=1514 TSC: 7892189293
>  8969       containerd-2965  [012]   255.467304: bprint:               xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2050 len=1514 TSC: 7892189479
>  8970       containerd-2965  [012]   255.467306: bprint:               xenvif_tx_build_gops.constprop.0: id=53 ref=1333 offset=2 len=1514 TSC: 7892189533

I am having difficulty following the messages. Are the two points [a]
and [b] as described in the previous email shown here?


> So the xennet (Xen net forend driver) and xenvif (net backend driver)
> work in parallel.  Please note, I didn't see networking performance
> improvement after changed to use NULL scheduler.
> 
> Now I will compare the duration for two directions, one direction is
> sending data from xennet to xenvif, and another is the reversed
> direction.  It's very likely the two directions have significant
> difference for sending data with grant tables, you could see in above
> log, it takes 20~30us to transmit a data block (we can use the id
> number and grant table's ref number to match the data block in xennet
> driver and xenvif driver).
> 
> > Now regarding the results, I can see the timestamp 3842008681 for
> > xennet_notify_tx_irq, 3842008885 for vgic_inject_irq, and 3842008935 for
> > vcpu_kick. Where is the corresponding TSC for the domain receiving the
> > notification?
> > 
> > Also for the other case, starting at 3842016505, can you please
> > highlight the timestamp for vgic_inject_irq, vcpu_kick, and also the one
> > for the domain receiving the notification?
> > 
> > The most interesting timestamps would be the timestamp for vcpu_kick in
> > "notification sending domain" [a], the timestamp for receiving the
> > interrupt in the Xen on pCPU for the "notification receiving domain"
> > [b], and the timestamp for the "notification receiving domain" getting
> > the notification [c].
> > 
> > If really context switch is the issue, then the interesting latency
> > would be between [a] and [b].
> 
> Understand.  I agree that I didn't move into more details, the main
> reason is Xen dmesg buffer is fragile after adding more logs, e.g.
> after I added log in the function gicv3_send_sgi(), Xen will stuck
> during the booting phase, and after adding logs in
> leave_hypervisor_to_guest() it will introduce huge logs (so I need to
> only trace for first 16 CPUs to mitigate log flood).
> 
> I think it would be better to enable xentrace for my profiling at my
> side.  If I have any further data, will share back.

Looking forward to it. Without more details it is impossible to identify
the source of the problem and fix it.


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 00:25:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 00:25:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430282.681785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onUDt-0004xT-7j; Wed, 26 Oct 2022 00:24:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430282.681785; Wed, 26 Oct 2022 00:24:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onUDt-0004xM-4G; Wed, 26 Oct 2022 00:24:45 +0000
Received: by outflank-mailman (input) for mailman id 430282;
 Wed, 26 Oct 2022 00:24:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NsSF=23=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onUDq-0004xG-TQ
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 00:24:43 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2062.outbound.protection.outlook.com [40.107.20.62])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 94e5fd9f-54c4-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 02:24:41 +0200 (CEST)
Received: from AM5PR0502CA0008.eurprd05.prod.outlook.com
 (2603:10a6:203:91::18) by DB9PR08MB9539.eurprd08.prod.outlook.com
 (2603:10a6:10:453::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 00:24:38 +0000
Received: from AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:91:cafe::69) by AM5PR0502CA0008.outlook.office365.com
 (2603:10a6:203:91::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend
 Transport; Wed, 26 Oct 2022 00:24:38 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT060.mail.protection.outlook.com (100.127.140.216) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 00:24:37 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Wed, 26 Oct 2022 00:24:37 +0000
Received: from 0d971bca963c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BF40FD09-C22A-4E76-8F5F-D0FA4CE2B11B.1; 
 Wed, 26 Oct 2022 00:24:31 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0d971bca963c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 00:24:31 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB8458.eurprd08.prod.outlook.com (2603:10a6:10:3d6::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Wed, 26 Oct
 2022 00:24:29 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 00:24:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94e5fd9f-54c4-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=W3tIztXnsLTmyvWrVB7xq4nY2lHuOOOEOynywXxi3jP7L1/iGtrk+x/plwl21RDS5vWyH5NyY/O/UqjfzymH/WD3IGf0jyKQs0B7a6YYRL9w5+iZmv7YqKT7iUaPPb/Wa+8/J6vofwIqxyHM6EC2IO2TKIKdBmG7AgYAk+r1bfnBhoACllsR3X3AopwDX9bcnjPSM6F7cVUgQ/JT3ym+Ld/3HxMtHp2q472fNsVHbZRlKaQmXWPzUlUrgcTH2NVHciR0pOXyZ5nNLv+34B1WDULDnLFsvPsEYTbZyqNq/l7Tk6VMYHYV3HdOMAD7cOqfv6Ijv1vdq3ei+MAgYCjIWw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ohq/QidtMMhvuoQn3k1V0osZPXj/L17D20miE8Ha+MU=;
 b=HV9O1Ls5cJ7zX/cq6BnhpqtREdrIOLBzT0q8Gi+5vpN0MX/wWzSrRUGp437QOizwwlRUjoOhW/RfkJuRrj0RIFBM2INj9yOK7SlzNpdzj7N+SU+LYskUBTbWhI7/GggFRebds96YJ2t52RZWCyT7WkjEfmi62dIwf79eV4pixQh2vKHc4ONDnV4wQdbVVZcU40i3QspY8PEJ0d0fEx00Q7iiYc4zdrty6deu3fjzeoWb5/1I9svKua+w/ZF/5uMF9WLsjoUkVkU/LOBV1txv1XNQKrfoPuUeQGRI7Cx08aIr9+onLyO/z5TPOPwLBon025T8Zl1BQczUTTHu4X615g==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ohq/QidtMMhvuoQn3k1V0osZPXj/L17D20miE8Ha+MU=;
 b=cFaV5d32/+cROyl8XyWUqvwiGgiXoYxm6+AqFgm92pEpfkkXRbZHkvyMm1pMp/QQNQE1PfiWniI8lXJKMViLnvwj4lB0rFhxWLzDUlFfXEgasGqScezauCNsjtxniLA2fgzxoQxLeniYma+jkVlNFwzCpWp2XZlX69jtS/1GZAg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CdEH1xg2IOZjl+bTNWNo5dd5mFz31HSCx/nxBpNdvJKC4O7oUd2XCTf3MUPj2QvgDf0+E/QsCPU6Gagoty8Mdx8qMrrSC45BW8+gSpkvnIeuEL8s/MV+LOzYGm2ybCwmoymmxyAL8qiugXTYwy4opAVZxwGmLEbjHz2xJlVhrW3CMi6/htambyyjataBIx9ylhJoqfwcYmYwrtVTuwQmwhvPjGVX8PD8C5Po1Rz8JUOWdyA6hYgSgAlQg/CoVr5WqnVWYe5Zp7e/qY01+QFUYgWoVF5Zp/m1LBJhBlTsfPDT8nBtD5xU9yqD6WNxyxDkzknxcGJPETODMCZKDFG2Pw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ohq/QidtMMhvuoQn3k1V0osZPXj/L17D20miE8Ha+MU=;
 b=OPDyjY/gtRPaGIpZ7jUZduRO6Ru17o+AcHy5wcHeWERPr3IYZRYIvH+zp8915HnUgZVVeuBrU0kD8O2vTa6ShDTAxN16703OHzPv7zBfwp06QZl4/Ng/kCjEvgSueh7a3zxlhT8mJ9TKb/MgZGKiA6+mN9Nm+JlnFQxnWi00NQ3MOffRVXBlqUG03+7hmI2e9z9N2IuSrNFqthLjevmvITuTxeqasIX8uy1HrlXSlocdU/OSaEg/oiw6Cm3Cw34viPpOSxk2T5+hK4KppOGAQU2LbENh9S/JozCb1heTh1VqktQpkFyVIGGbydcb9MFo4ZKDr+6Xy8JF69Xk8pDWIg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ohq/QidtMMhvuoQn3k1V0osZPXj/L17D20miE8Ha+MU=;
 b=cFaV5d32/+cROyl8XyWUqvwiGgiXoYxm6+AqFgm92pEpfkkXRbZHkvyMm1pMp/QQNQE1PfiWniI8lXJKMViLnvwj4lB0rFhxWLzDUlFfXEgasGqScezauCNsjtxniLA2fgzxoQxLeniYma+jkVlNFwzCpWp2XZlX69jtS/1GZAg=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
Thread-Topic: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
Thread-Index: AQHY6FMyz5PAz01Tnka4mYQhtIXJEK4ficaAgABEtvA=
Date: Wed, 26 Oct 2022 00:24:29 +0000
Message-ID:
 <AS8PR08MB79915FB6F828D7650E85BDA092309@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221025092112.50168-1-Henry.Wang@arm.com>
 <9bec8877-25d2-8d50-6f03-523b806642b2@xen.org>
In-Reply-To: <9bec8877-25d2-8d50-6f03-523b806642b2@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: B5F00B1E48961346ADCDB56FA55434C8.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB8458:EE_|AM7EUR03FT060:EE_|DB9PR08MB9539:EE_
X-MS-Office365-Filtering-Correlation-Id: b7c7b073-0d55-4c86-12ff-08dab6e87721
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2a7tJO+vzDdd2CmYAexMvg6O9gsEEVzi+cfH3vc0wnBeLQlgw3y+yQDIvQX9zIMoxlDtBuRfTZMZhf6P4YaY0W4m7vDoMk6277UZ4qsRbnymWEGglgj3fXdAQlbceHgXdZrv9MBWMKIP4qCTf7uTo87fw34T94ajSHmD9cLcT/zt8GOA8vtnuNzqodnun1M6b6b5UCoV4j7+MYoAGcMKFEHvR0SBr/lcGQcl/q9sjg1VDduGtOQfwLtb5mnMVHAeiBTsRHGD5bCYgQeKEem36YVIzVAU5hzjBKMyfNhSV2U/uJ7LAbFeqN/ksk/7COxlddMmzPO8gkvgj9emqh/7u7dBvjs01RoSqC44EpyvUMV3RSOMRc/EuyvUQ0MgqLWJD0yeVRJdXWeVRUjfdtFmp/pXqE2/rSAnJtCkVOgcGv/MsFkX8gS9SrlnTVmkdofpo3HNnRzwmF/S7tu5asDHi+/mwcuaiEA6w4foIvXzvkXn4urKWWNlZNz88AOFxQmKt3M3OY7wJNn48gfLm3zxU6/BKSeWvcwOnv+qdJ4+DXD3bX3bAPKoicWI5i9lr2q7fO1rD1m8BnIDbFbgTspybYBknyi46fpAK8kkiJlg+pXybJeSoAOkY7yaS6qAAlbR18336HEP9Q5z6vi5NS7Eq09dKmeFfUiiPH4HXVOrolhg0wVoynSf2/D1ZAvvRvVb58VDj3oEEH0aDp88V7AkmwLX2fdPdR085gMgNJnh64waqN+kh1/1ZgYijlWAoKQn+o29sz0RlkyVvI35ZMYxuw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(186003)(110136005)(33656002)(52536014)(478600001)(26005)(41300700001)(8936002)(9686003)(86362001)(316002)(54906003)(55016003)(83380400001)(5660300002)(38070700005)(66946007)(66446008)(53546011)(38100700002)(64756008)(66556008)(76116006)(8676002)(66476007)(6506007)(122000001)(71200400001)(4326008)(7696005)(2906002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8458
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f16e4c31-1400-4b08-e402-08dab6e8724d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MWaOmyi5OtEOJSYANpv6VJPGScxKVHIzoEKBjTY+9RcNPPx8L0kJoBsu0Xh60wLzrJdwaXVodFwIGxrQbrTaLtJ5la89nuRTzq7rXPCl7xMBpCaVbw8/dHFG3geSbaTxfq0DX5gPguZvMOSG1n7wq+n40ZuDt/NIbPTT64Lub/cLeCj+zDG60MaMTpyj73tcEYG183XcnUP1qUZXVHuwdE8GWv+Bn+w9lfQQLmGash4Jtv8pxf+NxHjcV+pzE48cUoZgihpbSvY8dgVzvCb7pENwEPB+El/nXum7anBKcqwkv2KB/69O4tGY+HNlRoFHcXsblbFbHnHfAIFqgh12JSBbI7LjIMqLQ4G6VdaMjJn/+r8vVCpPNRaf6pZ/ed2Mi2xjGAThRLIlunJJqn45qhsUng49DgvXqlqOBo7b/m08b4rORfU1+It0bvFfP+kH2NOpSrp6EubtAyGsqHbSL8JsJtqpszG8xJ0QGCWQN/JvNLxLvSIXjQfyo3vBESmWy3SmrCAhfXQD2mQQWzgKOJzEqrNODAXyecocq0tX8slmvq6OzYRjkVkftwZantLRZqKheoZsuLfyYQ4L5arWP0TDE4u4uOqOl+w9BTQYO71xrZvhLZHlHVHVi0q1I1MQyVx36DEN1KBEQ2Nq9O43iyIDTHef5XBlizIwZiQte+gKNqGqd9glwyjwOjwVSHCkR1Qf3nai73NLr4qq+7FB13fzt1mctvJrJMJ/bj/FK1Q+04KBDobZEpunoC5PGiXu4S8V9fBY1FQnmo17wwLN+Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(83380400001)(2906002)(47076005)(36860700001)(186003)(336012)(82310400005)(82740400003)(5660300002)(52536014)(41300700001)(107886003)(26005)(9686003)(6506007)(110136005)(7696005)(53546011)(33656002)(54906003)(40460700003)(55016003)(4326008)(316002)(8936002)(70586007)(70206006)(8676002)(86362001)(478600001)(356005)(81166007)(40480700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 00:24:37.3045
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b7c7b073-0d55-4c86-12ff-08dab6e87721
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9539

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggZm9yLTQuMTQt
dG8tNC4xNiAwLzJdIEJhY2twb3J0cyBmb3IgWFNBLTQwOSBmaXhlcw0KPiANCj4gSGkgSGVucnks
DQo+IA0KPiBPbiAyNS8xMC8yMDIyIDEwOjIxLCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IFRoaXMg
c2VyaWVzIGlzIGEgYmFja3BvcnRlZCBzZXJpZXMgZm9yIFhTQS00MDkgZml4ZXMgZnJvbSBtYXN0
ZXIgZm9yDQo+ID4gNC4xNCB0byA0LjE2LCB3aGljaCBjaGVycnktcGlja2luZyBjb21taXRzOg0K
PiA+IDM3ODNlNTgzMzE5ZiBhcm0vcDJtOiBSZXdvcmsgcDJtX2luaXQoKQ0KPiA+IGM3Y2ZmMTE4
ODgwMiB4ZW4vYXJtOiBwMm06IFBvcHVsYXRlIHBhZ2VzIGZvciBHSUN2MiBtYXBwaW5nIGluDQo+
IHAybV9pbml0KCkNCj4gDQo+IEkgaGF2ZSBtZXJnZWQgdGhlIDIgcGF0Y2hlcyBpbiBYZW4gNC4x
NiwgNC4xNSBhbmQgNC4xNC4NCg0KVGhhbmsgeW91IHZlcnkgbXVjaCENCg0KPiBJIG5vdGljZWQg
dGhhdCB0aGUgInJlbGVhc2VkLWFja2VkLWJ5IiB0YWdzIHdlcmUgcmVtb3ZlZC4NCg0KWWVhaCwg
SSBjYW5ub3QgZmluZCBhbnkgIlJlbGVhc2UtYWNrZWQtYnkiIGZyb20gYWxsIHRoZSBiYWNrcG9y
dGVkDQpwYXRjaGVzIHNvIEkgcmVtb3ZlZCB0aGF0IHRhZyBmb3IgY29udmVuaWVuY2Ugb2YgdGhl
IG1haW50YWluZXIgZG9pbmcNCnRoZSBiYWNrcG9ydC4NCg0KPiANCj4gV2UgdXN1YWxseSBrZWVw
IHRoZSBjb21taXQgbWVzc2FnZSBhcy1pcyAoaW5jbHVkaW5nIHRhZ3MpLiBCdXQgSSB2YWd1ZWx5
DQo+IHJlbWVtYmVyIHRoYXQgd2UgbWF5IGhhdmUgc3RyaXBwZWQgdGhlICJyZWxlYXNlZC1hY2tl
ZC1ieSIgdGFnIGluIHRoZQ0KPiBwYXN0LiBTbyBJIGxlZnQgaXQgYWxvbmUuDQoNClRoYW5rcy4N
Cg0KPiANCj4gQWxzbywgaXQgbG9va3MgbGlrZSB0aGUgdG9vbHMgSSBhbSB1c2luZyB0byBkb3du
bG9hZCB0aGUgcGF0Y2hlcyAoYjQpDQo+IGRlY2lkZWQgdG8gbW92ZSB0aGUgImNoZXJyeS1waWNr
ZWQgLi4uIiBsaW5lIGJlZm9yZSB0aGUgdGFncy4gSSBhbSBub3QNCj4gZW50aXJlbHkgc3VyZSB3
aHkuLi4gU28gSSBoYXZlIG1vZGlmaWVkIHRoZSBjb21taXQgbWVzc2FnZSB0byByZS1hZGQgdGhl
DQo+IGxpbmUgd2hlcmUgeW91IGluaXRpYWxseSBhZGRlZCAodGhpcyBpcyB0aGUgY29ycmVjdCBw
bGFjZSEpLg0KDQpIbW1tIHRoaXMgaXMgc3RyYW5nZS4uLnByb2JhYmx5IGI0IHRoaW5rcyB0aGlz
ICJjaGVycnkgcGlja2VkIGNvbW1pdCIgaXMNCnNvbWUga2luZCBvZiB1bm5lY2Vzc2FyeSBpbmZv
cm1hdGlvbiB3aGljaCBzaG91bGRuJ3QgYXBwZWFyIGluIHRoZSBjb21taXQNCm1lc3NhZ2UgOikN
Cg0KTXkgaW5pdGlhbCB0aG91Z2h0IHdhcyBhZGRpbmcgdGhlICJjaGVycnkgcGlja2VkIGNvbW1p
dCIgd291bGQgcmVkdWNlDQp0aGUgbWFpbnRhaW5lcidzIHdvcmtsb2FkIHNvIHRoZSBwYXRjaCBj
YW4gYmUgYXBwbGllZCB3aXRob3V0IGFueSBtb2RpZmljYXRpb24NCmJ1dCBpdCBzZWVtcyB0aGF0
IHlvdSBzdGlsbCBkaWQgc29tZSBleHRyYSB3b3JrLi4uLnNvcnJ5IGFib3V0IHRoYXQuDQoNCktp
bmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBH
cmFsbA0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 00:27:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 00:27:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430286.681795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onUGs-0005lx-MY; Wed, 26 Oct 2022 00:27:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430286.681795; Wed, 26 Oct 2022 00:27:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onUGs-0005lq-Js; Wed, 26 Oct 2022 00:27:50 +0000
Received: by outflank-mailman (input) for mailman id 430286;
 Wed, 26 Oct 2022 00:27:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NsSF=23=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onUGr-0005li-Mt
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 00:27:49 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04a2191f-54c5-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 02:27:48 +0200 (CEST)
Received: from DB8PR09CA0019.eurprd09.prod.outlook.com (2603:10a6:10:a0::32)
 by DBBPR08MB6233.eurprd08.prod.outlook.com (2603:10a6:10:204::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct
 2022 00:27:42 +0000
Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:a0:cafe::b) by DB8PR09CA0019.outlook.office365.com
 (2603:10a6:10:a0::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 00:27:42 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 26 Oct 2022 00:27:41 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Wed, 26 Oct 2022 00:27:41 +0000
Received: from 2c70d7bf9aa2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 63D9BCD3-BEE8-4351-9BED-4B0CADF1F799.1; 
 Wed, 26 Oct 2022 00:27:36 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2c70d7bf9aa2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 00:27:36 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB8458.eurprd08.prod.outlook.com (2603:10a6:10:3d6::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Wed, 26 Oct
 2022 00:27:34 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 00:27:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04a2191f-54c5-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=aeffBM68z0kIz9ad5V0JMPEWRxNrpc1MYhd/4okkcr+Q2G7O0h0fO03AEnR74+ZLX80kFRsMb+QIPbHRAgfSnkmdbmwGFyeWY8IdgkaBcaZH2kOEXYAivCh4lVprPgmTH4JgBokr4vnqb0me1CqdAEr8vv+nVeFAh6CFRzxz78np89HuWL3kT3VhdWig5h12L3V+L+JR9gXXbiOlbnLroFp7Fv/BLw5hk7tw8SGKde2KUvpHHM3qMP965Sl08uCIvITWh3djajyhNEMkKUej9TLnJVE3YFOFOMiaDS9ZGo8V3xkhZawFI1AusY/PloTdl6FMHFVhnm+pJQTXOb35fA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TizVcDI5HtjKEM6LeLrJCwzea0cFMJJKYl5s7pVpJSY=;
 b=IpW5Rnnt6O6cxnFjuvM+3jYhg7WZz62f+vm7I5XXcUbn3gkntQXkG4zx+/vOJx8ToROoJjZJgShOnTtii3rYxxkc+JG5iqXmaCvaxiaWQmMEZ4hGCw6K20DQ3va4BVA6yfE8G4OCFbfnJRjrNVwHLrDvyNsKY0idYIHyNKtOP5CO+ItcdAsjjMgt+NPyQAke0CtbknCydFUFRUio8AAQW2eDCjDL0t38yqvSIxLUUyQwE+0mAVrcqFFkZb8znbxkjI+ZSxsKieSCUzEHkA2EsDRzfFCQGSktZ+kBX2cBH6ee0oVI1MSDRL+ahHcmehdfCRudiJwR1cpgIVhTSYODgA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TizVcDI5HtjKEM6LeLrJCwzea0cFMJJKYl5s7pVpJSY=;
 b=X76hAjToKlHawovABtsPWUZ6aVNO7cAdGwefb7J7eGN9Xx3mkqRHOSw31DxaN41yHJhnaWHh6VGQEVtlYjX4zP0lLx+s0JnSjUuEyhQd8x15Gijs4wvz3KXjkDUJgGoCr0HhNBnHsd7uTsGO+6I24vyboK6QIR0K3DMwE0cTo2w=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C3wF+qLQa2jTY5+P7XIMHVAXH0edlQITsePKfPOZR4NTmYwfGagLQuduVYmn423S/femoXZ1yhyTPNAbIWk6rO1sa7ffnYn9J6acNQJoW9Z48kMtlvc4pDKvM9x0mydk75gnAUmWV8tb+0Gm21uiWQCf0FJHnCupesQuGd5Z4cTy0pSm2460sgYyIEwJIlwwFLo5JDyrhxwvmB4sNAiwCIXX/l0uF6Va1T9/CHSp0OF19b54hqevok0300ErdcNsSsmfqEiI++fhh0S38PFSOeVwsV0p3S8FYpNuDWguNeNUxs82OiWS9qfnySK40Gm6ADNvXmzcfQbTSXYbIa57RQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TizVcDI5HtjKEM6LeLrJCwzea0cFMJJKYl5s7pVpJSY=;
 b=WtLgsjdYEilhXsyztv0fjAr18UHN0RwEJxTl54rfgELo+cpRXRYA6MnrIdp9AChNhi/NT1crwBuxXYeCBfLRM6BXeXNhuq61vTvDBD4CsqKQHhrk3Vkmmn2k3FqZ4gsEjFL+zs4L4fTuSSRMfPhQlc4J6+MCxUA1XKfp3w+u/27Tlw49W3La58tio4qw5Bjd32oh7Dt0Kkm/ge8Jbr9KBqVxkKuA77O0FhvCpNVNC4/Bu+0esCshVPNVJekcsB5w1o6nMVv6Q/OUYqJr07OwboF93jJya7DacQQ7gY5EQrYLWbpinhhw3r3E0wDNTVJuqigyO6dhZG2TVW2AVR16bg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TizVcDI5HtjKEM6LeLrJCwzea0cFMJJKYl5s7pVpJSY=;
 b=X76hAjToKlHawovABtsPWUZ6aVNO7cAdGwefb7J7eGN9Xx3mkqRHOSw31DxaN41yHJhnaWHh6VGQEVtlYjX4zP0lLx+s0JnSjUuEyhQd8x15Gijs4wvz3KXjkDUJgGoCr0HhNBnHsd7uTsGO+6I24vyboK6QIR0K3DMwE0cTo2w=
From: Henry Wang <Henry.Wang@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>
CC: Paul Durrant <paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding
 handling
Thread-Topic: [PATCH for-4.17 v2 0/5] (v)pci: fixes related to memory decoding
 handling
Thread-Index: AQHY6IBWBZfIV8vcxEqNmhmW2Z94164fNKeAgAAQKgCAAI0fAA==
Date: Wed, 26 Oct 2022 00:27:34 +0000
Message-ID:
 <AS8PR08MB79917182F722088D7F872A2192309@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <8a89c0fb-3d12-fcf9-7e53-d32f9904a3f6@suse.com>
 <Y1gIIPdQWKDZkNVD@Air-de-Roger>
In-Reply-To: <Y1gIIPdQWKDZkNVD@Air-de-Roger>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 35451000DC415346A5563C1204C11754.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB8458:EE_|DBAEUR03FT018:EE_|DBBPR08MB6233:EE_
X-MS-Office365-Filtering-Correlation-Id: 6e7a9305-f401-45bd-7f7c-08dab6e8e4f5
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sMQZuaYDyI5KRnMRbVs75i0cP/C09VvtlUC0O1/rnTilkpxdZb+zpQ8f91LwdhzJewfN0utoNpm3sQ7Np/l/6A1OXnzoZEbovfekX/spQepjhuROCE9VFDcifx3ONh2cBGsyrSCYjLYVbJ9Kj7w+q6bEdS2wK2lso6VEcJxn+lo+mtXOsvlv9XlKkLbzotQ886k5CinYet4OzvRQQtlpLDUbwczc7tu9yblnwldUggNJ19dvavbTdifw9nUCHkRlSGowm3l8JZc5en3XxzCt4T5kuNv1mUBdD19Dw3JcpJdcO5oSbO6OwrJp3nAWOjh9QmQdz9eoehlWs7bv2sBSun80WjtgRzySV7M+DxCcaIwhzoCHES5QshjZS1jZSvzrmfjrROyg6ZyUZQwwSOw0fOykwuY6UfYXpelrDTA7IkkjGasJuSflOqdfeOz5kPc9ENTxrIvzsvt76ZfvFgnIYU7g9bfFDy8xuYV5JzGbcDyvnXV+uxvF57ePYUkI8jktW6S+353pC9Dl3kk1AIr79x8uqe+Yu5S3kb8X0TaXl+LQIs10AmevIiYpMhAYXgg6yoHBiqHDv7fASLxQhSbMVy36DPyaM9HLi/s0naiAFZHBQ98E9l70wRDAOAxHqXLuLj55hfqqLeniAR7ioCf2SWHK+OU6yKqAGOjvDcD2II7DfxIdhqjDgNr+Dx18tX9bnmTwICmE8cKF4HnBBGsY5n1XHYbD2GF1QNOa8xLszZeRCRsvAT8CduYGS1OQ/sx52Evfk5bUb1z0DEFa4yToxg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(186003)(110136005)(33656002)(52536014)(478600001)(26005)(41300700001)(8936002)(9686003)(86362001)(316002)(54906003)(55016003)(83380400001)(5660300002)(38070700005)(66946007)(66446008)(53546011)(38100700002)(64756008)(66556008)(76116006)(8676002)(66476007)(6506007)(122000001)(71200400001)(4326008)(7696005)(2906002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8458
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ae6c83f5-e75a-4c74-857a-08dab6e8e0fc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LD9TxUBmH7QIqK4tmU9LK7TfJGKReRONeOX2wOLFQ3S+utmCe1z9BQ3Sbger8Gbhhm1WcgveM72aAW9h64H78hQsrNMtY4XUnhx2I9sZ/BwkDss9ibPltXQHQlBpdMF9l59MpAVgVJre2F9U99lSjcb93JkftXdceLnSxODNdhfZ7+RSFWudfMDhjjnoaInHD6cMoCgvXzb2OHHX3C2JtyssfynqLAjEU4CjhhFcYR9rR6npArilIoTOgSRLCIDDH0+hGLhacKAh8C1vZGDwPiuKosTiOaf8lVr2H3iUiwpZg9nGGd611sEr9g7d9L2B16t4/ung/XB1wQMijwDtsK8cbqGySfX34lV/3GSubOsKawPvPTU5JZSiRYrdJ1dPgV2U1f26yoA5DMXzsAN3J3k9br5f+7hUKPgHBT3xNklH4Fv8/9aAIZ9Uo2xM/6+HSPl+BA6pyDaNstehRe5Wz/b2Rq7mBVJfqdt5eTMm7QbXa/HzLi6Rr8S0ISsnz4OsxciRgPP9gapy+NnRGVHHuKH7qDVG0ywmJGN5jKbv0qKdUZd2cuqoUkFCVkEBYk7IWgUG59HV/X5wkSAb/pjaB6TR7QjweYYSd0aWlpss8nRwQUS0dvEw45sfBB4hi05Hl/xEQ24RAYN5vfDsbNDgmXmNmqqxt1nPz9xWzJ/9Q7C7WPPWSXbY8S4E3cx+HgTwiCdLW3S6DoC1CKAZfWlPqkOwsjaW2KarnwXW2A6vpeQcH2cH7PASH6Tr2p5tQCGu6a+GGcYloWH+JwV//mf0wg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(46966006)(40470700004)(36840700001)(70586007)(7696005)(316002)(52536014)(6506007)(53546011)(40460700003)(54906003)(41300700001)(33656002)(4326008)(2906002)(8676002)(110136005)(26005)(9686003)(5660300002)(86362001)(70206006)(82310400005)(81166007)(478600001)(8936002)(40480700001)(47076005)(356005)(55016003)(36860700001)(83380400001)(82740400003)(186003)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 00:27:41.6308
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e7a9305-f401-45bd-7f7c-08dab6e8e4f5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6233

SGkgUm9nZXIgYW5kIEphbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t
OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogUmU6
IFtQQVRDSCBmb3ItNC4xNyB2MiAwLzVdICh2KXBjaTogZml4ZXMgcmVsYXRlZCB0byBtZW1vcnkg
ZGVjb2RpbmcNCj4gaGFuZGxpbmcNCj4gDQo+IE9uIFR1ZSwgT2N0IDI1LCAyMDIyIGF0IDA1OjAy
OjQxUE0gKzAyMDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+IE9uIDI1LjEwLjIwMjIgMTY6NDQs
IFJvZ2VyIFBhdSBNb25uZSB3cm90ZToNCj4gPiA+IEhlbGxvLA0KPiA+ID4NCj4gPiA+IFRoaXMg
cGF0Y2ggc2VyaWVzIGF0dGVtcHRzIHRvIGZpeCB0aGUgcmVncmVzc2lvbnMgY2F1c2VkIGJ5IDc1
Y2M0NjBhMWINCj4gPiA+ICgneGVuL3BjaTogZGV0ZWN0IHdoZW4gQkFScyBhcmUgbm90IHN1aXRh
Ymx5IHBvc2l0aW9uZWQnKSBhbmQgdGhlIGxhc3QNCj4gPiA+IHBhdGNoIHJlbGF4ZXMgdGhlIGNo
ZWNrIGRvbmUgd2hlbiBhdHRlbXB0aW5nIHRvIHdyaXRlIHRvIEJBUnMgd2l0aA0KPiA+ID4gbWVt
b3J5IGRlY29kaW5nIGVuYWJsZWQuDQo+ID4gPg0KPiA+ID4gSSBjb25zaWRlciBhbGwgb2YgdGhl
bSBidWcgZml4ZXMsIGFsYmVpdCB0aGUgbGFzdCBwYXRjaCBpcyBub3QgZml4aW5nIGENCj4gPiA+
IHJlZ3Jlc3Npb24gKHNpbmNlIHZQQ0kgY29kZSBoYXMgYWx3YXlzIGJlaGF2ZWQgdGhpcyB3YXkp
Lg0KPiA+ID4NCj4gPiA+IFRoYW5rcywgUm9nZXIuDQo+ID4gPg0KPiA+ID4gUm9nZXIgUGF1IE1v
bm5lICg1KToNCj4gPiA+ICAgdnBjaTogZG9uJ3QgYXNzdW1lIHRoYXQgdnBjaSBwZXItZGV2aWNl
IGRhdGEgZXhpc3RzIHVuY29uZGl0aW9uYWxseQ0KPiA+ID4gICB2cGNpL21zaXg6IHJlbW92ZSBm
cm9tIHRhYmxlIGxpc3Qgb24gZGV0YWNoDQo+ID4gPiAgIHZwY2k6IGludHJvZHVjZSBhIGxvY2Fs
IHZwY2lfYmFyIHZhcmlhYmxlIHRvIG1vZGlmeV9kZWNvZGluZygpDQo+ID4gPiAgIHBjaTogZG8g
bm90IGRpc2FibGUgbWVtb3J5IGRlY29kaW5nIGZvciBkZXZpY2VzDQo+ID4gPiAgIHZwY2k6IHJl
ZnVzZSBCQVIgd3JpdGVzIG9ubHkgaWYgdGhlIEJBUiBpcyBtYXBwZWQNCj4gPg0KPiA+IExvb2tz
IGxpa2UgeW91J3ZlIGxvc3QgSGVucnkncyByZWxlYXNlLWFjayB0aGF0IHdhcyBnaXZlbiBmb3Ig
YWxsIG9mIHYxDQo+ID4gKGkuZS4gb25seSBwYXRjaCAyIGlzbid0IGNvdmVyZWQgYnkgaXQpLg0K
PiANCj4gSSB3YXMgd29ycnkgYWJvdXQgYWRkaW5nIGl0IGFnYWluIGZvciB0aGUgd2hvbGUgc2Vy
aWVzIChleGNlcHQgcGF0Y2gNCj4gMiksIGFzIEkgdGhpbmsgcmVsZWFzZS1hY2tzIGFyZSBjb25k
aXRpb25hbCB0byB0aGUgdGltZSB0aGV5IGFyZQ0KPiBnaXZlbi4gIElPVzogYSByZWxlYXNlLWFj
ayBnaXZlbiBmb3IgYSBwcmV2aW91cyBzZXJpZXMgc2VudCBtYXliZQ0KPiB3ZWVrcyBhZ28gc2hv
dWxkbid0IGJlIGNhcnJpZWQgb3ZlciBiZWNhdXNlIGNvbmRpdGlvbnMgdG8gZ2V0IGNoYW5nZXMN
Cj4gYWNjZXB0ZWQgbWlnaHQgYmUgdGlnaHRlciBhcyB3ZSBwcm9ncmVzcyB3aXRoIHRoZSByZWxl
YXNlLg0KDQpUaGFua3MgZm9yIGJlaW5nIGNvbnNpZGVyYXRlISBUaGUgcmVsZWFzZSBhY2sgc3Rp
bGwgaG9sZHMuDQoNCj4gDQo+IEkgdGhpbmsgSGVucnkgd291bGQgYmUgZmluZSB0byByZWFzc2Vz
cyB0aGUgc3VpdGFiaWxpdHkgb2YgdGhlIHNlcmllcw0KPiBvbmNlIGl0IGdldHMgcHJvcGVybHkg
QWNrZWQuDQoNCk5vIHByb2JsZW0sIGZvciB0aGUgd2hvbGUgc2VyaWVzIChnaXZlbiB0aGF0IHRo
aXMgaXMgYSBidWcgZml4IHNlcmllcykNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8
SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpCdXQgYSByZW1pbmRlcjogcGF0Y2ggIzQgYW5kICM1IG5l
ZWQgcmV2aWV3L2FjayBmcm9tIG1haW50YWluZXJzLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K
DQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 01:56:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 01:56:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430298.681819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onVeJ-0006O5-E4; Wed, 26 Oct 2022 01:56:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430298.681819; Wed, 26 Oct 2022 01:56:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onVeJ-0006Nx-9O; Wed, 26 Oct 2022 01:56:07 +0000
Received: by outflank-mailman (input) for mailman id 430298;
 Wed, 26 Oct 2022 01:56:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onVeH-0006NX-SW; Wed, 26 Oct 2022 01:56:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onVeH-0007QE-P1; Wed, 26 Oct 2022 01:56:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onVeH-0004U3-By; Wed, 26 Oct 2022 01:56:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onVeH-0004o3-BN; Wed, 26 Oct 2022 01:56:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VTSN0z6IHQSOKKEDgRpcMZoE86F7qcmI+aR3g7BFAqM=; b=oPXctjgdQyodNDk1zWWN0nXBdS
	aj7z0Ddxl7uDK3EECmhSjs30A2YvsQgnVrEuNUI6a8G9AYR66Y2p/kGZryi+TYzKC/qsYwC/IInuI
	G2/XnlWKbVd6chWbVyVDRM7xv5CJmijZmbj/2efIsTUi8JmXpppKGm7jlIpxRFr/LuYc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174421-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174421: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ef9cc669ba157f9e71fd79722ee43892e7304604
X-Osstest-Versions-That:
    xen=4ff0811a2b0d1c715f54550f9a3632195bb6b21f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 01:56:05 +0000

flight 174421 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174421/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  ef9cc669ba157f9e71fd79722ee43892e7304604
baseline version:
 xen                  4ff0811a2b0d1c715f54550f9a3632195bb6b21f

Last test of basis   174409  2022-10-25 14:00:29 Z    0 days
Testing same since   174421  2022-10-25 23:00:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michal Orzel <michal.orzel@amd.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4ff0811a2b..ef9cc669ba  ef9cc669ba157f9e71fd79722ee43892e7304604 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 01:56:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 01:56:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430303.681832 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onVek-0006md-NI; Wed, 26 Oct 2022 01:56:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430303.681832; Wed, 26 Oct 2022 01:56:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onVek-0006mW-Kb; Wed, 26 Oct 2022 01:56:34 +0000
Received: by outflank-mailman (input) for mailman id 430303;
 Wed, 26 Oct 2022 01:56:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NsSF=23=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onVej-0006mB-7u
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 01:56:33 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140083.outbound.protection.outlook.com [40.107.14.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68fa33c6-54d1-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 03:56:30 +0200 (CEST)
Received: from DB6PR0301CA0089.eurprd03.prod.outlook.com (2603:10a6:6:30::36)
 by AS8PR08MB9525.eurprd08.prod.outlook.com (2603:10a6:20b:61f::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct
 2022 01:56:28 +0000
Received: from DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:30:cafe::b9) by DB6PR0301CA0089.outlook.office365.com
 (2603:10a6:6:30::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend
 Transport; Wed, 26 Oct 2022 01:56:27 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT065.mail.protection.outlook.com (100.127.142.147) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 01:56:27 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Wed, 26 Oct 2022 01:56:27 +0000
Received: from 4497f06e85dc.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 36AD46AA-150F-47E8-9F7C-80FAF72E8E6B.1; 
 Wed, 26 Oct 2022 01:56:20 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4497f06e85dc.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 01:56:20 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS2PR08MB9785.eurprd08.prod.outlook.com (2603:10a6:20b:606::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 01:56:11 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 01:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68fa33c6-54d1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Bzb7qUObggB1iV26vWEDD7xbKm2OXcAXbn6GCs5Jvk823Pq6LQVbjXk6vt5heXOeaDBurwcLyH0SNuwdI89pouupR0A4Jd6gbd+EEy7OfN5sR1YtxNESyMWjYowuk32/vUDWn9tO5PyZblD5l83O7YBycNc5zgOzNf7D+MgZYIr9hKY21LlWyJ2JglaCmH7qQiCvvvQ5eBc8LwYh82KymXoZl5LsLB3fpZBfgT6SKwvk5NT7cCwQ65ONNQ/TY22mA2RV+j3edu4CsaO1RRQ480pUizAT/nUIkalz4shLMdLZ4K3hvMwC7ZVvcVv7L8Y4+1OU+aQqUEq5MD2WoXGsvg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u+RhG1JO8jwhVrvB4DgFAccV0R2dNcyoZg9tnj5yBPE=;
 b=lByF+MIurCVd84v8n90IBmbspHcDFm10ZHLmML1t/XNmmRsetdOKetO9w+M7bfwHylB+mpksVk2eMquMPH/3oF71QsrZoVK9TeNLM1h8jk9RWMntkVmih9swJNzdgTkDZ3vMkaxTqQYoJFqSbOsfJckvAmX04bB/22TstRZRBbSycurTBgOa0keJZ/DGLYKq5tXyo4G4RFqlgJLJZmqrerQ+vdK8OLv41qtpmLM6/dvihjiowROR6y4+Rpp04+BzriKq+Sr20QyDN+0x+8FUexIFT1NnkW8hJ7E9ziHYxR6oNnFpycGKh1SOLFFlwj9yIKke4e3z6bNNkyQRJEgWZw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u+RhG1JO8jwhVrvB4DgFAccV0R2dNcyoZg9tnj5yBPE=;
 b=qLgv6FtmHBZ1jZyvU17LVuKVZLyCmAhGTjUpmcSIpJPtZ9iBFfFsm3LkEvgYDSpdeiRqx7H/WidSbRNDfy+h9o44gOSPIpr5Zr8szteSnT0TkIPkZa9N5Mj7N9vGIgklOzPHjq2Poup6YB4+r9A/oi+xESNAl2pdwa0vF0ssCeA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m8+YFz4NXH16KmuF6Y/oFS49+BmXzNZe3yUKDna+c1zShbTIn4tm/f5WdRX3AVPYngPYat3vjBY8YkTY7t4LcUuhSNZh17qVGz5D31DL64lLM1uh4Nm2ZClvnSpsarSYKmUJnHjMi6c9f/X6VeLm67ormiLuFsd4WLYopDPfqsJKxhZeG2AqHc03edclkv1hLvYyRaOWDeEG7ZhRJw20Wn+RBnfW3i00g9+RGISrQG4EFXVeGmfI0Cnqj1vKTUx98r+mvDo23Uc5+5UVcQQeFeKkJjn0ecfc7YBDd/dA2myKmTCqvR8WGG1hbn9WiZrOlbfE1uJG7qwl2K0BvGCRFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u+RhG1JO8jwhVrvB4DgFAccV0R2dNcyoZg9tnj5yBPE=;
 b=IuDKtP8XoZiLmnLPNzWNdlEuP2pcKLrdOB97lSZ0iu69Tror96ElRysDr+AwkXaEfGAeN5mxi5mZH8zG+vrI+T9OQ0Os5lH2kFEF7C7vFR0sOM82w4SntkTdKRSdcagkF+v5+nKHQFqcjVsUa8N8LW6LcHUPLYULMN9V9Fl+IHXEWq2yQxfy9qUqexljk2RnZtKrDd4Ky/gkDKDbDvmq4TXot988zAieUZqnSqY5WgamP21mIKBffcs6Lle7Hvnth/RDUwJ0bhQwLzMGwKrJZiZQMI6ExWVsluXZHP2yyWQja4dlPbkpUivCMVAEfUtct8RUWQnt1RJvAPJp8xidwA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u+RhG1JO8jwhVrvB4DgFAccV0R2dNcyoZg9tnj5yBPE=;
 b=qLgv6FtmHBZ1jZyvU17LVuKVZLyCmAhGTjUpmcSIpJPtZ9iBFfFsm3LkEvgYDSpdeiRqx7H/WidSbRNDfy+h9o44gOSPIpr5Zr8szteSnT0TkIPkZa9N5Mj7N9vGIgklOzPHjq2Poup6YB4+r9A/oi+xESNAl2pdwa0vF0ssCeA=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Ayan Kumar Halder <ayankuma@amd.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>, "stefanos@xilinx.com"
	<stefanos@xilinx.com>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Andre Przywara <Andre.Przywara@arm.com>
Subject: RE: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit
 guests
Thread-Topic: [XEN v2] GICv3: Emulate GICR_PENDBASER correctly for 32 bit
 guests
Thread-Index: AQHY598l3BDpzksR8Ui/iytPKb2rYq4fhckAgABmFoA=
Date: Wed, 26 Oct 2022 01:56:09 +0000
Message-ID:
 <AS8PR08MB799168455DA41BC0F789DE7E92309@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221024193002.57888-1-ayankuma@amd.com>
 <05c469e9-8d9a-76ac-016b-400b550dbb68@xen.org>
In-Reply-To: <05c469e9-8d9a-76ac-016b-400b550dbb68@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 6B61026833079748B894674426D5DEC3.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS2PR08MB9785:EE_|DBAEUR03FT065:EE_|AS8PR08MB9525:EE_
X-MS-Office365-Filtering-Correlation-Id: 276acebc-b21e-4147-fdb3-08dab6f54b4a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 y3htpyhRS5W0Si/T/fx9JRIvdiSnThfaeU1RLmNaXI9OEqXUXR4/MAopKKcjvODl69f9v5VezRj+Z0nKT1H54KHP3n6exD3J9r8dIgJ/lr7boR4TItAtNNhD1Gt4eUo9Xy2pGrnc+MOgo8FslEl+ShW8koyusoc0L3P7SYubP3JS+FbUp2x3qaYMcDE+obXTZioNpFzQsmbdvs9z0pClq6IpmGeoyKE8/4D1aTawjUBWbD25UDaYjArac5a7Of9L5RHJYDmrU7IW5mKephpPYTLYEme9i0n4SKwEM9JF+e6T+bTtF+hOTWMqn6g0HYKmBoakCtUT9tC6zLKkF0s9zIXMD8iEFg/lJBtqS/dD+0P9gtAaETds1NPl/an/CoK49zabLB5IlPQcWAz2JJa0SEhpDlc8dR1LodCcLoYqfSugJmYVDuD5XeJFH1o5wB4FgmPptfRHaS8+dgYeMMuyBVqygO0w3SoXx6YlcJnhGd/JmOeJhtiCGm4ROaYP9gh5TKTnT5xL+d8A6v3Oyr2lU1zRtcTdBSPIzVIZSEd/NZNqaf6rF6FM3KBXhyo1wgMZBzvAdBtrOZiCMsQxM36SymuH9OsqfT59asne82IDynL675gtz/hmaYjXIPXh5ix//FILGXZ9NFhAywAB6kwWjdXSbnIKNUi2Ud6GubcfXoMgxfTdmxhg6FFuY0eqDHeytw1tQ6HPHgIK7TCfaP5LKnQWikCIbAZikRaEN1a251KvDKqgKqMoItD847XwIPE8
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199015)(2906002)(64756008)(4744005)(76116006)(66556008)(8676002)(52536014)(54906003)(316002)(66946007)(66446008)(41300700001)(4326008)(66476007)(71200400001)(5660300002)(33656002)(110136005)(55016003)(8936002)(478600001)(83380400001)(38070700005)(122000001)(38100700002)(6506007)(26005)(7696005)(86362001)(186003)(9686003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9785
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	321dd137-f3c3-4d9c-d0c3-08dab6f540bb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QjOkDWVG4sVwvGrrkqTRO4RhedD7t46dpJBC49s3JT/WNwr8cX1gs5ndK2Dn0dHyyBi6LmdRIzfbNRo81WWedODcwh0bF1LGqrlbb1BsHJ7/6R+MQ4mDl8wSUQVWBX/L6Xzxo8GPpm27HEJgcxQUMfrHEIJlBF1r1h+fiLQVSAjXPx9j41OvDZJE+2+SZgrl7HhDYhkNEvxC+qty6gIA++zxcm5faV5vjWV1y9VCm46BHHviqeSZRMTjZRlt6rK32h4tjTYo4bQpCRD5UmhV87dQj2OzGyp4B2AiF/ss2fmqagr2mb6pujq003Ty909BnxkxAImPHmK4GZzoHuaNSCj1Kb4ji2u8r5G5sqoU5wMER+RKymxnuE6/9ltv1x+sGW1V+cBLLcayOU7h/ig4JsaD9MdBWwIEvvM3tKZStmOL5SOpxHsGchuT/NmsRfFntUXhYyfEPxA1ox+JVSJ4JuUnIMaSOrolwH0UoPnVTEuFcL97yf5UkoiXrsXemHn+0ZhpwX2z/hkb6D4sTfvQit8qbtJYP36JRigyPxWN4LWsoZU0nqxff1LjbcQs4cgu5By+WsQTQG3CYjBtEBYTF2Q5v+eF3zZNPtoomUQa3kqktUBdBgmhxkMmayGIXGZGsH2W9QO2fddRBmiDPh/UlGDcdTiFf62CpAyefPk2Oeg7S9kh5mVw5Rf6zEOhEg65bE+XAaz5rEZSX53s6CzO5QQybRCSN8dC5GVRi++G33B5R7+jiIikGksR8lmA2q7O/RYtJtC1dYlF+woX0VlI3g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(2906002)(336012)(4744005)(26005)(9686003)(5660300002)(186003)(41300700001)(8936002)(356005)(81166007)(40480700001)(33656002)(55016003)(86362001)(82310400005)(40460700003)(83380400001)(47076005)(82740400003)(36860700001)(110136005)(54906003)(316002)(478600001)(70206006)(52536014)(8676002)(7696005)(6506007)(4326008)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 01:56:27.2638
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 276acebc-b21e-4147-fdb3-08dab6f54b4a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT065.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9525

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbWEVOIHYyXSBHSUN2Mzog
RW11bGF0ZSBHSUNSX1BFTkRCQVNFUiBjb3JyZWN0bHkgZm9yIDMyIGJpdA0KPiBndWVzdHMNCj4g
DQo+ICgrSGVucnkpDQo+IA0KPiBIaSBBeWFuLA0KPiANCj4gQWRkaW5nIEhlbnJ5IGJlY2F1c2Ug
dGhpcyBpcyBzb21ldGhpbmcgd2UgcHJvYmFibHkgd2FudCB0byBmaXggaW4gWGVuDQo+IDQuMTcu
IEFGQUlVLCB0aGUgdmFsdWUgaXMgbm90IHVzZWQgYXQgYWxsIGluIFhlbiwgc28gdGhlIHJpc2sg
aXMgbW9zdGx5DQo+IHJldHVybmluZyBhIHdyb25nIHZhbHVlIHRvIGEgZG9tYWluIHVzaW5nIEdJ
Q3YzIElUUyAobm90IG9mZmljaWFsbHkNCj4gc3VwcG9ydGVkIGFuZCBvbmx5IGV4cG9zZSB0byBk
b20wIHNvIGZhcikuIFRoZXJlZm9yZSwgSSB3b3VsZCBzYXkgdGhpcw0KPiBzaG91bGQgYmUgT0sg
dG8gaW5nZXN0IGluIFhlbiA0LjE3Lg0KDQpUaGlzIHNvdW5kcyBnb29kIHRvIG1lICh3aXRoIHlv
dXIgY29tbWVudHMgcHJvcGVybHkgYWRkcmVzc2VkKToNCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVu
cnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQoN
Cg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 02:03:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 02:03:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430310.681847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onVlo-0000Nb-Gs; Wed, 26 Oct 2022 02:03:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430310.681847; Wed, 26 Oct 2022 02:03:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onVlo-0000NU-Dz; Wed, 26 Oct 2022 02:03:52 +0000
Received: by outflank-mailman (input) for mailman id 430310;
 Wed, 26 Oct 2022 02:03:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NsSF=23=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onVln-0000NO-Oo
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 02:03:51 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f0d8790-54d2-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 04:03:50 +0200 (CEST)
Received: from FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21)
 by AS8PR08MB9094.eurprd08.prod.outlook.com (2603:10a6:20b:5b0::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 02:03:47 +0000
Received: from VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:15:cafe::3b) by FR0P281CA0016.outlook.office365.com
 (2603:10a6:d10:15::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.13 via Frontend
 Transport; Wed, 26 Oct 2022 02:03:47 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT065.mail.protection.outlook.com (100.127.144.171) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 02:03:46 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Wed, 26 Oct 2022 02:03:46 +0000
Received: from 051c43c4fcdb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 5348FD87-D148-43B4-A7B1-95C9B3AD10CA.1; 
 Wed, 26 Oct 2022 02:03:37 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 051c43c4fcdb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 02:03:37 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM9PR08MB6273.eurprd08.prod.outlook.com (2603:10a6:20b:2d7::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Wed, 26 Oct
 2022 02:03:33 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 02:03:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f0d8790-54d2-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=S7VS46O6QQfp+f/6Rphz+LDQWN82IKNQFZnXBLZazX3HGDLCvv6Ld1VuZRX3oNqijHZThqCz0mfpN8hCMeU4h1C2eiXbW1D90sJfc0TWRTewFTUBS+99pMNS4wUJ0xdeDThsb4VtY40vdiDvlCy4QjQcujqehsPdW/gdVQ8lHiIID4MVrjPEf90PdMTpB2WtjrIJ6DIadpE/qXqC6Dpil1M61htIq2qmPh5LcWjhuR9yS7H/ggEfFH0exXGo7L7rVUfnr0en4iZgy61tPnZnlYfE1D63oItIp4E2UYzldpTUBXHKzdSV7fiok5w0QxZYuFNKGTI2h46DrP+o49yi2g==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+z2dHxmsY1Lp//3Um1aszd+MDEWQGZ0kuBI78SFfUjg=;
 b=F6zo/8g1z7Y4dMZ9sOP9jHmN2NlT0obOOT+fMEAGL3DFyzEcIxLijKtQWDH4iA8J3hUEWjgQ+wSIJkM9H7KnxyVlJzfa9rhTKCTUN5V8bO6+26GK6FTXKiQ31BvxThEXjXjdB4BOQpjEiu5DhvCxdJaMAMm2MslZXyX+OX/D9MzS4wMIx3Quoo1r7jDHia8iA6y6IJpqcdcr9NhQY6X3GcNxbDFx7D/F/wlK69WujPSKf8Y4+kTE1EGYhX+yGgsO7/20SlahPFEnJwM9LJs2Hbg57mftLiUT9OJ2y6ZiggdhgMqdQNrm5z8C+XW/NosqPX5ybiXui5H9JA/0RI8kzQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+z2dHxmsY1Lp//3Um1aszd+MDEWQGZ0kuBI78SFfUjg=;
 b=0yS+QXWG6k5mHSfF2xXg7JaX2VCocQ8jV9y98V0S33Gf5f2TPNVsb/g3qiNGJkghk2dvYvBcFQeQgkQsTFdaQs1KOoOZUT/coW0g3b9U96K9iwH1//pXSjvQWEQNZS8RrSO/l98eLu4Nu9T3eSEWTWexLmfRVQL4DdbEUub5vlM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hg08SOC0AMOhn5Qz1LMe+qAz8DjqD3Sft1JX0kMOoKkwV/J8YS3peEswQpJ1fh0FE8OHuMx+cpkr4Yc8VgEuWni1px+/YuYlb1TQo0+IFD3Dd1v3ys+vNAx3kF5USsx2RxLT82bS2nvibejZe54JS+3EYpF4CPuaGo8lWFQQ75S+aycAa3DaPihPAt8IVlTRKxOclbLOwvvDcikxChcZc4JdCXbYcWmaV3HNdRQsMRdBbez0fvgwj9XMDultOOLdEl4kpUY6Pluq5vlSqEu44BIYKKTc56mlgj/U0fqT+45d6MM+yhimHykyUG9UmIm74J1XgqQanTuosSXG0XSxIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+z2dHxmsY1Lp//3Um1aszd+MDEWQGZ0kuBI78SFfUjg=;
 b=AuiVjD4E52dSv0h8oJrDrLBFCxyOA7nA7wT7jJjTwrgQ9GSNVRRfYAAKhUlVMhLnPlt1qTRfiTrWaXnRkXWjZbcXB49Z5HYlysT1fMmnBu2jdzP30QVQet2SSwNQJixR3qgABRLdPIEFHVuZ4rH0WVOKbxFGKdcSBmVgKxwSV3G+ShnNegn2zh9oxmqJp5iPW+i6kt5z8VZgqAtPQrflLZq4S7eMatE0AcyVAPsXaXyxToZHbsdY0QrEKTwan6l2TOUB5XuaIAD69kGaPf7RHZyHl6xfcDBP5Ogfk06uMmFiRfvdnwbx5wMorFjS1JpsXHmBfpwlSCtS+u6onVbgFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+z2dHxmsY1Lp//3Um1aszd+MDEWQGZ0kuBI78SFfUjg=;
 b=0yS+QXWG6k5mHSfF2xXg7JaX2VCocQ8jV9y98V0S33Gf5f2TPNVsb/g3qiNGJkghk2dvYvBcFQeQgkQsTFdaQs1KOoOZUT/coW0g3b9U96K9iwH1//pXSjvQWEQNZS8RrSO/l98eLu4Nu9T3eSEWTWexLmfRVQL4DdbEUub5vlM=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: RE: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare the
 underlying page
Thread-Topic: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare the
 underlying page
Thread-Index: AQHY3U5WyIj+k3kfXES3Q5PgZ4e+DK4fVjIAgAAG1YCAAKWEIA==
Date: Wed, 26 Oct 2022 02:03:32 +0000
Message-ID:
 <AS8PR08MB7991C7034FE22A68AE77A39A92309@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
 <Y1gD7GmclguLZCM8@Air-de-Roger>
 <b9c190ee-f916-b03d-e56f-0a54d93ba948@suse.com>
In-Reply-To: <b9c190ee-f916-b03d-e56f-0a54d93ba948@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 8AB12A33C9DCAC4B86B156B3E36D9BEA.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM9PR08MB6273:EE_|VI1EUR03FT065:EE_|AS8PR08MB9094:EE_
X-MS-Office365-Filtering-Correlation-Id: bdce586c-ef5f-4b98-b9f9-08dab6f65157
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 BEJyadq+uW+GJwNSc25N1lQ5ajAnQ3SqJZ9IgnRJLYJoyJIFhPWb5SFLqcP78az1Tu1s1DNPnaS/FBtkMCRSVT5GxLnsrtEH9OZy88ujiK8SNAK7lc/b0CrOYzan84R6DBjhGccDZr3jK00Cjl7bUhFqPAezwXoq2byTJY9qA6CB4t4BZKJFkuNcxTThywNSmmF75H3icl3AZ2Up1dmBkD5gtCcUKuh3+M/O6eoupqqWr+rdJBDwL/abErmn9hn7KfABdvtblRnS3BPoIIUvXZL14FqzUvEAw5VVXEkOyr8UslkP0TusjbbitmtQHmxNoT48L822q1eym7Z99LiXEzQctYTTfii7FsngSvjA4u438uiQ6HY43q4/l/2BgdhHS4fNye/7bRfHQ2AE/E+ikxBn5shTUp4MFf1NA68nhEFzaBRQnWF/419+8pvVNwWVI7iLCIBw/tYLob0w5gE7xwL4pw2ij3l45HvT2cvJY8EtOMDbiK3IG70t9rZA2PZK6IXj4wJxzlKFuwP9K/8jvnWKJEuBQ1zKTSC/3QdIAAQrbAqFg+Dt5PNyycBch8xb8NSMvJuCdrDidvzzIBX8nJOYLQQysJza/r9+VRglW/Rz6/IkGYuKks31V8TpP0L5gb42oDCtYrxCP5KwsU5bbyLW3mxNL5LpisfGw7u8THqnmEgxO8QXgbrEuen1Zwom65EvVXpoRkphztq/m0ZnSNVm7geo0lOaZjExG/hsCKp5c6E2QEXGpNPHsiML9bs2Rt9pqCSXKO2TgK79IYLGIoEShQROpIDaBog1wEnlABw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(66446008)(66476007)(52536014)(5660300002)(66556008)(66946007)(76116006)(8936002)(122000001)(38070700005)(83380400001)(33656002)(38100700002)(64756008)(86362001)(6916009)(54906003)(55016003)(26005)(966005)(186003)(71200400001)(9686003)(478600001)(316002)(4326008)(8676002)(41300700001)(6506007)(7696005)(53546011)(2906002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6273
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7515dc8e-8b02-4a1a-f515-08dab6f648db
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vFaujDEOfVRtlH12B7wq+QSCsOVNNeqN8WqiX91qsHXrHX4g+ykBsuu9oFktH3D6X7AHDOOqC5jXcUGHJ16095rzfGNqBalbUMXutup+y45HTZhK2lR/TS/Yj0D+9nykZSYUy9189haD6r0/Y0jSRy+pTj8zKXHpetwT+luJghz3jUCaTej3VbRTuQDarAHpXXe5+PH21J6rt9kpx/S6dZoDOdsWezF8VgyTz6kPoh/vXHEAmoQJ7dW59Hgs2wcD/6umDJhcoeJuGBR73fqLuImAkzOUPk7nJH+WwahfcksJz9P6W0pAOC6RK+Gc28yB48zesp7Asea8YQUcuVtfQQ01aBvmKWoVWRiKF8SaRiXaYesVy54WsELPy5hJcN6aw/mYegWgbYANR33OjwKFUfKgQ3gfPaQMSllCg+5rSEII1cNECPHM5WrCVHVSuxcMlb4KaVKSOFiLAIgX2w63W3nW9YFvMrwootb33yMm2pckuN0Evbk9sqCBUpbaskM+PWxX1gxKe2uszZsobGg8dAJW9wMq2TYMxSinx610icM2hZSSsTpw5hMFE3GG237Wk/ose0VRxAG8Qcc4TlVzP2Tq6ttptIAnArjBccgBWmsb93Ww3HNtrE0tQJKdOaNBiQXicdvbs8yYhvZvsEQmMF5HJ2eKUv7NMrdLSX6Jp75iQNx4lxAMs9dCwJ67eNNWQHlUsYxYQg0yv2afkQsWk0UKHomnc0jI0kEgZRbWyod8A7MiLoXIpVdUkrhsZRBx78RJNjoIe6MYv9mvy8XWlffnyfvLylXxVRscGx6+8fY=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(2906002)(40460700003)(70586007)(6862004)(5660300002)(52536014)(7696005)(8936002)(53546011)(6506007)(33656002)(9686003)(316002)(4326008)(26005)(81166007)(55016003)(70206006)(186003)(336012)(8676002)(41300700001)(54906003)(86362001)(478600001)(966005)(36860700001)(356005)(82310400005)(83380400001)(82740400003)(40480700001)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 02:03:46.8166
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bdce586c-ef5f-4b98-b9f9-08dab6f65157
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT065.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9094

KCtBcm0gbWFpbnRhaW5lcnMpDQoNCkhpIEphbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut
LS0tLQ0KPiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFdl
ZG5lc2RheSwgT2N0b2JlciAyNiwgMjAyMiAxMjowNyBBTQ0KPiBUbzogSGVucnkgV2FuZyA8SGVu
cnkuV2FuZ0Bhcm0uY29tPg0KPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBB
bmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxh
cCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsNCj4gSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu
Lm9yZz47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47DQo+IFdl
aSBMaXUgPHdsQHhlbi5vcmc+OyBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNv
bT4NCj4gU3ViamVjdDogWzQuMTc/XSBSZTogW1BBVENIXSBjb21tb246IG1hcF92Y3B1X2luZm8o
KSB3YW50cyB0byB1bnNoYXJlDQo+IHRoZSB1bmRlcmx5aW5nIHBhZ2UNCj4gDQo+IE9uIDI1LjEw
LjIwMjIgMTc6NDIsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6DQo+ID4gT24gVHVlLCBPY3QgMTEs
IDIwMjIgYXQgMTA6NDg6MzhBTSArMDIwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+IE5vdCBw
YXNzaW5nIFAyTV9VTlNIQVJFIHRvIGdldF9wYWdlX2Zyb21fZ2ZuKCkgbWVhbnMgdGhlcmUgd29u
J3QNCj4gZXZlbiBiZQ0KPiA+PiBhbiBhdHRlbXB0IHRvIHVuc2hhcmUgdGhlIHJlZmVyZW5jZWQg
cGFnZSwgd2l0aG91dCBhbnkgaW5kaWNhdGlvbiB0byB0aGUNCj4gPj4gY2FsbGVyIChlLmcuIC1F
QUdBSU4pLiBOb3RlIHRoYXQgZ3Vlc3RzIGhhdmUgbm8gZGlyZWN0IGNvbnRyb2wgb3Zlcg0KPiA+
PiB3aGljaCBvZiB0aGVpciBwYWdlcyBhcmUgc2hhcmVkIChvciBwYWdlZCBvdXQpLCBhbmQgaGVu
Y2UgdGhleSBoYXZlIG5vDQo+ID4+IHdheSB0byBtYWtlIHN1cmUgYWxsIG9uIHRoZWlyIG93biB0
aGF0IHRoZSBzdWJzZXF1ZW50IG9idGFpbmluZyBvZiBhDQo+ID4+IHdyaXRhYmxlIHR5cGUgcmVm
ZXJlbmNlIGNhbiBhY3R1YWxseSBzdWNjZWVkLg0KPiA+Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBK
YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+ID4NCj4gPiBSZXZpZXdlZC1ieTogUm9n
ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IA0KPiBJIGRpZG4ndCBDYyB5
b3Ugb24gdGhlIGluaXRpYWwgc3VibWlzc2lvbiBiZWNhdXNlIG1lbS1zaGFyaW5nIGlzbid0IGEN
Cj4gc3VwcG9ydGVkIGZlYXR1cmUsIGJ1dCB1cG9uIHJlY29uc2lkZXJhdGlvbiBJIHRob3VnaHQg
SSdkIGF0IGxlYXN0IGFzaw0KPiB3aGV0aGVyIHlvdSB3b3VsZCB3YW50IHRvIGdpdmUgdGhpcyBh
IHJlbGVhc2UtYWNrLiBJIGRvbid0IHJlYWxseSBzZWUNCj4gYW55IHJpc2sgYXNzb2NpYXRlZCB3
aXRoIGl0Lg0KDQpCeSBsb29raW5nIGF0IHRoZSBwYXRjaCBpdHNlbGYsIHRoaXMgY2hhbmdlIHNl
ZW1zIG9rIHRvIG1lLCBzbyBJIHRoaW5rDQpJIHdpbGwgbm90IGJsb2NrIGl0LCBidXQgSSB0aGlu
ayBBcm0gbWFpbnRhaW5lcnMnIGFwcHJvdmFsIG1pZ2h0IGJlIG5lZWRlZA0KYmVjYXVzZSBvZiB0
aGUgZGlzY3Vzc2lvbiBpbiBbMV0sIHNvIEkgYWRkZWQgdGhlbSBmb3IgdGhlaXIgaW5mb3JtYXRp
b24uDQpJZiBBcm0gbWFpbnRhaW5lcnMgZG8gbm90IG9iamVjdCB0aGUgY2hhbmdlLCB5b3UgY2Fu
IGhhdmUgbXkgcmVsZWFzZS1hY2suDQoNClsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4t
ZGV2ZWwvMTc4MGFjYjMtZDI5Ny1lZGM2LTNhMWUtYWRmOGIyOGE1MjYyQHN1c2UuY29tLw0KDQpL
aW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBKYW4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 04:12:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 04:12:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430323.681882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onXly-0007NI-24; Wed, 26 Oct 2022 04:12:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430323.681882; Wed, 26 Oct 2022 04:12:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onXlx-0007NB-VR; Wed, 26 Oct 2022 04:12:09 +0000
Received: by outflank-mailman (input) for mailman id 430323;
 Wed, 26 Oct 2022 04:12:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onXlw-0007Mk-Cj; Wed, 26 Oct 2022 04:12:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onXlw-0001lU-AD; Wed, 26 Oct 2022 04:12:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onXlv-0001Vf-Uq; Wed, 26 Oct 2022 04:12:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onXlv-0005Le-UM; Wed, 26 Oct 2022 04:12:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pD/nQsEjp396lf47djNjd9k13QljKIsMEMP78+9YCMY=; b=mnqyC9EWZ/MLDtXDf9QKk3iRjO
	AQZ3Ryf1XMDVSOk8lXM91sKcu8+Hc9creBZJlhKt+xeCPtXUsZ16M4VzCpkOzWLI7PMAOtTn6m083
	YeJCikhfPZnmmR/RJ995q+zq0/MEKbMzzvYCeqKPxdwL1AsYN8cXMjgXufmy2EYUYZNA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174424-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174424: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=26638d2aa399e436f47d629f877e581ed402020a
X-Osstest-Versions-That:
    ovmf=56035d1c8b255b33b34cd4625c26bc7d38504e30
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 04:12:07 +0000

flight 174424 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174424/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 26638d2aa399e436f47d629f877e581ed402020a
baseline version:
 ovmf                 56035d1c8b255b33b34cd4625c26bc7d38504e30

Last test of basis   174412  2022-10-25 17:42:05 Z    0 days
Testing same since   174424  2022-10-26 00:12:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chasel Chiu <chasel.chiu@intel.com>
  Nate DeSimone <nathaniel.l.desimone@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   56035d1c8b..26638d2aa3  26638d2aa399e436f47d629f877e581ed402020a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 04:30:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 04:30:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430332.681899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onY3U-0001ms-LQ; Wed, 26 Oct 2022 04:30:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430332.681899; Wed, 26 Oct 2022 04:30:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onY3U-0001ml-Gq; Wed, 26 Oct 2022 04:30:16 +0000
Received: by outflank-mailman (input) for mailman id 430332;
 Wed, 26 Oct 2022 04:30:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onY3T-0001mb-Fr; Wed, 26 Oct 2022 04:30:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onY3T-0002Ao-BZ; Wed, 26 Oct 2022 04:30:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onY3T-0001vo-0j; Wed, 26 Oct 2022 04:30:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onY3T-00073m-01; Wed, 26 Oct 2022 04:30:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QW5ZLjPbjBHFS9PiLzhXSyJp4VDFilDmOAkLjki7CRM=; b=bmY5e6hrPbjPhKtbvRbE2rBIYl
	9UKQK+ZC6pxIjWV2URvAMwjchmGZd3h8JfS6i0WAnIUFkzRIedXwXLVnrB65spdOYTdxljnC/gUcl
	XoDi5ilr57MmD1uekHqdPWzZqD3IAMC6frMWOOpgR77xZBowBt1CbqRmppdMOL/4fdYY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174367-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174367: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d
X-Osstest-Versions-That:
    xen=73c62927f64ecb48f27d06176befdf76b879f340
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 04:30:15 +0000

flight 174367 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174367/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174285
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174285
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174285
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174337
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174337
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174337
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174337
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174337
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174337
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174337
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174337
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174337
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d
baseline version:
 xen                  73c62927f64ecb48f27d06176befdf76b879f340

Last test of basis   174337  2022-10-24 01:51:43 Z    2 days
Testing same since   174367  2022-10-24 15:06:52 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dario Faggioli <dfaggioli@suse.com>
  Juergen Gross <jgross@suse.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   73c62927f6..fce1f381f7  fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d -> master


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 05:57:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 05:57:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430343.681923 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onZPI-0002sN-38; Wed, 26 Oct 2022 05:56:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430343.681923; Wed, 26 Oct 2022 05:56:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onZPH-0002sG-UX; Wed, 26 Oct 2022 05:56:51 +0000
Received: by outflank-mailman (input) for mailman id 430343;
 Wed, 26 Oct 2022 05:56:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onZPH-0002s6-CQ; Wed, 26 Oct 2022 05:56:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onZPH-0003qC-BX; Wed, 26 Oct 2022 05:56:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onZPG-0004Li-Sy; Wed, 26 Oct 2022 05:56:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onZPG-0001x1-SX; Wed, 26 Oct 2022 05:56:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xkHFjw+PXOT7fKYJZcOuyyhcCxz7yaQyLQLzmKVLB2w=; b=nQQC9Ev0nFqyc4QVbN20qkkTpF
	JHTLLUGjgnseoGEnsf5MLSgaLFOB/tRiKBs+A1YcWlPmMc1xK6yClcLUPzF7X5yLMVf7lpdOtGzFI
	2c67mSYlf8RA4JGFaAlCyp1/s4OZZQONXENx4c0DpGyJPf6JIzWo+CKQHwP7enK3AWGQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174432-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174432: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=9e2c88b16ed3444ea9dfffb39a91d6c17071835d
X-Osstest-Versions-That:
    ovmf=26638d2aa399e436f47d629f877e581ed402020a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 05:56:50 +0000

flight 174432 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174432/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 9e2c88b16ed3444ea9dfffb39a91d6c17071835d
baseline version:
 ovmf                 26638d2aa399e436f47d629f877e581ed402020a

Last test of basis   174424  2022-10-26 00:12:08 Z    0 days
Testing same since   174432  2022-10-26 04:14:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Abner Chang <abner.chang@amd.com>
  Chao Li <lichao@loongson.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   26638d2aa3..9e2c88b16e  9e2c88b16ed3444ea9dfffb39a91d6c17071835d -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 06:47:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 06:47:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430354.681949 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onaCN-0000Sg-FK; Wed, 26 Oct 2022 06:47:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430354.681949; Wed, 26 Oct 2022 06:47:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onaCN-0000S1-8G; Wed, 26 Oct 2022 06:47:35 +0000
Received: by outflank-mailman (input) for mailman id 430354;
 Wed, 26 Oct 2022 06:47:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onaCL-0000PX-85
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 06:47:33 +0000
Received: from sonic306-19.consmr.mail.gq1.yahoo.com
 (sonic306-19.consmr.mail.gq1.yahoo.com [98.137.68.82])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f7882b8-54fa-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 08:47:31 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic306.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 06:47:28 +0000
Received: by hermes--production-ne1-c47ffd5f5-kmjmv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 636de0ff1881defd5f865b248e2c93fc; 
 Wed, 26 Oct 2022 06:47:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f7882b8-54fa-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666766848; bh=dLXrJkyiqsIYSywqKcL7l1Em1BNR45sfHEGx1oxqiGw=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=Lyg5OZaRttFnGNg/8bmNuJi3/0BI1FSHLxUoy212k4uVw3EMytYYX57pmxmjxb04ra8TQejVv2wVVgeAvZieBPtNADbv/cjV67Lqt9cYvIkr6V5y2yoAujMVwKZ/8yYCENFTSmsFEfYv0Ko8zbhdpFnOzd4SclsfQC6bvlRsWb0nOE0GBLvB6DMHbngGrpO3cqIlQJTatFUlcTtStWcV7nOCUUi+8/MMSmRS9gBl6PvKu2GjR0jWGafiVRAhwvOTw9JAhUi714GRG8FPg1g/ZEvLlc6N0IT+TQSYB9HbkqvCyEhOizIAIyX1QkUJNDF3xnGkKbpgZefMEnbtoY8Szg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666766848; bh=DZIOPkXCbwnwejG//h5zhhHCiMPr/e0DijlWUSFDkh3=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HKaO0RPdCtti4skngDL5fhvvVcDLQMZ77m2sz1dbeVifY3PsboP6fWWqKEEs8jhh1Xo8viylKmlYeO6YE4sTMpsHfc5MoVnF6TarASEXxvWELxmwft8SkCKMqJQWM01TWlBMpxGED+2jBJxaneIm8uxm4/A2H3Uwq8moICJgfewZlemVaP1ZTeeaor32fzddfb8XlI9TInFz2lMKVbxiiRN/J4r7KwrxKSDhw1+foPyxR86Q1ZREq+F+8K0zU3y4Twdc4kuxEYjezejhjiVUuREGDCPwVvrs36Ypy8yA6zJNZbaGnjPyuPbAizGUXTIcxIEfk8EfeC4Al+8CeA6HlA==
X-YMail-OSG: _iZutSEVM1k_8REuJyjNnB1PBvx8Y_BrUcP9ZE0sP6dy2yhL_on2SJVSbFHHzHt
 vuvFelI9Inu5a6iJFouc.OA6JsFTVJn6dQIpxjFC16qcJPgpqbzXnFW8my5ka8BhqlQ.nIBSZTvx
 su0B7mgyMyEkFU1wPbN3rFBMzN3XBs2WOP8oPuL9.1BySJk_C4lCCMKAwIEJxIpJzMuHhus8_tJ4
 l3RGCNoaP_OTxpyNCR4TrBCgU1tAyf.wjnOa32SlivgflXX.lTJASKpESynFtW6Q7pw2GCxQDJub
 oMpF1cqrDM5gJL89nlnJisbE_TauLvpLkn1f1Tlh_Lz10hOYKbNjNWbI8v5uUyClAkQwQ7wOCFMZ
 McBw7rFHgkrdcSW8xqqNS8IwEIt.UZodj_urta9rRJ77RY93UXsv3WuSZj8W059kReesOoCl.fei
 qEcnfLoV5cUVMqmuka0djhbasIIMtqFwKSx6pfpTF0U781aDBR9pqfOFlgC8PnCNnc3zAajM6Cr9
 lguStnZNLsEgHXzCtj9IAsCVpO3kynErllBccdB9z4Vinx5sycllTAGBcm4h0Fomkus27N5jLUeM
 l3ih0i9JLpz2PDH8m92h6qrrPJYSkNNOiTCJdQLwK3beNG.sM7K3qw027OJaMxg5N_8hH3X4JvMd
 JMSjR_y2I5kzvQ5g__Fw29.M2OCQAYkftaW9eFsqLZxYK6N1m_nyO5nKQVaAvZlAcXtLitAMepFr
 MDlnprWVBYASLdKunhM_h95SkH9iU9gmmancQNu70ATknBuek_qfZvV6eScZqIFi5134u_0yZL7E
 uaiJ_9M9w4UnLj8pHq79pDKRNU8p6UwxuQ.QZ3qhc5fT54r_aDt6jdgdGIgfPX4BGRjg1g8JfKKJ
 vW0comVOnqq.eWM.H1EHq7WXeMILh9aI1FZHI5SpC_onsz6wT7K4C6cEQ.vFI8W.A13B9vpoW64a
 DL5fk3uFe5TnHtRDf5ktC3XpqNpqa4YLjIIEk8vlrriXp2gptiBnMgZkh8OIxJbWkyERes24SPOg
 IBq2QNhvBgxfNKelqONpLjs0wiPmFTmXpfdtN.z_uUybmIDzCiACjST5r4YKsVYOWmOrIsadTOFl
 zlr6tSnp5BQy84jRkWGm2eJr6YklzXnQ4_4amYgBhb_0o0Gw8qHjDW3pXO8mAWnjGw5fhCLUk3wn
 96xr5PrFx7mmK5Wc_cvBamTJ3BkkfNV7NLla9dTc40FnrX6cytJ0z3aGWV.H0Lnkuuvbscnhmtwt
 Cl4_IvzkYx.7V6cd8.cQA73D5ETtJubBAAEPeluARv.SqfJyc_1qtkHUdi62bgbtj_CiGLXi4QJ6
 FIUr8W.wF3qwCS4ckTteYPWXJ0NNnMPv4LW1riaxftxwFUOlfrpbSHwFfCRKoaMEqsCYlUnyaTJI
 m4Y5k9eDtdxQGWFxuloohedP.J7Gc0gy8AXXs4..cBGSYtCHC4VacJWrxuUcpkW2XBDpBjNuT6OC
 MTXzUShiV0L2E_mcvBkkXaxsafkmUHWVYtGKbiAjWR4uZjRI.pULSHoLb9iYTx1DEeJSWI2dsheA
 H_mU0lymNGXoCvXExwZyBIevxkl.q9_pEG261PqvXI2MwJSczCuSF4r7CjBhdVB087yJG.v0dAYU
 wUfAneAiqlpj.eSl29a4q0ye93L3wMzQz3XbwzLA5JK_57tRw2KefSiJzIEXflaDDB_GDDH7QooY
 C1md3WKuhQPi.sOva3Yj0ELU6NXGrTEfhB_gD9SCGwa8QRhy0PKi5BJotXQzlzhuiFDwtSW9f2jZ
 DxwOViF1QL8ckvYVtuUqXoyEJ76QsHqdNDy2PdQx.YINd6Tl_1Z63PAxPkiZvqnpe8_1jNMd2WUe
 8v2HRz12dCDS0r.GweCr5T3vZnX9ax.SowAwfbOoOIBqkXlCnVCRKQGHFi_T9ZiVOcQrhhpZFi9k
 EnfNsSZkZzT9yiuo0PSYQN6g.8FKhVB0QjXzV1uUzDq2ssqie78uHKSGw6Zr_PTbt9aP4pOF7.2I
 K6R3_tmvmc.9Gxmstdifu82pepzxTqEZQ.6UP5GTcal5MytbsV2SWUntuPTQFJzRFj9xl25JcX59
 8ErYxWl3aZKntC_F0rXnKV5ZxcdvBsdP4mr4NS_iSwanhhAkob9IbjaTVNjTey6P0gXDFXt5MEQ0
 pLbFMTKAEfm7elaw_BMLeEFTz2zCjv3LVKeaNay0P0sZtnsRrnWQMiEs9.ON1N7Rr3WY8M8Klf_c
 x
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Chuck Zmudzinski <brchuckz@netscape.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD
Date: Wed, 26 Oct 2022 02:47:06 -0400
Message-Id: <cover.1666764146.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
References: <cover.1666764146.git.brchuckz.ref@netscape.net>
Content-Length: 1587

From: Chuck Zmudzinski <brchuckz@netscape.net>

This is a series of two patches:

The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough
configure options are set with when building for the linux target os.

The second fixes a regression that was introduced many years ago with the
upgrade from the Qemu traditional device model that is still available
from xenbits.xen.org and based on very old Qemu version 0.10.2.

The regression is that the Qemu traditional device model reserves slot 2
for the Intel IGD on the PCI bus when the Intel IGD is passed through
to a Xen HVM domain, but the current Qemu upsream device model does not
and in fact results in a different slot assigned to the Intel IGD.

This behavior does not conform to the requirement that the Intel IGD must
be assigned to slot 2, as noted in docs/igd-assign.txt in the Qemu source
code: "IGD must be given address 02.0 on the PCI root bus in the VM."

I have used the second patch of the series for the past two years with
no problems. Without the patch, the reliability of PCI passthrough of the
Intel IGD to a Xen HVM guest is very poor, and in some cases the guest
fails to start without the patch.

Chuck Zmudzinski (2):
  xen/pt: fix syntax error that causes FTBFS in some configurations
  xen/pt: reserve PCI slot 2 for Intel igd-passthru

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/meson.build   |  2 +-
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 5 files changed, 49 insertions(+), 1 deletion(-)

-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 06:47:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 06:47:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430355.681965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onaCP-0000vJ-IH; Wed, 26 Oct 2022 06:47:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430355.681965; Wed, 26 Oct 2022 06:47:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onaCP-0000vC-FG; Wed, 26 Oct 2022 06:47:37 +0000
Received: by outflank-mailman (input) for mailman id 430355;
 Wed, 26 Oct 2022 06:47:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onaCN-0000PX-KY
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 06:47:35 +0000
Received: from sonic311-25.consmr.mail.gq1.yahoo.com
 (sonic311-25.consmr.mail.gq1.yahoo.com [98.137.65.206])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11444c48-54fa-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 08:47:34 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic311.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 06:47:31 +0000
Received: by hermes--production-ne1-c47ffd5f5-kmjmv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 636de0ff1881defd5f865b248e2c93fc; 
 Wed, 26 Oct 2022 06:47:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11444c48-54fa-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666766851; bh=ONSTUnovoeWnNbxOoaE6+yTq1iUkTDrGtK1eMs5++KM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=E4HBLAir0tWYpE8ai6J/4DOiDiyAdbLIlzjdErYl3dVJCLYfXKfNyZAk3//Cdk4zgo9/thT7YJjSPmtXzjvOM91CcxbMozlD8hx0eB5DZxDCNw2g1HCaJLq5L0UInsHc9bQN6tuFeHjRK/tcHqh2hRXPCgwbuA4HRBkcNyJ5FcBBS6StTcD9zhuu+dMRwOM9Q4uhBNXq9pEdV+qGaR55Dt4OKiOcv9WEleP+1ww+U3tbTjcIaaNjfruJY4qQlKfFckzCLbpdr9+dmx4fV/TVibjGJtgGbPTf358/lp2+CgDOdVyKLpcGoq/WH39T8mdbGPSV18pcA/aklVYeQBWBPg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666766851; bh=0mP3iOtuO/3KQ2/gcn+xJtP3dsmvYPLDaFVZasLlgZf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=GSxpk23VfNm/WgShvNeaEn9AGw9bADjpdnDmJh3iAQ3CvugLpmOnyqz4PdIyi7a+bwTuorwvrlIQM6lRZ71V2uX2PlGNR5zLXDm9ZdI5UHd7qU6tvUU98GIYnWpVk3f8ok750pNLlewk3XMVOraBDcRIx66q/1CRB/yt2d/AXiBvLT7Xuk2YdJz1yyslbEmRvNaZB3Mu+6q8PYF9WsE+VWvyb1gqwa9G0JY+0ClMeO8ygDbIGS9gy2EUT1X1iC8a8h+x9/AVepATSZW6K6sy+z8H7UxbCTPAeJpcveyrRFW0dVAaw/g+GNLXySQubYeqWJoE3lEu+6ghDLJMeBg2dw==
X-YMail-OSG: qM3XLeAVM1llGWhcZRaWVdk290YNclP8zFuMfQHHT5FUWJLlQOsQqpkYLL3s07d
 qp3woHC8gEdqLmGzzIU2Puf8IAkjVBOFLbFHuaiB_VJWrhgodNsc2jsa0ajXl5ApT4DltBFxSCm7
 _isb00P.ki04vCEYsIWrlRge3gmqp1vea4Y7M.42lnY4AedkLGbRXt6HgwbjOfm.RzV6NiZNi9mt
 P5kk14m1lwXtHQAVdhqeQhwSYK.HYtVxKQtNcToR34ZxndBnyqBfw0eSSSsUjbU65GlZQkfC546E
 _fjs57KrZa1rzJ4uNHu009qOddlXXepgd4.IXP_y1s6tBztiPbch.6MR1hUgSyMYRThnf3HwBjhV
 PtJ0DYS5GV9r3OagzC3zDQR_rk_tSyy9mi9IU9P1wHSBCjIZf9CCle1Ae2k0vXdMddarW_Vx9Tkx
 ick7Pg4IGgTXCZzoxX6TMEoKz88sJHZFhv8nPFzyTKBKxSGgMK76mVhif3LkhkyCPQsRztrHLeGC
 khYYQiIvKNu.Jx.fJF8aqKYpr.89z3RFwdzM5u6cnSI3OYgwWQYUpjeRKOZp_tuEOt5tWQutsNex
 _cPXavsEBZ3MyGAPI.hfUUSY6ghe54tZ7tboBXAW8Fpik6NBNvkeTUcV87oCYgqiHekvnkDNrZBv
 DNFvMHuz9WtoIG4e4UD3ZFyTFKmF3hvFk8sAMLngqF_AKLtqAOgPYHpRPO3QS94QrnUooIIQnCNK
 J51KNLA.1QAWPcuh58oGgEoQ0HIDf2ZthVyt6bZHG8K4nxGcroczLzZhSkEDS_2QLlZ6du25c_Mn
 cTYaMEo_3Ja3.h559sNxtiSgaPJVDB3okWBlZkaJUHFIaMd9EhR6B2bFpDv3_IEATIJUhWacGXPu
 7SKbg.6O3I.as06RoFeyRmJ3zbXkIl0soqXvBkJl5Be38Draq1e6xU9Qb1o.lQxrh7A6xw8k0eAe
 6SoxtB1HaHI5Cyb6eOftREVSZdrPspEFo5b3mPvw5zKRbPZbD.lyTb3x2ON0D8WxZK9BjTIJoRDJ
 DvqAwjPlChjINfqOA6uZZtU1OaFzgMB2Vq6Fk0lTmnKLlXbILj.tfcn4Y2AT7BTFVhQPZ1wFfsxM
 zShU7SIhWbAkJkJkEjX.OOgaSjQWspcaJky7FuhXEFG9478UNgNBYAsSRgItAak8DQneUv87Rl0f
 CsDTGFUkUazNqvOt0o4x3_9k9QAXns1IeKA1BMuh5QCrnanXP6WMHq2O_83hOby0TToqXUz6DaM4
 XPnnFtWOG1w5qgk9NoXIkLYpOjQOk.hWwqDpD73KEuwJGkCFJqJiKxi8OnFzSBkWcFSTxENF3_O1
 A79BCEOLLfKsSL74EkH.q7dqm1KEP3nQqtafR_OPAKyfVu8nVdhveUoJjwB4T9o_M6psHQqIgs_q
 qmzk.epIRWrrpKf5_gbGNfKATxQf43U9Ws9YcmzmBwl2mCQW45sbdOOoeKuNh8fatVkVmmCCXwFk
 vxNIsjvgRoj9mykP8FQA3zdEKmv8AZfyw.aXFfhEwdRyMx9LR7yXaY2T1QSmoHE.TTo00bGwnGDK
 FrmMEAMB8iU.peYrvLrvVZmPdpb4Tw40gh8licK1wSv_ze33aktdxVYUPnFyldhx_uRSi_57aQlE
 Qn4GM44NulurGr0n4BQX_pdalFeFkF74Ab7EOxtaKiR5T1tFGcDioUERpKNE0XTb3x0ptnRotfos
 ISKhHtAmSZPBgzB35vPHEyJUUGfkQaqv9vKtNg9I2SMATkLAzFze46EJmxeFBs87gApnx.pcnjZu
 hL4zY4QbcXLLpIQf8SkgMtMMwEmRPX6QXsKxUT5eyGClhMXdemCStlLXytsTrCZkiiYxYVzoBvp_
 wHEvZ.XM6jXvAwcUHUjQc46DuVSv_QTkWfSAbseQWF.ZtsaDcabEvS0J47To9yET.sLBqsAIuxRv
 dDtJwQ5Xe68v41Z5VF4rLdiMFY.NeoSIuDOdpgqOwfOLP2LbmWRzsl4GbZPqCzs9dllE9mWaQYLM
 cB9swMSKjbMbL9hoONz9apmzPAAsIE2Jzm1ZdvR5e44oNnp.mUvppR.Gt82RueY_4YlrDWhU0wSy
 y4IbsghVeFS7zIFM3.ciaAbwbZ29jpPeK2zYRcgdzmWgPxixvxByFeXECFtJoZYjhuZShkPshsAu
 _ZjXGD.8tR4xj8UwJH2Dh.VA8bRlfU.z7GjTeg4.baOadCKQj.ElrMJuNbeH7i5fHSq3wUC8L0Fw
 dMoz1A8uDWbSO
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Chuck Zmudzinski <brchuckz@netscape.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru
Date: Wed, 26 Oct 2022 02:47:08 -0400
Message-Id: <1b98334dd30af4a467170237c8a31c1824ee9c37.1666764146.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1666764146.git.brchuckz@netscape.net>
References: <cover.1666764146.git.brchuckz@netscape.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 6999

From: Chuck Zmudzinski <brchuckz@netscape.net>

Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus,
as noted in docs/igd-assign.txt in the Qemu source code.

Currently, when the xl toolstack is used to configure a Xen HVM guest with
Intel IGD passthrough to the guest with the Qemu upstream device model,
a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy
a different slot. This problem often prevents the guest from booting.

The only available workaround is not good: Configure Xen HVM guests to use
the old and no longer maintained Qemu traditional device model available
from xenbits.xen.org which does reserve slot 2 for the Intel IGD.

To implement this feature in the Qemu upstream device model for Xen HVM
guests, introduce the following new class, functions, types, and macros:

* XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE
* XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS
* typedef XenPTQdevRealize function pointer
* XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2
* xen_igd_reserve_slot and xen_igd_clear_slot functions

The new xen_igd_reserve_slot function uses the existing slot_reserved_mask
member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using
the xl toolstack with the gfx_passthru option enabled, which sets the
igd-passthru=on option to Qemu for the Xen HVM machine type.

The new xen_igd_reserve_slot function also needs to be implemented in
hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case
when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough,
in which case it does nothing.

The new xen_igd_clear_slot function overrides qdev->realize of the parent
PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus
since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was
created in hw/i386/pc_piix.c for the case when igd-passthru=on.

Signed-off-by: Chuck Zmudzinski <brchuckz@netscape.net>
---
Notes that might be helpful to reviewers of patched code in hw/xen:

The new functions and types are based on recommendations from Qemu docs:
https://qemu.readthedocs.io/en/latest/devel/qom.html

Notes that might be helpful to reviewers of patched code in hw/i386:

The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does
not affect builds that do not have CONFIG_XEN defined.

xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an
existing function that is only true when Qemu is built with
xen-pci-passthrough enabled and the administrator has configured the Xen
HVM guest with Qemu's igd-passthru=on option.

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 4 files changed, 48 insertions(+)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 0b1a79c0fa..a0f04ad62e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -402,6 +402,9 @@ static void pc_xen_hvm_init(MachineState *machine)
     }
 
     pc_xen_hvm_init_pci(machine);
+    if (xen_igd_gfx_pt_enabled()) {
+        xen_igd_reserve_slot(pcms->bus);
+    }
     pci_create_simple(pcms->bus, -1, "xen-platform");
 }
 #endif
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 0ec7e52183..ec42f47fac 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -950,11 +950,35 @@ static void xen_pci_passthrough_instance_init(Object *obj)
     PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS;
 }
 
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+    XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n");
+    pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK;
+}
+
+static void xen_igd_clear_slot(DeviceState *qdev, Error **errp)
+{
+    PCIDevice *pci_dev = (PCIDevice *)qdev;
+    XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev);
+    XenPTDeviceClass *xptc = XEN_PT_DEVICE_GET_CLASS(s);
+    PCIBus *pci_bus = pci_get_bus(pci_dev);
+
+    if (is_igd_vga_passthrough(&s->real_device) &&
+        (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) {
+        pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK;
+        XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n");
+    }
+    xptc->pci_qdev_realize(qdev, errp);
+}
+
 static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
+    XenPTDeviceClass *xptc = XEN_PT_DEVICE_CLASS(klass);
+    xptc->pci_qdev_realize = dc->realize;
+    dc->realize = xen_igd_clear_slot;
     k->realize = xen_pt_realize;
     k->exit = xen_pt_unregister_device;
     k->config_read = xen_pt_pci_read_config;
@@ -977,6 +1001,7 @@ static const TypeInfo xen_pci_passthrough_info = {
     .instance_size = sizeof(XenPCIPassthroughState),
     .instance_finalize = xen_pci_passthrough_finalize,
     .class_init = xen_pci_passthrough_class_init,
+    .class_size = sizeof(XenPTDeviceClass),
     .instance_init = xen_pci_passthrough_instance_init,
     .interfaces = (InterfaceInfo[]) {
         { INTERFACE_CONVENTIONAL_PCI_DEVICE },
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index e7c4316a7d..40b31b5263 100644
--- a/hw/xen/xen_pt.h
+++ b/hw/xen/xen_pt.h
@@ -3,6 +3,7 @@
 
 #include "hw/xen/xen_common.h"
 #include "hw/pci/pci.h"
+#include "hw/pci/pci_bus.h"
 #include "xen-host-pci-device.h"
 #include "qom/object.h"
 
@@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg;
 #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough"
 OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE)
 
+#define XEN_PT_DEVICE_CLASS(klass) \
+    OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE)
+#define XEN_PT_DEVICE_GET_CLASS(obj) \
+    OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE)
+
+typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp);
+
+typedef struct XenPTDeviceClass {
+    PCIDeviceClass parent_class;
+    XenPTQdevRealize pci_qdev_realize;
+} XenPTDeviceClass;
+
 uint32_t igd_read_opregion(XenPCIPassthroughState *s);
+void xen_igd_reserve_slot(PCIBus *pci_bus);
 void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val);
 void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
                                            XenHostPCIDevice *dev);
@@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read)
 
 #define XEN_PCI_INTEL_OPREGION 0xfc
 
+#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */
+
 typedef enum {
     XEN_PT_GRP_TYPE_HARDWIRED = 0,  /* 0 Hardwired reg group */
     XEN_PT_GRP_TYPE_EMU,            /* emul reg group */
diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c
index 2d8cac8d54..5c108446a8 100644
--- a/hw/xen/xen_pt_stub.c
+++ b/hw/xen/xen_pt_stub.c
@@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp)
         error_setg(errp, "Xen PCI passthrough support not built in");
     }
 }
+
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+}
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 06:47:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 06:47:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430353.681943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onaCN-0000Pq-4S; Wed, 26 Oct 2022 06:47:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430353.681943; Wed, 26 Oct 2022 06:47:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onaCN-0000Pj-1J; Wed, 26 Oct 2022 06:47:35 +0000
Received: by outflank-mailman (input) for mailman id 430353;
 Wed, 26 Oct 2022 06:47:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onaCL-0000PY-Do
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 06:47:33 +0000
Received: from sonic312-25.consmr.mail.gq1.yahoo.com
 (sonic312-25.consmr.mail.gq1.yahoo.com [98.137.69.206])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0fdfc98f-54fa-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 08:47:32 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic312.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 06:47:29 +0000
Received: by hermes--production-ne1-c47ffd5f5-kmjmv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 636de0ff1881defd5f865b248e2c93fc; 
 Wed, 26 Oct 2022 06:47:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fdfc98f-54fa-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666766849; bh=ny7owJa2RxbGuwayq4FQhxBsSVH0ukbtIh/FIB5CtGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=CL2obzNVzt/rKJmuzVYOGdQ8Kn1d1yMZrG2uHlQXtAz//NYIJwS5l0IDGrDPLTx9h7cXc85vg/xfb1BAqx5SE2wV+NMgY/SdFqEI5ibwr8MiouBKWY9Q8O4+gc9ONIPG6CALybaJmHbvT8GRtM4/8PuMvFoR7MgIAUfIiKYQO1RWykuIknzwIXnJ9rqWJepNXLyXTC6AeEHTN7eRCJ6BUW+JonaztqNCu1vw5T77TjWUvXixFJtkHnRZXs8k3sxwpNHo5dZC7N5njiYL0+xO6V4MChRtie10EAhnHyCja7DM96VKu8Vl0BZZi/OIbLUEWxPRr0b+8rkRF+MvZmJO0g==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666766849; bh=43KMNyXrtQtnI0ETe7rDIkw9N+CEwpTmRLuodKWNxiO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Fp8AkV4z9C8IcGLMaGd+26g3sZklbNV1CFNuR1EwQ71iqOxKyLDuvgCmiPrh9WQY5Y2LdtCNGEnE5wWYusZP00UaXQl2c4YpwY4KozTyNuazqgwSLeLMshowQlK+S1z/RVXYGfNg7zNa+JAl2BIHlXTk7zUExkOdTzCHjXs5XHW4dbzFErvmq4AJxsxa9sMOlaxL1RqwMeAd9c9sBOQWGok1duC9CiKOuLQX+7veiWik1yZdHdzPAjNUmpgMrdy4PIESGc0cPy+TP+EEoFULJ8Oas/xkODW494sFYDdO7uIizAuaugNWSnyjGtkthmXfaQLuyFakbjrvzSM5z6mHzg==
X-YMail-OSG: iaScSSYVM1kIj9HY.g9pZpp4a8.WVB4UO7BeqapWtqoUUNlj0tzP8eyPowJXjuj
 gSW634pCKGpiZ3lQGRitXX6j_rvSWUV5nRRGv18.0NZ4YayNhokTApBFi5HnLz5mdr94UTRIR8Wu
 I92JMO4fp06pU5AyVc7p8DYNvkv9ZPdb6oFTro0TIje33RAXHJUCuppa8FAL4w3H4Xq10w05ed7L
 GulyFR7keJQW5ZbjLUCFns6Sajf0nVHbyoN6LiLIxHNa382zzhyxMo0VODUe59Hih7i0BLgB7bkV
 l2K46tn1Gl6DZ30rsSTBtSSpRWsu9xY0Aoz8hHp3I1Vwrw9hmGSGfr3avGZrIx4Dx9xXjRhu_qqu
 B7mPHujqq9W2r3wO7rCEg0Ul61G28hjbPp48F0pVGRvOjmVndTCxsAJasFNvA.xXvKajkpwEFodf
 .RScefCAImBOzl21hfqfJglRmuqotJdqJ4ALkWBZcRWvEu4VePqWIor4rFBBThV9Zfs93XGgGmt3
 wc_DvYy1vWODup30urkwyrEjgBl8HREHGcUW2RJxa1yTNgu9LtSu_N37_0AUhfgVXlcwTfc0CJOm
 5zro._cw9jY2CNEXAEKdpdgtrbiiuA9mBBHxbMMrc.EDqitS9F75wvpCSjqEQ8VNxkkK6MmMRNbG
 fx9ere3c.Mfb8vlsh.sGwSRMXRrBsbHJPFCd9Tcbmz0bsucO6RsbhLR2J8LmaCiJRpp7z5Mixyt9
 yHUqrIHHFShoQ_m90rW4MVXCCorCEVggtub0IKcKC7Z_Yw9xf3j_hxjzUBFL6xcoegh3PTEd9fid
 1BKZ1bYRnsUiUBTEDlslPeGPugpSkkKz8AHeij84VNinIFJLHnsh9daHnvTPGWvlfPi4_SM0y3fo
 T0nlX2Cto3cTzPapvX5tzNqYIZ9UJcr4lbMiFeemT4TdlcjB1e7.bL_fr7S8uVjuOv3YCkL_VrKY
 2S1QGkkdzjfHuCsebe1X2LnoDWVJu9qIfkXyQYMIdqOI5Q1hs_um2lRCUeQ1ReISyy8ptqp6B0Wy
 Z4uSN1rUX95iheGPwl9XgwkLSNSoZGmYiTvDrvyA1WJ_T57vIyyJJVqPjj9I6q6QcejXSKpMWWxn
 IWTNe1gJu685Jtovleb043jVrav0Il4PmPGKW.tIUFuApk7HXUaimhX1lqW1kLOPKP5_xsEUz6Cm
 McRHzvbc680bd2jANqNnwwKZN7xp1favv0boreWT6u5U3ZcM1uE8S0JqI.EsRxfY9CBLXvIKfrYg
 wxqQ4YXy73dNxLR1w0Fs3GNQx34RDg0aMJcFYygRjiAS2hl7n_16esDOImR26ytm1DVRJSFXv_R1
 XJWqzvHMXRzK0lbYkJn9_tEDHni50tIeXk6TrPJTrJq09diVE1_fXMLitA3BGvnFs8f9_qZI_wz1
 vDrUYpxkcPJjorMJqnxSOgZH5K6a0ok3HZBbjz_dR9v4SNGAkG00MJ5hvxLBhOKqQM_QSnRU.s9z
 5ek._kO.1QqCYKAuS52H1E0a0RAZnTuqna.VDZW20kQXmh1BFy9_Nd8nYUBrGMeD99byuFON5_H7
 Y4woRpAZdOUQkKhYh8uSCFTkjqgfMUV.iDKkjjTuIVuMO3fdp.65_NB.DQLKK8aOJ9HeVtcqVc.o
 L3AVLfivBkTwUHB.mGg4aogWa2fZsnYlqBfDYywUpnkW2RBMYlsbJgcxS0uEnZj5KJPOje6n515U
 INAgydaz0gc9BAzJIaXj3qydUqt9f777kywlzIoIfG5hf1yJ0gIE.ZE1EjOy1WjShswL73xptf7X
 MbZA_TzWmeHioglNh6wCc8wxO265nIfrt3UQei7hrk_DiT1X50IDH36PQoDarGPJoTNimO.9yvTY
 xqq8D2eoWID_WV550HFMV4DvzSeTlh49bcqqgKFqOKEjpejmAN_q40.TE5yaZheq0rFzH8H2oSOe
 S3dd5TVYvwKT1u8i76rT3xrolID1XGbi6jE6Vc5B8DeMsQdVdRviUXl2L823kHgB5iqLSYxaI.4W
 h2L_C5FtvA2x3CchFZVv1eDgWdrrTGs_9cYvbjk_Wx.yokPjbYH.tEclhRo226IYnpOwCkWW9_cF
 vMbio0lJz5eUDoXCs7uZYAZPfIJbYLV3N..ZNO9Gb4yEgMEh5dByZ6anU6KqKGHQkB2JJ_SWvHR9
 2SlDHfvr0yHO96rzSUu3kCwm4QJkU79Dk0QV_EZ9OptjvX8CfdvKYjoJLfb6rfC5iHu9wesEp6lX
 naCtDNOA-
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Chuck Zmudzinski <brchuckz@netscape.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations
Date: Wed, 26 Oct 2022 02:47:07 -0400
Message-Id: <7a1fa15767e76155a4f78a1dd126c596bc24cd83.1666764146.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1666764146.git.brchuckz@netscape.net>
References: <cover.1666764146.git.brchuckz@netscape.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 816

From: Chuck Zmudzinski <brchuckz@netscape.net>

When Qemu is built with --enable-xen and --disable-xen-pci-passthrough
and the target os is linux, the build fails with:

meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist.

Fixes: 582ea95f5f93 ("meson: convert hw/xen")

Signed-off-by: Chuck Zmudzinski <brchuckz@netscape.net>
---
 hw/xen/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index 08dc1f6857..ae0ace3046 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -18,7 +18,7 @@ if have_xen_pci_passthrough
     'xen_pt_msi.c',
   ))
 else
-  xen_specific_ss.add('xen_pt_stub.c')
+  xen_specific_ss.add(files('xen_pt_stub.c'))
 endif
 
 specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 08:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 08:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430377.681999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onbR0-0002zl-E9; Wed, 26 Oct 2022 08:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430377.681999; Wed, 26 Oct 2022 08:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onbR0-0002yV-8p; Wed, 26 Oct 2022 08:06:46 +0000
Received: by outflank-mailman (input) for mailman id 430377;
 Wed, 26 Oct 2022 08:06:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onbQy-0002gT-Po
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 08:06:44 +0000
Received: from sonic312-23.consmr.mail.gq1.yahoo.com
 (sonic312-23.consmr.mail.gq1.yahoo.com [98.137.69.204])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1fc0f98f-5505-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 10:06:42 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic312.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 08:06:40 +0000
Received: by hermes--production-ne1-c47ffd5f5-kmjmv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 23da40615be2c6ee6a989747ca28211e; 
 Wed, 26 Oct 2022 08:06:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1fc0f98f-5505-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666771600; bh=u86QTm0cyxo38RdExErIu1L1spuQttzF9o1Vs1Vo7tg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=ZR2T7Z41SlvXc+rN1mES7UY4Bb+Ycz65QSQGyKE3j2N9g9YvCoyDkX1lp/BczMULbtRqp3/m9Nzkhwo9CrqvMnML+T7P0LKZX879HeuuxS4ipo8Er1YP0gas6mJZypw89JBgo9yrZKGbj2tO9Ou1MWAwptJQ/SOZwI5SXHXX5Ckh4Ft2UwlA7QrLsSVtHUZ78/2i9RINnIwDke7vs4XUao1fSCUlywYDr7U/MQWPhyKngylsFOiXX/RDHwukASBhyDCfLx1sPgA3IVqJTnHRF5oosq4E+IiVu3XkUT40umiQD4h9mQhjkRKvK2Q6sqZqDSUc+PO6VeFeJt022pTgdQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666771600; bh=1KYDCrNPU+/svpF5/W1oIG2nGvvX+6+8wbJ5ajoLPAa=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=CmMHkHepufn2Qll7JYXi01ukoER0p3TQJBYtcaEEOFoXdaNqIQR2FlmXg+V9V+MhMxVaz+Pf18Sy3AwPxhu3EUTc+tpfBeiBdFcUTMEI9mTBSmLWDPjIP+C4XYyltwJGOsfvSQQhx/I6CelrRiLTq4Q67imx6DjzFwJOuuN8mkCwUQurk979wEDbefGLqU4Gmsvjd9cduo/m+A00v6NBjMvrqPxW6wjs5qySlvUNzNAW/E7XLiE19NgQ15AHdrz27NntgHMtpCGd09yd63vvdIVWCALXewPEt1l91l//gIzWzNbr8vU5ci4SeZAb/7gFlmnjtaqR32Wkdtwkl/b58A==
X-YMail-OSG: FapNKEYVM1lv1c4logrdi4PSEeumlxN3GcGS6oPcjD4QNjayXQlSGXC0ABtI00R
 S8hAfLaiOZepETaAjHrZt5yZ0TZlhEsQSEtZN28JPchpaKZjo9KbHHhGKR5V6CCGjJyFu_RCtSjs
 JeLCGwB.QEvK5MZXpqVY3AKucf_JoGQ3Kkih8mW2O1iJJZvbY.479NrhuOfwpDmve7lcD1wUaG5a
 Ke0zSmxvlQ6myCrT2l_3fWCsJKHmAOmT0iXc4t2iq4ro4ephYNivT_Xlj_BlVVDexTtczgH6Lpq7
 gCln7XTnK97gwAINXgK8joOBTZGwBMSP1cS3xIawApqH9QWHhEdOnxyDZjyNIchJooPNfI9aFESV
 7hplrDlG76Y9p_oWVoNNvx2KPNkfVl2oZrrgpUpIcpCBdSYX6qhuo4gnuuKiKPwo86_KtDn7PZ3N
 eSPTEtlRV8lazRwgMi2bHo.ud8wfu9Bt.XFcDV_Ch5.xIiNEycB78igXsAJJa2xo0qYUbVXbsjkJ
 6z5o08OSXk4awNE28NVlg7f0AJrrpgIHElO6u7LdYyxYRllbIZunryZMGRXigUcmzjvS1_h10ZNd
 nrNcOlT_oEY2HQMn4NYJx3bwbqgXbv72br5nj2ZChrgZEp31LS10xD55rAWyVgsZRmjMiv8jl10u
 IRq3jgobevUxC75pvE69hwGmcuQSnwIHrLtntjRxbhNNQGxe6wJ27dNtswl5IzSJW_zX9xbId3tw
 VIPUbH40mejBfPHx4em.cG5ZB4oCsQTpXhopbR3XO6kjyh1GoVhfCDuVTob1Fm4VhyNFpjSoWE3D
 6PJqMfZwnpSiIO8EdjO5BVIrunOlGjDBLcW1g0mMWUGUzx0.5_wkE4lJJm534vtEyK8jcTh_mELj
 Jk5dm.NJ1isN8N5mxbtsl3sF9wJrsFho1.w.wKXjIwIHO14OQJUKHfgwgs1xwVRfohM9sxI3NnCi
 jWCSfe6PNPCHG7.SpivTZc0fOcpmW9yOIueW6Mh7HWVfd16HFdfBY7tsNtUGQNlIJOiLwBHIpUuV
 m3f.DrEeNctsM5ZeAhDYheii0xveqHRxgbi25Z7uC4QbWPn_7K3rbuOFe.XLsHCk0F.PNASiCII9
 vehpK7j1ZLxqa8uMxhyXPoJ.QObszDqXdboZ8ju7cvNuDrB1aahl1ga4MjtOfW2hUqTQ5mK2IMIN
 bY0JKypYhxbOZ.oSL_DtzGOMy6xlHH.qqopkqW3ZML7C85r4AkQzIobnnWzn8OXVEcA_AXRV9eiJ
 Bqawf.Vn04qAC0M2cy6MEhkRICBIZuXLd9lepKKlugQUXv6Mt9TCB_JnTQZA.7k_FZ_s319LKLbM
 4uSNxbaQunnYTaBg0mI_PJN5bdDgJQ1_Qi5egCd0k8M1NFxiT5jOPUwIbX0HCW4iwJD9bf5K6o93
 n.DqBkd9IaMozwg8BqUHCaYfd4DvHk7Ktq0lNcUyUtRtR5zxj_CY73kT6gcXxypGIZPYX_r9XSUv
 cun4Av0DfMyNtTlBRa8PnLupA2hDKLDUpicfLzJRnVfAwkujtCVUoNx87k28TkSjLaHmakXgTD_h
 vJl7nXv9f.zQd2T9osYa_zcTRLgL1a6FpS8SFxAay4Udpike.vWRW7g4BMVD6pV05Xr8BqckzM6w
 3rNFBvpK2sja8a_0QGqjk7jlhM2KE0kcPOTEp.Sjw68ZtUAb8Oy4ijw49o2gJbu2CfPBGuj4YNMq
 vokZZorvKJ.fUmSrakN1DwW8SkAoo9k6tJqa8bIEyjduUZutijxjo18TyBzVpfi7vBfFoADo.LGg
 DpSRb4W4TEysRf6e3QbB6RA8ggORrgIAw8cHdCacRsbebkE_acnJPYQqlKtHcgb2Un3RsTghntwO
 aXZK3D95b6Rb9xVbVil2u1S4XKcWrwU79R.7oe18j5nXP61hdzBGv.P33.DlVji4pCUkIrYr3K2a
 wWftXSkTI8JuELVzXrrbtF4CspjSfkYichlXgouH5IRfQL4vCT6lTyGqyyuYxUnNVC.hR.MkiAEB
 duUUH3Xzo.eiujjAsh4cZWFUfaKRly06C2zgrL2f5s.pNliplKDAVXza6ixehxvYRqIvrivGgrdM
 6ohOlEUIvzcugW96JoH0RyuCMl8qO_GA9cPazBdFs832Tn1xu4JBd_M_YzHikxNQGw9ysp8L27OZ
 fqYCrrCt2EZUyG1DA.jR9MiEgKsXeu.FWQf12i6uJiAcczytH4JLJsl1l6fKRlMKHo24oTEUDP6.
 p5B3Vfw--
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	xen-devel@lists.xenproject.org,
	Chuck Zmudzinski <brchuckz@netscape.net>
Subject: [PATCH v2 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations
Date: Wed, 26 Oct 2022 04:06:05 -0400
Message-Id: <7a1fa15767e76155a4f78a1dd126c596bc24cd83.1666770888.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1666770887.git.brchuckz@netscape.net>
References: <cover.1666770887.git.brchuckz@netscape.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 831

When Qemu is built with --enable-xen and --disable-xen-pci-passthrough
and the target os is linux, the build fails with:

meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist.

Fixes: 582ea95f5f93 ("meson: convert hw/xen")

Signed-off-by: Chuck Zmudzinski <brchuckz@netscape.net>
---
v2: Remove From: <email address> tag at top of commit message

 hw/xen/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index 08dc1f6857..ae0ace3046 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -18,7 +18,7 @@ if have_xen_pci_passthrough
     'xen_pt_msi.c',
   ))
 else
-  xen_specific_ss.add('xen_pt_stub.c')
+  xen_specific_ss.add(files('xen_pt_stub.c'))
 endif
 
 specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 08:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 08:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430375.681982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onbQx-0002gb-Q5; Wed, 26 Oct 2022 08:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430375.681982; Wed, 26 Oct 2022 08:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onbQx-0002gU-NB; Wed, 26 Oct 2022 08:06:43 +0000
Received: by outflank-mailman (input) for mailman id 430375;
 Wed, 26 Oct 2022 08:06:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onbQv-0002gM-V7
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 08:06:42 +0000
Received: from sonic316-8.consmr.mail.gq1.yahoo.com
 (sonic316-8.consmr.mail.gq1.yahoo.com [98.137.69.32])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1e610dba-5505-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 10:06:40 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 08:06:38 +0000
Received: by hermes--production-ne1-c47ffd5f5-kmjmv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 23da40615be2c6ee6a989747ca28211e; 
 Wed, 26 Oct 2022 08:06:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e610dba-5505-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666771598; bh=5xrh+eQj0TKCY48VtCs3LUP/5HjMlN7+sNXMihoT/w0=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=dD3jTe85+Gt8zE8J2Xk/kHaixt0a/QgA4WJsG9ecjZ53Vb/vSuOA3GN7Rwdlk6HnuEZ8ZKr5hy4Ng4mfSolih2Vcrm1qSTHZf2DULvmp+ix6VRgSF7ToAOUoswFPHqi2+lmFgkDjGNhPyqVdlYIP0+LkV0FOjnloaf9y670fkqI2ZrJ6T0jimsa9lghxEOsIkPhXy/4tgAsXSgYThSSNSFBR78m29ote5j4SL4J28SomeJ9gaMip14vtCj79MHtv36/w8bYzeIPB+W517ZRVlQLslq3M0QDzPh33Er/fWi55B0dkcF555jlA33GVZePcCWxMsta4KmyDicvHKruTOA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666771598; bh=FaQauBinFig4hAkIRNDMa9WSUGN23QRygcriy/AUKko=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fYzRwzq/C5a2R8A3Dfss4kOdXI3KiROrwgxv1fIXZC2/EDgfOzIvVcmsf4+bKcRtDRQYsaoq9TxK3YH3ocdhq16fTa2X04mLobM7KZ2I2rmpmlxP0FqhVVofIIL6YhKaRjq+LVjFN6cB0DnICxL2MEUSmUbixYSqQ8zOVwcXcXXPyWlBHrMDw8vHhd7TCiN+yzsAvJBLz/aIwnkOK5coYtqBdq2MlXaPQPQ5zmxlDTac2TqKC8MRVaGXlH6fXgdeSnnHJ+vVoRdEYjgwWMH9TalbpDoe6h0y6QCykWrc4r4U81/75EkOlNyjJvWx4IwXgwvfuhhap4LSzDI7BVR7cA==
X-YMail-OSG: e4cAigwVM1kM3mVmsNS0gTFsZkouFLMQzxq8n0Eko6doVBqcrB.VFSkEl6rRxwO
 OEhjl5emjL9g.6ktVvYlT2qv4byzkF9HML4xEjxUtz_t_ZHEtm1uVXY8GlSPqJJM8QMndklhYZSo
 _qMkQqUEAEtDoPs8S7KOZJLYdJyhAS4IbZpGmGY8UVopGYHRtyDgMO7wqB_Nskc6BCMNrg2ljIw7
 paG2ZbMG5vHeQ46_GwGMkzXQF6CIeeDgog4XCKxZgG6TgXxhG0YaFpC1HidS_VXZjSJjsZDOIoC0
 mPBdLA41pHKxNA9r.ugWFcQf1.63_q5Fb.G5r6zNVbuH1xgC0mPP3N7vRAciv7V2O63SZgd6H5X.
 7OWvxNG5_t.tLBbn29wuy8b0Ygfr5jtCbNE88nKI7kAxU61pK.LK539jLM1.DGD.wn7Mw5flOIKA
 UOSmdMjswCujluRZJHTd3DSUBA18k3O3dDanOEx68Y6_kQSkJS1Rw68LUJ0wS3GJTxk.Ys2lSzWs
 1kc8w0czHgpMSqSQkmhRSoGrUoG553yjmbND1uXbV.HHtxt2axqKk_iWnwEwxFezvU3PHt_Yc31A
 53LPRzZnk_gQqIC6nR.q2kj9tZqOb6y0wxz3JOIZ5grMp9sb8ZPmxbPufrRJw4DRQNRVYttFKXus
 chPhlLF1d7lmv133XD6IKmyBU5qUkjglqWv4AHLLM4aB_axScexsFcclbETTrHioXE8gTanyAaaa
 hk6PSHLxDy043fe5p_omrS9fsMfbUqt8vNj4o9N0VWMkgBmsBqfW8eZ6zRcJgJgfvpk89bUtr6Th
 jd9r9uPmhYDJUedFb.QyS39IlFy_NKe9KSKgXBkvjQmUWwR_UJPvXNIcdxBeHe308mT4PqEXwn7x
 pJqgftz8YEu25CiKnybbvbiGBhrZc.OV_oQJufg32YHlykxnGvh_N5r7aenyvvee0DhOe04a11DF
 Nk.EauYr2nO9HJEvPSpyxYh4drTKtjL76W9Hl7Y1.5Nmlpii24ya.rvEHgXWufzfGVZgJpYpJeSP
 fXsa1Tk.4yY4nhu3jNzdSCsrGim9Vfbzd57VTeuDDuZ.YX3rlbWr_VC8b_2I4rm2AGCyEB3VHgsJ
 ucd2UPIgDfhKvdNxt1CBzI4Zex5p1m.IuFUuJfayJj_KCI8Oa2kyLuRNGLxluASz9bQNgXb1E57_
 KZKoGkdFuXnkSxX7mNGr2ofdMWqlJlSQEKP92OKHP6ADz29vDOx45zKxtyluzNCl2jBGg9Sgi6SE
 f7dBHWWfNfThgt_xZneDsdVubpyinTu8YZnkNDDXL2_F1XyyhPMAZc.3pfZQcvMdxysZJFsThyiw
 s62yfKEZ6eKn35O.mBV89Dkxa6YrXTaq3rhqPXi4I4ID3t3F4NtOVpxn.BL7zsYcl94oV30Fb72J
 GeCatqsAWM.BP2fGqJpXaqjhG_YtQyAJ6EfQc3IjpMNqqhunak.5r5jdtMdfHYHWjWyw9HkmLxAf
 k4le7xeRj4KJQZof97ZrAZq5b.zeL8Hgtb84DyBX0ocH9gucniLT6ML2DursxthVUq6D9Voa27G7
 LM1gNJHBA7MYUQVnBRw4nYjbl.xSUs7rvuSyDC4o1eoF6Up.XfKNf5mJgjpGqvp0ibRcxz5Z3Tix
 G.rwuxzFsnpdUVKWE1Tf1fzvVmyCJaPPUhdvx0BXupUqxi1P_TVVVz_29UNanAlKyz8WJdLq6orq
 z1_ghhjMaHHmRnGupHmtWY89NLgXhlgaCQsydM4tg3u1Xgqr8g2ENV9eDXNz3ZN0QMyYiJFh9wEL
 eVcfcLMFZRwibOY5X9c5yOM0KvOJx2DLE4NQIlsq7DPlLdWmdDZBBgQk2UiwvFSOZ2ERHYyesfdU
 tRAbgqG14tcPUFaUbQfoP05nHYHDmC1uNuBmO9VyNqxkP.43c1jk8XrY8iHD0tclFpgi0B_nMf9g
 oB0wVIPK904CaScQpybjQR73LHFhLZH0tpxEjtpjB2EKzZSuO2DFsnEwp7kJkwcK1UexGzuDxYhR
 gkwn9wXyv5LqYhEAKMibxpCFLO9rc100iYKE8XaeLARdpLKVRtZx_SqguR4P5pAYs3Q86CM_Y2m8
 0hGfq6qqiwNczxuvdjfQtX7XDCj1Ho1XrpASS3IP1JAncJhJ3mjbhShzSHZHdMIEDv4GmgQmSvEI
 _AIldVjYjxrmYQegW1OsqPllM7bz9O5cLTwnjyqZCIyoK5VKDgfOCleCeRazS0nW7xeoFov_OhyO
 fhYY-
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v2 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD
Date: Wed, 26 Oct 2022 04:06:04 -0400
Message-Id: <cover.1666770887.git.brchuckz@aol.com>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
References: <cover.1666770887.git.brchuckz.ref@aol.com>
Content-Length: 1595

This is a series of two patches:

The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough
configure options are set with when building for the linux target os.

The second fixes a regression that was introduced many years ago with the
upgrade from the Qemu traditional device model that is still available
from xenbits.xen.org and based on very old Qemu version 0.10.2.

The regression is that the Qemu traditional device model reserves slot 2
for the Intel IGD on the PCI bus when the Intel IGD is passed through
to a Xen HVM domain, but the current Qemu upsream device model does not
and in fact results in a different slot assigned to the Intel IGD.

This behavior does not conform to the requirement that the Intel IGD must
be assigned to slot 2, as noted in docs/igd-assign.txt in the Qemu source
code: "IGD must be given address 02.0 on the PCI root bus in the VM."

I have used the second patch of the series for the past two years with
no problems. Without the patch, the reliability of PCI passthrough of the
Intel IGD to a Xen HVM guest is very poor, and in some cases the guest
fails to start without the patch.

v2: Remove From: <email address> tag at top of message

Chuck Zmudzinski (2):
  xen/pt: fix syntax error that causes FTBFS in some configurations
  xen/pt: reserve PCI slot 2 for Intel igd-passthru

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/meson.build   |  2 +-
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 5 files changed, 49 insertions(+), 1 deletion(-)

-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 08:06:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 08:06:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430376.681993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onbR0-0002wE-4z; Wed, 26 Oct 2022 08:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430376.681993; Wed, 26 Oct 2022 08:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onbR0-0002w7-1d; Wed, 26 Oct 2022 08:06:46 +0000
Received: by outflank-mailman (input) for mailman id 430376;
 Wed, 26 Oct 2022 08:06:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onbQy-0002gT-4m
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 08:06:44 +0000
Received: from sonic306-19.consmr.mail.gq1.yahoo.com
 (sonic306-19.consmr.mail.gq1.yahoo.com [98.137.68.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f47aead-5505-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 10:06:42 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic306.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 08:06:39 +0000
Received: by hermes--production-ne1-c47ffd5f5-kmjmv (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 23da40615be2c6ee6a989747ca28211e; 
 Wed, 26 Oct 2022 08:06:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f47aead-5505-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666771599; bh=+Oks/M8Oo0mqEqotDONcsMEHG5zWEVL77nZHBMvFWNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=ckLkhzYstS0fKG7BSw3t0lJKTyP9Od3mbLiK7l+I+TZ7MtqVLnu/WhVFI5xAzJ2LR2rd8j3zvvlu8aLuxc6rC67NT0DfrR//DjkFzJssxvxFsLbTVnPDpOoxuqnGHNbAd1qjZcpmsbPFCwJb1LxKgOfqe2/3fBi/vW4QnHf/n1/sySxN4R0xruoAU//bV7fGW0LNh4jyHcMdqsSBBw/W41bPhIyzdSK3rLnU/Y+BWHyOqTPLojlrXPP2Vgx9iRIAvWO/ObpQHTAVMDf+OQ0lBhYJqhfAXwOiMsvHqq7n9v+jn84TcwhidsawBuExQRajhzFNo2w5XADMwkQomTVYAg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666771599; bh=Mq4uo71v5aH3IPer/qatJgs+91Gr9mbGGM+r2ov2Q6A=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=CisKuaUGp+nZmxORxidKxmas0DqsmxMABtRXh8jhMVFe+eLWYBUkhGkgVuDBRtszeV5ZSZDbXKeLKdXogzLutT0ha3uq7bnPbpgGM4YMxt/GZvNlpODNJTF8RdiwO4BD4jcLQzBZQVhlCuUssdvRpiGb4XHK4xP5nnQ6jyJ4fkmDkYNmOy1jMH9v9GyBjSERnpa2TpnOb8zyn/W2gk7sR8BUvlxD9oeA49zRUPSL2QZBmxPBDAJak83h3LaQMblPhCun3QThS/HCpwArfgFro/B+7DvRb9cb49FoJ4P+S90ojYvH4oMvpkk8qbRHq9NE4EU9Py7PdIowC4XsIoqa0A==
X-YMail-OSG: k.OGyGAVM1nZCL3v0mnAnkIo50MDaWRp5IlEpFW3VUd7xxXHEZvh6Yax5tWsXp0
 9BQEIO3N9y2nQslrSh.2YPT_dOtO8hpDowRR6O74sk5VtA0HdBIJOO5mj8kusXg.GiBZa4a7bJJl
 tTSIxTKVbPn9r6hPR.FUXJ7zk4INcDOCXNBcy3KHMN9VQC.vvuhjwTLEMJqBs_0eV6iwvB_h2Agc
 f6HbGp7ONl5yHHC7oyMkFVTCRRur7__ug_g4p8AdsLZf1g6cZz2vz_Xpvw2lRak.l0YeyzpZ7qj1
 jv84Ql9TxF8Q.UqB4UYZF2oeAl25QW2ahpHvVGCkjxPuWCTOA6BKl.SvZ23jd1Iu78HvYs6aTvrb
 rBQtBzsMOxQVwOtmcSbeytibnVspftAk_15SE50dx8rRvl_c8cIvwLgTwfm3W6rPUNGuLwiAZHQd
 Vgi2pMXDmvN.BIaE2NNQzT4LlmiL2zDK_gdotrcF35MRo14Z1U3ejExy50EMMoC2rc0fi9UarAM9
 JZdxKbYHD24sKqWETXqIZMFmeF5vHBBB92ir1IleBYI3Hpx.L076gVReAIF4IIWI_JgUfkAPQ6Xy
 rDEZMMEs3ESPWQ2PAFqC.N_5B203arjRIkU41DJkM49F98b.qTfdHjWjQDMOJI_6o8WWNaT8YWnj
 OVssQjb5z327kdKpf2ITfkoFI3Spq5Ql_7sJyVLpCrTgoL6evYe_bPGyTQv59IR1A_tD8OcW3py3
 aEgLA8I_5fQQftk11b6eAaO5snE.Dh0NoUs7xSaOQjr9CDcOIAUQFL34GUPRiyH4TVqVI.vIinpP
 j.DtU6E4Agvp7YE5RtqUS4lsYhjf1_sRU8c_gvxZtrY9xKwv68M3WxR7xL7Av4NCj0MdA8_UwyYR
 kAaBDZQhKHKi5JV14YjXffNLoFFnpHzJykmC3FBJDJ5mVk9OvOy9cwxzo0zzDjqBAfbAyXTn90_5
 WKY7qrGqKOLPFU.0tePw2GW1sCtPYt0UWGmsytPILsw3BF3aUatewWxGr2GLIuBsbGF6qnqz3K8L
 mwvRF8a19dWiwaOdqUtqLudVMULO2BwLClEMOSyuTUsEct2LMDbt2j5Yf17hp_6vx3baui8BZrF_
 G0OpTvSQEYOanhWNiq8mMD6JaYEW6wYLeoxqzu4xjKOOz8SylnaUHiJwqBbUE0W3cmCKgN.8jcET
 mOXKbCRBU2W6GqBfxv0mWiZxUmJyHWGsLY8hdPOYt47qQeq8Oo1PIi5S35CHN9Rluem.5k5.e.We
 tTROkikWim57MJ7vQU8fH08YCpdk._rGVWZWd8tzzR2dgJfTLsmDVsedIyHjF38c9Y0eRSfYPzYZ
 QERiY_7nJ_rlTKpWjSMdOXmMDL5Dh6ihMXksXONNkFpQ77JQ.ui1pDapB09rS3z_5ptxatqq8NVX
 Qo1caUpDxSCXDliJ..nWRaQWiGXWqf1rQqBeFCVKfEtuOtkLftsFI4eEA6KcRdzpD2.FjQc8z_fk
 AUqkG4xlV_yRs2W5tvI2.NpaR3GVJBO3rk4hzW9Gyjbrfk56ZbQg2hlFIUa.f_SlExv7QRZrO9DQ
 KuoIXx.NFKTvXzqMQ9koMCh.yPYLwOwO9g.wb9OcBp_ZRxW4Zo0zTbidhi5M5tnLRa6.WXRCfHcz
 luhOjUm8AcyGMAC1Q6iN4Ran5jApt9hjjc4wlalaiEW1j8WBAKdd7fCtuW3xRq0jvtfueyS9szGI
 3oUorgngNmLhW_z4lw2zKKF91i30RWNRgKaeTXqFIFQtLGRdvE53Xbrc3QKtF5mgxb9PxmOmlK5a
 Biw7SzomC2PFE.ZgH9NjqwwJkD1exjKMjWWdaJW5FTMbCa2GHNqbhUiGntIalD5sggRJvfzyTl82
 YKsjHVHlEfnsCHAb3W.VYjSqspOdzBBJA01oXQKgT4.ErngNWqgQvs5gjJtq6w9z1nqdHyddgZY2
 rpEp5fS0n.wNrLMlVlPcHF4fS0OgC2z0_d1cHjlOfiMz3c5x5YmVEgekvOyvb8pOq8SeOPHkut6K
 qvBEWfhQ462Ze174P3pwkq992vf.dm81GiKng5aGy1etHKZDGRpMYq9wNCCUSmeOYt2z9X9edawZ
 R6Go6DZz17EozPWlT9bomls31UpsBDqYFvUalgchXsb1lXls6y7luNTtYnOePMpIgTdhUo.A8wfL
 ck5X6_8NJP3O65LRYPN4U9pV4G28uoDpoJHNM.wN25kgMtHM1FUNlFc769Z3.Ieixc1gS9Q5Mzpn
 izoL0k_9L2h2p
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org,
	Chuck Zmudzinski <brchuckz@netscape.net>
Subject: [PATCH v2 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru
Date: Wed, 26 Oct 2022 04:06:06 -0400
Message-Id: <1b98334dd30af4a467170237c8a31c1824ee9c37.1666770888.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1666770887.git.brchuckz@netscape.net>
References: <cover.1666770887.git.brchuckz@netscape.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 7014

Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus,
as noted in docs/igd-assign.txt in the Qemu source code.

Currently, when the xl toolstack is used to configure a Xen HVM guest with
Intel IGD passthrough to the guest with the Qemu upstream device model,
a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy
a different slot. This problem often prevents the guest from booting.

The only available workaround is not good: Configure Xen HVM guests to use
the old and no longer maintained Qemu traditional device model available
from xenbits.xen.org which does reserve slot 2 for the Intel IGD.

To implement this feature in the Qemu upstream device model for Xen HVM
guests, introduce the following new class, functions, types, and macros:

* XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE
* XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS
* typedef XenPTQdevRealize function pointer
* XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2
* xen_igd_reserve_slot and xen_igd_clear_slot functions

The new xen_igd_reserve_slot function uses the existing slot_reserved_mask
member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using
the xl toolstack with the gfx_passthru option enabled, which sets the
igd-passthru=on option to Qemu for the Xen HVM machine type.

The new xen_igd_reserve_slot function also needs to be implemented in
hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case
when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough,
in which case it does nothing.

The new xen_igd_clear_slot function overrides qdev->realize of the parent
PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus
since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was
created in hw/i386/pc_piix.c for the case when igd-passthru=on.

Signed-off-by: Chuck Zmudzinski <brchuckz@netscape.net>
---
Notes that might be helpful to reviewers of patched code in hw/xen:

The new functions and types are based on recommendations from Qemu docs:
https://qemu.readthedocs.io/en/latest/devel/qom.html

Notes that might be helpful to reviewers of patched code in hw/i386:

The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does
not affect builds that do not have CONFIG_XEN defined.

xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an
existing function that is only true when Qemu is built with
xen-pci-passthrough enabled and the administrator has configured the Xen
HVM guest with Qemu's igd-passthru=on option.

v2: Remove From: <email address> tag at top of commit message

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 4 files changed, 48 insertions(+)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 0b1a79c0fa..a0f04ad62e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -402,6 +402,9 @@ static void pc_xen_hvm_init(MachineState *machine)
     }
 
     pc_xen_hvm_init_pci(machine);
+    if (xen_igd_gfx_pt_enabled()) {
+        xen_igd_reserve_slot(pcms->bus);
+    }
     pci_create_simple(pcms->bus, -1, "xen-platform");
 }
 #endif
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 0ec7e52183..ec42f47fac 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -950,11 +950,35 @@ static void xen_pci_passthrough_instance_init(Object *obj)
     PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS;
 }
 
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+    XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n");
+    pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK;
+}
+
+static void xen_igd_clear_slot(DeviceState *qdev, Error **errp)
+{
+    PCIDevice *pci_dev = (PCIDevice *)qdev;
+    XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev);
+    XenPTDeviceClass *xptc = XEN_PT_DEVICE_GET_CLASS(s);
+    PCIBus *pci_bus = pci_get_bus(pci_dev);
+
+    if (is_igd_vga_passthrough(&s->real_device) &&
+        (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) {
+        pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK;
+        XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n");
+    }
+    xptc->pci_qdev_realize(qdev, errp);
+}
+
 static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
+    XenPTDeviceClass *xptc = XEN_PT_DEVICE_CLASS(klass);
+    xptc->pci_qdev_realize = dc->realize;
+    dc->realize = xen_igd_clear_slot;
     k->realize = xen_pt_realize;
     k->exit = xen_pt_unregister_device;
     k->config_read = xen_pt_pci_read_config;
@@ -977,6 +1001,7 @@ static const TypeInfo xen_pci_passthrough_info = {
     .instance_size = sizeof(XenPCIPassthroughState),
     .instance_finalize = xen_pci_passthrough_finalize,
     .class_init = xen_pci_passthrough_class_init,
+    .class_size = sizeof(XenPTDeviceClass),
     .instance_init = xen_pci_passthrough_instance_init,
     .interfaces = (InterfaceInfo[]) {
         { INTERFACE_CONVENTIONAL_PCI_DEVICE },
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index e7c4316a7d..40b31b5263 100644
--- a/hw/xen/xen_pt.h
+++ b/hw/xen/xen_pt.h
@@ -3,6 +3,7 @@
 
 #include "hw/xen/xen_common.h"
 #include "hw/pci/pci.h"
+#include "hw/pci/pci_bus.h"
 #include "xen-host-pci-device.h"
 #include "qom/object.h"
 
@@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg;
 #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough"
 OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE)
 
+#define XEN_PT_DEVICE_CLASS(klass) \
+    OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE)
+#define XEN_PT_DEVICE_GET_CLASS(obj) \
+    OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE)
+
+typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp);
+
+typedef struct XenPTDeviceClass {
+    PCIDeviceClass parent_class;
+    XenPTQdevRealize pci_qdev_realize;
+} XenPTDeviceClass;
+
 uint32_t igd_read_opregion(XenPCIPassthroughState *s);
+void xen_igd_reserve_slot(PCIBus *pci_bus);
 void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val);
 void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
                                            XenHostPCIDevice *dev);
@@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read)
 
 #define XEN_PCI_INTEL_OPREGION 0xfc
 
+#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */
+
 typedef enum {
     XEN_PT_GRP_TYPE_HARDWIRED = 0,  /* 0 Hardwired reg group */
     XEN_PT_GRP_TYPE_EMU,            /* emul reg group */
diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c
index 2d8cac8d54..5c108446a8 100644
--- a/hw/xen/xen_pt_stub.c
+++ b/hw/xen/xen_pt_stub.c
@@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp)
         error_setg(errp, "Xen PCI passthrough support not built in");
     }
 }
+
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+}
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 09:14:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 09:14:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430393.682026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oncTs-0003Gs-D0; Wed, 26 Oct 2022 09:13:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430393.682026; Wed, 26 Oct 2022 09:13:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oncTs-0003Gl-9t; Wed, 26 Oct 2022 09:13:48 +0000
Received: by outflank-mailman (input) for mailman id 430393;
 Wed, 26 Oct 2022 09:13:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ktaj=23=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1oncTq-0003Gf-De
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 09:13:46 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d4c3923-550e-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 11:13:44 +0200 (CEST)
Received: from AM6PR08CA0031.eurprd08.prod.outlook.com (2603:10a6:20b:c0::19)
 by AS8PR08MB8567.eurprd08.prod.outlook.com (2603:10a6:20b:566::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.25; Wed, 26 Oct
 2022 09:13:41 +0000
Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:c0:cafe::b4) by AM6PR08CA0031.outlook.office365.com
 (2603:10a6:20b:c0::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 09:13:41 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 09:13:40 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Wed, 26 Oct 2022 09:13:40 +0000
Received: from 966f1dd02493.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 3F76CA69-CCB7-4479-B5AF-5C3A59FA3406.1; 
 Wed, 26 Oct 2022 09:13:29 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 966f1dd02493.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 09:13:29 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by DBBPR08MB6137.eurprd08.prod.outlook.com (2603:10a6:10:20f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Wed, 26 Oct
 2022 09:13:22 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 09:13:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d4c3923-550e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Hc/etjXu/80WU0ujZivZjnL1WmFomIyIqp/DwSwdS+IdMSFVV7+H2EutGka8n9eAt7MHsdTdPJMRZiG51yUAcLdWp5SwGGuqKXeX1dvhUgwFsw6yrIwPMyPgW5uFb/Fa5dyQGF/M3uk+kmlVqdN/LlSCAiOnZZaeSbgSN2BVq2Q4M6pDKQXkljqOQ7eqXETZ+YcVAPUenAa7U+3lUNwFSwE6Lv6DT85bxrwSXVe1fDIaGeqKpFuX0IseUFeJ4sMD7SbaCjQUJGdId9rVVzlvTQFawgRAHLI9FXJ1jGoJF0DmzpmuXHblylaxSf/pTUx47pPYivG3W8YknnjcDpekmw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YQk+csCPFOjwgAUQb3WtmTkUtqIGjY1egY0hzhsYz/w=;
 b=NSg3HBhA0RVweJe0FuMxYSLz66bds7p8udZwCXhlu+IhwaU8MnbY3mrWvEel9yHBJ/qLrIFIuS6BuS5jkk0C1tVida0WZX7ySHaxgo07xafmKXuB1/t1ur8igv5xd6jmg9aevzxD1WtqPhQZUprNN/6pXmjh6L0aKzrEKKY2ywt8PEF6HlHwrbjGtX+cwjzdt9Htvc4fn0tLnaEhPacNpJ4EZylqhvq7ZUwQutqS1TmS02cLAh87GP/nw+ONCL1h3aB/Olj4taTBmkhMTrdXhXfEhjHLpMOUT2zaK5kbCGF3HxjAN9CzD9vUFP0UmclJkR0VNmKrOGahp/kH3Hu6lA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YQk+csCPFOjwgAUQb3WtmTkUtqIGjY1egY0hzhsYz/w=;
 b=dOZ8vy7GitYquCVAgpv4syPjDPVDu9LXgBtmtP69/cr9KOzsBNmYPaDD0kcGnbu/NMtWpr1JfhJgYONTOV4+/6rztZ9FSttAdmhIeEfVYdocoFvt11Q0PuZWoFT6wQyWGro5La0pduib32JS/omdlt16lw6aFkCEihbNlk0Z8wY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 62c63edd3fb210f7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gmkfQgmcV1NA2K2z7EgmJN66O6Vd5DYb7PnD6Tduna4F6c7tgWB39mdkoX0NYezNCWbOxA2tBy8GZ3kysdmKFvy30RSryfW9aFa42GJAaINidftn28AEOYFPFU+eP7leN3mjzzjdDzQUmuVOFnCItuyvMmziiQpUiv9DUmyjGOvjKjb+6XcWycPaStFYwwggpTHkgD3fS/mEU1UY5AcslAmTvPFanRS2dVAvGTP63Qd2nD7E8kwFuyAuyc843zsI7kAzCWXd1srYcJs8zJ8tf5NR1FFnTQ3iBSkkQGYkWq8g8IrSpyfwGHVUT/CmHfQMIoZZQWhaKv4B1AX/af6Pqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YQk+csCPFOjwgAUQb3WtmTkUtqIGjY1egY0hzhsYz/w=;
 b=keCUFbkSGyKfrE1E4FImHCHLjV9Rt6Ctegop+umcHwW9fWAExEzsWe5rFDuB0tZXgoyBk6DjtwGN8FIPeYnlDs8O4fhD9svIyBtAhW0SafRLrGaV8okL+QJJJVSYbeDyoof50/pOnwOWJtDqeaHXQvDlAJDvqLzno/QBGSJ7rzhPtS2/dD6Gj2mHpo7ouI+ljfqYQlQo6LFVph82htVkHLcwcZEwY4lY6UWl0eFk2IZNAYqbP+2gtfZWyotU+XZaWV4WL0KeKOEtN1Ck1n+FAlRfdizStpqFEB8zYrUQS1iG2fyaibIAcdd52/oy1w/63iglp208FaAJhD7qqFgMSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YQk+csCPFOjwgAUQb3WtmTkUtqIGjY1egY0hzhsYz/w=;
 b=dOZ8vy7GitYquCVAgpv4syPjDPVDu9LXgBtmtP69/cr9KOzsBNmYPaDD0kcGnbu/NMtWpr1JfhJgYONTOV4+/6rztZ9FSttAdmhIeEfVYdocoFvt11Q0PuZWoFT6wQyWGro5La0pduib32JS/omdlt16lw6aFkCEihbNlk0Z8wY=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Julien Grall
	<julien@xen.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [v2] Proposal for deviations in static analyser findings
Thread-Topic: [v2] Proposal for deviations in static analyser findings
Thread-Index: AQHY6FpvvKvqm6eEhUKW2GdsP99AnK4fwTyAgACkb4A=
Date: Wed, 26 Oct 2022 09:13:20 +0000
Message-ID: <88950CCA-67E1-408A-82D7-38C3EBBFD6CC@arm.com>
References: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
 <alpine.DEB.2.22.394.2210251619090.1397955@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210251619090.1397955@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|DBBPR08MB6137:EE_|AM7EUR03FT012:EE_|AS8PR08MB8567:EE_
X-MS-Office365-Filtering-Correlation-Id: e79cd9b6-585d-46ba-ab48-08dab7325fa9
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NeB1Xl4pQSnO1OsyuH7LFy6Dy97ph8+FtM+drXCaHhyAnSJzaxIRLXeo8oqhl7Ac7YajVXsDDNXJwvI5Zs7FnTe5OvQb2vCpADYcECGgH22J1RH2k2NoBBfORe7AnXoT3Ha1va2s0RmCLUTQGToD2uyaPSdujDKfKKEoVNh7X5XOeEyT8jypGR10qKNc3o5T53A1cHMATRd5Gikx0aFgvMDpvFYPXjgY9Rm4qiiiHfowsqLh2Tig9vOAosyqKlDeTC/FQ/nD+9J1a7MQ24BRK2uMqQb3XPhYAVRTvjdD3jjMPN9AuSE60HhtvL0By6A11RyzjMOy+WrH3Op43kncUiVkTpmXuVhfK23YUZXD0ZmDDgrcDl/U3T8PCmbs1lZOiDLKgqMtMJAD9/g5aqVNnwgFNXyO1imLbB3QwJ5wsnpfK1DlWY+femfXO//VRj4wujfqRXTH699B82ubzS3N6zP7KrXsQAbErv/bmYWxP4k4RHagAqHz7JQEBj5RdI4myD0jXEBL5LV1XcJHeJfZVxV7/GTTy3G4bTW67LqnWiiIhqsY3AtRdDJ33ZRdH9t6VHzU1Z4mhe3ypvjck2C6cv6tUz1O/4glwyni/sNfI3P1AtUeWDpPpIv/4itcsHzeuO18Buylsz6Msf/5iHcW1Lip2Ly8pLpoitn8DlhoiowZXZqeoarHRX8CgUIYyEEPwuzNCZdGqbVGe1KAbbMfTSunAosmc+ccGYlOgz7uOb3DBKe6BgV1aClXt9SzO2J3b4YVk2CzGi0OYpD5/yOVBqKedSb3noyS6/BG3dfpa6agGW0+MQ/WjYoUA/wiDMHA07p13oNOwFXTMZJsOBIHRIZEmkIhdpx8suJYwrEqiWBxbftnUh1eO0kbdlahupby
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199015)(71200400001)(186003)(2906002)(478600001)(84970400001)(966005)(38100700002)(6486002)(91956017)(316002)(41300700001)(38070700005)(66946007)(76116006)(4326008)(8676002)(64756008)(66446008)(66476007)(54906003)(66556008)(53546011)(36756003)(6506007)(83380400001)(122000001)(6512007)(5660300002)(26005)(8936002)(86362001)(2616005)(33656002)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <E1DA57FCC293FC439EB0084D73C26EB7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6137
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ace1534f-7412-4b48-b7bb-08dab732538e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cyo6+Zir9/tVcG3t5S/JQIZv9N7OA4JTr3FPqgiQ/kbCXqb6cRsdbNRWpwQiKDR5P+e+DCoSbAdhf15PutKsRaTFTA9YY7TX8hQQLOcVYutpdRF8HJRA9EvBTNtZGut2r0HaQdbKG7Oe3KpkjY3rQ5f8juu6OKT3XBC4LTjz2mS5YfP31R5J6ADPGvDzjiP2WcO0wY5nQj4qJ3j9md5g/Hc6njWi9ODZx6gx+kzAvd+xN++7M4DiT0htse+0qRVZ30ftvs1N4kihw0qrmW45pIi6xWA7D4kkHoYuu1t7fXnQ3uxHp7qmtHdcjn858CQ82oveHhlfExo4Mop8FGyeAbgjVHrBwRYl8usDIRctljrQCsu/hw5gxx/83kq08dg4cHrXFEoeBJLYRY7dmMnzAU6FdBAIMrP8HSBlezvmIQUj9eQmKZX7VLVw4kY4vHYfAQubVpyv8x3nZuCGD6YAmo31mfnqBoaelp6cfkiG5fGfEUFaywzJAbQgAXnsaik4hqQwqIoJANIdvekyfgjrklAp4ZjCW5j7SCjRBHQ/8khDJ6SYkTTDJ5mT9ODWw6Y7EkX5nkY9N0lZDpxmMx9xE6qycSjL2Ev6ofxSxTk1Zl6N0ZxrjsO0W/m8Dk5l9leRh13hz1cXb3thUEU1gUKNm9cyysFYcI/5nuSu+VGF2WYuAyP0YAmUycuLWqs6sYrL+4IVQET1+0EhLIx7H2KtVHHQ5QZH9s2RThVGTDKYRd8wrLI7W1ScuhXkkEzpE1SHGwM2qZz34Lb/brgqfBXp6GWNFpO6bhNIgCcLPsLGm8oL2+4P3nYWzRU5qLJ29XCgZip5nPgFc6QSuAKyx5WHtg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(36756003)(84970400001)(81166007)(356005)(82740400003)(47076005)(36860700001)(2906002)(6862004)(8936002)(5660300002)(83380400001)(336012)(186003)(86362001)(33656002)(26005)(40460700003)(53546011)(316002)(966005)(2616005)(40480700001)(54906003)(70586007)(6512007)(6486002)(478600001)(4326008)(70206006)(8676002)(41300700001)(6506007)(107886003)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 09:13:40.6768
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e79cd9b6-585d-46ba-ab48-08dab7325fa9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8567

DQoNCj4gT24gMjYgT2N0IDIwMjIsIGF0IDAwOjI0LCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFi
ZWxsaW5pQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiANCj4gT24gVHVlLCAyNSBPY3QgMjAyMiwgTHVj
YSBGYW5jZWxsdSB3cm90ZToNCj4+IEhpIGFsbCwNCj4+IA0KPj4gVGhpcyBpcyB0aGUgVjIgb2Yg
dGhlIHByb3Bvc2FsIGZvciBkZXZpYXRpb25zIHRhZ2dpbmcgaW4gdGhlIFhlbiBjb2RlYmFzZSwg
dGhpcyBpbmNsdWRlcw0KPj4gYWxsIHRoZSBmZWVkYmFja3MgZnJvbSB0aGUgRnVTYSBzZXNzaW9u
IGhlbGQgYXQgdGhlIFhlbiBTdW1taXQgMjAyMiBhbmQgYWxsIHRoZQ0KPj4gZmVlZGJhY2tzIHJl
Y2VpdmVkIGluIHRoZSBwcmV2aW91cyBwcm9wb3NhbCBzZW50IG9uIHRoZSBtYWlsaW5nIGxpc3Qu
DQo+IA0KPiBJdCB3b3VsZCBiZSBnb29kIHRvIGNvbW1pdCB0aGlzIHByb3Bvc2FsICh3aGVuIGFj
a2VkKSBhcyBhIHBhbmRvYyB1bmRlcg0KPiB4ZW4uZ2l0L2RvY3MvbWlzcmENCg0KWWVzIGl0IHdp
bGwgYmUgcGFydCBvZiBteSBzZXJpZSB0aGF0IEkgd2lsbCBwdXNoIHNvb24NCg0KPiANCj4gDQo+
PiBIZXJlIGEgbGluayB0byB0aGUgcHJldmlvdXMgdGhyZWFkOiANCj4+IGh0dHBzOi8vbGlzdHMu
eGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMi0xMC9tc2cwMDU0MS5o
dG1sDQo+PiANCj4+IERvY3VtZW50aW5nIHZpb2xhdGlvbnMNCj4+ID09PT09PT09PT09PT09PT09
PT09PT0NCj4+IA0KPj4gU3RhdGljIGFuYWx5c2VycyBhcmUgdXNlZCBvbiB0aGUgWGVuIGNvZGVi
YXNlIGZvciBib3RoIHN0YXRpYyBhbmFseXNpcyBhbmQgTUlTUkENCj4+IGNvbXBsaWFuY2UuDQo+
PiBUaGVyZSBtaWdodCBiZSB0aGUgbmVlZCB0byBzdXBwcmVzcyBzb21lIGZpbmRpbmdzIGluc3Rl
YWQgb2YgZml4aW5nIHRoZW0gYW5kDQo+PiBtYW55IHRvb2xzIHBlcm1pdCB0aGUgdXNhZ2Ugb2Yg
aW4tY29kZSBjb21tZW50cyB0aGF0IHN1cHByZXNzIGZpbmRpbmdzIHNvIHRoYXQNCj4+IHRoZXkg
YXJlIG5vdCBzaG93biBpbiB0aGUgZmluYWwgcmVwb3J0Lg0KPj4gDQo+PiBYZW4gd2lsbCBpbmNs
dWRlIGEgdG9vbCBjYXBhYmxlIG9mIHRyYW5zbGF0aW5nIGEgc3BlY2lmaWMgY29tbWVudCB1c2Vk
IGluIGl0cw0KPj4gY29kZWJhc2UgdG8gdGhlIHJpZ2h0IHByb3ByaWV0YXJ5IGluLWNvZGUgY29t
bWVudCB1bmRlcnN0YW5kYWJsZSBieSB0aGUgc2VsZWN0ZWQNCj4+IGFuYWx5c2VyIHRoYXQgc3Vw
cHJlc3MgaXRzIGZpbmRpbmcuDQo+PiANCj4+IEluIHRoZSBYZW4gY29kZWJhc2UsIHRoZXNlIHRh
Z3Mgd2lsbCBiZSB1c2VkIHRvIGRvY3VtZW50IGFuZCBzdXBwcmVzcyBmaW5kaW5nczoNCj4+IA0K
Pj4gLSBTQUYtWC1zYWZlOiBUaGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxpbmUgb2YgY29k
ZSBjb250YWlucyBhIGZpbmRpbmcsIGJ1dA0KPj4gdGhlIG5vbiBjb21wbGlhbmNlIHRvIHRoZSBj
aGVja2VyIGlzIGFuYWx5c2VkIGFuZCBkZW1vbnN0cmF0ZWQgdG8gYmUgc2FmZS4NCj4+IC0gU0FG
LVgtZmFsc2UtcG9zaXRpdmUtPHRvb2w+OiBUaGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxp
bmUgb2YgY29kZSBjb250YWlucyBhDQo+PiBmaW5kaW5nLCBidXQgdGhlIGZpbmRpbmcgaXMgYSBi
dWcgb2YgdGhlIHRvb2wuDQo+PiANCj4+IFNBRiBzdGFuZHMgZm9yIFN0YXRpYyBBbmFseXNlciBG
aW5kaW5nLCB0aGUgWCBpcyBhIHBsYWNlaG9sZGVyIGZvciBhIHBvc2l0aXZlDQo+PiBudW1iZXIs
IHRoZSBudW1iZXIgYWZ0ZXIgU0FGLSBzaGFsbCBiZSBpbmNyZW1lbnRhbCBhbmQgdW5pcXVlLCBi
YXNlIHRlbg0KPj4gbm90YXRpb24gYW5kIHdpdGhvdXQgbGVhZGluZyB6ZXJvcy4NCj4+IA0KPj4g
RW50cmllcyBpbiB0aGUgZGF0YWJhc2Ugc2hvdWxkIG5ldmVyIGJlIHJlbW92ZWQsIGV2ZW4gaWYg
dGhleSBhcmUgbm90IHVzZWQNCj4+IGFueW1vcmUgaW4gdGhlIGNvZGUgKGlmIGEgcGF0Y2ggaXMg
cmVtb3Zpbmcgb3IgbW9kaWZ5aW5nIHRoZSBmYXVsdHkgbGluZSkuDQo+PiBUaGlzIGlzIHRvIG1h
a2Ugc3VyZSB0aGF0IG51bWJlcnMgYXJlIG5vdCByZXVzZWQgd2hpY2ggY291bGQgbGVhZCB0byBj
b25mbGljdHMNCj4+IHdpdGggb2xkIGJyYW5jaGVzIG9yIG1pc2xlYWRpbmcganVzdGlmaWNhdGlv
bnMuDQo+PiANCj4+IEFuIGVudHJ5IGNhbiBiZSByZXVzZWQgaW4gbXVsdGlwbGUgcGxhY2VzIGlu
IHRoZSBjb2RlIHRvIHN1cHByZXNzIGEgZmluZGluZyBpZg0KPj4gYW5kIG9ubHkgaWYgdGhlIGp1
c3RpZmljYXRpb24gaG9sZHMgZm9yIHRoZSBzYW1lIG5vbi1jb21wbGlhbmNlIHRvIHRoZSBjb2Rp
bmcNCj4+IHN0YW5kYXJkLg0KPj4gDQo+PiBBbiBvcnBoYW4gZW50cnksIHRoYXQgaXMgYW4gZW50
cnkgd2hvIHdhcyBqdXN0aWZ5aW5nIGEgZmluZGluZyBpbiB0aGUgY29kZSwgYnV0IGxhdGVyDQo+
PiB0aGF0IGNvZGUgd2FzIHJlbW92ZWQgYW5kIHRoZXJlIGlzIG5vIG90aGVyIHVzZSBvZiB0aGF0
IGVudHJ5IGluIHRoZSBjb2RlLCBjYW4gYmUNCj4+IHJldXNlZCBhcyBsb25nIGFzIHRoZSBqdXN0
aWZpY2F0aW9uIGZvciB0aGUgZmluZGluZyBob2xkcy4gVGhpcyBpcyBkb25lIHRvIGF2b2lkIHRo
ZQ0KPj4gYWxsb2NhdGlvbiBvZiBhIG5ldyBlbnRyeSB3aXRoIGV4YWN0bHkgdGhlIHNhbWUganVz
dGlmaWNhdGlvbiwgdGhhdCB3b3VsZCBsZWFkIHRvIHdhc3RlDQo+PiBvZiBzcGFjZSBhbmQgbWFp
bnRlbmFuY2UgaXNzdWVzIG9mIHRoZSBkYXRhYmFzZS4NCj4+IA0KPj4gVGhlIGZpbGVzIHdoZXJl
IHRvIHN0b3JlIGFsbCB0aGUganVzdGlmaWNhdGlvbnMgYXJlIGluIHhlbi9kb2NzL21pc3JhLyBh
bmQgYXJlDQo+PiBuYW1lZCBhcyBzYWZlLmpzb24gYW5kIGZhbHNlLXBvc2l0aXZlLTx0b29sPi5q
c29uLCB0aGV5IGhhdmUgSlNPTiBmb3JtYXQsIGVudHJpZXMNCj4+IG9mIHRoZXNlIGZpbGVzIGhh
dmUgaW5kZXBlbmRlbnQgSUQgbnVtYmVyaW5nLg0KPj4gDQo+PiBIZXJlIGlzIGFuIGV4YW1wbGUg
dG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb24gaW4gc2FmZS5qc29uOjoNCj4+IA0KPj4gfHsNCj4+
IHwgICAgInZlcnNpb24iOiAiMS4wIiwNCj4+IHwgICAgImNvbnRlbnQiOiBbDQo+PiB8ICAgICAg
ICB7DQo+PiB8ICAgICAgICAgICAgImlkIjoiU0FGLTAtc2FmZSIsDQo+PiB8ICAgICAgICAgICAg
ImFuYWx5c2VyIjogew0KPj4gfCAgICAgICAgICAgICAgICAiY3BwY2hlY2siOiAibWlzcmEtYzIw
MTItMjAuNyIsDQo+PiB8ICAgICAgICAgICAgICAgICJjb3Zlcml0eSI6ICJtaXNyYV9jXzIwMTJf
cnVsZV8yMF83X3Zpb2xhdGlvbiIsDQo+PiB8ICAgICAgICAgICAgICAgICJlY2xhaXIiOiAiTUMz
UjEuUjIwLjciDQo+PiB8ICAgICAgICAgICAgfSwNCj4+IHwgICAgICAgICAgICAibmFtZSI6IOKA
nFIyMC43IEMgbWFjcm8gcGFyYW1ldGVycyBub3QgdXNlZCBhcyBleHByZXNzaW9uIiwNCj4+IHwg
ICAgICAgICAgICAidGV4dCI6ICJUaGUgbWFjcm8gcGFyYW1ldGVycyB1c2VkIGluIHRoaXMgW+KA
pl0iDQo+PiB8ICAgICAgICB9LA0KPj4gfCAgICAgICAgew0KPj4gfCAgICAgICAgICAgICJpZCI6
4oCdU0FGLTEtc2FmZSIsDQo+PiB8ICAgICAgICAgICAgImFuYWx5c2VyIjogew0KPj4gfCAgICAg
ICAgICAgICAgICAiY3BwY2hlY2siOiAidW5yZWFkVmFyaWFibGUiLA0KPj4gfCAgICAgICAgICAg
ICAgICAiY292ZXJpdHkiOiAiVU5VU0VEX1ZBTFVFIg0KPj4gfCAgICAgICAgICAgIH0sDQo+PiB8
ICAgICAgICAgICAgIm5hbWUiOiDigJxWYXJpYWJsZSBzZXQgYnV0IG5vdCB1c2VkIiwNCj4+IHwg
ICAgICAgICAgICAidGV4dCI6IOKAnEl0IGlzIHNhZmUgYmVjYXVzZSBb4oCmXSINCj4+IHwgICAg
ICAgIH0sDQo+PiB8ICAgICAgICB7DQo+PiB8ICAgICAgICAgICAgImlkIjrigJ1TQUYtMi1zYWZl
IiwNCj4+IHwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7fSwNCj4+IHwgICAgICAgICAgICAibmFt
ZSI6ICJTZW50aW5lbCIsDQo+PiB8ICAgICAgICAgICAgInRleHQiOiAiIg0KPj4gfCAgICAgICAg
fQ0KPj4gfCAgICBdDQo+PiB8fQ0KPj4gDQo+PiBIZXJlIGlzIGFuIGV4YW1wbGUgdG8gYWRkIGEg
bmV3IGp1c3RpZmljYXRpb24gaW4gZmFsc2UtcG9zaXRpdmUtY3BwY2hlY2suanNvbjo6DQo+PiAN
Cj4+IHx7DQo+PiB8ICAgICJ2ZXJzaW9uIjogIjEuMCIsDQo+PiB8ICAgICJjb250ZW50IjogWw0K
Pj4gfCAgICAgICAgew0KPj4gfCAgICAgICAgICAgICJpZCI6IlNBRi0wLWZhbHNlLXBvc2l0aXZl
LWNwcGNoZWNrIiwNCj4+IHwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQo+PiB8ICAgICAgICAg
ICAgICAgICJjcHBjaGVjayI6ICJtaXNyYS1jMjAxMi0yMC43Ig0KPj4gfCAgICAgICAgICAgIH0s
DQo+PiB8ICAgICAgICAgICAg4oCcdG9vbC12ZXJzaW9u4oCdOiDigJwyLjciLA0KPj4gfCAgICAg
ICAgICAgICJuYW1lIjog4oCcUjIwLjcgc2Vjb25kIG9wZXJhbmQgb2YgbWVtYmVyLWFjY2VzcyBv
cGVyYXRvciIsDQo+PiB8ICAgICAgICAgICAgInRleHQiOiAiVGhlIHNlY29uZCBvcGVyYW5kIG9m
IGEgbWVtYmVyIGFjY2VzcyBvcGVyYXRvciBzaGFsbCBiZSBhIG5hbWUgb2YgYSBtZW1iZXIgb2Yg
dGhlIHR5cGUgcG9pbnRlZCB0bywgc28gaW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UgaXQgaXMgd3Jv
bmcgdG8gdXNlIHBhcmVudGhlc2VzIG9uIHRoZSBtYWNybyBwYXJhbWV0ZXIuIg0KPiANCj4gQW55
IHdheSB3ZSBjYW4gbWFrZSB0aGUgdGV4dCBtYXggODAgY2hhcnMgaW4gbGVuZ3RocyAod2l0aG91
dCBicmVha2luZw0KPiB0aGUganNvbiBwYXJzZXIpPw0KDQpVbmZvcnR1bmF0ZWx5IGl0IGlzIGEg
bGltaXRhdGlvbiBvZiBqc29uLCBidXQgaXTigJlzIHNvIGVhc3kgdG8gaW50ZWdyYXRlIGluIHB5
dGhvbiBzY3JpcHRzIHRoYXQgSSBjb3VsZG7igJl0IGZpbmQgYSBiZXR0ZXIgYWx0ZXJuYXRpdmVz
IGluIHRlcm1zIG9mIGZsZXhpYmlsaXR5IGFuZCBhdmFpbGFiaWxpdHkgb2YgcGFyc2VyLg0KSSBn
dWVzcyBpbiBjYXNlIG9mIGp1c3RpZmljYXRpb25zIHRoYXQgbmVlZHMgbG90IG9mIHRleHQsIGdy
YXBocywgaW1hZ2VzLCB3ZSBjYW4gY29tbWl0IGEgZG9jdW1lbnQgYW5kIHB1dCB0aGUgcGF0aCB0
byBpdCBhcyB0ZXh0IGNvbnRlbnQuDQoNCj4gDQo+IEFsc28sIGlmIHdlIGFyZSBnb2luZyB0byBj
b21taXQgdGhpcyBkb2N1bWVudCBpbiB4ZW4uZ2l0LCBwbGVhc2UgdXNlDQo+IGNvbnNpc3RlbnRs
eSAiIGluc3RlYWQgb2Yg4oCcDQoNClllcyB0aGlzIGlzIGEgY29weS1wYXN0ZSBlcnJvciBJIHdp
bGwgZml4DQoNCj4gDQo+IA0KPj4gfCAgICAgICAgfSwNCj4+IHwgICAgICAgIHsNCj4+IHwgICAg
ICAgICAgICAiaWQiOuKAnVNBRi0xLWZhbHNlLXBvc2l0aXZlLWNwcGNoZWNrIiwNCj4+IHwgICAg
ICAgICAgICAiYW5hbHlzZXIiOiB7fSwNCj4+IHwgICAgICAgICAgICDigJx0b29sLXZlcnNpb27i
gJ06IOKAnCIsDQo+PiB8ICAgICAgICAgICAgIm5hbWUiOiAiU2VudGluZWwiLA0KPj4gfCAgICAg
ICAgICAgICJ0ZXh0IjogIiINCj4+IHwgICAgICAgIH0NCj4+IHwgICAgXQ0KPj4gfH0NCj4+IA0K
Pj4gVG8gZG9jdW1lbnQgYSBmaW5kaW5nLCBqdXN0IGFkZCBhbm90aGVyIGJsb2NrIHtbLi4uXX0g
YmVmb3JlIHRoZSBzZW50aW5lbCBibG9jaywNCj4+IHVzaW5nIHRoZSBpZCBjb250YWluZWQgaW4g
dGhlIHNlbnRpbmVsIGJsb2NrIGFuZCBpbmNyZW1lbnQgYnkgb25lIHRoZSBudW1iZXINCj4+IGNv
bnRhaW5lZCBpbiB0aGUgaWQgb2YgdGhlIHNlbnRpbmVsIGJsb2NrLg0KPj4gDQo+PiBIZXJlIGEg
YnJpZWYgZXhwbGFuYXRpb24gb2YgdGhlIGZpZWxkIGluc2lkZSBhbiBvYmplY3Qgb2YgdGhlICJj
b250ZW50IiBhcnJheToNCj4+IC0gaWQ6IGl0IGlzIGEgdW5pcXVlIHN0cmluZyB0aGF0IGlzIHVz
ZWQgdG8gcmVmZXIgdG8gdGhlIGZpbmRpbmcsIG1hbnkgZmluZGluZw0KPj4gY2FuIGJlIHRhZ2dl
ZCB3aXRoIHRoZSBzYW1lIGlkLCBpZiB0aGUganVzdGlmaWNhdGlvbiBob2xkcyBmb3IgYW55IGFw
cGxpZWQNCj4+IGNhc2UuDQo+PiBJdCB0ZWxscyB0aGUgdG9vbCB0byBzdWJzdGl0dXRlIGEgWGVu
IGluLWNvZGUgY29tbWVudCBoYXZpbmcgdGhpcyBzdHJ1Y3R1cmU6DQo+PiAvKiBTQUYtMC1zYWZl
IFsuLi5dIFwqLw0KPiANCj4gTm8gbmVlZCBmb3IgdGhlIGZpbmFsIFwNCg0KTXkgdnNjb2RlIGV4
dGVuc2lvbiB0aGF0IHJlbmRlcnMgdGhlIC5yc3QgZmlsZSBpcyBjb21wbGFpbmluZyBpZiBJIGRv
buKAmXQgdXNlIHRoZSBmaW5hbCBcIC4NCg0KPiANCj4gRXZlcnl0aGluZyBlbHNlIGxvb2tzIGdv
b2QgdG8gbWUuDQo+IA0KPiANCj4+IC0gYW5hbHlzZXI6IGl0IGlzIGFuIG9iamVjdCBjb250YWlu
aW5nIHBhaXIgb2Yga2V5LXZhbHVlIHN0cmluZ3MsIHRoZSBrZXkgaXMNCj4+IHRoZSBhbmFseXNl
ciwgc28gaXQgY2FuIGJlIGNwcGNoZWNrLCBjb3Zlcml0eSBvciBlY2xhaXIuIFRoZSB2YWx1ZSBp
cyB0aGUNCj4+IHByb3ByaWV0YXJ5IGlkIGNvcnJlc3BvbmRpbmcgb24gdGhlIGZpbmRpbmcsIGZv
ciBleGFtcGxlIHdoZW4gY292ZXJpdHkgaXMNCj4+IHVzZWQgYXMgYW5hbHlzZXIsIHRoZSB0b29s
IHdpbGwgdHJhbnNsYXRlIHRoZSBYZW4gaW4tY29kZSBjb21lbnQgaW4gdGhpcyB3YXk6DQo+PiAv
KiBTQUYtMC1zYWZlIFsuLi5dIFwqLyAtPiAvKiBjb3Zlcml0eVtjb3Zlcml0eS1pZF0gXCovDQo+
PiBpZiB0aGUgb2JqZWN0IGRvZXNuJ3QgaGF2ZSBhIGtleS12YWx1ZSwgdGhlbiB0aGUgY29ycmVz
cG9uZGluZyBpbi1jb2RlDQo+PiBjb21tZW50IHdvbid0IGJlIHRyYW5zbGF0ZWQuDQo+PiAtIG5h
bWU6IGEgc2ltcGxlIG5hbWUgZm9yIHRoZSBmaW5kaW5nDQo+PiAtIHRleHQ6IGEgcHJvcGVyIGp1
c3RpZmljYXRpb24gdG8gdHVybiBvZmYgdGhlIGZpbmRpbmcuDQo+PiANCj4+IA0KPj4gDQo+PiBI
ZXJlIGFuIGV4YW1wbGUgb2YgdGhlIHVzYWdlIG9mIHRoZSBpbi1jb2RlIGNvbW1lbnQgdGFncyB0
byBzdXBwcmVzcyBhIGZpbmRpbmcgZm9yIHRoZSBSdWxlIDguNjoNCj4+IA0KPj4gRWNsYWlyIHJl
cG9ydHMgaXQgaGVyZToNCj4+IGh0dHBzOi8vZWNsYWlyaXQuY29tOjM3ODcvZnMvdmFyL2xpYi9q
ZW5raW5zL2pvYnMvWEVOL2NvbmZpZ3VyYXRpb25zL2F4aXMtVGFyZ2V0L0FSTTY0L2F4aXMtYWdl
bnQvcHVibGljL2J1aWxkcy81NDkvYXJjaGl2ZS9FQ0xBSVIvb3V0L1BST0pFQ1QuZWNkOy9zb3Vy
Y2VzL3hlbi9pbmNsdWRlL3hlbi9rZXJuZWwuaC5odG1sI1I1MDc0M18xDQo+PiANCj4+IEFsc28g
Y292ZXJpdHkgcmVwb3J0cyBpdCwgaGVyZSBhbiBleHRyYWN0IG9mIHRoZSBmaW5kaW5nOg0KPj4g
DQo+PiB4ZW4vaW5jbHVkZS94ZW4va2VybmVsLmg6Njg6DQo+PiAxLiBtaXNyYV9jXzIwMTJfcnVs
ZV84XzZfdmlvbGF0aW9uOiBGdW5jdGlvbiAiX3N0YXJ0IiBpcyBkZWNsYXJlZCBidXQgbmV2ZXIg
ZGVmaW5lZC4NCj4+IA0KPj4gVGhlIGFuYWx5c2VycyBhcmUgY29tcGxhaW5pbmcgYmVjYXVzZSB3
ZSBoYXZlIHRoaXMgaW4geGVuL2luY2x1ZGUveGVuL2tlcm5lbC5oIGF0IGxpbmUgNjg6DQo+PiAN
Cj4+IGV4dGVybiBjaGFyIF9zdGFydFtdLCBfZW5kW10sIHN0YXJ0W107DQo+PiANCj4+IFRob3Nl
IGFyZSBzeW1ib2xzIGV4cG9ydGVkIGJ5IHRoZSBsaW5rZXIsIGhlbmNlIHdlIHdpbGwgbmVlZCB0
byBoYXZlIGEgcHJvcGVyIGRldmlhdGlvbiBmb3IgdGhpcyBmaW5kaW5nLg0KPj4gDQo+PiBXZSB3
aWxsIHByZXBhcmUgb3VyIGVudHJ5IGluIHRoZSBkYXRhYmFzZToNCj4+IA0KPj4gfHsNCj4+IHwg
ICAgInZlcnNpb24iOiAiMS4wIiwNCj4+IHwgICAgImNvbnRlbnQiOiBbDQo+PiB8ICAgICAgICB7
DQo+PiB8ICAgICAgICBb4oCmXQ0KPj4gfCAgICAgICAgfSwNCj4+IHwgICAgICAgIHsNCj4+IHwg
ICAgICAgICAgICAiaWQiOuKAnVNBRi0xLXNhZmUiLA0KPj4gfCAgICAgICAgICAgICJhbmFseXNl
ciI6IHsNCj4+IHwgICAgICAgICAgICAgICAg4oCcZWNsYWlyIjogIk1DM1IxLlI4LjYiLA0KPj4g
fCAgICAgICAgICAgICAgICAiY292ZXJpdHkiOiAibWlzcmFfY18yMDEyX3J1bGVfOF82X3Zpb2xh
dGlvbiINCj4+IHwgICAgICAgICAgICB9LA0KPj4gfCAgICAgICAgICAgICJuYW1lIjog4oCcUnVs
ZSA4LjY6IGxpbmtlciBkZWZpbmVkIHN5bWJvbHMiLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0Ijog
4oCcSXQgaXMgc2FmZSB0byBkZWNsYXJlIHRoaXMgc3ltYm9sIGJlY2F1c2UgaXQgaXMgZGVmaW5l
ZCBpbiB0aGUgbGlua2VyIHNjcmlwdC4iDQo+PiB8ICAgICAgICB9LA0KPj4gfCAgICAgICAgew0K
Pj4gfCAgICAgICAgICAgICJpZCI64oCdU0FGLTItc2FmZSIsDQo+PiB8ICAgICAgICAgICAgImFu
YWx5c2VyIjoge30sDQo+PiB8ICAgICAgICAgICAgIm5hbWUiOiAiU2VudGluZWwiLA0KPj4gfCAg
ICAgICAgICAgICJ0ZXh0IjogIiINCj4+IHwgICAgICAgIH0NCj4+IHwgICAgXQ0KPj4gfH0NCj4+
IA0KPj4gQW5kIHdlIHdpbGwgdXNlIHRoZSBwcm9wZXIgdGFnIGFib3ZlIHRoZSB2aW9sYXRpb24g
bGluZToNCj4+IA0KPj4gLyogU0FGLTEtc2FmZSBbb3B0aW9uYWwgdGV4dF0gKi8NCj4+IGV4dGVy
biBjaGFyIF9zdGFydFtdLCBfZW5kW10sIHN0YXJ0W107DQo+PiANCj4+IFRoaXMgZW50cnkgd2ls
bCBmaXggYWxzbyB0aGUgdmlvbGF0aW9uIG9uIF9lbmQgYW5kIHN0YXJ0LCBiZWNhdXNlIHRoZXkg
YXJlIG9uIHRoZSBzYW1lIGxpbmUgYW5kIHRoZQ0KPj4gc2FtZSDigJx2aW9sYXRpb24gSUTigJ0u
DQo+PiANCj4+IEFsc28sIHRoZSBzYW1lIHRhZyBjYW4gYmUgdXNlZCBvbiBvdGhlciBzeW1ib2xz
IGZyb20gdGhlIGxpbmtlciB0aGF0IGFyZSBkZWNsYXJlZCBpbiB0aGUgY29kZWJhc2UsDQo+PiBi
ZWNhdXNlIHRoZSBqdXN0aWZpY2F0aW9uIGhvbGRzIGZvciB0aGVtIHRvby4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 09:14:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 09:14:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430398.682038 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oncUs-0003ow-QA; Wed, 26 Oct 2022 09:14:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430398.682038; Wed, 26 Oct 2022 09:14:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oncUs-0003op-NP; Wed, 26 Oct 2022 09:14:50 +0000
Received: by outflank-mailman (input) for mailman id 430398;
 Wed, 26 Oct 2022 09:14:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oncUq-0003io-KL
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 09:14:48 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2049.outbound.protection.outlook.com [40.107.105.49])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a325c9f5-550e-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 11:14:47 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8213.eurprd04.prod.outlook.com (2603:10a6:20b:3f3::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 09:14:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 09:14:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a325c9f5-550e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OW8YAwGtfwd3WIQ5aT12fOMp6XBNjZ91R9pdMfC78xBA+KI0DNOejmwrD1ZjYLtVrzwgDDhZNKZK2CIUqkjNhuTkGTbcbRFsG+DFvdvos9QsrkOKnaIWqkz2G60AzP2aLy0OGi8qQQ1TDp2w/nR14L5xHAJXQpyHoyg3bbUVMfP7gZpnBo2BKZv4WK9cp+oK/bCCKR5pSDOsmCUca6bEKQbNOvISLfPLUP9MMRZegr7p79lcOY9P8kp69Tn0UfD6l1Si0GPJuy/YC/VkCnXKukAU/Uz910uAJpyDG6gHMhFtJaMuR7P7HP7HvXdOPv6SnpVl3e/ZiUh18yHpRIWPGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rV3pfXIMOwXzVwIuuQtpwMooCubqdzZP7iiKKnuQcgw=;
 b=g/mdzZ39+ohppFtFUSF3V5tTTTJIPpdRgdE/NrNyQaKnr98wtOWEsh2UOfe68DL5GtAhFWzrUCpX70QvUXAMidtphpIFj33e017EzIK23Wo4kpnN8Hxrugnkkuurkhks5GMs0h6wQI06NmGVCgO9ur7YD8OOwCWjPqLOCe5HXblYeDDXjWHU62g3EoWaS5doI4E45THWcHCFPfsSH/egv/fPpRr88++NUHMrUIagdG3Iah/dInkOO7uatwJS50i+8H6/sPa9MUpbf2FglUSq15TqZq2P11ot7qcP/c3qEFoXLH2dP13GC7bkE4L3GZRR91fRtiG/GlQKUnxnrkWuMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rV3pfXIMOwXzVwIuuQtpwMooCubqdzZP7iiKKnuQcgw=;
 b=48KqmgXYXdfPNMzuYqU/BacBfMYWx03ZYYHM2P+HgaDAKRJCV3R7SZzonKjLhzLO1MDeXFOWLvEvfGNuqV6or7VUE+94mVO0n3StVtf7Irh6DjAd1mJ+rtZkIESkThJ6pIeIJY54oU9N0+crXq8+9u4ftEEl4q8PqxY665Y1Ui9NhdVIfU17GDRjZa8EHm2QZKV/twHi/HTu2XzNBhrRXE22itS8v6moxGVu9zsoLR4UljX+zh8W+6GHjoMzNt5nQjjyDUDdHdHDPzkOIj2ukVAJh5CGJCQnjPrKhRe7+D2LuxHrdBFqKQ78QFtvA1j5R6U7Jkc7/O55EPlU0/DJ0g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <11096910-5574-657b-6d91-fb4ce4c39ed7@suse.com>
Date: Wed, 26 Oct 2022 11:14:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Henry Wang <Henry.Wang@arm.com>, xen-devel@lists.xenproject.org
References: <20221025092112.50168-1-Henry.Wang@arm.com>
 <9bec8877-25d2-8d50-6f03-523b806642b2@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9bec8877-25d2-8d50-6f03-523b806642b2@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0107.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8213:EE_
X-MS-Office365-Filtering-Correlation-Id: 59f5b5c2-ccbd-464f-e41f-08dab732867e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5Ksq9kcEvSo8Y/fDoycFyzcd78LDrDOYy1dRuU3/nOr4uN5gb72gMAkbZUQbfJEXa5lSKEDUuiBaBlXbmv+SHTifqmPZi9dIw5xAoC1OaLlavSJ6uBVqmlU85qap3eaweI3fj/M8xYfG1GTSAxbUDhF0057Qh7loFnNY6WzLy7katotoSo6fUpfzyHApwEFAp1sefJIy0YxqzumCCJ+pqUY1QG8iqggfxbBOm27LVEugtKk992roh54Q1gdpOpxsgRvr01DwCFuBnddhuv4S97HS9xR1msX7FoFwYuBVeIsRRbueyDZ+9RuEODC2zOXW5IZ6xQevAxj8+sT5En4Mo6+We7hD9Alqx/dfA0IgpBvWyl0TizHZh4yfEcK5vckGpEZIha78EZm4QaieSc5TeIbT1LFqApdephz3ZMuicRgQEkeFE82eUXgm6n9CXvXQs6TvouKcy2vuxogHcaH3UwYgXDz/szlRw+HReM2tiD9gzY8Sokmka2hGrnsr88FaFKHgcC8CxqRfHW/8Ds9bXNYITaiWOJwwcFiGUK4RdfoCcnHafdJGDRljvVD0o3h6Vd8fdDMNsvPDnoavCDTi5DjmRGHBfGaYBB+IIbsFye9IaFB+AM7RieOKOPVEWQIVuZpFbbYQvu1fjIIQQp9JZUXAzV88WTEjltaiWKgVt7naAHHAQqvI2ZaFZlNQz+vw+RR+o179YLOnvkgSBmIZWRfHPa6c6To1Zp3oqprbfAETZ+ly6ayqowhnWvef2N4+7i9IudHl2Vovj3IiT+SHZwOe+29hgDMRnh9KTeBIlGw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(346002)(396003)(136003)(39860400002)(451199015)(83380400001)(31696002)(4744005)(86362001)(38100700002)(66556008)(66946007)(8936002)(5660300002)(66476007)(2906002)(4326008)(53546011)(6916009)(41300700001)(6506007)(186003)(26005)(2616005)(6512007)(54906003)(8676002)(478600001)(316002)(31686004)(36756003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHIzSFZMSHI1VUhkamVDRE1wZStGYy9PTk1sZTc2Q1BnZDl6bXpGdlhxVVlE?=
 =?utf-8?B?WnZTSGJtdnNIQWEzdjRGc0h1Z3ZOUU1iWDFPWlZvVDB5bjRVZkpIM3pyTXM1?=
 =?utf-8?B?Qk05aGZHV1NzVk5vZ0hueUowNG1ZRTdkNWdnbEtnaHRlMy9HUFFTN1JuUnlW?=
 =?utf-8?B?V3VPZ3E5T1RRRStBSFJZaUNDaCtNc3VLRXRwKzlLdVpqd3RrdTlpQzBTNmJ4?=
 =?utf-8?B?Um9LbTZTMDNoUlZ6S0w1L0hDRDJucDBDRXZDY1l5WnBldjhaZ1dOSGxhdnZN?=
 =?utf-8?B?Tml6elc1U3ZHSnh6TU9sMzBoRnVjcjQ4Uit4UzF2L1ZFOWNQaHVONlB0NStz?=
 =?utf-8?B?ZzR0N1NPaXFLQ1ZJOFdEekovN0dFWk9nQ3BkME9pYTlRZWhzN0lYWEdFcHIv?=
 =?utf-8?B?OWhoSThlNjRINTlKNlRGK3BZVVJVMFFaOTVCTmtZbDd6N2pwVVJOUDI4aGxH?=
 =?utf-8?B?VXNiMm5TYXMrdTk3ejFlMWgvSlVFc25hVFJoeFpWWUNrMmFXVkxPdXZKR2pM?=
 =?utf-8?B?NC9DOHQ2S2Y4bktqUkFUNTVSUVdSRUVyMC9qQTZHZjJWbXVWTjR5dnJEZUwr?=
 =?utf-8?B?REtOL0gwWGlUL3FyS2RRZ2gxT2s3TXFIUzlqU01QTktTaGtCeTVRdGpTU1lT?=
 =?utf-8?B?eVR1YUdtR0NsUlRlNmEvQkVuNGdxMlBoaFpWVVN2dVhvZXNLb3VhSWkyemNN?=
 =?utf-8?B?S1JNVTIyYTZXWkxsbXA4RnZxQktlcmZXSmVLWFJsYUk3cmJ0blVkOGVuQzhv?=
 =?utf-8?B?d0NpaW1MY3JDQUlHT2cyUTg4eWU0L2dmdlI3QVN5VDdmV1lWcmVwWTNCcUtC?=
 =?utf-8?B?RUlLSCtWYWpsb2w5WVUvcnJnOEZNNjlYZ1BhRm5XQS9mOWorbnRwdlhoVkZk?=
 =?utf-8?B?bW9kS3IzSVNnTG9taXBVK2wrTVh5NVNnS2tuYWRjR2QrZkpZVXpSMlBNNTVC?=
 =?utf-8?B?ZEZBdlVvRURGVXByeElqOGU3TllyWXZCdHl0T0VjeU8zaW9ISXg1YW50NTdB?=
 =?utf-8?B?RjZHOWZSWU1YR3Bzbk44RXA1Z3BWSUJ0VUtkUFRGakxJRVFCTHVLSWxNQTlv?=
 =?utf-8?B?NlVBbDZNaTJneU1TcW9ybFA5My9BZU5zSTFrOGY0cFp0aVhUbUJvbkxyU0ZY?=
 =?utf-8?B?blJ3KzUxaHcvTytoRWc0WTMxeWJyWjQxZjU5MnhSbE5iVDM0MWRMWk1YTThl?=
 =?utf-8?B?L25MTkE0NGdBam9IZ2pGUk96NWpicFUxTy84VFk1MmVYcm1LTjVRRFhxejkz?=
 =?utf-8?B?RGdJWTlQZjlGSVdPR2greURVSEFMcHY3ZzFyUzVNSXhBVWx1eDduc05qTEJx?=
 =?utf-8?B?K0o5akFtU1NMN1ZmYkV3bjZ0SWxvVlU5NExvZmJ6YnRHZXhpY3lzSllFd0pX?=
 =?utf-8?B?WGdUZHlLbDgrMlRQUmZLNjJyQXhtTFUveW9yN050WTZUQ2tYMHZSRSsvbnNP?=
 =?utf-8?B?cVo5cFFUVDJ4T2pWcGhCYm1lMGhCTWZ2Rmp0WDZ3c1k0TjNhbHY0SDRJZ0RR?=
 =?utf-8?B?ZlZINVozbm90RjBTRVp0RGQxK3ZMSzZFSHhrSzM0TXA3K3pxZzFCd3ZXeDU5?=
 =?utf-8?B?ZmY1SzYya1NIT2phR3dmRnBIVWprbVFhbmlmZ1FnVlREbURZakRWV0RSTE1v?=
 =?utf-8?B?REVrSU03L0tZVU9ScnZFd1h4d0prekhIVXdERHUrOVFVMHordklLN2Fua0li?=
 =?utf-8?B?K21CZkVNSWgwMTRkL2Q2OVEzcDBVaFVITW9Dd2ExYTBIUjNQUUhjR0d6bTdR?=
 =?utf-8?B?ZWJjWU1VU1VqcE5DVTJwNFRlS0N4NG1ETVN1TG1idkErVDNBaXh3V0hDZzky?=
 =?utf-8?B?enorNStjbXBCUkgyNDZTTVNlQ2RzdjJMN1g3Z05CSTdzaDRUVFFpMlk0c1NU?=
 =?utf-8?B?Z2ZLNUl6OWIyOWJqeVBnRGVJYytDeWJUNjhJblFLUklhMVlVcVRIRnhqU1hI?=
 =?utf-8?B?aldwOFNNVGoyZ2ZqMGRNOE5XcmtlZmU0cy90R3Y3c3hNZHBVSHA2dEtiU0wz?=
 =?utf-8?B?WW1ZbDExY2FBZ2xVUThpblhpeTdrOXFQSVBRa0o0ZjNMa0tDNkVGNWdkU3p5?=
 =?utf-8?B?UkpqdUVyOGhnUG9mQXIyUGFtc2lqSnBsODd2cXp4Y2RvaTJGK0tPcG1oWU1o?=
 =?utf-8?Q?47d6tQ+9wCoVs8kJePe5LLrNU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59f5b5c2-ccbd-464f-e41f-08dab732867e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 09:14:46.0307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IXNjmj6LWpVQfDD2MRzjW5rq6eygYYp3Rd+36Nfb/rbdz3BvhGqTGkm+y20VdltJOnCQ0SNflOjb+YSKvwXFuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8213

On 25.10.2022 22:06, Julien Grall wrote:
> On 25/10/2022 10:21, Henry Wang wrote:
>> This series is a backported series for XSA-409 fixes from master for
>> 4.14 to 4.16, which cherry-picking commits:
>> 3783e583319f arm/p2m: Rework p2m_init()
>> c7cff1188802 xen/arm: p2m: Populate pages for GICv2 mapping in p2m_init()
> 
> I have merged the 2 patches in Xen 4.16, 4.15 and 4.14. I noticed that 
> the "released-acked-by" tags were removed.
> 
> We usually keep the commit message as-is (including tags). But I vaguely 
> remember that we may have stripped the "released-acked-by" tag in the 
> past. So I left it alone.

Indeed I'm trying to remember to strip those when doing backports, as they
aren't meaningful (but potentially confusing) on the stable branches.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 09:36:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 09:36:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430404.682055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oncpu-0006eM-Mu; Wed, 26 Oct 2022 09:36:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430404.682055; Wed, 26 Oct 2022 09:36:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oncpu-0006eF-Iz; Wed, 26 Oct 2022 09:36:34 +0000
Received: by outflank-mailman (input) for mailman id 430404;
 Wed, 26 Oct 2022 09:36:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oncpt-0006e9-MC
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 09:36:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oncpt-0007zF-BE; Wed, 26 Oct 2022 09:36:33 +0000
Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.240])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oncpt-0002HS-3z; Wed, 26 Oct 2022 09:36:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=2F+Ob1oXMIaVeKSAXliqSCKxg7aY9dtmBzqWXxHPJ9Y=; b=Krda/ohbX5E+Hts9MeVJngTm/1
	PJBV5gx0R5dxv8abJGF0pqz9qhxqPiUmeRvXvfkFq+Oy7rNbN66r63EVkG5lyHq5Z01ra2JJnCyto
	vwAyY4zoZM94X4Ttp96LJOKhJ1Kcg0BTHqDBw3aZY4IEtync06RAOl1NLXMi/H/VNMuY=;
Message-ID: <4ec8b702-aebf-2ce4-78e9-2f72d1b53cc3@xen.org>
Date: Wed, 26 Oct 2022 10:36:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [v2] Proposal for deviations in static analyser findings
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 25/10/2022 11:13, Luca Fancellu wrote:
> Hi all,

Hi Luca,

Some comments below if we plan to merge the doc in the tree.

> This is the V2 of the proposal for deviations tagging in the Xen codebase, this includes
> all the feedbacks from the FuSa session held at the Xen Summit 2022 and all the
> feedbacks received in the previous proposal sent on the mailing list.
> 
> Here a link to the previous thread:
> https://lists.xenproject.org/archives/html/xen-devel/2022-10/msg00541.html >
> Documenting violations
> ======================
> 
> Static analysers are used on the Xen codebase for both static analysis and MISRA
> compliance.
> There might be the need to suppress some findings instead of fixing them and
> many tools permit the usage of in-code comments that suppress findings so that
> they are not shown in the final report.
> 
> Xen will include a tool capable of translating a specific comment used in its
> codebase to the right proprietary in-code comment understandable by the selected
> analyser that suppress its finding.
> 
> In the Xen codebase, these tags will be used to document and suppress findings:
> 
> - SAF-X-safe: This tag means that the next line of code contains a finding, but
>   the non compliance to the checker is analysed and demonstrated to be safe.
> - SAF-X-false-positive-<tool>: This tag means that the next line of code contains a
>   finding, but the finding is a bug of the tool.
> 
> SAF stands for Static Analyser Finding, the X is a placeholder for a positive
> number, the number after SAF- shall be incremental and unique, base ten
> notation and without leading zeros.
> 
> Entries in the database should never be removed, even if they are not used
> anymore in the code (if a patch is removing or modifying the faulty line).
> This is to make sure that numbers are not reused which could lead to conflicts
> with old branches or misleading justifications.
> 
> An entry can be reused in multiple places in the code to suppress a finding if
> and only if the justification holds for the same non-compliance to the coding
> standard.
> 
> An orphan entry, that is an entry who was justifying a finding in the code, but later
> that code was removed and there is no other use of that entry in the code, can be
> reused as long as the justification for the finding holds. This is done to avoid the
> allocation of a new entry with exactly the same justification, that would lead to waste
> of space and maintenance issues of the database.
> 
> The files where to store all the justifications are in xen/docs/misra/ and are
> named as safe.json and false-positive-<tool>.json, they have JSON format, entries
> of these files have independent ID numbering.
> 
> Here is an example to add a new justification in safe.json::
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |            "id":"SAF-0-safe",
> |            "analyser": {
> |                "cppcheck": "misra-c2012-20.7",
> |                "coverity": "misra_c_2012_rule_20_7_violation",
> |                "eclair": "MC3R1.R20.7"
> |            },
> |            "name": “R20.7 C macro parameters not used as expression",
> |            "text": "The macro parameters used in this […]"
> |        },
> |        {
> |            "id":”SAF-1-safe",
> |            "analyser": {
> |                "cppcheck": "unreadVariable",
> |                "coverity": "UNUSED_VALUE"
> |            },
> |            "name": “Variable set but not used",
> |            "text": “It is safe because […]"
> |        },
> |        {
> |            "id":”SAF-2-safe",
> |            "analyser": {},
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}
> 
> Here is an example to add a new justification in false-positive-cppcheck.json::
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |            "id":"SAF-0-false-positive-cppcheck",
> |            "analyser": {
> |                "cppcheck": "misra-c2012-20.7"
> |            },
> |            “tool-version”: “2.7",
> |            "name": “R20.7 second operand of member-access operator",
> |            "text": "The second operand of a member access operator shall be a name of a member of the type pointed to, so in this particular case it is wrong to use parentheses on the macro parameter."
> |        },
> |        {
> |            "id":”SAF-1-false-positive-cppcheck",
> |            "analyser": {},
> |            “tool-version”: “",
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}
> 
> To document a finding, just add another block {[...]} before the sentinel block,
> using the id contained in the sentinel block and increment by one the number
> contained in the id of the sentinel block.
> 
> Here a brief explanation of the field inside an object of the "content" array:

You don't seem to have a longer explanation afterwards. So I would drop 
"brief".

> - id: it is a unique string that is used to refer to the finding, many finding
>   can be tagged with the same id, if the justification holds for any applied
>   case.
>   It tells the tool to substitute a Xen in-code comment having this structure:
>   /* SAF-0-safe [...] \*/
> - analyser: it is an object containing pair of key-value strings, the key is
>   the analyser, so it can be cppcheck, coverity or eclair. The value is the
>   proprietary id corresponding on the finding, for example when coverity is
>   used as analyser, the tool will translate the Xen in-code coment in this way:
>   /* SAF-0-safe [...] \*/ -> /* coverity[coverity-id] \*/
>   if the object doesn't have a key-value, then the corresponding in-code
>   comment won't be translated.
> - name: a simple name for the finding
> - text: a proper justification to turn off the finding.
> 
> 
> 
> Here an example of the usage of the in-code comment tags to suppress a finding for the Rule 8.6:
> 
> Eclair reports it here:
> https://eclairit.com:3787/fs/var/lib/jenkins/jobs/XEN/configurations/axis-Target/ARM64/axis-agent/public/builds/549/archive/ECLAIR/out/PROJECT.ecd;/sources/xen/include/xen/kernel.h.html#R50743_1

How stable is this link?

The rest of the document LGTM.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:03:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430413.682078 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondFk-0001ud-V5; Wed, 26 Oct 2022 10:03:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430413.682078; Wed, 26 Oct 2022 10:03:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondFk-0001uW-SN; Wed, 26 Oct 2022 10:03:16 +0000
Received: by outflank-mailman (input) for mailman id 430413;
 Wed, 26 Oct 2022 10:03:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=n4Ky=23=citrix.com=prvs=291e24488=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ondFj-0001uM-8p
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:03:15 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6635ab20-5515-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 12:03:13 +0200 (CEST)
Received: from mail-bn1nam07lp2045.outbound.protection.outlook.com (HELO
 NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.45])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 06:03:04 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BLAPR03MB5601.namprd03.prod.outlook.com (2603:10b6:208:293::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct
 2022 10:03:01 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 10:03:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6635ab20-5515-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666778593;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=/dj6E1IkQaulSHiJdixEbL20AVQX8WLqeXxmCXjZJ30=;
  b=ddP6rD7IaMCXKaK/RNxsxi+izl44y2J2Z7Xx9DZrgjHTyeltWfQHikGo
   qiH3/hTAtctwqlElGYCsHu+uEI8idzd4Q29CG4OwfJvCFWecfGpGoOG9w
   2oZs/FB1tjiUFJC7ebtBSUImtfCR9vvxZ/UgBzY1dxWdSjfe7cFRWJ4Vn
   A=;
X-IronPort-RemoteIP: 104.47.51.45
X-IronPort-MID: 86060185
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:4hlfVa7atqKQ+d7jEhEmdwxRtK3GchMFZxGqfqrLsTDasY5as4F+v
 jNJCzvTOa2OMWHweo9/bYSwoRwFsZ+AzIdiTAM4qyBmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4vX1oe7
 fETFApXRRaKnbzt24ixRvBV05FLwMnDZOvzu1lG5BSBV7MMZ8mGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dupTSOpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toiz02LeWzX6TtIQ6Lo285994rHSo5W03CgUOfn+Hu9KdlRvrMz5YA
 wlOksY0loAu/UmiVZ/+GRm1pnGVsxo0VN9ZEul84waIooLI6gOQHS4AQzhOedEinM4wWTEuk
 FSOmrvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKksijrfQ9AlF7S65vX3Fiv32
 CuitzUlivMYistj/6ex8E3DgjmsjoPUVQNz7QLSNkqn8wU/Yoembo6p7FHz7PBcIYLfRV6E1
 FAHltaf6qYSDJiLvC2LXOgJWrqu4p643Cb0hFduG9wr8W2r8nv7IoRIumkieQFuL9oOfiLvb
 AnLowRN6ZRPPXysK6hqf4a2DMdsxq/lfTj4as3pghN1SsAZXGe6EOtGPCZ8A0iFfJAQrJwC
IronPort-HdrOrdr: A9a23:6/REFqvffkqPwJ8qii//Nc8O7skDjNV00zEX/kB9WHVpm6yj+v
 xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379
 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu
 v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="86060185"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EN4H5J9s84e+/aKihC1k7EB9DcRyk0T4OtQGQ9zOoVp5F1vJ5rbhaxMgbJ6DlTGykGN1NbIXkP7l4EokFKKSg2HSV8Sjpd0mXysjOLFLIw7tg7kr4kkKUzPdnAIoLY6JTzabo0YwNGLHKEtNJC2zBt1SeNmPI2CPvNIiI1C194f7Ia/3bOLbNltYKfJn1lkOU6TNVzNmOQ4xuh1Xr4Xg/azodXkDnF7k9KMxyHg7EW51WI/GOIAPbykvLaOOnCbjFjWNjOmkrFY2RcLAkBkbJs7rmDSS0zhBFLFl9v2el+sQxBTNQs/WDk3mc7bsoqoHRehuBcjbmmxj3sOBcswY+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=arextXejh538XjVgOLGFjhVzAL5duyki9VJ4w6Ki4wc=;
 b=KPYYJf4fr5tve2QxJ/p5Zk2DI2RBtqYMm/gDtAIH78v+YnJxD8X7sxXQxYvT1p0mpZ4QmmxOUUwLTOeH8YwFbDeq5GF1o2Jpqxf87qV/Cyy3wpW1bf8wGDYsweaDcu/FtZZPkaY7fdzT4wlXkaaEGuL937bkevCxODPy5QCDgifCWCTdR8hCNX5lojmQ1dR4gVfuRXJ0U0RzdWoXBuiviE307lbdKWLbCM5/ZCeCiqV5pk9kOO05ntNry6mFfzbvcSz16R3Nw5/SX1tWIE3pUSSTAwUS8krYdtk2HVWSdifxEapXr60HJUBzsPEelIaYa2hXBcSe11lCS3SBYazPvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=arextXejh538XjVgOLGFjhVzAL5duyki9VJ4w6Ki4wc=;
 b=LaxxiPTh92neJSHAHl0mhiQmapN28pujILYW6oTCy9azgaJ6ntMEihXaq/YB6TOEdzSJvzgw4w/4N9i36cLcmREVdZVx10tNQWodAeBW1Og8g6ynMfCMajoC3LBiMMW4yuEoZT23ifDT/YLmXaQUr8b3cx6DBwGngLCPwwF5Mfo=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 26 Oct 2022 12:02:54 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
	xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Message-ID: <Y1kFzqJStb/oCKg0@Air-de-Roger>
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <Y1eamiBY0d+julWk@Air-de-Roger>
 <CABfawhk=Awfxu6iBpBtpNF_qKsEW3tMMG4EJzH3okZzdyyESxg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABfawhk=Awfxu6iBpBtpNF_qKsEW3tMMG4EJzH3okZzdyyESxg@mail.gmail.com>
X-ClientProxiedBy: LO4P265CA0074.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2bd::13) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BLAPR03MB5601:EE_
X-MS-Office365-Filtering-Correlation-Id: 2b693ee7-0fa7-4137-95f3-08dab73943ac
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KsnpyipvpDAOinocGXoaIyUQeW7meQI4p8bILf3QIqCCVSBYtvvTpMBV+NZ3hxPR1eGg0BXR1s0xROyGGZZKKoK0vnDilB90H76ALgJ9WodPcn0kcmuzCgAFjYWycNAuNcbJhF+Xblab9M291ev7f6cpTmHwKDPutEhRduHZMBFGogHYTPkDWOWgkjckmXzpvkP7//sbxL84UpxYt9L/4EiNAzUxjxs3W2Gj2I1Hx6QIBpnbYoZZv69LndztWv+FQ4PAonwB4+INxtbWj19leDUa8pLK1nGVRrT+8lQfgsUL2NdKH3YYKznpTcuSuJ4rFVV91jpaasxY8p8gc4FuV+d82lPbtEHq2H1DrX/gkRXO3y/DUliaA5zp/iU8YMVtplNmffFB3mOFLD1A8i2aJc/XgZPVWLOK/3BpgPCJjedvsCzN5V2bLlmATpTN/mLKAi/Rb+OpD4SzWw9hd77MwQ4TWGxaqrtHnbaKcwcJAsGmNM5ajRlXo79Eyscaz646RAhDlu5nxQrJ1FFUitLPEwO+PzR6Vzb/QjO8uWP0t0QsRUXiGEA1Eq5uHXkUOf5p2xOI0x4xQ1czsNCqCoET9M8FBMyiH8J2BcJ3vdLIlNdOJcpfwhUlqzrTV5Z0VBZSRpz3xgA+aKucJ0et184i7YkVsImuHxVDpMN8nxRlTuV09TaaJ1RCNMJW9b3seqQdyRDIZ9S7bpZTMMCTY91VxA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199015)(85182001)(6916009)(54906003)(8676002)(2906002)(5660300002)(186003)(8936002)(86362001)(4326008)(26005)(41300700001)(66476007)(66946007)(66556008)(6512007)(316002)(53546011)(9686003)(6506007)(82960400001)(33716001)(38100700002)(83380400001)(6666004)(478600001)(6486002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGxCNmVpRVM2U1Q2Sm50dlZ2OG5MS1BIUHdhU2tGMk9zajFjcFFJamxSbTNT?=
 =?utf-8?B?cDJHcWRrOEFKNjd0MGlLQWhzZklVNlA5VTdjTVd6aFBKaXI3V0tjUzJ2N29Z?=
 =?utf-8?B?bGg5TDJOT0dLeC9VWm5CWjZJZVh3ZEoyL0txR0l4bFdJazlNU2NhNWszeXdI?=
 =?utf-8?B?aGtsbjlDNjh4R2hZTWtBR1ovUm1IbjFQV1hTaHZ2V3lod3I0WHNsMW1IN01N?=
 =?utf-8?B?cFMwcloxM0NZSEpPek9rRUNXb0pFWTNHTVJmUE9JV2k2L0d3SlpuMDV1Zmpq?=
 =?utf-8?B?bVVtZjJ3SWtOaElmOG0rb2tCZDVpNURyVGtOengwNG1KYnlJOUxqWThQRy85?=
 =?utf-8?B?SGVVSERxU0VKRnczR29QWUFYd1VMUm0zRGtxSTd1dU9PVTJPVXdiNE5WNElP?=
 =?utf-8?B?aEVUL2MrNnpGUkJldU9yNHJCSXpvYkZQNVNzOGJLb3E1Vll0WDNjdlhGSlpm?=
 =?utf-8?B?bEt6WEUzN0QwRmRGM2Q4WWhkOGJTczVpVDVWTm8yWTZrVWxMN2Z2ZGNHNDBr?=
 =?utf-8?B?MVg5bVhvcDVFT3NJd2grS3FEYVpaOU1DdDZrQUIzYk9rWWsxK1JzcTRJTWty?=
 =?utf-8?B?cGpXRTZqWlcyeFBmVEFhTWlmcHN2Z0c1SlRJZVEvUENYNTBEOFNya0dIbXNr?=
 =?utf-8?B?RFM3TVNEVGpvQ1I2NWpURHlDK0l4b000TVArTk9Hc1dFYnJSYVE0WXZuWHcx?=
 =?utf-8?B?MjVOb1BaMHRreFFDakh1bElCTjQrUmNFZlZEWnRTT1lybEFVbWxVaVRacUl5?=
 =?utf-8?B?YjFEOVg1NmtQMUtlZmpXYkNvWFY1TERpWW5ib3B4WWROS2lHL2VkTnBIVXc0?=
 =?utf-8?B?NjNtRmd0ZEdqa0pEWDJ4SWVHaEJIZkczL01rQWpqRUdOUmxCKzVTSlk0MkF3?=
 =?utf-8?B?dDcyanM5SzduYndoNlFTOHVRRHpwbGErbTVuZEJFalpuZWpCZHllWEx5WHJL?=
 =?utf-8?B?V280SnFEckdYUzFTbytScjFmRFYvLzhhK0lGN0FLMzRDOTdraXdoQ3FxTHJI?=
 =?utf-8?B?dDdEQklUSk52MWZIWlVVcHZoTHZZTVE3ZlBhaUk1bk1EY21TakNCSG9XSXFN?=
 =?utf-8?B?REpyTmhIVVZlenUvZHNYTUdWbDVlQUFHR3gxVC9SMCtEd3phZkp0T3VLQVNU?=
 =?utf-8?B?UjRkd0J6akM2c3h5RTFkMyt4bG9jRDRoOXVBR3BkTlhMc0VNUG90NHlVT1l3?=
 =?utf-8?B?ZHlYUGkzMyszSTJFZ084MHNqekhBTDZZMEhITUlkQUdQdExJNkpiME8yZUY4?=
 =?utf-8?B?dGRXSzVVU2srYVhKQi9rQWRWUkc0L3l2a28wT2NYc1l0V1pLQVRwZnZYYndP?=
 =?utf-8?B?MHlLaDQyaWJTblcyZDQ1cGJoaWwzU3FEMWxjQUNFdStQeCtXc1ZDaVp0YW94?=
 =?utf-8?B?ZzJLeWxlZ0c3c3pJUnl2NVVvQnAzNUFyMFFzZVFxNzNYenVRVWFYc1pWV0hp?=
 =?utf-8?B?R2dVVXJtY05MMGJKUFF0ZGFzMWVnRklkVkkxZFAxamNRNEZCQ1IvSDdTWnB3?=
 =?utf-8?B?eW9Xb1F2T0ZYSlJOS242NjFJaVdFRE5lOHRrK0NhMlhkZU5tS1pZbXZIejUz?=
 =?utf-8?B?RjJoY2hEbUxRU1prcDVBVFZJTTdsTzlZNVVMK1hSaCtGTHZocGxMdGJFWEFB?=
 =?utf-8?B?eU1nUTJZbFo2UFRMU0xuS21TdExrSGxJaFd2dTlXUDNXa2lpcCt1UUZzMTBv?=
 =?utf-8?B?aVJVMTJNekxZTnd6S3hmK1ZadVgvb21lM2VoVXRoNEdPZ1RVYlZDc3MrbGFl?=
 =?utf-8?B?N3hlL2N1UzFTS2w5TWtDRTBzcDkybk54RDVYZk5kcUFoUWRnTXhSMzhWR3Ev?=
 =?utf-8?B?TWlLelc1QUdOZGdJRUJyVDNrd3drM2Z5WTBGWkVFNTlrUisyTjNpcW9uWTR1?=
 =?utf-8?B?Tk1XQ3VTdTAxdmRQZFRQVGVjVmRVSVVNRFlPMEo3MTFMcXAzWFVrUFFKVXBm?=
 =?utf-8?B?cC9lODkvQ2ZYQ2c4NU1rbVducU9Ca0J2REFodlpkS1gyZVlVREZJN3ZGeGYw?=
 =?utf-8?B?RXE0MlZXUHJtd080b3NyVVR0ZUx1a3hpQU84aWdzVnVRcHo5VEt0S0p2RVpO?=
 =?utf-8?B?bDZHV01ZQjVNOG1RSnE4YzNCUG1qZjhBQkVHNkVzYTNaMHB5SnhORUJrSVdn?=
 =?utf-8?Q?TJmI/g0djoSbmcNhILTiIWfXS?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b693ee7-0fa7-4137-95f3-08dab73943ac
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 10:03:01.2903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +N87I10YQ3zHzDEAXMxkSTJwFwj5THbEtLzjqM68FCdy3WyONVHQPcRdL4ex0jVJ+GRpSDWZUuTsUS1K3vgjCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5601

On Tue, Oct 25, 2022 at 01:48:36PM -0400, Tamas K Lengyel wrote:
> On Tue, Oct 25, 2022 at 4:13 AM Roger Pau Monné <roger.pau@citrix.com>
> wrote:
> >
> > On Mon, Oct 24, 2022 at 12:58:54PM -0400, Tamas K Lengyel wrote:
> > > Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a
> handful
> > > of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by
> an
> > > external privileged tool is necessary, thus we extend the domctl to
> allow for
> > > querying for any guest MSRs. To remain compatible with the existing
> setup if
> > > no specific MSR is requested via the domctl the default list is
> returned.
> >
> > I'm afraid I would benefit from some extra description about why you
> > need to introduce a separate hook instead of using the existing
> > do_rdmsr hook in arch_vpmu_ops (which is already hooked into
> > guest_rdmsr()).
> >
> > Are the MSRs you are trying to fetch not accessible for the guest
> > itself to read?
> 
> No, the reason we need this different hook is because do_rdmsr assumes the
> guest is reading the MSRs that are currently loaded. For external tools
> where v != current the vpmu context needs to be saved by pausing the vcpu
> first and then the MSR content returned from the saved context.

Hm, I see.

We need to dump the CPU MSR contents into the structure so they can be
read from a different pCPU differently than the currently running one.

It would be nice if this could all be somehow wired into
guest_rdmsr(), but the function executing a vcpu_pause() as part of
it's operations would be quite weird, also it having a vcpu parameter
is kind of misleading, as under some circumstances it will perform a
rdmsr and that's likely only correct when v == current.

I guess I will ask for others opinion, but having that specific vPMU
function call in XEN_DOMCTL_get_vcpu_msrs on the side of guest_rdmsr()
seems like a layering violation, as it should all be contained in
guest_rdmsr().

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:20:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:20:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430421.682111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWX-00059v-W0; Wed, 26 Oct 2022 10:20:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430421.682111; Wed, 26 Oct 2022 10:20:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWX-00059m-Sy; Wed, 26 Oct 2022 10:20:37 +0000
Received: by outflank-mailman (input) for mailman id 430421;
 Wed, 26 Oct 2022 10:20:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ktaj=23=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1ondWW-00057W-9I
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:20:36 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d29b554a-5517-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 12:20:32 +0200 (CEST)
Received: from AM6P192CA0076.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::17)
 by DU0PR08MB8495.eurprd08.prod.outlook.com (2603:10a6:10:404::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 10:20:29 +0000
Received: from AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:8d:cafe::d6) by AM6P192CA0076.outlook.office365.com
 (2603:10a6:209:8d::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 10:20:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT037.mail.protection.outlook.com (100.127.140.225) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 10:20:29 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Wed, 26 Oct 2022 10:20:28 +0000
Received: from e82de94c9f3f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 09C7FF23-605D-4A32-811C-9532A5E6707D.1; 
 Wed, 26 Oct 2022 10:20:22 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e82de94c9f3f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 10:20:22 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by AS8PR08MB6248.eurprd08.prod.outlook.com (2603:10a6:20b:298::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 10:20:20 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 10:20:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d29b554a-5517-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=amzAk+pI2edN+PGuqe4kSybgBwq7/1WyPjyGp5h1H+NKF1o2nLZzbtakFq4yLfu3IElMrlZV/ZFvv84S1s7FpmuBPI0gC/77kl1plFUR3YfzFpJNfov6cgPTDHkUxPmEBS3KHmId1N5B8OLC7xGnP+9lHtJmS6q0IKG62njMyFAzarp5tlB1bB2Hsu+cQKQUfjgOi9Epo/Y3oHuVF6AY64smMZXspJNNn1aR9qiljb33Q79b0KedEIqFEVK7v52zW14s1CBEcNzXBEXgCOylqQ//XAl3l5SB2Mej5bTrxURl07Z1Lc74aB6Wv4mm7fiFhZytIZOPuARpGO1pXv2uzQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RyXPhPts4Vai/7vpUY1xXhX9z8gky+b/vGUdY4Mn2TA=;
 b=Q28YcjvMyja2CdR3G24dCS27i9j3RZH1svSVYBsfLXmEBTcnmdfddmaI2iNHPYLk7NZmsQFTt5owzLCYCRtkDSTyC35Ro1kfOcSNWm7AMsPko9W7A0eZCITF+PrSiEDsGRhzQPoIXIaffs22hkDQ0Ax+C5g6+yD9KJEioKeFYIwQIvB3mApIdPyWzLn9eXMvQffmYLorTlz218RFOhF3nsgYaYSuHHx6EdJ9PR42y1UTuo7zB220iaXdh4OIN5/qTELJf4vm0eiij6Kcm8Pu7HgMLz2ZRm0SgtsSxlJjL6mQLMhBTTe9HNIdBo1/ikRzp9rm9X3/g+0+6gwBIINQaw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RyXPhPts4Vai/7vpUY1xXhX9z8gky+b/vGUdY4Mn2TA=;
 b=o9QOvfW/EcPFjPEKXnt7Qpb+sbDSn7T69t/SES7KPQ5GYWRUxOQ45IATtA7UkG+WtxjeHuKbz8tFtDoZuVz9O7LSaB1UtLbTy6Q9iQWsXesRl3fBjl9+ww3ul1wMvBQskeWY5g3wZ7jBtysw06FVG3cqwMTqBgaVdzRwe6jVFrs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: abf7183d88ed49cf
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cu2h26Q0mokWVNuqFEv/DobIH/EfuvwDm/iwCF9uRYtAP5CVuQpZe+2t7PWPjOQk/QiqL6yAQ27B8PmA0pNx2KK7+lsyyLhB2fUuoqSOUg8QPfkxBG51nL3d/BrUc1b6j0F0y6mlXVxMkriCRjZAV5yWY1KfLQdPIdKH+Dd4mpnixGMtRspRHNhuRB4T3vfJk1bjnV38ze/iOfpvZjrV39faqgcOi2F2U74SMmGeOrL4vFdwigzJuBTi2777GLrfVcp1rNkIkOUKkdfWR5hxJsq1vXdZhWiWyyU5yW/KvDFT5NxE6TxDX9tA7Eys1AMi6FZjGzO5coprv5VF5MontA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RyXPhPts4Vai/7vpUY1xXhX9z8gky+b/vGUdY4Mn2TA=;
 b=i0Gr4d0WLpT3pX/FP1274WrHWWAxLoAbHaI07Sx/FrDQkCzmkVRPNUfx5fU897zCREujf2f5HkhAGgMnhbwMFCV1q70qs3drleXW6RqcTkc2IamNHsYpaICeoGoFa32Wb1pnwiS9req3W+rCmQBaIp/JZrhQtwTnh65pmOIvyUWr1KIgS0xphuZ/IC7wNBAjzkfvmVoqkUFlwpz1UuqS/0+dXPGsU9eiRGW+lMbY0Xw84/JXEj3AZwir357xHMb4eTzdn1BNepVtSVsRObuydSfHPcS26iovIunrTMp2NvogmZR4hNuzxxIEOeT/mlyo0D9HQqaZLO216zU1kBaJtg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RyXPhPts4Vai/7vpUY1xXhX9z8gky+b/vGUdY4Mn2TA=;
 b=o9QOvfW/EcPFjPEKXnt7Qpb+sbDSn7T69t/SES7KPQ5GYWRUxOQ45IATtA7UkG+WtxjeHuKbz8tFtDoZuVz9O7LSaB1UtLbTy6Q9iQWsXesRl3fBjl9+ww3ul1wMvBQskeWY5g3wZ7jBtysw06FVG3cqwMTqBgaVdzRwe6jVFrs=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Subject: Re: [v2] Proposal for deviations in static analyser findings
Thread-Topic: [v2] Proposal for deviations in static analyser findings
Thread-Index: AQHY6FpvvKvqm6eEhUKW2GdsP99AnK4gbCUAgAAMPQA=
Date: Wed, 26 Oct 2022 10:20:19 +0000
Message-ID: <CD551386-FC55-4624-B4BE-D14DAFA1DC74@arm.com>
References: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
 <4ec8b702-aebf-2ce4-78e9-2f72d1b53cc3@xen.org>
In-Reply-To: <4ec8b702-aebf-2ce4-78e9-2f72d1b53cc3@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|AS8PR08MB6248:EE_|AM7EUR03FT037:EE_|DU0PR08MB8495:EE_
X-MS-Office365-Filtering-Correlation-Id: 8530919e-3f15-4654-dc5e-08dab73bb4d1
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 tmkW1d/Tt85qf3fbMtmTGKZrT+xhD2X9NYRkQfsiRuUq9mQLKd591A0Vr1nWkmsrPFtgN/DIsXaW/md1wrOrvuDwxAsAZHQYktllgsaGlJTtqZKJwpCi4mZHX6IFOJ8b0hAr1PC1xl8R5AKPsFwfibcFCtAeie7AkQUeUMZEW7KwALcJY/y6rXyKx0fcdSDTLQsLhGWI1xmCsSVmH18wlB36x784KWfmLtf9jg5opnCbZfQquz53JrS9iQGkgauNzMtxTurOtUOEKBEXKWS9QWHgF/fONDRmEFWjaIcWGEWZyPnXjuvF+JlswwFEBWKYaI2ariX69qJv+eZ4FgN8Dfoztq+q2B6xc9g8MJsYiqQXXcSO98lwfdmgUjZTfegioCiGYHNKov2egZtFqsFAjtOy5dUH8m+INoHoW7WBZN/4QVzUxYDb9OghPZsu2UcdOjmlKMcJjASHc72ab829b08FIL6z38qHQh0mA3xGqaM4t4kcwTZsvtTpRwdpo4IisiesWf+5nDPlT9GH4OV8Plp9kq5ko5DqyUmKWKjajaVgLHx8RUaIO4OP2jGEzn4O07IpAzilbTv7nu4VAq0uxxdtDYw5DXjSVKBnE/B5Mt1WZcrrPPj7vRCwC9wb7lg1MvuT1MS1t+66CUEhQMpWOZHiMHho87nlrDsZNXGF3Nls3vLCNre84d55pYzINFuUhqyUBNuoRhoxf3xZFrZjhdb4C1Ub7JbawFu7w595NHpjHx0gO+c+Ft3861DWw665E/witCoWHCWkv8hKQ1+lVJShepj2od2BHj5qSwSi2Z+2fKu+2sjVeey275oFPI3hfmLEnR84eaZNiZgDWXF5cDiObEtLyj8s+17FH/MkXvFdh/8OHPX2Q8SEsaTTmorg
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199015)(86362001)(36756003)(33656002)(38070700005)(122000001)(38100700002)(2906002)(83380400001)(5660300002)(8936002)(6506007)(2616005)(186003)(53546011)(6512007)(26005)(54906003)(6916009)(8676002)(316002)(66476007)(71200400001)(478600001)(64756008)(76116006)(91956017)(66446008)(66556008)(66946007)(6486002)(966005)(41300700001)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <0BEAE9B929989449A37B7D43075AE199@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6248
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1d7846e2-0406-478d-0ae3-08dab73baf22
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Th+Myq+c3qBqU+QvZRCBmCPhi/6tE/mDPNMzRlPngFBif68MvEOXx2V5NnG9T2Kk1+WFfWxAZj5CD0Zy6naaB6hWZm/fzj6iKHnyWB+TD8k+0nAvyR1x+N+xR5ACwMdOV+6Z/eUdD4d3gvLN8nJRC8ucxao0DgQHmvpjsAclgUhoJaovh8ecAmKKjCPVGsPdjL+u2jNEYVLZS+qhoVPiOzg/ldw9CW5OTIW+01pFqzSD8IbcgssiXVUgjFdyNJztNHQyHaYwZ27+GU8DaqTQX3u398Rj/kzUcTUndTn5p2QjIlDW3pAmf7ijXiM4Q7FAQOPODDme+lIygH9lAJ1v4OqKIaypIwV8fHZ97EQDo5uoHmDlq2Cfag3UiL/rb/YncxGoHTAX83sYjkmtuAwBD6UL5Zrxji7VgeeoZf2DC8gk1B4APE4AJVT8f30pkKPVXC9zUg/lyG8OhH8rs5HxR5SbsUp+ABmDSNt+HNVvMzWVZwU8lQsJqJWpHeHndAffk7pil06D+/NsQbDPwEDWCPX8fm8J2VHv76/zFwb5DWoYrpezyNlJJ6o3zKiuJVaIAu8D1zTxE3uhnJU8vPG53uCxy9/yt6FrYeUai7hp6zimhCzuzECX5rbhF48DZgN5gTxqC+xjRc1dtrNTeRS0Pt2hGcKnclekf9JP+O0lZUHp2pTAMLJTxQPPkJHxBQmHHzfgEqCikmnc3CW0OAuNOrMY+t0IGveKe2/1LJEi/NHCWbpj/pRq+ZBfMtdBtlOZC91VLvHmbrrfhE2FtdrRNrwiXIAgblwYfmh2wWn7vAvR9tRoBBtoaZyXP9zVMIhZxZJuYTBMwusyDMPJI4PmPg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(966005)(478600001)(6486002)(86362001)(83380400001)(70206006)(53546011)(54906003)(6506007)(6512007)(107886003)(8676002)(70586007)(36756003)(4326008)(6862004)(26005)(41300700001)(8936002)(5660300002)(82310400005)(40480700001)(40460700003)(33656002)(2906002)(186003)(2616005)(47076005)(336012)(356005)(81166007)(82740400003)(36860700001)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 10:20:29.0171
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8530919e-3f15-4654-dc5e-08dab73bb4d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8495

DQoNCj4gT24gMjYgT2N0IDIwMjIsIGF0IDEwOjM2LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u
b3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMjUvMTAvMjAyMiAxMToxMywgTHVjYSBGYW5j
ZWxsdSB3cm90ZToNCj4+IEhpIGFsbCwNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBTb21lIGNvbW1l
bnRzIGJlbG93IGlmIHdlIHBsYW4gdG8gbWVyZ2UgdGhlIGRvYyBpbiB0aGUgdHJlZS4NCj4gDQo+
PiBUaGlzIGlzIHRoZSBWMiBvZiB0aGUgcHJvcG9zYWwgZm9yIGRldmlhdGlvbnMgdGFnZ2luZyBp
biB0aGUgWGVuIGNvZGViYXNlLCB0aGlzIGluY2x1ZGVzDQo+PiBhbGwgdGhlIGZlZWRiYWNrcyBm
cm9tIHRoZSBGdVNhIHNlc3Npb24gaGVsZCBhdCB0aGUgWGVuIFN1bW1pdCAyMDIyIGFuZCBhbGwg
dGhlDQo+PiBmZWVkYmFja3MgcmVjZWl2ZWQgaW4gdGhlIHByZXZpb3VzIHByb3Bvc2FsIHNlbnQg
b24gdGhlIG1haWxpbmcgbGlzdC4NCj4+IEhlcmUgYSBsaW5rIHRvIHRoZSBwcmV2aW91cyB0aHJl
YWQ6DQo+PiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRl
dmVsLzIwMjItMTAvbXNnMDA1NDEuaHRtbCA+DQo+PiBEb2N1bWVudGluZyB2aW9sYXRpb25zDQo+
PiA9PT09PT09PT09PT09PT09PT09PT09DQo+PiBTdGF0aWMgYW5hbHlzZXJzIGFyZSB1c2VkIG9u
IHRoZSBYZW4gY29kZWJhc2UgZm9yIGJvdGggc3RhdGljIGFuYWx5c2lzIGFuZCBNSVNSQQ0KPj4g
Y29tcGxpYW5jZS4NCj4+IFRoZXJlIG1pZ2h0IGJlIHRoZSBuZWVkIHRvIHN1cHByZXNzIHNvbWUg
ZmluZGluZ3MgaW5zdGVhZCBvZiBmaXhpbmcgdGhlbSBhbmQNCj4+IG1hbnkgdG9vbHMgcGVybWl0
IHRoZSB1c2FnZSBvZiBpbi1jb2RlIGNvbW1lbnRzIHRoYXQgc3VwcHJlc3MgZmluZGluZ3Mgc28g
dGhhdA0KPj4gdGhleSBhcmUgbm90IHNob3duIGluIHRoZSBmaW5hbCByZXBvcnQuDQo+PiBYZW4g
d2lsbCBpbmNsdWRlIGEgdG9vbCBjYXBhYmxlIG9mIHRyYW5zbGF0aW5nIGEgc3BlY2lmaWMgY29t
bWVudCB1c2VkIGluIGl0cw0KPj4gY29kZWJhc2UgdG8gdGhlIHJpZ2h0IHByb3ByaWV0YXJ5IGlu
LWNvZGUgY29tbWVudCB1bmRlcnN0YW5kYWJsZSBieSB0aGUgc2VsZWN0ZWQNCj4+IGFuYWx5c2Vy
IHRoYXQgc3VwcHJlc3MgaXRzIGZpbmRpbmcuDQo+PiBJbiB0aGUgWGVuIGNvZGViYXNlLCB0aGVz
ZSB0YWdzIHdpbGwgYmUgdXNlZCB0byBkb2N1bWVudCBhbmQgc3VwcHJlc3MgZmluZGluZ3M6DQo+
PiAtIFNBRi1YLXNhZmU6IFRoaXMgdGFnIG1lYW5zIHRoYXQgdGhlIG5leHQgbGluZSBvZiBjb2Rl
IGNvbnRhaW5zIGEgZmluZGluZywgYnV0DQo+PiAgdGhlIG5vbiBjb21wbGlhbmNlIHRvIHRoZSBj
aGVja2VyIGlzIGFuYWx5c2VkIGFuZCBkZW1vbnN0cmF0ZWQgdG8gYmUgc2FmZS4NCj4+IC0gU0FG
LVgtZmFsc2UtcG9zaXRpdmUtPHRvb2w+OiBUaGlzIHRhZyBtZWFucyB0aGF0IHRoZSBuZXh0IGxp
bmUgb2YgY29kZSBjb250YWlucyBhDQo+PiAgZmluZGluZywgYnV0IHRoZSBmaW5kaW5nIGlzIGEg
YnVnIG9mIHRoZSB0b29sLg0KPj4gU0FGIHN0YW5kcyBmb3IgU3RhdGljIEFuYWx5c2VyIEZpbmRp
bmcsIHRoZSBYIGlzIGEgcGxhY2Vob2xkZXIgZm9yIGEgcG9zaXRpdmUNCj4+IG51bWJlciwgdGhl
IG51bWJlciBhZnRlciBTQUYtIHNoYWxsIGJlIGluY3JlbWVudGFsIGFuZCB1bmlxdWUsIGJhc2Ug
dGVuDQo+PiBub3RhdGlvbiBhbmQgd2l0aG91dCBsZWFkaW5nIHplcm9zLg0KPj4gRW50cmllcyBp
biB0aGUgZGF0YWJhc2Ugc2hvdWxkIG5ldmVyIGJlIHJlbW92ZWQsIGV2ZW4gaWYgdGhleSBhcmUg
bm90IHVzZWQNCj4+IGFueW1vcmUgaW4gdGhlIGNvZGUgKGlmIGEgcGF0Y2ggaXMgcmVtb3Zpbmcg
b3IgbW9kaWZ5aW5nIHRoZSBmYXVsdHkgbGluZSkuDQo+PiBUaGlzIGlzIHRvIG1ha2Ugc3VyZSB0
aGF0IG51bWJlcnMgYXJlIG5vdCByZXVzZWQgd2hpY2ggY291bGQgbGVhZCB0byBjb25mbGljdHMN
Cj4+IHdpdGggb2xkIGJyYW5jaGVzIG9yIG1pc2xlYWRpbmcganVzdGlmaWNhdGlvbnMuDQo+PiBB
biBlbnRyeSBjYW4gYmUgcmV1c2VkIGluIG11bHRpcGxlIHBsYWNlcyBpbiB0aGUgY29kZSB0byBz
dXBwcmVzcyBhIGZpbmRpbmcgaWYNCj4+IGFuZCBvbmx5IGlmIHRoZSBqdXN0aWZpY2F0aW9uIGhv
bGRzIGZvciB0aGUgc2FtZSBub24tY29tcGxpYW5jZSB0byB0aGUgY29kaW5nDQo+PiBzdGFuZGFy
ZC4NCj4+IEFuIG9ycGhhbiBlbnRyeSwgdGhhdCBpcyBhbiBlbnRyeSB3aG8gd2FzIGp1c3RpZnlp
bmcgYSBmaW5kaW5nIGluIHRoZSBjb2RlLCBidXQgbGF0ZXINCj4+IHRoYXQgY29kZSB3YXMgcmVt
b3ZlZCBhbmQgdGhlcmUgaXMgbm8gb3RoZXIgdXNlIG9mIHRoYXQgZW50cnkgaW4gdGhlIGNvZGUs
IGNhbiBiZQ0KPj4gcmV1c2VkIGFzIGxvbmcgYXMgdGhlIGp1c3RpZmljYXRpb24gZm9yIHRoZSBm
aW5kaW5nIGhvbGRzLiBUaGlzIGlzIGRvbmUgdG8gYXZvaWQgdGhlDQo+PiBhbGxvY2F0aW9uIG9m
IGEgbmV3IGVudHJ5IHdpdGggZXhhY3RseSB0aGUgc2FtZSBqdXN0aWZpY2F0aW9uLCB0aGF0IHdv
dWxkIGxlYWQgdG8gd2FzdGUNCj4+IG9mIHNwYWNlIGFuZCBtYWludGVuYW5jZSBpc3N1ZXMgb2Yg
dGhlIGRhdGFiYXNlLg0KPj4gVGhlIGZpbGVzIHdoZXJlIHRvIHN0b3JlIGFsbCB0aGUganVzdGlm
aWNhdGlvbnMgYXJlIGluIHhlbi9kb2NzL21pc3JhLyBhbmQgYXJlDQo+PiBuYW1lZCBhcyBzYWZl
Lmpzb24gYW5kIGZhbHNlLXBvc2l0aXZlLTx0b29sPi5qc29uLCB0aGV5IGhhdmUgSlNPTiBmb3Jt
YXQsIGVudHJpZXMNCj4+IG9mIHRoZXNlIGZpbGVzIGhhdmUgaW5kZXBlbmRlbnQgSUQgbnVtYmVy
aW5nLg0KPj4gSGVyZSBpcyBhbiBleGFtcGxlIHRvIGFkZCBhIG5ldyBqdXN0aWZpY2F0aW9uIGlu
IHNhZmUuanNvbjo6DQo+PiB8ew0KPj4gfCAgICAidmVyc2lvbiI6ICIxLjAiLA0KPj4gfCAgICAi
Y29udGVudCI6IFsNCj4+IHwgICAgICAgIHsNCj4+IHwgICAgICAgICAgICAiaWQiOiJTQUYtMC1z
YWZlIiwNCj4+IHwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQo+PiB8ICAgICAgICAgICAgICAg
ICJjcHBjaGVjayI6ICJtaXNyYS1jMjAxMi0yMC43IiwNCj4+IHwgICAgICAgICAgICAgICAgImNv
dmVyaXR5IjogIm1pc3JhX2NfMjAxMl9ydWxlXzIwXzdfdmlvbGF0aW9uIiwNCj4+IHwgICAgICAg
ICAgICAgICAgImVjbGFpciI6ICJNQzNSMS5SMjAuNyINCj4+IHwgICAgICAgICAgICB9LA0KPj4g
fCAgICAgICAgICAgICJuYW1lIjog4oCcUjIwLjcgQyBtYWNybyBwYXJhbWV0ZXJzIG5vdCB1c2Vk
IGFzIGV4cHJlc3Npb24iLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0IjogIlRoZSBtYWNybyBwYXJh
bWV0ZXJzIHVzZWQgaW4gdGhpcyBb4oCmXSINCj4+IHwgICAgICAgIH0sDQo+PiB8ICAgICAgICB7
DQo+PiB8ICAgICAgICAgICAgImlkIjrigJ1TQUYtMS1zYWZlIiwNCj4+IHwgICAgICAgICAgICAi
YW5hbHlzZXIiOiB7DQo+PiB8ICAgICAgICAgICAgICAgICJjcHBjaGVjayI6ICJ1bnJlYWRWYXJp
YWJsZSIsDQo+PiB8ICAgICAgICAgICAgICAgICJjb3Zlcml0eSI6ICJVTlVTRURfVkFMVUUiDQo+
PiB8ICAgICAgICAgICAgfSwNCj4+IHwgICAgICAgICAgICAibmFtZSI6IOKAnFZhcmlhYmxlIHNl
dCBidXQgbm90IHVzZWQiLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0Ijog4oCcSXQgaXMgc2FmZSBi
ZWNhdXNlIFvigKZdIg0KPj4gfCAgICAgICAgfSwNCj4+IHwgICAgICAgIHsNCj4+IHwgICAgICAg
ICAgICAiaWQiOuKAnVNBRi0yLXNhZmUiLA0KPj4gfCAgICAgICAgICAgICJhbmFseXNlciI6IHt9
LA0KPj4gfCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCj4+IHwgICAgICAgICAgICAi
dGV4dCI6ICIiDQo+PiB8ICAgICAgICB9DQo+PiB8ICAgIF0NCj4+IHx9DQo+PiBIZXJlIGlzIGFu
IGV4YW1wbGUgdG8gYWRkIGEgbmV3IGp1c3RpZmljYXRpb24gaW4gZmFsc2UtcG9zaXRpdmUtY3Bw
Y2hlY2suanNvbjo6DQo+PiB8ew0KPj4gfCAgICAidmVyc2lvbiI6ICIxLjAiLA0KPj4gfCAgICAi
Y29udGVudCI6IFsNCj4+IHwgICAgICAgIHsNCj4+IHwgICAgICAgICAgICAiaWQiOiJTQUYtMC1m
YWxzZS1wb3NpdGl2ZS1jcHBjaGVjayIsDQo+PiB8ICAgICAgICAgICAgImFuYWx5c2VyIjogew0K
Pj4gfCAgICAgICAgICAgICAgICAiY3BwY2hlY2siOiAibWlzcmEtYzIwMTItMjAuNyINCj4+IHwg
ICAgICAgICAgICB9LA0KPj4gfCAgICAgICAgICAgIOKAnHRvb2wtdmVyc2lvbuKAnTog4oCcMi43
IiwNCj4+IHwgICAgICAgICAgICAibmFtZSI6IOKAnFIyMC43IHNlY29uZCBvcGVyYW5kIG9mIG1l
bWJlci1hY2Nlc3Mgb3BlcmF0b3IiLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0IjogIlRoZSBzZWNv
bmQgb3BlcmFuZCBvZiBhIG1lbWJlciBhY2Nlc3Mgb3BlcmF0b3Igc2hhbGwgYmUgYSBuYW1lIG9m
IGEgbWVtYmVyIG9mIHRoZSB0eXBlIHBvaW50ZWQgdG8sIHNvIGluIHRoaXMgcGFydGljdWxhciBj
YXNlIGl0IGlzIHdyb25nIHRvIHVzZSBwYXJlbnRoZXNlcyBvbiB0aGUgbWFjcm8gcGFyYW1ldGVy
LiINCj4+IHwgICAgICAgIH0sDQo+PiB8ICAgICAgICB7DQo+PiB8ICAgICAgICAgICAgImlkIjri
gJ1TQUYtMS1mYWxzZS1wb3NpdGl2ZS1jcHBjaGVjayIsDQo+PiB8ICAgICAgICAgICAgImFuYWx5
c2VyIjoge30sDQo+PiB8ICAgICAgICAgICAg4oCcdG9vbC12ZXJzaW9u4oCdOiDigJwiLA0KPj4g
fCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCj4+IHwgICAgICAgICAgICAidGV4dCI6
ICIiDQo+PiB8ICAgICAgICB9DQo+PiB8ICAgIF0NCj4+IHx9DQo+PiBUbyBkb2N1bWVudCBhIGZp
bmRpbmcsIGp1c3QgYWRkIGFub3RoZXIgYmxvY2sge1suLi5dfSBiZWZvcmUgdGhlIHNlbnRpbmVs
IGJsb2NrLA0KPj4gdXNpbmcgdGhlIGlkIGNvbnRhaW5lZCBpbiB0aGUgc2VudGluZWwgYmxvY2sg
YW5kIGluY3JlbWVudCBieSBvbmUgdGhlIG51bWJlcg0KPj4gY29udGFpbmVkIGluIHRoZSBpZCBv
ZiB0aGUgc2VudGluZWwgYmxvY2suDQo+PiBIZXJlIGEgYnJpZWYgZXhwbGFuYXRpb24gb2YgdGhl
IGZpZWxkIGluc2lkZSBhbiBvYmplY3Qgb2YgdGhlICJjb250ZW50IiBhcnJheToNCj4gDQo+IFlv
dSBkb24ndCBzZWVtIHRvIGhhdmUgYSBsb25nZXIgZXhwbGFuYXRpb24gYWZ0ZXJ3YXJkcy4gU28g
SSB3b3VsZCBkcm9wICJicmllZiIuDQoNCk9rIHdpbGwgcmVtb3ZlIGl0DQoNCj4gDQo+PiAtIGlk
OiBpdCBpcyBhIHVuaXF1ZSBzdHJpbmcgdGhhdCBpcyB1c2VkIHRvIHJlZmVyIHRvIHRoZSBmaW5k
aW5nLCBtYW55IGZpbmRpbmcNCj4+ICBjYW4gYmUgdGFnZ2VkIHdpdGggdGhlIHNhbWUgaWQsIGlm
IHRoZSBqdXN0aWZpY2F0aW9uIGhvbGRzIGZvciBhbnkgYXBwbGllZA0KPj4gIGNhc2UuDQo+PiAg
SXQgdGVsbHMgdGhlIHRvb2wgdG8gc3Vic3RpdHV0ZSBhIFhlbiBpbi1jb2RlIGNvbW1lbnQgaGF2
aW5nIHRoaXMgc3RydWN0dXJlOg0KPj4gIC8qIFNBRi0wLXNhZmUgWy4uLl0gXCovDQo+PiAtIGFu
YWx5c2VyOiBpdCBpcyBhbiBvYmplY3QgY29udGFpbmluZyBwYWlyIG9mIGtleS12YWx1ZSBzdHJp
bmdzLCB0aGUga2V5IGlzDQo+PiAgdGhlIGFuYWx5c2VyLCBzbyBpdCBjYW4gYmUgY3BwY2hlY2ss
IGNvdmVyaXR5IG9yIGVjbGFpci4gVGhlIHZhbHVlIGlzIHRoZQ0KPj4gIHByb3ByaWV0YXJ5IGlk
IGNvcnJlc3BvbmRpbmcgb24gdGhlIGZpbmRpbmcsIGZvciBleGFtcGxlIHdoZW4gY292ZXJpdHkg
aXMNCj4+ICB1c2VkIGFzIGFuYWx5c2VyLCB0aGUgdG9vbCB3aWxsIHRyYW5zbGF0ZSB0aGUgWGVu
IGluLWNvZGUgY29tZW50IGluIHRoaXMgd2F5Og0KPj4gIC8qIFNBRi0wLXNhZmUgWy4uLl0gXCov
IC0+IC8qIGNvdmVyaXR5W2NvdmVyaXR5LWlkXSBcKi8NCj4+ICBpZiB0aGUgb2JqZWN0IGRvZXNu
J3QgaGF2ZSBhIGtleS12YWx1ZSwgdGhlbiB0aGUgY29ycmVzcG9uZGluZyBpbi1jb2RlDQo+PiAg
Y29tbWVudCB3b24ndCBiZSB0cmFuc2xhdGVkLg0KPj4gLSBuYW1lOiBhIHNpbXBsZSBuYW1lIGZv
ciB0aGUgZmluZGluZw0KPj4gLSB0ZXh0OiBhIHByb3BlciBqdXN0aWZpY2F0aW9uIHRvIHR1cm4g
b2ZmIHRoZSBmaW5kaW5nLg0KPj4gSGVyZSBhbiBleGFtcGxlIG9mIHRoZSB1c2FnZSBvZiB0aGUg
aW4tY29kZSBjb21tZW50IHRhZ3MgdG8gc3VwcHJlc3MgYSBmaW5kaW5nIGZvciB0aGUgUnVsZSA4
LjY6DQo+PiBFY2xhaXIgcmVwb3J0cyBpdCBoZXJlOg0KPj4gaHR0cHM6Ly9lY2xhaXJpdC5jb206
Mzc4Ny9mcy92YXIvbGliL2plbmtpbnMvam9icy9YRU4vY29uZmlndXJhdGlvbnMvYXhpcy1UYXJn
ZXQvQVJNNjQvYXhpcy1hZ2VudC9wdWJsaWMvYnVpbGRzLzU0OS9hcmNoaXZlL0VDTEFJUi9vdXQv
UFJPSkVDVC5lY2Q7L3NvdXJjZXMveGVuL2luY2x1ZGUveGVuL2tlcm5lbC5oLmh0bWwjUjUwNzQz
XzENCj4gDQo+IEhvdyBzdGFibGUgaXMgdGhpcyBsaW5rPw0KDQpBdCBmaXJzdCBJIHRob3VnaHQg
dG8gZG9u4oCZdCBwdXQgaW4gdGhlIGRvY3VtZW50IHRoZSBleGFtcGxlLCBzbyBJIHdvdWxkIGhh
dmUgZHJvcHBlZCBmcm9tIOKAnEhlcmUgYW4gZXhhbXBsZSBvZiB0aGUgdXNhZ2Ugb2YgdGhlIGlu
LWNvZGUgW+KApl3igJ0sDQpidXQgSSB1bmRlcnN0YW5kIEkgd2FzIG5vdCB2ZXJ5IGNsZWFyIG9u
IHRoYXQsIGFuZCBJIHNlZSB0aGUgZXhhbXBsZSBjb3VsZCBiZSBhbHNvIHVzZWZ1bCwgc28gSSB0
aGluayBJIGNhbiBjcmVhdGUgYSBzZWN0aW9uIGluIHRoZSBkb2N1bWVudA0KbGlrZSB0aGlzIGJl
bG93IGFuZCBJIHdvdWxkIGRyb3AgdGhlIGxpbmsgaW4gZmF2b3VyIG9mIHNvbWUgdGV4dCBmcm9t
IGVjbGFpciByZXBvcnQuDQoNCg0KSnVzdGlmaWNhdGlvbiBleGFtcGxlDQotLS0tLS0tLS0tLS0t
LS0tLS0tLS0NCg0KSGVyZSBhbiBleGFtcGxlIG9mIHRoZSB1c2FnZSBvZiB0aGUgaW4tY29kZSBj
b21tZW50IHRhZ3MgdG8gc3VwcHJlc3MgYSBmaW5kaW5nDQpmb3IgdGhlIFJ1bGUgOC42Og0KDQpF
Y2xhaXIgcmVwb3J0cyBpdCBpbiBpdHMgcmVwb3J0Og0KDQp8IFtlbGNhaXIgcmVwb3J0XSAobm93
IGVjbGFpciBpcyB1bnJlYWNoYWJsZSBmb3IgYW4gaW50ZXJuYWwgZXJyb3IsIEkgd2lsbCB0YWtl
IHRoZSBvdXRwdXQgd2hlbiBpdCB3aWxsIGJlIGJhY2spDQp8IFsuLi5dDQoNCkFsc28gY292ZXJp
dHkgcmVwb3J0cyBpdCwgaGVyZSBhbiBleHRyYWN0IG9mIHRoZSBmaW5kaW5nOg0KDQp8IHhlbi9p
bmNsdWRlL3hlbi9rZXJuZWwuaDo2ODoNCnwgMS4gbWlzcmFfY18yMDEyX3J1bGVfOF82X3Zpb2xh
dGlvbjogRnVuY3Rpb24gIl9zdGFydCIgaXMgZGVjbGFyZWQgYnV0IG5ldmVyDQogZGVmaW5lZC4N
Cg0KVGhlIGFuYWx5c2VycyBhcmUgY29tcGxhaW5pbmcgYmVjYXVzZSB3ZSBoYXZlIHRoaXMgaW4g
eGVuL2luY2x1ZGUveGVuL2tlcm5lbC5oDQphdCBsaW5lIDY4OjoNCg0KfCBleHRlcm4gY2hhciBf
c3RhcnRbXSwgX2VuZFtdLCBzdGFydFtdOw0KDQpUaG9zZSBhcmUgc3ltYm9scyBleHBvcnRlZCBi
eSB0aGUgbGlua2VyLCBoZW5jZSB3ZSB3aWxsIG5lZWQgdG8gaGF2ZSBhIHByb3Blcg0KZGV2aWF0
aW9uIGZvciB0aGlzIGZpbmRpbmcuDQoNCldlIHdpbGwgcHJlcGFyZSBvdXIgZW50cnkgaW4gdGhl
IGRhdGFiYXNlOjoNCg0KfHsNCnwgICAgInZlcnNpb24iOiAiMS4wIiwNCnwgICAgImNvbnRlbnQi
OiBbDQp8ICAgICAgICB7DQp8ICAgICAgICBbLi4uXQ0KfCAgICAgICAgfSwNCnwgICAgICAgIHsN
CnwgICAgICAgICAgICAiaWQiOiAiU0FGLTEtc2FmZSIsDQp8ICAgICAgICAgICAgImFuYWx5c2Vy
Ijogew0KfCAgICAgICAgICAgICAgICDigJxlY2xhaXIiOiAiTUMzUjEuUjguNiIsDQp8ICAgICAg
ICAgICAgICAgICJjb3Zlcml0eSI6ICJtaXNyYV9jXzIwMTJfcnVsZV84XzZfdmlvbGF0aW9uIg0K
fCAgICAgICAgICAgIH0sDQp8ICAgICAgICAgICAgIm5hbWUiOiAiUnVsZSA4LjY6IGxpbmtlciBk
ZWZpbmVkIHN5bWJvbHMiLA0KfCAgICAgICAgICAgICJ0ZXh0IjogIkl0IGlzIHNhZmUgdG8gZGVj
bGFyZSB0aGlzIHN5bWJvbCBiZWNhdXNlIGl0IGlzIGRlZmluZWQgaW4gdGhlIGxpbmtlciBzY3Jp
cHQuIg0KfCAgICAgICAgfSwNCnwgICAgICAgIHsNCnwgICAgICAgICAgICAiaWQiOiAiU0FGLTIt
c2FmZSIsDQp8ICAgICAgICAgICAgImFuYWx5c2VyIjoge30sDQp8ICAgICAgICAgICAgIm5hbWUi
OiAiU2VudGluZWwiLA0KfCAgICAgICAgICAgICJ0ZXh0IjogIiINCnwgICAgICAgIH0NCnwgICAg
XQ0KfH0NCg0KQW5kIHdlIHdpbGwgdXNlIHRoZSBwcm9wZXIgdGFnIGFib3ZlIHRoZSB2aW9sYXRp
b24gbGluZTo6DQoNCnwgLyogU0FGLTEtc2FmZSBbb3B0aW9uYWwgdGV4dF0gKi8NCnwgZXh0ZXJu
IGNoYXIgX3N0YXJ0W10sIF9lbmRbXSwgc3RhcnRbXTsNCg0KVGhpcyBlbnRyeSB3aWxsIGZpeCBh
bHNvIHRoZSB2aW9sYXRpb24gb24gX2VuZCBhbmQgc3RhcnQsIGJlY2F1c2UgdGhleSBhcmUgb24N
CnRoZSBzYW1lIGxpbmUgYW5kIHRoZSBzYW1lICJ2aW9sYXRpb24gSUQiLg0KDQpBbHNvLCB0aGUg
c2FtZSB0YWcgY2FuIGJlIHVzZWQgb24gb3RoZXIgc3ltYm9scyBmcm9tIHRoZSBsaW5rZXIgdGhh
dCBhcmUNCmRlY2xhcmVkIGluIHRoZSBjb2RlYmFzZSwgYmVjYXVzZSB0aGUganVzdGlmaWNhdGlv
biBob2xkcyBmb3IgdGhlbSB0b28uDQoNCg0KPiANCj4gVGhlIHJlc3Qgb2YgdGhlIGRvY3VtZW50
IExHVE0uDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:20:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:20:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430422.682122 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWZ-0005QZ-AL; Wed, 26 Oct 2022 10:20:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430422.682122; Wed, 26 Oct 2022 10:20:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWZ-0005QQ-7H; Wed, 26 Oct 2022 10:20:39 +0000
Received: by outflank-mailman (input) for mailman id 430422;
 Wed, 26 Oct 2022 10:20:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ondWX-0004c6-Of
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:20:37 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3bbc3f4-5517-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 12:20:35 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3bbc3f4-5517-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666779635;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=R02ZMC1k6phfC4hNr6bv6e+rmMsxG/5mpBaH4ZGEwOQ=;
  b=GW2gy6Rf5OpvQZjqvAcRmmv1Fqhivd1drAVFA5BIeOClU/NmRtp86TfC
   bB7djA8kGIjva0Imwbhh0w7ADrSGNQf9FFgz+CjtuvrOjxP8Zaz62/Oj6
   x2gcyX8YXyD+awLAIUJubazwtlDirVFoUwj1jSAvFvZrmbLmzokiT4dSk
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 82629705
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:P8i7P6769hNKx18BiYLetQxRtKjHchMFZxGqfqrLsTDasY5as4F+v
 jRKW2CBMq2JZTOgKI8ja9i//B5V6sDUztZiGgc9rylkHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5LHT1iy
 e4nJwkNVTDcv7yJ6euAeu5V05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP
 oxANGQpPE+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUozQG58EwR7Fz
 o7A10voBggxLu6l8CPG1lWiiffkkBqnW7tHQdVU8dY12QbOlwT/EiY+a1y/pvWoj1+kbPhWI
 UcU5ykGoLA78QqgSdyVdx+lpH+JuDYMVtwWFPc1gCmtx6zO8kCmD24LZjdbbZots8pebTYnz
 EOTltXlQzlmqqSISGm1/62R6zi1PEA9NnQebCUJSQ8E5djLo4wpiB/LCNF5H8adldD+BCvx3
 yGivCU4wbIJgqYjx6i9uFzKnT+ojpzIVRIuoBXaWHq/6QF0b5LjYJangXDE6d5QIYDfSUOO1
 FAmscWD6OEFDbmWiTeABu4KGdmUC+2taWOGxwQ1Rt94qmrrqyXLkZ1sDC9WGFs1HvoWRjDQY
 HTz5jsP27YKB0utVPoiC26uMPgCwa/lHNXjc/nbaNtSf5R8HDO6EDFSiV24hD60zhV1+U0rE
 dLCKJv3Uy5GYUhy5GDuL9rxx4PH0czXKYn7YZnghyqq3rOFDJJ+YedUaQDeBgzVAU7tnek0z
 zq9H5HUo/m8eLekCsUyzWL0BQlTRUXX/bis96Rqmhere2KK4l0JBf7L2q8GcId4halTneqg1
 ijjBBEHkgCu3CSdcVjihpVfhFTHBMgXkJ7GFXZ0YQbAN4YLPe5DE5vzh7NoJOJ6pYSPPNZ/T
 uUfetXoPxi8Ym2vxtjpVrGk9NYKXE3y3WqmZnP1CAXTirY9HmQlDPe/JVCxnMTPZwLq3fYDT
 0qIjFiCEMddGlkzZCsUAdr2p26MUbEmsLoadyP1zhN7IS0ALKACx/TNs8IK
IronPort-HdrOrdr: A9a23:WsNLS6C5F24WvBXlHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8f
 xG/c5rsiMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ8l6U
 4KScZD4bPLYWSS9fyKgzWFLw==
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="82629705"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Xen Security Team
	<security@xen.org>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	"Anthony PERARD" <anthony.perard@citrix.com>
Subject: [PATCH 2/4] tools/tests: Unit test for p2m pool size
Date: Wed, 26 Oct 2022 11:20:16 +0100
Message-ID: <20221026102018.4144-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221026102018.4144-1-andrew.cooper3@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Exercise some basic functionality of the new xc_{get,set}_p2m_mempool_size()
hypercalls.

This passes on x86, but fails currently on ARM.  ARM will be fixed up in
future patches.

This is part of XSA-409 / CVE-2022-33747.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Xen Security Team <security@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Henry Wang <Henry.Wang@arm.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/tests/Makefile                 |   1 +
 tools/tests/p2m-pool/.gitignore      |   1 +
 tools/tests/p2m-pool/Makefile        |  42 ++++++++
 tools/tests/p2m-pool/test-p2m-pool.c | 181 +++++++++++++++++++++++++++++++++++
 4 files changed, 225 insertions(+)
 create mode 100644 tools/tests/p2m-pool/.gitignore
 create mode 100644 tools/tests/p2m-pool/Makefile
 create mode 100644 tools/tests/p2m-pool/test-p2m-pool.c

diff --git a/tools/tests/Makefile b/tools/tests/Makefile
index d99146d56a64..7ce8b7b881db 100644
--- a/tools/tests/Makefile
+++ b/tools/tests/Makefile
@@ -11,6 +11,7 @@ endif
 SUBDIRS-y += xenstore
 SUBDIRS-y += depriv
 SUBDIRS-y += vpci
+SUBDIRS-y += p2m-pool
 
 .PHONY: all clean install distclean uninstall
 all clean distclean install uninstall: %: subdirs-%
diff --git a/tools/tests/p2m-pool/.gitignore b/tools/tests/p2m-pool/.gitignore
new file mode 100644
index 000000000000..cce6d97b1cc8
--- /dev/null
+++ b/tools/tests/p2m-pool/.gitignore
@@ -0,0 +1 @@
+test-p2m-pool
diff --git a/tools/tests/p2m-pool/Makefile b/tools/tests/p2m-pool/Makefile
new file mode 100644
index 000000000000..24f348f20582
--- /dev/null
+++ b/tools/tests/p2m-pool/Makefile
@@ -0,0 +1,42 @@
+XEN_ROOT = $(CURDIR)/../../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+TARGET := test-p2m-pool
+
+.PHONY: all
+all: $(TARGET)
+
+.PHONY: clean
+clean:
+	$(RM) -- *.o $(TARGET) $(DEPS_RM)
+
+.PHONY: distclean
+distclean: clean
+	$(RM) -- *~
+
+.PHONY: install
+install: all
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)
+
+.PHONY: uninstall
+uninstall:
+	$(RM) -- $(DESTDIR)$(LIBEXEC_BIN)/$(TARGET)
+
+CFLAGS += $(CFLAGS_xeninclude)
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenforeginmemory)
+CFLAGS += $(CFLAGS_libxengnttab)
+CFLAGS += $(APPEND_CFLAGS)
+
+LDFLAGS += $(LDLIBS_libxenctrl)
+LDFLAGS += $(LDLIBS_libxenforeignmemory)
+LDFLAGS += $(LDLIBS_libxengnttab)
+LDFLAGS += $(APPEND_LDFLAGS)
+
+%.o: Makefile
+
+$(TARGET): test-p2m-pool.o
+	$(CC) -o $@ $< $(LDFLAGS)
+
+-include $(DEPS_INCLUDE)
diff --git a/tools/tests/p2m-pool/test-p2m-pool.c b/tools/tests/p2m-pool/test-p2m-pool.c
new file mode 100644
index 000000000000..1ffb19eeb420
--- /dev/null
+++ b/tools/tests/p2m-pool/test-p2m-pool.c
@@ -0,0 +1,181 @@
+#include <err.h>
+#include <errno.h>
+#include <inttypes.h>
+#include <stdio.h>
+#include <string.h>
+#include <sys/mman.h>
+
+#include <xenctrl.h>
+#include <xenforeignmemory.h>
+#include <xengnttab.h>
+#include <xen-tools/libs.h>
+
+static unsigned int nr_failures;
+#define fail(fmt, ...)                          \
+({                                              \
+    nr_failures++;                              \
+    (void)printf(fmt, ##__VA_ARGS__);           \
+})
+
+static xc_interface *xch;
+static uint32_t domid;
+
+static struct xen_domctl_createdomain create = {
+    .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap,
+    .max_vcpus = 1,
+    .max_grant_frames = 1,
+    .grant_opts = XEN_DOMCTL_GRANT_version(1),
+
+    .arch = {
+#if defined(__x86_64__) || defined(__i386__)
+        .emulation_flags = XEN_X86_EMU_LAPIC,
+#endif
+    },
+};
+
+static uint64_t default_p2m_size_bytes =
+#if defined(__x86_64__) || defined(__i386__)
+    256 << 12; /* Only x86 HAP for now.  x86 Shadow broken. */
+#elif defined (__arm__) || defined(__aarch64__)
+    16 << 12;
+#endif
+
+static void run_tests(void)
+{
+    xen_pfn_t physmap[] = { 0 };
+    uint64_t size_bytes, old_size_bytes;
+    int rc;
+
+    printf("Test default p2m mempool size\n");
+
+    rc = xc_get_p2m_mempool_size(xch, domid, &size_bytes);
+    if ( rc )
+        return fail("  Fail: get p2m mempool size: %d - %s\n",
+                    errno, strerror(errno));
+
+    printf("P2M pool size %"PRIu64" bytes (%"PRIu64"kB, %"PRIu64"MB)\n",
+           size_bytes, size_bytes >> 10, size_bytes >> 20);
+
+
+    /*
+     * Check that the domain has the expected default allocation size.  This
+     * will fail if the logic in Xen is altered without an equivelent
+     * adjustment here.
+     */
+    if ( size_bytes != default_p2m_size_bytes )
+        return fail("  Fail: size %"PRIu64" != expected size %"PRIu64"\n",
+                    size_bytes, default_p2m_size_bytes);
+
+
+    printf("Test that allocate doesn't alter pool size\n");
+
+    /*
+     * Populate the domain with some RAM.  This will cause more of the p2m
+     * pool to be used.
+     */
+    old_size_bytes = size_bytes;
+
+    rc = xc_domain_setmaxmem(xch, domid, -1);
+    if ( rc )
+        return fail("  Fail: setmaxmem: : %d - %s\n",
+                    errno, strerror(errno));
+
+    rc = xc_domain_populate_physmap_exact(xch, domid, 1, 0, 0, physmap);
+    if ( rc )
+        return fail("  Fail: populate physmap: %d - %s\n",
+                    errno, strerror(errno));
+
+    /*
+     * Re-get the p2m size.  Should not have changed as a consequence of
+     * populate physmap.
+     */
+    rc = xc_get_p2m_mempool_size(xch, domid, &size_bytes);
+    if ( rc )
+        return fail("  Fail: get p2m mempool size: %d - %s\n",
+                    errno, strerror(errno));
+
+    if ( old_size_bytes != size_bytes )
+        return fail("  Fail: p2m mempool size changed %"PRIu64" => %"PRIu64"\n",
+                    old_size_bytes, size_bytes);
+
+
+
+    printf("Test bad set size\n");
+
+    /*
+     * Check that setting a non-page size results in failure.
+     */
+    rc = xc_set_p2m_mempool_size(xch, domid, size_bytes + 1);
+    if ( rc != -1 || errno != EINVAL )
+        return fail("  Fail: Bad set size: expected -1/EINVAL, got %d/%d - %s\n",
+                    rc, errno, strerror(errno));
+
+
+    printf("Test very large set size\n");
+
+    /*
+     * Check that setting a large P2M size succeeds.  This is expecting to
+     * trigger continuations.
+     */
+    rc = xc_set_p2m_mempool_size(xch, domid, 64 << 20);
+    if ( rc )
+        return fail("  Fail: Set size 64MB: %d - %s\n",
+                    errno, strerror(errno));
+
+
+    /*
+     * Check that the reported size matches what set consumed.
+     */
+    rc = xc_get_p2m_mempool_size(xch, domid, &size_bytes);
+    if ( rc )
+        return fail("  Fail: get p2m mempool size: %d - %s\n",
+                    errno, strerror(errno));
+
+    if ( size_bytes != 64 << 20 )
+        return fail("  Fail: expected mempool size %u, got %"PRIu64"\n",
+                    64 << 20, size_bytes);
+}
+
+int main(int argc, char **argv)
+{
+    int rc;
+
+    printf("P2M Shadow memory pool tests\n");
+
+    xch = xc_interface_open(NULL, NULL, 0);
+
+    if ( !xch )
+        err(1, "xc_interface_open");
+
+    rc = xc_domain_create(xch, &domid, &create);
+    if ( rc )
+    {
+        if ( errno == EINVAL || errno == EOPNOTSUPP )
+            printf("  Skip: %d - %s\n", errno, strerror(errno));
+        else
+            fail("  Domain create failure: %d - %s\n",
+                 errno, strerror(errno));
+        goto out;
+    }
+
+    printf("  Created d%u\n", domid);
+
+    run_tests();
+
+    rc = xc_domain_destroy(xch, domid);
+    if ( rc )
+        fail("  Failed to destroy domain: %d - %s\n",
+             errno, strerror(errno));
+ out:
+    return !!nr_failures;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:20:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:20:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430420.682100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWR-0004rV-N6; Wed, 26 Oct 2022 10:20:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430420.682100; Wed, 26 Oct 2022 10:20:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWR-0004rO-K7; Wed, 26 Oct 2022 10:20:31 +0000
Received: by outflank-mailman (input) for mailman id 430420;
 Wed, 26 Oct 2022 10:20:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ondWP-0004c6-JA
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:20:29 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cfd4c801-5517-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 12:20:28 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfd4c801-5517-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666779627;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=UKcW3nevq717wcPG1BpUjMEd9z82OdectilgGlr6jBY=;
  b=EFJbnd+HnLQn6QNs0GvCqGaBVh2+A/ZBgdMBVYE2NYUHJdAllUk6S1cS
   biWv/h0oiaRBdQVTvwWcZOFOkCdn0CmVFOekQjZx3NrlDpZxO7bljXv2p
   XEsn6BgFtVJzA14/lGol/g5boszjYFkk+nLhVtNIRZspeOVnq/llRB2xm
   U=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 86061067
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2Kfluaq6JlESVd4Y40UExfz5xx9eBmKIZRIvgKrLsJaIsI4StFCzt
 garIBmHPK2DM2HwL9p+bY+zoBlXv5HQzoIwHAVrrCE1Q3hH8ZuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR4geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5
 8UBEQwyc0q6isHv3Y2ZcqpFjOstM5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP
 YxDM2MpNUmeJU0UUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0FwB7G/
 zqYoAwVBDkEKdKx7RCoyUu+2NLSjHvnSZpIO/qno6sCbFq7mTVIVUx+uUGAice+jkmyStdOM
 Xs+8yAlrbUx3EGzR9y7VBq9yFaGoxodVtx4A+A8rgaXxcL8wwufHHlCcTdHZ/QvrspwTjsvv
 neDksn1HzVpvPuQQGiE67aPhTqoPG4eKmpqTTQfUQIP7t3noYcyphHCVNBuFOiylNKdMSr9y
 C2QrTQvr6Uei4gMzarT1UDKhXegq4bESiYx5x7LRSS14wVhfomnaoe0r1/B4p5oM4KxXlSH+
 n8elKC2zsoDEJWMnyylW/gWEfei4PPtDdHHqQcxRd97rW3roiP9O9ALiN1jGKt3GtQ9YAbVX
 1KJgA5yvYJsHkPpRKVYbZ3kXqzG0pPcPdjiU/nVaP9HbZ5waBKL8UlSWKKA44z+uBNyyP9iY
 P93Ze7pVC9HUvo/kFJaUs9HidcWKjYCKXQ/rHwR5zCuyvKgaXGcUt/p23PeP7livMtoTOg4m
 uuz1vdmKT0FDoUSgQGNq+b/yGzmylBiXPjLRzR/LLLrH+afMDhJ5wXt6b0gYZd5uK9ei/3F+
 HqwMmcBlgSh2iedeFzTMCg+AF8KYXqYhStlVRHAwH7ygyRzCWpRxPt3m2QLkUkPq7U4kK8co
 wgtcMScGPVfIgkrCBxEBaQRWLdKLUzx7SrXZnLNSGFmL/Zdq/nhp4aMkv3Hr3JVUEJadKIW/
 tWd6+8sacBYHlU/UpuLOZpCDTqZ5BAgpQ67ZGOQSvE7Rakm2NICx/DZ5hPvH/wxFA==
IronPort-HdrOrdr: A9a23:vDmGwq4BXed/QzFLugPXwM7XdLJyesId70hD6qhwISY7TiX+rb
 HJoB17726StN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpN
 5dmsNFZuEYY2IXsS+D2njaL+od
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="86061067"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Xen Security Team
	<security@xen.org>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	"Anthony PERARD" <anthony.perard@citrix.com>
Subject: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size
Date: Wed, 26 Oct 2022 11:20:15 +0100
Message-ID: <20221026102018.4144-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221026102018.4144-1-andrew.cooper3@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems:

 * All set_allocation() flavours have an overflow-before-widen bug when
   calculating "sc->mb << (20 - PAGE_SHIFT)".
 * All flavours have a granularity of of 1M.  This was tolerable when the size
   of the pool could only be set at the same granularity, but is broken now
   that ARM has a 16-page stopgap allocation in use.
 * All get_allocation() flavours round up, and in particular turn 0 into 1,
   meaning the get op returns junk before a successful set op.
 * The x86 flavours reject the hypercalls before the VM has vCPUs allocated,
   despite the pool size being a domain property.
 * Even the hypercall names are long-obsolete.

Implement an interface that doesn't suck, which can be first used to unit test
the behaviour, and subsequently correct a broken implementation.  The old
interface will be retired in due course.

This is part of XSA-409 / CVE-2022-33747.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Xen Security Team <security@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Henry Wang <Henry.Wang@arm.com>
CC: Anthony PERARD <anthony.perard@citrix.com>

Name subject to improvement.  ABI not.  This is the first of many tools ABI
changes required to cleanly separate the logical operation from Xen's choice
of pagetable size.

Future TODOs:
 * x86 shadow still rounds up.  This is buggy as it's a simultaneous equation
   with tot_pages which varies over time with ballooning.
 * x86 PV is weird.  There are no toolstack interact with the shadow pool
   size, but the "shadow" pool it does come into existence when logdirty (or
   pv-l1tf) when first enabled.
 * The shadow+hap logic is in desperate need of deduping.
---
 tools/include/xenctrl.h           |  3 +++
 tools/libs/ctrl/xc_domain.c       | 29 +++++++++++++++++++++++++++++
 xen/arch/arm/p2m.c                | 27 +++++++++++++++++++++++++++
 xen/arch/x86/include/asm/hap.h    |  1 +
 xen/arch/x86/include/asm/shadow.h |  4 ++++
 xen/arch/x86/mm/hap/hap.c         | 10 ++++++++++
 xen/arch/x86/mm/paging.c          | 39 +++++++++++++++++++++++++++++++++++++++
 xen/arch/x86/mm/shadow/common.c   | 10 ++++++++++
 xen/common/domctl.c               | 14 ++++++++++++++
 xen/include/public/domctl.h       | 26 +++++++++++++++++++++++++-
 xen/include/xen/domain.h          |  3 +++
 11 files changed, 165 insertions(+), 1 deletion(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 0c8b4c3aa7a5..f503f03a3927 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -893,6 +893,9 @@ long long xc_logdirty_control(xc_interface *xch,
                               unsigned int mode,
                               xc_shadow_op_stats_t *stats);
 
+int xc_get_p2m_mempool_size(xc_interface *xch, uint32_t domid, uint64_t *size);
+int xc_set_p2m_mempool_size(xc_interface *xch, uint32_t domid, uint64_t size);
+
 int xc_sched_credit_domain_set(xc_interface *xch,
                                uint32_t domid,
                                struct xen_domctl_sched_credit *sdom);
diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index 14c0420c35be..9ac09cfab036 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -706,6 +706,35 @@ long long xc_logdirty_control(xc_interface *xch,
     return (rc == 0) ? domctl.u.shadow_op.pages : rc;
 }
 
+int xc_get_p2m_mempool_size(xc_interface *xch, uint32_t domid, uint64_t *size)
+{
+    int rc;
+    struct xen_domctl domctl = {
+        .cmd         = XEN_DOMCTL_get_p2m_mempool_size,
+        .domain      = domid,
+    };
+
+    rc = do_domctl(xch, &domctl);
+    if ( rc )
+        return rc;
+
+    *size = domctl.u.p2m_mempool.size;
+    return 0;
+}
+
+int xc_set_p2m_mempool_size(xc_interface *xch, uint32_t domid, uint64_t size)
+{
+    struct xen_domctl domctl = {
+        .cmd         = XEN_DOMCTL_set_p2m_mempool_size,
+        .domain      = domid,
+        .u.p2m_mempool = {
+            .size = size,
+        },
+    };
+
+    return do_domctl(xch, &domctl);
+}
+
 int xc_domain_setmaxmem(xc_interface *xch,
                         uint32_t domid,
                         uint64_t max_memkb)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 94d3b60b1387..4607cde6f0b8 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -100,6 +100,14 @@ unsigned int p2m_get_allocation(struct domain *d)
     return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT);
 }
 
+/* Return the size of the pool, in bytes. */
+int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size)
+{
+    *size = ACCESS_ONCE(d->arch.paging.p2m_total_pages) << PAGE_SHIFT;
+
+    return 0;
+}
+
 /*
  * Set the pool of pages to the required number of pages.
  * Returns 0 for success, non-zero for failure.
@@ -157,6 +165,25 @@ int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted)
     return 0;
 }
 
+int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
+{
+    unsigned long pages = size >> PAGE_SHIFT;
+    bool preempted = false;
+    int rc;
+
+    if ( (size & ~PAGE_MASK) ||          /* Non page-sized request? */
+         pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */
+        return -EINVAL;
+
+    spin_lock(&d->arch.paging.lock);
+    rc = p2m_set_allocation(d, pages, &preempted);
+    spin_unlock(&d->arch.paging.lock);
+
+    ASSERT(preempted == (rc == -ERESTART));
+
+    return rc;
+}
+
 int p2m_teardown_allocation(struct domain *d)
 {
     int ret = 0;
diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h
index 90dece29deca..14d2f212dab9 100644
--- a/xen/arch/x86/include/asm/hap.h
+++ b/xen/arch/x86/include/asm/hap.h
@@ -47,6 +47,7 @@ int   hap_track_dirty_vram(struct domain *d,
 extern const struct paging_mode *hap_paging_get_mode(struct vcpu *);
 int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted);
 unsigned int hap_get_allocation(struct domain *d);
+int hap_get_allocation_bytes(struct domain *d, uint64_t *size);
 
 #endif /* XEN_HAP_H */
 
diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h
index 1365fe480518..dad876d29499 100644
--- a/xen/arch/x86/include/asm/shadow.h
+++ b/xen/arch/x86/include/asm/shadow.h
@@ -97,6 +97,8 @@ void shadow_blow_tables_per_domain(struct domain *d);
 int shadow_set_allocation(struct domain *d, unsigned int pages,
                           bool *preempted);
 
+int shadow_get_allocation_bytes(struct domain *d, uint64_t *size);
+
 #else /* !CONFIG_SHADOW_PAGING */
 
 #define shadow_vcpu_teardown(v) ASSERT(is_pv_vcpu(v))
@@ -108,6 +110,8 @@ int shadow_set_allocation(struct domain *d, unsigned int pages,
     ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; })
 #define shadow_set_allocation(d, pages, preempted) \
     ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; })
+#define shadow_get_allocation_bytes(d, size) \
+    ({ ASSERT_UNREACHABLE(); -EOPNOTSUPP; })
 
 static inline void sh_remove_shadows(struct domain *d, mfn_t gmfn,
                                      int fast, int all) {}
diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
index f809ea9aa6ae..50c3d6e63fa5 100644
--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -345,6 +345,16 @@ unsigned int hap_get_allocation(struct domain *d)
             + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0));
 }
 
+int hap_get_allocation_bytes(struct domain *d, uint64_t *size)
+{
+    unsigned long pages = (d->arch.paging.hap.total_pages +
+                           d->arch.paging.hap.p2m_pages);
+
+    *size = pages << PAGE_SHIFT;
+
+    return 0;
+}
+
 /* Set the pool of pages to the required number of pages.
  * Returns 0 for success, non-zero for failure. */
 int hap_set_allocation(struct domain *d, unsigned int pages, bool *preempted)
diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c
index 3a355eee9ca3..b3f7c46e1dfd 100644
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -977,6 +977,45 @@ int __init paging_set_allocation(struct domain *d, unsigned int pages,
 }
 #endif
 
+int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size)
+{
+    int rc;
+
+    if ( is_pv_domain(d) )
+        return -EOPNOTSUPP;
+
+    if ( hap_enabled(d) )
+        rc = hap_get_allocation_bytes(d, size);
+    else
+        rc = shadow_get_allocation_bytes(d, size);
+
+    return rc;
+}
+
+int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
+{
+    unsigned long pages = size >> PAGE_SHIFT;
+    bool preempted = false;
+    int rc;
+
+    if ( is_pv_domain(d) )
+        return -EOPNOTSUPP;
+
+    if ( size & ~PAGE_MASK )             /* Non page-sized request? */
+        return -EINVAL;
+
+    ASSERT(paging_mode_enabled(d));
+
+    paging_lock(d);
+    if ( hap_enabled(d) )
+        rc = hap_set_allocation(d, pages, &preempted);
+    else
+        rc = shadow_set_allocation(d, pages, &preempted);
+    paging_unlock(d);
+
+    return preempted ? -ERESTART : rc;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c
index badfd53c6b23..d190601c4424 100644
--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -1427,6 +1427,16 @@ static unsigned int shadow_get_allocation(struct domain *d)
             + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0));
 }
 
+int shadow_get_allocation_bytes(struct domain *d, uint64_t *size)
+{
+    unsigned long pages = (d->arch.paging.shadow.total_pages +
+                           d->arch.paging.shadow.p2m_pages);
+
+    *size = pages << PAGE_SHIFT;
+
+    return 0;
+}
+
 /**************************************************************************/
 /* Hash table for storing the guest->shadow mappings.
  * The table itself is an array of pointers to shadows; the shadows are then
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 69fb9abd346f..8f318b830185 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -874,6 +874,20 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         ret = iommu_do_domctl(op, d, u_domctl);
         break;
 
+    case XEN_DOMCTL_get_p2m_mempool_size:
+        ret = arch_get_p2m_mempool_size(d, &op->u.p2m_mempool.size);
+        if ( !ret )
+            copyback = 1;
+        break;
+
+    case XEN_DOMCTL_set_p2m_mempool_size:
+        ret = arch_set_p2m_mempool_size(d, op->u.p2m_mempool.size);
+
+        if ( ret == -ERESTART )
+            ret = hypercall_create_continuation(
+                __HYPERVISOR_domctl, "h", u_domctl);
+        break;
+
     default:
         ret = arch_do_domctl(op, d, u_domctl);
         break;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b2ae839c3632..7da09d5925c8 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -214,7 +214,10 @@ struct xen_domctl_getpageframeinfo3 {
  /* Return the bitmap but do not modify internal copy. */
 #define XEN_DOMCTL_SHADOW_OP_PEEK        12
 
-/* Memory allocation accessors. */
+/*
+ * Memory allocation accessors.  These APIs are broken and will be removed.
+ * Use XEN_DOMCTL_{get,set}_p2m_mempool_size instead.
+ */
 #define XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION   30
 #define XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION   31
 
@@ -946,6 +949,24 @@ struct xen_domctl_cacheflush {
     xen_pfn_t start_pfn, nr_pfns;
 };
 
+/*
+ * XEN_DOMCTL_get_p2m_mempool_size / XEN_DOMCTL_set_p2m_mempool_size.
+ *
+ * Get or set the P2M memory pool size.  The size is in bytes.
+ *
+ * The P2M memory pool is a dedicated pool of memory for managing the guest
+ * physical -> host physical mappings, usually containing pagetables.
+ * Implementation details cause there to be a minimum granularity, usually the
+ * size of pagetables used by Xen.  Users of this interface are required to
+ * identify the granularity by other means.
+ *
+ * The set operation can fail midway through the request (e.g. Xen running out
+ * of memory, no free memory to reclaim from the pool, etc.).
+ */
+struct xen_domctl_p2m_mempool {
+    uint64_aligned_t size; /* IN/OUT.  Size in bytes. */
+};
+
 #if defined(__i386__) || defined(__x86_64__)
 struct xen_domctl_vcpu_msr {
     uint32_t         index;
@@ -1274,6 +1295,8 @@ struct xen_domctl {
 #define XEN_DOMCTL_get_cpu_policy                82
 #define XEN_DOMCTL_set_cpu_policy                83
 #define XEN_DOMCTL_vmtrace_op                    84
+#define XEN_DOMCTL_get_p2m_mempool_size          85
+#define XEN_DOMCTL_set_p2m_mempool_size          86
 #define XEN_DOMCTL_gdbsx_guestmemio            1000
 #define XEN_DOMCTL_gdbsx_pausevcpu             1001
 #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
@@ -1335,6 +1358,7 @@ struct xen_domctl {
         struct xen_domctl_psr_alloc         psr_alloc;
         struct xen_domctl_vuart_op          vuart_op;
         struct xen_domctl_vmtrace_op        vmtrace_op;
+        struct xen_domctl_p2m_mempool       p2m_mempool;
         uint8_t                             pad[128];
     } u;
 };
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 2c8116afba27..01aaf4dedbe8 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -98,6 +98,9 @@ void arch_get_info_guest(struct vcpu *, vcpu_guest_context_u);
 int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
+int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size /* bytes */);
+int arch_set_p2m_mempool_size(struct domain *d, uint64_t size /* bytes */);
+
 int domain_relinquish_resources(struct domain *d);
 
 void dump_pageframe_info(struct domain *d);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:20:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:20:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430419.682089 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWQ-0004cO-EY; Wed, 26 Oct 2022 10:20:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430419.682089; Wed, 26 Oct 2022 10:20:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWQ-0004cH-Bb; Wed, 26 Oct 2022 10:20:30 +0000
Received: by outflank-mailman (input) for mailman id 430419;
 Wed, 26 Oct 2022 10:20:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ondWO-0004c6-HY
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:20:28 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce5abfad-5517-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 12:20:27 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce5abfad-5517-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666779626;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=H1k/sRIkYmxFT9UeN76zAOprAdUFwq7qs6VwJ6rRnlc=;
  b=binRtpegyANyAXhWG2/JrqcM7SGjVUT6S0vSsAsY/9fTvrXFElHSWyMp
   5C05QCxaZWlD0FsLGARTiMPBM8Pg3IkNkwToRo1BOdBBUzLVocnStbuJi
   f+i+/0viOACfuBkUvwLGqZekJW7OsuSO6c/zG9F7qJ/F/M82pKxEsclwE
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 86061066
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:34wGr6IrxYsG23KCFE+RQZUlxSXFcZb7ZxGr2PjKsXjdYENSgTxVy
 WsWD2GCM/bYMTf9ed4naoizpB8Dv8DQxoNqHQtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4m1A5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FY8J3cMuX0BCz
 v1bdhIBcBTfrO6YmJvuH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO
 YxJMlKDbzyZC/FLEn4RBIgzg6GDgX7nficDgFmUubA28y7YywkZPL3FYISNJIXSG5s9ckCwo
 FD5rnXpWxcgDPuh7Ge36CKBoNDRtHauMG4VPOLhraM76LGJ/UQtDxkRWUq+sOOOoEe0UNJCK
 GQZ4iMr66M18SSDTMT5XhC+iG6JuFgbQdU4O8037hucjJXd5QmxD3IBCDVGbbQOvsIsWSYj0
 FPPmtrzHCFuq5WcU3fb/bCRxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv54HaWolNzpCBngz
 jbMqzIx750DgMhO26il8FTvhzO3uoOPXgMz/h/QXG+u8kV+foHNT5OswUjW67BHNonxZnurs
 WUAmsOexPsTFpzLnyuIKNjhB5nwuazDameFxwcyQd9xrFxB5kJPY6hS8RZbfRlIPv0FOmHLb
 FHX5Shdysd6aS7CgbBMX6q9DMEjzK7FHNvjV+zJYtcmXqWdZDNr7wk1OxfOgjmFfFwE1PhmZ
 MzFKZrE4WMyU/wP8dagewsKPVbHLAgazHibe530xg/PPVG2NC/MEudt3Ldjg4kEAEK4TOf9q
 Yg32yiikU83vAjCjs7/qNd7ELzyBSJnba0aUuQOHgJ5HiJoGXs6F9jayq47dopuksx9z7mWo
 C7nAB4BkQCn2BUrzDlmjVg6NtvSsWtX9ypnbUTAw370s5TcXWpfxPhGLMZmFVXW3Odi0eR1X
 5E4lzaoW5xypsD8021FN/HV9dU6HDzy3FLmAsZQSGVmF3KWb1eSoYGMk8qG3HRmMxdbQuNk+
 OTxi12GHMtrqsYLJJ++Vc9DBmiZ5RA18N+elWOSSjWPUC0AKLRXFhE=
IronPort-HdrOrdr: A9a23:Y/uJ/KFvER3E5H1OpLqE4seALOsnbusQ8zAXP0AYc3Nom6uj5q
 STdZUgpHrJYVkqOU3I9ersBEDiewK/yXcW2+ks1N6ZNWGM0ldARLsSircKqAePJ8SRzIJgPN
 9bAstDNOE=
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="86061066"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Xen Security Team
	<security@xen.org>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	"Anthony PERARD" <anthony.perard@citrix.com>
Subject: [PATCH for-4.17 0/4] XSA-409 fixes
Date: Wed, 26 Oct 2022 11:20:14 +0100
Message-ID: <20221026102018.4144-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

For 4.17, and backport to all stable releases.

Patch 2 doesn't technically need backporting, but it's safe and I'm
dis-enclined to forgo testing in older releases.

Andrew Cooper (4):
  xen: Introduce non-broken hypercalls for the p2m pool size
  tools/tests: Unit test for p2m pool size
  xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls
  xen/arm: Correct the p2m pool size calculations

 tools/include/xenctrl.h              |   3 +
 tools/libs/ctrl/xc_domain.c          |  29 ++++++
 tools/libs/light/libxl_arm.c         |  14 +--
 tools/libs/light/libxl_dom.c         |  19 ++++
 tools/libs/light/libxl_internal.h    |   3 +
 tools/libs/light/libxl_x86.c         |  15 +--
 tools/tests/Makefile                 |   1 +
 tools/tests/p2m-pool/.gitignore      |   1 +
 tools/tests/p2m-pool/Makefile        |  42 ++++++++
 tools/tests/p2m-pool/test-p2m-pool.c | 181 +++++++++++++++++++++++++++++++++++
 xen/arch/arm/domctl.c                |  53 ----------
 xen/arch/arm/include/asm/p2m.h       |   1 -
 xen/arch/arm/p2m.c                   |  31 ++++--
 xen/arch/x86/include/asm/hap.h       |   1 +
 xen/arch/x86/include/asm/shadow.h    |   4 +
 xen/arch/x86/mm/hap/hap.c            |  10 ++
 xen/arch/x86/mm/paging.c             |  39 ++++++++
 xen/arch/x86/mm/shadow/common.c      |  10 ++
 xen/common/domctl.c                  |  14 +++
 xen/include/public/domctl.h          |  26 ++++-
 xen/include/xen/domain.h             |   3 +
 21 files changed, 411 insertions(+), 89 deletions(-)
 create mode 100644 tools/tests/p2m-pool/.gitignore
 create mode 100644 tools/tests/p2m-pool/Makefile
 create mode 100644 tools/tests/p2m-pool/test-p2m-pool.c

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:20:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:20:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430425.682133 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWq-0006D6-Ji; Wed, 26 Oct 2022 10:20:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430425.682133; Wed, 26 Oct 2022 10:20:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWq-0006Ct-F6; Wed, 26 Oct 2022 10:20:56 +0000
Received: by outflank-mailman (input) for mailman id 430425;
 Wed, 26 Oct 2022 10:20:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ondWp-0004c6-C0
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:20:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de3d0b22-5517-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 12:20:53 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de3d0b22-5517-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666779653;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=6JO0wvwDsV/DC/XiuqlUU3zZyv9PlBtYFfVcD+Dl1Yk=;
  b=ZzKALwUtY2MP2luNc+3vGhB9ir8VR7KrUSPNt9raZQoXsHUyeHE+yggc
   ubX055S7Um8MmQS8cQBIgtfor8MXhWbWa/hhZgmD42Rw3knt6MHJTFGfm
   iH9epURcL6Rw0wSQVzo9OYqz/O4bCViZ9hn6iErAe97nXsd6htflt/rMW
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83149672
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RG+9rq/C2N/jZfLaAU/cDrUDEH6TJUtcMsCJ2f8bNWPcYEJGY0x3n
 WMWDDqCPvaJYGf2eo0jao3i8k1Q7ZDVmN4yTws6ri48E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5AJmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0utHWnt2r
 qIiEzIcfzKg2+WJ/+ufSPY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI
 ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KofTGZQLwRzwS
 mTu5iO+LQ0mapulywGczDX3ic7GhBjyR9dHfFG/3qEz2wDCroAJMzUoUl+8rei8m1SJcdtVI
 EwJ+QIjtaE3skesS7HVXQC8oXOClg4RXZxXCeJSwCGAzLDFpTmQAGcsRyRELtchsaceTzEwy
 kWAmd+vADV1qaCUUlqU7LLSpjS3UQAONnMLbyIASQoD4vHgrZs1gxaJScxseIaug9boAzDs0
 hiaoS54gK8c5eYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPAwUffxeZNKsCeVFbpl
 FoultWa7esOJYqQjyHLS+IIdIxF/N7cbmea2wQ2WcB8qXL9oBZPYLy8/hlzFBxzCp1aQwTrc
 V7xml9W26AKGHm1OPofj52KN+wmyq3pFNLAX//Sb8ZTbpUZSDJr7B2CdmbLgTmzzRFEfbUXf
 M7CLJ3yVSpy5bFPlmLeegsL7VM8KsnSL0v3TIuz8Rmo2KH2iJW9GeZcawvmggzUAcq5TOTpH
 zR3bZXiJ/Z3CreWjszrHWk7dAliEJTDLcqqw/G7j8baSuacJEkvCuXK3ZQqcJF/kqJem4/gp
 y/jBBACkgum3CefdG1mj0yPj5u2A/5CQY8TZ3RwbT5EJVB/CWpQ0EvvX8RuJuR2nACS5fV1U
 +MEa6297gdnE1z6F8AmRcCl9uRKLU3z7SrXZnrNXdTKV8M5L+A/0oS/JVWHGehnJnffiPbSV
 JX6jVqKHMReGlUK4QS/QKvH8m5ddEM1wIpaN3Yk6PEIEKkw2OCG8xDMs8I=
IronPort-HdrOrdr: A9a23:2y1U3qi9oXjHXi8/RW5FVYLsbXBQXuIji2hC6mlwRA09TySZ//
 rBoB19726MtN9xYgBHpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5
 0QF5SWYOeAdWSS5vya3ODXKbkdKaG8gcKVuds=
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="83149672"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Xen Security Team
	<security@xen.org>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	"Anthony PERARD" <anthony.perard@citrix.com>
Subject: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls
Date: Wed, 26 Oct 2022 11:20:17 +0100
Message-ID: <20221026102018.4144-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221026102018.4144-1-andrew.cooper3@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits
of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7.

First of all, with ARM borrowing x86's implementation, the logic to set the
pool size should have been common, not duplicated.  Introduce
libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from
the ARM and x86 paths.  It is left as an exercise to the reader to judge how
libxl/xl can reasonably function without the ability to query the pool size...

Remove ARM's p2m_domctl() infrastructure now the functioanlity has been
replaced with a working and unit tested interface.

This is part of XSA-409 / CVE-2022-33747.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Xen Security Team <security@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Henry Wang <Henry.Wang@arm.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/light/libxl_arm.c      | 14 +----------
 tools/libs/light/libxl_dom.c      | 19 ++++++++++++++
 tools/libs/light/libxl_internal.h |  3 +++
 tools/libs/light/libxl_x86.c      | 15 ++---------
 xen/arch/arm/domctl.c             | 53 ---------------------------------------
 xen/arch/arm/include/asm/p2m.h    |  1 -
 xen/arch/arm/p2m.c                |  8 ------
 7 files changed, 25 insertions(+), 88 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index 2a5e93c28403..2f5615263543 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -209,19 +209,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
                               libxl__domain_build_state *state,
                               uint32_t domid)
 {
-    libxl_ctx *ctx = libxl__gc_owner(gc);
-    unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb, 1024);
-
-    int r = xc_shadow_control(ctx->xch, domid,
-                              XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
-                              &shadow_mb, 0);
-    if (r) {
-        LOGED(ERROR, domid,
-              "Failed to set %u MiB shadow allocation", shadow_mb);
-        return ERROR_FAIL;
-    }
-
-    return 0;
+    return libxl__domain_set_p2m_pool_size(gc, d_config, domid);
 }
 
 int libxl__arch_extra_memory(libxl__gc *gc,
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index 2abaab439c4f..f93b221f1c1f 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t domid,
     return rc;
 }
 
+int libxl__domain_set_p2m_pool_size(
+    libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid)
+{
+    libxl_ctx *ctx = libxl__gc_owner(gc);
+    uint64_t shadow_mem;
+
+    shadow_mem = d_config->b_info.shadow_memkb;
+    shadow_mem <<= 10;
+
+    int r = xc_get_p2m_mempool_size(ctx->xch, domid, &shadow_mem);
+    if (r) {
+        LOGED(ERROR, domid,
+              "Failed to set p2m pool size to %"PRIu64"kB", shadow_mem);
+        return ERROR_FAIL;
+    }
+
+    return 0;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
index cb9e8b3b8b5a..f31164bc6c0d 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -4864,6 +4864,9 @@ int libxl__is_domid_recent(libxl__gc *gc, uint32_t domid, bool *recent);
 /* os-specific implementation of setresuid() */
 int libxl__setresuid(uid_t ruid, uid_t euid, uid_t suid);
 
+_hidden int libxl__domain_set_p2m_pool_size(
+    libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid);
+
 #endif
 
 /*
diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
index 7c5ee74443e5..99aba51d05df 100644
--- a/tools/libs/light/libxl_x86.c
+++ b/tools/libs/light/libxl_x86.c
@@ -538,20 +538,9 @@ int libxl__arch_domain_create(libxl__gc *gc,
         xc_domain_set_time_offset(ctx->xch, domid, rtc_timeoffset);
 
     if (d_config->b_info.type != LIBXL_DOMAIN_TYPE_PV) {
-        unsigned int shadow_mb = DIV_ROUNDUP(d_config->b_info.shadow_memkb,
-                                             1024);
-        int r = xc_shadow_control(ctx->xch, domid,
-                                  XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
-                                  &shadow_mb, 0);
-
-        if (r) {
-            LOGED(ERROR, domid,
-                  "Failed to set %u MiB %s allocation",
-                  shadow_mb,
-                  libxl_defbool_val(d_config->c_info.hap) ? "HAP" : "shadow");
-            ret = ERROR_FAIL;
+        ret = libxl__domain_set_p2m_pool_size(gc, d_config, domid);
+        if (ret)
             goto out;
-        }
     }
 
     if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index c8fdeb124084..1baf25c3d98b 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -47,64 +47,11 @@ static int handle_vuart_init(struct domain *d,
     return rc;
 }
 
-static long p2m_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
-                       XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
-{
-    long rc;
-    bool preempted = false;
-
-    if ( unlikely(d == current->domain) )
-    {
-        printk(XENLOG_ERR "Tried to do a p2m domctl op on itself.\n");
-        return -EINVAL;
-    }
-
-    if ( unlikely(d->is_dying) )
-    {
-        printk(XENLOG_ERR "Tried to do a p2m domctl op on dying domain %u\n",
-               d->domain_id);
-        return -EINVAL;
-    }
-
-    switch ( sc->op )
-    {
-    case XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION:
-    {
-        /* Allow and handle preemption */
-        spin_lock(&d->arch.paging.lock);
-        rc = p2m_set_allocation(d, sc->mb << (20 - PAGE_SHIFT), &preempted);
-        spin_unlock(&d->arch.paging.lock);
-
-        if ( preempted )
-            /* Not finished. Set up to re-run the call. */
-            rc = hypercall_create_continuation(__HYPERVISOR_domctl, "h",
-                                               u_domctl);
-        else
-            /* Finished. Return the new allocation. */
-            sc->mb = p2m_get_allocation(d);
-
-        return rc;
-    }
-    case XEN_DOMCTL_SHADOW_OP_GET_ALLOCATION:
-    {
-        sc->mb = p2m_get_allocation(d);
-        return 0;
-    }
-    default:
-    {
-        printk(XENLOG_ERR "Bad p2m domctl op %u\n", sc->op);
-        return -EINVAL;
-    }
-    }
-}
-
 long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
                     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
 {
     switch ( domctl->cmd )
     {
-    case XEN_DOMCTL_shadow_op:
-        return p2m_domctl(d, &domctl->u.shadow_op, u_domctl);
     case XEN_DOMCTL_cacheflush:
     {
         gfn_t s = _gfn(domctl->u.cacheflush.start_pfn);
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index c8f14d13c2c5..91df922e1c9f 100644
--- a/xen/arch/arm/include/asm/p2m.h
+++ b/xen/arch/arm/include/asm/p2m.h
@@ -222,7 +222,6 @@ void p2m_restore_state(struct vcpu *n);
 /* Print debugging/statistial info about a domain's p2m */
 void p2m_dump_info(struct domain *d);
 
-unsigned int p2m_get_allocation(struct domain *d);
 int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted);
 int p2m_teardown_allocation(struct domain *d);
 
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 4607cde6f0b8..92b678cf0d09 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -92,14 +92,6 @@ static void p2m_free_page(struct domain *d, struct page_info *pg)
     spin_unlock(&d->arch.paging.lock);
 }
 
-/* Return the size of the pool, rounded up to the nearest MB */
-unsigned int p2m_get_allocation(struct domain *d)
-{
-    unsigned long nr_pages = ACCESS_ONCE(d->arch.paging.p2m_total_pages);
-
-    return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT);
-}
-
 /* Return the size of the pool, in bytes. */
 int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size)
 {
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 10:20:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 10:20:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430426.682144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWr-0006WB-QB; Wed, 26 Oct 2022 10:20:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430426.682144; Wed, 26 Oct 2022 10:20:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ondWr-0006W4-Mq; Wed, 26 Oct 2022 10:20:57 +0000
Received: by outflank-mailman (input) for mailman id 430426;
 Wed, 26 Oct 2022 10:20:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ondWq-0004c6-EW
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 10:20:56 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e0276613-5517-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 12:20:55 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0276613-5517-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666779655;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=t5KooTTb63GFPiYoUuuSBv6eBVEQmvOiWx0QPIN98xg=;
  b=DIPP8RbpyuAdb8a800d1bbpOHvVoEFfreEv7uGA7b+wDR3TMQhHtH4Ng
   IPTHrqiR1nhZpvt58IwrzRtk7BstTMGrKkr9Q/y3N4Sym1x8orZYGFt4L
   CtdC1ivOTZONq3LXixZEePa9PpJoBU/SlT7ExDgK0GhQQc4bSZNPxT/TZ
   A=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83149673
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3OoMwa0wGqWOlsj0/vbD5UNxkn2cJEfYwER7XKvMYLTBsI5bpzcGy
 WUeXmiPO6mCYGXwc91yaoS3/UJS75KGx9FjSQRtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlG5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUVyr1tOToQz
 8caOSEvTUyEuN3v5LCkH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO
 pRfOWEHgBfoOnWjPn8+Dp4kkfjurX74azBC83qepLYt4niVxwt0uFToGIqOI4DbG5oO9qqej
 lmd8VjUHBQ2CMeWkQu+1k/2usCSlzyuDer+E5Xnr6U30TV/3Fc7NhoSUleqpOijvWS3UdlfN
 k889zInqO4580nDZtvgWxy1plaUsxhaXMBfe8Ua5QeX2+zr6gCWLmEeS3hKb9lOnMU7XyAw3
 1mF2dbgHyVysaa9QGiYsLyTqFuaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5LC6O+k8f0BSDY0
 z2M6i8kiN07ncMNkqm2413DqzatvYTSCB444B3NWWCo5R8/Y5SqD6S37XDL4PAGK5yWJnGjl
 nUZn8mV7MgVEIqA0ieKRY0w8KqBvqjfdmeG2Bg2Qsdnp2/FF2OfkZ547QElPn8ybPw/ey74Q
 myPvjxuvbtRIy7/BUNoWL6ZB8MvxKnmMN3qUPHIc9ZDCqRMmB+7EDJGPhDJgT20+KQ4ueRmY
 MrAL57wZZoPIf4/pAdaUdvxxlPCKsoW4WrIDa72wB28uVZ1TC7EEOxVWLdigw1Q0U9lnOk32
 4wBXydp408FOAEbXsUw2ddKRW3m1VBhWfjLRzV/L4Zv2DZOFmA7EOP2yrg8YYFjlKk9vr6Wo
 C/iABUJkQOl3SCvxeC2hpdLMe2HYHqChShjYXxE0aiAhxDPnrpDHI9ALsBqLNHLBcRozOJuT
 ultRilzKq0nd9gzwBxENcOVhNU7LHyD3FveVxdJlRBiJvaMsSSSoYS6FuYunQFTZheKWTwW+
 eb5h16FHMdSL+mgZe6PAM+SI5qKlSB1sIpPs4HgebG/pG2EHFBWFhHM
IronPort-HdrOrdr: A9a23:V8FBpqGjbxka7YOKpLqE7seALOsnbusQ8zAXP0AYc3Nom6uj5q
 aTdZUgpHjJYVkqOU3I9ersBEDEewK/yXcX2/h0AV7BZmnbUQKTRekIh7cKgQeQfhEWntQtrJ
 uIGJIRNDSfNzRHZL7BkWqFL+o=
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="83149673"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Xen Security Team
	<security@xen.org>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>,
	"Anthony PERARD" <anthony.perard@citrix.com>
Subject: [PATCH 4/4] xen/arm: Correct the p2m pool size calculations
Date: Wed, 26 Oct 2022 11:20:18 +0100
Message-ID: <20221026102018.4144-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20221026102018.4144-1-andrew.cooper3@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Allocating or freeing p2m pages doesn't alter the size of the mempool; only
the split between free and used pages.

Right now, the hypercalls operate on the free subset of the pool, meaning that
XEN_DOMCTL_get_p2m_mempool_size varies with time as the guest shuffles its
physmap, and XEN_DOMCTL_set_p2m_mempool_size ignores the used subset of the
pool and lets the guest grow unbounded.

This fixes test-p2m-pool on ARM so that the behaviour matches x86.

This is part of XSA-409 / CVE-2022-33747.

Fixes: cbea5a1149ca ("xen/arm: Allocate and free P2M pages from the P2M pool")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Xen Security Team <security@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Henry Wang <Henry.Wang@arm.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
 xen/arch/arm/p2m.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 92b678cf0d09..dd9696c48312 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -72,7 +72,6 @@ static struct page_info *p2m_alloc_page(struct domain *d)
             spin_unlock(&d->arch.paging.lock);
             return NULL;
         }
-        d->arch.paging.p2m_total_pages--;
     }
     spin_unlock(&d->arch.paging.lock);
 
@@ -85,10 +84,7 @@ static void p2m_free_page(struct domain *d, struct page_info *pg)
     if ( is_hardware_domain(d) )
         free_domheap_page(pg);
     else
-    {
-        d->arch.paging.p2m_total_pages++;
         page_list_add_tail(pg, &d->arch.paging.p2m_freelist);
-    }
     spin_unlock(&d->arch.paging.lock);
 }
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:06:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:06:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430454.682167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oneEQ-0004AM-Gs; Wed, 26 Oct 2022 11:05:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430454.682167; Wed, 26 Oct 2022 11:05:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oneEQ-0004AF-Cm; Wed, 26 Oct 2022 11:05:58 +0000
Received: by outflank-mailman (input) for mailman id 430454;
 Wed, 26 Oct 2022 11:05:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oneEP-0004A5-2S; Wed, 26 Oct 2022 11:05:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oneEP-00018v-0M; Wed, 26 Oct 2022 11:05:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oneEO-000289-JN; Wed, 26 Oct 2022 11:05:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oneEO-0001ew-Ix; Wed, 26 Oct 2022 11:05:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=g48LFL3sPVzepsiDTKuQlSypgFPPbpWxTcn098CMFv8=; b=NCmEkt6mdpwY4OwfLDwkzsJ4aZ
	drJnCmVNsLGrfrXb8ETQulN7KYJtaCzE6QDCZWdgp/j0SBzJRNl+BbzkrDDRfOsxCcrNuzMUfQXqc
	xA6p3ImNlJ9ThgJECfKSVlMZ9Z89n5XVQ9dgXX1XdmJz1K5bw4gYlWNxaXrgAVOZu5y8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174369-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174369: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e750a7ace492f0b450653d4ad368a77d6f660fb8
X-Osstest-Versions-That:
    qemuu=0529245488865038344d64fff7ee05864d3d17f6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 11:05:56 +0000

flight 174369 qemu-mainline real [real]
flight 174440 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174369/
http://logs.test-lab.xenproject.org/osstest/logs/174440/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qcow2   21 guest-start/debian.repeat fail REGR. vs. 174155

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174155
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174155
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174155
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174155
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174155
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt   16 saverestore-support-check fail starved in 174155
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 174155
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 174155

version targeted for testing:
 qemuu                e750a7ace492f0b450653d4ad368a77d6f660fb8
baseline version:
 qemuu                0529245488865038344d64fff7ee05864d3d17f6

Last test of basis   174155  2022-10-20 22:37:37 Z    5 days
Testing same since   174369  2022-10-24 21:38:34 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bin Meng <bin.meng@windriver.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Laurent Vivier <laurent@vivier.eu>
  Linus Heckemann <git@sphalerite.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 585 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:06:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:06:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430457.682178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oneEj-0004Uq-RM; Wed, 26 Oct 2022 11:06:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430457.682178; Wed, 26 Oct 2022 11:06:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oneEj-0004Uj-N5; Wed, 26 Oct 2022 11:06:17 +0000
Received: by outflank-mailman (input) for mailman id 430457;
 Wed, 26 Oct 2022 11:06:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oneEi-0004UF-G5
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 11:06:16 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3382b0f8-551e-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 13:06:14 +0200 (CEST)
Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO
 NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 07:06:01 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB6536.namprd03.prod.outlook.com (2603:10b6:a03:394::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 11:05:55 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 11:05:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3382b0f8-551e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666782374;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=OjkB2EtK+PgSY0hM7qYybrQOJJaKiOjzfOJG+aTe394=;
  b=LnSWw3G+c0nGlyRpcdKg9HJ8E4m1XwslRP7BoMvX5eGMM3VVy0FTWoOU
   0T6EHp8WJtP/g2nF2bFvQEajdWdQe72LrEbpuebihIlQJrM/E1dkTF4pW
   XiJTlBm3ZDybnYkXBXJ3eiapmGQZKwOHtt5iWmqrzDqwDwTZ6EgRjAm8y
   8=;
X-IronPort-RemoteIP: 104.47.55.176
X-IronPort-MID: 86063442
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:QkQB7aKBErOpQeUDFE+RL5QlxSXFcZb7ZxGr2PjKsXjdYENS0mMFy
 mYWXTqGOfmMNDamet0lPNjl8BsPsZHVmN9rTQVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4m1A5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FaoJ5e1NIzlrz
 NdGFC8HSBeinubmma3uH4GAhux7RCXqFKU2nyg6iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q/T/PVpi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv
 Dnu9GXlGBAKcteYzFJp91r82LeRxn+nAur+EpWD08VEhHSa91YyASYcckG0vtqhpGCHDoc3x
 0s8v3BGQbIJ3FCiS9DmGRm1pnGVsxo0WtxMHul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9BW0NfygfViMe/sLu5oo0i3rnTNxuDaq0hd3dAizrz
 naBqy1Wr7cOi4gN3qay/1HCihqtoITESkg+4QC/dmGo8AJ/IpKkboqA6F7H4PIGJ4GcJmRtp
 1ABksmaqeoIXZeEkXXXRP1XRe73ofGYLDfbnFhjWYE78Cig8GKieoYW5yxiIEBuMYAPfjqBj
 FLvhD69LaR7ZBOCBZKbqaroYyj25cAMzejYa80=
IronPort-HdrOrdr: A9a23:lh5UdaNTx+rN5cBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u
 Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZtNkIPkjgZJq3PoiFXluYd49NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTOYNSRP5uw+zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY
 fHBK5r
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="86063442"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EZbESgHOuaNSly0dbqYI6CA5vNnV1Cpf38oup0S+sac9fI8LbnFN8nw4JTyqo+Km1ViH0beMQ6J6dhf4rC9BWeNIL4g+rAU9lFqPlwpuliQOjPhb67SIN4jeP5yw1Q/kO1nl6llTJm+DJwrISX9zk16fv5gw0x+TXcPXB75CZ4Tdoyr+2xFfF6nTX+GWgBkE3YPfxRYm8lZgjFbOOkQXl3Go7MP16tEGmgq91aiEXHgaQS63YuaRMu0W/czNynAedLt9ah1uGCEI+XaMU6GuLXpmvsN9YVRh1U6ReymRtPTylqbeOerBvfoa6eI593woLwPyn+M7sAiv4OwY72ccwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OjkB2EtK+PgSY0hM7qYybrQOJJaKiOjzfOJG+aTe394=;
 b=RnNKIueynBlvTLHvgyuIWlebfpAE8TDGHFFPlKXnskc/jMvt8A4fvXirqrMNjMAIDTpJmmAdWcoQsvrDo9//wmF+fN/wOY13Rz2ZPzIR/6d5PqW/Uie1mHTb5m6LMAs+8U3tlw6G2zp4/vw4AO4cutX5gbLb7Q5S0oBqfu4UJ3VZSloIVY9HGcH0MhRCspEBa7iIGuY2TXi7RNM9Ygg0eU7HC4oOCaIR6m2C8wj8RNVLP1IJJDc6wH+/Hx16LC6YmxNMOZpcK73dxyzrHwv61t9CAdpWCkIh7rA3+R1P+Le9Jc8W+oi/hC1FsZAGz27LuKmf5iFscKAFXam/W1asxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OjkB2EtK+PgSY0hM7qYybrQOJJaKiOjzfOJG+aTe394=;
 b=ZAFXy4NVpII6x1TEmG/qazp+U6IdNNI1FSic0ykhQ7qibu/WboWbSXvv8kMRLfKFsvvvhfjHZBmEFrf5RNbbKHrgZQQO7rqG+/fZFEvMopNcAe7yZ7ReiI6mjZnInkRtsnmrNjMi/DganjbprDkCc8lSjR8o8MQu9O/UfJEF+E4=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@intel.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Juergen
 Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Thread-Topic: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Thread-Index: AQHY58oHJ6gDkVUXak23gaU3RLT7hK4ghkAA
Date: Wed, 26 Oct 2022 11:05:54 +0000
Message-ID: <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com>
References:
 <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
In-Reply-To:
 <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6536:EE_
x-ms-office365-filtering-correlation-id: 750edc7a-b74d-4b9e-17a2-08dab7420d87
x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 2wHdbR6bbARxKZmrC05ju846Drpebu9PZPtH0HT3p3ldonHdqbCp9pofCfbk4wvTIps72pVsuWuvC6odE9ycSQwvSM8LH0XevnFCuWLac0ZarOpB2UBd7E66duQohD2dPUR/mgz/42hZRnkE/xIpa6Aae15hMBUSFZzdz/pDrn1+mjs3bD01d7uFcEQkeIzOAG0Y90cgIdS5I3m14iPsWvkNozZyL+r50YOV5IcdmSnyoJGPKd36XdSo1D0xUE2ct3CmvEPh8aNLkKRYXyLipG7H4svu01sxku2x1myI6pD7Id9k7c61ngP2YIhjkzpIoyZDZvLk3Br7zQ7llN1ps1JnqLKBW+uYDi+P3qQg2GIRDo/7ia2ag9OGo79Z7rP9ONVTpOhGsJYTbwE7bEjd9h3PKOmE0uLCFXAXHoAPO3XMpvcg4oeKem5TDCpwDemUTeuA8iBEgvzfIZlZuavsJYqPY/BnDFgm1RjHftPT4vBXR2iZ6sP4LBuZAYp81k5t+yG2FkAGSoYg6foelZuAWKeQQDnY6tR2LrqSI+TafRDTMvLTE9ZXwEiTXGtKzvJsgkaQxSrTV6FMNRhg++1Dxq9j6IsXrTe2p0H9A3hHr9qmBrVDHHamv15dKp75baj5rSynaP/caQLojODwTeZOXqSA4wGw+j2XC4CEVcLrYzFq3IIDQRCYDE6/K5oLE0S98NmfvjsrBKGUrUmej6sAT94Pd38KA1TgYm+S54eciZmi+gKxBnsxNXKtsluTFQwOgmsVCiLdsMtkUVd/yTtoNorDooLYIBSSYEdD8kS1tAAfESKegqEAm63GTYrLbny2/td6FWYsmqS6XgHk9RFRaQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199015)(122000001)(64756008)(316002)(41300700001)(5660300002)(8936002)(2616005)(83380400001)(186003)(82960400001)(38100700002)(2906002)(4326008)(91956017)(8676002)(110136005)(54906003)(36756003)(76116006)(66946007)(66446008)(66556008)(66476007)(6506007)(53546011)(31686004)(38070700005)(31696002)(86362001)(6512007)(26005)(6486002)(478600001)(71200400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?U2E0YW54WitVcStacmowcWxvdUcwOFNHSE1DWE50WGYxZi9YS1FmbWRKYUxX?=
 =?utf-8?B?dDJ5NDg0WDNxUzV3MXlTRHlwQURHOUtFN0tMZGpsb2lxYzVtSGI4OXdDK09Y?=
 =?utf-8?B?VnQ1dDJhSDZ4K0M2OTNUa1FDZFZsaHkzVld4eCtTcG9TM2lkdi8wVmVBeGd0?=
 =?utf-8?B?TGZaVE02N2h0bFNyc2FEdUN4dFBwRUxtWFBINnpYcXpRd1dtdXRhbXBmSktP?=
 =?utf-8?B?K3N6VFVwRWpaMUlYRC94SGcvT253cnlLU2MwdVk2dlVQNDZNdW1VME9pNnF6?=
 =?utf-8?B?YUxuTDBDT0lvalB2WlFVSTlrQkVzS3pjb0QvRytJYzMzUGlwdjIxZURYOEJs?=
 =?utf-8?B?R0E1VUx5SUQxU3dCQWNnejFDazdUdXlvUmdUYlJzbkQvbFNnUFB4NmFvZlk5?=
 =?utf-8?B?NHVDRk1OWlp4eWJaTTFDUUhFQXdocjM2emVtM1c0QnFSZVcyQmdVem11VHJz?=
 =?utf-8?B?dE95d3pxN2xWUGhXai9GMWxaYzNvR3JIb0tuczBVdWJPdnc4T0lxaXc2UU1R?=
 =?utf-8?B?YjduVDBReWNqUDRpOHFBdmEzTzUycGdhRE5HL0V2ZEtCU0laNE9UbzlYVXhY?=
 =?utf-8?B?S2wzOW90a0dIeDFWM25Fd0NiQ2RmOUFnS2N1NDhtVG1JTSsxSEpKZnd1T0Rs?=
 =?utf-8?B?d0RIQ2xlSFc1RW9DSXROZ1VHejF4eklEdjdHbm00MjBrclY5VkRNU3A1NTVW?=
 =?utf-8?B?TjVxRUwxUDlyR0p2M1B4SENJekxKUFRDUFVZY1c5U2dKM09idFhoUythRU12?=
 =?utf-8?B?TUhIQmU3RE5JS2NibHgzMnMrRExJYXVDdUVFL0t6eFpQS1RVT0Q2K2NiV3pP?=
 =?utf-8?B?UzQ4YWE3MXQ5R2NpcG1JWkhvRkhJOEM0MnU3MnRNZjNtQWEyVkRoVFZtbVI2?=
 =?utf-8?B?ellPZ0RqNFl1MDlnTFdEd2hrS2MyN053bjVLRXlnM0RQcUc4UmdtbGNIYlZv?=
 =?utf-8?B?K2VhbXJDckRtRHA0bXVDWUtrcnp0YlhZU1hlMk4rSEU4dlFpQURNUGx4bE8w?=
 =?utf-8?B?bUVrT1M2QjhPK2M1eWo5eDlKK1pHWnZaK3hGMzQyQlNuanl1ZU0rVlU1bXA1?=
 =?utf-8?B?QytpdUpxUUM3NHBIcXdERGk2T0pXcSthYUxrMm5yY1BLQXRIeEQrdWloNklm?=
 =?utf-8?B?cm1kblJwbkhQOUl2MTBpYWN3SXVTNW1Vb3BDakN0YUF0TW0xaGpEN1dxcitH?=
 =?utf-8?B?SDVvcThPbzhjV1ltMCt2d2UwcS9mTFk2T2xuQzU2K1VkQ0dwcm5Ec1JyNXRx?=
 =?utf-8?B?RURyNm1pQzl3R3pYblBYbTMydGJPMndLWXRGb2ZzZVJrcmp4QnVYdlN4cVhj?=
 =?utf-8?B?VXdaVTVnSnZIS0tiTmE0Rmdpcks3NUh0b3Z6cDhuT0dNTFhwN2g2ZytqNVVh?=
 =?utf-8?B?bU9GdlozUmQrNTIwNFZYRE9id0Z2eHBqM1JvQzBRb280Z2gxdk5PZGxwQkU0?=
 =?utf-8?B?bkVoam9FcUdocjVHbTFrOU9ML0dyeG9GRGNyS2MwZ0lES296YURUQ2NJajdL?=
 =?utf-8?B?NHQ1WGxxMkthZC9GaEdUSjByQ1JCSUZzcUo5eTUxbERWaEY1bURPaWJ5OWMr?=
 =?utf-8?B?YjM3SVJNWVBPOE9XVW1BejY5NEFZVnFocnY1NGlhRDY5dmlNdk5hekdXem9m?=
 =?utf-8?B?UU9xTmhiR29MZ2t5dVRpOE9ubTNMV3BUeGthczMzcTdqTkhQUzV3cVgvMEN0?=
 =?utf-8?B?anNjZ0ZVd0ZXcTlZK2hXU01zckVRc3hPUlV3OXNTalRmMXlxaEc3czd2TTAy?=
 =?utf-8?B?bUpRcFQyREt5MUhqdU5pb2hKZHNSdkdtVitBcDBKU3Ftc2pXblVBV1pVTmZl?=
 =?utf-8?B?NnlsNDIwQ055U2kwYXA1TE03UHJCckJ2YXlLOEF6T0ZBY0JZdFJEaXo4VlBx?=
 =?utf-8?B?ZWlJc0RWWGFzaFFUSmQ5M0NxVjExRTZPRDVGTEgvSGF1bVIrVktoSmtSNEVH?=
 =?utf-8?B?WnpLU1ZRYkVyM2lsMHpqZDZaRGdoUzlqWDU1dDlDVnhmKzhrNzVGOUlrYnZU?=
 =?utf-8?B?YTY2Q2ZLdHg1VUxldjhXY3hLQmtKUW1yUVMrOVFFc29tM3JpU2FhTUx6ZDla?=
 =?utf-8?B?UHFJSGI3YjMzTXNCUmFvMHhhUXdlWjI5MTMyRWY0ejJjaEc4eHdITkJueTJ6?=
 =?utf-8?Q?/ImAaSp6q8EJEc0KToidfCjos?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <69DE43BBA32D6640A71DD5B9A0EF1706@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 750edc7a-b74d-4b9e-17a2-08dab7420d87
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 11:05:54.8871
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JB2zEYXbH8fWQRXdE7E24AepxHQUeFCSrChXGY8pm5NGOa2q8CMsuvuQAhJYTBFjx8xQWjMx9OhDRbTbYJBsNvBdWyhOlD+NI5XUI+Y/kXY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6536

T24gMjQvMTAvMjAyMiAxNzo1OCwgVGFtYXMgSyBMZW5neWVsIHdyb3RlOg0KPiBDdXJyZW50bHkg
dGhlIFhFTl9ET01DVExfZ2V0X3ZjcHVfbXNycyBpcyBvbmx5IGNhcGFibGUgb2YgZ2F0aGVyaW5n
IGEgaGFuZGZ1bA0KPiBvZiBwcmVkZXRlcm1pbmVkIHZjcHUgTVNScy4gSW4gb3VyIHVzZS1jYXNl
IGdhdGhlcmluZyB0aGUgdlBNVSBNU1JzIGJ5IGFuDQo+IGV4dGVybmFsIHByaXZpbGVnZWQgdG9v
bCBpcyBuZWNlc3NhcnksIHRodXMgd2UgZXh0ZW5kIHRoZSBkb21jdGwgdG8gYWxsb3cgZm9yDQo+
IHF1ZXJ5aW5nIGZvciBhbnkgZ3Vlc3QgTVNScy4gVG8gcmVtYWluIGNvbXBhdGlibGUgd2l0aCB0
aGUgZXhpc3Rpbmcgc2V0dXAgaWYNCj4gbm8gc3BlY2lmaWMgTVNSIGlzIHJlcXVlc3RlZCB2aWEg
dGhlIGRvbWN0bCB0aGUgZGVmYXVsdCBsaXN0IGlzIHJldHVybmVkLg0KPg0KPiBTaWduZWQtb2Zm
LWJ5OiBUYW1hcyBLIExlbmd5ZWwgPHRhbWFzLmxlbmd5ZWxAaW50ZWwuY29tPg0KDQpOYW1pbmcg
YXNpZGUsIFhFTl9ET01DVExfe2dldCxzZXR9X3ZjcHVfbXNycyBpcyBzdXBwb3NlZCB0byBiZSAi
Z2V0IG1lDQphbGwgTVNScyBuZWVkZWQgdG8gbWlncmF0ZSBhIHZDUFUiLsKgIChJIGRvIGludGVu
ZCB0byByZXRpcmUgdGhlDQpoeXBlcmNhbGwgYXMgcGFydCBvZiBmaXhpbmcgdGhlIFhlbiBzaWRl
IG9mIG1pZ3JhdGlvbiwgYnV0IHRoYXQncyBhZ2VzIGF3YXkpDQoNCkl0IHNlZW1zIGxpa2Ugd2hh
dCB5b3Ugd2FudCBpcyBzb21ldGhpbmcgbW9yZSBsaWtlDQpYRU5fRE9NQ1RMX3tyZCx3cn1tc3Jf
bGlzdMKgIChjb252ZW5pZW50IHRpbWluZywgZ2l2ZW4gdGhlIHJlY2VudCBJU0UNCnVwZGF0ZSku
wqAgSSB0aGluayB0aG9zZSB3b3VsZCBiZSBiZXR0ZXIgYXMgYSBzZXBhcmF0ZSBwYWlyIG9mDQpo
eXBlcmNhbGxzLCByYXRoZXIgdGhhbiB0cnlpbmcgdG8gcmVwdXJwb3NlIGFuIGV4aXN0aW5nIGh5
cGVyY2FsbC4NCg0KDQpBcyBmb3IgYWN0dWFsbHkgZ2V0dGluZyB0aGUgdmFsdWVzLCBwbGVhc2Ug
Zml4IHVwIGd1ZXN0X3tyZCx3cn1tc3IoKSB0bw0KYWNjZXNzIHRoZSBwZXJmIE1TUnMgc2FmZWx5
LsKgIEkga25vdyB0aGUgdnBtdSBNU1IgaGFuZGxpbmcgaXMgaW4gYQ0KdHJhZ2ljIHN0YXRlLCBi
dXQgdGhpcyBuZXcgZ2V0X21zciBzdWJvcCBpcyBtYWtpbmcgdGhlIHByb2JsZW0gZXZlbiBtb3Jl
DQp0YW5nbGVkLg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430472.682192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onec6-0008Jv-0O; Wed, 26 Oct 2022 11:30:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430472.682192; Wed, 26 Oct 2022 11:30:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onec5-0008Jo-Td; Wed, 26 Oct 2022 11:30:25 +0000
Received: by outflank-mailman (input) for mailman id 430472;
 Wed, 26 Oct 2022 11:30:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=azgP=23=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onec4-0008Ji-2U
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 11:30:24 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2065.outbound.protection.outlook.com [40.107.96.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 928c8caf-5521-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 13:30:21 +0200 (CEST)
Received: from BN8PR07CA0034.namprd07.prod.outlook.com (2603:10b6:408:ac::47)
 by IA0PR12MB7505.namprd12.prod.outlook.com (2603:10b6:208:443::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Wed, 26 Oct
 2022 11:30:16 +0000
Received: from BN8NAM11FT105.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ac:cafe::13) by BN8PR07CA0034.outlook.office365.com
 (2603:10b6:408:ac::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 11:30:16 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT105.mail.protection.outlook.com (10.13.176.183) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 26 Oct 2022 11:30:15 +0000
Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 06:30:11 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com
 (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 06:30:01 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 26 Oct 2022 06:30:00 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 928c8caf-5521-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N87Bn6kKXWsIU0qB2EJsRsNajHsXcjNnXlwcHMEwkI4NF4psBn5HW2h1frPZ8tjf5a1Lb7wSANOURwQFCi6nAKE3684Gc+8KX15NuiH8ALOcoUhbNga/XeDOHX9dxfJkH+FZNrtM2acNmRi2CKOhp2eQ+19X5uKHwnaFuxwuYlc/y+KhFoJEglPNQ3z/1Vt6vV/XCHMxU/G/FsmTGF+qxrapQA9/ty4/F8ZYcUp30VKfipkvcnW0rQ6+MTyQZNpZDZT/DQDdF4OJJ6dyMwUdOoxmAJC8KK5cza/scy9QdXrKhoJ5F5aPOXSbpTPBEkanHfObMoPw90C98FL0nMaCzw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1MKL4/bJPIbrbqSmm1MNH2U23zvEtOLoWhA71QkNGbc=;
 b=Y7i9WHdbzf6t6vtz5KtWYY7wi96QNzTtXbh4kMcE02K+Ttcurkmj9LyB6F4hMJ402UEbKTFz6b2SkTUkx6wQ4Ecuj5zPEoD2ZE278gGOWCJobOavcZ8dPw73pjczZbHs26x1oOYAAYxyLwDqtM4ZA/7y3kVQE4bf7gsIiIVL+T4DSEU9cVksDM75U32zBTkiqHHsZ8Yss+CEkRVglAFqaIbV1pKr5XzcN6y0OU+GWSQY6QzKy8BP5GdOWPqLmapFzAoPURic+4/NsmatL438wMb4a6063Oa9hZ6noDthK993HLdPAkUx6J4DAiZVKqCrwjm4q5gN/djsi2k/Fru/Tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1MKL4/bJPIbrbqSmm1MNH2U23zvEtOLoWhA71QkNGbc=;
 b=j5bAkC/mQsBZW3bMCe46w9gGrw4L3FyuF1Tp7eIshsBbmOOWdZXUSKwsaObQOMOtUWtMOL8Au67LjFckHQ5bPKrWt+isIuPs3UtJULDPgFSUTzjJNGeZ9GmkrPt7E9ZIPZfrqqDd0cf2CsG/z5VNrrdGg10z4fCeb1I/qQ3Uf58=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <a3306efe-16bb-feb0-91aa-d6a9b0e30691@amd.com>
Date: Wed, 26 Oct 2022 13:29:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Deadcode discussion based on Arm NS phys timer
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
 <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
 <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com>
 <7C838BB9-E8FA-4239-B851-B179CB6B7A02@arm.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <7C838BB9-E8FA-4239-B851-B179CB6B7A02@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT105:EE_|IA0PR12MB7505:EE_
X-MS-Office365-Filtering-Correlation-Id: 41514440-ea25-45ee-f7dc-08dab7457473
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s+It8KC7SKu7hDUM1WayDCH2nJpVS2B7WhP2jiDXr1B5sIV+lSW6CPfQzXaD60kjvIUKhXSDcBDK3K4cGYiR/IML9vFo2PiBOvm9yi+fCCK71s5epFflMVBAp7Z3Ba3bmikE6TorNQuYxe2T2VsgUS4BhQRMKQ96xIBXi/zjG0Po+9XroqKcExOXYuv2rSsDjFubplfp9UxqJYvOSCua+EzSsP3WVKUuiV8w+zkupygnzjFCwG/HtLYB2tbC5m9J5lvv79ILo3Y0DkYtCF28KKKzHo6mJZf1uTFtGNZwHsjJnZIl3g4D68CsEOltmLcRGgQCedSf3DlCWWymb6e/ZDmVU5XSNNb0ZKFaRgX/H32AJl9nO/S/idKvDTg+eyNnxrjRv8FtyLxJc5+KvMFA8eh9gOwKU92yU3GTj2lHVH85nUWw4kCqw/uGnUMl2jZXBDwSbxWNZddhLJc6oT40r0ue1AYAsniV92e9Rbzyvm+Bg8sp0ZAPH2D4IPfgAi8CE9EU0cvsU4Gx2ThMQeOhS/Gym9e1nN7tKTvq0MwqwX49wcnlgtXjPHMqJmpxorHtaDdRJn5l+rtD+rWGwWctSM81cCwW3YhmtFx80313xuFq9Z+lyqnSHryLk8u5cayiAXSP9b+BRS6EbnQvHgwBQyGynBaT9posJorpNPckPIDaXQpAIIqXeF9Ok06koNLCPjpn/xtcompO/YmQNvHBZME9vr0Gp1YUOF+xgLBI/WwPpuPvvHubZA4xzgDwDwscfaf7k1Ctyg+f7QusceU+/k21Gfi1f9KwWE+m/rr+OLD8qAjctcRkXudZk9U6+q4SWScNGMfcG1AS+qHxhhyRtg==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(31686004)(36756003)(66899015)(82740400003)(36860700001)(5660300002)(70206006)(8936002)(70586007)(83380400001)(426003)(47076005)(86362001)(31696002)(44832011)(356005)(81166007)(110136005)(26005)(186003)(40460700003)(478600001)(2616005)(336012)(40480700001)(16576012)(316002)(41300700001)(82310400005)(8676002)(4326008)(2906002)(53546011)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 11:30:15.9792
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 41514440-ea25-45ee-f7dc-08dab7457473
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT105.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7505

Hi all,

On 25/10/2022 10:20, Bertrand Marquis wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Michal,
> 
>> On 25 Oct 2022, at 09:07, Michal Orzel <michal.orzel@amd.com> wrote:
>>
>> Hi Bertrand,
>>
>> On 25/10/2022 09:45, Bertrand Marquis wrote:
>>>
>>>
>>> Hi Michal,
>>>
>>>> On 25 Oct 2022, at 08:11, Michal Orzel <michal.orzel@amd.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On 25/10/2022 03:29, Stefano Stabellini wrote:
>>>>>
>>>>>
>>>>> On Mon, 24 Oct 2022, Julien Grall wrote:
>>>>>>> On 24/10/2022 12:51, Julien Grall wrote:
>>>>>>>> Caution: This message originated from an External Source. Use proper
>>>>>>>> caution when opening attachments, clicking links, or responding.
>>>>>>>>
>>>>>>>>
>>>>>>>> On 24/10/2022 10:07, Michal Orzel wrote:
>>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> Hi Michal,
>>>>>>>>
>>>>>>>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly
>>>>>>>>> speaking, we are routing
>>>>>>>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use
>>>>>>>>> of it (as it uses the hypervisor timer CNTHP).
>>>>>>>>> This timer is fully emulated, which means that there is nothing that can
>>>>>>>>> trigger such IRQ. This code is
>>>>>>>>> a left over from early days, where the CNTHP was buggy on some models
>>>>>>>>> and we had to use the CNTP instead.
>>>>>>>>>
>>>>>>>>> As far as the problem itself is not really interesting, it raises a
>>>>>>>>> question of what to do with a deadcode,
>>>>>>>>> as there might be/are other deadcode places in Xen.
>>>>>>>>
>>>>>>>> There are multiple definition of deadcode. Depending on which one you
>>>>>>>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
>>>>>>>> would result to a lot of places impacted with the decision.
>>>>>>>>
>>>>>>>> So can you clarify what you mean by deadcode?
>>>>>>> In the timer example, I think we have both a deadcode and unreachable code.
>>>>>>> For the purpose of this discussion, let's take the MISRA definition of a
>>>>>>> deadcode which is a "code that can be executed
>>>>>>> but has no effect on the functional behavior of the program". This differs
>>>>>>> from the unreachable code definition that is
>>>>>>> a "code that cannot be executed". Setting up the IRQ for Xen is an example
>>>>>>> of a deadcode. Code within IRQ handler is an unreachable code
>>>>>>> (there is nothing that can trigger this IRQ).
>>>>>>>
>>>>>>> What I mean by deadcode happens to be the sum of the two cases above i.e.
>>>>>>> the code that cannot be executed as well as the code that
>>>>>>> does not impact the functionality of the program.
>>>>>>>
>>>>>>>>
>>>>>>>>> One may say that it is useful to keep it, because one day,
>>>>>>>>> someone might need it when dealing with yet another broken HW. Such
>>>>>>>>> person would still need to modify the other
>>>>>>>>> part of the code (e.g. reprogram_timer), but there would be less work
>>>>>>>>> required overall. Personally, I'm not in favor of
>>>>>>>>> such approach, because we should not really support possible scenarios
>>>>>>>>> with broken HW (except for erratas listing known issues).
>>>>>>>>
>>>>>>>> The difference between "broken HW" and "HW with known errata" is a bit
>>>>>>>> unclear to me. Can you clarify how you would make the difference here?
>>>>>>>>
>>>>>>>> In particular, at which point do you consider that the HW should not be
>>>>>>>> supported by Xen?
>>>>>>> I'm not saying that HW should not be supported. The difference for me
>>>>>>> between broken HW and
>>>>>>> HW with known errata is that for the former, the incorrect behavior is often
>>>>>>> due to the early support stage,
>>>>>>> using emulators/models instead of real HW, whereas for the latter, the HW is
>>>>>>> already released and it happens to be that it is buggy
>>>>>>> (the HW vendor is aware of the issue and released erratas).
>>>>>>
>>>>>> Thanks for the clarification. What I would call broken is anything that can't
>>>>>> be fixed in software. For a not too fictional example, an HW where PCI devices
>>>>>> are using the same stream ID. So effectively, passthrough can't be safely
>>>>>> supported.
>>>>>>
>>>>>> Regarding, not yet released HW, I don't think Xen should have workaround for
>>>>>> them. I wouldn't even call it "broken" because they are not yet released and
>>>>>> it is common to have bug in early revision.
>>>>>>
>>>>>>> Do we have any example in Xen for supporting broken HW,
>>>>>>> whose vendor is not aware of the issue or did not release any errata?
>>>>>> I will not cite any HW on the ML. But from my experience, the vendors are not
>>>>>> very vocal about issues in public (some don't even seem to have public doc).
>>>>>> The best way to find the issues is to look at Linux commit.
>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>> Also, as part of the certification/FUSA process, there should be no
>>>>>>>>> deadcode and we should have explanation for every block of code.
>>>>>>>>
>>>>>>>> See above. What are you trying to cover by deadcode? Would protecting
>>>>>>>> code with IS_ENABLED() (or #ifdef) ok?
>>>>>>> I think this would be ok from the certification point of view (this would at
>>>>>>> least means, that we are aware of the issue
>>>>>>> and we took some steps). Otherwise, such code is just an example of a
>>>>>>> deadcode/unreachable code.
>>>>>>
>>>>>> Thanks for the clarification. So the exact approach will depend on the
>>>>>> context....
>>>>>>
>>>>>>>>> There are different ways to deal with a deadcode: > 1. Get rid of it
>>>>>>>>> completely
>>>>>>>>> 2. Leave it as it is
>>>>>>
>>>>>> ... this is my preference in the context of the timer.
>>>>>
>>>>> From a certification point of view, the fewer lines of code the better,
>>>>> and ideally all the lines of code used for the certified build should be
>>>>> testable and used.
>>>>>
>>>>> So I think 2. is the lest useful option from a certification
>>>>> perspective. For this reason, I'd prefer another alternative.
>>>>>
>>>>>
>>>>>> If the other don't like it, then 1 would be my preference.
>>>>>>
>>>>>> In general, my preference would be either 3.3 or 3.2 (see below).
>>>>>
>>>>> I also think that 3.2 and 3.3 are good options for the general case. For
>>>>> the timer, I can see why 1 is your (second) preference and I am fine
>>>>> with 1 as well.
>>>> Ok, sounds good to me. Let's still give Bertrand the chance to share his opinion.
>>>
>>> We need to get rid of dead code and removing it is not always the best solution.
>>>
>>> If the code is or could be useful for someone some day, protecting it with ifdef is ok.
>>>
>>> In the mid term we will have to introduce a lot more ifdef or IS_ENABLED in the
>>> code so that we can compile out what we do not need and code not applying to
>>> some hardware is a case where we will do that (does not mean that by default
>>> we will not compile it in but we will make it easier to reduce the code size for a
>>> specific use case).
>>>
>>> So 3.2 and 3.3 are ok for me.
>>
>> So we all agree that the code in the current form is a no go from certification purposes.
>> That is good :)
>>
>> The reason why I opt for solution 1 and not the others is that in the latter case it would
>> mean introducing the Kconfig option to allow user to select the timer to be used by Xen.
>> This is not really correct. Also in the current form, it would also require adding more
>> code to time.c code because at the moment using CNTP for Xen would not work out of the box.
>> The architecture defines the hypervisor timer for a purpose. If it does not work, it means
>> that the HW is problematic. I agree that we would want to support such use case but I'm not
>> really aware of any issue like that. Adding more code and Kconfig options just because
>> one day someone may face issues with a new HW is something I am not a fan of.
> 
> I see 2 solutions here:
> - somehow push the code to a different file (not quite sure this is feasible here)
> - remove completely the code with a clean commit. Doing this it will be easy for someone needing this to later revert the patch
> 
> It is definitely true here that adding more code to keep some unused code does not really make sense.
> And let’s be realistic here, if we need that one day, it will not take ages to support it somehow.
> 
> As said, from a pure certification point of view:
> - we must not have deadcode
> - proper ifdef is acceptable
> - if 0 is not acceptable
> - commented code is not acceptable

Given that we agree on that (+ IS_ENABLED option if possible), and the option 1 seems
to be the best choice for the timer, I will create a patch removing the IRQ path to get rid
of the deadcode/unreachable code.

Do you think this is something we want for 4.17?
The risk is low as the code is already dead and the benefit is that we have no deadcode.
What do you think?

~Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:34:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:34:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430476.682203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onegI-0000VP-HT; Wed, 26 Oct 2022 11:34:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430476.682203; Wed, 26 Oct 2022 11:34:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onegI-0000VF-EG; Wed, 26 Oct 2022 11:34:46 +0000
Received: by outflank-mailman (input) for mailman id 430476;
 Wed, 26 Oct 2022 11:34:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2/Fg=23=gmail.com=tamas.k.lengyel@srs-se1.protection.inumbo.net>)
 id 1onegH-0000V9-Q5
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 11:34:45 +0000
Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com
 [2607:f8b0:4864:20::1129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 300db0b0-5522-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 13:34:44 +0200 (CEST)
Received: by mail-yw1-x1129.google.com with SMTP id
 00721157ae682-369c2f83697so136552167b3.3
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 04:34:44 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 300db0b0-5522-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=4jtWY1izdVLRWtNkMLA9QHRnU+c79+aaIwQzbBtRnTg=;
        b=h6n7rYY9VIdSq53oe2a3k1wECaDtKJFWta6fGn94Sxa+4V5YcK37+hf7jHuCQQ4t46
         u8I6Q0nNv73S3+4OLW6GXhBA+m2KUkXh6fhV8hxF2CYuMFGhzY8uIbBYnIhL80Zx10PB
         EJxjFE1Aotw9P9alm33cuUNVIj+PMllks8IkXgJjyqVRf6vYvs7bLyA4eMi0j1f+R9w3
         5Ot6wEnbCSe8q3NyEZLzN4FqIPUcnMuTyv64CH6z7pda8IXevQA2EsVU6SqHqLH0dNSa
         fX3Pea33M8j9IVEII6z+VYTaZYuO+fmRLDRIllp4XqBAr/MqthKZpmvmuBO/qfFuKJqa
         2YAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=4jtWY1izdVLRWtNkMLA9QHRnU+c79+aaIwQzbBtRnTg=;
        b=kYgCMGoCDEdEJPDTdgrsDPCb2Ff9tS70Uf1lkNj6vhnoc3cBfE8IFpyjBG70Phq6ra
         dTnCY8Ngx0ZmAjp47vJ0iHoF74WtoEyz2fpnIeDRdJMhFrDPrsXqe53YlXtdNLQfD8SN
         h8PpIT7/6QRaCtzlqDmtH7YOf/hlIFxGyo+A1C3CM8huInCqkpBc2oto5Jsxn93bNY7s
         0JOf1QnhJ6VSJmaSodJXrK3F8yEspueDqY495TFmwki6I508UHX5vRFn7mH43AiW7Lr3
         hJ2Mke5XMyUDsugHg4wpq8lnV5NYpQrtIUWqncuHsYdTOra7Nw/sFT1zk3/sOK25KhW2
         +Gqg==
X-Gm-Message-State: ACrzQf2E3H9fqKhSGO358kt/Zss5J4XaiOdOzlJeaACQnTly3GgCIpVU
	SEe/d0P4b54PgJHrkB3a19/bTLbnKMes6AiBZPw=
X-Google-Smtp-Source: AMsMyM663RanbA3obv/EBlnVL8Z+n+u67smkhijARG8vAfoFAXnR5mWFQ82C1+i1IKv5u6spWcdw2jU4CXd0SiZEEWo=
X-Received: by 2002:a81:a109:0:b0:367:efbe:e1f0 with SMTP id
 y9-20020a81a109000000b00367efbee1f0mr32256261ywg.365.1666784082649; Wed, 26
 Oct 2022 04:34:42 -0700 (PDT)
MIME-Version: 1.0
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com>
In-Reply-To: <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com>
From: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Date: Wed, 26 Oct 2022 07:34:31 -0400
Message-ID: <CABfawh=RXrPgj+MA-4QGogM0o3Oo4GEJ3ipbqHKE0TV4GHdCTg@mail.gmail.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>, 
	Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>, 
	Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Content-Type: multipart/alternative; boundary="00000000000029e55f05ebee69d7"

--00000000000029e55f05ebee69d7
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper <Andrew.Cooper3@citrix.com>
wrote:

> On 24/10/2022 17:58, Tamas K Lengyel wrote:
> > Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a
> handful
> > of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by an
> > external privileged tool is necessary, thus we extend the domctl to
> allow for
> > querying for any guest MSRs. To remain compatible with the existing
> setup if
> > no specific MSR is requested via the domctl the default list is returned.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>
> Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be "get me
> all MSRs needed to migrate a vCPU".  (I do intend to retire the
> hypercall as part of fixing the Xen side of migration, but that's ages
> away)
>
> It seems like what you want is something more like
> XEN_DOMCTL_{rd,wr}msr_list  (convenient timing, given the recent ISE
> update).  I think those would be better as a separate pair of
> hypercalls, rather than trying to repurpose an existing hypercall.
>
>
> As for actually getting the values, please fix up guest_{rd,wr}msr() to
> access the perf MSRs safely.  I know the vpmu MSR handling is in a
> tragic state, but this new get_msr subop is making the problem even more
> tangled.
>

Adding a separate hypercall is fine. Unfortunately wiring it into
guest_rdmsr failed on the first attempt when I tried. This is because the
guest itself will hit that path when it reads its own vpmu msrs. The
guest_rdmsr actually fails in that path and a separate fall-back path is
where the vpmu do_rdmsr is called. Now if I wire in the vpmu msrs into
guest_rdmsr I short circuit the existing setup and it looked like a can of
worms. I would have to figure out who is trying to get the vpmu msrs and do
things differently based on that, and the only info we have is if v ==
current. That just looked fragile to me.

Tamas

>

--00000000000029e55f05ebee69d7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper &lt;<a hre=
f=3D"mailto:Andrew.Cooper3@citrix.com">Andrew.Cooper3@citrix.com</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex">On 24/10/2022 17:58, Tamas K L=
engyel wrote:<br>
&gt; Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a =
handful<br>
&gt; of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by=
 an<br>
&gt; external privileged tool is necessary, thus we extend the domctl to al=
low for<br>
&gt; querying for any guest MSRs. To remain compatible with the existing se=
tup if<br>
&gt; no specific MSR is requested via the domctl the default list is return=
ed.<br>
&gt;<br>
&gt; Signed-off-by: Tamas K Lengyel &lt;<a href=3D"mailto:tamas.lengyel@int=
el.com" target=3D"_blank" rel=3D"noreferrer">tamas.lengyel@intel.com</a>&gt=
;<br>
<br>
Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be &quot;get me=
<br>
all MSRs needed to migrate a vCPU&quot;.=C2=A0 (I do intend to retire the<b=
r>
hypercall as part of fixing the Xen side of migration, but that&#39;s ages =
away)<br>
<br>
It seems like what you want is something more like<br>
XEN_DOMCTL_{rd,wr}msr_list=C2=A0 (convenient timing, given the recent ISE<b=
r>
update).=C2=A0 I think those would be better as a separate pair of<br>
hypercalls, rather than trying to repurpose an existing hypercall.<br>
<br>
<br>
As for actually getting the values, please fix up guest_{rd,wr}msr() to<br>
access the perf MSRs safely.=C2=A0 I know the vpmu MSR handling is in a<br>
tragic state, but this new get_msr subop is making the problem even more<br=
>
tangled.<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=
=3D"auto">Adding a separate hypercall is fine. Unfortunately wiring it into=
 guest_rdmsr failed on the first attempt when I tried. This is because the =
guest itself will hit that path when it reads its own vpmu msrs. The guest_=
rdmsr actually fails in that path and a separate fall-back path is where th=
e vpmu do_rdmsr is called. Now if I wire in the vpmu msrs into guest_rdmsr =
I short circuit the existing setup and it looked like a can of worms. I wou=
ld have to figure out who is trying to get the vpmu msrs and do things diff=
erently based on that, and the only info we have is if v =3D=3D current. Th=
at just looked fragile to me.</div><div dir=3D"auto"><br></div><div dir=3D"=
auto">Tamas</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;=
padding-left:1ex">
</blockquote></div></div></div>

--00000000000029e55f05ebee69d7--


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:48:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:48:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430483.682213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onete-0002Kq-Nn; Wed, 26 Oct 2022 11:48:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430483.682213; Wed, 26 Oct 2022 11:48:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onete-0002Kj-L5; Wed, 26 Oct 2022 11:48:34 +0000
Received: by outflank-mailman (input) for mailman id 430483;
 Wed, 26 Oct 2022 11:48:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onetc-0002Kd-Vr
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 11:48:33 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d24fb6b-5524-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 13:48:31 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM8PR04MB7476.eurprd04.prod.outlook.com (2603:10a6:20b:1d1::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 11:48:29 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 11:48:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d24fb6b-5524-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HHuLUVp2y8HHbl6bGOwpjCK79ft20WmXV3rRJPqHqQD9nQoRAHRjNCz/7H2poEzzK5jT9ASpBoHeC7/VGXn1KrfuY6Y1I0MSvyB0Yk2ME2zuMS+ZEGRugVXxZ8gMYeO5uGeu9Qnnx7w2XaKq0PuabEfMga2S0z78j/axirnnKUvx1GQkJzwBg5ITGxYpBpjCFTIDb+AQU8zAafu5sEkg2zung5Xq1kux3dbDSOJBBIeDu28dOHBioKfCd3TLJYkxEhVo95WSWzQXcrqLE6IDfncIAddCi9oGoo9XTdvS5/ZK3JsN/CfJ/MIivCVSYYKXvUqDi+BHzLULwCQ9FCse+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eDMMaTAp4EGr2Zc5Zpmc5NR5QgXKacEiNe6VHnlr6Os=;
 b=f9suORdRji2SS/6/+d3Grrbs0VABmLn91Gh8/a1ZOrXyW5F2+kuW6UzvPF6ShzsM08SBJGJLdidAomLK2M26wYKVur3NkcCteL4jX1pCLt+twrzx83HciE0S/mFdcJ1+ubsctqiTtukh3pYKggL+51sAIhLcM30Xh8PkOOZE9PEyOD/Tt+HNcxgcjaNlwFPlOpe70zlPeO6/WRSjXpCDvPZKh5vaYu8fHtcv1bxZvOct5mj+MdOsfAicodIaFngwHwaKuhXtzVGQEiklb963Y4w+xfRY0uB5JxQemSN9z7uL3oKjaQ/18KFZl+3uzwuOvSRTq+IEoeeQcIuvnLDwww==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eDMMaTAp4EGr2Zc5Zpmc5NR5QgXKacEiNe6VHnlr6Os=;
 b=cyUZCB+Xz/+RrDZ/diAiAVmzHLjDVuOGwJEQZ1IGlpDzx8R0a4TEQRbjp2nhF2NMJS1KMMuGZpQtKBfYULFW/m6fQ/97aU52blQWFTaYLNCxBa8ogq5KdzierW9AbKEES80bWThgfwWVVDfJrU5sNAp/CYIf3/4E2k2i1wuKVL/UODXrztYL946sENUsVHtXQB+Ejia9EgjzGz3a+EKf1UIj9AttDBfALYYQPnmJc+8T3tf7Fx/3rPzA2MSc7mWq+TcNJH0jfbzw5lqG+fQXXNlwZkRBxbU2AE5My+vaZ31+bazx4fhXaoSzb+UD1/IdFxJlw2MZImmDuZcqTLRAyA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f5673a0a-853e-fa2c-2f4c-e76b7b7aba87@suse.com>
Date: Wed, 26 Oct 2022 13:48:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Content-Language: en-US
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Jun Nakajima
 <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com>
 <CABfawh=RXrPgj+MA-4QGogM0o3Oo4GEJ3ipbqHKE0TV4GHdCTg@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawh=RXrPgj+MA-4QGogM0o3Oo4GEJ3ipbqHKE0TV4GHdCTg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7476:EE_
X-MS-Office365-Filtering-Correlation-Id: 719579dd-7c41-454f-ce0f-08dab747ffa0
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ShfEva4IcQ7ERPjq+0FOC72Cy+iSyd8favNQR9hGGRtoIc9HEtpRRMmPMfUV6YZOfy8yD70StOVCCe5gR9kQx9UBb463PZMV9xkLcAvFTAFgcxcAPjTyNAjvGxjvPtqiKWJeBOXGz8uj1KDMZ6z+gLaLNUdWbCe6OrAVZhgR+C0HZAaWV7sfSOvjfAZYccz4583DSWVO9DA4eRiDZ46Hs4xxgUL+oDi7xbYxxo4BU2rY9+0mwmqGJzPL3GQ4delOvCPmX1dJEOlHCYJLT5fPeWcOyYvWcfoGbgUwkMW32/9rTpug+7At747S0lCZ0OpqApwntAms5hksTHs4975AIQMj0rKMslKHZAt/9ktK3ZQNYK4sjRyGhw8UrHs+GT3L/fyChk+xKeSaGs8VOsvwMtG4bOMarU6Ik+T/dzFHVldLzVk1IETP54H+N3xIQnPrc2fheY4VZSxuvi7XTUpVYN7hp0q3v2M2mdZnet1bzK/GylNpgNK5buhfZTJh8QSdTqoVxZ8Ilf+gUWnFpTnDFLz3gDT2CWhkB0fpsm0GuAComCt6I0rHCo211UPRpO+q4Tm/lR1+C+2I9QtLCVsVTOoHhjy1wmHTLxorcgKtsgyKfvZuHTCC+pMlCYUzjSb48Ys3PenuqLKbOaN3VdmWk3iYt/8jzwcnLbptQ/MDMIRvKOtNPmRRuLfCY8+vJJrs72Lg7hBb2zgHKghI8kWf8l9z/6r54qAyqyX5gtXzRjbvS8HC4P48b062M3C6WabJyeCf6jBZ8AvThwsnUW1C7lY6xWSzg5zPTbk+B+g1A3k=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199015)(478600001)(6512007)(38100700002)(66946007)(316002)(66556008)(66476007)(86362001)(54906003)(6916009)(36756003)(31696002)(53546011)(6506007)(8676002)(4326008)(26005)(41300700001)(6486002)(186003)(2906002)(5660300002)(2616005)(31686004)(83380400001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z2VFZ1NKZlVuVktIbE1NU1hDSW0zUFAyR3duTzVpMXA1d055QTdpdUc4ancx?=
 =?utf-8?B?L3ovdkFvL1V3eFFuWUdYaGtmYmNscWZZMSt2cWJPNytWMWNVUVZpMFRCYkZU?=
 =?utf-8?B?ZFU4OXhSRFFQSUU4S2F0MkpNU2piT1drQ1ZobEVvRDd5enFtQTZUaEkrc1hy?=
 =?utf-8?B?cGFHQkowV1hXTithdnRwcFJQeHA1L3BNVUpRYWF2akhrOFRuRmtnM2oyaFdu?=
 =?utf-8?B?Vm82eWZDVjUvVnFBVi9sZXJTS2N3VllSQ0RyOVc3WCswL3dvczllMUt2amFh?=
 =?utf-8?B?UUpFeUN6KzNyK3pidnBGOVdzT1FibWJtN1BmVW5GcGE1elAyTG9uU1FKQzl0?=
 =?utf-8?B?NFppam82bkg2bThlSW9wZ0Ftc0VWMHl1Y1BHVWUvK2VxL05MWmRUWWh1ckpD?=
 =?utf-8?B?Y3Z0NTJzSUJySUw0dWdwVkgvNjU2aU91bTl3VG4rb1U3MFI1Y05CVHFEZ21W?=
 =?utf-8?B?NENTQmZkcVJNbSt0KzNMd04wQnZNSXVPemQwd2YydHduZytqTExzTzhsbjM4?=
 =?utf-8?B?Znc3a1BZK2MvdVRZeEJ6UkhONytqa3JLVkF3ZDBzQ1V0MG5jWlkza0tHTkYv?=
 =?utf-8?B?VnNPT0lWNFVpZDcyOFRKOFBFR21uL2crZ3dBMEZ5MzU4dmF5M21Xc0g2VEds?=
 =?utf-8?B?M0RaUnVFOUEvb1g4SjlidVdZUnlZN0JidjFkaDVSdFNjRmIwQTI5S0Y5bEpr?=
 =?utf-8?B?dG1kc2FjZmY0VldVcEs2K04xRzFaNDJuRnhnQ2JCV1JHV3ZLVmNqTFI1MGxm?=
 =?utf-8?B?SHZubmVBb1JOUEFKZWI0Q3lyci9yN01BdktEaGpwbzhsVHRJUG84VWRMOHdP?=
 =?utf-8?B?b3hhcE1MYkRDcy9mT0tsMmZ2Vm1UYTJKWS9FOU5QdmYzYytOaGszMS82U2o5?=
 =?utf-8?B?ODhNU0xVbnB5am5kd0VZUEZub0pGQVlQZXRxaTdncXltM1BQZFJwZDJLQThW?=
 =?utf-8?B?dHFTUjNiZUtZZlFPR1hLaWNLdWVKSzh3MHNRVGpLRlFrYlo2L2dhMHFnZDcw?=
 =?utf-8?B?bHl5QVQyZk9FV3huOW14dGh2MmptQTlpZzNKRDAxZDVCOHhHZXhZclhIL1I4?=
 =?utf-8?B?WW9aeC9tdlYvalJZSzhkMkxlZ0hJakU1cThLQXZBbW84NjcxVDB4TjZyU3Qw?=
 =?utf-8?B?V25UbVpkdEIwd01sZ1E4RjBlNlpRbXZ5dFdYdVIzSUdPYUZQS1B4eVdnQXht?=
 =?utf-8?B?OHVxU00vQnlEM0s3eGZCYUp0ZXFVNEIzdTdLa29GemhMekx1VTg2L044a0Va?=
 =?utf-8?B?SjhPbXJ1aElqY2pMQjZWZFBDZnQvbGx4bklpZkxiRHlkU2ZzYXpCL1gvWmVZ?=
 =?utf-8?B?ZlRabkxVN2tNblkwT1d3Z0tFSWFTOUpDR2ZiL255a1A2NmxUSFhTVGgwUnY5?=
 =?utf-8?B?dTFUVDZ5elIvdzhGcnhvNkpseWhjc25udUttbXptUlhvVXJ3SUhtU3M2UlJZ?=
 =?utf-8?B?TkZGYVpuSk11R0tyVWJBM3FyRmR4T0V5ZFE1ZU1uZGhod3Q2UGxjbUNvcWZp?=
 =?utf-8?B?K1l2Rmx4MURGZ2xkU0Z4engycnhTNGJJUEhMWGFsd1FqTGMzcjVLbUVXM09Y?=
 =?utf-8?B?aHNQNEhiNWtSK2pFWnV5NFN0RmFES2VSQ0JiU0lGcDJhdmI0OVo3cUJUb2FZ?=
 =?utf-8?B?TzkyNW11ME9BNVZpemlXS3FNazdCR1VPaGYzdVh1NE8zeHNtSzE1ZE9va1Bi?=
 =?utf-8?B?ckEyR3R4OVAxWlJvZS9pSjZvZ2FJb2JlZm9IRE14VmhUUGlCYjBDVVFpUGZm?=
 =?utf-8?B?YjZ6SlBmSjErQk5nY0NiZHYwWnRveVVEV1FBRitoNGhmMndSV3NYNmljT2pI?=
 =?utf-8?B?a0lDOWI5dUpzTnBvT1ZDR3hjVVhSSExHVXlrUU1WWjVaRXozRTlWSXhKamZR?=
 =?utf-8?B?eEJJQmk3RWhhOWZDSUxKYjl6ZEg4SnBvMEZUYWFBMGR4R29TU1lQY3ZBbGx3?=
 =?utf-8?B?NlBEYzdFTFAzZ3VWcjFINHB5UzVSNStqampqd3lpM2d1MU1yVjJ0aGxRUTBO?=
 =?utf-8?B?a200NGh4VnFJdTh6R3o5TjdhSkJ1MXJIUFYxNk5MeGNUV1hUTW9JWlhOTTIw?=
 =?utf-8?B?Y3FYQXV2cE5SS004REFSdGdjWHlUWUQ4cSt0bUMvOG1wOE5RcUwzak1PYjFi?=
 =?utf-8?Q?sJ7kAFNkA/x+mtEK8yYJi13rv?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 719579dd-7c41-454f-ce0f-08dab747ffa0
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 11:48:29.5947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fS564FO7z5/wbaYOXe3KBDoTMBswwMRIJqqQtJw3jGceC3hD0JoXTdMFm2bVdEWZNU+n2hGFu+Vw6yiWuMYCHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7476

On 26.10.2022 13:34, Tamas K Lengyel wrote:
> On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper <Andrew.Cooper3@citrix.com>
> wrote:
> 
>> On 24/10/2022 17:58, Tamas K Lengyel wrote:
>>> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a
>> handful
>>> of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by an
>>> external privileged tool is necessary, thus we extend the domctl to
>> allow for
>>> querying for any guest MSRs. To remain compatible with the existing
>> setup if
>>> no specific MSR is requested via the domctl the default list is returned.
>>>
>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>>
>> Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be "get me
>> all MSRs needed to migrate a vCPU".  (I do intend to retire the
>> hypercall as part of fixing the Xen side of migration, but that's ages
>> away)
>>
>> It seems like what you want is something more like
>> XEN_DOMCTL_{rd,wr}msr_list  (convenient timing, given the recent ISE
>> update).  I think those would be better as a separate pair of
>> hypercalls, rather than trying to repurpose an existing hypercall.
>>
>>
>> As for actually getting the values, please fix up guest_{rd,wr}msr() to
>> access the perf MSRs safely.  I know the vpmu MSR handling is in a
>> tragic state, but this new get_msr subop is making the problem even more
>> tangled.
>>
> 
> Adding a separate hypercall is fine.

Which will then also avoid altering the behavior of the existing hypercall:
You can't just assume e.g. input fields to be zeroed (or otherwise
suitably set) by existing callers, when those were previously output only.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:57:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:57:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430490.682231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onf2S-000418-Pt; Wed, 26 Oct 2022 11:57:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430490.682231; Wed, 26 Oct 2022 11:57:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onf2S-000411-Mn; Wed, 26 Oct 2022 11:57:40 +0000
Received: by outflank-mailman (input) for mailman id 430490;
 Wed, 26 Oct 2022 11:57:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onf2R-00040r-HQ; Wed, 26 Oct 2022 11:57:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onf2R-00020a-Ek; Wed, 26 Oct 2022 11:57:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onf2R-0003Ht-21; Wed, 26 Oct 2022 11:57:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onf2R-0007cY-1X; Wed, 26 Oct 2022 11:57:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xZrF0XTn3IGfwh/aMX82G6Pwekag2FkuMcSEIoKEc3I=; b=FGa7qhR0v26hygkLYp1qqb677N
	DzYTNgQMG6XSXXSdfAyXOfELQz/6rkBE8cmxj4gsKxxQgEsS2VPMloDQinXMAX07/kL6FZb4+2q/Z
	HdmQRMuDJhIE4EdFYsIRZtimmgOQ3C47355kQUUEouGuwsORtudppLvNCzHk/qo/gC7o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174383-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174383: regressions - FAIL
X-Osstest-Failures:
    xen-4.16-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.16-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.16-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 11:57:39 +0000

flight 174383 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174383/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172623
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172623
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172623
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172623
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172623
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 172623

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 173511 pass in 174383
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 174070 pass in 174383
 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 174070 pass in 174383
 test-arm64-arm64-xl          14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 173493
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173511
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173511
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 174070

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172623

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173493 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173493 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1bce7fb1f702da4f7a749c6f1457ecb20bf74fca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   68 days
Testing same since   173493  2022-10-11 13:07:01 Z   14 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 695 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 11:58:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 11:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430495.682242 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onf3e-0004Z5-4p; Wed, 26 Oct 2022 11:58:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430495.682242; Wed, 26 Oct 2022 11:58:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onf3e-0004Yy-28; Wed, 26 Oct 2022 11:58:54 +0000
Received: by outflank-mailman (input) for mailman id 430495;
 Wed, 26 Oct 2022 11:58:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2/Fg=23=gmail.com=tamas.k.lengyel@srs-se1.protection.inumbo.net>)
 id 1onf3c-0004Yq-7x
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 11:58:52 +0000
Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com
 [2607:f8b0:4864:20::112d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e20b18f-5525-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 13:58:51 +0200 (CEST)
Received: by mail-yw1-x112d.google.com with SMTP id
 00721157ae682-35befab86a4so144496537b3.8
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 04:58:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e20b18f-5525-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=FNNv/mTy2IZyL2oJu7ZW8qmThCOYZYrApLznQoY3Pwo=;
        b=Kpo8VPAx9SVcgGqAC5Nb98jM/seoYnkNPXAWyZwIdq4nmVEfJuXUZTENRRIsv2h3gZ
         1uk75k/fIbdoHw7bHftkoviFbV7+JRRTCpSyOgHJ8hJbVLOKrWovceh3DVPiUpEtIuam
         1ZTjTZCk27TyiIH+iaQkKuPMf4tR6Bz0sGwr594pvD0f5CBqEHRthTmAiLJstiiuNwwh
         9h3oOW4TItvhN4US3nRvdbYkL0vJky8ZZ/WS+mQmZbs8DhwxqrIRmQ9pB5LoRX+Y/YNB
         hb9Vaxc0RWut7FkIh0LajhpCj7dHVoZhgXt7rS9YEK7up+Tb7WGxiU0iqnsjjCv+59IZ
         xWRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=FNNv/mTy2IZyL2oJu7ZW8qmThCOYZYrApLznQoY3Pwo=;
        b=nObpMLBHCcfLUH9Q4sXe6Wm0ZwNAu/9GGnGfE4ybVuFmYBLI1KKF+nvMg+Zqmo7pBY
         Gfi+b0iZ0CmLXlk+Jmpct2mvh4wsTpGyjUcf2CNxZofy9DJfPS3wSnrEe8gqnzRsM1PZ
         rEoXmS0xVsRgPy8KJwCmQsnER8api/DSQcsxkM0m+CE3IH2f/jEis1wxofTbtQBas+d4
         zhififihdh7/XP65LsKDro9RttXTplTJ6Mub+iE7rzD8cnGOugaXw0E1yVmwFxf+yX7p
         83NleoGgay8Skl1psN+RPyW6kA0SY++leTN/cTxVMvJkNLYwe3fgOI9HVJtVMIzobtvo
         1/aA==
X-Gm-Message-State: ACrzQf09sjfTKLW+7REkV7DsvvpH0fiIhOGc4Ss81r7A1AqZ2cBbCLF0
	cxk6tfDA5vpg3SD6ZADX+yhUFZSvtX1ZukOhJjM=
X-Google-Smtp-Source: AMsMyM4w9LyKIfJwxj1siA/Zt3QL7HU/CRE5o0x0CZZiYTMLKLQmyBNdjzUB3e10ZpodHhvY6eFF8+l+kIDUwRxDH/k=
X-Received: by 2002:a81:1713:0:b0:36b:3a6b:4b49 with SMTP id
 19-20020a811713000000b0036b3a6b4b49mr20009316ywx.500.1666785529991; Wed, 26
 Oct 2022 04:58:49 -0700 (PDT)
MIME-Version: 1.0
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com> <CABfawh=RXrPgj+MA-4QGogM0o3Oo4GEJ3ipbqHKE0TV4GHdCTg@mail.gmail.com>
 <f5673a0a-853e-fa2c-2f4c-e76b7b7aba87@suse.com>
In-Reply-To: <f5673a0a-853e-fa2c-2f4c-e76b7b7aba87@suse.com>
From: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Date: Wed, 26 Oct 2022 07:58:38 -0400
Message-ID: <CABfawhmjcv0mu4cqjTaOPxgrOuMQ5VyAA1OoNtOmr6g34a6Ezw@mail.gmail.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
To: Jan Beulich <jbeulich@suse.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>, 
	Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Roger Pau Monne <roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Content-Type: multipart/alternative; boundary="0000000000006e97b305ebeebf52"

--0000000000006e97b305ebeebf52
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 26, 2022, 7:48 AM Jan Beulich <jbeulich@suse.com> wrote:

> On 26.10.2022 13:34, Tamas K Lengyel wrote:
> > On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper <Andrew.Cooper3@citrix.com>
> > wrote:
> >
> >> On 24/10/2022 17:58, Tamas K Lengyel wrote:
> >>> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a
> >> handful
> >>> of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by
> an
> >>> external privileged tool is necessary, thus we extend the domctl to
> >> allow for
> >>> querying for any guest MSRs. To remain compatible with the existing
> >> setup if
> >>> no specific MSR is requested via the domctl the default list is
> returned.
> >>>
> >>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> >>
> >> Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be "get me
> >> all MSRs needed to migrate a vCPU".  (I do intend to retire the
> >> hypercall as part of fixing the Xen side of migration, but that's ages
> >> away)
> >>
> >> It seems like what you want is something more like
> >> XEN_DOMCTL_{rd,wr}msr_list  (convenient timing, given the recent ISE
> >> update).  I think those would be better as a separate pair of
> >> hypercalls, rather than trying to repurpose an existing hypercall.
> >>
> >>
> >> As for actually getting the values, please fix up guest_{rd,wr}msr() to
> >> access the perf MSRs safely.  I know the vpmu MSR handling is in a
> >> tragic state, but this new get_msr subop is making the problem even more
> >> tangled.
> >>
> >
> > Adding a separate hypercall is fine.
>
> Which will then also avoid altering the behavior of the existing hypercall:
> You can't just assume e.g. input fields to be zeroed (or otherwise
> suitably set) by existing callers, when those were previously output only.
>

I did add a memset to zero it on the single caller I could find.

Tamas

>

--0000000000006e97b305ebeebf52
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Wed, Oct 26, 2022, 7:48 AM Jan Beulich &lt;<a href=
=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #=
ccc solid;padding-left:1ex">On 26.10.2022 13:34, Tamas K Lengyel wrote:<br>
&gt; On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper &lt;<a href=3D"mailto:Andr=
ew.Cooper3@citrix.com" target=3D"_blank" rel=3D"noreferrer">Andrew.Cooper3@=
citrix.com</a>&gt;<br>
&gt; wrote:<br>
&gt; <br>
&gt;&gt; On 24/10/2022 17:58, Tamas K Lengyel wrote:<br>
&gt;&gt;&gt; Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gath=
ering a<br>
&gt;&gt; handful<br>
&gt;&gt;&gt; of predetermined vcpu MSRs. In our use-case gathering the vPMU=
 MSRs by an<br>
&gt;&gt;&gt; external privileged tool is necessary, thus we extend the domc=
tl to<br>
&gt;&gt; allow for<br>
&gt;&gt;&gt; querying for any guest MSRs. To remain compatible with the exi=
sting<br>
&gt;&gt; setup if<br>
&gt;&gt;&gt; no specific MSR is requested via the domctl the default list i=
s returned.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Signed-off-by: Tamas K Lengyel &lt;<a href=3D"mailto:tamas.len=
gyel@intel.com" target=3D"_blank" rel=3D"noreferrer">tamas.lengyel@intel.co=
m</a>&gt;<br>
&gt;&gt;<br>
&gt;&gt; Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be &qu=
ot;get me<br>
&gt;&gt; all MSRs needed to migrate a vCPU&quot;.=C2=A0 (I do intend to ret=
ire the<br>
&gt;&gt; hypercall as part of fixing the Xen side of migration, but that&#3=
9;s ages<br>
&gt;&gt; away)<br>
&gt;&gt;<br>
&gt;&gt; It seems like what you want is something more like<br>
&gt;&gt; XEN_DOMCTL_{rd,wr}msr_list=C2=A0 (convenient timing, given the rec=
ent ISE<br>
&gt;&gt; update).=C2=A0 I think those would be better as a separate pair of=
<br>
&gt;&gt; hypercalls, rather than trying to repurpose an existing hypercall.=
<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; As for actually getting the values, please fix up guest_{rd,wr}msr=
() to<br>
&gt;&gt; access the perf MSRs safely.=C2=A0 I know the vpmu MSR handling is=
 in a<br>
&gt;&gt; tragic state, but this new get_msr subop is making the problem eve=
n more<br>
&gt;&gt; tangled.<br>
&gt;&gt;<br>
&gt; <br>
&gt; Adding a separate hypercall is fine.<br>
<br>
Which will then also avoid altering the behavior of the existing hypercall:=
<br>
You can&#39;t just assume e.g. input fields to be zeroed (or otherwise<br>
suitably set) by existing callers, when those were previously output only.<=
br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I=
 did add a memset to zero it on the single caller I could find.</div><div d=
ir=3D"auto"><br></div><div dir=3D"auto">Tamas</div><div dir=3D"auto"><div c=
lass=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 =
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--0000000000006e97b305ebeebf52--


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:07:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:07:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430508.682256 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfBZ-0006Vc-9m; Wed, 26 Oct 2022 12:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430508.682256; Wed, 26 Oct 2022 12:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfBZ-0006VV-6q; Wed, 26 Oct 2022 12:07:05 +0000
Received: by outflank-mailman (input) for mailman id 430508;
 Wed, 26 Oct 2022 12:07:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onfBX-0006VO-SB
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:07:03 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b343ec4a-5526-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 14:07:02 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7470.eurprd04.prod.outlook.com (2603:10a6:800:1a3::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 12:07:00 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 12:06:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b343ec4a-5526-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O80MbpcSXSjhG2XtsgpJbu4Bj51Vx93a6DAhlIosT8elPEXBiV9VdKZBGXLnhKcnHV5QlRSgHxp58dmJmeblMWEMSEl7jttEk9WVG4/KKDjd2C8D2SPx31Ut04z/+pqNRtm9Tt8z18tWhk2V04G6oKr6aYaIn8wxE7FlXCWcprXZYpSBYwPWy987OvW6VK22B7ZEMUvFn9gvo0Q9ew/zE6UWZX4OOtjLOZ+YUTRBEaNkiqg1TJU8WmmQ/VAazZYZv1oox/ZjCI2f4ZsepXj9HAyFUsl1BoqmX7b6PF/JMBs6EPNC0NhXnn6yZ/XrFP59QKsWs8Cb9j2pGBoeQLrhvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bvS+6gAm3nZXIXSoOJSEGQ/JthYAowZtbB5XTXkQ818=;
 b=DjS467Q9x4qODoAz/v8GqPk41XYCmVDOYAs6fUiFZywb9O0VxHLC23BSh5D2vkoxW1fVXW8pHxCMIkeEmF0SXcFwOk7Kvxlyjhp5H2Ontmqgm/naB27HozTaGmWwocI76fI6vG2kctgg5B74vTf+MQodF3xdd9e09SZpf5aagLwQVzF353XBceEmxtBoRNS60FyifNtTnS/+q8MjxLHPllV1NoYVru+XTOxp2j6JxssvW9zPhKUUteYwDg/ygePY49ji4hKg3H/yoSiMBtQi+dg9cyo+gs6peHjbNYdVybTi+jCROnVZA4VdQ+MqRhifKRGg1vn93vZ59SUKb8NuCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=bvS+6gAm3nZXIXSoOJSEGQ/JthYAowZtbB5XTXkQ818=;
 b=VF5fDhGAgy5QkBDdfWgK9RfnltYI7AcOCV44OfT+aToOdmB6iSPUiuWjFjZ7z9WWSZVQd0aZOsUa93lUrDCVxl26CkvSIqSmUL0sJnx1a8PlE1NAgr9tz3S2rnqU7ZgVtaeyKMM4i1nt1LwBn1ATtnW5VLpXm7Dw27wj2GAWvNkNqCas+KZnap5463lUxFgJ7aqGcxbtZKgkZ9moYER9FMOYBeIZgsIrKYaFCQYMj8dAXJzhKQ2jBc0WnvWIOUNo5dHO1dWcvfsFg4eBdQC48SnpXw6nGrvPsbxyMOzZcdDknzSlINm1PCbB9ONX7BSAegXhwYQJFBcOapcvm7bjtw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a00d4591-b068-c05a-763b-905f61af4d46@suse.com>
Date: Wed, 26 Oct 2022 14:06:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [v2] Proposal for deviations in static analyser findings
Content-Language: en-US
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0144.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::19) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7470:EE_
X-MS-Office365-Filtering-Correlation-Id: 613cf8f4-9649-473d-5e7a-08dab74a95fa
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1dyjJAqS6zthjGiLozR1IMIpbscoTbqgMC48nVNl/2D9Qu618TaNMGVYouSGbWjkfOqX1fRzzaholIJihUg4jU3Y443BnizBM89NiqAe+MCI+9gNA8Pg0sk65e3I5C1hvxBDSAralGTreuWCDtefC70TRe/Vyo2/cRXJ8azM/obIfSi9uc/YocVhF9cUyTBWgv4ZAKzkFvHpMduU8iv9Llwrz0JJzQwCCD0/oIsy11rLKQuYbJK+w1y59DAuxGR+DgjLBfpX4JYr0jLVHVp6xD5x0yh5yNWSixDcMypCAivoiGcYlSrQPuiuRAx3kEzfLgvWSRtcYic4U2FjQTOm5jx9B5doaNwDVYTmGEY+tbLbDdZssV8bHWcsi4lK+3YMS9Qo0pNC018FVUtvDYFTApFxp6t1sVd+eP5LJaZaPpu4e1CNkIz6d09BTfvSZq5mNvcczhiFTZn55mXRGblRwe9yiI/bTelY0PeCNvmEBrT+uLLbAb/7uPfbeM1IKiX81V6vlASBNTRc6yh7tkspVl3SYbV6X7MqHTMf2OzmJVaytKrHxnGXZQkywlDsFgmtb3kOnKl+lrbqrnxBcfHkdNjqTTYGkJAahhxjhcf5IwoOvTVypycEWxL+1SGV8+85pja7VPkimgL/70vkyaDeZIrwUqlQOoeYDKZlPoEE360MLjSh+vJTkVBW29mj3JFMOlFWLvXpcKImQJV87Cgapde7eWPQIBCheioKqjK0Ug3xMzK/VfsTuosYECWT65YaYyNKczXNKe+lmeRkOZ+qQ5QfQwBZCHkrrIc4oGftWoU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(366004)(39860400002)(346002)(396003)(451199015)(26005)(41300700001)(6506007)(53546011)(38100700002)(36756003)(5660300002)(6916009)(54906003)(66476007)(66556008)(6486002)(316002)(8936002)(31696002)(86362001)(4326008)(478600001)(66946007)(8676002)(2906002)(2616005)(6512007)(31686004)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TjRRMVhHZFBJL3pvdWFnRno3MmN5V3U2dlBpb1MrY0pUclFkRUs5bHFBN0JG?=
 =?utf-8?B?S0hyZjBzMng4dlkxQ0Y0RUFBWWNHTlVvSjNZT21ZT1M2S3ZUcEZLdlhDWitW?=
 =?utf-8?B?SmdiUjZ2cW90WDZsT002djYyK05TaVRka2RkZ054Z29ySFZXOGJGTWRObFQ1?=
 =?utf-8?B?L0FLYisxa2w0THhEcTBNWTJtUG1JWWhvYUtkMC85Zy9mV2Foa1hOVVZRelB3?=
 =?utf-8?B?UURVak8yWE9YMGpSK0h2OE1oZjhXVGxGOGd3M2tYWmYrMEhJeldxci8rWDUw?=
 =?utf-8?B?ZEE4V3ZGTmxQR1lZVGprcVpxdjR6ZjhZeGNTajVpUVJUNGlTN1ZxdFdGZDha?=
 =?utf-8?B?eXJiRS9jRndJQzZEcFJGb1R2aUVuK2NMVjJhUzhodUN2anJlQXpOZVJaSDd2?=
 =?utf-8?B?NHhzQ3diZ0Fvd1ljeW1zRWp3MmdYdFZQRFRhNzNkYUZaSnJjRGFWTExDZkpW?=
 =?utf-8?B?eEVOeGFvR00ySkZMNWdTOHZ6REhsVGVQOVVTdmFuUVhVRG5CRzNPS0xMRUFp?=
 =?utf-8?B?Qk96QzJuVVl2M3B3dENuRytwR0Z3RHZkanlaMmRWQkliNEhuWEpReTNjRnZJ?=
 =?utf-8?B?ZThBbWFOaU94V2VTUmdEcnZhYWF2UHJTeldwZkJ2U1V4YVZWZi9hNmgwcmF1?=
 =?utf-8?B?VHZqV1JoeE9JTDgyTTlTQy94SjhISjl4QSsyc0FHbFVWN3hUajZKTGl6QlJI?=
 =?utf-8?B?VlR5VXJPczdSbjFWU3JuVTlQalAxeDBsUkMvYWx5MkZ4QWpPNVIvM1oyNVMr?=
 =?utf-8?B?YTdYTkJLaHVSLzF2SHhjVU5vVzcrUjY5V0lqZUVRUGJxajJNZVFTbmVhYTJK?=
 =?utf-8?B?V1dRSVQ0Vy9PdWJVTzIrUGZXdUIvRnV0OWgxQmtxMnV3VlFobkkxQnJSUXNi?=
 =?utf-8?B?TG9XekV5MzdtV3NhOWVUY1FtajVsYVFUZm5mRzAwVEp1VUlKa0p0MXVZbDBj?=
 =?utf-8?B?TkFlTUtDcmxCc1QzN0Fib2V2YXZJTWJKL0VLRk4rdjJ0MVRqa0VLS3BpblFI?=
 =?utf-8?B?UFk2TDE4b0w0UzJFa25LenNmMHMvcXJUaEFkVnB1bHBTTUswellhS2xRazFU?=
 =?utf-8?B?bUZwL1l2SmtvOWRBUU5UbGhKZzNzUFVRREdsNDZuM0RxZ2hDZjQ0OUZoK2pm?=
 =?utf-8?B?d0o4Y0RYeDI1Tko3di9UdXJ0QzBsWjBlNVdiRjR3TlNGZGp2dVVxS2ZlYTRD?=
 =?utf-8?B?YjhvVTdJeitQNDhkOG5JRjFZTkhHaDBaNno3TnNsenFDcVpjZi9mbFZUd2lN?=
 =?utf-8?B?WkhaQWVQVjRoWkRxUGNrYStaT0xQTVVnRnVBV25xWjdycUpNMStuZk0rNldu?=
 =?utf-8?B?VGZJdXlmY1FybXR5Q2lIOTlsbjRuWERTUlc0aWdJMXJiNloxazY2c0hVc05X?=
 =?utf-8?B?RDN3L3NLc1ZKYzJoTlA3ZzlNZkhaKzFhTTdueXlVcXdMeFM2aHhPTTE2QndP?=
 =?utf-8?B?UFg2MVc2L2RaWGdlTW9TREd6UlRtMVF3a2x3RklaQW9WZXVuN0tXZEFPYWJV?=
 =?utf-8?B?NUpBZE9xMEk0M2dLZHZydVNyVmNqb0VrUkhpbE9kT1ZURisyQmZ5T0VMZGw1?=
 =?utf-8?B?SHRQYlFoVlIwdDZiUzFaYnQrR2NodWFtbHk0cUNEckRVYXR3L21DZ0xlVEtQ?=
 =?utf-8?B?K0YwbGt3dUxoTTFjN0h2b3Bkcm9YU3BZbkFxTWsrSkJ0MHVjeGVMV2FFRmll?=
 =?utf-8?B?S0VDa255b2duOHdJY09DcG92VnVKQSs3WjUwbnJlbWFHZDBQMEdacFZId0xr?=
 =?utf-8?B?SWVhUzFTdi96Ky9yNS9HL3ZjQ1pkS2NkaDJYMlI3TTBCVHRPckRUZ0pOdmYy?=
 =?utf-8?B?RzR3Z2liZzhOanFTRGEwK0twSzFMM3g3MlV2cW5tT1BXdlRnTkxzV3lHQWpX?=
 =?utf-8?B?Y0NRV09GZ2NhWi9QVE8rZmpRVEdrbCtUb0p2Qm51WGZOR2hpVkVHNUt4ZTZw?=
 =?utf-8?B?Y2hQMjY4Q0ZvdUU1OTkvQ3lnV3VWdjdKS0QyQ04zRlJKYmVSdHhQOUt5RkpW?=
 =?utf-8?B?S3hrblVrRTZ4eHFWb2lZaWxXZW9iM2EvRmUxb3RNT3R1dERrNXJNVDQzM25K?=
 =?utf-8?B?dlp6dG1laTZqU2Izd2pLazk0UEV6Rmc5aHBPTlZwd01DSjVnZ1AxNDBlUFVO?=
 =?utf-8?Q?/nQK1N8Ij7KfOTWOHZnqLeG3p?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 613cf8f4-9649-473d-5e7a-08dab74a95fa
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:06:59.9272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lbIevybWAEt3CE9+zOsTXWL0vsYPH2ZSUGuJjSIq/1aZ8FEmJw3XXyjaqnIIwcN28lN3ikC4uNtphQqEWCUoUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7470

On 25.10.2022 12:13, Luca Fancellu wrote:
> Here is an example to add a new justification in safe.json::
> 
> |{
> |    "version": "1.0",
> |    "content": [
> |        {
> |            "id":"SAF-0-safe",
> |            "analyser": {
> |                "cppcheck": "misra-c2012-20.7",
> |                "coverity": "misra_c_2012_rule_20_7_violation",
> |                "eclair": "MC3R1.R20.7"
> |            },
> |            "name": “R20.7 C macro parameters not used as expression",
> |            "text": "The macro parameters used in this […]"
> |        },
> |        {
> |            "id":”SAF-1-safe",
> |            "analyser": {
> |                "cppcheck": "unreadVariable",
> |                "coverity": "UNUSED_VALUE"
> |            },
> |            "name": “Variable set but not used",
> |            "text": “It is safe because […]"
> |        },
> |        {
> |            "id":”SAF-2-safe",
> |            "analyser": {},
> |            "name": "Sentinel",
> |            "text": ""
> |        }
> |    ]
> |}

Besides the still inconsistent use of double quote forms (as also pointed
out by Stefano) I'd further like to point out that colons still aren't
uniformly followed by a blank (both pointed out at v1 already, and iirc
you agreed to make both aspects consistent).

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:10:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:10:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430512.682267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfEa-0007t1-OP; Wed, 26 Oct 2022 12:10:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430512.682267; Wed, 26 Oct 2022 12:10:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfEa-0007su-Le; Wed, 26 Oct 2022 12:10:12 +0000
Received: by outflank-mailman (input) for mailman id 430512;
 Wed, 26 Oct 2022 12:10:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ktaj=23=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1onfEZ-0007so-7h
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:10:11 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 22fdae13-5527-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 14:10:10 +0200 (CEST)
Received: from DU2PR04CA0283.eurprd04.prod.outlook.com (2603:10a6:10:28c::18)
 by AS8PR08MB9148.eurprd08.prod.outlook.com (2603:10a6:20b:57f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 12:10:02 +0000
Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28c:cafe::96) by DU2PR04CA0283.outlook.office365.com
 (2603:10a6:10:28c::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21 via Frontend
 Transport; Wed, 26 Oct 2022 12:10:02 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5709.10 via Frontend Transport; Wed, 26 Oct 2022 12:10:02 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Wed, 26 Oct 2022 12:10:02 +0000
Received: from 93965348a3f0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 047B2954-A8A8-407B-B471-F11330AE6D0F.1; 
 Wed, 26 Oct 2022 12:09:55 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 93965348a3f0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 12:09:55 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16)
 by DB4PR08MB9359.eurprd08.prod.outlook.com (2603:10a6:10:3f1::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 12:09:53 +0000
Received: from AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef]) by AM0PR08MB3809.eurprd08.prod.outlook.com
 ([fe80::52d5:6f8c:1348:f8ef%7]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 12:09:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22fdae13-5527-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=QcYLX8aU3EevojfQk7+C7jEduKwb/tTxos6+k0bZucYC8p6k81MspwpVzyrvVeLejXWKHKTPX7tet5RVs4iwI6JezytU9J0kw5O57QZz2Tu487Log1y3GAWt5H1Ues0bJ0243sOtSvgpHQBFh2Qhy7AUxJtkwhBz8orQhjSxN9cCcNP5I/kki7hwANWNIGapdLfM+6raH5tuoBMR0a3YLIhWDeO/pSMSiZEUxd+I1PgpfqL5804PnYcuf58jaPaLuECaccyaScN8oZWOZg1w1OTHjvT8M3cFy5seqd/5aNCpvErsjjS6mt8Gt1qSJeg3+B+gfTDxT/JGotXr/r8eSA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x9PSstsO5KDC5nSk/5C/x6O05/WB7bddeL7yCdPtI7o=;
 b=Yk1Z5j1Adp4vkh4VIoBNY98Wf02POzlwPufyAildB6/f9t9rsfi5fyqArQUvRhuIv0dVPD3NNcjUeDIq50AU9pbkJk1RjUXi1X6IamyMBNb39mkuCOMyvO9+gYpRG4gN4NGH9PS1meYG1OihmHrKMiA5o6d+cTG3TOWc0G46KBEL80PxQMDlq8F7HsXvLy2S2A+s1pwdZJZseePxFgm1hJ83Yb9yRLXQ4n76reCMCyGAC7xiH7ZCtbbwsWjQAS/sD0nyhZrL4bnnpJ/h5QaRDQRR/tKo3mGkYaDFtDIORN+yIPZQySmtPXZBDANs1szZGfzTJqhGyo0fbla9N0bLBg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x9PSstsO5KDC5nSk/5C/x6O05/WB7bddeL7yCdPtI7o=;
 b=KS4kfCDy7BrFDRiVCU7/tpKQ5LuHeKTe+atnN98mq7fUxjT9ws9a98V+7GKhBdPHVMOBA9dHSqPvTDLs6psg8v2VMxK5kvNPrtON9g1tZ45atib5AQ7Hi/CQcx21Y6zBHxmK+vviraLeChdFA/xwdWasgr4t/O25IGb5m0IPoJ8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 3597cc9ca1b443f0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OxVcN8BWhTcUiimunGhTwSnYg4oZBUZvxhholUDrZ4uAJQNlErWhe3Z3htGPLO54+/L17xtSLxX44j0ZxifKl7Q0Loie+LfghAvxI0sauSMD/tH3Sw05zgsZoE33xxe/wDGszAOVCdmryHAzi0ClJURVCIOok7kpHrZ6g2UGSUycHZLQnD3CL07QYeapRH2PaoVKIXosUbmRWd96N8ipj/YkUox8+KftEnVSt7MSE4K3/pRjTpify2eUuxqPSBWtWJijEyLfFR0L2ZjFJmpoG04roZAjBw6tpkj4/2kLTNlVx2ygTX6BLnq5JpGs+Sk09MnrCfGQKeEj7CQJUe5UpA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x9PSstsO5KDC5nSk/5C/x6O05/WB7bddeL7yCdPtI7o=;
 b=ehVDLjRBIjWJPaCLOGQceH85wE80gCzTAm9EN5vqUd41Hd/iXAyvGk5jlvTeWZbnJktr7eAh47oXFQXd7nskHxGjfTwlcrtdqAZyLNUSw0JopZFzosLORry4OeGPp9gJMyLDuJ+GmPPR6FM9mADORFGLhKjnaSex8PZ+9m+MbCxsM75KUGeFAZAZzC3ifrj2Skg1fT5JcFpFp4hnrJoCSaqO6DG3n/QFff/k5WJtjuDfgphXhYaVxMNaWLWVNw/l2WRDscykgA8bF/gvyifpiw2W/hpIqbXCoXEbPibkQozCJyH2vA8mKxvdHcXlG7ITPeD7w9mXwzEWrxWcEJC7KQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x9PSstsO5KDC5nSk/5C/x6O05/WB7bddeL7yCdPtI7o=;
 b=KS4kfCDy7BrFDRiVCU7/tpKQ5LuHeKTe+atnN98mq7fUxjT9ws9a98V+7GKhBdPHVMOBA9dHSqPvTDLs6psg8v2VMxK5kvNPrtON9g1tZ45atib5AQ7Hi/CQcx21Y6zBHxmK+vviraLeChdFA/xwdWasgr4t/O25IGb5m0IPoJ8=
From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [v2] Proposal for deviations in static analyser findings
Thread-Topic: [v2] Proposal for deviations in static analyser findings
Thread-Index: AQHY6FpvvKvqm6eEhUKW2GdsP99AnK4gljAAgAAAzwA=
Date: Wed, 26 Oct 2022 12:09:52 +0000
Message-ID: <7B05AD53-8627-42F1-A20C-B2BD0EED3581@arm.com>
References: <83A7652A-3F00-4490-837F-81498808FCC7@arm.com>
 <a00d4591-b068-c05a-763b-905f61af4d46@suse.com>
In-Reply-To: <a00d4591-b068-c05a-763b-905f61af4d46@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM0PR08MB3809:EE_|DB4PR08MB9359:EE_|DBAEUR03FT026:EE_|AS8PR08MB9148:EE_
X-MS-Office365-Filtering-Correlation-Id: 6741e60a-a9e0-44be-7248-08dab74b02e3
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6FkYfdvTL+cFXtDdYScejgwRybVO6OYbUeCxb/nH+K0lhjBaWxvrxJW7mBIqnGpoRRRjuio4iCx+XoeBMRtt7kbIgirRiKQ+aZyT+EBlcHKNxnbVCEEAoh62FclcAynKNMMu0Wgbrysa4g6URCCZa8gIauyCmGgdE8b9NuufejXZ+hk2mK5vg4RopIE5iJcaacgPtyBF3vupC4OLiVIvV/H2yWDOnPLdvfous3tqspx0YAfwhQna5ic1hlNbWgY0J9/UKym45sNzREF+jYrdigRYbXl7yO+Xe5PJcjb/yY4XiKJbEHjz0dgMTBUzIPZbP/uBuMgcnYqk4J3UsdGsUspmnwphEI9qcZVP5fyf0iWjVIL370UlcJzeuMhAK/YSyNNoAiiTx+bj2ITOvWEkjo429Sp4dFjkLdREXCQlDgqaRmlF95ACz1xak0KliJFpAaOOz9I/yQfCxwDHD7nkgTTXgAwn6P3/+MFxP6BOWdCu3KnVJfl0H0OfNhUjFntsR8yvf5GOItoRr+FIe5aQ9XBTTrp15a9DhKR+T3rasfXBted2w6XjWoZkHt0BHt40LahC3DV3Stp4OhBwfIYMfUGasjKime7K7csIOhBNp8wCiR74IjENcVnma6TzM76sZSao27t6eBd5KkW2WYlUJXffj4PBC4yY0ggcbUHbExwClr2HiPK9iMabUXzwZgZb5OT/WU+7YFCwE2/VpjKpveW44eEp2b3QcvWH/F8g8C8bNyDPjyv8rIWWqWfQDxsmjrEmEe31FgMTEmZly379bNy6yHyjj/qMLyp8gYc1fPs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(451199015)(36756003)(33656002)(86362001)(122000001)(2906002)(38100700002)(2616005)(6506007)(38070700005)(186003)(66946007)(71200400001)(6916009)(91956017)(66446008)(26005)(6486002)(76116006)(6512007)(4326008)(316002)(53546011)(54906003)(64756008)(66556008)(66476007)(8676002)(5660300002)(8936002)(41300700001)(478600001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <29EE2EC926C6CF46B8F7B39398B1EDB5@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9359
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	14a69635-1381-4900-451d-08dab74afd34
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XcOZTKy6K/TVh8YMFqm8qN+8c8K2Ma+U3gQq1ei5uNO1G00H0b5do50vY7qGEXtydiIMFBXIQtK1+sriiBMdZbD7m3UT1c8Uj+kGl7WHuDpgYjET0mRLp6XC12jjmOq+Xt38FQb2kf2poRVP3pniV1wDKDLxYwO3IzDKv4VdqZpT6KS7HHQR6kaWBaeMWymd5uNJv9KaCF26/CGebEwcceCRFacGZbnVnJbJYPX6b2q8S56dE1Fx/bUR8t8D5Rvv5+l5HnQUXWINyWVpdFWx3CaiMIaoz10yFXkZzCaP+GDY4W+tFUWGPV/zx+CUf1mMrpzZhC5BamcHUKvPz5R6mxFdRV9m1dGiAJwGsne4aUpdzUu5EdSJYf50SnTK/gY4grnEIjyKy0YDX0126astSHW0q/kMt6HceOo+4Z5ddfMSbNMcqu9k/EzKk0f34GO5fTySKaHkhghh6d4KzLTsyeaQfrBYkRkxgSz/hVyQh07rr0XSy1qjSgwFO55rOuqo1jDQ9gRaoghg+ipSHQkQO8Hk5sP9i7F7pPNGL6RR/iAqlcfM+nIqhHrVImhuY3wpQ0LnfIOiFca8Wr3EZ+soV9ufGC6INoJ5UcdAVwVzKz1Mi24OBCTS4uH7FuNUR9+joZT3y1v2JlS/UDP/OWvAW1UynoQQ4IrgB2mIuRUshbfoe680RZ9wHLy78voI1Z4V+7nAHAjbI0WHpE+EwShluyGXMRYYNhDRSzc4fw105nH+H+TivIdGo3DV0LYOsXkbit185wVm1c4gba4hafJj8w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(356005)(81166007)(82740400003)(2616005)(6862004)(86362001)(8936002)(33656002)(4326008)(6506007)(26005)(36756003)(70206006)(41300700001)(8676002)(40480700001)(70586007)(5660300002)(40460700003)(6512007)(47076005)(2906002)(53546011)(186003)(316002)(82310400005)(54906003)(6486002)(36860700001)(336012)(478600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:10:02.4612
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6741e60a-a9e0-44be-7248-08dab74b02e3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9148

DQoNCj4gT24gMjYgT2N0IDIwMjIsIGF0IDEzOjA2LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjUuMTAuMjAyMiAxMjoxMywgTHVjYSBGYW5jZWxsdSB3
cm90ZToNCj4+IEhlcmUgaXMgYW4gZXhhbXBsZSB0byBhZGQgYSBuZXcganVzdGlmaWNhdGlvbiBp
biBzYWZlLmpzb246Og0KPj4gDQo+PiB8ew0KPj4gfCAgICAidmVyc2lvbiI6ICIxLjAiLA0KPj4g
fCAgICAiY29udGVudCI6IFsNCj4+IHwgICAgICAgIHsNCj4+IHwgICAgICAgICAgICAiaWQiOiJT
QUYtMC1zYWZlIiwNCj4+IHwgICAgICAgICAgICAiYW5hbHlzZXIiOiB7DQo+PiB8ICAgICAgICAg
ICAgICAgICJjcHBjaGVjayI6ICJtaXNyYS1jMjAxMi0yMC43IiwNCj4+IHwgICAgICAgICAgICAg
ICAgImNvdmVyaXR5IjogIm1pc3JhX2NfMjAxMl9ydWxlXzIwXzdfdmlvbGF0aW9uIiwNCj4+IHwg
ICAgICAgICAgICAgICAgImVjbGFpciI6ICJNQzNSMS5SMjAuNyINCj4+IHwgICAgICAgICAgICB9
LA0KPj4gfCAgICAgICAgICAgICJuYW1lIjog4oCcUjIwLjcgQyBtYWNybyBwYXJhbWV0ZXJzIG5v
dCB1c2VkIGFzIGV4cHJlc3Npb24iLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0IjogIlRoZSBtYWNy
byBwYXJhbWV0ZXJzIHVzZWQgaW4gdGhpcyBb4oCmXSINCj4+IHwgICAgICAgIH0sDQo+PiB8ICAg
ICAgICB7DQo+PiB8ICAgICAgICAgICAgImlkIjrigJ1TQUYtMS1zYWZlIiwNCj4+IHwgICAgICAg
ICAgICAiYW5hbHlzZXIiOiB7DQo+PiB8ICAgICAgICAgICAgICAgICJjcHBjaGVjayI6ICJ1bnJl
YWRWYXJpYWJsZSIsDQo+PiB8ICAgICAgICAgICAgICAgICJjb3Zlcml0eSI6ICJVTlVTRURfVkFM
VUUiDQo+PiB8ICAgICAgICAgICAgfSwNCj4+IHwgICAgICAgICAgICAibmFtZSI6IOKAnFZhcmlh
YmxlIHNldCBidXQgbm90IHVzZWQiLA0KPj4gfCAgICAgICAgICAgICJ0ZXh0Ijog4oCcSXQgaXMg
c2FmZSBiZWNhdXNlIFvigKZdIg0KPj4gfCAgICAgICAgfSwNCj4+IHwgICAgICAgIHsNCj4+IHwg
ICAgICAgICAgICAiaWQiOuKAnVNBRi0yLXNhZmUiLA0KPj4gfCAgICAgICAgICAgICJhbmFseXNl
ciI6IHt9LA0KPj4gfCAgICAgICAgICAgICJuYW1lIjogIlNlbnRpbmVsIiwNCj4+IHwgICAgICAg
ICAgICAidGV4dCI6ICIiDQo+PiB8ICAgICAgICB9DQo+PiB8ICAgIF0NCj4+IHx9DQo+IA0KPiBC
ZXNpZGVzIHRoZSBzdGlsbCBpbmNvbnNpc3RlbnQgdXNlIG9mIGRvdWJsZSBxdW90ZSBmb3JtcyAo
YXMgYWxzbyBwb2ludGVkDQo+IG91dCBieSBTdGVmYW5vKSBJJ2QgZnVydGhlciBsaWtlIHRvIHBv
aW50IG91dCB0aGF0IGNvbG9ucyBzdGlsbCBhcmVuJ3QNCj4gdW5pZm9ybWx5IGZvbGxvd2VkIGJ5
IGEgYmxhbmsgKGJvdGggcG9pbnRlZCBvdXQgYXQgdjEgYWxyZWFkeSwgYW5kIGlpcmMNCj4geW91
IGFncmVlZCB0byBtYWtlIGJvdGggYXNwZWN0cyBjb25zaXN0ZW50KS4NCg0KWWVzLCB0aGFuayB5
b3UgZm9yIHlvdXIgcmV2aWV3IG9uIHYxIGFuZCBoZXJlLCBJ4oCZdmUgYWxyZWFkeSBmaXhlZCB0
aGVtIGluIG15IHBhdGNoZXMsDQpJIGZvcmdvdCB0byBkbyB0aGF0IHNlbmRpbmcgdGhlIHYyLCB0
aGUgZmluYWwgZG9jdW1lbnQgd2lsbCBoYXZlIGEgY29uc2lzdGVudCBzdHlsZS4NCg0KQ2hlZXJz
LA0KTHVjYQ0KDQo+IA0KPiBKYW4NCg0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:20:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:20:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430518.682281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfOM-00016j-Oa; Wed, 26 Oct 2022 12:20:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430518.682281; Wed, 26 Oct 2022 12:20:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfOM-00016c-Lk; Wed, 26 Oct 2022 12:20:18 +0000
Received: by outflank-mailman (input) for mailman id 430518;
 Wed, 26 Oct 2022 12:20:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TgK0=23=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1onfOL-00016W-CE
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:20:17 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8c81163e-5528-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 14:20:16 +0200 (CEST)
Received: from FR3P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::10)
 by DB8PR08MB5529.eurprd08.prod.outlook.com (2603:10a6:10:115::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 12:20:12 +0000
Received: from VI1EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:95:cafe::8a) by FR3P281CA0147.outlook.office365.com
 (2603:10a6:d10:95::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.13 via Frontend
 Transport; Wed, 26 Oct 2022 12:20:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VI1EUR03FT025.mail.protection.outlook.com (100.127.144.151) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 12:20:11 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Wed, 26 Oct 2022 12:20:10 +0000
Received: from 4673a6d39c61.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 235F6828-B499-46F5-BA0E-3BF5EC4B4DED.1; 
 Wed, 26 Oct 2022 12:20:03 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4673a6d39c61.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 12:20:03 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB8568.eurprd08.prod.outlook.com (2603:10a6:20b:565::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct
 2022 12:20:01 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 12:20:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c81163e-5528-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=LHL64mfh3MZR5s1a8zyHvrVzXOlGPAB2Q0KjvIdcCsiWCv38fJy5+8TWKrm1Wdb3C+JyisqpxyWJENrxQc8rt4RQXVi357sKXTU75E+/QMT9R/eir+yEn2DhcC6ECFjWMY8B0O/Mn6ZGMLdOQXfYuPssk7Bpqn73vthgh7h4axG4GQ6A1Mnqiy3yTIoAxMEWwdDBHK8SMx0giqTvQKJZcGQ+LzaE2kOxJlzL2XJcSVoVcvoRS4r+jT3WARaKj3FY6IrDhuJKbiL92ct7FiiYC9Vb/tAj0R51bg1UKM4NFICTGT1PMCva5LJYSTy6sbRZR0LRBpNjtJZVfQIJgfyZCA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y7+r2fMd+HdGVHU93NjBLkR9hPHnC+ku8Vd0l1aYhnU=;
 b=FoBxC91W3HPfvTato+yFO0bHnG52jFlq7uuHvvfbRk7cQHQTIM4JDWDxWAHSaORzYSffbYBh1qzPRT/ONq725tU1RR2ttMoeZ8LnvRBxB9UmiMO5yqvERJB3580LILBv2OG41BTRimwbxmFGzeYBqwnDREh8Sniw+iPgTDHluOpujrD5EPJtFHO7ywvFJHhZ1TQFCKWemCAigrJxNo5owDlUwp/smcmWpdjtmqNA/aNqZD9SvYTQnpaJVLNd89q3t+XMg73ehcYzIzbMm/uUJNm+cfZKFbXC2xnpHUtDZ53hF+v6Flg388FP44pfnyQPQaWVKhPVIouo8YlBBGGXsw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y7+r2fMd+HdGVHU93NjBLkR9hPHnC+ku8Vd0l1aYhnU=;
 b=WzpVaYtHvIUHx09kx6dSS1uOWmGxS99tel6x7NWnwFgmTIb+PfD+le4rIUfMpLMdWQpuNuBm//+8DkNul0bnj0WgBnHokO+7FTdLg0M9uBvISTgi7ueacoMng5xwS8PynPtwWp54vybyUsltkQxqmpoxpSGyyALGP8QNcQTBOgg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: de29177873210349
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZA7X7887VCLBQGsKO68y3Dqy5bYmwxUo5+1N/+F7OOWP743pXBXhCQZ5yQbcoEGVp8yrjPCgQ3qmB/nvg7FVYhfyBTlyunaBq5JFlnK5cRPSKiUvrJvn91P1oJTXDa4HwQCrjplmjBGOgSPwqEgZ7mbiHM1bK2/ZHzCmdOagPVPfXL/BWXCvt6/Q4/6TP9UlQNTgl2LypIPV3g9/tBkuL7HYpGXyV89JJQbNGimDCfbaqzKcZ7tUjXGKdEUxXUcpda0/BAJaISZZziHQT4kSHWnE8T7y1NftyGYQyHdOd32cOdSLwVttNkAsKA0f8Gs4F/ucXEWaMoGUaghC4VJLLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y7+r2fMd+HdGVHU93NjBLkR9hPHnC+ku8Vd0l1aYhnU=;
 b=AQXMehb3Daq94B3W8V4A+i1zq1ciSxkBmTbWVbsFctklqT+/ulU4OHiVeUdSXVMt1GWl++5rSrEOAU883ZeYDQ33hdcwVsinP/EqKHRMEFPLQE9Y0WjieqwDur4FTbQEofOCA7zbUoP0tr7LHioP4sTKmbpOUunXFi8JZFOhP+nMqpu29+PKhU8rrISJsSlc9YjwmoaDS/9h8v2yWBpmokR8JPJCIeN0kXE6S0ruYGHnfsuZPJfXSdYI3SRlaTitfyS2ZRF8UqtIu0bS5Z7j1FLtugkCt/8TmmGWJuYi6ghkB75aLma9gIEk2BIdYlCEhnpTvBoXnNq8fw+j5UmZwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y7+r2fMd+HdGVHU93NjBLkR9hPHnC+ku8Vd0l1aYhnU=;
 b=WzpVaYtHvIUHx09kx6dSS1uOWmGxS99tel6x7NWnwFgmTIb+PfD+le4rIUfMpLMdWQpuNuBm//+8DkNul0bnj0WgBnHokO+7FTdLg0M9uBvISTgi7ueacoMng5xwS8PynPtwWp54vybyUsltkQxqmpoxpSGyyALGP8QNcQTBOgg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: Deadcode discussion based on Arm NS phys timer
Thread-Topic: Deadcode discussion based on Arm NS phys timer
Thread-Index:
 AQHY54gZ+lETtnfh9UiF8D+fGFbI5q4dXjCAgAANxICAAB5kgIAAySOAgABfjwCAAAmGgIAABfAAgAADzwCAAccwgIAADfkA
Date: Wed, 26 Oct 2022 12:20:01 +0000
Message-ID: <54F41F27-8753-4BA5-98D5-23E649EBE339@arm.com>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
 <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
 <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com>
 <7C838BB9-E8FA-4239-B851-B179CB6B7A02@arm.com>
 <a3306efe-16bb-feb0-91aa-d6a9b0e30691@amd.com>
In-Reply-To: <a3306efe-16bb-feb0-91aa-d6a9b0e30691@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB8568:EE_|VI1EUR03FT025:EE_|DB8PR08MB5529:EE_
X-MS-Office365-Filtering-Correlation-Id: a3157a49-c8f4-4993-08e3-08dab74c6db2
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Q19V1iPzrjOv105zxJtQk0iZQZ/4ZPKN+M9gVfS/qlISWewjTz3zd1X9YUXPY640ygo2v/zcS0tW8l9bQCSDVaVnbNQE07/fP7bSQMwfp94fkL0FdLFoDIKYZjkyCCA1OKNRS0Al5XPlxMHcoCn18VwDdnWn+4cAvUlLy7y0oNcJaZ6GtkqweWRn+z5s5Li6YdFwN9UgJMDx477C8vjTYfVTtaksV4h2ykiacttvigmnfDngFPKFuS6TPxMCnrFizXB4AvPUj2+zFKF013Y/idIIxmcPVePblmsATu1b8nkUEz+wJydM40yIDL1s6wizx2u4BLL02vQnnasFnjB+rMqcPNAp76BE+C1KzI7aioQly0ASbAk8c6Kb53pT0xNa9CQHbkejwYA+x3hURRKCJb3KUbjZAJAQ2Hfl7/dQj8UHPkLIpYv/zHTQdaVTrNS92MFbsWAs9wlk3KO3NOkmJo4/6DhCTDUPVUTDpPDm2tBwu3b8fioL43Rt3z1CdocEJ++YFIScK7MTiK4UYxsJr8x0I9bm0/vJeaQtsDNxtNZIrxW7hx6vZTc9oHgELOlgCe2L6iKBDRLwCLu46ZLu4hfp/16FWOVrp7AOuB4fAzHwbVyGDJ48KsTDsckfi52fXvZhHsXk6x4KwVabQA11taRxmejdUr+v80qdpdkoWDN7Ue+C2GDq7g7kdqlRcaKppjKQwRiwd7rto1iqIkDF82A5OZWRot3DOJFAU911RGPucF5zohq5Hi8naZbtbA0BEHWPWw+8YKQGCr6pE0uHttb6el1H29/TExkkGpgBZqE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(451199015)(66476007)(66946007)(66556008)(66446008)(6916009)(64756008)(91956017)(4326008)(2906002)(8676002)(86362001)(54906003)(41300700001)(316002)(76116006)(8936002)(5660300002)(33656002)(186003)(38100700002)(122000001)(83380400001)(478600001)(6486002)(6506007)(53546011)(2616005)(38070700005)(71200400001)(26005)(6512007)(66899015)(36756003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <245A41D00B893F4280B7E57668EB4B55@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8568
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VI1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e651af40-b02c-41c1-58af-08dab74c67a2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kxSmrz8NpjIDScMLQwjPW9z2y8VsZQDE7F5oz1iGJaN/xCbrClxJBDs+LYFvMFzzvBFq5iFXHdf730+DbME37l3EFeJQSbW+Ub0CerGe/T1pQW7SlYBISVlC75xCBZX+94CW6LdVrYUB6RXrob3WhJtnznUPg7QfGf4/OL+/6dhJK9Zud2Kn5hv/ZpsPjhSnFeFe89e/HQPoYSOHvjru29wiBCCNBOX3QL2YGbw1+71DZtTnWMhLT1yZnXEWC4wBLy3mSyyP3n9oz+R2iipQScFezl6vC059YqugMBsSQbbgmQi+QTR8iVi/aOeGGd2WRqnsotddM1iWp16MdnwC+DoKY0gInTa78aXLe/IQmTmMWl0kqtg41C+Wpe4f+HeFzoGnQYx694XaLiGxHFvJD0AeePRmXJWZyaY/0CJ6VVvFl0uy+XHfiHoazJ/FuMjYMig0kdH2+fxEqW0AfqmeTIj86ZFjzFBU6MZN00Vum3g1v3cGH/xg/aSK4GZKyyZ9xT9G6WZQguNRqUTkNE7Z30NxIo6vuDvCofyeSwr4sHRhbpbUROh1QehkOHZ95FF02yiEbPAc0m5qEQBY+M5HjgA6DaEGlPLD0VSvnZ7KyLP/baXO1aSAcLQQA3AWrg053shoJ8UV10hQsQI9cfhpR2DvxqKmDAfXyGZxPsB44s2kN1RjQXLKTBDoazY6ygzbqKfDKcy3wtf5W4yyQzw4ZB7IuJ0s82YmjwrWdsIvmIW18KGVtZ4DGj/ZPvGydsGZw6nnXoVhZW4KLXIVGfahwg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(36756003)(66899015)(86362001)(6486002)(36860700001)(41300700001)(4326008)(47076005)(82310400005)(82740400003)(478600001)(356005)(8936002)(6512007)(33656002)(83380400001)(336012)(40460700003)(54906003)(2616005)(186003)(2906002)(81166007)(53546011)(5660300002)(6862004)(316002)(8676002)(6506007)(40480700001)(26005)(70206006)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:20:11.0722
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a3157a49-c8f4-4993-08e3-08dab74c6db2
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VI1EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5529

SGkgTWljaGFsLA0KDQo+IE9uIDI2IE9jdCAyMDIyLCBhdCAxMjoyOSwgTWljaGFsIE9yemVsIDxt
aWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBhbGwsDQo+IA0KPiBPbiAyNS8x
MC8yMDIyIDEwOjIwLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gQ2F1dGlvbjogVGhpcyBt
ZXNzYWdlIG9yaWdpbmF0ZWQgZnJvbSBhbiBFeHRlcm5hbCBTb3VyY2UuIFVzZSBwcm9wZXIgY2F1
dGlvbiB3aGVuIG9wZW5pbmcgYXR0YWNobWVudHMsIGNsaWNraW5nIGxpbmtzLCBvciByZXNwb25k
aW5nLg0KPj4gDQo+PiANCj4+IEhpIE1pY2hhbCwNCj4+IA0KPj4+IE9uIDI1IE9jdCAyMDIyLCBh
dCAwOTowNywgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6DQo+Pj4g
DQo+Pj4gSGkgQmVydHJhbmQsDQo+Pj4gDQo+Pj4gT24gMjUvMTAvMjAyMiAwOTo0NSwgQmVydHJh
bmQgTWFycXVpcyB3cm90ZToNCj4+Pj4gDQo+Pj4+IA0KPj4+PiBIaSBNaWNoYWwsDQo+Pj4+IA0K
Pj4+Pj4gT24gMjUgT2N0IDIwMjIsIGF0IDA4OjExLCBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5vcnpl
bEBhbWQuY29tPiB3cm90ZToNCj4+Pj4+IA0KPj4+Pj4gSGksDQo+Pj4+PiANCj4+Pj4+IE9uIDI1
LzEwLzIwMjIgMDM6MjksIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+Pj4+PiANCj4+Pj4+
PiANCj4+Pj4+PiBPbiBNb24sIDI0IE9jdCAyMDIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+
Pj4+PiBPbiAyNC8xMC8yMDIyIDEyOjUxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+Pj4+Pj4g
Q2F1dGlvbjogVGhpcyBtZXNzYWdlIG9yaWdpbmF0ZWQgZnJvbSBhbiBFeHRlcm5hbCBTb3VyY2Uu
IFVzZSBwcm9wZXINCj4+Pj4+Pj4+PiBjYXV0aW9uIHdoZW4gb3BlbmluZyBhdHRhY2htZW50cywg
Y2xpY2tpbmcgbGlua3MsIG9yIHJlc3BvbmRpbmcuDQo+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4gDQo+
Pj4+Pj4+Pj4gT24gMjQvMTAvMjAyMiAxMDowNywgTWljaGFsIE9yemVsIHdyb3RlOg0KPj4+Pj4+
Pj4+PiBIZWxsbywNCj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+PiBIaSBNaWNoYWwsDQo+Pj4+Pj4+Pj4g
DQo+Pj4+Pj4+Pj4+IFJlY2VudGx5IEkgY2FtZSBhY3Jvc3MgYSBkZWFkY29kZSBpbiBYZW4gQXJt
IGFyY2ggdGltZXIgY29kZS4gQnJpZWZseQ0KPj4+Pj4+Pj4+PiBzcGVha2luZywgd2UgYXJlIHJv
dXRpbmcNCj4+Pj4+Pj4+Pj4gdGhlIE5TIHBoeXMgdGltZXIgKENOVFApIElSUSB0byBYZW4sIGV2
ZW4gdGhvdWdoIFhlbiBkb2VzIG5vdCBtYWtlIHVzZQ0KPj4+Pj4+Pj4+PiBvZiBpdCAoYXMgaXQg
dXNlcyB0aGUgaHlwZXJ2aXNvciB0aW1lciBDTlRIUCkuDQo+Pj4+Pj4+Pj4+IFRoaXMgdGltZXIg
aXMgZnVsbHkgZW11bGF0ZWQsIHdoaWNoIG1lYW5zIHRoYXQgdGhlcmUgaXMgbm90aGluZyB0aGF0
IGNhbg0KPj4+Pj4+Pj4+PiB0cmlnZ2VyIHN1Y2ggSVJRLiBUaGlzIGNvZGUgaXMNCj4+Pj4+Pj4+
Pj4gYSBsZWZ0IG92ZXIgZnJvbSBlYXJseSBkYXlzLCB3aGVyZSB0aGUgQ05USFAgd2FzIGJ1Z2d5
IG9uIHNvbWUgbW9kZWxzDQo+Pj4+Pj4+Pj4+IGFuZCB3ZSBoYWQgdG8gdXNlIHRoZSBDTlRQIGlu
c3RlYWQuDQo+Pj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+PiBBcyBmYXIgYXMgdGhlIHByb2JsZW0gaXRz
ZWxmIGlzIG5vdCByZWFsbHkgaW50ZXJlc3RpbmcsIGl0IHJhaXNlcyBhDQo+Pj4+Pj4+Pj4+IHF1
ZXN0aW9uIG9mIHdoYXQgdG8gZG8gd2l0aCBhIGRlYWRjb2RlLA0KPj4+Pj4+Pj4+PiBhcyB0aGVy
ZSBtaWdodCBiZS9hcmUgb3RoZXIgZGVhZGNvZGUgcGxhY2VzIGluIFhlbi4NCj4+Pj4+Pj4+PiAN
Cj4+Pj4+Pj4+PiBUaGVyZSBhcmUgbXVsdGlwbGUgZGVmaW5pdGlvbiBvZiBkZWFkY29kZS4gRGVw
ZW5kaW5nIG9uIHdoaWNoIG9uZSB5b3UNCj4+Pj4+Pj4+PiBjaG9zZSwgdGhlbiB0aGlzIGNvdWxk
IGNvdmVyIElTX0VOQUJMRUQoKSBhbmQgcG9zc2libHkgI2lmZGVmLiBTbyB0aGlzDQo+Pj4+Pj4+
Pj4gd291bGQgcmVzdWx0IHRvIGEgbG90IG9mIHBsYWNlcyBpbXBhY3RlZCB3aXRoIHRoZSBkZWNp
c2lvbi4NCj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+PiBTbyBjYW4geW91IGNsYXJpZnkgd2hhdCB5b3Ug
bWVhbiBieSBkZWFkY29kZT8NCj4+Pj4+Pj4+IEluIHRoZSB0aW1lciBleGFtcGxlLCBJIHRoaW5r
IHdlIGhhdmUgYm90aCBhIGRlYWRjb2RlIGFuZCB1bnJlYWNoYWJsZSBjb2RlLg0KPj4+Pj4+Pj4g
Rm9yIHRoZSBwdXJwb3NlIG9mIHRoaXMgZGlzY3Vzc2lvbiwgbGV0J3MgdGFrZSB0aGUgTUlTUkEg
ZGVmaW5pdGlvbiBvZiBhDQo+Pj4+Pj4+PiBkZWFkY29kZSB3aGljaCBpcyBhICJjb2RlIHRoYXQg
Y2FuIGJlIGV4ZWN1dGVkDQo+Pj4+Pj4+PiBidXQgaGFzIG5vIGVmZmVjdCBvbiB0aGUgZnVuY3Rp
b25hbCBiZWhhdmlvciBvZiB0aGUgcHJvZ3JhbSIuIFRoaXMgZGlmZmVycw0KPj4+Pj4+Pj4gZnJv
bSB0aGUgdW5yZWFjaGFibGUgY29kZSBkZWZpbml0aW9uIHRoYXQgaXMNCj4+Pj4+Pj4+IGEgImNv
ZGUgdGhhdCBjYW5ub3QgYmUgZXhlY3V0ZWQiLiBTZXR0aW5nIHVwIHRoZSBJUlEgZm9yIFhlbiBp
cyBhbiBleGFtcGxlDQo+Pj4+Pj4+PiBvZiBhIGRlYWRjb2RlLiBDb2RlIHdpdGhpbiBJUlEgaGFu
ZGxlciBpcyBhbiB1bnJlYWNoYWJsZSBjb2RlDQo+Pj4+Pj4+PiAodGhlcmUgaXMgbm90aGluZyB0
aGF0IGNhbiB0cmlnZ2VyIHRoaXMgSVJRKS4NCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gV2hhdCBJIG1l
YW4gYnkgZGVhZGNvZGUgaGFwcGVucyB0byBiZSB0aGUgc3VtIG9mIHRoZSB0d28gY2FzZXMgYWJv
dmUgaS5lLg0KPj4+Pj4+Pj4gdGhlIGNvZGUgdGhhdCBjYW5ub3QgYmUgZXhlY3V0ZWQgYXMgd2Vs
bCBhcyB0aGUgY29kZSB0aGF0DQo+Pj4+Pj4+PiBkb2VzIG5vdCBpbXBhY3QgdGhlIGZ1bmN0aW9u
YWxpdHkgb2YgdGhlIHByb2dyYW0uDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+Pj4g
T25lIG1heSBzYXkgdGhhdCBpdCBpcyB1c2VmdWwgdG8ga2VlcCBpdCwgYmVjYXVzZSBvbmUgZGF5
LA0KPj4+Pj4+Pj4+PiBzb21lb25lIG1pZ2h0IG5lZWQgaXQgd2hlbiBkZWFsaW5nIHdpdGggeWV0
IGFub3RoZXIgYnJva2VuIEhXLiBTdWNoDQo+Pj4+Pj4+Pj4+IHBlcnNvbiB3b3VsZCBzdGlsbCBu
ZWVkIHRvIG1vZGlmeSB0aGUgb3RoZXINCj4+Pj4+Pj4+Pj4gcGFydCBvZiB0aGUgY29kZSAoZS5n
LiByZXByb2dyYW1fdGltZXIpLCBidXQgdGhlcmUgd291bGQgYmUgbGVzcyB3b3JrDQo+Pj4+Pj4+
Pj4+IHJlcXVpcmVkIG92ZXJhbGwuIFBlcnNvbmFsbHksIEknbSBub3QgaW4gZmF2b3Igb2YNCj4+
Pj4+Pj4+Pj4gc3VjaCBhcHByb2FjaCwgYmVjYXVzZSB3ZSBzaG91bGQgbm90IHJlYWxseSBzdXBw
b3J0IHBvc3NpYmxlIHNjZW5hcmlvcw0KPj4+Pj4+Pj4+PiB3aXRoIGJyb2tlbiBIVyAoZXhjZXB0
IGZvciBlcnJhdGFzIGxpc3Rpbmcga25vd24gaXNzdWVzKS4NCj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+
PiBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVuICJicm9rZW4gSFciIGFuZCAiSFcgd2l0aCBrbm93biBl
cnJhdGEiIGlzIGEgYml0DQo+Pj4+Pj4+Pj4gdW5jbGVhciB0byBtZS4gQ2FuIHlvdSBjbGFyaWZ5
IGhvdyB5b3Ugd291bGQgbWFrZSB0aGUgZGlmZmVyZW5jZSBoZXJlPw0KPj4+Pj4+Pj4+IA0KPj4+
Pj4+Pj4+IEluIHBhcnRpY3VsYXIsIGF0IHdoaWNoIHBvaW50IGRvIHlvdSBjb25zaWRlciB0aGF0
IHRoZSBIVyBzaG91bGQgbm90IGJlDQo+Pj4+Pj4+Pj4gc3VwcG9ydGVkIGJ5IFhlbj8NCj4+Pj4+
Pj4+IEknbSBub3Qgc2F5aW5nIHRoYXQgSFcgc2hvdWxkIG5vdCBiZSBzdXBwb3J0ZWQuIFRoZSBk
aWZmZXJlbmNlIGZvciBtZQ0KPj4+Pj4+Pj4gYmV0d2VlbiBicm9rZW4gSFcgYW5kDQo+Pj4+Pj4+
PiBIVyB3aXRoIGtub3duIGVycmF0YSBpcyB0aGF0IGZvciB0aGUgZm9ybWVyLCB0aGUgaW5jb3Jy
ZWN0IGJlaGF2aW9yIGlzIG9mdGVuDQo+Pj4+Pj4+PiBkdWUgdG8gdGhlIGVhcmx5IHN1cHBvcnQg
c3RhZ2UsDQo+Pj4+Pj4+PiB1c2luZyBlbXVsYXRvcnMvbW9kZWxzIGluc3RlYWQgb2YgcmVhbCBI
Vywgd2hlcmVhcyBmb3IgdGhlIGxhdHRlciwgdGhlIEhXIGlzDQo+Pj4+Pj4+PiBhbHJlYWR5IHJl
bGVhc2VkIGFuZCBpdCBoYXBwZW5zIHRvIGJlIHRoYXQgaXQgaXMgYnVnZ3kNCj4+Pj4+Pj4+ICh0
aGUgSFcgdmVuZG9yIGlzIGF3YXJlIG9mIHRoZSBpc3N1ZSBhbmQgcmVsZWFzZWQgZXJyYXRhcyku
DQo+Pj4+Pj4+IA0KPj4+Pj4+PiBUaGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0aW9uLiBXaGF0IEkg
d291bGQgY2FsbCBicm9rZW4gaXMgYW55dGhpbmcgdGhhdCBjYW4ndA0KPj4+Pj4+PiBiZSBmaXhl
ZCBpbiBzb2Z0d2FyZS4gRm9yIGEgbm90IHRvbyBmaWN0aW9uYWwgZXhhbXBsZSwgYW4gSFcgd2hl
cmUgUENJIGRldmljZXMNCj4+Pj4+Pj4gYXJlIHVzaW5nIHRoZSBzYW1lIHN0cmVhbSBJRC4gU28g
ZWZmZWN0aXZlbHksIHBhc3N0aHJvdWdoIGNhbid0IGJlIHNhZmVseQ0KPj4+Pj4+PiBzdXBwb3J0
ZWQuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBSZWdhcmRpbmcsIG5vdCB5ZXQgcmVsZWFzZWQgSFcsIEkg
ZG9uJ3QgdGhpbmsgWGVuIHNob3VsZCBoYXZlIHdvcmthcm91bmQgZm9yDQo+Pj4+Pj4+IHRoZW0u
IEkgd291bGRuJ3QgZXZlbiBjYWxsIGl0ICJicm9rZW4iIGJlY2F1c2UgdGhleSBhcmUgbm90IHll
dCByZWxlYXNlZCBhbmQNCj4+Pj4+Pj4gaXQgaXMgY29tbW9uIHRvIGhhdmUgYnVnIGluIGVhcmx5
IHJldmlzaW9uLg0KPj4+Pj4+PiANCj4+Pj4+Pj4+IERvIHdlIGhhdmUgYW55IGV4YW1wbGUgaW4g
WGVuIGZvciBzdXBwb3J0aW5nIGJyb2tlbiBIVywNCj4+Pj4+Pj4+IHdob3NlIHZlbmRvciBpcyBu
b3QgYXdhcmUgb2YgdGhlIGlzc3VlIG9yIGRpZCBub3QgcmVsZWFzZSBhbnkgZXJyYXRhPw0KPj4+
Pj4+PiBJIHdpbGwgbm90IGNpdGUgYW55IEhXIG9uIHRoZSBNTC4gQnV0IGZyb20gbXkgZXhwZXJp
ZW5jZSwgdGhlIHZlbmRvcnMgYXJlIG5vdA0KPj4+Pj4+PiB2ZXJ5IHZvY2FsIGFib3V0IGlzc3Vl
cyBpbiBwdWJsaWMgKHNvbWUgZG9uJ3QgZXZlbiBzZWVtIHRvIGhhdmUgcHVibGljIGRvYykuDQo+
Pj4+Pj4+IFRoZSBiZXN0IHdheSB0byBmaW5kIHRoZSBpc3N1ZXMgaXMgdG8gbG9vayBhdCBMaW51
eCBjb21taXQuDQo+Pj4+Pj4+IA0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4+IEFs
c28sIGFzIHBhcnQgb2YgdGhlIGNlcnRpZmljYXRpb24vRlVTQSBwcm9jZXNzLCB0aGVyZSBzaG91
bGQgYmUgbm8NCj4+Pj4+Pj4+Pj4gZGVhZGNvZGUgYW5kIHdlIHNob3VsZCBoYXZlIGV4cGxhbmF0
aW9uIGZvciBldmVyeSBibG9jayBvZiBjb2RlLg0KPj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+IFNlZSBh
Ym92ZS4gV2hhdCBhcmUgeW91IHRyeWluZyB0byBjb3ZlciBieSBkZWFkY29kZT8gV291bGQgcHJv
dGVjdGluZw0KPj4+Pj4+Pj4+IGNvZGUgd2l0aCBJU19FTkFCTEVEKCkgKG9yICNpZmRlZikgb2s/
DQo+Pj4+Pj4+PiBJIHRoaW5rIHRoaXMgd291bGQgYmUgb2sgZnJvbSB0aGUgY2VydGlmaWNhdGlv
biBwb2ludCBvZiB2aWV3ICh0aGlzIHdvdWxkIGF0DQo+Pj4+Pj4+PiBsZWFzdCBtZWFucywgdGhh
dCB3ZSBhcmUgYXdhcmUgb2YgdGhlIGlzc3VlDQo+Pj4+Pj4+PiBhbmQgd2UgdG9vayBzb21lIHN0
ZXBzKS4gT3RoZXJ3aXNlLCBzdWNoIGNvZGUgaXMganVzdCBhbiBleGFtcGxlIG9mIGENCj4+Pj4+
Pj4+IGRlYWRjb2RlL3VucmVhY2hhYmxlIGNvZGUuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBUaGFua3Mg
Zm9yIHRoZSBjbGFyaWZpY2F0aW9uLiBTbyB0aGUgZXhhY3QgYXBwcm9hY2ggd2lsbCBkZXBlbmQg
b24gdGhlDQo+Pj4+Pj4+IGNvbnRleHQuLi4uDQo+Pj4+Pj4+IA0KPj4+Pj4+Pj4+PiBUaGVyZSBh
cmUgZGlmZmVyZW50IHdheXMgdG8gZGVhbCB3aXRoIGEgZGVhZGNvZGU6ID4gMS4gR2V0IHJpZCBv
ZiBpdA0KPj4+Pj4+Pj4+PiBjb21wbGV0ZWx5DQo+Pj4+Pj4+Pj4+IDIuIExlYXZlIGl0IGFzIGl0
IGlzDQo+Pj4+Pj4+IA0KPj4+Pj4+PiAuLi4gdGhpcyBpcyBteSBwcmVmZXJlbmNlIGluIHRoZSBj
b250ZXh0IG9mIHRoZSB0aW1lci4NCj4+Pj4+PiANCj4+Pj4+PiBGcm9tIGEgY2VydGlmaWNhdGlv
biBwb2ludCBvZiB2aWV3LCB0aGUgZmV3ZXIgbGluZXMgb2YgY29kZSB0aGUgYmV0dGVyLA0KPj4+
Pj4+IGFuZCBpZGVhbGx5IGFsbCB0aGUgbGluZXMgb2YgY29kZSB1c2VkIGZvciB0aGUgY2VydGlm
aWVkIGJ1aWxkIHNob3VsZCBiZQ0KPj4+Pj4+IHRlc3RhYmxlIGFuZCB1c2VkLg0KPj4+Pj4+IA0K
Pj4+Pj4+IFNvIEkgdGhpbmsgMi4gaXMgdGhlIGxlc3QgdXNlZnVsIG9wdGlvbiBmcm9tIGEgY2Vy
dGlmaWNhdGlvbg0KPj4+Pj4+IHBlcnNwZWN0aXZlLiBGb3IgdGhpcyByZWFzb24sIEknZCBwcmVm
ZXIgYW5vdGhlciBhbHRlcm5hdGl2ZS4NCj4+Pj4+PiANCj4+Pj4+PiANCj4+Pj4+Pj4gSWYgdGhl
IG90aGVyIGRvbid0IGxpa2UgaXQsIHRoZW4gMSB3b3VsZCBiZSBteSBwcmVmZXJlbmNlLg0KPj4+
Pj4+PiANCj4+Pj4+Pj4gSW4gZ2VuZXJhbCwgbXkgcHJlZmVyZW5jZSB3b3VsZCBiZSBlaXRoZXIg
My4zIG9yIDMuMiAoc2VlIGJlbG93KS4NCj4+Pj4+PiANCj4+Pj4+PiBJIGFsc28gdGhpbmsgdGhh
dCAzLjIgYW5kIDMuMyBhcmUgZ29vZCBvcHRpb25zIGZvciB0aGUgZ2VuZXJhbCBjYXNlLiBGb3IN
Cj4+Pj4+PiB0aGUgdGltZXIsIEkgY2FuIHNlZSB3aHkgMSBpcyB5b3VyIChzZWNvbmQpIHByZWZl
cmVuY2UgYW5kIEkgYW0gZmluZQ0KPj4+Pj4+IHdpdGggMSBhcyB3ZWxsLg0KPj4+Pj4gT2ssIHNv
dW5kcyBnb29kIHRvIG1lLiBMZXQncyBzdGlsbCBnaXZlIEJlcnRyYW5kIHRoZSBjaGFuY2UgdG8g
c2hhcmUgaGlzIG9waW5pb24uDQo+Pj4+IA0KPj4+PiBXZSBuZWVkIHRvIGdldCByaWQgb2YgZGVh
ZCBjb2RlIGFuZCByZW1vdmluZyBpdCBpcyBub3QgYWx3YXlzIHRoZSBiZXN0IHNvbHV0aW9uLg0K
Pj4+PiANCj4+Pj4gSWYgdGhlIGNvZGUgaXMgb3IgY291bGQgYmUgdXNlZnVsIGZvciBzb21lb25l
IHNvbWUgZGF5LCBwcm90ZWN0aW5nIGl0IHdpdGggaWZkZWYgaXMgb2suDQo+Pj4+IA0KPj4+PiBJ
biB0aGUgbWlkIHRlcm0gd2Ugd2lsbCBoYXZlIHRvIGludHJvZHVjZSBhIGxvdCBtb3JlIGlmZGVm
IG9yIElTX0VOQUJMRUQgaW4gdGhlDQo+Pj4+IGNvZGUgc28gdGhhdCB3ZSBjYW4gY29tcGlsZSBv
dXQgd2hhdCB3ZSBkbyBub3QgbmVlZCBhbmQgY29kZSBub3QgYXBwbHlpbmcgdG8NCj4+Pj4gc29t
ZSBoYXJkd2FyZSBpcyBhIGNhc2Ugd2hlcmUgd2Ugd2lsbCBkbyB0aGF0IChkb2VzIG5vdCBtZWFu
IHRoYXQgYnkgZGVmYXVsdA0KPj4+PiB3ZSB3aWxsIG5vdCBjb21waWxlIGl0IGluIGJ1dCB3ZSB3
aWxsIG1ha2UgaXQgZWFzaWVyIHRvIHJlZHVjZSB0aGUgY29kZSBzaXplIGZvciBhDQo+Pj4+IHNw
ZWNpZmljIHVzZSBjYXNlKS4NCj4+Pj4gDQo+Pj4+IFNvIDMuMiBhbmQgMy4zIGFyZSBvayBmb3Ig
bWUuDQo+Pj4gDQo+Pj4gU28gd2UgYWxsIGFncmVlIHRoYXQgdGhlIGNvZGUgaW4gdGhlIGN1cnJl
bnQgZm9ybSBpcyBhIG5vIGdvIGZyb20gY2VydGlmaWNhdGlvbiBwdXJwb3Nlcy4NCj4+PiBUaGF0
IGlzIGdvb2QgOikNCj4+PiANCj4+PiBUaGUgcmVhc29uIHdoeSBJIG9wdCBmb3Igc29sdXRpb24g
MSBhbmQgbm90IHRoZSBvdGhlcnMgaXMgdGhhdCBpbiB0aGUgbGF0dGVyIGNhc2UgaXQgd291bGQN
Cj4+PiBtZWFuIGludHJvZHVjaW5nIHRoZSBLY29uZmlnIG9wdGlvbiB0byBhbGxvdyB1c2VyIHRv
IHNlbGVjdCB0aGUgdGltZXIgdG8gYmUgdXNlZCBieSBYZW4uDQo+Pj4gVGhpcyBpcyBub3QgcmVh
bGx5IGNvcnJlY3QuIEFsc28gaW4gdGhlIGN1cnJlbnQgZm9ybSwgaXQgd291bGQgYWxzbyByZXF1
aXJlIGFkZGluZyBtb3JlDQo+Pj4gY29kZSB0byB0aW1lLmMgY29kZSBiZWNhdXNlIGF0IHRoZSBt
b21lbnQgdXNpbmcgQ05UUCBmb3IgWGVuIHdvdWxkIG5vdCB3b3JrIG91dCBvZiB0aGUgYm94Lg0K
Pj4+IFRoZSBhcmNoaXRlY3R1cmUgZGVmaW5lcyB0aGUgaHlwZXJ2aXNvciB0aW1lciBmb3IgYSBw
dXJwb3NlLiBJZiBpdCBkb2VzIG5vdCB3b3JrLCBpdCBtZWFucw0KPj4+IHRoYXQgdGhlIEhXIGlz
IHByb2JsZW1hdGljLiBJIGFncmVlIHRoYXQgd2Ugd291bGQgd2FudCB0byBzdXBwb3J0IHN1Y2gg
dXNlIGNhc2UgYnV0IEknbSBub3QNCj4+PiByZWFsbHkgYXdhcmUgb2YgYW55IGlzc3VlIGxpa2Ug
dGhhdC4gQWRkaW5nIG1vcmUgY29kZSBhbmQgS2NvbmZpZyBvcHRpb25zIGp1c3QgYmVjYXVzZQ0K
Pj4+IG9uZSBkYXkgc29tZW9uZSBtYXkgZmFjZSBpc3N1ZXMgd2l0aCBhIG5ldyBIVyBpcyBzb21l
dGhpbmcgSSBhbSBub3QgYSBmYW4gb2YuDQo+PiANCj4+IEkgc2VlIDIgc29sdXRpb25zIGhlcmU6
DQo+PiAtIHNvbWVob3cgcHVzaCB0aGUgY29kZSB0byBhIGRpZmZlcmVudCBmaWxlIChub3QgcXVp
dGUgc3VyZSB0aGlzIGlzIGZlYXNpYmxlIGhlcmUpDQo+PiAtIHJlbW92ZSBjb21wbGV0ZWx5IHRo
ZSBjb2RlIHdpdGggYSBjbGVhbiBjb21taXQuIERvaW5nIHRoaXMgaXQgd2lsbCBiZSBlYXN5IGZv
ciBzb21lb25lIG5lZWRpbmcgdGhpcyB0byBsYXRlciByZXZlcnQgdGhlIHBhdGNoDQo+PiANCj4+
IEl0IGlzIGRlZmluaXRlbHkgdHJ1ZSBoZXJlIHRoYXQgYWRkaW5nIG1vcmUgY29kZSB0byBrZWVw
IHNvbWUgdW51c2VkIGNvZGUgZG9lcyBub3QgcmVhbGx5IG1ha2Ugc2Vuc2UuDQo+PiBBbmQgbGV0
4oCZcyBiZSByZWFsaXN0aWMgaGVyZSwgaWYgd2UgbmVlZCB0aGF0IG9uZSBkYXksIGl0IHdpbGwg
bm90IHRha2UgYWdlcyB0byBzdXBwb3J0IGl0IHNvbWVob3cuDQo+PiANCj4+IEFzIHNhaWQsIGZy
b20gYSBwdXJlIGNlcnRpZmljYXRpb24gcG9pbnQgb2YgdmlldzoNCj4+IC0gd2UgbXVzdCBub3Qg
aGF2ZSBkZWFkY29kZQ0KPj4gLSBwcm9wZXIgaWZkZWYgaXMgYWNjZXB0YWJsZQ0KPj4gLSBpZiAw
IGlzIG5vdCBhY2NlcHRhYmxlDQo+PiAtIGNvbW1lbnRlZCBjb2RlIGlzIG5vdCBhY2NlcHRhYmxl
DQo+IA0KPiBHaXZlbiB0aGF0IHdlIGFncmVlIG9uIHRoYXQgKCsgSVNfRU5BQkxFRCBvcHRpb24g
aWYgcG9zc2libGUpLCBhbmQgdGhlIG9wdGlvbiAxIHNlZW1zDQo+IHRvIGJlIHRoZSBiZXN0IGNo
b2ljZSBmb3IgdGhlIHRpbWVyLCBJIHdpbGwgY3JlYXRlIGEgcGF0Y2ggcmVtb3ZpbmcgdGhlIElS
USBwYXRoIHRvIGdldCByaWQNCj4gb2YgdGhlIGRlYWRjb2RlL3VucmVhY2hhYmxlIGNvZGUuDQo+
IA0KPiBEbyB5b3UgdGhpbmsgdGhpcyBpcyBzb21ldGhpbmcgd2Ugd2FudCBmb3IgNC4xNz8NCj4g
VGhlIHJpc2sgaXMgbG93IGFzIHRoZSBjb2RlIGlzIGFscmVhZHkgZGVhZCBhbmQgdGhlIGJlbmVm
aXQgaXMgdGhhdCB3ZSBoYXZlIG5vIGRlYWRjb2RlLg0KPiBXaGF0IGRvIHlvdSB0aGluaz8NCj4g
DQoNCldlIGFyZSB2ZXJ5IG5lYXIgZnJvbSB0aGUgcmVsZWFzZSBzbyBmcm9tIG15IHBvaW50IG9m
IHZpZXcgYXMgaXQgaXMgbm90IHNvbHZpbmcgYSBidWcsIHRoaXMgc2hvdWxkIG5vdCBnbyBpbnRv
IDQuMTcuDQoNCkJlcnRyYW5kDQoNCj4gfk1pY2hhbA0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:22:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:22:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430523.682292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfQJ-0001kf-8e; Wed, 26 Oct 2022 12:22:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430523.682292; Wed, 26 Oct 2022 12:22:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfQJ-0001kY-5S; Wed, 26 Oct 2022 12:22:19 +0000
Received: by outflank-mailman (input) for mailman id 430523;
 Wed, 26 Oct 2022 12:22:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onfQH-0001kO-US
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:22:18 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80055.outbound.protection.outlook.com [40.107.8.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d41cabad-5528-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 14:22:16 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PR3PR04MB7369.eurprd04.prod.outlook.com (2603:10a6:102:89::5) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 12:22:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 12:22:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d41cabad-5528-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kTVogthQ36FhZEaBS6o4AqRB5isJa9J33npjV4zo8byrLFNjvlixOH8jRaiZHQj7oT+nYJWk2m9iQUosUIiDYOvGUBFqkSUtQTXti9TDgIYABQ4Bnf+qSQxxx56XNn6JHwYk72NcZEI+m42UMn8cQKdKOeUUswjUNrIlUizcsIOzrHCpN0zn1GaaIG1PHrHUHF5RInE8GDsuzM9BjKBO5CkXSUB6Emlz11NTj9p7C64Zayyl+ZldAzEqgT8k56DpxWRu71X+H6nyEDeyFmtE0vgyr8e2Z2GuJa9jsQ/8BYSrkYcsyhc2NxwXiLhrj9tvQVqm6QCFu+kPRA/31J5WJQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A5ZL3M2l+5oszwDBX+lnLb+1M2f0j38MXzS0Lu5aqWM=;
 b=d6habteaZ+AEHpp01p8dfq2u8DisQoPZwXm2dM0l7wkdqPCYtRm+ZIV4gt4eQDW9AuugvyuJuJ5SuIBQd3VqrbDpb3sewU6d40pMoFN8AORgP00cwpmKCa/cbrSERYz5Ii+sWCvnnYHfWJafrOVFKZkZmFE+QjfdizG8ENG80sR3isAqJLz5nKZbt/LoIBy0tgWOJeg0IR6VBQmfF5WhpJcVOWtjx1xBXvjp/M51jaW7JIf6t2aHK7rOF07hJFgvqLUnLxhbQr0iPlr9JJO+GnuRcAg0Ip0ucmTqkBq8xXmIkapiOHpeDpXHekc/6CRgA4MRQdw2yQ9z0oO7N0aOYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A5ZL3M2l+5oszwDBX+lnLb+1M2f0j38MXzS0Lu5aqWM=;
 b=ma3kXZwv0h8NYnTsR6ZTt5n6ZYtQQ0AnbzOAP5iRS9DYphTj7Vy1mkbtnS5GWmru12HO3rLSY6+sttkuqIbu16QdEE5p0vcnbddFbMIQBVPKzE96BidxEnKhBri09uV5lt9V/QiqMDe4zu6ggmPApNWPSpyCB6s7FBPCs8Hsexu3vRhcKpDci6VyIMC2bVNcu2alCQD5rRjQh2TtOCmcrNe96Wz8RJ5HdsZBPbEFZqHGqaRsvtTFVry8dFuL/OWTcDRxKE5KVGQMT7X7PLEothrXeNuykMTVJMzodBlfX9Ta8KyqoZEvmfcwQJwe3UHkD0YsC4MHbHd1R0lDEd+KMw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b4a7f3a4-1685-a14b-4800-2d1277a26a07@suse.com>
Date: Wed, 26 Oct 2022 14:22:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
Content-Language: en-US
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Jun Nakajima
 <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com>
 <CABfawh=RXrPgj+MA-4QGogM0o3Oo4GEJ3ipbqHKE0TV4GHdCTg@mail.gmail.com>
 <f5673a0a-853e-fa2c-2f4c-e76b7b7aba87@suse.com>
 <CABfawhmjcv0mu4cqjTaOPxgrOuMQ5VyAA1OoNtOmr6g34a6Ezw@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CABfawhmjcv0mu4cqjTaOPxgrOuMQ5VyAA1OoNtOmr6g34a6Ezw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0149.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:95::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7369:EE_
X-MS-Office365-Filtering-Correlation-Id: 07c03a33-2472-49a4-e6ee-08dab74cb672
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VmikshT5we2G6Y9GMPEIarHiX3IT4gluzAoV8CQbclq1vi5QzIFausNRw4ZRNh+ojPshq20lH+vtfSuztDcmCyXo9GGwmBomjlcB4enPJ/nb8D7j3BJcP6K8xdSOXu7b8h+auRSw+nXMyq6/iQMKMHWYKyvHBw2c8Sa9l13PprpdDPoR+YWiLAUwKfz6ch8+7aWVzo65R+qOBRD/nnCs9vBE61tlMtTn+wprYJYK95DUUKUYOSw4JqaekS5AITaMbf4i3Btbm+1vlLvozTTujA+g4/jo/4ZA+iXVoz6Uc2Qw6pso8IrFun9y4BcKP6gnJGuXd8pl4EtOb7gD8v0TaQ2jrm5DXxnSBVpdc2B7SQji6ux5kBk6K/YmQjmadO09FTyVKcrVmjGZxQ8W9uk6h1i0zdiyy7QaM8qqySg74mtwJei7KlUi2n1n94a0afXmLwMbf9WiaBT7+I+0JG7mTOijplQ1/XXr2IvnWSpyI2WWEMoYZ69HgvLEuJ4K7VNFKg4iCY7cJV0hGw0co9quZIr2SC5bht/RjgxJI5VsQKiI3XL1Ry6FfcPHYfcHwAZmqeMCqMP0yvejPNnjFyT5yz5I5lNXdYNos8ajibMaH/qNzamCUUxqJ2edtYzuqH/CKb1m0zCQEfT5qDR/UaxVY7NUskVWKKcnB4zhLAnBL78RuruUkEcEoADXfNeL00YfskAKOkqLGv8OgEq0QcSsKi5by6AN6rk3RENJ1BevjZGs4jf0CcQ+LPDFT3lu0wGor2rj22EEmwsVtMd1DTGDmmgZXmvU51JvhzwQ2caSJmk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(39860400002)(346002)(366004)(451199015)(31686004)(5660300002)(41300700001)(8936002)(186003)(66946007)(6916009)(54906003)(2906002)(316002)(4326008)(31696002)(36756003)(8676002)(86362001)(66476007)(66556008)(478600001)(6486002)(38100700002)(6506007)(6512007)(53546011)(26005)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eFJ4UXhQbitNZ1I1eE9iampwSG82VWxsc1RNcXdiUXhta1FQTi9jcDJHU2dw?=
 =?utf-8?B?SUxHd2hZSTduNDdlVEJhZTVaNmhURWtGRUJWVTJ2cWU5dTlKYUZIK0pWcmxm?=
 =?utf-8?B?UndSN2grQ2ZTcFExMWxyVnY4cU1lZVVIclZUaVhHR1lScmFMTzA4dnVJZDJa?=
 =?utf-8?B?Vk1uUzRTQ0V2OU4rcHRxTFJNQmhTeWNsdmZtSUFvai9QR1c2YjA3c1dpa01k?=
 =?utf-8?B?bFpzWDZ4Wno1OXd0S3BySWFhYVo5RENkUmN0WHphZVN4VlV2dkdwU0dxR3VW?=
 =?utf-8?B?VXFUcW9CaUhJN3FKbU8waWFZUDc0bXpiNkpuZEhZVGRIMXh0aVdLeUJjakRn?=
 =?utf-8?B?UGtKU3AvWHAyZmwzRUtudTRmYUZYd0xmS2VaRzV6bDJBOFRTaS9WYXZ1WTVM?=
 =?utf-8?B?emhVTjlOR0pDUmZSSG9wV3pwT0lKWk9NWm0zRnJIeDhTSER3c2ZFMTRSWHZx?=
 =?utf-8?B?QmVubWUzQTl2Y2YzdFlyQVYzb2xaN0JvN3dkb1B6QlRXcE1MTmx3cjVPQWdT?=
 =?utf-8?B?T2YxK3JnSWt2YzFST2Q1ZzNjM1FkaUlkSjRFdjRsN091MGFmVVZYdXVmMG1Z?=
 =?utf-8?B?ZFdzU3NvRUlscUU1dXdRc08zWkw2WnZrTFFLamRBUjdUMEZQS3lRVWNlUlBp?=
 =?utf-8?B?bnFZRnhwdXRocm1jZEhaY2J1WVdSa2hVaExUZ1dPQUdnNDU4ZEEyazN2NXVE?=
 =?utf-8?B?cjQxK1VpRHBxVlVxRWN4R3lpM1FzOXVXMjFQT013WUZ1alk3Z1doWnNTV3Vq?=
 =?utf-8?B?RXdKaGxhSHZEeVJCT2N0eVBFMkRKeHp1b29jTlQ2VEVUSnRRQzhIaFh5ek9M?=
 =?utf-8?B?WkwwSW1YK05GeFAycDd0QWpocXQ3cGl0aGxVZzVLM1NjakUyaE1Na0twVmZT?=
 =?utf-8?B?TTRiaTRHWHc2Q3ZaL1Zvbm9IQ2thbjZwM3ZmWmhyeDFxc3BsZFFQeFlmWDZV?=
 =?utf-8?B?S3htaHhFeWxaOTcvRU9iSSt1OXo1eDVWQVk1ZGtCRE03bldpNmVwZDVuajdZ?=
 =?utf-8?B?ZHNwREcya0N3RVFRajdJTUNuUzNpclNJNUNQa2pWWC9xU25oTlFjVEdKNEZM?=
 =?utf-8?B?SjhjS0pXR2lnWDJmU3ZBTXV0ZGdzQ2JoWklnUlk4aWtIaE9OSkkzd3lUZENT?=
 =?utf-8?B?VFlOODJHT3FneWdPdWpwV245bHJIeng1RGJsaFlEQndDWmJleHhWdVlFYUk4?=
 =?utf-8?B?VHQwbW5EOE9kWmVNK1E3U2VWUTVmMjU0dUk0c2llNnBCbTcwVWFLVk5FN3VH?=
 =?utf-8?B?bTF2eWNMZjlXUXVKVFJiWHg0aGNuQ3NSN2J1Nld6M2JQeE1JbHlJY2VmYmtC?=
 =?utf-8?B?OHd6WXBma2krSitHcWVOY1JOM3ZPelFJV0FoRHRGb2gwMy9YNUU2MGhuc3dE?=
 =?utf-8?B?TXZkeU1Td0k2OWg2akdIY1NhN1RGTVQ1d0ZQNUhYWHM5VnVLUkFzdnh3K2tU?=
 =?utf-8?B?K3NTMWNZSHVlK1I1eW9Hc2NEUlNEeWRjN0IwK2pqMi9zS0lRdzAvWWlqVGVX?=
 =?utf-8?B?Mng0U2F1Q0d6YkF4cS9RaDBCbnNOaTBvNGxuTzRrMkY1M1QySlFadkNUcEg0?=
 =?utf-8?B?bGVBWG1md0d5Wm1pcG9pTHowYkdVZDBaVEVoOXRQOXNmZXJGYjM2WWN5ZENZ?=
 =?utf-8?B?bkRmdFc2SkdHMVJVenpCQnZxUWRwdGMxaDhVaGZVWTBnc1NGVGEvUkx0bDc0?=
 =?utf-8?B?VG83RmpIOWhzSTFUVTIwMVVXT2xDQmFycFMzRDFvUzRCUktLd0NFUE1hN2k4?=
 =?utf-8?B?ZUc5Q3Yvb3E5ckNITDQ4a0E2S09lMFNkSWpHU0I2dllnSGFZRExHMXlZTjBy?=
 =?utf-8?B?OER5SzdWTVcvWGovckJWSU5pZ2xna0h0bFpmZTlXZ1A3R1ZPQjQySGMwTmM4?=
 =?utf-8?B?WjVUN3JVTTMvYXhCbnRmNWNQU2kzMGQramlnV09kMDRxaDhBUFREajlUVUp3?=
 =?utf-8?B?M0w2WmNZVWpNTERpU0dzV1RmZU1wRjJjc0g5VzhCQVFNYVRxNlV2ejJISkJy?=
 =?utf-8?B?ZEY2OVhSRHNKYStEdWg5MWI0TFZFTVlNQlAzM0VNWDBWVkU4UEN3UXFVcHcv?=
 =?utf-8?B?QkVOUTRmd2xGZkQrT3k0bjhlRjc0MTdGd01YR3QzUUhIbjM1V1lMaUNMSjJ4?=
 =?utf-8?Q?ET+8AE14sr33yKaKVitS9Dlnc?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07c03a33-2472-49a4-e6ee-08dab74cb672
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:22:13.4289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DKVFERMmt2biwYKB+2q/aLLRZ7SVWuC5/aSrfM9o+cLI8yS3kaKmjzxHUVZH0sO7P6xmyYxVWaQ8TR5hK7RR3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7369

On 26.10.2022 13:58, Tamas K Lengyel wrote:
> On Wed, Oct 26, 2022, 7:48 AM Jan Beulich <jbeulich@suse.com> wrote:
> 
>> On 26.10.2022 13:34, Tamas K Lengyel wrote:
>>> On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper <Andrew.Cooper3@citrix.com>
>>> wrote:
>>>
>>>> On 24/10/2022 17:58, Tamas K Lengyel wrote:
>>>>> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering a
>>>> handful
>>>>> of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs by
>> an
>>>>> external privileged tool is necessary, thus we extend the domctl to
>>>> allow for
>>>>> querying for any guest MSRs. To remain compatible with the existing
>>>> setup if
>>>>> no specific MSR is requested via the domctl the default list is
>> returned.
>>>>>
>>>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
>>>>
>>>> Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be "get me
>>>> all MSRs needed to migrate a vCPU".  (I do intend to retire the
>>>> hypercall as part of fixing the Xen side of migration, but that's ages
>>>> away)
>>>>
>>>> It seems like what you want is something more like
>>>> XEN_DOMCTL_{rd,wr}msr_list  (convenient timing, given the recent ISE
>>>> update).  I think those would be better as a separate pair of
>>>> hypercalls, rather than trying to repurpose an existing hypercall.
>>>>
>>>>
>>>> As for actually getting the values, please fix up guest_{rd,wr}msr() to
>>>> access the perf MSRs safely.  I know the vpmu MSR handling is in a
>>>> tragic state, but this new get_msr subop is making the problem even more
>>>> tangled.
>>>>
>>>
>>> Adding a separate hypercall is fine.
>>
>> Which will then also avoid altering the behavior of the existing hypercall:
>> You can't just assume e.g. input fields to be zeroed (or otherwise
>> suitably set) by existing callers, when those were previously output only.
>>
> 
> I did add a memset to zero it on the single caller I could find.

Some may deem this sufficient on the assumption that all users should
go through the libxenguest function. But then at the minimum you want
to update documentation in the public header. Yet then this wasn't
the only issue I spotted (hence the use of "e.g.") - you also alter
documented behavior as to the returned number of MSRs when the input
value was too small, if I'm not mistaken.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:36:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:36:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430527.682302 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfdP-0003b1-EC; Wed, 26 Oct 2022 12:35:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430527.682302; Wed, 26 Oct 2022 12:35:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfdP-0003au-BJ; Wed, 26 Oct 2022 12:35:51 +0000
Received: by outflank-mailman (input) for mailman id 430527;
 Wed, 26 Oct 2022 12:35:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onfdO-0003am-I2
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:35:50 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20054.outbound.protection.outlook.com [40.107.2.54])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7ff64f8-552a-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 14:35:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8130.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 12:35:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 12:35:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7ff64f8-552a-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XUTS0clZ+C0WCbhjkylh+bosqPCaX48bf+Yg68Lh01luC//nN1MdP+0R9NDvgUVdB5m0EFCMnRaOQw1Ms/syP5mbeS/OgzUjEzIYoyASiGrIuOqtubsL5BeK9/5BZMQc8Tpnpy430qQJD+J3TNqczcbuC6j112GMbUkzf9KBe6jeRNqcBeNjxOx0PKZjupGYIgVBHlm0Fgsv/oc3ajefpCjkLZ+EAHIGUFIkRX602PPCNCbKj9436AN40DsmQtKbBqETBBmEd1xvMBjaEcL8GDnPqcZ0JmDHbaawdp3piF/Ij+GPUYVOj5ce/x0G5HWzS0mvISrBkGVOt292RlWJGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nD8Ce0/dRHbCANyucPc8SVsJyQwfDzrQc1UcfGfRc3k=;
 b=WsgPVDnDRglO1AjRlHXdPZfq3fRM+Skzs/yDZH0UunEN4FN4n9IpX6txtKklK72np+ldXklrRJjl3EyJP6QCij1NBDC0Vl5qvRd4dlJ2Za70O4kFk7O867+IwbJidBg8lPLuplnhSr2tCT5UrYCkorJXEfW5wXYJQoD/TtOzpe/OSTrMch1YzUHJaY6eKnFcIbd7aJSUoTfgFE58SCniCvVKuLHNneD5RP3dP8yRuGeuAlx4tUAz80T/lvYSUVVwqpI4vYD8BQKbCBFw03aDtI2R7dBdm6Nrk+pjYdZuF83yGi2gxnpC1O2zhXZ1a2EkOXKzdZxmZU5RZ/japMAFiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nD8Ce0/dRHbCANyucPc8SVsJyQwfDzrQc1UcfGfRc3k=;
 b=EBwdofMA9t5kxSnFYo4nZx7xcGtU5sM/BjyQ0xw1Tk4b29wMLIlJYPcID1vYKLzc8PL7KAgHoI8ogUzDBeMwd9gtAdv0FXe8BtbzH6LaIh60IisFkxBWX80LWCYM4rLDsCluIzc83Fp5WgUlJ15vNnPVUadsJCPaMg4UYGBBFg++vjbMOmWRm+rLrok4YfW+tjrkt0VC3/cE4iJZhgRU0FH9xVI/ElF2/JAfHejL22wRpcRj40yUTXz6sE0DqwcOVDC0y6Kl6nnChKaSzbkdQBtZqunN/psEQny3khgD/oexF5pY0jpXa7/zLt+bj5ZiHcux8CV7YV0RepK6VYeIPA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a03bae18-9a38-854f-0634-f11c42e65fcb@suse.com>
Date: Wed, 26 Oct 2022 14:35:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for
 devices
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-5-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221025144418.66800-5-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0152.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8130:EE_
X-MS-Office365-Filtering-Correlation-Id: 62841d0b-7898-4a80-3aa7-08dab74e9aeb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	f+7ccl4ngmGokHiBEmAJIH569oGq4psIbQtX216Z8scgUXGsTBn3dazCuHI6/miESGhONu/cAODpQATZn91zH2M53ag//gmtlRaeNwA60pj2C3wABrXScTgBpCQ55t4uP+gorQyZsTuHAI2EoY/+twSVUnFD+PIeseTBIKi0Lko85cvSzdFU9BffKXmEweNBggC3VpdWg+XkshgS2qQllwaTosjNEV+Rnip25JFWdV/YhSAmBO15Wg+bvwOPyFiQceJSM7aH+SwdG1yf5U+dKc8DPnBEUwc30Tb9hfoqoaLmhigljrHkZt6yVi5u+NeBTOFBZi0m7ErI1gteeHmoTXB19DLZ6g9NgtQCSNMbcvH51RaziT5te2Y1RS2CGSAZyHeKubJZj2H8hkXwN8ZAUtUvML3esD/J6fyCoMa6fU8zlQpxnRWtU5ARW0Mp1iJhAEj364ybyGr6f4vJAXnDcaLMpIBq2pYbCMw8RcKt1UcaKSNUlLgSkV745GWqdtwPFZp/f4zTnpm7h4fRVOIR2bz3w+gOI+jGlA4ZxiVJ/L/It6V8FwVMqM2oN4IP/KWcudtT9havv/dqNkOKQth5AxkusQXD6x5VuappyY1uhZRfBFY88EmTEQ+PA1EZ6b/QYmZJMXzs8d5KgXN1GWF44rsT+yZFN4KAwHUNvf45FkpHqGsAb4PcH4OAa+OHtwpvnqJmvaljxkBdQxjLhVqniIcI3JulsMfC8MgUUlRKemrDQQ3ZU1Z9s74buapd/I/0KPCEGXx+7WXYqMJGgqqHHUfkHJEUT9cXB/qG3PtrGMo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(396003)(136003)(39860400002)(346002)(451199015)(6486002)(478600001)(86362001)(31696002)(83380400001)(31686004)(66946007)(53546011)(66476007)(66556008)(8676002)(4326008)(36756003)(6512007)(5660300002)(26005)(41300700001)(8936002)(6916009)(2616005)(6506007)(186003)(2906002)(38100700002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFoxMlBjSEpYbloyWnJ0eGZEckxBKy9TYjBRTHlFTlhhTVJncTh5cVQzVUJT?=
 =?utf-8?B?bGdwdUd2NDcvNWQvY0MwV2hkS1NaSThqSnRBdjFaYVE0MkRTekduSGxNQTAz?=
 =?utf-8?B?bG45VVJ3WnpZc1VyeVl2aHJJc1c3eE1EczVOVWpuQllRY1lOMXR0NTZ5N3hw?=
 =?utf-8?B?RXpQdUIyaU1NL1NXK1ArN2c4bkZ0WHJydjlWZUYrV3UzSllDTnErYXhFak9o?=
 =?utf-8?B?V1ZJcE9SRHBCR25MenFYdmZqb2dKU1VwWUFJZTZnbExCbTlRamMwN1RrZFV3?=
 =?utf-8?B?Y2plM1VYa1dmTHordnJ0V3h5dWFkNG1VaHNDejh1L1JoVEcvb3NMR2piMURH?=
 =?utf-8?B?WE5XWW9GVXRTaEU0akRQL28ycE5WWGdFMEFTSk82SzdvV0wvL3J5ZURkdGpS?=
 =?utf-8?B?cjQyOU9GSXZTb1d4NkNiR2JEU0paTzg2TTlmaFd4MHJ5VW9iVTNodnJ0WE9F?=
 =?utf-8?B?bkVVU09rNkhmZlAzMGZ6aGRDTDdsSnFTWHFjMEE4SGZWT2s0U0dtSWxUWFVn?=
 =?utf-8?B?aUJtNnNEd0NvQjRVUmM0YWR2YmZkSlpHVm5XMEd5Nk9jMzJKNGZWWG9ZdDI4?=
 =?utf-8?B?S00xZkM2TFRiVThpUlUyYXI1UFpJR3ZqZFAwbnFqOGtqT1JkcUpXN2NjSlZO?=
 =?utf-8?B?NWlKZ0F4R0xmaUlOMVdlcm9RV1hlWk9sOUJMeWNtY1plWk02UDgvYUZKWlp4?=
 =?utf-8?B?M1FHbTFwKzZaMkJPR3A3WnJkYXVBaVZUZ3VDYzdEN1dsRUtmcW14MHAyOC9Q?=
 =?utf-8?B?VkVScmlIOUZuN1l6T0VjSUtMSkJ4cU8weHREdFNhdTdhMFNLRjBhTGYyV3pI?=
 =?utf-8?B?Q0FxNWk4cFg5N2JZb2FJMnZiV2ZtOUlqNlZVRGVGQWlXNjdEeE5xeVBRWXMw?=
 =?utf-8?B?YWdLakt0a3V0OENpTDl6dFNYd2xvMHNmNk9qcTlXa0hOMk9KRWwvVVJmK2Y1?=
 =?utf-8?B?M0lCbUczZ0ZxWG1vS200SEhVYXFBQmVUMm9sQ1hNOG5UQklxYWVYaEtqU3Fv?=
 =?utf-8?B?SzNRQThUZWZhbFc4MUZWR2hGM3AxM0pIMDlVelc4R2VqT2wvK0dnUFRVdDAw?=
 =?utf-8?B?UWVpTENXWkt6ZERsMmZrQURpV2o0ZDVBa0FOczNwMjY3MGp2VjhqNjhQcUR5?=
 =?utf-8?B?bmZGMnBxZzlxaUpqQ1ExVERJTHY5TzAvbkp5ak51bkRoamd1dEtMaW1sWjQv?=
 =?utf-8?B?aU12L1hXWStycVpFaTZHWmQyam5VaEVXd0JIRXFwRm9BUkZudU5aT3o2Nml0?=
 =?utf-8?B?eDJTQ0hGLzBDVnBFcjAxTmJ4dnNUWk9FZzM5enNGeUpVckFWbnpsTEJJTG91?=
 =?utf-8?B?ejFJYTJNb0QvcnBZRW9EREdPL1pYVHFJdmJ6MmxEcFBNR1JDcnBOWG04OE05?=
 =?utf-8?B?TXZpMzNvSG9jVVdlR1JjL29vM0ltTk04RXVvTEFlc3NnUitwTHdRUkhSVXhF?=
 =?utf-8?B?NG5rTUhwdlB2ci9hbTFHMHBockw0TGI5SDlHajFBY0hCNE1vS3hubXVHcDFB?=
 =?utf-8?B?RFZmVnQzSG5Jc3IzVnh3Mk5zS2JMNnFYU3dCWnlPOXdqV1BUaWxVM2dzRXho?=
 =?utf-8?B?N1lONU01WmcwdHpvQ2JyUnBYWVNUZ2RMWk84VlZ4M0pLMVF3K2tkQVN5dUJC?=
 =?utf-8?B?N0VvekQwQmc4aUhmVy84MUNxRUhzRnNLRXBwQXJaSnpMc1NuSUlmRXdTT1lZ?=
 =?utf-8?B?ZVUzNlFFRDlZa29GWE02aXgrUHJzcS9rNmJqYlVRSEwxSkNvS2FSNTd6NlZn?=
 =?utf-8?B?dExsNkxVTmFIRWlwNVNIcDZKMzVwbFlwMjFrbHhqclZUTWxsaVBmeVdqMmFn?=
 =?utf-8?B?SUVSUXNWc2pCM1J0VTRyRm1wOS85OHM1S01IcU9mcGY1L0tnc3pDcSsxNWt4?=
 =?utf-8?B?aWNaSUxrVWxPWXhzL3BORmtWL2FBWnNYcDlZRkV1S1RpWGs3WnVrT0NzMy9Z?=
 =?utf-8?B?a3BOYUt1R2ZJcFV2QUFEaTZsY0xicEhhd1BaTkIyVEw0SE1DR2tUY0pUY2JW?=
 =?utf-8?B?RkJBZGVNRVNjRWptMVVXcTVLZDFTZ0kxVERTNklnSVhlbnQwNEx0b1J6NzU3?=
 =?utf-8?B?RTJ2MXR2dVZrUFhiTU9mTWppYWFEeTFaNm5ocSswQThzOTh6MVpaa1JpOEFH?=
 =?utf-8?Q?11T/pl1uFpAibHhV7uK0fOChU?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62841d0b-7898-4a80-3aa7-08dab74e9aeb
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:35:46.2035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e+En24XO4+U7KbjMh9iWqrNuN3xQXRmHr2ZZwsW6S+2lql44IHYWG4vLvUhAR/iCmNBJYZdkFm6J0hTNvx6mzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8130

On 25.10.2022 16:44, Roger Pau Monne wrote:
> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -121,7 +121,9 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
>          }
>  
>          if ( !rom_only &&
> -             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
> +             (bar->type != VPCI_BAR_ROM || header->rom_enabled) &&
> +             pci_check_bar(pdev, _mfn(PFN_DOWN(bar->addr)),
> +                           _mfn(PFN_DOWN(bar->addr + bar->size - 1))) )
>              bar->enabled = map;
>      }

What about the ROM handling immediately above from here?

> @@ -234,9 +236,25 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>  
>          if ( !MAPPABLE_BAR(bar) ||
>               (rom_only ? bar->type != VPCI_BAR_ROM
> -                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
> +                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ||
> +             /* Skip BARs already in the requested state. */
> +             bar->enabled == !!(cmd & PCI_COMMAND_MEMORY) )
>              continue;
>  
> +        /*
> +         * Only do BAR position checks for the hardware domain, for guests it's
> +         * assumed that the hardware domain has changed the position of any
> +         * problematic BARs.
> +         */
> +        if ( is_hardware_domain(pdev->domain) &&
> +             !pci_check_bar(pdev, _mfn(start), _mfn(end)) )
> +        {
> +            printk(XENLOG_G_WARNING
> +                   "%pp: not mapping BAR [%lx, %lx] invalid position\n",
> +                   &pdev->sbdf, start, end);
> +            continue;
> +        }

I'm not convinced of it being appropriate to skip the check for DomU.
I'd rather consider this a "fixme", as (perhaps somewhere else) we
should return an error if a misconfigured device was passed. We cannot
blindly leave the security of the system to tool stack + Dom0 kernel
imo.

And then, if this is Dom0-only, I think it wants to be XENLOG_WARNING,
i.e. without the G infix.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:39:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:39:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430531.682314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfh4-0004DR-UI; Wed, 26 Oct 2022 12:39:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430531.682314; Wed, 26 Oct 2022 12:39:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfh4-0004DK-Qs; Wed, 26 Oct 2022 12:39:38 +0000
Received: by outflank-mailman (input) for mailman id 430531;
 Wed, 26 Oct 2022 12:39:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1onfh3-0004DE-9D
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:39:37 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e1e2224-552b-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 14:39:35 +0200 (CEST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e1e2224-552b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666787974;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=bw9rQV/0FLFKekMb2yQK28V59IeT0f8Ipt+Y9TkCWig=;
  b=gMnTY6OE+lRF+XqHW//kMN2XeyBrj6o4l90VcjuLKwn3I6Ko4eFllrP2
   7pVbl5zj6E8wyJijwCIqmOBMuQj547meZFVKA3DItxD9muxgyifcMiWb1
   cpYZQU5kc/vb6qOV/GBxwko71GFJcMOofp9lTd1zMKIcqxEP7uRvEcJyb
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
X-SBRS: 5.1
X-MesageID: 83964485
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1/YPsKqbbidrS24+E4UUeyp5hwheBmLTZRIvgKrLsJaIsI4StFCzt
 garIBnVO/nbamv9fo1zao3joEIDv5Ddm9c3TwpkqSlgQi4Q8puZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR4geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz
 /UZCB4raSq62byE6vWmU7hI2J9yFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP
 YxDM2MpNUmeJU0UUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0FxRfG+
 j6WogwVBDk+P5+A9B3eqEiAue6SlwnbXq4JFfq3o6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM
 UN80igzqak/8mS7Q9+7WAe3yFaksxgGSpxvGus1wAiXz+zf5APxLngJSHtNZcIrsOcyRCc2z
 RmZktXxHzttvbaJD3WH+d+8jxm/JCwUJm8qfjIfQE0O5NyLiJookhvFQ9JnEai0pt74Azf9x
 3aNtidWulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdlis7yNXQomfXtL223Kc8O8RCNjCH2DU6
 RDohPOixOwJCJiMkgmET+MMAKyl6p65DdHMvbJ8N8J/rmrwohZPaagVuWgjfxkxbq7obBezO
 CfuVRVtCIi/1ZdARYt+eMqPBssj1sAM/vy1B6mPPrKijnWcHTJrHR2Ch2bKgQgBc2B2y8nT3
 Kt3lu71VB4n5VxPlmbeegvk+eZDKtoC7W3SX4vn6B+szKCTYnWYIZ9cbgXQMbpjvfrd+l2Im
 zq6Cydt40wBONASnwGNqdJDRbz0BSRT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwM/tokC
 kqVAxcCoHKm3CWvAVzTOhhehEbHAM8XQYQTZnd3Yz5FGhELPO6S0UvoX8JpJ+l5qbY6lK4co
 jtsU5zoP8mjgw/vo1w1BaQRZqQyHPh3rWpi5xaYXQU=
IronPort-HdrOrdr: A9a23:5DJwx65XTupAn/I4KwPXwNzXdLJyesId70hD6qhwISY7TiX4rb
 HLoB11737JYVoqNU3I+urwXZVoI0m9yXcd2+B4Vt2ftWHdyQmVxepZg7cKrQeNJ8SHzJ8/6Z
 td
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="83964485"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH] CI: Drop more TravisCI remnants
Date: Wed, 26 Oct 2022 13:39:06 +0100
Message-ID: <20221026123906.10421-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

This was missed from previous attempts to remove Travis.

Fixes: e0dc9b095e7c ("CI: Drop TravisCI")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@eu.citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Wei Liu <wl@xen.org>
CC: Julien Grall <julien@xen.org>
CC: Henry Wang <Henry.Wang@arm.com>

Preforably for 4.17.  Not a bugfix, but this does reduce the amount of
irrelevant junk in the tree.
---
 MAINTAINERS          |  1 -
 scripts/travis-build | 32 --------------------------------
 2 files changed, 33 deletions(-)
 delete mode 100755 scripts/travis-build

diff --git a/MAINTAINERS b/MAINTAINERS
index 816656950ae2..175f10f33fc9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -274,7 +274,6 @@ W:	https://gitlab.com/xen-project/xen
 S:	Supported
 F:	.gitlab-ci.yml
 F:	automation/
-F:	scripts/travis-build
 
 CPU POOLS
 M:	Juergen Gross <jgross@suse.com>
diff --git a/scripts/travis-build b/scripts/travis-build
deleted file mode 100755
index 84d74266a01f..000000000000
--- a/scripts/travis-build
+++ /dev/null
@@ -1,32 +0,0 @@
-#!/bin/bash -ex
-
-$CC --version
-
-# random config or default config
-if [[ "${RANDCONFIG}" == "y" ]]; then
-    make -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
-else
-    make -C xen defconfig
-fi
-
-# build up our configure options
-cfgargs=()
-cfgargs+=("--disable-stubdom") # more work needed into building this
-cfgargs+=("--disable-rombios")
-cfgargs+=("--enable-docs")
-cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
-
-# Qemu requires Python 3.5 or later
-if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))"; then
-    cfgargs+=("--with-system-qemu=/bin/false")
-fi
-
-if [[ "${XEN_TARGET_ARCH}" == "x86_64" ]]; then
-    cfgargs+=("--enable-tools")
-else
-    cfgargs+=("--disable-tools") # we don't have the cross depends installed
-fi
-
-./configure "${cfgargs[@]}"
-
-make dist
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:47:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:47:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430543.682331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfoy-0005qx-Sf; Wed, 26 Oct 2022 12:47:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430543.682331; Wed, 26 Oct 2022 12:47:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfoy-0005qq-Pl; Wed, 26 Oct 2022 12:47:48 +0000
Received: by outflank-mailman (input) for mailman id 430543;
 Wed, 26 Oct 2022 12:47:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onfox-0005qk-RE
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:47:47 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2060.outbound.protection.outlook.com [40.107.249.60])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 63f20c0e-552c-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 14:47:46 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8826.eurprd04.prod.outlook.com (2603:10a6:20b:409::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 12:47:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 12:47:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63f20c0e-552c-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gwo4mFI9ZXMFTh5eRUleTFzJ92tyYjZjXJCpXRHtgerGR2iTgJFgBUJCO5SrjcxvVAr6yUFQw0kn48WqPPTJQhNcUoJbK2RCv/k0Y67xz3nmRbDUox6dOV+vb5/Nb7jK7lLgdGbIsKZMicEHkUpw+FGY31b1fFmqEiMh+/dotBdKT4kWAfdxV1av6eLlsLiQOHo/i/OvMHl6yJnK3UQx8GqVTSBUPVIzaUfx5FEzR2ojPP4eMPbR4kfXAKumSGXTCir7en/Dr6yryjY61P3HS+VbVzgsP5Sya9qEIL2/lTsNRlQTBjLs4Mpq7Sp9RRT8Zqlk3H9+wXpF6RwZWFFONg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VeAsD+nm3sk4y+riIz5Mbd5zOluwHxMpYPiCG3igjCU=;
 b=K07UWEF5CgFhtsrSUZ3wXxNaQVXQfTrmfFKQgg+TchYO2ayLRGTIfh5cgn0eC2M5c+a4PkcMgDHJEgWtluBvVHzCyeWMmFqEroZuZgloq6wCDp2altHV2G5q+Env8pPhHjlnpKcDDOzces2OTsIvGN+JGMTj4E0InYlj2uPNHt80bKrUOLIM+lHB7JAq5Phrr9p2X0Ou6UrubKSBH5rNuqh2szklVF+43l2PenEpk+d4Ez08jQ3X+SzIyT/gI26nLKLjY5sHaCmA/AM1srAwZd9nAj3V2UNIYWfNFBSaS1WUU69Cybjmv94M7ZGpsURFPhtaYaEognhjM+Q7J+SnPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VeAsD+nm3sk4y+riIz5Mbd5zOluwHxMpYPiCG3igjCU=;
 b=31nnsZctxn7I6iYSZ9FduVbmvQDpPc/U9C57hzG3NbBh213i+7Uutj7btsHtG+aBRGu7aUFxmD48AfZdxm+YU+zxnPwWoizbRAUuZHjtPG/lz/1h+MlSDGo3+G+qTwI9XUl58XxMdAdlPwmZgn/0dSrqlDcP4CqgP10IOmMQ0EOsH4h1Jf6UZpOMTZl134SxmAynHPVlACqa3GezBOmC9/Nzy0EHJELQcVfeem3FnaCUk7PcxcqrHzn7l8sizEu2z5Dguxnj6kG04D+r1vj13KaxwigsGmLCg+MOPPuW7yorhReKuRLv3i/7mQXwxWlKDvpUWxCdV1jNbIMkwfISEg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <666377e8-fe58-bc9f-70ff-2e21d93c691f@suse.com>
Date: Wed, 26 Oct 2022 14:47:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR
 is mapped
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-6-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221025144418.66800-6-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0002.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::7) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8826:EE_
X-MS-Office365-Filtering-Correlation-Id: 89447bc4-392c-48b2-4c9b-08dab750471f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6O0VVebZ23pYsr1+fxJdxyQy6C5m/y3Ee9uE6yW9iBaUcbS/I9KtnHM5bz1SgcSHqBXSvpuKQSw6/Ny4UE3P65n/AewB6t2IkCgHbUhsmJTgCr2cM6KsOl5bCCryANF0Q7Utkr/3lv51FarTid4q+0S+QJVH7Hk9HwZMfcym/SVrMysQ9FaecGw6M2CLkujbebYeUyNDPeF11CIe3LwH9b3Ev6ixuwtBrbMSttGkJeormE6+6VyfBPqZFh9cfPMsBplhersnkyW3PMVrW/6Pou8RT9pf/BwpJpYbTePLu+pctAANWKLZgBDLLbDsalgyfrnzlb+esXaDBnvMhrXNEyJScHRfiUGT4QRCtrHX09hXXzOVkh6qyI2d68+VvVBNax6BrccL5ln8JndejOsNmGb+pezasoFkrdu3mbsujmsSkRAxsN8ZmDiKacdBR9nH7om42YfaiZVKlbaF/1z21v5OP95TtuLmO9CRkPMtqOlmQq3mQKU47cRqqTJ9YGhKRQtwRBTwWOgFfry6TKZfRhTgmMDcg2Bl+iHJHgc7qQ9o2L0+vII9TLcY879vdby454N+a7NxPe9twwVZ214PzhrSQ8figa7kqw3dPQUZ8/6Ad2C9ls/1nz+ePAshPggV6Odq4iXEx8GMgj3KbxGa0tAicO/+JkmfdkQzyo/R+RS2yWtLoqZ/vdUQk9J2TL/5ZJgt7Z2b06IFGPF8mTHFvZLG4QHKGoFtGc8yMph3M5qVBCfL/+nfPDv/ajh3Cw8yRQGkNuc0nFyvt8mSqp+/rg9VS/x4vxiDH5j5nzLErFk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199015)(36756003)(31686004)(83380400001)(86362001)(31696002)(2906002)(2616005)(5660300002)(186003)(6486002)(316002)(6506007)(26005)(38100700002)(66476007)(41300700001)(8936002)(66946007)(8676002)(66556008)(4326008)(53546011)(6916009)(6512007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VnE5YWRZRWZyNlpiNjh2L0ZsU0dTUkxXeU9ZV0hXMVVKeTcycWlLaDdRemIz?=
 =?utf-8?B?RTZ5TjNOL1JTdzJway9LdTBtOTlFYTlYVDN3UGhLa05sUWJKL1ZjM3E3Ylpr?=
 =?utf-8?B?R2VScCtHSDNPUHo5NHVZQnpkbWFOMmhUSCtYdEM2WGxwV2NTc2FYb0NoZGFi?=
 =?utf-8?B?NnNtd2VleTVKNWw4L0ZSRCtzTXVXNXlZb2p5cW45bzd2YVdkSXREdGFiaG0x?=
 =?utf-8?B?c2JTZFBRWlYydG01NEdhaE5vR1pPbmRrM1pVNDY4Sy9ibEdlNmluS0NFZ094?=
 =?utf-8?B?WXNnZzBmM2Z3NVFVaDBEbkp1UUU1VU1VMkNpU2xiRmVOSDBJY25rY1R2aHN1?=
 =?utf-8?B?eTk3WDRoTHowK2xsS2p0TTVLMEVMdE9URmFvWWt2V0VuY1kvSmUxNE5nOFYz?=
 =?utf-8?B?M0x3U3JHaDMwbXEwNEU2WnBVYmpiK3NGTTZLRlVWOTgrWkZYeGxweDl6MFZa?=
 =?utf-8?B?djUrYlJTK0R2RVJTSHpBZXhFMU5JT0lpRFlLNE00VmF3SHVtV2dpT284REhU?=
 =?utf-8?B?Q0RMNEFmaFVHZ2xGK1hwV1RnYjFXdGdndWE1eThNZ29Zd2p5ekdQb0U3RDV3?=
 =?utf-8?B?UlR4ZUhxY1NmWEhwODcycytzUDFSOHhDWnBnelk0SldETHBsMExTS1JHTWR6?=
 =?utf-8?B?azlSVXlLNlU5T3ByYWhoNVFYQ29zKzRDQXUwMDdVanFIaFFXdnZJc1ZWMnc3?=
 =?utf-8?B?N0pmbkxuVmNlcnZpU3JhQklLdmlwVy8vc2s4SlVYV04yZVMyTTJhZzBQQ0R0?=
 =?utf-8?B?b0V5MmRLM0dyYU5PaExzUFRMNU9pcWZVYXJKaXczZnNBbDFTVFNlRWY5cERJ?=
 =?utf-8?B?U1pxVTM2c3IzL2VLRjNRMVpRdHhxVVFZS0NhM1BwSFoyem54bHVKZytGME4w?=
 =?utf-8?B?a3JwMzRYTUIvMTJwZjZ0N1lsMkpWYW44OC80Z09TNkhiMU5EYlB1MTdPVkY2?=
 =?utf-8?B?QS8yZ3lGSXdaNUExemU1YmhxOUJsZjJDZXFqZ1hReWdrd0cxemhrbTRVbk5s?=
 =?utf-8?B?bG0ycVJpbzRxSWs2dDkzbWlyU2wyV0JUdDZxcDZXM3hSVTZPT0tzS2hCdnBn?=
 =?utf-8?B?Mmpqa01tV3JFSC9QMGFZQ0R6YlptRHBXTTVUcFVaU2RUSmpHU1dORFhPNzB3?=
 =?utf-8?B?UmZ4d1NoZVhmN0VJYStmMzJQa00yL1dLN1R0TEJGK0Y4dWtaOXBqNTlDK2p5?=
 =?utf-8?B?QkpGL0hFSEJucm1DbnhHa0JhM0NWN0J6SFltUlkxdDhwTHVHbjhFd3BieWpr?=
 =?utf-8?B?dnZncDNEMFgvWHFnUGVsbTMvQitUVjdyUGNXVmZGQlg3dDlhRndsc1JXVjdr?=
 =?utf-8?B?WjlDM0RnNVRlYkhRVXBkdzc5eGh5MXBVS2JuZ01xVlZsMnR5ZDlzbmRjVWtu?=
 =?utf-8?B?WFVVb1NBM0lZa1J0Z2FpMEg1SW5taEJweUZCd3R4YTRLczVvMm93c0tLaDVo?=
 =?utf-8?B?MjdVb1ltVnZWcTlXcHFrUFUvZTZ0bCtjci9NWW9Eem9wd0EzZEtpZ3Y1dzhS?=
 =?utf-8?B?cGszNDAzTHREcFZEWERJVGw2YTRVM0FOdVJjbWRWMnpNMStPVW9sWmlQNUlj?=
 =?utf-8?B?TGQ1VURwWmxnR1UvYm1RWExoeCtNRkJJVHB3TTZWSkg2QkFzaDNCUDlIUGJT?=
 =?utf-8?B?T0JMT1lBQ3JwMHdiRHJzb04vaXVXYXVpNTlrYVdTeEgrNFlVRUZBakRaTWhI?=
 =?utf-8?B?R2o5N3pRVXlYeXVJMnR6eTlvcXBIVTFuR1VobTIrd01hbjV4UFhneWx2aGg2?=
 =?utf-8?B?MDl1SC9UMHpMUEY3ci9neUpwZVRkbUJEUlJpMFZ5QnllcHhtUFBGVDdFaWhU?=
 =?utf-8?B?OTVFTkZJS3o0d0xRbUQ5dnZSNXZHT1VSQ3YvUnp2emlNYW9QZTVTdXc4TnJx?=
 =?utf-8?B?YVVqNVljeS96bisrUnlydHprNHZlZG1MSEsxTy9hWk5scTlWSTVQekp3eHFm?=
 =?utf-8?B?TjNKa0k1SDI5bmhERzBpcVpBL0JYL09mZjdhU3RadHVHVEhLdGlwZWJuMGdq?=
 =?utf-8?B?SS9KTG0rU0E4cnRvWG5IVExOdjRPaG40UmVZMmtwSmFXeHdONW9DYU9PaHdQ?=
 =?utf-8?B?YUFsQU9mZFB5aDJ2MkU1dWxTNmVSNytoVXd3YXRKRmpiRk9Td2tDWnpWQVZU?=
 =?utf-8?Q?PEvyIbxOp/KtSmVoJznt7h3uu?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89447bc4-392c-48b2-4c9b-08dab750471f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:47:44.6096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QBWP90WpZuKx+eb9uu2VixuBsqh+WwXHu1cjjSKnNgJ/HzJ96oeM35UpeNYda/KDbguSPxHNb7nJ9HxQWWUPKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8826

On 25.10.2022 16:44, Roger Pau Monne wrote:
> Writes to the BARs are ignored if memory decoding is enabled for the
> device, and the same happen with ROM BARs if the write is an attempt
> to change the position of the BAR without disabling it first.
> 
> The reason of ignoring such writes is a limitation in Xen, as it would
> need to unmap the BAR, change the address, and remap the BAR at the
> new position, which the current logic doesn't support.
> 
> Some devices however seem to (wrongly) have the memory decoding bit
> hardcoded to enabled, and attempts to disable it don't get reflected
> on the command register.
> 
> This causes issues for well behaved guests that disable memory
> decoding and then try to size the BARs, as vPCI will think memory
> decoding is still enabled and ignore the write.

Just to avoid misunderstandings: "guests" here includes Dom0? In such
cases we typically prefer to say "domains". This then also affects
the next (final) paragraph.

> --- a/xen/drivers/vpci/header.c
> +++ b/xen/drivers/vpci/header.c
> @@ -128,7 +128,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
>      }
>  
>      if ( !rom_only )
> +    {
>          pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
> +        header->bars_mapped = map;
> +    }
>      else
>          ASSERT_UNREACHABLE();
>  }
> @@ -355,13 +358,13 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
>  static void cf_check cmd_write(
>      const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data)
>  {
> -    uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
> +    struct vpci_header *header = data;
>  
>      /*
>       * Let Dom0 play with all the bits directly except for the memory
>       * decoding one.
>       */
> -    if ( (cmd ^ current_cmd) & PCI_COMMAND_MEMORY )
> +    if ( header->bars_mapped != !!(cmd & PCI_COMMAND_MEMORY) )
>          /*
>           * Ignore the error. No memory has been added or removed from the p2m
>           * (because the actual p2m changes are deferred in defer_map) and the
> @@ -388,12 +391,12 @@ static void cf_check bar_write(
>      else
>          val &= PCI_BASE_ADDRESS_MEM_MASK;
>  
> -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
> +    if ( bar->enabled )

In 3 of the 4 cases you use header->bars_mapped as replacement. Since it's
not clear to me why you don't here, could you explain this to me? (I'm
therefore undecided whether this is merely a cosmetic [consistency] issue.)

>      {
>          /* If the value written is the current one avoid printing a warning. */
>          if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>              gprintk(XENLOG_WARNING,
> -                    "%pp: ignored BAR %zu write with memory decoding enabled\n",
> +                    "%pp: ignored BAR %zu write while mapped\n",
>                      &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
>          return;
>      }
> @@ -422,13 +425,12 @@ static void cf_check rom_write(
>  {
>      struct vpci_header *header = &pdev->vpci->header;
>      struct vpci_bar *rom = data;
> -    uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
>      bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
>  
> -    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
> +    if ( header->bars_mapped && header->rom_enabled && new_enabled )
>      {
>          gprintk(XENLOG_WARNING,
> -                "%pp: ignored ROM BAR write with memory decoding enabled\n",
> +                "%pp: ignored ROM BAR write while mapped\n",
>                  &pdev->sbdf);
>          return;
>      }
> @@ -440,7 +442,7 @@ static void cf_check rom_write(
>           */
>          rom->addr = val & PCI_ROM_ADDRESS_MASK;
>  
> -    if ( !(cmd & PCI_COMMAND_MEMORY) || header->rom_enabled == new_enabled )
> +    if ( !header->bars_mapped || header->rom_enabled == new_enabled )
>      {
>          /* Just update the ROM BAR field. */
>          header->rom_enabled = new_enabled;



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:48:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:48:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430548.682342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfpy-0006RL-Bb; Wed, 26 Oct 2022 12:48:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430548.682342; Wed, 26 Oct 2022 12:48:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfpy-0006RE-8R; Wed, 26 Oct 2022 12:48:50 +0000
Received: by outflank-mailman (input) for mailman id 430548;
 Wed, 26 Oct 2022 12:48:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onfpw-0005qk-1f
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:48:48 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2058.outbound.protection.outlook.com [40.107.247.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 884ec12d-552c-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 14:48:47 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8939.eurprd04.prod.outlook.com (2603:10a6:20b:40a::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 12:48:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 12:48:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 884ec12d-552c-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FDHH/4WWMXAp1B+SB+HbTPWEgESb7Yp4dRA99eykvSGQePdJyYX72jzfYu3boVUClIJ58QURWaCLHS/AigvlJSdHRBSCTsrizOlxF3lqvH/A2tslCx/VV8dGsXY2sdGuQM3hO7WRFAIuZHfgEycyV6k9BjBuJ5KbcCTgGZzhvcSkMdcIk6U5ve1PBlYzFqDWmM9fvtn6ePvmIuEZlPo1MkdIwS9zLHLN0AiLyCgSJnaeFLmEWhRb/ZSd4WXgRKhE7c5cPPxmXqw6hAPSk0VzjZt0BRLsuzUbat9d+DPvWAeqVm65QSOCXUja+tw5YxyzAXL1rEMW5NYyxj2UCMlU1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2EMIls/P8zRUMJ2taZP2fTjAv1f6gT1A7iuI3RxRK4I=;
 b=Gy/pjOBlIolbXSfZjrKtuM8cFquuY4hnvxUtw9Q2LrRwicTm4ukV80zRlWvfT1RsAbSi/f2XF+aWymzwsTIMyrhtsUWi41neGRz/VOWK2GDpv7GyeT3/fBv3oUmFUtAP0/MIzDIFUajppsKqBJIOOWJyYzWN6eD4ParNzk6DdGbntk+GUqQl7O60Nf0wLXZfOYPWCMXA/9htDsCM3HeXZKMEKXCfoEZK28LQH0KmdVGtAoXo8wiEBgMn8HpCkq0LQ5OUltmhDe4ItXvmvqFN6ucqNQ1JkXB5al8LB/ImSt5kJbcg3jeCq443SUxIR+mqjsbQ2Rho7I8RPDcJlmWCLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2EMIls/P8zRUMJ2taZP2fTjAv1f6gT1A7iuI3RxRK4I=;
 b=0IaB6KaY0QyTVzfwwOgJmnQmEHG5mti5U7fVGDAVEwquwDpvRt2LH9FQvaaLNfw/eChAt5MfNqnlOMeqiFyqBS42qc5V1wOpWBTD9JqiOAFr+5Ny7NSPTaKMdtoTeEQknGiFr0df7SQLwdUcfG+0xU3iLVBEomm7WcizNREezZouNAdHsczXwcyekQL98VTx6MiFBT9aNQweh8KIfCvSF+79ono43rlMExbiz1PJ94SEQnGlpjMV8RMt++/c5CB+dFxI3koaHaWdP03B4sIfFyKmeKX69kYvuTOGEbBQbKhscP/qIJBhT32Pg/UWLnndTGxpTYKQD9BADpk0pqsmuQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <141dd739-153c-6d72-d1cd-3dce579b7e7b@suse.com>
Date: Wed, 26 Oct 2022 14:48:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] CI: Drop more TravisCI remnants
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221026123906.10421-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221026123906.10421-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0125.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8939:EE_
X-MS-Office365-Filtering-Correlation-Id: 5cf946e7-5ab9-428f-0ccf-08dab7506b14
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/TXFBEAry/ynim/3EbBw+Yk0sqdyI95oTySS7FjP0lQJxWNBEh5lzFcXkczt0gMMOl7GD59OImkEtPb3zdaaspDiT9RbW0i3Ey/cFKlUY6rLz3N/QFN+CJcrH9hE5zYYxCwJXuPYvfXLSpf3IMyOQrNhmvhyN9qC/CF0gDUem2L3Q4T/BNBnYgfx06SahybUKkVlFtl0+RtH2BxqRWY0U+7+UpbLLtscS6Oix5OebkxBhnJHdf+zk/KeQVWcBtvLN9fjEyG92aeVU1Xj4yZzcl4iiUS2zgtyH7aK0GzRhiHXjkJx24VMrMbF/GhRRVLX83HBYiY1DvaYoBM75kNOcrYcLxzUKSyGLoowFVClNomYTaeVweHiapKqWBQqxIuap91J56xlvGVsWwLIgIEiIpIEzVhQQ5yb+S43Iv3JUz0GD+C5LKtZxwemALCzZZ9whprU/1Jj/BbfhRu5PQfA9Xhh9vQt6oLjaKym3U8Eo7KqDs6/HwUlQDd7CGGS0R6hGWLTAJAMrvf/G8QYilsSV/cFQVb1E6GNteLB4mkhatmk+d06h9Rkbs7zFq/GaznMrFXkfL8rMD10VynyjzGesPRgvAMcmktoP9gWTWefsD8ul6/JNVvn9psxBusaLSzoDSvVIDNYivmJDJVzbZQVvTsMLRXVCEVCSSzwHnx0WDiXRnoGxZKyDRRz1AfobB7FLQqVdaVofrSrtD7lpvN4mJBABbjNioei0ts7HBZ7NVgk8Sh8gsx97nZXJx6TBeD4zZ15tyyF83Jx9715hXN3MH6QrPmKAnTkXx7aazPNaM4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199015)(36756003)(31686004)(558084003)(86362001)(2906002)(38100700002)(2616005)(6512007)(186003)(66946007)(31696002)(6506007)(53546011)(4326008)(6486002)(26005)(6916009)(5660300002)(54906003)(316002)(66556008)(66476007)(8676002)(8936002)(41300700001)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1E1MjZjZSt6MjJlOUVGZmhTM0Vnb2dPN21vdHQ3cWM3SXdUa2FYOHlNTlh6?=
 =?utf-8?B?VTJpRkhtTW9jdnRrWEtXSzljbzNMRWlNdmZaZjhIMk9YK2FIRXdZVzJGQkN1?=
 =?utf-8?B?UWNDQ3U5ZGY1MVVxQWptZTVPSGs2R2Y2blhjdXNOWXBreDNYOFYyT2owTWtK?=
 =?utf-8?B?OFk2RklHWnVLTmZzbUdQUUJDK2l2azVtYUtLWmxRQ3hhWFo5MEYyOTR5UG5J?=
 =?utf-8?B?V3k1Yk1FUXZzVWM4QTRXSkJ5bnhiYnlsOHBHU2FZOUZBZUFYdWRmdmx6NXVp?=
 =?utf-8?B?OEY4NHJyd1ZNNHYrSXA5aTRBUW9Hek5meVJHWmpsck56MmIrUUs3UUhkU0tq?=
 =?utf-8?B?NHQ4RERqeGp5aUpTM0dqcmtxRkJsWWFDeVhBTXFRYmczOWppRlI2RzZJTmRM?=
 =?utf-8?B?T0orOG9YUG1XV2x6OGdzTmo4eHY3QlBMTXhrTmVkem00a0ZlVm00UjZsb1lF?=
 =?utf-8?B?YStjdlpBUTVjWVUwMWZLUzFmSHowQVEydUhmb21Vemg5M3g4akVHZTErVE9P?=
 =?utf-8?B?TnkxWU9GLzJFZzc5RTZOQnVNdkJQQm1nd2wwOU1TUkMxank0djhIYndRVnRp?=
 =?utf-8?B?eDZXQlVSd2FER0Q1TmMrLzRFUjRRV3BBenVUcWd4OGttYktQTmFXdXRVVFhl?=
 =?utf-8?B?UzlTQUxpcmR5UWc4RG5QL3Q3OUdQMXJqZlZUVFprQnlwZWhvUjlQWDFGaEgz?=
 =?utf-8?B?OXd6SnQwK0ZqbTZSWktpZWVhaFFCSHdCL2tSRS9ON2hsby9MdW9RSXVUaUNT?=
 =?utf-8?B?Z2RpRVZXWVNZOHZ0Z3RzUnlvVk5NUURMazFpZGRJRG1oZ1hyTWhYaHRndER5?=
 =?utf-8?B?bk9MeEhhQndhY2thMjdQbkR0bmhLTk5BR1pyemw2Wk1FMkFSTDhQV091MDBu?=
 =?utf-8?B?U0hhQ0Qwb3ZJZlQxVHF6bXROS21PVW1lcWhWbUJuWnJ0NzZkU0E0ZlhiTWRm?=
 =?utf-8?B?WmJ1RmdackxaQjdWL3FuNkhWVjhlSVBzdmU5Y2ZjYWtmQ0VpZUNOS2t6SENh?=
 =?utf-8?B?UDVSNk5Sa3JuS3I0Sk5IcEVMTlB4TUxGcTdRenNRTUllTnFCWmg1T1dMa0R3?=
 =?utf-8?B?NWlEcFZiL1pnSTQxTUJ4WE5UMTVHU2x4Tld1d2hFajlRemYwZ05BQ0pyd2Fl?=
 =?utf-8?B?VUdNUFFwNU9KSjZwVjQybGV1cU9OMEROUXgzVDZFa0xqTVlRajFDYjNtSCsr?=
 =?utf-8?B?cENHY1lEVmxOTXpjL25iNjZNQVFIWnBTNXZwdDhTOXJ3NEMvOTF5VWk2SG9F?=
 =?utf-8?B?Mjc5NDBBODVFMWtaTXJVYW95bVN3aE8zUGk0YXdwWk5vcjRzL0ZWQ3B3Wkl2?=
 =?utf-8?B?SjJDREtDNDJnWFpsVXYwZmJiYWE0a0hFSStVTENQTTVKd3I2Y2h1MzZCTFYy?=
 =?utf-8?B?RFJ1Skc4SlkwSDQvYncwMzFqY3BJNitJR2hROUE5SlhSa3hnL0lIM2pLajdp?=
 =?utf-8?B?M052RHp1SFJUa29VUXFTNlVIWkJ3UFRJdC9xVllEaExDU1I0djl1alZkbkFo?=
 =?utf-8?B?Qk9PUmorQ0tsZTZCcHB4QmQ3bmh4aThLTkt5QXNCcTFTZ2cySGt3VGRjZXli?=
 =?utf-8?B?VzZPWDFsclRaUnQ5Y3pTUkt2Z1FZc3luT01mbFoyQTRRZ2pxN2YxYm1GTzZo?=
 =?utf-8?B?akZMOEtJQzhrYWFtWUx0bTk3UW4rcjNvQlBSd0xRRkVaWVIzdEZ6R2gvejIy?=
 =?utf-8?B?MEhkTzRxa1U4Q21PUTYwVVc0QTRiUnNISXdHalN1NUhYYktSRi9waWp4aUlp?=
 =?utf-8?B?dFVQb0hOM21vNVpzR293VE5ZZFp1TlRmQlFmOFNzVER3NkJQSlRZaWVUWUhv?=
 =?utf-8?B?cUFPSFpSbzdFaFl2THN1WXJsdjZaRnNmcjg1NW1rc1dlc3lRUFFNbzZndHFN?=
 =?utf-8?B?MlNyZGdKTlFuZ1JnQkNBQjIvT3ZtTGZrdldoazlrTzFVREFwVldhcm5LQlRQ?=
 =?utf-8?B?YVh0QVZxMVZNaEVIM0g5WmhjMkpPcUk4RFdKN25MMkdYOExEMmw1UUZ3bFlJ?=
 =?utf-8?B?ZnZMU3FTOUsyc0dqOUNBZWhOZXNmU0lIZzN6TE5obzRiUU9MQXM2Y3JCc3pH?=
 =?utf-8?B?UzVicld2aEFLV3YxcWo0WDQ4YlJlaWptMmtZTStic3U3MVhrOFFiT2lvV24r?=
 =?utf-8?Q?jV2bcEB7LMEUCamdGQ01hYDG9?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cf946e7-5ab9-428f-0ccf-08dab7506b14
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:48:44.9339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BzYABfYZMVWFoHOuQ1CpkUImGGgfjp4L95ksaKfQLY8cGoT3UC6h3yX2Zv4KQsi1IlmBHkYdJn2KUJV5kcjqZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8939

On 26.10.2022 14:39, Andrew Cooper wrote:
> This was missed from previous attempts to remove Travis.
> 
> Fixes: e0dc9b095e7c ("CI: Drop TravisCI")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Wed Oct 26 12:58:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 12:58:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430552.682353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfzJ-00085g-7j; Wed, 26 Oct 2022 12:58:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430552.682353; Wed, 26 Oct 2022 12:58:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onfzJ-00085Z-4y; Wed, 26 Oct 2022 12:58:29 +0000
Received: by outflank-mailman (input) for mailman id 430552;
 Wed, 26 Oct 2022 12:58:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=n4Ky=23=citrix.com=prvs=291e24488=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onfzI-00085T-A3
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 12:58:28 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e07035d0-552d-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 14:58:26 +0200 (CEST)
Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 08:58:19 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BL1PR03MB5957.namprd03.prod.outlook.com (2603:10b6:208:310::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 12:58:16 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 12:58:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e07035d0-552d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666789106;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=S6Gv7JgTxvNnJWtFzs1s8mFI3IbPKUso4zr1nNedTwc=;
  b=YXyZqMADPjkJ+aV5GKZLqSf312derPHLoWN1rT+bKjkzY97UKK2gazoZ
   v3n4HKETs37yW3jX0bjBYL8ktwHQ3F7K3GA1AYYRqkYV5tQp4HTNY7BGl
   rhIYDEfQ7iHqZTMAejSTg5+vK4xBiJbKpNWkirLUXzNh6HmmrTlevKQ2Y
   0=;
X-IronPort-RemoteIP: 104.47.55.103
X-IronPort-MID: 82639266
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:a4yH8KgKk3ThHBITflsR7yn2X161UREKZh0ujC45NGQN5FlHY01je
 htvUWrXPfnZNjegf9onPIzg9hxTvZaHyoQxTAFq/C02FH4b9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmP64T5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU0Wr
 fMzKRY9Vzm4p8SzxpLmT85lhO12eaEHPKtH0p1h5RfwKK9+BLX8GeDN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVQquFTuGIO9ltiiX8Jak1zev
 mvb12/4HgsbJJqUzj/tHneE1rWRxnKhBtx6+LuQ9edL2ECB3kIvKl45eEua//OpqRKmcocKQ
 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUSyAyL0LuS3A+fCUANVDsHY9sj3OcuTCEu/
 k+EmZXuHzMHmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXryos1LFae0ipjwBmv2y
 jXT9Cwm3exL1ogMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl
 BA5dwK2tYji0bnlePSxfdgw
IronPort-HdrOrdr: A9a23:HBpTmKtDpUv8XiMOLBfBhhXN7skDYdV00zEX/kB9WHVpm62j5q
 OTdZEgvnXJYVkqKRMdcK+7Scy9qB/nmKKdgrNwAV7BZmfbUQKTRelfBO3ZrwEIcBeeygcy78
 hdmqFFebnNMWQ=
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="82639266"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DQxlwoXsmiqWGYXNFQYjGhYsLfe7ulNjbEFczPQwOT3A4XriHTzdN8Gtb4JTM4kypiJb8Xb1H+d18DFLIsDQxA9tu2EY2RQXiO3GOWbsk5L3aTn1TV0jlD2pwBJdwC6VGRR8g+Ef/pMyWNKtQ5yL2xW6opuP8npC2fyGisZdFDx2MFoa0V5q15WqIl++uxw4NkuSbdhvV8v9BN7YbebXuxspt0ysJoAuS/eXZ51ASRKJVG138qvuiKgvWfseMwLgS7v09C9WWHmhmtqQwRii8jyxeSORd3B8KEn7aR6AAGLuDWftd/3LstTeHUkPuTx0XqqX+o43kgQRK36Dn+KRNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+BN02nZQ3WWoFkhtqZyZcB4FegHtCKo6r1cu4pKyFp4=;
 b=bJKS6H5j4uq36k7SJTnEgmoM0pV/3x135mR449MEawU2L3pCzoRjO5+0SfVYRHj5cRVg59L3um3sNCkYvlaQBFKxQFmlPd41gDx0YZm7W2t4E7n6RLMqk3FMZUsqvivtAVCwnLlqmyiepjHSkwysUcwcFmeuBMDfNDo07eOp9RRk5phQsFoJLcPtOy5bUmn2FXsKYjUCML2zLwoW5+270PLUzr54bQqNT96o+LxocVRHkoTbOwLmphIdUUSpVIcWJLDAoo7vSWTbjeX1C0/Ps2lOVIbH5DSv1z4jQUg51+kb8cOhFm7bxPzOBn37Eo5ShRuAZRgkkKGHUTFQAJ+NPg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+BN02nZQ3WWoFkhtqZyZcB4FegHtCKo6r1cu4pKyFp4=;
 b=ViPFS6GipsT46hxxqJvKrAUM5Oh/GU3DR8rU+UUopwRO6EG1WPn5hXxaLs1dIs7roiT9Ed/AOPsgHt4Xc1AkYoadHVlYDzZT0CSm2Kkfg0aQOhgTyCTNZB+IZMz/IvK0v2gjk6Huc9/P+ATXvS+h0Aec1QFH2+yAwNJeADd0G2o=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 26 Oct 2022 14:58:04 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, Paul Durrant <paul@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 v2 4/5] pci: do not disable memory decoding for
 devices
Message-ID: <Y1ku3PPoBpZDtM2U@Air-de-Roger>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-5-roger.pau@citrix.com>
 <a03bae18-9a38-854f-0634-f11c42e65fcb@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a03bae18-9a38-854f-0634-f11c42e65fcb@suse.com>
X-ClientProxiedBy: LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1aa::16) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BL1PR03MB5957:EE_
X-MS-Office365-Filtering-Correlation-Id: b1e47be6-70a0-49f6-1d54-08dab751bc73
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7vyxT0sL2v83jWM8rs0v2MAsWJ1tOvhezYewR+PP8fIDSNgybJT8tAlFZMRcBy7oGv9AdZMgZUsUo5q3ID7LP4qSQFWMytOe82+8rFGHktBB2Nl4xoTfyGc/2Ui8VcEovN2Ypl/6yN2D0yEwd0iYrYUXEvEYbJCB6qrx160LdPpeugWCrJTE5WCCcvrHWGVSmmPbJvDrdAXMe2RTmMIkFAAZ2QPxETUxphRh5rNnaBr2XU1wiHS4rcWRQws510ARKWDRGYm2BPrNtYuYjYjzGk7ADJdH3RWlMyg7m+EsmOpF37IExfu1PtPI8WjmEFfK0cG1UFcexB1sXW/TKP8jyyqc87DswYglskwhwvWjCGbq6KdpJXRqXGmUREWM1RxtdZ3Kj0G5Qq7ieQrecQrDMYLsWTqlBai8Ajb7ZESgeo9cFLWhLnj0/ZuvG1h6JR/7WvGTrl2H5Ikb5lo4WjLp/4GulLtEh8OhjGyEbbuO1mjpqqPcr3vEhj+P62PAFXrGtc4Mwzrgl3F6fPT9QJ+C6zs0Ryc6VIp3JlSYjHNxa1SDBRcZM23xRfZQUx5r7kPjAJqmS35dVky8nqpU9Nj1MUwM6XWXOLrySNbJj+ejBIH73p3Lr2xmd2/M7YWsGxvOW0yXTAp/FO/37vbeieupSePMqB5i9TxQ5w3svJP9dXqvKPQF7k/AMg7Kf/+H3YOUXYICAYfR9OdndKjC3Pxkyg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199015)(26005)(186003)(6506007)(53546011)(6512007)(9686003)(83380400001)(6666004)(5660300002)(2906002)(8936002)(33716001)(478600001)(6916009)(66946007)(41300700001)(6486002)(4326008)(66556008)(8676002)(66476007)(316002)(85182001)(86362001)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VUxxNXRXQ1d4blVuUmxsanI4V2pvam5LNnJtNjRudVhVekpUSjczVlhLdVEv?=
 =?utf-8?B?WVRIY0p0dG5OOFd1VXdJNldjdFQ0RFBPNUpLbG5RYTM2eTVETWhxRjYxRitO?=
 =?utf-8?B?cXBESTE0dXVtM1JRd2cyTFpsaHdmbGwveGJrUnZaK1JMTkdTb0RYaVBwdXNr?=
 =?utf-8?B?YnBQdjNjSFBXM1hIQTN6N2JkdWNvRnBYQUp5cWJuTDRHUk9zTkxKMlh1eWhM?=
 =?utf-8?B?bnJOaHY5bi9jNEFWbkhDcW9oeHNGQUh4OTRZblY3K3RUM3d1U0gwTlZvZ3Vl?=
 =?utf-8?B?OGNIMHBTUzFvc0hmSjNLaVVXZ1lORWtMdStvMW9tRnQ1N0lRaXBaQXd4em5S?=
 =?utf-8?B?NDdTSnIvc1dORUN3U3laaitkcXZFWmpHbTk2d1dOZkx5S2M0TGFYRExJbi9y?=
 =?utf-8?B?c09XZzZwMW95VnNpMnZRU09FWlJoKzAzTVg0cWZOQjZiWGVnZ0lYYmZLMHQ2?=
 =?utf-8?B?WFkvZGp4Y3FQanNzbmd3VjMvZU1hOGZuMkJjUTZ4MmZuUlFKME8wRFQ5UU94?=
 =?utf-8?B?eDdqNHRIQlhTVjFKYkU4NURUeGlkRXIyYVJWUXBmREpHWDYvVk9ldHBrT3Bo?=
 =?utf-8?B?a21MdjNFaXNDMWhVcVoxNjVoUitNbkJCZW12b0lXS0dJYXV4SHNDYUVkNW1S?=
 =?utf-8?B?R3JlMXdvN2w5NG5jck5JK0xZdSswZWtTSjVVekRuM1JLZWRVZmV4UGhmcmdD?=
 =?utf-8?B?Um5tNld3a3lTdDZJRDc1am5lcEErYnIweUZVZVByTm9ONTdTcFp6c3cwdXA2?=
 =?utf-8?B?MTRJc2FYa2ZRNUJmd3ZsTk5hSzZRQzdYZm1ORTA0VUdTcUY2QlMwYkpzdStu?=
 =?utf-8?B?VSt0dnM1bXBnWWQwY1RBWWhMMms0TXlqUUlBYVpUQzREbTNNZW1vSFFVNHg4?=
 =?utf-8?B?NTI4VUdIWHBYNU0yVlVNREp4S0NXWDU3Rlp5NENlMXlBQVBaelVYdGh6MnpX?=
 =?utf-8?B?OHVqVFVHNVJNVUlzZTdobW1lUTh5S2E0NVo5eEtwU1ZaN2pkR1ZJWkNvS3Z5?=
 =?utf-8?B?ajAxT3RJTmQ4cU1FTFNmN3A2bXZXL2xKcGcxS1ZhdFloME1lUC9kQ1l2akgz?=
 =?utf-8?B?czVUZlJIRkxNeTR6cjBrclZ2ZWE2NTR6RHh1T0hTVVBBSzllLy9CRXk3YlJl?=
 =?utf-8?B?ZCtXdVZyelAreE0vZkgzdWdqNGlDcVFBYnJGSFRNS2lpdHoyWjV0V1hQZW5S?=
 =?utf-8?B?YlBMenhBUU9FUFlaUXdCOXVVREhlWXRXemVZMENPdVJuZTJUTTJXTjRIajlT?=
 =?utf-8?B?VUZLWHZpb3FTNmVUb2VPbnRCQ1RTRFpMRTdDRWo2UmlPTjF5YzhvUHR5VDh5?=
 =?utf-8?B?Qy80VHpxcTRLNHRPQ20yRVJnVHpscGR5UFlCWWJOeUxmS25JL09XMmszOEZh?=
 =?utf-8?B?WWoyYWQrNVBEdUhvbEg4ejc5SlRJZnhQOHNtS1p4T0tkNjhEYTd0bHl4SGp2?=
 =?utf-8?B?Zy9YaUFzamc5azZMeFNjeHd2R2VXd0lrYzh4WW41b0JvK3VpdTdkSm9KeGVP?=
 =?utf-8?B?UXVHanRHbjg3VWlMM0t5TXBHaGRVS2RkVmcvWmxrcGRQMXJZN1grY2VTYnBz?=
 =?utf-8?B?Nm5PeHI0TzB2Q3JKdlRqb0pFbnpiWk9qRVh1akg5cEd2ZXBZODlNNEJpQXZQ?=
 =?utf-8?B?aHA2Q0xxKzJnRlorbHZTYTgzcTFZVEdRWURaVjJpcTl3ajlmTHFFQ3BycjFK?=
 =?utf-8?B?bm1wbVJNNU14Nmlza2l5ODN3M1E4dWt0dElMenVrK0VCUlVKbFd3U0RwdmdZ?=
 =?utf-8?B?T3JqNXAzcHdjbkQ0bGZrcm5wN05kNmFQVUpvckpZSFR6aTBZSXJObXU3K29F?=
 =?utf-8?B?bEkyZ2sxaUlLS1p4eFZVSm5DYUZNUzlaTnlXZVVyZGJwSmkva2JtdXFuMUQw?=
 =?utf-8?B?ZTY2VEZaU0tLTXhXVFpwVVpUSURhT2hkVXU1UHhTdFlac040dkhwRGxHMGpj?=
 =?utf-8?B?VFR6RkVOMXY2ZGkzQUZoWGRmTEpjT0t6Z1FzdnlHZlhwbnlSVDRVWVBROElq?=
 =?utf-8?B?R1ZDMnR0RzlZb0l2T2c5N1NaWTlMeDFRajZYOThtTzdEdEllWEtZajkvZ0VT?=
 =?utf-8?B?SW5DTDZ1YWdvWGsybXhNZHMyNUJLenZ6TlMwaXNXMko1QS9kc2M3UDI5WDlO?=
 =?utf-8?Q?TC5cDK8Wsjoey3A3fCZzgQSGZ?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1e47be6-70a0-49f6-1d54-08dab751bc73
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:58:14.4035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nhKJ29N34YsbxTJfYnXh9Hzq2s3eNuWIf0ziP3xtCmG/nhhOlwBYm6Uu/5LG3gdPd/+XN1/GjSSAOnxXyMgNrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB5957

On Wed, Oct 26, 2022 at 02:35:44PM +0200, Jan Beulich wrote:
> On 25.10.2022 16:44, Roger Pau Monne wrote:
> > --- a/xen/drivers/vpci/header.c
> > +++ b/xen/drivers/vpci/header.c
> > @@ -121,7 +121,9 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
> >          }
> >  
> >          if ( !rom_only &&
> > -             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
> > +             (bar->type != VPCI_BAR_ROM || header->rom_enabled) &&
> > +             pci_check_bar(pdev, _mfn(PFN_DOWN(bar->addr)),
> > +                           _mfn(PFN_DOWN(bar->addr + bar->size - 1))) )
> >              bar->enabled = map;
> >      }
> 
> What about the ROM handling immediately above from here?

Needs fixing indeed.  I had plans to short circuit the ROM only
mapping path earlier if the BAR wasn't correctly positioned, but
decided it was too complicated and then forgot to adjust the
conditional.

> > @@ -234,9 +236,25 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >  
> >          if ( !MAPPABLE_BAR(bar) ||
> >               (rom_only ? bar->type != VPCI_BAR_ROM
> > -                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
> > +                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ||
> > +             /* Skip BARs already in the requested state. */
> > +             bar->enabled == !!(cmd & PCI_COMMAND_MEMORY) )
> >              continue;
> >  
> > +        /*
> > +         * Only do BAR position checks for the hardware domain, for guests it's
> > +         * assumed that the hardware domain has changed the position of any
> > +         * problematic BARs.
> > +         */
> > +        if ( is_hardware_domain(pdev->domain) &&
> > +             !pci_check_bar(pdev, _mfn(start), _mfn(end)) )
> > +        {
> > +            printk(XENLOG_G_WARNING
> > +                   "%pp: not mapping BAR [%lx, %lx] invalid position\n",
> > +                   &pdev->sbdf, start, end);
> > +            continue;
> > +        }
> 
> I'm not convinced of it being appropriate to skip the check for DomU.
> I'd rather consider this a "fixme", as (perhaps somewhere else) we
> should return an error if a misconfigured device was passed. We cannot
> blindly leave the security of the system to tool stack + Dom0 kernel
> imo.
> 
> And then, if this is Dom0-only, I think it wants to be XENLOG_WARNING,
> i.e. without the G infix.

OK, I don't mind removing the is_hardware_domain() condition, it's
still not clear how we want to handle all this when domU support is
added.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:18:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:18:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430564.682387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongIH-0002YZ-5H; Wed, 26 Oct 2022 13:18:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430564.682387; Wed, 26 Oct 2022 13:18:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongIH-0002YS-2D; Wed, 26 Oct 2022 13:18:05 +0000
Received: by outflank-mailman (input) for mailman id 430564;
 Wed, 26 Oct 2022 13:18:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+8N7=23=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ongIF-0002YM-Ux
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:18:04 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2067.outbound.protection.outlook.com [40.107.20.67])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9df2a416-5530-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 15:18:01 +0200 (CEST)
Received: from AS9PR06CA0083.eurprd06.prod.outlook.com (2603:10a6:20b:464::27)
 by GV2PR08MB9421.eurprd08.prod.outlook.com (2603:10a6:150:dd::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 13:17:58 +0000
Received: from AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:464:cafe::e4) by AS9PR06CA0083.outlook.office365.com
 (2603:10a6:20b:464::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 13:17:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT025.mail.protection.outlook.com (100.127.140.199) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Wed, 26 Oct 2022 13:17:57 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Wed, 26 Oct 2022 13:17:57 +0000
Received: from 7b2fe9640039.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 38E44109-FB3B-4D24-9E53-5EF46F7146E5.1; 
 Wed, 26 Oct 2022 13:17:46 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7b2fe9640039.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 13:17:46 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24)
 by PAWPR08MB9517.eurprd08.prod.outlook.com (2603:10a6:102:2eb::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 13:17:43 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572]) by AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572%4]) with mapi id 15.20.5709.015; Wed, 26 Oct 2022
 13:17:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9df2a416-5530-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=F/jEgtfh7dsxALAxiyDYGSrXDtnDfpoIB2FWP/IT71KLfHTPN9Xkzqvgvp+ztUIR2iyjqaQqyTgmVCbHyGR/h+NxCjGhUTWf2Ko2HM2/UZW1ik0BZ/InBde3vBKa0GRtsEXGJpb618/2nAU5FUAIWg4SCvdd2Qo7gMrY4pKI2DUW0WxhamVEOrRRBvop5pkCbGNMtIHuUFh9didCRHR9nNCSZhYafPzl+u12n+BGc26iZQPdaX5Gksn8k62XintCHItFflNOHalHu1NBG4ZC1XjmVP6fj1H4OkZ+nprVHQyZc4MfO18jSlX1DRO3z0OntbvjIIkL8CG9WgDK5kN16Q==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7L45+M+So87NQD79rx1b/VxFV+qYJWUyiyGYdUS3X/o=;
 b=Em70HyqAuLE1xJj/VDKc2+zJNpdQpPVcYfl6MeZmyteqB66K1p9u4ilidEZGSMo0zQwRyXbymCaZb/t3jwn279oX+Gd8wOn+o8/DBO+MyaFc0oawOJGTgv6YdkJ+HwIQIJ+O/dpgeVdxCSMouCh/GF/qRbYNqUvuEUcDfUCHnZzZ/0NP8U5M25qywYz3rQMp44cDcBRxkm2SZtTw6OjZ5ou+6EufeOYQB2jkK39SXARAOB/pQDtOUAnsyiFZxb4eVv3BLwusmt2x81/YZ9HfJ3ylTccS9y54jJA/kuWC76aR6zdY5/F6UB5A8rCKxg/JJ/G+PENPx04dodVh2Vuyfg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7L45+M+So87NQD79rx1b/VxFV+qYJWUyiyGYdUS3X/o=;
 b=IOz7SXIwr7pgllZisP9izE0Pk+/zckU2Tpng8SGc/1wgvCWbhZMd6Pk1l8rUxTECAZ4t/RbBQuJratYgINt91SQ+Y62nlflyWLghlDqwq3aLbTbqhML8kYDZJ8RqfWIJbhHRMJcUj/Dty0xqkw6MiFRgYNjVH05BcwlpIZ/w4f0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: fd64b4cae576e573
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q8PzA9xPZ5xvBrJSeyNL7NMj6036AclA+87zy80v+7uqZur3efrRfywQb6l9iN+gUGc3WvGsLOAzxFIku6IefOiynQWWraEWX/WkC7CTklWV91uX4TtdwH9fav4exAvniXCkAzWUpJbWaGYOLREnjOaVPUt6zMiQpPjOfKgL1MRY2V2BXADzNmbkO8sJzueVSxT9uWymIy/W0Wr3VWxlIAiAW8UIky9hsdzc67DqlGZfSyjTdO1Ay4szkaPOpu4+3dMdxbKA5gEY+7BIbabZgmeOXjJRkwh35T6nCGVc3lN6mwataLImIZBS9E5OW00kZ6cEOsFqZvSq5Z9dR/ukHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7L45+M+So87NQD79rx1b/VxFV+qYJWUyiyGYdUS3X/o=;
 b=LL+hrEyQYQG8j6BXqi5FxSpuJvvW6et0tk6UMcErtK5CIpzFPVKyBeBkGbFC/QaC9TFCrpZTm1jjDHk+ULLybrmvq+OTk80uDt4BPPniSo15oYTQfJSvwkN3pDYYRAx1hXl+m04lrfa3iOnbHmHOVS381605GrRm2xQCYjKQWiVoQQBbtpiI7aFbaCqncX3dGPlAydGPYGfmac7MnrO1uwyyCFOoUvZNdQndeEvU0jzl7brI1pa+vzbqW1FUdV6c8MfrzLF/CYWPu5iY0d0r8NnKcC53b7wbygFeWKcuAeF1t62PGdsWR+5zBE5BWYyh5HzTjM61ARpYF/H9ltxOTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7L45+M+So87NQD79rx1b/VxFV+qYJWUyiyGYdUS3X/o=;
 b=IOz7SXIwr7pgllZisP9izE0Pk+/zckU2Tpng8SGc/1wgvCWbhZMd6Pk1l8rUxTECAZ4t/RbBQuJratYgINt91SQ+Y62nlflyWLghlDqwq3aLbTbqhML8kYDZJ8RqfWIJbhHRMJcUj/Dty0xqkw6MiFRgYNjVH05BcwlpIZ/w4f0=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Xen developer discussion <xen-devel@lists.xenproject.org>
CC: Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Michal
 Orzel <Michal.Orzel@arm.com>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index: AQHY6T1V+gcJbmRqpEyt0b8GeG9bFg==
Date: Wed, 26 Oct 2022 13:17:43 +0000
Message-ID: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7158:EE_|PAWPR08MB9517:EE_|AM7EUR03FT025:EE_|GV2PR08MB9421:EE_
X-MS-Office365-Filtering-Correlation-Id: 53a033e6-304e-4602-0453-08dab7547fde
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 kTE2MMJ8pjlDVY/VOVyo1PUu6qlHZ+3tQpgCLZwnumHSf3Tt0hxN1Jg2VkWD/lsl/Hw1ow9YQJncHtwmG6bkJBnZW/ayXXpA7eCgLCMcNXzgUa6NnpKVuA/EAnawcYmbYkMb4EXq3GCUBRzvi7KxRNGCAYRen6q67uSlzY3QO9gssBCyorkqoOOaytzMeqy2YMylfVm7HLKdRjLgfJCj5NtVH/QTcgezzlmvzEu11LUBkqS/UtffO3HX/oJoq43Rxp1YlWs+X9zuCv6blZVzF9oeLu99tOdZG7UxszEipdWLAUZXG45haP+pSyGGVXFZavysz+70DtIrkZ2wpNmfwPRFjDcu4dlyvMb8dHBiKlg8Mf/W28QZgSD2qB+CefT9pHYTvQlfYN1m3DjkZrJzXEGhszNkQE1ZT1rTxpRTRzQpKb7kABRnRMW9q2iubtTIKsG9mIWnNbo3IDf8VunkcA6Zb4cpN+061epEhjqdioMAV6mVf2BqLBUZdGykHcfmE0qR+js9p5B5XL5F6FJK++D3fAJ40G+GwEhs7CYxLUx08LmqIO6YDxNQPU3i3NxXrt87K+b9RmapN8F9p4GhkqbDBDJ4+WKuz4d4W1odcbWN/CnEKYiEQ2WhhyBix4WtXZdp2+FZZxnis/+JAduiCrxJCwnm1jsIKWHAq3X/USUNAE2Yl5DtwMlOCKc/fhVkOu2MdiVWAPRi8kjiB8BHzsNlgWZTknTPRjRv82N/uBdSOKeXRM4egBfvvleow7wkPy/wSOZHJ0u6VtrreA+WPomx/2+1QGtsWvRpS+blkZ5cDlvibCtUWFZal1RJ4yFgx5rjj06sijRYIORzTGMxxavQPWUDUW0/sa4tX9nSBlw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(451199015)(478600001)(966005)(86362001)(71200400001)(2906002)(38100700002)(122000001)(36756003)(66556008)(38070700005)(6486002)(2616005)(33656002)(186003)(83380400001)(76116006)(8676002)(91956017)(66946007)(316002)(4326008)(6506007)(66476007)(66446008)(41300700001)(64756008)(5660300002)(54906003)(6916009)(8936002)(6512007)(26005)(7416002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <99F6895D1FE9CE449C220739161C5DA8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9517
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	efa7997b-402d-4647-9860-08dab7547791
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5caKnq/O8xvgRK2yRNp2nyUPdr9KGc4ohzICVR3ZSFnUVYJQbfao8U4HiR/Rl5qzW2OlKyM5flpVG0g0y+lUQWNE5P/BncwaEu8S5fVK6l/3UsIoMWfX25ktwMw26Rkh6PT5TD8fbRK2kdQXIEdmso0n9wPHMcQnFxaoRFoFaq/9S4hho74QVBfk2c2rfGoQEolUKkXkNomA51ooE3RtUlN2zTb2v6wjZirfxNdJFXaV9pWy7FKWsqdBgFhJ2r9Vrn3+KlHO5zzZp3GKb58TV/hRkmo85wwFmd561hi6/6Yp4J3wQ2v1SsgI3h48nGUNeH0XMVXiywJLsZVRXft6RFmXRjN65y65DIpH2fvwS/svesZZxMw0EeuYvieNaX17uzd/RiYmYEoFksJc1uE7MGKSYuScWbSY1HXTZqPzpr5HRKzpni+mb0AWUdqNk4QdWJFmMSMnZ/m1Fq4B2jodE//G7gBOPfy5OzvwDMhdjgO3Ia9NgC+kuniS48mXFTXaBXaedCChfJzGv805Rulmie44LFsNa3FGnVRUrUKdFzsjH4BHGNga95GMRlzOTWswN7d5F2MfIwqrljw1PYFDUGJocd/rUZ7xOfRi747+A2tg4htnWa6gy/C7DFciR7kCU3UXLZSz1sGcUm2RUEupcN7lfeBIjmu1TkFgaJicfpO23h71f6mnFcA5gqfcUTHr8M6/zxNck7dKEEPs/qu9Sn/oLBwzAXMXBVuNfHbnRDs0ps8ctwFolIuH9Oz6NpsXcCn7TzyCQW1uAOJpB1QjgMOuxJnoejDmWP0crghX+noA+mMpBNHApxpc/AqFWmm5uZBe79lmvCxFAY1dkwbobg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199015)(36840700001)(40470700004)(46966006)(107886003)(6506007)(41300700001)(6916009)(82740400003)(36756003)(5660300002)(54906003)(40460700003)(316002)(70586007)(40480700001)(81166007)(966005)(6486002)(356005)(8676002)(8936002)(86362001)(4326008)(478600001)(70206006)(33656002)(26005)(82310400005)(83380400001)(2616005)(6512007)(2906002)(47076005)(36860700001)(336012)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 13:17:57.5957
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 53a033e6-304e-4602-0453-08dab7547fde
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9421

SGkgQWxsLA0KDQpBdCBBcm0sIHdlIHN0YXJ0ZWQgdG8gaW1wbGVtZW50IHRoZSBQT0MgdG8gc3Vw
cG9ydCAyIGxldmVscyBvZiBwYWdlIHRhYmxlcy9uZXN0ZWQgdHJhbnNsYXRpb24gaW4gU01NVXYz
Lg0KVG8gc3VwcG9ydCBuZXN0ZWQgdHJhbnNsYXRpb24gZm9yIGd1ZXN0IE9TIFhlbiBuZWVkcyB0
byBleHBvc2UgdGhlIHZpcnR1YWwgSU9NTVUuIElmIHdlIHBhc3N0aHJvdWdoIHRoZQ0KZGV2aWNl
IHRvIHRoZSBndWVzdCB0aGF0IGlzIGJlaGluZCBhbiBJT01NVSBhbmQgdmlydHVhbCBJT01NVSBp
cyBlbmFibGVkIGZvciB0aGUgZ3Vlc3QgdGhlcmUgaXMgYSBuZWVkIHRvDQphZGQgSU9NTVUgYmlu
ZGluZyBmb3IgdGhlIGRldmljZSBpbiB0aGUgcGFzc3Rocm91Z2ggbm9kZSBhcyBwZXIgWzFdLiBU
aGlzIGVtYWlsIGlzIHRvIGdldCBhbiBhZ3JlZW1lbnQgb24NCmhvdyB0byBhZGQgdGhlIElPTU1V
IGJpbmRpbmcgZm9yIGd1ZXN0IE9TLg0KDQpCZWZvcmUgSSB3aWxsIGV4cGxhaW4gaG93IHRvIGFk
ZCB0aGUgSU9NTVUgYmluZGluZyBsZXQgbWUgZ2l2ZSBhIGJyaWVmIG92ZXJ2aWV3IG9mIGhvdyB3
ZSB3aWxsIGFkZCBzdXBwb3J0IGZvciB2aXJ0dWFsDQpJT01NVSBvbiBBcm0uIEluIG9yZGVyIHRv
IGltcGxlbWVudCB2aXJ0dWFsIElPTU1VIFhlbiBuZWVkIFNNTVV2MyBOZXN0ZWQgdHJhbnNsYXRp
b24gc3VwcG9ydC4gU01NVXYzIGhhcmR3YXJlDQpzdXBwb3J0cyB0d28gc3RhZ2VzIG9mIHRyYW5z
bGF0aW9uLiBFYWNoIHN0YWdlIG9mIHRyYW5zbGF0aW9uIGNhbiBiZSBpbmRlcGVuZGVudGx5IGVu
YWJsZWQuIEFuIGluY29taW5nIGFkZHJlc3MgaXMgbG9naWNhbGx5DQp0cmFuc2xhdGVkIGZyb20g
VkEgdG8gSVBBIGluIHN0YWdlIDEsIHRoZW4gdGhlIElQQSBpcyBpbnB1dCB0byBzdGFnZSAyIHdo
aWNoIHRyYW5zbGF0ZXMgdGhlIElQQSB0byB0aGUgb3V0cHV0IFBBLiBTdGFnZSAxIGlzDQppbnRl
bmRlZCB0byBiZSB1c2VkIGJ5IGEgc29mdHdhcmUgZW50aXR5KCBHdWVzdCBPUykgdG8gcHJvdmlk
ZSBpc29sYXRpb24gb3IgdHJhbnNsYXRpb24gdG8gYnVmZmVycyB3aXRoaW4gdGhlIGVudGl0eSwg
Zm9yIGV4YW1wbGUsDQpETUEgaXNvbGF0aW9uIHdpdGhpbiBhbiBPUy4gU3RhZ2UgMiBpcyBpbnRl
bmRlZCB0byBiZSBhdmFpbGFibGUgaW4gc3lzdGVtcyBzdXBwb3J0aW5nIHRoZSBWaXJ0dWFsaXph
dGlvbiBFeHRlbnNpb25zIGFuZCBpcw0KaW50ZW5kZWQgdG8gdmlydHVhbGl6ZSBkZXZpY2UgRE1B
IHRvIGd1ZXN0IFZNIGFkZHJlc3Mgc3BhY2VzLiBXaGVuIGJvdGggc3RhZ2UgMSBhbmQgc3RhZ2Ug
MiBhcmUgZW5hYmxlZCwgdGhlIHRyYW5zbGF0aW9uDQpjb25maWd1cmF0aW9uIGlzIGNhbGxlZCBu
ZXN0aW5nLg0KDQpTdGFnZSAxIHRyYW5zbGF0aW9uIHN1cHBvcnQgaXMgcmVxdWlyZWQgdG8gcHJv
dmlkZSBpc29sYXRpb24gYmV0d2VlbiBkaWZmZXJlbnQgZGV2aWNlcyB3aXRoaW4gdGhlIGd1ZXN0
IE9TLiBYRU4gYWxyZWFkeSBzdXBwb3J0cw0KU3RhZ2UgMiB0cmFuc2xhdGlvbiBidXQgdGhlcmUg
aXMgbm8gc3VwcG9ydCBmb3IgU3RhZ2UgMSB0cmFuc2xhdGlvbiBmb3IgZ3Vlc3RzLiBXZSB3aWxs
IGFkZCBzdXBwb3J0IGZvciBndWVzdHMgdG8gY29uZmlndXJlDQp0aGUgU3RhZ2UgMSB0cmFuc2l0
aW9uIHZpYSB2aXJ0dWFsIElPTU1VLiBYRU4gd2lsbCBlbXVsYXRlIHRoZSBTTU1VIGhhcmR3YXJl
IGFuZCBleHBvc2VzIHRoZSB2aXJ0dWFsIFNNTVUgdG8gdGhlIGd1ZXN0Lg0KR3Vlc3QgY2FuIHVz
ZSB0aGUgbmF0aXZlIFNNTVUgZHJpdmVyIHRvIGNvbmZpZ3VyZSB0aGUgc3RhZ2UgMSB0cmFuc2xh
dGlvbi4gV2hlbiB0aGUgZ3Vlc3QgY29uZmlndXJlcyB0aGUgU01NVSBmb3IgU3RhZ2UgMSwNClhF
TiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBhbmQgY29uZmlndXJlIHRoZSBoYXJkd2FyZSBhY2NvcmRp
bmdseS4NCg0KTm93IGJhY2sgdG8gdGhlIHF1ZXN0aW9uIG9mIGhvdyB3ZSBjYW4gYWRkIHRoZSBJ
T01NVSBiaW5kaW5nIGJldHdlZW4gdGhlIHZpcnR1YWwgSU9NTVUgYW5kIHRoZSBtYXN0ZXIgZGV2
aWNlcyBzbyB0aGF0DQpndWVzdHMgY2FuIGNvbmZpZ3VyZSB0aGUgSU9NTVUgY29ycmVjdGx5LiBU
aGUgc29sdXRpb24gdGhhdCBJIGFtIHN1Z2dlc3RpbmcgaXMgYXMgYmVsb3c6DQoNCkZvciBkb20w
LCB3aGlsZSBoYW5kbGluZyB0aGUgRFQgbm9kZShoYW5kbGVfbm9kZSgpKSBYZW4gd2lsbCByZXBs
YWNlIHRoZSBwaGFuZGxlIGluIHRoZSAiaW9tbXVzIiBwcm9wZXJ0eSB3aXRoIHRoZSB2aXJ0dWFs
DQpJT01NVSBub2RlIHBoYW5kbGUuDQoNCkZvciBkb21VIGd1ZXN0cywgd2hlbiBwYXNzdGhyb3Vn
aCB0aGUgZGV2aWNlIHRvIHRoZSBndWVzdCBhcyBwZXIgWzJdLCAgYWRkIHRoZSBiZWxvdyBwcm9w
ZXJ0eSBpbiB0aGUgcGFydGlhbCBkZXZpY2UgdHJlZQ0Kbm9kZSB0aGF0IGlzIHJlcXVpcmVkIHRv
IGRlc2NyaWJlIHRoZSBnZW5lcmljIGRldmljZSB0cmVlIGJpbmRpbmcgZm9yIElPTU1VcyBhbmQg
dGhlaXIgbWFzdGVyKHMpDQoNCiJpb21tdXMgPSA8ICZtYWdpY19waGFuZGxlIDB4dk1hc3RlcklE
PiAgDQoJ4oCiIG1hZ2ljX3BoYW5kbGUgd2lsbCBiZSB0aGUgcGhhbmRsZSAoIHZJT01NVSBwaGFu
ZGxlIGluIHhsKSAgdGhhdCB3aWxsIGJlIGRvY3VtZW50ZWQgc28gdGhhdCB0aGUgdXNlciBjYW4g
c2V0IHRoYXQgaW4gcGFydGlhbCBEVCBub2RlICgweGZkZWEpLiAgDQoJ4oCiIHZNYXN0ZXJJRCB3
aWxsIGJlIHRoZSB2aXJ0dWFsIG1hc3RlciBJRCB0aGF0IHRoZSB1c2VyIHdpbGwgcHJvdmlkZS4N
Cg0KVGhlIHBhcnRpYWwgZGV2aWNlIHRyZWUgd2lsbCBsb29rIGxpa2UgdGhpczoNCi9kdHMtdjEv
Ow0KIA0KLyB7DQogICAgLyogIypjZWxscyBhcmUgaGVyZSB0byBrZWVwIERUQyBoYXBweSAqLw0K
ICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Ow0KICAgICNzaXplLWNlbGxzID0gPDI+Ow0KIA0KICAg
IGFsaWFzZXMgew0KICAgICAgICBuZXQgPSAmbWFjMDsNCiAgICB9Ow0KIA0KICAgIHBhc3N0aHJv
dWdoIHsNCiAgICAgICAgY29tcGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsNCiAgICAgICAgcmFuZ2Vz
Ow0KICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCiAgICAgICAgI3NpemUtY2VsbHMgPSA8
Mj47DQogICAgICAgIG1hYzA6IGV0aGVybmV0QDEwMDAwMDAwIHsNCiAgICAgICAgICAgIGNvbXBh
dGlibGUgPSAiY2FseGVkYSxoYi14Z21hYyI7DQogICAgICAgICAgICByZWcgPSA8MCAweDEwMDAw
MDAwIDAgMHgxMDAwPjsNCiAgICAgICAgICAgIGludGVycnVwdHMgPSA8MCA4MCA0ICAwIDgxIDQg
IDAgODIgND47DQogICAgICAgICAgIGlvbW11cyA9IDwweGZkZWEgMHgwMT47DQogICAgICAgIH07
DQogICAgfTsNCn07DQogDQpJbiB4bC5jZmcgd2UgbmVlZCB0byBkZWZpbmUgYSBuZXcgb3B0aW9u
IHRvIGluZm9ybSBYZW4gYWJvdXQgdk1hc3RlcklkIHRvIHBNYXN0ZXJJZCBtYXBwaW5nIGFuZCB0
byB3aGljaCBJT01NVSBkZXZpY2UgdGhpcw0KdGhlIG1hc3RlciBkZXZpY2UgaXMgY29ubmVjdGVk
IHNvIHRoYXQgWGVuIGNhbiBjb25maWd1cmUgdGhlIHJpZ2h0IElPTU1VLiBUaGlzIGlzIHJlcXVp
cmVkIGlmIHRoZSBzeXN0ZW0gaGFzIGRldmljZXMgdGhhdCBoYXZlDQp0aGUgc2FtZSBtYXN0ZXIg
SUQgYnV0IGJlaGluZCBhIGRpZmZlcmVudCBJT01NVS4NCiANCmlvbW11X2RldmlkX21hcCA9IFsg
4oCcUE1BU1RFUl9JRFtAVk1BU1RFUl9JRF0sSU9NTVVfQkFTRV9BRERSRVNT4oCdICwg4oCcUE1B
U1RFUl9JRFtAVk1BU1RFUl9JRF0sSU9NTVVfQkFTRV9BRERSRVNT4oCdXQ0KDQoJ4oCiIFBNQVNU
RVJfSUQgaXMgdGhlIHBoeXNpY2FsIG1hc3RlciBJRCBvZiB0aGUgZGV2aWNlIGZyb20gdGhlIHBo
eXNpY2FsIERULg0KCeKAoiBWTUFTVEVSX0lEIGlzIHRoZSB2aXJ0dWFsIG1hc3RlciBJZCB0aGF0
IHRoZSB1c2VyIHdpbGwgY29uZmlndXJlIGluIHRoZSBwYXJ0aWFsIGRldmljZSB0cmVlLg0KCeKA
oiBJT01NVV9CQVNFX0FERFJFU1MgaXMgdGhlIGJhc2UgYWRkcmVzcyBvZiB0aGUgcGh5c2ljYWwg
SU9NTVUgZGV2aWNlIHRvIHdoaWNoIHRoaXMgZGV2aWNlIGlzIGNvbm5lY3RlZC4gDQogDQpFeGFt
cGxlOiBMZXQncyBzYXkgdGhlIHVzZXIgd2FudHMgdG8gYXNzaWduIHRoZSBiZWxvdyBwaHlzaWNh
bCBkZXZpY2UgaW4gRFQgdG8gdGhlIGd1ZXN0Lg0KIA0KaW9tbXVANGYwMDAwMDAgew0KICAgICAg
ICAgICAgICAgIGNvbXBhdGlibGUgPSAiYXJtLHNtbXUtdjMiOw0KICAgICAgICAgICAgIAlpbnRl
cnJ1cHRzID0gPDB4MDAgMHhlNCAweGYwND47DQogICAgICAgICAgICAgICAgaW50ZXJydXB0LXBh
cmVudCA9IDwweDAxPjsNCiAgICAgICAgICAgICAgICAjaW9tbXUtY2VsbHMgPSA8MHgwMT47DQog
ICAgICAgICAgICAgICAgaW50ZXJydXB0LW5hbWVzID0gImNvbWJpbmVkIjsNCiAgICAgICAgICAg
ICAgICByZWcgPSA8MHgwMCAweDRmMDAwMDAwIDB4MDAgMHg0MDAwMD47DQogICAgICAgICAgICAg
ICAgcGhhbmRsZSA9IDwweGZkZWI+Ow0KICAgICAgICAgICAgICAgIG5hbWUgPSAiaW9tbXUiOw0K
fTsNCiANCnRlc3RAMTAwMDAwMDAgew0KCWNvbXBhdGlibGUgPSAidmlvbW11LXRlc3TigJ07DQoJ
aW9tbXVzID0gPDB4ZmRlYiAweDEwPjsNCglpbnRlcnJ1cHRzID0gPDB4MDAgMHhmZiAweDA0PjsN
CglyZWcgPSA8MHgwMCAweDEwMDAwMDAwIDB4MDAgMHgxMDAwPjsNCgluYW1lID0gInZpb21tdS10
ZXN0IjsNCn07DQogDQpUaGUgcGFydGlhbCBEZXZpY2UgdHJlZSBub2RlIHdpbGwgYmUgbGlrZSB0
aGlzOg0KIA0KLyB7DQogICAgLyogIypjZWxscyBhcmUgaGVyZSB0byBrZWVwIERUQyBoYXBweSAq
Lw0KICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Ow0KICAgICNzaXplLWNlbGxzID0gPDI+Ow0KIA0K
ICAgIHBhc3N0aHJvdWdoIHsNCiAgICAgICAgY29tcGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsNCiAg
ICAgICAgcmFuZ2VzOw0KICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCiAgICAgICAgI3Np
emUtY2VsbHMgPSA8Mj47DQoNCgl0ZXN0QDEwMDAwMDAwIHsNCiAgICAgICAgICAgIAljb21wYXRp
YmxlID0gInZpb21tdS10ZXN0IjsNCiAgICAgICAgICAgIAlyZWcgPSA8MCAweDEwMDAwMDAwIDAg
MHgxMDAwPjsNCiAgICAgICAgICAgIAlpbnRlcnJ1cHRzID0gPDAgODAgNCAgMCA4MSA0ICAwIDgy
IDQ+Ow0KICAgICAgICAgICAgCWlvbW11cyA9IDwweGZkZWEgMHgwMT47DQogICAgICAgIH07DQog
ICAgfTsNCn07DQogDQogaW9tbXVfZGV2aWRfbWFwID0gWyDigJwweDEwQDB4MDEsMHg0ZjAwMDAw
MOKAnV0NCgnigKIgMHgxMCBpcyB0aGUgcmVhbCBwaHlzaWNhbCBtYXN0ZXIgaWQgZnJvbSB0aGUg
cGh5c2ljYWwgRFQuDQoJ4oCiIDB4MDEgaXMgdGhlIHZpcnR1YWwgbWFzdGVyIElkIHRoYXQgdGhl
IHVzZXIgZGVmaW5lcyBhcyBhIHBhcnRpYWwgZGV2aWNlIHRyZWUuDQoJ4oCiIDB4NGYwMDAwMDAg
aXMgdGhlIGJhc2UgYWRkcmVzcyBvZiB0aGUgSU9NTVUgZGV2aWNlLg0KDQpbMV0gaHR0cHM6Ly93
d3cua2VybmVsLm9yZy9kb2MvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2lvbW11
L2lvbW11LnR4dA0KWzJdIGh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2RvY3MvdW5zdGFibGUvbWlz
Yy9hcm0vcGFzc3Rocm91Z2gudHh0DQoNClJlZ2FyZHMsDQpSYWh1bA0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:19:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:19:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430569.682399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongJo-0003AL-Mb; Wed, 26 Oct 2022 13:19:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430569.682399; Wed, 26 Oct 2022 13:19:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongJo-0003AE-J3; Wed, 26 Oct 2022 13:19:40 +0000
Received: by outflank-mailman (input) for mailman id 430569;
 Wed, 26 Oct 2022 13:19:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=NsSF=23=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ongJn-0003A6-4l
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:19:39 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d74e81bd-5530-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 15:19:38 +0200 (CEST)
Received: from AM6P194CA0003.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::16)
 by GV2PR08MB8097.eurprd08.prod.outlook.com (2603:10a6:150:75::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 13:19:36 +0000
Received: from AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::43) by AM6P194CA0003.outlook.office365.com
 (2603:10a6:209:90::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 13:19:36 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT063.mail.protection.outlook.com (100.127.140.221) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.19 via Frontend Transport; Wed, 26 Oct 2022 13:19:35 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Wed, 26 Oct 2022 13:19:35 +0000
Received: from 99d6ba52dd76.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C5A269FC-7F99-494E-A486-483F347C88FE.1; 
 Wed, 26 Oct 2022 13:19:30 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 99d6ba52dd76.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 13:19:30 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS8PR08MB9576.eurprd08.prod.outlook.com (2603:10a6:20b:618::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 13:19:28 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Wed, 26 Oct 2022
 13:19:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d74e81bd-5530-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=KyPDHnG2XTxgm9LmIwgKDd4EZMlzMkcHOKcRPLLzhsgug4cK6dY9JU33M/FQgFcrQmQTEUCwQiowwvQZqsEeDBbi4QbcKxJmAVgnQDDCpwzKvkuWeinoYg4LOIj7Q1lgb9/fUNH2jYJgY0ksvaGO9g4mMpvkDAqg8b3ClvJS/AerdQFUQwo/gZrylw2pk7V+SOG+5nhBqn/HsfmhL0B3VwOPWA5Myrf/iew/uSqNJheWPyCD+br5ySENWCsF2G0Jd+dr2cDs0SIimMvyaj5pvOGcBLCCljeXn2/r8xEvJwlHpOYkUf/zqJGwxhOTgPEHgdcFUZMieaGTeKiqbaoZbw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Bkdz2A3+vNZL4pCvhzmxXAnEZ8XmE6nmD0GMQHtou4=;
 b=Qwq12b7mDNP+uzIInSGiaVpO9oesQb4AKx9FkseSaNmn0UqfB0rueiprEqJhHA9ZcyU4kuhsxkEdZl0bQxqvQG+sEf7SBnC+IGbNfdt0OfMrrlnRBZoiFiHnkXrcSmkt+P3E1s062jN4IsxoDAuJ9oXLaSu0UumOAL1ys95mEzXqYPgen15ZyGMSHQD6BG6AHiaae/RGbTWLUScTvy5T46ySbeQ48Nl2e6Bsd4z0TXLH4UYyOzAuBwruMZ3K/Yg4fJz5vADMM7RYmHw1JLn6c9ZWLj4SKp/fxNHjo4NueraWD/nWBMYQ3A3jVBIsaV/YpaMawY1ZDrs+K1qkhnpwxQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Bkdz2A3+vNZL4pCvhzmxXAnEZ8XmE6nmD0GMQHtou4=;
 b=Vutua8+Bbrfa6XUG1z5fkCG5qtKgWJbiEkpj8f2+UpCG/cydOcfu2L7PUiwev3IWcRlcjnf2/zTO3lXkk8DZ3qU7YSlKKWiHPg7UB7kiKuoE3G6Awm/CWW00fru0yr2pA2HWbw0IBhlKswE60+HdLm0Nsomb2G1HNPiT5/3k3aw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IMz9vg1gN37HLt165V4oJxvvoRkRJ0za8WIUhNW5EwqSWqk0GdkSN9PYQ0kTP+DCRvu3LyU2vJCbc8tsLn7Cb9+OfyYZlsJ8T/uHN0rzIGqaXwMUu5NtU978lr2bElgyV7CWV67Vd+Y6oyxLb6SmS1/Zxq3dqv6Z79ZxHJ/TkgduDKnKGN2Ma7F1X/U+mkcau4PSZZSRqekV5VRXKX0M6BhjZNQ7kMWGhhv53IDIMRIo0MAjj0MOJrlKRs3QyHBWYF2l/AYigy0NK0U2U2/q37sJiDWZGFpsSAgMRzf6NbnfOMAIxjh+G8o4BU281cPSJuWdD0muFlzWGMX3TBJ5Mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Bkdz2A3+vNZL4pCvhzmxXAnEZ8XmE6nmD0GMQHtou4=;
 b=OGSD0Db7BVAdz2KwjJsyGxhU+7wGgWL7va6gtaqWqqLPD6es+7QJC+ZL0DSz/LzDfuLdOftEFrf9L746vkEPd4pCgQYEnrnWRPZRSBBYPiSS0POQTaBU6kBrc83T1ioivDtHtyRAXbRNIYCjgDcMSBX8iz0CThbnpyyRhzQlJM8CU84EoIhGCSzFNKSZqT/66d5POlu8R5ZSlnNfxYArEwRQcB8NN2CQpkTEur5m3rxH6bgVqe27MK7C0dOnGgl2/lfRjXRf8HMz+2jEbZHlE+1mC2ZLtJYfTpQwcUxLlXY1EPE43mmWkuDfc3RE4YKgZG0iki1zs9gJB5fNZDCXTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Bkdz2A3+vNZL4pCvhzmxXAnEZ8XmE6nmD0GMQHtou4=;
 b=Vutua8+Bbrfa6XUG1z5fkCG5qtKgWJbiEkpj8f2+UpCG/cydOcfu2L7PUiwev3IWcRlcjnf2/zTO3lXkk8DZ3qU7YSlKKWiHPg7UB7kiKuoE3G6Awm/CWW00fru0yr2pA2HWbw0IBhlKswE60+HdLm0Nsomb2G1HNPiT5/3k3aw=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: George Dunlap <George.Dunlap@eu.citrix.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Julien Grall
	<julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH] CI: Drop more TravisCI remnants
Thread-Topic: [PATCH] CI: Drop more TravisCI remnants
Thread-Index: AQHY6TgHyoZDlKglYE6vttngtkx/xK4goB+AgAAIgcA=
Date: Wed, 26 Oct 2022 13:19:28 +0000
Message-ID:
 <AS8PR08MB7991C8776EA4459F8CFF6E5092309@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221026123906.10421-1-andrew.cooper3@citrix.com>
 <141dd739-153c-6d72-d1cd-3dce579b7e7b@suse.com>
In-Reply-To: <141dd739-153c-6d72-d1cd-3dce579b7e7b@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 656DE45D66A2574EA1F8A5E7ABD22776.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS8PR08MB9576:EE_|AM7EUR03FT063:EE_|GV2PR08MB8097:EE_
X-MS-Office365-Filtering-Correlation-Id: a913db23-652e-463c-81bb-08dab754ba60
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 7CdHlpdgo+5VinmHOXnQIJQ3DSgWMG6vMv7EHHxfPxVa1KblszAcBu/DhzgNcq+Wek7CZm/9DzUudxuTuvrJYoS9UIyEIrDIDvy4TuhHugrJC0gfka5zs8GNfz9Fu/Bs5Di94rXZmLkf9TRqGolJaah/fc4KsxEqc9r9sQaUznQs8UZEcD8lN2S7+S0KFEpB86IigQhes3o1c5S0DJXjlopLooY6QLilwCE/NJziBgGw22VkYRMVsbafeUbQfpAYzyGnE4+nR4Rj+yMnuIxJphXSfawX+4IjZrmwZm28aT+K9ms86qRdaq7J0l4rYGk/7T9GJoIDV8fbykB8XWxqYqRPhO/6/iORX9RWRuzFDDY7EQy0gFIyJ2ZAwHtOUEeTJlJ4bfA0Tukf1X6sfIIq81m+SygCzbKKqjMdKbeLBBIjLLIDASKzhOl98XiYC40g/+frFeRlnQX/xenJpltSDjKILNFwiy6lW80PA8+6MVVVK8i2zQRqgEoJeN1XPPMqtEpvGx7E1gNtnrrz/iWZgJMpy8jZVJ8fqX3iePB+ElBozSOOP+qFSpNm4saueT3FzGD6FDvcfSDis35K/95Hi1XmD1vsVckW2BCQxEXadplu7zE9Icd7T+sp0b05TJYQODsV2SUSfJvFsPCjYs2R0ksNqQjZb/qwaDZI3Fxn2FeMcUBIlwV++vsua8jVw38Ht5VabEzPca0Op47jKmkMSTXwCZVle5BOn6HFVJQ+LYtrUY9fblvCd5TOwBQ6ykusrmGu2hBCnlzPqHs4F+2/LA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(66556008)(55016003)(66446008)(66946007)(110136005)(38070700005)(2906002)(8936002)(52536014)(478600001)(33656002)(64756008)(4326008)(8676002)(41300700001)(54906003)(71200400001)(5660300002)(66476007)(76116006)(186003)(9686003)(86362001)(4744005)(316002)(38100700002)(6506007)(122000001)(53546011)(7696005)(26005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9576
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	db980041-1756-424e-05b0-08dab754b5ec
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WMB9q5BP4x34vHnRpIcBpD/7+pv6QIw5iOdBL/uXqq+Iv2z3JaR2ncUHJrWl8X/rJI7K0qInjTL8X9UIiBoZB2XVVc8mUx3/cnxXtsz3dlz8vKSu8PzYuFFhH24vKBFVKFX7knOoH2Qzvut8X4IyYurAkMP22zDjA69kCuIZLudIR3NyN9/Qe428S38pO4nYzVisQeRb+vRvft+0sijGC1biyOr8n+C3bhrFjSOsYpJ+KxhYZk+NyzRuDCl2ir5OlSAaxXk89yUqBD8GpgO1Ro3w40xuJtGU65oWwOhE7XhejUyPPLiVxhMLZsLGe/gtrjalYOS7GxYiw0Oq0Ghk0wFOzu3EUipHRc7c8CLKaURfVEUN3bYK4wDvC+nYTxw98TFJ3L9REiWvM3mLonkh0+2jkGFXubL58wZKpLiDZXSvrrF3FYA2OwqaoXUwwBqPB+rVUTcwHt5gyulPOI/X4htYw+xnqcYBD5fODV+rplrfWsM8ZzKaZtuBekoPRlHXHTjrRO6ebOo0c+0QjZOvoq2IkR6yUj4/C49YL14hJZ8MRaxqNmhf3IR5rQ0KXLMDcr9OTk+l6tOFSBF0YkunXaOoPaoLJsQ5c8sycSGbub6pVyN2lXsDZFfybpoaEpa4aWqdMfW5M3CPQCvp+uXHTwD6+RLApp0BQlG0IIwB5bRcRGmV9c6Pn1F8zT+3wrXV1m9QtCnGKo03+cB8JWLOG8BFQpkmbry0wzh5XnE4PhbWg/uI6I1Z6jq0mNiEvvOeepzNZPbST5hcrEMU/l6myw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(478600001)(86362001)(40460700003)(47076005)(40480700001)(55016003)(9686003)(36860700001)(82740400003)(7696005)(33656002)(186003)(336012)(356005)(81166007)(4326008)(8676002)(53546011)(70206006)(82310400005)(316002)(2906002)(6506007)(52536014)(41300700001)(26005)(4744005)(70586007)(54906003)(5660300002)(8936002)(110136005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 13:19:35.7900
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a913db23-652e-463c-81bb-08dab754ba60
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8097

SGkNCg0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBDSTogRHJvcCBtb3JlIFRyYXZpc0NJIHJlbW5h
bnRzDQo+IA0KPiBPbiAyNi4xMC4yMDIyIDE0OjM5LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPiA+
IFRoaXMgd2FzIG1pc3NlZCBmcm9tIHByZXZpb3VzIGF0dGVtcHRzIHRvIHJlbW92ZSBUcmF2aXMu
DQo+ID4NCj4gPiBGaXhlczogZTBkYzliMDk1ZTdjICgiQ0k6IERyb3AgVHJhdmlzQ0kiKQ0KPiA+
IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+
DQo+IA0KPiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZWxl
YXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVn
YXJkcywNCkhlbnJ5DQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:22:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430573.682410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongMV-0004aL-4S; Wed, 26 Oct 2022 13:22:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430573.682410; Wed, 26 Oct 2022 13:22:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongMV-0004aE-0h; Wed, 26 Oct 2022 13:22:27 +0000
Received: by outflank-mailman (input) for mailman id 430573;
 Wed, 26 Oct 2022 13:22:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hd2z=23=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1ongMU-0004a6-EF
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:22:26 +0000
Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com
 [2a00:1450:4864:20::631])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b19b9ea-5531-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 15:22:25 +0200 (CEST)
Received: by mail-ej1-x631.google.com with SMTP id kt23so15616521ejc.7
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 06:22:25 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b19b9ea-5531-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=mCcgfz/wvaZSqkoybq4ATyzXHlmrWG7ukWyi1Cbw+SU=;
        b=QKXiu8hnT1x/yaKzMdSFb6e61S4VVO8sPQGbiwI7n1byV0Ni1YNOvFe/Vyw320DVHG
         SHVI76NjqRb288Gs7Qf/niQtDrNVYPQwq9uit4lyk8X0J86Ah6PJq1XIDuCfTM+pICCm
         RT84k3iAzaNH9HPYAci+x/+PQxsLS0AF4Dzq4BTfDdma2a82LnaEkZMBJcUjuwuhF6qQ
         XV6Lroc1AFNLFq4jm/cU5DsM+pWFf8k8xG3H9UyP36uEM2Px+pjx7GNeskc3+YDRMbGL
         Vj5jhMFVT0Re1R1xGa/OqwjPXML5XZ/5/iko6vocli8F7xFUhmOr5mEsF8Tj7L9I0zbm
         C7jQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=mCcgfz/wvaZSqkoybq4ATyzXHlmrWG7ukWyi1Cbw+SU=;
        b=SZVvmQ7/dgVAjUJO9OHnKieA5vHpvX7hNGjDkk4aQ4aW7fkSa6Sz2GXwEz4ZjPuRQG
         asKSUgw+Mt9UviLz4NLMjFpu84mqLXzKq8mty7wY0biG2Ny3N5eZu36ZcXro/bvKq/87
         /Zm1FeOkOIO19owMTgTbsoGQ3kix7/Rm7OZ9DOS8b2M5LjgcN60bQB38HS/5ZIQqNEAU
         1eabIRSqulXpxFCgpJGRuEpVLqIUqfELX+/xekIIvQg6Fwyak/rGp37IpISyVb1uyiXO
         1uqWdnj8vPvaUa9I7lVhQOfl0teGytftVag8cLn0l13rL+KGuVEaAK5KGVQn3ZdQHh39
         V/0Q==
X-Gm-Message-State: ACrzQf3ZwYS9w/GXdRwHkp98HogKgn/v7idObK2QoZlhpyrhW1bViU/R
	GrpU36wsvNzjAcycwfJVbeV9YbzJNEq/07n69hA=
X-Google-Smtp-Source: AMsMyM70YohUVmLpqHjt8uCDGyfHv1uPm4Ssf+QX6Rsr6adF0va406IcJLNYhJ8UN9dUmw5CXze8g9ix27XwksYws+w=
X-Received: by 2002:a17:906:30c8:b0:73c:81a9:f8e1 with SMTP id
 b8-20020a17090630c800b0073c81a9f8e1mr37428980ejb.649.1666790544802; Wed, 26
 Oct 2022 06:22:24 -0700 (PDT)
MIME-Version: 1.0
References: <20221026102018.4144-1-andrew.cooper3@citrix.com> <20221026102018.4144-4-andrew.cooper3@citrix.com>
In-Reply-To: <20221026102018.4144-4-andrew.cooper3@citrix.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Wed, 26 Oct 2022 09:22:13 -0400
Message-ID: <CAKf6xptnDHePBLxE06bBUEkrgetg5-0X1TFFSDyJqPv4TCvA4A@mail.gmail.com>
Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m
 mempool hypercalls
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Xen Security Team <security@xen.org>, 
	Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Henry Wang <Henry.Wang@arm.com>, Anthony PERARD <anthony.perard@citrix.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 26, 2022 at 6:21 AM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> This reverts most of commit cf2a68d2ffbc3ce95e01449d46180bddb10d24a0, and bits
> of cbea5a1149ca7fd4b7cdbfa3ec2e4f109b601ff7.
>
> First of all, with ARM borrowing x86's implementation, the logic to set the
> pool size should have been common, not duplicated.  Introduce
> libxl__domain_set_p2m_pool_size() as a shared implementation, and use it from
> the ARM and x86 paths.  It is left as an exercise to the reader to judge how
> libxl/xl can reasonably function without the ability to query the pool size...
>
> Remove ARM's p2m_domctl() infrastructure now the functioanlity has been
> replaced with a working and unit tested interface.
>
> This is part of XSA-409 / CVE-2022-33747.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---

> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index 2abaab439c4f..f93b221f1c1f 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t domid,
>      return rc;
>  }
>
> +int libxl__domain_set_p2m_pool_size(
> +    libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid)
> +{
> +    libxl_ctx *ctx = libxl__gc_owner(gc);
> +    uint64_t shadow_mem;
> +
> +    shadow_mem = d_config->b_info.shadow_memkb;
> +    shadow_mem <<= 10;
> +
> +    int r = xc_get_p2m_mempool_size(ctx->xch, domid, &shadow_mem);

Should this be xc_*set*_p2m_mempool_size?

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:26:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:26:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430577.682420 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongPv-0005KE-JT; Wed, 26 Oct 2022 13:25:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430577.682420; Wed, 26 Oct 2022 13:25:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongPv-0005K7-Gi; Wed, 26 Oct 2022 13:25:59 +0000
Received: by outflank-mailman (input) for mailman id 430577;
 Wed, 26 Oct 2022 13:25:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ongPu-0005K1-IL
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:25:58 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8448d3b-5531-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 15:25:57 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 09:25:48 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by DS7PR03MB5400.namprd03.prod.outlook.com (2603:10b6:5:2cc::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 13:25:46 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 13:25:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8448d3b-5531-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666790756;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=WdoIs1DXYrpf4zH5vaIUGbKvXgnwjwiqcS39NP5sWT8=;
  b=HjkItfbULUPlzSB+rcZeHzy1iPPd836U2aIR9a60ugx/Y4G8q0FWcOhw
   HexhmI72mwrZrsFAB+4fVXu3/7eVi4mVqqpWSDN0o1fENz02N34Z57QyU
   BzxQMH7/BNKTH+3musmi9Jcb8VzCvNmrr0sXVDXdYp59ueNANSdivGzTC
   g=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 86073483
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:viyn66gGVOfnxoHqaeaoadyGX1613hEKZh0ujC45NGQN5FlHY01je
 htvDD+BbvqLYDOnKIoiYI+w9EgHuZPVnYAwTlFl+yE8Ensb9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult
 Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmP64T5TcyqlFOZH4hDfDpR5fHatE88t6SH
 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo
 Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUJ00
 OAbFyJdVBHd3c+w3ZO7cdFh2Nt2eaEHPKtH0p1h5RfwKK9/BLrlE+DN79Ie2yosjMdTG/qYf
 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVIhuFTuGIO9ltiibMNZhEuH4
 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurBtpNT+HorZaGhnXJmjA6T0JJDmCVhqC+o3CjBYsFF
 R09r39GQa8asRbDosPGdx+xpnKerwMfc9VVGuw+rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVqG+7yJtzKuKAAFIGlEYjULJSMnydT+pIA4jjrUU81uVqWyi7XdBjXY0
 z2M6i8kiN07ltUX3q+2+VTGhTOEpZXTSAMxoALNUQqN7B59ZYOjT5yl7x7c9/koBLieSl6Nr
 X0Vgf+05eoFDYyOvCGVSeBLF7asj96PPSfAm1dpE98k/i605n+4VYlK5Xd1I0IBGuYJfyX4J
 nDavwx57YVWenCtaMdKj5mZDs0rye3qE4TjX/WNN95WOMEvJEmA4T1kYlOW0yb1ik8wnKojO
 JCdN8GxEXIdDqchxz2zLwsA7YIWKukF7Tu7bfjGI96PiNJyuFb9pW85DWaz
IronPort-HdrOrdr: A9a23:tV22zam5UPpdXJ+1l7ewZhWyhk/pDfOPimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ
 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa
 Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F
 mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee
 r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO
 gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO
 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+
 zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ
 TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duf22vaIJy4EUbICbQRGrWRQpj9aqpekZD4nSR+
 uzUagmccPeEQ==
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="86073483"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eGmol2qhwT9DXkyOkzhMJpwjaParVRusXEaAko4TNK8Ko9uEY/mXCCeng0QYCHJtFvbsgcSumFM9N43OnLhfHMrWxa4Hf2Ivi6K2CC1gA9bTn32S7Zq82wMjMNpbbw1AnUtA70x+KYweppKG1Z1y2cAmxQiWEPBHwqO/mqMzADd0LC0mX6WpoEWlNyoebU3Mhy6Xvrk3cfpNFoPvln1vqV3rmYVABpw2hunLPZ+dBwZmXq8jlCuamUqhs//VEjAmKDN9YzgVZJfe0ixBqzdZ2+pfuBIdu8D++3Sb20pESsv9iIXBi57LO1sda2wZdFM4drTTvvSLgal7IccBdwvBOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WdoIs1DXYrpf4zH5vaIUGbKvXgnwjwiqcS39NP5sWT8=;
 b=JeWbgBDsQIvdi6DZvplyQGnz5NjtWLMQZZv218KDV3QOmdcidj8xByyFCNfKh+NnN17f+zUWcVCYws9G+1GyAJyAeJ4xGBdtjJAGNcTxSfsrWPOqWr9S3S4pqYuA+EFwUDF9wl7CWY2Qjp91mwp8QaZ1FUSeTj6AvYk3GkFSEI9c8m5SgEoacgueHGOiCJeJouu6Dys4hH/kOsKTEK8Jy0KCWeVhbNFC3ujcolkuru5e8k/c2uOC5U54wF7sf77QjegGCatDCUReyiQmNtWPUPghxRL2hZ7b3KnpITp+fsrPRewQXO9t4f6jvthyLHJb8Cq+DlB7K9E0LDA/SmGwIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WdoIs1DXYrpf4zH5vaIUGbKvXgnwjwiqcS39NP5sWT8=;
 b=CJzWzNnIdV0SWDz6gntpSSRBqFcIwtgcB9T2jJOeZbZPw5mZpP4S1A5EFFRyyWl76MsK/j46B38x0ABsDZVy17VvdDdkE6Xs05l39DktLXaSGUl0PvxZjI9HT0zgUg60fKXHVoul2Pisx/x02khAUkMMyEMoqjXnjt6Ph9WMi9I=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jason Andryuk <jandryuk@gmail.com>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Xen Security Team
	<security@xen.org>, Jan Beulich <JBeulich@suse.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Henry Wang <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m
 mempool hypercalls
Thread-Topic: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m
 mempool hypercalls
Thread-Index: AQHY6SSlXP4isouqyE+BbtcNRl5Xnq4gqaGAgAAA/YA=
Date: Wed, 26 Oct 2022 13:25:46 +0000
Message-ID: <ce5f35a9-c3d0-5c07-f8e9-d1a53eadb1bd@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-4-andrew.cooper3@citrix.com>
 <CAKf6xptnDHePBLxE06bBUEkrgetg5-0X1TFFSDyJqPv4TCvA4A@mail.gmail.com>
In-Reply-To:
 <CAKf6xptnDHePBLxE06bBUEkrgetg5-0X1TFFSDyJqPv4TCvA4A@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|DS7PR03MB5400:EE_
x-ms-office365-filtering-correlation-id: 0a103954-37a0-4361-3287-08dab7559741
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 caGyfIXU4k2I0n+RfT+YnUb6h5RWLxcihFCFV05zH4hBzJcAU78yTIpnNja8NGVh3zoLUT/NEmWBd2Sk4y2HrgJmYERR7ifsbEPo2jVQ/9byJmgAqKfZH0mG16Bm7NhTT4+Kb0dom8uZ+5VWbvFdxj2wh74OVwwUrFQGrcBdwcxGSMvRbuGTLCwiG/7rOrTRCMZ079KkK8c+BXS/34UruaiWj+012KzsoD7x/h/6ZBqgd0xCWlamUYB6ofWVol9ylRT2YuUIVxpDojtjciToNM8De+J10yovUNONVHw4uq6Wq4Xnf+0sBuvBTO5ATkgqIPWTsAj2WTy12dCAP0hUst5SWUqVmLgowl6MdT9qjuyqqk9aRJ34fkanaKpjaawM33QR2XqpYi05HnJAY5xv1vFzNl1pv7wCujWAgLF2Bj75umk6fzuARU9q7Tu8RePy+bR0zNCV00j6AdahCQMGUl3W2CrplZiuEDeJPGkxypDRtl2LpYz47gz230rpO7laneeNmjguEkpKJ2euZGtTvUNE1EXGJHCWW5WSGV+4UblWdwgLJpI7oIJzXoGHHY5k8rV5pbcQ6R4818V1e6lRp0036TTxaEsFjhVb5YU5vz84dn2LoK9ZBhQZCMydBxKSA/xd6m6S1MjdCqGhBfL3apITUPLEZvT2T6i7C5GiXN/y6v7FTo/T92ryp61NYR64GrYCFMxrvGGxwMgeo49O4xO3EYpRWFCNgNxoBlqPOk/gbAEjp03QntziWKyJ2JDw/vRoA76j7NUCzeZn07mq1M6jW5Cof5ti35pXc7JFZveO6OA3Yxe/hCFBunEqX7ErBADZxBgGtyQqnkdidPdeIA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199015)(31686004)(36756003)(122000001)(66476007)(76116006)(31696002)(5660300002)(66556008)(7416002)(38100700002)(38070700005)(66946007)(82960400001)(86362001)(186003)(8936002)(66446008)(110136005)(54906003)(71200400001)(26005)(107886003)(2616005)(6512007)(6486002)(478600001)(316002)(64756008)(8676002)(2906002)(41300700001)(4326008)(53546011)(6506007)(91956017)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?dS9oWDRiaGFXdXMxMlZ4S3o4UUk4VG5lOHZBY0IzZ3htL0RLZlEzRzRXeUND?=
 =?utf-8?B?cXdRYkdVTitjQXgyTjgyMjNCVStJZGJscDlvOFF0Qll3R3VSdHBHT2JKRHZv?=
 =?utf-8?B?UHlzcnBtVGJnWFRQZCtGVEoxZWVqaGRoem1xVGpwcTZNQUtBalBTTklNOHpR?=
 =?utf-8?B?dE5aRDFqTFl2OVlMYnBaNm1oWkZ2T3JzdG5mZVhVVkc5M1VKWEUvVVh1VXRl?=
 =?utf-8?B?TU9uUWxYdXlxcTBXUGRYZ2lPdkNjV25DTHgva3VRQVUyUTB6YVNVampjY1hS?=
 =?utf-8?B?blQ4ci9oZXBsZEN0K3lJajhvTnp2QzZjc3RHdStVbWxobTk5S2JyTUR3WHJy?=
 =?utf-8?B?dTVadFQxMEdDU1hNKzNoeis5a0tzenZMT2Q5SUo4RnNGcGN3bFY5QlFWTkNn?=
 =?utf-8?B?bHF4MlNoR2VWaitheC9XY2tJMllCcnhmZzVuSCtKTTVBcnpLUDNMdzVVT0I4?=
 =?utf-8?B?QklyZ0Fpd3ZGYnZldDZoK3RRTjEvcG1lZkZOakZ0VmQwQTdIMjgxOXFtdldL?=
 =?utf-8?B?NDBBR25GWWZWOEgrWDM3dUxuaEdKTThkZTF4MWZBTjh5dFE2Q2FYODVybHN2?=
 =?utf-8?B?TG1CT0dxN2hZcHFGWlBVdUp3eFZRN204QXcxaHFWc2w2eThLRVRLNlc4TGFV?=
 =?utf-8?B?Kyt0VFQzSWZyOGhIMy9jNnE3SXY3WmJ0dUhLUEdsVGRaZXNBNGd6c29FVlFC?=
 =?utf-8?B?SVM2MG5OMkNyRXdHUTVXd0VhSzh3S3Y4R2JNOXFmN2ZLNks1S3VialgveERS?=
 =?utf-8?B?QWFDL2pwY2RINzhtazNPRFF1UkhRTUV2OGFVM3UySWUxSzh0MkVPWTBZMVRX?=
 =?utf-8?B?c1o0OFUxSWpKZFRzeDBvRE1ZckZYWlc4cFUyb0REWWhlV0dwMi9iL1pTUWda?=
 =?utf-8?B?dk5aOTRNWXBuUFlUdmtlZTl3TG90MWRHRmY2MWZ4V0VLR3UrSFJUMk9LZVhS?=
 =?utf-8?B?RCt2ZGdCY1BUVjRxa0RDMENWUGJiUlp6elEza2x3dUFXUDJWRWlmOTZ5bHox?=
 =?utf-8?B?MGphQ1pkVGVsbElTU3N6SWVTcktzK2ZIL3UzWE82MkMxZWVHenpKTDExUTJ5?=
 =?utf-8?B?MGU4SDZuZTZScXYralovL0tEUnViN0Z1MXczYmlwNUE1QklzM3hoYktuVWNR?=
 =?utf-8?B?Yjk5cWJaSlhYM3FqY3JSenFock8xYlY3ZndMZVpNWUMwS3FQMUwwUWI0YllL?=
 =?utf-8?B?SGU3NFExa1R6dGp3L0pSYVNCZVlNYTBNNFMvd0FNVVdIMXUreGNudnlCL2x2?=
 =?utf-8?B?YTliRU5kS2ZYb1Zzei96SVErd3dqcEpZOU1hTEZHOXlMTHk2WVNJZWZhVk5o?=
 =?utf-8?B?YVYzK0JNczFpaTJBeEhxQWt3ZEdYMm9Xbm5KVUFPL281Q1NTUFRCY0hBWGVZ?=
 =?utf-8?B?K2JCTjE0V1VlUFYzS0dydU1Vb2I0b1RWR3lrNFlDNVMyREtGTHJmOG5KaEhy?=
 =?utf-8?B?c0c2VitqREMvZVgzcVd6b3FFU0xGN0dsTVdiaEpGWlVqWVd4ZGdwK202OE1y?=
 =?utf-8?B?Y1lTKzVKUlFQN0Z2eERvV3ZGZTA0SWhaV2U2OUF1NVB1eUhDcVVIV09DUnNj?=
 =?utf-8?B?TmFmZWFIckQ3cHo0emQ0MDQ3NCtKa0pHQktxbEM5ZVRZSWpJUXdURkZwbTVO?=
 =?utf-8?B?QWhjMHpGSGdIZldhUEZhamFGTkE4QnVsMXZhbGlSMWhWUDBPeG16N1RIbzBa?=
 =?utf-8?B?K25YeTlZeXVPcHQrMHB0Nko5ajlSYjVDTE9xSVlObkJVdmZFVWY0OGZSd2dZ?=
 =?utf-8?B?ZHcveGhBTjlMN1ZzeG8yYUpNdTBaY2dBUkFQakk1TFJGY0hVMUtya0xTeVZC?=
 =?utf-8?B?cUpsZzR4YXJPMzR1cU9TNzRpdmxzYmVSWXFWbXdpdHRUa3RXYi9nR1VUcHpO?=
 =?utf-8?B?SmpjT29sU2NjbnlsTVVpdVFXbGx1MFoxTERETjF6Rzd3YVFqNXhyNk9pelBL?=
 =?utf-8?B?aHh3MENOQ2xSNnNsUXdpbUVxaDJnYUxqZWZoSkhsUmJqbDB3MUxQQVpWdlM4?=
 =?utf-8?B?MHBxbEVGdVJJQUFwc2hBRjhnZlY0VCtYK3VCdDU4dm5YYXlLd3V0dXE1dC84?=
 =?utf-8?B?OGtUKzh2bTRNblpTa29ocTlwc3h4S2U5REVJTnYvRkFKTmtpeGxzWkZaWVZa?=
 =?utf-8?Q?oy6R43YZ4V0TPYC4AbAvVlTqM?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4CE5BFB915087E48AE49E1AB6D063E27@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a103954-37a0-4361-3287-08dab7559741
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 13:25:46.3769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j0iuwL43tK9jtjRfESGK3MfFMuGioxh8LDjG96I0qyqmuKYMxlAwWJlPkaw3tNZLpL79gjzzdWwDbXfst3Zua7MSSq7eZyIkzZB1RoMp82o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5400

T24gMjYvMTAvMjAyMiAxNDoyMiwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gT24gV2VkLCBPY3Qg
MjYsIDIwMjIgYXQgNjoyMSBBTSBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXgu
Y29tPiB3cm90ZToNCj4+IFRoaXMgcmV2ZXJ0cyBtb3N0IG9mIGNvbW1pdCBjZjJhNjhkMmZmYmMz
Y2U5NWUwMTQ0OWQ0NjE4MGJkZGIxMGQyNGEwLCBhbmQgYml0cw0KPj4gb2YgY2JlYTVhMTE0OWNh
N2ZkNGI3Y2RiZmEzZWMyZTRmMTA5YjYwMWZmNy4NCj4+DQo+PiBGaXJzdCBvZiBhbGwsIHdpdGgg
QVJNIGJvcnJvd2luZyB4ODYncyBpbXBsZW1lbnRhdGlvbiwgdGhlIGxvZ2ljIHRvIHNldCB0aGUN
Cj4+IHBvb2wgc2l6ZSBzaG91bGQgaGF2ZSBiZWVuIGNvbW1vbiwgbm90IGR1cGxpY2F0ZWQuICBJ
bnRyb2R1Y2UNCj4+IGxpYnhsX19kb21haW5fc2V0X3AybV9wb29sX3NpemUoKSBhcyBhIHNoYXJl
ZCBpbXBsZW1lbnRhdGlvbiwgYW5kIHVzZSBpdCBmcm9tDQo+PiB0aGUgQVJNIGFuZCB4ODYgcGF0
aHMuICBJdCBpcyBsZWZ0IGFzIGFuIGV4ZXJjaXNlIHRvIHRoZSByZWFkZXIgdG8ganVkZ2UgaG93
DQo+PiBsaWJ4bC94bCBjYW4gcmVhc29uYWJseSBmdW5jdGlvbiB3aXRob3V0IHRoZSBhYmlsaXR5
IHRvIHF1ZXJ5IHRoZSBwb29sIHNpemUuLi4NCj4+DQo+PiBSZW1vdmUgQVJNJ3MgcDJtX2RvbWN0
bCgpIGluZnJhc3RydWN0dXJlIG5vdyB0aGUgZnVuY3Rpb2FubGl0eSBoYXMgYmVlbg0KPj4gcmVw
bGFjZWQgd2l0aCBhIHdvcmtpbmcgYW5kIHVuaXQgdGVzdGVkIGludGVyZmFjZS4NCj4+DQo+PiBU
aGlzIGlzIHBhcnQgb2YgWFNBLTQwOSAvIENWRS0yMDIyLTMzNzQ3Lg0KPj4NCj4+IFNpZ25lZC1v
ZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+PiAtLS0N
Cj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbS5jIGIvdG9vbHMvbGli
cy9saWdodC9saWJ4bF9kb20uYw0KPj4gaW5kZXggMmFiYWFiNDM5YzRmLi5mOTNiMjIxZjFjMWYg
MTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbS5jDQo+PiArKysgYi90
b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbS5jDQo+PiBAQCAtMTQ0OCw2ICsxNDQ4LDI1IEBAIGlu
dCBsaWJ4bF91c2VyZGF0YV91bmxpbmsobGlieGxfY3R4ICpjdHgsIHVpbnQzMl90IGRvbWlkLA0K
Pj4gICAgICByZXR1cm4gcmM7DQo+PiAgfQ0KPj4NCj4+ICtpbnQgbGlieGxfX2RvbWFpbl9zZXRf
cDJtX3Bvb2xfc2l6ZSgNCj4+ICsgICAgbGlieGxfX2djICpnYywgbGlieGxfZG9tYWluX2NvbmZp
ZyAqZF9jb25maWcsIHVpbnQzMl90IGRvbWlkKQ0KPj4gK3sNCj4+ICsgICAgbGlieGxfY3R4ICpj
dHggPSBsaWJ4bF9fZ2Nfb3duZXIoZ2MpOw0KPj4gKyAgICB1aW50NjRfdCBzaGFkb3dfbWVtOw0K
Pj4gKw0KPj4gKyAgICBzaGFkb3dfbWVtID0gZF9jb25maWctPmJfaW5mby5zaGFkb3dfbWVta2I7
DQo+PiArICAgIHNoYWRvd19tZW0gPDw9IDEwOw0KPj4gKw0KPj4gKyAgICBpbnQgciA9IHhjX2dl
dF9wMm1fbWVtcG9vbF9zaXplKGN0eC0+eGNoLCBkb21pZCwgJnNoYWRvd19tZW0pOw0KPiBTaG91
bGQgdGhpcyBiZSB4Y18qc2V0Kl9wMm1fbWVtcG9vbF9zaXplPw0KDQpIbW0sIHllcyBpdCBzaG91
bGQgYmUuDQoNCkFuZCB0aGUgcmVhc29uIHRoaXMgZG9lc24ndCBicmVhayBhbnkgdGVzdHMgaXMg
YmVjYXVzZSBhbGwgZXhhbXBsZXMgaW4NCkNJIG1hdGNoIHRoZSBkZWZhdWx0IHRoYXQgWGVuIHRo
YXQgc2V0cy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:36:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:36:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430584.682431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongaF-00071A-Mw; Wed, 26 Oct 2022 13:36:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430584.682431; Wed, 26 Oct 2022 13:36:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongaF-000713-K3; Wed, 26 Oct 2022 13:36:39 +0000
Received: by outflank-mailman (input) for mailman id 430584;
 Wed, 26 Oct 2022 13:36:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ongaE-00070x-Fa
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:36:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ongaE-0003mA-36; Wed, 26 Oct 2022 13:36:38 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.28.184]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ongaD-0005iI-S2; Wed, 26 Oct 2022 13:36:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=98F6bgrjz7sIeL9FPPRZjNKw97p6xD7EaVybNoD0hmI=; b=yxKhq42WtteIzmJDJSuwsxMXKd
	28vDZ88KQT/DyquAwtrS5IDeGhi1lekcl9Fo9uJzQMrUmGS8JX0RZhF2Ysbr7Tbjd+vaL78o51mgn
	2qemw2aqPOTZMm14kxgUofCaZUOetmjOk1+f1eZ2dOlGCo6FeIBQxKO67WNVws+/T1Ko=;
Message-ID: <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
Date: Wed, 26 Oct 2022 14:36:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Rahul Singh <Rahul.Singh@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 26/10/2022 14:17, Rahul Singh wrote:
> Hi All,

Hi Rahul,

> At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3.
> To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the
> device to the guest that is behind an IOMMU and virtual IOMMU is enabled for the guest there is a need to
> add IOMMU binding for the device in the passthrough node as per [1]. This email is to get an agreement on
> how to add the IOMMU binding for guest OS.
> 
> Before I will explain how to add the IOMMU binding let me give a brief overview of how we will add support for virtual
> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 Nested translation support. SMMUv3 hardware
> supports two stages of translation. Each stage of translation can be independently enabled. An incoming address is logically
> translated from VA to IPA in stage 1, then the IPA is input to stage 2 which translates the IPA to the output PA. Stage 1 is
> intended to be used by a software entity( Guest OS) to provide isolation or translation to buffers within the entity, for example,
> DMA isolation within an OS. Stage 2 is intended to be available in systems supporting the Virtualization Extensions and is
> intended to virtualize device DMA to guest VM address spaces. When both stage 1 and stage 2 are enabled, the translation
> configuration is called nesting.
> 
> Stage 1 translation support is required to provide isolation between different devices within the guest OS. XEN already supports
> Stage 2 translation but there is no support for Stage 1 translation for guests. We will add support for guests to configure
> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU hardware and exposes the virtual SMMU to the guest.
> Guest can use the native SMMU driver to configure the stage 1 translation. When the guest configures the SMMU for Stage 1,
> XEN will trap the access and configure the hardware accordingly.
> 
> Now back to the question of how we can add the IOMMU binding between the virtual IOMMU and the master devices so that
> guests can configure the IOMMU correctly. The solution that I am suggesting is as below:
> 
> For dom0, while handling the DT node(handle_node()) Xen will replace the phandle in the "iommus" property with the virtual
> IOMMU node phandle.
Below, you said that each IOMMUs may have a different ID space. So 
shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the 
user to specify the mapping?

> 
> For domU guests, when passthrough the device to the guest as per [2],  add the below property in the partial device tree
> node that is required to describe the generic device tree binding for IOMMUs and their master(s)
> 
> "iommus = < &magic_phandle 0xvMasterID>
> 	• magic_phandle will be the phandle ( vIOMMU phandle in xl)  that will be documented so that the user can set that in partial DT node (0xfdea).

Does this mean only one IOMMU will be supported in the guest?

> 	• vMasterID will be the virtual master ID that the user will provide.
> 
> The partial device tree will look like this:
> /dts-v1/;
>   
> / {
>      /* #*cells are here to keep DTC happy */
>      #address-cells = <2>;
>      #size-cells = <2>;
>   
>      aliases {
>          net = &mac0;
>      };
>   
>      passthrough {
>          compatible = "simple-bus";
>          ranges;
>          #address-cells = <2>;
>          #size-cells = <2>;
>          mac0: ethernet@10000000 {
>              compatible = "calxeda,hb-xgmac";
>              reg = <0 0x10000000 0 0x1000>;
>              interrupts = <0 80 4  0 81 4  0 82 4>;
>             iommus = <0xfdea 0x01>;
>          };
>      };
> };
>   
> In xl.cfg we need to define a new option to inform Xen about vMasterId to pMasterId mapping and to which IOMMU device this
> the master device is connected so that Xen can configure the right IOMMU. This is required if the system has devices that have
> the same master ID but behind a different IOMMU.

In xl.cfg, we already pass the device-tree node path to passthrough. So 
Xen should already have all the information about the IOMMU and 
Master-ID. So it doesn't seem necessary for Device-Tree.

For ACPI, I would have expected the information to be found in the IOREQ.

So can you add more context why this is necessary for everyone?

>   
> iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
> 
> 	• PMASTER_ID is the physical master ID of the device from the physical DT.
> 	• VMASTER_ID is the virtual master Id that the user will configure in the partial device tree.
> 	• IOMMU_BASE_ADDRESS is the base address of the physical IOMMU device to which this device is connected.

Below you give an example for Platform device. How would that fit in the 
context of PCI passthrough?

>   
> Example: Let's say the user wants to assign the below physical device in DT to the guest.
>   
> iommu@4f000000 {
>                  compatible = "arm,smmu-v3";
>               	interrupts = <0x00 0xe4 0xf04>;
>                  interrupt-parent = <0x01>;
>                  #iommu-cells = <0x01>;
>                  interrupt-names = "combined";
>                  reg = <0x00 0x4f000000 0x00 0x40000>;
>                  phandle = <0xfdeb>;
>                  name = "iommu";
> };

So I guess this node will be written by Xen. How will you the case where 
there are extra property to added (e.g. dma-coherent)?

>   
> test@10000000 {
> 	compatible = "viommu-test”;
> 	iommus = <0xfdeb 0x10>;

I am a bit confused. Here you use 0xfdeb for the phandle but below...

> 	interrupts = <0x00 0xff 0x04>;
> 	reg = <0x00 0x10000000 0x00 0x1000>;
> 	name = "viommu-test";
> };
>   
> The partial Device tree node will be like this:
>   
> / {
>      /* #*cells are here to keep DTC happy */
>      #address-cells = <2>;
>      #size-cells = <2>;
>   
>      passthrough {
>          compatible = "simple-bus";
>          ranges;
>          #address-cells = <2>;
>          #size-cells = <2>;
> 
> 	test@10000000 {
>              	compatible = "viommu-test";
>              	reg = <0 0x10000000 0 0x1000>;
>              	interrupts = <0 80 4  0 81 4  0 82 4>;
>              	iommus = <0xfdea 0x01>;

... you use 0xfdea. Does this mean 'xl' will rewrite the phandle?

>          };
>      };
> };
>   
>   iommu_devid_map = [ “0x10@0x01,0x4f000000”]
> 	• 0x10 is the real physical master id from the physical DT.
> 	• 0x01 is the virtual master Id that the user defines as a partial device tree.
> 	• 0x4f000000 is the base address of the IOMMU device.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:37:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:37:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430585.682443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongad-0007PU-Vd; Wed, 26 Oct 2022 13:37:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430585.682443; Wed, 26 Oct 2022 13:37:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongad-0007PN-SF; Wed, 26 Oct 2022 13:37:03 +0000
Received: by outflank-mailman (input) for mailman id 430585;
 Wed, 26 Oct 2022 13:37:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ANQJ=23=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1ongac-0007NX-E1
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:37:02 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 44ab19b1-5533-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 15:37:00 +0200 (CEST)
Received: from MW4PR04CA0303.namprd04.prod.outlook.com (2603:10b6:303:82::8)
 by LV2PR12MB5965.namprd12.prod.outlook.com (2603:10b6:408:172::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 26 Oct
 2022 13:36:56 +0000
Received: from CO1NAM11FT070.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:82:cafe::ca) by MW4PR04CA0303.outlook.office365.com
 (2603:10b6:303:82::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 13:36:56 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT070.mail.protection.outlook.com (10.13.175.20) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 26 Oct 2022 13:36:56 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 08:36:17 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Wed, 26 Oct 2022 08:36:16 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44ab19b1-5533-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oee8nAeZ0e7IMaYnjTdBV+jz0cNT04wyfQn51D8oJH9i+h7BbvHPsDQNiIH1ikM/4eRUm/uu0mvNQhM5aODyeAJ+W7pomJGOEOOTxXa6uhSFzlnq9t+bd5XNbG9QLv0aqrWAX0x+yJRd6vxTT2gU3ivGK51ywFLDV+vxZR1RFav9S/ao7NbSP3leyOQZAKcSTJVi/+elXkA4aLxm96klqk51mBeYkn3q7uRT3gN5LWlxGqgfaT6q6RtojDAOsBTOp8DDJVmErkD5zGsfpQoLDwjzuUBPCoPA7Q7XIvZt01G7AKrgy9Guyu2ZNuJVWvl+nKAzV7GbaOIV8yxk91Sv9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wwEyZHBa3dPSOxtzUwSKMcWCHBoTLECu3tT8+ePe6jE=;
 b=LroUwE2ZuOcCu7KUrZ3tGnR0J/ndhpHh2FEdDIOb/ZdNtWndoApO08fIIg1YTAP/UeoN6xftf6J29C0jfMt5qYddMTjIIG/wcLD2zC/NXwgrWF0I2z7iXH9yug3EP0do3QpV+F3sWLTDnrDsio51luxZWBCIuzO8in47w5eCljdcT2j85F+T78r3xr94awpOunVz78qIY+s5pLaQnPaLhhea98X+iPyIzPHA8c4mjgNEMt7OdJsIBkXVW+CorTEJvHcG0heJC6/Bp/BJSheG1PIGZ2C09XSKQP5OwN0lbAKp57cOih8EuPMMdUlma6rOx5ERpBGx4Rf6eSixa4kkaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wwEyZHBa3dPSOxtzUwSKMcWCHBoTLECu3tT8+ePe6jE=;
 b=ZFObGO8/IXn898KvloihPTeiIpmpMLNt/EsiFRsw/q+9bV9l/N8sVyTBbFzbsDlglZRHk7+TekEVOLLrwU0qu478KFQDUTGTBwlfu6BMBjwQaBF8QSc/hQ7SwjQyJVyB/C9+E16Y6Bu8nAyNjHoJdZ2IPrAgjs3uSztlonT4U0A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<andre.przywara@arm.com>, <Henry.Wang@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER
Date: Wed, 26 Oct 2022 14:35:40 +0100
Message-ID: <20221026133540.52191-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT070:EE_|LV2PR12MB5965:EE_
X-MS-Office365-Filtering-Correlation-Id: dea28037-51af-454a-6297-08dab75726b2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rWntPbS4r9y3KnRr2bGGR3DfIto9M/NIcHRmColpSwvPmtOcBFZ3XsL8FcdRtjajv43FV4duECzEAMdXkXA4k/bZLgkwPxtB9w3wjQuTz9Av4ELwB+BsuCRFoPI1ZRZK3ZOjG3Lf9eWX+Nus9/LEq/vWI2TGWrMpvQl40rSOjrBIHzxXkm88jJ3lfnVni4yurR5Vu08Fyp27yUXU1heQ+eOlsy6sbM9VHu50MJwtfiMhO7Jp7RKUC6fZ1/5AyNfnfyctfcYGF3aXwLOyDT0PUF9GZC1FtmUVpj3h2a8ax+WFRokwKXSf3yzNXvvoC8hSCJ8J/Cq/zlQDeAXpKq1kiUBPmvb2wYMEAOo8HoWDKStgseSEv9r95ZzHgMs41MxA1VxbKgKOmdZrN/zxpHtQXLkm/cG2fPOJN0xxR1OgZq8kxfRrNr19px6Y/wS2FWHLRWUINdLfIBmzvx9WakC5ebqVTsdAfVwPRy5Nmr3pIx0BgILW0JGVAZC3R8nCk8cldR+yUAAv7I3K1O2Okw6qFnHtGrtuL95KlQ5bI4M1QR6T3xKhsvtB9jAl8MXDPAGChnDSBg9xiChUlAw72RCWWzhm5jIky13+qJK2IIi2XQGKOhqNPTGkBwoApPX172Nx+7tres9vyh3PZyNduLlqK2DFZbTNkjwy66FUFTa7Dd5GeckEzZ2eer7DX8vfjJvyjz3WWsc+hQPX5b3uJA3r15cpvUUTdg5wGhNvL/LpPyA+s/rULkeXAn4dvazGtB0Ce32RYddP4BtAnCiY3QCOaGkkcnny23DIq4ShqLMTwRq7pqPJP3ZOPbxv7LCIY2Fq
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199015)(40470700004)(46966006)(36840700001)(82310400005)(41300700001)(6666004)(5660300002)(82740400003)(316002)(26005)(4326008)(356005)(54906003)(81166007)(40460700003)(36756003)(478600001)(40480700001)(8936002)(70206006)(83380400001)(8676002)(47076005)(426003)(336012)(186003)(6916009)(2616005)(1076003)(36860700001)(2906002)(70586007)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 13:36:56.4202
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dea28037-51af-454a-6297-08dab75726b2
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT070.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5965

If a guest is running in 32 bit mode and it tries to access
"GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
will return the value stored "v->arch.vgic.rdist_pendbase + 4".
This will be stored in a 64bit cpu register.
So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
in the lower 32 bits of the 64bit cpu register.

This 64bit cpu register is then modified bitwise with a mask (ie
GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
64 bit cpu register) is not cleared as expected by the specification.

The correct thing to do here is to store the value of
"v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
vreg_reg64_extract() which will extract 32 bits from the given offset.

Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
---

Changes from:-

v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
appropriate commit message.

v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read 
v->arch.vgic.rdist_pendbase in an atomic context.
2. Rectified the commit message to state that the cpu register is 64 bit.
(because currently, GICv3 is supported on Arm64 only). Reworded to make it
clear.

 xen/arch/arm/vgic-v3.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..958af1532e 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -249,16 +249,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
 
     case VREG64(GICR_PENDBASER):
     {
-        unsigned long flags;
+        uint64_t val;
 
         if ( !v->domain->arch.vgic.has_its )
             goto read_as_zero_64;
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
 
-        spin_lock_irqsave(&v->arch.vgic.lock, flags);
-        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
-        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
-        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
+        val = read_atomic(&v->arch.vgic.rdist_pendbase);
+        val = v->arch.vgic.rdist_pendbase;
+        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
+        *r = vreg_reg64_extract(val, info);
         return 1;
     }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:41:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:41:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430591.682454 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongf4-0000Yb-KK; Wed, 26 Oct 2022 13:41:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430591.682454; Wed, 26 Oct 2022 13:41:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongf4-0000YU-G9; Wed, 26 Oct 2022 13:41:38 +0000
Received: by outflank-mailman (input) for mailman id 430591;
 Wed, 26 Oct 2022 13:41:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ongf4-0000YO-1p
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:41:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ongf3-0003rs-MS; Wed, 26 Oct 2022 13:41:37 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.28.184]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ongf3-0005tg-Fj; Wed, 26 Oct 2022 13:41:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ikrKre8zf6ff2/vdwgDK7M0P68hkRUB3XwKF9qbYtPQ=; b=NMcvqxyXP6okrWJ3lDVE3Shnx9
	cfUjb9ixyOtGgnT0OSe7kHJkiuKqpZkMjndzqCH4+5QR2pXJuR+bsaF0xU2llO3fd2CIy1KQjse/n
	jL6lsoAklN2d8/ZrRwBoaLJJNHDDBz693SHyMm/ZTJNFG6Evkb+9e8cVANLj0V9mr/Lw=;
Message-ID: <95d0a8ca-9ff0-162a-02ae-8cbdc30af8b9@xen.org>
Date: Wed, 26 Oct 2022 14:41:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, andre.przywara@arm.com, Henry.Wang@arm.com
References: <20221026133540.52191-1-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221026133540.52191-1-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 26/10/2022 14:35, Ayan Kumar Halder wrote:
> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 64bit cpu register.
 >
> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
> in the lower 32 bits of the 64bit cpu register.
> 
> This 64bit cpu register is then modified bitwise with a mask (ie
> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
> 64 bit cpu register) is not cleared as expected by the specification.
> 
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Given the changes you made below, the reviewed-by tags below should not 
have been retained.

> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
> ---
> 
> Changes from:-
> 
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> appropriate commit message.
> 
> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
> v->arch.vgic.rdist_pendbase in an atomic context.

Please in the commit message why the lock is removed. But...

> 2. Rectified the commit message to state that the cpu register is 64 bit.
> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
> clear.
> 
>   xen/arch/arm/vgic-v3.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..958af1532e 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -249,16 +249,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>   
>       case VREG64(GICR_PENDBASER):
>       {
> -        unsigned long flags;
> +        uint64_t val;
>   
>           if ( !v->domain->arch.vgic.has_its )
>               goto read_as_zero_64;
>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>   
> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);

... you also need to ensure that the writers are atomically setting 
rdist_pendbase. Please correct if I am wrong, but the callers are not 
using write_atomic(). So how does that work?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:42:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:42:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430595.682465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongfm-00016d-Uk; Wed, 26 Oct 2022 13:42:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430595.682465; Wed, 26 Oct 2022 13:42:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongfm-00016W-QV; Wed, 26 Oct 2022 13:42:22 +0000
Received: by outflank-mailman (input) for mailman id 430595;
 Wed, 26 Oct 2022 13:42:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ongfl-00012X-90
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:42:21 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2051.outbound.protection.outlook.com [40.107.247.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0324ae12-5534-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 15:42:20 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by VE1PR04MB7487.eurprd04.prod.outlook.com (2603:10a6:800:1a2::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 13:42:17 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 13:42:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0324ae12-5534-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZY442MERyaNQyg0iOYE17Ivc0PW6+9DARJSDuxM3BYze9yDjbrXhBTolJET1FmfFEBsVUbF7vl1GRLDTEprVSCCWj3sfBV46Sq9VK+5D97VVPQPDFF+//NEKyHQXvyv+0Dey7TIlWz4PLd7HyNNKsb2pzl/iYW7nEPbT9rMNJoV95gvSRU2P2VapqJ1N1HIKNr0t5xgaAPNFJiP5pvQ0hTFJBLl9KoyIoIgCFnHG2XPp2VYL6k4nqJIgVm5M1rlvNKOY6Jnc1AWiNNiU6gYaNL5QJfb4HiBniBbx6VoWxoII9u9MnoRm/W/ikjsPiqwqviKPqTGr5J6W1iXCSIQvsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Cx3W9P+imJMsWqJjb3/Fd9pb/bD2d42JW7SPBB3zBKw=;
 b=A0bHcRJx7nYYZVdgY85Vw8qazZx2EE9uxZDWjy/eEG/+6JvcTFhlGbfWhftCXeTUv9Me9g0ePDJRGt31wZcXT5sYu0HjoQBcc3rXPOvzvJOguIHdDEEAgNon1IqwD3b0ONCGGRFn5MlnyTP/a0OKa2ABcHzqZRYnazxF2GTlpvUqeE1kX4vo3daBTJ+DWfCqQOYDBUg3JPI0keOX2TdCGhH0dSXqjzRabvQgpmDV7Ec7Q3MXgmAK0Jh5362pJSZsK7ggnO6cAPWdTCHHKVPLQ/0BbfIu0BIv0wownYhCzkaeH5tR6eAnx+Qa9JwPxXnZ6pLe1219phSFn4JW27BCiQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Cx3W9P+imJMsWqJjb3/Fd9pb/bD2d42JW7SPBB3zBKw=;
 b=ibrYv+OJXZwWqMF/IyCTHNxZgqs3q1rguP2G+IeeOE3ri9zxst83HZy2wLe6J/ifeeAEWZoicFiFZy2UlqzTCZWK3ne2tT5bzpCnDEiBDvfm2Uu0NGIYIPO5xmRrk6Ue18vgbayqDvpAwEXmzMVE1MHx6yVjPOwbmJHyiGom4VnL0pX5dSp7YwHGBEaUNsqdx/tpo04+HK3PU4gGxTMp3EUFLnNRE/6hE2UgRW8q90QajtG9lv+viiYcr4UudRje0rWM+E4XH6WSat9JlQmHPE0OQOfYKHP5irvoZpUSggb11i54UJdeeUZ2O+/xCJimEGOdX4YI0TZTZ4tFOMDWqw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
Date: Wed, 26 Oct 2022 15:42:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221026102018.4144-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0132.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:94::12) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7487:EE_
X-MS-Office365-Filtering-Correlation-Id: 41050455-72eb-4c39-df2d-08dab757e5bb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QLwOIb+t5AaNXTCKnj/BDnQbgok0I+EE7pOo8KDu1L8+z7xXQCvlc3eq836a0exE4/Ca46Q/frPULetw9FbWsCTSdPVqeBJzcA8uT4/4ho7w1y+TBa8OF9VNj9sodb8T+/l5Ki/5MpxFtwij2tjA81BFpeLD6XxaM52h9ScmQbwvLRKZF7+0ty9m2zO0gvbrwQnmiobtpv94oYKq8NmAT820coHWF3hr4EAC3Rx00rU2AUyPW7h3WDiH6JPYflcrY6IVY+1FmYZBQXzCLwRdOUrLwrCZD7N5jR0mXo+deBC6Uhb97It8JP0z1xzW7CN3lUxw83Kx/1GfvPTG1rimIo7ehcMWfIQ+tYjUr3ejBHUv7kC4+Blhj+RL8egMAA748ZEOkj9N0a26+ike03/ed43X0m/LJclypXjIcIpunqnB7AxLiBvyWU6oo8cCPilYxQgpVGPdbxLwkvnz/cXc5ocVUxkXc1SEyYwhE9gSkfSTXarCuSD0i/RhXZ9SIf79zjxOjY2kGGrmyIizY4mx8HkJnnAj3nFcGqAQcM8j1NWTFHjtiKj0HctQysjBoywkxCh5HolP9jRduVJXA4WDOPrzzLilk6QQcDmcU+4pKPQtXpASI304vFe1s/LjaJ+dCzmOT2Z0a3c6cZ/ua4SStYWfGjpWF6PGDKm4FBVqFG8u3f6XaU/MWe9q/x0MIOz4gIrW+HqZvn4iRlJvs5YJI4boRPP6Tb0h8Sno74uWYbsZWzwtORrn1OW59PVkOrbb/Aq54BDFRURlfJQgkiqLbw6HFLnKewSnNcWKHVwSqN3dr3sAkkfirl4cpOq9xcsF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199015)(2906002)(54906003)(6916009)(316002)(53546011)(86362001)(6506007)(6512007)(6486002)(5660300002)(478600001)(26005)(38100700002)(7416002)(31686004)(8936002)(41300700001)(4326008)(186003)(66946007)(36756003)(2616005)(8676002)(83380400001)(66556008)(31696002)(66476007)(45980500001)(43740500002)(473944003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bm5hWXk1S2tXekIvRldId3dYbGpnaWtZTUpTWGhjZ2dsNWgyMUdDbXF1dERD?=
 =?utf-8?B?cWtSK3VMcjdhVmFVS2V4emZjdVJ4bDJKa1FTNUFSMXRqT1JHTlZlY1A1dmVS?=
 =?utf-8?B?Tm16Uzk2bjhCL0w5akFMaHJoZXlNclVmN2lOM2xpNjUrUmx0ZE5takZFL2Vu?=
 =?utf-8?B?bnk5dEFDNHFuZERFSis2WVA1TEFZZnN1K094WHRrZ0VxdG4vRFdzdURzbEk3?=
 =?utf-8?B?aWpIQ0N1YzVjd2wyRFBtdnJ2VjNtZDJCY0swTld2RTgxNmxzS3VJWW1STG44?=
 =?utf-8?B?QWRBUlNhOUxscFFmalE3SjdGcjdnT04vS085UEFSTjhxZ0lFOUZEallLOU1G?=
 =?utf-8?B?Uk1XWE9xM3hOd21XWWdFejEzYWwxOG9PWS9RVEhWV0dFbStMQk05NFFXSncw?=
 =?utf-8?B?MXFOME5nTWI1akNZS0c3VHJHQ1JNeklXR0taWVpTYVFlR2RHUFhkbTRHRzRi?=
 =?utf-8?B?TFgvRUIrcmVScVg4OGtsY1lzZGxWdHF2aTZ1N3laTkxqcXVvY2c0WGJ4T2tv?=
 =?utf-8?B?dS9BbkhIV1orZ2FubHRlK0I3SzhJbFgwOU9YM2xWeVZsT21LV051a2dqdkNy?=
 =?utf-8?B?K0I3T3RXQmZQRnBmU2VEZ0JMZjJaVy9xakxPVWtPUmw1c0tMenNjbXF1b0RZ?=
 =?utf-8?B?RjM1MkVuRWlGL3hjVmEwak80WlVLSktkYWt5cGh4NVRDUllWNFkzOGFLaVRI?=
 =?utf-8?B?OUJUSW0rcGw2Sk1YWXY3ckpMbUVNck5JR0xROWtYaURPeVR4K3RZcGtSem9B?=
 =?utf-8?B?bDQ2dTlBSG9SWGpoaEk4L1crSkJDRTZTZHFxWXhBNm83aWhmdUI2ZzBaUGxE?=
 =?utf-8?B?VlBtNTRuRXBja2VnQWp6RWVWa0IwbGg3Y3JWS21FMUI5endYNzk0ekpiZWxT?=
 =?utf-8?B?cEVBcTlyaXpLL0tneU5xbHo4cDdxU2IyNHc3RkZhWUhuUDhWSmZNWCtZazhB?=
 =?utf-8?B?ak5YZ21ZSHA4MVVGSDQwaXBwc0hxRTBQRVRyY2ExMWRlOGF0WUlHSjJrd0xV?=
 =?utf-8?B?NEFoZVBKV1ZnYWNWR0xBbldWTnFHRXFaanFPVXhKUkIvQ0dBMXNMa0h4NHNv?=
 =?utf-8?B?b0orZTBRU1hjQkUvdHpQcGdOSW41U041bEFranJxSlF6eFluWXJBcDZEUjVr?=
 =?utf-8?B?aFkyZlpkZ1RNL1pKbEJ3NVV2S3VVYnAzMW5od2JDa0UrVC9tSGhUbnBBTzZB?=
 =?utf-8?B?ZUFZRjM3YUkyNWdaQUJRYk1QL1ZHY1hsakFsLzltYlUwSE9aY29CZm4xbkts?=
 =?utf-8?B?b1dZYjRJZ1VHazNzMDF1TUswVkdvZ1lQWDVIVnpQbndFVmNHVnMwdkRnVjd1?=
 =?utf-8?B?bzB0ZmFvV2JpT20rV0tHTGZFOWU2eTlXSmVPbHpyTmdWaWhaZ01Tek9JRTgy?=
 =?utf-8?B?QjFOQWx4UFh1TlNTVi9CUC96SkRUM0RFRFhjK0IwcFhRTjJNQ29PQ2NvVXhL?=
 =?utf-8?B?SFA3UlJpOHF4ZDRuNnh2TUNKZlFSQjdML08xN0l3OEo1KzlNLzNsVDhIUG52?=
 =?utf-8?B?dnZXWnd1WFhQZTc1aUI2aXB6OWpPOE1uWWRnVE04ak5aRnVvUm1aMGVQSGx3?=
 =?utf-8?B?YU9CTXpSS0wxMGtwcXRRa3hrVXNyS0ladlE0alVtQVN4bkR5L0F2SUZYT1d6?=
 =?utf-8?B?UG42WWVsR2x3TE1HOWJWRjJHYkRFTzZUU3dxQktpU0xDRTMzd1FCdGpTK1o0?=
 =?utf-8?B?S0NVaG5HaHN6NE53dGg2ZGRUc1ZINVgyZ3M3SUdkZkRUem5xbXJhQkZPeVVv?=
 =?utf-8?B?MVdOUUZYYlhFdDlKLzRBeUJLV212cytOaGplWmswQ3lEMlp5bUhsR3Fzdjgy?=
 =?utf-8?B?UVRlY0FldzBkeFBYS0NwQ2JyRHM5US9IdkFUWjJmRkZablZmZThRS2IzSmwz?=
 =?utf-8?B?d0ZwQ1pXcXpVaW1wYTQycUtWSXNuNXpkQXZZWTR3NWk1MEQ5WElPRE1Dd1Bs?=
 =?utf-8?B?RGRCT0pVcXNEK3FoeGtJM0MzZkE3RSt3QnBCUFNVSmFVV1p3bVdqUXo4Y1JV?=
 =?utf-8?B?Yno1WlIzang3TE1LWnF2TXhZS2ZIS1h2UTRWbExKL1JnSlEzNUdFR2FnRy92?=
 =?utf-8?B?bTZjdmErNjBhRmluS1BNaFRKcTFXMFB3YVVoandHa3pIdytpOWpZT2lXY21n?=
 =?utf-8?Q?l3c4xa+no2+fP2pxX1hIYYKee?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41050455-72eb-4c39-df2d-08dab757e5bb
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 13:42:17.1772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aYji9VYN8b5kTbPTVYPRcRnoIYP6b55EyUOKqnQ8sevmXaxdDuKZiqyBXVh0ET2bk6VkAWChA1kvcy+DKn1Xbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7487

On 26.10.2022 12:20, Andrew Cooper wrote:
> The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems:
> 
>  * All set_allocation() flavours have an overflow-before-widen bug when
>    calculating "sc->mb << (20 - PAGE_SHIFT)".
>  * All flavours have a granularity of of 1M.  This was tolerable when the size
>    of the pool could only be set at the same granularity, but is broken now
>    that ARM has a 16-page stopgap allocation in use.
>  * All get_allocation() flavours round up, and in particular turn 0 into 1,
>    meaning the get op returns junk before a successful set op.
>  * The x86 flavours reject the hypercalls before the VM has vCPUs allocated,
>    despite the pool size being a domain property.

I guess this is merely a remnant and could easily be dropped there.

>  * Even the hypercall names are long-obsolete.
> 
> Implement an interface that doesn't suck, which can be first used to unit test
> the behaviour, and subsequently correct a broken implementation.  The old
> interface will be retired in due course.
> 
> This is part of XSA-409 / CVE-2022-33747.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Xen Security Team <security@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
> CC: Bertrand Marquis <bertrand.marquis@arm.com>
> CC: Henry Wang <Henry.Wang@arm.com>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> 
> Name subject to improvement.

paging_{get,set}_mempool_size() for the arch helpers (in particular
fitting better with them living in paging.c as well its multi-purpose use
on x86) and XEN_DOMCTL_{get,set}_paging_mempool_size? Perhaps even the
"mem" could be dropped?

>  ABI not.

With the comment in the public header saying "Users of this interface are
required to identify the granularity by other means" I wonder why the
interface needs to be byte-granular. If the caller needs to know page size
by whatever means, it can as well pass in a page count.

> Future TODOs:
>  * x86 shadow still rounds up.  This is buggy as it's a simultaneous equation
>    with tot_pages which varies over time with ballooning.
>  * x86 PV is weird.  There are no toolstack interact with the shadow pool
>    size, but the "shadow" pool it does come into existence when logdirty (or
>    pv-l1tf) when first enabled.
>  * The shadow+hap logic is in desperate need of deduping.

I have a tiny step towards this queued as post-XSA-410 work, folding HAP's
and shadow's freelist, total_pages, free_pages, and p2m_pages. Here this
would mean {hap,shadow}_get_allocation_bytes() could be done away with,
having the logic exclusively in paging.c.

> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -100,6 +100,14 @@ unsigned int p2m_get_allocation(struct domain *d)
>      return ROUNDUP(nr_pages, 1 << (20 - PAGE_SHIFT)) >> (20 - PAGE_SHIFT);
>  }
>  
> +/* Return the size of the pool, in bytes. */
> +int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size)
> +{
> +    *size = ACCESS_ONCE(d->arch.paging.p2m_total_pages) << PAGE_SHIFT;

This may overflow for Arm32.

> @@ -157,6 +165,25 @@ int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted)
>      return 0;
>  }
>  
> +int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
> +{
> +    unsigned long pages = size >> PAGE_SHIFT;
> +    bool preempted = false;
> +    int rc;
> +
> +    if ( (size & ~PAGE_MASK) ||          /* Non page-sized request? */
> +         pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */
> +        return -EINVAL;

Simply "(pages << PAGE_SHIFT) != size"? And then move the check into
common code?

> --- a/xen/arch/x86/mm/hap/hap.c
> +++ b/xen/arch/x86/mm/hap/hap.c
> @@ -345,6 +345,16 @@ unsigned int hap_get_allocation(struct domain *d)
>              + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0));
>  }
>  
> +int hap_get_allocation_bytes(struct domain *d, uint64_t *size)
> +{
> +    unsigned long pages = (d->arch.paging.hap.total_pages +
> +                           d->arch.paging.hap.p2m_pages);

Unlike for Arm no ACCESS_ONCE() here? Also the addition can in
principle overflow, because being done only in 32 bits.

> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -977,6 +977,45 @@ int __init paging_set_allocation(struct domain *d, unsigned int pages,
>  }
>  #endif
>  
> +int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size)
> +{
> +    int rc;
> +
> +    if ( is_pv_domain(d) )
> +        return -EOPNOTSUPP;
> +
> +    if ( hap_enabled(d) )
> +        rc = hap_get_allocation_bytes(d, size);
> +    else
> +        rc = shadow_get_allocation_bytes(d, size);
> +
> +    return rc;
> +}
> +
> +int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
> +{
> +    unsigned long pages = size >> PAGE_SHIFT;
> +    bool preempted = false;
> +    int rc;
> +
> +    if ( is_pv_domain(d) )
> +        return -EOPNOTSUPP;

Why? You do say "PV is weird" in a post-commit-message remark, but why
do you want to retain this weirdness? Even if today the tool stack
doesn't set the size when enabling log-dirty mode, I'd view this as a
bug which could be addressed purely in the tool stack if this check
wasn't there.

> +    if ( size & ~PAGE_MASK )             /* Non page-sized request? */
> +        return -EINVAL;
> +
> +    ASSERT(paging_mode_enabled(d));

Not only with the PV aspect in mind - why? It looks reasonable to me
to set the pool size before enabling any paging mode.

> +    paging_lock(d);
> +    if ( hap_enabled(d) )
> +        rc = hap_set_allocation(d, pages, &preempted);
> +    else
> +        rc = shadow_set_allocation(d, pages, &preempted);

Potential truncation from the "unsigned long" -> "unsigned int"
conversions.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 13:58:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 13:58:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430603.682486 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongvT-00036J-Hw; Wed, 26 Oct 2022 13:58:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430603.682486; Wed, 26 Oct 2022 13:58:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ongvT-00036C-Cj; Wed, 26 Oct 2022 13:58:35 +0000
Received: by outflank-mailman (input) for mailman id 430603;
 Wed, 26 Oct 2022 13:58:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=n4Ky=23=citrix.com=prvs=291e24488=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ongvR-000366-C2
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 13:58:33 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45379bef-5536-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 15:58:31 +0200 (CEST)
Received: from mail-mw2nam04lp2173.outbound.protection.outlook.com (HELO
 NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.173])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 09:58:20 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by PH7PR03MB6972.namprd03.prod.outlook.com (2603:10b6:510:12f::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 26 Oct
 2022 13:58:16 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 13:58:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45379bef-5536-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666792711;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=EP5UQJ08KDhkBYVopzuTynVIcU3wGlXQdgLq8Yv5nM4=;
  b=SFWOCsk5oZf9AmnYd+dF6ecDCXpLVpjyQml+DmNWyOnio9b9GRS5+Lwo
   HDTG71j84V6Fv230bbRAb5SNeqTUzWxc+BBOsQiD5fQVYtH7X2Ik88PkD
   BAJpDxBpdNOlRgiQajgnnccMp9/4AaPXuHrA63Iyp0NyLBTjPOSz4p+lu
   Y=;
X-IronPort-RemoteIP: 104.47.73.173
X-IronPort-MID: 82645052
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:2kIBkK2CnIroyotbl/bD5fBwkn2cJEfYwER7XKvMYLTBsI5bp2RVy
 GJNDD+Ga/fZNjH8LYonPN6y/EME7JDQnNBiHAVupC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlG5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUa/vpVX28ey
 MciCzQdSyzcuPiskKmSH7wEasQLdKEHPas5k1Q4kXT8MqxjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g3O4/NouAA/zyQouFTpGMDSddGQA91cg26Tp
 37c/nS/CRYfXDCa4WrfrC7x3rKV9c/9cNJRSLuV6eJLu1KC6WowNjZMZV7nj+bs3yZSXPoac
 ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c/pdFfcrrj6EzKX86hycQGMDS1ZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9URX5NkcHbC4ACA4aud/qpdlvigqVF4k4VqmoktfyBDf8h
 SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTxgbQHxZ6s9Lqkc2Q=
IronPort-HdrOrdr: A9a23:yydNB61umPT5USDcFk9D6AqjBVdyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtrp
 uIEJIOdOEYb2IK6voSiTPQe7hA/DDEytHPuQ639QYRcegAUdAF0+4WMHf4LqUgLzM2f6bRWa
 DskfZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolys2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4RLYGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUQTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+qZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wVh4S0LpXX9
 WGMfusqsq/KTihHjHkVyhUsZeRt00Ib1u7qhNogL3U79BU9EoJvHfwivZv3Uvoz6hNOqWs19
 60TZiAq4s+MPP+TZgNcdvpEvHHflDlcFbrDF+4B2jBOeUuB0/twqSHkIndotvaMKA18A==
X-IronPort-AV: E=Sophos;i="5.95,214,1661832000"; 
   d="scan'208";a="82645052"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nw2gOw/oKOhSTbMGB3p7ueCKOOH6+0EonapNKIi+YHTB95X7sZU7BNwL3cgpc6/vRwp4lqztjNZ+uXRzktoEpsCwG6PZuXe9Xh/qU0Eo/0cxg0x4w2Jv7fC8VzK+hB22lqTBcmxbX9C3f/oYnAK15jIYt977dahPPad8Pv2b4A35jbQUmNwR2s2Df0T/LhxSIcMLen0bvtum1nZHiiysmNE5bC3TroSvvUJmmzDCGN1+z8aGVKVrhN/Q+oBM+4zPbqg5vAoSPuugwtd9wQ9Gk5ZK4ro7k//I8XFY0jqO9xDqPH0UuBIHLCX/KFHi+vkLJ0MvxlQz7Az4U19K82wtSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0qSp6mfsVSYJSkqhY8tIio+vVK4ih0bpe64V9TSGzyU=;
 b=cloopdE8EuhEjds2PkNnlt9gcY++qRWp9d9+ref3/IbrijDKh5Z9AETaqmTdRDraF/8qr4H9hPaEGAHjPd/+/gl5vU2hyWX7EABRj+bxt/8ppMjWzPr4PgKhMftdp+QaDK9Ae8l/3/a1Wo6yKJNtU+L82jDyopqBSAI2QC6TF/P6ljzN91rwKbcXM+oKHPhtEGK31G9e/AxcfukdQ4/ZY7fnNqFPzmBRvtxVzwB1z5qG1XoM4lnyknwTrfhS5KZFjviyyd7rVb5pck6/4YVoSOXkZd5SYGgkT+VO8TuWgFYXBzOvV4Rywb0424V8/1lDAEQtA09WE1KcSwyEkcWfPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0qSp6mfsVSYJSkqhY8tIio+vVK4ih0bpe64V9TSGzyU=;
 b=NKFU03qnrH4ae1inMK+2CIVdSL/x9stt7udTGL4PG37eT4xhWlBVRtK/GDCpasWLGSQv8UD6PWExEA0q78jVS65E55IBYJN5tPvGG77fxtzlUpg4RciXh5tpX6XDunfARB2q1jy7biC6UQ2VR9XyjlyOSmA36rqjunhKCOXtIUw=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 26 Oct 2022 15:58:10 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR
 is mapped
Message-ID: <Y1k88uhbSNdMvsa+@Air-de-Roger>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-6-roger.pau@citrix.com>
 <666377e8-fe58-bc9f-70ff-2e21d93c691f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <666377e8-fe58-bc9f-70ff-2e21d93c691f@suse.com>
X-ClientProxiedBy: LO4P265CA0015.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ad::18) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|PH7PR03MB6972:EE_
X-MS-Office365-Filtering-Correlation-Id: 67c5e006-0c5f-4746-b04f-08dab75a215a
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NbM3KcksN/bhwzQUPS1TXahiv0b6UYf5bvoYR8vJv8E1RtptM6/VfXro8sNsn5aFD73pBFjPOWU/0lx8wvyX7XfWcGLaa+Fv/gEX0v7HPihKWvcPDJWLlOs5b7Wkilqq8JOL0TU9tBV+PSmodHHmj0vWgI86awLyvubIHXatMwH/VV2YIvAam1QPd6kEDmZZgFjnxtiYzL4omznCxrRqC/VJkUHAxNtOolNRJRho6y8M58cOehiy1KwSRaYnkOEeLBHx1QSLJUUXF/j20IDqsB/0foF1eArTALaGDe+SkXNmhr0qzxUtRksEFc8wNi+O9v4kRrGF1uvaL3fnQI/BdIo6ds/2BRLyKKt4dkE3/+8FuS+2FU/aVtgozDdRKWoFuTY/nMcAc/eLXKuryGvdPxnkiCxGZbrAOfJ2XkS4VEdH2bTZr9lZqFUmMcH3nKsqmMGV6Wq0sfrQ1llzOLOxq6bB127pkfskgUhnvyc6+kFJeDnyjAQ60/gjOrNwHsWyyFugGfI3w7I5HkYCWEYrR9bYkaoMQWfP2xuUmo3f8U3nsMNeoddC4V/iVOKUk7uy2zB6CGjE0qXgPuDrkcqXgLiQu/rhHA/4SkqMjXpAs6lSMCzCjEDJynxdTYQc/LfVvLQAiUfvx59ny7VHKZr0rGRjxc0Z4fgkXTCcZgP08ql4/CAcZzodq7Ydi7dciDfDiYWawLQCpHNKStjfdiy5lQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199015)(33716001)(478600001)(38100700002)(186003)(66476007)(41300700001)(83380400001)(85182001)(6666004)(53546011)(6916009)(66946007)(8676002)(5660300002)(26005)(2906002)(6512007)(82960400001)(66556008)(86362001)(316002)(6486002)(6506007)(9686003)(8936002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3dxcUFMVUVqc3B6ODlocmhlQmpNZTZMK09tVnpoR3laM2VCeEcxaWh0VFJ4?=
 =?utf-8?B?cjFudXhrNytmWStRNFVyUjhGQ2hmRExBSFpSVCtFek1VcGVPNnk4SWxCUzVt?=
 =?utf-8?B?S2JDckkzdllOS1U5bjlSUEc1WUhFSk5MMVU3MzBuMzJwOVg2UWNkRHJ1MWgr?=
 =?utf-8?B?bWozNmN1dG5RSFU3blJqcWsrSFRTR3RkNUhSUjRwdGFWbWtjMm1QVnRjVFNE?=
 =?utf-8?B?TXVNejdBa1JpOHdCNVdEbTlMMTNseXFmeVlSdFpNbk9TbTlGTkd3WjRKSjJq?=
 =?utf-8?B?NytCRllhMVV5RjZBYVoyNmtDbFhDL1NyNkR0ZlIzT0hwakFUck1UM1pNbzUx?=
 =?utf-8?B?UzRSS3V6a0hmUzRVS0JTdDNLd0pQNmZoTVp6d21wWW1EWE52THJiaTBaQUFv?=
 =?utf-8?B?SXYwempjd1F2aFlpU0JpRUVGdmFFclRKai9lVk01SDNmdjhPRXlLSDlOaGR5?=
 =?utf-8?B?WTdTWTV5TkdKMGswQWdONXZqc0FNQWZSbTllYURKa1JwUWVqY21Nc3pmQlZ6?=
 =?utf-8?B?aElrNHIzaStybnJwMG1oaUJjc0cra3VHNDNNaWwwNEJzSHA4cW8wMEh4Wklx?=
 =?utf-8?B?VUFnSlIvTDF5eUhwaUN1d1I2THFsMmsxbS9yOEs5dlpveTM4bnErRk1qRHk1?=
 =?utf-8?B?V2l6cnJ0OTl3d252MlZDN3M1ZWVneFU3ODN5K2hnbUFGTFVubm1RQ1FBMVBy?=
 =?utf-8?B?aGlGU0FNMlJDRG91ZVA2K250bm5oM2VHUUV1eFRaSkl3L2NWb3NuaVNVYVQw?=
 =?utf-8?B?dVdnYms5VHVOdnpjWVhaV0pRdUNNbnI0TVVucFU2Mjh0SUdzdEVtRDdBZlBB?=
 =?utf-8?B?akE3NW1CUFE2ZjFFQUkyTEJLczZ1MEpiUUN4Z0hySUJqZE1Mc0lsS3hiclhB?=
 =?utf-8?B?dEhXaFc0SnRleHdqMWdzLzgrVnZCS3BuN1BFWTNjRFl2dkhGNG9XakI0bG1N?=
 =?utf-8?B?a2lLVk1FZW1nSDloeUpoa3hGcFM4RkRWRiszRFRxVnlTdElLQlI4WWNHTFpl?=
 =?utf-8?B?MUxJMUZOeHpOdGJOSnYvKythd2hLcjFwOFJ3L0NKVVR4ZmxVQ0M5elFiWTZC?=
 =?utf-8?B?bk5pSVYzSVo2VEtEd2s5MzhMb3dlazBoL0JmWUNPMmdEeEZqdU5wdy9vSDVK?=
 =?utf-8?B?eS9QYmU5Tk1kNGZOdFZSNHIwaGlGNG5qVm5KZnZLdmQ1WW9zYkFKb2E3VW5M?=
 =?utf-8?B?UHNWSjlzVGUxU29ZTUE2TjcwMzFsd1MxOUVLcTg4akZNenB0T2JNaHVCMXV5?=
 =?utf-8?B?OTVqOXltYWFPQ2dRWEpqU3phV3h5dlJlOWZ1SU9QVDdLU3liQzZITk45ekIv?=
 =?utf-8?B?eTdvckRuT0ZnMHYzVnNDeDJZbTZNcFdKdTVuUnpVM0d1MGtuYmMwZjUvS2lB?=
 =?utf-8?B?blBOMkhteDVzT1NDREVod2FDaUQ0WUlxZEVQZ1VzMi94dkF3RExDeWRjYmt1?=
 =?utf-8?B?UWdKMHk2bkdxSVU4Z3pFMFk5STF4a1FUYmJVbXc1WVF4d2xxRXNyZXJwZXBs?=
 =?utf-8?B?Q3c2ZWxSTGMvakczU3VoY3JwVjRIbE5sbno0U045NUZ1cWE0K3ZLMGNjbE1D?=
 =?utf-8?B?OTBuRUJ4cjRzK21jSGN3NzJXTGJ3NzUrQitCRjYxTDU4VkZjRFdQWUFaMlV2?=
 =?utf-8?B?T3UxWDBFUlVxcW1HQ1dnNUY0T0dEWFJjWlVtSmtwVXBPSVpkZXNpUkk1ZVdw?=
 =?utf-8?B?aVpVdldzSXdxMEgvbDE4WjFEQ0hWK3laNEwrclNmSG8vRXd0d0RKdlFMK0lz?=
 =?utf-8?B?YnFxSGNvZDlCT3pPaFJFOWtKa0d1S0tSWnlLUHI3dEFsVVVoZlFDZzRmeHNM?=
 =?utf-8?B?MW42NnlvYTFOV3VISHVxYXhuKzNiZHlsT3Fsb1l6M1lyYTdPRjhHcVAxSmxS?=
 =?utf-8?B?Snc0aEc0SFByemVPcEovL2VVNGxyaHFvVUZLRXRoZEFyQkErMDZ4a1VVQmFa?=
 =?utf-8?B?bnNWalVEejh3Y28wT3pnMkJkNnYwY3JZYjl1M3d5Q25BOHNCM0Z6SVZ6a1NW?=
 =?utf-8?B?VGh4SEw1UUhYZG1jckRQeVMwdkUrWVVoRlVMaW5uMmlmbnVYUW14Y25UTlNX?=
 =?utf-8?B?Z3VMMWlXaGtOOS9BZ3liM21FQnhIUzY5RzZZREdBaThFbmQ0Q2hjd0xFZHE2?=
 =?utf-8?Q?69iAzyOX/E8VgxVmhlB70eOrP?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67c5e006-0c5f-4746-b04f-08dab75a215a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 13:58:16.3220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MRjER1/TPVoj2VsXU+rQXxnFUytR5ISxMpgCu8akU9UwqFh6baOP1H/N3DtKUgaG7Ql8j0wMPkT1sMQeOtjeCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6972

On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote:
> On 25.10.2022 16:44, Roger Pau Monne wrote:
> > Writes to the BARs are ignored if memory decoding is enabled for the
> > device, and the same happen with ROM BARs if the write is an attempt
> > to change the position of the BAR without disabling it first.
> > 
> > The reason of ignoring such writes is a limitation in Xen, as it would
> > need to unmap the BAR, change the address, and remap the BAR at the
> > new position, which the current logic doesn't support.
> > 
> > Some devices however seem to (wrongly) have the memory decoding bit
> > hardcoded to enabled, and attempts to disable it don't get reflected
> > on the command register.
> > 
> > This causes issues for well behaved guests that disable memory
> > decoding and then try to size the BARs, as vPCI will think memory
> > decoding is still enabled and ignore the write.
> 
> Just to avoid misunderstandings: "guests" here includes Dom0? In such
> cases we typically prefer to say "domains". This then also affects
> the next (final) paragraph.

Right, will adjust.

> > --- a/xen/drivers/vpci/header.c
> > +++ b/xen/drivers/vpci/header.c
> > @@ -128,7 +128,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
> >      }
> >  
> >      if ( !rom_only )
> > +    {
> >          pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
> > +        header->bars_mapped = map;
> > +    }
> >      else
> >          ASSERT_UNREACHABLE();
> >  }
> > @@ -355,13 +358,13 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >  static void cf_check cmd_write(
> >      const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data)
> >  {
> > -    uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
> > +    struct vpci_header *header = data;
> >  
> >      /*
> >       * Let Dom0 play with all the bits directly except for the memory
> >       * decoding one.
> >       */
> > -    if ( (cmd ^ current_cmd) & PCI_COMMAND_MEMORY )
> > +    if ( header->bars_mapped != !!(cmd & PCI_COMMAND_MEMORY) )
> >          /*
> >           * Ignore the error. No memory has been added or removed from the p2m
> >           * (because the actual p2m changes are deferred in defer_map) and the
> > @@ -388,12 +391,12 @@ static void cf_check bar_write(
> >      else
> >          val &= PCI_BASE_ADDRESS_MEM_MASK;
> >  
> > -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
> > +    if ( bar->enabled )
> 
> In 3 of the 4 cases you use header->bars_mapped as replacement. Since it's
> not clear to me why you don't here, could you explain this to me? (I'm
> therefore undecided whether this is merely a cosmetic [consistency] issue.)

No, it's intended to use bar->enabled here rather than
header->bars_mapped.

It's possible to have header->bars_mapped == true, but bar->enabled ==
false if memory decoding is enabled, but this BAR specifically has
failed to be mapped in the guest p2m, which means dom0 is safe to move
it for what Xen cares (ie: it won't mess with p2m mappings because
there are none for the BAR).

We could be more strict and use header->bars_mapped, but I don't think
there's a need for it.

What about adding a comment with:

/*
 * Xen only cares whether the BAR is mapped into the p2m, so allow BAR
 * writes as long as the BAR is not mapped into the p2m.
 */

Otherwise I can switch to using header->bars_mapped if you think
that's clearer.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 14:06:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 14:06:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430609.682499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onh3P-0004m0-C1; Wed, 26 Oct 2022 14:06:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430609.682499; Wed, 26 Oct 2022 14:06:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onh3P-0004lt-9G; Wed, 26 Oct 2022 14:06:47 +0000
Received: by outflank-mailman (input) for mailman id 430609;
 Wed, 26 Oct 2022 14:06:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onh3O-0004ln-FH
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 14:06:46 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c733e72-5537-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 16:06:45 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8740.eurprd04.prod.outlook.com (2603:10a6:20b:42d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 14:06:43 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 14:06:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c733e72-5537-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PSyOJYNv6tUFK+RrNsrxi9mQYF9i8R6mNNLp6X4s+FCUsKopfv6ti7qNtOtQ7aTSR/AENmCFwtEIX0KXy2fDic40WKJyTlYyiJKWPL9QyJ9owzJP2Fmlf80JTJMOXIOSTpkTmcYSFDoEw0U+ydrILzVuoIVFgA7LHhIA506fLmqnK3qpGFqswkB75LHlxt+8sJy0g6pwbF34c3VyfzGILEzrkV9OCneEX2nT/9FUxmXFHa6+hXZq0yMNb4kq/MYjVF2Z/Hu5Bl+5fzCP2mUrEF/EN3j27pwlrEU8yBOEKKfnL55ckyE/g/+EssNEso4C7Mm8YjCx7seli14W7MRg/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QXq0m7jvoyekWseyL6Ho4aVMtVi5oA7iIXs0LHcyuUg=;
 b=GMJxaxiIxbBKnoqtuzU0902kjp4+PzMi14vB657I5HHBnUENq7HnuuVrSV3KMkNNbVTIFWrgEeq6H1b2qQAzr14tabxRtjm1TJSzIL5YFu1hbH1w68dXRAB5bSddd6gHF3b91JOswUcDTkI8D1/3iRVm8RE0TTt1ZvP+k9MCEo5xsQpqZu5envUmbT87IL4zCIaSQbO1pIZVA9Ylq+Fx1dAps56XSYUOU3y8XGQ0GxSj4lCCtqr+8isnLI0cQT7qids7d3nKmkUpBPrEc1eQ1aQNJgh3aQynG9N+nkk0pinoIgX1drXSM85KiJYlam+pEBuFZKsIlUTZ3mkqRWZUsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QXq0m7jvoyekWseyL6Ho4aVMtVi5oA7iIXs0LHcyuUg=;
 b=tJFx77Z8176UEiDNmRzurzFNkjsZtn7apBcHTel/y/qLgGw5deD38jplmEgKcIwTDkaWAdcIkn5C2Fxc8pnQGqLaKZEIFZ/jc8Yd6x6CeLxJhX2wk2pDYqLH3QDRcXSHdyaIJZddZUl1Ez8R2fFWV1WnJYhchlV9flxxWM1yGS8hthnpXZn38cOBAEQqw63+KRZXAlmx+IgUmZRwEpdBRQiBjmKm2h8ANVTNRW7V9OoeL1EHggyM9jE5uj+fr+1bNeaRj+mphjxnBUzKREvxrqlo9fmozyGGwULuY2SDz6+/ExXjAXAMl3p9KemXVEFmbrJUIfUqlvPnHkFEjtKNUg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <045428b7-9c4d-cbf6-3ca9-157c516399a9@suse.com>
Date: Wed, 26 Oct 2022 16:06:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR
 is mapped
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-6-roger.pau@citrix.com>
 <666377e8-fe58-bc9f-70ff-2e21d93c691f@suse.com>
 <Y1k88uhbSNdMvsa+@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1k88uhbSNdMvsa+@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P193CA0124.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::29) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8740:EE_
X-MS-Office365-Filtering-Correlation-Id: c4c48faf-3dfa-4e05-eda1-08dab75b4f50
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UHw9LsylyGwSZAWjPdX099MU7MHqe6Yr3nGZEnAPDrBXHfFnp1fWbYiX6Pf20Mt1Xf7M4X5GW2EgKGBWP5zNJaMWcYYTt2SpHAE2ok5bp+DrRSAR1/7NrxU0WdtnWnAVxDOkqKjeKG54N7VHPs/k9Vr3ysN5YYKcKkPbTDrFieeR5VZBQaGfDm/BYWLUJINYN7bJuC5RWhjyMFaql4lRUg57z6b8jhtaqbdHmXGvo02boU5adyBbU8hx4WhKhtGuTbYvQwIidLXOuSfkVSAXya6EQQ/QiSj/xbRYcNrvO+onNmitkFnILFsjkW1YsnA/QmWoLXnfIV78/huzmNye+kx0c4aVs8mtGRdiGzp88u71+6M14kL82Vl3CwV6VRIR6gnvgnevfUi74k0nhbVbyfYVV7HGS6ZeblncC6cQqb4ntuRDvdjJKH4migKhqV96BfbBw8TTy2AVxj1YF/RhxKUm27xmq3gglHsE8emqUdyLVvtxbK7l7QarMbCrLKCqGgjAl9IqLQLNO75yfq4WGiNlcnGHIbS0c0F2JfnaOcGdUXXw/NHSAqckKPvcPwjwquX6+Lg2fO8C31vJddv4tqlqfHAu798EQ6V6M7cDW5WxSFyLwPgBJDHVK4pwFEwUKP2Zz9TdBQvhY4js2ZuioAyUMtLfcpGHsOZWLPTWraKZgZduDBVB04Hy46UklekHRh0WyTad5lDGe0wY0/tCkSt1nicFb9UC7B5/OitFvY5RYHRwbOoUT8kW9WWgtaVP27g8iVf4wpMJA96/JvdhqO9aI/poT0Q25kMwuM/TESM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(136003)(39860400002)(346002)(366004)(451199015)(31686004)(41300700001)(5660300002)(186003)(66946007)(6916009)(4326008)(8676002)(36756003)(66476007)(86362001)(2906002)(31696002)(66556008)(316002)(478600001)(6486002)(38100700002)(8936002)(53546011)(6512007)(26005)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z2hzRW92RDA2dksrMURjbmJ4SU5vOVQ0eHlBRXhLTDljZ0JTL0R1K1lFV2RO?=
 =?utf-8?B?SVhGN3RsQlRxbTRLTVhZQjJEeGNTNHM3V2d2THRybjY1TXlnbVJwZjFPVXda?=
 =?utf-8?B?Zm1nY0huQ1RXdVlVdHhQcnNjMkZYeXJ4RjN2VVVtUW5sQ29RdDIrUXNBU1Bv?=
 =?utf-8?B?OEI4SVJNc2k5amoxZXFjNFNRQkhDODBDc3dJUUQ1WUFGQ3JsbTVjUnZCZFZI?=
 =?utf-8?B?RHUxc1RxWUhpT0RzWjk1alFic0pUcnlST3JxT2pRQlFmREZ1Y1hxVVg1aFFy?=
 =?utf-8?B?MTl1YitBZEY5L1Q4NVpiNGNDK1JTOVAwYk9odmV1Rlc3WUltajdNRFNOODAx?=
 =?utf-8?B?eDlZU1NSWWx6YjhPT0xRM2lSVGpQbDEzTDdjZXBFUVJkYnlkYlJsQWxQc0Q5?=
 =?utf-8?B?MGpUd3VwTWtwL1o2WndEUVE1SFI1WnJzN0xuM0NieVdBanU5Qnh5NFRtMWJy?=
 =?utf-8?B?amZWU2R4cTZpcTNkQ01VWXhqM1F6WUVIWnUwZFdWT0lBdkJweVAvRWxwSDdL?=
 =?utf-8?B?akJXaEgvVnM2TnNPcG02bUNQYmRGcHgyekJRZFBTTDZrZTBINWxRYTQ1WXpl?=
 =?utf-8?B?a1VQSzJVVVdtWU5BZVlhMjBTSmtsRE1ESEwyRmpUSmxDOHhUWnZpdVBmOHRl?=
 =?utf-8?B?YnRNT1ZTUFBPQ0NpdDRCTHpqQWt4U3JMTVhHS0NucS9pOUZabmtMcUlkWEJI?=
 =?utf-8?B?WWhZUm84K3dMSFRudUNsSzN4WGhrTjlsaVFVaG1UVGh2ZTBOTWw2V1RhYTRS?=
 =?utf-8?B?Nk4xS09RMHN1eWladHcvdXhRSXBVQ3ZwdHg1RUpBQzhNTlpqNmpFV0taMFFH?=
 =?utf-8?B?UmdkQWMvMEhPWFk1Ui9RVVR4cHJlT3NSV0pLYytUNVdiUno2Q0hQdlRqdzZ3?=
 =?utf-8?B?b0krclBwNDdvWDJoTDJDNVVwdnV3RlI4enBORXFHSGtmRitnb3FmYW8vT0Fk?=
 =?utf-8?B?SG1pN25oWUJFVG5jMnVkM2k3alltY0Z2Z0FOYUcxS2NaREszdWM5NUhSdzh0?=
 =?utf-8?B?Q2pBZkVJR0YwNnJVSU84aFVrZ1NncFhIY2t4RlNsUkVMRmRHQStZOGxUb2FH?=
 =?utf-8?B?VGdGSzJqL3ZwUWd4dXc2R0pBS1MxUmlmSGU1TE55YTBUcDBEeVZUMzNGNG5y?=
 =?utf-8?B?Tm1YZENScUJ1V0dLN3JRaWs0eDVPelVLaWEvYXZxcUtKNmdvUFVQc0VBbDd4?=
 =?utf-8?B?UTdYdWxjSjBIL3hSc2lLZUkzcFViRVF4azNranZPclBKSnAwRWlDWXluZ0h2?=
 =?utf-8?B?TjM2a2xGc25tWGpQYnFjOFprSU83YXV6SjE2Q3BxeEg1YXg3VXJsL09idGJz?=
 =?utf-8?B?dXhsOHdFRWYyLzJLOXhKZFFCS1B5MlZGWjhYMWoremtjMDg5MHcvV2JkbHFt?=
 =?utf-8?B?eHI0c2tvVVRjYXdLb1RXZVN2NUNNRjRzRUp6QU5JZUp3eVlHN3cvLytnS1R6?=
 =?utf-8?B?R2lMdlAwbHg0N3doa25sT3NZOFh5MWZ5SGovU1U3L1JRTzdjK3RGV0RBYUM2?=
 =?utf-8?B?T3Z4b1FUNk9XblZvMGhCQlhDVml1MzZsYThXNGtYRE5sTXM2eUt1azdaSnNR?=
 =?utf-8?B?K2R4eGpzZFc5MFpGbWJHazJSV0h3TGppbFhwSi92bFIyNkQ0WjE3NU1pdXRV?=
 =?utf-8?B?NC8xUWlyY09pV0VYWFVsVzZNbGxWUmZ3MXdLazEybEJvd3pnQitEVHlDN0lH?=
 =?utf-8?B?eGJqY2pyQzVKakYyMVBJck9aS2xRcFFhT3Via1ZNUlVQcUp1akpkeEpwK3hh?=
 =?utf-8?B?eklKNm8wazUyNGhEYUpjalhYd1JXcXBybWMrQkhNdmk0REVpNlRpM0hkVno2?=
 =?utf-8?B?REdhSzJ5SDEzMDJWUHluVUFyTytGZk94TlNudUxjR2twNDV3cWdpTlZjL2M5?=
 =?utf-8?B?TVFQT00zOXdWWEt5UE8rRGFpQ3dYcE9zMlRGNEJvbDBoSGYyeFh6ckdUaDNk?=
 =?utf-8?B?eVVnRUwxdEVmSUxzMERoazI2T1NOZkxMMEF4aDcwNVdGYWY0c0RSY2dhSnU2?=
 =?utf-8?B?VXJIU1ptemgrU0JSNzRCSGxYYXZOMTcvd0ErSmpxZFMzUzNSazYyQURlSkxY?=
 =?utf-8?B?WjBLK3FkbjA4Y2FmcXJMUWF5eEhqakdZUG05UlBvc01RemdaMjdKNFRvdmgz?=
 =?utf-8?Q?yr1FVdUp/y+SWEhPAphnw19ZD?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4c48faf-3dfa-4e05-eda1-08dab75b4f50
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 14:06:42.8207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /7hzbHZZFS3ptEnI9mNcN1mpYYgwqwwth3dT5iSrkwZ39eHqvHQCyRj+uGHUN0B78WoATVR8fvN2ZdCQqaxsNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8740

On 26.10.2022 15:58, Roger Pau Monné wrote:
> On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote:
>> On 25.10.2022 16:44, Roger Pau Monne wrote:
>>> @@ -388,12 +391,12 @@ static void cf_check bar_write(
>>>      else
>>>          val &= PCI_BASE_ADDRESS_MEM_MASK;
>>>  
>>> -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
>>> +    if ( bar->enabled )
>>
>> In 3 of the 4 cases you use header->bars_mapped as replacement. Since it's
>> not clear to me why you don't here, could you explain this to me? (I'm
>> therefore undecided whether this is merely a cosmetic [consistency] issue.)
> 
> No, it's intended to use bar->enabled here rather than
> header->bars_mapped.
> 
> It's possible to have header->bars_mapped == true, but bar->enabled ==
> false if memory decoding is enabled, but this BAR specifically has
> failed to be mapped in the guest p2m, which means dom0 is safe to move
> it for what Xen cares (ie: it won't mess with p2m mappings because
> there are none for the BAR).
> 
> We could be more strict and use header->bars_mapped, but I don't think
> there's a need for it.
> 
> What about adding a comment with:
> 
> /*
>  * Xen only cares whether the BAR is mapped into the p2m, so allow BAR
>  * writes as long as the BAR is not mapped into the p2m.
>  */
> 
> Otherwise I can switch to using header->bars_mapped if you think
> that's clearer.

It's not so much a matter of being clearer, but a matter of consistency:
Why does the same consideration not apply in rom_write()? In fact both
uses there are (already before the change) combined with further
conditions (checking header->rom_enabled and new_enabled). If the
inconsistency is on purpose (and perhaps necessary), I'd like to first
understand why that is before deciding what to do about it. A comment
like you suggest it _may_ be the route to go.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 14:10:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 14:10:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430613.682510 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onh6w-0006AT-SR; Wed, 26 Oct 2022 14:10:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430613.682510; Wed, 26 Oct 2022 14:10:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onh6w-0006AM-PC; Wed, 26 Oct 2022 14:10:26 +0000
Received: by outflank-mailman (input) for mailman id 430613;
 Wed, 26 Oct 2022 14:10:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onh6v-0006AC-Ih; Wed, 26 Oct 2022 14:10:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onh6v-0004QG-EO; Wed, 26 Oct 2022 14:10:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onh6v-00013t-4d; Wed, 26 Oct 2022 14:10:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onh6v-00062C-3q; Wed, 26 Oct 2022 14:10:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WRv+VBqnMn/8Pf0/pN0mSIkU6oW0/O3/ZAtkbIl25mQ=; b=VIbLpLEbXkS9qoC1m9cE/75kNT
	sF4wvMW3yc1WxEk4mjV9GIbpKqJwMB4s54iS7l+UEOemq8BuxaaMXcAazVMwb8xmxh/bXRPjrVPX9
	8EnrS4HO4t+yjiiOhD9c6vLkjLl+h8lG9c1DXl7y7kg6jtJXDHVrX/eMxlVZqMBOSd+k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174395-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174395: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1a2dcbdde82e3a5f1db9b2f4c48aa1aeba534fb2
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 14:10:25 +0000

flight 174395 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174395/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                1a2dcbdde82e3a5f1db9b2f4c48aa1aeba534fb2
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   18 days
Failing since        173470  2022-10-08 06:21:34 Z   18 days   26 attempts
Testing same since   174395  2022-10-25 08:27:36 Z    1 days    1 attempts

------------------------------------------------------------
1407 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 132718 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 14:25:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 14:25:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430620.682521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhKx-0007vw-8S; Wed, 26 Oct 2022 14:24:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430620.682521; Wed, 26 Oct 2022 14:24:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhKx-0007vp-4s; Wed, 26 Oct 2022 14:24:55 +0000
Received: by outflank-mailman (input) for mailman id 430620;
 Wed, 26 Oct 2022 14:24:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5DW6=23=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onhKv-0007vj-TV
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 14:24:54 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140059.outbound.protection.outlook.com [40.107.14.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f4043257-5539-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 16:24:51 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8836.eurprd04.prod.outlook.com (2603:10a6:20b:42f::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 14:24:49 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Wed, 26 Oct 2022
 14:24:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4043257-5539-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=coCrfAQjgqu8FNe34VpupCY7IT9zLFxD/eBmE0kudqMWCvFIyhMfzUAxm2cHBAf/NtrpuXLcrKX2qJRWPE9XqciZ2e7ALjwlGdDx4CEQH6EOZOvRKLRrpq+10DeLz/lKPEdEmp2vDXYchn/wjgpjz3NMl7jKcCdNUBvPbD6CAbt84hzBFKjLgnKjH+bmHCtBZqG3gkCGIC1/wzYSsLdGEh06cYXEMjVd1YA4FYsy3nshUkcRwFkHosOJxBWjB9xko3G7hZBTmCMpYhQAfAvAgYalNEHdNsq3br49Y9ijs0KqV/k6tasZAYu9K63pC8RuEC0tInZn/VeXyaO22TTuqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aWxrGAWAw0/X6LENbgHoP2IGgFGkCRf3WP3OUYrnITE=;
 b=i6+E0oGM1VcTOvN+94BjwdppQs1T0C6FiCb/59fMyl+8gbOZoG3duVzmxMCVr+eZpyf1c4Yi5rg195jLHLwFKNd3NX1MWAg5EiruVcm4iY9Az1Xf9eMwlcCZ5FP0nvtU2sX8bvdNXNeFtbr3FYtU+YYrytyh5baoRe8zZllbEfFUOiG6GhsJSjiDRXOxsHnN/u4pA8mFgqpMaQfM3Y4AhmOeI10b9B1NiVuCv3XdgTI5FD0F44YWvIDZEmYSFEBLJN4Zt2+OGdcQPIV485tOEjY/ChnCuXXfeTK1uDunqZegvFwJbDYzOEDnyeyO4fMSp611RT0sf23wySer1xHSHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aWxrGAWAw0/X6LENbgHoP2IGgFGkCRf3WP3OUYrnITE=;
 b=xirivownqJMpHWnDxoU73oI7Hf8fUrfLfumzHa9NYWL28ZwYP86n385oG/dfiBTo4Vpp1IUNmACUMuANhGatJ64Xo4Jfb6a3gauz6zJha8BW+MrNrYHsMiKlfua7zzoHMyd7yXdpmUackZTs1bDhWrt2z6TMRU/QCAcWQ/Vv/NohMIB9kG8bNyUPudRVNYuAOL39VDVPG1AoEdBWnTk1yTy7MxpDiCVAAuHpVQYiVN3yf2d1ja0//Ui+mXNwFUvkf69yls5RUfwLzB/oar7BjhY306IFUZqklkP1FISwfEMcF3iVHcm2um5SWehcndqo/Nm4Qs2jDMM/83IyZwxrCw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ed2b08ea-db8a-fca0-3583-ead23043ae0e@suse.com>
Date: Wed, 26 Oct 2022 16:24:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 2/4] tools/tests: Unit test for p2m pool size
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221026102018.4144-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0037.eurprd06.prod.outlook.com
 (2603:10a6:203:68::23) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8836:EE_
X-MS-Office365-Filtering-Correlation-Id: 6f194ee1-a6f3-41b4-9783-08dab75dd711
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SEU300JEUq20hr6dYMkiz7urWnXA9ZViDYuEfO9eOM2IqSB6B87FBd9bjTW9xN39fftpGPU3z7an5gX9aA7DWqNhwW6bG5zJaaBoMynPBqNzUaQV82hDYvPHMmXKqq0TbV1ozgxtnEDtMk6sanZRJzjjg+moMhAJrnR6lgw1SWzfvKHjDWh/nkgGgrhDZoQjgAqgkhnXo9hF9He18SiqVuBVU8nktC42/IgwTObIhTUoz070zvtD/l6Krlj1x1cN+GtBPsDqaSUBufU12R95y6f91zXWczIQRDmywq38NTxSiWqX9IgvGbX9qOo5pEHHI8nFqC6+a3FsmwJYAFQMfUK2+S4uTJg9famicul9mSB4MXHNHyKF2/tMVoXjKSp7QnPttLjl0oIKOUA2eHPEe0kdhYfqCJX75saB5FMtZG2G/2tIhQVbxLxXsIBsLxuROgID0HI89nAbM+pJoh1QroxH1Jg6PtZc8GjxRrViQmb7UICD/ijdOUdiqC1T+6mqH7ULQv5WYXEjaHkON//RO5gPKiZqhq2lowg4vBgjqc/Vn3T0HEG+Ti/a700u7qQ8EPYwlaCgCquR+/mDfRI80/Qy7KIuZuA/mTkdDJ8c3425C71dra+u3s1NGh0K5QKaG6YPOpd46kJgcuOoL568DDNtgUm7VdLKokEfYMxojyWgCBqW9zA9Zi7jql5FqwzP30Jr/Wp2R4xmy0w1SN0Vp9j7RlLP1iLqLLV4HibpJME2oWbzPxlRnW/kzxubnqA72RNZ4HYQMwf5yZ6watlYcK14+j2au5BYUOFDRobj2vw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199015)(66556008)(66476007)(66946007)(8676002)(36756003)(41300700001)(2906002)(4326008)(6486002)(8936002)(6916009)(54906003)(5660300002)(316002)(38100700002)(83380400001)(6506007)(31696002)(26005)(53546011)(86362001)(6512007)(186003)(2616005)(31686004)(7416002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUNoR0M0TnZxTkc5K0JQOUY0amQ4dG1rUnRhNjc5bkQ4WHRQbitxN212TmpN?=
 =?utf-8?B?c1k4MU5pTDJjdWFRZ3JZZ0Z2SzZCWm9XNk1kNGhXOHpQK1JyTHpScGRpY3ky?=
 =?utf-8?B?QnBadlFIenFaM2dHSWdvYnc5K08vN3N5VTBQSm1YYlVaQkgzeGZNL002MXBt?=
 =?utf-8?B?aHZ1Z1hDOEJqY2pHUVdxK1Q3QWNpVWV4ZDVyVlBUdUhqSldJTFlhemd4ZE1S?=
 =?utf-8?B?Mit5MFJQUlVKTEdtVFU5L0JtWEFrTVpqRXFhOGsxTVNvM2xxVVN0WGtSRlhF?=
 =?utf-8?B?Y0ZDbHByOWZtTTRoeUg1dE9MRHlsZ09NUTBrNWRJWVJ3NEtRaDNtZUQyYUx6?=
 =?utf-8?B?d3RKbkdkRURyMmtSVUVhVHIrT2pSZXFmb0pFa3VCR1BYT3B2UkUrRFBQbTRk?=
 =?utf-8?B?WXQ1UDZwQ1c2bHpWc29ZL2VoNnFzcVFKYUFBSCs0czk5dkQ5bVp4Mk1nZW1R?=
 =?utf-8?B?dzdFYVF3QTJxM29UZGRoRWg4RDlncm1HSncwOW9INUE5aWpseW5INU5vWFNm?=
 =?utf-8?B?ODIzTk4vNVJoR1RDcXR4U3NBeHVNOTlveTB6RFpUcXlOTWtxL1VnVkJVbkVS?=
 =?utf-8?B?SjRUYi9BSjZHaWxzNGl0MjViekd4T2hHbWp1Ny9IbWozdHVKL0RRWTdJbjZU?=
 =?utf-8?B?bnNCTnBWMy9sS3dYRDRES2grODRLLzRWQnplRkpYU3NpR2hraDNabFVrYm93?=
 =?utf-8?B?ZWRNTnRTVkNyTi9Ramp1L3FhU0NaNWdqdFZCM3V5aU1iRWNEYUFjZW91WXh4?=
 =?utf-8?B?RGU5dmkxN0ZENFBoRjRFR3hzQytPM1hhUjJLWkQzTWs0Q0RIL3FjS1pOR3JJ?=
 =?utf-8?B?akl3VEJobThWUHFMZG4vUWtXSmpaRlo3NmRGK0VmWlpIOHAzMXJoZm1lMXFt?=
 =?utf-8?B?ZXNBRFI2NTE2bUU1MWcrNVZyVkU1ckROT0N1Y2lGSDlyMVBzK3VYWFpjQktL?=
 =?utf-8?B?dDlIdEQ0OEpzaXVwQWpIZTJZYmNyZzhqa0RtUHBVc0U2bjFiUUZHaDFQL3JI?=
 =?utf-8?B?NmMxUTJCbHNOVkd3RkRtK2VGY2hiUW5sVHdDWnhMbEl3ekRna1h6TEZ6TlRT?=
 =?utf-8?B?ZEJvSWh2SDNOSU4rZS9KR1lGWnBjdlNXc2lVaFlzVUJKUWZDT3FQQ252UEVK?=
 =?utf-8?B?QWNQTitRNnZhcGhJdEh2RVlFSGpNaVVCejFMOWhEZ2NaWVNUSWlnNW85ZlFK?=
 =?utf-8?B?NFRFcU5tSHAwNS81dnBZOHJPSURHVTI0R1VYajkyQWJSV3N5M3RSekMrK3J0?=
 =?utf-8?B?K1F2VDBVUERobFYvcUw2ZXdSRWZUdFdIZHhqbDhlK3F5OE9FczNZcUNIdjhT?=
 =?utf-8?B?USswbmdTSzNmUUV5TE52UUNZeEdZZmJ0dzRocUE5WXRyNm43bzRpYktGV2Vp?=
 =?utf-8?B?eitSQ1F0MnZQQzErMUxJSlVObnhJQkU1N2xHOC80OVV5TndwRVJPRG1Qa3Vx?=
 =?utf-8?B?QU1pajdHdU40MitkTVFVR0lkRWFhVi9HQ1BWWHJPV2VqMTdFL1pXMlpJaFAr?=
 =?utf-8?B?WHg0OThzUWs4V0NEand2bHZZOC9NUWlXVFZweXdjdERoeFdJWkphZ2Fjb0Fa?=
 =?utf-8?B?S3lEU1F6QVRXcGhqa3lRM3VGZjAyRS9ERzk4ejJtVG5xR3BITk5WV212QXFB?=
 =?utf-8?B?ZGIrSlpFeGVJUVNkTGtYOUxrd2FIZ29wV3pwOS9OYjBvUGRERm5LWDFPNERD?=
 =?utf-8?B?THIwTWZ4UThLOHNieFdkRzJqcEdNRVRBOTM3SWVhVDlMMXJRdFFXbzBKa3Nt?=
 =?utf-8?B?YXcwVFNKdUlHc1FMSFEwRnhBaE5QOEZmM2NYZGtwQ0k1am4vS0FVbm1CL0R2?=
 =?utf-8?B?NElYYStreWJCNXJzZGZIV1hic1k4NDJoTUdCWjdRTk9hZ2R3NU9BZ01TaWVk?=
 =?utf-8?B?RHJHYVI3ZkN5azQ0ZjdrN1JWeDlINGhJcmhPYTRBdCtMSUtub2tBdXNLVFMz?=
 =?utf-8?B?SnkxNVoyYXdrWEI2MmpZZGw4Q1hTd2xiWmlLNkQzR1JXY0NxN3FkbXN6VGQx?=
 =?utf-8?B?a3R4aHdzcEs4cUZGMHIwUEhwMWhsVnhxaUJGTkZvSC94anpqWTd1Um9ESE9a?=
 =?utf-8?B?RTIrNC96ejFndDlCTGtVV293NVJZYm0vbnlhYk5lNkprbVlzUEh0Skp2Z2JT?=
 =?utf-8?Q?Vp3NV251AzOMXb9bpvoxspVFK?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f194ee1-a6f3-41b4-9783-08dab75dd711
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 14:24:49.5536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6nldW4ExYuChpY9VvZIaUR9Rk6iItX51p+uBfubLSpAYY/3W5Pg9fmuvyTARvb5tXvc0d7OLnTFCrArNSgO7SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8836

On 26.10.2022 12:20, Andrew Cooper wrote:
> --- /dev/null
> +++ b/tools/tests/p2m-pool/Makefile
> @@ -0,0 +1,42 @@
> +XEN_ROOT = $(CURDIR)/../../..
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +TARGET := test-p2m-pool
> +
> +.PHONY: all
> +all: $(TARGET)
> +
> +.PHONY: clean
> +clean:
> +	$(RM) -- *.o $(TARGET) $(DEPS_RM)
> +
> +.PHONY: distclean
> +distclean: clean
> +	$(RM) -- *~
> +
> +.PHONY: install
> +install: all
> +	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> +	$(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)
> +
> +.PHONY: uninstall
> +uninstall:
> +	$(RM) -- $(DESTDIR)$(LIBEXEC_BIN)/$(TARGET)
> +
> +CFLAGS += $(CFLAGS_xeninclude)
> +CFLAGS += $(CFLAGS_libxenctrl)
> +CFLAGS += $(CFLAGS_libxenforeginmemory)

Typo here or typo also elsewhere: CFLAGS_libxenforeignmemory? I
have to admit that I can't really spot where these variables are
populated. The place in Rules.mk that I could spot uses

 CFLAGS_libxen$(1) = $$(CFLAGS_xeninclude)

i.e. the expansion doesn't really depend on the library.

Apart from this looks okay to me, maybe apart from ...

> --- /dev/null
> +++ b/tools/tests/p2m-pool/test-p2m-pool.c
> @@ -0,0 +1,181 @@
> +#include <err.h>
> +#include <errno.h>
> +#include <inttypes.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <sys/mman.h>
> +
> +#include <xenctrl.h>
> +#include <xenforeignmemory.h>
> +#include <xengnttab.h>
> +#include <xen-tools/libs.h>
> +
> +static unsigned int nr_failures;
> +#define fail(fmt, ...)                          \
> +({                                              \
> +    nr_failures++;                              \
> +    (void)printf(fmt, ##__VA_ARGS__);           \
> +})
> +
> +static xc_interface *xch;
> +static uint32_t domid;
> +
> +static struct xen_domctl_createdomain create = {
> +    .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap,
> +    .max_vcpus = 1,
> +    .max_grant_frames = 1,
> +    .grant_opts = XEN_DOMCTL_GRANT_version(1),
> +
> +    .arch = {
> +#if defined(__x86_64__) || defined(__i386__)
> +        .emulation_flags = XEN_X86_EMU_LAPIC,
> +#endif
> +    },
> +};
> +
> +static uint64_t default_p2m_size_bytes =
> +#if defined(__x86_64__) || defined(__i386__)
> +    256 << 12; /* Only x86 HAP for now.  x86 Shadow broken. */

... this shadow related comment (the commit message could at least
say what's wrong there, to give a hint at what would need fixing to
remove this restriction) and ...

> +#elif defined (__arm__) || defined(__aarch64__)
> +    16 << 12;
> +#endif
> +
> +static void run_tests(void)
> +{
> +    xen_pfn_t physmap[] = { 0 };
> +    uint64_t size_bytes, old_size_bytes;
> +    int rc;
> +
> +    printf("Test default p2m mempool size\n");
> +
> +    rc = xc_get_p2m_mempool_size(xch, domid, &size_bytes);
> +    if ( rc )
> +        return fail("  Fail: get p2m mempool size: %d - %s\n",
> +                    errno, strerror(errno));
> +
> +    printf("P2M pool size %"PRIu64" bytes (%"PRIu64"kB, %"PRIu64"MB)\n",
> +           size_bytes, size_bytes >> 10, size_bytes >> 20);
> +
> +
> +    /*
> +     * Check that the domain has the expected default allocation size.  This
> +     * will fail if the logic in Xen is altered without an equivelent
> +     * adjustment here.
> +     */
> +    if ( size_bytes != default_p2m_size_bytes )
> +        return fail("  Fail: size %"PRIu64" != expected size %"PRIu64"\n",
> +                    size_bytes, default_p2m_size_bytes);
> +
> +
> +    printf("Test that allocate doesn't alter pool size\n");
> +
> +    /*
> +     * Populate the domain with some RAM.  This will cause more of the p2m
> +     * pool to be used.
> +     */
> +    old_size_bytes = size_bytes;
> +
> +    rc = xc_domain_setmaxmem(xch, domid, -1);
> +    if ( rc )
> +        return fail("  Fail: setmaxmem: : %d - %s\n",
> +                    errno, strerror(errno));
> +
> +    rc = xc_domain_populate_physmap_exact(xch, domid, 1, 0, 0, physmap);
> +    if ( rc )
> +        return fail("  Fail: populate physmap: %d - %s\n",
> +                    errno, strerror(errno));
> +
> +    /*
> +     * Re-get the p2m size.  Should not have changed as a consequence of
> +     * populate physmap.
> +     */
> +    rc = xc_get_p2m_mempool_size(xch, domid, &size_bytes);
> +    if ( rc )
> +        return fail("  Fail: get p2m mempool size: %d - %s\n",
> +                    errno, strerror(errno));
> +
> +    if ( old_size_bytes != size_bytes )
> +        return fail("  Fail: p2m mempool size changed %"PRIu64" => %"PRIu64"\n",
> +                    old_size_bytes, size_bytes);
> +
> +
> +
> +    printf("Test bad set size\n");
> +
> +    /*
> +     * Check that setting a non-page size results in failure.
> +     */
> +    rc = xc_set_p2m_mempool_size(xch, domid, size_bytes + 1);
> +    if ( rc != -1 || errno != EINVAL )
> +        return fail("  Fail: Bad set size: expected -1/EINVAL, got %d/%d - %s\n",
> +                    rc, errno, strerror(errno));
> +
> +
> +    printf("Test very large set size\n");
> +
> +    /*
> +     * Check that setting a large P2M size succeeds.  This is expecting to
> +     * trigger continuations.
> +     */
> +    rc = xc_set_p2m_mempool_size(xch, domid, 64 << 20);
> +    if ( rc )
> +        return fail("  Fail: Set size 64MB: %d - %s\n",
> +                    errno, strerror(errno));
> +
> +
> +    /*
> +     * Check that the reported size matches what set consumed.
> +     */
> +    rc = xc_get_p2m_mempool_size(xch, domid, &size_bytes);
> +    if ( rc )
> +        return fail("  Fail: get p2m mempool size: %d - %s\n",
> +                    errno, strerror(errno));
> +
> +    if ( size_bytes != 64 << 20 )
> +        return fail("  Fail: expected mempool size %u, got %"PRIu64"\n",
> +                    64 << 20, size_bytes);
> +}
> +
> +int main(int argc, char **argv)
> +{
> +    int rc;
> +
> +    printf("P2M Shadow memory pool tests\n");

... the question of why "Shadow" here.

Jan


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 14:34:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 14:34:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430624.682532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhU9-00019N-67; Wed, 26 Oct 2022 14:34:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430624.682532; Wed, 26 Oct 2022 14:34:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhU9-00019G-28; Wed, 26 Oct 2022 14:34:25 +0000
Received: by outflank-mailman (input) for mailman id 430624;
 Wed, 26 Oct 2022 14:34:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+8N7=23=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1onhU7-000199-3C
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 14:34:23 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2048.outbound.protection.outlook.com [40.107.22.48])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4708148f-553b-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 16:34:20 +0200 (CEST)
Received: from AS9PR06CA0151.eurprd06.prod.outlook.com (2603:10a6:20b:45c::8)
 by DB8PR08MB5531.eurprd08.prod.outlook.com (2603:10a6:10:11e::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 14:34:17 +0000
Received: from AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45c:cafe::6) by AS9PR06CA0151.outlook.office365.com
 (2603:10a6:20b:45c::8) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 14:34:17 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT064.mail.protection.outlook.com (100.127.140.127) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 14:34:17 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Wed, 26 Oct 2022 14:34:16 +0000
Received: from 8e4140fca469.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0793471A-D847-41E0-9F94-6E019753A093.1; 
 Wed, 26 Oct 2022 14:34:06 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e4140fca469.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 26 Oct 2022 14:34:06 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24)
 by AS4PR08MB7455.eurprd08.prod.outlook.com (2603:10a6:20b:4e6::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 14:33:57 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572]) by AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572%4]) with mapi id 15.20.5709.015; Wed, 26 Oct 2022
 14:33:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4708148f-553b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=hQ4FwAMKgdwZIE2jL+Zjk+8MnoUStrB0C4wdwYt0au8Wl3U0b6rX05XotzdHQyU7zGT3G2UajdBJ/gv0qOIaBnAFmekj/9thWDgweqxr64WRDzEKHihEwpaKwBVq477wLu2RPUDytVfQk/1rlC7tZd+8w0D7aCmV7N2ZYgFFwPTbeKGBMDVwthbVtjwvj0jAi1zW94SDs5FRZzJw/12IRlqYnVzimpG0wjbj6hcOF4Sp0epaYa5X/KDn5L5URXdDWv5BGVL6ovQ4QPX8xu8JzU5Qyblv6C6KH+asRuaqqmrs4C7HXePSz6rigYYqC3o1Ei6mL/K4ETsaBsVBEkJ4gA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yyC1lwX16FyUJf7K1KSdYHzBhBszsmJLjcTx4sBobV8=;
 b=H0dRx3HQTuL1WrGUnhWBQpCffbTSV0nsX2Sh5ozX5QOSFiyS8RON/OT1pk5bEV1Wec4tgGp2yAmfwKClx1EFcWI9MYmR9b0IFmN1QZydZxkQEs5SZ6rB4ppqGKHbtyS0gwS2A5cVfffjo0qgx+ykmeBaentD4MAp2lBCnO1ahbRXGIsf9/kyQwG3U/zUZI0LGWRhHKs3z45KRSrnWbtKEiPTnJLs9J+MKaxBpge7s2ecWFyOZqhYZgZWa/owv3lLI8oxM1pTHxFtZ3deEgJ+SKQoW99X3nW726O+3aSYJAPnfWNknqZb5p11WzLNbUg9JwgYk75t3TX7yf9My2FGOQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yyC1lwX16FyUJf7K1KSdYHzBhBszsmJLjcTx4sBobV8=;
 b=PQeLc5RCQiJmk9vlTz5cZzN27RtC4O8MD0SdoCqbOgx+ulJYTbYR4srbvs/kQbSz1Baboa4B4tawZOEZqGC96LGanIem4Z6CM9vEwEaYcHoKDTC6kWoSCyMTsTACE2J18W1R3L77VImTyMyL9SbCc3eEPeQ2OgcNFjEZCt1aPm8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: a0f2a8b3d4bc4047
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P0BAW+6+VSFoHm5tgNk2nAJ5kY8NccJfFhP9cI92v8K21q2lj9Sj9wr/VhshfP7KjKOda6yltofVjLtYLizE+rFJQ+zuylI021MuAHA1yHId44BnyUX1wif9vNrlQl1tZja6EJppSzl/9P7E44ssXw8CFM3vkGN0I82dvln74wBQW1y0IO7ffwp/FNzAj7MP62EZjQtvkgZwl47pxrmKUsyRm21U/0baQpR9oXYashJSozGEyMFdEZto9utw23lvDvRnyXlnSqYD/3tEtujJv2OmCHJAONrzr19sfM94yzoIBa7gI6H1j46eZXU24BOj2uAf/nX9dtsNBIPfyZ68bQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yyC1lwX16FyUJf7K1KSdYHzBhBszsmJLjcTx4sBobV8=;
 b=AV07Wq9fYyIXxji8R9DGmojAzHckT2H+zGtZRVmh/v/rJeqKYynZPcWumfi+epB5Mp/L4HlxBXmyoS/VCUDDVV6bam9gOJTys8fU8a11vcJY/GF6gYre0c9oRzu+LGmKV9xF+LjeFj1dCAonzWt8Rkgxm6qkWCmgNVA3QUyQDJ+yd+zSeApH2z1F+9ZKaaYDXsnjhj72e5RHX92iJdlef6Jca3l6U2pWLgkYR3oMOCPjR0WoXgFDYIZuTmR3U0iYonFo+bPWhfhAK6awsRjAsgVKMxlt2b2sE6AfdHSMFfd6VnFpnUdPDd7vvIycfE71YdVG5HtrD8grhhZqsDkXgw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yyC1lwX16FyUJf7K1KSdYHzBhBszsmJLjcTx4sBobV8=;
 b=PQeLc5RCQiJmk9vlTz5cZzN27RtC4O8MD0SdoCqbOgx+ulJYTbYR4srbvs/kQbSz1Baboa4B4tawZOEZqGC96LGanIem4Z6CM9vEwEaYcHoKDTC6kWoSCyMTsTACE2J18W1R3L77VImTyMyL9SbCc3eEPeQ2OgcNFjEZCt1aPm8=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index: AQHY6T1VjOHHQJGN7kyXeL6pAIKNMa4grXIAgAAQBQA=
Date: Wed, 26 Oct 2022 14:33:56 +0000
Message-ID: <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
In-Reply-To: <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7158:EE_|AS4PR08MB7455:EE_|AM7EUR03FT064:EE_|DB8PR08MB5531:EE_
X-MS-Office365-Filtering-Correlation-Id: d9e11b51-4137-4fd6-2298-08dab75f297a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 GPucFJhtTcEGFIsjNXiLtSRwIJiBwNkk1kniPPOZpUx/2Cq3tOr1coSiRxOWlLnXFFMFb/XNtdrnhNx3V6iyE9bi+QZ+vGR8DUXQOpgrGlThYVqmco44XtAZEtHCgfSCCzEaW4eIgtUa2qxQy7dV4EarPAs/3kdRo1tNkLCp0gHW28bkrV9g1o8t5tZi697j3jCMExAga1mXMNyXRT6Ksp1T0DpjaOcBb4WRod28KueO5NCcqsQrRUZC2Pgql10iqrLoB1Tbbf8vijWiHKYU0CIjtEmPVA/jMSI9DDlcwnIb4wI/0ZLscdFlaxHxMrm1eoBU0PdmvBfWoztA2VxfulbGSVP+y9duDbrJdHGEmD42QpPnTPc7RJW1OTJXatqNMiw6bPtzatpyytv/TdCsxzeBsv4nMA6Y0rU8KKhynFdqXz7XcN01cdDzzEIgof1oTTzCtO0dCRuI/AC758Y86ZvtWHfD1Prc7O2w7Q5phALkaOY2ZrOiuDPDQvGtm12VkEqFTwxg0LFgz0HHBssNUvW4o+GDi/FyKSDVDozP8MngBINu+gdtneaROcvkZkPlfJ+cI/cVfElmFnRhDxGunIMXU1Ey9J4cE3HCpFVqDzi3DIAcC3OXXtv/eEIUNyayhDigTZZY6QSDVKZNq9tkj7Gg++0Z8OYhvkn3U3Q3g8958kxavdaJjxRZ0ts/6gK+NuokuEvpNpvo1RoA38SyKmk/vavuEBeQeyfPK9tjVG21CGkMfoJr5B6Na46Y/jJFF9o1RjM80p+pRomEMuJ69mg3nSxCng09VmiWXSmXNbs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(451199015)(186003)(38070700005)(2616005)(83380400001)(2906002)(54906003)(71200400001)(6506007)(8676002)(33656002)(6916009)(6486002)(53546011)(478600001)(64756008)(26005)(316002)(66946007)(66446008)(66556008)(6512007)(66476007)(86362001)(36756003)(76116006)(4326008)(91956017)(5660300002)(7416002)(8936002)(122000001)(38100700002)(41300700001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <56D7E5D0FA73F94897E8BFB007433505@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7455
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a8221fe9-42e3-4219-0e7f-08dab75f1cfb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3XxMeIPNtfHt/QGSzfTpid89PL7GHSMzaKBwhL35akzxuQQ9QHdwWi0wW85YHOQZo6Zd3NTcdX53HE2d/zgOdCZd76lUUtuoWRzTacaQPGwIKZXMjQDDgmMBQ6KinpGDXX5ZWj2xR+vJLG/4U616J2TGgYM5myvIS72fbO/cLQ1W1YwoJQwPs/gXn4Z+hY3yg84LVYNpTlyYuOIVCE4WTlOqs/YNFmlUCXkjZFDV9m85Lb5fBUhF63Ie67dmHtQLqt+yluobFZASubx3CfD40hYs9s1bmCaKl8NU//TWQvQAjI2N7Zfcqr4NCIKqG4lnwcZ+QFUICGA8pbblRmRa3TmKMuPR9kxi3R9IzzyQv231hfp6xrs/gC+Kp9WlvrauyRb25aXLVdlUJ4aFfxifZcOgVS3QiMBmEk3fQ1oEZu5rVDE088Z+8hO6P9xpClF22aoZHfq2NZFdZh0L5SyYjnY+VC+CchnBX0JzthaGvW6mGgerXx/L8cy+nkbUUzCLCyxm4JJeWIB1M5YJiuyfaZm/LAgVLCIIJiIKJj8AX2+v+KW9HE707eRWZJx+RqC7wOCf1pyE2HNvrrKqkpqC2MHmSJ/0qyecY/Xqc4rcg6iTyO9c/CLsTT+sBLwMkhJO941hiG0sX+4cl5c4KF033uEI9sOs9N9LYDU/zQZg86hsJOVmjB3cRiZenlH4jwIM92OY5gsPEOAPCP1u+A2HyErFevluGcLWHFCO1snttfM0WuubaAc0/1q5c8gqrEsLGTZab2GHzaz95vthLIQ1/A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(86362001)(83380400001)(6486002)(478600001)(53546011)(54906003)(70586007)(36756003)(8676002)(4326008)(6512007)(26005)(6862004)(41300700001)(8936002)(5660300002)(47076005)(33656002)(40480700001)(82310400005)(107886003)(186003)(2906002)(70206006)(36860700001)(6506007)(40460700003)(356005)(336012)(2616005)(82740400003)(81166007)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 14:34:17.1367
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d9e11b51-4137-4fd6-2298-08dab75f297a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5531

SGkgSnVsaWVuLA0KDQo+IE9uIDI2IE9jdCAyMDIyLCBhdCAyOjM2IHBtLCBKdWxpZW4gR3JhbGwg
PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gMjYvMTAvMjAyMiAxNDox
NywgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBIaSBBbGwsDQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+
PiBBdCBBcm0sIHdlIHN0YXJ0ZWQgdG8gaW1wbGVtZW50IHRoZSBQT0MgdG8gc3VwcG9ydCAyIGxl
dmVscyBvZiBwYWdlIHRhYmxlcy9uZXN0ZWQgdHJhbnNsYXRpb24gaW4gU01NVXYzLg0KPj4gVG8g
c3VwcG9ydCBuZXN0ZWQgdHJhbnNsYXRpb24gZm9yIGd1ZXN0IE9TIFhlbiBuZWVkcyB0byBleHBv
c2UgdGhlIHZpcnR1YWwgSU9NTVUuIElmIHdlIHBhc3N0aHJvdWdoIHRoZQ0KPj4gZGV2aWNlIHRv
IHRoZSBndWVzdCB0aGF0IGlzIGJlaGluZCBhbiBJT01NVSBhbmQgdmlydHVhbCBJT01NVSBpcyBl
bmFibGVkIGZvciB0aGUgZ3Vlc3QgdGhlcmUgaXMgYSBuZWVkIHRvDQo+PiBhZGQgSU9NTVUgYmlu
ZGluZyBmb3IgdGhlIGRldmljZSBpbiB0aGUgcGFzc3Rocm91Z2ggbm9kZSBhcyBwZXIgWzFdLiBU
aGlzIGVtYWlsIGlzIHRvIGdldCBhbiBhZ3JlZW1lbnQgb24NCj4+IGhvdyB0byBhZGQgdGhlIElP
TU1VIGJpbmRpbmcgZm9yIGd1ZXN0IE9TLg0KPj4gQmVmb3JlIEkgd2lsbCBleHBsYWluIGhvdyB0
byBhZGQgdGhlIElPTU1VIGJpbmRpbmcgbGV0IG1lIGdpdmUgYSBicmllZiBvdmVydmlldyBvZiBo
b3cgd2Ugd2lsbCBhZGQgc3VwcG9ydCBmb3IgdmlydHVhbA0KPj4gSU9NTVUgb24gQXJtLiBJbiBv
cmRlciB0byBpbXBsZW1lbnQgdmlydHVhbCBJT01NVSBYZW4gbmVlZCBTTU1VdjMgTmVzdGVkIHRy
YW5zbGF0aW9uIHN1cHBvcnQuIFNNTVV2MyBoYXJkd2FyZQ0KPj4gc3VwcG9ydHMgdHdvIHN0YWdl
cyBvZiB0cmFuc2xhdGlvbi4gRWFjaCBzdGFnZSBvZiB0cmFuc2xhdGlvbiBjYW4gYmUgaW5kZXBl
bmRlbnRseSBlbmFibGVkLiBBbiBpbmNvbWluZyBhZGRyZXNzIGlzIGxvZ2ljYWxseQ0KPj4gdHJh
bnNsYXRlZCBmcm9tIFZBIHRvIElQQSBpbiBzdGFnZSAxLCB0aGVuIHRoZSBJUEEgaXMgaW5wdXQg
dG8gc3RhZ2UgMiB3aGljaCB0cmFuc2xhdGVzIHRoZSBJUEEgdG8gdGhlIG91dHB1dCBQQS4gU3Rh
Z2UgMSBpcw0KPj4gaW50ZW5kZWQgdG8gYmUgdXNlZCBieSBhIHNvZnR3YXJlIGVudGl0eSggR3Vl
c3QgT1MpIHRvIHByb3ZpZGUgaXNvbGF0aW9uIG9yIHRyYW5zbGF0aW9uIHRvIGJ1ZmZlcnMgd2l0
aGluIHRoZSBlbnRpdHksIGZvciBleGFtcGxlLA0KPj4gRE1BIGlzb2xhdGlvbiB3aXRoaW4gYW4g
T1MuIFN0YWdlIDIgaXMgaW50ZW5kZWQgdG8gYmUgYXZhaWxhYmxlIGluIHN5c3RlbXMgc3VwcG9y
dGluZyB0aGUgVmlydHVhbGl6YXRpb24gRXh0ZW5zaW9ucyBhbmQgaXMNCj4+IGludGVuZGVkIHRv
IHZpcnR1YWxpemUgZGV2aWNlIERNQSB0byBndWVzdCBWTSBhZGRyZXNzIHNwYWNlcy4gV2hlbiBi
b3RoIHN0YWdlIDEgYW5kIHN0YWdlIDIgYXJlIGVuYWJsZWQsIHRoZSB0cmFuc2xhdGlvbg0KPj4g
Y29uZmlndXJhdGlvbiBpcyBjYWxsZWQgbmVzdGluZy4NCj4+IFN0YWdlIDEgdHJhbnNsYXRpb24g
c3VwcG9ydCBpcyByZXF1aXJlZCB0byBwcm92aWRlIGlzb2xhdGlvbiBiZXR3ZWVuIGRpZmZlcmVu
dCBkZXZpY2VzIHdpdGhpbiB0aGUgZ3Vlc3QgT1MuIFhFTiBhbHJlYWR5IHN1cHBvcnRzDQo+PiBT
dGFnZSAyIHRyYW5zbGF0aW9uIGJ1dCB0aGVyZSBpcyBubyBzdXBwb3J0IGZvciBTdGFnZSAxIHRy
YW5zbGF0aW9uIGZvciBndWVzdHMuIFdlIHdpbGwgYWRkIHN1cHBvcnQgZm9yIGd1ZXN0cyB0byBj
b25maWd1cmUNCj4+IHRoZSBTdGFnZSAxIHRyYW5zaXRpb24gdmlhIHZpcnR1YWwgSU9NTVUuIFhF
TiB3aWxsIGVtdWxhdGUgdGhlIFNNTVUgaGFyZHdhcmUgYW5kIGV4cG9zZXMgdGhlIHZpcnR1YWwg
U01NVSB0byB0aGUgZ3Vlc3QuDQo+PiBHdWVzdCBjYW4gdXNlIHRoZSBuYXRpdmUgU01NVSBkcml2
ZXIgdG8gY29uZmlndXJlIHRoZSBzdGFnZSAxIHRyYW5zbGF0aW9uLiBXaGVuIHRoZSBndWVzdCBj
b25maWd1cmVzIHRoZSBTTU1VIGZvciBTdGFnZSAxLA0KPj4gWEVOIHdpbGwgdHJhcCB0aGUgYWNj
ZXNzIGFuZCBjb25maWd1cmUgdGhlIGhhcmR3YXJlIGFjY29yZGluZ2x5Lg0KPj4gTm93IGJhY2sg
dG8gdGhlIHF1ZXN0aW9uIG9mIGhvdyB3ZSBjYW4gYWRkIHRoZSBJT01NVSBiaW5kaW5nIGJldHdl
ZW4gdGhlIHZpcnR1YWwgSU9NTVUgYW5kIHRoZSBtYXN0ZXIgZGV2aWNlcyBzbyB0aGF0DQo+PiBn
dWVzdHMgY2FuIGNvbmZpZ3VyZSB0aGUgSU9NTVUgY29ycmVjdGx5LiBUaGUgc29sdXRpb24gdGhh
dCBJIGFtIHN1Z2dlc3RpbmcgaXMgYXMgYmVsb3c6DQo+PiBGb3IgZG9tMCwgd2hpbGUgaGFuZGxp
bmcgdGhlIERUIG5vZGUoaGFuZGxlX25vZGUoKSkgWGVuIHdpbGwgcmVwbGFjZSB0aGUgcGhhbmRs
ZSBpbiB0aGUgImlvbW11cyIgcHJvcGVydHkgd2l0aCB0aGUgdmlydHVhbA0KPj4gSU9NTVUgbm9k
ZSBwaGFuZGxlLg0KPiBCZWxvdywgeW91IHNhaWQgdGhhdCBlYWNoIElPTU1VcyBtYXkgaGF2ZSBh
IGRpZmZlcmVudCBJRCBzcGFjZS4gU28gc2hvdWxkbid0IHdlIGV4cG9zZSBvbmUgdklPTU1VIHBl
ciBwSU9NTVU/IElmIG5vdCwgaG93IGRvIHlvdSBleHBlY3QgdGhlIHVzZXIgdG8gc3BlY2lmeSB0
aGUgbWFwcGluZz8NCg0KWWVzIHlvdSBhcmUgcmlnaHQgd2UgbmVlZCB0byBjcmVhdGUgb25lIHZJ
T01NVSBwZXIgcElPTU1VIGZvciBkb20wLiBUaGlzIGFsc28gaGVscHMgaW4gdGhlIEFDUEkgY2Fz
ZQ0Kd2hlcmUgd2UgZG9u4oCZdCBuZWVkIHRvIG1vZGlmeSB0aGUgdGFibGVzIHRvIGRlbGV0ZSB0
aGUgcElPTU1VIGVudHJpZXMgYW5kIGNyZWF0ZSBvbmUgdklPTU1VLg0KSW4gdGhpcyBjYXNlLCBu
byBuZWVkIHRvIHJlcGxhY2UgdGhlIHBoYW5kbGUgYXMgWGVuIGNyZWF0ZSB0aGUgdklPTU1VIHdp
dGggdGhlIHNhbWUgcElPTU1VDQpwaGFuZGxlIGFuZCBzYW1lIGJhc2UgYWRkcmVzcy4NCg0KRm9y
IGRvbVUgZ3Vlc3RzIG9uZSB2SU9NTVUgcGVyIGd1ZXN0IHdpbGwgYmUgY3JlYXRlZC4NCg0KPiAN
Cj4+IEZvciBkb21VIGd1ZXN0cywgd2hlbiBwYXNzdGhyb3VnaCB0aGUgZGV2aWNlIHRvIHRoZSBn
dWVzdCBhcyBwZXIgWzJdLCAgYWRkIHRoZSBiZWxvdyBwcm9wZXJ0eSBpbiB0aGUgcGFydGlhbCBk
ZXZpY2UgdHJlZQ0KPj4gbm9kZSB0aGF0IGlzIHJlcXVpcmVkIHRvIGRlc2NyaWJlIHRoZSBnZW5l
cmljIGRldmljZSB0cmVlIGJpbmRpbmcgZm9yIElPTU1VcyBhbmQgdGhlaXIgbWFzdGVyKHMpDQo+
PiAiaW9tbXVzID0gPCAmbWFnaWNfcGhhbmRsZSAweHZNYXN0ZXJJRD4NCj4+IAnigKIgbWFnaWNf
cGhhbmRsZSB3aWxsIGJlIHRoZSBwaGFuZGxlICggdklPTU1VIHBoYW5kbGUgaW4geGwpICB0aGF0
IHdpbGwgYmUgZG9jdW1lbnRlZCBzbyB0aGF0IHRoZSB1c2VyIGNhbiBzZXQgdGhhdCBpbiBwYXJ0
aWFsIERUIG5vZGUgKDB4ZmRlYSkuDQo+IA0KPiBEb2VzIHRoaXMgbWVhbiBvbmx5IG9uZSBJT01N
VSB3aWxsIGJlIHN1cHBvcnRlZCBpbiB0aGUgZ3Vlc3Q/DQoNClllcy4NCg0KPiANCj4+IAnigKIg
dk1hc3RlcklEIHdpbGwgYmUgdGhlIHZpcnR1YWwgbWFzdGVyIElEIHRoYXQgdGhlIHVzZXIgd2ls
bCBwcm92aWRlLg0KPj4gVGhlIHBhcnRpYWwgZGV2aWNlIHRyZWUgd2lsbCBsb29rIGxpa2UgdGhp
czoNCj4+IC9kdHMtdjEvOw0KPj4gIC8gew0KPj4gICAgIC8qICMqY2VsbHMgYXJlIGhlcmUgdG8g
a2VlcCBEVEMgaGFwcHkgKi8NCj4+ICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4+ICAgICAj
c2l6ZS1jZWxscyA9IDwyPjsNCj4+ICAgICAgIGFsaWFzZXMgew0KPj4gICAgICAgICBuZXQgPSAm
bWFjMDsNCj4+ICAgICB9Ow0KPj4gICAgICAgcGFzc3Rocm91Z2ggew0KPj4gICAgICAgICBjb21w
YXRpYmxlID0gInNpbXBsZS1idXMiOw0KPj4gICAgICAgICByYW5nZXM7DQo+PiAgICAgICAgICNh
ZGRyZXNzLWNlbGxzID0gPDI+Ow0KPj4gICAgICAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4+ICAg
ICAgICAgbWFjMDogZXRoZXJuZXRAMTAwMDAwMDAgew0KPj4gICAgICAgICAgICAgY29tcGF0aWJs
ZSA9ICJjYWx4ZWRhLGhiLXhnbWFjIjsNCj4+ICAgICAgICAgICAgIHJlZyA9IDwwIDB4MTAwMDAw
MDAgMCAweDEwMDA+Ow0KPj4gICAgICAgICAgICAgaW50ZXJydXB0cyA9IDwwIDgwIDQgIDAgODEg
NCAgMCA4MiA0PjsNCj4+ICAgICAgICAgICAgaW9tbXVzID0gPDB4ZmRlYSAweDAxPjsNCj4+ICAg
ICAgICAgfTsNCj4+ICAgICB9Ow0KPj4gfTsNCj4+ICBJbiB4bC5jZmcgd2UgbmVlZCB0byBkZWZp
bmUgYSBuZXcgb3B0aW9uIHRvIGluZm9ybSBYZW4gYWJvdXQgdk1hc3RlcklkIHRvIHBNYXN0ZXJJ
ZCBtYXBwaW5nIGFuZCB0byB3aGljaCBJT01NVSBkZXZpY2UgdGhpcw0KPj4gdGhlIG1hc3RlciBk
ZXZpY2UgaXMgY29ubmVjdGVkIHNvIHRoYXQgWGVuIGNhbiBjb25maWd1cmUgdGhlIHJpZ2h0IElP
TU1VLiBUaGlzIGlzIHJlcXVpcmVkIGlmIHRoZSBzeXN0ZW0gaGFzIGRldmljZXMgdGhhdCBoYXZl
DQo+PiB0aGUgc2FtZSBtYXN0ZXIgSUQgYnV0IGJlaGluZCBhIGRpZmZlcmVudCBJT01NVS4NCj4g
DQo+IEluIHhsLmNmZywgd2UgYWxyZWFkeSBwYXNzIHRoZSBkZXZpY2UtdHJlZSBub2RlIHBhdGgg
dG8gcGFzc3Rocm91Z2guIFNvIFhlbiBzaG91bGQgYWxyZWFkeSBoYXZlIGFsbCB0aGUgaW5mb3Jt
YXRpb24gYWJvdXQgdGhlIElPTU1VIGFuZCBNYXN0ZXItSUQuIFNvIGl0IGRvZXNuJ3Qgc2VlbSBu
ZWNlc3NhcnkgZm9yIERldmljZS1UcmVlLg0KPiANCj4gRm9yIEFDUEksIEkgd291bGQgaGF2ZSBl
eHBlY3RlZCB0aGUgaW5mb3JtYXRpb24gdG8gYmUgZm91bmQgaW4gdGhlIElPUkVRLg0KPiANCj4g
U28gY2FuIHlvdSBhZGQgbW9yZSBjb250ZXh0IHdoeSB0aGlzIGlzIG5lY2Vzc2FyeSBmb3IgZXZl
cnlvbmU/DQoNCldlIGhhdmUgaW5mb3JtYXRpb24gZm9yIElPTU1VIGFuZCBNYXN0ZXItSUQgYnV0
IHdlIGRvbuKAmXQgaGF2ZSBpbmZvcm1hdGlvbiBmb3IgbGlua2luZyB2TWFzdGVyLUlEIHRvIHBN
YXN0ZXItSUQuDQpUaGUgZGV2aWNlIHRyZWUgbm9kZSB3aWxsIGJlIHVzZWQgdG8gYXNzaWduIHRo
ZSBkZXZpY2UgdG8gdGhlIGd1ZXN0IGFuZCBjb25maWd1cmUgdGhlIFN0YWdlLTIgdHJhbnNsYXRp
b24uIEd1ZXN0IHdpbGwgdXNlIHRoZQ0Kdk1hc3Rlci1JRCB0byBjb25maWd1cmUgdGhlIHZJT01N
VSBkdXJpbmcgYm9vdC4gWGVuIG5lZWRzIGluZm9ybWF0aW9uIHRvIGxpbmsgdk1hc3Rlci1JRCB0
byBwTWFzdGVyLUlEIHRvIGNvbmZpZ3VyZQ0KdGhlIGNvcnJlc3BvbmRpbmcgcElPTU1VLiBBcyBJ
IG1lbnRpb24gd2UgbmVlZCB2TWFzdGVyLUlEIGluIGNhc2UgYSBzeXN0ZW0gY291bGQgaGF2ZSAy
IGlkZW50aWNhbCBNYXN0ZXItSUQgYnV0DQplYWNoIG9uZSBjb25uZWN0ZWQgdG8gYSBkaWZmZXJl
bnQgU01NVSBhbmQgYXNzaWduZWQgdG8gdGhlIGd1ZXN0Lg0KDQo+IA0KPj4gIGlvbW11X2Rldmlk
X21hcCA9IFsg4oCcUE1BU1RFUl9JRFtAVk1BU1RFUl9JRF0sSU9NTVVfQkFTRV9BRERSRVNT4oCd
ICwg4oCcUE1BU1RFUl9JRFtAVk1BU1RFUl9JRF0sSU9NTVVfQkFTRV9BRERSRVNT4oCdXQ0KPj4g
CeKAoiBQTUFTVEVSX0lEIGlzIHRoZSBwaHlzaWNhbCBtYXN0ZXIgSUQgb2YgdGhlIGRldmljZSBm
cm9tIHRoZSBwaHlzaWNhbCBEVC4NCj4+IAnigKIgVk1BU1RFUl9JRCBpcyB0aGUgdmlydHVhbCBt
YXN0ZXIgSWQgdGhhdCB0aGUgdXNlciB3aWxsIGNvbmZpZ3VyZSBpbiB0aGUgcGFydGlhbCBkZXZp
Y2UgdHJlZS4NCj4+IAnigKIgSU9NTVVfQkFTRV9BRERSRVNTIGlzIHRoZSBiYXNlIGFkZHJlc3Mg
b2YgdGhlIHBoeXNpY2FsIElPTU1VIGRldmljZSB0byB3aGljaCB0aGlzIGRldmljZSBpcyBjb25u
ZWN0ZWQuDQo+IA0KPiBCZWxvdyB5b3UgZ2l2ZSBhbiBleGFtcGxlIGZvciBQbGF0Zm9ybSBkZXZp
Y2UuIEhvdyB3b3VsZCB0aGF0IGZpdCBpbiB0aGUgY29udGV4dCBvZiBQQ0kgcGFzc3Rocm91Z2g/
DQoNCkluIFBDSSBwYXNzdGhyb3VnaCBjYXNlLCB4bCB3aWxsIGNyZWF0ZSB0aGUgImlvbW11LW1h
cCIgcHJvcGVydHkgaW4gdnBjaSBob3N0IGJyaWRnZSBub2RlIHdpdGggcGhhbmRsZSB0byB2SU9N
TVUgbm9kZS4NCnZTTU1VdjMgbm9kZSB3aWxsIGJlIGNyZWF0ZWQgaW4geGwuDQoNCj4gDQo+PiAg
RXhhbXBsZTogTGV0J3Mgc2F5IHRoZSB1c2VyIHdhbnRzIHRvIGFzc2lnbiB0aGUgYmVsb3cgcGh5
c2ljYWwgZGV2aWNlIGluIERUIHRvIHRoZSBndWVzdC4NCj4+ICBpb21tdUA0ZjAwMDAwMCB7DQo+
PiAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJhcm0sc21tdS12MyI7DQo+PiAgICAgICAg
ICAgICAgCWludGVycnVwdHMgPSA8MHgwMCAweGU0IDB4ZjA0PjsNCj4+ICAgICAgICAgICAgICAg
ICBpbnRlcnJ1cHQtcGFyZW50ID0gPDB4MDE+Ow0KPj4gICAgICAgICAgICAgICAgICNpb21tdS1j
ZWxscyA9IDwweDAxPjsNCj4+ICAgICAgICAgICAgICAgICBpbnRlcnJ1cHQtbmFtZXMgPSAiY29t
YmluZWQiOw0KPj4gICAgICAgICAgICAgICAgIHJlZyA9IDwweDAwIDB4NGYwMDAwMDAgMHgwMCAw
eDQwMDAwPjsNCj4+ICAgICAgICAgICAgICAgICBwaGFuZGxlID0gPDB4ZmRlYj47DQo+PiAgICAg
ICAgICAgICAgICAgbmFtZSA9ICJpb21tdSI7DQo+PiB9Ow0KPiANCj4gU28gSSBndWVzcyB0aGlz
IG5vZGUgd2lsbCBiZSB3cml0dGVuIGJ5IFhlbi4gSG93IHdpbGwgeW91IHRoZSBjYXNlIHdoZXJl
IHRoZXJlIGFyZSBleHRyYSBwcm9wZXJ0eSB0byBhZGRlZCAoZS5nLiBkbWEtY29oZXJlbnQpPw0K
DQpJbiB0aGlzIGV4YW1wbGUgdGhpcyBpcyBwaHlzaWNhbCBJT01NVSBub2RlLiB2SU9NTVUgbm9k
ZSB3aWwgYmUgY3JlYXRlZCBieSB4bCBkdXJpbmcgZ3Vlc3QgY3JlYXRpb24uDQo+IA0KPj4gIHRl
c3RAMTAwMDAwMDAgew0KPj4gCWNvbXBhdGlibGUgPSAidmlvbW11LXRlc3TigJ07DQo+PiAJaW9t
bXVzID0gPDB4ZmRlYiAweDEwPjsNCj4gDQo+IEkgYW0gYSBiaXQgY29uZnVzZWQuIEhlcmUgeW91
IHVzZSAweGZkZWIgZm9yIHRoZSBwaGFuZGxlIGJ1dCBiZWxvdy4uLg0KDQpIZXJlIDB4ZmRlYiBp
cyB0aGUgcGh5c2ljYWwgSU9NTVUgbm9kZSBwaGFuZGxlLi4uDQo+IA0KPj4gCWludGVycnVwdHMg
PSA8MHgwMCAweGZmIDB4MDQ+Ow0KPj4gCXJlZyA9IDwweDAwIDB4MTAwMDAwMDAgMHgwMCAweDEw
MDA+Ow0KPj4gCW5hbWUgPSAidmlvbW11LXRlc3QiOw0KPj4gfTsNCj4+ICBUaGUgcGFydGlhbCBE
ZXZpY2UgdHJlZSBub2RlIHdpbGwgYmUgbGlrZSB0aGlzOg0KPj4gIC8gew0KPj4gICAgIC8qICMq
Y2VsbHMgYXJlIGhlcmUgdG8ga2VlcCBEVEMgaGFwcHkgKi8NCj4+ICAgICAjYWRkcmVzcy1jZWxs
cyA9IDwyPjsNCj4+ICAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4+ICAgICAgIHBhc3N0aHJvdWdo
IHsNCj4+ICAgICAgICAgY29tcGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsNCj4+ICAgICAgICAgcmFu
Z2VzOw0KPj4gICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4+ICAgICAgICAgI3NpemUt
Y2VsbHMgPSA8Mj47DQo+PiAJdGVzdEAxMDAwMDAwMCB7DQo+PiAgICAgICAgICAgICAJY29tcGF0
aWJsZSA9ICJ2aW9tbXUtdGVzdCI7DQo+PiAgICAgICAgICAgICAJcmVnID0gPDAgMHgxMDAwMDAw
MCAwIDB4MTAwMD47DQo+PiAgICAgICAgICAgICAJaW50ZXJydXB0cyA9IDwwIDgwIDQgIDAgODEg
NCAgMCA4MiA0PjsNCj4+ICAgICAgICAgICAgIAlpb21tdXMgPSA8MHhmZGVhIDB4MDE+Ow0KPiAN
Cj4gLi4uIHlvdSB1c2UgMHhmZGVhLiBEb2VzIHRoaXMgbWVhbiAneGwnIHdpbGwgcmV3cml0ZSB0
aGUgcGhhbmRsZT8NCg0KYnV0IGhlcmUgdXNlciBoYXMgdG8gc2V0IHRoZSDigJxpb21tdXPigJ0g
cHJvcGVydHkgd2l0aCBtYWdpYyBwaGFubGUgYXMgZXhwbGFpbmVkIGVhcmxpZXIuIDB4ZmRlYSBp
cyBtYWdpYyBwaGFuZGxlLiANCiANClJlZ2FyZHMsDQpSYWh1bA==


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 14:35:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 14:35:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430629.682543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhV9-0001sK-Iv; Wed, 26 Oct 2022 14:35:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430629.682543; Wed, 26 Oct 2022 14:35:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhV9-0001sD-FX; Wed, 26 Oct 2022 14:35:27 +0000
Received: by outflank-mailman (input) for mailman id 430629;
 Wed, 26 Oct 2022 14:35:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1onhV7-000199-4A
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 14:35:25 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b718542-553b-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 16:35:23 +0200 (CEST)
Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 10:35:19 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BLAPR03MB5441.namprd03.prod.outlook.com (2603:10b6:208:29d::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 14:35:17 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 14:35:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b718542-553b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666794923;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=s3LN7jfkCjVPkVJrbPic/KrRchDeZeU/tZ16ifrSZ94=;
  b=X4B7JhLSs3H3y8EdMu+GnDyitNIuvlQHftlxSl8svYHMrm+LO/tA23ex
   7Q19BMQuiN0+4fnU/OO38TSNzNYkarD6jxIP6Lq/yza9Gim8mub+dZMEk
   BX7QRC1kG9IXCtsUSKcNTLdLOcYL8cEo0BD5x6l6K/lZfDctgjXAK3PT3
   I=;
X-IronPort-RemoteIP: 104.47.58.102
X-IronPort-MID: 83572409
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: =?us-ascii?q?A9a23=3Aqml/KK6e5scL0R7U4vJOhwxR2vbMJbsYPyYv2?=
 =?us-ascii?q?y7IWF9r3B3vpq4Fd1GK4G3kQXS30eSpgp1EoPZiAVQHUe/D0aapk60v3sCUu?=
 =?us-ascii?q?UdL/wI0BmMmNcHtOe7tkvCNeR0f6obE3hsKKSTmK6UGtqj+I8vBeEJZhtfnh?=
 =?us-ascii?q?x2mQVP0YHGkXrmrzjc7BsBoLHWDA3KlBk6JUZnYJy91bmm8JBJX956/NMDGz?=
 =?us-ascii?q?FCn1DKk6wj8XmQF8Xhn+jpBEQ4HVXi5KqdjcfFH9Sh1k+Dhi0z5xuR4gEx7O?=
 =?us-ascii?q?fEr2mvebuGk0yXsxZ7siYYgiOkCSvh4pAWnCv5toqCiOyMf97tZDLJOs4hEG?=
 =?us-ascii?q?wov2apzRorCiSmdMm8lha+ef2QSTgN8whdAWv2AUow6rQVVKeJvf/fLd1Tzs?=
 =?us-ascii?q?qH4GFHU6JdsdH/NrXFKAQtsnRxSJYQE+3Sksyq2PwF1bkygQZ1OuaOu9wD6r?=
 =?us-ascii?q?GcP+m7yJUqYxq1Rn/xJNPlYpbwZjWBJgCkQpIBsn5CG+a0pO68gWfnnui7Kz?=
 =?us-ascii?q?/96xBCL2PbQbjsTNe0duJbF7zQG3VdMAAzZ+ezVn51etl0MWaoj7TkGI12wM?=
 =?us-ascii?q?/O0UuyqfypdEBbxsv4PAahuwcCAUW2YPhkUSNYSMgWAuq3uyVRBDzCi7FzZr?=
 =?us-ascii?q?x3wHUI+6dgO4D9kV7/WAUJKfM1BCUK2aUfdB/dmObzv1hA51rPil2IYgwlWS?=
 =?us-ascii?q?BIBweN1LrrV8wA9RCufvigz+ss4iQKSubzv11rNKFxrvtTOEnSEJTLAuI77w?=
 =?us-ascii?q?Rmmi7rjm0iXrfwOInZQFsIWl+vZomCAn5p1iXctDplPJSydm7qDGsSlt7R5a?=
 =?us-ascii?q?mEoToF7mOy0xzQ8ZR9JPu5mzb2uN/kEgZe0CwkMuN2yP8WgAzksqrIpwBxqG?=
 =?us-ascii?q?ld2OFVeFbf1ZBByJihYOseI0rMtQ0w2LNLsdcxcvb1eDJik8SbSfumhFJEgf?=
 =?us-ascii?q?ZW2XDIs8p83o7rog9tb7ymn0FpIgUuA5swRr0j0hdNZhGdbJo343siC/eB5v?=
 =?us-ascii?q?j7Ersvx2aRDQC1LVMgNgZeRY8BojIPq3aRiW0WMGXkMWgeQwBxo2hLXO15XX?=
 =?us-ascii?q?Q5jzXBqTDinP2t8T966/diKA1lO/q0f68KDGh3Net/GZr4Wl60Evm1mtCUp7?=
 =?us-ascii?q?GeuViA1PFHxGOpK14eSHCiTPoFvzdYcoJ5nAcGa634WxiblFW1rORdSFGAYH?=
 =?us-ascii?q?ge81Qi6Tj1l5md9KRIQQIrxEyOgr4gy4N7+LJnQAJe2fBjtejngmoDUrria4?=
 =?us-ascii?q?tMsT7B8G1MoOQr/Tend0AiY5buWfYR5FH//Yi35XLsOXNafyT2IIZ6l1p6Rx?=
 =?us-ascii?q?RzQhafhwu++s7AdoZMHtmJOdH8uT7Yst7+1ajrHOGNru6GhaMKNugI2dlj8g?=
 =?us-ascii?q?WfgA4iEa4RL4utvvCwWaPQdqyMdkZfPtt3AJEaOXa6LVdLvRULomowu/ZU/L?=
 =?us-ascii?q?mhRv1X115ut3rl2RARiBGrERPzcNn7mOG93AqWa4c6S+O2nEQBXrDtnuW1j6?=
 =?us-ascii?q?gJ5TQhGbHRxr6dJI+8FEu1YwzjbamO0v8u1Hl589mUpY5zDQ8SMtx7MxDPIx?=
 =?us-ascii?q?6c62egP/swxpqdVoeowNR7KaQEWcyMRxMTw+gGu6Y6ILlO924zLthcWzdS/t?=
 =?us-ascii?q?yc+TwbzUKZ+74ZgQ6TnALcrmIxXXhkp+avVlb2swygY4/72B+ekBz17VAGra?=
 =?us-ascii?q?OV8NYXA7glN7trmk9WJ8RuaBuEkkLpgRdkKgknN3EtJ6cWA6RHYLUR/UtS08?=
 =?us-ascii?q?v7NxiAFl2QKjhA0F9EWyaFuBVqf3aSfsjKC1zJhQaE+1TqeekLibhNOSXcC8?=
 =?us-ascii?q?dQ8/lPPxCZcttpFtrs4n711rrjjQpNepsj6DdWe/8zQZPI4F84NE65RS1hrS?=
 =?us-ascii?q?XxxO4LUeIUXr9lWQW2f2/Izbwo7Ms9mX8mmfc+KPG+H9leFsiQ59n0WZ42Z7?=
 =?us-ascii?q?OeGn5m+eTentprt7hYaHoT9fk0A1ExJaIHXMIe+fEGeUYMRKzuLW0iOHpm8X?=
 =?us-ascii?q?1dXqxe4asi54rnDXnW9jWFADJ8W6/4sFB3JmaEZc5RNIWsKxcqN20zsiHUHO?=
 =?us-ascii?q?gDSkv5xjiaYspBXiNki5nuyv5XaWEZj7nt1SCZaKXPUB+lIZIcjLZk0DJnaG?=
 =?us-ascii?q?Epjn2vepR8ERQAslpLhHmVrYi0fPSMl/wE55KJSvKIboJ+DQk53YKkbSwpWm?=
 =?us-ascii?q?wM2g50cKD0TLJBEYzm2w/ISOaLUBMVPfRz2i7+iJcTyqLeTLMjVV7j2OEcUS?=
 =?us-ascii?q?u3hPO9uW9m08XyWRbLTm89vf4iY5nzT1sNgzB6qomCIv0dSqBS6cjYI8BRTF?=
 =?us-ascii?q?sbucdgReWswar42Nabsg3TeBqqPade5Niqe6jqOD9t8DMchWbew/Mt8YzNlY?=
 =?us-ascii?q?/V/wKtqy/GNCvDAlzDNlSqyBjJLYsj8N15HCilzQcsN0y/g+dsMPzH73/HmF?=
 =?us-ascii?q?BnsNaZBGMDeOZ2L63+7XqCRnv71cgu1+yLiTMM694OgFhd88Cy0pOqv/7hxb?=
 =?us-ascii?q?Ls839Di6wa4Gja1xLerIGKY/g/Umm/VRx9RS9ofQkIHZ3knCu4D99XpD37KW?=
 =?us-ascii?q?+Et+uRs/sIu+eNA4kq9FlJQ8k1UzItwuzMIAx+2hQN/ZDn0hTtLNby5Jb+rm?=
 =?us-ascii?q?iVObKgB/PEfHNvl56Nv2k4bRRpRrSP+9quPsRsWwlPBl3/S/BKcZDBeOUgBw?=
 =?us-ascii?q?8Uz8DFhX/uk8RyGIZvJL/a86HRrdQUrYi3JkqSi/FTQ93Xd1VEZG3RP/DiOA?=
 =?us-ascii?q?pw+vvdh9+Qt0AmWLmbm5B3r6rdYKe4cPEs6ezs=3D?=
X-IronPort-AV: E=Sophos;i="5.95,215,1661832000"; 
   d="scan'208";a="83572409"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nociswfhVCYglUIgx7ZcEaZwwAYnntOoRB+LzaGtaTKGqAg/2L4blzDwt+ysawrGmnwHu6abvbiU26Ofgt9pIMmbmQYla9pcF5wlUsgu6qILl9B5kvoRWWxifEfTU/I+AtQroDe01h8P0j7onkdi5pDDb3jI48K2MIGivMAyED0OghxZPmxZ/R0aszFFW3hkofzjfTyakPfILxmmbFbpVUPGq3LrnoCKdAr6TJ7VJH/Iy6YbvQ7AuImoSFVKO4NYiGsepcJWIOY63BUhRrmHisKj+IccvF/c5w6eF/nLtZ/TAS4c4k56mIeBQTcd5R2NkEBEdtFaseZ7Plf8+02QMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s3LN7jfkCjVPkVJrbPic/KrRchDeZeU/tZ16ifrSZ94=;
 b=CPVrv1ZHfcritpNRTml+//xSBiIJnSNcnRr8+0GTQkQ3mld/jpdbpdlldN8tcGIlybo1re3ZLamOOUfV490QxDuwQnxbw9LHiLZG3aLxlfC2lxHuR2yTzwlokKZoXxUJ11w+9zQBepAzUTt5eOIbPSto7PyKTBFaXA6FHuZNusjVkpKWkIV1rPkxv/EsY82BgHPPs8p5T3Aa16VJ39+o6RvXxlj7j3awItO+C3ghEX5L7CzPA+P7sLFYUIwMYw86iV11BnfjpZ1wwbU7B7NM0IVUoTd3Z0OaY3NL+N8bLB8vXlPynHiEYesYN1r4pMhkXOaaUwkK3D5QT6LJQpgZFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s3LN7jfkCjVPkVJrbPic/KrRchDeZeU/tZ16ifrSZ94=;
 b=jDJLieRfZwKenXk217uZYsYZEAkeuD0tTq6J5hvXs9NfZQomc/46MuZhB1h8Up8jGUAeXGKo3+zzbupR5kcIXHrlEI8yukDBhkK+YpqpRQghpiqjnTE+tVup+W8P0cKfvpuqnUi1lulq3WCdxplBEyDSDxuXMFGNa9xos3+AjWE=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>, Anthony Perard
	<anthony.perard@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/4] tools/tests: Unit test for p2m pool size
Thread-Topic: [PATCH 2/4] tools/tests: Unit test for p2m pool size
Thread-Index: AQHY6SSi5WtbMu9SZEOaoatJ6oZrzK4gux2AgAAC7QA=
Date: Wed, 26 Oct 2022 14:35:17 +0000
Message-ID: <0a8de504-20b6-7b9a-a249-54911dd7c6df@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-3-andrew.cooper3@citrix.com>
 <ed2b08ea-db8a-fca0-3583-ead23043ae0e@suse.com>
In-Reply-To: <ed2b08ea-db8a-fca0-3583-ead23043ae0e@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5441:EE_
x-ms-office365-filtering-correlation-id: 6ac24179-b05f-499f-3b03-08dab75f4d2f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 w8kJZlNBKpH/TgoybErVvDejHpUbgfvwSGk5NNIaO5OaVakujOxcQiamLRJelX/Dk97/PwxXxl2zJ1+3qo7wlN+AH+czp+7s5ELUprncN9e4qJroB9dmYSqdZ4djAV7mug7k483t5onZ1x+nuFhj0EbJJ6cwaYpQZ4mZtklyX1VFJIDU0yfOF9/pqGGl7Zr0pKMOsxBlNhy9zRalT2p7GgfSFDKWEUlBeD/4zauc8fG5tUkOPyRaiyteMQ9fjP41oRVfNL1BHJueCz7ar0VKW/G1WZvySLFeMtVqs9GhyZDmUw3FvyEE3uo3vNCNNY++fCzNEFi5WQmCItrq7671T56aZn3s0lUMSvhpbl7FGnUBnwdSrPeGsnVdCqHiSsM0sdb5lyF9zndAdhJsIUXbKoYtojFb+f8W/fQOtS4AgA1MQ1k9FlMP34wCsNsLPQMlXq85XhtZ4OR/ORGCog8cVQCgvWjJscNF01PjjjT7ztkNn6okvrPY3Zd30lBFDO4HOJx3SgPYyDCG7rqFuGgZAP2/jvu74rlPzebpHZIxSARn2ig2UZgkXTcIZgMhOxqv4bOG3pGZlcv0Rl/FWYKE/z0H+UgI1lJAFaW98zU4JfdtBPsmuCwK/hbfltpZR72n+lcLvWDkpb+HaA3U2neVH8/+OC4LoBywOQ4vSG2YKsa6WAqaTmnERcyY/BiOQVRaDC3pobagnIayPRNQzNkI+p69+Zk5CRWHDGsFpS0nAkYByjdtNMQlIc6fMiRCbhhSiyNb6VDGVYKuRCdaqISssO3VPNDOeMYJX7u8PMaJCDiVHcQzfL1BPi8fKidG+VtrtvKRcLU74CfNmL8YGSCMGg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199015)(31686004)(36756003)(82960400001)(64756008)(122000001)(66556008)(66476007)(76116006)(66446008)(66946007)(5660300002)(8936002)(83380400001)(38070700005)(31696002)(38100700002)(6916009)(54906003)(316002)(186003)(2616005)(71200400001)(86362001)(6486002)(6512007)(478600001)(41300700001)(26005)(2906002)(53546011)(91956017)(6506007)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Nzh0SEtNeGZNTmF0LzdBTVdsSFdLS0lSeG9FUW0ySjM5K2U3VjFuNjdVRm9q?=
 =?utf-8?B?dmdxYUZqdnBZcU1CWmlRK3lOU2ZSRGlkU2VGc25iSW5UYlZPYW5VMmZaWDUz?=
 =?utf-8?B?NGNXZG9ia01lVGM4ZWxzSlNQQS92bkN3ZndaMENZTkRoNWZDcng5QVdFZFpP?=
 =?utf-8?B?d1g4SnN6ZUYrdWI3SXdFVDJaN215VlVQUDlBV3pCNzU5MjNjQWUweXRKc0ll?=
 =?utf-8?B?b0RnTldxbkQ0NUhhUnFBTVpRbk1ta1dpb0cvSWt3MjFCUktaYThoMWd5RGJD?=
 =?utf-8?B?a3REOFFtcWZlVXVkbXZndVZqcndnZlRxdStNZkN3bHVjajc5MTVEVjZlSEFG?=
 =?utf-8?B?Z2lPdFk5blB2RVVYRDN2aFl5Z0k1dWd5ZS8zVXBRQlBQaXoyNk5UY1RMNzdh?=
 =?utf-8?B?THpjazgvb3BscTlyUXQzYlNGalFzSGl2UHFwY2lac0xSYUV1RjRBVXFnbi81?=
 =?utf-8?B?dTZsNWRsWUVpOStvbDRadUF0UkRxZFRCT2lVdVlxam1mV1N1TkdxZlNLRE5P?=
 =?utf-8?B?RGtoTVBacU1nVWRENkg3RDl6eUpyeEk3OVFSRDdTcXI5MW55OGY1M055YnlP?=
 =?utf-8?B?blYxT1V2TG9HMFd3QnFKdi9SWXZ1VDFuc0p1UjFlSEZIUjRVZjhpR3c5WGlV?=
 =?utf-8?B?QmxrRlBjNmdhR2tLb2x5Z2ZibFBYcWpvSzFzVGhxbkdySVQ4NFBKOXVNVWhL?=
 =?utf-8?B?UTBXZ1dyTG1WdWNGbEY5elJQY3dHY21nVWhVRFJ3OEUwQklmOFFScG1sTTN4?=
 =?utf-8?B?Qy9YbGN2SWFaZzMrZEc5bE1pTkQydVVNNFVFdHNyVzExQjg4a2Z6ZzlRVnBK?=
 =?utf-8?B?UVdseWlUT29ZN093aGNCZ0h2ZTU0eEg3V3hNUy9QTm01TmIzODNUanRQUnZy?=
 =?utf-8?B?S1diWVA3K2VxRkhZeWxnMGJLVytJY2JQb3NoZVdMMyt4MjdyMXZmb3FRSklZ?=
 =?utf-8?B?empxRmpSUjFXNTVENmtTV1MwVzk4OUI3WkRWa2RXZE9KcGxORXlPdmF0dmZB?=
 =?utf-8?B?a0ZNVWx3Y0p6TWNXSUVxeXFQK2prTHlNVUh3OFE0NUdJOTA5aTBmaGxkaHdE?=
 =?utf-8?B?K0xRcSt6VkxUemJQeW1DMC81bDE0SHZoNkVacnJVQmNlL3RIZlFCTnVjaFRM?=
 =?utf-8?B?TmVHWFBJOXpQdHpCay9uYTloTVBCSEJNVzlCSGx2UTNaeWUvZ05jV3prZHYw?=
 =?utf-8?B?WlA3Q0Voa3RjaEFqZW5TWk4xN3pvZVRwMWRFbDMraDhwUmVJSEJQRFdLcVI2?=
 =?utf-8?B?Ti9mT29lYnhYbmNwaFViMURGY3R6Ym1XVllmL2RNWVozUjByU1Baem5VZkU3?=
 =?utf-8?B?dm1HZ05NU05WN1kxaXB1NGRxdUR4TjZZcVJ1d2NiQS9yUWc3Z3RWTXMrYTI0?=
 =?utf-8?B?Z0V2Y05zOFpISDZTWCtURkdWSU9VMG5uYllWM0JPMkttS1hvcE1ocjRZemFt?=
 =?utf-8?B?Q2VpQUkvYjM5SnZwOGhpT0RXZWdZL2ttWGppbUxGMEdRQThDbGVwK2ljN1Z1?=
 =?utf-8?B?cFVoUjdnNlZ5bkozTHJmZFZEMGlUaTkvNjdDelF1Y2lxWndJb0xqTWVlRWl6?=
 =?utf-8?B?UFdMci80NHBWR1dyNUxjT3JXcVpHRHJwZXNMSmQ2eWRvd085ejJTZEUvRm1k?=
 =?utf-8?B?MGJFc3lqRmdSKzYvY2ovZDRRVCtHc2pObXowUGg0ZGpQbis4dlBpUVUyNUNZ?=
 =?utf-8?B?cFBKeENWVGZIU2JDMENNWmt5QW5RdHNVVmFTNTJSdmNVT3pyRThibnRRVVBC?=
 =?utf-8?B?UUZ5dHVEWEdXeGZjV3Iyamd0YURPaC96S1V4VDJha1BWdEVudGs2ZGpOeGZ5?=
 =?utf-8?B?STFqUzFEQWVIZ2gxU2prTXJQdzNpS2drSzZzL2pBME1GY21MemRpenlYNFNw?=
 =?utf-8?B?c1JZM0syTlhBczVyYW5ndEtJNEc4MUQ2MTg1Zmtub2JpNWZyQUlHTEVsM3BF?=
 =?utf-8?B?VGxqVUE1V1pBY1ZRZ3RsekpBYXJvaHJEV2hKcWpuTTgxVFcvRzZKcmhxaita?=
 =?utf-8?B?NDhmdU13N0NZT0xPUG14MnZxVkJwa0kwTlhKTWQ4MnF4bGhYUXRTbDhFR2Jq?=
 =?utf-8?B?eXRoM3NqTGJEQldiVTdtL3VCMVplUjIvYUZQQmM2dlUzdHFsaDA4dzl0RDhn?=
 =?utf-8?Q?NozJ9da1AfpDF/DcOKeXW2B5b?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <E0161E22BBDE0749940CDCD54AA0BDD0@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac24179-b05f-499f-3b03-08dab75f4d2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 14:35:17.0751
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xwcojyEgbE1hZ7biyV9VwTvmjOFWF8kC2YzBCnXG4ZnlTnswa9TccuONFFz2rFxMrBfup8CiwcFq65jUn5gSTozAgjpyz+QetrWAwsgGlYo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5441

T24gMjYvMTAvMjAyMiAxNToyNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjEwLjIwMjIg
MTI6MjAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysgYi90
b29scy90ZXN0cy9wMm0tcG9vbC9NYWtlZmlsZQ0KPj4gQEAgLTAsMCArMSw0MiBAQA0KPj4gK1hF
Tl9ST09UID0gJChDVVJESVIpLy4uLy4uLy4uDQo+PiAraW5jbHVkZSAkKFhFTl9ST09UKS90b29s
cy9SdWxlcy5taw0KPj4gKw0KPj4gK1RBUkdFVCA6PSB0ZXN0LXAybS1wb29sDQo+PiArDQo+PiAr
LlBIT05ZOiBhbGwNCj4+ICthbGw6ICQoVEFSR0VUKQ0KPj4gKw0KPj4gKy5QSE9OWTogY2xlYW4N
Cj4+ICtjbGVhbjoNCj4+ICsJJChSTSkgLS0gKi5vICQoVEFSR0VUKSAkKERFUFNfUk0pDQo+PiAr
DQo+PiArLlBIT05ZOiBkaXN0Y2xlYW4NCj4+ICtkaXN0Y2xlYW46IGNsZWFuDQo+PiArCSQoUk0p
IC0tICp+DQo+PiArDQo+PiArLlBIT05ZOiBpbnN0YWxsDQo+PiAraW5zdGFsbDogYWxsDQo+PiAr
CSQoSU5TVEFMTF9ESVIpICQoREVTVERJUikkKExJQkVYRUNfQklOKQ0KPj4gKwkkKElOU1RBTExf
UFJPRykgJChUQVJHRVQpICQoREVTVERJUikkKExJQkVYRUNfQklOKQ0KPj4gKw0KPj4gKy5QSE9O
WTogdW5pbnN0YWxsDQo+PiArdW5pbnN0YWxsOg0KPj4gKwkkKFJNKSAtLSAkKERFU1RESVIpJChM
SUJFWEVDX0JJTikvJChUQVJHRVQpDQo+PiArDQo+PiArQ0ZMQUdTICs9ICQoQ0ZMQUdTX3hlbmlu
Y2x1ZGUpDQo+PiArQ0ZMQUdTICs9ICQoQ0ZMQUdTX2xpYnhlbmN0cmwpDQo+PiArQ0ZMQUdTICs9
ICQoQ0ZMQUdTX2xpYnhlbmZvcmVnaW5tZW1vcnkpDQo+IFR5cG8gaGVyZSBvciB0eXBvIGFsc28g
ZWxzZXdoZXJlOiBDRkxBR1NfbGlieGVuZm9yZWlnbm1lbW9yeT8gSQ0KPiBoYXZlIHRvIGFkbWl0
IHRoYXQgSSBjYW4ndCByZWFsbHkgc3BvdCB3aGVyZSB0aGVzZSB2YXJpYWJsZXMgYXJlDQo+IHBv
cHVsYXRlZC4gVGhlIHBsYWNlIGluIFJ1bGVzLm1rIHRoYXQgSSBjb3VsZCBzcG90IHVzZXMNCj4N
Cj4gIENGTEFHU19saWJ4ZW4kKDEpID0gJCQoQ0ZMQUdTX3hlbmluY2x1ZGUpDQo+DQo+IGkuZS4g
dGhlIGV4cGFuc2lvbiBkb2Vzbid0IHJlYWxseSBkZXBlbmQgb24gdGhlIGxpYnJhcnkuDQoNCkht
bS7CoCBJdCB3YXMgY29weSZwYXN0ZSBmcm9tIHRlc3QtcmVzb3VyY2UgYW5kIEkgZm9yZ290IHRv
IHRyaW0NCmZvcmVpZ25tZW1vcnksIGJ1dCBJIGd1ZXNzIEknbGwgbmVlZCB0byBnbyBhbmQgZml4
IHRoZSB0eXBvIGV2ZXJ5d2hlcmUuDQoNCj4NCj4gQXBhcnQgZnJvbSB0aGlzIGxvb2tzIG9rYXkg
dG8gbWUsIG1heWJlIGFwYXJ0IGZyb20gLi4uDQo+DQo+PiAtLS0gL2Rldi9udWxsDQo+PiArKysg
Yi90b29scy90ZXN0cy9wMm0tcG9vbC90ZXN0LXAybS1wb29sLmMNCj4+IEBAIC0wLDAgKzEsMTgx
IEBADQo+PiArI2luY2x1ZGUgPGVyci5oPg0KPj4gKyNpbmNsdWRlIDxlcnJuby5oPg0KPj4gKyNp
bmNsdWRlIDxpbnR0eXBlcy5oPg0KPj4gKyNpbmNsdWRlIDxzdGRpby5oPg0KPj4gKyNpbmNsdWRl
IDxzdHJpbmcuaD4NCj4+ICsjaW5jbHVkZSA8c3lzL21tYW4uaD4NCj4+ICsNCj4+ICsjaW5jbHVk
ZSA8eGVuY3RybC5oPg0KPj4gKyNpbmNsdWRlIDx4ZW5mb3JlaWdubWVtb3J5Lmg+DQo+PiArI2lu
Y2x1ZGUgPHhlbmdudHRhYi5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4tdG9vbHMvbGlicy5oPg0KPj4g
Kw0KPj4gK3N0YXRpYyB1bnNpZ25lZCBpbnQgbnJfZmFpbHVyZXM7DQo+PiArI2RlZmluZSBmYWls
KGZtdCwgLi4uKSAgICAgICAgICAgICAgICAgICAgICAgICAgXA0KPj4gKyh7ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4+ICsgICAgbnJfZmFpbHVyZXMr
KzsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+PiArICAgICh2b2lkKXByaW50Zihm
bXQsICMjX19WQV9BUkdTX18pOyAgICAgICAgICAgXA0KPj4gK30pDQo+PiArDQo+PiArc3RhdGlj
IHhjX2ludGVyZmFjZSAqeGNoOw0KPj4gK3N0YXRpYyB1aW50MzJfdCBkb21pZDsNCj4+ICsNCj4+
ICtzdGF0aWMgc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluIGNyZWF0ZSA9IHsNCj4+ICsg
ICAgLmZsYWdzID0gWEVOX0RPTUNUTF9DREZfaHZtIHwgWEVOX0RPTUNUTF9DREZfaGFwLA0KPj4g
KyAgICAubWF4X3ZjcHVzID0gMSwNCj4+ICsgICAgLm1heF9ncmFudF9mcmFtZXMgPSAxLA0KPj4g
KyAgICAuZ3JhbnRfb3B0cyA9IFhFTl9ET01DVExfR1JBTlRfdmVyc2lvbigxKSwNCj4+ICsNCj4+
ICsgICAgLmFyY2ggPSB7DQo+PiArI2lmIGRlZmluZWQoX194ODZfNjRfXykgfHwgZGVmaW5lZChf
X2kzODZfXykNCj4+ICsgICAgICAgIC5lbXVsYXRpb25fZmxhZ3MgPSBYRU5fWDg2X0VNVV9MQVBJ
QywNCj4+ICsjZW5kaWYNCj4+ICsgICAgfSwNCj4+ICt9Ow0KPj4gKw0KPj4gK3N0YXRpYyB1aW50
NjRfdCBkZWZhdWx0X3AybV9zaXplX2J5dGVzID0NCj4+ICsjaWYgZGVmaW5lZChfX3g4Nl82NF9f
KSB8fCBkZWZpbmVkKF9faTM4Nl9fKQ0KPj4gKyAgICAyNTYgPDwgMTI7IC8qIE9ubHkgeDg2IEhB
UCBmb3Igbm93LiAgeDg2IFNoYWRvdyBicm9rZW4uICovDQo+IC4uLiB0aGlzIHNoYWRvdyByZWxh
dGVkIGNvbW1lbnQgKHRoZSBjb21taXQgbWVzc2FnZSBjb3VsZCBhdCBsZWFzdA0KPiBzYXkgd2hh
dCdzIHdyb25nIHRoZXJlLCB0byBnaXZlIGEgaGludCBhdCB3aGF0IHdvdWxkIG5lZWQgZml4aW5n
IHRvDQo+IHJlbW92ZSB0aGlzIHJlc3RyaWN0aW9uKSBhbmQgLi4uDQoNClRoYXQgd2FzIGluIHJl
ZmVyZW5jZSB0byB0aGUgUFYgaXNzdWUuwqAgV2lsbCBmb2xsb3cgaXQgdXAgb24gcGF0Y2ggMQ0K
d2hlcmUgdGhlcmUncyBtb3JlIGNvbnRleHQuDQoNCj4NCj4+ICsjZWxpZiBkZWZpbmVkIChfX2Fy
bV9fKSB8fCBkZWZpbmVkKF9fYWFyY2g2NF9fKQ0KPj4gKyAgICAxNiA8PCAxMjsNCj4+ICsjZW5k
aWYNCj4+ICsNCj4+ICtzdGF0aWMgdm9pZCBydW5fdGVzdHModm9pZCkNCj4+ICt7DQo+PiArICAg
IHhlbl9wZm5fdCBwaHlzbWFwW10gPSB7IDAgfTsNCj4+ICsgICAgdWludDY0X3Qgc2l6ZV9ieXRl
cywgb2xkX3NpemVfYnl0ZXM7DQo+PiArICAgIGludCByYzsNCj4+ICsNCj4+ICsgICAgcHJpbnRm
KCJUZXN0IGRlZmF1bHQgcDJtIG1lbXBvb2wgc2l6ZVxuIik7DQo+PiArDQo+PiArICAgIHJjID0g
eGNfZ2V0X3AybV9tZW1wb29sX3NpemUoeGNoLCBkb21pZCwgJnNpemVfYnl0ZXMpOw0KPj4gKyAg
ICBpZiAoIHJjICkNCj4+ICsgICAgICAgIHJldHVybiBmYWlsKCIgIEZhaWw6IGdldCBwMm0gbWVt
cG9vbCBzaXplOiAlZCAtICVzXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgZXJybm8sIHN0
cmVycm9yKGVycm5vKSk7DQo+PiArDQo+PiArICAgIHByaW50ZigiUDJNIHBvb2wgc2l6ZSAlIlBS
SXU2NCIgYnl0ZXMgKCUiUFJJdTY0ImtCLCAlIlBSSXU2NCJNQilcbiIsDQo+PiArICAgICAgICAg
ICBzaXplX2J5dGVzLCBzaXplX2J5dGVzID4+IDEwLCBzaXplX2J5dGVzID4+IDIwKTsNCj4+ICsN
Cj4+ICsNCj4+ICsgICAgLyoNCj4+ICsgICAgICogQ2hlY2sgdGhhdCB0aGUgZG9tYWluIGhhcyB0
aGUgZXhwZWN0ZWQgZGVmYXVsdCBhbGxvY2F0aW9uIHNpemUuICBUaGlzDQo+PiArICAgICAqIHdp
bGwgZmFpbCBpZiB0aGUgbG9naWMgaW4gWGVuIGlzIGFsdGVyZWQgd2l0aG91dCBhbiBlcXVpdmVs
ZW50DQo+PiArICAgICAqIGFkanVzdG1lbnQgaGVyZS4NCj4+ICsgICAgICovDQo+PiArICAgIGlm
ICggc2l6ZV9ieXRlcyAhPSBkZWZhdWx0X3AybV9zaXplX2J5dGVzICkNCj4+ICsgICAgICAgIHJl
dHVybiBmYWlsKCIgIEZhaWw6IHNpemUgJSJQUkl1NjQiICE9IGV4cGVjdGVkIHNpemUgJSJQUkl1
NjQiXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgc2l6ZV9ieXRlcywgZGVmYXVsdF9wMm1f
c2l6ZV9ieXRlcyk7DQo+PiArDQo+PiArDQo+PiArICAgIHByaW50ZigiVGVzdCB0aGF0IGFsbG9j
YXRlIGRvZXNuJ3QgYWx0ZXIgcG9vbCBzaXplXG4iKTsNCj4+ICsNCj4+ICsgICAgLyoNCj4+ICsg
ICAgICogUG9wdWxhdGUgdGhlIGRvbWFpbiB3aXRoIHNvbWUgUkFNLiAgVGhpcyB3aWxsIGNhdXNl
IG1vcmUgb2YgdGhlIHAybQ0KPj4gKyAgICAgKiBwb29sIHRvIGJlIHVzZWQuDQo+PiArICAgICAq
Lw0KPj4gKyAgICBvbGRfc2l6ZV9ieXRlcyA9IHNpemVfYnl0ZXM7DQo+PiArDQo+PiArICAgIHJj
ID0geGNfZG9tYWluX3NldG1heG1lbSh4Y2gsIGRvbWlkLCAtMSk7DQo+PiArICAgIGlmICggcmMg
KQ0KPj4gKyAgICAgICAgcmV0dXJuIGZhaWwoIiAgRmFpbDogc2V0bWF4bWVtOiA6ICVkIC0gJXNc
biIsDQo+PiArICAgICAgICAgICAgICAgICAgICBlcnJubywgc3RyZXJyb3IoZXJybm8pKTsNCj4+
ICsNCj4+ICsgICAgcmMgPSB4Y19kb21haW5fcG9wdWxhdGVfcGh5c21hcF9leGFjdCh4Y2gsIGRv
bWlkLCAxLCAwLCAwLCBwaHlzbWFwKTsNCj4+ICsgICAgaWYgKCByYyApDQo+PiArICAgICAgICBy
ZXR1cm4gZmFpbCgiICBGYWlsOiBwb3B1bGF0ZSBwaHlzbWFwOiAlZCAtICVzXG4iLA0KPj4gKyAg
ICAgICAgICAgICAgICAgICAgZXJybm8sIHN0cmVycm9yKGVycm5vKSk7DQo+PiArDQo+PiArICAg
IC8qDQo+PiArICAgICAqIFJlLWdldCB0aGUgcDJtIHNpemUuICBTaG91bGQgbm90IGhhdmUgY2hh
bmdlZCBhcyBhIGNvbnNlcXVlbmNlIG9mDQo+PiArICAgICAqIHBvcHVsYXRlIHBoeXNtYXAuDQo+
PiArICAgICAqLw0KPj4gKyAgICByYyA9IHhjX2dldF9wMm1fbWVtcG9vbF9zaXplKHhjaCwgZG9t
aWQsICZzaXplX2J5dGVzKTsNCj4+ICsgICAgaWYgKCByYyApDQo+PiArICAgICAgICByZXR1cm4g
ZmFpbCgiICBGYWlsOiBnZXQgcDJtIG1lbXBvb2wgc2l6ZTogJWQgLSAlc1xuIiwNCj4+ICsgICAg
ICAgICAgICAgICAgICAgIGVycm5vLCBzdHJlcnJvcihlcnJubykpOw0KPj4gKw0KPj4gKyAgICBp
ZiAoIG9sZF9zaXplX2J5dGVzICE9IHNpemVfYnl0ZXMgKQ0KPj4gKyAgICAgICAgcmV0dXJuIGZh
aWwoIiAgRmFpbDogcDJtIG1lbXBvb2wgc2l6ZSBjaGFuZ2VkICUiUFJJdTY0IiA9PiAlIlBSSXU2
NCJcbiIsDQo+PiArICAgICAgICAgICAgICAgICAgICBvbGRfc2l6ZV9ieXRlcywgc2l6ZV9ieXRl
cyk7DQo+PiArDQo+PiArDQo+PiArDQo+PiArICAgIHByaW50ZigiVGVzdCBiYWQgc2V0IHNpemVc
biIpOw0KPj4gKw0KPj4gKyAgICAvKg0KPj4gKyAgICAgKiBDaGVjayB0aGF0IHNldHRpbmcgYSBu
b24tcGFnZSBzaXplIHJlc3VsdHMgaW4gZmFpbHVyZS4NCj4+ICsgICAgICovDQo+PiArICAgIHJj
ID0geGNfc2V0X3AybV9tZW1wb29sX3NpemUoeGNoLCBkb21pZCwgc2l6ZV9ieXRlcyArIDEpOw0K
Pj4gKyAgICBpZiAoIHJjICE9IC0xIHx8IGVycm5vICE9IEVJTlZBTCApDQo+PiArICAgICAgICBy
ZXR1cm4gZmFpbCgiICBGYWlsOiBCYWQgc2V0IHNpemU6IGV4cGVjdGVkIC0xL0VJTlZBTCwgZ290
ICVkLyVkIC0gJXNcbiIsDQo+PiArICAgICAgICAgICAgICAgICAgICByYywgZXJybm8sIHN0cmVy
cm9yKGVycm5vKSk7DQo+PiArDQo+PiArDQo+PiArICAgIHByaW50ZigiVGVzdCB2ZXJ5IGxhcmdl
IHNldCBzaXplXG4iKTsNCj4+ICsNCj4+ICsgICAgLyoNCj4+ICsgICAgICogQ2hlY2sgdGhhdCBz
ZXR0aW5nIGEgbGFyZ2UgUDJNIHNpemUgc3VjY2VlZHMuICBUaGlzIGlzIGV4cGVjdGluZyB0bw0K
Pj4gKyAgICAgKiB0cmlnZ2VyIGNvbnRpbnVhdGlvbnMuDQo+PiArICAgICAqLw0KPj4gKyAgICBy
YyA9IHhjX3NldF9wMm1fbWVtcG9vbF9zaXplKHhjaCwgZG9taWQsIDY0IDw8IDIwKTsNCj4+ICsg
ICAgaWYgKCByYyApDQo+PiArICAgICAgICByZXR1cm4gZmFpbCgiICBGYWlsOiBTZXQgc2l6ZSA2
NE1COiAlZCAtICVzXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgZXJybm8sIHN0cmVycm9y
KGVycm5vKSk7DQo+PiArDQo+PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIENoZWNrIHRoYXQg
dGhlIHJlcG9ydGVkIHNpemUgbWF0Y2hlcyB3aGF0IHNldCBjb25zdW1lZC4NCj4+ICsgICAgICov
DQo+PiArICAgIHJjID0geGNfZ2V0X3AybV9tZW1wb29sX3NpemUoeGNoLCBkb21pZCwgJnNpemVf
Ynl0ZXMpOw0KPj4gKyAgICBpZiAoIHJjICkNCj4+ICsgICAgICAgIHJldHVybiBmYWlsKCIgIEZh
aWw6IGdldCBwMm0gbWVtcG9vbCBzaXplOiAlZCAtICVzXG4iLA0KPj4gKyAgICAgICAgICAgICAg
ICAgICAgZXJybm8sIHN0cmVycm9yKGVycm5vKSk7DQo+PiArDQo+PiArICAgIGlmICggc2l6ZV9i
eXRlcyAhPSA2NCA8PCAyMCApDQo+PiArICAgICAgICByZXR1cm4gZmFpbCgiICBGYWlsOiBleHBl
Y3RlZCBtZW1wb29sIHNpemUgJXUsIGdvdCAlIlBSSXU2NCJcbiIsDQo+PiArICAgICAgICAgICAg
ICAgICAgICA2NCA8PCAyMCwgc2l6ZV9ieXRlcyk7DQo+PiArfQ0KPj4gKw0KPj4gK2ludCBtYWlu
KGludCBhcmdjLCBjaGFyICoqYXJndikNCj4+ICt7DQo+PiArICAgIGludCByYzsNCj4+ICsNCj4+
ICsgICAgcHJpbnRmKCJQMk0gU2hhZG93IG1lbW9yeSBwb29sIHRlc3RzXG4iKTsNCj4gLi4uIHRo
ZSBxdWVzdGlvbiBvZiB3aHkgIlNoYWRvdyIgaGVyZS4NCg0KSG1tLCBzdGFsZSwgYnV0IGV2ZW4g
dGhlIG5hbWUgb2YgdGhpcyB0ZXN0IChwMm0tcG9vbCkgaXMgc3ViamVjdCB0byBhDQpyZXNvbHV0
aW9uIG9mIHRoZSBuYW1pbmcgcXVlc3Rpb24gb24gcGF0Y2ggMS4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 15:06:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 15:06:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430638.682566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhyz-0005sf-3l; Wed, 26 Oct 2022 15:06:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430638.682566; Wed, 26 Oct 2022 15:06:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onhyz-0005sY-0O; Wed, 26 Oct 2022 15:06:17 +0000
Received: by outflank-mailman (input) for mailman id 430638;
 Wed, 26 Oct 2022 15:06:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ANQJ=23=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onhyx-0005sC-8T
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 15:06:15 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
 (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba063b3a-553f-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 17:06:12 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by SN7PR12MB7953.namprd12.prod.outlook.com (2603:10b6:806:345::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 15:06:08 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 15:06:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba063b3a-553f-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ogv9j53CPeu/CFyAS5Z/bkNJLedOO7twqF5jJM2by3s/WESuB31IwZA3YcQXvAdsk9N7nFPmcrp2Y18g8UZM8SwMu1RB9t7RxV4uFMoYYEpDdpa7eWkyDHa1ACdC57a0xinodBlzJ5IeXz0bCJ302keZUY6SYTDb6lzk/EMimhokrqDHpmqsLAfON5/4khcLqTO+OTBD9VCA+TMebSNnbWuPhK99Isv0MLc8S8AJEb5idvgJTy4SEae8Vfo7HAZ6xl/Su2DmOEpTdJ4cl6sBwqxZxX9ljv0yzrsD3cG5v3y7Ot6miEdY6TcSkRcMYARxC4IHS88vJa9qC0GSkaK4Lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MKyDAe5syXKZErZKNtg70nsvt235EbivVhwOYDfV6F4=;
 b=FNy6bG2KVGix4a2/NrPR7+WzQiWYzAOTAr1qiJpJIwy6T84DNVj+AeXuy2t4KVamgyL4iuDmjAj/GEe1PFGgIw04IiNoL8CCJDOic3jwY0vwQY7JFyrG2N6vuJsi/p8hKTfrftnouTlQbPuvepmgIeJt4UUaxbE3JX6x85AtfpW9izFfA+uHMex5WrHFfBImjEJ913wFqcbZIOETNPj6ZAMnmg8WxLBSoBiSUm3vR5QbNrUeHUad3duvgeoRG/P2411HQREqtlKmHNsch9ItwGTPQFTjrfat+farr5sCCfUq2gVv5wODNsc/3QeHdFZYetljjYVCPyhUuZLIt7ECjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MKyDAe5syXKZErZKNtg70nsvt235EbivVhwOYDfV6F4=;
 b=ibFccaemKCzVRC8UVyYPRTVMeVp0VewLdmb113VcmSx4Msl4G8UrNbjG2tvoLj+V144pnntxewMucGocFKUMkrQKRkdqMebUf/iicj9c0Y1quvNE3yDC4rxuSokKrObInrL4ObvePEK0r/c37TCcvlzmoz8xrhG7OYTuPcAuKEU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <2accac91-d822-c493-4045-8657aed26fb1@amd.com>
Date: Wed, 26 Oct 2022 16:06:02 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, andre.przywara@arm.com, Henry.Wang@arm.com
References: <20221026133540.52191-1-ayankuma@amd.com>
 <95d0a8ca-9ff0-162a-02ae-8cbdc30af8b9@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <95d0a8ca-9ff0-162a-02ae-8cbdc30af8b9@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0064.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:153::15) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SN7PR12MB7953:EE_
X-MS-Office365-Filtering-Correlation-Id: f4193537-49cf-4cbd-549a-08dab7639c59
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IwMGYECAmbcJhEwKU2oLIcwA5cQuKk7t2Yh38ahQRiGcvNoG0NhOkmUBcXySyUr/cafC2ie1AFRe8+B1KiJmvEtjOEZwotMgoPmqDj0lqIfde+s43Q8IJvNbgA7KWAinO5+RpJ3pLs5KXg0SMQCsMeuPHzFjfs7xOf6ik4fZcAEuG/xnVPiEajRjHQ8qbgklpZTcDU4ehoYCaACivbV0Y5/AY5uvmPDqXIkFYLqZ+ScgZQOF5qMSm4DBfmjR6CFT/CC3yZ/nipl1MRaLo6hHT/oHZ8m+lFSg2cae6is5ExHzSMO6Oewk97+XIXgjn04Lt5wB/Mh2BcLQT+Gvy94i8SgBY8ljyvhNpx3tdBbM35uktCBN+/+XzGqAlcyHrTwwLNkZiJ53wNFd6RusCExudN6seyMYhzUoDstGUsyEQ0ZDfTdqgJZv69VcmVVXi0IsUWVCSI98n7YMJNMJ3a6z7AthtKgYeMtXPsvnfMa0viJteoW8XumoyKtMsh+xKR6wsyyu8H9P+lv9o8iq+yIbZrdVh89Tuo5NGMkAEIOECoYBvtqOwess+Jt6CYyFCchKOsDutiutTmk1WvsWuB21fL8thEzuoO1vCP/+Fpct9DEy9n/mJVH0jP8UT7fvtfVktTMZ85Yqeq3XrK6AwZoXghcRfgzYtBbR1ZUdjZCGhMfl9MuLkMexO6Tb9ZGw53r1rGDTu//GdRLum2Xnt8GhONSBJoYf2fONhO4pQI9OmHx13zcqTvwVIY7uH2hkU3XvbYSkWAPMVEPKf7Rv5jxooibTLpMTCCPcFkMT3AqqfEY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199015)(31686004)(478600001)(38100700002)(83380400001)(6486002)(66556008)(53546011)(6666004)(8676002)(66476007)(36756003)(4326008)(186003)(31696002)(6506007)(8936002)(26005)(66946007)(41300700001)(316002)(2906002)(6512007)(2616005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cEhsdHBFOE1xSEpMU1ExYlp6S3hmdmxNUGlycGFjaWVMdjlZREFYNk42Y2Jx?=
 =?utf-8?B?TVJXT0xDcDRXaEtKRUh5L0VJZFdPWFJkTUFRNDFoV1ROdjFrcFVLbThzNTBF?=
 =?utf-8?B?UXBmMEVVVGxBNGhwRkJ3MkY2SHI0U25TeVJ5SVF4ZmVKbVhaRDRTd0VrbEwv?=
 =?utf-8?B?Vk4wcUFUS3F0NDNlSTZTRDRxWHF4SjRTclVCalRCNFNRZCtKeXpHc0dqdHMv?=
 =?utf-8?B?WWNsQlV6U2x0aCtTcFJFZGlCK2d1Y3hiNHVUdXFYRk5mUGNsRmtOTXI3cVdM?=
 =?utf-8?B?MFRQOEY3aWtKRTdhek53ck4vMm0yNVBIVmVvRlB5SDBxalVpQklUMUVtbUVK?=
 =?utf-8?B?djVOSThrTW5UU3VGVWFlZG5tWjdNdExtOGgxNk1tem5EemVzS2YvQ2VVdzZY?=
 =?utf-8?B?NWdzdzNaRC8ydFBuUStUYUlJeC9GZmlKV1BBZksyWWhMZm9yY29Mb09leVlL?=
 =?utf-8?B?WnoyOStuT0tyNWRIN2tmQmNwVlEwREJMWUN0UnFjT0EvbzZQWFhvbUNsdWFU?=
 =?utf-8?B?NHEweTc4OW9yQ3VtR3F0WC9NcC84cXh5cHRDZThJVzFRRkpYcFJENFA0YmUr?=
 =?utf-8?B?Q2xiUnk5Z1IwTjlVMDdtbDg0QzNoZnJuSWxxdk1FNE5EMDlvTmdDbmxMTnE3?=
 =?utf-8?B?Z3gvdFlLMS9WeEttWVV3K3hGSWZnUVplUnNsUFY4T21EOHZQcFZqOWtSNWt3?=
 =?utf-8?B?NVpMREw4dzU3c2k0Myt1SGp1OW5rUmdGVWhpWExXVDVPYUlnMHBBVW0xREpk?=
 =?utf-8?B?S1lJWkM2OHg2dGQrM3Q5WERKSThEWXZJZS8xYUpSdlZtaFpuNmZXOVFtRlR3?=
 =?utf-8?B?ZEltY2ZwdHhEY09YN1RkQ09QTHBlWmU4a2FYZGN1QnBSaVFJWk9OUUdBUU8z?=
 =?utf-8?B?TWRaUmwrMW1ueE9wVmszZk4vUWZyendJcWNQT3pKSVhsUmVGZE1LZjNlUWJq?=
 =?utf-8?B?VTdYMmVXZ25Rd1lOMVo4WmZmckthVHVndjBaNG5YM1RZb1czR0JnbjFtWSt4?=
 =?utf-8?B?dFB6andEN2FSNGQzUEpCQUxNL1Z0Q2VPZUJncFowY2hIY0M2Y0tqblpSTW9M?=
 =?utf-8?B?Mzc3U2JiMDQxOFU0QkRIQ0ozTFVWRlRFc0Uxck5tOWFadTNoQ0cxcVAvdGRV?=
 =?utf-8?B?cWxrNkxrRmhVL1Zjc2twaXlYMmM5RDZ4QlRmY1ZWT0FFQ3JZMm9zanAxSkFa?=
 =?utf-8?B?bi90OU5JekU5Slg2V2hYOStZeXI1V290OTIyVlQxZ1I3Tk12YnoxdFlTTklZ?=
 =?utf-8?B?OGE4TGg3UUt6aitNdjBKZGVVQmdKQURNSVM3aWtIeHNMWG1lWjAyM1BxaExC?=
 =?utf-8?B?eHFuWW9OUTkvWCt6akJlWXZzNHduNk1PbFlMTVdGbHp0MjE0NCthT3JaeUIv?=
 =?utf-8?B?TFlyelUrZnhYZWFTS0F5eUdUbVZNY2tONityRHlkTEVnRndpYmFFeVA3c0NZ?=
 =?utf-8?B?S21QMEpQbGhPRjdCRzY5cmNuL0IyL2s4TTV0K3BJekltVWdSbDdxaEVaQTEv?=
 =?utf-8?B?RzVmZGc2UkVXZnFabGpOdVNjZGJBN1RzTFo5dmJMTFBOWlhPMkYxMGlYNmIy?=
 =?utf-8?B?cDNCTlFZOWl0K1pNREE5bVhvRXlvWDljdWg5VUdzQ0hMeG1HUFphWTErR2ND?=
 =?utf-8?B?c25wcHNDZjZkMHkyVlVjVDdHUHIrbXNURW5IMFViY1p4a2prRzIrRE1lSVQz?=
 =?utf-8?B?RURqRjk0eExCb0pBZUowSk4yK0hlaGdYMW1VVUlWYmNZbG5EZWZvQjc5QkVC?=
 =?utf-8?B?Mi9yVFA3Mk1iVEp0bDJaNTNkalI4WXdRWEIvNzVoSTg1T1dPdlhkcElUR1Ro?=
 =?utf-8?B?Tng2Wmh5Q2lxbG1vTEJKVVNjZk5xaGRybzBIVitTY2twbmNGSkxHdUY1WDZw?=
 =?utf-8?B?UGpkZFZPaGplYXFDYTVUTlVtM3BxYmdDWFc3dWgybUJLZVl0QkJPei9BQVRa?=
 =?utf-8?B?T3d5aDRvR0VGRHl3bGRkNk1YejVaT0RvdjJ5Tyt1RG00ZjhnUDgvR1U1dmF4?=
 =?utf-8?B?LzVUOFpQNTNyMC9Yakl0V0ZBaFdmazEzd01qNVhGSXNCc1MyL25mNy92SU1h?=
 =?utf-8?B?UlNudXZoNzd6SjZZREJOamZqeHc2amt2UmxCTCtLemwzTFZSSitLaEorNzhk?=
 =?utf-8?Q?zkRK5htv3KCNMyct+P20xIWLI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4193537-49cf-4cbd-549a-08dab7639c59
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 15:06:08.1435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DzdsFYN4Z1kb86ReOEesfE9AlxHrtQlCGpkspDRyyUNOPfshlnpd9ClnW/l5IZs0hP3pCdwCcOqjzJPC4SrCMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7953


On 26/10/2022 14:41, Julien Grall wrote:
> Hi Ayan,
Hi Julien,
>
> On 26/10/2022 14:35, Ayan Kumar Halder wrote:
>> If a guest is running in 32 bit mode and it tries to access
>> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. 
>> vreg_reg64_extract()
>> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
>> This will be stored in a 64bit cpu register.
> >
>> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO 
>> register) stored
>> in the lower 32 bits of the 64bit cpu register.
>>
>> This 64bit cpu register is then modified bitwise with a mask (ie
>> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is 
>> bit 30 in the
>> 64 bit cpu register) is not cleared as expected by the specification.
>>
>> The correct thing to do here is to store the value of
>> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This 
>> variable is
>> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
>> vreg_reg64_extract() which will extract 32 bits from the given offset.
>>
>> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending 
>> and property tables")
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>
> Given the changes you made below, the reviewed-by tags below should 
> not have been retained.
Sorry, I will take care of this henceforth.
>
>> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
>> ---
>>
>> Changes from:-
>>
>> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: 
>> Emulate
>> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch 
>> with an
>> appropriate commit message.
>>
>> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
>> v->arch.vgic.rdist_pendbase in an atomic context.
>
> Please in the commit message why the lock is removed. But...
ok
>
>> 2. Rectified the commit message to state that the cpu register is 64 
>> bit.
>> (because currently, GICv3 is supported on Arm64 only). Reworded to 
>> make it
>> clear.
>>
>>   xen/arch/arm/vgic-v3.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>> index 0c23f6df9d..958af1532e 100644
>> --- a/xen/arch/arm/vgic-v3.c
>> +++ b/xen/arch/arm/vgic-v3.c
>> @@ -249,16 +249,16 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct 
>> vcpu *v, mmio_info_t *info,
>>         case VREG64(GICR_PENDBASER):
>>       {
>> -        unsigned long flags;
>> +        uint64_t val;
>>             if ( !v->domain->arch.vgic.has_its )
>>               goto read_as_zero_64;
>>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>>   -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
>> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
>> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
>
> ... you also need to ensure that the writers are atomically setting 
> rdist_pendbase. Please correct if I am wrong, but the callers are not 
> using write_atomic(). So how does that work?

I think read_atomic()/write_atomic() may not be the correct approach for 
the following reasons :-

1. __vgic_v3_rdistr_rd_mmio_read is a static function. So 'val' has a 
global lifetime. Thus, all the following three lines need to be 
protected from concurrent access.

         val = read_atomic(&v->arch.vgic.rdist_pendbase);
         val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */

         /* If a context switch happens here, then the 'val' below may 
potentially be incorrect. */

         *r = vreg_reg64_extract(val, info);

2. The same holds true for 'reg' as well in __vgic_v3_rdistr_rd_mmio_write()

             reg = v->arch.vgic.rdist_pendbase;
             blah, blah
             v->arch.vgic.rdist_pendbase = reg;

Thus, I am thinking of going back to 
spin_lock_irqsave()/spin_unlock_irqrestore(). Unless, you have some 
other opinions.

- Ayan

>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 15:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 15:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430649.682577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oniMT-000143-2L; Wed, 26 Oct 2022 15:30:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430649.682577; Wed, 26 Oct 2022 15:30:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oniMS-00013w-Ut; Wed, 26 Oct 2022 15:30:32 +0000
Received: by outflank-mailman (input) for mailman id 430649;
 Wed, 26 Oct 2022 15:30:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JuuU=23=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1oniMR-00013q-FJ
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 15:30:31 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e843d64-5543-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 17:30:29 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D929AB82316;
 Wed, 26 Oct 2022 15:30:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CABD2C433C1;
 Wed, 26 Oct 2022 15:30:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e843d64-5543-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666798226;
	bh=dsp8KP98oVVVHIU6skf5Sad/rXjvqSo5U2iza8mUiIQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EYd9Ls9E39FRajwxxoJDFsYmvSFDqsoFyDDyUyzZsqJvuG8NZ56dLSo87UfzCLtn3
	 zcudhN52rfMOFIeJ9W7girjCTFEmZcsA1WhB5mM5xc5rS72Dn0DfgwTH1Y1X1W84J2
	 m0mjaUoQcw8R+HhRfUlOp5cO1HXtdiGX7GrRRKjNlpDc3U0bJ6Op9dLVAAkK904PCK
	 7rNrYc6IdYfSiYaDQC8Mvqm2UEBcgZTotbNYsesTnN9iegylChbT+LdhPX6FJWPSL9
	 BoessUFPIh4XH0kNRo7J8plyIkkML+bMML/ExXDzMYnPjTk+FGS0gfohQsoAMN1b80
	 3sgZyuDoQTEBw==
Date: Wed, 26 Oct 2022 08:30:24 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
cc: Michal Orzel <michal.orzel@amd.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Deadcode discussion based on Arm NS phys timer
In-Reply-To: <54F41F27-8753-4BA5-98D5-23E649EBE339@arm.com>
Message-ID: <alpine.DEB.2.22.394.2210260830170.1397955@ubuntu-linux-20-04-desktop>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com> <8691e100-4548-9752-8e7e-b292643cae83@xen.org> <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com> <aff58db0-646c-6699-48af-033e28c5626f@xen.org> <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com> <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com> <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com> <7C838BB9-E8FA-4239-B851-B179CB6B7A02@arm.com> <a3306efe-16bb-feb0-91aa-d6a9b0e30691@amd.com>
 <54F41F27-8753-4BA5-98D5-23E649EBE339@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1449371642-1666798226=:1397955"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1449371642-1666798226=:1397955
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wed, 26 Oct 2022, Bertrand Marquis wrote:
> > On 26 Oct 2022, at 12:29, Michal Orzel <michal.orzel@amd.com> wrote:
> > 
> > Hi all,
> > 
> > On 25/10/2022 10:20, Bertrand Marquis wrote:
> >> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> >> 
> >> 
> >> Hi Michal,
> >> 
> >>> On 25 Oct 2022, at 09:07, Michal Orzel <michal.orzel@amd.com> wrote:
> >>> 
> >>> Hi Bertrand,
> >>> 
> >>> On 25/10/2022 09:45, Bertrand Marquis wrote:
> >>>> 
> >>>> 
> >>>> Hi Michal,
> >>>> 
> >>>>> On 25 Oct 2022, at 08:11, Michal Orzel <michal.orzel@amd.com> wrote:
> >>>>> 
> >>>>> Hi,
> >>>>> 
> >>>>> On 25/10/2022 03:29, Stefano Stabellini wrote:
> >>>>>> 
> >>>>>> 
> >>>>>> On Mon, 24 Oct 2022, Julien Grall wrote:
> >>>>>>>> On 24/10/2022 12:51, Julien Grall wrote:
> >>>>>>>>> Caution: This message originated from an External Source. Use proper
> >>>>>>>>> caution when opening attachments, clicking links, or responding.
> >>>>>>>>> 
> >>>>>>>>> 
> >>>>>>>>> On 24/10/2022 10:07, Michal Orzel wrote:
> >>>>>>>>>> Hello,
> >>>>>>>>> 
> >>>>>>>>> Hi Michal,
> >>>>>>>>> 
> >>>>>>>>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly
> >>>>>>>>>> speaking, we are routing
> >>>>>>>>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use
> >>>>>>>>>> of it (as it uses the hypervisor timer CNTHP).
> >>>>>>>>>> This timer is fully emulated, which means that there is nothing that can
> >>>>>>>>>> trigger such IRQ. This code is
> >>>>>>>>>> a left over from early days, where the CNTHP was buggy on some models
> >>>>>>>>>> and we had to use the CNTP instead.
> >>>>>>>>>> 
> >>>>>>>>>> As far as the problem itself is not really interesting, it raises a
> >>>>>>>>>> question of what to do with a deadcode,
> >>>>>>>>>> as there might be/are other deadcode places in Xen.
> >>>>>>>>> 
> >>>>>>>>> There are multiple definition of deadcode. Depending on which one you
> >>>>>>>>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
> >>>>>>>>> would result to a lot of places impacted with the decision.
> >>>>>>>>> 
> >>>>>>>>> So can you clarify what you mean by deadcode?
> >>>>>>>> In the timer example, I think we have both a deadcode and unreachable code.
> >>>>>>>> For the purpose of this discussion, let's take the MISRA definition of a
> >>>>>>>> deadcode which is a "code that can be executed
> >>>>>>>> but has no effect on the functional behavior of the program". This differs
> >>>>>>>> from the unreachable code definition that is
> >>>>>>>> a "code that cannot be executed". Setting up the IRQ for Xen is an example
> >>>>>>>> of a deadcode. Code within IRQ handler is an unreachable code
> >>>>>>>> (there is nothing that can trigger this IRQ).
> >>>>>>>> 
> >>>>>>>> What I mean by deadcode happens to be the sum of the two cases above i.e.
> >>>>>>>> the code that cannot be executed as well as the code that
> >>>>>>>> does not impact the functionality of the program.
> >>>>>>>> 
> >>>>>>>>> 
> >>>>>>>>>> One may say that it is useful to keep it, because one day,
> >>>>>>>>>> someone might need it when dealing with yet another broken HW. Such
> >>>>>>>>>> person would still need to modify the other
> >>>>>>>>>> part of the code (e.g. reprogram_timer), but there would be less work
> >>>>>>>>>> required overall. Personally, I'm not in favor of
> >>>>>>>>>> such approach, because we should not really support possible scenarios
> >>>>>>>>>> with broken HW (except for erratas listing known issues).
> >>>>>>>>> 
> >>>>>>>>> The difference between "broken HW" and "HW with known errata" is a bit
> >>>>>>>>> unclear to me. Can you clarify how you would make the difference here?
> >>>>>>>>> 
> >>>>>>>>> In particular, at which point do you consider that the HW should not be
> >>>>>>>>> supported by Xen?
> >>>>>>>> I'm not saying that HW should not be supported. The difference for me
> >>>>>>>> between broken HW and
> >>>>>>>> HW with known errata is that for the former, the incorrect behavior is often
> >>>>>>>> due to the early support stage,
> >>>>>>>> using emulators/models instead of real HW, whereas for the latter, the HW is
> >>>>>>>> already released and it happens to be that it is buggy
> >>>>>>>> (the HW vendor is aware of the issue and released erratas).
> >>>>>>> 
> >>>>>>> Thanks for the clarification. What I would call broken is anything that can't
> >>>>>>> be fixed in software. For a not too fictional example, an HW where PCI devices
> >>>>>>> are using the same stream ID. So effectively, passthrough can't be safely
> >>>>>>> supported.
> >>>>>>> 
> >>>>>>> Regarding, not yet released HW, I don't think Xen should have workaround for
> >>>>>>> them. I wouldn't even call it "broken" because they are not yet released and
> >>>>>>> it is common to have bug in early revision.
> >>>>>>> 
> >>>>>>>> Do we have any example in Xen for supporting broken HW,
> >>>>>>>> whose vendor is not aware of the issue or did not release any errata?
> >>>>>>> I will not cite any HW on the ML. But from my experience, the vendors are not
> >>>>>>> very vocal about issues in public (some don't even seem to have public doc).
> >>>>>>> The best way to find the issues is to look at Linux commit.
> >>>>>>> 
> >>>>>>>> 
> >>>>>>>>> 
> >>>>>>>>>> Also, as part of the certification/FUSA process, there should be no
> >>>>>>>>>> deadcode and we should have explanation for every block of code.
> >>>>>>>>> 
> >>>>>>>>> See above. What are you trying to cover by deadcode? Would protecting
> >>>>>>>>> code with IS_ENABLED() (or #ifdef) ok?
> >>>>>>>> I think this would be ok from the certification point of view (this would at
> >>>>>>>> least means, that we are aware of the issue
> >>>>>>>> and we took some steps). Otherwise, such code is just an example of a
> >>>>>>>> deadcode/unreachable code.
> >>>>>>> 
> >>>>>>> Thanks for the clarification. So the exact approach will depend on the
> >>>>>>> context....
> >>>>>>> 
> >>>>>>>>>> There are different ways to deal with a deadcode: > 1. Get rid of it
> >>>>>>>>>> completely
> >>>>>>>>>> 2. Leave it as it is
> >>>>>>> 
> >>>>>>> ... this is my preference in the context of the timer.
> >>>>>> 
> >>>>>> From a certification point of view, the fewer lines of code the better,
> >>>>>> and ideally all the lines of code used for the certified build should be
> >>>>>> testable and used.
> >>>>>> 
> >>>>>> So I think 2. is the lest useful option from a certification
> >>>>>> perspective. For this reason, I'd prefer another alternative.
> >>>>>> 
> >>>>>> 
> >>>>>>> If the other don't like it, then 1 would be my preference.
> >>>>>>> 
> >>>>>>> In general, my preference would be either 3.3 or 3.2 (see below).
> >>>>>> 
> >>>>>> I also think that 3.2 and 3.3 are good options for the general case. For
> >>>>>> the timer, I can see why 1 is your (second) preference and I am fine
> >>>>>> with 1 as well.
> >>>>> Ok, sounds good to me. Let's still give Bertrand the chance to share his opinion.
> >>>> 
> >>>> We need to get rid of dead code and removing it is not always the best solution.
> >>>> 
> >>>> If the code is or could be useful for someone some day, protecting it with ifdef is ok.
> >>>> 
> >>>> In the mid term we will have to introduce a lot more ifdef or IS_ENABLED in the
> >>>> code so that we can compile out what we do not need and code not applying to
> >>>> some hardware is a case where we will do that (does not mean that by default
> >>>> we will not compile it in but we will make it easier to reduce the code size for a
> >>>> specific use case).
> >>>> 
> >>>> So 3.2 and 3.3 are ok for me.
> >>> 
> >>> So we all agree that the code in the current form is a no go from certification purposes.
> >>> That is good :)
> >>> 
> >>> The reason why I opt for solution 1 and not the others is that in the latter case it would
> >>> mean introducing the Kconfig option to allow user to select the timer to be used by Xen.
> >>> This is not really correct. Also in the current form, it would also require adding more
> >>> code to time.c code because at the moment using CNTP for Xen would not work out of the box.
> >>> The architecture defines the hypervisor timer for a purpose. If it does not work, it means
> >>> that the HW is problematic. I agree that we would want to support such use case but I'm not
> >>> really aware of any issue like that. Adding more code and Kconfig options just because
> >>> one day someone may face issues with a new HW is something I am not a fan of.
> >> 
> >> I see 2 solutions here:
> >> - somehow push the code to a different file (not quite sure this is feasible here)
> >> - remove completely the code with a clean commit. Doing this it will be easy for someone needing this to later revert the patch
> >> 
> >> It is definitely true here that adding more code to keep some unused code does not really make sense.
> >> And let’s be realistic here, if we need that one day, it will not take ages to support it somehow.
> >> 
> >> As said, from a pure certification point of view:
> >> - we must not have deadcode
> >> - proper ifdef is acceptable
> >> - if 0 is not acceptable
> >> - commented code is not acceptable
> > 
> > Given that we agree on that (+ IS_ENABLED option if possible), and the option 1 seems
> > to be the best choice for the timer, I will create a patch removing the IRQ path to get rid
> > of the deadcode/unreachable code.
> > 
> > Do you think this is something we want for 4.17?
> > The risk is low as the code is already dead and the benefit is that we have no deadcode.
> > What do you think?
> > 
> 
> We are very near from the release so from my point of view as it is not solving a bug, this should not go into 4.17.

I agree
--8323329-1449371642-1666798226=:1397955--


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 15:54:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 15:54:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430662.682593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onijJ-0003tB-0G; Wed, 26 Oct 2022 15:54:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430662.682593; Wed, 26 Oct 2022 15:54:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onijI-0003t4-Ta; Wed, 26 Oct 2022 15:54:08 +0000
Received: by outflank-mailman (input) for mailman id 430662;
 Wed, 26 Oct 2022 15:54:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=azgP=23=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onijH-0003sy-Mo
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 15:54:07 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2086.outbound.protection.outlook.com [40.107.223.86])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6ab57c6b-5546-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 17:54:05 +0200 (CEST)
Received: from DM6PR11CA0041.namprd11.prod.outlook.com (2603:10b6:5:14c::18)
 by DM4PR12MB6493.namprd12.prod.outlook.com (2603:10b6:8:b6::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 26 Oct
 2022 15:54:02 +0000
Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:14c:cafe::80) by DM6PR11CA0041.outlook.office365.com
 (2603:10b6:5:14c::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 15:54:00 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 26 Oct 2022 15:53:59 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 10:53:58 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 10:53:59 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 26 Oct 2022 10:53:57 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ab57c6b-5546-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NxsNmqs0oQp+fMc8kNKp5TTE4XQTMwRDLyy8I17RFhJkIT/qrWs+u5guAQuQm1F2apDGonVdxxFhvekxhC7BOfsi02Qf/RGVWLmlclEU8TRYU4JXARMS3UwzR9TF/LTh+UyBTSzFO4qfmtU6/HNOyGZ69HUsTmaemgJsjYUagjcAuQOeLxGbfnZG3j5zSorbb1YP4G7SfqvvL2DD2OGZ2CNxvPPmCrhgScqUC/oDaivUBhzvAyKP+qjXOfpStyFkaSPxREPQbVooyJS1NUEV+icDcs2H++imQcvFyx/4NrxCpu0nHWxgo56oDNFM1EJaTFI4ETwoECpE5gDgBn8x5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4NgGw8kcVoF76m1tdml6dJWDBvTDF9iqcMaH2NwS+fk=;
 b=oHfuO8n247BVDG4t2/w39sY8bWtx+F2jprSpkGFSIg21X1ICnVpqOrMJmuymrSPV4OS1Pqt/WtLIy3LMLr9OS4KefTxvl4cxq29r1974XlcsDaDFFzQqAo4N31IBINui1qdDP6/FQ4tj2R3jTxls7RPMGkTUSDIMV26WP17aTgYv7eSn9cG6FHHgnBv6bFxZohLz/jexz7jXA7fLrbpbIFsdvmdVVU+FsRf1oOIftbFZo3L4gvQdFTVYjJiQ88fKwH5U7MyuBY69BjTJwS2GNsx09NbG+pVlRSVEakrkNzzKICG3tZpJal6BA3YZxkp3NfhdQhNpQbBTTrCrtcRSbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4NgGw8kcVoF76m1tdml6dJWDBvTDF9iqcMaH2NwS+fk=;
 b=MAKLA5Xl4/zRaLGtJYvrdXRVGst94gLRiopNpBYJ7IAmSCP4gtPKF3JW5rToDWSWx33fm7Eb84lD5pihTcJDfHT0w2aivczqc/J+zqq082tpyWpowEILHePs30zchHn0oOQHQodK24cZ6KYu1QVuAlYP9LQGUSGRs2nawVWApTQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <1f094419-32be-97fd-cae2-43cf1e868d62@amd.com>
Date: Wed, 26 Oct 2022 17:53:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Deadcode discussion based on Arm NS phys timer
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>
CC: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
References: <d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com>
 <8691e100-4548-9752-8e7e-b292643cae83@xen.org>
 <6aefd6d6-45a2-a1f3-24da-8bbbba22fc08@amd.com>
 <aff58db0-646c-6699-48af-033e28c5626f@xen.org>
 <alpine.DEB.2.22.394.2210241819420.1151068@ubuntu-linux-20-04-desktop>
 <ed0bf3da-fe9f-e00c-9bc3-35e10840701e@amd.com>
 <06D2C614-0F17-4364-BE52-FB0DB51D097B@arm.com>
 <89ff9e50-be23-82c2-cd6b-81e05d339778@amd.com>
 <7C838BB9-E8FA-4239-B851-B179CB6B7A02@arm.com>
 <a3306efe-16bb-feb0-91aa-d6a9b0e30691@amd.com>
 <54F41F27-8753-4BA5-98D5-23E649EBE339@arm.com>
 <alpine.DEB.2.22.394.2210260830170.1397955@ubuntu-linux-20-04-desktop>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <alpine.DEB.2.22.394.2210260830170.1397955@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT040:EE_|DM4PR12MB6493:EE_
X-MS-Office365-Filtering-Correlation-Id: 40e2cd60-811c-4b0e-335f-08dab76a4c3d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gFGkpOBMES/jZNZer32fKhGMEPAO5d9JcspHY9ZEsAyXJTI+oY+5GBw/F2EgEbCVwh7ORKjQtIpBvHjzdWz3CaaFn8K5+dEUVeGuE4wuA8jMhZy7hW8U7VCgmUNeFBlk0g0Lvu1w14sdb4EHir2Vl2QZNp59SfAftc/39lmf4b87tOCoxtsP4j/yRI/ZtrgH0uz+wZqB0d8oYsZPY5NdtxP6fgovFerTZE1vogyckblIeiQr6x6eVekijoMnBF0bxBb6j/s7wrnc99nc5AG+BqfPnT6OzDGVrXUvFjEi9DV/Umno2stDgVz9O6lQEquwVXZ73zepEuGlPn1ddKt54Y9WJJZTdKN36HRkX5YH54m95rd87jKhTdIOq4ChR3zWprsgvQup1hJbmsQi0GJWRegXtLesiX32UNgvuVy6V6Yop0qbqV8hNEA77mgW0fEtoDwNP0uu0UqGtWCerCnK2vRjKU3X83v/L4T6ymlU4L7dE3RMTxvqLPgc+sEAr8FBgnXtJxFrMSy2c5uegtlME9swP8DzvI05LJXPyTMl5XMuaTtJ8TKXFMwS4an8SE5p6Tpgc1c0gq69c9HpCCPe/idWgzPey8R5EMPLHrHoZUXGERhyxhL8rXVWTHqcUeGxVJiAey3fxgGwED7OdffQXO+7mFptW/4HptvmMc0ZnIdQGp8rIXUZ4W14cHSreuaDVZWJP4Gy72EY3rTNKCmBtsigpmfnXvLgpN0nvxs3AwoH8c2VIDZZOJp84vSCTXX8yUEjks88F3+BRJpYTaEuCK3zVpWm6sSflKL4Dhb0AMD9s3hL8HKUNYSDST2XNV1h8DhkPGTmzvZ2IQ0kud8YfQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(396003)(376002)(451199015)(36840700001)(46966006)(40470700004)(81166007)(86362001)(82740400003)(2906002)(36756003)(66899015)(31696002)(44832011)(31686004)(356005)(70206006)(40480700001)(70586007)(5660300002)(53546011)(186003)(2616005)(36860700001)(47076005)(26005)(54906003)(426003)(16576012)(83380400001)(40460700003)(336012)(82310400005)(110136005)(478600001)(41300700001)(316002)(4326008)(8936002)(8676002)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 15:53:59.9217
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 40e2cd60-811c-4b0e-335f-08dab76a4c3d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT040.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6493

Hi,

On 26/10/2022 17:30, Stefano Stabellini wrote:
> 
> 
> On Wed, 26 Oct 2022, Bertrand Marquis wrote:
>>> On 26 Oct 2022, at 12:29, Michal Orzel <michal.orzel@amd.com> wrote:
>>>
>>> Hi all,
>>>
>>> On 25/10/2022 10:20, Bertrand Marquis wrote:
>>>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>>>
>>>>
>>>> Hi Michal,
>>>>
>>>>> On 25 Oct 2022, at 09:07, Michal Orzel <michal.orzel@amd.com> wrote:
>>>>>
>>>>> Hi Bertrand,
>>>>>
>>>>> On 25/10/2022 09:45, Bertrand Marquis wrote:
>>>>>>
>>>>>>
>>>>>> Hi Michal,
>>>>>>
>>>>>>> On 25 Oct 2022, at 08:11, Michal Orzel <michal.orzel@amd.com> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> On 25/10/2022 03:29, Stefano Stabellini wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, 24 Oct 2022, Julien Grall wrote:
>>>>>>>>>> On 24/10/2022 12:51, Julien Grall wrote:
>>>>>>>>>>> Caution: This message originated from an External Source. Use proper
>>>>>>>>>>> caution when opening attachments, clicking links, or responding.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 24/10/2022 10:07, Michal Orzel wrote:
>>>>>>>>>>>> Hello,
>>>>>>>>>>>
>>>>>>>>>>> Hi Michal,
>>>>>>>>>>>
>>>>>>>>>>>> Recently I came across a deadcode in Xen Arm arch timer code. Briefly
>>>>>>>>>>>> speaking, we are routing
>>>>>>>>>>>> the NS phys timer (CNTP) IRQ to Xen, even though Xen does not make use
>>>>>>>>>>>> of it (as it uses the hypervisor timer CNTHP).
>>>>>>>>>>>> This timer is fully emulated, which means that there is nothing that can
>>>>>>>>>>>> trigger such IRQ. This code is
>>>>>>>>>>>> a left over from early days, where the CNTHP was buggy on some models
>>>>>>>>>>>> and we had to use the CNTP instead.
>>>>>>>>>>>>
>>>>>>>>>>>> As far as the problem itself is not really interesting, it raises a
>>>>>>>>>>>> question of what to do with a deadcode,
>>>>>>>>>>>> as there might be/are other deadcode places in Xen.
>>>>>>>>>>>
>>>>>>>>>>> There are multiple definition of deadcode. Depending on which one you
>>>>>>>>>>> chose, then this could cover IS_ENABLED() and possibly #ifdef. So this
>>>>>>>>>>> would result to a lot of places impacted with the decision.
>>>>>>>>>>>
>>>>>>>>>>> So can you clarify what you mean by deadcode?
>>>>>>>>>> In the timer example, I think we have both a deadcode and unreachable code.
>>>>>>>>>> For the purpose of this discussion, let's take the MISRA definition of a
>>>>>>>>>> deadcode which is a "code that can be executed
>>>>>>>>>> but has no effect on the functional behavior of the program". This differs
>>>>>>>>>> from the unreachable code definition that is
>>>>>>>>>> a "code that cannot be executed". Setting up the IRQ for Xen is an example
>>>>>>>>>> of a deadcode. Code within IRQ handler is an unreachable code
>>>>>>>>>> (there is nothing that can trigger this IRQ).
>>>>>>>>>>
>>>>>>>>>> What I mean by deadcode happens to be the sum of the two cases above i.e.
>>>>>>>>>> the code that cannot be executed as well as the code that
>>>>>>>>>> does not impact the functionality of the program.
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> One may say that it is useful to keep it, because one day,
>>>>>>>>>>>> someone might need it when dealing with yet another broken HW. Such
>>>>>>>>>>>> person would still need to modify the other
>>>>>>>>>>>> part of the code (e.g. reprogram_timer), but there would be less work
>>>>>>>>>>>> required overall. Personally, I'm not in favor of
>>>>>>>>>>>> such approach, because we should not really support possible scenarios
>>>>>>>>>>>> with broken HW (except for erratas listing known issues).
>>>>>>>>>>>
>>>>>>>>>>> The difference between "broken HW" and "HW with known errata" is a bit
>>>>>>>>>>> unclear to me. Can you clarify how you would make the difference here?
>>>>>>>>>>>
>>>>>>>>>>> In particular, at which point do you consider that the HW should not be
>>>>>>>>>>> supported by Xen?
>>>>>>>>>> I'm not saying that HW should not be supported. The difference for me
>>>>>>>>>> between broken HW and
>>>>>>>>>> HW with known errata is that for the former, the incorrect behavior is often
>>>>>>>>>> due to the early support stage,
>>>>>>>>>> using emulators/models instead of real HW, whereas for the latter, the HW is
>>>>>>>>>> already released and it happens to be that it is buggy
>>>>>>>>>> (the HW vendor is aware of the issue and released erratas).
>>>>>>>>>
>>>>>>>>> Thanks for the clarification. What I would call broken is anything that can't
>>>>>>>>> be fixed in software. For a not too fictional example, an HW where PCI devices
>>>>>>>>> are using the same stream ID. So effectively, passthrough can't be safely
>>>>>>>>> supported.
>>>>>>>>>
>>>>>>>>> Regarding, not yet released HW, I don't think Xen should have workaround for
>>>>>>>>> them. I wouldn't even call it "broken" because they are not yet released and
>>>>>>>>> it is common to have bug in early revision.
>>>>>>>>>
>>>>>>>>>> Do we have any example in Xen for supporting broken HW,
>>>>>>>>>> whose vendor is not aware of the issue or did not release any errata?
>>>>>>>>> I will not cite any HW on the ML. But from my experience, the vendors are not
>>>>>>>>> very vocal about issues in public (some don't even seem to have public doc).
>>>>>>>>> The best way to find the issues is to look at Linux commit.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Also, as part of the certification/FUSA process, there should be no
>>>>>>>>>>>> deadcode and we should have explanation for every block of code.
>>>>>>>>>>>
>>>>>>>>>>> See above. What are you trying to cover by deadcode? Would protecting
>>>>>>>>>>> code with IS_ENABLED() (or #ifdef) ok?
>>>>>>>>>> I think this would be ok from the certification point of view (this would at
>>>>>>>>>> least means, that we are aware of the issue
>>>>>>>>>> and we took some steps). Otherwise, such code is just an example of a
>>>>>>>>>> deadcode/unreachable code.
>>>>>>>>>
>>>>>>>>> Thanks for the clarification. So the exact approach will depend on the
>>>>>>>>> context....
>>>>>>>>>
>>>>>>>>>>>> There are different ways to deal with a deadcode: > 1. Get rid of it
>>>>>>>>>>>> completely
>>>>>>>>>>>> 2. Leave it as it is
>>>>>>>>>
>>>>>>>>> ... this is my preference in the context of the timer.
>>>>>>>>
>>>>>>>> From a certification point of view, the fewer lines of code the better,
>>>>>>>> and ideally all the lines of code used for the certified build should be
>>>>>>>> testable and used.
>>>>>>>>
>>>>>>>> So I think 2. is the lest useful option from a certification
>>>>>>>> perspective. For this reason, I'd prefer another alternative.
>>>>>>>>
>>>>>>>>
>>>>>>>>> If the other don't like it, then 1 would be my preference.
>>>>>>>>>
>>>>>>>>> In general, my preference would be either 3.3 or 3.2 (see below).
>>>>>>>>
>>>>>>>> I also think that 3.2 and 3.3 are good options for the general case. For
>>>>>>>> the timer, I can see why 1 is your (second) preference and I am fine
>>>>>>>> with 1 as well.
>>>>>>> Ok, sounds good to me. Let's still give Bertrand the chance to share his opinion.
>>>>>>
>>>>>> We need to get rid of dead code and removing it is not always the best solution.
>>>>>>
>>>>>> If the code is or could be useful for someone some day, protecting it with ifdef is ok.
>>>>>>
>>>>>> In the mid term we will have to introduce a lot more ifdef or IS_ENABLED in the
>>>>>> code so that we can compile out what we do not need and code not applying to
>>>>>> some hardware is a case where we will do that (does not mean that by default
>>>>>> we will not compile it in but we will make it easier to reduce the code size for a
>>>>>> specific use case).
>>>>>>
>>>>>> So 3.2 and 3.3 are ok for me.
>>>>>
>>>>> So we all agree that the code in the current form is a no go from certification purposes.
>>>>> That is good :)
>>>>>
>>>>> The reason why I opt for solution 1 and not the others is that in the latter case it would
>>>>> mean introducing the Kconfig option to allow user to select the timer to be used by Xen.
>>>>> This is not really correct. Also in the current form, it would also require adding more
>>>>> code to time.c code because at the moment using CNTP for Xen would not work out of the box.
>>>>> The architecture defines the hypervisor timer for a purpose. If it does not work, it means
>>>>> that the HW is problematic. I agree that we would want to support such use case but I'm not
>>>>> really aware of any issue like that. Adding more code and Kconfig options just because
>>>>> one day someone may face issues with a new HW is something I am not a fan of.
>>>>
>>>> I see 2 solutions here:
>>>> - somehow push the code to a different file (not quite sure this is feasible here)
>>>> - remove completely the code with a clean commit. Doing this it will be easy for someone needing this to later revert the patch
>>>>
>>>> It is definitely true here that adding more code to keep some unused code does not really make sense.
>>>> And let’s be realistic here, if we need that one day, it will not take ages to support it somehow.
>>>>
>>>> As said, from a pure certification point of view:
>>>> - we must not have deadcode
>>>> - proper ifdef is acceptable
>>>> - if 0 is not acceptable
>>>> - commented code is not acceptable
>>>
>>> Given that we agree on that (+ IS_ENABLED option if possible), and the option 1 seems
>>> to be the best choice for the timer, I will create a patch removing the IRQ path to get rid
>>> of the deadcode/unreachable code.
>>>
>>> Do you think this is something we want for 4.17?
>>> The risk is low as the code is already dead and the benefit is that we have no deadcode.
>>> What do you think?
>>>
>>
>> We are very near from the release so from my point of view as it is not solving a bug, this should not go into 4.17.
> 
> I agree
This works for me and thank you all for the discussion!
This thread and its outcome will certainly be useful for similar issues in the future.

~Michal


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 15:54:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 15:54:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430664.682605 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onijj-0004FE-CY; Wed, 26 Oct 2022 15:54:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430664.682605; Wed, 26 Oct 2022 15:54:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onijj-0004F7-99; Wed, 26 Oct 2022 15:54:35 +0000
Received: by outflank-mailman (input) for mailman id 430664;
 Wed, 26 Oct 2022 15:54:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oniji-0004Et-Pc; Wed, 26 Oct 2022 15:54:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oniji-00065p-Or; Wed, 26 Oct 2022 15:54:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oniji-0007bA-IT; Wed, 26 Oct 2022 15:54:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oniji-0004em-Fu; Wed, 26 Oct 2022 15:54:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9Q8iGedWGWRTsz4t/ffp6nduuIhDEcq+ams7KtIfdHk=; b=k1BOIG2m9lMIABtQnCpbttI0W4
	VyKeYaxhNYdH+/5VT9LB1uurc1ZaK8cA7LaT4aYP5lyuQkMvDnP3Z2IdCzGvGDwLjxjO4x2ilm0R8
	+qN/RPsOGm8A1xHg1TgZaIxdlaiExpPk0JEuG9i0w35hqarK7fOTYccyloqv2R5BpRbQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174455-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174455: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=26bf76b48bbce3e7b126290374c64966dca47561
X-Osstest-Versions-That:
    xen=ef9cc669ba157f9e71fd79722ee43892e7304604
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 15:54:34 +0000

flight 174455 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174455/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  26bf76b48bbce3e7b126290374c64966dca47561
baseline version:
 xen                  ef9cc669ba157f9e71fd79722ee43892e7304604

Last test of basis   174421  2022-10-25 23:00:30 Z    0 days
Testing same since   174455  2022-10-26 13:01:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ef9cc669ba..26bf76b48b  26bf76b48bbce3e7b126290374c64966dca47561 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 16:01:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 16:01:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430676.682619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oniqX-0006fp-5F; Wed, 26 Oct 2022 16:01:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430676.682619; Wed, 26 Oct 2022 16:01:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oniqX-0006fi-1o; Wed, 26 Oct 2022 16:01:37 +0000
Received: by outflank-mailman (input) for mailman id 430676;
 Wed, 26 Oct 2022 16:01:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=n4Ky=23=citrix.com=prvs=291e24488=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oniqW-0006fc-5U
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 16:01:36 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 75ab924c-5547-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 18:01:34 +0200 (CEST)
Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 12:01:19 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by SJ0PR03MB6779.namprd03.prod.outlook.com (2603:10b6:a03:40e::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 16:01:17 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 16:01:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75ab924c-5547-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666800094;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=MNhskMjZloTkLeOZVgNHLz79NkqOdYCE8IQZl+2+sR8=;
  b=IePnQW0gVqiA+iDwa00ipoxfZz9OHh9DnpZ+QX520sZsSDVKAml0AUDS
   /j8MgKDbwf8x+Ei3nFaim2LltrfAeecqwVIn0P9Z9Jqp2Z4Nf0hKTZ1ym
   JgZ3dO5Th1CFsic+OjZAmY6Dp6hj5+3d1dLDsAzvqSvDwAXV96yH6fjOw
   I=;
X-IronPort-RemoteIP: 104.47.58.109
X-IronPort-MID: 82657922
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:AKjYaqLOqGNknXF0FE+R8pQlxSXFcZb7ZxGr2PjKsXjdYENS12AFz
 2RNCzrTOPmCZGLyc9l0aI2w9U5VuZfUz9EwHlZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t
 ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo
 rsemeWGULOe82MyYz98B56r8ks15q2q4m1A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T
 uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/
 /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fc4AwswnJ21Cz
 v07dwIJPyGmrfDu6b3uH4GAhux7RCXqFKU2nyg4iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe
 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QLT/PJmi4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWDbry393LWncSXTZtoTKbuYyt5ToGKK7UANBw0UX2KhiKzs4qK5c5cFQ
 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0e9dWCfx81wiLxYLd+QPfDW8BJhZRZdpjuMIoSDgC0
 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBQQ5b5dDm+dk3lkiWFoclF7OphNroHz222
 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw==
IronPort-HdrOrdr: A9a23:9n+fg6uJe6vp28Qymr+F+1dh7skC7YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79
 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M
 323Ls7m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w
 3+CNUZqFh/dL5pUUtDPpZxfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou
 WLbG9l
X-IronPort-AV: E=Sophos;i="5.95,215,1661832000"; 
   d="scan'208";a="82657922"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KOggiWP4pFpvRNoTHYnPkPAfFOlCu3dBm89p6c2DcbM6qvk+2pmLkYj8gjFSDbPNH4aZQCBi+K6NJedHmdOy3mYGzmJv1go0AzDVNtQY3kGKbMGDzBWZEvN74WUjlBtXeX71iYvmjfWNAPcZHhWsjGoReuReF1LmrBitYso6acIlKiMeVqp1ScK+O+97gYX0WX+4ztxIFPvdPFoAx3fvpnEX9BCLUR+NpF1DJloyK/hu2cZp3In7l+eK9GwerWqBYbWyUdj8fpYI7PdsiaPx0So5MHOwKwyxYFNium29E7G/KB3X3FhKIShHIZEFFkDD+316GRbZm4ocfOCKLZB94g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M8nRB5uedLk5esz7w0md7iNePwpVrvFMHRbyl66rIzA=;
 b=EcxcD9RxhNDiE2HrryoHJhMC6Y6MMcqOC1faazB3icAz1w9REXLJgF/PCMsYUmNaLJFZfsloDnOFoUn8kE5anA+hte11nEzMPeKKyGZ0DsSStKIV83Y1HzmtZHvq1DrGIlAz9BJQnjhDLp77MAY3Y2Sf4/B9IH79ngXTorS+tbXmqgrLAWXSjBCkTStNmCRxGc6L6xQVRVa8RxLGMZsKwiavB7I2SoEBFkm/MvB+lND563D8UsjyFL0JbB1MXDVMpNqnXCUynWeohvcAyQtfZWWp9uZrRtGM7IKka0SJ52WEAjmhRadCaqWqUS645WrF2S9ZS6FREVKsmCcE1Ir+rw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M8nRB5uedLk5esz7w0md7iNePwpVrvFMHRbyl66rIzA=;
 b=l9CyTDPtQCCxISur+/+Z8MOyJMJc2OI1wyl76SP8g9eeTcYMw7Ez7G1LYdBq7kALvak0APEPmtxtOhSxPktU+p+bJZP7V38U6sWdElVPp/hYPelgoUYsNLeOhr3YiwNnEjDXsU4VxIO+fTq942HOHN3R3zNBmAzFUHAfo9UMww4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Wed, 26 Oct 2022 18:01:10 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR
 is mapped
Message-ID: <Y1lZxldTIWawfpnO@Air-de-Roger>
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-6-roger.pau@citrix.com>
 <666377e8-fe58-bc9f-70ff-2e21d93c691f@suse.com>
 <Y1k88uhbSNdMvsa+@Air-de-Roger>
 <045428b7-9c4d-cbf6-3ca9-157c516399a9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <045428b7-9c4d-cbf6-3ca9-157c516399a9@suse.com>
X-ClientProxiedBy: LO2P265CA0092.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:8::32) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|SJ0PR03MB6779:EE_
X-MS-Office365-Filtering-Correlation-Id: 67b209ce-3b9c-43af-7277-08dab76b506e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YDoaJ9FjyYOpz7wxlQsLXaL1BLWGRqkVRMaovMb4SmsHiLTOG6Iz+PCHrtCwOpb56Xe4R1JRmLFGYCsvJVysknP/v34pkcnekh/+2DYnKH8O3gn85xUpUWDxASFA4ulMEals1KjpxEfLRW5ohfpGSYwfIqEWqRl3ObmEZI7kIvoJozrYVoTu+3BPqYUyaDn6IQYlmB3lQ8XNhHgdWoo/yN6cZApcn7O4fLsLx1czW/ul3gbwSLxznRaGh2T2UgvjCF9pgZHH7DnnXQlmCkrTeyK3ElVkKJEwToqBxoS88lIxjf6qleYq+ie5qu6dxkhttTdmOxVl9gWoKQ3Z5ZCyfrwTEbS5KdGz5pa2d2vKPbnWjjBtrfNWBDlNDY9BxEtjMNle888Lh0KZfI2zAGl+FERPHQ+fVOtBAHZtoIrjPY9srtTy4UJInEU/5deqjsrJwwkq6Y9xAk8t4YQq76CvDSI1Z732UUtes9RjgfTYLcNGZTMXtdniewnrERLZ5r9EF6duYCtiLO5aZZCoC6m/iS/MKafqAgBegZk3slxt5HyKDX1KwqOUIJJq3tmTorNyEbvcz/jeo34Bhc2SmFHdgPw7SBHjPXfhqW4WUfyyzpJp2KvC2ui2jH05KlUqIjkPEwpplsCX86LjaR2xu+OdRS2u55PoN3QJ5qJVAnwKCOyw+TAb2rQFApnOfwI5RTx7OS/Zlzy5+akHV7XjJ/U+Uw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199015)(66556008)(186003)(6916009)(478600001)(33716001)(41300700001)(66946007)(66476007)(4326008)(2906002)(8676002)(82960400001)(83380400001)(38100700002)(6486002)(86362001)(316002)(5660300002)(9686003)(6512007)(6506007)(53546011)(8936002)(6666004)(26005)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDhvMUY3VE16NnZiVEdVT0RtS00wcTQxQm9yZ3FpaHJXZGxORzZNdnZQcUk5?=
 =?utf-8?B?U3FwOUM3RlV5QUJJTEhTaThHQURGSkRzczNvREZBdFBaOGdraXFhSFBHbDZs?=
 =?utf-8?B?MmJoL1kwNnZHaUpoWDB6cUkzMG9Kb0JKZ3lVcnR4L3gvcHZZR2g1N0Z2TmNI?=
 =?utf-8?B?ZStjbE1sazdKdXloVk1HbVhYcUZrQzZaOGV2ekFSQ2pMLzl5bkpwNnVWbmdF?=
 =?utf-8?B?cU9SMEZMZGcvc05veERncUdaeHpjMDlmejVzRmE4bjJIaVMyb0tybEN1WkJ4?=
 =?utf-8?B?czFRUU8zWmlNYnYrN0dRQVByVjJ1MVM1Ri9QSmdkVUJWaHhUTDdhYXQxWXlw?=
 =?utf-8?B?L3FPMGxCa1FNc1hCQU82MWl6dTR3T0JrTlhZMHJjaGpyRHJOMXBKK3VZZEk1?=
 =?utf-8?B?YktxQVljbGl2SlQ0UEZpU2dLUTdqT1daZzhEWHdNWlNrcUhkR21CRmVnQUNS?=
 =?utf-8?B?dDRzNTlvMFI4N2tmMnVudFBwNzFFOFhuVk9nUktCR3c1VUlxcHR3Y3Iwbk93?=
 =?utf-8?B?cVd6UXlxTGtqSHA4YkRkK0xKZWh4Zkc3Vnh5YmxWRkNnV29yOVozQ3lpV0U5?=
 =?utf-8?B?dG8xMGg3eUU2NFRMZUZLK1R0YnZjb2RzWERHeWJRdWVJUXc3YXRmVHN3TUkx?=
 =?utf-8?B?ek02K0VDUWs2eWJYdld6dXRYYzBoUjd0WWhzZWJPL2ovRng3VytnV3g2VXRp?=
 =?utf-8?B?aTdkaDFhTElsZnBpK3dOdXB1b2ZjS1VXeWh5OVRxUG1ZMFRwVTVtUDBRWHN5?=
 =?utf-8?B?TWtQeXc0RHVaODROVVY1TDdCL2JESUgyNStCZkp5QjZTaXJkb29qRUhKQitX?=
 =?utf-8?B?Mll4REJuV01mR3F5cXFaclhiQWtYQytDRGdzM05CcTNmZlRNcDJaNzhtcUZX?=
 =?utf-8?B?QVBmOExzL0dFakxkRnFzOEFHQ1VPUWJybTZUaWE2b3hRYTdTMldaTWN3K2Uv?=
 =?utf-8?B?MGNlMEE4ZXZLeEVVNW16aE9uTDFWM1dFamljMUZKV0JFaWJ3NkhQV2JqVTNG?=
 =?utf-8?B?c1NXSVZJdGVzOG1PSldtOEQzeWpJbnVCdlRJUWZjREk5dlo4cUpBQjVNOTA4?=
 =?utf-8?B?WFg3NmZ6SEEyb1FLbGEwNWo0Ny9wTkE5TXhqM1FLR2N1UGhVK3MxbVdsU1pn?=
 =?utf-8?B?a2ZSR0NvSCtvUkRVcW9PREJBL3hVNHJHYVRrRTd5b24rWUFjL2dJMFFEYXJ2?=
 =?utf-8?B?bmxCMEFmS1YwR1lSZWpodzRPQjFaUm1NQlplMjAyUi9oMFcxQ0dRa1I2d0w0?=
 =?utf-8?B?YUVVYUMrSjc1YkVqWHozLzdhNS9sNEl5dXc4UEJiaUFNL0ZWYmprbyswYzFG?=
 =?utf-8?B?OG5Kc0psQ09jM29PdVdEUTBCWnVESGpURkJLWG5IQTFsbEMxbjdkZ2pRN29O?=
 =?utf-8?B?MFREWG1zOWhiRWxTa1RPbC9FYVljYUkxT1pkOHRqdlVLWmVlRFAraUtaNE5I?=
 =?utf-8?B?RlE5U05BczBNRVFwZzVtdnpkMHJIZGNaQkltY0VtWjZpRm9DcjlYanFGWGth?=
 =?utf-8?B?NTFZMjZTY2lHeldQTUttTmd4S0ZybElIVXJxSEpva2kyYjNJQ2RZVFZWTXY2?=
 =?utf-8?B?TGEvMTloYzQ3NGZ0VVlKR3pXSG5jNkg4LzBXdGVZVTRJZGdxRWVDOUFsTmlY?=
 =?utf-8?B?QVBQdk9icVZTdGZFRmUxMEUrQzJSS05yYmVlZmVSZ3lXT0dOSDI1SmlOQW5Y?=
 =?utf-8?B?QVY0K3RCQ1FPZ1FmeExWMzVrOVIwdndQWloySUU3eUtwTW5FNDBhbW5ndm9w?=
 =?utf-8?B?WnBaN0VuZXQ0ckhHb1M0eWV0UjRnSkJZYndtbytjd2JwaFBpVGxOZWNmUXIz?=
 =?utf-8?B?ak5nS0k5eEo0Uzh3eE1ZMDBOS3hRbENySG1xRS9tVWM0dUMyM2NhQU85c0pr?=
 =?utf-8?B?WG1iV0ljMmpQdFZlbkVBek5lSGtBQ2lleTEzRjJrVkFCWHo1Vk1nZkEzV2l1?=
 =?utf-8?B?MERGWGpJU0RkNHdNQUUvamdOVjJIRS9MVDhCV1haTDVncGhYMXdZWGpDbWhr?=
 =?utf-8?B?WHVRcDlFN2VjeXZjTVZ6QURQQ0wxZGdVVTNRcWhuOHlwNWE2RHk1MkVSY0ZN?=
 =?utf-8?B?Q213NDYrSjhDZ3FjVGNZVWNGN2V3cDRiK08rWmo3ZWt6NVhrcmUyNnp5Yyth?=
 =?utf-8?Q?jL+zICLjXAgN6GefmMKXdKrY2?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67b209ce-3b9c-43af-7277-08dab76b506e
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 16:01:16.7971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u1uCGGqd3CJkRzkIjdwYK+5Ka0UyFI4Ybf5WOO7WBVBehCBYslxHidls4617TmH2IIi7FH5KL0JsTdbP5HWnQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6779

On Wed, Oct 26, 2022 at 04:06:40PM +0200, Jan Beulich wrote:
> On 26.10.2022 15:58, Roger Pau Monné wrote:
> > On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote:
> >> On 25.10.2022 16:44, Roger Pau Monne wrote:
> >>> @@ -388,12 +391,12 @@ static void cf_check bar_write(
> >>>      else
> >>>          val &= PCI_BASE_ADDRESS_MEM_MASK;
> >>>  
> >>> -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
> >>> +    if ( bar->enabled )
> >>
> >> In 3 of the 4 cases you use header->bars_mapped as replacement. Since it's
> >> not clear to me why you don't here, could you explain this to me? (I'm
> >> therefore undecided whether this is merely a cosmetic [consistency] issue.)
> > 
> > No, it's intended to use bar->enabled here rather than
> > header->bars_mapped.
> > 
> > It's possible to have header->bars_mapped == true, but bar->enabled ==
> > false if memory decoding is enabled, but this BAR specifically has
> > failed to be mapped in the guest p2m, which means dom0 is safe to move
> > it for what Xen cares (ie: it won't mess with p2m mappings because
> > there are none for the BAR).
> > 
> > We could be more strict and use header->bars_mapped, but I don't think
> > there's a need for it.
> > 
> > What about adding a comment with:
> > 
> > /*
> >  * Xen only cares whether the BAR is mapped into the p2m, so allow BAR
> >  * writes as long as the BAR is not mapped into the p2m.
> >  */
> > 
> > Otherwise I can switch to using header->bars_mapped if you think
> > that's clearer.
> 
> It's not so much a matter of being clearer, but a matter of consistency:
> Why does the same consideration not apply in rom_write()? In fact both
> uses there are (already before the change) combined with further
> conditions (checking header->rom_enabled and new_enabled). If the
> inconsistency is on purpose (and perhaps necessary), I'd like to first
> understand why that is before deciding what to do about it. A comment
> like you suggest it _may_ be the route to go.

ROM register is more complex to handle, because the same register
that's used to store the address also contains the bit that can
trigger whether it's mapped into the guest p2m or not
(PCI_ROM_ADDRESS_ENABLE).  So ROM BAR writes with the ROM BAR mapped
and the PCI_ROM_ADDRESS_ENABLE bit also set in the to be written value
will be rejected, because we only allow to first disable the ROM and
then change the address (which is likely to not play well with OSes,
but so far I haven't been able to test ROM BAR register usage on PVH).

I do think for consistency it would be better to use rom->enabled in
the first conditional of rom_write() check, so it would be:

    if ( rom->enabled && new_enabled )
    {
        gprintk(XENLOG_WARNING,
                "%pp: ignored ROM BAR write while mapped\n",
                &pdev->sbdf);
        return;
    }

So that we also allow changing the address of ROM BARs even with
memory decoding and PCI_ROM_ADDRESS_ENABLE as long as the ROM BAR is
not mapped in the p2m.

Would you be fine with the comment in the previous email added and
rom_write() adjusted as suggested above?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 16:45:30 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 16:45:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430695.682642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjWm-0003Nu-GQ; Wed, 26 Oct 2022 16:45:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430695.682642; Wed, 26 Oct 2022 16:45:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjWm-0003Nn-D4; Wed, 26 Oct 2022 16:45:16 +0000
Received: by outflank-mailman (input) for mailman id 430695;
 Wed, 26 Oct 2022 16:45:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onjWl-0003Nh-JP
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 16:45:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onjWl-0007T2-7C; Wed, 26 Oct 2022 16:45:15 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.28.184]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onjWk-0005vD-V0; Wed, 26 Oct 2022 16:45:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dJ0eD5jsTTfJ1q74TTD/br42jRPM/NBqKlxP3ND2HO4=; b=q5tk90gGwoCfeASABgCRyXPqFI
	2J0PB1S6lmU6BtOH6j7EWI3ijiQMS19H+up+IcdhmlN4gTJXzqJjkUS3itm0B6XPIQKMbdBcX1exa
	pLcqqHO7W2KWOzLNsnPUbnTVMeQo2m0qsnibbsf2Wu0TpplKgze1iQ+GrSW30tsfrVO0=;
Message-ID: <bb8709ff-9b1a-91f4-3a73-c5f216b6b44e@xen.org>
Date: Wed, 26 Oct 2022 17:45:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, andre.przywara@arm.com, Henry.Wang@arm.com
References: <20221026133540.52191-1-ayankuma@amd.com>
 <95d0a8ca-9ff0-162a-02ae-8cbdc30af8b9@xen.org>
 <2accac91-d822-c493-4045-8657aed26fb1@amd.com>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <2accac91-d822-c493-4045-8657aed26fb1@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 26/10/2022 16:06, Ayan Kumar Halder wrote:
>>
>> ... you also need to ensure that the writers are atomically setting 
>> rdist_pendbase. Please correct if I am wrong, but the callers are not 
>> using write_atomic(). So how does that work?
> 
> I think read_atomic()/write_atomic() may not be the correct approach for 
> the following reasons :-
> 
> 1. __vgic_v3_rdistr_rd_mmio_read is a static function. So 'val' has a 
> global lifetime. Thus, all the following three lines need to be 
> protected from concurrent access.

I don't understand this argument. 'static' means the function is not 
exported. The local variables will still reside on the stack.

So why does the use of 'val' needs to be protected with the lock?

> 
>          val = read_atomic(&v->arch.vgic.rdist_pendbase);
>          val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> 
>          /* If a context switch happens here, then the 'val' below may 
> potentially be incorrect. */
> 
>          *r = vreg_reg64_extract(val, info);
> 
> 2. The same holds true for 'reg' as well in 
> __vgic_v3_rdistr_rd_mmio_write()
> 
>              reg = v->arch.vgic.rdist_pendbase;
>              blah, blah
>              v->arch.vgic.rdist_pendbase = reg;

Same here.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 17:00:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 17:00:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430699.682653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjll-0005ul-Q4; Wed, 26 Oct 2022 17:00:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430699.682653; Wed, 26 Oct 2022 17:00:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjll-0005ue-Lx; Wed, 26 Oct 2022 17:00:45 +0000
Received: by outflank-mailman (input) for mailman id 430699;
 Wed, 26 Oct 2022 17:00:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onjlj-0005uW-IM
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 17:00:44 +0000
Received: from sonic316-54.consmr.mail.gq1.yahoo.com
 (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b815b5c7-554f-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 19:00:41 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic316.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 17:00:38 +0000
Received: by hermes--production-ne1-c47ffd5f5-8c2cz (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 93f63f5da119448f595de422776c389f; 
 Wed, 26 Oct 2022 17:00:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b815b5c7-554f-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666803638; bh=zb9TRqADCGUlSjnc/6p3hLWAmFwYge6kxBzZzfgm3nI=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=hOmfJzpS1Le1suDPpUVex+MuO1fsi3K4G2dIqxNauqBTCyCe+slpTkbwhYPIpxxz/s7+EnP5PkA1v5Ktrby4d96G6iSMpVCnim1f8aUX632UneXfmDOL2ZamQVsiAaukpZveBKRgZKLKs7h42qKjLSOupHCfW6a5vxsfyx+YUlipAuxOrnXfEo7yqHhLpIIF1BXkNhpuOiYAi3LObaKMgMsU4mqV7l0k0q9nNXckx0iMTK5YFL0xNW61M3Jp1yVVkYXJYhF2vEhdGQ4gwSAXnHUnyVXlzmy45pit6TPk1gyd1gAqs+WdiRRY+1NWOeafKMWktKZxpn17l5fIyVxcwA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666803638; bh=psU36/V8qwUhsHYEEgkkx68ScTcq5dMEEdFw3pYAggB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=N4RA2j/WZca9NqhQL1SImL11htm3lq7l8UbsawDFDIm9d/PrgCxlGiasM/uWYKAOhVzyUlapJcpoabA2SPS/qPAvphdbRdqGPmcFBiZzq+Adxj/SclxGlWFSP1wFc2LQox4TZOagNNkqE524gTXNM7608r7mW9B+KrqcD3U8n9syklTUJF+Z+gz3L6Igz7EytSmyMzCW+QtUY/Fza1LhD2VkdomN406dB9uMSCGyTTVepJCYRolTT2sGmvCNeqd3jQCBFJnHgjlYhNWrs7jMbzQ7NES46mbJAY4L0ESTrMZnVFVsxJzc38ZTdIpeW8DED//mwmcuj41huuy8umde5w==
X-YMail-OSG: qqhJPAsVM1mKMCiM7fMFEtjmc3LTDFTcfwj6g3rvZezEOc_eN9s4GXzQWDU69.i
 puz0BUcOzNc3LGe_ha7HMTAIySNhZJquPdsvn3_ajRphWFNg46mdHFKHG2xF8vhOWF.ABsEliHL2
 _IQvK_Q7Y2AH_b1gE4eDHVAHsCVxdSXt8mSE05ZOb7QgvXOfkFuoufQWRw5HcDzO5HSPZzou4mOu
 kr9qDKm6DVxirIhg82vCymm98m1jgIbfkJEliFhXNA2jjO1Zz3EVuhbYllbgQENUn0xwSyT.o1FQ
 LZI0jLLbwT8BrsV0EGw905PHpluSblQDA.C0jRK.wF2tcT0YlMz.bi1YdXEQLFtaMwPJO.QGsdfd
 Pb0iEypNlnCHwqKRLyHVOnF8F.FnBAQea0OBbN9Y0YgpfeGDV8_SCH3JlpMBgxGctmUvQxPh864d
 mfy9KS7W0cHpW1ZiapW_7b0DU0Wdg8TiOhBlLdooGi1wm6jjTtjgSc_eGXCgDv7GfWlixx0VZ.wa
 3F8hyceYHn.nR1rvyvUVqGcbxl5j8u7kUnBrA_Usow_DB.42Rw9uReJypTC2.Jem8Q8hLqyb194Q
 iqeIfyKprBKG.9jxR03_7VHMLN4ZJQF0Nh8kCHDJUBRdH1ftDJWynGz0RD5lr8QYnbRzBuyqH48S
 PatwGvq4hfYwhTkbKVA6PIvnqQ4e1RS11Le_HM6LMozCeY.mgL2OY_eSuKHHVRoQ8g33bStqaxEX
 59pXiSxlx6T_szlpUhwJqnyY8UyddoB0j9VwWWXZsDytIbfvIyIAf5PJI7VfvvNSAEhwAM9_PvQ8
 3zzxe8TBJPld_W1ZSLcvKmeC9NnUTKLWEPrL_o_tPUOyg7MobuqLD8sxS9O4Ev8DzVLcOurraugz
 CbrxRcyNJTDYZOTAZ0Q5e.6XqGsqxWSkBsiPp68ssZY6GlbLDN2Ovw4KVWXegtPvwz4TpOZuYQ.r
 LyE6bSiOINbdsrrqwnQHI14xocgYykOb0qoMHnCWOealCXA3LHDFS5XMCDUj9nbtNyP6UJ2axY1n
 kw4BpQBDbXAmSd2U_6xgF14p5SXcJ.z8xy9M.F4FtcmMEX4p57XJ_C9T8phzXbKwP5zTvconEDw3
 DXJGm8aoAm0Gt7utMJfFBxh3S.92T9xcKTZf3OITEJQmNk652ySCbx6J6lOwyTVB3b5d.37xuqQ7
 NXUfeB9RKBraekXu6XV0ZXbjghe6sksHJ8JYBrpV0sdyiMAA48wJglX9UGaywNKLqQ1JZyv9mqp7
 DKLDqKR7dw9T2Sn8q9_sY599iyKoF9fYPqMOpc854MKeQHOxlyoqMbFZA850zc0dhGyWUuVyrpXl
 Q81yD5t0AoQP5D8OSt48RcmS5Fqjl1bO5QNMYA6Fo5xcCGiS.l1gIbnitEm6AeXvqSfvO.Hiv8bQ
 .0OwzP.D.FGYM.6FMm_HhvAXebLyo7OfC..T9uMW2vlv9h3vBhbBKd4X1JvgMdgQ99wMy1F8XP5w
 a6HVYnNFbofBpOdk20gR..RQePtAoybFZ_vpIiqRdJZytHPKtFNAHvbgKKdqBZYS_StFZuEIZb0o
 5eT9w8MCxQQdfPvwbdrDpWbgT0tE46oPGTAO8XrhJkSNXjt7go8.q1_DkgTqLOm9NkJFom_ZDuBB
 uNSLXjAtv3ktbITNv_asf2ktRzV.agd42A261aZHcVULi0NtVTxgOauxeatHBuIh_TKvS_nvYW2k
 9Yh.PbqgN_YTJLTw3NVGNIJ6C1aGbasxa9rtmvHphb4pKdi0jjR3WnqOusvQePAuvXpVREk1DGxW
 JVnt2uMFxehnyi.VIGfne12tWCSlJuogTyFccwCARH1pd70NLE6hoAefeUQBN77pl5thGdR10y9Y
 saNwpcoOoyqo3UtuZ_iMxSY5iDSMTaaxNTFLw05URUZxrsI2W2s5RG6m4zmY9mZsGrqCjVj9dXDe
 G7Skc.2BJNBuCTArlWuSA5Aycctc.g2k2V0N2xMWQgTCVYhjZTT8URdMzOxZka6XK0lnjEqRNO3U
 pi_NR4hp6iWnsGU343Kvv9o2NHva5slIB2eQnKNNjCELhGJRDo9JaE2yvuOf2tyVWfncnf7HB9jJ
 WiyEgloEG87y_rhL.t58AS0QlV_dr_6djXtVx3ihvkApHbGcMbFAmqKhXSpfcG87iIGyVDv.AD82
 Vx7NNTwYvyVqlaWzj7Vz60urTSu0nMKdr65_Xj_Lg6FFKX3qP2G3BMmYbSlK3Qp6W1fZquxoLA41
 F9Q--
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v3 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD
Date: Wed, 26 Oct 2022 13:00:25 -0400
Message-Id: <cover.1666802059.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
References: <cover.1666802059.git.brchuckz.ref@netscape.net>
Content-Length: 1640

This is a series of two patches:

The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough
configure options are set with when building for the linux target os.

The second fixes a regression that was introduced many years ago with the
upgrade from the Qemu traditional device model that is still available
from xenbits.xen.org and based on very old Qemu version 0.10.2.

The regression is that the Qemu traditional device model reserves slot 2
for the Intel IGD on the PCI bus when the Intel IGD is passed through
to a Xen HVM domain, but the current Qemu upsream device model does not
and in fact results in a different slot assigned to the Intel IGD.

This behavior does not conform to the requirement that the Intel IGD must
be assigned to slot 2, as noted in docs/igd-assign.txt in the Qemu source
code: "IGD must be given address 02.0 on the PCI root bus in the VM."

I have used the second patch of the series for the past two years with
no problems. Without the patch, the reliability of PCI passthrough of the
Intel IGD to a Xen HVM guest is very poor, and in some cases the guest
fails to start without the patch.

v2: Remove From: <email address> tag at top of message

v3: No change to this cover letter since v2

Chuck Zmudzinski (2):
  xen/pt: fix syntax error that causes FTBFS in some configurations
  xen/pt: reserve PCI slot 2 for Intel igd-passthru

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/meson.build   |  2 +-
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 5 files changed, 49 insertions(+), 1 deletion(-)

-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 17:00:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 17:00:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430700.682664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjlp-0006Ai-61; Wed, 26 Oct 2022 17:00:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430700.682664; Wed, 26 Oct 2022 17:00:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjlp-0006AY-1y; Wed, 26 Oct 2022 17:00:49 +0000
Received: by outflank-mailman (input) for mailman id 430700;
 Wed, 26 Oct 2022 17:00:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onjln-0006A5-QI
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 17:00:47 +0000
Received: from sonic308-55.consmr.mail.gq1.yahoo.com
 (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ba1a1f97-554f-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 19:00:45 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic308.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 17:00:42 +0000
Received: by hermes--production-ne1-c47ffd5f5-8c2cz (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 93f63f5da119448f595de422776c389f; 
 Wed, 26 Oct 2022 17:00:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba1a1f97-554f-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666803642; bh=eU7PpBLLODdhmYNTWitUDr6syhPI4x30puQr0AkwZn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=JNWP5RxiSEimCPsFJEl5ySrpR8ZaHnJfgcTFBWhbHjxa+DX+yv6qC507mCEFdXj4/5qw9+e+sJD3nJgbF3jvpqbggjXIU6S0u9IzPaTBCIaufbrPLAWwxF6E/MpNiwtbZDFJ9H/N4+hd+V3eRGrbKyLh45olIAZu0D1lFyhzP1zlMoAvrx4m0Wg/f4sXw0yShsnFHWki+lppr6yAe+6P2yqp+/SFiRihd9lYQubx6sEB3q5uJhSk1Vd6rLpHo35abuciG1TlYlhg1e25xb22wMH5HSa1VbUdd9dHc7rpNCLs0UZb4+70twf1G8C3ZPxmvXF5C+crj7/Qj1tnZ0pkQg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666803642; bh=FXj5u+59eDkG4z/KjVnwtjqV21VAHHrc8/npF8OKk4t=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HUpTDXsO1/GSukqr3jTqsIL846hT4f4YfXtyBNVwLcjf/31l7VEHy+PZv+ScLGacBqJi5sHrRBCxxR2tDLGVPg3YpTco5SrKJsi1Jww8A+H2nOR/nbF9VSC4hn9ai1yjDxwnAMrqzwUw6ldJAAyx27sfjo5b70LX5aYbkN0e6VcciaoSmwTBc4WVTN0jDRBjelR1++ytOnoOb4EXgTkKuIP/uM2fQ6jgsKl+LKoU7+GDbQf0AaTTKFvVPerg2+ji7bwNIidcXrxUuAZdKtjINqJSkg1XzQdP9KMNeLSvwdzJW3d3Da/HnY+Q8qEj+/KQsmeaDZwrBDyjiPIZ+d7NOQ==
X-YMail-OSG: bzItIX4VM1mi9pZWtTQTBkPiuqurRbhqdnekxPNUMqpuXt._1ZwXAh.j5pzGcHG
 tuG4gfVPZkxPTHgP3RoPQ56NHOFwnm0wZcEJEgRA.qwntNEjJHFacsUahBMO.mGHXWpgF.BBIr6D
 f1Hq5w0_c3JrwIyhbYqeIYxaTdWgjKkFRXG4pr8ySj1d8VFyVZ6ZwGx43bTPd_iWFvr6Ef73e2Nn
 S1pHC_wTyYwGCv3FtMRKsm_nIEG3BhWa541rC0ipTVanydFS2j0D7jzpEYQwTbOoosq1zuSMXCat
 IoUEc5LXejeEQyp5ETHbNina2ycd1OuOnwuK7fQI9JUiH4aYSMnwOdTkUO0P.vHAfZuuMmUAHRyZ
 XyDToY0TRNjaNWEz7QS_2qHQhwp8iNYsbp9AqX9qorX.hWtvnImJkKJ6gr7BTZYS4lAqO9TKb7VK
 rL59ezfk8OMxt3DMqKnXPOxmIJSg1EetWMAtsCf8Y3Wu0Zt_VG0SZ23BsHkddTd9jq1x8WItyvf9
 dm2.7QRoqYFx0XuubQ5QAzR6AGB4mJdr.vEyT3O3ZztkRjVUcwWdHF5SRfYAVGzyuhUI4QvjAWvS
 xcjeksl3OT9Ql.V41tax_qOWohQuNDUC1uWUUd.5gZJN3ybh5LW8Y6A9n7A.n86EYnwr8s7l9QL5
 BjUAKECJlRNcLfj0L8TuzPCDLfH_urW5Itkam2jkdSmmPzH7.fALmmQNcomTqOMkBQb_4B1bWzN3
 1qKPykeQqosAEgSq4y_cmq0_Jik0c3S.Mios_Quoa7zknicejDjNyLoYAn39hAlsQcVQrfedk1YT
 yi0_yBCiIwYEKSt_VvWSOndEi_rB0E.vu7231jUvpdYDUnPSJd5Gz.F8UfZjDhucGKa_uCao.kZ3
 x_8uNdvGF052axxVf8oIhpKrwjtyM38eToCsoDTWBtm15ptWb.KnZuP7aOobSw7ZMJREdI4FbHeT
 PXgAIyiw.RLmZRREF1CioTG5H.d_XRILScBzWf3VQW1OaYPtkiwZn7HVmbzKWrcKybhQJQK6xGA4
 twqWo_voi3Fq10vq2wpMEZMFcJ1iQPU5OlARuSMyWQIhcv4uz1F.mLSqwp7Up4HmQPeNCFJu3Qdo
 pDj9.Y4i3qEazsEp8pyEmPiMFzxELtH9xxZ6I7OBoOfE4CMY4q6leUsy3diQUu7IJDUhuJeXxdrw
 vFhe7m1v5LQMHwPiDeXup.MRTxKmw9I7iud7ID5k_gyNdnUUaDQds0V6W7auum_16N45B8VpaBvD
 f1HGpTFV.XMJecrVXmtK2y2reVe5ImeHcZPkKRIw8.iw46ks21jRrBHOGZATpOW6l6B0Mw_fcy5u
 MIJ.kOWzbONVc3FhvB6DiyKnv05.dcCCXt7lrFUL89EDsrRZ3xVTfzGMZVSGLXFTWKMdyLtt2DPk
 e1t5o7CVWMOxjrqHjfde0WnzAWAn2ecG0QaaN1CnMzxFJKGZNj6j_qAIaOA9O6E_FbiuuqlANMrv
 JUZP2DnB6t3V1yPOLU1vrNpw7RRLSYMVN3EMK.e_5Ndcq3DO2ZNSFphilpmCNRbgShaNdesw5rke
 hac9lp529iMSLPxFWZwIGPtmUMR9M3XDHrQg_NlGGKkvgHhQ7dNSea7CzlhUBXVeqbnzbZA6C20I
 zNVLwTObc8XneKPMn95fiCXIlIKouUE1oDSbP.n3Y47k3tzGGWMMbA1ziW26r8zH8Bn2M_gx0TMW
 WQgmcwmdiUY9HXjCsSsrCDCqNsQ5T4UtSzoyYAxOHMM3nfkh1I_PwLBCjKxTC4xUIOnNnXz_61Ow
 .8I1LcUL6SZDwWXXUa0UslXxoxqlLBL1BaEEaiqIKBvXpdVSFSjhMzT12.a_wiYU.ZQCiB4U9NV0
 63DAezE8sUVytZLw9FowqT.MEg.HNKEvDZfIDf30iJmzYMfutUxoUQZDSVGSet6OvwE5qsqIK7J4
 V4ttTU6aXBStkx7gX_PCMxjyuHPFrF2GFjyo7_EwJ2MNGmMhUp1jGhtNyQisZ_E8nemsXnqnKEEH
 sFiJ25iTG7jeGIUZ.2xOvIJX7t2AVq0VTVXutvW0F._OAmsN.05Qg.XXyEftdjP3fcPh5xzD8nO_
 Zjt_chzcAXyv8MnxCWfxu3edbGnD0..pgiTrpNMAxx2twdHsVqWq6aRa_ssw5ZIDfe5FC7yqs6M7
 nd1yToQ6Tef.1N1BKv4ZPuNKM1Q0WQDeLhRny.Az1xOJge5e0x2wRGilz75AruBcu6NduQsPJAtI
 3jKuupKt6
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	xen-devel@lists.xenproject.org,
	Chuck Zmudzinski <brchuckz@netscape.net>
Subject: [PATCH v3 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations
Date: Wed, 26 Oct 2022 13:00:26 -0400
Message-Id: <1b63dcf10b2e99c6dba5f0c9b16bac3ac58d3848.1666802059.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1666802059.git.brchuckz@netscape.net>
References: <cover.1666802059.git.brchuckz@netscape.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 869

When Qemu is built with --enable-xen and --disable-xen-pci-passthrough
and the target os is linux, the build fails with:

meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist.

Fixes: 582ea95f5f93 ("meson: convert hw/xen")

Signed-off-by: Chuck Zmudzinski <brchuckz@netscape.net>
---
v2: Remove From: <email address> tag at top of commit message

v3: No change to this patch since v2

 hw/xen/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index 08dc1f6857..ae0ace3046 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -18,7 +18,7 @@ if have_xen_pci_passthrough
     'xen_pt_msi.c',
   ))
 else
-  xen_specific_ss.add('xen_pt_stub.c')
+  xen_specific_ss.add(files('xen_pt_stub.c'))
 endif
 
 specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 17:00:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 17:00:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430701.682668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjlp-0006Dh-EC; Wed, 26 Oct 2022 17:00:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430701.682668; Wed, 26 Oct 2022 17:00:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onjlp-0006DE-9m; Wed, 26 Oct 2022 17:00:49 +0000
Received: by outflank-mailman (input) for mailman id 430701;
 Wed, 26 Oct 2022 17:00:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/gdy=23=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1onjlo-0006A5-Ce
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 17:00:48 +0000
Received: from sonic314-19.consmr.mail.gq1.yahoo.com
 (sonic314-19.consmr.mail.gq1.yahoo.com [98.137.69.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb0df635-554f-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 19:00:46 +0200 (CEST)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic314.consmr.mail.gq1.yahoo.com with HTTP; Wed, 26 Oct 2022 17:00:43 +0000
Received: by hermes--production-ne1-c47ffd5f5-8c2cz (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 93f63f5da119448f595de422776c389f; 
 Wed, 26 Oct 2022 17:00:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb0df635-554f-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1666803643; bh=HXJgswFBRRtT9kaDj9qpnwme4wa3QKPBT14ZHv3IuAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=h2sC5ENKC6sY9lhvU1I21u4Jhkme4x/zyVVxVAanjFIqME+TnVLzTAqaHGlriTRjCPcN+AnOc/5W4PYDqUlbxygaYm+tVaD6kre+qdf5DZyjavwrQF7pe7yITcEifXt7mm4hwusT+gSuSFWSa9l8jfhcwaVROr9DQ9ImVaX0i1ke5yOQphSDubGAoeufSwU89k4/H0Ta/C54UD1de0XWcli6gM8u7I8H2snBhrs0/L8X9Lt/PvDPLg1OR+zAyAHD7lJt9kXqdfk/vZZVw030iFFwhYvrd+2ViWleZpw1/L2q4Jh/ccaRHy5wAAZQaVdjy18lLHPt7CeiWyiN5LTYzQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666803643; bh=hI/bVGYJ937dVcuMfGwaxi78BNd+35SdIf3yn2Pl+fy=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HcJO0HuRj1berk1VgSley9XOCw0PmJRq1kjQw8BeJTGfuHEEcrDdv7GXdiQshQ7YzBcNDTib0XEcbSD//Vtq0tgWosdXhfJxO0BgMqZ2ByJztrvyWzPPoyx/5rTg3m0UsFW70R4zhf0/xtU1LefPA/EyBFxWOrvocNzI6yofKNDW0TGsi9vEdahePJMOhR824X3uJoVeyrWuTsNcGzIU4un1I91AN0Ihouv6DGNdwnhsMm3lTBVgLjWrCMd/oG7Qap/fyx+5h9c1H8F226wvRrjQcR26bNYhkGP9GnsIVwpDyqwWs6hkp3NF7YgHGyJV7zwN5azlM7SwjXsVhB3iUQ==
X-YMail-OSG: c29YqMkVM1leNLHSXhYnexgZfpg7xzousfaeplUPHAbmtTJF7_4Fs4b788dSVES
 .r1EZG7l8T4pU9uWTNartiXk4vpN2Zc.zmEqT9dLjcy8IVWHzCiu8hm2xjwAdv6z6c8DSpCvWd7H
 QeQQjOUQ_PodbEvgd_Oj9b46Voe5fgVpHHgadS955ctiFef2nMNLznf4BA2Alz0dBcxL9xS7TWub
 BwuiMNEpjOZmyheCH4T_sDyTFdgefoQbaTea1OyhKRXCLXCeUuYn5LNDOmmejsd_5R78jRRCrVsz
 S_Xc6B_F85FGCngo.Es_bZjsAitCF0bpLQj4neFDhDoVl4_j8lRyFpeaXUJ1r_b3KUhuavN2HRUT
 56TZcEaBka4UWPC7OqZDYnSK4EazrXEjXLOXYs5HzDYYmcBu7cXiSVnlGFrZjAfz_3Ciy3K5cS.s
 2XynfC7s9VDMpjKltNkaPge564AxdeIbVevLx52O88tc7tOPT18jXZG.rr8KL0HKdwaUFieMItMm
 lwvRk5WrfFz1EnTLxrxRzjlVFF.n.fiyci9HfYO4wESiEoqVSyIJ1FVl7hPpc1j4jRQnR29Pu2Pj
 h7.1gouPY9ZAJnSsSY3ga2v1IXWx_dFo9TlRFTIuWiN8v62NZ5IbW_u0skQxSKi7egVvmUaiWlOv
 IZT5I.IEg2tR0.Iq9P93ek8iu9sJAktJoAmGOh9fR9u6EK91M8FlR1uHu3bmczDzLIMf_ej2CG.z
 RhxVaO0ySxpuEp5.123sn9.h7yQ09dFNHcSoVhiIerdwaxL2rx8HF5FjmKI2ah79qOda5m7VbgQg
 NDd3e_84UnJtPHT_uMospkM0lEB4qwHUy9T5IXeniHIF0qZnFV.hXaxyhgK2oxGXF4iNIchpN3d_
 HgL5Y7Gh_xEm.9P8grDRntUzRwBCLyv4ub1QFsA1w9xc0d.tfSaw.kKR0SqsZSMwhqOauZluuvf1
 2ULAxAmu6xCcJBfrxWA1a4ii3cC46pz3KcTQ8MX5MeakYZoIQVpKv_m_KUIGbYwPTw_Nqxdzv97Q
 rhfRhnHqF9kCTBobeCP.vnvzIz2EHYfDq9Ag91JBFjTZ.EqHCs2O0iHdHnNTYxjIKJai70XdRlar
 yM7XL94jMuky0mOLt3CgvFN5gVJdMTzCTvXy0aBQ5CmaFS0aS3DpWt2ykZjLJaG62pKSr5JxoC5q
 NCn4YFLAY3s6sK1pEETFRfb_hS.WTQEazVYEAHwLTTje0A88KJfZna1VH8is_NUEslySU6tzvoMU
 gVtjwsbgGsg6WC0m2N1Y8q3_4SnhWWGT.24saLA9ArPJMtVdT_YrK2XyzCmlpQdpSDS1pgpl19xM
 t3wbfGTw9dVVB0XIsyH1pyEofV1xHY1QZC8nxOe5XTyaW9qyke83Uvce6_IlO98u1zYHLHJkeCTy
 VWy3M2jx41ax4hv7k.peSA27DGVSWANg1x3IwbBQjP58Bk_nR6gJO97Vn0h7hR.jyqh9nmO6ppd9
 RgA97WKK2Xlha0CF.3Z49mIGuH6nQEdC06MePFJWWsE8NWHii5ARsgaEa244xRzpONhrGQy0Vn3L
 s6HQm_wySZWaDosicXPlGGnSQNgPCJ8tHHgVMHscns9WvV4sAylKwQF7mavI3Jw4nEBEzlGfEYoP
 nvyI6Feq3rZ4TfeN0AIhrwltm8Q_6thdR4M1HsiqN3RbvHG8ophOlfBdIiBM0dmdqPdpp7MPX.Sp
 ACF03FS0Vbzd5GRxQ3KAqtNa0ZXHZu3u1gRC7x62UurAoE7DRMG_NhGpJW_t4e4HF2.eWPiT2otI
 BRTa7H5ILs8mMVrRa.SYNmQtiOhvI43EsSOWz6QPraVIv_HjKg680bxfqpDvvNaRjKxCLVzuS0H2
 Jtf8eAwqjx.53K0hKBF_RnvS8PHzMgNdovVQjJjsrlEbAxjtUwCWxsE6Wmhi1Z4mFONz9de5IQqA
 v9WlJG4f6L9t114nJhcjF1AnQl3gcIfRf4Op5PBtJCrATc.LhEiSV2NWkeXItazFTJ8C4StSDu_p
 ZX8pOqcSBoUEEhRjO3o5yWhpvCOzcqERB6pkaWm4.R6mDCtua98AnSRj91.3XjC9tmL7kq2lGeA9
 RMBOFQZPkDnyv2.TjBuE2cghITNxt9X17G3e3n8pHVTTSbWFV6e58fKxQgzkZHO_dgwICSPmsq.J
 PIvVV45tWGZK9rjUJpbuTaWzj9WtTJOdq4q9VbQCuGeJzGRU9vZrpKM5ZoBN8kwpO2v1qZ8P53GU
 XvaetrS2E55Dm
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org,
	Chuck Zmudzinski <brchuckz@netscape.net>
Subject: [PATCH v3 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru
Date: Wed, 26 Oct 2022 13:00:27 -0400
Message-Id: <69ddfbd373a61dc3ec29b405191abf5eaa9a2650.1666802059.git.brchuckz@netscape.net>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1666802059.git.brchuckz@netscape.net>
References: <cover.1666802059.git.brchuckz@netscape.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 7732

Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus,
as noted in docs/igd-assign.txt in the Qemu source code.

Currently, when the xl toolstack is used to configure a Xen HVM guest with
Intel IGD passthrough to the guest with the Qemu upstream device model,
a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy
a different slot. This problem often prevents the guest from booting.

The only available workaround is not good: Configure Xen HVM guests to use
the old and no longer maintained Qemu traditional device model available
from xenbits.xen.org which does reserve slot 2 for the Intel IGD.

To implement this feature in the Qemu upstream device model for Xen HVM
guests, introduce the following new class, functions, types, and macros:

* XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE
* XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS
* typedef XenPTQdevRealize function pointer
* XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2
* xen_igd_reserve_slot and xen_igd_clear_slot functions

The new xen_igd_reserve_slot function uses the existing slot_reserved_mask
member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using
the xl toolstack with the gfx_passthru option enabled, which sets the
igd-passthru=on option to Qemu for the Xen HVM machine type.

The new xen_igd_reserve_slot function also needs to be implemented in
hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case
when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough,
in which case it does nothing.

The new xen_igd_clear_slot function overrides qdev->realize of the parent
PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus
since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was
created in hw/i386/pc_piix.c for the case when igd-passthru=on.

Signed-off-by: Chuck Zmudzinski <brchuckz@netscape.net>
---
Notes that might be helpful to reviewers of patched code in hw/xen:

The new functions and types are based on recommendations from Qemu docs:
https://qemu.readthedocs.io/en/latest/devel/qom.html

Notes that might be helpful to reviewers of patched code in hw/i386:

The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does
not affect builds that do not have CONFIG_XEN defined.

xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an
existing function that is only true when Qemu is built with
xen-pci-passthrough enabled and the administrator has configured the Xen
HVM guest with Qemu's igd-passthru=on option.

v2: Remove From: <email address> tag at top of commit message

v3: Changed the test for the Intel IGD in xen_igd_clear_slot:

    if (is_igd_vga_passthrough(&s->real_device) &&
        (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) {

    is changed to

    if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2)
        && (s->hostaddr.function == 0)) {

    I hoped that I could use the test in v2, since it matches the
    other tests for the Intel IGD in Qemu and Xen, but those tests
    do not work because the necessary data structures are not set with
    their values yet. So instead use the test that the administrator
    has enabled gfx_passthru and the device address on the host is
    02.0. This test does detect the Intel IGD correctly.

    Sorry for the extra noise.

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 4 files changed, 48 insertions(+)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 0b1a79c0fa..a0f04ad62e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -402,6 +402,9 @@ static void pc_xen_hvm_init(MachineState *machine)
     }
 
     pc_xen_hvm_init_pci(machine);
+    if (xen_igd_gfx_pt_enabled()) {
+        xen_igd_reserve_slot(pcms->bus);
+    }
     pci_create_simple(pcms->bus, -1, "xen-platform");
 }
 #endif
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 0ec7e52183..c62f03dd9f 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -950,11 +950,35 @@ static void xen_pci_passthrough_instance_init(Object *obj)
     PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS;
 }
 
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+    XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n");
+    pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK;
+}
+
+static void xen_igd_clear_slot(DeviceState *qdev, Error **errp)
+{
+    PCIDevice *pci_dev = (PCIDevice *)qdev;
+    XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev);
+    XenPTDeviceClass *xptc = XEN_PT_DEVICE_GET_CLASS(s);
+    PCIBus *pci_bus = pci_get_bus(pci_dev);
+
+    if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2)
+        && (s->hostaddr.function == 0)) {
+        pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK;
+        XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n");
+    }
+    xptc->pci_qdev_realize(qdev, errp);
+}
+
 static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
+    XenPTDeviceClass *xptc = XEN_PT_DEVICE_CLASS(klass);
+    xptc->pci_qdev_realize = dc->realize;
+    dc->realize = xen_igd_clear_slot;
     k->realize = xen_pt_realize;
     k->exit = xen_pt_unregister_device;
     k->config_read = xen_pt_pci_read_config;
@@ -977,6 +1001,7 @@ static const TypeInfo xen_pci_passthrough_info = {
     .instance_size = sizeof(XenPCIPassthroughState),
     .instance_finalize = xen_pci_passthrough_finalize,
     .class_init = xen_pci_passthrough_class_init,
+    .class_size = sizeof(XenPTDeviceClass),
     .instance_init = xen_pci_passthrough_instance_init,
     .interfaces = (InterfaceInfo[]) {
         { INTERFACE_CONVENTIONAL_PCI_DEVICE },
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index e7c4316a7d..40b31b5263 100644
--- a/hw/xen/xen_pt.h
+++ b/hw/xen/xen_pt.h
@@ -3,6 +3,7 @@
 
 #include "hw/xen/xen_common.h"
 #include "hw/pci/pci.h"
+#include "hw/pci/pci_bus.h"
 #include "xen-host-pci-device.h"
 #include "qom/object.h"
 
@@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg;
 #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough"
 OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE)
 
+#define XEN_PT_DEVICE_CLASS(klass) \
+    OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE)
+#define XEN_PT_DEVICE_GET_CLASS(obj) \
+    OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE)
+
+typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp);
+
+typedef struct XenPTDeviceClass {
+    PCIDeviceClass parent_class;
+    XenPTQdevRealize pci_qdev_realize;
+} XenPTDeviceClass;
+
 uint32_t igd_read_opregion(XenPCIPassthroughState *s);
+void xen_igd_reserve_slot(PCIBus *pci_bus);
 void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val);
 void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
                                            XenHostPCIDevice *dev);
@@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read)
 
 #define XEN_PCI_INTEL_OPREGION 0xfc
 
+#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */
+
 typedef enum {
     XEN_PT_GRP_TYPE_HARDWIRED = 0,  /* 0 Hardwired reg group */
     XEN_PT_GRP_TYPE_EMU,            /* emul reg group */
diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c
index 2d8cac8d54..5c108446a8 100644
--- a/hw/xen/xen_pt_stub.c
+++ b/hw/xen/xen_pt_stub.c
@@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp)
         error_setg(errp, "Xen PCI passthrough support not built in");
     }
 }
+
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+}
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 17:18:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 17:18:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430714.682692 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onk2L-0000d0-VW; Wed, 26 Oct 2022 17:17:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430714.682692; Wed, 26 Oct 2022 17:17:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onk2L-0000cp-RK; Wed, 26 Oct 2022 17:17:53 +0000
Received: by outflank-mailman (input) for mailman id 430714;
 Wed, 26 Oct 2022 17:17:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=azgP=23=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1onk2K-0000cj-Hy
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 17:17:52 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2084.outbound.protection.outlook.com [40.107.94.84])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d5a4d17-5552-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 19:17:49 +0200 (CEST)
Received: from MW2PR2101CA0007.namprd21.prod.outlook.com (2603:10b6:302:1::20)
 by CY8PR12MB7611.namprd12.prod.outlook.com (2603:10b6:930:9b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct
 2022 17:17:45 +0000
Received: from CO1NAM11FT087.eop-nam11.prod.protection.outlook.com
 (2603:10b6:302:1:cafe::98) by MW2PR2101CA0007.outlook.office365.com
 (2603:10b6:302:1::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.0 via Frontend
 Transport; Wed, 26 Oct 2022 17:17:45 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT087.mail.protection.outlook.com (10.13.174.68) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 26 Oct 2022 17:17:44 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 12:17:44 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Wed, 26 Oct 2022 12:17:41 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d5a4d17-5552-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZvFhiTWKHqduAcnIErXfynJeYKEpj2O+0OctTZ3nldYuL6l3Q99mdlkxfVaMT1cJKVIu/R5LUwAJ9s+96hwDddkt1tNAhN6YCACOEkNCpQjsU8+Zg3VFXFe/m+cGOrDDdFByv5/90VviIppdcaWBBZofKLlXjReA83PhjhTpr500qNPY1K981tPgHmb+PuXE982jiGRoGWsdEoGCJ348gbIlxp0V4VGZ75kyIN7gBB7lZ3McVoywBl0MvLjoaXmvRP1maSRIp5BUfxpVYkiOy+0/BzfsZwugMTwRozXVCIvItomdJctND39sE77MmFQ7Ym0kQ8n4cIJC5DZXu/38Nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k6TCyx2iWcfkvCOoNyftXRpBX6ft6Xvxvt7fMRXQa+0=;
 b=AfMKY0VdCkPzVk3jgdYDNewbVx+IB3XXAKhOsuW7s/53xBBgVlpl+4Er8nwvAkcbLW+05h9ZG5iHsJsEwhVCh0fDEEO0cIhZ4Q0pYz18/qx2MZiLFF4jMr0G6M7fbbC/Xah+4Eo0XPViR7kGNfI4U5+gahWVwrsNLcE7xms4bLHcVc0JvrVUZwUQK8yEsMVP/3AOJp74u3J/sVUt0YNCa2yJXZdxwSjVmCx4TTRyq36MeDTkDU4bOmUdj3mUblF5c6TbhZ5br8fUzXNF/Xz0ImoRPEgauV+Z696TYkZLBU1CguFZuUbu3xrXahDTAEdRARxMrfnWTpmbjOtErtS9Rg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=k6TCyx2iWcfkvCOoNyftXRpBX6ft6Xvxvt7fMRXQa+0=;
 b=sqEYXEeuPOeMIcRrMb2YjQFzk9Yi5Ve9n307VYTPJUYLiBj5HzNiaFLcPotMwpKyHkl5oljK//nQ092oUE9QZgSXm0xjP1ahjDlcUGpuOEbvzIn1rJHDQomQb+AyOUNa+/SFYu5OGgj8xROODxeOEPOKQDNJVpgO6Wut2nBx2/s=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
Date: Wed, 26 Oct 2022 19:17:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Rahul Singh <Rahul.Singh@arm.com>, Julien Grall <julien@xen.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT087:EE_|CY8PR12MB7611:EE_
X-MS-Office365-Filtering-Correlation-Id: ffb817ad-1f71-4cac-cf72-08dab775ff65
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uGQVYPwGREQV3oRFJeLh5qeCg1g+Lina+O2IBNsvleOIkQO9ycz8ZKy8F+Gs4mW/rS1H5oTs/SDMNKZY9NlzswIbo2L9jdGWFoWzzXKJUg5je7NvsDn1YoUUnsWsIDLSAPTuK31fcDVX0NOBCt0lyAw/4ehX2Q4VrGW+l8k6v47zS9JJ9yjU3CkaDwHn1OYrtu4b/oKCRqCUeA7kIHbqnyb2M1RfSdBvarh1ODsIw6uF2pPHf2Ez0XdJeqrxYyAqLTSRc9iQQ/c/wsnigi3YoyDBTxUHeK3dFrEGN1L5Rp/YtMipq9jWbA69kwWZVRtqYJS2sqbiR2zVIflPEGkSiPAyOyRoiNrJ35JPwoP0pFbOovNrZP/dLCuJHdym2m/q3/HIAdvGZKIQvcbJaE1o9z2SLipbKKhvQfHvwIybld+futW5yJUh8Sxkg8lw7vZjjLPn1QQvCWWzNUanAwQwa497ol3TvFa/pf/ws0JrXvc56mKYYmtbp7it89g01Rk5W/3YK+aINSkMNlw32S3C4PvRzfgmxiQaOvu/Vwq0QWHi2S1I0kv3DcF+9hTV+HD4eZAwZ5v+L1Sk7zIIUp8MENNpMpPg0v9EDJwbN3G3Z8WSzb8VGG+E304GYHmAOeHJORbz4ow6naHzJfyl1fVzocI2HcLsTs71aXgOOb0AWfppaHTdLBLVO05W5D1Pr+gnZetHr0aFfJlEzTsEpu2bRtl79UBw9YAz8tXM4SmS4QOKKO5ctdu/fZEGpoN0W4eYrXbGL5nAQpuRWadKBga6Q20pt7L+chgy0DxgFllq3/mq/K9Z7u6Gya1NWQelc4TOrgtDJFG3l/JtU6j400zE+Q==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(44832011)(316002)(356005)(16576012)(81166007)(83380400001)(110136005)(36756003)(54906003)(8676002)(70586007)(70206006)(5660300002)(40480700001)(2906002)(41300700001)(8936002)(4326008)(40460700003)(2616005)(426003)(47076005)(336012)(478600001)(7416002)(31686004)(36860700001)(186003)(82740400003)(31696002)(86362001)(26005)(53546011)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 17:17:44.8703
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ffb817ad-1f71-4cac-cf72-08dab775ff65
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT087.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7611

Hi Rahul,

On 26/10/2022 16:33, Rahul Singh wrote:
> 
> 
> Hi Julien,
> 
>> On 26 Oct 2022, at 2:36 pm, Julien Grall <julien@xen.org> wrote:
>>
>>
>>
>> On 26/10/2022 14:17, Rahul Singh wrote:
>>> Hi All,
>>
>> Hi Rahul,
>>
>>> At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3.
>>> To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the
>>> device to the guest that is behind an IOMMU and virtual IOMMU is enabled for the guest there is a need to
>>> add IOMMU binding for the device in the passthrough node as per [1]. This email is to get an agreement on
>>> how to add the IOMMU binding for guest OS.
>>> Before I will explain how to add the IOMMU binding let me give a brief overview of how we will add support for virtual
>>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 Nested translation support. SMMUv3 hardware
>>> supports two stages of translation. Each stage of translation can be independently enabled. An incoming address is logically
>>> translated from VA to IPA in stage 1, then the IPA is input to stage 2 which translates the IPA to the output PA. Stage 1 is
>>> intended to be used by a software entity( Guest OS) to provide isolation or translation to buffers within the entity, for example,
>>> DMA isolation within an OS. Stage 2 is intended to be available in systems supporting the Virtualization Extensions and is
>>> intended to virtualize device DMA to guest VM address spaces. When both stage 1 and stage 2 are enabled, the translation
>>> configuration is called nesting.
>>> Stage 1 translation support is required to provide isolation between different devices within the guest OS. XEN already supports
>>> Stage 2 translation but there is no support for Stage 1 translation for guests. We will add support for guests to configure
>>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU hardware and exposes the virtual SMMU to the guest.
>>> Guest can use the native SMMU driver to configure the stage 1 translation. When the guest configures the SMMU for Stage 1,
>>> XEN will trap the access and configure the hardware accordingly.
>>> Now back to the question of how we can add the IOMMU binding between the virtual IOMMU and the master devices so that
>>> guests can configure the IOMMU correctly. The solution that I am suggesting is as below:
>>> For dom0, while handling the DT node(handle_node()) Xen will replace the phandle in the "iommus" property with the virtual
>>> IOMMU node phandle.
>> Below, you said that each IOMMUs may have a different ID space. So shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the user to specify the mapping?
> 
> Yes you are right we need to create one vIOMMU per pIOMMU for dom0. This also helps in the ACPI case
> where we don’t need to modify the tables to delete the pIOMMU entries and create one vIOMMU.
> In this case, no need to replace the phandle as Xen create the vIOMMU with the same pIOMMU
> phandle and same base address.
> 
> For domU guests one vIOMMU per guest will be created.
> 
>>
>>> For domU guests, when passthrough the device to the guest as per [2],  add the below property in the partial device tree
>>> node that is required to describe the generic device tree binding for IOMMUs and their master(s)
>>> "iommus = < &magic_phandle 0xvMasterID>
>>>      • magic_phandle will be the phandle ( vIOMMU phandle in xl)  that will be documented so that the user can set that in partial DT node (0xfdea).
>>
>> Does this mean only one IOMMU will be supported in the guest?
> 
> Yes.
> 
>>
>>>      • vMasterID will be the virtual master ID that the user will provide.
>>> The partial device tree will look like this:
>>> /dts-v1/;
>>>  / {
>>>     /* #*cells are here to keep DTC happy */
>>>     #address-cells = <2>;
>>>     #size-cells = <2>;
>>>       aliases {
>>>         net = &mac0;
>>>     };
>>>       passthrough {
>>>         compatible = "simple-bus";
>>>         ranges;
>>>         #address-cells = <2>;
>>>         #size-cells = <2>;
>>>         mac0: ethernet@10000000 {
>>>             compatible = "calxeda,hb-xgmac";
>>>             reg = <0 0x10000000 0 0x1000>;
>>>             interrupts = <0 80 4  0 81 4  0 82 4>;
>>>            iommus = <0xfdea 0x01>;
>>>         };
>>>     };
>>> };
>>>  In xl.cfg we need to define a new option to inform Xen about vMasterId to pMasterId mapping and to which IOMMU device this
>>> the master device is connected so that Xen can configure the right IOMMU. This is required if the system has devices that have
>>> the same master ID but behind a different IOMMU.
>>
>> In xl.cfg, we already pass the device-tree node path to passthrough. So Xen should already have all the information about the IOMMU and Master-ID. So it doesn't seem necessary for Device-Tree.
>>
>> For ACPI, I would have expected the information to be found in the IOREQ.
>>
>> So can you add more context why this is necessary for everyone?
> 
> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
> The device tree node will be used to assign the device to the guest and configure the Stage-2 translation. Guest will use the
> vMaster-ID to configure the vIOMMU during boot. Xen needs information to link vMaster-ID to pMaster-ID to configure
> the corresponding pIOMMU. As I mention we need vMaster-ID in case a system could have 2 identical Master-ID but
> each one connected to a different SMMU and assigned to the guest.

I think the proposed solution would work and I would just like to clear some issues.

Please correct me if I'm wrong:

In the xl config file we already need to specify dtdev to point to the device path in host dtb.
In the partial device tree we specify the vMasterId as well as magic phandle.
Isn't it that we already have all the information necessary without the need for iommu_devid_map?
For me it looks like the partial dtb provides vMasterID and dtdev provides pMasterID as well as physical phandle to SMMU.

Having said that, I can also understand that specifying everything in one place using iommu_devid_map can be easier
and reduces the need for device tree parsing.

Apart from that, what is the reason of exposing only one vSMMU to guest instead of one vSMMU per pSMMU?
In the latter solution, the whole issue with handling devices with the same stream ID but belonging to different SMMUs
would be gone. It would also result in a more natural way of the device tree look. Normally a guest would see
e.g. both SMMUs and exposing only one can be misleading.

> 
>>
>>>  iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
>>>      • PMASTER_ID is the physical master ID of the device from the physical DT.
>>>      • VMASTER_ID is the virtual master Id that the user will configure in the partial device tree.
>>>      • IOMMU_BASE_ADDRESS is the base address of the physical IOMMU device to which this device is connected.
>>
>> Below you give an example for Platform device. How would that fit in the context of PCI passthrough?
> 
> In PCI passthrough case, xl will create the "iommu-map" property in vpci host bridge node with phandle to vIOMMU node.
> vSMMUv3 node will be created in xl.
> 
>>
>>>  Example: Let's say the user wants to assign the below physical device in DT to the guest.
>>>  iommu@4f000000 {
>>>                 compatible = "arm,smmu-v3";
>>>                      interrupts = <0x00 0xe4 0xf04>;
>>>                 interrupt-parent = <0x01>;
>>>                 #iommu-cells = <0x01>;
>>>                 interrupt-names = "combined";
>>>                 reg = <0x00 0x4f000000 0x00 0x40000>;
>>>                 phandle = <0xfdeb>;
>>>                 name = "iommu";
>>> };
>>
>> So I guess this node will be written by Xen. How will you the case where there are extra property to added (e.g. dma-coherent)?
> 
> In this example this is physical IOMMU node. vIOMMU node wil be created by xl during guest creation.
>>
>>>  test@10000000 {
>>>      compatible = "viommu-test”;
>>>      iommus = <0xfdeb 0x10>;
>>
>> I am a bit confused. Here you use 0xfdeb for the phandle but below...
> 
> Here 0xfdeb is the physical IOMMU node phandle...
>>
>>>      interrupts = <0x00 0xff 0x04>;
>>>      reg = <0x00 0x10000000 0x00 0x1000>;
>>>      name = "viommu-test";
>>> };
>>>  The partial Device tree node will be like this:
>>>  / {
>>>     /* #*cells are here to keep DTC happy */
>>>     #address-cells = <2>;
>>>     #size-cells = <2>;
>>>       passthrough {
>>>         compatible = "simple-bus";
>>>         ranges;
>>>         #address-cells = <2>;
>>>         #size-cells = <2>;
>>>      test@10000000 {
>>>              compatible = "viommu-test";
>>>              reg = <0 0x10000000 0 0x1000>;
>>>              interrupts = <0 80 4  0 81 4  0 82 4>;
>>>              iommus = <0xfdea 0x01>;
>>
>> ... you use 0xfdea. Does this mean 'xl' will rewrite the phandle?
> 
> but here user has to set the “iommus” property with magic phanle as explained earlier. 0xfdea is magic phandle.
> 
> Regards,
> Rahul

~Michal



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 17:26:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 17:26:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430719.682703 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onkAw-0002Jh-Vb; Wed, 26 Oct 2022 17:26:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430719.682703; Wed, 26 Oct 2022 17:26:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onkAw-0002Ja-RG; Wed, 26 Oct 2022 17:26:46 +0000
Received: by outflank-mailman (input) for mailman id 430719;
 Wed, 26 Oct 2022 17:26:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ANQJ=23=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onkAv-0002JT-74
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 17:26:45 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on2057.outbound.protection.outlook.com [40.107.243.57])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5be497af-5553-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 19:26:44 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DS0PR12MB7584.namprd12.prod.outlook.com (2603:10b6:8:13b::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 17:26:40 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 17:26:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5be497af-5553-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AN/EZLmmdZ/Vy56e2qXhg+D38yoYGHh1EbdsyucIiTAlQpz2ail7uZi3s6G26IDXWiDDKkFadLC32jra9yhTLBKdpMGInnd1mugCrTlldygLlMXxmVf0r1RDleloYq6kfX6KCeVrGbLakgQcqNVMn86jJG2AnwNEIaeh1vvRGCzYOv+TKGqwm30S4Ym6hba0fjrFh1ukN91Nnd4yeNrBmkGAqsOsP8GLuwjifF7uCeVFVk7UEDe3mGqbXOe7LAq9Ini9iyx/5BftlIalSnXD7+UCNVLjwd9QRWnXzl3J9ctJijg9hBN1fBi/LzbHlljz1nQxrKTcSlBZOdYt+gJN1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e/c89O2RN4c7grri9y0r8ZWkE5NdGSrl5/WAIN50Q3w=;
 b=BpZyPwFKqNYwdsNe06rbXelu8eMiFWyp6CyKDmR9lqcvZ8jmiKTt1DkCZKpN2In9XDX+mb5VUmQp7PMIV+daJNOVYMXJ6/QoMgXLT7sn3n9g1LOrkjhXUras0x8pLX/9f39jDrwX3Kmi9c8sXNTCzNypNk9zP0pZ59fxIHLOLinGBC+ZNzZ6/m0GEl4/iK+PJFw6q8i0NoTZZdAiVV8snO0TCljIXUQUgrGKClEf75HuWCFW95VNo5BTPAnvLrak2ZFL9QXEn/8i3S0yaUBgIWrSQD0EbaBvvmRi4QdSVJwZ+xy51mGHNQGRIyz915op/9yZJ2AzoHhmUW7UhjKQUQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e/c89O2RN4c7grri9y0r8ZWkE5NdGSrl5/WAIN50Q3w=;
 b=WJSbhftyuDoo4hM0r+te6QJlQFuvCnA4xd33TAYOi47yrigBFpGk7TlW+CKNurN62F8adYKe4XWMaXuAP/5hOE6LZzV7Wgm/T1ND7EUAezA9mrzRv2KoxDe2XW+GVpm/esdNVHg3ZVKl5EiY0POpDSA1FmznGC7gUVfbpuxrxMk=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <c8505d52-5bf5-e233-dcac-090a546d86b1@amd.com>
Date: Wed, 26 Oct 2022 18:26:34 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v3] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, andre.przywara@arm.com, Henry.Wang@arm.com
References: <20221026133540.52191-1-ayankuma@amd.com>
 <95d0a8ca-9ff0-162a-02ae-8cbdc30af8b9@xen.org>
 <2accac91-d822-c493-4045-8657aed26fb1@amd.com>
 <bb8709ff-9b1a-91f4-3a73-c5f216b6b44e@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <bb8709ff-9b1a-91f4-3a73-c5f216b6b44e@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0355.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:d::31) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS0PR12MB7584:EE_
X-MS-Office365-Filtering-Correlation-Id: 368ac13e-f11d-4d3a-092d-08dab7773e5e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aB0ldJ5l/QaXMGALISiA5CpAd89Blap5VCA53rpfDJAbtziSdgy7KAoy2crEDKLumawUooobDtE95kBEgS+7zOFp3wa9NVHZtJLarFu4tLNcsQdp9bwPdktEO45XIwj7x66Lopf7mmeV5Qso5IhSTPp3QgdgYeGODDUsz+hKR7pDgKJoQWWZkFaY3Bava5kL3W++CVxvXAQWyexp7rOW7WPO7P3wrq5TKpdJyGwmcJ3woUfIiHT6c7nqUkv0z/uzq1UbwjDvSRgzSCT0bJJztZtwJ0LORRSzP1zWN2HvvhFTJlbnGcMecgQW5vjzpRMbVMBvG8X2uPu0A/AL1ghDIt0sFIiiOPuairJOZyB3MGvxf5+YfeVztLDMXqXjFCtihNAdjr1Sz8d/WpnRlYChEfO0Rlm2403kGq/pB6qvwoNyqc8aK0ngL7RuwIGzDCFLnp3lc990B+oRxAEYp4FVtSC3ek6/6Mh3A4ztq2rKdRSfLyfnE7dJpXK2m7oIqx/d2bP/inFx/xOBi8wZ4qug2wHJLZpEKGZWKlGnPS0KN3yjngV+unQ1vgtI26ZWwdv98Ij1FNclM8XN9EyrBZ3GvS0oBlIeUuF6xCh2asOwt747++TN8qwjdT8/nifaiSgVxhZvub/BAw6eNvDUUdxywTmv5vSOPXWPbCXgDnTU7puLEBASWSG/oVupf2blMnjSmsJ5o9nYQqqVoq6XVHFj7DyxhWMtT46zOCw4m4CcrJVa3rGKllxhFs39RfMy2F6prP+E/7svqz+v52CcCGuEY8gcX0e8ZtBo5MzbQEI0prU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199015)(8936002)(41300700001)(26005)(6512007)(5660300002)(66556008)(53546011)(4326008)(36756003)(66946007)(6666004)(8676002)(66476007)(2616005)(316002)(38100700002)(6506007)(186003)(2906002)(83380400001)(31696002)(31686004)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R3AxUHIrbWxwbVExSytRSC93bmwvK0w1UStlZUc5cnJRb3NqOG5mc2RoQm1W?=
 =?utf-8?B?WVIzQ0Q2NlFPZHh0Zk11dXlGdGdTY2RhaDZPdERFSnAwbGloYitpdjIycVRh?=
 =?utf-8?B?SDMwRzNON1oxdlltUmt3NFkyMWJ0TlIyMk91dmFRQnFkbFR0bEpVeHpudVRB?=
 =?utf-8?B?N0htT1ZXM0tYVmZ3S3VhU2JUakR5QmRiWWo0cVpRNjhlNzh1S3l6dlFZMEF3?=
 =?utf-8?B?N2NYYVk2YnEzTlBBcHZXUXhjWHFNRmV3RHhxSHdFM09RUzZQVFhCUjQ2QzJw?=
 =?utf-8?B?eHRvdlQ0NmtGQ0RMRXdpbjRUeW5Rc2MwYVJxTDFiNUw3bjZxd3lEZVMxOFBO?=
 =?utf-8?B?ZVBaOTQ5R2FIZ05jeFZuUHdHdVZZSXMxY0ZoZ2JPUHVxcmpBTG9ZQ1JGdzJq?=
 =?utf-8?B?anRvYStYMkFaNUpvS3MvdzhMc3Nsa2tVRVZIQVdFMUcyQmZQZy9OOEUrSXBL?=
 =?utf-8?B?Z2RERllCVTNjb0cxUXJOQ1ppeHFZZXNPRE9YbzNGNnovekQxME1aaHJvK3Nl?=
 =?utf-8?B?WGlpaldJRUlqNGFPcHNXWmhaZ2c5SzZOSHdDaE9wR2ZZRHp3SGdqVkhIdExJ?=
 =?utf-8?B?SU53RncyTVhzaHhzQWZ2em5xMC9IU2VTOGNXeHlJWmJFN3NTMlV1YWhLY2o0?=
 =?utf-8?B?TzhMTnYvaXI3cmttR3lOQmZQMzRXSi9yWmh6Y0F6QmNyODBCUHg1OHowQ1ho?=
 =?utf-8?B?WlM2dEcxaFMyTGo5eVY3TVhlczJxaWNsdktNQWh3VTRLeWZoVitJQ3k1cENF?=
 =?utf-8?B?VTFIWWhlNlZaRXV5MGRDSFR2VmphSWM5LytWUnFwKzVqQmxVdUJKL0lHU2hz?=
 =?utf-8?B?TkoweHZ5Y3RPNTZMTnhCY1paSitHVSsxeU1ENVZmMzN4NG9VcEd3alhzOVFW?=
 =?utf-8?B?Mjh5aHFXdlJ6dWdhUUJ6V2doc3pnWiswWGtqTmgzUnhXeGMzZmxrN2NGTmlD?=
 =?utf-8?B?ZWNoUnhRY0xsM2NLV1pIVXRoRFJBYlpIM3g2MjRPb1NnVk1naTBSM1ZKWEFU?=
 =?utf-8?B?K3FVQWdoeVZjdzR3SlNyeXRCOG5iM1FyQW9Jb0NDTU0vM2tVTFRVSThGUHY3?=
 =?utf-8?B?WExZVnZxSmJKajkrNjVlMFlRZmFCdk50TDBOY3BBOE1JTjlSeSs0c0Z1YjJ0?=
 =?utf-8?B?cXYwaWd2T2V6MTFMdVFnYkNua3czZEVneG4xdnByWDBPUUlScElveVhTZUV6?=
 =?utf-8?B?U1prU0VLTVBQOXAzeTdPYjR3c25KT2JrdCt6cUpxMmo1V1FVMGpzTlNQSURK?=
 =?utf-8?B?L3BKQXY2djdjYm1iMmlrRWFIUHpJbGVRWEZhdm5meXM3N0RvVEtLVXQ4Ky81?=
 =?utf-8?B?Zm1kdzYxVmVSUHJVcW1RQW5xZERTOGl1alVBMlgxOGNGSVBnb1k3SlVoQkhJ?=
 =?utf-8?B?M0RCaEwzV2FzNDEvRkFkK1ZZVk5EeEwySy9oWmJtTWpQR0xJQ2F3SGNKOEpt?=
 =?utf-8?B?aWVIT2RPMU9xSTN0bmJkWWJNNzlPYzVGSUNxbHdBRVA2K3FoZ2xmSjZmWTZl?=
 =?utf-8?B?enI3MC9NdzVzMlNHWldjWG5BOW92enhXSXZBT3FuOVFiM1hRb3A0dk9XZDFV?=
 =?utf-8?B?aUlpVlBGNVpxWWZ4UURNc3NIK1dmVkRSKzAzemJYQ2JPdTIzaEJ2SXIzUTBV?=
 =?utf-8?B?NzIwaVJrWDQyZ0QyOW9BbXQ3dUlhajA1ZEJwelEzbTluU25yUXJkaXFHVUU3?=
 =?utf-8?B?c1c2c3ZKY3V2ZDAvbXJObCsvN0lEYURFZUlvZ0lLY3VnWmN4UWRDT01SWXVq?=
 =?utf-8?B?RkpLb3hKbTJhRGZ5K0ErK3g1WXdCbWg5dmtTbjJXc1lTR0IvdDliTjNDOWZl?=
 =?utf-8?B?c2JLVE13NTZxNEpBbFpMN2JTMDVrdUlGcVVIdVVydm1jN2l0MTJsZDJjeDd2?=
 =?utf-8?B?RWRmNllsTVhxR1dPZVlOTkFsUU56ZHpiMVVoQS9SSEtOaTQ3NjZoaTcvVHd2?=
 =?utf-8?B?cmc5WmRmMUp3aHZrUEcwZDVQcDNaRTZqTmQ0RnN5VU5pd2JLemgvYThQTmpp?=
 =?utf-8?B?cE01eWJ4UTlXeXlScHM3Y0l4K3R1ZzgxTTU2UWs3YWxSL1FsUTlnYVIrNTFH?=
 =?utf-8?B?eVZhN0VHOUZLWDJJUDhFRFgzaWFEeEIycHduSXlZMDlZN21Ndzc3Y0pBcHBO?=
 =?utf-8?Q?XtGf2S99pwtlIuYtZHvqFkCSh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 368ac13e-f11d-4d3a-092d-08dab7773e5e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 17:26:40.3875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GTVFrVAeaR6CnWVEwMK2Cw5d6RIugtQ/2YIojJvKtfdTKcrhFzlR3dwMFn6B1OGULrm7DCshadwY3J4VDXfZIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7584

Hi Julien,

On 26/10/2022 17:45, Julien Grall wrote:
>
>
> On 26/10/2022 16:06, Ayan Kumar Halder wrote:
>>>
>>> ... you also need to ensure that the writers are atomically setting 
>>> rdist_pendbase. Please correct if I am wrong, but the callers are 
>>> not using write_atomic(). So how does that work?
>>
>> I think read_atomic()/write_atomic() may not be the correct approach 
>> for the following reasons :-
>>
>> 1. __vgic_v3_rdistr_rd_mmio_read is a static function. So 'val' has a 
>> global lifetime. Thus, all the following three lines need to be 
>> protected from concurrent access.
>
> I don't understand this argument. 'static' means the function is not 
> exported. The local variables will still reside on the stack.
>
> So why does the use of 'val' needs to be protected with the lock?

Yes, you are correct. I was misunderstanding this as a static variable.

Also, I understood from Stefano that pre-emption does not occur in Xen. 
So there will be no context switch.

So, the only race is between __vgic_v3_rdistr_rd_mmio_read() and 
__vgic_v3_rdistr_rd_mmio_write() for reading/writing rdist_pendbase.

- Ayan

>
>>
>>          val = read_atomic(&v->arch.vgic.rdist_pendbase);
>>          val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
>>
>>          /* If a context switch happens here, then the 'val' below 
>> may potentially be incorrect. */
>>
>>          *r = vreg_reg64_extract(val, info);
>>
>> 2. The same holds true for 'reg' as well in 
>> __vgic_v3_rdistr_rd_mmio_write()
>>
>>              reg = v->arch.vgic.rdist_pendbase;
>>              blah, blah
>>              v->arch.vgic.rdist_pendbase = reg;
>
> Same here.
>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 18:23:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 18:23:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430727.682725 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onl3j-0000uc-9d; Wed, 26 Oct 2022 18:23:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430727.682725; Wed, 26 Oct 2022 18:23:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onl3j-0000uV-6n; Wed, 26 Oct 2022 18:23:23 +0000
Received: by outflank-mailman (input) for mailman id 430727;
 Wed, 26 Oct 2022 18:23:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XGDX=23=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1onl3i-0000uN-1I
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 18:23:22 +0000
Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com
 [2607:f8b0:4864:20::1032])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 431a90af-555b-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 20:23:18 +0200 (CEST)
Received: by mail-pj1-x1032.google.com with SMTP id b11so8723541pjp.2
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 11:23:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 431a90af-555b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=MJZVoRGtRB/kzdtsP43JIicPpC6feHeGXeOHSjkuE0g=;
        b=Usr5i5Ihw1FWdDZEembcgIFwrUrvnPSsM0dQrmnEeWEH0wyS8m0VIzyQQg4j+0B31N
         rd81VC0bc+JBv/mDtdTeBmvJ1taXO1HWYnw+xpD1mgkDvNRqvKF+RtC15FuOvRX/s1J2
         dvvvlX5vIYHRhW7adIBGNPNkw7Kst6KNms0CDQO/6lnRbvkTK43ewuqQwUEFVwR4RPy+
         Xrq4+Gd5aIiYkXzOB+83HI6eHGKiDGwFgiFSaLv/C/vO8b1rx+H8B01IO+G3brJgUgWJ
         zx4SPRfLktNip1q+87+i/WUaOh5aV198SuQsz6rVM/9/FNq6o4r2fIMiE//jmSugXLBZ
         t7jw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=MJZVoRGtRB/kzdtsP43JIicPpC6feHeGXeOHSjkuE0g=;
        b=aRwoijMKl/9L3geGjnrR/pSnUbS67nbIS8sq4W56JhQZNiLAHD/gYR0fsQJzgdYTd7
         CZvQjFa8rpeS9aqpymz8KnilyI2cdDg2qvOjfG/wMi2TOSIrB9QhOsWGex/PserM6Yxw
         +FYJPLiThdUjNIe5h8DBK1rr21BTe1haMLDd6Uek7sCtpwEmODnBmGF+fhc91tFiwdiq
         9rXcAsRc/AVOOu+rI/e7/T46wBDUhpWKGgzq/Bj6ZVgLc2HJ7UPncsiCz0fzx9IIsbkt
         mQwKHeBcmQxv9FF3GMp+7n1LRdke+6s+9bT10VRxH1imbNfq+cduivlZALTIbLWZeo+d
         BHqQ==
X-Gm-Message-State: ACrzQf0OKKLreyar8CPfySJIIEZpqajI3NMIlnvHwGt4qzVh2piKkvGP
	yuwZEXNZgXBvQz5SrBfNgxBOkyl4B/MlKzOfZ/Q=
X-Google-Smtp-Source: AMsMyM73eaFBJ3KzSNvJpvoAB6IwlYBATdr15a0UMtY4p/Yu2VYs/A6yx5WVZmV+SclCgcrI8MYIAxwzMUEVSFtxzik=
X-Received: by 2002:a17:90b:1e43:b0:213:1efe:9815 with SMTP id
 pi3-20020a17090b1e4300b002131efe9815mr5734336pjb.164.1666808596818; Wed, 26
 Oct 2022 11:23:16 -0700 (PDT)
MIME-Version: 1.0
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com> <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com> <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
In-Reply-To: <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Wed, 26 Oct 2022 21:23:05 +0300
Message-ID: <CAPD2p-=PSahQR0JWe3tLEtp0-iiNH=yE96_GxNyDbhSw-fod0w@mail.gmail.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices
To: Michal Orzel <michal.orzel@amd.com>, Rahul Singh <rahul.singh@arm.com>
Cc: Julien Grall <julien@xen.org>, 
	Xen developer discussion <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	Michal Orzel <Michal.Orzel@arm.com>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
	Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Content-Type: multipart/alternative; boundary="000000000000526ed205ebf41ebc"

--000000000000526ed205ebf41ebc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 26, 2022 at 8:18 PM Michal Orzel <michal.orzel@amd.com> wrote:

> Hi Rahul,
>


Hello all

[sorry for the possible format issues]


>
> On 26/10/2022 16:33, Rahul Singh wrote:
> >
> >
> > Hi Julien,
> >
> >> On 26 Oct 2022, at 2:36 pm, Julien Grall <julien@xen.org> wrote:
> >>
> >>
> >>
> >> On 26/10/2022 14:17, Rahul Singh wrote:
> >>> Hi All,
> >>
> >> Hi Rahul,
> >>
> >>> At Arm, we started to implement the POC to support 2 levels of page
> tables/nested translation in SMMUv3.
> >>> To support nested translation for guest OS Xen needs to expose the
> virtual IOMMU. If we passthrough the
> >>> device to the guest that is behind an IOMMU and virtual IOMMU is
> enabled for the guest there is a need to
> >>> add IOMMU binding for the device in the passthrough node as per [1].
> This email is to get an agreement on
> >>> how to add the IOMMU binding for guest OS.
> >>> Before I will explain how to add the IOMMU binding let me give a brie=
f
> overview of how we will add support for virtual
> >>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3
> Nested translation support. SMMUv3 hardware
> >>> supports two stages of translation. Each stage of translation can be
> independently enabled. An incoming address is logically
> >>> translated from VA to IPA in stage 1, then the IPA is input to stage =
2
> which translates the IPA to the output PA. Stage 1 is
> >>> intended to be used by a software entity( Guest OS) to provide
> isolation or translation to buffers within the entity, for example,
> >>> DMA isolation within an OS. Stage 2 is intended to be available in
> systems supporting the Virtualization Extensions and is
> >>> intended to virtualize device DMA to guest VM address spaces. When
> both stage 1 and stage 2 are enabled, the translation
> >>> configuration is called nesting.
> >>> Stage 1 translation support is required to provide isolation between
> different devices within the guest OS. XEN already supports
> >>> Stage 2 translation but there is no support for Stage 1 translation
> for guests. We will add support for guests to configure
> >>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU
> hardware and exposes the virtual SMMU to the guest.
> >>> Guest can use the native SMMU driver to configure the stage 1
> translation. When the guest configures the SMMU for Stage 1,
> >>> XEN will trap the access and configure the hardware accordingly.
> >>> Now back to the question of how we can add the IOMMU binding between
> the virtual IOMMU and the master devices so that
> >>> guests can configure the IOMMU correctly. The solution that I am
> suggesting is as below:
> >>> For dom0, while handling the DT node(handle_node()) Xen will replace
> the phandle in the "iommus" property with the virtual
> >>> IOMMU node phandle.
> >> Below, you said that each IOMMUs may have a different ID space. So
> shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the
> user to specify the mapping?
> >
> > Yes you are right we need to create one vIOMMU per pIOMMU for dom0. Thi=
s
> also helps in the ACPI case
> > where we don=E2=80=99t need to modify the tables to delete the pIOMMU e=
ntries
> and create one vIOMMU.
> > In this case, no need to replace the phandle as Xen create the vIOMMU
> with the same pIOMMU
> > phandle and same base address.
> >
> > For domU guests one vIOMMU per guest will be created.
> >
> >>
> >>> For domU guests, when passthrough the device to the guest as per [2],
> add the below property in the partial device tree
> >>> node that is required to describe the generic device tree binding for
> IOMMUs and their master(s)
> >>> "iommus =3D < &magic_phandle 0xvMasterID>
> >>>      =E2=80=A2 magic_phandle will be the phandle ( vIOMMU phandle in =
xl)  that
> will be documented so that the user can set that in partial DT node
> (0xfdea).
> >>
> >> Does this mean only one IOMMU will be supported in the guest?
> >
> > Yes.
> >
> >>
> >>>      =E2=80=A2 vMasterID will be the virtual master ID that the user =
will
> provide.
> >>> The partial device tree will look like this:
> >>> /dts-v1/;
> >>>  / {
> >>>     /* #*cells are here to keep DTC happy */
> >>>     #address-cells =3D <2>;
> >>>     #size-cells =3D <2>;
> >>>       aliases {
> >>>         net =3D &mac0;
> >>>     };
> >>>       passthrough {
> >>>         compatible =3D "simple-bus";
> >>>         ranges;
> >>>         #address-cells =3D <2>;
> >>>         #size-cells =3D <2>;
> >>>         mac0: ethernet@10000000 {
> >>>             compatible =3D "calxeda,hb-xgmac";
> >>>             reg =3D <0 0x10000000 0 0x1000>;
> >>>             interrupts =3D <0 80 4  0 81 4  0 82 4>;
> >>>            iommus =3D <0xfdea 0x01>;
> >>>         };
> >>>     };
> >>> };
> >>>  In xl.cfg we need to define a new option to inform Xen about
> vMasterId to pMasterId mapping and to which IOMMU device this
> >>> the master device is connected so that Xen can configure the right
> IOMMU. This is required if the system has devices that have
> >>> the same master ID but behind a different IOMMU.
> >>
> >> In xl.cfg, we already pass the device-tree node path to passthrough. S=
o
> Xen should already have all the information about the IOMMU and Master-ID=
.
> So it doesn't seem necessary for Device-Tree.
> >>
> >> For ACPI, I would have expected the information to be found in the
> IOREQ.
> >>
> >> So can you add more context why this is necessary for everyone?
> >
> > We have information for IOMMU and Master-ID but we don=E2=80=99t have
> information for linking vMaster-ID to pMaster-ID.
> > The device tree node will be used to assign the device to the guest and
> configure the Stage-2 translation. Guest will use the
> > vMaster-ID to configure the vIOMMU during boot. Xen needs information t=
o
> link vMaster-ID to pMaster-ID to configure
> > the corresponding pIOMMU. As I mention we need vMaster-ID in case a
> system could have 2 identical Master-ID but
> > each one connected to a different SMMU and assigned to the guest.
>
> I think the proposed solution would work and I would just like to clear
> some issues.
>
> Please correct me if I'm wrong:
>
> In the xl config file we already need to specify dtdev to point to the
> device path in host dtb.
> In the partial device tree we specify the vMasterId as well as magic
> phandle.
> Isn't it that we already have all the information necessary without the
> need for iommu_devid_map?
> For me it looks like the partial dtb provides vMasterID and dtdev provide=
s
> pMasterID as well as physical phandle to SMMU.
>
> Having said that, I can also understand that specifying everything in one
> place using iommu_devid_map can be easier
> and reduces the need for device tree parsing.
>
> Apart from that, what is the reason of exposing only one vSMMU to guest
> instead of one vSMMU per pSMMU?
> In the latter solution, the whole issue with handling devices with the
> same stream ID but belonging to different SMMUs
> would be gone. It would also result in a more natural way of the device
> tree look. Normally a guest would see
> e.g. both SMMUs and exposing only one can be misleading.
>

I also have the same question. From earlier answers as I understand it is
going to be identity vSMMU <-> pSMMU mappings for Dom0, so why diverge for
DomU?

Also I am thinking how this solution would work for IPMMU-VMSA Gen3(Gen4),
which also supports two stages of translation, so the nested translation
could be possible in general, although there might be some pitfalls
(yes, I understand that code to emulate access to control registers would
be different in comparison with SMMUv3, but some other code could be
common).




>
> >>
> >>>  iommu_devid_map =3D [ =E2=80=9CPMASTER_ID[@VMASTER_ID],IOMMU_BASE_AD=
DRESS=E2=80=9D ,
> =E2=80=9CPMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS=E2=80=9D]
> >>>      =E2=80=A2 PMASTER_ID is the physical master ID of the device fro=
m the
> physical DT.
> >>>      =E2=80=A2 VMASTER_ID is the virtual master Id that the user will
> configure in the partial device tree.
> >>>      =E2=80=A2 IOMMU_BASE_ADDRESS is the base address of the physical=
 IOMMU
> device to which this device is connected.



If iommu_devid_map is a way to go, I have a question, would this
configuration cover the following cases?
1. Device has several stream IDs
2. Several devices share the stream ID (or several stream IDs)




> >>
> >> Below you give an example for Platform device. How would that fit in
> the context of PCI passthrough?
> >
> > In PCI passthrough case, xl will create the "iommu-map" property in vpc=
i
> host bridge node with phandle to vIOMMU node.
> > vSMMUv3 node will be created in xl.
> >
> >>
> >>>  Example: Let's say the user wants to assign the below physical devic=
e
> in DT to the guest.
> >>>  iommu@4f000000 {
> >>>                 compatible =3D "arm,smmu-v3";
> >>>                      interrupts =3D <0x00 0xe4 0xf04>;
> >>>                 interrupt-parent =3D <0x01>;
> >>>                 #iommu-cells =3D <0x01>;
> >>>                 interrupt-names =3D "combined";
> >>>                 reg =3D <0x00 0x4f000000 0x00 0x40000>;
> >>>                 phandle =3D <0xfdeb>;
> >>>                 name =3D "iommu";
> >>> };
> >>
> >> So I guess this node will be written by Xen. How will you the case
> where there are extra property to added (e.g. dma-coherent)?
> >
> > In this example this is physical IOMMU node. vIOMMU node wil be created
> by xl during guest creation.
> >>
> >>>  test@10000000 {
> >>>      compatible =3D "viommu-test=E2=80=9D;
> >>>      iommus =3D <0xfdeb 0x10>;
> >>
> >> I am a bit confused. Here you use 0xfdeb for the phandle but below...
> >
> > Here 0xfdeb is the physical IOMMU node phandle...
> >>
> >>>      interrupts =3D <0x00 0xff 0x04>;
> >>>      reg =3D <0x00 0x10000000 0x00 0x1000>;
> >>>      name =3D "viommu-test";
> >>> };
> >>>  The partial Device tree node will be like this:
> >>>  / {
> >>>     /* #*cells are here to keep DTC happy */
> >>>     #address-cells =3D <2>;
> >>>     #size-cells =3D <2>;
> >>>       passthrough {
> >>>         compatible =3D "simple-bus";
> >>>         ranges;
> >>>         #address-cells =3D <2>;
> >>>         #size-cells =3D <2>;
> >>>      test@10000000 {
> >>>              compatible =3D "viommu-test";
> >>>              reg =3D <0 0x10000000 0 0x1000>;
> >>>              interrupts =3D <0 80 4  0 81 4  0 82 4>;
> >>>              iommus =3D <0xfdea 0x01>;
> >>
> >> ... you use 0xfdea. Does this mean 'xl' will rewrite the phandle?
> >
> > but here user has to set the =E2=80=9Ciommus=E2=80=9D property with mag=
ic phanle as
> explained earlier. 0xfdea is magic phandle.
> >
> > Regards,
> > Rahul
>
> ~Michal
>
>
>

--=20
Regards,

Oleksandr Tyshchenko

--000000000000526ed205ebf41ebc
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 26, 2022 at 8:18 PM Micha=
l Orzel &lt;<a href=3D"mailto:michal.orzel@amd.com">michal.orzel@amd.com</a=
>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi =
Rahul,<br></blockquote><div>=C2=A0</div><div><br></div><div>Hello all</div>=
<div><br></div><div>[sorry for the possible format issues]</div><div>=C2=A0=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On 26/10/2022 16:33, Rahul Singh wrote:<br>
&gt; <br>
&gt; <br>
&gt; Hi Julien,<br>
&gt; <br>
&gt;&gt; On 26 Oct 2022, at 2:36 pm, Julien Grall &lt;<a href=3D"mailto:jul=
ien@xen.org" target=3D"_blank">julien@xen.org</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; On 26/10/2022 14:17, Rahul Singh wrote:<br>
&gt;&gt;&gt; Hi All,<br>
&gt;&gt;<br>
&gt;&gt; Hi Rahul,<br>
&gt;&gt;<br>
&gt;&gt;&gt; At Arm, we started to implement the POC to support 2 levels of=
 page tables/nested translation in SMMUv3.<br>
&gt;&gt;&gt; To support nested translation for guest OS Xen needs to expose=
 the virtual IOMMU. If we passthrough the<br>
&gt;&gt;&gt; device to the guest that is behind an IOMMU and virtual IOMMU =
is enabled for the guest there is a need to<br>
&gt;&gt;&gt; add IOMMU binding for the device in the passthrough node as pe=
r [1]. This email is to get an agreement on<br>
&gt;&gt;&gt; how to add the IOMMU binding for guest OS.<br>
&gt;&gt;&gt; Before I will explain how to add the IOMMU binding let me give=
 a brief overview of how we will add support for virtual<br>
&gt;&gt;&gt; IOMMU on Arm. In order to implement virtual IOMMU Xen need SMM=
Uv3 Nested translation support. SMMUv3 hardware<br>
&gt;&gt;&gt; supports two stages of translation. Each stage of translation =
can be independently enabled. An incoming address is logically<br>
&gt;&gt;&gt; translated from VA to IPA in stage 1, then the IPA is input to=
 stage 2 which translates the IPA to the output PA. Stage 1 is<br>
&gt;&gt;&gt; intended to be used by a software entity( Guest OS) to provide=
 isolation or translation to buffers within the entity, for example,<br>
&gt;&gt;&gt; DMA isolation within an OS. Stage 2 is intended to be availabl=
e in systems supporting the Virtualization Extensions and is<br>
&gt;&gt;&gt; intended to virtualize device DMA to guest VM address spaces. =
When both stage 1 and stage 2 are enabled, the translation<br>
&gt;&gt;&gt; configuration is called nesting.<br>
&gt;&gt;&gt; Stage 1 translation support is required to provide isolation b=
etween different devices within the guest OS. XEN already supports<br>
&gt;&gt;&gt; Stage 2 translation but there is no support for Stage 1 transl=
ation for guests. We will add support for guests to configure<br>
&gt;&gt;&gt; the Stage 1 transition via virtual IOMMU. XEN will emulate the=
 SMMU hardware and exposes the virtual SMMU to the guest.<br>
&gt;&gt;&gt; Guest can use the native SMMU driver to configure the stage 1 =
translation. When the guest configures the SMMU for Stage 1,<br>
&gt;&gt;&gt; XEN will trap the access and configure the hardware accordingl=
y.<br>
&gt;&gt;&gt; Now back to the question of how we can add the IOMMU binding b=
etween the virtual IOMMU and the master devices so that<br>
&gt;&gt;&gt; guests can configure the IOMMU correctly. The solution that I =
am suggesting is as below:<br>
&gt;&gt;&gt; For dom0, while handling the DT node(handle_node()) Xen will r=
eplace the phandle in the &quot;iommus&quot; property with the virtual<br>
&gt;&gt;&gt; IOMMU node phandle.<br>
&gt;&gt; Below, you said that each IOMMUs may have a different ID space. So=
 shouldn&#39;t we expose one vIOMMU per pIOMMU? If not, how do you expect t=
he user to specify the mapping?<br>
&gt; <br>
&gt; Yes you are right we need to create one vIOMMU per pIOMMU for dom0. Th=
is also helps in the ACPI case<br>
&gt; where we don=E2=80=99t need to modify the tables to delete the pIOMMU =
entries and create one vIOMMU.<br>
&gt; In this case, no need to replace the phandle as Xen create the vIOMMU =
with the same pIOMMU<br>
&gt; phandle and same base address.<br>
&gt; <br>
&gt; For domU guests one vIOMMU per guest will be created.<br>
&gt; <br>
&gt;&gt;<br>
&gt;&gt;&gt; For domU guests, when passthrough the device to the guest as p=
er [2],=C2=A0 add the below property in the partial device tree<br>
&gt;&gt;&gt; node that is required to describe the generic device tree bind=
ing for IOMMUs and their master(s)<br>
&gt;&gt;&gt; &quot;iommus =3D &lt; &amp;magic_phandle 0xvMasterID&gt;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 magic_phandle will be the phandl=
e ( vIOMMU phandle in xl)=C2=A0 that will be documented so that the user ca=
n set that in partial DT node (0xfdea).<br>
&gt;&gt;<br>
&gt;&gt; Does this mean only one IOMMU will be supported in the guest?<br>
&gt; <br>
&gt; Yes.<br>
&gt; <br>
&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 vMasterID will be the virtual ma=
ster ID that the user will provide.<br>
&gt;&gt;&gt; The partial device tree will look like this:<br>
&gt;&gt;&gt; /dts-v1/;<br>
&gt;&gt;&gt;=C2=A0 / {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0/* #*cells are here to keep DTC happy */<br=
>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0#address-cells =3D &lt;2&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0#size-cells =3D &lt;2&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0aliases {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0net =3D &amp;mac0;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0};<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0passthrough {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &quot;simple-b=
us&quot;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ranges;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-cells =3D &lt;2&gt;;=
<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cells =3D &lt;2&gt;;<br=
>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mac0: ethernet@10000000 {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D =
&quot;calxeda,hb-xgmac&quot;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D &lt;0 0=
x10000000 0 0x1000&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0interrupts =3D =
&lt;0 80 4=C2=A0 0 81 4=C2=A0 0 82 4&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 iommus =3D &lt;0xfdea=
 0x01&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0};<br>
&gt;&gt;&gt; };<br>
&gt;&gt;&gt;=C2=A0 In xl.cfg we need to define a new option to inform Xen a=
bout vMasterId to pMasterId mapping and to which IOMMU device this<br>
&gt;&gt;&gt; the master device is connected so that Xen can configure the r=
ight IOMMU. This is required if the system has devices that have<br>
&gt;&gt;&gt; the same master ID but behind a different IOMMU.<br>
&gt;&gt;<br>
&gt;&gt; In xl.cfg, we already pass the device-tree node path to passthroug=
h. So Xen should already have all the information about the IOMMU and Maste=
r-ID. So it doesn&#39;t seem necessary for Device-Tree.<br>
&gt;&gt;<br>
&gt;&gt; For ACPI, I would have expected the information to be found in the=
 IOREQ.<br>
&gt;&gt;<br>
&gt;&gt; So can you add more context why this is necessary for everyone?<br=
>
&gt; <br>
&gt; We have information for IOMMU and Master-ID but we don=E2=80=99t have =
information for linking vMaster-ID to pMaster-ID.<br>
&gt; The device tree node will be used to assign the device to the guest an=
d configure the Stage-2 translation. Guest will use the<br>
&gt; vMaster-ID to configure the vIOMMU during boot. Xen needs information =
to link vMaster-ID to pMaster-ID to configure<br>
&gt; the corresponding pIOMMU. As I mention we need vMaster-ID in case a sy=
stem could have 2 identical Master-ID but<br>
&gt; each one connected to a different SMMU and assigned to the guest.<br>
<br>
I think the proposed solution would work and I would just like to clear som=
e issues.<br>
<br>
Please correct me if I&#39;m wrong:<br>
<br>
In the xl config file we already need to specify dtdev to point to the devi=
ce path in host dtb.<br>
In the partial device tree we specify the vMasterId as well as magic phandl=
e.<br>
Isn&#39;t it that we already have all the information necessary without the=
 need for iommu_devid_map?<br>
For me it looks like the partial dtb provides vMasterID and dtdev provides =
pMasterID as well as physical phandle to SMMU.<br>
<br>
Having said that, I can also understand that specifying everything in one p=
lace using iommu_devid_map can be easier<br>
and reduces the need for device tree parsing.<br>
<br>
Apart from that, what is the reason of exposing only one vSMMU to guest ins=
tead of one vSMMU per pSMMU?<br>
In the latter solution, the whole issue with handling devices with the same=
 stream ID but belonging to different SMMUs<br>
would be gone. It would also result in a more natural way of the device tre=
e look. Normally a guest would see<br>
e.g. both SMMUs and exposing only one can be misleading.<br></blockquote><d=
iv><br></div>I also have the same question. From earlier answers as I under=
stand it is going to be identity vSMMU &lt;-&gt; pSMMU mappings for Dom0, s=
o why diverge for DomU?<br><br>Also I am thinking how this solution would w=
ork for IPMMU-VMSA Gen3(Gen4), which also supports two stages of translatio=
n, so the nested translation could be possible in general, although there m=
ight be some pitfalls<br><div>(yes, I understand that code to emulate acces=
s to control registers would be different in comparison with SMMUv3, but so=
me other code could be common).=C2=A0 =C2=A0 =C2=A0=C2=A0<br></div><div><br=
></div><div><br></div><div>=C2=A0</div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><br>
&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 iommu_devid_map =3D [ =E2=80=9CPMASTER_ID[@VMASTER_ID],I=
OMMU_BASE_ADDRESS=E2=80=9D , =E2=80=9CPMASTER_ID[@VMASTER_ID],IOMMU_BASE_AD=
DRESS=E2=80=9D]<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 PMASTER_ID is the physical maste=
r ID of the device from the physical DT.<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 VMASTER_ID is the virtual master=
 Id that the user will configure in the partial device tree.<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 IOMMU_BASE_ADDRESS is the base a=
ddress of the physical IOMMU device to which this device is connected.</blo=
ckquote><div>=C2=A0</div><div><br></div><div>If iommu_devid_map is a way to=
 go, I have a question, would this configuration cover the following cases?=
</div><div>1. Device has several stream IDs</div><div>2. Several devices sh=
are the stream ID (or several stream IDs)<br></div><div><br></div><div><br>=
</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt;&gt;<br>
&gt;&gt; Below you give an example for Platform device. How would that fit =
in the context of PCI passthrough?<br>
&gt; <br>
&gt; In PCI passthrough case, xl will create the &quot;iommu-map&quot; prop=
erty in vpci host bridge node with phandle to vIOMMU node.<br>
&gt; vSMMUv3 node will be created in xl.<br>
&gt; <br>
&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 Example: Let&#39;s say the user wants to assign the belo=
w physical device in DT to the guest.<br>
&gt;&gt;&gt;=C2=A0 iommu@4f000000 {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0c=
ompatible =3D &quot;arm,smmu-v3&quot;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 interrupts =3D &lt;0x00 0xe4 0xf04&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i=
nterrupt-parent =3D &lt;0x01&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#=
iommu-cells =3D &lt;0x01&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i=
nterrupt-names =3D &quot;combined&quot;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r=
eg =3D &lt;0x00 0x4f000000 0x00 0x40000&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0p=
handle =3D &lt;0xfdeb&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0n=
ame =3D &quot;iommu&quot;;<br>
&gt;&gt;&gt; };<br>
&gt;&gt;<br>
&gt;&gt; So I guess this node will be written by Xen. How will you the case=
 where there are extra property to added (e.g. dma-coherent)?<br>
&gt; <br>
&gt; In this example this is physical IOMMU node. vIOMMU node wil be create=
d by xl during guest creation.<br>
&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 test@10000000 {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 compatible =3D &quot;viommu-test=E2=80=9D;=
<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 iommus =3D &lt;0xfdeb 0x10&gt;;<br>
&gt;&gt;<br>
&gt;&gt; I am a bit confused. Here you use 0xfdeb for the phandle but below=
...<br>
&gt; <br>
&gt; Here 0xfdeb is the physical IOMMU node phandle...<br>
&gt;&gt;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 interrupts =3D &lt;0x00 0xff 0x04&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 reg =3D &lt;0x00 0x10000000 0x00 0x1000&gt=
;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 name =3D &quot;viommu-test&quot;;<br>
&gt;&gt;&gt; };<br>
&gt;&gt;&gt;=C2=A0 The partial Device tree node will be like this:<br>
&gt;&gt;&gt;=C2=A0 / {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0/* #*cells are here to keep DTC happy */<br=
>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0#address-cells =3D &lt;2&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0#size-cells =3D &lt;2&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0passthrough {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &quot;simple-b=
us&quot;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ranges;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-cells =3D &lt;2&gt;;=
<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cells =3D &lt;2&gt;;<br=
>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 test@10000000 {<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compatible =3D=
 &quot;viommu-test&quot;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 reg =3D &lt;0 =
0x10000000 0 0x1000&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 interrupts =3D=
 &lt;0 80 4=C2=A0 0 81 4=C2=A0 0 82 4&gt;;<br>
&gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 iommus =3D &lt=
;0xfdea 0x01&gt;;<br>
&gt;&gt;<br>
&gt;&gt; ... you use 0xfdea. Does this mean &#39;xl&#39; will rewrite the p=
handle?<br>
&gt; <br>
&gt; but here user has to set the =E2=80=9Ciommus=E2=80=9D property with ma=
gic phanle as explained earlier. 0xfdea is magic phandle.<br>
&gt; <br>
&gt; Regards,<br>
&gt; Rahul<br>
<br>
~Michal<br>
<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><span style=3D"background-color:rgb(255,255,255)"><font size=
=3D"2"><span style=3D"color:rgb(51,51,51);font-family:Arial,sans-serif">Reg=
ards,</span></font></span></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"=
><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2">Ol=
eksandr Tyshchenko</font></span></div></div></div></div></div></div></div><=
/div>

--000000000000526ed205ebf41ebc--


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 18:30:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 18:30:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430732.682737 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlAX-0002ag-4w; Wed, 26 Oct 2022 18:30:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430732.682737; Wed, 26 Oct 2022 18:30:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlAX-0002aZ-2B; Wed, 26 Oct 2022 18:30:25 +0000
Received: by outflank-mailman (input) for mailman id 430732;
 Wed, 26 Oct 2022 18:30:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ANQJ=23=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onlAV-0002aT-Ay
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 18:30:23 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2069.outbound.protection.outlook.com [40.107.94.69])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f002040-555c-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 20:30:21 +0200 (CEST)
Received: from MW4PR04CA0122.namprd04.prod.outlook.com (2603:10b6:303:84::7)
 by SJ0PR12MB6926.namprd12.prod.outlook.com (2603:10b6:a03:485::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Wed, 26 Oct
 2022 18:30:17 +0000
Received: from CO1NAM11FT096.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:84:cafe::3f) by MW4PR04CA0122.outlook.office365.com
 (2603:10b6:303:84::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Wed, 26 Oct 2022 18:30:17 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT096.mail.protection.outlook.com (10.13.175.84) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Wed, 26 Oct 2022 18:30:16 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 13:30:15 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct
 2022 11:30:14 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Wed, 26 Oct 2022 13:30:13 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f002040-555c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jdhKNPu9B8ZzZTT6g9oc1j14GHbQg97bT0ZTJglye9v4WZ0/US9Eh4WqmR6BQhDIln8tTCZi45nQuZCk6djJFmVmDac0O8yhLGVrCWIdKqwaH4WH7e04/P/QkCparAq7rCtsCQlk1EH3GzzyjJRssCrmJgD2+L/IMWnW/hNp70xDwBymtIcYiGmFp0/ooR6YyyrNppJLOft045mfdVKzdoHXFt5TgDkyJWvBOP60U/HPpF06lQiWsStdUDGcu5V5d9Ca/NmCsRScVrB4szE9+pUaah5pPNew6/QOoPTV/ceKYr/Rknq7p8eW+mEd8jbSca4XU/Cs3ea/3AlrcW3N9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=K4qxm2rjvz/kxPVyvwj6Tman63HO/M4jCRdkIBDeKOU=;
 b=GygaTpG58WkBkINoQbrPkpjXlixt6i+6emoucXXamL+UtZ+eAijc5D2LEDqKvLxBvaPI+6fX8hwV5+9RhrbtScfhbBmzEJWA2hxNmZpl8cMzo4yvyDdtx4ONopNQn1H5Wsr4+lOu8GNlmnXaaJ4B3LHhwFXlvc0LLKDGOgpR6d6Vx8i4GloItPX+UN7VwmoiBBMuf0vncO+zUeSym6Ss+oil+JNzdNIUU1tZ6bh4Xr5+wuJQafXPbtyOZQ5X+i+wmC7H032ACTEyrmgiqkojLvN4D8fUIPGF0aRNdJ/HxdBYk+VmOPIRqPnyRNHLNEFDVUnNttC+PUEmC0fR+Sobbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=K4qxm2rjvz/kxPVyvwj6Tman63HO/M4jCRdkIBDeKOU=;
 b=gV8PRoCP09nj0gKK/9y/dqHG3GE41eqHuQR1v0DtD1AXEg3E4wKrv4U/5G3+wUFfF0gmoGCpdW0Gj65rwdyuRllbUI92ZMfvyw4FS1B0UUR7gkNuBPrLdXO7AYlApzJEgwQtSSAEB42uK1M0TZUmQus6P85YI1+L52rq0fL/cT0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<andre.przywara@arm.com>, <Henry.Wang@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER
Date: Wed, 26 Oct 2022 19:30:04 +0100
Message-ID: <20221026183004.7293-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT096:EE_|SJ0PR12MB6926:EE_
X-MS-Office365-Filtering-Correlation-Id: bb5e8d5d-9603-4c24-ae65-08dab780212e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	acJmEMcM/gKpXLYe3CWDH3RurO8YeoN+a6cmwrNaqVNJBL1yGeLJ/gMDUguiJn/HfqYhEiviXK/torzRZys2DLD+ia8AmCgRwR1VaFIpn1fDnNWPpeeinQVABkldcrcelYO3k3TASX+oXm/P6BtaYiVecZqfaAF9kuT189/S/HRk2O9OHfs/sbo7xO0v+7rEh9DNBt78l/C6AT7rQ242ufHMW1sUc0NeGS+/AhmOK6/70ilBu23n4CRgSKJUo8DOXo30wy92eQJlBkdUBn7XsrwKix0OKkY430ddy7Zxe7L6Gzpw25PtRChRR4nhSS4cBRR/VDczaP2YACibz7W6hsF2OJewS7PP1wkxwncNc+D12w8erJA1l1+0B31q61ZUZH2O8DKoStOqFKxSRcFzkxaZKcRJSaU4U8rVyFA99GU0HnJN/db3nFgBfNPIOATUn6AEqLsgy80nTq4xhGKFRs7jfT+mRWcVaIUJJfQ+ZOwfQOUHlACFD12DGORXKgh6I/NGhk/qZoa3rgMz7OBjgezM/cwrKQcrEjEHfrUZntpbj20ha76lNiclI9fctllh4sCYOh2EqR3qr2SMX/kBC0OVB9eBDYPS55E9/XNJ2jJOGUekXkkaO6eNTEJC89FemfTkCvAY+BY3LxgABwM8+tANyhaRa8zUNFQk0hVVGdXn9BdJZkclspP7w+o+uQ9qwblXRSa1a5dVnp8XAObuH4cTkWV304uyq2nazTBWw6xEzjkIzjyHZZZZWvqdGE7R6DyLKsAM4AIJ/t1tb3uEb94emcuds/+5G3DjopWBHATfL3ohGVKfuiWKRg3V0XQQ
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(36840700001)(46966006)(40470700004)(36756003)(36860700001)(82740400003)(2906002)(40460700003)(336012)(81166007)(2616005)(186003)(1076003)(426003)(8676002)(356005)(5660300002)(47076005)(83380400001)(70586007)(70206006)(26005)(4326008)(54906003)(6666004)(40480700001)(41300700001)(6916009)(82310400005)(8936002)(316002)(478600001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 18:30:16.5032
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bb5e8d5d-9603-4c24-ae65-08dab780212e
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT096.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6926

If a guest is running in 32 bit mode and it tries to access
"GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
will return the value stored "v->arch.vgic.rdist_pendbase + 4".
This will be stored in a 64bit cpu register.
So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
in the lower 32 bits of the 64bit cpu register.

This 64bit cpu register is then modified bitwise with a mask (ie
GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
64 bit cpu register) is not cleared as expected by the specification.

The correct thing to do here is to store the value of
"v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
vreg_reg64_extract() which will extract 32 bits from the given offset.

Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
v->arch.vgic.rdist_pendbase. The reason being v->arch.vgic.rdist_pendbase is
now being read/written in an atomic manner (using read_atomic()/write_atomic()).

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
---

Changes from:-

v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
appropriate commit message.

v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
v->arch.vgic.rdist_pendbase in an atomic context.
2. Rectified the commit message to state that the cpu register is 64 bit.
(because currently, GICv3 is supported on Arm64 only). Reworded to make it
clear.

v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
in __vgic_v3_rdistr_rd_mmio_write().

 xen/arch/arm/vgic-v3.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..1adbdc0e54 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
 
     case VREG64(GICR_PENDBASER):
     {
-        unsigned long flags;
+        uint64_t val;
 
         if ( !v->domain->arch.vgic.has_its )
             goto read_as_zero_64;
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
 
-        spin_lock_irqsave(&v->arch.vgic.lock, flags);
-        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
-        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
-        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
+        val = read_atomic(&v->arch.vgic.rdist_pendbase);
+        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
+        *r = vreg_reg64_extract(val, info);
         return 1;
     }
 
@@ -566,25 +565,19 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
 
     case VREG64(GICR_PENDBASER):
     {
-        unsigned long flags;
-
         if ( !v->domain->arch.vgic.has_its )
             goto write_ignore_64;
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
 
-        spin_lock_irqsave(&v->arch.vgic.lock, flags);
-
         /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
         if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
         {
-            reg = v->arch.vgic.rdist_pendbase;
+            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
             vreg_reg64_update(&reg, r, info);
             reg = sanitize_pendbaser(reg);
-            v->arch.vgic.rdist_pendbase = reg;
+            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
         }
 
-        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
-
         return 1;
     }
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:01:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:01:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430736.682748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onleq-0006X2-KD; Wed, 26 Oct 2022 19:01:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430736.682748; Wed, 26 Oct 2022 19:01:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onleq-0006Wv-H3; Wed, 26 Oct 2022 19:01:44 +0000
Received: by outflank-mailman (input) for mailman id 430736;
 Wed, 26 Oct 2022 19:01:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Su4L=23=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onleo-0006Wp-Qz
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 19:01:42 +0000
Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com
 [2a00:1450:4864:20::332])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a0568b5c-5560-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 21:01:41 +0200 (CEST)
Received: by mail-wm1-x332.google.com with SMTP id
 r6-20020a1c4406000000b003cf4d389c41so1321245wma.3
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 12:01:41 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 p5-20020adfaa05000000b002366f9bd717sm7165399wrd.45.2022.10.26.12.01.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 26 Oct 2022 12:01:40 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 1B0631FFB7;
 Wed, 26 Oct 2022 20:01:40 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0568b5c-5560-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=Zpzp4aOdkkISx5ILcz2RiZRzgoDoLjsOb8Q83qDZTuo=;
        b=g43jYRFfdAkmpnCeBkFk26McMgzkKS7nAuOKg/fO6paxLU22nK0yZx/x6sIsTKP2QG
         ceZMcomWlZ4Qqdr9tiRbWw08c6rxc3Uh23la9I7wr2Cn4es2aNmVO+nSZfimEGiHMSQ1
         nPgRblPQSj3/6Z3O5RuGEa+vbjbKHu1Kd4W00n9dX9NZ4V+lehuF+YhnPI9xJ7F0iF+L
         ayRMtgchppJNjvmi537QMxKjBNlzUdpvWU+NpY9hqVIG6lQyjJLtw3I7aUhTpux+3ywF
         6pNDyWCE8JgsFfOOVA2x6R6TRIqT+Pnb4ovKdxAN9TAaI8XyINmrWtrAx4VU9jWcKhf6
         trXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=Zpzp4aOdkkISx5ILcz2RiZRzgoDoLjsOb8Q83qDZTuo=;
        b=CKTbJ6U2JcwTXNsog6nEtIUjmi5SoomwEh/19zTVRZKtf71sV8grk+CXrHD5SWE6d8
         A2sdUgJFPQbmKLtHxer1LHBonl2g5fn+pY2rOAUbKDpzzm++mIdoAi0oz8oYDtTfH9Ze
         xXMnn9JOzi+XKGwEbgrPJ/m4b5tDfB7/eGnPK+TQ9It2AQplMOz7FqcDJhVGrhDIIE2y
         MX3HcnR2Qp9R3ZBrNXHy3w5w1l0OpsjUOMvp6KcJl31gYFr37TAf6Wzg9f+kz+rXYTHQ
         NemCvL12TIC48bt8lv48LB/zcgEYFaK8KsgtKXhohrq3IkzLSUXqvXfqUaIk1Egw0j+Y
         JMsw==
X-Gm-Message-State: ACrzQf0b03zui5T5zhU/MUPjZsZzMCGTNGqSjS0i82OHvpXqev7lihMA
	iw+GHp7XzuXOI7nQrDOm6niNrw==
X-Google-Smtp-Source: AMsMyM6aXssRV9cCopFQKhvSSRLqDTri2SN4+sODUiVIOnw54XkFIoRxASG0kxB53TgxohdplKz2Bw==
X-Received: by 2002:a05:600c:4ec6:b0:3c6:c469:d295 with SMTP id g6-20020a05600c4ec600b003c6c469d295mr3555807wmq.117.1666810900982;
        Wed, 26 Oct 2022 12:01:40 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-2-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Stefano Stabellini
 <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul
  Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub
Date: Wed, 26 Oct 2022 20:01:35 +0100
In-reply-to: <20221015050750.4185-2-vikram.garhwal@amd.com>
Message-ID: <871qqu4dez.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

> Build fails when have_xen_pci_passthrough is disabled. This is because of
> incorrect build configuration for xen_pt_stub.c.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Reviewed-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:03:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:03:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430740.682759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlgd-00076I-1K; Wed, 26 Oct 2022 19:03:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430740.682759; Wed, 26 Oct 2022 19:03:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlgc-00076B-TL; Wed, 26 Oct 2022 19:03:34 +0000
Received: by outflank-mailman (input) for mailman id 430740;
 Wed, 26 Oct 2022 19:03:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onlgc-000761-EJ; Wed, 26 Oct 2022 19:03:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onlgc-0001OY-Ak; Wed, 26 Oct 2022 19:03:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onlgb-0002i2-Rr; Wed, 26 Oct 2022 19:03:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onlgb-0007tV-RB; Wed, 26 Oct 2022 19:03:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GGBWvqMvFfi1h0w796cvk2LyFeJ9rchu0kHeZFAOf7I=; b=BE29Q/xUYZsXVK9u1eQV6dhtQG
	+4nk7BS9PGjeHDDGuqKFQ/MUQf3zN77EC/nRpzP5ObJKhIdLs8wAXn2fg7JCckmNKzO9K0Ju7Iy8z
	4M5BeTS3ajaQSRcpJ/WP3pbS0hbOiVGMSgyu4d9fSGcSAdEpRuJ0A7pIRZsoUtr9nDqE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174406-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174406: regressions - FAIL
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-amd64-xl-credit2:<job status>:broken:regression
    xen-4.14-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.14-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression
    xen-4.14-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.14-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-4.14-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.14-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=016de62747b26ead5a5c763b640fe8e205cd182b
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 19:03:33 +0000

flight 174406 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174406/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit2     <job status>                 broken  in 173725
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172550
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172550
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172550
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172550
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172550
 test-arm64-arm64-xl-vhd      12 debian-di-install        fail REGR. vs. 172550
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172550

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  5 host-install(5) broken in 173725 pass in 174406
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 173725 pass in 174406
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 173906 pass in 174406
 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail in 173906 pass in 174406
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 173906 pass in 174406
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173725
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173725
 test-arm64-arm64-xl          14 guest-start                fail pass in 173906
 test-arm64-arm64-xl-credit1  14 guest-start                fail pass in 173906
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173906

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172550

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173725 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173725 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173906 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173906 never pass
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  016de62747b26ead5a5c763b640fe8e205cd182b
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   72 days
Failing since        173496  2022-10-11 14:08:01 Z   15 days   15 attempts
Testing same since   173650  2022-10-13 00:06:56 Z   13 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-amd64-amd64-xl-credit2 broken

Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:19:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:19:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430747.682769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlw0-0000fJ-EQ; Wed, 26 Oct 2022 19:19:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430747.682769; Wed, 26 Oct 2022 19:19:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlw0-0000fC-Bf; Wed, 26 Oct 2022 19:19:28 +0000
Received: by outflank-mailman (input) for mailman id 430747;
 Wed, 26 Oct 2022 19:19:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JuuU=23=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1onlvy-0000f6-SD
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 19:19:26 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1a92c879-5563-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 21:19:25 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id B52D1B8241E;
 Wed, 26 Oct 2022 19:19:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7499AC433D6;
 Wed, 26 Oct 2022 19:19:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a92c879-5563-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1666811963;
	bh=qI3fTCewS7KVbEY+3VrAXb+svFxvbLAAcucZ9EWRHFk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=YTB8sz2vt99z0Hsu2Oy7nIJivr/0CmeNx5y8X4eBaLfBFb/2sQnoGhmKzSNUHhjTx
	 pOs9Rdan0nozxb8WdLTSIhmiXEZWs2M749z3nKy+ktfSobcIc368Bu4q20RMIyIz9y
	 J2rWWuO3ibVzgfa0XXaJ5gZfn5Yn0Xl/JxTdQGaMRmp+N4N8ZsdOlgBlFDqgY/ylPu
	 NroHu23GP/cUXmpW8a8tOyhHRqYkVlmLut4+DaQkTdh8L+86k6eY5AXtFFXB3Az1Uq
	 W/6oPRJk62ObKJ++ugF3zRj80w6Stb9VosXtE1ZSLFjuIVdGuADEcIvicwkQ5ee0xB
	 9Uev+YMzuumLg==
Date: Wed, 26 Oct 2022 12:19:21 -0700 (PDT)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Andrew Cooper <andrew.cooper3@citrix.com>
cc: Xen-devel <xen-devel@lists.xenproject.org>, 
    George Dunlap <George.Dunlap@eu.citrix.com>, 
    Jan Beulich <JBeulich@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH] CI: Drop more TravisCI remnants
In-Reply-To: <20221026123906.10421-1-andrew.cooper3@citrix.com>
Message-ID: <alpine.DEB.2.22.394.2210261219120.4028@ubuntu-linux-20-04-desktop>
References: <20221026123906.10421-1-andrew.cooper3@citrix.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 26 Oct 2022, Andrew Cooper wrote:
> This was missed from previous attempts to remove Travis.
> 
> Fixes: e0dc9b095e7c ("CI: Drop TravisCI")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> CC: George Dunlap <George.Dunlap@eu.citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Wei Liu <wl@xen.org>
> CC: Julien Grall <julien@xen.org>
> CC: Henry Wang <Henry.Wang@arm.com>
> 
> Preforably for 4.17.  Not a bugfix, but this does reduce the amount of
> irrelevant junk in the tree.
> ---
>  MAINTAINERS          |  1 -
>  scripts/travis-build | 32 --------------------------------
>  2 files changed, 33 deletions(-)
>  delete mode 100755 scripts/travis-build
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 816656950ae2..175f10f33fc9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -274,7 +274,6 @@ W:	https://gitlab.com/xen-project/xen
>  S:	Supported
>  F:	.gitlab-ci.yml
>  F:	automation/
> -F:	scripts/travis-build
>  
>  CPU POOLS
>  M:	Juergen Gross <jgross@suse.com>
> diff --git a/scripts/travis-build b/scripts/travis-build
> deleted file mode 100755
> index 84d74266a01f..000000000000
> --- a/scripts/travis-build
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -#!/bin/bash -ex
> -
> -$CC --version
> -
> -# random config or default config
> -if [[ "${RANDCONFIG}" == "y" ]]; then
> -    make -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig
> -else
> -    make -C xen defconfig
> -fi
> -
> -# build up our configure options
> -cfgargs=()
> -cfgargs+=("--disable-stubdom") # more work needed into building this
> -cfgargs+=("--disable-rombios")
> -cfgargs+=("--enable-docs")
> -cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
> -
> -# Qemu requires Python 3.5 or later
> -if ! type python3 || python3 -c "import sys; res = sys.version_info < (3, 5); exit(not(res))"; then
> -    cfgargs+=("--with-system-qemu=/bin/false")
> -fi
> -
> -if [[ "${XEN_TARGET_ARCH}" == "x86_64" ]]; then
> -    cfgargs+=("--enable-tools")
> -else
> -    cfgargs+=("--disable-tools") # we don't have the cross depends installed
> -fi
> -
> -./configure "${cfgargs[@]}"
> -
> -make dist
> -- 
> 2.11.0
> 


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:23:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:23:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430752.682785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlzS-00026z-Vy; Wed, 26 Oct 2022 19:23:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430752.682785; Wed, 26 Oct 2022 19:23:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onlzS-00026s-Ry; Wed, 26 Oct 2022 19:23:02 +0000
Received: by outflank-mailman (input) for mailman id 430752;
 Wed, 26 Oct 2022 19:23:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JODj=23=citrix.com=prvs=291bfe38a=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1onlzR-00026m-Oh
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 19:23:01 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99081653-5563-11ed-8fd0-01056ac49cbb;
 Wed, 26 Oct 2022 21:22:59 +0200 (CEST)
Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 26 Oct 2022 15:22:52 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by SJ0PR03MB6780.namprd03.prod.outlook.com (2603:10b6:a03:40f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct
 2022 19:22:49 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Wed, 26 Oct 2022
 19:22:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99081653-5563-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666812179;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=WjzLjmUBSF8IfMHwDmsvFGtp+uN9bZMhqT2udzAfy+A=;
  b=YTw2EmOwfPqk1IWl34wlRhJdq3Zq0x5NSyjDRMc77coZYusalCFc9Vp7
   2wpoJzEmixH5QvzeYJqz9NJSvKrbQWFS1Qgynmj2V8+JJWlzTl5kqzOtE
   cPaR2yYTVQRn5EPlryzGuj0PrOaFlppSVx0SBfdZcHm9fRFDD6NjEiHDs
   g=;
X-IronPort-RemoteIP: 104.47.56.176
X-IronPort-MID: 86108880
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:gRHv5KxwIHya3ZXNsCl6t+enxyrEfRIJ4+MujC+fZmUNrF6WrkUEm
 GoXXG+PaazcMTageI11atjl/RkPvZ+DnIdkGQs9qyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s
 ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC4ARkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwyuJ+DlFs2
 9wjGT0fM0CFvcm26a+rVbw57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDa7IA9ZidABNPL8fNCQSNoTtUGfv
 m/cpEzyAw0ANczZwj2Amp6prr+RxHurCNJKfFG+3r1VrW2YwzMqMg8PeEqChsuTiUSkBt0Kf
 iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZiVadNUsucsyRDor/
 lyEhdXkAXpoqrL9YXCA8raZqxuiNC5TKnUNDQc6Sg8C78jmsZsEpBvFRdZ+E4a4ltTwXzr3x
 liipiUkm68ai8JN0qyh5E3GmBqlvJ2PRQkwji33U2S//0VGbYiqT4Wy7B7Q6vMoBJaUSByNs
 WYJn+Ca7fsSFtedmSqVWuIPEbq1ofGfP1XhbUVHGpAg83Gm/CeldIUJuTVmfh42bIADZCPjZ
 1LVtUVJ/phPMXC2bKhxJYWsF8AtyqumHtPgPhzJUudzjlFKXFfv1ElTiYS4hggBTGBEfXkDB
 Kqm
IronPort-HdrOrdr: A9a23:fNAbPqNK9+V7PcBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp
 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM
 tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH
 Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W
 /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+
 Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536
 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu
 UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+
 jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI
 SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
X-IronPort-AV: E=Sophos;i="5.95,215,1661832000"; 
   d="scan'208";a="86108880"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E3UZdXGBcM5GjvYK+kG6Tr9AhBumsDaJhUea2HcduLG/xTC82Cr0M4ewwuE2npk/SIOs0N/kklBUa68Mg02xVwgyBVX5DY1xDRyOvMbK7mUpvVpk5i4V8UQ16/NXXBfcYmp0bwVBH7wkVBWbMhsMd4H8gbRX7ljRtPllmtBIanI4h66YmPQ1KxX3QydN1Q0AUUCjvmmFeoTHSJ44M0aaB539zuhedK5N7MOCnBDiPi44Cfn+Ng9XYSd5etwGTj/S7Bd9WSQlhaXRRX7/ONwHBCLIpGxnkpRA3P1uGDUHCgZvuqxB7aGcXj6Txul/HVdsH6LJdrZ002EKD4v8Db8fRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WjzLjmUBSF8IfMHwDmsvFGtp+uN9bZMhqT2udzAfy+A=;
 b=OSR+8WZfRuXESaMC7qva+q/S1Zh8hqlbA//4ANB/mvUC6WV0BGebptkwIodjryINVvohPyONv4K+ELpTLYE+UaUKCJoXsAYD3r5P+LHgBNgy9+e6w8d7/yPS6cFrlGwToO2nnmvphZKQG17JFfO63JStUfru+3zuagoxeJlCkMbkkniXn4n8bOJFVQdUuMuAqx/GwCv7IsyIAOvAB6mPiyQJ9A++G35whIVlNAhQ+kuHlPTFTno52HPqE60IA6cppifgdV6oOqRsBuXMu1dr+tiGsCdCCXFXaDshQ27wJdofmrGSc0YquK2N6y4JKaxeJS2cRe4psfceyUjL/5llxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WjzLjmUBSF8IfMHwDmsvFGtp+uN9bZMhqT2udzAfy+A=;
 b=PEJ4ScWY6it1AofGvtVaeRCe1YSgDOWjFT3zZH2wKy737VKCpn0pe1VAktnlW4uN/iL3xMUsz4gT4UpN3x9XHVZOGPgMFjMd4em69W2ev6GMPAFfucBbBC64wQTcNDEquM38+2qLjYWirntT20oNUPxx7NI+tZatv94UMO6Aw3I=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>, Anthony Perard
	<anthony.perard@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Thread-Topic: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m
 pool size
Thread-Index: AQHY6SSZFNY32ndKvEeCzPqKJo4FHa4grzqAgABfJgA=
Date: Wed, 26 Oct 2022 19:22:48 +0000
Message-ID: <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
In-Reply-To: <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6780:EE_
x-ms-office365-filtering-correlation-id: f3a4a851-3ef3-4114-b0d4-08dab78777cf
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 BmKi+sRvfhZZaZMCgfdTciY5EhA5j9frJ0eKh4XjSY3lfVZpPH10epdyj2g7cfFd99vXz9OAgsyofJ3yqbloA4qRTv+/WB6OnTy1jBi1tnC8KE1fUOYQeGsuWJj1laBXtYmtuE5iiPFuJ4plfRgaGoJz0zH9AmCG0jIQWJh5o6ajsfGN0t00tVfG2fTT/cqRqz2VQMBEuzNsCITovJURz6Bx/xmLMZrCt2C8NvJgIG+U0NnloICQD3DtrB6BujjTPlsIo2vifRmh+5rLCyCNZRhxmx8q4y4mBC0ny745o80wJwEIwF+MWNqNd3xUhzvvJhJfLmJeydwNFX4zEYK+n3UGtRu/anncAKB6yYab8iErX6xBJOzDKiUbGb0IAhz2/YYPMWJXJpmL1IkfHCG8N3CSa8UcXt5xIgd5MJenHl9HVVIuhIMVfRYFKEJYAoG0txgI4blVqy4bSeK4lyr4pP12HAL8DSEpPYIwtl65bBtiBV7XpK3U3RBxxU6ZJBklNNDoBS4WD8FHWbsV1OHWCLI8obH4tCaOk7H1T847GZDB+j6Z6g5cuqIlxJexcBz0lSn/7Dvg2a2m2ncdOI63AL2w+ord5+PWTyMvSBUV1yKxZ3HWefEhmM7vmbJ4UUMH9DgVQkGNeV6nz1eiQvOwtCkjRpgN+wc14htK62oc0Ji0SwHVuPRgsMfdkRyCAyjVTvvRg1BdGwqvJJXrO0h9CyHLegZB4X3qCih7nWigAKy+ErTLoGnXMQwAsRF/CiOuIpot8UU8ZVmpkN5dSfTJ6aAo9O4ISyCOrQbupjDEHiCtXMuHBFyUvkE1KJWcUQPraP0yuNC0/nETSIX01LeGhas3KuFKn6aPDapVM7be3WY=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199015)(38070700005)(5660300002)(2906002)(36756003)(6916009)(4326008)(86362001)(76116006)(53546011)(6512007)(8936002)(66556008)(91956017)(66946007)(64756008)(8676002)(66476007)(41300700001)(26005)(316002)(54906003)(66446008)(6506007)(38100700002)(2616005)(71200400001)(82960400001)(186003)(478600001)(83380400001)(6486002)(31696002)(122000001)(31686004)(45980500001)(43740500002)(473944003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Sng5aXFBUkx5ZjZpMHZpQjBNRnA5aE0vcHQyUkNsbGNUZHQyQVhHN3VVbXRa?=
 =?utf-8?B?aEZpZHZycys1dk0vd1VQNjNSMWNINjloVldkQythM2Z2dG5YZTgwNHVNcW5H?=
 =?utf-8?B?YlcrSXBLQ1Q3c0lTZUc2bHd1ajVSNmxWMThhQ0hPYlFmeE5vK0FhZ0FoUzUw?=
 =?utf-8?B?K0tFUktJcjlTb2JScm9tTklSZm5QM3N3UzNLb2NaUERSTENoQ2k3YlVVWWI1?=
 =?utf-8?B?SFdNMjAwWWhIU25yUkEwMlk5ZnF3MWk5SG01dUF2encyMExRVUxVVEw0cGt0?=
 =?utf-8?B?NkMxMXZaamY4RUtDelRoa3hCREV0bkw4RENKUlFRL3B6MmRmMW8veEtsSms0?=
 =?utf-8?B?bHBGU2V5QkJVbWRHNnRyWjI5OWZTZGpBSytHM1NFZExKajZRTDBDSCttN1ls?=
 =?utf-8?B?Y2tWSG84dTV1VGliVjRlWG9wcXBTYVpEdVlXNU0yOFp4TlBsQXVXSVp6UXpO?=
 =?utf-8?B?ZjU0NUx2d1ZjRkM4ZTNWRnM0Q1lpYThBdTg2SVpTcWpLQ0tNNWlycm1pb0FJ?=
 =?utf-8?B?SE4vOUxsNWF4SXNWVzE2aDNXdXNBaS8wMjd2WCsxdVRvOVhMVlRNcHpER2l0?=
 =?utf-8?B?RHdKalRsM25zdTVyZnFpaCtleTlSL0p4UjdUbjhFelA0NjJRQjROYVBuaEVs?=
 =?utf-8?B?ejJaZ3oxZUtQYUVSVHVDRjZ3aXN1bEllOXlKQ25zSkRTaVlRTWtCMFA4U01P?=
 =?utf-8?B?Y3NnVUZsY0c1SWJqNTVqMVduaVdIRHpkY0pLaGFiWTNTUDBKbE1obDNSSGc3?=
 =?utf-8?B?MWVTckxoZlM2dzNmb2dqbVdhQXphQWlwdkNzR09zcklPc2E5QnJka1BtVkNE?=
 =?utf-8?B?YWRHMFU4ajR5OFF3UXFEbUIxNUR5eTkzOXUxL2xGb1h1WkNzVnpRRDFGN0NM?=
 =?utf-8?B?clFvNktJbWRSTmFSQTUxVUxxY0JqZlYzYUJtaVJNK2RzdDZCYXhmZXZDVkVH?=
 =?utf-8?B?NExkZlhPcWtWODhTUGJ4RlhONkVNcDh3SWJud0xDRXhlaFVEZ2ZlZEw4U3Rq?=
 =?utf-8?B?OFIrRVVuTVFBYitjeWRQMXQ0VmFmMEZ1NVVYUG1UVmFGVE50MEMwM1ZGcjhP?=
 =?utf-8?B?WE9reTlCZHk0eGdwYkNYM0FqYUl2UEJrdG1wNFJDc2ZmU3NRMzNveDJlS3Br?=
 =?utf-8?B?Zzl0ZllvakV3UEo3QlhuY3FQMWFTTFg1TXZrekFSY3plSEJMOEdDQll3bGIy?=
 =?utf-8?B?d1NPcTR1bkJRd0c4NGc4SHdhTWdveE9HMWxBVWFRbTJqUEtjYUJHdWw2ZTdn?=
 =?utf-8?B?bS9HYXQzRzB1dWRYRWx3MTBnWlIvQ2VYSlZGSlhPQWdwM3B3UFllbStweGgv?=
 =?utf-8?B?R2FoTWNTU0FmM3BhYTZ1WUtSRmFzeElPZ0RIcHc1V1RzNkUwc2dlamE4WDhG?=
 =?utf-8?B?OFJURENqYVVjYmRVZVlkTVh3dzJIVU9PTHk3T3lKV0RRV1hIejRXQUV4cWJR?=
 =?utf-8?B?OXIxcTZVOFpGd0dVUlZNT2l2SjI1cFNBbHUyOHFBRkpub3B0Wm9haWtDb2tv?=
 =?utf-8?B?ZjBsOXJRQmpQdmJrMlpQWVFMOXhBWU90RlZoU3ZKREd4OUhjcldVK0FoOVVp?=
 =?utf-8?B?OVdwMmtkK2xNUGRSbG5zb2VBMkl4NzNwMlpSN1hFd1BWNVh0SHdsLytURFpw?=
 =?utf-8?B?bzVJdDZ5ODlqNG5NOVlsU240UlFlSEJFYTZIdTVVUWx5VWRlK3NlZXI4azdT?=
 =?utf-8?B?azZKOFNNVXpKdTZUcWRlenhnRmVaVWVRa3NOYkdQbzgxYVlLdURhMms4NmJz?=
 =?utf-8?B?QUNPTXUrY0thMXdoTS9QRUY0VDQyKzRRdlFGQ2dZTVZzc0QxbmF1K3lNVEo0?=
 =?utf-8?B?dmdBYlZBU051UEF5cXNKaGUzejA2SXdEcVFYRDg4TCtHVFhLY3U2MjAxYitE?=
 =?utf-8?B?MnVKM3FNL3pEeHpTUmZVSkU5eXE5d2NLMTNUa0o2RFV3SzB5Y3h2YXFjNHNx?=
 =?utf-8?B?citEa0NoNHlsYUtDc003cVNTU3FaVmFGTWJiUXd2KzcrcTM0THVkNmsvbVFz?=
 =?utf-8?B?NlJ3N0RvdkJHU1k3cWRrR0F5NWV1Sk5qRlptem41RlQxNHVaRkpoRTBLd1Ny?=
 =?utf-8?B?ekFyYmkvN3B2d096a1JLclNncitPV3FDTXNLcmJsc0luRjc3eXFvakEvaHFI?=
 =?utf-8?Q?CHkLJqxPYebYNjNbtH8cDuttE?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <11B469EBA4AEBF4B939786C31519D69E@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3a4a851-3ef3-4114-b0d4-08dab78777cf
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 19:22:48.4289
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pi4b1rwT3ezR9kBI+OhpBqwJGFq7AhMXjc/8xGTGgholxVE9U750R8Q2ryrmPa2HHPIGDJAIp/02Pv27oTjkgOCEeWNUr0HDXpPq7ibJQF4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6780

T24gMjYvMTAvMjAyMiAxNDo0MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjEwLjIwMjIg
MTI6MjAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGUgZXhpc3RpbmcgWEVOX0RPTUNUTF9T
SEFET1dfT1Bfe0dFVCxTRVR9X0FMTE9DQVRJT04gaGF2ZSBwcm9ibGVtczoNCj4+DQo+PiAgKiBB
bGwgc2V0X2FsbG9jYXRpb24oKSBmbGF2b3VycyBoYXZlIGFuIG92ZXJmbG93LWJlZm9yZS13aWRl
biBidWcgd2hlbg0KPj4gICAgY2FsY3VsYXRpbmcgInNjLT5tYiA8PCAoMjAgLSBQQUdFX1NISUZU
KSIuDQo+PiAgKiBBbGwgZmxhdm91cnMgaGF2ZSBhIGdyYW51bGFyaXR5IG9mIG9mIDFNLiAgVGhp
cyB3YXMgdG9sZXJhYmxlIHdoZW4gdGhlIHNpemUNCj4+ICAgIG9mIHRoZSBwb29sIGNvdWxkIG9u
bHkgYmUgc2V0IGF0IHRoZSBzYW1lIGdyYW51bGFyaXR5LCBidXQgaXMgYnJva2VuIG5vdw0KPj4g
ICAgdGhhdCBBUk0gaGFzIGEgMTYtcGFnZSBzdG9wZ2FwIGFsbG9jYXRpb24gaW4gdXNlLg0KPj4g
ICogQWxsIGdldF9hbGxvY2F0aW9uKCkgZmxhdm91cnMgcm91bmQgdXAsIGFuZCBpbiBwYXJ0aWN1
bGFyIHR1cm4gMCBpbnRvIDEsDQo+PiAgICBtZWFuaW5nIHRoZSBnZXQgb3AgcmV0dXJucyBqdW5r
IGJlZm9yZSBhIHN1Y2Nlc3NmdWwgc2V0IG9wLg0KPj4gICogVGhlIHg4NiBmbGF2b3VycyByZWpl
Y3QgdGhlIGh5cGVyY2FsbHMgYmVmb3JlIHRoZSBWTSBoYXMgdkNQVXMgYWxsb2NhdGVkLA0KPj4g
ICAgZGVzcGl0ZSB0aGUgcG9vbCBzaXplIGJlaW5nIGEgZG9tYWluIHByb3BlcnR5Lg0KPiBJIGd1
ZXNzIHRoaXMgaXMgbWVyZWx5IGEgcmVtbmFudCBhbmQgY291bGQgZWFzaWx5IGJlIGRyb3BwZWQg
dGhlcmUuDQoNCkl0J3MgaW50ZXJtaXhlZCB0aGUgb3RoZXIgc2hhZG93IG9wZXJhdGlvbnMuwqAg
SXQgd2Fzbid0IHRyaXZpYWxseS1zYWZlDQplbm91Z2ggdG8gZG8gaGVyZSwgYW5kIG5lZWRzIGNv
bWluZyBiYWNrIHRvIGluIGZ1dHVyZSB3b3JrLg0KDQo+DQo+PiAgKiBFdmVuIHRoZSBoeXBlcmNh
bGwgbmFtZXMgYXJlIGxvbmctb2Jzb2xldGUuDQo+Pg0KPj4gSW1wbGVtZW50IGFuIGludGVyZmFj
ZSB0aGF0IGRvZXNuJ3Qgc3Vjaywgd2hpY2ggY2FuIGJlIGZpcnN0IHVzZWQgdG8gdW5pdCB0ZXN0
DQo+PiB0aGUgYmVoYXZpb3VyLCBhbmQgc3Vic2VxdWVudGx5IGNvcnJlY3QgYSBicm9rZW4gaW1w
bGVtZW50YXRpb24uICBUaGUgb2xkDQo+PiBpbnRlcmZhY2Ugd2lsbCBiZSByZXRpcmVkIGluIGR1
ZSBjb3Vyc2UuDQo+Pg0KPj4gVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDkgLyBDVkUtMjAyMi0zMzc0
Ny4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj
aXRyaXguY29tPg0KPj4gLS0tDQo+PiBDQzogWGVuIFNlY3VyaXR5IFRlYW0gPHNlY3VyaXR5QHhl
bi5vcmc+DQo+PiBDQzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPj4gQ0M6IFJv
Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPj4gQ0M6IFdlaSBMaXUgPHds
QHhlbi5vcmc+DQo+PiBDQzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu
b3JnPg0KPj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+PiBDQzogVm9sb2R5
bXlyIEJhYmNodWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPj4gQ0M6IEJlcnRyYW5k
IE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCj4+IENDOiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+DQo+PiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJk
QGNpdHJpeC5jb20+DQo+Pg0KPj4gTmFtZSBzdWJqZWN0IHRvIGltcHJvdmVtZW50Lg0KPiBwYWdp
bmdfe2dldCxzZXR9X21lbXBvb2xfc2l6ZSgpIGZvciB0aGUgYXJjaCBoZWxwZXJzIChpbiBwYXJ0
aWN1bGFyDQo+IGZpdHRpbmcgYmV0dGVyIHdpdGggdGhlbSBsaXZpbmcgaW4gcGFnaW5nLmMgYXMg
d2VsbCBpdHMgbXVsdGktcHVycG9zZSB1c2UNCj4gb24geDg2KSBhbmQgWEVOX0RPTUNUTF97Z2V0
LHNldH1fcGFnaW5nX21lbXBvb2xfc2l6ZT8gUGVyaGFwcyBldmVuIHRoZQ0KPiAibWVtIiBjb3Vs
ZCBiZSBkcm9wcGVkPw0KDQpZZWFoLCB0aGlzIHdhcyBhIHBsYWNlaG9sZGVyIGZvciAid2hhdCBh
cmUgd2UgYWN0dWFsbHkgZ29pbmcgdG8gY2FsbCBpdA0KaW4gWGVuIi4NCg0KSSB3ZW50IHdpdGgg
bWVtcG9vbCBvdmVyIGp1c3Qgc2ltcGx5IHBvb2wgYmVjYXVzZSBwb29sIGhhcyBhIHZlcnkNCmRp
ZmZlcmVudCBtZWFuaW5nIHNsaWdodGx5IGhpZ2hlciBpbiB0aGUgdG9vbHN0YWNrIHdoZXJlIHlv
dSB0YWxrIGFib3V0DQpwb29scyBvZiBzZXJ2ZXJzLsKgIEFkbWl0dGVkbHksIHRoYXQncyBjb2Rl
IG91dHNpZGUgb2YgeGVuLmdpdCwgYnV0IHRoZQ0KaHlwZXJjYWxsIG5hbWVzIGRvIHBlcmNvbGF0
ZSB1cCBpbnRvIHRob3NlIGNvZGViYXNlcy4NCg0KcGFnaW5nIGlzbid0IGEgZ3JlYXQgbmFtZS7C
oCBXaGlsZSBpdCdzIHdoYXQgd2UgY2FsbCB0aGUgaW5mcmFzdHJ1Y3R1cmUNCmluIHg4NiwgaXQg
aGFzIG5vdGhpbmcgdG8gZG8gd2l0aCBwYWdpbmcgdGhpbmdzIG91dCB0byBkaXNrICh0aGUgdGhp
bmcNCmV2ZXJ5b25lIGFzc29jaWF0ZXMgdGhlIG5hbWUgd2l0aCksIG5vciB0aGUgeGVucGFnaW5n
IGluZnJhc3RydWN0dXJlDQooWGVuJ3MgdmVyc2lvbiBvZiB3aGF0IE9TIHBhZ2luZyBzdXBwb3Nl
ZGx5IG1lYW5zKS4NCg0KPg0KPj4gIEFCSSBub3QuDQo+IFdpdGggdGhlIGNvbW1lbnQgaW4gdGhl
IHB1YmxpYyBoZWFkZXIgc2F5aW5nICJVc2VycyBvZiB0aGlzIGludGVyZmFjZSBhcmUNCj4gcmVx
dWlyZWQgdG8gaWRlbnRpZnkgdGhlIGdyYW51bGFyaXR5IGJ5IG90aGVyIG1lYW5zIiBJIHdvbmRl
ciB3aHkgdGhlDQo+IGludGVyZmFjZSBuZWVkcyB0byBiZSBieXRlLWdyYW51bGFyLiBJZiB0aGUg
Y2FsbGVyIG5lZWRzIHRvIGtub3cgcGFnZSBzaXplDQo+IGJ5IHdoYXRldmVyIG1lYW5zLCBpdCBj
YW4gYXMgd2VsbCBwYXNzIGluIGEgcGFnZSBjb3VudC4NCg0KTm90IGFsbCBhcmNoaXRlY3R1cmVz
IGhhdmUgcGFnZXRhYmxlIGxldmVscyBvZiB1bmlmb3JtIHNpemUuwqAgTm90IGFsbA0KYXJjaGl0
ZWN0dXJlcyBoYXZlIHRoZSBtYXBwaW5nIGdyYW51bGFyaXR5IGVxdWFsIHRvIHRoZSBwYWdldGFi
bGUgc2l6ZS7CoA0KeDg2IGhhcyBleGFtcGxlcyBvZiBib3RoIG9mIHRoZXNlIChhbmQgaW4gYSBy
b2d1ZSBtb3ZlLCBvbmUgeDg2IGhhcmR3YXJlDQp2ZW5kb3IgaXMgdHJ5aW5nIHRvIGFkZCBldmVu
IG1vcmUgcGFnZXRhYmxlIGFzeW1tZXRyeSkuwqAgT3RoZXINCmFyY2hpdGVjdHVyZXMgc3Vic3Rh
bnRpYWxseSBtb3JlIHZhcmlldHkuDQoNCkV2ZW4gb24geDg2LCB0aGVyZSBhcmUgcGVyZm9ybWFu
Y2UgYWR2YW50YWdlcyBmcm9tIHVzaW5nIDhrIG9yIDE2aw0KYXJyYW5nZW1lbnRzLCB3aGljaCBj
b3VsZCBjYXVzZSB1cyBpbnNpc3QgdXBvbiA+NGsgcmVxdWlyZW1lbnRzIGhlcmUuwqANCihUQkgs
IG5vdCBhY3R1YWxseSBmb3IgdGhpcyB1c2VjYXNlLCBidXQgdGhlIHByaW5jaXBsZSBpcyBzdGls
bCB2YWxpZC4pDQoNCg0KVGhlIHJlYXNvbiBpcyBiZWNhdXNlIHRoaXMgaXMgYSBzaXplLsKgIFNp
emVzIGFyZSBpbiBieXRlcywgYW5kIHRoYXQncw0KaG93IGV2ZXJ5b25lIHRoaW5rcyBhYm91dCB0
aGVtLsKgIEl0cyBob3cgdGhlIHZhbHVlIGlzIGFscmVhZHkgc3BlY2lmaWVkDQppbiBhbiB4bCBj
ZmcgZmlsZSwgYW5kIGl0IGVudGlyZWx5IHVuYW1iaWd1b3VzIGF0IGFsbCBsZXZlbHMgb2YgdGhl
IHN0YWNrLg0KDQpFdmVyeSB0cmFuc2xhdGlvbiBvZiB0aGUgdmFsdWUgaW4gdGhlIHNvZnR3YXJl
IHN0YWNrIHJpc2tzIGJyZWFraW5nDQp0aGluZ3MsIGV2ZW4gc3R1ZmYgYXMgc2ltcGxlIGFzIGRl
YnVnZ2luZy7CoCBBcyBwcm9vZiwgY291bnQgdGhlIG51bWJlcg0Kb2YgdHJhbnNsYXRpb24gZXJy
b3JzIEkndmUgYWxyZWFkeSBpZGVudGlmaWVkIGluIHRoaXMgcGF0Y2ggYWxvbmUuDQoNClRoaXMg
QUJJIGRvZXMgbm90IHJlcXVpcmUgYW55IGNoYW5nZXMgYXQgYWxsIChub3QgZXZlbiByZWNvbXBp
bGluZw0KdXNlcnNwYWNlKSBmb3IgQVJNIHRvIGRlY2lkZSB0byB1c2UgMTZrIG9yIDY0ayBwYWdl
dGFibGVzIGluIFhlbiwgb3IgZm9yDQp4ODYgdG8gZGVjaWRlIHRoYXQgOGsgb3IgMTZrIGlzIGJl
bmVmaWNpYWwgZW5vdWdoIHRvIGFjdHVhbGx5IHJlcXVpcmUuDQoNCkF0dGVtcHRpbmcgdG8gY29t
cHJlc3MgdGhpcyB1aW50NjRfdCBpbnRvIHNvbWV0aGluZyBzbWFsbGVyIGJ5IGFueSBtZWFucw0K
d2lsbCBjcmVhdGUgYnVncywgb3IgYXQgaW5jcmVhc2VkIGNvbXBsZXhpdHkgYW5kIGEgaGlnaCBy
aXNrIG9mIGJ1Z3MuwqANClRoZXJlIGlzbid0IGVub3VnaCBtb25leSBvbiBlYXJ0aCByaWdodCBu
b3cgdG8gYWZmb3JkIGEgMTI4Yml0IHByb2Nlc3Nvcg0Kd2l0aCBlbm91Z2ggcmFtIGZvciB0aGlz
IGN1cnJlbnQgQUJJIHRvIG5lZWQgY2hhbmdpbmcuDQoNCg0KVGhpcyBpcyBnb2luZyB0byBiZSBh
IHJlb2NjdXJyaW5nIHRoZW1lIHRocm91Z2ggZml4aW5nIHRoZSBBQklzLsKgIEl0cw0Kb25lIG9m
IGEgc2V2ZXJhbCBhcmVhcyB3aGVyZSB0aGVyZSBpcyBvYmplY3RpdmVseSBvbmUgcmlnaHQgYW5z
d2VyLCBib3RoDQppbiB0ZXJtcyBvZiBlYXNlIG9mIHVzZSwgYW5kIGNvbXBhdGliaWxpdHkgdG8g
ZnV0dXJlIGNpcmN1bXN0YW5jZXMuDQoNCg0KDQo+DQo+PiBGdXR1cmUgVE9ET3M6DQo+PiAgKiB4
ODYgc2hhZG93IHN0aWxsIHJvdW5kcyB1cC4gIFRoaXMgaXMgYnVnZ3kgYXMgaXQncyBhIHNpbXVs
dGFuZW91cyBlcXVhdGlvbg0KPj4gICAgd2l0aCB0b3RfcGFnZXMgd2hpY2ggdmFyaWVzIG92ZXIg
dGltZSB3aXRoIGJhbGxvb25pbmcuDQo+PiAgKiB4ODYgUFYgaXMgd2VpcmQuICBUaGVyZSBhcmUg
bm8gdG9vbHN0YWNrIGludGVyYWN0IHdpdGggdGhlIHNoYWRvdyBwb29sDQo+PiAgICBzaXplLCBi
dXQgdGhlICJzaGFkb3ciIHBvb2wgaXQgZG9lcyBjb21lIGludG8gZXhpc3RlbmNlIHdoZW4gbG9n
ZGlydHkgKG9yDQo+PiAgICBwdi1sMXRmKSB3aGVuIGZpcnN0IGVuYWJsZWQuDQo+PiAgKiBUaGUg
c2hhZG93K2hhcCBsb2dpYyBpcyBpbiBkZXNwZXJhdGUgbmVlZCBvZiBkZWR1cGluZy4NCj4gSSBo
YXZlIGEgdGlueSBzdGVwIHRvd2FyZHMgdGhpcyBxdWV1ZWQgYXMgcG9zdC1YU0EtNDEwIHdvcmss
IGZvbGRpbmcgSEFQJ3MNCj4gYW5kIHNoYWRvdydzIGZyZWVsaXN0LCB0b3RhbF9wYWdlcywgZnJl
ZV9wYWdlcywgYW5kIHAybV9wYWdlcy4gSGVyZSB0aGlzDQo+IHdvdWxkIG1lYW4ge2hhcCxzaGFk
b3d9X2dldF9hbGxvY2F0aW9uX2J5dGVzKCkgY291bGQgYmUgZG9uZSBhd2F5IHdpdGgsDQo+IGhh
dmluZyB0aGUgbG9naWMgZXhjbHVzaXZlbHkgaW4gcGFnaW5nLmMuDQoNClRoYW5rcy7CoCBJJ2xs
IGRyb3AgdGhhdCB0YXNrIGZyb20gbXkgdG9kbyBsaXN0Lg0KDQpCdXQgcmVhbGx5LCBpdCBuZWVk
IHRvIGJlIGZ1bGx5IGNvbW1vbiwgYmVjYXVzZSBSSVNDLVYgaXMgZ29pbmcgdG8gbmVlZA0KaXQg
dG9vLsKgIChJJ20gdG9sZCBkZXZlbG9wbWVudCBvbiBSSVNDLVYgd2lsbCBzdGFydCBiYWNrIHVw
IGFueSB0aW1lIG5vdy4pDQoNCj4NCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYw0KPj4gKysr
IGIveGVuL2FyY2gvYXJtL3AybS5jDQo+PiBAQCAtMTAwLDYgKzEwMCwxNCBAQCB1bnNpZ25lZCBp
bnQgcDJtX2dldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQpDQo+PiAgICAgIHJldHVybiBS
T1VORFVQKG5yX3BhZ2VzLCAxIDw8ICgyMCAtIFBBR0VfU0hJRlQpKSA+PiAoMjAgLSBQQUdFX1NI
SUZUKTsNCj4+ICB9DQo+PiAgDQo+PiArLyogUmV0dXJuIHRoZSBzaXplIG9mIHRoZSBwb29sLCBp
biBieXRlcy4gKi8NCj4+ICtpbnQgYXJjaF9nZXRfcDJtX21lbXBvb2xfc2l6ZShzdHJ1Y3QgZG9t
YWluICpkLCB1aW50NjRfdCAqc2l6ZSkNCj4+ICt7DQo+PiArICAgICpzaXplID0gQUNDRVNTX09O
Q0UoZC0+YXJjaC5wYWdpbmcucDJtX3RvdGFsX3BhZ2VzKSA8PCBQQUdFX1NISUZUOw0KPiBUaGlz
IG1heSBvdmVyZmxvdyBmb3IgQXJtMzIuDQoNClNvIGl0IHdpbGwuwqAgSSdsbCB3aWRlbiBmaXJz
dC4NCg0KPg0KPj4gQEAgLTE1Nyw2ICsxNjUsMjUgQEAgaW50IHAybV9zZXRfYWxsb2NhdGlvbihz
dHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIHBhZ2VzLCBib29sICpwcmVlbXB0ZWQpDQo+
PiAgICAgIHJldHVybiAwOw0KPj4gIH0NCj4+ICANCj4+ICtpbnQgYXJjaF9zZXRfcDJtX21lbXBv
b2xfc2l6ZShzdHJ1Y3QgZG9tYWluICpkLCB1aW50NjRfdCBzaXplKQ0KPj4gK3sNCj4+ICsgICAg
dW5zaWduZWQgbG9uZyBwYWdlcyA9IHNpemUgPj4gUEFHRV9TSElGVDsNCj4+ICsgICAgYm9vbCBw
cmVlbXB0ZWQgPSBmYWxzZTsNCj4+ICsgICAgaW50IHJjOw0KPj4gKw0KPj4gKyAgICBpZiAoIChz
aXplICYgflBBR0VfTUFTSykgfHwgICAgICAgICAgLyogTm9uIHBhZ2Utc2l6ZWQgcmVxdWVzdD8g
Ki8NCj4+ICsgICAgICAgICBwYWdlcyAhPSAoc2l6ZSA+PiBQQUdFX1NISUZUKSApIC8qIDMyLWJp
dCBvdmVyZmxvdz8gKi8NCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiBTaW1wbHkgIihw
YWdlcyA8PCBQQUdFX1NISUZUKSAhPSBzaXplIj8gQW5kIHRoZW4gbW92ZSB0aGUgY2hlY2sgaW50
bw0KPiBjb21tb24gY29kZT8NCg0KVGhlc2UgY2hlY2tzIGFyZSBkZWxpYmVyYXRlbHkgbm90IGlu
IGNvbW1vbiBjb2RlLsKgIFRoYXQncyBqdXN0IGNyZWF0aW5nDQp3b3JrIHRoYXQgc29tZW9uZSB3
aWxsIG5lZWQgdG8gdW5kbyBpbiBkdWUgY291cnNlLg0KDQo+DQo+PiAtLS0gYS94ZW4vYXJjaC94
ODYvbW0vaGFwL2hhcC5jDQo+PiArKysgYi94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5jDQo+PiBA
QCAtMzQ1LDYgKzM0NSwxNiBAQCB1bnNpZ25lZCBpbnQgaGFwX2dldF9hbGxvY2F0aW9uKHN0cnVj
dCBkb21haW4gKmQpDQo+PiAgICAgICAgICAgICAgKyAoKHBnICYgKCgxIDw8ICgyMCAtIFBBR0Vf
U0hJRlQpKSAtIDEpKSA/IDEgOiAwKSk7DQo+PiAgfQ0KPj4gIA0KPj4gK2ludCBoYXBfZ2V0X2Fs
bG9jYXRpb25fYnl0ZXMoc3RydWN0IGRvbWFpbiAqZCwgdWludDY0X3QgKnNpemUpDQo+PiArew0K
Pj4gKyAgICB1bnNpZ25lZCBsb25nIHBhZ2VzID0gKGQtPmFyY2gucGFnaW5nLmhhcC50b3RhbF9w
YWdlcyArDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgZC0+YXJjaC5wYWdpbmcuaGFw
LnAybV9wYWdlcyk7DQo+IFVubGlrZSBmb3IgQXJtIG5vIEFDQ0VTU19PTkNFKCkgaGVyZT8gQWxz
byB0aGUgYWRkaXRpb24gY2FuIGluDQo+IHByaW5jaXBsZSBvdmVyZmxvdywgYmVjYXVzZSBiZWlu
ZyBkb25lIG9ubHkgaW4gMzIgYml0cy4NCg0KSSdtIG5vdCBhY3R1YWxseSBjb252aW5jZWQgQVJN
IG5lZWRzIEFDQ0VTU19PTkNFKCkgdG8gYmVnaW4gd2l0aC7CoCBJDQpjYW4ndCBzZWUgYW55IGxl
Z2FsIHRyYW5zZm9ybWF0aW9uIG9mIHRoYXQgbG9naWMgd2hpY2ggY291bGQgcmVzdWx0IGluIGEN
CnRvcm4gbG9hZC4NCg0KQm90aCBleGFtcGxlcyB3ZXJlIHdyaXR0ZW4gdG8gbWF0Y2ggdGhlIGV4
aXN0aW5nIGNvZGUsIGJlY2F1c2UgdGhpcw0KbmVlZHMgYmFja3BvcnRpbmcgdG8gYWxsIHNlY3Vy
aXR5IHRyZWVzLg0KDQpJIGZvcmdvdCB0byBtZW50aW9uIHRoZSBvdmVyZmxvdyBvbiB4ODYgaW4g
dGhlIGZ1dHVyZSB0b2RvIHNlY3Rpb24uwqANClRoaXMgY29kZSBpcyByaWZlIHdpdGggdGhlbS4N
Cg0KPg0KPj4gLS0tIGEveGVuL2FyY2gveDg2L21tL3BhZ2luZy5jDQo+PiArKysgYi94ZW4vYXJj
aC94ODYvbW0vcGFnaW5nLmMNCj4+IEBAIC05NzcsNiArOTc3LDQ1IEBAIGludCBfX2luaXQgcGFn
aW5nX3NldF9hbGxvY2F0aW9uKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGludCBwYWdlcywN
Cj4+ICB9DQo+PiAgI2VuZGlmDQo+PiAgDQo+PiAraW50IGFyY2hfZ2V0X3AybV9tZW1wb29sX3Np
emUoc3RydWN0IGRvbWFpbiAqZCwgdWludDY0X3QgKnNpemUpDQo+PiArew0KPj4gKyAgICBpbnQg
cmM7DQo+PiArDQo+PiArICAgIGlmICggaXNfcHZfZG9tYWluKGQpICkNCj4+ICsgICAgICAgIHJl
dHVybiAtRU9QTk9UU1VQUDsNCj4+ICsNCj4+ICsgICAgaWYgKCBoYXBfZW5hYmxlZChkKSApDQo+
PiArICAgICAgICByYyA9IGhhcF9nZXRfYWxsb2NhdGlvbl9ieXRlcyhkLCBzaXplKTsNCj4+ICsg
ICAgZWxzZQ0KPj4gKyAgICAgICAgcmMgPSBzaGFkb3dfZ2V0X2FsbG9jYXRpb25fYnl0ZXMoZCwg
c2l6ZSk7DQo+PiArDQo+PiArICAgIHJldHVybiByYzsNCj4+ICt9DQo+PiArDQo+PiAraW50IGFy
Y2hfc2V0X3AybV9tZW1wb29sX3NpemUoc3RydWN0IGRvbWFpbiAqZCwgdWludDY0X3Qgc2l6ZSkN
Cj4+ICt7DQo+PiArICAgIHVuc2lnbmVkIGxvbmcgcGFnZXMgPSBzaXplID4+IFBBR0VfU0hJRlQ7
DQo+PiArICAgIGJvb2wgcHJlZW1wdGVkID0gZmFsc2U7DQo+PiArICAgIGludCByYzsNCj4+ICsN
Cj4+ICsgICAgaWYgKCBpc19wdl9kb21haW4oZCkgKQ0KPj4gKyAgICAgICAgcmV0dXJuIC1FT1BO
T1RTVVBQOw0KPiBXaHk/IFlvdSBkbyBzYXkgIlBWIGlzIHdlaXJkIiBpbiBhIHBvc3QtY29tbWl0
LW1lc3NhZ2UgcmVtYXJrLCBidXQgd2h5DQo+IGRvIHlvdSB3YW50IHRvIHJldGFpbiB0aGlzIHdl
aXJkbmVzcz8gRXZlbiBpZiB0b2RheSB0aGUgdG9vbCBzdGFjaw0KPiBkb2Vzbid0IHNldCB0aGUg
c2l6ZSB3aGVuIGVuYWJsaW5nIGxvZy1kaXJ0eSBtb2RlLCBJJ2QgdmlldyB0aGlzIGFzIGENCj4g
YnVnIHdoaWNoIGNvdWxkIGJlIGFkZHJlc3NlZCBwdXJlbHkgaW4gdGhlIHRvb2wgc3RhY2sgaWYg
dGhpcyBjaGVjaw0KPiB3YXNuJ3QgdGhlcmUuDQoNCkkgd2FudCB0byBjbGVhbiB1cCBQViwgYnV0
IGFnYWluLCBpdCB3YXNuJ3Qgc3VmZmljaWVudGx5IHRyaXZpYWxseS1zYWZlDQp0byBkbyByaWdo
dCBub3cuDQoNClBWIGlzIHdlaXJkIGJlY2F1c2UgaXQgaXMgbmVpdGhlciBoYXBfZW5hYmxlZCgp
IChmdW5kYW1lbnRhbGx5KSwgbm9yDQpzaGFkb3dfZW5hYmxlZCgpIHdoZW4gbG9nZGlydHkgaXNu
J3QgYWN0aXZlLsKgIFdoaWxlIHRoZSBmcmVlbGlzdCBpcw0Kc3VpdGFibHkgY29uc3RydWN0ZWQs
IHRoZSBnZXQvc2V0IG9wZXJhdGlvbnMgd2VyZSBwcmV2aW91c2x5IHJlamVjdGVkDQphbmQgY2xl
YW51cCBpcyBsb2NhbCB0byB0aGUgZGlzYWJsZSBvcCwgbm90IGRvbWFpbiBzaHV0ZG93bi4NCg0K
SSBjb3VsZCBwdXQgaW4gYSAvKiBUT0RPOiByZWxheCBpbiBkdWUgY291cnNlICovIGlmIHlvdSdk
IHByZWZlcj8NCg0KPj4gKyAgICBpZiAoIHNpemUgJiB+UEFHRV9NQVNLICkgICAgICAgICAgICAg
LyogTm9uIHBhZ2Utc2l6ZWQgcmVxdWVzdD8gKi8NCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFM
Ow0KPj4gKw0KPj4gKyAgICBBU1NFUlQocGFnaW5nX21vZGVfZW5hYmxlZChkKSk7DQo+IE5vdCBv
bmx5IHdpdGggdGhlIFBWIGFzcGVjdCBpbiBtaW5kIC0gd2h5PyBJdCBsb29rcyByZWFzb25hYmxl
IHRvIG1lDQo+IHRvIHNldCB0aGUgcG9vbCBzaXplIGJlZm9yZSBlbmFibGluZyBhbnkgcGFnaW5n
IG1vZGUuDQoNCkJlY2F1c2UgdGhpcyBpcyBob3cgYWxsIHRoZSBleGlzdGluZyBsb2dpYyBpcyBl
eHByZXNzZWQsIGFuZCB0aGlzIHBhdGNoDQp3YW50cyBiYWNrcG9ydGluZy4NCg0KVGhlcmUgaXMg
c29vbyBtdWNoIHRvIGNsZWFuIHVwLi4uDQoNCj4NCj4+ICsgICAgcGFnaW5nX2xvY2soZCk7DQo+
PiArICAgIGlmICggaGFwX2VuYWJsZWQoZCkgKQ0KPj4gKyAgICAgICAgcmMgPSBoYXBfc2V0X2Fs
bG9jYXRpb24oZCwgcGFnZXMsICZwcmVlbXB0ZWQpOw0KPj4gKyAgICBlbHNlDQo+PiArICAgICAg
ICByYyA9IHNoYWRvd19zZXRfYWxsb2NhdGlvbihkLCBwYWdlcywgJnByZWVtcHRlZCk7DQo+IFBv
dGVudGlhbCB0cnVuY2F0aW9uIGZyb20gdGhlICJ1bnNpZ25lZCBsb25nIiAtPiAidW5zaWduZWQg
aW50Ig0KPiBjb252ZXJzaW9ucy4NCg0KSSdkIG5vdCBldmVuIHNwb3R0ZWQgdGhhdCBBUk0gYW5k
IHg4NiB3ZXJlIGRpZmZlcmVudCBpbiB0aGlzIHJlZ2FyZC4NCg0KTW9yZSBzaG9ydCB0ZXJtIGhh
Y2tzLCBpdCBzZWVtcy4NCg0KfkFuZHJldw0K


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:40:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:40:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430761.682808 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmFi-00047a-LI; Wed, 26 Oct 2022 19:39:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430761.682808; Wed, 26 Oct 2022 19:39:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmFi-00047T-IF; Wed, 26 Oct 2022 19:39:50 +0000
Received: by outflank-mailman (input) for mailman id 430761;
 Wed, 26 Oct 2022 19:39:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=ctE9=23=redhat.com=mst@srs-se1.protection.inumbo.net>)
 id 1onmFh-00047M-Bw
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 19:39:49 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f23e33cf-5565-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 21:39:47 +0200 (CEST)
Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com
 [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-92-w1HIvh77NyKPmCwgOdp3fg-1; Wed, 26 Oct 2022 15:39:44 -0400
Received: by mail-wr1-f69.google.com with SMTP id
 d10-20020adfa34a000000b00236616a168bso4994115wrb.18
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 12:39:44 -0700 (PDT)
Received: from redhat.com ([2.52.15.7]) by smtp.gmail.com with ESMTPSA id
 a5-20020a5d4565000000b0022ae401e9e0sm6243967wrc.78.2022.10.26.12.39.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 26 Oct 2022 12:39:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f23e33cf-5565-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666813186;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zUFP9VXXAZ+kSQdE/F04mInbZThaEABWviF23B44Qo8=;
	b=DTjSHT6FnxB3pK9COBtRi+UKMfTzGZ18znCFGzANyPcTi2dYMyqJiprBKdIm9vXGgzFNKM
	y0YJqkxq1YGIiHi1c2lEJGC9m5uTcXD+3nFgqUv4qkaUTcybkusUJlBMTkn0nfufch+ATW
	CkKoo60cmM9hA1n2xgHPFOdfd/dF96A=
X-MC-Unique: w1HIvh77NyKPmCwgOdp3fg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-transfer-encoding:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=zUFP9VXXAZ+kSQdE/F04mInbZThaEABWviF23B44Qo8=;
        b=Nsd7hubH0VzNUsGWecuVSeBgJw+J+a+cd2qDgwvrgfDOapAymF7QF7sf8IMZSR1qVb
         ipK3K0MgMGBYtRyiaf1FSxRD4cA1BEDHAPMCmSRc9VIX3Jj7P+i/SvRw7B2cjLrzmn87
         PqIoJrnyHVX3Km6x5Hm+U3WkHsMamc71IElK4rMu01YlIZqsX4/Ad2Gm3uD37dIO3ys/
         auAnj8D3+D2cwSf358iezXx+IukmToATothg0dHkGoooDuxksAWX9dT32MePQPXWg6nx
         sS4FlPvz+zYSJklznzPJlXu0iS/Nt4BpOdkZoNd9xBVBqHdUAXfh1yhSOJuqUVww29Ga
         9wRA==
X-Gm-Message-State: ACrzQf1bcwWNKIz/RYZysFuEV4jiBImxUfZmSZUSnt8xE2tt6pZ3YeTn
	ZG8t0vm8YC9OBpUqWh2jp2fdNJ1YZZua402BkjgIOlE9sf1Bgw6ikUGw9Ij1k/PAXHDjRvE+EXu
	GZb9x9Z6rBxAdVG6rnGowfycuZag=
X-Received: by 2002:a05:600c:4e8a:b0:3c6:de26:9d6e with SMTP id f10-20020a05600c4e8a00b003c6de269d6emr3615258wmq.117.1666813182426;
        Wed, 26 Oct 2022 12:39:42 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6XpfNr5DFiR2iaFQU1FRspM6+jmQxlo4TAtOlDYDi8YgHu1uoAKiKMqXZOqN6x/jK6CdR3jg==
X-Received: by 2002:a05:600c:4e8a:b0:3c6:de26:9d6e with SMTP id f10-20020a05600c4e8a00b003c6de269d6emr3615242wmq.117.1666813182194;
        Wed, 26 Oct 2022 12:39:42 -0700 (PDT)
Date: Wed, 26 Oct 2022 15:39:37 -0400
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, Stefano Stabellini <sstabellini@kernel.org>,
	Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Greg Kurz <groug@kaod.org>, Eric Blake <eblake@redhat.com>,
	Stefan Weil <sw@weilnetz.de>, Thomas Huth <thuth@redhat.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Markus Armbruster <armbru@redhat.com>, Paul Durrant <paul@xen.org>,
	David Gibson <david@gibson.dropbear.id.au>,
	xen-devel@lists.xenproject.org,
	Ralph Schmieder <ralph.schmieder@gmail.com>,
	Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v11 00/17] qapi: net: add unix socket type support to
 netdev backend
Message-ID: <20221026153926-mutt-send-email-mst@kernel.org>
References: <20221011200539.1486809-1-lvivier@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20221011200539.1486809-1-lvivier@redhat.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=WINDOWS-1252
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, Oct 11, 2022 at 10:05:22PM +0200, Laurent Vivier wrote:
> "-netdev socket" only supports inet sockets.
> 
> It's not a complex task to add support for unix sockets, but
> the socket netdev parameters are not defined to manage well unix
> socket parameters.


Acked-by: Michael S. Tsirkin <mst@redhat.com>


this is Jason's area though.

> As discussed in:
> 
>   "socket.c added support for unix domain socket datagram transport"
>   https://lore.kernel.org/qemu-devel/1C0E1BC5-904F-46B0-8044-68E43E67BE60@gmail.com/
> 
> This series adds support of unix socket type using SocketAddress QAPI structure.
> 
> Two new netdev backends, "stream" and "dgram" are added, that are barely a copy of "socket"
> backend but they use the SocketAddress QAPI to provide socket parameters.
> And then they also implement unix sockets (TCP and UDP).
> 
> Some examples of CLI syntax:
> 
>   for TCP:
> 
>   -netdev stream,id=socket0,addr.type=inet,addr.host=localhost,addr.port=1234
>   -netdev stream,id=socket0,server=off,addr.type=inet,addr.host=localhost,addr.port=1234
> 
>   -netdev dgram,id=socket0,\
>           local.type=inet,local.host=localhost,local.port=1234,\
>           remote.type=inet,remote.host=localhost,remote.port=1235
> 
>   for UNIX:
> 
>   -netdev stream,id=socket0,addr.type=unix,addr.path=/tmp/qemu0
>   -netdev stream,id=socket0,server=off,addr.type=unix,addr.path=/tmp/qemu0
> 
>   -netdev dgram,id=socket0,\
>           local.type=unix,local.path=/tmp/qemu0,\
>           remote.type=unix,remote.path=/tmp/qemu1
> 
>   for FD:
> 
>   -netdev stream,id=socket0,addr.type=fd,addr.str=4
>   -netdev stream,id=socket0,server=off,addr.type=fd,addr.str=5
> 
>   -netdev dgram,id=socket0,local.type=fd,addr.str=4
> 
> v11:
>   - use qemu_set_info_str() in hw/net/xen_nic.c
>   - fix link_down state in stream client mode
>   - cleanup error case in net_stream_receive()
>   - update qapi version to 7.2
> 
> v10:
>   - add Red Hat copyright
>   - initialize dgram_dst to NULL in SOCKET_ADDRESS_TYPE_FD
>   - remove redundente _stream / _dgram in functions name
>   - move net_dgram_init() into net_init_dgram()
>   - address Thomas' comments on qtest
>   - add a function qemu_set_info_str() to set info string
>   - tested stream netdev with fd type using qrap/passt and
>     "-netdev stream,addr.type=fd,server=off,addr.str=5,id=netdev0"
> 
> v9:
>   - add events to report stream connection/disconnection
>   - remove from net/dgram.c send_fn, listen_fd, net_dgram_accept()
>     net_dgram_connect() and net_dgram_send() that are only
>     needed by net/stream.c
>   - remove from net/stream.c send_fn
>   - add Red Hat copyright
>   - add original net/socket.c Stefano's patch (EINVAL)
> 
> v8:
>   - test ipv4 and ipv6 parameters (stream inet)
>   - test abstract parameter (stream unix)
>   - add SocketAddressInet supported parameters in qemu-options.hx
>     (only stream, supported by the move to QIO)
>   - with qio_channel_writev() replace (ret == -1 && errno == EAGAIN)
>     by (ret == QIO_CHANNEL_ERR_BLOCK)
> 
> v7:
>   - add qtests
>   - update parameters table in net.json
>   - update socket_uri() and socket_parse()
> 
> v6:
>   - s/netdev option/-netdev option/ PATCH 4
>   - s/�/ /
>   - update @NetdevStreamOptions and @NetdevDgramOptions comments
>   - update PATCH 4 description message
>   - add missing return in error case for unix stream socket
>   - split socket_uri() patch: move and rename, then change content
> 
> v5:
>   - remove RFC prefix
>   - put the change of net_client_parse() into its own patch (exit() in the
>     function)
>   - update comments regarding netdev_is_modern() and netdev_parse_modern()
>   - update error case in net_stream_server_init()
>   - update qemu-options.hx with unix type
>   - fix HMP "info network" with unix protocol/server side.
> 
> v4:
>   - net_client_parse() fails with exit() rather than with return.
>   - keep "{ 'name': 'vmnet-host', 'if': 'CONFIG_VMNET' }" on its
>     own line in qapi/net.json
>   - add a comment in qapi/net.json about parameters usage
>   - move netdev_is_modern() check to qemu_init()
>   - in netdev_is_modern(), check for JSON and use qemu_opts_do_parse()
>     to parse parameters and detect type value.
>   - add a blank line after copyright comment
> 
> v3:
>   - remove support of "-net" for dgram and stream. They are only
>     supported with "-netdev" option.
>   - use &error_fatal directly in net_client_inits()
>   - update qemu-options.hx
>   - move to QIO for stream socket
> 
> v2:
>   - use "stream" and "dgram" rather than "socket-ng,mode=stream"
>     and ""socket-ng,mode=dgram"
>   - extract code to bypass qemu_opts_parse_noisily() to
>     a new patch
>   - do not ignore EINVAL (Stefano)
>   - fix "-net" option
> 
> CC: Ralph Schmieder <ralph.schmieder@gmail.com>
> CC: Stefano Brivio <sbrivio@redhat.com>
> CC: Daniel P. Berrang� <berrange@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> 
> Laurent Vivier (15):
>   net: introduce convert_host_port()
>   net: remove the @errp argument of net_client_inits()
>   net: simplify net_client_parse() error management
>   qapi: net: introduce a way to bypass qemu_opts_parse_noisily()
>   net: introduce qemu_set_info_str() function
>   qapi: net: add stream and dgram netdevs
>   net: stream: add unix socket
>   net: dgram: make dgram_dst generic
>   net: dgram: move mcast specific code from net_socket_fd_init_dgram()
>   net: dgram: add unix socket
>   qemu-sockets: move and rename SocketAddress_to_str()
>   qemu-sockets: update socket_uri() and socket_parse()  to be consistent
>   net: stream: move to QIO to enable additional parameters
>   tests/qtest: netdev: test stream and dgram backends
>   net: stream: add QAPI events to report connection state
> 
> Stefano Brivio (2):
>   net: socket: Don't ignore EINVAL on netdev socket connection
>   net: stream: Don't ignore EINVAL on netdev socket connection
> 
>  hmp-commands.hx             |   2 +-
>  hw/net/xen_nic.c            |   5 +-
>  include/net/net.h           |   7 +-
>  include/qemu/sockets.h      |   4 +-
>  meson                       |   2 +-
>  monitor/hmp-cmds.c          |  23 +-
>  net/clients.h               |   6 +
>  net/dgram.c                 | 622 ++++++++++++++++++++++++++++++++++++
>  net/hub.c                   |   2 +
>  net/l2tpv3.c                |   3 +-
>  net/meson.build             |   2 +
>  net/net.c                   | 186 ++++++++---
>  net/slirp.c                 |   5 +-
>  net/socket.c                |  36 +--
>  net/stream.c                | 389 ++++++++++++++++++++++
>  net/tap-win32.c             |   3 +-
>  net/tap.c                   |  13 +-
>  net/vde.c                   |   3 +-
>  net/vhost-user.c            |   3 +-
>  net/vhost-vdpa.c            |   2 +-
>  qapi/net.json               | 112 ++++++-
>  qemu-options.hx             |  14 +
>  softmmu/vl.c                |  16 +-
>  tests/qtest/meson.build     |   1 +
>  tests/qtest/netdev-socket.c | 417 ++++++++++++++++++++++++
>  util/qemu-sockets.c         |  25 ++
>  26 files changed, 1771 insertions(+), 132 deletions(-)
>  create mode 100644 net/dgram.c
>  create mode 100644 net/stream.c
>  create mode 100644 tests/qtest/netdev-socket.c
> 
> -- 
> 2.37.3
> 



From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:40:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:40:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430762.682819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmFs-0004Ok-UG; Wed, 26 Oct 2022 19:40:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430762.682819; Wed, 26 Oct 2022 19:40:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmFs-0004Ob-Qa; Wed, 26 Oct 2022 19:40:00 +0000
Received: by outflank-mailman (input) for mailman id 430762;
 Wed, 26 Oct 2022 19:40:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onmFs-0004OD-9L; Wed, 26 Oct 2022 19:40:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onmFs-0001yz-7d; Wed, 26 Oct 2022 19:40:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onmFr-0005RQ-Ui; Wed, 26 Oct 2022 19:40:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onmFr-00008Z-UA; Wed, 26 Oct 2022 19:39:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eTLKNAY2nd49Ua1qQG6uNUp5vLsP4j1+QGnwfajQt28=; b=y49imYsCYOcVu6Z5u6137AWZhN
	saCz5nNn3jyp3jl3dZzAs0LocmbkCp+0+hz2l6Oo7vw9XmN8y2ZWSqFV5bjCekC+8GD00J5KVNdeK
	ZN0IBLr95i0YO1UYH2mhYv3TPMMVe5+Mxml3o2ngSk492wd9V/VpUxcaRcf3vNG4KHv8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174434-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174434: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=454927368f5623b77d9ef20e28b82037d8a952e6
X-Osstest-Versions-That:
    libvirt=045072ee3ad0643254c8cb55bd47c878ddbee084
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 19:39:59 +0000

flight 174434 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174434/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174380
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174380
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174380
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              454927368f5623b77d9ef20e28b82037d8a952e6
baseline version:
 libvirt              045072ee3ad0643254c8cb55bd47c878ddbee084

Last test of basis   174380  2022-10-25 04:18:54 Z    1 days
Testing same since   174434  2022-10-26 04:23:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Erik Skultety <eskultet@redhat.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Jiri Denemark <jdenemar@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Pavel Hrdina <phrdina@redhat.com>
  Weblate <noreply@weblate.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   045072ee3a..454927368f  454927368f5623b77d9ef20e28b82037d8a952e6 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:47:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:47:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430771.682830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmMt-0006Jn-MI; Wed, 26 Oct 2022 19:47:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430771.682830; Wed, 26 Oct 2022 19:47:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmMt-0006Jg-J9; Wed, 26 Oct 2022 19:47:15 +0000
Received: by outflank-mailman (input) for mailman id 430771;
 Wed, 26 Oct 2022 19:47:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2/Fg=23=gmail.com=tamas.k.lengyel@srs-se1.protection.inumbo.net>)
 id 1onmMs-0006Ja-8r
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 19:47:14 +0000
Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com
 [2607:f8b0:4864:20::b2e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc2c635e-5566-11ed-91b5-6bf2151ebd3b;
 Wed, 26 Oct 2022 21:47:13 +0200 (CEST)
Received: by mail-yb1-xb2e.google.com with SMTP id o70so20355850yba.7
 for <xen-devel@lists.xenproject.org>; Wed, 26 Oct 2022 12:47:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc2c635e-5566-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=zteI1mSUj99/cE/1wEWV/kzRX00FnSv5Ujgd6O8BuH8=;
        b=k9gsSCdGL7Dv+x+5gfxA0A3xJv8jfPwexUdm6CPij1pGVY3msuk6YJ5dNpDlvNVaWz
         2dmTOtYjlJ61AoyoREbg2EiE8aqnIlJeoPaHhVG1vM0UWa53DrP5oEkCovHxQJqwQeDF
         jPqKLBJc0glFVF0Vg13wpPd4z6Dyw+aGZaVAhMrUiDJKopQL543i1ZRRicBYQ3egSKiD
         x24fHQvcvrG+b8QgrLXvQY4zL80F9bwNSbh9HAkrgISbxA3OnQB1/tBqueBOvy+vo+Xs
         fFz+5R9FNSH0VhPtaghWKEwpDItosPpxOeFUlI1JcuYq/8sP0hoDg2iSegFYkaFMr7NJ
         7p6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=zteI1mSUj99/cE/1wEWV/kzRX00FnSv5Ujgd6O8BuH8=;
        b=lCsiCIEDfu8UGzzKdSpuH/5yQPBVZNGTQRPfIU+i/g5/pTrRtWGV8Ad4a6LA/rFGnT
         p9cmmU0BZwDwUaSOhPYjm/yTWwGEhn7Gr6MZFwl4AAz7uKP4QgNabrS2KI5ELpMtKBZx
         aNJkbBWWwbavJooikWK4gzVBLOkKAMiVwQROOSaTHAhjwvDAnAOJrrHKolArQsveNaFE
         +3yhBpd7SqAEulOQiizqJ7h5sw7BtbwP2xNOzo8mL3ZDjI4DOl297Je0hA/f9UjZ624/
         XN4Tz6XZygH0XB72xMA7hFfJBKKutYMDPAb/CBYh77LizB+9aBYf4YcU5jYzUNAxo9NW
         OYZQ==
X-Gm-Message-State: ACrzQf1Za5BPHQYQfAAQUgElNGsg3l+viVpCRcv0hWHm+DvYGn0T7WnN
	/0/GshokZC1Ng5bcO0qVsXbHPqryqLQSjP47hhY=
X-Google-Smtp-Source: AMsMyM6ssoal9uC9vpRfcH7lKXJezgHbNHk2N+NKYqCpcVt1+DKkUWATrRNurjSK7ujICg5PXUv0MtdoRctkX+5+QlY=
X-Received: by 2002:a5b:845:0:b0:683:6ed7:b3b6 with SMTP id
 v5-20020a5b0845000000b006836ed7b3b6mr40653150ybq.183.1666813631872; Wed, 26
 Oct 2022 12:47:11 -0700 (PDT)
MIME-Version: 1.0
References: <854cdedcdd2bfff08ea45a3c13367c610d710aaf.1666630317.git.tamas.lengyel@intel.com>
 <0c7ca888-3142-1719-13c2-4f006ecdf683@citrix.com> <CABfawh=RXrPgj+MA-4QGogM0o3Oo4GEJ3ipbqHKE0TV4GHdCTg@mail.gmail.com>
 <f5673a0a-853e-fa2c-2f4c-e76b7b7aba87@suse.com> <CABfawhmjcv0mu4cqjTaOPxgrOuMQ5VyAA1OoNtOmr6g34a6Ezw@mail.gmail.com>
 <b4a7f3a4-1685-a14b-4800-2d1277a26a07@suse.com>
In-Reply-To: <b4a7f3a4-1685-a14b-4800-2d1277a26a07@suse.com>
From: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Date: Wed, 26 Oct 2022 15:46:35 -0400
Message-ID: <CABfawhnPxXVMXshALk7Ee+drhU0o8pD2rJ6g6uY85wQw35sWEA@mail.gmail.com>
Subject: Re: [PATCH] xen/x86: Make XEN_DOMCTL_get_vcpu_msrs more configurable
To: Jan Beulich <jbeulich@suse.com>
Cc: Tamas K Lengyel <tamas.lengyel@intel.com>, Xen-devel <xen-devel@lists.xenproject.org>, 
	Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, 
	Roger Pau Monne <roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, 
	Kevin Tian <kevin.tian@intel.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Content-Type: multipart/alternative; boundary="0000000000006f44e305ebf54a2c"

--0000000000006f44e305ebf54a2c
Content-Type: text/plain; charset="UTF-8"

On Wed, Oct 26, 2022 at 8:22 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 26.10.2022 13:58, Tamas K Lengyel wrote:
> > On Wed, Oct 26, 2022, 7:48 AM Jan Beulich <jbeulich@suse.com> wrote:
> >
> >> On 26.10.2022 13:34, Tamas K Lengyel wrote:
> >>> On Wed, Oct 26, 2022, 7:06 AM Andrew Cooper <Andrew.Cooper3@citrix.com
>
> >>> wrote:
> >>>
> >>>> On 24/10/2022 17:58, Tamas K Lengyel wrote:
> >>>>> Currently the XEN_DOMCTL_get_vcpu_msrs is only capable of gathering
a
> >>>> handful
> >>>>> of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs
by
> >> an
> >>>>> external privileged tool is necessary, thus we extend the domctl to
> >>>> allow for
> >>>>> querying for any guest MSRs. To remain compatible with the existing
> >>>> setup if
> >>>>> no specific MSR is requested via the domctl the default list is
> >> returned.
> >>>>>
> >>>>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> >>>>
> >>>> Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is supposed to be "get
me
> >>>> all MSRs needed to migrate a vCPU".  (I do intend to retire the
> >>>> hypercall as part of fixing the Xen side of migration, but that's
ages
> >>>> away)
> >>>>
> >>>> It seems like what you want is something more like
> >>>> XEN_DOMCTL_{rd,wr}msr_list  (convenient timing, given the recent ISE
> >>>> update).  I think those would be better as a separate pair of
> >>>> hypercalls, rather than trying to repurpose an existing hypercall.
> >>>>
> >>>>
> >>>> As for actually getting the values, please fix up guest_{rd,wr}msr()
to
> >>>> access the perf MSRs safely.  I know the vpmu MSR handling is in a
> >>>> tragic state, but this new get_msr subop is making the problem even
more
> >>>> tangled.
> >>>>
> >>>
> >>> Adding a separate hypercall is fine.
> >>
> >> Which will then also avoid altering the behavior of the existing
hypercall:
> >> You can't just assume e.g. input fields to be zeroed (or otherwise
> >> suitably set) by existing callers, when those were previously output
only.
> >>
> >
> > I did add a memset to zero it on the single caller I could find.
>
> Some may deem this sufficient on the assumption that all users should
> go through the libxenguest function. But then at the minimum you want
> to update documentation in the public header. Yet then this wasn't
> the only issue I spotted (hence the use of "e.g.") - you also alter
> documented behavior as to the returned number of MSRs when the input
> value was too small, if I'm not mistaken.

No, there shouldn't have been any alteration of the previous behavior other
than assuming the buffer sent by the toolstack is zero initialized when the
default list is requested. Either way, adding the separate hypercall is
fine by me.

Tamas

--0000000000006f44e305ebf54a2c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br>On Wed, Oct 26, 2022 at 8:22 AM Jan Beulich &lt;<a=
 href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; wrote:<br>&gt;=
<br>&gt; On 26.10.2022 13:58, Tamas K Lengyel wrote:<br>&gt; &gt; On Wed, O=
ct 26, 2022, 7:48 AM Jan Beulich &lt;<a href=3D"mailto:jbeulich@suse.com">j=
beulich@suse.com</a>&gt; wrote:<br>&gt; &gt;<br>&gt; &gt;&gt; On 26.10.2022=
 13:34, Tamas K Lengyel wrote:<br>&gt; &gt;&gt;&gt; On Wed, Oct 26, 2022, 7=
:06 AM Andrew Cooper &lt;<a href=3D"mailto:Andrew.Cooper3@citrix.com">Andre=
w.Cooper3@citrix.com</a>&gt;<br>&gt; &gt;&gt;&gt; wrote:<br>&gt; &gt;&gt;&g=
t;<br>&gt; &gt;&gt;&gt;&gt; On 24/10/2022 17:58, Tamas K Lengyel wrote:<br>=
&gt; &gt;&gt;&gt;&gt;&gt; Currently the XEN_DOMCTL_get_vcpu_msrs is only ca=
pable of gathering a<br>&gt; &gt;&gt;&gt;&gt; handful<br>&gt; &gt;&gt;&gt;&=
gt;&gt; of predetermined vcpu MSRs. In our use-case gathering the vPMU MSRs=
 by<br>&gt; &gt;&gt; an<br>&gt; &gt;&gt;&gt;&gt;&gt; external privileged to=
ol is necessary, thus we extend the domctl to<br>&gt; &gt;&gt;&gt;&gt; allo=
w for<br>&gt; &gt;&gt;&gt;&gt;&gt; querying for any guest MSRs. To remain c=
ompatible with the existing<br>&gt; &gt;&gt;&gt;&gt; setup if<br>&gt; &gt;&=
gt;&gt;&gt;&gt; no specific MSR is requested via the domctl the default lis=
t is<br>&gt; &gt;&gt; returned.<br>&gt; &gt;&gt;&gt;&gt;&gt;<br>&gt; &gt;&g=
t;&gt;&gt;&gt; Signed-off-by: Tamas K Lengyel &lt;<a href=3D"mailto:tamas.l=
engyel@intel.com">tamas.lengyel@intel.com</a>&gt;<br>&gt; &gt;&gt;&gt;&gt;<=
br>&gt; &gt;&gt;&gt;&gt; Naming aside, XEN_DOMCTL_{get,set}_vcpu_msrs is su=
pposed to be &quot;get me<br>&gt; &gt;&gt;&gt;&gt; all MSRs needed to migra=
te a vCPU&quot;. =C2=A0(I do intend to retire the<br>&gt; &gt;&gt;&gt;&gt; =
hypercall as part of fixing the Xen side of migration, but that&#39;s ages<=
br>&gt; &gt;&gt;&gt;&gt; away)<br>&gt; &gt;&gt;&gt;&gt;<br>&gt; &gt;&gt;&gt=
;&gt; It seems like what you want is something more like<br>&gt; &gt;&gt;&g=
t;&gt; XEN_DOMCTL_{rd,wr}msr_list =C2=A0(convenient timing, given the recen=
t ISE<br>&gt; &gt;&gt;&gt;&gt; update).=C2=A0 I think those would be better=
 as a separate pair of<br>&gt; &gt;&gt;&gt;&gt; hypercalls, rather than try=
ing to repurpose an existing hypercall.<br>&gt; &gt;&gt;&gt;&gt;<br>&gt; &g=
t;&gt;&gt;&gt;<br>&gt; &gt;&gt;&gt;&gt; As for actually getting the values,=
 please fix up guest_{rd,wr}msr() to<br>&gt; &gt;&gt;&gt;&gt; access the pe=
rf MSRs safely.=C2=A0 I know the vpmu MSR handling is in a<br>&gt; &gt;&gt;=
&gt;&gt; tragic state, but this new get_msr subop is making the problem eve=
n more<br>&gt; &gt;&gt;&gt;&gt; tangled.<br>&gt; &gt;&gt;&gt;&gt;<br>&gt; &=
gt;&gt;&gt;<br>&gt; &gt;&gt;&gt; Adding a separate hypercall is fine.<br>&g=
t; &gt;&gt;<br>&gt; &gt;&gt; Which will then also avoid altering the behavi=
or of the existing hypercall:<br>&gt; &gt;&gt; You can&#39;t just assume e.=
g. input fields to be zeroed (or otherwise<br>&gt; &gt;&gt; suitably set) b=
y existing callers, when those were previously output only.<br>&gt; &gt;&gt=
;<br>&gt; &gt;<br>&gt; &gt; I did add a memset to zero it on the single cal=
ler I could find.<br>&gt;<br>&gt; Some may deem this sufficient on the assu=
mption that all users should<br>&gt; go through the libxenguest function. B=
ut then at the minimum you want<br>&gt; to update documentation in the publ=
ic header. Yet then this wasn&#39;t<br>&gt; the only issue I spotted (hence=
 the use of &quot;e.g.&quot;) - you also alter<br>&gt; documented behavior =
as to the returned number of MSRs when the input<br>&gt; value was too smal=
l, if I&#39;m not mistaken.<br><div><br></div><div>No, there shouldn&#39;t =
have been any alteration of the previous behavior other than assuming the b=
uffer sent by the toolstack is zero initialized when the default list is re=
quested. Either way, adding the separate hypercall is fine by me.</div><div=
><br></div><div>Tamas<br></div></div>

--0000000000006f44e305ebf54a2c--


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 19:49:00 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 19:49:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430776.682840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmOY-0006wJ-5X; Wed, 26 Oct 2022 19:48:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430776.682840; Wed, 26 Oct 2022 19:48:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmOY-0006wC-2m; Wed, 26 Oct 2022 19:48:58 +0000
Received: by outflank-mailman (input) for mailman id 430776;
 Wed, 26 Oct 2022 19:48:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onmOX-0006w4-6Z
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 19:48:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onmOV-000294-L6; Wed, 26 Oct 2022 19:48:55 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onmOV-0001st-FJ; Wed, 26 Oct 2022 19:48:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=EfraIYUHNiit4dxFrnJ/h0saWNF3hEuMzVJIWeO/o5c=; b=5iJhi2tKYvPv0wZx+BOPII813p
	u3D5dysuyo5T4rC/cm5TtQAqaIdTSbs37pkO170n30kjo6K4Y1Ve08TsLVTEW7jj43cByXoQR+rZg
	9qlz1AhYV2wF9Xrjby9h8Z/QpkcuSoPZACRRGrImlJ5AQL3gdMVZp34hkQ4zEo18cuV0=;
Message-ID: <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
Date: Wed, 26 Oct 2022 20:48:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
From: Julien Grall <julien@xen.org>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
In-Reply-To: <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 26/10/2022 15:33, Rahul Singh wrote:
> Hi Julien,

Hi Rahul,

>> On 26 Oct 2022, at 2:36 pm, Julien Grall <julien@xen.org> wrote:
>>
>>
>>
>> On 26/10/2022 14:17, Rahul Singh wrote:
>>> Hi All,
>>
>> Hi Rahul,
>>
>>> At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3.
>>> To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the
>>> device to the guest that is behind an IOMMU and virtual IOMMU is enabled for the guest there is a need to
>>> add IOMMU binding for the device in the passthrough node as per [1]. This email is to get an agreement on
>>> how to add the IOMMU binding for guest OS.
>>> Before I will explain how to add the IOMMU binding let me give a brief overview of how we will add support for virtual
>>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 Nested translation support. SMMUv3 hardware
>>> supports two stages of translation. Each stage of translation can be independently enabled. An incoming address is logically
>>> translated from VA to IPA in stage 1, then the IPA is input to stage 2 which translates the IPA to the output PA. Stage 1 is
>>> intended to be used by a software entity( Guest OS) to provide isolation or translation to buffers within the entity, for example,
>>> DMA isolation within an OS. Stage 2 is intended to be available in systems supporting the Virtualization Extensions and is
>>> intended to virtualize device DMA to guest VM address spaces. When both stage 1 and stage 2 are enabled, the translation
>>> configuration is called nesting.
>>> Stage 1 translation support is required to provide isolation between different devices within the guest OS. XEN already supports
>>> Stage 2 translation but there is no support for Stage 1 translation for guests. We will add support for guests to configure
>>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU hardware and exposes the virtual SMMU to the guest.
>>> Guest can use the native SMMU driver to configure the stage 1 translation. When the guest configures the SMMU for Stage 1,
>>> XEN will trap the access and configure the hardware accordingly.
>>> Now back to the question of how we can add the IOMMU binding between the virtual IOMMU and the master devices so that
>>> guests can configure the IOMMU correctly. The solution that I am suggesting is as below:
>>> For dom0, while handling the DT node(handle_node()) Xen will replace the phandle in the "iommus" property with the virtual
>>> IOMMU node phandle.
>> Below, you said that each IOMMUs may have a different ID space. So shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the user to specify the mapping?
> 
> Yes you are right we need to create one vIOMMU per pIOMMU for dom0. This also helps in the ACPI case
> where we don’t need to modify the tables to delete the pIOMMU entries and create one vIOMMU.
> In this case, no need to replace the phandle as Xen create the vIOMMU with the same pIOMMU
> phandle and same base address.
> 
> For domU guests one vIOMMU per guest will be created.

IIRC, the SMMUv3 is using a ring like the GICv3 ITS. I think we need to 
be open here because this may end up to be tricky to security support it 
(we have N guest ring that can write to M host ring).

> 
>>
>>> For domU guests, when passthrough the device to the guest as per [2],  add the below property in the partial device tree
>>> node that is required to describe the generic device tree binding for IOMMUs and their master(s)
>>> "iommus = < &magic_phandle 0xvMasterID>
>>> 	• magic_phandle will be the phandle ( vIOMMU phandle in xl)  that will be documented so that the user can set that in partial DT node (0xfdea).
>>
>> Does this mean only one IOMMU will be supported in the guest?
> 
> Yes.
> 
>>
>>> 	• vMasterID will be the virtual master ID that the user will provide.
>>> The partial device tree will look like this:
>>> /dts-v1/;
>>>   / {
>>>      /* #*cells are here to keep DTC happy */
>>>      #address-cells = <2>;
>>>      #size-cells = <2>;
>>>        aliases {
>>>          net = &mac0;
>>>      };
>>>        passthrough {
>>>          compatible = "simple-bus";
>>>          ranges;
>>>          #address-cells = <2>;
>>>          #size-cells = <2>;
>>>          mac0: ethernet@10000000 {
>>>              compatible = "calxeda,hb-xgmac";
>>>              reg = <0 0x10000000 0 0x1000>;
>>>              interrupts = <0 80 4  0 81 4  0 82 4>;
>>>             iommus = <0xfdea 0x01>;
>>>          };
>>>      };
>>> };
>>>   In xl.cfg we need to define a new option to inform Xen about vMasterId to pMasterId mapping and to which IOMMU device this
>>> the master device is connected so that Xen can configure the right IOMMU. This is required if the system has devices that have
>>> the same master ID but behind a different IOMMU.
>>
>> In xl.cfg, we already pass the device-tree node path to passthrough. So Xen should already have all the information about the IOMMU and Master-ID. So it doesn't seem necessary for Device-Tree.
>>
>> For ACPI, I would have expected the information to be found in the IOREQ.
>>
>> So can you add more context why this is necessary for everyone?
> 
> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.

I am confused. Below, you are making the virtual master ID optional. So 
shouldn't this be mandatory if you really need the mapping with the 
virtual ID?

> The device tree node will be used to assign the device to the guest and configure the Stage-2 translation. Guest will use the
> vMaster-ID to configure the vIOMMU during boot. Xen needs information to link vMaster-ID to pMaster-ID to configure
> the corresponding pIOMMU. As I mention we need vMaster-ID in case a system could have 2 identical Master-ID but
> each one connected to a different SMMU and assigned to the guest.

I am afraid I still don't understand why this is a requirement. Libxl 
could have enough knowledge (which will be necessarry for the PCI case) 
to know the IOMMU and pMasterID associated with a device.

So libxl could allocate the vMasterID, tell Xen the corresponding 
mapping and update the device-tree.

IOW, it doesn't seem to be necessary to involve the user in the process 
here.

> 
>>
>>>   iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
>>> 	• PMASTER_ID is the physical master ID of the device from the physical DT.
>>> 	• VMASTER_ID is the virtual master Id that the user will configure in the partial device tree.
>>> 	• IOMMU_BASE_ADDRESS is the base address of the physical IOMMU device to which this device is connected.
>>
>> Below you give an example for Platform device. How would that fit in the context of PCI passthrough?
> 
> In PCI passthrough case, xl will create the "iommu-map" property in vpci host bridge node with phandle to vIOMMU node.
> vSMMUv3 node will be created in xl.

This means that libxl will need to know the associated pMasterID to a 
PCI device. So, I don't understand why you can't do the same for 
platform devices.

> 
>>
>>>   Example: Let's say the user wants to assign the below physical device in DT to the guest.
>>>   iommu@4f000000 {
>>>                  compatible = "arm,smmu-v3";
>>>               	interrupts = <0x00 0xe4 0xf04>;
>>>                  interrupt-parent = <0x01>;
>>>                  #iommu-cells = <0x01>;
>>>                  interrupt-names = "combined";
>>>                  reg = <0x00 0x4f000000 0x00 0x40000>;
>>>                  phandle = <0xfdeb>;
>>>                  name = "iommu";
>>> };
>>
>> So I guess this node will be written by Xen. How will you the case where there are extra property to added (e.g. dma-coherent)?
> 
> In this example this is physical IOMMU node. vIOMMU node wil be created by xl during guest creation.

Ok. I think it would be better to use very different phandle in your 
example so it doesn't look like a mistake.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 20:27:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 20:27:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430785.682865 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmzj-0003aA-9c; Wed, 26 Oct 2022 20:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430785.682865; Wed, 26 Oct 2022 20:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onmzj-0003a3-4W; Wed, 26 Oct 2022 20:27:23 +0000
Received: by outflank-mailman (input) for mailman id 430785;
 Wed, 26 Oct 2022 20:27:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onmzh-0003Zt-I6; Wed, 26 Oct 2022 20:27:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onmzh-0002td-6o; Wed, 26 Oct 2022 20:27:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onmzg-0000FV-Os; Wed, 26 Oct 2022 20:27:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onmzg-00007b-OR; Wed, 26 Oct 2022 20:27:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FuTDurkkAqFcGHcEApcwt1catn/c5hum/N0ahaDIlps=; b=d9qXH7Co5z6AOVwRu5v7pQzMeE
	AQcPAy8J5oTR6sgIK9NWSZNNNBvjI6s1GQZy1CtlrlTNF1fC3pBEDjcFeD9Y6GmLxTyZHyfsNS1kW
	VbryPsoicQXWGDfVgEeAlcO4V9TTPJegjiNf8Nq4cYARPUbG6JM/OIhKrbVaxgRRkmg4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174411-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174411: regressions - FAIL
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-seattle:guest-start:fail:regression
    xen-4.13-testing:test-arm64-arm64-xl-xsm:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit1:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-credit2:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl:guest-start:fail:regression
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:debian-di-install:fail:regression
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:guest-start:fail:regression
    xen-4.13-testing:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug
    xen-4.13-testing:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0be63c2615b268001f7cc9b72ce25eed952737dc
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 20:27:20 +0000

flight 174411 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174411/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-seattle  14 guest-start              fail REGR. vs. 172549
 test-arm64-arm64-xl-xsm      14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit1  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-credit2  14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 172549
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 172549
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 172549
 test-armhf-armhf-libvirt-raw 12 debian-di-install        fail REGR. vs. 172549
 test-armhf-armhf-xl-cubietruck 14 guest-start            fail REGR. vs. 172549

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot    fail in 173935 pass in 174411
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 173735
 test-arm64-arm64-libvirt-raw 12 debian-di-install          fail pass in 173735
 test-arm64-arm64-xl          14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-credit2  14 guest-start                fail pass in 173935
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 173935

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 173735 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 173735 never pass
 test-arm64-arm64-xl         15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl     16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 173935 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 173935 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 xen                  0be63c2615b268001f7cc9b72ce25eed952737dc
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   72 days
Failing since        173495  2022-10-11 14:08:01 Z   15 days   15 attempts
Testing same since   173657  2022-10-13 01:09:08 Z   13 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 450 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 21:25:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 21:25:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430797.682881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onntT-00029i-S6; Wed, 26 Oct 2022 21:24:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430797.682881; Wed, 26 Oct 2022 21:24:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onntT-00029b-OW; Wed, 26 Oct 2022 21:24:59 +0000
Received: by outflank-mailman (input) for mailman id 430797;
 Wed, 26 Oct 2022 21:24:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onntT-00029V-BW
 for xen-devel@lists.xenproject.org; Wed, 26 Oct 2022 21:24:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onntN-0003ni-JI; Wed, 26 Oct 2022 21:24:53 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onntN-0006Lc-Cy; Wed, 26 Oct 2022 21:24:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=sItJ5+hYj8CzCBe0BFkqN9pUL8NsekrPRIDvPd/T7qs=; b=2bMXgGrlSXKG8AOvmaZdFdozGv
	VYmKjmulPo8gzq4jA0IV93H5orfLLRnrbpGl2W31VFPWSwpzTLVcI7Ka5spJCZpVWNELgJcDKtuA5
	cvSbBl9tV9eHeyt8CN6n8tUhTLn3Inlsaok0mOFXnqt4QdaADzatS44UJpJFVdhfKpF4=;
Message-ID: <4c713750-670b-eac1-5f5b-376de79192eb@xen.org>
Date: Wed, 26 Oct 2022 22:24:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.3
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang
 <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
From: Julien Grall <julien@xen.org>
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
In-Reply-To: <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 26/10/2022 20:22, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/mm/hap/hap.c
>>> +++ b/xen/arch/x86/mm/hap/hap.c
>>> @@ -345,6 +345,16 @@ unsigned int hap_get_allocation(struct domain *d)
>>>               + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0));
>>>   }
>>>   
>>> +int hap_get_allocation_bytes(struct domain *d, uint64_t *size)
>>> +{
>>> +    unsigned long pages = (d->arch.paging.hap.total_pages +
>>> +                           d->arch.paging.hap.p2m_pages);
>> Unlike for Arm no ACCESS_ONCE() here? Also the addition can in
>> principle overflow, because being done only in 32 bits.
> 
> I'm not actually convinced ARM needs ACCESS_ONCE() to begin with.  I
> can't see any legal transformation of that logic which could result in a
> torn load.

AFAIU, ACCESS_ONCE() is not only about torn load but also making sure 
that the compiler will only read the value once.

When LTO is enabled (not yet supported) in Xen, can we guarantee the 
compiler will not try to access total_pages twice (obviously it would be 
caller dependent)?

With that in mind, when LTO is enabled on Linux arm64, the 
implementation of READ_ONCE() is not a simple (volatile *) to prevent 
the compiler to do harmful convertion. Possibly something we will need 
to consider in Xen in the future if we enable LTO. In this context, the 
ACCESS_ONCE() would make sense because we don't know (or should not 
assume) how the caller will use it.

Regardless that, I think using ACCESS_ONCE() help to document how the 
variable should be used. This will reduce the risk that someone decides 
to add a new use total_pages like below:

val = d->arch.paging.total_pages;

if ( val == 0 )
   return ...

/* use val */

AFAIU, a compiler would be allow to read total_pages twice here. Which 
is not what we would want. I am ready to bet this will be missed.

So consistency here is IMO much better. An alternative would be to 
document why we think the compiler would not be naughty.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 22:40:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 22:40:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430802.682895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onp3o-0002Jr-9X; Wed, 26 Oct 2022 22:39:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430802.682895; Wed, 26 Oct 2022 22:39:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onp3o-0002Jk-6k; Wed, 26 Oct 2022 22:39:44 +0000
Received: by outflank-mailman (input) for mailman id 430802;
 Wed, 26 Oct 2022 22:39:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onp3m-0002Ja-PM; Wed, 26 Oct 2022 22:39:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onp3m-00050e-Mj; Wed, 26 Oct 2022 22:39:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onp3m-00075r-By; Wed, 26 Oct 2022 22:39:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onp3m-0002IG-BT; Wed, 26 Oct 2022 22:39:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YHpg7lZ1gFWbcBndMhrgIfclQadDw6pLLbAtC5int5k=; b=0iSbpN3x4Ip9H8wsAJCMOldfRC
	XddqZTuv7zJtlCpZwEmlOACLYMS1VSCy0GOIkYEN44yYNKmrVbBOG0LzNoJm27uQb15y6KEGYjUJU
	ozwhGSiQ3XeEppbQGetPUtous0mz+9sDSAi8PeeRX4uFpfdJ/6EZOPxJ3aQfvbMn9B4s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174468-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174468: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b6efc505e4d6eb2055a39afd0a1ee67846a1e5f9
X-Osstest-Versions-That:
    ovmf=9e2c88b16ed3444ea9dfffb39a91d6c17071835d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 22:39:42 +0000

flight 174468 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174468/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b6efc505e4d6eb2055a39afd0a1ee67846a1e5f9
baseline version:
 ovmf                 9e2c88b16ed3444ea9dfffb39a91d6c17071835d

Last test of basis   174432  2022-10-26 04:14:08 Z    0 days
Testing same since   174468  2022-10-26 17:40:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   9e2c88b16e..b6efc505e4  b6efc505e4d6eb2055a39afd0a1ee67846a1e5f9 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Oct 26 22:53:02 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 26 Oct 2022 22:53:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430810.682912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onpGa-0004q8-HE; Wed, 26 Oct 2022 22:52:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430810.682912; Wed, 26 Oct 2022 22:52:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onpGa-0004q1-EM; Wed, 26 Oct 2022 22:52:56 +0000
Received: by outflank-mailman (input) for mailman id 430810;
 Wed, 26 Oct 2022 22:52:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onpGY-0004pq-P6; Wed, 26 Oct 2022 22:52:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onpGY-0005EG-OD; Wed, 26 Oct 2022 22:52:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onpGY-00088e-Cy; Wed, 26 Oct 2022 22:52:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onpGY-00087l-CZ; Wed, 26 Oct 2022 22:52:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Yl35vrCzXX4ob2LulVAqJylebQVur8ZbLtpCgBhhtAQ=; b=hrOuL3aKzqBXJ378dgJxQQz1ar
	e3L6L1cZZOPPqePqiUDyMhlOJyGoY5J5jhCZ70VbsJh/Qylsv+GV6nXxZmSKq06yVwnn0sIHBl3Xw
	9Rl2aD2YyfknDMCYoGspTm6y2jt8PMU41Uw74XFzKcDJR5eU0o7HW0mzhcPuxWxKttJk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174474-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174474: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bad4832710c7261fad1abe2d0e8e2e1d259b3e8d
X-Osstest-Versions-That:
    xen=26bf76b48bbce3e7b126290374c64966dca47561
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 26 Oct 2022 22:52:54 +0000

flight 174474 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174474/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  bad4832710c7261fad1abe2d0e8e2e1d259b3e8d
baseline version:
 xen                  26bf76b48bbce3e7b126290374c64966dca47561

Last test of basis   174455  2022-10-26 13:01:57 Z    0 days
Testing same since   174474  2022-10-26 20:00:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   26bf76b48b..bad4832710  bad4832710c7261fad1abe2d0e8e2e1d259b3e8d -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 03:34:49 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 03:34:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430847.683017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ontfA-00021J-7j; Thu, 27 Oct 2022 03:34:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430847.683017; Thu, 27 Oct 2022 03:34:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ontfA-000219-1c; Thu, 27 Oct 2022 03:34:36 +0000
Received: by outflank-mailman (input) for mailman id 430847;
 Thu, 27 Oct 2022 03:34:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ontf8-00020k-OS; Thu, 27 Oct 2022 03:34:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ontf8-0000jx-Lp; Thu, 27 Oct 2022 03:34:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ontf8-0001hH-4l; Thu, 27 Oct 2022 03:34:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ontf8-00011U-4G; Thu, 27 Oct 2022 03:34:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dYp9qVVX4Z0Fr9CZttdZx+ii6BzvX0lt16IWvBI+vWw=; b=YX3GK6r36+fRHNf3vkihIO5Qgg
	C2Nv/42kNSny+aSAfBcit/DiUKuHB8pnlLyxnWRMf9g//PaO+D7BDjbicxMf+zSjhDPPW7Z7vRMGS
	urAL53T8gIcx7GxBY0+2nre2Rhc4oSdhjyTGU11E8XRIbouQe5T0uMdxuTkcdweNO5+k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174415-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 174415: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f8915cd5dbe0f51e9bb31a54fe40600b839dd707
X-Osstest-Versions-That:
    xen=9acedc3c58c31930737edbe212f2ccf437a0b757
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 03:34:34 +0000

flight 174415 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174415/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 172547
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172547
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 172547
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 172547
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172547
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172547
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172547
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  f8915cd5dbe0f51e9bb31a54fe40600b839dd707
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   72 days
Failing since        173494  2022-10-11 13:38:08 Z   15 days   17 attempts
Testing same since   174415  2022-10-25 20:13:09 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9acedc3c58..f8915cd5db  f8915cd5dbe0f51e9bb31a54fe40600b839dd707 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 03:47:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 03:47:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430875.683104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ontrT-0004s3-8s; Thu, 27 Oct 2022 03:47:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430875.683104; Thu, 27 Oct 2022 03:47:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ontrT-0004rw-5r; Thu, 27 Oct 2022 03:47:19 +0000
Received: by outflank-mailman (input) for mailman id 430875;
 Thu, 27 Oct 2022 03:47:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ontrS-0004rm-OF; Thu, 27 Oct 2022 03:47:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ontrS-00010H-JT; Thu, 27 Oct 2022 03:47:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ontrS-00028W-CQ; Thu, 27 Oct 2022 03:47:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ontrS-0006CK-C2; Thu, 27 Oct 2022 03:47:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=etJ2X4d/EYDEJc3fFO2X7fD9j6auwFV1FkTWv+hAK3w=; b=h0QKqaVvL/EsXoWS7eeYPSLA1R
	A6HOyBIN3/TUVivWKq3YLFwPRIOPP6Z9ODJloyNMzULY8oV2GiUwtdu46g8ruUOPCH3BeRZs8mEf8
	dc6O6Bdks7s8K6XFX/BiZAQHthgJ2TC86amzHixrjJq8dxrdgjh+8OXdVZ1D0JKNDkfc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174478-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174478: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=115cebbe4d7541c795b4f9baefc38f9a1733b7f6
X-Osstest-Versions-That:
    ovmf=b6efc505e4d6eb2055a39afd0a1ee67846a1e5f9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 03:47:18 +0000

flight 174478 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174478/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 115cebbe4d7541c795b4f9baefc38f9a1733b7f6
baseline version:
 ovmf                 b6efc505e4d6eb2055a39afd0a1ee67846a1e5f9

Last test of basis   174468  2022-10-26 17:40:30 Z    0 days
Testing same since   174478  2022-10-26 22:43:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b6efc505e4..115cebbe4d  115cebbe4d7541c795b4f9baefc38f9a1733b7f6 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 06:36:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 06:36:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430890.683142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onwUX-0007ik-8H; Thu, 27 Oct 2022 06:35:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430890.683142; Thu, 27 Oct 2022 06:35:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onwUX-0007id-5P; Thu, 27 Oct 2022 06:35:49 +0000
Received: by outflank-mailman (input) for mailman id 430890;
 Thu, 27 Oct 2022 06:35:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onwUV-0007iX-O7
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 06:35:48 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9598d4be-55c1-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 08:35:44 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB9061.eurprd04.prod.outlook.com (2603:10a6:20b:444::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 06:35:42 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 06:35:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9598d4be-55c1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eWAMJ3VgCbgSmDwcsuReobEZVHQ5xIXdWAwVhEA6Yy6V1sU5RpGQDwBlbUA84w+jIyrpYdy16m4v4x8WjsSEtFteSwdZt5SzmKKm9w2uxi1PaJdUpjKoINCviJFGKP6eqP7q3jKP7ruzwdD8Lq6XuJitgb3jKyvq8ctQW42lLWCr0/y79l1Twl1/nScwIfbAkiQch3e1513KQARiDL9NWPNcnCe7HLfWcpl4tu+J+Ytj55EcN/zjp1NMJz+DqYee/sQbJs/yODMNhgNi50EDlkz9TMgi27VEwTt33fQropRrbbDMQEMrslBEra1Imzac2mKTf6HtD34BhJ1j/6LkCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Co1ILXLOErZgoj60Ktgf30vDbgp6ceXC7gQe8CJC1c4=;
 b=CbNabWe/zyO4KyIZzV80Fp8Bv0bFkROt0/KBvYypMIQn4JfVyVWa6biiCBqkhOG91HHhjlyHR07PLkEH6MpdPwQcF7zhJEtNBdngVwcGTBqo8R8ihKCVmWS7VdwdbaT2chKu3NnWbEUBeXNI84M3KI3evAAE/D4CXwU+qk6Ew0nwDAFAjKZmtCX44ronrzcIOUvcmKaOEJoEdb7fPPjydwXFJDEkPKvp9xZaGnLrLW1wKlp/xIsW81dBMp/aqCidjnLFlioKUnISv1cxet1L9H1CLj6hQoLaWmuqhdw+dzpG+3A09s2ZiAP1BHfP+0oFBVtCLusZ/uwK6SsHrGZBpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Co1ILXLOErZgoj60Ktgf30vDbgp6ceXC7gQe8CJC1c4=;
 b=RsTe1DitORih++ekjQ27m0EBbb/AfF2gA0wwOsrCsnzuu94b1w72rMv7ZoA1cuCIbct/TZBaL39GIj25NJ3ug8NcNhPG8ySLCwAjnSLkL4Q4Knw2CzAFLJnbdEqXYbJ/CLPYata0Rng70ffysVNHzUlvr02WmrADaQWoHDlmK+9WupjNBWCRbMDnFnTa5mN2fKxP6ZuP61XV1DOJoOO0LeVK1TKdTcT3VB0RhHQyvy7P2jDIt0OdNZO1Z8tgWw+IkQ8T9ha4sC2g4TOxI6FhwDb3Hno9gxky8YdX0Gm3sJy6IZpu8tC5PxuLJbZOuKv+ZVdtrOhxLiFwOzTP5p4s/Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6afcce03-a9f4-cf06-48ea-777357ea080d@suse.com>
Date: Thu, 27 Oct 2022 08:35:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v2 5/5] vpci: refuse BAR writes only if the BAR
 is mapped
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-6-roger.pau@citrix.com>
 <666377e8-fe58-bc9f-70ff-2e21d93c691f@suse.com>
 <Y1k88uhbSNdMvsa+@Air-de-Roger>
 <045428b7-9c4d-cbf6-3ca9-157c516399a9@suse.com>
 <Y1lZxldTIWawfpnO@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Y1lZxldTIWawfpnO@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0124.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:97::13) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9061:EE_
X-MS-Office365-Filtering-Correlation-Id: d17d4f2f-21a3-4386-a07d-08dab7e578ad
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Uv9jSBLVtSxXYd1QHI13m3qSYeP3R4dXl6KAUBWkA1nTF0iTjUuK/JGz6WJKs5K3mQU6X5K0xJnes8isFOCHVvGj2IVUKbC6MXI2e5o5QPrCwi1b42HxfoAeIf33TaX86BafsrzNC3rxHwl7vrw8FcYqt/WxMBidDYfOA55QaYgv65iZzQhXSl3MSz8Kg1S5deCOhyeWLbFdpMuSMittIZb0vlfB5rqLy9ASl/eGASq3Ydsa8XkFVRsZh9uIYqFGEikHm7+GzB61urHkCuBy7NK4V3hTaah1K4262jvXIvkgiATfdK3pEuN3cbdyreVGHXxux9H2wk8FjxiOVMtDV8iXx4KDtZZLrdpgSjKnY+x2W+OIYVyHthLItj8IreTEDXf7Jpax6+oO30qUaM+sNn66LOg+bYVHnws1piZIQ6zGjs98rD8ID0uJ9o8zUJe/VqXpUm9aTaVxwFKa8i+sP+0K4ctk5Q81VjkThVT9iuKPU3GHxGyrgG+ehMKunkWT5fiZyROGAtElguCqx1IQabhvZcDjYEBPgDp1qn3P0YRKdTsxJANJCKoRz2iNpvx/HiTbhATkdUJ6ydXHyYWTXQ3A1qz6g/wHyGaJVsBrCI5FLnj1lvwB/70vqjNXt1RJOzD6GRtAC+MLPDDDcTkF569iNOrhWHWSiP3vxPQKfKc5Dv4t8Tx4kNqOIWbmtdbaifm763GEB0VlPoWAvPOQmE536GmU1OOHnDDGxvhf137eBeHP6GUSVS9KbD3RP4Fvxzzu1HPT49NdyOBLLm4ouyEAYMXhzs7p/E4RN5oSzhQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(346002)(376002)(366004)(136003)(451199015)(31686004)(6486002)(478600001)(6916009)(8936002)(31696002)(83380400001)(86362001)(38100700002)(316002)(66946007)(4326008)(41300700001)(8676002)(66476007)(66556008)(2906002)(186003)(2616005)(6512007)(26005)(5660300002)(53546011)(36756003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aDdnY0Z2cmMyekpBSGxKNTN2R3JiYnAreW5McEZWdURnRks2NmU5ODJueVQ5?=
 =?utf-8?B?Q3VuMytmN0o5VzQ4Z1U5elAxb3B6M25jaGlzbHRCTUtyTUNUS0NhM1hRSVV5?=
 =?utf-8?B?eER5UjBCZm9JbXdmZTZXcUJvU094NVRFakZ2WXNEeXdLMmxmYzJCbngxeG5h?=
 =?utf-8?B?ZExVY1YrTTAvcS9kOTl3cFU1dzRtTU1PQlY1UTVMa2FwQWJkZ0FrOEV4M2RT?=
 =?utf-8?B?VndFMHYvbjFMWUpxblFWbHZsclloOHZDLzh0LzVDVjBxQTR3L2hSOS9mcDhZ?=
 =?utf-8?B?endoTUsrOVFrK1hlSmp5UXlQeXlQd1hyZ0ZOVWlJaTY5Uy9Mb016dlplUmNU?=
 =?utf-8?B?RVFoY0xZUDFTRWNhSHVKbGVPdHByaWY3a1BqQjJWMThtVUpaN3dSRmNrMU1W?=
 =?utf-8?B?MWRrN3ZYTjNBMVBzZWUzdUFiT2p3SFAxSVdhdFNObllhVkpyN05tV2JpZmJz?=
 =?utf-8?B?NSs4dTdHaXVoem1LcWlvQTVLYlpCWTZRcHhxZFNkOUFUSXgza3lQblNtUFYy?=
 =?utf-8?B?bzNGZTUzejUvOXMxc2tkYkNLTXpxa0ZWNjdrN1BqTjl3OExMSXhwTGYwLzB0?=
 =?utf-8?B?cmUrWWl2ZWw3TE0wdzVjOEZLbEpsRTBhdTl6WTFBeHN2Y1RBTnFjcmxaMkpF?=
 =?utf-8?B?dS9jT0RVb0pvWEFCZTNWbGlNSzZkUkpMWTZCS20yMnEyRCtSUk1aNEVsZkRS?=
 =?utf-8?B?MWVhejR0RVRqa0ZBR21iVDByelk3OEtKQzM2V1B4bnFHWXA1M05EamJubEVC?=
 =?utf-8?B?TWVPakJjM0FmcXltZDEweHZ2bzJxWkI4MU42SnJ1THNYckNhSzN5Z1dtZkpi?=
 =?utf-8?B?c3dMaE1XOTRIeEx2Z0VsaFlxcEJoNDhpNit0di95R0tzMVlFSWluWG8rRmQy?=
 =?utf-8?B?bjlIVFpQWVBzT1dmZzU1cEpjTUhrY2VpUkdZcjJqaDBFcWNsRWNhbXhwMk9h?=
 =?utf-8?B?NlpvQkhnaUhKbmhVRFUrdERhelFaeEd0YytyakwxU1JScXpEZlB2TW5QK01B?=
 =?utf-8?B?cFQ3dTh5blhyaTRleWR2R2RlSmtZWjdOdHFpc01Pd1Q3cVZneVg3V0JyOHJG?=
 =?utf-8?B?cnorbmNOOTNtVm9ScjRUNXFzUGFEVlNiMEFyZzJQS2M2cmtXYml6WjdJS1hX?=
 =?utf-8?B?WVpFbjRVTS9LTjlraFlqRnArSzhFVmREd1U1TlpFa2lOaTE4UG5BZ1RlQ2ZK?=
 =?utf-8?B?VUx3UDFQSElLOGU5Vko2TUU3RFluem50Y1A0N09veFUyVEhpa2hZWmtVdVJm?=
 =?utf-8?B?U0RCVWNNVkpkbkhvT2NIcWkzSzZQY0V5SU5Pc0NES3I0cXQxc0F1R0Rzb2V1?=
 =?utf-8?B?bDJ3bzl0aGc5Q2FIZGc1bjJjOXAzbFpQRnZ3YTdjSHpTNzNjMXc5RS9sdElR?=
 =?utf-8?B?UWNld3FEaTJQZ05yK1o2SlhDMHk3dWJ3N3dFUnlmR01uN3RhcVFwZjJjRjV6?=
 =?utf-8?B?UGRCN2dDOE5raGJGUC9rY3dWWVdFSG4wM3hqbzI5VVRXdndtNTM5bkQ1Wjlh?=
 =?utf-8?B?bEZVVWFuTGxSeG96K3I0TVgvWklHVjZqOHA2RHJIMGIyOEorVGdNb3p3Umgr?=
 =?utf-8?B?VExpUTRvV09LYTZUeGNqN0E0dkd0enMxNGxKellvWDFPNkJDaElKTC9PeFk0?=
 =?utf-8?B?TnFIbVBJMXU5aW0zWlNtaVgwQW9pTDZBdnFhR2ZvdWRCVGlxTUVWaW5kOUtq?=
 =?utf-8?B?UUNWeXZYU0RaK2xjSWR2elRQSXNxOTNEZ0JGN3cyZHRRTzdUYTFveW16Y050?=
 =?utf-8?B?MTVCYU16YXlFZXlCU1RDOE1EV1p1RXZMRjhjQzRZUGlta1B6MlMxTTZSSEds?=
 =?utf-8?B?cFZ1SmpBb0JKYk1yR1lyc2RmWmM4Mi9HM0NWemt6M2t0eDBKQWlnR2dKSHFo?=
 =?utf-8?B?NGtlMTlQODZlRTQ0ZG96SlplVk1UdXhoZFozM0plSXR0anZ2c3Z0VmFTQ3NS?=
 =?utf-8?B?MHdhMHB1cWU4UlZjQlFOL2lWc2VCUFlJZ3FrN0VGWDEvZEQxb0xRMVdjRVJ2?=
 =?utf-8?B?c1dtSVByclVWbUNSSlM1Q0JldmpPZzhmU3QyZGFnSWhNYzBVWlVGb2FOb2J6?=
 =?utf-8?B?Smxld3ppVFc5MHRJZ2ZUdjl0c1RKSU83cG1hYXQzZG4yaXJXNGNlYnF4N1R6?=
 =?utf-8?Q?eNd9y0lNoWGguRZ//Ru5YWXQR?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d17d4f2f-21a3-4386-a07d-08dab7e578ad
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 06:35:42.7634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Tmjkj2mAJ3AHdlGFDm+sqCqlKpfesfRQuCKPLa9d813v6Iywo3kmP0LBq2jcI7IoQb4SxAO+t9YpafNlaOBsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9061

On 26.10.2022 18:01, Roger Pau Monné wrote:
> On Wed, Oct 26, 2022 at 04:06:40PM +0200, Jan Beulich wrote:
>> On 26.10.2022 15:58, Roger Pau Monné wrote:
>>> On Wed, Oct 26, 2022 at 02:47:43PM +0200, Jan Beulich wrote:
>>>> On 25.10.2022 16:44, Roger Pau Monne wrote:
>>>>> @@ -388,12 +391,12 @@ static void cf_check bar_write(
>>>>>      else
>>>>>          val &= PCI_BASE_ADDRESS_MEM_MASK;
>>>>>  
>>>>> -    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
>>>>> +    if ( bar->enabled )
>>>>
>>>> In 3 of the 4 cases you use header->bars_mapped as replacement. Since it's
>>>> not clear to me why you don't here, could you explain this to me? (I'm
>>>> therefore undecided whether this is merely a cosmetic [consistency] issue.)
>>>
>>> No, it's intended to use bar->enabled here rather than
>>> header->bars_mapped.
>>>
>>> It's possible to have header->bars_mapped == true, but bar->enabled ==
>>> false if memory decoding is enabled, but this BAR specifically has
>>> failed to be mapped in the guest p2m, which means dom0 is safe to move
>>> it for what Xen cares (ie: it won't mess with p2m mappings because
>>> there are none for the BAR).
>>>
>>> We could be more strict and use header->bars_mapped, but I don't think
>>> there's a need for it.
>>>
>>> What about adding a comment with:
>>>
>>> /*
>>>  * Xen only cares whether the BAR is mapped into the p2m, so allow BAR
>>>  * writes as long as the BAR is not mapped into the p2m.
>>>  */
>>>
>>> Otherwise I can switch to using header->bars_mapped if you think
>>> that's clearer.
>>
>> It's not so much a matter of being clearer, but a matter of consistency:
>> Why does the same consideration not apply in rom_write()? In fact both
>> uses there are (already before the change) combined with further
>> conditions (checking header->rom_enabled and new_enabled). If the
>> inconsistency is on purpose (and perhaps necessary), I'd like to first
>> understand why that is before deciding what to do about it. A comment
>> like you suggest it _may_ be the route to go.
> 
> ROM register is more complex to handle, because the same register
> that's used to store the address also contains the bit that can
> trigger whether it's mapped into the guest p2m or not
> (PCI_ROM_ADDRESS_ENABLE).  So ROM BAR writes with the ROM BAR mapped
> and the PCI_ROM_ADDRESS_ENABLE bit also set in the to be written value
> will be rejected, because we only allow to first disable the ROM and
> then change the address (which is likely to not play well with OSes,
> but so far I haven't been able to test ROM BAR register usage on PVH).
> 
> I do think for consistency it would be better to use rom->enabled in
> the first conditional of rom_write() check, so it would be:
> 
>     if ( rom->enabled && new_enabled )
>     {
>         gprintk(XENLOG_WARNING,
>                 "%pp: ignored ROM BAR write while mapped\n",
>                 &pdev->sbdf);
>         return;
>     }
> 
> So that we also allow changing the address of ROM BARs even with
> memory decoding and PCI_ROM_ADDRESS_ENABLE as long as the ROM BAR is
> not mapped in the p2m.
> 
> Would you be fine with the comment in the previous email added and
> rom_write() adjusted as suggested above?

Yes, that would look better to me. The comment then probably also wants
duplicating (or pointing at from) here.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 06:56:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 06:56:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430896.683159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onwog-00022P-1A; Thu, 27 Oct 2022 06:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430896.683159; Thu, 27 Oct 2022 06:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onwof-00022I-TW; Thu, 27 Oct 2022 06:56:37 +0000
Received: by outflank-mailman (input) for mailman id 430896;
 Thu, 27 Oct 2022 06:56:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onwoe-00022C-Sk
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 06:56:36 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7f368857-55c4-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 08:56:35 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6902.eurprd04.prod.outlook.com (2603:10a6:20b:107::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct
 2022 06:56:33 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 06:56:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f368857-55c4-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AQGVI7nFT9T3JjaAGbHGzWx+W6ybkBnVPBkB8k38VFkF2qRqMbvCpvM4RivwxfWaxfxLnu0v+9woQvAGDcrCtIXUISFS4Y2Goeey+zUo6/VNjaPHwjIrPFyU/bvU1reUPmBCtmrzDQzZtj4x3c8y9fgmIZPVfYDLRfVfHQ5xIqg2VjC8RnEV00OOcxP3pS12oW1hofOFDAj2hvB6IlZv9aXa22NrMtM4KIYlr3Xq4LxNszB1Dxe3DaPsqoJN6I6qsr6pGqNs7P/8bHnm2ik4mbjmkzI0Ubwq9udyUV7tGDZfgZ1e9FM1OZbMsKB9NaM4EtPXrDhzksb7eq/0XOf+6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vCY7I2ZdJgT2X3NvZlqbK5kIo0Sa6ZEyRPlwJhig8p0=;
 b=U7p/v9NbOgaHpf2PEklIIrH7pxgWP5iVKDM6ayAph2VsEeMnaPzsi2zGzRqlF5mDLxgHIa0IL8ZDRhBLc2DBT/C4FxSkkr/0CnrmSJqsnWEJDTYRktDPRjec5uI4lh0VMUbzIgdKAtAUO4yamE93RAk/45OwV5rdpWeSf4Gm6iTBeVi/6KuBUVApmKiw3oVKU6yEpDHpjH4LG7Zm4ddtugg9ZVp6U6cAu/qYkOpo1Pvq1P6RiJk2SnFyIoP/dlL2KYS9Cp/EWFBtKDJ1aKyZn7rjvrruKBt79kR7dDjFOWJpU5nFyFnpFp/fHFqa9QKMgD+/cgca+x79MQG3jaeskg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vCY7I2ZdJgT2X3NvZlqbK5kIo0Sa6ZEyRPlwJhig8p0=;
 b=XgGF3LwoMxYRyTkZxP18TGaiCdk4h4s3uBcebg0YnQ2TVnqjMhhdz5sMhkm8KJMyS2zU1PVCXxETX/WXd3ClI/1KIMc1OaUdKPjiqnC+3MZm0XizBwn05YC/IS+fMzAaRzGyw+5f0OsKPcCL2Dakfiq7O7ApHtNBOs1j6isRQf8770oAErINcNLJr7ZbT4m/tTv9KlWHv+R8TWdYhc89MHxtwWjcMsvdsCSOhIZWtmWujFXIqu0cKOm0xRn82uIZHWp4aHH7LBn43jI8mJ4CrZTWZfUP4ABeib9/PIh/Q3fQPuX7glJSM1EqMsQNhec0iubRdge2VyT4GF3bSomp+A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f8c5cebd-06c3-2a8c-737c-c6bd6544f95a@suse.com>
Date: Thu, 27 Oct 2022 08:56:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang
 <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
 <4c713750-670b-eac1-5f5b-376de79192eb@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4c713750-670b-eac1-5f5b-376de79192eb@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6902:EE_
X-MS-Office365-Filtering-Correlation-Id: 77e1e7e9-c2a1-4dff-60f1-08dab7e8620d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	owjdY3kXVankasGdPzjYu086APD5QIXR9bWTZth3Dw8aQZuoGARQAZRqQqxsxV5dBH69VMWO/m4y/Kn/nW3VVm5UdnyZep9yvk4CHzhAXsBaW7hdsR+eukdyh8AMk73lNqdRMDY/lZjTnywgy8J+USIVP4GPBo7KGNGfW5PnUGu4SIn/AzmsmOl419Ze2kzcvn2lHAL7etJGzzyL5p4csu6NgMVncfxYw1J1WClXSDCnfjy1gEPN78Dsn1Z9CuMSB44SsikSIO174SBZ/0e2dy6TmvWPFK8JwKDthlgWB1vo4LV3WPghp3AorwGFiYe92FhC+Jr1AnlEnHCXEkdlU6cAnSWFMXqvizc+VbgBH0YxNihPA6LK6nSJQz4XdE4MHVs9UWxQFmegODpeKDEugmNdUZia89CAKkHHj6hlJrmTBwmhv+apQhaBWdvoHY7l4LsUPByXOFySnoX4jTXfN/BACsJVo+rb5w/qsIn/cgE19lQuNybiqAeqDqVpaUtnZ9XhTC16k5RvGxGQLmfp7q7AQ7kH4Paz+rkVQiO7hzgjAjUaFJzF0fm4EV0hUeKhiPNaIdirkkFpEjzl/DOOMYBRZepM9Bi/JNUG8IvwN/dVo+r8zNPjl43/w3NXuSu3U3vQyVOYLgohQ98TNiMQgwVMxGnxhCVcZOXnieQqMd2gYtpVG4ZqIX7BYn0MqBRsc34gYVrXOx1VJjSO3q4GBGGNF/cOH4i73fwZDD1Vgyy0WXR0RLVYRGJg36TLLa6aG/XsQlkyfyHr6Kf34nxjxuOW97rwwFhPR053miV3F+r4sIQ9xk3HItO2zbn+xxVUE3PRyYbk2xOC5JZTh3xIzw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199015)(31686004)(54906003)(316002)(6916009)(83380400001)(31696002)(6486002)(36756003)(6512007)(478600001)(6506007)(2616005)(26005)(38100700002)(53546011)(8936002)(66476007)(66556008)(41300700001)(7416002)(5660300002)(2906002)(186003)(66946007)(86362001)(4326008)(8676002)(60764002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDUzVDgxcVVMWjkvQ2xpalpPdG9vWkJCdFp0UEl4Wnd2bW5HbkFKYlFpODBa?=
 =?utf-8?B?VXVOSDJiVUJ6UVR1dHFFVERpUDE5a21TMXJnbWwrN3FEclBjb3RRK1h0bktZ?=
 =?utf-8?B?Q2FSOWZKdG5LMW03SHkzVU5TczE5cFZ4bmVhbktZano0Z1haN1dyNkZ1ZTdp?=
 =?utf-8?B?bUdKbkgrTWF4Wkdqc3ZSb0xlTU44L2dZWkdwcnoxVWlpRzBSMFZsWEoyUlFu?=
 =?utf-8?B?UEZjek55cjJENTFqRlZ5OEhMcTBtcG9PTG1BRU9lK1VkWGZmOXVQSDhWVXlk?=
 =?utf-8?B?MXdES1BodnNHRjRCekJTNmFoK0p0dmo0blEydlFrc0FtTHY2eDk0aEFadC9u?=
 =?utf-8?B?eGN3NDVDVE1BSSt4Wi9XUEZ1MVdVTU5iYXFKcUtKSktRdEw1VU81VUY4dnV3?=
 =?utf-8?B?eTAyc0R6T0k5Skd3Ky96aVY5cllBRUhVSVI1cHBrYVZPUk5EdDk4bEJDWkxQ?=
 =?utf-8?B?TDY3bCtDWG1Qa0VIMkxqc2tubXNZNHdQbkhINzFpTjVOVFgzWWhwOXhmYzVK?=
 =?utf-8?B?a3I2WXhtNVJUeEV1YmRGditJUjA1eXgwSC9CRmI3SlZaUmZhaTVkRjM1L3pz?=
 =?utf-8?B?bjZQZzFrQzg1cGV3YmhpS3MyUTdBVlcrOUZ0Sll0K1RqaFhvb3lkQjNmL1Br?=
 =?utf-8?B?cEY1SkVqbVl1aHdjdXNvcjMzeXd5S1ZUUVRkNGVFcnV0NGFRenNSUU8rcHk4?=
 =?utf-8?B?M3Nwc1psUGNkcEFVZlJmcDhCcGNSY0RIMjRDdjkxakt3OWVWTHRkVFlvR0Nu?=
 =?utf-8?B?c3l0b2NqazhubmhObDBYdkgySWVYb2JDTWo3dDdySnFna3phNkFzbHZISFlT?=
 =?utf-8?B?d3FWRkxQNDJDRDV6S3JsaG9sbGtBeWNvNXVrNVZveEJQL0JFdzVBc0c5M1lI?=
 =?utf-8?B?UFJMajJhOGdvZlVrR2d0a05sS2lpajM2Z3NrMWc2NW9mWEl5TVNXazRnSHBY?=
 =?utf-8?B?b2ptenlOK0tGV2JmL1FudjBZZTUvVkpBMUhtRGd1K2IwcnltN3RYMjdkbkhM?=
 =?utf-8?B?eW83dFRWTXJid0hNYUt5bEwvQU4zaDBVWXJhMFEzdllEeUtpMStrUWlROSs1?=
 =?utf-8?B?YlFWaGJUTmJ3KzVZdy9xWUR3U0NybWtscUMyVFE2emNEWWNuKzFpRThzQ29Z?=
 =?utf-8?B?WjBObStSN2lIUkJyQWoxbi90SmNqWlY2d2dNK2tqTk5wZENrekRzYzI5WGVh?=
 =?utf-8?B?WG9nVWJNVDI4aFVub2VaODdFSlk2VFQ3emJBOENuTHVxbmo3L0sycHFLSHdk?=
 =?utf-8?B?ekZiWWQvM3o5ODkzVUVNQ0lzWW9vTEc2ZnB0VmdZaUN3WHZRdXlrZWY3NDR5?=
 =?utf-8?B?R0lRRjlrbjd1NmdNQnNKcjhKeDY2eVByUTJtUmVzK3ZTeUU5TG9wN0dyaWRQ?=
 =?utf-8?B?YUs1NnVoMWx5bVhUTWpQOEFJSkU3SEs0cEd5eHlwR0dGTHZtWXpYdkdySUp3?=
 =?utf-8?B?cVgwL3Nya3hidXVVZUpUbWs2Nm9tOFJvTHJRMkhVaDhscjVPQjBVcGVMMjdH?=
 =?utf-8?B?OHFleS9POGdkL3YzU0cxbEVhWVVhU0EvejNZbzBkYi8xRFZjQm1IK0w3K2Nj?=
 =?utf-8?B?Q2NBWXpuNmQyTFRZdG9vTnRJWE1lQ0J0UHRlRnA3WS9XWVVvUENMemU0YXFa?=
 =?utf-8?B?Q1U1TlYzRWJIZU9oZ21iRUtJWFk3ZDNDOUxnNU4zVThBcTJ4V0VJN3ZYQzVh?=
 =?utf-8?B?eWxXNFZoRzhQV0JTRlJFSjUvdjVaTzFHTEEyYkdoZTM0ZGdaVUU1Umo3TnFn?=
 =?utf-8?B?TEtnOUlUTlorU0xHQUdwUkMycGhqRUQzRTMzdG9SeDZBUE5keWdLZC9Pc1Ey?=
 =?utf-8?B?TzhQb2FQNGtXdHNicDk5cVp5VENYOTRTQ0x6SHc0UFdDbDBCVFRDUnluczVp?=
 =?utf-8?B?OEVRdVMvQ05kQk5lOHZyTE5SZmlYRisyZmRiSFF0SkVGQmc5MVhpaDBoSk5h?=
 =?utf-8?B?ajhuV1F5VWxlckRZWEpKMEdhWGVlUncyMFlqYnpOMWl3STg3Z1pkRHpwTm5P?=
 =?utf-8?B?S1d2WEdkZzdvbzdieEdIQ0F5MWhwOVovZ29weVEyUUpjanhBbzA2NnA2UFZa?=
 =?utf-8?B?UUI4Vi9WUTluRlJmVGYwTDZlNGxsa0tNMGFxRlZ6Z0h4d3VlZTZDZDVlMHEy?=
 =?utf-8?Q?auqFl5aFQCmAH0pqVUJGnkRZt?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77e1e7e9-c2a1-4dff-60f1-08dab7e8620d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 06:56:33.2936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O0hIAnl9kh9J9XyDp89FqtWJqxHJib9U/z2tys+dJD90QcWRPWZN1fD9bLfDZDqr0GL03adkFcHUsGwIMDETlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6902

On 26.10.2022 23:24, Julien Grall wrote:
> On 26/10/2022 20:22, Andrew Cooper wrote:
>>>> --- a/xen/arch/x86/mm/hap/hap.c
>>>> +++ b/xen/arch/x86/mm/hap/hap.c
>>>> @@ -345,6 +345,16 @@ unsigned int hap_get_allocation(struct domain *d)
>>>>               + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0));
>>>>   }
>>>>   
>>>> +int hap_get_allocation_bytes(struct domain *d, uint64_t *size)
>>>> +{
>>>> +    unsigned long pages = (d->arch.paging.hap.total_pages +
>>>> +                           d->arch.paging.hap.p2m_pages);
>>> Unlike for Arm no ACCESS_ONCE() here? Also the addition can in
>>> principle overflow, because being done only in 32 bits.
>>
>> I'm not actually convinced ARM needs ACCESS_ONCE() to begin with.  I
>> can't see any legal transformation of that logic which could result in a
>> torn load.
> 
> AFAIU, ACCESS_ONCE() is not only about torn load but also making sure 
> that the compiler will only read the value once.
> 
> When LTO is enabled (not yet supported) in Xen, can we guarantee the 
> compiler will not try to access total_pages twice (obviously it would be 
> caller dependent)?

Aren't all accesses (supposed to be) under paging lock? At which point
there's no issue with multiple (or torn) accesses?

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 07:11:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 07:11:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430900.683170 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onx3Q-0004Yk-BL; Thu, 27 Oct 2022 07:11:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430900.683170; Thu, 27 Oct 2022 07:11:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onx3Q-0004Yd-7C; Thu, 27 Oct 2022 07:11:52 +0000
Received: by outflank-mailman (input) for mailman id 430900;
 Thu, 27 Oct 2022 07:11:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onx3O-0004YX-2O
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 07:11:50 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f09e54a-55c6-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 09:11:48 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PAXPR04MB8767.eurprd04.prod.outlook.com (2603:10a6:102:20e::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Thu, 27 Oct
 2022 07:11:46 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 07:11:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f09e54a-55c6-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PaqXtTgVGE2OSJBIlnH6PYiufJqWKOWKfUZicw7nSx3kToFw1OdkEJRwZu4Md8PnZJuHo18FDpMRp58FypBhBZrddUOp9zvkUozfsaGYUCH0BftN7oOpsd4yZbJd+2c9x85+2wmdM0AbOox1JdQR0hGiPH8XK1vabkZGxuupBzWWLLHk1KbJ1NqAlwhaipZdIW/RBFeIAf1N0Dg74PtElPY4xrqdnKazFKKPHMEW8xKp3VKiMf+YfS0lvAtozB/k2xnlrix48IOOZrdbAWDMcE8Aga05m7TEHY4V5MVN43KZTJiO2qyV1QlEkejLcf0FVdRHiezIgmBKU26RzSg1oA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AGA40ZeBhhgDlmH+qfaS5dlLFuP3Lys15u+4bzXL95I=;
 b=VFMjFpp1/PePaDg2J7VoHHkCuF+6c0Lve3ySdzOtW9nPp4TX7Pi9qWo84NXdphTNMWUhU1Hylb0+3Nks+a/b8GLgdOQ8EqIljs8myLywQ0phRP8UQlQqOvrOsG3BIJiNpU+CQr46VofmuSBym1BR77R83TE2ZO9jycvFfuRtY0o9bdReZgub2qpCvhdzyNuvCRLyheuLuJCcI1HSjCuQTFsWWO2KyRBCccVuuYU1klyB8CqKKW8+m0ADWGd+et+kGNyCOyGyxkTqRmsP+kKneic5u2tWnHahLBv2RsOVjvZnFofnW4BeIowRxdbnvXAepA2WcVW0V8k7dd2w8hVsIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AGA40ZeBhhgDlmH+qfaS5dlLFuP3Lys15u+4bzXL95I=;
 b=NAqXhZecN3ED3fDrk/OGog0tn7M7qHfN6jicrsWCHLlSKqO+bzHl76vBieZDeNZn7wk1g9te9A8D5Jdv8MKs5D42p7xuv73rDu3eXWWPav2tDo3KQ8mnC2tTdH2h/ou9n1ChVMJeCV2us4BdYax2zr8ZvZHTB+6R90D2/xc8EvLTdAONgmXK8koCByXxL7L7nHw9/PO6IqReKcjcThkZROk4Q7TJpQptv5qgU16lBRj3WuVbnshLe4okn+nY0lpB5lgwkFk5IZYUuic02nqJREUTgwZaRj07grFKHc5CWPD2ff13WsjMDd1UzvgMPfHSULiR1TPDaNmwb8OORYROaw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com>
Date: Thu, 27 Oct 2022 09:11:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Content-Language: en-US
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang
 <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0008.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8767:EE_
X-MS-Office365-Filtering-Correlation-Id: ba51dcae-cc3e-47af-9b23-08dab7ea8256
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OK9K10bHZ3qRJCl2TqauiBpeQKIw+tKBjAv8ZL52LXYO5tlgIdxDfzQU0qKK5hxscfpPB1/H7Mtt7iVNbEbAgM+D1kWS9qKktJpfSw73BdQ0S3Kxefka37zS6BdkmqW5H29QUwTP8gy5qp1lTcAhV/yiQEom02N/VcN9bN6To4rUJ4Vu3g2eHL2esx+fguTzN0TKnIYY6jqtPPIE2/ibZdaqXc0Fs0DVzlKbVyuVWTGFSBjtKJh2/TrGQnlJqwhwrb+I85IFkbAdIDgBKMzSX8tr8BmsmRO7xojhOXHfn9lGduL51S1orTVgu6ERAauq61zlk0KYt6YTiwq3f61MmehmUWxqPOrPMuAXMJcDWbTJ1qs0kL7y52gHkXrTBjK+gaM2j9rkYkHjUkSO0FHsd9k3oAV3ZVgn4WAynZtNa3zuyLjL3bpXuL940x7++pMV7aWC8hgIhvdD3mO8AJtoNaCr0uyh8oFpkqlXgwzCgYrrT/TKsldfEPTQ89HqNMusTr2Y/KBt2sPBFHkaVFP7FSHjE9Xe0aiuNZZZKZ3+3+OgAuzCJu2QAjbH4Q/hQ148cRnYJxUWfwXbD96ggdbZFIlMcxNXcK5dYH3cM7wyLyvXmGOhTQcYrV61qRZSDtbi+IRPfvOGGtYixWJuj0yUEpmWpHoi23y3Vn4W6jz2+lBFTOYDL9vyY0caY88elo1ImipLJHKfMOMAkJzntLVW3T945XPcBszYoViutYMZE6oNW+yd0RQ+fe3AV1oW3suHYbIck6ZOjBZsJAIpvDwm27RRTBQ5Tr2RQd3vAMVzU8w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199015)(36756003)(31686004)(83380400001)(2906002)(86362001)(31696002)(41300700001)(2616005)(38100700002)(186003)(6506007)(53546011)(6916009)(26005)(4326008)(54906003)(6512007)(316002)(8676002)(66556008)(66946007)(66476007)(5660300002)(478600001)(6486002)(7416002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b3krUk40c0d5bkdjSzFqM3NERy9kYU5lYnc4WWxKN3VKMGdybFNQSHFQdDBW?=
 =?utf-8?B?Skk0TlVHTU1KQnp2Q3I0QjlOS3NIQi9Cdk1McjhoK0FKWEY4RnI0UU01Q0tj?=
 =?utf-8?B?RUFXc2F0MzhIWEtlZm1IV1lvck1tNi90MllNUGljampFVStjTXBxcTJ5aWE3?=
 =?utf-8?B?Sk5DRWJ6Q0RJQVYzV1lDcDUxYW5aQmlna1RwdVRvK3MrUmVYZ2hsL3hMaytD?=
 =?utf-8?B?SHZqcXdZT2t1OFEyNFZtenJaRkphcE1TTTJEUkFueEZ5Z3JUSEFheGFXSlBJ?=
 =?utf-8?B?UVJLdklaUHdlMlQ0dnFXM2RyYzJyd0orUisrNDRPVWtEZHdibUI0WGlqMnBi?=
 =?utf-8?B?bzdMQnRxOGcyWTZTQ0IwT0ptL2tiTXRSZGx1Y2UyL21PZTNCQjBsWW1jMGQ0?=
 =?utf-8?B?alhhL1VLTS9PRXdwK0s0dXBOZ3hhbDNkOEc1TEloeitsaTB6NGdzZUNDeFBO?=
 =?utf-8?B?K0czUWNZSG9LMCtpVGc2YmJWV05vMFU1L1RGVWxCQ2VzOGtad0lDMDl0WG9K?=
 =?utf-8?B?N2c2WTJjYXI4UzBFS3NCNXZrcDhVS2VpVGpJYUI3SHNQOThxV1RCUUxqYmZY?=
 =?utf-8?B?NHkxcXE1NkZXV09rNVFUancyOG05Y1YyVWdlaytkL0RIak5leENSdHRsYWw3?=
 =?utf-8?B?aEVSZmNmUEZ4eWU3OStVdSsvM1ZIVmFvN0pIWE84RC80WDJlVTdtRkVucW9O?=
 =?utf-8?B?b1cwRDZnMUxLSVlmUlRJTUMrRTBrWUtNZUovS0pqN25td1pqYnRuRlhWZ1gv?=
 =?utf-8?B?Sks0c240bzZ5MFFlSVdnNmV3TmhiR1RMMmN0U0ZON1E5REhoTXpSRkV3bE9Z?=
 =?utf-8?B?Z0t0NFp2YXBkU0RHa3F2OHlyZmRNWjJvejdpZ2hEblREVEI2R1hYZlE4aThp?=
 =?utf-8?B?dFFFdkg3enBvOTdiNWQ1WUZpb1U5WDU2eTV5SVdwUFpjdUNJVkJBNkk5ZzBt?=
 =?utf-8?B?N2R0VGYySUpRL2wzd2JSZkp4cnZxNzNLUGxLb2o2b21wN3lTWDV3c3BFQ0dr?=
 =?utf-8?B?YWc0cXBMMnRJRmU3TU1mVnBwS0ZtSmJDZDFIcXpCSzQzbk0wWCtLZ3hSRVRS?=
 =?utf-8?B?SU1Ua2lDMlV2U1YwZkVJSCthdlp3b0RZU2Y1SUNHS0oxdTBWSlJEMkgwaXdz?=
 =?utf-8?B?aU1KS1RZRDZMZFJZUmdwaHJpRkFGYnJKQXlmOERodkk2SWNJR1JYTlprSHRV?=
 =?utf-8?B?U0dlWU9EMXptdGVFdENJb1Axa2FmcDdYZ3FFWi9xMWpjc091Z1JHTzdoVUFm?=
 =?utf-8?B?dlphYm03MkRoWVgwd2NWUmdmcDJIeGtnOEdIaXBhWTRqUHRmY0ozdG9xMzF1?=
 =?utf-8?B?WnBvSTdGZm5GWTdHdUM2a1AxeWkvblpHOGh0YXdwdDhDU1laZHhMam5XNWxE?=
 =?utf-8?B?emVzaWg5NkRIdlVvU3dWemFHNXh6Y2dVLytVNjJiczRaUVlMS0xzODNHTWRm?=
 =?utf-8?B?UDVjMDI5YVhSTXRGMEtVaVBWc1Z3KzFKOUhFV0k0dkhQNWgwODRBQkFYVVhS?=
 =?utf-8?B?U08vVTdBVkFGRXFRVWU1Q1c5K1NVV2d1ZEh5b1JHb2FYT0swa1haZ3hRSk4y?=
 =?utf-8?B?cko4MmtRSk15eFkrOWo5YkNJY0RtQ2hTQzM5VDREakZmVjh5RGlCOEJHSytB?=
 =?utf-8?B?MUM4bk9LYnN3aHd0VDBKRDFjajJoNTVtZlo3aXNCaVFkMlBEZGNJOEc4SHNW?=
 =?utf-8?B?UjZUMUJ5eW9mZ2c2NHJIWVJocVJHWHZ3Y0MzcnhvN3JoSlN5bmI1RVBNZnJ2?=
 =?utf-8?B?L0Y5dFNOQ1p4REtPYko3R0d2OEc5b2E4aTBqeUhaeEFRZ09VUFprVkNLTjlx?=
 =?utf-8?B?YVlrYVp3S2hnYVBCTUR5RzRlWGkxSVgrdjIvbWxlcnFDc243OW5jbnYxelVF?=
 =?utf-8?B?aExpbXJtazVMeHp4VmYrNU00Z256bTc4K0E3N0dJTjcrc0xaYXAvOVNIS0E4?=
 =?utf-8?B?clVhZkpqQTRPQ3BNbDhsVjRkeUhGUTFpQUtTOHBOem1RQjcwR3lTcnVFVGNX?=
 =?utf-8?B?V0Y3cnpIdTFMWmRYakQxZGg3OHFpZVFDRmw0dDgvL3hTclk3bVZPbk85SjZh?=
 =?utf-8?B?Z3kwb0R4T200OUZLWTM2b29TWDRURWVJbFFtc2J2d0p0a0x2UmRiczRQbjJn?=
 =?utf-8?Q?N67IS3JSesnh9VU+FBoL4YdbN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba51dcae-cc3e-47af-9b23-08dab7ea8256
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 07:11:46.4384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IsUIeKx8pDejpCQgC2B4lhtyDW+pZCCDJFWFLvlAOUWyxqNDFJA3vuxCskU8XO0PBxEwfNOQJ4TcDzea8VC9Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8767

On 26.10.2022 21:22, Andrew Cooper wrote:
> On 26/10/2022 14:42, Jan Beulich wrote:
>> On 26.10.2022 12:20, Andrew Cooper wrote:
>>> The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems:
>>>
>>>  * All set_allocation() flavours have an overflow-before-widen bug when
>>>    calculating "sc->mb << (20 - PAGE_SHIFT)".
>>>  * All flavours have a granularity of of 1M.  This was tolerable when the size
>>>    of the pool could only be set at the same granularity, but is broken now
>>>    that ARM has a 16-page stopgap allocation in use.
>>>  * All get_allocation() flavours round up, and in particular turn 0 into 1,
>>>    meaning the get op returns junk before a successful set op.
>>>  * The x86 flavours reject the hypercalls before the VM has vCPUs allocated,
>>>    despite the pool size being a domain property.
>> I guess this is merely a remnant and could easily be dropped there.
> 
> It's intermixed the other shadow operations.  It wasn't trivially-safe
> enough to do here, and needs coming back to in future work.

Right, and I should have said that this is merely a remark, not a request
for any change here.

>>> Name subject to improvement.
>> paging_{get,set}_mempool_size() for the arch helpers (in particular
>> fitting better with them living in paging.c as well its multi-purpose use
>> on x86) and XEN_DOMCTL_{get,set}_paging_mempool_size? Perhaps even the
>> "mem" could be dropped?
> 
> Yeah, this was a placeholder for "what are we actually going to call it
> in Xen".
> 
> I went with mempool over just simply pool because pool has a very
> different meaning slightly higher in the toolstack where you talk about
> pools of servers.  Admittedly, that's code outside of xen.git, but the
> hypercall names do percolate up into those codebases.
> 
> paging isn't a great name.  While it's what we call the infrastructure
> in x86, it has nothing to do with paging things out to disk (the thing
> everyone associates the name with), nor the xenpaging infrastructure
> (Xen's version of what OS paging supposedly means).

Okay, "paging" can be somewhat misleading. But "p2m" also doesn't fit
the use(s) on x86. Yet we'd like to use a name clearly better than the
previous (and yet more wrong/misleading) "shadow". I have to admit that
I can't think of any other sensible name, and among the ones discussed
I still think "paging" is the one coming closest despite the
generally different meaning of the word elsewhere.

>>>  ABI not.
>> With the comment in the public header saying "Users of this interface are
>> required to identify the granularity by other means" I wonder why the
>> interface needs to be byte-granular. If the caller needs to know page size
>> by whatever means, it can as well pass in a page count.
> 
> Not all architectures have pagetable levels of uniform size.  Not all
> architectures have the mapping granularity equal to the pagetable size. 
> x86 has examples of both of these (and in a rogue move, one x86 hardware
> vendor is trying to add even more pagetable asymmetry).  Other
> architectures substantially more variety.
> 
> Even on x86, there are performance advantages from using 8k or 16k
> arrangements, which could cause us insist upon >4k requirements here. 
> (TBH, not actually for this usecase, but the principle is still valid.)

Perhaps, but that doesn't change the picture: The tool stack still needs
to know how many of the low bits in the request need to be clear (unless
you would accept to go back to rounding an unaligned input value). And
once it knows this value, it can still convert to a count of that-unit-
sized blocks of memory.

> The reason is because this is a size.  Sizes are in bytes, and that's
> how everyone thinks about them.  Its how the value is already specified
> in an xl cfg file, and it entirely unambiguous at all levels of the stack.
> 
> Every translation of the value in the software stack risks breaking
> things, even stuff as simple as debugging.  As proof, count the number
> of translation errors I've already identified in this patch alone.
> 
> This ABI does not require any changes at all (not even recompiling
> userspace) for ARM to decide to use 16k or 64k pagetables in Xen, or for
> x86 to decide that 8k or 16k is beneficial enough to actually require.
> 
> Attempting to compress this uint64_t into something smaller by any means
> will create bugs, or at increased complexity and a high risk of bugs. 
> There isn't enough money on earth right now to afford a 128bit processor
> with enough ram for this current ABI to need changing.

I didn't suggest to use a type other than uint64_t. I'm merely puzzled
by your insistence on byte granularity while at the same time requiring
inputs to be suitable multiples of a base granularity, obtaining of
which is not even specified alongside this new interface.

> This is going to be a reoccurring theme through fixing the ABIs.  Its
> one of a several areas where there is objectively one right answer, both
> in terms of ease of use, and compatibility to future circumstances.

Well, I wouldn't say using whatever base granularity as a unit is
"objectively" less right.

>>> @@ -157,6 +165,25 @@ int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted)
>>>      return 0;
>>>  }
>>>  
>>> +int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
>>> +{
>>> +    unsigned long pages = size >> PAGE_SHIFT;
>>> +    bool preempted = false;
>>> +    int rc;
>>> +
>>> +    if ( (size & ~PAGE_MASK) ||          /* Non page-sized request? */
>>> +         pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */
>>> +        return -EINVAL;
>> Simply "(pages << PAGE_SHIFT) != size"? And then move the check into
>> common code?
> 
> These checks are deliberately not in common code.  That's just creating
> work that someone will need to undo in due course.

Would you mind clarifying why you think so? If the base unit isn't PAGE_SIZE
then all it takes is to introduce a suitable #define and/or global
specifying the intended per-arch value. Even if you expected this to become
a domain-dependent property, the corresponding value could still be a field
in (common) struct domain.

>>> --- a/xen/arch/x86/mm/paging.c
>>> +++ b/xen/arch/x86/mm/paging.c
>>> @@ -977,6 +977,45 @@ int __init paging_set_allocation(struct domain *d, unsigned int pages,
>>>  }
>>>  #endif
>>>  
>>> +int arch_get_p2m_mempool_size(struct domain *d, uint64_t *size)
>>> +{
>>> +    int rc;
>>> +
>>> +    if ( is_pv_domain(d) )
>>> +        return -EOPNOTSUPP;
>>> +
>>> +    if ( hap_enabled(d) )
>>> +        rc = hap_get_allocation_bytes(d, size);
>>> +    else
>>> +        rc = shadow_get_allocation_bytes(d, size);
>>> +
>>> +    return rc;
>>> +}
>>> +
>>> +int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
>>> +{
>>> +    unsigned long pages = size >> PAGE_SHIFT;
>>> +    bool preempted = false;
>>> +    int rc;
>>> +
>>> +    if ( is_pv_domain(d) )
>>> +        return -EOPNOTSUPP;
>> Why? You do say "PV is weird" in a post-commit-message remark, but why
>> do you want to retain this weirdness? Even if today the tool stack
>> doesn't set the size when enabling log-dirty mode, I'd view this as a
>> bug which could be addressed purely in the tool stack if this check
>> wasn't there.
> 
> I want to clean up PV, but again, it wasn't sufficiently trivially-safe
> to do right now.
> 
> PV is weird because it is neither hap_enabled() (fundamentally), nor
> shadow_enabled() when logdirty isn't active.  While the freelist is
> suitably constructed, the get/set operations were previously rejected
> and cleanup is local to the disable op, not domain shutdown.
> 
> I could put in a /* TODO: relax in due course */ if you'd prefer?

Yes please - that would clarify this isn't a hard requirement.

>>> +    if ( size & ~PAGE_MASK )             /* Non page-sized request? */
>>> +        return -EINVAL;
>>> +
>>> +    ASSERT(paging_mode_enabled(d));
>> Not only with the PV aspect in mind - why? It looks reasonable to me
>> to set the pool size before enabling any paging mode.
> 
> Because this is how all the existing logic is expressed, and this patch
> wants backporting.

What do you mean by "is expressed"? I can't seem to be able to find a
similar check on the existing code paths. But given that yesterday I
almost overlooked the d->vcpu check in paging_domctl(), I can easily
accept that I might be overlooking something somewhere.

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 07:43:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 07:43:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430905.683180 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onxXS-0008Rv-Q3; Thu, 27 Oct 2022 07:42:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430905.683180; Thu, 27 Oct 2022 07:42:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onxXS-0008Ro-NQ; Thu, 27 Oct 2022 07:42:54 +0000
Received: by outflank-mailman (input) for mailman id 430905;
 Thu, 27 Oct 2022 07:42:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onxXR-0008Ri-JG
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 07:42:53 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5b9f6ff-55ca-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 09:42:51 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB7511.eurprd04.prod.outlook.com (2603:10a6:20b:23f::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct
 2022 07:42:49 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 07:42:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5b9f6ff-55ca-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MCKbqd/dbt8R6ig8Xr7f1F3KOlRqe5+oajETQajI1IYQV/xbvjDwaJr5/GmI+Z2r5o6kxGZZ7e09/fcaVhDkBQCjVPREi1/qFanFy1TueiYB7S82F/xw2+FP38htrFOhR85xhYazqollis+9znneKXDnpZA2XOWM7rkeZhz4r3LxxDtbhpHK9Y6OCyBYemWE/oSZmMAtNJG4k/tOqfXbhe8lpQg3myCPx4776jbi4LqhsMVSaHnjG++OKQS7Li6URXsP8Cl0vkj9fHhFjSw01n7m+bXL9LdKqfpMu083bqHZSefVOo1YoNDGu21oSRUxcvbnMpCTAJ0elmm8j1dnlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rbj/4eHtZ0EwWOarKG1TXEsOJjIYCSgqAK0gFP8TdVg=;
 b=XHA4XlqG3MervS9rJN3CtLrS17EPT5dOyaXcWIsOWXi2cfn3fkyCztae5Nzg7NroFTKLRY2q4VoD0xm7U1C4Fd0+A6amhUI//eCBSrj24HHu4g+Wp2aL+XZj3rSq6j6h38AUbMfg+UwSF5ZkFWYSjzBgPTGUuU9M2JT8pXBqk+rI8/lRcXhDQQqD//klqp9cQs/u2ICWdK1wCifrdIVnBfqjOOeiiVGt80WRnZC6/E/+r5ea5H9IJszpq+FO0eqMICO9nTwI9yBJPJqaHosNQl07OtVK5vXCdDbGMhtOAFq7dF/3koKlp8BexUZBZkw97RWTpk4CQOONdY68+0swnQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rbj/4eHtZ0EwWOarKG1TXEsOJjIYCSgqAK0gFP8TdVg=;
 b=xc0KkG2NuG4wFMtG1WqObT2hzILUOsln+hANK4F9ZnXAjODe3My+byWTqZy3HivcG2rPIxyCwORzhe+/JjHfM3GGup1OJRqc/PF1R/G4DCniB5+i7Q6tBrtYbfw8cR62HtbMrwtdt4IrRlwgk9xFLIw40dKIilsjnRQAanBdCmYA4j+VCvqs1sBkOVqE6lR00v5KtlDn0zFqwbIaGqNX+/jXzS5FRhI2BL5mMoEE/YJN6IRzpZQ0NaOC3MINfCc4QNcJQpUTiq85vDsaVZJ0Eb7AaBhMUw+3DPkZYx71J6ym+9V6IxvljA6ZUvzr2EYywAuJHSf3xFjTUAEvbNSZXw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ddcfd948-a189-7094-2300-aa7a1cdd5f2a@suse.com>
Date: Thu, 27 Oct 2022 09:42:47 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen Security Team <security@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221026102018.4144-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0146.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:95::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7511:EE_
X-MS-Office365-Filtering-Correlation-Id: 77b27d9c-06aa-4566-d84e-08dab7eed8c8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sQj4tF+WeFNY/QArBkCVhBG3LbPjSnz2LQO4/t+syP/qvKYHP9HhAEEpgBejCG8z/ghJlP8gctdccTzTrV+JgO+B8lj5JDPHHnzZMAfG38h5RwgJg/y0aa0go2QFlCPhFs6X7ZtrmArr9Sub+KQr0PkAPxy2uD02AyjF0Nprm5NyiCxrZeFiPWFKzBPNv3cmVdByWlHEfRhn8Z8rWxnSnWsqCB+AFe4T4Ix+zG1cPnLjswcPPrX4lzqkq86guw++4r7PXtxGp0iA/FeWZIruQyizq7/ParEnj4HaT/ANHgIiCn9bi3ybdsnUphJ3FCIPFofKO9II6TH4wdJgYSdzlWLbUddtJ3P0Cib2aQZG97FxaxOqaZ8dpXoKWkoxelgYOBRh5VeZjJk/g7YDUvfRYJ1bOFV45TkS8dBM9E+ZGPFA66/BQaNsjUXEhRdg5XjOejbSKHYk2szT4djhhB9msaJkizXD09uzYP19PiT2agWC6WMqwUnUwOqLNOJ4Gi3Jwfa9TU8Ng3NfmOEpYuUlyzu3v51RDLc2Yy57QERdI/jf7WVKcKEQwakt52MhKcofYc6hN5Xa8Hssbdd7DwPX0T0OgFIWHoR0WSszYhcdog81Ys/vQ4R/1itJF+Kv9TAP9X3RuyUWYAsWYexcW1fvH6+SMpTKlN9+nFjMlsySFH1OZ/GTrS7zf25uFx3grjO4RLwXj7BeScyS0uckHmr5/woWeb+NuXD9kDT+duA7YkPZ86ymhR6e1uIJp+JoWT/chrErbbtAdDXS8vHca0q5go2NGwEn1lHWfCbuMwud8KE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(6916009)(31696002)(86362001)(54906003)(8676002)(316002)(26005)(6512007)(186003)(2906002)(7416002)(5660300002)(83380400001)(38100700002)(66946007)(66556008)(66476007)(4326008)(8936002)(36756003)(41300700001)(2616005)(6486002)(31686004)(478600001)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RzdlWk5ScU5mNlNDY0VUbEwrbmI1NEticzJrZHBxR0l4QkExN0gyd2RYV2pI?=
 =?utf-8?B?QjdDSHRHOThSdGRMZWswYnQ2dVJ4VytxZGNzTWk3Z0VxNDdJS0FGT1pGQzgy?=
 =?utf-8?B?Ym9zWWlaSy9GU3I0cmdZWWNJanRQM3BRRHo5NnQ5SDB5dHZQL1Uyc0M1WkIz?=
 =?utf-8?B?ODM1NjNqQVBlZzNXdDVNeGQvSmJwV245bWtJZWJCUFQrZnFaSzg4cGNKQnBq?=
 =?utf-8?B?UkpZWUpUMU14enJwM05NWHAyK05RSUlRbWQ3Z3QrQ1dZQ3JPSzdNaS9sNHRa?=
 =?utf-8?B?SWRLZVQ2ait4bzhjeWUvaDBORytVWlAxQStFM0xkaUpmaSthZHpuQXU1cGFj?=
 =?utf-8?B?T1YwOGJXdldMNk5wVk9BY09uU2REVnlBSmcvbVJkSnQybWoyenB0UVV5Rklw?=
 =?utf-8?B?TEJSREZ6NjZlaGxVLzJGbm05akk4RGJ1Z0NqS3RzNEgwajFUL3htRTRleHVD?=
 =?utf-8?B?WmhoYTFPSWNsblhhbVJEQ1pPRmJwNmJ5SlAxYkRQMGhIZVNEOW91MHVNM3Bi?=
 =?utf-8?B?VmZuVmtadFdmcDhlYnFQMms4VWtINzk1UlVQVEpQQ1JGczhpVGcxUTZ1VHh2?=
 =?utf-8?B?ekJOZmhoejUxTTdkS3IxSkdkRUlVYlFrT0dXcjVpV3NpL1FhWDlhY1hwVlNi?=
 =?utf-8?B?Mk16eDUyay92ODFLNlljMkNkVVg3OTJ1bFcydDRuVmRSRkU0MDVYUS9MNGhD?=
 =?utf-8?B?YW4rcmxUVVI2allORUN2akt4eWt6MjJBblV3aXp4bDNuMUpYVTlHeTZXK0F1?=
 =?utf-8?B?Z3p1V1pTSGlvdzNVLzkxN3pIS0UvcUtadXFsTzM1YXZZVWFLeHg0WmZSQ09N?=
 =?utf-8?B?ODlqZjFoSEZWdExYREwzSzA0Z0lpdTdMUDBHQUVwOG5jeVJqQ3UwVzh2c0Mz?=
 =?utf-8?B?YmxwQmZmTkowTEJmNFVJdkhNQlVtZ3dzTWV5UDR2TC9mODhOU1ZDWW5XdHVS?=
 =?utf-8?B?bklHeFRTT0lwalRORXdhM2dZdjN2NU5iZmdTdUxodXhsdG9HRGF3YXhmS1JP?=
 =?utf-8?B?T2MzSE1QZDUwM3V4QVMrbDYxRXZGdFd1OU1lMjF5UkNVSHY3RTlsbmZ0TzVB?=
 =?utf-8?B?R1dDMkkxbkxDSEtDWk1ZanVzaHdDRnJPMGZ1VnlKdXVvazBaRDNNaG1sUVBx?=
 =?utf-8?B?d0Z4aHRnNytPcWdTcERJcmRzOTNHaEtnNm1qTWlJcFlvL0IrOUFCUEtRK0Vs?=
 =?utf-8?B?QkxvczJQanR5a3g0L0JBMkVDd3AvL094KzBVYjcwQk9ONVgwREJMZXVabUlZ?=
 =?utf-8?B?NlJhYWdSVHoyMVZKOHB4bW1mRGVMRjVFNDZoTUNYUmpPZHAzSlZnZjhMNHE3?=
 =?utf-8?B?VUpCSGYxUEJIeWNwY2FJZUI5TlBDcm5pMFc2QzlvMEtaaWkvVyt3cGFxNlhT?=
 =?utf-8?B?U2lYK1orK1VlU1dGY2lqZmZLS3JYNElPYThoMmhHWUJlenZQVGkvdHdPbHJm?=
 =?utf-8?B?ZHRQM3hyTFQvcmJFaHhrVURVSXhieFBSOFRocm94QUVhUVk2NEg4VlJTMXhm?=
 =?utf-8?B?em05VVowOXJLQ3dnZ1lqdFFHeDV6cjhNK09MTWVvYmFQM2RManE0WjQwQWt6?=
 =?utf-8?B?dkxraVUzenlTU284dmUvQ3BiVWFyUzFTdXFQRkg2Nnc5cGRmclhTSlpubTR6?=
 =?utf-8?B?Y1Rzc3F5THJyRTN3M0FJVVM1Qzc2bWIwUVRvV3ZiU0FjZUx6SjE5bldWR2wz?=
 =?utf-8?B?U2JFcEJsZ0Q5ejBnNTlkRXEvNFVaQTlEeTM2ZndNM3RMZENUdmY4WUNFdjBl?=
 =?utf-8?B?dGtsZFlicFR0bnJXZHZNR1Z5T1RuOU5DeFY5aUgyQ0JVTU03NEJMdnpWeXc4?=
 =?utf-8?B?aXIrZHNlVHdWLzl6T05LWndhRzhtWTJMTCtMbFQ3c05QM2lFNzdmQVg5MlFO?=
 =?utf-8?B?ZjY1WVpSV2NmdHFHdk9kM3NvWk4zNGJxRU1xaHNiQm5sM2R6WDRjTVhHRzI0?=
 =?utf-8?B?MExCWUVUeUs1dVpzVG1SZVFtTGFMZTJmU1RocE0yNEEwcGxoR3MrZXV3bEJ3?=
 =?utf-8?B?cEVmQ0k1aHJWNk9yRTRZcGNXMnBsOHljQ1Y3cVNqYjVkWjNtbUZpd2QrR3o2?=
 =?utf-8?B?TFpIcnlDODlicnpmbzJQQ3NKM0NHWUpVVkQ1QmJyeVdFVGp3ZUVYUnVsREVD?=
 =?utf-8?Q?8pYzBCMCEb/y+k7Crk5o51Rna?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77b27d9c-06aa-4566-d84e-08dab7eed8c8
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 07:42:49.4893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xgmcFwg+9uEAHRroNzT/7B9wnAr/0YkWYcK4Fh3SK2f9jppLALTMZThtphDt12RjimbT8KuFkH8eNaPBiISuiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7511

On 26.10.2022 12:20, Andrew Cooper wrote:
> +int arch_set_p2m_mempool_size(struct domain *d, uint64_t size)
> +{
> +    unsigned long pages = size >> PAGE_SHIFT;
> +    bool preempted = false;
> +    int rc;
> +
> +    if ( is_pv_domain(d) )
> +        return -EOPNOTSUPP;
> +
> +    if ( size & ~PAGE_MASK )             /* Non page-sized request? */
> +        return -EINVAL;
> +
> +    ASSERT(paging_mode_enabled(d));
> +
> +    paging_lock(d);
> +    if ( hap_enabled(d) )
> +        rc = hap_set_allocation(d, pages, &preempted);
> +    else
> +        rc = shadow_set_allocation(d, pages, &preempted);
> +    paging_unlock(d);
> +
> +    return preempted ? -ERESTART : rc;
> +}

There's a further difference between HAP and shadow which may want/need
reflecting here: shadow's handling of XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION
rejects 0 as an input when shadow mode is still enabled. On one hand
that's reasonable from an abstract pov, while otoh it may be viewed as
questionable when at the same time setting to a very small value (which
will then be upped to the minimum acceptable one) is permitted. At the
very least this guards against emptying of the pool where active shadows
would be allocated from (which isn't a problem on HAP as there apart
from the allocations through hap_alloc_p2m_page() the only thing coming
from the pool are the monitor tables of each vCPU, which set-allocation
wouldn't attempt to free).

Jan


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:06:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:06:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430913.683192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onxu0-0003Zg-UC; Thu, 27 Oct 2022 08:06:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430913.683192; Thu, 27 Oct 2022 08:06:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onxu0-0003ZZ-RH; Thu, 27 Oct 2022 08:06:12 +0000
Received: by outflank-mailman (input) for mailman id 430913;
 Thu, 27 Oct 2022 08:06:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onxtz-0003ZT-79
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:06:11 +0000
Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com
 [2a00:1450:4864:20::32e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32ac2419-55ce-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 10:06:02 +0200 (CEST)
Received: by mail-wm1-x32e.google.com with SMTP id
 c7-20020a05600c0ac700b003c6cad86f38so3525703wmr.2
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 01:06:02 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 j21-20020a05600c42d500b003b492753826sm739610wme.43.2022.10.27.01.06.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 01:06:01 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 919ED1FFB7;
 Thu, 27 Oct 2022 09:06:00 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32ac2419-55ce-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=z1uurC34g6Qf9FWFyk2KxYKzqdHfrq68bhaSqBXYo5I=;
        b=voqhycX7azc3qkNmoaEI47DED1JheWSB5FvAWFHrw81a6fImlbnNBRSDIcvG9BExml
         26iN6aGZtpUIqliBs2HcdUXiCK9sCNgqejR09ardAtqfe1ldJOqYwTYhsy66h6AT59DR
         2e9VtXnRyyT2pb8OfQeq7gsEohoR/Vuh4xOVtgr4vsfmd6t55TrG2HE8urDAq/rk8hgy
         wnI0sfFjkvjadU1fAiW6KhI9kYv2eZsWFxUr9poXziE8F1XELnifCJiNpvsWne4sR0td
         2jDP3QSSJUfIwV5Wy0IznPBzh+7wPiFSIaFSWUWKoMtV23j+WIeqoVnVlMVQHW6rGVUI
         yRdw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=z1uurC34g6Qf9FWFyk2KxYKzqdHfrq68bhaSqBXYo5I=;
        b=cTZnfoI5t7azEMmCfBeRZhVWGRBa0vEyg9Ns5ZjgUzBkFlnQE6YG28Ye6GiI94mCVp
         7yACdVAO4EjIc1B/GxXqlQZrYeZmeSIIqvECJy3NDzqNQFnd9kZfVhjcd4a6xHeDDM5L
         PZQmTHi41r/ufyRrPKfYH4F2vdox7A/3E8toE1Lg/n571lyIsnb8YRpiaD540J1XAZEN
         iUSe1EEIWj07alzX+/9HgUIUZ6eEN+g+yVxtaU/LzRy7vLruTeEP/5W0vnOuq4ZN5CXb
         FZWiVKafp9Gkf7BMgm9nTiGWMKP9EDDrVY6PWAeRArydzZY0drXeHIygCEUY0euarraW
         D7ZQ==
X-Gm-Message-State: ACrzQf3wSbN7twdjz1lewJ3yRbH6sCnA9lm/gHdXPH+Tj467ao8NLGX1
	YX7KleR7An+2Gyshx/rb0hFSSA==
X-Google-Smtp-Source: AMsMyM5GL4qb1MFYnFCbiDZDc7xYJjB+hmZlm/UCDT+/BW/Bb1iQZ3miWz9BLFpOIdi8TqX2va0aTw==
X-Received: by 2002:a1c:25c1:0:b0:3cf:4dc4:5a97 with SMTP id l184-20020a1c25c1000000b003cf4dc45a97mr3556803wml.147.1666857961556;
        Thu, 27 Oct 2022 01:06:01 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Peter Maydell
 <peter.maydell@linaro.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Date: Thu, 27 Oct 2022 09:02:54 +0100
In-reply-to: <20221015050750.4185-11-vikram.garhwal@amd.com>
Message-ID: <87wn8l3d3r.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

<snip>
> Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, a=
dds a
> TPM emulator and connects to swtpm running on host machine via chardev so=
cket
> and support TPM functionalities for a guest domain.
>
> Extra command line for aarch64 xenpv QEMU to connect to swtpm:
>     -chardev socket,id=3Dchrtpm,path=3D/tmp/myvtpm2/swtpm-sock \
>     -tpmdev emulator,id=3Dtpm0,chardev=3Dchrtpm \
>
> swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on libtpm=
s and
> provides access to TPM functionality over socket, chardev and CUSE interf=
ace.
> Github repo: https://github.com/stefanberger/swtpm
> Example for starting swtpm on host machine:
>     mkdir /tmp/vtpm2
>     swtpm socket --tpmstate dir=3D/tmp/vtpm2 \
>     --ctrl type=3Dunixio,path=3D/tmp/vtpm2/swtpm-sock &

<snip>
> +static void xen_enable_tpm(void)
> +{
> +/* qemu_find_tpm_be is only available when CONFIG_TPM is enabled. */
> +#ifdef CONFIG_TPM
> +    Error *errp =3D NULL;
> +    DeviceState *dev;
> +    SysBusDevice *busdev;
> +
> +    TPMBackend *be =3D qemu_find_tpm_be("tpm0");
> +    if (be =3D=3D NULL) {
> +        DPRINTF("Couldn't fine the backend for tpm0\n");
> +        return;
> +    }
> +    dev =3D qdev_new(TYPE_TPM_TIS_SYSBUS);
> +    object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp);
> +    object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
> +    busdev =3D SYS_BUS_DEVICE(dev);
> +    sysbus_realize_and_unref(busdev, &error_fatal);
> +    sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);

I'm not sure what has gone wrong here but I'm getting:

  ../../hw/arm/xen_arm.c: In function =E2=80=98xen_enable_tpm=E2=80=99:
  ../../hw/arm/xen_arm.c:120:32: error: =E2=80=98GUEST_TPM_BASE=E2=80=99 un=
declared (first use in this function); did you mean =E2=80=98GUEST_RAM_BASE=
=E2=80=99?
    120 |     sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);
        |                                ^~~~~~~~~~~~~~
        |                                GUEST_RAM_BASE
  ../../hw/arm/xen_arm.c:120:32: note: each undeclared identifier is report=
ed only once for each function it appears in

In my cross build:

  # Configured with: '../../configure' '--disable-docs' '--target-list=3Daa=
rch64-softmmu' '--disable-kvm' '--enable-xen' '--disable-opengl' '--disable=
-libudev' '--enable-tpm' '--disable-xen-pci-passthrough' '--cross-prefix=3D=
aarch64-linux-gnu-' '--skip-meson'

which makes me wonder if this is a configure failure or a confusion
about being able to have host swtpm implementations during emulation but
needing target tpm for Xen?

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:25:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:25:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430919.683209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyCN-0006BW-Hv; Thu, 27 Oct 2022 08:25:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430919.683209; Thu, 27 Oct 2022 08:25:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyCN-0006BP-Ev; Thu, 27 Oct 2022 08:25:11 +0000
Received: by outflank-mailman (input) for mailman id 430919;
 Thu, 27 Oct 2022 08:25:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onyCM-0006BJ-6A
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:25:10 +0000
Received: from NAM04-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam04on2062.outbound.protection.outlook.com [40.107.100.62])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dd3835da-55d0-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 10:25:08 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CH3PR12MB7761.namprd12.prod.outlook.com (2603:10b6:610:14e::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 08:25:04 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 08:25:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd3835da-55d0-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T0tI6jApO5LhX/qOC5HjlxeTQw9VBwqEfwlmk0VTyiZN+GwQVfOL5+jMp0y92vUe5k0+fP1JL9tkoUwUZjdnOizYuytiro+5jff2KHVHbzRkpLr523xDd9pnve+TlZZSAQeDf9uVZM55+yT1ECeFmiubEfEfEuPWtWOP5iMQMXuf8EV65w1taNXuUk/d6r48bsFJq0zNntV5XJlzEAns2M8AC9VaPr9FKj/9OFqXNv2pV3ZLBoG3MsfzzJVgvdUdyKj+/EAQqLUyI8Ri74LGmcervuTIZM/ECBF+IK8itiKMKcKr6XzLk2wkGM5b4+fqn3f9u14Wp/3wLIwD9+UuGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OH7IXZw1AMVPEQ5w6E9UYFsjfRKvPnGCpMJ4+VuD9/g=;
 b=gAKLXDjT186qlUKQaMFzHhjXdQGmf1wcb+ZVrDhNoLNwgsqzfThBFtUV4JHZ9VzLT8cSYdFucT96cd0/YB8+gI7CguNgqS3R0TwcPVqBTEz1UFCN0Pe0Hpx+dsvk+b2A6jC5UBLqIGWld19RzOApBbxfS9Q9daCeNHdfi4hj2h0bi+32B/v/oyvD4/FBo4dRxzilwtwZHkpt2Ds50xLp6rL7RVUhewrczY4dV4KrpDEQMq3vafUM9z/Pi0XS2qEPCHGinRaQafmoMgcJalDol8QyfgAaglAiiPyVwaaCGCxlo0LhdOKgESltH4QExsqTUf8UsXe0k21uy3Z25Keibg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OH7IXZw1AMVPEQ5w6E9UYFsjfRKvPnGCpMJ4+VuD9/g=;
 b=myo4tjOjaHaGgSI5zOX/myPkYDU31LeL8WMoIdmlkzTv63MaR5xlv6HF+8PAqRhze7q4HYHtaFqiU3tSAL8MIBDL/J4JofKcQNOWgOkap9xlzgvyfzwSLMtTDTDeZE0BAXv2NZaV3r4gdfQYfA3KrY5zYe48h8GuluOCMK8bbEg=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <5367cdc9-3dc1-75a5-ed99-09cf24570705@amd.com>
Date: Thu, 27 Oct 2022 09:24:57 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 andre.przywara@arm.com, Henry.Wang@arm.com
References: <20221026183004.7293-1-ayankuma@amd.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221026183004.7293-1-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO2P265CA0431.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a0::35) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH3PR12MB7761:EE_
X-MS-Office365-Filtering-Correlation-Id: eadfa6a5-a801-4a9a-2981-08dab7f4beef
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oDeAKROVJMI2YDGoYlCLy9T0HL5lZgDCAuoP6WUj3jAu3xc/YQS/bYyx82ThoXJ4WdfnZcpzlE35Mw3/upN2n6nLscduyxRgk4Q9gTZQIeg/V2oeRZBc85Jidzo77ValrTWRZqzFYwlMhVgihUz2AH4DrnNDH1XpuXRMLyqP+OIZzGyotXKXdVroYTN8UMXhVQR5LWwInuNqA/iv2kCFi/u+ytTdxOy3R8Z7lBdtcu2U6O34zK1mpLWNWqV44Trif4rPh6DY9ibrLjvs3mlk3uCVpPvp/n2Oj3pXIue/nlhG6JcTy2Nn+b0Zd9SLXUOFv2dboHepbUHd+pomOgF4nU5te9Jj6XzdYE7S1gjsnebFhE4HaWO2BXvt9FRAnwXjBGhu0x3Cka32SvZThnvpAAFJibwe551SMWmZub2uVyDzXDjXNkxB0EkiZyhwBU1iWu+zxX2lG27TRVBO3iAl8wL3v93vJETUKxaDfNwyplyLS429z0MY6EM8Kp2DNQQUP9ltBEKWrc4ZgQ8nxuPjo7eaR6ZyMKEg13PP+4KH5b5pm9YkOdikjPXwLQJmY2UhIhij/mKD5grp9h/a029fzO3wX8cTR+dyf2RXsVreJUW/f0u2AWX4n2gyHu79Ka2FHX12kbfPfxw26kpV0hdZnaREVDvUWS+qcZQ7mBTswvWY3SKftpY4ozzEyBgOVSTGl/9mDY0uz0YL9+0cogKqjLKLht2S+50hFjYr3rVlcI9LFsgBl9DUSLh9gR3hemZakE1u3btVpCOo0hsLLRiz84LSibIQkXM7xRATWZUDKN0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(451199015)(4326008)(36756003)(53546011)(6666004)(66556008)(8676002)(66946007)(6506007)(66476007)(316002)(38100700002)(6916009)(2906002)(186003)(83380400001)(31696002)(26005)(6512007)(41300700001)(5660300002)(2616005)(8936002)(6486002)(31686004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y1VQWkFMZ0hOTWlDcGluQURPVloxakVocmJOU3MwNktSdXFuUU85c1gwQVVh?=
 =?utf-8?B?R01URU00WkJPKys2YzVvMDIyM0VhVm1ZZjBzTGY1VE15Nlp6TDdRdE5DSVQ4?=
 =?utf-8?B?Mmk1RU9sV0V0UENCQ1B6MVhkQnFSUm1KQ1dDU0grQUtOdXhYaFFET2ozemNm?=
 =?utf-8?B?bUtqTVR2YWNWL1dQWmhpNHEyaUhhZldxNGx3R1VodkdONm5tRDUxc3B4QTNo?=
 =?utf-8?B?aUI0OHB0Z2ZMaFpFVHN3eUFWYnhLNHUzNGFWWWtUak5xR2pBSVJYMGFSS2U0?=
 =?utf-8?B?YlJUQTdLRzZXcVg0RCs1alcvVkFEVHI2S0VFSW9OY2k1U0JOUXBPbFRPSjhI?=
 =?utf-8?B?alVmUGUxRGc0UU1ZN05zUExVVWUwTmZ5U0ZUMDhlRWhpYU9hZitVRHRmdVMz?=
 =?utf-8?B?UTRlNm5UbFExaDBacDFaUzFKdmFlRFJqNk9lY1IrYVQ3L205dlhQWUdRQ1RO?=
 =?utf-8?B?bmFWWTh2bzlZQi9wREtXZm5PRFc5cURQb3ZGRXY4NWVDZzVVK09nTlp4UXlV?=
 =?utf-8?B?UDNSdCtVd0RqSktpRUhFR1hUZlVjTngxcnliR1hLUmNmT2lwUWhSUkpUQ0s0?=
 =?utf-8?B?QlFvRGtSSm05Qm5iWmRJQU1hb0NweURCL0pjci9qVEhZeEt3ZXNFZ0NVQkFF?=
 =?utf-8?B?TmRDQ1o1SnJaWXJkTXhuSFo2NGo3SmtUYmlkOXRUVXU0ek0zU2RSQXE1ZlZQ?=
 =?utf-8?B?Q1ZlVThqZ0U4RFRPeUtrWVFWQmhyRVNqeEtUZmFrOCtwMC9OTG1SR09KVTVF?=
 =?utf-8?B?a2lVM0RXLzBqK1NoMDg1aDFKdEFheWhNNTkrTkdELzQzaHk3REdROTZRa0lV?=
 =?utf-8?B?dUNlYURPcHU4NExsYktYWHpXQjVEUXRsdzl5MnlLZTd1OU1EMjAzRENvR3NO?=
 =?utf-8?B?MnZFK2xHUHBEVW5jamVOTlZlTTdQQk5TYjB0TjVGTStya0FLR244M29nYW9w?=
 =?utf-8?B?Z0FjdnBPcy9KeWhrSUNzcklCbXR4ZUZYQXI3R3czWk9GK2hvN2tXaXVMNHM0?=
 =?utf-8?B?OEVVRUZDTnU2YzkyMy9KVi8zd0dLRjNsZDVHTzVJQmFUUW5rUndGVWpKWVBo?=
 =?utf-8?B?L0J6UGYrb1FDb0NrTnl5NEg0MENMTFNLeWhmTXpWQW5tekhsZnVFUHZSMFlo?=
 =?utf-8?B?Q2VjOERlM05qNjYxUERJcm0vaE0vTFl1bi9VYlhMb3pPWmxjQ0xma0hramx1?=
 =?utf-8?B?aGdoaitqNVFDd0hhcEIzVy9JNVZjL21yTHlISTNIUFVjRTFYRWFqN2tiV2dR?=
 =?utf-8?B?VXB1aUp0c3ZuaVIzZllwL0k2dnZTSFVBWVppWWlrTHZrdW1BWEZLTC81c0I0?=
 =?utf-8?B?a0Q0anhGeU9qSVdwcTJ1WUlWTzFodUVpZ0hmRS9KRUF6bmFjVHk4SmdydXlS?=
 =?utf-8?B?UDZ0RTRrZzI4L25WNnhwU2Q0TzFYNnh4WWFsTWIyV0JpT29nNmQxa2YvZEli?=
 =?utf-8?B?T1RzVXM1U3dOS21MK1ZmRitma1lEVUhsZEZiUVNmc3FCeU1PSFc3YllQcEY5?=
 =?utf-8?B?bXFHbExacUJtUmRiMXJZSHRqVloyRmpDNDN4SDg0RjhwZUc4MDJIV092bTNV?=
 =?utf-8?B?RUNvbmpDaExpZzZ3Zm5WSlF6SjR2eEFkVUdmdnBsT205blVpTzFzRWhkNGp6?=
 =?utf-8?B?SkdhYkRDQXlqZHJFcmhCb0dNUUhXUGVyV2tPVUVia093bFk3aGZtejlFYlFz?=
 =?utf-8?B?ak4vMmE5a3NMS0t0cys0MWZLUXpBN1B0MS9aeitDWWhNRmRMcEQ4SXNYQndK?=
 =?utf-8?B?S1ZVQld0dVI3Z3JnTnJOaHhyK0xrbjdjRVNnMkwrOE4vVDVPdHc5bTQxRE1C?=
 =?utf-8?B?RjIrSXhxSXhib0FuK1h1K0t5aTAxK0NIUnNtMkpPQmx6b2I0c29RazNiTktG?=
 =?utf-8?B?ekUvZldzU1lNbW5jdnBYYUNhS0d3OTl3MEVBQWl3L0JQNVB1SzBRQUJEUnMx?=
 =?utf-8?B?ck5adk44VXZPWEFSc3AyTE9WcDJRWG1ERURSblpSOUhVZXRJQnF2L0tFQmFT?=
 =?utf-8?B?RStSWUNyeWZkR3BIeFBPZWJlUVd5WjR0cUhYZE5SUFk5ZC9rVTM1U1ZKVDV5?=
 =?utf-8?B?OFhiZDRITXFDTFdVODc3aG4wVEJkUVQzR2RyYXNTQWJZKzZOeVNwQ2JEU3lu?=
 =?utf-8?Q?g+lgQ9VWzua6PUJEk+HmzZFvb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eadfa6a5-a801-4a9a-2981-08dab7f4beef
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 08:25:03.2875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OYA/ksGpXcZsgoA93gg9zZCSiXaM+WTa0zrgdkLsmepM0tI6Ag+o7deHxzt6d8hPYnAenKIFpRCfpDNNBKwjlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7761


On 26/10/2022 19:30, Ayan Kumar Halder wrote:
> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 64bit cpu register.
> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
> in the lower 32 bits of the 64bit cpu register.
>
> This 64bit cpu register is then modified bitwise with a mask (ie
> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
> 64 bit cpu register) is not cleared as expected by the specification.
>
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
>
> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
> v->arch.vgic.rdist_pendbase. The reason being v->arch.vgic.rdist_pendbase is
> now being read/written in an atomic manner (using read_atomic()/write_atomic()).
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and 
> property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
> ---
>
> Changes from:-
>
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> appropriate commit message.
>
> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
> v->arch.vgic.rdist_pendbase in an atomic context.
> 2. Rectified the commit message to state that the cpu register is 64 bit.
> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
> clear.
>
> v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
> in __vgic_v3_rdistr_rd_mmio_write().
>
>   xen/arch/arm/vgic-v3.c | 19 ++++++-------------
>   1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..1adbdc0e54 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>   
>       case VREG64(GICR_PENDBASER):
>       {
> -        unsigned long flags;
> +        uint64_t val;
>   
>           if ( !v->domain->arch.vgic.has_its )
>               goto read_as_zero_64;
>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>   
> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> +        *r = vreg_reg64_extract(val, info);
>           return 1;
>       }
>   
> @@ -566,25 +565,19 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
>   
>       case VREG64(GICR_PENDBASER):
>       {
> -        unsigned long flags;
> -
>           if ( !v->domain->arch.vgic.has_its )
>               goto write_ignore_64;
>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>   
> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -
>           /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>           if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>           {
> -            reg = v->arch.vgic.rdist_pendbase;
> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>               vreg_reg64_update(&reg, r, info);
>               reg = sanitize_pendbaser(reg);
> -            v->arch.vgic.rdist_pendbase = reg;
> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>           }
>   
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> -
>           return 1;
>       }
>   


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:29:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:29:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430925.683223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyG5-00070i-7k; Thu, 27 Oct 2022 08:29:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430925.683223; Thu, 27 Oct 2022 08:29:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyG5-00070b-3j; Thu, 27 Oct 2022 08:29:01 +0000
Received: by outflank-mailman (input) for mailman id 430925;
 Thu, 27 Oct 2022 08:28:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/85=24=citrix.com=prvs=2922bd7c1=roger.pau@srs-se1.protection.inumbo.net>)
 id 1onyG3-00070V-RY
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:28:59 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6603bbc1-55d1-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 10:28:58 +0200 (CEST)
Received: from mail-dm6nam04lp2043.outbound.protection.outlook.com (HELO
 NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Oct 2022 04:28:50 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BY5PR03MB5155.namprd03.prod.outlook.com (2603:10b6:a03:218::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Thu, 27 Oct
 2022 08:28:47 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 08:28:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6603bbc1-55d1-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666859338;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=1al4V9aql58lLJ4BEv43wMhhUd4KxPGWNzwiTheZMYY=;
  b=JZICqK2kBRk+FxBcU6uES3NAxXsdFVf2qsoxqpscFRufDAhUIf/VkYAG
   LrdZGmHZFppGFuvdEgVu0VxLiJ/TbhKrKgY/KFT396JQgSQ62R9KSx4ga
   xDpausyGD3qoeRhuXfUoWYKxMN0IvzPkdjhez90Y/r4eX4re8Nq34y0dZ
   I=;
X-IronPort-RemoteIP: 104.47.73.43
X-IronPort-MID: 86142609
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:TKofxq3Ukz+E7hja8vbD5cxwkn2cJEfYwER7XKvMYLTBsI5bp2cFx
 jRKXGCFOf+MYWv8e4glaYvkoEwOvZPRy4BkHgFqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt
 MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlH5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q
 e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ
 OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUxoOR4Qkpi+
 8BCazc0UwqDvN+42OqkH7wEasQLdKEHPas5k1Q4kXT1KKhjRprOBaLX+dVfwTE8wNhUGurTb
 NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g3O4/Zsi4TQ5FUZPLzFKt3ad8bMXcxItk2Zu
 njH7yLyBRRy2Nm3mWTcrijy3r6ncSXTR7kZT6OG1eVWsFytwFMCFzIOWEOGmKzs4qK5c5cFQ
 6AOwQIQqqw1+F2uX8PKdRSyq36ZvTYRQ9NVVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0
 V2ElM+vAiZg2IB5UlqY/7aQ6D+3Zy4cKDdeYTdeFVdepd7+vIs0kxTDCM55F7K4hcH0Hje2x
 C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2NNo55xmuVvLKYWrE=
IronPort-HdrOrdr: A9a23:Lgu1pqtCjrc9CLFEmJBdtRtr7skC7YMji2hC6mlwRA09TyXGra
 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79
 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M
 323Ls7m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w
 3+CNUZqFh/dL5pUUtDPpZxfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou
 WLbG9l
X-IronPort-AV: E=Sophos;i="5.95,217,1661832000"; 
   d="scan'208";a="86142609"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fDsVVMcQetVsfrfId0rGXnEz6rRWuIEWsJ4QSZC6lmLltrbVI592wwpCuRb4MWBTXZOuRqjUbslKXAgGcCyVsX6pqKgASVzfQ6fcgKd4K/g+f41JPqR2Ya6x8b7es+UwV7fc4kdldGQ6ADRg7fWdvCUDhvGOScJAjhqK6OXaU6GdV4MFaqq9mfbGvCbUDfuu0p6lFPwbjGz68JYdQIzijWtQOK8n8a4EaWfUsRqh0MZksrEGo+Ov7lnTKYZ8uy+GaZ7yIViuI2SxpeNCjcPPc9XoPXsKPw7W2E9FGnqhqrc7hF4GRunwuTI4CTiNuLkL+q0xNa+tDdQwtQvXgrEJxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ihzRX2EHOxsWK9NFlyRyNHT1aB0apNihdVZIYBismeE=;
 b=F+UzD3YPtZvYEPZgLdkhVeXLM/+uVXPMhmsCfIEnIE+dmwGqBltTm08PGrRm5EbWzeMb0tBH+VIlyOn8/CWEzLhnzS6iqqntX74pivmpHQ4XHHfb4Lv77jDmWD0J0n8Ffrs2onIXCpMf9lp7wFs/igUZLuRTc85FzB9LViMMyxopSRVgyDnVgJUze5DWAgwmaLwX6j+IwP3LCsKeDnngCYyEZQFipMtgHxQJst/Gm/woqcOsMafPzfwACyKr8xiPChnpXcbI2YltWPFpmZg6MD21i+HtdchqerLPpLifAIMxWlfFD7Nq1BVmtiBZ2iRgvcCa1ePU4azmBpKmccRWZg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ihzRX2EHOxsWK9NFlyRyNHT1aB0apNihdVZIYBismeE=;
 b=WgnfQGmShtOqoSYc2Ztzc7UAtMGKksA5jlfY7vRBokGuTBkZVfUb84TH5Q6jREprOvxW2yaEZVDiBxYmWOBoSgCi83DgXUmPfwolHS9EHN0RsVIZH93WH5W+uCNrSt/I5GA0YKjuUFROv5JWdq3a8Xvn8uI0RIdx+8YcwWyglog=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Thu, 27 Oct 2022 10:28:41 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Message-ID: <Y1pBOZjzJ9JhUc+c@Air-de-Roger>
References: <20220718211521.664729-1-volodymyr_babchuk@epam.com>
 <20220718211521.664729-5-volodymyr_babchuk@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220718211521.664729-5-volodymyr_babchuk@epam.com>
X-ClientProxiedBy: LO4P123CA0525.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:2c5::8) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BY5PR03MB5155:EE_
X-MS-Office365-Filtering-Correlation-Id: baa23697-e7cb-4f1b-d425-08dab7f54463
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vgI6asxjahYK5eD/qlbbupAcsOgF5lFL6NWc9lF3azuIcOWLg64hXCYJbNMHXG5x3ozbFYbfm0k9oApRDGtHBVNdUUYWCGcIbFabCAlcLiJuByQWbnTLkEqPwkVj8MbBaTumxSZixSKO7so1JB89/V0WY4MLd95TnLUmt6i4nbysXQ+YQ7L8NArFWz/+raT5c3RLgqL13wIBGNETE2nvZvXbUsnydDfpJaeGjHH1vqHob3wixbQucgw3gnBBkLlmhzNPRw3u/01WvRQ9dxuTj14BZp4249OZ0JoYNspZ/fl14cqUCDTKll4PtmGvui3vhJ/ooDOpBG+6xpr/CYV0qCLh4St1FK9PvEyjJG89AC7BTuolFCQ2KE2wSxw1yzfFzxow+Y4NXhYFYsaawlrXylMiXyoMcTWVDBSVt1L2gvnJGO/C6PT2HoRohJadu3n09gDACmvwcfQMbKy/y7YxZJKEiinBm0uOAlSJH3axo3AgO9gQmgirYMFUU2GgNmQkIlienJAws9cz5cy6R87FbPfoogteMIZQKRtgxcJ7ybnJnKXZEJ7w7FOUCRXOTbqZ4tj9quTVv2jXNznf6zwG0QfZsE2jRkuuOfbUFD0P294oVkQQ9LDswIVAP8kFWJJeZn60Af6NiwHT6lyl6/UsMTEey5VLd2Up7f+rb4wVGHdmgcc2cZbZibOkh7HaLL7cIvcZ/GD5kqBOmupAPMXkb7PyY2khUuPqXAN0FnBlff9D9OMDuWBKNgY9d68xrSFV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(7916004)(366004)(376002)(396003)(39860400002)(346002)(136003)(451199015)(6486002)(38100700002)(5660300002)(478600001)(4744005)(66946007)(41300700001)(66556008)(4326008)(8676002)(66476007)(86362001)(8936002)(82960400001)(85182001)(6916009)(316002)(33716001)(186003)(6506007)(2906002)(9686003)(6512007)(6666004)(83380400001)(26005)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YWhQREV1bXRCa1IxcXdsWEhGOWVWOVFreU5WcU5MWVFBUDVjS25mblZOOGFS?=
 =?utf-8?B?b0JYVWMwZDJNZ3dORm9scWEyOGxQTUxrRnJNQi9uK1hHWTJnWnZCaWs5Mmtx?=
 =?utf-8?B?SnkyV2dDdnZoTUQvblpsNWREeDZvMHcxRFpBZnJRU1VjK0lBQ2U4bW5VaFpK?=
 =?utf-8?B?d2FZZENlMW1uTFcvUVJyOHc1b0VlTGx1OWdsNzBxdy9xVWJSWG41ZFJTZnc4?=
 =?utf-8?B?bmhXNDVYS0pGVFliZ2ZwNXZKUXlaQXF0eG02VC9iMEp1RlVQTXc5VUxhZkE0?=
 =?utf-8?B?UnRsTk40RjFWRXkyZmV4RnUra1lTbmtvazJWa2g5THVwOThlbm9IVTlVek1C?=
 =?utf-8?B?UjNCNERjR3lEbXZvQTdzaUVGYVdKdGZqK3RZSWoweUo1ZGtWNnJ1MGFpMHhZ?=
 =?utf-8?B?cURlU3FrWWl5a0lqa2MyTUsvSk1BM3BCSitUclJOaTBBakRSejNLMDNjM2E0?=
 =?utf-8?B?Vk5udUZNZ2k0TlBTTk9RZGJabjdsN0FYMFZCVndPdnJYQUtrYy9nZ0xBUU8x?=
 =?utf-8?B?eHduUVRGK05JengzSG80SU5ubjZhRVBleDlUclNjaCtTUUFReWovRjJSU0V3?=
 =?utf-8?B?MXE0MGRKRUVQclBwUjcxVVN6Sm5McjNnejltWmJHT09HZGJ0TzhtMHdkei9v?=
 =?utf-8?B?S0RIYlpXYjNiZzdpQWd0Q1hpSDZHMkFRZDhkY0lrb01LelZOa0JiT3llVmxJ?=
 =?utf-8?B?cDFsOHI4MnpTQ2FlSzF1cDBzblZLZnkrVCtwSmJadFhQR1lWL3ZOSnNnbFJk?=
 =?utf-8?B?VWw1Slh0STMxOTRER2I1T3MrQTR2aGxOZ3FFU05ObGs0eTBydzBPSFU0OUVP?=
 =?utf-8?B?TFloUVpnN1RxR3AyUkR3VHdteGtvNE5iUHU0KzY3eGFxZ0JUU0FYWXgxajdl?=
 =?utf-8?B?SWFVMHNBN3JOUUdiNjQ3WU9nUkZZdDFOZkpmdUdWbDFlclZnOEd1WUI1R1RP?=
 =?utf-8?B?b1NaWkZjdmJXWjdPeVpFenFDdXZjbE5PYWJWUnpabHpPOEFyUDFYWlgxSi9O?=
 =?utf-8?B?OUFGU3I2bVRKWXpZRXp0Y0JJcDR3cUtqU3ZhaUZ2SnE1c0RjQ0dDMytJU2xN?=
 =?utf-8?B?WFU0aW1NZzhvc2lXRExVaUNGSEpVK0VEcWMyLzZjd2FZNUVzZUpjb2pJRjZD?=
 =?utf-8?B?RjRnVUk1TTJqTVh6ZU9UdGxRckxsZFdFeHdwRmcrMThVcDJrSDZlZ0l4WGp6?=
 =?utf-8?B?dUZXbWpETGppcnVWYzVqVzhjSmZleFJtbFpYaTBGaklXVXNFTWZKWXlXTnM4?=
 =?utf-8?B?dmkvclBhbE8vZ3FYcC9oSmdJVmRLYUp0QjQvYThHSDduL05hL3JqdFlNMUJT?=
 =?utf-8?B?cG5XeXVnT1REL3RsMXhoTEF4cmlXOHp0LzZuVjR5SDY1S01tc1RrZHN3MFZh?=
 =?utf-8?B?eit6eEJFdUFwa0MwY1lBTWVnakltS3NSaTZKcENHUlNhL2VXcEdjNGVQYjVa?=
 =?utf-8?B?Vk4zVk94ZDBmSU1LUFdyYVUwb0ZlNFN0aUtHZzFYc0diU1JaQ3R3NGNVaVNu?=
 =?utf-8?B?Q1hVb1B3Szk5YzhlOFQralZHOVVTRHVITU9HSTR0Sy9RKzZURktWV3lHOUd1?=
 =?utf-8?B?UGdwbUFLZldrazhTTnZBRUhJSm9jVXhkdkhGQ25oRFZ3VUpPRGhsYmNZOCtu?=
 =?utf-8?B?UXEvbUhmdkxWN3c1RGdQMGRXTVF6STI4SnlXd3lHT0dpQkRsckdpc3VTbGkr?=
 =?utf-8?B?cFV4NEppY3NHOTE0cUxEbStFZERURDZiMXk2OTZuNUcrOUZCNmVOY0VCcmg0?=
 =?utf-8?B?Z2dGUEl6NDRNS2JpeWJlRlZud1F2TE5jdnMySmFuSWUzUklWNXNqNzNCVHBO?=
 =?utf-8?B?cWtKSFRDWU1Pc1VvaUxkaloyZUxMRlVzRGEvVlVlemdMMDRveElPZjlnOHNl?=
 =?utf-8?B?ZktmeTkyVXBKQmZBL3Z1MEtDZ2lyT1o2dDNLM1p6WnhhTGcwSFY4OWtpVE9H?=
 =?utf-8?B?Zkw1NHFOd3I2T000Z1RDRjI0a1Rpa3hSK3phaWY5blN0Q0VjR2tDYkV4MWxa?=
 =?utf-8?B?NzQycHhneFBjTGU1b0FXN1JpY2dCeGg0Ny96RUoxWmZtWHh2REhrY1YxYkNy?=
 =?utf-8?B?SHB4NUlUc3FOdkRVa1huT3lNSHVrUDRXaERVWFVzc0ZPbytlUUpmcXNsZmor?=
 =?utf-8?Q?+VTPEcvlKZb0jaolf9jdGxJ+3?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: baa23697-e7cb-4f1b-d425-08dab7f54463
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 08:28:47.0172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zrZJdYoR+k5hbyHaqoBi0ZZyW/rpYERZP4mPs+eajsRBaPtd/kNWH0ORHUOfMqcKXky/hbRvFeZJO0KqlTcTuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5155

On Mon, Jul 18, 2022 at 09:15:43PM +0000, Volodymyr Babchuk wrote:
> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
> iounmap(), but not added corresponding include.
> 
> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> 
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:40:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:40:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430933.683236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyR3-000129-7Y; Thu, 27 Oct 2022 08:40:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430933.683236; Thu, 27 Oct 2022 08:40:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyR3-000122-4k; Thu, 27 Oct 2022 08:40:21 +0000
Received: by outflank-mailman (input) for mailman id 430933;
 Thu, 27 Oct 2022 08:40:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onyR1-00011w-PR
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:40:19 +0000
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com
 [2a00:1450:4864:20::433])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc5b42be-55d2-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 10:40:18 +0200 (CEST)
Received: by mail-wr1-x433.google.com with SMTP id bs21so974143wrb.4
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 01:40:18 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 j8-20020a5d6188000000b0022e035a4e93sm577041wru.87.2022.10.27.01.40.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 01:40:17 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 14A9E1FFB7;
 Thu, 27 Oct 2022 09:40:17 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc5b42be-55d2-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=R72+Byta0ggcrMJ6pBTu9gVKHwUiTbM3bM47Lj1VcUQ=;
        b=HJlW3B32rhTSgzGTIOUVtz3GcIr3wQ2iIN+gBHqCt37IeWfGIH/zx6qei95qNQ9BLm
         eiMZBODbD1UuQh+xkhOJEAxbdPJQMcDMhd3ZUHEnCRCXPaIEjTqUo/EmfeoBiHF+D7Qw
         Fjs5wnHRrmccTQj969nhrxFP6OdzV6GlAuZ/8oN+1eysfp0hZcDydVlyx3InFhvURDCx
         g85iXDodk2UXc7jpZSqgHOpqxxr++Vd0lF8ewq9/RPPr4j5Vu/9Ss6zFYY9AURbRsIkP
         0BFT3Pms9aWDVXXXe1FGVPoKrTt9RdSMCgLRG6LS4Ph91RTHMCf9loKxmYIROzgVhH0M
         l++g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=R72+Byta0ggcrMJ6pBTu9gVKHwUiTbM3bM47Lj1VcUQ=;
        b=H8+4OGrtEQqNJByWhxDjAsWMr7K+fq3EsW+Y6knxLxcaIzHzDr85ZBDrAi8BUYbBYY
         DH63C7e5YDbFU3896PReahh+klU2+j+KbjLHn8CW+n/1QE0VTCjgeAfJg+H82z0S9n7E
         J8h6u25QqH35q5iYjs0upqMBJ43rvN8Jfjq2oinHCdc0QzAaeTPMD0scrnFwc2z5yk5d
         34I0VA+GqEgUpY3MwxQ1CFwBlnm8kmBofPNx1Ma1t+O/Yh99MciM0QsTAlJBLsWYyyaw
         nhXoKOgs8mT1raLxU5I0h4eD1MEHpLfxY4nZyKG/JGw+oD/HIoAFMvHfO8UyYQAhEpvF
         snUA==
X-Gm-Message-State: ACrzQf1JQRBi39CNkt2R1q8QyQDugAZF3PVB8zoQF+GY5RienTFz2E1L
	nxzJ29x5xgzRtds79JE+cBZaQA==
X-Google-Smtp-Source: AMsMyM6HkxGVNKU3Muav/IfO9FnY3SnVzozajd22rOaY8YCyg60SONqAX76DzqXaqnJTZPQ29Yxfuw==
X-Received: by 2002:a5d:6185:0:b0:236:776f:2bed with SMTP id j5-20020a5d6185000000b00236776f2bedmr11491996wru.535.1666860018100;
        Thu, 27 Oct 2022 01:40:18 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com>
 <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Julien Grall <julien@xen.org>
Cc: Vikram Garhwal <vikram.garhwal@amd.com>, stefano.stabellini@amd.com,
 Peter Maydell <peter.maydell@linaro.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul
 Durrant <paul@xen.org>, "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>,
 qemu-devel@nongnu.org
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Date: Thu, 27 Oct 2022 09:37:43 +0100
In-reply-to: <3e504b1b-197d-b77b-16e1-86530eb3d64c@xen.org>
Message-ID: <87k04l3bim.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Julien Grall <julien@xen.org> writes:

> Hi,
>
> There seem to be some missing patches on xen-devel (including the
> cover letter). Is that expected?
>
> On 15/10/2022 06:07, Vikram Garhwal wrote:
>> Add a new machine xenpv which creates a IOREQ server to register/connect=
 with
>> Xen Hypervisor.
>
> I don't like the name 'xenpv' because it doesn't convey the fact that
> some of the HW may be emulated rather than para-virtualized. In fact
> one may only want to use for emulating devices.
>
> Potential name would be 'xen-arm' or re-using 'virt' but with
> 'accel=3Dxen' to select a Xen layout.

I don't think you can re-use the machine name and select by accelerator
because the virt machine does quite a lot of other stuff this model
doesn't support. However I've been calling this concept "xen-virt" or
maybe the explicit "xen-virtio" because that is what it is targeting.

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:41:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:41:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430936.683247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyS2-0001YZ-Hz; Thu, 27 Oct 2022 08:41:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430936.683247; Thu, 27 Oct 2022 08:41:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyS2-0001YS-EZ; Thu, 27 Oct 2022 08:41:22 +0000
Received: by outflank-mailman (input) for mailman id 430936;
 Thu, 27 Oct 2022 08:41:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onyS0-0001YE-Lk
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:41:20 +0000
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [2a00:1450:4864:20::42c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 20db39d9-55d3-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 10:41:19 +0200 (CEST)
Received: by mail-wr1-x42c.google.com with SMTP id j15so989869wrq.3
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 01:41:19 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 v16-20020a5d43d0000000b00236733f0f98sm524419wrr.107.2022.10.27.01.41.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 01:41:18 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 61DFE1FFB7;
 Thu, 27 Oct 2022 09:41:18 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20db39d9-55d3-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=ciO9wzqDJBohEQ8HfojpLhNd+QMTSlu+YI/hytMwZ1w=;
        b=v0mfmniZbpC86gyjj1j07A1k6oA7cmZVznvQ8L6eMMYweqS64J9MxRroVRX6sC6Rna
         RB2HBJ+2hFZAM3XUBxk46pPy6DgNre5qZAm5n60d+ZGoPeT06fFE0pCrAN2Mwypy7A0y
         ULufsH0Efl5YYtPwDt3rTMEW8qJ6Hrz+gPopoTbFrKGx4V4jks1cTjoMlX7aADaNTC/m
         b7vkfRpl2hOtjynlFt9aPjV8fSPrkIY3uzc8/Ed8fihn/px6Ue8u84fjPqLhMkJWEsQU
         C5VYQpmSLBypHTZUeVfDuZUe0B1KVIVmvB78f18RVPTc5N6lhKfPFGbjVm4FPqZPWh5D
         ntfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=ciO9wzqDJBohEQ8HfojpLhNd+QMTSlu+YI/hytMwZ1w=;
        b=3/I+ERsYLYEfbONasNA96/QKWEGr6++i0uVr9kCXFLvacjOWkpDNylvLvcj1dxZzoe
         T0SZ6794XP0DND5LYrgm8QX6vQH4DBzHXHD2D1ixIttyNbbs5kYP7ayCatb/a7RmERJ5
         lxRev8hEciiS6KMmmJOAAr/uSklBNWjZNaH7Y0kHBNJ2vs3xNB9yV6IdhMZcMN79LrpT
         wN5tABv3q3cLxaeHpumEYiU/MbQLG7uY6Fc3D+RvtdvjltAWglhcvhjAllMdN1cNjeTg
         pqBsAeqSQ134EoXtVDVANuxbJBftVQcjd+Dh26CWioTI+r4VY630/BuSmgkdXTXyHPoF
         Fe2w==
X-Gm-Message-State: ACrzQf1gkg7yPy9qCG4On+QiCeiDqqwrfWMj5yzAg9HKYfpMrDq0zY5y
	RGCQBHlgg31bxxmfuVdeiHbfHg==
X-Google-Smtp-Source: AMsMyM638r8gzQZMR8CORrK9O03zbBgnd6gqJhp7ycsjV8TfmSVTN7UJj+OFIHVG8gJkH2fYp2m0xA==
X-Received: by 2002:a05:6000:22f:b0:236:4f8e:a913 with SMTP id l15-20020a056000022f00b002364f8ea913mr22270263wrz.240.1666860079283;
        Thu, 27 Oct 2022 01:41:19 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Peter Maydell
 <peter.maydell@linaro.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Date: Thu, 27 Oct 2022 09:40:20 +0100
In-reply-to: <20221015050750.4185-11-vikram.garhwal@amd.com>
Message-ID: <87fsf93bgx.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

> Add a new machine xenpv which creates a IOREQ server to register/connect =
with
> Xen Hypervisor.
>
<snip>
> Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, a=
dds a
> TPM emulator and connects to swtpm running on host machine via chardev so=
cket
> and support TPM functionalities for a guest domain.
<snip>
> +
> +static void xen_arm_machine_class_init(ObjectClass *oc, void *data)
> +{
> +
> +    MachineClass *mc =3D MACHINE_CLASS(oc);
> +    mc->desc =3D "Xen Para-virtualized PC";
> +    mc->init =3D xen_arm_init;
> +    mc->max_cpus =3D 1;
> +    machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);

This needs #ifdef CONFIG_TPM because while doing --disable-tpm to try
and get the cross build working it then fails with:

../../hw/arm/xen_arm.c: In function =E2=80=98xen_arm_machine_class_init=E2=
=80=99:
../../hw/arm/xen_arm.c:148:48: error: =E2=80=98TYPE_TPM_TIS_SYSBUS=E2=80=99=
 undeclared (first use in this function)
  148 |     machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);
      |                                                ^~~~~~~~~~~~~~~~~~~
../../hw/arm/xen_arm.c:148:48: note: each undeclared identifier is reported=
 only once for each function it appears in

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:59:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:59:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430943.683264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyj5-0003Yu-1n; Thu, 27 Oct 2022 08:58:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430943.683264; Thu, 27 Oct 2022 08:58:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyj4-0003Yn-VT; Thu, 27 Oct 2022 08:58:58 +0000
Received: by outflank-mailman (input) for mailman id 430943;
 Thu, 27 Oct 2022 08:58:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onyj4-0003Yh-8l
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:58:58 +0000
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com
 [2a00:1450:4864:20::433])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 965a1505-55d5-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 10:58:56 +0200 (CEST)
Received: by mail-wr1-x433.google.com with SMTP id o4so1038462wrq.6
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 01:58:55 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 l3-20020a05600c4f0300b003a5f3f5883dsm4481191wmq.17.2022.10.27.01.58.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 01:58:54 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 5F8721FFB7;
 Thu, 27 Oct 2022 09:58:54 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 965a1505-55d5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=HlK9CJNg/9rsUzm71jPR98pXYeeVDstCpBqW8I8CNA4=;
        b=YlBXV8QXZlvjUNP3tQKPHYVepyIjaF5Ovz4hkGV6jofMtO534xsxbsnmq6f+9bBqyd
         3RjepHNx//neEJS3lSvYWkgnSl/ktz4y4m+m6LkbFuLEaYl5Qh/9+EonuCS4zxLcGNdc
         2c9mpfGEN1ETOTQyg4pjyKL7qbQjn0I5lQMVSolifACzLyERYo71Kp+6q3ZQZPvfdmFi
         jhska+a4iIZIo/WweOmG/+ryJ4B/VlslraCZ38sOBZ2GQgf9OXmBXUgluNA/O7ajMnjh
         OwH4dxDl1T1z9MOoJE89gqhlsJLL7SgpytBP+i8mmw4yar70tD/yMvLd6CceMozyvQqa
         LObA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=HlK9CJNg/9rsUzm71jPR98pXYeeVDstCpBqW8I8CNA4=;
        b=ox9seih/K2f5BstFLIFP0aOk4e/UN66G7h6I8GzrOCkLknpkS8DI6Fj0Dn0fpv2EJo
         bd0aLTCcVl91sYs/Sk1ntgCZrL6c5puIAnm1XXh6bZ8jLQLwHRcym8HmwxiqTYFu0F/2
         pVG+7fj5w1ry10hd8Y6oNHqEurbK1HD6ZRvYI7dmwIzzv7BNW6/5MOVcYUDdQ3zLnHP5
         nt3a6FuOW6GGYSE8dTWKe6Ls+wQYM7ub5sMGEF7i1kbKt1hzBPxBoMTyBAyeUxxHWEV4
         p12TbHA1a/Rt2DDkc/bLbWxYPWXz5Yr4VtgwDr5kyWaMZPPFLeJiuaNjwTMwyXhgZQ/x
         Oz7A==
X-Gm-Message-State: ACrzQf1kRHf25uakcyJAEfi4Q6AZi+hFO+77ZQYw9UnnrQ/Nobk7/2mE
	jg1z+zrSxES9DVxeC/jLtWNnqA==
X-Google-Smtp-Source: AMsMyM77tWKKcuvcrigafDwCzk9KcKoAesgG7RQROTl8z9x/JYo0weCt44sLmZ+v0mNPt8YKddDXpQ==
X-Received: by 2002:adf:d843:0:b0:236:6231:113b with SMTP id k3-20020adfd843000000b002366231113bmr17057263wrl.42.1666861135337;
        Thu, 27 Oct 2022 01:58:55 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-9-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Stefano Stabellini
 <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul
  Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 08/12] hw/xen/xen-hvm-common: skip ioreq creation on
 ioreq registration failure
Date: Thu, 27 Oct 2022 09:46:47 +0100
In-reply-to: <20221015050750.4185-9-vikram.garhwal@amd.com>
Message-ID: <87bkpx3anl.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

> From: Stefano Stabellini <stefano.stabellini@amd.com>
>
> On ARM it is possible to have a functioning xenpv machine with only the
> PV backends and no IOREQ server. If the IOREQ server creation fails conti=
nue
> to the PV backends initialization.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
>  hw/xen/xen-hvm-common.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
> index f848f9e625..7bccf595fc 100644
> --- a/hw/xen/xen-hvm-common.c
> +++ b/hw/xen/xen-hvm-common.c
> @@ -777,7 +777,11 @@ void xen_register_ioreq(XenIOState *state, unsigned =
int max_cpus,
>          goto err;
>      }
>=20=20
> -    xen_create_ioreq_server(xen_domid, &state->ioservid);
> +    rc =3D xen_create_ioreq_server(xen_domid, &state->ioservid);
> +    if (rc) {
> +        DPRINTF("xen: failed to create ioreq server\n");

This should be a warn_report to properly inform the user.

> +        goto no_ioreq;

Maybe pushing the rest of this function into a local subroutine would
reduce the amount of goto messing about. Other candidates for cleaning
up/modernising:

  - g_malloc to g_new0
  - perror -> error_setg_errno

> +    }
>=20=20
>      state->exit.notify =3D xen_exit_notifier;
>      qemu_add_exit_notifier(&state->exit);
> @@ -842,6 +846,7 @@ void xen_register_ioreq(XenIOState *state, unsigned i=
nt max_cpus,
>      QLIST_INIT(&state->dev_list);
>      device_listener_register(&state->device_listener);
>=20=20
> +no_ioreq:
>      xen_bus_init();
>=20=20
>      /* Initialize backend core & drivers */


--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 08:59:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 08:59:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430947.683276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyjx-00044P-Bm; Thu, 27 Oct 2022 08:59:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430947.683276; Thu, 27 Oct 2022 08:59:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onyjx-00044I-8m; Thu, 27 Oct 2022 08:59:53 +0000
Received: by outflank-mailman (input) for mailman id 430947;
 Thu, 27 Oct 2022 08:59:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onyjv-00040u-VX
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 08:59:52 +0000
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com
 [2a00:1450:4864:20::42b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7506f95-55d5-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 10:59:51 +0200 (CEST)
Received: by mail-wr1-x42b.google.com with SMTP id bp11so1025477wrb.9
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 01:59:51 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 bk13-20020a0560001d8d00b0023677693532sm677875wrb.14.2022.10.27.01.59.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 01:59:50 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id ADB0A1FFB7;
 Thu, 27 Oct 2022 09:59:49 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7506f95-55d5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=cWc8ZuMg1/+4qY7rzQF6w0oVRg1s+VU5bhsmROUresc=;
        b=m8SHq17GnllkBzLDUI0cKBCBnxw6KxFC9Ew/VVss/SVAL1xT33ju7XxARfhhxBJTP/
         Bi+Ad/ZO6vO+eHqqf0djGURQU0mtyMkaYXFC56Xuiy16rGesbE7R+XDyaQM7d1RQVXYs
         GDqIhZ6Bh5Q2408HR+ubCUseqtvDu2bryVc56pA24T7mUC+inICP08T3r+wxsG/Sqqn1
         eA2csEKTBvORv0wj6/oMtzHHai7ge39PjK5LDCsJaLLm7tGMyR3PY0tQ767IjZqwLP7p
         hHeScuyZBFRvQuZiyugO/0KVayETNq6lUpc97R01mVOV6PBDxR0ggTPtegu1QkpsVgMM
         mUCw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=cWc8ZuMg1/+4qY7rzQF6w0oVRg1s+VU5bhsmROUresc=;
        b=irgjFOalnGQB/nnSFvjjNQWB4KSdcdwcSgK/C1L1DJIuCYx++NHJv56s1Df7JDJmrb
         NWGKGcm8y2yZHNisjSTlgGTTjiWHQXMMk6MxUdL6UAoGO+iRk453JK1Vy4sV+nGs0zHN
         dL7PeM7aMRr9Ldvkycp3inYNDV1pLU8MimiITk072l4epmrEYEzcgKvJ8+ZBSNgovwDI
         Xl8p8ydyryeLO+0pb90EZy+tiy0R5x44zITmWaNmYSPo9Dtu5LkMbXf49yAKEBoUy1Sm
         tvjZEIoJCFCraYxIT0eBiSOe+4ZtC22LV8f7hXlsEYK2NOZFjRjlmJGme/exJ+mErijg
         6PjQ==
X-Gm-Message-State: ACrzQf2nYB51bTBcKxMdufY62jRT68n2tzH8EeN6XcE6soFykJrvCjC2
	N9M1ZKTVLLzaUBleUVcxkT9rgg==
X-Google-Smtp-Source: AMsMyM7E352cvnvKVOaC8nFGoKrvYv8reHvdCXxgeuwBf1GvlE6shsatQzuA8/P+egWBRVhCR6tHpA==
X-Received: by 2002:a05:6000:18c7:b0:22e:5503:9c46 with SMTP id w7-20020a05600018c700b0022e55039c46mr29775755wrq.668.1666861190719;
        Thu, 27 Oct 2022 01:59:50 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-5-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Stefano Stabellini
 <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul
  Durrant <paul@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel
  Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini
 <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields
 out of XenIOState
Date: Thu, 27 Oct 2022 09:59:44 +0100
In-reply-to: <20221015050750.4185-5-vikram.garhwal@amd.com>
Message-ID: <877d0l3am2.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

> From: Stefano Stabellini <stefano.stabellini@amd.com>
>
> In preparation to moving most of xen-hvm code to an arch-neutral location=
, move:
> - shared_vmport_page
> - log_for_dirtybit
> - dirty_bitmap
> - suspend
> - wakeup
>
> out of XenIOState struct as these are only used on x86, especially the on=
es
> related to dirty logging.
> Updated XenIOState can be used for both aarch64 and x86.
>
> Also, remove free_phys_offset as it was unused.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>

Reviewed-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>

--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:01:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:01:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430952.683286 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onylZ-0005Z5-SS; Thu, 27 Oct 2022 09:01:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430952.683286; Thu, 27 Oct 2022 09:01:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onylZ-0005Yy-Oo; Thu, 27 Oct 2022 09:01:33 +0000
Received: by outflank-mailman (input) for mailman id 430952;
 Thu, 27 Oct 2022 09:01:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onylY-0005Ys-Gt
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:01:32 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f21dd7b1-55d5-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 11:01:30 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM4PR12MB7527.namprd12.prod.outlook.com (2603:10b6:8:111::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 09:01:27 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 09:01:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f21dd7b1-55d5-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ftU+HrbBEXE7Fyn9WUzrecZKPG/9J1SMJVYq/1ZAi6Q4/BBZN4KMRXw0LqH6ljsFAlBI3foJvAnjwjFVZRFr+8v2N3nsQLf6mIO8147dWRlsJ4IM+ZPAU06iTyVnoHtt34MlCuyKbZWOyRh5J0t5jt7BJG7oFSjTaovEV6wFOpnz9SEQxW76KdIi8ec0hZDQawOJDtkvOYnX1ZEl+Hyuv0Fb65tp/joSJtVvxDHTeNotAdkmfgnvt0aEJS4AtX6AsDi5nHowWT9OCTbujigoyuSFQ45SE0aAWSRylV/CDqw022gWRhfFznsNpT2nFJDLFN1FahVemLci7rhh51z8AA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QCNgseUlavDw11utYCVKkqM59r1bvjXmnK53anDayQI=;
 b=EK1FQgNVJPinQD1YzfARDNlHOPkGPCwkiRUmQigSNhhPRYYOA77xRGp1UmBLq5hl190s2jFbfFOY8j0NBSUOX0uInUJlnMP74R9A5q3VMatl/5/ZmMunTzKRjuCanS1/X9FaJrF96kiM25ERiwYvEP6oHh+ts/E8Aea2guAGzh7wQjtbxv7lgAGMW3OvCzcrkXHoEoQ3lwKDd/yQCpfOVLce3RKhP9NotrUoLDgJ8ZUT4kZ7hVirCmajkL/3R5PBiRMFaPjHylct4VOZ2y6UzzUXGB5x39or80eR2USJKrxkzq5knDPCEcaIajW+U6gsWjE/ri+9t1md43e1xU2VZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QCNgseUlavDw11utYCVKkqM59r1bvjXmnK53anDayQI=;
 b=yTc42Z1SLokPfEvW/NtJMqAYKgNDTUWJ0imv/FuroiABluw83Imyomk8LAS0q6eeVvaeZSpbwkjfK5fzRBUOWIdy1CC+Sll2AJ2vLLt5JQM5v04Gx3fGI0OA3Rw/13RlQVhS9l4VKEt560nTDGQ/72S1i90gZs9ZnGKsoATjXFQ=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <00baa14d-59bd-e106-23c8-b3f151f19eca@amd.com>
Date: Thu, 27 Oct 2022 10:01:20 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
To: Rahul Singh <Rahul.Singh@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO6P265CA0022.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2ff::17) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM4PR12MB7527:EE_
X-MS-Office365-Filtering-Correlation-Id: 5b361a48-0496-479e-a360-08dab7f9d4f3
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1i4vhv3AicknXum+ZI1FK6O+mzn0oqXtamyEu+pO4iW4lVDbKBPkK4DobHmLiGVfPAT/9kSUFDTM9OI+n8UDG3vcGv86LaJQiq7prEcY7M8SbdY0fta4pmm7DB9LvdFb/7Ng9UYxINUX8uRbVEtTEkgC+SX+bgoUfCIpnBW6ylJJ+BD2pE2DsOQ2WGMrUmmSux9/XzuwFPtk/eHzFq6uCRl/wMB8h6wxs7yKbMs4xXZws0heTdWr8yJOuBTho+HyAMVZgYozsnaFzLcbVmQu/WlZSpdNWyjqHt7b5xQpE0BguP8uZP6z3KtjKdkfbCCQHgku1o+g5X6eiLAghv0yJb6whoH8F0jkEniMSBQdOH80NNzP1+kPaZUdON45V9O/SjiTW1c2F2F0SF9aWBOrAd7uxxERVHYXyZoXLr0TJEPpFI/0Zhw3Wk3fcvbLfepcOzg4d9r5xCdRfyeg+uA2f5WcvPwfusD1n5amD1SOY3elgcrATkLpMzC0AHbB9vxPvOEW0kuSqd/1AEER3mlf6BpWbRnMdVcbzjBqRUu771OaRpRprZ0CC7sxgdzow/ByUAGA+mt/hMLXs+VA/n0Iui7Ut272+5mpfa/7BaQYcJCw3FKwvclyXEOhiQilVf78oA0jK1IYC+waN55EfBvn1r1r/82ssqqx9elObHKTK0/B5h8P0U9s/kv9j1G+Uyfd5Gmq2SqOQpRDM8ehT5aCgfUE925Y2vAOZfTO3ekdLRH64YqhaY41CIcTXmGw2Zo6aTYWwp/O5zGF87cJ/BMdfLBs4rPSOSt9+TtHg9YpUgffJ3XH6xmTqec+KERVDcw/xeilX/Oqb9mIy1D4inJu71eBxWNyFCbOOL0gTI2y0UM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(396003)(366004)(376002)(451199015)(31696002)(36756003)(31686004)(38100700002)(5660300002)(2906002)(7416002)(8936002)(83380400001)(53546011)(186003)(2616005)(6506007)(6666004)(26005)(6512007)(66556008)(54906003)(8676002)(478600001)(66476007)(110136005)(41300700001)(6486002)(4326008)(966005)(316002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bE1TMmR0OUJ6REViSUl5Q3J5Zkh4SmJ3MDdtMWpFUlJ3NWlTSzZaVWtnaFZY?=
 =?utf-8?B?UG9uSjE4ZE5TTHpXRGliNS9oWVE0YWt5TEw1UW5YeDBnS21kS1QxT3VqSE5a?=
 =?utf-8?B?MkFiTlJKTlhBd1JHZlFMR2VtYU9vNVhTL1lKdFNTZEZhZTFXVEh3SDdDaWps?=
 =?utf-8?B?QVQ2ZTlXMldyMWF1c2w2Zlc5S3NOU0d1R1JWS0xiZU1ENzhuZFRJdnRpNWtr?=
 =?utf-8?B?MmIrb2l3MERsSWEyYTcwdjZSZGltMEpYUExGaDQxNWhtRFg0YWVndFh2eWZP?=
 =?utf-8?B?M2l6YkFjejVTZjAwNVlPNU4vZVBLWDRwd2RpcmNTRzBsZWZwRlVCWkFqTlUy?=
 =?utf-8?B?ZHZGbXFKMFcwWUc3RFBkcStVV1duTkhnTGFrNkM4MHV4dHRneTZXUjFxdCtU?=
 =?utf-8?B?L2RXT3FnZVRKd0NYZ0NsV2dYa2VmSXMzNHhpc0I1VlNsMytMZXUxN0d2REZM?=
 =?utf-8?B?d1VKd0UzZzM1NVRIK1hTWnNvekpDbkFUQURDU3FJNHIrMkNaMVJHSFd1alh1?=
 =?utf-8?B?SVVla1VnUjY0VVdmQnowNitNR3ZZS3lXU0ZmaTdmQlcrSXp1SjFERnNLdDcx?=
 =?utf-8?B?bW5ZbWxac3EzUDZJb0xROVlZeFAzcllRd3ZrYzZoVjZJRkRVZ3ZvcGcrT2ds?=
 =?utf-8?B?T2tyV1BOaEJjQy9mU0VZeThGSEN4SjZ3ZEZ0b1RWaW5VblhrYUxYTlEyRVJw?=
 =?utf-8?B?VmpJTFhRRGEybi92b3NFQ3VvMzdYS0FTRGVzb2h5alplMXpuTE5hbUdQMGJn?=
 =?utf-8?B?TFNZLzRTY1ozd2poQ3ZTdjFOcjJqeWpLSnRNekgyeVdYcDAzWUNnR3IzbUFn?=
 =?utf-8?B?UjRQL3lDT2g2Q28vbTFXZmV6TnBxWTNyVElyWHFTdE53WHF0MTB4VmsvSEtC?=
 =?utf-8?B?bEl6TG00ZnA5dXltSytOR01hN0luZ3QrS0oveHA0aEFoY1pETnFtaWludldX?=
 =?utf-8?B?aFVnTENFQWk0T1NURmlkZGd2alJqRHBGMW5sNUVJdmpQSkQ2MlpOS3V1U2VJ?=
 =?utf-8?B?K1Y0Qm9JNkh1RFpXaGhkY2dUYU1vMzBSQllxZFVNa1lhQitkMUVvQ1VJL3Y0?=
 =?utf-8?B?SEJTRWNYTitLTklEREs1VThPTi94Mi9ndGMrQmZzUnJTb0JVMXU1T0sweE14?=
 =?utf-8?B?THZDWDEvdTF3RUNGRTkyM1ZCaFZvMUQ3YnVlS0JUUERDUm1UNnltUnVZSzNx?=
 =?utf-8?B?bi9USkFaZUVsUFVtRUdPNEs4QzJ1ZnVRb2MwczYrRkdiajVJUVVuSG5nK3pT?=
 =?utf-8?B?eUdyNktpMmgwaDNSS1MrQ0JKNjlkMUs1VFdhdUpKaTFzOTc0aU1mWGI2Q05G?=
 =?utf-8?B?cWwrZjZFN2FreG1CSUYydGlXRThWM0ZjUUYxckZScXRBbXlKc2Y1MkFyN0hG?=
 =?utf-8?B?UVVZaytyNFdINTEwM1JlR3lZamlZT3lXOXZDaExpMVFiRTVENWN2NzZzc0hE?=
 =?utf-8?B?S3RHY3hiTmNOSHU5UTQ3ekU2Zjc1NUlsbkJ4WGVMVk5DdCtWTVcvbWQ3RWI4?=
 =?utf-8?B?RlRoL3VXNGRqUUF1WWlWZG5YOFRWUWUvOEI5RndRUGEyRWZQbmQvUFBCdE4y?=
 =?utf-8?B?VGkxZ2x0VWpIVy9qY3dHSXQ1U1dnZGVGQXRidnN6bmdtRXh6SXFjOStadEVw?=
 =?utf-8?B?M1lqTTNHVEpuVG5RZlhxTGlWdGxzWjdLS3BHM3RPK3lYOFg4MTNzM2pUdXU5?=
 =?utf-8?B?VG9salNWOG5lVjMxUnNETVIzS1NsNjgyc2c3dW04OUpyTmk0ZTY2S1ljYnpD?=
 =?utf-8?B?V05pOUNCTnI4bmdaaXB3NUo0cmNwYTRxYU81WHVoS0xXRXFFcHgzaExxOThy?=
 =?utf-8?B?Q0djWnZkNEE1NXh3RlNybEx2WERhUDVEZ1pvSk1UZEdNNlFVMVowbUIvRFlU?=
 =?utf-8?B?dUJqTzh0cEhjS21qK1JmNVlWMG5mUndOZ2FSTi93cThaY0NTSkVOVlp1RzVW?=
 =?utf-8?B?eE52a0ozYUxKVU1UOGlYc3FuRURNUU1xTTdTdDUrdWxhZTNtWnNWcnVqQURm?=
 =?utf-8?B?UjNER2FPOEl1dXEwUkk3OHk0TExKOGF6aS94Smw0S3g4Yk0rVmh0N2xmaEND?=
 =?utf-8?B?NitxTTBVb1ZIb3ROMmc1V0hRRHlncTlVSE1OdjBGSG0vVWNudk8zWlFQQjAr?=
 =?utf-8?Q?l+JVmcpkdL6naME5bqmyMvnF7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b361a48-0496-479e-a360-08dab7f9d4f3
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 09:01:27.6166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jq+UTOPkL9xaFLuCHIghJqiDRnOE2/afn2+THass6NXjbR1U/g2t62lwiHj+WgsDEtcOYyDrip9dpHjh10YR4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7527


On 26/10/2022 14:17, Rahul Singh wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
>
>
> Hi All,

Hi Rahul,

I have a very basic question.

>
> At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3.
> To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the
> device to the guest that is behind an IOMMU and virtual IOMMU is enabled for the guest there is a need to
> add IOMMU binding for the device in the passthrough node as per [1]. This email is to get an agreement on
> how to add the IOMMU binding for guest OS.
>
> Before I will explain how to add the IOMMU binding let me give a brief overview of how we will add support for virtual
> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 Nested translation support. SMMUv3 hardware
> supports two stages of translation. Each stage of translation can be independently enabled. An incoming address is logically
> translated from VA to IPA in stage 1, then the IPA is input to stage 2 which translates the IPA to the output PA. Stage 1 is
> intended to be used by a software entity( Guest OS) to provide isolation or translation to buffers within the entity, for example,
> DMA isolation within an OS. Stage 2 is intended to be available in systems supporting the Virtualization Extensions and is
> intended to virtualize device DMA to guest VM address spaces. When both stage 1 and stage 2 are enabled, the translation
> configuration is called nesting.
>
> Stage 1 translation support is required to provide isolation between different devices within the guest OS. XEN already supports

Doesn't this imply that there is support for Stage 1 translation for 
guests ? Otherwise, how will the guest provide isolation between 
different devices or dma-masters ?

- Ayan

> Stage 2 translation but there is no support for Stage 1 translation for guests.

> We will add support for guests to configure
> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU hardware and exposes the virtual SMMU to the guest.
> Guest can use the native SMMU driver to configure the stage 1 translation. When the guest configures the SMMU for Stage 1,
> XEN will trap the access and configure the hardware accordingly.
>
> Now back to the question of how we can add the IOMMU binding between the virtual IOMMU and the master devices so that
> guests can configure the IOMMU correctly. The solution that I am suggesting is as below:
>
> For dom0, while handling the DT node(handle_node()) Xen will replace the phandle in the "iommus" property with the virtual
> IOMMU node phandle.
>
> For domU guests, when passthrough the device to the guest as per [2],  add the below property in the partial device tree
> node that is required to describe the generic device tree binding for IOMMUs and their master(s)
>
> "iommus = < &magic_phandle 0xvMasterID>
>          • magic_phandle will be the phandle ( vIOMMU phandle in xl)  that will be documented so that the user can set that in partial DT node (0xfdea).
>          • vMasterID will be the virtual master ID that the user will provide.
>
> The partial device tree will look like this:
> /dts-v1/;
>
> / {
>      /* #*cells are here to keep DTC happy */
>      #address-cells = <2>;
>      #size-cells = <2>;
>
>      aliases {
>          net = &mac0;
>      };
>
>      passthrough {
>          compatible = "simple-bus";
>          ranges;
>          #address-cells = <2>;
>          #size-cells = <2>;
>          mac0: ethernet@10000000 {
>              compatible = "calxeda,hb-xgmac";
>              reg = <0 0x10000000 0 0x1000>;
>              interrupts = <0 80 4  0 81 4  0 82 4>;
>             iommus = <0xfdea 0x01>;
>          };
>      };
> };
>
> In xl.cfg we need to define a new option to inform Xen about vMasterId to pMasterId mapping and to which IOMMU device this
> the master device is connected so that Xen can configure the right IOMMU. This is required if the system has devices that have
> the same master ID but behind a different IOMMU.
>
> iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
>
>          • PMASTER_ID is the physical master ID of the device from the physical DT.
>          • VMASTER_ID is the virtual master Id that the user will configure in the partial device tree.
>          • IOMMU_BASE_ADDRESS is the base address of the physical IOMMU device to which this device is connected.
>
> Example: Let's say the user wants to assign the below physical device in DT to the guest.
>
> iommu@4f000000 {
>                  compatible = "arm,smmu-v3";
>                  interrupts = <0x00 0xe4 0xf04>;
>                  interrupt-parent = <0x01>;
>                  #iommu-cells = <0x01>;
>                  interrupt-names = "combined";
>                  reg = <0x00 0x4f000000 0x00 0x40000>;
>                  phandle = <0xfdeb>;
>                  name = "iommu";
> };
>
> test@10000000 {
>          compatible = "viommu-test”;
>          iommus = <0xfdeb 0x10>;
>          interrupts = <0x00 0xff 0x04>;
>          reg = <0x00 0x10000000 0x00 0x1000>;
>          name = "viommu-test";
> };
>
> The partial Device tree node will be like this:
>
> / {
>      /* #*cells are here to keep DTC happy */
>      #address-cells = <2>;
>      #size-cells = <2>;
>
>      passthrough {
>          compatible = "simple-bus";
>          ranges;
>          #address-cells = <2>;
>          #size-cells = <2>;
>
>          test@10000000 {
>                  compatible = "viommu-test";
>                  reg = <0 0x10000000 0 0x1000>;
>                  interrupts = <0 80 4  0 81 4  0 82 4>;
>                  iommus = <0xfdea 0x01>;
>          };
>      };
> };
>
>   iommu_devid_map = [ “0x10@0x01,0x4f000000”]
>          • 0x10 is the real physical master id from the physical DT.
>          • 0x01 is the virtual master Id that the user defines as a partial device tree.
>          • 0x4f000000 is the base address of the IOMMU device.
>
> [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/iommu/iommu.txt
> [2] https://xenbits.xen.org/docs/unstable/misc/arm/passthrough.txt
>
> Regards,
> Rahul


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:02:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:02:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430956.683298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onymr-000693-5h; Thu, 27 Oct 2022 09:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430956.683298; Thu, 27 Oct 2022 09:02:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onymr-00068w-2d; Thu, 27 Oct 2022 09:02:53 +0000
Received: by outflank-mailman (input) for mailman id 430956;
 Thu, 27 Oct 2022 09:02:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onymp-00063g-L1
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:02:51 +0000
Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com
 [2a00:1450:4864:20::436])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2273c41b-55d6-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 11:02:51 +0200 (CEST)
Received: by mail-wr1-x436.google.com with SMTP id z14so1044702wrn.7
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 02:02:50 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 h9-20020a05600c314900b003c6f3e5ba42sm4398779wmo.46.2022.10.27.02.02.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 02:02:49 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id 35F5B1FFB7;
 Thu, 27 Oct 2022 10:02:49 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2273c41b-55d6-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=gM2J/iqTtZ3YgqXFapPxeERaDYDYuEVYIvE6ZdrIy9I=;
        b=P4fzATqIK/XTtT0SwdCeHEj68hQhUg6RdI7HtcK6qMvs3dSGlkaBr6LEX77yl6EI/r
         XO/5KunxRBzjWMkWmdkKf/WwNI9tZ9W/b7Z3/aWOyfSzbfiM6CX3ug05Z3nXrothXzM2
         RuIwj0wqxdAp6EHFTKqMF2xJdTaRwuigrZkWuCoZIUPME+kCc8BigF7wsGdnQMQIxzir
         SzEFto+/8kk/zLkHHpEGIB955GgC4FddAqh68uYAk1Q3kKBwcT8QZuRk27twW0L7641T
         JsvpV4MZe6GwYGPDf2nnP0ZVoYxe6ggIEjZg4C4dL/uiDk744UjhCKNaUkX7zh0I92UE
         uG3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=gM2J/iqTtZ3YgqXFapPxeERaDYDYuEVYIvE6ZdrIy9I=;
        b=cq2mQ+XUjiLRjZIhCKMMQJN8dYtED8u4Q890rRUAXe8BwkzoizdzDXEK83eOTvUmdl
         2AkfaQdUcNfCbrEw7E1GZr8Qrbe1IGKKTE0E2oPu7vwEwCroUIvKzSm6YvbeS9d1h34z
         g0twzbEV+AvRFEEGivUVfeXB3GjKp2L7aTq2t44VRwX3fP9YNwC1n1o3OjX7jd8pLqPx
         I3XDvDw9pDHCbZXBMGEwgFZbLXhrgRL+x4oMzRm8D+oPf0U07YL90WgqZ2O6KYKKjTie
         L7oo6+wat+JbJTweKkh+AIlkXOO8PZEr6nXYJFhGbml/eJANEJCCd/GsRix3XP+Ne4Mu
         sxqg==
X-Gm-Message-State: ACrzQf27/V4nNgL4vIry2Kt1gN2ahagbTbB1tGYI2llDApEJax1D5+vI
	fX5DgWrvVqt0AhAze7IzzMuZKA==
X-Google-Smtp-Source: AMsMyM7NiReiU4Tji7TAd7yKY3oQyuqn7T2/B8HNKEp77ib6k8oevwdOdjLwtI1IR331sr0dKLUHQQ==
X-Received: by 2002:a5d:58d7:0:b0:236:6c53:6123 with SMTP id o23-20020a5d58d7000000b002366c536123mr15253547wrf.719.1666861370324;
        Thu, 27 Oct 2022 02:02:50 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-6-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Stefano Stabellini
 <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul
  Durrant <paul@xen.org>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel
  Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini
 <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq
 and arch_xen_set_memory
Date: Thu, 27 Oct 2022 10:02:04 +0100
In-reply-to: <20221015050750.4185-6-vikram.garhwal@amd.com>
Message-ID: <8735b93ah2.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

> From: Stefano Stabellini <stefano.stabellini@amd.com>
>
> In preparation to moving most of xen-hvm code to an arch-neutral location,
> move the x86-specific portion of xen_set_memory to arch_xen_set_memory.
>
> Also move handle_vmport_ioreq to arch_handle_ioreq.
>
> NOTE: This patch breaks the build. Next patch fixes the build issue.
> Reason behind creating this patch is because there is lot of new code add=
ition
> and pure code movement done for enabling Xen on ARM. Keeping the this pat=
ch
> separate is done to make it easier to review.

But you do intend to squash the patches for the final version? We don't
want to intentionally break bisection.

Otherwise:

Reviewed-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>


--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:24:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:24:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430961.683312 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onz7b-0000VQ-UZ; Thu, 27 Oct 2022 09:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430961.683312; Thu, 27 Oct 2022 09:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onz7b-0000VJ-RD; Thu, 27 Oct 2022 09:24:19 +0000
Received: by outflank-mailman (input) for mailman id 430961;
 Thu, 27 Oct 2022 09:24:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uk3A=24=linaro.org=alex.bennee@srs-se1.protection.inumbo.net>)
 id 1onz7a-0000VD-HO
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:24:18 +0000
Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com
 [2a00:1450:4864:20::42d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2128c7d8-55d9-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 11:24:17 +0200 (CEST)
Received: by mail-wr1-x42d.google.com with SMTP id y16so1100318wrt.12
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 02:24:17 -0700 (PDT)
Received: from zen.linaroharston ([185.81.254.11])
 by smtp.gmail.com with ESMTPSA id
 y16-20020adfd090000000b0022ae401e9e0sm625789wrh.78.2022.10.27.02.24.16
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 27 Oct 2022 02:24:16 -0700 (PDT)
Received: from zen (localhost [127.0.0.1])
 by zen.linaroharston (Postfix) with ESMTP id BF57E1FFB7;
 Thu, 27 Oct 2022 10:24:15 +0100 (BST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2128c7d8-55d9-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:from:to:cc:subject:date
         :message-id:reply-to;
        bh=jDTjrVScAlJawu8O4rOrl/s+z1ctwZBTr4dK/zNh2kk=;
        b=dbNT40tpHaizjJf90K0GLRgx8AmjLic8rHnbmqMrjgOlq8louULOewrNvFFSM7M+gT
         gTKv82My1kp9pHHyoX4vCyyoJcswugjNnJE2qecfdl0nwsN5wBHgc+wx//mUT2tuXP7B
         D304uZejigrgCcEwBike5XRZEFdRCpnQxgIzOpvsQcevPVm0NljDNWpJ0f47KyC9GVa5
         otETWhh6XPk8F4jgRTWVNBtZk33/iOltNy502agfrectvcogqiK9X4ZdMhTv0/SKoQg2
         Fe++HYepBuBZ1o5gYSS71EPctyq+G1zIM7jxgEiRAiAbPMfqt3vj2jqiLqHqCzrBVVQY
         3mqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:message-id:in-reply-to:date
         :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=jDTjrVScAlJawu8O4rOrl/s+z1ctwZBTr4dK/zNh2kk=;
        b=ik4CGNpVPu7HTLFgjCw1bs9ktPZQBOVDRoAagxGYbGBkTSrCAw6lVmE9fk/0UsyRAS
         QSoTbtpgt8Mb+BL/rw9h3qLuVcVYlaNF11uopg0ykkW1BmNMga3SaUNv3sQ9N55zZTwI
         vCmhk3zarzk4raZPL4fE2JE/aANS+7Nhi5AwRuhDqyC7tanjNIRH7PicRLpow73ipgwd
         3y8Vj3Wbj4tBHjLgtKvaqpQUmlvY7J77JDIuUd2cWX4g4OkGe/kIAMD/eiEmXrJs/+1x
         oWyxTzWWkZjFOR2PHOhAaHA4//yeIh0rjZVc2H5CTz/hygRARbrd/Ni8xY0r5dtxY4R4
         AWeQ==
X-Gm-Message-State: ACrzQf0KbDUikTDvKor2GPeu3kNTtr4E5H/DDypJWDlg5KdJB+7bBnu7
	U0OS5z9jEYALKvQ/0Odj39pXIg==
X-Google-Smtp-Source: AMsMyM6N4jvLFy+y/t7rQnlbUN+Se1FB5PabUpFJR3tGTSgQmy2PSOfE7OmGVTDLLzGAeL4+arSrKQ==
X-Received: by 2002:adf:b646:0:b0:221:76eb:b3ba with SMTP id i6-20020adfb646000000b0022176ebb3bamr30840721wre.237.1666862656717;
        Thu, 27 Oct 2022 02:24:16 -0700 (PDT)
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-10-vikram.garhwal@amd.com>
User-agent: mu4e 1.9.1; emacs 28.2.50
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
To: Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com, Stefano Stabellini
 <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, Paul
  Durrant <paul@xen.org>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export
 xenstore_record_dm_state
Date: Thu, 27 Oct 2022 10:14:40 +0100
In-reply-to: <20221015050750.4185-10-vikram.garhwal@amd.com>
Message-ID: <87pmed1uww.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Vikram Garhwal <vikram.garhwal@amd.com> writes:

> xenstore_record_dm_state() will also be used in aarch64 xenpv machine.
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
>  accel/xen/xen-all.c  | 2 +-
>  include/hw/xen/xen.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
> index 69aa7d018b..276625b78b 100644
> --- a/accel/xen/xen-all.c
> +++ b/accel/xen/xen-all.c
> @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev *c=
hr)
>  }
>=20=20
>=20=20
> -static void xenstore_record_dm_state(struct xs_handle *xs, const char *s=
tate)
> +void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
>  {
>      char path[50];
>=20=20
> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
> index afdf9c436a..31e9538a5c 100644
> --- a/include/hw/xen/xen.h
> +++ b/include/hw/xen/xen.h
> @@ -9,6 +9,7 @@
>   */
>=20=20
>  #include "exec/cpu-common.h"
> +#include <xenstore.h>

This is breaking a bunch of the builds and generally we try and avoid
adding system includes in headers (apart from osdep.h) for this reason.
In fact there is a comment just above to that fact.

I think you can just add struct xs_handle to typedefs.h (or maybe just
xen.h) and directly include xenstore.h in xen-all.c following the usual
rules:

  https://qemu.readthedocs.io/en/latest/devel/style.html#include-directives

It might be worth doing an audit to see what else is including xen.h
needlessly or should be using sysemu/xen.h.=20

>=20=20
>  /* xen-machine.c */
>  enum xen_mode {
> @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);
>  void xenstore_store_pv_console_info(int i, Chardev *chr);
>=20=20
>  void xen_register_framebuffer(struct MemoryRegion *mr);
> +void xenstore_record_dm_state(struct xs_handle *xs, const char *state);
>=20=20
>  #endif /* QEMU_HW_XEN_H */


--=20
Alex Benn=C3=A9e


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:27:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:27:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430966.683326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzB3-0001K4-EJ; Thu, 27 Oct 2022 09:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430966.683326; Thu, 27 Oct 2022 09:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzB3-0001Jx-BE; Thu, 27 Oct 2022 09:27:53 +0000
Received: by outflank-mailman (input) for mailman id 430966;
 Thu, 27 Oct 2022 09:27:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onzB2-0001Jr-48
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:27:52 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onzAx-0007k3-ON; Thu, 27 Oct 2022 09:27:47 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.29.62]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onzAx-0005Ho-G9; Thu, 27 Oct 2022 09:27:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=UHRBdzlTPR3+OCLd5Z6IF9G+cuWbPl24uwslqhVE+cA=; b=EZisDwA7U8MHqIXjJXikHJlQFF
	l+NXPcRRQEdyie4DRwt0Q9jtDf94uW7eVqB6yDPLjZDhJT51HoJzWXMFW69aPXaMIbnMgrd8KCC9H
	z0mzTKMzgM6UTW2Yiwk4WAsHcEh0kurNWZDPpifk4Q+xdxkldIQyXgw7AizOaoyHwg58=;
Message-ID: <00912a7d-ae12-703b-de24-e64359774a07@xen.org>
Date: Thu, 27 Oct 2022 10:27:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang
 <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Andrew Cooper <Andrew.Cooper3@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
 <4c713750-670b-eac1-5f5b-376de79192eb@xen.org>
 <f8c5cebd-06c3-2a8c-737c-c6bd6544f95a@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f8c5cebd-06c3-2a8c-737c-c6bd6544f95a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jan,

On 27/10/2022 07:56, Jan Beulich wrote:
> On 26.10.2022 23:24, Julien Grall wrote:
>> On 26/10/2022 20:22, Andrew Cooper wrote:
>>>>> --- a/xen/arch/x86/mm/hap/hap.c
>>>>> +++ b/xen/arch/x86/mm/hap/hap.c
>>>>> @@ -345,6 +345,16 @@ unsigned int hap_get_allocation(struct domain *d)
>>>>>                + ((pg & ((1 << (20 - PAGE_SHIFT)) - 1)) ? 1 : 0));
>>>>>    }
>>>>>    
>>>>> +int hap_get_allocation_bytes(struct domain *d, uint64_t *size)
>>>>> +{
>>>>> +    unsigned long pages = (d->arch.paging.hap.total_pages +
>>>>> +                           d->arch.paging.hap.p2m_pages);
>>>> Unlike for Arm no ACCESS_ONCE() here? Also the addition can in
>>>> principle overflow, because being done only in 32 bits.
>>>
>>> I'm not actually convinced ARM needs ACCESS_ONCE() to begin with.  I
>>> can't see any legal transformation of that logic which could result in a
>>> torn load.
>>
>> AFAIU, ACCESS_ONCE() is not only about torn load but also making sure
>> that the compiler will only read the value once.
>>
>> When LTO is enabled (not yet supported) in Xen, can we guarantee the
>> compiler will not try to access total_pages twice (obviously it would be
>> caller dependent)?
> 
> Aren't all accesses (supposed to be) under paging lock? At which point
> there's no issue with multiple (or torn) accesses?

Not in the current code base for Arm. I haven't checked whether this is 
the case with the new version.

If it is suitably locked, then I think we should remove all the 
ACCESS_ONCE() and add an ASSERT(spin_is_locked(...)) to make clear this 
should be called with the lock held.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:30:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430971.683337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzDU-0002jo-Tz; Thu, 27 Oct 2022 09:30:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430971.683337; Thu, 27 Oct 2022 09:30:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzDU-0002jh-R5; Thu, 27 Oct 2022 09:30:24 +0000
Received: by outflank-mailman (input) for mailman id 430971;
 Thu, 27 Oct 2022 09:30:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1onzDT-0002jb-H8
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:30:23 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fab800a2-55d9-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 11:30:22 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB8PR04MB6937.eurprd04.prod.outlook.com (2603:10a6:10:113::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct
 2022 09:30:20 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 09:30:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fab800a2-55d9-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FT1jVnzscm3tSLwup7cYDdbeIMVifWFSIq3ndt/1CcAyHNxKmwu9sGcQwTNhvwM+b902P3qlf/QUm4l3mWbxhc21FG44QKA1rlT0zNLp9v+iFIzvJIDnb550bcV+TljZsdDDXHzOxSntpofwWH4uK/QZC3Xw23fKl047xh4dyrzU+gKjnbkE+eKTT5dTrW8FocjbiSzSdbUVcNpREfpRN42ZRghHqxVXfjl1y3xazmKQQ0qw75LOAqr1opUyg1HkF8JlDQrY2rhoUa4kebCZEI4SOQx9sCAuQEa6nP6Ve0gGjTHCtKsUvFLKBvj3IjhaX3hRqV8zJXlCKDcNfWqm/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3fVNj437jzI/xD1iuWJLwxgq7AmGh6GmaXbh4vWkAGo=;
 b=XuWuC2h6WMuRe2rozFbPwybEoxN7UXN6wBIl36vOtDFNWotR3TKg0yHS+Y9LsF5eODKaGup5G4qOqzaMs40UWMlW/hd5xypr4C9z5ULvCvLfIeX3CcCf2MW8LiLd8lOM6zjGmnDL7IC6eI8rUZLJy6aQi6RzNQQsSA1V6QwAmOZbJ4w/dunKH7jKeq6EB/CxBeDRxascXTyKuhWpHTjVxbD9OzQtWUrWC7gzxdWnj/TkEoqHBQGS7JJADSCy91ClYgHDbUuBm0YjFL2JEGl6AqOFw/LP0Tdx19lVpbuCSEtclC5Y3hpDwUfGgd/5TDKSk9GLqP2FPtnwc7S81QotTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3fVNj437jzI/xD1iuWJLwxgq7AmGh6GmaXbh4vWkAGo=;
 b=eiJ+7crLRj5nwEs+2LuH8Fg9lRxPNYItKLy6yViXsr7CAri8HkEotSU+EisCQn89TvJQ2Vw1UXMgqT9cLJRPclAg8i7sAURE8ejyhyS7iN3paWFaPDu2HAxPood5kMi3SHLpqxiM8ffKGrjuyIwhkzyzTNTK5rtJ8SzpA9ISU2cZHU4wfnZ0tmvfC5C6gES/zQyk5tK4Ls9HCOIZzjzg83eOmQexMXhB47zJHSmR4KdFcrupWAFdm2gBpQEdzIjrAsA0WZDOecTIDlAs7gEIw7Vdp4vdisVAzoeb4gp2TRRfwYKhJ0nDmvA9r85gkjTgewhxrZ0y/v0R1/63w34ocw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6a6df9c5-a527-63ac-60ec-fe7f3b6fadbd@suse.com>
Date: Thu, 27 Oct 2022 11:30:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <julien@xen.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Anthony Perard <anthony.perard@citrix.com>, Henry Wang <Henry.Wang@arm.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH][4.17] Arm32: prune (again) ld warning about mismatched
 wchar_t sizes
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0023.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::36) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6937:EE_
X-MS-Office365-Filtering-Correlation-Id: f67363ae-8470-40ad-a6dd-08dab7fdddf1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7VdIH37ExBgwAr49rCoL6hKq5KRahjjUMZuHn62Qxtf8OrIuI3awFSvZOlFS7BYhqaOfo2PbCBXmtofR2HfaNKz4tAP2myk7Ldv3B+HpIAgf7eLvVvTnSioW8jSgi4mfDfGf7PJ2gRh5fWQeyXplQkmxkaNdzTjvoYJVrkdutnytiWYiVTJL8xLO/K95/uyoXCLQdSVdg/Abzanx4jZDvV81EW/Xa2E5ssweHbvkpN3TLxfgQvo4m7466mcdk5UCnpIEynwxswVRYJGQgzCc9MLjAeACc2sRvgo7b/wossF8gcz4FWilnOem9oAOexGDSeunh7N1GrW3kHg6x0at9eOXxYblcKou+m/UeER2j1j6mMFsCAAL+5x/MHpNW5BbuBw0Aa2fhjkQbMeOySdOPKBH1eUSO2EuGn4fdzA7IW2tQQwVJUTHPfOr4vjVgdUiHw6r8D6ttv4h+RqRbFsnMHAdav2dqzOdAjHrN4PVOIAx3K9PqoMV/qcKlxkf5lSmUc7GsT8TkJ2/m5ncA1IPqQs2iBdDt11WY1pa7LHemipR5ZAePGR2nnj2MEaxz5BbL37r4mt6uHdhVTGafyhK/HBMjh3Y7wx7i13uF1nrcNMI+9yT/MkqJTCkANO5hVmqv1PCIjQ+F+A/kaOe68NIkFTEuQh4EbvVVjbvIUxTUtmlI6fqBtqknO8QSBbzxz/PGlqeVPrCUiQCKGk5GRO6EsJmw24o9o/4AxcIJ1m+ZuPiPjqHWAOflLgKByzkLnxemYa+o3jxc76cyHiOpFgiw+LdnYNvyhgeAikNelmMR1M=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199015)(6506007)(5660300002)(31696002)(83380400001)(66946007)(38100700002)(86362001)(41300700001)(6486002)(8936002)(478600001)(8676002)(66476007)(316002)(2616005)(6916009)(4326008)(54906003)(66556008)(26005)(186003)(2906002)(6512007)(4744005)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a3Z6K1Rjc0tIQTZSLzFRUWRxQWVaRE5TZFhjSU5mUmdONUJyT1p2WTFPS1Jw?=
 =?utf-8?B?TWh1SzU1MlpOK2JpUGFNd1hCSGcyMkhDRzNxSUx5NkxQOVpMRjBGLzh1N2xh?=
 =?utf-8?B?eWttYzZpY3Jqbm5FZDFJUFhYTy9hTURKdy8venZSK3I5c010L1dCdyt6WmRa?=
 =?utf-8?B?N25FZTArbkF6SktGQTM0VkdpalB4MVcwNW5Ua1ZLOWx3dStLV3g4Ui9pNGZJ?=
 =?utf-8?B?a1FISDdwczZJMTJHcFo3VUpmZndaRDB5cGlya2Z0d0doN2tCYnByU2w4aWd4?=
 =?utf-8?B?QUJ6NzFNUkRic3pVY29wQnBZOWNNajlpWS9sOXpQeE91SE9pUlAwRFArQnN4?=
 =?utf-8?B?NGZVRHFaNi8rYUpUT1pVYXNaSE1jWGFYTjBHUzQxR2N2Mk12RkdSV2x5K1FS?=
 =?utf-8?B?THdZeTlTeTlUT3EzclNIR2NIZmU2OUxtWENTRUp2U3B3elJvaG9pcXVvZDNY?=
 =?utf-8?B?a2dtQW9ySXd6L0dQZFM1WjZ3U1l3SzJPbHJhRlljamtGL3F1Zlh1M2NLY0RQ?=
 =?utf-8?B?K3RFMzNzdzZldWN0UTNZZVJzOFVpaGs5dU8vNmJlZW9hWkRGdHlTWm1zUXRu?=
 =?utf-8?B?Qmk0NUd2cmE2bjVJUzhDZm1rT3BsY2ZzOWNrdmVQNkE0QnVWL3cwT0FENFU5?=
 =?utf-8?B?Nk55UHZZRTR2cUppMUNwcFVZaDBsSzdZSXhCSUVRK3gwWXZlU0dJeEhLRTVp?=
 =?utf-8?B?bFBGenhaWjgxbFJUcCtpYy85Vm1IZ1JPUWRZZm54UmZLNHRrQnNuZldVaXdH?=
 =?utf-8?B?R3B4U0UvUGhncDZ3ZUkvYTZUMDZVdWE5aDRlcEN5eHlKaFVFN2haTCtlUmtM?=
 =?utf-8?B?S3IzOHFEZTc5VCtjbnpHMG9VQXFoY1BnVUIzd3M1STFoeW1kZU1yOU9Mb29U?=
 =?utf-8?B?UXoyZnk2S2VSeFY0OVIvNjRUbUtNMzR6d1N1RHBwaFNyTFE5bGplRDIza0Nq?=
 =?utf-8?B?N3o5dVBwOWUyOUUwaTc5RlpvUXc4NWdXcTlHa0MvZlVKMitxY1VFMURlRVRn?=
 =?utf-8?B?K3ZTKzlaZU8zeEZMMVo3VEhMQ0dQOU1ZbDBLMExha3grYkdaRnZaU05CcHVJ?=
 =?utf-8?B?MkJFTVozd0xMWmVBUlAvWVh5K0UvQTFiSS96VSt3VkorajcxR0ozZE40b3hB?=
 =?utf-8?B?Ky9yTzFHM1BERFJBQWdrMFBUN1hpOEM1RG93K2RJM1NISDQ0VE51TE1ub0hl?=
 =?utf-8?B?bFpUdTdzZFR1VHF4TzJvT0RqUEl5eG43REl6Tk0wTzRaZlZaZ3Jqa1k0OTZP?=
 =?utf-8?B?Qkdtb05DUC9Xemw4YjNIVk42Mjh2b0JuRTdIMFdMNFBSMCt3cTRLb2Jjdy9W?=
 =?utf-8?B?TEh1Sy9xeVBCdDkyVFdBN3NLVzJUbHQwL3BrV2F1ZnFxTU5Zekg2MlZWOE9T?=
 =?utf-8?B?dmxhY0JSbE15c0R3ZUJtWng5ZGN1K0Y5Q3hNdE4rekRjd3JBQzRRa2FvaHJB?=
 =?utf-8?B?OEx1VEE5MjRSb0JEbWk0MGoyUkxDdWlKcmJLelRyZFFKSXFDZ0ZsOUREcnVI?=
 =?utf-8?B?TmE5ZHZMdVB1WTk1cDdlNVBTM3VyUS80WmZCcUdpN0NJbklxWHR4eUdyM05R?=
 =?utf-8?B?Q2tQR0sxS1gwaFNsbjE3RnhxSk9acEZCU2F2RC80RzZxbzVVeGQ2cGprSTZ4?=
 =?utf-8?B?Mi9XaEJOZy9vWHZHWWVDcnZSSldOS1FvdUZDWmtEblZNdTRnQjFocG9WVU1K?=
 =?utf-8?B?b3c2d21xQk1iaXptSGp2N1JFN0JlbGhTM1VpS1dGWncrOTU5SndLbndxNjlX?=
 =?utf-8?B?eDUrMytOL1dnR0J6RnlMSFgrczhLYk4xSllGcWcza1V3aHMrZmlHVUo5WDM2?=
 =?utf-8?B?dFUybkI4Rlp5aUlucDloRmtGS2h5eERDbE4ybms2N1pnSWt2OGR1d0hBMWk3?=
 =?utf-8?B?aVFHQzhyeHNDQzZlQXdqZ2x1ejBZakZGSnNBQkx5RzdXU0ZnYVZnRmoybXV6?=
 =?utf-8?B?TFJXOHBGZUhGa0pBUkk5bkVWQ3F3VVlqSXpjTk9lYkdxMzFDVHpCdlJjZjA4?=
 =?utf-8?B?blBIeHVZSkszZjRoNmU4Ryt2MXQrVEpzaENaM0RKaEsrQVpIM2xYWHlmQTdt?=
 =?utf-8?B?Y2tleFdYRUFjNzBYMm9UMVNUejZWbDF4SjRWeVNndzB5Zk02K0VPM1B4NW9t?=
 =?utf-8?Q?RlYCntNWAYfZZ6Do1nDd9nTbi?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f67363ae-8470-40ad-a6dd-08dab7fdddf1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 09:30:20.6275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Cr0sh1dgA1uZLo9t6N2/FsL9J6vppzfYL5XRu5DUm5OE4C1oXwa3kAS3syuVvuWuYE89yaJhbyNAhoQ/GrI/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6937

The name change (stub.c -> common-stub.c) rendered the earlier
workaround (commit a4d4c541f58b ["xen/arm32: avoid EFI stub wchar_t size
linker warning"]) ineffectual.

Fixes: bfd3e9945d1b ("build: fix x86 out-of-tree build without EFI")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/arm/efi/Makefile
+++ b/xen/arch/arm/efi/Makefile
@@ -6,6 +6,6 @@ obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
 else
 obj-y += common-stub.o
 
-$(obj)/stub.o: CFLAGS-y += -fno-short-wchar
+$(obj)/common-stub.o: CFLAGS-y += -fno-short-wchar
 
 endif


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:32:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:32:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430975.683348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzFY-0003KX-AA; Thu, 27 Oct 2022 09:32:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430975.683348; Thu, 27 Oct 2022 09:32:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzFY-0003KQ-6Y; Thu, 27 Oct 2022 09:32:32 +0000
Received: by outflank-mailman (input) for mailman id 430975;
 Thu, 27 Oct 2022 09:32:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1onzFX-0003KI-6e
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:32:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onzFW-0007ps-Nc; Thu, 27 Oct 2022 09:32:30 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.29.62]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1onzFW-0005Ni-Gs; Thu, 27 Oct 2022 09:32:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=EBE1Q7CU6voBZIzX8/WnsrJydJ9TiOFS5RLESzBoRlk=; b=MhY0dJxPLvAzeUbkRMhbEk2sR7
	xolTsgF4YI49G80gKyFi6kRM2by/pE+tWd8g25cVBcxbye8YPlicItKe9zfCKv4kyd8qFtLJY5V9Y
	h3rSGGkM5y4l2XeeR9oaZKjepHUllF42rsJtUO0BNJHuvMDozskVhSIFHBoZ0rSphyNY=;
Message-ID: <fd3142a7-778b-4176-347f-ad02252f59c0@xen.org>
Date: Thu, 27 Oct 2022 10:32:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH][4.17] Arm32: prune (again) ld warning about mismatched
 wchar_t sizes
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Anthony Perard <anthony.perard@citrix.com>, Henry Wang <Henry.Wang@arm.com>
References: <6a6df9c5-a527-63ac-60ec-fe7f3b6fadbd@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6a6df9c5-a527-63ac-60ec-fe7f3b6fadbd@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 27/10/2022 10:30, Jan Beulich wrote:
> The name change (stub.c -> common-stub.c) rendered the earlier
> workaround (commit a4d4c541f58b ["xen/arm32: avoid EFI stub wchar_t size
> linker warning"]) ineffectual.

Ah! I noticed this warning over the week-end and was wondering why it 
was still there...

> 
> Fixes: bfd3e9945d1b ("build: fix x86 out-of-tree build without EFI")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:34:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:34:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430983.683375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzHn-00045v-SU; Thu, 27 Oct 2022 09:34:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430983.683375; Thu, 27 Oct 2022 09:34:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzHn-00045o-O7; Thu, 27 Oct 2022 09:34:51 +0000
Received: by outflank-mailman (input) for mailman id 430983;
 Thu, 27 Oct 2022 09:34:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SB4N=24=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onzHm-00045i-Lc
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:34:50 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99fd75d2-55da-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 11:34:49 +0200 (CEST)
Received: from DB6PR07CA0024.eurprd07.prod.outlook.com (2603:10a6:6:2d::34) by
 GV1PR08MB8177.eurprd08.prod.outlook.com (2603:10a6:150:93::21) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.21; Thu, 27 Oct 2022 09:34:40 +0000
Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2d:cafe::2a) by DB6PR07CA0024.outlook.office365.com
 (2603:10a6:6:2d::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.13 via Frontend
 Transport; Thu, 27 Oct 2022 09:34:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.20 via Frontend Transport; Thu, 27 Oct 2022 09:34:40 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Thu, 27 Oct 2022 09:34:40 +0000
Received: from e969b8366bad.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 651E4A33-68AA-4033-BC3B-FDEC135F3780.1; 
 Thu, 27 Oct 2022 09:34:34 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e969b8366bad.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 27 Oct 2022 09:34:34 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DBBPR08MB6204.eurprd08.prod.outlook.com (2603:10a6:10:1f5::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 09:34:32 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Thu, 27 Oct 2022
 09:34:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99fd75d2-55da-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Mi3MTb3kJNWKubVMXZ8Ya9CBa6KuYXwtOvv9M53AEeOD8TUYqBQBNVvL9gVcBDgy9xMYxTz1knvRyDidCRB3+jdkOkv/XnNiAEfo8Y73NVE+pDhxDgrDxy0Fm3yUaRMhu7hOZPi4lXug806es1H2TJZHOrMIroOEWqhIh1fJ/kJlHaeNy2blTps+99X3bZ4oXKTRmYfq4oPmvQBZAKODynkrbzDl/fHHGSE5zmTPVHRw2sMqhM63pbGtX68LdUcpeYS5q6IdPP2CDoXdj5LnkUoyOu6+3k/k1vAPzlbwOBBbA0HtlkJNnNeaAz3mBQtwi/+Yz45spNJmwh4gZg7Fag==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=680r0LKeV1ifl+jM/E3JSYDCiKPY6uzKvzbryl+Fs1k=;
 b=KxHR+Sbgm3MIz/E77LL7/P2c3+I8nuPVJoqg3bXyHuVVzy6ZbOhcRdIsW4o5ZOu7wgptUTIe3qV9jx2qY0WglvwJ0j1oWB3oGB+EcNL7LBlInd6DQg664oW8ck/UMMsq6z8PlZWRz7HTuJGrOroFV9wr6g4c91u3jUxrJ0kYHp2pqkfVuqHRV2dmtsbJAEb1LTE+lZjb5vv3gVpq/s2hir/hW/ZaHK4MRe7lCboazIPyCjLTCa8r/5DYqeRRgMt8QFjEsmyYJ/eqGyXiebJLWUGA2DWW6r4iGBSUHTe0+1c5kTfNf0e1k34DDaiGES6V7eUrP273DMcb8zHwL1oHhQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=680r0LKeV1ifl+jM/E3JSYDCiKPY6uzKvzbryl+Fs1k=;
 b=NezOZhaTiy8tAL+VPkO6Cx8Yht4Eadwylaxg4lUTtIbPcSmYs6vJdK5HlhnLbpNmTCmnt1IwJxCcOUNhqi5c/cpGXcigDCEX/4yOSoI+CSegS/WKEF+zJW3iRgatdtuvAQK+xVpzG8SC28UMpISsagq8YxopYvXOvZdyXTdQMdk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fw8Z4jUCg85uUZUXt4sR3KEX+0Qrqxnx//bS6H+h5wqKdOVntB/pQ85u+fYGbD8o1X8QN+oExA2DyfQOlTD9b5wwMs0ryPvHWSS66Bj6vkqJ4EPffJslgDBut+M/BVva7YXhqqPl5HzH8n3uthko4cRPF+KYYZbijL1BzMnneI0kctRZPkkosSi4S+iB/OKo1CrQSJHLodj0H6Pxo2fCXvn+5OSRsFhwp4pHiGz7yi+lGTETQO3CpIo9Q0Txh8wbUP4ymu2kvp1MtR0p6CJ/Et5BzFgOFo8SBPM6FGzRDzQtui2BgGD6BGPHN71Ekpg3biz7PDcBuGvBfsE4AL+4Eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=680r0LKeV1ifl+jM/E3JSYDCiKPY6uzKvzbryl+Fs1k=;
 b=hD+ZguecrjKusAChMoZ8ZLPeQNlMSeXktX2ffWULNC47ZrYlZsOrLJ1Y9C1TwSe5Eq0iGTT1nlhYnnNNdbUZoYbLzXu341eVZnCrqJhehMmjmCNNYAQQEW0xFkWWhFeq0rJbqxweI241xZLCuTrLNhj7Bs+s8LNE3XDoR/pEUjOdXS7FTDLTiE57pamCqDWjQGakmSRwc5KguPoKdAM8DYv0+XdkjJhGNirfTnB/0dUgYYu18PhmE9jycTDXnuoNbUmUflMu0NioediLYDUHlT3fc4Qyj/v/B9S6m8Dqx849SbaRMbHuPTosv9sy3VytoyU1OZA2yGJOoKCH2TRcNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=680r0LKeV1ifl+jM/E3JSYDCiKPY6uzKvzbryl+Fs1k=;
 b=NezOZhaTiy8tAL+VPkO6Cx8Yht4Eadwylaxg4lUTtIbPcSmYs6vJdK5HlhnLbpNmTCmnt1IwJxCcOUNhqi5c/cpGXcigDCEX/4yOSoI+CSegS/WKEF+zJW3iRgatdtuvAQK+xVpzG8SC28UMpISsagq8YxopYvXOvZdyXTdQMdk=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Anthony Perard
	<anthony.perard@citrix.com>
Subject: RE: [PATCH][4.17] Arm32: prune (again) ld warning about mismatched
 wchar_t sizes
Thread-Topic: [PATCH][4.17] Arm32: prune (again) ld warning about mismatched
 wchar_t sizes
Thread-Index: AQHY6ebILjCZ5f5rwEOE6D43MoDXY64h+r1g
Date: Thu, 27 Oct 2022 09:34:31 +0000
Message-ID:
 <AS8PR08MB79919F3B1FFBB69FE1744FD092339@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <6a6df9c5-a527-63ac-60ec-fe7f3b6fadbd@suse.com>
In-Reply-To: <6a6df9c5-a527-63ac-60ec-fe7f3b6fadbd@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 04FAE19D423DB44E94A6454245CF9135.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DBBPR08MB6204:EE_|DBAEUR03FT046:EE_|GV1PR08MB8177:EE_
X-MS-Office365-Filtering-Correlation-Id: 31786580-02fb-4ef3-ef9a-08dab7fe78b8
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 soA5nDnH4FGOf/DMXhg2QlU00M9bDVfhEM/YJDV+bFfX646vOaVEzcB99PY0+tHJqtEJlcER2e75kQystKtpmPeOROKDEezZbd1LvKgsiFdzdCdCQZCWBMRJ9Mjtezg6fHXNG/9V/jLQ/c0XjgFHuGmP8HJf++8NlQ6rU95NnN+UiU46/esfIkku5AL7H6OnlYosCtnIzAZS8gc8mol9ZedTCYK1XOVaoo7+SR0yyy7sCgU16U69ndiaycW/JOOhnZoQuAVqIybGD6gDPk7unoQLJPPGHPPfvMNXtBomv6XR1TcDHnjadUmzZ1y9UuC6KApXrAHNBKQZ6D2ustxu562ysWsAapcwqJ1eJr/qmvPIFDYzfDtxq6rdVu1+ArWdc+DRTUZoF2zY7Q/uUwuJ223lJXZVtaS0RiKLLcOJ4ZuOH1TOVh2RAPN/m9tCdPE2Td154oEEapK9h9/wQttvgMdZgsnAQNTjXU329uRU+Q7rF8gBXJV899xpsSjpjYqiB8FegAl2xc43Y1pyuwmK/X+siaTDJq0m/0Z1GzAqVdqCs72ly2nSacij+/6WUDwJmiKKJrD26DmEVNLESg06cVh4wv8PQUFE1mJmMsEGt7aomhTwLEIVbi5Q37GcaKkHmzHJTa5oZKK7mNotyDdMv2elqcd2YEQl5l/p97o0PfZFEK8F4rB6yg78DlX3hspiTirJi/xGlBoQLO0JFagftHTuUMVUk84iuZYxBMgE7yJcYSIgRstQipDIY8NcwCh5T6BNTJwx6f6Z47ME5W3mvQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199015)(86362001)(33656002)(38100700002)(38070700005)(122000001)(2906002)(9686003)(26005)(6506007)(478600001)(186003)(7696005)(83380400001)(71200400001)(110136005)(41300700001)(316002)(55016003)(64756008)(5660300002)(8676002)(54906003)(4744005)(66476007)(4326008)(8936002)(66446008)(76116006)(66556008)(52536014)(66946007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6204
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e9622c06-7428-4843-3c3b-08dab7fe73db
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F10nXAtf2llVyzYKhxel7BVk3qNPJgVzeCA20HmGo/M0g8WhBslYVLTRbM6o6km1QVju61dMsyFH4/yRRCjO6JZkKx2d9mK7cpYXNBCJ16nFZgh2Qa9Z+Lev1lhRVtkhMYDRP04wPgEQQ5CTWRQAWf6izu7wnU2jymtWW3xC3dmQYLI886pBvnxAt/TgH5H84o5EuBDLjShk2lZppG0qmTLKmz4FOzb6ta6e6e9ChhViPA6DFoY6y6rIrE2cJF8p6GWZD4pTKKD3C+32AyES8s6Kgftdfmohu3BCoov5MKIukXlqzQXyTlPW+aThsQYXxDa1Lq0lvy/0JsX8H3p2AyWE1HiAYypgy+jDEeGKejH0CdrLk3AgUT4K27l6cbphDsG0xohUYlickUV6Pwgl2rb5tkK9MEqBz2SmCNztvLtIC7xISMEoac/Qx+/maHYUeS9uhF9XbJiRYmhCj+t4ctxfKJJcV0uooyVnzN+uHE+wDrkfh46PW7TMhh99Ba7EPxv3JlBzIID0PtHYZq1hNpQZeBKF2K6Ks736pox2J4apBDmWHVk6kQROnu+pZrD/7VCmiNXFZteYg+H/8bLD+7pFWM2OPb2zXGyxIIo6KxEoQEGrBEiX2raRFYr3+1mZbPGAAwCVZz6MR0aYRWxImsWeLXDR7JJ2s9xWI633kN3IrqHUbuO9w+wIxG6A2mBxm/XC+246zURvo6JJnrEvbW9s6QoT7gPwU5A7dZU3/QjSnkL7yVOPye5G8YrEQGYmGIU/mPDCLBTpVxvA/WqvEw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199015)(40470700004)(46966006)(36840700001)(5660300002)(336012)(83380400001)(2906002)(47076005)(186003)(82740400003)(54906003)(36860700001)(81166007)(52536014)(26005)(40460700003)(356005)(4744005)(55016003)(8936002)(86362001)(82310400005)(478600001)(9686003)(6506007)(8676002)(110136005)(70206006)(70586007)(4326008)(316002)(41300700001)(107886003)(33656002)(40480700001)(7696005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 09:34:40.1152
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 31786580-02fb-4ef3-ef9a-08dab7fe78b8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8177

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIXVs0LjE3XSBBcm0zMjog
cHJ1bmUgKGFnYWluKSBsZCB3YXJuaW5nIGFib3V0IG1pc21hdGNoZWQNCj4gd2NoYXJfdCBzaXpl
cw0KPiANCj4gVGhlIG5hbWUgY2hhbmdlIChzdHViLmMgLT4gY29tbW9uLXN0dWIuYykgcmVuZGVy
ZWQgdGhlIGVhcmxpZXINCj4gd29ya2Fyb3VuZCAoY29tbWl0IGE0ZDRjNTQxZjU4YiBbInhlbi9h
cm0zMjogYXZvaWQgRUZJIHN0dWIgd2NoYXJfdCBzaXplDQo+IGxpbmtlciB3YXJuaW5nIl0pIGlu
ZWZmZWN0dWFsLg0KPiANCj4gRml4ZXM6IGJmZDNlOTk0NWQxYiAoImJ1aWxkOiBmaXggeDg2IG91
dC1vZi10cmVlIGJ1aWxkIHdpdGhvdXQgRUZJIikNCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxI
ZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg==


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:37:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:37:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430987.683385 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzK6-0004uC-7h; Thu, 27 Oct 2022 09:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430987.683385; Thu, 27 Oct 2022 09:37:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzK6-0004u5-51; Thu, 27 Oct 2022 09:37:14 +0000
Received: by outflank-mailman (input) for mailman id 430987;
 Thu, 27 Oct 2022 09:37:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onzK4-0004tr-NJ; Thu, 27 Oct 2022 09:37:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onzK4-0007vd-Kj; Thu, 27 Oct 2022 09:37:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1onzK4-0002vX-6H; Thu, 27 Oct 2022 09:37:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1onzK4-0003j3-5l; Thu, 27 Oct 2022 09:37:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=CkrU/0+S6+oadEx3m2J++Xe4CWEOD99KtuawfKeLqEw=; b=RK3kyVe3So19vOmfmJPZsfyI40
	uQbqk4S1mtcLGynT5X+F678qnd3Sqa+8kIGZEwf1z6kvbl+lWFQMs8eEXlcHPWdZtqIa+dO530gD0
	coEW6RLYWVHLSUbYXAJ9qZVrghMoSs2kP9KtqXa1WyJFtnU3h0pK2U3nAT8t46lYAqpE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174435-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174435: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ef9cc669ba157f9e71fd79722ee43892e7304604
X-Osstest-Versions-That:
    xen=fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 09:37:12 +0000

flight 174435 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174435/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174367
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174367
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174367
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174367
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174367
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174367
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174367
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174367
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174367
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174367
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174367
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174367
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  ef9cc669ba157f9e71fd79722ee43892e7304604
baseline version:
 xen                  fce1f381f7388daaa3e96dbb0d67d7a3e4bb2d2d

Last test of basis   174367  2022-10-24 15:06:52 Z    2 days
Testing same since   174435  2022-10-26 04:32:31 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Michal Orzel <michal.orzel@amd.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   fce1f381f7..ef9cc669ba  ef9cc669ba157f9e71fd79722ee43892e7304604 -> master


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:41:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:41:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430994.683397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzO8-0006L2-Up; Thu, 27 Oct 2022 09:41:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430994.683397; Thu, 27 Oct 2022 09:41:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzO8-0006Kv-RZ; Thu, 27 Oct 2022 09:41:24 +0000
Received: by outflank-mailman (input) for mailman id 430994;
 Thu, 27 Oct 2022 09:41:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1onzO7-0006Kp-90
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:41:23 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 82cb5e5b-55db-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 11:41:20 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM6PR12MB4579.namprd12.prod.outlook.com (2603:10b6:5:2ac::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Thu, 27 Oct
 2022 09:41:16 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 09:41:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82cb5e5b-55db-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HRxBJM4YJ673YXFVec1DkLMKavOFe1FbIdqIdtPHQvQCOFkUF0QyWFazce9ARyJGsbUDc8D6jIk/7V8FXv//Oek3vlko2g+6mhWw89WmxYjf0LUzhfOFoSHztHV8IQUDvqs4HnQL6JSFIoQiAAUl2EqGF4l1G0HRM0Tp4X29fNvp0yqL+SKsn39FJTGXnSxAFD926M3ZBrPUOrBQPy6Kg9MwW+YQJf8luRxr5b2hM3gWUkIne8Hw7CzGVj6fEl2cmsedCR0wpwXVAsIthhE7O0r4s1tDhvB0cRohTehgRJzezjZ+uog6dkTS/VmM5DXguF4WW3Su7uIbs72iJdLlIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Dogu5ETNCI2EUoNrtXonyQcFnvOcxAMQZqJ65IMw7jI=;
 b=ERWY6afrr13IvipR2KEoRG8kR3WVioYpWNd9m6gUpUVwqhwwIic4g5ElF27eWYxTujOX3dgq13b5G3/32z/QgBMZo2BdtHyaBxDNDSTpZrOXTHLWRUBPs5hA907OlHVE8iaH0D7paz9EOoT3mYOW5CDbVAWftm4eVEiCU7nTMMdvdyx51Jfuayxu1vfz2HSI6wdsBUHG64YtMRipbr4kpE+ZmjGUK/vJY4/uAfCAkyo2sfzCkIvqqJdyAgtAXHB7CmXA3qHTj4S1gEhFlk8lMx/zQE/v8cPXuLeqzc9XKSJMmk3mg3lnzc/QCeZWofozCwYnKlL01sfhonUAxudAbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Dogu5ETNCI2EUoNrtXonyQcFnvOcxAMQZqJ65IMw7jI=;
 b=EMmiowDsJsgHu5HKM9EVF2fZj++9wlGgmhSdf/IcDrUlX2H3tNgok/6PHIH9eQDxm6ruQoQXqQAVd8ikiwLSci19ZTmzl9HM+miyO8sBTP3LuyM3ZJ5zw4cuwXmoQiYQRvgnVQHDW9ogt93bPL71olbqhXYInOnqJNSNt6kNU88=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <96129ac0-29c1-3d7a-b047-377c1b242887@amd.com>
Date: Thu, 27 Oct 2022 10:41:11 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
From: Ayan Kumar Halder <ayankuma@amd.com>
To: Rahul Singh <Rahul.Singh@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <00baa14d-59bd-e106-23c8-b3f151f19eca@amd.com>
In-Reply-To: <00baa14d-59bd-e106-23c8-b3f151f19eca@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0520.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:272::16) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4579:EE_
X-MS-Office365-Filtering-Correlation-Id: 75334215-a9f2-4da1-1f3c-08dab7ff650c
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yf52EcWxY6feFYufFbKfev1XmfIGTwDuU2+xN+nQ1db+9Asb4LPq2TuY3PNZr3K5xc511Z4RgxoNVi7rd8vXrwr0UkYZVmI9/C8sdqtHNlkdMPFwulnqiHUD9zsmYEbzDcv2M9MosY3R9YVuJjfhhE7KMtBlUp0c1R9Sdnlumis/YjSzIvrp/4tSoBcpINpZqc8LKYhxVhqGfR++Y/KFaARgK8uf5l/xvCk5vT2lWpoYmiKZBr1A1/7GRZpXq6ep/FjzE0a4xITp4CXLshzKLF2By6TyEL6gGLs3vRtuZ+mu7+GuhwB8SbIv2HxdAB745/Z92UCV/yiqt05YNSt3d9cJQPVpMfX2mBKcjn5Acp/hCfxzvp2WT4vwH5kezx5+Xig4JL+g1YhuQqjSPmd1u9MPi8N2vKwaJGZCPyBwB+vPpJ5CqhCG8HTfWQ50P5wdXD/hiYxgrtMezjL3lt+Uem58IqZPwQzsNuGu3AoUkpBNgySjPX0/x9uoR69qvonrh4Ttv16Wmq7+fd9i1NJe+ODJS80C2Z2Hx/CaUqlMGCNoqwXbVepNZ3OUrSVJGv0wSr93WhLfqzIijtL+Updzy7mZ8oo3OyHZnaLsNtbsy878pO98E5xNaTNlVNoHcggpV2zzCgM6RCPA2BG5QGfl1/vyLNJPzCOGc3MrHlypbYZYJIDDu+5fOn5mo9awqBcyoPuz2+WhYheRDxEUC39EJjh4Zsv0vy4uCtu8WIYgoaPZXsV4JeX4AO94cBYApnbv2XSIi0Lz8nSGRnP42WnhDiFT7+7tPq3kS2wqR7DL9W+Go/C3SC2yN9ZDKkVJbKB5mA5zZ1KANZQPHHsit+nXdnAfwSk5bwqXHf9gKSyEKsk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(6666004)(6506007)(53546011)(36756003)(2906002)(8676002)(66476007)(66556008)(66946007)(316002)(110136005)(83380400001)(31696002)(2616005)(186003)(6512007)(26005)(41300700001)(8936002)(5660300002)(478600001)(6486002)(31686004)(966005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dUVuVVM5a0ZrSmdCREhOcVBvQk1hUklmREhBejF5L2NlZGtKSmZrMG9wT3pu?=
 =?utf-8?B?MXk0RTZGSEplanFSVWRtSXZ1OEpTeDI5T3RnUUVMSmNjcTBVQ3RmeW9UdHlm?=
 =?utf-8?B?NnlES2VGMy85cmNKQVlHUTNpUklXSWgwTGh0dlVLUjF4NGZtcEgxMXRadHRr?=
 =?utf-8?B?NlltT2VQQmdJYWQ1ZllpOXlCSmVEU1d6UTlsWnl1b1hBNjdRTng1dWQyMVdz?=
 =?utf-8?B?dmloY2UwWGJrYXlLRm1scHpremVyU3YrdjhFV3ZaM2h5VVdWQ1FmcTRnU3Fi?=
 =?utf-8?B?TTEzYnlUL1JxZy9oRVY1RXdOUDBLazZzRkFRUjRvbjk3RUlWamxJRFR3RnpN?=
 =?utf-8?B?MVZFYXBNOUgvMU5rd1U1WmVzL0dWSFJTY1JRZXdpb3JnMWhWZGp3d2RTYUdB?=
 =?utf-8?B?MHhJdzBHWFBGUGUrSFowZzlvaUNsQ1RCN2FjenFmekJwbWdPWVVPYngrUms1?=
 =?utf-8?B?VFBaSlZES2gzVGpoNWNPNlJrRzkwTzRlVWxucmNLVUl5WjZXd29ManNsdi9T?=
 =?utf-8?B?YmFRbGhZWEl0aUJXb3o3TmYzZXFub0FyZzlVVWE1VGhCd2VYNEFzMnl1U0w5?=
 =?utf-8?B?b3hWVERQV0ZYVFNtbkZiNmx5Wk82NjI2ekREV1R2THJlSUlta0MzOFJHeVM0?=
 =?utf-8?B?bmtQaUxPeGFUakorbEdpQzZzVEw1cExkaDJIY05LNWpWSWpsVHJEbXNSMVQx?=
 =?utf-8?B?bU05QjJtZ3ZmaHIyUFBGSjNhSVRGV2txYjVRYnlyb0hOQzVheHQ5ZjVoZ3RS?=
 =?utf-8?B?WjVuL1FvU3lMUHphUkYra25JVm1lam00d1VnVGVJQTVHVE1Uak5lQktidHBN?=
 =?utf-8?B?dlkrbU5wS3VxY0sxdFYvQjJYMDlvM1ZyRTVLeG9DOXBMS25ERS9sRjBSbmRp?=
 =?utf-8?B?ZnZvazZ6ejI5RDR0VjZLbWZyclZLK014MXhXZ2pHbW1zK01aQU4yMlpLYUxB?=
 =?utf-8?B?YzNBYlFYNUFkVHJ4SUZXcDgrdDFVQnhqYytocTFrK05TbGgySWE1bEZOL1A3?=
 =?utf-8?B?QjFCU1I1cnFVcW5rWXplL1EwK1RKdFVsZGJsd2Y5aUZvSWJVR3h3VCtRNUpX?=
 =?utf-8?B?SlFoNUltQmdWdHo2OEVIS0F0VkZvbWJoc2pYSndqUmRRR2RpWjhnaFpKR0I4?=
 =?utf-8?B?RmlJdURFNmFTOVIreGJrL0lvMmpDdlFzemlpaG0zWTB0VEdrTm04WWFOS2pE?=
 =?utf-8?B?Wm9GcEg5VmlOWEU4RzdaR1cwZ01DeEdGYXAzblR6OWZCMW5VUExOSmZQN3Ew?=
 =?utf-8?B?dG1RdDN5ayt4V2xaNEprbE5jMWZQYUJZWk0rYUxVWE5uVEZnV2NWNGthbmtx?=
 =?utf-8?B?dUFQTGx2dFk5czJ6L1Z1cE1aZkpFMFJ4alJUUlVjODZXMlEvaHltd3ZLVnNa?=
 =?utf-8?B?WjJLN2xndHMzTzIzSWl4Y1pObXBmVERlbklEbXk1cml5akJiRlZ5SUpueExl?=
 =?utf-8?B?SEhFN0NkU0RxSkNQRUxGRWw1d2RBOGJKYW1UWjdJbkNsZ0lXVE5pZ0JuMytY?=
 =?utf-8?B?d3RTRVFsYkVhRWZhVkNyamk4ZEtkUWl5Z0JleTJMRFRUMlpucTB2WVc3NEFK?=
 =?utf-8?B?UjQzeXZVeFdLYTZxQ2FoL0xiRk02dDBhT3FwRzl5cGZRNjlSc3VIK2NmRTE3?=
 =?utf-8?B?OEZpRG5reFZiaE1MeVhKTGlQbVhYeVlibko1NWUrc21vZmVYdExNUzc0K0Z6?=
 =?utf-8?B?ZXlHMFdpeDRuTERYaGkvL1VrU0ZoUlZadlNGZVVZanh5bHBXdVhwUmhJQmpX?=
 =?utf-8?B?TmhGUVhmdGdYN0JTK2FaWVpYN3QwdjZ0REhXdWw3UGtFNWJOWFRsZXVVNjVp?=
 =?utf-8?B?T21ZRU1HSi9Ndm1kNHUwd1RPTTNaRHBtZFdUem1vRXIzYTB0dU42aE9pWnE4?=
 =?utf-8?B?UE9HTXEvTytzQjlIMW9FbEswTk9WVEl1MWFERDNhYzBQNFgwdUVLMDhzQlpz?=
 =?utf-8?B?U0U0RlArRFBNWC9UdjA3SFhjTzVMbWNXTFF5UUtaYjVuTjEwK1lPVklQaGNh?=
 =?utf-8?B?elNRYUIxUDNRZjUxa2JFdFlBQzlJRlNCRTQrbWVJVjJEQjhlSm9rRnhnR3BC?=
 =?utf-8?B?S1JlbVlHblErYUpOTUhSRXZ6QVgxSSt0VGZodnBqNytVc0hZYVdKVGRrWGx3?=
 =?utf-8?Q?Z2O0diAyoVePo95rUr4v/LX+A?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75334215-a9f2-4da1-1f3c-08dab7ff650c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 09:41:16.7901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zZwzpsY4xD8/mCMjz5Qoj7TVD2cYw93WrTPsabyxGu3gBRrWJITIOa8tGgYu48rld2lhKoNjTe25qhDdY5NpIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4579


On 27/10/2022 10:01, Ayan Kumar Halder wrote:
>
> On 26/10/2022 14:17, Rahul Singh wrote:
>> CAUTION: This message has originated from an External Source. Please 
>> use proper judgment and caution when opening attachments, clicking 
>> links, or responding to this email.
>>
>>
>> Hi All,
>
> Hi Rahul,
>
> I have a very basic question.
>
>>
>> At Arm, we started to implement the POC to support 2 levels of page 
>> tables/nested translation in SMMUv3.
>> To support nested translation for guest OS Xen needs to expose the 
>> virtual IOMMU. If we passthrough the
>> device to the guest that is behind an IOMMU and virtual IOMMU is 
>> enabled for the guest there is a need to
>> add IOMMU binding for the device in the passthrough node as per [1]. 
>> This email is to get an agreement on
>> how to add the IOMMU binding for guest OS.
>>
>> Before I will explain how to add the IOMMU binding let me give a 
>> brief overview of how we will add support for virtual
>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 
>> Nested translation support. SMMUv3 hardware
>> supports two stages of translation. Each stage of translation can be 
>> independently enabled. An incoming address is logically
>> translated from VA to IPA in stage 1, then the IPA is input to stage 
>> 2 which translates the IPA to the output PA. Stage 1 is
>> intended to be used by a software entity( Guest OS) to provide 
>> isolation or translation to buffers within the entity, for example,
>> DMA isolation within an OS. Stage 2 is intended to be available in 
>> systems supporting the Virtualization Extensions and is
>> intended to virtualize device DMA to guest VM address spaces. When 
>> both stage 1 and stage 2 are enabled, the translation
>> configuration is called nesting.
>>
>> Stage 1 translation support is required to provide isolation between 
>> different devices within the guest OS. XEN already supports
>
> Doesn't this imply that there is support for Stage 1 translation for 
> guests ? Otherwise, how will the guest provide isolation between 
> different devices or dma-masters ?

Michal explained to me offline. This query is answered. Sorry for the noise.

- Ayan

>
> - Ayan
>
>> Stage 2 translation but there is no support for Stage 1 translation 
>> for guests.
>
>> We will add support for guests to configure
>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU 
>> hardware and exposes the virtual SMMU to the guest.
>> Guest can use the native SMMU driver to configure the stage 1 
>> translation. When the guest configures the SMMU for Stage 1,
>> XEN will trap the access and configure the hardware accordingly.
>>
>> Now back to the question of how we can add the IOMMU binding between 
>> the virtual IOMMU and the master devices so that
>> guests can configure the IOMMU correctly. The solution that I am 
>> suggesting is as below:
>>
>> For dom0, while handling the DT node(handle_node()) Xen will replace 
>> the phandle in the "iommus" property with the virtual
>> IOMMU node phandle.
>>
>> For domU guests, when passthrough the device to the guest as per 
>> [2],  add the below property in the partial device tree
>> node that is required to describe the generic device tree binding for 
>> IOMMUs and their master(s)
>>
>> "iommus = < &magic_phandle 0xvMasterID>
>>          • magic_phandle will be the phandle ( vIOMMU phandle in xl)  
>> that will be documented so that the user can set that in partial DT 
>> node (0xfdea).
>>          • vMasterID will be the virtual master ID that the user will 
>> provide.
>>
>> The partial device tree will look like this:
>> /dts-v1/;
>>
>> / {
>>      /* #*cells are here to keep DTC happy */
>>      #address-cells = <2>;
>>      #size-cells = <2>;
>>
>>      aliases {
>>          net = &mac0;
>>      };
>>
>>      passthrough {
>>          compatible = "simple-bus";
>>          ranges;
>>          #address-cells = <2>;
>>          #size-cells = <2>;
>>          mac0: ethernet@10000000 {
>>              compatible = "calxeda,hb-xgmac";
>>              reg = <0 0x10000000 0 0x1000>;
>>              interrupts = <0 80 4  0 81 4  0 82 4>;
>>             iommus = <0xfdea 0x01>;
>>          };
>>      };
>> };
>>
>> In xl.cfg we need to define a new option to inform Xen about 
>> vMasterId to pMasterId mapping and to which IOMMU device this
>> the master device is connected so that Xen can configure the right 
>> IOMMU. This is required if the system has devices that have
>> the same master ID but behind a different IOMMU.
>>
>> iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , 
>> “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
>>
>>          • PMASTER_ID is the physical master ID of the device from 
>> the physical DT.
>>          • VMASTER_ID is the virtual master Id that the user will 
>> configure in the partial device tree.
>>          • IOMMU_BASE_ADDRESS is the base address of the physical 
>> IOMMU device to which this device is connected.
>>
>> Example: Let's say the user wants to assign the below physical device 
>> in DT to the guest.
>>
>> iommu@4f000000 {
>>                  compatible = "arm,smmu-v3";
>>                  interrupts = <0x00 0xe4 0xf04>;
>>                  interrupt-parent = <0x01>;
>>                  #iommu-cells = <0x01>;
>>                  interrupt-names = "combined";
>>                  reg = <0x00 0x4f000000 0x00 0x40000>;
>>                  phandle = <0xfdeb>;
>>                  name = "iommu";
>> };
>>
>> test@10000000 {
>>          compatible = "viommu-test”;
>>          iommus = <0xfdeb 0x10>;
>>          interrupts = <0x00 0xff 0x04>;
>>          reg = <0x00 0x10000000 0x00 0x1000>;
>>          name = "viommu-test";
>> };
>>
>> The partial Device tree node will be like this:
>>
>> / {
>>      /* #*cells are here to keep DTC happy */
>>      #address-cells = <2>;
>>      #size-cells = <2>;
>>
>>      passthrough {
>>          compatible = "simple-bus";
>>          ranges;
>>          #address-cells = <2>;
>>          #size-cells = <2>;
>>
>>          test@10000000 {
>>                  compatible = "viommu-test";
>>                  reg = <0 0x10000000 0 0x1000>;
>>                  interrupts = <0 80 4  0 81 4  0 82 4>;
>>                  iommus = <0xfdea 0x01>;
>>          };
>>      };
>> };
>>
>>   iommu_devid_map = [ “0x10@0x01,0x4f000000”]
>>          • 0x10 is the real physical master id from the physical DT.
>>          • 0x01 is the virtual master Id that the user defines as a 
>> partial device tree.
>>          • 0x4f000000 is the base address of the IOMMU device.
>>
>> [1] 
>> https://www.kernel.org/doc/Documentation/devicetree/bindings/iommu/iommu.txt
>> [2] https://xenbits.xen.org/docs/unstable/misc/arm/passthrough.txt
>>
>> Regards,
>> Rahul
>


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:44:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:44:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.430998.683407 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzR7-0006xj-CZ; Thu, 27 Oct 2022 09:44:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 430998.683407; Thu, 27 Oct 2022 09:44:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzR7-0006xc-9g; Thu, 27 Oct 2022 09:44:29 +0000
Received: by outflank-mailman (input) for mailman id 430998;
 Thu, 27 Oct 2022 09:44:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yXv3=24=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1onzR5-0006xG-V4
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:44:27 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id f1457d45-55db-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 11:44:25 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18D164B27;
 Thu, 27 Oct 2022 02:44:31 -0700 (PDT)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DDAC3F445;
 Thu, 27 Oct 2022 02:44:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1457d45-55db-11ed-8fd0-01056ac49cbb
Date: Thu, 27 Oct 2022 10:44:21 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
 <stefanos@xilinx.com>, <julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
 <bertrand.marquis@arm.com>, <Henry.Wang@arm.com>
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
Message-ID: <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
In-Reply-To: <20221026183004.7293-1-ayankuma@amd.com>
References: <20221026183004.7293-1-ayankuma@amd.com>
Organization: ARM
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 26 Oct 2022 19:30:04 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi,

> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 64bit cpu register.
> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
> in the lower 32 bits of the 64bit cpu register.
> 
> This 64bit cpu register is then modified bitwise with a mask (ie
> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
> 64 bit cpu register) is not cleared as expected by the specification.
> 
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
> 
> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
> v->arch.vgic.rdist_pendbase. The reason being v->arch.vgic.rdist_pendbase is
> now being read/written in an atomic manner (using read_atomic()/write_atomic()).
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
> ---
> 
> Changes from:-
> 
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> appropriate commit message.
> 
> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
> v->arch.vgic.rdist_pendbase in an atomic context.
> 2. Rectified the commit message to state that the cpu register is 64 bit.
> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
> clear.
> 
> v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
> in __vgic_v3_rdistr_rd_mmio_write().
> 
>  xen/arch/arm/vgic-v3.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..1adbdc0e54 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>  
>      case VREG64(GICR_PENDBASER):
>      {
> -        unsigned long flags;
> +        uint64_t val;
>  
>          if ( !v->domain->arch.vgic.has_its )
>              goto read_as_zero_64;
>          if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>  
> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> +        *r = vreg_reg64_extract(val, info);

That part looks fine now.

>          return 1;
>      }
>  
> @@ -566,25 +565,19 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
>  
>      case VREG64(GICR_PENDBASER):
>      {
> -        unsigned long flags;
> -
>          if ( !v->domain->arch.vgic.has_its )
>              goto write_ignore_64;
>          if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>  
> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -

I don't think you can drop the lock here easily. If it would be just for
the LPIs enabled check, that'd be fine, because you can never turn LPIs off
again (but that would deserve an explicit comment then).

But down below you do a read-modify-write operation of rdist_pendbase, and
need to make sure no one else is attempting that at the same time.

Cheers,
Andre

>          /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>          if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>          {
> -            reg = v->arch.vgic.rdist_pendbase;
> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>              vreg_reg64_update(&reg, r, info);
>              reg = sanitize_pendbaser(reg);
> -            v->arch.vgic.rdist_pendbase = reg;
> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>          }
>  
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> -
>          return 1;
>      }
>  



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 09:45:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 09:45:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431003.683419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzRh-0007cH-LD; Thu, 27 Oct 2022 09:45:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431003.683419; Thu, 27 Oct 2022 09:45:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1onzRh-0007bl-I8; Thu, 27 Oct 2022 09:45:05 +0000
Received: by outflank-mailman (input) for mailman id 431003;
 Thu, 27 Oct 2022 09:45:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SB4N=24=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1onzRf-0007G5-F9
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 09:45:03 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2060.outbound.protection.outlook.com [40.107.22.60])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07637543-55dc-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 11:45:02 +0200 (CEST)
Received: from AM5PR0202CA0003.eurprd02.prod.outlook.com
 (2603:10a6:203:69::13) by AS8PR08MB8249.eurprd08.prod.outlook.com
 (2603:10a6:20b:53f::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 27 Oct
 2022 09:44:59 +0000
Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:69:cafe::81) by AM5PR0202CA0003.outlook.office365.com
 (2603:10a6:203:69::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend
 Transport; Thu, 27 Oct 2022 09:44:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.19 via Frontend Transport; Thu, 27 Oct 2022 09:44:58 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Thu, 27 Oct 2022 09:44:58 +0000
Received: from 28f4353d5a90.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2263CF60-E684-47B1-922B-62AC8E5024CA.1; 
 Thu, 27 Oct 2022 09:44:52 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 28f4353d5a90.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 27 Oct 2022 09:44:52 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB4PR08MB8128.eurprd08.prod.outlook.com (2603:10a6:10:381::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 09:44:50 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%9]) with mapi id 15.20.5746.026; Thu, 27 Oct 2022
 09:44:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07637543-55dc-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=hqC6Z40JBzfNsq1NMqYxSwKw4osoTUh6oad1EwlgK0j9ubfVtwZOLIO+sCrq1hsjrB6dPJ1FPTc8wgjePSVEUqg3vlyVt4tFWmwh5rP9JQi2p+Zaf2/JrXSRqzUdtC2UCJm3/VQTUc72ajeaOQ4qK1OYLaETLSMT+dyWnmrr5XFeZUDwSwF3kroMg8duXHxZZkAq7VHjmpkMf4m5v14BbXLbuqmkbasP+HXv4oCj5CHwTnhKNrNm8Tuvm92745wv9rDLXgfjZXRJmTgMYVN+RmcveomJcLTZ20IAIduHTkwvKK7p91jkOZ2sif5WeLTAdsHm5r6z8xlu3lWbgNdhCQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+GqDSzTcP9Tts7cKFiO7kcYHKfFCWgvBLgGLUVOukqQ=;
 b=DGTjJqE8mTPWiVKMJyNIlRCGOAQ6HTIUBbLoMBnktZ1QILXVkimJqrkjfKo4rswBQTtq5FWNVKq8lnG2+fet0nJmvI+tjkq8X0JXcY37bWxgowCMO7i5ZDsFZ69jZgshAy34noG/bAZul1ROXX2NAQUWbt+llphcZPQCRk8yAeSqtm5WhSwHzyHV6f7JlwuF/ZhwQJtuM5/PAFNxVtQYO2bi1Bw10Ke/pEfEcpBGMTDNDEybXFPqr9wIk+IJHrV/g4NIMZlwo6xqoWwwb/xDzbnR74qZk0cTmLFlUAGiLg7GR0MR6eStPtAkJVFNgixlH7nHTQ/GLfYCb+Qvr6XPgQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+GqDSzTcP9Tts7cKFiO7kcYHKfFCWgvBLgGLUVOukqQ=;
 b=VEz7XawOY/CbWggX+1hxKLcrTsJ6s2l0hhs2rq2LnLVcG4LCv67yWdUBFqeI2h4IxqhkaEvOk92jAK13s8Z68Cd581W1N+AbFlb5tEMXoTSU1fQkryGajEArI1WObM24T/PzYx19hQt3n5ETm+hddBOC/4ubDsFdLFc5u9iviwo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jPPhgXrLR7EJYowQukxbE5TH9FAJoDochKVUi+I8IeZRdEr9w0Iw5s6f7BgKdZgAp2I5fGi+Nq6+ftTV2H4oFG7gCS3zSnzorFyRP3zl+5dXE30BfQZ1DBix1UWZFWkILt4xYaBlH/FyTRcecorqmUdiQ88OdEZzCq+u3dmeqWaQGa8JeKoUnkkdUOuynuijO2vahhqIbBqDzvRx00ZtAHH/DYigayEUDi9OI/TtI/0IFz1ghu6en4t+Z+Pt54tN3Ae4Nz0rj11Y0R7J8U59PYZJyRNROQcSZwUC341znS5Sbqgmgh8g/FK+gO4VHPNK4KMOHwPwF6hn4XqkcRx8/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+GqDSzTcP9Tts7cKFiO7kcYHKfFCWgvBLgGLUVOukqQ=;
 b=E1u4Vy4mSEJe2MW+ON7Ik3Fkuw0CUy76GlscGoStsrybt0vLjqJOEuBfRZnpLSTDyF/3UZhoEaWp26t81iGx4kWaQJmp+4FW00zh2u/vg5IlyZ3c9jdkIoBjVF+vrSp66LnRYI6S9y9eCn2Irhl6Ib5F0IhgvP6Y6eHkOfJAwes3/D/uwaHZRQ+l5lJZT89dvoVIAw/YV87LYB+BVievUErzYTSDRq7/icbPPHLmqYZzbDRo7nS3gQ383o3Gick4mUZO08rvc99vxE1y2bvV6u/Y3yfkfbjmUxwk3zujEs26c4UWRYakO9SdemITSJKPNTe/LTGUmlvnaKnsvIKORQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+GqDSzTcP9Tts7cKFiO7kcYHKfFCWgvBLgGLUVOukqQ=;
 b=VEz7XawOY/CbWggX+1hxKLcrTsJ6s2l0hhs2rq2LnLVcG4LCv67yWdUBFqeI2h4IxqhkaEvOk92jAK13s8Z68Cd581W1N+AbFlb5tEMXoTSU1fQkryGajEArI1WObM24T/PzYx19hQt3n5ETm+hddBOC/4ubDsFdLFc5u9iviwo=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: RE: [PATCH][4.17?] x86: also zap secondary time area handles during
 soft reset
Thread-Topic: [PATCH][4.17?] x86: also zap secondary time area handles during
 soft reset
Thread-Index: AQHY3s/RhJ2DvtQvW0uB7kvty9Hpsq4iE7bg
Date: Thu, 27 Oct 2022 09:44:50 +0000
Message-ID:
 <AS8PR08MB79919E113D8FB00AE19B711B92339@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
In-Reply-To: <c80390e6-b9c2-e15a-b513-ec97e8329ad8@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 90C4D06E9F6D7F44B033D4BD9AD50C79.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB4PR08MB8128:EE_|AM7EUR03FT031:EE_|AS8PR08MB8249:EE_
X-MS-Office365-Filtering-Correlation-Id: 7888f957-465a-4626-311d-08dab7ffe97a
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 L3g6/wYuzQM1/61PBL61FvbFHLXS9O4JU0Rd8SdoVoOuVjwFUjlWohCVYJ0UomsGtXXG7twUZ780Pd/e0a62NHtVdlHQahrVWoO7hMOyv6qMrVM44NQpIRXGL7b3/6kaLJCccfEG1OJp+trzBBAW8HbnToGjgeWOSOWp5GqYVw27AJ6hAI8XdC7Liq0nwIavOQAHLcBBJ/S5jTl4UII8CjboXoXs9jTvd6DuOvWiBSuDLrSeYq/VkgPHu8VaMIAgNSrdnw/OeEcIj8InJmpz37w/Aak4ZIJC6yyP/JPRbHTOfLniHj9zQ0J9uSS4ov6QcxXsVsNHE7EUL4yjLMtIXzajuAEDra3bHNLsKcpqkboBgJ/WZsacSl9YNjSYLZ2EaVWSaA57H2w+2Jw+/DWewQg2JDlTkFTidRBzC3ckNd618mNm2mZE6zt1MDpe9lce4srlCGOwTHRMxtWaAKJvOYel+xnr2nu1VjbnEJ+yAITEUC4u19BctugEfF4ZahoCYrReQeH0PP/Vh5A6UbLCdey6sBo8u+cN4y8FMEtL3ohD88Q2E18WuS4Q716Sp28k1Ttfc3yZ39Xnudl4f0L6ZNrbwXfJS+xl93g/NcRcIZoPIH6ZZyOZRkNLEO7RCKusiEd5XSmtYAvarU80v5ktLSNpoMyyfbJoSfxNsGaUuo9L/oKvsevHJUSSD4uuZCYWLUwzZcnBA/wKVH+3/diFbFR+5lXRMb6bFAM/Oq1JoBNe1CrIcejy7FSelxTaar58jC5oQreFcZlaw8O4PXyzag==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199015)(478600001)(71200400001)(83380400001)(86362001)(41300700001)(9686003)(54906003)(8936002)(26005)(66446008)(66476007)(66556008)(33656002)(4326008)(6506007)(52536014)(8676002)(7696005)(76116006)(64756008)(66946007)(4744005)(186003)(2906002)(5660300002)(110136005)(316002)(122000001)(38100700002)(55016003)(38070700005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8128
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	252d9b88-c510-4366-d15b-08dab7ffe471
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RXR8rDn/WHvjZuMFV0A9pjwzqkJEk+4uIp+C3QTQb9Ucj4QlKasS+ZvV9fc+hfULxXmMpPmwS/stfILUhPMrefHYbEr5d2tChxdI4JCQ1R9nH6j6tKRyjMEmJ5/rX2jPau3MbGzF4gkNLx0NU+LFwZFlAEa00oBFzPtKUuRj+V/8W5LuJvivjPMoE48m3nSfsp2TLGqwaX43qX7VuwIOvHgrmjTZoTsBGhxKDrY4TBSZj6QohFZSW03eTFY4JB+W5QK+tIE6aT8Zh89TVI8kb7mZ2uCL3e6xbTTiSq8ugV3dMUVy0dTeFd7cYYx7HIctKsTcmuIChwuY31YWAM1dGBh7FiQbWm7FhvvgThlCYJRQesgwRXTFW9Up7W9WUI41jT8GO4r7w8f1MeBcE92Z7dgF5cpr05MgawV4bG5TfOXc4s1aB7NoGYczVtg7lXvSwhZ9IajPb/GXK6GLmq7/ZLmeZKl5APtPpOQLrJSk+k8kXzx5Me5BFmNz6jUTaQk4oLuDubVZ5/JUiRyCK2MrL3J3WmOf+Q0jveZ3hxnrbIL91rBxvtW+g3U4FTqlCyS2wbk8XLrc6PtJhQoiLgCFgU1bV6oAbLTpdSs98duqpsjywZgba+Phyia3My9mcYvYe0VaEN5IyN1khLlukclZ9xjECcwQxCTI083oHOqYBkq3L+AHC1Kgm6Yfv6b8MFFdVxXKTXGGGOfwxS6V7jXWwoMxAj4c6UTIR3dQ1Irgx9MnWyiZ7Dd+YpXjp1JpsXH2WEMWwsXsYoblMhEGgEzXgw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(82310400005)(81166007)(336012)(478600001)(47076005)(2906002)(40480700001)(4326008)(107886003)(356005)(186003)(82740400003)(6506007)(8936002)(4744005)(36860700001)(33656002)(316002)(40460700003)(8676002)(5660300002)(52536014)(41300700001)(83380400001)(110136005)(9686003)(86362001)(70206006)(55016003)(54906003)(7696005)(70586007)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 09:44:58.7364
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7888f957-465a-4626-311d-08dab7ffe97a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8249

SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogW1BBVENIXVs0LjE3P10geDg2OiBh
bHNvIHphcCBzZWNvbmRhcnkgdGltZSBhcmVhIGhhbmRsZXMgZHVyaW5nDQo+IHNvZnQgcmVzZXQN
Cj4gDQo+IEp1c3QgbGlrZSBkb21haW5fc29mdF9yZXNldCgpIHByb3Blcmx5IHphcHMgcnVuc3Rh
dGUgYXJlYSBoYW5kbGVzLCB0aGUNCj4gc2Vjb25kYXJ5IHRpbWUgYXJlYSBvbmVzIGFsc28gbmVl
ZCBkaXNjYXJkaW5nIHRvIHByZXZlbnQgZ3Vlc3QgbWVtb3J5DQo+IGNvcnJ1cHRpb24gb25jZSB0
aGUgZ3Vlc3QgaXMgcmUtc3RhcnRlZC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNo
IDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVu
cnkuV2FuZ0Bhcm0uY29tPg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 10:32:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 10:32:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431012.683442 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo0BU-0005Qz-Kc; Thu, 27 Oct 2022 10:32:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431012.683442; Thu, 27 Oct 2022 10:32:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo0BU-0005Qs-HJ; Thu, 27 Oct 2022 10:32:24 +0000
Received: by outflank-mailman (input) for mailman id 431012;
 Thu, 27 Oct 2022 10:32:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo0BT-0005Qi-Gm; Thu, 27 Oct 2022 10:32:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo0BT-0000Th-Ei; Thu, 27 Oct 2022 10:32:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo0BT-0004LA-4l; Thu, 27 Oct 2022 10:32:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo0BT-0006PB-4F; Thu, 27 Oct 2022 10:32:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ksjqB3cEDXi1ZEejxYhX+vbd3GCkShZxAFoXJ7PGBgY=; b=A5lWuWl/2zfAsU4qy7wFb36lsp
	WkySiLQbfeMny6FI5DG6i+A82UhBRN2i//ShL3VDh2ME0bGoMhSkX7y7pBk1yWvyD+O5k3kRZlKe2
	pQVglCqwkzo9FWVmU5oVyQf84a/kJY6PDJV3CsGEnwFut+bRc17LLuEtnWEyMCAN7Ksk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174490-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174490: tolerable trouble: pass/starved - PUSHED
X-Osstest-Failures:
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    libvirt:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    libvirt=a6474cfe4806ef90a4621b509d202b7efd8fd09e
X-Osstest-Versions-That:
    libvirt=454927368f5623b77d9ef20e28b82037d8a952e6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 10:32:23 +0000

flight 174490 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174490/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 libvirt              a6474cfe4806ef90a4621b509d202b7efd8fd09e
baseline version:
 libvirt              454927368f5623b77d9ef20e28b82037d8a952e6

Last test of basis   174434  2022-10-26 04:23:08 Z    1 days
Testing same since   174490  2022-10-27 04:18:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michal Privoznik <mprivozn@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   454927368f..a6474cfe48  a6474cfe4806ef90a4621b509d202b7efd8fd09e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 11:35:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 11:35:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431020.683459 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo1AU-0004VN-EU; Thu, 27 Oct 2022 11:35:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431020.683459; Thu, 27 Oct 2022 11:35:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo1AU-0004VG-BI; Thu, 27 Oct 2022 11:35:26 +0000
Received: by outflank-mailman (input) for mailman id 431020;
 Thu, 27 Oct 2022 11:35:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oo1AS-0004VA-UG
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 11:35:25 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 70ab94a0-55eb-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 13:35:22 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DM6PR12MB4235.namprd12.prod.outlook.com (2603:10b6:5:220::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Thu, 27 Oct
 2022 11:35:19 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 11:35:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70ab94a0-55eb-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SEZVoj2DKxs3jtMymDEUvUW3bDsMCIQbuU/pfuN+sTSREwlsYJ4pdvH25efXcoKcn4r8lThZTDCbaRTOu+mKN6M5q3uKdPzYSi3/74VVnmUrEVPAJAt8qcrj8mK1KQRoYp9exR9RqfpX1A5z0OoE6K4b40M1PbvZbmvzXa/6lmfnB1euv2+WSmA1J0g3SX9RsOLgrMf8tapJqeC2BCJtGln/GwvokiotpRPFnWRRL0uKwErgfsMaShzOFgWPcDAPnFVC4mkxHFWFoRVZoZaasKg6I+T6ffyPMUcLDbpKgkYinGAWAOdBKKXyr9X6oRtqpMjqCXmj0xKZOp9uTO6A/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oVfX0Aryh8o2SWZb+BKO3OPNPiM3peaM0ZlSDjIa5NU=;
 b=DAtA8dkxsCbK5n+bI2iANAW29wu5lMEocTy3ZC0KknqVMnft49BWHX1CBMhldFwCVH7L39sQNB7dUyTjgvx5H5CO25Sv2W2Gg712BLnxTeRBHDNfZolrEZZ0Dh12W5oYiCEoj+NWalHkUiyZb4KtCCVgKI9ATRtOiPKgQvrZyHSlVkRLqyfejb+GvcN1F7+WsDKwHn3Tp8N1794J0Va7hQ9lwvDdRjP8F/pWC+br06ScOZ0vw7b8grY84bdKEaIiaAGR62D1ARPqoLNr9Qus3+6a0j1YqxUk9gjGAlX0zmLUkXhrC0KyEY1aejbXDktx9/AlxQZjgf2+OkYKZN5rDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oVfX0Aryh8o2SWZb+BKO3OPNPiM3peaM0ZlSDjIa5NU=;
 b=Q4BZRE0KQWQu8gQPGmCjOuXp83hdkRB141udy2obVK5apQpcrHP+tlwH8o3j66BpBsN9hWEQTVA1QIRpLiD/t47kHHzhtcPizFG9wR/Ggl8KvQgy+Dx1Fqk1TF8dpb72pewfkn8xLuyc1eE4nmTcfjUpbkCNKYlIh4K2/SDFVMc=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <ad1e55bd-207f-4d9d-f84f-00ef5ee604bc@amd.com>
Date: Thu, 27 Oct 2022 12:35:13 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: Andre Przywara <andre.przywara@arm.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Henry.Wang@arm.com
References: <20221026183004.7293-1-ayankuma@amd.com>
 <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0409.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::18) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4235:EE_
X-MS-Office365-Filtering-Correlation-Id: 847910f8-5464-4fbe-00c7-08dab80f534f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HiOmxBq33o0iQDf5dc57fJ4jSlj6fvPEERJk+O+PIIjNheRLb32uRWaWU6z/pdi4VVJy1T5cxWFkTkUNeOHiOlwJu19kXamyTJkr2wXO8LFoiVkRfX9kUW2adain5u5oljtiKyPnbloO5k4LF4m4WVJ+PFyN38oqr4DOdq7Y0BbP2RepheGUX9JJm/MwCAdrqf0ONSeBRTGj9Q0vrlgtmrmNzrfhwuWkWNO6rNXWnVlcr/4qmpDqOOlwR6briUZVpvcAy71Wkil+dmNQPuXQj8kzVbo6mA7ndcaLiIQ076+MnfsYxoUaXAigV1n78PG2Ryk7G+wdLiNmVikvufefS+x2nkNO63PQpgYzgMoP3OvgE8lwFNwvmUuDS6ExGDB+r7CHMOT6pLuGgrHYluDCs0k9fImo3kfCDAT++lMVi7vK2fWjTKX3ByaXfrkX8BC2c6xU2A1t5hyBZYX4SBRrUcfEziXaj2pwpto+ywx0dokqfmZ/l9Ufa3AcKnLeLhY98/80JwdaoDWAUhXrNG5HyTNuN0nMQ24xpmMOQ5hc1q/jjjsM+ZHR2WhNHhOZhst8yS1n4MpljNMlOivLjH2XNaHU1CYA9R/Rvmrw3wxzMS1g2lGRjIAAQ+TFbY89v0OZCUER9u4zUT4h0Cayn9poYYdVlCcn0Qs50O5dUdmVLKDTXGfrs4MYfqjROm5GoRewE/HHQ/tQfzLkigucCqfl0edFAimGNL95F3gEtgAXxdzzBsM0y6d1C8Hh8xxhWfRprVDZpHocb75uNcNE2vKFjIwSb5kAqPYYwwNgPo9QC1w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(31686004)(36756003)(8936002)(66946007)(5660300002)(66476007)(31696002)(38100700002)(83380400001)(66556008)(2616005)(26005)(2906002)(478600001)(41300700001)(6916009)(6512007)(6486002)(316002)(6666004)(8676002)(4326008)(186003)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NE9QL0dhR1hQODgvVjladmNzNGtYdGsydHNUYkpab0xKRVREQlN6cEdNNmR6?=
 =?utf-8?B?TzJVY2lMcldRdjlWVXhoRC9EeDRtb1Z2Z0ZWb29XVUJhVmRya0UyeUFaeTlF?=
 =?utf-8?B?Y0hkV1VCeXZxUkcvQW9vMjJFcXlPNCtjaGl4c2JPNVlZaDBzMzhqRkxjanha?=
 =?utf-8?B?Q3BwcXIyUkZWWHBKK1lMd05aSzAvcFMrdTMyMmV0WkROWWVWZDhUcGwvRFo3?=
 =?utf-8?B?bWRueGtLeHVwSWFsVk0xQ1lMN0lDaG5Cc1cxdk9lWnpmTEEza3puTS92S1pk?=
 =?utf-8?B?ZWo1SUgvalh0N3lTQnZ4NmUxVmFSN0o4NVBMaE94bERaMzBtTTdpaEtCbGtZ?=
 =?utf-8?B?SGZaN3FVcU1OK2dabit5eThRcFRLaUFQbStQMkkzTU9MaHJVVkF1RzhaMjNJ?=
 =?utf-8?B?MngzZE15SXRuMkhZTVl2RDh2TmpMbHgrV1pUenovK2NyemVXUmR2WURxZDZQ?=
 =?utf-8?B?ZkJDMDFHWUI4bW04eXdOejRqODBydUpab28xTTJrL2xWaHA5aGtnektxdVpn?=
 =?utf-8?B?SS9FQ0g4TWs1TzhYSVowcDR0c1JQWnVoN09tS3d6TStna1lkM0ZqUmljaGdp?=
 =?utf-8?B?UHpqQmZrU1JsRjBsL2xrVnFUZFdWZGJFYzF2ckhmUmxwaXRCbmJVVTRaUDVE?=
 =?utf-8?B?SE5oOHpzYVgwK1ZRMUpNOUdNYnRndjViM1pXUFNTcWhPY21GOExUS2tPNS8r?=
 =?utf-8?B?cnFBYjk3d3QyV0V1eC90MzFkZHdmUHpjMmFqcjZwaEFBK2JFNE9nWjVCZzhB?=
 =?utf-8?B?M0dEVG9NMG14TWJMaHFmU1NybWFKNkk5MHVZUTVyRXhTRFpiVGFYQ0tlM2t0?=
 =?utf-8?B?V2d6ZHpObFlQRjIybGorUnJ2Tit5WTJUTEJodExpZGd0MnpXMi80T1dZakRF?=
 =?utf-8?B?NXRuRVd5a3A2ckhGS01OMWliZXRHUlRETGNEQjg5SG11MkN2Q2ErSXVrL3Bp?=
 =?utf-8?B?U0h3NUJOV0l0UEN1Mk95MWpGT0piU1MvaS8zd3JmTTZwTEpnQU9XUzJsQkk1?=
 =?utf-8?B?UUxTaDhTaHVhRjBqVWx4eVY0RlBrVXF5MW0ySW1LUkI3UENpdExkM05HOStl?=
 =?utf-8?B?YjFNU0hnajlTNndoTUtpTS8vcDA0cGE5bFpBK0d5cTdpUW5SNVgvTjVCTEZT?=
 =?utf-8?B?UklwSklZMkJjTHR6TC93L29YemJFSUczeXkvamE1SVk2NlVxUFFmL3RqSGVo?=
 =?utf-8?B?bDNjS1VwL0YxWWE1cVg5aEF5VDRJSEI0dmp4NWpwL0MzOGw3SGZaSTF0U2t2?=
 =?utf-8?B?RW5EOUF1UTlEVGJmcExWNjd4bVQ4WFRpY1V1UTJQWnJHdVFFNzBOUGFsUnZU?=
 =?utf-8?B?Q2lvM1FoK1RuM1NnZHpWZ3poTjNtQythMzJlYnpibEpPWlh6T1hCeEdXL2Fx?=
 =?utf-8?B?ajd2ZWRCTFE3TzVSSEpnaWJJM2JGMVpYWERjUTIvcEpUQUNkd0syNHhRSVBt?=
 =?utf-8?B?dGhrZldkRHZKWEVLV3dpZUZJQi9ZRmJYdk0velBRNGhpZy9scDZoOWI1aXNK?=
 =?utf-8?B?Q1pwNVA5NTR3NG9TVFdRODZGUnpPb0F6WnVUMVB4YndjTUZQY2IwZG5yNmVI?=
 =?utf-8?B?UU5WN2R1MnlaV0NDaGZqTlZJQ1p6K1p4LzdRSjVqc3NMVDhzcVk4czhlZ1Zr?=
 =?utf-8?B?YWFqNVNhbFZidjhGRnJKbk9rV0xXa1lYcER4Wi9GVURObWJnL09vQWliY1hL?=
 =?utf-8?B?a1hHRDdjRzFGc3V1a1dHU1ViWEpuOWtTMjJQZG9Rc0lPWTkvWmVhV1Y3K01h?=
 =?utf-8?B?TEplWStBQTlKTXl0c0V4VkRFZGE5c2dqVXN3WjgzVTNHWXBiWE8rWWQzbS9K?=
 =?utf-8?B?WDhmYm1IZThValdhQXp4OTZOZGdod2gyMUVvWjBhMGJCNUJHSTZxcW92TmFH?=
 =?utf-8?B?UGdjRHVwTmdZNXlOR3RtWnBPM2pZWFMyRjU5Q2ZralhocU1Rd0srREREcVdp?=
 =?utf-8?B?bHZDMTllK3ljVm45MVJETmQwZ0RzR2lDK3ZvTE5udTlxdFpTZlBoNGsweGRn?=
 =?utf-8?B?MGplNW5yNEl5cnFTd2pYVXVNeFlSUzlremRIMmZuYllHVWJBcnErYkVNL2pw?=
 =?utf-8?B?Q0VYY0lwL1ZkLzUwVzltQkxyWXlkOGtwblpVc2VaVjU3aDFHRnVJZnBtU0M4?=
 =?utf-8?Q?caFaeO8wL8Yv+4c0IO2GRSCoE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 847910f8-5464-4fbe-00c7-08dab80f534f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 11:35:19.0553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W6Su7/HLOz/HywFJLLmm8ZRlysE+RlDyscTQz1CR0HGrQ+LpaQnXo7+ASvzmSMzMwQGVbzOAHBKRQEjv4AYMYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4235


On 27/10/2022 10:44, Andre Przywara wrote:
> On Wed, 26 Oct 2022 19:30:04 +0100
> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>
> Hi,

Hi Andre,

Thanks for the feedback. Just one clarification.

>
>> If a guest is running in 32 bit mode and it tries to access
>> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
>> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
>> This will be stored in a 64bit cpu register.
>> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
>> in the lower 32 bits of the 64bit cpu register.
>>
>> This 64bit cpu register is then modified bitwise with a mask (ie
>> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
>> 64 bit cpu register) is not cleared as expected by the specification.
>>
>> The correct thing to do here is to store the value of
>> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
>> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
>> vreg_reg64_extract() which will extract 32 bits from the given offset.
>>
>> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
>> v->arch.vgic.rdist_pendbase. The reason being v->arch.vgic.rdist_pendbase is
>> now being read/written in an atomic manner (using read_atomic()/write_atomic()).
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
>> ---
>>
>> Changes from:-
>>
>> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
>> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
>> appropriate commit message.
>>
>> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
>> v->arch.vgic.rdist_pendbase in an atomic context.
>> 2. Rectified the commit message to state that the cpu register is 64 bit.
>> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
>> clear.
>>
>> v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
>> in __vgic_v3_rdistr_rd_mmio_write().
>>
>>   xen/arch/arm/vgic-v3.c | 19 ++++++-------------
>>   1 file changed, 6 insertions(+), 13 deletions(-)
>>
>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>> index 0c23f6df9d..1adbdc0e54 100644
>> --- a/xen/arch/arm/vgic-v3.c
>> +++ b/xen/arch/arm/vgic-v3.c
>> @@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>>   
>>       case VREG64(GICR_PENDBASER):
>>       {
>> -        unsigned long flags;
>> +        uint64_t val;
>>   
>>           if ( !v->domain->arch.vgic.has_its )
>>               goto read_as_zero_64;
>>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>>   
>> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
>> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
>> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
>> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
>> +        *r = vreg_reg64_extract(val, info);
> That part looks fine now.
>
>>           return 1;
>>       }
>>   
>> @@ -566,25 +565,19 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
>>   
>>       case VREG64(GICR_PENDBASER):
>>       {
>> -        unsigned long flags;
>> -
>>           if ( !v->domain->arch.vgic.has_its )
>>               goto write_ignore_64;
>>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>>   
>> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
>> -
> I don't think you can drop the lock here easily. If it would be just for
> the LPIs enabled check, that'd be fine, because you can never turn LPIs off
> again (but that would deserve an explicit comment then).

/* LPIs once enabled (ie via vgic_vcpu_enable_lpis()) are never disabled 
by Xen */

Let me know if this comment makes sense.

>
> But down below you do a read-modify-write operation of rdist_pendbase, and
> need to make sure no one else is attempting that at the same time.

AFAIU, Xen is non preemptable. So there cannot be a context switch 
between read-modify-write.

But I think you have a valid point.

If two callers are trying to read-modify-write on rdist_pendbase at the 
same time, it is possible that caller2 reads a stale value of 
rdist_pendbase (just before caller1 writes). So caller2 might program 
rdist_pendbase in such a way that caller1's update is gone.

I will fix this in v5.

- Ayan

>
> Cheers,
> Andre
>
>>           /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>>           if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>>           {
>> -            reg = v->arch.vgic.rdist_pendbase;
>> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>>               vreg_reg64_update(&reg, r, info);
>>               reg = sanitize_pendbaser(reg);
>> -            v->arch.vgic.rdist_pendbase = reg;
>> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>>           }
>>   
>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
>> -
>>           return 1;
>>       }
>>   


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 12:16:36 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 12:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431027.683476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo1oE-0001BC-PC; Thu, 27 Oct 2022 12:16:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431027.683476; Thu, 27 Oct 2022 12:16:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo1oE-0001B5-MK; Thu, 27 Oct 2022 12:16:30 +0000
Received: by outflank-mailman (input) for mailman id 431027;
 Thu, 27 Oct 2022 12:16:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oo1oD-0001Az-Px
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 12:16:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo1oD-00028u-Gb; Thu, 27 Oct 2022 12:16:29 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.29.62]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo1oD-00058G-A3; Thu, 27 Oct 2022 12:16:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=FJJMI/vWB0SZNbUk42SkCM/ifuJWIC68Bm0gRG/TQo4=; b=EEJ4U8h+opf3MsuoZbb8P/3jbe
	3/1w2TN9j1vgWrUag4xIGYMpFkB4eT5eCRVDefyw8ktFedo0CLTg+9HxcrFerxriT29o53YHZNbvM
	XA6aenflD5yT9Z6rUX77u96xHc3tx9eok83432gcqVQgwSyLMo6fBEEgtBonncZMB89A=;
Message-ID: <917e09d6-ee94-2c85-c35a-2bb8a5bfc6f5@xen.org>
Date: Thu, 27 Oct 2022 13:16:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221025092112.50168-1-Henry.Wang@arm.com>
 <9bec8877-25d2-8d50-6f03-523b806642b2@xen.org>
 <AS8PR08MB79915FB6F828D7650E85BDA092309@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB79915FB6F828D7650E85BDA092309@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 26/10/2022 01:24, Henry Wang wrote:
> Hi Julien,
> 
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: Re: [PATCH for-4.14-to-4.16 0/2] Backports for XSA-409 fixes
>>
>> Hi Henry,
>>
>> On 25/10/2022 10:21, Henry Wang wrote:
>>> This series is a backported series for XSA-409 fixes from master for
>>> 4.14 to 4.16, which cherry-picking commits:
>>> 3783e583319f arm/p2m: Rework p2m_init()
>>> c7cff1188802 xen/arm: p2m: Populate pages for GICv2 mapping in
>> p2m_init()
>>
>> I have merged the 2 patches in Xen 4.16, 4.15 and 4.14.
> 
> Thank you very much!
> 
>> I noticed that the "released-acked-by" tags were removed.
> 
> Yeah, I cannot find any "Release-acked-by" from all the backported
> patches so I removed that tag for convenience of the maintainer doing
> the backport.
> 
>>
>> We usually keep the commit message as-is (including tags). But I vaguely
>> remember that we may have stripped the "released-acked-by" tag in the
>> past. So I left it alone.
> 
> Thanks.
> 
>>
>> Also, it looks like the tools I am using to download the patches (b4)
>> decided to move the "cherry-picked ..." line before the tags. I am not
>> entirely sure why... So I have modified the commit message to re-add the
>> line where you initially added (this is the correct place!).
> 
> Hmmm this is strange...probably b4 thinks this "cherry picked commit" is
> some kind of unnecessary information which shouldn't appear in the commit
> message :)

I am guessing 'b4' is removing all the tags and then append them at the end.

> 
> My initial thought was adding the "cherry picked commit" would reduce
> the maintainer's workload so the patch can be applied without any modification
> but it seems that you still did some extra work....sorry about that.

You did the right thing to add the cherry-pick tag. This is more my 
workflow that is broken :). I will have a look if I can fix it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 12:22:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 12:22:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431031.683487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo1u8-0002cB-FH; Thu, 27 Oct 2022 12:22:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431031.683487; Thu, 27 Oct 2022 12:22:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo1u8-0002c4-BE; Thu, 27 Oct 2022 12:22:36 +0000
Received: by outflank-mailman (input) for mailman id 431031;
 Thu, 27 Oct 2022 12:22:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oo1u7-0002by-8B
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 12:22:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo1u6-0002GF-3c; Thu, 27 Oct 2022 12:22:34 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.29.62]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo1u5-0005Q5-Rd; Thu, 27 Oct 2022 12:22:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nyPPKmCS1j28BPWFcMl8JsK0BaQ8YaQOQoEUDg9JxiU=; b=0ziwU8Mri+kIYcIGdfMzTDI8wF
	Rnwxad51noIQ6o1rQgEjW22wVnKEQxZHkd7GIDNq8XrYHqRYMAwCUN9p3DUd1dIxwh7epI/LtJ6v7
	/mhzoA0B+4BEmUXAf0VaCFoYEGoAFpowUw9GA9dS3issKQQxFvRLBWRjiDaWUh9bhAJU=;
Message-ID: <77793987-d638-deaa-f3a5-4a9aba3d2a30@xen.org>
Date: Thu, 27 Oct 2022 13:22:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare the
 underlying page
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
 <Y1gD7GmclguLZCM8@Air-de-Roger>
 <b9c190ee-f916-b03d-e56f-0a54d93ba948@suse.com>
 <AS8PR08MB7991C7034FE22A68AE77A39A92309@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB7991C7034FE22A68AE77A39A92309@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Henry, Jan,

Sorry for the late reply.

On 26/10/2022 03:03, Henry Wang wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Wednesday, October 26, 2022 12:07 AM
>> To: Henry Wang <Henry.Wang@arm.com>
>> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
>> <andrew.cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>;
>> Julien Grall <julien@xen.org>; Stefano Stabellini <sstabellini@kernel.org>;
>> Wei Liu <wl@xen.org>; Roger Pau Monné <roger.pau@citrix.com>
>> Subject: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare
>> the underlying page
>>
>> On 25.10.2022 17:42, Roger Pau Monné wrote:
>>> On Tue, Oct 11, 2022 at 10:48:38AM +0200, Jan Beulich wrote:
>>>> Not passing P2M_UNSHARE to get_page_from_gfn() means there won't
>> even be
>>>> an attempt to unshare the referenced page, without any indication to the
>>>> caller (e.g. -EAGAIN). Note that guests have no direct control over
>>>> which of their pages are shared (or paged out), and hence they have no
>>>> way to make sure all on their own that the subsequent obtaining of a
>>>> writable type reference can actually succeed.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>> I didn't Cc you on the initial submission because mem-sharing isn't a
>> supported feature, but upon reconsideration I thought I'd at least ask
>> whether you would want to give this a release-ack. I don't really see
>> any risk associated with it.
> 
> By looking at the patch itself, this change seems ok to me, so I think
> I will not block it, but I think Arm maintainers' approval might be needed
> because of the discussion in [1], so I added them for their information.
> If Arm maintainers do not object the change, you can have my release-ack.

The P2M query type is so far ignored on Arm as we neither support 
populate-on-demand nor memsharing.

I am assuming that if we ever introduce any those of features, we would 
follow the same behavior as x86. So:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 12:45:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 12:45:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431040.683506 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2Fs-0005U8-JC; Thu, 27 Oct 2022 12:45:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431040.683506; Thu, 27 Oct 2022 12:45:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2Fs-0005U1-GL; Thu, 27 Oct 2022 12:45:04 +0000
Received: by outflank-mailman (input) for mailman id 431040;
 Thu, 27 Oct 2022 12:45:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo2Fr-0005Tr-Aj; Thu, 27 Oct 2022 12:45:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo2Fr-0002cf-8D; Thu, 27 Oct 2022 12:45:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo2Fq-00021L-TZ; Thu, 27 Oct 2022 12:45:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo2Fq-0006AJ-TB; Thu, 27 Oct 2022 12:45:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AKL6K3izuv/XR9Lu1oaujZ2U3fD86w3iHrU+cBqldlw=; b=Jt2uL+XaaU/6kmki7Da3aK2E5B
	/xeMCUUz5+7l5dkbUeOGIC93BUcLTt/XUmM+czlBJxk70x1Vb6HunsG9k4D7D/hgHjW6lmWyAD1Po
	ArYIucqg5SawbOSzcgbP4bgAmivpjFqrDMsg7GW4WxCudisaB1+ut3P1UIb8q+wCpmL0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174500-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174500: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=20cf0ab774e828dc4e75ecebecf56b53aca754fc
X-Osstest-Versions-That:
    xen=bad4832710c7261fad1abe2d0e8e2e1d259b3e8d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 12:45:02 +0000

flight 174500 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174500/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  20cf0ab774e828dc4e75ecebecf56b53aca754fc
baseline version:
 xen                  bad4832710c7261fad1abe2d0e8e2e1d259b3e8d

Last test of basis   174474  2022-10-26 20:00:32 Z    0 days
Testing same since   174500  2022-10-27 10:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   bad4832710..20cf0ab774  20cf0ab774e828dc4e75ecebecf56b53aca754fc -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 13:23:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 13:23:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431048.683524 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2rB-00025A-Kq; Thu, 27 Oct 2022 13:23:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431048.683524; Thu, 27 Oct 2022 13:23:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2rB-000253-H0; Thu, 27 Oct 2022 13:23:37 +0000
Received: by outflank-mailman (input) for mailman id 431048;
 Thu, 27 Oct 2022 13:23:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/85=24=citrix.com=prvs=2922bd7c1=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oo2rA-00024x-D8
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 13:23:36 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8c13fe7a-55fa-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 15:23:33 +0200 (CEST)
Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Oct 2022 09:23:29 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6377.namprd03.prod.outlook.com (2603:10b6:303:11c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct
 2022 13:23:27 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 13:23:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c13fe7a-55fa-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666877014;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=fkalRipwL4QhzJBlRTC3oCd7uIW7whVV3EmU6EU1m+w=;
  b=eri9ZSEaHiH4Y0knOgQ/b+sUGXiMU6ttrI2YCM/taMKuCqrNetMKGcCv
   fG5UJQXRMFSNsGWpdaYVQlnicN92wF1wzLUA8yIfwl86ENeNgERpowxCT
   MDqmsbDdbfskF6UopUjyzncD7a7bs3RLuvON7BsIb9P6Z8VOdMWS9/roK
   0=;
X-IronPort-RemoteIP: 104.47.66.43
X-IronPort-MID: 83623797
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:ZwXKpa5AlcxiTnyoOOgBzwxRtA7GchMFZxGqfqrLsTDasY5as4F+v
 mtJUWHUaf+DMDCnf98laoXl9kMA6JbcmINiSwRkpSo1Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZhPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5dH2FLz
 +FGGgtVby68gM/s7LySU/Jj05FLwMnDZOvzu1lG5BSAV7MDfsqGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/RppTSIpOBy+OGF3N79YNuFSN8Thk+Fj
 mnH4374ElcRM9n3JT+toiny3LSQzHyTtIQ6TranteBVsHio+TY2EwQYfF3r5qGnsxvrMz5YA
 wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkgJSCRQLuMvssAeTCYvk
 FSOmrvBBzZirbmUQnK17aqPoHW5Pi19BXcLeCssXQYDpd75r+kOYgnnS99iFOuwkYfzEDSpm
 TSS9nBi3PMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U
 LIswqByMMhm4UmxqRGw
IronPort-HdrOrdr: A9a23:v5SlbqkWBpCO5x/4OPZV/5DkeZHpDfPDimdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhRYtKPTOWwVdASbsP0WKM+UyFJ8STzI5gPM
 RbAtVD4aPLfD9HZK/BiWHXcurIqOP3ipxA7t2uqkuFIzsaCJ2JuGxCe32m+wBNNX17LKt8MK
 DZyttMpjKmd3hSRsOnBkMdV+yGg9HQjprpbTMPGhZisWC1/EWVwY+/NyLd8gYVUjtJz7tn2W
 /Zkzbh7qHml/2g0BfT20La8pwTstr8zdloAtCKl6EuW0LRozftQL4kd6yJvTgzru3qwFE2kO
 PUqxNlBMh342O5RBDHnTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZtB+Z
 MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3MciFXtuYds99R/Bmc8a+L
 EENrCT2B8WSyLTU5nhhBgj/DT2NU5DXytvQSA5y7yoOnZt7TBEJnAjtbIid0c7he4AoqZ/lp
 v529xT5ddzp+8tHNBA7bQ6ML6KI12IZy7wG0SvBnmiPJ07Ghv22u/KCfMOlaiXRKA=
X-IronPort-AV: E=Sophos;i="5.95,217,1661832000"; 
   d="scan'208";a="83623797"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bmxXj7c/Oesn8rt0Alzk62EuqMT+IbybG/NfpckdsP35f1xa11QdDnvFOCVV8YMvZ6av/STerHJt8V9ovhue6EewzxTULa6dtjjdmucr3lbP5N97SBWVRHBh9B5jSPvuF8oBwrHe/di46bizZO8Nc1pJP6BVFl8riZpZSwE77DbiL7+x+YAcHDg+YP4QUhOH0wLPFpVMh0LC+lzTeoJ4lpkNBClFA0UNSh03iDcKRKjX5DGUmQp4UCEuZnzdd9QsCeTlyYvlX87pdFgcSK3KfII/EJklxjEe0PafQtKP+ywUVum6Y7qgOId+QwglSNI0vPH2Sz9UpweFYGAYbi6UAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y8UmHt6C/ljxC4lFDsKcFQOxCx0nEIFwa+tGtO4pidA=;
 b=H4XESa+bh20XAPjoJnmlPSdHcfv2y2ViGdmvvDo9Yncx00whV/PWrf27zPt/Qag1KA+wq5kK63nGhzlMG+hCUFC/kNnEhJVnma/WIxcK1fUS7LRbScETTZy2oDT8MnI1/5qoycpq/w4Mtb7kjgQi1TVafZ0yOY3EAfYGuT1aHvUWXfCt8vjgdvKBQgiParmMMqMt7qkbyTaVT4MOuZWKINsE1odZNYYnX+LZTY3yCS7HLAAsRKO2scnsC/ZivLrqIpJ3x8MHfORPprMqiAKX0wnkWfkbOYC1WqFYY5aKJaDHWgvkebMAqrhAxPlWzh0ZCkfpkTBJWrs5JzRy2f7DtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y8UmHt6C/ljxC4lFDsKcFQOxCx0nEIFwa+tGtO4pidA=;
 b=ib1ppPFKZTOiBFLeBLTM3ybLmj5nsOxh6ZsMJsczZtOI91EBtpPnH1tgffG+cg18S5agIwNEyKY88Gv81xrA18hgFfmLEniWuqn4TzsMOfFjR8AkjH557eTry6H4dbOQo8Hq0Zan5HjWbnqcyyz/euUD9rAQ6n1uygyX6Dg3utI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH for-4.17 v3 0/2] (v)pci: fixes related to memory decoding handling
Date: Thu, 27 Oct 2022 15:23:13 +0200
Message-Id: <20221027132315.80592-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: BN9P220CA0026.NAMP220.PROD.OUTLOOK.COM
 (2603:10b6:408:13e::31) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6377:EE_
X-MS-Office365-Filtering-Correlation-Id: 98ec76a1-4683-4009-70f7-08dab81e6e61
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YCbNAwQL9eXZr8rwe5n9Kb53LDvhdbzGDa34gtLloDfe0PxwZmjDX41T7pg4FbSwB1AnWciVZG0jF9pq10cGtHIidpYnmNEq8QJOjihirmn/Nauy20lGYGZKO2gzAaf9MgvtxVo4cyd0WJIJegjFRac0eayq+HE37DmPNn0wtknL8zxc0OfuF53hheBBXBE1RFKBxXcLuzZJZbS1Y3O+mNFo5TEznAlb7XVEVrtDKFKeyiKQgzRTL9DjAKFSo1YY0dhPmSMIcAyMAoNvicbf4cOyaAibnMDSTki430ATqpg4mJfbqpLOluaoIfn2muIzfP9yGVFDOzXvKE5hRcPzifJ1jHyGU37G6P0F8Dr20RllXv7iOJmBeydl9g3HqDsy2XWlf+FonbaUuvjKCl+HTD3cg6af8nRTXNzG1yeoDIGKKgAnda5HyRzl9/H7EgTI7yhTrZM4+eQ3+5melVyZ0FG+tlS9Y/6wMPviW0nqXcN4XGW+eY8SxE8MBvSSRnxAK7eecr25gI3PZ6OzONEE+BthSpOXz47nDqmFDpg1wQQpu0sTWgxvSFc9nBhRnKiEphnuvNhBy0zE6Io/A1Q30hiI89BY3/g/L8Xwzl8aGYsCSQ/81E1jALvOKYkZSyFhR3X2EEhjKapfs+3PevHH20h9OUoRjbt/1Z6axPD3Uhyimq+WJj3giIrUgOzpKg8zDEsy+sVk7+VCIg9oNec1RQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199015)(478600001)(83380400001)(6486002)(54906003)(6916009)(6666004)(82960400001)(1076003)(4326008)(8676002)(36756003)(186003)(66476007)(26005)(6506007)(8936002)(41300700001)(38100700002)(66946007)(66556008)(4744005)(2906002)(316002)(6512007)(86362001)(5660300002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UllXWlFzUktzSFNtdGdPNG53czFWeFNWb0FiV1dPV1dGYkhCRitTOGwvNXcx?=
 =?utf-8?B?QWFZcVlNUU5LQk0yVGhIcEExSWVaVTFlVHFjRUIxQitCM240OW5OK08xMWE3?=
 =?utf-8?B?aktFTzZZdkNLSmxDemp2MnFZK1Z4VFBwSDZRRGVlbmZETmwwaWgvK3JHYUZk?=
 =?utf-8?B?dVI4ZlRCZzVlNG01Rk5rNXNCWDIrUXZPYU4wTW0xMmNrbS9aWk1CRWZycit4?=
 =?utf-8?B?S0hocjFyVGl2dVVQRjhrZlkrbWR5d2loSEJ3UkFJamswSjZidzhrWC9nY2RK?=
 =?utf-8?B?aHRBV2JaQ1NTS2JqbnA4WE1BdnJHMDNVTjZqeXRZMFlsOGRqaVE3amg1SGxQ?=
 =?utf-8?B?cDZmRDgwUU9IdS83TDdUdGNkNkR1TXFHVVVhbjU1emNDSXFqQkxucmMySFFP?=
 =?utf-8?B?cGl6d1dNU1d3WjdKRmpCOFF6YThBUlo3aTRSNmdYQ3NKT2toS2dZVk9qdXJl?=
 =?utf-8?B?YUNHTlBTSXgxZW9KVmRwV3JPM0NhZ2k1U2lRSCtjVGlKak8wdCtWSGowRDNG?=
 =?utf-8?B?eFgvL1dNdlUvOFlQbDRFMHVYTkVOSDgvd1JRbWVET2oraWM0T3JEQVNlQWFW?=
 =?utf-8?B?cEFZa0J0WlNOdFVnNy93RVpaR1RnMWhaRU1OK2lxOVlrVWpqM0RGYTM5dXkv?=
 =?utf-8?B?djBrUWJwMHNQOWN2SzVMUTN5azg1cnhqSEJaRlEzS1NqVW1HaVFqNjFPcm5P?=
 =?utf-8?B?ZGcwL3BmM0Y5Vmk2NDNuS0tGTEtSRHBqQjZNM0lrR21DNjFqM2xwM0E1bWZa?=
 =?utf-8?B?bVVud29IRkdlWVRNQWZKdnZGZEQ1WXY5dGowYXRrcy9NV1REWEVma0ViSTlT?=
 =?utf-8?B?amhESzYwSVBEcEIwNEp0K2V1UFN5SVRlZDIyaUhUcXhKK2FpZzF3bCtCeWg2?=
 =?utf-8?B?aHc0eXdqVkdJSE16WCtRZW5XOHYzeG5EOXh3ckRDbitjdlNjdk16cWVGRVVr?=
 =?utf-8?B?N2RFWUVKdTRvN01VT0lQY1RQSEtrOGVlNG5uajUxNnFMcHFneUtESEdhd1JW?=
 =?utf-8?B?MWRLSUkxMkd2cDF1Nlh2KzYwNFpQdHlUUm5GdnBJUGVabENVSGlUc2pvVGF6?=
 =?utf-8?B?bXJ6TGN1KzRpMTIvYk1NMktHZzg4akczL3lMOVpBZXFVWk9zdHFGMmpIalVw?=
 =?utf-8?B?NG41dXMyMHM1eVlKZUFwNUxiSEEyWHZjeDFWanR2dll0M2xnclZSNGw0SVhR?=
 =?utf-8?B?L1RzeHhNYnJJZzdOblFGVno5SmNNVkhZWlVGaVhKc3RVZ3BjbWk1ajg5NzUv?=
 =?utf-8?B?YUJzaFI4ME4yN0p5U2JzWkg5K3UrMmcxN0ZOcVVlL2JEZkdtc0N6R08rNUtn?=
 =?utf-8?B?Z29Nd0kyYXlucU5jTCtCSTBlTnBFU0lFUmE5OHg1TlhNWWVRY0YxQkNDWFNK?=
 =?utf-8?B?dDZZazQ5VStSK1QyYW1qMytJMnlvWk9OU2xPMUR0MzJFSS9Wak1RNnFhaWVw?=
 =?utf-8?B?OHB6TmpjbW1wbVViL2hON1I2SDErZVpFaGxvYUUzdFFwRjNKWVFud1hQdGUr?=
 =?utf-8?B?QWY4ZFoydmhkQTJ0TUVtNUdSVTdSMUo4aXRFRk1aek5kUTBrMGpJUzJWV3N0?=
 =?utf-8?B?Sm1GOHliTmdQWlcvd1ZJcVduaEhON3NrbGZ6U2F4L0FhWXJzZ1FiWTR6dzlp?=
 =?utf-8?B?Smx5L1pVZ3BpZFpsQnJOWVZFWk82S2h0NGgraEd5TmYwRUdLTGZteHkvSllF?=
 =?utf-8?B?UGlISEZiQzdtcTdwZVB6Nkhyb3E0QjBodEZHSHlSbEw1TGdFMHlyRm44L0Fy?=
 =?utf-8?B?eFFlLzFJdUlDeG9RRjVWbmkwWkZnRTQ0SWQyZVFqejVmWDhTMTNvYk4rV2hQ?=
 =?utf-8?B?VjZVYW9LRXVWcWVCRFpVcVV6VC8rWnlUNlR4dlVidW4vK0lnaXV6ZVJCTUNE?=
 =?utf-8?B?RUZYQVdXenVFRG1rTDI1aWRMKzkvUCtSTkhha29RWE5JeDVFa0lJdHRiREtu?=
 =?utf-8?B?QUM0Z0NPTEFSNTlQLytkSnd4Njc1d2hZNUIrVkpkZk9hbW1QL0FqbXpqZHYw?=
 =?utf-8?B?RjBmRUx0T2JCVm16MlFHVWZtNVd1WTJlUGh1WUZ4Wk1tN1lhMk5yeWI2TEda?=
 =?utf-8?B?VVcyTlEwMTIzZC94SUdDSEZUZlo5dmlxbHM3K3RoNk8yRlNTN3B3Z2R6WkVE?=
 =?utf-8?Q?x2QEYejGjW2pwvNAMFHqOVMga?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98ec76a1-4683-4009-70f7-08dab81e6e61
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 13:23:26.8005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tJY77IUAbqDt3avB0WuFxoWJjoJONYdkc4bfLA31S+Zu0jbNFjc+uIubgND+0X13Rx0nPpivbo1ipFUkzO8Dmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6377

Hello,

Just two patches left, but likely the ones with more meat in them.

Previous series was release-acked by Henry, but I haven't kept the acks
in case there's delay in getting them reviewed at which point the
release-ack would expire.

Thanks, Roger.

Roger Pau Monne (2):
  pci: do not disable memory decoding for devices
  vpci: refuse BAR writes only if the BAR is mapped

 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 44 ++++++++++++++++------
 xen/include/xen/vpci.h        |  6 +++
 3 files changed, 39 insertions(+), 80 deletions(-)

-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 13:23:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 13:23:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431049.683535 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2rO-0002Ne-Sd; Thu, 27 Oct 2022 13:23:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431049.683535; Thu, 27 Oct 2022 13:23:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2rO-0002NX-PQ; Thu, 27 Oct 2022 13:23:50 +0000
Received: by outflank-mailman (input) for mailman id 431049;
 Thu, 27 Oct 2022 13:23:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/85=24=citrix.com=prvs=2922bd7c1=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oo2rN-0002NC-MV
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 13:23:49 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 88e0cb3d-55fa-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 15:23:27 +0200 (CEST)
Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Oct 2022 09:23:44 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6377.namprd03.prod.outlook.com (2603:10b6:303:11c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct
 2022 13:23:43 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 13:23:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88e0cb3d-55fa-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666877028;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=U/sFfRACaJY77fr7H33N73W/nGnZ1foREkrO0xbsYcw=;
  b=AQDlK/WWKoguwTwvgYOQSev8b9mrPYLlJWjHJ47O9LFvDWMA5COgFCa2
   rq/Wea/ZuyoS4A5+oOW1tr0piEZuHdC/Qfbtes7Zf+Xs8IlcNr/BJy9tz
   Kcgb2bVHJBBPDnwcf4oOJ5GI611t60eYvFYZQprFHGTqkuL8+SWlBW20H
   A=;
X-IronPort-RemoteIP: 104.47.55.109
X-IronPort-MID: 83623811
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:mVcLZ67jPFFH3V3oSgSrQwxRtAnGchMFZxGqfqrLsTDasY5as4F+v
 mNNUW7SO/6PamD0c4p+Odi/9kwAvpHXnNdiT1dqrSxkHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws
 Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gZhPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb
 /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/
 jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lW0UN/
 N0IbwsjaxK8pcyHmemZFPZV05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY
 NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLnWSd05C0WDbRUsaNSshP2F6Ru
 0rN/njjAwFcP9uaodaA2iL32LWUzXqiMG4UPIGBrMVGgHSe/E8KKy0TVXyGofS6mkHrDrqzL
 GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAkQzhbeZoZvck5bTUw0
 xmCmNaBLT5lvaCRSHmd3qyJtj70Mi8QRUcabDIAZRsI5Z/kuo5bs/7UZtNqEarwi8KvHzj1m
 miOtHJn3+RVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg
 ZTOs5H2ADwmZX1VqBGwfQ==
IronPort-HdrOrdr: A9a23:VhsRKKA333MmKk/lHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ++xoX5PwO080lKQFmrX5WI3PYOCIghrNEGgP1+vfKnjbalTDH41mpN
 hdmtZFebrN5DFB5K6VgTVQUexQuOVvmJrY+ds2pE0dKD2CBZsQjDuQXW2gYzBLrUR9dOwEPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmfbHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+0+VTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qZ5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 529lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQ5o+a87bWzHAb0cYa
 hT5Jm23ocXTbraVQGSgoBX+q3iYpxpdS32AXTruaSuokprdT5CvgklLfck7wc9HaIGOud5Dt
 v/Q9VVfcl1P6krhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc=
X-IronPort-AV: E=Sophos;i="5.95,217,1661832000"; 
   d="scan'208";a="83623811"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PI51BFXkQ/fWwzzghTpKMQtPfY196xMt/RSSlTSCyKWAMbvwh9k06aPMklfQlL4nTnaGQk1F4/AHOpicDkeU11kSAwp3JL7YqcPBzk6GdS72ZNND29Lz/sigdDR48v6kr/nSfQSVsZyniRZEf6T0vF3g2vOfvFPt5t7+HpxWqzj/ogEijsJulasOld0W+NEblUTx6xsu8JfyfEU/QNwEKolN2BisM5kX6qg9aemcw64w9odg5kUfVoWPJF/Zy3CuVGYdVCgeHOjisF+i1V4smzXYkTxr/VHXGzmf77DocKdPmrlsQy5GxDuLvzqNF/vhqeI32x/YGJM9HbCiimTSXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=igYZqg1x/g0JshDU5Yx+sFod6AtAlB0SWplM18oXcQY=;
 b=ePXEJWPUALfOAtr0jpMY8ar8PoBwM+cVeGx1G6egtPlxkggxdJGoXVS8573cy9sFNeCnn4riF2dDFXXWL1qFW9uc4le/ImD4Djn3yfZw5+6xh5bUVDswvMY//egfv0Uj+UxH/YiKec9nDPSIFHoaoly9Yyb9mr6cTCIuu/Ab8WWRSQ3jGw3DvIRCf8aOdhyNf12vzPVWEEgYwu8U6UxXyr5MK6m+FVFMVHxDttKH+dHVKJJb8WA5ugFykutm89iUFR8pdGDu0McPR+Lv8vK7r40GWxl3/9m3ogEJJlPhT9nTIGhu+ltAwmkU4dZjKpH2I4xJhQ5/dJqSOpc6LlvYLg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=igYZqg1x/g0JshDU5Yx+sFod6AtAlB0SWplM18oXcQY=;
 b=w3cQV+vIadfMOTS7BjMsU5iZt5W918svDLOiNiqHL4UKoKSuyMfSkarcxQsf3rlaq67enNorVv+fj9/mo0GX89izFVM0ea24/+9FnFbfVA2lJSuOpfC/EcLt16GOkBCcFH8VXCQoEZF/46MrnWBQLnqb13OWLx0ZBoQvqlOlfGs=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH for-4.17 v3 1/2] pci: do not disable memory decoding for devices
Date: Thu, 27 Oct 2022 15:23:14 +0200
Message-Id: <20221027132315.80592-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221027132315.80592-1-roger.pau@citrix.com>
References: <20221027132315.80592-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: BN8PR12CA0002.namprd12.prod.outlook.com
 (2603:10b6:408:60::15) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6377:EE_
X-MS-Office365-Filtering-Correlation-Id: d7a7e494-5121-4657-c5a5-08dab81e7064
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/PjSTZePNQwqz5obKwcH9L5IQ67iJdKUw3K5CMmgGVSRgEGkkHdTD4xLxrxkXMV6BS0s/jE3P85ZZA951NyX/kaZo0cpt30JKeVF+csunYqj0taiSfF2XfE2sv32KSNfSKQxNdJ6NvvWOWRCTQjxptk11IlcqpgAN15+VpcScdXTAEKNjQWO9eKU91mXMiHwuqzlleJogY0TBd1ajhyRjiVo89SEC5I/Fbgmy1W11XkZsKqrXFOkzMExblinHAj8FhUYLee8a1773z0Xdtm3P+BqikeJfnDD4inNo1LIZhXlblVYUnI4DxeBN6Gl4YnBXKzurw5RQFXTJKyDMf1FiXaS9JdiL5Sldm46//neUBn8ejIJ3wUILYu/IGLNwJVVx7rNnsVeD/+Srg4fZwdK06ifBCtvHXldxUirFaeYYOOq0KZ3o0V/ga+Ef6QECzhds/vqp4NAkqV7kmJdmpUUTUSn0fTEQ5HTQmVRLL8fkAxYqrqgTVYLxDMK19+IzpKEpAiyuAC9KNJDHVHgTRlYQ0xkekBjgbqN1WUq6cPMllN/N/1/e/xhd6UjPjNTECsMwy3cmmXz1EV0oosuPI1Hg2pAJEc6fYxKR27Fq6xwQHVQ3RBA9xAE1a1q+iRKCKQnB/WrWlTZYlfTKkl7HN4jly37FpuG93J1py14bpYCuBF+LGcX/RwaJod41m4Gp+PmLKF7l3ab6SpkZ9kGCy0QDw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199015)(478600001)(83380400001)(6486002)(54906003)(6916009)(6666004)(82960400001)(1076003)(4326008)(8676002)(36756003)(186003)(66476007)(26005)(6506007)(8936002)(41300700001)(38100700002)(66946007)(66556008)(2906002)(316002)(6512007)(86362001)(5660300002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dVkzYzhIOGN5dWhMNDlCNlp1N3pTK0Vvb1RDM1c3cndGMm5TQTlYVm9HRm96?=
 =?utf-8?B?SENjRjZESzJNTFpzQUFZSjEyY0ltdVpCam5Cd2IrRGtLUDlqYVliRnFQUGU3?=
 =?utf-8?B?R2h2dTI5OW9hZndCUzBRZWZ0akYzUk16c3VRUzhHMG1uMlFPcEFxTm11bDdI?=
 =?utf-8?B?N1R2WjNSQjVCR1JnRDBLZGFIdmJMU1o4NUZGNG5xYWhPWkNOU211UWFXM0Rh?=
 =?utf-8?B?YkYyWVlqaklHdlZNSEE4NUY5TDJFVHlaTmtGbXFHY1VGeFRuL3JCRThaejR0?=
 =?utf-8?B?OXgyU2NPa1lJd3NZZU51d09iSFJPb2xrUGV4VVo3aEV5Q1EwTW52YUxLOWZx?=
 =?utf-8?B?WDQ2Q0pBc0wxQXArOFNlN0YzVksyQ1VOMVg0aWxVcnZoNnlxU3M3TzVtWGll?=
 =?utf-8?B?OVBRQlJsVkRDQUpUd1FRd3YzZE5JNjNaS2FDRlFQaFR0N3d6d2hRdXBXSzMr?=
 =?utf-8?B?OW54UFpFZCtnSnVHb05SV1JyRHpsMFRLVFFpZWZRUkhORDRFNnFnNGQ5bDcz?=
 =?utf-8?B?L0V4Q1FzTUZmbStrODU2M0hLcFJ2U0tqc3pBRjFtT01YSFN1STJVTVVoMjlU?=
 =?utf-8?B?Y0V0dTlOTERUK2pReUJsdXdwQzgzdExpTzcvTFVFOXExV3RQYTk2dFFIZEpt?=
 =?utf-8?B?RjVib1VBczUvN01JK21zSGgydWUxUUhwVkgxSWRmRlNsN3R1YUt0QjdEZEV3?=
 =?utf-8?B?cVZ0Z2xHa3dhR3B4cEdsWE5jY2lmYkZxSlFDSGl4RlZISXJPcFpJMUdVbks4?=
 =?utf-8?B?ZklNVjRLMEpRY01ZalJ2ZzBFd3ZudXJ4TGtKUnNCUmVrczdsSEI5NXh5R0pD?=
 =?utf-8?B?MDF1UUh3d0Q1S2NGZStFODIxZ0k0RTh4UHd2V3lBSWhjTUk3Y3RkUFlpbWNy?=
 =?utf-8?B?NXJ6TG1IaVFqMFJyZDlrdzA1TTlCdkEyQUJSeEZSZlFJVnAyVWhIVjlNS3hK?=
 =?utf-8?B?ZEJENDI1N3RlS0xpSXRSZW5qZHE5N3M1M1BFRDdMcjdIRGxaVDdGbUdNU3p1?=
 =?utf-8?B?U2FXampyODVxQkh1L3E0eGNJbDk4RGxTd0ZwQWQ3ZGJMWGcvSDErRi9pTEh2?=
 =?utf-8?B?MzRLUVdkWnhkQW80cHNITHQrL1N1T1Q5QXFzclFjSmN1ZmJ6dGhhWjBWcUNF?=
 =?utf-8?B?M0RXVy9aTVhtSndtdUhWWlZnczl5MWtKcDEzOVliOHBUTjIybXpoNUZyV3lK?=
 =?utf-8?B?a1JvVnRKaHZhTkRWSmVBdUdHZCtmd2l2bDBVOFdUU0ZROVNhanoySTg5OXMw?=
 =?utf-8?B?NEJGVnBGQkcrOVNocThQaHBxQ0hYa0pBQmlZaEpFM2pMV0JOc28wZVFsSTEv?=
 =?utf-8?B?b0R6VnVYTWF4VjJrU24wc3R2dU84dlJhTjlNc29IMGRvdzVzbkUvakc5Y1Jm?=
 =?utf-8?B?ZFFINnd6VXZxTDVibUs0OHRyaytDaW1zZS8vb3FHcFRzSkk2YzYzWGNSVTBD?=
 =?utf-8?B?Z0luamxjNFF1ZEwvSVVURHRvcWtRcHozM1RDdFVyNnpvSTdSSUlUamhyVWR1?=
 =?utf-8?B?VkJpR2lYNXA3YWhvSy9IemZSdHlkR2ZwWHd2NHBXZzJacDlUZEUzcHlGZ0ZU?=
 =?utf-8?B?MXpkZG1CYUJEZm9NVVp6QkJrZm5qSXlXMmZKZDhwRkRDUDJKTVpraG9mL0h3?=
 =?utf-8?B?SDFrczdseDVleGJXdWgzaFp4Tkl0K2o3UzZDN3VBRVRQenQ3U3Mxc2lNNmlN?=
 =?utf-8?B?ZTVvbnhCRnh3cUJuRnczNnZLTDE2cHhlaVY1SDdJYmZEZVhCdUdFQkNydVVD?=
 =?utf-8?B?eVlzeUVpZzJTenRyVTBxYk0zbHh3MUZWR2FISWJHaVVwTUVkaTJLVWpvK2FB?=
 =?utf-8?B?d0VTOVRqdm9jMVArWVIwcXpWY1pFc3RyQjAxeFZWMnQzYVBiNVc5VytJdW1o?=
 =?utf-8?B?RWY0RVgzdVZCY3dLcERQRVRuZG1HdHBTWDM1U3JKZFZvbXNaUVNmMWRCZzVN?=
 =?utf-8?B?OFc2U3p1cElreTVxNTBDYlhqRGxnVTNYdEQrL2pzejVndGJyME5oQ2dxcjNK?=
 =?utf-8?B?V1IvWHlINUV1czFaOFFIM1Vwbng0QmdndklJdGRvWURpSG9xVWkyV3JHb1dU?=
 =?utf-8?B?TnZlQzUzZU43TUtRbkRDVEsxeGlaeUxhUEVEY2tXS2ZvOHgwQ1Btb3ZxS0hj?=
 =?utf-8?Q?JdMJBJGX5TVkehB8DZuNQ6ayi?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7a7e494-5121-4657-c5a5-08dab81e7064
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 13:23:30.9433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nct6zTIZ3s8McLRjy6ij7GbimV40vd/j0mCPwHOg+fAj669J+L+aDukV8CqDUFJUTDiwjQEHCNC2V2AJ0IlBZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6377

Commit 75cc460a1b added checks to ensure the position of the BARs from
PCI devices don't overlap with regions defined on the memory map.
When there's a collision memory decoding is left disabled for the
device, assuming that dom0 will reposition the BAR if necessary and
enable memory decoding.

While this would be the case for devices being used by dom0, devices
being used by the firmware itself that have no driver would usually be
left with memory decoding disabled by dom0 if that's the state dom0
found them in, and thus firmware trying to make use of them will not
function correctly.

The initial intent of 75cc460a1b was to prevent vPCI from creating
MMIO mappings on the dom0 p2m over regions that would otherwise
already have mappings established.  It's my view now that we likely
went too far with 75cc460a1b, and Xen disabling memory decoding of
devices (as buggy as they might be) is harmful, and reduces the set of
hardware on which Xen works.

This commits reverts most of 75cc460a1b, and instead adds checks to
vPCI in order to prevent misplaced BARs from being added to the
hardware domain p2m.  Signaling on whether BARs are mapped is tracked
in the vpci structure, so that misplaced BARs are not mapped, and thus
Xen won't attempt to unmap them when memory decoding is disabled.

This restores the behavior of Xen for PV dom0 to the state it was
previous to 75cc460a1b, while also introducing a more contained fix
for the vPCI BAR mapping issues.

Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Also check ROM in modify_decoding.
 - Do the checks for all domains, regardless of their privilege.
---
 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 21 +++++++++--
 2 files changed, 18 insertions(+), 72 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 149f68bb6e..b42acb8d7c 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -233,9 +233,6 @@ static void check_pdev(const struct pci_dev *pdev)
      PCI_STATUS_REC_TARGET_ABORT | PCI_STATUS_REC_MASTER_ABORT | \
      PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)
     u16 val;
-    unsigned int nbars = 0, rom_pos = 0, i;
-    static const char warn[] = XENLOG_WARNING
-        "%pp disabled: %sBAR [%#lx, %#lx] overlaps with memory map\n";
 
     if ( command_mask )
     {
@@ -254,8 +251,6 @@ static void check_pdev(const struct pci_dev *pdev)
     switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f )
     {
     case PCI_HEADER_TYPE_BRIDGE:
-        nbars = PCI_HEADER_BRIDGE_NR_BARS;
-        rom_pos = PCI_ROM_ADDRESS1;
         if ( !bridge_ctl_mask )
             break;
         val = pci_conf_read16(pdev->sbdf, PCI_BRIDGE_CONTROL);
@@ -272,75 +267,11 @@ static void check_pdev(const struct pci_dev *pdev)
         }
         break;
 
-    case PCI_HEADER_TYPE_NORMAL:
-        nbars = PCI_HEADER_NORMAL_NR_BARS;
-        rom_pos = PCI_ROM_ADDRESS;
-        break;
-
     case PCI_HEADER_TYPE_CARDBUS:
         /* TODO */
         break;
     }
 #undef PCI_STATUS_CHECK
-
-    /* Check if BARs overlap with other memory regions. */
-    val = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
-    if ( !(val & PCI_COMMAND_MEMORY) || pdev->ignore_bars )
-        return;
-
-    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val & ~PCI_COMMAND_MEMORY);
-    for ( i = 0; i < nbars; )
-    {
-        uint64_t addr, size;
-        unsigned int reg = PCI_BASE_ADDRESS_0 + i * 4;
-        int rc = 1;
-
-        if ( (pci_conf_read32(pdev->sbdf, reg) & PCI_BASE_ADDRESS_SPACE) !=
-             PCI_BASE_ADDRESS_SPACE_MEMORY )
-            goto next;
-
-        rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size,
-                              (i == nbars - 1) ? PCI_BAR_LAST : 0);
-        if ( rc < 0 )
-            /* Unable to size, better leave memory decoding disabled. */
-            return;
-        if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr),
-                                    maddr_to_mfn(addr + size - 1)) )
-        {
-            /*
-             * Return without enabling memory decoding if BAR position is not
-             * in IO suitable memory. Let the hardware domain re-position the
-             * BAR.
-             */
-            printk(warn,
-                   &pdev->sbdf, "", PFN_DOWN(addr), PFN_DOWN(addr + size - 1));
-            return;
-        }
-
- next:
-        ASSERT(rc > 0);
-        i += rc;
-    }
-
-    if ( rom_pos &&
-         (pci_conf_read32(pdev->sbdf, rom_pos) & PCI_ROM_ADDRESS_ENABLE) )
-    {
-        uint64_t addr, size;
-        int rc = pci_size_mem_bar(pdev->sbdf, rom_pos, &addr, &size,
-                                  PCI_BAR_ROM);
-
-        if ( rc < 0 )
-            return;
-        if ( size && !pci_check_bar(pdev, maddr_to_mfn(addr),
-                                    maddr_to_mfn(addr + size - 1)) )
-        {
-            printk(warn, &pdev->sbdf, "ROM ", PFN_DOWN(addr),
-                   PFN_DOWN(addr + size - 1));
-            return;
-        }
-    }
-
-    pci_conf_write16(pdev->sbdf, PCI_COMMAND, val);
 }
 
 static void apply_quirks(struct pci_dev *pdev)
diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index eb9219a49a..d272b3f343 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -115,13 +115,18 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
             uint32_t val = bar->addr |
                            (map ? PCI_ROM_ADDRESS_ENABLE : 0);
 
-            bar->enabled = header->rom_enabled = map;
+            if ( pci_check_bar(pdev, _mfn(PFN_DOWN(bar->addr)),
+                               _mfn(PFN_DOWN(bar->addr + bar->size - 1))) )
+                bar->enabled = map;
+            header->rom_enabled = map;
             pci_conf_write32(pdev->sbdf, rom_pos, val);
             return;
         }
 
         if ( !rom_only &&
-             (bar->type != VPCI_BAR_ROM || header->rom_enabled) )
+             (bar->type != VPCI_BAR_ROM || header->rom_enabled) &&
+             pci_check_bar(pdev, _mfn(PFN_DOWN(bar->addr)),
+                           _mfn(PFN_DOWN(bar->addr + bar->size - 1))) )
             bar->enabled = map;
     }
 
@@ -234,9 +239,19 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 
         if ( !MAPPABLE_BAR(bar) ||
              (rom_only ? bar->type != VPCI_BAR_ROM
-                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) )
+                       : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ||
+             /* Skip BARs already in the requested state. */
+             bar->enabled == !!(cmd & PCI_COMMAND_MEMORY) )
             continue;
 
+        if ( !pci_check_bar(pdev, _mfn(start), _mfn(end)) )
+        {
+            printk(XENLOG_G_WARNING
+                   "%pp: not mapping BAR [%lx, %lx] invalid position\n",
+                   &pdev->sbdf, start, end);
+            continue;
+        }
+
         rc = rangeset_add_range(mem, start, end);
         if ( rc )
         {
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 13:23:52 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 13:23:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431050.683546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2rQ-0002dq-77; Thu, 27 Oct 2022 13:23:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431050.683546; Thu, 27 Oct 2022 13:23:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo2rQ-0002dh-4E; Thu, 27 Oct 2022 13:23:52 +0000
Received: by outflank-mailman (input) for mailman id 431050;
 Thu, 27 Oct 2022 13:23:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/85=24=citrix.com=prvs=2922bd7c1=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oo2rO-0002NC-Px
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 13:23:51 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b19e53f-55fa-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 15:23:28 +0200 (CEST)
Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Oct 2022 09:23:45 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MW4PR03MB6377.namprd03.prod.outlook.com (2603:10b6:303:11c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct
 2022 13:23:43 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 13:23:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b19e53f-55fa-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666877029;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=VYmDNmKt0p2+CEpXe0jIDJH4snfwphrxsB4ACulM+Yo=;
  b=Q0seDADDHnt5xZEDzDodyaju4Rz0vaUkwKQ1NfjEXQ5094elUe19UrDp
   nTtt2d7gCVdxJHHeJUv4ZJzJa/zLPSZKUar3pUXZ49GJEcuow26JqkGtF
   Qy6p8PqVDSJt/WuJd9fxpyZzJCc3cQYb0HKaQrQjUeBEG4trO1ayeAYM0
   A=;
X-IronPort-RemoteIP: 104.47.55.100
X-IronPort-MID: 83623812
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:MZ69WqrCQjw+OG8nF8Hm9nDpaUReBmIOZBIvgKrLsJaIsI4StFCzt
 garIBmBM/yJMzCkLYgkbIjlp08D75LUmtcwHVBuri4yRn4X+JuZCYyVIHmrMnLJJKUvbq7FA
 +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYGYpLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR4weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5ms
 sYGAxwpfhq/h/OYwIK8cbVjg98NFZy+VG8fkikIITDxK98DGMiGZpqQoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooiOCF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efxn2hA9JLTtVU8NZXrAfIxGA6KiEvfnmxoPiU1WiZZMBQf
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2
 XeAhdavDjtq2IB5UlqY/7aQ6DatYy4cKDZaYTdeFFNdpd7+vIs0kxTDCM55F7K4hcH0Hje2x
 C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2ONo55xmuVvLKYWrE=
IronPort-HdrOrdr: A9a23:1HBjl67Bf+7s+UpEKgPXwVOBI+orL9Y04lQ7vn2ZFiY5TiXIra
 qTdaogviMc6Ax/ZJjvo6HjBEDmewKnyXcV2/hrAV7GZmXbUQSTXeVfBOfZowEIXheOj9K1tp
 0QDJSWdueAamSS5PySiGfYLz9j+qj+zEnBv5aj854Hd3AOV0gP1XYbNu7NeXcGOTWuSKBJYq
 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbDbQQdDxAqxQGShXfwgYSKWySw71M7aXdi0L0i+W
 /Kn0jQ4biiieiyzlv523XI55pbtdP9wp9oBdCKiOISNjLw4zzYLbhJavmnhnQYseuv4FElnJ
 3lpAohBd167zfrcmS8sXLWqnzd+Qdrz0Wn5U6TgHPlr8C8bik9EdB9iYVQdQacw1Y8vflnuZ
 g7k16xht5yN1ftjS7979/HW1VBjUyvu0cvluYVkjh2TZYeUrlMtoYSlXklXavoJBiKprzPLd
 MeTf01vJ1tABOnhjHizyNSKeWXLzsO9kzseDlAhiSXuwIm7kyRgXFohvD3pU1whK7Ve6M0md
 gsDZ4Y5Y2mNvVmC56VJN1xNfdfWVa9Ni7kASa1HWnNMp0hFjbkl6PXiY9Fl91CPqZ4h6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.95,217,1661832000"; 
   d="scan'208";a="83623812"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EFiqBxu7t0B66oqHnTcgM5NQR/J7XC249WtwBEioBU8e97nDIZ97BeMQNO+UTbl5z/6R12JqzJB8GSmt6wX8zCEfBQyVXMcbUvejAUXfoM67OnMOla9gXn/fX3QNtxXmVbPF8oBuqgBLe4FPzP2QjIUN5P08pgKSVufgyf8pzUN5p9Ssj5XcOwa7x7lGSTG9rzRwWQRjMMYqlkPdLzKFFdUd+z9bMRXtjOB49Mifc1qbOy1qPYlPoOWTOAjXvZLoM1dNv+sKcS3A6xsuXcwuEAeTU9QbDvoyY1KuF5EXuTzNxkRXp+0UCGbxukazRQwJGHBGEfQ6kY4R4EikmIokrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yUXzzGq4VSx8sBvqH8bPi1ynt4HYx3T9gdXKxYW08cM=;
 b=MN0WSZ5gvCcQcQnfdz/to5x4nI+blQoqnKlp6AtQKuL7oCOdG3/ss2TPxwk859BGwH3+DEh0Eqnv9aAAfSPnKsOoSyDyvOJDyy9VDXMvBJ0MDF4DzM1clwK1MvR30jYvVtGLmCiORS1Q6gi3PVj05a6AP/IEvoGeHuRLyNI4te9zDksefohSUQ7tAJoB68WxYAAuWQMc1yP8OLMNOvmdEJeAcPfdyxm3/499oP4hNB4PKpti3KXhGdLMUaQnVS9M7RvaX1D/ZjuJOzgKbzQgh96+Qqg2nn2nmFKsQSPh294TMYQlFLV9j5VT1Fl1VPXRtD+ZzxlnydRTkRqw4FXsJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yUXzzGq4VSx8sBvqH8bPi1ynt4HYx3T9gdXKxYW08cM=;
 b=Hx4Q3l31+rI+hhwH7MNwC39WD8e14BWkHe4rqgKkCC9zIghtMfQYmx4hA3F/Gkjzeugcg8kHjrqhlTMkOungTyWen++T7vOtitCqNKb3fKcZDc+BFZqnPMA1Y66MKPiIoFBCohilPbCdFKQ15XLS01sVkJ+IUhtdAtJYA/y4WDM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH for-4.17 v3 2/2] vpci: refuse BAR writes only if the BAR is mapped
Date: Thu, 27 Oct 2022 15:23:15 +0200
Message-Id: <20221027132315.80592-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221027132315.80592-1-roger.pau@citrix.com>
References: <20221027132315.80592-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: BN0PR04CA0058.namprd04.prod.outlook.com
 (2603:10b6:408:e8::33) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MW4PR03MB6377:EE_
X-MS-Office365-Filtering-Correlation-Id: 924ec5d8-de00-48d6-ea62-08dab81e7337
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	L0iRnEDQzbWMdKqqAdjBuKN65W11XdBwfoYYu/Wy6uagVJOkVU5+sjjh36Hn9Gp7t09JlVEfxMQ+ChpYs0FGS9l09ZJJeYz540t+qS67mNmIVZwmLCrAzcM34PAdBz8X6mTHOFvJl2vnCkM9oACXSe4TgGmOiP0RlxSbn4qp/it1oV0rWLXH7LDJId+f+pRrqg5AWkCNIlED+sScKX1VTHH0v69kNOvmiHK5evaLCNTpymMa2bbrbV4kFmVUBSgljuWXE6C0JcSPnkdJ6wJeGKydrRpIbZMI2rnPEWwyXYFHXuezRkDB6UelXd6bfkJt6JzaFhSkUdliOhtpxR+EW5JruBLDjXAV7LL0o9TTR5ywAwDvjPvamYpv8PEAC1NejDMoM4kG+SOU/rg2rGjNbEc5W0zie6TIJrrfzBHVmmlB20NkwPlPxrK5ovI9gH1aOCj5RJKgCM0QXXKH3POM94QsiiNjhroKGvpv341YJ3iL1Y9/vJj7IYG27gZJGG8C3N7iA/yvR7hLvv61/DLodmXtFe+KDlxeGIiF9xg8K0Z9CkCD2eZvQxD9xn8Iae81c/ugaVeoSD0zJYkfMDaBLSmxNEo2yqn+Z/Pd6WV+XEsr6ji+HTK0Y/xrn8Kek2qU7X29NaOStqPzHS4nM3ak3Haftil5m6b/HtkNtUrn4BqSJfIrW9QOpbPHEfpu5apQhccb3CUUF0HEDAqsg0RPFA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199015)(478600001)(83380400001)(6486002)(6916009)(107886003)(6666004)(82960400001)(1076003)(4326008)(8676002)(36756003)(186003)(66476007)(26005)(6506007)(8936002)(41300700001)(38100700002)(66946007)(66556008)(2906002)(316002)(6512007)(86362001)(5660300002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R3MvQVdNdHYwYU9yUloyODVGZ0FtK1BGS216dEhTRkw2Nk9GMW0vZVN5aEpF?=
 =?utf-8?B?YUNta1ZkMEVCbmdVRUxjemx6QXI0aHhXRUxWd2ZPTi8zQzYwRUZuUUw5dWU3?=
 =?utf-8?B?Q3VVb1hZa0IzZit0STBWbGo0VTJUeSsrUGtIZGhlaUcwc1ZGVkZjK3NkbW9W?=
 =?utf-8?B?MTVjODIwOEJCRm1OT1M3a09jZ3NVMlpxNWppZmNtN2FpZWZGY2FXNzNiejlE?=
 =?utf-8?B?aXlwcmppQ1VNVnI1bHEvQ2N3UHNIOTBiRXdyVkpuOGJrNU5UNS9DcmlpMUcx?=
 =?utf-8?B?R2Y2Q3RZMTA0ajVpVmlvOUdsbngzMHAxa3Q4TDVVTzh2K3VvM0tLQy90MEl2?=
 =?utf-8?B?UTFtQ0M1Zzk3bUlQQmdaaUJ4RTZONWlnSEhRK2ljbC9hQ29VaTZZME1KZTI3?=
 =?utf-8?B?VFY4NXVvVGl2cndsSWVVWGtPNWNZUXFuLythNzlFK1JVcVY1dE8zMmhlclBZ?=
 =?utf-8?B?cUdKSE1Vb0dkekl6YTNCb1ZQRVRCTTJMU0RjQ1FBWHdReVRON2c4c0JCU0tT?=
 =?utf-8?B?NUFDc09zT2xEUC9BU1NRL2wyN3laWHpSN2ViSURaVmNlZlliWlFWTjkxWmh5?=
 =?utf-8?B?R0V3VzhJREhVSE8rL2NOei9RRDBFNDBYMFRNbEVMOXkrVDVFeEtoaG5sSGRo?=
 =?utf-8?B?SkNGUzBNL21tSURwRGowL2hGelF0OVhmQkZKMVE5QmkvQ1RXZ05oMjhZQUxw?=
 =?utf-8?B?V3hTdUlMRWs0MjVzUlpyREE1UFVtek1FUko5YnA3Qk9md09zRHlwVVMva3lF?=
 =?utf-8?B?UktZRDNlKzNaYXNwUFRnaFpEZnBYMzh5Sk12aFlpT0JVbS95VTVsMGs2RHFG?=
 =?utf-8?B?N0t5R1VFN1c0UjBOZ3ZqVW5QUmU1RWYvR2pHVE9qcWpnek0rZVZOa2Zrd3BP?=
 =?utf-8?B?Z0EyY0tJd1pDMEdkN0oxaGo1WmI0NkNrcVl1NFJDbjRZSU5QRXVTa3hsY2M3?=
 =?utf-8?B?TExOMXAyZGJLNXN0dXBkYlFWWE9BVFAxN0NJKy90STVTZEJ4NlVOU000b3Ro?=
 =?utf-8?B?RmE5eW9YK3BobkI3YjJLRndHdjJSQUEweHlDQXRXMVZhODArM1hCYnI1ZnM1?=
 =?utf-8?B?S1VqOHRPakhwR1YwaVNUdVVRTndqb09GSnhiRlkxaEhCWHNEZ2xQR2hRdnVD?=
 =?utf-8?B?aVJsUWlqUzR6QysyeGRIbjFGanl0QkNkSUNLWjhoQmlzVzBoUEpvWVEvRWtQ?=
 =?utf-8?B?dnpSZlkwMGZZc3Ezd0R6VlNtOEV4cWN3VmNReDVFbitUNHltKzREZWw3QnhK?=
 =?utf-8?B?UTFuRFdNVWV0OUJzTEE0QUZjZzhVUEV0eWV5bG9Sejg4USswb2hYZkNKS1dY?=
 =?utf-8?B?ZEhHdDY3M0hyd2YyYVlpYzVzMGgvL0hlUGFjeE9ESWUzSGthNW9ma0tNR2JC?=
 =?utf-8?B?NlNMVUJ2QnpCdk9DTjhoU0h0dUUvclg3SERPVXd4R1EvcEZ2a2ZUclVSdkZD?=
 =?utf-8?B?azZSYmttaFZGdWJJR1UxeWowSUM1YnMvWnk1cEo4VlJrQ1MzZVlkd3lDbXB5?=
 =?utf-8?B?ZzlwcVJiU1lvdTVZYXpiM0k0VUk1TkZoRjcwZ1VLMWhLam1yM1YzbWE0MmY4?=
 =?utf-8?B?bk5SdHZ0RWFvL21YTGR3em1OZUxUQWFBejVlSEwxRkRieDRNQnEwYXNqTGUw?=
 =?utf-8?B?WDdueTFzWnRRQzF2L0NDZVFnRnk5TkQraGUyek5vdGtFeDJxT0RiZE9HSTRK?=
 =?utf-8?B?REQ1MWdJalYvQUZqdVJEMzBGQWlKeEN0MHkweWVtYnhQcUdzSm9pL2lhd3ZV?=
 =?utf-8?B?aEhNc1Bkb2V0TGQ3dlltWW1sRFVjTVAzbFlvellRQ2QvT3I0dU54amowN1Iy?=
 =?utf-8?B?eWZQQW5naDhiMWg3Z1ZlbnBLTlpJeHRZdXZQWXpGOGJxWnRBeVU5ODNOYmdl?=
 =?utf-8?B?VGRkMUZ1Zmp5akVvcW5MK0RsUmMvSVZRZC9RTU9DK3AxMHVNYUFoZG9FeXV3?=
 =?utf-8?B?WTExYWhEc0ZHMXpYREh2Y2ZXN0hNWHFRSUdnZEVHZUd6K2lWZklZQndGcWxq?=
 =?utf-8?B?TWpFUE1iQWlQeXFGWldGV1BaSVBLVzRDUlJ1UGIzL2hPcUpkd28wdGc5UWs5?=
 =?utf-8?B?eVZlRG1pTjBUQnJSNnEwdExLL0Z2Mm5HdHhXYldmY1lQZ2REV29TVStodmJI?=
 =?utf-8?Q?wjJaWrnohwuNphUABHisJXbV7?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 924ec5d8-de00-48d6-ea62-08dab81e7337
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 13:23:35.0732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4K7Wc/XwjOl/pjwrR7athEAG16ev81WQ9kD0V+i5p1OhlWbsnNJ+KNBwOy0TfjFhPLssljKiEl2k3PJlJnLliw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6377

Writes to the BARs are ignored if memory decoding is enabled for the
device, and the same happen with ROM BARs if the write is an attempt
to change the position of the BAR without disabling it first.

The reason of ignoring such writes is a limitation in Xen, as it would
need to unmap the BAR, change the address, and remap the BAR at the
new position, which the current logic doesn't support.

Some devices however seem to (wrongly) have the memory decoding bit
hardcoded to enabled, and attempts to disable it don't get reflected
on the command register.

This causes issues for well behaved domains that disable memory
decoding and then try to size the BARs, as vPCI will think memory
decoding is still enabled and ignore the write.

Since vPCI doesn't explicitly care about whether the memory decoding
bit is disabled as long as the BAR is not mapped in the domain p2m use
the information in the vpci_bar to check whether the BAR is mapped,
and refuse writes only based on that information.  This workarounds
the issue, and allows domains to size and reposition the BARs properly.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Use domains instead of guests in the commit log.
 - Add comment about ignoring {ROM,} BAR writes.
 - Use rom->enabled in rom_write().

Changes since v1:
 - Cache setting of memory decoding in command register.
 - Reword some log messages.
---
 xen/drivers/vpci/header.c | 31 +++++++++++++++++++++----------
 xen/include/xen/vpci.h    |  6 ++++++
 2 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
index d272b3f343..ec2e978a4e 100644
--- a/xen/drivers/vpci/header.c
+++ b/xen/drivers/vpci/header.c
@@ -131,7 +131,10 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd,
     }
 
     if ( !rom_only )
+    {
         pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd);
+        header->bars_mapped = map;
+    }
     else
         ASSERT_UNREACHABLE();
 }
@@ -352,13 +355,13 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
 static void cf_check cmd_write(
     const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data)
 {
-    uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg);
+    struct vpci_header *header = data;
 
     /*
      * Let Dom0 play with all the bits directly except for the memory
      * decoding one.
      */
-    if ( (cmd ^ current_cmd) & PCI_COMMAND_MEMORY )
+    if ( header->bars_mapped != !!(cmd & PCI_COMMAND_MEMORY) )
         /*
          * Ignore the error. No memory has been added or removed from the p2m
          * (because the actual p2m changes are deferred in defer_map) and the
@@ -385,12 +388,16 @@ static void cf_check bar_write(
     else
         val &= PCI_BASE_ADDRESS_MEM_MASK;
 
-    if ( pci_conf_read16(pdev->sbdf, PCI_COMMAND) & PCI_COMMAND_MEMORY )
+    /*
+     * Xen only cares whether the BAR is mapped into the p2m, so allow BAR
+     * writes as long as the BAR is not mapped into the p2m.
+     */
+    if ( bar->enabled )
     {
         /* If the value written is the current one avoid printing a warning. */
         if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
             gprintk(XENLOG_WARNING,
-                    "%pp: ignored BAR %zu write with memory decoding enabled\n",
+                    "%pp: ignored BAR %zu write while mapped\n",
                     &pdev->sbdf, bar - pdev->vpci->header.bars + hi);
         return;
     }
@@ -419,25 +426,29 @@ static void cf_check rom_write(
 {
     struct vpci_header *header = &pdev->vpci->header;
     struct vpci_bar *rom = data;
-    uint16_t cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND);
     bool new_enabled = val & PCI_ROM_ADDRESS_ENABLE;
 
-    if ( (cmd & PCI_COMMAND_MEMORY) && header->rom_enabled && new_enabled )
+    /*
+     * See comment in bar_write(). Additionally since the ROM BAR has an enable
+     * bit some writes are allowed while the BAR is mapped, as long as the
+     * write is to unmap the ROM BAR.
+     */
+    if ( rom->enabled && new_enabled )
     {
         gprintk(XENLOG_WARNING,
-                "%pp: ignored ROM BAR write with memory decoding enabled\n",
+                "%pp: ignored ROM BAR write while mapped\n",
                 &pdev->sbdf);
         return;
     }
 
-    if ( !header->rom_enabled )
+    if ( !rom->enabled )
         /*
-         * If the ROM BAR is not enabled update the address field so the
+         * If the ROM BAR is not mapped update the address field so the
          * correct address is mapped into the p2m.
          */
         rom->addr = val & PCI_ROM_ADDRESS_MASK;
 
-    if ( !(cmd & PCI_COMMAND_MEMORY) || header->rom_enabled == new_enabled )
+    if ( !header->bars_mapped || rom->enabled == new_enabled )
     {
         /* Just update the ROM BAR field. */
         header->rom_enabled = new_enabled;
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 67c9a0c631..d8acfeba8a 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -88,6 +88,12 @@ struct vpci {
          * is mapped into guest p2m) if there's a ROM BAR on the device.
          */
         bool rom_enabled      : 1;
+        /*
+         * Cache whether memory decoding is enabled from our PoV.
+         * Some devices have a sticky memory decoding so that can't be relied
+         * upon to know whether BARs are mapped into the guest p2m.
+         */
+        bool bars_mapped      : 1;
         /* FIXME: currently there's no support for SR-IOV. */
     } header;
 
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 13:39:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 13:39:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431061.683557 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo368-0005DH-I1; Thu, 27 Oct 2022 13:39:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431061.683557; Thu, 27 Oct 2022 13:39:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo368-0005DA-Dm; Thu, 27 Oct 2022 13:39:04 +0000
Received: by outflank-mailman (input) for mailman id 431061;
 Thu, 27 Oct 2022 13:39:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oo367-0005D4-Nu
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 13:39:03 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam04on2059.outbound.protection.outlook.com [40.107.102.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b6d307b0-55fc-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 15:39:01 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by BL1PR12MB5205.namprd12.prod.outlook.com (2603:10b6:208:308::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Thu, 27 Oct
 2022 13:38:58 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 13:38:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6d307b0-55fc-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MFRmNfY21KL4NazIxSQaX1MXKTsF1KFw9xYelgenO9KoOM9kbZEKToFnvszANZ8yyUlVSBqzhCUYig7NJnXJOqbbLFDYulmDrpMrwSxz5fEF9STKccyLPguqvpIZbpWicxlbJwFUwmWAxQc0eniOQfp/vAMMKJy/eTuHLsUE1dXKY+yr/vt0Zdt2ineQTuhW56iSJiyuxv/NHrvKYHkPHI2ITmKbJjLMsj+x0N4mZp7dNkcWcNZjO6W7xYuHmAE5+Dm0QtJGH4JoUAMkywf78pmMUP8Fm6Zj7fnZDZUevqgFemj8pRuUCSVeMcn1AKZSt2huWPt7MBeY8vImsHVYqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4ih4QiThEgWEnw+Z5gksqekf4rUZ0mkCZ5D35fwR/f4=;
 b=g8ideGILa6X+eyTBCRNpx8lr+W/fvkWb1Swbb3sNyibbOSivHe2Ui9IAhxnSRmvcRIuORqJOmGa41vR2FqVSA2TKuD58NDwV1A9WddK6VT78V/H//JuHLdAhMHxZIZpslTEPlWwR4M6TzHWNn6tHgmjJk3fSDMSidDnbNVtbH1ZpBg1IrRj6TJ11CNwRq8Rj4RI96Ca1Up7q+KGuqjmD9d49r+HIywGrw6fFPEprICswsMFlGN6ocwsBR3V2JGQbu6vMBK+OulegOPW5B7Ij7aJ3SzlBiz0AgRTvWjf7/CSH2IH9lmI9U8i0uvL7HAGz06GVL6Pg2dfYSzz/h1qJCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4ih4QiThEgWEnw+Z5gksqekf4rUZ0mkCZ5D35fwR/f4=;
 b=3tm8Jvl2AkETJ6RxCZdgWLSwQx/Eex5XFCC+BfpD85Q/P8mWfrzyvxGRJWkM91t/IFwGzWrqDe4ArR0feX6447ZTHwwMbhS1nwiF9rzS5uogqYYEJsgD5UlJibXss4uVMWFxJxzlNrhc54yPhd2fTD6ZSArKbk9altjSuoN5ekg=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <7f1bdc88-da6b-9a0c-03d4-319e9d8966d4@amd.com>
Date: Thu, 27 Oct 2022 14:38:52 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
To: Andre Przywara <andre.przywara@arm.com>
Cc: "stefanos@xilinx.com" <stefanos@xilinx.com>, Julien Grall
 <julien@xen.org>, bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
 <20221025145506.5708839c@donnerap.cambridge.arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221025145506.5708839c@donnerap.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0188.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:a::32) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BL1PR12MB5205:EE_
X-MS-Office365-Filtering-Correlation-Id: d968d4e9-a9bd-4f86-4d3e-08dab8209949
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hsYCkwX2k50+fY2eFVFkzix3f/8iVCf4V0Mo7DFwZ6eBrpqX7VeD93fb8iTbWo4Hgyl3SdsKMFFIB/8WWs+S1F/9xRPse3Sn6BYizJH1pJiWorJ39+zuCSQdb5bxnOeHCUEMYA7MUBnzMBFYX+0Qv1EGeOQw9B4a0y0KOYD8h4b1JiPk3agbbirasptXv6klHiJaxKvRV1IsbCtkMlfuN/sLNz+Z+ZJu3g6xCUkSaMFGpE9qFMgwPs/5fY3s5ENDCHRnRUY1U0fxRCbMP+6KkCHhzTzP5P1xetjB8VE0ksELylekygDbBCDr0LWhsK/z3TekcUxD2RcbRvrlCEqX9/Y9lIWCFgHzH9Y1iSodXPSQoewhKcTh3UldshmmsqX0wtE9gXTT7BJ3OJFzfFE57mTbZDz3eTSueHYC+i3YkzXU+gjsYGIQ/UT/NCyUq1cI5WhsZ7oyM+QwFNXoB/qd4uVBL0pmWMT5LvK2k2CJxz7eo9d3/dn4P/zuRsTa3GWDM6f4WH447IV5l/qpldx6HgKoeemFc9p/51AqNlRTiSme6CecAkegzuRNacz2gPyQtqhP+uLSBY/edhCsWtfPaEym816Aet275pokNTQvivhrgntiFMzZRpguLeHikG0Naya8NhxDa3gxS081sMj4hAbMcBhqIvPSe+VWSuD3SQB+VmP/4ucjpCvnj5X/fLWr3gn3GuPnKKVAjUOGUf1dxh6WrYQxh1yaZ1nW7tjFlHx0YBFbcvFSUmDF144Ry2zvjnQZ5MYdzS7qHBi/gVgOYVmfNqdXL6o8vAnlBad+l8w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199015)(2906002)(8936002)(186003)(2616005)(5660300002)(54906003)(6916009)(41300700001)(36756003)(26005)(53546011)(6512007)(6666004)(316002)(8676002)(4326008)(6506007)(66556008)(66476007)(66946007)(38100700002)(31696002)(6486002)(478600001)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SmJMOUp3QzJLUXZlS0t3Zlo2RVEweGZBZEJDL2N6V1RNOUtseEN1T2RmRS9j?=
 =?utf-8?B?M3RsbWNRbldVWmtxNEZ4M3ZBOWxydUg4dUJ0UjhSL3QxZjFXOEZBRUxRSWZZ?=
 =?utf-8?B?alBsN3V1TTljem41OXZQR01IVExrN1A2L0hrTVJuMkROeVJBdGdnYVgwYk96?=
 =?utf-8?B?cXc4OWNNSERBd0dUc2FQNkVYQVBEWnk4OURtWUhRSU9xYU9OU2hKcXEvNXY5?=
 =?utf-8?B?amVHMWVRZ05FcXI2YUNrUjdlR0xiQStVaHhFZ1ZsMUd2RGVsbHJOOG5Td3No?=
 =?utf-8?B?ekJaRWdVMGF2dzRwOWMzNUF1aU1SMmNoaUtBWDJoOGQvbnVCeWZBY0trNFgx?=
 =?utf-8?B?Um9Canhwenh5VVFHRHhITDFqZnYvc2tHWFgzR20xN0dBNnlnd1VsMmVLSUNh?=
 =?utf-8?B?Y2JValZDYzExekRxbXhjQVZqZ0ViR01FcnJrVGZNUlJNUFl1UXdhM2FORWYz?=
 =?utf-8?B?YXBkYlNnNEFhQzZvUG8xajFzdkVIRU5wZFhIaW9LMFlOR2dmd25KZTJZSzg3?=
 =?utf-8?B?bmNRdVRWSnAzMEEwWjlBWUt2WFBnWThNVDNvU0hHR2FjT3FEZGhRTkhmSWtV?=
 =?utf-8?B?SUx5dC8xcTdhQ2N6RTBkUDVSTEJ0dGpmL05oQjN3azlESGRvY0M0REJLdXRx?=
 =?utf-8?B?M2ZReUpCSExKWGFJTjM4R3c5ZXpMdjhndzRtRnNic0VveFZ4K1I1RVY1YVRK?=
 =?utf-8?B?UnpqcnB4VFJLUGRSeU1Lb2l1NThmS3dWcFQ0S0U1VWsvMTh1NmhkRnMwMUs0?=
 =?utf-8?B?c2wwd3RidmRabksrNDNkSTJ0TGo2RXBsdXdoYTJtUHJVcDRJQ1RETVI4Mnk4?=
 =?utf-8?B?c0NFazdnN0d1eWJKOGc5RGdXSzNiK1kxSE9TdDhmUVNwUUk5dlVvdER5MEYw?=
 =?utf-8?B?UWVFNHRuNlJYZmNmQXYwaWtXd3cwVGtySTVQa1hMS2NJcmlnZDNkR2x6cTlK?=
 =?utf-8?B?WDkrWHgySHE1SzRybHd4dGNWemlRZmszNGpadkU4eUc1WnJDMm1NZWc3cHph?=
 =?utf-8?B?bnNPL2pZTW5mZDBKOHRHc2NLVmwwMXVBYlhHNGw2dWFXM0dMbWdlY3pxTFo3?=
 =?utf-8?B?MC9PaFVIR1ozUndLVWxrTTJBMFlxUTFic3orSWRvWko2TUx2WDVOODRkNmhn?=
 =?utf-8?B?M2VEc29sMWp1aXpyRVh4YklGVzZGUitoajFiUmpHWVBJdHE5Z1FWZTliZVI4?=
 =?utf-8?B?aTdDYnhDUjJMQ3Y1Z2I5akJMUjQzQTJKNzNPSmZVUmN1ZUV5aGVUUmZBN1J2?=
 =?utf-8?B?U2dubEpCb3prMyt2RHVVcGVvUnduMUV6YUpqbmRENEgwcmJtV1pwekNVYnIv?=
 =?utf-8?B?QkZKK0xyRWgrM1l6Yk8vRk5iR1hBcnVwd1NJdFZCSEt3czFtdU9nbzVna2NF?=
 =?utf-8?B?UlJmY0J1MUJiRWtjcnRmekFkcDY3SHRRbHBiNFVKc2RsTGs2eC9KeDA0TDNp?=
 =?utf-8?B?dUdsSFlwY3N1NWFjUTlacmlUbzZQMGRocjRWN05GUTRzKzB3TUtsOVNRbXhq?=
 =?utf-8?B?bXg0dk9aSHIzcW5aNmJpYXQrLytCVzNZZDJQT1JVdUQwcktmZHNaR0hlR2tv?=
 =?utf-8?B?aWp3TytWdUU5UHRjZkhmU05TMERESFIwdk5XdkZpSFk1TXMvK2Z1RXFQbXMx?=
 =?utf-8?B?QjVNSnM4SGhsWFFab244OTRrRUNBalFLQklTbXJYMENMekV6cUNsS1BBOWp5?=
 =?utf-8?B?YVU4eVE2SXVkclhzWHI1M0lvYUxKbTQ3MzJwdEMremlHKzdvekRLUjBGSGJ4?=
 =?utf-8?B?TEZnaXF2OHZPZUgyMHRQYkFISU1PanpiRko2a1p6OEF3b3E5T1lUakRCUTdi?=
 =?utf-8?B?ZDQwZ1l0YWRhS0NaVVY3d2x2ZkVSVlJMeHIzZDJxUGRqQXJzZmZyMEhSYWox?=
 =?utf-8?B?Vncwb0JIMXNKdEJ5WWFhNXdZWEdvNXR2RkRRVXlQUWh6RngwTW1CYnhHU0ZW?=
 =?utf-8?B?MWhLb0ZoNlF1WUM5T0M3NVhaUVZjU1RPZ0srakd1ejNWQUV3bmVaR2RSUGo4?=
 =?utf-8?B?aGVVSXY3Szh0bjNpR3BZSzBIT3ZRL0h5Y2xqNGRkcFp0Y3pVMXh3ZnIwYjUx?=
 =?utf-8?B?aC9CMzhEYTM1Y2ZEUm5BY0VaK1dTZEtMUmk3S1VUaUc5SHprSjhKNVhEQXhO?=
 =?utf-8?Q?xCKMejhH9X6K/vxbe/27awokJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d968d4e9-a9bd-4f86-4d3e-08dab8209949
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 13:38:57.8872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g4EPSzO+U5MnpclHDhIYpy/5oAGefUtNg6YqXMmB3obxwRAksWAq/W8t/0s1UP9qV2CbmHRjcTLor7qWRVF1Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5205


On 25/10/2022 14:55, Andre Przywara wrote:
> On Tue, 25 Oct 2022 13:25:52 +0100
> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>
> Hi,

Hi Andre,

Many thanks for the explanation.

I need a clarification on the issue of atomic access to 64bit normal 
memory on R52.

>
>> Hi Andre/All,
>>
>> This came up while porting Xen on R52.
>>
>> Refer "ARM DDI 0568A.cID110520", B1.3.1
>>
>> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE
>> must not implement LPI support. "
>>
>> Does this mean ITS is not supported on R52 ? I am assuming yes, please
>> correct me if mistaken.
> An ITS relies on LPIs, so yes: no ITS on a v8-R32 system. I cannot find
> this restriction anymore in the v8-R64 supplement, so it would only apply
> to the R52/AArch32.
>
>> If the answer is no, then my next query is follows :-
> Answering to that anyway ...
>
>> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
>> index 9ca74bc321..dea60aac0d 100644
>> --- a/xen/arch/arm/gic-v3-lpi.c
>> +++ b/xen/arch/arm/gic-v3-lpi.c
>> @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
>>        int rc;
>>
>>        /* We rely on the data structure being atomically accessible. */
>> -    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long));
>> +    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint64_t));
>>
>> "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.
>>
>> Is it fine to change it as above ?
>>
>> Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy
>> atomicity".
>>
>> "LDRD and STRD accesses to 64-bit aligned locations are 64-bit
>> single-copy atomic as seen by translation table walks and accesses to
>> translation tables"
> This (and the explaining paragraph) indeed suggests that this should
> work architecturally, if you use normal system memory (where you would
> hold page tables). It would be confined to ARMv8 AArch32 and ARMv7 w/
> LPAE, which matches Xen's requirements.

Does it mean that ldrd/strd will not work atomically on AArch32-v8R as 
it uses MPU (not MMU, so no page tables) ?

If so, then is using ldrexd/strexd the solution for this ?

IIUC "Memory accesses caused by LDREXD and STREXD instructions to 
doubleword-aligned locations.", then the answer seems yes.

- Ayan

>
> But it's only atomic if you are using ldrd/strd, which you cannot know for
> sure in C, because it's up to the compiler to generate the instructions.
>
> This is why we have that test. Changing the unsigned long to uint64_t
> would make the check pointless, since the data structure is 64-bits long,
> so it would always be true.
>
> So given that you don't seem to need it, right now, it would leave the
> test alone.
>
> If you need that on AArch32 anyway, you would need to replace accesses to
> the host_lpis array with inline assembly accessors, to ensure ldrd/strd
> instructions. This seems doable (there are only so many places which
> directly access the array members), but would need a good use case.
>
> Cheers,
> Andre
>
>> Does this imply that atomicity will be retained (with the above change)
>> ? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so
>> translation tables are irrelevant).
>> Kind regards,
>> Ayan
>>


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 14:26:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 14:26:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431068.683574 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3pb-0002wb-5d; Thu, 27 Oct 2022 14:26:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431068.683574; Thu, 27 Oct 2022 14:26:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3pb-0002wU-2b; Thu, 27 Oct 2022 14:26:03 +0000
Received: by outflank-mailman (input) for mailman id 431068;
 Thu, 27 Oct 2022 14:26:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo3pZ-0002wK-Eb; Thu, 27 Oct 2022 14:26:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo3pZ-0004Tv-Co; Thu, 27 Oct 2022 14:26:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo3pY-0000Fq-TJ; Thu, 27 Oct 2022 14:26:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo3pY-0003zL-St; Thu, 27 Oct 2022 14:26:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=up2UZtPhR0NZRJzmnCjBH7a/ovxYD3wZGqaCI5EM980=; b=vRivEwKN6fWY2tXhZGWd6ypKGm
	NUcMI4tswDhmbu5/IBVBgrkIC/dYIma4gcab2btzzUiEqVAv45j1+98emTDy3cCiZ7yXSF9SVTNvO
	x3nD6rz2tQDxYvklIW+25GTl65Gpvvd5Jpv2l8pmcTAPN7uUq+aUcqPMpwSPx3yVjSZE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174448-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174448: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e750a7ace492f0b450653d4ad368a77d6f660fb8
X-Osstest-Versions-That:
    qemuu=0529245488865038344d64fff7ee05864d3d17f6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 14:26:00 +0000

flight 174448 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174448/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174155
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174155
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174155
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174155
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174155
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt   16 saverestore-support-check fail starved in 174155
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 174155
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 174155

version targeted for testing:
 qemuu                e750a7ace492f0b450653d4ad368a77d6f660fb8
baseline version:
 qemuu                0529245488865038344d64fff7ee05864d3d17f6

Last test of basis   174155  2022-10-20 22:37:37 Z    6 days
Testing same since   174369  2022-10-24 21:38:34 Z    2 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bin Meng <bin.meng@windriver.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Laurent Vivier <laurent@vivier.eu>
  Linus Heckemann <git@sphalerite.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   0529245488..e750a7ace4  e750a7ace492f0b450653d4ad368a77d6f660fb8 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 14:29:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 14:29:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431076.683587 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3sj-0003cW-RH; Thu, 27 Oct 2022 14:29:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431076.683587; Thu, 27 Oct 2022 14:29:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3sj-0003cP-Oh; Thu, 27 Oct 2022 14:29:17 +0000
Received: by outflank-mailman (input) for mailman id 431076;
 Thu, 27 Oct 2022 14:29:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oo3sh-0003cF-PT
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 14:29:15 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2067.outbound.protection.outlook.com [40.107.21.67])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac722c03-5603-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 16:28:53 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8952.eurprd04.prod.outlook.com (2603:10a6:10:2e3::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct
 2022 14:29:08 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 14:29:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac722c03-5603-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gGKrn/G9fock1u8k06sqA2WtvBa/vwNueCuJqPoa+7paeBMD3HRLEKUOXXPIO9Da+11MgAiRZ2xNS1s7+eApxLdv8Q744Ha+CQOHGueOIVxeHwjfe5CdvNh2uXQBkpBmb5vuZ0B0x/8Z870Gnsk1nlQKY8tVHY27o3BiVxgBe8qTVx4Cs5jDDIfOIepc4XlEcrAPieazbWXFAh1kxRKtxWMrC6QeyrIBk6qhStnwLJApA6pcfkMloq3/DKITmZi0cf+p+gzhIx30PfIrMrjeJ93lY7mpZA9OFAHA8FV/7wlpzN02rufDwdgWAAz6/YVt6/cfA+tNO1t+iGXbZEM1QA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=25kprHdriuNril/eVKR4vAB0OGMSnilqE15qTFK8Gio=;
 b=HNA0/StC3ZfaJ6NrMTfP0ZNn1XW+NPOgUoqfGWGQolvxBaQwHxQlWAUamYsU8cYhSFt4NzFYr4sUUPwHBxZgimUQ8z3o70+L3hCyNM1TsQGzXT7SJvV4pACIyNclWuaHde3rGREXJe2b+1FhdC0T1B/tsCNWSRFoz6O8X6crI/wpg6Pc9LGuKBZ3tOL4QXyRWQYXCk4A1RR1hjPNq4h/FQhWtpNL8Z2jHLPaVNLM/HeVHcn3waPzkvBa4wKVm3D1Xj+Dag5Pb4zU+UkO14CY8pVfMo4Cd7SXqZNCEnMalXHbcZmXRwHLzJnGG4UcqzRrAljldX2Hb8aDv9WHSERv5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=25kprHdriuNril/eVKR4vAB0OGMSnilqE15qTFK8Gio=;
 b=XNHCe0OsFVt9vXdwsi2LwpCp1Zn62TbEFKwMLlQF8tsNqwDgFmfFRV8T8jN9j379yUbErPNRDH2AZQLUG+0lrLH6LRKg1GVQNx8KtWGYwQGfierAgbJBaqNowGVaNi6MKpjouEHRJRu0ARvqOi3e3gsF4eWKXITVnjcHXg9UErCndXuwVha58GD5cMCCuO+WcC34N7ZOM4q9shiGkqFIoFxTMuExFhExVnLHph4qt1fyWpsPfOH0uE+SJalsX4ZKrRK9D/OyXKoDq4SqpWSoFQrcZFQSsKEXWuUa6ZyEgA9BKpC8a+hfKH8sGUCi8T4bFO45nma0gDmuAb/yvgX5uQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1b8eb76c-2ec3-c297-b2af-7fe0521d6e61@suse.com>
Date: Thu, 27 Oct 2022 16:29:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v3 1/2] pci: do not disable memory decoding for
 devices
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20221027132315.80592-1-roger.pau@citrix.com>
 <20221027132315.80592-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221027132315.80592-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR06CA0410.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::28) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8952:EE_
X-MS-Office365-Filtering-Correlation-Id: d49f3eb1-1074-4baf-6b96-08dab8279bd2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wGC3WWoyxld81Wbm3OZrgOhKO/EAKwLRbQZhfw1H5UDPA1gZWE/gvCOlJTh4gCK8QSWDwANgAW37EgVNh2nr/LQ9zjeSt5hLK4oJu42AbRIM0T1MZlkXJXDP+sN0enxCggqBQnxA/DCqodg4aSPR7+NsDJdMAtqtSzOiVAnSXlMFCX7QuUhxZwx9FPFQMNvBedtQooSCJYEHkrau9UCBxzptHJkCjxY3VFWHPCRc8NnBMrLzm9Zp66eo/o3IDmkU76DRM/HVYcAdfxsVjQSss5KTocDTcjkLn6fvd9C4Jem4rbTUCw+GeIrpQghiBYpWeJRpbzgdn5LfO1k2HcA+ud8n1zR7aoRBh1XSTqJG/ABnlNJKYzZep39p5ltDGLJAlbvhCbXOzRc9qgv14y294CaomOUnLKMR9npLVgTENnWhTK13Mr/qZ8zut6fZqWR2maAgMidAuhQziDloMr8uiLX/FC7KKIDXyZiHZtAaxxfWUOHZfm63N4VzEPBGIKDGt52OlhOqMGmNIXY0/wZlfRc+DJabixNx5icPPkbFjqFL08ma5G91j3G3Q6Z+S+RjOEgch6rwSQYSVS4QmOZdL6nHFD2kMGOhR0JT9RySAjA0b48UbOUo86mInSG7MfMMYlLSiSlo9aRwwuDs6khPCL4ZRY9lZQUDfAtVEEY0+3GRFu6BdpiRNPYQra0oWjTiKzGvSmNcfmed4X9V0AcKGB4Fi6ZC/qOTa1TAxkEhqnBE8fcWeYa7xx5XFzIgCsvDUply72E95rHILn00IwGJai+3hIcj5CgsK8HV4hk0RJc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(376002)(346002)(136003)(39860400002)(451199015)(5660300002)(86362001)(36756003)(31696002)(31686004)(38100700002)(2906002)(8936002)(83380400001)(6666004)(186003)(6506007)(2616005)(26005)(6512007)(478600001)(66556008)(6916009)(316002)(53546011)(41300700001)(8676002)(66946007)(6486002)(4326008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dll2QlJVUC9RUnBFUlNKaDF4M05WUC9zVTgzY3Btc0J2SCtsSSt0L1B1d01I?=
 =?utf-8?B?NUVwSHhFVExDbU85bEtwQmliSzdIMGNTMm5FOVV3dkxwM2VnaGx6WXZPOGZL?=
 =?utf-8?B?RUs1aVNQOHB2eVM0cDN0MHg5YzQwOG94SzlGMCtQWnlVaXBJKytjcEVSajJK?=
 =?utf-8?B?NzJlNWdubU9BTVh2Z2YxV3ErOWVacUtCcXVYN1ZSeCtlRlhXRitrVmcxb2tu?=
 =?utf-8?B?UDNrRVBrUVpYRFM1b1pReDRlbUwrTkU5eDRhYnh4VEFPS0EwY2cvcmNxNEp6?=
 =?utf-8?B?ZzZVYkJvclBTSll3cklRWDFuczg5Qy9LeW11MmZWTmtPQWVFL3JLakdhTFVB?=
 =?utf-8?B?NXZBSUdCYlNNWW5XdkpZT2tsWXduM29sa3lqNmpkeGQwMTJ0QUYvTldmQmZs?=
 =?utf-8?B?Z3VSUGtLMlA1M0gzZVdJUE5xT2swcG0xWVF1dElGNUxLOVpHVzkzenZxTW44?=
 =?utf-8?B?ZldxRXYrZ280WTZLMG5ocXI5bUFLeVdFeUl3TGliZ0RNK2lsTUJYazFCS2l3?=
 =?utf-8?B?Tkd5T1E1NEJoMHRXZVRPb3I1SThkc2VYQmVVakVFdGhaUEczSmdWb0pPLzVM?=
 =?utf-8?B?dXlNNTl3TUM4K28vQ2lQWUY0WElYL3N6QkI1cXdvMmppMzVYeURqeXk3ekIr?=
 =?utf-8?B?WndLSU9JQkoxTGVBdFRWQmdpR1ZsajVXQy84dmlqQ3Q5MVU0VVhIdUJHV2Jy?=
 =?utf-8?B?Nk5QTitOWFBlbVBZS1FWTEZMVTQzNDJLRzNJRHZhUFZrQ1JTWTcybFBvc0NS?=
 =?utf-8?B?VFBPSXJkVmNPMEFjVnR0YUNNbzk0Z0hJa3NoRzVXc1pOc0NJY2o0WHlXN3Fj?=
 =?utf-8?B?K1BpTjExNFcvYUs4YkpHUUNaVExuc1N5ai8vRGluMiszMDhzNXorZ1FzOVZT?=
 =?utf-8?B?dEF3anVMVEFDUm9Za3lKZEpTQ2daSERPVTZlL3pjdEtRRmVMcE51WkR3RTFI?=
 =?utf-8?B?Zmk4STVEQVR6dlNOazVEOEpMREFlY0JWVS90TUxZY1ZFeVkxaEx2T1UwaWVk?=
 =?utf-8?B?bVBEUXRXYkNOVGk1Zk9CWlpsQmlqUkdiRWF6Z3NsdmpsUEJWUTVid0wxaDBo?=
 =?utf-8?B?K09ZZ01HZGUybzlDZ1NLcUJGdmZXSDBUZ2Q5azVYYW9BeVg4ZGxCc01hbzdV?=
 =?utf-8?B?RkhiMmJFV1N0WDdjdndTaHBobU5vZW1ZSjFXVzZDeGxFOGVBdlBYa21yLzdI?=
 =?utf-8?B?Z0wra1NId3RQVGtLSktKc2VsUENhWmMyZlp4TEkxK0R5aThCaUNNeHpuSkho?=
 =?utf-8?B?cVduNnQ3N08va1E4TzVNNk5BVHB6OVJKNkN3dWg0K0haMFlSZytzQWFScEYw?=
 =?utf-8?B?ZmdqM3p3dXZYRE9pR0tlZjQ3ZHNlQVVGOW1VQWhpbnVleExZYVJ3Y3QvQXFR?=
 =?utf-8?B?WXM0ZVNiMmFXa25DbUgvbmZNclkwMlZxRHlndnFZVXZpQlZvRFlreVp3YnBx?=
 =?utf-8?B?VWlHR2NGV21aODcwNUVhbUhOSldWb20zSmpsSEpQOVdUdFZjaGk5Z0ZtczBw?=
 =?utf-8?B?dkNpb2dSc1F1M2dWMTlwRWNWWjErU0ZsSEs4MEY1UzVwK2g4eTJNSitIOWgr?=
 =?utf-8?B?ZXhISit3TFhnU05TdTRCY3RZMHV6d0lRR3RWZlV0NW16L1g4SVdZVlBqajlU?=
 =?utf-8?B?R1RmT3NXY2JobUgxcEJZTGJ6a3ZBOXlCc0pwQWtnL2JzSHp5eW9kajJ4cTFy?=
 =?utf-8?B?amlaY2IxUFBxUlNxY3pDUzlSZTdRSm94ZlBXekhCWjNtT1JrdC9CczlOY1NC?=
 =?utf-8?B?ZFJhMWlCbGFLWkVUVkgzWTZGekFUdkFoSEIxVXhYNzRIZnZDWkNlSTVSSUVj?=
 =?utf-8?B?Y2V2UkV3TDlGdWV1cmNHVytLS0JmTjBBM25DaVFCbzhhcEFQVGFBUHBISmta?=
 =?utf-8?B?WjVCbE16QUszalQxWjV5UmtaWjRNdlU1SjVRam5PL3pJUHV2dnF3bmpJVVVy?=
 =?utf-8?B?V2RZTG9UZXdlejNpZjBjZjYraTFSTWwyOHkxSDNJeWZiWStZd3NCNnhrdS81?=
 =?utf-8?B?UEZTYURHd1hSVGRTTzVFbFQzdTJKblNVOUVoR29KblpCWm5HaVBUYWl6cUF1?=
 =?utf-8?B?ZFQrV0loaFh0SW9HYk9uci8rQ1BzcVYweHRMNzcrT1AwWmYxOTRJTDVncnZT?=
 =?utf-8?Q?dyB45Ml1y06ogyzkHcGEkrhdz?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d49f3eb1-1074-4baf-6b96-08dab8279bd2
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 14:29:08.4934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GpkRM9i4fYRD1YAb+koJsHr76+M0xsW7yW1rx+zh9mI3cgCxOhjHqAn6hQ8TLbhf/0UVmof43P/plIU1qtL86w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8952

On 27.10.2022 15:23, Roger Pau Monne wrote:
> Commit 75cc460a1b added checks to ensure the position of the BARs from
> PCI devices don't overlap with regions defined on the memory map.
> When there's a collision memory decoding is left disabled for the
> device, assuming that dom0 will reposition the BAR if necessary and
> enable memory decoding.
> 
> While this would be the case for devices being used by dom0, devices
> being used by the firmware itself that have no driver would usually be
> left with memory decoding disabled by dom0 if that's the state dom0
> found them in, and thus firmware trying to make use of them will not
> function correctly.
> 
> The initial intent of 75cc460a1b was to prevent vPCI from creating
> MMIO mappings on the dom0 p2m over regions that would otherwise
> already have mappings established.  It's my view now that we likely
> went too far with 75cc460a1b, and Xen disabling memory decoding of
> devices (as buggy as they might be) is harmful, and reduces the set of
> hardware on which Xen works.
> 
> This commits reverts most of 75cc460a1b, and instead adds checks to
> vPCI in order to prevent misplaced BARs from being added to the
> hardware domain p2m.  Signaling on whether BARs are mapped is tracked
> in the vpci structure, so that misplaced BARs are not mapped, and thus
> Xen won't attempt to unmap them when memory decoding is disabled.
> 
> This restores the behavior of Xen for PV dom0 to the state it was
> previous to 75cc460a1b, while also introducing a more contained fix
> for the vPCI BAR mapping issues.
> 
> Fixes: 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 14:31:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 14:31:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431080.683599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3vA-0004zn-7S; Thu, 27 Oct 2022 14:31:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431080.683599; Thu, 27 Oct 2022 14:31:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3vA-0004zg-4d; Thu, 27 Oct 2022 14:31:48 +0000
Received: by outflank-mailman (input) for mailman id 431080;
 Thu, 27 Oct 2022 14:31:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a7vm=24=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1oo3v9-0004zY-HY
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 14:31:47 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15d35175-5604-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 16:31:46 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB8493.eurprd04.prod.outlook.com (2603:10a6:10:2c5::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct
 2022 14:31:44 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022
 14:31:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15d35175-5604-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jgQUXbSfZMtffI3N6Y2NlJ2uZz43fSr9eohvv42Y4NJe4b2oR9C2iB3rKIcMBFLL3gcpzyRmPteWkY0/DCC1LSsiHJGpVGuw3yn/BIkYR46bUE4rFZbLfQXdfp4GsvvDpXF/LQBb9NgtCtvx8EJkjJ/LQkbGZFtrOHIa6uiKgcmw+EXP8F6SuMyZjrvA6f7ITvwopL66fZFbE61DXzL729COgluz7IkHcZCJWeAOwhkLwN487UGLjF/eXpvVG49CyOIb4DgUhoZ1zDYd/RucHjBXjJQZLqsn/zJsVbgVbIgrjT34bDD0YV7alYJaEP9C7r7bI9bN0GkVb9ZoeE36mg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GgEHVT/gYchzDXCf/78mHRzmvt3VdVeADW4P/SMvYxo=;
 b=gJ9FcTA13XFBM2xCqPfTUYeGTPrt4JGR/ejXwhhTt4h1vc376vzKd12zY6PX7QxusTNS02WWNXYscogBwM4v/pYlLC2jyq1C8yOpxvD6GkvwqTkGRPYoQofynJcGjrM8fu+6OsJWFCAAIakQkaQN2QjBGkMsTmoOvOpn8EbHXbaCH8OK5jOPokcN1zk87hnXRIOmCe7HUWoT+0onuFwwEDp95M40gt5bkDRz7W8Unu3mOU2zrptCjZQN3rbcYJaXFae5efYedf6inzBlbxsAE5bKbHg39UpcE5LJnjDd3Ryw2Remwv/f+Kb87YXuiVBvwGcfWwpSw8A8fZs5M/K4Ng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GgEHVT/gYchzDXCf/78mHRzmvt3VdVeADW4P/SMvYxo=;
 b=LhWPhnR2w1or0W0M1jRlU5W2dQNOVeswiL7JIU/wCxEc6UieMb/G8POTVRDDV1fxHD7Vu+oI/6IwirN5C4MGjo79SRtpFccBZz/EC4kdQti81zPV1Y8PhiUfKhBjRpOf6O484OfJ4UDmLcM8FVXqoOlrgyI8qCdonu1xXAoCIvu2H1sJCldB7JESiFvDo6O7Jc2CMkUoieQCTf6zluUl10xgvg7UlVNDgDiqsORHWfEoRJ7Smu7DOhGOCC1Vvgylo7Wy6hCAirmds7WjIS6fYJwBU246PYSEV6hwHefG+8aqPsnijpf/gZtHon2eC0GAUx7cnijq9a5wbjeRNY7YVw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d880aaf-bf23-92ec-c193-b1bc5b84baa6@suse.com>
Date: Thu, 27 Oct 2022 16:31:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH for-4.17 v3 2/2] vpci: refuse BAR writes only if the BAR
 is mapped
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
References: <20221027132315.80592-1-roger.pau@citrix.com>
 <20221027132315.80592-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221027132315.80592-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR3P281CA0099.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a1::16) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8493:EE_
X-MS-Office365-Filtering-Correlation-Id: 2326f240-fc30-44d8-fb2a-08dab827f8ce
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VVmqBxh/eT0ZYaJQjLngl+d3JoqZEuW+hvNQXuaqPjkFmdbVl2ZOY3ifc7zfv+EL8R5TSQcU988qMq+AXrL+rkmgrJ11e9syXJC6IN/TpHh3CHTCfD0xfg6GsPw2RXBFmJzpe0piOTmgM9aw2RAcBlf+I28LwfN4C6U5vRbjdJgOkRsgO38p5n0Hh8bTAflTdJxsIiu/iq7DeGW+WElOqxVgouFmoKASmU9i58DqQH+aCCAqdqsqqw0rBCfeXI+5j9552TMirjctONYczrvlNKvLKBFth+uHX8lMyPmQZrtURU6OuXLFPQxHrwvDiLC3RguOK18IPiRdpoL58g0fQ6TyJey/MS3a8oZd7ZOIlHh/ujXyB2aywnvXDshJeElHmO6CQCeudUCFeA8z3X92LvM4MBDVS6JzwWgZBbPO8xA64HyVhp3eG87NbXDw35usFoMxJg8ViW2+HcnrZN9eDxGG+Bgds+V7itORBSBVYwMjkPUpI8hOCCCUSOqnO1HGmUDawMplYIfyvk5HfPLGP1ttvHDCz8VLlsvJRuUDGH7MK5S7Ar+lhv7b6L8BOfW0qYHF3yLkmVevVZsm3cOGYcD0JwKoO9TWB/q/WhJXpL/wJvdMlolb5UniWRyHg/8IKmaBvH8Yka3nbrt8vhIRX+KXu1dQxJtySnhfaMTus9WicfWt9ioIkbEHj4gXwvqReOpuH45hpWmUJCn+cLwtFX78OTi3ntLG08VKcFRn0x/BdSLyTmIrXObpkWLS96ApqcvfsQuioBZiy3yTPdMS8IJv4HNMeKvAPt1rRgileXw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(376002)(366004)(136003)(396003)(451199015)(38100700002)(66556008)(66946007)(36756003)(41300700001)(66476007)(2906002)(478600001)(5660300002)(6486002)(8936002)(8676002)(31686004)(83380400001)(4326008)(26005)(186003)(53546011)(6506007)(31696002)(86362001)(6512007)(2616005)(316002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MjE4WnFUelloTkZSQzViS28yVVpjL2U4a01hcUh3Y2FPaWxYcXFXNUpKczVs?=
 =?utf-8?B?dDh6SFRkOFZ0cmk0OHdXSmRjTzUvOEpZOHYyRUc3eTd6bTEraWQvU0RDWXJI?=
 =?utf-8?B?ZytKOGlOQkdzNzIzUGFrYmt3eGcyM1h3ZWRYZThJbDNjTVdzQ0FjVldnTWR1?=
 =?utf-8?B?ZXhTWURXZEh1SFNJTjh2Z1MveWJFT3NibGdlUEYydkhod0NNTkRDa1lKMEJ4?=
 =?utf-8?B?UGt3eGcrU21HZWM2aW1TK1lQSVRiV3VsS2hubmttZnpKZ0Y4WUZwU2VRUzdF?=
 =?utf-8?B?OU5ySmh5OFloMFJ6ZTYrRm50SG5nYnluR0JDa3ZZQVc2VjgyTCt0dkY2WEtB?=
 =?utf-8?B?bHd5QmlqV1Eyb29QTm1BQVltZzZaTTQ4ZWdRdW82QlJWc2J0cDNKT0pFVkhy?=
 =?utf-8?B?R01tcDZWYmFTTzUvYTJUL000Y1IrWEZyNjZkdERUWjR0djJEVElBQ3ozbE8r?=
 =?utf-8?B?VkdML3l5TVRzNUhQejljWnZNUnhENGhaVmlaVmhqTkpxMnRCWVBaTHcrazI0?=
 =?utf-8?B?b3JFdi92KzEzZ2NaQlpuSnBiMUlyRjdmcVR5c25mbFMvTHlkcm1hUkFLYjI0?=
 =?utf-8?B?ZlBNbS95QWFYYlRIWU15bVVLajQwaGtpVmtuREdoZmU3VXdkekpyNVk0VllC?=
 =?utf-8?B?dlVvZzgwNUUxM3ZmbjVJZkljMjk0bzhRc1hKM0diMnYzQy9zSk1PWU4rOEcr?=
 =?utf-8?B?ejl1MldBa0Mra0VkTUd1aGJtUEVRYXNjRjArd3JWWmR2Zll1MVdoVGgzRmVr?=
 =?utf-8?B?VWh6RW5VYkdaUVBkY1RRUTliZnV0NXJpSU1VQzlVaTczR0UyOEZZbWFpT2x6?=
 =?utf-8?B?OER3QkdrRTJEZE1Dd0dnR0NRelQwOThwU3lrWlRFaDRmckpCRy8vSEVQTENn?=
 =?utf-8?B?b2NwVExOREFxMk5FajE4N09SRTdBdTlsNUN6L3BjbWM3amJQd3FxMXc4WlY4?=
 =?utf-8?B?U2Z4R1dNSVpyUjFtaktpaFE5b3VNbGJVbnVFby90Q0tPc2ZHaElBc204MGtu?=
 =?utf-8?B?Yklia3hFRWVoRTdwTUIzUGd1NGo3alA4dUZHT3lDQWpnUVlZNFM0TTV4T2ZO?=
 =?utf-8?B?OGdwVEJPSWV6SndPWlZ0VU1saCsyYmZjYzQwbFZrK05rc0xiRjd3NmcxOHBF?=
 =?utf-8?B?WWdlY0JrSGtxdStOYityYzgzU2gyNFQrekFUM1VIdG5Tem03cVJKNEtkY3pk?=
 =?utf-8?B?ZXk5dE5ZclRDeHNCYnNKcGNkVWNnNDJZempDOE1ENmRLWGVlM29UUS9LMXVn?=
 =?utf-8?B?Y05vb2VXc3dTOVkwTTB0SWdSSUpCVlJPOXViSTlZbkZoT3dyRG44UEtOR0lS?=
 =?utf-8?B?a2lyWGEzdk56eUJtVW5oUkc4QWJlYW5YSWhsUDFPdjhEOWFKd05PcnVVQmlL?=
 =?utf-8?B?VG5JNmswQWpxdlhmZmJsTUNFeFhjNkIyeXMwVDZlYWNUeWFtdWI4MmxCeFcz?=
 =?utf-8?B?K3RKaTQvTTU1L285Q3ozcEcwbkozcEdIVU9nV2tlTytlQ0svWTFkTGUxQmZZ?=
 =?utf-8?B?WlhUMHhFZEwxdU81T1JLcmVHdjFzazExMDRaVW5rc0R4UXlGcG9lTXFqK25t?=
 =?utf-8?B?UlZZdTF1UFBPTXpIM3ZjaHZSaXZiNk5WYlFxL1lZZWxxOXdoMnRTcG9UMjZQ?=
 =?utf-8?B?REFvZ3lBVG9sMGZpQnBQVmJDVzJNNzJBZi9oSFhKWVEybHRGdlBRdGhITURs?=
 =?utf-8?B?UVptMXlKd2czeU1udE44SWlWYktjSjl3YkVYUFVDZzdRM0EvOEN2VGZSb3Bw?=
 =?utf-8?B?U25CTDFkOXVjUXZOZG5jcUVWcmhGcThveGZCMFE5T2M0Sit0L2ZUc3d3UXpn?=
 =?utf-8?B?eTR3TzRQSVIxTG12UUhrVTdYNUp5dzFnY1hqWUx5dDJYalNYdFJySVdaSnRN?=
 =?utf-8?B?MFFJZjF1dWFxSjhFMWpVZWtUamhlU3AxWXMwVHN1cFVXOU5oNzI5cnhCd2hq?=
 =?utf-8?B?MEdORUZEMEVmS3AydmFUOTJURTZpejVEWGZZakt2SzJiU0ZuMFVYYys4cndQ?=
 =?utf-8?B?RzZFV1VFRmlxbDl2OG11eWtTZlZtNjJxUExUcm1lcjNJY2hGNXBYQTJ5dVFw?=
 =?utf-8?B?eE81bjB5OUUrV2F1eDNIVVFXeHNjTFdUdnZ5OU9HS0kxeFBCY0NhRHJmM2g1?=
 =?utf-8?Q?ZwUO4DAPqINZWur2yBnYct3vX?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2326f240-fc30-44d8-fb2a-08dab827f8ce
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 14:31:44.4989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i/zyix/kywJcYLvrroMs3odUp/8F9jLgATw31+KDwPV8Cuh8+HbofYUSeksTTsFPxqKhpGZBjB6KCQNJJPvJPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8493

On 27.10.2022 15:23, Roger Pau Monne wrote:
> Writes to the BARs are ignored if memory decoding is enabled for the
> device, and the same happen with ROM BARs if the write is an attempt
> to change the position of the BAR without disabling it first.
> 
> The reason of ignoring such writes is a limitation in Xen, as it would
> need to unmap the BAR, change the address, and remap the BAR at the
> new position, which the current logic doesn't support.
> 
> Some devices however seem to (wrongly) have the memory decoding bit
> hardcoded to enabled, and attempts to disable it don't get reflected
> on the command register.
> 
> This causes issues for well behaved domains that disable memory
> decoding and then try to size the BARs, as vPCI will think memory
> decoding is still enabled and ignore the write.
> 
> Since vPCI doesn't explicitly care about whether the memory decoding
> bit is disabled as long as the BAR is not mapped in the domain p2m use
> the information in the vpci_bar to check whether the BAR is mapped,
> and refuse writes only based on that information.  This workarounds
> the issue, and allows domains to size and reposition the BARs properly.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>




From xen-devel-bounces@lists.xenproject.org Thu Oct 27 14:36:43 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 14:36:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431085.683613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3zs-0005rD-Sx; Thu, 27 Oct 2022 14:36:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431085.683613; Thu, 27 Oct 2022 14:36:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo3zs-0005r6-PE; Thu, 27 Oct 2022 14:36:40 +0000
Received: by outflank-mailman (input) for mailman id 431085;
 Thu, 27 Oct 2022 14:36:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yXv3=24=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1oo3zr-0005r0-Fo
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 14:36:39 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id c2857e81-5604-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 16:36:36 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1780423A;
 Thu, 27 Oct 2022 07:36:42 -0700 (PDT)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E4C593F7B4;
 Thu, 27 Oct 2022 07:36:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2857e81-5604-11ed-91b5-6bf2151ebd3b
Date: Thu, 27 Oct 2022 15:36:32 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: "stefanos@xilinx.com" <stefanos@xilinx.com>, Julien Grall
 <julien@xen.org>, bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
Message-ID: <20221027153632.0cf7d004@donnerap.cambridge.arm.com>
In-Reply-To: <7f1bdc88-da6b-9a0c-03d4-319e9d8966d4@amd.com>
References: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
	<20221025145506.5708839c@donnerap.cambridge.arm.com>
	<7f1bdc88-da6b-9a0c-03d4-319e9d8966d4@amd.com>
Organization: ARM
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 27 Oct 2022 14:38:52 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi Ayan,

> On 25/10/2022 14:55, Andre Przywara wrote:
> > On Tue, 25 Oct 2022 13:25:52 +0100
> > Ayan Kumar Halder <ayankuma@amd.com> wrote:
> >
> > Hi, =20
>=20
> Hi Andre,
>=20
> Many thanks for the explanation.
>=20
> I need a clarification on the issue of atomic access to 64bit normal=20
> memory on R52.
>=20
> > =20
> >> Hi Andre/All,
> >>
> >> This came up while porting Xen on R52.
> >>
> >> Refer "ARM DDI 0568A.cID110520", B1.3.1
> >>
> >> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE
> >> must not implement LPI support. "
> >>
> >> Does this mean ITS is not supported on R52 ? I am assuming yes, please
> >> correct me if mistaken. =20
> > An ITS relies on LPIs, so yes: no ITS on a v8-R32 system. I cannot find
> > this restriction anymore in the v8-R64 supplement, so it would only app=
ly
> > to the R52/AArch32.
> > =20
> >> If the answer is no, then my next query is follows :- =20
> > Answering to that anyway ...
> > =20
> >> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
> >> index 9ca74bc321..dea60aac0d 100644
> >> --- a/xen/arch/arm/gic-v3-lpi.c
> >> +++ b/xen/arch/arm/gic-v3-lpi.c
> >> @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi=
_bits)
> >>   =C2=A0=C2=A0=C2=A0=C2=A0 int rc;
> >>
> >>   =C2=A0=C2=A0=C2=A0=C2=A0 /* We rely on the data structure being atom=
ically accessible. */
> >> -=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsig=
ned long));
> >> +=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint6=
4_t));
> >>
> >> "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.
> >>
> >> Is it fine to change it as above ?
> >>
> >> Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy
> >> atomicity".
> >>
> >> "LDRD and STRD accesses to 64-bit aligned locations are 64-bit
> >> single-copy atomic as seen by translation table walks and accesses to
> >> translation tables" =20
> > This (and the explaining paragraph) indeed suggests that this should
> > work architecturally, if you use normal system memory (where you would
> > hold page tables). It would be confined to ARMv8 AArch32 and ARMv7 w/
> > LPAE, which matches Xen's requirements. =20
>=20
> Does it mean that ldrd/strd will not work atomically on AArch32-v8R as=20
> it uses MPU (not MMU, so no page tables) ?

No, this mentioning of page tables is more an example or a rationale, than
a requirement.
What this means (in the ARMv7-A/ARMv8-A AArch32 context) it:
Because on v7A-LPAE and v8-AArch32 PTEs are 64 bits wide, it's too painful
to use explicit locking to make sure just writing one PTE is atomic. So
the architecture demands that 64-bit aligned accesses using ldrd/strd
are single-copy atomic, so software can update just one PTE easily. But
this is only required for locations where page tables typically reside, so
system memory. This avoids this 64-bit atomicity requirement for *every*
part of the system, for instance separate buses, SRAM or flash on smaller
buses, or MMIO in general.

I don't find anything in the v8-R32 supplement that would step back from
this requirement, although indeed the original reason (atomic PTE writes)
would not apply to v8-R32. Both the LDRD/STRD description and the section
listing differences in the system memory architecture do not mention
anything, so I'd say that the ldrd atomicity requirement still holds.

Please note that this only applies to ARMv7 *LPAE* systems, but Xen
requires LPAE, and R52 is v8, so we are good, and the Xen code can rely on
this.

So for Xen on ARMv8-R32:
*LDRD/STRD* accesses to *64-bit aligned* addresses in *RAM* would be
atomic. You need to satisfy all three requirements:
- You must use ldrd/strd. Just dereferencing a uint64_t pointer in C does
not guarantee that, but read_atomic()/write_atomic() does.
- It must be 64-bit aligned. Shouldn't be a problem if the data type is
64 bits wide. Please note the slight nastiness that ldrd would silently
work on non-aligned addresses, but would lose the atomicity guarantee.
ldrexd would always fault if the address is not aligned.
We might want to check the alignment of data we access (assert?), if not
done already.
- It must be in system RAM, so not MMIO. Also I think TCM might be a
different story, but I would hope Xen would not use that directly.

> If so, then is using ldrexd/strexd the solution for this ?

As mentioned above, you would not need that, just
read_atomic()/write_atomic() would do.

Hope that clears that up.

Cheers,
Andre

P.S. This above is my reading of the ARM ARM and the R32 supplement. I can
double check with the architects, but this might take a while.

> IIUC "Memory accesses caused by LDREXD and STREXD instructions to=20
> doubleword-aligned locations.", then the answer seems yes.
>=20
> - Ayan
>=20
> >
> > But it's only atomic if you are using ldrd/strd, which you cannot know =
for
> > sure in C, because it's up to the compiler to generate the instructions.
> >
> > This is why we have that test. Changing the unsigned long to uint64_t
> > would make the check pointless, since the data structure is 64-bits lon=
g,
> > so it would always be true.
> >
> > So given that you don't seem to need it, right now, it would leave the
> > test alone.
> >
> > If you need that on AArch32 anyway, you would need to replace accesses =
to
> > the host_lpis array with inline assembly accessors, to ensure ldrd/strd
> > instructions. This seems doable (there are only so many places which
> > directly access the array members), but would need a good use case.
> >
> > Cheers,
> > Andre
> > =20
> >> Does this imply that atomicity will be retained (with the above change)
> >> ? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so
> >> translation tables are irrelevant).
> >> Kind regards,
> >> Ayan
> >> =20



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 15:40:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 15:40:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431094.683630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo4zP-0005dI-Kb; Thu, 27 Oct 2022 15:40:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431094.683630; Thu, 27 Oct 2022 15:40:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo4zP-0005dB-HM; Thu, 27 Oct 2022 15:40:15 +0000
Received: by outflank-mailman (input) for mailman id 431094;
 Thu, 27 Oct 2022 15:40:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oo4zN-0005d5-L9
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 15:40:13 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3d4968d-560d-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 17:40:11 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CH2PR12MB4117.namprd12.prod.outlook.com (2603:10b6:610:ae::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Thu, 27 Oct
 2022 15:40:07 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 15:40:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3d4968d-560d-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VVOS6z1Wgs5ar6UF9Tx7Zxo/dgF2doQXePGp2gNcY71RjbHZTJ+9Be3HHDEvO8YSLq6itySFpMzuCKsiuVK4ks++pdoSA5kax+sO/HCbBrbqM7yUKZyTS0bsmMJmiFWe1MlXMqgqs63UK1cH/JosIEcvg5jc2v3/ulZAUFPELcmV74KLdbRjbwPDlt48N7UT7+CEln0nfQiUCYrMlWQFrm1xuwkyhx1Wu0zbTlbSQ2SZVgjN+Vq9gk74xWLAkTVhxBJ7ariH3iH00QW+T6IjAWS93baEHMTiz14ExKdMAa1exnknTOPwpXMitt3FWg0T+JMFFcwO2VhXqY2d1OfRPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xdya/2LdvajT5SSNeKEhvvkC8qdcVKui/z0ztWN+3g0=;
 b=UkpH5h0VFZ6FqG2mOZ/9/CHU/TX2MhohEYqWh45IyX88P0PthQhkpOizy/tl4XtoiRsbfNJ4leZ/psWrGqUQlcoyJt3cbQiFhAqCS3U7ozyJLhOk9T9P3Uv7Hz4mKkQUcSBQ3QuOXB9zj/pgUUMTPfMhY/W3K16V7Ez1tHBCjdAQHT7+T8lx8eckYIA36xRs8f0NFF+mkvKDjGab4oizB81wPmt9VHEhW8Q5A8kFPt+8UcTN56HLAbaP9UEbcqBiW5lk7EM6ZhEfK3mxDqCazsDJCOcw6K+Z0Fa/TyM60qpl/f3dFEyXfhLmTikOIbamNG/exduIYcLg42V8/ueOjg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Xdya/2LdvajT5SSNeKEhvvkC8qdcVKui/z0ztWN+3g0=;
 b=byIRQ7jLcXtP+u+6wSQyOih0khSm7/1MXiprM6Pka3NXeh/fssRubzMA8+M/BoJvwMUDEiVRLrjfTipn94ooS2kCBGx7qbzRX65KoPb6f8owUySsc5eqjGSQqsESQkUJwe0B9nObOINgtdhvi+GYm4u7YzjmDnCljxuKKa5Hi84=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <da52b703-5de7-1673-f6a1-d6541f59f5cd@amd.com>
Date: Thu, 27 Oct 2022 16:40:01 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: Andre Przywara <andre.przywara@arm.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Henry.Wang@arm.com
References: <20221026183004.7293-1-ayankuma@amd.com>
 <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P123CA0443.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1a9::16) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH2PR12MB4117:EE_
X-MS-Office365-Filtering-Correlation-Id: 6c8c31a5-dffd-483c-19cb-08dab831863f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hvolDu4usPj7Ta4HIOyvCRb9Ohip0Uyj3YqScN57nDpSldPfNlvrvS/LFDJQzDghA4szP5Yt7Hvv4Q21ncLQ+uA57pSCNeQPVX+xFZtwlNJCo8cQgT0sPdViO17YfWxTwWSEvCxSoMDr88AH//NlatEDsGYZBRIf/UcTkVfIP0A1F52pvKkQ7IRKaZHTne70DDsK9qdF8nAeLogDGtjm5IqH/24KzohjI945Gkmgng8Gs14WDzePhmnNOGDrxP+Hba2pv6sBrfN0ZAA/iI8aMUo2UYa6Etppl0u5mR/VK241Scc14Ozmvs94uhBshqs9oGOHjYMLIJDTVGzFGWFY7QmqWOaFdjg3wuH27dcylhrj0ZnutLzJk9Ozquk/xqzP7vqC89ltTkOHjpWTXR33e50044TZnuZZ9GR2q/jV+WTlTf5Ffh3bmIv53/3TzxqN7QrB5P+D/xsgW8Ol37lwJXoi8LQzsPK3fd605QuxR3ngBR5W865YjiANvCCclkFn0qiZALQuFM1T23uHe3ORgrnpXaJI4N0PdjfjgsuV+3ulP9XdZnki/BaJDJGj9XNq3u4690BdIB9l9vNruzqkx6FIpl8m2EI+6R9LlSq2a1DMzY7pG6WUc0T+zCmlnPl5HTmB+KWLt/9Tj4Lna4xkDrP/3uv0k1DlCnOXZrr0Lv8XO9MBiX9kGOFXAPNfiFVe8wAxP7JNvCx8cx3lvzwNZvrGKnnm2EiiSMiLPmAmcOKqA/mOkwhWUlTqVBOIofsUvH0Jjci41JvVDWdrNHcHN/yKWAzkIMjZTMKuO6k07nI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(366004)(39860400002)(451199015)(478600001)(31696002)(6916009)(6486002)(31686004)(6666004)(316002)(5660300002)(2616005)(53546011)(6506007)(4326008)(66476007)(66556008)(8676002)(66946007)(6512007)(8936002)(26005)(38100700002)(2906002)(83380400001)(186003)(36756003)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cUs5eWptQWgwWXNlaFlEaDdZNmd2QW5jcFVtdmpUNFpDRWF2MlNlandRUyth?=
 =?utf-8?B?bUlmeTBKOVdQTjZIcGpvdzZ0enhMZTd4b3puQlJzTlpaRnlCWGxnUHQxV0x5?=
 =?utf-8?B?QTBpRk5FSXhZQ05JTjN6eCt4dmJJbnBNSDU3b1lPUEQvY0xzV2JkaUNKdEto?=
 =?utf-8?B?NXNocjA0UUhxMTIzSkt4TVc2VWUvZXFYUnV5Yk5oVzNub2M3eWtmaEE5cEFP?=
 =?utf-8?B?Vm9ESEhiR0lSSkh1cFMxbFFOakw5d3hYRVBaWUFvVnhXY2NINTJSeHZ6WnJR?=
 =?utf-8?B?LzNDL2xEbGxybTR2ZWJnZVkzQW5XeXh4L1A5c1NtL3JiMlUzSFhNOGtnOWxo?=
 =?utf-8?B?WkVUcHowdTFGM0ZpTWo2RVZvNVdTQnZBL3RlM2wrT1VYTTFQTHdDekpDMkh2?=
 =?utf-8?B?ck1tQlB4cFBFTE5tRmIxZFVFQlJSUUlaU1NQc0NOMTgyeS9OZ1NoZ2ZLTTZJ?=
 =?utf-8?B?TlZZcFNwWjBNRlpGNXFrOGlLMGhlb2dVeGhra1ZwVHgxZmVrYW5rT3RVUzBV?=
 =?utf-8?B?NHhlUnlDcWpaa2pDUmc0QmpXdk9OV3M0T2dvUHZBM0dHOVo5dDBVdjUyRkZD?=
 =?utf-8?B?b1ZxZUhOOXdLU2VuYkNqb2dqeXp6ZjU3M3JqOXRXaklhZlduMVRXZUJ3N3Fz?=
 =?utf-8?B?YzBybWJJOXBSMGdqNWQxcG96cW9Wck9jTDFtL28xdUFYbWRuV0JyYVIvSUJk?=
 =?utf-8?B?SE1aQURaUUVMTWZjYk1lUUJlSmYyZEYzV3gxejE1WHRYQVZCUDAxbXMzc21B?=
 =?utf-8?B?UGZaZWdQWHVwb3l0QWxLWmpVUmt1S0dWSFVLUEZwL3ZGUXRzOXEvVGI1dFkw?=
 =?utf-8?B?RDE2K0YxbTd2WnM5MkJyN3NvSmdRb1ZFTTU0bDZYOXVkZWRXMHZvdmFTUnR3?=
 =?utf-8?B?L2RVT1J5dmduS3R5djZnYXQ5WS9oeXBJZkxZNVNxSHdqWHN2RFNvZGt3SEh0?=
 =?utf-8?B?ZjNjZjlSNVNoNzRQd2dDcW10Z1V0UTJScGxRRXNQbUh0SFkvYkN6YUpQdWFj?=
 =?utf-8?B?NlBXUDlzcmdMSHFLdkJRUHZZcndwWFF1RDFzRS9qU2RIem1nR2t2U0trZTdY?=
 =?utf-8?B?MXlJTDYrMW5UN3ZTRFcvT2JoNm1vZWNEeERBNjBEUzh3NldnTUNYR3JRZVlr?=
 =?utf-8?B?VzRTbWJmRTFjNGRoN2cvOEpNRTJsZTFMbm9OTVp3cStlc20yckhPcjBtTkRS?=
 =?utf-8?B?SW1GMkUycnM4bkN3S3FqcjV3eG5YajVTTkd3ZlFoWGhzSlA3VFJBellNcFcy?=
 =?utf-8?B?R3A3YkJreVFzZ05rRXhQR1I1WUVvVGFqOFd0Qy9lRnFjdFk4QWZhTHJqZjA2?=
 =?utf-8?B?a0lQRm5QVDg1ajZ3dGVvVDJBVWRoeERzZVpIdGhTQ3dtQSs3d3IzWGlHWkxv?=
 =?utf-8?B?SnM1ZVFsN1NQMzlaSlJVVFQzNitRSHBLU1BXOFU5cHNycXFtdTB4RzgzUG1t?=
 =?utf-8?B?eFYvUVJCOUJPSnFZUHBobGlhZHEwVTJqTWFVNm9BOU85ekY4YUp0dUgxcnBy?=
 =?utf-8?B?S0s3V2tObEZpV2U1YnhaWUQybXVSMFcrU1hzSzNDdUN1cGxSclhLUDNoeG5B?=
 =?utf-8?B?dVFFeWpSSE9VSDIxM2lWUE9sNFRJYXRneTl6SFNZS2lsOE84bXFJdENyaFV5?=
 =?utf-8?B?V2t5RXlaZ04xUERvcDhZbnRkSkxsU1dKb09QQVJtRzlTWWNPaUwvcG1LNDZs?=
 =?utf-8?B?Q3Rhb1VQS1RIZWZvQ25uN0orVFNGTW01MGo1bnZONlEwR1ZkZlNmQmZvZkZY?=
 =?utf-8?B?aGNwOURTaW9wTTQwdktUd04xdHBWVzhRWFNwRXBPamFScXlSSW02Z0d1TXdJ?=
 =?utf-8?B?Q05oRWhUNWpYNHpFMy9tVmhNWk9JTkZWY2NqRVVHWVJ4YTZMUXFVdHl3cFpa?=
 =?utf-8?B?UUc2TmN3bVc2ekR3OGllbnpIeHR5SFJXYW5NM0EydndTcWJCNEF6eVFOYmtH?=
 =?utf-8?B?WVhjM2JOOFJpVjBETjRrenVTN0V2OWRvcWEzS1dHTmlwTUJjbnc0TmlwMmh1?=
 =?utf-8?B?RGJialVQSUtKNVZWNjlxa29tWGYxL3g0RlgyM0xMd2FGSitjbGpFWjdYbkZ3?=
 =?utf-8?B?OHNDSGQ0dlpBYnpVbHQrVDZsd2RyK1JuTlFJZjBldTMzNWtOR0ZvT09iU29W?=
 =?utf-8?Q?Hew05jwhd1mr4XPg3uapgTL4u?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c8c31a5-dffd-483c-19cb-08dab831863f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 15:40:07.3411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HS7jpcnf7xkESy9/6tf5g6VsB1Jp+hpPo8TFPzuBL+7HPGIoICHjfvLY6Hsgb846fgozMghZ8CbmfceIjozuxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4117


On 27/10/2022 10:44, Andre Przywara wrote:
> On Wed, 26 Oct 2022 19:30:04 +0100
> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>
> Hi,

Hi Andre,

I need a clarification.

>
>> If a guest is running in 32 bit mode and it tries to access
>> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
>> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
>> This will be stored in a 64bit cpu register.
>> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
>> in the lower 32 bits of the 64bit cpu register.
>>
>> This 64bit cpu register is then modified bitwise with a mask (ie
>> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
>> 64 bit cpu register) is not cleared as expected by the specification.
>>
>> The correct thing to do here is to store the value of
>> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
>> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
>> vreg_reg64_extract() which will extract 32 bits from the given offset.
>>
>> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
>> v->arch.vgic.rdist_pendbase. The reason being v->arch.vgic.rdist_pendbase is
>> now being read/written in an atomic manner (using read_atomic()/write_atomic()).
>>
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
>> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
>> ---
>>
>> Changes from:-
>>
>> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
>> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
>> appropriate commit message.
>>
>> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
>> v->arch.vgic.rdist_pendbase in an atomic context.
>> 2. Rectified the commit message to state that the cpu register is 64 bit.
>> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
>> clear.
>>
>> v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
>> in __vgic_v3_rdistr_rd_mmio_write().
>>
>>   xen/arch/arm/vgic-v3.c | 19 ++++++-------------
>>   1 file changed, 6 insertions(+), 13 deletions(-)
>>
>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>> index 0c23f6df9d..1adbdc0e54 100644
>> --- a/xen/arch/arm/vgic-v3.c
>> +++ b/xen/arch/arm/vgic-v3.c
>> @@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>>   
>>       case VREG64(GICR_PENDBASER):
>>       {
>> -        unsigned long flags;
>> +        uint64_t val;
>>   
>>           if ( !v->domain->arch.vgic.has_its )
>>               goto read_as_zero_64;
>>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>>   
>> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
>> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
>> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
>> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
>> +        *r = vreg_reg64_extract(val, info);
> That part looks fine now.
>
>>           return 1;
>>       }
>>   
>> @@ -566,25 +565,19 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
>>   
>>       case VREG64(GICR_PENDBASER):
>>       {
>> -        unsigned long flags;
>> -
>>           if ( !v->domain->arch.vgic.has_its )
>>               goto write_ignore_64;
>>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>>   
>> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
>> -
> I don't think you can drop the lock here easily. If it would be just for
> the LPIs enabled check, that'd be fine, because you can never turn LPIs off
> again (but that would deserve an explicit comment then).
>
> But down below you do a read-modify-write operation of rdist_pendbase, and
> need to make sure no one else is attempting that at the same time.
>
> Cheers,
> Andre
>
>>           /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>>           if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>>           {
>> -            reg = v->arch.vgic.rdist_pendbase;
>> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>>               vreg_reg64_update(&reg, r, info);
>>               reg = sanitize_pendbaser(reg);
>> -            v->arch.vgic.rdist_pendbase = reg;
>> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>>           }
>>   
>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);

Shouldn't this be "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" ?

- Ayan

>> -
>>           return 1;
>>       }
>>   


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 16:09:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 16:09:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431100.683647 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5RE-0000w5-WE; Thu, 27 Oct 2022 16:09:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431100.683647; Thu, 27 Oct 2022 16:09:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5RE-0000vy-S4; Thu, 27 Oct 2022 16:09:00 +0000
Received: by outflank-mailman (input) for mailman id 431100;
 Thu, 27 Oct 2022 16:08:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WPLX=24=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1oo5RD-0000vs-BG
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 16:08:59 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 (mail-am0eur02on2045.outbound.protection.outlook.com [40.107.247.45])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a83e3da4-5611-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 18:08:55 +0200 (CEST)
Received: from DB6PR07CA0201.eurprd07.prod.outlook.com (2603:10a6:6:42::31) by
 DBAPR08MB5862.eurprd08.prod.outlook.com (2603:10a6:10:1ac::13) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.28; Thu, 27 Oct 2022 16:08:52 +0000
Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:42:cafe::7f) by DB6PR07CA0201.outlook.office365.com
 (2603:10a6:6:42::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.13 via Frontend
 Transport; Thu, 27 Oct 2022 16:08:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Thu, 27 Oct 2022 16:08:52 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Thu, 27 Oct 2022 16:08:52 +0000
Received: from 5df110da5c11.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 600C8118-55A1-4F4F-9BA6-B2D8CA2C6427.1; 
 Thu, 27 Oct 2022 16:08:41 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5df110da5c11.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 27 Oct 2022 16:08:41 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24)
 by PAXPR08MB6510.eurprd08.prod.outlook.com (2603:10a6:102:158::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 16:08:37 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572]) by AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572%4]) with mapi id 15.20.5709.015; Thu, 27 Oct 2022
 16:08:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a83e3da4-5611-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=iWjjJ5gBz3TV5wul6VSsc64z4FY7ZMH4ZIhjWblCBo+ZH3fEDBtziZe4cg/tcnvC7SccvEGBhL9i2WDzm3T1iFwXuTKTUAGhKWAe+5/Ql9Brsqu9/fSazM6vbHUP1i+6yI6HgYuym8YxsxuzFmedtyMaSeBN95w3ZK/Y+xUn//Un/Sj3BC65rclo/5kGdG3UIFIqnKtCFRzCV3YFSydqV/bR3YrqMQxGLzRUyFHTP/tBA4ciIZ44NOkuuN0a5geiaArq9pMfb/dj3sTpIGWdEGtEH5HhEri9yTGd/0HMOWdqw67uNdLXvRq6bpwv5/yTxrO21+alcEuSLYwET5iCRA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w5qD5fiN2Wc01CVMAM7n9AAsVJpStvRj1DdGacuzCfs=;
 b=KiRWOF1a0f+E3U9cvE9+XKTF7gL9CZrcQ4JsJikyeqULwO1kWemIhzdPm1C9GNmeGSk8GWX8D4IXvRSXgYA6f5APFKSymaJc0jEkKBEkBDtPQMqWJMTDlXSFIbu7uJoFJk54BP+KEwF4DjcZjgcQFvThTR5TpvDjdT2JdX0hkFbvVxpCCsgSdNoh5gj9Q61GmmQ4LKjnUkTt7DrYA2YF3OmMJmXIhcys6vxV0Qlq9YMQ0mweB1H/cyX5clzUQezJXufTDE+mcS27nQyQqZXssDjQm5aJo7V8dBHOdtshbYC4R4rALKEm7jL1JeN+c0JrOjwNivGJqHOmihdeE/0RkQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w5qD5fiN2Wc01CVMAM7n9AAsVJpStvRj1DdGacuzCfs=;
 b=sVbZvRHI1yZSJ+gkn6mPQCgKXgoJuSjul+2hmYo6RsV8DxXiLt4bg89Vti1LilCAOGCwWoz7+7OehIBLJpnm9Sj/l6JqEwrBeB5SA57HZUMW3WRreGQwRXsAD6y7zx3bYbCvVqSOuJFUnjefa6DEec1ARNttAcviy1KV2T6GU9M=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4c8422beba683fb4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gtEQyzeSloRWxV9ySL1ZN3O0iztJrSgccCOPoZ6Z+2X7CrO5/81Eg4SSNTXZbhclR6YI5xd/OuO/75jbax3N7pfWTzJVI5Ca6H+aJ5dMfgejSNDfSGECRJvihzdONqBzsPaOJHxMpbzZLBdYYT2Wwuu6k7qFKdYA/hJ0fL2ARxlrvBSf3HNy1a3cq/TTQGV8UVd7g9mgQdbspoUOn18ldTMHzaBBkJm1Q0ON1WITDRHY6CLfhrg5hwAHbERlSZo2JJRMxTyJmEWqjUyXCAErYUsMrpIDsDwoNBzLXjAK9ULehRt2YEhz5CmCALC2BZeliuR0Rr+jag3xg16hhNGcOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w5qD5fiN2Wc01CVMAM7n9AAsVJpStvRj1DdGacuzCfs=;
 b=aYV4VYyjE1RlDCqAd3HlgYByGlMoHfMP6gDA1lCR/RbcxKKktufOefvrR9ADWDA6TloPuxYubcwontxgSXnFh4UEkefGGmR+8HABNZFY0JKbLeYUWnm3/wI8qw3m9zacrvvPCD0wxjoW0qXmqxOXiTMTbt1TdYTyvh+wuKmbSDK61R6WtGRsyuv/lG/eXcFbgWdQc45XTiUK2nNd5TEd4k8kyYPbF6wpT3XXrDoo9wLADo46mHqdAkK9qdXZdv5wG9Dta6QMJ+MZrlnc11uTOQDMDoXYNS/m5ruSOPs5H+QHJHQAULdyTLG0MbbzFuy0jwML1jOU1tdQ+Qhu/WSj9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=w5qD5fiN2Wc01CVMAM7n9AAsVJpStvRj1DdGacuzCfs=;
 b=sVbZvRHI1yZSJ+gkn6mPQCgKXgoJuSjul+2hmYo6RsV8DxXiLt4bg89Vti1LilCAOGCwWoz7+7OehIBLJpnm9Sj/l6JqEwrBeB5SA57HZUMW3WRreGQwRXsAD6y7zx3bYbCvVqSOuJFUnjefa6DEec1ARNttAcviy1KV2T6GU9M=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index: AQHY6T1VjOHHQJGN7kyXeL6pAIKNMa4grXIAgAAQBQCAAFgAAIABVMsA
Date: Thu, 27 Oct 2022 16:08:37 +0000
Message-ID: <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
In-Reply-To: <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7158:EE_|PAXPR08MB6510:EE_|DBAEUR03FT061:EE_|DBAPR08MB5862:EE_
X-MS-Office365-Filtering-Correlation-Id: b89571f6-d0e9-424e-3526-08dab8358a6d
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 kRhDgie83O30GyFQgSdO019WFUv2HDZ0dn14/5hGCNc6M1G3nesOyPvF+CrIlPYCVAOALU1H25woW+FlNYdy3TlX/2ZwIGWNMZ3okyWFR6KrRVLc09xZsbi93R1CTNuHmVqoZcxt11PiaRxT4nVv+261krvhvcY++6IR+/s9tzNoskD67vm9VvaYyFudsVIC1/bTbQk5GfIPbKkVjKv6lQEMRYEpERlxYMPLmiHDewkP5FallDS3+LQ93rVvlUEJL0ZxZaJIwBAbUykOBN4vgrsJtvZCEy2/AbneIJuIhvHRa1GBpcvhaCjqBPZObTDtk/UInhy08r4p1PajNUWiDe01mlP5+USQipOYIkKqhOYsWv1CHi4ZXU7e3Xq3CBUpXswIQUkuWzrVGvcQ+fWnKWIywSNipSf7GsrASaOd4Cz13XRxjLwsONqqiIV/Tp/VQFd9nPxl7cvKvpW2m+EyMkiHUK7ysomor7Cmvm4oqCQLgWPgq6kIaKNkGZoslq+5U7OvctcmiYrbu6r5NtrZV8Y1l2ZP53wpF+zdhFsf4SoQCxcK4FrEE4KOW8d+h+fpLb4k3ckFB6n5k0/fe8P3YEnYx2E6J5gj8xsfZCxr1Jq2iwAKrsojMrtfpFTfJctwbBlr54tzqsUauw7RRCFedFASXg2ezypqS7zPxBWZrfzvrwZF2QWrOeQBwd3Uwr9Pv3NnoSxVhGj2UX3P02pXzBFj490xY+bOkYzIO2v4PIFWZ3r9RfB7crzncNdn0PtBKhhCylioWjfugmmP49OfqUHy72MrtZPbeXtVUmNAmrI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199015)(33656002)(6486002)(478600001)(38070700005)(53546011)(6506007)(71200400001)(76116006)(6512007)(26005)(6916009)(8676002)(316002)(54906003)(86362001)(4326008)(66476007)(66946007)(186003)(64756008)(66556008)(66446008)(8936002)(91956017)(2616005)(41300700001)(36756003)(30864003)(5660300002)(38100700002)(83380400001)(122000001)(2906002)(7416002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <98BC65462E7C384C87C8148728F982E1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6510
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e72aa198-394e-4b2f-9deb-08dab83581d3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FvGo6Nq6Kj9kIF2wF9K2/AP9rT1eoNjt0FyhNZMZ6WR9RrvPB12YdJbilc6BbkCGFVeCKT0O0bW20jetmq6uakpq69IA239lyUs2nMQ+ChihzLUel8bGu0WEfna4U0nML5FDObIgZPPKaQP+5YUuKk1gWrrjPIlR6hgfLbG9GwXXHhshEDsTsm2zYLR2swENo0XoV8aFvTv6pN2U8sO3BrZSu0A9X08aHUcg2uF6oyNKw8Y4LjnG9ooChjeBvPwll78D937Z4Kv2Zj/purBjT8udc6v4louVCicChM3aEcn1fFlKO1/e2TkWmfCOALPzoKjClTHVc6yM0+f2eBa54ijE1UjBLophki8PHmv6ihYPt7wJeYZHZ2vXcqA/OMsBfYqRjqg4bKSVU5Y0hNcTNzrHJDM6SvCtSEEEPcfesP3BJ9zms3kEKgi+OdYIEJny9VaBPHCJieO2a01LyNOAX4B3ui0nb9xJ/kXS2s4LiatBIPIgAQ245gkfNSFQ6337eONFjvVg6D5kRHVGvsru6R63cxkWACB3o146TROKJycEwZbZQWwnQORWx2aqzpe6wjF4HrEmEH8zz5yy8fJcJjbUyFekP6jx2fu/jKf/bQbBd62+PGs1TIeKrmGC0ccyQpOx1mbDdLoGWQmEgzxh67HL/S1MHieZnQlXknHSqsF65SDFInmkdFO1xXnxIKb2sN+0d+yEFfzDx8Czlf1yGyJxGr0ylZ5YkO6aEWcvy0AkIRj6O4ccCCUfAIphQmGsaZ2IxF2hp/fuOTO0BlWaqw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(6862004)(336012)(6512007)(53546011)(83380400001)(36860700001)(30864003)(2616005)(47076005)(2906002)(186003)(107886003)(8936002)(6506007)(40480700001)(40460700003)(26005)(82310400005)(316002)(54906003)(70206006)(6486002)(4326008)(8676002)(70586007)(41300700001)(478600001)(5660300002)(36756003)(86362001)(33656002)(82740400003)(81166007)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 16:08:52.1536
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b89571f6-d0e9-424e-3526-08dab8358a6d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5862

SGkgSnVsaWVuLA0KDQoNCj4gT24gMjYgT2N0IDIwMjIsIGF0IDg6NDggcG0sIEp1bGllbiBHcmFs
bCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAyNi8xMC8yMDIyIDE1
OjMzLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIFJhaHVsLA0K
PiANCj4+PiBPbiAyNiBPY3QgMjAyMiwgYXQgMjozNiBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5A
eGVuLm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gDQo+Pj4gDQo+Pj4gT24gMjYvMTAvMjAyMiAxNDox
NywgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+IEhpIEFsbCwNCj4+PiANCj4+PiBIaSBSYWh1bCwN
Cj4+PiANCj4+Pj4gQXQgQXJtLCB3ZSBzdGFydGVkIHRvIGltcGxlbWVudCB0aGUgUE9DIHRvIHN1
cHBvcnQgMiBsZXZlbHMgb2YgcGFnZSB0YWJsZXMvbmVzdGVkIHRyYW5zbGF0aW9uIGluIFNNTVV2
My4NCj4+Pj4gVG8gc3VwcG9ydCBuZXN0ZWQgdHJhbnNsYXRpb24gZm9yIGd1ZXN0IE9TIFhlbiBu
ZWVkcyB0byBleHBvc2UgdGhlIHZpcnR1YWwgSU9NTVUuIElmIHdlIHBhc3N0aHJvdWdoIHRoZQ0K
Pj4+PiBkZXZpY2UgdG8gdGhlIGd1ZXN0IHRoYXQgaXMgYmVoaW5kIGFuIElPTU1VIGFuZCB2aXJ0
dWFsIElPTU1VIGlzIGVuYWJsZWQgZm9yIHRoZSBndWVzdCB0aGVyZSBpcyBhIG5lZWQgdG8NCj4+
Pj4gYWRkIElPTU1VIGJpbmRpbmcgZm9yIHRoZSBkZXZpY2UgaW4gdGhlIHBhc3N0aHJvdWdoIG5v
ZGUgYXMgcGVyIFsxXS4gVGhpcyBlbWFpbCBpcyB0byBnZXQgYW4gYWdyZWVtZW50IG9uDQo+Pj4+
IGhvdyB0byBhZGQgdGhlIElPTU1VIGJpbmRpbmcgZm9yIGd1ZXN0IE9TLg0KPj4+PiBCZWZvcmUg
SSB3aWxsIGV4cGxhaW4gaG93IHRvIGFkZCB0aGUgSU9NTVUgYmluZGluZyBsZXQgbWUgZ2l2ZSBh
IGJyaWVmIG92ZXJ2aWV3IG9mIGhvdyB3ZSB3aWxsIGFkZCBzdXBwb3J0IGZvciB2aXJ0dWFsDQo+
Pj4+IElPTU1VIG9uIEFybS4gSW4gb3JkZXIgdG8gaW1wbGVtZW50IHZpcnR1YWwgSU9NTVUgWGVu
IG5lZWQgU01NVXYzIE5lc3RlZCB0cmFuc2xhdGlvbiBzdXBwb3J0LiBTTU1VdjMgaGFyZHdhcmUN
Cj4+Pj4gc3VwcG9ydHMgdHdvIHN0YWdlcyBvZiB0cmFuc2xhdGlvbi4gRWFjaCBzdGFnZSBvZiB0
cmFuc2xhdGlvbiBjYW4gYmUgaW5kZXBlbmRlbnRseSBlbmFibGVkLiBBbiBpbmNvbWluZyBhZGRy
ZXNzIGlzIGxvZ2ljYWxseQ0KPj4+PiB0cmFuc2xhdGVkIGZyb20gVkEgdG8gSVBBIGluIHN0YWdl
IDEsIHRoZW4gdGhlIElQQSBpcyBpbnB1dCB0byBzdGFnZSAyIHdoaWNoIHRyYW5zbGF0ZXMgdGhl
IElQQSB0byB0aGUgb3V0cHV0IFBBLiBTdGFnZSAxIGlzDQo+Pj4+IGludGVuZGVkIHRvIGJlIHVz
ZWQgYnkgYSBzb2Z0d2FyZSBlbnRpdHkoIEd1ZXN0IE9TKSB0byBwcm92aWRlIGlzb2xhdGlvbiBv
ciB0cmFuc2xhdGlvbiB0byBidWZmZXJzIHdpdGhpbiB0aGUgZW50aXR5LCBmb3IgZXhhbXBsZSwN
Cj4+Pj4gRE1BIGlzb2xhdGlvbiB3aXRoaW4gYW4gT1MuIFN0YWdlIDIgaXMgaW50ZW5kZWQgdG8g
YmUgYXZhaWxhYmxlIGluIHN5c3RlbXMgc3VwcG9ydGluZyB0aGUgVmlydHVhbGl6YXRpb24gRXh0
ZW5zaW9ucyBhbmQgaXMNCj4+Pj4gaW50ZW5kZWQgdG8gdmlydHVhbGl6ZSBkZXZpY2UgRE1BIHRv
IGd1ZXN0IFZNIGFkZHJlc3Mgc3BhY2VzLiBXaGVuIGJvdGggc3RhZ2UgMSBhbmQgc3RhZ2UgMiBh
cmUgZW5hYmxlZCwgdGhlIHRyYW5zbGF0aW9uDQo+Pj4+IGNvbmZpZ3VyYXRpb24gaXMgY2FsbGVk
IG5lc3RpbmcuDQo+Pj4+IFN0YWdlIDEgdHJhbnNsYXRpb24gc3VwcG9ydCBpcyByZXF1aXJlZCB0
byBwcm92aWRlIGlzb2xhdGlvbiBiZXR3ZWVuIGRpZmZlcmVudCBkZXZpY2VzIHdpdGhpbiB0aGUg
Z3Vlc3QgT1MuIFhFTiBhbHJlYWR5IHN1cHBvcnRzDQo+Pj4+IFN0YWdlIDIgdHJhbnNsYXRpb24g
YnV0IHRoZXJlIGlzIG5vIHN1cHBvcnQgZm9yIFN0YWdlIDEgdHJhbnNsYXRpb24gZm9yIGd1ZXN0
cy4gV2Ugd2lsbCBhZGQgc3VwcG9ydCBmb3IgZ3Vlc3RzIHRvIGNvbmZpZ3VyZQ0KPj4+PiB0aGUg
U3RhZ2UgMSB0cmFuc2l0aW9uIHZpYSB2aXJ0dWFsIElPTU1VLiBYRU4gd2lsbCBlbXVsYXRlIHRo
ZSBTTU1VIGhhcmR3YXJlIGFuZCBleHBvc2VzIHRoZSB2aXJ0dWFsIFNNTVUgdG8gdGhlIGd1ZXN0
Lg0KPj4+PiBHdWVzdCBjYW4gdXNlIHRoZSBuYXRpdmUgU01NVSBkcml2ZXIgdG8gY29uZmlndXJl
IHRoZSBzdGFnZSAxIHRyYW5zbGF0aW9uLiBXaGVuIHRoZSBndWVzdCBjb25maWd1cmVzIHRoZSBT
TU1VIGZvciBTdGFnZSAxLA0KPj4+PiBYRU4gd2lsbCB0cmFwIHRoZSBhY2Nlc3MgYW5kIGNvbmZp
Z3VyZSB0aGUgaGFyZHdhcmUgYWNjb3JkaW5nbHkuDQo+Pj4+IE5vdyBiYWNrIHRvIHRoZSBxdWVz
dGlvbiBvZiBob3cgd2UgY2FuIGFkZCB0aGUgSU9NTVUgYmluZGluZyBiZXR3ZWVuIHRoZSB2aXJ0
dWFsIElPTU1VIGFuZCB0aGUgbWFzdGVyIGRldmljZXMgc28gdGhhdA0KPj4+PiBndWVzdHMgY2Fu
IGNvbmZpZ3VyZSB0aGUgSU9NTVUgY29ycmVjdGx5LiBUaGUgc29sdXRpb24gdGhhdCBJIGFtIHN1
Z2dlc3RpbmcgaXMgYXMgYmVsb3c6DQo+Pj4+IEZvciBkb20wLCB3aGlsZSBoYW5kbGluZyB0aGUg
RFQgbm9kZShoYW5kbGVfbm9kZSgpKSBYZW4gd2lsbCByZXBsYWNlIHRoZSBwaGFuZGxlIGluIHRo
ZSAiaW9tbXVzIiBwcm9wZXJ0eSB3aXRoIHRoZSB2aXJ0dWFsDQo+Pj4+IElPTU1VIG5vZGUgcGhh
bmRsZS4NCj4+PiBCZWxvdywgeW91IHNhaWQgdGhhdCBlYWNoIElPTU1VcyBtYXkgaGF2ZSBhIGRp
ZmZlcmVudCBJRCBzcGFjZS4gU28gc2hvdWxkbid0IHdlIGV4cG9zZSBvbmUgdklPTU1VIHBlciBw
SU9NTVU/IElmIG5vdCwgaG93IGRvIHlvdSBleHBlY3QgdGhlIHVzZXIgdG8gc3BlY2lmeSB0aGUg
bWFwcGluZz8NCj4+IFllcyB5b3UgYXJlIHJpZ2h0IHdlIG5lZWQgdG8gY3JlYXRlIG9uZSB2SU9N
TVUgcGVyIHBJT01NVSBmb3IgZG9tMC4gVGhpcyBhbHNvIGhlbHBzIGluIHRoZSBBQ1BJIGNhc2UN
Cj4+IHdoZXJlIHdlIGRvbuKAmXQgbmVlZCB0byBtb2RpZnkgdGhlIHRhYmxlcyB0byBkZWxldGUg
dGhlIHBJT01NVSBlbnRyaWVzIGFuZCBjcmVhdGUgb25lIHZJT01NVS4NCj4+IEluIHRoaXMgY2Fz
ZSwgbm8gbmVlZCB0byByZXBsYWNlIHRoZSBwaGFuZGxlIGFzIFhlbiBjcmVhdGUgdGhlIHZJT01N
VSB3aXRoIHRoZSBzYW1lIHBJT01NVQ0KPj4gcGhhbmRsZSBhbmQgc2FtZSBiYXNlIGFkZHJlc3Mu
DQo+PiBGb3IgZG9tVSBndWVzdHMgb25lIHZJT01NVSBwZXIgZ3Vlc3Qgd2lsbCBiZSBjcmVhdGVk
Lg0KPiANCj4gSUlSQywgdGhlIFNNTVV2MyBpcyB1c2luZyBhIHJpbmcgbGlrZSB0aGUgR0lDdjMg
SVRTLiBJIHRoaW5rIHdlIG5lZWQgdG8gYmUgb3BlbiBoZXJlIGJlY2F1c2UgdGhpcyBtYXkgZW5k
IHVwIHRvIGJlIHRyaWNreSB0byBzZWN1cml0eSBzdXBwb3J0IGl0ICh3ZSBoYXZlIE4gZ3Vlc3Qg
cmluZyB0aGF0IGNhbiB3cml0ZSB0byBNIGhvc3QgcmluZykuDQoNCklmIHhsIHdhbnQgdG8gY3Jl
YXRlcyB0aGUgb25lIHZJT01NVSBwZXIgcElPTU1VIGZvciBkb21VIHRoZW4geGwgbmVlZHMgdG8g
a25vdyB0aGUgYmVsb3cgaW5mb3JtYXRpb246DQogLSAgRmluZCB0aGUgbnVtYmVyIG9mIGhvbGVz
IGluIGd1ZXN0IG1lbW9yeSBzYW1lIGFzIHRoZSBudW1iZXIgb2YgdklPTU1VIHRoYXQgbmVlZHMg
dGhlIGNyZWF0aW9uIHRvIGNyZWF0ZSB0aGUgdklPTU1VIERUIG5vZGVzLiAoVGhpbmsgYWJvdXQg
YSBiaWcgc3lzdGVtIHRoYXQgaGFzIDUwKyBJT01NVXMpDQogICAgWWVzLCB3ZSB3aWxsIGNyZWF0
ZSB2SU9NTVUgZm9yIG9ubHkgdGhvc2UgZGV2aWNlcyB0aGF0IGFyZSBhc3NpZ25lZCB0byBndWVz
dHMgYnV0IHN0aWxsIHdlIG5lZWQgdG8gZmluZCB0aGUgaG9sZSBpbiBndWVzdCBtZW1vcnkuDQog
LSAgRmluZCB0aGUgcElPTU1VIGF0dGFjaGVkIHRvIHRoZSBhc3NpZ25lZCBkZXZpY2UgYW5kIGNy
ZWF0ZSBtYXBwaW5nIGIvdyB2SU9NTVUgLT4gcElPTU1VIHRvIHJlZ2lzdGVyIHRoZSBNTUlPIGhh
bmRsZXIuDQogICAgRWl0aGVyIHdlIG5lZWQgdG8gbW9kaWZ5IHRoZSBjdXJyZW50IGh5ZXJwY2Fs
bCBvciBuZWVkIHRvIGltcGxlbWVudCBhIG5ldyBoeXBlcmNhbGwgdG8gZmluZCB0aGlzIGluZm9y
bWF0aW9uLiANCg0KQmVjYXVzZSBvZiB0aGUgYWJvdmUgcmVhc29uIEkgdGhvdWdodCBvZiBjcmVh
dGluZyBvbmUgdklPTU1VIGZvciBkb21VLiBZZXMgeW91IGFyZSByaWdodCB0aGlzIG1heSBlbmQg
dXAgdG8gYmUgdHJpY2t5IHRvIHNlY3VyaXR5IHN1cHBvcnQNCmJ1dCBhcyBwZXIgbXkgdW5kZXJz
dGFuZGluZyBvbmUgdklPTU1VICBwZXIgZG9tVSBndWVzdCBpcyBlYXN5IHRvIGltcGxlbWVudCBh
bmQgc2ltcGxlIHRvIGhhbmRsZSBhcyBjb21wYXJlZCB0byBvbmUgdklPTU1VIHBlciBwSU9NTVUN
Cg0KDQo+IA0KPj4+IA0KPj4+PiBGb3IgZG9tVSBndWVzdHMsIHdoZW4gcGFzc3Rocm91Z2ggdGhl
IGRldmljZSB0byB0aGUgZ3Vlc3QgYXMgcGVyIFsyXSwgIGFkZCB0aGUgYmVsb3cgcHJvcGVydHkg
aW4gdGhlIHBhcnRpYWwgZGV2aWNlIHRyZWUNCj4+Pj4gbm9kZSB0aGF0IGlzIHJlcXVpcmVkIHRv
IGRlc2NyaWJlIHRoZSBnZW5lcmljIGRldmljZSB0cmVlIGJpbmRpbmcgZm9yIElPTU1VcyBhbmQg
dGhlaXIgbWFzdGVyKHMpDQo+Pj4+ICJpb21tdXMgPSA8ICZtYWdpY19waGFuZGxlIDB4dk1hc3Rl
cklEPg0KPj4+PiAJ4oCiIG1hZ2ljX3BoYW5kbGUgd2lsbCBiZSB0aGUgcGhhbmRsZSAoIHZJT01N
VSBwaGFuZGxlIGluIHhsKSAgdGhhdCB3aWxsIGJlIGRvY3VtZW50ZWQgc28gdGhhdCB0aGUgdXNl
ciBjYW4gc2V0IHRoYXQgaW4gcGFydGlhbCBEVCBub2RlICgweGZkZWEpLg0KPj4+IA0KPj4+IERv
ZXMgdGhpcyBtZWFuIG9ubHkgb25lIElPTU1VIHdpbGwgYmUgc3VwcG9ydGVkIGluIHRoZSBndWVz
dD8NCj4+IFllcy4NCj4+PiANCj4+Pj4gCeKAoiB2TWFzdGVySUQgd2lsbCBiZSB0aGUgdmlydHVh
bCBtYXN0ZXIgSUQgdGhhdCB0aGUgdXNlciB3aWxsIHByb3ZpZGUuDQo+Pj4+IFRoZSBwYXJ0aWFs
IGRldmljZSB0cmVlIHdpbGwgbG9vayBsaWtlIHRoaXM6DQo+Pj4+IC9kdHMtdjEvOw0KPj4+PiAg
LyB7DQo+Pj4+ICAgICAvKiAjKmNlbGxzIGFyZSBoZXJlIHRvIGtlZXAgRFRDIGhhcHB5ICovDQo+
Pj4+ICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4+Pj4gICAgICNzaXplLWNlbGxzID0gPDI+
Ow0KPj4+PiAgICAgICBhbGlhc2VzIHsNCj4+Pj4gICAgICAgICBuZXQgPSAmbWFjMDsNCj4+Pj4g
ICAgIH07DQo+Pj4+ICAgICAgIHBhc3N0aHJvdWdoIHsNCj4+Pj4gICAgICAgICBjb21wYXRpYmxl
ID0gInNpbXBsZS1idXMiOw0KPj4+PiAgICAgICAgIHJhbmdlczsNCj4+Pj4gICAgICAgICAjYWRk
cmVzcy1jZWxscyA9IDwyPjsNCj4+Pj4gICAgICAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4+Pj4g
ICAgICAgICBtYWMwOiBldGhlcm5ldEAxMDAwMDAwMCB7DQo+Pj4+ICAgICAgICAgICAgIGNvbXBh
dGlibGUgPSAiY2FseGVkYSxoYi14Z21hYyI7DQo+Pj4+ICAgICAgICAgICAgIHJlZyA9IDwwIDB4
MTAwMDAwMDAgMCAweDEwMDA+Ow0KPj4+PiAgICAgICAgICAgICBpbnRlcnJ1cHRzID0gPDAgODAg
NCAgMCA4MSA0ICAwIDgyIDQ+Ow0KPj4+PiAgICAgICAgICAgIGlvbW11cyA9IDwweGZkZWEgMHgw
MT47DQo+Pj4+ICAgICAgICAgfTsNCj4+Pj4gICAgIH07DQo+Pj4+IH07DQo+Pj4+ICBJbiB4bC5j
Zmcgd2UgbmVlZCB0byBkZWZpbmUgYSBuZXcgb3B0aW9uIHRvIGluZm9ybSBYZW4gYWJvdXQgdk1h
c3RlcklkIHRvIHBNYXN0ZXJJZCBtYXBwaW5nIGFuZCB0byB3aGljaCBJT01NVSBkZXZpY2UgdGhp
cw0KPj4+PiB0aGUgbWFzdGVyIGRldmljZSBpcyBjb25uZWN0ZWQgc28gdGhhdCBYZW4gY2FuIGNv
bmZpZ3VyZSB0aGUgcmlnaHQgSU9NTVUuIFRoaXMgaXMgcmVxdWlyZWQgaWYgdGhlIHN5c3RlbSBo
YXMgZGV2aWNlcyB0aGF0IGhhdmUNCj4+Pj4gdGhlIHNhbWUgbWFzdGVyIElEIGJ1dCBiZWhpbmQg
YSBkaWZmZXJlbnQgSU9NTVUuDQo+Pj4gDQo+Pj4gSW4geGwuY2ZnLCB3ZSBhbHJlYWR5IHBhc3Mg
dGhlIGRldmljZS10cmVlIG5vZGUgcGF0aCB0byBwYXNzdGhyb3VnaC4gU28gWGVuIHNob3VsZCBh
bHJlYWR5IGhhdmUgYWxsIHRoZSBpbmZvcm1hdGlvbiBhYm91dCB0aGUgSU9NTVUgYW5kIE1hc3Rl
ci1JRC4gU28gaXQgZG9lc24ndCBzZWVtIG5lY2Vzc2FyeSBmb3IgRGV2aWNlLVRyZWUuDQo+Pj4g
DQo+Pj4gRm9yIEFDUEksIEkgd291bGQgaGF2ZSBleHBlY3RlZCB0aGUgaW5mb3JtYXRpb24gdG8g
YmUgZm91bmQgaW4gdGhlIElPUkVRLg0KPj4+IA0KPj4+IFNvIGNhbiB5b3UgYWRkIG1vcmUgY29u
dGV4dCB3aHkgdGhpcyBpcyBuZWNlc3NhcnkgZm9yIGV2ZXJ5b25lPw0KPj4gV2UgaGF2ZSBpbmZv
cm1hdGlvbiBmb3IgSU9NTVUgYW5kIE1hc3Rlci1JRCBidXQgd2UgZG9u4oCZdCBoYXZlIGluZm9y
bWF0aW9uIGZvciBsaW5raW5nIHZNYXN0ZXItSUQgdG8gcE1hc3Rlci1JRC4NCj4gDQo+IEkgYW0g
Y29uZnVzZWQuIEJlbG93LCB5b3UgYXJlIG1ha2luZyB0aGUgdmlydHVhbCBtYXN0ZXIgSUQgb3B0
aW9uYWwuIFNvIHNob3VsZG4ndCB0aGlzIGJlIG1hbmRhdG9yeSBpZiB5b3UgcmVhbGx5IG5lZWQg
dGhlIG1hcHBpbmcgd2l0aCB0aGUgdmlydHVhbCBJRD8NCg0Kdk1hc3RlcklEIGlzIG9wdGlvbmFs
IGlmIHVzZXIga25vd3MgcE1hc3RlcklEIGlzIHVuaXF1ZSBvbiB0aGUgc3lzdGVtLiBCdXQgaWYg
cE1hc3RlcklkIGlzIG5vdCB1bmlxdWUgdGhlbiB1c2VyIG5lZWRzIHRvIHByb3ZpZGUgdGhlIHZN
YXN0ZXJJRC4NCg0KPiANCj4+IFRoZSBkZXZpY2UgdHJlZSBub2RlIHdpbGwgYmUgdXNlZCB0byBh
c3NpZ24gdGhlIGRldmljZSB0byB0aGUgZ3Vlc3QgYW5kIGNvbmZpZ3VyZSB0aGUgU3RhZ2UtMiB0
cmFuc2xhdGlvbi4gR3Vlc3Qgd2lsbCB1c2UgdGhlDQo+PiB2TWFzdGVyLUlEIHRvIGNvbmZpZ3Vy
ZSB0aGUgdklPTU1VIGR1cmluZyBib290LiBYZW4gbmVlZHMgaW5mb3JtYXRpb24gdG8gbGluayB2
TWFzdGVyLUlEIHRvIHBNYXN0ZXItSUQgdG8gY29uZmlndXJlDQo+PiB0aGUgY29ycmVzcG9uZGlu
ZyBwSU9NTVUuIEFzIEkgbWVudGlvbiB3ZSBuZWVkIHZNYXN0ZXItSUQgaW4gY2FzZSBhIHN5c3Rl
bSBjb3VsZCBoYXZlIDIgaWRlbnRpY2FsIE1hc3Rlci1JRCBidXQNCj4+IGVhY2ggb25lIGNvbm5l
Y3RlZCB0byBhIGRpZmZlcmVudCBTTU1VIGFuZCBhc3NpZ25lZCB0byB0aGUgZ3Vlc3QuDQo+IA0K
PiBJIGFtIGFmcmFpZCBJIHN0aWxsIGRvbid0IHVuZGVyc3RhbmQgd2h5IHRoaXMgaXMgYSByZXF1
aXJlbWVudC4gTGlieGwgY291bGQgaGF2ZSBlbm91Z2gga25vd2xlZGdlICh3aGljaCB3aWxsIGJl
IG5lY2Vzc2FycnkgZm9yIHRoZSBQQ0kgY2FzZSkgdG8ga25vdyB0aGUgSU9NTVUgYW5kIHBNYXN0
ZXJJRCBhc3NvY2lhdGVkIHdpdGggYSBkZXZpY2UuDQo+IA0KPiBTbyBsaWJ4bCBjb3VsZCBhbGxv
Y2F0ZSB0aGUgdk1hc3RlcklELCB0ZWxsIFhlbiB0aGUgY29ycmVzcG9uZGluZyBtYXBwaW5nIGFu
ZCB1cGRhdGUgdGhlIGRldmljZS10cmVlLg0KPiANCj4gSU9XLCBpdCBkb2Vzbid0IHNlZW0gdG8g
YmUgbmVjZXNzYXJ5IHRvIGludm9sdmUgdGhlIHVzZXIgaW4gdGhlIHByb2Nlc3MgaGVyZS4NCg0K
WWVzLCBsaWJ4bCBjb3VsZCBhbGxvY2F0ZSB0aGUgdk1hc3RlcklEIGJ1dCB0aGVyZSBpcyBubyB3
YXkgd2UgY2FuIGZpbmQgdGhlIGxpbmsgYi93IHZNYXN0ZXJJRCBjcmVhdGVkIHRvIHBNYXN0ZXJJ
RCBmcm9tIGR0ZGV2Lg0KDQpXaGF0IEkgdW5kZXJzdGFuZCBmcm9tIHRoZSBjb2RlIGlzIHRoYXQg
dGhlcmUgaXMgbm8gbGluayBiZXR3ZWVuIHRoZSBwYXNzdGhyb3VnaCBub2RlIGFuZCBkdGRldiBj
b25maWcgb3B0aW9uLiBUaGUgcGFzc3Rocm91Z2gNCm5vZGUgaXMgZGlyZWN0bHkgY29waWVkIHRv
IGd1ZXN0IERUIHdpdGhvdXQgYW55IG1vZGlmaWNhdGlvbi4gRHRkZXYgaXMgdXNlZCB0byBhZGQg
YW5kIGFzc2lnbiB0aGUgZGV2aWNlIHRvIElPTU1VLiANCg0KTGV0J3MgdGFrZSBhbiBleGFtcGxl
IGlmIHRoZSB1c2VyIHdhbnRzIHRvIGFzc2lnbiB0d28gZGV2aWNlcyB0byB0aGUgZ3Vlc3Qgdmlh
IHBhc3N0aHJvdWdoIG5vZGUuDQoNCi9kdHMtdjEvOw0KDQovIHsNCiAgIC8qICMqY2VsbHMgYXJl
IGhlcmUgdG8ga2VlcCBEVEMgaGFwcHkgKi8NCiAgICNhZGRyZXNzLWNlbGxzID0gPDI+Ow0KICAg
I3NpemUtY2VsbHMgPSA8Mj47DQoNCiAgIGFsaWFzZXMgew0KICAgICAgIG5ldCA9ICZtYWMwOw0K
ICAgfTsNCg0KICAgcGFzc3Rocm91Z2ggew0KICAgICAgIGNvbXBhdGlibGUgPSAic2ltcGxlLWJ1
cyI7DQogICAgICAgcmFuZ2VzOw0KICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Ow0KICAgICAg
ICNzaXplLWNlbGxzID0gPDI+Ow0KDQogICAgICAgbWFjMDogZXRoZXJuZXRAMTAwMDAwMDAgew0K
ICAgICAgICAgICBjb21wYXRpYmxlID0gImNhbHhlZGEsaGIteGdtYWMiOw0KICAgICAgICAgICBy
ZWcgPSA8MCAweDEwMDAwMDAwIDAgMHgxMDAwPjsNCiAgICAgICAgICAgaW50ZXJydXB0cyA9IDww
IDgwIDQgIDAgODEgNCAgMCA4MiA0PjsNCiAgICAgICB9Ow0KDQogICAgIG1hYzE6IGV0aGVybmV0
QDIwMDAwMDAwIHsNCiAgICAgICAgICAgY29tcGF0aWJsZSA9IOKAnHI4MTY5IjsNCiAgICAgICAg
ICAgcmVnID0gPDAgMHgxMDAwMDAwMCAwIDB4MTAwMD47DQogICAgICAgICAgIGludGVycnVwdHMg
PSA8MCA4MCA0ICAwIDgxIDQgIDAgODIgND47DQogICAgICAgfTsNCg0KICAgfTsNCn07DQoNCmR0
ZGV2ID0gWyAiL3NvYy9ldGhlcm5ldEAxMDAwMDAwMOKAnSwg4oCcL3NvYy9ldGhlcm5ldEBmMjAw
MDAwMOKAnSBdDQoNClRoZXJlIGlzIG5vIGxpbmsgd2hpY2ggZHRkZXYgZW50cnkgYmVsb25ncyB0
byB3aGljaCBub2RlLiBUaGVyZWZvciB0aGVyZSBpcyBubyB3YXkgdG8gbGluayB0aGUgdk1hc3Rl
cklEIGNyZWF0ZWQgdG8gcE1hc3RlcklELg0KDQo+IA0KPj4+IA0KPj4+PiAgaW9tbXVfZGV2aWRf
bWFwID0gWyDigJxQTUFTVEVSX0lEW0BWTUFTVEVSX0lEXSxJT01NVV9CQVNFX0FERFJFU1PigJ0g
LCDigJxQTUFTVEVSX0lEW0BWTUFTVEVSX0lEXSxJT01NVV9CQVNFX0FERFJFU1PigJ1dDQo+Pj4+
IAnigKIgUE1BU1RFUl9JRCBpcyB0aGUgcGh5c2ljYWwgbWFzdGVyIElEIG9mIHRoZSBkZXZpY2Ug
ZnJvbSB0aGUgcGh5c2ljYWwgRFQuDQo+Pj4+IAnigKIgVk1BU1RFUl9JRCBpcyB0aGUgdmlydHVh
bCBtYXN0ZXIgSWQgdGhhdCB0aGUgdXNlciB3aWxsIGNvbmZpZ3VyZSBpbiB0aGUgcGFydGlhbCBk
ZXZpY2UgdHJlZS4NCj4+Pj4gCeKAoiBJT01NVV9CQVNFX0FERFJFU1MgaXMgdGhlIGJhc2UgYWRk
cmVzcyBvZiB0aGUgcGh5c2ljYWwgSU9NTVUgZGV2aWNlIHRvIHdoaWNoIHRoaXMgZGV2aWNlIGlz
IGNvbm5lY3RlZC4NCj4+PiANCj4+PiBCZWxvdyB5b3UgZ2l2ZSBhbiBleGFtcGxlIGZvciBQbGF0
Zm9ybSBkZXZpY2UuIEhvdyB3b3VsZCB0aGF0IGZpdCBpbiB0aGUgY29udGV4dCBvZiBQQ0kgcGFz
c3Rocm91Z2g/DQo+PiBJbiBQQ0kgcGFzc3Rocm91Z2ggY2FzZSwgeGwgd2lsbCBjcmVhdGUgdGhl
ICJpb21tdS1tYXAiIHByb3BlcnR5IGluIHZwY2kgaG9zdCBicmlkZ2Ugbm9kZSB3aXRoIHBoYW5k
bGUgdG8gdklPTU1VIG5vZGUuDQo+PiB2U01NVXYzIG5vZGUgd2lsbCBiZSBjcmVhdGVkIGluIHhs
Lg0KPiANCj4gVGhpcyBtZWFucyB0aGF0IGxpYnhsIHdpbGwgbmVlZCB0byBrbm93IHRoZSBhc3Nv
Y2lhdGVkIHBNYXN0ZXJJRCB0byBhIFBDSSBkZXZpY2UuIFNvLCBJIGRvbid0IHVuZGVyc3RhbmQg
d2h5IHlvdSBjYW4ndCBkbyB0aGUgc2FtZSBmb3IgcGxhdGZvcm0gZGV2aWNlcy4NCg0KRm9yIHRo
ZSBQQ0kgcGFzc3Rocm91Z2ggY2FzZSwgd2UgZG9u4oCZdCBuZWVkIHRvIHByb3ZpZGUgdGhlIE1h
c3RlcklEIHRvIGNyZWF0ZSAiaW9tbXUtbWFw4oCdIHByb3BlcnR5IGFzIGZvciANClBDSSBkZXZp
Y2UgTWFzdGVySUQgaXMgUklEICggQkRGICkuIEZvciBub24tUENJIGRldmljZXMsIE1hc3RlcklE
IGlzIHJlcXVpcmVkIHRvIGNyZWF0ZSDigJxpb21tdXPigJ0gcHJvcGVydHkuDQoNCkFsc28sIFZQ
Q0kgd2lsbCBjcmVhdGUgdGhlIHZpcnR1YWwgU0JERiB3aGVuIHdlIGFzc2lnbmVkIFBDSSBkZXZp
Y2VzIHRvIHRoZSBndWVzdC4gWGVuIGNhbiBlYXNpbHkgZmluZCB0aGUNCnBoeXNpY2FsIFNCREYg
YW5kIHBJT01NVSBmcm9tIHZpcnR1YWwgU0JERiBhcyBYZW4gaGFzIGFsbCB0aGUgaW5mb3JtYXRp
b24gZm9yIFBDSSBkZXZpY2VzLg0KDQo+IA0KPj4+IA0KPj4+PiAgRXhhbXBsZTogTGV0J3Mgc2F5
IHRoZSB1c2VyIHdhbnRzIHRvIGFzc2lnbiB0aGUgYmVsb3cgcGh5c2ljYWwgZGV2aWNlIGluIERU
IHRvIHRoZSBndWVzdC4NCj4+Pj4gIGlvbW11QDRmMDAwMDAwIHsNCj4+Pj4gICAgICAgICAgICAg
ICAgIGNvbXBhdGlibGUgPSAiYXJtLHNtbXUtdjMiOw0KPj4+PiAgICAgICAgICAgICAgCWludGVy
cnVwdHMgPSA8MHgwMCAweGU0IDB4ZjA0PjsNCj4+Pj4gICAgICAgICAgICAgICAgIGludGVycnVw
dC1wYXJlbnQgPSA8MHgwMT47DQo+Pj4+ICAgICAgICAgICAgICAgICAjaW9tbXUtY2VsbHMgPSA8
MHgwMT47DQo+Pj4+ICAgICAgICAgICAgICAgICBpbnRlcnJ1cHQtbmFtZXMgPSAiY29tYmluZWQi
Ow0KPj4+PiAgICAgICAgICAgICAgICAgcmVnID0gPDB4MDAgMHg0ZjAwMDAwMCAweDAwIDB4NDAw
MDA+Ow0KPj4+PiAgICAgICAgICAgICAgICAgcGhhbmRsZSA9IDwweGZkZWI+Ow0KPj4+PiAgICAg
ICAgICAgICAgICAgbmFtZSA9ICJpb21tdSI7DQo+Pj4+IH07DQo+Pj4gDQo+Pj4gU28gSSBndWVz
cyB0aGlzIG5vZGUgd2lsbCBiZSB3cml0dGVuIGJ5IFhlbi4gSG93IHdpbGwgeW91IHRoZSBjYXNl
IHdoZXJlIHRoZXJlIGFyZSBleHRyYSBwcm9wZXJ0eSB0byBhZGRlZCAoZS5nLiBkbWEtY29oZXJl
bnQpPw0KPj4gSW4gdGhpcyBleGFtcGxlIHRoaXMgaXMgcGh5c2ljYWwgSU9NTVUgbm9kZS4gdklP
TU1VIG5vZGUgd2lsIGJlIGNyZWF0ZWQgYnkgeGwgZHVyaW5nIGd1ZXN0IGNyZWF0aW9uLg0KPiAN
Cj4gT2suIEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIHVzZSB2ZXJ5IGRpZmZlcmVudCBw
aGFuZGxlIGluIHlvdXIgZXhhbXBsZSBzbyBpdCBkb2Vzbid0IGxvb2sgbGlrZSBhIG1pc3Rha2Uu
DQo+IA0KDQpBY2sNCg0KUmVnYXJkcywNClJhaHVs


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 16:12:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 16:12:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431105.683658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5V0-0002Od-Hh; Thu, 27 Oct 2022 16:12:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431105.683658; Thu, 27 Oct 2022 16:12:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5V0-0002OW-EW; Thu, 27 Oct 2022 16:12:54 +0000
Received: by outflank-mailman (input) for mailman id 431105;
 Thu, 27 Oct 2022 16:12:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WPLX=24=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1oo5Uz-0002OP-8S
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 16:12:53 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2045.outbound.protection.outlook.com [40.107.249.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3471218b-5612-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 18:12:51 +0200 (CEST)
Received: from AM6PR08CA0003.eurprd08.prod.outlook.com (2603:10a6:20b:b2::15)
 by DBAPR08MB5845.eurprd08.prod.outlook.com (2603:10a6:10:1a5::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27; Thu, 27 Oct
 2022 16:12:40 +0000
Received: from AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::9b) by AM6PR08CA0003.outlook.office365.com
 (2603:10a6:20b:b2::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Thu, 27 Oct 2022 16:12:40 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT043.mail.protection.outlook.com (100.127.140.160) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Thu, 27 Oct 2022 16:12:40 +0000
Received: ("Tessian outbound aeae1c7b66fd:v130");
 Thu, 27 Oct 2022 16:12:39 +0000
Received: from 96e75caddee2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 75336368-189A-4848-BAC4-17A035FEE336.1; 
 Thu, 27 Oct 2022 16:12:29 +0000
Received: from EUR02-AM0-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96e75caddee2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 27 Oct 2022 16:12:29 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24)
 by AS2PR08MB9872.eurprd08.prod.outlook.com (2603:10a6:20b:593::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct
 2022 16:12:21 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572]) by AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572%4]) with mapi id 15.20.5709.015; Thu, 27 Oct 2022
 16:12:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3471218b-5612-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=nqPSWDR0+p/K7KLqCMFlNtChevDgD6VJHwihZVHGYkH1LHwDpNDoIMq2LVo/k7IdLpiztr6MfI1d4L/CtRzQFfGWjzqQu1UJEQGj2pqPftXeLizHoshRjJfzKT+FgLLMsD7sGXPs0d8t0sxl/HkWdALafuij6d+DWHZl9eDj2Yg+c4+71Y+hWWAHYDBqy3vZry19aZh9ZA1FVuFAEzkIikFvqmbLi6BQy9/JSIYBwrt9tsZamekMg0ynfLq0nngnclKiWEeb3V0+Y64N6IJIAAuQNiMqU+U3Yt3d1sMP/ZvhFmoCpKtx4drzBKwH1YlXNNH+UG+wABNMBikV3ueTQw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sQXFUjz6pUP2jOn1u7TPpY2+qa2Qni+KHtughFLBD+g=;
 b=WJ96zLdc2i/krZo77eBZH3c8UYvbPf2ppef0gsm+ew0cWyMmN7so35moKkW31/bqMit/vgHugc3vrDs5P/qxGU4m5Wv2Y/3vTc/fwMxio0rRlx2XQZZW8PvotAvlzSuoNIADgwHg6eRV0cDyeTDtCrtdlOel1J0vUSlrX2n2LfcaYpaAva+1ppIihFLSybRY2CXGMOa2+45sC6bu5hPfLulUWbUzTengdye8jyouXfQXhu5mbnrLTrDL0GYP6Fl2Xrfe1adTnoE2PovjvyeQ10dqMwSWRIa6jvBextJaKHNaQDuLzQqqKqdg3r95/bmZJfNeFIcbfpWmhnb/OXTWsQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sQXFUjz6pUP2jOn1u7TPpY2+qa2Qni+KHtughFLBD+g=;
 b=Llhwq9RbsO1tHy4OeZywwBdpXD7Mkgau5iUkxBG6iSekBWGdTXOT3Dv1+cLf9Sg8Dgl5F3sUYnd9c/cNVEoUEZowOaFMbWh64FkQdIq1kqFq6wZAgvsUTsq359iydBC/XsyXU8hRXuhGdoEP3b3yD+AT4bGDjN8a+RxrtVsFoOY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 763fba3040961573
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J6wuwRuSFvVJz3hn9xP0mX7WvFVkTlpi16N561EQemczYIz/T4lmAnL+Qi2VlcP6cmof3dArZirsB9xT7w2WBQBKJDw51hb3913JSDiFIbA7Sl2q+60Fwxgu+H5rp6+QYP734y735Z33Dh1zAxC5xVAebHVKal0B/lb6QosfVkjvZM6rKmZdujx8wrfPji7HxvHL5M/o59tx/EcA1NSTXqYIAaUFyIPHtIWdcbYpU4dugFujWvvVu3bAsNsG99pzQZQXphsDg/7k7tA6R7lndIhBJzDYNB4Yn3XVBwoCchpr1iOBNDtQ0nhWOrLDyGi2QKQI6K4H1eEH46QyCiWJTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sQXFUjz6pUP2jOn1u7TPpY2+qa2Qni+KHtughFLBD+g=;
 b=Nd9/H390Y0gvKv8SGf2n/+DMVoZMoqpUEmDfzg6EomxNH/0DM7F3Ua9TXC2SUvos5l5HiT3ei+OedIyg4o7qNUB2BTdEov7zDgY4cZrHZlhZbT6h1GvG6UuTD4w7NqHAFuCJyeSMNGgQ2QLWMd37R7Ga+B6B13CndT9O+Rf1+rZXOUFiduS1/YdYFtDWEQg0fSG/2x7ndvq8vL73I6JpNe0tUS3Lz3Csc33EJJeqz8x6zk9FYZvu73KwAKc053EIGTx2MotmTjqzMzUS1I99pXeaNPLEV0+uZlP+W4QQvpZzjJCmN7pt6ANvnBxXwROzA4wacSc4yk6y5YalSln93w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sQXFUjz6pUP2jOn1u7TPpY2+qa2Qni+KHtughFLBD+g=;
 b=Llhwq9RbsO1tHy4OeZywwBdpXD7Mkgau5iUkxBG6iSekBWGdTXOT3Dv1+cLf9Sg8Dgl5F3sUYnd9c/cNVEoUEZowOaFMbWh64FkQdIq1kqFq6wZAgvsUTsq359iydBC/XsyXU8hRXuhGdoEP3b3yD+AT4bGDjN8a+RxrtVsFoOY=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: Julien Grall <julien@xen.org>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Michal
 Orzel <Michal.Orzel@arm.com>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index: AQHY6T1VjOHHQJGN7kyXeL6pAIKNMa4grXIAgAAQBQCAAC3DgIABgBSA
Date: Thu, 27 Oct 2022 16:12:21 +0000
Message-ID: <3293BDA0-76E5-49E4-A695-B677F9B9AB57@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
In-Reply-To: <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7158:EE_|AS2PR08MB9872:EE_|AM7EUR03FT043:EE_|DBAPR08MB5845:EE_
X-MS-Office365-Filtering-Correlation-Id: feeaa752-bee6-41b1-a919-08dab8361266
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 2Knn2kDS1Lpb8HHQoVppw+roL7ZbuHwSpbwOrAPDeiAcMQdPyPZguOhW4N58NLiKTw5NazrQt+FY1r/yxCqdI7tCVDLuZ/dYYZxiZtjxz3KqJJmjaIsoOAnWEKGM2eMN5SjlLwV6GGYBEMD3M5zPHluuzTgmA3ENnQHle+J1tIMn8Fwr7QEaHqCpUhWHZ622+PGe+2/G5kcil1Jp1xfq2a0nHwa0x0hzQtXpgmIpBViSYUtd4M/a6QyUCNdvc6ay+qy22hFekni05vBiFqBAr7L0syiC8a3lWVlzdKqyCwkLd2UrxW2JaTcMxqxpOzVNFvx6bit+Yj5SX3xjUlFvIX5h09Ha/Gfy46GCcdg3QZhawUaTlWSOrZjiFw4TKMNxHz7uSnqHtQA8NXr9vnujxroFCzZqa/abQtjgv8DGH3jjZVhhuDbmN7YtL+JK/17JcXnZWVFIBe83AeUEKgJBPOU6q1j7LLGX8bLt7xv9ECngdt1eCEyGDnjMx46lf4l82xyPSbcqcDl7oq+O2Nx5zVqKG1xzmfpaeENDSCT7Sr3M0ZSmtUuWL7i6BNKtTHdSrZkF7fhoMB6hmwBTpxP9joWQ9YjOJpG0mHK/HxDBOpiCweBVHD8HaHaKWNdFmiUk8I36G9InuU8uTKSllNPO3XkrJeGGszZNuw7QjerTShW8VqmKD3wac2Xz11fO3+D5aoHlkfZv2kCiAfjkke7vSyPQ8Xd7HD0+mvv4NN0O3zjiAE4Po87HzqG1yeLKLpTkx4ZffACkeShoujbo+iQA/62WhCk3RMsec+FB480qUwJdeePoRwQ8cgHLIXb4+MZ6c262wxuXHUHS9jLJuUP9kw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199015)(2616005)(26005)(186003)(478600001)(6512007)(53546011)(6506007)(71200400001)(91956017)(2906002)(66946007)(4326008)(66556008)(83380400001)(6486002)(66446008)(7416002)(54906003)(316002)(8936002)(8676002)(6916009)(5660300002)(41300700001)(76116006)(66476007)(64756008)(36756003)(86362001)(33656002)(38100700002)(38070700005)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <5B629BF06008634DA854D6CA33A88199@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9872
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	bf51a69c-94ac-4e42-4933-08dab836076b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XMiInCxjM0Vn/PymhETCWQmlPptaMBl4HNEFdXxCsL2CiLZzyXTXsXrDUdZeLTSQ/B6Tu15IafevkCFihaYAd5xjB3Bo0Rm3JW+Jm5wnMbdDUqr5p52lp/4enpuQ/3YWcauidAjlgVOJHNg85g1cJljGwP1cYiEIy1qAYF6dkG/slaMYS1qZ4OpQ6AijMNracPo5l9B/LwYU3fuwkrthJrKPyLsjZh6hlI9M5mN8/CPQF3nOwAvZj67e/LQhODxqWbEaCtSnTT3EYd9dWSeEaFeXi4Jl5n0W4EksddjyhJ/NM1WtncNPCTduDxAlccMqD+qYb9c5qoCk2/Stmxk4gGljUqWzlKJ8T2Bh+DSE6ldt700kOMTQEZIXxvtoSpZZNS3K/4kIIupeeDIBSXg8bTuY/I7smj9TUZqxF6fsMq0HKp5Q7EGSSuZg+4epv3uqzbDPJ1ZF3QgE7/7nQ4kBH8z+G2vg7QV2J9i76qDeHN3son0x6MkMRlHV699wiIFK/sqsRG53RQwiKchUqti5c0DEwQmLPvkJz7zmKNjaFfErjWTcuPjugDVHPKfZG/Cib0emPYJa0IVaQbHcZI2ph6YSisbsaFbhrTMx7nyGS47yJc+ejt3TC/kbsxaTHSLg2O7HH3Z1oOBVz5dG4FkP2eGdJrg2t52dsEtReTQh4IE4UAEXCNwEm0lBQABNcYWHizVggWTxn9jMSG4HHxIURRf34RmTg9WJJFWU7VXf0yD+fD65cgxXr+bBTqSbdqLxNt2FfI+Qj6Ckvr4ugqI9xQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(81166007)(336012)(83380400001)(47076005)(2616005)(186003)(356005)(86362001)(36860700001)(53546011)(82740400003)(40460700003)(8936002)(5660300002)(6862004)(4326008)(40480700001)(82310400005)(54906003)(6512007)(70206006)(6506007)(70586007)(316002)(478600001)(8676002)(41300700001)(107886003)(6486002)(36756003)(33656002)(2906002)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 16:12:40.2027
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: feeaa752-bee6-41b1-a919-08dab8361266
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5845

SGkgTWljaGFsLA0KDQo+IE9uIDI2IE9jdCAyMDIyLCBhdCA2OjE3IHBtLCBNaWNoYWwgT3J6ZWwg
PG1pY2hhbC5vcnplbEBhbWQuY29tPiB3cm90ZToNCj4gDQo+IEhpIFJhaHVsLA0KPiANCj4gT24g
MjYvMTAvMjAyMiAxNjozMywgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiANCj4+IA0KPj4gSGkgSnVs
aWVuLA0KPj4gDQo+Pj4gT24gMjYgT2N0IDIwMjIsIGF0IDI6MzYgcG0sIEp1bGllbiBHcmFsbCA8
anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+IA0KPj4+IA0KPj4+IA0KPj4+IE9uIDI2LzEwLzIw
MjIgMTQ6MTcsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+PiBIaSBBbGwsDQo+Pj4gDQo+Pj4gSGkg
UmFodWwsDQo+Pj4gDQo+Pj4+IEF0IEFybSwgd2Ugc3RhcnRlZCB0byBpbXBsZW1lbnQgdGhlIFBP
QyB0byBzdXBwb3J0IDIgbGV2ZWxzIG9mIHBhZ2UgdGFibGVzL25lc3RlZCB0cmFuc2xhdGlvbiBp
biBTTU1VdjMuDQo+Pj4+IFRvIHN1cHBvcnQgbmVzdGVkIHRyYW5zbGF0aW9uIGZvciBndWVzdCBP
UyBYZW4gbmVlZHMgdG8gZXhwb3NlIHRoZSB2aXJ0dWFsIElPTU1VLiBJZiB3ZSBwYXNzdGhyb3Vn
aCB0aGUNCj4+Pj4gZGV2aWNlIHRvIHRoZSBndWVzdCB0aGF0IGlzIGJlaGluZCBhbiBJT01NVSBh
bmQgdmlydHVhbCBJT01NVSBpcyBlbmFibGVkIGZvciB0aGUgZ3Vlc3QgdGhlcmUgaXMgYSBuZWVk
IHRvDQo+Pj4+IGFkZCBJT01NVSBiaW5kaW5nIGZvciB0aGUgZGV2aWNlIGluIHRoZSBwYXNzdGhy
b3VnaCBub2RlIGFzIHBlciBbMV0uIFRoaXMgZW1haWwgaXMgdG8gZ2V0IGFuIGFncmVlbWVudCBv
bg0KPj4+PiBob3cgdG8gYWRkIHRoZSBJT01NVSBiaW5kaW5nIGZvciBndWVzdCBPUy4NCj4+Pj4g
QmVmb3JlIEkgd2lsbCBleHBsYWluIGhvdyB0byBhZGQgdGhlIElPTU1VIGJpbmRpbmcgbGV0IG1l
IGdpdmUgYSBicmllZiBvdmVydmlldyBvZiBob3cgd2Ugd2lsbCBhZGQgc3VwcG9ydCBmb3Igdmly
dHVhbA0KPj4+PiBJT01NVSBvbiBBcm0uIEluIG9yZGVyIHRvIGltcGxlbWVudCB2aXJ0dWFsIElP
TU1VIFhlbiBuZWVkIFNNTVV2MyBOZXN0ZWQgdHJhbnNsYXRpb24gc3VwcG9ydC4gU01NVXYzIGhh
cmR3YXJlDQo+Pj4+IHN1cHBvcnRzIHR3byBzdGFnZXMgb2YgdHJhbnNsYXRpb24uIEVhY2ggc3Rh
Z2Ugb2YgdHJhbnNsYXRpb24gY2FuIGJlIGluZGVwZW5kZW50bHkgZW5hYmxlZC4gQW4gaW5jb21p
bmcgYWRkcmVzcyBpcyBsb2dpY2FsbHkNCj4+Pj4gdHJhbnNsYXRlZCBmcm9tIFZBIHRvIElQQSBp
biBzdGFnZSAxLCB0aGVuIHRoZSBJUEEgaXMgaW5wdXQgdG8gc3RhZ2UgMiB3aGljaCB0cmFuc2xh
dGVzIHRoZSBJUEEgdG8gdGhlIG91dHB1dCBQQS4gU3RhZ2UgMSBpcw0KPj4+PiBpbnRlbmRlZCB0
byBiZSB1c2VkIGJ5IGEgc29mdHdhcmUgZW50aXR5KCBHdWVzdCBPUykgdG8gcHJvdmlkZSBpc29s
YXRpb24gb3IgdHJhbnNsYXRpb24gdG8gYnVmZmVycyB3aXRoaW4gdGhlIGVudGl0eSwgZm9yIGV4
YW1wbGUsDQo+Pj4+IERNQSBpc29sYXRpb24gd2l0aGluIGFuIE9TLiBTdGFnZSAyIGlzIGludGVu
ZGVkIHRvIGJlIGF2YWlsYWJsZSBpbiBzeXN0ZW1zIHN1cHBvcnRpbmcgdGhlIFZpcnR1YWxpemF0
aW9uIEV4dGVuc2lvbnMgYW5kIGlzDQo+Pj4+IGludGVuZGVkIHRvIHZpcnR1YWxpemUgZGV2aWNl
IERNQSB0byBndWVzdCBWTSBhZGRyZXNzIHNwYWNlcy4gV2hlbiBib3RoIHN0YWdlIDEgYW5kIHN0
YWdlIDIgYXJlIGVuYWJsZWQsIHRoZSB0cmFuc2xhdGlvbg0KPj4+PiBjb25maWd1cmF0aW9uIGlz
IGNhbGxlZCBuZXN0aW5nLg0KPj4+PiBTdGFnZSAxIHRyYW5zbGF0aW9uIHN1cHBvcnQgaXMgcmVx
dWlyZWQgdG8gcHJvdmlkZSBpc29sYXRpb24gYmV0d2VlbiBkaWZmZXJlbnQgZGV2aWNlcyB3aXRo
aW4gdGhlIGd1ZXN0IE9TLiBYRU4gYWxyZWFkeSBzdXBwb3J0cw0KPj4+PiBTdGFnZSAyIHRyYW5z
bGF0aW9uIGJ1dCB0aGVyZSBpcyBubyBzdXBwb3J0IGZvciBTdGFnZSAxIHRyYW5zbGF0aW9uIGZv
ciBndWVzdHMuIFdlIHdpbGwgYWRkIHN1cHBvcnQgZm9yIGd1ZXN0cyB0byBjb25maWd1cmUNCj4+
Pj4gdGhlIFN0YWdlIDEgdHJhbnNpdGlvbiB2aWEgdmlydHVhbCBJT01NVS4gWEVOIHdpbGwgZW11
bGF0ZSB0aGUgU01NVSBoYXJkd2FyZSBhbmQgZXhwb3NlcyB0aGUgdmlydHVhbCBTTU1VIHRvIHRo
ZSBndWVzdC4NCj4+Pj4gR3Vlc3QgY2FuIHVzZSB0aGUgbmF0aXZlIFNNTVUgZHJpdmVyIHRvIGNv
bmZpZ3VyZSB0aGUgc3RhZ2UgMSB0cmFuc2xhdGlvbi4gV2hlbiB0aGUgZ3Vlc3QgY29uZmlndXJl
cyB0aGUgU01NVSBmb3IgU3RhZ2UgMSwNCj4+Pj4gWEVOIHdpbGwgdHJhcCB0aGUgYWNjZXNzIGFu
ZCBjb25maWd1cmUgdGhlIGhhcmR3YXJlIGFjY29yZGluZ2x5Lg0KPj4+PiBOb3cgYmFjayB0byB0
aGUgcXVlc3Rpb24gb2YgaG93IHdlIGNhbiBhZGQgdGhlIElPTU1VIGJpbmRpbmcgYmV0d2VlbiB0
aGUgdmlydHVhbCBJT01NVSBhbmQgdGhlIG1hc3RlciBkZXZpY2VzIHNvIHRoYXQNCj4+Pj4gZ3Vl
c3RzIGNhbiBjb25maWd1cmUgdGhlIElPTU1VIGNvcnJlY3RseS4gVGhlIHNvbHV0aW9uIHRoYXQg
SSBhbSBzdWdnZXN0aW5nIGlzIGFzIGJlbG93Og0KPj4+PiBGb3IgZG9tMCwgd2hpbGUgaGFuZGxp
bmcgdGhlIERUIG5vZGUoaGFuZGxlX25vZGUoKSkgWGVuIHdpbGwgcmVwbGFjZSB0aGUgcGhhbmRs
ZSBpbiB0aGUgImlvbW11cyIgcHJvcGVydHkgd2l0aCB0aGUgdmlydHVhbA0KPj4+PiBJT01NVSBu
b2RlIHBoYW5kbGUuDQo+Pj4gQmVsb3csIHlvdSBzYWlkIHRoYXQgZWFjaCBJT01NVXMgbWF5IGhh
dmUgYSBkaWZmZXJlbnQgSUQgc3BhY2UuIFNvIHNob3VsZG4ndCB3ZSBleHBvc2Ugb25lIHZJT01N
VSBwZXIgcElPTU1VPyBJZiBub3QsIGhvdyBkbyB5b3UgZXhwZWN0IHRoZSB1c2VyIHRvIHNwZWNp
ZnkgdGhlIG1hcHBpbmc/DQo+PiANCj4+IFllcyB5b3UgYXJlIHJpZ2h0IHdlIG5lZWQgdG8gY3Jl
YXRlIG9uZSB2SU9NTVUgcGVyIHBJT01NVSBmb3IgZG9tMC4gVGhpcyBhbHNvIGhlbHBzIGluIHRo
ZSBBQ1BJIGNhc2UNCj4+IHdoZXJlIHdlIGRvbuKAmXQgbmVlZCB0byBtb2RpZnkgdGhlIHRhYmxl
cyB0byBkZWxldGUgdGhlIHBJT01NVSBlbnRyaWVzIGFuZCBjcmVhdGUgb25lIHZJT01NVS4NCj4+
IEluIHRoaXMgY2FzZSwgbm8gbmVlZCB0byByZXBsYWNlIHRoZSBwaGFuZGxlIGFzIFhlbiBjcmVh
dGUgdGhlIHZJT01NVSB3aXRoIHRoZSBzYW1lIHBJT01NVQ0KPj4gcGhhbmRsZSBhbmQgc2FtZSBi
YXNlIGFkZHJlc3MuDQo+PiANCj4+IEZvciBkb21VIGd1ZXN0cyBvbmUgdklPTU1VIHBlciBndWVz
dCB3aWxsIGJlIGNyZWF0ZWQuDQo+PiANCj4+PiANCj4+Pj4gRm9yIGRvbVUgZ3Vlc3RzLCB3aGVu
IHBhc3N0aHJvdWdoIHRoZSBkZXZpY2UgdG8gdGhlIGd1ZXN0IGFzIHBlciBbMl0sICBhZGQgdGhl
IGJlbG93IHByb3BlcnR5IGluIHRoZSBwYXJ0aWFsIGRldmljZSB0cmVlDQo+Pj4+IG5vZGUgdGhh
dCBpcyByZXF1aXJlZCB0byBkZXNjcmliZSB0aGUgZ2VuZXJpYyBkZXZpY2UgdHJlZSBiaW5kaW5n
IGZvciBJT01NVXMgYW5kIHRoZWlyIG1hc3RlcihzKQ0KPj4+PiAiaW9tbXVzID0gPCAmbWFnaWNf
cGhhbmRsZSAweHZNYXN0ZXJJRD4NCj4+Pj4gICAgIOKAoiBtYWdpY19waGFuZGxlIHdpbGwgYmUg
dGhlIHBoYW5kbGUgKCB2SU9NTVUgcGhhbmRsZSBpbiB4bCkgIHRoYXQgd2lsbCBiZSBkb2N1bWVu
dGVkIHNvIHRoYXQgdGhlIHVzZXIgY2FuIHNldCB0aGF0IGluIHBhcnRpYWwgRFQgbm9kZSAoMHhm
ZGVhKS4NCj4+PiANCj4+PiBEb2VzIHRoaXMgbWVhbiBvbmx5IG9uZSBJT01NVSB3aWxsIGJlIHN1
cHBvcnRlZCBpbiB0aGUgZ3Vlc3Q/DQo+PiANCj4+IFllcy4NCj4+IA0KPj4+IA0KPj4+PiAgICAg
4oCiIHZNYXN0ZXJJRCB3aWxsIGJlIHRoZSB2aXJ0dWFsIG1hc3RlciBJRCB0aGF0IHRoZSB1c2Vy
IHdpbGwgcHJvdmlkZS4NCj4+Pj4gVGhlIHBhcnRpYWwgZGV2aWNlIHRyZWUgd2lsbCBsb29rIGxp
a2UgdGhpczoNCj4+Pj4gL2R0cy12MS87DQo+Pj4+IC8gew0KPj4+PiAgICAvKiAjKmNlbGxzIGFy
ZSBoZXJlIHRvIGtlZXAgRFRDIGhhcHB5ICovDQo+Pj4+ICAgICNhZGRyZXNzLWNlbGxzID0gPDI+
Ow0KPj4+PiAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4+Pj4gICAgICBhbGlhc2VzIHsNCj4+Pj4g
ICAgICAgIG5ldCA9ICZtYWMwOw0KPj4+PiAgICB9Ow0KPj4+PiAgICAgIHBhc3N0aHJvdWdoIHsN
Cj4+Pj4gICAgICAgIGNvbXBhdGlibGUgPSAic2ltcGxlLWJ1cyI7DQo+Pj4+ICAgICAgICByYW5n
ZXM7DQo+Pj4+ICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4+Pj4gICAgICAgICNzaXpl
LWNlbGxzID0gPDI+Ow0KPj4+PiAgICAgICAgbWFjMDogZXRoZXJuZXRAMTAwMDAwMDAgew0KPj4+
PiAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiY2FseGVkYSxoYi14Z21hYyI7DQo+Pj4+ICAgICAg
ICAgICAgcmVnID0gPDAgMHgxMDAwMDAwMCAwIDB4MTAwMD47DQo+Pj4+ICAgICAgICAgICAgaW50
ZXJydXB0cyA9IDwwIDgwIDQgIDAgODEgNCAgMCA4MiA0PjsNCj4+Pj4gICAgICAgICAgIGlvbW11
cyA9IDwweGZkZWEgMHgwMT47DQo+Pj4+ICAgICAgICB9Ow0KPj4+PiAgICB9Ow0KPj4+PiB9Ow0K
Pj4+PiBJbiB4bC5jZmcgd2UgbmVlZCB0byBkZWZpbmUgYSBuZXcgb3B0aW9uIHRvIGluZm9ybSBY
ZW4gYWJvdXQgdk1hc3RlcklkIHRvIHBNYXN0ZXJJZCBtYXBwaW5nIGFuZCB0byB3aGljaCBJT01N
VSBkZXZpY2UgdGhpcw0KPj4+PiB0aGUgbWFzdGVyIGRldmljZSBpcyBjb25uZWN0ZWQgc28gdGhh
dCBYZW4gY2FuIGNvbmZpZ3VyZSB0aGUgcmlnaHQgSU9NTVUuIFRoaXMgaXMgcmVxdWlyZWQgaWYg
dGhlIHN5c3RlbSBoYXMgZGV2aWNlcyB0aGF0IGhhdmUNCj4+Pj4gdGhlIHNhbWUgbWFzdGVyIElE
IGJ1dCBiZWhpbmQgYSBkaWZmZXJlbnQgSU9NTVUuDQo+Pj4gDQo+Pj4gSW4geGwuY2ZnLCB3ZSBh
bHJlYWR5IHBhc3MgdGhlIGRldmljZS10cmVlIG5vZGUgcGF0aCB0byBwYXNzdGhyb3VnaC4gU28g
WGVuIHNob3VsZCBhbHJlYWR5IGhhdmUgYWxsIHRoZSBpbmZvcm1hdGlvbiBhYm91dCB0aGUgSU9N
TVUgYW5kIE1hc3Rlci1JRC4gU28gaXQgZG9lc24ndCBzZWVtIG5lY2Vzc2FyeSBmb3IgRGV2aWNl
LVRyZWUuDQo+Pj4gDQo+Pj4gRm9yIEFDUEksIEkgd291bGQgaGF2ZSBleHBlY3RlZCB0aGUgaW5m
b3JtYXRpb24gdG8gYmUgZm91bmQgaW4gdGhlIElPUkVRLg0KPj4+IA0KPj4+IFNvIGNhbiB5b3Ug
YWRkIG1vcmUgY29udGV4dCB3aHkgdGhpcyBpcyBuZWNlc3NhcnkgZm9yIGV2ZXJ5b25lPw0KPj4g
DQo+PiBXZSBoYXZlIGluZm9ybWF0aW9uIGZvciBJT01NVSBhbmQgTWFzdGVyLUlEIGJ1dCB3ZSBk
b27igJl0IGhhdmUgaW5mb3JtYXRpb24gZm9yIGxpbmtpbmcgdk1hc3Rlci1JRCB0byBwTWFzdGVy
LUlELg0KPj4gVGhlIGRldmljZSB0cmVlIG5vZGUgd2lsbCBiZSB1c2VkIHRvIGFzc2lnbiB0aGUg
ZGV2aWNlIHRvIHRoZSBndWVzdCBhbmQgY29uZmlndXJlIHRoZSBTdGFnZS0yIHRyYW5zbGF0aW9u
LiBHdWVzdCB3aWxsIHVzZSB0aGUNCj4+IHZNYXN0ZXItSUQgdG8gY29uZmlndXJlIHRoZSB2SU9N
TVUgZHVyaW5nIGJvb3QuIFhlbiBuZWVkcyBpbmZvcm1hdGlvbiB0byBsaW5rIHZNYXN0ZXItSUQg
dG8gcE1hc3Rlci1JRCB0byBjb25maWd1cmUNCj4+IHRoZSBjb3JyZXNwb25kaW5nIHBJT01NVS4g
QXMgSSBtZW50aW9uIHdlIG5lZWQgdk1hc3Rlci1JRCBpbiBjYXNlIGEgc3lzdGVtIGNvdWxkIGhh
dmUgMiBpZGVudGljYWwgTWFzdGVyLUlEIGJ1dA0KPj4gZWFjaCBvbmUgY29ubmVjdGVkIHRvIGEg
ZGlmZmVyZW50IFNNTVUgYW5kIGFzc2lnbmVkIHRvIHRoZSBndWVzdC4NCj4gDQo+IEkgdGhpbmsg
dGhlIHByb3Bvc2VkIHNvbHV0aW9uIHdvdWxkIHdvcmsgYW5kIEkgd291bGQganVzdCBsaWtlIHRv
IGNsZWFyIHNvbWUgaXNzdWVzLg0KPiANCj4gUGxlYXNlIGNvcnJlY3QgbWUgaWYgSSdtIHdyb25n
Og0KPiANCj4gSW4gdGhlIHhsIGNvbmZpZyBmaWxlIHdlIGFscmVhZHkgbmVlZCB0byBzcGVjaWZ5
IGR0ZGV2IHRvIHBvaW50IHRvIHRoZSBkZXZpY2UgcGF0aCBpbiBob3N0IGR0Yi4NCj4gSW4gdGhl
IHBhcnRpYWwgZGV2aWNlIHRyZWUgd2Ugc3BlY2lmeSB0aGUgdk1hc3RlcklkIGFzIHdlbGwgYXMg
bWFnaWMgcGhhbmRsZS4NCj4gSXNuJ3QgaXQgdGhhdCB3ZSBhbHJlYWR5IGhhdmUgYWxsIHRoZSBp
bmZvcm1hdGlvbiBuZWNlc3Nhcnkgd2l0aG91dCB0aGUgbmVlZCBmb3IgaW9tbXVfZGV2aWRfbWFw
Pw0KPiBGb3IgbWUgaXQgbG9va3MgbGlrZSB0aGUgcGFydGlhbCBkdGIgcHJvdmlkZXMgdk1hc3Rl
cklEIGFuZCBkdGRldiBwcm92aWRlcyBwTWFzdGVySUQgYXMgd2VsbCBhcyBwaHlzaWNhbCBwaGFu
ZGxlIHRvIFNNTVUuDQo+IA0KPiBIYXZpbmcgc2FpZCB0aGF0LCBJIGNhbiBhbHNvIHVuZGVyc3Rh
bmQgdGhhdCBzcGVjaWZ5aW5nIGV2ZXJ5dGhpbmcgaW4gb25lIHBsYWNlIHVzaW5nIGlvbW11X2Rl
dmlkX21hcCBjYW4gYmUgZWFzaWVyDQo+IGFuZCByZWR1Y2VzIHRoZSBuZWVkIGZvciBkZXZpY2Ug
dHJlZSBwYXJzaW5nLg0KPiANCj4gQXBhcnQgZnJvbSB0aGF0LCB3aGF0IGlzIHRoZSByZWFzb24g
b2YgZXhwb3Npbmcgb25seSBvbmUgdlNNTVUgdG8gZ3Vlc3QgaW5zdGVhZCBvZiBvbmUgdlNNTVUg
cGVyIHBTTU1VPw0KPiBJbiB0aGUgbGF0dGVyIHNvbHV0aW9uLCB0aGUgd2hvbGUgaXNzdWUgd2l0
aCBoYW5kbGluZyBkZXZpY2VzIHdpdGggdGhlIHNhbWUgc3RyZWFtIElEIGJ1dCBiZWxvbmdpbmcg
dG8gZGlmZmVyZW50IFNNTVVzDQo+IHdvdWxkIGJlIGdvbmUuIEl0IHdvdWxkIGFsc28gcmVzdWx0
IGluIGEgbW9yZSBuYXR1cmFsIHdheSBvZiB0aGUgZGV2aWNlIHRyZWUgbG9vay4gTm9ybWFsbHkg
YSBndWVzdCB3b3VsZCBzZWUNCj4gZS5nLiBib3RoIFNNTVVzIGFuZCBleHBvc2luZyBvbmx5IG9u
ZSBjYW4gYmUgbWlzbGVhZGluZy4NCg0KUGxlYXNlIHNlZSB0aGUgb3RoZXIgZW1haWwgdGhhdCBJ
IHJlcGxpZWQgdG8gSnVsaWVuIHRvIGtub3cgdGhlIGFuc3dlciB0byB0aGUgYWJvdmUgcXVlc3Rp
b24uDQoNClJlZ2FyZHMsDQpSYWh1bA==


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 16:14:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 16:14:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431109.683669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5W8-0002v8-S3; Thu, 27 Oct 2022 16:14:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431109.683669; Thu, 27 Oct 2022 16:14:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5W8-0002v1-Ot; Thu, 27 Oct 2022 16:14:04 +0000
Received: by outflank-mailman (input) for mailman id 431109;
 Thu, 27 Oct 2022 16:14:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oo5W7-0002uv-Gf
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 16:14:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo5W6-0006ut-Qs; Thu, 27 Oct 2022 16:14:02 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.29.62]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo5W6-0001sC-J8; Thu, 27 Oct 2022 16:14:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=p6FcUrUAjFlgLyeMzrQKMRmJMrda8ARnEbFOy76cSkI=; b=s7oCLHpYdehkH6iOmAMKTpsocq
	TYChheapaq9EjTGjRnE24IPhaHwam7PAvxHn6eDq1JOHqit7A0GMNsvhlM3EegcDsIMtI7cbHG3iu
	zc8dbVTPCwv/oLfvVOKwUtnYzVVwOl8fFfNrfmo9gFb1Gr1LhjxuSBKgZ6VNmEk4pvK8=;
Message-ID: <d9779975-9b47-bc3f-7cb0-508165ebc707@xen.org>
Date: Thu, 27 Oct 2022 17:13:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>,
 Andre Przywara <andre.przywara@arm.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 Henry.Wang@arm.com
References: <20221026183004.7293-1-ayankuma@amd.com>
 <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
 <da52b703-5de7-1673-f6a1-d6541f59f5cd@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <da52b703-5de7-1673-f6a1-d6541f59f5cd@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 27/10/2022 16:40, Ayan Kumar Halder wrote:
> 
> On 27/10/2022 10:44, Andre Przywara wrote:
>> On Wed, 26 Oct 2022 19:30:04 +0100
>> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>
>> Hi,
> 
> Hi Andre,

Hi,

> I need a clarification.

I am not Andre but will answer :).

[...]

>>>           /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>>>           if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>>>           {
>>> -            reg = v->arch.vgic.rdist_pendbase;
>>> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>>>               vreg_reg64_update(&reg, r, info);
>>>               reg = sanitize_pendbaser(reg);
>>> -            v->arch.vgic.rdist_pendbase = reg;
>>> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>>>           }
>>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> 
> Shouldn't this be "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" ?

Good catch. Yes it does. The current code will clear DAIF (even if 
irqsave touch only I). The I/O emulation is done with interrupts enabled 
usually, so now they are going to be unhandled until 
leave_hypervisor_to_guest().

This could be a "very" long time. Thankfully ITS is experimental, 
otherwise I would have considered this a potential security issue.

Can you send a separate patch for that?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 16:19:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 16:19:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431112.683679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5bK-0003p5-FG; Thu, 27 Oct 2022 16:19:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431112.683679; Thu, 27 Oct 2022 16:19:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5bK-0003oy-Cl; Thu, 27 Oct 2022 16:19:26 +0000
Received: by outflank-mailman (input) for mailman id 431112;
 Thu, 27 Oct 2022 16:19:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yXv3=24=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1oo5bI-0003os-Jj
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 16:19:24 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 1dffe430-5613-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 18:19:23 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67ACF23A;
 Thu, 27 Oct 2022 09:19:28 -0700 (PDT)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0BEA43F7B4;
 Thu, 27 Oct 2022 09:19:20 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1dffe430-5613-11ed-8fd0-01056ac49cbb
Date: Thu, 27 Oct 2022 17:19:18 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Henry.Wang@arm.com
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
Message-ID: <20221027171918.30b2b61b@donnerap.cambridge.arm.com>
In-Reply-To: <da52b703-5de7-1673-f6a1-d6541f59f5cd@amd.com>
References: <20221026183004.7293-1-ayankuma@amd.com>
	<20221027104231.77c5cd28@donnerap.cambridge.arm.com>
	<da52b703-5de7-1673-f6a1-d6541f59f5cd@amd.com>
Organization: ARM
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 27 Oct 2022 16:40:01 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi Ayan,

> On 27/10/2022 10:44, Andre Przywara wrote:
> > On Wed, 26 Oct 2022 19:30:04 +0100
> > Ayan Kumar Halder <ayankuma@amd.com> wrote:
> >
> > Hi,  
> 
> Hi Andre,
> 
> I need a clarification.
> 
> >  
> >> If a guest is running in 32 bit mode and it tries to access
> >> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> >> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> >> This will be stored in a 64bit cpu register.
> >> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
> >> in the lower 32 bits of the 64bit cpu register.
> >>
> >> This 64bit cpu register is then modified bitwise with a mask (ie
> >> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
> >> 64 bit cpu register) is not cleared as expected by the specification.
> >>
> >> The correct thing to do here is to store the value of
> >> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> >> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> >> vreg_reg64_extract() which will extract 32 bits from the given offset.
> >>
> >> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
> >> v->arch.vgic.rdist_pendbase. The reason being v->arch.vgic.rdist_pendbase is
> >> now being read/written in an atomic manner (using read_atomic()/write_atomic()).
> >>
> >> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> >> Release-acked-by: Henry Wang <Henry.Wang@arm.com>
> >> ---
> >>
> >> Changes from:-
> >>
> >> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> >> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> >> appropriate commit message.
> >>
> >> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
> >> v->arch.vgic.rdist_pendbase in an atomic context.
> >> 2. Rectified the commit message to state that the cpu register is 64 bit.
> >> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
> >> clear.
> >>
> >> v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
> >> in __vgic_v3_rdistr_rd_mmio_write().
> >>
> >>   xen/arch/arm/vgic-v3.c | 19 ++++++-------------
> >>   1 file changed, 6 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> >> index 0c23f6df9d..1adbdc0e54 100644
> >> --- a/xen/arch/arm/vgic-v3.c
> >> +++ b/xen/arch/arm/vgic-v3.c
> >> @@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
> >>   
> >>       case VREG64(GICR_PENDBASER):
> >>       {
> >> -        unsigned long flags;
> >> +        uint64_t val;
> >>   
> >>           if ( !v->domain->arch.vgic.has_its )
> >>               goto read_as_zero_64;
> >>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
> >>   
> >> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> >> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> >> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> >> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
> >> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
> >> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> >> +        *r = vreg_reg64_extract(val, info);  
> > That part looks fine now.
> >  
> >>           return 1;
> >>       }
> >>   
> >> @@ -566,25 +565,19 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
> >>   
> >>       case VREG64(GICR_PENDBASER):
> >>       {
> >> -        unsigned long flags;
> >> -
> >>           if ( !v->domain->arch.vgic.has_its )
> >>               goto write_ignore_64;
> >>           if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
> >>   
> >> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> >> -  
> > I don't think you can drop the lock here easily. If it would be just for
> > the LPIs enabled check, that'd be fine, because you can never turn LPIs off
> > again (but that would deserve an explicit comment then).
> >
> > But down below you do a read-modify-write operation of rdist_pendbase, and
> > need to make sure no one else is attempting that at the same time.
> >
> > Cheers,
> > Andre
> >  
> >>           /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
> >>           if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
> >>           {
> >> -            reg = v->arch.vgic.rdist_pendbase;
> >> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
> >>               vreg_reg64_update(&reg, r, info);
> >>               reg = sanitize_pendbaser(reg);
> >> -            v->arch.vgic.rdist_pendbase = reg;
> >> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
> >>           }
> >>   
> >> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);  
> 
> Shouldn't this be "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" ?

Ouch, indeed, looks like a typo!
There is a some type check in spin_lock_irqsave() and local_irq_restore(),
but not in spin_unlock_irqrestore(), so we missed that.

Cheers,
Andre

> 
> - Ayan
> 
> >> -
> >>           return 1;
> >>       }
> >>     



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 16:33:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 16:33:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431119.683691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5ou-0006bB-UH; Thu, 27 Oct 2022 16:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431119.683691; Thu, 27 Oct 2022 16:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo5ou-0006b4-Pb; Thu, 27 Oct 2022 16:33:28 +0000
Received: by outflank-mailman (input) for mailman id 431119;
 Thu, 27 Oct 2022 16:33:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1oo5ot-0006ak-Hp
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 16:33:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo5ot-0007Fb-1W; Thu, 27 Oct 2022 16:33:27 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.29.62]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1oo5os-0002aP-MM; Thu, 27 Oct 2022 16:33:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=BhvQCRl6DBL5657TGVv13HCXvgJ4eyODUMfIpHIaJ60=; b=IeaRjM1AV7wyqoXcOALdKhTOes
	PCni/teNZITvwZ6kyRFvICvDPxuU/lvxiL9aH/UgU6BFORb8NkaZseGcId3x24i7pkdOF+ASaYImx
	e/pFrzSL0UqyqNGRrKTXh5ZfJlURaTht614SIMjr+FVkRSE6q6qCzMyEBRkOqlIOKVYg=;
Message-ID: <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
Date: Thu, 27 Oct 2022 17:33:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 27/10/2022 17:08, Rahul Singh wrote:
> Hi Julien,

Hi Rahul,

>> On 26 Oct 2022, at 8:48 pm, Julien Grall <julien@xen.org> wrote:
>>
>>
>>
>> On 26/10/2022 15:33, Rahul Singh wrote:
>>> Hi Julien,
>>
>> Hi Rahul,
>>
>>>> On 26 Oct 2022, at 2:36 pm, Julien Grall <julien@xen.org> wrote:
>>>>
>>>>
>>>>
>>>> On 26/10/2022 14:17, Rahul Singh wrote:
>>>>> Hi All,
>>>>
>>>> Hi Rahul,
>>>>
>>>>> At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3.
>>>>> To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the
>>>>> device to the guest that is behind an IOMMU and virtual IOMMU is enabled for the guest there is a need to
>>>>> add IOMMU binding for the device in the passthrough node as per [1]. This email is to get an agreement on
>>>>> how to add the IOMMU binding for guest OS.
>>>>> Before I will explain how to add the IOMMU binding let me give a brief overview of how we will add support for virtual
>>>>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 Nested translation support. SMMUv3 hardware
>>>>> supports two stages of translation. Each stage of translation can be independently enabled. An incoming address is logically
>>>>> translated from VA to IPA in stage 1, then the IPA is input to stage 2 which translates the IPA to the output PA. Stage 1 is
>>>>> intended to be used by a software entity( Guest OS) to provide isolation or translation to buffers within the entity, for example,
>>>>> DMA isolation within an OS. Stage 2 is intended to be available in systems supporting the Virtualization Extensions and is
>>>>> intended to virtualize device DMA to guest VM address spaces. When both stage 1 and stage 2 are enabled, the translation
>>>>> configuration is called nesting.
>>>>> Stage 1 translation support is required to provide isolation between different devices within the guest OS. XEN already supports
>>>>> Stage 2 translation but there is no support for Stage 1 translation for guests. We will add support for guests to configure
>>>>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU hardware and exposes the virtual SMMU to the guest.
>>>>> Guest can use the native SMMU driver to configure the stage 1 translation. When the guest configures the SMMU for Stage 1,
>>>>> XEN will trap the access and configure the hardware accordingly.
>>>>> Now back to the question of how we can add the IOMMU binding between the virtual IOMMU and the master devices so that
>>>>> guests can configure the IOMMU correctly. The solution that I am suggesting is as below:
>>>>> For dom0, while handling the DT node(handle_node()) Xen will replace the phandle in the "iommus" property with the virtual
>>>>> IOMMU node phandle.
>>>> Below, you said that each IOMMUs may have a different ID space. So shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the user to specify the mapping?
>>> Yes you are right we need to create one vIOMMU per pIOMMU for dom0. This also helps in the ACPI case
>>> where we don’t need to modify the tables to delete the pIOMMU entries and create one vIOMMU.
>>> In this case, no need to replace the phandle as Xen create the vIOMMU with the same pIOMMU
>>> phandle and same base address.
>>> For domU guests one vIOMMU per guest will be created.
>>
>> IIRC, the SMMUv3 is using a ring like the GICv3 ITS. I think we need to be open here because this may end up to be tricky to security support it (we have N guest ring that can write to M host ring).
> 
> If xl want to creates the one vIOMMU per pIOMMU for domU then xl needs to know the below information:
>   -  Find the number of holes in guest memory same as the number of vIOMMU that needs the creation to create the vIOMMU DT nodes. (Think about a big system that has 50+ IOMMUs)
>      Yes, we will create vIOMMU for only those devices that are assigned to guests but still we need to find the hole in guest memory.

I agree this is a problem with the one vIOMMU per pIOMMU.

>   -  Find the pIOMMU attached to the assigned device and create mapping b/w vIOMMU -> pIOMMU to register the MMIO handler.
>      Either we need to modify the current hyerpcall or need to implement a new hypercall to find this information.

Adding hypercalls are is not a big problem.

> 
> Because of the above reason I thought of creating one vIOMMU for domU. Yes you are right this may end up to be tricky to security support
> but as per my understanding one vIOMMU  per domU guest is easy to implement and simple to handle as compared to one vIOMMU per pIOMMU

I am not sure about this. My gut feeling is the code in Xen will end up 
to be tricky (there more that Xen doesn't support preemption). So I 
think we will trade-off complexity in Xen over simplicity in libxl.

That said, I haven't looked deeper in the code. So I may be wrong. I 
will need to see the code to confirm.

>>>>> For domU guests, when passthrough the device to the guest as per [2],  add the below property in the partial device tree
>>>>> node that is required to describe the generic device tree binding for IOMMUs and their master(s)
>>>>> "iommus = < &magic_phandle 0xvMasterID>
>>>>> 	• magic_phandle will be the phandle ( vIOMMU phandle in xl)  that will be documented so that the user can set that in partial DT node (0xfdea).
>>>>
>>>> Does this mean only one IOMMU will be supported in the guest?
>>> Yes.
>>>>
>>>>> 	• vMasterID will be the virtual master ID that the user will provide.
>>>>> The partial device tree will look like this:
>>>>> /dts-v1/;
>>>>>   / {
>>>>>      /* #*cells are here to keep DTC happy */
>>>>>      #address-cells = <2>;
>>>>>      #size-cells = <2>;
>>>>>        aliases {
>>>>>          net = &mac0;
>>>>>      };
>>>>>        passthrough {
>>>>>          compatible = "simple-bus";
>>>>>          ranges;
>>>>>          #address-cells = <2>;
>>>>>          #size-cells = <2>;
>>>>>          mac0: ethernet@10000000 {
>>>>>              compatible = "calxeda,hb-xgmac";
>>>>>              reg = <0 0x10000000 0 0x1000>;
>>>>>              interrupts = <0 80 4  0 81 4  0 82 4>;
>>>>>             iommus = <0xfdea 0x01>;
>>>>>          };
>>>>>      };
>>>>> };
>>>>>   In xl.cfg we need to define a new option to inform Xen about vMasterId to pMasterId mapping and to which IOMMU device this
>>>>> the master device is connected so that Xen can configure the right IOMMU. This is required if the system has devices that have
>>>>> the same master ID but behind a different IOMMU.
>>>>
>>>> In xl.cfg, we already pass the device-tree node path to passthrough. So Xen should already have all the information about the IOMMU and Master-ID. So it doesn't seem necessary for Device-Tree.
>>>>
>>>> For ACPI, I would have expected the information to be found in the IOREQ.
>>>>
>>>> So can you add more context why this is necessary for everyone?
>>> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
>>
>> I am confused. Below, you are making the virtual master ID optional. So shouldn't this be mandatory if you really need the mapping with the virtual ID?
> 
> vMasterID is optional if user knows pMasterID is unique on the system. But if pMasterId is not unique then user needs to provide the vMasterID.

So the expectation is the user will be able to know that the pMasterID 
is uniq. This may be easy with a couple of SMMUs, but if you have 50+ 
(as suggested above). This will become a pain on larger system.

IHMO, it would be much better if we can detect that in libxl (see below).

> 
>>
>>> The device tree node will be used to assign the device to the guest and configure the Stage-2 translation. Guest will use the
>>> vMaster-ID to configure the vIOMMU during boot. Xen needs information to link vMaster-ID to pMaster-ID to configure
>>> the corresponding pIOMMU. As I mention we need vMaster-ID in case a system could have 2 identical Master-ID but
>>> each one connected to a different SMMU and assigned to the guest.
>>
>> I am afraid I still don't understand why this is a requirement. Libxl could have enough knowledge (which will be necessarry for the PCI case) to know the IOMMU and pMasterID associated with a device.
>>
>> So libxl could allocate the vMasterID, tell Xen the corresponding mapping and update the device-tree.
>>
>> IOW, it doesn't seem to be necessary to involve the user in the process here.
> 
> Yes, libxl could allocate the vMasterID but there is no way we can find the link b/w vMasterID created to pMasterID from dtdev.
> 
> What I understand from the code is that there is no link between the passthrough node and dtdev config option. The passthrough
> node is directly copied to guest DT without any modification. Dtdev is used to add and assign the device to IOMMU.
> 
> Let's take an example if the user wants to assign two devices to the guest via passthrough node.
> 
> /dts-v1/;
> 
> / {
>     /* #*cells are here to keep DTC happy */
>     #address-cells = <2>;
>     #size-cells = <2>;
> 
>     aliases {
>         net = &mac0;
>     };
> 
>     passthrough {
>         compatible = "simple-bus";
>         ranges;
>         #address-cells = <2>;
>         #size-cells = <2>;
> 
>         mac0: ethernet@10000000 {
>             compatible = "calxeda,hb-xgmac";
>             reg = <0 0x10000000 0 0x1000>;
>             interrupts = <0 80 4  0 81 4  0 82 4>;
>         };
> 
>       mac1: ethernet@20000000 {
>             compatible = “r8169";
>             reg = <0 0x10000000 0 0x1000>;
>             interrupts = <0 80 4  0 81 4  0 82 4>;
>         };
> 
>     };
> };
> 
> dtdev = [ "/soc/ethernet@10000000”, “/soc/ethernet@f2000000” ]
> 
> There is no link which dtdev entry belongs to which node. Therefor there is no way to link the vMasterID created to pMasterID.

I agree there is no link today. But we could add a property in the 
partial device-tree to mention which physical device is associated.

With that, I think all, the complexity is moved to libxl and it will be 
easier for the user to use vIOMMU.

[...]

>>>>>   iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
>>>>> 	• PMASTER_ID is the physical master ID of the device from the physical DT.
>>>>> 	• VMASTER_ID is the virtual master Id that the user will configure in the partial device tree.
>>>>> 	• IOMMU_BASE_ADDRESS is the base address of the physical IOMMU device to which this device is connected.
>>>>
>>>> Below you give an example for Platform device. How would that fit in the context of PCI passthrough?
>>> In PCI passthrough case, xl will create the "iommu-map" property in vpci host bridge node with phandle to vIOMMU node.
>>> vSMMUv3 node will be created in xl.
>>
>> This means that libxl will need to know the associated pMasterID to a PCI device. So, I don't understand why you can't do the same for platform devices.
> 
> For the PCI passthrough case, we don’t need to provide the MasterID to create "iommu-map” property as for
> PCI device MasterID is RID ( BDF ). For non-PCI devices, MasterID is required to create “iommus” property.

Are you talking about the physical MasterID or virtual one? If physical 
MasterID then I don't think this is always the RID (see [1]). But for 
the virtual Master ID we could make this association.

This still means that in some way the toolstack need to let Xen know (or 
the other way around) the mapping between the pMasterID and vMasterID.

[1] Documentation/devicetree/bindings/pci/pci-iommu.txt.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 16:49:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 16:49:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431124.683708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo64T-0000Dh-7b; Thu, 27 Oct 2022 16:49:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431124.683708; Thu, 27 Oct 2022 16:49:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo64T-0000Da-4r; Thu, 27 Oct 2022 16:49:33 +0000
Received: by outflank-mailman (input) for mailman id 431124;
 Thu, 27 Oct 2022 16:49:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WPLX=24=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1oo64S-0000DB-3A
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 16:49:32 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 534a560e-5617-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 18:49:30 +0200 (CEST)
Received: from DU2PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:10:3b::34)
 by DB9PR08MB8508.eurprd08.prod.outlook.com (2603:10a6:10:3d3::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Thu, 27 Oct
 2022 16:49:15 +0000
Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:3b:cafe::68) by DU2PR04CA0029.outlook.office365.com
 (2603:10a6:10:3b::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend
 Transport; Thu, 27 Oct 2022 16:49:15 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Thu, 27 Oct 2022 16:49:14 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Thu, 27 Oct 2022 16:49:14 +0000
Received: from 493c99339084.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4950A7EB-047A-4B1E-9C84-E7A214DA33A4.1; 
 Thu, 27 Oct 2022 16:49:02 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 493c99339084.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 27 Oct 2022 16:49:02 +0000
Received: from PAXPR08MB7154.eurprd08.prod.outlook.com (2603:10a6:102:207::17)
 by AS8PR08MB8947.eurprd08.prod.outlook.com (2603:10a6:20b:5b3::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct
 2022 16:49:01 +0000
Received: from PAXPR08MB7154.eurprd08.prod.outlook.com
 ([fe80::b153:7b24:56fe:7402]) by PAXPR08MB7154.eurprd08.prod.outlook.com
 ([fe80::b153:7b24:56fe:7402%6]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 16:49:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 534a560e-5617-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Fb+5hIV0J/4Q79F8kDy8nw2lG5v5anJgPjNzKQi1JUmYh4Azqra1PPiaWGRTOl4UYlXYbEfoXipYWaym5gHKAcdIa1U3oa5MqPJZPnoRTZVfyH3puO1vcL7l/SP4CU2NMNAqaxgXpT31AkvweLUmEpFe4ePoJKp1B7xYgkGfWzK/y+QWm6S3xKZVp+lb6qLTJPEe1vVyPrp9+NSDY/FeA1aDwNCcPHB9b7Int13YXpTUgV0Gs9T0i+lpFhsaaG2OczVV3jGAm9UiWcchwvzIKpFSjVDb/uU99mkS3PmD7dkhyTFhQiTm+7dg3tj4eNH8ST0tBPFnDx8T8f7SKM5Ofg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VsXxt9BPvBoNXS9lvAlq9KJoZCP3OSs/60IriDXaNis=;
 b=ltmsvt7jGzlSFnLx8vHsE/OYLzPD8e74YHmvJaNBZIoIgYo1ngWLlLjyVffcKaHOqvKEWwUTjOy2t1HEia4GaW6kCdgyrdOSIVk/i5/rUdTUJ/nXuqnAI+I94p42RQnAau3Z5s4+KC1qodzIqyTzvJx6pIDmvzOEiw8N1J/9bVjYuy1LFYlYDAm3w3v5EnqvjwgRRhEbQ9hQnEdd5YXDRPiDszmF627ED8aWx9f0NRqowivtWlAZe8yIS4Grudk3w6GEgJrxwyAHZo/rvG/af6ys5NYe0r2ql45VqApdBF+0wVwAmskT/eNBdccBd6bSxwa5hhuaO0V6kzZ5HRfe3Q==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VsXxt9BPvBoNXS9lvAlq9KJoZCP3OSs/60IriDXaNis=;
 b=BTjg6GAc9IRy0sLqmIMmsE/VCIx8VAsGVJ02PHDxMWKYe+aBXEop+X5/iSZtdKWMMa8T9he+1Ck5ax48xHppH+yuX1bp3fWG0IoXMgvQU2SrGB/r9GtnL95Ac4nXmGLcK6jBeCpt7ncHEmYe+scz9irk2LlhY7vLVZDxwMdBAqs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6c74bb4eaea8dd4a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aIoe6Dv32W1FpNv2ZRu8Vn01NJPqUxXenwzpO9mqVA5MYzJbGCpK1sOsCn52a/q/LJ7xYhm/oW9OnHhRveH7+sKaXtAA8qySiLbuasLQKvCcNCHXmYd2DHSfUYIKx41B1ceL/Gx40Sk3H06uyAOYm8Tog6toQzclq0hRuAUsJ8z+4uey5APFMrdVfVwb6pTTNKhYLGdZoKCJIFhbNV0m3IeWw20v15YthKO0+DTs5TVRIYCfUMnFLfKi3J5dCclffF5/n8E+YYMYr2ch0GZ+B4FFk1ckzQrZp4282RvPB95Wu/tbTv4Qdjel1PAOQPNsdDakxwrPt2waFqxtaDRjRw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VsXxt9BPvBoNXS9lvAlq9KJoZCP3OSs/60IriDXaNis=;
 b=SXr9o6RNs7NEqBm4qMqjzhdNsdLfYlrXaMd8tLVtILRpjrpa9kBVQ6M2XySj6/Ow7zFdoLqMZ9g6FPx74l3WCtLFKc2dqSmn47WhfmkcgGrPI737s4SEcZMxHOKf5bOK1TlKymaTm30N/VzoCCrhxLgOBb46yNUFNXgZFBmgJQIssj5paBuxXVJlfptmVjNxHKQI6/SfwA7jXMlGMwmDs+O/SdwAm7JlkzECbbelgzY1X5WpK2q2MuKaajhdFkD/OuHB+v+pSqHHTGxI1fv0WZr1UmLtoBChNkZ/mhZqgOmHmZhk5S7RVMztezGYF2+zZ+BdiXayWyE7of894BOlVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VsXxt9BPvBoNXS9lvAlq9KJoZCP3OSs/60IriDXaNis=;
 b=BTjg6GAc9IRy0sLqmIMmsE/VCIx8VAsGVJ02PHDxMWKYe+aBXEop+X5/iSZtdKWMMa8T9he+1Ck5ax48xHppH+yuX1bp3fWG0IoXMgvQU2SrGB/r9GtnL95Ac4nXmGLcK6jBeCpt7ncHEmYe+scz9irk2LlhY7vLVZDxwMdBAqs=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: Michal Orzel <michal.orzel@amd.com>, Julien Grall <julien@xen.org>, Xen
 developer discussion <xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, Michal
 Orzel <Michal.Orzel@arm.com>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index: AQHY6T1VjOHHQJGN7kyXeL6pAIKNMa4grXIAgAAQBQCAAC3DgIAAEkaAgAF4CwA=
Date: Thu, 27 Oct 2022 16:49:01 +0000
Message-ID: <60B7173E-65B4-4859-8F14-5CA34368640E@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
 <CAPD2p-=PSahQR0JWe3tLEtp0-iiNH=yE96_GxNyDbhSw-fod0w@mail.gmail.com>
In-Reply-To:
 <CAPD2p-=PSahQR0JWe3tLEtp0-iiNH=yE96_GxNyDbhSw-fod0w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	PAXPR08MB7154:EE_|AS8PR08MB8947:EE_|DBAEUR03FT062:EE_|DB9PR08MB8508:EE_
X-MS-Office365-Filtering-Correlation-Id: f5b51693-e282-498b-7522-08dab83b2e8b
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6Z7jHIFy/VMYsc7T4EGsEplwZ4utQmBXiHrR6oaT1/wUw0AmFAdL1bvrp/9vmdWc3dJ2XnuJy4RPMInnQ7RTNgoRJA5/qwyjSCSpq5Oepd1s5RkKROY0Lvk/974/S5MNM6pDdR15g7t+nxmP2ydPYkwkuerxyz2DHQeG5Y+w0W2Kohn3UKkv8O90E8rPVMlYMyQNiC2SmgL/iR7U7J80CQaJ03EHpzVKKJB0RKvvF9MneImIRTwDnFya+j/afdwJdLvDhMmbfKbEFUiF6E+lVbwHY87/FmSBkNuLjLDTssZYJpC0qMvceQ+BQFS/LkySCkQb3IP24vTiADCpGSie+UM3AYn7UhimnmhLarZUMzk5fWpoDxtzWjSrLFG2Ob6sUuizLiRwKd/ScFQoKG947qRypQA2I7zktO4+Hv2dR/vm+cwkHwOJw0JwT8regtuoT1z2yWr8fujeg7iDyB17AqOSm9rOzucLa4KXLI5IOLnQPiivLJ41u9zdEmQFJrIdfgKQSO/tIwqW1Fq2yrgyb7Tor8j/PA+vKVbC/9PSDDQ8s3FW4HhilSUw0jLPLbpD2tbhgBCQuP/6dJQnaHhLowaGgaM6TFCW+eobZwf8E8v3ZeqnIyM45y5jPwF1L97jYC6lSDR1T6DFqPhOs1H0ZLTcUI8nH5p00WSjkWAzzgS00pzo40AjvPlZn6hJ36fLPacM9vkMUcpd4uC8svtdV/mNyctQDsZwPGbyj85GiIcK/2TimXaAskJ5RnY/M5imUawReC25ZKj/WaYCGPatBkkOXh1eXJlZu1il8iv5FoI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7154.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(39860400002)(396003)(366004)(346002)(451199015)(8676002)(33656002)(71200400001)(83380400001)(76116006)(91956017)(4326008)(6486002)(478600001)(38070700005)(2906002)(316002)(36756003)(6512007)(8936002)(86362001)(6916009)(41300700001)(38100700002)(54906003)(26005)(122000001)(2616005)(7416002)(5660300002)(6506007)(186003)(53546011)(66476007)(66946007)(64756008)(66556008)(66446008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <011962D59A2DD741B7EBB9406EF28A17@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8947
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	28d3bf3d-973a-47b0-2d5b-08dab83b2644
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X2+0NipXcyEVofXoXU7T8IAyQe/xnULq/AYnWiT72odmhQqkumWWPQPM+3pILjvJ6o1xwdTUnwKg2wAQxHUY+DfDfLVu90h99VWd46wV0XPWU/gUoZNG5G1qmwAklG34Z5lcLB3N++zZOJpyR0Ve0R9H6Fp8cG1N1EJhj0QqhKNNqeQ7nsFqvF1CYQEJIVtnKc8fxj5Q8UZf0kipsJxvWTM5tMR2NynDrdf4pIfUJWXay4pocOy6MDUlFPy/Y9vSX4MfYCZuTOrAvjeUb/WPIEPCZhcb4FRc0Ip1hbEekYiEYZlILqYCn1pY7WLY+cmV4z88E+FMc0OD0atMwljilH7ZQKMmmFROINwTHAGyXOPUChZVO0zvnQsvLVOzY0skUnjRi4HIJ//Os0HMncI8BVHAYxULqUVNsfT03POFJB6ZgbM+8kmAAyaghbLs42Zp1W5sy7dJ5n+Uu9W5HrXUZcLDkb6CpGc+RvMWvJcO90uct4QHTOpcLIXiZOnWNP5b5ZUvk2ZywcyvBcdv4hF5GCA6aVIorrc3UQNL2J/RkDxmt5GCiwS1luIbAssf/u5Ul15WX/fRgP3yv1PTAE2czgn7y7QCntBvHfMhEJwsDO0uCWm4OS6sWYF9d74fASYAY9ascsufwZGb4W2U/kzF6bwxlTzP/3inonxJNraYBfl6xcRUbC/4rq1FOe9+VD/YdWGbzFFLjtn9IjoAk2YcBo7CeghjGkFHyD+FgUu3GGjee8+J04E/6BsqiwoAZBLKiDwf4UsOmOFAv9UKGYzmwA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(36756003)(81166007)(8936002)(5660300002)(70206006)(70586007)(47076005)(83380400001)(8676002)(6862004)(33656002)(36860700001)(86362001)(82740400003)(40480700001)(316002)(54906003)(186003)(356005)(53546011)(26005)(107886003)(2616005)(336012)(6512007)(6486002)(478600001)(6506007)(82310400005)(41300700001)(4326008)(40460700003)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 16:49:14.9819
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f5b51693-e282-498b-7522-08dab83b2e8b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8508

SGkgT2xla3NhbmRyLA0KDQo+IE9uIDI2IE9jdCAyMDIyLCBhdCA3OjIzIHBtLCBPbGVrc2FuZHIg
VHlzaGNoZW5rbyA8b2xla3N0eXNoQGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9u
IFdlZCwgT2N0IDI2LCAyMDIyIGF0IDg6MTggUE0gTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxA
YW1kLmNvbT4gd3JvdGU6DQo+IEhpIFJhaHVsLA0KPiAgDQo+IA0KPiBIZWxsbyBhbGwNCj4gDQo+
IFtzb3JyeSBmb3IgdGhlIHBvc3NpYmxlIGZvcm1hdCBpc3N1ZXNdDQo+ICANCj4gDQo+IE9uIDI2
LzEwLzIwMjIgMTY6MzMsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPiA+IA0KPiA+IA0KPiA+IEhpIEp1
bGllbiwNCj4gPiANCj4gPj4gT24gMjYgT2N0IDIwMjIsIGF0IDI6MzYgcG0sIEp1bGllbiBHcmFs
bCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiA+Pg0KPiA+Pg0KPiA+Pg0KPiA+PiBPbiAyNi8x
MC8yMDIyIDE0OjE3LCBSYWh1bCBTaW5naCB3cm90ZToNCj4gPj4+IEhpIEFsbCwNCj4gPj4NCj4g
Pj4gSGkgUmFodWwsDQo+ID4+DQo+ID4+PiBBdCBBcm0sIHdlIHN0YXJ0ZWQgdG8gaW1wbGVtZW50
IHRoZSBQT0MgdG8gc3VwcG9ydCAyIGxldmVscyBvZiBwYWdlIHRhYmxlcy9uZXN0ZWQgdHJhbnNs
YXRpb24gaW4gU01NVXYzLg0KPiA+Pj4gVG8gc3VwcG9ydCBuZXN0ZWQgdHJhbnNsYXRpb24gZm9y
IGd1ZXN0IE9TIFhlbiBuZWVkcyB0byBleHBvc2UgdGhlIHZpcnR1YWwgSU9NTVUuIElmIHdlIHBh
c3N0aHJvdWdoIHRoZQ0KPiA+Pj4gZGV2aWNlIHRvIHRoZSBndWVzdCB0aGF0IGlzIGJlaGluZCBh
biBJT01NVSBhbmQgdmlydHVhbCBJT01NVSBpcyBlbmFibGVkIGZvciB0aGUgZ3Vlc3QgdGhlcmUg
aXMgYSBuZWVkIHRvDQo+ID4+PiBhZGQgSU9NTVUgYmluZGluZyBmb3IgdGhlIGRldmljZSBpbiB0
aGUgcGFzc3Rocm91Z2ggbm9kZSBhcyBwZXIgWzFdLiBUaGlzIGVtYWlsIGlzIHRvIGdldCBhbiBh
Z3JlZW1lbnQgb24NCj4gPj4+IGhvdyB0byBhZGQgdGhlIElPTU1VIGJpbmRpbmcgZm9yIGd1ZXN0
IE9TLg0KPiA+Pj4gQmVmb3JlIEkgd2lsbCBleHBsYWluIGhvdyB0byBhZGQgdGhlIElPTU1VIGJp
bmRpbmcgbGV0IG1lIGdpdmUgYSBicmllZiBvdmVydmlldyBvZiBob3cgd2Ugd2lsbCBhZGQgc3Vw
cG9ydCBmb3IgdmlydHVhbA0KPiA+Pj4gSU9NTVUgb24gQXJtLiBJbiBvcmRlciB0byBpbXBsZW1l
bnQgdmlydHVhbCBJT01NVSBYZW4gbmVlZCBTTU1VdjMgTmVzdGVkIHRyYW5zbGF0aW9uIHN1cHBv
cnQuIFNNTVV2MyBoYXJkd2FyZQ0KPiA+Pj4gc3VwcG9ydHMgdHdvIHN0YWdlcyBvZiB0cmFuc2xh
dGlvbi4gRWFjaCBzdGFnZSBvZiB0cmFuc2xhdGlvbiBjYW4gYmUgaW5kZXBlbmRlbnRseSBlbmFi
bGVkLiBBbiBpbmNvbWluZyBhZGRyZXNzIGlzIGxvZ2ljYWxseQ0KPiA+Pj4gdHJhbnNsYXRlZCBm
cm9tIFZBIHRvIElQQSBpbiBzdGFnZSAxLCB0aGVuIHRoZSBJUEEgaXMgaW5wdXQgdG8gc3RhZ2Ug
MiB3aGljaCB0cmFuc2xhdGVzIHRoZSBJUEEgdG8gdGhlIG91dHB1dCBQQS4gU3RhZ2UgMSBpcw0K
PiA+Pj4gaW50ZW5kZWQgdG8gYmUgdXNlZCBieSBhIHNvZnR3YXJlIGVudGl0eSggR3Vlc3QgT1Mp
IHRvIHByb3ZpZGUgaXNvbGF0aW9uIG9yIHRyYW5zbGF0aW9uIHRvIGJ1ZmZlcnMgd2l0aGluIHRo
ZSBlbnRpdHksIGZvciBleGFtcGxlLA0KPiA+Pj4gRE1BIGlzb2xhdGlvbiB3aXRoaW4gYW4gT1Mu
IFN0YWdlIDIgaXMgaW50ZW5kZWQgdG8gYmUgYXZhaWxhYmxlIGluIHN5c3RlbXMgc3VwcG9ydGlu
ZyB0aGUgVmlydHVhbGl6YXRpb24gRXh0ZW5zaW9ucyBhbmQgaXMNCj4gPj4+IGludGVuZGVkIHRv
IHZpcnR1YWxpemUgZGV2aWNlIERNQSB0byBndWVzdCBWTSBhZGRyZXNzIHNwYWNlcy4gV2hlbiBi
b3RoIHN0YWdlIDEgYW5kIHN0YWdlIDIgYXJlIGVuYWJsZWQsIHRoZSB0cmFuc2xhdGlvbg0KPiA+
Pj4gY29uZmlndXJhdGlvbiBpcyBjYWxsZWQgbmVzdGluZy4NCj4gPj4+IFN0YWdlIDEgdHJhbnNs
YXRpb24gc3VwcG9ydCBpcyByZXF1aXJlZCB0byBwcm92aWRlIGlzb2xhdGlvbiBiZXR3ZWVuIGRp
ZmZlcmVudCBkZXZpY2VzIHdpdGhpbiB0aGUgZ3Vlc3QgT1MuIFhFTiBhbHJlYWR5IHN1cHBvcnRz
DQo+ID4+PiBTdGFnZSAyIHRyYW5zbGF0aW9uIGJ1dCB0aGVyZSBpcyBubyBzdXBwb3J0IGZvciBT
dGFnZSAxIHRyYW5zbGF0aW9uIGZvciBndWVzdHMuIFdlIHdpbGwgYWRkIHN1cHBvcnQgZm9yIGd1
ZXN0cyB0byBjb25maWd1cmUNCj4gPj4+IHRoZSBTdGFnZSAxIHRyYW5zaXRpb24gdmlhIHZpcnR1
YWwgSU9NTVUuIFhFTiB3aWxsIGVtdWxhdGUgdGhlIFNNTVUgaGFyZHdhcmUgYW5kIGV4cG9zZXMg
dGhlIHZpcnR1YWwgU01NVSB0byB0aGUgZ3Vlc3QuDQo+ID4+PiBHdWVzdCBjYW4gdXNlIHRoZSBu
YXRpdmUgU01NVSBkcml2ZXIgdG8gY29uZmlndXJlIHRoZSBzdGFnZSAxIHRyYW5zbGF0aW9uLiBX
aGVuIHRoZSBndWVzdCBjb25maWd1cmVzIHRoZSBTTU1VIGZvciBTdGFnZSAxLA0KPiA+Pj4gWEVO
IHdpbGwgdHJhcCB0aGUgYWNjZXNzIGFuZCBjb25maWd1cmUgdGhlIGhhcmR3YXJlIGFjY29yZGlu
Z2x5Lg0KPiA+Pj4gTm93IGJhY2sgdG8gdGhlIHF1ZXN0aW9uIG9mIGhvdyB3ZSBjYW4gYWRkIHRo
ZSBJT01NVSBiaW5kaW5nIGJldHdlZW4gdGhlIHZpcnR1YWwgSU9NTVUgYW5kIHRoZSBtYXN0ZXIg
ZGV2aWNlcyBzbyB0aGF0DQo+ID4+PiBndWVzdHMgY2FuIGNvbmZpZ3VyZSB0aGUgSU9NTVUgY29y
cmVjdGx5LiBUaGUgc29sdXRpb24gdGhhdCBJIGFtIHN1Z2dlc3RpbmcgaXMgYXMgYmVsb3c6DQo+
ID4+PiBGb3IgZG9tMCwgd2hpbGUgaGFuZGxpbmcgdGhlIERUIG5vZGUoaGFuZGxlX25vZGUoKSkg
WGVuIHdpbGwgcmVwbGFjZSB0aGUgcGhhbmRsZSBpbiB0aGUgImlvbW11cyIgcHJvcGVydHkgd2l0
aCB0aGUgdmlydHVhbA0KPiA+Pj4gSU9NTVUgbm9kZSBwaGFuZGxlLg0KPiA+PiBCZWxvdywgeW91
IHNhaWQgdGhhdCBlYWNoIElPTU1VcyBtYXkgaGF2ZSBhIGRpZmZlcmVudCBJRCBzcGFjZS4gU28g
c2hvdWxkbid0IHdlIGV4cG9zZSBvbmUgdklPTU1VIHBlciBwSU9NTVU/IElmIG5vdCwgaG93IGRv
IHlvdSBleHBlY3QgdGhlIHVzZXIgdG8gc3BlY2lmeSB0aGUgbWFwcGluZz8NCj4gPiANCj4gPiBZ
ZXMgeW91IGFyZSByaWdodCB3ZSBuZWVkIHRvIGNyZWF0ZSBvbmUgdklPTU1VIHBlciBwSU9NTVUg
Zm9yIGRvbTAuIFRoaXMgYWxzbyBoZWxwcyBpbiB0aGUgQUNQSSBjYXNlDQo+ID4gd2hlcmUgd2Ug
ZG9u4oCZdCBuZWVkIHRvIG1vZGlmeSB0aGUgdGFibGVzIHRvIGRlbGV0ZSB0aGUgcElPTU1VIGVu
dHJpZXMgYW5kIGNyZWF0ZSBvbmUgdklPTU1VLg0KPiA+IEluIHRoaXMgY2FzZSwgbm8gbmVlZCB0
byByZXBsYWNlIHRoZSBwaGFuZGxlIGFzIFhlbiBjcmVhdGUgdGhlIHZJT01NVSB3aXRoIHRoZSBz
YW1lIHBJT01NVQ0KPiA+IHBoYW5kbGUgYW5kIHNhbWUgYmFzZSBhZGRyZXNzLg0KPiA+IA0KPiA+
IEZvciBkb21VIGd1ZXN0cyBvbmUgdklPTU1VIHBlciBndWVzdCB3aWxsIGJlIGNyZWF0ZWQuDQo+
ID4gDQo+ID4+DQo+ID4+PiBGb3IgZG9tVSBndWVzdHMsIHdoZW4gcGFzc3Rocm91Z2ggdGhlIGRl
dmljZSB0byB0aGUgZ3Vlc3QgYXMgcGVyIFsyXSwgIGFkZCB0aGUgYmVsb3cgcHJvcGVydHkgaW4g
dGhlIHBhcnRpYWwgZGV2aWNlIHRyZWUNCj4gPj4+IG5vZGUgdGhhdCBpcyByZXF1aXJlZCB0byBk
ZXNjcmliZSB0aGUgZ2VuZXJpYyBkZXZpY2UgdHJlZSBiaW5kaW5nIGZvciBJT01NVXMgYW5kIHRo
ZWlyIG1hc3RlcihzKQ0KPiA+Pj4gImlvbW11cyA9IDwgJm1hZ2ljX3BoYW5kbGUgMHh2TWFzdGVy
SUQ+DQo+ID4+PiAgICAgIOKAoiBtYWdpY19waGFuZGxlIHdpbGwgYmUgdGhlIHBoYW5kbGUgKCB2
SU9NTVUgcGhhbmRsZSBpbiB4bCkgIHRoYXQgd2lsbCBiZSBkb2N1bWVudGVkIHNvIHRoYXQgdGhl
IHVzZXIgY2FuIHNldCB0aGF0IGluIHBhcnRpYWwgRFQgbm9kZSAoMHhmZGVhKS4NCj4gPj4NCj4g
Pj4gRG9lcyB0aGlzIG1lYW4gb25seSBvbmUgSU9NTVUgd2lsbCBiZSBzdXBwb3J0ZWQgaW4gdGhl
IGd1ZXN0Pw0KPiA+IA0KPiA+IFllcy4NCj4gPiANCj4gPj4NCj4gPj4+ICAgICAg4oCiIHZNYXN0
ZXJJRCB3aWxsIGJlIHRoZSB2aXJ0dWFsIG1hc3RlciBJRCB0aGF0IHRoZSB1c2VyIHdpbGwgcHJv
dmlkZS4NCj4gPj4+IFRoZSBwYXJ0aWFsIGRldmljZSB0cmVlIHdpbGwgbG9vayBsaWtlIHRoaXM6
DQo+ID4+PiAvZHRzLXYxLzsNCj4gPj4+ICAvIHsNCj4gPj4+ICAgICAvKiAjKmNlbGxzIGFyZSBo
ZXJlIHRvIGtlZXAgRFRDIGhhcHB5ICovDQo+ID4+PiAgICAgI2FkZHJlc3MtY2VsbHMgPSA8Mj47
DQo+ID4+PiAgICAgI3NpemUtY2VsbHMgPSA8Mj47DQo+ID4+PiAgICAgICBhbGlhc2VzIHsNCj4g
Pj4+ICAgICAgICAgbmV0ID0gJm1hYzA7DQo+ID4+PiAgICAgfTsNCj4gPj4+ICAgICAgIHBhc3N0
aHJvdWdoIHsNCj4gPj4+ICAgICAgICAgY29tcGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsNCj4gPj4+
ICAgICAgICAgcmFuZ2VzOw0KPiA+Pj4gICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4g
Pj4+ICAgICAgICAgI3NpemUtY2VsbHMgPSA8Mj47DQo+ID4+PiAgICAgICAgIG1hYzA6IGV0aGVy
bmV0QDEwMDAwMDAwIHsNCj4gPj4+ICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiY2FseGVkYSxo
Yi14Z21hYyI7DQo+ID4+PiAgICAgICAgICAgICByZWcgPSA8MCAweDEwMDAwMDAwIDAgMHgxMDAw
PjsNCj4gPj4+ICAgICAgICAgICAgIGludGVycnVwdHMgPSA8MCA4MCA0ICAwIDgxIDQgIDAgODIg
ND47DQo+ID4+PiAgICAgICAgICAgIGlvbW11cyA9IDwweGZkZWEgMHgwMT47DQo+ID4+PiAgICAg
ICAgIH07DQo+ID4+PiAgICAgfTsNCj4gPj4+IH07DQo+ID4+PiAgSW4geGwuY2ZnIHdlIG5lZWQg
dG8gZGVmaW5lIGEgbmV3IG9wdGlvbiB0byBpbmZvcm0gWGVuIGFib3V0IHZNYXN0ZXJJZCB0byBw
TWFzdGVySWQgbWFwcGluZyBhbmQgdG8gd2hpY2ggSU9NTVUgZGV2aWNlIHRoaXMNCj4gPj4+IHRo
ZSBtYXN0ZXIgZGV2aWNlIGlzIGNvbm5lY3RlZCBzbyB0aGF0IFhlbiBjYW4gY29uZmlndXJlIHRo
ZSByaWdodCBJT01NVS4gVGhpcyBpcyByZXF1aXJlZCBpZiB0aGUgc3lzdGVtIGhhcyBkZXZpY2Vz
IHRoYXQgaGF2ZQ0KPiA+Pj4gdGhlIHNhbWUgbWFzdGVyIElEIGJ1dCBiZWhpbmQgYSBkaWZmZXJl
bnQgSU9NTVUuDQo+ID4+DQo+ID4+IEluIHhsLmNmZywgd2UgYWxyZWFkeSBwYXNzIHRoZSBkZXZp
Y2UtdHJlZSBub2RlIHBhdGggdG8gcGFzc3Rocm91Z2guIFNvIFhlbiBzaG91bGQgYWxyZWFkeSBo
YXZlIGFsbCB0aGUgaW5mb3JtYXRpb24gYWJvdXQgdGhlIElPTU1VIGFuZCBNYXN0ZXItSUQuIFNv
IGl0IGRvZXNuJ3Qgc2VlbSBuZWNlc3NhcnkgZm9yIERldmljZS1UcmVlLg0KPiA+Pg0KPiA+PiBG
b3IgQUNQSSwgSSB3b3VsZCBoYXZlIGV4cGVjdGVkIHRoZSBpbmZvcm1hdGlvbiB0byBiZSBmb3Vu
ZCBpbiB0aGUgSU9SRVEuDQo+ID4+DQo+ID4+IFNvIGNhbiB5b3UgYWRkIG1vcmUgY29udGV4dCB3
aHkgdGhpcyBpcyBuZWNlc3NhcnkgZm9yIGV2ZXJ5b25lPw0KPiA+IA0KPiA+IFdlIGhhdmUgaW5m
b3JtYXRpb24gZm9yIElPTU1VIGFuZCBNYXN0ZXItSUQgYnV0IHdlIGRvbuKAmXQgaGF2ZSBpbmZv
cm1hdGlvbiBmb3IgbGlua2luZyB2TWFzdGVyLUlEIHRvIHBNYXN0ZXItSUQuDQo+ID4gVGhlIGRl
dmljZSB0cmVlIG5vZGUgd2lsbCBiZSB1c2VkIHRvIGFzc2lnbiB0aGUgZGV2aWNlIHRvIHRoZSBn
dWVzdCBhbmQgY29uZmlndXJlIHRoZSBTdGFnZS0yIHRyYW5zbGF0aW9uLiBHdWVzdCB3aWxsIHVz
ZSB0aGUNCj4gPiB2TWFzdGVyLUlEIHRvIGNvbmZpZ3VyZSB0aGUgdklPTU1VIGR1cmluZyBib290
LiBYZW4gbmVlZHMgaW5mb3JtYXRpb24gdG8gbGluayB2TWFzdGVyLUlEIHRvIHBNYXN0ZXItSUQg
dG8gY29uZmlndXJlDQo+ID4gdGhlIGNvcnJlc3BvbmRpbmcgcElPTU1VLiBBcyBJIG1lbnRpb24g
d2UgbmVlZCB2TWFzdGVyLUlEIGluIGNhc2UgYSBzeXN0ZW0gY291bGQgaGF2ZSAyIGlkZW50aWNh
bCBNYXN0ZXItSUQgYnV0DQo+ID4gZWFjaCBvbmUgY29ubmVjdGVkIHRvIGEgZGlmZmVyZW50IFNN
TVUgYW5kIGFzc2lnbmVkIHRvIHRoZSBndWVzdC4NCj4gDQo+IEkgdGhpbmsgdGhlIHByb3Bvc2Vk
IHNvbHV0aW9uIHdvdWxkIHdvcmsgYW5kIEkgd291bGQganVzdCBsaWtlIHRvIGNsZWFyIHNvbWUg
aXNzdWVzLg0KPiANCj4gUGxlYXNlIGNvcnJlY3QgbWUgaWYgSSdtIHdyb25nOg0KPiANCj4gSW4g
dGhlIHhsIGNvbmZpZyBmaWxlIHdlIGFscmVhZHkgbmVlZCB0byBzcGVjaWZ5IGR0ZGV2IHRvIHBv
aW50IHRvIHRoZSBkZXZpY2UgcGF0aCBpbiBob3N0IGR0Yi4NCj4gSW4gdGhlIHBhcnRpYWwgZGV2
aWNlIHRyZWUgd2Ugc3BlY2lmeSB0aGUgdk1hc3RlcklkIGFzIHdlbGwgYXMgbWFnaWMgcGhhbmRs
ZS4NCj4gSXNuJ3QgaXQgdGhhdCB3ZSBhbHJlYWR5IGhhdmUgYWxsIHRoZSBpbmZvcm1hdGlvbiBu
ZWNlc3Nhcnkgd2l0aG91dCB0aGUgbmVlZCBmb3IgaW9tbXVfZGV2aWRfbWFwPw0KPiBGb3IgbWUg
aXQgbG9va3MgbGlrZSB0aGUgcGFydGlhbCBkdGIgcHJvdmlkZXMgdk1hc3RlcklEIGFuZCBkdGRl
diBwcm92aWRlcyBwTWFzdGVySUQgYXMgd2VsbCBhcyBwaHlzaWNhbCBwaGFuZGxlIHRvIFNNTVUu
DQo+IA0KPiBIYXZpbmcgc2FpZCB0aGF0LCBJIGNhbiBhbHNvIHVuZGVyc3RhbmQgdGhhdCBzcGVj
aWZ5aW5nIGV2ZXJ5dGhpbmcgaW4gb25lIHBsYWNlIHVzaW5nIGlvbW11X2RldmlkX21hcCBjYW4g
YmUgZWFzaWVyDQo+IGFuZCByZWR1Y2VzIHRoZSBuZWVkIGZvciBkZXZpY2UgdHJlZSBwYXJzaW5n
Lg0KPiANCj4gQXBhcnQgZnJvbSB0aGF0LCB3aGF0IGlzIHRoZSByZWFzb24gb2YgZXhwb3Npbmcg
b25seSBvbmUgdlNNTVUgdG8gZ3Vlc3QgaW5zdGVhZCBvZiBvbmUgdlNNTVUgcGVyIHBTTU1VPw0K
PiBJbiB0aGUgbGF0dGVyIHNvbHV0aW9uLCB0aGUgd2hvbGUgaXNzdWUgd2l0aCBoYW5kbGluZyBk
ZXZpY2VzIHdpdGggdGhlIHNhbWUgc3RyZWFtIElEIGJ1dCBiZWxvbmdpbmcgdG8gZGlmZmVyZW50
IFNNTVVzDQo+IHdvdWxkIGJlIGdvbmUuIEl0IHdvdWxkIGFsc28gcmVzdWx0IGluIGEgbW9yZSBu
YXR1cmFsIHdheSBvZiB0aGUgZGV2aWNlIHRyZWUgbG9vay4gTm9ybWFsbHkgYSBndWVzdCB3b3Vs
ZCBzZWUNCj4gZS5nLiBib3RoIFNNTVVzIGFuZCBleHBvc2luZyBvbmx5IG9uZSBjYW4gYmUgbWlz
bGVhZGluZy4NCj4gDQo+IEkgYWxzbyBoYXZlIHRoZSBzYW1lIHF1ZXN0aW9uLiBGcm9tIGVhcmxp
ZXIgYW5zd2VycyBhcyBJIHVuZGVyc3RhbmQgaXQgaXMgZ29pbmcgdG8gYmUgaWRlbnRpdHkgdlNN
TVUgPC0+IHBTTU1VIG1hcHBpbmdzIGZvciBEb20wLCBzbyB3aHkgZGl2ZXJnZSBmb3IgRG9tVT8N
Cj4gDQo+IEFsc28gSSBhbSB0aGlua2luZyBob3cgdGhpcyBzb2x1dGlvbiB3b3VsZCB3b3JrIGZv
ciBJUE1NVS1WTVNBIEdlbjMoR2VuNCksIHdoaWNoIGFsc28gc3VwcG9ydHMgdHdvIHN0YWdlcyBv
ZiB0cmFuc2xhdGlvbiwgc28gdGhlIG5lc3RlZCB0cmFuc2xhdGlvbiBjb3VsZCBiZSBwb3NzaWJs
ZSBpbiBnZW5lcmFsLCBhbHRob3VnaCB0aGVyZSBtaWdodCBiZSBzb21lIHBpdGZhbGxzDQo+ICh5
ZXMsIEkgdW5kZXJzdGFuZCB0aGF0IGNvZGUgdG8gZW11bGF0ZSBhY2Nlc3MgdG8gY29udHJvbCBy
ZWdpc3RlcnMgd291bGQgYmUgZGlmZmVyZW50IGluIGNvbXBhcmlzb24gd2l0aCBTTU1VdjMsIGJ1
dCBzb21lIG90aGVyIGNvZGUgY291bGQgYmUgY29tbW9uKS4gIA0KDQpZZXMgd2Ugd2lsbCB0cnkg
dG8gbWFrZSBjb2RlIGNvbW1vbiBzbyB0aGF0IG90aGVyIHZJT01NVSBjYW4gYmUgaW1wbGVtZW50
ZWQgZWFzaWx5LiANCj4gICAgDQo+IA0KPiANCj4gIA0KPiANCj4gPj4NCj4gPj4+ICBpb21tdV9k
ZXZpZF9tYXAgPSBbIOKAnFBNQVNURVJfSURbQFZNQVNURVJfSURdLElPTU1VX0JBU0VfQUREUkVT
U+KAnSAsIOKAnFBNQVNURVJfSURbQFZNQVNURVJfSURdLElPTU1VX0JBU0VfQUREUkVTU+KAnV0N
Cj4gPj4+ICAgICAg4oCiIFBNQVNURVJfSUQgaXMgdGhlIHBoeXNpY2FsIG1hc3RlciBJRCBvZiB0
aGUgZGV2aWNlIGZyb20gdGhlIHBoeXNpY2FsIERULg0KPiA+Pj4gICAgICDigKIgVk1BU1RFUl9J
RCBpcyB0aGUgdmlydHVhbCBtYXN0ZXIgSWQgdGhhdCB0aGUgdXNlciB3aWxsIGNvbmZpZ3VyZSBp
biB0aGUgcGFydGlhbCBkZXZpY2UgdHJlZS4NCj4gPj4+ICAgICAg4oCiIElPTU1VX0JBU0VfQURE
UkVTUyBpcyB0aGUgYmFzZSBhZGRyZXNzIG9mIHRoZSBwaHlzaWNhbCBJT01NVSBkZXZpY2UgdG8g
d2hpY2ggdGhpcyBkZXZpY2UgaXMgY29ubmVjdGVkLg0KPiAgDQo+IA0KPiBJZiBpb21tdV9kZXZp
ZF9tYXAgaXMgYSB3YXkgdG8gZ28sIEkgaGF2ZSBhIHF1ZXN0aW9uLCB3b3VsZCB0aGlzIGNvbmZp
Z3VyYXRpb24gY292ZXIgdGhlIGZvbGxvd2luZyBjYXNlcz8NCj4gMS4gRGV2aWNlIGhhcyBzZXZl
cmFsIHN0cmVhbSBJRHMNCg0KWWVzIGluIHRoYXQgY2FzZSB1c2VyIG5lZWRzIHRvIGNyZWF0ZSB0
aGUgbWFwcGluZyBmb3IgZWFjaCBzdHJlYW1JRHMuIEZvciBleGFtcGxlIGlmIGRldmljZSBoYXMg
c3RyZWFtSWQgMHgxMCAsIDB4MjAgYW5kIDB4MzAuDQppb21tdV9kZXZpZF9tYXAgd2lsbCBiZToN
Cg0KaW9tbXVfZGV2aWRfbWFwID0gWyIweDEwQDB4MDEsMHg0MDAwMDAwMOKAnSwgIjB4MjBAMHgw
MiwweDQwMDAwMDAw4oCdLCIweDMwQDB4MDMsMHg0MDAwMDAwMOKAnV0NCg0KSGVyZSAweDQwMDAw
MDAwIGlzIHBoeXNpY2FsIElPTU1VIGJhc2UgYWRkcmVzcy4NCg0KPiAyLiBTZXZlcmFsIGRldmlj
ZXMgc2hhcmUgdGhlIHN0cmVhbSBJRCAob3Igc2V2ZXJhbCBzdHJlYW0gSURzKQ0KDQpMZXQgdGFr
ZSBhbiBleGFtcGxlIG9mIHR3byBkZXZpY2VzIDoNCg0KRGV2aWNlIDE6IDB4MTANCkRldmljZSAy
OiAweDEwDQoNCklvbW11X2RldmlkX21hcCA9IFvigJwweDEwQDB4MSwweDQwMDAwMDAw4oCdLCIw
eDEwQDB4MiwweDQwMDAwMDAw4oCdXQ0KDQpYZW4gd2lsbCBjcmVhdGUgdGhlIGRhdGEgc3RydWN0
dXJlIHRoYXQgaW5jbHVkZSB2U3RyZWFtSUQsIHBNYXN0ZXJJRCBhbmQgSU9NTVUgYmFzZSBhZGRy
ZXNzLiANCldpdGggdGhlIGhlbHAgb2YgdGhyZWUgdHVwbGVzIHdlIHdpbGwgYmUgYWJsZSB0byBm
aW5kIHRoZSByaWdodCBwaHlzaWNhbCBJT01NVS4gDQoNCg0KUmVnYXJkcywNClJhaHVs


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 17:00:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 17:00:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431129.683719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo6F3-0002n2-Bs; Thu, 27 Oct 2022 17:00:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431129.683719; Thu, 27 Oct 2022 17:00:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo6F3-0002mv-8w; Thu, 27 Oct 2022 17:00:29 +0000
Received: by outflank-mailman (input) for mailman id 431129;
 Thu, 27 Oct 2022 17:00:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo6F1-0002ml-TP; Thu, 27 Oct 2022 17:00:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo6F1-0007in-Ph; Thu, 27 Oct 2022 17:00:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo6F1-0006wk-EP; Thu, 27 Oct 2022 17:00:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo6F1-0003ZU-Ds; Thu, 27 Oct 2022 17:00:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1KtkQBzlYzsvGinvGgZbrYWkJfWaCIdnnmVRvnvOWoM=; b=Zdf5kiCJt/2EpaUJpbvdtrBe5Z
	RUM9QeFL5Hl/WRska1mBoR2oFEpKV3NXwB6mKOFZuslxqHCuVw+uudemRi0aIZr1whULiM2Kltm7b
	9auT46AUES9hMjCT7/LV/819U5hY2GPV74Ea34x51BD3klijCLt2Mvuh5sbS6De+Z0kw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174450-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174450: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-vhd:<job status>:broken:regression
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:regression
    linux-5.4:test-armhf-armhf-xl-vhd:capture-logs(14):broken:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fe18f1af38a7999e05a6564c80d63e8d9df5ee60
X-Osstest-Versions-That:
    linux=fd92cfed8bc6668d314acd1e6da708a80826f768
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 17:00:27 +0000

flight 174450 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174450/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-vhd         <job status>                 broken
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 174012
 test-armhf-armhf-xl-vhd      13 guest-start              fail REGR. vs. 174012

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd      14 capture-logs(14)      broken blocked in 174012
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 174012
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-xl-credit1  18 guest-start/debian.repeat    fail  like 174012
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174012
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174012
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat    fail like 174012
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174012
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174012
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174012
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174012
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                fe18f1af38a7999e05a6564c80d63e8d9df5ee60
baseline version:
 linux                fd92cfed8bc6668d314acd1e6da708a80826f768

Last test of basis   174012  2022-10-17 16:21:11 Z   10 days
Testing same since   174450  2022-10-26 11:42:18 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Ahmad Fatoum <a.fatoum@pengutronix.de>
  Albert Briscoe <albertsbriscoe@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Coffin <alex.coffin@matician.com>
  Alexander Dahl <ada@thorsis.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexei Starovoitov <ast@kernel.org>
  Alexey Lyashkov <alexey.lyashkov@gmail.com>
  Allen Pais <apais@linux.microsoft.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Andreas Pape <apape@de.adit-jv.com>
  Andrew Bresticker <abrestic@rivosinc.com>
  Andrew Gaul <gaul@gaul.org>
  Andrew Gaul <gaul@google.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrew Perepechko <anserper@ya.ru>
  Andri Yngvason <andri@yngvason.is>
  Andrii Nakryiko <andrii@kernel.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Anssi Hannula <anssi.hannula@bitwise.fi>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Arvid Norlander <lkml@vorpal.se>
  Baokun Li <libaokun1@huawei.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bernard Metzler <bmt@zurich.ibm.com>
  Bitterblue Smith <rtl8821cerfe2@gmail.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Callum Osmotherly <callum.osmotherly@gmail.com>
  Carlos Llamas <cmllamas@google.com>
  Chao Qin <chao.qin@intel.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wenst@chromium.org>
  Chi-hsien Lin <chi-hsien.lin@cypress.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Chuck Lever <chuck.lever@oracle.com>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Coly Li <colyli@suse.de>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Golle <daniel@makrotopia.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Jiang <dave.jiang@intel.com>
  David Collins <collinsd@codeaurora.org>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  David Teigland <teigland@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <dmitry.osipenko@collabora.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eddie James <eajames@linux.ibm.com>
  Eric Dumazet <edumazet@google.com>
  Eugeniu Rosca <erosca@de.adit-jv.com>
  Fangrui Song <maskray@google.com>
  Fenglin Wu <quic_fenglinw@quicinc.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Haibo Chen <haibo.chen@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Hari Chandrakanthan <quic_haric@quicinc.com>
  Hawkins Jiawei <yin31149@gmail.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hillf Danton <hdanton@sina.com>
  hongao <hongao@uniontech.com>
  Huacai Chen <chenhuacai@loongson.cn>
  Hyunwoo Kim <imv4bel@gmail.com>
  Ian Nam <young.kwan.nam@xilinx.com>
  Ignat Korchagin <ignat@cloudflare.com>
  Ingo Molnar <mingo@kernel.org>
  Jack Wang <jinpu.wang@ionos.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jason Baron <jbaron@akamai.com>
  Jassi Brar <jaswinder.singh@linaro.org>
  Javier Martinez Canillas <javierm@redhat.com>
  Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
  Jens Axboe <axboe@kernel.dk>
  Jerry Lee <jerrylee@qnap.com>
  Jerry Lee 李修賢 <jerrylee@qnap.com>
  Jes Sorensen <Jes.Sorensen@gmail.com>
  Jianglei Nie <niejianglei2021@163.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jim Cromie <jim.cromie@gmail.com>
  Jimmy Assarsson <extja@kvaser.com>
  Jinke Han <hanjinke.666@bytedance.com>
  Jiri Kosina <jkosina@suse.cz>
  Joel Stanley <joel@jms.id.au>
  Joerg Roedel <jroedel@suse.de>
  Johannes Berg <johannes.berg@intel.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Junichi Uekawa <uekawa@chromium.org>
  Kalle Valo <kvalo@kernel.org>
  Kalle Valo <quic_kvalo@quicinc.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Keith Busch <kbusch@kernel.org>
  Kevin(Yudong) Yang <yyd@google.com>
  Khalid Masum <khalid.masum.92@gmail.com>
  Koba Ko <koba.ko@canonical.com>
  Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
  Lalith Rajendran <lalithkraj@google.com>
  Lam Thai <lamthai@arista.com>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Lee Jones <lee@kernel.org>
  Leon Romanovsky <leon@kernel.org>
  Letu Ren <fantasquex@gmail.com>
  Liang He <windhl@126.com>
  Liang Yang <liang.yang@amlogic.com>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Liu Jian <liujian56@huawei.com>
  Logan Gunthorpe <logang@deltatee.com>
  Lorenz Bauer <oss@lmb.io>
  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Luke D. Jones <luke@ljones.dev>
  Lyude Paul <lyude@redhat.com>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Behún <kabel@kernel.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Liska <mliska@suse.cz>
  Masahiro Yamada <masahiroy@kernel.org>
  Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Maya Matuszczyk <maccraft123mc@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Hennerich <michael.hennerich@analog.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Michal Luczaj <mhal@rbox.co>
  Michal Simek <michal.simek@amd.com>
  Mike Pattrick <mkp@redhat.com>
  Mingzhe Zou <mingzhe.zou@easystack.cn>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nam Cao <namcaov@gmail.com>
  Namhyung Kim <namhyung@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Nicolas Dufresne <nicolas.dufresne@collabora.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Ninad Naik <ninad.naik@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Olga Kornievskaia <kolga@netapp.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Ondrej Mosnacek <omosnace@redhat.com>
  Pali Rohár <pali@kernel.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paul Moore <paul@paul-moore.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Oberparleiter <oberpar@linux.ibm.com>
  Peter Robinson <pbrobinson@gmail.com>
  Peter Rosin <peda@axentia.se>
  Peter Xu <peterx@redhat.com>
  Petr Mladek <pmladek@suse.com>
  Phil Sutter <phil@nwl.cc>
  Philipp Hortmann <philipp.g.hortmann@gmail.com>
  Qu Wenruo <wqu@suse.com>
  Quanyang Wang <quanyang.wang@windriver.com>
  Quentin Monnet <quentin@isovalent.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Reinette Chatre <reinette.chatre@intel.com>
  Rich Felker <dalias@libc.org>
  Richard Acayan <mailingradian@gmail.com>
  Richard Weinberger <richard@nod.at>
  Rik van Riel <riel@surriel.com>
  Rob Clark <robdclark@chromium.org>
  Robert Foss <robert.foss@linaro.org>
  Robin Guo <guoweibin@inspur.com>
  Robin Murphy <robin.murphy@arm.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rustam Subkhankulov <subkhankulov@ispras.ru>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Saranya Gopal <saranya.gopal@intel.com>
  Sasha Levin <sashal@kernel.org>
  Saurabh Sengar <ssengar@linux.microsoft.com>
  Sean Christopherson <seanjc@google.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Shawn Guo <shawnguo@kernel.org>
  Sherry Sun <sherry.sun@nxp.com>
  Shigeru Yoshida <syoshida@redhat.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slade Watkins <srw@sladewatkins.net>
  Song Liu <song@kernel.org>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Steffen Klassert <steffen.klassert@secunet.com>
  Stephen Boyd <sboyd@kernel.org>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  sunghwan jung <onenowy@gmail.com>
  Sungwoo Kim <iam@sung-woo.kim>
  syzbot <syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com>
  syzbot+5ec9bb042ddfe9644773@syzkaller.appspotmail.com
  Tadeusz Struk<tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Tales Aparecida <tales.aparecida@gmail.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Thara Gopinath <tgopinath@microsoft.com>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Zimmermann <tzimmermann@suse.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Tzung-Bi Shih <tzungbi@kernel.org>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vinod Koul <vkoul@kernel.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wang Kefeng <wangkefeng.wang@huawei.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wen Gong <quic_wgong@quicinc.com>
  Wenchao Chen <wenchao.chen@unisoc.com>
  William Dean <williamsukatube@gmail.com>
  Wright Feng <wright.feng@cypress.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Qiang <xuqiang36@huawei.com>
  Yonghong Song <yhs@fb.com>
  Yuchung Cheng <ycheng@google.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
  Zheng Yejian <zhengyejian1@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhu Yanjun <yanjun.zhu@linux.dev>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      broken  
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl-vhd broken
broken-step test-armhf-armhf-xl-vhd capture-logs(14)

Not pushing.

(No revision log; it would be 7597 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 17:18:41 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 17:18:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431136.683730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo6WZ-0004su-1u; Thu, 27 Oct 2022 17:18:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431136.683730; Thu, 27 Oct 2022 17:18:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo6WY-0004sn-V2; Thu, 27 Oct 2022 17:18:34 +0000
Received: by outflank-mailman (input) for mailman id 431136;
 Thu, 27 Oct 2022 17:18:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6J+t=24=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1oo6WW-0004sR-P7
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 17:18:33 +0000
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam04on2084.outbound.protection.outlook.com [40.107.102.84])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5efd5dee-561b-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 19:18:28 +0200 (CEST)
Received: from BN9PR03CA0607.namprd03.prod.outlook.com (2603:10b6:408:106::12)
 by PH8PR12MB6769.namprd12.prod.outlook.com (2603:10b6:510:1c4::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 17:18:24 +0000
Received: from BN8NAM11FT111.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:106:cafe::c6) by BN9PR03CA0607.outlook.office365.com
 (2603:10b6:408:106::12) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Thu, 27 Oct 2022 17:18:24 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT111.mail.protection.outlook.com (10.13.177.54) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5746.16 via Frontend Transport; Thu, 27 Oct 2022 17:18:23 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct
 2022 12:18:23 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Thu, 27 Oct 2022 12:18:21 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5efd5dee-561b-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E0bjR/UC9KeHphw4P/DDOJ/HptTy23ev5Ji/KQV2IK3CqJTcXioqRXSfn/beVdr6jX/Kor6OB+zykhsM07UAh8dgJv8XkMqaKJGYaMkH5EGDYuX6JZt0IAZuOWD34oeklJCA+W6hmwZU+o6xNrRhZeHtxXgOVdTEb9LZUUfHJQ0Ktl12LHl3BvP410pqKMb6HxtjuB6ivzO5YK1KIeLGxjpKXtRZCK/S4s4tCeIQU8TncOc4wMuLvVgwzwK3WF/AoJAyvdJVV9IAsAcMQZco9zjxjH6j8HJ3bEI2Tqfxc4X2nNF8bnrqRdC40flmojsn90cJplGCdr+bmhN3W3G4EA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QOGjgVScCEyvCzW4wOzlicFrgQI4xTDncbB9kJaxG2s=;
 b=H90TGcpbWJGyJQvlaJ/8nLBwRzZqKR0lUIF/g5A39SpJxaZ330gaL0F9bqTxv7RgBL2dQpDLQEpo7/I4+r+sRJuUSHHEVNW7TO6NJAbxgfxDmPxDMutCOZ/cRDyothQJ1ii8WnDsphL8k2MvqtqB31i3d+GMJf5AaoKsJ02xgCH8osq29VaQXRYxo3fOJ8821nxCwsdBeX02BvyfwhqOldvzbiRXvUjRbkN9tPoKf08s39Y69d6iz6KOOoX7Z/Ne6N28MezvRsZV5URpFykxdBXN23lj8Z4eVuPbNofGQz8QthzdraZFVJye0tRZThgw3K4KvVG0clu0+rawIpm+qQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QOGjgVScCEyvCzW4wOzlicFrgQI4xTDncbB9kJaxG2s=;
 b=O/XDTW2/BppF0qIW2C+zt3ozsUs4oxvi+Jfkd5Fay5PJBGxoEXEaR7LheLfV196bx+skqVv+5V4K5iSLbtjjDI1SPGOAOWbDl3WZJ/wrddNrVWV+VP00/SuLqMs4Do6rsGVAC2ZS61kNGZkkK58sasSb052AWkfnwu7m+QVdTvw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <15e041fe-1ec2-b616-3f9c-5f5ef8014290@amd.com>
Date: Thu, 27 Oct 2022 19:18:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Rahul Singh <Rahul.Singh@arm.com>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT111:EE_|PH8PR12MB6769:EE_
X-MS-Office365-Filtering-Correlation-Id: ba7ef6b6-b7c0-4895-b7ef-08dab83f40fd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rakmkZ3BWA7BIwGq8YOHyh1zuz9zqLzrx/orc95b9DZBVO7ckL6u7Pq1xdBxo+eneWxWW5vqqBDMvWtHV73fxA5RRYpMBbrFaW2KtQD7D7Ms5yr84V4w7i726MMJ0f4B9AFB2d72rOOM+YR+Y5G3wcUUzHs2hKzPJfgYjqFxOo97ZdPn0e3aBIy0QytvQw2BhqWDQhlZKUhdcoQHMob89S8/tl/6PlUuDnQyqdq+ZVyilC2OmI+70zhxg5HyWefl6NBiGoU7ggRIwCzMfdeMC5E67QVhwhMyEP3429PVzP6eZcTWvFuT2Y1aUs6eVbo0b/A3AE2m2yu4wQC53Va46/FvC46eLby4tUrmflrTH8lyQG4WxPl5cUeylkjdLWYCA9DP37og70oxDFlvmRODhfhfj4VBnlgMyrj3C9T9uZ0/x+LlwYeq4zPzdEahGA7YkNNocin1lFBqdoIUnP3xhxxMsxARsRH3JDfdiNl/dGvpBtCmkImsjrR8vIoau6/jC6E8y1wACopZWONdaVK4pV3hwC96HHyEosnWc9B2zGzzYNPsjd6IiU+k2KExlAE3P5NQTBVsnYsehJBFSkj3amZ90sYQpshMPAmHGa6PnGT5tHetOMgy2iS23nyU/QCTfFcCvq30qqV8AC1jnUtGS15o1OXDc1kocTZ4IPFiIpkOIRsHj49SZHLmdnbtLyxqA3Ig2gB6Ke0pncZIumC7tqZgOBF3aCsIWaImbOBeFyz+qpaKw8UHYJbtkqdPZiSwkRpbnjvLhT4adkoG6L68orJbDCKkwKrEdUzET9Wx8b543TCIees1YHuRVbqK0JHAWhVgObcmLeyTn9aWTvTIG66DpUXoBIWoveLWDquih38=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(396003)(376002)(451199015)(40470700004)(36840700001)(46966006)(83380400001)(31686004)(31696002)(16576012)(478600001)(966005)(36756003)(70586007)(4326008)(8676002)(41300700001)(110136005)(86362001)(53546011)(7416002)(5660300002)(26005)(8936002)(40480700001)(426003)(70206006)(82310400005)(47076005)(336012)(54906003)(186003)(2616005)(40460700003)(2906002)(44832011)(316002)(30864003)(81166007)(356005)(82740400003)(36860700001)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 17:18:23.8697
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ba7ef6b6-b7c0-4895-b7ef-08dab83f40fd
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT111.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6769

Hi Rahul,

On 27/10/2022 18:33, Julien Grall wrote:
> 
> 
> On 27/10/2022 17:08, Rahul Singh wrote:
>> Hi Julien,
> 
> Hi Rahul,
> 
>>> On 26 Oct 2022, at 8:48 pm, Julien Grall <julien@xen.org> wrote:
>>>
>>>
>>>
>>> On 26/10/2022 15:33, Rahul Singh wrote:
>>>> Hi Julien,
>>>
>>> Hi Rahul,
>>>
>>>>> On 26 Oct 2022, at 2:36 pm, Julien Grall <julien@xen.org> wrote:
>>>>>
>>>>>
>>>>>
>>>>> On 26/10/2022 14:17, Rahul Singh wrote:
>>>>>> Hi All,
>>>>>
>>>>> Hi Rahul,
>>>>>
>>>>>> At Arm, we started to implement the POC to support 2 levels of page tables/nested translation in SMMUv3.
>>>>>> To support nested translation for guest OS Xen needs to expose the virtual IOMMU. If we passthrough the
>>>>>> device to the guest that is behind an IOMMU and virtual IOMMU is enabled for the guest there is a need to
>>>>>> add IOMMU binding for the device in the passthrough node as per [1]. This email is to get an agreement on
>>>>>> how to add the IOMMU binding for guest OS.
>>>>>> Before I will explain how to add the IOMMU binding let me give a brief overview of how we will add support for virtual
>>>>>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3 Nested translation support. SMMUv3 hardware
>>>>>> supports two stages of translation. Each stage of translation can be independently enabled. An incoming address is logically
>>>>>> translated from VA to IPA in stage 1, then the IPA is input to stage 2 which translates the IPA to the output PA. Stage 1 is
>>>>>> intended to be used by a software entity( Guest OS) to provide isolation or translation to buffers within the entity, for example,
>>>>>> DMA isolation within an OS. Stage 2 is intended to be available in systems supporting the Virtualization Extensions and is
>>>>>> intended to virtualize device DMA to guest VM address spaces. When both stage 1 and stage 2 are enabled, the translation
>>>>>> configuration is called nesting.
>>>>>> Stage 1 translation support is required to provide isolation between different devices within the guest OS. XEN already supports
>>>>>> Stage 2 translation but there is no support for Stage 1 translation for guests. We will add support for guests to configure
>>>>>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU hardware and exposes the virtual SMMU to the guest.
>>>>>> Guest can use the native SMMU driver to configure the stage 1 translation. When the guest configures the SMMU for Stage 1,
>>>>>> XEN will trap the access and configure the hardware accordingly.
>>>>>> Now back to the question of how we can add the IOMMU binding between the virtual IOMMU and the master devices so that
>>>>>> guests can configure the IOMMU correctly. The solution that I am suggesting is as below:
>>>>>> For dom0, while handling the DT node(handle_node()) Xen will replace the phandle in the "iommus" property with the virtual
>>>>>> IOMMU node phandle.
>>>>> Below, you said that each IOMMUs may have a different ID space. So shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the user to specify the mapping?
>>>> Yes you are right we need to create one vIOMMU per pIOMMU for dom0. This also helps in the ACPI case
>>>> where we don’t need to modify the tables to delete the pIOMMU entries and create one vIOMMU.
>>>> In this case, no need to replace the phandle as Xen create the vIOMMU with the same pIOMMU
>>>> phandle and same base address.
>>>> For domU guests one vIOMMU per guest will be created.
>>>
>>> IIRC, the SMMUv3 is using a ring like the GICv3 ITS. I think we need to be open here because this may end up to be tricky to security support it (we have N guest ring that can write to M host ring).
>>
>> If xl want to creates the one vIOMMU per pIOMMU for domU then xl needs to know the below information:
>>   -  Find the number of holes in guest memory same as the number of vIOMMU that needs the creation to create the vIOMMU DT nodes. (Think about a big system that has 50+ IOMMUs)
>>      Yes, we will create vIOMMU for only those devices that are assigned to guests but still we need to find the hole in guest memory.
> 
> I agree this is a problem with the one vIOMMU per pIOMMU.
> 
>>   -  Find the pIOMMU attached to the assigned device and create mapping b/w vIOMMU -> pIOMMU to register the MMIO handler.
>>      Either we need to modify the current hyerpcall or need to implement a new hypercall to find this information.
> 
> Adding hypercalls are is not a big problem.
> 
>>
>> Because of the above reason I thought of creating one vIOMMU for domU. Yes you are right this may end up to be tricky to security support
>> but as per my understanding one vIOMMU  per domU guest is easy to implement and simple to handle as compared to one vIOMMU per pIOMMU
> 
> I am not sure about this. My gut feeling is the code in Xen will end up
> to be tricky (there more that Xen doesn't support preemption). So I
> think we will trade-off complexity in Xen over simplicity in libxl.
> 
> That said, I haven't looked deeper in the code. So I may be wrong. I
> will need to see the code to confirm.
> 
>>>>>> For domU guests, when passthrough the device to the guest as per [2],  add the below property in the partial device tree
>>>>>> node that is required to describe the generic device tree binding for IOMMUs and their master(s)
>>>>>> "iommus = < &magic_phandle 0xvMasterID>
>>>>>>   • magic_phandle will be the phandle ( vIOMMU phandle in xl)  that will be documented so that the user can set that in partial DT node (0xfdea).
>>>>>
>>>>> Does this mean only one IOMMU will be supported in the guest?
>>>> Yes.
>>>>>
>>>>>>   • vMasterID will be the virtual master ID that the user will provide.
>>>>>> The partial device tree will look like this:
>>>>>> /dts-v1/;
>>>>>>   / {
>>>>>>      /* #*cells are here to keep DTC happy */
>>>>>>      #address-cells = <2>;
>>>>>>      #size-cells = <2>;
>>>>>>        aliases {
>>>>>>          net = &mac0;
>>>>>>      };
>>>>>>        passthrough {
>>>>>>          compatible = "simple-bus";
>>>>>>          ranges;
>>>>>>          #address-cells = <2>;
>>>>>>          #size-cells = <2>;
>>>>>>          mac0: ethernet@10000000 {
>>>>>>              compatible = "calxeda,hb-xgmac";
>>>>>>              reg = <0 0x10000000 0 0x1000>;
>>>>>>              interrupts = <0 80 4  0 81 4  0 82 4>;
>>>>>>             iommus = <0xfdea 0x01>;
>>>>>>          };
>>>>>>      };
>>>>>> };
>>>>>>   In xl.cfg we need to define a new option to inform Xen about vMasterId to pMasterId mapping and to which IOMMU device this
>>>>>> the master device is connected so that Xen can configure the right IOMMU. This is required if the system has devices that have
>>>>>> the same master ID but behind a different IOMMU.
>>>>>
>>>>> In xl.cfg, we already pass the device-tree node path to passthrough. So Xen should already have all the information about the IOMMU and Master-ID. So it doesn't seem necessary for Device-Tree.
>>>>>
>>>>> For ACPI, I would have expected the information to be found in the IOREQ.
>>>>>
>>>>> So can you add more context why this is necessary for everyone?
>>>> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
>>>
>>> I am confused. Below, you are making the virtual master ID optional. So shouldn't this be mandatory if you really need the mapping with the virtual ID?
>>
>> vMasterID is optional if user knows pMasterID is unique on the system. But if pMasterId is not unique then user needs to provide the vMasterID.
> 
> So the expectation is the user will be able to know that the pMasterID
> is uniq. This may be easy with a couple of SMMUs, but if you have 50+
> (as suggested above). This will become a pain on larger system.
> 
> IHMO, it would be much better if we can detect that in libxl (see below).
> 
>>
>>>
>>>> The device tree node will be used to assign the device to the guest and configure the Stage-2 translation. Guest will use the
>>>> vMaster-ID to configure the vIOMMU during boot. Xen needs information to link vMaster-ID to pMaster-ID to configure
>>>> the corresponding pIOMMU. As I mention we need vMaster-ID in case a system could have 2 identical Master-ID but
>>>> each one connected to a different SMMU and assigned to the guest.
>>>
>>> I am afraid I still don't understand why this is a requirement. Libxl could have enough knowledge (which will be necessarry for the PCI case) to know the IOMMU and pMasterID associated with a device.
>>>
>>> So libxl could allocate the vMasterID, tell Xen the corresponding mapping and update the device-tree.
>>>
>>> IOW, it doesn't seem to be necessary to involve the user in the process here.
>>
>> Yes, libxl could allocate the vMasterID but there is no way we can find the link b/w vMasterID created to pMasterID from dtdev.
>>
>> What I understand from the code is that there is no link between the passthrough node and dtdev config option. The passthrough
>> node is directly copied to guest DT without any modification. Dtdev is used to add and assign the device to IOMMU.
>>
>> Let's take an example if the user wants to assign two devices to the guest via passthrough node.
>>
>> /dts-v1/;
>>
>> / {
>>     /* #*cells are here to keep DTC happy */
>>     #address-cells = <2>;
>>     #size-cells = <2>;
>>
>>     aliases {
>>         net = &mac0;
>>     };
>>
>>     passthrough {
>>         compatible = "simple-bus";
>>         ranges;
>>         #address-cells = <2>;
>>         #size-cells = <2>;
>>
>>         mac0: ethernet@10000000 {
>>             compatible = "calxeda,hb-xgmac";
>>             reg = <0 0x10000000 0 0x1000>;
>>             interrupts = <0 80 4  0 81 4  0 82 4>;
>>         };
>>
>>       mac1: ethernet@20000000 {
>>             compatible = “r8169";
>>             reg = <0 0x10000000 0 0x1000>;
>>             interrupts = <0 80 4  0 81 4  0 82 4>;
>>         };
>>
>>     };
>> };
>>
>> dtdev = [ "/soc/ethernet@10000000”, “/soc/ethernet@f2000000” ]
>>
>> There is no link which dtdev entry belongs to which node. Therefor there is no way to link the vMasterID created to pMasterID.
> 
> I agree there is no link today. But we could add a property in the
> partial device-tree to mention which physical device is associated.
+1

And we already have this property in partial device trees for dom0less domUs:
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/arm/passthrough.txt;h=219d1cca571b01bc8f0afbbe64435299547fed75;hb=HEAD#l104

FWIK, the solution proposed in this thread was chosen due to the fact that at the moment we do not parse the partial device tree in libxl.
But if this is a way to go (to reduce the complexity in Xen), then it will allow us to drop the need for both specifying vMasterID and iommu_devid_map.

> 
> With that, I think all, the complexity is moved to libxl and it will be
> easier for the user to use vIOMMU.
> 
> [...]
> 
>>>>>>   iommu_devid_map = [ “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS” , “PMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS”]
>>>>>>   • PMASTER_ID is the physical master ID of the device from the physical DT.
>>>>>>   • VMASTER_ID is the virtual master Id that the user will configure in the partial device tree.
>>>>>>   • IOMMU_BASE_ADDRESS is the base address of the physical IOMMU device to which this device is connected.
>>>>>
>>>>> Below you give an example for Platform device. How would that fit in the context of PCI passthrough?
>>>> In PCI passthrough case, xl will create the "iommu-map" property in vpci host bridge node with phandle to vIOMMU node.
>>>> vSMMUv3 node will be created in xl.
>>>
>>> This means that libxl will need to know the associated pMasterID to a PCI device. So, I don't understand why you can't do the same for platform devices.
>>
>> For the PCI passthrough case, we don’t need to provide the MasterID to create "iommu-map” property as for
>> PCI device MasterID is RID ( BDF ). For non-PCI devices, MasterID is required to create “iommus” property.
> 
> Are you talking about the physical MasterID or virtual one? If physical
> MasterID then I don't think this is always the RID (see [1]). But for
> the virtual Master ID we could make this association.
> 
> This still means that in some way the toolstack need to let Xen know (or
> the other way around) the mapping between the pMasterID and vMasterID.
> 
> [1] Documentation/devicetree/bindings/pci/pci-iommu.txt.
> 
> Cheers,
> 
> --
> Julien Grall
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 18:13:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 18:13:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431143.683747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo7NS-0003cF-4J; Thu, 27 Oct 2022 18:13:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431143.683747; Thu, 27 Oct 2022 18:13:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo7NS-0003c8-0B; Thu, 27 Oct 2022 18:13:14 +0000
Received: by outflank-mailman (input) for mailman id 431143;
 Thu, 27 Oct 2022 18:13:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4k8K=24=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1oo7NQ-0003c2-D2
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 18:13:12 +0000
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com
 [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 01b50e3d-5623-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 20:13:09 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 95F273200ACA;
 Thu, 27 Oct 2022 14:13:05 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Thu, 27 Oct 2022 14:13:06 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 27 Oct 2022 14:13:03 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01b50e3d-5623-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1666894385; x=
	1666980785; bh=yHOCAXYXPvmZdJ2Y3WExOCbtnTnjCGpfS6blLilQoBY=; b=O
	ZaA2L0RmJE0afsVed7G17BCN/0QzsvBTDH61xUMG2qlcQPUB/yPQecRL5phb2Fb/
	3T3VPohi2y7kLC8DKqb8BraHoUvBfb7Mx/GRc2EWMYO2E4eFzj69sCYhM1O93+QJ
	Hn/AEpJac+I+3VIylEb+77ibcezm/0fMi/fIOs4Q/pCdGy4yqvbJdFL8+IhNpewQ
	PRBab2QZO724LnW7YUd3mUVjFZSWu+Ap2RRolhFoPogX4SJCxoZRU4I6SHawKZz7
	P/rf7zr8o72UrjfvvODYedud+OTHbdV31dBcwLrQScn89PCJ1S6/z4s45YCsMUAI
	wNF3AUumYlU64miWZa0hg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1666894385; x=1666980785; bh=yHOCAXYXPvmZdJ2Y3WExOCbtnTnj
	CGpfS6blLilQoBY=; b=OwdjQOBFOerlE0dSfISAuvhbXwLMJFFidooqvkIA6cvB
	udYH3EltDa7oMtmlHHiMlsR2/JVAwPDZhljycYeU3ieXZCY6CrjhOcp8HVSTlWvA
	BvrD5kpnSgEqXVVa3/tJLS/EuKMCEHqtrdjIt6MpzQD56p1+1YXNJOU2Bj5uqR+z
	9V9DPl/gx6rDtX3RXu6cv/5vNiP84i7Znbbml0IXUcI8MvQOB1HM+OROJ80PaTE4
	k8GUUz/A2SI9ljnRiW7CN509pNQY8sPYl9Rgo5wk79iIjvUlFfrJ24EDqqdbMfA4
	2Eb49nYEODILZZcfjRkl+us5NdtlQMSWs2vVsTWX2Q==
X-ME-Sender: <xms:MMpaY2HfGLWiuTU_jVwjsUjUnK3K25ZWIxshtkMGUyDxtTqh_jlQQQ>
    <xme:MMpaY3VeqsfcsXsBUcTa4rQOOD4mfy3r8CS69LritKdpkWx8njFfZftNaVM0F1XWb
    Osvkw_9PR9mEQ>
X-ME-Received: <xmr:MMpaYwKuo5WVpFKUqS5TbiJIM4jhbhdUt236pkG1_mwR6NyJ6FTRWEjK5jDz-uf305-ejSfev7JW_VY_YWBxQVxANwyq6VyRleMA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeggdduvddtucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv
    khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh
    hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu
    leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh
    hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk
    sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh
X-ME-Proxy: <xmx:McpaYwFPwi_pH-g0q10dE_axtM_0ZrYWjBGIiT7fyMCpZDHOtlbvoQ>
    <xmx:McpaY8VN5tetw3IIKKbkBos6pyIXL3rsXiL817QB7lQwya5uX0CO4A>
    <xmx:McpaYzO3cN_wyA6qjrwUZOw34sGjUn8LYBaEDKhOVTIBZnaZTEZttQ>
    <xmx:McpaYzSwV9zJL3mGEfyEztCy2FHtDtP2F0IxB8-X2JMFFKCSk_tYQw>
Feedback-ID: i1568416f:Fastmail
Date: Thu, 27 Oct 2022 20:13:00 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
Message-ID: <Y1rKLJP/p+E+eVi7@mail-itl>
References: <20221021145357.17931-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="dMEw57xvfhB1YxK7"
Content-Disposition: inline
In-Reply-To: <20221021145357.17931-1-jgross@suse.com>


--dMEw57xvfhB1YxK7
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Thu, 27 Oct 2022 20:13:00 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend

On Fri, Oct 21, 2022 at 04:53:57PM +0200, Juergen Gross wrote:
> Today all timers are migrated to cpu 0 when the system is being
> suspended. They are not migrated back after resuming the system again.
>=20
> This results (at least) to problems with the credit scheduler, as the
> timer isn't handled on the cpu it was expected to occur.
>=20
> Add migrating the scheduling related timers of a specific cpu from cpu
> 0 back to its original cpu when that cpu has gone up when resuming the
> system.
>=20
> Signed-off-by: Juergen Gross <jgross@suse.com>

I tested it in my setup, but it crashed:

(XEN) arch/x86/cpu/mcheck/mce_intel.c:770: MCA Capability: firstbank 0, ext=
ended MCE MSR 0, BCAST, CMCI
(XEN) CPU0 CMCI LVT vector (0xf1) already installed
(XEN) Finishing wakeup from ACPI S3 state.
(XEN) Enabling non-boot CPUs  ...
(XEN) Platform timer appears to have unexpectedly wrapped 3 times.
(XEN) ----[ Xen-4.17-rc  x86_64  debug=3Dy  Tainted:   C    ]----
(XEN) CPU:    0
(XEN) RIP:    e008:[<ffff82d040250c7e>] sched_migrate_timers+0x4d/0xc9
(XEN) RFLAGS: 0000000000010202   CONTEXT: hypervisor
(XEN) rax: ffff82d0405c5298   rbx: 0000000000000000   rcx: 0000000000000001
(XEN) rdx: 0000003211219000   rsi: 0000000000000004   rdi: 0000000000000001
(XEN) rbp: ffff830256227d20   rsp: ffff830256227d18   r8:  ffff82d0405d2f78
(XEN) r9:  ffff82d0405ef8a0   r10: 00000000ffffffff   r11: 00000000002191c0
(XEN) r12: 0000000000000000   r13: 0000000000000001   r14: 0000000000000004
(XEN) r15: 0000000000000000   cr0: 000000008005003b   cr4: 00000000003526e0
(XEN) cr3: 0000000049677000   cr2: 0000000000000070
(XEN) fsb: 0000000000000000   gsb: 0000000000000000   gss: 0000000000000000
(XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: 0000   cs: e008
(XEN) Xen code around <ffff82d040250c7e> (sched_migrate_timers+0x4d/0xc9):
(XEN)  48 8b 14 ca 48 8b 1c 02 <39> 7b 70 74 51 48 8d 05 56 34 37 00 48 89 =
e2 48
(XEN) Xen stack trace from rsp=3Dffff830256227d18:
(XEN)    0000000000000001 ffff830256227d58 ffff82d04023f1a0 ffff82d04047a308
(XEN)    ffff82d04047a300 ffff82d04047a060 0000000000000004 0000000000000000
(XEN)    ffff830256227da0 ffff82d040226a04 0000000000000000 0000000000000001
(XEN)    0000000000000001 0000000000000000 0000000000000001 ffff830256227fff
(XEN)    ffff82d04046c520 ffff830256227db8 ffff82d040207e75 0000000000000001
(XEN)    ffff830256227de0 ffff82d040208243 ffff82d04047a220 0000000000000001
(XEN)    0000000000000010 ffff830256227e18 ffff82d040208428 0000000000000200
(XEN)    0000000000000000 0000000000000003 ffff830256227ef8 ffff82d0405de6c0
(XEN)    ffff830256227e48 ffff82d04027a2df ffff830251491490 ffff830251757000
(XEN)    0000000000000000 0000000000000000 ffff830256227e68 ffff82d040209c73
(XEN)    ffff8302517571b8 ffff82d040479618 ffff830256227e88 ffff82d04022e484
(XEN)    ffff82d0405c41a0 ffff82d0405c41b0 ffff830256227eb8 ffff82d04022e76e
(XEN)    0000000000000000 0000000000007fff ffff82d0405caf00 ffff82d0405c41b0
(XEN)    ffff830256227ef0 ffff82d0402f455d ffff82d0402f44e5 ffff830251757000
(XEN)    ffff830256227ef8 ffff8302517f5000 0000000000000000 ffff830256227e18
(XEN)    0000000000000000 ffffc90040b43d60 0000000000003403 0000000000000000
(XEN)    0000000000000003 ffffffff82e37868 0000000000000246 0000000000000003
(XEN)    0000000000003403 0000000000003403 0000000000000000 ffffffff81e4a0ea
(XEN)    0000000000003403 0000000000000010 deadbeefdeadf00d 0000010000000000
(XEN)    ffffffff81e4a0ea 000000000000e033 0000000000000246 ffffc90040b43c30
(XEN) Xen call trace:
(XEN)    [<ffff82d040250c7e>] R sched_migrate_timers+0x4d/0xc9
(XEN)    [<ffff82d04023f1a0>] F cpupool.c#cpu_callback+0x13d/0x47e
(XEN)    [<ffff82d040226a04>] F notifier_call_chain+0x6c/0x96
(XEN)    [<ffff82d040207e75>] F cpu.c#cpu_notifier_call_chain+0x1b/0x36
(XEN)    [<ffff82d040208243>] F cpu_up+0xaf/0xc8
(XEN)    [<ffff82d040208428>] F enable_nonboot_cpus+0x7b/0x1ef
(XEN)    [<ffff82d04027a2df>] F power.c#enter_state_helper+0x156/0x5dc
(XEN)    [<ffff82d040209c73>] F domain.c#continue_hypercall_tasklet_handler=
+0x50/0xbf
(XEN)    [<ffff82d04022e484>] F tasklet.c#do_tasklet_work+0x7b/0xac
(XEN)    [<ffff82d04022e76e>] F do_tasklet+0x58/0x8a
(XEN)    [<ffff82d0402f455d>] F domain.c#idle_loop+0x78/0xe6
(XEN)=20
(XEN) Pagetable walk from 0000000000000070:
(XEN)  L4[0x000] =3D 00000002517fb063 ffffffffffffffff
(XEN)  L3[0x000] =3D 00000002517fa063 ffffffffffffffff
(XEN)  L2[0x000] =3D 00000002517f9063 ffffffffffffffff
(XEN)  L1[0x000] =3D 0000000000000000 ffffffffffffffff
(XEN)=20
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=3D0000]
(XEN) Faulting linear address: 0000000000000070
(XEN) ****************************************

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--dMEw57xvfhB1YxK7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNayi0ACgkQ24/THMrX
1ywtEwf/RtLpNcPpYjAHTuJpdiUQS46/uilMBQzJ9WbnatCUEPfyPNCyr/I1IaYE
PzOL6m39i3d5sKsbIyVoKLfoMY6A16WG8BufCU82vkBXADMcaDPAq2OAk11awu5m
4YbEJMqMl1/YiJ3Au/Qaga3QQI1juLvHKvLrICVQMb/RBgTfmsRQmZ48+Ru1kSej
9lyWZm+PdX3WDnfKgqf0v/BVpC3Z5OOggUtoEYOXvc6ksTXbT0V5/AeFGHRQsqzu
vH/PrEX0YxA0qfrkTAlRunxRp+dZ3W9faCuJ7IgK/w1lzpXZ85O/QvQgKIW85Mh6
MGYjdnWgQ6fRuRqAlGQn+IwKQ7Q7Pg==
=u11S
-----END PGP SIGNATURE-----

--dMEw57xvfhB1YxK7--


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 18:17:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 18:17:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431149.683758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo7RY-0004W5-P6; Thu, 27 Oct 2022 18:17:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431149.683758; Thu, 27 Oct 2022 18:17:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo7RY-0004Vy-Lp; Thu, 27 Oct 2022 18:17:28 +0000
Received: by outflank-mailman (input) for mailman id 431149;
 Thu, 27 Oct 2022 18:17:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo7RX-0004Vm-MV; Thu, 27 Oct 2022 18:17:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo7RX-0000bg-G0; Thu, 27 Oct 2022 18:17:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo7RW-0001Wb-Pq; Thu, 27 Oct 2022 18:17:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo7RW-0005FO-PM; Thu, 27 Oct 2022 18:17:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dED8+63Bp158l6/le1TfRiufCcV+/7b99j8vQI3WWG0=; b=P4eJ8aGjrB+Gurfi+f8Oa+XqjN
	72P+DcQMOqRm8ldPH8ODm8jI0g/uB4vrFJkjsI52dwqvLt4sxEjC9u8GD8Vg6O94R8HNdr+1QC2DP
	4aC8rxrH0KRImVoqwp+6TqWGBtGu2Ieh6J/YYS2INmZQuJdS0JiqMqCCqkKeMcEa1erI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174470-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 174470: tolerable trouble: fail/pass/starved - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:build-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking
    xen-4.14-testing:build-armhf:hosts-allocate:starved:nonblocking
X-Osstest-Versions-This:
    xen=96220aec3e72b9d71600d78958b60e77db753b94
X-Osstest-Versions-That:
    xen=4ed063a71bf9ec291a1b71d0b7b36c0416ca544d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 18:17:26 +0000

flight 174470 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174470/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172550
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 build-armhf-libvirt           1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               starved  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl           1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               starved  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               starved  n/a
 build-armhf                   2 hosts-allocate               starved  n/a

version targeted for testing:
 xen                  96220aec3e72b9d71600d78958b60e77db753b94
baseline version:
 xen                  4ed063a71bf9ec291a1b71d0b7b36c0416ca544d

Last test of basis   172550  2022-08-15 14:37:34 Z   73 days
Failing since        173496  2022-10-11 14:08:01 Z   16 days   16 attempts
Testing same since   174470  2022-10-26 19:06:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  starved 
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          starved 
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          starved 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  starved 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  starved 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  starved 
 test-armhf-armhf-xl-cubietruck                               starved 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     starved 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                starved 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               starved 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 starved 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     starved 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      starved 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4ed063a71b..96220aec3e  96220aec3e72b9d71600d78958b60e77db753b94 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 18:56:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 18:56:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431175.683844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo832-0001oK-IK; Thu, 27 Oct 2022 18:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431175.683844; Thu, 27 Oct 2022 18:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo832-0001oD-Ey; Thu, 27 Oct 2022 18:56:12 +0000
Received: by outflank-mailman (input) for mailman id 431175;
 Thu, 27 Oct 2022 18:56:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oo831-0001o7-Hn
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 18:56:11 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 02efae9a-5629-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 20:56:07 +0200 (CEST)
Received: from BN9P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:13e::27)
 by DM8PR12MB5414.namprd12.prod.outlook.com (2603:10b6:8:3e::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct
 2022 18:56:04 +0000
Received: from BN8NAM11FT023.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:13e:cafe::46) by BN9P220CA0022.outlook.office365.com
 (2603:10b6:408:13e::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.29 via Frontend
 Transport; Thu, 27 Oct 2022 18:56:04 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT023.mail.protection.outlook.com (10.13.177.103) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Thu, 27 Oct 2022 18:56:03 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct
 2022 13:56:03 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Thu, 27 Oct 2022 13:56:02 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02efae9a-5629-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kKF/z7UXvywn+k8JWALLnz8+i02WsEzZptiQdXu+JXrUpmIJzDaUUEoDG5qn0FDCADbCrYvOAWrUyItxNrGVFlUhicQuuaUOdYrXpE3mIejxZrxYxoj1H+72ybb2EEEIAlz5jL08gevBpOzPFp9C7ZjHlRfRIrWhvAXQ0s7flE/LCWL9aUfi/3au8S+3nelVJa3n4je3NGNkdiXcWgQ6zz0wD05W3ZNz8xziLioO1nDnlF7miJ8WxBHBrpaIbTL4E2g+Izopr4tCc9+2TFW/+vAW1bsvGb8exq4/On6pjJKFCEQGth90u6zMOo2vNZz3bYuHhmGbUek0O7Tt/7hKOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zpk5LJ+b5vdvJSP5Ee92XUw++nWgxcwlfOU25UtZHvU=;
 b=Zq6hwKZBvZbe6Qu4HeJOsJHfQ4kE5IQK2cACp+9frOgPedw7s2mBYr4yBUbAr1+72HYnZ+UMq5+6xy+4/8BL6GfeKOK/I0hlBKhnWuuZdxxV1uqJZZm6WUrbJf1nE3HE7is3mP94c+ytvscba41wf5YYnrvi1PjbzPfRtnWPYidOTnyfmoTeFoltHlsMs42rD6NImUIRa+OwFs3ofWZVq2QdBJTUEtdGKjfty3YeHCUpS72H0R+9uokSCYjjjkoDr2E45/L6w7sr3MdwcMWvqj6FT/Yw/fxHqHOcZQ4eb8JoRZA6iDl23KC+5IxSDCFNZvN1CJKB5rknk+rICKaIkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zpk5LJ+b5vdvJSP5Ee92XUw++nWgxcwlfOU25UtZHvU=;
 b=41LlDooqmcd+ozMofD9K1XTI4MT10QOwTcg4nH+5NtnwKKb6Zq22fsItAVa00JKVxY0P673X4bH6j6cAP0UmiB3CJPJUKjKIHpQiKmpICpjMlMfyRy3BtWS3KPPJ8Z6evR7ZUC+b4tcqU06dkprQ9S9KkhmRGcx52cUJILZ+zhA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<andre.przywara@arm.com>, <Henry.Wang@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [XEN v5] xen/arm: vGICv3: Emulate properly 32-bit access on GICR_PENDBASER
Date: Thu, 27 Oct 2022 19:55:55 +0100
Message-ID: <20221027185555.46125-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT023:EE_|DM8PR12MB5414:EE_
X-MS-Office365-Filtering-Correlation-Id: caa1efe6-fd12-40d7-aa3d-08dab84ce5db
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BIJ+cGnKrkEfj1yfIPNCuwBY4xjcbZNk2TL/qO7mtjkXPDT0n/NhJXNk3vWUP+1cPDiiT+HnzBOBesPmYfeV88nqzPjYl62FU837GAJQq4g6oClOXC/nSgNIPcWqtqXZmy5Tf0p1TX4dOY3OfIWWp6tEHm8C6ReZL4x+GW0OpPYj7VzqxsH877XLP5aVwDnb/ICUXMuT29MSVnHOHAlNERfIKmPgn29pqwYCYIVdgZROX9wK3JOWqphPffANaPGYO+/4W1+kPwQ2GsSbG944zu2vtQN4qqSJIRvUXOf5ydF8bi43qkSfZt+QxcdBV4RrRNoBrz85wPt0U9U1skAXO//SwFsj4RKnjSsu5ewahT9xmM5dQtF3OmJl/2fuaEq/mqlxMwKG9BcBFnvL88auA5UbKgYzQKqSFbDc1FIWkmPcUGzIzix+f4hRcQ16LiK8kM8d/RmsFjDzyr1d7doTlZTsI5IAGFx2IWEwgE/8Fd38pcr6BWo/SnRTJDyTc5ieD+E4LH9Ydi8mMAqC7bL6k1P5120mlx6U0FfuA6V8q8+iU0/SuR6tAmcrcG4qmZANmEzrQ1MK2Fp6U39Qgkh18xHGG8l68paqFuFP+OXZF0e3It+xpAkbzL42jZEGydXDctsU/idaAQJlFy5Q1laWlUkt+7wz22gw/qroC1EP9i9vkT8JbPEgk8J6jJExLiZsgOiuUsaCNxPciFwgGUeFlGdAQ3LkQUlzBw17J+MgOqP9oluJRoxqHLNwcaTg/5LyrYzvJGRdnKFIWztuQ1iwlr/7UaFioYVO1OtVxhQ96EmIDyOoqu7Zjl3MyOJHH6Cy
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(336012)(5660300002)(8936002)(1076003)(47076005)(426003)(356005)(41300700001)(36756003)(4326008)(186003)(40480700001)(81166007)(6916009)(54906003)(36860700001)(316002)(82740400003)(6666004)(40460700003)(26005)(8676002)(82310400005)(478600001)(2906002)(70586007)(2616005)(70206006)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 18:56:03.9281
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: caa1efe6-fd12-40d7-aa3d-08dab84ce5db
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT023.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5414

If a guest is running in 32 bit mode and it tries to access
"GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
will return the value stored "v->arch.vgic.rdist_pendbase + 4".
This will be stored in a 64bit cpu register.
So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
in the lower 32 bits of the 64bit cpu register.

This 64bit cpu register is then modified bitwise with a mask (ie
GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
64 bit cpu register) is not cleared as expected by the specification.

The correct thing to do here is to store the value of
"v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
vreg_reg64_extract() which will extract 32 bits from the given offset.

Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_read(). The reason
being v->arch.vgic.rdist_pendbase is now being read in an atomic manner.

Similarly in __vgic_v3_rdistr_rd_mmio_write(), we have used read_atomic(),
write_atomic() to read/write v->arch.vgic.rdist_pendbase.

Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
---

Changes from:-

v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
appropriate commit message.

v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
v->arch.vgic.rdist_pendbase in an atomic context.
2. Rectified the commit message to state that the cpu register is 64 bit.
(because currently, GICv3 is supported on Arm64 only). Reworded to make it
clear.

v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
in __vgic_v3_rdistr_rd_mmio_write().
2. Removed spin_lock_irqsave()/spin_unlock_irqrestore() for access to
v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_write().

v4 - 1. Retained the spin_lock_irqsave()/spin_unlock_irqrestore() for access to
v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_write(). This is because
there could be a potential race while read-modify-write is performed on
v->arch.vgic.rdist_pendbase, with another caller performing the same operation.

 xen/arch/arm/vgic-v3.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..d0e265634e 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
 
     case VREG64(GICR_PENDBASER):
     {
-        unsigned long flags;
+        uint64_t val;
 
         if ( !v->domain->arch.vgic.has_its )
             goto read_as_zero_64;
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
 
-        spin_lock_irqsave(&v->arch.vgic.lock, flags);
-        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
-        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
-        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
+        val = read_atomic(&v->arch.vgic.rdist_pendbase);
+        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
+        *r = vreg_reg64_extract(val, info);
         return 1;
     }
 
@@ -577,10 +576,10 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
         /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
         if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
         {
-            reg = v->arch.vgic.rdist_pendbase;
+            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
             vreg_reg64_update(&reg, r, info);
             reg = sanitize_pendbaser(reg);
-            v->arch.vgic.rdist_pendbase = reg;
+            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
         }
 
         spin_unlock_irqrestore(&v->arch.vgic.lock, false);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 19:09:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 19:09:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431180.683854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo8Fy-0003rV-RC; Thu, 27 Oct 2022 19:09:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431180.683854; Thu, 27 Oct 2022 19:09:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo8Fy-0003rO-OO; Thu, 27 Oct 2022 19:09:34 +0000
Received: by outflank-mailman (input) for mailman id 431180;
 Thu, 27 Oct 2022 19:09:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oo8Fx-0003qz-8d
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 19:09:33 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e2a7f436-562a-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 21:09:32 +0200 (CEST)
Received: from DS7PR03CA0275.namprd03.prod.outlook.com (2603:10b6:5:3ad::10)
 by SA0PR12MB4511.namprd12.prod.outlook.com (2603:10b6:806:95::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Thu, 27 Oct
 2022 19:09:27 +0000
Received: from DM6NAM11FT057.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:3ad:cafe::e3) by DS7PR03CA0275.outlook.office365.com
 (2603:10b6:5:3ad::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Thu, 27 Oct 2022 19:09:27 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT057.mail.protection.outlook.com (10.13.172.252) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Thu, 27 Oct 2022 19:09:27 +0000
Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct
 2022 14:09:26 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com
 (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct
 2022 14:09:26 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Thu, 27 Oct 2022 14:09:24 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2a7f436-562a-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n2xfodyO+wMwjJB7nN+HGe/r7IiBJsouSPAliaPZTRz+qJ++Zy6qhdFW2ANt/YsBFunEo127hO+bTLAbGVq2m/pHypB08al36qDcLO4n2Kmnv8EuGGWcS5v2sKpNcbBEHVJchMdO/WNDHVAfB3grTL5voshXPCoDWBXB6XeIOgnXy0yciwC7Bg3e8raBOLysseB6zE9/xVPmFej15iM6Ieq4PkxkicSOzsV8O1QE2O8uZegKACx+MrNQpUylREa+qv0VUVt3W11erPGdZARkYTwqIbvsfQLl5Ldiv3Q2wmDjUU02Kh7sADsXVwZrcwpUOE3Cjwhu64VtUtJcxibHiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8FeIMOJGH/45YEpzVXFBG3/d4t87OUAvpO4VLLRjPlc=;
 b=O3Q3VilCj6s+4hJ1o7ZzfSg+4XLYshJ4Q1lYMfPUjjvUhFtohZlDYSDozoZ6d/QVXGQVjy20aasEHGAdffsvFL8jYmChYKYuptVrET8CeeSGejSYKAePj4zJfWV78iffMotX0P7jxqcwciqa7CZ5kxJ+Hvk8spF/homnevfZnGsw3d4UpvJcrSNF+R5D3l6W3S3XsxLK8YYn43y9KYhBbzvWlw/9ccoLVWFRBTedW1nMmdWChXh23P/HA41eSOBwTWpm+FxrM95/N0Xw/sNuNY+j/x7XWDnaZgp1gGZmKQCNlhKgiaMt3eTOuz+3fWtE2ZLktZUerprhl5k1IHX3Ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8FeIMOJGH/45YEpzVXFBG3/d4t87OUAvpO4VLLRjPlc=;
 b=gKcNrA25kQGxHe/elDshg2Z6J+yweYrMdUjlNIEuj7yjPRe0E3RaJatDPJ1mFx8EJBYaULMQGDeCS/7aTSwZ5vJkdV+DaMk++04FHGD2BKUBVi0E4pKNN8CvzLQjfY6+2UfOswTYwJY6rR5G9Fb6hhVd7tcE8CRkzTPwa4c5cLI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<andre.przywara@arm.com>, <Henry.Wang@arm.com>, Ayan Kumar Halder
	<ayankuma@amd.com>
Subject: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
Date: Thu, 27 Oct 2022 20:09:13 +0100
Message-ID: <20221027190913.65413-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT057:EE_|SA0PR12MB4511:EE_
X-MS-Office365-Filtering-Correlation-Id: e8cfef07-e595-47c3-0ee5-08dab84ec499
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8vBnDcoUNChln3F+i1yGeMHR8BjA+lTohT3dh40uBHW5+hIaCQuE2ryvVoAryYS9I+HQrrl92ZUbISavLvOI4HlWiPjcKx71DDKtvobwtXkAS4DalCGPIxBIAsadiWF638XbQeuc/r8/BxWXdkTTkisOt+cVou7nDwNESVmC0WOKCe/two8FHUijXHP6OqMXl6pdv8lsTOsNxsVA2vbqrWDzRdl6xZdiAd5fvn6QL2L4ZWTKwYw2x92jzABLbcrLgvFKlQmoitXqVRMvxST2e4hBR105ksKt9n7WDXk7vj6FS+aylN+AfFIvwp8mGutFomg8lZlGV1nQQj/T/AhzFtQesMpyqYGEyYrZI7pfL1Uhvn+BsFy87ybO9EY42XJXxo1KxQ1/2+pJyiy+zdAHDSyPVhNvy9aFF1V1b+Qlv6D+adyPD1nquT0HTfm76jTjhHuVoUBPJGZzlULt0RrOcwaYAcVWDieY7aG6Qsi67ouHArCVvhzlS7wfLcJTlR/2Xtu44N9FJxXNr20YOYsYI6gOd8A7OLwKfL225XgfntoEbBeH2xEUO4GgFJKq3AoaLWCiZ64DolF+aM4L10Ylb0KrRC1uATIRZY+2OLyBsMimLnQsbWz6b2ULnHYpn4WuL4vd0VQVZUjNHe8WWMO78GJ/phQ9zHvwZDTqycQZ6jeZNg7HkqQtd7rZFC2cjJu9hqibNzN7uoBUpzaJC14epP4NoFhmrvhHEP1DiIhvz1GGjScXLI9fviVfFyYdNeeCowBP5+qOCTVW7zje+bcPmGGaQxiLxm7AtcUFy+cBplGErG+Rn4kKKTHZaDyXAWz+
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(426003)(47076005)(316002)(70586007)(8936002)(356005)(6916009)(54906003)(36756003)(81166007)(82310400005)(40480700001)(82740400003)(70206006)(8676002)(4326008)(26005)(83380400001)(2616005)(40460700003)(4744005)(36860700001)(1076003)(6666004)(336012)(186003)(478600001)(5660300002)(41300700001)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 19:09:27.0890
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e8cfef07-e595-47c3-0ee5-08dab84ec499
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT057.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4511

As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt
state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should be
used to restore the saved interrupt state.

Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---
 xen/arch/arm/vgic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index d0e265634e..015446be17 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
             write_atomic(&v->arch.vgic.rdist_pendbase, reg);
         }
 
-        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
+        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
 
         return 1;
     }
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 19:12:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 19:12:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431184.683866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo8Io-0005Fe-8l; Thu, 27 Oct 2022 19:12:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431184.683866; Thu, 27 Oct 2022 19:12:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo8Io-0005FX-5m; Thu, 27 Oct 2022 19:12:30 +0000
Received: by outflank-mailman (input) for mailman id 431184;
 Thu, 27 Oct 2022 19:12:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9cef=24=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oo8Im-0005FQ-Du
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 19:12:28 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2047.outbound.protection.outlook.com [40.107.237.47])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4b08f30f-562b-11ed-91b5-6bf2151ebd3b;
 Thu, 27 Oct 2022 21:12:27 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by DS7PR12MB6022.namprd12.prod.outlook.com (2603:10b6:8:86::7) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.28; Thu, 27 Oct 2022 19:12:22 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 19:12:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b08f30f-562b-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dHds+dUwuccWtCj37Z1OdMZayIrOte/0kHUxMwQtwmyJOpt3N2mZHWnuVaz6sNytChAWZPX3PTNw1luaKf6QF8AYl1LOXgVaBv/3Jsuqb9++vMQ8vfJlBWwu/bnakC+duo47thNOwJy6PusWQw4aVy4K6AE5VZHegJazbIUgxtpNdzGdZcDzHuIltYue150A/ZaDIU67SpVpzBmQsF+BMydf3YPIBVIPQoIK8j+zZcoDhtHKfmcIxUT83ICRTnh5I8Ty1/1ImNuj7C8bobyzJD+aie69gpSPnphce9I6Bh+FRjTn6tYycdgwJFkwYSxF9S89bLHOF1Kx4TJ7HJVH5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AY3lAEWtu5RtLdURwFBuSeggbt985FW2mT1VEk8w7p8=;
 b=Yoqyv4VYpcb04vA3Xv+T7umzlx+Or9L1yn15HMFxQLrTn9nGv0uSJIQypBquEse7o52q0O5NB7uR1W09AZMt7nZePQ4jvb3D1zagCBj7ectzfujTXAxlBUlzPpAhV3OBsBFchEdS5WfysNme4zz0tqG3MddNRDulaTIeONvRdz+vsNSw+7D+eooUyfUe4gfNUBrFF71n2iC7K9YONGV9Ys05UFLzpgHVKbggfEIfgElvydaphPCsB6vPyNBFGI2JSnZ5R0U5uto6u4xeyme9HslJxCMWmAxxf/UUAbCw6RwfHKILkQ1htFdxj4FYOrq3otR9F8zW4TjBTL40YagmOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AY3lAEWtu5RtLdURwFBuSeggbt985FW2mT1VEk8w7p8=;
 b=Ik5iYj3P1jeULV3Sg1qFK57nCZrcDm1B/1yVc95YSOYA+R6X4Kz/YUDLr3DpeaPbeNgDRpMVcGFFA4J+6eMkd/rLKJmBczVVcQD2xDvLSiA6tU1+cSQKLaYbQYzlbfZOMrQUI730WTz/duQRKsvwMlV05Ey6vz1OT/6jSkuNhz4=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <6f6e2f21-b138-0b89-8de3-58c86aa9f44f@amd.com>
Date: Thu, 27 Oct 2022 20:12:16 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v4] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
To: Julien Grall <julien@xen.org>, Andre Przywara <andre.przywara@arm.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 Henry.Wang@arm.com
References: <20221026183004.7293-1-ayankuma@amd.com>
 <20221027104231.77c5cd28@donnerap.cambridge.arm.com>
 <da52b703-5de7-1673-f6a1-d6541f59f5cd@amd.com>
 <d9779975-9b47-bc3f-7cb0-508165ebc707@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <d9779975-9b47-bc3f-7cb0-508165ebc707@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0510.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:13b::17) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS7PR12MB6022:EE_
X-MS-Office365-Filtering-Correlation-Id: 686aeb09-d98b-44c7-91e3-08dab84f2d15
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5Jd5yS4Bi5YBgmgPVZ05rjaZzcfA4LM1iHttAjvfzxTXr8uXNLXOyBuo1SH0Nzkvqs/dP5+4XlbYXwcY3a/zdlEg5mKZTjnk9ZuMQugNG45g7fopQWKJUjGJLdv+9KS2cP0nLtkVvXehyJc0SPgZWY07eBqlucVJPXIShMc74PU/bbGU+ZR3+HheOvC5WsGSmfpBTo2XRPEBTdqL4EiwA3aow6zFUW6YBPwjvilNDwj75Eyr5ZZmtr10/ZZ3HH0kx5AHn8IjzWLxZqTG0SIi6rPf+NOaw+Jjm9wwwVj1sZHAHuzZ1VPp5gHoPD7Dyq9w1+PvW31OV8QtjZYqEhQTQkLqubS4bBV70w+GF+bGnt66lCBqQzHVXfWoo+OBRKNTB9RnhYDSCTsqo5oRRJGXDAagyuai1//DuxUKL6v8G+z6WNwyc17IzSB+s2CjJBbZwE9z5YgJJbqXgBk9rHzlZpMfdiCnABpH5i/xkMLf4iP0Tp3MgeounONI7cYb93radwr610tuoxnlvrrDhADdyejgOij0vd0pn1aNaKbXu/mnFkXKIon/DroE5uA8TxqT5ZF6W6caqbiJmMmNetLpT9jO9Tbk//Bq+a/CG/t/N8eev6cpliTnro1Z/rkuQ1/hb+2a+zoJQ20MBGHRIcbAWqgPMVvLLwN0JZ1R1l4wWjihL+tfGB6uL69MlpXjNR6JdOtUo64gAMRHJSB16rJQgumonquq0lgMPAVLKlfGBrCK/nbvRFYYssnS1PFZ/pGM0zv7dpNF+pcuvwlmutwzhZjsZ/XYyJhVFuxtTSHOzs4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(451199015)(5660300002)(8936002)(26005)(36756003)(6512007)(83380400001)(38100700002)(41300700001)(2616005)(186003)(2906002)(6486002)(478600001)(6666004)(31686004)(110136005)(316002)(66556008)(66476007)(53546011)(6506007)(4326008)(31696002)(66946007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TlRYWGM5K1VZY2VYa3ljV3JnZElNc3p6by9CMUlCT1ZlUEJmenZuMXNnaFkz?=
 =?utf-8?B?UnliRjBIVWRjL29VUXZLcFVubkRzM1VqRHdqOWV4Q2p1Vk1OeUl6MnorMEpW?=
 =?utf-8?B?Z1lhZm9mVlZkU0lNb3o4RExWSjNaaG1nd29xTWQzZDU3NGdCQ2dnNzVXOU93?=
 =?utf-8?B?WlhHWUYvckNLd3RYUnlTYnFhbVNpMFZ6d29DbWRNU3RCZ0YvNU0zdVk4NGJ5?=
 =?utf-8?B?aVJIeHVQdEljWHRFR2dVMGpleVZPdDg4ODVMaUdVejgvNjZLYTBlNkVORFNt?=
 =?utf-8?B?Wjl6UEVHaDdiVGhQbUpQaFhuTHg5ZEFvenZQbzk3Uk1PWjhURE55a2Z2SFh1?=
 =?utf-8?B?SURiZzBOckpxMGFTRDQ1QzlzR1RTcW80Uzhja2hrSmROUkRjeWtNOHFiWTAw?=
 =?utf-8?B?U2F1M1YwaDgvRHZyR0I0UnZPSUIwSld6d1RmM2ZjMUVOVWFQT09ZanBCSVRx?=
 =?utf-8?B?RFhCVXhiN2JvQmhUaFJCTmtTVXgwNHZweEt6bjZKaDREK1ZFbjJRYVBRREdl?=
 =?utf-8?B?OFN0ZGltejZrcWoyMXZwYUlUdEIxUmV6dXZYL3JReGNZcjRLUzkvT3hxNGpD?=
 =?utf-8?B?MEl3VEF5ZGxGbHRVZUp3QzZjWUxoNUthSTFUOThtaEFrUFByZ3BReU1yL1No?=
 =?utf-8?B?R0tLUjBrZlk2QjFLQVQxdEsyNXp3M0ZGRVk2Ym43eStlTlRLSUQ0Qmdsdktw?=
 =?utf-8?B?Y3VOdnFLampHU2xyamFNZGVjY2VsUzZGcExtRUlGd0JyOEFNVW92bDF1V2VR?=
 =?utf-8?B?ZzBwaStZUVJueEpyQmU4ZDJrVzIyMkx5RVVJWVcvMmFBVmlpY0lUODRaczcw?=
 =?utf-8?B?RzVENVJEMGFjQ0ZUQWhUdTl3VHBYazhSdnlCOFhFdklTU3JVZUdkN205em9Q?=
 =?utf-8?B?M2FlSHF1MUlXYUl5RlhmeWcrdTRZd3JkK3E4YU1jRHppdlpSRnFMR1VsVmZC?=
 =?utf-8?B?ZjNlNDNqR3RwZ3N0cGV3V0pyVjdHWlFlbVdpK0lkMlgyeHdaWEpxazdSc1F2?=
 =?utf-8?B?ODlMVW9IbEdudFV0SGZvK1BPZHlYSTBMS3JGbXVFaTRPaEdGaW1GQ2phRDZj?=
 =?utf-8?B?dlR6UkJsOEdwN054UTVoVytDWGt6QndTcUNzZEgzOURaVWpWNjRJd2ZSaXJh?=
 =?utf-8?B?Yy8zZ1lIcE5Qc1VKS3FOUnVFV2twSitPQXVFeWFQREJlb2ZWVENrdzRXaUdi?=
 =?utf-8?B?cDZnMFppaGRnbDRsSFdaR3NiZytMWGorNFlZWjFtNDFqMXg0cnZLT0dDSGwy?=
 =?utf-8?B?eUU1bEZDU0VoUjdlclR2aHptNzkzTDdaMUpldkx4WjAxWGdBYmdVZDlpZEVr?=
 =?utf-8?B?dG1FQUtUM0RGVzc0eU5JeXRwRXRTN3NTNnBwZ2grZDlaSEVsdWlVOHFHQU15?=
 =?utf-8?B?ZVhkUmU3ZVFkRTlKK2dyTllaWGFvWDA5UEFwTXZvWTIrUVdFK1BDVGZvb05I?=
 =?utf-8?B?MXR6SDluZ0hWM2cycTRMQjhnM2NoWmFnZkMrZGFRMDhsNnVWV29QSEkzc0pV?=
 =?utf-8?B?V1F5bnJvTUNtbFQ5bWZ3NXAvajhvUExSa3NrSkxFYzkxWVZ4Y3RlbTltTklv?=
 =?utf-8?B?eEJyOG1wNDYxblhmYkpqS1V3WU9pcTZsMG1FTEM3eVQrWTA5VFZWdmpvK0Ji?=
 =?utf-8?B?YVlKa2dBM2tGWU5VT1JoS2hNMzkwNmlFdEZoR2JpeW5BcDlCTFBXZi8rVzha?=
 =?utf-8?B?Q0hXRG55VEZNU1d4TklPUkNPcTNYaGxWN0M2ZTV4MXc4bndiOUxjUUxuQWlk?=
 =?utf-8?B?WDFMajZRK05SMG9OVmVjUnQxOWh3YVd6RGlVNFE0R2NrOTY2V3YwaVR2OG40?=
 =?utf-8?B?WVZ1T1hLbXBpNStSZnd2WkVUMVU2LzJYakpMZE9PcUxoSHRjZnFxbFNERFRr?=
 =?utf-8?B?UDdJbTFSMmpDaUtkV2g3TTM5Z0cva29saTRGd2N6STZDQnRVQTQrZGJWYjhS?=
 =?utf-8?B?VmNiclpyUGJKcnJyU0J4bE9FMXhhK1NsVlFLUjJvamd1b2tpTUowSHpFRzZ6?=
 =?utf-8?B?aWJxdXp3djBXK21nVDFHZzBsV0ZnL3VMdnlJNlE0ZzZ4cFlCUVJBcWZ0VmFr?=
 =?utf-8?B?alVxc0FvRUtvM2hqSUtCTERGWWt2eVQ2dFRLcHh2UWdpcmJyUWZTeFpZaW5x?=
 =?utf-8?Q?z5bHiVyabdsRLvyU98x7vRZ5o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 686aeb09-d98b-44c7-91e3-08dab84f2d15
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 19:12:22.7161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZIFDcAMNOI12ckts6FiaE65mbSeteKfRjPOE4ye5ieZfm66e12mIEqRaxmrNK2/gnCV0fXE2ogUp6ec89ET4nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6022


On 27/10/2022 17:13, Julien Grall wrote:
>
>
> On 27/10/2022 16:40, Ayan Kumar Halder wrote:
>>
>> On 27/10/2022 10:44, Andre Przywara wrote:
>>> On Wed, 26 Oct 2022 19:30:04 +0100
>>> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>>
>>> Hi,
>>
>> Hi Andre,
>
> Hi,

Hi Julien/Andre,

>
>> I need a clarification.
>
> I am not Andre but will answer :).
>
> [...]
>
>>>>           /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>>>>           if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>>>>           {
>>>> -            reg = v->arch.vgic.rdist_pendbase;
>>>> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>>>>               vreg_reg64_update(&reg, r, info);
>>>>               reg = sanitize_pendbaser(reg);
>>>> -            v->arch.vgic.rdist_pendbase = reg;
>>>> + write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>>>>           }
>>>> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
>>
>> Shouldn't this be "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" ?
>
> Good catch. Yes it does. The current code will clear DAIF (even if 
> irqsave touch only I). The I/O emulation is done with interrupts 
> enabled usually, so now they are going to be unhandled until 
> leave_hypervisor_to_guest().
>
> This could be a "very" long time. Thankfully ITS is experimental, 
> otherwise I would have considered this a potential security issue.
>
> Can you send a separate patch for that?

Thanks for confirming. I have now sent a patch to address this.

- Ayan

>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 19:37:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 19:37:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431188.683877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo8hB-0008O0-7I; Thu, 27 Oct 2022 19:37:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431188.683877; Thu, 27 Oct 2022 19:37:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo8hB-0008Nt-3q; Thu, 27 Oct 2022 19:37:41 +0000
Received: by outflank-mailman (input) for mailman id 431188;
 Thu, 27 Oct 2022 19:37:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vmgS=24=citrix.com=prvs=2926947f4=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1oo8h9-0008Nn-8R
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 19:37:39 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cd6c010e-562e-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 21:37:35 +0200 (CEST)
Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO
 NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 27 Oct 2022 15:37:23 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by CH2PR03MB5335.namprd03.prod.outlook.com (2603:10b6:610:91::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Thu, 27 Oct
 2022 19:37:21 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022
 19:37:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd6c010e-562e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666899455;
  h=from:to:cc:subject:date:message-id:content-id:
   content-transfer-encoding:mime-version;
  bh=f1BXe0ubGZbIk1FGJFtnHrxTWNaUlcWBAyux02VQSfg=;
  b=INXqkuDw+dSVdBa0jXsmw7f/1nq4u4L/nRmuEryaTjA/5dRWfO73BTdL
   1EWAhOy9ux5gI6HCXxyXgNT1ErtMSpRK9AZfL4W4rUDF5wLC4GdNPgUrt
   vkjlvkemf6cuQC1U9rI4axmbJRZGhEANWaezQ8h5r33kUyp6IMbN56J7w
   E=;
X-IronPort-RemoteIP: 104.47.59.170
X-IronPort-MID: 82759317
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:/79RFK+w+Wu7GNgWh6OiDrUDd3+TJUtcMsCJ2f8bNWPcYEJGY0x3m
 GUeUT2EbPuOZDOhedh1YI6z9E4OuZ+GxoAyTFdprCs8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOC6UIYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/
 Nj/uKUzAnf8s9JPGj9Suv/rRC9H5qyo4mpA5ANmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW
 +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ
 HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vxqLTxK/
 OA1EQlTRT7ehsys35nlT/Y506zPLOGzVG8ekldJ6GiDSNoDH9XESaiM4sJE1jAtgMwIBezZe
 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PtxujeLpOBy+OGF3N79U9qGX8hK2G2fo
 XrL5T/RCRAGLt2PjzGC9xpAg8efx3ymCdlLS9VU8NZAsQeZhXwOLSQ2RHKUmtS7lWKeAMtmf
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpdMYrssQ2Tzsty
 hqFks3kARRgt7qaTX+S7LCJtSj0Mi8QRUcAbyIZSQoO4/H4vZo+yBnIS75LE7SklcH0EDe2w
 z2AoSwW3LAfgMRN3KK+lXjLmympp4TJZgct6x/LQ3m+6QdkeI+iYZfu4l/ehcusN66cR1iF+
 XQBxc6X6blUCYnXzXPVBuIQALuu+vCJdiXGhkJiFIUg8DLr/GO/eYdX43d1I0IB3ts4RAIFq
 XT74Wt5jKK/9lPzBUOrS+pd0/gX8JU=
IronPort-HdrOrdr: A9a23:R++vBK3icO3b1UXeqLwjZwqjBQVyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4OxpOMG7MBDhHQYc2/hbAV7QZnifhILOFvAp0WKC+UypJ8SazIJgPM
 hbAs9D4bHLbGSS7vyKrTVQcexQpuVvmZrA7Yix854Hd3AJV0gU1XYcNu/tKDwSeOApP/oEPa
 vZwvACiyureHwRYMj+LGICRfL/q9rCk4+jSQIaBjY8gTP+wg+A2frfKVy1zx0eWzRAzfMJ6m
 7eiTH04a2lrrWS1gLc7WnO9J5b8eGRhOerRfb8y/T9GA+cyTpAV74RGYFqewpF5d1H3Wxa0O
 UkZS1Qe/ibpUmhOV1d6iGdoDUImAxekUMKj2XozUcL6PaJOA7TQaB69P9kWwqc5Ew6sN5m1q
 VXm2qfqppMFBvF2D/w/t7SSnhR5z2JSFcZ4JsuZkZkIP8jQa4UqZZa8FJeEZ8GEi6/4Ic7EP
 N2BMWZ4PpNa1uVY33Qo2EqmbWXLz0ONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+
 nNL6wtnrBTSc0da757GY46ML2KI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upBpH
 0AaiIqiYcfQTOeNSTV5uw1zvnkehTCYR39jsdD+pN+prrwALL2LCzrciFfr/ed
X-IronPort-AV: E=Sophos;i="5.95,218,1661832000"; 
   d="scan'208";a="82759317"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cv0Dl6JeifO8wIv9FSF/cIqpwukC3IkodiYf7RxIue8hP4zAyw6L6Ki2q4knZvoePPeoXpz+kEFQSSUteNwKAlHYRUKY86IUQ2Vn2r/2CS/o/8VtrVVWsMK6ViSyNti05TB4RqvxaOrW7YtPAAMEyUn/72XCz4IPMPKPHjM4D8ewt+E/UKokFkNfxGSyfGE21OhYGoajf/H7WyBsz7/o8CZSvMZw3hQWmY4vQ5A8Osb3q5lKvT1Wb4e1B++DD2flDP0HlVOik6D0qykXkA9hSrQvGY/SmEnRaWfL8vU8UJdmbRbGnobxvTILGDw/bWA3N0WXbEMh98iKq/lsPKWEaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f1BXe0ubGZbIk1FGJFtnHrxTWNaUlcWBAyux02VQSfg=;
 b=gsRGPsrl+ZH/1oGuroNQqh6WJGwTZdj3iRMPcyORFohe5DW8jugEsJGPKx3s5ZRHlEgGHlks7be+EcwS57YTOFNtG+JQKRBGQohD9fO0w3lF3+zFHBOUwwKpkZzSnmebtYlzzod/KuUlG01+BhN1yjSYk/svZ8mgRcanuy7dz08MTFyXkPyUKN+/pEyOJt5tarEuUDxzRwwsC91fTinF0ocUdP2KSplxH4U6Icef84czNUZRD+gYCoybDkA3+FH5mNeqVa2lNV9gYm9dy6JCyxhQhA/JWhnsExWx1gkr7/F0oqH4DN8272BfQx9YQVuQMtyBlDkPnhSEu6g52j/kWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=f1BXe0ubGZbIk1FGJFtnHrxTWNaUlcWBAyux02VQSfg=;
 b=vN9aNIi64w2V3COHX6Z9wY546POFf5pojj8CYFjTqyjnVsWk1Rm/x1nqyXuZrA7ulB3Ne9T8IrV4WWb8zEQ2MMw+EJ2y4jwQIi2lwdy3h8yqOIpNS2U9EhvTK61vYLV5630pAdE6aB6WX+DDxPZxmCpRdrCiHgV1Aqd6wBTHl3M=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>,
	"trenchboot-devel@googlegroups.com" <trenchboot-devel@googlegroups.com>
CC: Jan Beulich <jbeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
	Krystian Hebel <krystian.hebel@3mdeb.com>, Daniel Smith
	<dpsmith@apertussolutions.com>
Subject: Xen vs Trenchboot: TXT AP bringup
Thread-Topic: Xen vs Trenchboot: TXT AP bringup
Thread-Index: AQHY6juH8lNOUE9lmEK2XF+extU0lQ==
Date: Thu, 27 Oct 2022 19:37:20 +0000
Message-ID: <6ccbcaf7-29f4-6477-2f1f-0aa4de64e8c3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|CH2PR03MB5335:EE_
x-ms-office365-filtering-correlation-id: 3dd94bc2-e973-4c2d-0756-08dab852aa29
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Ts9O9Q/lQqFLnnklC5fh2Crbmq5arNWDwe4gyvlI2Ygs/Bo2tiyFbKQzpnddJo9CJCfVuX13RstgzP7QtfPWPtso2ANd348zetMgO2cCYyK8AFaAGQB3gV6Xs9r3B7EslHAIf4jLxRlOUEjRErenq2GwPy+bWsC4iWUv6eo40WRDLK9dZsHrBrufAm83rbb7p94QnoXpDJYaEO6hSf0s9PWIbmrgnbDkzP8VNT7lWz/SrHGZWlcWH0ZpDWiP1Agp3OVG6rvsNFb7y1kK8wVOG4JJpIZvFC/7to3sMWkFKMr5M7RAW2tb2stso5iX4OCGCGGrBmn+a8AASNbIL7Za6wmAIowlmeDiH6u8XMNknNseWAdL1TSHEIuKlUq9R++lfimI1c8ekz4aKvqDvII46pXOlCpTIleFOxE0MQ+zTIfwr147TT0+pVnGuQFa1mJixfrQjq4/q/aNvXdKCryz9wwvH7PGnPuwopRI8MN0fDeNT+tNo7UQGDgXI70R3kcXalS8ehUAIw3ZGBG0vljLBa5jDRypYf8lPb0osgOclPrsJEZBrh4MJaIO9pmmDNDJbJROVhOCmi+95L347c7nC6ODsThnLJxQea4OSa2JyHpVZ++OEDbHBfHXISnk9/kw6ffjWv3ufEKQvS/JQgkLyp+DeeXQzpC3QL6OtvEUAHSJ8koojNiTeMRyK64OfDZQN5jFMQpUNK/k5UlXohgswLnNqB/VfzBx76ZDnqiIIZvoKLHryQbsOaKtS7/xXJK9K0V0eNhaHOWPNu9/L94l3nmnGCI7RC1T5zEcQ8lNx6u5q+wSp38HPuoAmb3dzHNgtFX0kzwW5BC7/lHPj5g9Zw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(451199015)(66476007)(316002)(110136005)(54906003)(5660300002)(2616005)(2906002)(4326008)(86362001)(6506007)(186003)(8936002)(66946007)(36756003)(76116006)(64756008)(8676002)(26005)(6512007)(82960400001)(66556008)(66446008)(83380400001)(91956017)(31696002)(41300700001)(478600001)(122000001)(38100700002)(6486002)(71200400001)(31686004)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?N1dmVG9aWHJ2aGRLK0ZrUlNqMENNNDZZQzdwdkFSQ0xtYzg4bU9oWll6VFRa?=
 =?utf-8?B?VU42ZkpHWVNzTFVaTVBQTi9aZXIwUnFiWlZMVHJhb0ZENVdNTHI3UUY1cGJF?=
 =?utf-8?B?cGZtSzVxaUxMemtjNjRxYU05VC9wcmxKbURiYVhuc1JMM0FsUlNYemNKQThQ?=
 =?utf-8?B?T2RxaVk2MUVUUlFIandWaHJsejVKamc1b0plUXNwcDBQYVhOTzZsN05VMldR?=
 =?utf-8?B?SFBLSjdPRk1uWUZZcm9QTy8wME1sWklWcWw4UnlzN2YzWTVPUnpETHZHMFJq?=
 =?utf-8?B?aEZQN2M5d2VWZWZvM0dWWGtZODdtYU5HM0wvMXIvSFdkM3hLNVIrNVM1bGFR?=
 =?utf-8?B?VGgrSmlIL0s5M2JzNDhTVTVlRWdrZXFyVWUwdXhRNHpYRTc4ejFvZE1VOUE0?=
 =?utf-8?B?VUtEcllrUUxRYlpDSUt6cjNqL3AzNFRQNDBoTkZHajZiN3VoUU5hM2VvZzRX?=
 =?utf-8?B?cHlFNVhoV1A0cm5HbGVEUkxlVlRGaFZESTVPR0lUYkM2aFZscFRUSVdUY3Ev?=
 =?utf-8?B?VWpnYnpyWlBYNE9SMWZ0TWxLcU0yQ04ycmZqcDA1K0wrMWFQMWd1dEV6QUdq?=
 =?utf-8?B?RFRyR0pVcDViUHpwMjRNSk53QkkvUlNoYktGeERNS0pzc2N1YVFFVnhJTkJw?=
 =?utf-8?B?UnpiR1diLzJOWVRhZ1NZWWg2Z1pRN1Nhb2RuWGhqdTd4U08vQVZSQVlJMTky?=
 =?utf-8?B?ZEZ6Z0tvTDZjQXNWN2NDVXdJTDAyTy92UlVxODFNTGNIZFhHU1BnbGk3QVNO?=
 =?utf-8?B?cEx5bjVOWGFnc1hnQkwyRmxnR1hsSXJlV1NrdEVEa0JMU2VzWFdwem5YQytR?=
 =?utf-8?B?bVk4dmsvOHA0TDFJNkRwQm1ITXRoamhqYWg1aVhTdUx5bHQzU1VFMzZQcTRj?=
 =?utf-8?B?bUgzOUIydFBtUTJ1c2FpbEJLS0ZCVXZnQS9MaytneVRSMkpEdEVUM1ZzNXQv?=
 =?utf-8?B?TzdaZXhVYk9HNStWVElwSGpic0dzck5ieUdYNm5BOUZ1UjBialB2aENMZlJ2?=
 =?utf-8?B?ekUwQWorcGpweFhHYjdXeEZOZnNrVTlod3ZhdE50YmE4UFhQQWRSeG41N0FM?=
 =?utf-8?B?NU83ZGhxS29pai9jaXAxcUFOOHZrR3RtSjlvRkdVMktpQXAwOUtoOXMySUF2?=
 =?utf-8?B?TFVHOExNUjRCb2ZTbnhnTXdUNTN6eFlKZEtib1dWWnpZWHo4blZVZmtyNVpp?=
 =?utf-8?B?dmc5WG5ZSmJUQ0Uvb2VHSmN3aFBTY25CNklZc1Z1OWMyZzUxV3UvNzUzTWVq?=
 =?utf-8?B?cmNrazREOGVGRGptemxqcXFFa2YxK0ZjTmN0LzZUeEVwMk50dkdNRWVGT05a?=
 =?utf-8?B?NnNucjZiTEZROUpKTU9rZHJYS1o2L1F6bGkxRXNVaHRuMWg4Y1pxSGQ0YjFE?=
 =?utf-8?B?Mjh1SmdCMWh2anJlVW5UUUp3U3dqSlo4QjRRYnhBZHpEdE5Lc29xd245T3Q4?=
 =?utf-8?B?U0RrMFdaR2dkR2hFR2RadnNFWXJycU9pcmZ6WDRFa0pSTFNMWk9ueXo2MmJq?=
 =?utf-8?B?c1FnSlRGd0lIdmp6NXFnYU9mRWpIdWZQZUwwMnFic3l0K3dtNmFqbzkzMzNB?=
 =?utf-8?B?KzZsUkozTG1rbXhZNUZEbEtPNld1RjhDZUNNQ2hwUkZwN3ZaajFmNzFGVUsy?=
 =?utf-8?B?OG9odmpQRnA0MC9HRk4ydXV6QzhtQkJNVXlxWEtjd0k5Q25hcFJhNE1jdFJW?=
 =?utf-8?B?U2FKbVZuSld2c1NncTdKbDZMaU1UeXlIYlpSYnBCWGRYRkNqZENZYkg0SEhI?=
 =?utf-8?B?NnZnWE9CcjFCTlFBazR0Zzk1RmVtOTBMMWdIRHpXTTBudVVVT0tmT29yWFBx?=
 =?utf-8?B?TFM4OVpwbjI1SkJWZ1RITW51WDFwSFl6STNwbWV3NU9LS1VrendEZDhzaHdG?=
 =?utf-8?B?NHM3MGFSRlZuL21BNWxIWkYybG0vUlFqSTFGVlZqRlo3ZFdrSkJyTk0zWDRK?=
 =?utf-8?B?MkpiT1MwcHBvckFReTVibk1DcWdpdHo2QVJxR1F3Zi9VaXFrN1VQbXlNR2h1?=
 =?utf-8?B?MkNoZklteDliOWV4cGovbWpKVDBvTXM2TGQwV3lkcEdRcGJ4UFRNYXgxRHBk?=
 =?utf-8?B?ZSt3TmlaQ1RBT29BZWt6NUk2eU9Lc2JLRFZUckV1WXBLVVkyTDI4cHpkTm9a?=
 =?utf-8?Q?Ce5lKe79LzxHRrREqC21iI1Pk?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9AA083771A7B9A46B04629610E2DBEFC@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dd94bc2-e973-4c2d-0756-08dab852aa29
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 19:37:20.7366
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iueD6xWFfgk+hVMLwmoeHEGs8Pqnlz9EkRDXvMzfc9woEGk+YDlyx6mmyZW4JVbO/o4Hum7pchmcWj4WLZefSeX9Qw+IjdnoRPfJXEQWE5A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5335

SGVsbG8sDQoNCktyeXN0aWFuIGlzIHdvcmtpbmcgb24gdGhlIG5leHQgYml0IG9mIHRoZSBUcmVu
Y2hib290IHByb2plY3QncyBwbGFucywNCnNwZWNpZmljYWxseSBnZXR0aW5nIFhlbiBhYmxlIHRv
IG9wZXJhdGUgd2l0aCBUWFQgZGlyZWN0bHkgKGkuZS4gd2l0aG91dA0KdGJvb3QgaW4gdGhlIG1p
ZGRsZSkuDQoNClRoZSB3YXkgVFhUIHJlbGVhc2VzIEFQcyBiYWNrIHRvIHRoZSBCU1AgaXMgY2F1
c2luZyBzb21lIGZ1bi7CoCBBbGwgQVBzDQpyZWxlYXNlIHNpbXVsdGFuZW91c2x5LCBhdCBhIHBv
aW50IG9mIHRoZSBCU1AncyBjaG9vc2luZy7CoCAoU0RNIFZvbDIgNi4yKQ0KDQpXaGlsZSB0aGUg
QVBzIGRvIHJlbGVhc2UgaW4gMzJiaXQgZmxhdCB1bnBhZ2VkIG1vZGUgKHNvIG11Y2ggbmljZXIg
dGhhbg0KMTZiaXQgbW9kZSksIGl0IGlzIHN0aWxsIGluaGVyZW50bHkgYSBwYXJhbGxlbCBib290
LCBhbmQgdGhlIEFQSUNfSUQgaXMNCnRoZSBvbmx5IHNlbnNpYmxlIHBpZWNlIG9mIHVuaXF1ZWx5
IGlkZW50aWZ5aW5nIGluZm9ybWF0aW9uLg0KDQoNClRoZSBzaW1wbGUgYm9kZ2UgaXMgcHJvYmFi
bHkgdG8gaGF2ZSBhIHZhcmlhYmxlIHNpbWlsYXIgdG8gc21wYm9vdCdzDQpib290aW5nX2NwdSwg
d2hlcmUgYWxsIEFQcyBzcGluIHVudGlsIHRoZXkgZmluZCB0aGVpciBvd24gQVBJQ19JRC7CoCBU
aGlzDQpzZXJpYWxpc2VzIHRoZSBBUHMgYXJvdW5kIHRoZSBleGlzdGluZyBib290IHNlcXVlbmNl
Lg0KDQoNCkhvd2V2ZXIsIHdlJ3JlIGFsc28gdmVyeSBjbG9zZSB0byBzdXBwb3J0aW5nIHBhcmFs
bGVsIGJvb3QuwqAgVGhlDQpzZXJpYWxpc2luZyBwb2ludCB3ZSBjdXJyZW50bHkgaGF2ZSBpcyBf
X2hpZ2hfc3RhcnQgbG9hZGluZyAlcnNwIGZyb20NCnN0YWNrX3N0YXJ0LCBiZWNhdXNlIHRoYXQn
cyBhIHNpbmdsZSBwb2ludGVyIGFkanVzdGVkIGJ5IGRvX2Jvb3RfY3B1KCkuwqANCkV2ZXJ5dGhp
bmcgZWxzZSwgZXZlbiB0aGUgcHJvY2Vzc29yJ3MgaWRlYSBvZiBYZW4ncyBDUFUgaWQgaXMgZGVy
aXZlZA0KZnJvbSB0aGUgc3RhY2s7IHNwZWNpZmljYWxseSBpbiB0aGUgY3B1X2luZm8gYmxvY2sg
b24gdGhlIHRvcCBvZiB0aGUNCnN0YWNrLCB3aGljaCBpcyBwcmVwYXJlZCBieSB0aGUgQlNQLg0K
DQpBbGwgd2UgbmVlZCB0byBkbyBmdWxsIHBhcmFsbGVsIGJvb3QgaXMgYW4gYXJyYXkgbWFwcGlu
ZyBBUElDX0lEIC0+IFhlbg0KQ1BVIGluZGV4LsKgIFRoZSBBUCBib290IHBhdGggZG9lc24ndCB1
c2UgdGhlIHRyYW1wb2xpbmUgc3RhY2sgYXQgYWxsLsKgDQpHaXZlbiBzb21lIHdheSBvZiB0cmFu
c2Zvcm1pbmcgQVBJQ19JRCBpbnRvIGEgWGVuIENQVSBpbmRleCwgdGhlIEFQcw0KY291bGQgcHVs
bCB0aGVpciBzdGFjayBwb2ludGVyIHN0cmFpZ2h0IG91dCBvZiB0aGUgc3RhY2tfYmFzZXNbXSBh
cnJheS7CoA0KVGhpcyB3b3VsZCBhbGxvdyB1cyBpbiB0aGUgZ2VuZXJhbCBjYXNlIHRvIGJvb3Qg
QVBzIHVzaW5nIGFuDQphbGwtYnV0LXNlbGYgSU5JVC1TSVBJLVNJUEkuwqAgKFRoaXMgaXMgaG93
IGZpcm13YXJlIGRvZXMgQVAgYnJpbmd1cCBhbnl3YXkuKQ0KDQoNClRob3VnaHRzP8KgIEluIHBh
cnRpY3VsYXIsIGlzIHRoZXJlIGFuIG9idmlvdXMgb3B0aW9uIEkndmUgbWlzc2VkWzFdPw0KDQp+
QW5kcmV3DQoNClsxXSBUaGVyZSBpcyBhbm90aGVyIHdheSBvZiBkb2luZyB0aGlzIHdpdGggbXVs
dGlwbGUgY29waWVzIG9mIHRoZSBBUA0KdHJhbXBvbGluZSBhdCBkaWZmZXJlbnQgcG9zaXRpb25z
LCB3aGVyZSB0cmFtcG9saW5lX3JlYWxtb2RlX2VudHJ5KCkgY2FuDQpkZXJpdmUgdGhlIFhlbiBD
UFUgSUQgZnJvbSAlY3MsIGJ1dCB0aGlzIGlzIGFscmVhZHkgaG9ycmlibGUgYW5kIGlzbid0IGEN
CnNlbnNpYmxlIGFwcHJvYWNoIHRvIGNvbnNpZGVyLg0K


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 20:46:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 20:46:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431197.683900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo9l8-0000KU-C9; Thu, 27 Oct 2022 20:45:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431197.683900; Thu, 27 Oct 2022 20:45:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo9l8-0000KM-8b; Thu, 27 Oct 2022 20:45:50 +0000
Received: by outflank-mailman (input) for mailman id 431197;
 Thu, 27 Oct 2022 20:45:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9l6-0000Jx-UD; Thu, 27 Oct 2022 20:45:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9l6-00038U-SH; Thu, 27 Oct 2022 20:45:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9l6-0000ti-GL; Thu, 27 Oct 2022 20:45:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9l6-0006xp-Fp; Thu, 27 Oct 2022 20:45:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/TL4SAGOGlTSvGPzWkVyvCKuSz1flU1BkXJTp7Y3Pt8=; b=Nlt2kL/D9s4gALEYb/9CAo+c28
	qbAoCRRYIft8s8X66jPpziuLCr69J5lKsNlvlSr5yoJxpYTZLj+Wt8xKeWDUwf0FUJyjUMJ+wtLvj
	3u0hWLBsCyWV744Hr+YKESZYsl/fjnUbG5Wo93Rfw1aq3vqEgB+N1LNJ57vSHSQQoOOc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174460-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174460: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4dc12f37a8e98e1dca5521c14625c869537b50b6
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 20:45:48 +0000

flight 174460 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174460/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                4dc12f37a8e98e1dca5521c14625c869537b50b6
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   20 days
Failing since        173470  2022-10-08 06:21:34 Z   19 days   27 attempts
Testing same since   174460  2022-10-26 14:11:50 Z    1 days    1 attempts

------------------------------------------------------------
1411 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 132851 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 20:54:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 20:54:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431203.683911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo9tw-0001yw-9X; Thu, 27 Oct 2022 20:54:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431203.683911; Thu, 27 Oct 2022 20:54:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo9tw-0001yp-6E; Thu, 27 Oct 2022 20:54:56 +0000
Received: by outflank-mailman (input) for mailman id 431203;
 Thu, 27 Oct 2022 20:54:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yXv3=24=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1oo9tv-0001yj-4x
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 20:54:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 9ae00ab3-5639-11ed-8fd0-01056ac49cbb;
 Thu, 27 Oct 2022 22:54:53 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CED5F23A;
 Thu, 27 Oct 2022 13:54:58 -0700 (PDT)
Received: from slackpad.lan (unknown [172.31.20.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF8573F7B4;
 Thu, 27 Oct 2022 13:54:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ae00ab3-5639-11ed-8fd0-01056ac49cbb
Date: Thu, 27 Oct 2022 21:53:16 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
 <stefanos@xilinx.com>, <julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
 <bertrand.marquis@arm.com>, <Henry.Wang@arm.com>
Subject: Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
Message-ID: <20221027215316.768881c9@slackpad.lan>
In-Reply-To: <20221027190913.65413-1-ayankuma@amd.com>
References: <20221027190913.65413-1-ayankuma@amd.com>
Organization: Arm Ltd.
X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 27 Oct 2022 20:09:13 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

Hi,

> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt
> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should be
> used to restore the saved interrupt state.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>

Thanks for fixing this!

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  xen/arch/arm/vgic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index d0e265634e..015446be17 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
>              write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>          }
>  
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> +        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>  
>          return 1;
>      }



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 20:55:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 20:55:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431206.683925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo9uA-0002O2-K2; Thu, 27 Oct 2022 20:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431206.683925; Thu, 27 Oct 2022 20:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oo9uA-0002Mw-FI; Thu, 27 Oct 2022 20:55:10 +0000
Received: by outflank-mailman (input) for mailman id 431206;
 Thu, 27 Oct 2022 20:55:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9u9-0002Kd-Fd; Thu, 27 Oct 2022 20:55:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9u9-0003Hz-D0; Thu, 27 Oct 2022 20:55:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9u8-0001VE-Ty; Thu, 27 Oct 2022 20:55:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oo9u8-0006OW-TZ; Thu, 27 Oct 2022 20:55:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=++WL/wbzwQqKv49CrtT3SHNwg45I034zroFe6PwajUA=; b=Z7F8opysR/BzQ4hmW030WgRij6
	H4w4O4RwoMjHTiKNd4Ka47XhBi30WUpPe7NoicXhY1obj6VzEtVbYWSZhmc8qHAc0yIWk2K1WCAdy
	0pMYaypAooOeGGRkTni+RxXtgbHwv4ocu6gmydO0ZEn0QM4XlpUUyUGd1QUgRD3NLymY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174452-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174452: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e5a5bdeba6a0c3eacd2ba39c1ee36b3c54e77dca
X-Osstest-Versions-That:
    xen=cea5ed49bb5716698a11312a3f38bc8865cd1e67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 20:55:08 +0000

flight 174452 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174452/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172623
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 172623
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172623
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 172623
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 172623
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172623
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172623
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172623
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  e5a5bdeba6a0c3eacd2ba39c1ee36b3c54e77dca
baseline version:
 xen                  cea5ed49bb5716698a11312a3f38bc8865cd1e67

Last test of basis   172623  2022-08-18 12:08:13 Z   70 days
Failing since        173493  2022-10-11 13:07:01 Z   16 days   14 attempts
Testing same since   174452  2022-10-26 11:59:49 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   cea5ed49bb..e5a5bdeba6  e5a5bdeba6a0c3eacd2ba39c1ee36b3c54e77dca -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Thu Oct 27 22:17:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 22:17:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431248.684054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooBBN-0005Wb-87; Thu, 27 Oct 2022 22:17:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431248.684054; Thu, 27 Oct 2022 22:17:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooBBN-0005WU-4N; Thu, 27 Oct 2022 22:17:01 +0000
Received: by outflank-mailman (input) for mailman id 431248;
 Thu, 27 Oct 2022 22:16:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yXv3=24=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1ooBBL-0005Vd-J6
 for xen-devel@lists.xenproject.org; Thu, 27 Oct 2022 22:16:59 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 11a7c3d6-5645-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 00:16:57 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8725E23A;
 Thu, 27 Oct 2022 15:17:02 -0700 (PDT)
Received: from slackpad.lan (unknown [172.31.20.19])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CAE633F71A;
 Thu, 27 Oct 2022 15:16:54 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11a7c3d6-5645-11ed-8fd0-01056ac49cbb
Date: Thu, 27 Oct 2022 23:15:10 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
 <stefanos@xilinx.com>, <julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
 <bertrand.marquis@arm.com>, <Henry.Wang@arm.com>
Subject: Re: [XEN v5] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
Message-ID: <20221027231510.064975be@slackpad.lan>
In-Reply-To: <20221027185555.46125-1-ayankuma@amd.com>
References: <20221027185555.46125-1-ayankuma@amd.com>
Organization: Arm Ltd.
X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 27 Oct 2022 19:55:55 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 64bit cpu register.
> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
> in the lower 32 bits of the 64bit cpu register.
> 
> This 64bit cpu register is then modified bitwise with a mask (ie
> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
> 64 bit cpu register) is not cleared as expected by the specification.
> 
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
> 
> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
> v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_read(). The reason
> being v->arch.vgic.rdist_pendbase is now being read in an atomic manner.
> 
> Similarly in __vgic_v3_rdistr_rd_mmio_write(), we have used read_atomic(),
> write_atomic() to read/write v->arch.vgic.rdist_pendbase.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> 
> Changes from:-
> 
> v1 - 1. Extracted this fix from "[RFC PATCH v1 05/12] Arm: GICv3: Emulate
> GICR_PENDBASER and GICR_PROPBASER on AArch32" into a separate patch with an
> appropriate commit message.
> 
> v2 - 1. Removed spin_lock_irqsave(). Used read_atomic() to read
> v->arch.vgic.rdist_pendbase in an atomic context.
> 2. Rectified the commit message to state that the cpu register is 64 bit.
> (because currently, GICv3 is supported on Arm64 only). Reworded to make it
> clear.
> 
> v3 - 1. Added read_atomic()/write_atomic() for access to v->arch.vgic.rdist_pendbase
> in __vgic_v3_rdistr_rd_mmio_write().
> 2. Removed spin_lock_irqsave()/spin_unlock_irqrestore() for access to
> v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_write().
> 
> v4 - 1. Retained the spin_lock_irqsave()/spin_unlock_irqrestore() for access to
> v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_write(). This is because
> there could be a potential race while read-modify-write is performed on
> v->arch.vgic.rdist_pendbase, with another caller performing the same operation.
> 
>  xen/arch/arm/vgic-v3.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index 0c23f6df9d..d0e265634e 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -249,16 +249,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
>  
>      case VREG64(GICR_PENDBASER):
>      {
> -        unsigned long flags;
> +        uint64_t val;
>  
>          if ( !v->domain->arch.vgic.has_its )
>              goto read_as_zero_64;
>          if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>  
> -        spin_lock_irqsave(&v->arch.vgic.lock, flags);
> -        *r = vreg_reg64_extract(v->arch.vgic.rdist_pendbase, info);
> -        *r &= ~GICR_PENDBASER_PTZ;       /* WO, reads as 0 */
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
> +        val = read_atomic(&v->arch.vgic.rdist_pendbase);
> +        val &= ~GICR_PENDBASER_PTZ;      /* WO, reads as 0 */
> +        *r = vreg_reg64_extract(val, info);
>          return 1;
>      }
>  
> @@ -577,10 +576,10 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info,
>          /* Writing PENDBASER with LPIs enabled is UNPREDICTABLE. */
>          if ( !(v->arch.vgic.flags & VGIC_V3_LPIS_ENABLED) )
>          {
> -            reg = v->arch.vgic.rdist_pendbase;
> +            reg = read_atomic(&v->arch.vgic.rdist_pendbase);
>              vreg_reg64_update(&reg, r, info);
>              reg = sanitize_pendbaser(reg);
> -            v->arch.vgic.rdist_pendbase = reg;
> +            write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>          }
>  
>          spin_unlock_irqrestore(&v->arch.vgic.lock, false);



From xen-devel-bounces@lists.xenproject.org Thu Oct 27 22:56:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 27 Oct 2022 22:56:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431256.684071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooBnD-000200-6J; Thu, 27 Oct 2022 22:56:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431256.684071; Thu, 27 Oct 2022 22:56:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooBnD-0001zt-2b; Thu, 27 Oct 2022 22:56:07 +0000
Received: by outflank-mailman (input) for mailman id 431256;
 Thu, 27 Oct 2022 22:56:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooBnB-0001zj-Qo; Thu, 27 Oct 2022 22:56:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooBnB-0005L0-Q1; Thu, 27 Oct 2022 22:56:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooBnB-0000JM-IC; Thu, 27 Oct 2022 22:56:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooBnB-0002a2-Hm; Thu, 27 Oct 2022 22:56:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=53JNHjd2aAFDGjQ0OH2hnqUYr86eVIdCIg0VVzVInCk=; b=Y6XbLD85AKv73E6bapq6Lfi5yy
	StUKWXsLJ00WdHm7+EIHFu5qe7QNw+/ZPuSvjtRA97uCtomqK+mu0ks2sdj80w7789eIzg55kGe67
	xQW7SnetNmRsBm8S4JwYtxVT8tuW0wSn9jecrOmhGXHAg1Me+z8gASi2YpNzrIxsMSX4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174512-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174512: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=99338ef81ed6e48be57f71c01af85fbbdd7030ed
X-Osstest-Versions-That:
    ovmf=115cebbe4d7541c795b4f9baefc38f9a1733b7f6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 27 Oct 2022 22:56:05 +0000

flight 174512 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174512/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 99338ef81ed6e48be57f71c01af85fbbdd7030ed
baseline version:
 ovmf                 115cebbe4d7541c795b4f9baefc38f9a1733b7f6

Last test of basis   174478  2022-10-26 22:43:36 Z    1 days
Testing same since   174512  2022-10-27 17:10:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   115cebbe4d..99338ef81e  99338ef81ed6e48be57f71c01af85fbbdd7030ed -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 01:16:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 01:16:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431287.684175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooDyX-0001my-IE; Fri, 28 Oct 2022 01:15:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431287.684175; Fri, 28 Oct 2022 01:15:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooDyX-0001mr-EW; Fri, 28 Oct 2022 01:15:57 +0000
Received: by outflank-mailman (input) for mailman id 431287;
 Fri, 28 Oct 2022 01:15:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooDyW-0001mh-5V; Fri, 28 Oct 2022 01:15:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooDyW-0006da-2r; Fri, 28 Oct 2022 01:15:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooDyV-0005Xp-Lr; Fri, 28 Oct 2022 01:15:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooDyV-0001bi-LM; Fri, 28 Oct 2022 01:15:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=quFp4F3Lqr/dUHn6ELRprHz2KuSEwsCjrucVweqBamo=; b=NsEnzLKMvOha2VfrOTFVA00HYB
	+l4Mv0aXxcgdYuDQKflidanV+ftEYj6Fc7mVAzg3slvxTUeS0vrlDOSr2vyscxYzNJhEJr5QdDYj4
	1fAJdhjHUD+KsJ+5rkjnev+o6IBArKUIu9ZaMJZ8xGQl5b8x7MZ0IaX4GaJjiAvi4PBM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174476-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 174476: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.13-testing:test-arm64-arm64-xl-seattle:xen-boot:fail:heisenbug
    xen-4.13-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=5b668634a9feb68e7a27339f25591b019d0923c3
X-Osstest-Versions-That:
    xen=bde3b13043e31fd757c44bcec182b0ff1fe36d22
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 01:15:55 +0000

flight 174476 xen-4.13-testing real [real]
flight 174519 xen-4.13-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174476/
http://logs.test-lab.xenproject.org/osstest/logs/174519/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-seattle   8 xen-boot            fail pass in 174519-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 172549

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 174519 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 174519 never pass
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 172549
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 172549
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 172549
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 172549
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 172549
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 172549
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 172549
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 172549
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  5b668634a9feb68e7a27339f25591b019d0923c3
baseline version:
 xen                  bde3b13043e31fd757c44bcec182b0ff1fe36d22

Last test of basis   172549  2022-08-15 14:37:33 Z   73 days
Failing since        173495  2022-10-11 14:08:01 Z   16 days   16 attempts
Testing same since   174476  2022-10-26 20:31:02 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   bde3b13043..5b668634a9  5b668634a9feb68e7a27339f25591b019d0923c3 -> stable-4.13


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 02:56:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 02:56:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431379.684233 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooFYB-00086s-16; Fri, 28 Oct 2022 02:56:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431379.684233; Fri, 28 Oct 2022 02:56:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooFYA-00086j-TI; Fri, 28 Oct 2022 02:56:50 +0000
Received: by outflank-mailman (input) for mailman id 431379;
 Fri, 28 Oct 2022 02:56:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/aT=25=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ooFY9-00086A-B9
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 02:56:49 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29c47aab-566c-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 04:56:48 +0200 (CEST)
Received: from AS9PR0301CA0033.eurprd03.prod.outlook.com
 (2603:10a6:20b:469::20) by DB4PR08MB9310.eurprd08.prod.outlook.com
 (2603:10a6:10:3f6::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 02:56:45 +0000
Received: from AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:469:cafe::68) by AS9PR0301CA0033.outlook.office365.com
 (2603:10a6:20b:469::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Fri, 28 Oct 2022 02:56:45 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT038.mail.protection.outlook.com (100.127.140.120) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 02:56:43 +0000
Received: ("Tessian outbound 0800d254cb3b:v130");
 Fri, 28 Oct 2022 02:56:43 +0000
Received: from dcfb1e350bc0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 29A9A589-72F1-4256-A23A-FA8F282A9572.1; 
 Fri, 28 Oct 2022 02:56:37 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dcfb1e350bc0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 02:56:37 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB8385.eurprd08.prod.outlook.com (2603:10a6:10:3da::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 28 Oct
 2022 02:56:36 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 02:56:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29c47aab-566c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Rqloq1PJzEKfnb/jInNuDZDCiD37L+IzFKwstL1qzt/4f2AT3GMW1rk96Nh7mP7/sE3ABmuNgV0yZ2x26oHcYBB2OL2Og9NEOryZDce+8mmMT+aUKCmmcff58SnKUIiGv+HdHZXc5fJjECni6a6UCzaf5MgUxx/xmrJ0XuqXriN6KzEei9HJ6A/MaLeRVlzfGf87p9IcaqfqllH4XhZWP09Iipl54GN9zZTRSK3Nk1j/bBnTEylaYvwzNZxw98Gppfcri+Aher1l9bVSq75km/XVXq8GXcOOISs0wPEL6sIoeulDvFfrZ2c4wo/id/vtEo0Hyc6oIIrGijgpUf3BRw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=49Yd57NvxfUThgErfcmRemkq9fQUMEBKdQumhm4wPjI=;
 b=deBqM6jSX5DUSeMJmGkZ6eW9awSjeRqSxTUnei2tig5vz4zcMuLwL0R3aLPDPPWKDcX8b3ARQ0qprjEOIJi6tRP4FSNsORGCxBPwJ/UIR9fgnQt+Qklj6hv5csq+Blos50AggTOwlTRjqfzU7OnFYJc0n557SXykbNxsXwj3QU+vYUCnzco01klfDiat0uuRAfjP4+kJgng9AkMm7gCzQODfpVQ8tp//j4wiybsWowvVL7IMDj+9HSZDTS3ePchU7elz3cLHlbryfrztObphT1saGis9TouU/TtuS3VLHv+3tX/LRWmWh5NKGeYcZFqqP6zmfLRe0V/zE/PMl9pxNw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=49Yd57NvxfUThgErfcmRemkq9fQUMEBKdQumhm4wPjI=;
 b=vZSEqJ+W4pwVq0XzvJFzH3F7RzWadIPeanfhKAD29UWWfARmcDScHJcSUlzUk7qIn6StZl3UjRzpBfQ6ewtJjYpGhgy/YVwgOwwxTQp2x0Gsa7rQBVLldTCm5df4n8U8eeXNfagP3IBoUoFuyLX5Sy5/uzGGteuOySJOs00D9/0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lLHeBA0QCvDHnyMYfZHAL4yUhQRzjYmSuF/iSkhR61HSYVqDBQ/bS7EWDsk8TQxFAh87uCutjGDJm4C0dGeIam+hl52HM+Gx/g+zpssUm0KhBRx+EMzi41O40nYgwvZZDIMYOPncBvXrTaDnjVVkki3U5bH/EJYElPz8ieFmw8CbyFSLjHP9brkyidNYri5WzBZw/shqKH+hJHZYT3EYxpgP9ZB9CjSrWR57X2e6/ZnHTB2MWyjgKMIoyYl2FJIRgMP7jOtlMG6zI0ZVx7V8reFrJqGklZDpnMfecAy6zzIQfkkAvmPFbGdRX62e7UrdMABeVmNz1C4W+GZiQwoJPQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=49Yd57NvxfUThgErfcmRemkq9fQUMEBKdQumhm4wPjI=;
 b=IBCOLglb6z6RBLICijGdu9dYZoWiT6wwKeBzv4LWSwpfZmfP555IlwT/e5xig6VmkcfFVg+YRSfCUXQ6jTAAINyPU/zMVFW0T9/cfqwVsUpUoL98hLn6t3dZi0PQWXh5rOGcvbMOzRvqYfQYCd+j2msO3lPLNEcG52ZhzBIvZgXgUANT54NxfZ07Pv9kzZfOzy/ONz1BCFnxkPbIqLGP4gGmm/u5LhT3B2oE6NJiZ0Uc2eT7Bstx/WtPC7juVp23d2qDbyLO23YIeUDsL00eWD6bKb2PGd04mWxgH2rghjaeeOV79nR4uuxyK+HnCPcqbYn+0xgRCiOA9ayxbN8Uwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=49Yd57NvxfUThgErfcmRemkq9fQUMEBKdQumhm4wPjI=;
 b=vZSEqJ+W4pwVq0XzvJFzH3F7RzWadIPeanfhKAD29UWWfARmcDScHJcSUlzUk7qIn6StZl3UjRzpBfQ6ewtJjYpGhgy/YVwgOwwxTQp2x0Gsa7rQBVLldTCm5df4n8U8eeXNfagP3IBoUoFuyLX5Sy5/uzGGteuOySJOs00D9/0=
From: Henry Wang <Henry.Wang@arm.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH for-4.17 v3 2/2] vpci: refuse BAR writes only if the BAR
 is mapped
Thread-Topic: [PATCH for-4.17 v3 2/2] vpci: refuse BAR writes only if the BAR
 is mapped
Thread-Index: AQHY6gdlgL3IkW26406wHogcEOJe0K4jHZ7w
Date: Fri, 28 Oct 2022 02:56:35 +0000
Message-ID:
 <AS8PR08MB799101A292018EBBEA4470D092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221027132315.80592-1-roger.pau@citrix.com>
 <20221027132315.80592-3-roger.pau@citrix.com>
In-Reply-To: <20221027132315.80592-3-roger.pau@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: DC4AE74C3684D740B4E3CE38E188EA9D.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB8385:EE_|AM7EUR03FT038:EE_|DB4PR08MB9310:EE_
X-MS-Office365-Filtering-Correlation-Id: b8472e03-6d14-4f1b-fd73-08dab8900bd6
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 YGp7a3nRt1DFccvSFBLqwchiGrG06pAG+loIhYHxWTh8h1ucc0pW5Ox4QehoT/oCtnXB7LpNsWbSs67ydVXEkumy9bbO7lcz4p/9vSBpE7nRvm+f2au6vuZUVtCoFyaH0yHhp34X/Qf4QEHfj3hNljNkz5axQsOBsKka9gI+ec5b5y1hdQuIoKP4ee81jZrcGyw37viBwP70nzkTzBJt8VOPGDBlE7Xjk/BZZnFIwo6tbOjjKA82g8wEYB0SaUF3sJlN7BxvoOz1A+Gu62WBtiUtpqu2XFY0mvqJ0KGntAwtxwsECMZIaGBihCdfXmsjvlcJuv/+dbCJnWxy71ZbyVk/nHpypqs1qXvXHYj6ItLNhgZCeflzxY/d6ZYetIcZvlFoSx5mYe5DZcmt5VmwILaxxjF9MB9A5rUCXku2J/kDEelK5Xa8kSdM4JvPW6jboM+JLI1LkEPOrynXiREI9r9FnmRQuGGWSdklT4Q5HaUElWPF9p+3RAodR4hWAxE/lo3hAJBO8S4F894C/xln4fJbEamRRdrHfwHzSXzNi7geYTn2esvU0ER+VG0rNWYSOhu0egrSVOYhUqX3jVNHvhONReQBTjLswTQIoIhrLQJzeQ5GgERPHhwligRf0TQrzsrDmLczhS4HRi70XLcksRRBsZgTnsFzdkC2uXeOdie7ADWHwpCaoKV0VPMrbCy+T3HCyYz3ixM6U1G30J8p6LMcQm+9XFUYtbaghTmIHAI+RzTuFRB8CE0+N+eF/Znd1vLDNybMOIgADUhXEsjreA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(33656002)(6506007)(55016003)(478600001)(7696005)(38100700002)(71200400001)(122000001)(316002)(110136005)(38070700005)(26005)(9686003)(186003)(86362001)(83380400001)(2906002)(8936002)(66476007)(66946007)(64756008)(66446008)(41300700001)(76116006)(5660300002)(66556008)(52536014)(8676002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8385
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7d21cc7e-c25d-4802-382a-08dab8900714
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	W8Pr0koKTOYSRx0RoYlqISyINmCbR9B7xBgQYtoIYvf2419eyUxpdJGh/s1wapcnZXISKW1fRrPzyR5XnsTsL48nzuIIic9eKPN6goSZnd/LIQmQCvNgKUrbs3eEReHvxjJT4mGXSnNZAfFNiTw04cfQoTESXqt5WqU/slZzRjHznwVsdgJV8UkUwAkYJuKrPLs7eGL/ZaRvIsHS6179Mv98uWPduebr0lRzijosDK/0ZbfbRQBysSIOoJgm8WIAOL4VvSPsi+zb5MVgmfSGeh7Pz+RsDixg1vlYHObi3Wn5brQjQXDxxsL+98AwzTiKU5k8ypqIubC1c/J/aD3u/PajwyHhLBtfCSESvrzfuPsVWqvnjzbgROO1ei2umBAqewv+BhvlFkmwWT+enmXNepyeT5pJDmMc20YKMDJ17VD7FivgovWm+HyXyytGXl4SIJy98Q/VYJOR0i82JJBxEPSYcApBZDRF5rRIM2bsfMBbly096yMBrK7Dmk4fMpqtndbxXNeFfDZcT6TqUmrqTGoitEnv3b4gaYD2sBYIemgs3qkfIvMuyXt/we55e562FGAOxZOwgLueJcz4W/LF7PEBr4+oCFtMw7U3TpErcMUdJf2YRPZ+s5AS2i3M4kKKLl/az0Ukii5d/ZL+ZM1AF9gkgWSDobPQ9tlTpUpCIU9/hbny4hYLNTWqTI8PdN+vPjKequG7rV5SElv1rU4S89KJCApz8Xpu5iTav1aFmlEVDyUdgR4yCKcQmryNMxZsJLP5oCkpIgSyilREUgYyig==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(36840700001)(40470700004)(46966006)(55016003)(40480700001)(40460700003)(82740400003)(36860700001)(2906002)(5660300002)(356005)(47076005)(83380400001)(33656002)(86362001)(81166007)(336012)(26005)(9686003)(186003)(478600001)(316002)(110136005)(41300700001)(52536014)(8936002)(70206006)(8676002)(7696005)(6506007)(70586007)(82310400005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 02:56:43.9161
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b8472e03-6d14-4f1b-fd73-08dab8900bd6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9310

SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9nZXIg
UGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00
LjE3IHYzIDIvMl0gdnBjaTogcmVmdXNlIEJBUiB3cml0ZXMgb25seSBpZiB0aGUgQkFSIGlzDQo+
IG1hcHBlZA0KPiANCj4gV3JpdGVzIHRvIHRoZSBCQVJzIGFyZSBpZ25vcmVkIGlmIG1lbW9yeSBk
ZWNvZGluZyBpcyBlbmFibGVkIGZvciB0aGUNCj4gZGV2aWNlLCBhbmQgdGhlIHNhbWUgaGFwcGVu
IHdpdGggUk9NIEJBUnMgaWYgdGhlIHdyaXRlIGlzIGFuIGF0dGVtcHQNCj4gdG8gY2hhbmdlIHRo
ZSBwb3NpdGlvbiBvZiB0aGUgQkFSIHdpdGhvdXQgZGlzYWJsaW5nIGl0IGZpcnN0Lg0KPiANCj4g
VGhlIHJlYXNvbiBvZiBpZ25vcmluZyBzdWNoIHdyaXRlcyBpcyBhIGxpbWl0YXRpb24gaW4gWGVu
LCBhcyBpdCB3b3VsZA0KPiBuZWVkIHRvIHVubWFwIHRoZSBCQVIsIGNoYW5nZSB0aGUgYWRkcmVz
cywgYW5kIHJlbWFwIHRoZSBCQVIgYXQgdGhlDQo+IG5ldyBwb3NpdGlvbiwgd2hpY2ggdGhlIGN1
cnJlbnQgbG9naWMgZG9lc24ndCBzdXBwb3J0Lg0KPiANCj4gU29tZSBkZXZpY2VzIGhvd2V2ZXIg
c2VlbSB0byAod3JvbmdseSkgaGF2ZSB0aGUgbWVtb3J5IGRlY29kaW5nIGJpdA0KPiBoYXJkY29k
ZWQgdG8gZW5hYmxlZCwgYW5kIGF0dGVtcHRzIHRvIGRpc2FibGUgaXQgZG9uJ3QgZ2V0IHJlZmxl
Y3RlZA0KPiBvbiB0aGUgY29tbWFuZCByZWdpc3Rlci4NCj4gDQo+IFRoaXMgY2F1c2VzIGlzc3Vl
cyBmb3Igd2VsbCBiZWhhdmVkIGRvbWFpbnMgdGhhdCBkaXNhYmxlIG1lbW9yeQ0KPiBkZWNvZGlu
ZyBhbmQgdGhlbiB0cnkgdG8gc2l6ZSB0aGUgQkFScywgYXMgdlBDSSB3aWxsIHRoaW5rIG1lbW9y
eQ0KPiBkZWNvZGluZyBpcyBzdGlsbCBlbmFibGVkIGFuZCBpZ25vcmUgdGhlIHdyaXRlLg0KPiAN
Cj4gU2luY2UgdlBDSSBkb2Vzbid0IGV4cGxpY2l0bHkgY2FyZSBhYm91dCB3aGV0aGVyIHRoZSBt
ZW1vcnkgZGVjb2RpbmcNCj4gYml0IGlzIGRpc2FibGVkIGFzIGxvbmcgYXMgdGhlIEJBUiBpcyBu
b3QgbWFwcGVkIGluIHRoZSBkb21haW4gcDJtIHVzZQ0KPiB0aGUgaW5mb3JtYXRpb24gaW4gdGhl
IHZwY2lfYmFyIHRvIGNoZWNrIHdoZXRoZXIgdGhlIEJBUiBpcyBtYXBwZWQsDQo+IGFuZCByZWZ1
c2Ugd3JpdGVzIG9ubHkgYmFzZWQgb24gdGhhdCBpbmZvcm1hdGlvbi4gIFRoaXMgd29ya2Fyb3Vu
ZHMNCj4gdGhlIGlzc3VlLCBhbmQgYWxsb3dzIGRvbWFpbnMgdG8gc2l6ZSBhbmQgcmVwb3NpdGlv
biB0aGUgQkFScyBwcm9wZXJseS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u
w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5n
IDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 02:56:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 02:56:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431378.684222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooFY3-0007qo-OB; Fri, 28 Oct 2022 02:56:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431378.684222; Fri, 28 Oct 2022 02:56:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooFY3-0007qh-Kw; Fri, 28 Oct 2022 02:56:43 +0000
Received: by outflank-mailman (input) for mailman id 431378;
 Fri, 28 Oct 2022 02:56:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/aT=25=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ooFY2-0007qb-8z
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 02:56:42 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 22c6e0e4-566c-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 04:56:36 +0200 (CEST)
Received: from DUZPR01CA0086.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:46a::13) by DU0PR08MB8493.eurprd08.prod.outlook.com
 (2603:10a6:10:406::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Fri, 28 Oct
 2022 02:56:24 +0000
Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:46a:cafe::e0) by DUZPR01CA0086.outlook.office365.com
 (2603:10a6:10:46a::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 02:56:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 02:56:23 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Fri, 28 Oct 2022 02:56:23 +0000
Received: from 04977826e0d5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 316BC360-9FEB-4AB9-B292-3B362551DC30.1; 
 Fri, 28 Oct 2022 02:56:14 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04977826e0d5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 02:56:14 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB8385.eurprd08.prod.outlook.com (2603:10a6:10:3da::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 28 Oct
 2022 02:56:13 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 02:56:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22c6e0e4-566c-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=e+24LfDAy1mzvoxuQYtHstEtdOKFZlGyO1Y4hcpxXjcDe5e/oXkhiaWZRjgHgo/KTJ0j6m+MnE22H3++csbW7NMP9TbkRy8QpOKJ7hRYlb4NxTex4IL9Uha3KrB68DogHWO7VWDmAeXWvFdWvoMeuuo+ZCvOebxpU5vMJ5b9fjk9FlYxN4n2RF3tNYk2QGOnjGYZrODG+8j6ek/+mqk4p7jfC77idw3rVjSBwf9VQ+E6AmSNyrOL3y0K7MtY1CKY1G2z3Wi8bEf+eAJeFq/QqPeb24qttnF/4WvxJszG6kNPvLVBDZIau5FcgTLmBSwwkqo3nx7cBoEQPQpUA8G0sA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6UEgP8UdKuw1heNoBAVkzU29+rag/Yv31sWuP0bWZ/M=;
 b=KyofLWc5S5/D3yeITiTqZsDARU58hMQowFcyEqAT8PId0PDhNJPrZKJl4079g+4XmXPDklTyWhX4YOVwEXv8tdu1yEmowVc1Nv7LOoLTZoKqVSTdJRuQNUOU2h/flYo20Jlw1OxUV7viF1TFUzGsnOHI6JO41iI/fXhI8mRMQIrGtRk/nApi7Yg2gM52bOAp/gYNUc6l9JDQAgu7k2pEbDKwweI9UiFBn10lD81Savi4eeX2R8MVGbHclgiQFY45WJylJKGET+SGCo92pUBkRM5qZA2/xlVx6PuyqUb7QGVJfXeCvY4JUd+CjctQkHPAZfAgBg6B/ts3EjBjZor20w==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6UEgP8UdKuw1heNoBAVkzU29+rag/Yv31sWuP0bWZ/M=;
 b=vwjreV/cwTVRz2ApCt6lRNfc9z4TbBFXZ5e6I799G5eFFnzt3H3D2Gwq48LjCAvK5rsMYFQqgd9qWy8R9fLyvrzBQ6b9ROVSO/rGhS8gO6pgc+DzVVDIY8gEDmrdEIkcwa7t2TGpMobDW+3lImn+p0bLsQsVSl/L4M5Hhhl+ccc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 66db3c28a15e05bf
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IC7JwZet8HcBpZUe43H+v+aYF34+RPeAQIZTX+uhC5bXQ0vocBgKU2cG9M1dJuNYppoglJNIqme7+zl1YfnOSVtFy55JOwJUzP6w6uyw5KIjnRKHT2MB5BDtWwQustfTKDqsSdPBCzBnq6+Rv1pZZZz5nBSsnzAMtIsfj7OFVyzhP9KdMRLHbutZB1j/ANCIjtP4ZZC5diJPBiU6p/O6KVqpCUaxUyAY75YJW873K356oRKYwjqPxKMW0RIfgotADOL/Dm+aAw/oPQlFz3YssvBvv5s/XlbQ7FN7L6vB9xHIqIfSSYi1rO5CaJNVrzqDQCUW+LNy31kVbJm+e4fx6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6UEgP8UdKuw1heNoBAVkzU29+rag/Yv31sWuP0bWZ/M=;
 b=ZcVX0MSGWFxClHFHXZCNxEg9REPGXI/ZaTYWkWi8hgR1rUfHnFOFT6CptIgPoFyW1H7fpJhWnGkt//KeMOny0yIrESgLc4njWD3kGEAjv8uy/tH/ZMN+iWCwyq+cLY8LpIZYQ/eCR0EOoFZqOSqqi6IBG7KStQ+cxPVa4NHScEvHa/ZJmUOv3pLjVK2SbO9BV2cddiT3kQfNatWB8ioh3SeT06K1DZgdhet8ItaO+1iYNnnheXMo65Y1C1LpxfgwTi0jFhE4KVI1XcMPYyB7uyfttoDIML/w6YJ8nmJItGn9/f2yRFT6KAQ44MhTimdrWy1bMIfP7V8G5S15AwnSgA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6UEgP8UdKuw1heNoBAVkzU29+rag/Yv31sWuP0bWZ/M=;
 b=vwjreV/cwTVRz2ApCt6lRNfc9z4TbBFXZ5e6I799G5eFFnzt3H3D2Gwq48LjCAvK5rsMYFQqgd9qWy8R9fLyvrzBQ6b9ROVSO/rGhS8gO6pgc+DzVVDIY8gEDmrdEIkcwa7t2TGpMobDW+3lImn+p0bLsQsVSl/L4M5Hhhl+ccc=
From: Henry Wang <Henry.Wang@arm.com>
To: Roger Pau Monne <roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Jan Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>
Subject: RE: [PATCH for-4.17 v3 1/2] pci: do not disable memory decoding for
 devices
Thread-Topic: [PATCH for-4.17 v3 1/2] pci: do not disable memory decoding for
 devices
Thread-Index: AQHY6gdfXU3AcwAAuU+ikCtUluaIt64jHX+g
Date: Fri, 28 Oct 2022 02:56:12 +0000
Message-ID:
 <AS8PR08MB7991AADA9FF4A6F85C14CF7C92329@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221027132315.80592-1-roger.pau@citrix.com>
 <20221027132315.80592-2-roger.pau@citrix.com>
In-Reply-To: <20221027132315.80592-2-roger.pau@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 88CBC4AC7DACCC40B2A75A57AA9F99AA.0
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB8385:EE_|DBAEUR03FT041:EE_|DU0PR08MB8493:EE_
X-MS-Office365-Filtering-Correlation-Id: 2bd7599f-56ab-42c9-c3bd-08dab88fffa5
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 aBC5DAWFZMmGPLBVQ129tl+SjxOWzDhQRY9Snr3DiF8PL9sv/4toO4cXBRXoX+pTZ1td6SbcTQZUmPM7eOQpahqK5yzw2XZ/EDgCvdju+EnUObGqST7BrkfigF0RtCcdDg2FWCr+jv56a1kdBUgFaLn66AKAPFFB0TMvoH6lkSFStLBGrlg7XvwoDgqwZSKZ3dRC/z8Gi/755xXEqX1WdhoqHBbeViABXnHY7YD7g18CrZxwktqalXqqsdHfdu3QFtMnK+i38PDrNSw4ppLPanQtKhegKAMk37njYp1dSdAtHa4AotCruhuZUqeO7+aWMbvQ4mUXSN/ApOTnQpQucbK8Ws1ZWyUgGXgPiKnmLv3HArhsC74tFoGqrMo+X/tK/7Z6SBOR7xPdHrJShyAB2nMVEPpZFtGdIPyefWartgiuRpW7X/mTbvKDip3gifOFJG1GBQekylWdT7AUmgFQEPAoz9Qw6RwNQTsmWpinmrQRmXEyWDwJMDDQZj2XCiIwPub/vDIE9Civ985NEdIKJXN704+jUUH6WJJiC7I4qNV8SVja91LrRfmI/cpqJN3HGsTyPMP5AYTDVBou32uQwrW+mt/C6U7lAuaExEm2T9fYIq/IkzlyWfT/xKko1MxJhNrYNbrCaw1DMwaBXLDxx3z4wvRaTFm6gned3Nv93XdPjlEIFIP3hqO+JF+Bz8ao/emwIc1PB7hSMT9SM7jVsWQnzWpXugLE5h3HcsUlF5QwyN1wPs/qEtvL0mOzKGSemhu9up3dX5vP24SIPSeXLA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(33656002)(6506007)(55016003)(478600001)(7696005)(38100700002)(71200400001)(122000001)(54906003)(316002)(110136005)(38070700005)(26005)(9686003)(186003)(86362001)(83380400001)(2906002)(8936002)(66476007)(66946007)(64756008)(66446008)(41300700001)(4326008)(76116006)(5660300002)(66556008)(52536014)(8676002);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8385
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9c678615-62cb-452a-508e-08dab88ff960
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yoR2JokZ/G8EIaCOmROHYb7U3MiDVpilECxioC192GtQDJ0kUpgQyP8eCVwBpyKPRqgfcJXLTZGzRAPEuTnh1o0busgAyOv6uKVX+t2XeMtLPdV786WIANtlZ61+xwv64T3kzpd5Jw8rt6cb9xij7TgBJQTUGOJmcBgBtFrn1mSnV1oezsA260V/fnNffhxxZzC6EL9pTO75pukK74ytWWV7ccTqn3SPZIsk7oXvZnBcMxyc7kyPfwSHmBp1la+qfRCKaVPHEeT/GEcK5DQ1OuPGq/vKRVUh04LHMFe3U0zJX8y62n5D1n4N7VzVP7VrY34XyQRhsXTBp6bb+Luv6KChmMFevAQ8m5LAHa595hRhMTq1I76LsMpc+pjKJcKloMNabUYELwCS+NIIKuEF8hSS7Uont4/Ys64ixH81sEU4+P8eZj2+uD1pgzIx0qV/MYVJq9JJSqit5gMpMR1xxwuxQ8hQQPRB7N3f1r4EpF9NSJKAj6Vv1siPYA2W15/gd+hKGtaBFrW3Y1cfLmzGgxiDxbrnlxl/AweQTy4YvvJx3d98czeVRj8sYEDfdVGEJsfpH0ySr2gZPIDPKfpLaEpi79uOBl91jWUN3+Bs8ApfleNTlDgX923ljhLpDg1PJun2DDFJwzkFoj8fihIxDYD7WQOIT7VHsWi0+LsVshdckrj7GHNxL1uId8rJjsnLDz/fqCAcw7VNp1V43i46LUAd0Efii/kVGO2uwxsex3rd2rqdtSULIIogc1VmGKspNtRCPMRgO0tG32vxZ4QL4Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(83380400001)(52536014)(336012)(186003)(316002)(9686003)(7696005)(6506007)(26005)(41300700001)(86362001)(5660300002)(47076005)(2906002)(33656002)(70206006)(478600001)(70586007)(8936002)(36860700001)(8676002)(356005)(40480700001)(55016003)(82310400005)(82740400003)(4326008)(81166007)(40460700003)(110136005)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 02:56:23.5234
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd7599f-56ab-42c9-c3bd-08dab88fffa5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8493

SGkgUm9nZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm9nZXIg
UGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU3ViamVjdDogW1BBVENIIGZvci00
LjE3IHYzIDEvMl0gcGNpOiBkbyBub3QgZGlzYWJsZSBtZW1vcnkgZGVjb2RpbmcgZm9yDQo+IGRl
dmljZXMNCj4gDQo+IENvbW1pdCA3NWNjNDYwYTFiIGFkZGVkIGNoZWNrcyB0byBlbnN1cmUgdGhl
IHBvc2l0aW9uIG9mIHRoZSBCQVJzIGZyb20NCj4gUENJIGRldmljZXMgZG9uJ3Qgb3ZlcmxhcCB3
aXRoIHJlZ2lvbnMgZGVmaW5lZCBvbiB0aGUgbWVtb3J5IG1hcC4NCj4gV2hlbiB0aGVyZSdzIGEg
Y29sbGlzaW9uIG1lbW9yeSBkZWNvZGluZyBpcyBsZWZ0IGRpc2FibGVkIGZvciB0aGUNCj4gZGV2
aWNlLCBhc3N1bWluZyB0aGF0IGRvbTAgd2lsbCByZXBvc2l0aW9uIHRoZSBCQVIgaWYgbmVjZXNz
YXJ5IGFuZA0KPiBlbmFibGUgbWVtb3J5IGRlY29kaW5nLg0KPiANCj4gV2hpbGUgdGhpcyB3b3Vs
ZCBiZSB0aGUgY2FzZSBmb3IgZGV2aWNlcyBiZWluZyB1c2VkIGJ5IGRvbTAsIGRldmljZXMNCj4g
YmVpbmcgdXNlZCBieSB0aGUgZmlybXdhcmUgaXRzZWxmIHRoYXQgaGF2ZSBubyBkcml2ZXIgd291
bGQgdXN1YWxseSBiZQ0KPiBsZWZ0IHdpdGggbWVtb3J5IGRlY29kaW5nIGRpc2FibGVkIGJ5IGRv
bTAgaWYgdGhhdCdzIHRoZSBzdGF0ZSBkb20wDQo+IGZvdW5kIHRoZW0gaW4sIGFuZCB0aHVzIGZp
cm13YXJlIHRyeWluZyB0byBtYWtlIHVzZSBvZiB0aGVtIHdpbGwgbm90DQo+IGZ1bmN0aW9uIGNv
cnJlY3RseS4NCj4gDQo+IFRoZSBpbml0aWFsIGludGVudCBvZiA3NWNjNDYwYTFiIHdhcyB0byBw
cmV2ZW50IHZQQ0kgZnJvbSBjcmVhdGluZw0KPiBNTUlPIG1hcHBpbmdzIG9uIHRoZSBkb20wIHAy
bSBvdmVyIHJlZ2lvbnMgdGhhdCB3b3VsZCBvdGhlcndpc2UNCj4gYWxyZWFkeSBoYXZlIG1hcHBp
bmdzIGVzdGFibGlzaGVkLiAgSXQncyBteSB2aWV3IG5vdyB0aGF0IHdlIGxpa2VseQ0KPiB3ZW50
IHRvbyBmYXIgd2l0aCA3NWNjNDYwYTFiLCBhbmQgWGVuIGRpc2FibGluZyBtZW1vcnkgZGVjb2Rp
bmcgb2YNCj4gZGV2aWNlcyAoYXMgYnVnZ3kgYXMgdGhleSBtaWdodCBiZSkgaXMgaGFybWZ1bCwg
YW5kIHJlZHVjZXMgdGhlIHNldCBvZg0KPiBoYXJkd2FyZSBvbiB3aGljaCBYZW4gd29ya3MuDQo+
IA0KPiBUaGlzIGNvbW1pdHMgcmV2ZXJ0cyBtb3N0IG9mIDc1Y2M0NjBhMWIsIGFuZCBpbnN0ZWFk
IGFkZHMgY2hlY2tzIHRvDQo+IHZQQ0kgaW4gb3JkZXIgdG8gcHJldmVudCBtaXNwbGFjZWQgQkFS
cyBmcm9tIGJlaW5nIGFkZGVkIHRvIHRoZQ0KPiBoYXJkd2FyZSBkb21haW4gcDJtLiAgU2lnbmFs
aW5nIG9uIHdoZXRoZXIgQkFScyBhcmUgbWFwcGVkIGlzIHRyYWNrZWQNCj4gaW4gdGhlIHZwY2kg
c3RydWN0dXJlLCBzbyB0aGF0IG1pc3BsYWNlZCBCQVJzIGFyZSBub3QgbWFwcGVkLCBhbmQgdGh1
cw0KPiBYZW4gd29uJ3QgYXR0ZW1wdCB0byB1bm1hcCB0aGVtIHdoZW4gbWVtb3J5IGRlY29kaW5n
IGlzIGRpc2FibGVkLg0KPiANCj4gVGhpcyByZXN0b3JlcyB0aGUgYmVoYXZpb3Igb2YgWGVuIGZv
ciBQViBkb20wIHRvIHRoZSBzdGF0ZSBpdCB3YXMNCj4gcHJldmlvdXMgdG8gNzVjYzQ2MGExYiwg
d2hpbGUgYWxzbyBpbnRyb2R1Y2luZyBhIG1vcmUgY29udGFpbmVkIGZpeA0KPiBmb3IgdGhlIHZQ
Q0kgQkFSIG1hcHBpbmcgaXNzdWVzLg0KPiANCj4gRml4ZXM6IDc1Y2M0NjBhMWIgKCd4ZW4vcGNp
OiBkZXRlY3Qgd2hlbiBCQVJzIGFyZSBub3Qgc3VpdGFibHkgcG9zaXRpb25lZCcpDQo+IFNpZ25l
ZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KDQpSZWxl
YXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQoNCktpbmQgcmVn
YXJkcywNCkhlbnJ5DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 04:08:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 04:08:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431388.684243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooGf5-0000Ht-4g; Fri, 28 Oct 2022 04:08:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431388.684243; Fri, 28 Oct 2022 04:08:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooGf5-0000Hm-1e; Fri, 28 Oct 2022 04:08:03 +0000
Received: by outflank-mailman (input) for mailman id 431388;
 Fri, 28 Oct 2022 04:08:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooGf3-0000Hc-Go; Fri, 28 Oct 2022 04:08:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooGf3-0001Wo-BE; Fri, 28 Oct 2022 04:08:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooGf2-0001RD-TS; Fri, 28 Oct 2022 04:08:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooGf2-0007r8-T0; Fri, 28 Oct 2022 04:08:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6uCD68eqpRcQLiTsMByCNDPY2cHhBzQ7dsTmCAVvycA=; b=WMPJGq8PI0H9U2opqBng1Ho4Ri
	rXa5lm+mNi4N+xLfSMwjeK2fYWeR+IUCw5PJ0yEW8KVTY79nSMrOE+0kGiEQaabGosQ/fsU6NLT/n
	TEpFCLeCGhm7B+l5GJUzhqptim12bhL3is+YbrWG95CYQa8iV5ZwjCwz/0UhNBdljHps=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174499-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174499: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=bad4832710c7261fad1abe2d0e8e2e1d259b3e8d
X-Osstest-Versions-That:
    xen=ef9cc669ba157f9e71fd79722ee43892e7304604
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 04:08:00 +0000

flight 174499 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174499/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174435
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174435
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174435
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174435
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174435
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174435
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174435
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174435
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174435
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174435
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174435
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174435
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  bad4832710c7261fad1abe2d0e8e2e1d259b3e8d
baseline version:
 xen                  ef9cc669ba157f9e71fd79722ee43892e7304604

Last test of basis   174435  2022-10-26 04:32:31 Z    1 days
Testing same since   174499  2022-10-27 09:39:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ef9cc669ba..bad4832710  bad4832710c7261fad1abe2d0e8e2e1d259b3e8d -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 04:44:57 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 04:44:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431399.684270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooHEg-0005bD-6R; Fri, 28 Oct 2022 04:44:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431399.684270; Fri, 28 Oct 2022 04:44:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooHEg-0005b6-3m; Fri, 28 Oct 2022 04:44:50 +0000
Received: by outflank-mailman (input) for mailman id 431399;
 Fri, 28 Oct 2022 04:44:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/aT=25=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ooHEe-0005b0-J9
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 04:44:48 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60041.outbound.protection.outlook.com [40.107.6.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3fc1942c-567b-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 06:44:47 +0200 (CEST)
Received: from AM5PR0701CA0059.eurprd07.prod.outlook.com (2603:10a6:203:2::21)
 by VI1PR08MB5501.eurprd08.prod.outlook.com (2603:10a6:803:138::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 04:44:31 +0000
Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:2:cafe::bb) by AM5PR0701CA0059.outlook.office365.com
 (2603:10a6:203:2::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend
 Transport; Fri, 28 Oct 2022 04:44:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 04:44:29 +0000
Received: ("Tessian outbound b4aebcc5bc64:v130");
 Fri, 28 Oct 2022 04:44:29 +0000
Received: from fce0fe867e8d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7A561CBB-D959-47F2-A5DA-3624458618F4.1; 
 Fri, 28 Oct 2022 04:43:36 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fce0fe867e8d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 04:43:36 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AM8PR08MB6514.eurprd08.prod.outlook.com (2603:10a6:20b:36b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 04:43:33 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 04:43:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fc1942c-567b-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=dXSSSKPwLLe/A11e90exfg7E7SVS3or+XYv6PfrLRJgKmemdGMVehViRHIqAonWl5LOdezwsjiQHJ9ZAp7dbczSMxpwRnAH1FmqcPTx3Euv082pJGa7t9r3k3Fw5T/CcZtd2QfV8Ez0im4ZrXyushGfsW2vJi1dx27Ub/4PxTJAJXwL1ZSB0HDIMDQmycMAbrsJYV1IqGhuAjHTyQIPCYiIqzmRdtoq3th02KWLRza7gcJOJisuoplj+Mn4yPLxBYw6C4bBVhbHhm3EE/FVI6UvOnxQqbDKr8BA/+QCNLw0FUD2dVlqeGWJlGBCyGpfeoqU0sBYS5GM/0MXwMYKNrA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XDTXL0vWjxx0ZpH5GwKEm5jF0HBp/iReKAR0LSi3f7o=;
 b=G9RcGTzx7xDktn8Y4U8+hueWYytZOiR1KK1RhDT5sGWIR+IQEuIbch+3X1DJhM6+KzXbhjH9m0iCaDDm8fJvRYrhaxjOLMhpV1r91bvUpK7qUdZs8OVlQm9uV7XvIoquojswPaGVXhRVY8Vr/QiGTyY9JXOlPriZdkwb2rDL1CO7pW0f4sC2zjitAa1vM3zLYdQqTL2uBlp+/dUx12/dp15I326BnkvNpdFD5g8MGj9uhvvvl2N200xDPbOqxT7PebrbQo61ua6mHUMh0F8WllmSkz/4VuoW5xjzBknjmaV0XRhtLw3D3Nz4fNFP7Y0NK5rksdL3GHPfkIFG48QdEQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XDTXL0vWjxx0ZpH5GwKEm5jF0HBp/iReKAR0LSi3f7o=;
 b=Se5cb12kCd2p9KFn7DFN1W8KukEilIjAkFHbyTyGVcswNGeSswRxtVkVj9PKTlSaNn8R6gLrtni3kGiz7TzqIZmocoOMOQAheVH80QwM/pVOO41FNqXv4DHgL4JW9D5vFY26AVPn3ajBIMEWLxn/jAu2E8Ou4tpjdnxYXaKAXKU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8cd2310d058e8748
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V2muTnQzUHZuINRdPFwwokUm9olkkdrYvaZRqwy2uodgSXPItqHZ6idaV2aD8rxcjKOCLVEWNQm+4ynYiLQhKDGCx5FoGKLjRSw89s0SkBC+j1H1NmPWqrKbHe7A86ekOm9viVxRvRusZj7WYJTjzwGdtIPofkwj0FIlNWigH3/sE0/spCyub+oo3LpayKoyzhzlh7okc0D5+wLr25zaRRQrjsDqv9THLKccCqgZzj6OP8rEYdAFq/XSBOQmcVqoPjAaBx86yzYmStl+Znh0Towseovp8a+Az9hI3gRUFvJS6frLlk6n96FB5EctunX3orcHjaYFhyn2HI1h9rSVuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XDTXL0vWjxx0ZpH5GwKEm5jF0HBp/iReKAR0LSi3f7o=;
 b=ioqcm9LAtlMNVlhTRarPSIBaRtV8rePQERZvJlQhhdwlVOBc04NAIqEB15qVXtop3xHQNnFIZbGMzduax7G56eS8ktjhnagG56SCqONGvhsDwhVo37q7GfgBMFU51xPHavix2Y97vsngn9YyL6tc/hZbE6UMRAjDwlczs4jELVaVbqY1uaLIfyBvBaagJiCVwOWm1UdVsHzMHPgUTiq8j+qlC5bkkEdcbWEUXq0fj7q/C9Pfm6etXggL3jCERnby4qEROz9b/Um5BDStvDWIRqKBBuJj5muxmvCpfjNDB+k8mTFixFYwxoNuZ5t/ONG7b4iHFPSeEPPOX5eE0Dr0qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XDTXL0vWjxx0ZpH5GwKEm5jF0HBp/iReKAR0LSi3f7o=;
 b=Se5cb12kCd2p9KFn7DFN1W8KukEilIjAkFHbyTyGVcswNGeSswRxtVkVj9PKTlSaNn8R6gLrtni3kGiz7TzqIZmocoOMOQAheVH80QwM/pVOO41FNqXv4DHgL4JW9D5vFY26AVPn3ajBIMEWLxn/jAu2E8Ou4tpjdnxYXaKAXKU=
From: Henry Wang <Henry.Wang@arm.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "Daniel P. Smith" <dpsmith@apertussolutions.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
	"christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
	"christopher.clark@starlab.io" <christopher.clark@starlab.io>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Julien
 Grall <jgrall@amazon.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "jgross@suse.com" <jgross@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, Anthony PERARD <anthony.perard@citrix.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>, "Wei Liu (LSG)"
	<liuwe@microsoft.com>
Subject: Feedback for postponing the 4.17 release to a week later
Thread-Topic: Feedback for postponing the 4.17 release to a week later
Thread-Index: Adjqh6nb7bpyTo+8QPKuDS/Y5NDKqw==
Date: Fri, 28 Oct 2022 04:43:33 +0000
Message-ID:
 <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: EEED2DDA949674468255770FF13229F8.0
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AM8PR08MB6514:EE_|AM7EUR03FT009:EE_|VI1PR08MB5501:EE_
X-MS-Office365-Filtering-Correlation-Id: edd2719b-caf5-47ed-0de0-08dab89f19cc
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 FjamBxIuTVuMrlMh++YdnFioVT8ha+EMAxZSYw3m2VJ5MR9gbsqWKsN6v1b++NhpCN8ZVEL7aCkT2az6DpnBxoNT+DrqTGyJJDAfQ6XCq09skvkOrJa7pYBhNHL5bb+OBPk3JDBlRdSRmE+no5nQzol5JCqLcTieSv82SkSY8IxBw/UlJx2sSYoniheq9qm04EZCESPJOmdLpjGT9d3OhWqN9VFLDIjX/IVMJibgohOW8XeG2AXIsSV2aPsaQYvFOYaL8Iq3Nzpg23m2qBhZoRgCmQCY59D6VJlX6sQ1+LrN/JIKgMqv2bS/o4SRgF/l1amtUO2BSLkhUAOmbGceYtt4KpglYAId+DXAYYYGCpuM1cPEh6ttQsserQ0Bw6mVV/UqUjyKdiAjsdx8SDzwWgbZjNsS++FnCq/JAiEIoy8nWzzD757wH/NN+Nhudnrec7L+gQ1bVxGYMOEK4EmGlfFplIgv3WLRBkb9xubojIZMfu+utN2eMgj4JcrD2mE6T8C0jxdXNm7UWV2cNAVzycS6j0cFTCvSspgUg5mVB+5GaZoMIU4Lm3oIYZrb8Z/iVSiTXAuWl/SboHFVo3xxVHM82TQt/l3iFA8vqUWI37FXkY+5FX0y5WR0x49tSjHhBennVl78e+DvFA4vs8ErKxPIR3sAYqGNVktXeuZaVLiyqnVgNC2MQd7bQbqle61ob1elpWwDEtp2B5pb4VJEexrTiKOSYHk4mQ8SyccjYbfSl9P70dwOFrChA9seTBtBT6sXYOO+1sAD1r2vU15qeHORc6a255sUFmwzrW0pHRU=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(86362001)(33656002)(38070700005)(38100700002)(122000001)(8936002)(2906002)(83380400001)(55016003)(6506007)(26005)(7696005)(478600001)(9686003)(186003)(71200400001)(966005)(4744005)(54906003)(6916009)(316002)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(4326008)(5660300002)(41300700001)(7416002)(52536014);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6514
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9902745c-acdf-4292-2ebc-08dab89ef815
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NAA01Rj/x5FgEJ+AqmF4euWvdITEzhODNkREqzD2/aSGtMkfos35eg0BxPuUAT7zIOO7SkbH3bprefz5wSKzwPIRa+1WzZtoIHMB2a6yz2Cb/UYCYzyVrfdwV1qsb1pgCBcvQlW1/MDFykX6Vfm+HmBmZALH/WfZpBzMq0PFGCGQU2KEvLaLREaCTWDI6j0uPD1TkNeVV84Guj8FUDIZ7eHTR9cTkuGXz/1eyksSfEMSBjpCgfv65Mx8SdmPiumX4HyqLlaJGqcUBb9NO8snbYfLHWudbVo05/uPiSpqQTWc2SCjEr9tIZTC+K9TjOGznnklHIUVeN09mq+be/JqF2oByqeCwa/866tF9NLC27Kmd+n0xLYNK9CJjCrWe9GVOHJAK5R0KacLi3gkLJCGKAyPOAVUhxZMnQvO02CcOkyN8zpW3KKE4177x5PR8uzgzsoO3Ebsx3psVvCyBOz6ncTkoSZilyNqUddwOri3jwYh8yDBAYUasFu+19qxkxtSLvQKjqAhNz5de1vKVdg+hCvLx0jWTdLegQtLmoSqbudSXTu6vKTL3l1Nf9dY6m3Hz6i42+lHzb7XmXmmgiuQ9/1qFBuQ+q4zruviRL19zuL6KkL5mb+jZGQ0UfMj/KHTD7lQD/BVgIjW+mKzwfAcfZ14xHMZq2381eQSbeVlgUrxdpB+J2+KN2tIUZ5F2Qc3U3h2jQhbGsrpdvTYtG8eHZBX2faKESxZ8GvScFc7xS4M1aHZ8NzYlocie1tsRBR4ZsL5Lanj+MmQ1eMo+T4iHTeFosaiWMbbs4uxGQnQQw0=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(36840700001)(40470700004)(46966006)(83380400001)(40460700003)(478600001)(966005)(82310400005)(33656002)(81166007)(356005)(54906003)(6916009)(52536014)(4744005)(82740400003)(36860700001)(47076005)(107886003)(8676002)(4326008)(316002)(40480700001)(70586007)(70206006)(6506007)(9686003)(2906002)(55016003)(8936002)(7696005)(26005)(5660300002)(41300700001)(336012)(186003)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 04:44:29.7835
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: edd2719b-caf5-47ed-0de0-08dab89f19cc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5501

Hi all,

Since there will be a batch of XSAs released on Nov. 1 [1] and the original=
 date for
the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the 4=
.17
release to a week later (Nov. 11) to give a little bit longer time so that:

- The security team won't do anything in rush.
- We can have more feedback after merging these XSAs.
- Include more release-relevant bugfixes.

May I please have some feedback on this proposal? Thanks very much!

[1] https://xenbits.xen.org/xsa/

Kind regards,
Henry



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 05:04:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 05:04:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431403.684282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooHXk-0000Ml-RS; Fri, 28 Oct 2022 05:04:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431403.684282; Fri, 28 Oct 2022 05:04:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooHXk-0000Me-Nv; Fri, 28 Oct 2022 05:04:32 +0000
Received: by outflank-mailman (input) for mailman id 431403;
 Fri, 28 Oct 2022 05:04:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aLI4=25=redhat.com=jasowang@srs-se1.protection.inumbo.net>)
 id 1ooHXj-0000MY-BS
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 05:04:31 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffd29ac5-567d-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 07:04:29 +0200 (CEST)
Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com
 [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-18-1GfdpKXBP2iOMuaxLrVIBg-1; Fri, 28 Oct 2022 01:04:26 -0400
Received: by mail-pj1-f70.google.com with SMTP id
 om10-20020a17090b3a8a00b002108b078ab1so5008704pjb.9
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 22:04:26 -0700 (PDT)
Received: from [10.72.13.50] ([43.228.180.230])
 by smtp.gmail.com with ESMTPSA id
 e16-20020aa79810000000b0056b6c7a17c6sm2062169pfl.12.2022.10.27.22.04.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 27 Oct 2022 22:04:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffd29ac5-567d-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1666933467;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=okMdc+KhJjKXcis0bcDj5EWl2UnVMQS0OzmNUP9xDbI=;
	b=FN1oK56umF6F/gA5ejdQPewR8WZSeLaMwD/DirCaOADVkAbP5CKeVNKrBS+ATvRsB5A8Jz
	lVFBaz1tyQL8xfp87HfXniuthou+nWtMfJalq2BgcL83WNKoSZgulbvF36A/fLKsbozMTw
	F9XEZ7remiI47CefLmfekXAEqpqVe5w=
X-MC-Unique: 1GfdpKXBP2iOMuaxLrVIBg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=okMdc+KhJjKXcis0bcDj5EWl2UnVMQS0OzmNUP9xDbI=;
        b=uZZW7wgjehQLdgPvn0tewlr+U+inu3SSCtJ3asrgkJU1CpxRPOQJAiJOPDnYX62u4r
         Wtui8AHCuC72xhDrC1LAax3QOHPuvqgxStUVgS4snUqeNbFG2bHlwJJF/CJto9H+ZRxJ
         VvYopLgFOeRhtGfcjn4MZKI2kVzEB0gjtUV/oD1boucTHDAju+AUQb7Ha1IhALyBFt6c
         dpnfKhOkZCh+1J48ieI6se1zEAnRHNW4NkTYCCFgXfIjvh67UPWZmmRnvowgdE55f/GS
         +umZKITgkpJs1XoRm3bMJUtXHSiuj8b51kWbEh03Y04OJzSY0YjWHNiAIsbWkNFuHaEv
         J/5w==
X-Gm-Message-State: ACrzQf2TCj67BxCiTxGCIkBDkbMkBKW6mnU3c+laTR3ZKlroGaAUz+b1
	Ztd8ZkRzr2hm4YIETL+Yj+dU3X+h0cutaSfq0ogK5fvQOfN9d/WUxJbMtl7JGiTR6KOxu6IU22p
	iccKeVxbV5SQzBMimI49u2MRjgBE=
X-Received: by 2002:a17:90b:1649:b0:20d:2d96:6b05 with SMTP id il9-20020a17090b164900b0020d2d966b05mr14284810pjb.9.1666933465303;
        Thu, 27 Oct 2022 22:04:25 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM763cM40Ox4h2hsO44kzlRFkLDSF93C9SC1IIjEwDsaISVB67+Ka9W6ONBS2A+3fnGisQJaow==
X-Received: by 2002:a17:90b:1649:b0:20d:2d96:6b05 with SMTP id il9-20020a17090b164900b0020d2d966b05mr14284755pjb.9.1666933464749;
        Thu, 27 Oct 2022 22:04:24 -0700 (PDT)
Message-ID: <700ef645-6cb6-66e6-00a9-3db187be0c43@redhat.com>
Date: Fri, 28 Oct 2022 13:04:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.1
Subject: Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram
 backends
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>, xen-devel@lists.xenproject.org,
 "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
 Anthony Perard <anthony.perard@citrix.com>, Stefan Weil <sw@weilnetz.de>,
 David Gibson <david@gibson.dropbear.id.au>,
 Stefano Stabellini <sstabellini@kernel.org>, Paul Durrant <paul@xen.org>,
 Eric Blake <eblake@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
 Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>, Greg Kurz <groug@kaod.org>,
 =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= <berrange@redhat.com>
References: <20221021090922.170074-1-lvivier@redhat.com>
 <20221021090922.170074-17-lvivier@redhat.com>
From: Jason Wang <jasowang@redhat.com>
In-Reply-To: <20221021090922.170074-17-lvivier@redhat.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


在 2022/10/21 17:09, Laurent Vivier 写道:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---


I got this:

63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: 
assertion failed (resp == expect): ("st0: index=0,type=stream,connection 
error\r\n" == "st0: index=0,type=stream,tcp:::1:40389\r\n") ERROR
63/63 qemu:qtest+qtest-x86_64 / 
qtest-x86_64/netdev-socket                  ERROR 5.29s   killed by 
signal 6 SIGABRT
 >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 
MALLOC_PERTURB_=96 
QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon 
G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh 
/home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― 
✀ 
―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stderr:
**
ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: 
assertion failed (resp == expect): ("st0: index=0,type=stream,connection 
error\r\n" == "st0: index=0,type=stream,tcp:::1:40389\r\n")

(test program exited with status code -6)
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

The base is:

commit 344744e148e6e865f5a57e745b02a87e5ea534ad (HEAD -> master, 
origin/master, origin/HEAD)
Merge: 08a5d04606 e38c24cb58
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Wed Oct 26 10:53:48 2022 -0400

     Merge tag 'dump-pull-request' of 
https://gitlab.com/marcandre.lureau/qemu into staging

So I dropped this patch from the queue and we can add it back after 
soft-freeze.

Thanks


>   tests/qtest/meson.build     |   1 +
>   tests/qtest/netdev-socket.c | 420 ++++++++++++++++++++++++++++++++++++
>   2 files changed, 421 insertions(+)
>   create mode 100644 tests/qtest/netdev-socket.c
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index c07a5b1a5f43..6953797e4e3e 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -27,6 +27,7 @@ qtests_generic = [
>     'test-hmp',
>     'qos-test',
>     'readconfig-test',
> +  'netdev-socket',
>   ]
>   if config_host.has_key('CONFIG_MODULES')
>     qtests_generic += [ 'modules-test' ]
> diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> new file mode 100644
> index 000000000000..b24c0819b9ac
> --- /dev/null
> +++ b/tests/qtest/netdev-socket.c
> @@ -0,0 +1,420 @@
> +/*
> + * QTest testcase for netdev stream and dgram
> + *
> + * Copyright (c) 2022 Red Hat, Inc.
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#include "qemu/osdep.h"
> +#include "libqtest.h"
> +
> +#define CONNECTION_TIMEOUT    5
> +
> +#define EXPECT_STATE(q, e, t)                             \
> +do {                                                      \
> +    char *resp = qtest_hmp(q, "info network");            \
> +    if (t) {                                              \
> +        strrchr(resp, t)[0] = 0;                          \
> +    }                                                     \
> +    g_test_timer_start();                                 \
> +    while (g_test_timer_elapsed() < CONNECTION_TIMEOUT) { \
> +        if (strcmp(resp, e) == 0) {                       \
> +            break;                                        \
> +        }                                                 \
> +        g_free(resp);                                     \
> +        resp = qtest_hmp(q, "info network");              \
> +        if (t) {                                          \
> +            strrchr(resp, t)[0] = 0;                      \
> +        }                                                 \
> +    }                                                     \
> +    g_assert_cmpstr(resp, ==, e);                         \
> +    g_free(resp);                                         \
> +} while (0)
> +
> +static int inet_get_free_port_socket(int sock)
> +{
> +    struct sockaddr_in addr;
> +    socklen_t len;
> +
> +    memset(&addr, 0, sizeof(addr));
> +    addr.sin_family = AF_INET;
> +    addr.sin_addr.s_addr = INADDR_ANY;
> +    addr.sin_port = 0;
> +    if (bind(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
> +        return -1;
> +    }
> +
> +    len = sizeof(addr);
> +    if (getsockname(sock,  (struct sockaddr *)&addr, &len) < 0) {
> +        return -1;
> +    }
> +
> +    return ntohs(addr.sin_port);
> +}
> +
> +static int inet_get_free_port_multiple(int nb, int *port)
> +{
> +    int sock[nb];
> +    int i;
> +
> +    for (i = 0; i < nb; i++) {
> +        sock[i] = socket(AF_INET, SOCK_STREAM, 0);
> +        if (sock[i] < 0) {
> +            break;
> +        }
> +        port[i] = inet_get_free_port_socket(sock[i]);
> +    }
> +
> +    nb = i;
> +    for (i = 0; i < nb; i++) {
> +        closesocket(sock[i]);
> +    }
> +
> +    return nb;
> +}
> +
> +static int inet_get_free_port(void)
> +{
> +    int nb, port;
> +
> +    nb = inet_get_free_port_multiple(1, &port);
> +    g_assert_cmpint(nb, ==, 1);
> +
> +    return port;
> +}
> +
> +static void test_stream_inet_ipv4(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    int port;
> +
> +    port = inet_get_free_port();
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=true,addr.type=inet,"
> +                       "addr.ipv4=on,addr.ipv6=off,"
> +                       "addr.host=localhost,addr.port=%d", port);
> +
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev stream,server=false,id=st0,addr.type=inet,"
> +                       "addr.ipv4=on,addr.ipv6=off,"
> +                       "addr.host=localhost,addr.port=%d", port);
> +
> +    expect = g_strdup_printf("st0: index=0,type=stream,tcp:127.0.0.1:%d\r\n",
> +                             port);
> +    EXPECT_STATE(qts1, expect, 0);
> +    g_free(expect);
> +
> +    /* the port is unknown, check only the address */
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:127.0.0.1", ':');
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +}
> +
> +static void test_stream_inet_ipv6(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    int port;
> +
> +    port = inet_get_free_port();
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=true,addr.type=inet,"
> +                       "addr.ipv4=off,addr.ipv6=on,"
> +                       "addr.host=localhost,addr.port=%d", port);
> +
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev stream,server=false,id=st0,addr.type=inet,"
> +                       "addr.ipv4=off,addr.ipv6=on,"
> +                       "addr.host=localhost,addr.port=%d", port);
> +
> +    expect = g_strdup_printf("st0: index=0,type=stream,tcp:::1:%d\r\n",
> +                             port);
> +    EXPECT_STATE(qts1, expect, 0);
> +    g_free(expect);
> +
> +    /* the port is unknown, check only the address */
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:::1", ':');
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +}
> +
> +static void test_stream_unix(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    gchar *path;
> +    int ret;
> +
> +    ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
> +    g_assert_true(ret >= 0);
> +    close(ret);
> +
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=true,"
> +                       "addr.type=unix,addr.path=%s,",
> +                       path);
> +
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=false,"
> +                       "addr.type=unix,addr.path=%s",
> +                       path);
> +
> +    expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
> +    EXPECT_STATE(qts1, expect, 0);
> +    EXPECT_STATE(qts0, expect, 0);
> +    g_free(expect);
> +    unlink(path);
> +    g_free(path);
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +}
> +
> +static void test_stream_unix_abstract(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    gchar *path;
> +    int ret;
> +
> +    ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
> +    g_assert_true(ret >= 0);
> +    close(ret);
> +
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=true,"
> +                       "addr.type=unix,addr.path=%s,"
> +                       "addr.abstract=on",
> +                       path);
> +
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=false,"
> +                       "addr.type=unix,addr.path=%s,addr.abstract=on",
> +                       path);
> +
> +    expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
> +    EXPECT_STATE(qts1, expect, 0);
> +    EXPECT_STATE(qts0, expect, 0);
> +    g_free(expect);
> +    unlink(path);
> +    g_free(path);
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +}
> +
> +static void test_stream_fd(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    int ret, sock0, sock1;
> +    struct sockaddr_un addr;
> +    gchar *path;
> +
> +    ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
> +    g_assert_true(ret >= 0);
> +    close(ret);
> +    addr.sun_family = AF_UNIX;
> +    strcpy(addr.sun_path, path);
> +
> +    unlink(addr.sun_path);
> +    sock0 = socket(AF_LOCAL, SOCK_STREAM, 0);
> +    g_assert_cmpint(sock0, !=, -1);
> +
> +    ret = bind(sock0, (struct sockaddr *)&addr, sizeof(addr));
> +    g_assert_cmpint(ret, !=, -1);
> +
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=true,"
> +                       "addr.type=fd,addr.str=%d",
> +                       sock0);
> +
> +    EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> +    sock1 = socket(AF_LOCAL, SOCK_STREAM, 0);
> +    g_assert_cmpint(sock1, !=, -1);
> +
> +    ret = connect(sock1, (struct sockaddr *)&addr, sizeof(addr));
> +    g_assert_cmpint(ret, !=, -1);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev stream,id=st0,server=false,addr.type=fd,addr.str=%d",
> +                       sock1);
> +
> +
> +    expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
> +    EXPECT_STATE(qts1, expect, 0);
> +    EXPECT_STATE(qts0, expect, 0);
> +    g_free(expect);
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +
> +    closesocket(sock0);
> +    closesocket(sock1);
> +
> +    g_free(path);
> +}
> +
> +static void test_dgram_inet(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    int port[2];
> +    int nb;
> +
> +    nb = inet_get_free_port_multiple(2, port);
> +    g_assert_cmpint(nb, ==, 2);
> +
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,"
> +                       "local.type=inet,local.host=localhost,local.port=%d,"
> +                       "remote.type=inet,remote.host=localhost,remote.port=%d",
> +                        port[0], port[1]);
> +
> +    expect = g_strdup_printf("st0: index=0,type=dgram,"
> +                             "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
> +                             port[0], port[1]);
> +    EXPECT_STATE(qts0, expect, 0);
> +    g_free(expect);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,"
> +                       "local.type=inet,local.host=localhost,local.port=%d,"
> +                       "remote.type=inet,remote.host=localhost,remote.port=%d",
> +                        port[1], port[0]);
> +
> +    expect = g_strdup_printf("st0: index=0,type=dgram,"
> +                             "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
> +                             port[1], port[0]);
> +    EXPECT_STATE(qts1, expect, 0);
> +    g_free(expect);
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +}
> +
> +static void test_dgram_mcast(void)
> +{
> +    QTestState *qts;
> +
> +    qts = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,"
> +                       "remote.type=inet,remote.host=230.0.0.1,remote.port=1234");
> +
> +    EXPECT_STATE(qts, "st0: index=0,type=dgram,mcast=230.0.0.1:1234\r\n", 0);
> +
> +    qtest_quit(qts);
> +}
> +
> +static void test_dgram_unix(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    gchar *path0, *path1;
> +    int ret;
> +
> +    ret = g_file_open_tmp("netdev-XXXXXX", &path0, NULL);
> +    g_assert_true(ret >= 0);
> +    close(ret);
> +
> +    ret = g_file_open_tmp("netdev-XXXXXX", &path1, NULL);
> +    g_assert_true(ret >= 0);
> +    close(ret);
> +
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
> +                       "remote.type=unix,remote.path=%s",
> +                       path0, path1);
> +
> +    expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
> +                             path0, path1);
> +    EXPECT_STATE(qts0, expect, 0);
> +    g_free(expect);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
> +                       "remote.type=unix,remote.path=%s",
> +                       path1, path0);
> +
> +
> +    expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
> +                             path1, path0);
> +    EXPECT_STATE(qts1, expect, 0);
> +    g_free(expect);
> +
> +    unlink(path0);
> +    g_free(path0);
> +    unlink(path1);
> +    g_free(path1);
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +}
> +
> +static void test_dgram_fd(void)
> +{
> +    QTestState *qts0, *qts1;
> +    char *expect;
> +    int ret;
> +    int sv[2];
> +
> +    ret = socketpair(PF_UNIX, SOCK_DGRAM, 0, sv);
> +    g_assert_cmpint(ret, !=, -1);
> +
> +    qts0 = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,local.type=fd,local.str=%d",
> +                       sv[0]);
> +
> +    expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[0]);
> +    EXPECT_STATE(qts0, expect, 0);
> +    g_free(expect);
> +
> +    qts1 = qtest_initf("-nodefaults "
> +                       "-netdev dgram,id=st0,local.type=fd,local.str=%d",
> +                       sv[1]);
> +
> +
> +    expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[1]);
> +    EXPECT_STATE(qts1, expect, 0);
> +    g_free(expect);
> +
> +    qtest_quit(qts1);
> +    qtest_quit(qts0);
> +
> +    closesocket(sv[0]);
> +    closesocket(sv[1]);
> +}
> +
> +int main(int argc, char **argv)
> +{
> +    int ret;
> +
> +    g_test_init(&argc, &argv, NULL);
> +
> +    qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
> +    qtest_add_func("/netdev/stream/inet/ipv6", test_stream_inet_ipv6);
> +    qtest_add_func("/netdev/stream/unix", test_stream_unix);
> +    qtest_add_func("/netdev/stream/unix/abstract", test_stream_unix_abstract);
> +    qtest_add_func("/netdev/stream/fd", test_stream_fd);
> +    qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
> +    qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
> +    qtest_add_func("/netdev/dgram/unix", test_dgram_unix);
> +    qtest_add_func("/netdev/dgram/fd", test_dgram_fd);
> +
> +    ret = g_test_run();
> +
> +    return ret;
> +}



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 06:43:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 06:43:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431410.684294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJ5d-0004FJ-2v; Fri, 28 Oct 2022 06:43:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431410.684294; Fri, 28 Oct 2022 06:43:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJ5c-0004FC-U8; Fri, 28 Oct 2022 06:43:36 +0000
Received: by outflank-mailman (input) for mailman id 431410;
 Fri, 28 Oct 2022 06:43:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lonw=25=gmail.com=christopher.w.clark@srs-se1.protection.inumbo.net>)
 id 1ooJ5b-0004F6-0Q
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 06:43:35 +0000
Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com
 [2001:4860:4864:20::2d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d75050e9-568b-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 08:43:33 +0200 (CEST)
Received: by mail-oa1-x2d.google.com with SMTP id
 586e51a60fabf-13ae8117023so5321615fac.9
 for <xen-devel@lists.xenproject.org>; Thu, 27 Oct 2022 23:43:33 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d75050e9-568b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=i6p1KV4ytSklt9xMenkyq+EiW3duis9GchqXYiC9M78=;
        b=LPwCloR3CsEWelubuXseWVRC7KelKlbC8Ur6BRz9MOijLZXlkgjOW2PYGf2yZQyV3N
         VBpMQdAuTM2ZRFz7nDlXPzmM6CG7NYMWEi5e0SjXuO1mdWKWipNj6dT3VjsOtuLzhmHw
         l7EtrIvXAPWdZy1S3sPLD5LC+2jjbkEMxZOP0mrVgkcOHaAlKEkoP2JQ9kSsjFGfwSiH
         gl7NPxq0FbOkt/SbNfzXqzPGbO0tBP6M89RrP3VpAccHPRojVjeVWUst9f9lB6L376VG
         Oih967UMOINLMO0RTKFl0K8BXVPcPB1Pi2uWJpapPGmhKmTZZDYlTFFUIxtr3ZVSKsw3
         8KmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=i6p1KV4ytSklt9xMenkyq+EiW3duis9GchqXYiC9M78=;
        b=RJ2oOhDfqqFcrZgZQoyZIH7ii+zzYGs4lI1HDMpqPwGWSujYYnHY5RSHjFFm8+aT5Q
         CeuIh6Q1c8erl+Gi7LFIRjF7J12Jqt1ZC3XOEqtnEqRTxv64uHFMIEgDwgS2HbfwakQE
         KSKKabG7ut45+XG9kgrvO4V3qUzaIL7Vrox4UbwcRt4bz41rIluKJ9oABHnabJrO637G
         pOGZfnfOEVcltkwuE5esw3/H0vRZrkyviQQIohRr66e48Ff0Ipi9X2Ma0tZaV4jFjfn1
         FW2rmQ/qAriAPXqe66EYoYxtKXAAO4cOKoePs8rtHwS0lYIe2YXDUitoP+Drr/XyrCDE
         1Glg==
X-Gm-Message-State: ACrzQf1LeHJYU+SKEdJXBV3WsAr173OnSctiv9yUVnEbCNc/CsJJuk4U
	PYO9xrVBA12WnsSMRzzLJZghceBZyIiO2ShpFD4=
X-Google-Smtp-Source: AMsMyM5NuL6YUV50dCVUqfeeEmBHTyarOguI/BO8Q8n4OZkIP/q+oY8SZW+q2+2obUwwvQeqJjwm4ZhkjQZkFwpktQ0=
X-Received: by 2002:a05:6870:6394:b0:13c:7d1c:8604 with SMTP id
 t20-20020a056870639400b0013c7d1c8604mr1009277oap.184.1666939412597; Thu, 27
 Oct 2022 23:43:32 -0700 (PDT)
MIME-Version: 1.0
References: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
In-Reply-To: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Christopher Clark <christopher.w.clark@gmail.com>
Date: Thu, 27 Oct 2022 23:43:21 -0700
Message-ID: <CACMJ4GYr_R-yKCxUVGjcZgcCFmHNQa9Ts=_F-pdN-rgvsrCVWA@mail.gmail.com>
Subject: Re: Feedback for postponing the 4.17 release to a week later
To: Henry Wang <Henry.Wang@arm.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, 
	"christopher.clark@starlab.io" <christopher.clark@starlab.io>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	Julien Grall <julien@xen.org>, Julien Grall <jgrall@amazon.com>, 
	Stefano Stabellini <stefano.stabellini@xilinx.com>, 
	"sstabellini@kernel.org" <sstabellini@kernel.org>, "jgross@suse.com" <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Anthony PERARD <anthony.perard@citrix.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Wei Liu <wl@xen.org>, "Wei Liu (LSG)" <liuwe@microsoft.com>, 
	Bruce Ashfield <bruce.ashfield@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000008cd11505ec129316"

--0000000000008cd11505ec129316
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 27, 2022 at 9:44 PM Henry Wang <Henry.Wang@arm.com> wrote:

> Hi all,
>
> Since there will be a batch of XSAs released on Nov. 1 [1] and the
> original date for
> the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the
> 4.17
> release to a week later (Nov. 11) to give a little bit longer time so that:
>
> - The security team won't do anything in rush.
> - We can have more feedback after merging these XSAs.
> - Include more release-relevant bugfixes.
>
> May I please have some feedback on this proposal? Thanks very much!
>

I think you have presented an appropriate rationale for the date
adjustment, so I am supportive of it.

As for effect on downstreams: I don't think that this change of date will
negatively affect OpenEmbedded and Yocto (+CC Bruce for visibility).

Christopher


>
> [1] https://xenbits.xen.org/xsa/
>
> Kind regards,
> Henry
>
>

--0000000000008cd11505ec129316
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Oct 27, 2022 at 9:44 PM Henry Wan=
g &lt;<a href=3D"mailto:Henry.Wang@arm.com">Henry.Wang@arm.com</a>&gt; wrot=
e:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex">Hi all,<br>
<br>
Since there will be a batch of XSAs released on Nov. 1 [1] and the original=
 date for<br>
the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the 4=
.17<br>
release to a week later (Nov. 11) to give a little bit longer time so that:=
<br>
<br>
- The security team won&#39;t do anything in rush.<br>
- We can have more feedback after merging these XSAs.<br>
- Include more release-relevant bugfixes.<br>
<br>
May I please have some feedback on this proposal? Thanks very much!<br></bl=
ockquote><div><br></div><div>I think you have presented an appropriate rati=
onale for the date adjustment, so I am supportive of it.</div><div><br></di=
v><div>As for effect on downstreams: I don&#39;t=C2=A0think that this chang=
e of date will negatively affect OpenEmbedded and Yocto (+CC Bruce for visi=
bility).</div><div><br></div><div>Christopher</div><div>=C2=A0</div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex">
<br>
[1] <a href=3D"https://xenbits.xen.org/xsa/" rel=3D"noreferrer" target=3D"_=
blank">https://xenbits.xen.org/xsa/</a><br>
<br>
Kind regards,<br>
Henry<br>
<br>
</blockquote></div></div>

--0000000000008cd11505ec129316--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 06:51:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 06:51:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431415.684304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJDB-0005uc-Qu; Fri, 28 Oct 2022 06:51:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431415.684304; Fri, 28 Oct 2022 06:51:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJDB-0005uV-NR; Fri, 28 Oct 2022 06:51:25 +0000
Received: by outflank-mailman (input) for mailman id 431415;
 Fri, 28 Oct 2022 06:51:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mkji=25=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ooJDA-0005uP-Is
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 06:51:24 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef2e2934-568c-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 08:51:23 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 55EAB1F921;
 Fri, 28 Oct 2022 06:51:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CDCC51377D;
 Fri, 28 Oct 2022 06:51:21 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4wylMOl7W2PESgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 28 Oct 2022 06:51:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef2e2934-568c-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666939882; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=h5k7lKh7CDfIxFHjHAAvrPqXcRUX/v7MaVm45cX1eFc=;
	b=PhnRV8EPaqZC+DhonO/r32S6mSTAaLzoU4KoIftXX9BT385Nmuz/MPygp04IiDd19Zm5yN
	x3AIU0WHaVrRQrqQOgGVwqxGNzf8OVwOkOrVGf3DYNBLOKDulWa5WDFTYhBY5adwytIPYO
	B+6JnGUqlU6oGAfO7ZYyCkwgDmtJHWw=
Message-ID: <61534be4-a2a0-bda3-7e0d-e5ff00f89d86@suse.com>
Date: Fri, 28 Oct 2022 08:51:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: Feedback for postponing the 4.17 release to a week later
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 "christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
 "christopher.clark@starlab.io" <christopher.clark@starlab.io>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>,
 Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 "Wei Liu (LSG)" <liuwe@microsoft.com>
References: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Juergen Gross <jgross@suse.com>
In-Reply-To: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------DqW3jnHdLXosqFNSWcWBUMva"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------DqW3jnHdLXosqFNSWcWBUMva
Content-Type: multipart/mixed; boundary="------------QLTWUCuotKkWw7zlMOHQNdT0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 "christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
 "christopher.clark@starlab.io" <christopher.clark@starlab.io>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>,
 Julien Grall <jgrall@amazon.com>,
 Stefano Stabellini <stefano.stabellini@xilinx.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 "Wei Liu (LSG)" <liuwe@microsoft.com>
Message-ID: <61534be4-a2a0-bda3-7e0d-e5ff00f89d86@suse.com>
Subject: Re: Feedback for postponing the 4.17 release to a week later
References: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
In-Reply-To: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>

--------------QLTWUCuotKkWw7zlMOHQNdT0
Content-Type: multipart/mixed; boundary="------------akGzOmXFJkBju7f0GRrjeyEP"

--------------akGzOmXFJkBju7f0GRrjeyEP
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjguMTAuMjIgMDY6NDMsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+IEhpIGFsbCwNCj4gDQo+
IFNpbmNlIHRoZXJlIHdpbGwgYmUgYSBiYXRjaCBvZiBYU0FzIHJlbGVhc2VkIG9uIE5vdi4g
MSBbMV0gYW5kIHRoZSBvcmlnaW5hbCBkYXRlIGZvcg0KPiB0aGUgNC4xNyByZWxlYXNlIHdh
cyBzdXBwb3NlZCB0byBiZSBOb3YuIDIsIEkgYW0gdGhpbmtpbmcgdG8gcG9zdHBvbmUgdGhl
IDQuMTcNCj4gcmVsZWFzZSB0byBhIHdlZWsgbGF0ZXIgKE5vdi4gMTEpIHRvIGdpdmUgYSBs
aXR0bGUgYml0IGxvbmdlciB0aW1lIHNvIHRoYXQ6DQo+IA0KPiAtIFRoZSBzZWN1cml0eSB0
ZWFtIHdvbid0IGRvIGFueXRoaW5nIGluIHJ1c2guDQo+IC0gV2UgY2FuIGhhdmUgbW9yZSBm
ZWVkYmFjayBhZnRlciBtZXJnaW5nIHRoZXNlIFhTQXMuDQo+IC0gSW5jbHVkZSBtb3JlIHJl
bGVhc2UtcmVsZXZhbnQgYnVnZml4ZXMuDQo+IA0KPiBNYXkgSSBwbGVhc2UgaGF2ZSBzb21l
IGZlZWRiYWNrIG9uIHRoaXMgcHJvcG9zYWw/IFRoYW5rcyB2ZXJ5IG11Y2ghDQoNClRoZSBh
bHRlcm5hdGl2ZXMgd291bGQgYmU6DQoNCi0gbm90IGluY2x1ZGluZyB0aGUgWFNBcyBpbiA0
LjE3IChJTU8gYSBiYWQgaWRlYSkNCi0gZG9uJ3QgZG8gZmluYWwgdGVzdHMgd2l0aCB0aGUg
WFNBcyBpbmNsdWRlZCAoYW5vdGhlciBiYWQgaWRlYSkNCg0KVGhpcyBpcyBhIGNsZWFyIGlu
ZGljYXRpb24gZm9yIG1lIHRvIGRlbGF5IHRoZSByZWxlYXNlLCBsaWtlIHdlIGRpZCBpbg0K
c2ltaWxhciBjYXNlcyBpbiB0aGUgcGFzdCBzZXZlcmFsIHRpbWVzLg0KDQoNCkp1ZXJnZW4N
Cg==
--------------akGzOmXFJkBju7f0GRrjeyEP
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------akGzOmXFJkBju7f0GRrjeyEP--

--------------QLTWUCuotKkWw7zlMOHQNdT0--

--------------DqW3jnHdLXosqFNSWcWBUMva
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNbe+kFAwAAAAAACgkQsN6d1ii/Ey+U
dwf9HaxcBmAlAAcW9mxngJRqUwESjAHSdxMGXO3MVXz5jWpvByhCB5EqN0ZSexbl2jxVhGgEWAz9
qETzkT/vxqJPV19Kf2UGMuHHmD7n/jw7cTdRyL6D7d2lLQX+U4XK1TcSVx5EQjR8n3O/9tdNhUBq
8xZ5NvTdIjO9o2csfkUBa/0KockzpLNYDs82j7jafsJo4bAdzYcGXvnbPxJ/rvdP6+KEBTI8FzuJ
VxwU10B0zjJWQjuAnLFKIv80r3oJ7nPdGwUqoCVyoQ+fPz53XxPWpyyNYAuGo01majvg5y9KISNo
wAMEHbQiKSYb4qWk0w7L4SgEvy5N7XXkkokljxea9A==
=kpst
-----END PGP SIGNATURE-----

--------------DqW3jnHdLXosqFNSWcWBUMva--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 07:20:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 07:20:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431427.684315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJf1-0001Zm-34; Fri, 28 Oct 2022 07:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431427.684315; Fri, 28 Oct 2022 07:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJf0-0001Zf-Vo; Fri, 28 Oct 2022 07:20:10 +0000
Received: by outflank-mailman (input) for mailman id 431427;
 Fri, 28 Oct 2022 07:20:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jtyv=25=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ooJez-0001ZY-Ac
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:20:09 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f33a4795-5690-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 09:20:08 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM9PR04MB8472.eurprd04.prod.outlook.com (2603:10a6:20b:417::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 07:20:06 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022
 07:20:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f33a4795-5690-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D2driBkH+SkgUJfaR4WQwhD/rRn3KK6fHC8ChnTnfE3llAV6zhgj2ro5j+3abgPSN6GPG8E936QStyd3qcpN1M+5BuHfmYHuoq5QnMfJHtkkSg5a3zJx4i6ezQhpa9pgz5F4YHdP3J/M4cOYxYOzhvnLvPFOqXNVG9zwXZNvys+wXfw2aqIhyhqpb537wzf+gzmYInXRCeQ5hRFIzeS7JX3xwvTSNPCeyneFFUFmnk5zUrmTs8tg7hRxZV86BG6yMS5T8jBVgF7zYUUbhVKbEvCvsD3Y8hxh60TC9WAdw+2xs0rLJDYyJRDbiqBqFNOEC7kvWol27rhd10z1X0ROOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8s3DrhwpFVg9TFqBsTME7Gej+yEW6H1ixYRhJdqtmH8=;
 b=OrSmqaDxHtTLbefRjVrhLu+4GpAJuAgDdg4ikl5C0upppm2rL0A7wpzfiMpcAB4MRKsyA7ywnplpPt3z4X38RYBvtSJBi6s+fTFzieHBYi1Oro1q899D9LkVoL6j/FFL+veK24CoPeTsM3+hCv8EBthnB/01XaKxXDJ/sn+R5IUalBpAwisbOuobIGIlWs+yWShRUmukjb739C0Zjn3it/KV3HlhxkzSRs+eROlT+x7eeEzF/w4y0gTwuYEjKX81v/bFU0B+l4TL6NKmVVQqtbuf3V3s7YB0LIr2WIp8SCTHv0CCBZ4+nTp7Xo7YQNS4xhO0mz91H0Tar5v5Fk7sSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=8s3DrhwpFVg9TFqBsTME7Gej+yEW6H1ixYRhJdqtmH8=;
 b=y60ogv4cv2fPFBARRe2J//44HD3vy2enPOVkCVx02FK5/AvbHJ5XN79eqBP4oGV8yoSj8ecIxnfzVffnXDfc4OcDDfz0Y90qXZUrO9IchjPZ9NDQqUTqVgcuJljcTzZ3TqcYc8PTUwKKgtjzC+6XaITJTnp6Zm9ehDUZXMrFtfU9cTofECte/0dEOdNAXv2g/U3foxHSTBJ+4DUA+3YRzR7E6u7CVTjJD4dRJ1HvPRCLtK+1XdN8bW5SPaYxWMlVAu2hw4T1AcnfmyoY36mRRhQEga/85Jm4xKzS093ht23yTTJwcKVbxxJ50oH3m1eXy33uV9KIOpCElC7zDcAv0w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
Date: Fri, 28 Oct 2022 09:20:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>, George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0120.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a3::18) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8472:EE_
X-MS-Office365-Filtering-Correlation-Id: 96a4f49f-27f1-4680-24ad-08dab8b4d6be
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PhHQiuI/KTWBIz2TXQYvWUy4MfQV6HWChryArFWpAk5EGhDKktvoyaiT5x6OhB7gNJdhIsNawHOSE3Jl9gYUAnyTBoxrLtj73e+ScSdcbPY166xQk7E3InC0z3xEwkiiOvUjMfzDY4UQvERTbEwcO0rZTjfHYgmXfK780UvplRZwY5xakbiCE5LofmuV9WqbziV5zRVj0jXGqZhkjvodi5nM41b4G/p4iggErgNmE8ZKNloJ63flgg76C7hTNeTMuQVH7jG+JgteY4o4gDwDNSKNflrcVT+ak89JraFa58jXz3EN7PKett1V8tD0p2pFdKKpLNJR6ZzkEoAvoaqAnOJvsiEI6QZtx07CXuaXhlO1p9oNKh4+nEI5hCiU5Rf/vw8Z5qtos9jfbNPRV5sD2HhmrkNarSIurHsRgTUySprintTdYP72iMh/t35zjYhaqIDkkcmCAgg8dhnEXxBvUD1tFtfJUthL+KQT/kQCVJU2WZUScR1i7tZvVTNGN1IuNoL0f2HyumJOboFe5jHYK2nRQlAG4TlhkBeWFm727bi3Gg6gfJpiGOW1mxQAJ2ThsI0ruI7e+y73SB79D7f3tYZokg2tAfE7+tzrZlyD2T/R/qvHbKQP0F3kP/iDSJF/daZM5hxkq/bhFCGaP0Uo+K1AbpCT9Y5QwoW3GeOIDS4/W0B6/hvfZF5WDa6GxXxFS/5KelYtI5ooUYnE4xCHTACz2uClBqWZEyekIQA8OwjQa1NA3OzNRNS7p2AJGDPPTW222Wokx8dGA8wiGcGkaqx+bYjRBjCJvlUTghTVKD0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(396003)(376002)(451199015)(66476007)(8676002)(4326008)(6486002)(66946007)(66556008)(54906003)(6916009)(2906002)(316002)(5660300002)(4744005)(41300700001)(8936002)(38100700002)(6506007)(186003)(2616005)(26005)(6512007)(478600001)(83380400001)(31696002)(31686004)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDJGUEUwSDZhVHE2NG8rNWdLU1lNVUpmdWU0dkk4RTRDL2RRWFBkMzdhOFpu?=
 =?utf-8?B?NE5EbHJUMGRsUUtJQTJMSG5tUjFpa2djdC85c1piTEdiMmF4MEltYjVKZHdY?=
 =?utf-8?B?b3VwYTI5VmtvRDd6NTE2cHpHRmYzSnkveEtsbzRMcmE5VFpmNjIrcGpsZWdt?=
 =?utf-8?B?YkhBaUY5bTc4Q0tjdFEzcjN0TEtTbXVLdnE4dzVWN29WZ1UxcEwyejROVHFQ?=
 =?utf-8?B?cSt2SkZZdHF0V3I2Vm5JK25EazdxTzBMYmQ0dVhpODkyRjBHalFVcFdyM2Q4?=
 =?utf-8?B?ZHBra3VqUEdFK3pNVnFidlBKT0hOUmNHbkxrQ3k3anRqL1d6RnFtM0k5Lzlp?=
 =?utf-8?B?dncyM1E4aHhFUGpTRXBBVlByOXBMNXVFY0xleFU2eCtvWWpxazMwaVQwd2U4?=
 =?utf-8?B?YlRXdS9GV1Zzby8rMXhBYyt3eVovaUFLbWlaT28zUC82NXdXK0lORDFnQWVK?=
 =?utf-8?B?dEdmeWVNbGpleURiZzFOQVRoRm16OWFtUGRORVdIZHZWL2FKQWdHYUJYd2Rq?=
 =?utf-8?B?SngzOUcrV3NjWnZCM01jK0tDYnhGTlNjUEZ0OUJBRUN4WnFVbVBlaWRJUWpH?=
 =?utf-8?B?REVkTGhweUlRbTdXWVRmbjNza1lNUXY1cmJJMkh5M2k5QTVCSGttTyt1N1cx?=
 =?utf-8?B?MTkyZEJtdVJrQjc3YXJhUkcyblhZeUt3UW9pSllBWitwMEdjOThiV1MyWUsz?=
 =?utf-8?B?UjhKMk5tM3owbGVWaE1kMmc2QXU4WkllOTN1UUNPNkpJSU9xWUkzczhldENr?=
 =?utf-8?B?NkpjSTZNMTlGZnE5N3RVemNaQnd4SVJ4TkQrdlFKdGlPalA0ejJnK3J4T2Z3?=
 =?utf-8?B?Q2M4OFZ4T2pFUDRWdnBpcEFsRHE1OGVXaUU5TmRzMlp6YWh4YUU4aFZGVEVp?=
 =?utf-8?B?ZEpCR1NzZnZ4OWpUOWZNa29RcDNVWjZtMkt2VjhjbmFzOG8wOHd4SVRHOFNU?=
 =?utf-8?B?RkRSV3pKbjJSN002LzU2ZjJRcGR3SEtycnl0Uk0wZUZSeld4S0xwZ2JWUlpB?=
 =?utf-8?B?eXpqL2dFRUhreDBLZEJ3ejREUHRDNFV0cG1tZi9hUXcwUGFRNldaRDdTR3RV?=
 =?utf-8?B?SEcvU2VhV0JINm04RFBLWjBGU2RXMVA5ZEFyL2JUS0szUHJTWlRTN2kvaXpk?=
 =?utf-8?B?YWl2TEQzUzUyTnJ2MzdRTUExZWJQaXJqYnNrSnh6N3NaYmdYYVZWclhlanhu?=
 =?utf-8?B?MmxTdUpZZDF4L2c2WUlYcWlqNzNkNWM3eTNWRDZ6bmpjL2JqeVZiREtDM2Y5?=
 =?utf-8?B?c0RSUVZqNjVPUzRHRzd1UTl6WGVwU0I1YlRqTnh4b1BLR1RzelVPMmdzRE13?=
 =?utf-8?B?ajRLSldUSncycFFTdlZ0U09Nbk80cjgzTHYxYzBZZ2svSE1HaWY1QTU5eEdE?=
 =?utf-8?B?cnBYMzFzelRkT1ZKL3RGR3ZUanFCa2UydERvR1VMU2ZxejZuWVVBVmw5bThJ?=
 =?utf-8?B?SmVpNCtxRVVnUUtWK3ZXanJYZmdvT3hOMTFCczFaZFg1VzJLZDh0OVFQd3Av?=
 =?utf-8?B?eWJZRElHcWF3azdmUjdLS2JOemRUanl1K2d0dlpmUVp5MTBpMjljRW4wRlJU?=
 =?utf-8?B?QjVFclNSSFIyYVB6L3JJejloVlhEcGdMYWEvVkI0QmUyMXlFVjNQaisvL3Qw?=
 =?utf-8?B?TDFUM1AwczBOMDQ4ZmpxRmhaa0szWDMvVDgreXhFSUhQeEdrWFBvbEl5a3J0?=
 =?utf-8?B?bjVlRnA1U2lTc1MrN0FENzI1N2RKWmh6YVc4d3Nva0JsSGl5N0ZWQ0phTEpn?=
 =?utf-8?B?SWNGdXMyVWptOGpJVndpMTJ1TVpuKzRhY3F1aldUMHY3cjBUUDdIM0xPNWNi?=
 =?utf-8?B?M2VZbGxOWGFWZCszOUdXelJIcnZxTVZTWFJoTExIMXVWWGR5ckx2VWtWeU9N?=
 =?utf-8?B?QWJMMzVYMDRjeEM3VFBxQ2NGWkRFcEZkSXBlZmYvL1E0SURtWGNYWnlnU1BJ?=
 =?utf-8?B?TGlyZHVtTFZRODMvQXBkRzNMc3lzbG1NQUJtNjBHdVpMTnNpbWJaTUI0YURt?=
 =?utf-8?B?YVRzMUtkRjNkMUM2ZGszZWRmdWNHQzYxNTEvWnpZOXV5VkVLZHArbzZTaERt?=
 =?utf-8?B?aEQ5SjVra1ZqQ3Exa1poU0ZqeDZoOEl3d1ZkUEE3MEJObTBqY2U2MXluZGhL?=
 =?utf-8?Q?FNcSp38tbS1zJf/LEDj2Kbs++?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96a4f49f-27f1-4680-24ad-08dab8b4d6be
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:20:06.4318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K1dm8HkAFfkbdTzHrz1R4xZLWlEzVB4l0d2maaSNYZifQBWcD8nCE6SYXLQsMRbls1l6DiPxYxT+FpIi7j1ELQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8472

These patches have (as a single, monolithic one) been living in
the XenServer patch queue for quite some time. While preparing for
this upstream submission, I've left the code largely as is (only a
few cosmetic adjustments, but no functional changes), so the series
can be assumed to have been properly tested. What I did fully alter
though are the descriptions.

1: correctly ignore empty onlining requests
2: correct ballooning up for compat guests
3: correct ballooning down for compat guests

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 07:21:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 07:21:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431433.684326 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJgk-00028a-Ev; Fri, 28 Oct 2022 07:21:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431433.684326; Fri, 28 Oct 2022 07:21:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJgk-00028T-Bv; Fri, 28 Oct 2022 07:21:58 +0000
Received: by outflank-mailman (input) for mailman id 431433;
 Fri, 28 Oct 2022 07:21:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jtyv=25=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ooJgj-00028L-8O
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:21:57 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2075.outbound.protection.outlook.com [40.107.104.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33c60a38-5691-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 09:21:56 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9264.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 07:21:53 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022
 07:21:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33c60a38-5691-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MV5erz9oEQdMcoEAm3htOgDfSAXy6K5nmnLq48x7fXdZcRS8i63DziepT2Mkuw8hl2Tk9lPlsAybmptrLfOodvkQxo7RE5lQeHbqXP6j/w/m5lJt9uvG6fXQKBYvFJJeHPX4YouAOE6MbCwvpjZN5pvkzJiuPSJ1ZSG18aM7L+vlU4Z6GWboPpGOeZdev4yCD+9N/Lk87fwMj9ipPMRJkyy7gpIxQ5ViqbitBeTtxggMIUCP+VdGSArUyXyMycz1yrvJH1uF3k98vJtNxgavBadg3lBmijL1bUOZx6oR1Xs89Y47DMUvo9+INis98XILfZocLFXbXCh7v295FmKg7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YIhWJYPncYb8h4kWhPCveJpPZuHkPif4kdTPxSU2Ykg=;
 b=QZUyx5uiObIxM1V5G7249iHsNDqtsQYm6a5rdV8d8GVpkHVs7GVxb7+gWsKSpOLtp0NIelOGr51z0BwfMeOsvI0VrthesU1CGrtZffxTehIfIXq2w44zFpseSuPoTkdW9NRywalD6FLStgFT8fCwj0QSS2VagPs/lMKl5GUzIrdMz3aHHcUFM1EB8iak4yimRqPR6/VR7rO1siAv+5tMvEz7x9gvvisBx6W8EkAt8N2CTo3/+ki9/XqZxaB7AtYAD6mulhXvjJz5JWdqMRPlVX5u0T2ayU5wWw7k1xYO7mvz2TPrPLL6e2r8d4HB4UjxZP07x0tREaoDxlepV8zP2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YIhWJYPncYb8h4kWhPCveJpPZuHkPif4kdTPxSU2Ykg=;
 b=wbUyDYfI11shxrh2N9Z8wo0Vm5eMMWZMfjyHWvxBWW2yqjnkNHrPqxhyIlALufhum8/xSlxY+TM45JPKGZbv4Z5uPIl4jSjbzF69gg2nLO9fJsc+1qRLRuIQoJT+yl3xVSeFDkaJ6Bbl2phXurPlV1nSJaSrRjLwCaunVxaWM+yJJqsFU1R/IYslQyTz5VdTpcgSK/bwrPZOe9WvDUpfkvA6wWtD1MQYYSmB5vKLcr1KGhbZQAgCRr2iFGGkVRVnoC1CHzu/H96x8uQ8YvCmwlNusep7DnmlF5+DRhLPuYUydrBcAx3v0PdrlK+Jc3nSZLdGWdjOnvxLd1jJhvIl5A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2678ded5-f3d1-12de-91b4-ef2ac14cd5d9@suse.com>
Date: Fri, 28 Oct 2022 09:21:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: [PATCH 1/3][4.17?] x86/pv-shim: correctly ignore empty onlining
 requests
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>, George Dunlap <george.dunlap@citrix.com>
References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AS9PR04CA0037.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::28) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9264:EE_
X-MS-Office365-Filtering-Correlation-Id: f9cd2d88-69a6-40bc-b50e-08dab8b51675
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NMW+S6LP+vkSEiRuif0795HAyFavCXKTAcvuAViytGUm/D4uP5BhCN8e7y3/3gUv31DQniY7q6F9CCfcM/84tTulwuEQ5ThVFHykeBLbkwtqYjJu6c7qbdpFQy7uNnyHfsftezIBuPzj5qEJ/dizm0jJN6UJ3f6Ty2CBphM8MCoudg5Lq0NqP2abfd+AILV1jxfppkqY5+V1UKMeAi9FrZFIxFZd5bM4WxR4W4COvwCUTtO4DLepC7NBYjUuXlBmB08VwLSJuj14FlfczQ4arTCboZZGfyjh4QXRPsyNwtjPRuWPN3mr18d6VyFCIHNgHCcBZRG9c85m7lzouW6YSgeAdC8FWZhl3BP/gAWqgb6tPChVX5MB9J8QUnX09Jfgy3R3MApvAxPmVxHHFwyuW0UX62f7zkQLXq4o39VMt4Or9X1eyJ0ANsyNmGUtaBIZl+Vjgg8ktIgP4EvNyrPEVtoFO6oj5EmoaJAYllcNABdOEXGgEF342LLAMDYW2tUPYx9UcCQYnCDI+AVbjRWQTauTqU1OXUxiQUjxxJyy5GAWvW3GoIwcsX2eXlaOBMDhR9TpQqxeipDvjMeAPGAGnP54yvGWVKlojYr2rxBBvPihHkCaFWvrQtosU2IBih6Unut/wKYUQ9TKNoexA4+XaaeJa0gGHqktTOZ0J+d3UPiyBfTCbm5V+uKfXYluwkM/SJtvM9UwXUuOBQuNvNqiisN9ExcpMDvweCXAZbJ+v8mgJoXUIbnKbewMlRa6MiUrWSDXnsTW+DZy1I8gyyXmtqQJ501AIHuViaq9QRh9iEE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(316002)(54906003)(6916009)(8936002)(5660300002)(2616005)(186003)(4326008)(4744005)(36756003)(8676002)(6506007)(66476007)(66946007)(66556008)(26005)(6512007)(41300700001)(2906002)(83380400001)(86362001)(31696002)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L2Z3VTVoNVRGMDRnc2YzMnBkdFdRRW5MSUJiM0pHSC9qQXhVNkNHY29YODBR?=
 =?utf-8?B?QVIzTDZkek9Ycms5b2FUUlA5STJ3bXZJTjc3N0s3cEtPT0FKbGFxWS9oKzhD?=
 =?utf-8?B?eVZ6YXcxbWNpeXB2c1ZhWHp4MjVtUHZvdFBXUHVxU1JYL2tTcDhNMFV0dW1q?=
 =?utf-8?B?Z3RhNHRhUjNhTGpjWTFCUGQybkRqcXVZOU1WSkdWUm1VVDIxdnJOcXpvQ01K?=
 =?utf-8?B?Z3BHcjA1SGg3aGJSclVNRkpacGM4TVJwN1Q5djB2OWFZMzZLRnNJWkdIaXBI?=
 =?utf-8?B?TkVScHNGaEhFNnhudFVGemF6RjZlR0NPNjcyU3dtYXE1cUUzNUp3MGFnR1ln?=
 =?utf-8?B?c0w5WXk4dkpNekxPYTJoN0ZqK3VpeFlHclRVRkQ0WnBJYTBQQXBmekhEVE9m?=
 =?utf-8?B?OE5GQXZLb1VKSlRraFZmUzB3RjRMbXdXUGg5Y0NNVkZoYmMzRUxFRGFXMDJK?=
 =?utf-8?B?MU5iUjNkRUVpZHBLcjBnV0k5TkZWWFVrSzhTTG9tY2RxSWwzc1lKcEtYUVE0?=
 =?utf-8?B?KzdJL3U3Q3RGbEFpYlQ1ZjJMQXo5aC9XZXZIZGtEZ1RxdVVTelZua1pkaDB6?=
 =?utf-8?B?VzBoYVBQUS9XdWpoMzJWajVPNjdTcGY1dEpyd0tPVzZmVkc5ejJvTW0zUWJU?=
 =?utf-8?B?dnRZTW1CL0RoSTJPcUlnYzE1bzBiT2tpVkZtVTNDbElTSS94TDJtVXNaeTZZ?=
 =?utf-8?B?Ums0YVRGUVVEeEtWcTFYb3ltbHA1aGwwUkM1QkV0N3pNZ0NWbkxQZ3VubVRS?=
 =?utf-8?B?dk5SamhwWEFQMDlUUk04VkJNOXlzMEsxS3ZWVkY2c2Y1OVI3TmdPZUJxSFo2?=
 =?utf-8?B?bllKOWExMm5UV1Bmc21SZU1oZTdTTlVMWFlLckZNL3hoTmU5aXV6bS82TmVx?=
 =?utf-8?B?MGxLcmV0NXNEdllUWDAycVg3czVMT1V1dmVBY2htWTE3YWw4QkM3WEhsTTlG?=
 =?utf-8?B?c3Rwc29PalBZU2VQZFV5UEtUMnJqQzRDbTRibDlmdTY4RFF4emtGeVhHdm5a?=
 =?utf-8?B?VXRvTTJpbDU5WXJ0MEZ0QVFxVXJOMFA5eTgvSTh3NlVheDJVcXF0Q1E3T0dS?=
 =?utf-8?B?UHgxRnB1TGdrYXgvWVoxYlF5bFNFRUNyTzcxMnlCUHVWMHo5S1hUZHJKTnpj?=
 =?utf-8?B?eXFGTXdYdjZKbXdxRFljajQ5UHpOQlJrWkhGVjFHTGE3Zzl3a1FPdGdmRWpP?=
 =?utf-8?B?ZC9mVlV2aHBBZVVYWis0eEhlMllzUEE5Y1ROOVZWOEpIZllnc0Z5Um9uNVFT?=
 =?utf-8?B?WU55dUNmeGQycnduTXZ1L1ZLRVlHcFZGMDlwYVZ5SWtwNXpGbE1xaHJFTFor?=
 =?utf-8?B?aDBWNHpPL0I3a0dWM2sxMTh3ZUg1QlFRUVZ4OU50ZnZCT2FIcmF1OVB0Q2FF?=
 =?utf-8?B?eUVORXBBSHlld1F2NGtrWU5jU0NSbk54NXhPWTRRUHJmdkY4NlM2cFNvL1kr?=
 =?utf-8?B?U29mMlUxWFJWUkFXT2duZzF6QkdySnIvblV3Tmg3V1JvbjhQcEoveW02VHQz?=
 =?utf-8?B?eWtkUUxITTRZRHArYlB0Sk5VakdPZyt2aGpVdjFSelRWOGtJa3NRN0R6NkM2?=
 =?utf-8?B?NjZvYlQzeFlRcmdpdlJnWHZxLzJ5QTZMdkl0Nm1ZcFYwU2JjUUMzbFZ4YmRW?=
 =?utf-8?B?NHk1ZXFmRndvVXhiNDNsUUlLWHFnNUl5RjhLdm1tTTY0dldjTTA1QkhUM2Jw?=
 =?utf-8?B?NWlzdDU0RWFoeWJEMGFLV3QxSWtOMHdiQWlPNFZtNTVoQnhNSjl6YmRWSEQz?=
 =?utf-8?B?eTJUcDNuRjlOOGl1aXlYazJEaG1UZE94dlE5Mks2RWxxTWtyRDRIWWRrRUkv?=
 =?utf-8?B?VUxHM2NJeWxBVmNCaVlWOVF0YkFhL2xOaEZmaGtrUUppcCtwK3FFb2EwS0tK?=
 =?utf-8?B?WVMxSnVGZ25FYW43NGFXa1BJZlNRMndYQ3VveDRjUU81TWJmYnQ2OTRxUS8v?=
 =?utf-8?B?ZnVxbWNIeW5YTU1ubDR2NlRJS1MwT0lsbFNlK0h5RkZ3UGRMNEIwY2RFRnU2?=
 =?utf-8?B?Z2dpYm1OYTNxQkl5REh3WVdMbnhPNWUyYVZYSDNUTWQrTllHZU5MOGtkM0h1?=
 =?utf-8?B?TnVuUjZ3TlJzUDRMTGJvMGw3VTFsc2N0QWhncUtqVk1Nbmc5MkdJcUxBUlF1?=
 =?utf-8?Q?yQTLt4DA9qTfxmWDoRDhxn1IA?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9cd2d88-69a6-40bc-b50e-08dab8b51675
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:21:53.4406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: inOAM9FkWk89zo1JOAA6NBvm8v+tLfJsrV33oAJqFnj9dcqjl+vl1YkEYDWNaOM8ZHgOAGC+1RmqZY8lVKOEww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9264

From: Igor Druzhinin <igor.druzhinin@citrix.com>

Mem-op requests may have zero extents. Such requests need treating as
no-ops. pv_shim_online_memory(), however, would have tried to take 2³²-1
order-sized pages from its balloon list (to then populate them),
typically ending when the entire set of ballooned pages of this order
was consumed.

Note that pv_shim_offline_memory() does not have such an issue.

Fixes: b2245acc60c3 ("xen/pvshim: memory hotplug")
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -944,6 +944,9 @@ void pv_shim_online_memory(unsigned int
     struct page_info *page, *tmp;
     PAGE_LIST_HEAD(list);
 
+    if ( !nr )
+        return;
+
     spin_lock(&balloon_lock);
     page_list_for_each_safe ( page, tmp, &balloon )
     {



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 07:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 07:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431436.684337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJhJ-0002iM-TI; Fri, 28 Oct 2022 07:22:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431436.684337; Fri, 28 Oct 2022 07:22:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJhJ-0002iF-Q3; Fri, 28 Oct 2022 07:22:33 +0000
Received: by outflank-mailman (input) for mailman id 431436;
 Fri, 28 Oct 2022 07:22:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jtyv=25=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ooJhI-0002i0-Lh
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:22:32 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2089.outbound.protection.outlook.com [40.107.104.89])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4902870b-5691-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 09:22:31 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9264.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 07:22:30 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022
 07:22:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4902870b-5691-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gSAw//2uDBvNDvCJ4BvfD2gDBZuxtf8ZJuYTaPp/ic7C6qCZgNlZQmcxTaKCuEvQ/1qNOnTKWarTVJ5z25G+zrhhE7TIyiL4iPrk1m66ERRhwPrHqiI5lKW0XyuknNVg4UrbUMytxUn+XWcE1Y1qX96MqK3knqSZFL3yP/2xW5MyjZ1B7qnhR+aaszO1EOGDu+qKHliq3eM/kgv1xzNqeG0jdEOWE3+dojI22tmb91vrRzh7v+5/3vzeB5/hV4awsbHFWuaz10ovgrCwXuNNkTH2WT4Moo5Me6OuAVOLHBrlvH3DNsxG+F1pkf6fFLyexlvWLXrDxLROWUc5k2Ck0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z+zkDWf3de9+bRGdDawZnuvAUtR92dpvUXja9wCTUW8=;
 b=Sv74S8fykyVhVcgrsoWjdX3KKe1qoEs8wwyGGZPURZVlRBeTlgjKymayqL1Ii7zNdYdOYm5Ck7Wyy02bzm7XC0v/D0kN+7y2u8uthHeytlX9eej/D/WQLlUSaiJi/UQIrTIporFS9R+GVYbhDXTrnWUIlFYZW3YQ/ch5+wU6sZjaeTstQ7y0fvvs5vPsJ5+tWYhvBdQYVpHiHmTJxF/qa8SsGtOQHKPo2ectnqn6RWZOkOYGYVYV89VHsX62qSA6MNCcxlWEhk6REvMK3cHej9R60vABkF2SpUe1A3NN18vzQuuQGQh/11k6goDbVP63eysAvbp/GSXtHpykHIVIwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z+zkDWf3de9+bRGdDawZnuvAUtR92dpvUXja9wCTUW8=;
 b=H3clkn4Ehg5x8XmUIcvkp4R7no48XoBv7qXbtB9g1miVWEWOb2gSgf84q6Dd5JjilQP4CUczMBnTStrLiTDdteu4ys2+YNNRsF434C9hFXCgmWk90AqGOQURmDmG/UNKhA/s3VwX3dUSCRMosDgrmI2gNsmgUSq+rfYw+VVR3AaiYrLE4hixelSxymqdXcu+1ECzst6lTz8GK6pg2gx//DTkhhqJFvfWVMhRe1r3wn2bamc1xXfnXHqX3NKkgVzX0PbSd7fI+7se3bEaBO4c3EqBeoNkDw3b38fZ6jjIcEGraw6TlMy3kTBPL8NX4pNkzgzfjI06El2QccsB93/U6w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <07ecca86-97e3-555b-78fa-d9cda765805d@suse.com>
Date: Fri, 28 Oct 2022 09:22:28 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: [PATCH 2/3][4.17?] x86/pv-shim: correct ballooning up for compat
 guests
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0048.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::27) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9264:EE_
X-MS-Office365-Filtering-Correlation-Id: 8a3dcbc5-1abf-4607-b990-08dab8b52c61
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	a/KueU2czSe9Ewp7R27kEH0LqYxxXuKwcub+w+dTvp8tImgbGyqCFLvPLOFCKK1X/4mL73DRBSpOB2qr92TxFxrlCSjiRquzzG9RoX8nrjfRFl/3S9qKHkovKQIAH/2l6Rhaq1Sy4/TI+x3pc47V4cgN3rL8PJL9YAbImiTaUhN6BVFw+hwOSbiJ7CxSOPzCh483aOgnr125O8hjJoKs6Rl975sLRiE3u4U7VkLr3Ej4pQiDAoXGV/Ho+usMTsEo+J1HBo3GxjEzI7nxdY2ZYvjYTPOoWbgxi0Txl16TIxujYaZWt/wXK3eteqppBuR9Cohh0kFq5xf8LPlz6/GeS0pqGI8+np6XOq/Zd/pb3xqxnOdgjIgRS9Qc+rzVVvdTFvbz3qHWQXxt85X7uqcRzJXmVk+0DB5yt3T/doeBe92ZP09peGz+ctvd280pgroXIRmi5v4ErPuqchIyQnKSakGHTWj9RjNhieI/CzRmtwwxkTIL2lSVIXtErHnGXvcNbxVOLw/uUkbMhqzQrmheShwIFW7zBVH4OVbwfbJbKvRRGXktsL5dCerI834YobsdTDpt1uQuGtLdddHnpWE2bcUn0HGx70IWFcYRObYPauHXW+n+E+cVBwqA1tWlvNFT4hAFhZsdOeXc6wgHufZ84V/X6W0ozBcFcapZzOEN1gqXyVOD0g7Xc9EzPbDcHq4wLpX8an50+l4SxB1giHIlorAELbb3d+1W55pxAXgnLFrKHlmMdw8uJ2Yg+VkJeMQcKBY0Dep8v7VeMa8P40TjiKO10+dNaUmw9qtuw/pfqLI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(316002)(54906003)(6916009)(8936002)(5660300002)(2616005)(186003)(4326008)(36756003)(8676002)(6506007)(66476007)(66946007)(66556008)(26005)(6512007)(41300700001)(2906002)(83380400001)(86362001)(31696002)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q1NzU3hGYXlrZnNwOURrWmFZQUNlQXk5S0Vlb3V6RlJKdGNaenBTMTRwRHpZ?=
 =?utf-8?B?azZRN3FvendVU1VVNUVUTXRSeWZmUG9SWW8rNG5kZFNnUWNEZWFFSWNoelNZ?=
 =?utf-8?B?TVd5enBQMHhpa292Ni9nZUxHaXFVcW9OZWs4ZXlDSk11RHVkbWFEK3hsWWJq?=
 =?utf-8?B?cWcxb0d0TE8vNkNPT1Fqc29ON1I4bXErMGhGU010TWNDeG9PSlJaaWhHcmJX?=
 =?utf-8?B?Qm5GenkrUlhNZUdUZFpBNG9JMW5UMHp1QTdoU1lqZk16Z2pWaUdsdDhNVmQz?=
 =?utf-8?B?WGxoSXpESVFqMFdoaE5zSGlWUEg4YXBBN0NvWERsSDc3SzVkZElmbE9kbTEz?=
 =?utf-8?B?WVFnVm0yMFBoY0dsd0JQUC9sSUp1UFJ4ME1ZdGMyQVJkMUxKdXpKS2hKZ3RI?=
 =?utf-8?B?THAvU2NCRDBLeFAxOURuZ0ZWN3RMc2JpOGRvbVV3b1Fyd3ZMZTlDZ0Y3N3dn?=
 =?utf-8?B?TlV1TDIwSndMeWhkblorWXEyNEtCbGtVempZZytmcEhBaEIwQk1Zayt1Sko3?=
 =?utf-8?B?eTBvUFVRRzVkelpocGsvMk9YdDJkRFJqZlZEeUZhbWFuMmkxNHdReGhaOHFl?=
 =?utf-8?B?SzRyTlhRSUkwYWo1MWZ4QUZjVUNHUFhOeHJ5eXN3SW0rczhGbWJtS2hBbytW?=
 =?utf-8?B?b3VXS2U5RzU4TmtDbHQzMlA5dFBydGNaV29MK0w3d2gyc05kWFpkS0lMdnVF?=
 =?utf-8?B?Z2NjdWU5UWhwRm5YZlJ3NGpXb0s3UXUza2FhYVNOeFk1N3FhdzYzUHhQMW5x?=
 =?utf-8?B?YkgzN2liMytHQVd4dVh5cnZXNnpRZmVoWWwrbEkzMWpMNDdLOVBxeWovWlYy?=
 =?utf-8?B?KzJBSW9LRW5Pc1gwSDhnakhzVHRKR2l1WkVvMDErZFc4WFRuWHZaMThySlNZ?=
 =?utf-8?B?U1NLTWdtZFZkK0JuVExjbDE2dVRseDI0TjFLekU1Wlo5Tk1oa3ppTWl1ZTRI?=
 =?utf-8?B?SS9vcHFJejU2NDR5OWRsN1ljN2VWK2ZwYlZ3OVhPWGZ6QjJnRU5Zblpvbk1R?=
 =?utf-8?B?eXpNVWMxb1J0VnluVXNpa2RpNjNnbURmaVJnYmJtYWNyQWFEZXJqd05nbzZX?=
 =?utf-8?B?aUhTWWFuVVJXZThDL2dYSEcxSHUzb1E4WldRcUpIQzNuVEQ5Nnh6ZzJaNTBS?=
 =?utf-8?B?d3FjWkxNVU4vUWhZcWZBcGkwdm94NndVd2NiaGF4SzhmemU1dC9ITFdFK1Bs?=
 =?utf-8?B?TW1ZWmFoQVFGTE11a21wdWthdmE3RnNRdEhaRkdhMml6TE9ER3RDRjBlVi9T?=
 =?utf-8?B?Vng5VXlGY1pzVUdYR1hVSkhGSEhpTk1talFENCtSZlBMajh1NlQ2ajBOa21w?=
 =?utf-8?B?ZXNOODdramd4Ynh2S1FabEhiTDd6VkErSitOa3NtL1NNSjNPMi9ySkxmeEp6?=
 =?utf-8?B?NzBIQmcxQ3JOamVhWTFtTTY3S0FTSWp4cmNBclFoN2NoaXpaNU5pWjMyQngx?=
 =?utf-8?B?eDRPZGVwdzg0djdSSGFhYnlTTnpFM0Jnc1FsTEV0UzN2L3Jjall3UHBndVFq?=
 =?utf-8?B?bHVxZDBsMGJIZDJ2ZEhCTXd1LzJaVnBhamlDMnlSdmdHMS9RMy9KY3FZMHN3?=
 =?utf-8?B?MkZleWpnc0dOMkNmSWpzaUU1VGlqQ2lPbjhsdXBrc1pwRGluTVB2ZDYzRVJa?=
 =?utf-8?B?a2d4dyt2N3lWeGE1REVvNG9LRjhPTmdDeUlDZlFBemF6MzVUL3RxSVFLS2dI?=
 =?utf-8?B?c05CSHIyMEhPVFhDMkVockZnczN1cnIrcXU0NDdudFVRNHVZM1BQT2NKNnda?=
 =?utf-8?B?U1dZRyt4cmJnaWlTYmFEQ0tocWNUNi9MUmZ4Mmd0emVYWmRLQ3RhOGJvVjJ5?=
 =?utf-8?B?T0YxWWJFUFpKU1p5YmRldzJhbjNyODQyWWgzMng0Q3N4SzQrR1oxaUdGNXFC?=
 =?utf-8?B?SzlkT1FUN1JtdjZHbzF0cWE0RE5seTAwQUtuL0tERFg2dmRhUU82RkxZNnRO?=
 =?utf-8?B?QmlkOVYrUEdyWVBaS2t1TWRwd012RVdiOE9sRElKaE8xWm1XSk8yU0xHUTdj?=
 =?utf-8?B?aUI1RHlWK2lNeXRuM2o0Uy9temZmd2JmeFJCa2xJQ1pBNG5jSDZmNGRFZlFH?=
 =?utf-8?B?MWZLMUJlWTRrV0JNNFljbXVIQmRkbWp0cEloN3VSV3ZRK1crQVlWcGMveG5q?=
 =?utf-8?Q?EegZWPXcizJIBd47nuHbfGAWg?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a3dcbc5-1abf-4607-b990-08dab8b52c61
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:22:30.0789
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1837UEFakiNuzQJsfLSQ4m+V+KTvb9jC3T0Kw8wrTHbJ2UndCmOsZj/NfdUJW4WgmDFqw2AXJaKYAeeQqriFbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9264

From: Igor Druzhinin <igor.druzhinin@citrix.com>

The compat layer for multi-extent memory ops may need to split incoming
requests. Since the guest handles in the interface structures may not be
altered, it does so by leveraging do_memory_op()'s continuation
handling: It hands on non-initial requests with a non-zero start extent,
with the (native) handle suitably adjusted down. As a result
do_memory_op() sees only the first of potentially several requests with
start extent being zero. It's only that case when the function would
issue a call to pv_shim_online_memory(), yet the range then covers only
the first sub-range that results from the split.

Address that breakage by making a complementary call to
pv_shim_online_memory() in compat layer.

Fixes: b2245acc60c3 ("xen/pvshim: memory hotplug")
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/compat/memory.c
+++ b/xen/common/compat/memory.c
@@ -7,6 +7,7 @@ EMIT_FILE;
 #include <xen/event.h>
 #include <xen/mem_access.h>
 #include <asm/current.h>
+#include <asm/guest.h>
 #include <compat/memory.h>
 
 #define xen_domid_t domid_t
@@ -146,7 +147,10 @@ int compat_memory_op(unsigned int cmd, X
                 nat.rsrv->nr_extents = end_extent;
                 ++split;
             }
-
+           /* Avoid calling pv_shim_online_memory() when in a continuation. */
+           if ( pv_shim && op != XENMEM_decrease_reservation && !start_extent )
+               pv_shim_online_memory(cmp.rsrv.nr_extents - nat.rsrv->nr_extents,
+                                     cmp.rsrv.extent_order);
             break;
 
         case XENMEM_exchange:



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 07:23:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 07:23:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431441.684348 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJi1-0003I7-75; Fri, 28 Oct 2022 07:23:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431441.684348; Fri, 28 Oct 2022 07:23:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooJi1-0003Hy-4M; Fri, 28 Oct 2022 07:23:17 +0000
Received: by outflank-mailman (input) for mailman id 431441;
 Fri, 28 Oct 2022 07:23:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jtyv=25=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ooJi0-0003Hp-ED
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:23:16 +0000
Received: from EUR03-DBA-obe.outbound.protection.outlook.com
 (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62d9dbd7-5691-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 09:23:15 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS1PR04MB9264.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 07:23:13 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022
 07:23:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62d9dbd7-5691-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RP0MM2Dbw+SIT8P/cq1IuvqZl0F4NCrnhjtHjOh0zPefiNKUPTiJ5IFHu2DDWekt2YvMDR6JXWtdRRUs3+cgzs/QK/Z08PWOugRodB6b153wg49cSno+DspqJEBmJl7cGlSUO8YquzU1eJJzKvHXWTCbX2lLwwrb1RbQYoLD62q7UZq4LqyJCDj0f2ioRIOl1dus+5JsJ5LYPDdbbNT+1Nxa29yfaEW0m8mdFzx3H7xfM5N+fbWl/e/B4M4suBiHddQsR565JBUUVY3xbS57pwwswRTrOC1boVIQmTvP/fuiPXJnAX7XWyEjaLG9aX6dvpnAb/MNoRgUDqQycf9toQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B4EnGeRwXar3+da6jwqvXI51YktxFxeKbOMUsdd7OF8=;
 b=n3ui2QSscLcNXWx53MsSA1MFmdJ0XphkFKK6l0i5EEpO1GS2BX4BxK/LDXLCu9duLoQ7/p/NitDlRJeiPpfL3/OjGGmji+QIydr3GBScSveFlKH98TZbEDHCBlgpJkjWHFGkoXm6r+Xn+mE7slHodEaNmh2nsGLNmASjjWyfmZxosdUvpVD74BUYncfDZmDGv6jMag6WieFWxhfaQ6yZnGbTPRjtqCGVUsHV1qmSVVN+hGy7C+PO6v9iKtJfZOXkArzzab/9j7mAwgTF2+YJXWV+G9xJ9WOgPE6g2ZxTschkN21MZRis2qCwAVmqQpVWy4auvAmEySq4oZt4wDymwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=B4EnGeRwXar3+da6jwqvXI51YktxFxeKbOMUsdd7OF8=;
 b=CMf+uJBsEN0kWZASqJEnO7IYLhFosBujId9SraPi/42LRzZSbpdYm+E9UkurKX/K1M9Fu5mySFUtfPGrSMVehA0UI7rLQ9BVOFL5DGooI9XFIZyivjiqrF6SN8kffpiZ4Ffb9gecRCvbZ436ldqe7zdkpn3szOqm5PNf/1k36kZkOoDetUuWItuRc5j7zKk1d/tBaoz+71y23eznh0XBYEHAWILYIGKSzm5PxQnAT78WH0UqdVdYYRxlDuuGGsQ93VL4dNtxW5mI1DcLIIt5t8UNxe1L45hEVp/jHW89lCIz5b4AR7e1tSyBURMJHetNqlTT/8TtrO7bGDEx3C0N9Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b038c16d-2c94-584a-ad84-02403c52b0e3@suse.com>
Date: Fri, 28 Oct 2022 09:23:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: [PATCH 3/3][4.17?] x86/pv-shim: correct ballooning down for compat
 guests
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Henry Wang <Henry.Wang@arm.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0015.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::20) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9264:EE_
X-MS-Office365-Filtering-Correlation-Id: 401ac5b1-ad37-4fd6-5975-08dab8b54626
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MaKF6QKUQhTwCvkvqieXw77wWm1OI3YsgaHzzaH/MIhe9w0WrWinAM1GonlRIOV5or70tF+L2cEAWDcmc0H3f9sD4h/MG1MLF40Hj5hf+EsKY53DuQL1pXR/akaWD+O9fdkYTZZhIerdFHEGPZyyIizsfhXegCdnrkDUbvDOwonrZQrZ7ZbCQ2rRY8Mlttxktulx6kD8b6ZlUYoevDBJrUqy2ZxNQbHbBZ2QvQO8xag4AcLbvXZMc0u7mzobY1dr5cAyi58yVA6ruUN5JAyAqxKN8edJR+ZKtpsYyy2wFfYv+TOn/G4F7nFdY78tcIM7QmHkN9vZunNYJ3nB/vF/hf0vlktK00I5O54buj4yODDMpygPuv3+N07Q6t79zeEvF63Q592ivFKfq0JYXz4NkJY84LHN8XptJVr9MuEalQJ0FM/PmfOlenuer1aAMgpeJ3goyVbibbTY6lTo4lKPyzY+g6FRez1ZwBzD1nfeLZSWvGN/Ecv8u/wVWVR+yFJ305EeZ2E51czqOO80neMjmnHSVMnQleD+fyg5jmi6UMqSAn8zLBs9+9TMij5TlGOGVna1G+eWCQ1D1WmxQZ+IrjhUXa+q/nISKROQNH0anmmMYgidZCbImQT/wZaje8A7xzuHKZJjvc7YSc3DgNesXfkT/1JPqGDwX3aWu9BR3Jt4UCPpVFGNLvs54ADESemmANC+e+vXxeQ/kjR75NQmqGtVCYJZW5bGhuqqTa9ZAhF0WOmbvn5P77VldaPdqfNJzPB2ZR7ScmTFyDZYftL4+yCifXtXggLKoGgAvLsMcz0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(316002)(54906003)(6916009)(8936002)(5660300002)(2616005)(186003)(4326008)(36756003)(8676002)(6506007)(66476007)(66946007)(66556008)(26005)(6512007)(41300700001)(2906002)(83380400001)(86362001)(31696002)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cm1LNXNNS1U0aFg4dGpIZGVtVGp3WVkxS3R6WnJEQklzNmJCZHNacnJKSXRX?=
 =?utf-8?B?enRVWStDMGY0R0RQekR5RkJTcjZteGFDNHVwYmN1aFFxY2F2aDRvME9qYmIz?=
 =?utf-8?B?ajUzbWtyK1VERmZ1d082Q2RVSTRQOFBVeFNpMzdHTnNROWNkdHI4cWtmZG9O?=
 =?utf-8?B?L3RsTFhBcHJ6cUFTZmltU3Y4djc0SldWMjJkcmx5RWpPM3M2VUZ0QWVMUHlv?=
 =?utf-8?B?a0pNWnFmQnZsanpGUC85YW9PRlNubGlTZ0o4a0hHaW9LR2VWNnhkV0NTL1l5?=
 =?utf-8?B?bklpTGpMclF6K0NHVVZSTDBZL1FIYWxaVkZZUkVGdGpBREdhVTRxQTBMUFZQ?=
 =?utf-8?B?eEM3a2RCNXNVaVNmTkV6TFBXNHNMaXJzU0lOQWpDd25UTU1CME5KekdqL3lu?=
 =?utf-8?B?YUNrMVEyb0I0T3MwTE90anVZRDhKY0REUCt2Q3NBcTVhN056dmpzc3pmbkc4?=
 =?utf-8?B?czBNTTB2amVGL1F1VGxVWEhheDRRNFZncERKaHZac0t1UzIwMWxKYVZUR1VL?=
 =?utf-8?B?emh6cG01KzZXMUNUV3htc1BWdjlMZ0ZhVW9FVm5oYUxTQXZvTFAyb2NsQWM0?=
 =?utf-8?B?RzhteUs0NG54dHR4SUdMY3VrZEN6STN2bkV3WisxQ0NKcHhKcjcrR2I2OHRX?=
 =?utf-8?B?a2p1ejdOT1A5Z0R6RWVxS05QRHB6T3VUTmdnSmFVZ1BTTFBTaDMvSXVKNnZT?=
 =?utf-8?B?NzFJMS9TUTdJTi9tQ3g4V3JhaC9CT3JxOGY5bkhjWWVTb1J2bnluT3BrbHFM?=
 =?utf-8?B?UzBnYzAwZmxwWEoxUDIxd085Ly9rczJkT3hzT1NXL1BNVGcyd2NmQnlsSEhO?=
 =?utf-8?B?ZUlEalFDSVZ4UWJuS3ByY09KMTdrRExQK0xGZVV1TklOejkrQk8waXY5azBI?=
 =?utf-8?B?SnZCSXdzdkdma2crZmZIZHpHN09WQUJDalgxSUJwYXlHWnUxWThaYXhRYTdF?=
 =?utf-8?B?SWtzSEJPUzhtYy92NFdNNHVBRndvRWQwZC9WbEhET2ZWdjJFbU9LQ25MRWZU?=
 =?utf-8?B?Lzk1dmtIdmxWWUsyTHZYK2l0RXkwbEdmMkZxZ0U0aFBFT2dyd3B6WWEvdTQ0?=
 =?utf-8?B?NHZvS0RrU0VvZExwNkdUdEJSUXpsZWNrUmdOOGFNMVBCUDl4dHorUUs1Rmp6?=
 =?utf-8?B?M1ZvQmJCaUpXMXdNczVJdUJVU0tCM3h4YVBUWEM5YWNlek5OTW1GUDc5Rm11?=
 =?utf-8?B?bmZFd0lCUjRyVWRuR0hEbko1VHZTOXBLcUppRVhLRmJqR2VTZzJ2emZmR1pS?=
 =?utf-8?B?MzF3RVc3aDFSd3BhU1RwcE1hR2s5c3MxMVpHajY0dUx1TWsrdlMzSzBmMksw?=
 =?utf-8?B?TlNiUkJicEhpNDh4SGhHNEhkWGg5UmFadTdzOVIvOU5KK2dJaUZRRmRlWTY1?=
 =?utf-8?B?a0kwd1lLanpDUFVvY3Q1N0Rhai9Pak1OakIxbjQ0bHBpMW1OUzhsUE1NT1Vi?=
 =?utf-8?B?Z0xUM0xnWG53dDNQek5ZRFhxcHdla2lBYzFOWlcxTmtVWnY3VnVyWE9LOXZ2?=
 =?utf-8?B?VGw1a0FwUkVyODZGTTNrRDNVVk5IRzNyNnE1VVdzV0svRFdjZW1NSXFoUjNX?=
 =?utf-8?B?SUpsS0lhZGlOZmxOZStWMGs1cm5vcmpmOXFBN3VidkNKRjFMcnE5ZFN6Ykxh?=
 =?utf-8?B?cFVVakRxOGJnci9lOWIwb2ZEN3E1WjFOZyt5V0sydGFRdXB0WkgxaGtObUpK?=
 =?utf-8?B?Mll2dW1hQ0ZXVm5BQnNHUjhGdUtLRjI2TkVEeTl0V3hlR2N2c1E5UXVwcjFr?=
 =?utf-8?B?OUhaQ3F4TUJSbjlNWUZDTkZIbkllT0tsbm9BbkV5QlBlM1Q0aURRSERyRVgy?=
 =?utf-8?B?eTJGNlcwV3F6VmVEbDFBNkZsNWYvYTNhb3lzMUtsT3h0L1Z1OXkyWkZ5Mjdw?=
 =?utf-8?B?VWdieVllVHlrTzVxRXF5UEtOK04yc0k0emcvWkl0MG1RVmxNYk9PV1Iwcmg2?=
 =?utf-8?B?TFM0VmdwdDZNR1ByakNoOXZuOEJZNW1UNlpiZExxRGFtcmFCL2NqUVhSdjJT?=
 =?utf-8?B?ekhPU3J2UXY4QUZqNm85d0Y0QUwxTUFIU2NKSFZwQlJ4SmVBd1JDbDJxMEFN?=
 =?utf-8?B?eTgrc2RsZW00S0x3Q001QVhNdFpCV0oyLzJyMGlWZ2IzWkdkZHNvU1FGWXMv?=
 =?utf-8?Q?qPS/i+GMrZXg+HbUvTPPLS880?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 401ac5b1-ad37-4fd6-5975-08dab8b54626
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:23:13.2949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d2W5LiGUCBqks8d5844u/qQQNP+huyopMCOjkYs+eBRnVoBoZzOHTnz9bdrMjyu+E6fHKEpAfoGpn3HiaRIjfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9264

From: Igor Druzhinin <igor.druzhinin@citrix.com>

The compat layer for multi-extent memory ops may need to split incoming
requests. Since the guest handles in the interface structures may not be
altered, it does so by leveraging do_memory_op()'s continuation
handling: It hands on non-initial requests with a non-zero start extent,
with the (native) handle suitably adjusted down. As a result
do_memory_op() sees only the first of potentially several requests with
start extent being zero. In order to be usable as overall result, the
function accumulates args.nr_done, i.e. it initialized the field with
the start extent. Therefore non-initial requests resulting from the
split would pass too large a number into pv_shim_offline_memory().

Address that breakage by always calling pv_shim_offline_memory()
regardless of current hypercall preemption status, with a suitably
adjusted first argument. Note that this is correct also for the native
guest case: We now simply "commit" what was completed right away, rather
than at the end of a series of preemption/re-start cycles. In fact this
improves overall preemption behavior: There's no longer a potentially
big chunk of work done non-preemptively at the end of the last
"iteration".

Fixes: b2245acc60c3 ("xen/pvshim: memory hotplug")
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1461,22 +1461,17 @@ long do_memory_op(unsigned long cmd, XEN
 
         rc = args.nr_done;
 
-        if ( args.preempted )
-            return hypercall_create_continuation(
-                __HYPERVISOR_memory_op, "lh",
-                op | (rc << MEMOP_EXTENT_SHIFT), arg);
-
 #ifdef CONFIG_X86
         if ( pv_shim && op == XENMEM_decrease_reservation )
-            /*
-             * Only call pv_shim_offline_memory when the hypercall has
-             * finished. Note that nr_done is used to cope in case the
-             * hypercall has failed and only part of the extents where
-             * processed.
-             */
-            pv_shim_offline_memory(args.nr_done, args.extent_order);
+            pv_shim_offline_memory(args.nr_done - start_extent,
+                                   args.extent_order);
 #endif
 
+        if ( args.preempted )
+           return hypercall_create_continuation(
+                __HYPERVISOR_memory_op, "lh",
+                op | (rc << MEMOP_EXTENT_SHIFT), arg);
+
         break;
 
     case XENMEM_exchange:



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 07:57:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 07:57:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431527.684358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooKEa-0007q6-P5; Fri, 28 Oct 2022 07:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431527.684358; Fri, 28 Oct 2022 07:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooKEa-0007pz-MP; Fri, 28 Oct 2022 07:56:56 +0000
Received: by outflank-mailman (input) for mailman id 431527;
 Fri, 28 Oct 2022 07:56:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ToJk=25=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ooKEZ-0007pj-G9
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 07:56:55 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 156bc132-5696-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 09:56:53 +0200 (CEST)
Received: from MW4PR03CA0058.namprd03.prod.outlook.com (2603:10b6:303:8e::33)
 by LV2PR12MB5728.namprd12.prod.outlook.com (2603:10b6:408:17c::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 07:56:47 +0000
Received: from CO1NAM11FT106.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:8e:cafe::88) by MW4PR03CA0058.outlook.office365.com
 (2603:10b6:303:8e::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend
 Transport; Fri, 28 Oct 2022 07:56:46 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CO1NAM11FT106.mail.protection.outlook.com (10.13.175.44) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 07:56:45 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 02:56:45 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 00:56:45 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 28 Oct 2022 02:56:43 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 156bc132-5696-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=c+HlRMoj1jel+9LmkrPf5qA3D/Y+VKFuGeAai+D9BfDsY9DbY8+creOFsFPGxMMv/e/KJ8zcn9A8ORYiad4RKfy/cIEyvCAdRO3tMzItoJrqOEypWmtso82mjdUvs8YxRo6pddaXDfRucQXTrQXR7HHjq6GNYB8ZC9uR/NPiAWPachxgeH43DuwBTdp2qEHgET3gbmwlxJxPz7+fnUdoDdWKLjeY7QNcTdjRhM6ozk4AWpdhzF8rkWhA/UJGJKdaEtI3t36M7EBUiWopeedFKrgy2nf4hCFRHjpH7Rpmxtqm9XR68XBPw4ROGg/SGY9DOdYVL+L9SR4Rj6D7WuAabw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wutamKw3Z7Q+Eb/ceHGMavXxD6AMVnBkePAKZWrFltM=;
 b=SMFAnIR9Wx1nukn99obgPTUquMwePHjEkTBoTxBq+BdxqRkB+cvpv+wL0Mq/hHOTe+qqzbTY4B03rbPY/M+TtcpeQcWkaJvMk3aoVrWl0pxN/PHDcgxZnernaX4Nnf2/q/bCxBZD5QfDd6X6GcRG/jIo3ypxfHRuRNJsBmaJmBdO6e80r47jegejhSqYYutkCvwYn5UtCgGW6nnqPrkB194d3GrIBxl+f3WlIygpEQYN+FZQMU7A2ZH20mQAgHp86p5kEkm+f53pBWzNxpjbNI7b6JGMpU0ZUeN9kHhM/AfVIjZDuyEiOTfAqlYQNa9/GHaO8sDOyN66ii9g0pta6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wutamKw3Z7Q+Eb/ceHGMavXxD6AMVnBkePAKZWrFltM=;
 b=dU0Xiwq8yPtSXaqk8sTsHFWpUvARpCS0genpJFDA0m3XbOIMVMIaumUWViDUKUxOqpYcw/lnNs6PA3zhbKGLbcoGUTK5omvFjzcoVeI9RP2+KNLtj7d5HyJipSGgkCFNjPBcXQlxHunK1+8Ynj7SE/L67884XUH+fte0rDhGqdQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: Do not route NS phys timer IRQ to Xen
Date: Fri, 28 Oct 2022 09:56:30 +0200
Message-ID: <20221028075630.32261-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT106:EE_|LV2PR12MB5728:EE_
X-MS-Office365-Filtering-Correlation-Id: c11ebadc-10f4-4542-4d80-08dab8b9f5de
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lzEr5mg7urmT99AKQ6boJr3h0zCqzmZJu3Im4awNKd8OQrKNtENljsFn5g15GbyrR6jdGV+cyrpHW1zaGnuokudICvyNQZNuSRtWs0R95EnRiaBBHv1UCwepeIRRbX1y6gY7JRgO0SQDtL9wYfU1yYsq3bhI8WAmD8+S5bqTx8e9OVKT24l0rU6W+z9A9lV0tYK9yU3YeF/zXMuLs6ScbBmpsAL6pOJA8urcwS8Ph5Wf5Njo5xwAOkHuF63y2p0fW+oA4LyuV5L7urHvHrDTcR9XdivrPymoiAe8s/QcYW7VQfSzJpykijbtQo4Prnz1GqH57AFXbnimTRkiiF8rY2AeKoPXr+Da9jmoEmW8WP4CK22OVRooeKLkeJ1ME8d2rMB7+uTxyymw2DTtCDkW+sNDKEPBvxw5ZIgpsn4pKaOLVjPVq6YLKxfOYgM3tf4CM+RVi3kXLTEVvWQqmAs+Vn9A5IgUysW/lfbXm8PKK5xG5/EJDe4x7uHv3zetNWn5rdFGXoSCu4T0xs71IlFy6ZJo2F5Bzl0JUqbandT5pITdgEVugZvCcm4C/ePQA8F+giyjpjVPs+iQnF6VE52ri7MyjPpgxEcsGld5npAt1/Lo4BbQP72hj98e2CZeNmAFGuYPeA29MITcFjtVhw8MgylLBvY+lb98/CKq6REpREEnobxN3CZI51u/KQcoJxVWwTMo+ZkotdzKiBzxuvX7Zat/h28aKe2N4of+OtYuB1NZk+7y4Gu37nBGdYSgfL3HLlnNij+NzxcKlYMM/bfjrhFMXSBm+GtiTdv5q7uEQ9uT14H3DLGKMUlqePRlpG3xKM9iYbdxzWZNzHaER2xhUw==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199015)(36840700001)(40470700004)(46966006)(41300700001)(8936002)(5660300002)(83380400001)(70586007)(70206006)(2906002)(8676002)(966005)(36860700001)(6916009)(82310400005)(6666004)(316002)(26005)(4326008)(478600001)(47076005)(36756003)(426003)(54906003)(44832011)(40480700001)(1076003)(356005)(186003)(81166007)(40460700003)(82740400003)(86362001)(336012)(2616005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 07:56:45.8231
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c11ebadc-10f4-4542-4d80-08dab8b9f5de
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT106.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5728

At the moment, we route NS phys timer IRQ to Xen even though it does not
make use of this timer. Xen uses hypervisor timer for itself and the
physical timer is fully emulated, hence there is nothing that can trigger
such IRQ. This means that requesting/releasing IRQ ends up as a deadcode
as it has no impact on the functional behavior, whereas the code within
a handler ends up being unreachable. This is a left over from the early
days when the CNTHP IRQ was buggy on the HW model used for testing and we
had to use the CNTP instead.

Remove the calls to {request/release}_irq for this timer as well as the
code within the handler. Since timer_interrupt handler is now only used
by the CNTHP, remove the IRQ affiliation condition. Keep the calls to
zero the CNTP_CTL_EL0 register on timer init/deinit for sanity and also remove
the corresponding perf counter definition.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Based on the outcome of the following discussion:
https://lore.kernel.org/xen-devel/d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com/
---
 xen/arch/arm/include/asm/perfc_defn.h |  1 -
 xen/arch/arm/time.c                   | 16 +---------------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h
index 31f071222b24..3ab0391175d7 100644
--- a/xen/arch/arm/include/asm/perfc_defn.h
+++ b/xen/arch/arm/include/asm/perfc_defn.h
@@ -70,7 +70,6 @@ PERFCOUNTER(spis,                 "#SPIs")
 PERFCOUNTER(guest_irqs,           "#GUEST-IRQS")
 
 PERFCOUNTER(hyp_timer_irqs,   "Hypervisor timer interrupts")
-PERFCOUNTER(phys_timer_irqs,  "Physical timer interrupts")
 PERFCOUNTER(virt_timer_irqs,  "Virtual timer interrupts")
 PERFCOUNTER(maintenance_irqs, "Maintenance interrupts")
 
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index dec53b5f7d53..3160fcc7b440 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -222,8 +222,7 @@ int reprogram_timer(s_time_t timeout)
 /* Handle the firing timer */
 static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
 {
-    if ( irq == (timer_irq[TIMER_HYP_PPI]) &&
-         READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
+    if ( READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
     {
         perfc_incr(hyp_timer_irqs);
         /* Signal the generic timer code to do its work */
@@ -231,16 +230,6 @@ static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
         /* Disable the timer to avoid more interrupts */
         WRITE_SYSREG(0, CNTHP_CTL_EL2);
     }
-
-    if ( irq == (timer_irq[TIMER_PHYS_NONSECURE_PPI]) &&
-         READ_SYSREG(CNTP_CTL_EL0) & CNTx_CTL_PENDING )
-    {
-        perfc_incr(phys_timer_irqs);
-        /* Signal the generic timer code to do its work */
-        raise_softirq(TIMER_SOFTIRQ);
-        /* Disable the timer to avoid more interrupts */
-        WRITE_SYSREG(0, CNTP_CTL_EL0);
-    }
 }
 
 static void vtimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
@@ -306,8 +295,6 @@ void init_timer_interrupt(void)
                 "hyptimer", NULL);
     request_irq(timer_irq[TIMER_VIRT_PPI], 0, vtimer_interrupt,
                    "virtimer", NULL);
-    request_irq(timer_irq[TIMER_PHYS_NONSECURE_PPI], 0, timer_interrupt,
-                "phytimer", NULL);
 
     check_timer_irq_cfg(timer_irq[TIMER_HYP_PPI], "hypervisor");
     check_timer_irq_cfg(timer_irq[TIMER_VIRT_PPI], "virtual");
@@ -326,7 +313,6 @@ static void deinit_timer_interrupt(void)
 
     release_irq(timer_irq[TIMER_HYP_PPI], NULL);
     release_irq(timer_irq[TIMER_VIRT_PPI], NULL);
-    release_irq(timer_irq[TIMER_PHYS_NONSECURE_PPI], NULL);
 }
 
 /* Wait a set number of microseconds */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 08:43:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 08:43:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431754.684370 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooKxB-0006OO-Io; Fri, 28 Oct 2022 08:43:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431754.684370; Fri, 28 Oct 2022 08:43:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooKxB-0006OH-Fc; Fri, 28 Oct 2022 08:43:01 +0000
Received: by outflank-mailman (input) for mailman id 431754;
 Fri, 28 Oct 2022 08:43:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooKxA-0006OB-3x
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 08:43:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooKx9-00076J-MD; Fri, 28 Oct 2022 08:42:59 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooKx9-0002Cu-Ds; Fri, 28 Oct 2022 08:42:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+0wGAR4JBxoi6WuT0gI6g9XX9jgPWnYWkAU7fmXHg0M=; b=fJ9XFUS0OCxSA/KtTfmUJ5VlJ9
	aiGekVzfM4XWUxQVxVWMMqhQWZw24e+awolwis/SeP+VmN3MPAjloxHAsV1TNTOsSMeckpRPdXNiX
	E6zmJwovVlKLdJYbeYG7AdUN/JgbyEt+BuDkNpHgd3w2NtcS/QVpBQpBZ8pC+CdJhEoE=;
Message-ID: <8d7fb5c6-b1f4-e6ea-76cd-a3b98b2fcb52@xen.org>
Date: Fri, 28 Oct 2022 09:42:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [XEN v5] xen/arm: vGICv3: Emulate properly 32-bit access on
 GICR_PENDBASER
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, andre.przywara@arm.com, Henry.Wang@arm.com
References: <20221027185555.46125-1-ayankuma@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221027185555.46125-1-ayankuma@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ayan,

On 27/10/2022 19:55, Ayan Kumar Halder wrote:
> If a guest is running in 32 bit mode and it tries to access
> "GICR_PENDBASER + 4" mmio reg, it will be trapped to Xen. vreg_reg64_extract()
> will return the value stored "v->arch.vgic.rdist_pendbase + 4".
> This will be stored in a 64bit cpu register.
> So now we have the top 32 bits of GICR_PENDBASER (a 64 bit MMIO register) stored
> in the lower 32 bits of the 64bit cpu register.
> 
> This 64bit cpu register is then modified bitwise with a mask (ie
> GICR_PENDBASER_PTZ, it clears the 62nd bit). But the PTZ (which is bit 30 in the
> 64 bit cpu register) is not cleared as expected by the specification.
> 
> The correct thing to do here is to store the value of
> "v->arch.vgic.rdist_pendbase" in a temporary 64 bit variable. This variable is
> then modified bitwise with GICR_PENDBASER_PTZ mask. It is then passed to
> vreg_reg64_extract() which will extract 32 bits from the given offset.
> 
> Also, we have removed spin_lock_irqsave()/spin_unlock_irqrestore() to protect
> v->arch.vgic.rdist_pendbase in __vgic_v3_rdistr_rd_mmio_read(). The reason
> being v->arch.vgic.rdist_pendbase is now being read in an atomic manner.
> 
> Similarly in __vgic_v3_rdistr_rd_mmio_write(), we have used read_atomic(),
> write_atomic() to read/write v->arch.vgic.rdist_pendbase.
> 
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 08:55:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 08:55:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431798.684381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooL90-0008DM-MC; Fri, 28 Oct 2022 08:55:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431798.684381; Fri, 28 Oct 2022 08:55:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooL90-0008DF-Ir; Fri, 28 Oct 2022 08:55:14 +0000
Received: by outflank-mailman (input) for mailman id 431798;
 Fri, 28 Oct 2022 08:55:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pqEQ=25=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ooL8z-0008D9-Ov
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 08:55:13 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70053.outbound.protection.outlook.com [40.107.7.53])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3bf5b247-569e-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 10:55:13 +0200 (CEST)
Received: from AS8PR04CA0090.eurprd04.prod.outlook.com (2603:10a6:20b:313::35)
 by AS8PR08MB6038.eurprd08.prod.outlook.com (2603:10a6:20b:23f::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 28 Oct
 2022 08:55:07 +0000
Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:313:cafe::9a) by AS8PR04CA0090.outlook.office365.com
 (2603:10a6:20b:313::35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23 via Frontend
 Transport; Fri, 28 Oct 2022 08:55:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 08:55:07 +0000
Received: ("Tessian outbound 2ff13c8f2c05:v130");
 Fri, 28 Oct 2022 08:55:07 +0000
Received: from e28632f11c9f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9301F328-BFFD-42BE-9992-213F0A2300DE.1; 
 Fri, 28 Oct 2022 08:55:01 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e28632f11c9f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 08:55:01 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB8252.eurprd08.prod.outlook.com (2603:10a6:20b:53c::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 08:54:59 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.014; Fri, 28 Oct 2022
 08:54:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bf5b247-569e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=TqkW9XW1VP1Ttm3hv6OU7lreqBhJsyxyQKVj3BpEi4I2Tm9nig9O2nMo3ohL1ZwdZNJ0QCnjG9UujvOA6skf2e/Z/TI5JT80y3368KpTp/EZpMeCjcIesmJ6QcSGLLUZ8d1aFRZGqKpC7agfOx7pMECA0QsRQ4T60AuZyq1ZsHjRNePWZfoZexQCp3yU5ROoAuOMJwGgqlHzdd9w7c4dgrd7cMDbbEdb8a/R8MDfL9KMVG9g/hTodaH5HR3sq2LGP3IZ9clHJmG3Oba3NJIDXpskCWkuV05uQTcQpjqbAgYFa2Z7LgtB8TJJ2dwFsTZkUhBAuM03LRhwzBf1dN/kxA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D2dt6MnFf+F1uP31ARA4eip6dwxpSBhrJnRCvCW9atA=;
 b=WN0HrPiUndwUKzVGK0GMwKHOhwK1fZE47L9OwZPWnyDfnTFj9f7xSz8pJH1WzXlVGDGQpYHByp0rMnv+dMGySjlPpUqVeDOaO/i3w30f6wosJneuIFy77wGq460CNLSSu0yk22UpdNGRe8UK7Lkh6Wifsoh1SgqUTJYLMeaWdkFhY4U+Xwtu0B1kIic9lqyiHWX8SPyTP+uiKhsu/nLSwomhzFkHg8z3PBoYp3dAU418dgHzUDnZIJxnM7w5uGm0CxSYx4Q5sEoTakegyoO79DS46D7d/1c6Yg7nU3jTVc7bYspB/8BPTAExH+87/+voTUsEHY7WNccnHtK5lOyjFw==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D2dt6MnFf+F1uP31ARA4eip6dwxpSBhrJnRCvCW9atA=;
 b=cdycyMiKFpFeRa9EEpM9KlRScNtaf1c0NTjNYrYofdnovMiJslBA9SCfUZQUcR96Ew+pInAM07bn8r1ZANc9lpyLAI/T0mMvgfiifcDm9Dtkw2d76QSfse05CALkh77bn0FXreA4xRoqLmEvKbmuW9valCYE53VjfidTyd2USJo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 974b8ea45292e7ae
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RAk/CDKyeqkBCdYfsPPj2sGU6alrrpeeTro+2smbIMRAjlES/yMiF6q3uqrjIxU+xfxCopf+W4OyzKnDSysX7NZM4WYMj/j57rMlFYTdGV0Xh7YJbyPC+m1UI1IqkjUuNXUyOSc3vrRYVSMVCw84JDVlsLOc5ZZ3umEJsPhXlZaahQTXNFBY5Bh7bRYQr4kL3NpTezrBUOOOzbHjd7FXUgzhepdajCkJf14vqL26EmYs4doB5LMAJ25i5Tsb1INhui6acTMylDXmYyhUaSdbqQKDQX5LnvmMDT0p1XS+WgKhXvjXeunyndFlta0XdL6Yd+BmHWn03bdrjoDntz8ozw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D2dt6MnFf+F1uP31ARA4eip6dwxpSBhrJnRCvCW9atA=;
 b=kpFrVgO40CFXtFfotGDu6bxaYNF2Bh5u/eZ2Aq//US6NJqp6fnIk+axibpKbOY/YTvHRHmItNtnZangbCy2HbgBeP4jn2vzFeYItH8UuqGjOGbV3zNW7Lju7+Usnrn60K9ZnDPfiy24NJM2FSMJpFk88qZMzoKzKQOaMIiBylVgNjnnQ+2n0QGp8wl+lXTcCVkd1kTUYHZhUQNAwuMztlMYIgDoIP/iTaDF/QZ6EYHQv7+0DpdIdyBlSfcEK+LPmDJrLKlEw/CbpvvKgKAsvwf7BL6pbewZW/3meuYQatnmjbU9keY7vtKtgpKFUQeYN6Q+niyOV/qrdEAcqP+3jew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D2dt6MnFf+F1uP31ARA4eip6dwxpSBhrJnRCvCW9atA=;
 b=cdycyMiKFpFeRa9EEpM9KlRScNtaf1c0NTjNYrYofdnovMiJslBA9SCfUZQUcR96Ew+pInAM07bn8r1ZANc9lpyLAI/T0mMvgfiifcDm9Dtkw2d76QSfse05CALkh77bn0FXreA4xRoqLmEvKbmuW9valCYE53VjfidTyd2USJo=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, Andre Przywara <Andre.Przywara@arm.com>, Henry
 Wang <Henry.Wang@arm.com>
Subject: Re: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
Thread-Topic: [XEN v1] xen/arm: vGICv3: Restore the interrupt state correctly
Thread-Index: AQHY6jesKd0lAUK8nUWE7dUi6/OJ1K4jgXoA
Date: Fri, 28 Oct 2022 08:54:58 +0000
Message-ID: <6A9AEAA2-F954-4308-8A28-846B696EBC94@arm.com>
References: <20221027190913.65413-1-ayankuma@amd.com>
In-Reply-To: <20221027190913.65413-1-ayankuma@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS8PR08MB8252:EE_|AM7EUR03FT046:EE_|AS8PR08MB6038:EE_
X-MS-Office365-Filtering-Correlation-Id: 84df9b8d-0d48-4710-7ef4-08dab8c21cfa
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 EkuoVFFLOnzdeZ4IvgN3ueslsbNSiETBN+Pnfzk+kusfcidSQ+NIebdAwSCwtIJPOkFS/yVFHddE5TgPgBsVDX3IlgxO+EHX1/FOotJUy96Jk7PPHdC1lbYieewdEpQLdFiY6pjgWxbfikm6Yl0cvHKwLbljvq07iH8aE2xfmRfvngHXqPFyrYQEwgM95bTZQr3oIssM9OCq2Q42LXll6uYEf90dGcQVwyTufujFQ7bDwPNy31t1MSfi80kJ/7+QxtJTf8XgiVvo8e2iap/F5H6oWM8sEMOvPTKrcm2ccqvN2s5vOpc620Z2mXvXzznM+HyZO1ZLHF6HmtVRrs/H+fCFAuTGllBmfDZwA5r2wh3MW0Ea/SuhwhL4gDUAnGZfA4tj9YDgf0nZG7OQS4nxoLlmjQosIA9JMVey1eKCNrN+MPxzf3fzIeBbI/QYBXgq0V/ZwbBHGkZOObGMc/K1u5Fs7bj/6hURxjl+Hzztd6dXY3slwKhqxm7XtKYbkiPBuTtzczOERVvycztyfhsVJizsiJarTv8lHP1FPZI9pAa7fPCx/ECCKCz8kw9E40zyOMwHMir0d7/y8f03jn0po4KGjhgWQuW/1cceU/jj1XKLaZOjT3IX/A7XUM94CnScGHBezhiS6kwGZlTkOFAvSEk4dV6EgleYdwr3ylGYyLDpJckM6UfLk1qjZOiNhF4WnTuhDZeEje0jiEUDNeAsdKv6CO8hnZX1BOcpD6NiqsCfrs5bi7yRHBeWGJfVzwdp3qclC7cMuj8FXYZZ74eVwcv3jko7F2z8YUFliQLXOn4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199015)(6486002)(91956017)(2906002)(71200400001)(83380400001)(6512007)(186003)(26005)(2616005)(478600001)(36756003)(53546011)(6506007)(41300700001)(33656002)(54906003)(8936002)(86362001)(38070700005)(8676002)(4326008)(66476007)(316002)(66556008)(66946007)(122000001)(66446008)(76116006)(64756008)(38100700002)(5660300002)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2BBC15573182614BA56ADCDE0DEE082D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8252
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	14a4b5e1-d6b8-46b1-1d8d-08dab8c21785
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Kfgfwm0mKHmfogrE4AmcIs7THEN33ZwiXsgGd4V43SWN4SdxnqWqy0mEeG0S+XVC7dn7uZqj/u516Lm1M1STx09XGlK3KSaYTYfwoXBvvfh40TczIpthpn5ZIJGhj52jwOf0TYDzQ5Gib5gtUlCbt0Oq3XTpjcQVJx3Z3fu1p+a4bbE+dTbI1IZthZ9ixvBpMJqyyweRwdujkQEV4IqIAHhGN3af444JqNnPiSC5hSz1uqCNJeF4pICvMKNjQGkfVQn0tRQ1M41NKm/ErRTStQGftSV7zR/yGo4boxHxX/PNVKhaMPTMiokfD39w1P/NG4k1bJGW4iH5oWWGAFaMdsqt95LYbStw23dnZQ7ANkJpJAx0GDWcyayeuLDWS7dZj7NL1yJGJLfhHCniPGnJYXoOpNjD5aT5lQMj5a5l5F+LXSFdWGuw8KpciOLR4FFmN0cpICVdbjCxtmTan0RBF98UkOavBfeivw1hYs7dhyYTuesgISf+N3KZPreZmjGEl/Alz1oJSUxzzXiINxl3k5b022NjK0yr+jfPduoku4GKE4Eu/UkfsoLemqHptMciLqM6RQXxowzkLxre47X62XjhU036crJVzVWsrt83BuXd3YIxBIiycpiBzD4m2rsZDLvE8eBSYBm7SfUAt6jp15e1toS05H1Am+2M+BYCKiYfxrUzo/X9jbu4i/HBrIrwgHjsZ6vmzEI7Xq3bIOpY0U+UneeNGh7EZpk6Ulv5f0bLTXkwUdBt7LFHvBu0miYgH9x8DY3vtj3OdN1mWVF2kA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(6486002)(478600001)(6506007)(8936002)(83380400001)(2616005)(186003)(26005)(54906003)(336012)(40460700003)(41300700001)(36756003)(5660300002)(86362001)(53546011)(47076005)(356005)(316002)(6512007)(2906002)(81166007)(82310400005)(36860700001)(82740400003)(40480700001)(33656002)(8676002)(6862004)(4326008)(70206006)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 08:55:07.5066
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 84df9b8d-0d48-4710-7ef4-08dab8c21cfa
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6038

Hi Ayan,

> On 27 Oct 2022, at 20:09, Ayan Kumar Halder <ayankuma@amd.com> wrote:
>=20
> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current inter=
rupt
> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" sho=
uld be
> used to restore the saved interrupt state.
>=20
> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and pr=
operty tables")
> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

This is definitely a bug fix candidate for 4.17 !!

Cheers
Bertrand

> ---
> xen/arch/arm/vgic-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
> index d0e265634e..015446be17 100644
> --- a/xen/arch/arm/vgic-v3.c
> +++ b/xen/arch/arm/vgic-v3.c
> @@ -582,7 +582,7 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu=
 *v, mmio_info_t *info,
>             write_atomic(&v->arch.vgic.rdist_pendbase, reg);
>         }
>=20
> -        spin_unlock_irqrestore(&v->arch.vgic.lock, false);
> +        spin_unlock_irqrestore(&v->arch.vgic.lock, flags);
>=20
>         return 1;
>     }
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 08:55:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 08:55:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431801.684391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooL9R-0000D1-Tp; Fri, 28 Oct 2022 08:55:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431801.684391; Fri, 28 Oct 2022 08:55:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooL9R-0000Cu-R2; Fri, 28 Oct 2022 08:55:41 +0000
Received: by outflank-mailman (input) for mailman id 431801;
 Fri, 28 Oct 2022 08:55:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooL9Q-0000Ch-DZ
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 08:55:40 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooL9Q-0007IP-1i; Fri, 28 Oct 2022 08:55:40 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooL9P-0002oa-Pr; Fri, 28 Oct 2022 08:55:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=AkHKQZ6aXnwWexnNXhlbp/uq1TzfvSB/NTILqeB2Z0U=; b=eM9BqNlg8ivVMKladcMPlX53Tl
	Uyuf/brA3Lz4UvdhANUKBImtCzDTFzpfYj2QVi/Prpv1OZGYsTv9dp8xz+UIwyJeIHnpWDb1XBGbW
	cWgXL5nPbvTct8AfYT8IMDKy+JxNPTNazDzDZVeYVhwV6XZf0syMXX+Hilwfhy/2ZzR0=;
Message-ID: <ef4cf2ac-7b79-e0c2-6e29-b24154c9379f@xen.org>
Date: Fri, 28 Oct 2022 09:55:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: =?UTF-8?B?W2Zvci00LjE3XcKgUmU6IFtYRU4gdjFdIHhlbi9hcm06IHZHSUN2Mzog?=
 =?UTF-8?Q?Restore_the_interrupt_state_correctly?=
Content-Language: en-US
To: Andre Przywara <andre.przywara@arm.com>,
 Ayan Kumar Halder <ayankuma@amd.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 Henry.Wang@arm.com
References: <20221027190913.65413-1-ayankuma@amd.com>
 <20221027215316.768881c9@slackpad.lan>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221027215316.768881c9@slackpad.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 27/10/2022 21:53, Andre Przywara wrote:
> On Thu, 27 Oct 2022 20:09:13 +0100
> Ayan Kumar Halder <ayankuma@amd.com> wrote:
> 
> Hi,
> 
>> As "spin_lock_irqsave(&v->arch.vgic.lock, flags)" saves the current interrupt
>> state in "flags", "spin_unlock_irqrestore(&v->arch.vgic.lock, flags)" should be
>> used to restore the saved interrupt state.
>>
>> Fixes: fe7fa1332dabd9ce4 ("ARM: vGICv3: handle virtual LPI pending and property tables")
>> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> 
> Thanks for fixing this!
> 
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Henry, this is fixing a bug in the ITS. The feature is at the moment 
experiement and the code is not used by other subystem, so technically 
not necessary for 4.17. But if you still accept any bug fix (I know we 
are close to the release), then I would like to request to include. It 
should be risk free.

Cheers,

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 08:57:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 08:57:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431810.684403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLBJ-00018F-8s; Fri, 28 Oct 2022 08:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431810.684403; Fri, 28 Oct 2022 08:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLBJ-000188-61; Fri, 28 Oct 2022 08:57:37 +0000
Received: by outflank-mailman (input) for mailman id 431810;
 Fri, 28 Oct 2022 08:57:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooLBH-000182-Qe
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 08:57:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooLBH-0007M4-4M; Fri, 28 Oct 2022 08:57:35 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooLBG-0002qR-Tr; Fri, 28 Oct 2022 08:57:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xc4rDD/Tjg4Cr4rqbTeGQCCMQ6E5SqAkGxeslyDT418=; b=jBOUSeY9lIkucCDLtyl29NJvXb
	gI1lFgUDB6/khDZJNtFJnCeIKAzlqBInhu39YJRSBbGLeeEm1fXmAu5v9SSwi6CoVNkMvzDdJ5SM4
	VwhRKskoxIA4zzReW+ZnlY91Cxoznxl1ojVcpGK7jmBENcQ3ZcuvhupHO+aySRwfiCdE=;
Message-ID: <e7c17d83-d9f2-bb9e-24ae-8bc44005deeb@xen.org>
Date: Fri, 28 Oct 2022 09:57:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Feedback for postponing the 4.17 release to a week later
Content-Language: en-US
To: Henry Wang <Henry.Wang@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 "christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
 "christopher.clark@starlab.io" <christopher.clark@starlab.io>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall
 <jgrall@amazon.com>, Stefano Stabellini <stefano.stabellini@xilinx.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "jgross@suse.com" <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 "Wei Liu (LSG)" <liuwe@microsoft.com>
References: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/10/2022 05:43, Henry Wang wrote:
> Hi all,

Hi Henry and others,

> Since there will be a batch of XSAs released on Nov. 1 [1] and the original date for
> the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the 4.17
> release to a week later (Nov. 11) to give a little bit longer time so that:
> 
> - The security team won't do anything in rush.
> - We can have more feedback after merging these XSAs.
> - Include more release-relevant bugfixes.
> 
> May I please have some feedback on this proposal? Thanks very much!

Somewhat related. When should we branch for the release and set 
CONFIG_DEBUG=n?

I think we would at least need a RC with CONFIG_DEBUG=n but IIUC we 
usually do it at a point where the tree is nearly frozen.


AFAICT, there are still a few things in flight (including fix for 
XSA-409). So I am not sure we are in position yet to branch. Any opinions?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 08:58:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 08:58:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431813.684414 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLBm-0001bv-Hk; Fri, 28 Oct 2022 08:58:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431813.684414; Fri, 28 Oct 2022 08:58:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLBm-0001bj-Ep; Fri, 28 Oct 2022 08:58:06 +0000
Received: by outflank-mailman (input) for mailman id 431813;
 Fri, 28 Oct 2022 08:58:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/aT=25=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ooLBk-0001Qc-Oa
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 08:58:04 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2067.outbound.protection.outlook.com [40.107.105.67])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a10f23d9-569e-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 10:58:02 +0200 (CEST)
Received: from DB9PR06CA0016.eurprd06.prod.outlook.com (2603:10a6:10:1db::21)
 by GV2PR08MB8148.eurprd08.prod.outlook.com (2603:10a6:150:7c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 08:58:00 +0000
Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:1db:cafe::70) by DB9PR06CA0016.outlook.office365.com
 (2603:10a6:10:1db::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 08:58:00 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 08:58:00 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 28 Oct 2022 08:58:00 +0000
Received: from 0ca4b9fa6598.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 23F7E541-CCE8-44B2-8FBD-C5E9836A16D7.1; 
 Fri, 28 Oct 2022 08:57:50 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ca4b9fa6598.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 08:57:49 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DB9PR08MB7583.eurprd08.prod.outlook.com (2603:10a6:10:307::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 08:57:37 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 08:57:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a10f23d9-569e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OLoBYMTMdgJOcsYGGrm5k6HDOLSMGgCjrJc6L5Bb/Ll0lAxXiAIZkuJb6EVCZPTJJNRMbw6gIFxrTig2dqUpIobpJGaRY4x5/QNEj5MlCDAfbDGRprIgKUyTbiKlZ+JUcHXJ4B/wC51OghDl3Ixr9D2oMHYdU2acTDGm2zBJGszWwrI/JH72UEl0zs0v2yRKNJauc5p8HqHn5DqEqP8dtyY1sWQfwUpTHSuUHcXxTm5JFldSlHFvKRRmaNrzR8dT/eaENUm9r0lG3ZPIfmW/Zh4Ue7Xc97mhNDDFk82FAa0Kz7Gyalt1CW41+sTS5NeoLA/JUWFnNz1mIGU0XbxPhg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3VNCvhs6oGQQaRUA5pPwEFORpnG7m11d65KmpGF/gaM=;
 b=f7RvW00NmBNtHMgijYaZ4oIa/UCl7w04dgn9HdZOl1Lmt9u1Cm6BIRyltB6J93N1UPGHhay5NL0klqfvCZCWHnc8WBbthimRsfnoy7IeZpa+F7unEpX3RkzNFKZ5a05qSlSbsNRXa4smmyz6V0dPBuRqJT42oJiPi/Xe9pkrlbwLffnVW3wdjHg94WEzRJcjQZOfYPUAtFIVWXTk0Zxv2NM1u9g3f0iS2cM74xOyQ8o2Z0lvKIQvdyeMeIOHN5RQoJz1tbn7S22M2c/WsaLHXUUeHeWV2QqtSMhsixpukewGKeA/eR8B39RJcgLLD6/RbhNk6iouQpAhl/jFyUvmyQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3VNCvhs6oGQQaRUA5pPwEFORpnG7m11d65KmpGF/gaM=;
 b=edwn2LAEcDJPI/Z7KXcmTBAd7LsphdQx6KT3z+3cXgBTDVPhoSAhUU/GtPcsAh6XTzijcXgcp4+IoqeD0OIRdXI+V3dsa25BuuJVnajsotNcxHyUrzmyUQe6wYRB6j5RY4Vfqg9FU+NHTy+w8px7U0cejIxzQ+WMRQinQnUF4oQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UQEt4SCXUZWU8rzeABhBaAdd6VxHDON2quuyBCJDzCRbC1SH/1xw0gwOLH1HdfHmvRCGCkHHzDnOcZghsrr/PvjoRiizw3sUzhgCg73Fjp33DmmgNETY7Df2M0cjj/7oIMhVF3F1WgbvPqI+nxZ8E7Xyd6ihonAtsZrpJsnP5yTHrK1aPicTuC/Kj/Gk+w01vbZFIhMc0zgnudJUlv6EIu8L3UlFYG76DGRXKFNZuC9miGJ6ZlWlbh6n7fhGDNvEp8T3N4OxLn5Xa8SphufZaJaxmbIcrVxpyV4nBmMuwO2j/CYmdcWwHe65QrpA3IrcFtxep4mGQFB0N3U4XqXH7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3VNCvhs6oGQQaRUA5pPwEFORpnG7m11d65KmpGF/gaM=;
 b=I8F/eWabGOtid59yAqiWJF4T8NA4iP4qcJlogMIN+lKrkYoUTRwS9df5GImO9BbPdsWcz0lYEGsX7IFo816QmaETbB6dAfJ7WsVtp+XZtX/+HUrnYNStah9WIgNB4oIa+vYSZ4bv0Hq0ZCzCuZTTZqgzu2xgQ1piRRgTHMDeUEDPouuuabXiZeBNSNWI8b5R+dU2Qr1nc0OcfuNkpqFXDvC5hD5Sb4FKJdh6BzdWYs4xfoceC7IKihTHK9MTXl2FCBsDNNWPbdXplt9eY/1ad/P+A/GQIgYuX1JKJLHMKX3guFSa0U8ytaFezKbmGzl68y5lhcrFfOyRkaaAEegd8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3VNCvhs6oGQQaRUA5pPwEFORpnG7m11d65KmpGF/gaM=;
 b=edwn2LAEcDJPI/Z7KXcmTBAd7LsphdQx6KT3z+3cXgBTDVPhoSAhUU/GtPcsAh6XTzijcXgcp4+IoqeD0OIRdXI+V3dsa25BuuJVnajsotNcxHyUrzmyUQe6wYRB6j5RY4Vfqg9FU+NHTy+w8px7U0cejIxzQ+WMRQinQnUF4oQ=
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>, Andre Przywara <Andre.Przywara@arm.com>,
	Ayan Kumar Halder <ayankuma@amd.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>, "stefanos@xilinx.com"
	<stefanos@xilinx.com>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject:
 =?utf-8?B?UkU6IFtmb3ItNC4xN13CoFJlOiBbWEVOIHYxXSB4ZW4vYXJtOiB2R0lDdjM6?=
 =?utf-8?Q?_Restore_the_interrupt_state_correctly?=
Thread-Topic:
 =?utf-8?B?W2Zvci00LjE3XcKgUmU6IFtYRU4gdjFdIHhlbi9hcm06IHZHSUN2MzogUmVz?=
 =?utf-8?Q?tore_the_interrupt_state_correctly?=
Thread-Index: AQHY6jes783wY66tZUuv7V7GxLd9Pa4it9YAgADJ0oCAAAA2oA==
Date: Fri, 28 Oct 2022 08:57:37 +0000
Message-ID:
 <AS8PR08MB7991735529442CA6021EB4F592329@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <20221027190913.65413-1-ayankuma@amd.com>
 <20221027215316.768881c9@slackpad.lan>
 <ef4cf2ac-7b79-e0c2-6e29-b24154c9379f@xen.org>
In-Reply-To: <ef4cf2ac-7b79-e0c2-6e29-b24154c9379f@xen.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 1D9E60B4502C874CA4632FFC666FC256.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DB9PR08MB7583:EE_|DBAEUR03FT060:EE_|GV2PR08MB8148:EE_
X-MS-Office365-Filtering-Correlation-Id: acf1e213-161c-4186-6c93-08dab8c283d6
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 emUPIVQOhKsLIJmmiriuiix7lcbZ46xdnQMn1eY3RnlGYkXdEg2gZkp5dxupdtz+KH009CKSTJDHhVKRy2JUUWW2JhWXWP1J+QKa+SfTpbeXSP5ZzGlCEJiuDwJ3Z+2BlazBMA++xZ7Dh2O8OC9+X1Tn+kLgCw+KeCRnnRFNSVh9C0SpRTlTATXF79I0U1yObcbQwSbkniQjsAvSSKGSTLtbVX3u9WSbrZPBrViwZf2lMHzQ6f5ahHu6RH+8LFRLsPhuzZX+6XmYqev5rThsg23HJ/6q0OUxxe7+69xQnIOs4yDyrfLwNTJHopPipczREGX+J0sLW1LlBF+++DZo8er6vlXbZRALY8gtFyLy1RttMYXH3/9/LuP04tF1Rk1Z1MXM9ea7cKCZxfwjll+OxhYwDLOjHiKLSCxNQ/eALTOYIPB2gv4g7MHmZYvs+qWxlQqz2GflpS1hsidX+6H1y2MlR1bvKWWnkl/BEJBY7okJGZYS420HVl0G2ONxVnNvpHdSo7Lr3JOMOad0lvOHYv2FMIAZoMdNoqsUrmgLpRt1ZaMWMAPsznjciq6COzF9JHbrYu/AzQYnB96UojZuDzFr/D3+i3RBJa1iTikSiLNLbxMRTO/Hj6DEw6uGkDTeesTlpIrQGsIWEGPsYRym7QJtgalbkj5lFnCy8iE6Im5Pmg/c95bkTCeY3iCIB/m5C3BgunPfDON89K9lD+DQzi0JKLWSUcHKMqfKBxqS7IOPfMpPtCjJ+UtAQKnzAO39n+qJgvjgImLc6Y5kBKSGoA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(451199015)(2906002)(186003)(8936002)(478600001)(83380400001)(52536014)(5660300002)(9686003)(71200400001)(41300700001)(38100700002)(122000001)(26005)(4326008)(53546011)(76116006)(7696005)(66476007)(54906003)(86362001)(64756008)(66556008)(38070700005)(6506007)(316002)(55016003)(66446008)(110136005)(33656002)(66946007);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7583
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7ea9f62a-7807-4ff2-15b1-08dab8c27674
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cppMD4hGxOYuHAMp6aC1Q2ujFvPlBpiQmUpNaDNVWYZipecZabDsam3gjdGDjQE8i69RXMbnNiC3DMlUApN/bfw5klAYQkldk7emM7h6Mxa2v2lVw0pleelfz3OmHoXIJcLEgXn0dSqA4n89GL1fQ0sHNm7oMSrp6eibzMW5EgowfcxcoUgV/JXhfRvL4bsXEaYbqYVk3J9tQ883q9GjYlZ7z7lUWW51ESTpXqLLxMc9Q0wdjEFilEos5sMWmTUd+G3ORoDFzuKHRfzSPyDHinzvWEfFf0jfw7X1Bwe8Q2wqo1OoT/e/1QJkq7nIOHI1DB5mJWDUD3UkonKIrZUnz1/VAodiV75pJz2/fPAZ7/xwxbpdo4idXFbFKwu1aHZNuzlScxJ4gV40ero9Ta2y2eA5D2YrA6FsaHE4WwLVzLui6oSpAuopVlKT61e+7hUnKck0O8OGIxpchlRQQp8TBKDsj4AHM/77HMg0rt6DwcOTqipwVpsA9e976uVUep0WR2pyDPCbEVAHOrFFQLDJjlm+yhx02ZTA7Y30r1MjSJk17iRbiv+UYHZxz9K/8ApBGQlHypdpDIafMUrioykuPQNZ5a1kd9pJNNK+WkhL+dID3iXWli4EWbVMVlyD4p6++qsj0NPPcoXwgFu4I1WGtwBZfUEJPP4e7aTurfN/VmJZTa+uSFvhZnZNTZDQd0c+sOwnMHQBZ+VsF1DGHOFvp9WZY1xRaxGsnKkhRiqveGBmuLTt7/kLwhLdtdl5ZjcK3j7MHIO/ck1PAAZXR4ZW2w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(316002)(336012)(47076005)(83380400001)(33656002)(36860700001)(81166007)(356005)(8936002)(52536014)(5660300002)(70586007)(70206006)(82740400003)(53546011)(41300700001)(40460700003)(7696005)(82310400005)(86362001)(26005)(2906002)(4326008)(9686003)(54906003)(110136005)(6506007)(55016003)(186003)(478600001)(40480700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 08:58:00.1224
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: acf1e213-161c-4186-6c93-08dab8c283d6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8148

SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IEZyaWRheSwgT2N0b2JlciAyOCwgMjAy
MiA0OjU2IFBNDQo+IFRvOiBBbmRyZSBQcnp5d2FyYSA8QW5kcmUuUHJ6eXdhcmFAYXJtLmNvbT47
IEF5YW4gS3VtYXIgSGFsZGVyDQo+IDxheWFua3VtYUBhbWQuY29tPg0KPiBDYzogeGVuLWRldmVs
QGxpc3RzLnhlbnByb2plY3Qub3JnOyBzc3RhYmVsbGluaUBrZXJuZWwub3JnOw0KPiBzdGVmYW5v
c0B4aWxpbnguY29tOyBWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbTsgQmVydHJhbmQgTWFycXVp
cw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bh
cm0uY29tPg0KPiBTdWJqZWN0OiBbZm9yLTQuMTddwqBSZTogW1hFTiB2MV0geGVuL2FybTogdkdJ
Q3YzOiBSZXN0b3JlIHRoZSBpbnRlcnJ1cHQgc3RhdGUNCj4gY29ycmVjdGx5DQo+IA0KPiBIaSwN
Cj4gDQo+IE9uIDI3LzEwLzIwMjIgMjE6NTMsIEFuZHJlIFByenl3YXJhIHdyb3RlOg0KPiA+IE9u
IFRodSwgMjcgT2N0IDIwMjIgMjA6MDk6MTMgKzAxMDANCj4gPiBBeWFuIEt1bWFyIEhhbGRlciA8
YXlhbmt1bWFAYW1kLmNvbT4gd3JvdGU6DQo+ID4NCj4gPiBIaSwNCj4gPg0KPiA+PiBBcyAic3Bp
bl9sb2NrX2lycXNhdmUoJnYtPmFyY2gudmdpYy5sb2NrLCBmbGFncykiIHNhdmVzIHRoZSBjdXJy
ZW50DQo+IGludGVycnVwdA0KPiA+PiBzdGF0ZSBpbiAiZmxhZ3MiLCAic3Bpbl91bmxvY2tfaXJx
cmVzdG9yZSgmdi0+YXJjaC52Z2ljLmxvY2ssIGZsYWdzKSIgc2hvdWxkDQo+IGJlDQo+ID4+IHVz
ZWQgdG8gcmVzdG9yZSB0aGUgc2F2ZWQgaW50ZXJydXB0IHN0YXRlLg0KPiA+Pg0KPiA+PiBGaXhl
czogZmU3ZmExMzMyZGFiZDljZTQgKCJBUk06IHZHSUN2MzogaGFuZGxlIHZpcnR1YWwgTFBJIHBl
bmRpbmcgYW5kDQo+IHByb3BlcnR5IHRhYmxlcyIpDQo+ID4+IFNpZ25lZC1vZmYtYnk6IEF5YW4g
S3VtYXIgSGFsZGVyIDxheWFua3VtYUBhbWQuY29tPg0KPiA+DQo+ID4gVGhhbmtzIGZvciBmaXhp
bmcgdGhpcyENCj4gPg0KPiA+IFJldmlld2VkLWJ5OiBBbmRyZSBQcnp5d2FyYSA8YW5kcmUucHJ6
eXdhcmFAYXJtLmNvbT4NCj4gDQo+IEFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6
b24uY29tPg0KPiANCj4gSGVucnksIHRoaXMgaXMgZml4aW5nIGEgYnVnIGluIHRoZSBJVFMuIFRo
ZSBmZWF0dXJlIGlzIGF0IHRoZSBtb21lbnQNCj4gZXhwZXJpZW1lbnQgYW5kIHRoZSBjb2RlIGlz
IG5vdCB1c2VkIGJ5IG90aGVyIHN1YnlzdGVtLCBzbyB0ZWNobmljYWxseQ0KPiBub3QgbmVjZXNz
YXJ5IGZvciA0LjE3LiBCdXQgaWYgeW91IHN0aWxsIGFjY2VwdCBhbnkgYnVnIGZpeCAoSSBrbm93
IHdlDQo+IGFyZSBjbG9zZSB0byB0aGUgcmVsZWFzZSksIHRoZW4gSSB3b3VsZCBsaWtlIHRvIHJl
cXVlc3QgdG8gaW5jbHVkZS4gSXQNCj4gc2hvdWxkIGJlIHJpc2sgZnJlZS4NCg0KWWVhaCwgb2Yg
Y291cnNlLg0KDQpSZWxlYXNlLWFja2VkLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5j
b20+DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gQ2hl
ZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 09:03:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 09:03:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431827.684425 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLHH-0003FS-9K; Fri, 28 Oct 2022 09:03:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431827.684425; Fri, 28 Oct 2022 09:03:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLHH-0003FL-6c; Fri, 28 Oct 2022 09:03:47 +0000
Received: by outflank-mailman (input) for mailman id 431827;
 Fri, 28 Oct 2022 09:03:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jtyv=25=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ooLHG-0003FA-80
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 09:03:46 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20059.outbound.protection.outlook.com [40.107.2.59])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6cd8b4ec-569f-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 11:03:45 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9379.eurprd04.prod.outlook.com (2603:10a6:10:369::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 09:03:41 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022
 09:03:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cd8b4ec-569f-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Thj45cOvF6xhvnzrL0CKBx3efBZaHnagkuakZMzkqFFuHS6jWo4SFsiyH0kNnxT5AwO0bnV1Ro5dyXYto1Bgrw6eXffQEIdY/+30VYGrTawPazbVfvUCDPYV15pG77M3nvkapmBe72cJn3Ga9b0YBlV1J/V9L75c6KsCMtloA1Kc/BICX+A2lkiup98mPQaYRLltC8RhqHiZTyvhv9JXtATtddwt6cYf9do6RLm6EiS0gRAZlGEdD//dYMet1p0WHmAaIxG3md1SUPEnyOAk16BeAGJU/yedHNyXtvQHvIJ+SRqSzPxCBqD3X3JT4ulNSY6EZQiCHVqO21Vz5NSt+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=38HujbxyAcKqIYPwr5Xd2OBOLvK5AmFEiA/xyjMJjK4=;
 b=SChBokodAWUxin8E8f11rRUJ3aXR1nn7EVZnP550miuj709uCnzGm89a/t4ELS+hSJrLDl4J/JZ88i96TFDQ9OLdlP5wBgj5DpwPysA95K3DrmPAu0IgKbKphp0lbYSjYXNTO1eGWrnk3wty2+8dhe6/bzivZuIz+h8kgAr93MEyam+5sQvkJDH+JtDc62RFnBVkYjwp5iNbWuIyBGWkhxTC17fktbQfM2Fy24WNh+uOo0LFTMgcS43scVgRY748Cyjpzcj8vOSMYhXPu1hMIUj6Ie4mGLMKXSPmlerW8E29JTzJ6tTtG/leLUlt67gFBqkErV3wViXlqyxDPgKiAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=38HujbxyAcKqIYPwr5Xd2OBOLvK5AmFEiA/xyjMJjK4=;
 b=OozcEDx8WrCmaeBFkpgFOwLAwv3krELDacLcpMsIbIOMdzApNOZCyUg7hnnwO69hcS+6AsOsviy08I3mm6DWvc2Ey/iHUL2qbztK2SKU5djtZcdFA3Fsbb+4GUP2lU7hrgWvGiIpF9Gu5HgCdc8G5SpS+hPP2PlixSjrcwRDBdZtsZ2EhqGjonJX2ktrmbGuBACEAt7rS2N0AIo3oS6T56QPiVn4rGzX0b2s/dTkBhQUBFJgirQA/nCvFo8QT9gsejW4Vuj2loB0hkIdAQ5FHwvDBgwUEnTPIZ7Tsi3XbMOQy1e4jzJcQqhkxQHVlcVvK55NinfsbVwg+QdZMR8F2w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b1312717-15c8-f90a-c84f-1bf8709007ee@suse.com>
Date: Fri, 28 Oct 2022 11:03:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Feedback for postponing the 4.17 release to a week later
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 George Dunlap <george.dunlap@citrix.com>,
 "christopher.w.clark@gmail.com" <christopher.w.clark@gmail.com>,
 "christopher.clark@starlab.io" <christopher.clark@starlab.io>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall
 <jgrall@amazon.com>, Stefano Stabellini <stefano.stabellini@xilinx.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "jgross@suse.com" <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>,
 "Wei Liu (LSG)" <liuwe@microsoft.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7c17d83-d9f2-bb9e-24ae-8bc44005deeb@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <e7c17d83-d9f2-bb9e-24ae-8bc44005deeb@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0141.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:95::14) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9379:EE_
X-MS-Office365-Filtering-Correlation-Id: c28abc89-944e-454f-fb8d-08dab8c34f23
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QlBfKQofXqQPyd5gU6gjW8t53QSa7ThVmjVo/Z0aqG7Y1Cp4n4tIVaR3I929KVK9j1J9oPZcqnyViw4FXGOB9x/XTXRI+VjUNTAexDZc8BVqSM43WW7zFcmrefAczEtf3jid5Oxzj6Mu3y46zvEsoxVvJjgxXgTeBSk/wQoDPyIOTeMKjSEwGxb5px2Jqh7cQYo58KTI8RAnkVVzUZkzlnWK7wKZ0+Y2vNd+8QjKq4mSzgPbipSXRLCdSKPsIDhC8HzI/KCGWG6eFgC7+9/EnPi8fGQUVqDRzy4yAlULX1KVJByQZfJN7jeo5bmiAfDKdLaZgTHXyi2LjtJ3CZUTwlsO5J6s5HFFGZfITji39ivqOcE6Xnj5OZ3e0iPbAzDU+TMpzrIBi4c4dFO/j+jq33ReL7ggso823toL8rSeFSHb6/PMV72IkyW4uLBLqSAyynd1KJKyddcF1gQR2k463HXpnwx0D7pSoi8ItQmTFuq+95LZbUHiu8dM1zDqmm+3APU4ETiOYFEn8t+EvjnxZp+oaBh6P03PsUuTbGFV7v8m94JcQ5CAWSca3NQTlVNxF8yQyAnXhV0Q8AzpAt6uEkjNDKakMvThNvvie5P6aGCGuGvYnKQ1xkYnq+4WK8tuCNQxcB0P48F6XEayNQYZubki7avD7XVnx5BRe88CDrnRxA1GVyISKMxkjxzdeVfGTrp7F8njQ9Asq0WScOGFa08qNx8HG7W17vG1agdnXcDK8OGP6VObkmAid3Ow2E7fy1fzhznxw3F5jKnrReM+sJemBkjTV1SNCnNl2oPPkvs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(346002)(396003)(366004)(451199015)(86362001)(41300700001)(31696002)(8676002)(66556008)(110136005)(66476007)(66946007)(316002)(4326008)(8936002)(6486002)(478600001)(54906003)(66899015)(6512007)(38100700002)(26005)(2616005)(6506007)(53546011)(186003)(83380400001)(31686004)(2906002)(36756003)(5660300002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RmtoRlpxNjU3Nk1Kd0ZQeVVCTlBGQWpKcWgwYXdtdnE1ajV0b0xsYnR0d0Vu?=
 =?utf-8?B?Y3d4Si8vMGd5cC9sUHhSVmhxckhLMUt5UlFTeW1PVUdJNEtIYWNBUFdjeUJK?=
 =?utf-8?B?ZFlCUWFURTJlMTJDcVFYeGZHL2d3QlVldHNWVC9sUVdJMW44SHZSNllFRUNp?=
 =?utf-8?B?YjhBVEN4ejJhR1Q3TkZpU0l3NjdoWi91MXBOR2tNSm8xUCt4aklPVS9RMEto?=
 =?utf-8?B?V0xNaHEvQWRNWHU5MWUwR2M4K21wZVoxd2N0Sy9pUnNDQkJiYjQzOXpMbE1v?=
 =?utf-8?B?NnFyeGNIUnQxdEVHRDlJTGozWkJEZkt1QThIT0Rrd1psRnRWeVF5YzJUdnJi?=
 =?utf-8?B?STRSVG5NN3BrekVwL3lOempQeXRSU0Y2ZVNFdEFzM1JOeWhxdGNIbFBHcjha?=
 =?utf-8?B?SjRtVnZob011WW4wdVlWR2RMZVBlb3RjUnl0Y2FDdVR3bXRRdUpMTTRPUVRh?=
 =?utf-8?B?MHNCejBCaDhBaUErVTRlY1A5QW1PQ0hmN2ZXa0NtWkhMVEFRR2tRbXVkbWla?=
 =?utf-8?B?LzhsNlJxY0tsY25nalZxY0t6MWlvUTI0U21RbHg0ZnJSbnQrdFdZZkpuZUlm?=
 =?utf-8?B?UXdWSEZweXJqemdQVTZPUm9abnp6bXIwSHI4WmovSlQ1Skg0MDNEVEhUTUlv?=
 =?utf-8?B?ZVF4QW1wb0tBUm5HM2RyMGVJU3krYW9FN1Z6NkttWitzNXh1dU1hYUdxY3Ay?=
 =?utf-8?B?MWUxNjhxSlRBMVBWd2RQR3ZEbmprRjBmdk96S20xRHUzMWMybmUzWksyN0Fa?=
 =?utf-8?B?d0FZY2RLV1dKd0ZQanhWVDRneGVZQjNNU1REVzQ5NEk3SkEyL0hBY1BDcVlR?=
 =?utf-8?B?RXgvSHEzR3BZK2hzZjNVOUswd2RwVVRHTXNHOWlpek50WDFqcFBhNzEvK25X?=
 =?utf-8?B?OHdmRGJrL01OVmg4N0QzQXFJRXcwcTZ6Q1RHQ0tya01ZYTNlZ096NGVtcU5Y?=
 =?utf-8?B?eDI2NkFmdzk2dnFnWmlGdlI2WTdIeU1Cb3hQTjdqYitmUXp0L3c1REswcmx6?=
 =?utf-8?B?c1JJaFI1U20yWjlWVmFycWp5MjAvbkdFRzg3SE5OcUhpV0VxY3BLR29RR1dX?=
 =?utf-8?B?Snh5cXFONDBtRUVud0RaZlJKcEc4Nk5QLzlzYlBxVFdBZFd2SERJb2RqQjNY?=
 =?utf-8?B?b29KZG5EN28wazlJT2xOQXZSWkxRZE5meE1MQmpyUEkraC9pVmZEbVd4SjVy?=
 =?utf-8?B?ZUZYM09LM0VsWWdpZkJFV0RzL3ltY25HaHQ0Z2dsT0NLVzd1M3QwSEliTmhs?=
 =?utf-8?B?bXk4OEtJbHl2bERuRlBoU1d0d3U3Lzc5VGpzUlJodUhUUElWcjFzQ0pVQ3BP?=
 =?utf-8?B?c2h6QTdienB5aE1jSTJoRG5CRlA3RFl6WFNSOHp4ZUIwNUJsS3k1MkFOYm1V?=
 =?utf-8?B?VTJNY1pDWVpoaDFKWEgrbG8wSmQzVnBsZ0tQZDYyN0R4VjFDZGtlOGpZVXA4?=
 =?utf-8?B?eFUzUHBsa2FEMEtoM3FaSHJOOG12cHVUL2hUVGYrUGVsYW5NZE1EY2dSMFdJ?=
 =?utf-8?B?MTVXMnBjREZ1OU52WHFVbVFWWU8vU1VheWhMVGxLODhYNm4xS2l5RWMrT2Ur?=
 =?utf-8?B?M1AxMnFJQzV6UUU1N3hiZENoSk90MXlaVWZNelJZSjkxWDFUajFkTC9qbE9Q?=
 =?utf-8?B?d1FBbEpGUzJ1OVhOKzMwdjhBREhwQmxDQW56SUZGemFOK2xRNGRPSU1teUV5?=
 =?utf-8?B?QUJ5d2dwblFOa2JWclNWOUxqb2pVK3pVMGxHRVNTR3ZVL2xoaUQ5cXlYOTVQ?=
 =?utf-8?B?cU1adTcyc01NY1d1Y044dnYzb0ZQajJKS0MybkNNUW1RV3dVd2N0Q0hreGRJ?=
 =?utf-8?B?ZXVrbEFYSW4wU1R5WWFVYjkrT213MjdHQ0xuQUQ4Z204d245cEZvdzB4RVNQ?=
 =?utf-8?B?d2xKaS8xaWNDTmFCMUdldXh5UkdCOE1xOU54bHQ3dHR4UE9XMERHamZrM3Jo?=
 =?utf-8?B?ZkVrK3NPWWdyVDdoQ0RQMG1qVXI4NGhPMGs0T1NZMTRsWDQ3RkhTL1R5VUZE?=
 =?utf-8?B?WDJLdURoQ3k3STdpd0hpMXVaa1pzd2h0RkhxcE83OGtQYTNkT1d6dFhjZFJr?=
 =?utf-8?B?bjlneUl5eU9XYVRza21tMHRjS3MyMldCVnhWWFlGT0FoOFZzZTQ3ZHRqdVBM?=
 =?utf-8?Q?qElIfyE0y4l0n/GSWI9gka6tn?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c28abc89-944e-454f-fb8d-08dab8c34f23
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 09:03:41.3175
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IBh2SjM/UG8b8Oj3/phaIjNGAbm2TvqsmmE9nG9NU3HE5ybnxjAzCQU/lVplpr9P25SM9v+E/tLTzzmcwYj6Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9379

On 28.10.2022 10:57, Julien Grall wrote:
> On 28/10/2022 05:43, Henry Wang wrote:
>> Since there will be a batch of XSAs released on Nov. 1 [1] and the original date for
>> the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the 4.17
>> release to a week later (Nov. 11) to give a little bit longer time so that:
>>
>> - The security team won't do anything in rush.
>> - We can have more feedback after merging these XSAs.
>> - Include more release-relevant bugfixes.
>>
>> May I please have some feedback on this proposal? Thanks very much!
> 
> Somewhat related. When should we branch for the release and set 
> CONFIG_DEBUG=n?
> 
> I think we would at least need a RC with CONFIG_DEBUG=n but IIUC we 
> usually do it at a point where the tree is nearly frozen.
> 
> 
> AFAICT, there are still a few things in flight (including fix for 
> XSA-409). So I am not sure we are in position yet to branch. Any opinions?

+1 to it being too early to branch. I would suggest that the XSA batch
should have gone in first and release blockers should have been dealt
with (unless for some it is clear that they're going to be unintrusive),
to limit what needs applying to staging and the new branch.

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 09:04:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 09:04:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431828.684437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLHV-0003c1-J2; Fri, 28 Oct 2022 09:04:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431828.684437; Fri, 28 Oct 2022 09:04:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLHV-0003b5-EA; Fri, 28 Oct 2022 09:04:01 +0000
Received: by outflank-mailman (input) for mailman id 431828;
 Fri, 28 Oct 2022 09:04:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooLHU-0003Yl-1d
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 09:04:00 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooLHT-0007Ve-Qh; Fri, 28 Oct 2022 09:03:59 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooLHT-0003JM-KU; Fri, 28 Oct 2022 09:03:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=exK0Gy4/b9EaVI8b3aW0mesZXl0ghD1t8Y2i7FvRjt8=; b=6d3crXQovgHzcXEnl7hrvNJk8A
	wo0fRWhJsOGX35Vox1LWBZ2sLGKwYFI6mgi7ftMBsta8I4K0L71lk56eSzHOet4lJbEONnDp6owwJ
	LwfIgOTdEy1pmNvMlY+v7GNzeJy3qAmYv8ciSj5ZgJ4KAUh5fnIvkgQgVPPZ1b0m4JBM=;
Message-ID: <ecd3e603-b1d1-210b-1212-3b9151f4bc3d@xen.org>
Date: Fri, 28 Oct 2022 10:03:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH] xen/arm: Do not route NS phys timer IRQ to Xen
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221028075630.32261-1-michal.orzel@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221028075630.32261-1-michal.orzel@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 28/10/2022 08:56, Michal Orzel wrote:
> At the moment, we route NS phys timer IRQ to Xen even though it does not
> make use of this timer. Xen uses hypervisor timer for itself and the
> physical timer is fully emulated, hence there is nothing that can trigger
> such IRQ. This means that requesting/releasing IRQ ends up as a deadcode
> as it has no impact on the functional behavior, whereas the code within
> a handler ends up being unreachable. This is a left over from the early
> days when the CNTHP IRQ was buggy on the HW model used for testing and we
> had to use the CNTP instead.
> 
> Remove the calls to {request/release}_irq for this timer as well as the
> code within the handler. Since timer_interrupt handler is now only used
> by the CNTHP, remove the IRQ affiliation condition. Keep the calls to
> zero the CNTP_CTL_EL0 register on timer init/deinit for sanity and also remove
> the corresponding perf counter definition.
> 
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
> ---
> Based on the outcome of the following discussion:
> https://lore.kernel.org/xen-devel/d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com/
> ---
>   xen/arch/arm/include/asm/perfc_defn.h |  1 -
>   xen/arch/arm/time.c                   | 16 +---------------
>   2 files changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h
> index 31f071222b24..3ab0391175d7 100644
> --- a/xen/arch/arm/include/asm/perfc_defn.h
> +++ b/xen/arch/arm/include/asm/perfc_defn.h
> @@ -70,7 +70,6 @@ PERFCOUNTER(spis,                 "#SPIs")
>   PERFCOUNTER(guest_irqs,           "#GUEST-IRQS")
>   
>   PERFCOUNTER(hyp_timer_irqs,   "Hypervisor timer interrupts")
> -PERFCOUNTER(phys_timer_irqs,  "Physical timer interrupts")
>   PERFCOUNTER(virt_timer_irqs,  "Virtual timer interrupts")
>   PERFCOUNTER(maintenance_irqs, "Maintenance interrupts")
>   
> diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
> index dec53b5f7d53..3160fcc7b440 100644
> --- a/xen/arch/arm/time.c
> +++ b/xen/arch/arm/time.c
> @@ -222,8 +222,7 @@ int reprogram_timer(s_time_t timeout)
>   /* Handle the firing timer */
>   static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
>   {
> -    if ( irq == (timer_irq[TIMER_HYP_PPI]) &&
> -         READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
> +    if ( READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )

AFAICT, this condition is meant to be true most of the times. So as you 
are modifying the code, could you take the opportunity to add a 
"likely()"? Or better invert the condition so the code below is not 
indented.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 09:08:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 09:08:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431836.684447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLLl-0004iS-3A; Fri, 28 Oct 2022 09:08:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431836.684447; Fri, 28 Oct 2022 09:08:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLLk-0004iL-Vq; Fri, 28 Oct 2022 09:08:24 +0000
Received: by outflank-mailman (input) for mailman id 431836;
 Fri, 28 Oct 2022 09:08:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/aT=25=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ooLLk-0004iF-2D
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 09:08:24 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 12b624b8-56a0-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 11:08:23 +0200 (CEST)
Received: from AS9PR04CA0162.eurprd04.prod.outlook.com (2603:10a6:20b:530::22)
 by DB9PR08MB8739.eurprd08.prod.outlook.com (2603:10a6:10:3d1::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 09:07:57 +0000
Received: from AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:530:cafe::e4) by AS9PR04CA0162.outlook.office365.com
 (2603:10a6:20b:530::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 09:07:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT021.mail.protection.outlook.com (100.127.140.243) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 09:07:57 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 28 Oct 2022 09:07:56 +0000
Received: from b140c5e11771.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2E97AB99-25D3-43B0-822A-4A6872410224.1; 
 Fri, 28 Oct 2022 09:07:49 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b140c5e11771.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 09:07:49 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by AS2PR08MB8477.eurprd08.prod.outlook.com (2603:10a6:20b:55b::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 09:07:43 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 09:07:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12b624b8-56a0-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=DLJBoi0rlzz6l1kSWMcQgDsebyw9uzFZKJOyRB1Zp6KgSWI8MYdWQTwsu92f0807yhB9wXWdRMOcUf3O5glAJ+lN6XKb7spkQCb073JYz9phNnKTLK74cUxql/vmRFEO1HBLvRtOPcusJOAqZKcG2HKAxQkjGzgag05+X72K5OSpWFXOHfWm1w9vwbcvUd3qQRU2gZF+1h3cXblOazC0dB3HGCO+l2yNHz4eXQ2qxtTpCDEIgaEMYj4y9RIafDkh3xJnxSPvMIL3cYwdEpWmnxBMGdu7xCQL1gd3mWJueCBSp1tNgH00SZKnEJ7Aq6Oh1c7glWbfBU1Oez3xgBD2Mg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BkywJmE3cQrYTa8E/EP2z+5ZHNzxv9/EwXFHqJCAsAo=;
 b=VxzQScaRjlbdClzoxSTBmvCDxxTXm9AgL91NHUz1m9nhHzYt3QfPt61SZaVEcHtqbfgRFIz1iS1EL2dv7zYggDkMjF1V2xMS9e3HG5oEnAOqSB78vsrhJT68qf3YxbjmrNf45/YivBd12xysR6KW6KmP7I1N7S3ba1M5JG4f+08WFZaiu6C/Ot5OKAaG6/fZ+bmzyNlwARfK9KGtq9JXYDaAvzBnqGzE9KY0IlyrwJBf7BDIFfjcjyThcdRAg3ZnJTs4/liou/lZsSljJb5lMgjxLnD9SMRd+BHf+082hz+XAHpmQkpPSHpFxEo92ZM40Iy2pCgjGZ9FBjtdegdOSg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BkywJmE3cQrYTa8E/EP2z+5ZHNzxv9/EwXFHqJCAsAo=;
 b=jGSdEf7grreNvj5tVo5/UfOy1XQXkw6I5ilQ1CcSFDQvMv3V9Wj8oFMM+t8GQe6HI7NdULN2p4Owdxc32QSFnQCrUe6Hq2wTtPy56kVNseKSX1IT6nKM6ohGaZetJgUNRBuKRjr1udd2rNEAPYtO3kmqbs00P0UM9xQ8j/t9EOI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IIP3ADY0DhFj83Or22zktGWvUnbgW4aLy+zKKBLw0K8H+QkfbXupKO5MmnGn6QIvZvFMg6QnxhJAJWlJVf/fSo4LAaRb8z8Poh41buFmsJYkTwKSUw++KXa52nHFkDm+BBh/m2ldq9bx2nEFeqySlVMzQ+1rdlb0egd7l5ReIO8EWy6t5PKL61G3JAjhv4iqcT2qIF7I9Q7Ro9VzW/CNddqJcVdMxWN9qRFfU6pjy9cN7fZz2to1hDcYl/3JxA4F7oKY2WyS2FNS4sOfjvbqLejx2+iNDMbut0++PgqANjvwKC/M0ik4E9MiBYrschjJ5VMK93b1/5NQpFfxcdkEBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BkywJmE3cQrYTa8E/EP2z+5ZHNzxv9/EwXFHqJCAsAo=;
 b=llPHS7VngbLi5TIcQLYSWL3QjIW6QjqbXF7OmwplkGR9oIpi8Yg1rSrc+2OfGMoTYs9/uf/wm4vlDlGoij0ziACIz/dFqJ/8gkqQyDGnW/Fflg2wvnvi3UbjrVdVEhlgH9FdJQW3M75inbC7yYRD7B7t1mATyfKN1yPi+PcmWNDiAvVFoYc7JuR2tSLlM7o+NAqkUNWmJri/oz7PlLCRZWdHbVnseXs+LbXPZyEfHHwoJjg+gwZoIZMOcGKOFfzwNS70gpzGUg7Vr/oNDO+PXhEPIPKJ3ZlcgnW9itA13oMbQnudHy6mc4ox0UN9ob+DqL0kUljwRaSLIix2i7i9RQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BkywJmE3cQrYTa8E/EP2z+5ZHNzxv9/EwXFHqJCAsAo=;
 b=jGSdEf7grreNvj5tVo5/UfOy1XQXkw6I5ilQ1CcSFDQvMv3V9Wj8oFMM+t8GQe6HI7NdULN2p4Owdxc32QSFnQCrUe6Hq2wTtPy56kVNseKSX1IT6nKM6ohGaZetJgUNRBuKRjr1udd2rNEAPYtO3kmqbs00P0UM9xQ8j/t9EOI=
From: Henry Wang <Henry.Wang@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
CC: "Daniel P. Smith" <dpsmith@apertussolutions.com>, George Dunlap
	<george.dunlap@citrix.com>, "christopher.w.clark@gmail.com"
	<christopher.w.clark@gmail.com>, "christopher.clark@starlab.io"
	<christopher.clark@starlab.io>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Julien Grall <jgrall@amazon.com>, Stefano Stabellini
	<stefano.stabellini@xilinx.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "jgross@suse.com" <jgross@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, Anthony PERARD <anthony.perard@citrix.com>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Wei Liu <wl@xen.org>, "Wei Liu (LSG)"
	<liuwe@microsoft.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: Feedback for postponing the 4.17 release to a week later
Thread-Topic: Feedback for postponing the 4.17 release to a week later
Thread-Index: Adjqh6nb7bpyTo+8QPKuDS/Y5NDKqwAI6YmAAAA21oAAAA9FIA==
Date: Fri, 28 Oct 2022 09:07:42 +0000
Message-ID:
 <AS8PR08MB7991F1F7CCC8AC6A56F9F0E492329@AS8PR08MB7991.eurprd08.prod.outlook.com>
References:
 <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <e7c17d83-d9f2-bb9e-24ae-8bc44005deeb@xen.org>
 <b1312717-15c8-f90a-c84f-1bf8709007ee@suse.com>
In-Reply-To: <b1312717-15c8-f90a-c84f-1bf8709007ee@suse.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: AFA7768609CEF544B1ACFCFFB6E1A94A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|AS2PR08MB8477:EE_|AM7EUR03FT021:EE_|DB9PR08MB8739:EE_
X-MS-Office365-Filtering-Correlation-Id: 74998f9b-c30a-413b-45fb-08dab8c3e7c8
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6Nu2xKf4YPK3vWT12mE+GvkwgOTCPBoXR58z3zYtFL3ND12JZ251OEk0tP+pLzwDfkMc0T+d5sxZ/++Ag4dT+OR7/dbUgv+1qiLeZ2vgRBOe5ZncO0BKnKwZp6CyrKWv3YBVBzTEko3Enank9mK5Y6YBXPdITcTI+LpuIQFe/oPlZBso3GgjuCvzDg6JJufq7WPk6iyqdj0e4uP0HMIYiWJg7X3l0GBDm+lg4Hrc7miTwGQnJjT3raT8Q8T97chzhKbxl+RviHlS5JQtrd2gRmVS8S7qPzm7++sZgZkPbwr1UQKBotHKq9kQnNorElG1Epa8gLqasYM8nmd/8Wc08/+5IS6FAbPG7wqIIqmYwwmPdKpCQmYVsLEAE+90NWL4LMQ6sCyozrRnKPu2L6VO+R++BIkthe8pH9EUL4UslTd3t2xGN0mfzRmrDkQJ7N39cJDdkxu2XhBi06zZH7k7W8tc/kAYW3GOFpxv6c3ecIxw8PFPU4gE+AAS+Hi/3BOYNrfT+vaKkvtGnoceFoQ/9dMaahTWZjdHrdGlPErUkozxT3Qs6NZSqaZta1UzeGnrrGt5sL5C2dNYEh8mqzQADagHxb3uWEwHltHHv2BDbm3Ru5uGbVVohckUP/yrH/k/S1q1trG65CiuAZF8e/SjBJMwGHqdzwP0Wyvne1H0xn9bHjFwQhRQ2Qi1vUqLmy7YdIPGY63HTS6RXmf6190eJfs/gI3SHd/3eTh2ae4MUI2OXb+jR4cqgmyyDK+s6Jf5imqYzSnbPCRkETEzg7jXAA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(451199015)(2906002)(55016003)(7696005)(122000001)(186003)(8676002)(38100700002)(86362001)(8936002)(6506007)(33656002)(53546011)(83380400001)(41300700001)(316002)(110136005)(9686003)(26005)(76116006)(54906003)(4326008)(66446008)(71200400001)(64756008)(66556008)(66476007)(66899015)(66946007)(52536014)(478600001)(7416002)(5660300002)(38070700005);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8477
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5895603b-0040-4516-63da-08dab8c3df37
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P9S0ulL2UWgFVNWhaEABhHvLru746TcRDtujyLdNP2t2BokHCSskm7IYQwgRh+j1IE4a5aoBWCEuH3Orq/UoH4FW+LXmboIusNXx83/94gWpL+rmfoottNKHNszeWwRUAnAfv8eKLVyzviGeAV7OKUZ2lnyIJnNsH8595oJSw2OtxT+6Zo9bEOXV3fcB1g9gLJXbX7ekhlF+VLIUGGQEkLkiwDKerkDVn5yAhNJtDBVP0Xs2oOZYDjoadnjtbJs5q/R/xPGL43wkss8C4T78CC5yiha1MaxW8cv7h4MM29jDkF/3O0jjp9gJ8avQfivvQIz8DkHgoV8eBombx8lBogA9m2fbumTxOJ+cjr9eIcEIqcbs5BdtQ4J9ofvUkJqikVIafKiJAylvsp1lC7fRwtKARr9x2DsYrNSDbIhWQcPPTccfySUKuWNTkdmpmJfWikQU/vONJYetdtOQtnIe4nntTD67WdEgGhHB5S1FYS+kV2k5JTHz3whl1rkY2epwks9Z0Ry9RXE0s4ZtOc+rCC7VMveSGjC9F7+15N+yEl27B2e6FFMAsEOqhm9IVfRx400c40DkGiZ4McW05o2PJolDDrY5rFfsjbN9dLqTvIsdQv71k+4ATAlNN//erDdAuPak+Oq7vu/tNu9sFf64ZcKcdj78CH5NaOjeHSDqdhZchKGR5hIF4IdjZuWrAej6IN3BZOqLxOhlUsawl15OgM02GnH6geYQ7rRilgZYuWqWnhfRla8OdNSYegImmyD1L59lN5d3kAt6qqxvFpsWqg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199015)(36840700001)(46966006)(40470700004)(81166007)(82740400003)(316002)(33656002)(40460700003)(40480700001)(478600001)(86362001)(356005)(2906002)(70586007)(8676002)(4326008)(54906003)(8936002)(5660300002)(41300700001)(110136005)(52536014)(70206006)(6506007)(82310400005)(36860700001)(83380400001)(9686003)(53546011)(7696005)(55016003)(26005)(186003)(336012)(66899015)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 09:07:57.2517
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 74998f9b-c30a-413b-45fb-08dab8c3e7c8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT021.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8739

SGkgSnVsaWVuIGFuZCBKYW4sDQoNClRoYW5rcyBmb3IgYmVpbmcgY2F1dGlvdXMgOikNCg0KPiAt
LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hA
c3VzZS5jb20+DQo+IFN1YmplY3Q6IFJlOiBGZWVkYmFjayBmb3IgcG9zdHBvbmluZyB0aGUgNC4x
NyByZWxlYXNlIHRvIGEgd2VlayBsYXRlcg0KPiANCj4gT24gMjguMTAuMjAyMiAxMDo1NywgSnVs
aWVuIEdyYWxsIHdyb3RlOg0KPiA+IE9uIDI4LzEwLzIwMjIgMDU6NDMsIEhlbnJ5IFdhbmcgd3Jv
dGU6DQo+ID4+IFNpbmNlIHRoZXJlIHdpbGwgYmUgYSBiYXRjaCBvZiBYU0FzIHJlbGVhc2VkIG9u
IE5vdi4gMSBbMV0gYW5kIHRoZSBvcmlnaW5hbA0KPiBkYXRlIGZvcg0KPiA+PiB0aGUgNC4xNyBy
ZWxlYXNlIHdhcyBzdXBwb3NlZCB0byBiZSBOb3YuIDIsIEkgYW0gdGhpbmtpbmcgdG8gcG9zdHBv
bmUgdGhlDQo+IDQuMTcNCj4gPj4gcmVsZWFzZSB0byBhIHdlZWsgbGF0ZXIgKE5vdi4gMTEpIHRv
IGdpdmUgYSBsaXR0bGUgYml0IGxvbmdlciB0aW1lIHNvIHRoYXQ6DQo+ID4+DQo+ID4+IC0gVGhl
IHNlY3VyaXR5IHRlYW0gd29uJ3QgZG8gYW55dGhpbmcgaW4gcnVzaC4NCj4gPj4gLSBXZSBjYW4g
aGF2ZSBtb3JlIGZlZWRiYWNrIGFmdGVyIG1lcmdpbmcgdGhlc2UgWFNBcy4NCj4gPj4gLSBJbmNs
dWRlIG1vcmUgcmVsZWFzZS1yZWxldmFudCBidWdmaXhlcy4NCj4gPj4NCj4gPj4gTWF5IEkgcGxl
YXNlIGhhdmUgc29tZSBmZWVkYmFjayBvbiB0aGlzIHByb3Bvc2FsPyBUaGFua3MgdmVyeSBtdWNo
IQ0KPiA+DQo+ID4gU29tZXdoYXQgcmVsYXRlZC4gV2hlbiBzaG91bGQgd2UgYnJhbmNoIGZvciB0
aGUgcmVsZWFzZSBhbmQgc2V0DQo+ID4gQ09ORklHX0RFQlVHPW4/DQo+ID4NCj4gPiBJIHRoaW5r
IHdlIHdvdWxkIGF0IGxlYXN0IG5lZWQgYSBSQyB3aXRoIENPTkZJR19ERUJVRz1uIGJ1dCBJSVVD
IHdlDQo+ID4gdXN1YWxseSBkbyBpdCBhdCBhIHBvaW50IHdoZXJlIHRoZSB0cmVlIGlzIG5lYXJs
eSBmcm96ZW4uDQo+ID4NCj4gPiBBRkFJQ1QsIHRoZXJlIGFyZSBzdGlsbCBhIGZldyB0aGluZ3Mg
aW4gZmxpZ2h0IChpbmNsdWRpbmcgZml4IGZvcg0KPiA+IFhTQS00MDkpLiBTbyBJIGFtIG5vdCBz
dXJlIHdlIGFyZSBpbiBwb3NpdGlvbiB5ZXQgdG8gYnJhbmNoLiBBbnkgb3BpbmlvbnM/DQo+IA0K
PiArMSB0byBpdCBiZWluZyB0b28gZWFybHkgdG8gYnJhbmNoLiBJIHdvdWxkIHN1Z2dlc3QgdGhh
dCB0aGUgWFNBIGJhdGNoDQo+IHNob3VsZCBoYXZlIGdvbmUgaW4gZmlyc3QgYW5kIHJlbGVhc2Ug
YmxvY2tlcnMgc2hvdWxkIGhhdmUgYmVlbiBkZWFsdA0KPiB3aXRoICh1bmxlc3MgZm9yIHNvbWUg
aXQgaXMgY2xlYXIgdGhhdCB0aGV5J3JlIGdvaW5nIHRvIGJlIHVuaW50cnVzaXZlKSwNCj4gdG8g
bGltaXQgd2hhdCBuZWVkcyBhcHBseWluZyB0byBzdGFnaW5nIGFuZCB0aGUgbmV3IGJyYW5jaC4N
Cg0KSSBhZ3JlZSwgdGhlcmVmb3JlIEkgdGhpbmsgd2UgY2FuIHN3aXRjaCB0byBDT05GSUdfREVC
VUc9biBpbiB0aGUgUkMNCm5leHQgd2VlayBhZnRlciB0aGUgTm92LiAxIFhTQXMuIFNvIHdlIGhh
dmUgYXQgbGVhc3QgYSB3ZWVrIGFmdGVyIHRoZSBSQzMuDQoNCkRvZXMgdGhpcyBzb3VuZCBvaz8N
Cg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFuDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 09:33:28 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 09:33:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431845.684458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLju-000062-5D; Fri, 28 Oct 2022 09:33:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431845.684458; Fri, 28 Oct 2022 09:33:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLju-00005v-2V; Fri, 28 Oct 2022 09:33:22 +0000
Received: by outflank-mailman (input) for mailman id 431845;
 Fri, 28 Oct 2022 09:33:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jtyv=25=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1ooLjs-00005p-9W
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 09:33:20 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 (mail-am7eur03on2075.outbound.protection.outlook.com [40.107.105.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8e7bb6bd-56a3-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 11:33:19 +0200 (CEST)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DB9PR04MB9331.eurprd04.prod.outlook.com (2603:10a6:10:36d::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 09:33:17 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022
 09:33:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e7bb6bd-56a3-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Jjw7B0UNGB0W1xzjMR7IFOB5o8KhgI4iG5V7M6NVBzUi1Pbl5K6xjMPA1n6GdFkT5IozLSvu2OOAUSP4eee4zAXaRi30Z2zQCv/dqSQdA4z0MsH1ws5Ghhv0wizmiOt7Zx0oEnBWdkPQd+3/nDyCPOLv5Gac+c3lyK4P9CaVR486YcxfO3NvIFMoQ0drnAcv/EAS5y8dEYqM6Pr+gQD6UafBpPAKxOfeu0o7AmlJEkN19/hLnM40joIyW47FSVEktWtQvBiuiBp9RbrIDI6pyqNCISiT12fi08gUTSAqqCT08S5q0HW4lZtc3Inl4OPg8LsKJtjZJUCJf0vyhmmBWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VQqwifjrRX2J6HNw2QwhDfDl/0nuZREDzWmJGvuyZM4=;
 b=gm7S4vGKZB+cCgUzEHiKEN/N1tuKClJdbtyRwtSWWxg9/PJAxZDAxXuncswcbUi55sy1qOFkbjXtWehS+W415zsRSVKL1Xhbbky0GXHUwEWvuPEzOcANPvfekH2bp4g3rJZGzHu1mvoeJBUE+NOEWsqT7jKu3OGvogzF0oT9DlExiFAaccWL+2u4psLo12wXy6ZHx9hqlGmKZ32OH2fJrlLrEaMRdNJxfuOhTaQOfQDcCtn/EgGdJYiEcmuDHvNIiM8QtmhFCRbjrwT4i1QxpLNEQseMGbtFppRr+Vtb9H6k4I54UiKq/nJRR53ioL2L58IsRxbie+lxv+I+8ZGfvQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VQqwifjrRX2J6HNw2QwhDfDl/0nuZREDzWmJGvuyZM4=;
 b=2EhK4R9Rf+rPtKCJBQkJC5odfnAwkIc47HxASCq+/kHHuipUTKEs6Yx9+x6TFe4OZrl1OytiBIn8BVDMZEq+9RkGibO/2Rs7jrrOMIZe5DfyfAYb+8Hz/kx812tVOBVKf2cGj6P10XgV4/ospYGwZnKTx1spdwRLDZJntixAR8EgVZ4avSOoGcmFWlJfbzmapfXE4xeMQoK3pGyCP7H78/2TKZbwcPOZ1SCcgv3bvtVoPpwi9RGN9JmNQ1OOu0rmPLAqr8pDt/ZZ9+tHr9fpebrvMPxQTkfVgKebaxtbA4haHXOyNJFcz4Rq9rw4dtSJ2TrZENHEq0ByTTpAC8vSGw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <19b1f3e0-6851-eacf-0efe-4d82293f29c4@suse.com>
Date: Fri, 28 Oct 2022 11:33:15 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare the
 underlying page
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Henry Wang <Henry.Wang@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <b2382fad-e328-fb03-2860-cca93625f4bb@suse.com>
 <Y1gD7GmclguLZCM8@Air-de-Roger>
 <b9c190ee-f916-b03d-e56f-0a54d93ba948@suse.com>
 <AS8PR08MB7991C7034FE22A68AE77A39A92309@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <77793987-d638-deaa-f3a5-4a9aba3d2a30@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <77793987-d638-deaa-f3a5-4a9aba3d2a30@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::23) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9331:EE_
X-MS-Office365-Filtering-Correlation-Id: 1a0a89e3-0d0f-4a07-bc26-08dab8c7716d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DbiMNpqmolbeXkrvuD7EbSBAY0ShtVFbZLv+l3b/EmbKQyIIaY4g0TrBSaBcwEDcju49dMTH8DhZggsKeNCX1rJCLP2H/W0w7tMS7OT6sGIykA9fZacuYwXvow7GAXeQfnUuvzOLWlz7/tnZ8wGoTfCPdyzS0zk3wJjoTnAi9sZn+gZ0oZ2aN8C2QT6rJIpSTdUHLkAWLoGEaYObMBVkrDi8mqith31I/cYv/5+JImg7oOOEQ9S052EM7ABTTIb14OaQSUKAaDMkpezvXtjs9TQmcOi8G7IgjGmL76FKStEp8QKG68CaCk2smZNtZyj3m1R/hHnpJhhi/IQnDCEWJmyMR2oLRUQZ8k/KwcCnTR1+9vXrtoTDHgeKhyrXNgtTa2199Fz7NhoevCtXz90oB0QPvY0MQUK0Z83Yiijc75WbEeH1Q0mD1IOiHpcSFFSkL9e5Hmalf5/mpejZfp3y/f41mFkTATlI8LZCHu/NwtiXdM2bQBN9DHAjUnSzfaVRC7anHFlPB/f+o/RAlvq7pScfFsivDxKa2YB8Cny6ekZNGlOWtJGPCIxVWDdAuOsBqROR+ZRKbHnwmQFA5r+/e95+MbmTtehflC/4wsiAbgu+phFE1P1t6AqdAUnHFvOdht15ctWqBHSNKtVg1aGHAJp0d06T7aQErqfxe4o3R3tv/q8SDdGJXFBYLA+vkYObvTGM6VCR/xM4pFlY23Az3UOGIoZoc0Y2w7+YLZPUaP7t/4Ye94WKiMoL8LelQBrZIZ2E6ciVLkO4lKl0el/uiknajo2fOeP4UP50S2gJSv4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(346002)(396003)(376002)(136003)(451199015)(2616005)(53546011)(6506007)(478600001)(26005)(6512007)(83380400001)(186003)(2906002)(316002)(54906003)(8676002)(110136005)(6486002)(8936002)(5660300002)(4326008)(66476007)(66556008)(66946007)(41300700001)(31696002)(86362001)(36756003)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c0RDWGwrR3lVbGs2TXc3QXJQeFhXVE5UNnJid2Z3YkZYSUl2cE1VdFYrOVJN?=
 =?utf-8?B?WHhwUXdPRE10U2drcU4zc0pQWVdNeUpjNWdqTHlJYWxHbjdBaDBWU3F6dzZV?=
 =?utf-8?B?U1BHcVlhaWt6eXI3Z3o3RmZUNjd0c0duWmxJcGNZNHdOUE11V0pxT3VLdWd0?=
 =?utf-8?B?cUJrNzZBek5IR1diNEVtdzlwVnNGOVdNdFRROHAyZnd1SElWaHVUSlk1dzN6?=
 =?utf-8?B?T3BQUWphZDB3QW14SUxhemE5by9YSTNKT0J3eDF4Z2NQNUh2dHJnUzJmVEw4?=
 =?utf-8?B?WjJvdGpMcGFVY2dWZlVHTFVOZnhyVU1hQUlhZVQ1MXU1ZHlVNlhMSXlTajc3?=
 =?utf-8?B?aXhGWERDUDM0MzUzdXZTd3NURyszbENySXJsOFQ3UDJNTk1OWlVITlVHYTht?=
 =?utf-8?B?VUxBRUF1eEVpYnYzOURmMlpHMHpob1U4TFdhcXdUUjN2Z2hZNUFsdUdhVEI5?=
 =?utf-8?B?c3lRaXFVWmJLTW9aRGt5bW9vTWhIWXlIcXRqSUU4NWZKbEIzdjI0czVZYTJs?=
 =?utf-8?B?KzAyQTByNlhQQTRYMjVUTkJDTnM4WDl5NzRtWFJ3S29SSG1kZGxpQTZRZDI1?=
 =?utf-8?B?L0hXSXBOWGFlUUNaYXAvNzZxN3JPR2FaRlNoYkxYU3NUOUo5NkNhNWdWYXlY?=
 =?utf-8?B?ampXc1h6TFZCOXJCcjJ1L2tlQ2FWZ0lGRVZRb2FiQzZLV2V6b3NvYzJOaDhs?=
 =?utf-8?B?bVUvSzF4RFhvZjNPRTVLTWMyMlRTTDUyOThxN1lxSVQ5N1prb1Q3US9CbERJ?=
 =?utf-8?B?L2wxakJaVEZyMVlUWWxpcDFzWldHTHdPUlp3ZFhsU0VkSlZTdnRwQnZueCtC?=
 =?utf-8?B?R2dMVnVWc1VGMHJVQm9tLzlhL1NWYWRPMXFneElwSThrUml3cVpTeHkwSnB2?=
 =?utf-8?B?ZWRhalVJc0dUTVByQk1GM28wREpndjBBYTMrMGM0VjVMYWdwQ3JKMVZNMER3?=
 =?utf-8?B?UnBvZmRVM2pBelRKYUFFTVphMjZocU5Tc1pmUnUzaDRNMzlyVkw2ekhkUFF3?=
 =?utf-8?B?WXd4SGVuN0k3dWtqSEFpU0svK1ZNelhpY2FhR3ZOQ1VqSTVXSWhsTkYrOEti?=
 =?utf-8?B?RkI3T24yR0pQL1AvU21Cb083dXFxZ01NMHc5QXJPQjlieGp5OTNMeEV6QzVO?=
 =?utf-8?B?VXAwTWdadU90M05yVVkwRCt3eXdBdnc2ZU44SGVweGdwTFQ3MzZFYXlxb2Rv?=
 =?utf-8?B?RHFQNWNOMzN4KzZRUktqSjBXWWUrMnlSUWFlM1duYnZzd1VOSWZhQ1lkb2Ri?=
 =?utf-8?B?NFhsaXcxWGI1WUNtd3ZseHYyNVFGUjNWQ0NHdGs5TXZteFRmeHpiRFZUTElC?=
 =?utf-8?B?c0FZTkNCNkIvT29YZ1lFYjR2ZUJzeWljcW5tbG4zUlpNdFM3RktzZjc2SHpW?=
 =?utf-8?B?SS94aE9tdTdYWW1BQXBxQUJGRlAxbG84SDUveWYwQ1gxZmZSZ012bklHSFcr?=
 =?utf-8?B?V1hpRDVZSzBvUWlzWXFHd1dDRnl6ejkyVUtHRzFyVWkwSEh5aWFRRkh6SHBs?=
 =?utf-8?B?NjZUelFtRU1nYS9kMjRLOXhaMGhTREFYWEVWbi9Ud3FxRXk3MVo0ZnprbG9F?=
 =?utf-8?B?NE1Nakt3K3owL08rRUVqZnE1QklGaXVET01VZ3pFU2xTcXVrTStHKzZwd3Rp?=
 =?utf-8?B?aWUxbnFVVmcrQmFUdDU1NTZlNnJ6bXEwREhpQmV6M1YwNENMbSsrdmtqYXoz?=
 =?utf-8?B?ek5YQWpsbENuU3dSK3hEWHoyTVFMR3hBR3BjL0dhckkwU3Z2bEgvejU2YnRu?=
 =?utf-8?B?SlQ5L1pJckJKbnF3cVVvb2ZOVFNSMER6RFRuOUJ2VFhQVEJtaHQ3c2kxSWVM?=
 =?utf-8?B?bUtveGZoejkzM213Y0JaUDVuTmpoMjdkS3RBV1pZdzFXSFpueWR0WlA3SWNs?=
 =?utf-8?B?bFJqTHM3eWZxNkFET3FRbGZmSUFzYXV0U2xOSGtuMVRCcEU5alJjbkFsd0g4?=
 =?utf-8?B?WjBhSnV3UmlYYTNuNHdxcjk3R1NjMzQvVFdFa2VnZnNiMGpBYXMzQjRvQ21R?=
 =?utf-8?B?M2ljaG9kdzdxOEprRkQvY0pjZXV2M2lLVGowc3RSWEtCNW8wL1dBOUVpY2tZ?=
 =?utf-8?B?c3NZNkRJRTY0MWp0V2dmY1Z0Rm80YzJJUTMxNGNMZ0VYUit0V3RKa2VjT1dO?=
 =?utf-8?Q?idrDRwZcIkixKVVmpP5edYb3J?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0a89e3-0d0f-4a07-bc26-08dab8c7716d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 09:33:16.8928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CXlRwtBOjb/HE55+7j36nN8sLJt0Q2p+A40WIY5TR8fmZ/KNtT7k5HdTgI4QyOj7eGGNo3c8rbgfhzdxl243GQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9331

On 27.10.2022 14:22, Julien Grall wrote:
> On 26/10/2022 03:03, Henry Wang wrote:
>>> -----Original Message-----
>>> From: Jan Beulich <jbeulich@suse.com>
>>> Sent: Wednesday, October 26, 2022 12:07 AM
>>> To: Henry Wang <Henry.Wang@arm.com>
>>> Cc: xen-devel@lists.xenproject.org; Andrew Cooper
>>> <andrew.cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>;
>>> Julien Grall <julien@xen.org>; Stefano Stabellini <sstabellini@kernel.org>;
>>> Wei Liu <wl@xen.org>; Roger Pau Monné <roger.pau@citrix.com>
>>> Subject: [4.17?] Re: [PATCH] common: map_vcpu_info() wants to unshare
>>> the underlying page
>>>
>>> On 25.10.2022 17:42, Roger Pau Monné wrote:
>>>> On Tue, Oct 11, 2022 at 10:48:38AM +0200, Jan Beulich wrote:
>>>>> Not passing P2M_UNSHARE to get_page_from_gfn() means there won't
>>> even be
>>>>> an attempt to unshare the referenced page, without any indication to the
>>>>> caller (e.g. -EAGAIN). Note that guests have no direct control over
>>>>> which of their pages are shared (or paged out), and hence they have no
>>>>> way to make sure all on their own that the subsequent obtaining of a
>>>>> writable type reference can actually succeed.
>>>>>
>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>>>
>>> I didn't Cc you on the initial submission because mem-sharing isn't a
>>> supported feature, but upon reconsideration I thought I'd at least ask
>>> whether you would want to give this a release-ack. I don't really see
>>> any risk associated with it.
>>
>> By looking at the patch itself, this change seems ok to me, so I think
>> I will not block it, but I think Arm maintainers' approval might be needed
>> because of the discussion in [1], so I added them for their information.
>> If Arm maintainers do not object the change, you can have my release-ack.

I'll take the liberty then to translate this into an actual tag, with ...

> The P2M query type is so far ignored on Arm as we neither support 
> populate-on-demand nor memsharing.
> 
> I am assuming that if we ever introduce any those of features, we would 
> follow the same behavior as x86. So:
> 
> Acked-by: Julien Grall <jgrall@amazon.com>

... this now in place (thanks Julien).

Jan


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 09:36:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 09:36:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431851.684469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLmz-0000yZ-JD; Fri, 28 Oct 2022 09:36:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431851.684469; Fri, 28 Oct 2022 09:36:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooLmz-0000yS-G6; Fri, 28 Oct 2022 09:36:33 +0000
Received: by outflank-mailman (input) for mailman id 431851;
 Fri, 28 Oct 2022 09:36:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ToJk=25=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ooLmx-0000yI-3p
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 09:36:31 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2083.outbound.protection.outlook.com [40.107.244.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe1a5e0a-56a3-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 11:36:27 +0200 (CEST)
Received: from BN9PR03CA0572.namprd03.prod.outlook.com (2603:10b6:408:10d::7)
 by CH2PR12MB4922.namprd12.prod.outlook.com (2603:10b6:610:65::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 28 Oct
 2022 09:36:24 +0000
Received: from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:10d:cafe::d7) by BN9PR03CA0572.outlook.office365.com
 (2603:10b6:408:10d::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend
 Transport; Fri, 28 Oct 2022 09:36:23 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 09:36:23 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 04:36:23 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 04:36:23 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Fri, 28 Oct 2022 04:36:22 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe1a5e0a-56a3-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YpE3cS477FHgdF4hAthAozkm/EbhDyOV4VSA7c85DOEL7KiFDBTkD6KS5+CQ8/MUFc/ye2pOP8GRiYnjiZCJDWWF6Ep2QFW3EJjO7072vPD+MggIm0IlWED357H83dBc9uQYHyNv7gR1wmeRzWBcFIVIc58iO0P6KNB1j759Pw0Hz8/VZOCK2hK5Mdu2kHoDc3EVEt5vqoO3Heb0l4ezUFkAg/K9jYSXxea3Qaww/zdl5aU43FBqoE2o9qymdPaSe27HLcv9PGeHTicQd58B1BZPk7cBq/vqDyIX7nrN83lJQx8BmWqHylRGfRWg2CEHPAs9ttkHltK4BEERlFO2Lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UFyMI16L8NG++G/MAxE4y4FnFfJTFapEsVSkvT3B5Rw=;
 b=FYaLd9AJWNYSlU4Xb28RiH5tCU/CMrIrfwDahLJHgzW/rDU6l47LoIp6srOlhiB36lPTr47rQ4oE5kRArvvRuUzJ7+FPZMTZQ70xNZN2lSew+iGnt/suk2tzL3Z0G1SusPMBiqDkxLv4nQRT0cOnOaTkUEJx4Gwuv60OlvbYaocL+O1VsC49m19L6S3pbvJPIQSTxhINOWjKyo4eWevfs3s5+Df/y4GnudtzgEJbCdjY6vg8CdykO2je6TdrFKyAzDBXbCXmZSRWt5ZxnysdGiad/W7NqOtpJiTjCNVwiMC0fv2HyzAvtDYnkCAyjV/0bIMMnWdChAFAHHDXgCgJBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UFyMI16L8NG++G/MAxE4y4FnFfJTFapEsVSkvT3B5Rw=;
 b=SPADtIgQS9WAyK5DxDnlWD2RoQhFMThsWBfyUptxSoikVI9R3yTrvq/DWT/dArT8/cS5bkkb1hqI8IDPLSZs3P9R3hx3iCcEdEj1EvuAPwtDCS1B3+OFk+Vyoskrww/pf8XjhZqjlRdBrXqKDb1PHzVa5FDr+k9ifMPcMP174PM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <6413650b-efc4-8feb-2e70-f54044cdb0ef@amd.com>
Date: Fri, 28 Oct 2022 11:36:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] xen/arm: Do not route NS phys timer IRQ to Xen
Content-Language: en-US
To: Julien Grall <julien@xen.org>, <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221028075630.32261-1-michal.orzel@amd.com>
 <ecd3e603-b1d1-210b-1212-3b9151f4bc3d@xen.org>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <ecd3e603-b1d1-210b-1212-3b9151f4bc3d@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT035:EE_|CH2PR12MB4922:EE_
X-MS-Office365-Filtering-Correlation-Id: e8fd77b3-9e71-4734-d7ed-08dab8c7e0d2
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BmtbOueOwK9JD3d/WM6rcgchYiufgIpjAxefJykiMZMQt533TFP7VgQVfpsLQQEm3jXjx3KkpKj0udM9Bp+Pgrs7JMiKP7sPcGihQY1/CqgL2c2pTIMnkroK03DfxVZfNGXwdv/EQTUQZewesnYNJzSbze7Kp2cI8YkEIW3g3jP6awdk4fAOuKxdN7GUL7tlzwEvIl2WN3LR5X6n/eYY+jeOjViP7zPUimugTqFoi9k6AlcatotUmOIB3qUTuL5OEKLz0L9v+pSmQMN5FwDsx1v8ola5mMXV6mPgDOd3qK4cPnW1Bt7lImK6rqAa9+CLX6oC+CCz2Jsm/p902jZjya3ine+3pgJfg/vHRez5eiScUnEsPRq41KYLkaedfyXAbTSAKw/ui5QWjL8n29KKcuxRD/auENjogzT5FPJpJcd+INCYW9JFX0nQJm1CuO64/jj+dz2Mfw63RuVDfym4nYg0itRR7+PYaTBGphCQ55s/6bV9XXdBiMP4c9uBU14+skqdycGtEbptWyDqYdiZteyRG2I6Gy8amlaodkETT8tE7X8VNqQkRtZyMMcS6Gd29l+FUZtRB2ODVG4HU4TotBu5mJyh/pTKtbE8Z4azqKK/tUNlA2V0rgfExcs4LW2OOWhgyiJd60xOGa9scQKfOZm03d/z99TyER33lK0EN1GOjTkLTPA3aSQ84PPzfw9LwoNzHgcxPN/vyrtZgAmOP2kUvloKZl3UT/3veDqjRIXKJ7fWEFr6EVmriTIeM2VyOy7hnwDOr0BcBrTUav18rqBAtMyOBWRMxeH1F3oUgI1EGSNCyrc4idGnqZL5a88WPSoE+sMWGeXs6EVqA6FnFPcokDUHM0H77DO+URpBTg4=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(46966006)(40470700004)(36840700001)(478600001)(966005)(31686004)(45080400002)(356005)(82740400003)(81166007)(110136005)(8936002)(54906003)(16576012)(316002)(86362001)(83380400001)(31696002)(41300700001)(8676002)(70206006)(426003)(70586007)(4326008)(26005)(47076005)(5660300002)(82310400005)(44832011)(40460700003)(2616005)(186003)(36860700001)(2906002)(53546011)(36756003)(336012)(40480700001)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 09:36:23.5950
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e8fd77b3-9e71-4734-d7ed-08dab8c7e0d2
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT035.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4922

Hi Julien,

On 28/10/2022 11:03, Julien Grall wrote:
> 
> 
> Hi Michal,
> 
> On 28/10/2022 08:56, Michal Orzel wrote:
>> At the moment, we route NS phys timer IRQ to Xen even though it does not
>> make use of this timer. Xen uses hypervisor timer for itself and the
>> physical timer is fully emulated, hence there is nothing that can trigger
>> such IRQ. This means that requesting/releasing IRQ ends up as a deadcode
>> as it has no impact on the functional behavior, whereas the code within
>> a handler ends up being unreachable. This is a left over from the early
>> days when the CNTHP IRQ was buggy on the HW model used for testing and we
>> had to use the CNTP instead.
>>
>> Remove the calls to {request/release}_irq for this timer as well as the
>> code within the handler. Since timer_interrupt handler is now only used
>> by the CNTHP, remove the IRQ affiliation condition. Keep the calls to
>> zero the CNTP_CTL_EL0 register on timer init/deinit for sanity and also remove
>> the corresponding perf counter definition.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>> ---
>> Based on the outcome of the following discussion:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fxen-devel%2Fd55938a3-aaca-1d01-b34f-858dbca9830b%40amd.com%2F&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C4df8dc89b3124eb8f51608dab8c35ab3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638025446431622763%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=qeZR%2BBvOwKA9PKjq2xemSXhJ1Xij%2F%2FMWKADD70vrwW0%3D&amp;reserved=0
>> ---
>>   xen/arch/arm/include/asm/perfc_defn.h |  1 -
>>   xen/arch/arm/time.c                   | 16 +---------------
>>   2 files changed, 1 insertion(+), 16 deletions(-)
>>
>> diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h
>> index 31f071222b24..3ab0391175d7 100644
>> --- a/xen/arch/arm/include/asm/perfc_defn.h
>> +++ b/xen/arch/arm/include/asm/perfc_defn.h
>> @@ -70,7 +70,6 @@ PERFCOUNTER(spis,                 "#SPIs")
>>   PERFCOUNTER(guest_irqs,           "#GUEST-IRQS")
>>
>>   PERFCOUNTER(hyp_timer_irqs,   "Hypervisor timer interrupts")
>> -PERFCOUNTER(phys_timer_irqs,  "Physical timer interrupts")
>>   PERFCOUNTER(virt_timer_irqs,  "Virtual timer interrupts")
>>   PERFCOUNTER(maintenance_irqs, "Maintenance interrupts")
>>
>> diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
>> index dec53b5f7d53..3160fcc7b440 100644
>> --- a/xen/arch/arm/time.c
>> +++ b/xen/arch/arm/time.c
>> @@ -222,8 +222,7 @@ int reprogram_timer(s_time_t timeout)
>>   /* Handle the firing timer */
>>   static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
>>   {
>> -    if ( irq == (timer_irq[TIMER_HYP_PPI]) &&
>> -         READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
>> +    if ( READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
> 
> AFAICT, this condition is meant to be true most of the times. So as you
> are modifying the code, could you take the opportunity to add a
> "likely()"? Or better invert the condition so the code below is not
> indented.

Sure thing. I can take the opportunity to do the following:
if ( unlikely(!(READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING)) )
    return;

Also, shouldn't we reflect the purpose of this handler by renaming it
from timer_interrupt to htimer_interrupt (or hyp_timer_interrupt) to be consistent
with the naming (i.e. vtimer_interrupt -> virtual, timer_interrupt -> quite ambiguous given the usage)?

> 
> Cheers,
> 
> --
> Julien Grall

~Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 09:54:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 09:54:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431860.684492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooM48-0003md-8Z; Fri, 28 Oct 2022 09:54:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431860.684492; Fri, 28 Oct 2022 09:54:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooM48-0003mW-5w; Fri, 28 Oct 2022 09:54:16 +0000
Received: by outflank-mailman (input) for mailman id 431860;
 Fri, 28 Oct 2022 09:54:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3R+4=25=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1ooM47-0003mQ-Dn
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 09:54:15 +0000
Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com
 [2607:f8b0:4864:20::535])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 79b0f72c-56a6-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 11:54:13 +0200 (CEST)
Received: by mail-pg1-x535.google.com with SMTP id f193so4442514pgc.0
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 02:54:13 -0700 (PDT)
Received: from leoy-huanghe.lan (45.78.19.212.16clouds.com. [45.78.19.212])
 by smtp.gmail.com with ESMTPSA id
 q5-20020a170902bd8500b00186c3af9644sm2590315pls.273.2022.10.28.02.54.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 28 Oct 2022 02:54:10 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79b0f72c-56a6-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=wDdEpU7/bUqib1nFdmfTyZtogRI3Oc+HnuFFSmIhnSk=;
        b=Voc8SFUhEtioAI/OIZeqrsZ8TYqvxlE+UYZJc+Tu2mZbEuqUJkg6euakDDebGed7kq
         JV8NG6vK1EUTte9HBXKJ/zZ/Nhauf6vbtRxjGkRt71ytSsNTh0sUf6qPAsDrRoU/6a4l
         Di31IX5HmEevLMiqdSAyi4mMjlc5rlXYO/HsJtXQOqimIpb7BbYuftOsgj6kvM/IW1qN
         CH7J5C4obIX0nopBwlW2TLh5EOB9U3nEmUF4cj/qoUB6ogKojFLXPLBE7s/wMo6XRA8G
         YRlh+pp0+Q7z+nfjIym0TIjzDPR8XOaJO2uHdgQS0x//1kIZxkzquJfvv17TkB9zEy7W
         CTTg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=wDdEpU7/bUqib1nFdmfTyZtogRI3Oc+HnuFFSmIhnSk=;
        b=VScikgf3cLthjFHdHS5k2fjNjVv+xWyXWKc7rNXPbVdUnbKl4oecQo0TSDqHEQN4PZ
         +neubLrii8xYkqFym+7BzJjwkkp68zyFHfYvMgpQCwJmcO3jB61HGd4KXeDssj8qOadY
         MDzA6KNkr86hIqqnIKodhWkE5vgN5ydu4d2HDWzbiZUKqHmNMTIHDO+udb29pQTWJMTa
         KSMXSB9EX3csSlKNXqbezmZEFGFezmVtPwcCb8udMDF7fCGr3+swiHe48HL/Nkg0igBB
         CxK8F3mLuXP5+hSq/Ggo4CqtJDKgdzSfGqMdnLIo2eWPRofm2i7EiczrgDiTy1YQEor5
         yJJQ==
X-Gm-Message-State: ACrzQf2Zig4hV+0+zxxbMUWzxRiKYv+/xt4ZxfqqUV2jE9KFZ/NMvHCB
	iyX3XtvTP4RxeQ2k90mB/eiMzg==
X-Google-Smtp-Source: AMsMyM7X1wiVk6REf1jNOZc2PWy1jV4/3REP4zhQQBTp3JodVkcN763V1yYcFN3Zjxkn/bKXlOFbxQ==
X-Received: by 2002:a63:4507:0:b0:43c:9cf4:f1d6 with SMTP id s7-20020a634507000000b0043c9cf4f1d6mr47433689pga.316.1666950851599;
        Fri, 28 Oct 2022 02:54:11 -0700 (PDT)
Date: Fri, 28 Oct 2022 17:54:05 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y1umvVrGLktIvJuk@leoy-huanghe.lan>
References: <Y0QMQuAUKKSgrAAV@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
 <Y1J39UsPlM8htxFx@leoy-huanghe.lan>
 <alpine.DEB.2.22.394.2210211341440.3873@ubuntu-linux-20-04-desktop>
 <Y1ZvDt7/I9JXJh2r@leoy-huanghe.lan>
 <alpine.DEB.2.22.394.2210251655420.1397955@ubuntu-linux-20-04-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2210251655420.1397955@ubuntu-linux-20-04-desktop>

Hi Stefano,

On Tue, Oct 25, 2022 at 04:58:16PM -0700, Stefano Stabellini wrote:
> On Mon, 24 Oct 2022, Leo Yan wrote:
> > > If you are really running with the NULL scheduler, then I would
> > > investigate why the vCPU has is_running == 0 because it should not
> > > happen.
> > 
> > Correct for this: it's my bad that I didn't really enable NULL scheduler
> > in my code base.  After I enabled NULL scheduler, the latency by context
> > switching is dismissed.
> > 
> >  8963              pub-338   [002]   217.777652: bprint:               xennet_tx_setup_grant: id=60 ref=1340 offset=2 len=1514 TSC: 7892178799
> >  8964              pub-338   [002]   217.777662: bprint:               xennet_tx_setup_grant: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179043
> >  8965     ksoftirqd/12-75    [012]   255.466914: bprint:               xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2 len=1514 TSC: 7892179731
> >  8966     ksoftirqd/12-75    [012]   255.466915: bprint:               xenvif_tx_build_gops.constprop.0: id=82 ref=1362 offset=2050 len=1006 TSC: 7892179761
> >  8967              pub-338   [002]   217.778057: bprint:               xennet_tx_setup_grant: id=60 ref=1340 offset=2050 len=1514 TSC: 7892188930
> >  8968              pub-338   [002]   217.778072: bprint:               xennet_tx_setup_grant: id=53 ref=1333 offset=2 len=1514 TSC: 7892189293
> >  8969       containerd-2965  [012]   255.467304: bprint:               xenvif_tx_build_gops.constprop.0: id=60 ref=1340 offset=2050 len=1514 TSC: 7892189479
> >  8970       containerd-2965  [012]   255.467306: bprint:               xenvif_tx_build_gops.constprop.0: id=53 ref=1333 offset=2 len=1514 TSC: 7892189533
> 
> I am having difficulty following the messages. Are the two points [a]
> and [b] as described in the previous email shown here?

No, the [b] point is about the trace point in Xen hypvervisor.  

For easier review I combined the trace log from Xen dom0 and dom0
Linux kernels, in above log, the function xennet_tx_setup_grant() is
traced from domU Linux kernel and the function
xenvif_tx_build_gops.constprop.0 from dom0 Linux kernel and I sorted
the logs with TSC (Arm arch timer physical counter).

Sorry for confusion and I didn't explain clearly.

> > So the xennet (Xen net forend driver) and xenvif (net backend driver)
> > work in parallel.  Please note, I didn't see networking performance
> > improvement after changed to use NULL scheduler.
> > 
> > Now I will compare the duration for two directions, one direction is
> > sending data from xennet to xenvif, and another is the reversed
> > direction.  It's very likely the two directions have significant
> > difference for sending data with grant tables, you could see in above
> > log, it takes 20~30us to transmit a data block (we can use the id
> > number and grant table's ref number to match the data block in xennet
> > driver and xenvif driver).
> > 
> > > Now regarding the results, I can see the timestamp 3842008681 for
> > > xennet_notify_tx_irq, 3842008885 for vgic_inject_irq, and 3842008935 for
> > > vcpu_kick. Where is the corresponding TSC for the domain receiving the
> > > notification?
> > > 
> > > Also for the other case, starting at 3842016505, can you please
> > > highlight the timestamp for vgic_inject_irq, vcpu_kick, and also the one
> > > for the domain receiving the notification?
> > > 
> > > The most interesting timestamps would be the timestamp for vcpu_kick in
> > > "notification sending domain" [a], the timestamp for receiving the
> > > interrupt in the Xen on pCPU for the "notification receiving domain"
> > > [b], and the timestamp for the "notification receiving domain" getting
> > > the notification [c].
> > > 
> > > If really context switch is the issue, then the interesting latency
> > > would be between [a] and [b].
> > 
> > Understand.  I agree that I didn't move into more details, the main
> > reason is Xen dmesg buffer is fragile after adding more logs, e.g.
> > after I added log in the function gicv3_send_sgi(), Xen will stuck
> > during the booting phase, and after adding logs in
> > leave_hypervisor_to_guest() it will introduce huge logs (so I need to
> > only trace for first 16 CPUs to mitigate log flood).
> > 
> > I think it would be better to enable xentrace for my profiling at my
> > side.  If I have any further data, will share back.
> 
> Looking forward to it. Without more details it is impossible to identify
> the source of the problem and fix it.

The application passes data to Linux kernel and low level driver needs
to transfer skbs between Xen network frontend and backend drivers via
Xen shared ring buffer / grant table.  So let's step back to review
the duration in the network drivers for sending and receiving skbs.

I measured intervals for sending skbs, one direction is for sending skb
from dom0 to domU and another direction is from domU to dom0. For easier
review, I plotted the intervals in diagrams [1][2] for these two
directions respectively.

In a diagram it has three metrics:

- Packet sending interval: measures the interval from the sender.

  For the direction from dom0 to domu, this metric measures the
  interval for sending skbs in the Xen backend driver in dom0.

  For the direction from domU to dom0, this metric measures the
  interval for sending skbs in the Xen frontend driver in domU.

- Packet receiving interval: measures the interval for the receiver.

  For the direction from dom0 to domu, this metric measures the
  interval for receiving skbs in the Xen frontend driver in domU.

  For the direction from domU to dom0, this metric measures the
  interval for receiving skbs in the Xen backend driver in dom0.

- Packet response interval: measures the interval between sender and
  receiver.

  This interval measures the duration between a skb is sending out
  from the sender and until it's fetched from grant table by the
  receiver.

>From these three metrics we can know the latency is caused by three
actors: sender, receiver, Xen hypervisor.

In two diagrams we can see the packet response interval (yellow line)
is about 10~20us.  The response interval for domu -> dom0 (~10us) is
even better than the interval for dom0 -> domu (15~20us), which means
the response time is not the curplit for the poor performance when
sending data from domu to dom0.

The purple line and blue line for sending and receiving intervals are
correlated, this means the drivers in two sides (dom0 and domU) work in
parallel.

A big difference is we can see the sending interval (purple line) in the
diagram xmit_interval_dom0_to_domu.png usually keeps at ~1us, but the
sending interval in the diagram xmit_interval_domu_to_dom0.png is
about 10us.

If map to the code, I think the function xennet_start_xmit() in Xen
frontend driver is critical for the sending interval in domU.  I can
see several things cost time when sending a packet:

- Xen frontend driver needs to setup grant table for every skb, it
  invokes the function xennet_tx_setup_grant() and
  gnttab_grant_foreign_access_ref() to prepare grant table;

- Xen frontend driver sends notification by calling
  notify_remote_via_irq().  It will trap to Xen hypervisor to send the
  interrupt, this takes several macro seonds for this step.

- Xen frontend driver calls xennet_tx_buf_gc(), the interval for this
  function is vary, it will take ~30us in the case for reclaiming grant
  table.

Any thoughts for this?

Thanks,
Leo

[1] https://people.linaro.org/~leo.yan/xen/xmit_interval_dom0_to_domu.png
[2] https://people.linaro.org/~leo.yan/xen/xmit_interval_domu_to_dom0.png

P.s. I will take other priority tasks from next week, it's pity that I
cannot fix the issue at this point.  Just want you know I will take this
task as low priority, but if you have any idea I can give a try or
test at my side.


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:05:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:05:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431866.684503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMEh-0005qv-B2; Fri, 28 Oct 2022 10:05:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431866.684503; Fri, 28 Oct 2022 10:05:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMEh-0005qo-8C; Fri, 28 Oct 2022 10:05:11 +0000
Received: by outflank-mailman (input) for mailman id 431866;
 Fri, 28 Oct 2022 10:05:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooMEf-0005iU-T0
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 10:05:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooMEf-00009X-H6; Fri, 28 Oct 2022 10:05:09 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooMEf-00060m-9M; Fri, 28 Oct 2022 10:05:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=02pRaLyPA6dmfIsjtU3K2Er7tP/eKbqk+HYFT8z0DDw=; b=xRtokPDI38DKxz0f3G0Oo5UKX8
	XOVVhegJAfKD8KrUt9LLRQNiDHt3bV19EsAzDTJz213HDqpcpCYvqOItWxQg+2lVueB94pFpWvQ8l
	MCqzl7ZWZ8irkOGoix5P7hwA2FXcAo/Ra2O/0XknrTZ4OKrlXggoH0XkXr8hYSKX9kNc=;
Message-ID: <b5640fc8-50b4-1153-0730-61c6a751f851@xen.org>
Date: Fri, 28 Oct 2022 11:05:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH] xen/arm: Do not route NS phys timer IRQ to Xen
Content-Language: en-US
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20221028075630.32261-1-michal.orzel@amd.com>
 <ecd3e603-b1d1-210b-1212-3b9151f4bc3d@xen.org>
 <6413650b-efc4-8feb-2e70-f54044cdb0ef@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6413650b-efc4-8feb-2e70-f54044cdb0ef@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 28/10/2022 10:36, Michal Orzel wrote:
> Hi Julien,
> 
> On 28/10/2022 11:03, Julien Grall wrote:
>>
>>
>> Hi Michal,
>>
>> On 28/10/2022 08:56, Michal Orzel wrote:
>>> At the moment, we route NS phys timer IRQ to Xen even though it does not
>>> make use of this timer. Xen uses hypervisor timer for itself and the
>>> physical timer is fully emulated, hence there is nothing that can trigger
>>> such IRQ. This means that requesting/releasing IRQ ends up as a deadcode
>>> as it has no impact on the functional behavior, whereas the code within
>>> a handler ends up being unreachable. This is a left over from the early
>>> days when the CNTHP IRQ was buggy on the HW model used for testing and we
>>> had to use the CNTP instead.
>>>
>>> Remove the calls to {request/release}_irq for this timer as well as the
>>> code within the handler. Since timer_interrupt handler is now only used
>>> by the CNTHP, remove the IRQ affiliation condition. Keep the calls to
>>> zero the CNTP_CTL_EL0 register on timer init/deinit for sanity and also remove
>>> the corresponding perf counter definition.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
>>> ---
>>> Based on the outcome of the following discussion:
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fxen-devel%2Fd55938a3-aaca-1d01-b34f-858dbca9830b%40amd.com%2F&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C4df8dc89b3124eb8f51608dab8c35ab3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638025446431622763%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=qeZR%2BBvOwKA9PKjq2xemSXhJ1Xij%2F%2FMWKADD70vrwW0%3D&amp;reserved=0
>>> ---
>>>    xen/arch/arm/include/asm/perfc_defn.h |  1 -
>>>    xen/arch/arm/time.c                   | 16 +---------------
>>>    2 files changed, 1 insertion(+), 16 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h
>>> index 31f071222b24..3ab0391175d7 100644
>>> --- a/xen/arch/arm/include/asm/perfc_defn.h
>>> +++ b/xen/arch/arm/include/asm/perfc_defn.h
>>> @@ -70,7 +70,6 @@ PERFCOUNTER(spis,                 "#SPIs")
>>>    PERFCOUNTER(guest_irqs,           "#GUEST-IRQS")
>>>
>>>    PERFCOUNTER(hyp_timer_irqs,   "Hypervisor timer interrupts")
>>> -PERFCOUNTER(phys_timer_irqs,  "Physical timer interrupts")
>>>    PERFCOUNTER(virt_timer_irqs,  "Virtual timer interrupts")
>>>    PERFCOUNTER(maintenance_irqs, "Maintenance interrupts")
>>>
>>> diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
>>> index dec53b5f7d53..3160fcc7b440 100644
>>> --- a/xen/arch/arm/time.c
>>> +++ b/xen/arch/arm/time.c
>>> @@ -222,8 +222,7 @@ int reprogram_timer(s_time_t timeout)
>>>    /* Handle the firing timer */
>>>    static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
>>>    {
>>> -    if ( irq == (timer_irq[TIMER_HYP_PPI]) &&
>>> -         READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
>>> +    if ( READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
>>
>> AFAICT, this condition is meant to be true most of the times. So as you
>> are modifying the code, could you take the opportunity to add a
>> "likely()"? Or better invert the condition so the code below is not
>> indented.
> 
> Sure thing. I can take the opportunity to do the following:
> if ( unlikely(!(READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING)) )
>      return;
> 
> Also, shouldn't we reflect the purpose of this handler by renaming it
> from timer_interrupt to htimer_interrupt (or hyp_timer_interrupt) to be consistent
> with the naming (i.e. vtimer_interrupt -> virtual, timer_interrupt -> quite ambiguous given the usage)?

I am fine with that.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:08:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:08:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431872.684513 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMID-0006Yi-Ps; Fri, 28 Oct 2022 10:08:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431872.684513; Fri, 28 Oct 2022 10:08:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMID-0006Yb-N5; Fri, 28 Oct 2022 10:08:49 +0000
Received: by outflank-mailman (input) for mailman id 431872;
 Fri, 28 Oct 2022 10:08:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mkji=25=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ooMIB-0006YV-Qw
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 10:08:47 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 82626845-56a8-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 12:08:46 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BBB6F1F86B;
 Fri, 28 Oct 2022 10:08:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E79213A6E;
 Fri, 28 Oct 2022 10:08:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uJRKHS2qW2NiMAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 28 Oct 2022 10:08:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82626845-56a8-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666951725; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TnU+iYoPyoglay09VhRXgr5yQMxV8rttNsD3ycEHKug=;
	b=knfrsSVwOTS0meNdLoPwZ5FET3VH4F2+dmPsB0HSCCVbrvrxFtL+Vt7POXmnTzRZJxv3Sb
	vLXtZyALeePnfWNJTSzg/Xt/Pt/po5b7J7j9G8lEbGhkWt7urVYTSCEBxbo3dl6rv6xs4o
	zvHgAgq58dwb4sooEss2ugZwkeUkKa4=
Message-ID: <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
Date: Fri, 28 Oct 2022 12:08:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
 Henry Wang <Henry.Wang@arm.com>
References: <20221021145357.17931-1-jgross@suse.com>
 <Y1rKLJP/p+E+eVi7@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
In-Reply-To: <Y1rKLJP/p+E+eVi7@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------YlT41rAiS2D0e9gsCYcK3gDh"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------YlT41rAiS2D0e9gsCYcK3gDh
Content-Type: multipart/mixed; boundary="------------FL8GGzN6KMP3dgOgxr1IjBUU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>
Cc: xen-devel@lists.xenproject.org, George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
 Henry Wang <Henry.Wang@arm.com>
Message-ID: <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
References: <20221021145357.17931-1-jgross@suse.com>
 <Y1rKLJP/p+E+eVi7@mail-itl>
In-Reply-To: <Y1rKLJP/p+E+eVi7@mail-itl>

--------------FL8GGzN6KMP3dgOgxr1IjBUU
Content-Type: multipart/mixed; boundary="------------7vefNumKYJnunoQLa1wCcNQz"

--------------7vefNumKYJnunoQLa1wCcNQz
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjcuMTAuMjIgMjA6MTMsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gRnJpLCBPY3QgMjEsIDIwMjIgYXQgMDQ6NTM6NTdQTSArMDIwMCwgSnVlcmdlbiBH
cm9zcyB3cm90ZToNCj4+IFRvZGF5IGFsbCB0aW1lcnMgYXJlIG1pZ3JhdGVkIHRvIGNwdSAw
IHdoZW4gdGhlIHN5c3RlbSBpcyBiZWluZw0KPj4gc3VzcGVuZGVkLiBUaGV5IGFyZSBub3Qg
bWlncmF0ZWQgYmFjayBhZnRlciByZXN1bWluZyB0aGUgc3lzdGVtIGFnYWluLg0KPj4NCj4+
IFRoaXMgcmVzdWx0cyAoYXQgbGVhc3QpIHRvIHByb2JsZW1zIHdpdGggdGhlIGNyZWRpdCBz
Y2hlZHVsZXIsIGFzIHRoZQ0KPj4gdGltZXIgaXNuJ3QgaGFuZGxlZCBvbiB0aGUgY3B1IGl0
IHdhcyBleHBlY3RlZCB0byBvY2N1ci4NCj4+DQo+PiBBZGQgbWlncmF0aW5nIHRoZSBzY2hl
ZHVsaW5nIHJlbGF0ZWQgdGltZXJzIG9mIGEgc3BlY2lmaWMgY3B1IGZyb20gY3B1DQo+PiAw
IGJhY2sgdG8gaXRzIG9yaWdpbmFsIGNwdSB3aGVuIHRoYXQgY3B1IGhhcyBnb25lIHVwIHdo
ZW4gcmVzdW1pbmcgdGhlDQo+PiBzeXN0ZW0uDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVl
cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gSSB0ZXN0ZWQgaXQgaW4gbXkg
c2V0dXAsIGJ1dCBpdCBjcmFzaGVkOg0KPiANCj4gKFhFTikgYXJjaC94ODYvY3B1L21jaGVj
ay9tY2VfaW50ZWwuYzo3NzA6IE1DQSBDYXBhYmlsaXR5OiBmaXJzdGJhbmsgMCwgZXh0ZW5k
ZWQgTUNFIE1TUiAwLCBCQ0FTVCwgQ01DSQ0KPiAoWEVOKSBDUFUwIENNQ0kgTFZUIHZlY3Rv
ciAoMHhmMSkgYWxyZWFkeSBpbnN0YWxsZWQNCj4gKFhFTikgRmluaXNoaW5nIHdha2V1cCBm
cm9tIEFDUEkgUzMgc3RhdGUuDQo+IChYRU4pIEVuYWJsaW5nIG5vbi1ib290IENQVXMgIC4u
Lg0KPiAoWEVOKSBQbGF0Zm9ybSB0aW1lciBhcHBlYXJzIHRvIGhhdmUgdW5leHBlY3RlZGx5
IHdyYXBwZWQgMyB0aW1lcy4NCj4gKFhFTikgLS0tLVsgWGVuLTQuMTctcmMgIHg4Nl82NCAg
ZGVidWc9eSAgVGFpbnRlZDogICBDICAgIF0tLS0tDQo+IChYRU4pIENQVTogICAgMA0KPiAo
WEVOKSBSSVA6ICAgIGUwMDg6WzxmZmZmODJkMDQwMjUwYzdlPl0gc2NoZWRfbWlncmF0ZV90
aW1lcnMrMHg0ZC8weGM5DQo+IChYRU4pIFJGTEFHUzogMDAwMDAwMDAwMDAxMDIwMiAgIENP
TlRFWFQ6IGh5cGVydmlzb3INCj4gKFhFTikgcmF4OiBmZmZmODJkMDQwNWM1Mjk4ICAgcmJ4
OiAwMDAwMDAwMDAwMDAwMDAwICAgcmN4OiAwMDAwMDAwMDAwMDAwMDAxDQo+IChYRU4pIHJk
eDogMDAwMDAwMzIxMTIxOTAwMCAgIHJzaTogMDAwMDAwMDAwMDAwMDAwNCAgIHJkaTogMDAw
MDAwMDAwMDAwMDAwMQ0KPiAoWEVOKSByYnA6IGZmZmY4MzAyNTYyMjdkMjAgICByc3A6IGZm
ZmY4MzAyNTYyMjdkMTggICByODogIGZmZmY4MmQwNDA1ZDJmNzgNCj4gKFhFTikgcjk6ICBm
ZmZmODJkMDQwNWVmOGEwICAgcjEwOiAwMDAwMDAwMGZmZmZmZmZmICAgcjExOiAwMDAwMDAw
MDAwMjE5MWMwDQo+IChYRU4pIHIxMjogMDAwMDAwMDAwMDAwMDAwMCAgIHIxMzogMDAwMDAw
MDAwMDAwMDAwMSAgIHIxNDogMDAwMDAwMDAwMDAwMDAwNA0KPiAoWEVOKSByMTU6IDAwMDAw
MDAwMDAwMDAwMDAgICBjcjA6IDAwMDAwMDAwODAwNTAwM2IgICBjcjQ6IDAwMDAwMDAwMDAz
NTI2ZTANCj4gKFhFTikgY3IzOiAwMDAwMDAwMDQ5Njc3MDAwICAgY3IyOiAwMDAwMDAwMDAw
MDAwMDcwDQo+IChYRU4pIGZzYjogMDAwMDAwMDAwMDAwMDAwMCAgIGdzYjogMDAwMDAwMDAw
MDAwMDAwMCAgIGdzczogMDAwMDAwMDAwMDAwMDAwMA0KPiAoWEVOKSBkczogMDAwMCAgIGVz
OiAwMDAwICAgZnM6IDAwMDAgICBnczogMDAwMCAgIHNzOiAwMDAwICAgY3M6IGUwMDgNCj4g
KFhFTikgWGVuIGNvZGUgYXJvdW5kIDxmZmZmODJkMDQwMjUwYzdlPiAoc2NoZWRfbWlncmF0
ZV90aW1lcnMrMHg0ZC8weGM5KToNCj4gKFhFTikgIDQ4IDhiIDE0IGNhIDQ4IDhiIDFjIDAy
IDwzOT4gN2IgNzAgNzQgNTEgNDggOGQgMDUgNTYgMzQgMzcgMDAgNDggODkgZTIgNDgNCj4g
KFhFTikgWGVuIHN0YWNrIHRyYWNlIGZyb20gcnNwPWZmZmY4MzAyNTYyMjdkMTg6DQo+IChY
RU4pICAgIDAwMDAwMDAwMDAwMDAwMDEgZmZmZjgzMDI1NjIyN2Q1OCBmZmZmODJkMDQwMjNm
MWEwIGZmZmY4MmQwNDA0N2EzMDgNCj4gKFhFTikgICAgZmZmZjgyZDA0MDQ3YTMwMCBmZmZm
ODJkMDQwNDdhMDYwIDAwMDAwMDAwMDAwMDAwMDQgMDAwMDAwMDAwMDAwMDAwMA0KPiAoWEVO
KSAgICBmZmZmODMwMjU2MjI3ZGEwIGZmZmY4MmQwNDAyMjZhMDQgMDAwMDAwMDAwMDAwMDAw
MCAwMDAwMDAwMDAwMDAwMDAxDQo+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDEgMDAwMDAw
MDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAxIGZmZmY4MzAyNTYyMjdmZmYNCj4gKFhFTikg
ICAgZmZmZjgyZDA0MDQ2YzUyMCBmZmZmODMwMjU2MjI3ZGI4IGZmZmY4MmQwNDAyMDdlNzUg
MDAwMDAwMDAwMDAwMDAwMQ0KPiAoWEVOKSAgICBmZmZmODMwMjU2MjI3ZGUwIGZmZmY4MmQw
NDAyMDgyNDMgZmZmZjgyZDA0MDQ3YTIyMCAwMDAwMDAwMDAwMDAwMDAxDQo+IChYRU4pICAg
IDAwMDAwMDAwMDAwMDAwMTAgZmZmZjgzMDI1NjIyN2UxOCBmZmZmODJkMDQwMjA4NDI4IDAw
MDAwMDAwMDAwMDAyMDANCj4gKFhFTikgICAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAw
MDAwMDAzIGZmZmY4MzAyNTYyMjdlZjggZmZmZjgyZDA0MDVkZTZjMA0KPiAoWEVOKSAgICBm
ZmZmODMwMjU2MjI3ZTQ4IGZmZmY4MmQwNDAyN2EyZGYgZmZmZjgzMDI1MTQ5MTQ5MCBmZmZm
ODMwMjUxNzU3MDAwDQo+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAw
MDAwMCBmZmZmODMwMjU2MjI3ZTY4IGZmZmY4MmQwNDAyMDljNzMNCj4gKFhFTikgICAgZmZm
ZjgzMDI1MTc1NzFiOCBmZmZmODJkMDQwNDc5NjE4IGZmZmY4MzAyNTYyMjdlODggZmZmZjgy
ZDA0MDIyZTQ4NA0KPiAoWEVOKSAgICBmZmZmODJkMDQwNWM0MWEwIGZmZmY4MmQwNDA1YzQx
YjAgZmZmZjgzMDI1NjIyN2ViOCBmZmZmODJkMDQwMjJlNzZlDQo+IChYRU4pICAgIDAwMDAw
MDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAwN2ZmZiBmZmZmODJkMDQwNWNhZjAwIGZmZmY4MmQw
NDA1YzQxYjANCj4gKFhFTikgICAgZmZmZjgzMDI1NjIyN2VmMCBmZmZmODJkMDQwMmY0NTVk
IGZmZmY4MmQwNDAyZjQ0ZTUgZmZmZjgzMDI1MTc1NzAwMA0KPiAoWEVOKSAgICBmZmZmODMw
MjU2MjI3ZWY4IGZmZmY4MzAyNTE3ZjUwMDAgMDAwMDAwMDAwMDAwMDAwMCBmZmZmODMwMjU2
MjI3ZTE4DQo+IChYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDAgZmZmZmM5MDA0MGI0M2Q2MCAw
MDAwMDAwMDAwMDAzNDAzIDAwMDAwMDAwMDAwMDAwMDANCj4gKFhFTikgICAgMDAwMDAwMDAw
MDAwMDAwMyBmZmZmZmZmZjgyZTM3ODY4IDAwMDAwMDAwMDAwMDAyNDYgMDAwMDAwMDAwMDAw
MDAwMw0KPiAoWEVOKSAgICAwMDAwMDAwMDAwMDAzNDAzIDAwMDAwMDAwMDAwMDM0MDMgMDAw
MDAwMDAwMDAwMDAwMCBmZmZmZmZmZjgxZTRhMGVhDQo+IChYRU4pICAgIDAwMDAwMDAwMDAw
MDM0MDMgMDAwMDAwMDAwMDAwMDAxMCBkZWFkYmVlZmRlYWRmMDBkIDAwMDAwMTAwMDAwMDAw
MDANCj4gKFhFTikgICAgZmZmZmZmZmY4MWU0YTBlYSAwMDAwMDAwMDAwMDBlMDMzIDAwMDAw
MDAwMDAwMDAyNDYgZmZmZmM5MDA0MGI0M2MzMA0KPiAoWEVOKSBYZW4gY2FsbCB0cmFjZToN
Cj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjUwYzdlPl0gUiBzY2hlZF9taWdyYXRlX3RpbWVy
cysweDRkLzB4YzkNCj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjNmMWEwPl0gRiBjcHVwb29s
LmMjY3B1X2NhbGxiYWNrKzB4MTNkLzB4NDdlDQo+IChYRU4pICAgIFs8ZmZmZjgyZDA0MDIy
NmEwND5dIEYgbm90aWZpZXJfY2FsbF9jaGFpbisweDZjLzB4OTYNCj4gKFhFTikgICAgWzxm
ZmZmODJkMDQwMjA3ZTc1Pl0gRiBjcHUuYyNjcHVfbm90aWZpZXJfY2FsbF9jaGFpbisweDFi
LzB4MzYNCj4gKFhFTikgICAgWzxmZmZmODJkMDQwMjA4MjQzPl0gRiBjcHVfdXArMHhhZi8w
eGM4DQo+IChYRU4pICAgIFs8ZmZmZjgyZDA0MDIwODQyOD5dIEYgZW5hYmxlX25vbmJvb3Rf
Y3B1cysweDdiLzB4MWVmDQo+IChYRU4pICAgIFs8ZmZmZjgyZDA0MDI3YTJkZj5dIEYgcG93
ZXIuYyNlbnRlcl9zdGF0ZV9oZWxwZXIrMHgxNTYvMHg1ZGMNCj4gKFhFTikgICAgWzxmZmZm
ODJkMDQwMjA5YzczPl0gRiBkb21haW4uYyNjb250aW51ZV9oeXBlcmNhbGxfdGFza2xldF9o
YW5kbGVyKzB4NTAvMHhiZg0KPiAoWEVOKSAgICBbPGZmZmY4MmQwNDAyMmU0ODQ+XSBGIHRh
c2tsZXQuYyNkb190YXNrbGV0X3dvcmsrMHg3Yi8weGFjDQo+IChYRU4pICAgIFs8ZmZmZjgy
ZDA0MDIyZTc2ZT5dIEYgZG9fdGFza2xldCsweDU4LzB4OGENCj4gKFhFTikgICAgWzxmZmZm
ODJkMDQwMmY0NTVkPl0gRiBkb21haW4uYyNpZGxlX2xvb3ArMHg3OC8weGU2DQo+IChYRU4p
DQo+IChYRU4pIFBhZ2V0YWJsZSB3YWxrIGZyb20gMDAwMDAwMDAwMDAwMDA3MDoNCj4gKFhF
TikgIEw0WzB4MDAwXSA9IDAwMDAwMDAyNTE3ZmIwNjMgZmZmZmZmZmZmZmZmZmZmZg0KPiAo
WEVOKSAgTDNbMHgwMDBdID0gMDAwMDAwMDI1MTdmYTA2MyBmZmZmZmZmZmZmZmZmZmZmDQo+
IChYRU4pICBMMlsweDAwMF0gPSAwMDAwMDAwMjUxN2Y5MDYzIGZmZmZmZmZmZmZmZmZmZmYN
Cj4gKFhFTikgIEwxWzB4MDAwXSA9IDAwMDAwMDAwMDAwMDAwMDAgZmZmZmZmZmZmZmZmZmZm
Zg0KPiAoWEVOKQ0KPiAoWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqDQo+IChYRU4pIFBhbmljIG9uIENQVSAwOg0KPiAoWEVOKSBGQVRBTCBQQUdFIEZB
VUxUDQo+IChYRU4pIFtlcnJvcl9jb2RlPTAwMDBdDQo+IChYRU4pIEZhdWx0aW5nIGxpbmVh
ciBhZGRyZXNzOiAwMDAwMDAwMDAwMDAwMDcwDQo+IChYRU4pICoqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioNCj4gDQoNClRoaXMgaXMgdmVyeSB3ZWlyZC4gVGhl
IGRhdGEgc3VnZ2VzdHMgdGhhdCB0aGUgc2NoZWR1bGluZyByZXNvdXJjZSBwb2ludGVyDQpm
b3IgY3B1IDEgd2FzIE5VTEwsIGJ1dCBJIGNhbid0IHNlZSBob3cgdGhpcyBjYW4gYmUgdGhl
IGNhc2Ugd2l0aG91dCBjYXVzaW5nDQpzaW1pbGFyIGNyYXNoZXMgd2l0aG91dCB0aGlzIHBh
dGNoLg0KDQpBcmUgdGhlcmUgYW55IGFkZGl0aW9uYWwgcGF0Y2hlcyByZWxhdGVkIHRvIGNw
dSBvbi9vZmZsaW5pbmcgb3Igc3VzcGVuZC9yZXN1bWUNCmluIHRoZSBoeXBlcnZpc29yPw0K
DQoNCkp1ZXJnZW4NCg==
--------------7vefNumKYJnunoQLa1wCcNQz
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------7vefNumKYJnunoQLa1wCcNQz--

--------------FL8GGzN6KMP3dgOgxr1IjBUU--

--------------YlT41rAiS2D0e9gsCYcK3gDh
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNbqiwFAwAAAAAACgkQsN6d1ii/Ey9v
YQf/fA51PCDgohgOEpyMCWT0gA1GkHGf6h7rbCr91B0jDodICKut0aps1JspTC02f0rwK0e3qKK4
Jeodkwe9SsXGuUhcxFXcx7hu9LOOAon3kxg5UFyAU9wQ5aJB7UxRF9rFDTdpR3imPiXOoVkwd2hf
BheUwjWV5YPIp64IKorthOmPJVFWpw9VVGvXlQXKqfuNItmLlvYBkyEtsGdsZfBTRn9dtNl+SKRx
em+P+cWgSQwxrBP/1mx9yQF6GN/3VMmbyEJPjEvJ4++XFBNVnCY58SCzb5CQ7cykeRCP6S6TaTm3
VxLROZK5te7AABQwunlloAQo/+lNYIUZELJ8TW1LEg==
=Pm83
-----END PGP SIGNATURE-----

--------------YlT41rAiS2D0e9gsCYcK3gDh--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:10:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:10:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431876.684525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMJX-0007si-36; Fri, 28 Oct 2022 10:10:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431876.684525; Fri, 28 Oct 2022 10:10:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMJX-0007sb-09; Fri, 28 Oct 2022 10:10:11 +0000
Received: by outflank-mailman (input) for mailman id 431876;
 Fri, 28 Oct 2022 10:10:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3R+4=25=linaro.org=leo.yan@srs-se1.protection.inumbo.net>)
 id 1ooMJV-0007sI-Ae
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 10:10:09 +0000
Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com
 [2607:f8b0:4864:20::42b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b27ddbb9-56a8-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 12:10:07 +0200 (CEST)
Received: by mail-pf1-x42b.google.com with SMTP id b29so4390352pfp.13
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 03:10:07 -0700 (PDT)
Received: from leoy-huanghe.lan (211-75-219-199.hinet-ip.hinet.net.
 [211.75.219.199]) by smtp.gmail.com with ESMTPSA id
 p11-20020a1709026b8b00b0017fe9b038fdsm2678944plk.14.2022.10.28.03.10.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 28 Oct 2022 03:10:05 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b27ddbb9-56a8-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=qoRKvtVQlXySzXk8G6GxZl37sL+q1/QwV2HPSxPeiwQ=;
        b=EvFGmUcam85mPU0pWZxH6ePEah+NiQ92/juH9eZ9nt6RwEhkupBOFeXHHiewO+VGm4
         cK/0HvtCy24KHAdyppSXLcQNaDXTh9diezwJi2Nn/9qhiVhNECMkJNK+MVIj6m7v5T22
         bh2AOrfEI2a4OiWM+1mYbdBm8xc5ITGTIJ5nGLbW2rggipCQjlmrIDj1hYVRBaBpwICv
         3DWWCXyaLxb68pypPfOtdT66Gshga9EyHM/6V5Sxab5100RjHYQ4TDiS4VJZPglZmjgI
         qaRmNU91LzgQ3/60W08nm67WuJYmzvNv86D7Fze9nvhbQp8nWerY7IXBm5x0yF0C3asw
         omvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=qoRKvtVQlXySzXk8G6GxZl37sL+q1/QwV2HPSxPeiwQ=;
        b=uAal0i5eCnFsMh/y4GLh07lUdjRGwGz7+mpu7JcK+V79yS9QuwjvKXzLOdhGsf1T6Y
         7Z8j/3kNstGMpDm342JC5q84UXczEdvd/uiYlIvu2OqWR6QgOGBWl17qlK6rkTDI9+UI
         vcPQPylGZIE6NzlAOsE51ncSeYjJivDtx6/ZqNdbcQ5NC/yhl5x06qNQq30yEhJJf2zX
         6P847MoiPLtQSsu+bEtakSOBJrZFOC0FeXgq+PzXD+LqFLva0HPKR+POPeuvQ3JnWWx8
         3i8E5qYdSk+WdYBv/aCMghUcO1JJr3MdBGHih6Ph6gwcZCmFVaX+ZghtZxTEtXiJBZX5
         suQA==
X-Gm-Message-State: ACrzQf3/qongQonOdaX9w8YUdEFJgl5ZiShN84Rge8WpvVyGPAsctyJT
	nkJBnbxjvtS2eEP2+QzKQdjCZw==
X-Google-Smtp-Source: AMsMyM5F7/JB5P5Mo8KOtDo05NIjk05htZLFA9MKQVlsl7hYw5B3L+bPTBRrgVivHZS1+pKwqqfGDQ==
X-Received: by 2002:a63:ea4a:0:b0:439:4695:c0f8 with SMTP id l10-20020a63ea4a000000b004394695c0f8mr45676573pgk.440.1666951806030;
        Fri, 28 Oct 2022 03:10:06 -0700 (PDT)
Date: Fri, 28 Oct 2022 18:09:58 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen Develop <xen-devel@lists.xenproject.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Kasper Ornstein Mecklenburg <Kasper.OrnsteinMecklenburg@arm.com>,
	jgross@suse.com, oleksandr_tyshchenko@epam.com,
	boris.ostrovsky@oracle.com, wei.liu@kernel.org, paul@xen.org
Subject: Re: Issue: Networking performance in Xen VM on Arm64
Message-ID: <Y1uqdr1j9YwuIUBU@leoy-huanghe.lan>
References: <alpine.DEB.2.22.394.2210101621480.3690179@ubuntu-linux-20-04-desktop>
 <Y0VbQ3esM8gucmqQ@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210111434240.3690179@ubuntu-linux-20-04-desktop>
 <Y00/SW5Ro+SlhoBU@leoy-yangtze.lan>
 <alpine.DEB.2.22.394.2210171638080.4587@ubuntu-linux-20-04-desktop>
 <Y1J39UsPlM8htxFx@leoy-huanghe.lan>
 <alpine.DEB.2.22.394.2210211341440.3873@ubuntu-linux-20-04-desktop>
 <Y1ZvDt7/I9JXJh2r@leoy-huanghe.lan>
 <alpine.DEB.2.22.394.2210251655420.1397955@ubuntu-linux-20-04-desktop>
 <Y1umvVrGLktIvJuk@leoy-huanghe.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1umvVrGLktIvJuk@leoy-huanghe.lan>

On Fri, Oct 28, 2022 at 05:54:05PM +0800, Leo Yan wrote:

[...]

> If map to the code, I think the function xennet_start_xmit() in Xen
> frontend driver is critical for the sending interval in domU.  I can
> see several things cost time when sending a packet:
> 
> - Xen frontend driver needs to setup grant table for every skb, it
>   invokes the function xennet_tx_setup_grant() and
>   gnttab_grant_foreign_access_ref() to prepare grant table;
> 
> - Xen frontend driver sends notification by calling
>   notify_remote_via_irq().  It will trap to Xen hypervisor to send the
>   interrupt, this takes several macro seonds for this step.
> 
> - Xen frontend driver calls xennet_tx_buf_gc(), the interval for this
>   function is vary, it will take ~30us in the case for reclaiming grant
>   table.
> 
> Any thoughts for this?

Supplement info with Ftrace function graph.  You could see below
log which shows the time is spent in xennet_start_xmit():

 1)               |  xennet_start_xmit() {
 1)               |  /* xennet_start_xmit: TSC: 50702652609 */
 1)   0.240 us    |    _raw_spin_lock_irqsave();
 1)               |    netif_skb_features() {
 1)   0.280 us    |      skb_network_protocol();
 1)   0.920 us    |    }
 1)               |    gnttab_foreach_grant_in_range() {
 1)               |      xennet_tx_setup_grant() {
 1)   0.280 us    |        gnttab_claim_grant_reference();
 1)               |        gnttab_grant_foreign_access_ref() {
 1)   0.280 us    |          gnttab_update_entry_v1();
 1)   0.800 us    |        }
 1)               |        /* id=103 ref=871 offset=2050 len=1514 TSC: 50702652709 */
 1)   2.200 us    |      }
 1)   2.800 us    |    }
 1)               |  /* xennet_notify_tx_irq: TSC: 50702652741 */
 1)               |    notify_remote_via_irq() {
 1)               |      irq_get_irq_data() {
 1)   0.240 us    |        irq_to_desc();
 1)   0.760 us    |      }
 1)   3.880 us    |    }
 1)   0.280 us    |    xennet_tx_buf_gc();
 1)   0.240 us    |    _raw_spin_unlock_irqrestore();
 1) + 11.120 us   |  }
 1)               |  xennet_start_xmit() {
 1)               |  /* xennet_start_xmit: TSC: 50702652974 */
 1)   0.280 us    |    _raw_spin_lock_irqsave();
 1)               |    netif_skb_features() {
 1)   0.240 us    |      skb_network_protocol();
 1)   0.760 us    |    }
 1)               |    gnttab_foreach_grant_in_range() {
 1)               |      xennet_tx_setup_grant() {
 1)   0.280 us    |        gnttab_claim_grant_reference();
 1)               |        gnttab_grant_foreign_access_ref() {
 1)   0.360 us    |          gnttab_update_entry_v1();
 1)   0.840 us    |        }
 1)               |        /* id=101 ref=869 offset=1026 len=574 TSC: 50702653093 */
 1)   2.800 us    |      }
 1)   3.320 us    |    }
 1)               |  /* xennet_notify_tx_irq: TSC: 50702653124 */
 1)               |    notify_remote_via_irq() {
 1)               |      irq_get_irq_data() {
 1)   0.240 us    |        irq_to_desc();
 1)   0.760 us    |      }
 1)   3.840 us    |    }
 1)   0.280 us    |    xennet_tx_buf_gc();
 1)   0.280 us    |    _raw_spin_unlock_irqrestore();
 1) + 11.800 us   |  }
 1)               |  /* finish_transmit_data */
 1)               |  /* transmit_data */
 1)               |  /* finish_transmit_data */
 1)               |  /* transmit_data */
 1)               |  /* finish_transmit_data */
 1)               |  /* transmit_data */
 1)               |  /* finish_transmit_data */
 1)               |  /* Before_throttle */
 1)               |  xennet_start_xmit() {
 1)               |  /* xennet_start_xmit: TSC: 50702654697 */
 1)   0.280 us    |    _raw_spin_lock_irqsave();
 1)               |    netif_skb_features() {
 1)   0.240 us    |      skb_network_protocol();
 1)   0.760 us    |    }
 1)               |    gnttab_foreach_grant_in_range() {
 1)               |      xennet_tx_setup_grant() {
 1)   0.280 us    |        gnttab_claim_grant_reference();
 1)               |        gnttab_grant_foreign_access_ref() {
 1)   0.320 us    |          gnttab_update_entry_v1();
 1)   0.920 us    |        }
 1)               |        /* id=3 ref=771 offset=2050 len=1514 TSC: 50702654801 */
 1)   2.400 us    |      }
 1)   2.960 us    |    }
 1)               |  /* xennet_notify_tx_irq: TSC: 50702654832 */
 1)               |    notify_remote_via_irq() {
 1)               |      irq_get_irq_data() {
 1)   0.280 us    |        irq_to_desc();
 1)   0.760 us    |      }
 1)   4.160 us    |    }
 1)               |    xennet_tx_buf_gc() {
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.480 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.960 us    |      }
 1)   0.280 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.240 us    |        __raise_softirq_irqoff();
 1)   1.240 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.480 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.960 us    |      }
 1)   0.240 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.240 us    |        __raise_softirq_irqoff();
 1)   0.760 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.400 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.840 us    |      }
 1)   0.280 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.280 us    |        __raise_softirq_irqoff();
 1)   0.880 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.360 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.840 us    |      }
 1)   0.240 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.240 us    |        __raise_softirq_irqoff();
 1)   0.760 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.240 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.760 us    |      }
 1)   0.240 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.240 us    |        __raise_softirq_irqoff();
 1)   0.760 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.360 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.960 us    |      }
 1)   0.240 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.240 us    |        __raise_softirq_irqoff();
 1)   0.760 us    |      }
 1) + 17.720 us   |    }
 1)   0.360 us    |    _raw_spin_unlock_irqrestore();
 1) + 29.320 us   |  }
 1)               |  xennet_start_xmit() {
 1)               |  /* xennet_start_xmit: TSC: 50702655824 */
 1)   0.360 us    |    _raw_spin_lock_irqsave();
 1)               |    netif_skb_features() {
 1)   0.280 us    |      skb_network_protocol();
 1)   0.760 us    |    }
 1)               |    gnttab_foreach_grant_in_range() {
 1)               |      xennet_tx_setup_grant() {
 1)   0.280 us    |        gnttab_claim_grant_reference();
 1)               |        gnttab_grant_foreign_access_ref() {
 1)   0.280 us    |          gnttab_update_entry_v1();
 1)   0.880 us    |        }
 1)               |        /* id=28 ref=796 offset=2 len=1514 TSC: 50702655925 */
 1)   2.280 us    |      }
 1)   2.920 us    |    }
 1)               |  /* xennet_notify_tx_irq: TSC: 50702655958 */
 1)               |    notify_remote_via_irq() {
 1)               |      irq_get_irq_data() {
 1)   0.280 us    |        irq_to_desc();
 1)   0.760 us    |      }
 1)   4.160 us    |    }
 1)               |    xennet_tx_buf_gc() {
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.360 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.880 us    |      }
 1)   0.280 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.280 us    |        __raise_softirq_irqoff();
 1)   1.280 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.360 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.880 us    |      }
 1)   0.760 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.280 us    |        __raise_softirq_irqoff();
 1)   0.760 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.400 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.880 us    |      }
 1)   0.240 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.400 us    |        __raise_softirq_irqoff();
 1)   0.880 us    |      }
 1)               |      gnttab_end_foreign_access_ref() {
 1)   0.400 us    |        gnttab_end_foreign_access_ref_v1();
 1)   0.880 us    |      }
 1)   0.280 us    |      gnttab_release_grant_reference();
 1)               |      __dev_kfree_skb_irq() {
 1)   0.240 us    |        __raise_softirq_irqoff();
 1)   0.760 us    |      }
 1) + 12.440 us   |    }
 1)   0.800 us    |    _raw_spin_unlock_irqrestore();
 1) + 24.080 us   |  }
 1)               |  xennet_start_xmit() {
 1)               |  /* xennet_start_xmit: TSC: 50702656728 */
 1)   0.240 us    |    _raw_spin_lock_irqsave();
 1)               |    netif_skb_features() {
 1)   0.240 us    |      skb_network_protocol();
 1)   0.760 us    |    }
 1)               |    gnttab_foreach_grant_in_range() {
 1)               |      xennet_tx_setup_grant() {
 1)   0.280 us    |        gnttab_claim_grant_reference();
 1)               |        gnttab_grant_foreign_access_ref() {
 1)   0.240 us    |          gnttab_update_entry_v1();
 1)   0.720 us    |        }
 1)               |        /* id=103 ref=871 offset=2050 len=1422 TSC: 50702656823 */
 1)   2.160 us    |      }
 1)   2.800 us    |    }
 1)               |  /* xennet_notify_tx_irq: TSC: 50702656850 */
 1)               |    notify_remote_via_irq() {
 1)               |      irq_get_irq_data() {
 1)   0.240 us    |        irq_to_desc();
 1)   0.720 us    |      }
 1)   3.920 us    |    }
 1)   0.320 us    |    xennet_tx_buf_gc();
 1)   0.280 us    |    _raw_spin_unlock_irqrestore();
 1) + 11.000 us   |  }



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:12:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:12:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431883.684536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMM5-00008U-MR; Fri, 28 Oct 2022 10:12:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431883.684536; Fri, 28 Oct 2022 10:12:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMM5-00008N-IQ; Fri, 28 Oct 2022 10:12:49 +0000
Received: by outflank-mailman (input) for mailman id 431883;
 Fri, 28 Oct 2022 10:12:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zj9=25=citrix.com=prvs=2939fe9fd=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ooMM5-00008G-1V
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 10:12:49 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 111dbe3e-56a9-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 12:12:47 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 06:12:40 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by MN2PR03MB5021.namprd03.prod.outlook.com (2603:10b6:208:1a8::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 10:12:38 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Fri, 28 Oct 2022
 10:12:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 111dbe3e-56a9-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666951967;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=V5tqL95KA5nNxGQnc24lGJUYzONxfx8UwMjpXlXozT8=;
  b=SgniGzzB8Zmvq1Vz8kefpnpUhyIQoJ/pA42Q2kuxeHKNQ0Rl23UmuIii
   ZRo59iCCugeSkriIu8Zy/yweN2IShXTGUs7fEAa/GQ1eDlSjJUtqrWd8+
   XsjkcZCVftXcKze6wPSQ+CVpxGl5DQisA7tnsPGdAdFJdu1Pyy+g5eoRQ
   c=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 82795885
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:DB/3v6hEP1z4McLMtpd/WLL7X161nREKZh0ujC45NGQN5FlHY01je
 htvCmmFOPaOa2PyL91/PYzgo08HvMXSzIA3QQdopHtkFn8b9cadCdqndUqhZCn6wu8v7q5Ex
 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv
 cKai8DEMRqu1iUc3lg8sspvkzsy+qWv0N8klgZmP6oS5AWOzyB94K83fsldEVOpGuG4IcbiL
 wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ
 OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+
 tQ2LBpSNQCjmdmkweynbupUwccKdY70adZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe
 swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYbI5efTTLSlRtm+eq
 njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ROfnp6M60AD7Kmo7SxcXdn2yq9mFkg2sa/BgB
 kIy4TEDlP1nnKCsZpynN/Gim1aGsQQbQMF4CPAh5UeGza+8ywOQHG0NVDNCQN0gqs4tRDYu2
 0OJntXmHjhmuvueTnf13qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adgtP8Fj7xx
 DSLhDMjnLhVhskOv42+8FbIky+ErZnSCBMt6wPRGG+p82tRRIOjfZ3u1lHd4t5JNoPfRV6E1
 EXogOCb5eEKSJuLxCqERbxUGKnzvqjUdjrBnVRoAp8tsSy3/GKudpxR5zc4I1p1NsEDenniZ
 0q7VR5t2aK/9UCCNcdfC79dwexzpUQ8PbwJjszpU+c=
IronPort-HdrOrdr: A9a23:mFRWWawhUkiY92yg4rGgKrPxj+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up
 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e
 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU
 TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD
 AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5
 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe
 NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f
 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo
 SOBK4=
X-IronPort-AV: E=Sophos;i="5.95,220,1661832000"; 
   d="scan'208";a="82795885"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kGGg+En4VGffWru4NFGwlB5PlT+T7xh+muAFs6jy7P+D3EhOOcZfJU/kWbPGs6p4Y21NcA0bUmwyzyIk/SFVz9wUhjdvQ3gq9c5ghRQPW9h/OCLl2Xfd3YuO9OMWeFgPPBLY/fwtXBb6aKbB4udlX0pKJyzzkpqBTJI7t+XG3XahRnSSezh6twTRrr6KdV5BEAV4A3o/wlDd1SpnoPqJorI9gJMYNT+rJhzEd6GKgF6dwLQ259INPnAQpSpNOCrCSzm4VLQS2obgYNLw11gOHePqFb+r+aLHVidRCJXDHEJ9YBAP0xQ0LPKxls4jejZo86mWxVDvv9hnZtu54egLUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V5tqL95KA5nNxGQnc24lGJUYzONxfx8UwMjpXlXozT8=;
 b=L8BMldbAh+76QTRmVaZ1qX4L8RcMIIyQShqBP0qQrZLXLI9VK7qRU/iDnbtj3rRjqQbEu2596XIzp5LfMEwGZTuSTC/7GlcG7UHcoLYN+OO8057yupLekbGeQp6YgqOiU6xq5Ha56aSmbCVHliNS4gefGWcGlNLiQaQfriRpKOue+/13EssQoSYPTtdKHPbofa0Bdz45x2wtGxkLwUgw1HtFPjRTI0dZCz/lfgneQCEA6kL56jqicAnESrzA2r/Ritiss7TyqKQB5O8ktm4cus79YrNt2xOwMe/KIiDJn6nC74wuX4/ESF6hmexPICtjIxQPR+x90+RuOdhzOS7Ucw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=V5tqL95KA5nNxGQnc24lGJUYzONxfx8UwMjpXlXozT8=;
 b=YSSbYhlM0hsOEx56UNTxG/1yLjZMRWl79dzOmV0SKq92Qy33nVeAFOaQRp3pGj9ir7B/uqEeYL50olbWy2Opwm/Ey48dLPVyX1rF7w7RJ26nNBqVXa3rT4Hpy4XbZXirigq6O/ojMHte0o8CN3c1Vgt+KdoTC5bPe7Q8aVv/LRc=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	=?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?=
	<marmarek@invisiblethingslab.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, George
 Dunlap <George.Dunlap@citrix.com>, Dario Faggioli <dfaggioli@suse.com>, Meng
 Xu <mengxu@cis.upenn.edu>, Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
Thread-Topic: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
Thread-Index: AQHY5V0DqOkvDmJ7xEaSKIEsmxLl9K4ilMQAgAELBwCAAAEVAA==
Date: Fri, 28 Oct 2022 10:12:36 +0000
Message-ID: <901fa58e-6693-ca2e-9231-447f989d614d@citrix.com>
References: <20221021145357.17931-1-jgross@suse.com>
 <Y1rKLJP/p+E+eVi7@mail-itl> <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
In-Reply-To: <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|MN2PR03MB5021:EE_
x-ms-office365-filtering-correlation-id: 1f268135-c21c-4ee6-ae8d-08dab8ccf040
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 tNCKRxxhGcRqhIFvf9QjBJ82EsutO3A2unHE65hzlr+dQGYOZdgg6EPd/2+Ln/cYznt1kgPfRDBPMO3V63fDhU6T1IKdf8O1v0ws8UUZLfHTnz/hxa0oXK6FSLKtlpH8Gj2wxNCBlZH7ilcGu3se2WdYzJUEdqihf4NYr4VL4OoLx22gtIzx29dGirVwhUQ5F2AD3iywOV8smAwyLIFSFgKxbJXmrnWiUCdYx48pFz8dNae1+IDTxEBK4qpeoeSiXqAivjYJ/pWha/JU5a2N+TaEYjxEuewKonidpKSFLE3nQO2klw2cwiOwtMOTa2Bsn1UrQwYtbUMIvgABAKZPfNpaiu9Qm45bSj/iXQw/3nXkSea8zH6u2C+v93DUIvohvayD9bkxe6aXEB6FU6whjGMTgP3gJYLQG3gjToTrshnQ1OcvrKC0aYLBI0c+f023bq1MzDOJO7+nmNJE/adpkCau67wzCx9DI0AT8WHH7rL/+t4Hwc7HQfC3mNhPAiua73FgC/YV28WDEgho8JVDAhsU8UEDaLg5cnEAwccQUve8HaHKiv4GVMgazfwqICknpr2ZyOIg/XTbL8BpLFnjuoSHdjQetbKHrqbCJJv4es8pGjZQiLcX9tsfXF+SUnARQtnNj0y7UGtz4YCUuZJpzBAVOX431DJ+FMZwIUJkQWWEFvMl9Jk2pBvxqxWOoZi1uaGxfEzYaBTiQmJMxDmWHRgJtQOf7rQL1xUzytzTclIayyw7xhrvMJ5Wjb7aZ4o0qlpn9eUqtoaCFkkeGw37G4e24XwTILr5iba7DcpMbbfoqGu4lBu3cB8E7kFBh7dimcLs5JT7QA9sQWkIUvlfiA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(71200400001)(478600001)(6486002)(38070700005)(122000001)(82960400001)(31686004)(110136005)(316002)(66574015)(91956017)(54906003)(6512007)(26005)(66556008)(66946007)(66476007)(66446008)(76116006)(6506007)(2906002)(38100700002)(41300700001)(31696002)(86362001)(83380400001)(64756008)(186003)(5660300002)(8936002)(2616005)(4326008)(8676002)(36756003)(53546011)(15650500001)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?bVJtUGUrYVYzc09yWnpaVXc0Tyt6YUFOOW1UV3A0c0M4aVB5NHhBWHlsdFFW?=
 =?utf-8?B?bjBVZG9yNzFqcG1ncjdtNVRvSkE5VXFJNWNMS3BLOXBRRngxNmJXNDhFTEFy?=
 =?utf-8?B?MTJhbDZ6ODVvSzI2M0t3YkQ5SERRV0dpR25FamhoZHVTWHYvWm5JVlZxYWxW?=
 =?utf-8?B?d0drR1VaRG8vK1o5YkplRkdaaW16NXQvcmVPbEZJc3JPV002QzhzcDBqQ0pp?=
 =?utf-8?B?UGN3NkNUTFNBQ0N6S09lMmRsNFp5YlNITlBTVXhRMDJjR2ZGcWVINktHUk56?=
 =?utf-8?B?V2VIR1drRHJlcUFpRURwMkhTN25RcUVkcTYweFpDbllaNVIyMUV5N0g4eUFL?=
 =?utf-8?B?NDNsVXdBR3lPVm1sOHROUVY3S3BXNCtTam5EZll2azNyQ05WeUtDV0lOOTF6?=
 =?utf-8?B?Sk1Hd05DcVJ1anEwQ1JrUU1rV25RYTZTYjBnZ2V4eWVMUHpkQUU3eFd4azVE?=
 =?utf-8?B?bVNDV3IrTkl3ZWNoKzN2VDdnUlprMSs1cVVWdDd5VXYwNnppWVROUHBZaDQy?=
 =?utf-8?B?eXV1eGkrTkw0RE9sc1o0b3dJU0Rvc2NDcWNKaVlTR00xQmRYUEUwTHE1NEVN?=
 =?utf-8?B?NTd2RVRWTnVLQTBaUWdxcFdKUWlMMjZYK21Kemd6RU9PQnFpemxlenlWVXVY?=
 =?utf-8?B?TlZQb1Avd0ZnUXFzemE3MGJ4bTFOSkMxYXpuY28ySStjUVE1WmR3VlZKNnNP?=
 =?utf-8?B?WEtkMFFqd0sxTUQwU3V4a28waDF0UHFxWjBaMHJFQ0JUWmFOZDQ2WWZEVCtO?=
 =?utf-8?B?eU82c1JyM1BSaTRJSnZBRithakJHbGdnSE1FZXQyN3BZYkdiYnJyUlp6Z3Fw?=
 =?utf-8?B?OUp3ZlBPV3RhbmVQY0FSUzF4ZG5LR0dORzNIS0p3N0oyWnZuR1BEV3hXZ1la?=
 =?utf-8?B?djd5K1hGWEdvcUpCVGpaVWNISGVrNnBzSEFvd1dDV1g1Um1sdHo0NjZ6RWZz?=
 =?utf-8?B?OVZpQ0dsQlBPZjVyYzErc0hBd25EWElEbjFxcS9LcHRGQ00rTzBvQ2RCU1ND?=
 =?utf-8?B?WGdtcHU4bitIQ1I3L3QyMlNxWXgxQTJtMFF1UWNOa21rbzhOL0djODk0QnVC?=
 =?utf-8?B?K01BV2V6c2dLTGJwMHJCTEVNY1BnRC8rREhHK2tyV0FZS1Qyc2owcDR4TG9N?=
 =?utf-8?B?RFpBSlN5ajAxdTVrY25IajJaZWFkYVRZbm1zNzRTb3hUdHA4ZG80QTYwazRk?=
 =?utf-8?B?amdTemZLRWRXU2NtOExZdGVpdkNnK0J4YmlwdFRFNHBrTFp2eURkWXcyeVZl?=
 =?utf-8?B?T2JuR29xLzFCZVNuUWFKWDlCVnU5dUhzbUd0dDMvNkZZU2FJRW1yV1lEbTNY?=
 =?utf-8?B?WnpCYnRaK2M2TVZuTjV3dnZ0L243RUwrTjFPM2k5UmhrZEFGQzF4OVowczFm?=
 =?utf-8?B?NlVoVWEvYkdPSjlaaFJyOG1qR2RLV1BzVjVNOGdlcU1UaXB2UWlMeWxXa3J0?=
 =?utf-8?B?MWJkN29NYXV5ZlRacm1GM3htSHRRZEtyd1FnNEh5VkNLQmFoRFRNOUNiVkE5?=
 =?utf-8?B?VkpwdWFicm84RlNOTEZhQmZMZmZkVnEzQnJCNStnWFgyWUJnM3BaZk93UFBU?=
 =?utf-8?B?VmVxYnRuRnFCWnJBcW9jRG9jVjNUNzhJdGR5eDJOSmtBL01nWlg2ZkxueDYx?=
 =?utf-8?B?bk9WTDhwTE5jSnVwaXhkeHpSb2VIUHovOEUrTGg1bUk4RlpHM09nNTVuOFRD?=
 =?utf-8?B?RUVRQjZkVUF0dWY5Rkl3czBINjRKS2IzMHJ6QmpkTVo3QW5ieHZvdFZyRGpp?=
 =?utf-8?B?NlNrYnpXR3BsOHQ2STFURWtxR0FFR1NZcWtZYVVkRnRHSXFzMzlCRDdKK2p6?=
 =?utf-8?B?Z2FmOFVzTFBReTRXeVJNbFhBU0FxN2RrdXZvNzJHM0lmeTQrdVhLZDFSOXZE?=
 =?utf-8?B?eFlxVnVDL0w0bTZXakU1V0tPK3dUV0ZxN2w3eHlFdkhIVVlaOVY4OGlacGti?=
 =?utf-8?B?MjdKTjNQUmpadDhmdXIwVWxMMlFVSk5ZQ3BGOEJGVjMrMEgvbStRaFJLZEZu?=
 =?utf-8?B?M0Zyc00ybmhTdFBITTdzUUxEMDNUK2hPeW80TXFTL0N2cVlTeHFxMVY5cUtl?=
 =?utf-8?B?a2srSmpsckRGeEZmdThleVU4ZFRRdXUrQ0t3NEwxdktjQnJlMGsvMjhBbG9C?=
 =?utf-8?Q?bJHW3IKN2bAqrcbNbZXO/ieWZ?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <026262F9564F7F41A6021F0B8558228C@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f268135-c21c-4ee6-ae8d-08dab8ccf040
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 10:12:36.9487
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Me7MOoDr+OhsQSuvCfIXQ93R17/G6rg9HaV7QzAHCzKLeAfJLWQ7asQGSLZOcy+JN1M5EMFKMIkweJhOZjZ2KNuCSJh9sJrziMa00e00wf8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5021

T24gMjgvMTAvMjAyMiAxMTowOCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4gT24gMjcuMTAuMjIg
MjA6MTMsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToNCj4NCj4gVGhpcyBpcyB2
ZXJ5IHdlaXJkLiBUaGUgZGF0YSBzdWdnZXN0cyB0aGF0IHRoZSBzY2hlZHVsaW5nIHJlc291cmNl
DQo+IHBvaW50ZXINCj4gZm9yIGNwdSAxIHdhcyBOVUxMLCBidXQgSSBjYW4ndCBzZWUgaG93IHRo
aXMgY2FuIGJlIHRoZSBjYXNlIHdpdGhvdXQNCj4gY2F1c2luZw0KPiBzaW1pbGFyIGNyYXNoZXMg
d2l0aG91dCB0aGlzIHBhdGNoLg0KPg0KPiBBcmUgdGhlcmUgYW55IGFkZGl0aW9uYWwgcGF0Y2hl
cyByZWxhdGVkIHRvIGNwdSBvbi9vZmZsaW5pbmcgb3INCj4gc3VzcGVuZC9yZXN1bWUNCj4gaW4g
dGhlIGh5cGVydmlzb3I/DQoNClF1YmVzT1MgcnVucyB3aXRoIHNtdD0wIGJ5IGRlZmF1bHQuwqAg
U2libGluZ3Mgb3VnaHQgdG8gYmUgcGFya2VkIGF0IHRoaXMNCnBvaW50Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:22:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:22:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431891.684546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMVe-0001tQ-KE; Fri, 28 Oct 2022 10:22:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431891.684546; Fri, 28 Oct 2022 10:22:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooMVe-0001tJ-Gp; Fri, 28 Oct 2022 10:22:42 +0000
Received: by outflank-mailman (input) for mailman id 431891;
 Fri, 28 Oct 2022 10:22:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IcqW=25=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ooMVd-0001tD-0L
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 10:22:41 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 71945715-56aa-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 12:22:38 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 7346D5C0073;
 Fri, 28 Oct 2022 06:22:36 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Fri, 28 Oct 2022 06:22:36 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 28 Oct 2022 06:22:34 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71945715-56aa-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1666952556; x=
	1667038956; bh=LQTrCQ1SmBiYMtTtcTNZ6a86ZIztFd+ZsK2jWKD8/hw=; b=B
	L48UI05TXtVtXyiJ7VqO7IoT81CGwCNPasYNoptIIuqNAjTkmkwLDF8jKzqLYr5v
	nWb2e0phsrlHsinbsP/cG+/4wplfCpSiTEgmI438w7trvyLCnTwaq5QDRVOBhlFc
	iexnGzAkc9VzmwsSrYqkuoXFWQdgrfwsYt++y/QHWNrZoz6nPpK/HaTDBXToK0dF
	wgnZdAP2HOrWFEgGD7kExbbM91cptOPDZSZ2YcmjxWFyXB4DhkT3HOniwwLZWNbf
	YZVNdcAGo1bdGo6nNlx0a8gTJX38WbJ+vXyYuL2zf9St6v5wlgYcOhMOPIFgiG8k
	JM8dqVWjMezSCzy4c3Djw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1666952556; x=1667038956; bh=LQTrCQ1SmBiYMtTtcTNZ6a86ZIzt
	Fd+ZsK2jWKD8/hw=; b=BuPCIX3pgX6U/YlebhmYeaDQO8ukMQ71hn8upA5me+Os
	Ud2XaqTf8sJ0/ruTGDC1O1tmcnuh9OQ+XcVZWYjvNbGxmiDpwV8oZlwDUD2CzS7K
	407ZKug+zsXZV1sR+Ofule44jHQGc+H+nB/WGSYTMxNbwZcjd+KuQL4Hz5oNZe1q
	GhK9NtSRqRi2Ya8slZYeUOqERbWVe2WtQbhIKZcZ35qm2O+g0yBaYmnTW6qpgWpk
	wFUcQvW6b06WkPf1OsNbBw/sMGRqA1ILs7t53cy89ixJsjo5V6NWuljPrA7HHYgB
	ZbOU9ZfSG9aT/0wgmgETafmq5ZZap+Mp34ZfYVffnw==
X-ME-Sender: <xms:bK1bYzL_0gH5OUmSnGoqub7QpBQhtmOmuBzufXj0fn8NKGQtoyFk4g>
    <xme:bK1bY3KwKz53ZD53kXBk0m-eV6AleB5uoDcbgbwoLe11_5JjMejqcR9hL9B2oLFJj
    ITV72kVNXhsnw>
X-ME-Received: <xmr:bK1bY7vkmDVUcADB_cRok8Qc7jYsd1Bhym6cOn9Nm6wrH9QP8RkVudhB5zzq_1_lD2Gncyf25YKn7a87sfJYWr6r3tVJqQ_pSGNJ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeigddviecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeukeet
    teeggffgkeduheetgeeileejjeeiiefhjeegvefhtefggfetueetteeuteenucffohhmrg
    hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
    pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomh
X-ME-Proxy: <xmx:bK1bY8bR4HpI6hWZeq3juHDbHtQv9zkucnGpA2FwwfG031TFpNPUjA>
    <xmx:bK1bY6b5_KDVoTXTLUcKw4bEMu6al_JJIhonn_vKCfZVjREvxFTCbQ>
    <xmx:bK1bYwAM8G1ivjO4wr5oYskNDdiYJ-GmjrR3djs8gYaJm0Mf8xNEUg>
    <xmx:bK1bYxUnBkXFTirBg56viCKu1kGGtlK9w2S7krVEqQmflSvD_lt6QQ>
Feedback-ID: i1568416f:Fastmail
Date: Fri, 28 Oct 2022 12:22:29 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
Message-ID: <Y1utZequY2IC9Apw@mail-itl>
References: <20221021145357.17931-1-jgross@suse.com>
 <Y1rKLJP/p+E+eVi7@mail-itl>
 <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
 <901fa58e-6693-ca2e-9231-447f989d614d@citrix.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="5KRzSUE2BoJpADaP"
Content-Disposition: inline
In-Reply-To: <901fa58e-6693-ca2e-9231-447f989d614d@citrix.com>


--5KRzSUE2BoJpADaP
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 28 Oct 2022 12:22:29 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Juergen Gross <jgross@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend

On Fri, Oct 28, 2022 at 10:12:36AM +0000, Andrew Cooper wrote:
> On 28/10/2022 11:08, Juergen Gross wrote:
> > On 27.10.22 20:13, Marek Marczykowski-G=C3=B3recki wrote:
> >
> > This is very weird. The data suggests that the scheduling resource
> > pointer
> > for cpu 1 was NULL, but I can't see how this can be the case without
> > causing
> > similar crashes without this patch.
> >
> > Are there any additional patches related to cpu on/offlining or
> > suspend/resume
> > in the hypervisor?

No such patches, it was this:
https://github.com/marmarek/xen/commits/master-credit-timers

> QubesOS runs with smt=3D0 by default.=C2=A0 Siblings ought to be parked a=
t this
> point.

Yes, indeed this test was with smt=3Doff.

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--5KRzSUE2BoJpADaP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNbrWUACgkQ24/THMrX
1yxfigf9HwIx/DDg6yHOiG9tf2VFYfWAuomfIjGOX7CrygSreAXhDsWPRF4DLGjJ
XwzVq/c3lb9CVRNwlRfd+T9mhKAsyzVXltqfJsQncoRQjvbtNj72D3dPXalfURYx
S0kW4CuBT5QT6Fh/owQGujTm/ffkxePAlRhxlZIxuTVpHZniXyQQr4xsDnR5ToSv
ZgsDHA+MUFuwaGE7bUUGLLXUhPjoOjB5R15j103Cc5t9vGc2x7ehehXF1ua48O9U
/6gT2ltGpjaBBn0CanmbzuuhOysjoOV/lHemMNsQx66dv7C2PFQPIBhvxqmoJDbs
y/QmNX9Y9mJXd0Vb3cYeqYR0KK0X6A==
=Y2d5
-----END PGP SIGNATURE-----

--5KRzSUE2BoJpADaP--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:56:45 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:56:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431902.684558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooN2X-0006Kd-86; Fri, 28 Oct 2022 10:56:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431902.684558; Fri, 28 Oct 2022 10:56:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooN2X-0006KW-4E; Fri, 28 Oct 2022 10:56:41 +0000
Received: by outflank-mailman (input) for mailman id 431902;
 Fri, 28 Oct 2022 10:56:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mkji=25=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ooN2V-0006KQ-AU
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 10:56:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 30fff563-56af-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 12:56:36 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0669121A59;
 Fri, 28 Oct 2022 10:56:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B610513A6E;
 Fri, 28 Oct 2022 10:56:36 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Ma7nKmS1W2MvSAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 28 Oct 2022 10:56:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30fff563-56af-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666954597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=y+pzUQWrSPJMKcGCvx5iWaKBsT+Mz7M8rB9qZ9ADrVg=;
	b=IuyhB2yOZC+Ty6FStCjSmlt97uBlq7FmwYV0uMEIfbVnY4WUZLbZusVGRlJPAYrx8+wbDH
	BiuXYb67QV4mdLtpFIMuPPOUOjCNpsHSwFbBPhIlqpeDCd394ogXFOYDRNEyQVaRC2wjFm
	e63n3nKeZT1Ml9TyZSLhGPJE3SUuqwk=
Message-ID: <301b11d2-ed2f-8e00-1c0c-4c2211eb3f38@suse.com>
Date: Fri, 28 Oct 2022 12:56:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Content-Language: en-US
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 George Dunlap <George.Dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
 Henry Wang <Henry.Wang@arm.com>
References: <20221021145357.17931-1-jgross@suse.com>
 <Y1rKLJP/p+E+eVi7@mail-itl> <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
 <901fa58e-6693-ca2e-9231-447f989d614d@citrix.com> <Y1utZequY2IC9Apw@mail-itl>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
In-Reply-To: <Y1utZequY2IC9Apw@mail-itl>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="------------dyY9gXJnoU90HCMTI0K9FZUx"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------------dyY9gXJnoU90HCMTI0K9FZUx
Content-Type: multipart/mixed; boundary="------------tVKpkSfc72PZx5fweGhqJxXu";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?=
 <marmarek@invisiblethingslab.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 George Dunlap <George.Dunlap@citrix.com>, Dario Faggioli
 <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
 Henry Wang <Henry.Wang@arm.com>
Message-ID: <301b11d2-ed2f-8e00-1c0c-4c2211eb3f38@suse.com>
Subject: Re: [PATCH-for-4.17] xen/sched: migrate timers to correct cpus after
 suspend
References: <20221021145357.17931-1-jgross@suse.com>
 <Y1rKLJP/p+E+eVi7@mail-itl> <4977c33a-fe11-172a-11be-17acb01d61bb@suse.com>
 <901fa58e-6693-ca2e-9231-447f989d614d@citrix.com> <Y1utZequY2IC9Apw@mail-itl>
In-Reply-To: <Y1utZequY2IC9Apw@mail-itl>

--------------tVKpkSfc72PZx5fweGhqJxXu
Content-Type: multipart/mixed; boundary="------------p0Pnm2fL2DbFuql9tnB8BgQv"

--------------p0Pnm2fL2DbFuql9tnB8BgQv
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: base64

T24gMjguMTAuMjIgMTI6MjIsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSB3cm90ZToN
Cj4gT24gRnJpLCBPY3QgMjgsIDIwMjIgYXQgMTA6MTI6MzZBTSArMDAwMCwgQW5kcmV3IENv
b3BlciB3cm90ZToNCj4+IE9uIDI4LzEwLzIwMjIgMTE6MDgsIEp1ZXJnZW4gR3Jvc3Mgd3Jv
dGU6DQo+Pj4gT24gMjcuMTAuMjIgMjA6MTMsIE1hcmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNr
aSB3cm90ZToNCj4+Pg0KPj4+IFRoaXMgaXMgdmVyeSB3ZWlyZC4gVGhlIGRhdGEgc3VnZ2Vz
dHMgdGhhdCB0aGUgc2NoZWR1bGluZyByZXNvdXJjZQ0KPj4+IHBvaW50ZXINCj4+PiBmb3Ig
Y3B1IDEgd2FzIE5VTEwsIGJ1dCBJIGNhbid0IHNlZSBob3cgdGhpcyBjYW4gYmUgdGhlIGNh
c2Ugd2l0aG91dA0KPj4+IGNhdXNpbmcNCj4+PiBzaW1pbGFyIGNyYXNoZXMgd2l0aG91dCB0
aGlzIHBhdGNoLg0KPj4+DQo+Pj4gQXJlIHRoZXJlIGFueSBhZGRpdGlvbmFsIHBhdGNoZXMg
cmVsYXRlZCB0byBjcHUgb24vb2ZmbGluaW5nIG9yDQo+Pj4gc3VzcGVuZC9yZXN1bWUNCj4+
PiBpbiB0aGUgaHlwZXJ2aXNvcj8NCj4gDQo+IE5vIHN1Y2ggcGF0Y2hlcywgaXQgd2FzIHRo
aXM6DQo+IGh0dHBzOi8vZ2l0aHViLmNvbS9tYXJtYXJlay94ZW4vY29tbWl0cy9tYXN0ZXIt
Y3JlZGl0LXRpbWVycw0KPiANCj4+IFF1YmVzT1MgcnVucyB3aXRoIHNtdD0wIGJ5IGRlZmF1
bHQuwqAgU2libGluZ3Mgb3VnaHQgdG8gYmUgcGFya2VkIGF0IHRoaXMNCj4+IHBvaW50Lg0K
PiANCj4gWWVzLCBpbmRlZWQgdGhpcyB0ZXN0IHdhcyB3aXRoIHNtdD1vZmYuDQoNCkFoLCB0
aGlzIGlzIHN1YnRsZS4gVGhlIENQVV9PTkxJTkUgbm90aWZpZXJzIGFyZSBjYWxsZWQgZm9y
IHRoZSBzaWJsaW5ncywNCnRvbywgcmVzdWx0aW5nIGluIGFib3ZlIGVycm9yLg0KDQpQcmVw
YXJpbmcgVjIgb2YgdGhlIHBhdGNoLg0KDQoNCkp1ZXJnZW4NCg==
--------------p0Pnm2fL2DbFuql9tnB8BgQv
Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Description: OpenPGP public key
Content-Transfer-Encoding: quoted-printable

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri
oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2
kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i
1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B
BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK
N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg
PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE
FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F
UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye
vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u
+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq
qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP
tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ
CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4
RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7
8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T
BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ
SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM
nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB
AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/
Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN
hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi
w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf
VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP
OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK
/1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1
c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC
F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4
k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ
wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu
5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB
TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io
N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6
AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr
0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x
Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm
we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I
v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv
Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD
534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH
b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT
yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc
suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B
jR/i1DG86lem3iBDXzXsZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------p0Pnm2fL2DbFuql9tnB8BgQv--

--------------tVKpkSfc72PZx5fweGhqJxXu--

--------------dyY9gXJnoU90HCMTI0K9FZUx
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmNbtWQFAwAAAAAACgkQsN6d1ii/Ey9+
Igf/Vj33ldZyQKaRSBXqcToUGGSQ1Tuzxmwb8wJSQ/mt7y6p76KZUJudBuy3oMjFiTsK7HNEbZ0K
m0yXIZHv1VirQHnBjjCtGfIjXUhNhcA6aU11xxHeLzBMDwhKbiI7Yxt5nPPuOs63Y6udnXFaiJa/
ZVqPTvh4z7/gyMwIiruOR9S6mv1GBfUY5emw/v02KSXx4CR6cdTJ+hoRoozYEvwPDGFcJIPagMh0
Nkn59DTXKjIxSnjxe26IaKGsR9SD4P/OlqBpgImRofiDFeaFE0opP7SKoCaa1I5wPs+P+NDYuS4N
UjFTEz8w/vYl2trwyRnY+s0HcSCasn8udp+ud2aqzw==
=My0V
-----END PGP SIGNATURE-----

--------------dyY9gXJnoU90HCMTI0K9FZUx--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 10:57:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 10:57:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431906.684569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooN38-0006rK-LD; Fri, 28 Oct 2022 10:57:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431906.684569; Fri, 28 Oct 2022 10:57:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooN38-0006rD-IQ; Fri, 28 Oct 2022 10:57:18 +0000
Received: by outflank-mailman (input) for mailman id 431906;
 Fri, 28 Oct 2022 10:57:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooN37-0006qz-Sf; Fri, 28 Oct 2022 10:57:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooN37-00013U-Q2; Fri, 28 Oct 2022 10:57:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooN37-0002Iz-3n; Fri, 28 Oct 2022 10:57:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooN37-0004zu-3J; Fri, 28 Oct 2022 10:57:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NAgGqFv8KkVMRjtDFFjsvauaF+MSonML0G8TDdQoBIk=; b=zitDNBH6uIHbLjF9xoNZte6m8D
	y7cbb7zNTz+HBexTXjdv+WqN7j2za+zC519tHNGel2aiTNI/fTd24cXGVdmUwqyG3BajdYtr/1mg2
	OR8dAKz1rl1U03Bmw8j553XsqRm0FLUEb2EGEr40NTcc7dc322XrAIxsCP2NYoR56Nu0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174507-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174507: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=344744e148e6e865f5a57e745b02a87e5ea534ad
X-Osstest-Versions-That:
    qemuu=e750a7ace492f0b450653d4ad368a77d6f660fb8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 10:57:17 +0000

flight 174507 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174507/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174448
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174448
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174448
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174448
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174448
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174448
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174448
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174448
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                344744e148e6e865f5a57e745b02a87e5ea534ad
baseline version:
 qemuu                e750a7ace492f0b450653d4ad368a77d6f660fb8

Last test of basis   174448  2022-10-26 11:08:30 Z    1 days
Testing same since   174507  2022-10-27 14:30:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Andreas K. Huettel <dilfridge@gentoo.org>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng@tinylab.org>
  Cédric Le Goater <clg@kaod.org>
  Daniel P. Berrangé <berrange@redhat.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Helge Deller <deller@gmx.de>
  Janosch Frank <frankja@linux.ibm.com>
  Jiaxun Yang <jiaxun.yang@flygoat.com>
  Laurent Vivier <laurent@vivier.eu>
  Leandro Lupori <leandro.lupori@eldorado.org.br>
  lu zhipeng <luzhipeng@cestc.cn>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrick Williams <patrick@stwcx.xyz>
  Peter Delevoryas <peter@pjd.dev>
  Peter Maydell <peter.maydell@linaro.org>
  Qi Hu <huqi@loongson.cn>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Viktor Prutyanov <viktor.prutyanov@redhat.com>
  Volker Rümelin <vr_qemu@t-online.de>
  WANG Xuerui <xen0n@gentoo.org>
  Wang, Lei <lei4.wang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   e750a7ace4..344744e148  344744e148e6e865f5a57e745b02a87e5ea534ad -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:08:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:08:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431921.684580 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNDL-0000KF-K1; Fri, 28 Oct 2022 11:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431921.684580; Fri, 28 Oct 2022 11:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNDL-0000K8-HE; Fri, 28 Oct 2022 11:07:51 +0000
Received: by outflank-mailman (input) for mailman id 431921;
 Fri, 28 Oct 2022 11:07:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNDK-0000Jy-LG; Fri, 28 Oct 2022 11:07:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNDK-0001GO-J1; Fri, 28 Oct 2022 11:07:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNDJ-0002cZ-SM; Fri, 28 Oct 2022 11:07:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNDJ-0003Sw-Ru; Fri, 28 Oct 2022 11:07:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bmszWbCS3gbI4Phgdz3sNskoqjs9uOTi27GEZwXaCTI=; b=jbbJxseaOwGuTXK4ilWmT2IYcO
	6sdrKjI/1kc4neGxDF0vSPtF3kN7ifyK+j5gam61wNsAxeyFtGxL+TqlZn9/4RTn3G1q2G5Hqv9i9
	fT9vK7jhKikzeqqTKcS9na4p7X0te8vanU2pWYrxlQ+OLFpLFR8oYnK2hnDwtHbVhHcg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174528-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174528: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=d98efb468211ab508710eac91761238e1f5c1d51
X-Osstest-Versions-That:
    ovmf=99338ef81ed6e48be57f71c01af85fbbdd7030ed
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 11:07:49 +0000

flight 174528 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174528/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 d98efb468211ab508710eac91761238e1f5c1d51
baseline version:
 ovmf                 99338ef81ed6e48be57f71c01af85fbbdd7030ed

Last test of basis   174512  2022-10-27 17:10:28 Z    0 days
Testing same since   174528  2022-10-28 09:11:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dun Tan <dun.tan@intel.com>
  Tan, Dun <dun.tan@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   99338ef81e..d98efb4682  d98efb468211ab508710eac91761238e1f5c1d51 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:11:17 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:11:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431928.684591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNGe-0001hc-4y; Fri, 28 Oct 2022 11:11:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431928.684591; Fri, 28 Oct 2022 11:11:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNGe-0001hV-1B; Fri, 28 Oct 2022 11:11:16 +0000
Received: by outflank-mailman (input) for mailman id 431928;
 Fri, 28 Oct 2022 11:11:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1zj9=25=citrix.com=prvs=2939fe9fd=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1ooNGd-0001hP-4q
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:11:15 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38e57d36-56b1-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 13:11:10 +0200 (CEST)
Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO
 NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 07:11:06 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by BN8PR03MB4961.namprd03.prod.outlook.com (2603:10b6:408:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 11:11:04 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5746.028; Fri, 28 Oct 2022
 11:11:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38e57d36-56b1-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666955471;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=p/Uo5j8AgtoGCHO+zF3Av/+B03tT0g/tCM4dc8+0L9U=;
  b=YXv9TDMAqBg6wZ+T6y8bHPpLjfFErUevf2PWXNs7Gipemeogr6bD1nT9
   jsx1k6nJz3tWcZTn9rVmk1gpbIULZu2XHZi/4mmYaN9tcIFSPyIwFiDUQ
   sEx9nAQgSw5B0NJyYveDzJvu5GZIugCgdXjWK4d+MIATeev5N3gvlwq4V
   4=;
X-IronPort-RemoteIP: 104.47.66.49
X-IronPort-MID: 86236213
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:dLjweK+pEbQe4W0Od6wUDrUDv3+TJUtcMsCJ2f8bNWPcYEJGY0x3z
 mQYX26FMqrYZGTxfNp3aNji8B5VsJ6Gy9dlGgc5qCk8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s
 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk
 d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPaob5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb
 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk
 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkluy
 sIqcxogYSugqO6swO6ic+ZthMEseZyD0IM34hmMzBn/JNN/G9XmfP+P4tVVmjAtmspJAPDSI
 dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTaNilAguFTuGIO9ltiibMNZhEuH4
 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurBthJSufhrZaGhnWK20AuEwEyRGK2uMTnuEW8Uv1+L
 2o9r39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9BU8PYzUVCzQM5dbLqZs2yBnIS75e/LWdi9T0HXT13
 GqMpS1n3bEL15ZXhuO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l
 CBss6CjAComV/lhSATlrD0xIYyU
IronPort-HdrOrdr: A9a23:FXaUGa1mckcXGb0ifDpGeQqjBRFyeYIsimQD101hICG9Lfb0qy
 n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM
 hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH
 Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy
 zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O
 UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod
 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP
 hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/
 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ
 CES19cvX5aQTObNSRP5uw/zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY
 fABK5r
X-IronPort-AV: E=Sophos;i="5.95,220,1661832000"; 
   d="scan'208";a="86236213"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AQcWRTtAA86ycBb577T9WrQl75Qa/I9s6Ll2j77d7ayAb4VEkt9NE9wK9XGVFwAOgGFvtl/I8wLp46h6kSAyv6EtwctmmpM6vD3MDN2TJFU/RF538hvXiJelbE7JMJHlcCGtaBSYc4CHryeRzUm8mppwXtsaRy17Ol9TL+sMigcDU3PphbVFJc7EWMeeFULLHbdm1Wmt+xEJvWGF4HOPsWV5hsLZMO6DSB9hAOws8Cbjl/P81Q1woOvZscLExfawhqi6hg1dsC9brQeb/BSbK5dRqu4VYMtLw/zQa0ULXsO6PkqVgCSP0y0gm/JIoDsQCBHxURlQbzPuyFEYEZcRwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=p/Uo5j8AgtoGCHO+zF3Av/+B03tT0g/tCM4dc8+0L9U=;
 b=TiT/IT5pENTDfD6RtjrenokeL4WmbWCYfKWiIcCClChk5ztclDVuMjhP8J0tM8aSFDufloonmMa4q+jMc6Pa4TzAuvY5YQSSqudFd+5HjSJbt9M0K9kVb/OBlm+08Kz4VytK0Z74ser4cBYDXx6ZHG6u0XXeiqLFnRCYGYwTmULFEpzeS6VyjrfpkdxEDBjmZ2i9dRQFhY8iiAnDwrsKU2RSHHXpiCa/Xcm5X4rQM46ygTMSGAIe/oBQ84OmMAQqZElIvvagjgvm3kTByp0jgSItIOk6fAzJkUy1sJHXPsFToihSNs0w+pX6Roe+fAi32j28/dbWD4K/FVQmZ3iWaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=p/Uo5j8AgtoGCHO+zF3Av/+B03tT0g/tCM4dc8+0L9U=;
 b=XQKJlLTdOcYV05jguGlHe36whL7zCJKWMXzYLQobGLTrJtOOK9JxiFOcvWtO1YBndfaHFrds1inCkgOZtaIcpDAazG805lsP/H5m5Aq+INTBp5fj24yHM8NRoV6/L/A/XFoGnhhjDZKvj8cYmEUYOwfCpQmWwpJGpKu7xRxMsRo=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, Henry Wang
	<Henry.Wang@arm.com>, George Dunlap <George.Dunlap@citrix.com>
Subject: Re: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes
Thread-Topic: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes
Thread-Index: AQHY6p3LXAPNFfdZH06/96aDJvU0V64jprOA
Date: Fri, 28 Oct 2022 11:11:03 +0000
Message-ID: <e8e062ac-5791-2f72-ba35-d8f86e452fa0@citrix.com>
References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
In-Reply-To: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BN8PR03MB4961:EE_
x-ms-office365-filtering-correlation-id: 7081f251-47c8-44b3-9713-08dab8d51a6f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 WBmEgjSP29POq/Zu0YfqpktYm1MM40iddkuInNeMRJ10roGEB8DTUBuVH3NkpB7I7JC/ciYWsWT5mxpF7+rciklzVdVDIoQjmszELZoXj8+mOsUbTHJB+1cCxwLJLgmxkFCof04AbFYU82CYA6q99pJX0/oqGvzKhkTAbvNooUnypSzioKn+qdMWHTR2MAu8v1xltgzgQeA63tJsvUR04sDJMjdKCxY6DJ6PbER5qjORB2Re3nMhrGZESNDlqVYeE/oQ+J1XhxBwOJuI1CwfeS87PpGO/GtJr+yELtW3W7m7uf9aieWwJAjifmE9+Kp+aFigJ+ZUnClsIdGonwQF2B5QoiRF5V6oRYsZOCNQcKN1JgxIEaXjDLNcUcpBkS0gQY5YILoz8iN22EQkYMudp34uoH5aXO/n9DjlMy3tT3bd+OQxCatwfY/c7uhxR8uz8LUAwaDzbY9qScBYPqOKT4XzyDNqDz4U0IgBFmKX49KmEamUqzw1hAyL9S+i03IRcTkso8OhsTjOdiQR39uARHo/gY938xqzSZX/7/TlVkGbwpYeb14pwn90Qv9qEcuVbCmz7IWcGPFbrsKDqyL82fKtw0qUoJWRu87EuVC8bCUem9lqRACsgYqFTSVl6SdVQ5+SbKtQ3RBiM89cirCBeK6hG59BG4YB30gFrHsYMK0w7ktwIFncGS30T0LTB7OieyLEe99Qkk93bxOuu8bwlnJndJ32G5HoVQtSXOJRsN0MuJGhp7XfXe6KM9z9bDp1AlzlvhoUIdVpI/EWq3h/Py14HlyXLK2GbG1lml+mOxrv241CgCSV4jcplK9MMadYiNRFEBzAMmjRUClHPWAUZw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(396003)(346002)(39860400002)(376002)(451199015)(31686004)(83380400001)(36756003)(82960400001)(4744005)(122000001)(5660300002)(2906002)(38100700002)(86362001)(31696002)(38070700005)(2616005)(186003)(6512007)(53546011)(107886003)(26005)(6486002)(91956017)(71200400001)(478600001)(316002)(54906003)(110136005)(41300700001)(8936002)(66946007)(4326008)(8676002)(66446008)(66476007)(66556008)(64756008)(76116006)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?VVFKVEZ5VnFJRHoyazQrMU5wQ28wVEU1VmRxYjhXTmI3YkltT2c4MW9iRllL?=
 =?utf-8?B?eVZoSnExMmE5SnNiU3dxNGt3a1E5aldpQmlaN0xMT04vSnM3eHoya251bW1O?=
 =?utf-8?B?ajU0ZmhsQ0wwQm5XMmIxbS9vam5CUmx0SlVWL1dJUE9kYzlGaTRPRERpc0ZE?=
 =?utf-8?B?TTFwRGY4dW90WGdUYWY3TmFrOWhZa3oyYWV2MnlRUWRxcENIN3BnYWFoMWJo?=
 =?utf-8?B?MnRscng3anhWaDFGNFZ5SitPK2xXQnN5aVlBMUp2TXdOZVFYQVNsb2x0RFgv?=
 =?utf-8?B?R29MbEtibFlaV0Z5ei9tVk9rOTlsRnE4Wjh1dllJM0VacFFmSFBWT0pJdmZY?=
 =?utf-8?B?cXFjamVKbmJHNXloWExxcnFhNVBhZlFuVy80OTFUVDZ1NUVRZDliRGp5ZXZa?=
 =?utf-8?B?bFVxWVpWbWtPazF4RWd1RVgyRHVXaUczYml1WEd6S3dKa2tqQy9MOERqYWdv?=
 =?utf-8?B?bDREcE1QWFlWMFBncnNtZ1JRWDJPYS8rcGdKMGU1S3Q5UlRLemptdEFvaFRD?=
 =?utf-8?B?Zk1CRUlnQno1Vmc0MzNxTUkyRU5KcEhwdEJpMHNmc1N2RHo2c1BMMTgvK3NN?=
 =?utf-8?B?WGNUczNNVzZPR0VEcFZ1NDNVOU1GdDJkellYNUdIM1M1MUtZYkluNjk2bnVa?=
 =?utf-8?B?MEFLbG5ZK3hlblZadVlBbm8xYkVjeW1kTmUvb2Q1TTRYVFBEbUxZeDdPdG1P?=
 =?utf-8?B?d1l1RkZSdHNtRVJBbXRoWWpYREdBV29aeUtXbkIxTm4wQVdPZ0JVK2tKYyth?=
 =?utf-8?B?Z1dwS1ZYYU0vZGYzZ29FZ2dLMVdFYTh4dWtyS3RqSTFBWkxWbE5PSnh4VUJW?=
 =?utf-8?B?U3N4Q2F1ZldxSFFBRVZTQkJUSnkrV2x0N1dXMHpKS1hmT1cwUDd3Y0tBT2xK?=
 =?utf-8?B?bldSeFQ4OGZzaFhtcU9OMXNXT0NVdm0wa0Z4U3EwTzVUM01yNURxWDd1UUdh?=
 =?utf-8?B?Z3hUdjVtekdya1ZucFFlOE5DVjhKOGEwdmZTM3RWMWxKeVZ4MWpyMmVYRWVR?=
 =?utf-8?B?QlpSQnNtOWttcWVQMVY1ZWhDTzJrVEdKYnRVdzB1U09nektZYi85c3RhU0FQ?=
 =?utf-8?B?RituYkJvWVVLZEN2S0lZQVo1a1BzRjVTZkZhdzRKSGRXUTA5WmZCOExYdkky?=
 =?utf-8?B?RFVab29NUHFPVGs4RjIzRmtQWlVWUnB4aFFvUVozTnpjbUdFYnBHUzVPb3ZX?=
 =?utf-8?B?clFKdUZ4UVdaOWxTMXdNaGZRaTVEcWxKMTR2dkpNMEVoTE9mK2hIVmNBelVp?=
 =?utf-8?B?bTZwN3JrWU5UakQ1OWFWK2ZRSnU4ODQ4aW9Fa1lnZTQ4OC9vT045SUN6Rzla?=
 =?utf-8?B?NnBQdXp1di9YS2I2Mm8rN2NabHVoeWs5bWRrS1lSeW8ySUIyWnVwMFFiS0pI?=
 =?utf-8?B?STJ6SXZvRG9oRW15bUQvQzRoRW5ybDYzS3oxbDdPdTlkME11aGtOV3orQWZZ?=
 =?utf-8?B?S1NxQ1g2N3pXL013K3RXSUFFMEJlQjdDTGFENlF3Vm9yUnArRnczS2MzQVZl?=
 =?utf-8?B?L1JFU2FZTVdJSHZ0alJkM1FCdGYrajVGdHBvZmNSYmhlR3BOR3lCTDFZV1hF?=
 =?utf-8?B?ekd0RjF5c3JzaCtGZmRCNFhQdFFqY3BGaXJCdUE5aWIrZW43TjZuTGdwcFJ0?=
 =?utf-8?B?SjFsc3JKSUlNaW1KMFFXZEc2cXpUMmNEb1M5dys1Ynp6YUFlV1Y4b2RhQnZK?=
 =?utf-8?B?M0p5RkRTM2hrQjZ6QnVrd055UWZNUzBLZVhmeWZUTHg1bStuclpRR1dQQVZp?=
 =?utf-8?B?aGlnK2dudnVtUlM0ekxFM2w2TTBJQVZOc3FvOFNvR2lmM0FCODdKd1VkRytx?=
 =?utf-8?B?Z0tzdjg4akE4NVlhNXJRZUNTbkNkRXRJN3NnTkhoSllWT2dyV1BZZW1uVy95?=
 =?utf-8?B?ZTdGMytuVlB0ZDN6cktVcFFOOWtzTWVObFA5OGJ3dmtDVDMwZ3N5NnFDRlFi?=
 =?utf-8?B?RkMrSjlkUzdYUXBYcjM4NGFBUE9PZmxiZWNxZHJQLzhnTjdsUmlrZWpGaDJJ?=
 =?utf-8?B?UnhFU0pRZVlyY2t2UUsrRHUvK2tPdzFhSitSeVhOMGVRM3lvVVQwVThSL3Zi?=
 =?utf-8?B?bVBRNEpJdHZkeHFTRnltMkIwc29uSVJIM3kybC9ZK09qY0hWNURnZVhRYVc2?=
 =?utf-8?Q?PMZLRa+AhbZm5LUUGpeB00NLo?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <16DEA34C07C99642BAE2E048DB6FC540@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7081f251-47c8-44b3-9713-08dab8d51a6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 11:11:03.7255
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F/tM7ZzSL6olNomfEUqO9uBv+oulpxdEBmYgG/fcZ8MAOPErzo54rG0mTqB2XTdMvFECV90Yyv+9FB7XbD1zUD6zTxE7bP/khf5eOpnANfo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4961

T24gMjgvMTAvMjAyMiAwODoyMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZXNlIHBhdGNoZXMg
aGF2ZSAoYXMgYSBzaW5nbGUsIG1vbm9saXRoaWMgb25lKSBiZWVuIGxpdmluZyBpbg0KPiB0aGUg
WGVuU2VydmVyIHBhdGNoIHF1ZXVlIGZvciBxdWl0ZSBzb21lIHRpbWUuIFdoaWxlIHByZXBhcmlu
ZyBmb3INCj4gdGhpcyB1cHN0cmVhbSBzdWJtaXNzaW9uLCBJJ3ZlIGxlZnQgdGhlIGNvZGUgbGFy
Z2VseSBhcyBpcyAob25seSBhDQo+IGZldyBjb3NtZXRpYyBhZGp1c3RtZW50cywgYnV0IG5vIGZ1
bmN0aW9uYWwgY2hhbmdlcyksIHNvIHRoZSBzZXJpZXMNCj4gY2FuIGJlIGFzc3VtZWQgdG8gaGF2
ZSBiZWVuIHByb3Blcmx5IHRlc3RlZC4gV2hhdCBJIGRpZCBmdWxseSBhbHRlcg0KPiB0aG91Z2gg
YXJlIHRoZSBkZXNjcmlwdGlvbnMuDQo+DQo+IDE6IGNvcnJlY3RseSBpZ25vcmUgZW1wdHkgb25s
aW5pbmcgcmVxdWVzdHMNCj4gMjogY29ycmVjdCBiYWxsb29uaW5nIHVwIGZvciBjb21wYXQgZ3Vl
c3RzDQo+IDM6IGNvcnJlY3QgYmFsbG9vbmluZyBkb3duIGZvciBjb21wYXQgZ3Vlc3RzDQoNClRo
YW5rcyBmb3IgZG9pbmcgdGhpcy7CoCBGcm9tIG91ciBzaWRlLCB0aGV5IGFsbCBjYW1lIGZyb20g
dGVzdGluZyB3aGVyZQ0Kd2UgdG9vayBvdXIgZXhpc3RpbmcgUFYgZ3Vlc3QgdGVzdHMgYW5kIHJh
biB0aGUgZ3Vlc3RzIHNoaW1tZWQuDQoNCkknbSByZWFzb25hYmx5IHN1cmUgdGhlcmUgYXJlIG1v
cmUgaXNzdWVzIGx1cmtpbmcsIGJ1dCB0aGlzIGlzDQpkZWZpbml0ZWx5IGFuIGltcHJvdmVtZW50
IG9uIGl0cyBvd24uDQoNClRoZXkgd2FudCBiYWNrcG9ydGluZyAoaW4gZHVlIGNvdXJzZSksIHNv
IHNob3VsZCBiZSBjb25zaWRlcmVkIGZvciA0LjE3DQpzZWVpbmcgYXMgdGhleSdyZSByZWFkeSBu
b3cuDQoNCkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t
Pg0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:12:42 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:12:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431933.684601 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNI0-0002Kf-Ih; Fri, 28 Oct 2022 11:12:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431933.684601; Fri, 28 Oct 2022 11:12:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNI0-0002KY-Fz; Fri, 28 Oct 2022 11:12:40 +0000
Received: by outflank-mailman (input) for mailman id 431933;
 Fri, 28 Oct 2022 11:12:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mkji=25=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ooNHy-0002KQ-Tc
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:12:38 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6e1ae8ae-56b1-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 13:12:37 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4FC0021A85;
 Fri, 28 Oct 2022 11:12:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 17F4113A6E;
 Fri, 28 Oct 2022 11:12:37 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id D9uABCW5W2P/TwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 28 Oct 2022 11:12:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e1ae8ae-56b1-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666955557; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=j/uXZWR0Y09frVHqDvAjUFf/jg9CEWFfCGlYbYkqxx8=;
	b=ai6GCEkI7U+GPzD+8gEt3n0YtehKga+XFrJA2qfG3Jli6xsgBZ1rqPkJ90k29WnJrR2GMI
	VYQ1J6MNOoLUP/T1PFbUXScW2SDMYaleJFDmM7dRkcen/Mfcc2IB8Eo57yxy8AARmlzC8R
	yLdj5mHXdvc7wFGDE0vIgIZxPyLCPPE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Meng Xu <mengxu@cis.upenn.edu>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH-for-4.17 v2] xen/sched: migrate timers to correct cpus after suspend
Date: Fri, 28 Oct 2022 13:12:31 +0200
Message-Id: <20221028111231.31355-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Today all timers are migrated to cpu 0 when the system is being
suspended. They are not migrated back after resuming the system again.

This results (at least) to problems with the credit scheduler, as the
timer isn't handled on the cpu it was expected to occur.

Add migrating the scheduling related timers of a specific cpu from cpu
0 back to its original cpu when that cpu has gone up when resuming the
system.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- fix smt=0 case (Marek Marczykowski-Górecki)
---
 xen/common/sched/core.c    | 26 +++++++++++++++++
 xen/common/sched/cpupool.c |  2 ++
 xen/common/sched/credit.c  | 13 +++++++++
 xen/common/sched/private.h | 10 +++++++
 xen/common/sched/rt.c      | 58 ++++++++++++++++++++++++++------------
 5 files changed, 91 insertions(+), 18 deletions(-)

diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 23fa6845a8..0f577e472b 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -1284,6 +1284,32 @@ static int cpu_disable_scheduler_check(unsigned int cpu)
     return 0;
 }
 
+/*
+ * Called after a cpu has come up again in a suspend/resume cycle.
+ * Note that on a system with smt=0 this will be called for the sibling cpus,
+ * too, so the case for no scheduling resource being available must be
+ * considered.
+ * Migrate all timers for this cpu (they have been migrated to cpu 0 when the
+ * cpu was going down).
+ * Note that only timers related to a physical cpu are migrated, not the ones
+ * related to a vcpu or domain.
+ */
+void sched_migrate_timers(unsigned int cpu)
+{
+    struct sched_resource *sr;
+
+    rcu_read_lock(&sched_res_rculock);
+
+    sr = get_sched_res(cpu);
+    if ( sr && sr->master_cpu == cpu )
+    {
+        migrate_timer(&sr->s_timer, cpu);
+        sched_move_timers(sr->scheduler, sr);
+    }
+
+    rcu_read_unlock(&sched_res_rculock);
+}
+
 /*
  * In general, this must be called with the scheduler lock held, because the
  * adjust_affinity hook may want to modify the vCPU state. However, when the
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index b2c6f520c3..bdf6030ab0 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1035,6 +1035,8 @@ static int cf_check cpu_callback(
     case CPU_ONLINE:
         if ( system_state <= SYS_STATE_active )
             rc = cpupool_cpu_add(cpu);
+        else
+            sched_migrate_timers(cpu);
         break;
     case CPU_DOWN_PREPARE:
         /* Suspend/Resume don't change assignments of cpus to cpupools. */
diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c
index 47945c2834..f2cd3d9da3 100644
--- a/xen/common/sched/credit.c
+++ b/xen/common/sched/credit.c
@@ -614,6 +614,18 @@ init_pdata(struct csched_private *prv, struct csched_pcpu *spc, int cpu)
     spc->nr_runnable = 0;
 }
 
+static void cf_check
+csched_move_timers(const struct scheduler *ops, struct sched_resource *sr)
+{
+    struct csched_private *prv = CSCHED_PRIV(ops);
+    struct csched_pcpu *spc = sr->sched_priv;
+
+    if ( sr->master_cpu == prv->master )
+        migrate_timer(&prv->master_ticker, prv->master);
+
+    migrate_timer(&spc->ticker, sr->master_cpu);
+}
+
 /* Change the scheduler of cpu to us (Credit). */
 static spinlock_t *cf_check
 csched_switch_sched(struct scheduler *new_ops, unsigned int cpu,
@@ -2264,6 +2276,7 @@ static const struct scheduler sched_credit_def = {
     .switch_sched   = csched_switch_sched,
     .alloc_domdata  = csched_alloc_domdata,
     .free_domdata   = csched_free_domdata,
+    .move_timers    = csched_move_timers,
 };
 
 REGISTER_SCHEDULER(sched_credit_def);
diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h
index 0126a4bb9e..0527a8c70d 100644
--- a/xen/common/sched/private.h
+++ b/xen/common/sched/private.h
@@ -331,6 +331,8 @@ struct scheduler {
                                     struct xen_sysctl_scheduler_op *);
     void         (*dump_settings)  (const struct scheduler *);
     void         (*dump_cpu_state) (const struct scheduler *, int);
+    void         (*move_timers)    (const struct scheduler *,
+                                    struct sched_resource *);
 };
 
 static inline int sched_init(struct scheduler *s)
@@ -485,6 +487,13 @@ static inline int sched_adjust_cpupool(const struct scheduler *s,
     return s->adjust_global ? s->adjust_global(s, op) : 0;
 }
 
+static inline void sched_move_timers(const struct scheduler *s,
+                                     struct sched_resource *sr)
+{
+    if ( s->move_timers )
+        s->move_timers(s, sr);
+}
+
 static inline void sched_unit_pause_nosync(const struct sched_unit *unit)
 {
     struct vcpu *v;
@@ -622,6 +631,7 @@ struct cpu_rm_data *alloc_cpu_rm_data(unsigned int cpu, bool aff_alloc);
 void free_cpu_rm_data(struct cpu_rm_data *mem, unsigned int cpu);
 int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *mem);
 int sched_move_domain(struct domain *d, struct cpupool *c);
+void sched_migrate_timers(unsigned int cpu);
 struct cpupool *cpupool_get_by_id(unsigned int poolid);
 void cpupool_put(struct cpupool *pool);
 int cpupool_add_domain(struct domain *d, unsigned int poolid);
diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index 1f8d074884..d443cd5831 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -750,6 +750,27 @@ rt_switch_sched(struct scheduler *new_ops, unsigned int cpu,
     return &prv->lock;
 }
 
+static void move_repl_timer(struct rt_private *prv, unsigned int old_cpu)
+{
+    cpumask_t *online = get_sched_res(old_cpu)->cpupool->res_valid;
+    unsigned int new_cpu = cpumask_cycle(old_cpu, online);
+
+    /*
+     * Make sure the timer run on one of the cpus that are still available
+     * to this scheduler. If there aren't any left, it means it's the time
+     * to just kill it.
+     */
+    if ( new_cpu >= nr_cpu_ids )
+    {
+        kill_timer(&prv->repl_timer);
+        dprintk(XENLOG_DEBUG, "RTDS: timer killed on cpu %d\n", old_cpu);
+    }
+    else
+    {
+        migrate_timer(&prv->repl_timer, new_cpu);
+    }
+}
+
 static void cf_check
 rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
 {
@@ -759,25 +780,25 @@ rt_deinit_pdata(const struct scheduler *ops, void *pcpu, int cpu)
     spin_lock_irqsave(&prv->lock, flags);
 
     if ( prv->repl_timer.cpu == cpu )
-    {
-        cpumask_t *online = get_sched_res(cpu)->cpupool->res_valid;
-        unsigned int new_cpu = cpumask_cycle(cpu, online);
+        move_repl_timer(prv, cpu);
 
-        /*
-         * Make sure the timer run on one of the cpus that are still available
-         * to this scheduler. If there aren't any left, it means it's the time
-         * to just kill it.
-         */
-        if ( new_cpu >= nr_cpu_ids )
-        {
-            kill_timer(&prv->repl_timer);
-            dprintk(XENLOG_DEBUG, "RTDS: timer killed on cpu %d\n", cpu);
-        }
-        else
-        {
-            migrate_timer(&prv->repl_timer, new_cpu);
-        }
-    }
+    spin_unlock_irqrestore(&prv->lock, flags);
+}
+
+static void cf_check
+rt_move_timers(const struct scheduler *ops, struct sched_resource *sr)
+{
+    unsigned long flags;
+    struct rt_private *prv = rt_priv(ops);
+    unsigned int old_cpu;
+
+    spin_lock_irqsave(&prv->lock, flags);
+
+    old_cpu = prv->repl_timer.cpu;
+    if ( prv->repl_timer.status != TIMER_STATUS_invalid &&
+         prv->repl_timer.status != TIMER_STATUS_killed &&
+         !cpumask_test_cpu(old_cpu, sr->cpupool->res_valid) )
+        move_repl_timer(prv, old_cpu);
 
     spin_unlock_irqrestore(&prv->lock, flags);
 }
@@ -1561,6 +1582,7 @@ static const struct scheduler sched_rtds_def = {
     .sleep          = rt_unit_sleep,
     .wake           = rt_unit_wake,
     .context_saved  = rt_context_saved,
+    .move_timers    = rt_move_timers,
 };
 
 REGISTER_SCHEDULER(sched_rtds_def);
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:24:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:24:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431940.684613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNTC-00047q-LF; Fri, 28 Oct 2022 11:24:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431940.684613; Fri, 28 Oct 2022 11:24:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNTC-00047j-IC; Fri, 28 Oct 2022 11:24:14 +0000
Received: by outflank-mailman (input) for mailman id 431940;
 Fri, 28 Oct 2022 11:24:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNTB-00047Z-5y; Fri, 28 Oct 2022 11:24:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNTB-0001Wp-1B; Fri, 28 Oct 2022 11:24:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNTA-00032A-Lq; Fri, 28 Oct 2022 11:24:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooNTA-0002tl-LH; Fri, 28 Oct 2022 11:24:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oLbT8U6f0g5GQPConvl2ZuGu7UkYC9siE13W9Hvocyo=; b=afGKfczID9bqhRbCTg3ZxpVLM5
	Qn900bq3ou0GXizBu3AhEQ6UMcCsSv6gveAvIpZxH7FCtidFZg1tDEvXMCnBHl8aKRFkYOwNvpNoW
	CFhfZ/z7nSdZip49OBTwFx6PVQMnmikv6hV6eZJDXQU4gBEck62QbTZ5mLb19wkwEGH4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174511-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174511: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-xl-vhd:<job status>:broken:regression
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-vhd:capture-logs(14):broken:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fe18f1af38a7999e05a6564c80d63e8d9df5ee60
X-Osstest-Versions-That:
    linux=fd92cfed8bc6668d314acd1e6da708a80826f768
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 11:24:12 +0000

flight 174511 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174511/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl-vhd         <job status>                 broken  in 174450
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail in 174450 REGR. vs. 174012

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-vhd      13 guest-start      fail in 174450 pass in 174511
 test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10  fail pass in 174450
 test-armhf-armhf-xl-multivcpu 14 guest-start               fail pass in 174450
 test-armhf-armhf-libvirt-qcow2 13 guest-start              fail pass in 174450

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd 14 capture-logs(14) broken in 174450 blocked in 174012
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 174012
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174450 like 174012
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174450 like 174012
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174450 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174450 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174450 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-xl-credit1  18 guest-start/debian.repeat    fail  like 174012
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174012
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174012
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat    fail  like 174012
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174012
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174012
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                fe18f1af38a7999e05a6564c80d63e8d9df5ee60
baseline version:
 linux                fd92cfed8bc6668d314acd1e6da708a80826f768

Last test of basis   174012  2022-10-17 16:21:11 Z   10 days
Testing same since   174450  2022-10-26 11:42:18 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Ahmad Fatoum <a.fatoum@pengutronix.de>
  Albert Briscoe <albertsbriscoe@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Coffin <alex.coffin@matician.com>
  Alexander Dahl <ada@thorsis.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexei Starovoitov <ast@kernel.org>
  Alexey Lyashkov <alexey.lyashkov@gmail.com>
  Allen Pais <apais@linux.microsoft.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Andreas Pape <apape@de.adit-jv.com>
  Andrew Bresticker <abrestic@rivosinc.com>
  Andrew Gaul <gaul@gaul.org>
  Andrew Gaul <gaul@google.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrew Perepechko <anserper@ya.ru>
  Andri Yngvason <andri@yngvason.is>
  Andrii Nakryiko <andrii@kernel.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Anssi Hannula <anssi.hannula@bitwise.fi>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Arvid Norlander <lkml@vorpal.se>
  Baokun Li <libaokun1@huawei.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bernard Metzler <bmt@zurich.ibm.com>
  Bitterblue Smith <rtl8821cerfe2@gmail.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Callum Osmotherly <callum.osmotherly@gmail.com>
  Carlos Llamas <cmllamas@google.com>
  Chao Qin <chao.qin@intel.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wenst@chromium.org>
  Chi-hsien Lin <chi-hsien.lin@cypress.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Chuck Lever <chuck.lever@oracle.com>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Coly Li <colyli@suse.de>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Golle <daniel@makrotopia.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Jiang <dave.jiang@intel.com>
  David Collins <collinsd@codeaurora.org>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  David Teigland <teigland@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <dmitry.osipenko@collabora.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eddie James <eajames@linux.ibm.com>
  Eric Dumazet <edumazet@google.com>
  Eugeniu Rosca <erosca@de.adit-jv.com>
  Fangrui Song <maskray@google.com>
  Fenglin Wu <quic_fenglinw@quicinc.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Haibo Chen <haibo.chen@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Hari Chandrakanthan <quic_haric@quicinc.com>
  Hawkins Jiawei <yin31149@gmail.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hillf Danton <hdanton@sina.com>
  hongao <hongao@uniontech.com>
  Huacai Chen <chenhuacai@loongson.cn>
  Hyunwoo Kim <imv4bel@gmail.com>
  Ian Nam <young.kwan.nam@xilinx.com>
  Ignat Korchagin <ignat@cloudflare.com>
  Ingo Molnar <mingo@kernel.org>
  Jack Wang <jinpu.wang@ionos.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jason Baron <jbaron@akamai.com>
  Jassi Brar <jaswinder.singh@linaro.org>
  Javier Martinez Canillas <javierm@redhat.com>
  Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
  Jens Axboe <axboe@kernel.dk>
  Jerry Lee <jerrylee@qnap.com>
  Jerry Lee 李修賢 <jerrylee@qnap.com>
  Jes Sorensen <Jes.Sorensen@gmail.com>
  Jianglei Nie <niejianglei2021@163.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jim Cromie <jim.cromie@gmail.com>
  Jimmy Assarsson <extja@kvaser.com>
  Jinke Han <hanjinke.666@bytedance.com>
  Jiri Kosina <jkosina@suse.cz>
  Joel Stanley <joel@jms.id.au>
  Joerg Roedel <jroedel@suse.de>
  Johannes Berg <johannes.berg@intel.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Junichi Uekawa <uekawa@chromium.org>
  Kalle Valo <kvalo@kernel.org>
  Kalle Valo <quic_kvalo@quicinc.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Keith Busch <kbusch@kernel.org>
  Kevin(Yudong) Yang <yyd@google.com>
  Khalid Masum <khalid.masum.92@gmail.com>
  Koba Ko <koba.ko@canonical.com>
  Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
  Lalith Rajendran <lalithkraj@google.com>
  Lam Thai <lamthai@arista.com>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Lee Jones <lee@kernel.org>
  Leon Romanovsky <leon@kernel.org>
  Letu Ren <fantasquex@gmail.com>
  Liang He <windhl@126.com>
  Liang Yang <liang.yang@amlogic.com>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Liu Jian <liujian56@huawei.com>
  Logan Gunthorpe <logang@deltatee.com>
  Lorenz Bauer <oss@lmb.io>
  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Luke D. Jones <luke@ljones.dev>
  Lyude Paul <lyude@redhat.com>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Behún <kabel@kernel.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Liska <mliska@suse.cz>
  Masahiro Yamada <masahiroy@kernel.org>
  Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Maya Matuszczyk <maccraft123mc@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Hennerich <michael.hennerich@analog.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Michal Luczaj <mhal@rbox.co>
  Michal Simek <michal.simek@amd.com>
  Mike Pattrick <mkp@redhat.com>
  Mingzhe Zou <mingzhe.zou@easystack.cn>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nam Cao <namcaov@gmail.com>
  Namhyung Kim <namhyung@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Nicolas Dufresne <nicolas.dufresne@collabora.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Ninad Naik <ninad.naik@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Olga Kornievskaia <kolga@netapp.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Ondrej Mosnacek <omosnace@redhat.com>
  Pali Rohár <pali@kernel.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paul Moore <paul@paul-moore.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Oberparleiter <oberpar@linux.ibm.com>
  Peter Robinson <pbrobinson@gmail.com>
  Peter Rosin <peda@axentia.se>
  Peter Xu <peterx@redhat.com>
  Petr Mladek <pmladek@suse.com>
  Phil Sutter <phil@nwl.cc>
  Philipp Hortmann <philipp.g.hortmann@gmail.com>
  Qu Wenruo <wqu@suse.com>
  Quanyang Wang <quanyang.wang@windriver.com>
  Quentin Monnet <quentin@isovalent.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Reinette Chatre <reinette.chatre@intel.com>
  Rich Felker <dalias@libc.org>
  Richard Acayan <mailingradian@gmail.com>
  Richard Weinberger <richard@nod.at>
  Rik van Riel <riel@surriel.com>
  Rob Clark <robdclark@chromium.org>
  Robert Foss <robert.foss@linaro.org>
  Robin Guo <guoweibin@inspur.com>
  Robin Murphy <robin.murphy@arm.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rustam Subkhankulov <subkhankulov@ispras.ru>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Saranya Gopal <saranya.gopal@intel.com>
  Sasha Levin <sashal@kernel.org>
  Saurabh Sengar <ssengar@linux.microsoft.com>
  Sean Christopherson <seanjc@google.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Shawn Guo <shawnguo@kernel.org>
  Sherry Sun <sherry.sun@nxp.com>
  Shigeru Yoshida <syoshida@redhat.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slade Watkins <srw@sladewatkins.net>
  Song Liu <song@kernel.org>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Steffen Klassert <steffen.klassert@secunet.com>
  Stephen Boyd <sboyd@kernel.org>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  sunghwan jung <onenowy@gmail.com>
  Sungwoo Kim <iam@sung-woo.kim>
  syzbot <syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com>
  syzbot+5ec9bb042ddfe9644773@syzkaller.appspotmail.com
  Tadeusz Struk<tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Tales Aparecida <tales.aparecida@gmail.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Thara Gopinath <tgopinath@microsoft.com>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Zimmermann <tzimmermann@suse.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Tzung-Bi Shih <tzungbi@kernel.org>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vinod Koul <vkoul@kernel.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wang Kefeng <wangkefeng.wang@huawei.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wen Gong <quic_wgong@quicinc.com>
  Wenchao Chen <wenchao.chen@unisoc.com>
  William Dean <williamsukatube@gmail.com>
  Wright Feng <wright.feng@cypress.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Qiang <xuqiang36@huawei.com>
  Yonghong Song <yhs@fb.com>
  Yuchung Cheng <ycheng@google.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
  Zheng Yejian <zhengyejian1@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhu Yanjun <yanjun.zhu@linux.dev>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl-vhd broken

Not pushing.

(No revision log; it would be 7597 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:41:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431971.684624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNjh-0007DN-8u; Fri, 28 Oct 2022 11:41:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431971.684624; Fri, 28 Oct 2022 11:41:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNjh-0007DG-5L; Fri, 28 Oct 2022 11:41:17 +0000
Received: by outflank-mailman (input) for mailman id 431971;
 Fri, 28 Oct 2022 11:41:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Mkji=25=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1ooNjf-0007DA-41
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:41:15 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6cb6a2bf-56b5-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 13:41:13 +0200 (CEST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D01281F8CD;
 Fri, 28 Oct 2022 11:41:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7710B1377D;
 Fri, 28 Oct 2022 11:41:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sCCpG9i/W2P3XQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 28 Oct 2022 11:41:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cb6a2bf-56b5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1666957272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=/p9z9up3uocKCE+GJ+TkX5e8OOBP85R6Err2/w4IGiY=;
	b=rUQsEyr3FBY1FodHD/PM1Fc+rX5GHfDXbv25D86XXGu6mqeuVsl5rluv3Pr8lnCoGGqZzn
	7PpX4YyEV88Txt0XuCJcsa+w4sZzuLmvOHY/GQ6nle/L9Kwx8E5qJUYoIwMJKPPGPG7upu
	7Mbu01R7ewExtW6LL8ED5fMTSuxEjj8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [PATCH] xen/notifier: simplify using notifier_[to|from]_errno()
Date: Fri, 28 Oct 2022 13:41:11 +0200
Message-Id: <20221028114111.8150-1-jgross@suse.com>
X-Mailer: git-send-email 2.35.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today all users of notifier_from_errno() and notifier_to_errno() are
Handling the success case the same way, by using

  !rc ? NOTIFY_DONE : notifier_from_errno(rc)

or

  (notifier_rc == NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_rc);

Simplify the use cases by moving the handling of the success case into
the functions.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/cpuerrata.c            | 2 +-
 xen/arch/arm/gic-v3-lpi.c           | 2 +-
 xen/arch/arm/irq.c                  | 2 +-
 xen/arch/arm/percpu.c               | 2 +-
 xen/arch/arm/smpboot.c              | 2 +-
 xen/arch/x86/acpi/cpu_idle.c        | 2 +-
 xen/arch/x86/cpu/mcheck/mce.c       | 2 +-
 xen/arch/x86/cpu/mcheck/mce_intel.c | 2 +-
 xen/arch/x86/cpu/mwait-idle.c       | 2 +-
 xen/arch/x86/genapic/x2apic.c       | 2 +-
 xen/arch/x86/hvm/hvm.c              | 2 +-
 xen/arch/x86/percpu.c               | 2 +-
 xen/arch/x86/psr.c                  | 2 +-
 xen/arch/x86/smpboot.c              | 2 +-
 xen/common/cpu.c                    | 2 +-
 xen/common/sched/core.c             | 2 +-
 xen/common/sched/cpupool.c          | 2 +-
 xen/include/xen/notifier.h          | 4 ++--
 18 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
index ae649d16ef..5952111b72 100644
--- a/xen/arch/arm/cpuerrata.c
+++ b/xen/arch/arm/cpuerrata.c
@@ -724,7 +724,7 @@ static int cpu_errata_callback(struct notifier_block *nfb,
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_errata_nfb = {
diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 61d90eb386..f0b7ef17da 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -402,7 +402,7 @@ static int cpu_callback(struct notifier_block *nfb, unsigned long action,
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index fd0c15fffd..00fadbc354 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -148,7 +148,7 @@ static int cpu_callback(struct notifier_block *nfb, unsigned long action,
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/arm/percpu.c b/xen/arch/arm/percpu.c
index 25442c48fe..67eb821ff6 100644
--- a/xen/arch/arm/percpu.c
+++ b/xen/arch/arm/percpu.c
@@ -68,7 +68,7 @@ static int cpu_percpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_percpu_nfb = {
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index f7bda3a18b..bfa988c162 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -562,7 +562,7 @@ static int cpu_smpboot_callback(struct notifier_block *nfb,
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_smpboot_nfb = {
diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index 557bc6ef86..427c8c89c5 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -1663,7 +1663,7 @@ static int cf_check cpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index f68e31b643..3e93bdd8da 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -757,7 +757,7 @@ static int cf_check cpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c
index 28a605a5cb..301533722d 100644
--- a/xen/arch/x86/cpu/mcheck/mce_intel.c
+++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
@@ -951,7 +951,7 @@ static int cf_check cpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c
index ffdc6fb2fc..9e981e7e26 100644
--- a/xen/arch/x86/cpu/mwait-idle.c
+++ b/xen/arch/x86/cpu/mwait-idle.c
@@ -1537,7 +1537,7 @@ static int cf_check mwait_idle_cpu_init(
 		dev = processor_powers[cpu];
 		if (!rc && cpuidle_current_governor->enable)
 			rc = cpuidle_current_governor->enable(dev);
-		return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+		return notifier_from_errno(rc);
 
 	case CPU_ONLINE:
 		if (!dev)
diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c
index 7dfc793514..f73390cdb0 100644
--- a/xen/arch/x86/genapic/x2apic.c
+++ b/xen/arch/x86/genapic/x2apic.c
@@ -221,7 +221,7 @@ static int cf_check update_clusterinfo(
         break;
     }
 
-    return !err ? NOTIFY_DONE : notifier_from_errno(err);
+    return notifier_from_errno(err);
 }
 
 static struct notifier_block x2apic_cpu_nfb = {
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 44b432ec5a..75ce37394d 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -142,7 +142,7 @@ static int cf_check cpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/x86/percpu.c b/xen/arch/x86/percpu.c
index 46460689b7..288050cdba 100644
--- a/xen/arch/x86/percpu.c
+++ b/xen/arch/x86/percpu.c
@@ -86,7 +86,7 @@ static int cf_check cpu_percpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_percpu_nfb = {
diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index ccb761998f..a1e0af27c5 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -1663,7 +1663,7 @@ static int cf_check cpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index b46fd9ab18..a238aa1f14 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -1144,7 +1144,7 @@ static int cf_check cpu_smpboot_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_smpboot_nfb = {
diff --git a/xen/common/cpu.c b/xen/common/cpu.c
index 778b6820b7..8709db4d29 100644
--- a/xen/common/cpu.c
+++ b/xen/common/cpu.c
@@ -82,7 +82,7 @@ static int cpu_notifier_call_chain(unsigned int cpu, unsigned long action,
 {
     void *hcpu = (void *)(long)cpu;
     int notifier_rc = notifier_call_chain(&cpu_chain, action, hcpu, nb);
-    int ret = (notifier_rc == NOTIFY_DONE) ? 0 : notifier_to_errno(notifier_rc);
+    int ret =  notifier_to_errno(notifier_rc);
 
     BUG_ON(ret && nofail);
 
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 23fa6845a8..44d60ac561 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -2874,7 +2874,7 @@ static int cf_check cpu_schedule_callback(
 
     rcu_read_unlock(&sched_res_rculock);
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_schedule_nfb = {
diff --git a/xen/common/sched/cpupool.c b/xen/common/sched/cpupool.c
index b2c6f520c3..ccb86ef283 100644
--- a/xen/common/sched/cpupool.c
+++ b/xen/common/sched/cpupool.c
@@ -1072,7 +1072,7 @@ static int cf_check cpu_callback(
         break;
     }
 
-    return !rc ? NOTIFY_DONE : notifier_from_errno(rc);
+    return notifier_from_errno(rc);
 }
 
 static struct notifier_block cpu_nfb = {
diff --git a/xen/include/xen/notifier.h b/xen/include/xen/notifier.h
index 0921213298..3d6017d4f7 100644
--- a/xen/include/xen/notifier.h
+++ b/xen/include/xen/notifier.h
@@ -58,13 +58,13 @@ int notifier_call_chain(
 /* Encapsulate (negative) errno value. */
 static inline int notifier_from_errno(int err)
 {
-    return NOTIFY_STOP_MASK | -err;
+    return err ? (NOTIFY_STOP_MASK | -err) : NOTIFY_DONE;
 }
 
 /* Restore (negative) errno value from notify return value. */
 static inline int notifier_to_errno(int ret)
 {
-    return -(ret & ~NOTIFY_STOP_MASK);
+    return (ret == NOTIFY_DONE) ? 0 : -(ret & ~NOTIFY_STOP_MASK);
 }
 
 #endif /* __XEN_NOTIFIER_H__ */
-- 
2.35.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:44:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:44:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431976.684634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNmf-0007p3-MC; Fri, 28 Oct 2022 11:44:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431976.684634; Fri, 28 Oct 2022 11:44:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNmf-0007ow-JX; Fri, 28 Oct 2022 11:44:21 +0000
Received: by outflank-mailman (input) for mailman id 431976;
 Fri, 28 Oct 2022 11:44:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JFjJ=25=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1ooNme-0007oq-IV
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:44:20 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id da2e2984-56b5-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 13:44:17 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by MW4PR12MB6683.namprd12.prod.outlook.com (2603:10b6:303:1e2::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Fri, 28 Oct
 2022 11:44:14 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 11:44:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da2e2984-56b5-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gaRgPiwbbZHFII0cYsJaIQEtk4g5HfA62g3oZtk79eYoEvFmHa4obLX9StkMnbBt6F98fts3Y/Zqu2sbIJe4CKj5RvDhS1fEL5WvDGSfE2hhsp7vZfJr0A/tgAP/lZ6O4orJy8Fd48oeTyvqUJ6wT9gfpUQ+xQgxn++nZYeWAowuex7Db9bOzpT8mhxc8iiwC9Lq/qgm/9I3fYbk4U6yidLSk4QnESlOzvOiUwfJD2yePQ6gFnCjynZff4Klv0SS02UMs4VmWRgtWffLOOCoVOdzKnzchkGkYKk6dMIABMG0dDZzgf+SFh0yDm/gdFizl7zfHVHXIAmTbQCLTBJAeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=W9Mldf5qUAwvWWbpAsoDm+xZrDAm0kaUATQDqGU47wc=;
 b=Q91rw6YMAGv6En1ar5HpQLFnORw2T9NUULX4PjnIri83Zmn/27hYkNk93zT0HWaBR3d03EV7VGxvGvysDbGD6LNYhB6ykX8GbK+Es/A8oxIzkzVcOrMqg0RgHSuYlEgrIlxXRzxCMqGZjzTosLwirYJTwvybZ/li/YKwkCl5FBBgK/C2ewQB2O7M+K4fxr6UmUtqOIKe81xoGG15RZRrbeT+5KoaGoyRgdSABNTUWHRpMJzpoVUOs+HatbiUC4UvokmEq/kj4a19O7kPuRmArOfgAuF2zAF49fZ4m2QGdmBkixgIYjGUDn4iLgUKRaI+EgtysGGioa2OkoxlMoPuBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=W9Mldf5qUAwvWWbpAsoDm+xZrDAm0kaUATQDqGU47wc=;
 b=Wuf+8sNQAsEbK744wF+1DS9HDHBjVAwG9WBGF4y5IUlh4hkUSkgmXmIN3DEZWGBD015o3Sfo5wgP9sPK5MoUXOm3LQ6S+DB+kJ407bk5102M77GNb5ETGc0rx29gM5Lqfv0K+Di7wsVmF33QLrcorkgTtFrUCTfgr3OQNINkkew=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <5afda99e-dd57-5820-7075-6b60e7a794f7@amd.com>
Date: Fri, 28 Oct 2022 12:44:08 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
To: Andre Przywara <andre.przywara@arm.com>, Julien Grall <julien@xen.org>
Cc: "stefanos@xilinx.com" <stefanos@xilinx.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
 <20221025145506.5708839c@donnerap.cambridge.arm.com>
 <7f1bdc88-da6b-9a0c-03d4-319e9d8966d4@amd.com>
 <20221027153632.0cf7d004@donnerap.cambridge.arm.com>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <20221027153632.0cf7d004@donnerap.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: BY3PR10CA0001.namprd10.prod.outlook.com
 (2603:10b6:a03:255::6) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MW4PR12MB6683:EE_
X-MS-Office365-Filtering-Correlation-Id: a5513767-4195-4c43-6fc8-08dab8d9bcdf
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	evyZPX1Efjk0pYPcdrkxwkAR38BiAj0X9u+QXu42Km2DRvvGPCqY3TEyNZ2S03dca1LoqNInQ8/xyCxRU64apNnVOX733F1P8IeHw7YSGQh7PtiHM8LeWTWrd/l/+fd9o32DSiqOwxPCs75tzHbGeEbFQorUPBtiC8fu56k6vclq8LdhdQ8vfOZUdsIsreOGNxZA+op1WRE0tAJeZ1J+zSNJdiKXF0R5S5Mm+q3fnhCaEU0iN7qU3VzuuEwZ2ttEHKehurnKXPAFsZRTwoawlssmx0PjFg7efAgvbLVCynN/ve/wCJSD4qqFNapPas/Zektw9YL79opCz5uURKTh0rrep4nNj2Z7F8zbajygk2JH1N2zuETSsGHg/f0E8WTfrk6FyjYEKYtXP7K101UAnt/d9UmG/DvutcI9BnwHfiMWR5ne5Q2CMn4zOC9+eZ2tiN2Gbnrpkf+LU447f4rU0XN+K0va9X2lhwf8cF96FUb/0UFyoymcMdV7Pp80AB47Ko/aB+qSKY9owY+Zy7bxFHI0SY0GArhM6oWUtujT+orRAVlaRROLr9gkMEts2WhHNqg/WybhNuBlK5o8fgpoLjHe6CQojIobcTM4RwL9oRlHTFPltHeHo9QKwF5sN+MGjjqzQ/qz37QgBPQ+bkQT6MLcDSQ2Uyi+nXCi8szfjTPdm+aPRhuK9HhiI/zCDIpb9HGKP3CYn1elz1XFqZOt8hBVxQhmrK8Qf4mCXPVgfGQrasgkEM8sqegrXoUEasU+tLKESEIfzRCik07B9soIEALirGGp0JHuL5R9bjR8+zk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(366004)(136003)(396003)(451199015)(31696002)(66946007)(316002)(66556008)(4326008)(478600001)(54906003)(110136005)(66476007)(41300700001)(8676002)(8936002)(5660300002)(38100700002)(6506007)(6512007)(53546011)(6666004)(26005)(83380400001)(36756003)(2616005)(186003)(2906002)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c1BrYTdHb3JzcW9lVCtPTzdSY0prSTIzaTdWR1Zwc3hzKytFZkd6ZWxDWm5E?=
 =?utf-8?B?YXVmOG1pLzQzSzJFVlVZeVZVcGY4eEJkUnFhSWczeHRyaTlySFA1L0N0eDB0?=
 =?utf-8?B?REwxR2lxZG9xUmtqOVFacmJVZzN6U0FqRmVReFhuVHl5OU5oeGY2TmJGQ2Zj?=
 =?utf-8?B?VGo2aXJyTmlPUHNWRU1aYUhiZFZ6ZVNWQTBqL0xEUUZhNWRabU1yNytFaGVm?=
 =?utf-8?B?OTRveWNiVjRHaEI5L3NQd0dFL3pUSXVmU3ZMaXRvMkdzWmsrMmQwdmMyK2k2?=
 =?utf-8?B?ZVcxWHpIbmc2cy9DRVlWckp0aTYwVDVIRzg3VHBEalEzQzhvTFlVYmIxOUMw?=
 =?utf-8?B?a3N0VkRJMWlOLzU3c3YxbVZnWXRrTDRWa3VTTERWa0pTZzFGTEQrSFBuQlVp?=
 =?utf-8?B?dFk3RlFnbzFpK3ZkQUtTOStQbzlmOVZvZTIxaktCdEpEblp1dFZMOXh3ME9L?=
 =?utf-8?B?cklSSjRGRXYzUW85TEdZVHF2R3pEenZ6V3NaeFM5YlRZWmx6eEJkdGJSSXVj?=
 =?utf-8?B?QlovUHc3QXRPMEtRbjAwZ2QraUh3ZVJtVmJNSDhqeXZRb21tSmVRaHNtNUZ3?=
 =?utf-8?B?Qzd2NkliRnMwUDhTVXE4SzZXM2x2dzh4L0VmeHdsdzJWL2JjRjRORENrL1pQ?=
 =?utf-8?B?YXYwNC9DRHU3cUFyWTF3MEJDZk44eDl0TWlRTlFuNUp3SFJsV3FyeG9sMnhk?=
 =?utf-8?B?TUlLa2JVb0VvWC9LN3UzTE9FRXc1N3VtYmZRcG5URGhWalpkaXRYOHBwVEZh?=
 =?utf-8?B?UjVSUEhlb0V1Vnp4ckFQbVBtY3ZWT2tRenA1UmJrZmFwU3AweWI2L1RyZk5l?=
 =?utf-8?B?alpWQktzb01uTEN2NnVscEU4bGFYanljK1ZEemt3ZHdqeWtScW5nVUhsUm9t?=
 =?utf-8?B?Q3F0bG00OWhiVXJSZG5ISTNJVU1DY3BJMXpaL1BFNGtwYjBzdnNENVNjK0sr?=
 =?utf-8?B?aUtPQjRCRU9xREJZSi9FbzhoT3hWeTJBV1hNbXhSWnpOSDM3Wk5hWjJMcU00?=
 =?utf-8?B?emkvbDVVSjhxY2NhZXJ1ejhNK1VwV20xZGtzckgxSnhCRUZnZUpVTXdzNG9s?=
 =?utf-8?B?YW8vMDNLREQzeHh5MERGNkdjdkduZVdNMVl4dmM5MERrVkllQS9IdGJlTmlp?=
 =?utf-8?B?SVpRU3N2dDMyYkR1MnFpdmhjMm5DejYydUNFVHBVUmhqUExYa2xXZ0ZwRVdQ?=
 =?utf-8?B?Yk9CODhPc3ZYTFRRbXFHRTlqNURsNzRjb3lSUFN0SU9jcExLR1piMmMzaWFJ?=
 =?utf-8?B?N2RqNVVId283R1U4THdwSVF5cVlSQ0NDcXR2WTRCWEQ5QlVpZFBsZDl6K09F?=
 =?utf-8?B?U1dkRjM3d3Q4em9Ydkh5azFLWFF1R1ZkVStLdWpINFoyK0hkRE15Nkc3bmsz?=
 =?utf-8?B?U3NyOEhLNXJMUW1oZW53a3BLR0VhTWdubDZiTGVWZ2p2NVE2QXNXZityelB2?=
 =?utf-8?B?MEdhU01vNjhWSy9vaTBWQlN6R2tWRCtEdHpNKytEeTZ3OWwwVUpXcmxBSEhZ?=
 =?utf-8?B?WGV4NExtaklLQk9ZOEQzS2dqMGI4Y0dqQ0doZVBOZUlnWWNFQUE5L0NUMHRV?=
 =?utf-8?B?OUR3T2FCLzdwZnNPSFYyZVRibjB3bCtGK280SDRMSlljQ21RUmwyU0F1d09M?=
 =?utf-8?B?eUVPN2FWbWl0UnZtN1Y0RFB4Tm1zSHNnaU15cGswTTJYL2dlOHk4U0hhU1R2?=
 =?utf-8?B?Znd6blJtQStKaUNpamloemlGMTBJdERjekZBbkIwa2RnN2dPTms4N2JFeUZu?=
 =?utf-8?B?YW10TW1FamZQUXRPcHZ6N1VMUUxuRzJvdGJINm1EYXhvOGxNL0tyZnBqL3Jz?=
 =?utf-8?B?NFoycVJ5aEc2blVNRFQvNEZZWTZqbUtsREdZck5SNFpHQU4xand6U1RBclk0?=
 =?utf-8?B?a25hV3pHN3pSU1QwVDE5VVN0aHQ2dGJkZHVNOFF6cDJnVk1kczNpZHQwK1lW?=
 =?utf-8?B?SDRiWkJRYjVMMmwvRUdpREIxTDNvQm5NWWZSK3lOUkZMOVo2YU5ralVxcTZD?=
 =?utf-8?B?RXNsUmtLd2t2TzdvRGhSYnE0NlVGeXVIbnJ2S1hWUWgyK3ZiWUtRVVpJd21E?=
 =?utf-8?B?emFzM3lVWm10dGptelNQRDExK2llME9JQTZMTlpXMlh5SWNkckRFMHlEN3Jx?=
 =?utf-8?Q?79w5vbYlQwhOyeNjmxdUO3usH?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5513767-4195-4c43-6fc8-08dab8d9bcdf
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 11:44:14.3457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: erw95vi3fABE4G5W5gY9EhKtMdeEImhq4QPhj2MI1pIfKAyurqWi6M/vMS6HInissGzYcAnLi7QswlXLtR9XfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6683


On 27/10/2022 15:36, Andre Przywara wrote:
> On Thu, 27 Oct 2022 14:38:52 +0100
> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>
> Hi Ayan,
Hi Andre / Julien,
>
>> On 25/10/2022 14:55, Andre Przywara wrote:
>>> On Tue, 25 Oct 2022 13:25:52 +0100
>>> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>>
>>> Hi,
>> Hi Andre,
>>
>> Many thanks for the explanation.
>>
>> I need a clarification on the issue of atomic access to 64bit normal
>> memory on R52.
>>
>>>   
>>>> Hi Andre/All,
>>>>
>>>> This came up while porting Xen on R52.
>>>>
>>>> Refer "ARM DDI 0568A.cID110520", B1.3.1
>>>>
>>>> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE
>>>> must not implement LPI support. "
>>>>
>>>> Does this mean ITS is not supported on R52 ? I am assuming yes, please
>>>> correct me if mistaken.
>>> An ITS relies on LPIs, so yes: no ITS on a v8-R32 system. I cannot find
>>> this restriction anymore in the v8-R64 supplement, so it would only apply
>>> to the R52/AArch32.
>>>   
>>>> If the answer is no, then my next query is follows :-
>>> Answering to that anyway ...
>>>   
>>>> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
>>>> index 9ca74bc321..dea60aac0d 100644
>>>> --- a/xen/arch/arm/gic-v3-lpi.c
>>>> +++ b/xen/arch/arm/gic-v3-lpi.c
>>>> @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
>>>>         int rc;
>>>>
>>>>         /* We rely on the data structure being atomically accessible. */
>>>> -    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long));
>>>> +    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint64_t));
>>>>
>>>> "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.
>>>>
>>>> Is it fine to change it as above ?
>>>>
>>>> Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy
>>>> atomicity".
>>>>
>>>> "LDRD and STRD accesses to 64-bit aligned locations are 64-bit
>>>> single-copy atomic as seen by translation table walks and accesses to
>>>> translation tables"
>>> This (and the explaining paragraph) indeed suggests that this should
>>> work architecturally, if you use normal system memory (where you would
>>> hold page tables). It would be confined to ARMv8 AArch32 and ARMv7 w/
>>> LPAE, which matches Xen's requirements.
>> Does it mean that ldrd/strd will not work atomically on AArch32-v8R as
>> it uses MPU (not MMU, so no page tables) ?
> No, this mentioning of page tables is more an example or a rationale, than
> a requirement.
> What this means (in the ARMv7-A/ARMv8-A AArch32 context) it:
> Because on v7A-LPAE and v8-AArch32 PTEs are 64 bits wide, it's too painful
> to use explicit locking to make sure just writing one PTE is atomic. So
> the architecture demands that 64-bit aligned accesses using ldrd/strd
> are single-copy atomic, so software can update just one PTE easily. But
> this is only required for locations where page tables typically reside, so
> system memory. This avoids this 64-bit atomicity requirement for *every*
> part of the system, for instance separate buses, SRAM or flash on smaller
> buses, or MMIO in general.
>
> I don't find anything in the v8-R32 supplement that would step back from
> this requirement, although indeed the original reason (atomic PTE writes)
> would not apply to v8-R32. Both the LDRD/STRD description and the section
> listing differences in the system memory architecture do not mention
> anything, so I'd say that the ldrd atomicity requirement still holds.
>
> Please note that this only applies to ARMv7 *LPAE* systems, but Xen
> requires LPAE, and R52 is v8, so we are good, and the Xen code can rely on
> this.
>
> So for Xen on ARMv8-R32:
> *LDRD/STRD* accesses to *64-bit aligned* addresses in *RAM* would be
> atomic. You need to satisfy all three requirements:
> - You must use ldrd/strd. Just dereferencing a uint64_t pointer in C does
> not guarantee that, but read_atomic()/write_atomic() does.
> - It must be 64-bit aligned. Shouldn't be a problem if the data type is
> 64 bits wide. Please note the slight nastiness that ldrd would silently
> work on non-aligned addresses, but would lose the atomicity guarantee.
> ldrexd would always fault if the address is not aligned.
> We might want to check the alignment of data we access (assert?), if not
> done already.
> - It must be in system RAM, so not MMIO. Also I think TCM might be a
> different story, but I would hope Xen would not use that directly.
>
Many thanks for the nice explanation.

I am trying to compare this with the atomicity requirement for AArch64 
(ARM DDI 0487G.b ID072021, B2.2.1 Requirements for single-copy atomicit )

I seethat the alignment requirement is the same as for ARMv8-R32.

"-A read that is generated by a load instruction that loads a single 
general-purpose register and is aligned to the size of the read in the 
instruction is single-copy atomic.

-A write that is generated by a store instruction that stores a single 
general-purpose register and is aligned to the size of the write in the 
instruction is single-copy atomic"

I think the following code change should help us to confirm the correct 
behavior of atomic read/write on both AArch64 and AArch32 (including R52).

diff --git a/xen/arch/arm/include/asm/atomic.h 
b/xen/arch/arm/include/asm/atomic.h
index ac2798d095..f22c65a853 100644
--- a/xen/arch/arm/include/asm/atomic.h
+++ b/xen/arch/arm/include/asm/atomic.h
@@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const 
volatile void *p,
                                             void *res,
                                             unsigned int size)
  {
+    ASSERT(IS_ALIGNED((unsigned long)p, size));
      switch ( size )
      {
      case 1:
@@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile 
void *p,
                                              void *val,
                                              unsigned int size)
  {
+    ASSERT(IS_ALIGNED((unsigned long)p, size));
      switch ( size )
      {
      case 1:

Please let me know if I misunderstand something.

- Ayan

>> If so, then is using ldrexd/strexd the solution for this ?
> As mentioned above, you would not need that, just
> read_atomic()/write_atomic() would do.
>
> Hope that clears that up.
>
> Cheers,
> Andre
>
> P.S. This above is my reading of the ARM ARM and the R32 supplement. I can
> double check with the architects, but this might take a while.
>
>> IIUC "Memory accesses caused by LDREXD and STREXD instructions to
>> doubleword-aligned locations.", then the answer seems yes.
>>
>> - Ayan
>>
>>> But it's only atomic if you are using ldrd/strd, which you cannot know for
>>> sure in C, because it's up to the compiler to generate the instructions.
>>>
>>> This is why we have that test. Changing the unsigned long to uint64_t
>>> would make the check pointless, since the data structure is 64-bits long,
>>> so it would always be true.
>>>
>>> So given that you don't seem to need it, right now, it would leave the
>>> test alone.
>>>
>>> If you need that on AArch32 anyway, you would need to replace accesses to
>>> the host_lpis array with inline assembly accessors, to ensure ldrd/strd
>>> instructions. This seems doable (there are only so many places which
>>> directly access the array members), but would need a good use case.
>>>
>>> Cheers,
>>> Andre
>>>   
>>>> Does this imply that atomicity will be retained (with the above change)
>>>> ? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so
>>>> translation tables are irrelevant).
>>>> Kind regards,
>>>> Ayan
>>>>   


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:49:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:49:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431983.684646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNrk-0000Ho-9A; Fri, 28 Oct 2022 11:49:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431983.684646; Fri, 28 Oct 2022 11:49:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNrk-0000Hh-6O; Fri, 28 Oct 2022 11:49:36 +0000
Received: by outflank-mailman (input) for mailman id 431983;
 Fri, 28 Oct 2022 11:49:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jk72=25=citrix.com=prvs=293452418=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ooNrj-0000Hb-07
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:49:35 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95dee47c-56b6-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 13:49:33 +0200 (CEST)
Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 07:49:30 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 11:49:28 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 11:49:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95dee47c-56b6-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666957773;
  h=from:to:cc:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=Zm/3UsG2PpP0G67ER8fI7VqnfG4u2Sxk7j1RNkhhpG4=;
  b=G5xiDPgBb+SiBqmEVn9QfSWO5T8R+3RitRSTuIcXIA9osqUiVSsj/Vfw
   INq02Gmj0jE0MfA83zJTZ1RkUU0+EfqpH8pGh5MjE80sZOAymjwHUB6OR
   1d4w8TD4k20X3HlOjewn4gY5/W6QxVAPbrlWJUw9hjgIDGV0kRDRzsOUX
   w=;
X-IronPort-RemoteIP: 104.47.58.168
X-IronPort-MID: 84129515
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:jVzIQqmFAX9XoxxK95gvEkbo5gxaJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xJNDz+DbKzfZGf9Kd13PY2/8E9X75fdnNdgS1ZkrnxjQiMWpZLJC+rCIxarNUt+DCFhoGFPt
 JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq
 LvartbWfVSowFaYCEpNg064gE4p7amaVA8w5ARkP6kT5g+GzRH5MbpETU2PByqgKmVrNrbSq
 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/
 f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3
 b81Di8iKU65vtqnh6P4cNlSl80xNta+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY
 cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea9WDbWUoXiqcF9hEGXq
 3iA523kKhobKMae2XyO9XfEaurnzX+iAtNPTeDQGvhC3V+CljVILAEvcHiqud6XhmGHBdxHN
 BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0
 FChlsnsQzdotdW9S3iQ67OVpjOaIjUOICkJYipsZRQBy8nupsc0lB2nZtR+FK+4iPXlFDe2x
 CqFxAAlnKkah8MP06S9/HjEjiiqq5yPSRQ6jjg7RUqg5wJ9IYSjN4qh7AGC6e4addjJCF6co
 HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu
 HPuhD4=
IronPort-HdrOrdr: A9a23:cN7rZKhDu9/FEX+vqZtH4arzFHBQXzV13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03I+eruBEBPewK/yXcT2/hoAV7CZniehILMFu1fBOTZslnd8kHFltK1tp
 0QDpSWdueAamSS5PySiGfYLz9J+qj8zEnCv5a6854Cd3AIV0k2hD0JcTpzX3cGMDVuNN4cLt
 6x98BHrz2vdTA+adm6PGAMW6zmq8fQnJzrTBYaD1p/gTP++w+A2frfKVy1zx0eWzRAzfML9n
 XEqRXw4uGGv+ugwhHR+mfP59B9mcfnyPFEGMuQ4/JlXQnEu0KNXsBMSreCtDc6rKWG70srqs
 DFp1MaM8F6+xrqDxKIiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ9u1U4e
 Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh5rD3xHklXKvoIRiKp7zOSI
 JVfY/hDbdtABunhknizyRSKIfGZAVzIv+EKnJyyvB9nQIm3EyR9HFouvD3rk1wiK7VdKM0mN
 gsSp4Y8o2mbvVmH56VV91xNPefOyjqfS/mFl60DBDOKJwnUki92qIfpo9Frd2XRA==
X-IronPort-AV: E=Sophos;i="5.95,221,1661832000"; 
   d="scan'208";a="84129515"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=E9AJazwRmBH+JyCTTPqbO57tQiiQdRz3EE0omOorqQBWGDJPZn4jkIJMFEbMKb8rH6LtbxmAKzZkzlYwa9Bpt/LlIC5nGR1+gS9cET2Lf9iXExACwHcR6SaLifyaVSkiGh2Dy0x4nN/vTY9F6/R92vAus1qllxjD1qZCnBoDyaxNBfTT4Q4VoDAQfK5H21KLL5OFSHwnuaeJ9agfJ1RdTdtgUJVzBYof9XwZjydV4KB42Qdjl/J7Ab5ESl/rfPWeYRv0sb5sGX0ioaKRRzNgzVfNfq4LIjGyptG5tkpHza92d/9zmoSpBKRFiuhDP99+et8oi6ewpUpHuA03syCivQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zKECUDVl1zscucUPv/GjI0191rht6maSxmk0rYH8+MM=;
 b=h63r+u2tmoD0E2ZY1Nsz6PM+AXc925MFJEGRaM1TQBHMymj7nZJxPFPEqMcKWgMELcnCh7ifdgV3616OqhCGqtDb68WDO05QUwyf8gLbjKUS6LOqnnUvGi5fHSd28qFNS5/lvxAAv30sNfWF+t1MSOj2Os/3RMaZn0Vx6K76bhLER4iA7zBc0i1MZXAwte1qdIiWe1N1R3yzb1qjj1i6Mbh3fZqnHrfC+N9DBh5Z8jGKmohRwRWWhUZQ6pOaMibOyOrwoGsRgqKkigI2wSasKeBwKZ2noimc3WGnyl4GMfYSgTHIE7JqPOinfCzmaN+LlkNPMGJwaLJ8LBULMgFxsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zKECUDVl1zscucUPv/GjI0191rht6maSxmk0rYH8+MM=;
 b=e1t0lpUMKNk+s4hPfWP6UqHfaVudL408ZdZ2gfTi6G+n7kUZCngMsrTCRNQbvAQO/L3lx9LfEWi1/Pe58ZpjGjUgs5t9ZtFuUagcGBWrJdqplUpPGXOKxhfrAAGL1YNB029Q4i/QU6N7g3K20puK5SgJ93ynrlhSf5nYrNjg5VA=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH for-4.17 v2 0/3] amd/virt_ssbd: refactoring and fixes
Date: Fri, 28 Oct 2022 13:49:10 +0200
Message-Id: <20221028114913.88921-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0421.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18b::12) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: bf6b57bd-5c50-46dc-6f9b-08dab8da779e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Xg0eooQ38ocxNC/YsyGBpcgz7dm60+9K9P5ThOhq9+zItvXSUeH+VErvLgAr7qVxYN28+b9NsR1nVvysLa535VKMJwuPNvLFKeBDv2AgE42DeomffLfgyQiGN0gdhieC+coJInK+hoYKjQLjOSfqVUo9WjvKzYE5G3C+lRP7i3xhUPe+9qSb9D5bqY2wwi46pk9jDvE/DyWqQe8jbNvjUnZ3w6gcmbcDgZf3XvrTUFLb9G/z9+5vB/D4CEWnHtSy+OxwLZRtQRiILZPPy+loVTCd8etuRqaf9da2vYHpYRUVazpDW904+Iq2f07ufy79stveDS1nS8a1LUR7CJ80pYa3PmEQjuuZSj7gbIkBdfPCL0IHYz8pAt8G9u3EyovY7ablK/bi9kxrTKmGrWY7i1XJJ+Mmt9gqrtOmTlAzzh1sKfV4FnoHtlQMWn4EkG9lqEXA/sb9ysOfeYJKmyW/ZwBtx+tFBQlyj+gDSjTBm4/PJeJBHk69LlTafpSl/3sQH2u0uQ1m6lRf7feH3mwuwLfjiPR6bn/o/+eMyJ24Jycld3aQBVRiUzL/ymMGO9+KpuMc77Ugf45l91f5bd+GYzfuIx+a/fGRv/qCwb/GHvtlFgHsAZpF3oGFJfXNFsR5ownafsFCDOk71kzD+K+bebQsRLVzeVbu5ZusyHeL2qENdcB5SvYzSC8Lar+/M9y3NCviUKS82Ij9h3V9uilM6Q==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199015)(1076003)(186003)(2616005)(6666004)(26005)(6512007)(6506007)(83380400001)(2906002)(5660300002)(54906003)(66476007)(6486002)(316002)(6916009)(478600001)(41300700001)(8936002)(66556008)(8676002)(4326008)(66946007)(36756003)(86362001)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NEM3ZlRSU2d6QjNCbEJaSkdkaG9jZmlFUit5emViQjFxNmZxRDNwRm1qZXZM?=
 =?utf-8?B?NFVNL3pXZ0R6cG5GMzA3R29WZC9Fd1A0bG9vU0FRN0lWZTZsdy9oVXRrYnkw?=
 =?utf-8?B?NUdoWkZPOW1yRHZjM3NnTFVlUHY4SXc2R2N4UWwxVTg5UDJZVldiZDIraVpp?=
 =?utf-8?B?UG9BOWdGSmsrY1pLdUVFY0dRNWR3SnBzNE5QUUhmZTRSb1JIZTg1Y05ZWlpR?=
 =?utf-8?B?VExtSVUvcEZwMGVnbm9BYWNXMGczaDlpSnhyZ3ltSWNvaWhYTnNFRHYyYU5Q?=
 =?utf-8?B?ZGptWUJSWUQ5YTBFZ3h6TU1aM29weG45MFI3ZnlhazNRTWM3dHk3ZUhCYUZj?=
 =?utf-8?B?WjZpZXBTV01HSHJyNXVBOG8zMG9EeTgwTUF2dnFTMmRnemRLQk9RWUd4eVdL?=
 =?utf-8?B?eGYyNUxlcDMwejFORk1yQVVQNkxNcUx3V1ZsVnFNYlczSEJGSDM0R3l0aEw0?=
 =?utf-8?B?RGRmN05BUXk3SEN3TkM1cmtoTUc3eDh6Tmc3cWl4enNlNHdLaSsxcThXOFQ1?=
 =?utf-8?B?SnJPb3hGTENKVUZlYnc1SkNURVYzNFovUXc5bzNCY2NTTE5temZGTjFOeElP?=
 =?utf-8?B?dWpTK2haTHVVckZ4WGRSMDIzU0oycTZlVHVoMm1ubjVCTFpjRGdQUnI0SnJM?=
 =?utf-8?B?VnRKWUhCMDN0TDdKdHNKcjZQSHE3QkJTbkRiL3RrZDZZakJoR0FqcUc3ZzJw?=
 =?utf-8?B?U3dydTN0OWhuTnZnTGRoeUR6cHBZTWZRTkMybVc3TU9QZlNBclBidWVCdlVk?=
 =?utf-8?B?Q1pNNXBVQjMxQzJwZHJrRzBDZ2VyY2dBT25CNWJBZ1NOREZtZ3lsc2tnNHlX?=
 =?utf-8?B?S2laenRNUFUyTWtwMG83MlhWcTNhdzhkSkp6YmgwK0F5NmhLMlZFcTZSM0xM?=
 =?utf-8?B?WTJQODk5U3RwTlNYSjRxYlprMThHSzhTVkRqWlRrNUlrK0FleGNkYkk4a0k2?=
 =?utf-8?B?c3l2WkJ6NldnNW1CTHpZVWlrV1pGSE1peUVXc1hBT2hBSExLTFJZeURFU3NC?=
 =?utf-8?B?eGc5VVhTUkh2RHdzZWR2dXF1OXUxLzVRazNTTlhsM2ZSdHpGY3dseFVQQmEz?=
 =?utf-8?B?ZTkvUGlPZllHNjFRc1B0T0FubStQMWt6M3VPYkUxYXdLdTh5OXRzaWVWZEZj?=
 =?utf-8?B?ek5naC9DdFVzNXF2S3l3NXd4bVZJYktSMkVzT0ZoUFFQK002NUlJamxVUmZM?=
 =?utf-8?B?elVlYUVSZGNlM3NXcUR1aUxRVmJIclpBeDJPS1M5VkRFMnROWnd6NkxEdi91?=
 =?utf-8?B?bjNCdkRiZkViR3BRT2ZETktaOHVjNUJ2bzNsTWlwdERMT1VSa3B0UDZycFJ4?=
 =?utf-8?B?VGN5TUc2MFllT2VhMWZtb3h0R0JPYVc5TEY2a2V6amJJVkkrYS9CZXRjTkJ0?=
 =?utf-8?B?SmNUeFRaN1pkMGdwbmR6TW1xMW42dHp2OUxQdzA3ZityZ0R1N25DYndERVN3?=
 =?utf-8?B?Z2cyazA2eFhRRjErSDJ4ckNEdTBPZ0pmRXhBSk1rdWIyUkNEZ3daNG1SMEUw?=
 =?utf-8?B?V3pUczJsNXpHV2pXU0t3alJOWVV3azdSVGEvT1BaNVAxaUYwUVFLSGQ5Q2Jz?=
 =?utf-8?B?MXZiazE5dm02WGUwTzd5c3JtMGNDVGc5dlNYRmNSK1NzdmFrZjFielpwcVo0?=
 =?utf-8?B?eUoxN0VDNk5oNDlFY3VRZFpaYTBndktndHVhRmJSSTE1ZEMvVDhGNHZ0bHdo?=
 =?utf-8?B?STczS0ZCUGViazBERE5OVmNNR3B5L05Dak1mOFZtd0ZUeWNWeHl2VDNCcDdX?=
 =?utf-8?B?Q2xDRVlyNXF3djREdDU4Tkk2T2tHRVI0SGhKNmZyQk1QMmljS2J2N3VLSzdj?=
 =?utf-8?B?dkR2MW45ejZjM0RLNWtJWkJyTXBjL2tXcFV2ZlF1cWVFaW9vb1o1R3VaSjFR?=
 =?utf-8?B?RjkyQzllOGt3N2pGQVJnV3ZkeGJjOFZuZThreTRQeW0zTzNOa1NHM0tLejlN?=
 =?utf-8?B?SWRDa3dGQnVTZEpSNjB1TENSN1g2c2xxR3JJeS9WeVR0MGtXaEdWR3o4MUVS?=
 =?utf-8?B?dXhPSC85SEpaZUtxc3lHTTh1eUpSYWQwRlFkdXc0TXRVWjg3dGN5YzV3YzF6?=
 =?utf-8?B?a1pFNUlDQzlvYk1IRnI4VXdJTklobUtXUXNvaFFUanpxaHMwK2RlV29vR1c5?=
 =?utf-8?Q?r7Esj4qirSKDPqv4OR2v7FgMk?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf6b57bd-5c50-46dc-6f9b-08dab8da779e
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 11:49:27.8255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fhb33fwukJoW6bbrqPpJXocA/79PAfRJu7gjsoqeTwDrV8uLhRj7xwgVlUGuDQaqQu9RCvxGVbC17+gNW40smA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

Hello,

The following series aims to remove running C code with GIF=0 on the AMD
vm{entry,exit} paths.  As a result, the context switching of SSBD is
done when context switching vCPUs, and hence Xen code is run with the
guest selection of SSBD.

First patch is a bugfix for missing VIRT_SPEC_CTRL MSR loading, while
second takes care of removing the loading of VIRT_SPEC_CTRL on
guest/hypervisor context switch.  Last patch is a cleanup, that's
already reviewed.

I tested on Naples and Milan CPUs (and migrating from Naples to Milan
correctly carrying the VIRT_SSBD bit), but I haven't tested on a
platform that exposes VIRT_SSBD itself.  I think the path is
sufficiently similar to the legacy one.

Currently running a gitlab CI loop in order to check everything is OK.

Roger Pau Monne (3):
  hvm/msr: load VIRT_SPEC_CTRL
  amd/virt_ssbd: set SSBD at vCPU context switch
  amd: remove VIRT_SC_MSR_HVM synthetic feature

 docs/misc/xen-command-line.pandoc      | 10 +++--
 xen/arch/x86/cpu/amd.c                 | 56 ++++++++++++++------------
 xen/arch/x86/cpuid.c                   |  9 +++--
 xen/arch/x86/hvm/hvm.c                 |  1 +
 xen/arch/x86/hvm/svm/entry.S           |  6 ---
 xen/arch/x86/hvm/svm/svm.c             | 49 ++++++++++------------
 xen/arch/x86/include/asm/amd.h         |  3 +-
 xen/arch/x86/include/asm/cpufeatures.h |  2 +-
 xen/arch/x86/msr.c                     |  7 ++++
 xen/arch/x86/spec_ctrl.c               |  8 ++--
 10 files changed, 78 insertions(+), 73 deletions(-)

-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:49:44 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:49:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431984.684656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNrs-0000aZ-Mt; Fri, 28 Oct 2022 11:49:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431984.684656; Fri, 28 Oct 2022 11:49:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNrs-0000aQ-KA; Fri, 28 Oct 2022 11:49:44 +0000
Received: by outflank-mailman (input) for mailman id 431984;
 Fri, 28 Oct 2022 11:49:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jk72=25=citrix.com=prvs=293452418=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ooNrr-0000Hb-GX
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:49:43 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9b321491-56b6-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 13:49:42 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 07:49:35 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 11:49:33 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 11:49:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b321491-56b6-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666957782;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=eD9s7tMFJPWGtYhi6CBv1Q1gNHmSZ5TKTBfwsmgeB58=;
  b=fg7tTu7C0rlvJG/us/PvSH+lR1lwRWaEX1Ms1gJ5kd5bltNpkTGXcGkr
   I0TJG/P0JNkiUOvq6XRRwOHwJz+727CLvG1fPN0sqgZYTCuJgwf6HYAFh
   5Q1BVikv5dk0IGkXC5/IcSSWypz6dDbKq8Uu2md2bH6aLAtR8MyXXEql7
   Y=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 82799954
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:R7VaFK7wnexZUBMAGe2HBwxRtAvGchMFZxGqfqrLsTDasY5as4F+v
 jNKXjyOPfiNNjP9c9onboy+p08FvMCBmNZgTgNorC1jHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6
 NYUOmkjaxC4v/Pnkb2lEuRmqf4gFZy+VG8fkikIITDxK98DGMmGaYOaoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEoojumF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efx3yqCdNPSNVU8NZA3AzJx3IXFCc5akS8ur63jkKcVPxAf
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2
 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsUg8t89Tl5oYpgXryos1LFae0ipj/H2H2y
 jXT9Swm3exN3IgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl
 BA5dwK2toji0bnlePSxfdgw
IronPort-HdrOrdr: A9a23:3l3id6kwo8yuOWt3+DB5Uy6o5ynpDfIG3DAbv31ZSRFFG/Fwz/
 re+Mjy1XfP5Ar5K0tQ/uxoWZPwOU80mqQU3WB8B92ftUzdyQ6VxeJZnPDfKl/bak7DH4dmvM
 9dmupFeb/N5DNB4voSlTPYLz9W+re6Gc6T6Ns2yU0HceggUdAH0+4wMHfjLnFL
X-IronPort-AV: E=Sophos;i="5.95,221,1661832000"; 
   d="scan'208";a="82799954"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LfsaWNSW8+Hxdm+T8f8OFRQYTjziH34LsIDURS5z+nzN5FabxO0obtmm73P3zbYaDa4WpHfwcbV3uK90/VLHffcXUKgct8ypOy3bXdPjXdYZk+NasJJyNo6Hb3meGcfXEvBf5q8KdFOvfFcXTNyMLAISH8GK2Gn0CbLG4LSz0o8vMCWovrb8vkZkXlTEBRmD9v4uSCA817Id+5nXKqK8mrTbd3oOJYvEafcnW3mMmfxHAAXLdDd1n/lV7mzjGvSQZEYeRFv4R3BVH0e4asS7bsrO42DDoMs1J87+iKiC7Bb4IHJjWitjxOAKYay6HSTVmPDH4qIbVAO5j+uh58kFbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aYDw1ju4VK98mCmtSho12wDHfRMXymvoyrYvMdxnUp0=;
 b=ErNn+qzqxZ+eLWN4gSJ9UOLqbLM6I4IfB1H5x9IBG8Gk0VM2pieBGmaWS+WU+lMgUqcqhZ1HlXZIbg8I8/x0OUgUdUC7j4+nyNa1muegGQX42BF+6t4z3AE8vHrTtIsX3O28ScBlWJ1GQilU3bUkxCN1RITWR+3EYgjta7CjjhJnavWJTYcUcOS5lnWJ2REzoLa7s2kAgC+5AjhUXZV/gOqpledi/MvqJb5lcR2z0UzxQNOZUaFuj9BHqGg2jBW4VB+E2ufZqeqfngyMWIM9zbBFaf9jAgefEz7kzF3RK0GDIm7SMVVzifHaWJEHFjaqFz9GCCQIQJlIwqS4OT5QIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aYDw1ju4VK98mCmtSho12wDHfRMXymvoyrYvMdxnUp0=;
 b=VAVyxaLx+xvSX0FMKib1/AEBHD2hByvwIxmcpaeWFYNpwHg35K2B/rboDVSPnrt7L70WUQdxlacSROkWoQnCUQcGuucFRU50Z/G0M8Zq9TpLQHeMaFNwFZkm2mXSJ/oxVlCxC16Wp1BGErQw6jHbzr3Y5qk7aHaa7yQIGJp7BcY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 v2 1/3] hvm/msr: load VIRT_SPEC_CTRL
Date: Fri, 28 Oct 2022 13:49:11 +0200
Message-Id: <20221028114913.88921-2-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221028114913.88921-1-roger.pau@citrix.com>
References: <20221028114913.88921-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0351.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:d::27) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: 83cd866b-b8e9-4ff7-622a-08dab8da7ae8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	04yvv3SCXZnmIUWo3pPDo5wxE1nlQzlqlhQzE5mSvsagOG5+cDlaGEa59f24NfTW+JeaV0THlgnh+Lg4t8PDhmYIYFHAIrZnNJLDRHHfPsc+4Bl3rTFyD6M89Bqj8jaDO6DwPNHPyPp9juFWF65VdHjlDjH/mTI7KtNOed19pdQKrt5NKU2ape+Inw9+zfXGLTCXzG/FGAIvZuAh1l4z9bCKNu+fcvfAc+8UOgReoPf9ztJJ3RsAF+Lx7lqNgd21Ui7F2c5ImlPwEvH5oUX63LEaD9gcqOPCtLPHJGF28MyNvXHNIbGQQHkRmqxirPpbxO/oxDFpdIK+cXp+wLdt60J17pabX6qp0luXtp94VeeLOpKE8N5eFp89706DH4Chsb6ihLfsa2RSbksFg+g7DtkwOV+3Q+mO5IRSBXTTk6+wCOM8Ch2KOwfZReP75sruAt8KQ2qpv6eEKbHpORa7Vvp0tnI8gFOHtxh4HtFj6LKW23lYX5Q9MBCSpPArqLfjzfD45wO80d6xl3Xma2QtD5/UPge6kvqwQWFyc90x6iBsk16Ua1lJ5oHX4RiA+yzalM7SXtvwgu0L3PsRgwEZzW4QZ1FKtcIBwVzQ+uOKohbL2MQL1+73qYA2bIbAwBEQ8iZEEvlZESTzYYzYvYR0bVklB/lhb8ON5g4sx2qbdhkSljoALe8jNbk9CnTLPsp0q8nqOS62sV3BSH80GrbdVg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199015)(1076003)(186003)(2616005)(6666004)(26005)(6512007)(6506007)(2906002)(5660300002)(54906003)(66476007)(6486002)(316002)(6916009)(478600001)(41300700001)(8936002)(66556008)(8676002)(4326008)(66946007)(36756003)(86362001)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bHRaMlFJeXNWSWM0VTBrQWpTc0hkNXI4UDBON1JhTGhrcWs1bUNOSkduNHMy?=
 =?utf-8?B?RjFHaFhFVkRPNVpRbVM3Nmo4WVZHTDRtbFZIVEhLWkE1WmZzWWdEeUplZVRX?=
 =?utf-8?B?dWFWZWRpNTRnNXZJNEo3OVloU0NNakgyQUxwb2ZPTElZVkhQV05rSzZPUXpl?=
 =?utf-8?B?R3BDQXBQWjZMbW9KZEo5dm9SMDFHZWFZUVVyZzBJWXNTUTBNOWJ2UXBIcjFM?=
 =?utf-8?B?WStrTUtubFFoM2d0RTlxT0JQVzNJMjBvU3FNUEV3MEhaR2FMelZEa0ZSa054?=
 =?utf-8?B?bTdZTUJMVUFjU1A2TDhRK3ZoZEt2bjl2VXlUMU9ZUjZpSDFMb0hPenJiRWRr?=
 =?utf-8?B?MHBwaG9iSUpqT3BndTFyWmhMZjNRL09mTmtBNGtoT3VuaHh2OWRpSjVjcFpl?=
 =?utf-8?B?V3JmekRzeXRrZFg2SGpLYm51bzdiUG1uU0VhZS9mSEJBY2VmYTdQMVZZUFRW?=
 =?utf-8?B?UXVDMGI1MFFrUDlGY2NYM1lITDlGK2pYVGFnaWh0MzRDdmRsb0xIWnlOaUFs?=
 =?utf-8?B?b2IzeEpIREFWaGhEZk5OcDBYUFVKRTgwTnNIYXMrUFlFblB2L2lCTUYyc25P?=
 =?utf-8?B?QXVyMVVidXBjbnlhYU5JdUZpK3lXd0FTVFFEZWRDcU5mNWlpTVJBN1BYbkdp?=
 =?utf-8?B?QlRld2lLNmkwQ2Z6WmtLNzd2OWZrbjYwZTJpaWdsTUJ5UnM2TXR6V2xvNmZi?=
 =?utf-8?B?bU9wMVVVbVQ5VS9VelBRUlNhYkgwT3ZOL0FZNjNMbDlPa0tVbEM5bDVUM1RG?=
 =?utf-8?B?NDR1TmJOMG5USXpWYU5nb2xEblhnaDNPeHhXaUpYUGJZZk4zWVdRNTZuVFR5?=
 =?utf-8?B?ZlB2K1hqdmZjYjBRUCtZZ0tqVXIyTEY2ZDNYTVYxTkUrWHhzUkVYYXlBZTE1?=
 =?utf-8?B?RGQ5VTYrMVpzbjNraHRmUjJ4ZldwT3psSEl3eFErd1pZTkZQN1FOT055eEFz?=
 =?utf-8?B?UmVzTEpPTDk2SUdSMkgwNVRBeVZLc21yUmFNby9FcGJnSWw3dDBKZ3NCRVNX?=
 =?utf-8?B?dkR0UFZhc254K3B3QUtoMWtoUWdjWW82MU5ybjBEZUxCSktEVkdzYTdOVExB?=
 =?utf-8?B?NXZobkN6RnAyTHZSUU5tMnAydzhTNHZBc3ptWWFtRXRDQ3BlYjBwZ3VQYkpZ?=
 =?utf-8?B?SXlSbVhCZG91NGRKeE5vU1ZxaXdFVTV4N1ZZRVRqTWlIblR0RFdUMjhjYnd2?=
 =?utf-8?B?aGdRaDZSYkcrWEtjY1hHNXJDTzRDY3dJdnJHNmdmVTlBSjJVYVVuSmFWNEtS?=
 =?utf-8?B?S0lyUTJ1enJFVG9Fb0s4WFdpSHpxT21xeDlqUkxoTnJvb1FwR3FvdHh2cFZP?=
 =?utf-8?B?Y0NEUEVSV2Y3bzlCTTN4WGJjd3JnYW9WZzNHa0lVNTZncmdEOWV3VTFXTDl2?=
 =?utf-8?B?Tzc4WmQ0Z3RrSGY1QURha1daeU1nYWV0ZXhsVVdSRFNSekR0UjhJVGpNUENI?=
 =?utf-8?B?RHBwSzFLYW1PeHZ6aFc0NzZ6K1l1Zk5keEdqMmhKUlE3NXhEU0hvRUNtVHlh?=
 =?utf-8?B?bURJcXc4YnlEQ1c5RDFWTU1SYXdWZEZtYXpDUDhsT1FYdUNBNXlzNlAyd0tv?=
 =?utf-8?B?M2lITlNhVGN2a3VnMURBUDV1Vlc0ckxDa0I2VjcyMFhGYmtyOGkzUlRqVXN1?=
 =?utf-8?B?OFhaRi9DZGRXcmFONkZuTm9qWElIWmIwNk94V1RiQllhN3ExcmczRCs5dUVk?=
 =?utf-8?B?SW1QemtoOWppNHdPYTl0WUZ2dWF3UUNWRkt6a2xsaXdiVTlUL2l1d1IxRUNI?=
 =?utf-8?B?OUR5eTVHTFN0cXROemFIdGpOVVQxNnUvT2VZeW1Sbk1Cd1RKbjdwUk8xTUpw?=
 =?utf-8?B?a25YVWp0TFVBREZlN29JMGgzNXBQUG85LzBmTjNiaDYvR3Y1eGxuY2dMN2RR?=
 =?utf-8?B?QXFSN2lsVTF2Si9ISjU5MGRFUUxQSDVCNksxQUNsNWdEOVdWdTJkQnVjYVpD?=
 =?utf-8?B?amZvS1loVWk3eEpnaThxZ0g4MW1jVjNxLzZqM1Nka1Y3ZExkYitsVkxXK1o4?=
 =?utf-8?B?MUxxUnF2YjBUaUpvRk0xaU95eFdPMmVtZnU0dzF5U0RNOU8yQllrRjZWWDRH?=
 =?utf-8?B?VVBBbHliVU9ITW5FZ0tDT3drQ0dGdTYvMk9nSDlXRU5nbXNpRStzUCtETjRr?=
 =?utf-8?Q?hMPx62gxdFD/R0QzjfRNRHkMX?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83cd866b-b8e9-4ff7-622a-08dab8da7ae8
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 11:49:33.3290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6dpw77xJQ1CdITUDY0fCMiKykD6cFGIARF7XN8o8hKk2eC1JCzYDyF7lZQO+oXsS3z9OP4xEwvD6E5i8oQzKWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

Add MSR_VIRT_SPEC_CTRL to the list of MSRs handled by
hvm_load_cpu_msrs(), or else it would be lost.

Fixes: 8ffd5496f4 ('amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
I'm confused as to why we have two different list of MSR to send and
load, one in msrs_to_send[] and the other open-coded in
hvm_load_cpu_msrs(), but given the release status it's no time to
clean that up.
---
Changes since v1:
 - New in this version.
---
 xen/arch/x86/hvm/hvm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 44b432ec5a..15a9b34c59 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1498,6 +1498,7 @@ static int cf_check hvm_load_cpu_msrs(struct domain *d, hvm_domain_context_t *h)
         case MSR_INTEL_MISC_FEATURES_ENABLES:
         case MSR_IA32_BNDCFGS:
         case MSR_IA32_XSS:
+        case MSR_VIRT_SPEC_CTRL:
         case MSR_AMD64_DR0_ADDRESS_MASK:
         case MSR_AMD64_DR1_ADDRESS_MASK ... MSR_AMD64_DR3_ADDRESS_MASK:
             rc = guest_wrmsr(v, ctxt->msr[i].index, ctxt->msr[i].val);
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:49:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:49:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431985.684668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNrz-0000wb-11; Fri, 28 Oct 2022 11:49:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431985.684668; Fri, 28 Oct 2022 11:49:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNry-0000wQ-TT; Fri, 28 Oct 2022 11:49:50 +0000
Received: by outflank-mailman (input) for mailman id 431985;
 Fri, 28 Oct 2022 11:49:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jk72=25=citrix.com=prvs=293452418=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ooNrw-0000Hb-Ol
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:49:48 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e3b40e5-56b6-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 13:49:47 +0200 (CEST)
Received: from mail-mw2nam10lp2101.outbound.protection.outlook.com (HELO
 NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.101])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 07:49:41 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by MN2PR03MB5103.namprd03.prod.outlook.com (2603:10b6:208:1aa::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 11:49:39 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 11:49:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e3b40e5-56b6-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666957787;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=UzpYOEF47yweIqsogyxeHkQxw0+cB1pK+4B0T/d6abY=;
  b=R3/Om3Fuycf7wcReYv1g5PZwuRp1I4Z/0kaeO7X3nrG/gcvTxUob2fpa
   Vepw76AgCJctNwssB06/+Kw0sTF/jShth8A2BK1nhzmSK/+CpK5sxoukr
   WstccH7b/ACUkj4TL6Wr7WQPk9H8tDBjqmemai8w8dTXbkUBlg1RBjvgq
   Y=;
X-IronPort-RemoteIP: 104.47.55.101
X-IronPort-MID: 83317456
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:TOAW9qDCfcN7SxVW//Liw5YqxClBgxIJ4kV8jS/XYbTApDsm1mQFn
 zdJX2yEP/zbYDGkf40iOt++9R4BvMSEyIdlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC7gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw479wAiJH8
 r8jNG4mVBCOvsKH7Lm5Y7w57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuuzG7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVqSn12bOSw0sXXqobEZ2h2vN7umSr6W0DWD9Pe16xpum23xvWt9V3b
 hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xJmUCVC8HV9Ugu+c/Xzls3
 ViM9/vrDzFytLyeSVqG66yZ6zi1PEA9L3IGZCICZRsI5Z/kuo5bpgnUUt9pHaqxj9v0MTL92
 TaHqG45nbp7pdEP/7W2+xbAmT3Em3TSZgs85wGSW33/6Ap8Pdahf9bxsQGd6utcJoGESFXHp
 GIDh8WV8OEJC9eKiTCJR+IOWrqu4p5pLQHhvLKmJLF5nxzFxpJpVdk4DO1WTKuxDvs5RA==
IronPort-HdrOrdr: A9a23:FpzfZKyS+ccJyBw5jC/sKrPxw+skLtp133Aq2lEZdPULSKGlfp
 GV9sjziyWetN9wYh4dcB67Scu9qBTnhOZICOgqTM6ftWzd1FdAQ7sSibcKrweBJ8SczJ8h6U
 4fSdkYNDSYNzET46fHCWGDYqwdKbK8gcWVbInlvhRQpVYAUdAa0+41MHfuLmRGAC19QbYpHp
 uV4cRK4xKmZHQsd8y+Ql0IRfLKqdHnnI/vJUduPW9Q1CC+yReTrJLqGRmR2RkTFxtJ3LcZ6G
 DA1yj0/L+qvf2XwgLVk0XT85NVst38zcYrPr36tuElbhHXziq4boVoXLOP+BgzveGU8V4v1O
 LBph8xVv4DmE/5TyWQm1/AygPg2DEh5zvJ0lmDm0bupsT/WXYTF9dBrZgxSGqS12MQ+PVHlI
 5b1WOQsJRaSTnamj7m2tTOXxZ20mKpvHsZl/IJhXA3a/pUVFZol/1SwKppKuZOIMqjg7pXXt
 WGTfusrMq+SGnqIkww5QJUsZ2RtndaJGb3fqFNgL3U79FspgEG86Ip/r1iop4+zuNDd3A93Z
 WjDk1JrsA9ciZEV9MJOM4xBe2KN0fqfTXgdEqvHHWPLtB3B5uKke+/3IkI
X-IronPort-AV: E=Sophos;i="5.95,221,1661832000"; 
   d="scan'208";a="83317456"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n3728W8c6e4zdwg5TvAy+XBrHFvvTXudLmfzEK39LoOOkQr/tL1ttsWO2D8RK1SdXuwQosFUKjzapC+j5jI3iyTyAymTcbsko0Ge5LVXFMMXedRYgWjpYHeoZ1P4UMBFD6a38rWis+CAt8yTQzoLOTBcDXXbwV/d/jjVSTqvWYVSiStQXbT5Hn7HLOiVG60FhOsCKYInZdZyMShYRvPj+XPdCbkNlDojDm+hXl5KSydbbor2c5Kc4PN7OAgmcpp/D0YOYlMkANy++nMSjWQo8n14LOPVoN0QYHfx5UgkODRCXLTbTYDcpk1/HQ8oRG7yDIEDzglwm5KzYnvi8gln+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1FD4zSusDD1nx/omYRwRbRuVZQkclT2SS5Qqf4UzDyE=;
 b=jcQBGFlnA79XbTT/tLrOOhXAd6HO0Xz1/UGMKGW8Wf7M5MPk9mo02R0PB3TSMVg5FVtCxxGjDsY+DO4FR7aZACbu4oNI+0WeOvu5AzyV93tKYoOjF8/JGQtfCeYQIWeRQTmxIFmM9kjBZMFwnOf5umXO0uudtzIIR2oQtaNJb4yhD4KoBxie8I2VtgXivhlNBS34AKa7I6h2o1fwlsQwp5qDWfzl/iDzngfd6vog22pTNZRLkbDP4LvmUv/6XDl0kwSUA98+cEsVATuklQ6klkwD9fSU3GJjRUt/chTEeDGEvLnv8zaNYWRk8KuOigM5+TzV8VrJ8wgayZTm2kjZNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1FD4zSusDD1nx/omYRwRbRuVZQkclT2SS5Qqf4UzDyE=;
 b=Vgotu/ZsLOxB27Dlb48OtpBNUyuaMTchtYfVW+WFPSySyXj4dTKKO8rF2bJr9Wm5brqoUjLX2WOr0xcJaTlNrZFM14b+Bzh1V4vV7ogOhaRnjJz2amvaGdgLsSC0RzFqoTvtHPrayZAuEFEL57g0SNttLrit6Otj/jSjb+FKGoY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 v2 2/3] amd/virt_ssbd: set SSBD at vCPU context switch
Date: Fri, 28 Oct 2022 13:49:12 +0200
Message-Id: <20221028114913.88921-3-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221028114913.88921-1-roger.pau@citrix.com>
References: <20221028114913.88921-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0136.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9f::28) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|MN2PR03MB5103:EE_
X-MS-Office365-Filtering-Correlation-Id: 6c47ed17-b03f-4800-fb4c-08dab8da7e53
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XkUWIIMFrbLm8OFjE+NTuzvCyCdDMPTGLUUky+5PZHrlU4kI4BCiYI08ZuNS5CazgAg1La9z5zaRtEferIckDD+GJUqlNA3X1A+lLQBQvki1gwaPeGQ9XPNoVPTXO9ZXSWzdpuH4N0xWb6xThdw6X8p38gNjSWFQRC1twvudB5y8YVr5MSKWph882JFHW2KX4+F7a/3olAUey4603g6afOqx5+DEMZ7oJ7RytlbUtT5tDmpJsisku2wX9kpIj/cdu4JgEanWULoyijGxAH2wV8+mLj3PlKs3aa1XppGeIM5nwa2iGnJLe/N4aHCqesyuc660LrmoL34V4ycmzmz5BPEDVSWQZu0yxYa3Vw8CC/nFGo5Iz1mXqJ55YFyAUsthVWJYmYSwndtqSMdylZXzsy1bU66i/MRtu2k9Oj8SI3l61koH1AUiyp+pGFi50Twj7FkdNjvqwuNJFG5qmw3zH/G1l6x1xZzxG+cWI5wi8EtNeMhWDi5oy/LegqlDls3TjxMjvBBIN9ZM4Do3jiA6kp/2QOaVJ/pjnyopWCIoMLsAE9Clvr3f9bffo87fMPT9JSFHs5ndcM3AhnF01RZT1Olw82YwENp5JEHfaHNzhuRly7pIDA6s+22xDoDl0p7+PZW76WnlXGF4+pYYi7eWzaOwHGMoEB4KYAhyA5aTUd7pSwbSnPN0NPVhLSnOV5Y1+A52Cazk9FiKeBSRKByqPg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(346002)(136003)(396003)(451199015)(1076003)(2616005)(83380400001)(6916009)(316002)(54906003)(186003)(36756003)(26005)(6512007)(6506007)(86362001)(38100700002)(4326008)(8676002)(2906002)(66556008)(66476007)(66946007)(8936002)(82960400001)(41300700001)(5660300002)(6486002)(478600001)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Wlc4YVRicTFleE5UNGtHVHQ5SHRoSmN3YUMwaTZaSVpocUovdERvL24ybFdD?=
 =?utf-8?B?d0k3Z1krS1h2cTdKaytCZjlac0oraWt6L2t1eEdDM2RlTWlCOUpTOVZjUkFq?=
 =?utf-8?B?M0xFWUZ2M0lqUG1yQjJxcWFqTGNOKzJZQVAyWm83dmZJbmRFdUpKMmh2dFV6?=
 =?utf-8?B?TUVwSTRzWlhxaFZqZGNESEx0WEVSWlA3SGFscWlxMGNmYzhDMDVYQUJDMmZa?=
 =?utf-8?B?T3g2QXRXM3VVODlkRkRuNWZBU1JETXVRSG1sa0xPazRuYW1Pc1AzeW5WYWRy?=
 =?utf-8?B?cXg0VWVxVUNudEdmSUk0MW4yNERZYUE3cHZWY2R0MTRXTi9ycVhad2tlRzRu?=
 =?utf-8?B?QUMxdDZheUdqVDVBWk1GSTI5aVNyYU9BRGFYc0hVR05nc0hmNktFblcvbmJB?=
 =?utf-8?B?bmxTMnRHVVpxMXhaMkFXaWxJNXIvc0MybDNlV2s2R0RWS003UlhNb01YUHN5?=
 =?utf-8?B?ZEI3OTRjbUVteTBiNWxOUEJZKzJVSFJnRjkvcS9iVldIREc5SXNReUFpS3JE?=
 =?utf-8?B?d3QzUFcyUlhQdStzK2hxWnBxcmRVVTVjbVJGTTZ2TXJrM3NIUEVHdWVaYTYw?=
 =?utf-8?B?OVhIdXJuckcrY29mSFFCVUxORjVNWW1YNmh0UUFtQkZmUmRmcEN2VHR4VUlw?=
 =?utf-8?B?M0NXeEt3QmIwekY4YWtCN2lzWVBDQ2d2RXVxODZpTGkxYlFPWnQvR0NWVHF3?=
 =?utf-8?B?d0FvRDJnbVB3eFFDYWxJaXlrd1I0aWNZOSthbGVXNUs1QklFaTNBSm5HRmtR?=
 =?utf-8?B?RDd0N2dPL0ZnaUNyaGZuZnNMSFljVDl5K3lyVjhxVWg3NzJ3eFU3VlpPNzRP?=
 =?utf-8?B?Um9sS0dUNmNMNGtjQ3lyWEF6aE1kMFNIY3Vsby9HdTc4SnRtSlZjcWNmTkls?=
 =?utf-8?B?QVdlQTl3OEY5M1huQ3hnRTVEM0g3Y01FeElqWjV4RkVXR1FYUUFyazlMQThi?=
 =?utf-8?B?V1hkTzJyK2VpQXpxQXhYLzh4MDlJZk42bTNoMlYxbllsdGFPcXkvalBtUXFB?=
 =?utf-8?B?a08rdTFHSUJibmh3ZEF4eTdDeW5laHk1OEpWSmFlSW5hUVcvS1JFZ0puM2th?=
 =?utf-8?B?d1FQeUUvNlhQSGNvYXVVaEFDeGZ0Y1VMTFZxb1pqd1B4Vko5c0hHS3hTcUFm?=
 =?utf-8?B?NHZUOG9tekVocUh5S3RhNjgxV3JIK1ExbmJ6MzIrTDM4WWF5allqYXRBRVFF?=
 =?utf-8?B?V3VYMUJPbzZzUThQZ2N6NTRxZ1MvNEdiTUd5RHc4Um1ma25BNUUxbERsRDM1?=
 =?utf-8?B?WFZMdDJDUjkxaTYwQnFicVc4UzJ1VTRQdXZSUkJDdWttYlNRdGdQTWd2emRm?=
 =?utf-8?B?Q0JxSGlMbzNTRmFScDhIQVJyQ05XajFpK0FacHR5MldCcEIyNTZOUkNNbjFu?=
 =?utf-8?B?Z3J1cUFpdmUvV25hOHEvcWtSVjV0UkNmanMyaXRLcGx6d2VhRmt1NlNkMFU2?=
 =?utf-8?B?L3BnWWU2ZXc3U1FGZENwYWtKcDh5WE5pMjZRbWVSTDdIM28yZDM5NnNBRVJ4?=
 =?utf-8?B?Z0kvOW1KTFEwV2RsWVBnL2IxVzE1bEJyL3RnWTNQaGlLaWMwQzFUY1NmWWZt?=
 =?utf-8?B?YlVWOEFtQzBIVnNDZ3hyU3U2dVBRb3A2aGJNcFhwUFZDVEpGM3h5bndNcW1r?=
 =?utf-8?B?NE9yYmlrQ1RSZHlUNXFqWmpoS0k5M0RMNThFQi92YlFzcFg5MDRiRWZhOUFP?=
 =?utf-8?B?MUNtZVFxSTlHbEZwUjhZQTN1TzlpZVNiYWRScXVTNzZZaHVjOTZNQ3RzUHhH?=
 =?utf-8?B?OCtkWXhNTldvQnJQTCthdkdka3dYSWdnbjJ6a1BuNlh3TUFjNHdrSzhiNWNm?=
 =?utf-8?B?bTJLdzFZdXJVTWhJb3RKV2ZjUXk1ZHRFOWdHVHRzZmhNeDZtb2tHZWwrNFpD?=
 =?utf-8?B?THJCL21UM0ttSkY5UmFHK1FhSHRoblFmN2ZNM1ZHZGJUYVM4Y0doSFlOdVNE?=
 =?utf-8?B?akoxSDlLa2k2NnpZNytsRjZOZ2JwdGJqNTV2dkFRNmc5TjRKZXJzNWFwQkwx?=
 =?utf-8?B?MVkwVk1IWVl2akxwSGRvYS9HYUloN3JYQ1ZYdW9WZlJWb0V1U2I5M2FPZWVR?=
 =?utf-8?B?TUJESGV0ZjNyODZsQ1htQkF6SGxWbjRERmphaTVRK3FFZCt3cFBqZjFRQ1d6?=
 =?utf-8?Q?biPAeLuwkR2uTKsQGQ+SdSvbZ?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c47ed17-b03f-4800-fb4c-08dab8da7e53
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 11:49:38.9879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q3Vmqcc0Le3VE9P3WBYbzMN7KQHz7QnvLHego56+l5U1zfURG4TCDs4hEPV/jI9GcVj90x8oXXaPMrYnTwbSUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5103

The current logic for AMD SSBD context switches it on every
vm{entry,exit} if the Xen and guest selections don't match.  This is
expensive when not using SPEC_CTRL, and hence should be avoided as
much as possible.

When SSBD is not being set from SPEC_CTRL on AMD don't context switch
at vm{entry,exit} and instead only context switch SSBD when switching
vCPUs.  This has the side effect of running Xen code with the guest
selection of SSBD, the documentation is updated to note this behavior.
Also note that then when `ssbd` is selected on the command line guest
SSBD selection will not have an effect, and the hypervisor will run
with SSBD unconditionally enabled when not using SPEC_CTRL itself.

This fixes an issue with running C code in a GIF=0 region, that's
problematic when using UBSAN or other instrumentation techniques.

As a result of no longer running the code to set SSBD in a GIF=0
region the locking of amd_set_legacy_ssbd() can be done using normal
spinlocks, and some more checks can be added to assure it works as
intended.

Finally it's also worth noticing that since the guest SSBD selection
is no longer set on vmentry the VIRT_SPEC_MSR handling needs to
propagate the value to the hardware as part of handling the wrmsr.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v1:
 - Just check virt_spec_ctrl value != 0 on context switch.
 - Remove stray asm newline.
 - Use val in svm_set_reg().
 - Fix style in amd.c.
 - Do not clear ssbd
---
 docs/misc/xen-command-line.pandoc | 10 +++---
 xen/arch/x86/cpu/amd.c            | 55 +++++++++++++++++--------------
 xen/arch/x86/hvm/svm/entry.S      |  6 ----
 xen/arch/x86/hvm/svm/svm.c        | 49 ++++++++++++---------------
 xen/arch/x86/include/asm/amd.h    |  2 +-
 xen/arch/x86/msr.c                |  7 ++++
 6 files changed, 65 insertions(+), 64 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 0fbdcb574f..424b12cfb2 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2372,10 +2372,12 @@ By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
 when hardware hints recommend using it as a blanket setting.
 
 On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
-option can be used to force or prevent Xen using the feature itself.  On AMD
-hardware, this is a global option applied at boot, and not virtualised for
-guest use.  On Intel hardware, the feature is virtualised for guests,
-independently of Xen's choice of setting.
+option can be used to force or prevent Xen using the feature itself.  The
+feature is virtualised for guests, independently of Xen's choice of setting.
+On AMD hardware, disabling Xen SSBD usage on the command line (`ssbd=0` which
+is the default value) can lead to Xen running with the guest SSBD selection
+depending on hardware support, on the same hardware setting `ssbd=1` will
+result in SSBD always being enabled, regardless of guest choice.
 
 On hardware supporting PSFD (Predictive Store Forwarding Disable), the `psfd=`
 option can be used to force or prevent Xen using the feature itself.  By
diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 98c52d0686..05d72c6501 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -742,7 +742,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 }
 
 static struct ssbd_ls_cfg {
-    bool locked;
+    spinlock_t lock;
     unsigned int count;
 } __cacheline_aligned *ssbd_ls_cfg;
 static unsigned int __ro_after_init ssbd_max_cores;
@@ -753,7 +753,7 @@ bool __init amd_setup_legacy_ssbd(void)
 	unsigned int i;
 
 	if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) ||
-	    boot_cpu_data.x86_num_siblings <= 1)
+	    boot_cpu_data.x86_num_siblings <= 1 || opt_ssbd)
 		return true;
 
 	/*
@@ -776,46 +776,51 @@ bool __init amd_setup_legacy_ssbd(void)
 	if (!ssbd_ls_cfg)
 		return false;
 
-	if (opt_ssbd)
-		for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
-			/* Set initial state, applies to any (hotplug) CPU. */
-			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;
+	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
+		spin_lock_init(&ssbd_ls_cfg[i].lock);
 
 	return true;
 }
 
-/*
- * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality
- * that relies on exceptions as those are not expected to run in GIF==0
- * context.
- */
-void amd_set_legacy_ssbd(bool enable)
+static void core_set_legacy_ssbd(bool enable)
 {
 	const struct cpuinfo_x86 *c = &current_cpu_data;
 	struct ssbd_ls_cfg *status;
+	unsigned long flags;
 
 	if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) {
-		set_legacy_ssbd(c, enable);
+		BUG_ON(!set_legacy_ssbd(c, enable));
 		return;
 	}
 
+	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
+	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
 	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
 	                      c->cpu_core_id];
 
-	/*
-	 * Open code a very simple spinlock: this function is used with GIF==0
-	 * and different IF values, so would trigger the checklock detector.
-	 * Instead of trying to workaround the detector, use a very simple lock
-	 * implementation: it's better to reduce the amount of code executed
-	 * with GIF==0.
-	 */
-	while (test_and_set_bool(status->locked))
-		cpu_relax();
+	spin_lock_irqsave(&status->lock, flags);
 	status->count += enable ? 1 : -1;
+	ASSERT(status->count <= c->x86_num_siblings);
 	if (enable ? status->count == 1 : !status->count)
-		set_legacy_ssbd(c, enable);
-	barrier();
-	write_atomic(&status->locked, false);
+		BUG_ON(!set_legacy_ssbd(c, enable));
+	spin_unlock_irqrestore(&status->lock, flags);
+}
+
+void amd_set_ssbd(bool enable)
+{
+	if (opt_ssbd)
+		/*
+		 * Ignore attempts to turn off SSBD, it's hardcoded on the
+		 * command line.
+		 */
+		return;
+
+	if (cpu_has_virt_ssbd)
+		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
+	else if (amd_legacy_ssbd)
+		core_set_legacy_ssbd(enable);
+	else
+		ASSERT_UNREACHABLE();
 }
 
 /*
diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S
index a26589aa9a..981cd82e7c 100644
--- a/xen/arch/x86/hvm/svm/entry.S
+++ b/xen/arch/x86/hvm/svm/entry.S
@@ -59,9 +59,6 @@ __UNLIKELY_END(nsvm_hap)
 
         clgi
 
-        ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \
-                        X86_FEATURE_VIRT_SC_MSR_HVM
-
         /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */
         /* SPEC_CTRL_EXIT_TO_SVM       Req: b=curr %rsp=regs/cpuinfo, Clob: acd */
         .macro svm_vmentry_spec_ctrl
@@ -131,9 +128,6 @@ __UNLIKELY_END(nsvm_hap)
         ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
         /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */
 
-        ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \
-                        X86_FEATURE_VIRT_SC_MSR_HVM
-
         /*
          * STGI is executed unconditionally, and is sufficiently serialising
          * to safely resolve any Spectre-v1 concerns in the above logic.
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 1aeaabcb13..b2f147c11b 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v)
 
     /* Resume use of ISTs now that the host TR is reinstated. */
     enable_each_ist(idt_tables[cpu]);
+
+    /*
+     * Clear previous guest selection of SSBD if set.  Note that SPEC_CTRL.SSBD
+     * is already cleared by svm_vmexit_spec_ctrl.
+     */
+    if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
+    {
+        ASSERT(v->domain->arch.cpuid->extd.virt_ssbd);
+        amd_set_ssbd(false);
+    }
 }
 
 static void cf_check svm_ctxt_switch_to(struct vcpu *v)
@@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v)
 
     if ( cpu_has_msr_tsc_aux )
         wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
+
+    /* Load SSBD if set by the guest. */
+    if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
+    {
+        ASSERT(v->domain->arch.cpuid->extd.virt_ssbd);
+        amd_set_ssbd(true);
+    }
 }
 
 static void noreturn cf_check svm_do_resume(void)
@@ -2518,6 +2535,10 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
         vmcb->spec_ctrl = val;
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        amd_set_ssbd(val & SPEC_CTRL_SSBD);
+        break;
+
     default:
         printk(XENLOG_G_ERR "%s(%pv, 0x%08x, 0x%016"PRIx64") Bad register\n",
                __func__, v, reg, val);
@@ -3116,34 +3137,6 @@ void svm_vmexit_handler(struct cpu_user_regs *regs)
     vmcb_set_vintr(vmcb, intr);
 }
 
-/* Called with GIF=0. */
-void vmexit_virt_spec_ctrl(void)
-{
-    unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0;
-
-    if ( val == current->arch.msrs->virt_spec_ctrl.raw )
-        return;
-
-    if ( cpu_has_virt_ssbd )
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
-    else
-        amd_set_legacy_ssbd(val);
-}
-
-/* Called with GIF=0. */
-void vmentry_virt_spec_ctrl(void)
-{
-    unsigned int val = current->arch.msrs->virt_spec_ctrl.raw;
-
-    if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) )
-        return;
-
-    if ( cpu_has_virt_ssbd )
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
-    else
-        amd_set_legacy_ssbd(val);
-}
-
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index 6a42f68542..81ed71710f 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -153,6 +153,6 @@ void amd_check_disable_c1e(unsigned int port, u8 value);
 
 extern bool amd_legacy_ssbd;
 bool amd_setup_legacy_ssbd(void);
-void amd_set_legacy_ssbd(bool enable);
+void amd_set_ssbd(bool enable);
 
 #endif /* __AMD_H__ */
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 95416995a5..a4c28879bc 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -697,7 +697,14 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
                 msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
         }
         else
+        {
             msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD;
+            /*
+             * Propagate the value to hardware, as it won't be context switched
+             * on vmentry.
+             */
+            goto set_reg;
+        }
         break;
 
     case MSR_AMD64_DE_CFG:
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:49:53 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.431986.684679 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNs1-0001GG-Dx; Fri, 28 Oct 2022 11:49:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 431986.684679; Fri, 28 Oct 2022 11:49:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNs1-0001G9-A6; Fri, 28 Oct 2022 11:49:53 +0000
Received: by outflank-mailman (input) for mailman id 431986;
 Fri, 28 Oct 2022 11:49:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jk72=25=citrix.com=prvs=293452418=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ooNs0-00017v-3B
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:49:52 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a03b66a5-56b6-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 13:49:50 +0200 (CEST)
Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO
 NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 07:49:47 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by BN9PR03MB6027.namprd03.prod.outlook.com (2603:10b6:408:118::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 11:49:45 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 11:49:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a03b66a5-56b6-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666957790;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=qY03LfRv9yDnW4Pz8QCS8mYG+gxyCw6inrJzCBoDSRI=;
  b=BztC+70rL+cQ2Oq8ZpNEnipK4x9bTZxWLc3/pMTRpt85cNdLrPjPJG7u
   dxN5ZnebFqO5ImRwQtLoDO1Tf00IPVv41YgTGFppzNcV+YTW3h/bVOWL3
   JJlyMQ5caJ+oWSuwMrHJ7bT5fTkhplpVFAzBQgOKilXhw+Vrm/M8iJzd0
   E=;
X-IronPort-RemoteIP: 104.47.58.169
X-IronPort-MID: 86237829
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:HTwsm675D5TXIbC3xjAGYgxRtAvGchMFZxGqfqrLsTDasY5as4F+v
 jYdDzqGOPrfNzekfNEiaN+w9x4D6MTWzNAxSlc9+HhmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6
 e0qDDcdSjS4o/+MnoCJbftjgMkHFZy+VG8fkikIITDxK98DGMmGaYOaoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEoojumF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efw3mgB9JIRdVU8NY2h3K4mjQVWSE6cmCY5taeoGmcXIp2f
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2
 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsUg8t89Tl5oYpgXryos1LFae0ipj/H2H2y
 jXT9Swm3exN3IgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl
 BA5dwK2tYji0bnlePSxfdgw
IronPort-HdrOrdr: A9a23:5YTbAKpOe26CuJA16frIbS0aV5rReYIsimQD101hICG9Evb0qy
 lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM
 VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf
 yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
X-IronPort-AV: E=Sophos;i="5.95,221,1661832000"; 
   d="scan'208";a="86237829"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oEOPmID/baK/Krzn9QyEgfUjyEvuLTwxYcLgU4BkFmms2a8PShD+RfFtvvYqKB08UnVfbswluHcsT2/W1OSrK2iIzTi84SykhqpxsWv/e8wNFEWUuTy7Ub/khx64ly5bm9oEVnZBJx9OFjlZ8a4O4CwTB7qzkqdcfOsw7FKeEj2RTfba7WSGxSOa8W6iM6Q0KgozBaV/zC5npuujq5lGQwBZnH3dvigg6eO2i4qndetPhOXoYTRTLJ57GyCiob2QvIdSTm6I9Al7JCd+Pi+uxmHsmVs3yxFCEBbdqACBhmC+w5lEdax7END8MLCALZv3ktp7xcG2aDhtIlRiq9J9xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HjwyPUUW6uvA6MFC/wsykxiv/QG5N/oHoiqE0L+rAJQ=;
 b=L5eVJGYFyQI9d22WjoInJ9NVjyFzrxOE/WVoOp8tkzu9l/UIJ8O2txUydPW2zQBNvL0iZ5p5nbtfNW+zGzKeSw2n9LP58arGMO/rHQzZ0PhfKR8ngFndtdZv9lc2QEHylBM+Pxy+zV5z+JN9DwetLeNdat28RbZ65v8uNLRACtJqYgnQby0upqcUqP9hL7SxaBWli1PNcQEK/zBhbctsFhySxhHMxwfIxzIR0wnTCl/J5YFmwsjpOAgTy7tt9zmIh13Mo1bI0yJEbE0Dd2UzTlPwP9EA2YAYVoiDP7Rc1ETxUkkOIRn9ECf7+0jLjzteLvZlZI2n3IXQiJTRfHHdCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HjwyPUUW6uvA6MFC/wsykxiv/QG5N/oHoiqE0L+rAJQ=;
 b=gqJCac6NZh7B4LdoIZ0mgGSK/cM0nDWf4o8eDJWkvZlvJ3M/nD8JXXNx7Sw1atWUAUzH7HToYa0cihSqUYgJuuhqfVH6CApomKIHJe1aTzhqSTrsauh66Q7gDtxoO54SIcFovD7eVjApqfpP5w4wD+QFMaEDkKy1yvdQQJwDQtE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 v2 3/3] amd: remove VIRT_SC_MSR_HVM synthetic feature
Date: Fri, 28 Oct 2022 13:49:13 +0200
Message-Id: <20221028114913.88921-4-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221028114913.88921-1-roger.pau@citrix.com>
References: <20221028114913.88921-1-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P265CA0154.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:9::22) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|BN9PR03MB6027:EE_
X-MS-Office365-Filtering-Correlation-Id: 7bbb5d6b-ca1f-49f0-09c4-08dab8da81d7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HZMGuXyok84w1jfA/gyWHXKzyGHu8D+P3y/XWYqpEdj0ayu5uoME/eC34JCL/Puf8KAUb2oflfiEKloi8PluZHcZ+IZuTHYzdaMvWrxnd9I6tWz+ig3zW3gJ41dcV6CSPbNek45fP0icTbWojpC0fiET8z91+ZiQ/je93xzMTKlr8Zs746y+4+SCcMRSD/9M5nk5wtCKZThiKgaSh/rxHdAXr4Fnij63co2AIwmrQfJeC8K6tIhbv/WV6pyzkW4KHh+sgQMhnHt6G/GWSl6bYGm2L57pgIWkw1FEuBa6dJusCIhsq2PeYLT/HFSVS3FICTxfJf+8b7fPNrcosWiRErUtT8gOv3/oIrDhyhOCZ+LKv7D0e3vtpjm2mvJIvsbIDD5AL4JTAfEQNtJpma0M14zwCOCWTo1JcvtH8oa3H/XIo5J+VcKq5JsPbUYSKJLEMnfW9uaRp2hevOCakBcFaOPJp/ZIQktrtyZTX/Gt6n2Xpp5+MKToHQbEaavhKKRMRTBpeQ1UhZ7ILtURYuSJTWNP0NNAuUmNvKPjV+LbKeImVI2zhvDgVvj7yhRn7DlM46ZVywPv3UeormxUuAbwBz9gJTExcS9efkLX6PIebz2+Xs4tcij+vSkmHvSalEfNLtvQ5NBFkst0505Vgy49HlWmyR4o399NMlFqxCIoJQYiUO10EPIoaZnGHQushRTJTE5Wn0rzP1BZyqUexRz7JA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199015)(1076003)(186003)(2616005)(6666004)(26005)(6512007)(6506007)(83380400001)(2906002)(5660300002)(54906003)(66476007)(6486002)(316002)(6916009)(478600001)(41300700001)(8936002)(66556008)(8676002)(4326008)(66946007)(36756003)(86362001)(82960400001)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0N5QVUzV1dGRHY3MlEvejBON3VTWmRURFVmUUUwbHhkdmVhREZuQktkU0py?=
 =?utf-8?B?Y0dtZG1qNWtjRWtPRTRlaTNGME5Pd3ZEQ3JMMER2MTNra2NaT3pra3MreW5C?=
 =?utf-8?B?YTNwbmRCWjJmN2FoeUF4OGVQLzNJRmlqeERpcyt5SFhYWW5PbWMwNUd4Y1Jl?=
 =?utf-8?B?TjRXYjYxaFNhNWt5SmFVOWh6ZVNIR25adjJxRWNkRlZUQnZLRWZ3cXA1eWJ0?=
 =?utf-8?B?NFBGZlMxZVB2Y3dyQ2ZGUVAvenZ5ZlpiQmRISFp0eGUyVU5EMnM2V3J3dnNy?=
 =?utf-8?B?Z29PQ3poNGNldnd4VkMvUFEvV0pKQ1BCME4rdGUvT2hyaU8vS1lvYzNzbmFV?=
 =?utf-8?B?ZzB2VktLK0RZM0VDQTV5WGQzTGlKQUxZbVlCdDNaTGk2eVZYdmxjdlh4Q3Bj?=
 =?utf-8?B?Z0VYYkZiblp3OXpZU1Rrd1c5YWtVUW9tT1FQbFRnMjRJYXhYYTlzRzZjaXdF?=
 =?utf-8?B?R1IrMGFERDRKWkRTMUJ5UTF1ZTNyRjdPUm51WlpTMENoZ0VDM3dyUy9wTW9z?=
 =?utf-8?B?azN5VTJPRURoalZ3czJkTU9LWG1tZ0thZG45VVZwcUpmdzhCRG4zRjJMQ3hm?=
 =?utf-8?B?am9oM1NxREVRL09wb3pzSEVsa25oSFR0NktoZWhDV01qejVUUXR6cWRwMDhS?=
 =?utf-8?B?UDgyUy9BcVYyQUE2VTNYY04zQTdqV1ViLzBJcEx5Z1JoaXFMam5Jem5WeUp1?=
 =?utf-8?B?NkFZcERaenN5RWQzV2o5ZDA1SjFIYytRTy84TDdyL3NsV0NCWjNpUmJUZm12?=
 =?utf-8?B?TnpqMkJsaytNU2pBazE1RUZrRytmWnpHZllDSkRrUXhWQm96dVpkUEZPbS9x?=
 =?utf-8?B?ekFmeXlzaFZMMG9MZHJBUWQwUDIvc3ZwQXNFSzJhYWxzeDZsZmtpMVF0L3ZH?=
 =?utf-8?B?ekR6S3N4dG5TK2xKbzVVakZrN3ZxV0dxYWdUWktDcGV1bGQvNjRLR2dGenRM?=
 =?utf-8?B?RHZ3L21vNmhVUmhDc21sRW80Y3RQWDd4Mk5yVVlaQ3QvNGx0aGptQ3B5L2g1?=
 =?utf-8?B?eTFpTFRyM1BFT0JmSW5kUEYvNmlXc0V0ZFV4K2dRbE9Va2ZORjI5VHI1b3Fo?=
 =?utf-8?B?RnVlZDg1cXg4Ni9ZNkt0UXI2ME1MWDNRQXFkN3VFZzZRc0tVNU9zb2xXaDcz?=
 =?utf-8?B?bkZhMFFzWDJxTm9FY1RGWFk4MEpFOC9CRTVraU5PeGlBZHgveVFQZG5DZFZN?=
 =?utf-8?B?S3lvZHZoSWFRc3hvTHNnYXZlc3NjQTVaSHdFU1lkTk5KSXJ3YldHRzFHKzMv?=
 =?utf-8?B?b0V0TDdURXp6YTcwMDBBWC9QY0F2c2poMm5YREhZTzZaZWhlaHJIOHZWRWFO?=
 =?utf-8?B?OEF0blU2VEk5cXRjMlc0bm0xUTllaUtVQ2lNZjRlejU0MUV4aEQyNjBLWFNa?=
 =?utf-8?B?U0FtL3daeGszcUJ6c0hOVnJXM0ZEOXVRWnJPVTRHZ1o5cjEvSm1helgzU3M5?=
 =?utf-8?B?ZXJEczhwRTJmcVVaZWRETHpPbUVpWmx3MXdvd3JGTnkxMFVYb1RUYTczKzE5?=
 =?utf-8?B?dkduUVUrZU5DaGpERW1QM0FoRlFQTjhGWlF0ZExCOEtEVjBrb1h4b2tLSGVz?=
 =?utf-8?B?SHNNZENDMEhpazdFWFZiMElLMHdDNmFENjJQQVQ2d3J6c3Rtd2t4d0Y4b3lo?=
 =?utf-8?B?Vm9lVGNPMjV2SzhPaUFweVlhRElucm5ncWFYOHhKK0VhcGp2OWVraXJqRFNn?=
 =?utf-8?B?cjIyQS9HVE9rNlFHM2JJVkF0YmtFemE1bjZYVnVjZ0NEb3Jpd1JaOTR3SEdG?=
 =?utf-8?B?TGpKeFk3bVhtTytjWjVuampKWVBPMlZmQnQvU25WQWx4SEJ6NWpxa0ZtdEJr?=
 =?utf-8?B?WlJ5NC9YQnZ1R2Q2bDJuYVNKdVFxNUIwR0RBdlAwT042eFIwZ0QvVDVYWXRl?=
 =?utf-8?B?V2RHVnVoTkIwSFAwY1lSUGl4VTFJVzR2UXRIWi9qL0xwc1N3V3Nqc0xlUnF4?=
 =?utf-8?B?MExTenc2OUJFeHhySXR3TjFsZ24ySHMyS2tkYmYyZE11K0VMbDVvZElTTGVU?=
 =?utf-8?B?ZFAzRnUwVHhNYjhRZmRxRHlrWFcyUk5wcVVOdzBNd2Q2QkF4UTNWNmJzY0w2?=
 =?utf-8?B?anBBbDZtZGpGOG44OHcwWEJwblJWazVWRDVCZTdRNDZwNHBXTHVDTUlHczRn?=
 =?utf-8?Q?bMO/zOnODMs/95m02hNfgjRnl?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bbb5d6b-ca1f-49f0-09c4-08dab8da81d7
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 11:49:44.9581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qY0hCGYjZ/zaHqN19D0DX+l3NqgmdfXKHcT/RS6UilcmmnFmLoa5Ned/Uni3HMyl/veMOgjgnTpvH3Iry6Js5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6027

Since the VIRT_SPEC_CTRL.SSBD selection is no longer context switched
on vm{entry,exit} there's no need to use a synthetic feature bit for
it anymore.

Remove the bit and instead use a global variable.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/cpu/amd.c                 | 1 +
 xen/arch/x86/cpuid.c                   | 9 +++++----
 xen/arch/x86/include/asm/amd.h         | 1 +
 xen/arch/x86/include/asm/cpufeatures.h | 2 +-
 xen/arch/x86/spec_ctrl.c               | 8 ++++----
 5 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 05d72c6501..11f8e1d359 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -49,6 +49,7 @@ boolean_param("allow_unsafe", opt_allow_unsafe);
 /* Signal whether the ACPI C1E quirk is required. */
 bool __read_mostly amd_acpi_c1e_quirk;
 bool __ro_after_init amd_legacy_ssbd;
+bool __ro_after_init amd_virt_spec_ctrl;
 
 static inline int rdmsr_amd_safe(unsigned int msr, unsigned int *lo,
 				 unsigned int *hi)
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 822f9ace10..acc2f606ce 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -3,6 +3,7 @@
 #include <xen/param.h>
 #include <xen/sched.h>
 #include <xen/nospec.h>
+#include <asm/amd.h>
 #include <asm/cpuid.h>
 #include <asm/hvm/hvm.h>
 #include <asm/hvm/nestedhvm.h>
@@ -543,9 +544,9 @@ static void __init calculate_hvm_max_policy(void)
 
     /*
      * VIRT_SSBD is exposed in the default policy as a result of
-     * VIRT_SC_MSR_HVM being set, it also needs exposing in the max policy.
+     * amd_virt_spec_ctrl being set, it also needs exposing in the max policy.
      */
-    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+    if ( amd_virt_spec_ctrl )
         __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     /*
@@ -606,9 +607,9 @@ static void __init calculate_hvm_def_policy(void)
 
     /*
      * Only expose VIRT_SSBD if AMD_SSBD is not available, and thus
-     * VIRT_SC_MSR_HVM is set.
+     * amd_virt_spec_ctrl is set.
      */
-    if ( boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) )
+    if ( amd_virt_spec_ctrl )
         __set_bit(X86_FEATURE_VIRT_SSBD, hvm_featureset);
 
     sanitise_featureset(hvm_featureset);
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index 81ed71710f..5c100784dd 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -152,6 +152,7 @@ extern bool amd_acpi_c1e_quirk;
 void amd_check_disable_c1e(unsigned int port, u8 value);
 
 extern bool amd_legacy_ssbd;
+extern bool amd_virt_spec_ctrl;
 bool amd_setup_legacy_ssbd(void);
 void amd_set_ssbd(bool enable);
 
diff --git a/xen/arch/x86/include/asm/cpufeatures.h b/xen/arch/x86/include/asm/cpufeatures.h
index 3895de4faf..efd3a667ef 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -24,7 +24,7 @@ XEN_CPUFEATURE(APERFMPERF,        X86_SYNTH( 8)) /* APERFMPERF */
 XEN_CPUFEATURE(MFENCE_RDTSC,      X86_SYNTH( 9)) /* MFENCE synchronizes RDTSC */
 XEN_CPUFEATURE(XEN_SMEP,          X86_SYNTH(10)) /* SMEP gets used by Xen itself */
 XEN_CPUFEATURE(XEN_SMAP,          X86_SYNTH(11)) /* SMAP gets used by Xen itself */
-XEN_CPUFEATURE(VIRT_SC_MSR_HVM,   X86_SYNTH(12)) /* MSR_VIRT_SPEC_CTRL exposed to HVM */
+/* Bit 12 unused. */
 XEN_CPUFEATURE(IND_THUNK_LFENCE,  X86_SYNTH(13)) /* Use IND_THUNK_LFENCE */
 XEN_CPUFEATURE(IND_THUNK_JMP,     X86_SYNTH(14)) /* Use IND_THUNK_JMP */
 XEN_CPUFEATURE(SC_NO_BRANCH_HARDEN, X86_SYNTH(15)) /* (Disable) Conditional branch hardening */
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 4e53056624..0b94af6b86 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -514,12 +514,12 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps)
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
             boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) ||
-            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM) ||
+            amd_virt_spec_ctrl ||
             opt_eager_fpu || opt_md_clear_hvm)       ? ""               : " None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
-            boot_cpu_has(X86_FEATURE_VIRT_SC_MSR_HVM)) ? " MSR_VIRT_SPEC_CTRL"
-                                                       : "",
+            amd_virt_spec_ctrl)                      ? " MSR_VIRT_SPEC_CTRL"
+                                                     : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
            opt_md_clear_hvm                          ? " MD_CLEAR"      : "",
@@ -1247,7 +1247,7 @@ void __init init_speculation_mitigations(void)
     /* Support VIRT_SPEC_CTRL.SSBD if AMD_SSBD is not available. */
     if ( opt_msr_sc_hvm && !cpu_has_amd_ssbd &&
          (cpu_has_virt_ssbd || (amd_legacy_ssbd && amd_setup_legacy_ssbd())) )
-        setup_force_cpu_cap(X86_FEATURE_VIRT_SC_MSR_HVM);
+        amd_virt_spec_ctrl = true;
 
     /* Figure out default_xen_spec_ctrl. */
     if ( has_spec_ctrl && ibrs )
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 11:56:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 11:56:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432007.684690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNy6-0003oT-3j; Fri, 28 Oct 2022 11:56:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432007.684690; Fri, 28 Oct 2022 11:56:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooNy6-0003oM-0p; Fri, 28 Oct 2022 11:56:10 +0000
Received: by outflank-mailman (input) for mailman id 432007;
 Fri, 28 Oct 2022 11:56:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=l/aT=25=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1ooNy4-0003oG-If
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 11:56:08 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr150083.outbound.protection.outlook.com [40.107.15.83])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7f1d2337-56b7-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 13:56:04 +0200 (CEST)
Received: from DB8P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::34)
 by AM9PR08MB5970.eurprd08.prod.outlook.com (2603:10a6:20b:2df::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Fri, 28 Oct
 2022 11:55:56 +0000
Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:130:cafe::34) by DB8P191CA0024.outlook.office365.com
 (2603:10a6:10:130::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 11:55:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 11:55:55 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Fri, 28 Oct 2022 11:55:55 +0000
Received: from 7e4ee9490ce8.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 DF40AAEA-37B7-4863-B99F-53A77B3D631E.1; 
 Fri, 28 Oct 2022 11:55:48 +0000
Received: from EUR03-AM7-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7e4ee9490ce8.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 11:55:48 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15)
 by DU0PR08MB8447.eurprd08.prod.outlook.com (2603:10a6:10:405::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Fri, 28 Oct
 2022 11:55:46 +0000
Received: from AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339]) by AS8PR08MB7991.eurprd08.prod.outlook.com
 ([fe80::5cdc:31ff:2d2d:339%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 11:55:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f1d2337-56b7-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=Z2EIMAlzEHtu214+Dyn3LUnKSy5+YK/uW4NK/00GYnRyUPJsW97AWO+1hyek0lcARO7uDN/kUGqzaeL0xKngCce7EJ4LB2XnI9WPYhr5Ihd6CWSlQi65yYsD7cH3YyQ18jfw4msbX6yiLbTszxOpl1mk9qnhjxZWlvka1S/hTL4AVQuAfpy31I5dfsWxh7xW0pifKBBIhEUdGGlN1A4c6vKGZvdcABSrUsYBRHWI7kzQPd2KQH80NtVmTOn8WDRD+K5Cs8+ymHBCp2m/92JrTqRdm3qj2Q6qB/EvxnHvP1/cynFPXF/XYc9vBxt8/d1rWgV3ytyxAcpB9a3+Gbvegw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P6/2DQd+DmjhFWR4GvW5JmeTYQEWBBIX1FQTBHmz/AI=;
 b=lNVuEo9jEHFvqSs9Oc8bkzaW03eXOpBXQwYLTxw2JPM1MLyHX2WUP3H5p9enq4OU4fYnHc+9ibJEOWitgMqpTHKAna1BvH7VvCRKx2CXMwqrkd3Dbaop4ia1KOE/Le+s9YTwolDlMJgFFMOAfj05zWSaA8UoxGQfVIB0OOI87yFjoB+F6vPdmtFKM4oR+hpiVfJ+AIxtUbAZDe9c3NEC+dhaGGporC6ZkDmNFkv1uKjSCUmXarOmOu1b7hzoaXGII3GBzc+AqMbQcxXSJTIsMnnyvl4f4lBS7psWel+ZuQRR7UscRgD1CVSwDYLoNGajR520kPeU79vwOwuWzft9rA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P6/2DQd+DmjhFWR4GvW5JmeTYQEWBBIX1FQTBHmz/AI=;
 b=jDTApxOHKMg5HYKTXJZKJBjYTuseUeFYUU6ILC5BcfyNV1pfOqWoxzwYFi5STSTmU/0FLVYdhCgpQVMgpC0+aZv7BHbWFaEksc2sMUciE3QkWeSL5qsWxMZ27V6hMr8+6EufAIhDrCXxE+wBlaxxfl0LXwfubGnjTiMVdomRu5Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8b979c5e8a1c298a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y6Z4UcOLpwPLDSHPAcJKS5aB3ifBRMTYupPodjCG4/xDUViMTAcZV0HJ6EPWoHw995SIvJrFRsbQjyUjpQdM4/5n0P+DKpVsx/o/cby+7x3ZNB/9eYzJgRICicuTROdX0ogjJeO7lvRf9cRi2pLo9QrXsuZDs4LygfyNiAqNNXR24H2DXNUitPK7AVpEUk7NmfxJ6tEGDmou6c1oGV9hYJ1i4NVHmtBIgQ3h2F3Nvbf6G9cKMZ1bSoAdNueySIurXv9JuaPy0AOP8GaMsKBP+P2es3Y2bb0cBCvslAEMEn9rMvUXferjlwaflS+4BQ2QyhkkhWFKoIihyBLQQ2jAJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P6/2DQd+DmjhFWR4GvW5JmeTYQEWBBIX1FQTBHmz/AI=;
 b=PwY1clf3+l63HrM9vnaAVFt2Vgu1XVUGI17j9KH99KgjiQzemaCV0Fh7Dt3KIpUz8bpbRzrSdJtbBHg/zgZFJEK4/dH0J+Fl4fZIar3N6+BEoXD91bOQvRy4y5zZw3kcxXlQ/Yxd0IuGF2ZMTimUCC5LNkRq2d9XSS/dhIOqwvwJSsYMzLeYsBtHMeUhkEojwwrNhq5vcUH6LjSpLsS71iStQ02bOJJRCwILyhOOhz7t+GzX5+R8qwaxzITUVK8DImFvv+fd54Rxs7/3YCFkSQS6uQNLAQXo6sd0HIIqTeDo5kb8CrQZFBBZdfKxuNctqVdqXRLV3U4/fBR31ylqSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P6/2DQd+DmjhFWR4GvW5JmeTYQEWBBIX1FQTBHmz/AI=;
 b=jDTApxOHKMg5HYKTXJZKJBjYTuseUeFYUU6ILC5BcfyNV1pfOqWoxzwYFi5STSTmU/0FLVYdhCgpQVMgpC0+aZv7BHbWFaEksc2sMUciE3QkWeSL5qsWxMZ27V6hMr8+6EufAIhDrCXxE+wBlaxxfl0LXwfubGnjTiMVdomRu5Y=
From: Henry Wang <Henry.Wang@arm.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Liu <wl@xen.org>, Roger Pau Monne <roger.pau@citrix.com>, George
 Dunlap <George.Dunlap@citrix.com>
Subject: Re: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes
Thread-Topic: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes
Thread-Index: AQHY6p25/bekYaAjhk+9l2kl41e6864jprOAgAAL158=
Date: Fri, 28 Oct 2022 11:55:46 +0000
Message-ID:
 <AS8PR08MB7991AB7CE4A56EFAB36708D892329@AS8PR08MB7991.eurprd08.prod.outlook.com>
References: <2398b0e8-ea5f-dc8e-46d8-2d3994a98b34@suse.com>
 <e8e062ac-5791-2f72-ba35-d8f86e452fa0@citrix.com>
In-Reply-To: <e8e062ac-5791-2f72-ba35-d8f86e452fa0@citrix.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7991:EE_|DU0PR08MB8447:EE_|DBAEUR03FT010:EE_|AM9PR08MB5970:EE_
X-MS-Office365-Filtering-Correlation-Id: 35e88d0b-eaf7-460f-4549-08dab8db5edd
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 T6WGy3WQuX3UNNNdrVKoLNYYbq650kmN6svKPQ1lPQsA78xgGWRBNAz7kIK9iBYUFTs7PLOZrKEZvyuXFZjxC7Ydcw329xMHlKpM+W1BqvuiK4vSQWBFQ9hJEau+PEtOfwzV5hF4pSbXgO2c/WROuL7CXhCr57STNBK7j9NVgnvjoN4c6RwvKH9v+lgEA4NHTH7nKA/XjmL5lrPSaRfK2F1b4SaGsUx364vxT8uEM42LE6d+rzX1ctzyxYda76OQhQN/rQBeayTxKM3/aFOlJVd036Cw24XGBSdTQYAvheZ3BOHU14mOoe1yLJU8qI9MT2NBkgGLMB+6VZkgobAaDxrNl/E4/7vb0cJafigtUoQTYJeV1KWL7JZszkM+UYpNOqLPIMcejeKkRGYCJ2KUjGwspgdG7O/pXbgokxJdSXEYwmFTSDw7KO4+LlFApEcPCdRDrsxVdT1xI57e6jyKXChq1IhM0NlVprz+Q8ifL8bzSOO2AbvnI3c2Y+xpRRDmQMPRDnIPLp4uWWFSAyb19y2swMs3mqxmFe5wGjFFBEIS85dAhqMRmd+/iSht5ZBC92452D2fC33Tvdj1Yxcqzk+gnLCc0w2oN+Yz8/c3eidw4sQ7BcKqlj87UGfzAtwmY+YkTJNby3zIUJU4ysP4wlMtLcu6mdqn6eJHDapMMJg/o7W8tkhBZiKBQ1xiJYZ56u/yvsKYGCGMCySSVTSL1dmEWxLY2vnhH896PN76ieIHU1ByIIaMDF6xnVsCu1wiNkJRPgg5N4FpUIrr9dg275NUMpQSSTX1GgC9uHjgWcM=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(451199015)(33656002)(166002)(38100700002)(86362001)(122000001)(6506007)(5660300002)(4326008)(9686003)(55016003)(186003)(83380400001)(53546011)(7696005)(54906003)(316002)(38070700005)(2906002)(45080400002)(478600001)(8936002)(52536014)(76116006)(66446008)(110136005)(41300700001)(64756008)(66946007)(66556008)(66476007)(71200400001)(91956017)(8676002);DIR:OUT;SFP:1101;
Content-Type: multipart/alternative;
	boundary="_000_AS8PR08MB7991AB7CE4A56EFAB36708D892329AS8PR08MB7991eurp_"
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8447
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5ee5db84-3c50-4087-a13b-08dab8db596a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nZ5y7u/t/T0Q00RNuAZzatkSfeOJktmdXvMZZkXjcnGTsFbedSeddW3HAcMrD6skH+sjASrrqVPrbLh1ws9ZYixPR4pxYAYTy0hXQFClD+btwgfMRjuZSpsCX83kS6d2vpjbaOUga7j+VWhaxw577uewKwYpv32pQk8T8mLpGD3pS7ZlJw1N97oVcuOWFDDtv8rFKPHCurUanLZYP7YgdmhUYfM/hKwBbo2ggyONPb50MpJvTNFGdLytnaDGuGmrq8mrtpBNZaB45dCLMFejbLtzl0TGyaFuPP+bl+MTJ3hfsARIxl2jfK2EnIkEfmLYnuSm854QOOMXJGYejTRDvNJ6LecqPZ4DDEvc6u84552+IZjmg/8U6oMB1SoKPi+7GBTXQCq9q7HWeFfOFSmdj7laG/1dhNgt5/Qax7DVksSi32WyFHSJ+zwUK3i3dwcbgecjEXkdTcKmN2HpKdo9HnR2VAdNj32/D9rBSpG2ulvndfq3HH/PE7UreduJh2Gl1zdlOkijzHr179Q+kqJWNNtumVYVh72c7xODNi9vsW3EspaVe1x/ePOL0oE0xcInLhtbLBWLY8jiKVcV0tsuyG0AeY2SYN4LD5Pkx9lPkr3wnnis46Kw9g4BEWGeNmmv9YDrKjYwERhxbUROgvqgHrn3UtbCO4Eow3LES8rESZEt4Y9E8WDEUiIb+GtSRbWFxOBV/fKfie1hoy0u6dIMUppK/eIvdQRE/34gP8K704r8p2SZaXzpPaYY/ihrtVaj2HXwz1i1q67QOgd1ZU3bso3VSLDPmBzGqK4Myb2fEHc=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(55016003)(47076005)(54906003)(166002)(356005)(8676002)(41300700001)(9686003)(83380400001)(86362001)(81166007)(36860700001)(33656002)(82740400003)(2906002)(5660300002)(70206006)(52536014)(4326008)(70586007)(82310400005)(107886003)(7696005)(6506007)(53546011)(45080400002)(186003)(336012)(26005)(40460700003)(110136005)(8936002)(316002)(478600001)(40480700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 11:55:55.5254
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e88d0b-eaf7-460f-4549-08dab8db5edd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5970

--_000_AS8PR08MB7991AB7CE4A56EFAB36708D892329AS8PR08MB7991eurp_
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64

SGkgQW5kcmV3IGFuZCBKYW4sDQoNClNvcnJ5IGZvciB0b3AgcG9zdGluZywgSSBkb24ndCByZWFs
bHkgd2FudCB0byBibG9jayB0aGlzIHNlcmllcyBzbyBJIGFtIGFuc3dlcmluZyB0aGlzIG9uIG15
IHBob25lLg0KDQpJIHNhdyBBbmRyZXcgcHJvdmlkZWQgaGlzIGFjaywgc2luY2UgdGhpcyBzZXJp
ZXMgaXMgcG9ydGVkIGZyb20gWGVuU2VydmVyIGFuZCBzaG91bGQgYmUgaW5jbHVkZWQgaW4gNC4x
Ny4NCg0KUmVsZWFzZS1hY2tlZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0K
DQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQq78cihIE91dGxvb2sgZm9yIGlPUzxodHRwczovL2Fr
YS5tcy9vMHVrZWY+DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0Kt6K8/sjLOiBB
bmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPg0Kt6LLzcqxvOQ6INDHxtrO
5Swgyq7UwiAyOCwgMjAyMiAxOToxMQ0KytW8/sjLOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz
ZS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcgPHhlbi1kZXZlbEBsaXN0cy54
ZW5wcm9qZWN0Lm9yZz4NCrOty806IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBSb2dlciBQYXUgTW9u
bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29t
PjsgR2VvcmdlIER1bmxhcCA8R2VvcmdlLkR1bmxhcEBjaXRyaXguY29tPg0K1vfM4jogUmU6IFtQ
QVRDSCAwLzNdWzQuMTc/XSB4ODYvcHYtc2hpbTogYmFsbG9vbmluZyBmaXhlcw0KDQpPbiAyOC8x
MC8yMDIyIDA4OjIwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gVGhlc2UgcGF0Y2hlcyBoYXZlIChh
cyBhIHNpbmdsZSwgbW9ub2xpdGhpYyBvbmUpIGJlZW4gbGl2aW5nIGluDQo+IHRoZSBYZW5TZXJ2
ZXIgcGF0Y2ggcXVldWUgZm9yIHF1aXRlIHNvbWUgdGltZS4gV2hpbGUgcHJlcGFyaW5nIGZvcg0K
PiB0aGlzIHVwc3RyZWFtIHN1Ym1pc3Npb24sIEkndmUgbGVmdCB0aGUgY29kZSBsYXJnZWx5IGFz
IGlzIChvbmx5IGENCj4gZmV3IGNvc21ldGljIGFkanVzdG1lbnRzLCBidXQgbm8gZnVuY3Rpb25h
bCBjaGFuZ2VzKSwgc28gdGhlIHNlcmllcw0KPiBjYW4gYmUgYXNzdW1lZCB0byBoYXZlIGJlZW4g
cHJvcGVybHkgdGVzdGVkLiBXaGF0IEkgZGlkIGZ1bGx5IGFsdGVyDQo+IHRob3VnaCBhcmUgdGhl
IGRlc2NyaXB0aW9ucy4NCj4NCj4gMTogY29ycmVjdGx5IGlnbm9yZSBlbXB0eSBvbmxpbmluZyBy
ZXF1ZXN0cw0KPiAyOiBjb3JyZWN0IGJhbGxvb25pbmcgdXAgZm9yIGNvbXBhdCBndWVzdHMNCj4g
MzogY29ycmVjdCBiYWxsb29uaW5nIGRvd24gZm9yIGNvbXBhdCBndWVzdHMNCg0KVGhhbmtzIGZv
ciBkb2luZyB0aGlzLiAgRnJvbSBvdXIgc2lkZSwgdGhleSBhbGwgY2FtZSBmcm9tIHRlc3Rpbmcg
d2hlcmUNCndlIHRvb2sgb3VyIGV4aXN0aW5nIFBWIGd1ZXN0IHRlc3RzIGFuZCByYW4gdGhlIGd1
ZXN0cyBzaGltbWVkLg0KDQpJJ20gcmVhc29uYWJseSBzdXJlIHRoZXJlIGFyZSBtb3JlIGlzc3Vl
cyBsdXJraW5nLCBidXQgdGhpcyBpcw0KZGVmaW5pdGVseSBhbiBpbXByb3ZlbWVudCBvbiBpdHMg
b3duLg0KDQpUaGV5IHdhbnQgYmFja3BvcnRpbmcgKGluIGR1ZSBjb3Vyc2UpLCBzbyBzaG91bGQg
YmUgY29uc2lkZXJlZCBmb3IgNC4xNw0Kc2VlaW5nIGFzIHRoZXkncmUgcmVhZHkgbm93Lg0KDQpB
Y2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg0K

--_000_AS8PR08MB7991AB7CE4A56EFAB36708D892329AS8PR08MB7991eurp_
Content-Type: text/html; charset="gb2312"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dgb2312">
</head>
<body>
<div dir=3D"ltr">
<div></div>
<div>
<div>Hi Andrew and Jan,</div>
<div dir=3D"ltr"><br>
</div>
<div dir=3D"ltr">Sorry for top posting, I don't really want to block this s=
eries so I am answering this on my phone.&nbsp;</div>
<div dir=3D"ltr"><br>
</div>
<div dir=3D"ltr">I saw Andrew provided his ack, since this series is ported=
 from XenServer and should be included in 4.17.</div>
<div dir=3D"ltr"><br>
</div>
<div dir=3D"ltr"><span style=3D"caret-color:rgb(33, 33, 33);color:rgb(33, 3=
3, 33);font-size:14.666667px;display:inline !important">Release-acked-by: H=
enry Wang &lt;</span><span dir=3D"ltr" style=3D"color:rgb(0, 120, 212);font=
-size:14.666667px">Henry.Wang@arm.com</span><span style=3D"caret-color:rgb(=
33, 33, 33);color:rgb(33, 33, 33);font-size:14.666667px;display:inline !imp=
ortant">&gt;</span><br style=3D"caret-color:rgb(33, 33, 33);color:rgb(33, 3=
3, 33);font-size:14.666667px">
<br style=3D"caret-color:rgb(33, 33, 33);color:rgb(33, 33, 33);font-size:14=
.666667px">
<span style=3D"caret-color:rgb(33, 33, 33);color:rgb(33, 33, 33);font-size:=
14.666667px;display:inline !important">Kind regards,</span><br style=3D"car=
et-color:rgb(33, 33, 33);color:rgb(33, 33, 33);font-size:14.666667px">
<span style=3D"caret-color:rgb(33, 33, 33);color:rgb(33, 33, 33);font-size:=
14.666667px;display:inline !important">Henry</span><br>
</div>
<div id=3D"ms-outlook-mobile-signature">
<div><br>
</div>
=BB=F1=C8=A1 <a href=3D"https://aka.ms/o0ukef">Outlook for iOS</a></div>
<div id=3D"mail-editor-reference-message-container" class=3D"ms-outlook-mob=
ile-reference-message">
<hr style=3D"display:inline-block;width:98%" tabindex=3D"-1">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif"><b=
>=B7=A2=BC=FE=C8=CB:</b> Andrew Cooper &lt;Andrew.Cooper3@citrix.com&gt;<br=
>
<b>=B7=A2=CB=CD=CA=B1=BC=E4:</b> =D0=C7=C6=DA=CE=E5, =CA=AE=D4=C2 28, 2022 =
19:11<br>
<b>=CA=D5=BC=FE=C8=CB:</b> Jan Beulich &lt;jbeulich@suse.com&gt;; xen-devel=
@lists.xenproject.org &lt;xen-devel@lists.xenproject.org&gt;<br>
<b>=B3=AD=CB=CD:</b> Wei Liu &lt;wl@xen.org&gt;; Roger Pau Monne &lt;roger.=
pau@citrix.com&gt;; Henry Wang &lt;Henry.Wang@arm.com&gt;; George Dunlap &l=
t;George.Dunlap@citrix.com&gt;<br>
<b>=D6=F7=CC=E2:</b> Re: [PATCH 0/3][4.17?] x86/pv-shim: ballooning fixes
<div>&nbsp;</div>
</font></div>
<meta name=3D"Generator" content=3D"Microsoft Exchange Server">
<!-- converted from text --><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">On 28/10/2022 08:20, Jan Beulich wrote:<br>
&gt; These patches have (as a single, monolithic one) been living in<br>
&gt; the XenServer patch queue for quite some time. While preparing for<br>
&gt; this upstream submission, I've left the code largely as is (only a<br>
&gt; few cosmetic adjustments, but no functional changes), so the series<br=
>
&gt; can be assumed to have been properly tested. What I did fully alter<br=
>
&gt; though are the descriptions.<br>
&gt;<br>
&gt; 1: correctly ignore empty onlining requests<br>
&gt; 2: correct ballooning up for compat guests<br>
&gt; 3: correct ballooning down for compat guests<br>
<br>
Thanks for doing this.&nbsp; From our side, they all came from testing wher=
e<br>
we took our existing PV guest tests and ran the guests shimmed.<br>
<br>
I'm reasonably sure there are more issues lurking, but this is<br>
definitely an improvement on its own.<br>
<br>
They want backporting (in due course), so should be considered for 4.17<br>
seeing as they're ready now.<br>
<br>
Acked-by: Andrew Cooper &lt;andrew.cooper3@citrix.com&gt;<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>

--_000_AS8PR08MB7991AB7CE4A56EFAB36708D892329AS8PR08MB7991eurp_--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 12:12:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 12:12:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432023.684701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooODK-0006ey-SI; Fri, 28 Oct 2022 12:11:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432023.684701; Fri, 28 Oct 2022 12:11:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooODK-0006er-OP; Fri, 28 Oct 2022 12:11:54 +0000
Received: by outflank-mailman (input) for mailman id 432023;
 Fri, 28 Oct 2022 12:11:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooODJ-0006eh-L3; Fri, 28 Oct 2022 12:11:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooODJ-0002Nf-HL; Fri, 28 Oct 2022 12:11:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooODJ-0004O1-1b; Fri, 28 Oct 2022 12:11:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooODJ-0003V8-13; Fri, 28 Oct 2022 12:11:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=P3uGst/lCbNUslVihsCEQxvGbtXe/zHol8f2bZRh0cg=; b=M2CjgyWmSHuJ0/yqLJtHxQegeG
	zPF2fKP/SjOadY9my7cmDIam4A8LGUQITVbQG3J7wK45Ooaj9yvPw3PxOObjzYT80Sz2/EiT6QeeP
	GwWCSULV4mkjyyxE7NzqBwzXXPi9QBNPsn0rSJcvhRtFVeCZFq1ulCt6z1ZXfkrKj73M=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174516-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174516: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=200204f56f3b5a464c719ddb930a1a2557562dda
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 12:11:53 +0000

flight 174516 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174516/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                200204f56f3b5a464c719ddb930a1a2557562dda
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   20 days
Failing since        173470  2022-10-08 06:21:34 Z   20 days   28 attempts
Testing same since   174516  2022-10-27 20:49:06 Z    0 days    1 attempts

------------------------------------------------------------
1422 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 133804 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 12:50:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 12:50:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432036.684723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooOoD-0002yN-0B; Fri, 28 Oct 2022 12:50:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432036.684723; Fri, 28 Oct 2022 12:50:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooOoC-0002yE-TO; Fri, 28 Oct 2022 12:50:00 +0000
Received: by outflank-mailman (input) for mailman id 432036;
 Fri, 28 Oct 2022 12:49:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ToJk=25=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ooOoB-0002xh-73
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 12:49:59 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam02on2042.outbound.protection.outlook.com [40.107.95.42])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 05f727d6-56bf-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 14:49:57 +0200 (CEST)
Received: from BLAPR03CA0014.namprd03.prod.outlook.com (2603:10b6:208:32b::19)
 by IA1PR12MB6580.namprd12.prod.outlook.com (2603:10b6:208:3a0::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 12:49:53 +0000
Received: from BL02EPF0000C407.namprd05.prod.outlook.com
 (2603:10b6:208:32b:cafe::30) by BLAPR03CA0014.outlook.office365.com
 (2603:10b6:208:32b::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.29 via Frontend
 Transport; Fri, 28 Oct 2022 12:49:52 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BL02EPF0000C407.mail.protection.outlook.com (10.167.241.9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Fri, 28 Oct 2022 12:49:52 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 07:49:51 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 05:49:46 -0700
Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Fri, 28 Oct 2022 07:49:44 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05f727d6-56bf-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eMD3YJJfx4DdAA3SI2NCUFPbKgYlPPmDReq6y/MTP0rLaqJpvQ3uE8r/D9R2WngY4ak03BcfszYPxMfsrhze6uetoTgsVczuUbrCSB69hxbILMK9x1MCu/d8EKeV90b/VrUala5Z/fUAUzXGa9GiGdRvEXiMmNaDmtcMbOnaPyoL1UtmAlEUmXNBGjxycqsOf/yno/fczJVE7Gdxoxtd5rEKX3liJMohpFBrcXrOa9ldQQzKFVzBjbQh0Qv6ZTkvHeiudvYS2Tv99RL4U4ZZhb0dwhUM+Q+0AEr8Q9nC9uCtaOX4SG2OKuv+0j33DrftDTY/zJnKfsXzSg5hkUoZbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pRgEOTS1Rmgglb4+SH4FFiPgR6NU5Z4DYRT+gL0JZcA=;
 b=YSwU8EkmXfOfmbzPPA3cIolwhiOtJYqLtLKosiv8JvBXcnC+WJgRTT9BSJLZYa8LbjFRTFf8WqDjhvEuWb0jxXg9TDnU8fhgeHUUST3OBuBV3CGCNrvK9+LeSNYj9VD3V0UCsPeAogdLrw3hEKlUlvNiyVMel4rxm9MR2zvtCL19Hi9SnsDc+TBoznCybQnIIiMCVATsCi7b/XrqkhbtiJ/CHeeiYIWMeFbNExt/Bvg5yp4IlWVVVZcIpbP+Kph2ODg51nKmnxbHcrogSeoBv0ZqO4lBxghjueLxq79jR1zrAfhak3eVpYhaHFlO//+hQcHyQZzkVyI6eH35AMVWhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pRgEOTS1Rmgglb4+SH4FFiPgR6NU5Z4DYRT+gL0JZcA=;
 b=BXnosmD6+Ryarey/82vSM3Ki8WhyEm9LZHxsnPO4LmoJL8miq1Qg2tY52ntSUY/kFlPesoTyJOCH2Zm5wO8R9eqbI+XkJvFWi9MqwFEAO5QuaHvlzjXFMY6SedhBSHAD+lmX6vB5UB/9NV4zZ58A2KTZwllc+eXiRJANt0H5cqc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Michal Orzel <michal.orzel@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: Michal Orzel <michal.orzel@amd.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Bertrand Marquis
	<bertrand.marquis@arm.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] xen/arm: Do not route NS phys timer IRQ to Xen
Date: Fri, 28 Oct 2022 14:49:37 +0200
Message-ID: <20221028124937.27677-1-michal.orzel@amd.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BL02EPF0000C407:EE_|IA1PR12MB6580:EE_
X-MS-Office365-Filtering-Correlation-Id: 765ff581-ba31-43b9-ccbc-08dab8e2e840
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XT6ITHF9kZbGL//bFDa9JaYcVK9XRoSy9HqxyabqWKRqqs7jZsxb1N1LmnGi3Z/D4bYyn6q9CWAwZmMEG+Y2/amgF0J6KsWxQ3WPumVZn8l32nL+Do7pp/ffciBwtxGoY4ncHZQ1YaZ91l/ujymz4KJAYESeOXJfnQCm7xuhYVPEHOcm4Lydhan3TZmUPLvd9Drkq4M6PRhd7zn8+te3++N4Am8JopMR53qd0ZTcyTVamNWorgtK5k8oYdfYV0fnLUDhgSCJVCRTh3+Vn0Bbj+mYr14CI3eGTjEsGofzupDlukUCef1X+YruQTwQ98F9Dmmjq/gZ342UIYqf+AafuhbgbYGluc2jWe6mUDeXWATUtJ9H21KcNVc3p07Oz+9WkrraQiw6Ip+svf9lDPd8nTLbqZfkDOgQ5vceRHqKOueT3tm93UjIlHD7jhNdE7WWMlseirVAGyt8+hAT+jmOyQ2tGA1G7ybEI8PZ6ylGboIobz4RElkl6SKRXiQfPPzrHcKGDVBQFdq+bpJyx/WqMBjYfQ3+vV7RAnUolzBnEkO2ZizMuck69J2Dpt00p4UniKF0of/t4Ooe7LdYwqsAbVYJ29AqcxqlorvgEWxH8WsURXZTbgmCMr4ac82/7e2AK2o5FMgrBSmHGsVHp6/H673Dz2TB4khR0k/4VuFxgv6YcfHw8NR4gKIdkJIpho4gxiZeN3hIRg2Ec/HEiZR/mKh566PJKSYZ0A8/E82NVlu8fZfPQhvLZVv4BLd1shTFQhrLPT65wo6FjlWzs/JpycDfAJdSy/bL1GkOoQddi2gd6f2We+IG7LtPwW4lZzncDZRsvZ1iPve+4/NDuTNS8Q==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(36756003)(83380400001)(44832011)(2616005)(47076005)(426003)(356005)(82740400003)(966005)(186003)(8936002)(81166007)(478600001)(336012)(86362001)(40460700003)(41300700001)(1076003)(70206006)(70586007)(2906002)(4326008)(5660300002)(8676002)(40480700001)(36860700001)(6916009)(54906003)(26005)(316002)(82310400005)(6666004)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 12:49:52.4558
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 765ff581-ba31-43b9-ccbc-08dab8e2e840
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BL02EPF0000C407.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6580

At the moment, we route NS phys timer IRQ to Xen even though it does not
make use of this timer. Xen uses hypervisor timer for itself and the
physical timer is fully emulated, hence there is nothing that can trigger
such IRQ. This means that requesting/releasing IRQ ends up as a deadcode
as it has no impact on the functional behavior, whereas the code within
a handler ends up being unreachable. This is a left over from the early
days when the CNTHP IRQ was buggy on the HW model used for testing and we
had to use the CNTP instead.

Remove the calls to {request/release}_irq for this timer as well as the
code within the handler. Since timer_interrupt handler is now only used
by the CNTHP, refactor it as follows:
 - rename it to htimer_interrupt to reflect its purpose,
 - remove the IRQ affiliation test,
 - invert the condition to avoid indented code and use unlikely,
 - improve readability by adding new lines \btw code and comments.

Keep the calls to zero the CNTP_CTL_EL0 register for sanity and also
remove the corresponding perf counter definition.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Changes in v2:
 - take the opportunity to rename the handler, modify the condition to
   avoid the indented code and improve readability.

Based on the outcome of the following discussion:
https://lore.kernel.org/xen-devel/d55938a3-aaca-1d01-b34f-858dbca9830b@amd.com/
---
 xen/arch/arm/include/asm/perfc_defn.h |  1 -
 xen/arch/arm/time.c                   | 34 +++++++++------------------
 2 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h
index 31f071222b24..3ab0391175d7 100644
--- a/xen/arch/arm/include/asm/perfc_defn.h
+++ b/xen/arch/arm/include/asm/perfc_defn.h
@@ -70,7 +70,6 @@ PERFCOUNTER(spis,                 "#SPIs")
 PERFCOUNTER(guest_irqs,           "#GUEST-IRQS")
 
 PERFCOUNTER(hyp_timer_irqs,   "Hypervisor timer interrupts")
-PERFCOUNTER(phys_timer_irqs,  "Physical timer interrupts")
 PERFCOUNTER(virt_timer_irqs,  "Virtual timer interrupts")
 PERFCOUNTER(maintenance_irqs, "Maintenance interrupts")
 
diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index dec53b5f7d53..0054cf2b7b78 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -220,27 +220,18 @@ int reprogram_timer(s_time_t timeout)
 }
 
 /* Handle the firing timer */
-static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
+static void htimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
 {
-    if ( irq == (timer_irq[TIMER_HYP_PPI]) &&
-         READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING )
-    {
-        perfc_incr(hyp_timer_irqs);
-        /* Signal the generic timer code to do its work */
-        raise_softirq(TIMER_SOFTIRQ);
-        /* Disable the timer to avoid more interrupts */
-        WRITE_SYSREG(0, CNTHP_CTL_EL2);
-    }
+    if ( unlikely(!(READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING)) )
+        return;
 
-    if ( irq == (timer_irq[TIMER_PHYS_NONSECURE_PPI]) &&
-         READ_SYSREG(CNTP_CTL_EL0) & CNTx_CTL_PENDING )
-    {
-        perfc_incr(phys_timer_irqs);
-        /* Signal the generic timer code to do its work */
-        raise_softirq(TIMER_SOFTIRQ);
-        /* Disable the timer to avoid more interrupts */
-        WRITE_SYSREG(0, CNTP_CTL_EL0);
-    }
+    perfc_incr(hyp_timer_irqs);
+
+    /* Signal the generic timer code to do its work */
+    raise_softirq(TIMER_SOFTIRQ);
+
+    /* Disable the timer to avoid more interrupts */
+    WRITE_SYSREG(0, CNTHP_CTL_EL2);
 }
 
 static void vtimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
@@ -302,12 +293,10 @@ void init_timer_interrupt(void)
     WRITE_SYSREG(0, CNTHP_CTL_EL2);   /* Hypervisor's timer disabled */
     isb();
 
-    request_irq(timer_irq[TIMER_HYP_PPI], 0, timer_interrupt,
+    request_irq(timer_irq[TIMER_HYP_PPI], 0, htimer_interrupt,
                 "hyptimer", NULL);
     request_irq(timer_irq[TIMER_VIRT_PPI], 0, vtimer_interrupt,
                    "virtimer", NULL);
-    request_irq(timer_irq[TIMER_PHYS_NONSECURE_PPI], 0, timer_interrupt,
-                "phytimer", NULL);
 
     check_timer_irq_cfg(timer_irq[TIMER_HYP_PPI], "hypervisor");
     check_timer_irq_cfg(timer_irq[TIMER_VIRT_PPI], "virtual");
@@ -326,7 +315,6 @@ static void deinit_timer_interrupt(void)
 
     release_irq(timer_irq[TIMER_HYP_PPI], NULL);
     release_irq(timer_irq[TIMER_VIRT_PPI], NULL);
-    release_irq(timer_irq[TIMER_PHYS_NONSECURE_PPI], NULL);
 }
 
 /* Wait a set number of microseconds */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 12:50:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 12:50:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432035.684712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooOo8-0002ie-QO; Fri, 28 Oct 2022 12:49:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432035.684712; Fri, 28 Oct 2022 12:49:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooOo8-0002iX-LL; Fri, 28 Oct 2022 12:49:56 +0000
Received: by outflank-mailman (input) for mailman id 432035;
 Fri, 28 Oct 2022 12:49:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=22xF=25=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1ooOo7-0002iQ-9G
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 12:49:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 0227d0bf-56bf-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 14:49:49 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C075D1FB;
 Fri, 28 Oct 2022 05:49:58 -0700 (PDT)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 995923F445;
 Fri, 28 Oct 2022 05:49:51 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0227d0bf-56bf-11ed-8fd0-01056ac49cbb
Date: Fri, 28 Oct 2022 13:49:47 +0100
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayankuma@amd.com>
Cc: Julien Grall <julien@xen.org>, "stefanos@xilinx.com"
 <stefanos@xilinx.com>, bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
Message-ID: <20221028134947.6cc0b985@donnerap.cambridge.arm.com>
In-Reply-To: <5afda99e-dd57-5820-7075-6b60e7a794f7@amd.com>
References: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
	<20221025145506.5708839c@donnerap.cambridge.arm.com>
	<7f1bdc88-da6b-9a0c-03d4-319e9d8966d4@amd.com>
	<20221027153632.0cf7d004@donnerap.cambridge.arm.com>
	<5afda99e-dd57-5820-7075-6b60e7a794f7@amd.com>
Organization: ARM
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 28 Oct 2022 12:44:08 +0100
Ayan Kumar Halder <ayankuma@amd.com> wrote:

> On 27/10/2022 15:36, Andre Przywara wrote:
> > On Thu, 27 Oct 2022 14:38:52 +0100
> > Ayan Kumar Halder <ayankuma@amd.com> wrote:
> >
> > Hi Ayan, =20
> Hi Andre / Julien,
> > =20
> >> On 25/10/2022 14:55, Andre Przywara wrote: =20
> >>> On Tue, 25 Oct 2022 13:25:52 +0100
> >>> Ayan Kumar Halder <ayankuma@amd.com> wrote:
> >>>
> >>> Hi, =20
> >> Hi Andre,
> >>
> >> Many thanks for the explanation.
> >>
> >> I need a clarification on the issue of atomic access to 64bit normal
> >> memory on R52.
> >> =20
> >>>    =20
> >>>> Hi Andre/All,
> >>>>
> >>>> This came up while porting Xen on R52.
> >>>>
> >>>> Refer "ARM DDI 0568A.cID110520", B1.3.1
> >>>>
> >>>> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE
> >>>> must not implement LPI support. "
> >>>>
> >>>> Does this mean ITS is not supported on R52 ? I am assuming yes, plea=
se
> >>>> correct me if mistaken. =20
> >>> An ITS relies on LPIs, so yes: no ITS on a v8-R32 system. I cannot fi=
nd
> >>> this restriction anymore in the v8-R64 supplement, so it would only a=
pply
> >>> to the R52/AArch32.
> >>>    =20
> >>>> If the answer is no, then my next query is follows :- =20
> >>> Answering to that anyway ...
> >>>    =20
> >>>> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
> >>>> index 9ca74bc321..dea60aac0d 100644
> >>>> --- a/xen/arch/arm/gic-v3-lpi.c
> >>>> +++ b/xen/arch/arm/gic-v3-lpi.c
> >>>> @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_l=
pi_bits)
> >>>>    =C2=A0=C2=A0=C2=A0=C2=A0 int rc;
> >>>>
> >>>>    =C2=A0=C2=A0=C2=A0=C2=A0 /* We rely on the data structure being a=
tomically accessible. */
> >>>> -=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uns=
igned long));
> >>>> +=C2=A0=C2=A0=C2=A0 BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uin=
t64_t));
> >>>>
> >>>> "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.
> >>>>
> >>>> Is it fine to change it as above ?
> >>>>
> >>>> Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-co=
py
> >>>> atomicity".
> >>>>
> >>>> "LDRD and STRD accesses to 64-bit aligned locations are 64-bit
> >>>> single-copy atomic as seen by translation table walks and accesses to
> >>>> translation tables" =20
> >>> This (and the explaining paragraph) indeed suggests that this should
> >>> work architecturally, if you use normal system memory (where you would
> >>> hold page tables). It would be confined to ARMv8 AArch32 and ARMv7 w/
> >>> LPAE, which matches Xen's requirements. =20
> >> Does it mean that ldrd/strd will not work atomically on AArch32-v8R as
> >> it uses MPU (not MMU, so no page tables) ? =20
> > No, this mentioning of page tables is more an example or a rationale, t=
han
> > a requirement.
> > What this means (in the ARMv7-A/ARMv8-A AArch32 context) it:
> > Because on v7A-LPAE and v8-AArch32 PTEs are 64 bits wide, it's too pain=
ful
> > to use explicit locking to make sure just writing one PTE is atomic. So
> > the architecture demands that 64-bit aligned accesses using ldrd/strd
> > are single-copy atomic, so software can update just one PTE easily. But
> > this is only required for locations where page tables typically reside,=
 so
> > system memory. This avoids this 64-bit atomicity requirement for *every*
> > part of the system, for instance separate buses, SRAM or flash on small=
er
> > buses, or MMIO in general.
> >
> > I don't find anything in the v8-R32 supplement that would step back from
> > this requirement, although indeed the original reason (atomic PTE write=
s)
> > would not apply to v8-R32. Both the LDRD/STRD description and the secti=
on
> > listing differences in the system memory architecture do not mention
> > anything, so I'd say that the ldrd atomicity requirement still holds.
> >
> > Please note that this only applies to ARMv7 *LPAE* systems, but Xen
> > requires LPAE, and R52 is v8, so we are good, and the Xen code can rely=
 on
> > this.
> >
> > So for Xen on ARMv8-R32:
> > *LDRD/STRD* accesses to *64-bit aligned* addresses in *RAM* would be
> > atomic. You need to satisfy all three requirements:
> > - You must use ldrd/strd. Just dereferencing a uint64_t pointer in C do=
es
> > not guarantee that, but read_atomic()/write_atomic() does.
> > - It must be 64-bit aligned. Shouldn't be a problem if the data type is
> > 64 bits wide. Please note the slight nastiness that ldrd would silently
> > work on non-aligned addresses, but would lose the atomicity guarantee.
> > ldrexd would always fault if the address is not aligned.
> > We might want to check the alignment of data we access (assert?), if not
> > done already.
> > - It must be in system RAM, so not MMIO. Also I think TCM might be a
> > different story, but I would hope Xen would not use that directly.
> > =20
> Many thanks for the nice explanation.
>=20
> I am trying to compare this with the atomicity requirement for AArch64=20
> (ARM DDI 0487G.b ID072021, B2.2.1 Requirements for single-copy atomicit )
>=20
> I seethat the alignment requirement is the same as for ARMv8-R32.
>=20
> "-A read that is generated by a load instruction that loads a single=20
> general-purpose register and is aligned to the size of the read in the=20
> instruction is single-copy atomic.
>=20
> -A write that is generated by a store instruction that stores a single=20
> general-purpose register and is aligned to the size of the write in the=20
> instruction is single-copy atomic"
>=20
> I think the following code change should help us to confirm the correct=20
> behavior of atomic read/write on both AArch64 and AArch32 (including R52).
>=20
> diff --git a/xen/arch/arm/include/asm/atomic.h=20
> b/xen/arch/arm/include/asm/atomic.h
> index ac2798d095..f22c65a853 100644
> --- a/xen/arch/arm/include/asm/atomic.h
> +++ b/xen/arch/arm/include/asm/atomic.h
> @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const=20
> volatile void *p,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *res,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int size)
>  =C2=A0{
> +=C2=A0=C2=A0=C2=A0 ASSERT(IS_ALIGNED((unsigned long)p, size));
>  =C2=A0=C2=A0=C2=A0=C2=A0 switch ( size )
>  =C2=A0=C2=A0=C2=A0=C2=A0 {
>  =C2=A0=C2=A0=C2=A0=C2=A0 case 1:
> @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile=
=20
> void *p,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void *val,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int size)
>  =C2=A0{
> +=C2=A0=C2=A0=C2=A0 ASSERT(IS_ALIGNED((unsigned long)p, size));
>  =C2=A0=C2=A0=C2=A0=C2=A0 switch ( size )
>  =C2=A0=C2=A0=C2=A0=C2=A0 {
>  =C2=A0=C2=A0=C2=A0=C2=A0 case 1:
>=20
> Please let me know if I misunderstand something.

Yes, that looks correct. Even the more "simple" atomic accesses always
require alignment, so if you do an unaligned 32-bit read in AArch64, it
wouldn't be single-copy atomic either.

Cheers,
Andre

> >> If so, then is using ldrexd/strexd the solution for this ? =20
> > As mentioned above, you would not need that, just
> > read_atomic()/write_atomic() would do.
> >
> > Hope that clears that up.
> >
> > Cheers,
> > Andre
> >
> > P.S. This above is my reading of the ARM ARM and the R32 supplement. I =
can
> > double check with the architects, but this might take a while.
> > =20
> >> IIUC "Memory accesses caused by LDREXD and STREXD instructions to
> >> doubleword-aligned locations.", then the answer seems yes.
> >>
> >> - Ayan
> >> =20
> >>> But it's only atomic if you are using ldrd/strd, which you cannot kno=
w for
> >>> sure in C, because it's up to the compiler to generate the instructio=
ns.
> >>>
> >>> This is why we have that test. Changing the unsigned long to uint64_t
> >>> would make the check pointless, since the data structure is 64-bits l=
ong,
> >>> so it would always be true.
> >>>
> >>> So given that you don't seem to need it, right now, it would leave the
> >>> test alone.
> >>>
> >>> If you need that on AArch32 anyway, you would need to replace accesse=
s to
> >>> the host_lpis array with inline assembly accessors, to ensure ldrd/st=
rd
> >>> instructions. This seems doable (there are only so many places which
> >>> directly access the array members), but would need a good use case.
> >>>
> >>> Cheers,
> >>> Andre
> >>>    =20
> >>>> Does this imply that atomicity will be retained (with the above chan=
ge)
> >>>> ? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so
> >>>> translation tables are irrelevant).
> >>>> Kind regards,
> >>>> Ayan
> >>>>    =20



From xen-devel-bounces@lists.xenproject.org Fri Oct 28 12:55:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 12:55:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432049.684734 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooOti-00051r-Pe; Fri, 28 Oct 2022 12:55:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432049.684734; Fri, 28 Oct 2022 12:55:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooOti-00051k-N0; Fri, 28 Oct 2022 12:55:42 +0000
Received: by outflank-mailman (input) for mailman id 432049;
 Fri, 28 Oct 2022 12:55:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5f+i=25=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1ooOtg-00051e-L2
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 12:55:40 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur02on2066.outbound.protection.outlook.com [40.107.249.66])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d01afa90-56bf-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 14:55:35 +0200 (CEST)
Received: from DB6PR0202CA0001.eurprd02.prod.outlook.com (2603:10a6:4:29::11)
 by DB9PR08MB6700.eurprd08.prod.outlook.com (2603:10a6:10:2a3::9) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 12:55:26 +0000
Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:29:cafe::76) by DB6PR0202CA0001.outlook.office365.com
 (2603:10a6:4:29::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 12:55:25 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5723.32 via Frontend Transport; Fri, 28 Oct 2022 12:55:25 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 28 Oct 2022 12:55:25 +0000
Received: from e42fd5a3084f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 389EC0A2-DF24-41E3-84A3-765171C97615.1; 
 Fri, 28 Oct 2022 12:54:57 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e42fd5a3084f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 12:54:57 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24)
 by DB9PR08MB6636.eurprd08.prod.outlook.com (2603:10a6:10:250::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 12:54:53 +0000
Received: from AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572]) by AS8PR08MB7158.eurprd08.prod.outlook.com
 ([fe80::3120:4825:cfd7:e572%5]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 12:54:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d01afa90-56bf-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=YSFlrfCzj6fDKAW7xsub2vaNlc3qNAcGndBTxh0eZi8HNkkxmrogW2nR8/zzRjphicx+ld7VNhIWpTKYm9tgIo5UKmeTFVGgnkBsuXLahIVE6mHCU1RVt5L1+70Yq2heFLicTuzfnb+zYTEwp7Ybufq2Qzxv6kGOqpyAUbo8ZiCImmEvHIn8k5Cq1vgG0mbc8+BwFepIj/Twy5y5jtdjxro0tEEb8KyON+NhkHzNCFIQSsOeKKFPwq6wfFfIMmLbaJsTb341lF6BIgLnBJX8AtRmk2whVZsnTk0T2OpPjr3mEkETyTbVXE8B69mjborX4rd3hXzZdEyHv/MvbaCWFA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tthXLs2zOVCypLamcBuWNGpKnfaDLa+0iiu8eZplBrw=;
 b=SjIieViLXQysj05ObLZQJojrhIZqZ6xM5ltRyhntCTCPlqHXARMt0BywZiyVE7F2gCdV0r42KMOvj8KA80noPidmQZ7kfVOJERzOHKhdTw5stAYRqxged0sYI4EGbDxFJKrG6roH1xLeXYbTU+8HcQDQsOjlOytOYY7d/QPrRcnMDSdzzBH8oiYHdMj5pWoU7glXnaifi2AudbMByfuSFrgPS48k+od0J9tZi/RLV+kSJYREXiolF25yGQbWUCxi6pQP/sDC3u30WxaehXZTuUmAb0pMWzBAUF77SLFINKZ77xd76k57xiX+5e1rc+czDHHJB2lkJNg0vSGk+M+p2A==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tthXLs2zOVCypLamcBuWNGpKnfaDLa+0iiu8eZplBrw=;
 b=IZzMNG4PW5Rh9dYsbQkxKu6/P6sTadNzL+c1howxVNogeBMKAVdz4L+rzCFpIsYR+twDBeknF87l5/kthCGWVrIEcmLyU0qZbeOxzh8lTpFQmplVt0c7xbOhKgjOrPmtcRQJspG+StrCvC6HJaifo3g0QmxN11YGt7MdW6WDbsU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Uzogs42MChX0yrHRyaApgj2e4PVmwkAyfFcuOtYbPhoyb8FvKaQtt+sG8Cbza8mXlocM+1Y2XJv38gKYBGVddou0JODrSrj5Y2Q6FsIe5S/PjJG+gi1eBOVpVJqfudbyydAD0JufDm2X+oZLlP6jsrTDOLa8iC2BXumJMpbLsK2+EmaFNVy8umVlqFbEFEeBTVGFwg4mWTgLS3l3ypo716YEFEIH2tC8GFuvNsYSbmBRUX7A38VlqwPClCCppKg+qZuWj2eMxvkcigKGkoCTD+KhzYzHIsIhL1eu5zvBvkXl6MzBmQuNmX7iuxe809j/9KPk1KlD4ByQDctb8ei9fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tthXLs2zOVCypLamcBuWNGpKnfaDLa+0iiu8eZplBrw=;
 b=lrAQ1QEKyiRM4xegB9JE6onvkB89m8s2jQZICI4/hUZx8xmbt/6Z4e+a1y6Kvw4dJ6kfXLVZQzy3EOnQ+DBG5RLIC/VBhZy5iDL7lzyAj3LYUh2iyJLj29nfJqh5QOUGXIrkAwMMiROcAtZUsTiZsTOv9EyBKjdm79vybaBxd6d8UIVM0z9oHmX43DJVE2IGMyXFf+O9MJAxzL/4lUyt03W5Uv+tLPRc7UOjex2MGks82NGLJRnxeNtfwbN/UBY/Mi8vDi0TNQwLM8Sqez++7j8VT16FAsVBQ4r5komowMctvltGEzyW6fCkIpOx0efsXT1uzPIy+gFO6O34PCy1pQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tthXLs2zOVCypLamcBuWNGpKnfaDLa+0iiu8eZplBrw=;
 b=IZzMNG4PW5Rh9dYsbQkxKu6/P6sTadNzL+c1howxVNogeBMKAVdz4L+rzCFpIsYR+twDBeknF87l5/kthCGWVrIEcmLyU0qZbeOxzh8lTpFQmplVt0c7xbOhKgjOrPmtcRQJspG+StrCvC6HJaifo3g0QmxN11YGt7MdW6WDbsU=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: Xen developer discussion <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index:
 AQHY6T1VjOHHQJGN7kyXeL6pAIKNMa4grXIAgAAQBQCAAFgAAIABVMsAgAAG7ICAAVVHAA==
Date: Fri, 28 Oct 2022 12:54:53 +0000
Message-ID: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
In-Reply-To: <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AS8PR08MB7158:EE_|DB9PR08MB6636:EE_|DBAEUR03FT033:EE_|DB9PR08MB6700:EE_
X-MS-Office365-Filtering-Correlation-Id: 77ad6d3e-3d10-4eec-4157-08dab8e3aee4
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 s89zy0QvCLwHyjec0bnKPiwsrBSo9eg9CnFke7L3hY0hCWOq+VCSa8luld893MlWxIXf1o9lgSfl4iSxXp3rEcYBeMKRyNUF28pu1H2pci09dOicB5kQLRtDidc7KAI7ARB483Tpq+JpebLzIdv525GAE5I76/2TrZn+yfQ0E8GNcGgRApuAYjFWkN/y54z7G2YjECtOn6JidrDatv1udGn+gRZmoEUHf6v0syquXkR/7iRzvfqkNlGzekgpiS7ywVpurlDv059MnOtW0f7QKmbvY4pTm+4sToA0bmnHSC6kLaj71WpZwSbUXjAlpzRjpJmOWImABgVrr+RqlcfM2sGNWPa5PfukmwlqGu19xPd5qlppD/1bYIpd8klzs3QdZFQ83WoFYyD9aYy+pCTygcYJMrWb3LMLJUBoPN7qWIFRoZNWAo9QNZ0J1vZmhXGT9o+POHmgMLyPs38xKGxpBcYEqDLm2/M+oV+SP4cAc/3P/4+SSAsOrlt5K6mAzejJwdkGeJVgWaHR7ZwPE2LGOLVBtXaosFak9KoKdy1YDexgvXZyWxNAX/Z5fz9B+N5VWWwrYY61bhLIWhW0re0eCKmFtnZWk2UISU0C6WsX5x/00PxdixW6c7DmHFhyKLyejd2oFoTE1N1zQ5cv49lqrd0rSphq38dM7ErqzzNllyrKwS6dG2DJtXyFfTlW0qE8PNkkaBK11HtMaCcYREbBtQLcDM+hb5VVTb9U3oJCx9ugN/j8R8xV1VKAOKAPlKGk4Z685lQwoXXAga0LTqKFCwm2FHWy7SHZAIiRBHIPoRs=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(39860400002)(136003)(346002)(376002)(451199015)(186003)(478600001)(6486002)(86362001)(71200400001)(41300700001)(66556008)(66476007)(54906003)(66946007)(64756008)(66446008)(26005)(6512007)(6506007)(7416002)(36756003)(316002)(76116006)(6916009)(5660300002)(91956017)(30864003)(2906002)(38100700002)(122000001)(8936002)(33656002)(53546011)(8676002)(2616005)(4326008)(83380400001)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <24D29E196722784199B5E6E6BC0081C1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6636
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	327f3a3a-4bdf-4110-d046-08dab8e39b8d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	axCOKcQ7WkaSCMX0H2gl+J5bpm8e7dI9+Kh1I3b3ZiVFe4wyP+Uk4HXBD9ByhfCFXDn9SNL4Q7IC1H5ZRhycLPQ4c2i8Tg0a4LCJ2XcSN6Se9Z2vuf37IKChPiDWezPftb1SqjDNsMAZa9w7+W8pwvWvlBdg6uKFYj770jlaE0PqRs4uILsat85qnQNm6/r1OKjTEJqRUZ4h40b8Tz/ynPl1BTKO0Nc/JWE8t3PTDBd+Ui124rnoe0uz/tT1yaX9MQmwxUK4l20NSkZXkJ90r2dGCca6628C2s5w1991n1t7qjx0mg/ZqE+2FKLoiQtg6A6mm0fp9XsjTglCk9MJzzhSMDwATP5s0MXdzwr2B8VZfP14GaYnIrR1uOjHhTPCcSTV7B3wFhQ4Bj13UiQ2Ij4hWq+P+nK1sRlceCSa2fMEHDh0X0D9+1C0GNrYIn8otX/gVSr6uCddxb1erYZ3w9driIM6yfeATG+MaEHNZIkZM0TpnRf0qxtndBvBhoCSa1xWidbYyS+c5m7XJuDegisjvN7qsuK4razvpYOI57jUiyOxSHfHnbKiEhbOrc8Rcz/j+uyi+4dWfvh66CtN1MKK4wai80Ig2aFFsEZF3cdvMPIjJx8ob5G6v3eVWzmF8COxdBTW+VY9SI+36wCII+Qo7UuxPfnjRFkvV6B+dCuNkG6XGk1gtdCTNPaQMoX/wXM1aVyJhEpa1qsVrKD/kHb7MwoG2FWXTaDETNO9r6xs0qcMWsK55GHOpJn4VD1mC3hj8OKuxOeM3rn1NcpFWw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(30864003)(2906002)(5660300002)(47076005)(26005)(107886003)(6506007)(53546011)(6512007)(8676002)(4326008)(8936002)(6862004)(70206006)(40480700001)(70586007)(40460700003)(41300700001)(82310400005)(36756003)(33656002)(6486002)(356005)(81166007)(336012)(2616005)(186003)(54906003)(86362001)(478600001)(36860700001)(83380400001)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 12:55:25.7627
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 77ad6d3e-3d10-4eec-4157-08dab8e3aee4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6700

SGkgSnVsaWVuLA0KDQo+IE9uIDI3IE9jdCAyMDIyLCBhdCA1OjMzIHBtLCBKdWxpZW4gR3JhbGwg
PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IE9uIDI3LzEwLzIwMjIgMTc6MDgsIFJhaHVs
IFNpbmdoIHdyb3RlOg0KPj4gSGkgSnVsaWVuLA0KPiANCj4gSGkgUmFodWwsDQo+IA0KPj4+IE9u
IDI2IE9jdCAyMDIyLCBhdCA4OjQ4IHBtLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3
cm90ZToNCj4+PiANCj4+PiANCj4+PiANCj4+PiBPbiAyNi8xMC8yMDIyIDE1OjMzLCBSYWh1bCBT
aW5naCB3cm90ZToNCj4+Pj4gSGkgSnVsaWVuLA0KPj4+IA0KPj4+IEhpIFJhaHVsLA0KPj4+IA0K
Pj4+Pj4gT24gMjYgT2N0IDIwMjIsIGF0IDI6MzYgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl
bi5vcmc+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiANCj4+Pj4+IA0KPj4+Pj4gT24gMjYvMTAvMjAy
MiAxNDoxNywgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+Pj4gSGkgQWxsLA0KPj4+Pj4gDQo+Pj4+
PiBIaSBSYWh1bCwNCj4+Pj4+IA0KPj4+Pj4+IEF0IEFybSwgd2Ugc3RhcnRlZCB0byBpbXBsZW1l
bnQgdGhlIFBPQyB0byBzdXBwb3J0IDIgbGV2ZWxzIG9mIHBhZ2UgdGFibGVzL25lc3RlZCB0cmFu
c2xhdGlvbiBpbiBTTU1VdjMuDQo+Pj4+Pj4gVG8gc3VwcG9ydCBuZXN0ZWQgdHJhbnNsYXRpb24g
Zm9yIGd1ZXN0IE9TIFhlbiBuZWVkcyB0byBleHBvc2UgdGhlIHZpcnR1YWwgSU9NTVUuIElmIHdl
IHBhc3N0aHJvdWdoIHRoZQ0KPj4+Pj4+IGRldmljZSB0byB0aGUgZ3Vlc3QgdGhhdCBpcyBiZWhp
bmQgYW4gSU9NTVUgYW5kIHZpcnR1YWwgSU9NTVUgaXMgZW5hYmxlZCBmb3IgdGhlIGd1ZXN0IHRo
ZXJlIGlzIGEgbmVlZCB0bw0KPj4+Pj4+IGFkZCBJT01NVSBiaW5kaW5nIGZvciB0aGUgZGV2aWNl
IGluIHRoZSBwYXNzdGhyb3VnaCBub2RlIGFzIHBlciBbMV0uIFRoaXMgZW1haWwgaXMgdG8gZ2V0
IGFuIGFncmVlbWVudCBvbg0KPj4+Pj4+IGhvdyB0byBhZGQgdGhlIElPTU1VIGJpbmRpbmcgZm9y
IGd1ZXN0IE9TLg0KPj4+Pj4+IEJlZm9yZSBJIHdpbGwgZXhwbGFpbiBob3cgdG8gYWRkIHRoZSBJ
T01NVSBiaW5kaW5nIGxldCBtZSBnaXZlIGEgYnJpZWYgb3ZlcnZpZXcgb2YgaG93IHdlIHdpbGwg
YWRkIHN1cHBvcnQgZm9yIHZpcnR1YWwNCj4+Pj4+PiBJT01NVSBvbiBBcm0uIEluIG9yZGVyIHRv
IGltcGxlbWVudCB2aXJ0dWFsIElPTU1VIFhlbiBuZWVkIFNNTVV2MyBOZXN0ZWQgdHJhbnNsYXRp
b24gc3VwcG9ydC4gU01NVXYzIGhhcmR3YXJlDQo+Pj4+Pj4gc3VwcG9ydHMgdHdvIHN0YWdlcyBv
ZiB0cmFuc2xhdGlvbi4gRWFjaCBzdGFnZSBvZiB0cmFuc2xhdGlvbiBjYW4gYmUgaW5kZXBlbmRl
bnRseSBlbmFibGVkLiBBbiBpbmNvbWluZyBhZGRyZXNzIGlzIGxvZ2ljYWxseQ0KPj4+Pj4+IHRy
YW5zbGF0ZWQgZnJvbSBWQSB0byBJUEEgaW4gc3RhZ2UgMSwgdGhlbiB0aGUgSVBBIGlzIGlucHV0
IHRvIHN0YWdlIDIgd2hpY2ggdHJhbnNsYXRlcyB0aGUgSVBBIHRvIHRoZSBvdXRwdXQgUEEuIFN0
YWdlIDEgaXMNCj4+Pj4+PiBpbnRlbmRlZCB0byBiZSB1c2VkIGJ5IGEgc29mdHdhcmUgZW50aXR5
KCBHdWVzdCBPUykgdG8gcHJvdmlkZSBpc29sYXRpb24gb3IgdHJhbnNsYXRpb24gdG8gYnVmZmVy
cyB3aXRoaW4gdGhlIGVudGl0eSwgZm9yIGV4YW1wbGUsDQo+Pj4+Pj4gRE1BIGlzb2xhdGlvbiB3
aXRoaW4gYW4gT1MuIFN0YWdlIDIgaXMgaW50ZW5kZWQgdG8gYmUgYXZhaWxhYmxlIGluIHN5c3Rl
bXMgc3VwcG9ydGluZyB0aGUgVmlydHVhbGl6YXRpb24gRXh0ZW5zaW9ucyBhbmQgaXMNCj4+Pj4+
PiBpbnRlbmRlZCB0byB2aXJ0dWFsaXplIGRldmljZSBETUEgdG8gZ3Vlc3QgVk0gYWRkcmVzcyBz
cGFjZXMuIFdoZW4gYm90aCBzdGFnZSAxIGFuZCBzdGFnZSAyIGFyZSBlbmFibGVkLCB0aGUgdHJh
bnNsYXRpb24NCj4+Pj4+PiBjb25maWd1cmF0aW9uIGlzIGNhbGxlZCBuZXN0aW5nLg0KPj4+Pj4+
IFN0YWdlIDEgdHJhbnNsYXRpb24gc3VwcG9ydCBpcyByZXF1aXJlZCB0byBwcm92aWRlIGlzb2xh
dGlvbiBiZXR3ZWVuIGRpZmZlcmVudCBkZXZpY2VzIHdpdGhpbiB0aGUgZ3Vlc3QgT1MuIFhFTiBh
bHJlYWR5IHN1cHBvcnRzDQo+Pj4+Pj4gU3RhZ2UgMiB0cmFuc2xhdGlvbiBidXQgdGhlcmUgaXMg
bm8gc3VwcG9ydCBmb3IgU3RhZ2UgMSB0cmFuc2xhdGlvbiBmb3IgZ3Vlc3RzLiBXZSB3aWxsIGFk
ZCBzdXBwb3J0IGZvciBndWVzdHMgdG8gY29uZmlndXJlDQo+Pj4+Pj4gdGhlIFN0YWdlIDEgdHJh
bnNpdGlvbiB2aWEgdmlydHVhbCBJT01NVS4gWEVOIHdpbGwgZW11bGF0ZSB0aGUgU01NVSBoYXJk
d2FyZSBhbmQgZXhwb3NlcyB0aGUgdmlydHVhbCBTTU1VIHRvIHRoZSBndWVzdC4NCj4+Pj4+PiBH
dWVzdCBjYW4gdXNlIHRoZSBuYXRpdmUgU01NVSBkcml2ZXIgdG8gY29uZmlndXJlIHRoZSBzdGFn
ZSAxIHRyYW5zbGF0aW9uLiBXaGVuIHRoZSBndWVzdCBjb25maWd1cmVzIHRoZSBTTU1VIGZvciBT
dGFnZSAxLA0KPj4+Pj4+IFhFTiB3aWxsIHRyYXAgdGhlIGFjY2VzcyBhbmQgY29uZmlndXJlIHRo
ZSBoYXJkd2FyZSBhY2NvcmRpbmdseS4NCj4+Pj4+PiBOb3cgYmFjayB0byB0aGUgcXVlc3Rpb24g
b2YgaG93IHdlIGNhbiBhZGQgdGhlIElPTU1VIGJpbmRpbmcgYmV0d2VlbiB0aGUgdmlydHVhbCBJ
T01NVSBhbmQgdGhlIG1hc3RlciBkZXZpY2VzIHNvIHRoYXQNCj4+Pj4+PiBndWVzdHMgY2FuIGNv
bmZpZ3VyZSB0aGUgSU9NTVUgY29ycmVjdGx5LiBUaGUgc29sdXRpb24gdGhhdCBJIGFtIHN1Z2dl
c3RpbmcgaXMgYXMgYmVsb3c6DQo+Pj4+Pj4gRm9yIGRvbTAsIHdoaWxlIGhhbmRsaW5nIHRoZSBE
VCBub2RlKGhhbmRsZV9ub2RlKCkpIFhlbiB3aWxsIHJlcGxhY2UgdGhlIHBoYW5kbGUgaW4gdGhl
ICJpb21tdXMiIHByb3BlcnR5IHdpdGggdGhlIHZpcnR1YWwNCj4+Pj4+PiBJT01NVSBub2RlIHBo
YW5kbGUuDQo+Pj4+PiBCZWxvdywgeW91IHNhaWQgdGhhdCBlYWNoIElPTU1VcyBtYXkgaGF2ZSBh
IGRpZmZlcmVudCBJRCBzcGFjZS4gU28gc2hvdWxkbid0IHdlIGV4cG9zZSBvbmUgdklPTU1VIHBl
ciBwSU9NTVU/IElmIG5vdCwgaG93IGRvIHlvdSBleHBlY3QgdGhlIHVzZXIgdG8gc3BlY2lmeSB0
aGUgbWFwcGluZz8NCj4+Pj4gWWVzIHlvdSBhcmUgcmlnaHQgd2UgbmVlZCB0byBjcmVhdGUgb25l
IHZJT01NVSBwZXIgcElPTU1VIGZvciBkb20wLiBUaGlzIGFsc28gaGVscHMgaW4gdGhlIEFDUEkg
Y2FzZQ0KPj4+PiB3aGVyZSB3ZSBkb27igJl0IG5lZWQgdG8gbW9kaWZ5IHRoZSB0YWJsZXMgdG8g
ZGVsZXRlIHRoZSBwSU9NTVUgZW50cmllcyBhbmQgY3JlYXRlIG9uZSB2SU9NTVUuDQo+Pj4+IElu
IHRoaXMgY2FzZSwgbm8gbmVlZCB0byByZXBsYWNlIHRoZSBwaGFuZGxlIGFzIFhlbiBjcmVhdGUg
dGhlIHZJT01NVSB3aXRoIHRoZSBzYW1lIHBJT01NVQ0KPj4+PiBwaGFuZGxlIGFuZCBzYW1lIGJh
c2UgYWRkcmVzcy4NCj4+Pj4gRm9yIGRvbVUgZ3Vlc3RzIG9uZSB2SU9NTVUgcGVyIGd1ZXN0IHdp
bGwgYmUgY3JlYXRlZC4NCj4+PiANCj4+PiBJSVJDLCB0aGUgU01NVXYzIGlzIHVzaW5nIGEgcmlu
ZyBsaWtlIHRoZSBHSUN2MyBJVFMuIEkgdGhpbmsgd2UgbmVlZCB0byBiZSBvcGVuIGhlcmUgYmVj
YXVzZSB0aGlzIG1heSBlbmQgdXAgdG8gYmUgdHJpY2t5IHRvIHNlY3VyaXR5IHN1cHBvcnQgaXQg
KHdlIGhhdmUgTiBndWVzdCByaW5nIHRoYXQgY2FuIHdyaXRlIHRvIE0gaG9zdCByaW5nKS4NCj4+
IElmIHhsIHdhbnQgdG8gY3JlYXRlcyB0aGUgb25lIHZJT01NVSBwZXIgcElPTU1VIGZvciBkb21V
IHRoZW4geGwgbmVlZHMgdG8ga25vdyB0aGUgYmVsb3cgaW5mb3JtYXRpb246DQo+PiAgLSAgRmlu
ZCB0aGUgbnVtYmVyIG9mIGhvbGVzIGluIGd1ZXN0IG1lbW9yeSBzYW1lIGFzIHRoZSBudW1iZXIg
b2YgdklPTU1VIHRoYXQgbmVlZHMgdGhlIGNyZWF0aW9uIHRvIGNyZWF0ZSB0aGUgdklPTU1VIERU
IG5vZGVzLiAoVGhpbmsgYWJvdXQgYSBiaWcgc3lzdGVtIHRoYXQgaGFzIDUwKyBJT01NVXMpDQo+
PiAgICAgWWVzLCB3ZSB3aWxsIGNyZWF0ZSB2SU9NTVUgZm9yIG9ubHkgdGhvc2UgZGV2aWNlcyB0
aGF0IGFyZSBhc3NpZ25lZCB0byBndWVzdHMgYnV0IHN0aWxsIHdlIG5lZWQgdG8gZmluZCB0aGUg
aG9sZSBpbiBndWVzdCBtZW1vcnkuDQo+IA0KPiBJIGFncmVlIHRoaXMgaXMgYSBwcm9ibGVtIHdp
dGggdGhlIG9uZSB2SU9NTVUgcGVyIHBJT01NVS4NCj4gDQo+PiAgLSAgRmluZCB0aGUgcElPTU1V
IGF0dGFjaGVkIHRvIHRoZSBhc3NpZ25lZCBkZXZpY2UgYW5kIGNyZWF0ZSBtYXBwaW5nIGIvdyB2
SU9NTVUgLT4gcElPTU1VIHRvIHJlZ2lzdGVyIHRoZSBNTUlPIGhhbmRsZXIuDQo+PiAgICAgRWl0
aGVyIHdlIG5lZWQgdG8gbW9kaWZ5IHRoZSBjdXJyZW50IGh5ZXJwY2FsbCBvciBuZWVkIHRvIGlt
cGxlbWVudCBhIG5ldyBoeXBlcmNhbGwgdG8gZmluZCB0aGlzIGluZm9ybWF0aW9uLg0KPiANCj4g
QWRkaW5nIGh5cGVyY2FsbHMgYXJlIGlzIG5vdCBhIGJpZyBwcm9ibGVtLg0KPiANCj4+IEJlY2F1
c2Ugb2YgdGhlIGFib3ZlIHJlYXNvbiBJIHRob3VnaHQgb2YgY3JlYXRpbmcgb25lIHZJT01NVSBm
b3IgZG9tVS4gWWVzIHlvdSBhcmUgcmlnaHQgdGhpcyBtYXkgZW5kIHVwIHRvIGJlIHRyaWNreSB0
byBzZWN1cml0eSBzdXBwb3J0DQo+PiBidXQgYXMgcGVyIG15IHVuZGVyc3RhbmRpbmcgb25lIHZJ
T01NVSAgcGVyIGRvbVUgZ3Vlc3QgaXMgZWFzeSB0byBpbXBsZW1lbnQgYW5kIHNpbXBsZSB0byBo
YW5kbGUgYXMgY29tcGFyZWQgdG8gb25lIHZJT01NVSBwZXIgcElPTU1VDQo+IA0KPiBJIGFtIG5v
dCBzdXJlIGFib3V0IHRoaXMuIE15IGd1dCBmZWVsaW5nIGlzIHRoZSBjb2RlIGluIFhlbiB3aWxs
IGVuZCB1cCB0byBiZSB0cmlja3kgKHRoZXJlIG1vcmUgdGhhdCBYZW4gZG9lc24ndCBzdXBwb3J0
IHByZWVtcHRpb24pLiBTbyBJIHRoaW5rIHdlIHdpbGwgdHJhZGUtb2ZmIGNvbXBsZXhpdHkgaW4g
WGVuIG92ZXIgc2ltcGxpY2l0eSBpbiBsaWJ4bC4NCj4gDQo+IFRoYXQgc2FpZCwgSSBoYXZlbid0
IGxvb2tlZCBkZWVwZXIgaW4gdGhlIGNvZGUuIFNvIEkgbWF5IGJlIHdyb25nLiBJIHdpbGwgbmVl
ZCB0byBzZWUgdGhlIGNvZGUgdG8gY29uZmlybS4NCg0KDQpJIGhhdmUgaW1wbGVtZW50ZWQgdGhl
IGNvZGUgYmFzZWQgb24gb25lIHZJT01NVSBwZXIgZG9tVSBndWVzdCBhbmQgd2lsbCBzaGFyZSB0
aGUgY29kZSBmb3IgcmV2aWV3Lg0KV2UgY2FuIG1ha2UgYSBkZWNpc2lvbiBhdCB0aGUgdGltZSBv
ZiByZXZpZXcgYWJvdXQgd2hpY2ggYXBwcm9hY2ggaXMgYmV0dGVyLg0KDQo+IA0KPj4+Pj4+IEZv
ciBkb21VIGd1ZXN0cywgd2hlbiBwYXNzdGhyb3VnaCB0aGUgZGV2aWNlIHRvIHRoZSBndWVzdCBh
cyBwZXIgWzJdLCAgYWRkIHRoZSBiZWxvdyBwcm9wZXJ0eSBpbiB0aGUgcGFydGlhbCBkZXZpY2Ug
dHJlZQ0KPj4+Pj4+IG5vZGUgdGhhdCBpcyByZXF1aXJlZCB0byBkZXNjcmliZSB0aGUgZ2VuZXJp
YyBkZXZpY2UgdHJlZSBiaW5kaW5nIGZvciBJT01NVXMgYW5kIHRoZWlyIG1hc3RlcihzKQ0KPj4+
Pj4+ICJpb21tdXMgPSA8ICZtYWdpY19waGFuZGxlIDB4dk1hc3RlcklEPg0KPj4+Pj4+IAnigKIg
bWFnaWNfcGhhbmRsZSB3aWxsIGJlIHRoZSBwaGFuZGxlICggdklPTU1VIHBoYW5kbGUgaW4geGwp
ICB0aGF0IHdpbGwgYmUgZG9jdW1lbnRlZCBzbyB0aGF0IHRoZSB1c2VyIGNhbiBzZXQgdGhhdCBp
biBwYXJ0aWFsIERUIG5vZGUgKDB4ZmRlYSkuDQo+Pj4+PiANCj4+Pj4+IERvZXMgdGhpcyBtZWFu
IG9ubHkgb25lIElPTU1VIHdpbGwgYmUgc3VwcG9ydGVkIGluIHRoZSBndWVzdD8NCj4+Pj4gWWVz
Lg0KPj4+Pj4gDQo+Pj4+Pj4gCeKAoiB2TWFzdGVySUQgd2lsbCBiZSB0aGUgdmlydHVhbCBtYXN0
ZXIgSUQgdGhhdCB0aGUgdXNlciB3aWxsIHByb3ZpZGUuDQo+Pj4+Pj4gVGhlIHBhcnRpYWwgZGV2
aWNlIHRyZWUgd2lsbCBsb29rIGxpa2UgdGhpczoNCj4+Pj4+PiAvZHRzLXYxLzsNCj4+Pj4+PiAg
LyB7DQo+Pj4+Pj4gICAgIC8qICMqY2VsbHMgYXJlIGhlcmUgdG8ga2VlcCBEVEMgaGFwcHkgKi8N
Cj4+Pj4+PiAgICAgI2FkZHJlc3MtY2VsbHMgPSA8Mj47DQo+Pj4+Pj4gICAgICNzaXplLWNlbGxz
ID0gPDI+Ow0KPj4+Pj4+ICAgICAgIGFsaWFzZXMgew0KPj4+Pj4+ICAgICAgICAgbmV0ID0gJm1h
YzA7DQo+Pj4+Pj4gICAgIH07DQo+Pj4+Pj4gICAgICAgcGFzc3Rocm91Z2ggew0KPj4+Pj4+ICAg
ICAgICAgY29tcGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsNCj4+Pj4+PiAgICAgICAgIHJhbmdlczsN
Cj4+Pj4+PiAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDI+Ow0KPj4+Pj4+ICAgICAgICAgI3Np
emUtY2VsbHMgPSA8Mj47DQo+Pj4+Pj4gICAgICAgICBtYWMwOiBldGhlcm5ldEAxMDAwMDAwMCB7
DQo+Pj4+Pj4gICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJjYWx4ZWRhLGhiLXhnbWFjIjsNCj4+
Pj4+PiAgICAgICAgICAgICByZWcgPSA8MCAweDEwMDAwMDAwIDAgMHgxMDAwPjsNCj4+Pj4+PiAg
ICAgICAgICAgICBpbnRlcnJ1cHRzID0gPDAgODAgNCAgMCA4MSA0ICAwIDgyIDQ+Ow0KPj4+Pj4+
ICAgICAgICAgICAgaW9tbXVzID0gPDB4ZmRlYSAweDAxPjsNCj4+Pj4+PiAgICAgICAgIH07DQo+
Pj4+Pj4gICAgIH07DQo+Pj4+Pj4gfTsNCj4+Pj4+PiAgSW4geGwuY2ZnIHdlIG5lZWQgdG8gZGVm
aW5lIGEgbmV3IG9wdGlvbiB0byBpbmZvcm0gWGVuIGFib3V0IHZNYXN0ZXJJZCB0byBwTWFzdGVy
SWQgbWFwcGluZyBhbmQgdG8gd2hpY2ggSU9NTVUgZGV2aWNlIHRoaXMNCj4+Pj4+PiB0aGUgbWFz
dGVyIGRldmljZSBpcyBjb25uZWN0ZWQgc28gdGhhdCBYZW4gY2FuIGNvbmZpZ3VyZSB0aGUgcmln
aHQgSU9NTVUuIFRoaXMgaXMgcmVxdWlyZWQgaWYgdGhlIHN5c3RlbSBoYXMgZGV2aWNlcyB0aGF0
IGhhdmUNCj4+Pj4+PiB0aGUgc2FtZSBtYXN0ZXIgSUQgYnV0IGJlaGluZCBhIGRpZmZlcmVudCBJ
T01NVS4NCj4+Pj4+IA0KPj4+Pj4gSW4geGwuY2ZnLCB3ZSBhbHJlYWR5IHBhc3MgdGhlIGRldmlj
ZS10cmVlIG5vZGUgcGF0aCB0byBwYXNzdGhyb3VnaC4gU28gWGVuIHNob3VsZCBhbHJlYWR5IGhh
dmUgYWxsIHRoZSBpbmZvcm1hdGlvbiBhYm91dCB0aGUgSU9NTVUgYW5kIE1hc3Rlci1JRC4gU28g
aXQgZG9lc24ndCBzZWVtIG5lY2Vzc2FyeSBmb3IgRGV2aWNlLVRyZWUuDQo+Pj4+PiANCj4+Pj4+
IEZvciBBQ1BJLCBJIHdvdWxkIGhhdmUgZXhwZWN0ZWQgdGhlIGluZm9ybWF0aW9uIHRvIGJlIGZv
dW5kIGluIHRoZSBJT1JFUS4NCj4+Pj4+IA0KPj4+Pj4gU28gY2FuIHlvdSBhZGQgbW9yZSBjb250
ZXh0IHdoeSB0aGlzIGlzIG5lY2Vzc2FyeSBmb3IgZXZlcnlvbmU/DQo+Pj4+IFdlIGhhdmUgaW5m
b3JtYXRpb24gZm9yIElPTU1VIGFuZCBNYXN0ZXItSUQgYnV0IHdlIGRvbuKAmXQgaGF2ZSBpbmZv
cm1hdGlvbiBmb3IgbGlua2luZyB2TWFzdGVyLUlEIHRvIHBNYXN0ZXItSUQuDQo+Pj4gDQo+Pj4g
SSBhbSBjb25mdXNlZC4gQmVsb3csIHlvdSBhcmUgbWFraW5nIHRoZSB2aXJ0dWFsIG1hc3RlciBJ
RCBvcHRpb25hbC4gU28gc2hvdWxkbid0IHRoaXMgYmUgbWFuZGF0b3J5IGlmIHlvdSByZWFsbHkg
bmVlZCB0aGUgbWFwcGluZyB3aXRoIHRoZSB2aXJ0dWFsIElEPw0KPj4gdk1hc3RlcklEIGlzIG9w
dGlvbmFsIGlmIHVzZXIga25vd3MgcE1hc3RlcklEIGlzIHVuaXF1ZSBvbiB0aGUgc3lzdGVtLiBC
dXQgaWYgcE1hc3RlcklkIGlzIG5vdCB1bmlxdWUgdGhlbiB1c2VyIG5lZWRzIHRvIHByb3ZpZGUg
dGhlIHZNYXN0ZXJJRC4NCj4gDQo+IFNvIHRoZSBleHBlY3RhdGlvbiBpcyB0aGUgdXNlciB3aWxs
IGJlIGFibGUgdG8ga25vdyB0aGF0IHRoZSBwTWFzdGVySUQgaXMgdW5pcS4gVGhpcyBtYXkgYmUg
ZWFzeSB3aXRoIGEgY291cGxlIG9mIFNNTVVzLCBidXQgaWYgeW91IGhhdmUgNTArIChhcyBzdWdn
ZXN0ZWQgYWJvdmUpLiBUaGlzIHdpbGwgYmVjb21lIGEgcGFpbiBvbiBsYXJnZXIgc3lzdGVtLg0K
PiANCj4gSUhNTywgaXQgd291bGQgYmUgbXVjaCBiZXR0ZXIgaWYgd2UgY2FuIGRldGVjdCB0aGF0
IGluIGxpYnhsIChzZWUgYmVsb3cpLg0KDQpXZSBjYW4gbWFrZSB0aGUgdk1hc3RlcklEIGNvbXB1
bHNvcnkgdG8gYXZvaWQgY29tcGxleGl0eSBpbiBsaWJ4bCB0byBzb2x2ZSB0aGlzLg0KDQo+IA0K
Pj4+IA0KPj4+PiBUaGUgZGV2aWNlIHRyZWUgbm9kZSB3aWxsIGJlIHVzZWQgdG8gYXNzaWduIHRo
ZSBkZXZpY2UgdG8gdGhlIGd1ZXN0IGFuZCBjb25maWd1cmUgdGhlIFN0YWdlLTIgdHJhbnNsYXRp
b24uIEd1ZXN0IHdpbGwgdXNlIHRoZQ0KPj4+PiB2TWFzdGVyLUlEIHRvIGNvbmZpZ3VyZSB0aGUg
dklPTU1VIGR1cmluZyBib290LiBYZW4gbmVlZHMgaW5mb3JtYXRpb24gdG8gbGluayB2TWFzdGVy
LUlEIHRvIHBNYXN0ZXItSUQgdG8gY29uZmlndXJlDQo+Pj4+IHRoZSBjb3JyZXNwb25kaW5nIHBJ
T01NVS4gQXMgSSBtZW50aW9uIHdlIG5lZWQgdk1hc3Rlci1JRCBpbiBjYXNlIGEgc3lzdGVtIGNv
dWxkIGhhdmUgMiBpZGVudGljYWwgTWFzdGVyLUlEIGJ1dA0KPj4+PiBlYWNoIG9uZSBjb25uZWN0
ZWQgdG8gYSBkaWZmZXJlbnQgU01NVSBhbmQgYXNzaWduZWQgdG8gdGhlIGd1ZXN0Lg0KPj4+IA0K
Pj4+IEkgYW0gYWZyYWlkIEkgc3RpbGwgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgdGhpcyBpcyBhIHJl
cXVpcmVtZW50LiBMaWJ4bCBjb3VsZCBoYXZlIGVub3VnaCBrbm93bGVkZ2UgKHdoaWNoIHdpbGwg
YmUgbmVjZXNzYXJyeSBmb3IgdGhlIFBDSSBjYXNlKSB0byBrbm93IHRoZSBJT01NVSBhbmQgcE1h
c3RlcklEIGFzc29jaWF0ZWQgd2l0aCBhIGRldmljZS4NCj4+PiANCj4+PiBTbyBsaWJ4bCBjb3Vs
ZCBhbGxvY2F0ZSB0aGUgdk1hc3RlcklELCB0ZWxsIFhlbiB0aGUgY29ycmVzcG9uZGluZyBtYXBw
aW5nIGFuZCB1cGRhdGUgdGhlIGRldmljZS10cmVlLg0KPj4+IA0KPj4+IElPVywgaXQgZG9lc24n
dCBzZWVtIHRvIGJlIG5lY2Vzc2FyeSB0byBpbnZvbHZlIHRoZSB1c2VyIGluIHRoZSBwcm9jZXNz
IGhlcmUuDQo+PiBZZXMsIGxpYnhsIGNvdWxkIGFsbG9jYXRlIHRoZSB2TWFzdGVySUQgYnV0IHRo
ZXJlIGlzIG5vIHdheSB3ZSBjYW4gZmluZCB0aGUgbGluayBiL3cgdk1hc3RlcklEIGNyZWF0ZWQg
dG8gcE1hc3RlcklEIGZyb20gZHRkZXYuDQo+PiBXaGF0IEkgdW5kZXJzdGFuZCBmcm9tIHRoZSBj
b2RlIGlzIHRoYXQgdGhlcmUgaXMgbm8gbGluayBiZXR3ZWVuIHRoZSBwYXNzdGhyb3VnaCBub2Rl
IGFuZCBkdGRldiBjb25maWcgb3B0aW9uLiBUaGUgcGFzc3Rocm91Z2gNCj4+IG5vZGUgaXMgZGly
ZWN0bHkgY29waWVkIHRvIGd1ZXN0IERUIHdpdGhvdXQgYW55IG1vZGlmaWNhdGlvbi4gRHRkZXYg
aXMgdXNlZCB0byBhZGQgYW5kIGFzc2lnbiB0aGUgZGV2aWNlIHRvIElPTU1VLg0KPj4gTGV0J3Mg
dGFrZSBhbiBleGFtcGxlIGlmIHRoZSB1c2VyIHdhbnRzIHRvIGFzc2lnbiB0d28gZGV2aWNlcyB0
byB0aGUgZ3Vlc3QgdmlhIHBhc3N0aHJvdWdoIG5vZGUuDQo+PiAvZHRzLXYxLzsNCj4+IC8gew0K
Pj4gICAgLyogIypjZWxscyBhcmUgaGVyZSB0byBrZWVwIERUQyBoYXBweSAqLw0KPj4gICAgI2Fk
ZHJlc3MtY2VsbHMgPSA8Mj47DQo+PiAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4+ICAgIGFsaWFz
ZXMgew0KPj4gICAgICAgIG5ldCA9ICZtYWMwOw0KPj4gICAgfTsNCj4+ICAgIHBhc3N0aHJvdWdo
IHsNCj4+ICAgICAgICBjb21wYXRpYmxlID0gInNpbXBsZS1idXMiOw0KPj4gICAgICAgIHJhbmdl
czsNCj4+ICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4+ICAgICAgICAjc2l6ZS1jZWxs
cyA9IDwyPjsNCj4+ICAgICAgICBtYWMwOiBldGhlcm5ldEAxMDAwMDAwMCB7DQo+PiAgICAgICAg
ICAgIGNvbXBhdGlibGUgPSAiY2FseGVkYSxoYi14Z21hYyI7DQo+PiAgICAgICAgICAgIHJlZyA9
IDwwIDB4MTAwMDAwMDAgMCAweDEwMDA+Ow0KPj4gICAgICAgICAgICBpbnRlcnJ1cHRzID0gPDAg
ODAgNCAgMCA4MSA0ICAwIDgyIDQ+Ow0KPj4gICAgICAgIH07DQo+PiAgICAgIG1hYzE6IGV0aGVy
bmV0QDIwMDAwMDAwIHsNCj4+ICAgICAgICAgICAgY29tcGF0aWJsZSA9IOKAnHI4MTY5IjsNCj4+
ICAgICAgICAgICAgcmVnID0gPDAgMHgxMDAwMDAwMCAwIDB4MTAwMD47DQo+PiAgICAgICAgICAg
IGludGVycnVwdHMgPSA8MCA4MCA0ICAwIDgxIDQgIDAgODIgND47DQo+PiAgICAgICAgfTsNCj4+
ICAgIH07DQo+PiB9Ow0KPj4gZHRkZXYgPSBbICIvc29jL2V0aGVybmV0QDEwMDAwMDAw4oCdLCDi
gJwvc29jL2V0aGVybmV0QGYyMDAwMDAw4oCdIF0NCj4+IFRoZXJlIGlzIG5vIGxpbmsgd2hpY2gg
ZHRkZXYgZW50cnkgYmVsb25ncyB0byB3aGljaCBub2RlLiBUaGVyZWZvciB0aGVyZSBpcyBubyB3
YXkgdG8gbGluayB0aGUgdk1hc3RlcklEIGNyZWF0ZWQgdG8gcE1hc3RlcklELg0KPiANCj4gSSBh
Z3JlZSB0aGVyZSBpcyBubyBsaW5rIHRvZGF5LiBCdXQgd2UgY291bGQgYWRkIGEgcHJvcGVydHkg
aW4gdGhlIHBhcnRpYWwgZGV2aWNlLXRyZWUgdG8gbWVudGlvbiB3aGljaCBwaHlzaWNhbCBkZXZp
Y2UgaXMgYXNzb2NpYXRlZC4NCj4gDQo+IFdpdGggdGhhdCwgSSB0aGluayBhbGwsIHRoZSBjb21w
bGV4aXR5IGlzIG1vdmVkIHRvIGxpYnhsIGFuZCBpdCB3aWxsIGJlIGVhc2llciBmb3IgdGhlIHVz
ZXIgdG8gdXNlIHZJT01NVS4NCj4gDQo+IFsuLi5dDQoNCkFzIG9mIG5vdyBsaWJ4bCBkaXJlY3Rs
eSBjb3BpbmcgdGhlIHBhcnRpYWwgRFQgdG8gZ3Vlc3QgRFQgd2l0aG91dCBhbnkgbW9kaWZpY2F0
aW9uLiBJZiB3ZSBoYXZlIHRvIGdvIHRvIHRoaXMgcm91dGUgbGlieGwgaGFzIHRvIG1vZGlmeQ0K
dGhlIHBhcnRpYWwgRFQgaW4gbGlieGwgdG8gaW5jbHVkZSDigJxpb21tdXPigJ0gb3IgImlvbW11
LW1hcOKAnS4gSXMgdGhhdCBva2F5IHRvIG1vZGlmeSB0aGUgcGFydGlhbCBEVCBpbiBsaWJ4bCA/
DQoNCj4gDQo+Pj4+Pj4gIGlvbW11X2RldmlkX21hcCA9IFsg4oCcUE1BU1RFUl9JRFtAVk1BU1RF
Ul9JRF0sSU9NTVVfQkFTRV9BRERSRVNT4oCdICwg4oCcUE1BU1RFUl9JRFtAVk1BU1RFUl9JRF0s
SU9NTVVfQkFTRV9BRERSRVNT4oCdXQ0KPj4+Pj4+IAnigKIgUE1BU1RFUl9JRCBpcyB0aGUgcGh5
c2ljYWwgbWFzdGVyIElEIG9mIHRoZSBkZXZpY2UgZnJvbSB0aGUgcGh5c2ljYWwgRFQuDQo+Pj4+
Pj4gCeKAoiBWTUFTVEVSX0lEIGlzIHRoZSB2aXJ0dWFsIG1hc3RlciBJZCB0aGF0IHRoZSB1c2Vy
IHdpbGwgY29uZmlndXJlIGluIHRoZSBwYXJ0aWFsIGRldmljZSB0cmVlLg0KPj4+Pj4+IAnigKIg
SU9NTVVfQkFTRV9BRERSRVNTIGlzIHRoZSBiYXNlIGFkZHJlc3Mgb2YgdGhlIHBoeXNpY2FsIElP
TU1VIGRldmljZSB0byB3aGljaCB0aGlzIGRldmljZSBpcyBjb25uZWN0ZWQuDQo+Pj4+PiANCj4+
Pj4+IEJlbG93IHlvdSBnaXZlIGFuIGV4YW1wbGUgZm9yIFBsYXRmb3JtIGRldmljZS4gSG93IHdv
dWxkIHRoYXQgZml0IGluIHRoZSBjb250ZXh0IG9mIFBDSSBwYXNzdGhyb3VnaD8NCj4+Pj4gSW4g
UENJIHBhc3N0aHJvdWdoIGNhc2UsIHhsIHdpbGwgY3JlYXRlIHRoZSAiaW9tbXUtbWFwIiBwcm9w
ZXJ0eSBpbiB2cGNpIGhvc3QgYnJpZGdlIG5vZGUgd2l0aCBwaGFuZGxlIHRvIHZJT01NVSBub2Rl
Lg0KPj4+PiB2U01NVXYzIG5vZGUgd2lsbCBiZSBjcmVhdGVkIGluIHhsLg0KPj4+IA0KPj4+IFRo
aXMgbWVhbnMgdGhhdCBsaWJ4bCB3aWxsIG5lZWQgdG8ga25vdyB0aGUgYXNzb2NpYXRlZCBwTWFz
dGVySUQgdG8gYSBQQ0kgZGV2aWNlLiBTbywgSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB5b3UgY2Fu
J3QgZG8gdGhlIHNhbWUgZm9yIHBsYXRmb3JtIGRldmljZXMuDQo+PiBGb3IgdGhlIFBDSSBwYXNz
dGhyb3VnaCBjYXNlLCB3ZSBkb27igJl0IG5lZWQgdG8gcHJvdmlkZSB0aGUgTWFzdGVySUQgdG8g
Y3JlYXRlICJpb21tdS1tYXDigJ0gcHJvcGVydHkgYXMgZm9yDQo+PiBQQ0kgZGV2aWNlIE1hc3Rl
cklEIGlzIFJJRCAoIEJERiApLiBGb3Igbm9uLVBDSSBkZXZpY2VzLCBNYXN0ZXJJRCBpcyByZXF1
aXJlZCB0byBjcmVhdGUg4oCcaW9tbXVz4oCdIHByb3BlcnR5Lg0KPiANCj4gQXJlIHlvdSB0YWxr
aW5nIGFib3V0IHRoZSBwaHlzaWNhbCBNYXN0ZXJJRCBvciB2aXJ0dWFsIG9uZT8gSWYgcGh5c2lj
YWwgTWFzdGVySUQgdGhlbiBJIGRvbid0IHRoaW5rIHRoaXMgaXMgYWx3YXlzIHRoZSBSSUQgKHNl
ZSBbMV0pLiBCdXQgZm9yIHRoZSB2aXJ0dWFsIE1hc3RlciBJRCB3ZSBjb3VsZCBtYWtlIHRoaXMg
YXNzb2NpYXRpb24uDQo+IA0KPiBUaGlzIHN0aWxsIG1lYW5zIHRoYXQgaW4gc29tZSB3YXkgdGhl
IHRvb2xzdGFjayBuZWVkIHRvIGxldCBYZW4ga25vdyAob3IgdGhlIG90aGVyIHdheSBhcm91bmQp
IHRoZSBtYXBwaW5nIGJldHdlZW4gdGhlIHBNYXN0ZXJJRCBhbmQgdk1hc3RlcklELg0KDQpZZXMs
IEkgYWdyZWUgaWYgUklEIGlzIG5vdCB0aGUgQkRGIHRoZW4gd2UgbmVlZCB0byBsZXQgWGVuIGtu
b3cgdGhlIG1hcHBpbmcgYmV0d2VlbiB0aGUgcE1hc3RlcklEIGFuZCB2TWFzdGVySUQuIA0KDQpS
ZWdhcmRzLA0KUmFodWw=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 13:06:38 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 13:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432054.684745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooP4C-0006Xy-OX; Fri, 28 Oct 2022 13:06:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432054.684745; Fri, 28 Oct 2022 13:06:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooP4C-0006Xr-Lr; Fri, 28 Oct 2022 13:06:32 +0000
Received: by outflank-mailman (input) for mailman id 432054;
 Fri, 28 Oct 2022 13:06:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooP4B-0006Xl-0o
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 13:06:31 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooP4A-0003G3-Lt; Fri, 28 Oct 2022 13:06:30 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooP4A-00065N-F5; Fri, 28 Oct 2022 13:06:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=vzMW9JF0pgkWt3b0mjgKiSrLS6OHC8sI9pYFu4gNpEw=; b=U2Iku+5Ye5yuySZgIcdCHQz5hM
	/hAxKMhccTUa4j+64NgJwGegf7Vvm/7G3V0o7XPltAchqHFXo51LO54Y8JrSTGgj4yNnJVkNgO75y
	dQKNJVdzX7rhmWcNBDo12asnkaOSS2rcNcBvC1oUSsnsC9eGnXnXdb/JX2kz8VMXnkNk=;
Message-ID: <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
Date: Fri, 28 Oct 2022 14:06:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Rahul,

On 28/10/2022 13:54, Rahul Singh wrote:
>>>>>> For ACPI, I would have expected the information to be found in the IOREQ.
>>>>>>
>>>>>> So can you add more context why this is necessary for everyone?
>>>>> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
>>>>
>>>> I am confused. Below, you are making the virtual master ID optional. So shouldn't this be mandatory if you really need the mapping with the virtual ID?
>>> vMasterID is optional if user knows pMasterID is unique on the system. But if pMasterId is not unique then user needs to provide the vMasterID.
>>
>> So the expectation is the user will be able to know that the pMasterID is uniq. This may be easy with a couple of SMMUs, but if you have 50+ (as suggested above). This will become a pain on larger system.
>>
>> IHMO, it would be much better if we can detect that in libxl (see below).
> 
> We can make the vMasterID compulsory to avoid complexity in libxl to solve this

In general, complexity in libxl is not too much of problem.

> 
>>
>>>>
>>>>> The device tree node will be used to assign the device to the guest and configure the Stage-2 translation. Guest will use the
>>>>> vMaster-ID to configure the vIOMMU during boot. Xen needs information to link vMaster-ID to pMaster-ID to configure
>>>>> the corresponding pIOMMU. As I mention we need vMaster-ID in case a system could have 2 identical Master-ID but
>>>>> each one connected to a different SMMU and assigned to the guest.
>>>>
>>>> I am afraid I still don't understand why this is a requirement. Libxl could have enough knowledge (which will be necessarry for the PCI case) to know the IOMMU and pMasterID associated with a device.
>>>>
>>>> So libxl could allocate the vMasterID, tell Xen the corresponding mapping and update the device-tree.
>>>>
>>>> IOW, it doesn't seem to be necessary to involve the user in the process here.
>>> Yes, libxl could allocate the vMasterID but there is no way we can find the link b/w vMasterID created to pMasterID from dtdev.
>>> What I understand from the code is that there is no link between the passthrough node and dtdev config option. The passthrough
>>> node is directly copied to guest DT without any modification. Dtdev is used to add and assign the device to IOMMU.
>>> Let's take an example if the user wants to assign two devices to the guest via passthrough node.
>>> /dts-v1/;
>>> / {
>>>     /* #*cells are here to keep DTC happy */
>>>     #address-cells = <2>;
>>>     #size-cells = <2>;
>>>     aliases {
>>>         net = &mac0;
>>>     };
>>>     passthrough {
>>>         compatible = "simple-bus";
>>>         ranges;
>>>         #address-cells = <2>;
>>>         #size-cells = <2>;
>>>         mac0: ethernet@10000000 {
>>>             compatible = "calxeda,hb-xgmac";
>>>             reg = <0 0x10000000 0 0x1000>;
>>>             interrupts = <0 80 4  0 81 4  0 82 4>;
>>>         };
>>>       mac1: ethernet@20000000 {
>>>             compatible = “r8169";
>>>             reg = <0 0x10000000 0 0x1000>;
>>>             interrupts = <0 80 4  0 81 4  0 82 4>;
>>>         };
>>>     };
>>> };
>>> dtdev = [ "/soc/ethernet@10000000”, “/soc/ethernet@f2000000” ]
>>> There is no link which dtdev entry belongs to which node. Therefor there is no way to link the vMasterID created to pMasterID.
>>
>> I agree there is no link today. But we could add a property in the partial device-tree to mention which physical device is associated.
>>
>> With that, I think all, the complexity is moved to libxl and it will be easier for the user to use vIOMMU.
>>
>> [...]
> 
> As of now libxl directly coping the partial DT to guest DT without any modification. If we have to go to this route libxl has to modify
> the partial DT in libxl to include “iommus” or "iommu-map”. Is that okay to modify the partial DT in libxl 

I am not aware of any issue to modify the partial device-tree. In fact, 
I am strongly in favor of libxl to modify it if it greatly improve the 
user experience.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 13:14:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 13:14:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432063.684756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooPBS-0008L4-Mt; Fri, 28 Oct 2022 13:14:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432063.684756; Fri, 28 Oct 2022 13:14:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooPBS-0008Kx-J9; Fri, 28 Oct 2022 13:14:02 +0000
Received: by outflank-mailman (input) for mailman id 432063;
 Fri, 28 Oct 2022 13:14:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pqEQ=25=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ooPBR-0008Kr-3H
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 13:14:01 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 627266bf-56c2-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 15:13:59 +0200 (CEST)
Received: from AS8P250CA0012.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::17)
 by AS8PR08MB8249.eurprd08.prod.outlook.com (2603:10a6:20b:53f::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 13:13:57 +0000
Received: from AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:330:cafe::14) by AS8P250CA0012.outlook.office365.com
 (2603:10a6:20b:330::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27 via Frontend
 Transport; Fri, 28 Oct 2022 13:13:57 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT008.mail.protection.outlook.com (100.127.141.25) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 13:13:57 +0000
Received: ("Tessian outbound 73ab5f36653e:v130");
 Fri, 28 Oct 2022 13:13:56 +0000
Received: from 250b8ccacc88.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BBCD2236-15B4-40AC-B42D-1A47B5BB3217.1; 
 Fri, 28 Oct 2022 13:13:46 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 250b8ccacc88.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 13:13:46 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAXPR08MB6368.eurprd08.prod.outlook.com (2603:10a6:102:159::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 13:13:42 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.014; Fri, 28 Oct 2022
 13:13:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 627266bf-56c2-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=UrXRE2cJHszoBFq6ddevWRYWfYfn8k0n4qBn5gX8cU0mylF2fE5/QT73ewBvULiPSmRDYUo37QFnroj7W7Hh16Bghh2Pq1juT//fnmHxyCPElUTjk9Xpj7/OXRIRrDBtV4MjAnt7cMZWyPr0wm+IiFse87DGIZtO0Is0EmLKJBBr19AVEIgkmUQJ856Xc2hZVNkA81eU2ekGbCSX4pQreco2rKjhH/WSl3Y9drRMXfJPGztqozgPwPZ3aadeyktK0qhnA4+XNnq2XefZEYAfBlzisnLO0yT/Yk/VPoxc9Y3Eu7NMnpQkkCjr9xEZGcjfNKx6DgKAfTzLBtI1md1NGw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Cq7r8Hv4HfMPFp24z5skg9bXgMbAh3TGz2A5+IJwmzw=;
 b=nCN0LmeubQSm/JfrA3HdJjppf5zY8SJVeJPuHtnIpGJQpRR4RADNv6ue+0xOELslBE9VCXPWcRWMS5v6BWdpVcpUx00Mst+S2hJ4KdcWUFKUxT0iKcl1zlaORidr7B8vOhj7BqSe9s8I18SEUWCpCSzgj7q++ylkDgQmERw5lN13GIznnkHgPCw08VUpslQj7dXVh3K1oSDP5ynskyVvA9vjMrF773+Gml0CgqqVw4CaKmVBCEL2mggnzEOxbEBG+nvWuqC62gX4DJEHLFAjV/mIhnmh9creouMdYtZhPx2MAWFjXbK7cAX6MYXjGgLEiVOkigRjBW2z7iriADh1jQ==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Cq7r8Hv4HfMPFp24z5skg9bXgMbAh3TGz2A5+IJwmzw=;
 b=eXu+hdrXgmqHa5IXyS7IaAUE/+tYmIT0LZOvtd8gR/7of9RmmfgnKZTwLSQJ7ZIVIfvEyLijUhibLnaX1N2VmiQkZ+ffPI0zh2oPUzIfZ27pzqPy4U/D/D1yY7JJ5PKL32XiZDJZjOD8wGBx2gkk3Lzu+fpIt87w1J4ANAQGdmg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7490f930d0b41a78
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XQgJnulKzt2cTRYRB+nRbV7IrNioqZKzSY9TWbBxKi7M73NdtAuVDgx+Z5fA8hmwq1Mqai4ahdpYO05fk53D4kkmKOpoH9zXGUaLE2ybKfuiO0o2Hlh3ITAs8n+/xxXkEZMBcqB7sLXRAusMBgUjaBJaDT3SG8y4FHPBUDTXBcme3aSG009yL+luM9a7PwXs8fn5eperWOzBDDrnbUiJU0iFSteT6JYsMhlZ3nconZUb/xopneC35dBfeLjqcu5CSeEd1d2hXTV1C66KHTPZ+mkjSei+4Ke56RgYUQnBjhY1iIF2nk580njGqvO6+jrGI/XKXq5GudbEDpn9bxDXjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Cq7r8Hv4HfMPFp24z5skg9bXgMbAh3TGz2A5+IJwmzw=;
 b=KnSeMoOcjth7DIpmeq4WjnpmkEZWvx4sGSu0zb31f5LV0zEqonj480E0em5Dikv+UeEmeJwNRe9Iz6YQucE8k9UNmAWspwbmuWfZepqaESRifKckyYiNGJsdmqy9qjWrNx3eHj5uOSrE3SWfk15gvaqF0lnyhkLWDrMPjai6UkvymXIYnSQi3hD0vEnsHuSoVRrTvIHwAWuiEVaPX2xu9RHMhO9IfT+l5HIY8h/cwOyL9kOn8TP90Dq8/UE1yWrSeSWqNwAIDF0gV3nyLlftRzQjDYUudCFJt47LIkC+YDyLKK+YrZExk/zVXNeFp6NJGRqhO0IINYxJbxo9HgIgbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Cq7r8Hv4HfMPFp24z5skg9bXgMbAh3TGz2A5+IJwmzw=;
 b=eXu+hdrXgmqHa5IXyS7IaAUE/+tYmIT0LZOvtd8gR/7of9RmmfgnKZTwLSQJ7ZIVIfvEyLijUhibLnaX1N2VmiQkZ+ffPI0zh2oPUzIfZ27pzqPy4U/D/D1yY7JJ5PKL32XiZDJZjOD8wGBx2gkk3Lzu+fpIt87w1J4ANAQGdmg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index:
 AQHY6T1V+gcJbmRqpEyt0b8GeG9bFq4grXIAgAAQCACAAFf9AIABVMyAgAAG64CAAVVJgIAAAzuAgAACBwA=
Date: Fri, 28 Oct 2022 13:13:42 +0000
Message-ID: <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
In-Reply-To: <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAXPR08MB6368:EE_|AM7EUR03FT008:EE_|AS8PR08MB8249:EE_
X-MS-Office365-Filtering-Correlation-Id: 7b42318d-18e7-4cff-0c4b-08dab8e6454f
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9VyJJt86UX4//VErB5JDNlLphOHnyBmz6CVdU9rR8xvjka4uVj7xluy7D+LZUVI5/Y9nAbLN17bnyEn4Ma1ZVDnl89DjAlKxwED6KorBYkXe8VDp8ea+PEE+w0VtkleNBMGcDUFgaTvg8Q46udBSjXyv1TXI0D8ZT6G1AepAp7fm+D73nNYORUj7FoYybWqdWwkVKk5I7QyG145S0YrLAOVTmphprNAF9993hUJxr5nEJGvAbJGO56heNv+rXVSoo5S8OSyUkHDVW428zS0SUpfSilPNigECOhFfbWIyg3tH9tC95ySBKobHIlqNa/CXiML+3P0ZIJ1rhbUSvweONe2BUndYb0E1r9TFrTTnXvl0FDwBNc5tnfmz72f4AzijSMLtYFameSKwuvBCnOQiYr01bRvgMm5srsHORbuXnXo73opX9JQLjdqtqp53FvjUgMfsUYmgWPUwaLZpg4GyvldD2ZeEygclgTDYPYLbQXug4kW4lVZb4a/T0vdlrTI5Icy8hMQhoefcqK0P+Jt+aeCdekn4fSU3uoCnAd7XNv+zOG0x0bR1+1FBIBM35FQVV0Xv/qNY2HMNEWXB2JeKDNFv6r0cHFQWxvy2Evu3jLCr4Eow8MEF9qXN7zjbaX5jZQj2OSt1ij0LR59F+K273Wm1CQ6nngcjva4RTQ/KQyfDkpTJRrYJlmqQ4H2o3I3RZQgBlR5QXrY3ckotLt+Pg5J8d+SzN/8NxREuomjqUSmkniK9UaDAc34/yO7TS6UqDSspLDIGhu+GMnqP12pkTR8UgjhUkShDmTEQoPYM6+M=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199015)(38070700005)(38100700002)(7416002)(2906002)(5660300002)(26005)(6506007)(53546011)(6512007)(66556008)(66446008)(64756008)(8676002)(66476007)(66946007)(4326008)(91956017)(8936002)(122000001)(41300700001)(76116006)(36756003)(33656002)(6486002)(71200400001)(2616005)(186003)(6916009)(54906003)(86362001)(478600001)(83380400001)(316002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <136AA14B40E78F429309B6D61F6429BD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6368
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	cfcce145-f0de-4b98-5162-08dab8e63ccb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BNpZyD0tEFPO76YvbSxy7IwlDu/JJSoGhpjVLLSKYdAkTqprG+PuQ+HUwTp5Ie6bHPwEhrHiVaMD8R6xyk4pY02PVGpTj7IC7WgThgQ46Tu7IPi+GA/OL4SKylrXey7IPBelGN1+zMuANu9lpnZLZJ13HAWFuEYsYqP6VM+dfXhfiA80S89cCO/obb4fzVTvmDTeJ86O5XjfTS/06AO87d9ufIN39qEZAtCAbk/MNdcL0S2uOlmz4efECPPxbTFX81Ktcl4SRWOnj8QfD1enj/IajjXwniFFgPN0wEd1fOA+z8fdmFTLIy9pnfKsSW2kvwps4nPA3Jf4A2FPbIr2voC8gzCCwvlGGxjzp5ASyyw85/USe79epPAhbKBFampuh7VnAcPu15lDLZtCnG0Vq364o9JptN2SpfRiwvvQtWWX6jhIWCbUsm2ZWBTURopJSFZ6IgaJiV9dAj+JOTJ2owdIQREXblDo9OMqb4vb26UysjDzxCmMC7euFNCh6SNeB7KK96ejUbvgCWQNx7oCymx4WaPrhplnEWxRQtquBxuk8IGgaTg9YfZIeVgtH+EgDdvPM7KWH9k7pbZQGSc1JFkg9kP/F/I4j3zvJH3z8kbk3vo9caIJ1O7t/EVDJB0+iOJpuUJ3cuB0xXwc+JC95zrOxumDe2vL+x/R3KyqWQgOEmj5wR1o4i5SD7usBXunqd3JDbE5oq87VmGrNBYDovefPnak+Z8YqeiK/1jqYCnR0Pa3OlJdaPdUZXmb/BRdtrUhxTXMNFupd96SIEmpSg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(46966006)(40470700004)(36840700001)(2906002)(40480700001)(478600001)(53546011)(54906003)(107886003)(6486002)(4326008)(8676002)(70586007)(316002)(70206006)(6506007)(41300700001)(26005)(6512007)(36860700001)(8936002)(6862004)(5660300002)(33656002)(36756003)(40460700003)(186003)(86362001)(336012)(83380400001)(2616005)(82310400005)(356005)(82740400003)(81166007)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 13:13:57.0518
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b42318d-18e7-4cff-0c4b-08dab8e6454f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT008.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8249

SGkgSnVsaWVuLA0KDQo+IE9uIDI4IE9jdCAyMDIyLCBhdCAxNDowNiwgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+IE9uIDI4LzEwLzIw
MjIgMTM6NTQsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+Pj4+PiBGb3IgQUNQSSwgSSB3b3VsZCBo
YXZlIGV4cGVjdGVkIHRoZSBpbmZvcm1hdGlvbiB0byBiZSBmb3VuZCBpbiB0aGUgSU9SRVEuDQo+
Pj4+Pj4+IA0KPj4+Pj4+PiBTbyBjYW4geW91IGFkZCBtb3JlIGNvbnRleHQgd2h5IHRoaXMgaXMg
bmVjZXNzYXJ5IGZvciBldmVyeW9uZT8NCj4+Pj4+PiBXZSBoYXZlIGluZm9ybWF0aW9uIGZvciBJ
T01NVSBhbmQgTWFzdGVyLUlEIGJ1dCB3ZSBkb27igJl0IGhhdmUgaW5mb3JtYXRpb24gZm9yIGxp
bmtpbmcgdk1hc3Rlci1JRCB0byBwTWFzdGVyLUlELg0KPj4+Pj4gDQo+Pj4+PiBJIGFtIGNvbmZ1
c2VkLiBCZWxvdywgeW91IGFyZSBtYWtpbmcgdGhlIHZpcnR1YWwgbWFzdGVyIElEIG9wdGlvbmFs
LiBTbyBzaG91bGRuJ3QgdGhpcyBiZSBtYW5kYXRvcnkgaWYgeW91IHJlYWxseSBuZWVkIHRoZSBt
YXBwaW5nIHdpdGggdGhlIHZpcnR1YWwgSUQ/DQo+Pj4+IHZNYXN0ZXJJRCBpcyBvcHRpb25hbCBp
ZiB1c2VyIGtub3dzIHBNYXN0ZXJJRCBpcyB1bmlxdWUgb24gdGhlIHN5c3RlbS4gQnV0IGlmIHBN
YXN0ZXJJZCBpcyBub3QgdW5pcXVlIHRoZW4gdXNlciBuZWVkcyB0byBwcm92aWRlIHRoZSB2TWFz
dGVySUQuDQo+Pj4gDQo+Pj4gU28gdGhlIGV4cGVjdGF0aW9uIGlzIHRoZSB1c2VyIHdpbGwgYmUg
YWJsZSB0byBrbm93IHRoYXQgdGhlIHBNYXN0ZXJJRCBpcyB1bmlxLiBUaGlzIG1heSBiZSBlYXN5
IHdpdGggYSBjb3VwbGUgb2YgU01NVXMsIGJ1dCBpZiB5b3UgaGF2ZSA1MCsgKGFzIHN1Z2dlc3Rl
ZCBhYm92ZSkuIFRoaXMgd2lsbCBiZWNvbWUgYSBwYWluIG9uIGxhcmdlciBzeXN0ZW0uDQo+Pj4g
DQo+Pj4gSUhNTywgaXQgd291bGQgYmUgbXVjaCBiZXR0ZXIgaWYgd2UgY2FuIGRldGVjdCB0aGF0
IGluIGxpYnhsIChzZWUgYmVsb3cpLg0KPj4gV2UgY2FuIG1ha2UgdGhlIHZNYXN0ZXJJRCBjb21w
dWxzb3J5IHRvIGF2b2lkIGNvbXBsZXhpdHkgaW4gbGlieGwgdG8gc29sdmUgdGhpcw0KPiANCj4g
SW4gZ2VuZXJhbCwgY29tcGxleGl0eSBpbiBsaWJ4bCBpcyBub3QgdG9vIG11Y2ggb2YgcHJvYmxl
bS4NCg0KSSBhbSBhIGJpdCB1bnN1cmUgYWJvdXQgdGhpcyBzdHJhdGVneS4NCkN1cnJlbnRseSB4
bCBoYXMgb25lIGNvbmZpZ3VyYXRpb24gZmlsZSB3aGVyZSB5b3UgcHV0IGFsbCBYZW4gcGFyYW1l
dGVycy4gVGhlIGRldmljZSB0cmVlIGlzIG9ubHkgbmVlZGVkIGJ5IHNvbWUgZ3Vlc3RzIHRvIGhh
dmUgYSBkZXNjcmlwdGlvbiBvZiB0aGUgc3lzdGVtIHRoZXkgcnVuIG9uLg0KSWYgd2UgY2hhbmdl
IHRoZSBtb2RlbCBhbmQgc2F5IHRoYXQgWGVuIGNvbmZpZ3VyYXRpb24gcGFyYW1ldGVycyBhcmUg
Ym90aCBpbiB0aGUgY29uZmlndXJhdGlvbiBhbmQgdGhlIGRldmljZSB0cmVlLCB3ZSBzb21laG93
IGVuZm9yY2UgdG8gaGF2ZSBhIGRldmljZSB0cmVlIGV2ZW4gdGhvdWdoIHNvbWUgZ3Vlc3RzIGRv
IG5vdCBuZWVkIGl0IGF0IGFsbCAoZm9yIGV4YW1wbGUgWmVwaHlyKS4NCkkgdGhpbmsgd2UgbmVl
ZCB0byBkaXNjdXNzIHRoYXQgYW5kIG1ha2Ugc3VyZSB3ZSBzdGF5IGNvaGVyZW50IGJlY2F1c2Ug
cmlnaHQgbm93IHRoZSB1c2VyIHdpbGwgaGF2ZSB0byBkbyB0aGluZ3Mgb24gdGhlIGNvbmZpZ3Vy
YXRpb24gYW5kIG9uZSB0aGluZyBpbiB0aGUgZGV2aWNlIHRyZWUuDQoNCkNoZWVycw0KQmVydHJh
bmQNCg0KPiANCj4+PiANCj4+Pj4+IA0KPj4+Pj4+IFRoZSBkZXZpY2UgdHJlZSBub2RlIHdpbGwg
YmUgdXNlZCB0byBhc3NpZ24gdGhlIGRldmljZSB0byB0aGUgZ3Vlc3QgYW5kIGNvbmZpZ3VyZSB0
aGUgU3RhZ2UtMiB0cmFuc2xhdGlvbi4gR3Vlc3Qgd2lsbCB1c2UgdGhlDQo+Pj4+Pj4gdk1hc3Rl
ci1JRCB0byBjb25maWd1cmUgdGhlIHZJT01NVSBkdXJpbmcgYm9vdC4gWGVuIG5lZWRzIGluZm9y
bWF0aW9uIHRvIGxpbmsgdk1hc3Rlci1JRCB0byBwTWFzdGVyLUlEIHRvIGNvbmZpZ3VyZQ0KPj4+
Pj4+IHRoZSBjb3JyZXNwb25kaW5nIHBJT01NVS4gQXMgSSBtZW50aW9uIHdlIG5lZWQgdk1hc3Rl
ci1JRCBpbiBjYXNlIGEgc3lzdGVtIGNvdWxkIGhhdmUgMiBpZGVudGljYWwgTWFzdGVyLUlEIGJ1
dA0KPj4+Pj4+IGVhY2ggb25lIGNvbm5lY3RlZCB0byBhIGRpZmZlcmVudCBTTU1VIGFuZCBhc3Np
Z25lZCB0byB0aGUgZ3Vlc3QuDQo+Pj4+PiANCj4+Pj4+IEkgYW0gYWZyYWlkIEkgc3RpbGwgZG9u
J3QgdW5kZXJzdGFuZCB3aHkgdGhpcyBpcyBhIHJlcXVpcmVtZW50LiBMaWJ4bCBjb3VsZCBoYXZl
IGVub3VnaCBrbm93bGVkZ2UgKHdoaWNoIHdpbGwgYmUgbmVjZXNzYXJyeSBmb3IgdGhlIFBDSSBj
YXNlKSB0byBrbm93IHRoZSBJT01NVSBhbmQgcE1hc3RlcklEIGFzc29jaWF0ZWQgd2l0aCBhIGRl
dmljZS4NCj4+Pj4+IA0KPj4+Pj4gU28gbGlieGwgY291bGQgYWxsb2NhdGUgdGhlIHZNYXN0ZXJJ
RCwgdGVsbCBYZW4gdGhlIGNvcnJlc3BvbmRpbmcgbWFwcGluZyBhbmQgdXBkYXRlIHRoZSBkZXZp
Y2UtdHJlZS4NCj4+Pj4+IA0KPj4+Pj4gSU9XLCBpdCBkb2Vzbid0IHNlZW0gdG8gYmUgbmVjZXNz
YXJ5IHRvIGludm9sdmUgdGhlIHVzZXIgaW4gdGhlIHByb2Nlc3MgaGVyZS4NCj4+Pj4gWWVzLCBs
aWJ4bCBjb3VsZCBhbGxvY2F0ZSB0aGUgdk1hc3RlcklEIGJ1dCB0aGVyZSBpcyBubyB3YXkgd2Ug
Y2FuIGZpbmQgdGhlIGxpbmsgYi93IHZNYXN0ZXJJRCBjcmVhdGVkIHRvIHBNYXN0ZXJJRCBmcm9t
IGR0ZGV2Lg0KPj4+PiBXaGF0IEkgdW5kZXJzdGFuZCBmcm9tIHRoZSBjb2RlIGlzIHRoYXQgdGhl
cmUgaXMgbm8gbGluayBiZXR3ZWVuIHRoZSBwYXNzdGhyb3VnaCBub2RlIGFuZCBkdGRldiBjb25m
aWcgb3B0aW9uLiBUaGUgcGFzc3Rocm91Z2gNCj4+Pj4gbm9kZSBpcyBkaXJlY3RseSBjb3BpZWQg
dG8gZ3Vlc3QgRFQgd2l0aG91dCBhbnkgbW9kaWZpY2F0aW9uLiBEdGRldiBpcyB1c2VkIHRvIGFk
ZCBhbmQgYXNzaWduIHRoZSBkZXZpY2UgdG8gSU9NTVUuDQo+Pj4+IExldCdzIHRha2UgYW4gZXhh
bXBsZSBpZiB0aGUgdXNlciB3YW50cyB0byBhc3NpZ24gdHdvIGRldmljZXMgdG8gdGhlIGd1ZXN0
IHZpYSBwYXNzdGhyb3VnaCBub2RlLg0KPj4+PiAvZHRzLXYxLzsNCj4+Pj4gLyB7DQo+Pj4+ICAg
IC8qICMqY2VsbHMgYXJlIGhlcmUgdG8ga2VlcCBEVEMgaGFwcHkgKi8NCj4+Pj4gICAgI2FkZHJl
c3MtY2VsbHMgPSA8Mj47DQo+Pj4+ICAgICNzaXplLWNlbGxzID0gPDI+Ow0KPj4+PiAgICBhbGlh
c2VzIHsNCj4+Pj4gICAgICAgIG5ldCA9ICZtYWMwOw0KPj4+PiAgICB9Ow0KPj4+PiAgICBwYXNz
dGhyb3VnaCB7DQo+Pj4+ICAgICAgICBjb21wYXRpYmxlID0gInNpbXBsZS1idXMiOw0KPj4+PiAg
ICAgICAgcmFuZ2VzOw0KPj4+PiAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8Mj47DQo+Pj4+ICAg
ICAgICAjc2l6ZS1jZWxscyA9IDwyPjsNCj4+Pj4gICAgICAgIG1hYzA6IGV0aGVybmV0QDEwMDAw
MDAwIHsNCj4+Pj4gICAgICAgICAgICBjb21wYXRpYmxlID0gImNhbHhlZGEsaGIteGdtYWMiOw0K
Pj4+PiAgICAgICAgICAgIHJlZyA9IDwwIDB4MTAwMDAwMDAgMCAweDEwMDA+Ow0KPj4+PiAgICAg
ICAgICAgIGludGVycnVwdHMgPSA8MCA4MCA0ICAwIDgxIDQgIDAgODIgND47DQo+Pj4+ICAgICAg
ICB9Ow0KPj4+PiAgICAgIG1hYzE6IGV0aGVybmV0QDIwMDAwMDAwIHsNCj4+Pj4gICAgICAgICAg
ICBjb21wYXRpYmxlID0g4oCccjgxNjkiOw0KPj4+PiAgICAgICAgICAgIHJlZyA9IDwwIDB4MTAw
MDAwMDAgMCAweDEwMDA+Ow0KPj4+PiAgICAgICAgICAgIGludGVycnVwdHMgPSA8MCA4MCA0ICAw
IDgxIDQgIDAgODIgND47DQo+Pj4+ICAgICAgICB9Ow0KPj4+PiAgICB9Ow0KPj4+PiB9Ow0KPj4+
PiBkdGRldiA9IFsgIi9zb2MvZXRoZXJuZXRAMTAwMDAwMDDigJ0sIOKAnC9zb2MvZXRoZXJuZXRA
ZjIwMDAwMDDigJ0gXQ0KPj4+PiBUaGVyZSBpcyBubyBsaW5rIHdoaWNoIGR0ZGV2IGVudHJ5IGJl
bG9uZ3MgdG8gd2hpY2ggbm9kZS4gVGhlcmVmb3IgdGhlcmUgaXMgbm8gd2F5IHRvIGxpbmsgdGhl
IHZNYXN0ZXJJRCBjcmVhdGVkIHRvIHBNYXN0ZXJJRC4NCj4+PiANCj4+PiBJIGFncmVlIHRoZXJl
IGlzIG5vIGxpbmsgdG9kYXkuIEJ1dCB3ZSBjb3VsZCBhZGQgYSBwcm9wZXJ0eSBpbiB0aGUgcGFy
dGlhbCBkZXZpY2UtdHJlZSB0byBtZW50aW9uIHdoaWNoIHBoeXNpY2FsIGRldmljZSBpcyBhc3Nv
Y2lhdGVkLg0KPj4+IA0KPj4+IFdpdGggdGhhdCwgSSB0aGluayBhbGwsIHRoZSBjb21wbGV4aXR5
IGlzIG1vdmVkIHRvIGxpYnhsIGFuZCBpdCB3aWxsIGJlIGVhc2llciBmb3IgdGhlIHVzZXIgdG8g
dXNlIHZJT01NVS4NCj4+PiANCj4+PiBbLi4uXQ0KPj4gQXMgb2Ygbm93IGxpYnhsIGRpcmVjdGx5
IGNvcGluZyB0aGUgcGFydGlhbCBEVCB0byBndWVzdCBEVCB3aXRob3V0IGFueSBtb2RpZmljYXRp
b24uIElmIHdlIGhhdmUgdG8gZ28gdG8gdGhpcyByb3V0ZSBsaWJ4bCBoYXMgdG8gbW9kaWZ5DQo+
PiB0aGUgcGFydGlhbCBEVCBpbiBsaWJ4bCB0byBpbmNsdWRlIOKAnGlvbW11c+KAnSBvciAiaW9t
bXUtbWFw4oCdLiBJcyB0aGF0IG9rYXkgdG8gbW9kaWZ5IHRoZSBwYXJ0aWFsIERUIGluIGxpYnhs
IA0KPiANCj4gSSBhbSBub3QgYXdhcmUgb2YgYW55IGlzc3VlIHRvIG1vZGlmeSB0aGUgcGFydGlh
bCBkZXZpY2UtdHJlZS4gSW4gZmFjdCwgSSBhbSBzdHJvbmdseSBpbiBmYXZvciBvZiBsaWJ4bCB0
byBtb2RpZnkgaXQgaWYgaXQgZ3JlYXRseSBpbXByb3ZlIHRoZSB1c2VyIGV4cGVyaWVuY2UuDQo+
IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 13:27:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 13:27:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432070.684767 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooPON-0001tR-Sk; Fri, 28 Oct 2022 13:27:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432070.684767; Fri, 28 Oct 2022 13:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooPON-0001tK-PO; Fri, 28 Oct 2022 13:27:23 +0000
Received: by outflank-mailman (input) for mailman id 432070;
 Fri, 28 Oct 2022 13:27:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooPOM-0001sG-RP
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 13:27:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooPOM-0003bu-De; Fri, 28 Oct 2022 13:27:22 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooPOM-00074V-79; Fri, 28 Oct 2022 13:27:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nlI3ppQNEYRC4xNc/a0NJE+tXBTdQAsrvZ1E+VpghME=; b=xdD/sbWqTwh3ZB0cDSqy0S7sof
	4W+LE3BbUKu6X/zILG/9FF1UhELMDErkRCG6u0FFfIWQJfCUlOTs7eEDXrmc3P1GqFAH3O+kWOmVz
	2hwUfazco6Rb3a+kWYudsK9nkMbQoMD9127PaUSOcjGSg8twyJtRxUSra+MZOOPHM1Tw=;
Message-ID: <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
Date: Fri, 28 Oct 2022 14:27:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 28/10/2022 14:13, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

>> On 28 Oct 2022, at 14:06, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Rahul,
>>
>> On 28/10/2022 13:54, Rahul Singh wrote:
>>>>>>>> For ACPI, I would have expected the information to be found in the IOREQ.
>>>>>>>>
>>>>>>>> So can you add more context why this is necessary for everyone?
>>>>>>> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
>>>>>>
>>>>>> I am confused. Below, you are making the virtual master ID optional. So shouldn't this be mandatory if you really need the mapping with the virtual ID?
>>>>> vMasterID is optional if user knows pMasterID is unique on the system. But if pMasterId is not unique then user needs to provide the vMasterID.
>>>>
>>>> So the expectation is the user will be able to know that the pMasterID is uniq. This may be easy with a couple of SMMUs, but if you have 50+ (as suggested above). This will become a pain on larger system.
>>>>
>>>> IHMO, it would be much better if we can detect that in libxl (see below).
>>> We can make the vMasterID compulsory to avoid complexity in libxl to solve this
>>
>> In general, complexity in libxl is not too much of problem.
> 
> I am a bit unsure about this strategy.
> Currently xl has one configuration file where you put all Xen parameters. The device tree is only needed by some guests to have a description of the system they run on.
> If we change the model and say that Xen configuration parameters are both in the configuration and the device tree, we somehow enforce to have a device tree even though some guests do not need it at all (for example Zephyr).

I think my approach was misunderstood because there is no change in the 
existing model.

What I am suggesting is to not introduce iommu_devid_map but instead let 
libxl allocate the virtual Master-ID and create the mapping with the 
physical Master-ID.

Libxl would then update the property "iommus" in the device-tree with 
the allocated virtual Master-ID.

Each node in the partial device-tree would need to have a property
to refer to the physical device just so we know how to update the 
"iommus". The list of device passthrough will still be specified in the 
configuration file. IOW, the partial device-tree is not directly 
involved in the configuration of the guest.

So far, I don't see a particular issue with this approach because the 
vMaster ID algorithm allocation should be generic. But please let me 
know if you think there are bits I am missing.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 13:28:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 13:28:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432076.684778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooPPN-0002Wy-87; Fri, 28 Oct 2022 13:28:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432076.684778; Fri, 28 Oct 2022 13:28:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooPPN-0002Wr-38; Fri, 28 Oct 2022 13:28:25 +0000
Received: by outflank-mailman (input) for mailman id 432076;
 Fri, 28 Oct 2022 13:28:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IcqW=25=invisiblethingslab.com=marmarek@srs-se1.protection.inumbo.net>)
 id 1ooPPL-0002U5-E7
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 13:28:23 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63939aed-56c4-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 15:28:21 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id E3ADB3200954;
 Fri, 28 Oct 2022 09:28:18 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Fri, 28 Oct 2022 09:28:19 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 28 Oct 2022 09:28:16 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63939aed-56c4-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1666963698; x=
	1667050098; bh=ceMsi2j89XVIw2/Off3vX06mukvQ4YVYqKcLixrJIVs=; b=k
	Fxe0kx7eyKmkbAw56PoB8cCvJBBY8E5bxF7Mk8sUvFWrjzsougDXBPKU5cy6mNai
	/ny5MdCXXhyso9LAwcpK4O7lhvgA6d0jrapKCZdkhWaiZEnQfz/kfiX7xJu7zscZ
	wviAGglSS+kXNGWvlE+FuQ+jEwTyiWzwdjMXbDxo/El+Byriin0wn8uL9L6Gb5FO
	tnjeDHPG28fK01iSgdXTPnfxltMougFmUI+xNEovKKbPmnpDlR1McENV5Xr/QrJC
	NvlYYUExuh1BzCXGxCEVSpNTbkjzIjuIs/0HAwqPCJlnHdAhztXrxrH9o/gTwaUy
	9TlqXo+K6f3brZ68l10hg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1666963698; x=1667050098; bh=ceMsi2j89XVIw2/Off3vX06mukvQ
	4YVYqKcLixrJIVs=; b=bIFsTgj6paL7m07GfLrvNsFeC8ByNbtHzkQfHyzkkSMk
	ojyLUzKABjshOHDApjYhNRu9BFtiGgPwLPzhQ9tDno9d3uz4vZha7dg5gbeBrpDw
	ZSMU8T1+FaZsLUHwvvl8B04nrtguQA+zRKapL0tiUSq8pJr43rTKMW7YZyoRvQu2
	FFfnRyL+E7Tv6ttdCF222k/TbP4Z8eaOE7NMG9zD/4PMVo32MahiooLRAr2CW17U
	6oR4g6lyNAb9OMg/FlxyQvHRS69h3qanMWWRSihAEdawfmCMbFZ/ARObdZfMVwm7
	4xX5tHUEMtwc03mNLGP7HqiTI4EcMmMLMjkcR8pZ7A==
X-ME-Sender: <xms:8dhbYzr8qsxyhDrp4ISUhGCdssG59KtqfqryQq1KPJHLlrCqdJmzOQ>
    <xme:8dhbY9qc19xwAVjhgftMXaClVO5ajs0DSTVTbQ8tnCCx2D9pZIguvWkx60GL9ULnA
    g47zUvfI4LRpw>
X-ME-Received: <xmr:8dhbYwP9EVuc9FPiLsJhkvYfsdtkftShkpZAkuARATnjERVVOvSTW_3phIETWWxhe_eCa0zAvOH8as4ESRup3-pvdqJ0wUxWKV-f>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdeigdeifecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk
    ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh
    hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefgudel
    teefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlhhush
    htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes
    ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:8dhbY27YoA1i4KqOjEqKP7awQ1CxnSp2rUeILft4otcVioJZy1RBXA>
    <xmx:8dhbYy6_mnU4cbPmQdz7SnVlUBfKFxsfe7xnmjmdcI_CzLQtxjLVQQ>
    <xmx:8dhbY-hW9b2LQ6g_O39jl6ucgf68g5hSBwz7rTOqsfXH8zR_4Xcmdw>
    <xmx:8thbY4mxympksvOQLs5VNn_oK9Ys0q5v7gA3RJh1KD8tloSkhZ_kng>
Feedback-ID: i1568416f:Fastmail
Date: Fri, 28 Oct 2022 15:28:12 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17 v2] xen/sched: migrate timers to correct cpus
 after suspend
Message-ID: <Y1vY7GmHCAmJj6hq@mail-itl>
References: <20221028111231.31355-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="FK5hyYDgtHHSKWjp"
Content-Disposition: inline
In-Reply-To: <20221028111231.31355-1-jgross@suse.com>


--FK5hyYDgtHHSKWjp
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Fri, 28 Oct 2022 15:28:12 +0200
From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
	George Dunlap <george.dunlap@citrix.com>,
	Dario Faggioli <dfaggioli@suse.com>, Meng Xu <mengxu@cis.upenn.edu>,
	Henry Wang <Henry.Wang@arm.com>
Subject: Re: [PATCH-for-4.17 v2] xen/sched: migrate timers to correct cpus
 after suspend

On Fri, Oct 28, 2022 at 01:12:31PM +0200, Juergen Gross wrote:
> Today all timers are migrated to cpu 0 when the system is being
> suspended. They are not migrated back after resuming the system again.
>=20
> This results (at least) to problems with the credit scheduler, as the
> timer isn't handled on the cpu it was expected to occur.
>=20
> Add migrating the scheduling related timers of a specific cpu from cpu
> 0 back to its original cpu when that cpu has gone up when resuming the
> system.
>=20
> Signed-off-by: Juergen Gross <jgross@suse.com>

This time it works, thanks!

Tested-by: Marek Marczykowski-G=C3=B3recki <marmarek@invisiblethingslab.com>

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab

--FK5hyYDgtHHSKWjp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmNb2O0ACgkQ24/THMrX
1ywkrAf+KHdjckeNgNVoJTCPUnFSIYR7OwKaZOoiUr6U1Mqkg9YNbVhtdRD8EmVP
XsxA+puCQII7Zpg4Mtf2x6CEUL73eJMOdBfiPBvZkMJVQmnv099a+xh8xQqLQ35X
pG5TzKWACzdjpo/nsBdOliHiLCmUZf2jRxerluOlwir1QPPUIkOrUdrfmgtd4Dlb
kr3kY5ISJxEvsdarLUQeTO8GoNUFOQ8KX49kdVgp4S6OWlhO9EOGWIb7tx0DwX0g
cCj9GB5IzYiK81Fxr2tSu5174pXWxgliCFw7GLjSNRSk1q62Gv+6R+prZ6PNI+DQ
t7YiW+eK9h3Fh6KDr1+xPYx8krhXmw==
=TEcY
-----END PGP SIGNATURE-----

--FK5hyYDgtHHSKWjp--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 14:08:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 14:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432092.684801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQ2K-00087S-HR; Fri, 28 Oct 2022 14:08:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432092.684801; Fri, 28 Oct 2022 14:08:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQ2K-00087L-EC; Fri, 28 Oct 2022 14:08:40 +0000
Received: by outflank-mailman (input) for mailman id 432092;
 Fri, 28 Oct 2022 14:08:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=liZE=25=citrix.com=prvs=293a53108=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1ooQ2I-00087F-VY
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 14:08:39 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 01c3ca1e-56ca-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 16:08:35 +0200 (CEST)
Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 28 Oct 2022 10:08:22 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by MN2PR03MB4941.namprd03.prod.outlook.com (2603:10b6:208:1a6::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 14:08:20 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::5d4b:6b1d:efc2:20e5]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::5d4b:6b1d:efc2:20e5%8]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 14:08:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01c3ca1e-56ca-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1666966115;
  h=from:to:subject:date:message-id:mime-version;
  bh=IX5bE3d8w10EbdF50wfkcZWE8qhZTI4jDIK8O7RLuJE=;
  b=hMgp/revVFXp7fNwPJ8aqTT8l/IKiFodn4rwtFngSxh5KRXWULCCjCde
   fvXcgUzUwtAaIb3uiPLXTmDKbdtIvIwnHUGX0f3yJ1Hm7suhZB7gaVAHz
   wK433wi+3/RF3TwRDDT7zk9ilfNzxgswplcdjODtc9nw4WRcMRIEm6wXF
   k=;
X-IronPort-RemoteIP: 104.47.58.102
X-IronPort-MID: 86247844
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:G/VWxajlTsAn/mZjb07Jl8gLX1614RUKZh0ujC45NGQN5FlGYwSy9
 lOraxnFY6jUMyawOYxoOc7lxf41ycOBzdY1HlBoq3ozRCkT9pWUXYzCJ0ygYXOfcp2ZERI95
 J5GNYeQdZw9RHWH+Rnya+K/pyR33PHRGrOhUbOYZX8ZqWOIMMsEoUsLd7kR3t446TTAPz6wh
 D/SnyH+EFP11m4lPjxKsP/b8kpm5qmq4W5E4gYyP/wStwKHmiUYXc4Tfa2/ESD1E9JedgKYq
 0Qv75nipz+EoE19Yj+BuuymGqHfaueKZWBislIPB+75xEAH/nZpukoCHKJ0QV9NjDmUlMxGx
 txItJihIS8kJaSJk+kGO/ViO3gW0ZZupfmWfBBTjeTJlxecKiO2k600ZK0LFdZwFthfUDkmG
 cMwcFjhXjjb78qqzbSyTPVbh8hLBKEH66tG5xmMZRmAZRoXacirr5fivLe07x9p7ix6Jt7MZ
 tJxVNZaRE+ojyujmLsgIMlWcO+A3hETetDDwb6fjfJfD2P7lGSd3FVxWTZ8lxPjqch9xy6lS
 mz6E2vRPxIeN9rH1z68702CqerCjSCqSoJDG+jtnhJqqAX7Km07LjQzDAP+jdznz0m0VpRYN
 lAe/Tcooe4q7ku3Q9LhXhq+5nmZohobXNkWGOo/gO2P4vOMv0DFWS5ZHngYMIZOWMweHFTG0
 nemktTzCjEpnKCTTXuF3ryVsSmzKW4eKmpqiSosHVVfv4az/N1bYhTnUvBSLZz2gdbJKBLK6
 DSmkg8Q36wotJtev0m81RWd6962nbDZQwhw6gjJU2aN6gJieJXjd4Gu8ULc7/tLMMCeVFbpl
 GQNnsGFquNICZyLmz2ARM0CGbio47CONzi0qV9pA5QlsiSg/Vaie5xd5Hd1I0IBGsoNfz7kZ
 AnQuBtc/rdUJnKhaaIxaIW0Y+whzbLhDsjiTvDZdJxRJJN1fRWE1C5rbE+UmWvqlSAEiawlI
 p6Ga+6jCH8bDeJsyz/eb+QQz74tgDgzzHnIQpbTyA671LOYb3mTUqoBLFqIYaYy66bsiAfa6
 dFELOOR1g5SFub5Z0H/6YION0oDK2QTDJX/uctRMOWEJ2JOGmYhDbnTwJsgfZBom+JekeKg1
 nyxVUZCjlvwgXDcKAyRQmBibLLpTdB0qndTFTYrN1eunWIqZ4qv5bgWX5IteP8s8+kL5dduU
 /QATOCRDf1ORyrv9iwUaN/2q4kKXDGimR7IBDKoZjMyZbZpXQmP8djhFiPU6CQRBzCr8+s/p
 7Gt3BnSR5YrTgFuSs3RbZqH0VS1unQMnfNoaEHBKNJTZUbE/ZBjLmr6ifpfC+MBJxuF5SaQ3
 h2dABQwqe7XpYIv797ThrvCpICse8NlBVZTFWTf6bewNAHZ83ClzIsGV/yHFRjfSWf19aOKd
 ehTifbmP5UvhldDtZNhErBt5a077trr4bRdy2xMEG3QalW3CptpOnScwdRUrapJ26NYvg2tH
 EmI/7FyMryTNMToOFUYPgYiY6KI0vR8sjXN6OsdKUDz9ihxurGAF1hRVzGFjS1BBLpzPpksz
 eootIgR8QPXogQjKN+KgSlJ622JBnMFWqQj8JodBefDgBAqw1cEfpvbBjTe8JCLatNcdEItJ
 1e8nq3Iwahb2UzGfmsbGn3E3O4bjpML0DhAy1UINhKEgdrBi/o+2jVe9D02SkJeyRAv++l2O
 256Pld5DaCQ/ix0jY5IWGXEMwZFBQOY91a3z1IMnmDDU2G2X3DANyszI46l9VsZtWAaYTlf8
 LCex07qVD/reIf62S5acXRsq+HnC+dw8ALCsMm9GoKOGJxSSSLkhbO0I2kSrB/PWsY9iUeBr
 u5vlM56c6D9OScWoPZiU6GV0L0RTFaPI2kqafBn574TEmb0YjCp1CWWbUa8ZqtlIPjH8lSxD
 cB0EctJWw6jzyaFrj0dBqkkLqd9mbgi499qUrTvKG0dur2TtA11oYnQ/Sjzgmwsa9h2mMN7I
 YTUHxqOH2GImXtV3WrlqNVYISyzZtxsTBb32/yp7+khGJcKseUqekY3upO+snO9PRtg4xuSv
 R7GIa7Rp8RnyI9slo+qFb9RCgGcINb/Eu+P9Wibtt1UZpXSN8jDrAgVq1r7JCxINKccQJJ5j
 9ylosX30UXtsaYxT2nfmoSEUahOje24QfBFO8bwIH5FlAONXcbt510I/GXQAbxElslMoPauQ
 QSQYdG1M9USXr9gKGZ9biFfF1MRDvrxZ6K5/Sel9a3UUF4azBDNK86h+Tnxd2ZHeyQUOpr4T
 Ajpp/Kp4dMep4NJbPMZO8xb71ZDCAeLccMbmxfZ7FF00kHAbou+h4bf
IronPort-HdrOrdr: A9a23:rv3M7KAMcq3hgwLlHegvsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+VAssQIb6Km90ci7MDrhHPtOjbX5Uo3SODUO1FHIEGgA1/qr/9SDIVyYygc178
 4JHMZD4bbLfDtHZLPBkWyF+qEbsbu6Gc6T5dv2/jNId0VHeqtg5wB2BkKwCUttXjRLApI/Cd
 61+tdHjyDIQwVcUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmj2AsEWT8n+8ZuzY
 GFqX202kyQiYD09vbu7R6T032Qoqqg9jJ3Pr3CtiHSEESutu/nXvUiZ1TIhkFMnAjm0idQrD
 CLmWZqAy070QKtQkil5RTqwAXuyzAo9jvrzkKZm2LqpYjjSCs9ENcpv/MsTvNIg3BQxu2U/Z
 g7rV5xjaAneC/ojWD4/ZzFRhtqnk27rT4rlvMSlWVWVc8bZKVKpYIS8UtJGNNYdRiKnrwPAa
 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23xdnWx/zUEf2MsD901wg64VWt1B/a
 DJI65onLZBQosfar98Hv4IRY+tBmnEUXv3QRGvyJTcZdE60l722uDKCe8OlZ2XkbQzveQPsY
 WEVk9EvmgvfE+rAdGS3fRwg2HwfFk=
X-IronPort-AV: E=Sophos;i="5.95,221,1661832000"; 
   d="asc'?scan'208";a="86247844"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e2DyyeKnjNSbfNSBuKeoJ45j5DZnYjIOSduP4gdlGuZXFur82NmC/ISpJuCOE+lvezB6z29K+wxXwQpuOKdu1Hi51lyPAZBKyxrN6RF7eFQqM24z+68+ghdkAkunsrVoKCcVqbC6MHW4whafc83cIi93of11f9mg4YVcCAIDX7GSm1zjzZ+7RC1ZkHCWpN/bn9vvB+NaaEpfBjEgfTirEn9STRN80wWgW3kxr4QJKwRqxMkMXf4U7rP5834K74aG8tkUAQ8TV9tcu0VbacA6IujxV7+XA/TtX8EbL2r+DFSNL54EsDmjtGyKERxQMI56+EbZTetj0WMlC3Yf9HcMxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1ILY2e1JF6EHNwafO8OS3b56l5srkzzN/om2u2AW4+0=;
 b=LkP+WLLWTq1FxIOVT1yi/Q+ArQMrDL307YbR7caF1pNNoR/XLDNpyLhNSimqvzGQISaewjtu8QdS/3XbPQ6YRZTc6jmJvfKlwqwoSer68oA6893nz9mq13Ee1mLuBrZR4I6m6UFCswbQFDAsihvI7dgrdectf2GHJfx6DDUpfo6d6LzQ0FEEv67TYVMotVBCTjlPwNtepeTpLifjmqiHCCpQ7r3ZJgQThfitom4zIb2jb7TIWjbuXbYKTEv900Psd3AuZJMi3OgP8IXL/hTU7QPIYWilNjy6kyoCjiqWz21cXqOqvaNrer9zM9SBXqn3gLtH+ntg6mxXdaTklsYPJA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1ILY2e1JF6EHNwafO8OS3b56l5srkzzN/om2u2AW4+0=;
 b=ROggbLD/jtXxrpkRbb0DMKHTI/nIg68nXYHMssbmOZMruH/Cchy6wjq4pIBu+pB9kjGC6YLFViGOrdyQDySOvwpdxOFP3a+SB2V8A9w5B20AtqQIL9vz5si12ofAc0OonAOVqnAhZVZtNt3f03NZmy6oeTC6jovJUjN0qEiirgg=
From: George Dunlap <George.Dunlap@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>, Tamas K Lengyel
	<tamas.k.lengyel@gmail.com>, "intel-xen@intel.com" <intel-xen@intel.com>,
	"daniel.kiper@oracle.com" <daniel.kiper@oracle.com>, Roger Pau Monne
	<roger.pau@citrix.com>, Sergey Dyasli <sergey.dyasli@citrix.com>, Christopher
 Clark <christopher.w.clark@gmail.com>, Rich Persaud <persaur@gmail.com>,
	Kevin Pearson <kevin.pearson@ortmanconsulting.com>, Juergen Gross
	<jgross@suse.com>, =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= <pdurrant@amazon.com>,
	"Ji, John" <john.ji@intel.com>, "edgar.iglesias@xilinx.com"
	<edgar.iglesias@xilinx.com>, "robin.randhawa@arm.com"
	<robin.randhawa@arm.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>, Matt
 Spencer <Matt.Spencer@arm.com>, Stewart Hildebrand
	<Stewart.Hildebrand@amd.com>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Jeff Kubascik <Jeff.Kubascik@dornerworks.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Rian Quinn
	<rianquinn@gmail.com>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?=
	<cardoe@cardoe.com>, George Dunlap <George.Dunlap@citrix.com>, David
 Woodhouse <dwmw@amazon.co.uk>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= <amit@infradead.org>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?=
	<varadgautam@gmail.com>, Brian Woods <brian.woods@xilinx.com>, Robert Townley
	<rob.townley@gmail.com>, Bobby Eshleman <bobby.eshleman@gmail.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?=
	<cminyard@mvista.com>, Olivier Lambert <olivier.lambert@vates.fr>, Andrew
 Cooper <Andrew.Cooper3@citrix.com>, Ash Wilding <ash.j.wilding@gmail.com>,
	Rahul Singh <Rahul.Singh@arm.com>, =?utf-8?B?UGlvdHIgS3LDs2w=?=
	<piotr.krol@3mdeb.com>, Brendan Kerrigan <brendank310@gmail.com>, "Thierry
 Laurion (Insurgo)" <insurgo@riseup.net>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>, Deepthi <deepthi.m@ltts.com>, Scott Davis
	<scottwd@gmail.com>, Ben Boyd <ben@exotanium.io>, Anthony Perard
	<anthony.perard@citrix.com>, Michal Orzel <michal.orzel@amd.com>, Marc
 Ungeschikts <marc.ungeschikts@vates.fr>, Zhiming Shen <zshen@exotanium.io>,
	Xenia Ragiadakou <burzalodowa@gmail.com>,
	=?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLSGVucnkgV2FuZw==?= <Henry.Wang@arm.com>
Subject: [ANNOUNCE] Call for agenda items for 5 November Community Call @ 1600
 UTC
Thread-Topic: [ANNOUNCE] Call for agenda items for 5 November Community Call @
 1600 UTC
Thread-Index: AQHY6ta7MD4AHdQWJU2vQ8pVwyf2LA==
Date: Fri, 28 Oct 2022 14:08:19 +0000
Message-ID: <75B69D18-27F3-4DC6-9308-CD2548967154@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|MN2PR03MB4941:EE_
x-ms-office365-filtering-correlation-id: e89fb317-f219-496b-69c6-08dab8edde09
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 UfOZGTCmTMyIAILcRCzSqGo/BUWPjuZYAUaX0HfSMPKAeCNGuojw7D+CXutSxK1rbMM4C6AhP0jWZHGyajKi/tcCXC1JbfnRtYuoQ4DDe4z1zBRwZA3D8qf2U9piH34mdc9w0LIG9ICT4Q0fbPTyn1KJAdXKSSugRNzCKHl+OaG3KIKvArXVC1KHxpn/ZIbpM/naGZesgpgoGlINb17uT86YjdE1CxMihKBM/mdauutc6XKhVGL/Vf0Zrzt6XJsTpZCRpLt9/NlGn7g1u8aZSEyTvviiFG51ANV927uR8ZPV4tz2ldhX+TnGeHyAMV5zb/GGLatd26H0xkPA0wPSIHRlIjeg97I+VJfzgSm+yDR8oAymBtsUChZ/cqKAgbX70QZrs8S1wYe3BhG371o1fxGkyMvJPooQ14gtzdp+KI5q9yIjeSzkjIEcSO5AixIyyuV6M3owfWbsltcqO9IY+qfoHVL6BJCR6ZLGNAqGJLbs2tlVyWYN0DjFjhtDjKuMmLfzyeXp0XCAN7xW9rB0k0K205BmcoBYvg98WPr/xnBPdm9N6MbuEv5mHwOGbwV/cvcNS5ViONnCBCViBRG6PlwIpoKPW4vVakBzYLDb4e4g7iuikUB+Q6dA5y57+ac2F+6EIGeDomC6cdmbTV4VFzS0cWyaaYAlTA6OZk+JLcZ68PKqrmCguTXgFRwhcV3IKn9UlKuuATrX8Ry0qPwM91m5zcJEtyNS8qYpmFzz45muLv8m/g6e0XoU0BijJTX09SUW7zGEKUNHaiGkonZwB0FkqUKxCYWszgaK2zJf/4qL6/NjbYcovrJW2AjDM15xvjnuaJNjewqjLmOqWTGwTkHnBtfVx8Xp2alfCh/6DuU=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(366004)(39860400002)(346002)(396003)(451199015)(38070700005)(921005)(316002)(110136005)(33656002)(478600001)(6486002)(966005)(5660300002)(71200400001)(7416002)(7406005)(8936002)(91956017)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(41300700001)(8676002)(186003)(2616005)(6512007)(26005)(83380400001)(6506007)(86362001)(2906002)(122000001)(99936003)(1191002)(82960400001)(36756003)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ak5pdkxvVTM2Z3RaRDhjRXo4Sy9zSFE4NS9lTXJiS3RHdlpTQXdXTzJmMUZR?=
 =?utf-8?B?M3diZFB1ZmsyeUYyQ0ZxWEtNc1ZzcUVVRVFib1FXaDFqckVaMmJjd2RUcGQ1?=
 =?utf-8?B?NXVqYUQrWjFRejByMnk5ZVNJS0drS0VTY1prc0xpbzdocjN3a2FpMUkvKzV2?=
 =?utf-8?B?RU1UWmpJMnJaNUtHd2hUbGt4T3RvQU5JVkdrYjFpR3ZaQVBjeDllZlBRWGhi?=
 =?utf-8?B?UVdBc0RybUhBcEoxUDdKUXZiOTNtZDZ3ZkJLQUZSdUVEeElGTWZJaVpLL2sw?=
 =?utf-8?B?aDF2YmFESEdjRjRJZnI4MEk3ZmVWOVMxWVBxZTMyb0VNRk5SdmN5MU1qV0pD?=
 =?utf-8?B?R0RxdnpSVWJoUTN1Uk1raUVvUVFTUmRtMEp4RStsbDVDVmtveXg2TVFZQmQz?=
 =?utf-8?B?bzRNcWVsRytDekVLY2s5cDVUaWFzemU2bDVvUVlQSGpqbUM3U1k0cjNVcE00?=
 =?utf-8?B?Q2RkOE5RQjZXOGlQL1pNQjU3R0xaMUFwY21LajczTDVVakFoVWpsc2pSOVpq?=
 =?utf-8?B?bGVxSldmamlDZFZoRmNqSkJYQWpVcU1Pak41cmwrUzhqc1RzRm5qK0NBK2Z1?=
 =?utf-8?B?SGxoSWtndFpHcTJra0M3aTh4TlZMUGpJSkZWRWZudVdBSGx1a3hMUFBLdHhU?=
 =?utf-8?B?MldkbkoxK3ZSbjdlN1h3bXVmbTdxMkNxekF5RDJYT2xWblZyUEJtNTdrWUFv?=
 =?utf-8?B?VjZzWCtlWWVkSXdud25ONE9XN1NQMVAyR1FTbGs0VDRMdUphbDRvRmxXRUta?=
 =?utf-8?B?QVBhYjZ1QVJmRXh3b2FBTlduZjFvU1liT056bVFQTDUrRmNSeTNSSFNSbFdu?=
 =?utf-8?B?NUp1MmttS0k0aE1XRE8wRlZvanFTQ1UzdkdEU1NpNWxmdnVKRGNRODZxMTVN?=
 =?utf-8?B?L2FyeTFuUVBQdCtvTko4akRZajFQQU9kL1BOaHF5bEJOT1J0bDgxd3BVcmhC?=
 =?utf-8?B?RHJycUJ6TEQ5TnpnZmpiOUdkT2FrampzWVVqSlcrUDlWTHdYbVMveGdrNmtW?=
 =?utf-8?B?MEloeFVCMWFnWFJHdkxsekxqbDdvMkZXcjZLTkgya0pVNUF2T1dzOVY4N0FD?=
 =?utf-8?B?MmR2YUUzRTBKcG0xTXAxN0wwbDB0bEcxd01RSDJ5YWhuRHN4RFNKaVZsTTNE?=
 =?utf-8?B?QzhXamtTZWRHblNteVNQTGZyRWYzcGlZbEhxcmFTL2RTY0doTisxa1lDWWwz?=
 =?utf-8?B?U2h6RXgxL1RDR01TTzJNa3lIQ1JudE80VDY3QjNxb3J1d0l1M0xBejBiMmQz?=
 =?utf-8?B?N0FEU1RmQXVrcVlyWk9TOC80ZytaZ3NMNXhwUmZMd2QwYnJVblhrRUVYbDE3?=
 =?utf-8?B?UmtUYVMwMnZJSUFoVGdoZ3duMVlrS3NsRGZDZXorY0pqOGhoZlBveXVSR3hO?=
 =?utf-8?B?K0lnRmRwSmJDMzJwUmRMd1dWSW9TSFNyYUNXZ0h2NklNVVZ0MFg2VlorQWhZ?=
 =?utf-8?B?cVA2K0xJNTBZUTdLSGxldlpyN01UbEZnalNUK2sxNWlLazRobEtTWHgzb3hz?=
 =?utf-8?B?SThNMitDRzFsZk9RdlNzeHpCczF2VE9rc0xpR2syMURpWVovMkNHTFFLT2Nx?=
 =?utf-8?B?aHBuNXhSS0lHckZFa0duMnVvLzh4aWJLazRVMFAybHJqYnlPRkpXS2F1TXYx?=
 =?utf-8?B?eW9sVTNzZ1p3SGNlUHoveEVtbnNROGlDOFJnYmNjY2dFaHJFRm15ekZzcWVh?=
 =?utf-8?B?Zkh6b2FzVXpTMGFDV0lpaVNmdkQ2R1J6U0dCQjdrSmdSUG5sNFpHa3VCaXRu?=
 =?utf-8?B?UUdFNThTV1hxVVlQZjFPVEFIZU1tWlBrZVVDVGlBVHB2RmJnQk5oWEluV09z?=
 =?utf-8?B?S1J0c1RFOVRVY1JTdFROdjZraUR0bEdRQm82UGhIemdPMTBoZlk0dFpFUkxw?=
 =?utf-8?B?RlNNUE4vajRvVXNjczBseVk2Sm56UGtIRTlLZEwrYzgzWDIrQWpUbWRQajU5?=
 =?utf-8?B?WWswWVQ3aDdiQUhkRlpLQjlJdFJUWXI3eXo3MnEwRzRMNWtoZlhpSzFBcG9z?=
 =?utf-8?B?U056NWtlbXR6UndJV0UrYndJY1Q5bm9sSzFvSkJQR2JIMENza2lJRlNaSUlW?=
 =?utf-8?B?QUV6amgxeHdJOC9hOU9EcHBEZUZBRlFEcTgwTE1vTkdtMjJWRU8xZWRxaks4?=
 =?utf-8?B?Y1RFbGoxVVRJUDkwT2pJdXFwUjdYc0hPeUFYMkx6WWV1SFJiRTgxWUhzcXA5?=
 =?utf-8?B?S3c9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_18232369-4B07-4FC2-9AB8-DAB9C07DF87E";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e89fb317-f219-496b-69c6-08dab8edde09
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 14:08:19.7640
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: quUMdgT4nhr0eK4JsblqhKOWUMMuTMQgEiRELPSTc3f1G8bMV80PyavrAAsGeciW9uqfIGOmE+S4iQJHJNZC4y3y4jrfAlFCA9yuah4xCAI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4941

--Apple-Mail=_18232369-4B07-4FC2-9AB8-DAB9C07DF87E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii


Hi all,

The proposed agenda is in =
https://cryptpad.fr/pad/#/2/pad/edit/5YUquBkUpmg-XuzK8cyvUQ8+/ and you =
can edit to add items.  Alternatively, you can reply to this mail =
directly.

Agenda items appreciated a few days before the call: please put your =
name besides items if you edit the document.

Note the following administrative conventions for the call:
* Unless, agreed in the pervious meeting otherwise, the call is on the =
1st Thursday of each month at 1600 British Time (either GMT or BST)
* I usually send out a meeting reminder a few days before with a =
provisional agenda

* To allow time to switch between meetings, we'll plan on starting the =
agenda at 16:05 sharp.  Aim to join by 16:03 if possible to allocate =
time to sort out technical difficulties &c

* If you want to be CC'ed please add or remove yourself from the =
sign-up-sheet at =
https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Best Regards
George



=3D=3D Dial-in Information =3D=3D
## Meeting time
16:00 - 17:00 UTC
Further International meeting times: =
https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2022&mon=
th=3D11&day=3D3&hour=3D16&min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D=
179


## Dial in details
Web: https://meet.jit.si/XenProjectCommunityCall

Dial-in info and pin can be found here:

https://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall

--Apple-Mail=_18232369-4B07-4FC2-9AB8-DAB9C07DF87E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNb4k4ACgkQshXHp8eE
G+1fpAf/eyxDIVjLCUWbvRxyrUcZG5fQABmDRZ428iM8XayVWSzHyBY7GUgPS3rz
GdhRY8YeQLxeWWZijpaNY1O/OLUkF5YQvrhZgUIeBo+GgHomAv/2nH4JqPqRg7qZ
CRS0JKsQNF6C2HxM09GRKjD8k8npM7Qc0YO2kDBG/NHLrRTuADskKJvgdppXuaeM
UXk4eseybBf7y779f+opWG+kuJGv/ehrGxX0fs4gPYYgC6J50H+QfgqmvAfTgPQC
3Fo2pA/X5rl9CmXGHv/Ph1JGiW0KH+VnjQiWbntoT5fc0QE+6JtLbhqp0GFDAoMC
rQ/xEO4NigGaNMy4jjd95U+8pHVXvg==
=jM1T
-----END PGP SIGNATURE-----

--Apple-Mail=_18232369-4B07-4FC2-9AB8-DAB9C07DF87E--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 14:19:07 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 14:19:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432097.684813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQCE-0001Rf-Hc; Fri, 28 Oct 2022 14:18:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432097.684813; Fri, 28 Oct 2022 14:18:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQCE-0001RY-Ca; Fri, 28 Oct 2022 14:18:54 +0000
Received: by outflank-mailman (input) for mailman id 432097;
 Fri, 28 Oct 2022 14:18:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooQCD-0001RN-JC; Fri, 28 Oct 2022 14:18:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooQCD-0004Wc-Hn; Fri, 28 Oct 2022 14:18:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooQCD-0003tm-6s; Fri, 28 Oct 2022 14:18:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooQCD-0008Nx-6R; Fri, 28 Oct 2022 14:18:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VGevPwZhvjlLwaspnhTnJNdQ5WObojSfm1wXsJAP5BQ=; b=xiWcoZsJlodM2gIQEl2QPki6RX
	ForZwOpcaPZXzeDrxs7lm5SrWrTvhG8cAs1Ze+otiJp3r4WlYblWLOMqUZzUVMBYY5BKSvOpTjTmF
	g0Mz+5nwybWkHBEnzHDFvZvzkvEzyW2oSUIULbynJlV6rVQyfQCvZ//RLnoCbC9fjyKM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174529-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174529: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=7abd7bc1626d25ada03c1cff2e8c2ce1a5cc3cbf
X-Osstest-Versions-That:
    xen=20cf0ab774e828dc4e75ecebecf56b53aca754fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 14:18:53 +0000

flight 174529 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174529/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  7abd7bc1626d25ada03c1cff2e8c2ce1a5cc3cbf
baseline version:
 xen                  20cf0ab774e828dc4e75ecebecf56b53aca754fc

Last test of basis   174500  2022-10-27 10:00:28 Z    1 days
Testing same since   174529  2022-10-28 10:01:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   20cf0ab774..7abd7bc162  7abd7bc1626d25ada03c1cff2e8c2ce1a5cc3cbf -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 14:22:34 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 14:22:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432104.684823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQFl-0002qz-0D; Fri, 28 Oct 2022 14:22:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432104.684823; Fri, 28 Oct 2022 14:22:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQFk-0002qs-Sk; Fri, 28 Oct 2022 14:22:32 +0000
Received: by outflank-mailman (input) for mailman id 432104;
 Fri, 28 Oct 2022 14:22:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JFjJ=25=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1ooQFj-0002qm-9l
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 14:22:31 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3a1bca5-56cb-11ed-91b5-6bf2151ebd3b;
 Fri, 28 Oct 2022 16:22:29 +0200 (CEST)
Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15)
 by CH3PR12MB7620.namprd12.prod.outlook.com (2603:10b6:610:150::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 14:22:23 +0000
Received: from SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com
 ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5769.015; Fri, 28 Oct 2022
 14:22:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3a1bca5-56cb-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IGomFMOxsHPiNdRVLwAP++ZBBAeQptoHEg4py8x0T20ECIn4wq/4ujOBTwn30p8le7zntS+iaPRmmJFthJJTTCYHkdAtWYeuq+4geDKlATnhRNvsdxIz8rx6OEmqVpA8YdJ29wkJVW70Z0B7Y7mINEXa87OG5u3w290HEZGl6R1ncEihoSdLL1UyaBhVTRW71YFryDwsjahvPc5j82NtXsivOMb3KfNuemYC06CDE7IultwihTr5NgyeUVlejJ4Hh309eoix6tSBt8ko31calrczg3IsqT9SK8P9Fu75OAQMEWZA/cyWg/yjc7BXF1Kp08uIxPFnvECJ6NgnPLI+zQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DThRTzhvhBxTkuh04hZkGbUEAmJUzUIP+5exOn6G0+E=;
 b=NbIIsw8qVgedYYpxUHXtbU9Qd7wjW2EdyzRsIxHNz6WuulX5YYByDqo2jAlszhsofRQQ4wW+/RdKP8KhY+D13jE3I5uMhwLekxy3604L5jTHg1hYvRfc9QldQ8Ko3Qae/jCdbxrIPJF67SxAIFy1bfk4jsovkFF6inwFib08Tu+PkFl7Xp809bBTsdsE2E37v74TFp4K9gBlHV5b6Pf+uOLcKFCJzb0a1dNsgq6RFJ0OZ5z52aKoH8Ny6WtLDFzAEVIpGnJUDeIDLJt0vXesWxzeW71Xn72bAEyscKf4DgQppZl6F/P62Qny5WPRGi++WGKRZLbb/OtKm/JUXhnvxA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DThRTzhvhBxTkuh04hZkGbUEAmJUzUIP+5exOn6G0+E=;
 b=SVmBXKE9k6dHtxSK/nBZvBKwro3SWZtrGqEckFBu1WUUFyj/mX/K4qgiE1yEMiuHc3snPnLdICKpbs9Eg4UxygP2jbmAyVNBtyEvRMuVqaka58KzKr8nYwNX8ogApvjeg0Np29UVW7KXqwXq62rwJez//qtOrxzqwJWXzswLvOI=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <65168ade-6730-b90b-b927-86535b18bdcb@amd.com>
Date: Fri, 28 Oct 2022 15:22:15 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 07/12] Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-8-ayankuma@amd.com>
 <c1290406-9ec4-97f7-efad-8279dec39123@xen.org>
From: Ayan Kumar Halder <ayankuma@amd.com>
In-Reply-To: <c1290406-9ec4-97f7-efad-8279dec39123@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO2P123CA0089.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:138::22) To SN6PR12MB2621.namprd12.prod.outlook.com
 (2603:10b6:805:73::15)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH3PR12MB7620:EE_
X-MS-Office365-Filtering-Correlation-Id: 34ef5130-1d7f-459a-29f8-08dab8efd49b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WxPoxTejQeoE+WI1SB6DoyZ9ppKm4wKcEN3Z6/xXFBp3SMaoAWSHeNj2S8DSSAPJYt5vJzCYgac1xDUZuaUug1glzQxO1FnXzabseXUHAoaVz/HyzHWwCa6EMdBijFh9g38HSNibfr5V8/SFwmGTEoxqMGrw1uQSQJEnBsMyazS2TMSqdvbXCycuDVMd+lv7uSizKDhCwpj7EmjsS255umSIRQRwSAN2isRz0VIX2b0Z4Y9XIE0WbdUy3nBC6P+fuhI4uX3AzjnngYAmT76Vd8jO2bWYUawvMe2AkbDXCotaR6ymoRozb+fUSoknU2iJwdXitpTDRJqta6DGx4hREmkuqmNfT3NAyS7coJygqUGS/7B6zMMfM8/+cb7l6MD56J8YWIiVjkeWpXxYn/MLKbV1ZzUMgPXb+sL7i30sGpGO28hMgY0/U4+2wnu5CBilvUmlW03dBTVLKvhG5b4T9axe3JNNAR7wFiHDVWfC/G7Siqagg9aJCSm8YXGOb+Cc1hdG4k2jx/f5QRE4se5GpdRePRrty3nUEGQQtKniazGfJY897WfHx1lntltVQaRU+ZaVZ9d0oUx+oVy5yvRd0NoM4tOEloCWRfd1980v513fw60MBChFFUhLIWZPOxlQvsE1uluJpKcEoJS3gU/GUPZ1i2Xq/NzSAXgTeBDe6YyuH/ptIBxlvKOIDsD9uOhmYzVmhtLidQQpzvFB2hIg2Cwy1ib9OX/nBu88e3NdShjQ5a5JeT+SSQ5lQwD4i8PUcfI1OkPh5q4QsBV3oz2z1jcF6MIqg59N+B3rYUzDXsI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(451199015)(478600001)(8936002)(5660300002)(41300700001)(2906002)(6486002)(4326008)(8676002)(66476007)(66556008)(66946007)(316002)(83380400001)(38100700002)(6666004)(53546011)(6506007)(31696002)(6512007)(26005)(2616005)(186003)(31686004)(66899015)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ckk2VWQ2WFZMSG9DdjJhZS9aNjBzQm1tbURWazVvYWJQK29qc2tuSS9uUUor?=
 =?utf-8?B?RERPUlRNUlc0SVJEZjVZS1o5VGF5eEFPSitiU1c1UXI2MUFIQmRVYnRQNFB0?=
 =?utf-8?B?akpwOXNzQnlOazJaRno0QTVQQ0JUaVFxaUpjTm1pd2VUOVJJRTFsakJvb2xv?=
 =?utf-8?B?TElKdThEVlpoUDJzSWU2TXA5V3BMbWlQZFFFd1JXMTkxUnhZdEdrRTBKLzRq?=
 =?utf-8?B?RVJxTmR5NUNtUnd6Qlc0bGJLU1NCdkxINlo3dkJPb1JQcjY5V1pOWVdQQzU2?=
 =?utf-8?B?dGZ4eVd6bElqVnhlNDhvb1V2T1RzTTlXYkM3V01wdlNHTGlnNXBBZzE3SFI0?=
 =?utf-8?B?YW0xLzBsWUc4MTkwcDY0dnVUekxQRVllNkNhNFBkK1Fab3NmR2JWWmxwYzlj?=
 =?utf-8?B?THNJaVVNRk1DSHhuQkEvYU9HRDlMVzZQWGY2WE1VUFB2dFpZWUg5Ny9kdy9C?=
 =?utf-8?B?YWZQWmExd1BsQ0svd1hDTnljcUZhcHJpeHZUbEdRTnF3aFNtbFZSdlpKa2dy?=
 =?utf-8?B?UklYdjd4VmZiUWNQYXR6bm9tU2JhL1pubG83b0FvVVlQUmR1MkVzN1pOeGs2?=
 =?utf-8?B?MEk4YndhU2M3cGJQNTc2ZXlid0RCdlFCRXdhZnp0c0N3d0RFRHFTSkx6UG9D?=
 =?utf-8?B?MzY3dlE5V0hIU3V4VEVIMkJiK2JISjJheTZodkp0eGtmeHdrVnM4ZEZmM1BC?=
 =?utf-8?B?dksza0l3THpxQVBJNGJmQ3FKNDVwQ3FibHFRYU9qNmUwQW44MjFjM1lUaG5y?=
 =?utf-8?B?ZjFYL1BBTTRSa01xbldmTDlzSSttS0FQMS9FUkZkL3IzRk1ucjhET2ViTk5l?=
 =?utf-8?B?aUNzZFZjV0hBeUFpQzlVUEdycitQeXRVaVRwK1hvMVJwZmdzNnBOUU1JZ1p4?=
 =?utf-8?B?RytORGJsaENMUWJ0Vjl0dm5iQ1JRSUdJNUdQSDgreU01NlVWYTZxVE9DTUJr?=
 =?utf-8?B?MVgzdk9nYkplbGhhNWNxWnp0SXJGSmo0SVhnV2g3VzNWaWlUZFduSWlXWXBP?=
 =?utf-8?B?RWpYbnpmVkxpb0I0NFM2TVlzOE95bVFWa1N0bnArc01yNEFsZ2pzamQ4UzVu?=
 =?utf-8?B?UGIwdnZZTCtkLzlhUnFMWEFZOHdIcW8zWEttY0ZoYUt6RmMwdkkyajFzODA5?=
 =?utf-8?B?V2Nzd0VSc1VGN3JjNmYvRjhScnNyOSs3UXh3c2FKTkliWHRwNDRwNHlhT0pD?=
 =?utf-8?B?UXZuMW00Y2dUT2FSNzN6WDhFRzhqZVJyTmxrblR0Qmt6UGk0NFFqT0psb1Vz?=
 =?utf-8?B?bGVqOWk5eS8rdm5vMWVNVE81NU9Ocjk3SzM1VGhZeDhoWXBwTjhnRGZ2TFdl?=
 =?utf-8?B?T2VneFZKYnMrNlMyU25XMkZQRTgzWGRPTnRveGRSWEhuY3BuV2hMaWk3cHRw?=
 =?utf-8?B?Ykp0TUlEdEpnTFJZVG5OV0RjeVRhQXpsQWtVRHVqSnBIbHBQZlZQVHBpaVRx?=
 =?utf-8?B?RXJwTzcycmRHeWQzQWtaTCtPMWZPU2gxUjVId0wxamZLYzNsVlhFTVYzQVRL?=
 =?utf-8?B?TGp5Yk1ZOHR4aEsyN0QrWVh1NFJ3eVU3UVBhNk50OEhvaXlMQ2dJMmZRSkdk?=
 =?utf-8?B?aVkrSFA2dHRnQVF1d1VYOTI1NjllUUZGT3kzc2tibFpXSmlsUVBVbGhJeFVy?=
 =?utf-8?B?TkYvRzdHNllXd1NJVzc1YnBJSCtpYkpMb1BiWFNaVUdYYy9YTFRZRU9YQ3Bj?=
 =?utf-8?B?dmRCbnpnM3NvWk5XQStzVjBobXFpNUliNWdZdTFZQXcxRTBGV2RpUnVwckkv?=
 =?utf-8?B?VWhOcGV0dG9lU0MrQUkwZ2VXSjZWTFVUNjJCNW5nd1FtK3hUdHhPWnVtaG9z?=
 =?utf-8?B?ODFld0ZMWkxJL2orR2xidnlLTGlKTmJvR0VrMTFxcGZGL1pNMHExZmVOZ0RG?=
 =?utf-8?B?Rjh0Tmhxek1LZUt3WHQwTm16RTA1Sk96TXVCWERzVndkaUtrK1BjZFNGenBD?=
 =?utf-8?B?OFVPK3NmSnpjTEYrN1YxVXBsWS9wYzJCZDFBQkFwTU81bjE2b3Bjd0xNbThZ?=
 =?utf-8?B?ZEhONTVQUWJSODFuRk5iZzJVYTNhc0lWU2VtWEExTDRZT2Y4ZEUyYTB3VkVy?=
 =?utf-8?B?bSs0bGlnWlhKc3NPakRLMGJzc2lTSGIwb1l1SWovbHJmUE9IMW12bklhNDVs?=
 =?utf-8?Q?dtkMLJt5KiyFUK4SvLzOyOHj3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34ef5130-1d7f-459a-29f8-08dab8efd49b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:22:23.2635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PaEm8JvCBFZOcKYpVjEoAU3zeGvYGyuMImz4lNwfx8CxAJ5J4U2poRU89pRnY8om0f9ZqwiaF+IK6TQavEXXJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7620


On 22/10/2022 12:03, Julien Grall wrote:
> Hi Ayan,

Hi Julien,

I need a clarification.

>
> Title: Xen doesn't emulate ICH_LR* (we don't expose them to the 
> guest). Instead Xen will use the registers and your patch provides 
> wrappers to use access the registers on 32-bit host.
>
> On 21/10/2022 16:31, Ayan Kumar Halder wrote:
>> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h 
>> b/xen/arch/arm/include/asm/arm32/sysregs.h
>> index 6841d5de43..f3b4dfbca8 100644
>> --- a/xen/arch/arm/include/asm/arm32/sysregs.h
>> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h
>> @@ -62,9 +62,61 @@
>>   #define READ_SYSREG(R...)       READ_SYSREG32(R)
>>   #define WRITE_SYSREG(V, R...)   WRITE_SYSREG32(V, R)
>>   +#define ICH_LR_REG(INDEX)        ICH_LR ## INDEX ## _EL2
>> +#define ICH_LRC_REG(INDEX)       ICH_LRC ## INDEX ## _EL2
>> +
>> +#define READ_SYSREG_LR(INDEX)    ((((uint64_t) \
>> + (READ_SYSREG(ICH_LRC_REG(INDEX)))) << 32) | \
>> + (READ_SYSREG(ICH_LR_REG(INDEX))))
>
> This is a bit dense to read. Also, we should use READ_CP64() when 
> dealing with arm32 only code. So how about (formatting will need to be 
> done):
>
> #define READ_SYSREG_LR(INDEX) ({   \
>     uint32_t lrc_ = READ_CP64(ICH_LRC_REG(INDEX)); \
>     uint32_t lr_ = READ_CP64(ICH_LR_REG(INDEX));   \
>                                                    \

I think this looks incorrect. These are read using 'mrc' so they should 
be READ_CP32(). They are 32 bit registers.

However, READ_SYSREG is defined as READ_CP32(), so should we use 
READ_CP32() or READ_SYSREG() ?

- Ayan

> (uint64_t)(lrc_ << 32) | lr_;
> })
>
>> +
>> +#define WRITE_SYSREG_LR(INDEX, V) WRITE_SYSREG \
>> +                                  (V&0xFFFFFFFF, ICH_LR_REG(INDEX)); \
>> +                                  WRITE_SYSREG(V>>32, 
>> ICH_LRC_REG(INDEX));
> This code is fragile. If V is a function call, then you will call it 
> twice. You want something like:
>
> do {
>   uint64_t v_ = (V);
>
>   WRITE_SYSREG(v_ & 0xFFFFFFFF, ICH_LR_REG(INDEX));
>   WRITE_SYSREG(v_ >> 32, ICH_LRC_REG(INDEX));
> } while(0);
>
> And maybe replacing the opencoding Fs with GENMASK.
>
>> +
>>   /* MVFR2 is not defined on ARMv7 */
>>   #define MVFR2_MAYBE_UNDEFINED
>>   +#define ___CP32(a,b,c,d,e)   a,b,c,d,e
>
> I am not entirely sure why you need to define __CP32() here. However, 
> co-processors registers should be defined in asm/cpregs.h rather than 
> arm32/sysregs.h.
>
>> +#define __LR0_EL2(x) ___CP32(p15,4,c12,c12,x)
>> +#define __LR8_EL2(x)              ___CP32(p15,4,c12,c13,x)
>> +
>> +#define __LRC0_EL2(x)             ___CP32(p15,4,c12,c14,x)
>> +#define __LRC8_EL2(x)             ___CP32(p15,4,c12,c15,x)
>> +
>> +#define ICH_LR0_EL2               __LR0_EL2(0)
>> +#define ICH_LR1_EL2               __LR0_EL2(1)
>> +#define ICH_LR2_EL2               __LR0_EL2(2)
>> +#define ICH_LR3_EL2               __LR0_EL2(3)
>> +#define ICH_LR4_EL2               __LR0_EL2(4)
>> +#define ICH_LR5_EL2               __LR0_EL2(5)
>> +#define ICH_LR6_EL2               __LR0_EL2(6)
>> +#define ICH_LR7_EL2               __LR0_EL2(7)
>> +#define ICH_LR8_EL2               __LR8_EL2(0)
>> +#define ICH_LR9_EL2               __LR8_EL2(1)
>> +#define ICH_LR10_EL2              __LR8_EL2(2)
>> +#define ICH_LR11_EL2              __LR8_EL2(3)
>> +#define ICH_LR12_EL2              __LR8_EL2(4)
>> +#define ICH_LR13_EL2              __LR8_EL2(5)
>> +#define ICH_LR14_EL2              __LR8_EL2(6)
>> +#define ICH_LR15_EL2              __LR8_EL2(7)
>> +
>> +#define ICH_LRC0_EL2               __LRC0_EL2(0)
>> +#define ICH_LRC1_EL2               __LRC0_EL2(1)
>> +#define ICH_LRC2_EL2               __LRC0_EL2(2)
>> +#define ICH_LRC3_EL2               __LRC0_EL2(3)
>> +#define ICH_LRC4_EL2               __LRC0_EL2(4)
>> +#define ICH_LRC5_EL2               __LRC0_EL2(5)
>> +#define ICH_LRC6_EL2               __LRC0_EL2(6)
>> +#define ICH_LRC7_EL2               __LRC0_EL2(7)
>> +#define ICH_LRC8_EL2               __LRC8_EL2(0)
>> +#define ICH_LRC9_EL2               __LRC8_EL2(1)
>> +#define ICH_LRC10_EL2              __LRC8_EL2(2)
>> +#define ICH_LRC11_EL2              __LRC8_EL2(3)
>> +#define ICH_LRC12_EL2              __LRC8_EL2(4)
>> +#define ICH_LRC13_EL2              __LRC8_EL2(5)
>> +#define ICH_LRC14_EL2              __LRC8_EL2(6)
>> +#define ICH_LRC15_EL2              __LRC8_EL2(7)
>> +
>>   #endif /* __ASSEMBLY__ */
>>     #endif /* __ASM_ARM_ARM32_SYSREGS_H */
>> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h 
>> b/xen/arch/arm/include/asm/arm64/sysregs.h
>> index 54670084c3..d45fe815f9 100644
>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h
>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h
>> @@ -469,8 +469,11 @@
>>       asm volatile("mrs  %0, "__stringify(name) : "=r" (_r));         \
>>       _r; })
>>   -#define READ_SYSREG(name)     READ_SYSREG64(name)
>> -#define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name)
>> +#define READ_SYSREG(name)          READ_SYSREG64(name)
>> +#define WRITE_SYSREG(v, name)      WRITE_SYSREG64(v, name)
>
> Please don't re-indent existing macro. This is only introducing 
> unnecessary extra churn.
>
>> +#define ICH_LR_REG(index)          ICH_LR ## index ## _EL2
>> +#define WRITE_SYSREG_LR(index, v)  WRITE_SYSREG(v, ICH_LR_REG(index))
>> +#define READ_SYSREG_LR(index) READ_SYSREG(ICH_LR_REG(index))
>>     #endif /* _ASM_ARM_ARM64_SYSREGS_H */
>>   diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h 
>> b/xen/arch/arm/include/asm/gic_v3_defs.h
>> index 48a1bc401e..87115f8b25 100644
>> --- a/xen/arch/arm/include/asm/gic_v3_defs.h
>> +++ b/xen/arch/arm/include/asm/gic_v3_defs.h
>> @@ -185,9 +185,9 @@
>>   #define ICH_LR_HW_SHIFT              61
>>   #define ICH_LR_GRP_MASK              0x1
>>   #define ICH_LR_GRP_SHIFT             60
>> -#define ICH_LR_MAINTENANCE_IRQ       (1UL<<41)
>> -#define ICH_LR_GRP1                  (1UL<<60)
>> -#define ICH_LR_HW                    (1UL<<61)
>> +#define ICH_LR_MAINTENANCE_IRQ       (1ULL<<41)
>> +#define ICH_LR_GRP1                  (1ULL<<60)
>> +#define ICH_LR_HW                    (1ULL<<61)
>>     #define ICH_VTR_NRLRGS               0x3f
>>   #define ICH_VTR_PRIBITS_MASK         0x7
>
> Cheers,
>


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 14:24:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 14:24:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432110.684833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQHX-0003Sw-GE; Fri, 28 Oct 2022 14:24:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432110.684833; Fri, 28 Oct 2022 14:24:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQHX-0003Sn-DT; Fri, 28 Oct 2022 14:24:23 +0000
Received: by outflank-mailman (input) for mailman id 432110;
 Fri, 28 Oct 2022 14:24:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooQHW-0003Sh-A8
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 14:24:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooQHV-0004cI-Ua; Fri, 28 Oct 2022 14:24:21 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooQHV-0001RK-OU; Fri, 28 Oct 2022 14:24:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=n8mWUaMCrfal6nTlLq/FpOO6vnP15u88E+dsM++AM/o=; b=wGtiI39jPFQNUvGtppHRwSnBx8
	47amjH6NIJLHDEvD9txWCu57BKv98I7yXJ/gfjlo+CDmQg1qG3H73mt9IE1wACS+F2M2Bpu2iXGld
	9aDR7/MY1qecO0RkyJ4sstiNequfT8aJTcTfv5SA7zPbmxTOeHnrz24HnixFEZN5gn/E=;
Message-ID: <ef1f549a-d917-b7eb-d2e0-34cf8927f6db@xen.org>
Date: Fri, 28 Oct 2022 15:24:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [RFC PATCH v1 07/12] Arm: GICv3: Emulate ICH_LR<n>_EL2 on AArch32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com
References: <20221021153128.44226-1-ayankuma@amd.com>
 <20221021153128.44226-8-ayankuma@amd.com>
 <c1290406-9ec4-97f7-efad-8279dec39123@xen.org>
 <65168ade-6730-b90b-b927-86535b18bdcb@amd.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <65168ade-6730-b90b-b927-86535b18bdcb@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 28/10/2022 15:22, Ayan Kumar Halder wrote:
> 
> On 22/10/2022 12:03, Julien Grall wrote:
>> Hi Ayan,
> 
> Hi Julien,
> 
> I need a clarification.
> 
>>
>> Title: Xen doesn't emulate ICH_LR* (we don't expose them to the 
>> guest). Instead Xen will use the registers and your patch provides 
>> wrappers to use access the registers on 32-bit host.
>>
>> On 21/10/2022 16:31, Ayan Kumar Halder wrote:
>>> diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h 
>>> b/xen/arch/arm/include/asm/arm32/sysregs.h
>>> index 6841d5de43..f3b4dfbca8 100644
>>> --- a/xen/arch/arm/include/asm/arm32/sysregs.h
>>> +++ b/xen/arch/arm/include/asm/arm32/sysregs.h
>>> @@ -62,9 +62,61 @@
>>>   #define READ_SYSREG(R...)       READ_SYSREG32(R)
>>>   #define WRITE_SYSREG(V, R...)   WRITE_SYSREG32(V, R)
>>>   +#define ICH_LR_REG(INDEX)        ICH_LR ## INDEX ## _EL2
>>> +#define ICH_LRC_REG(INDEX)       ICH_LRC ## INDEX ## _EL2
>>> +
>>> +#define READ_SYSREG_LR(INDEX)    ((((uint64_t) \
>>> + (READ_SYSREG(ICH_LRC_REG(INDEX)))) << 32) | \
>>> + (READ_SYSREG(ICH_LR_REG(INDEX))))
>>
>> This is a bit dense to read. Also, we should use READ_CP64() when 
>> dealing with arm32 only code. So how about (formatting will need to be 
>> done):
>>
>> #define READ_SYSREG_LR(INDEX) ({   \
>>     uint32_t lrc_ = READ_CP64(ICH_LRC_REG(INDEX)); \
>>     uint32_t lr_ = READ_CP64(ICH_LR_REG(INDEX));   \
>>                                                    \
> 
> I think this looks incorrect. These are read using 'mrc' so they should 
> be READ_CP32(). They are 32 bit registers.

That's my mistake. We should use...

> 
> However, READ_SYSREG is defined as READ_CP32(), so should we use 
> READ_CP32() or READ_SYSREG() ?

READ_CP32() instead of READ_SYSREG() for arm32 specific code. The latter 
is only provided to avoid #ifdef in the common code.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 14:38:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 14:38:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432116.684845 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQV1-0005br-P0; Fri, 28 Oct 2022 14:38:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432116.684845; Fri, 28 Oct 2022 14:38:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQV1-0005bk-LI; Fri, 28 Oct 2022 14:38:19 +0000
Received: by outflank-mailman (input) for mailman id 432116;
 Fri, 28 Oct 2022 14:38:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pqEQ=25=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ooQV0-0005be-Dy
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 14:38:18 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20053.outbound.protection.outlook.com [40.107.2.53])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 290ff155-56ce-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 16:38:17 +0200 (CEST)
Received: from AM6PR0202CA0072.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::49) by PAXPR08MB6591.eurprd08.prod.outlook.com
 (2603:10a6:102:150::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 14:38:05 +0000
Received: from AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:3a:cafe::d7) by AM6PR0202CA0072.outlook.office365.com
 (2603:10a6:20b:3a::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 14:38:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT053.mail.protection.outlook.com (100.127.140.202) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5746.16 via Frontend Transport; Fri, 28 Oct 2022 14:38:04 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Fri, 28 Oct 2022 14:38:04 +0000
Received: from f7e18d3e27e8.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1DC1F49C-55E7-4020-9B50-B5377C1AB14F.1; 
 Fri, 28 Oct 2022 14:37:34 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7e18d3e27e8.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 14:37:34 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by PAXPR08MB6445.eurprd08.prod.outlook.com (2603:10a6:102:159::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 14:37:27 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.014; Fri, 28 Oct 2022
 14:37:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 290ff155-56ce-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=KjfBU9iAHsrpl3NmGUlYNF0xABg8G/jDOXuIWCpBjn/oMdbUXm/egz63yYg1xrYcLAVORCjS78ySn+A4vfA91CK9KTe57Hy77oIodR3stz4f1hVZqciHWCQQlHGmm9jurEeZGnmmxbW+pB8Mp70XiyX808yBQ13jB9CksAMFcclDkxE7V8sdPMcPJKKhX8TBhmykJoITU50YvtZwFGvh1WdGkJ2TI669JHHtM/bxxwo1VK8RXqDN7mK7fz/4ua24E374i1x365cCJi6gaMnQZvSaT6BP5IkBVFRroDL9q0bpIaan+JIxwsLu5fYOVTNB5ttyQoNCbQIA8FEHgvteyQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YWfkTYsuJ5wbGQNDnH4LWt7X0jxKxnQ63RSEO4E52ng=;
 b=ajcps4fbtJIMZXsQtlwc7k70oL7nvvVNAvJqG5I8zWIcDl5SCO+kRD/llPIWe0/CqkCSilcvHVAhcY4gZbjE0ZPk5P8opd6wNdQ2AifCFyISD29lVBahNXciUAvnMemEa8mK3TBJQrlUMLTepFw9xIap7pM6KUmyVkwgieMJAElHt5v91cNLO1s31AXPDtIcASnh8k8rYrOlPlTSXuVc+qvZCxR4Rc40wzK20OGZjzDqMiP0x9cz4S4y5TC97KoxLlhNiOzl9/0/euH37VkFmskCxz4bSdRbLVDqE0vSL/fg78YltPnbuY2YThhi+negqYA5sUfIEoH0Llgx+qlBoA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YWfkTYsuJ5wbGQNDnH4LWt7X0jxKxnQ63RSEO4E52ng=;
 b=39AKnM25HzspWrz3zpgo/hhxvJHaDyTzREvGthTsJmvrXniv7g7WzK6o7YL5619Ub6kmGdjMdtwwcCt6mthtWos9M8XhLrU3E5fAUXZrTcx38wb2z7uoDoSRLfJpZHWxOHR+eNBXNu4WdZMt5f7w9/sasb3CgJAiaz2k40aPgsg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S7nKfWeFZOeG9ROq19MS8yH1vRG5N6riAn7zCNvjjSEiVYyMzDjykmTGJcxJkyPYkDlD7NVfDAaL2exo1FQS3di1XNJE9HIxqAKrTsJY0nG6VlpMYGIK6U9zHABgGXz2EbP4J927Mn2Y8IwWyWkeQmaIeMoubTV9aJyVUo5MBipYMzlKKo0VwibYPLcAI9WVAb1sXB1464Vq13oGHOFXAPNNcTGgWYD+NtlBUFRlnAr3ewJZnfLpq92zPIu5nULpaHAyCbf7kSOV0hiRi30nXr39gtu6oC+K+q5K4EW4Y+n3FEncnkrnQEwKxbBiXlT74iuco/C/0F7SgIKAZbtaMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YWfkTYsuJ5wbGQNDnH4LWt7X0jxKxnQ63RSEO4E52ng=;
 b=AO8YaQu4TqL4LwLLfNvw8TZnJw/XwZMiVxKu/r642kWwxFioMLigHS23In2ssLJ6YrlKPmvHD7ciSD9TuHDlmkE7kerJ0UgSLihDSRggTkhnpIkA4S7xkkBFcsgIlUbUAdFM1B6ESPMiK0Q0QeSR/Wkx6chcoAbev4eI7RYWhQEy8WOzzV90nadStLVxDDXXAu4zI70agO/RUyhJHOdGpfD146uiTUDUjVqpkPHVtUJF3wkP0lPta541dTg7UuneE72nEdJKpVNe0q8kbqRe+USbc5VrhNr/lP8gcozQKqCYx5GHqfzp/0qc7+Zw10N0EJxqoO7UlCQ3O1SLBkifhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YWfkTYsuJ5wbGQNDnH4LWt7X0jxKxnQ63RSEO4E52ng=;
 b=39AKnM25HzspWrz3zpgo/hhxvJHaDyTzREvGthTsJmvrXniv7g7WzK6o7YL5619Ub6kmGdjMdtwwcCt6mthtWos9M8XhLrU3E5fAUXZrTcx38wb2z7uoDoSRLfJpZHWxOHR+eNBXNu4WdZMt5f7w9/sasb3CgJAiaz2k40aPgsg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index:
 AQHY6T1V+gcJbmRqpEyt0b8GeG9bFq4grXIAgAAQCACAAFf9AIABVMyAgAAG64CAAVVJgIAAAzuAgAACBwCAAAPNgIAAE5mA
Date: Fri, 28 Oct 2022 14:37:27 +0000
Message-ID: <2981F6DC-444B-49DE-9D01-C0093A32E68F@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
 <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
In-Reply-To: <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|PAXPR08MB6445:EE_|AM7EUR03FT053:EE_|PAXPR08MB6591:EE_
X-MS-Office365-Filtering-Correlation-Id: 6cb862eb-bea1-4353-5586-08dab8f205fd
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 sUp51CVjW9ZVTYroOdBj3DeAIoc/cNRc70V3wH3wvc1X3V//MzxhdfL0RDUF6mGqIciCXfDgLrl2nGnYOkNWeORHwC8qvdJrGF/UpQMsZEzdf6a/3N6wCUFseKNB3NY456BvrbP6BKKi20hUZbeqzK2h1hUESDoK2v+fU1PaGf2bS1Vchim3h/YMLO1A4+GZXVfAAXzz113RYfWnjOOorv5WI3Bw7JRhiJcGS8Fmju5nRsPtVWY6A0wsVbseWVn4EjOhtTRV0MvIVuNBGrtSopkRsmQzMMTSfJro1HnaJadQpO+X4uPuikgAzFG2u9+G4MJHooz044KiUzbKqEjeotlGUxPOwYrt71Q5lkY3Tlz6k5KCj8mlTA9Ph23GcfWbTNRXnaDGRIAv9gFO7QlF1Vx9Uuz9Ilh2FdKfWDlnWLV+QIs7GGbqjTp7XcA7ObVrf1dRxh1n4XJgmsQ1kAAefBPIR5pOoyoXJXU7GfNZ47EncmTQ7DdCNFX7pyEC7kTwAzNMw3OivJQAsn5zNwK/mIbOj8NcuBclVHth9tBngYT+1MnCyKg4Jo9xuJlIl+RNAiBqlEtRs49G2pmJBsaadKgq5HcfKbI7LAoMRrqqGldKL5aqbe2r05hnbPtPeRSoJLCVONBZR0hBb3x6cLmlA+kxDRbtZCeyF0rqIevfjCc2kdITEemHTDM3pYIdnrh2kOsI0m7gqncx2zJZ6nHjH3H5mMsM3+KplfuhQiZogoQNu729qglZCW1DuU/WX1KL4KVSdq7YyO6YKp/ukJ21WF1U50IWJHSXwbDxYFd0t+c=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(136003)(346002)(366004)(39850400004)(451199015)(186003)(478600001)(83380400001)(86362001)(2906002)(41300700001)(2616005)(38100700002)(38070700005)(76116006)(5660300002)(7416002)(8936002)(122000001)(6486002)(6506007)(6512007)(71200400001)(6916009)(66946007)(53546011)(26005)(54906003)(4326008)(66476007)(66556008)(64756008)(91956017)(66446008)(316002)(8676002)(36756003)(33656002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <CFD8CE7886E567428ADAE476329CFC5A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6445
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ea4523f5-a750-4978-c1c0-08dab8f1efd5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wNq30guCbiQVZMkDpBrWy8x6FybdBsMwT+Z8LJZVdWzi6q/SX9PSpwNuLkZ+mEoxAPBEtezTM87d7urFubcWTBiZTHDya31hWAS0VsPguv9DWopuAge6GDtThjTOsZcOvTKL5PmCVjOy4YOpvWXw2mn5rLtbT0AAoTVzqqw9xNYTJ2j22gzWtCaynkeKs/cIa58GaENkNvbouQp3mENkkVoq3r56JEvoSeVaFAr/XfOWdP8KLQ+CHiETxe0VyBvjnHGGLsAkRPQUvtJrVChIRc7eIuhyP1PPjb80SIF9qtVGC6FJ2yiSVdF2u5aS1LN7Gq//mG10/kdYeXSx8Dr2Zow6EHVXWjTZX/YtN8CthaYA0PhwODy09SwEh2SHFwOh8qOq0mbuz00DXyD/DtkJCgOc/UuDimtKy/LqhEN/hsGJ83YM9CAdUEuxevrNmqZc0Wc7erWpXLu+MhvMVgW2BCU3KkQipZIEj+NIXz9pqV7acf7VYYAqgn/9baFUzTizTPjgV1rvHxEr1cILGjr6S+b0RCUVNj4LeVScIKnkQm6VBFMSDDhuNFSJg27iqiVhHqQkMrk8tFyFcUbQ+HLznB0wLpMBl/eFMsCebJgOOkvd+/7BHFFIfT10HCUOHCr6IV/9rb2FAKMlMcoYaIUrDa/MqPAWYw8uYPBm93YWszH5AZOMa2LXvlcrpvnIZalyj+um6TjZB7Zlzj3ndakTgIbToT347kLr5Sbh/689TO1+HCwtXVigrPXKE0kAZdCry8Nff6WVdFVeXZs+eYqPxw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(39850400004)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(81166007)(54906003)(356005)(478600001)(83380400001)(8936002)(8676002)(4326008)(70586007)(36756003)(41300700001)(2906002)(70206006)(40480700001)(6486002)(33656002)(6862004)(336012)(6512007)(186003)(40460700003)(47076005)(2616005)(5660300002)(36860700001)(107886003)(86362001)(53546011)(82740400003)(316002)(6506007)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 14:38:04.7650
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb862eb-bea1-4353-5586-08dab8f205fd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6591

SGkgSnVsaWVuLA0KDQo+IE9uIDI4IE9jdCAyMDIyLCBhdCAxNDoyNywgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9uIDI4LzEwLzIwMjIgMTQ6MTMs
IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBCZXJ0cmFu
ZCwNCj4gDQo+Pj4gT24gMjggT2N0IDIwMjIsIGF0IDE0OjA2LCBKdWxpZW4gR3JhbGwgPGp1bGll
bkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+PiBIaSBSYWh1bCwNCj4+PiANCj4+PiBPbiAyOC8x
MC8yMDIyIDEzOjU0LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+Pj4+Pj4+PiBGb3IgQUNQSSwgSSB3
b3VsZCBoYXZlIGV4cGVjdGVkIHRoZSBpbmZvcm1hdGlvbiB0byBiZSBmb3VuZCBpbiB0aGUgSU9S
RVEuDQo+Pj4+Pj4+Pj4gDQo+Pj4+Pj4+Pj4gU28gY2FuIHlvdSBhZGQgbW9yZSBjb250ZXh0IHdo
eSB0aGlzIGlzIG5lY2Vzc2FyeSBmb3IgZXZlcnlvbmU/DQo+Pj4+Pj4+PiBXZSBoYXZlIGluZm9y
bWF0aW9uIGZvciBJT01NVSBhbmQgTWFzdGVyLUlEIGJ1dCB3ZSBkb27igJl0IGhhdmUgaW5mb3Jt
YXRpb24gZm9yIGxpbmtpbmcgdk1hc3Rlci1JRCB0byBwTWFzdGVyLUlELg0KPj4+Pj4+PiANCj4+
Pj4+Pj4gSSBhbSBjb25mdXNlZC4gQmVsb3csIHlvdSBhcmUgbWFraW5nIHRoZSB2aXJ0dWFsIG1h
c3RlciBJRCBvcHRpb25hbC4gU28gc2hvdWxkbid0IHRoaXMgYmUgbWFuZGF0b3J5IGlmIHlvdSBy
ZWFsbHkgbmVlZCB0aGUgbWFwcGluZyB3aXRoIHRoZSB2aXJ0dWFsIElEPw0KPj4+Pj4+IHZNYXN0
ZXJJRCBpcyBvcHRpb25hbCBpZiB1c2VyIGtub3dzIHBNYXN0ZXJJRCBpcyB1bmlxdWUgb24gdGhl
IHN5c3RlbS4gQnV0IGlmIHBNYXN0ZXJJZCBpcyBub3QgdW5pcXVlIHRoZW4gdXNlciBuZWVkcyB0
byBwcm92aWRlIHRoZSB2TWFzdGVySUQuDQo+Pj4+PiANCj4+Pj4+IFNvIHRoZSBleHBlY3RhdGlv
biBpcyB0aGUgdXNlciB3aWxsIGJlIGFibGUgdG8ga25vdyB0aGF0IHRoZSBwTWFzdGVySUQgaXMg
dW5pcS4gVGhpcyBtYXkgYmUgZWFzeSB3aXRoIGEgY291cGxlIG9mIFNNTVVzLCBidXQgaWYgeW91
IGhhdmUgNTArIChhcyBzdWdnZXN0ZWQgYWJvdmUpLiBUaGlzIHdpbGwgYmVjb21lIGEgcGFpbiBv
biBsYXJnZXIgc3lzdGVtLg0KPj4+Pj4gDQo+Pj4+PiBJSE1PLCBpdCB3b3VsZCBiZSBtdWNoIGJl
dHRlciBpZiB3ZSBjYW4gZGV0ZWN0IHRoYXQgaW4gbGlieGwgKHNlZSBiZWxvdykuDQo+Pj4+IFdl
IGNhbiBtYWtlIHRoZSB2TWFzdGVySUQgY29tcHVsc29yeSB0byBhdm9pZCBjb21wbGV4aXR5IGlu
IGxpYnhsIHRvIHNvbHZlIHRoaXMNCj4+PiANCj4+PiBJbiBnZW5lcmFsLCBjb21wbGV4aXR5IGlu
IGxpYnhsIGlzIG5vdCB0b28gbXVjaCBvZiBwcm9ibGVtLg0KPj4gSSBhbSBhIGJpdCB1bnN1cmUg
YWJvdXQgdGhpcyBzdHJhdGVneS4NCj4+IEN1cnJlbnRseSB4bCBoYXMgb25lIGNvbmZpZ3VyYXRp
b24gZmlsZSB3aGVyZSB5b3UgcHV0IGFsbCBYZW4gcGFyYW1ldGVycy4gVGhlIGRldmljZSB0cmVl
IGlzIG9ubHkgbmVlZGVkIGJ5IHNvbWUgZ3Vlc3RzIHRvIGhhdmUgYSBkZXNjcmlwdGlvbiBvZiB0
aGUgc3lzdGVtIHRoZXkgcnVuIG9uLg0KPj4gSWYgd2UgY2hhbmdlIHRoZSBtb2RlbCBhbmQgc2F5
IHRoYXQgWGVuIGNvbmZpZ3VyYXRpb24gcGFyYW1ldGVycyBhcmUgYm90aCBpbiB0aGUgY29uZmln
dXJhdGlvbiBhbmQgdGhlIGRldmljZSB0cmVlLCB3ZSBzb21laG93IGVuZm9yY2UgdG8gaGF2ZSBh
IGRldmljZSB0cmVlIGV2ZW4gdGhvdWdoIHNvbWUgZ3Vlc3RzIGRvIG5vdCBuZWVkIGl0IGF0IGFs
bCAoZm9yIGV4YW1wbGUgWmVwaHlyKS4NCj4gDQo+IEkgdGhpbmsgbXkgYXBwcm9hY2ggd2FzIG1p
c3VuZGVyc3Rvb2QgYmVjYXVzZSB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gdGhlIGV4aXN0aW5nIG1v
ZGVsLg0KPiANCj4gV2hhdCBJIGFtIHN1Z2dlc3RpbmcgaXMgdG8gbm90IGludHJvZHVjZSBpb21t
dV9kZXZpZF9tYXAgYnV0IGluc3RlYWQgbGV0IGxpYnhsIGFsbG9jYXRlIHRoZSB2aXJ0dWFsIE1h
c3Rlci1JRCBhbmQgY3JlYXRlIHRoZSBtYXBwaW5nIHdpdGggdGhlIHBoeXNpY2FsIE1hc3Rlci1J
RC4NCj4gDQo+IExpYnhsIHdvdWxkIHRoZW4gdXBkYXRlIHRoZSBwcm9wZXJ0eSAiaW9tbXVzIiBp
biB0aGUgZGV2aWNlLXRyZWUgd2l0aCB0aGUgYWxsb2NhdGVkIHZpcnR1YWwgTWFzdGVyLUlELg0K
DQpPayBJIHVuZGVyc3RhbmQgbm93Lg0KDQo+IA0KPiBFYWNoIG5vZGUgaW4gdGhlIHBhcnRpYWwg
ZGV2aWNlLXRyZWUgd291bGQgbmVlZCB0byBoYXZlIGEgcHJvcGVydHkNCj4gdG8gcmVmZXIgdG8g
dGhlIHBoeXNpY2FsIGRldmljZSBqdXN0IHNvIHdlIGtub3cgaG93IHRvIHVwZGF0ZSB0aGUgImlv
bW11cyIuIFRoZSBsaXN0IG9mIGRldmljZSBwYXNzdGhyb3VnaCB3aWxsIHN0aWxsIGJlIHNwZWNp
ZmllZCBpbiB0aGUgY29uZmlndXJhdGlvbiBmaWxlLiBJT1csIHRoZSBwYXJ0aWFsIGRldmljZS10
cmVlIGlzIG5vdCBkaXJlY3RseSBpbnZvbHZlZCBpbiB0aGUgY29uZmlndXJhdGlvbiBvZiB0aGUg
Z3Vlc3QuDQoNCkJ1dCB3ZSB3aWxsIGdlbmVyYXRlIGl0LiBIb3cgd291bGQgc29tZXRoaW5nIGxp
a2UgWmVwaHlyIGd1ZXN0IHdvcmsgPyBaZXBoeXIgaXMgbm90IHVzaW5nIHRoZSBkZXZpY2UgdHJl
ZSB3ZSBwYXNzLCBpdCBoYXMgYW4gZW1iZWRkZWQgb25lLg0KDQo+IA0KPiBTbyBmYXIsIEkgZG9u
J3Qgc2VlIGEgcGFydGljdWxhciBpc3N1ZSB3aXRoIHRoaXMgYXBwcm9hY2ggYmVjYXVzZSB0aGUg
dk1hc3RlciBJRCBhbGdvcml0aG0gYWxsb2NhdGlvbiBzaG91bGQgYmUgZ2VuZXJpYy4gQnV0IHBs
ZWFzZSBsZXQgbWUga25vdyBpZiB5b3UgdGhpbmsgdGhlcmUgYXJlIGJpdHMgSSBhbSBtaXNzaW5n
Lg0KDQpJIGFtIGEgYml0IGFmcmFpZCBvZiB0aGluZ3MgdGhhdCBhcmUg4oCcYXV0b21hdGlj4oCd
Lg0KDQpGb3IgZXZlcnl0aGluZyBlbHNlIHdlIGxldCB0aGUgdXNlciBpbiBjb250cm9sIChJUEEg
Zm9yIG1hcHBpbmcsIHZpcnR1YWwgaW50ZXJydXB0IG51bWJlcikgYW5kIGluIHRoaXMgY2FzZSB3
ZSBzd2l0Y2ggdG8gYSBtb2RlbCB3aGVyZSB3ZSBhdXRvbWF0aWNhbGx5IGdlbmVyYXRlZCBhIHZN
YXN0ZXIgSUQuDQpXaXRoIHRoaXMgbW9kZWwsIGd1ZXN0IG5vdCB1c2luZyB0aGUgZGV2aWNlIHRy
ZWUgd2lsbCBoYXZlIHRvIGd1ZXNzIHRoZSB2TWFzdGVyIElEIG9yIHNvbWVob3cga25vdyBob3cg
dGhlIHRvb2xzIGFyZSBnZW5lcmF0aW5nIGl0IHRvIHVzZSB0aGUgcmlnaHQgb25lLg0KDQpDaGVl
cnMNCkJlcnRyYW5kDQoNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFs
bA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 14:39:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 14:39:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432119.684855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQW9-00068U-1V; Fri, 28 Oct 2022 14:39:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432119.684855; Fri, 28 Oct 2022 14:39:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQW8-00068N-V8; Fri, 28 Oct 2022 14:39:28 +0000
Received: by outflank-mailman (input) for mailman id 432119;
 Fri, 28 Oct 2022 14:39:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooQW7-00068H-VC
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 14:39:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooQW4-0004qz-QN; Fri, 28 Oct 2022 14:39:24 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooQW4-000258-KE; Fri, 28 Oct 2022 14:39:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Hdg5PraNstj6e9uRbatxRM3GxleF6RF6zlyTJAgec0M=; b=mMFq3B0U2WTCrNU9CpA9Vjawe7
	8FOhNhI6w4zUfxptPxFg/aYd0EqyhOwTtX7ilLeNYLxAspuLtWkj9wOX7mYzi2MobUKdnjJhT5Z3N
	M5uXtCSlexyystB84GalCOVG6ky+BvFF4/bjm1HGB1NgjjckXdAqH7sxK8JYdX76Np/M=;
Message-ID: <da8190ba-74b2-8eb2-b859-6b3b845896f0@xen.org>
Date: Fri, 28 Oct 2022 15:39:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: GICv3: Aarch32: Need guidance on the atomic access of "union
 host_lpi" or if ITS is supported on R52
Content-Language: en-US
To: Andre Przywara <andre.przywara@arm.com>,
 Ayan Kumar Halder <ayankuma@amd.com>
Cc: "stefanos@xilinx.com" <stefanos@xilinx.com>,
 bertrand Marquis <Bertrand.Marquis@arm.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <bedc03b9-e6b9-c85b-27d6-33860ba7bdd7@amd.com>
 <20221025145506.5708839c@donnerap.cambridge.arm.com>
 <7f1bdc88-da6b-9a0c-03d4-319e9d8966d4@amd.com>
 <20221027153632.0cf7d004@donnerap.cambridge.arm.com>
 <5afda99e-dd57-5820-7075-6b60e7a794f7@amd.com>
 <20221028134947.6cc0b985@donnerap.cambridge.arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20221028134947.6cc0b985@donnerap.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 28/10/2022 13:49, Andre Przywara wrote:
> On Fri, 28 Oct 2022 12:44:08 +0100
> Ayan Kumar Halder <ayankuma@amd.com> wrote:
> 
>> On 27/10/2022 15:36, Andre Przywara wrote:
>>> On Thu, 27 Oct 2022 14:38:52 +0100
>>> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>>
>>> Hi Ayan,
>> Hi Andre / Julien,
>>>   
>>>> On 25/10/2022 14:55, Andre Przywara wrote:
>>>>> On Tue, 25 Oct 2022 13:25:52 +0100
>>>>> Ayan Kumar Halder <ayankuma@amd.com> wrote:
>>>>>
>>>>> Hi,
>>>> Hi Andre,
>>>>
>>>> Many thanks for the explanation.
>>>>
>>>> I need a clarification on the issue of atomic access to 64bit normal
>>>> memory on R52.
>>>>   
>>>>>      
>>>>>> Hi Andre/All,
>>>>>>
>>>>>> This came up while porting Xen on R52.
>>>>>>
>>>>>> Refer "ARM DDI 0568A.cID110520", B1.3.1
>>>>>>
>>>>>> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE
>>>>>> must not implement LPI support. "
>>>>>>
>>>>>> Does this mean ITS is not supported on R52 ? I am assuming yes, please
>>>>>> correct me if mistaken.
>>>>> An ITS relies on LPIs, so yes: no ITS on a v8-R32 system. I cannot find
>>>>> this restriction anymore in the v8-R64 supplement, so it would only apply
>>>>> to the R52/AArch32.
>>>>>      
>>>>>> If the answer is no, then my next query is follows :-
>>>>> Answering to that anyway ...
>>>>>      
>>>>>> diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
>>>>>> index 9ca74bc321..dea60aac0d 100644
>>>>>> --- a/xen/arch/arm/gic-v3-lpi.c
>>>>>> +++ b/xen/arch/arm/gic-v3-lpi.c
>>>>>> @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
>>>>>>          int rc;
>>>>>>
>>>>>>          /* We rely on the data structure being atomically accessible. */
>>>>>> -    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long));
>>>>>> +    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint64_t));
>>>>>>
>>>>>> "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.
>>>>>>
>>>>>> Is it fine to change it as above ?
>>>>>>
>>>>>> Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy
>>>>>> atomicity".
>>>>>>
>>>>>> "LDRD and STRD accesses to 64-bit aligned locations are 64-bit
>>>>>> single-copy atomic as seen by translation table walks and accesses to
>>>>>> translation tables"
>>>>> This (and the explaining paragraph) indeed suggests that this should
>>>>> work architecturally, if you use normal system memory (where you would
>>>>> hold page tables). It would be confined to ARMv8 AArch32 and ARMv7 w/
>>>>> LPAE, which matches Xen's requirements.
>>>> Does it mean that ldrd/strd will not work atomically on AArch32-v8R as
>>>> it uses MPU (not MMU, so no page tables) ?
>>> No, this mentioning of page tables is more an example or a rationale, than
>>> a requirement.
>>> What this means (in the ARMv7-A/ARMv8-A AArch32 context) it:
>>> Because on v7A-LPAE and v8-AArch32 PTEs are 64 bits wide, it's too painful
>>> to use explicit locking to make sure just writing one PTE is atomic. So
>>> the architecture demands that 64-bit aligned accesses using ldrd/strd
>>> are single-copy atomic, so software can update just one PTE easily. But
>>> this is only required for locations where page tables typically reside, so
>>> system memory. This avoids this 64-bit atomicity requirement for *every*
>>> part of the system, for instance separate buses, SRAM or flash on smaller
>>> buses, or MMIO in general.
>>>
>>> I don't find anything in the v8-R32 supplement that would step back from
>>> this requirement, although indeed the original reason (atomic PTE writes)
>>> would not apply to v8-R32. Both the LDRD/STRD description and the section
>>> listing differences in the system memory architecture do not mention
>>> anything, so I'd say that the ldrd atomicity requirement still holds.
>>>
>>> Please note that this only applies to ARMv7 *LPAE* systems, but Xen
>>> requires LPAE, and R52 is v8, so we are good, and the Xen code can rely on
>>> this.
>>>
>>> So for Xen on ARMv8-R32:
>>> *LDRD/STRD* accesses to *64-bit aligned* addresses in *RAM* would be
>>> atomic. You need to satisfy all three requirements:
>>> - You must use ldrd/strd. Just dereferencing a uint64_t pointer in C does
>>> not guarantee that, but read_atomic()/write_atomic() does.
>>> - It must be 64-bit aligned. Shouldn't be a problem if the data type is
>>> 64 bits wide. Please note the slight nastiness that ldrd would silently
>>> work on non-aligned addresses, but would lose the atomicity guarantee.
>>> ldrexd would always fault if the address is not aligned.
>>> We might want to check the alignment of data we access (assert?), if not
>>> done already.

For Arm32, we have configured the processor to enforce the alignment for 
all store/load. So I believe, it means a ldrd/strd on an unaligned 
address would crash at least on arm32.

We should ensure this will also be the case for R52 (assuming that 
strd/ldrd are considered atomic).

>>> - It must be in system RAM, so not MMIO. Also I think TCM might be a
>>> different story, but I would hope Xen would not use that directly.
>>>   
>> Many thanks for the nice explanation.
>>
>> I am trying to compare this with the atomicity requirement for AArch64
>> (ARM DDI 0487G.b ID072021, B2.2.1 Requirements for single-copy atomicit )
>>
>> I seethat the alignment requirement is the same as for ARMv8-R32.
>>
>> "-A read that is generated by a load instruction that loads a single
>> general-purpose register and is aligned to the size of the read in the
>> instruction is single-copy atomic.
>>
>> -A write that is generated by a store instruction that stores a single
>> general-purpose register and is aligned to the size of the write in the
>> instruction is single-copy atomic"
>>
>> I think the following code change should help us to confirm the correct
>> behavior of atomic read/write on both AArch64 and AArch32 (including R52).
>>
>> diff --git a/xen/arch/arm/include/asm/atomic.h
>> b/xen/arch/arm/include/asm/atomic.h
>> index ac2798d095..f22c65a853 100644
>> --- a/xen/arch/arm/include/asm/atomic.h
>> +++ b/xen/arch/arm/include/asm/atomic.h
>> @@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const
>> volatile void *p,
>>                                               void *res,
>>                                               unsigned int size)
>>    {
>> +    ASSERT(IS_ALIGNED((unsigned long)p, size));

Please use vaddr_t instead of "unsigned long".

>>        switch ( size )
>>        {
>>        case 1:
>> @@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile
>> void *p,
>>                                                void *val,
>>                                                unsigned int size)
>>    {
>> +    ASSERT(IS_ALIGNED((unsigned long)p, size));
>>        switch ( size )
>>        {
>>        case 1:
>>
>> Please let me know if I misunderstand something.
> 
> Yes, that looks correct. Even the more "simple" atomic accesses always
> require alignment, so if you do an unaligned 32-bit read in AArch64, it
> wouldn't be single-copy atomic either.

This patch looks fine as a way to enforce the address is always aligned. 
And that would be a nice improvement for arm64. On arm32 it should not 
matter (see above why).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 15:01:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 15:01:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432128.684867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQrB-0001Z3-Th; Fri, 28 Oct 2022 15:01:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432128.684867; Fri, 28 Oct 2022 15:01:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooQrB-0001Yw-Ql; Fri, 28 Oct 2022 15:01:13 +0000
Received: by outflank-mailman (input) for mailman id 432128;
 Fri, 28 Oct 2022 15:01:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooQrA-0001Yq-DM
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 15:01:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooQr9-0005Df-O8; Fri, 28 Oct 2022 15:01:11 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooQr9-00038I-F7; Fri, 28 Oct 2022 15:01:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=qSbtmEmc5nChW8eJHwZXZt6FJsJmhdkALKXw+AkCq5M=; b=zo0NufyNn+inrn2/DMxHAaydnC
	ZJlBKQg/Td95/3MiULZznQV8HLaFtfVq6BwP59FtkuwTRBfleXuZd3g/26p/GCEbV1xl7gAxS+1FB
	5wJxDvc9vfc5kId3QE3ixoLE7CMXCaYwO+Sz+OHEDr0BKgAp3DhJAchcYHafd9eHzebE=;
Message-ID: <affc51c9-0f8b-b76a-6f23-ec161c967580@xen.org>
Date: Fri, 28 Oct 2022 16:01:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
 <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
 <2981F6DC-444B-49DE-9D01-C0093A32E68F@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2981F6DC-444B-49DE-9D01-C0093A32E68F@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 28/10/2022 15:37, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

>> On 28 Oct 2022, at 14:27, Julien Grall <julien@xen.org> wrote:
>>
>>
>>
>> On 28/10/2022 14:13, Bertrand Marquis wrote:
>>> Hi Julien,
>>
>> Hi Bertrand,
>>
>>>> On 28 Oct 2022, at 14:06, Julien Grall <julien@xen.org> wrote:
>>>>
>>>> Hi Rahul,
>>>>
>>>> On 28/10/2022 13:54, Rahul Singh wrote:
>>>>>>>>>> For ACPI, I would have expected the information to be found in the IOREQ.
>>>>>>>>>>
>>>>>>>>>> So can you add more context why this is necessary for everyone?
>>>>>>>>> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
>>>>>>>>
>>>>>>>> I am confused. Below, you are making the virtual master ID optional. So shouldn't this be mandatory if you really need the mapping with the virtual ID?
>>>>>>> vMasterID is optional if user knows pMasterID is unique on the system. But if pMasterId is not unique then user needs to provide the vMasterID.
>>>>>>
>>>>>> So the expectation is the user will be able to know that the pMasterID is uniq. This may be easy with a couple of SMMUs, but if you have 50+ (as suggested above). This will become a pain on larger system.
>>>>>>
>>>>>> IHMO, it would be much better if we can detect that in libxl (see below).
>>>>> We can make the vMasterID compulsory to avoid complexity in libxl to solve this
>>>>
>>>> In general, complexity in libxl is not too much of problem.
>>> I am a bit unsure about this strategy.
>>> Currently xl has one configuration file where you put all Xen parameters. The device tree is only needed by some guests to have a description of the system they run on.
>>> If we change the model and say that Xen configuration parameters are both in the configuration and the device tree, we somehow enforce to have a device tree even though some guests do not need it at all (for example Zephyr).
>>
>> I think my approach was misunderstood because there is no change in the existing model.
>>
>> What I am suggesting is to not introduce iommu_devid_map but instead let libxl allocate the virtual Master-ID and create the mapping with the physical Master-ID.
>>
>> Libxl would then update the property "iommus" in the device-tree with the allocated virtual Master-ID.
> 
> Ok I understand now.
> 
>>
>> Each node in the partial device-tree would need to have a property
>> to refer to the physical device just so we know how to update the "iommus". The list of device passthrough will still be specified in the configuration file. IOW, the partial device-tree is not directly involved in the configuration of the guest.
> 
> But we will generate it. How would something like Zephyr guest work ? Zephyr is not using the device tree we pass, it has an embedded one.

In general, guest that don't use the device-tree/ACPI table to detect 
the layout are already in a bad situation because we don't guarantee 
that the layout (memory, interrupt...) will be stable across Xen 
version. Although, there are a implicit agreement that the layout will 
not change for minor release (i.e. 4.14.x).

But see below for some suggestions how this could be handled.

> 
>>
>> So far, I don't see a particular issue with this approach because the vMaster ID algorithm allocation should be generic. But please let me know if you think there are bits I am missing.
> 
> I am a bit afraid of things that are “automatic”.
> 
> For everything else we let the user in control (IPA for mapping, virtual interrupt number) and in this case we switch to a model where we automatically generated a vMaster ID.

We only let the user control where the device is mapped. But this is 
quite fragile... I think this should be generated at runtime.

> With this model, guest not using the device tree will have to guess the vMaster ID or somehow know how the tools are generating it to use the right one.

To be honest, this is already the case today because the layout exposed 
to the guest is technically not fixed. Yes, so far, we haven't changed 
it too much. But sooner or later, this is going to bite because we made 
clear that the layout is not stable.

Now, if those projects are willing to rebuild for each version, then we 
could use the following approach:
   1) Write the xl.cfg
   2) Ask libxl to generate the device-tree
   3) Build Zephyr
   4) Create the domain

The expectation is for a given Xen version (and compatible), libxl will 
always generate the same Device-Tree.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 15:26:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 15:26:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432136.684878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooRFl-0004qp-TI; Fri, 28 Oct 2022 15:26:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432136.684878; Fri, 28 Oct 2022 15:26:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooRFl-0004qi-QN; Fri, 28 Oct 2022 15:26:37 +0000
Received: by outflank-mailman (input) for mailman id 432136;
 Fri, 28 Oct 2022 15:26:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SnbH=25=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ooRFk-0004qc-6N
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 15:26:36 +0000
Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com
 [2607:f8b0:4864:20::632])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e63657dc-56d4-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 17:26:32 +0200 (CEST)
Received: by mail-pl1-x632.google.com with SMTP id l2so5103622pld.13
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 08:26:32 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e63657dc-56d4-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=Xsk1CTBStwmyF2L6np0PIMN8Pxcqvpzehewr6aTD+FI=;
        b=GQSHxaCNRjiZ3+UhvMmxhHwoP5VyJAgU13N44arPMTTsBuBOaWbAwBVuzteCJKkMT3
         QjJJp5wTiO6+zkI1bcR8G/biXu3cYWqIq/gQUnfxE3BYpWjjb3a2rgQ/FkQ/noofQ3NV
         WHZZa7hvxpftlKNBzrDuhGZ1BDKz6TuejKaVJN3iuk4DlTSkIT0wjhkbq9F20n4d4IHC
         FStkAuYN4UU/qQ3EOOmszzjVKu6R9ob6tt4Biesj0TQmood4nx9JGU5CsftLvL9eKi4i
         LdH+1n3F+HCkbTaREGIjoXn9NE0dff1RNWGRHpu1ILrVeB8hb4GQIU6y5tUmzKAG30Ph
         6jgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=Xsk1CTBStwmyF2L6np0PIMN8Pxcqvpzehewr6aTD+FI=;
        b=2kuB2HGqvySQicyU9P8smwiqOx4NpOJN+Nzh9DpKYw49KEwoa/Rp6mu80SXsMXGvkg
         5FNQV5tUfvfMd2oGJ4KO5itGJ5LKUYEKD+++zqz6t1GvVB/4ZLY5AB49O3V/p485ADcU
         4/RxKvsMuDfarYtZ8LzrDwxZo7qck+0T+4CU/vCiYAaGUHnhjhnAQkRk0E8vxVa1zT1k
         QyDqNhMRlfNa8dk3WWuxWn8h9fuRpWWfaTN10paoV4Rs1538JhFubrz1d7EG/wRq+rlG
         SVcdjUBAolstcPGmNduqZdkMKW0l8sNBP62GjQWC7Sk+/AyU9DTaVuWrzZK6NOqRxc4Y
         4/rQ==
X-Gm-Message-State: ACrzQf2U7PD57Cn6uFg4DDigqDY+BrFX/nqiZH/k5JMx9TeMa/e44WZo
	3JCsVimMvIIrqyZ6aOJSlMOAguGdQTCJBGNhfu0=
X-Google-Smtp-Source: AMsMyM6L7JL/ZztJXo1rZOjHP1NqnUJNsQapw7FycTklZVaJpVZwXjxt4Veo1YMTgwnTW6sAz4IRYP9MYNuU24+Vz/I=
X-Received: by 2002:a17:902:b907:b0:178:2898:8084 with SMTP id
 bf7-20020a170902b90700b0017828988084mr54642133plb.140.1666970790666; Fri, 28
 Oct 2022 08:26:30 -0700 (PDT)
MIME-Version: 1.0
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com> <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com> <95470820-dc9d-dc3b-eb5f-b4db688fa5b1@amd.com>
 <CAPD2p-=PSahQR0JWe3tLEtp0-iiNH=yE96_GxNyDbhSw-fod0w@mail.gmail.com> <60B7173E-65B4-4859-8F14-5CA34368640E@arm.com>
In-Reply-To: <60B7173E-65B4-4859-8F14-5CA34368640E@arm.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Fri, 28 Oct 2022 18:26:18 +0300
Message-ID: <CAPD2p-mrka5aQPpGRABhmc3kY_kFEZL-YDg_iDN0TAVFgO1a6A@mail.gmail.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough devices
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: Michal Orzel <michal.orzel@amd.com>, Julien Grall <julien@xen.org>, 
	Xen developer discussion <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	Michal Orzel <Michal.Orzel@arm.com>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
	Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>, 
	=?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Content-Type: multipart/alternative; boundary="000000000000d4257c05ec19e10e"

--000000000000d4257c05ec19e10e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 27, 2022 at 7:49 PM Rahul Singh <Rahul.Singh@arm.com> wrote:

> Hi Oleksandr,
>

Hello Rahul

[sorry for the possible format issues]


>
> > On 26 Oct 2022, at 7:23 pm, Oleksandr Tyshchenko <olekstysh@gmail.com>
> wrote:
> >
> >
> >
> > On Wed, Oct 26, 2022 at 8:18 PM Michal Orzel <michal.orzel@amd.com>
> wrote:
> > Hi Rahul,
> >
> >
> > Hello all
> >
> > [sorry for the possible format issues]
> >
> >
> > On 26/10/2022 16:33, Rahul Singh wrote:
> > >
> > >
> > > Hi Julien,
> > >
> > >> On 26 Oct 2022, at 2:36 pm, Julien Grall <julien@xen.org> wrote:
> > >>
> > >>
> > >>
> > >> On 26/10/2022 14:17, Rahul Singh wrote:
> > >>> Hi All,
> > >>
> > >> Hi Rahul,
> > >>
> > >>> At Arm, we started to implement the POC to support 2 levels of page
> tables/nested translation in SMMUv3.
> > >>> To support nested translation for guest OS Xen needs to expose the
> virtual IOMMU. If we passthrough the
> > >>> device to the guest that is behind an IOMMU and virtual IOMMU is
> enabled for the guest there is a need to
> > >>> add IOMMU binding for the device in the passthrough node as per [1]=
.
> This email is to get an agreement on
> > >>> how to add the IOMMU binding for guest OS.
> > >>> Before I will explain how to add the IOMMU binding let me give a
> brief overview of how we will add support for virtual
> > >>> IOMMU on Arm. In order to implement virtual IOMMU Xen need SMMUv3
> Nested translation support. SMMUv3 hardware
> > >>> supports two stages of translation. Each stage of translation can b=
e
> independently enabled. An incoming address is logically
> > >>> translated from VA to IPA in stage 1, then the IPA is input to stag=
e
> 2 which translates the IPA to the output PA. Stage 1 is
> > >>> intended to be used by a software entity( Guest OS) to provide
> isolation or translation to buffers within the entity, for example,
> > >>> DMA isolation within an OS. Stage 2 is intended to be available in
> systems supporting the Virtualization Extensions and is
> > >>> intended to virtualize device DMA to guest VM address spaces. When
> both stage 1 and stage 2 are enabled, the translation
> > >>> configuration is called nesting.
> > >>> Stage 1 translation support is required to provide isolation betwee=
n
> different devices within the guest OS. XEN already supports
> > >>> Stage 2 translation but there is no support for Stage 1 translation
> for guests. We will add support for guests to configure
> > >>> the Stage 1 transition via virtual IOMMU. XEN will emulate the SMMU
> hardware and exposes the virtual SMMU to the guest.
> > >>> Guest can use the native SMMU driver to configure the stage 1
> translation. When the guest configures the SMMU for Stage 1,
> > >>> XEN will trap the access and configure the hardware accordingly.
> > >>> Now back to the question of how we can add the IOMMU binding betwee=
n
> the virtual IOMMU and the master devices so that
> > >>> guests can configure the IOMMU correctly. The solution that I am
> suggesting is as below:
> > >>> For dom0, while handling the DT node(handle_node()) Xen will replac=
e
> the phandle in the "iommus" property with the virtual
> > >>> IOMMU node phandle.
> > >> Below, you said that each IOMMUs may have a different ID space. So
> shouldn't we expose one vIOMMU per pIOMMU? If not, how do you expect the
> user to specify the mapping?
> > >
> > > Yes you are right we need to create one vIOMMU per pIOMMU for dom0.
> This also helps in the ACPI case
> > > where we don=E2=80=99t need to modify the tables to delete the pIOMMU=
 entries
> and create one vIOMMU.
> > > In this case, no need to replace the phandle as Xen create the vIOMMU
> with the same pIOMMU
> > > phandle and same base address.
> > >
> > > For domU guests one vIOMMU per guest will be created.
> > >
> > >>
> > >>> For domU guests, when passthrough the device to the guest as per
> [2],  add the below property in the partial device tree
> > >>> node that is required to describe the generic device tree binding
> for IOMMUs and their master(s)
> > >>> "iommus =3D < &magic_phandle 0xvMasterID>
> > >>>      =E2=80=A2 magic_phandle will be the phandle ( vIOMMU phandle i=
n xl)
> that will be documented so that the user can set that in partial DT node
> (0xfdea).
> > >>
> > >> Does this mean only one IOMMU will be supported in the guest?
> > >
> > > Yes.
> > >
> > >>
> > >>>      =E2=80=A2 vMasterID will be the virtual master ID that the use=
r will
> provide.
> > >>> The partial device tree will look like this:
> > >>> /dts-v1/;
> > >>>  / {
> > >>>     /* #*cells are here to keep DTC happy */
> > >>>     #address-cells =3D <2>;
> > >>>     #size-cells =3D <2>;
> > >>>       aliases {
> > >>>         net =3D &mac0;
> > >>>     };
> > >>>       passthrough {
> > >>>         compatible =3D "simple-bus";
> > >>>         ranges;
> > >>>         #address-cells =3D <2>;
> > >>>         #size-cells =3D <2>;
> > >>>         mac0: ethernet@10000000 {
> > >>>             compatible =3D "calxeda,hb-xgmac";
> > >>>             reg =3D <0 0x10000000 0 0x1000>;
> > >>>             interrupts =3D <0 80 4  0 81 4  0 82 4>;
> > >>>            iommus =3D <0xfdea 0x01>;
> > >>>         };
> > >>>     };
> > >>> };
> > >>>  In xl.cfg we need to define a new option to inform Xen about
> vMasterId to pMasterId mapping and to which IOMMU device this
> > >>> the master device is connected so that Xen can configure the right
> IOMMU. This is required if the system has devices that have
> > >>> the same master ID but behind a different IOMMU.
> > >>
> > >> In xl.cfg, we already pass the device-tree node path to passthrough.
> So Xen should already have all the information about the IOMMU and
> Master-ID. So it doesn't seem necessary for Device-Tree.
> > >>
> > >> For ACPI, I would have expected the information to be found in the
> IOREQ.
> > >>
> > >> So can you add more context why this is necessary for everyone?
> > >
> > > We have information for IOMMU and Master-ID but we don=E2=80=99t have
> information for linking vMaster-ID to pMaster-ID.
> > > The device tree node will be used to assign the device to the guest
> and configure the Stage-2 translation. Guest will use the
> > > vMaster-ID to configure the vIOMMU during boot. Xen needs information
> to link vMaster-ID to pMaster-ID to configure
> > > the corresponding pIOMMU. As I mention we need vMaster-ID in case a
> system could have 2 identical Master-ID but
> > > each one connected to a different SMMU and assigned to the guest.
> >
> > I think the proposed solution would work and I would just like to clear
> some issues.
> >
> > Please correct me if I'm wrong:
> >
> > In the xl config file we already need to specify dtdev to point to the
> device path in host dtb.
> > In the partial device tree we specify the vMasterId as well as magic
> phandle.
> > Isn't it that we already have all the information necessary without the
> need for iommu_devid_map?
> > For me it looks like the partial dtb provides vMasterID and dtdev
> provides pMasterID as well as physical phandle to SMMU.
> >
> > Having said that, I can also understand that specifying everything in
> one place using iommu_devid_map can be easier
> > and reduces the need for device tree parsing.
> >
> > Apart from that, what is the reason of exposing only one vSMMU to guest
> instead of one vSMMU per pSMMU?
> > In the latter solution, the whole issue with handling devices with the
> same stream ID but belonging to different SMMUs
> > would be gone. It would also result in a more natural way of the device
> tree look. Normally a guest would see
> > e.g. both SMMUs and exposing only one can be misleading.
> >
> > I also have the same question. From earlier answers as I understand it
> is going to be identity vSMMU <-> pSMMU mappings for Dom0, so why diverge
> for DomU?
> >
> > Also I am thinking how this solution would work for IPMMU-VMSA
> Gen3(Gen4), which also supports two stages of translation, so the nested
> translation could be possible in general, although there might be some
> pitfalls
> > (yes, I understand that code to emulate access to control registers
> would be different in comparison with SMMUv3, but some other code could b=
e
> common).
>
> Yes we will try to make code common so that other vIOMMU can be
> implemented easily.
> >
> >
> >
> >
> >
> > >>
> > >>>  iommu_devid_map =3D [ =E2=80=9CPMASTER_ID[@VMASTER_ID],IOMMU_BASE_=
ADDRESS=E2=80=9D ,
> =E2=80=9CPMASTER_ID[@VMASTER_ID],IOMMU_BASE_ADDRESS=E2=80=9D]
> > >>>      =E2=80=A2 PMASTER_ID is the physical master ID of the device f=
rom the
> physical DT.
> > >>>      =E2=80=A2 VMASTER_ID is the virtual master Id that the user wi=
ll
> configure in the partial device tree.
> > >>>      =E2=80=A2 IOMMU_BASE_ADDRESS is the base address of the physic=
al IOMMU
> device to which this device is connected.
> >
> >
> > If iommu_devid_map is a way to go, I have a question, would this
> configuration cover the following cases?
> > 1. Device has several stream IDs
>
> Yes in that case user needs to create the mapping for each streamIDs. For
> example if device has streamId 0x10 , 0x20 and 0x30.
> iommu_devid_map will be:
>
> iommu_devid_map =3D ["0x10@0x01,0x40000000=E2=80=9D, "0x20@0x02
> ,0x40000000=E2=80=9D,"0x30@0x03,0x40000000=E2=80=9D]
>
> Here 0x40000000 is physical IOMMU base address.
>
> > 2. Several devices share the stream ID (or several stream IDs)
>
> Let take an example of two devices :
>
> Device 1: 0x10
> Device 2: 0x10
>
> Iommu_devid_map =3D [=E2=80=9C0x10@0x1,0x40000000=E2=80=9D,"0x10@0x2,0x40=
000000=E2=80=9D]
>
> Xen will create the data structure that include vStreamID, pMasterID and
> IOMMU base address.
> With the help of three tuples we will be able to find the right physical
> IOMMU.



Thanks for the clarification, I see that iommu_devid_map is able to
describe various combinations, which is good. But, the user should be very
careful when filling in iommu_devid_map especially
if dealing with a system that has many iommus and devices with many stream
IDs, as it would be easy to make a mistake in that case.
As a real example, if I want to describe 5 DMA controllers assigned to the
guest where each has 16 uTLBs (this is an equivalent of stream IDs) I would
need to add 80 entries (quite lot) to iommu_devid_map with specifying
VMASTER_ID for each entry (as uTLBs are not unique across the system).

https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r=
8a77951.dtsi#L1042
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r=
8a77951.dtsi#L1084
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r=
8a77951.dtsi#L1126
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r=
8a77951.dtsi#L2450
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r=
8a77951.dtsi#L2492


So I agree in general with what has been said earlier in that thread to
*better* avoid user interaction
and teach the toolstack to do this automatically. At the same time I
understand this might be quite difficult to implement, etc.



>
>
>
> Regards,
> Rahul



--=20
Regards,

Oleksandr Tyshchenko

--000000000000d4257c05ec19e10e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Oct 27, 2022 at 7:49 PM Rahul=
 Singh &lt;<a href=3D"mailto:Rahul.Singh@arm.com" target=3D"_blank">Rahul.S=
ingh@arm.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex">Hi Oleksandr,<br></blockquote><div><br></div><div>Hello=C2=A0Ra=
hul</div><div><br></div><div>[sorry for the possible format issues]</div><d=
iv>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
&gt; On 26 Oct 2022, at 7:23 pm, Oleksandr Tyshchenko &lt;<a href=3D"mailto=
:olekstysh@gmail.com" target=3D"_blank">olekstysh@gmail.com</a>&gt; wrote:<=
br>
&gt; <br>
&gt; <br>
&gt; <br>
&gt; On Wed, Oct 26, 2022 at 8:18 PM Michal Orzel &lt;<a href=3D"mailto:mic=
hal.orzel@amd.com" target=3D"_blank">michal.orzel@amd.com</a>&gt; wrote:<br=
>
&gt; Hi Rahul,<br>
&gt;=C2=A0 <br>
&gt; <br>
&gt; Hello all<br>
&gt; <br>
&gt; [sorry for the possible format issues]<br>
&gt;=C2=A0 <br>
&gt; <br>
&gt; On 26/10/2022 16:33, Rahul Singh wrote:<br>
&gt; &gt; <br>
&gt; &gt; <br>
&gt; &gt; Hi Julien,<br>
&gt; &gt; <br>
&gt; &gt;&gt; On 26 Oct 2022, at 2:36 pm, Julien Grall &lt;<a href=3D"mailt=
o:julien@xen.org" target=3D"_blank">julien@xen.org</a>&gt; wrote:<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; On 26/10/2022 14:17, Rahul Singh wrote:<br>
&gt; &gt;&gt;&gt; Hi All,<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Hi Rahul,<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;&gt; At Arm, we started to implement the POC to support 2 leve=
ls of page tables/nested translation in SMMUv3.<br>
&gt; &gt;&gt;&gt; To support nested translation for guest OS Xen needs to e=
xpose the virtual IOMMU. If we passthrough the<br>
&gt; &gt;&gt;&gt; device to the guest that is behind an IOMMU and virtual I=
OMMU is enabled for the guest there is a need to<br>
&gt; &gt;&gt;&gt; add IOMMU binding for the device in the passthrough node =
as per [1]. This email is to get an agreement on<br>
&gt; &gt;&gt;&gt; how to add the IOMMU binding for guest OS.<br>
&gt; &gt;&gt;&gt; Before I will explain how to add the IOMMU binding let me=
 give a brief overview of how we will add support for virtual<br>
&gt; &gt;&gt;&gt; IOMMU on Arm. In order to implement virtual IOMMU Xen nee=
d SMMUv3 Nested translation support. SMMUv3 hardware<br>
&gt; &gt;&gt;&gt; supports two stages of translation. Each stage of transla=
tion can be independently enabled. An incoming address is logically<br>
&gt; &gt;&gt;&gt; translated from VA to IPA in stage 1, then the IPA is inp=
ut to stage 2 which translates the IPA to the output PA. Stage 1 is<br>
&gt; &gt;&gt;&gt; intended to be used by a software entity( Guest OS) to pr=
ovide isolation or translation to buffers within the entity, for example,<b=
r>
&gt; &gt;&gt;&gt; DMA isolation within an OS. Stage 2 is intended to be ava=
ilable in systems supporting the Virtualization Extensions and is<br>
&gt; &gt;&gt;&gt; intended to virtualize device DMA to guest VM address spa=
ces. When both stage 1 and stage 2 are enabled, the translation<br>
&gt; &gt;&gt;&gt; configuration is called nesting.<br>
&gt; &gt;&gt;&gt; Stage 1 translation support is required to provide isolat=
ion between different devices within the guest OS. XEN already supports<br>
&gt; &gt;&gt;&gt; Stage 2 translation but there is no support for Stage 1 t=
ranslation for guests. We will add support for guests to configure<br>
&gt; &gt;&gt;&gt; the Stage 1 transition via virtual IOMMU. XEN will emulat=
e the SMMU hardware and exposes the virtual SMMU to the guest.<br>
&gt; &gt;&gt;&gt; Guest can use the native SMMU driver to configure the sta=
ge 1 translation. When the guest configures the SMMU for Stage 1,<br>
&gt; &gt;&gt;&gt; XEN will trap the access and configure the hardware accor=
dingly.<br>
&gt; &gt;&gt;&gt; Now back to the question of how we can add the IOMMU bind=
ing between the virtual IOMMU and the master devices so that<br>
&gt; &gt;&gt;&gt; guests can configure the IOMMU correctly. The solution th=
at I am suggesting is as below:<br>
&gt; &gt;&gt;&gt; For dom0, while handling the DT node(handle_node()) Xen w=
ill replace the phandle in the &quot;iommus&quot; property with the virtual=
<br>
&gt; &gt;&gt;&gt; IOMMU node phandle.<br>
&gt; &gt;&gt; Below, you said that each IOMMUs may have a different ID spac=
e. So shouldn&#39;t we expose one vIOMMU per pIOMMU? If not, how do you exp=
ect the user to specify the mapping?<br>
&gt; &gt; <br>
&gt; &gt; Yes you are right we need to create one vIOMMU per pIOMMU for dom=
0. This also helps in the ACPI case<br>
&gt; &gt; where we don=E2=80=99t need to modify the tables to delete the pI=
OMMU entries and create one vIOMMU.<br>
&gt; &gt; In this case, no need to replace the phandle as Xen create the vI=
OMMU with the same pIOMMU<br>
&gt; &gt; phandle and same base address.<br>
&gt; &gt; <br>
&gt; &gt; For domU guests one vIOMMU per guest will be created.<br>
&gt; &gt; <br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;&gt; For domU guests, when passthrough the device to the guest=
 as per [2],=C2=A0 add the below property in the partial device tree<br>
&gt; &gt;&gt;&gt; node that is required to describe the generic device tree=
 binding for IOMMUs and their master(s)<br>
&gt; &gt;&gt;&gt; &quot;iommus =3D &lt; &amp;magic_phandle 0xvMasterID&gt;<=
br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 magic_phandle will be the p=
handle ( vIOMMU phandle in xl)=C2=A0 that will be documented so that the us=
er can set that in partial DT node (0xfdea).<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Does this mean only one IOMMU will be supported in the guest?=
<br>
&gt; &gt; <br>
&gt; &gt; Yes.<br>
&gt; &gt; <br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 vMasterID will be the virtu=
al master ID that the user will provide.<br>
&gt; &gt;&gt;&gt; The partial device tree will look like this:<br>
&gt; &gt;&gt;&gt; /dts-v1/;<br>
&gt; &gt;&gt;&gt;=C2=A0 / {<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0/* #*cells are here to keep DTC happy =
*/<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0#address-cells =3D &lt;2&gt;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0#size-cells =3D &lt;2&gt;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0aliases {<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0net =3D &amp;mac0;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0};<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0passthrough {<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &quot;sim=
ple-bus&quot;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ranges;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-cells =3D &lt;2=
&gt;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cells =3D &lt;2&gt=
;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mac0: ethernet@10000000 =
{<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible=
 =3D &quot;calxeda,hb-xgmac&quot;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D &l=
t;0 0x10000000 0 0x1000&gt;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0interrupts=
 =3D &lt;0 80 4=C2=A0 0 81 4=C2=A0 0 82 4&gt;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 iommus =3D &lt;0=
xfdea 0x01&gt;;<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0};<br>
&gt; &gt;&gt;&gt; };<br>
&gt; &gt;&gt;&gt;=C2=A0 In xl.cfg we need to define a new option to inform =
Xen about vMasterId to pMasterId mapping and to which IOMMU device this<br>
&gt; &gt;&gt;&gt; the master device is connected so that Xen can configure =
the right IOMMU. This is required if the system has devices that have<br>
&gt; &gt;&gt;&gt; the same master ID but behind a different IOMMU.<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; In xl.cfg, we already pass the device-tree node path to passt=
hrough. So Xen should already have all the information about the IOMMU and =
Master-ID. So it doesn&#39;t seem necessary for Device-Tree.<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; For ACPI, I would have expected the information to be found i=
n the IOREQ.<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; So can you add more context why this is necessary for everyon=
e?<br>
&gt; &gt; <br>
&gt; &gt; We have information for IOMMU and Master-ID but we don=E2=80=99t =
have information for linking vMaster-ID to pMaster-ID.<br>
&gt; &gt; The device tree node will be used to assign the device to the gue=
st and configure the Stage-2 translation. Guest will use the<br>
&gt; &gt; vMaster-ID to configure the vIOMMU during boot. Xen needs informa=
tion to link vMaster-ID to pMaster-ID to configure<br>
&gt; &gt; the corresponding pIOMMU. As I mention we need vMaster-ID in case=
 a system could have 2 identical Master-ID but<br>
&gt; &gt; each one connected to a different SMMU and assigned to the guest.=
<br>
&gt; <br>
&gt; I think the proposed solution would work and I would just like to clea=
r some issues.<br>
&gt; <br>
&gt; Please correct me if I&#39;m wrong:<br>
&gt; <br>
&gt; In the xl config file we already need to specify dtdev to point to the=
 device path in host dtb.<br>
&gt; In the partial device tree we specify the vMasterId as well as magic p=
handle.<br>
&gt; Isn&#39;t it that we already have all the information necessary withou=
t the need for iommu_devid_map?<br>
&gt; For me it looks like the partial dtb provides vMasterID and dtdev prov=
ides pMasterID as well as physical phandle to SMMU.<br>
&gt; <br>
&gt; Having said that, I can also understand that specifying everything in =
one place using iommu_devid_map can be easier<br>
&gt; and reduces the need for device tree parsing.<br>
&gt; <br>
&gt; Apart from that, what is the reason of exposing only one vSMMU to gues=
t instead of one vSMMU per pSMMU?<br>
&gt; In the latter solution, the whole issue with handling devices with the=
 same stream ID but belonging to different SMMUs<br>
&gt; would be gone. It would also result in a more natural way of the devic=
e tree look. Normally a guest would see<br>
&gt; e.g. both SMMUs and exposing only one can be misleading.<br>
&gt; <br>
&gt; I also have the same question. From earlier answers as I understand it=
 is going to be identity vSMMU &lt;-&gt; pSMMU mappings for Dom0, so why di=
verge for DomU?<br>
&gt; <br>
&gt; Also I am thinking how this solution would work for IPMMU-VMSA Gen3(Ge=
n4), which also supports two stages of translation, so the nested translati=
on could be possible in general, although there might be some pitfalls<br>
&gt; (yes, I understand that code to emulate access to control registers wo=
uld be different in comparison with SMMUv3, but some other code could be co=
mmon).=C2=A0 <br>
<br>
Yes we will try to make code common so that other vIOMMU can be implemented=
 easily. <br>
&gt;=C2=A0 =C2=A0 <br>
&gt; <br>
&gt; <br>
&gt;=C2=A0 <br>
&gt; <br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt;&gt;=C2=A0 iommu_devid_map =3D [ =E2=80=9CPMASTER_ID[@VMASTER_=
ID],IOMMU_BASE_ADDRESS=E2=80=9D , =E2=80=9CPMASTER_ID[@VMASTER_ID],IOMMU_BA=
SE_ADDRESS=E2=80=9D]<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 PMASTER_ID is the physical =
master ID of the device from the physical DT.<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 VMASTER_ID is the virtual m=
aster Id that the user will configure in the partial device tree.<br>
&gt; &gt;&gt;&gt;=C2=A0 =C2=A0 =C2=A0 =E2=80=A2 IOMMU_BASE_ADDRESS is the b=
ase address of the physical IOMMU device to which this device is connected.=
<br>
&gt;=C2=A0 <br>
&gt; <br>
&gt; If iommu_devid_map is a way to go, I have a question, would this confi=
guration cover the following cases?<br>
&gt; 1. Device has several stream IDs<br>
<br>
Yes in that case user needs to create the mapping for each streamIDs. For e=
xample if device has streamId 0x10 , 0x20 and 0x30.<br>
iommu_devid_map will be:<br>
<br>
iommu_devid_map =3D [&quot;0x10@0x01,0x40000000=E2=80=9D, &quot;0x20@0x02,0=
x40000000=E2=80=9D,&quot;0x30@0x03,0x40000000=E2=80=9D]<br>
<br>
Here 0x40000000 is physical IOMMU base address.<br>
<br>
&gt; 2. Several devices share the stream ID (or several stream IDs)<br>
<br>
Let take an example of two devices :<br>
<br>
Device 1: 0x10<br>
Device 2: 0x10<br>
<br>
Iommu_devid_map =3D [=E2=80=9C0x10@0x1,0x40000000=E2=80=9D,&quot;0x10@0x2,0=
x40000000=E2=80=9D]<br>
<br>
Xen will create the data structure that include vStreamID, pMasterID and IO=
MMU base address. <br>
With the help of three tuples we will be able to find the right physical IO=
MMU.</blockquote><div><br></div><div><br></div>Thanks for the clarification=
, I see that iommu_devid_map is able to describe various combinations, whic=
h is good. But, the user should be very careful when filling in iommu_devid=
_map especially<br>if dealing with a system that has many iommus and device=
s with many stream IDs, as it would be easy to make a mistake in that case.=
<br>As a real example, if I want to describe 5 DMA controllers assigned to =
the guest where each has 16 uTLBs (this is an equivalent of stream IDs) I w=
ould need to add 80 entries (quite lot) to iommu_devid_map with specifying =
VMASTER_ID for each entry (as uTLBs are not unique across the system). <br>=
<br><a href=3D"https://github.com/torvalds/linux/blob/master/arch/arm64/boo=
t/dts/renesas/r8a77951.dtsi#L1042">https://github.com/torvalds/linux/blob/m=
aster/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L1042</a><br><a href=3D"htt=
ps://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r8a7=
7951.dtsi#L1084">https://github.com/torvalds/linux/blob/master/arch/arm64/b=
oot/dts/renesas/r8a77951.dtsi#L1084</a><br><a href=3D"https://github.com/to=
rvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L1126">h=
ttps://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r8=
a77951.dtsi#L1126</a><br><a href=3D"https://github.com/torvalds/linux/blob/=
master/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L2450">https://github.com/=
torvalds/linux/blob/master/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L2450<=
/a><br><a href=3D"https://github.com/torvalds/linux/blob/master/arch/arm64/=
boot/dts/renesas/r8a77951.dtsi#L2492">https://github.com/torvalds/linux/blo=
b/master/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L2492</a><br><br><br>So =
I agree in general with what has been said earlier in that thread to *bette=
r* avoid user interaction<br><div>and teach the toolstack to do this automa=
tically. At the same time I understand this might be quite difficult to imp=
lement, etc.=C2=A0 =C2=A0 =C2=A0<br></div><div><br></div><div>=C2=A0</div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"> <br>
<br>
<br>
Regards,<br>
Rahul</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D=
"ltr"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><span st=
yle=3D"background-color:rgb(255,255,255)"><font size=3D"2"><span style=3D"c=
olor:rgb(51,51,51);font-family:Arial,sans-serif">Regards,</span></font></sp=
an></div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><div><span style=3D"ba=
ckground-color:rgb(255,255,255)"><font size=3D"2">Oleksandr Tyshchenko</fon=
t></span></div></div></div></div></div></div></div></div>

--000000000000d4257c05ec19e10e--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 15:27:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 15:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432141.684889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooRGj-0005Rn-AJ; Fri, 28 Oct 2022 15:27:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432141.684889; Fri, 28 Oct 2022 15:27:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooRGj-0005Rg-6r; Fri, 28 Oct 2022 15:27:37 +0000
Received: by outflank-mailman (input) for mailman id 432141;
 Fri, 28 Oct 2022 15:27:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Yvsd=25=gmail.com=dunlapg@srs-se1.protection.inumbo.net>)
 id 1ooRGh-0005LA-QP
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 15:27:35 +0000
Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com
 [2607:f8b0:4864:20::92f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b354736-56d5-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 17:27:34 +0200 (CEST)
Received: by mail-ua1-x92f.google.com with SMTP id c12so1919103uat.13
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 08:27:34 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b354736-56d5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=umich.edu; s=google-2016-06-03;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=mF/SditKV00XS5Xvar+K/S/BfS9x863TyTptR2UvUUg=;
        b=QnB2jMTBvaKQeI4HJ5BX1fUWbnEfpu+qVuJZuDeHwXfbY+UcZKuB4mTLhE1nYqEK/j
         7al6V4kQI+ZVcxj5vMqjn2EUolfk5Yf/8LVI7ZWgUfxR2pV/ZF5HD5ZFKpAfuhOvvGsQ
         c5x+cNpvglzqDVsG6Fr1ETSOuBrl8vzLIH0SaW+IV3kA5x7XS5MwfVa+JznJZ9xwulOS
         fIR04CwQKxW/nqOnbfOcw6c5KojiCKOyzccbbSNDH7qQYxE4Bpc8733s3Xes6Rk/rz4x
         V/nosSBCniSns705Dj8bHk9WawzpjrypmMH0Qodg3XeF9obFqMGyg/KExrH1h98uUPV4
         lzJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=mF/SditKV00XS5Xvar+K/S/BfS9x863TyTptR2UvUUg=;
        b=UBAWmXxMmiR//TDOONvR6Lq2ajQfOdAEsq/eqjljnNsyBfy/+gWrAYdkVZPQQ5YC/k
         8a+6Z0NJBu44m+CowZq/wZhqdbBSqE/yOhWT+xKAtUWJQL5EWLN3qezF4X3CWDcAeaJC
         6TMBqG3R7limLci88Ry3JiawXrje0roScYdIEdfWG2br4G7oVxl7DeEMt1rSMGShayn6
         snTK2u46TwuldtUb8unmhIUP1JKYjHQRLqg0OEhFx0DUmT7W+OQalGHGg2sNbMi4OWDd
         ZqvOeUNLBfvIp5w+4/OLaRgaAb1Y2FZ7HcTZpkpLzfiw9mlw4is3em30Uu3RNur0WOgx
         n95A==
X-Gm-Message-State: ACrzQf1GFrYZSq9oDghBRH5aqfnrQAtH8ZkuLlzub3BWt+a1I+BIx3KG
	+Na8NyYb+2qTUJ22WhOdrctUPPvabnEmHS1KZT8=
X-Google-Smtp-Source: AMsMyM5rXw5n8LqY1V8Rco1arTg/MAzPNOdpvzQ99TsRjn7p3vxre+yfwkrd9fTjJFDvk7tMVl4b9AvE8gDFc/3tqeU=
X-Received: by 2002:a9f:350c:0:b0:3e4:1518:7e8b with SMTP id
 o12-20020a9f350c000000b003e415187e8bmr120960uao.34.1666970852991; Fri, 28 Oct
 2022 08:27:32 -0700 (PDT)
MIME-Version: 1.0
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com> <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com> <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com>
In-Reply-To: <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com>
From: George Dunlap <dunlapg@umich.edu>
Date: Fri, 28 Oct 2022 16:27:21 +0100
Message-ID: <CAFLBxZbWkLSMxXAYRGYc9Z3Vvj6bT+m7nvdiZgWRdr+_nF0BfQ@mail.gmail.com>
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool size
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>, 
	Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>, 
	Henry Wang <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>, 
	Xen-devel <xen-devel@lists.xenproject.org>, George Dunlap <george.dunlap@citrix.com>
Content-Type: multipart/alternative; boundary="0000000000008b280f05ec19e56c"

--0000000000008b280f05ec19e56c
Content-Type: text/plain; charset="UTF-8"

On Thu, Oct 27, 2022 at 8:12 AM Jan Beulich <jbeulich@suse.com> wrote:

> On 26.10.2022 21:22, Andrew Cooper wrote:
> > On 26/10/2022 14:42, Jan Beulich wrote:
>


> > paging isn't a great name.  While it's what we call the infrastructure
> > in x86, it has nothing to do with paging things out to disk (the thing
> > everyone associates the name with), nor the xenpaging infrastructure
> > (Xen's version of what OS paging supposedly means).
>
> Okay, "paging" can be somewhat misleading. But "p2m" also doesn't fit
> the use(s) on x86. Yet we'd like to use a name clearly better than the
> previous (and yet more wrong/misleading) "shadow". I have to admit that
> I can't think of any other sensible name, and among the ones discussed
> I still think "paging" is the one coming closest despite the
> generally different meaning of the word elsewhere.
>

Inside the world of operating systems / hypervisors, "paging" has always
meant "things related to a pagetable"; this includes "paging out to disk".
In fact, the latter already has a perfectly good name -- "swap" (e.g., swap
file, swappiness, hypervisor swap).

Grep for "paging" inside of Xen.  We have the paging lock, paging modes,
nested paging, and so on.  There's absolutely no reason to start thinking
of "paging" as exclusively meaning "hypervisor swap".

[ A bunch of stuff about using bytes as a unit size]

> This is going to be a reoccurring theme through fixing the ABIs.  Its
> > one of a several areas where there is objectively one right answer, both
> > in terms of ease of use, and compatibility to future circumstances.
>
> Well, I wouldn't say using whatever base granularity as a unit is
> "objectively" less right.
>

Personally I don't think bytes or pages either have a particular advantage:

* Using bytes
 - Advantage: Can always use the same number regardless of the underlying
page size
 - Disadvantage: "Trap" where if you forget to check the page size, you
might accidentally pass an invalid input.  Or to put it differently, most
"reasonable-looking" numbers are actually invalid (since most numbers
aren't page-aligned)/
* Using pages
 - Advantage: No need to check page alignment in HV, no accidentally
invalid input
 - Disadvantage: Caller must check page size and do a shift on every call

What would personally tip me one way or the other is consistency with other
hypercalls.  If most of our hypercalls (or even most of our MM hypercalls)
use bytes, then I'd lean towards bytes.  Whereas if most of our hypercalls
use pages, I'd lean towards pages.

 -George

--0000000000008b280f05ec19e56c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Oct 27, 2022 at 8:12 AM Jan B=
eulich &lt;<a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 26.10.2=
022 21:22, Andrew Cooper wrote:<br>
&gt; On 26/10/2022 14:42, Jan Beulich wrote:<br></blockquote><div>=C2=A0</d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; paging isn&#39;t a great name.=C2=A0 While it&#39;s what we call the i=
nfrastructure<br>
&gt; in x86, it has nothing to do with paging things out to disk (the thing=
<br>
&gt; everyone associates the name with), nor the xenpaging infrastructure<b=
r>
&gt; (Xen&#39;s version of what OS paging supposedly means).<br>
<br>
Okay, &quot;paging&quot; can be somewhat misleading. But &quot;p2m&quot; al=
so doesn&#39;t fit<br>
the use(s) on x86. Yet we&#39;d like to use a name clearly better than the<=
br>
previous (and yet more wrong/misleading) &quot;shadow&quot;. I have to admi=
t that<br>
I can&#39;t think of any other sensible name, and among the ones discussed<=
br>
I still think &quot;paging&quot; is the one coming closest despite the<br>
generally different meaning of the word elsewhere.<br></blockquote><div><br=
></div><div>Inside the world of operating systems / hypervisors, &quot;pagi=
ng&quot; has always meant &quot;things related to a pagetable&quot;; this i=
ncludes &quot;paging out to disk&quot;.=C2=A0 In fact, the latter already h=
as a perfectly good name -- &quot;swap&quot; (e.g., swap file, swappiness, =
hypervisor swap).</div><div><br></div><div>Grep for &quot;paging&quot; insi=
de of Xen.=C2=A0 We have the paging lock, paging modes, nested paging, and =
so on.=C2=A0 There&#39;s absolutely no reason to start thinking of &quot;pa=
ging&quot; as exclusively meaning &quot;hypervisor swap&quot;.</div><div>=
=C2=A0</div><div>[ A bunch of stuff about using bytes as a unit size]</div>=
<div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; This is going to be a reoccurring theme through fixing the ABIs.=C2=A0=
 Its<br>
&gt; one of a several areas where there is objectively one right answer, bo=
th<br>
&gt; in terms of ease of use, and compatibility to future circumstances.<br=
>
<br>
Well, I wouldn&#39;t say using whatever base granularity as a unit is<br>
&quot;objectively&quot; less right.<br></blockquote><div><br></div><div>Per=
sonally I don&#39;t think bytes or pages either have a particular advantage=
:</div><div><br></div><div>* Using bytes</div><div>=C2=A0- Advantage: Can a=
lways use the same number regardless of the underlying page size</div><div>=
=C2=A0- Disadvantage: &quot;Trap&quot; where if you forget to check the pag=
e size, you might accidentally pass an invalid input.=C2=A0 Or to put it di=
fferently, most &quot;reasonable-looking&quot; numbers are actually invalid=
 (since most numbers aren&#39;t page-aligned)/</div><div>* Using pages</div=
><div>=C2=A0- Advantage: No need to check page alignment in HV, no accident=
ally invalid input</div><div>=C2=A0- Disadvantage: Caller must check page s=
ize and do a shift on every call</div><div><br></div><div>What would person=
ally tip me one way or the other is consistency with other hypercalls.=C2=
=A0 If most of our hypercalls (or even most of our MM hypercalls) use bytes=
, then I&#39;d lean towards bytes.=C2=A0 Whereas if most of our hypercalls =
use pages, I&#39;d lean towards pages.</div><div><br></div><div>=C2=A0-Geor=
ge</div></div></div>

--0000000000008b280f05ec19e56c--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 15:35:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 15:35:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432147.684899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooROM-0007DG-5X; Fri, 28 Oct 2022 15:35:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432147.684899; Fri, 28 Oct 2022 15:35:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooROM-0007D9-2o; Fri, 28 Oct 2022 15:35:30 +0000
Received: by outflank-mailman (input) for mailman id 432147;
 Fri, 28 Oct 2022 15:34:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=GD3O=25=gmail.com=bruce.ashfield@srs-se1.protection.inumbo.net>)
 id 1ooRMz-0006uW-3d
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 15:34:05 +0000
Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com
 [2607:f8b0:4864:20::d36])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f392cd94-56d5-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 17:34:04 +0200 (CEST)
Received: by mail-io1-xd36.google.com with SMTP id l127so4834071iof.12
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 08:34:04 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f392cd94-56d5-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=X68HLcAn+xMj99CT688cZ5YUmRAJyCzuJNU9oDEpHYo=;
        b=nx1kt/i5wIhiGCTgDEeTwQSWq3lw28Rhr6cpdTqez9uIFIpjd6wWmPDtTp8b/GvVB+
         cc+fzBFYtY5MWudcQzVXQBgxeNaMtfkh1+wwJfzPCw6IeIed5JK+8IvpsvkZ7QobA9w/
         E9t0lBOEojgbHDHDu5uoWW7d3syjJXqk80J6nD0UEB592BJZ8Sa0h7EQxxFNjUmjFovi
         +cwsn6EJi9PkNLt3Y/0JUsY2FKlSpMobZbx/qKwNaiWHKJANKOYJO3Bh4tYol8tF8Tp3
         pqZFr9GwNMkDyba8NHBx/sdMv/MQhb2uiXtCMSgimGo2l+azGdgrMAyuKniBN3VQmtCF
         QuZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=X68HLcAn+xMj99CT688cZ5YUmRAJyCzuJNU9oDEpHYo=;
        b=YuQ3svQWhg9tVk5v/AXypAoxacOGlG/jeDBU7kIxo7huC50u0+5ie22jkOLPurAFVN
         p+kOtDP/vMS0Mlud/3G6pabF69s5R+fi5C7CVt+YJH5l6BuN+o+LXThpKS22Zatkz0Lz
         U2PLaTsd3v648OucY1Mq6blmr1YfpleC+cU0GZeK/jLXefaH2uqJzIriVQdmDQwQQBP2
         zPtNuTHJy+QTKJ6y9by78o948n0CeoWCdjSPjj/CwesYjM0e1viMPzxhZPX479tDk3qG
         FmoLC8QPI0wEXHFiLZIag0qOxJtLsE2wpxhoWe+MEf8JO6kSjpnlOYlkG7yWXCgOrvl3
         PMJw==
X-Gm-Message-State: ACrzQf1y1osv4OWoXBNMTlNTAG6LwsOIWoGJNS8/6B5jh+472yWOvAIR
	/Ln6SEceireJzK7DadhNf1/v3l4+4mAyNNkSzI8=
X-Google-Smtp-Source: AMsMyM6G8fw+ZgdzvFMm4SXobj4CIDcGdMgd5QQ//LKzEIgRBU6WZk6E3mnwyVSnxtxOUhQWFJVOw3Pz6B+AST6XulM=
X-Received: by 2002:a05:6638:35a2:b0:364:451:9969 with SMTP id
 v34-20020a05663835a200b0036404519969mr960jal.245.1666971242731; Fri, 28 Oct
 2022 08:34:02 -0700 (PDT)
MIME-Version: 1.0
References: <AS8PR08MB79919CCB4F14F5FDE8929DF092329@AS8PR08MB7991.eurprd08.prod.outlook.com>
 <CACMJ4GYr_R-yKCxUVGjcZgcCFmHNQa9Ts=_F-pdN-rgvsrCVWA@mail.gmail.com>
In-Reply-To: <CACMJ4GYr_R-yKCxUVGjcZgcCFmHNQa9Ts=_F-pdN-rgvsrCVWA@mail.gmail.com>
From: Bruce Ashfield <bruce.ashfield@gmail.com>
Date: Fri, 28 Oct 2022 11:33:51 -0400
Message-ID: <CADkTA4MM31cAT9Mw87fHhByD54x1Qk0Ua68-FnLupLebXr7-vw@mail.gmail.com>
Subject: Re: Feedback for postponing the 4.17 release to a week later
To: Christopher Clark <christopher.w.clark@gmail.com>
Cc: Henry Wang <Henry.Wang@arm.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	"Daniel P. Smith" <dpsmith@apertussolutions.com>, George Dunlap <george.dunlap@citrix.com>, 
	Jan Beulich <jbeulich@suse.com>, 
	"christopher.clark@starlab.io" <christopher.clark@starlab.io>, Bertrand Marquis <Bertrand.Marquis@arm.com>, 
	Julien Grall <julien@xen.org>, Julien Grall <jgrall@amazon.com>, 
	Stefano Stabellini <stefano.stabellini@xilinx.com>, 
	"sstabellini@kernel.org" <sstabellini@kernel.org>, "jgross@suse.com" <jgross@suse.com>, 
	Andrew Cooper <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
	Anthony PERARD <anthony.perard@citrix.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Wei Liu <wl@xen.org>, "Wei Liu (LSG)" <liuwe@microsoft.com>
Content-Type: multipart/alternative; boundary="000000000000c620d205ec19fc49"

--000000000000c620d205ec19fc49
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 28, 2022 at 2:43 AM Christopher Clark <
christopher.w.clark@gmail.com> wrote:

> On Thu, Oct 27, 2022 at 9:44 PM Henry Wang <Henry.Wang@arm.com> wrote:
>
>> Hi all,
>>
>> Since there will be a batch of XSAs released on Nov. 1 [1] and the
>> original date for
>> the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the
>> 4.17
>> release to a week later (Nov. 11) to give a little bit longer time so
>> that:
>>
>> - The security team won't do anything in rush.
>> - We can have more feedback after merging these XSAs.
>> - Include more release-relevant bugfixes.
>>
>> May I please have some feedback on this proposal? Thanks very much!
>>
>
> I think you have presented an appropriate rationale for the date
> adjustment, so I am supportive of it.
>
> As for effect on downstreams: I don't think that this change of date will
> negatively affect OpenEmbedded and Yocto (+CC Bruce for visibility).
>
>
Thanks for the heads up.

We have time in our cycle, so no problems on this end.

Bruce



> Christopher
>
>
>>
>> [1] https://xenbits.xen.org/xsa/
>>
>> Kind regards,
>> Henry
>>
>>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

--000000000000c620d205ec19fc49
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-size:small"><br></div></div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Fri, Oct 28, 2022 at 2:43 AM Christopher Clark &=
lt;<a href=3D"mailto:christopher.w.clark@gmail.com">christopher.w.clark@gma=
il.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex"><div dir=3D"ltr"><div dir=3D"ltr">On Thu, Oct 27, 2022 at 9:44 PM Hen=
ry Wang &lt;<a href=3D"mailto:Henry.Wang@arm.com" target=3D"_blank">Henry.W=
ang@arm.com</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">Hi all,<br>
<br>
Since there will be a batch of XSAs released on Nov. 1 [1] and the original=
 date for<br>
the 4.17 release was supposed to be Nov. 2, I am thinking to postpone the 4=
.17<br>
release to a week later (Nov. 11) to give a little bit longer time so that:=
<br>
<br>
- The security team won&#39;t do anything in rush.<br>
- We can have more feedback after merging these XSAs.<br>
- Include more release-relevant bugfixes.<br>
<br>
May I please have some feedback on this proposal? Thanks very much!<br></bl=
ockquote><div><br></div><div>I think you have presented an appropriate rati=
onale for the date adjustment, so I am supportive of it.</div><div><br></di=
v><div>As for effect on downstreams: I don&#39;t=C2=A0think that this chang=
e of date will negatively affect OpenEmbedded and Yocto (+CC Bruce for visi=
bility).</div><div><br></div></div></div></blockquote><div><br></div><div><=
div class=3D"gmail_default" style=3D"font-size:small">Thanks for the heads =
up.</div><div class=3D"gmail_default" style=3D"font-size:small"><br></div><=
div class=3D"gmail_default" style=3D"font-size:small">We have time in our c=
ycle, so no problems on this end.</div><div class=3D"gmail_default" style=
=3D"font-size:small"><br></div><div class=3D"gmail_default" style=3D"font-s=
ize:small">Bruce</div><br></div><div>=C2=A0</div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div></=
div><div>Christopher</div><div>=C2=A0</div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex">
<br>
[1] <a href=3D"https://xenbits.xen.org/xsa/" rel=3D"noreferrer" target=3D"_=
blank">https://xenbits.xen.org/xsa/</a><br>
<br>
Kind regards,<br>
Henry<br>
<br>
</blockquote></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature">- Thou shalt not follow the NULL pointer, for ch=
aos and madness await thee at its end<br>- &quot;Use the force Harry&quot; =
- Gandalf, Star Trek II<br><br></div></div>

--000000000000c620d205ec19fc49--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 15:46:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 15:46:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432154.684911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooRYg-0000XS-67; Fri, 28 Oct 2022 15:46:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432154.684911; Fri, 28 Oct 2022 15:46:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooRYg-0000XL-1v; Fri, 28 Oct 2022 15:46:10 +0000
Received: by outflank-mailman (input) for mailman id 432154;
 Fri, 28 Oct 2022 15:46:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pqEQ=25=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1ooRYe-0000XF-LI
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 15:46:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70073.outbound.protection.outlook.com [40.107.7.73])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2b98ec6-56d7-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 17:46:06 +0200 (CEST)
Received: from AM6PR04CA0038.eurprd04.prod.outlook.com (2603:10a6:20b:f0::15)
 by AS2PR08MB9320.eurprd08.prod.outlook.com (2603:10a6:20b:598::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct
 2022 15:45:53 +0000
Received: from AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:f0:cafe::1b) by AM6PR04CA0038.outlook.office365.com
 (2603:10a6:20b:f0::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 15:45:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM7EUR03FT003.mail.protection.outlook.com (100.127.140.227) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 15:45:53 +0000
Received: ("Tessian outbound 6c699027a257:v130");
 Fri, 28 Oct 2022 15:45:53 +0000
Received: from 7f3da2e6fec1.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E8CD2E8E-C38C-4FA8-BCA6-28BD3E07D6A8.1; 
 Fri, 28 Oct 2022 15:45:46 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7f3da2e6fec1.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 28 Oct 2022 15:45:46 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS4PR08MB7530.eurprd08.prod.outlook.com (2603:10a6:20b:4f9::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 28 Oct
 2022 15:45:43 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.014; Fri, 28 Oct 2022
 15:45:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2b98ec6-56d7-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=TkITVSr14HQ+9/OxEDb9PJU6/ue0qyAiSfWt4TbGIZBOvK40plvVG1VTup+oIa9xr1gZhv/oYZGXePAka37WATpcGw/owP0fCWM+BxJRP7B5auk9/X8ogKB9QwXg2q/BbA5+243oA/+EzsVZib5X3nwqRJLPw7xiMvPTaIA7ym5BT9Qlb66kSwsyL6oZ/MxHi7LVWogdoC/LrpiFaI09WJHL2SjYwr7L3dTTSzAUk752rK+JKl7wFUS6P10267C8pKKwzKriT9zfw/RPKjqjniB15CjPXW4iZs+HlHLfxOxFP4HFDuU6YCvtsnEstsRmgsWEY3jtFiQKOItalgWgaA==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+w3AIFOT56xT7gpTwnUOohy02sNHJLZ5KfBpaHLruyc=;
 b=lx1cqDmlgY9A2qmJWoZVhTpWVhi2Tg/Ql9yiHOsm6Itx4s9SU3y8EEsaRojnjNvjXP00SuqMhoSTq1sI8YnSXVIvO6aWQb6m4XbeCc/WoG5Nkm1xpGFIgqKlGaCbVZqmGj1L0tnVxUUhjQZu3LbHmajJ+2PDyEk3uI7Vb/SHZSGCf86ERo7sRC7u7HYY89D/jNrgQtAtbfH6Wznwq5OBIDLDeqUk57RlNG4v18dU/ljPHVL/ChHnzawssMtvn3XxF1a6VELV9rXdmBhJvgYmdYID+eDC5+ifUENGEukL9Bj/0KXz16/zwqrzPkMX8ba2aiKnpjDGPKDHLMB5/QnXgg==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+w3AIFOT56xT7gpTwnUOohy02sNHJLZ5KfBpaHLruyc=;
 b=RHww1MQuZCsb3Cy1M/tIovCmVAd6qcsMyGYRVc8Scpq36FBlWF49Up//bDOngCf+O9UD0oduhYU2wGf+F5BOSZ5hj5rf6wofTRVtq7cZVwPUQA8ZA7Owm143/gK3wrUNV0fSZyH2RpnAMS1fw6X+yb64aBMZwc2WrCF7FwJFEQg=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9fd18cb8ea3e382d
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=K+t3ib1QBi2K3dmjY5ka82Iq9KCWlUp0XE4vpU8n0bm7TMn3/0FfNaIKoh4EhP35/jD1P2p43pgyuHdlfG7zolmclyMMQoWeZMnJIkxESm6J7lL7mAaRgVapqn8OlCzwW/vHJdKs4HT4jIY6c4tY7jA3fSVYV7jDqfBpm9s5z/Is+ZynKcJPAO28cu9ZqCbzB6FoTDJ3eY2ffLGmojUnuGtIBEtxPYvsDwQggIdzeOlRQQJT2zqk8Wo2hXvrQj82dK39OG5irMKDfHdkVMQ62BcDpdIjbGcux2vEX0B5V8xZOfD6ubsy5qTf3clflP0DtaTz6AS6uGOR99Ps/Hwimw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+w3AIFOT56xT7gpTwnUOohy02sNHJLZ5KfBpaHLruyc=;
 b=VC7JDKuRFWfx2pYXYhIIOPxywJ4UekDw8YZUE7q3d8XYTdSp3mziWmcCGOZaRSy70SzQ93+NGELkea+nN0Kz8je/J5D8Jbjd6bVxsIG78lAWa72R3gNzbNHEmGvv+aIki//1ly6OV6GAL+r7DNUf8gKKw1kGJesse04yaEyx+Yjk99SY8RJOn2CBj7YfjmZ52sf7HWPNGoS8abfWbSt8oqR2CfKk3BW/Yn2Jq/8DwXnHkdqBirfL7cV/7i5ylLOasbpXx17KcE5s5FhYfLC7OGZoqNT1abMcfk+SQ7yi/pJ8xX2hsJ4RYgcYgL4Huqs6qC+Xl0v6xWhuGgfydH9x6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+w3AIFOT56xT7gpTwnUOohy02sNHJLZ5KfBpaHLruyc=;
 b=RHww1MQuZCsb3Cy1M/tIovCmVAd6qcsMyGYRVc8Scpq36FBlWF49Up//bDOngCf+O9UD0oduhYU2wGf+F5BOSZ5hj5rf6wofTRVtq7cZVwPUQA8ZA7Owm143/gK3wrUNV0fSZyH2RpnAMS1fw6X+yb64aBMZwc2WrCF7FwJFEQg=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Michal Orzel <Michal.Orzel@arm.com>, Oleksandr
 Tyshchenko <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index:
 AQHY6T1V+gcJbmRqpEyt0b8GeG9bFq4grXIAgAAQCACAAFf9AIABVMyAgAAG64CAAVVJgIAAAzuAgAACBwCAAAPNgIAAE5mAgAAGngCAAAxxAA==
Date: Fri, 28 Oct 2022 15:45:41 +0000
Message-ID: <EED0A9FE-E948-469E-AB30-20BB69A03DD7@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
 <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
 <2981F6DC-444B-49DE-9D01-C0093A32E68F@arm.com>
 <affc51c9-0f8b-b76a-6f23-ec161c967580@xen.org>
In-Reply-To: <affc51c9-0f8b-b76a-6f23-ec161c967580@xen.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS4PR08MB7530:EE_|AM7EUR03FT003:EE_|AS2PR08MB9320:EE_
X-MS-Office365-Filtering-Correlation-Id: b32af9e1-baa1-4dab-68d5-08dab8fb7f02
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 L/mRHBG7dzA6tyzuxgM89QwybtI9HuprkGfG45rU7P3IeRQJHZxjY7XAAhWnPLwWd0KSSXZ0hYfoyBPyNBmwFWvs7Co+3LqqFwgqB2pI5dWU9vJvAkfrP4cuiFrCtp8QRB5SMfNkcx73ezXp3wkIw1pOrBCnvztPECGqU7FSICta6ujHnYPrLXP1ofrt6Kh72nI9UE4V33ajAlnr8PkqdiKfUplOmjm3u5tuCWxpQRvK/ivgtwRoDhUZ4/mPsSvL8ym7CrmVGeVOwSR//n5BrXDQ6b992aqXlytGhWVZ92TJAL18nRHsTvrF0IyCJVd13PJKhUQav79/O3Zx9f94PkLh3TQw3K9bDgbKblijC5XgyBtVM/6QyshzLPi4/0XNqUGUYEuLxKv9vk8vgD7Vfw+uvaD0EzNUWBkxTz4C/MuUdedV1EYhanZ49QoNZ7O9C1ZoGQ9l6nQnKxNJcm1iVIPjo7MqLhpYsV3TgDcg27rMdsLu6wVK9LjKqwkq7oGqPidIJPDDrItAtrvBmdZ0OREgKW3BGsAAVfwMS2UtL9/Xs2+dxDjgyQ3vMH6J7mfvn0skuMDBXyhuaZxOYcVwkLGX7/NRZnfjpmgWKPhd7wdDZJLo/IfeW8tBuWwHsKqwSa0Mr3iWbJV5iw0z/0zGSomUnzUIQJzRHoCYEcuIW99c7MGOfWfUT80kt6gjr9rroiBO1pQFW4rcV+avajgCAY+BWJ2Rhw0xJbNBmaYBGRQhe148j/Pz+OPwcd+h2Jt1bOH45eP3z8ZeGBSHehcE4IE2VDis6WgzorB0lxHPD/I=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199015)(66556008)(8676002)(316002)(86362001)(66946007)(76116006)(64756008)(41300700001)(91956017)(66476007)(4326008)(8936002)(7416002)(36756003)(38070700005)(33656002)(38100700002)(66446008)(122000001)(6512007)(6486002)(186003)(6506007)(54906003)(53546011)(26005)(478600001)(5660300002)(6916009)(2906002)(71200400001)(83380400001)(2616005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <6E724C4EBA618D4197701195E098134B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7530
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c2d5f2ba-7475-47fc-ae57-08dab8fb77ec
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MVniouvfa/fO+oNgxcdMyuiN2+0wr8KmSS3tw2BcyjPlOtXGesQBHgNeXcJp+sxQ+GcnGXpvdUeuDUve72sPT5HQUKnLw2iV83oeIKrHff86mT0jKb+nAeITB4ThhxbIHWSxqlFCBkl4mzhCqOYJQAz3jPxv747bzq2kMWGQV6yXRYi5bLd73osPNmEWlSkfYzXIV2sqhYhL3WdurRNzJ4tRAEM3blDSSNn4iIkHCHZ/IeynYShUfA55qrbtNGPR9wfc8/ZepuADNzavqG+KzSRU0efy3VCkss/yJMBEO1A/TIkkqK9Br3D0nnGmH16QbHwCMqz6w03fwb7FbrG8O2c09D1Uh0U5E5ZBIiRnh7utLU/QSUd7WTUwDbqmWQb1cc/FByrH0nQM9hZ4Un5U0mYP0bZFupLqZannvyerTwIm9eSbvYFe5zG7tnY1ryoDZMvjGqx/YYzsB+KaiHaehK26NCr7vlbSC0CYaZoygvoBW6VvOAcLLykLU1Ws74tSld/oueToZEyvi5ccAHOoTIzOzmlXYrfmv8ccyMip+m7VNzX7ncxnjTUfxEMBrBShGIjWXV23e6cxmxpShYrdWUS4taC1ZAFrzlDqlEHq9gvFfDG5hBJ6lVh9TjvVlo1f1k5uEtwcvu8MvXFx5mQdbqVfzX2k+jPRTSA91yEESAdKl2U/mzqcbgeLxYgfRawAwrRpGzIBp07bWFwM7NwoNkK14CgA4GGaBMXHegWHv4zWMaxX9ty+s2HgjlAH2cSDG3OAcOdDmtqkfg9Az0TkoQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(396003)(346002)(451199015)(40470700004)(46966006)(36840700001)(86362001)(83380400001)(478600001)(6486002)(36756003)(41300700001)(53546011)(2616005)(316002)(8676002)(4326008)(6506007)(6512007)(26005)(107886003)(33656002)(2906002)(6862004)(8936002)(186003)(40460700003)(5660300002)(54906003)(47076005)(40480700001)(336012)(70206006)(70586007)(82310400005)(36860700001)(356005)(81166007)(82740400003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 15:45:53.2887
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b32af9e1-baa1-4dab-68d5-08dab8fb7f02
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9320

SGkgSnVsaWVuLA0KDQo+IE9uIDI4IE9jdCAyMDIyLCBhdCAxNjowMSwgSnVsaWVuIEdyYWxsIDxq
dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9uIDI4LzEwLzIwMjIgMTU6Mzcs
IEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+IA0KPiBIaSBCZXJ0cmFu
ZCwNCj4gDQo+Pj4gT24gMjggT2N0IDIwMjIsIGF0IDE0OjI3LCBKdWxpZW4gR3JhbGwgPGp1bGll
bkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+PiANCj4+PiANCj4+PiBPbiAyOC8xMC8yMDIyIDE0
OjEzLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+PiBIaSBKdWxpZW4sDQo+Pj4gDQo+Pj4g
SGkgQmVydHJhbmQsDQo+Pj4gDQo+Pj4+PiBPbiAyOCBPY3QgMjAyMiwgYXQgMTQ6MDYsIEp1bGll
biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiBIaSBSYWh1bCwN
Cj4+Pj4+IA0KPj4+Pj4gT24gMjgvMTAvMjAyMiAxMzo1NCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+
Pj4+Pj4+Pj4+PiBGb3IgQUNQSSwgSSB3b3VsZCBoYXZlIGV4cGVjdGVkIHRoZSBpbmZvcm1hdGlv
biB0byBiZSBmb3VuZCBpbiB0aGUgSU9SRVEuDQo+Pj4+Pj4+Pj4+PiANCj4+Pj4+Pj4+Pj4+IFNv
IGNhbiB5b3UgYWRkIG1vcmUgY29udGV4dCB3aHkgdGhpcyBpcyBuZWNlc3NhcnkgZm9yIGV2ZXJ5
b25lPw0KPj4+Pj4+Pj4+PiBXZSBoYXZlIGluZm9ybWF0aW9uIGZvciBJT01NVSBhbmQgTWFzdGVy
LUlEIGJ1dCB3ZSBkb27igJl0IGhhdmUgaW5mb3JtYXRpb24gZm9yIGxpbmtpbmcgdk1hc3Rlci1J
RCB0byBwTWFzdGVyLUlELg0KPj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+IEkgYW0gY29uZnVzZWQuIEJl
bG93LCB5b3UgYXJlIG1ha2luZyB0aGUgdmlydHVhbCBtYXN0ZXIgSUQgb3B0aW9uYWwuIFNvIHNo
b3VsZG4ndCB0aGlzIGJlIG1hbmRhdG9yeSBpZiB5b3UgcmVhbGx5IG5lZWQgdGhlIG1hcHBpbmcg
d2l0aCB0aGUgdmlydHVhbCBJRD8NCj4+Pj4+Pj4+IHZNYXN0ZXJJRCBpcyBvcHRpb25hbCBpZiB1
c2VyIGtub3dzIHBNYXN0ZXJJRCBpcyB1bmlxdWUgb24gdGhlIHN5c3RlbS4gQnV0IGlmIHBNYXN0
ZXJJZCBpcyBub3QgdW5pcXVlIHRoZW4gdXNlciBuZWVkcyB0byBwcm92aWRlIHRoZSB2TWFzdGVy
SUQuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBTbyB0aGUgZXhwZWN0YXRpb24gaXMgdGhlIHVzZXIgd2ls
bCBiZSBhYmxlIHRvIGtub3cgdGhhdCB0aGUgcE1hc3RlcklEIGlzIHVuaXEuIFRoaXMgbWF5IGJl
IGVhc3kgd2l0aCBhIGNvdXBsZSBvZiBTTU1VcywgYnV0IGlmIHlvdSBoYXZlIDUwKyAoYXMgc3Vn
Z2VzdGVkIGFib3ZlKS4gVGhpcyB3aWxsIGJlY29tZSBhIHBhaW4gb24gbGFyZ2VyIHN5c3RlbS4N
Cj4+Pj4+Pj4gDQo+Pj4+Pj4+IElITU8sIGl0IHdvdWxkIGJlIG11Y2ggYmV0dGVyIGlmIHdlIGNh
biBkZXRlY3QgdGhhdCBpbiBsaWJ4bCAoc2VlIGJlbG93KS4NCj4+Pj4+PiBXZSBjYW4gbWFrZSB0
aGUgdk1hc3RlcklEIGNvbXB1bHNvcnkgdG8gYXZvaWQgY29tcGxleGl0eSBpbiBsaWJ4bCB0byBz
b2x2ZSB0aGlzDQo+Pj4+PiANCj4+Pj4+IEluIGdlbmVyYWwsIGNvbXBsZXhpdHkgaW4gbGlieGwg
aXMgbm90IHRvbyBtdWNoIG9mIHByb2JsZW0uDQo+Pj4+IEkgYW0gYSBiaXQgdW5zdXJlIGFib3V0
IHRoaXMgc3RyYXRlZ3kuDQo+Pj4+IEN1cnJlbnRseSB4bCBoYXMgb25lIGNvbmZpZ3VyYXRpb24g
ZmlsZSB3aGVyZSB5b3UgcHV0IGFsbCBYZW4gcGFyYW1ldGVycy4gVGhlIGRldmljZSB0cmVlIGlz
IG9ubHkgbmVlZGVkIGJ5IHNvbWUgZ3Vlc3RzIHRvIGhhdmUgYSBkZXNjcmlwdGlvbiBvZiB0aGUg
c3lzdGVtIHRoZXkgcnVuIG9uLg0KPj4+PiBJZiB3ZSBjaGFuZ2UgdGhlIG1vZGVsIGFuZCBzYXkg
dGhhdCBYZW4gY29uZmlndXJhdGlvbiBwYXJhbWV0ZXJzIGFyZSBib3RoIGluIHRoZSBjb25maWd1
cmF0aW9uIGFuZCB0aGUgZGV2aWNlIHRyZWUsIHdlIHNvbWVob3cgZW5mb3JjZSB0byBoYXZlIGEg
ZGV2aWNlIHRyZWUgZXZlbiB0aG91Z2ggc29tZSBndWVzdHMgZG8gbm90IG5lZWQgaXQgYXQgYWxs
IChmb3IgZXhhbXBsZSBaZXBoeXIpLg0KPj4+IA0KPj4+IEkgdGhpbmsgbXkgYXBwcm9hY2ggd2Fz
IG1pc3VuZGVyc3Rvb2QgYmVjYXVzZSB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gdGhlIGV4aXN0aW5n
IG1vZGVsLg0KPj4+IA0KPj4+IFdoYXQgSSBhbSBzdWdnZXN0aW5nIGlzIHRvIG5vdCBpbnRyb2R1
Y2UgaW9tbXVfZGV2aWRfbWFwIGJ1dCBpbnN0ZWFkIGxldCBsaWJ4bCBhbGxvY2F0ZSB0aGUgdmly
dHVhbCBNYXN0ZXItSUQgYW5kIGNyZWF0ZSB0aGUgbWFwcGluZyB3aXRoIHRoZSBwaHlzaWNhbCBN
YXN0ZXItSUQuDQo+Pj4gDQo+Pj4gTGlieGwgd291bGQgdGhlbiB1cGRhdGUgdGhlIHByb3BlcnR5
ICJpb21tdXMiIGluIHRoZSBkZXZpY2UtdHJlZSB3aXRoIHRoZSBhbGxvY2F0ZWQgdmlydHVhbCBN
YXN0ZXItSUQuDQo+PiBPayBJIHVuZGVyc3RhbmQgbm93Lg0KPj4+IA0KPj4+IEVhY2ggbm9kZSBp
biB0aGUgcGFydGlhbCBkZXZpY2UtdHJlZSB3b3VsZCBuZWVkIHRvIGhhdmUgYSBwcm9wZXJ0eQ0K
Pj4+IHRvIHJlZmVyIHRvIHRoZSBwaHlzaWNhbCBkZXZpY2UganVzdCBzbyB3ZSBrbm93IGhvdyB0
byB1cGRhdGUgdGhlICJpb21tdXMiLiBUaGUgbGlzdCBvZiBkZXZpY2UgcGFzc3Rocm91Z2ggd2ls
bCBzdGlsbCBiZSBzcGVjaWZpZWQgaW4gdGhlIGNvbmZpZ3VyYXRpb24gZmlsZS4gSU9XLCB0aGUg
cGFydGlhbCBkZXZpY2UtdHJlZSBpcyBub3QgZGlyZWN0bHkgaW52b2x2ZWQgaW4gdGhlIGNvbmZp
Z3VyYXRpb24gb2YgdGhlIGd1ZXN0Lg0KPj4gQnV0IHdlIHdpbGwgZ2VuZXJhdGUgaXQuIEhvdyB3
b3VsZCBzb21ldGhpbmcgbGlrZSBaZXBoeXIgZ3Vlc3Qgd29yayA/IFplcGh5ciBpcyBub3QgdXNp
bmcgdGhlIGRldmljZSB0cmVlIHdlIHBhc3MsIGl0IGhhcyBhbiBlbWJlZGRlZCBvbmUuDQo+IA0K
PiBJbiBnZW5lcmFsLCBndWVzdCB0aGF0IGRvbid0IHVzZSB0aGUgZGV2aWNlLXRyZWUvQUNQSSB0
YWJsZSB0byBkZXRlY3QgdGhlIGxheW91dCBhcmUgYWxyZWFkeSBpbiBhIGJhZCBzaXR1YXRpb24g
YmVjYXVzZSB3ZSBkb24ndCBndWFyYW50ZWUgdGhhdCB0aGUgbGF5b3V0IChtZW1vcnksIGludGVy
cnVwdC4uLikgd2lsbCBiZSBzdGFibGUgYWNyb3NzIFhlbiB2ZXJzaW9uLiBBbHRob3VnaCwgdGhl
cmUgYXJlIGEgaW1wbGljaXQgYWdyZWVtZW50IHRoYXQgdGhlIGxheW91dCB3aWxsIG5vdCBjaGFu
Z2UgZm9yIG1pbm9yIHJlbGVhc2UgKGkuZS4gNC4xNC54KS4NCg0KV2VsbCByaWdodCBub3cgd2Ug
aGF2ZSBubyBBQ1BJIHN1cHBvcnQuDQpCdXQgSSBzdGlsbCB0aGluayB0aGF0IGEgbm9uIGR0YiBn
dWVzdCBpcyBkZWZpbml0ZWx5IGEgdXNlIGNhc2Ugd2UgbmVlZCB0byBrZWVwIGluIG1pbmQgZm9y
IGVtYmVkZGVkIGFuZCBzYWZldHkgYXMgbW9zdCBwcm9wcmlldGFyeSBSVE9TIGFyZSBub3QgdXNp
bmcgYSBkZXZpY2UgdHJlZS4NCg0KPiANCj4gQnV0IHNlZSBiZWxvdyBmb3Igc29tZSBzdWdnZXN0
aW9ucyBob3cgdGhpcyBjb3VsZCBiZSBoYW5kbGVkLg0KPiANCj4+PiANCj4+PiBTbyBmYXIsIEkg
ZG9uJ3Qgc2VlIGEgcGFydGljdWxhciBpc3N1ZSB3aXRoIHRoaXMgYXBwcm9hY2ggYmVjYXVzZSB0
aGUgdk1hc3RlciBJRCBhbGdvcml0aG0gYWxsb2NhdGlvbiBzaG91bGQgYmUgZ2VuZXJpYy4gQnV0
IHBsZWFzZSBsZXQgbWUga25vdyBpZiB5b3UgdGhpbmsgdGhlcmUgYXJlIGJpdHMgSSBhbSBtaXNz
aW5nLg0KPj4gSSBhbSBhIGJpdCBhZnJhaWQgb2YgdGhpbmdzIHRoYXQgYXJlIOKAnGF1dG9tYXRp
Y+KAnS4NCj4+IEZvciBldmVyeXRoaW5nIGVsc2Ugd2UgbGV0IHRoZSB1c2VyIGluIGNvbnRyb2wg
KElQQSBmb3IgbWFwcGluZywgdmlydHVhbCBpbnRlcnJ1cHQgbnVtYmVyKSBhbmQgaW4gdGhpcyBj
YXNlIHdlIHN3aXRjaCB0byBhIG1vZGVsIHdoZXJlIHdlIGF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVk
IGEgdk1hc3RlciBJRC4NCj4gDQo+IFdlIG9ubHkgbGV0IHRoZSB1c2VyIGNvbnRyb2wgd2hlcmUg
dGhlIGRldmljZSBpcyBtYXBwZWQuIEJ1dCB0aGlzIGlzIHF1aXRlIGZyYWdpbGUuLi4gSSB0aGlu
ayB0aGlzIHNob3VsZCBiZSBnZW5lcmF0ZWQgYXQgcnVudGltZS4NCj4gDQo+PiBXaXRoIHRoaXMg
bW9kZWwsIGd1ZXN0IG5vdCB1c2luZyB0aGUgZGV2aWNlIHRyZWUgd2lsbCBoYXZlIHRvIGd1ZXNz
IHRoZSB2TWFzdGVyIElEIG9yIHNvbWVob3cga25vdyBob3cgdGhlIHRvb2xzIGFyZSBnZW5lcmF0
aW5nIGl0IHRvIHVzZSB0aGUgcmlnaHQgb25lLg0KPiANCj4gVG8gYmUgaG9uZXN0LCB0aGlzIGlz
IGFscmVhZHkgdGhlIGNhc2UgdG9kYXkgYmVjYXVzZSB0aGUgbGF5b3V0IGV4cG9zZWQgdG8gdGhl
IGd1ZXN0IGlzIHRlY2huaWNhbGx5IG5vdCBmaXhlZC4gWWVzLCBzbyBmYXIsIHdlIGhhdmVuJ3Qg
Y2hhbmdlZCBpdCB0b28gbXVjaC4gQnV0IHNvb25lciBvciBsYXRlciwgdGhpcyBpcyBnb2luZyB0
byBiaXRlIGJlY2F1c2Ugd2UgbWFkZSBjbGVhciB0aGF0IHRoZSBsYXlvdXQgaXMgbm90IHN0YWJs
ZS4NCj4gDQo+IE5vdywgaWYgdGhvc2UgcHJvamVjdHMgYXJlIHdpbGxpbmcgdG8gcmVidWlsZCBm
b3IgZWFjaCB2ZXJzaW9uLCB0aGVuIHdlIGNvdWxkIHVzZSB0aGUgZm9sbG93aW5nIGFwcHJvYWNo
Og0KPiAgMSkgV3JpdGUgdGhlIHhsLmNmZw0KPiAgMikgQXNrIGxpYnhsIHRvIGdlbmVyYXRlIHRo
ZSBkZXZpY2UtdHJlZQ0KPiAgMykgQnVpbGQgWmVwaHlyDQo+ICA0KSBDcmVhdGUgdGhlIGRvbWFp
bg0KPiANCj4gVGhlIGV4cGVjdGF0aW9uIGlzIGZvciBhIGdpdmVuIFhlbiB2ZXJzaW9uIChhbmQg
Y29tcGF0aWJsZSksIGxpYnhsIHdpbGwgYWx3YXlzIGdlbmVyYXRlIHRoZSBzYW1lIERldmljZS1U
cmVlLg0KDQpUaGlzIGlzIGEgZ29vZCBpZGVhIHllcyA6LSkNCg0KQ2hlZXJzDQpCZXJ0cmFuZA0K
DQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 16:54:39 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 16:54:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432167.684922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooSck-0001Iq-8Z; Fri, 28 Oct 2022 16:54:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432167.684922; Fri, 28 Oct 2022 16:54:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooSck-0001Ij-5t; Fri, 28 Oct 2022 16:54:26 +0000
Received: by outflank-mailman (input) for mailman id 432167;
 Fri, 28 Oct 2022 16:54:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ToJk=25=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1ooSci-0001Id-HH
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 16:54:24 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2af77dc7-56e1-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 18:54:21 +0200 (CEST)
Received: from DM6PR07CA0081.namprd07.prod.outlook.com (2603:10b6:5:337::14)
 by SJ1PR12MB6170.namprd12.prod.outlook.com (2603:10b6:a03:45b::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Fri, 28 Oct
 2022 16:54:18 +0000
Received: from DM6NAM11FT081.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:337:cafe::9b) by DM6PR07CA0081.outlook.office365.com
 (2603:10b6:5:337::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Fri, 28 Oct 2022 16:54:18 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 DM6NAM11FT081.mail.protection.outlook.com (10.13.172.136) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Fri, 28 Oct 2022 16:54:18 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 11:54:16 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 28 Oct
 2022 11:54:16 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Fri, 28 Oct 2022 11:54:14 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2af77dc7-56e1-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KQ/eUIsvrcW7MXSySOIeyUgRmbiJhD+f5LkY9uHnWPdpFP+ycWl2p4Tk4RzR6B5fnBMdUBTosQ6YUB2YI+vKQXo1Au8el2r/VTQbvYxW5pmPbgi8xWmUyvaZqzxKbEnOiVej73yiEiSASIlMDXVYrLAUn1GtgyhMTGcf6fQZ61Fn4OQpHL+H4/WddxBXPiLHlWvgUy+gAOr0xDJUGE6K/B0/aPzHsbWRywaP7TL2ChZbStTNYruyBR9y2V5fnsdx2VxYV3HNm95zZo5XSIxa7KrWPkH3CEGbEsaNQ3uIknHuzI6qC9Fp02vkO3SB4f+4GY502OO0/hNw1yB7pSo4eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HsiXk5Auw6kSqGXPU3wrfNMKh0U606xi/6ufKiLIiu0=;
 b=mkE+HKpMCmpGDM8O81Ahc9BvagH0qCCgLj9J3xsf0rRBpcV1Y1BTn/UIc/h2gtiX9DR1DqUjA9+6mMFrkC+1IeWZTjW9OpqCdxA1OU+d4xLHQis2HL3gL48r6VP6IwAmfMg+lPESBzXLRCCLL1x+PU9R3daxtQYJBLufqD/ZuXGdpo0kVTLyo6Lj+2Rkbry0zglrTEVuOU/zfQ3qBS/ftIMbqk/ivlzS7zLfdwwKNd4BFl7kDruDcODQduqkAry7VV3s1Z9+rOIPNMH86A3BuRoHrE9FTef7etCiib3ywP+o0+KJ6BrwwHbLFCAZkZvJBWh4u8tMVGN5W8sq7+8vDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HsiXk5Auw6kSqGXPU3wrfNMKh0U606xi/6ufKiLIiu0=;
 b=irK5BhSpdTY0gHWbXvIxe06kj8ErWc0kI6mYhth/4rbCVnnfmAORJwq7XAMqG7Fvv5GiXUk1dfaRTSX/ZY3EKtVI9/1lnHDBsGshJH2ej8iNqfhp5OoK/q4o3rIZma5u/at+0XhhYYbpjJSoPOI5fsGoObVkSLhSuktTaFN+6eY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <b4bfb38c-6b60-e652-b6a0-21b7235f1ad9@amd.com>
Date: Fri, 28 Oct 2022 18:54:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>
CC: Rahul Singh <Rahul.Singh@arm.com>, Xen developer discussion
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Michal Orzel <Michal.Orzel@arm.com>, "Oleksandr
 Tyshchenko" <Oleksandr_Tyshchenko@epam.com>, Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
 <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
 <2981F6DC-444B-49DE-9D01-C0093A32E68F@arm.com>
 <affc51c9-0f8b-b76a-6f23-ec161c967580@xen.org>
 <EED0A9FE-E948-469E-AB30-20BB69A03DD7@arm.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <EED0A9FE-E948-469E-AB30-20BB69A03DD7@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT081:EE_|SJ1PR12MB6170:EE_
X-MS-Office365-Filtering-Correlation-Id: c3381b5c-3c6a-4fee-3f14-08dab9050d9f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oaoOAP7wIAuuBCz8ZFk8XGoJVoKqhkgMSV0EpgQ6C6LswORjjPI/9LbaODkdmialD+ThW0tbRup1OJffxtCHYJOVAjYHHG65rcT9/KYuRopEO6U4bNu0JmOSFxgQqSGyft4GtRQaKHy02rYW9U9E2Fd9VsxsHIc4Jz4WeHeoX8RDNAzEMxhMJyg4Lpcsar20JN27Bv7WobuL2JCH5XvHCa0Wy8E+sXszT4NMRpSnKZQnXuJztXjqAomychJ9tOFN3sbNm+4acJicjuFmLckuOOPlLMf6DXlXUc9V/ltPjcKT+6XWWP7GcJa0DXhiQM2Sh0u1bZ0yREOq3RUpvKzhiIsrOGQSeC1vEDLre9REWPpOli+dDtG1+xKoSye2viMT4dPoVTT28Vyyyp6xpVA6ognyGvIy906AXgFtxe2/Lt7lUCdF1fgigE1LEPpk4B9qfXJg5pPSy0MQpX6nsksQP6D1W+HrVIEy/5OXg193rbU24L1474Il5Y4yL+SOvBPkU3AAR0heZ/EEDAum5RPeGZRCrKoml45uW2dmXaREnIn8X2rQQYC9e7KbR89bTtL5v8niZDrmEIoMfbtj4NeVwlCSJPwReBEnoH6O3vwzGRcKc7yCZwbqrlXfqIj7t0zNx5yLc64x37R+mqoMT+kcFPUq7CarowXsr9xpiSzwP7AbnuUdT6y2NXacfSd8Hv0i/aGXMn+SKERrGpoz5bbeRpqE2YReV2Mboq6PgcAKuaGfbry3JdTlXh18wh27Mn+hIV/f0iHwToEFV71yp+z55JXd8y/zCqD+ahlm0odQmCZorBmJVMr7OcXzLSfgNHWry7Dlzqm6nbwpi/QcOLCJehrY/ChnMDDCnhHT5ow1Jqk=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(16576012)(186003)(316002)(2616005)(356005)(40460700003)(26005)(8676002)(82740400003)(4326008)(40480700001)(31696002)(7416002)(70206006)(41300700001)(36860700001)(86362001)(2906002)(5660300002)(70586007)(44832011)(426003)(47076005)(8936002)(54906003)(966005)(478600001)(336012)(36756003)(110136005)(83380400001)(82310400005)(31686004)(53546011)(81166007)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 16:54:18.0236
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c3381b5c-3c6a-4fee-3f14-08dab9050d9f
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT081.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6170


On 28/10/2022 17:45, Bertrand Marquis wrote:
> 
> 
> Hi Julien,
> 
>> On 28 Oct 2022, at 16:01, Julien Grall <julien@xen.org> wrote:
>>
>>
>>
>> On 28/10/2022 15:37, Bertrand Marquis wrote:
>>> Hi Julien,
>>
>> Hi Bertrand,
>>
>>>> On 28 Oct 2022, at 14:27, Julien Grall <julien@xen.org> wrote:
>>>>
>>>>
>>>>
>>>> On 28/10/2022 14:13, Bertrand Marquis wrote:
>>>>> Hi Julien,
>>>>
>>>> Hi Bertrand,
>>>>
>>>>>> On 28 Oct 2022, at 14:06, Julien Grall <julien@xen.org> wrote:
>>>>>>
>>>>>> Hi Rahul,
>>>>>>
>>>>>> On 28/10/2022 13:54, Rahul Singh wrote:
>>>>>>>>>>>> For ACPI, I would have expected the information to be found in the IOREQ.
>>>>>>>>>>>>
>>>>>>>>>>>> So can you add more context why this is necessary for everyone?
>>>>>>>>>>> We have information for IOMMU and Master-ID but we don’t have information for linking vMaster-ID to pMaster-ID.
>>>>>>>>>>
>>>>>>>>>> I am confused. Below, you are making the virtual master ID optional. So shouldn't this be mandatory if you really need the mapping with the virtual ID?
>>>>>>>>> vMasterID is optional if user knows pMasterID is unique on the system. But if pMasterId is not unique then user needs to provide the vMasterID.
>>>>>>>>
>>>>>>>> So the expectation is the user will be able to know that the pMasterID is uniq. This may be easy with a couple of SMMUs, but if you have 50+ (as suggested above). This will become a pain on larger system.
>>>>>>>>
>>>>>>>> IHMO, it would be much better if we can detect that in libxl (see below).
>>>>>>> We can make the vMasterID compulsory to avoid complexity in libxl to solve this
>>>>>>
>>>>>> In general, complexity in libxl is not too much of problem.
>>>>> I am a bit unsure about this strategy.
>>>>> Currently xl has one configuration file where you put all Xen parameters. The device tree is only needed by some guests to have a description of the system they run on.
>>>>> If we change the model and say that Xen configuration parameters are both in the configuration and the device tree, we somehow enforce to have a device tree even though some guests do not need it at all (for example Zephyr).
>>>>
>>>> I think my approach was misunderstood because there is no change in the existing model.
>>>>
>>>> What I am suggesting is to not introduce iommu_devid_map but instead let libxl allocate the virtual Master-ID and create the mapping with the physical Master-ID.
>>>>
>>>> Libxl would then update the property "iommus" in the device-tree with the allocated virtual Master-ID.
>>> Ok I understand now.
>>>>
>>>> Each node in the partial device-tree would need to have a property
>>>> to refer to the physical device just so we know how to update the "iommus". The list of device passthrough will still be specified in the configuration file. IOW, the partial device-tree is not directly involved in the configuration of the guest.
>>> But we will generate it. How would something like Zephyr guest work ? Zephyr is not using the device tree we pass, it has an embedded one.
>>
>> In general, guest that don't use the device-tree/ACPI table to detect the layout are already in a bad situation because we don't guarantee that the layout (memory, interrupt...) will be stable across Xen version. Although, there are a implicit agreement that the layout will not change for minor release (i.e. 4.14.x).
> 
> Well right now we have no ACPI support.
> But I still think that a non dtb guest is definitely a use case we need to keep in mind for embedded and safety as most proprietary RTOS are not using a device tree.
> 
>>
>> But see below for some suggestions how this could be handled.
>>
>>>>
>>>> So far, I don't see a particular issue with this approach because the vMaster ID algorithm allocation should be generic. But please let me know if you think there are bits I am missing.
>>> I am a bit afraid of things that are “automatic”.
>>> For everything else we let the user in control (IPA for mapping, virtual interrupt number) and in this case we switch to a model where we automatically generated a vMaster ID.
>>
>> We only let the user control where the device is mapped. But this is quite fragile... I think this should be generated at runtime.
>>
>>> With this model, guest not using the device tree will have to guess the vMaster ID or somehow know how the tools are generating it to use the right one.
>>
>> To be honest, this is already the case today because the layout exposed to the guest is technically not fixed. Yes, so far, we haven't changed it too much. But sooner or later, this is going to bite because we made clear that the layout is not stable.
>>
>> Now, if those projects are willing to rebuild for each version, then we could use the following approach:
>>  1) Write the xl.cfg
>>  2) Ask libxl to generate the device-tree
>>  3) Build Zephyr
>>  4) Create the domain
>>
>> The expectation is for a given Xen version (and compatible), libxl will always generate the same Device-Tree.
> 
> This is a good idea yes :-)

Zephyr still uses a device tree but in a static way - everything must be defined in a .dts before building it.
The steps mentioned by Julien are already followed by Zephyr when building it to run as a Xen VM.
You can take a look at the "Updating configuration" section at the bottom of the following site:
https://docs.zephyrproject.org/latest/boards/arm64/xenvm/doc/index.html

So, as we tend to use Zephyr as a de facto RTOS for Xen, it is already aware of possible changes to the layout.

> 
> Cheers
> Bertrand
> 
>>
>> Cheers,
>>
>> --
>> Julien Grall
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 17:32:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 17:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432174.684933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooTDE-0006eN-26; Fri, 28 Oct 2022 17:32:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432174.684933; Fri, 28 Oct 2022 17:32:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooTDD-0006eG-VP; Fri, 28 Oct 2022 17:32:07 +0000
Received: by outflank-mailman (input) for mailman id 432174;
 Fri, 28 Oct 2022 17:32:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooTDD-0006e6-9A; Fri, 28 Oct 2022 17:32:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooTDD-0008EY-6a; Fri, 28 Oct 2022 17:32:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooTDC-0004yI-Mu; Fri, 28 Oct 2022 17:32:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooTDC-00046c-MS; Fri, 28 Oct 2022 17:32:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A/pzQL5afa1GBflt8VyqExreXzs9Ck7wlYAPgB8H66o=; b=QirCiio++3jZkhPsh03+l81L7p
	jm3VEVAlzLIcikeepGNNoc5FvU8/jWI2Vuj2GWR571/TMUFi1+vaD7J9s+aikFEtQdUNT6LO4ubwt
	FnP6Mu8ZYmtqI3u6c4h5FjgQfN6OdiiAIOmGrfERSY0TyKVc087mYwXD2B7A5DmeL8A4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174532-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 174532: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
X-Osstest-Versions-That:
    xen=7abd7bc1626d25ada03c1cff2e8c2ce1a5cc3cbf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 17:32:06 +0000

flight 174532 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174532/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
baseline version:
 xen                  7abd7bc1626d25ada03c1cff2e8c2ce1a5cc3cbf

Last test of basis   174529  2022-10-28 10:01:51 Z    0 days
Testing same since   174532  2022-10-28 15:03:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   7abd7bc162..1d7fbc535d  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 17:57:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 17:57:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432185.684944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooTbu-0001Vg-3t; Fri, 28 Oct 2022 17:57:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432185.684944; Fri, 28 Oct 2022 17:57:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooTbu-0001VZ-01; Fri, 28 Oct 2022 17:57:38 +0000
Received: by outflank-mailman (input) for mailman id 432185;
 Fri, 28 Oct 2022 17:57:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1ooTbs-0001VT-8I
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 17:57:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooTbj-0000BI-LD; Fri, 28 Oct 2022 17:57:27 +0000
Received: from 54-240-197-233.amazon.com ([54.240.197.233]
 helo=[192.168.25.146]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1ooTbj-0007GZ-Do; Fri, 28 Oct 2022 17:57:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=c1XmoAUQj3+jFBnGeB4GeekYFOj+FFZJbONcyLLcspQ=; b=BzQ6U+EN8+ZxedMiAIZIhXOoNY
	ypgoCymcrhksfp5EFZ3UecTWgkETbMjmTzKTr7mkiqEauLe5Yk1vpqx2k9umGEhlflMubWBY0/B+i
	XW5Vq8O/9+RDC1N7oThhM/gD6iMQ4kgVLMqfw4BM/bZXnVFz3debQC/D+lKu395+fVxs=;
Message-ID: <7da20a2e-81e0-b3ad-c2d6-6012fa7edee2@xen.org>
Date: Fri, 28 Oct 2022 18:57:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
 Vikram Garhwal <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org, stefano.stabellini@amd.com,
 Peter Maydell <peter.maydell@linaro.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
 xen-devel@lists.xenproject.org
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-11-vikram.garhwal@amd.com> <87wn8l3d3r.fsf@linaro.org>
Content-Language: en-US
From: Julien Grall <julien@xen.org>
In-Reply-To: <87wn8l3d3r.fsf@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 27/10/2022 09:02, Alex Bennée wrote:
> 
> Vikram Garhwal <vikram.garhwal@amd.com> writes:
> 
> <snip>
>> Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a
>> TPM emulator and connects to swtpm running on host machine via chardev socket
>> and support TPM functionalities for a guest domain.
>>
>> Extra command line for aarch64 xenpv QEMU to connect to swtpm:
>>      -chardev socket,id=chrtpm,path=/tmp/myvtpm2/swtpm-sock \
>>      -tpmdev emulator,id=tpm0,chardev=chrtpm \
>>
>> swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on libtpms and
>> provides access to TPM functionality over socket, chardev and CUSE interface.
>> Github repo: https://github.com/stefanberger/swtpm
>> Example for starting swtpm on host machine:
>>      mkdir /tmp/vtpm2
>>      swtpm socket --tpmstate dir=/tmp/vtpm2 \
>>      --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock &
> 
> <snip>
>> +static void xen_enable_tpm(void)
>> +{
>> +/* qemu_find_tpm_be is only available when CONFIG_TPM is enabled. */
>> +#ifdef CONFIG_TPM
>> +    Error *errp = NULL;
>> +    DeviceState *dev;
>> +    SysBusDevice *busdev;
>> +
>> +    TPMBackend *be = qemu_find_tpm_be("tpm0");
>> +    if (be == NULL) {
>> +        DPRINTF("Couldn't fine the backend for tpm0\n");
>> +        return;
>> +    }
>> +    dev = qdev_new(TYPE_TPM_TIS_SYSBUS);
>> +    object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp);
>> +    object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
>> +    busdev = SYS_BUS_DEVICE(dev);
>> +    sysbus_realize_and_unref(busdev, &error_fatal);
>> +    sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);
> 
> I'm not sure what has gone wrong here but I'm getting:
> 
>    ../../hw/arm/xen_arm.c: In function ‘xen_enable_tpm’:
>    ../../hw/arm/xen_arm.c:120:32: error: ‘GUEST_TPM_BASE’ undeclared (first use in this function); did you mean ‘GUEST_RAM_BASE’?
>      120 |     sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);
>          |                                ^~~~~~~~~~~~~~
>          |                                GUEST_RAM_BASE
>    ../../hw/arm/xen_arm.c:120:32: note: each undeclared identifier is reported only once for each function it appears in
> 
> In my cross build:
> 
>    # Configured with: '../../configure' '--disable-docs' '--target-list=aarch64-softmmu' '--disable-kvm' '--enable-xen' '--disable-opengl' '--disable-libudev' '--enable-tpm' '--disable-xen-pci-passthrough' '--cross-prefix=aarch64-linux-gnu-' '--skip-meson'
> 
> which makes me wonder if this is a configure failure or a confusion
> about being able to have host swtpm implementations during emulation but
> needing target tpm for Xen?

I was also wondering where is that value come from. Note that the 
memory/IRQ layout exposed to the guest is not stable.

Are we expecting the user to rebuild QEMU for every Xen versions (or 
possibly every guest if we ever allow dynamic layout in Xen)?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 18:40:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 18:40:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432196.684955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooUHE-0007h2-86; Fri, 28 Oct 2022 18:40:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432196.684955; Fri, 28 Oct 2022 18:40:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooUHE-0007gv-55; Fri, 28 Oct 2022 18:40:20 +0000
Received: by outflank-mailman (input) for mailman id 432196;
 Fri, 28 Oct 2022 18:40:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUHC-0007gl-I1; Fri, 28 Oct 2022 18:40:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUHC-0000wH-Dv; Fri, 28 Oct 2022 18:40:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUHB-0006jg-Tm; Fri, 28 Oct 2022 18:40:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUHB-0003yc-TN; Fri, 28 Oct 2022 18:40:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=y6JOoQs3zuPJMF0kdi3FNJZ6w4pzI98/BIQDtvNo1OQ=; b=Ns4Q5x2ARCgAtjWIgVyKUWvzDS
	I8kgLSema8KOSFhJ+x5O0DkCULRL5YaYwwz7TyOzb5wGTHE+Rd3Uc7FarnnJKLbc4DpyKKqiq7J5H
	J43R8hNCFuxOhQNcOJw3sZOXoCF7vXDFNlIEATBgoqxaX4F4sLX7UgRuyLizOrijOIzo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174527-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174527: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=de842f37a1d7626c6e2d334f7966d17a75c5a81f
X-Osstest-Versions-That:
    libvirt=a6474cfe4806ef90a4621b509d202b7efd8fd09e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 18:40:17 +0000

flight 174527 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174527/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt   16 saverestore-support-check fail starved in 174490
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 174490
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 174490

version targeted for testing:
 libvirt              de842f37a1d7626c6e2d334f7966d17a75c5a81f
baseline version:
 libvirt              a6474cfe4806ef90a4621b509d202b7efd8fd09e

Last test of basis   174490  2022-10-27 04:18:46 Z    1 days
Testing same since   174527  2022-10-28 04:18:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Martin Kletzander <mkletzan@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Yuri Chornoivan <yurchor@ukr.net>
  김인수 <simmon@nplob.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   a6474cfe48..de842f37a1  de842f37a1d7626c6e2d334f7966d17a75c5a81f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 19:06:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 19:06:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432207.684966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooUgI-0002eZ-Fx; Fri, 28 Oct 2022 19:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432207.684966; Fri, 28 Oct 2022 19:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooUgI-0002eS-D8; Fri, 28 Oct 2022 19:06:14 +0000
Received: by outflank-mailman (input) for mailman id 432207;
 Fri, 28 Oct 2022 19:06:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SnbH=25=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ooUgH-0002eM-98
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 19:06:13 +0000
Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com
 [2607:f8b0:4864:20::102a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 95d08896-56f3-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 21:06:11 +0200 (CEST)
Received: by mail-pj1-x102a.google.com with SMTP id
 z5-20020a17090a8b8500b00210a3a2364fso8601885pjn.0
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 12:06:11 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95d08896-56f3-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=OpySAI0m06R16LGE63jw0ivYx7e/ioZkfJWvMJn/6p4=;
        b=BJ33SXBipARpCCtD2oOUkdM2RwZNIXY+XMUdvUhKqF6VuaQ8miWtNBI/CdPbA7sUta
         oXy7ggplDYDuuUTyNOjOsHDFD9zVN0aKqUY/cewErZBNQcdZTk5TovbXo8pBbzYDTEZf
         9rp+ds87gQHxqbHI3/E3ECAWJ3dklCaqNHM7iJEPXGn1DvXXh/lRT/ghGVM9uRMn9iys
         XPN7XmGEab12vjsbRHdEHg/m0eXr0IeiaUA29O7qFu7kXN2aZXTengiSAgGOFc+izg78
         UkS93zzjWQDa8e9yZusr2WX2jmsR47czjYPH6Y0puT9tbf8JfLhY3G/p9YsjDrdoIDSR
         oyfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=OpySAI0m06R16LGE63jw0ivYx7e/ioZkfJWvMJn/6p4=;
        b=G+5bwF49xuRSGHuNPN+Qg0YijTG+5aWjRTMwboHz0+J8bzPsjJ1hM4wF6w0Lqcs+vT
         YICLkW5Hon8Jd2fwcaIjo1O/JdQuvu/OOyn0O6xgIstKruFAyuSSvZMMDM8a9Lr0JGMV
         bk8tFj8YsceKP/BmQjil92Un9ZWs3kCGvIVMzi3ONfTYHyUNAMbj5PNG3XQXWWR3/nGj
         lVU68mjDYkYAPOGRwYUYLvoYWtHIlMoKkVITGyKavwe9oXAmKekh5IV6EZBP5JRZ8dtM
         eL1MIKbCuggX4dx2hEpd3dWNN6XKXtc9g6WRCPzW2ay//TxkDP5mxjvVvKs0MeNjdxpz
         SyuA==
X-Gm-Message-State: ACrzQf0Sesg6oKYhrZoid0KUcu0vEla+wcaugTDVRv0aKCY67R2VFRww
	CnxYsSvN+O3MnAuTd9XIDeGr9C0Pa0GjT7RNOiM=
X-Google-Smtp-Source: AMsMyM4xKpCtA6doHrBId4kdH/4woxsla2xyPf+PNZF/ENC+dfhwTJMgv3LlYmF2OAn5rSk4ZRzuc0DmTtr8rx9IYqg=
X-Received: by 2002:a17:902:eccc:b0:186:5f09:f9 with SMTP id
 a12-20020a170902eccc00b001865f0900f9mr490806plh.6.1666983970122; Fri, 28 Oct
 2022 12:06:10 -0700 (PDT)
MIME-Version: 1.0
References: <20221015050750.4185-1-vikram.garhwal@amd.com> <20221015050750.4185-11-vikram.garhwal@amd.com>
 <87wn8l3d3r.fsf@linaro.org> <7da20a2e-81e0-b3ad-c2d6-6012fa7edee2@xen.org>
In-Reply-To: <7da20a2e-81e0-b3ad-c2d6-6012fa7edee2@xen.org>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Fri, 28 Oct 2022 22:05:58 +0300
Message-ID: <CAPD2p-nE30z9LosUkO6OdrPnuCaSwi_s2tsfbxgcOyu087tz-w@mail.gmail.com>
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
To: Julien Grall <julien@xen.org>, Vikram Garhwal <vikram.garhwal@amd.com>, stefano.stabellini@amd.com
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, 
	Paul Durrant <paul@xen.org>, "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>, xen-devel@lists.xenproject.org, 
	=?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Content-Type: multipart/alternative; boundary="00000000000062afd005ec1cf34a"

--00000000000062afd005ec1cf34a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 28, 2022 at 8:58 PM Julien Grall <julien@xen.org> wrote:

> Hi,
>

Hello all.

[sorry for the possible format issues]



>
> On 27/10/2022 09:02, Alex Benn=C3=A9e wrote:
> >
> > Vikram Garhwal <vikram.garhwal@amd.com> writes:
> >
> > <snip>
> >> Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device=
,
> adds a
> >> TPM emulator and connects to swtpm running on host machine via chardev
> socket
> >> and support TPM functionalities for a guest domain.
> >>
> >> Extra command line for aarch64 xenpv QEMU to connect to swtpm:
> >>      -chardev socket,id=3Dchrtpm,path=3D/tmp/myvtpm2/swtpm-sock \
> >>      -tpmdev emulator,id=3Dtpm0,chardev=3Dchrtpm \
> >>
> >> swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on
> libtpms and
> >> provides access to TPM functionality over socket, chardev and CUSE
> interface.
> >> Github repo: https://github.com/stefanberger/swtpm
> >> Example for starting swtpm on host machine:
> >>      mkdir /tmp/vtpm2
> >>      swtpm socket --tpmstate dir=3D/tmp/vtpm2 \
> >>      --ctrl type=3Dunixio,path=3D/tmp/vtpm2/swtpm-sock &
> >
> > <snip>
> >> +static void xen_enable_tpm(void)
> >> +{
> >> +/* qemu_find_tpm_be is only available when CONFIG_TPM is enabled. */
> >> +#ifdef CONFIG_TPM
> >> +    Error *errp =3D NULL;
> >> +    DeviceState *dev;
> >> +    SysBusDevice *busdev;
> >> +
> >> +    TPMBackend *be =3D qemu_find_tpm_be("tpm0");
> >> +    if (be =3D=3D NULL) {
> >> +        DPRINTF("Couldn't fine the backend for tpm0\n");
> >> +        return;
> >> +    }
> >> +    dev =3D qdev_new(TYPE_TPM_TIS_SYSBUS);
> >> +    object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp=
);
> >> +    object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
> >> +    busdev =3D SYS_BUS_DEVICE(dev);
> >> +    sysbus_realize_and_unref(busdev, &error_fatal);
> >> +    sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);
> >
> > I'm not sure what has gone wrong here but I'm getting:
> >
> >    ../../hw/arm/xen_arm.c: In function =E2=80=98xen_enable_tpm=E2=80=99=
:
> >    ../../hw/arm/xen_arm.c:120:32: error: =E2=80=98GUEST_TPM_BASE=E2=80=
=99 undeclared
> (first use in this function); did you mean =E2=80=98GUEST_RAM_BASE=E2=80=
=99?
> >      120 |     sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);
> >          |                                ^~~~~~~~~~~~~~
> >          |                                GUEST_RAM_BASE
> >    ../../hw/arm/xen_arm.c:120:32: note: each undeclared identifier is
> reported only once for each function it appears in
> >
> > In my cross build:
> >
> >    # Configured with: '../../configure' '--disable-docs'
> '--target-list=3Daarch64-softmmu' '--disable-kvm' '--enable-xen'
> '--disable-opengl' '--disable-libudev' '--enable-tpm'
> '--disable-xen-pci-passthrough' '--cross-prefix=3Daarch64-linux-gnu-'
> '--skip-meson'
> >
> > which makes me wonder if this is a configure failure or a confusion
> > about being able to have host swtpm implementations during emulation bu=
t
> > needing target tpm for Xen?
>
> I was also wondering where is that value come from. Note that the
> memory/IRQ layout exposed to the guest is not stable.
>
> Are we expecting the user to rebuild QEMU for every Xen versions (or
> possibly every guest if we ever allow dynamic layout in Xen)?
>


This doesn't sound ideal.

I am wondering what would be the correct way here assuming that we would
likely need to have more such information in place for supporting more
use-cases...
For instance, the PCI host bridge emulation in Qemu. Xen toolstack (another
software layer) generates device-tree for the guest, so creates PCI Host
bridge node by using reserved regions from Guest OS interface (arch-arm.h):
- GUEST_VPCI_MEM_ADDR (GUEST_VPCI_MEM_SIZE)
- GUEST_VPCI_ECAM_BASE (GUEST_VPCI_ECAM_SIZE)
- GUEST_VPCI_PREFETCH_MEM_ADDR (GUEST_VPCI_PREFETCH_MEM_SIZE)
https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3Dtools/libs/light/l=
ibxl_arm.c;h=3D2a5e93c28403738779863aded31d2df3ba72f8c0;hb=3DHEAD#l833

Here in Qemu when creating a PCI Host bridge we would need to use exactly
the same reserved regions which toolstack writes in the corresponding
device-tree node. So how to tell Qemu about them?
1. Introduce new cmd line arguments?
2. Using Xenstore?
3. Anything else?

I am afraid this would be related to every device that we want to emulate
in Qemu and for which the toolstack needs to generate device-tree node by
using something defined with GUEST_*, unless I really missed something.



>
> Cheers,
>
> --
> Julien Grall
>
>

--=20
Regards,

Oleksandr Tyshchenko

--00000000000062afd005ec1cf34a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 28, 2022 at 8:58 PM Julie=
n Grall &lt;<a href=3D"mailto:julien@xen.org" target=3D"_blank">julien@xen.=
org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e=
x">Hi,<br></blockquote><div><br></div><div>Hello all.</div><div><br></div><=
div>[sorry for the possible format issues]</div><div><br></div><div>=C2=A0<=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On 27/10/2022 09:02, Alex Benn=C3=A9e wrote:<br>
&gt; <br>
&gt; Vikram Garhwal &lt;<a href=3D"mailto:vikram.garhwal@amd.com" target=3D=
"_blank">vikram.garhwal@amd.com</a>&gt; writes:<br>
&gt; <br>
&gt; &lt;snip&gt;<br>
&gt;&gt; Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-de=
vice, adds a<br>
&gt;&gt; TPM emulator and connects to swtpm running on host machine via cha=
rdev socket<br>
&gt;&gt; and support TPM functionalities for a guest domain.<br>
&gt;&gt;<br>
&gt;&gt; Extra command line for aarch64 xenpv QEMU to connect to swtpm:<br>
&gt;&gt;=C2=A0 =C2=A0 =C2=A0 -chardev socket,id=3Dchrtpm,path=3D/tmp/myvtpm=
2/swtpm-sock \<br>
&gt;&gt;=C2=A0 =C2=A0 =C2=A0 -tpmdev emulator,id=3Dtpm0,chardev=3Dchrtpm \<=
br>
&gt;&gt;<br>
&gt;&gt; swtpm implements a TPM software emulator(TPM 1.2 &amp; TPM 2) buil=
t on libtpms and<br>
&gt;&gt; provides access to TPM functionality over socket, chardev and CUSE=
 interface.<br>
&gt;&gt; Github repo: <a href=3D"https://github.com/stefanberger/swtpm" rel=
=3D"noreferrer" target=3D"_blank">https://github.com/stefanberger/swtpm</a>=
<br>
&gt;&gt; Example for starting swtpm on host machine:<br>
&gt;&gt;=C2=A0 =C2=A0 =C2=A0 mkdir /tmp/vtpm2<br>
&gt;&gt;=C2=A0 =C2=A0 =C2=A0 swtpm socket --tpmstate dir=3D/tmp/vtpm2 \<br>
&gt;&gt;=C2=A0 =C2=A0 =C2=A0 --ctrl type=3Dunixio,path=3D/tmp/vtpm2/swtpm-s=
ock &amp;<br>
&gt; <br>
&gt; &lt;snip&gt;<br>
&gt;&gt; +static void xen_enable_tpm(void)<br>
&gt;&gt; +{<br>
&gt;&gt; +/* qemu_find_tpm_be is only available when CONFIG_TPM is enabled.=
 */<br>
&gt;&gt; +#ifdef CONFIG_TPM<br>
&gt;&gt; +=C2=A0 =C2=A0 Error *errp =3D NULL;<br>
&gt;&gt; +=C2=A0 =C2=A0 DeviceState *dev;<br>
&gt;&gt; +=C2=A0 =C2=A0 SysBusDevice *busdev;<br>
&gt;&gt; +<br>
&gt;&gt; +=C2=A0 =C2=A0 TPMBackend *be =3D qemu_find_tpm_be(&quot;tpm0&quot=
;);<br>
&gt;&gt; +=C2=A0 =C2=A0 if (be =3D=3D NULL) {<br>
&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 DPRINTF(&quot;Couldn&#39;t fine the b=
ackend for tpm0\n&quot;);<br>
&gt;&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return;<br>
&gt;&gt; +=C2=A0 =C2=A0 }<br>
&gt;&gt; +=C2=A0 =C2=A0 dev =3D qdev_new(TYPE_TPM_TIS_SYSBUS);<br>
&gt;&gt; +=C2=A0 =C2=A0 object_property_set_link(OBJECT(dev), &quot;tpmdev&=
quot;, OBJECT(be), &amp;errp);<br>
&gt;&gt; +=C2=A0 =C2=A0 object_property_set_str(OBJECT(dev), &quot;tpmdev&q=
uot;, be-&gt;id, &amp;errp);<br>
&gt;&gt; +=C2=A0 =C2=A0 busdev =3D SYS_BUS_DEVICE(dev);<br>
&gt;&gt; +=C2=A0 =C2=A0 sysbus_realize_and_unref(busdev, &amp;error_fatal);=
<br>
&gt;&gt; +=C2=A0 =C2=A0 sysbus_mmio_map(busdev, 0, GUEST_TPM_BASE);<br>
&gt; <br>
&gt; I&#39;m not sure what has gone wrong here but I&#39;m getting:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 ../../hw/arm/xen_arm.c: In function =E2=80=98xen_enable_t=
pm=E2=80=99:<br>
&gt;=C2=A0 =C2=A0 ../../hw/arm/xen_arm.c:120:32: error: =E2=80=98GUEST_TPM_=
BASE=E2=80=99 undeclared (first use in this function); did you mean =E2=80=
=98GUEST_RAM_BASE=E2=80=99?<br>
&gt;=C2=A0 =C2=A0 =C2=A0 120 |=C2=A0 =C2=A0 =C2=A0sysbus_mmio_map(busdev, 0=
, GUEST_TPM_BASE);<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 ^~~~~~~~~~~~~~<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 GUEST_RAM_BASE<br>
&gt;=C2=A0 =C2=A0 ../../hw/arm/xen_arm.c:120:32: note: each undeclared iden=
tifier is reported only once for each function it appears in<br>
&gt; <br>
&gt; In my cross build:<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 # Configured with: &#39;../../configure&#39; &#39;--disab=
le-docs&#39; &#39;--target-list=3Daarch64-softmmu&#39; &#39;--disable-kvm&#=
39; &#39;--enable-xen&#39; &#39;--disable-opengl&#39; &#39;--disable-libude=
v&#39; &#39;--enable-tpm&#39; &#39;--disable-xen-pci-passthrough&#39; &#39;=
--cross-prefix=3Daarch64-linux-gnu-&#39; &#39;--skip-meson&#39;<br>
&gt; <br>
&gt; which makes me wonder if this is a configure failure or a confusion<br=
>
&gt; about being able to have host swtpm implementations during emulation b=
ut<br>
&gt; needing target tpm for Xen?<br>
<br>
I was also wondering where is that value come from. Note that the <br>
memory/IRQ layout exposed to the guest is not stable.<br>
<br>
Are we expecting the user to rebuild QEMU for every Xen versions (or <br>
possibly every guest if we ever allow dynamic layout in Xen)?<br></blockquo=
te><div><br></div><div><br></div><div>This doesn&#39;t sound ideal.=C2=A0</=
div><div><br></div><div>I am wondering what would be the correct way here a=
ssuming that we would likely need to have more such information in place fo=
r supporting more use-cases...</div><div>For instance, the PCI host bridge =
emulation in Qemu. Xen toolstack (another software layer) generates device-=
tree for the guest, so creates PCI Host bridge node by using reserved regio=
ns from=C2=A0Guest OS interface (arch-arm.h):</div><div>- GUEST_VPCI_MEM_AD=
DR (GUEST_VPCI_MEM_SIZE)<br></div><div>- GUEST_VPCI_ECAM_BASE (GUEST_VPCI_E=
CAM_SIZE)<br></div><div>- GUEST_VPCI_PREFETCH_MEM_ADDR (GUEST_VPCI_PREFETCH=
_MEM_SIZE)<br></div><div><a href=3D"https://xenbits.xen.org/gitweb/?p=3Dxen=
.git;a=3Dblob;f=3Dtools/libs/light/libxl_arm.c;h=3D2a5e93c28403738779863ade=
d31d2df3ba72f8c0;hb=3DHEAD#l833" target=3D"_blank">https://xenbits.xen.org/=
gitweb/?p=3Dxen.git;a=3Dblob;f=3Dtools/libs/light/libxl_arm.c;h=3D2a5e93c28=
403738779863aded31d2df3ba72f8c0;hb=3DHEAD#l833</a><br></div><div><br></div>=
<div>Here in Qemu when creating a PCI Host bridge we would need to use exac=
tly the same reserved regions=C2=A0which toolstack writes in the correspond=
ing device-tree node. So how to tell Qemu about them?=C2=A0</div><div>1. In=
troduce new cmd line arguments?</div><div>2. Using Xenstore?</div><div>3. A=
nything else?</div><div><br></div><div>I am afraid this would be related to=
 every device that we want to emulate in Qemu and for which the toolstack n=
eeds to=C2=A0generate device-tree node=C2=A0by using something defined with=
 GUEST_*, unless I really missed something.</div><div><br></div><div>=C2=A0=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Cheers,<br>
<br>
-- <br>
Julien Grall<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><span style=
=3D"background-color:rgb(255,255,255)"><font size=3D"2"><span style=3D"colo=
r:rgb(51,51,51);font-family:Arial,sans-serif">Regards,</span></font></span>=
</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><div><span style=3D"backg=
round-color:rgb(255,255,255)"><font size=3D"2">Oleksandr Tyshchenko</font><=
/span></div></div></div></div></div></div></div></div>

--00000000000062afd005ec1cf34a--


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 19:10:31 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 19:10:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432212.684976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooUkP-00045N-To; Fri, 28 Oct 2022 19:10:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432212.684976; Fri, 28 Oct 2022 19:10:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooUkP-00045G-Qm; Fri, 28 Oct 2022 19:10:29 +0000
Received: by outflank-mailman (input) for mailman id 432212;
 Fri, 28 Oct 2022 19:10:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUkP-000456-2h; Fri, 28 Oct 2022 19:10:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUkO-0001Rm-VN; Fri, 28 Oct 2022 19:10:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUkO-0007Ok-IX; Fri, 28 Oct 2022 19:10:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooUkO-0003EQ-I2; Fri, 28 Oct 2022 19:10:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=h/Akms7Hglli4L+Ml6sZpQiOwVGlcV+08AzF6ZmYRGQ=; b=nHiSG8a2Q+XLdLPtiMBN9KbI3d
	vdBoSjGhI9i51W0t9hclQmltb8/TvYIkpTAI8gxDsjewBP763aaDPvtCOTyMz0kj1aFWMpWMGjZ/V
	7j7p4U+WFWXelvjBnPBXBeMJ4i49e8ZkCnZP/Xx7dBi2paB6+oDWhUPJE3EB3lRxPZRw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174530-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174530: regressions - trouble: blocked/broken/fail/pass
X-Osstest-Failures:
    linux-5.4:build-armhf:<job status>:broken:regression
    linux-5.4:test-armhf-armhf-xl-vhd:<job status>:broken:regression
    linux-5.4:build-armhf:host-build-prep:fail:regression
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:build-armhf-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:capture-logs(14):broken:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fe18f1af38a7999e05a6564c80d63e8d9df5ee60
X-Osstest-Versions-That:
    linux=fd92cfed8bc6668d314acd1e6da708a80826f768
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 19:10:28 +0000

flight 174530 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174530/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf                     <job status>                 broken
 test-armhf-armhf-xl-vhd         <job status>                 broken  in 174450
 build-armhf                   5 host-build-prep          fail REGR. vs. 174012
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail in 174450 REGR. vs. 174012

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-vhd      13 guest-start      fail in 174450 pass in 174511
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 174511 pass in 174450
 test-armhf-armhf-libvirt-qcow2 13 guest-start    fail in 174511 pass in 174450
 test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10 fail in 174511 pass in 174530
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174511

Tests which did not succeed, but are not blocking:
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-armhf-armhf-examine      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd 14 capture-logs(14) broken in 174450 blocked in 174012
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 174450 like 174012
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 174450 like 174012
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 174450 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 174450 never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 174450 never pass
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174511 blocked in 174012
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174511 like 174012
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 174511 like 174012
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174511 like 174012
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174511 like 174012
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-xl         15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174511 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174012
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174012
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174012
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                fe18f1af38a7999e05a6564c80d63e8d9df5ee60
baseline version:
 linux                fd92cfed8bc6668d314acd1e6da708a80826f768

Last test of basis   174012  2022-10-17 16:21:11 Z   11 days
Testing same since   174450  2022-10-26 11:42:18 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Ahmad Fatoum <a.fatoum@pengutronix.de>
  Albert Briscoe <albertsbriscoe@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Coffin <alex.coffin@matician.com>
  Alexander Dahl <ada@thorsis.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexei Starovoitov <ast@kernel.org>
  Alexey Lyashkov <alexey.lyashkov@gmail.com>
  Allen Pais <apais@linux.microsoft.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Andreas Pape <apape@de.adit-jv.com>
  Andrew Bresticker <abrestic@rivosinc.com>
  Andrew Gaul <gaul@gaul.org>
  Andrew Gaul <gaul@google.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrew Perepechko <anserper@ya.ru>
  Andri Yngvason <andri@yngvason.is>
  Andrii Nakryiko <andrii@kernel.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Anssi Hannula <anssi.hannula@bitwise.fi>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Arvid Norlander <lkml@vorpal.se>
  Baokun Li <libaokun1@huawei.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bernard Metzler <bmt@zurich.ibm.com>
  Bitterblue Smith <rtl8821cerfe2@gmail.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Callum Osmotherly <callum.osmotherly@gmail.com>
  Carlos Llamas <cmllamas@google.com>
  Chao Qin <chao.qin@intel.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wenst@chromium.org>
  Chi-hsien Lin <chi-hsien.lin@cypress.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Chuck Lever <chuck.lever@oracle.com>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Coly Li <colyli@suse.de>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Golle <daniel@makrotopia.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Jiang <dave.jiang@intel.com>
  David Collins <collinsd@codeaurora.org>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  David Teigland <teigland@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <dmitry.osipenko@collabora.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eddie James <eajames@linux.ibm.com>
  Eric Dumazet <edumazet@google.com>
  Eugeniu Rosca <erosca@de.adit-jv.com>
  Fangrui Song <maskray@google.com>
  Fenglin Wu <quic_fenglinw@quicinc.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Haibo Chen <haibo.chen@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Hari Chandrakanthan <quic_haric@quicinc.com>
  Hawkins Jiawei <yin31149@gmail.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hillf Danton <hdanton@sina.com>
  hongao <hongao@uniontech.com>
  Huacai Chen <chenhuacai@loongson.cn>
  Hyunwoo Kim <imv4bel@gmail.com>
  Ian Nam <young.kwan.nam@xilinx.com>
  Ignat Korchagin <ignat@cloudflare.com>
  Ingo Molnar <mingo@kernel.org>
  Jack Wang <jinpu.wang@ionos.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jason Baron <jbaron@akamai.com>
  Jassi Brar <jaswinder.singh@linaro.org>
  Javier Martinez Canillas <javierm@redhat.com>
  Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
  Jens Axboe <axboe@kernel.dk>
  Jerry Lee <jerrylee@qnap.com>
  Jerry Lee 李修賢 <jerrylee@qnap.com>
  Jes Sorensen <Jes.Sorensen@gmail.com>
  Jianglei Nie <niejianglei2021@163.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jim Cromie <jim.cromie@gmail.com>
  Jimmy Assarsson <extja@kvaser.com>
  Jinke Han <hanjinke.666@bytedance.com>
  Jiri Kosina <jkosina@suse.cz>
  Joel Stanley <joel@jms.id.au>
  Joerg Roedel <jroedel@suse.de>
  Johannes Berg <johannes.berg@intel.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Junichi Uekawa <uekawa@chromium.org>
  Kalle Valo <kvalo@kernel.org>
  Kalle Valo <quic_kvalo@quicinc.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Keith Busch <kbusch@kernel.org>
  Kevin(Yudong) Yang <yyd@google.com>
  Khalid Masum <khalid.masum.92@gmail.com>
  Koba Ko <koba.ko@canonical.com>
  Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
  Lalith Rajendran <lalithkraj@google.com>
  Lam Thai <lamthai@arista.com>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Lee Jones <lee@kernel.org>
  Leon Romanovsky <leon@kernel.org>
  Letu Ren <fantasquex@gmail.com>
  Liang He <windhl@126.com>
  Liang Yang <liang.yang@amlogic.com>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Liu Jian <liujian56@huawei.com>
  Logan Gunthorpe <logang@deltatee.com>
  Lorenz Bauer <oss@lmb.io>
  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Luke D. Jones <luke@ljones.dev>
  Lyude Paul <lyude@redhat.com>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Behún <kabel@kernel.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Liska <mliska@suse.cz>
  Masahiro Yamada <masahiroy@kernel.org>
  Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Maya Matuszczyk <maccraft123mc@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Hennerich <michael.hennerich@analog.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Michal Luczaj <mhal@rbox.co>
  Michal Simek <michal.simek@amd.com>
  Mike Pattrick <mkp@redhat.com>
  Mingzhe Zou <mingzhe.zou@easystack.cn>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nam Cao <namcaov@gmail.com>
  Namhyung Kim <namhyung@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Nicolas Dufresne <nicolas.dufresne@collabora.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Ninad Naik <ninad.naik@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Olga Kornievskaia <kolga@netapp.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Ondrej Mosnacek <omosnace@redhat.com>
  Pali Rohár <pali@kernel.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paul Moore <paul@paul-moore.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Oberparleiter <oberpar@linux.ibm.com>
  Peter Robinson <pbrobinson@gmail.com>
  Peter Rosin <peda@axentia.se>
  Peter Xu <peterx@redhat.com>
  Petr Mladek <pmladek@suse.com>
  Phil Sutter <phil@nwl.cc>
  Philipp Hortmann <philipp.g.hortmann@gmail.com>
  Qu Wenruo <wqu@suse.com>
  Quanyang Wang <quanyang.wang@windriver.com>
  Quentin Monnet <quentin@isovalent.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Reinette Chatre <reinette.chatre@intel.com>
  Rich Felker <dalias@libc.org>
  Richard Acayan <mailingradian@gmail.com>
  Richard Weinberger <richard@nod.at>
  Rik van Riel <riel@surriel.com>
  Rob Clark <robdclark@chromium.org>
  Robert Foss <robert.foss@linaro.org>
  Robin Guo <guoweibin@inspur.com>
  Robin Murphy <robin.murphy@arm.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rustam Subkhankulov <subkhankulov@ispras.ru>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Saranya Gopal <saranya.gopal@intel.com>
  Sasha Levin <sashal@kernel.org>
  Saurabh Sengar <ssengar@linux.microsoft.com>
  Sean Christopherson <seanjc@google.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Shawn Guo <shawnguo@kernel.org>
  Sherry Sun <sherry.sun@nxp.com>
  Shigeru Yoshida <syoshida@redhat.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slade Watkins <srw@sladewatkins.net>
  Song Liu <song@kernel.org>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Steffen Klassert <steffen.klassert@secunet.com>
  Stephen Boyd <sboyd@kernel.org>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  sunghwan jung <onenowy@gmail.com>
  Sungwoo Kim <iam@sung-woo.kim>
  syzbot <syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com>
  syzbot+5ec9bb042ddfe9644773@syzkaller.appspotmail.com
  Tadeusz Struk<tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Tales Aparecida <tales.aparecida@gmail.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Thara Gopinath <tgopinath@microsoft.com>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Zimmermann <tzimmermann@suse.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Tzung-Bi Shih <tzungbi@kernel.org>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vinod Koul <vkoul@kernel.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wang Kefeng <wangkefeng.wang@huawei.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wen Gong <quic_wgong@quicinc.com>
  Wenchao Chen <wenchao.chen@unisoc.com>
  William Dean <williamsukatube@gmail.com>
  Wright Feng <wright.feng@cypress.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Qiang <xuqiang36@huawei.com>
  Yonghong Song <yhs@fb.com>
  Yuchung Cheng <ycheng@google.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
  Zheng Yejian <zhengyejian1@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhu Yanjun <yanjun.zhu@linux.dev>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  broken  
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     blocked 
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-armhf broken
broken-job test-armhf-armhf-xl-vhd broken

Not pushing.

(No revision log; it would be 7597 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 19:57:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 19:57:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432224.685000 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooVTd-0001eu-N4; Fri, 28 Oct 2022 19:57:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432224.685000; Fri, 28 Oct 2022 19:57:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooVTd-0001en-Ip; Fri, 28 Oct 2022 19:57:13 +0000
Received: by outflank-mailman (input) for mailman id 432224;
 Fri, 28 Oct 2022 19:57:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooVTc-0001ed-Cr; Fri, 28 Oct 2022 19:57:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooVTc-0002Cw-AG; Fri, 28 Oct 2022 19:57:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooVTb-0008Un-N0; Fri, 28 Oct 2022 19:57:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooVTb-0008Ch-Md; Fri, 28 Oct 2022 19:57:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rUZ/RreR69IdQpVY1ZKOMke2sheO2Uro6ooDbIufXaQ=; b=P5EpF5pvn9xi17+evRNLNSX+b4
	LsDH+3ZwivUSiezTQMINjelkBrYHFv4NrgqLY8qfKg4uPANHGHwQMDaEDCwAR2uXOf9EHGDGsBtVp
	roNSeP5gz2zGWdoZfYM+4FctLmO4wAro4ja0IB4nW/rLLuSx6GWT47uTRwVJR7J7n8bE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174526-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174526: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=20cf0ab774e828dc4e75ecebecf56b53aca754fc
X-Osstest-Versions-That:
    xen=bad4832710c7261fad1abe2d0e8e2e1d259b3e8d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 28 Oct 2022 19:57:11 +0000

flight 174526 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174526/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174499
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174499
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174499
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174499
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174499
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174499
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174499
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174499
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174499
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174499
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174499
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174499
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  20cf0ab774e828dc4e75ecebecf56b53aca754fc
baseline version:
 xen                  bad4832710c7261fad1abe2d0e8e2e1d259b3e8d

Last test of basis   174499  2022-10-27 09:39:43 Z    1 days
Testing same since   174526  2022-10-28 04:10:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Volodymyr Babchuk <volodymyr_babchuk@epam.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   bad4832710..20cf0ab774  20cf0ab774e828dc4e75ecebecf56b53aca754fc -> master


From xen-devel-bounces@lists.xenproject.org Fri Oct 28 20:26:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 28 Oct 2022 20:26:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432231.685011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooVwC-0005qK-13; Fri, 28 Oct 2022 20:26:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432231.685011; Fri, 28 Oct 2022 20:26:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooVwB-0005qD-UX; Fri, 28 Oct 2022 20:26:43 +0000
Received: by outflank-mailman (input) for mailman id 432231;
 Fri, 28 Oct 2022 20:26:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SnbH=25=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1ooVwA-0005q7-S0
 for xen-devel@lists.xenproject.org; Fri, 28 Oct 2022 20:26:43 +0000
Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com
 [2607:f8b0:4864:20::429])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d48ac068-56fe-11ed-8fd0-01056ac49cbb;
 Fri, 28 Oct 2022 22:26:41 +0200 (CEST)
Received: by mail-pf1-x429.google.com with SMTP id e4so5725841pfl.2
 for <xen-devel@lists.xenproject.org>; Fri, 28 Oct 2022 13:26:41 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d48ac068-56fe-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=OXDBbwRSJNCji3jISCvGg1G1iOkeozCcaMRPzPzWFQ8=;
        b=doIPLx0kLWCXHT8iMjLNP+JtDUAVuJgmQ7CzhU8FcE+H8nw0CedGgn3AYpi9MWDo0K
         jmavq23FhbbM7zbsVYWuhF0SQI1grfrQsoXdR6tF1rHiD44jMhudTwV5O8B8uYVuxX3p
         4h3O6veHniM2trJPG0MEOnrGCRCA1wozEnfAvKNBx9hxfIPCDhetrXsoPgQBk2Fk7ios
         /aWTEr7mMeTjm7+xps0/u9zzKeofLYPhz6ZICK4nScoPq9BPrfyQ0X15kLK9QwM5KTD2
         hTVCw4S/nwSLKIOtPTVEc7Og8EJejLv4ADR+jbZdjKPyiaBfUfehA2kq5lQyOskl8b/9
         eVBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=OXDBbwRSJNCji3jISCvGg1G1iOkeozCcaMRPzPzWFQ8=;
        b=sfm4rYC83XhYMkJnSAcrePjsmL5GG3pMpjFDxkYFGnrKm2zMbvYDhbYC9BluOY4g44
         9mtL+gswUCtgA3lNQ2QxAZjKspTUydGcJBvn2kPaf8CyDdvqtHHPl16dC+l0cZIElQYG
         ymfl0AD8enrDCb13o54YrGrHylDIeVFcarfv9LdfRvT5mrnZL/hI6BqoN71pS7aRjsTy
         s7ZGav6CceMFsC7X8/r52DVIsrM/WTNyzGGRfQT9zHu3lv7zgm+TBmEFIRDocWKiBIWm
         pkCDrltlE42vKjEt4yv8J0jtZPZeY4UPgCMDSNaY2N9uKxVOoZkkYyzBJF/7g49nzXLW
         EwYw==
X-Gm-Message-State: ACrzQf0HM/MzLQlNcEwB4FTUgR19npq5Q8WrtzoZcu6WV4895gK9fbZw
	LR/E8Afm8Bm7clAk88Sq/7V+LkbXDl869QD1Pbg=
X-Google-Smtp-Source: AMsMyM4zrYEfDDYckj6NMgHQPAC9dscffKiIflNN9hjZpznv/3MPmKl0sySmXt0fxy8wzOwgRVaaaWMbP6g0SMgLJ0Y=
X-Received: by 2002:a63:e806:0:b0:44b:d45b:b8a2 with SMTP id
 s6-20020a63e806000000b0044bd45bb8a2mr1147699pgh.14.1666988799900; Fri, 28 Oct
 2022 13:26:39 -0700 (PDT)
MIME-Version: 1.0
References: <20221015050750.4185-1-vikram.garhwal@amd.com> <20221015050750.4185-10-vikram.garhwal@amd.com>
 <87pmed1uww.fsf@linaro.org>
In-Reply-To: <87pmed1uww.fsf@linaro.org>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Fri, 28 Oct 2022 23:26:28 +0300
Message-ID: <CAPD2p-=gTqAevPi8-Tq_wkbd+PeVgnLLergmJVLh_eE2HumbGA@mail.gmail.com>
Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state
To: Vikram Garhwal <vikram.garhwal@amd.com>, stefano.stabellini@amd.com
Cc: qemu-devel@nongnu.org, Stefano Stabellini <sstabellini@kernel.org>, 
	Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, 
	=?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, 
	xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="0000000000004340f305ec1e135c"

--0000000000004340f305ec1e135c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 27, 2022 at 12:24 PM Alex Benn=C3=A9e <alex.bennee@linaro.org> =
wrote:

Hello all



> Vikram Garhwal <vikram.garhwal@amd.com> writes:
>
> > xenstore_record_dm_state() will also be used in aarch64 xenpv machine.
> >
> > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> > ---
> >  accel/xen/xen-all.c  | 2 +-
> >  include/hw/xen/xen.h | 2 ++
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
> > index 69aa7d018b..276625b78b 100644
> > --- a/accel/xen/xen-all.c
> > +++ b/accel/xen/xen-all.c
> > @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev
> *chr)
> >  }
> >
> >
> > -static void xenstore_record_dm_state(struct xs_handle *xs, const char
> *state)
> > +void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
> >  {
> >      char path[50];
> >
> > diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
> > index afdf9c436a..31e9538a5c 100644
> > --- a/include/hw/xen/xen.h
> > +++ b/include/hw/xen/xen.h
> > @@ -9,6 +9,7 @@
> >   */
> >
> >  #include "exec/cpu-common.h"
> > +#include <xenstore.h>
>
> This is breaking a bunch of the builds and generally we try and avoid
> adding system includes in headers (apart from osdep.h) for this reason.
> In fact there is a comment just above to that fact.
>
> I think you can just add struct xs_handle to typedefs.h (or maybe just
> xen.h) and directly include xenstore.h in xen-all.c following the usual
> rules:
>
>
> https://qemu.readthedocs.io/en/latest/devel/style.html#include-directives
>
> It might be worth doing an audit to see what else is including xen.h
> needlessly or should be using sysemu/xen.h.
>
> >
> >  /* xen-machine.c */
> >  enum xen_mode {
> > @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);
> >  void xenstore_store_pv_console_info(int i, Chardev *chr);
> >
> >  void xen_register_framebuffer(struct MemoryRegion *mr);
> > +void xenstore_record_dm_state(struct xs_handle *xs, const char *state)=
;
> >
> >  #endif /* QEMU_HW_XEN_H */
>
>
> --
> Alex Benn=C3=A9e
>
>

For considering:
I think this patch and some other changes done in "[PATCH v1 10/12] hw/arm:
introduce xenpv machine" (the opening of Xen interfaces and
calling xenstore_record_dm_state() in hw/arm/xen_arm.c:xen_init_ioreq())
could be avoided if we enable the Xen accelerator (either by passing "-M
xenpv,accel=3Dxen" or by adding mc->default_machine_opts =3D "accel=3Dxen";
to hw/arm/xen_arm.c:xen_arm_machine_class_init() or by some other method).
These actions are already done in accel/xen/xen-all.c:xen_init(). Please
note, that I am not too familiar with that code, so there might be nuances.

Besides that, Xen accelerator will be needed for the xen-mapcache to be in
use (this is needed for mapping guest memory), there are a few
xen_enabled() checks spreading around that code to perform Xen specific
actions.

--=20
Regards,

Oleksandr Tyshchenko

--0000000000004340f305ec1e135c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Oct 27, 2022 at 12:24 PM Alex=
 Benn=C3=A9e &lt;<a href=3D"mailto:alex.bennee@linaro.org" target=3D"_blank=
">alex.bennee@linaro.org</a>&gt; wrote:<br></div><div dir=3D"ltr" class=3D"=
gmail_attr"><br></div><div class=3D"gmail_attr">Hello all</div><div dir=3D"=
ltr" class=3D"gmail_attr"><br></div><div dir=3D"ltr" class=3D"gmail_attr"><=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Vikram Garhwal &lt;<a href=3D"mailto:vikram.garhwal@amd.com" target=3D"_bla=
nk">vikram.garhwal@amd.com</a>&gt; writes:<br>
<br>
&gt; xenstore_record_dm_state() will also be used in aarch64 xenpv machine.=
<br>
&gt;<br>
&gt; Signed-off-by: Vikram Garhwal &lt;<a href=3D"mailto:vikram.garhwal@amd=
.com" target=3D"_blank">vikram.garhwal@amd.com</a>&gt;<br>
&gt; Signed-off-by: Stefano Stabellini &lt;<a href=3D"mailto:stefano.stabel=
lini@amd.com" target=3D"_blank">stefano.stabellini@amd.com</a>&gt;<br>
&gt; ---<br>
&gt;=C2=A0 accel/xen/xen-all.c=C2=A0 | 2 +-<br>
&gt;=C2=A0 include/hw/xen/xen.h | 2 ++<br>
&gt;=C2=A0 2 files changed, 3 insertions(+), 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c<br>
&gt; index 69aa7d018b..276625b78b 100644<br>
&gt; --- a/accel/xen/xen-all.c<br>
&gt; +++ b/accel/xen/xen-all.c<br>
&gt; @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev=
 *chr)<br>
&gt;=C2=A0 }<br>
&gt;=C2=A0 <br>
&gt;=C2=A0 <br>
&gt; -static void xenstore_record_dm_state(struct xs_handle *xs, const char=
 *state)<br>
&gt; +void xenstore_record_dm_state(struct xs_handle *xs, const char *state=
)<br>
&gt;=C2=A0 {<br>
&gt;=C2=A0 =C2=A0 =C2=A0 char path[50];<br>
&gt;=C2=A0 <br>
&gt; diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h<br>
&gt; index afdf9c436a..31e9538a5c 100644<br>
&gt; --- a/include/hw/xen/xen.h<br>
&gt; +++ b/include/hw/xen/xen.h<br>
&gt; @@ -9,6 +9,7 @@<br>
&gt;=C2=A0 =C2=A0*/<br>
&gt;=C2=A0 <br>
&gt;=C2=A0 #include &quot;exec/cpu-common.h&quot;<br>
&gt; +#include &lt;xenstore.h&gt;<br>
<br>
This is breaking a bunch of the builds and generally we try and avoid<br>
adding system includes in headers (apart from osdep.h) for this reason.<br>
In fact there is a comment just above to that fact.<br>
<br>
I think you can just add struct xs_handle to typedefs.h (or maybe just<br>
xen.h) and directly include xenstore.h in xen-all.c following the usual<br>
rules:<br>
<br>
=C2=A0 <a href=3D"https://qemu.readthedocs.io/en/latest/devel/style.html#in=
clude-directives" rel=3D"noreferrer" target=3D"_blank">https://qemu.readthe=
docs.io/en/latest/devel/style.html#include-directives</a><br>
<br>
It might be worth doing an audit to see what else is including xen.h<br>
needlessly or should be using sysemu/xen.h. <br>
<br>
&gt;=C2=A0 <br>
&gt;=C2=A0 /* xen-machine.c */<br>
&gt;=C2=A0 enum xen_mode {<br>
&gt; @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);<br>
&gt;=C2=A0 void xenstore_store_pv_console_info(int i, Chardev *chr);<br>
&gt;=C2=A0 <br>
&gt;=C2=A0 void xen_register_framebuffer(struct MemoryRegion *mr);<br>
&gt; +void xenstore_record_dm_state(struct xs_handle *xs, const char *state=
);<br>
&gt;=C2=A0 <br>
&gt;=C2=A0 #endif /* QEMU_HW_XEN_H */<br>
<br>
<br>
-- <br>
Alex Benn=C3=A9e<br>
<br></blockquote><div><br></div><div><br></div><div>For considering:</div><=
div>I think this patch and some other changes done in &quot;[PATCH v1 10/12=
] hw/arm: introduce xenpv machine&quot; (the opening of Xen interfaces and =
calling=C2=A0xenstore_record_dm_state() in hw/arm/xen_arm.c:xen_init_ioreq(=
))</div><div>could be avoided if we enable the Xen accelerator (either by p=
assing &quot;-M xenpv,accel=3Dxen&quot; or by adding mc-&gt;default_machine=
_opts =3D &quot;accel=3Dxen&quot;; to=C2=A0hw/arm/xen_arm.c:xen_arm_machine=
_class_init() or by some other method).<br></div><div>These actions are alr=
eady done in=C2=A0accel/xen/xen-all.c:xen_init(). Please note, that I am no=
t too familiar with that code, so there might be nuances.=C2=A0<br></div><d=
iv><br></div>Besides that, Xen accelerator will be needed for the xen-mapca=
che to be in use (this is needed for mapping guest memory), there are a few=
 xen_enabled() checks=C2=A0spreading around that code to perform Xen specif=
ic actions.</div><div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><d=
iv><div dir=3D"ltr"><div><div dir=3D"ltr"><span style=3D"background-color:r=
gb(255,255,255)"><font size=3D"2"><span style=3D"color:rgb(51,51,51);font-f=
amily:Arial,sans-serif">Regards,</span></font></span></div><div dir=3D"ltr"=
><br></div><div dir=3D"ltr"><div><span style=3D"background-color:rgb(255,25=
5,255)"><font size=3D"2">Oleksandr Tyshchenko</font></span></div></div></di=
v></div></div></div></div></div>

--0000000000004340f305ec1e135c--


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 00:51:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 00:51:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432240.685021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooa4g-0005FA-4n; Sat, 29 Oct 2022 00:51:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432240.685021; Sat, 29 Oct 2022 00:51:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooa4g-0005F3-24; Sat, 29 Oct 2022 00:51:46 +0000
Received: by outflank-mailman (input) for mailman id 432240;
 Sat, 29 Oct 2022 00:51:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooa4d-0005Et-Sv; Sat, 29 Oct 2022 00:51:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooa4d-0007dx-PT; Sat, 29 Oct 2022 00:51:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooa4d-0000jN-8A; Sat, 29 Oct 2022 00:51:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooa4d-0007bg-7V; Sat, 29 Oct 2022 00:51:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FhJH07rgg4GMAEmyN59oWV5eBjE7vK9EoZf6hzvEU+w=; b=HtMbRR9DqzhmQngTa2AHBC8EV4
	7ZyT5BUbSqP9GjoXEQk01gvpNCgM7TcLwMXuj+vvc4RuSIULMIThRqR50csucMYod1NDUoh3E3rEA
	5Eoy6PSzuwRQUzWqMGBScQgNTgwAKTfqAWZOiWOcbB48/OgtlOQPntBHDjunilOsNa0w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174531-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174531: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=23758867219c8d84c8363316e6dd2f9fd7ae3049
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 00:51:43 +0000

flight 174531 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174531/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                23758867219c8d84c8363316e6dd2f9fd7ae3049
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   21 days
Failing since        173470  2022-10-08 06:21:34 Z   20 days   29 attempts
Testing same since   174531  2022-10-28 12:14:57 Z    0 days    1 attempts

------------------------------------------------------------
1449 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 135977 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 03:00:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 03:00:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432251.685033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooc4r-0002nJ-Ay; Sat, 29 Oct 2022 03:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432251.685033; Sat, 29 Oct 2022 03:00:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooc4r-0002mV-4q; Sat, 29 Oct 2022 03:00:05 +0000
Received: by outflank-mailman (input) for mailman id 432251;
 Sat, 29 Oct 2022 03:00:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooc4q-0002fn-Am; Sat, 29 Oct 2022 03:00:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooc4q-0008Sq-7q; Sat, 29 Oct 2022 03:00:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ooc4p-0000PK-SF; Sat, 29 Oct 2022 03:00:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ooc4p-00021r-Q3; Sat, 29 Oct 2022 03:00:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xgGaI60cjiIiLJCgA2udFbzlrx28gvSM8HpfYlUCTlw=; b=4QfXIrNfTe1m2QbBe2gEH4EVTp
	eE4nByF8VkqJXdePRe4NCA4zZOppStr+qNYzRr9ISAyS9C13rnjoeucMzN0gYAzSylBhBo6mVVLF1
	wobFDI9R5eI2JvR2JlEB/lLUXifdzNWd38I4k6q9F0sad1mVIJ04GJIozrzLvOeF5LmM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174533-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174533: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:build-armhf:<job status>:broken:regression
    linux-5.4:build-armhf:host-build-prep:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
    linux-5.4:build-armhf-libvirt:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-examine:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start.2:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fe18f1af38a7999e05a6564c80d63e8d9df5ee60
X-Osstest-Versions-That:
    linux=fd92cfed8bc6668d314acd1e6da708a80826f768
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 03:00:03 +0000

flight 174533 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174533/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf                     <job status>                 broken  in 174530
 build-armhf                  5 host-build-prep fail in 174530 REGR. vs. 174012

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10 fail in 174511 pass in 174533
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 174511 pass in 174533
 test-armhf-armhf-libvirt-qcow2 13 guest-start    fail in 174511 pass in 174533
 test-armhf-armhf-xl-arndale  18 guest-start/debian.repeat  fail pass in 174511
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174511
 test-armhf-armhf-libvirt-raw 13 guest-start                fail pass in 174511
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 174530
 test-amd64-i386-xl-qemut-debianhvm-amd64  7 xen-install    fail pass in 174530

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt      1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)         blocked in 174530 n/a
 build-armhf-libvirt           1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl           1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-examine      1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)           blocked in 174530 n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)         blocked in 174530 n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)          blocked in 174530 n/a
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 174012
 test-armhf-armhf-xl-credit1  19 guest-start.2           fail blocked in 174012
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174511 like 174012
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174511 like 174012
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174511 like 174012
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174511 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174012
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174012
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat    fail like 174012
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174012
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174012
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174012
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                fe18f1af38a7999e05a6564c80d63e8d9df5ee60
baseline version:
 linux                fd92cfed8bc6668d314acd1e6da708a80826f768

Last test of basis   174012  2022-10-17 16:21:11 Z   11 days
Testing same since   174450  2022-10-26 11:42:18 Z    2 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Ahmad Fatoum <a.fatoum@pengutronix.de>
  Albert Briscoe <albertsbriscoe@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Coffin <alex.coffin@matician.com>
  Alexander Dahl <ada@thorsis.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexei Starovoitov <ast@kernel.org>
  Alexey Lyashkov <alexey.lyashkov@gmail.com>
  Allen Pais <apais@linux.microsoft.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Andreas Pape <apape@de.adit-jv.com>
  Andrew Bresticker <abrestic@rivosinc.com>
  Andrew Gaul <gaul@gaul.org>
  Andrew Gaul <gaul@google.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrew Perepechko <anserper@ya.ru>
  Andri Yngvason <andri@yngvason.is>
  Andrii Nakryiko <andrii@kernel.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Anssi Hannula <anssi.hannula@bitwise.fi>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Arvid Norlander <lkml@vorpal.se>
  Baokun Li <libaokun1@huawei.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bernard Metzler <bmt@zurich.ibm.com>
  Bitterblue Smith <rtl8821cerfe2@gmail.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Callum Osmotherly <callum.osmotherly@gmail.com>
  Carlos Llamas <cmllamas@google.com>
  Chao Qin <chao.qin@intel.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wenst@chromium.org>
  Chi-hsien Lin <chi-hsien.lin@cypress.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Chuck Lever <chuck.lever@oracle.com>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Coly Li <colyli@suse.de>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Golle <daniel@makrotopia.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Jiang <dave.jiang@intel.com>
  David Collins <collinsd@codeaurora.org>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  David Teigland <teigland@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <dmitry.osipenko@collabora.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eddie James <eajames@linux.ibm.com>
  Eric Dumazet <edumazet@google.com>
  Eugeniu Rosca <erosca@de.adit-jv.com>
  Fangrui Song <maskray@google.com>
  Fenglin Wu <quic_fenglinw@quicinc.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Haibo Chen <haibo.chen@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Hari Chandrakanthan <quic_haric@quicinc.com>
  Hawkins Jiawei <yin31149@gmail.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hillf Danton <hdanton@sina.com>
  hongao <hongao@uniontech.com>
  Huacai Chen <chenhuacai@loongson.cn>
  Hyunwoo Kim <imv4bel@gmail.com>
  Ian Nam <young.kwan.nam@xilinx.com>
  Ignat Korchagin <ignat@cloudflare.com>
  Ingo Molnar <mingo@kernel.org>
  Jack Wang <jinpu.wang@ionos.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jason Baron <jbaron@akamai.com>
  Jassi Brar <jaswinder.singh@linaro.org>
  Javier Martinez Canillas <javierm@redhat.com>
  Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
  Jens Axboe <axboe@kernel.dk>
  Jerry Lee <jerrylee@qnap.com>
  Jerry Lee 李修賢 <jerrylee@qnap.com>
  Jes Sorensen <Jes.Sorensen@gmail.com>
  Jianglei Nie <niejianglei2021@163.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jim Cromie <jim.cromie@gmail.com>
  Jimmy Assarsson <extja@kvaser.com>
  Jinke Han <hanjinke.666@bytedance.com>
  Jiri Kosina <jkosina@suse.cz>
  Joel Stanley <joel@jms.id.au>
  Joerg Roedel <jroedel@suse.de>
  Johannes Berg <johannes.berg@intel.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Junichi Uekawa <uekawa@chromium.org>
  Kalle Valo <kvalo@kernel.org>
  Kalle Valo <quic_kvalo@quicinc.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Keith Busch <kbusch@kernel.org>
  Kevin(Yudong) Yang <yyd@google.com>
  Khalid Masum <khalid.masum.92@gmail.com>
  Koba Ko <koba.ko@canonical.com>
  Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
  Lalith Rajendran <lalithkraj@google.com>
  Lam Thai <lamthai@arista.com>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Lee Jones <lee@kernel.org>
  Leon Romanovsky <leon@kernel.org>
  Letu Ren <fantasquex@gmail.com>
  Liang He <windhl@126.com>
  Liang Yang <liang.yang@amlogic.com>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Liu Jian <liujian56@huawei.com>
  Logan Gunthorpe <logang@deltatee.com>
  Lorenz Bauer <oss@lmb.io>
  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Luke D. Jones <luke@ljones.dev>
  Lyude Paul <lyude@redhat.com>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Behún <kabel@kernel.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Liska <mliska@suse.cz>
  Masahiro Yamada <masahiroy@kernel.org>
  Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Maya Matuszczyk <maccraft123mc@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Hennerich <michael.hennerich@analog.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Michal Luczaj <mhal@rbox.co>
  Michal Simek <michal.simek@amd.com>
  Mike Pattrick <mkp@redhat.com>
  Mingzhe Zou <mingzhe.zou@easystack.cn>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nam Cao <namcaov@gmail.com>
  Namhyung Kim <namhyung@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Nicolas Dufresne <nicolas.dufresne@collabora.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Ninad Naik <ninad.naik@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Olga Kornievskaia <kolga@netapp.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Ondrej Mosnacek <omosnace@redhat.com>
  Pali Rohár <pali@kernel.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paul Moore <paul@paul-moore.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Oberparleiter <oberpar@linux.ibm.com>
  Peter Robinson <pbrobinson@gmail.com>
  Peter Rosin <peda@axentia.se>
  Peter Xu <peterx@redhat.com>
  Petr Mladek <pmladek@suse.com>
  Phil Sutter <phil@nwl.cc>
  Philipp Hortmann <philipp.g.hortmann@gmail.com>
  Qu Wenruo <wqu@suse.com>
  Quanyang Wang <quanyang.wang@windriver.com>
  Quentin Monnet <quentin@isovalent.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Reinette Chatre <reinette.chatre@intel.com>
  Rich Felker <dalias@libc.org>
  Richard Acayan <mailingradian@gmail.com>
  Richard Weinberger <richard@nod.at>
  Rik van Riel <riel@surriel.com>
  Rob Clark <robdclark@chromium.org>
  Robert Foss <robert.foss@linaro.org>
  Robin Guo <guoweibin@inspur.com>
  Robin Murphy <robin.murphy@arm.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rustam Subkhankulov <subkhankulov@ispras.ru>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Saranya Gopal <saranya.gopal@intel.com>
  Sasha Levin <sashal@kernel.org>
  Saurabh Sengar <ssengar@linux.microsoft.com>
  Sean Christopherson <seanjc@google.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Shawn Guo <shawnguo@kernel.org>
  Sherry Sun <sherry.sun@nxp.com>
  Shigeru Yoshida <syoshida@redhat.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slade Watkins <srw@sladewatkins.net>
  Song Liu <song@kernel.org>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Steffen Klassert <steffen.klassert@secunet.com>
  Stephen Boyd <sboyd@kernel.org>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  sunghwan jung <onenowy@gmail.com>
  Sungwoo Kim <iam@sung-woo.kim>
  syzbot <syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com>
  syzbot+5ec9bb042ddfe9644773@syzkaller.appspotmail.com
  Tadeusz Struk<tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Tales Aparecida <tales.aparecida@gmail.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Thara Gopinath <tgopinath@microsoft.com>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Zimmermann <tzimmermann@suse.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Tzung-Bi Shih <tzungbi@kernel.org>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vinod Koul <vkoul@kernel.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wang Kefeng <wangkefeng.wang@huawei.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wen Gong <quic_wgong@quicinc.com>
  Wenchao Chen <wenchao.chen@unisoc.com>
  William Dean <williamsukatube@gmail.com>
  Wright Feng <wright.feng@cypress.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Qiang <xuqiang36@huawei.com>
  Yonghong Song <yhs@fb.com>
  Yuchung Cheng <ycheng@google.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
  Zheng Yejian <zhengyejian1@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhu Yanjun <yanjun.zhu@linux.dev>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job build-armhf broken

Not pushing.

(No revision log; it would be 7597 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 05:23:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 05:23:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432268.685044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooeJF-00041s-EK; Sat, 29 Oct 2022 05:23:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432268.685044; Sat, 29 Oct 2022 05:23:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooeJF-00041l-BS; Sat, 29 Oct 2022 05:23:05 +0000
Received: by outflank-mailman (input) for mailman id 432268;
 Sat, 29 Oct 2022 05:23:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wSGY=26=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ooeJE-00041f-1b
 for xen-devel@lists.xenproject.org; Sat, 29 Oct 2022 05:23:04 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2068.outbound.protection.outlook.com [40.107.93.68])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0c0abe2-5749-11ed-8fd0-01056ac49cbb;
 Sat, 29 Oct 2022 07:23:00 +0200 (CEST)
Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23)
 by SA1PR12MB7150.namprd12.prod.outlook.com (2603:10b6:806:2b4::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Sat, 29 Oct
 2022 05:22:54 +0000
Received: from MW3PR12MB4409.namprd12.prod.outlook.com
 ([fe80::6d54:a77f:86e0:6814]) by MW3PR12MB4409.namprd12.prod.outlook.com
 ([fe80::6d54:a77f:86e0:6814%7]) with mapi id 15.20.5769.016; Sat, 29 Oct 2022
 05:22:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0c0abe2-5749-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GAMV7lG9djXXt6P58EKuBL3cZm/5wOcfLmWfx3cDgfQIEbOsxbnbMkZLUOJu/eIKYIDhVCBdHHcI9gU6sNDBwGFqL1j62qTS6Xrjc1VTkZa0IYEjqo7FZF6lDKvvEXb2kBPLfSDRXigB5RhhKitcBv1jQbjhPt+bdPgSCYbOaWqOTlNfqrabEO4NLcRXbT6DpNn/AUVKreleYcI1ChGs4eDSOo+lEmEawvau0/N8jao0h2PHjHjhYigunWTylO3oN99XwmrxLytA1YYVKB+SQvZaKsNCYKcbdx07VJimLkxkXQ5EVoSXKLVKYJuPgPyCnDlBKp1vtxDoqsQGC/UZ4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aTMvdiXwLxmjhJzVVraDj1PpAmt+aoThnAtb5PeZJO8=;
 b=gnNXgL6+2ThrYGGBgJ1Uipjr1Fj65Q52L3EY/hudOW+UXjb7yaptohzj7lCHCLy1YwKdlbd0fRmN0nbyaVXg7tuyginE5/mmOdZ+O83mhOO7vyyJOBmgBYNMgTSsZf7dRwpDtydHJOz+Mm4ITojw9ik6sTgU9lJ3RfzwjGqtHEc+MyqiCrjUtHmfRUNapUGAPLiZi/mAqdyVxanVPrdkRBfdMyuthR+hA+fWVGbn6QNZP1qyCVQENdu01Z5EbSwH9+2468kLHXOUGtq6mzIiwnMSxifAnKcOk9bN6OLlD8Xdn3TLB35XVtvz/HK6Pc71G8ApVrdXKR7VCc95dx7a8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aTMvdiXwLxmjhJzVVraDj1PpAmt+aoThnAtb5PeZJO8=;
 b=DpmnbsAm/o3fTNZxuZvKsqXnDxZt9JEEO8aNY9z/PDdr/yic+3FcIttMYhCYiS/nvK18zlCmqXVZpqVvzuDWldKv6fOfVTqhwTfUbjoTeY06L3vd2Ck4YL9NjTXdJ73W7MofNAcV6+RmuV/EHUlElln57UhDeB1YbFWbhQ39hoI=
From: "Garhwal, Vikram" <vikram.garhwal@amd.com>
To: =?iso-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>
CC: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Stabellini, Stefano"
	<stefano.stabellini@amd.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export
 xenstore_record_dm_state
Thread-Topic: [PATCH v1 09/12] accel/xen/xen-all: export
 xenstore_record_dm_state
Thread-Index: AQHY4FQy+XJKg8lN/EicOL7R8b0Vta4iCG0AgALhTuE=
Date: Sat, 29 Oct 2022 05:22:54 +0000
Message-ID:
 <MW3PR12MB44094F971904ED24E1AC67939F359@MW3PR12MB4409.namprd12.prod.outlook.com>
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-10-vikram.garhwal@amd.com> <87pmed1uww.fsf@linaro.org>
In-Reply-To: <87pmed1uww.fsf@linaro.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MW3PR12MB4409:EE_|SA1PR12MB7150:EE_
x-ms-office365-filtering-correlation-id: 1ca9f194-1c7a-4b82-4eaf-08dab96da201
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 VZHnjk5F+F1PLWRzJWmaDLmcNbCALkUmZKwK4Zt4MO+c9CgelOQ7y6fmtdLCW4frerXryXnb95ntiLMFmxXIaYs+H8Wkk343lbJ2PNghI3q6bjOhOPSHUZH5jW63jae0uNBAaR7qhUyErt89UiMDqWwgJntjYez2az6UKyQAccwdOXielq8u+jWYnQqtJEcWkltFzH490y17vJvGGTlWUkPQ/uzVVhtHU66Yy1mLNyiTL8VJKTQc1tsrtPWgqvHrunsWtrx7rDOEE9ihyZarNXDl8hrm6yyrwNik8U0UKV0oGW6h22DIzpuaBe+685lAjtmL5zbaCi++ji0mlEEJz5GnPsedKetUluwZ+4nUTrrY+nnLx3oaGlavs7A1VPhHoK7IZpfYN6qjhFkCDXzH1jnsQmYWIfc7oW9a/PCzQVOfexdAO7wvOAVwZDtwPeQYYJbVeeG/eeBqQZsgFxalb6iZ3hWLNL8NvRoG0yiU0wyNMyierLUFNmhlDtqwGA2ZdwLU+y9JBuuUzhBo85H4qKqWgDP9+XGOh/v4Jr1pa2SPkSbn27jQNXJh+LMosDsumUae7IWEVABh2/RKQyIeKVmL+L5hMYJIZKShYfGwMYFA2NPA0RPZTREGcrFkoVCwOGq46Fmy0bUTnnUPsEUiUIWbS1oZ5sJp6hs101HX5DVXyAr18VS/PDOqhrqtZcXXIBdmwrSybqDFCV9D9Ej2jA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199015)(33656002)(86362001)(122000001)(38100700002)(38070700005)(166002)(2906002)(83380400001)(55016003)(478600001)(7696005)(26005)(53546011)(6506007)(9686003)(186003)(66574015)(71200400001)(966005)(54906003)(6916009)(316002)(66446008)(64756008)(4326008)(8936002)(66476007)(76116006)(66556008)(66946007)(8676002)(5660300002)(41300700001)(91956017)(52536014);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?X8OAVxtThGquSL5jx1rBcbUg83SHHr3CaQ3c833OoX6P1AiPL6upf0Erza?=
 =?iso-8859-1?Q?LLLpsC//NZpV23ijTF8mfAMWbXGZ1sZ47fumHyHCMpCY8nD5M0qrdY3P8x?=
 =?iso-8859-1?Q?J1Wqf2mDDI5vM6y6ZHyogz3EJwWYrsjUo2cYRteMSU0DWLe92UaN07tHNf?=
 =?iso-8859-1?Q?YVOise+DOTpuR4cPSDT0T1gLHMChVJZjZzhwgDfnNPrQoLFr6lHbIb7flz?=
 =?iso-8859-1?Q?A9oSNzEobryv/1IHM9R3qyiG7gVqLF1jUc6Fz4qHGnnZuRhr3cIEI20OLx?=
 =?iso-8859-1?Q?BxV53qNGKYa1poal6U9p/qjXjEmOWWK2Ejvk1BYKzOuGjMeeL2w84O5G1o?=
 =?iso-8859-1?Q?M/OybM0NRB2EENL3eR8U2UzN1b1aA6B04I+vR67D2NW8PzGY+Ccz2ZssoX?=
 =?iso-8859-1?Q?0zKQ84Jn62531XalEKKC7DIT2DruXd8MbQHEhz//6UF0iZyfOGPFyEGDxc?=
 =?iso-8859-1?Q?pJIbuLJgAqE0p3yoRFYTJNdSmNlyZ9B3GAxnhw2oTx/aomG/b6kD/4pvtP?=
 =?iso-8859-1?Q?33EDjdC2jfTp1WD381+X7dBrAb6+wNFbY5we61eIJhDkEc/DSKuXMT4UMs?=
 =?iso-8859-1?Q?OAQLiqM2+wiaYmhIx3qrYXXUt4kHfip7XccCAcVzfVssIaYkVzq8wm5Lho?=
 =?iso-8859-1?Q?a9ldYG0uh6H/1GZxrp62rCQng/N3X3OckqO1ej9aG7TRu/XFHoc1uYIpH1?=
 =?iso-8859-1?Q?C85uBtmoThIZxQOcT9OTJwQ/fBxxvkXwN5zCuDMrANpDHbQF5T63gIoTQn?=
 =?iso-8859-1?Q?F91ZmYE6Awwc2e/OKJun+3O58xE6qTLZg61spuaxwvnBGUnam/B9QUTxaQ?=
 =?iso-8859-1?Q?MV92YBMLEW/BBVAu0BzPBs2Jgjo+1ZXNlBkQrgLgKudvwaoZQJMu675hvC?=
 =?iso-8859-1?Q?wnWDsK2/jywTwQ8imIzGMU9rz66+j9SsAJhpWZyN9fMsTUttzwvwDTa2ls?=
 =?iso-8859-1?Q?oT9ZfVYA1eWPj5b5V2D0zhvin/ovpbIx2XO7on8Hlr8P8c+B0RJrWmbnv8?=
 =?iso-8859-1?Q?HmdlTFZ68KLKl+hS683h55ZmPC2gnuNC2W1SOF14rQLarbxPRuxKmiAuWe?=
 =?iso-8859-1?Q?VZBu7jlgAswq7xKaaFTUTt9WQ9BGfGWeGzfEcGI1N3MfJG+TBgLvrY4MYk?=
 =?iso-8859-1?Q?0WSUemzUaS3z2Nd/FGXvMxzo+US7iy7MEjtjMFeCwXl2mdHIyHsjLYzi3/?=
 =?iso-8859-1?Q?KVWfyOg4ieJPmz5AtQ4uOfU2AwzOhw7fl/gQLdDBeUwDiGy45lGxWjQXFs?=
 =?iso-8859-1?Q?phFWAXOr0Gw2RsWmaGyiPUYuuTnZNJ9YttHd5d4TbYsh1MsUP+qGUeCqMi?=
 =?iso-8859-1?Q?oT3Sh7Te7Ey/zhEjMFoOoVWTaUnXU4OQmu80JHJVB4Q2m5ltOM3tF1YJQJ?=
 =?iso-8859-1?Q?9hqB0pAdW51Xfg1w9JmYUX8kosDydlP6GSk7Dtg7KWU8P5a1n4V3/cj+YS?=
 =?iso-8859-1?Q?B5Cugk9i89YeGr8xkRQmRsCN1/d6q0hoSpwjZLFV1SLvlHDjkhA/LYz6w+?=
 =?iso-8859-1?Q?MN2DuxaaF//6aVBQprogVKZ48LlgF3SCK2lFG5dSNgOzm+mX093ARenFmq?=
 =?iso-8859-1?Q?chwht3k2ki7tyFTIe6WBBy+1WN/dXpmTnXG8H4EPsxUoFIf1CAylaV+DxP?=
 =?iso-8859-1?Q?RnOPTCDfT9IaDcyRBqYTJDJQMwUyGRAJlC?=
Content-Type: multipart/alternative;
	boundary="_000_MW3PR12MB44094F971904ED24E1AC67939F359MW3PR12MB4409namp_"
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ca9f194-1c7a-4b82-4eaf-08dab96da201
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2022 05:22:54.6758
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YZO0OU+ZRb6zvdRV2eavBzFXBj6pTOYZlS9J0SDzCoa1tTKus1KLaOffzGdAu51ehXPIT0NOh3gCiy5DTIaMvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7150

--_000_MW3PR12MB44094F971904ED24E1AC67939F359MW3PR12MB4409namp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Thanks, Alex, for reviewing this one. I built for all the archs and it was =
fine. Can you please share more about what environment builds are breaking?=
 So, I can test the changes for v2.

Regards,
Vikram

From: Alex Benn=E9e <alex.bennee@linaro.org>
Date: Thursday, October 27, 2022 at 2:24 AM
To: Garhwal, Vikram <vikram.garhwal@amd.com>
Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org>, Stabellini, Stefano <ste=
fano.stabellini@amd.com>, Stefano Stabellini <sstabellini@kernel.org>, Anth=
ony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>, xen-de=
vel@lists.xenproject.org <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_=
state

Vikram Garhwal <vikram.garhwal@amd.com> writes:

> xenstore_record_dm_state() will also be used in aarch64 xenpv machine.
>
> Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> ---
>  accel/xen/xen-all.c  | 2 +-
>  include/hw/xen/xen.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
> index 69aa7d018b..276625b78b 100644
> --- a/accel/xen/xen-all.c
> +++ b/accel/xen/xen-all.c
> @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev *c=
hr)
>  }
>
>
> -static void xenstore_record_dm_state(struct xs_handle *xs, const char *s=
tate)
> +void xenstore_record_dm_state(struct xs_handle *xs, const char *state)
>  {
>      char path[50];
>
> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
> index afdf9c436a..31e9538a5c 100644
> --- a/include/hw/xen/xen.h
> +++ b/include/hw/xen/xen.h
> @@ -9,6 +9,7 @@
>   */
>
>  #include "exec/cpu-common.h"
> +#include <xenstore.h>

This is breaking a bunch of the builds and generally we try and avoid
adding system includes in headers (apart from osdep.h) for this reason.
In fact there is a comment just above to that fact.

I think you can just add struct xs_handle to typedefs.h (or maybe just
xen.h) and directly include xenstore.h in xen-all.c following the usual
rules:

  https://qemu.readthedocs.io/en/latest/devel/style.html#include-directives

It might be worth doing an audit to see what else is including xen.h
needlessly or should be using sysemu/xen.h.

>
>  /* xen-machine.c */
>  enum xen_mode {
> @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);
>  void xenstore_store_pv_console_info(int i, Chardev *chr);
>
>  void xen_register_framebuffer(struct MemoryRegion *mr);
> +void xenstore_record_dm_state(struct xs_handle *xs, const char *state);
>
>  #endif /* QEMU_HW_XEN_H */


--
Alex Benn=E9e

--_000_MW3PR12MB44094F971904ED24E1AC67939F359MW3PR12MB4409namp_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc=
hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of=
fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	font-size:10.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
span.EmailStyle19
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style>
</head>
<body lang=3D"EN-US" link=3D"blue" vlink=3D"purple" style=3D"word-wrap:brea=
k-word">
<div class=3D"WordSection1">
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt">Thanks, Alex, for r=
eviewing this one. I built for all the archs and it was fine. Can you pleas=
e share more about what environment builds are breaking? So, I can test the=
 changes for v2.<o:p></o:p></span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt"><o:p>&nbsp;</o:p></=
span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt">Regards,<o:p></o:p>=
</span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt">Vikram<o:p></o:p></=
span></p>
<p class=3D"MsoNormal"><span style=3D"font-size:11.0pt"><o:p>&nbsp;</o:p></=
span></p>
<div style=3D"border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in =
0in 0in">
<p class=3D"MsoNormal" style=3D"mso-margin-top-alt:0in;margin-right:0in;mar=
gin-bottom:12.0pt;margin-left:.5in">
<b><span style=3D"font-size:12.0pt;color:black">From: </span></b><span styl=
e=3D"font-size:12.0pt;color:black">Alex Benn=E9e &lt;alex.bennee@linaro.org=
&gt;<br>
<b>Date: </b>Thursday, October 27, 2022 at 2:24 AM<br>
<b>To: </b>Garhwal, Vikram &lt;vikram.garhwal@amd.com&gt;<br>
<b>Cc: </b>qemu-devel@nongnu.org &lt;qemu-devel@nongnu.org&gt;, Stabellini,=
 Stefano &lt;stefano.stabellini@amd.com&gt;, Stefano Stabellini &lt;sstabel=
lini@kernel.org&gt;, Anthony Perard &lt;anthony.perard@citrix.com&gt;, Paul=
 Durrant &lt;paul@xen.org&gt;, xen-devel@lists.xenproject.org
 &lt;xen-devel@lists.xenproject.org&gt;<br>
<b>Subject: </b>Re: [PATCH v1 09/12] accel/xen/xen-all: export xenstore_rec=
ord_dm_state<o:p></o:p></span></p>
</div>
<div>
<p class=3D"MsoNormal" style=3D"margin-left:.5in"><span style=3D"font-size:=
11.0pt"><br>
Vikram Garhwal &lt;vikram.garhwal@amd.com&gt; writes:<br>
<br>
&gt; xenstore_record_dm_state() will also be used in aarch64 xenpv machine.=
<br>
&gt;<br>
&gt; Signed-off-by: Vikram Garhwal &lt;vikram.garhwal@amd.com&gt;<br>
&gt; Signed-off-by: Stefano Stabellini &lt;stefano.stabellini@amd.com&gt;<b=
r>
&gt; ---<br>
&gt;&nbsp; accel/xen/xen-all.c&nbsp; | 2 +-<br>
&gt;&nbsp; include/hw/xen/xen.h | 2 ++<br>
&gt;&nbsp; 2 files changed, 3 insertions(+), 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c<br>
&gt; index 69aa7d018b..276625b78b 100644<br>
&gt; --- a/accel/xen/xen-all.c<br>
&gt; +++ b/accel/xen/xen-all.c<br>
&gt; @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i, Chardev=
 *chr)<br>
&gt;&nbsp; }<br>
&gt;&nbsp; <br>
&gt;&nbsp; <br>
&gt; -static void xenstore_record_dm_state(struct xs_handle *xs, const char=
 *state)<br>
&gt; +void xenstore_record_dm_state(struct xs_handle *xs, const char *state=
)<br>
&gt;&nbsp; {<br>
&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; char path[50];<br>
&gt;&nbsp; <br>
&gt; diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h<br>
&gt; index afdf9c436a..31e9538a5c 100644<br>
&gt; --- a/include/hw/xen/xen.h<br>
&gt; +++ b/include/hw/xen/xen.h<br>
&gt; @@ -9,6 +9,7 @@<br>
&gt;&nbsp;&nbsp; */<br>
&gt;&nbsp; <br>
&gt;&nbsp; #include &quot;exec/cpu-common.h&quot;<br>
&gt; +#include &lt;xenstore.h&gt;<br>
<br>
This is breaking a bunch of the builds and generally we try and avoid<br>
adding system includes in headers (apart from osdep.h) for this reason.<br>
In fact there is a comment just above to that fact.<br>
<br>
I think you can just add struct xs_handle to typedefs.h (or maybe just<br>
xen.h) and directly include xenstore.h in xen-all.c following the usual<br>
rules:<br>
<br>
&nbsp; <a href=3D"https://qemu.readthedocs.io/en/latest/devel/style.html#in=
clude-directives">
https://qemu.readthedocs.io/en/latest/devel/style.html#include-directives</=
a><br>
<br>
It might be worth doing an audit to see what else is including xen.h<br>
needlessly or should be using sysemu/xen.h. <br>
<br>
&gt;&nbsp; <br>
&gt;&nbsp; /* xen-machine.c */<br>
&gt;&nbsp; enum xen_mode {<br>
&gt; @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);<br>
&gt;&nbsp; void xenstore_store_pv_console_info(int i, Chardev *chr);<br>
&gt;&nbsp; <br>
&gt;&nbsp; void xen_register_framebuffer(struct MemoryRegion *mr);<br>
&gt; +void xenstore_record_dm_state(struct xs_handle *xs, const char *state=
);<br>
&gt;&nbsp; <br>
&gt;&nbsp; #endif /* QEMU_HW_XEN_H */<br>
<br>
<br>
-- <br>
Alex Benn=E9e<o:p></o:p></span></p>
</div>
</div>
</body>
</html>

--_000_MW3PR12MB44094F971904ED24E1AC67939F359MW3PR12MB4409namp_--


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 05:37:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 05:37:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432272.685055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooeX0-00066W-MN; Sat, 29 Oct 2022 05:37:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432272.685055; Sat, 29 Oct 2022 05:37:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooeX0-00066P-JD; Sat, 29 Oct 2022 05:37:18 +0000
Received: by outflank-mailman (input) for mailman id 432272;
 Sat, 29 Oct 2022 05:37:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wSGY=26=amd.com=vikram.garhwal@srs-se1.protection.inumbo.net>)
 id 1ooeWz-00066J-RS
 for xen-devel@lists.xenproject.org; Sat, 29 Oct 2022 05:37:17 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id be9c9f52-574b-11ed-8fd0-01056ac49cbb;
 Sat, 29 Oct 2022 07:37:16 +0200 (CEST)
Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23)
 by SA0PR12MB4589.namprd12.prod.outlook.com (2603:10b6:806:92::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sat, 29 Oct
 2022 05:37:10 +0000
Received: from MW3PR12MB4409.namprd12.prod.outlook.com
 ([fe80::6d54:a77f:86e0:6814]) by MW3PR12MB4409.namprd12.prod.outlook.com
 ([fe80::6d54:a77f:86e0:6814%7]) with mapi id 15.20.5769.016; Sat, 29 Oct 2022
 05:37:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be9c9f52-574b-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h79VgrUk/yqhewfGbzHBByIp7dtZm31WydBCUufA304AYjEeg238lC8ra6a6sruGHYd/aact09nka1Y2k4CvOpv1Anq57slZXSvSsK3OcuH8VCKWpCVFzSln528rHMECjnWEPI6v+IRZLEKLlVUGRVkvnG0qHL7FQMDfB2t6z9KeqKxYTNjct8YcWQHH9sKjHRR/j5d+uEJVYjzFH3k4/h42lYbuvEUC7B9ekg1LsCwjkuHUUJtzxgD6A12+o6Au0iOwBxZLNZrrPIUM5VS729Rrc5nyb0pVZ8EJHBwAvV3up/0QTrXKUIJ7vo2ElPNnWlOe60zkVLtpuf1apjCxCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yAZfOlArbuKXJhaY3JUE9hUW9sR5OF62WoBXcVnF9QE=;
 b=ilyZnRkO80a/HM2S6kN7r2LKPSFgzbkOIZJpkFDrop3fUpxE9n99iWT1RZ8sdM8Zy12k2lbdR6LwdEfU3JUcjxfBeYwnMUjQfWuU9btszLp4lvLYEcBC+Wr0+LhW1Q+Ya0eMaXAAWs1mKwVoNA+ivvrEUv5qj0NY7XhLJMP8C4zWtFqUVOWZTxIJ7LOwj04NLIcOzTAPXvnCiYpEO98SxS5WXESbAsA7ADc0Bf3z2cpHWQdoXEy6QVq30nP75zXh65BVS4mxqFpMZ7DTq0QiB5g8SiKBWfL/igak1ZBwCLLQAP5FzuY7gE5h1QiTNGL7FZaP/kFyW1GZSMp3zpJfwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yAZfOlArbuKXJhaY3JUE9hUW9sR5OF62WoBXcVnF9QE=;
 b=df5uTL0QvUADzHe/a7RoZWXlbYAgCVAqUNZKoiftKLO8yPzd7CUDfyCAbGQcn44g4lfVQOaoq0o1N723QARHmmDq3Ojd/PNGyyhG1v34tbyax8Ck/ZpEA4Yctwj4uEhalxkG78Ccb9LNUJufIC/PiM9l9gYVCAaP38dPORGeuUE=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Message-ID: <2d7b110f-5d14-9067-bc3c-99951d4bdcdc@amd.com>
Date: Fri, 28 Oct 2022 22:36:47 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH v1 09/12] accel/xen/xen-all: export
 xenstore_record_dm_state
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, stefano.stabellini@amd.com
Cc: qemu-devel@nongnu.org, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
 xen-devel@lists.xenproject.org
References: <20221015050750.4185-1-vikram.garhwal@amd.com>
 <20221015050750.4185-10-vikram.garhwal@amd.com> <87pmed1uww.fsf@linaro.org>
 <CAPD2p-=gTqAevPi8-Tq_wkbd+PeVgnLLergmJVLh_eE2HumbGA@mail.gmail.com>
From: Vikram Garhwal <vikram.garhwal@amd.com>
In-Reply-To: <CAPD2p-=gTqAevPi8-Tq_wkbd+PeVgnLLergmJVLh_eE2HumbGA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: BMXPR01CA0075.INDPRD01.PROD.OUTLOOK.COM
 (2603:1096:b00:54::15) To MW3PR12MB4409.namprd12.prod.outlook.com
 (2603:10b6:303:2d::23)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|SA0PR12MB4589:EE_
X-MS-Office365-Filtering-Correlation-Id: f5aa6df1-85b1-4897-9d65-08dab96f9fe8
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U5xyl3rmg3oLy/gz9QD6RcpunKeCcK4+/pThJ1snMHOM7jjRHzugoUY2w6IZJcxKSepjtqtH/eThsqutRxWXeyRCFT3XVsVifK196BF+bHC0DEp3xese95OO7o1qc7aQKL4iq9k9UaNP1qHLnUutx10ThbQ3VfFrxI2mfnciQYJmjB3q7DfA5p81WVz/WRe+klxiwaLn1kG4mEFet8xOCglrQ+xaB6H32gXPJ1FuFGd4FOR5LGxz6MaOLOj/nhg2MSWpFptrUlhhcn9ePTCJi8yljhw2Qi+lUxhXx5nM4dmyhr1GUBn15FrXNz4KUW0Qe0KA/nK0wmEp+Bzbfs1SWqUeU82I6it5MoorAaG0TgTWZsziADhJsuu2+U/7nU3G2IzhfR02yr/HDu1WUEi1Zp+qw4FtXQZ83BnzdgkGLVRNBqVmiepyi7ct6agJRJvzoC/cnPEnQ9Lig4Yac3gf3m+lHzXIKmzt2JIVH+gDvj+2EkuIT1X8L70AjT/yFcITgZevmp0Jlb2B7Gk0wfSX9T3h+qIJAwHuiFGnKKQuqGd0+yOrjyXpguv0WkKJjSDSh2yjUrb/6U0Crnq7BeC0Nkf/Xm482scpV2LHJRgVgebY2hmbCRi2dJUl8sv1DVsL3C1MJhOl2IHibBKN/aAFFTA7O5OJ54FOOZReNz5hB+Uq0mhy7Wlb9T4NTbkLp4kfCV4129hKLTRkCPXtX/fk7cpgbrLeKIaqil4DOvfczSE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199015)(6512007)(26005)(6506007)(53546011)(186003)(2616005)(36756003)(6486002)(966005)(6666004)(316002)(6636002)(478600001)(54906003)(86362001)(31696002)(66574015)(83380400001)(38100700002)(31686004)(2906002)(66476007)(66556008)(8676002)(4326008)(41300700001)(66946007)(44832011)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2NPcmgyVG9KR0hlRkR5OEhKUjc3Yk8zSkhvYTV4a1ZJUVRueUN0clRKUmc0?=
 =?utf-8?B?eEJUVXdGaHVKaW1aV2U5d0RWZDNVRlcvZEtTb3dsTVFMWTNjU1lDdlRub0s3?=
 =?utf-8?B?d2NhdVAweFR4NmZvT3RGQmhNNWlDTkVsczl3dGZES1NxKzRFRk5ITHI3Z1hq?=
 =?utf-8?B?M09yc0Z1RDlGczRZV2U5WHQ1dThUNElxclVZMkVuZDBpVTFJSFg1ai9kSWxU?=
 =?utf-8?B?Q25DcFV1aXJFWlMwUEJ2THFVQmZoY1E2amhvZkx2RElkSm85aXBqRmpYemNT?=
 =?utf-8?B?V1JyQlExeXlFMEwrdUd1RytzWXFua1ZPc28yRWVHZC83Ri9TRGVIUzI3VG5Q?=
 =?utf-8?B?Q2M5alJnNnlLWFlwNkdlVCs5d3hWYkNvWHQxeUVjVUNOdVhybkE2M0VOL3pw?=
 =?utf-8?B?WTFVdUEwbkdaY2VhZHJETUZ6bHJTMFk3M3pNUFlRS0RDR1o5QURsMDhZbUcv?=
 =?utf-8?B?TnpNWXdBRnFEMFRYR25wS3ZxYzR3a2RhZmhtc3czQ29la3krcmRjL29WeS9X?=
 =?utf-8?B?OGJ0MlUxbmJjNEgzMXV6Q050WHRJUm9YRjlreTZRR2JDaDlsZnAweXNrVVA5?=
 =?utf-8?B?bDNoWWYzc2ppUGhjaktwcUtTRWNVWnY2ekJYdjQzTFZBamM2Nld0RS90UlpY?=
 =?utf-8?B?UGNDZ0l5dHJkVk50RFdrUmJXWlBkWEIrZlhyNzRCejhCYVQ3TlFFRnpOUzgv?=
 =?utf-8?B?UHFRT0tScjlOTlFDWnNHNUxWdFVDMHhBTEVLQXR5ZzFKUkFRUXJtWjloZE11?=
 =?utf-8?B?eVV2Vkd6cUc3RDNGU3RKbjVRS0xMYU9iNlFPZXBEYVFrK0c0NnhyQTlkMFlD?=
 =?utf-8?B?RzBnSDdpWDNOSEtEN082SFo5MnBkOGtVa3diK0pXbEpXSU5nZGYzMnBScVA1?=
 =?utf-8?B?TnVGQXVMNXZNQVRGMW5WWUUrRHlHOFFIQnU2UERhdkZLNEhFZlI5Z282OVd5?=
 =?utf-8?B?dDdXbVc5UFhPNFNKcGZGb0YzNDFnbXowS094akhsWEN3VU1ERy85NVRzclVY?=
 =?utf-8?B?MmVTcnRERVBwZWFpSGwvSzRJbnBHakVKT0FuMXhHa0NwMzMxOTZ4YVZjMzh1?=
 =?utf-8?B?ak9NY1pzazd2UEdvWGg4RCtoUktPVGpwTVJMeFQ2K1Z6NC9jRUVwUVF3V3Ft?=
 =?utf-8?B?b0lMcElnVjNiZUtoNjg0K2sxd0gvaVM5ckNQNFpQVlVKT2FvUSswZENCUWxs?=
 =?utf-8?B?Q3BqL0FUcXVaQkk2UUVYc0d6MEdxUXNIY09MSWppN25TTFN3VXZ5U3FMV3cr?=
 =?utf-8?B?c1VCMEYrTkFLUnUzNlVyb2hRc2ZaWjFyU2tsWFlvci9zdzFTRVdYRk5nWmJW?=
 =?utf-8?B?QU02R3BkNkZsQmJ4MWtiSzdnOEJqOElzYWlkSzU1MVNtNGFLMGZvcitaQWpy?=
 =?utf-8?B?YmYxMExGWk9Jc1RwUWd3eWY0aHB3RXloekNhNEErbWhtRTVrWkp3M3QzYkNo?=
 =?utf-8?B?MVgvdGlIYm9HZlQwazZLMWxkYXhxQ1Zrc1A1akxobmllbHBjK0tDdFNPUjVU?=
 =?utf-8?B?TUdTQWg4VlpKdEVMMU1uc3JnNTNVS1BqZE43OXRvdG5vdFoxOURvSkVvcFo4?=
 =?utf-8?B?akQ3aEpmOWYycTdoVkF2dWNqUzRMVTZSbldCbkhtZjV5MU0zY1V4ZEswMUtx?=
 =?utf-8?B?Rmt0SjRhbmN4elVhUUc5VDBPVkwxdEQvNWplUWVuK0xDd1oyOTF2bkdIWExz?=
 =?utf-8?B?TFdvUzQ1eVVBbitRUndaUzFTSVY4S25GUy9TTmlHSzJ5d1BXRjRTdHFGZlZy?=
 =?utf-8?B?UnREejZKV0x4ZHNWSTRrdGcwdldFbGo2SzI4dlFMay9xNnlQZStDUE1TS0F6?=
 =?utf-8?B?ZUZXa3ZiL28xZkJidk1Ja0oveGFHQisvMjZOcDVKUWdkaW4rOHVZS1JVQitE?=
 =?utf-8?B?MGlWN1l5TW9pZkcrYmtheVhremJZcFl3RkhVSUFTZGs2QlVxV3VCRjFGTWh6?=
 =?utf-8?B?ZmprQ1JibmdPWmlvZ2lEVHRZYktqZFdHbGtnamc0VEFYTmNyMDVzUjJIOXpG?=
 =?utf-8?B?Sm95Y3lWSk5oaDRUbU9aRUVwMk9BMThhdS9aamx4eG4rblhiVlZWbkErOFlx?=
 =?utf-8?B?V3lrd0tkc2xWUWxwRVl2WkNHeTA4SmZtZUR6aGtGQ21rWXkrT1ByMUl0RXlI?=
 =?utf-8?Q?0LQwOj2OOMrboE98tnFraqz+t?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5aa6df1-85b1-4897-9d65-08dab96f9fe8
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2022 05:37:10.4800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: edjd0hM2e4ItAI+fZ4OIYph8wfRzJwMHU7SS9+l1MSc1Q4g2Kgjyet/FgejqdbLN5y2iv56sizkF1t0EQSFUXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4589

Hi Oleksandr,

On 10/28/22 1:26 PM, Oleksandr Tyshchenko wrote:
>
>
> On Thu, Oct 27, 2022 at 12:24 PM Alex Bennée <alex.bennee@linaro.org> 
> wrote:
>
> Hello all
>
>
>
>     Vikram Garhwal <vikram.garhwal@amd.com> writes:
>
>     > xenstore_record_dm_state() will also be used in aarch64 xenpv
>     machine.
>     >
>     > Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
>     > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
>     > ---
>     >  accel/xen/xen-all.c  | 2 +-
>     >  include/hw/xen/xen.h | 2 ++
>     >  2 files changed, 3 insertions(+), 1 deletion(-)
>     >
>     > diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c
>     > index 69aa7d018b..276625b78b 100644
>     > --- a/accel/xen/xen-all.c
>     > +++ b/accel/xen/xen-all.c
>     > @@ -100,7 +100,7 @@ void xenstore_store_pv_console_info(int i,
>     Chardev *chr)
>     >  }
>     >
>     >
>     > -static void xenstore_record_dm_state(struct xs_handle *xs,
>     const char *state)
>     > +void xenstore_record_dm_state(struct xs_handle *xs, const char
>     *state)
>     >  {
>     >      char path[50];
>     >
>     > diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
>     > index afdf9c436a..31e9538a5c 100644
>     > --- a/include/hw/xen/xen.h
>     > +++ b/include/hw/xen/xen.h
>     > @@ -9,6 +9,7 @@
>     >   */
>     >
>     >  #include "exec/cpu-common.h"
>     > +#include <xenstore.h>
>
>     This is breaking a bunch of the builds and generally we try and avoid
>     adding system includes in headers (apart from osdep.h) for this
>     reason.
>     In fact there is a comment just above to that fact.
>
>     I think you can just add struct xs_handle to typedefs.h (or maybe just
>     xen.h) and directly include xenstore.h in xen-all.c following the
>     usual
>     rules:
>
>     https://qemu.readthedocs.io/en/latest/devel/style.html#include-directives
>
>     It might be worth doing an audit to see what else is including xen.h
>     needlessly or should be using sysemu/xen.h.
>
>     >
>     >  /* xen-machine.c */
>     >  enum xen_mode {
>     > @@ -31,5 +32,6 @@ qemu_irq *xen_interrupt_controller_init(void);
>     >  void xenstore_store_pv_console_info(int i, Chardev *chr);
>     >
>     >  void xen_register_framebuffer(struct MemoryRegion *mr);
>     > +void xenstore_record_dm_state(struct xs_handle *xs, const char
>     *state);
>     >
>     >  #endif /* QEMU_HW_XEN_H */
>
>
>     -- 
>     Alex Bennée
>
>
>
> For considering:
> I think this patch and some other changes done in "[PATCH v1 10/12] 
> hw/arm: introduce xenpv machine" (the opening of Xen interfaces and 
> calling xenstore_record_dm_state() in hw/arm/xen_arm.c:xen_init_ioreq())
> could be avoided if we enable the Xen accelerator (either by passing 
> "-M xenpv,accel=xen" or by adding mc->default_machine_opts = 
> "accel=xen"; to hw/arm/xen_arm.c:xen_arm_machine_class_init() or by 
> some other method).
> These actions are already done in accel/xen/xen-all.c:xen_init(). 
> Please note, that I am not too familiar with that code, so there might 
> be nuances.
>
> Besides that, Xen accelerator will be needed for the xen-mapcache to 
> be in use (this is needed for mapping guest memory), there are a few 
> xen_enabled() checks spreading around that code to perform Xen 
> specific actions.
>
Unfortunately, I am not that familiar with xen as accelerator function. 
Let me check and get back to you.
> -- 
> Regards,
>
> Oleksandr Tyshchenko


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 06:29:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 06:29:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432279.685066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oofLh-0004KC-Ng; Sat, 29 Oct 2022 06:29:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432279.685066; Sat, 29 Oct 2022 06:29:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oofLh-0004K5-JS; Sat, 29 Oct 2022 06:29:41 +0000
Received: by outflank-mailman (input) for mailman id 432279;
 Sat, 29 Oct 2022 06:29:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oofLg-0004Jv-9y; Sat, 29 Oct 2022 06:29:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oofLg-00041C-7A; Sat, 29 Oct 2022 06:29:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oofLf-0002kP-On; Sat, 29 Oct 2022 06:29:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oofLf-0000qO-OK; Sat, 29 Oct 2022 06:29:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=a3pd4g1Ucr7fcyue86xD0nropcPJcVx8JmJLDi/Wo1M=; b=2d9bYhLpGdLhNJ6epnixDp6NeW
	ZKs6aWqv1eKz/m8Gc3P7TOcubLsk74Yutl6y45LVupFbpntHrgYcnvKBUJtR2Gzch1CIWBJ19NPZn
	tUzWSy+j6H0ET8u+QtnPIcDRrAR3f+o1DWDgVw6SHewPp8QPjlaOlM5UTEyMvlQ5nCMA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174534-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174534: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
X-Osstest-Versions-That:
    xen=20cf0ab774e828dc4e75ecebecf56b53aca754fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 06:29:39 +0000

flight 174534 xen-unstable real [real]
flight 174537 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174534/
http://logs.test-lab.xenproject.org/osstest/logs/174537/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 174537-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174526
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174526
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174526
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174526
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174526
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174526
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174526
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174526
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174526
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174526
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174526
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174526
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
baseline version:
 xen                  20cf0ab774e828dc4e75ecebecf56b53aca754fc

Last test of basis   174526  2022-10-28 04:10:47 Z    1 days
Testing same since   174534  2022-10-28 20:08:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   20cf0ab774..1d7fbc535d  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1 -> master


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 09:48:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 09:48:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432319.685101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooiRN-0004FN-EU; Sat, 29 Oct 2022 09:47:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432319.685101; Sat, 29 Oct 2022 09:47:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooiRN-0004FG-AH; Sat, 29 Oct 2022 09:47:45 +0000
Received: by outflank-mailman (input) for mailman id 432319;
 Sat, 29 Oct 2022 09:47:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ErAt=26=citrix.com=prvs=294fe0d1b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1ooiRL-0004FA-RY
 for xen-devel@lists.xenproject.org; Sat, 29 Oct 2022 09:47:44 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b902b7b3-576e-11ed-8fd0-01056ac49cbb;
 Sat, 29 Oct 2022 11:47:39 +0200 (CEST)
Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Oct 2022 05:47:36 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DM6PR03MB4924.namprd03.prod.outlook.com (2603:10b6:5:1f2::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sat, 29 Oct
 2022 09:47:31 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5769.016; Sat, 29 Oct 2022
 09:47:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b902b7b3-576e-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1667036859;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=/4X8GMxWaqP7P7j2zUSRYmwYCoo7DvkDsz5FWzAAJbg=;
  b=Vrw6afcINVGvShDet/jrYr1GLhQnIoinMQn1VNS4Y8zmat/nS4y1obPr
   Z31N9t4AUa4XEQLczFZvGcsKIErCAsz4hOP7pfLENggQCOFXvjWiDRLSt
   YXM2oSprUOSvQfKQi27yaWfp3zxGExkdpyFd8j8go0l374EVJuss8A8kN
   Y=;
X-IronPort-RemoteIP: 104.47.56.176
X-IronPort-MID: 83368105
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:Hb8u4KCN7EgSoRVW//Liw5YqxClBgxIJ4kV8jS/XYbTApG8ghTdVz
 moXW2GCPKzZZmbyetx0YIuypBwH75DXmNRnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h
 yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs
 t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtC7wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS
 uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada
 jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw6sdIWEB03
 9MiLzUNPkGMuqG136m5Y7w57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa
 sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDa7IA9ZidABNPLPfdOHX4NNl1uwr
 WPa5WXpRBodMbRzzBLVqSny1raXwEsXXqoDG4az/eE3o2TDy04dOE0TCgOqmdym3xvWt9V3b
 hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xJmUCVC8HV9Ugu+c/Xzls3
 ViM9/vrDzFytLyeSVqG66yZ6zi1PEA9L3IGZCICZRsI5Z/kuo5bpgnUUt9pHaqxj9v0MTL92
 TaHqG45nbp7pdEP/7W2+xbAmT3Em3TSZgs85wGSVWX86Ap8Pdehf9bxtgad6utcJoGESFXHp
 GIDh8WV8OEJC9eKiTCJR+IOWrqu4p5pLQHhvLKmJLF5nxzFxpJpVdk4DO1WTKuxDvs5RA==
IronPort-HdrOrdr: A9a23:0iJwnKCJDYcbE6nlHehJsceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN
 tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dO0EPa
 vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmffHOind+i1bfyJEwL8k/2
 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+3CVTbUkf4fHkCE+oemp5lpvuN
 7Qoy04N8A20H/VdnHdm2qe5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe
 929lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQlo+a87bW3HAb0cYa
 dT5Jm23ocWTbraVQGTgoBX+q3hYpxpdS32AnTruaSuoktrdT5CvgglLfck7wY9HaIGOuZ5Dt
 v/Q9pVfZF1P7orhPFGdZM8aPryLFDxajTxF0/XCWjbNcg8SgLwQtjMkf0I2N0=
X-IronPort-AV: E=Sophos;i="5.95,223,1661832000"; 
   d="scan'208";a="83368105"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kpido4vGMq8XOPqpkjv0Q8vgcN8zO42aB0eg6SJf9ucFZetTNpFdjHeDmon5QjwoYCVlVH0+8a6kyXKKB7uU3PaRpk1Qb40J5pl77WuqoG5Zv7p3U6UZnwSmT0FlrEaxRsoboGrFVpT/XLXhqhOQLACIE/rsvpJkaVZaAaj8Obbpj6XZtHhO12fXB+KKUxdtQ4IXQ2WBh5Lo9+/YYuU7CETZT+l6tNRSKJTS5lrIVLMizP/9hzrmXcrgJWdeNgOdqW0jxUHBnU3eqRr7Rx/10ZP8FEhMTI4+MJHTQj7YdqHlbVU2cZ/F8tRQihECTek3T6snfiVgjGyfE4PWqjGb9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UsxrMTGoYf/ZB43KrphfKm6g7UnDTQ62oWu/iIPZ0mg=;
 b=S1j8fsg1d5a41E6VX+XDsHqYpb0Q0uStHO72gqTxTqnNWuE9tILJSjZ3fovmuFLSaO0TEmRLQqv7wIBpW++z6FlH9kI1Gah1E8UIlnZoTX4ZjYWvGsdOTeacBMaRR0MLOmw1dN8aYrWCZ1eIisRG5Qlgbe4iURqBS4swef73rh/bEJhwg8XxX6Xg6weQgpfN+bHW2FcZTFwtUz9sReRKxTE28WZD2C5ioIPY9COE9kppK96K89lWWhwQXQ9jF/uXAsKrSX+rDBpS+BzgnENssF1psZmKuoh/EKaSG5hwrPikUJx4gint8m4awocDvccKiRGCXWYChYMQFbGej5MPrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UsxrMTGoYf/ZB43KrphfKm6g7UnDTQ62oWu/iIPZ0mg=;
 b=iZ7blH5zpL89xJGrRqzRN96MZDjK9gW7ZTwhkWiGveV8Gh8mjfvff8k7D/EpdQKv1p7Ky+5D3Z5Nx+yxTIOrC7bIgFtTqAquUefyzuX7HvxaHxuQ08KuwX8RXpTBF56F7fh3wuFTBq0bX2FQQTwiuwOVjpr91WlNKkfHAK0wyBM=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
Date: Sat, 29 Oct 2022 11:47:24 +0200
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH for-4.17 v2 2/3] amd/virt_ssbd: set SSBD at vCPU context
 switch
Message-ID: <Y1z2rMNrzui3x9+J@Air-de-Roger>
References: <20221028114913.88921-1-roger.pau@citrix.com>
 <20221028114913.88921-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221028114913.88921-3-roger.pau@citrix.com>
X-ClientProxiedBy: LO4P123CA0291.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:196::8) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DM6PR03MB4924:EE_
X-MS-Office365-Filtering-Correlation-Id: 8d0609e0-fa8d-477a-5395-08dab99298f5
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2hWU0iLynHmm4OUO8tRd3Rm4THE7XM2swEb7XBWu0IpVNeZt+Q/xd7JBUIi3wlIRmr625Xr8GU1xhV3J6BzOrxzF/v+011EpMtEZ2ukN2BTd7xf/51ufr3UKY0cIPGYM3aATPv4BevvLsJv27ABfYUgb78FgU3sZqnzNDGKWlYEgBIo9ncv4aGF6Tw+NQywIDBLiaRWa9LIrhsBloX+/VM44q8TcBCLdwWxePLDNshnQb2LDHeiwEh0O2CcD55f2pkFUwPYQUfxZY/tz4lXgycHkirQLoTvLJWKlQ4HbGlJZ5uPqsORPtd6/tByU3CFwI604h+kFlRN1WFS7EmFLyHRGPcIzwxkZUe4It00atyGwXIiXp892aQL2/OCotyOglKXmib4a/2l54kHXGj7YunccejeUTz7OfTZoh06F8svgvIvmq4l/rNFLriOh1lM/MROnFyzj95Ad1aEYLNlOx52bKGqnuCkp6zjXHt99RiQU3XQS8rCRE6amJ1/ULUG9AgK1WMnWH0VmATL9vGEAS1w8e/9QX8XBdQHnq7Rc7Hf86w0PX+AXOYSWsjeHbjkLTs7MI0JKwFfHAmNk0EvlvVBI+Lc+bAM+SYUlUmJ/iPmccv3kX5RIIi4+iLKZpdJynCuFEDe9Eeiq38w+T6Vq8/p0tuRY/IQz+1pfMQK/o/Hk+q0kIAuMzlJ4nP/NBg8VbZNdggyUqbZJOZa3zDeTTgqB6KtUkBMUXDkbUyP886WBxWHz+xKJgUp5y0zFTDRY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199015)(41300700001)(6862004)(4744005)(5660300002)(8936002)(8676002)(316002)(54906003)(66476007)(66556008)(66946007)(478600001)(6486002)(4326008)(83380400001)(82960400001)(38100700002)(6506007)(6666004)(86362001)(6512007)(186003)(9686003)(26005)(33716001)(2906002)(6200100001)(85182001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RWg0VUJOUEN1amM1M3NxU0V1ZmdaMFVFeWNNdmQ0SG1RYTVMeDRpM082dVQr?=
 =?utf-8?B?TzNXbVBqeUtuUzNsMHlqeUgzMnNLb0dhSC91aTdPSEJhWXJrRi9NdDhUNnJD?=
 =?utf-8?B?U1N1SWtBRElRbzN2bEsrbzJVUEIybGpCL3E5VHRoM01QS3hzWjRsQzlGeHdJ?=
 =?utf-8?B?LzFXZ29EMm1mR1N5NXZjTEMyTjFsNmF2cUFic05JaGVFRFQxdEc5MHRvMzV5?=
 =?utf-8?B?U3REOWJmOFB6cyt3Wk9rU3FtY2hwM2JFekV4VkFSSHp3clZsRmVIVVA2cDly?=
 =?utf-8?B?dTk1RkZwc2ZOdFRiRzdSdU5rUVVjR0o1TVRoaVp2WU8xNEdZYkt0RTh3czdx?=
 =?utf-8?B?Q0Rjc2dpYlQzc1RndDFaOHRGWWlZVkVJY3pnb2hPbjVnZFZpOEo4dmZoMEVw?=
 =?utf-8?B?M3pBSGwwNmw2OVVZRFdOdHlOVS9RMFp5VjRCQ0pTb0xPdjlISWR4SnVhNUVT?=
 =?utf-8?B?cEFzYlhWa0dXdVJjN1FwTVRHSjNoaW1BNDAwc2FrU0VyNEhvOFVNdjZuakVD?=
 =?utf-8?B?SlhPdEZzVW5ubFNrTTRobHpLNUNXenFMd3Z3RGl5cFZ4YWlhYUFiT2lTZkY0?=
 =?utf-8?B?OUJ6ak9Pa3VPWmxBZ0lzb1JoMnN2VHNGbHBNMUFrM2RQTllwUnVrWTZwSEw0?=
 =?utf-8?B?UUVOb2RjK081S2EzSDJWRHU4T21PTUVZK3JNL3JrenBPM3NpMCtPaFA2eVRX?=
 =?utf-8?B?dW42K0QrQUtKZS95eEJpTGh6VzNLeHlDL3h4M0t2L2NOZWQ1a0lEM0JQTGFp?=
 =?utf-8?B?NnBzZ0JNdG9LYjJjS3c2akdXWTd6QWxHSUxEalQ4R3A5b0xVV2VtY1A2Y1U2?=
 =?utf-8?B?RDNqdVhOUE5NWjRuOHQxMFdYeENlOERTNGNLMVIxUnM5ekxYa0VWaGR2VmpR?=
 =?utf-8?B?VnJCa3lFSGhaeU8yOG5ubTYvUDRXbStwckRoamUvSkttd1plN0FnNCthUDQ2?=
 =?utf-8?B?TGtPK0I1ZksxVnZNcE9pR3gyNStrVlcySjBtRUp6bHlsQVlyVTV4bFM5K0Ri?=
 =?utf-8?B?cDJMZUorNHhNQXFjUVkzT2VrNHdWcnN6QmJTdjFmMWlFK0xPeEV3OWFtUnJD?=
 =?utf-8?B?VC9lZDFFcyswYThtOW81Nk5KeEFZeGVPeHB0NW83Qy9ieDlFZjY4SlRZOUlx?=
 =?utf-8?B?bUVZalc5bHRjak11WStxV3FsTEJ0TURreDdHOTZJck9nUG9WVEVuN1V1T21G?=
 =?utf-8?B?SlZBN0J2NVJjMVUzQ1huYkZqeGhrK2ZZNXJyYkZQa2JOcHQ0YlhSdXkzeVBq?=
 =?utf-8?B?TUZlamhuYW5Ud09WRitkRGd6L0ROQSt6dmo0QVRyUFRWQlZoTHVySHB6Q0Ry?=
 =?utf-8?B?M1dhcmtrVWtmVHl0dHpiczd1NXRRSC9XTEwxMEpkeDRFM1ZyWmduN00zbTFs?=
 =?utf-8?B?bm5sMFM1UkZ3WlQ3QzFLZVBMazR2eWllaVFpMSs4d3V3VjNxRVRHaTBaZmhw?=
 =?utf-8?B?TnlMUXcrVDgxZFBWZGFPMGpaYnVrVHNCVVErT2pnUFEybjFqR3pUUnhvQ3ht?=
 =?utf-8?B?dGowTUtoOWtpZDU1Sm9ZZFJnb1B2OHh4eWZvbWNETmVvRnJjTXl3ZnRMVFJK?=
 =?utf-8?B?U0JYTk50Mzd2U0d1VFcwc0xhYVhNdlBkZkpWTWhGdVhwWENRNG5BaWw3blBp?=
 =?utf-8?B?RTFFYXJ3VW5yQnB3TjdNaWhJb2ZKVG55dDNvUHhDTTN3WHdYdEpxdG9OM3dx?=
 =?utf-8?B?SmQwQTVNQkJDL3FhWFpPMTVJTG1NUGc1TTVjRGhVNThqbDdTMUNrOXBDbTJh?=
 =?utf-8?B?WllpTEZxT0g0UUsvSjlYT2R1R3V6V2pBaUhpdU4rdlB0a2tQbVdjOTdWamtF?=
 =?utf-8?B?VFhWQ2E3WkpWdDQyUE5UaFhKMkM0SnpZazZEVjZGWG85eXc3dEs5QmJNQVg0?=
 =?utf-8?B?cmJFVHF0UDlWTzlEcUxsdkNnaVJ1SmxNSjN5SmZWcWJsWDNpWEZBa3VUS05D?=
 =?utf-8?B?VnFQemt3VUpyc0ZKSEQrWGVaZStSMG8rTllwUS93RG1TSm80UXJvQ2tuQWRa?=
 =?utf-8?B?SElRZTl2ZTY3bi9qR0RYc1FRWGhrTnJVNVF2SlkrUFJwNk5HeFBRa3V3WUsr?=
 =?utf-8?B?MW5ZblRKR0w2UWFQcFFJdlFmcjRMV2xReHl5VlRlcWdleXFCZVh1Z3k1cDlM?=
 =?utf-8?Q?elQI0M6mE/0AWMmqziTe5hJ8/?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d0609e0-fa8d-477a-5395-08dab99298f5
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2022 09:47:31.0330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qX5xllLuo/tuCz7vEzhFopkxkfZc8g4vVTnSf9NI9j9m+1Ht2jcApz5Hlg1BtqKrKXKG4f1sxwX1dJwKzHJqLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4924

On Fri, Oct 28, 2022 at 01:49:12PM +0200, Roger Pau Monne wrote:
> diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
> index 95416995a5..a4c28879bc 100644
> --- a/xen/arch/x86/msr.c
> +++ b/xen/arch/x86/msr.c
> @@ -697,7 +697,14 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
>                  msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
>          }
>          else
> +        {
>              msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD;
> +            /*
> +             * Propagate the value to hardware, as it won't be context switched
> +             * on vmentry.
> +             */
> +            goto set_reg;

Doing this when v != curr is wrong, will send an updated patch.

Roger.


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 11:25:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 11:25:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432337.685112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oojy9-0008LC-Lc; Sat, 29 Oct 2022 11:25:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432337.685112; Sat, 29 Oct 2022 11:25:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oojy9-0008L5-G2; Sat, 29 Oct 2022 11:25:41 +0000
Received: by outflank-mailman (input) for mailman id 432337;
 Sat, 29 Oct 2022 11:25:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oojy8-0008Ku-8m; Sat, 29 Oct 2022 11:25:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oojy8-0000v5-5O; Sat, 29 Oct 2022 11:25:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oojy7-00021D-Im; Sat, 29 Oct 2022 11:25:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oojy7-0008Ji-IK; Sat, 29 Oct 2022 11:25:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FU0gb+98ytaj1V42joCo5wSakjcVCQCIUyb6wFtfhDA=; b=VX/LYoDAV6X3F2xLQWvme/C8d1
	0RTibaGwA20wgi9JLmDJn6T8bGu+e3mf9lkaUX1gaAQGwBcMA0hrHxDu9/EOIvT1jvoKaDtsRkl1J
	8/WshsS26X8G8FzeLAbo2999r0j4AXgdVzC3Dz71kXViZ7pZcxLMCAUbwdptiGGADmrk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174535-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174535: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=576e61cea1e4b66f52f164dee0edbe4b1c999997
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 11:25:39 +0000

flight 174535 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174535/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                576e61cea1e4b66f52f164dee0edbe4b1c999997
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   21 days
Failing since        173470  2022-10-08 06:21:34 Z   21 days   30 attempts
Testing same since   174535  2022-10-29 01:13:15 Z    0 days    1 attempts

------------------------------------------------------------
1496 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 139382 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 12:36:50 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 12:36:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432351.685123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ool4n-0000Lr-Qz; Sat, 29 Oct 2022 12:36:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432351.685123; Sat, 29 Oct 2022 12:36:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ool4n-0000Lk-O6; Sat, 29 Oct 2022 12:36:37 +0000
Received: by outflank-mailman (input) for mailman id 432351;
 Sat, 29 Oct 2022 12:36:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ool4m-0000La-Gk; Sat, 29 Oct 2022 12:36:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ool4m-00022Q-D6; Sat, 29 Oct 2022 12:36:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ool4l-0003tq-Vf; Sat, 29 Oct 2022 12:36:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ool4l-0001Gc-V8; Sat, 29 Oct 2022 12:36:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=350AYYfiPpxjQhhInJt9U19WehCW0y/MlzhaG3mBlYk=; b=1XpvcJlsiGNjoFjhkUDWH/ONMV
	4eRh/5PwQAGZa/uLMGtmuwPmwgIRBgGf/Z7Fbba/itV+xLwz8u1BiEkHbLYtiMHVk1hm4xFPqXk0q
	N23GP13MPMUZH1YjwojYXH9wdI1heHlSg0z9qbf4oJy8k9LMQZk0Hyfx0aXNXzi0IhUQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174536-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174536: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fe18f1af38a7999e05a6564c80d63e8d9df5ee60
X-Osstest-Versions-That:
    linux=fd92cfed8bc6668d314acd1e6da708a80826f768
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 12:36:35 +0000

flight 174536 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174536/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10 fail in 174511 pass in 174536
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 174511 pass in 174536
 test-armhf-armhf-libvirt-qcow2 13 guest-start    fail in 174511 pass in 174536
 test-armhf-armhf-libvirt-raw 13 guest-start                fail pass in 174511

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 174511 blocked in 174012
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 174511 like 174012
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 174511 like 174012
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 174511 like 174012
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 174511 never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 174511 never pass
 test-armhf-armhf-xl-credit2  14 guest-start                  fail  like 174012
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174012
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174012
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174012
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174012
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174012
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174012
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174012
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174012
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                fe18f1af38a7999e05a6564c80d63e8d9df5ee60
baseline version:
 linux                fd92cfed8bc6668d314acd1e6da708a80826f768

Last test of basis   174012  2022-10-17 16:21:11 Z   11 days
Testing same since   174450  2022-10-26 11:42:18 Z    3 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Ahmad Fatoum <a.fatoum@pengutronix.de>
  Albert Briscoe <albertsbriscoe@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Coffin <alex.coffin@matician.com>
  Alexander Dahl <ada@thorsis.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexei Starovoitov <ast@kernel.org>
  Alexey Lyashkov <alexey.lyashkov@gmail.com>
  Allen Pais <apais@linux.microsoft.com>
  Alvin Šipraga <alsi@bang-olufsen.dk>
  Andreas Pape <apape@de.adit-jv.com>
  Andrew Bresticker <abrestic@rivosinc.com>
  Andrew Gaul <gaul@gaul.org>
  Andrew Gaul <gaul@google.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrew Perepechko <anserper@ya.ru>
  Andri Yngvason <andri@yngvason.is>
  Andrii Nakryiko <andrii@kernel.org>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Anna Schumaker <Anna.Schumaker@Netapp.com>
  Anssi Hannula <anssi.hannula@bitwise.fi>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Arvid Norlander <lkml@vorpal.se>
  Baokun Li <libaokun1@huawei.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bernard Metzler <bmt@zurich.ibm.com>
  Bitterblue Smith <rtl8821cerfe2@gmail.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Bjorn Helgaas <bhelgaas@google.com>
  Borislav Petkov <bp@suse.de>
  Callum Osmotherly <callum.osmotherly@gmail.com>
  Carlos Llamas <cmllamas@google.com>
  Chao Qin <chao.qin@intel.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wenst@chromium.org>
  Chi-hsien Lin <chi-hsien.lin@cypress.com>
  Christian Brauner (Microsoft) <brauner@kernel.org>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Chuck Lever <chuck.lever@oracle.com>
  Claudiu Beznea <claudiu.beznea@microchip.com>
  Coly Li <colyli@suse.de>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniel Golle <daniel@makrotopia.org>
  Daniel Vetter <daniel.vetter@ffwll.ch>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dave Jiang <dave.jiang@intel.com>
  David Collins <collinsd@codeaurora.org>
  David Gow <davidgow@google.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  David Teigland <teigland@redhat.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Dmitry Osipenko <dmitry.osipenko@collabora.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Duoming Zhou <duoming@zju.edu.cn>
  Eddie James <eajames@linux.ibm.com>
  Eric Dumazet <edumazet@google.com>
  Eugeniu Rosca <erosca@de.adit-jv.com>
  Fangrui Song <maskray@google.com>
  Fenglin Wu <quic_fenglinw@quicinc.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  Frederic Barrat <fbarrat@linux.ibm.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Guilherme G. Piccoli <gpiccoli@igalia.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Haibo Chen <haibo.chen@nxp.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Hari Chandrakanthan <quic_haric@quicinc.com>
  Hawkins Jiawei <yin31149@gmail.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  Hillf Danton <hdanton@sina.com>
  hongao <hongao@uniontech.com>
  Huacai Chen <chenhuacai@loongson.cn>
  Hyunwoo Kim <imv4bel@gmail.com>
  Ian Nam <young.kwan.nam@xilinx.com>
  Ignat Korchagin <ignat@cloudflare.com>
  Ingo Molnar <mingo@kernel.org>
  Jack Wang <jinpu.wang@ionos.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jan Kara <jack@suse.cz>
  Jason Baron <jbaron@akamai.com>
  Jassi Brar <jaswinder.singh@linaro.org>
  Javier Martinez Canillas <javierm@redhat.com>
  Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
  Jens Axboe <axboe@kernel.dk>
  Jerry Lee <jerrylee@qnap.com>
  Jerry Lee 李修賢 <jerrylee@qnap.com>
  Jes Sorensen <Jes.Sorensen@gmail.com>
  Jianglei Nie <niejianglei2021@163.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jim Cromie <jim.cromie@gmail.com>
  Jimmy Assarsson <extja@kvaser.com>
  Jinke Han <hanjinke.666@bytedance.com>
  Jiri Kosina <jkosina@suse.cz>
  Joel Stanley <joel@jms.id.au>
  Joerg Roedel <jroedel@suse.de>
  Johannes Berg <johannes.berg@intel.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josh Poimboeuf <jpoimboe@kernel.org>
  Junichi Uekawa <uekawa@chromium.org>
  Kalle Valo <kvalo@kernel.org>
  Kalle Valo <quic_kvalo@quicinc.com>
  Kees Cook <keescook@chromium.org>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Keith Busch <kbusch@kernel.org>
  Kevin(Yudong) Yang <yyd@google.com>
  Khalid Masum <khalid.masum.92@gmail.com>
  Koba Ko <koba.ko@canonical.com>
  Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
  Lalith Rajendran <lalithkraj@google.com>
  Lam Thai <lamthai@arista.com>
  Laurent Pinchart <laurent.pinchart@ideasonboard.com>
  Lee Jones <lee@kernel.org>
  Leon Romanovsky <leon@kernel.org>
  Letu Ren <fantasquex@gmail.com>
  Liang He <windhl@126.com>
  Liang Yang <liang.yang@amlogic.com>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Liu Jian <liujian56@huawei.com>
  Logan Gunthorpe <logang@deltatee.com>
  Lorenz Bauer <oss@lmb.io>
  Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Luke D. Jones <luke@ljones.dev>
  Lyude Paul <lyude@redhat.com>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marek Behún <kabel@kernel.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Martin Liska <mliska@suse.cz>
  Masahiro Yamada <masahiroy@kernel.org>
  Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Maya Matuszczyk <maccraft123mc@gmail.com>
  Miaoqian Lin <linmq006@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael Hennerich <michael.hennerich@analog.com>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Walle <michael@walle.cc>
  Michal Luczaj <mhal@rbox.co>
  Michal Simek <michal.simek@amd.com>
  Mike Pattrick <mkp@redhat.com>
  Mingzhe Zou <mingzhe.zou@easystack.cn>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Nam Cao <namcaov@gmail.com>
  Namhyung Kim <namhyung@kernel.org>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nick Desaulniers <ndesaulniers@google.com>
  Nicolas Dufresne <nicolas.dufresne@collabora.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Ninad Naik <ninad.naik@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Olga Kornievskaia <kolga@netapp.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Ondrej Mosnacek <omosnace@redhat.com>
  Pali Rohár <pali@kernel.org>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Kocialkowski <paul.kocialkowski@bootlin.com>
  Paul Moore <paul@paul-moore.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Oberparleiter <oberpar@linux.ibm.com>
  Peter Robinson <pbrobinson@gmail.com>
  Peter Rosin <peda@axentia.se>
  Peter Xu <peterx@redhat.com>
  Petr Mladek <pmladek@suse.com>
  Phil Sutter <phil@nwl.cc>
  Philipp Hortmann <philipp.g.hortmann@gmail.com>
  Qu Wenruo <wqu@suse.com>
  Quanyang Wang <quanyang.wang@windriver.com>
  Quentin Monnet <quentin@isovalent.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Reinette Chatre <reinette.chatre@intel.com>
  Rich Felker <dalias@libc.org>
  Richard Acayan <mailingradian@gmail.com>
  Richard Weinberger <richard@nod.at>
  Rik van Riel <riel@surriel.com>
  Rob Clark <robdclark@chromium.org>
  Robert Foss <robert.foss@linaro.org>
  Robin Guo <guoweibin@inspur.com>
  Robin Murphy <robin.murphy@arm.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rustam Subkhankulov <subkhankulov@ispras.ru>
  Ryusuke Konishi <konishi.ryusuke@gmail.com>
  Saranya Gopal <saranya.gopal@intel.com>
  Sasha Levin <sashal@kernel.org>
  Saurabh Sengar <ssengar@linux.microsoft.com>
  Sean Christopherson <seanjc@google.com>
  Sebastian Reichel <sebastian.reichel@collabora.com>
  Serge Semin <Sergey.Semin@baikalelectronics.ru>
  Shawn Guo <shawnguo@kernel.org>
  Sherry Sun <sherry.sun@nxp.com>
  Shigeru Yoshida <syoshida@redhat.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
  Slade Watkins <srw@sladewatkins.net>
  Song Liu <song@kernel.org>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefan Wahren <stefan.wahren@i2se.com>
  Steffen Klassert <steffen.klassert@secunet.com>
  Stephen Boyd <sboyd@kernel.org>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (Google) <rostedt@goodmis.org>
  sunghwan jung <onenowy@gmail.com>
  Sungwoo Kim <iam@sung-woo.kim>
  syzbot <syzbot+78c55c7bc6f66e53dce2@syzkaller.appspotmail.com>
  syzbot+5ec9bb042ddfe9644773@syzkaller.appspotmail.com
  Tadeusz Struk<tadeusz.struk@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Tales Aparecida <tales.aparecida@gmail.com>
  Tejun Heo <tj@kernel.org>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Thara Gopinath <tgopinath@microsoft.com>
  Theodore Ts'o <tytso@mit.edu>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Zimmermann <tzimmermann@suse.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
  Tudor Ambarus <tudor.ambarus@microchip.com>
  Tzung-Bi Shih <tzungbi@kernel.org>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vinod Koul <vkoul@kernel.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wang Kefeng <wangkefeng.wang@huawei.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wen Gong <quic_wgong@quicinc.com>
  Wenchao Chen <wenchao.chen@unisoc.com>
  William Dean <williamsukatube@gmail.com>
  Wright Feng <wright.feng@cypress.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xin Long <lucien.xin@gmail.com>
  Xu Qiang <xuqiang36@huawei.com>
  Yonghong Song <yhs@fb.com>
  Yuchung Cheng <ycheng@google.com>
  Zhang Qilong <zhangqilong3@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
  Zheng Yejian <zhengyejian1@huawei.com>
  Zheng Yongjun <zhengyongjun3@huawei.com>
  Zheyu Ma <zheyuma97@gmail.com>
  Zhihao Cheng <chengzhihao1@huawei.com>
  Zhu Yanjun <yanjun.zhu@linux.dev>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   fd92cfed8bc6..fe18f1af38a7  fe18f1af38a7999e05a6564c80d63e8d9df5ee60 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 13:15:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 13:15:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432359.685134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oolfu-0005Ou-Tk; Sat, 29 Oct 2022 13:14:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432359.685134; Sat, 29 Oct 2022 13:14:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oolfu-0005On-QO; Sat, 29 Oct 2022 13:14:58 +0000
Received: by outflank-mailman (input) for mailman id 432359;
 Sat, 29 Oct 2022 13:14:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ErAt=26=citrix.com=prvs=294fe0d1b=roger.pau@srs-se1.protection.inumbo.net>)
 id 1oolft-0005Oh-1p
 for xen-devel@lists.xenproject.org; Sat, 29 Oct 2022 13:14:57 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac9df157-578b-11ed-8fd0-01056ac49cbb;
 Sat, 29 Oct 2022 15:14:54 +0200 (CEST)
Received: from mail-dm6nam10lp2109.outbound.protection.outlook.com (HELO
 NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.109])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 29 Oct 2022 09:14:51 -0400
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com (2603:10b6:a03:395::11)
 by DS7PR03MB5431.namprd03.prod.outlook.com (2603:10b6:5:2cd::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sat, 29 Oct
 2022 13:14:49 +0000
Received: from SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254]) by SJ0PR03MB6360.namprd03.prod.outlook.com
 ([fe80::9f90:6ba5:5b44:c254%3]) with mapi id 15.20.5769.016; Sat, 29 Oct 2022
 13:14:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac9df157-578b-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1667049294;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:content-transfer-encoding:mime-version;
  bh=aG2oexdWJ0iMZ06D7TEXxiaqlk7olnQakBtV25FsFP4=;
  b=MSUBHLt6RxcM/ca7AdppTX0JCGZ7kmj7AsV9gnhRg7kQTRjkzQ8YQkX+
   V92DQhCR1IxJA7NVgRObrLQfUlGuzLqzFHJITduNYYIDAIONi6eX+g1Qs
   02FK3N6g/Mve4wArLqy7T3jEoaXTF4kaCv+Plz7r1SoCFUdS8057EKVf6
   U=;
X-IronPort-RemoteIP: 104.47.58.109
X-IronPort-MID: 86293237
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:CcO9uK68fM6JkUxgFqngUwxRtOPGchMFZxGqfqrLsTDasY5as4F+v
 jcZDziDM6rbZTTzKt9zbYy/9BlUuJXQn99iG1Y6/ng0Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t
 plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0
 fv/uMSaM1K+s9JOGjt8B5mr9VU+4ZwehBtC5gZkPKgR7QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd
 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4
 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz
 PYUcA0kfze/jOubnpK7SvllvNgvM5y+VG8fkikIITDxK98DGMiGb4CUoNhS0XE3m9xEGuvYa
 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEooiOmF3Nn9I7RmQe1PmUmVv
 CTe9nnRCRAGLt2PjzGC9xpAg8efw3mqA9hJS9VU8NY1hx6XwjACMCYvenK6uOKAm2KGWulQf
 hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2
 XeAhdavDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLWuktT/FDX0w
 jaLhCsznbMeiYgMzarT1U/DqyKhoN7OVAFd2+nMdmes7wc8aIv7YYWtsADf9awZdNffSUSdt
 n8ZncTY9PoJEZyGiC2KRqMKAa2t4PGGdjbbhDaDAqUcythkwFb7Fag43d20DB4B3hosEdMxX
 HLuhA==
IronPort-HdrOrdr: A9a23:umyCN6n5LZ9oFSTgD28lI7xqkKDpDfO3imdD5ihNYBxZY6Wkfp
 +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhR4tKPTOWw1dASbsP0WKM+UyFJ8STzI5gPO
 JbAtFD4b7LfCdHZLjBkW6F+r8bqbHokZxAx92ut0uFJTsaF52IhD0JbzpzfHcGJzWvUvECZe
 ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V
 KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM
 jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI
 pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d
 FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp
 T525RT5c9zp/AtHNNA7Z86MK2K40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd
 L6IRhliVI=
X-IronPort-AV: E=Sophos;i="5.95,224,1661832000"; 
   d="scan'208";a="86293237"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SHr/1e8bNdikWduTF9nv2uoFGXT2MHr+FFL8STurU1uaHXroTUs067EaBsIW+e/3kDb13SBW3A4yPZgIVipZQEIwg7TeNxTkXe65KQ/GK5IdbQ1fPIwSW8cevYjfOsVNZ3+806d6kICMxSMqVskIF3z0QahGGXnjrAl30QE84yA71SQn8eazTu6l+fopzUTR5BwHrXgxDiODOmZrXR0EY+lRwAsCN6DsJ8w+MK0WLIGi4UQwSagGTmKuTj1fFlhnc9x0ZUOevhyNuEakzaDFaIeNxzSB+oSAM0/Cklj3GQRvfPFonn/QM8ROVFLCNaRR7GcNT43Phv5gJMgi5wJ9vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9ie04u2QSa69liLoH9iihQcrvkfTfzmRv3YCe1aW06o=;
 b=OR3feI5XO5ZtAf3lDz90i5oIeaLK61Cv79mohsc5IlJg8Kx98ub6dbpUnc1sN+CBWWLgt9EsWhWy75JSxbeaeYX24nQ5C89LxAxvKkdZYO18QTUdTyvSSVqMBPoUpc9VMpc/gXcC1L7B2WL9oKNOMDBnIHbNMIZHHkkqHxCqlKUa+F870HZNX4y3cZc/fDe63vIVHsFO8PmECAEVbQY7rr4KZWJkXeJs3jfB3eLLB939RdpBEaicT0IE6lvXR/bHsq2zQuR2Cq7uqHjf4Ye9xdEZMb7WpzmymvcB/VfIIq3C5bUvlGxGgo6NnBonGHEseeD9mDMvDrwHn8HGvsnP/A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9ie04u2QSa69liLoH9iihQcrvkfTfzmRv3YCe1aW06o=;
 b=kzJlQShpfu2o5X6u39Eek4zgNC85gkD+PnC2ELr7gj42giwWSnTyn73dr67DgyziflekzfxPMwN9FnvByx2TKnWPRDecMTx2STB6myfIG74qdzvCav+flXvHucIhCcw0Ki0EoMyWckdwB+7e6Q1Qb/oAM8Ne+SIsZdPnBFTxifU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Henry.Wang@arm.com,
	Roger Pau Monne <roger.pau@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH for-4.17 v2.1 2/3] amd/virt_ssbd: set SSBD at vCPU context switch
Date: Sat, 29 Oct 2022 15:12:58 +0200
Message-Id: <20221029131258.95811-1-roger.pau@citrix.com>
X-Mailer: git-send-email 2.37.3
In-Reply-To: <20221028114913.88921-3-roger.pau@citrix.com>
References: <20221028114913.88921-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P265CA0070.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:2af::10) To SJ0PR03MB6360.namprd03.prod.outlook.com
 (2603:10b6:a03:395::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR03MB6360:EE_|DS7PR03MB5431:EE_
X-MS-Office365-Filtering-Correlation-Id: d442fe30-a245-49b4-15c8-08dab9af8ea1
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JfKGlGA5Dc6+QaK5hR3SUM1kQreObZLX1xZ+p11PRwR1CpSqMa4mjzYRVF1CNMzFf5coe0klaomf9AT8uB3cB12eFjtKwNzSNOvygN+EyrQ+uhiwK+/WJHkT98ebf3JkUKycjcMxHRtrelwQ2D9Tql6v9ouggYiahj7XKsTBhCFe+E3wuperP/5h8Uq2q+v+VwBfSRPjamjkz756HyyxBhlxVt0HmD9twa4b+Y0Lue2pkEk5eXEB8730SBWOpA/Wodget+Qx77Et9bMIZ9OX6sE1PMVfsU8HeCXK8oWXTkPxzxqKNHItUDEvW6S7+P11lMFSf093Wj0MMh8sEuBiugFLD5Guc6cwsGeJso9DtwsTQY3iUWGZ5sZKak/ucLByW9Db0qPRrYodv8h5b3PsPOyL59mWrNjI5xiNxpfo6fLbEQPjbrExpXpkpD7UgE7YPjsQpAXjr6kQE5kso5Exhfir5wTtvt90O0hhoMK1eajdQjy47wUYGnpPmg8Q0GmdKx9ktCPq8Hoz9df+jJurPopjpl1I2ktAuo1+D2D5igzRAClUCEGQ4urjoPSNmJDjGyRxiq2mk0f+rDb7jjRd5xGvLlsEXlIZJkgAGFszKJ/D9Se0Y0MUyp+dClYEu0G44Kf0p5xK8RNxFKbWIYCzxuW6UDMokkRwMsGclL2uAy52NUAhpbGmI71Lozi/PyYmp2080MVjr+flR67oLlxCCA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6360.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199015)(6506007)(4326008)(8676002)(82960400001)(316002)(54906003)(6916009)(86362001)(478600001)(36756003)(66946007)(66476007)(66556008)(6666004)(83380400001)(5660300002)(1076003)(2616005)(186003)(8936002)(2906002)(6486002)(41300700001)(26005)(38100700002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXVwSVNpcmZZUEVwUGFCU3RrbWIzVi85SHNEMzZBeWJWOVJvQisvLyt2akQ0?=
 =?utf-8?B?U1lCdHlHcHpDTzVrdW1qOElEdERxdlQ2cG1WWW9GaHB2MUp3VEVFc1ZYOEww?=
 =?utf-8?B?TTZ1RXlncGhzTk9VVHZvT0tEQU5iS3FsenAxa3kyYjJoWE1HcFVMYkxzVVIw?=
 =?utf-8?B?M2s5QUd2TnZZa0NsalB5WDlZWHZnaCtmNU51ekx2dUhlcGFBUVRVKzRkdnh5?=
 =?utf-8?B?QUJiV1lxRVh0T0lQNUNxRS9ZQy9VQzVRWUZ4RGZmT3E3dFRzaVJIT3IzNEhX?=
 =?utf-8?B?K25BTXVGR2xmdEVXYkt3NkJmU1hkRUVla296dnF0ak41MTJWS2pMQ1ZsaXZm?=
 =?utf-8?B?TDV1RG0wdWhvOTE3WlEybXIwNGJCU1dNM2pHRkRoWlJOc0xDQmlVVVBlQ2Fx?=
 =?utf-8?B?aDh4ODV1RjhnSXQxYUxoODlVelB1ZlR2ZlVBWDBNTzBvVnduM3NGVUd0Yk5s?=
 =?utf-8?B?eS9adFhaUjFFaWF4bGI5ZjYvWDhVNk1hVGJjV3Ixdmt5Ymo1a3FzSkhwUDJ6?=
 =?utf-8?B?eW9qeHUxb0p1ZmduSnMrWDRWT1hReWJYeDFLWjczVnNjV0tjVnhPbSttTEhr?=
 =?utf-8?B?aUllb3dpMWN4V2hYaHRvcFNOL1ZEZDFwa1h2b2hGaE0zcUFDbk5HTWtJZ2VN?=
 =?utf-8?B?ODIrT3czTmZudTdPK0FGcmFTVndTV2VLQ0dnbmpweDFiNDZ6RG02QW5DM1dw?=
 =?utf-8?B?aVVEeHYyNkQyNDAwcmROZVVkblZDbU92Y3JENWV6Q3AydFpleFJMR0RjZWpv?=
 =?utf-8?B?aDhzNGcxMFhETzJIWS9PM1l3bE00OHdkUzRLZ3FLUkdqWXpscys5SmVaRUgv?=
 =?utf-8?B?bHJLSjVKcDNvdlNheEhLTkVxZ3hPT2F3dllBRkp3YVlRZlhWalJUQzlxMVZQ?=
 =?utf-8?B?UDJrYVlZTEFZVi8ya1Y5R09QMXFZSmxvQWVQNjdxeC9mNDRya2tjNHg0bDdk?=
 =?utf-8?B?R29yejBoMVQ5UGF4WUNtVHVsWFN3ZlAzTHNGenZSbldnK2VpbDMrNncxMnBR?=
 =?utf-8?B?L2NGQ2d6WDZ0a1E0VmhQZDM1ZzMyeGpoWit3Tm5QNWswc2xyL2hEMUxIRGV6?=
 =?utf-8?B?NUtVa25DVnJRVUwwL1pPMnlpNHVxWXdiY2ZZdHV2dWhFT0hObDJFUFRQSXJM?=
 =?utf-8?B?eXFjSnZMYkNOOXhUSVUrSkdQeDFhNG83aTkwV0VSdld1cmU4ZG53Zys0LzBp?=
 =?utf-8?B?dUR0T2dtVEVXdXhtVEJlZWlEalNyWjVjWjhoRVJDRGZyWndZOWk2WVAzQldT?=
 =?utf-8?B?Q29Fdi9xcUEyL3pEakM2SUVrMjFkWnZCaXUvekc4Rnppa3ZzQzlJMlBOQjQ1?=
 =?utf-8?B?Q3VHdkV4cDAzQ0NlakVtTnNHTzRLZWd4a1A2dGcwb3Rka2MyWXZ0Z2pHME1B?=
 =?utf-8?B?ams3WFJWazN5OVVzdlJGb1RjWUg2bjFRclI4eEtIU1duaWpJQkU0Y2EzcVFH?=
 =?utf-8?B?RzMzV0ZUa2J0YS92Z0FrOTNWNk5FTmJyTmZiN0tmUXZnK0ZpWlFPbUZVcGdW?=
 =?utf-8?B?SjA3eThwazhTbWxOQnlHN2M5dGFmb2R2dVNLTnBnSmhKc0VNaCs1azEwTTZt?=
 =?utf-8?B?VElRVXVMMWkzMXp2UmF1MzlNVHBBaVJjQnVLd0ZVMVNTZy9ubmM0ZGVMYjlB?=
 =?utf-8?B?Qkw2ZzRyQ2g2WEFxODdVOEtSNWFWNCtlNGNmdEFLdnZPMDZ1MnE5elpuU1l6?=
 =?utf-8?B?bHFML0hvTkJxWGRhMjhEeVpYdkVwa1NmWU5iUW92dzJzM1VhaHdObEpZMjYv?=
 =?utf-8?B?OUNFSElqa3ZkTDdwYWlSR0V6SWUySjdjRlFDelNTaFQwemZkNG5oSW9uVnlo?=
 =?utf-8?B?ellpMzRWbXQvdjIrUDg2Mmh4N2tSRFMvbW4xSjRBM0hvbzdYb2llT0Z3NEt6?=
 =?utf-8?B?WWNGck85VFRBdjZ4RVVjT3ZFL0dtanA0cStROUIvY0xGdlNkWG5wbzJKalMr?=
 =?utf-8?B?WXk4ZUNIdnh0ZDB1TE5hcnF0VFZwSWpSNEdsK0tROUhYdjdMaWRoamw5OTh2?=
 =?utf-8?B?RVpLbGRnZmszaWx0cy9hZFJqdFNHSTVGN1dCNE9BV2hQY1ZKbDBWTThhUzg3?=
 =?utf-8?B?bk1UbmQ4RllndUszU0M3Y1NHc3JWVUxCVU0xN3dNSkNxMDhlVUtBNFZDT2U5?=
 =?utf-8?Q?GT4nxQIEbVSP7F1mtFoahQVLn?=
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d442fe30-a245-49b4-15c8-08dab9af8ea1
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6360.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2022 13:14:49.1390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p6Xv3PNpNCjK3hoqKzR7tl9Z41b1ycfz27og698djmE+Id+oKNkgKeUFCRffMG4wTqyHShnItWxTr7ACZ6T8Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5431

The current logic for AMD SSBD context switches it on every
vm{entry,exit} if the Xen and guest selections don't match.  This is
expensive when not using SPEC_CTRL, and hence should be avoided as
much as possible.

When SSBD is not being set from SPEC_CTRL on AMD don't context switch
at vm{entry,exit} and instead only context switch SSBD when switching
vCPUs.  This has the side effect of running Xen code with the guest
selection of SSBD, the documentation is updated to note this behavior.
Also note that then when `ssbd` is selected on the command line guest
SSBD selection will not have an effect, and the hypervisor will run
with SSBD unconditionally enabled when not using SPEC_CTRL itself.

This fixes an issue with running C code in a GIF=0 region, that's
problematic when using UBSAN or other instrumentation techniques.

As a result of no longer running the code to set SSBD in a GIF=0
region the locking of amd_set_legacy_ssbd() can be done using normal
spinlocks, and some more checks can be added to assure it works as
intended.

Finally it's also worth noticing that since the guest SSBD selection
is no longer set on vmentry the VIRT_SPEC_MSR handling needs to
propagate the value to the hardware as part of handling the wrmsr.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - Fix calling set_reg unconditionally.

Changes since v1:
 - Just check virt_spec_ctrl value != 0 on context switch.
 - Remove stray asm newline.
 - Use val in svm_set_reg().
 - Fix style in amd.c.
 - Do not clear ssbd
---
 docs/misc/xen-command-line.pandoc | 10 +++---
 xen/arch/x86/cpu/amd.c            | 55 +++++++++++++++++--------------
 xen/arch/x86/hvm/svm/entry.S      |  6 ----
 xen/arch/x86/hvm/svm/svm.c        | 49 ++++++++++++---------------
 xen/arch/x86/include/asm/amd.h    |  2 +-
 xen/arch/x86/msr.c                |  8 +++++
 6 files changed, 66 insertions(+), 64 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 0fbdcb574f..424b12cfb2 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -2372,10 +2372,12 @@ By default, Xen will use STIBP when IBRS is in use (IBRS implies STIBP), and
 when hardware hints recommend using it as a blanket setting.
 
 On hardware supporting SSBD (Speculative Store Bypass Disable), the `ssbd=`
-option can be used to force or prevent Xen using the feature itself.  On AMD
-hardware, this is a global option applied at boot, and not virtualised for
-guest use.  On Intel hardware, the feature is virtualised for guests,
-independently of Xen's choice of setting.
+option can be used to force or prevent Xen using the feature itself.  The
+feature is virtualised for guests, independently of Xen's choice of setting.
+On AMD hardware, disabling Xen SSBD usage on the command line (`ssbd=0` which
+is the default value) can lead to Xen running with the guest SSBD selection
+depending on hardware support, on the same hardware setting `ssbd=1` will
+result in SSBD always being enabled, regardless of guest choice.
 
 On hardware supporting PSFD (Predictive Store Forwarding Disable), the `psfd=`
 option can be used to force or prevent Xen using the feature itself.  By
diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 98c52d0686..05d72c6501 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -742,7 +742,7 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c)
 }
 
 static struct ssbd_ls_cfg {
-    bool locked;
+    spinlock_t lock;
     unsigned int count;
 } __cacheline_aligned *ssbd_ls_cfg;
 static unsigned int __ro_after_init ssbd_max_cores;
@@ -753,7 +753,7 @@ bool __init amd_setup_legacy_ssbd(void)
 	unsigned int i;
 
 	if ((boot_cpu_data.x86 != 0x17 && boot_cpu_data.x86 != 0x18) ||
-	    boot_cpu_data.x86_num_siblings <= 1)
+	    boot_cpu_data.x86_num_siblings <= 1 || opt_ssbd)
 		return true;
 
 	/*
@@ -776,46 +776,51 @@ bool __init amd_setup_legacy_ssbd(void)
 	if (!ssbd_ls_cfg)
 		return false;
 
-	if (opt_ssbd)
-		for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
-			/* Set initial state, applies to any (hotplug) CPU. */
-			ssbd_ls_cfg[i].count = boot_cpu_data.x86_num_siblings;
+	for (i = 0; i < ssbd_max_cores * AMD_FAM17H_MAX_SOCKETS; i++)
+		spin_lock_init(&ssbd_ls_cfg[i].lock);
 
 	return true;
 }
 
-/*
- * Executed from GIF==0 context: avoid using BUG/ASSERT or other functionality
- * that relies on exceptions as those are not expected to run in GIF==0
- * context.
- */
-void amd_set_legacy_ssbd(bool enable)
+static void core_set_legacy_ssbd(bool enable)
 {
 	const struct cpuinfo_x86 *c = &current_cpu_data;
 	struct ssbd_ls_cfg *status;
+	unsigned long flags;
 
 	if ((c->x86 != 0x17 && c->x86 != 0x18) || c->x86_num_siblings <= 1) {
-		set_legacy_ssbd(c, enable);
+		BUG_ON(!set_legacy_ssbd(c, enable));
 		return;
 	}
 
+	BUG_ON(c->phys_proc_id >= AMD_FAM17H_MAX_SOCKETS);
+	BUG_ON(c->cpu_core_id >= ssbd_max_cores);
 	status = &ssbd_ls_cfg[c->phys_proc_id * ssbd_max_cores +
 	                      c->cpu_core_id];
 
-	/*
-	 * Open code a very simple spinlock: this function is used with GIF==0
-	 * and different IF values, so would trigger the checklock detector.
-	 * Instead of trying to workaround the detector, use a very simple lock
-	 * implementation: it's better to reduce the amount of code executed
-	 * with GIF==0.
-	 */
-	while (test_and_set_bool(status->locked))
-		cpu_relax();
+	spin_lock_irqsave(&status->lock, flags);
 	status->count += enable ? 1 : -1;
+	ASSERT(status->count <= c->x86_num_siblings);
 	if (enable ? status->count == 1 : !status->count)
-		set_legacy_ssbd(c, enable);
-	barrier();
-	write_atomic(&status->locked, false);
+		BUG_ON(!set_legacy_ssbd(c, enable));
+	spin_unlock_irqrestore(&status->lock, flags);
+}
+
+void amd_set_ssbd(bool enable)
+{
+	if (opt_ssbd)
+		/*
+		 * Ignore attempts to turn off SSBD, it's hardcoded on the
+		 * command line.
+		 */
+		return;
+
+	if (cpu_has_virt_ssbd)
+		wrmsr(MSR_VIRT_SPEC_CTRL, enable ? SPEC_CTRL_SSBD : 0, 0);
+	else if (amd_legacy_ssbd)
+		core_set_legacy_ssbd(enable);
+	else
+		ASSERT_UNREACHABLE();
 }
 
 /*
diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S
index a26589aa9a..981cd82e7c 100644
--- a/xen/arch/x86/hvm/svm/entry.S
+++ b/xen/arch/x86/hvm/svm/entry.S
@@ -59,9 +59,6 @@ __UNLIKELY_END(nsvm_hap)
 
         clgi
 
-        ALTERNATIVE "", STR(call vmentry_virt_spec_ctrl), \
-                        X86_FEATURE_VIRT_SC_MSR_HVM
-
         /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */
         /* SPEC_CTRL_EXIT_TO_SVM       Req: b=curr %rsp=regs/cpuinfo, Clob: acd */
         .macro svm_vmentry_spec_ctrl
@@ -131,9 +128,6 @@ __UNLIKELY_END(nsvm_hap)
         ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM
         /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */
 
-        ALTERNATIVE "", STR(call vmexit_virt_spec_ctrl), \
-                        X86_FEATURE_VIRT_SC_MSR_HVM
-
         /*
          * STGI is executed unconditionally, and is sufficiently serialising
          * to safely resolve any Spectre-v1 concerns in the above logic.
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 1aeaabcb13..b2f147c11b 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -973,6 +973,16 @@ static void cf_check svm_ctxt_switch_from(struct vcpu *v)
 
     /* Resume use of ISTs now that the host TR is reinstated. */
     enable_each_ist(idt_tables[cpu]);
+
+    /*
+     * Clear previous guest selection of SSBD if set.  Note that SPEC_CTRL.SSBD
+     * is already cleared by svm_vmexit_spec_ctrl.
+     */
+    if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
+    {
+        ASSERT(v->domain->arch.cpuid->extd.virt_ssbd);
+        amd_set_ssbd(false);
+    }
 }
 
 static void cf_check svm_ctxt_switch_to(struct vcpu *v)
@@ -1000,6 +1010,13 @@ static void cf_check svm_ctxt_switch_to(struct vcpu *v)
 
     if ( cpu_has_msr_tsc_aux )
         wrmsr_tsc_aux(v->arch.msrs->tsc_aux);
+
+    /* Load SSBD if set by the guest. */
+    if ( v->arch.msrs->virt_spec_ctrl.raw & SPEC_CTRL_SSBD )
+    {
+        ASSERT(v->domain->arch.cpuid->extd.virt_ssbd);
+        amd_set_ssbd(true);
+    }
 }
 
 static void noreturn cf_check svm_do_resume(void)
@@ -2518,6 +2535,10 @@ static void cf_check svm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val)
         vmcb->spec_ctrl = val;
         break;
 
+    case MSR_VIRT_SPEC_CTRL:
+        amd_set_ssbd(val & SPEC_CTRL_SSBD);
+        break;
+
     default:
         printk(XENLOG_G_ERR "%s(%pv, 0x%08x, 0x%016"PRIx64") Bad register\n",
                __func__, v, reg, val);
@@ -3116,34 +3137,6 @@ void svm_vmexit_handler(struct cpu_user_regs *regs)
     vmcb_set_vintr(vmcb, intr);
 }
 
-/* Called with GIF=0. */
-void vmexit_virt_spec_ctrl(void)
-{
-    unsigned int val = opt_ssbd ? SPEC_CTRL_SSBD : 0;
-
-    if ( val == current->arch.msrs->virt_spec_ctrl.raw )
-        return;
-
-    if ( cpu_has_virt_ssbd )
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
-    else
-        amd_set_legacy_ssbd(val);
-}
-
-/* Called with GIF=0. */
-void vmentry_virt_spec_ctrl(void)
-{
-    unsigned int val = current->arch.msrs->virt_spec_ctrl.raw;
-
-    if ( val == (opt_ssbd ? SPEC_CTRL_SSBD : 0) )
-        return;
-
-    if ( cpu_has_virt_ssbd )
-        wrmsr(MSR_VIRT_SPEC_CTRL, val, 0);
-    else
-        amd_set_legacy_ssbd(val);
-}
-
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/x86/include/asm/amd.h b/xen/arch/x86/include/asm/amd.h
index 6a42f68542..81ed71710f 100644
--- a/xen/arch/x86/include/asm/amd.h
+++ b/xen/arch/x86/include/asm/amd.h
@@ -153,6 +153,6 @@ void amd_check_disable_c1e(unsigned int port, u8 value);
 
 extern bool amd_legacy_ssbd;
 bool amd_setup_legacy_ssbd(void);
-void amd_set_legacy_ssbd(bool enable);
+void amd_set_ssbd(bool enable);
 
 #endif /* __AMD_H__ */
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index 95416995a5..d15185cd48 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -697,7 +697,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
                 msrs->spec_ctrl.raw &= ~SPEC_CTRL_SSBD;
         }
         else
+        {
             msrs->virt_spec_ctrl.raw = val & SPEC_CTRL_SSBD;
+            if ( v == curr )
+                /*
+                 * Propagate the value to hardware, as it won't be context
+                 * switched on vmentry.
+                 */
+                goto set_reg;
+        }
         break;
 
     case MSR_AMD64_DE_CFG:
-- 
2.37.3



From xen-devel-bounces@lists.xenproject.org Sat Oct 29 14:21:06 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 14:21:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432365.685145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oomhe-0005mL-OR; Sat, 29 Oct 2022 14:20:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432365.685145; Sat, 29 Oct 2022 14:20:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oomhe-0005mE-Lh; Sat, 29 Oct 2022 14:20:50 +0000
Received: by outflank-mailman (input) for mailman id 432365;
 Sat, 29 Oct 2022 14:20:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oomhd-0005m4-5k; Sat, 29 Oct 2022 14:20:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oomhd-0003na-2t; Sat, 29 Oct 2022 14:20:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oomhc-0001aN-OT; Sat, 29 Oct 2022 14:20:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oomhc-000254-O2; Sat, 29 Oct 2022 14:20:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pmx1wq91sDjLoa3yN/BR7Uf/+M0RjcwaHhqjcSIi5nM=; b=0g71aAAjliMQI0ppE6yR10kej1
	sadOSPERtixThrh6WT1AAHZBU+7d41mvpO2iPwcs8eZ69ewY5kBSySuaahXpXqYqt4nSh32702DGN
	JdMM4mMCZ438i29KXdlYOQFND2tw8rcHHiwXOUt3n1+wx1P4Tj6BIEsicEheOMSUuF3c=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174538-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174538: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl:debian-fixup:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
X-Osstest-Versions-That:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 14:20:48 +0000

flight 174538 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174538/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 174534 pass in 174538
 test-amd64-amd64-xl          13 debian-fixup               fail pass in 174534

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174534
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174534
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174534
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174534
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174534
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174534
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174534
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174534
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174534
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174534
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174534
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174534
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
baseline version:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1

Last test of basis   174538  2022-10-29 06:33:22 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Oct 29 21:50:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 21:50:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432426.685156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ootiv-0000RM-4y; Sat, 29 Oct 2022 21:50:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432426.685156; Sat, 29 Oct 2022 21:50:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ootiv-0000RF-1j; Sat, 29 Oct 2022 21:50:37 +0000
Received: by outflank-mailman (input) for mailman id 432426;
 Sat, 29 Oct 2022 21:50:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ootit-0000R0-Ee; Sat, 29 Oct 2022 21:50:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ootit-0003Ab-BD; Sat, 29 Oct 2022 21:50:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1ootis-0001dr-KD; Sat, 29 Oct 2022 21:50:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1ootis-00011i-Jo; Sat, 29 Oct 2022 21:50:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OvZqTPBGoXu1YRo/Oxa4T4DCzP9WJjbOaQoT6bHYbfQ=; b=kqMeqKbKOQTebZF3jnml7eiHzI
	rnTUYPR60pGj8DV7MHSxBGoGtEqA78/opl1X9LXiI1tiEy1z4o22LRL+nMgtt9LNyTDd8HEDNpEo0
	O+FHF6j/FcAWD/JC+CdNjiWhf1zXws/RJsl0nJdwro/frGHc/4Q0MA8bkrmytbk/TEmk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174539-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174539: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=576e61cea1e4b66f52f164dee0edbe4b1c999997
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 21:50:34 +0000

flight 174539 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174539/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                576e61cea1e4b66f52f164dee0edbe4b1c999997
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   22 days
Failing since        173470  2022-10-08 06:21:34 Z   21 days   31 attempts
Testing same since   174535  2022-10-29 01:13:15 Z    0 days    2 attempts

------------------------------------------------------------
1496 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 139382 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 22:31:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 22:31:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432432.685167 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oouMC-0005ed-86; Sat, 29 Oct 2022 22:31:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432432.685167; Sat, 29 Oct 2022 22:31:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1oouMC-0005eW-3W; Sat, 29 Oct 2022 22:31:12 +0000
Received: by outflank-mailman (input) for mailman id 432432;
 Sat, 29 Oct 2022 22:31:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oouMA-0005eM-Ai; Sat, 29 Oct 2022 22:31:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oouMA-0003qi-6v; Sat, 29 Oct 2022 22:31:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1oouM9-0002Xn-Ly; Sat, 29 Oct 2022 22:31:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1oouM9-0004AW-LV; Sat, 29 Oct 2022 22:31:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/Ji+7moqkuAkKhy94ACxLTsUQ71spf4HfBBNUYl95Ag=; b=AvlKVdELy+DSTULRtJWTOEQi41
	9Dyxz0CmYqyGyu0u1BxW93YtLG77XBjdQ8KfKL0lQNYPnWALGG6qPfFkyrzIrKBa5P2zoXiDkQKht
	HHGHZ+XGw3LS9xq1+1O++j+kmpyTMsDP0Vd6QdwplnV8PXyymi21C5fchQswgZcXzOkA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174540-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 174540: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b70bfeb98635040588883503d2760e0f46231491
X-Osstest-Versions-That:
    linux=fe18f1af38a7999e05a6564c80d63e8d9df5ee60
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 29 Oct 2022 22:31:09 +0000

flight 174540 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174540/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174511
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174536
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174536
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174536
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174536
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174536
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174536
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174536
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174536
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174536
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174536
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174536
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                b70bfeb98635040588883503d2760e0f46231491
baseline version:
 linux                fe18f1af38a7999e05a6564c80d63e8d9df5ee60

Last test of basis   174536  2022-10-29 03:04:30 Z    0 days
Testing same since   174540  2022-10-29 12:41:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Potapenko <glider@google.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexey Dobriyan <adobriyan@gmail.com>
  Andrew Morton <akpm@linux-foundation.org>
  Ard Biesheuvel <ardb@kernel.org>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Borislav Petkov <bp@suse.de>
  Brian Foster <bfoster@redhat.com>
  Bryan O'Donoghue <bryan.odonoghue@linaro.org>
  Catalin Marinas <catalin.marinas@arm.com>
  Chandan Babu R <chandan.babu@oracle.com>
  Christoph Hellwig <hch@lst.de>
  Conor Dooley <conor.dooley@microchip.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Darrick J. Wong <darrick.wong@oracle.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Chinner <dchinner@redhat.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Eric Ren <renzhengeek@gmail.com>
  Filipe Manana <fdmanana@suse.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Gaurav Kohli <gauravkohli@linux.microsoft.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Harini Katakam <harini.katakam@amd.com>
  Jakub Kicinski <kuba@kernel.org>
  James Morse <james.morse@arm.com>
  Jean-Francois Le Fillatre <jflf_kernel@gmx.com>
  Jerry Snitselaar <jsnitsel@redhat.com>
  Joerg Roedel <jroedel@suse.de>
  Jon Hunter <jonathanh@nvidia.com>
  Joseph Qi <joseph.qi@linux.alibaba.com>
  José Expósito <jose.exposito89@gmail.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Len Brown <len.brown@intel.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lu Baolu <baolu.lu@linux.intel.com>
  Marc Zyngier <maz@kernel.org>
  Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
  Mauro Carvalho Chehab <mchehab@kernel.org>
  Nick Desaulniers <ndesaulniers@google.com>
  Pavel Reichl <preichl@redhat.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Sasha Levin <sashal@kernel.org>
  Seth Jenkins <sethjenkins@google.com>
  Stanimir Varbanov <stanimir.varbanov@linaro.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tony Luck <tony.luck@intel.com>
  Werner Sembach <wse@tuxedocomputers.com>
  Will Deacon <will@kernel.org>
  Xiaobo Liu <cppcoffee@gmail.com>
  Yang Yingliang <yangyingliang@huawei.com>
  Zhang Rui <rui.zhang@intel.com>
  Zhengchao Shao <shaozhengchao@huawei.com>
  Ștefan Talpalaru <stefantalpalaru@yahoo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   fe18f1af38a7..b70bfeb98635  b70bfeb98635040588883503d2760e0f46231491 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sat Oct 29 22:48:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 29 Oct 2022 22:48:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432439.685178 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooucl-0007m3-Pj; Sat, 29 Oct 2022 22:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432439.685178; Sat, 29 Oct 2022 22:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1ooucl-0007lw-MW; Sat, 29 Oct 2022 22:48:19 +0000
Received: by outflank-mailman (input) for mailman id 432439;
 Sat, 29 Oct 2022 22:48:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2MEd=26=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1oouck-0007lq-JU
 for xen-devel@lists.xenproject.org; Sat, 29 Oct 2022 22:48:18 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2051.outbound.protection.outlook.com [40.107.93.51])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c618025c-57db-11ed-8fd0-01056ac49cbb;
 Sun, 30 Oct 2022 00:48:17 +0200 (CEST)
Received: from DM6PR08CA0050.namprd08.prod.outlook.com (2603:10b6:5:1e0::24)
 by DM6PR12MB4925.namprd12.prod.outlook.com (2603:10b6:5:1b7::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sat, 29 Oct
 2022 22:48:13 +0000
Received: from CY4PEPF0000B8EE.namprd05.prod.outlook.com
 (2603:10b6:5:1e0:cafe::4d) by DM6PR08CA0050.outlook.office365.com
 (2603:10b6:5:1e0::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16 via Frontend
 Transport; Sat, 29 Oct 2022 22:48:13 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 CY4PEPF0000B8EE.mail.protection.outlook.com (10.167.241.10) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5723.20 via Frontend Transport; Sat, 29 Oct 2022 22:48:12 +0000
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 29 Oct
 2022 17:48:11 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Sat, 29 Oct 2022 17:48:10 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c618025c-57db-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IksFvbwPn0madVIVrgwmP0RR+9JANWDmd/PGqSDMLeiNiuCnDDC43+AUnkGlHXGhAQ30yoeclQQGLYe/YN7lISr45qcf03h2WgguqHWTInsS6ELTjSce5Tfgr3aWRaM66bDpdfs/7+vC5SP+uJcifpQgvbF6RDUJ+U/QE47vppBdyX8cb4alz7sJF31AV0Km1UXNrK7yNzsjZl+5P/aWZy88KYhyBIZXCo1hWEtp6qmUHrJKBXEPq/+Fd7hypedLTZTLNVCD3Kqyu5uFGGy9Sl5HAJDE/pjNLVnDvesRDgc8YbY2qrnk0n9YHELf3+ZVO9dpAwrHt5B49ZUYEbTn/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZYPO/ZJx5OoPn847hTGmKX837OvG63RvUdsnPCdXzUs=;
 b=lP0MIySkc8lSCAGuCcRR/8EityVRGvRtFE5AhylMfKuHiYP3bQ/+McgTz/TFiFMSgO/b/V98kTRLMy4WBe6pildYKL3HcCewz5L/HhPvmMiLOKacLaSPnScOFY9puKRwGNdNMlWRCyRW/DraavNSER5FCUQn80x/xojEJZME8mYrVCnPTn+QP8JVcdlXVLuV1HK6AgAKPoxSFzE/+8KjxcMw4LJO7KMtwRq12mWkTennIjz+xTgj1MRGxXZB/tThy8zspwjxL0vv6prnmO+wo571RusxS8prb32Dt6tQ4gGIsJAZB0xu6XrqmHdHQtyb1dGzzKrKsym36yutkyBG2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ZYPO/ZJx5OoPn847hTGmKX837OvG63RvUdsnPCdXzUs=;
 b=qgPC9qPTauHh6AY6oofj3IDYjYsoVUWzhQ5TJEuaLr1/caRrMYXYZk/0xViBsD9Ux/0VYSKTjbJdcbKyZ7/LsNvq9Bl26Anm4tkbGsZoKAAx3Wji3DIjU8/Bed1MkeRgiMFGoTZji4eLifChRv/pG/FA2jcOavbTQ3eRU+bpbS4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<andre.przywara@arm.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v1] xen/Arm: Enforce alignment check for atomic read/write
Date: Sat, 29 Oct 2022 23:48:02 +0100
Message-ID: <20221029224802.464-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EE:EE_|DM6PR12MB4925:EE_
X-MS-Office365-Filtering-Correlation-Id: 1cf0c26c-0999-4ac1-e6a1-08dab9ffa8b9
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YR90vqEmavmUqT+iD6csEi2DTGa1trLGF+FihRH4XHmd/LtJffPBD9y/MlRPPtnfBq0vVx2X34xbMZxKf/SLymdN08elvJb0RL5f6HjadKYDGQ24TdaHEUjQyxyOZEmHxhMoUEvZjb8kCWLK5wSNYfnpyc1azUxFzrVFls51DwRzfbRdBe4w2GS9nJv8X6uv6AhRBj9IN1M2Ga3PvQCj6hP66qv9xPTqs9SdxWhqeVeHa4B5qNcsYixFLIVx83X8pCgxv8s5z1P85fTfj9oAPGNuTpOxCp+DCyh9URhXXXLJcg5YEiK15kjFSFoYlMt8OhgRXHaFqqSJTNpiNFBaqe0T65LsAwuSFcwNiV71alYE2PEl27qrSY6h50ocTGMlpw2q0Rva3lcJETteSPiHDHi210cK+m0NCh1SSH9X0ibsdQJKXn7wHieUVNADaVOqrEj2+xSGl/tFhghSGHkmZ6KUMhGg3TWFyeMM4578XYKUJhkRbGr1BfK/+ZjOZbhtTc+DeLWq8SLb0/1HCS3mirj099VM0eFBsVJDE5BSWb5VRZirgF8v4yXLTsri3rYPkqY0dRcD8x2EDUpn9kuIomvaDxxLjt5fRR85Sa/4lSXnqXmAaNBchsyLEkpS5M2W+Q1wCZd/OtARswuCvhDJRMIagIcj4R/k9rkWI8/5HWRKKMu2wB898fabD0a7QBMHnfSoZztBf6hEhPjRLchx3usQBYsC5sUSmmhRvNimZufZce2J9c6HPPLtG7ED2GEhNgLmFW5ZALU18L7thX/RU+FdQ705N4ts3rMQnWJKq4tnPnbcpybgX3dAdKY3dIhTDFd1sP3AE9ygozXx6ieVHw==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(36840700001)(40470700004)(46966006)(8676002)(70206006)(70586007)(4326008)(2906002)(5660300002)(8936002)(41300700001)(40480700001)(82310400005)(966005)(36860700001)(26005)(478600001)(6666004)(316002)(54906003)(6916009)(426003)(81166007)(356005)(40460700003)(82740400003)(47076005)(186003)(1076003)(336012)(2616005)(36756003)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2022 22:48:12.3806
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cf0c26c-0999-4ac1-e6a1-08dab9ffa8b9
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CY4PEPF0000B8EE.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4925

Refer ARM DDI 0487G.b ID072021, B2.2.1
"Requirements for single-copy atomicity

- A read that is generated by a load instruction that loads a single
general-purpose register and is aligned to the size of the read in the
instruction is single-copy atomic.

-A write that is generated by a store instruction that stores a single
general-purpose register and is aligned to the size of the write in the
instruction is single-copy atomic"

On AArch32, the alignment check is enabled at boot time by setting HSCTLR.A bit.
("HSCTLR, Hyp System Control Register").
However in AArch64, alignment check is not enabled at boot time.

Thus, one needs to check for alignment when performing atomic operations.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

This came up during discussion https://www.mail-archive.com/xen-devel@lists.xenproject.org/msg131185.html

 xen/arch/arm/include/asm/atomic.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h
index 1f60c28b1b..64314d59b3 100644
--- a/xen/arch/arm/include/asm/atomic.h
+++ b/xen/arch/arm/include/asm/atomic.h
@@ -78,6 +78,7 @@ static always_inline void read_atomic_size(const volatile void *p,
                                            void *res,
                                            unsigned int size)
 {
+    ASSERT(IS_ALIGNED((vaddr_t)p, size));
     switch ( size )
     {
     case 1:
@@ -102,6 +103,7 @@ static always_inline void write_atomic_size(volatile void *p,
                                             void *val,
                                             unsigned int size)
 {
+    ASSERT(IS_ALIGNED((vaddr_t)p, size));
     switch ( size )
     {
     case 1:
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Sun Oct 30 06:34:46 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 06:34:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432460.685189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op1ts-0002mK-M5; Sun, 30 Oct 2022 06:34:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432460.685189; Sun, 30 Oct 2022 06:34:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op1ts-0002mC-Gs; Sun, 30 Oct 2022 06:34:28 +0000
Received: by outflank-mailman (input) for mailman id 432460;
 Sun, 30 Oct 2022 06:34:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op1tq-0002m2-Dp; Sun, 30 Oct 2022 06:34:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op1tq-0003Hy-9q; Sun, 30 Oct 2022 06:34:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op1tp-0006xX-Qp; Sun, 30 Oct 2022 06:34:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1op1tp-0003ZM-QQ; Sun, 30 Oct 2022 06:34:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6gjX1KJo9loO6QfIA08Eq2v/WOtMlU//P2MZTSasI1k=; b=2I7kJy4wrmpTGgUkqhMcutTlNJ
	7pMXAnExQ++dp1vO+LwW7r+mRzjNTLLa39W94B7sUsmK8inRsO7VUjBzZUMTvoamu2ZAQhDuIzIhr
	g1j/82FxJkNh6iku/Rzte24XYx2UXFCgE51xNg+u8MDkjf6GK3PCOwSWQSQHHyHxsclQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174541-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174541: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=91562cf99364dd29755988f3cc33ce9a46cd5b0a
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 30 Oct 2022 06:34:25 +0000

flight 174541 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174541/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                91562cf99364dd29755988f3cc33ce9a46cd5b0a
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   22 days
Failing since        173470  2022-10-08 06:21:34 Z   22 days   32 attempts
Testing same since   174541  2022-10-29 22:12:52 Z    0 days    1 attempts

------------------------------------------------------------
1496 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 139703 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 07:13:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 07:13:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432470.685200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VM-0007wz-IC; Sun, 30 Oct 2022 07:13:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432470.685200; Sun, 30 Oct 2022 07:13:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VM-0007ws-Ed; Sun, 30 Oct 2022 07:13:12 +0000
Received: by outflank-mailman (input) for mailman id 432470;
 Sun, 30 Oct 2022 07:13:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/jzH=27=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1op2VL-0007wm-I4
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 07:13:11 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4e000b9e-5822-11ed-8fd0-01056ac49cbb;
 Sun, 30 Oct 2022 08:13:09 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 6D9195C009C;
 Sun, 30 Oct 2022 03:13:07 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Sun, 30 Oct 2022 03:13:07 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 30 Oct 2022 03:13:05 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e000b9e-5822-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date
	:date:from:from:in-reply-to:message-id:mime-version:reply-to
	:sender:subject:subject:to:to; s=fm3; t=1667113987; x=
	1667200387; bh=ZJibAMbkI97/+xmZRF5cCgBS1DOG88E+xTgG4JMofdw=; b=F
	84YnTjyGRYkELLxxqxkrdOJ3LCm6QlhCm9N9taa7vw3TSdoh9HjV2ySaXDdQjcuG
	g2pPJZhvRplS/auXRnLr2ooRj0mssngLcwmkcr/mh4lzNEvC6590YACw+MBDCfqT
	h2+4ouXApeY1z5gLPhCXNVdrGJ/yjSvc1FNRSnHC8hu7hzHfFyXFEZK334X/WdZ6
	ED1XF2LAY9l4f6BsV6IaP+k6kBf2c3qGSrGu6+5ShayPVdqtuFDuwnwSaFG/SjYj
	/Zn5fThDGRyeoUTBmPZoXYJ+6Gnvlc/YmjyHIWZoQacVb0WVFK/YiQhmeBXrO0BK
	V5YTp3tS52SIbyCPYbC5g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:message-id
	:mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
	1667113987; x=1667200387; bh=ZJibAMbkI97/+xmZRF5cCgBS1DOG88E+xTg
	G4JMofdw=; b=eePFuxfuOizprmG6TJT3XF04VXNFqVbzOzFB726EFiG+NxL0hjj
	I7pBwPS8kT227cnchAIAdKXDO4r/xjX8BLcU9fD2YNZg08WBuqK2eP1HjSKdVjy7
	cEHiD/CnhuVpuVS40UB7rRvnSTOkZi4jnrtPCzXSuGjtuJb6UXy4r4IzdgLP/rF/
	Quw32gfXEBWKAcvXGFetGZy2yY4Ld5+xmCa+d2UclskH6fG0Ro72GNEBBtXC+3Vj
	2yuVTXcq4tXyud78oAwVl6RlWlx1QTp/qb8C4m6zlsa4aVpZ3eSdpnBcsTsYYn88
	VpA2iQlQyq5rjGtWSLj6A6PCuKxiOXHRXgQ==
X-ME-Sender: <xms:AiReY4Cp209zhX2mv9oHxPsCxZL9QGjWvVm9ddcpiLDpc8NFtESJ-A>
    <xme:AiReY6hHxuSOZrHruibhR8D0HyIosg4diaGChBv-4x243sTHFGHgyIWNk075gU1lP
    WRDDurwXCQkmPY>
X-ME-Received: <xmr:AiReY7nKDUOeDhlBOCkWU-ALGoux-Lau1VlpmFH-VUwBZ2B6UiVeAo9_hFYQPw26x1ydN5-kce0F>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgdduudekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo
    rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh
    grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek
    hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg
    hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr
    sgdrtghomh
X-ME-Proxy: <xmx:AiReY-zycIagbZnn9asuhUE3rgQb93apAnvKgnwK79ckZAzhhlwSrg>
    <xmx:AiReY9Q6K47KWDlvv1VmXtiShd39iVwp7cl0PX1iaBhAlLzafehMSA>
    <xmx:AiReY5YgmfOJesRNDBivOyiJzY7xLOVTq_FKRa_sVoUpI_TV18slpg>
    <xmx:AyReY-QLcQ3SUJ3rSMw60li0tw3Ru8V6XOC9A5QIK4BqHKKDibiygw>
Feedback-ID: iac594737:Fastmail
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: [PATCH 0/3] Stable backports of gntdev fixes
Date: Sun, 30 Oct 2022 03:12:40 -0400
Message-Id: <20221030071243.1580-1-demi@invisiblethingslab.com>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

I backported the recent gntdev patches to stable branches before 5.15.
The first patch is a prerequisite for the other backports.  The second
patch should apply cleanly to all stable branches, but the third only
applies to 5.10 as it requires mmu_interval_notifier_insert_locked().

Jan Beulich (1):
  Xen/gntdev: don't ignore kernel unmapping error

M. Vefa Bicakci (2):
  xen/gntdev: Prevent leaking grants
  xen/gntdev: Accommodate VMA splitting

 drivers/xen/gntdev-common.h |  3 +-
 drivers/xen/gntdev.c        | 88 +++++++++++++++++++++----------------
 2 files changed, 52 insertions(+), 39 deletions(-)

-- 
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 07:13:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 07:13:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432471.685211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VV-0008EX-QH; Sun, 30 Oct 2022 07:13:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432471.685211; Sun, 30 Oct 2022 07:13:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VV-0008EQ-Mi; Sun, 30 Oct 2022 07:13:21 +0000
Received: by outflank-mailman (input) for mailman id 432471;
 Sun, 30 Oct 2022 07:13:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/jzH=27=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1op2VU-0008Dn-Ii
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 07:13:20 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 529bb7ea-5822-11ed-91b5-6bf2151ebd3b;
 Sun, 30 Oct 2022 08:13:18 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 7D9E35C009A;
 Sun, 30 Oct 2022 03:13:15 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Sun, 30 Oct 2022 03:13:15 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 30 Oct 2022 03:13:14 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 529bb7ea-5822-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date
	:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:sender:subject:subject:to:to; s=fm3; t=
	1667113995; x=1667200395; bh=vJbgWUEbOHgWLPm7ppN5SvNsjatY4g8zRiC
	FyL+Xdn4=; b=IwHb1Zgz07Y3pVKscW2hU3i2Gk3zGfp/GIJEDSY1Lss/QbNU4KN
	qGzcy7D8wmGTR8+s7sXppPmh4KRx8dpUORuYucIm+RUGpnGrvt0+gnmR1ZC/PO4t
	r1aVb/4Mo027QXSmQo9QORe21bNc0Nm0KaAJh+hhnDLsvK4uMSPsHdBlWR7JuStf
	ZeEQyXf1lICQohjcILHY8OGKNOijySG8dVn/GBEBgb9YqhHVjDJOAYOiBfg8ERL6
	FWbTFQOlG9NWUoMWqT3tIAlfAqGYGUAQS3+rp/URv0HvZK1hdcSMJqZd64nmGbds
	mS+AEnn0p2dCDw3GCfwF5aiCRibL/lcexbw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; t=1667113995; x=1667200395; bh=vJbgWUEbOHgWL
	Pm7ppN5SvNsjatY4g8zRiCFyL+Xdn4=; b=YnAuvN76YQGIKkObsRtmsUAlXuVS/
	JEOrnqn5TBT4Ht3RE+VnSZ7fHsmwL6Mv6dksR5pBse1+Bs16ey+TSxk6Cp6T+z3f
	/S9/EwhDTraScgg7K8Sdsttaj50uOatQHIfEQIwaPuyGy8qmbYyol8n819AGbmm6
	H7FFwwBIHI3fVR5QXTtWi0Y8MnVj7K20kBmM9EsT86Fk/6cwDCIXsaSbKU8cJqu2
	oSV9mTnRBkZREziGyvfjR0+32O8O4CkwZWYmieWKr19jhQ6vlStL5ylxCg6neKvJ
	duBsWolhOOFGK2hTwhSRtUgDP9GA+02wZA8RUsxg3mcqZvtGm8g9G219Q==
X-ME-Sender: <xms:CyReY2hxLEv5GDzru_3jM0_L8IMuSZnhZjbzxx19z2t4qO85gzXqaw>
    <xme:CyReY3DVpfMVHtk1ZO1EXzU8tkL1pbBweI_OLejuJA0GrXkAUdsjJVuEKGmjyXlZw
    m8AxeiTPfZPJWI>
X-ME-Received: <xmr:CyReY-HY_pVboPrCGLOrIj_T_2jFucY2vDXR3_8cyG2VLCqvJbxYAU6KJlnmk9KN4tH2mR9IrRkO>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgdduudekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepkeevkeevgedufffggfelkeduueek
    teelgfevlefhheeutdefvdfgkeelhfetgfefnecuffhomhgrihhnpehkvghrnhgvlhdroh
    hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu
    vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm
X-ME-Proxy: <xmx:CyReY_TpqyY7z-qjLgnlactBTBVdNMGtomxgHe6g2xqKFLxjkilLaA>
    <xmx:CyReYzyZl2zdNc_2gVFCQX8wkllfDL_aIoF5gRgCPwAt8AjBYxNSEw>
    <xmx:CyReY97CbjzVVBiPETh6z5vbGB5ehu1PfwHDJGmz8lef-hemxn79vQ>
    <xmx:CyReY6m7CfG1C9-7uwBDgdWdD66SITudXdnqA0O0SHruhmmu_0fuhw>
Feedback-ID: iac594737:Fastmail
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Demi Marie Obenour <demi@invisiblethingslab.com>
Subject: [PATCH 1/3] Xen/gntdev: don't ignore kernel unmapping error
Date: Sun, 30 Oct 2022 03:12:41 -0400
Message-Id: <20221030071243.1580-2-demi@invisiblethingslab.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221030071243.1580-1-demi@invisiblethingslab.com>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Jan Beulich <jbeulich@suse.com>

commit f28347cc66395e96712f5c2db0a302ee75bafce6 upstream.

While working on XSA-361 and its follow-ups, I failed to spot another
place where the kernel mapping part of an operation was not treated the
same as the user space part. Detect and propagate errors and add a 2nd
pr_debug().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/c2513395-74dc-aea3-9192-fd265aa44e35@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Co-authored-by: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 drivers/xen/gntdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 54fee4087bf1078803c230ad2081aafa8415cf53..8cf9f2074c5d57bff81364d7d6a70b0007a85e44 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -407,6 +407,14 @@ static void __unmap_grant_pages_done(int result,
 			map->unmap_ops[offset+i].handle,
 			map->unmap_ops[offset+i].status);
 		map->unmap_ops[offset+i].handle = -1;
+		if (use_ptemod) {
+			WARN_ON(map->kunmap_ops[offset+i].status &&
+				map->kunmap_ops[offset+i].handle != -1);
+			pr_debug("kunmap handle=%u st=%d\n",
+				 map->kunmap_ops[offset+i].handle,
+				 map->kunmap_ops[offset+i].status);
+			map->kunmap_ops[offset+i].handle = -1;
+		}
 	}
 	/*
 	 * Decrease the live-grant counter.  This must happen after the loop to
-- 
2.38.1


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 07:13:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 07:13:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432472.685221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VX-0008Ur-5n; Sun, 30 Oct 2022 07:13:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432472.685221; Sun, 30 Oct 2022 07:13:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VX-0008Ui-2j; Sun, 30 Oct 2022 07:13:23 +0000
Received: by outflank-mailman (input) for mailman id 432472;
 Sun, 30 Oct 2022 07:13:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/jzH=27=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1op2VV-0008Dn-BH
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 07:13:21 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 544f1d54-5822-11ed-91b5-6bf2151ebd3b;
 Sun, 30 Oct 2022 08:13:19 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 55F655C00A5;
 Sun, 30 Oct 2022 03:13:18 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 30 Oct 2022 03:13:18 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 30 Oct 2022 03:13:16 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 544f1d54-5822-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date
	:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:sender:subject:subject:to:to; s=fm3; t=
	1667113998; x=1667200398; bh=LGUTbFYKx/IAmswm/E+Mt+qNJPB4ZgOwy8T
	Xo7c4Lqc=; b=dLdYbx3R3u+KO33HPmxYo+LStlRoMXxR3d1Q4x8Ljspm2tu90M7
	ujUaqSfOX0Py8Yb1W4jQK0Aj41sZKEF9NsFuJsU00AiIjvg3Q7EloGVNrbXJykEk
	IWAh7wGjoUqPbOO6egHuVVW9GRq6Y+p2c6gZjndP/rzTgiNMeI4Uokhe9yq2juyn
	trQbNOZwzz4HK4j+UiW6e0DWjyeTJVeOPkdQbRps2zzVBKByEBZsUAm4wbfGCcR1
	367j5uvwlR0fl2ryrhEx3Me26uuSJ1ePbMoi2eSwxe1N1z6X8ymzoxNE+PoT8iKN
	pP3QwOLJiJJmNkDoK/wBD2c1+i/p0Oo3/cQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; t=1667113998; x=1667200398; bh=LGUTbFYKx/IAm
	swm/E+Mt+qNJPB4ZgOwy8TXo7c4Lqc=; b=oj7ZEzf8U2UZUzhqThJzZdNGbAik7
	PXGDGrFlDC48ZZGP+ZqeofDn4fim4WJKsmRzqLey5ORU4e+DaYDZZu8/72NLUpR6
	ZAbliWxkm2ZUFxhq/du6FaeX9Xjx9dtzxxTupb/CCt1uSGG4mVs4+Bd7SoNSw+vk
	nPuH1Qx2ezkBWiNhlOodfVnRhPn8N7jbjGBYznCnze4xrSXog8qbwwIYrLccuAz5
	K3STQ9NZuFeHT+2gPL3zHIM8Q09710WPR5rtlfthjp1CTLktT8h061dmJaLr80i/
	XjKDIaB7L1J9a2nmosH36MTFtBylSSz5hI3sIdPPmshHIYLzkBdMjH45g==
X-ME-Sender: <xms:DSReYxsNi6xDc9WWA8xVra5LkwJCzb1pXUOl4Xjldk1zAZTJfL8Ejw>
    <xme:DSReY6fy1CsJ723k4T63JEO6Iv1l8vI1oXWvBBfL7qH_Chpr5YmONTsspWdkCm87Z
    aZyaxfEmljnCXo>
X-ME-Received: <xmr:DSReY0yzAXdZy-LmwtNVF1WRTZKwzhPTHL5S6YedlutuhIOQjKP31o55x_oP4KM6hdGZGd_xDBjD>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgdduudekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh
    veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg
    homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
    pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg
    homh
X-ME-Proxy: <xmx:DSReY4MLw6kdj0O68nzgpG_nUnozF3trz9zdnK22tnniuRFaKXI_tA>
    <xmx:DSReYx9da_e9cj06ZisW_gQi7Vy8N1TpMzRhM0X9hpC8UG0H45DJpA>
    <xmx:DSReY4Uc2wnjKcxrQBB4Yd338wcPAbp4-JNaJQc75pu1DYSItwdoZQ>
    <xmx:DiReY9QG9DBkWaxf9hf4EExrvEP58XZKD9zZ3w4V7o3SHh0jE_HCyA>
Feedback-ID: iac594737:Fastmail
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: "M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Demi Marie Obenour <demi@invisiblethingslab.com>
Subject: [PATCH 2/3] xen/gntdev: Prevent leaking grants
Date: Sun, 30 Oct 2022 03:12:42 -0400
Message-Id: <20221030071243.1580-3-demi@invisiblethingslab.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221030071243.1580-1-demi@invisiblethingslab.com>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: "M. Vefa Bicakci" <m.v.b@runbox.com>

commit 0991028cd49567d7016d1b224fe0117c35059f86 upstream.

Prior to this commit, if a grant mapping operation failed partially,
some of the entries in the map_ops array would be invalid, whereas all
of the entries in the kmap_ops array would be valid. This in turn would
cause the following logic in gntdev_map_grant_pages to become invalid:

  for (i = 0; i < map->count; i++) {
    if (map->map_ops[i].status == GNTST_okay) {
      map->unmap_ops[i].handle = map->map_ops[i].handle;
      if (!use_ptemod)
        alloced++;
    }
    if (use_ptemod) {
      if (map->kmap_ops[i].status == GNTST_okay) {
        if (map->map_ops[i].status == GNTST_okay)
          alloced++;
        map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
      }
    }
  }
  ...
  atomic_add(alloced, &map->live_grants);

Assume that use_ptemod is true (i.e., the domain mapping the granted
pages is a paravirtualized domain). In the code excerpt above, note that
the "alloced" variable is only incremented when both kmap_ops[i].status
and map_ops[i].status are set to GNTST_okay (i.e., both mapping
operations are successful).  However, as also noted above, there are
cases where a grant mapping operation fails partially, breaking the
assumption of the code excerpt above.

The aforementioned causes map->live_grants to be incorrectly set. In
some cases, all of the map_ops mappings fail, but all of the kmap_ops
mappings succeed, meaning that live_grants may remain zero. This in turn
makes it impossible to unmap the successfully grant-mapped pages pointed
to by kmap_ops, because unmap_grant_pages has the following snippet of
code at its beginning:

  if (atomic_read(&map->live_grants) == 0)
    return; /* Nothing to do */

In other cases where only some of the map_ops mappings fail but all
kmap_ops mappings succeed, live_grants is made positive, but when the
user requests unmapping the grant-mapped pages, __unmap_grant_pages_done
will then make map->live_grants negative, because the latter function
does not check if all of the pages that were requested to be unmapped
were actually unmapped, and the same function unconditionally subtracts
"data->count" (i.e., a value that can be greater than map->live_grants)
from map->live_grants. The side effects of a negative live_grants value
have not been studied.

The net effect of all of this is that grant references are leaked in one
of the above conditions. In Qubes OS v4.1 (which uses Xen's grant
mechanism extensively for X11 GUI isolation), this issue manifests
itself with warning messages like the following to be printed out by the
Linux kernel in the VM that had granted pages (that contain X11 GUI
window data) to dom0: "g.e. 0x1234 still pending", especially after the
user rapidly resizes GUI VM windows (causing some grant-mapping
operations to partially or completely fail, due to the fact that the VM
unshares some of the pages as part of the window resizing, making the
pages impossible to grant-map from dom0).

The fix for this issue involves counting all successful map_ops and
kmap_ops mappings separately, and then adding the sum to live_grants.
During unmapping, only the number of successfully unmapped grants is
subtracted from live_grants. The code is also modified to check for
negative live_grants values after the subtraction and warn the user.

Link: https://github.com/QubesOS/qubes-issues/issues/7631
Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")
Cc: stable@vger.kernel.org
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
Acked-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20221002222006.2077-2-m.v.b@runbox.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
---
 drivers/xen/gntdev.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 8cf9f2074c5d57bff81364d7d6a70b0007a85e44..62a65122c73fbfe673405ce90a53c5f364b75082 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -372,8 +372,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
 	for (i = 0; i < map->count; i++) {
 		if (map->map_ops[i].status == GNTST_okay) {
 			map->unmap_ops[i].handle = map->map_ops[i].handle;
-			if (!use_ptemod)
-				alloced++;
+			alloced++;
 		} else if (!err)
 			err = -EINVAL;
 
@@ -382,8 +381,7 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map)
 
 		if (use_ptemod) {
 			if (map->kmap_ops[i].status == GNTST_okay) {
-				if (map->map_ops[i].status == GNTST_okay)
-					alloced++;
+				alloced++;
 				map->kunmap_ops[i].handle = map->kmap_ops[i].handle;
 			} else if (!err)
 				err = -EINVAL;
@@ -399,8 +397,14 @@ static void __unmap_grant_pages_done(int result,
 	unsigned int i;
 	struct gntdev_grant_map *map = data->data;
 	unsigned int offset = data->unmap_ops - map->unmap_ops;
+	int successful_unmaps = 0;
+	int live_grants;
 
 	for (i = 0; i < data->count; i++) {
+		if (map->unmap_ops[offset + i].status == GNTST_okay &&
+		    map->unmap_ops[offset + i].handle != -1)
+			successful_unmaps++;
+
 		WARN_ON(map->unmap_ops[offset+i].status &&
 			map->unmap_ops[offset+i].handle != -1);
 		pr_debug("unmap handle=%d st=%d\n",
@@ -408,6 +412,10 @@ static void __unmap_grant_pages_done(int result,
 			map->unmap_ops[offset+i].status);
 		map->unmap_ops[offset+i].handle = -1;
 		if (use_ptemod) {
+			if (map->kunmap_ops[offset + i].status == GNTST_okay &&
+			    map->kunmap_ops[offset + i].handle != -1)
+				successful_unmaps++;
+
 			WARN_ON(map->kunmap_ops[offset+i].status &&
 				map->kunmap_ops[offset+i].handle != -1);
 			pr_debug("kunmap handle=%u st=%d\n",
@@ -416,11 +424,15 @@ static void __unmap_grant_pages_done(int result,
 			map->kunmap_ops[offset+i].handle = -1;
 		}
 	}
+
 	/*
 	 * Decrease the live-grant counter.  This must happen after the loop to
 	 * prevent premature reuse of the grants by gnttab_mmap().
 	 */
-	atomic_sub(data->count, &map->live_grants);
+	live_grants = atomic_sub_return(successful_unmaps, &map->live_grants);
+	if (WARN_ON(live_grants < 0))
+		pr_err("%s: live_grants became negative (%d) after unmapping %d pages!\n",
+		       __func__, live_grants, successful_unmaps);
 
 	/* Release reference taken by __unmap_grant_pages */
 	gntdev_put_map(NULL, map);
-- 
2.38.1


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 07:13:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 07:13:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432473.685233 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VZ-0000Li-Ec; Sun, 30 Oct 2022 07:13:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432473.685233; Sun, 30 Oct 2022 07:13:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op2VZ-0000LX-BC; Sun, 30 Oct 2022 07:13:25 +0000
Received: by outflank-mailman (input) for mailman id 432473;
 Sun, 30 Oct 2022 07:13:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/jzH=27=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1op2VX-0008Dn-8I
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 07:13:23 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 561f8869-5822-11ed-91b5-6bf2151ebd3b;
 Sun, 30 Oct 2022 08:13:22 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 6477E5C009A;
 Sun, 30 Oct 2022 03:13:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Sun, 30 Oct 2022 03:13:21 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 30 Oct 2022 03:13:20 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 561f8869-5822-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date
	:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:sender:subject:subject:to:to; s=fm3; t=
	1667114001; x=1667200401; bh=Mo8RRVU/BCqu317V/TpNAiSZ8pju9kQTzGf
	3AAdnqs4=; b=dfcMRjyrXKkQpQBS2ci3HT1FA9DjFGnBeJHxaHlC2YWMZyKXbcD
	u4gflN0UpK3yanFBNARtumJ2QSY4VUFaOqJqqcndU4OdfsVgXvUz8O12EJHpj3xN
	5YTs90DRWA0anrEVH6vRWr+mpzJ8KC0ieg+evYLhAwEkmt/tE16Jgnf8TQHmVB/M
	LpCZDu/wzaVHfLYuTX843kIMdVjOFYwRI+eCdgs1184yyqm+lTeyEFZse9IsQ+eC
	D1g9bXszG4JaO6eVP/2pr0Z2cXysBUDAkWcS3ZG5H8w1YN+9EVlnhH7EeiLiF7XA
	Kk2jc7BwrKsWeeWYBbeVmf+Ta6TF34a4mzQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; t=1667114001; x=1667200401; bh=Mo8RRVU/BCqu3
	17V/TpNAiSZ8pju9kQTzGf3AAdnqs4=; b=NvntkGDBdJs9WghcSChl7hqL8t+fR
	mSWTzvbiAn4NEPDaPwEz6hSPwP6o6byVOn5WN3RBfnqDwqHgbct9zVc8dyNmbPAP
	aZQBBSIrBKqwx/04AZe9KC8YBAseu+lUH9Ky526b6Mq3hJCsQYvJsHmlNvqpvYGd
	i+Mo5sotrWQfPAK2qDSQ2Ronm8DkUZ1iY4AvnAiRYfNLFOkxCwiqqUoXSpRU7tR0
	IAAuOTqlqC9oBPeHnMJyI8x5aRYS84zZioG5liJHF2lbyAwKyTF4HuG8gGjyuZzc
	a8ynS4nH2PsMw0FBZJfR+lpUYTDelfZS96M4eMdHvdcuFj3kbqKceObfg==
X-ME-Sender: <xms:ESReY3fmnVwL94JEkzhDwa65hRTPc2FaSdW87HTrTJV9efEEJ1DADg>
    <xme:ESReY9Mm9Dsm4FnNQTyM8B_qDv5jd7gJy1MOlOUPu043VCCULYJGK9UK0aHhPhhUs
    AsI8IzGJl9Y0o4>
X-ME-Received: <xmr:ESReYwhyup1UUjVCT3C5drltDC-tDoqHY2Jt0lXjdQRvwQz2QPzKG7R0U1nNCoVE0FvkFKOhs0mZ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdelgdduudekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh
    veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg
    homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm
    pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg
    homh
X-ME-Proxy: <xmx:ESReY48pGf_ssKyBeNnYBMA2IrJa7vPuyIBPHzhkIT5niEWQu655hQ>
    <xmx:ESReYzvwJMdFOUzjAkTtidZ2I19TJKQwZyHjxYMNIdry76jBRiXuKA>
    <xmx:ESReY3Hn2RsQhwTur-d0KjuR2S2CjAgQOkIWie59HsGro6btMgwfmQ>
    <xmx:ESReY88LUcu9mvwZJ2Milelj5pQ2__0c3F7RVk4IsH-hmW04sjmx4Q>
Feedback-ID: iac594737:Fastmail
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	=?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: "M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: [PATCH 3/3] xen/gntdev: Accommodate VMA splitting
Date: Sun, 30 Oct 2022 03:12:43 -0400
Message-Id: <20221030071243.1580-4-demi@invisiblethingslab.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221030071243.1580-1-demi@invisiblethingslab.com>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: "M. Vefa Bicakci" <m.v.b@runbox.com>

Prior to this commit, the gntdev driver code did not handle the
following scenario correctly with paravirtualized (PV) Xen domains:

* User process sets up a gntdev mapping composed of two grant mappings
  (i.e., two pages shared by another Xen domain).
* User process munmap()s one of the pages.
* User process munmap()s the remaining page.
* User process exits.

In the scenario above, the user process would cause the kernel to log
the following messages in dmesg for the first munmap(), and the second
munmap() call would result in similar log messages:

  BUG: Bad page map in process doublemap.test  pte:... pmd:...
  page:0000000057c97bff refcount:1 mapcount:-1 \
    mapping:0000000000000000 index:0x0 pfn:...
  ...
  page dumped because: bad pte
  ...
  file:gntdev fault:0x0 mmap:gntdev_mmap [xen_gntdev] readpage:0x0
  ...
  Call Trace:
   <TASK>
   dump_stack_lvl+0x46/0x5e
   print_bad_pte.cold+0x66/0xb6
   unmap_page_range+0x7e5/0xdc0
   unmap_vmas+0x78/0xf0
   unmap_region+0xa8/0x110
   __do_munmap+0x1ea/0x4e0
   __vm_munmap+0x75/0x120
   __x64_sys_munmap+0x28/0x40
   do_syscall_64+0x38/0x90
   entry_SYSCALL_64_after_hwframe+0x61/0xcb
   ...

For each munmap() call, the Xen hypervisor (if built with CONFIG_DEBUG)
would print out the following and trigger a general protection fault in
the affected Xen PV domain:

  (XEN) d0v... Attempt to implicitly unmap d0's grant PTE ...
  (XEN) d0v... Attempt to implicitly unmap d0's grant PTE ...

As of this writing, gntdev_grant_map structure's vma field (referred to
as map->vma below) is mainly used for checking the start and end
addresses of mappings. However, with split VMAs, these may change, and
there could be more than one VMA associated with a gntdev mapping.
Hence, remove the use of map->vma and rely on map->pages_vm_start for
the original start address and on (map->count << PAGE_SHIFT) for the
original mapping size. Let the invalidate() and find_special_page()
hooks use these.

Also, given that there can be multiple VMAs associated with a gntdev
mapping, move the "mmu_interval_notifier_remove(&map->notifier)" call to
the end of gntdev_put_map, so that the MMU notifier is only removed
after the closing of the last remaining VMA.

Finally, use an atomic to prevent inadvertent gntdev mapping re-use,
instead of using the map->live_grants atomic counter and/or the map->vma
pointer (the latter of which is now removed). This prevents the
userspace from mmap()'ing (with MAP_FIXED) a gntdev mapping over the
same address range as a previously set up gntdev mapping. This scenario
can be summarized with the following call-trace, which was valid prior
to this commit:

  mmap
    gntdev_mmap
  mmap (repeat mmap with MAP_FIXED over the same address range)
    gntdev_invalidate
      unmap_grant_pages (sets 'being_removed' entries to true)
        gnttab_unmap_refs_async
    unmap_single_vma
    gntdev_mmap (maps the shared pages again)
  munmap
    gntdev_invalidate
      unmap_grant_pages
        (no-op because 'being_removed' entries are true)
    unmap_single_vma (For PV domains, Xen reports that a granted page
      is being unmapped and triggers a general protection fault in the
      affected domain, if Xen was built with CONFIG_DEBUG)

The fix for this last scenario could be worth its own commit, but we
opted for a single commit, because removing the gntdev_grant_map
structure's vma field requires guarding the entry to gntdev_mmap(), and
the live_grants atomic counter is not sufficient on its own to prevent
the mmap() over a pre-existing mapping.

Link: https://github.com/QubesOS/qubes-issues/issues/7631
Fixes: ab31523c2fca ("xen/gntdev: allow usermode to map granted pages")
Cc: stable@vger.kernel.org
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20221002222006.2077-3-m.v.b@runbox.com
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/gntdev-common.h |  3 +-
 drivers/xen/gntdev.c        | 58 ++++++++++++++++---------------------
 2 files changed, 27 insertions(+), 34 deletions(-)

diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h
index 40ef379c28ab01a3a11008cb0f85a1b3fde134ca..9c286b2a19001616ae0e9986be13905891b5f5ff 100644
--- a/drivers/xen/gntdev-common.h
+++ b/drivers/xen/gntdev-common.h
@@ -44,9 +44,10 @@ struct gntdev_unmap_notify {
 };
 
 struct gntdev_grant_map {
+	atomic_t in_use;
 	struct mmu_interval_notifier notifier;
+	bool notifier_init;
 	struct list_head next;
-	struct vm_area_struct *vma;
 	int index;
 	int count;
 	int flags;
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index 62a65122c73fbfe673405ce90a53c5f364b75082..862de00cfe89209cf28f7e7e87cf325e40f1fc4b 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -276,6 +276,9 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map)
 		 */
 	}
 
+	if (use_ptemod && map->notifier_init)
+		mmu_interval_notifier_remove(&map->notifier);
+
 	if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
 		notify_remote_via_evtchn(map->notify.event);
 		evtchn_put(map->notify.event);
@@ -288,7 +291,7 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map)
 static int find_grant_ptes(pte_t *pte, unsigned long addr, void *data)
 {
 	struct gntdev_grant_map *map = data;
-	unsigned int pgnr = (addr - map->vma->vm_start) >> PAGE_SHIFT;
+	unsigned int pgnr = (addr - map->pages_vm_start) >> PAGE_SHIFT;
 	int flags = map->flags | GNTMAP_application_map | GNTMAP_contains_pte;
 	u64 pte_maddr;
 
@@ -513,11 +516,7 @@ static void gntdev_vma_close(struct vm_area_struct *vma)
 	struct gntdev_priv *priv = file->private_data;
 
 	pr_debug("gntdev_vma_close %p\n", vma);
-	if (use_ptemod) {
-		WARN_ON(map->vma != vma);
-		mmu_interval_notifier_remove(&map->notifier);
-		map->vma = NULL;
-	}
+
 	vma->vm_private_data = NULL;
 	gntdev_put_map(priv, map);
 }
@@ -545,29 +544,30 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn,
 	struct gntdev_grant_map *map =
 		container_of(mn, struct gntdev_grant_map, notifier);
 	unsigned long mstart, mend;
+	unsigned long map_start, map_end;
 
 	if (!mmu_notifier_range_blockable(range))
 		return false;
 
+	map_start = map->pages_vm_start;
+	map_end = map->pages_vm_start + (map->count << PAGE_SHIFT);
+
 	/*
 	 * If the VMA is split or otherwise changed the notifier is not
 	 * updated, but we don't want to process VA's outside the modified
 	 * VMA. FIXME: It would be much more understandable to just prevent
 	 * modifying the VMA in the first place.
 	 */
-	if (map->vma->vm_start >= range->end ||
-	    map->vma->vm_end <= range->start)
+	if (map_start >= range->end || map_end <= range->start)
 		return true;
 
-	mstart = max(range->start, map->vma->vm_start);
-	mend = min(range->end, map->vma->vm_end);
+	mstart = max(range->start, map_start);
+	mend = min(range->end, map_end);
 	pr_debug("map %d+%d (%lx %lx), range %lx %lx, mrange %lx %lx\n",
-			map->index, map->count,
-			map->vma->vm_start, map->vma->vm_end,
-			range->start, range->end, mstart, mend);
-	unmap_grant_pages(map,
-				(mstart - map->vma->vm_start) >> PAGE_SHIFT,
-				(mend - mstart) >> PAGE_SHIFT);
+		 map->index, map->count, map_start, map_end,
+		 range->start, range->end, mstart, mend);
+	unmap_grant_pages(map, (mstart - map_start) >> PAGE_SHIFT,
+			  (mend - mstart) >> PAGE_SHIFT);
 
 	return true;
 }
@@ -1047,18 +1047,15 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 		return -EINVAL;
 
 	pr_debug("map %d+%d at %lx (pgoff %lx)\n",
-			index, count, vma->vm_start, vma->vm_pgoff);
+		 index, count, vma->vm_start, vma->vm_pgoff);
 
 	mutex_lock(&priv->lock);
 	map = gntdev_find_map_index(priv, index, count);
 	if (!map)
 		goto unlock_out;
-	if (use_ptemod && map->vma)
+	if (!atomic_add_unless(&map->in_use, 1, 1))
 		goto unlock_out;
-	if (atomic_read(&map->live_grants)) {
-		err = -EAGAIN;
-		goto unlock_out;
-	}
+
 	refcount_inc(&map->users);
 
 	vma->vm_ops = &gntdev_vmops;
@@ -1079,15 +1076,16 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 			map->flags |= GNTMAP_readonly;
 	}
 
+	map->pages_vm_start = vma->vm_start;
+
 	if (use_ptemod) {
-		map->vma = vma;
 		err = mmu_interval_notifier_insert_locked(
 			&map->notifier, vma->vm_mm, vma->vm_start,
 			vma->vm_end - vma->vm_start, &gntdev_mmu_ops);
-		if (err) {
-			map->vma = NULL;
+		if (err)
 			goto out_unlock_put;
-		}
+
+		map->notifier_init = true;
 	}
 	mutex_unlock(&priv->lock);
 
@@ -1104,7 +1102,6 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 		 */
 		mmu_interval_read_begin(&map->notifier);
 
-		map->pages_vm_start = vma->vm_start;
 		err = apply_to_page_range(vma->vm_mm, vma->vm_start,
 					  vma->vm_end - vma->vm_start,
 					  find_grant_ptes, map);
@@ -1150,13 +1147,8 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
 out_unlock_put:
 	mutex_unlock(&priv->lock);
 out_put_map:
-	if (use_ptemod) {
+	if (use_ptemod)
 		unmap_grant_pages(map, 0, map->count);
-		if (map->vma) {
-			mmu_interval_notifier_remove(&map->notifier);
-			map->vma = NULL;
-		}
-	}
 	gntdev_put_map(priv, map);
 	return err;
 }
-- 
2.38.1


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 09:43:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 09:43:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432502.685245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op4qe-0002kd-Cf; Sun, 30 Oct 2022 09:43:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432502.685245; Sun, 30 Oct 2022 09:43:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op4qe-0002kW-7x; Sun, 30 Oct 2022 09:43:20 +0000
Received: by outflank-mailman (input) for mailman id 432502;
 Sun, 30 Oct 2022 09:43:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op4qc-0002kM-LK; Sun, 30 Oct 2022 09:43:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op4qc-0006qS-FW; Sun, 30 Oct 2022 09:43:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op4qb-0007NP-SE; Sun, 30 Oct 2022 09:43:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1op4qb-0001Gm-Rp; Sun, 30 Oct 2022 09:43:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XBMIYZzZ2aiLywe+EymYX+GMIKh9yxG3mfAHlfeDCto=; b=vIlioXwpAAQmVmsV6yhho8wHXO
	N1qtYB/WP3rYVwYX9FCAoaFq7MFetBjoiTSWvafPxzNtBVHqC1QBXWhK+0iMopSm7wLBm852n/fhP
	5WcFJOwIOHaQaMvgD+jSX5uX1KyHjSd4IYx+x5TFcyBNVUw7erq4dU52Vb7azvHhpV3Q=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174542-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174542: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
X-Osstest-Versions-That:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 30 Oct 2022 09:43:17 +0000

flight 174542 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174542/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174538
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174538
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174538
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174538
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174538
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174538
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174538
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174538
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174538
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174538
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174538
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174538
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
baseline version:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1

Last test of basis   174542  2022-10-30 01:53:35 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Oct 30 14:24:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 14:24:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432545.685255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op9EP-0001eZ-89; Sun, 30 Oct 2022 14:24:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432545.685255; Sun, 30 Oct 2022 14:24:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op9EP-0001eS-4n; Sun, 30 Oct 2022 14:24:09 +0000
Received: by outflank-mailman (input) for mailman id 432545;
 Sun, 30 Oct 2022 14:24:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oc5E=27=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1op9EN-0001eM-U4
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 14:24:08 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81f613b4-585e-11ed-91b5-6bf2151ebd3b;
 Sun, 30 Oct 2022 15:24:06 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 73FC660EC0;
 Sun, 30 Oct 2022 14:24:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23EBBC433D6;
 Sun, 30 Oct 2022 14:24:00 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81f613b4-585e-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1667139843;
	bh=jBziqfMkA2cHOCnx8zVMCzIoTtSw4yBB9eg3zJ8ftl0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZV7EOqslGRFszYUY8yMyJK35f9Ddkj1nLEEA7S9SyTpUPM2B52Te5+wzf2tIn5L07
	 fEserVZfrVAPwM3vXPnaojwVi8a7+Emwf0v1miaJyppTUYxUvY1tqeQEUG9TpJLXQA
	 z8jZA5jvHJPE/u+hu5aOcHYlNp1JJk6SVoytwQG3vNmwOY565mArCsUwoID3Y+T5Gi
	 nURB9mwa0Xf8R362SMZ9Lqq3aeftKn7HNp3NxjCSwkErPhG2qfL9MdiLluQa0EGqxK
	 uor9950GjmnBUYynPT+UbIuu9qC0Z0iA6/znMfvaWt9P9DKGNqLR3QTK16urSLWCQl
	 HiEgUDtRi+Htw==
Date: Sun, 30 Oct 2022 15:23:55 +0100 (CET)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    Xen developer discussion <xen-devel@lists.xenproject.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Michal Orzel <Michal.Orzel@arm.com>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
In-Reply-To: <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
Message-ID: <alpine.DEB.2.22.394.2210301523450.3408@ubuntu-linux-20-04-desktop>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com> <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org> <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com> <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org> <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org> <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-376676523-1667138621=:3408"
Content-ID: <alpine.DEB.2.22.394.2210301503490.3408@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-376676523-1667138621=:3408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210301503491.3408@ubuntu-linux-20-04-desktop>

On Fri, 28 Oct 2022, Julien Grall wrote:
> On 28/10/2022 14:13, Bertrand Marquis wrote:
> > > On 28 Oct 2022, at 14:06, Julien Grall <julien@xen.org> wrote:
> > > 
> > > Hi Rahul,
> > > 
> > > On 28/10/2022 13:54, Rahul Singh wrote:
> > > > > > > > > For ACPI, I would have expected the information to be found in
> > > > > > > > > the IOREQ.
> > > > > > > > > 
> > > > > > > > > So can you add more context why this is necessary for
> > > > > > > > > everyone?
> > > > > > > > We have information for IOMMU and Master-ID but we don’t have
> > > > > > > > information for linking vMaster-ID to pMaster-ID.
> > > > > > > 
> > > > > > > I am confused. Below, you are making the virtual master ID
> > > > > > > optional. So shouldn't this be mandatory if you really need the
> > > > > > > mapping with the virtual ID?
> > > > > > vMasterID is optional if user knows pMasterID is unique on the
> > > > > > system. But if pMasterId is not unique then user needs to provide
> > > > > > the vMasterID.
> > > > > 
> > > > > So the expectation is the user will be able to know that the pMasterID
> > > > > is uniq. This may be easy with a couple of SMMUs, but if you have 50+
> > > > > (as suggested above). This will become a pain on larger system.
> > > > > 
> > > > > IHMO, it would be much better if we can detect that in libxl (see
> > > > > below).
> > > > We can make the vMasterID compulsory to avoid complexity in libxl to
> > > > solve this
> > > 
> > > In general, complexity in libxl is not too much of problem.

I agree with this and also I agree with Julien's other statement:

"I am strongly in favor of libxl to modify it if it greatly improves the
user experience."

I am always in favor of reducing complexity for the user as they
typically can't deal with tricky details such as MasterIDs. In general,
I think we need more automation with our tooling.

However, it might not be as simple as adding support for automatically
generating IDs in libxl because we have 2 additional cases to support:
1) dom0less
2) statically built guests

For 1) we would need the same support also in Xen? Which means more
complexity in Xen.

2) are guests like Zephyr that consume a device tree at
build time instead of runtime. These guests are built specifically for a
given environment and it is not a problem to rebuild them for every Xen
release.

However I think it is going to be a problem if we have to run libxl to
get the device tree needed for the Zephyr build. That is because it
means that the Zephyr build system would have to learn how to compile
(or crosscompile) libxl in order to retrieve the data needed for its
input. Even for systems based on Yocto (Yocto already knows how to build
libxl) would cause issues because of internal dependencies this would
introduce.

So I think the automatic generation might be best done in another tool.

I think we need something like a script that takes a partial device tree
as input and provides a more detailed partial device tree as output with
the generated IDs.

If we did it that way, we could call the script from libxl, but also we
could call it separately from ImageBuilder for dom0less and Zephyr/Yocto
could also call it.

Basically we make it easier for everyone to use it. The only price to
pay is that it will be a bit less efficient for xl guests (one more
script to fork and exec) but I think is a good compromise.

Another advantage is that in fully static workflows we could call the
script ahead of time (e.g. from Lopper/ImageBuilder) and still have full
knowledge of the device tree of all the guests which is great from a
safety perspective.


> > I am a bit unsure about this strategy.
> > Currently xl has one configuration file where you put all Xen parameters.
> > The device tree is only needed by some guests to have a description of the
> > system they run on.
> > If we change the model and say that Xen configuration parameters are both in
> > the configuration and the device tree, we somehow enforce to have a device
> > tree even though some guests do not need it at all (for example Zephyr).
> 
> I think my approach was misunderstood because there is no change in the
> existing model.
> 
> What I am suggesting is to not introduce iommu_devid_map but instead let libxl
> allocate the virtual Master-ID and create the mapping with the physical
> Master-ID.
>
> Libxl would then update the property "iommus" in the device-tree with the
> allocated virtual Master-ID.
> 
> Each node in the partial device-tree would need to have a property
> to refer to the physical device just so we know how to update the "iommus".
> The list of device passthrough will still be specified in the configuration
> file. IOW, the partial device-tree is not directly involved in the
> configuration of the guest.
> 
> So far, I don't see a particular issue with this approach because the vMaster
> ID algorithm allocation should be generic. But please let me know if you think
> there are bits I am missing.
>
> For everything else we let the user in control (IPA for mapping, virtual interrupt number) and in this case we switch to a model where we
> automatically generated a vMaster ID.

I think this is a great idea, I only suggest that we move the automatic
generation out of libxl (a separate stand-alone script), in another
place that can be more easily reused by multiple projects and different
use-cases.
--8323329-376676523-1667138621=:3408--


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 14:31:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 14:31:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432550.685265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op9Lr-0003IX-W1; Sun, 30 Oct 2022 14:31:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432550.685265; Sun, 30 Oct 2022 14:31:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1op9Lr-0003IQ-TE; Sun, 30 Oct 2022 14:31:51 +0000
Received: by outflank-mailman (input) for mailman id 432550;
 Sun, 30 Oct 2022 14:31:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op9Lq-0003IG-E3; Sun, 30 Oct 2022 14:31:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op9Lp-000383-KB; Sun, 30 Oct 2022 14:31:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1op9Lo-0005Et-Vu; Sun, 30 Oct 2022 14:31:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1op9Lo-00084T-VQ; Sun, 30 Oct 2022 14:31:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kJCzSl319H0Grk1bsEwU4I8Q/D1SFITDDeEeReMZPXI=; b=X7keS6JOyEZfyCKL2NlPnyYChM
	nOaswFdi8RnU6bBTPDAyspaYUVyZLHfeYBdA0Q+alPIDSqCdBy6G0dhdJ/WJN2+LfYpULZric8fYR
	IAiCIdaradP0pyOkoTdLkAaLRPOXK18VQPyNze5PoE2GZ7PQtFTIk2OaxtDbgnRlvdzY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174543-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174543: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=882ad2a2a8ffa1defecdf907052f04da2737dc46
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 30 Oct 2022 14:31:48 +0000

flight 174543 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174543/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10  fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                882ad2a2a8ffa1defecdf907052f04da2737dc46
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   22 days
Failing since        173470  2022-10-08 06:21:34 Z   22 days   33 attempts
Testing same since   174543  2022-10-30 06:39:20 Z    0 days    1 attempts

------------------------------------------------------------
1512 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 141175 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 16:37:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 16:37:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432565.685277 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opBJE-0001KF-09; Sun, 30 Oct 2022 16:37:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432565.685277; Sun, 30 Oct 2022 16:37:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opBJD-0001K8-TX; Sun, 30 Oct 2022 16:37:15 +0000
Received: by outflank-mailman (input) for mailman id 432565;
 Sun, 30 Oct 2022 16:37:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ZhP/=27=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1opBJD-0001K2-7u
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 16:37:15 +0000
Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com
 [209.85.214.179]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b260964-5871-11ed-91b5-6bf2151ebd3b;
 Sun, 30 Oct 2022 17:37:13 +0100 (CET)
Received: by mail-pl1-f179.google.com with SMTP id c2so8852993plz.11
 for <xen-devel@lists.xenproject.org>; Sun, 30 Oct 2022 09:37:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b260964-5871-11ed-91b5-6bf2151ebd3b
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=VmRryiIhsBZrJWe9dZMnKrws2g1r0LIPunYSsFhLBeU=;
        b=s4nffNlcAmrgMc9aHVCme51KhReSCr1c1ebakGdK+L6ZUy05tNgdjRTfOBeGrnV/NL
         JYADtlvMiXBa5poWlD6FDx8EWQiM5hdLHXceuVS5/cdmILuZQuMU7dSKOOoOjTFJwBIL
         TpV9rXZKyPgsTr+47sEQkLbL+vxl2sOutczrCYgF5AncoWo3al2zTTyDlDKiZsTfhlTt
         kKqHNpEAy3PVupy+73QvDKi9sT3OYEpqqTMWWnMIQO7a+4ld5e/TK/pQkaQOFYQUGb4N
         6wa3DkCJlLHPHgmYMe9pPsoigOLqSYZn9ETPboTBcqD/RAOLVtYbg6z0JjF+Z62zvkWc
         Razg==
X-Gm-Message-State: ACrzQf3koEE1Z2GTEtxhGYTBUgRjt6/alK7fLdvvdoP/7mkVYn7ouoF/
	52ojDbGLCvXvROljw4fGQB8dA0F3cwGMqLZoxkI=
X-Google-Smtp-Source: AMsMyM6Txmb9vm84kuPRw2bOFh4ZSw1Dc0vY4I9iPpctVlZc/dx/9/fnBXr7BlotWDPPPsHl34VFbV61e2LdOdzu/PU=
X-Received: by 2002:a17:90b:60e:b0:212:d5cd:4e58 with SMTP id
 gb14-20020a17090b060e00b00212d5cd4e58mr10568850pjb.165.1667147832202; Sun, 30
 Oct 2022 09:37:12 -0700 (PDT)
MIME-Version: 1.0
References: <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
 <Ycw4Jna5J2iQJyeM@Air-de-Roger> <Ycyx65BDakqWmEe+@Air-de-Roger>
 <CAKhsbWYU5_DGbGK2i_uhooXk4EzCLLO4SJGjDsvAkf2udQGsbg@mail.gmail.com>
 <Yc3/ytwCHFtR1BLi@Air-de-Roger> <CAKhsbWbRinNavBq4NnQ64nVrfWoOQWV0mM3Foao4VBYUWjoSnQ@mail.gmail.com>
 <YdQgf2+E467kuTxK@Air-de-Roger> <CAKhsbWbrvF6M-SAocACO5NvBaitUQ9mB5Qx+fMGtn_yVu0ZvEA@mail.gmail.com>
 <YdWsPWqALWBRGtqW@Air-de-Roger> <CAKhsbWbvjEcA220TTHGB3PPbfLmdS_MuK5Mn3Xvrr+JL=dHK7w@mail.gmail.com>
 <YdxIbLYRYh4hvVGj@Air-de-Roger>
In-Reply-To: <YdxIbLYRYh4hvVGj@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Mon, 31 Oct 2022 00:36:59 +0800
Message-ID: <CAKhsbWYHhveuwTjaiSGKCqf41nSHZKdt7W_y0qp-x09Pce22SA@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 10, 2022 at 10:54 PM Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
> > So looks like at least the imbalance between two directions are not
> > related to your patch.
> > Likely the debug build is a bigger contributor to the perf difference
> > in both directions.
> >
> > I also tried your patch on a release build, and didn't observe any
> > major difference in iperf3 numbers.
> > Roughly match the 30Gbps and 1.xGbps number on the stock release kernel=
.
>
> Thanks a lot, will try to get this upstream then.
>
> Roger.

Hi Roger, any news for the upstream fix? I haven't heard any news since...
The reason I came back to this thread is that I totally forgot about
this issue and upgraded to FreeNAS 13 only to rediscover this issue
once again :-(

Any chance the patch can apply on FreeBSD 13.1-RELEASE-p1 kernel?

Thanks,
G.R.


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 19:57:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 19:57:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432606.685288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opEQi-0007ac-95; Sun, 30 Oct 2022 19:57:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432606.685288; Sun, 30 Oct 2022 19:57:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opEQi-0007aV-4p; Sun, 30 Oct 2022 19:57:12 +0000
Received: by outflank-mailman (input) for mailman id 432606;
 Sun, 30 Oct 2022 19:57:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1opEQg-0007aP-RX
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 19:57:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1opEQg-0000Sy-58; Sun, 30 Oct 2022 19:57:10 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1opEQf-0004En-SE; Sun, 30 Oct 2022 19:57:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject:
	From:References:Cc:To:MIME-Version:Date:Message-ID;
	bh=LrfQUR1ESsIiExLE9T71EUICjGNZbStHapp0Prm9lKA=; b=qSIV31L3tZZfhyy/5ReNuiXwrs
	w9FMq75V627PzdXT99j2d29JTTZ97rc1TOZJ2CbTtqBjHUo1ACCLpfQjsOqL7huZhFcGDkpwsoMTQ
	/JOayCVUfuP+XxvIqryCpB58ziN0w+2NIdA2hyjsWJAyhlbaa3v2r0exzHcSPKpVwdqk=;
Message-ID: <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org>
Date: Sun, 30 Oct 2022 19:57:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>,
 Xen developer discussion <xen-devel@lists.xenproject.org>,
 Michal Orzel <Michal.Orzel@arm.com>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
 <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
 <alpine.DEB.2.22.394.2210301523450.3408@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
In-Reply-To: <alpine.DEB.2.22.394.2210301523450.3408@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Stefano,

On 30/10/2022 14:23, Stefano Stabellini wrote:
> On Fri, 28 Oct 2022, Julien Grall wrote:
>> On 28/10/2022 14:13, Bertrand Marquis wrote:
>>>> On 28 Oct 2022, at 14:06, Julien Grall <julien@xen.org> wrote:
>>>>
>>>> Hi Rahul,
>>>>
>>>> On 28/10/2022 13:54, Rahul Singh wrote:
>>>>>>>>>> For ACPI, I would have expected the information to be found in
>>>>>>>>>> the IOREQ.
>>>>>>>>>>
>>>>>>>>>> So can you add more context why this is necessary for
>>>>>>>>>> everyone?
>>>>>>>>> We have information for IOMMU and Master-ID but we don’t have
>>>>>>>>> information for linking vMaster-ID to pMaster-ID.
>>>>>>>>
>>>>>>>> I am confused. Below, you are making the virtual master ID
>>>>>>>> optional. So shouldn't this be mandatory if you really need the
>>>>>>>> mapping with the virtual ID?
>>>>>>> vMasterID is optional if user knows pMasterID is unique on the
>>>>>>> system. But if pMasterId is not unique then user needs to provide
>>>>>>> the vMasterID.
>>>>>>
>>>>>> So the expectation is the user will be able to know that the pMasterID
>>>>>> is uniq. This may be easy with a couple of SMMUs, but if you have 50+
>>>>>> (as suggested above). This will become a pain on larger system.
>>>>>>
>>>>>> IHMO, it would be much better if we can detect that in libxl (see
>>>>>> below).
>>>>> We can make the vMasterID compulsory to avoid complexity in libxl to
>>>>> solve this
>>>>
>>>> In general, complexity in libxl is not too much of problem.
> 
> I agree with this and also I agree with Julien's other statement:
> 
> "I am strongly in favor of libxl to modify it if it greatly improves the
> user experience."
> 
> I am always in favor of reducing complexity for the user as they
> typically can't deal with tricky details such as MasterIDs. In general,
> I think we need more automation with our tooling.
> 
> However, it might not be as simple as adding support for automatically
> generating IDs in libxl because we have 2 additional cases to support:
> 1) dom0less
> 2) statically built guests
> 
> For 1) we would need the same support also in Xen? Which means more
> complexity in Xen.
Xen will need to parse the device-tree to find the mapping. So I am not 
entirely convinced there will be more complexity needed other than 
requiring a bitmap to know which vMasterID has been allocated.

That said, you would still need one to validate the input provided by 
the user. So overall maybe there will be no added complexity?

> 
> 2) are guests like Zephyr that consume a device tree at
> build time instead of runtime. These guests are built specifically for a
> given environment and it is not a problem to rebuild them for every Xen
> release.
> 
> However I think it is going to be a problem if we have to run libxl to
> get the device tree needed for the Zephyr build. That is because it
> means that the Zephyr build system would have to learn how to compile
> (or crosscompile) libxl in order to retrieve the data needed for its
> input. Even for systems based on Yocto (Yocto already knows how to build
> libxl) would cause issues because of internal dependencies this would
> introduce.

That would not be very different to how this works today for Zephyr. 
They need libxl to generate the guest DT.

That said, I agree this is a bit of a pain...

> 
> So I think the automatic generation might be best done in another tool.
It sounds like what you want is creating something similar to libacpi 
but for Device-Tree. That should work with some caveats.

> 
> I think we need something like a script that takes a partial device tree
> as input and provides a more detailed partial device tree as output with
> the generated IDs.

AFAICT, having the partial device-tree is not enough. You also need the 
real DT to figure out the pMaster-ID.

> 
> If we did it that way, we could call the script from libxl, but also we
> could call it separately from ImageBuilder for dom0less and Zephyr/Yocto
> could also call it.
> 
> Basically we make it easier for everyone to use it. The only price to
> pay is that it will be a bit less efficient for xl guests (one more
> script to fork and exec) but I think is a good compromise.

We would need an hypercall to retrieve the host Device-Tree. But that 
would not be too difficult to add.

[...]

> 
> I think this is a great idea, I only suggest that we move the automatic
> generation out of libxl (a separate stand-alone script), in another
> place that can be more easily reused by multiple projects and different
> use-cases.

If we use the concept of libacpi, we may not need a to have a 
stand-alone script. It could directly linked in libxl or any other tools.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 21:14:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 21:14:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432629.685299 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opFdR-0000AF-0o; Sun, 30 Oct 2022 21:14:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432629.685299; Sun, 30 Oct 2022 21:14:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opFdQ-0000A2-Tx; Sun, 30 Oct 2022 21:14:24 +0000
Received: by outflank-mailman (input) for mailman id 432629;
 Sun, 30 Oct 2022 21:14:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oc5E=27=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1opFdP-00009Y-D8
 for xen-devel@lists.xenproject.org; Sun, 30 Oct 2022 21:14:23 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2e97300-5897-11ed-91b5-6bf2151ebd3b;
 Sun, 30 Oct 2022 22:14:22 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 9D324B80DA8;
 Sun, 30 Oct 2022 21:14:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91896C433D6;
 Sun, 30 Oct 2022 21:14:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2e97300-5897-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1667164460;
	bh=XciBK2+w7UmHSTsPArQZvPuCyUtZHsyvPyqXMoFOLBs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=h6brfdAx72B71SWDADb3fszm8xNVHiPG+kwdGhajt+RtgsSp5MYLJAmE3fLG/4GAC
	 2JjlDJs63n2LiKIY4JTvXFm7GY7muresHxpPcHrmDQPlIQQ+hFxPw0kRvK+Kfx/xJp
	 iFOCH46qCskBq2W2GMapJsa+6TB5vabriPr3bCN7VkH7k113RPOTwVUcl8ZXS6nZU7
	 qdci0zPInauvhgYJEGNpsIDxFEt8mEBA8ZfbHQXQd4PL/RHAasyQY/xk+TpYjikO/K
	 hwsrRVXHV2gk7KL/s/xDOp1lYHpPx0A2Jg0rUA2FlIB5eT/8rqKUX9XFZ/O5zCFhcd
	 o/iFp9J195zJw==
Date: Sun, 30 Oct 2022 22:14:15 +0100 (CET)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Rahul Singh <Rahul.Singh@arm.com>, 
    Xen developer discussion <xen-devel@lists.xenproject.org>, 
    Michal Orzel <Michal.Orzel@arm.com>, 
    Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>, 
    Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Jan Beulich <jbeulich@suse.com>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
In-Reply-To: <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org>
Message-ID: <alpine.DEB.2.22.394.2210302148150.3408@ubuntu-linux-20-04-desktop>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com> <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org> <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com> <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org> <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org> <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com> <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org> <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com> <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
 <alpine.DEB.2.22.394.2210301523450.3408@ubuntu-linux-20-04-desktop> <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1834020026-1667163085=:3408"
Content-ID: <alpine.DEB.2.22.394.2210302151350.3408@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1834020026-1667163085=:3408
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2210302151351.3408@ubuntu-linux-20-04-desktop>

On Sun, 30 Oct 2022, Julien Grall wrote:
> Hi Stefano,
> 
> On 30/10/2022 14:23, Stefano Stabellini wrote:
> > On Fri, 28 Oct 2022, Julien Grall wrote:
> > > On 28/10/2022 14:13, Bertrand Marquis wrote:
> > > > > On 28 Oct 2022, at 14:06, Julien Grall <julien@xen.org> wrote:
> > > > > 
> > > > > Hi Rahul,
> > > > > 
> > > > > On 28/10/2022 13:54, Rahul Singh wrote:
> > > > > > > > > > > For ACPI, I would have expected the information to be
> > > > > > > > > > > found in
> > > > > > > > > > > the IOREQ.
> > > > > > > > > > > 
> > > > > > > > > > > So can you add more context why this is necessary for
> > > > > > > > > > > everyone?
> > > > > > > > > > We have information for IOMMU and Master-ID but we don’t
> > > > > > > > > > have
> > > > > > > > > > information for linking vMaster-ID to pMaster-ID.
> > > > > > > > > 
> > > > > > > > > I am confused. Below, you are making the virtual master ID
> > > > > > > > > optional. So shouldn't this be mandatory if you really need
> > > > > > > > > the
> > > > > > > > > mapping with the virtual ID?
> > > > > > > > vMasterID is optional if user knows pMasterID is unique on the
> > > > > > > > system. But if pMasterId is not unique then user needs to
> > > > > > > > provide
> > > > > > > > the vMasterID.
> > > > > > > 
> > > > > > > So the expectation is the user will be able to know that the
> > > > > > > pMasterID
> > > > > > > is uniq. This may be easy with a couple of SMMUs, but if you have
> > > > > > > 50+
> > > > > > > (as suggested above). This will become a pain on larger system.
> > > > > > > 
> > > > > > > IHMO, it would be much better if we can detect that in libxl (see
> > > > > > > below).
> > > > > > We can make the vMasterID compulsory to avoid complexity in libxl to
> > > > > > solve this
> > > > > 
> > > > > In general, complexity in libxl is not too much of problem.
> > 
> > I agree with this and also I agree with Julien's other statement:
> > 
> > "I am strongly in favor of libxl to modify it if it greatly improves the
> > user experience."
> > 
> > I am always in favor of reducing complexity for the user as they
> > typically can't deal with tricky details such as MasterIDs. In general,
> > I think we need more automation with our tooling.
> > 
> > However, it might not be as simple as adding support for automatically
> > generating IDs in libxl because we have 2 additional cases to support:
> > 1) dom0less
> > 2) statically built guests
> > 
> > For 1) we would need the same support also in Xen? Which means more
> > complexity in Xen.
> Xen will need to parse the device-tree to find the mapping. So I am not
> entirely convinced there will be more complexity needed other than requiring a
> bitmap to know which vMasterID has been allocated.
> 
> That said, you would still need one to validate the input provided by the
> user. So overall maybe there will be no added complexity?
> 
> > 
> > 2) are guests like Zephyr that consume a device tree at
> > build time instead of runtime. These guests are built specifically for a
> > given environment and it is not a problem to rebuild them for every Xen
> > release.
> > 
> > However I think it is going to be a problem if we have to run libxl to
> > get the device tree needed for the Zephyr build. That is because it
> > means that the Zephyr build system would have to learn how to compile
> > (or crosscompile) libxl in order to retrieve the data needed for its
> > input. Even for systems based on Yocto (Yocto already knows how to build
> > libxl) would cause issues because of internal dependencies this would
> > introduce.
> 
> That would not be very different to how this works today for Zephyr. They need
> libxl to generate the guest DT.
> 
> That said, I agree this is a bit of a pain...

Yeah..


> > So I think the automatic generation might be best done in another tool.
> It sounds like what you want is creating something similar to libacpi but for
> Device-Tree. That should work with some caveats.

Yes, something like that. We have a framework for reading, editing and
generating Device Tree: Lopper https://github.com/devicetree-org/lopper

It is mostly targeted at build time but it could also be invoked on
target at runtime.

 
> > I think we need something like a script that takes a partial device tree
> > as input and provides a more detailed partial device tree as output with
> > the generated IDs.
> 
> AFAICT, having the partial device-tree is not enough. You also need the real
> DT to figure out the pMaster-ID.
> 
> > 
> > If we did it that way, we could call the script from libxl, but also we
> > could call it separately from ImageBuilder for dom0less and Zephyr/Yocto
> > could also call it.
> > 
> > Basically we make it easier for everyone to use it. The only price to
> > pay is that it will be a bit less efficient for xl guests (one more
> > script to fork and exec) but I think is a good compromise.
> 
> We would need an hypercall to retrieve the host Device-Tree. But that would
> not be too difficult to add.

Good point


> > I think this is a great idea, I only suggest that we move the automatic
> > generation out of libxl (a separate stand-alone script), in another
> > place that can be more easily reused by multiple projects and different
> > use-cases.
> 
> If we use the concept of libacpi, we may not need a to have a stand-alone
> script. It could directly linked in libxl or any other tools.
 
I don't feel strongly whether it should be a library, a script or
something else. My only point is that it should be easy to use both at
build time (e.g. Yocto/Zephyr/ImageBuilder/Lopper) and runtime
(xl/libxl).

We have already a partial DTB generator as a Lopper "lop" (a Lopper
plugin). Probably using Lopper would be the easiest way to implement it,
and the "lop" could be under xen.git (it doesn't have to reside under
the lopper repository).

But if we wanted a library that would be OK too. The issue with libxl is
not much that it is a library but that it is complex to build and has
many dependencies (it can only be built from the top level ./configure
and make).

Ideally this would be something quick that can be easily invoked as the
first step of an external third-party build process.
--8323329-1834020026-1667163085=:3408--


From xen-devel-bounces@lists.xenproject.org Sun Oct 30 22:05:58 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 30 Oct 2022 22:05:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432637.685310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opGRA-0006Zh-O1; Sun, 30 Oct 2022 22:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432637.685310; Sun, 30 Oct 2022 22:05:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opGRA-0006Za-LA; Sun, 30 Oct 2022 22:05:48 +0000
Received: by outflank-mailman (input) for mailman id 432637;
 Sun, 30 Oct 2022 22:05:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opGR9-0006ZQ-Ih; Sun, 30 Oct 2022 22:05:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opGR9-0002c4-Bq; Sun, 30 Oct 2022 22:05:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opGR8-00020D-Os; Sun, 30 Oct 2022 22:05:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opGR8-00061g-OT; Sun, 30 Oct 2022 22:05:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DOnPXrdP5auCWK602Ry0+8ATrDZjW0Ooc1jHYCFJ83U=; b=5zdqljFvqOLEktOSpTBAGxE4pL
	YGUwYICQLpWzeIcyV/8T3MY7kDRUoqQ3RcyM2Z5rZSb7RMiP6twYtairWWN5c9GFHsqRpZUNoUFGb
	h7xXrjwOto3c/mzBgAkz/UFOJ4QK0bIw9h2/J82WM/Zo5R6iRQR2dFuC0rJtiHhqdATg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174544-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174544: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=882ad2a2a8ffa1defecdf907052f04da2737dc46
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 30 Oct 2022 22:05:46 +0000

flight 174544 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174544/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                882ad2a2a8ffa1defecdf907052f04da2737dc46
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   23 days
Failing since        173470  2022-10-08 06:21:34 Z   22 days   34 attempts
Testing same since   174543  2022-10-30 06:39:20 Z    0 days    2 attempts

------------------------------------------------------------
1512 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 141175 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 05:50:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 05:50:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432659.685321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opNgN-0008Ld-5T; Mon, 31 Oct 2022 05:49:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432659.685321; Mon, 31 Oct 2022 05:49:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opNgN-0008LV-0L; Mon, 31 Oct 2022 05:49:59 +0000
Received: by outflank-mailman (input) for mailman id 432659;
 Mon, 31 Oct 2022 05:49:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opNgM-0008LL-3g; Mon, 31 Oct 2022 05:49:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opNgL-00029p-Kg; Mon, 31 Oct 2022 05:49:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opNgL-0001VL-07; Mon, 31 Oct 2022 05:49:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opNgK-00050H-UQ; Mon, 31 Oct 2022 05:49:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ebj9/eOHU5zw8sLFSsf1rKLrBT0Uuumk9vNkjYs+dKk=; b=dP1DkzoAFuy/Zsn3oVnqSskq/h
	XEeYX9+7YbXCHju7+5iUWy3SINpagapbuxrjzR6ROvIK1dKQLaOxR1Mn7XTKnsutXC7udgP0/kRJa
	X4SO5+2BJ3hbbBQrixGXvGsRzc1ILuHpskLqRPxiITHfU0z+saoQF3Ioe09WMb1GrKQ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174545-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174545: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b72018ab8236c3ae427068adeb94bdd3f20454ec
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 05:49:56 +0000

flight 174545 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174545/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                b72018ab8236c3ae427068adeb94bdd3f20454ec
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   23 days
Failing since        173470  2022-10-08 06:21:34 Z   22 days   35 attempts
Testing same since   174545  2022-10-30 22:12:19 Z    0 days    1 attempts

------------------------------------------------------------
1528 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 143054 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 06:34:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 06:34:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432666.685331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opON7-0006i7-Hn; Mon, 31 Oct 2022 06:34:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432666.685331; Mon, 31 Oct 2022 06:34:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opON7-0006i0-FF; Mon, 31 Oct 2022 06:34:09 +0000
Received: by outflank-mailman (input) for mailman id 432666;
 Mon, 31 Oct 2022 06:34:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opON6-0006hq-5O; Mon, 31 Oct 2022 06:34:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opON6-0002wp-1U; Mon, 31 Oct 2022 06:34:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opON5-0003qp-Li; Mon, 31 Oct 2022 06:34:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opON5-00020U-LE; Mon, 31 Oct 2022 06:34:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xWGZ5eDKVcsOwwYKkWKBkQwOP01b2FmdJearP2Oy6H4=; b=5LGyB57/oEm7aD1XmMx1Egaf5W
	M41d47nGVXwxf9XqmyisBJODEjIbZjEv3sE0faIRu4zsj8+US5reW+vusRkfaV3XvcKP1eaigyWnx
	i9+zbOEhSnckUG/BuCGD01wXKavKdrdRC8qQ8/vlwImokQfQu0/uLe72ZlByVefR6Y+4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174548-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174548: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=52199bf5326a8355d28b2d395db483f7c77d5a4d
X-Osstest-Versions-That:
    ovmf=d98efb468211ab508710eac91761238e1f5c1d51
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 06:34:07 +0000

flight 174548 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174548/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 52199bf5326a8355d28b2d395db483f7c77d5a4d
baseline version:
 ovmf                 d98efb468211ab508710eac91761238e1f5c1d51

Last test of basis   174528  2022-10-28 09:11:52 Z    2 days
Testing same since   174548  2022-10-31 03:12:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cheripally Gopi <gopic@ami.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   d98efb4682..52199bf532  52199bf5326a8355d28b2d395db483f7c77d5a4d -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 07:24:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 07:24:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432678.685342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opP99-0004Lg-8k; Mon, 31 Oct 2022 07:23:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432678.685342; Mon, 31 Oct 2022 07:23:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opP99-0004LZ-5M; Mon, 31 Oct 2022 07:23:47 +0000
Received: by outflank-mailman (input) for mailman id 432678;
 Mon, 31 Oct 2022 07:23:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eVFZ=3A=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1opP97-0004LT-Cx
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 07:23:45 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f1c7ae62-58ec-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 08:23:43 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7FA5160FF8;
 Mon, 31 Oct 2022 07:23:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68D9FC433D6;
 Mon, 31 Oct 2022 07:23:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1c7ae62-58ec-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1667201019;
	bh=Io6zd5E1x1tJ/A9M6wscatLJ3A4vcR7XMXt55LhYVlM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=rxgrY6l/YrO7UgwPm7uvOk1I0IqGWoWy8vQIiIZi+nKCmQAtC3eoqTg6LzFy8hDS/
	 L7t+Up37mXudXsWdX754npknNRx52BSV1gk5OQzmU+EhYBPsinXNpCnIblFjbb3fmF
	 XEitYEI81AgR4/bWn11D7ZU99wB56rj0oIRvhhGA=
Date: Mon, 31 Oct 2022 08:24:35 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Sasha Levin <sashal@kernel.org>,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	"M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 3/3] xen/gntdev: Accommodate VMA splitting
Message-ID: <Y194M/6GboCwWiZX@kroah.com>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
 <20221030071243.1580-4-demi@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221030071243.1580-4-demi@invisiblethingslab.com>

On Sun, Oct 30, 2022 at 03:12:43AM -0400, Demi Marie Obenour wrote:
> From: "M. Vefa Bicakci" <m.v.b@runbox.com>
> 
> Prior to this commit, the gntdev driver code did not handle the
> following scenario correctly with paravirtualized (PV) Xen domains:

This is already in 5.10.152, do we need to add it again?

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 07:24:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 07:24:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432679.685354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opP9M-0004d6-GW; Mon, 31 Oct 2022 07:24:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432679.685354; Mon, 31 Oct 2022 07:24:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opP9M-0004cz-Dv; Mon, 31 Oct 2022 07:24:00 +0000
Received: by outflank-mailman (input) for mailman id 432679;
 Mon, 31 Oct 2022 07:23:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eVFZ=3A=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1opP9L-0004cg-DZ
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 07:23:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb22addb-58ec-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 08:23:57 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6B15C60FF8;
 Mon, 31 Oct 2022 07:23:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79924C433C1;
 Mon, 31 Oct 2022 07:23:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb22addb-58ec-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1667201035;
	bh=/l+bnPa+QpO2aKJ1A1iRYqzj0CbaaJY5jam4oQUCoSc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=uRkFDgMKqIQ4lED1kKnYIKCcFBuVk1Zi0YPILaM1iY5qbtHyYN3ri3myorYz7IcQu
	 wvMWiZgVCgHAxcJVbOmuFF9ZVhve3VJ3O04Luq6l+RPJsNhrG1WDS5CUO5xHA4svuj
	 G5WWNLvDlTguUdrqyOBSaCZSE9cZyQu5ymYMZNgY=
Date: Mon, 31 Oct 2022 08:24:51 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Sasha Levin <sashal@kernel.org>,
	Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 0/3] Stable backports of gntdev fixes
Message-ID: <Y194Q9lH3ye4jJOU@kroah.com>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221030071243.1580-1-demi@invisiblethingslab.com>

On Sun, Oct 30, 2022 at 03:12:40AM -0400, Demi Marie Obenour wrote:
> I backported the recent gntdev patches to stable branches before 5.15.
> The first patch is a prerequisite for the other backports.  The second
> patch should apply cleanly to all stable branches, but the third only
> applies to 5.10 as it requires mmu_interval_notifier_insert_locked().

Patches 1 and 2 now queued up, see my comments on 3.

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 08:47:40 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 08:47:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432709.685369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opQS6-0006dJ-Uk; Mon, 31 Oct 2022 08:47:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432709.685369; Mon, 31 Oct 2022 08:47:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opQS6-0006dC-RS; Mon, 31 Oct 2022 08:47:26 +0000
Received: by outflank-mailman (input) for mailman id 432709;
 Mon, 31 Oct 2022 08:47:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opQS5-0006d2-Hi; Mon, 31 Oct 2022 08:47:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opQS5-0005ct-Eb; Mon, 31 Oct 2022 08:47:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opQS4-0002PH-V1; Mon, 31 Oct 2022 08:47:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opQS4-0007oi-UY; Mon, 31 Oct 2022 08:47:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=19TULHPskKPCJ850viOAHV8HJTEpeHpcCnXFmS9vC6A=; b=MvoLpeYnacBv8VLQa/S6lzurpc
	5Z0SqEn3muH/OG1RGlUPR7An9y4o9VM1wtoFajZLL3aTKFMS5XP5LHhy+vXBa2S7giiiOT9qNv7BG
	nM0B9DIry6MlS9UBLiN+s9cR+sGazhcINgVr6cwZTGTuNoh4Fhi+wftUnB0CpuLj5CgE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174546-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174546: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=75d30fde55485b965a1168a21d016dd07b50ed32
X-Osstest-Versions-That:
    qemuu=344744e148e6e865f5a57e745b02a87e5ea534ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 08:47:24 +0000

flight 174546 qemu-mainline real [real]
flight 174551 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174546/
http://logs.test-lab.xenproject.org/osstest/logs/174551/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 174551-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174507
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174507
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174507
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174507
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174507
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174507
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174507
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174507
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                75d30fde55485b965a1168a21d016dd07b50ed32
baseline version:
 qemuu                344744e148e6e865f5a57e745b02a87e5ea534ad

Last test of basis   174507  2022-10-27 14:30:43 Z    3 days
Testing same since   174546  2022-10-30 22:37:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ake Koomsin <ake@igel.co.jp>
  Alex Bennée <alex.bennee@linaro.org>
  Alexander Ivanov <alexander.ivanov@virtuozzo.com>
  Axel Heider <axel.heider@hensoldt.net>
  Bjørn Forsman <bjorn.forsman@gmail.com>
  Damien Hedde <damien.hedde@greensocs.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Konstantin Kostiuk <kkostiuk@redhat.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Markus Armbruster <armbru@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   344744e148..75d30fde55  75d30fde55485b965a1168a21d016dd07b50ed32 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 09:26:56 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 09:26:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432729.685379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opR4E-00037J-73; Mon, 31 Oct 2022 09:26:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432729.685379; Mon, 31 Oct 2022 09:26:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opR4E-00037C-4Q; Mon, 31 Oct 2022 09:26:50 +0000
Received: by outflank-mailman (input) for mailman id 432729;
 Mon, 31 Oct 2022 09:26:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CXQ+=3A=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1opR4D-000376-4J
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 09:26:49 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2428a044-58fe-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 10:26:47 +0100 (CET)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AS8PR04MB8706.eurprd04.prod.outlook.com (2603:10a6:20b:429::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Mon, 31 Oct
 2022 09:26:45 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022
 09:26:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2428a044-58fe-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jIRNEsAllMSIAnLWqCatL3K88IzTJuo3h/2WlItfCNWezoMLO+quNSejAtyYmb5m+PiSoXmVsi/zvJitq2Zk5X8PsQxbt957RHItX5JNn9sBOPpobDmZGqo+0CIPTflgPZooTHwljIgAPbBAvx4jXCpUo8x9eh/7C/UuCVTvLzJnpiOlY6G3ntYfKk1Hc3+44WyEFG2f/B3Fdo+p/KVYpDfuDs6Q3kzBLt+NV9lCItz57pTfTnSvuA/NUPYzLqQR3skPPg45T6qrN+GQSkRXbmn2WsjUc0le0alFF35+M14MJ1DtTdO2nodwLguHJsqRmrIXUdh9WwKTr8R2kgxjhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QTlqkDrR386OTIQSyronbV5SigiCTNsZ6FGukga/31I=;
 b=nRHRSWlrPaL7p1YMbCGqMvu76oxKoY8/7nqkpjdaBPX2DB8tk2Gr0gzXpNRkMpeq49lnjee47GMaHrLJx3rJs6lO4spLwYUy1YkoBvVdUSEsVcQKrI1RhA8pJTfeCASoqD0mp/qPnTSJzuqMIorIBpTRdC593dX5NnqpUXBzAEo51oqjHLKpBTwy1lkdSQTK3X/SYR66a1irckF1bWHODfQZ3ymiU7uvvEg29Wrf02i29yUTY11voLv071SYsUHEoDGVlu8E4462320c8dgV/FvuCt/8/xKmnSkkNItKUtieyAuKYhCJIY0xnFPlXeCwmKwaympo7izGX3+ZnG+Z+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QTlqkDrR386OTIQSyronbV5SigiCTNsZ6FGukga/31I=;
 b=R2+4XhIlQ+PDG9cLUoeHBaol3tS87RuqqswxGf1eTfHXfPdtB4/fsK1hdgRf4YAZPxIMWpAyZ8tQMDEdgeyZOJDr8tAbCe7+TAMX9+vESdqRjuKZcEzetFRi49NLzFS2K0KEbA+PvHsY/ydAgO02/VDrWFcpJAhXAo9q41DH1SH63cexBHbEAAxaFLphzkfIyX/ks6MWn+L0sutoeEBJXCvFTVnreh2b3OA/frDw+LVSLPf6QVmBw3Udg8LXmDrUl5OlnLLKPH4iTvq8xSD9SYLFuwBWHaGygk404/wuW5QFEbx82kd0NaeGz8uTMDT+rjad8/g+xljY4Z3FZK2L+w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2a8a490b-fd5c-5fe5-64ec-975c9c4784d0@suse.com>
Date: Mon, 31 Oct 2022 10:26:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Content-Language: en-US
To: George Dunlap <dunlapg@umich.edu>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
 Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Henry Wang
 <Henry.Wang@arm.com>, Anthony Perard <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 George Dunlap <george.dunlap@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
 <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com>
 <CAFLBxZbWkLSMxXAYRGYc9Z3Vvj6bT+m7nvdiZgWRdr+_nF0BfQ@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAFLBxZbWkLSMxXAYRGYc9Z3Vvj6bT+m7nvdiZgWRdr+_nF0BfQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0136.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:96::10) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8706:EE_
X-MS-Office365-Filtering-Correlation-Id: 88661de5-1d4b-402f-35bb-08dabb220769
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DzRLm4RYn8XGtrdkJ4p7b3+UFX0zPeSutdLqUXXLFt381VGe+gLqZSRgiENJIpl1+4pDTXmjNGiKrly15LGpygW+k+CbuUiuH9QuLD3UJqcezEaAm1MZH6SuJBF46TTY6ldMJXOUj/og5ndiwA76Li5QwRDWd6x+nbzDzKVtpwpcHP0D6tW/JuBa/wjnp2PtDR+Jeyr21kgCETDmnqIk63zbn/Bof0+yepXSJNJsjBcGEKH6pGg3ll3pGkBp1imHMLKlwL/bQgc7VsPELtvh7hJMaO8uBFU/YUqoDf4bppVSkxNZ73Aqtg67rJKu4HThYwfTRWQTCG+nlJbS/iWewyFFEADN/X0oGRaeLGv1hF6Wqn0OlrkDPYRpx3aOQcik0LEtam7Ab6lFcO+IQ+vb0/RFtwnIWVMNKUNvolLBOusIafIgXSlDnLD9A8aPHDLbkHi5AAynPjJ1amWVuC2cMkVPAjMAnAAC0GdBT0vLBNjfLrH2KV1RuNh27nRuB4jEfugDoug0epFpIFSXziGN9jUQTIeuWPDpPvhLwNnkMcfdH0nmpGbE5DNhmXpc7uDOZNKhn8xlHBjGjizy2xBoh5kIEKJd10LV77SMDYnab/oWI2GQE7Wtf7peOXwWHR40uaaon9Up1TF9eD7jbriFSnGp9i+PR1FxCeqXCa/yaRJf9i1QuiL7mB/Ei9zvIKldiuvFl+UfgDldiZC7gCZZjUCeIBbfyLQJgRHMSfpyId9B9iY5SiSBB/WyRpIaL7s0DfA+CUkJCtoSDwb0J3rw1UtnWsGQbIkVelYP1w2XVpk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(366004)(396003)(39860400002)(451199015)(8936002)(5660300002)(7416002)(2616005)(6506007)(31696002)(53546011)(2906002)(478600001)(6512007)(83380400001)(86362001)(26005)(36756003)(6486002)(186003)(38100700002)(4326008)(8676002)(66946007)(66556008)(66476007)(54906003)(31686004)(316002)(41300700001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YUxqNEJpNHFITk05b3FmYnVwYXFGTlcxRFAxbytUWHZVU2I0bHk5czlsNE9O?=
 =?utf-8?B?UEhKdUlpd0J5cUUrQ0JZaFNSUzl4eWtLOFl6RGxZTXAyR1VhOXMxOU90TXlm?=
 =?utf-8?B?UlRmUVFjeGdDN0J4RnpoNHZCUHpSbytjT0c4Mml6LzJyNTZkRUhiZkZzTGQw?=
 =?utf-8?B?WlpxdUZBbXNMZnc1b0MxK0FrbHZlZElUalVBcXVWWnI2N2RCSDkwTmlXSEJj?=
 =?utf-8?B?aElRRmx6aGZBMlE5VS93Ym5KOUQyNGVOQVpmdytIVU9lZ1lOSFlpMDBvZE1l?=
 =?utf-8?B?VU0vZTNVcXpWTkREWFY0OExoa3ducjZoSHJRZTVFTUlTYkhJeEdMc2FlSnVF?=
 =?utf-8?B?dTFKMTlXRTNvQ0NBNk1XT1VrVHozRTh0Mndrb1BkSDJUa0lTS2NwWnczc1ZK?=
 =?utf-8?B?WnJPZTd5bUlVS3RhR2w1UWNqYjl5enBRdWxjdnkycVkvN2xsSUhtUis3bUJ6?=
 =?utf-8?B?NnJLZEQrb3ErS25Iekw3TUQwRmIwYzV2VTFXY1RWV1VwU3N5eHhmcnloSzNG?=
 =?utf-8?B?NFBRS2dKZzVYM0pIYzF1Q3lXRmhWdmxtMUZWektrYnRlRWRBd01md0J4elZs?=
 =?utf-8?B?RGtTOUxmWlJTWVAra3FVdDAwVU9rRTh6SGhkTUJ2R1RvZmwvZmw5WlAzMlVi?=
 =?utf-8?B?RTB0QXpNME1iKzNpdkpmdVdrNGkyOW5OVFhocWhTVVhLSjJ3S3VCdHZnd2Rw?=
 =?utf-8?B?Rzl2SmYwWDZ2VFJHWG9CdHMvd3lxMUtWK0NPZmRpMjZTNm5VREZFTVZQTlBs?=
 =?utf-8?B?d2NOUTg4N2xPNlZYTlpMUWtxS1Yxc3Z3empua25qUHNnSGx4RlBSZ29FSThL?=
 =?utf-8?B?WVFEMWlybkJRaW9uYi9aR2tXZE1jSFRvUmc4QzV1dFB5RlFZdm1UcStJSWg4?=
 =?utf-8?B?ZVdFV1NDVDR6UFpPNnNVeTBsQzcza3VVNGtwQjFpZ1RkUkJaQTNQYThRWFBx?=
 =?utf-8?B?SzF3czNtSkJpVCswYzZET2xHYk5FMG9iaUFVTm5MS0VFc2pHU3NUL0Z1TWlr?=
 =?utf-8?B?VlVxOVE5Z0d5QWZDb2xNVk1tVHIrMmIrSm44RTBiSTZmRkdXS0ZHK2R3SkxL?=
 =?utf-8?B?dFRFZjYwMmN6UG9UbGszcE1ISFJ5RXpqNm53SVF0WW00SS85cUJuYkFnY3E5?=
 =?utf-8?B?ZlNscEt5Tml6UEVGNUd6b251VWhLcy9na29tODlVNWdhVlhLL1J2anZWZEdV?=
 =?utf-8?B?TFBGK0I1d0ZxM3dKbEErbW9vcnd2c3lHZ29RVU1FSzNMYWlpSEE4U055VWJs?=
 =?utf-8?B?NnZCa09yRHZrS291cnluWmRBMGJ6OGdmRFNXTGFmVk9FZnNVNWFmajZ0N2FT?=
 =?utf-8?B?YlNSQWtMSENqN0Y4L0NaSS9KSzYrT1ZqOHFxc1I3QytDOGNJUnZ3UHA1akor?=
 =?utf-8?B?R3BNS1dnbEsxOFloelRBZXo2RVRGdlIrM2JHY1M2SHhZaGJZZmxPeGVQZWJC?=
 =?utf-8?B?MWRPd3o4UG52Z25FMWJjK2l6RUs5SFpPanpweHhtNGhRckxwOGI1UTR5bTIx?=
 =?utf-8?B?b3JsQUlIaHF6dlBDZTdCZTlueDlnd2dBU3dMTkh1QWl1OVRGS0FqZFovY3h3?=
 =?utf-8?B?anhMOG5kaHRQbUxPRndSK2lNczdIZTNORXBlTXltck5adXR2ZERxaG93MGVF?=
 =?utf-8?B?M1FiQTZxSGh0NGRiMXh4Q2JqVmc5TXpHTG1oRGg0MTJJMDlEbEE3aTRvK2I2?=
 =?utf-8?B?alEwcHB4M1lTdStyTUV6dk03ZVBudUNYYzI1eExGcGV4azkzTDBmaXNWWUhu?=
 =?utf-8?B?UlF5UmtvajlwSHA5QkhEMHd0NFdzQjdNV0VjZWRsR2h4c3NzYms1d1hEaUh4?=
 =?utf-8?B?YjFlRnV3Y3hieWRCbTIydXpxVnlSVkVWemZNMWQ0S0p5UXY4SzZjZGRCMTBJ?=
 =?utf-8?B?UUdGR0psRGxPWG5rdjE0VHlyZXJ6L01tczJoR1dyR0MzTjBUbTAzS0kyOHg2?=
 =?utf-8?B?TjFjTzZUaUVoYk5MeTV3UDU2SU5Cc0NvdXdkb01Tb0hkNjhpUWhtUEh1YTNU?=
 =?utf-8?B?VTlWL3ljTHhSakpKR1hLVGlRdExUZGllVVhxRlpFNVMrYkRlRVZ6N21SSnFL?=
 =?utf-8?B?QVArZUQ3OXUzTTkwR05lVHhoVGs5KytTL2p4VXZURk9kaHNXT3BkZ0t1ajQ0?=
 =?utf-8?Q?UbHllvtcpNTbtPQVIUS7XwBJ3?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88661de5-1d4b-402f-35bb-08dabb220769
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 09:26:45.5214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SPsK6qbKiwr8u5F+9EOomYr9xLDHmpoFWCWKGFaiOdUzITyoSCK4VNo5a7KmAIMqAmqIhCPK1hNmm40FF7g/eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8706

On 28.10.2022 17:27, George Dunlap wrote:
> On Thu, Oct 27, 2022 at 8:12 AM Jan Beulich <jbeulich@suse.com> wrote:
> 
>> On 26.10.2022 21:22, Andrew Cooper wrote:
>>> On 26/10/2022 14:42, Jan Beulich wrote:
>>
> 
> 
>>> paging isn't a great name.  While it's what we call the infrastructure
>>> in x86, it has nothing to do with paging things out to disk (the thing
>>> everyone associates the name with), nor the xenpaging infrastructure
>>> (Xen's version of what OS paging supposedly means).
>>
>> Okay, "paging" can be somewhat misleading. But "p2m" also doesn't fit
>> the use(s) on x86. Yet we'd like to use a name clearly better than the
>> previous (and yet more wrong/misleading) "shadow". I have to admit that
>> I can't think of any other sensible name, and among the ones discussed
>> I still think "paging" is the one coming closest despite the
>> generally different meaning of the word elsewhere.
>>
> 
> Inside the world of operating systems / hypervisors, "paging" has always
> meant "things related to a pagetable"; this includes "paging out to disk".
> In fact, the latter already has a perfectly good name -- "swap" (e.g., swap
> file, swappiness, hypervisor swap).
> 
> Grep for "paging" inside of Xen.  We have the paging lock, paging modes,
> nested paging, and so on.  There's absolutely no reason to start thinking
> of "paging" as exclusively meaning "hypervisor swap".

Just to clarify: You actually support my thinking that "paging" is an okay
term to use here? I ask because, perhaps merely because of not being a
native speaker, to me content and wording suggest different things: The
former appears to support my response to Andrew, while the latter reads to
me as if you were objecting.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 09:31:47 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 09:31:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432733.685391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opR8z-0004X1-Pt; Mon, 31 Oct 2022 09:31:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432733.685391; Mon, 31 Oct 2022 09:31:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opR8z-0004Wu-Me; Mon, 31 Oct 2022 09:31:45 +0000
Received: by outflank-mailman (input) for mailman id 432733;
 Mon, 31 Oct 2022 09:31:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opR8y-0004Wk-Ld; Mon, 31 Oct 2022 09:31:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opR8y-0006LO-Fw; Mon, 31 Oct 2022 09:31:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opR8y-0004Gt-0s; Mon, 31 Oct 2022 09:31:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opR8y-0006Z7-0T; Mon, 31 Oct 2022 09:31:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NNu4dVQhKG0x4GYllwzA9V2IHGI78KKpSFqyYF51ty4=; b=0EEf/LLI6Mnp4NxobpnNjBQvxX
	nXmMsNE55M4KfRR7iCSioT7p3+qRGh1rl9x6W40JB0mZFh+XCHO5H3p7iW3Kqs/LQKpQL4LoJgAve
	o9sJfPVFYIinJrinXXDXaiNRJqlAXkkqFzqm8nchnqqCY0JWJweGyJQAb0H266sj97YE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174547-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 174547: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-pair:debian-fixup/dst_host:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
X-Osstest-Versions-That:
    xen=1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 09:31:44 +0000

flight 174547 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174547/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-amd64  7 xen-install    fail pass in 174542
 test-amd64-i386-xl-qemuu-debianhvm-amd64  7 xen-install    fail pass in 174542
 test-amd64-amd64-pair        21 debian-fixup/dst_host      fail pass in 174542

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174542
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174542
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174542
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174542
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174542
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174542
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174542
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174542
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174542
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174542
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174542
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174542
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1
baseline version:
 xen                  1d7fbc535d1d37bdc2cc53ede360b0f6651f7de1

Last test of basis   174547  2022-10-31 01:53:28 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        fail    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 10:13:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 10:13:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432756.685402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opRmy-00015J-3Z; Mon, 31 Oct 2022 10:13:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432756.685402; Mon, 31 Oct 2022 10:13:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opRmx-00015C-W4; Mon, 31 Oct 2022 10:13:03 +0000
Received: by outflank-mailman (input) for mailman id 432756;
 Mon, 31 Oct 2022 10:13:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4oKL=3A=citrix.com=prvs=29677aabb=George.Dunlap@srs-se1.protection.inumbo.net>)
 id 1opRmw-000156-HE
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 10:13:02 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 91b7786f-5904-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 11:12:53 +0100 (CET)
Received: from mail-sn1anam02lp2043.outbound.protection.outlook.com (HELO
 NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.43])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 31 Oct 2022 06:12:46 -0400
Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16)
 by DM4PR03MB6013.namprd03.prod.outlook.com (2603:10b6:5:388::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 10:12:42 +0000
Received: from PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::5d4b:6b1d:efc2:20e5]) by PH0PR03MB5669.namprd03.prod.outlook.com
 ([fe80::5d4b:6b1d:efc2:20e5%8]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022
 10:12:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91b7786f-5904-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1667211173;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:mime-version;
  bh=S0j3BqmU/4jk1hsrwzp4nxYdIsOmYvxL2UxY4PVWkCU=;
  b=Mi+5pYrOgSFYQIab3uvuys0o2Eo2sm4aRIg2yu+QEGXFdXn/VQM8CSBr
   etWyqi4bHRNv7zzwpA4GzG/u4O+kr/AH4c2WmRySBT7XVT2tHi76tByC7
   6TXcM3zQPUPxnhEqD2XpvPLl+as9MM8Eo+oPL8VpAiSMNxL6UiCEECnt5
   8=;
X-IronPort-RemoteIP: 104.47.57.43
X-IronPort-MID: 84253942
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:1YKd2aJTWhzjoWNgFE+Rz5UlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl
 zVBCC3DeKqUMyGmS21FGI+//E4H65fcmIQ2TQI6pCthEihDpMDPDt7Dfh6tMXmbcpzOHBhu4
 swQOtCQIJlvHnOD+x2hPufop3UsiPDRG7eU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk
 d6u+sfWZlH/gW4qaWlKsane9E9h5fiu4WpDsA00bqwQ7QPSz3UbMskSdPq7R5fariu4PcbhH
 rqek+vplo/9101wYj9wuu+jKiXmepaLYU7VzCITA/L56vR7jnRa+r4hM/YBYltghTyMntRgo
 P1ArpX1QgoyVkH2sL11vyJwTmcvYMWqxJedeSLl6JTIlhWfG5fR664G4H8ebNVwFtlfWQmix
 dRAQBgRYxaKgf6Bwb7TYoGAUex6caEHlKtG0p1R5Wmx4cQOGPgvcI2TjTNs5x8ih9gmIBrrT
 5FxhQyDzvj3S0Yn1l8/UPrSlQoz75X1W2UwRFm9/cLb74VPpeDYPXeE3Nf9I7S3qctpckmwq
 1rCx1u6XhYmBJ/By2GHqnKDrf/zgnauMG4SPOXQGv9CpnS2njZWMztPEFyxrL++l1K0XM9ZJ
 woM4C0yoKMu9UutCN7gQxm/p33CtRkZMzZSO7RitEfRleyJvEDFXQDoTRYYADAinOA7QiYl2
 xmlgtXtDCRHu7yJU3ONsLyTqFtePABFcTVfPn5YF2Pp5fHHmsYdpAz9a+9JFb+FiPPVKBHdm
 WqV+X1Wa7I7yJRjO7+A1VLNji+op5PJZhUo/QiRVWWghit1eYihbpSnwUXe7P1AaouVUzGpo
 3wsi8WYqucUAvmljzeRSe8AGLWo4fetMzDGh1NrWZ47+FyF+WOnfI1WyCFzIgFuKMlsUQHuZ
 EjfqAZA/qh5NXGhbbJ0S4+pAsFsxq/lffzvW+rIdNNIbt50fRWe4SB1TUeK2ibml01EuYEyP
 42KN/mlC3kyAL5iijGxQo81wbItgywz227XbZT61Ai8l6qTYmaPTrUIO0fIafo2hJ5ouy3Q+
 tdbctCMkhxZWeimOC3Pq9ZPdhYNMGQxAo3wp4pPbOmfLwF6GWYnTfjM3bcmfI8jlKNQ/gvVw
 kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G
IronPort-HdrOrdr: A9a23:qEbYD6Dx3ixtpzrlHegasceALOsnbusQ8zAXPh9KJCC9I/bzqy
 nxpp8mPEfP+U0ssHFJo6HiBEDyewKnyXcV2/haAV7GZmXbUQSTXeZfBOfZogEIXheOjtK1tp
 0QPpSWaueAa2SS5PySiGbXLz9j+qj/zEnCv5a9854Zd3APV0gW1XYdNu/0KC1LbTgDIaB8OI
 uX58JBqTblU28QdN6HCn4MWPWGj8HXlbr9CCR2SCIP2U2rt3eF+bT6Gx+X0lM1SDVU24ov9m
 DDjkjQ+rijifem0RXRvlWjoai+2eGRi+erNvb8yfT9GQ+cyDpAo74RHoFqiQpF4N1HLmxa1O
 Uk7S1QePiboEmhA11d6SGdpzUIlgxep0MKgGXo/0fLsIj3Qik3BNFGgp8cehzF61A4tNU5y6
 5T2XmF3qAnRC8pDEzGlqf1vjxR5z2JSEAZ4Jgupm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO
 V1FsnT6PtfbFvfNhnizyJS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e
 XZNaZjkq1IU6YtHOpALfZERdHyBn3GQBrKPm7XKVP7FLsfM3aIsJLz6KVd3pDfRHXJ9upGpH
 3saiIqiYdpQTOeNSSn5uw6zjndBGOgQD/q1sZSo5Bkp7yUfsuYDRG+
X-IronPort-AV: E=Sophos;i="5.95,227,1661832000"; 
   d="asc'?scan'208,217";a="84253942"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L9shBT4vw+boZRoynt2EiVTvZH8/2VLScwq4nFCLxJoPeCCBhFx3h3yvn8RwCpbbcsRPHQm/oCeeOwuGid1AQ2pPO/UE0Op1khUPmpRdPNhnaQA5yczjjGxRYFn6HXE6pImeZs072GMhlLzYtJ1tTconoEv7Cg2G2yYqjxWRlMYHVKltPbOx3a6ggA/K01RmdEtq5Ecs0nXzIUGNtmGI2xphZam7iKA71OsIWVeVUb+0rm3eQv1bh7P0HWSAHNwwlwwqPYp5FqA0CxhQcttUkSwLXVjRwPm4Xt9w5yG4prUrOV1C6Ul/0iYTLIYJPFOmT6nAHHhK0FPqE44EVUltjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TcpFzGI6IoPOSIWS2McIqLJ1KnYVv3CkFohp+Id07gg=;
 b=HvUwelAbUNNb5Jyo7nXnAumjCe/x11kORkM4F4AdmPNSr3ZGpl5dJ2k5zta6yBiDInJIk8ObbQ3BpyiTUwLpyB+anPVwqrrfjEtLz8M84AMNXxjUgbx/M4P+ObmR6XgWQhA+vb4Y/4b7EpfHgyCif4gdTY2Guu64tJY8LnIJJph9rYq2k+Kgnc76yVy/oAUQUoYBoMqwT0NeFgn6j7YZ5mhAONBh/kO2NS1Odfu+wDbzXC28DuPNkT/SphYjpSdz9VoLTFul1gZArjDitQYZhRUkdvahHRLVuBEqxkSgeHnb11QhviIIsbJ6WTi8JhSEa/5Ru5Nk1YZYzZRB9p8o1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TcpFzGI6IoPOSIWS2McIqLJ1KnYVv3CkFohp+Id07gg=;
 b=HkuROOctUEv4DH1wyNVRt/lRWNH+bkgz0JymKK/zhPPX1pPe0rMiIacHv6eBTsuUvCPwxI9OjNryeSZRegENL0hr2Dxoc2Av4Ll3ygXKKG3Mn/m3FnfK5B78bQECjxl31Enp715vEZGMFsxLyFd4e0QMP6qFJUrd+HVSMv31Bu8=
From: George Dunlap <George.Dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: George Dunlap <dunlapg@umich.edu>, Andrew Cooper
	<Andrew.Cooper3@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand
 Marquis <bertrand.marquis@arm.com>, Henry Wang <Henry.Wang@arm.com>, Anthony
 Perard <anthony.perard@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m pool
 size
Thread-Topic: [PATCH 1/4] xen: Introduce non-broken hypercalls for the p2m
 pool size
Thread-Index: AQHY6SSZSdHfQqx5wkKQBwuC6qEQ/a4j8VgNgARSJYCAAAzQAA==
Date: Mon, 31 Oct 2022 10:12:41 +0000
Message-ID: <5EC7E359-3583-4846-8AF8-B84197B83BEF@citrix.com>
References: <20221026102018.4144-1-andrew.cooper3@citrix.com>
 <20221026102018.4144-2-andrew.cooper3@citrix.com>
 <ffb8bdb8-f54b-2107-ce1a-775337c172ac@suse.com>
 <0f048bd2-d08c-8bd5-2a20-7e49e794c679@citrix.com>
 <8a8bc184-6237-ed24-8d9f-daa3c36df915@suse.com>
 <CAFLBxZbWkLSMxXAYRGYc9Z3Vvj6bT+m7nvdiZgWRdr+_nF0BfQ@mail.gmail.com>
 <2a8a490b-fd5c-5fe5-64ec-975c9c4784d0@suse.com>
In-Reply-To: <2a8a490b-fd5c-5fe5-64ec-975c9c4784d0@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.100.31)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR03MB5669:EE_|DM4PR03MB6013:EE_
x-ms-office365-filtering-correlation-id: 2e24d21c-d0f0-4643-4fdf-08dabb287257
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 oynRil2ElZER//ZxQILodec0WJ3KJdLj+ul2z7DoxdtVqsXJf9hWqyLLXyWRgLGn2At3uIIpFzv+2FGinwazi5sDTRJjPSnhKJ5g76D7WU7x+40+OKU9s17HEfopqD6/ZznVmFqwZ/0W/+QV4hX4bLs57+6ZBCBNp2tPyfIDYdiz5ajwfFD7xMYOcdSWfIe3FVyGKNP3EY/A1MIEixsM0bLrOHsREJplcnOkQEn7Yk0v6+tuFAUfa87D9+foPzgjOYhVpDXgVCDagDRBQQpNYFYwQnjPBYeY5EkPI4UWBFtnY2hGIplD+d+jxg8OzkDbz/dsie56BC6zt6YpSNjFP1TN5nJqH09lLNCP+1nCtfBgMjRDGpye0yQjMrmY9HV78sjr4YkM133M6aUSNzcDFoB3q7PQWpVuRdmqba4o8OwUcf0b7eJjyZ7GIKnfNLhEv1qNmZ4f7WZ0xxGR3h8jwduj1P6jWcAhdep0ZX8Ql0R60ez0S6uEroJyew+PkvHOxPibKvRbPeb3F3wabe7XB99C05013sL5uAErYiAYkHvw4pXPp+gX8XyXaeZuNeaKlUpt9T56k+FLUHuVtoPIKe8CFxQ53HtfDWnGTspdKFH8S4e2OqlQFumi2ir24fT7SDTIVEQCMi56OqlEptF4bjFbxNBcqsFQlP5SpDuwMmAhKZVXI/twhJIn1L8MDlsBna/fgvd5Sccdhh34fBBbtQQiYv8T+Sw83DdB3HGPoewQwOPCrPKctxOW9Tz1moVypd78FO/HVXDykuQq9NFPjSujlL4tnMjxy6txXVJOUHtmi8PCnhj35OFeqNY3pMSe
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199015)(36756003)(38070700005)(86362001)(122000001)(82960400001)(99936003)(38100700002)(71200400001)(2906002)(6486002)(478600001)(76116006)(8936002)(91956017)(5660300002)(4326008)(64756008)(66446008)(66476007)(66946007)(8676002)(54906003)(6916009)(6506007)(66556008)(41300700001)(186003)(2616005)(316002)(26005)(53546011)(6512007)(83380400001)(33656002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MFFabTBLSjdzTzRtaFUrL2gvRmREZ1Jjc2c4TlVPTlhLRjJvKzNoZHlmbUtL?=
 =?utf-8?B?b285bTFrY0pTcThEWFlwWW9nZ2tHV0w1cnZUM2laaC9sdUFMaUpVN283NmJG?=
 =?utf-8?B?N1FXY0I5ZkUwKzczY0FDdEFZZFNreXpPUGszdzJCSlU2STlQS1pRTUhZVTRm?=
 =?utf-8?B?RytQZ3VFbng2bXB1SGlidy9XRzJQM3grdi9XZ1Fta2lYN3l1THZiQ2dQSWVJ?=
 =?utf-8?B?VTUwZFJoR1NqekxnNkY4WlZTaVhGWm9mWG51UDMxYXpMS1ltMHppWEJpTHB2?=
 =?utf-8?B?cFcvMzJ4OTJpeW4wSllQQTlnTEtWLzQwUzk1K0hpeE5ieWFnY1lHejJIejlW?=
 =?utf-8?B?c1hVakphQk9RN2dVcUhjcHRXTjQzNUNwRlNQSXhBckhKWUhCVi92WFNmMXB1?=
 =?utf-8?B?VUxOM1Q5a0U3enRKVXc3aGNDL1NwWnBxbElNTG1xZmlpWVRTaUFWTVpQZjIr?=
 =?utf-8?B?eE13bUpoK3hCd0pKTXM2eHllMjdlZjcwYkhNanNEaG80WDc5R0l5bStCNWNx?=
 =?utf-8?B?QXRMQmhkTzJGVjdtbEtycDVXdEU4OWVyVHpUL05Qc1g3c2pRYThIN0FTSCtW?=
 =?utf-8?B?VDh6RE1DQ1JwalJydTcvNWR4Sis1TDM5aGlwMFhJUHRRSk0yZGRRRG5lQkpU?=
 =?utf-8?B?b1RiQjFKMmoxek13QWVtajhQWDEvb3EyWWh4MGtUZk5BVHdkYVRMSmVvM3Vx?=
 =?utf-8?B?b1h5T3FNNTVoUUNYdHVZRzNFR0JqekRYZzZsd3hHTVg1UktJZHdLZW1yTlRy?=
 =?utf-8?B?ZjBnM1pVTjJ4THFwSG9ITUgybzV1RE1rcVJVZzkzK3VrZnlNaFhlaHhZd3pZ?=
 =?utf-8?B?bm5ad2FURzl2azE5THNScTZnZnVNOVFkK2ZGNUhidVhHd0JnUzRKUlBBc1BF?=
 =?utf-8?B?cTFJMDR3dnFUVXA0NS9kODVKclJXNnh3eGVxRURIb2VnWERhWHprYlJ1anNM?=
 =?utf-8?B?akRzb3loWXA3NUxGS0JpZkR1c2h2WXdMT0M4R3FEZDl4MmhYNEIrSkxDZzgw?=
 =?utf-8?B?RlpEOGtmeG5XK1FOOXplVmFuQXRWRjZMNDIzWUdzazJieE5zYUdibmorM3JK?=
 =?utf-8?B?eE5LbC9OTWdnMHpMSHVaTjRQaXJPcDVVajNtYXRwS2d6NHVJTmNLV1l6NmRz?=
 =?utf-8?B?ZWxFN0xXdXdVOHJEcnNUeCtkY0tzWWpUeGlFbEhvMWdoSWNHTWJuaVZzRXVl?=
 =?utf-8?B?ZnFJb3hUeTgzeVBYTjB6WmFmOVZLWEJFQzVmNnFxQ2k2d3Q2SGZJek9BTS92?=
 =?utf-8?B?MThlWFIycm9JaTBtRzRLVzhvNnRidEFxUHBMZmpZMnRlaU0xRWtVbUZPcC93?=
 =?utf-8?B?YzVOVzRONlF4T1JyNDFyNHFhUFdmOExFUDg0R082VlduOGNWQ0ZEU2NmNHd6?=
 =?utf-8?B?V1hKNjNvV2lrV1htdjZLRFVBejRkSmhiVUFYRnZmOW9vQ2VxQlBjdmhaaGdX?=
 =?utf-8?B?SnZ0OUdRd1FzTUVyRVh6SGpIS1dQZEptRW5vemhhUmRrWFlvU1hOallQbFc5?=
 =?utf-8?B?aWh5em5adGpaS29ob3JkU2pZcW9qczlIQUdUU1lkZi9HL05TTUdNMDlBZTkz?=
 =?utf-8?B?OFVEcXNJYTc1MHZ6OUlGdnFtYVJBMzBNU3RGNjRoNjVLVE1CclpnRXkwemIy?=
 =?utf-8?B?MnR2Tkk1Zm1BTWNWcVpNd2NLNmx1YmV0YXBVdlpCaVZYeWZQYjY3bEtsUDZM?=
 =?utf-8?B?eis4d2J3MWdZaE96RDJsc0xoZ2NVM3d0OXlkbUU4NU9vai9CZFpjYlhET3Fo?=
 =?utf-8?B?bFZXOWgrenY3SkIwTEY3U3VUVHdJL1c0M1RxOEd5STZLYlZiM0ZsYnNoQkkv?=
 =?utf-8?B?bXlmTTM5TERvaFN6RlN5WGh0aGN6clBhZks3a2lYaFBRZDRUMEp1S09uOHZn?=
 =?utf-8?B?Q3NvNWFPVkdOSEZ5Q3NKMkxWeVdqL09Ha21HK0s5UTkrakZYOS9FZmU5blMw?=
 =?utf-8?B?cVpSN3NjNFV0ODE4SDRRb0oxRkhsVXZIK1Rqb1prTlM0UEtNblBjbktOQjUw?=
 =?utf-8?B?aWpQUHlaVzBtRFh4ci9jWjZLM1BvbnNpNERXTkNkTnpmUVQ1c3BoUVlIdGxX?=
 =?utf-8?B?cUhhREhoZmJUOFI5MXNWU0FVNldOTm1XZDdNOGZQQ1h4MkVxMER1Z3dJRVdy?=
 =?utf-8?B?VmlCcWUvN3dRZ0puRUhxYkJwN3VKNzBoQkVud0RNcTZKZjNMeUV0blNnMVRl?=
 =?utf-8?B?WXc9PQ==?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_8E4F71DA-140C-4FDA-BB4C-9FF5874D00C2";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e24d21c-d0f0-4643-4fdf-08dabb287257
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 10:12:41.7275
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mim+ZMYS/PL9G/6WsjpplVZghwV8VaMneF7X0+EPlsOG1men2gvHmB8L0ZsMHBPJFR9YBXD/KDPoKdMIzi5p8uTNgaChoAzKqvEyS1bGnZI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6013

--Apple-Mail=_8E4F71DA-140C-4FDA-BB4C-9FF5874D00C2
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_DCD67686-F85E-4921-A3CB-5ADB6AE77FCE"


--Apple-Mail=_DCD67686-F85E-4921-A3CB-5ADB6AE77FCE
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> On 31 Oct 2022, at 09:26, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 28.10.2022 17:27, George Dunlap wrote:
>> On Thu, Oct 27, 2022 at 8:12 AM Jan Beulich <jbeulich@suse.com> =
wrote:
>>=20
>>> On 26.10.2022 21:22, Andrew Cooper wrote:
>>>> On 26/10/2022 14:42, Jan Beulich wrote:
>>>=20
>>=20
>>=20
>>>> paging isn't a great name. While it's what we call the =
infrastructure
>>>> in x86, it has nothing to do with paging things out to disk (the =
thing
>>>> everyone associates the name with), nor the xenpaging =
infrastructure
>>>> (Xen's version of what OS paging supposedly means).
>>>=20
>>> Okay, "paging" can be somewhat misleading. But "p2m" also doesn't =
fit
>>> the use(s) on x86. Yet we'd like to use a name clearly better than =
the
>>> previous (and yet more wrong/misleading) "shadow". I have to admit =
that
>>> I can't think of any other sensible name, and among the ones =
discussed
>>> I still think "paging" is the one coming closest despite the
>>> generally different meaning of the word elsewhere.
>>>=20
>>=20
>> Inside the world of operating systems / hypervisors, "paging" has =
always
>> meant "things related to a pagetable"; this includes "paging out to =
disk".
>> In fact, the latter already has a perfectly good name -- "swap" =
(e.g., swap
>> file, swappiness, hypervisor swap).
>>=20
>> Grep for "paging" inside of Xen. We have the paging lock, paging =
modes,
>> nested paging, and so on. There's absolutely no reason to start =
thinking
>> of "paging" as exclusively meaning "hypervisor swap".
>=20
> Just to clarify: You actually support my thinking that "paging" is an =
okay
> term to use here? I ask because, perhaps merely because of not being a
> native speaker, to me content and wording suggest different things: =
The
> former appears to support my response to Andrew, while the latter =
reads to
> me as if you were objecting.

Sorry, the tone was =E2=80=9Cobjecting=E2=80=9D because it was directed =
mainly at Andrew=E2=80=99s arguments.  I thought about replying only to =
his mail, but it seemed like since I was clearly =E2=80=9Cjoining the =
discussion=E2=80=9D, it would make more sense to quote you too.  I could =
probably have made it more clear by leading with something like, =E2=80=9C=
I tend to agree with Jan here. =E2=80=A6=E2=80=9D

 -George


--Apple-Mail=_DCD67686-F85E-4921-A3CB-5ADB6AE77FCE
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br =
class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div =
class=3D"">On 31 Oct 2022, at 09:26, Jan Beulich &lt;<a =
href=3D"mailto:jbeulich@suse.com" class=3D"">jbeulich@suse.com</a>&gt; =
wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><span =
style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">On 28.10.2022 17:27, George Dunlap wrote:</span><br =
style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><blockquote type=3D"cite" =
style=3D"font-family: JetBrainsMonoRoman-Thin; font-size: 14px; =
font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; orphans: auto; text-align: start; text-indent: =
0px; text-transform: none; white-space: normal; widows: auto; =
word-spacing: 0px; -webkit-text-size-adjust: auto; =
-webkit-text-stroke-width: 0px; text-decoration: none;" class=3D"">On =
Thu, Oct 27, 2022 at 8:12 AM Jan Beulich &lt;<a =
href=3D"mailto:jbeulich@suse.com" class=3D"">jbeulich@suse.com</a>&gt; =
wrote:<br class=3D""><br class=3D""><blockquote type=3D"cite" =
class=3D"">On 26.10.2022 21:22, Andrew Cooper wrote:<br =
class=3D""><blockquote type=3D"cite" class=3D"">On 26/10/2022 14:42, Jan =
Beulich wrote:<br class=3D""></blockquote><br class=3D""></blockquote><br =
class=3D""><br class=3D""><blockquote type=3D"cite" class=3D""><blockquote=
 type=3D"cite" class=3D"">paging isn't a great name. While it's what we =
call the infrastructure<br class=3D"">in x86, it has nothing to do with =
paging things out to disk (the thing<br class=3D"">everyone associates =
the name with), nor the xenpaging infrastructure<br class=3D"">(Xen's =
version of what OS paging supposedly means).<br =
class=3D""></blockquote><br class=3D"">Okay, "paging" can be somewhat =
misleading. But "p2m" also doesn't fit<br class=3D"">the use(s) on x86. =
Yet we'd like to use a name clearly better than the<br class=3D"">previous=
 (and yet more wrong/misleading) "shadow". I have to admit that<br =
class=3D"">I can't think of any other sensible name, and among the ones =
discussed<br class=3D"">I still think "paging" is the one coming closest =
despite the<br class=3D"">generally different meaning of the word =
elsewhere.<br class=3D""><br class=3D""></blockquote><br class=3D"">Inside=
 the world of operating systems / hypervisors, "paging" has always<br =
class=3D"">meant "things related to a pagetable"; this includes "paging =
out to disk".<br class=3D"">In fact, the latter already has a perfectly =
good name -- "swap" (e.g., swap<br class=3D"">file, swappiness, =
hypervisor swap).<br class=3D""><br class=3D"">Grep for "paging" inside =
of Xen. We have the paging lock, paging modes,<br class=3D"">nested =
paging, and so on. There's absolutely no reason to start thinking<br =
class=3D"">of "paging" as exclusively meaning "hypervisor swap".<br =
class=3D""></blockquote><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">Just to clarify: You actually support my thinking that =
"paging" is an okay</span><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">term to use here? I ask because, perhaps merely because of =
not being a</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">native speaker, to me content and wording suggest different =
things: The</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
JetBrainsMonoRoman-Thin; font-size: 14px; font-style: normal; =
font-variant-caps: normal; font-weight: 400; letter-spacing: normal; =
text-align: start; text-indent: 0px; text-transform: none; white-space: =
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">former appears to support my response to Andrew, while the =
latter reads to</span><br style=3D"caret-color: rgb(0, 0, 0); =
font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, =
0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; font-style: =
normal; font-variant-caps: normal; font-weight: 400; letter-spacing: =
normal; text-align: start; text-indent: 0px; text-transform: none; =
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; =
text-decoration: none; float: none; display: inline !important;" =
class=3D"">me as if you were objecting.</span><br style=3D"caret-color: =
rgb(0, 0, 0); font-family: JetBrainsMonoRoman-Thin; font-size: 14px; =
font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none;" =
class=3D""></div></blockquote></div><br class=3D""><div class=3D"">Sorry, =
the tone was =E2=80=9Cobjecting=E2=80=9D because it was directed mainly =
at Andrew=E2=80=99s arguments. &nbsp;I thought about replying only to =
his mail, but it seemed like since I was clearly =E2=80=9Cjoining the =
discussion=E2=80=9D, it would make more sense to quote you too. &nbsp;I =
could probably have made it more clear by leading with something like, =
=E2=80=9CI tend to agree with Jan here. =E2=80=A6=E2=80=9D</div><div =
class=3D""><br class=3D""></div><div class=3D"">&nbsp;-George</div><div =
class=3D""><br class=3D""></div></body></html>=

--Apple-Mail=_DCD67686-F85E-4921-A3CB-5ADB6AE77FCE--

--Apple-Mail=_8E4F71DA-140C-4FDA-BB4C-9FF5874D00C2
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmNfn5IACgkQshXHp8eE
G+0m8wgAtCqz/dGH+gdoUj1MtJMd18DQSAxMMH+RDvkM3F/Ukr8uPCtwVVyijL65
lu8IhZtgHlJ07BgugpCQu3hLdOxpINkCjQlPx5rkn1UdFT+k1fVO8toIe6BeX1vO
OHGCooS6nyzc2XEhUx5HRcGz5Hi71WDHLmCZX9fFLfOFsreDQkPwwA72nZzEj8Es
rWMfWmc78LBls0DFxYtJRDgt38iOCp71kopJ/3xGyDINjUyKkRBJQbv0vIVxnxCV
hBZQGGJVrladRYC2BJ0yZR+vr7ouSlq//6Pc7InR1wRzsvbk91rudF012rWF1/tS
Q5vjDVUFzrAT47fbuLOvymhiqkdagQ==
=UEz4
-----END PGP SIGNATURE-----

--Apple-Mail=_8E4F71DA-140C-4FDA-BB4C-9FF5874D00C2--


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 12:14:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 12:14:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432777.685413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opTg5-00065N-7D; Mon, 31 Oct 2022 12:14:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432777.685413; Mon, 31 Oct 2022 12:14:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opTg5-00065G-3o; Mon, 31 Oct 2022 12:14:05 +0000
Received: by outflank-mailman (input) for mailman id 432777;
 Mon, 31 Oct 2022 12:14:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opTg4-000656-13; Mon, 31 Oct 2022 12:14:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opTg3-0000bz-Ue; Mon, 31 Oct 2022 12:14:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opTg3-0001Q6-Ha; Mon, 31 Oct 2022 12:14:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opTg3-0002nR-H5; Mon, 31 Oct 2022 12:14:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UX92Ohtyu8WY7k7BYVLRn13MA14GyYDX6YBTq6MbZkY=; b=uNr/j6nUVHtc55Oa/8u1GQ2zSf
	ME7Xj0UIsAP3BlIKDf2NgcS8mLsEyX4oVvT0FWPJ28Iz/4kGT9PxYjt5BV6S/i0ezPA+kaaivHE6r
	2ZC1JQhfGyw62htX02XNrMXwECdu06E2UvQUbA+5qZbIBn7eh/196jhvdPl3mHgoA8jc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174549-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 174549: tolerable all pass - PUSHED
X-Osstest-Failures:
    libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    libvirt=72d4709ab901dd3699d342f15ca3aff9bffddf96
X-Osstest-Versions-That:
    libvirt=de842f37a1d7626c6e2d334f7966d17a75c5a81f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 12:14:03 +0000

flight 174549 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174549/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174527
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174527
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174527
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check    fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 libvirt              72d4709ab901dd3699d342f15ca3aff9bffddf96
baseline version:
 libvirt              de842f37a1d7626c6e2d334f7966d17a75c5a81f

Last test of basis   174527  2022-10-28 04:18:46 Z    3 days
Testing same since   174549  2022-10-31 04:18:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cole Robinson <crobinso@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-libvirt                                     pass    
 test-arm64-arm64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-arm64-arm64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-libvirt-vhd                                 pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/libvirt.git
   de842f37a1..72d4709ab9  72d4709ab901dd3699d342f15ca3aff9bffddf96 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 12:14:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 12:14:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432780.685424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opTgO-0006RH-Fn; Mon, 31 Oct 2022 12:14:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432780.685424; Mon, 31 Oct 2022 12:14:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opTgO-0006R8-CL; Mon, 31 Oct 2022 12:14:24 +0000
Received: by outflank-mailman (input) for mailman id 432780;
 Mon, 31 Oct 2022 12:14:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CXQ+=3A=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1opTgM-0006QI-T9
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:14:22 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-eopbgr60081.outbound.protection.outlook.com [40.107.6.81])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8cd944d7-5915-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 13:14:21 +0100 (CET)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by PA4PR04MB9440.eurprd04.prod.outlook.com (2603:10a6:102:2ac::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Mon, 31 Oct
 2022 12:14:18 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022
 12:14:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cd944d7-5915-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NXsne1y/wTX4el87L4tQV13mODKsdNopkjhma3k0n3klHLYEn+QnBlu3DTx7IRb+EflCscfWX6jlCq4pIGHJ26hUk7/EwmiJZ3uBQPZsoNf5YQ1BTHcz2JGRbleo4j4E50Q7ijbZ1uNDx/8NxgDHpXvmN7VoVY3IE1xubKFcwhGpuR3Ve0JfWqJEhN6vZ3my8+uOh8vw2hmqPngElNB04eJ6nnIUd+fHZQcVw9Zjml4pWKv73atvF2kW5tiySMzcJb/lpKVYfzP4d4Z/gK+zrCXrYB3HQ1v/w6iTY9ssYRGUdjAt/32wGF08ixavnP8jWTKV5hUtfZcexm53cO0PYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yC+z+b60CPfkAzm4S3wKlgxdb+EjYvwbbICGuJTmy3E=;
 b=iHkOnuqyQHnkV0GoxA3lDeZf2vOxSHPAZCE2WmZPo5rs93HeBaFVuYU3snY9QkVi84JTu/sf5dXJAyaNXAGF/zoCArVxce/YD23BgUB0/2qTgrqBlWdHAq1IAfTPBa3jyaJsSXf6ysdiZ1WZglEROGQRfdX5sOfB5ZILBRP9GbKg0wbL5HsSVkclV8qoOT9euRRpINS2pTJAxWp06TayiLA2SWojq/40QjC18eyqwK+/1h6jNWhWBp2SmFwG+06BdgbU2b7LEXbfIlfmdohgOlW6Si7+KaR0Y4Faeap9V8gu0pWFnn35oQotWRtd/pXUPWNRsxcLMM3jFuyH4R9zBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yC+z+b60CPfkAzm4S3wKlgxdb+EjYvwbbICGuJTmy3E=;
 b=WhZAlrUYvDUCjOoCXjFe4PKOPNx00Gn3JvsuL43xFub73XVafAYr8fxem9cOsp/b9SrxvtFDBFAMoxaJwrPJFPnUIK6HRvwzDwYVcIAinogLX9hdNkT4HD9V+ahFVgQjsZVLQ4PhbnWJrWwgbNFCh87s96uyEC3+ebLKu1g4k8SN7s5NguZsHNKW4dAT7qwdsKhlJ3UB6gmw6nWV9Yww4nQpR0z/OTo9ACUj0gp5TdWuwSNNqwmy/CyhVjPtQ2JCuJKQNbmQ8YMdivbk9PBH9g+NnE2Q7ZVrFp/z5LYM1eF8qteNnjVF95BFNkZMHOY2z9nWCCK66O4T1hzjYlIj+A==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d8412661-9c7a-60c5-3adb-029abc87c0af@suse.com>
Date: Mon, 31 Oct 2022 13:14:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH for-4.17 v2 1/5] vpci: don't assume that vpci per-device
 data exists unconditionally
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, xen-devel@lists.xenproject.org
References: <20221025144418.66800-1-roger.pau@citrix.com>
 <20221025144418.66800-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221025144418.66800-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0156.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:a2::17) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9440:EE_
X-MS-Office365-Filtering-Correlation-Id: e8af2448-a35c-4e13-9123-08dabb396f6b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gIdASHczguQbpC3vLWSsyVAs1ZZimyavk7Gxxg/as0b+nWZZgR39fHxPQWi6AXFIA96jPIDs8WZWKKwNgzc5NpkqEVZ7h/C6xbfnTua55rsgd5ARjj30m4Gr/LhTrkU4y+KmsT1gHzwU2oLXigx3L1KXmqPCjPkgUq3QG5ij95F6KQ0i0vsvV6eOzsw91cnLKEBe5/BuAMG8WOEKdISUlNbHYvLd425I6SgBljEkJ1Qqgh+14RaBAR1qfD+9K6XzDhSNLIz3NIs4/ZGDMaMa/rshbjHx8RrtI82oz4ehNajQxFhEygwnn7QYzErnhJhAzE0X/wIVnKGxASEk4sotCo4IvlzaNYHEUZxTNmxW9pwJxZrGXdupAFtjT2t28zxA1Dwht1WCjZWUSMY7AG2HSwJ4Fm8jVsePRi5hKiJgO+GHAMQDmznx9tPGG2MhEuCBJ4BzURAk7tRep6bop+Ho0mWb3FkyNNls7YXj1hH9RQ+9LdlmdWjTveBAAn0w/8WSXYASfhNs2qqH/zyFHKj0c1lfu13ZuhEyO4FI9Dxv66Y978RS43dHjI7psVDKtbWyiB6h9cuHoQ7mEqQvkxkm8+j9cIwLuX6J0s/JKL2gc7wdBFM6qaeuiX72InrEMGoFIItX5dbNz0F0S877WRHeCqzOILGF11DSVjsYEblq6LATdrpFX9hQjAagnEIS0q/wjJ+GjlSHF968Mu3lKPjzg7EILthWTm+uR2GSZhw3p+X2AFuWPylhYk+0PFSpi83pxVk4JNHfas4e15JolkQ4LB5HNqpkMHDrjkba0ZkUK4c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(346002)(39860400002)(396003)(451199015)(6916009)(31686004)(36756003)(38100700002)(2906002)(5660300002)(4744005)(31696002)(86362001)(186003)(316002)(41300700001)(6486002)(53546011)(2616005)(6512007)(66946007)(26005)(4326008)(8676002)(66556008)(66476007)(478600001)(6506007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VVd2Ujh2ekxkQlVsWjFMNHlUaTh0TXl1RHFQb0NQbUxER3JMNzB2dkVTb2Rk?=
 =?utf-8?B?RHN4RjJteWNiUEhnWW40OGZjWXV4U1h6cFlLZG9mUlg0VU1lVnJMT0NhM3FY?=
 =?utf-8?B?eERWS1NyNmlFZVFWVGhKcUpJbDBGb21pK2lhWGdGL1QwZnBkL0M2ejNDelB1?=
 =?utf-8?B?RHFPbjJmRE9oZm5wOEkwNW01NG5pM3g3OXFjZzk2OUxiYWptS3RvRDFHTjJr?=
 =?utf-8?B?WDB5QzFJeWNPdURKKy92TkErRVlCZS9uYkFPUDNkMVlBT1hwUEpwQ3pqRDQ5?=
 =?utf-8?B?VUVmV3o4bmIxTFlwV3hwZG1BT2R4c0tXWkc5MjlseG8rVmVoMExXd05FRkMx?=
 =?utf-8?B?dSsrbGplL0ZCQUNFbkxETU9nVzVSM2tQb01XdC9hOTE1RUVoaWNJUTAzSFlp?=
 =?utf-8?B?L2JyUVJsbW01anJmSnEwMGJJVURaZ2dCUjhWYjdmL2JFcTUyTXpYYmVOeSs1?=
 =?utf-8?B?a1o0eUs2aEF3VmNZOWhGUmpxUHc3YXk4UkRQeTU3T1hyRkNqbUh1bjZDVFJj?=
 =?utf-8?B?bld3cmNCWXFCQUxJRVdSektSN3NrSGxBYzBNQnhDclM2Ukx5LzBFMkNrczlx?=
 =?utf-8?B?Q0NRRkE1QVB3cnBwNTFKcUg5RXhVNnprN1JITTVLQm5LSnhjZ3Fhb29UQjZq?=
 =?utf-8?B?SUZDZ3BuRTNsNmJ1dVJqT3pIdlI0ODEvcTc1bWxNeVFOQXQwSlZOZ05jc3Jz?=
 =?utf-8?B?ZkN3S2VKR29RaGZPS04vRldjeWh3RjVINFYxV2U1Mk1EK3AzSzBaQVdRT2d4?=
 =?utf-8?B?RnFwbFh5dzVpa2ovd3oxNU83RUZVZWJqTWJoS1RxQmhCVkpSaTNtemxDRXh4?=
 =?utf-8?B?OFFwYU5xWFhvTFFlcVAxZ2FKZytpVDhJaHg5VUJlM1BPZElCdlJqWndaN2pJ?=
 =?utf-8?B?ZXUwTEgyL2wwaFZqS3FST0dYYW15SEJKVFZEQythSTdGMzBCNjJ5bUNPZHRo?=
 =?utf-8?B?Y3pHK1NuOHR6VnlzWSttTC9QN0dKamxRWVRJNHdKYUsvYXB4VjJ2UTNwZEVQ?=
 =?utf-8?B?bjI4Q0ZnNDJYVEd5ZmROdmdYTllUckFvcXJOdzZRbjludXZMMTR5VG9TK1NZ?=
 =?utf-8?B?dk52dFFFempjSWR1OVRubWhMVFEwUkRYdXh1ZWJvWFhoM0M0cmd1bEZPWjNl?=
 =?utf-8?B?R1BmVXh2ZFk0QlVjUGxBQVYwemQzSDNjNk41NjNYQTZ0a2lhQ01Ud1lQb21Y?=
 =?utf-8?B?dGJtQ0R5U1NKQ2VxNTAvTFVwQlQ4aDJvbC85RVpBSXBaZlpLRjJKeUpMVUlx?=
 =?utf-8?B?SFZNNzdmNTArT0Y4Nkh1QXRROFNIcm4xZGU1Tno3aVVBb21WaCtPL3lPTExD?=
 =?utf-8?B?ejA1VHpyNGRvZjJWZ3IxZTZIRForSGZib0JaY3J6YW4vcTlUSEtDdDNoOUxm?=
 =?utf-8?B?MWV6YStIM1NSalFwMU52QU9UNzlJbDc2UGEwNkEvYXd0L3BKb21ZWkEvM1BX?=
 =?utf-8?B?QysxUnN6ME4rVHpFdmVBOWsySjNWS05GRHl5aXdvT0NPL1haeVkvVGNncHk3?=
 =?utf-8?B?SHdUY0lNWU9sOVlqeForQnpyN09Ja1d3S2lOd0I1YmRvVmN0TDZSbjFYd092?=
 =?utf-8?B?OXNuUlJodHNhMFdVcGY1K0R3M3c0ZW1OVk1TMUFvazdDdHhXN0dtWDdZaEpD?=
 =?utf-8?B?MGd1TUlzY0paUlo5d3ZDclpvdy9JVVZ4bDJrK29xRmVOZ1R1Z2xBK0l0U1ZN?=
 =?utf-8?B?MVVEK3BnTThSbGhjZjhkZUNqT0x2cFBrOTdqRW5uNkdHUExpSHQ3OFRvRCts?=
 =?utf-8?B?SXR4Yk90ZnorQk9INTg5YkdjTVBTbkg0QVlJTmdEeVp1YnJWTHhGemN4aGxY?=
 =?utf-8?B?T0tNMy9PeHdzbEZWRDBHcGZWNUE2YUcxeTV2UDloaXA0U3pHaExsUGFKT1Bh?=
 =?utf-8?B?MzlNck5EcVVCNDNrWHJHbHhGTnRvSis3Zjg2VWZwRmxzcThkYnFRWmZQOTh1?=
 =?utf-8?B?MXJhdWx0bnV6YUpKQ2J3WGtxZldoMGplbTlQamNXdE5kV1pEeDFnWjBrL000?=
 =?utf-8?B?RFBQa0VFTlRHZUZQMlpnU1BPdzhpOGR3M3dQUlk4M3dkYW9pZU1aODI3Wk5K?=
 =?utf-8?B?WHBhaDVKZEgwZzZlOWp2YWhZVGhvSkJIMEE3SmMrTHZLZFBkMHdIajl1cnFq?=
 =?utf-8?Q?esIQLtfAqS1T8aKPdwpguHmy2?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8af2448-a35c-4e13-9123-08dabb396f6b
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 12:14:18.5071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EINKo7OALy2qbWUGQInnZMRglTIFHfuaLuPwwMvmesXcLwOjhpJIPmR0SAwkixo2GBuC/GlJUXAGLqC1hkIhGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9440

On 25.10.2022 16:44, Roger Pau Monne wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -37,7 +37,7 @@ extern vpci_register_init_t *const __end_vpci_array[];
>  
>  void vpci_remove_device(struct pci_dev *pdev)
>  {
> -    if ( !has_vpci(pdev->domain) )
> +    if ( !has_vpci(pdev->domain) || !pdev->vpci )
>          return;

Btw (noticing while backporting) - is the left side of the || still
needed then?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 13:27:22 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 13:27:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432866.685551 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opUom-0007xX-Hi; Mon, 31 Oct 2022 13:27:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432866.685551; Mon, 31 Oct 2022 13:27:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opUom-0007xQ-Ep; Mon, 31 Oct 2022 13:27:08 +0000
Received: by outflank-mailman (input) for mailman id 432866;
 Mon, 31 Oct 2022 13:27:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1opUok-0007xK-TG
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 13:27:07 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b4b95f23-591f-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 14:27:03 +0100 (CET)
Received: from DB6PR0301CA0061.eurprd03.prod.outlook.com (2603:10a6:4:54::29)
 by AS8PR08MB6149.eurprd08.prod.outlook.com (2603:10a6:20b:29d::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 13:26:58 +0000
Received: from DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:54:cafe::1f) by DB6PR0301CA0061.outlook.office365.com
 (2603:10a6:4:54::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Mon, 31 Oct 2022 13:26:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT064.mail.protection.outlook.com (100.127.143.3) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 13:26:58 +0000
Received: ("Tessian outbound 58faf9791229:v130");
 Mon, 31 Oct 2022 13:26:58 +0000
Received: from 6c2a35f5b6d2.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 6EC524F4-3CDF-45D1-893C-2CAEE5C63D6E.1; 
 Mon, 31 Oct 2022 13:26:47 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6c2a35f5b6d2.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 31 Oct 2022 13:26:47 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS4PR08MB7926.eurprd08.prod.outlook.com (2603:10a6:20b:575::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct
 2022 13:26:44 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.014; Mon, 31 Oct 2022
 13:26:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b4b95f23-591f-11ed-8fd0-01056ac49cbb
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=OEllxYGzZKXwMRCptB7TDF57eAh2SeEiTiMR82lEWJ92uAcLtZxDuWBOLyNzDCe4NYLCxfjpu9RBRi4hV9B6dtZ677bIrsokBgFfct+9THB6rq4id3Lnh75swMhxmGYwYzCM0pfTLQUZOs6i+saMJjm5Bl9gzgjA5/sOJxh1nmE50b4+nNgyvaSpGHSLXSC4M/wa/h9EfyudUNknZ4bZgBTiBNm5SQuYGxUBMDN1beV21jiza0mr2k6PHqYIvlQ7OEZTgb23Gu9LclGnw8TXyFhdiFeCCubZxTApalWIdnKo4Q+f8Co2t2Ydsnntv/2sNe+QWFYfvq1sq3PdB6DB2w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x0j4VWwaDaMbspt9Gdt93qfRGxWmQkVeaT1k2BNWivQ=;
 b=EGpJtjA4px86H0VbNlI08cXOHwM432lWo6ir+84WMBt5doD3qOiuUUx8YQvFiyqc1/vejWs+Wj6oATNWB1YVd0DO2oC3orA2eS3s8bEw7wX8VzFh4WUhybj5sXdVqJyj1pVe3CZUSE/1pMooh0mdSCctqHPMZuFYMNjCPZhYoHso6Vr2EVn0uUpcL4wwFgaJGobwzB3hgmHZuh4qoF6eG20+8gVsWIQdTg1niaBa2iAM2mag7Sqej0LhpCyrvul34L9xFpE2hpKhEIRdGegb9Guiu4yu260dDC73fr6bkl5qzdKj3+K//k2C7Y2T9z/CxCMYEu6hPGes4nFpIf9aig==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x0j4VWwaDaMbspt9Gdt93qfRGxWmQkVeaT1k2BNWivQ=;
 b=jpaoiUmqh2Qf6AsNIa5zxRtQ+eJkSiDvhbIgrBowieLqDn36AYqkPPct7P2OhMy9CXrbsNAuzBM3DpnLcSh2v5mbx5uI56Gw06tyfYGgZBRcvlzxGjcSmQI7TRK7fH7pD+ReQFPfe8IEV5ru4jzN4X67fTxo0seUNTG65OjfUYQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: df9bc3fa5664f596
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jgMw4fUbmR+USs/26EYUn/tmbPdhXtMadqOTtb+qMOsLeaX7iwvBdSpPTjrP4lmCUBI+R8xzmc7dZ0wI9+WhNgboupWEraFKC7dPNPt9mw6+08u1jQxhciJmBR9fMPYECplFZJMVHLQPAVFphLbbhgUMPCjln0oMWxriGYmHXllU1Kd/6Mt41noqh6sslkY7EQtr0Lqjsg5ZsdORE5TmXffqE/k+xAJ2ApxcgAB+AIqfaGNA71/3715z5uh5yL3CCdN7JWDYrCHLlqDlLTVHf2vk+77yi7Xf94gHSDK57R/4PmcwLhg2xHNWuBJj9LuhFnqU38ot90ERp2WjF55u1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x0j4VWwaDaMbspt9Gdt93qfRGxWmQkVeaT1k2BNWivQ=;
 b=SzVKIEP1nRCVL5+SJApVnmETtBtcgJXcZD7/AFmqDHtLUZOeMfJ0Mdv7hPEYOOdsnUfQswDCQDc0QZdi9VEkYAYOETsv4ylPGfpxCn81ryO76UCQYLAq0JiAtQbG+PCnJUZ0WYnd7YPDM4QdFsn93Zm+4MXASI223tv8dEC8YOHmu8s9LrUL8MDaAKHueJtRZBF7oS/yFePaw2o10J6sbrrsqTY9cBgHHbZDT8YXSLIE98UjshMK3KVpcoUWdAs5BL22RyKBTdAc/NUW3bXPjbeLDrqG8QHKlywD0eok27IyqTnG2+x2B8q8SEcj5kqN0D/R9XNZsgW55btXM9rG7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=x0j4VWwaDaMbspt9Gdt93qfRGxWmQkVeaT1k2BNWivQ=;
 b=jpaoiUmqh2Qf6AsNIa5zxRtQ+eJkSiDvhbIgrBowieLqDn36AYqkPPct7P2OhMy9CXrbsNAuzBM3DpnLcSh2v5mbx5uI56Gw06tyfYGgZBRcvlzxGjcSmQI7TRK7fH7pD+ReQFPfe8IEV5ru4jzN4X67fTxo0seUNTG65OjfUYQ=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>, Rahul Singh <Rahul.Singh@arm.com>, Xen
 developer discussion <xen-devel@lists.xenproject.org>, Michal Orzel
	<Michal.Orzel@arm.com>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
	Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Jan Beulich <jbeulich@suse.com>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: Re: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Topic: Proposal for virtual IOMMU binding b/w vIOMMU and passthrough
 devices
Thread-Index:
 AQHY6T1V+gcJbmRqpEyt0b8GeG9bFq4grXIAgAAQCACAAFf9AIABVMyAgAAG64CAAVVJgIAAAzuAgAACBwCAAAPNgIADNHqAgABdGACAABWOgIABD7SA
Date: Mon, 31 Oct 2022 13:26:44 +0000
Message-ID: <9F323893-B1C9-4D31-9A40-213345421860@arm.com>
References: <DD70007C-300F-44D3-B314-A5F8C4582CD3@arm.com>
 <75b7665f-66aa-2e11-35a0-edf20a9c0139@xen.org>
 <99E954B0-50F5-4D7B-A7D2-50D1B7B3657C@arm.com>
 <60b9cc07-c0ec-756b-802b-5fc96f253dbf@xen.org>
 <EDDD0430-0BFF-4C95-B9CE-402487C2E5DE@arm.com>
 <fde8c845-8d35-83cd-d4fd-bb2c5fd1a7ed@xen.org>
 <227AD28E-DFB8-4EB3-9E0E-61C70A0D19EB@arm.com>
 <f777b164-54c6-6091-79ce-fac3dd603b8c@xen.org>
 <34B31FA6-72D8-4F03-AC94-3DC795D0FF55@arm.com>
 <222ed837-594d-6301-edec-6f9d26e1fadf@xen.org>
 <alpine.DEB.2.22.394.2210301523450.3408@ubuntu-linux-20-04-desktop>
 <82c45bc1-6052-502b-3007-8a16fbd1d433@xen.org>
 <alpine.DEB.2.22.394.2210302148150.3408@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2210302148150.3408@ubuntu-linux-20-04-desktop>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|AS4PR08MB7926:EE_|DBAEUR03FT064:EE_|AS8PR08MB6149:EE_
X-MS-Office365-Filtering-Correlation-Id: 5a04b472-7af5-4eff-5ed9-08dabb439627
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9f+mGcAq72V0Kk8A/As+eXBgU4acJpMcGydRvchAyMXlJ6paM6nLMFYzuaJ/HK9yq6xKvGlivP9WGNOv6PHSRLzhAda8xq2+zeEhPFNz1Tu1a/TFieFiSEq8kurGph6zvIGeizoZKEA7wlFOdB0zHJv9DAJDfFYGmvNOuD0k7BhPZInAQPYXLIT0x3FpnV4q5rAgMdJrpf2uh5AG2cU6N80O4qsR70kNLksm6FGQF0peq9zSarjJ1+ywotMYx4vwru9uaXp3G1t6JX14bDSSPZlOhHpEzdwQUXN1bhHVocdBU33fNbYAeeJ90BlmgJ5/7TsjYTdaOJMhh5G1d13867Er2h1EdaPpRVHkCgfjisVJD5mIKTW+CWZT3p2kBahRDFsa5FUuPb3Mx1H8OD8LeC+//woRdcogTNvIEun9caDSKfaUH8xRPSq8JN30fR6W7TALyPqLqkwfWCNxEjz0hdLjY1rMyoIEaCxpyCa/+0GLj+JOf+r93l/CIaMbVGOoJhR+3iXrDsdJZErdinD371HgqPLWzFE2f1AMdKBGU+GQMvqKIOEFiSAwW06wh4phSUKH0MTyCeODmb6khEboPd2lt835JVhCk+OU1744Id8gtsdO35RGk44vOBM/s0gSjt0leuY/LcAeVS9ktSWnbDl+XPB361lAZXS5N2K14N5A0PwMLvo/HJyVsM6novKSBnrEmLLMW+qaUeK5kyaNZFFTDbcg6rUrS3iWncWqpAVxBdkqI73LionSKnI755Xo3Lh738fQDyvPeYptKJyb3dnZqbcNyhUChmhX3gkHIZrKxDyddGG3Cux5PX9eqyQCjkEzAIqPGpHD04iehAVX7Q==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(346002)(396003)(136003)(451199015)(33656002)(66899015)(2906002)(86362001)(36756003)(122000001)(38070700005)(38100700002)(186003)(53546011)(2616005)(6512007)(478600001)(6506007)(26005)(83380400001)(66476007)(41300700001)(76116006)(64756008)(8936002)(66446008)(966005)(66556008)(91956017)(71200400001)(6916009)(8676002)(316002)(6486002)(66946007)(5660300002)(45080400002)(4326008)(7416002)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <D60C4700D5B15945AD3F92150252CA74@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7926
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	613bea2a-036b-4614-c1f9-08dabb438dd5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fVRC2PsszFHkT4On1/uBnrfldN8A3aGi6m4YU/l8z/8sELtDhA7PwnzsL45bR+qIrVVMb6bPhnuaeHkfM15HeQLi8fk3EZQiHUvWw/kkgsw7qsb2Ghmhhs+b6YkDQdG5YHXLElCm32Px/OS7oMfz8Jjxpsza/06um4rTt4hbZVH7qa7g0zXED48vVu2I2fW9T4CfgCFZ5vMkBVMrAeqFa3FLpdZSWbko9hYD9Kw2uk/P87gHhjspDmjS7uKmX9q8bTZDMIJJwUvc65lVl3Zy2quThDcn4c6ZoEcilylwJEWNBn38zmLI6tFl9Xwqbc+1ejn89a/NzFanejnd0AmYWmZFp7hO+Uq+X/Hq95lhkxf4l+7XGwAjq63W8hS75Wj24lv5EuvBMZMS2HY9wg09ZrT0VhvgjjzRymdSBPeKvg29aNN6bf5fSZz9IQwnMVsiwQc1q6GU/QjOSzui5PztJq0YCNFkB0rjufYct2n8fp40DdzbMAmB3oCTsQLzOs47zZL+RqRfdW8YcNlOs/vPVpiJ2ntI8dBi32hLtBRYdxAM/1UoAuauAgVB1Ql6C7ipZN4/8YF8UifCd0/qE80yqrIdhCtQPRCwCd3mo9BaDROfhbCioIoXDx8LwVIQePn8RYPnLPi9hOaax44ueAEp/v5ws4P6kEPZ3yigcUhgRKreyRTAADoPDqcMWzZkoQM7N3WNn6XeY0K+gfqTSVmIE1OCVZPXb81ZRyXRb+BqGrWCpQHJMO8Ax3eoaH0r0nAQh/cWekQgDUg1inUqD8g5+GyzghmTCVjrJUpvwKTUeqE=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(46966006)(36840700001)(40470700004)(336012)(186003)(2616005)(6486002)(966005)(478600001)(2906002)(6512007)(26005)(6506007)(53546011)(107886003)(81166007)(356005)(40460700003)(40480700001)(86362001)(82740400003)(47076005)(36860700001)(83380400001)(33656002)(82310400005)(8936002)(36756003)(6862004)(54906003)(316002)(70206006)(70586007)(8676002)(66899015)(4326008)(5660300002)(41300700001)(45080400002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 13:26:58.2712
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a04b472-7af5-4eff-5ed9-08dabb439627
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6149

SGkgQWxsLA0KDQo+IE9uIDMwIE9jdCAyMDIyLCBhdCAyMToxNCwgU3RlZmFubyBTdGFiZWxsaW5p
IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIFN1biwgMzAgT2N0IDIw
MjIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+IEhpIFN0ZWZhbm8sDQo+PiANCj4+IE9uIDMwLzEw
LzIwMjIgMTQ6MjMsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+PiBPbiBGcmksIDI4IE9j
dCAyMDIyLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+IE9uIDI4LzEwLzIwMjIgMTQ6MTMsIEJl
cnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+Pj4+Pj4gT24gMjggT2N0IDIwMjIsIGF0IDE0OjA2LCBK
dWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+PiANCj4+Pj4+PiBIaSBS
YWh1bCwNCj4+Pj4+PiANCj4+Pj4+PiBPbiAyOC8xMC8yMDIyIDEzOjU0LCBSYWh1bCBTaW5naCB3
cm90ZToNCj4+Pj4+Pj4+Pj4+PiBGb3IgQUNQSSwgSSB3b3VsZCBoYXZlIGV4cGVjdGVkIHRoZSBp
bmZvcm1hdGlvbiB0byBiZQ0KPj4+Pj4+Pj4+Pj4+IGZvdW5kIGluDQo+Pj4+Pj4+Pj4+Pj4gdGhl
IElPUkVRLg0KPj4+Pj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+Pj4+IFNvIGNhbiB5b3UgYWRkIG1vcmUg
Y29udGV4dCB3aHkgdGhpcyBpcyBuZWNlc3NhcnkgZm9yDQo+Pj4+Pj4+Pj4+Pj4gZXZlcnlvbmU/
DQo+Pj4+Pj4+Pj4+PiBXZSBoYXZlIGluZm9ybWF0aW9uIGZvciBJT01NVSBhbmQgTWFzdGVyLUlE
IGJ1dCB3ZSBkb27igJl0DQo+Pj4+Pj4+Pj4+PiBoYXZlDQo+Pj4+Pj4+Pj4+PiBpbmZvcm1hdGlv
biBmb3IgbGlua2luZyB2TWFzdGVyLUlEIHRvIHBNYXN0ZXItSUQuDQo+Pj4+Pj4+Pj4+IA0KPj4+
Pj4+Pj4+PiBJIGFtIGNvbmZ1c2VkLiBCZWxvdywgeW91IGFyZSBtYWtpbmcgdGhlIHZpcnR1YWwg
bWFzdGVyIElEDQo+Pj4+Pj4+Pj4+IG9wdGlvbmFsLiBTbyBzaG91bGRuJ3QgdGhpcyBiZSBtYW5k
YXRvcnkgaWYgeW91IHJlYWxseSBuZWVkDQo+Pj4+Pj4+Pj4+IHRoZQ0KPj4+Pj4+Pj4+PiBtYXBw
aW5nIHdpdGggdGhlIHZpcnR1YWwgSUQ/DQo+Pj4+Pj4+Pj4gdk1hc3RlcklEIGlzIG9wdGlvbmFs
IGlmIHVzZXIga25vd3MgcE1hc3RlcklEIGlzIHVuaXF1ZSBvbiB0aGUNCj4+Pj4+Pj4+PiBzeXN0
ZW0uIEJ1dCBpZiBwTWFzdGVySWQgaXMgbm90IHVuaXF1ZSB0aGVuIHVzZXIgbmVlZHMgdG8NCj4+
Pj4+Pj4+PiBwcm92aWRlDQo+Pj4+Pj4+Pj4gdGhlIHZNYXN0ZXJJRC4NCj4+Pj4+Pj4+IA0KPj4+
Pj4+Pj4gU28gdGhlIGV4cGVjdGF0aW9uIGlzIHRoZSB1c2VyIHdpbGwgYmUgYWJsZSB0byBrbm93
IHRoYXQgdGhlDQo+Pj4+Pj4+PiBwTWFzdGVySUQNCj4+Pj4+Pj4+IGlzIHVuaXEuIFRoaXMgbWF5
IGJlIGVhc3kgd2l0aCBhIGNvdXBsZSBvZiBTTU1VcywgYnV0IGlmIHlvdSBoYXZlDQo+Pj4+Pj4+
PiA1MCsNCj4+Pj4+Pj4+IChhcyBzdWdnZXN0ZWQgYWJvdmUpLiBUaGlzIHdpbGwgYmVjb21lIGEg
cGFpbiBvbiBsYXJnZXIgc3lzdGVtLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBJSE1PLCBpdCB3b3Vs
ZCBiZSBtdWNoIGJldHRlciBpZiB3ZSBjYW4gZGV0ZWN0IHRoYXQgaW4gbGlieGwgKHNlZQ0KPj4+
Pj4+Pj4gYmVsb3cpLg0KPj4+Pj4+PiBXZSBjYW4gbWFrZSB0aGUgdk1hc3RlcklEIGNvbXB1bHNv
cnkgdG8gYXZvaWQgY29tcGxleGl0eSBpbiBsaWJ4bCB0bw0KPj4+Pj4+PiBzb2x2ZSB0aGlzDQo+
Pj4+Pj4gDQo+Pj4+Pj4gSW4gZ2VuZXJhbCwgY29tcGxleGl0eSBpbiBsaWJ4bCBpcyBub3QgdG9v
IG11Y2ggb2YgcHJvYmxlbS4NCj4+PiANCj4+PiBJIGFncmVlIHdpdGggdGhpcyBhbmQgYWxzbyBJ
IGFncmVlIHdpdGggSnVsaWVuJ3Mgb3RoZXIgc3RhdGVtZW50Og0KPj4+IA0KPj4+ICJJIGFtIHN0
cm9uZ2x5IGluIGZhdm9yIG9mIGxpYnhsIHRvIG1vZGlmeSBpdCBpZiBpdCBncmVhdGx5IGltcHJv
dmVzIHRoZQ0KPj4+IHVzZXIgZXhwZXJpZW5jZS4iDQo+Pj4gDQo+Pj4gSSBhbSBhbHdheXMgaW4g
ZmF2b3Igb2YgcmVkdWNpbmcgY29tcGxleGl0eSBmb3IgdGhlIHVzZXIgYXMgdGhleQ0KPj4+IHR5
cGljYWxseSBjYW4ndCBkZWFsIHdpdGggdHJpY2t5IGRldGFpbHMgc3VjaCBhcyBNYXN0ZXJJRHMu
IEluIGdlbmVyYWwsDQo+Pj4gSSB0aGluayB3ZSBuZWVkIG1vcmUgYXV0b21hdGlvbiB3aXRoIG91
ciB0b29saW5nLg0KPj4+IA0KPj4+IEhvd2V2ZXIsIGl0IG1pZ2h0IG5vdCBiZSBhcyBzaW1wbGUg
YXMgYWRkaW5nIHN1cHBvcnQgZm9yIGF1dG9tYXRpY2FsbHkNCj4+PiBnZW5lcmF0aW5nIElEcyBp
biBsaWJ4bCBiZWNhdXNlIHdlIGhhdmUgMiBhZGRpdGlvbmFsIGNhc2VzIHRvIHN1cHBvcnQ6DQo+
Pj4gMSkgZG9tMGxlc3MNCj4+PiAyKSBzdGF0aWNhbGx5IGJ1aWx0IGd1ZXN0cw0KPj4+IA0KPj4+
IEZvciAxKSB3ZSB3b3VsZCBuZWVkIHRoZSBzYW1lIHN1cHBvcnQgYWxzbyBpbiBYZW4/IFdoaWNo
IG1lYW5zIG1vcmUNCj4+PiBjb21wbGV4aXR5IGluIFhlbi4NCj4+IFhlbiB3aWxsIG5lZWQgdG8g
cGFyc2UgdGhlIGRldmljZS10cmVlIHRvIGZpbmQgdGhlIG1hcHBpbmcuIFNvIEkgYW0gbm90DQo+
PiBlbnRpcmVseSBjb252aW5jZWQgdGhlcmUgd2lsbCBiZSBtb3JlIGNvbXBsZXhpdHkgbmVlZGVk
IG90aGVyIHRoYW4gcmVxdWlyaW5nIGENCj4+IGJpdG1hcCB0byBrbm93IHdoaWNoIHZNYXN0ZXJJ
RCBoYXMgYmVlbiBhbGxvY2F0ZWQuDQo+PiANCj4+IFRoYXQgc2FpZCwgeW91IHdvdWxkIHN0aWxs
IG5lZWQgb25lIHRvIHZhbGlkYXRlIHRoZSBpbnB1dCBwcm92aWRlZCBieSB0aGUNCj4+IHVzZXIu
IFNvIG92ZXJhbGwgbWF5YmUgdGhlcmUgd2lsbCBiZSBubyBhZGRlZCBjb21wbGV4aXR5Pw0KPj4g
DQo+Pj4gDQo+Pj4gMikgYXJlIGd1ZXN0cyBsaWtlIFplcGh5ciB0aGF0IGNvbnN1bWUgYSBkZXZp
Y2UgdHJlZSBhdA0KPj4+IGJ1aWxkIHRpbWUgaW5zdGVhZCBvZiBydW50aW1lLiBUaGVzZSBndWVz
dHMgYXJlIGJ1aWx0IHNwZWNpZmljYWxseSBmb3IgYQ0KPj4+IGdpdmVuIGVudmlyb25tZW50IGFu
ZCBpdCBpcyBub3QgYSBwcm9ibGVtIHRvIHJlYnVpbGQgdGhlbSBmb3IgZXZlcnkgWGVuDQo+Pj4g
cmVsZWFzZS4NCj4+PiANCj4+PiBIb3dldmVyIEkgdGhpbmsgaXQgaXMgZ29pbmcgdG8gYmUgYSBw
cm9ibGVtIGlmIHdlIGhhdmUgdG8gcnVuIGxpYnhsIHRvDQo+Pj4gZ2V0IHRoZSBkZXZpY2UgdHJl
ZSBuZWVkZWQgZm9yIHRoZSBaZXBoeXIgYnVpbGQuIFRoYXQgaXMgYmVjYXVzZSBpdA0KPj4+IG1l
YW5zIHRoYXQgdGhlIFplcGh5ciBidWlsZCBzeXN0ZW0gd291bGQgaGF2ZSB0byBsZWFybiBob3cg
dG8gY29tcGlsZQ0KPj4+IChvciBjcm9zc2NvbXBpbGUpIGxpYnhsIGluIG9yZGVyIHRvIHJldHJp
ZXZlIHRoZSBkYXRhIG5lZWRlZCBmb3IgaXRzDQo+Pj4gaW5wdXQuIEV2ZW4gZm9yIHN5c3RlbXMg
YmFzZWQgb24gWW9jdG8gKFlvY3RvIGFscmVhZHkga25vd3MgaG93IHRvIGJ1aWxkDQo+Pj4gbGli
eGwpIHdvdWxkIGNhdXNlIGlzc3VlcyBiZWNhdXNlIG9mIGludGVybmFsIGRlcGVuZGVuY2llcyB0
aGlzIHdvdWxkDQo+Pj4gaW50cm9kdWNlLg0KPj4gDQo+PiBUaGF0IHdvdWxkIG5vdCBiZSB2ZXJ5
IGRpZmZlcmVudCB0byBob3cgdGhpcyB3b3JrcyB0b2RheSBmb3IgWmVwaHlyLiBUaGV5IG5lZWQN
Cj4+IGxpYnhsIHRvIGdlbmVyYXRlIHRoZSBndWVzdCBEVC4NCj4+IA0KPj4gVGhhdCBzYWlkLCBJ
IGFncmVlIHRoaXMgaXMgYSBiaXQgb2YgYSBwYWluLi4uDQo+IA0KPiBZZWFoLi4NCj4gDQo+IA0K
Pj4+IFNvIEkgdGhpbmsgdGhlIGF1dG9tYXRpYyBnZW5lcmF0aW9uIG1pZ2h0IGJlIGJlc3QgZG9u
ZSBpbiBhbm90aGVyIHRvb2wuDQo+PiBJdCBzb3VuZHMgbGlrZSB3aGF0IHlvdSB3YW50IGlzIGNy
ZWF0aW5nIHNvbWV0aGluZyBzaW1pbGFyIHRvIGxpYmFjcGkgYnV0IGZvcg0KPj4gRGV2aWNlLVRy
ZWUuIFRoYXQgc2hvdWxkIHdvcmsgd2l0aCBzb21lIGNhdmVhdHMuDQo+IA0KPiBZZXMsIHNvbWV0
aGluZyBsaWtlIHRoYXQuIFdlIGhhdmUgYSBmcmFtZXdvcmsgZm9yIHJlYWRpbmcsIGVkaXRpbmcg
YW5kDQo+IGdlbmVyYXRpbmcgRGV2aWNlIFRyZWU6IExvcHBlciBodHRwczovL2dpdGh1Yi5jb20v
ZGV2aWNldHJlZS1vcmcvbG9wcGVyDQo+IA0KPiBJdCBpcyBtb3N0bHkgdGFyZ2V0ZWQgYXQgYnVp
bGQgdGltZSBidXQgaXQgY291bGQgYWxzbyBiZSBpbnZva2VkIG9uDQo+IHRhcmdldCBhdCBydW50
aW1lLg0KPiANCj4gDQo+Pj4gSSB0aGluayB3ZSBuZWVkIHNvbWV0aGluZyBsaWtlIGEgc2NyaXB0
IHRoYXQgdGFrZXMgYSBwYXJ0aWFsIGRldmljZSB0cmVlDQo+Pj4gYXMgaW5wdXQgYW5kIHByb3Zp
ZGVzIGEgbW9yZSBkZXRhaWxlZCBwYXJ0aWFsIGRldmljZSB0cmVlIGFzIG91dHB1dCB3aXRoDQo+
Pj4gdGhlIGdlbmVyYXRlZCBJRHMuDQo+PiANCj4+IEFGQUlDVCwgaGF2aW5nIHRoZSBwYXJ0aWFs
IGRldmljZS10cmVlIGlzIG5vdCBlbm91Z2guIFlvdSBhbHNvIG5lZWQgdGhlIHJlYWwNCj4+IERU
IHRvIGZpZ3VyZSBvdXQgdGhlIHBNYXN0ZXItSUQuDQo+PiANCj4+PiANCj4+PiBJZiB3ZSBkaWQg
aXQgdGhhdCB3YXksIHdlIGNvdWxkIGNhbGwgdGhlIHNjcmlwdCBmcm9tIGxpYnhsLCBidXQgYWxz
byB3ZQ0KPj4+IGNvdWxkIGNhbGwgaXQgc2VwYXJhdGVseSBmcm9tIEltYWdlQnVpbGRlciBmb3Ig
ZG9tMGxlc3MgYW5kIFplcGh5ci9Zb2N0bw0KPj4+IGNvdWxkIGFsc28gY2FsbCBpdC4NCj4+PiAN
Cj4+PiBCYXNpY2FsbHkgd2UgbWFrZSBpdCBlYXNpZXIgZm9yIGV2ZXJ5b25lIHRvIHVzZSBpdC4g
VGhlIG9ubHkgcHJpY2UgdG8NCj4+PiBwYXkgaXMgdGhhdCBpdCB3aWxsIGJlIGEgYml0IGxlc3Mg
ZWZmaWNpZW50IGZvciB4bCBndWVzdHMgKG9uZSBtb3JlDQo+Pj4gc2NyaXB0IHRvIGZvcmsgYW5k
IGV4ZWMpIGJ1dCBJIHRoaW5rIGlzIGEgZ29vZCBjb21wcm9taXNlLg0KPj4gDQo+PiBXZSB3b3Vs
ZCBuZWVkIGFuIGh5cGVyY2FsbCB0byByZXRyaWV2ZSB0aGUgaG9zdCBEZXZpY2UtVHJlZS4gQnV0
IHRoYXQgd291bGQNCj4+IG5vdCBiZSB0b28gZGlmZmljdWx0IHRvIGFkZC4NCj4gDQo+IEdvb2Qg
cG9pbnQNCj4gDQo+IA0KPj4+IEkgdGhpbmsgdGhpcyBpcyBhIGdyZWF0IGlkZWEsIEkgb25seSBz
dWdnZXN0IHRoYXQgd2UgbW92ZSB0aGUgYXV0b21hdGljDQo+Pj4gZ2VuZXJhdGlvbiBvdXQgb2Yg
bGlieGwgKGEgc2VwYXJhdGUgc3RhbmQtYWxvbmUgc2NyaXB0KSwgaW4gYW5vdGhlcg0KPj4+IHBs
YWNlIHRoYXQgY2FuIGJlIG1vcmUgZWFzaWx5IHJldXNlZCBieSBtdWx0aXBsZSBwcm9qZWN0cyBh
bmQgZGlmZmVyZW50DQo+Pj4gdXNlLWNhc2VzLg0KPj4gDQo+PiBJZiB3ZSB1c2UgdGhlIGNvbmNl
cHQgb2YgbGliYWNwaSwgd2UgbWF5IG5vdCBuZWVkIGEgdG8gaGF2ZSBhIHN0YW5kLWFsb25lDQo+
PiBzY3JpcHQuIEl0IGNvdWxkIGRpcmVjdGx5IGxpbmtlZCBpbiBsaWJ4bCBvciBhbnkgb3RoZXIg
dG9vbHMuDQo+IA0KPiBJIGRvbid0IGZlZWwgc3Ryb25nbHkgd2hldGhlciBpdCBzaG91bGQgYmUg
YSBsaWJyYXJ5LCBhIHNjcmlwdCBvcg0KPiBzb21ldGhpbmcgZWxzZS4gTXkgb25seSBwb2ludCBp
cyB0aGF0IGl0IHNob3VsZCBiZSBlYXN5IHRvIHVzZSBib3RoIGF0DQo+IGJ1aWxkIHRpbWUgKGUu
Zy4gWW9jdG8vWmVwaHlyL0ltYWdlQnVpbGRlci9Mb3BwZXIpIGFuZCBydW50aW1lDQo+ICh4bC9s
aWJ4bCkuDQo+IA0KPiBXZSBoYXZlIGFscmVhZHkgYSBwYXJ0aWFsIERUQiBnZW5lcmF0b3IgYXMg
YSBMb3BwZXIgImxvcCIgKGEgTG9wcGVyDQo+IHBsdWdpbikuIFByb2JhYmx5IHVzaW5nIExvcHBl
ciB3b3VsZCBiZSB0aGUgZWFzaWVzdCB3YXkgdG8gaW1wbGVtZW50IGl0LA0KPiBhbmQgdGhlICJs
b3AiIGNvdWxkIGJlIHVuZGVyIHhlbi5naXQgKGl0IGRvZXNuJ3QgaGF2ZSB0byByZXNpZGUgdW5k
ZXINCj4gdGhlIGxvcHBlciByZXBvc2l0b3J5KS4NCj4gDQo+IEJ1dCBpZiB3ZSB3YW50ZWQgYSBs
aWJyYXJ5IHRoYXQgd291bGQgYmUgT0sgdG9vLiBUaGUgaXNzdWUgd2l0aCBsaWJ4bCBpcw0KPiBu
b3QgbXVjaCB0aGF0IGl0IGlzIGEgbGlicmFyeSBidXQgdGhhdCBpdCBpcyBjb21wbGV4IHRvIGJ1
aWxkIGFuZCBoYXMNCj4gbWFueSBkZXBlbmRlbmNpZXMgKGl0IGNhbiBvbmx5IGJlIGJ1aWx0IGZy
b20gdGhlIHRvcCBsZXZlbCAuL2NvbmZpZ3VyZQ0KPiBhbmQgbWFrZSkuDQo+IA0KPiBJZGVhbGx5
IHRoaXMgd291bGQgYmUgc29tZXRoaW5nIHF1aWNrIHRoYXQgY2FuIGJlIGVhc2lseSBpbnZva2Vk
IGFzIHRoZQ0KPiBmaXJzdCBzdGVwIG9mIGFuIGV4dGVybmFsIHRoaXJkLXBhcnR5IGJ1aWxkIHBy
b2Nlc3MuDQoNCkkgdGhpbmsgdGhhdCB3ZSBhcmUgbWFraW5nIHRoaXMgcHJvYmxlbSBhIGxvdCB0
byBjb21wbGV4IGFuZCBJIGFtIG5vdCBzdXJlDQp0aGF0IGFsbCB0aGlzIGNvbXBsZXhpdHkgaXMg
cmVxdWlyZWQuDQoNCkZvciBub3csIHdlIGNvdWxkIG1ha2UgdGhlIGFzc3VtcHRpb24gdGhhdCBh
IG1hc3RlciBJRCBpcyB1bmlxIGFuZCBuZXZlcg0KcmV1c2VkIG9uIGEgc3lzdGVtLiBMaW51eCBp
cyBjdXJyZW50bHkgbWFraW5nIHRoaXMgYXNzdW1wdGlvbiB0byBzaW1wbGlmeQ0KdGhlIGNvZGUu
IFdlIGFsc28gZm91bmQgbm8gaGFyZHdhcmUgd2l0aCB0aGUgc2FtZSBtYXN0ZXIgSUQgcmV1c2Vk
Lg0KDQpJdCB3b3VsZCBtZWFuIHRoYXQgdGhlIHVzZXIgd291bGQganVzdCBuZWVkIHRvIGtlZXAg
dGhlIHN0cmVhbS1pZCBwcm9wZXJ0eQ0KaW4gdGhlIGRldmljZSB0cmVlLCByZXBsYWNlIHRoZSBs
aW5rIHRvIHRoZSBTTU1VIHdpdGggYSBmYWtlIHBoYW5kbGUuIFRoZQ0KdG9vbHMgY291bGQgdGhl
biBhZGQgdGhlIHZJT01NVSBub2RlIGFuZCBmaXggYWxsIHBoYW5kbGUgaW4gdGhlIGRldmljZSB0
cmVlDQp0byBwcm9wZXJseSBwb2ludCB0byBpdC4gSW4gcHJhY3RpY2UgdGhlIHVzZXIgY2FuIHNp
bXBseSBjb3B5IHRoZSB3aG9sZSBkZXZpY2UNCm5vZGUgd2l0aCB0aGUgc3RyZWFtLWlkIHByb3Bl
cnRpZXMgYW5kIGp1c3QgcmVwbGFjZSB0aGUgcGhhbmRsZSBieSAweDAuDQoNClRoaXMgd2lsbCBt
YWtlIHRoZSBmaXJzdCBpbXBsZW1lbnRhdGlvbiBhIGxvdCBzaW1wbGVyIGFuZCBwcmV2ZW50IGFk
ZGluZw0KaHlwZXIgY2FsbHMgb3IgdG8gbXVjaCBtYWdpYyBpbiB0aGUgdG9vbHMgZm9yIG5vdy4N
ClRoaXMgd2lsbCBhbHNvIGdpdmUgdXMgbW9yZSB0aW1lIHRvIGNoZWNrIGlmIHdlIG5lZWQgbW9y
ZSBjb21wbGV4IHVzZQ0KY2FzZXMgYW5kIGhvdyB0aGV5IGNvdWxkIGJlIGNvbmZpZ3VyZWQuDQoN
CldoYXQgZG8geW91IHRoaW5rID8NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQoNCg==


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:01:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:01:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432885.685565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVLr-0004Io-EP; Mon, 31 Oct 2022 14:01:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432885.685565; Mon, 31 Oct 2022 14:01:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVLr-0004Ih-Bo; Mon, 31 Oct 2022 14:01:19 +0000
Received: by outflank-mailman (input) for mailman id 432885;
 Mon, 31 Oct 2022 14:01:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1opVLq-0004Ib-6u
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 14:01:18 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 7b1f0af5-5924-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 15:01:14 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D5DB1FB;
 Mon, 31 Oct 2022 07:01:22 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98A023F5A1;
 Mon, 31 Oct 2022 07:01:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b1f0af5-5924-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@amd.com,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 0/4] Yocto Gitlab CI
Date: Mon, 31 Oct 2022 14:00:52 +0000
Message-Id: <cover.1667224593.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This patch series is a first attempt to check if we could use Yocto in
gitlab ci to build and run xen on qemu for arm, arm64 and x86.

The first patch is creating a container with all elements required to
build Yocto, a checkout of the yocto layers required and an helper
script to build and run xen on qemu with yocto.

The second patch is creating containers with a first build of yocto done
so that susbsequent build with those containers would only rebuild what
was changed and take the rest from the cache.

The third patch is adding a way to easily clean locally created
containers.

This is is mainly for discussion and sharing as there are still some
issues/problem to solve:
- building the qemu* containers can take several hours depending on the
  network bandwith and computing power of the machine where those are
  created
- produced containers containing the cache have a size between 8 and
  12GB depending on the architecture. We might need to store the build
  cache somewhere else to reduce the size. If we choose to have one
  single image, the needed size is around 20GB and we need up to 40GB
  during the build, which is why I splitted them.
- during the build and run, we use a bit more then 20GB of disk which is
  over the allowed size in gitlab

Once all problems passed, this can be used to build and run dom0 on qemu
with a modified Xen on the 3 archs in less than 10 minutes.

This has been tested on a x86 host machine and on an arm host machine
(with mk_dsdt.c fix).

Changes in v3:
- limit number of jobs in yocto
- do not copy build script inside container
- add patch from Michal to create gitlab jobs

Changes in v2:
- remove gitignore patch which was merged
- add a --dump-log support in build-yocto.sh script and use it during
  container creation to see the error logs.

Bertrand Marquis (3):
  automation: Add elements for Yocto test and run
  automation: Add yocto containers with cache
  automation: Add a clean rule for containers

Michal Orzel (1):
  automation: Add CI test jobs for Yocto

 automation/build/Makefile                     |  19 +-
 automation/build/yocto/build-yocto.sh         | 349 ++++++++++++++++++
 .../build/yocto/kirkstone-qemuarm.dockerfile  |  29 ++
 .../yocto/kirkstone-qemuarm64.dockerfile      |  29 ++
 .../yocto/kirkstone-qemux86-64.dockerfile     |  29 ++
 automation/build/yocto/kirkstone.dockerfile   |  97 +++++
 automation/gitlab-ci/test.yaml                |  34 ++
 7 files changed, 585 insertions(+), 1 deletion(-)
 create mode 100755 automation/build/yocto/build-yocto.sh
 create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile
 create mode 100644 automation/build/yocto/kirkstone.dockerfile

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:01:32 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:01:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432886.685577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM4-0004ad-ML; Mon, 31 Oct 2022 14:01:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432886.685577; Mon, 31 Oct 2022 14:01:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM4-0004aW-Im; Mon, 31 Oct 2022 14:01:32 +0000
Received: by outflank-mailman (input) for mailman id 432886;
 Mon, 31 Oct 2022 14:01:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1opVM2-0004Ib-OI
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 14:01:30 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 82f2a89d-5924-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 15:01:27 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A826523A;
 Mon, 31 Oct 2022 07:01:35 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B48333F5A1;
 Mon, 31 Oct 2022 07:01:28 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82f2a89d-5924-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@amd.com,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 2/4] automation: Add yocto containers with cache
Date: Mon, 31 Oct 2022 14:00:54 +0000
Message-Id: <6538dd8bc1fce8f6848567a0a7fbab00d49bd2ae.1667224593.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1667224593.git.bertrand.marquis@arm.com>
References: <cover.1667224593.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Create yocto containers for kirkstone with a builder step to fill the
yocto cache by running the build script once.
Those containers depend on the kirkstone.dockerfile container to be
created and use it as base image.

To run a build test on one image the following command must be called
inside the container:
build-yocto.sh --xen-dir=XENSRC TARGET where
- XENSRC is the directory where xen sources are available in the
container
- TARGET is the build target (qemuarm64, qemuarm or qemux86_64)

In case of error, the script will return an error code and the logs will
be in /home/docker-build/logs.

!!!
The build of each container can take several hours depending on the
network bandwith (for downloading all sources) and the amount of
computing power on the machine where the docker images are created.
!!!

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v3:
- Copy build-yocto.sh inside the container before running it to generate
the cache.
Changes in v2:
- pass --dump-log option to build-yocto.sh during the image generation
so that we have more info when there is an error during the image
creation.
Changes in v1:
- fix dependency in Makefile
---
 automation/build/Makefile                     |  2 ++
 .../build/yocto/kirkstone-qemuarm.dockerfile  | 29 +++++++++++++++++++
 .../yocto/kirkstone-qemuarm64.dockerfile      | 29 +++++++++++++++++++
 .../yocto/kirkstone-qemux86-64.dockerfile     | 29 +++++++++++++++++++
 4 files changed, 89 insertions(+)
 create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile
 create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile

diff --git a/automation/build/Makefile b/automation/build/Makefile
index a4b2b85178cf..b0dc68f00b70 100644
--- a/automation/build/Makefile
+++ b/automation/build/Makefile
@@ -16,5 +16,7 @@ help:
 		$(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \
 	fi
 
+$(subst .dockerfile,,$(wildcard yocto/kirkstone-*)): yocto/kirkstone
+
 .PHONY: all
 all: $(CONTAINERS)
diff --git a/automation/build/yocto/kirkstone-qemuarm.dockerfile b/automation/build/yocto/kirkstone-qemuarm.dockerfile
new file mode 100644
index 000000000000..e4540021d0af
--- /dev/null
+++ b/automation/build/yocto/kirkstone-qemuarm.dockerfile
@@ -0,0 +1,29 @@
+# Docker file to populate the initial sstate and download cache for yocto
+# for a specific target
+#
+# This requires the build-yocto.sh script to be in the same directory as this
+# dockerfile during the image creation
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "from_image=img" to select the docker image and tag to start from
+# "target=qemuxxx": to select which target to build in this image
+
+ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone
+
+FROM $from_image AS builder
+
+ARG target=qemuarm
+
+# This step can take one to several hours depending on your download bandwith
+# and the speed of your computer
+COPY ./build-yocto.sh /
+RUN /build-yocto.sh --dump-log $target
+
+FROM $from_image
+
+# Only copy the cache status
+COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/.
+
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
new file mode 100644
index 000000000000..aea3fc1f3e5d
--- /dev/null
+++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile
@@ -0,0 +1,29 @@
+# Docker file to populate the initial sstate and download cache for yocto
+# for a specific target
+#
+# This requires the build-yocto.sh script to be in the same directory as this
+# dockerfile during the image creation
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "from_image=img" to select the docker image and tag to start from
+# "target=qemuxxx": to select which target to build in this image
+
+ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone
+
+FROM $from_image AS builder
+
+ARG target=qemuarm64
+
+# This step can take one to several hours depending on your download bandwith
+# and the speed of your computer
+COPY ./build-yocto.sh /
+RUN /build-yocto.sh --dump-log $target
+
+FROM $from_image
+
+# Only copy the cache status
+COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/.
+
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
diff --git a/automation/build/yocto/kirkstone-qemux86-64.dockerfile b/automation/build/yocto/kirkstone-qemux86-64.dockerfile
new file mode 100644
index 000000000000..9b2277a65e33
--- /dev/null
+++ b/automation/build/yocto/kirkstone-qemux86-64.dockerfile
@@ -0,0 +1,29 @@
+# Docker file to populate the initial sstate and download cache for yocto
+# for a specific target
+#
+# This requires the build-yocto.sh script to be in the same directory as this
+# dockerfile during the image creation
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "from_image=img" to select the docker image and tag to start from
+# "target=qemuxxx": to select which target to build in this image
+
+ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone
+
+FROM $from_image AS builder
+
+ARG target=qemux86-64
+
+# This step can take one to several hours depending on your download bandwith
+# and the speed of your computer
+COPY ./build-yocto.sh /
+RUN /build-yocto.sh --dump-log $target
+
+FROM $from_image
+
+# Only copy the cache status
+COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/.
+
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:01:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:01:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432887.685581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM5-0004dU-2V; Mon, 31 Oct 2022 14:01:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432887.685581; Mon, 31 Oct 2022 14:01:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM4-0004cv-Ro; Mon, 31 Oct 2022 14:01:32 +0000
Received: by outflank-mailman (input) for mailman id 432887;
 Mon, 31 Oct 2022 14:01:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1opVM3-0004Zq-19
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 14:01:31 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 84240b00-5924-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 15:01:29 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5D811FB;
 Mon, 31 Oct 2022 07:01:34 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B71723F5A1;
 Mon, 31 Oct 2022 07:01:27 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84240b00-5924-11ed-91b5-6bf2151ebd3b
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@amd.com,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 1/4] automation: Add elements for Yocto test and run
Date: Mon, 31 Oct 2022 14:00:53 +0000
Message-Id: <447141266843aeb30cf08507183e06815e957dfe.1667224593.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1667224593.git.bertrand.marquis@arm.com>
References: <cover.1667224593.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add a container suitable to run yocto kirkstone build based on ubuntu
22.04. It contains all packages required by Yocto and a checkout of the
layers required to build Xen with Yocto.

Add a build script to build and run xen on qemu using Yocto.
The script supports arm32, arm64 and x86_64 and checks that dom0 is
properly booting. At this stage this does not run any guest on top of
dom0.

The build script is currently in the same directory than the docker
files so that it can be included directly in the image. This is required
for the next step which creates images with an initial cache content to
speed up testing.

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v3:
- limit number of jobs in yocto by default to 8 and add --num-jobs
option to the script to set a custom number of jobs
- do not copy anymore the build-yocto.sh script inside the main image so
that the current one in the repository is used when running
Changes in v2:
- add a --dump-log command line option to build-yocto.sh script to dump
the logs if an error occurs.
Changes in v1:
- add --image command line argument to build-yocto.sh to allow building
something different than xen-image-minimal.
- modify dockerfile to have one layer per line and make it easier to add
other. I kept the for loop to keep the number of docker steps lower
- update commit message to warn that no guest are tested.
- fix build-yocto script to properly return with an error if expect
script ends up in timeout or EOF.
---
 automation/build/yocto/build-yocto.sh       | 349 ++++++++++++++++++++
 automation/build/yocto/kirkstone.dockerfile |  97 ++++++
 2 files changed, 446 insertions(+)
 create mode 100755 automation/build/yocto/build-yocto.sh
 create mode 100644 automation/build/yocto/kirkstone.dockerfile

diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh
new file mode 100755
index 000000000000..d0c93dfaffe0
--- /dev/null
+++ b/automation/build/yocto/build-yocto.sh
@@ -0,0 +1,349 @@
+#!/bin/bash
+#
+# Yocto meta virtualization build and run script
+#
+# This script is building Yocto xen-image-minimal for qemu targets and run
+# them using runqemu inside yocto to check that dom0 is booting properly
+# The build is using a local xen source tree so that specific patches can be
+# tested.
+# In order to optimize the build time, a build cache is used so that only xen
+# packages and its dependencies are rebuilt (qemu and final image mainly).
+#
+
+# Directories
+YOCTODIR="$HOME/yocto-layers"
+CACHEDIR="$HOME/yocto-cache"
+LOGDIR="$HOME/logs"
+XENDIR="$HOME/xen"
+BUILDDIR="$HOME/build"
+
+# what yocto bsp we support
+TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64"
+VERBOSE="n"
+TARGETLIST=""
+BUILDJOBS="8"
+
+# actions to do
+do_clean="n"
+do_build="y"
+do_run="y"
+do_localsrc="n"
+do_dump="n"
+build_result=0
+
+# layers to include in the project
+build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \
+                 meta-openembedded/meta-oe meta-openembedded/meta-python \
+                 meta-openembedded/meta-filesystems \
+                 meta-openembedded/meta-networking meta-virtualization"
+
+# yocto image to build
+build_image="xen-image-minimal"
+
+function print_progress() {
+    echo -n "$(date +%T) $*"
+}
+
+function run_task() {
+    local task_name="$1"
+    local task_target="$2"
+
+    task_log="${task_name//project_}-${task_target}"
+
+    mkdir -p "${LOGDIR}"
+    print_progress
+    echo -n "${task_name//project_} ${task_target}: "
+    if [ "${VERBOSE}" = "n" ]; then
+        $@ > "${LOGDIR}/${task_log}.log" 2>&1
+    else
+        $@ 2>&1 | tee "${LOGDIR}/${task_log}.log"
+    fi
+
+    if [ ${?} -ne 0 ]; then
+        echo "Error"
+        build_result=$((build_result+1))
+        if [ "${do_dump}" = "y" ]; then
+            echo
+            echo "############ LOGS-START ############"
+            cat "${LOGDIR}/${task_log}.log"
+            echo "############  LOGS-END  ############"
+            echo
+        fi
+        return 1
+    else
+        echo "OK"
+        return 0
+    fi
+}
+
+function project_create() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+
+    (
+        # init yocto project
+        source ${YOCTODIR}/poky/oe-init-build-env "${destdir}"
+
+        # add needed layers
+        for layer in ${build_layerlist}; do
+            bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1
+        done
+    ) || return 1
+
+    # customize project configuration
+    cat <<EOF >> "${destdir}/conf/local.conf"
+# Yocto BSP
+MACHINE = "${target}"
+
+# Use local cache to reuse previous builds results
+SSTATE_DIR = "${CACHEDIR}/sstate-cache"
+DL_DIR = "${CACHEDIR}/downloads"
+
+# Enable xen and virtualization
+DISTRO_FEATURES = " virtualization xen ipv4"
+
+# Speed up run by not generating ssh host keys
+IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys"
+
+# Save some disk space
+INHERIT += "rm_work"
+
+# Reduce number of jobs
+BB_NUMBER_THREADS="${BUILDJOBS}"
+
+EOF
+
+    if [ "${do_localsrc}" = "y" ]; then
+        XENVERS=$(grep -e "^XEN_REL" \
+            "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \
+            2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \
+            | sed -e "s/.*=//" | sort -V | tail -n 1)
+
+        XENBASE=$(dirname "$(realpath -m "${XENDIR}")")
+        XENSUB=$(basename "$(realpath -m "${XENDIR}")")
+
+        cat <<EOF >> "${destdir}/conf/local.conf"
+# Use local sources for xen and xen-tools
+FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:"
+FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:"
+
+SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/"
+SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/"
+
+PREFERRED_VERSION:pn-xen = "${XENVERS}%"
+PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%"
+
+S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}"
+S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}"
+
+SRCREV:pn-xen = "\${AUTOREV}"
+SRCREV:pn-xen-tools = "\${AUTOREV}"
+
+SRCPV:pn-xen = "1"
+SRCPV:pn-xen-tools = "1"
+
+# Disable all QA errors as the recipe is not up to date with changes in Xen
+# when we use local sources
+ERROR_QA:pn-xen = "arch"
+ERROR_QA:pn-xen-tools = "arch"
+
+EOF
+    fi
+}
+
+function project_build() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+
+    (
+        source ${YOCTODIR}/poky/oe-init-build-env "${destdir}"
+
+        bitbake "${build_image}" || exit 1
+    ) || return 1
+}
+
+function project_clean() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+
+    rm -rf "${destdir}"
+}
+
+function project_run() {
+    target="${1:?}"
+    destdir="${BUILDDIR}/${target}"
+    (
+        source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1
+
+        /usr/bin/expect <<EOF
+set timeout 100
+spawn bash -c "runqemu serialstdio nographic slirp"
+
+expect_after {
+    -re "(.*)\r" {
+        exp_continue
+    }
+    timeout {send_user "ERROR-Timeout!\n"; exit 1}
+    eof {send_user "ERROR-EOF!\n"; exit 1}
+}
+
+# wait initial login
+expect -re ".* login: "
+send "root\r"
+expect -re "root@.*# "
+
+EOF
+    exit $?
+    ) || return 1
+}
+
+function help() {
+    cat <<EOF
+Usage: ${0} [TARGET1] [TARGET2]
+
+This script is build the yocto xen-image-minimal for different qemu targets
+and is running it after.
+Without any target specified, all supported targets are done.
+
+Options:
+  -h, --help       Print this help
+  -v, --verbose    Verbose build
+  --list-target    List supported targets
+  --clean          Clean existing project before starting
+  --no-build       Do not build (to run an already built project)
+  --no-run         Do not run
+  --num-jobs=NUM   Define the number of parallel jobs in Yocto.
+                   Default: ${BUILDJOBS}
+  --dump-log       On error, dump the logs on the console
+  --image=IMG      Yocto image or package to build
+                   Default: xen-image-minimal
+  --xen-dir=DIR    path to xen hypervisor source tree
+                   if not provide, normal yocto version of xen is built
+                   Default: ${XENDIR}
+  --out-dir=DIR    directory where to create the projectss
+                   Default: ${BUILDDIR}
+  --log-dir=DIR    directory to store logs
+                   Default: ${LOGDIR}
+  --cache-dir=DIR  directory where to take and store build cache
+                   Default: ${CACHEDIR}
+  --layer-dir=DIR  directory containing the checkout of yocto layers
+                   Default: ${YOCTODIR}
+EOF
+}
+
+for OPTION in "$@"
+do
+    case ${OPTION} in
+        -h|--help)
+            help
+            exit 0
+            ;;
+        -v|--verbose)
+            VERBOSE="y"
+            ;;
+        --list-targets)
+            echo "${TARGET_SUPPORTED}"
+            exit 0
+            ;;
+        --clean)
+            do_clean="y"
+            ;;
+        --no-build)
+            do_build="n"
+            ;;
+        --no-run)
+            do_run="n"
+            ;;
+        --dump-log)
+            do_dump="y"
+            ;;
+        --num-jobs=*)
+            BUILDJOBS="${OPTION#*=}"
+            ;;
+        --image=*)
+            build_image="${OPTION#*=}"
+            ;;
+        --xen-dir=*)
+            XENDIR="${OPTION#*=}"
+            if [ ! -e "${XENDIR}/xen/Makefile" ]; then
+                echo "No Xen source tree in ${XENDIR}"
+                exit 1
+            fi
+            do_localsrc="y"
+            ;;
+        --out-dir=*)
+            BUILDDIR="${OPTION#*=}"
+            ;;
+        --log-dir=*)
+            LOGDIR="${OPTION#*=}"
+            ;;
+        --cache-dir=*)
+            CACHEDIR="${OPTION#*=}"
+            ;;
+        --layer-dir=*)
+            YOCTODIR="${OPTION#*=}"
+            ;;
+        --*)
+            echo "Invalid option ${OPTION}"
+            help
+            exit 1
+            ;;
+        *)
+            if echo "${TARGET_SUPPORTED}" | grep -q -w "${OPTION}"; then
+                TARGETLIST="${TARGETLIST} ${OPTION}"
+            else
+                echo "Unsupported target ${OPTION}"
+                exit 1
+            fi
+            ;;
+    esac
+done
+
+# if no target is specified build all targets
+if [ -z "${TARGETLIST}" ]; then
+    TARGETLIST="${TARGET_SUPPORTED}"
+fi
+
+mkdir -p "${CACHEDIR}"
+mkdir -p "${LOGDIR}"
+mkdir -p "${BUILDDIR}"
+
+# Make sure we have an absolute path
+YOCTODIR=$(realpath -m "${YOCTODIR}")
+CACHEDIR=$(realpath -m "${CACHEDIR}")
+BUILDDIR=$(realpath -m "${BUILDDIR}")
+LOGDIR=$(realpath -m "${LOGDIR}")
+if [ "${do_localsrc}" = "y" ]; then
+    XENDIR=$(realpath -m "${XENDIR}")
+fi
+
+# Check that we have all the layers we need
+for f in ${build_layerlist}; do
+    if [ ! -f "${YOCTODIR}/${f}/conf/layer.conf" ]; then
+        echo "Layer ${f} missing in ${YOCTODIR}"
+        exit 1
+    fi
+done
+
+for f in ${TARGETLIST}; do
+    if [ "${do_clean}" = "y" ]; then
+        run_task project_clean ${f}
+    fi
+    if [ ! -f ${BUILDDIR}/${f}/conf/local.conf ]; then
+        run_task project_create ${f}
+    fi
+    if [ -f ${BUILDDIR}/${f}/conf/local.conf ]; then
+        if [ "${do_build}" = "y" ]; then
+            run_task project_build ${f}
+        fi
+        if [ "${do_run}" = "y" ]; then
+            run_task project_run ${f}
+        fi
+
+    fi
+done
+
+print_progress "Build Complete (${build_result} errors)"
+echo
+exit ${build_result}
+
diff --git a/automation/build/yocto/kirkstone.dockerfile b/automation/build/yocto/kirkstone.dockerfile
new file mode 100644
index 000000000000..ffbd91aa90cc
--- /dev/null
+++ b/automation/build/yocto/kirkstone.dockerfile
@@ -0,0 +1,97 @@
+# Docker file to create an environment to build yocto with virtualization
+#
+# Arguments that can be passed during image creation using --build-arg:
+# "host_uid=$(id -u)": to use current user uid for build user in the image
+# "host_gid=$(id -g)": to use current user gid for build user in the image
+# "yocto_version=VERS": to select the Yocto version (branch name)
+
+# Use standard ubuntu minimal
+From ubuntu:22.04
+LABEL maintainer.name="The Xen Project " \
+      maintainer.email="xen-devel@lists.xenproject.org"
+
+ENV DEBIAN_FRONTEND=noninteractive
+
+# Install minimal ubuntu requirements for yocto and other tools we need
+# See https://docs.yoctoproject.org/4.0.1/brief-yoctoprojectqs/index.html#build-host-packages
+RUN apt-get update && \
+    apt-get --quiet --yes install \
+        gawk \
+        wget \
+        git \
+        diffstat \
+        unzip \
+        texinfo \
+        gcc \
+        build-essential \
+        chrpath \
+        socat \
+        cpio \
+        python3 \
+        python3-pip \
+        python3-pexpect \
+        xz-utils \
+        debianutils \
+        iputils-ping \
+        python3-git \
+        python3-jinja2 \
+        libegl1-mesa \
+        libsdl1.2-dev \
+        python3-subunit \
+        mesa-common-dev \
+        zstd \
+        liblz4-tool \
+        file \
+        vim \
+        bison \
+        expect \
+        locales \
+        liblz4-tool \
+        zstd \
+        openssl \
+        libssl3 \
+        ca-certificates \
+        && \
+        apt-get autoremove -y && \
+        apt-get clean && \
+        rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/*
+
+# Use bash as shell
+RUN rm /bin/sh && ln -s bash /bin/sh
+
+# Fix local for yocto
+RUN locale-gen en_US.UTF-8 && update-locale LC_ALL=en_US.UTF-8 \
+    LANG=en_US.UTF-8
+ENV LANG en_US.UTF-8
+ENV LC_ALL en_US.UTF-8
+
+# Create a user for the build (we don't want to build as root)
+ENV USER_NAME docker-build
+ARG host_uid=1000
+ARG host_gid=1000
+RUN groupadd -g $host_gid $USER_NAME && \
+    useradd -g $host_gid -m -s /bin/bash -u $host_uid $USER_NAME
+
+# Switch to our user instead of root and start in its home
+USER $USER_NAME
+WORKDIR /home/$USER_NAME
+
+# Create needed directories
+RUN mkdir -p /home/$USER_NAME/yocto-layers \
+             /home/$USER_NAME/yocto-cache \
+             /home/$USER_NAME/logs \
+             /home/$USER_NAME/bin \
+             /home/$USER_NAME/xen && \
+    chown $USER_NAME.$USER_NAME /home/$USER_NAME/*
+
+# clone yocto repositories we need
+ARG yocto_version="kirkstone"
+RUN for rep in \
+                https://github.com/openembedded/meta-openembedded \
+                https://git.yoctoproject.org/poky \
+                https://git.yoctoproject.org/meta-virtualization \
+            ; do \
+        git -C /home/$USER_NAME/yocto-layers \
+            clone -b $yocto_version --single-branch $rep; \
+    done
+
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:01:33 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:01:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432888.685588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM5-0004ji-F2; Mon, 31 Oct 2022 14:01:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432888.685588; Mon, 31 Oct 2022 14:01:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM5-0004hm-6V; Mon, 31 Oct 2022 14:01:33 +0000
Received: by outflank-mailman (input) for mailman id 432888;
 Mon, 31 Oct 2022 14:01:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1opVM3-0004Ib-OT
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 14:01:31 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 83773202-5924-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 15:01:28 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ACE8113E;
 Mon, 31 Oct 2022 07:01:36 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 972413F5A1;
 Mon, 31 Oct 2022 07:01:29 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83773202-5924-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@amd.com,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 3/4] automation: Add a clean rule for containers
Date: Mon, 31 Oct 2022 14:00:55 +0000
Message-Id: <08c3c29a85d0857ec7652f86c66e801bf0bc3e89.1667224593.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1667224593.git.bertrand.marquis@arm.com>
References: <cover.1667224593.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add make clean support to remove the containers from the local docker
registry:
- make clean: remove all images
- clean-yocto/kirkstone-qemuarm: remove yocto kirkstone for qemuarm
image

Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
Changes in v3:
- none
Changes in v2:
- none
Changes in v1:
- patch added
---
 automation/build/Makefile | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/automation/build/Makefile b/automation/build/Makefile
index b0dc68f00b70..9fbb49c8717e 100644
--- a/automation/build/Makefile
+++ b/automation/build/Makefile
@@ -4,6 +4,17 @@ REGISTRY := registry.gitlab.com/xen-project/xen
 CONTAINERS = $(subst .dockerfile,,$(wildcard */*.dockerfile))
 DOCKER_CMD ?= docker
 
+define CLEAN_RULE
+.PHONY: clean-$(1)
+clean-$(1):
+ifneq ($$(shell docker image ls -q $(REGISTRY)/$(subst /,:,$(1))),)
+	docker image rm $(REGISTRY)/$(subst /,:,$(1))
+endif
+
+clean: clean-$(1)
+
+endef
+
 help:
 	@echo "Builds containers for building Xen based on different distros"
 	@echo "To build one run 'make DISTRO/VERSION'. Available containers:"
@@ -18,5 +29,9 @@ help:
 
 $(subst .dockerfile,,$(wildcard yocto/kirkstone-*)): yocto/kirkstone
 
-.PHONY: all
+.PHONY: all clean
 all: $(CONTAINERS)
+
+clean:
+
+$(eval $(foreach img,$(CONTAINERS),$(call CLEAN_RULE,$(img))))
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:01:35 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:01:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432889.685610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM6-0005MV-Tu; Mon, 31 Oct 2022 14:01:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432889.685610; Mon, 31 Oct 2022 14:01:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVM6-0005LU-Qn; Mon, 31 Oct 2022 14:01:34 +0000
Received: by outflank-mailman (input) for mailman id 432889;
 Mon, 31 Oct 2022 14:01:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=bertrand.marquis@srs-se1.protection.inumbo.net>)
 id 1opVM4-0004Ib-Oq
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 14:01:32 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 83ff3c8c-5924-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 15:01:28 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DDE911FB;
 Mon, 31 Oct 2022 07:01:37 -0700 (PDT)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A3373F5A1;
 Mon, 31 Oct 2022 07:01:30 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83ff3c8c-5924-11ed-8fd0-01056ac49cbb
From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: michal.orzel@amd.com,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 4/4] automation: Add CI test jobs for Yocto
Date: Mon, 31 Oct 2022 14:00:56 +0000
Message-Id: <00335fd0abaee077c09a33ec6c3ae93ddce30f5b.1667224593.git.bertrand.marquis@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <cover.1667224593.git.bertrand.marquis@arm.com>
References: <cover.1667224593.git.bertrand.marquis@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Michal Orzel <michal.orzel@amd.com>

Populate test jobs for Yocto based tests using the provided containers.
Due to the size restrictions, it is currently not possible to split the
build and run tasks, therefore everything is done in a single step.

Test jobs for the supported Yocto targets are generic to avoid the
necessity to add new ones after each Yocto release. The only thing
required to be changed after updating the containers is the variable
YOCTO_VERSION stored in a .yocto-test template.

Signed-off-by: Michal Orzel <michal.orzel@amd.com>
---
Changes in v3:
- patch added
---
 automation/gitlab-ci/test.yaml | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index fc0884b12082..44febcf97262 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -52,6 +52,18 @@
   tags:
     - x86_64
 
+.yocto-test:
+  extends: .test-jobs-common
+  script:
+    - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD}
+  variables:
+    YOCTO_VERSION: kirkstone
+    CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}
+  artifacts:
+    paths:
+      - 'logs/*'
+    when: always
+
 # Test jobs
 build-each-commit-gcc:
   extends: .test-jobs-common
@@ -186,3 +198,25 @@ qemu-smoke-x86-64-clang-pvh:
     - ./automation/scripts/qemu-smoke-x86-64.sh pvh 2>&1 | tee ${LOGFILE}
   needs:
     - debian-unstable-clang-debug
+
+# Yocto test jobs
+yocto-qemuarm64:
+  extends: .yocto-test
+  variables:
+    YOCTO_BOARD: qemuarm64
+  tags:
+    - arm64
+
+yocto-qemuarm:
+  extends: .yocto-test
+  variables:
+    YOCTO_BOARD: qemuarm
+  tags:
+    - arm32
+
+yocto-qemux86-64:
+  extends: .yocto-test
+  variables:
+    YOCTO_BOARD: qemux86-64
+  tags:
+    - x86_64
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432764.685628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQX-0007Yc-Kg; Mon, 31 Oct 2022 14:06:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432764.685628; Mon, 31 Oct 2022 14:06:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQX-0007YV-I5; Mon, 31 Oct 2022 14:06:09 +0000
Received: by outflank-mailman (input) for mailman id 432764;
 Mon, 31 Oct 2022 11:58:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTRR-000432-6C
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 11:58:57 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 648f52f1-5913-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 12:58:55 +0100 (CET)
Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com
 [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-513-39d5fIbEO5ehtIvHPTtDXQ-1; Mon, 31 Oct 2022 07:58:52 -0400
Received: by mail-wm1-f72.google.com with SMTP id
 p9-20020a1c7409000000b003cf670dad6eso662744wmc.7
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 04:58:52 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 cc14-20020a5d5c0e000000b00228d67db06esm7103664wrb.21.2022.10.31.04.58.49
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 04:58:50 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 648f52f1-5913-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667217534;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NYUZwRg+lRYohe3+hrEekpmCQsb4LiBLuZ4BzJljYVc=;
	b=Aq4ZBF4ZVamQvcwUjGrWN6SbfFODTTStAp6SHUNgwxI69310k/oVrQ32aVwOqmNcHvkD1S
	NyA9Fv8isKswEA8UZ/oD88DxiBN2xKrAfsSn3loxs2qbJ8LfM6hGrcQbXNDBhAuPMxfsEf
	JjQTBAQhaVEmZ7nv/LS1cRv9Wn/bw3s=
X-MC-Unique: 39d5fIbEO5ehtIvHPTtDXQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=NYUZwRg+lRYohe3+hrEekpmCQsb4LiBLuZ4BzJljYVc=;
        b=zK2iwSKAmW+0SGj5D471oxKENoFhqfPXxL/73QI9belifgZwoShz7Qzp5B1qpKfBpy
         FH71CIElqFmrZittnEha5cwg3fHUVStryZZv3gKEqOCs0sD3X1CR7Dxx+Kbw/pq3pb+9
         DjC+WP8YGifQ5MYPUqV9maJvq+gSzI3Kw/b1uXjpuplkTVeZF9bA6Q1fDZtq9FBIQ0E9
         tFaXpUUw7uypW8djR7SlzHafWx5xrSfnocJ6BpRD66zgB7CLPkXXu2AEkIUiqp6PJHxS
         Mwet2eaUlCBZe9mHRx7UIr5GMNNlHl4M5rV8fgHfWgVLVhwD2riLDl5CaYd4ISTkaGnf
         tPPQ==
X-Gm-Message-State: ACrzQf3mg6SdyQXsDfzOieWuj88JAmXLOB/3pcffLUOQffMeOXrqcr+h
	/hEZBLxBDbXGN8bCV54p86+c7pg0vOuERBFDRNV0qYbLrcRX/l0v+9E6vFoh8e5te1hgam/qOjL
	QYcTE4C6sem4enlcmJkMXIMYObqI=
X-Received: by 2002:adf:ee46:0:b0:236:57e4:60d9 with SMTP id w6-20020adfee46000000b0023657e460d9mr7712402wro.208.1667217531291;
        Mon, 31 Oct 2022 04:58:51 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5NlG/EcNgth7sygR/Y2wmF3YkVg5o1INpxQYpcg5X49eIhA0omsq50HY00GhqtS98H3T4hUQ==
X-Received: by 2002:adf:ee46:0:b0:236:57e4:60d9 with SMTP id w6-20020adfee46000000b0023657e460d9mr7712386wro.208.1667217531117;
        Mon, 31 Oct 2022 04:58:51 -0700 (PDT)
Message-ID: <365e1467-7dc2-42b4-b985-53323741dea8@redhat.com>
Date: Mon, 31 Oct 2022 12:58:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 01/21] drm/komeda: Don't set struct
 drm_driver.lastclose
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-2-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-2-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.lastclose. It's used to restore the
> fbdev console. But as komeda uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See
> the call to drm_client_dev_restore() in drm_lastclose().
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432766.685634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQX-0007bz-Sx; Mon, 31 Oct 2022 14:06:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432766.685634; Mon, 31 Oct 2022 14:06:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQX-0007bP-PC; Mon, 31 Oct 2022 14:06:09 +0000
Received: by outflank-mailman (input) for mailman id 432766;
 Mon, 31 Oct 2022 11:59:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTS9-00043u-Ah
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 11:59:41 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f6b87cb-5913-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 12:59:40 +0100 (CET)
Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com
 [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-671-EsYKBKFfPXqhcOhuIYqi3A-1; Mon, 31 Oct 2022 07:59:38 -0400
Received: by mail-wm1-f72.google.com with SMTP id
 az11-20020a05600c600b00b003c6e3d4d5b1so5200866wmb.7
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 04:59:37 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 123-20020a1c1981000000b003c6c182bef9sm7774720wmz.36.2022.10.31.04.59.35
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 04:59:36 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f6b87cb-5913-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667217579;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ypYZqoZTsptEoKYiFoPm/p19rfXtb3oU3pAWnCNe+WI=;
	b=g4jMqAp8hrGRUSmI2Hc4CZvOW0ebl46D4m3RfmyoWgCmf2lrlh3KOdMx6WKwy6Wms7BBpu
	9oFmNSmJ1GNJ0f9OwMeNqOTKRyvkNNdkJOzaaR8FxeKcNNwJnA1wtKNxvfiBk4dKz+vhjf
	7Gxvj1aF3r85fgbNn4qnVwdUj3RxF6Y=
X-MC-Unique: EsYKBKFfPXqhcOhuIYqi3A-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=ypYZqoZTsptEoKYiFoPm/p19rfXtb3oU3pAWnCNe+WI=;
        b=i4gZlIq+ez6HmZMw5eYUcUU9R/B8MHCOgCfR+zSAO88/NyAzQza9s4CXDFdAUSbATa
         OzCql76Ui7ISdAW22xYALDt4j3Wjo7EqA7wj5Uz3BzByCfccAuzxdDkR7WzMG7+78Nf5
         IBJ6+5X2FteKPZEyaCpgnGZVwNRyv9DnZ1xOWbgXEMrXZiA4SGIAcW2oU3sV0j6ud9rn
         CLLj7o5p8GO4xdCOGoUswYJ3R6ex1E9nBi7b6YifaX3aCiHuk5IeZtikpAVFye/wQ8Ze
         b4TdwebtX3MRpr9ghoWn1b2iO03rIbEilyNGFdK9idvI/B1NYCtR+KXR8YzTeYk5ilb+
         LWVQ==
X-Gm-Message-State: ACrzQf0RmTicD7gqoXk8Qp78xaAmGTe2fMXZYPuxTYgSUkvgoOgKc4eF
	RUYF6Hd6KZcJKC0uENKGPRiqWd9o4ACqN9pPudacaPr/mfFwSqF7fBs8/XQBa8RFx+aTkz3pKuA
	4BahCayrg0IhMvqCpY0W1L5NUWmQ=
X-Received: by 2002:a05:600c:468e:b0:3c6:f510:735c with SMTP id p14-20020a05600c468e00b003c6f510735cmr7602948wmo.179.1667217577126;
        Mon, 31 Oct 2022 04:59:37 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6EBETLSD4MBJxdnzTxR3FGu4hBbX2SQFUCrJloOPK1q2LF0w1HzUkYOXWVOI9w84+cugepvA==
X-Received: by 2002:a05:600c:468e:b0:3c6:f510:735c with SMTP id p14-20020a05600c468e00b003c6f510735cmr7602924wmo.179.1667217576945;
        Mon, 31 Oct 2022 04:59:36 -0700 (PDT)
Message-ID: <ae69e0c5-05ee-f0ef-a333-53bbaff5c3e8@redhat.com>
Date: Mon, 31 Oct 2022 12:59:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 02/21] drm/mcde: Don't set struct drm_driver.lastclose
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-3-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-3-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.lastclose. It's used to restore the
> fbdev console. But as mcde uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See
> the call to drm_client_dev_restore() in drm_lastclose().
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432773.685645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQY-0007lt-J0; Mon, 31 Oct 2022 14:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432773.685645; Mon, 31 Oct 2022 14:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQY-0007k6-Cr; Mon, 31 Oct 2022 14:06:10 +0000
Received: by outflank-mailman (input) for mailman id 432773;
 Mon, 31 Oct 2022 12:08:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTaZ-0005Dc-GP
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:08:23 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b68c087b-5914-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:08:22 +0100 (CET)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-222-1Jzp8XYrMiqLEg4pn2ZSXg-1; Mon, 31 Oct 2022 08:08:19 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 l1-20020a7bc341000000b003bfe1273d6cso2534925wmj.4
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:08:19 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 bn26-20020a056000061a00b0022cd0c8c696sm6948033wrb.103.2022.10.31.05.08.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:08:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b68c087b-5914-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=;
	b=HVwgxIFnTQWShJIbAp+p3yMHeOQrB6J5obh03OwUqlJlXbm90w49w/nPJiu98HKGScM9Uj
	vcR2K1W6wwdh1fa05SHdk+3fuL31eun9CsHTnQBBPzXgM2GVsUWvjC59Qd/0aT4EbN9Vql
	WRS4q8gCbvbwjjBXqhS0GpswFgCgaLQ=
X-MC-Unique: 1Jzp8XYrMiqLEg4pn2ZSXg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=UzviKTRQBMSKwIl6kvNWZgMaFQwic4ec30sKv7m652k=;
        b=5IzmLwy4KUG3NsyiHeRuGK9sPwZZHjVCgbe2MZhk7VB9yMMjyhqtK0MkAqEtd4AmCg
         vGAWlJ3YIxJYqr7g6Qho5GUawO7gCLUO+CSFXxOoXaAyyeF1M1bBuJn6WAchMjV0hDC6
         QhqiirdnCIOvzK8B4BpD99VIahkkrRXJ9ABHlHZ0LgPUsC5wwqn/TmhnLnGopsGvzOMj
         cIJ0lfNhuYJKp/rBh5KXVufkQruhXIX92jtCu8BGGNvuzYDfgU6oxxa89DpZyeptR2Ni
         Buzs3LwBJeN2KDoHyLPytu28skqXCgEBUAyCE9iK6o/Qb8njVApc0CfmU2apTEojfFVi
         3jtg==
X-Gm-Message-State: ACrzQf3Tqro5srQZNyh2V2Gih2uZW47wmYrBny25Wfq8QHXZ4rJgrQv3
	R3gPqOiTjOnc2kShT95kSqrtG1hP3SahjE8nLmTYbIjAp9eJWNDnGc7DdivaQItCyNAAL1n5a+v
	jF7C9z01m+HDcbUsgabZChQHqhyE=
X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691181wry.248.1667218098865;
        Mon, 31 Oct 2022 05:08:18 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6Xfc/ao13H30KX93ABjLq4iUJ6oQF+1EOXF8gvz+3LvWSBMjjIijdjEWsEsBBK0GpYNHL8UA==
X-Received: by 2002:a05:6000:15cd:b0:236:9701:7939 with SMTP id y13-20020a05600015cd00b0023697017939mr7691171wry.248.1667218098682;
        Mon, 31 Oct 2022 05:08:18 -0700 (PDT)
Message-ID: <fd53a4f9-34a8-f5f3-1b1f-baf4a456bcc9@redhat.com>
Date: Mon, 31 Oct 2022 13:08:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct
 drm_driver.output_poll_changed
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-5-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.output_poll_changed. It's used to restore
> the fbdev console. But as amdgpu uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See the
> functions drm_kms_helper_hotplug_event() and
> drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.
> 
> v2:
> 	* fix commit description (Christian)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Do you think that the fbdev helpers kernel doc has to be updated to mention
that drm_fb_helper_lastclose() and drm_fb_helper_output_poll_changed() are
not needed when generic fbdev emulation is used? Because by reading that is
not clear that's the case:

https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_fb_helper.c#L86

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432770.685641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQY-0007gv-Cq; Mon, 31 Oct 2022 14:06:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432770.685641; Mon, 31 Oct 2022 14:06:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQY-0007fG-12; Mon, 31 Oct 2022 14:06:10 +0000
Received: by outflank-mailman (input) for mailman id 432770;
 Mon, 31 Oct 2022 12:00:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTSw-0004uN-1z
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:00:30 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9b69db35-5913-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:00:27 +0100 (CET)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-271-j1Bo1sHwO5el3ApQgPJrrg-1; Mon, 31 Oct 2022 08:00:25 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 i7-20020a1c3b07000000b003c5e6b44ebaso3362181wma.9
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:00:24 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 bi19-20020a05600c3d9300b003c6c1686b10sm5388458wmb.7.2022.10.31.05.00.21
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:00:23 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b69db35-5913-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667217626;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HRPxwW2zKPepuA8PR9mUAwCAVRj8pp1PiT5CedYG760=;
	b=A81TQWzRANSt9UBXkN6GWZECwAj2+GPLXn6gdwd5irFl8gEo3FGTWQ0tGgzwhMkxQ2lwHk
	9EJ9dIXq62KH3h5oOwgKZ83yltwQfjYnOnaHOR1ePZXUP1C+hxUKtaADOJgdSnV4tlZcO1
	vZWbNYGFj0c0lpX1hv6hD75EP2wEoSM=
X-MC-Unique: j1Bo1sHwO5el3ApQgPJrrg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=HRPxwW2zKPepuA8PR9mUAwCAVRj8pp1PiT5CedYG760=;
        b=sb1GQb5L2ioWMZ2Qz1ENCpy7EU6IdxqGoWKRiEi7UELaOD07FzcLDQZLz1owgftgCv
         O6bNUF+gsxPxQMr/L/D/JFaeTWP6kjKTBjRBk0JnpYq1Q+81IGQaaJ6aOV3ueeVhEAjy
         dJGJvzAY6TTnQ20D0M0KXF6iysWJ1XrXlHdszkCVhUm8YunvJA/DRR23qXIwXTEmRO8y
         1t8p8QTzTO/N3UdhG24uswmvXgOTq2T+3FOOyjZHS65r9ToEwacZDxZcCpelQ2ezdL2B
         ahh4yB44RWKAqwJ89UmkuxCTHCQ5DmTaV7QQWnvh2FvIWGmfgPvw6C/Hcplm5dkyka5T
         PoJw==
X-Gm-Message-State: ACrzQf12nXGgWoG8OUu5cx7/5lBTRCr32kJ0PWo6y+m1G/8+KGtT92SU
	wAptUIYFStmxUP3prxmARqNjNtI3k5NuD2NA2WpNsp+Nkui5Bm05CUNICqIxrd4RCptVrkazX9a
	JS68zbYgVu/ORmmVyRMeQZ6ymjTg=
X-Received: by 2002:a5d:560e:0:b0:236:c325:4858 with SMTP id l14-20020a5d560e000000b00236c3254858mr4606545wrv.259.1667217623893;
        Mon, 31 Oct 2022 05:00:23 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7SGo+SId6me5X0r4rljOgpSC8TPNcKC+21wfNb2F4dclcZs6G1cIUREq2tk/ot5/dgyLJVEQ==
X-Received: by 2002:a5d:560e:0:b0:236:c325:4858 with SMTP id l14-20020a5d560e000000b00236c3254858mr4606520wrv.259.1667217623655;
        Mon, 31 Oct 2022 05:00:23 -0700 (PDT)
Message-ID: <2e2e3915-a7b2-d030-2ffd-117b12deedb2@redhat.com>
Date: Mon, 31 Oct 2022 13:00:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 03/21] drm/vboxvideo: Don't set struct
 drm_driver.lastclose
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-4-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-4-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.lastclose. It's used to restore the
> fbdev console. But as vboxvideo uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See
> the call to drm_client_dev_restore() in drm_lastclose().
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432775.685654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQZ-0007xG-5V; Mon, 31 Oct 2022 14:06:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432775.685654; Mon, 31 Oct 2022 14:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQY-0007vQ-T7; Mon, 31 Oct 2022 14:06:10 +0000
Received: by outflank-mailman (input) for mailman id 432775;
 Mon, 31 Oct 2022 12:13:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTfn-00064X-9N
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:13:47 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77a02b38-5915-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:13:46 +0100 (CET)
Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com
 [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-19-ty7L1GAdO6mkRXNXxC619Q-1; Mon, 31 Oct 2022 08:13:42 -0400
Received: by mail-wm1-f69.google.com with SMTP id
 p14-20020a05600c204e00b003cf4cce4da5so2548430wmg.0
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:13:41 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 az29-20020a05600c601d00b003cdf141f363sm7207444wmb.11.2022.10.31.05.13.38
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:13:40 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77a02b38-5915-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218425;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2H8Fq04+XbNugdc6Ty/YSDXQIs5WWNt9cW9u1MIkjOA=;
	b=Fyinmr+Q0n1IVSrn1/exfVMuahFI1GnKDLxSO9gZGMd5IxN240qNx53yJ9b8Xz6pqMid2b
	CEI3LOrG0zsDnl738U59edgRRo+QqiKnBUmP449C4+uKDWKqe0ZDPz5nEbUAotsDijRKNC
	OqQAZMk1+J6bQq5CGLVsSuBJCkLyXMI=
X-MC-Unique: ty7L1GAdO6mkRXNXxC619Q-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=2H8Fq04+XbNugdc6Ty/YSDXQIs5WWNt9cW9u1MIkjOA=;
        b=7JOvEnKaBl49ljtmZsFoPXkhtRGzKBRFKPSB9jL1pJpgtmiEE+4XOZmJqRcrUsB3fY
         Vf49lISQcgR/rprKN1NExcgnqhgHa81EFDkVeIldJ+HkmsopnSgDjetusDiKEsiSWmTM
         Zn7EYRlBriEsepLmYycfUqBjg0QtsCuKFkhBbbCaONXoKtKWv9xZgJfhzFf9PEf/j9xL
         EaVZfxW9OB3VAkDCNB+pve11E3FaQW3KtfJ6ID3fr3iv70twy1dFnU7jHqLIYCqoQxd3
         DEUqDIXQVvg2ytQYlzjIVL85uxJFLqojDTOxQcyKiS7s3Pmn5k/x5CjQe35aSxUjE1rx
         OaMA==
X-Gm-Message-State: ACrzQf2glnlK1fC0JL/lSRTDyS+rnL0rOGv6mtq3c9XcE+IguCyKMj8v
	Zd1sI6tMhOFkEg6y4nL/SwSfe/sfmf31uBnFA6zZrvCVbJhwCY5it+YrqNmTB36nhKw265UaiSq
	JBTOyGt80b74Nvp5XFCTMnCn9CsM=
X-Received: by 2002:a5d:64cd:0:b0:236:6d1c:c1a2 with SMTP id f13-20020a5d64cd000000b002366d1cc1a2mr8196703wri.360.1667218420935;
        Mon, 31 Oct 2022 05:13:40 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6+QX10ZDmjvc1IfL0XXmvBimtEQHEjFBrrHb50hNQes1zzurNnpW//og1SN1o9c/o5tX548g==
X-Received: by 2002:a5d:64cd:0:b0:236:6d1c:c1a2 with SMTP id f13-20020a5d64cd000000b002366d1cc1a2mr8196664wri.360.1667218420692;
        Mon, 31 Oct 2022 05:13:40 -0700 (PDT)
Message-ID: <231be619-96b7-b725-0735-0275e07477d8@redhat.com>
Date: Mon, 31 Oct 2022 13:13:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 04/21] drm/amdgpu: Don't set struct
 drm_driver.output_poll_changed
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-5-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-5-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.output_poll_changed. It's used to restore
> the fbdev console. But as amdgpu uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See the
> functions drm_kms_helper_hotplug_event() and
> drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.
> 
> v2:
> 	* fix commit description (Christian)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432787.685662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQa-00086B-0B; Mon, 31 Oct 2022 14:06:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432787.685662; Mon, 31 Oct 2022 14:06:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQZ-00083K-EI; Mon, 31 Oct 2022 14:06:11 +0000
Received: by outflank-mailman (input) for mailman id 432787;
 Mon, 31 Oct 2022 12:16:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTiF-0007Kt-QE
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:16:19 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d28150b5-5915-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:16:18 +0100 (CET)
Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com
 [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-618-FPQfGad1PaK6NQ_jQidDJg-1; Mon, 31 Oct 2022 08:16:16 -0400
Received: by mail-wm1-f69.google.com with SMTP id
 v188-20020a1cacc5000000b003cf76c4ae66so437744wme.7
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:16:16 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 d2-20020a05600c34c200b003b3365b38f9sm7118010wmq.10.2022.10.31.05.16.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:16:14 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d28150b5-5915-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218577;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WlC4H0gmckJZ8E/tDGtmzwjQN3hfnWY+OkvhUHpUiTc=;
	b=SzxIp3KH1MJqCBUG1OdZLDtnmNr9ze9qCNca0D8W7lQRRd7ZxIpp/bc+uAAaPM2RO0+6dP
	gKIwcXSPzSp6YmttVdvmmB32i8J1A4MuFA+0Vaz6QSGVxi4OOhikTdPAddVDg4EK0Msryg
	sHj/vUsp15Qd6j9vD3TLgzuO/uTAz80=
X-MC-Unique: FPQfGad1PaK6NQ_jQidDJg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=WlC4H0gmckJZ8E/tDGtmzwjQN3hfnWY+OkvhUHpUiTc=;
        b=icSXDnJLIgbZbmhwQWbeROSQlX1LPC1hmgmYRvbWItRpPVF5dIx0EveHo/yjJaVamg
         QkgfXaTr8VROP00XQxSAtOplDbkXE/lNHhU+ZF+vjuA6rV3DUZFM38WM01gXJnUIvYGO
         XBCKbEmBF59aZ0b+uHNLetRk8wafB3zkH1B5XnFf43aCGD21vCKaNfSdazh5NOl17vJJ
         DA/TYVYjBnOMv0C4JIoHzvJpXcDoz3P0atApCSXMMGbRQwVcvc4Kl2xivngcFVJ6/46W
         d44ccFSPzF7JQl5kumlZ0PIF2RED0ZXzeE/gAWa55tTIc9oSEAm6UKUEAKHvAGH/hdzx
         tx+A==
X-Gm-Message-State: ACrzQf00+d8KplXlWGoP6s+hZEFmf39/JG5wuQeImV0SdphFN3+9i/Rm
	dLPCJUZiG2Zc69UewIeYrmhm9J+QE1DrY+1VWvPEd8XxYxBs3VB6A6a2pIbGxtsQzveQzJuMq+N
	6s01ZUsppbT7RF0oFkLnfgwmyyLY=
X-Received: by 2002:a05:600c:1c0d:b0:3cf:5fd2:1fd1 with SMTP id j13-20020a05600c1c0d00b003cf5fd21fd1mr10268837wms.8.1667218575303;
        Mon, 31 Oct 2022 05:16:15 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7vtgF5OcVzyyhJbAVQv0UtjhNq0IgAK2jPkGsnoYeZKQ/ZE7IsMKsB/emo+io4u+dLlmSgSQ==
X-Received: by 2002:a05:600c:1c0d:b0:3cf:5fd2:1fd1 with SMTP id j13-20020a05600c1c0d00b003cf5fd21fd1mr10268814wms.8.1667218575124;
        Mon, 31 Oct 2022 05:16:15 -0700 (PDT)
Message-ID: <8423bcd3-84f6-b6c9-914a-c70166e20482@redhat.com>
Date: Mon, 31 Oct 2022 13:16:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 05/21] drm/imx/dcss: Don't set struct
 drm_driver.output_poll_changed
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-6-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-6-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.output_poll_changed. It's used to restore
> the fbdev console. But as DCSS uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See the
> functions drm_kms_helper_hotplug_event() and
> drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.
> 
> v2:
> 	* fix commit description (Christian)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432789.685675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQa-0008Me-To; Mon, 31 Oct 2022 14:06:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432789.685675; Mon, 31 Oct 2022 14:06:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQa-0008Jv-BV; Mon, 31 Oct 2022 14:06:12 +0000
Received: by outflank-mailman (input) for mailman id 432789;
 Mon, 31 Oct 2022 12:17:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTj8-0007OL-AV
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:17:14 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2e6cf22-5915-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 13:17:13 +0100 (CET)
Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com
 [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-208-bPSv-ps6OVWKfAPp3a8btQ-1; Mon, 31 Oct 2022 08:17:10 -0400
Received: by mail-wm1-f72.google.com with SMTP id
 v23-20020a1cf717000000b003bff630f31aso2540650wmh.5
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:17:10 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 cc6-20020a5d5c06000000b002364835caacsm7133274wrb.112.2022.10.31.05.17.07
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:17:08 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2e6cf22-5915-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218632;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z23uByta1RO7RusYzzGag4IvKSimSY8jEax7dgozF+A=;
	b=h2tegKMiWIGtbIk1/P01ccdMrYTydj+qUma62OUP27owChMflrAYUaX0UCIMtyAGOulfVl
	MbG9Bqha3GFz3BhqgEIiDvfqNNFUB99VrPNnql90ki0vhdjYxOQw015F+jEPQkb695ipFk
	cKkWIllZzxiR654pwom76ElSOogoI+U=
X-MC-Unique: bPSv-ps6OVWKfAPp3a8btQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Z23uByta1RO7RusYzzGag4IvKSimSY8jEax7dgozF+A=;
        b=TNYF9QIL7EwGV9nqqCEg+T46u8YJxsOnIYBOorNOkL1Ie9ZLbhHv4muKmXRROmzP4x
         2SrparrSicyN0++pUNm+KQ7bVDTP0CZMSp8qcnX3jgfjJMEmQLMrrKapMdtdLNPF1x+p
         cnTq2e3gYEQgOtETscK1FdzyUt+mOfWvyKx1E12ny0+Jg/ehyrGxDv0zX+foplZ8Ww6i
         EMX2qkE3Z8O4TWMTYDGSOxieQtkIf8UYrQp/x18v9qermvOIB8GruZ8MSVDPHasspfor
         0XXWcYenaq7UAIe2HcpECcxXabS9eY3BjdkVtp4rkYqyarvAWsPreXYbW5cs0aoXG752
         yDPg==
X-Gm-Message-State: ACrzQf0X5+d9qCM3BHsaQh2PZpR/0TmNpZPaI8LCFAcAIua+T8tzSSdk
	T93WvRhxjbPwKAjYdaeNo9kXYfDxAw76bR92KBvjZc8KCFtJ5UVjv5jt3s5bP5mQNCcG9i5c/Ry
	f2l9VZDMfuZOY1gz0CIdBfUmi+O8=
X-Received: by 2002:a5d:6da2:0:b0:236:7916:a9b2 with SMTP id u2-20020a5d6da2000000b002367916a9b2mr7921505wrs.393.1667218629377;
        Mon, 31 Oct 2022 05:17:09 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM67BGVEVFx5kckaS0oDiow+E3wYJXdivRHIvOOROl9hHnAsaKyVcMk8ZYE1a2HK4LSTJkXvEg==
X-Received: by 2002:a5d:6da2:0:b0:236:7916:a9b2 with SMTP id u2-20020a5d6da2000000b002367916a9b2mr7921473wrs.393.1667218629159;
        Mon, 31 Oct 2022 05:17:09 -0700 (PDT)
Message-ID: <efe0c7bd-0b14-b829-cc41-fda316952a51@redhat.com>
Date: Mon, 31 Oct 2022 13:17:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 06/21] drm/ingenic: Don't set struct
 drm_driver.output_poll_changed
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-7-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-7-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.output_poll_changed. It's used to restore
> the fbdev console. But as ingenic uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See the
> functions drm_kms_helper_hotplug_event() and
> drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.
> 
> v2:
> 	* fix commit description (Christian, Sergey)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432791.685681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQb-0008WQ-7Z; Mon, 31 Oct 2022 14:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432791.685681; Mon, 31 Oct 2022 14:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQa-0008Rf-Rd; Mon, 31 Oct 2022 14:06:12 +0000
Received: by outflank-mailman (input) for mailman id 432791;
 Mon, 31 Oct 2022 12:18:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTke-0007RU-0b
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:18:48 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2acb9ca5-5916-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 13:18:47 +0100 (CET)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-404-ruFN1sSuO0mNS6TCSSQbHw-1; Mon, 31 Oct 2022 08:18:44 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 bg25-20020a05600c3c9900b003cf3ed7e27bso5229392wmb.4
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:18:44 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 l7-20020a05600c1d0700b003b505d26776sm1928473wms.5.2022.10.31.05.18.41
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:18:42 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2acb9ca5-5916-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218725;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Y9o0NAEqIzltln/rJd0nXK88QZ5o4OnoHZo920P8Bvg=;
	b=gDJmJCaUqJ7Fm6o9o5aunIA5xfKid9ZLcI2R1r8DajuGUsufutJXLsks1ABDt97IrmjQXr
	rFHPAXjVvH2zt4OLa6y1XAHhEZomEUALKaONYArkpyjqGt47uZ3902Kpa/xZESRuV7066X
	8VkTIYOU1i6VKauEjV1TQZqcTnqptow=
X-MC-Unique: ruFN1sSuO0mNS6TCSSQbHw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:content-language
         :references:cc:to:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Y9o0NAEqIzltln/rJd0nXK88QZ5o4OnoHZo920P8Bvg=;
        b=iV3KFnER0anT3ncX1m7JX44owIYmTBt20fw9lnuDpXA+qalRSMJUHNkwKmSs/Q9oFS
         8pPfEAmzSqOkUokrJxG0PmcGGIqth7A+yfnUFDX/8ZCVyR5rf9K6NkrM35uRa1PJXl4Y
         x6/u5IzsYvvqK1i75Byh7XOpVeu5L002hCSoyMVd0SjTW7RyXXA1evk+jeYVnzZYVtfz
         qNLUt7gxqAFIkLiIQkmOR43L+ad+KLNM6Or2Qqgz6fwR9+wGoiiC2aeQDhRbRkAXJoQ0
         8vwZJRxwM8HgtfuzS2MXk7G/3Mt12Nkul5RUEU8GbM9hBJJnc/DR0UjuIHOXOyER0IGp
         ulfg==
X-Gm-Message-State: ACrzQf1nrp2U2RXfI72S0EL1qENkWtN/55/6rbmZAm4jO7cY7qf2+trq
	ij5QkzGiePy/u0olzo8Fnl285PTYrMBkexAAvE6ajBAIqHyOIvdTXseAkrxN3mRizNfrsdPnXAy
	xOwZvHHmulwpRWkw25LHNI59PIW0=
X-Received: by 2002:a05:600c:1913:b0:3c7:32c8:20f1 with SMTP id j19-20020a05600c191300b003c732c820f1mr18174570wmq.81.1667218723533;
        Mon, 31 Oct 2022 05:18:43 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7l/GcAhTFdfukiyp7nV9yfjX7i/zfBGid5JfBMyP3xXFRWK8fegD9382/Cb8rQ8SeG7Fkrtw==
X-Received: by 2002:a05:600c:1913:b0:3c7:32c8:20f1 with SMTP id j19-20020a05600c191300b003c732c820f1mr18174541wmq.81.1667218723353;
        Mon, 31 Oct 2022 05:18:43 -0700 (PDT)
Message-ID: <05a2ad4a-b053-ba98-2547-520ab51d3e77@redhat.com>
Date: Mon, 31 Oct 2022 13:18:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 07/21] drm/logicvc: Don't set struct
 drm_driver.output_poll_changed
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-8-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-8-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.output_poll_changed. It's used to restore
> the fbdev console. But as logicvc uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See the
> functions drm_kms_helper_hotplug_event() and
> drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.
> 
> v2:
> 	* fix commit description (Christian)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432793.685690 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQb-0000Ku-Vl; Mon, 31 Oct 2022 14:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432793.685690; Mon, 31 Oct 2022 14:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQb-0000GR-Gp; Mon, 31 Oct 2022 14:06:13 +0000
Received: by outflank-mailman (input) for mailman id 432793;
 Mon, 31 Oct 2022 12:19:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTl7-0007S3-Tv
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:19:17 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3cc5fa9f-5916-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:19:17 +0100 (CET)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-660-03E0EI0yMpadCH_N4Yp3mw-1; Mon, 31 Oct 2022 08:19:14 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 p14-20020a05600c204e00b003cf4cce4da5so2553484wmg.0
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:19:14 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 x11-20020adff0cb000000b0023660f6cecfsm7060089wro.80.2022.10.31.05.19.12
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:19:13 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3cc5fa9f-5916-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218756;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=riNVOBu8e2pIZERXBmAvmwAOPdhd6MsYxn78jTBB4dE=;
	b=OBolPdy1AF2o/wp/D6pjRilLNmLCu644iVdp5xYog2AGWhwfTXstwshmx++UNF4iRTd/IR
	jS9w5k7O4w9vyLefikbi3kfZncrS0YuBJ6WI0VA/zfuZcxwuMYDzb81+LuY9T31pd3vlIg
	mCYLNeoX02c0cqrZteXZnpM1aBeklys=
X-MC-Unique: 03E0EI0yMpadCH_N4Yp3mw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=riNVOBu8e2pIZERXBmAvmwAOPdhd6MsYxn78jTBB4dE=;
        b=sjXYI7uz8w5jj73qIGRqKiWi2LOvMmx91y2ceH3NAat2dglV+A8gLaw0nIDgEqf7lb
         IRfyrmihsr7KwWIY9V2S8WREY7AZV9S560FflZnY9y84u8OP5sbgk9GhfskDYiWmFvHw
         D8U0+5Nm0ltjLv/Y7TxLx28j4oW8XTC3ka32NjybtG9by4udwNlTMPAJRG5fTv1pq9QC
         Fd+o2dmv4GoB/dd+aUw8QJ+itYhBO2+Qjii7XysHDdPvjdfowTblrl6QeoAq/kPdNU4A
         27aLk8U3oy74kkYDBncAXNZ9IljDXWwM7n6Q/Ie2BZLwDJUUVzMp+O9YFiuKm8krTbLn
         YsYA==
X-Gm-Message-State: ACrzQf3auHYo0CpdzqwIxG+IBj2R3/8H/yjk+mumabA/ECz7b5DVXdc6
	LQlQp56lyGj2TE7XD7+0beKE34vlWEmXgP15Fw3ccO/19NLboE4LM6SgNlooDnQm/Xqbg2KKuXY
	VfNrZlSZQwYnG01RV1jOjQn5qGPg=
X-Received: by 2002:a1c:7405:0:b0:3cf:55ea:6520 with SMTP id p5-20020a1c7405000000b003cf55ea6520mr7948727wmc.46.1667218753687;
        Mon, 31 Oct 2022 05:19:13 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4oPDcyHgSUP9i1GOihR+fx3MXqkZeIX2xB6yE7P9f9dsxB6V14E0IWVQPIhFCjpfp7XUuGLg==
X-Received: by 2002:a1c:7405:0:b0:3cf:55ea:6520 with SMTP id p5-20020a1c7405000000b003cf55ea6520mr7948695wmc.46.1667218753455;
        Mon, 31 Oct 2022 05:19:13 -0700 (PDT)
Message-ID: <01f85874-6beb-c325-8b94-7a7aeec30d5a@redhat.com>
Date: Mon, 31 Oct 2022 13:19:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 08/21] drm/rockchip: Don't set struct
 drm_driver.output_poll_changed
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-9-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-9-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Don't set struct drm_driver.output_poll_changed. It's used to restore
> the fbdev console. But as rockchip uses generic fbdev emulation, the
> console is being restored by the DRM client helpers already. See the
> functions drm_kms_helper_hotplug_event() and
> drm_kms_helper_connector_hotplug_event() in drm_probe_helper.c.
> 
> v2:
> 	* fix commit description (Christian)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:15 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432795.685703 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQd-0000gG-2K; Mon, 31 Oct 2022 14:06:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432795.685703; Mon, 31 Oct 2022 14:06:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQc-0000cY-Id; Mon, 31 Oct 2022 14:06:14 +0000
Received: by outflank-mailman (input) for mailman id 432795;
 Mon, 31 Oct 2022 12:21:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTng-0008GI-El
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:21:56 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9b46e161-5916-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:21:55 +0100 (CET)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-376-kJGwxApwNfygiW1zysZOIQ-1; Mon, 31 Oct 2022 08:21:51 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 bg25-20020a05600c3c9900b003cf3ed7e27bso5232477wmb.4
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:21:51 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 i4-20020a05600c354400b003cf4c1e211fsm7421692wmq.38.2022.10.31.05.21.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:21:49 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b46e161-5916-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218914;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Sz8PAZx0cLc5RAaRO0sQR4MZQyCy7VtrjJT7yq4jHuw=;
	b=ZzE8H/e1Rtq/tBnevIYxkAHR3g+VsdKbJ9XOh7IqG07hsVf+2z/hN41aI5SPH//8iwPFLh
	HZjmkzfj/I4VS1ru0c+CdMfv6bqNL+kNIftfkOXDOscOmjgaIVP3u79/sa3JlXanOvLaCJ
	VcRwmm8yg81c5Cg1mXmPWMskWk5qk+o=
X-MC-Unique: kJGwxApwNfygiW1zysZOIQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=Sz8PAZx0cLc5RAaRO0sQR4MZQyCy7VtrjJT7yq4jHuw=;
        b=Vtr0jDu6IVrlYUQGzb4oDICWcN1HIphhvpfMxDxCCdywajAnpcZ3o/wQtx0oHcGJAX
         h7REACeR/JmqlMCJbSLf03qk4hmTzbMVUpa8vcxf9pXOE+1d0enXdJTpxBwlTtn0Ofuy
         yFcSyX5s86Rx1w2fpATw0WSAmTfH9PyGHO9ajkI2sH8rWNMR8i9fiGsFcosQ+/Cj9cUy
         0w06AvsKlaG3c7qq67pw3yWzcw4oK0QI0q3xbVSTMyras1rVI/2D6I5W8zYxzEXT7Fhe
         TnC+d4MpyE3OSw8qbtREoj8DkZLcHDVpReFPF9k2U/4GXW2o8jG24GRCXj2EtPsblFxw
         FAxg==
X-Gm-Message-State: ACrzQf3Ij9xF4/EYjlh0N3DSsqu96Z9aQ3II1Rj+uV7V6XVcgqEfsBGV
	xb2Hm+AVTBzPPCHQ4uCOwv/3cOhumS9IIkArL3r8+TRkBRlRzHhUYVWTXtCwGGsC2i8cW6xjpKD
	teJnhmti2Dqg+8jVudJJC0gy/H1I=
X-Received: by 2002:a05:600c:3c8e:b0:3b4:d224:ae27 with SMTP id bg14-20020a05600c3c8e00b003b4d224ae27mr7936000wmb.187.1667218910346;
        Mon, 31 Oct 2022 05:21:50 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7kQh5/EvsJvI9K3W2EFLXezwgTMZr8BgFr4Dt+IxgUiTtboeKKAu1FK4Es/7ETyez8XSTV6g==
X-Received: by 2002:a05:600c:3c8e:b0:3b4:d224:ae27 with SMTP id bg14-20020a05600c3c8e00b003b4d224ae27mr7935971wmb.187.1667218910155;
        Mon, 31 Oct 2022 05:21:50 -0700 (PDT)
Message-ID: <e9192382-f04c-4ebd-ca1c-b2fceaa29f86@redhat.com>
Date: Mon, 31 Oct 2022 13:21:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 09/21] drm/panel-ili9341: Include <linux/backlight.h>
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-10-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-10-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Include <linux/backlight.h> for devm_of_find_backlight().
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432797.685714 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQd-0000qX-SS; Mon, 31 Oct 2022 14:06:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432797.685714; Mon, 31 Oct 2022 14:06:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQd-0000mG-AJ; Mon, 31 Oct 2022 14:06:15 +0000
Received: by outflank-mailman (input) for mailman id 432797;
 Mon, 31 Oct 2022 12:22:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opToF-0008IQ-Cg
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:22:31 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b014f1d8-5916-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:22:30 +0100 (CET)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-360-xBLSR-70PqKbRnsxpUxLEw-1; Mon, 31 Oct 2022 08:22:28 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 x10-20020a05600c420a00b003cf4dbff2e4so5738452wmh.8
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:22:27 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 f16-20020a05600c4e9000b003cf568a736csm5157904wmq.20.2022.10.31.05.22.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:22:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b014f1d8-5916-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667218949;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xVJodACOlUyVw6jJB0o/QffeIPQi24/sF6MmyMfBvgg=;
	b=AD3YqiH6p2ttr44BpYQxrxqMRTPybN7R/b6HdOO7WVOug/Q1OjwZu85lR+0dhw9vB0ZNLp
	v7HafG6DmjwvnlLt3brJJxuyUzEl6cdvpUV5fqKr5ZAt+IBZq1/R/Xx18Uo02XSc4VOIrG
	Mu6cRHxrbzkM8L0aY3CeC+LMDI6BwZY=
X-MC-Unique: xBLSR-70PqKbRnsxpUxLEw-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=xVJodACOlUyVw6jJB0o/QffeIPQi24/sF6MmyMfBvgg=;
        b=UedgasGjDkanSGlf5AL4zp0uksPkbzE+WElO3vvCFgFX2oySevT95R5FRQChn3K2r7
         rnys761UWskDS9uw1qVKKLa1rRVINGjfEVQg/ft+/oNEhgSEWNZD3EmnQ2hY4osWgfjl
         XcrmwsVw8PoDyKIYHLSFExq+hX+8jQKu6duomCQGcgDA4aYz+S55+io5YROh2CZ2Gp+R
         ZworiK8c1TgUmEfQRTM3TkcUtZ+cZ1bwiRP5viH4S0olmfXZa3q4LGHOHZgyo+Anz/c/
         zmcNPIB9SEc+rO8JuN5z7zYVCbX/r+5bJJTNkIXh3/T0VVdoziTl3WoKd5Ab/AsnELT5
         PxCQ==
X-Gm-Message-State: ACrzQf3pEcp81zozY0SJZBOQryHP+l7WdygPtxevMkSHXH0ltDHKXfgU
	+I9+vsr9zoJzVorFLIzNq3GC85U6eBm/tIllyZ9Jlwfn8uJ+0c1ytvYkRnWKhrK5pBDI8T5E15g
	i8mY28WMkEfaX/iJ2ql0azqWaHC8=
X-Received: by 2002:a05:600c:46ce:b0:3c6:f274:33b2 with SMTP id q14-20020a05600c46ce00b003c6f27433b2mr7860201wmo.27.1667218947045;
        Mon, 31 Oct 2022 05:22:27 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4zVdpLNc1mYDp74XAWVtjpPddzcwMDONTh4D+G0X15w3fKqsphKr/pP9hn5PrcknLAkhJ5Mg==
X-Received: by 2002:a05:600c:46ce:b0:3c6:f274:33b2 with SMTP id q14-20020a05600c46ce00b003c6f27433b2mr7860165wmo.27.1667218946788;
        Mon, 31 Oct 2022 05:22:26 -0700 (PDT)
Message-ID: <ea046b06-fb0e-b7c2-8f70-b299401d9adf@redhat.com>
Date: Mon, 31 Oct 2022 13:22:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 10/21] drm/tve200: Include <linux/of.h>
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-11-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-11-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Include <linux/of.h> for of_match_ptr().
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432800.685719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQe-00017M-Jd; Mon, 31 Oct 2022 14:06:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432800.685719; Mon, 31 Oct 2022 14:06:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQe-00011l-At; Mon, 31 Oct 2022 14:06:16 +0000
Received: by outflank-mailman (input) for mailman id 432800;
 Mon, 31 Oct 2022 12:23:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTp7-0008Lw-75
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:23:25 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d02cab61-5916-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:23:24 +0100 (CET)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-38-4-D7V0N8Of2X3AI86-dHwA-1; Mon, 31 Oct 2022 08:23:19 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 r6-20020a1c4406000000b003cf4d3b6644so1056185wma.6
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:23:19 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 ci8-20020a5d5d88000000b0023662245d3csm7011927wrb.95.2022.10.31.05.23.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:23:18 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d02cab61-5916-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667219003;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VQCx1YM0kmrgAAcvKhWafunY3KuhCAquKBUmZJVCfV8=;
	b=OXxETfR4g8DTtsYOgeAYKp+EQgjNGaqLLCMi4dhrYZ+lPfcfdS5h5O8mwAFhR877yun0Zf
	nn2XbQOGwj8SjrqEVIoXsAliYDbiWm27JjHNCKViA/plFCtoSisI7Dw8DPfoOt6SWLCrcj
	xhNghWqsLn4MotOmVecD81rNWnwv9F8=
X-MC-Unique: 4-D7V0N8Of2X3AI86-dHwA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=VQCx1YM0kmrgAAcvKhWafunY3KuhCAquKBUmZJVCfV8=;
        b=v6hcEhgPzw6uJEPtscv7l4FPt8LptZWomXClKWy5a/HQPRtZWjlMnIbXkvs022oklA
         mDhKm9YS2feVYdPSnixsCG3lcTgg4qlcfEiEw1Xz21L+qQquG9Iac1B/VOFbLN30UVex
         QKI0uFo5tGaBjTUUWCia3bLbn8ceyZASwDzl7w3gF3EIYP07VOGYLMFSHM8ctuImHa/L
         AKqBucgtLhsxNPFEnqqiy2W1W2kx8vivJ/P6dpzg2qs6QWMTMDByHL3pUgI/3SR4wRH5
         a6Dan8mzwS19qe+tCXgLQ/FaG8CbjK1lSnWEey9OwRpgv/NDZ7UZkm5nkl1HPVwlwlm2
         yyZg==
X-Gm-Message-State: ACrzQf2UuLWhU5g7fD2zWgbNMQLVtr1Nj7bUyIPAQIXEwBns4MWpL8A+
	DopR2hvjtOB48T2MrxYXv34QSI9nvgBKLBuYyr4GfP2X4ThZ7LE2Bc8SfLaaSKpqXaHlEiawzd0
	iTyZoNQXzn6pvUiW9zq99qYnqfwU=
X-Received: by 2002:adf:aa8d:0:b0:236:588f:71f with SMTP id h13-20020adfaa8d000000b00236588f071fmr7582892wrc.205.1667218998717;
        Mon, 31 Oct 2022 05:23:18 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM7e34dAcxvP3Vi0CwbwP1YeMi235O6q6VyKCYvEf93eDT38FEWiyAv5s+MTc8QNv7Bgz3ny/w==
X-Received: by 2002:adf:aa8d:0:b0:236:588f:71f with SMTP id h13-20020adfaa8d000000b00236588f071fmr7582855wrc.205.1667218998538;
        Mon, 31 Oct 2022 05:23:18 -0700 (PDT)
Message-ID: <63a804b4-ab2c-f5b7-73b5-edefdeff038e@redhat.com>
Date: Mon, 31 Oct 2022 13:23:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 11/21] drm/fb-helper: Cleanup include statements in
 header file
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-12-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-12-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Only include what we have to.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
Nice cleanup.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432815.685731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQg-0001Ra-0n; Mon, 31 Oct 2022 14:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432815.685731; Mon, 31 Oct 2022 14:06:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQf-0001Nr-Ff; Mon, 31 Oct 2022 14:06:17 +0000
Received: by outflank-mailman (input) for mailman id 432815;
 Mon, 31 Oct 2022 12:25:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTrA-00008h-1o
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:25:32 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b8e2598-5917-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 13:25:31 +0100 (CET)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-407-X4ZRPHrJPomG_BnRghdy8g-1; Mon, 31 Oct 2022 08:25:28 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 o18-20020a05600c4fd200b003c6ceb1339bso5594158wmq.1
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:25:28 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 m13-20020a05600c3b0d00b003bfaba19a8fsm7382582wms.35.2022.10.31.05.25.25
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:25:26 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b8e2598-5917-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667219129;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=G3lFqSUva8cf7eu6ekgojQtwZeR44+C1N0qDI7SjLRc=;
	b=FokqE+OawLhTjp7iVH+q3xV5qU+owxbjGYpygfYYbZilLPOWQS+Uk06vGCqWKa5Zg61x7L
	KCsidB+Mn9zm2uZnf0vRptgX9YPuFnLxLSh6Vf32dmbdyEZCSdg2Dup14duyFQymj0gh5B
	wqZkX+UaWVQlOkjtLaQulkamOJmfsPg=
X-MC-Unique: X4ZRPHrJPomG_BnRghdy8g-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=G3lFqSUva8cf7eu6ekgojQtwZeR44+C1N0qDI7SjLRc=;
        b=JDF5k8RVBRmxYJMgmns/Sc0Sqm2vkr7vcZB1tf1jbpy8kRDIsAznyBtWcefNy5vT29
         tUq/bbCMDAH8ySkImNOs/9r3geX3KVwAL4HTH1xT8bAOhmMVFGxkf14q2c+w1BGZr8i7
         g1Aa/NSfCI1mkVOAuYhx4jrrZJcBr/7RHPIUn3uhDh4iH0jwcqXDiHdwda04HjHRl2fE
         rSm3OxPrXifYlesuw9PYD5KVhjnDWiwIrij+a6Wmj66vI1g7ubinIMIrsJWli6K0CThI
         2xmfR3oZl9kYTgR1B5/8mRbtVD0z7X+DOTOe0ii7HtHpBNMRh+0ZOR/QoosMErFlSYdN
         XKLA==
X-Gm-Message-State: ACrzQf0j3jvOoOfebbhdlvmEEc+2Y+4ypGhnK4vskXaHOcjtYeVPgjdU
	rmq/8gzmqkCFDeeglTDQgWTw8H6h3m7Uhq2fPbKnJcnnIY7RRook55IltcLgSK9R4UynVLjb3xL
	zHtyGxoP/074wPCwpUniB58b+M6o=
X-Received: by 2002:a5d:498a:0:b0:236:58ef:6796 with SMTP id r10-20020a5d498a000000b0023658ef6796mr8133547wrq.399.1667219127469;
        Mon, 31 Oct 2022 05:25:27 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5OaQ4lCdeJx0P85vXeCC9ohI1f8Am/sl3oDUbbTCyW5S09EQhBnmsKMGoGzObNL20EAzLquw==
X-Received: by 2002:a5d:498a:0:b0:236:58ef:6796 with SMTP id r10-20020a5d498a000000b0023658ef6796mr8133518wrq.399.1667219127226;
        Mon, 31 Oct 2022 05:25:27 -0700 (PDT)
Message-ID: <53f341ad-4b72-5546-f752-ca705d62d63c@redhat.com>
Date: Mon, 31 Oct 2022 13:25:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 12/21] drm/fb_helper: Rename field fbdev to info in
 struct drm_fb_helper
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-13-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-13-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Rename struct drm_fb_helper.fbdev to info. The current name is
> misleading as it overlaps with generic fbdev naming conventions.
> Adapt to the usual naming in fbdev drivers by calling the field
> 'info'. No functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Agreed. I got confused by this naming in the past.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432817.685745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQh-0001nn-QW; Mon, 31 Oct 2022 14:06:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432817.685745; Mon, 31 Oct 2022 14:06:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQg-0001iu-M6; Mon, 31 Oct 2022 14:06:18 +0000
Received: by outflank-mailman (input) for mailman id 432817;
 Mon, 31 Oct 2022 12:26:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opTsT-0000AL-77
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 12:26:53 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4c13cf49-5917-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 13:26:52 +0100 (CET)
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-216-HHud18U6OQ6ULGY9R-pRWg-1; Mon, 31 Oct 2022 08:26:50 -0400
Received: by mail-wm1-f71.google.com with SMTP id
 v23-20020a1cf717000000b003bff630f31aso2548349wmh.5
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 05:26:49 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 q1-20020a1ce901000000b003b476cabf1csm4889352wmc.26.2022.10.31.05.26.47
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 05:26:48 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c13cf49-5917-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667219211;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/x9mAjb8LNYXXK+HVNHKFir+j3ZwIeSko/dKjp9YLmY=;
	b=AkQsTEKR1y9Fem7oTJ0E3dmo3tSyUuX34g7YcIEBfU/OXBSKRL/QiVX4biNYbj4VOFhn4W
	OCYtrt/Yx9m3DzmtnpA8LOacAJbORJ9GshIUa4dxrFXoxCS8kBtwGlqp6K0QEQc7VI3zeI
	6gqkmpi5G0SI5+1pENUOav6Ir2O/Na4=
X-MC-Unique: HHud18U6OQ6ULGY9R-pRWg-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=/x9mAjb8LNYXXK+HVNHKFir+j3ZwIeSko/dKjp9YLmY=;
        b=CsaSNJXEKMGLIdJiRW2e0cZj6hVepFmH0SapgVPq5pDAJHFp01wf6KffSc5/pqfMnU
         qaWd/tU8g0lF307ZRtvxz1zA2fcZWwzPKiz57JT1rKbKYSGXW99Ma3SbDNQjj8tF7923
         u9slgEdLb1XYzp6FjsVtPrXGzADk5KT9PYNIyYQZkDhIPRCukZ06eRy3oqk69z5ymFop
         ohauy0qxbqRDwgQ0H4cw3Z8Hu2rMzUfe5jrVCnN+HMrjhIP0P2jk79YS4PUqH9ULSE2x
         QdP9KokgKkUCuy3HWk2Mu5Q0wjWvPv0mm2QYgBSfMoLj21Y/jPdHeZlYqf/IqZY6njGE
         jgwA==
X-Gm-Message-State: ACrzQf33Y/tcqyfNHxBpUVdWPtI+nczGBdEZVhJz5FzadPj2vHMgCqzz
	rxhF0ciNNg6eG2kLnUag0jZ1uI5MAn7mqOe+J8TFi9rodHeRdzgb47ELUXtChcQ5LZNOcPS8Asp
	2hrNuRrNcCTRdrqhXGc7sujgXpgo=
X-Received: by 2002:a05:600c:4f10:b0:3c6:dcc6:51d7 with SMTP id l16-20020a05600c4f1000b003c6dcc651d7mr7887427wmq.91.1667219208978;
        Mon, 31 Oct 2022 05:26:48 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4eCY6FaPESRi0FBsuwSJAU0ypknopcItEy1BimghpIISJ8Db9xrgTY3spCPjOXKZ6zCgaGzA==
X-Received: by 2002:a05:600c:4f10:b0:3c6:dcc6:51d7 with SMTP id l16-20020a05600c4f1000b003c6dcc651d7mr7887399wmq.91.1667219208796;
        Mon, 31 Oct 2022 05:26:48 -0700 (PDT)
Message-ID: <0d2250e4-dc26-2fc9-e429-0d43ef280e5b@redhat.com>
Date: Mon, 31 Oct 2022 13:26:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi()
 to use _info postfix
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-14-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-14-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as
> part of unifying the naming within fbdev helpers. Adapt drivers. No
> functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:06:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:06:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.432867.685750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQi-00021T-7u; Mon, 31 Oct 2022 14:06:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 432867.685750; Mon, 31 Oct 2022 14:06:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVQh-0001wy-MD; Mon, 31 Oct 2022 14:06:19 +0000
Received: by outflank-mailman (input) for mailman id 432867;
 Mon, 31 Oct 2022 13:27:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=a9QX=3A=redhat.com=javierm@srs-se1.protection.inumbo.net>)
 id 1opUoz-0008GN-ET
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 13:27:21 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bdfb47ca-591f-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 14:27:19 +0100 (CET)
Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com
 [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-608--FpMCZ5MNyC9WPdsZ7IIZQ-1; Mon, 31 Oct 2022 09:27:17 -0400
Received: by mail-wm1-f70.google.com with SMTP id
 e8-20020a05600c218800b003cf634f5280so982818wme.8
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 06:27:17 -0700 (PDT)
Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es.
 [92.176.231.205]) by smtp.gmail.com with ESMTPSA id
 bg37-20020a05600c3ca500b003b477532e66sm25116881wmb.2.2022.10.31.06.27.14
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 06:27:15 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bdfb47ca-591f-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667222838;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GwqNSS0OJIleR6uoXEXg4AgYpmJqcWP2KGT201SIVMg=;
	b=W0vqrJETrrXTqQoG3vpBmoqKSRrJS1/Jq7LTpPu+mO9deitZfgbdUDFUfCZ5bixBYlMIUZ
	GrDC02uosAahqXIn6bqCVSZB6T87vh0yNDdytr1uBX2vmgQpsTb5GxCpQz186gv0yM5s91
	Ju+RHUdGinbYv4UwP1yzMQLflk8HTSQ=
X-MC-Unique: -FpMCZ5MNyC9WPdsZ7IIZQ-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=GwqNSS0OJIleR6uoXEXg4AgYpmJqcWP2KGT201SIVMg=;
        b=eNvA424YfTs+qo+fyeHhYjpvNDGyPClxSTOoeczUpPDbEaJ4gNcOqK1jeS2uvB5Wfw
         R1DS3QcyqPNZGF6lj5Fk9u4opUy8gPbVbNyqpYP+hV70cnQDrGgwFIclLmWzVrPeZRWz
         uW7GZIFaGv/KNxdJW3T+fne2vw0assQiNN7KTuDzRM/cDcNdD5V3Bzx0V9IQFvTRGqM8
         TsEkSJhu3cKyXC5q2j9DxWpNoMrlW/80xnOnr2EswDSrUiv6TGLi21JuoXzdgfJ/VRNK
         nYkkdnSJH4uogs4oud+syfuKMfB23nj65mFYzgmiLE4iV6rpvWRA4dozdu6Ei5jXeWVv
         Z32A==
X-Gm-Message-State: ACrzQf19ENDpm25tq/Zt8e29TxswsSkf2a8DOoArCQDDsH+K/nrx9xjj
	3YmwhiWUdE3kzzoqP/jCY36VTqJKSGTmtkG+1ft/cfzcZbhlhRLPDku6sGCGQOsxh5ftAfrdMme
	LRAL+bxTRdxgQrk8MtfNluSiUGBk=
X-Received: by 2002:adf:ec8a:0:b0:236:5b80:da83 with SMTP id z10-20020adfec8a000000b002365b80da83mr7858626wrn.509.1667222835983;
        Mon, 31 Oct 2022 06:27:15 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM4XoYVkE5jE7vlhuKQ/BuqMv6qQj/pE66jVA36/qVXv1WZdIDiMFN0/ixJs2zjwBzGxtBPgyA==
X-Received: by 2002:adf:ec8a:0:b0:236:5b80:da83 with SMTP id z10-20020adfec8a000000b002365b80da83mr7858599wrn.509.1667222835772;
        Mon, 31 Oct 2022 06:27:15 -0700 (PDT)
Message-ID: <0fe3974c-de66-9eaa-b56a-ed1d07644e4c@redhat.com>
Date: Mon, 31 Oct 2022 14:27:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 14/21] drm/fb-helper: Rename
 drm_fb_helper_unregister_fbi() to use _info postfix
To: Thomas Zimmermann <tzimmermann@suse.de>, daniel@ffwll.ch,
 airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org,
 maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
 etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org,
 linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org,
 linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org,
 spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org,
 linux-rockchip@lists.infradead.org,
 linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev,
 linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20221024111953.24307-1-tzimmermann@suse.de>
 <20221024111953.24307-15-tzimmermann@suse.de>
From: Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <20221024111953.24307-15-tzimmermann@suse.de>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 10/24/22 13:19, Thomas Zimmermann wrote:
> Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info()
> as part of unifying the naming within fbdev helpers. Adapt drivers. No
> functional changes.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 14:40:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 14:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433001.685802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVxI-0002sb-1f; Mon, 31 Oct 2022 14:40:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433001.685802; Mon, 31 Oct 2022 14:40:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opVxH-0002sU-VA; Mon, 31 Oct 2022 14:39:59 +0000
Received: by outflank-mailman (input) for mailman id 433001;
 Mon, 31 Oct 2022 14:39:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oXMc=3A=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1opVxG-0002sO-Gz
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 14:39:58 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e14ee608-5929-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 15:39:53 +0100 (CET)
Received: from BN9PR03CA0043.namprd03.prod.outlook.com (2603:10b6:408:fb::18)
 by BL1PR12MB5269.namprd12.prod.outlook.com (2603:10b6:208:30b::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 14:39:53 +0000
Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:fb:cafe::20) by BN9PR03CA0043.outlook.office365.com
 (2603:10b6:408:fb::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 14:39:53 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 14:39:53 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 09:39:53 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 31 Oct 2022 09:39:52 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e14ee608-5929-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QZII/Fn4ELcWS+Dph2b9XNqpFwKUX7wocV8z4scfgZUuyLvHIbLdbKk2cwGnJBRe2tQYkxaeCLSBsgKMc6hLdSInTNsb0ZVQBuPmrzq7PD7ciq74JUwSjrzjAMMNdt3XN9po+rAqT1NA/KNg7YcoAzxcoxvrgfgjeLOUvXasELf1OtQKbrpAlFbuLAE2HjSr/Eg6jt0sFBeZ6tWVhd8nWKGv4UX4VOvAKS5jMdwQM//OP8lmHmdB3mr1w3TDWVdNCh7UFJkr5k386koNCA06t/MYP4p7tlHRiWpGz7wNiH2AN/Vbl82BCGqfWUUZTySP3WjXKSuTjgTpecjZFjUYdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kzh/2fMj11dCzNgbkaFsZ+6FEGFZsdHD3qiMMvY1mKg=;
 b=bMVgV8hCU+C6KVPer2StbuT3ieJVmRnpQ/HKaQNDeKMlWKoXXM7ynT31X/ps21BCgev106jGSnyLtzQ66TpsuRK+1nzD4Rmo7aJ0WCObzKKyUtOKdiSysFI0Egb9WKEcoZG2TwXc93/CyGrxQA4b3LBJczL4GvI/MSK+aOU7XtuQalaVFFklvLfIbMx/gBqI+f3KeMXbITyDajtw/p4hVq0iZ1++6IUkRZDBbDmcTiJvYsJk0dZLFwRA7T7DQk+pm2pMkOhZKncnPUtLoVNkseUwXKYRNGnpVt2zGVlNKjju8ykLT/laRgVtTqWJmEEuo6XdEFjvXLl4vUVpUP/WVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass
 (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Kzh/2fMj11dCzNgbkaFsZ+6FEGFZsdHD3qiMMvY1mKg=;
 b=pBmpnrO1i2s5dHD+bW3gXSzOPxPDCyHztScqwEBm6bWd+zDzb85cuHBgGzK2fS83UAPctRK5/Ye62ow9X0xMfnolxI0jGaXPRnUw83lKmV/sO8bq6NuLmIlLRBKxO0sE1c5QfnAhOffrkXpPDb4fGq3L1/Gr5G0Oqk8UxB0eOTM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com>
Date: Mon, 31 Oct 2022 15:39:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI
Content-Language: en-US
To: Bertrand Marquis <bertrand.marquis@arm.com>,
	<xen-devel@lists.xenproject.org>
CC: Doug Goldstein <cardoe@cardoe.com>, Stefano Stabellini
	<sstabellini@kernel.org>
References: <cover.1667224593.git.bertrand.marquis@arm.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <cover.1667224593.git.bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT052:EE_|BL1PR12MB5269:EE_
X-MS-Office365-Filtering-Correlation-Id: 1575bac6-6ffd-4613-2061-08dabb4dc5f6
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5Hgpo3j9S/bS4PfSfkfFTnE3YpzP7wOA8289FZLQPxjvJh3zyhdUNrYGoHcWhR7JuXOoB5a5uflnfQBUpdEfpq+CSOZfvCZBoBE7EhYaIYYxfCYaJyy/IFU2EQyTXtUR3g3/2Dx91xG0m6oCU9GmqnC40WiK/u3gZw6uquluWpGSMnH3FW4CE0shO/iY8SoU6WCp6tfTzYI2DIs4d8eb+AOawrxK/5qnaS8nBI3+Dv8PalFtO1cBkCbDcZLHALeYZIsntymCjMdAp8kV0nFONUdGTW68aDoRw31MTiYtXgS4fJzILt7cpj92QdWyyHy8jD7YNiJMD5+mio/KKdakRoPjwXxJTmtsmUc9JmwgNue3UP/FrNexNsjkZaX3CpaK8eskgKuJXGQ5sDa2mgT5nd9LO8HktVK8mUq9mWoscxn4h8QkYwh+5Yl5XN59/fPL7RdUcQtaajLvrwSM9uzxV6P/NmlxwCENNbUU9OgdYYpcqsk1rADuNx1D7osJCVerX2K4/X58tHn6B7P+kVfHAj4/eGdvUOL/2pJcdmVMVbIeBsskL184MxtH8nEUUT/eFyZslFiX12KRtF4wu0ELCTEvI4gQY0+aNJrugCApPpSTuxWAAvfVwuNeW4KWLFNtGNMZo3WQExmDe+y7fx1L4CtHQxEZN28CKiXq/ZliYrmh1QzwrTaS8Fp0iYD3fgUUdh3Kh93UvlymYRpR/ZS1cl+FdMlRQZYob6WPpiOFWO7Qzi+6bCrwA3fzXxWaUtVMY+MGPpVAqYAMMJpDgthoae+cNk5LhWrakDm4H993shxYFO5SlvbNe620Td2UHA4ldUwTTNjtvz5ZEcuE2TfxJw==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(356005)(86362001)(81166007)(36756003)(31696002)(82740400003)(44832011)(2906002)(40480700001)(4326008)(5660300002)(8676002)(316002)(16576012)(8936002)(110136005)(478600001)(54906003)(41300700001)(70586007)(70206006)(40460700003)(82310400005)(36860700001)(186003)(2616005)(53546011)(26005)(426003)(47076005)(336012)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 14:39:53.4151
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1575bac6-6ffd-4613-2061-08dabb4dc5f6
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT052.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5269

Hi Bertrand,

On 31/10/2022 15:00, Bertrand Marquis wrote:
> 
> 
> This patch series is a first attempt to check if we could use Yocto in
> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
> 
> The first patch is creating a container with all elements required to
> build Yocto, a checkout of the yocto layers required and an helper
> script to build and run xen on qemu with yocto.
> 
> The second patch is creating containers with a first build of yocto done
> so that susbsequent build with those containers would only rebuild what
> was changed and take the rest from the cache.
> 
> The third patch is adding a way to easily clean locally created
> containers.
> 
> This is is mainly for discussion and sharing as there are still some
> issues/problem to solve:
> - building the qemu* containers can take several hours depending on the
>   network bandwith and computing power of the machine where those are
>   created
This is not really an issue as the build of the containers occurs on the local
machines before pushing them to registry. Also, building the containers
will only be required for new Yocto releases.

> - produced containers containing the cache have a size between 8 and
>   12GB depending on the architecture. We might need to store the build
>   cache somewhere else to reduce the size. If we choose to have one
>   single image, the needed size is around 20GB and we need up to 40GB
>   during the build, which is why I splitted them.
> - during the build and run, we use a bit more then 20GB of disk which is
>   over the allowed size in gitlab
As we could see during v2 testing, we do not have any space restrictions
on the Xen GitLab and I think we already decided to have the Yocto
integrated into our CI.

I will do some testing and get back to you with results + review.

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:00:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:00:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433018.685817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWGt-0006Xo-T0; Mon, 31 Oct 2022 15:00:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433018.685817; Mon, 31 Oct 2022 15:00:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWGt-0006Xh-Q9; Mon, 31 Oct 2022 15:00:15 +0000
Received: by outflank-mailman (input) for mailman id 433018;
 Mon, 31 Oct 2022 15:00:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=X+oh=3A=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1opWGs-0006Xb-Si
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:00:14 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8eb521a-592c-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 16:00:13 +0100 (CET)
Received: from DB7PR02CA0012.eurprd02.prod.outlook.com (2603:10a6:10:52::25)
 by GV2PR08MB8049.eurprd08.prod.outlook.com (2603:10a6:150:ae::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct
 2022 15:00:11 +0000
Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:52:cafe::90) by DB7PR02CA0012.outlook.office365.com
 (2603:10a6:10:52::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Mon, 31 Oct 2022 15:00:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:00:10 +0000
Received: ("Tessian outbound f394866f3f2b:v130");
 Mon, 31 Oct 2022 15:00:10 +0000
Received: from a7f2a70ab37b.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8A98A25D-EA2F-4532-A313-78C6243AFD71.1; 
 Mon, 31 Oct 2022 15:00:04 +0000
Received: from EUR02-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7f2a70ab37b.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 31 Oct 2022 15:00:04 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by DU2PR08MB10261.eurprd08.prod.outlook.com (2603:10a6:10:46e::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct
 2022 15:00:02 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::58db:2a7f:e8f5:92ad%7]) with mapi id 15.20.5769.014; Mon, 31 Oct 2022
 15:00:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8eb521a-592c-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass;
 b=kba6PY6IzRvlptX5K/yv0iHY4ETQMry/mR0QInrR2jDK3oSncfiAhOXMRxrtjMIsC5vOTuRF9HKQHB23V2n4QTRgb42pqe8wKuiS0pr2ewJuNQp+QQBsAtQCwXw44RVa5liLDuipHxwxRgIMabsY9Fps39MGIDt/cIeQ4kETFNxmYT5c+gjk5SNs53p/82SKNW+9VOeJQPVmpgRr+ZqXQoKhF/4CPfOTPusqD5h2AITKHcJp9i/0hAIQ0VIdC5PzBDYYtnPTlBazhgQfECg0WERLcteYTxl9h4NoDj3A7wV5p7NZiqjCNwW84sVfi1VvAgpQm/5o+jWQBppt4AwoDw==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PcIwLfFsTcCfDGttnp6HWQYe3p86ho45mqY8hci0/2k=;
 b=DXURZA3+h0n4DDYwzI//Ea/a8aWIjMer36cbY2JF4szV8wYCz4Tp2Ppx/CtEhxTbaHu7FIF6xxCU7mAHCyXwNBLXgAELF3+y4UW9MSxf2nlm9mubUV3zNxEMBUIBscB+V0+YS3XuWNM20mrf3XSgcCrenX7AcNgG3m9BZ9Ga69QHWj3teqoZ9gDekZnTDk2fddFwgNWMMVrBjrRg61EfxYodXRYEdIrMVgn4EI3aTY/2zEYYPgZKote1UD0i8/xgDbtnhXUG860Nhj45i1iXndX1j2NmLTgARI0GLIzmJvjixHL0fTM7Tl6ltZKGh9pZXajCaUy+OlGLJSg6IddUZA==
ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is
 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0
 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com]
 dmarc=[1,1,header.from=arm.com])
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PcIwLfFsTcCfDGttnp6HWQYe3p86ho45mqY8hci0/2k=;
 b=5TWi7jMTHh2gHeaUxMIpCo5Renn6qAePm95ccsEPPxEdV3ScBlVfL1zMbzu3VIrNtdDnGpLGEnu+PUpdNs9KxOsotEySMsu/gUTsHs/vr+zkjEIgMQdF8I+w2xgGuwL3H8MgFGsDS3SO0bfjKhYdLm6ulh5CZGTb+KZS+CeYDX8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
X-CheckRecipientChecked: true
X-CR-MTA-CID: eb4fe5b6cc203de5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NLVE5KownaD7hnUFvqM9v1TrhInkLhSgHq8U6U5sXpr0qnPT4DywJMlRnvG/SIAlg+DcIHDKKAfOlBm6K+1/XFFwr9hqkBOGWIl7N0kd+2T2KNI/MEhzSIxdzvZdWkmNMlIpGSU7koYwo450gsgO3hAETHxLtH9NviLuXZtBFfn1CuJ1MwnKVSWKYKzi82skskDj7Lb6TAUuFAfqAS4v6W80eZXYIOTsUjIdvowxbRsH/I94A0uaqSqGqBJr4sk84St8iA++Ii5PKH+IWlWwdBYD5oRVMqvHR3uMq7js66saLDTXZ3Ds/dXg0JRgn9nHpk2J+cxQWngPsSIgEJwiHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PcIwLfFsTcCfDGttnp6HWQYe3p86ho45mqY8hci0/2k=;
 b=JO3xdXO3a/8owKK8VevqE/z3hoXo9dxaeF4YsSS2317XSLkNojnRy4BtH2r3DBk/x4tEcLU724Ch/2SMFqC9fsWIfEESX8l1JKHloTbYm+7xkKS/F/yfG34F78aYhHdTBO2jKh5rEj/cCtF9YcgfK14JkVuWtLalStWoudhpE3s+4Oj3bGEoYhH7LzO+JUFAwobSASga+Dba60/+vi3MGq2m6/RQ8fVCxGKpj0EN2+SeCck3/5fvTwb4FbVXIg/YdUsZ0CuySLu5U9WNm96y/7XX11rGcACeN3zvfFRJRJ26HwUKZ43ELYK+pJ9nM3JKD5C0FG8Q8AmL2AZce/FGng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PcIwLfFsTcCfDGttnp6HWQYe3p86ho45mqY8hci0/2k=;
 b=5TWi7jMTHh2gHeaUxMIpCo5Renn6qAePm95ccsEPPxEdV3ScBlVfL1zMbzu3VIrNtdDnGpLGEnu+PUpdNs9KxOsotEySMsu/gUTsHs/vr+zkjEIgMQdF8I+w2xgGuwL3H8MgFGsDS3SO0bfjKhYdLm6ulh5CZGTb+KZS+CeYDX8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <michal.orzel@amd.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Doug
 Goldstein <cardoe@cardoe.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 0/4] Yocto Gitlab CI
Thread-Topic: [PATCH v3 0/4] Yocto Gitlab CI
Thread-Index: AQHY7TFh2hDh7VPqHUGkPo4tUdJZza4okuGAgAAFoQA=
Date: Mon, 31 Oct 2022 15:00:01 +0000
Message-ID: <D1248F50-542B-474D-B016-A3BF09A21CE8@arm.com>
References: <cover.1667224593.git.bertrand.marquis@arm.com>
 <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com>
In-Reply-To: <1220596a-4fe7-5c08-5437-fa98eb14254c@amd.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3696.120.41.1.1)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-traffictypediagnostic:
	AM6PR08MB3784:EE_|DU2PR08MB10261:EE_|DBAEUR03FT058:EE_|GV2PR08MB8049:EE_
X-MS-Office365-Filtering-Correlation-Id: b596ccfb-bbf8-43d8-1212-08dabb509b8b
x-checkrecipientrouted: true
nodisclaimer: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 OZA69K8hTUAg67/1eWo+NGE/GtDfWQKZYpQAvhIld7u1dyWRb8ielBVCBJ+kKAcqmNR6bicmRIjd5ON2DJxnREHfsGax3a5O7kmaJVgwLqd2OWiqa/OzGqZO2mOYjp1j4Cj6bsjzEP84HdiMMTs1Cw8vjyWobC5vtBE8IaQASpEyWmQa3ESaGHL2FniBTF3P5AnOaPY/i8SDQ29mXtGsLYhUzv5HWW61ALi2TyC75c6SUKkaM18qnDQ/j39AauqDslow/3UNeNeBZLyNDW3tpHcD+7/YsTpAQHNiaLiF/Ntzmb8pEp9HmSlCPEMHmBWaTfFrrS9PlEfiPZ0WVNbg92hhKhZZajdVKn8hvSjOTfi8HewZ98QYDbzoHCl5hy/WANzA7sQyAi7wwD9TO2VmRTQLsMbADc9JmnkKBJJIsuXZtj03241Vw8RnKDAhZRl87IK2jPTyS/5e828TyehdtxwdV7pD2qwcFDImGKqN8+k6k1aP8oOkGPq+WK26w5H90in7nVpDsLdhfJcG1thXsB+oqZbSBn19KY8VklozGpCy2DQ8NgWTRLyyUgxfY5XGzO+AXt57+AadkZycsUWCfRFEyfYjH3FyUYFxiAkpq23I6L1XX4rhAbt3utkfDpEsfPo2zMxycaRmkmdC8iM41fHbqXyQh4T5T6P4UUjM7AeZa+2XkCvPDI69loaCy5Qw+AhCAEXUl55VnrpxctStwiK1M8vkjoBMD/Co6yi8Dafi34NqtFbpvDSwujxlNTTAV+rZKj4Tz03AeKdOVoGXZzyMIRnmpuDJONm9lFUkSik=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(66556008)(66946007)(2906002)(26005)(6512007)(8936002)(64756008)(53546011)(6506007)(41300700001)(66446008)(8676002)(54906003)(91956017)(4326008)(66476007)(6916009)(71200400001)(478600001)(316002)(76116006)(6486002)(186003)(5660300002)(2616005)(86362001)(38070700005)(36756003)(33656002)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0C6EBB9C7CBC294AA0F06CBB7332864E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10261
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3fdcfb7d-47d3-4e13-a380-08dabb5095e4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	viAhhYRTgpcchq7JoK55pEtTJgvgGyjWa7WP5IWLqLLHpM7rJGE6Cek7h/IM2v2WWlROllzO05nWk506pZzBefZKnUaBJl1fJHB4kwJ2m6oWIKKxqMJ5US71Bmb7BNiEgyGzbTMA8T7lUl1NBaHs24in/JEXYi7eNCADNBQC3l0a1ukE6x9CZD1uW3mkKEXVZeViGytbhQpFA2/qO1e0HSi+5A4Bg0nQwa4xAiIeGKsR1usRO5+dQYiBLwRnK0MBXi5lpMpTHkjpquSmRQHidji68hGlqq+fiKA4PY0B7lY5bshCXGEgupyd6i2zm0rn6bp9qDgAk/u+n3XsLYiHLz/A+5Wv8xG7p+aYa/1mBB5ZXd/iakINZQSrgJrVFcH6FgN22i4NcIA4LBO30mQ9Pqn3qV+qprjm2WYdxqTgTZqP01wm7n3r+RWzPcWNjWQPw3XNIOsAYLoM9wCa6ZclytprQgvVQcpDtM65AJowJNFjZC+AxqpT0zLdpvLJpriUp82OKJ+6QLvbefCCvqNW147QT1vv90EihXTLB81xxDN7yKy3iq9ip9w7sdbVRTIN55QeVrWPCtbn0/jBZH48vjXZF3sP8qiY0UCPtzdwZEXlgEa/l0GauviwV/unUwvrtAXMBQu0IsbNzT7No9oBfsEYBO3Fguj0J0c0xMbFjdJvYapYhmjP3u9gNT2XzLf7PkL4nvscrStCdB5exik3Wu62aGqXFW8NM8YBaxpQOEJ0090Bu11OJGh6ix7BqbCCPfp6mNb2BPWL1NcTAaJb6g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(36840700001)(46966006)(40470700004)(36756003)(33656002)(86362001)(82740400003)(81166007)(356005)(26005)(186003)(47076005)(40480700001)(107886003)(40460700003)(53546011)(6512007)(36860700001)(478600001)(6506007)(2616005)(336012)(82310400005)(8936002)(6486002)(2906002)(316002)(4326008)(70586007)(8676002)(41300700001)(70206006)(5660300002)(6862004)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:00:10.7706
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b596ccfb-bbf8-43d8-1212-08dabb509b8b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8049

Hi Michal,

> On 31 Oct 2022, at 14:39, Michal Orzel <michal.orzel@amd.com> wrote:
>=20
> Hi Bertrand,
>=20
> On 31/10/2022 15:00, Bertrand Marquis wrote:
>>=20
>>=20
>> This patch series is a first attempt to check if we could use Yocto in
>> gitlab ci to build and run xen on qemu for arm, arm64 and x86.
>>=20
>> The first patch is creating a container with all elements required to
>> build Yocto, a checkout of the yocto layers required and an helper
>> script to build and run xen on qemu with yocto.
>>=20
>> The second patch is creating containers with a first build of yocto done
>> so that susbsequent build with those containers would only rebuild what
>> was changed and take the rest from the cache.
>>=20
>> The third patch is adding a way to easily clean locally created
>> containers.
>>=20
>> This is is mainly for discussion and sharing as there are still some
>> issues/problem to solve:
>> - building the qemu* containers can take several hours depending on the
>>  network bandwith and computing power of the machine where those are
>>  created
> This is not really an issue as the build of the containers occurs on the =
local
> machines before pushing them to registry. Also, building the containers
> will only be required for new Yocto releases.
>=20
>> - produced containers containing the cache have a size between 8 and
>>  12GB depending on the architecture. We might need to store the build
>>  cache somewhere else to reduce the size. If we choose to have one
>>  single image, the needed size is around 20GB and we need up to 40GB
>>  during the build, which is why I splitted them.
>> - during the build and run, we use a bit more then 20GB of disk which is
>>  over the allowed size in gitlab
> As we could see during v2 testing, we do not have any space restrictions
> on the Xen GitLab and I think we already decided to have the Yocto
> integrated into our CI.

Right, I should have modified this chapter to be coherent with your latest =
tests.
Sorry for that.

>=20
> I will do some testing and get back to you with results + review.

Thanks

Cheers
Bertrand

>=20
> ~Michal



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:13:59 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:13:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433022.685828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWU6-0008E0-3Z; Mon, 31 Oct 2022 15:13:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433022.685828; Mon, 31 Oct 2022 15:13:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWU6-0008Dt-0U; Mon, 31 Oct 2022 15:13:54 +0000
Received: by outflank-mailman (input) for mailman id 433022;
 Mon, 31 Oct 2022 15:13:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWU4-0008Dn-He
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:13:52 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12hn2245.outbound.protection.outlook.com [52.100.166.245])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9f72c823-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:13:50 +0100 (CET)
Received: from MW4PR03CA0342.namprd03.prod.outlook.com (2603:10b6:303:dc::17)
 by DM4PR12MB5964.namprd12.prod.outlook.com (2603:10b6:8:6b::6) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.5769.16; Mon, 31 Oct 2022 15:13:47 +0000
Received: from CO1NAM11FT013.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:dc:cafe::3d) by MW4PR03CA0342.outlook.office365.com
 (2603:10b6:303:dc::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:13:47 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT013.mail.protection.outlook.com (10.13.174.227) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:13:47 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:13:46 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 08:13:46 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:13:45 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f72c823-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XOOC0zQskzP+Ro12bE7Atp+6UGJka+q8cTC04V1dip8H2oZOXvFclCLSg4emii3h2MqD9Z9P9eLv27HkHHJXMmFE+kxKy9HDwDCuta6efiJyAA8cixZhN5to3FqjgoUHhizYnVvgk7oqTIZvKIbLzYRZSDpI9zCIep8KUMGDZjyOHEBxUk4uH8ebazzrpoq1kA/4bq3RRIv+QK0mANBS7u3ot/G6+YsK+H9gL90dgWxUbb8HcJoPj1pCKRMI116ktkHHB5Zw6jgSHm9kH4eL1aunHbYWjMDpyeEnoLZUdszHxYqI2A7aNlvmoAMelFmsQrykt8xPBHJyJA+PGySvUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nRSHJ6wAhxWVOSKl64SdUWUT5qqgNhl3sYkMCP37X5E=;
 b=iwnzlL2ggTGdcA8LDYqEYE0Sp6JPaFjd3QYHEfts/6O3mIiZslrqYbixRuXicB/G4mN+Un2/95FXZbSdl6xOGYaKWgIrs6chR+KyqEozo0Rjy7VrVy4Ug0vkWc4oZhoU8p4GWSyL8D3EOgZYCxRaQioqI11Gsr0bFjdQtuOfGjaZzqJ0Wd25nTunzRWorL0b5fs/rl2wh/8Ja1cGIPfEHMUdlOnoIKFqBOQjyLekH11+7BvanlL3ArsUHYwCtOekoU7ubOj9XXsAf2V17zF1HNvn5+zLxrP/KE3lB+Okf6ICtQzKnl7c6F9K4OKEZRz6CKH0Hte4nXt3425hHKzGsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nRSHJ6wAhxWVOSKl64SdUWUT5qqgNhl3sYkMCP37X5E=;
 b=pUor9/fdNorDvNHvPsfHX/7SoSSytWq9hyfzx00jRCoUAE6JExQpgNqWdBBUNwFb7SZfS7oYLpdqryiakIUUpnTST22aeZy+uTmZCnwqX7/7GKwwEgXgSaLDdJRY4MqQsL9SqtlM8OedJmIAp3B2ujCIJMiYOWdKqztDHyBOrfw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 00/12] Arm: Enable GICv3 for AArch32 (v8R)
Date: Mon, 31 Oct 2022 15:13:14 +0000
Message-ID: <20221031151326.22634-1-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT013:EE_|DM4PR12MB5964:EE_
X-MS-Office365-Filtering-Correlation-Id: e78dc95d-ad04-436c-38c5-08dabb52825f
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	=?us-ascii?Q?6yz0vOqDq+kKopEOAU7ZV2KULxnX7D3ludZhoq39TMBYG2jTdfE/NbTCw1fQ?=
 =?us-ascii?Q?UAHtf4vSNyVJBOc/4Vi20w/hxE74oBQ/iyukG00PDHKtvgmQCjhTydNaoEMq?=
 =?us-ascii?Q?FGXOl1LRp/vpft30xwbINZ3fnqIdZiZnDx607ru2MQVo0kKWGPOEmTi7NOEN?=
 =?us-ascii?Q?Kt+fxIMMM61nQB4P53FnEQmMbXzVtWqiiGG5WUP1ctK3Wl39TNXZuAL3KDF6?=
 =?us-ascii?Q?MURLFo/QCuwSHNJP1/sBvqpROHk9ybQg7AIA2cR3UEX1yM5qEXYZq/bK6neN?=
 =?us-ascii?Q?CO4eTEVe+7XGjroGIaCjk8o0YpT+CDLJsdXYiw3sgkkzC1UyM/fC/Puf29+S?=
 =?us-ascii?Q?JyUxQLujm5lI8GNEiMxA6DnWvOagi2oRG7zlCFrsm0y/64AGGz2FlXt3JYCH?=
 =?us-ascii?Q?VpLBeE8Pg49DicnrgcxO8/DMVvxm/XQqNOEgJLr26hF6ITb10pu75XlMZ7OI?=
 =?us-ascii?Q?FV76+8Ocumb76taOBzyBjX2pqWzg7t9ktIuHuZdJx0z55LSiM0trDRC8ifXh?=
 =?us-ascii?Q?hg/p69xTuv2nx5It9O0ZzfBR+J9RNxo246/6q2vI7cHLU9vYb+Pjypli7K18?=
 =?us-ascii?Q?lRZshWXlXOxQqotd/rmmtfmV7JG89Qz0bIq167uV9/H5KwNm14LY/QrZkzlc?=
 =?us-ascii?Q?3oPR2ITvOeKrFxaY26g2I+1ad18/aYF9rj3h8WHtq8qxies28mhaAUA/PMi3?=
 =?us-ascii?Q?A2J/6ibaFVrGyW7NvXw/gmT10Mjyxjloxith0Ne46U0OtJQMmraOfELf+fRC?=
 =?us-ascii?Q?uhGL8uuIYX9TPozlRDS/A7c00zzGTnHtT9vjNEnXx4zZL0+p5lw/yXFk8u4j?=
 =?us-ascii?Q?WP9HmGMgYtd2VkpfT6RNXMK2AOgOfIxwPZ0COjWyTQDUefKdnZFY25H8dbK6?=
 =?us-ascii?Q?xUmRKsKpqtrnxcqEQm7iT09wQLn69Wb74i1G/+AKzJPsbrwZ4g8taHFwHa7J?=
 =?us-ascii?Q?RK7kaMyYB9t+Oxi18N701WcCFI8qfrj0ZjEcl9+w51ZGUEGbg8DlNErMpwqD?=
 =?us-ascii?Q?8+M2IGC3bGbzrdiAp4pfABFR7J6BUOaTajesSCdLtGZ++L7joym/VRTDxlpa?=
 =?us-ascii?Q?IVpfceSwwAk+nQ9bhL1NII/j2d+wgaqfHBy6cFOnPyA+ohb9333QDQLO7zhk?=
 =?us-ascii?Q?fXveUUg2tqf2C9kDQ57CWWOpoEV/9ZVJ/bTIt2yqz7xwdTHsLR4eJXmP22Cj?=
 =?us-ascii?Q?BBItK8I5hzdwQ0BMVNezw/e4AtgVKpSWY43BGuzpXlJR+zvq+GZDlZSk6JU?=
 =?us-ascii?Q?=3D?=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:OSPM;SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(2906002)(5660300002)(8936002)(41300700001)(4326008)(8676002)(70586007)(70206006)(478600001)(82740400003)(356005)(81166007)(40460700003)(186003)(6666004)(26005)(336012)(36756003)(1076003)(2616005)(6916009)(82310400005)(36860700001)(40480700001)(54906003)(316002)(83380400001)(426003)(47076005)(36900700001)(11215385002);DIR:OUT;SFP:1501;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:13:47.3931
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e78dc95d-ad04-436c-38c5-08dabb52825f
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT013.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5964

Hi All,

Please find the following patches to enable GICv3 for AArch32.
This is a pre-requisite to support Xen on Cortex-R52 (AArch32-v8R system)

Let me know your thoughts.

Changes from v1 :-
1. Updated in the changelog for each of the patches.

Ayan Kumar Halder (12):
  xen/Arm: vGICv3: Sysreg emulation is applicable for Aarch64 only
  xen/Arm: GICv3: Move the macros to compute the affnity level to
    arm64/arm32
  xen/Arm: vreg: Support vreg_reg64_* helpers on Aarch32
  xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32
  xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit
    host
  xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32
  xen/Arm: GICv3: Define ICH_LR<n>_EL2 on AArch32
  xen/Arm: GICv3: Define ICH_AP0R<n> and ICH_AP1R<n> for AArch32
  xen/Arm: GICv3: Define GIC registers for AArch32
  xen/Arm: GICv3: Use ULL instead of UL for 64bits
  xen/Arm: GICv3: Define macros to read/write 64 bit
  xen/Arm: GICv3: Enable GICv3 for AArch32

 SUPPORT.md                                 |   6 +
 xen/arch/arm/Kconfig                       |   4 +-
 xen/arch/arm/gic-v3-lpi.c                  |   8 +-
 xen/arch/arm/gic-v3.c                      | 132 ++++++++++-----------
 xen/arch/arm/include/asm/arm32/io.h        |  21 ++++
 xen/arch/arm/include/asm/arm32/processor.h |   5 +
 xen/arch/arm/include/asm/arm32/sysregs.h   |  18 ++-
 xen/arch/arm/include/asm/arm64/processor.h |   8 ++
 xen/arch/arm/include/asm/arm64/sysregs.h   |   3 +
 xen/arch/arm/include/asm/cpregs.h          |  69 +++++++++++
 xen/arch/arm/include/asm/cpufeature.h      |   1 +
 xen/arch/arm/include/asm/gic_v3_defs.h     |  24 ++--
 xen/arch/arm/include/asm/gic_v3_its.h      |   2 +-
 xen/arch/arm/include/asm/processor.h       |   6 -
 xen/arch/arm/include/asm/vreg.h            |  88 ++++----------
 xen/arch/arm/vgic-v3-its.c                 |  17 +--
 xen/arch/arm/vgic-v3.c                     |  16 ++-
 17 files changed, 255 insertions(+), 173 deletions(-)

-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:03 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433023.685839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUF-0008VW-Bp; Mon, 31 Oct 2022 15:14:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433023.685839; Mon, 31 Oct 2022 15:14:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUF-0008VP-8q; Mon, 31 Oct 2022 15:14:03 +0000
Received: by outflank-mailman (input) for mailman id 433023;
 Mon, 31 Oct 2022 15:14:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUD-0008Dn-Rw
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:01 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a5b0abd2-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:01 +0100 (CET)
Received: from BN8PR07CA0020.namprd07.prod.outlook.com (2603:10b6:408:ac::33)
 by MN0PR12MB6102.namprd12.prod.outlook.com (2603:10b6:208:3ca::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct
 2022 15:13:58 +0000
Received: from BN8NAM11FT066.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ac:cafe::47) by BN8PR07CA0020.outlook.office365.com
 (2603:10b6:408:ac::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:13:57 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT066.mail.protection.outlook.com (10.13.177.138) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:13:57 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:13:57 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 08:13:57 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:13:55 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5b0abd2-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=avRwN0G+ApTkyA8fRoS2jvSo444A4oHY6yqNU3dJ3eZ0xoe8J1lwFkSZdAR/NPJUnB8pKYY0IOnE5GTZGdooEjzuWKgWyW5GlrGn++QeDTnuVP16eVdzZVNMTZirXHUVdMM0wd2Nj84kHubGvyU7rVRtXLu7dAdxn8F95dWYBpNl3ZQiW1L9C2ZTs+8UurmDMryLyQZDP9srrLEKGSj5X9tz350gj11Whzv5iSWnY+pfIv9MOcGeKO02lhFehqWVZeA4VCiySOWy7V9WJHgK7vKkOQUbG+omUywmRmsPTzS984dYBl5VruWniUuNVQzeeBOsUcgRUX8odws0tMuboQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XCcH6I2IShWjy514ECFK3D/NJBnq9VO1ALaP7nT1HEk=;
 b=H6IGreBIVOArGkD5KWVUyAjEHjHMI9yN+GU3w2qeVxvXze2x9atYkfWJuo9DgcRHzjp2rUel9ROEwo/+I2HHFpiD9rJSsX/T0zSxnLxIT54HB9/R0ktvWJj/BXZWSHbXpYc2AjPSpOwu/yO06XCTccujN2S95XuCT6f/4zAUipDVb0xhJeiBJS2kE2zlNjqrw8PT4KCDexvG4AV9VNgPHjcaKWEnXG9YPIUBjOlVGuwcRWNTjh9TjrMLt3Vgk1SLshHtfsmQp0yzCx0R7QCoqaf4m6XWy73Ae/ijGYVf78QJNRIOeCzO2OoX6VO15rZvc0TJc97yLMEEUIy+PknnAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XCcH6I2IShWjy514ECFK3D/NJBnq9VO1ALaP7nT1HEk=;
 b=rkJuPrIMpEkhJdkHBVTJ62us0ZD51WZagQwUZPPz9ru7VnoYY1DaKTwkrDdmulfThSxftfZzqXCU1E1NjmBZRQnH58lvPIahprh+/W4zsz1FVfjFPHi15Qa5PbBDImjzGvD6u95pc35ljclroom4Wj3YVjQOkXdFb7g0d9cXYqA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for Aarch64 only
Date: Mon, 31 Oct 2022 15:13:15 +0000
Message-ID: <20221031151326.22634-2-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT066:EE_|MN0PR12MB6102:EE_
X-MS-Office365-Filtering-Correlation-Id: f9b40064-74d7-478b-23a4-08dabb528867
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	otvrLXU7ddqHrK+99F4qQ1k3FBoKQ8Gg+QvQs28l0VmTvSVte3VL+40rNSlfCOsw5JAZH93O/XLp+NEyNBEHoM80tH1xntkRIV+Yl4reZfE0MqOD3rTWFDJ/gJrxzgrQihxMfPLElxqqSeB90/qYzYWrV0Rwr+7Yj72Mv1XB7uhGQ6t1AgW5SDGkFmrF29lqf5UfODy9Bz3Q4Gd+W6a5jBVlcCYUVDb+D73EtqBAn0PY+2Xe+R/kRM8kOUhg43CGvF5Mj9IPeBFMAjrRrt95BngDO0tMzAYVvkqfxhmOoMdm2KRbcOfXvTC6MszZuCQL7LXJ3XAj3mcZR3cnm3/OC46bIRm7J3gobbA7GXAxU/jxav9disCoQ9mCcoP3KzfY5VOu9UtP+6LFpxSCL+2H4Qk5g3jCl9f1vejwTfaxPyGdJcpfrwpJZLttAedGgTSHb0O2F/VSCnJ70jHUXFWD9ZVyvi0YACwqCqu/Q0y+cccHMT1WvV8S+cvaqT47sYcCeiGqFHQVSJJu0t+UW9iwC39P+g1j+9DhSUYSTgl2Ah6Nf2lYkTgNO9/hbv47VF8tx4XBhOHzHwNSnexCaHq52PcEYmOsvwow0djBekb1oLI2/n9LEFKyZWkW2Xm1lvwEQ3zEeF9ZwBZONNptmvuOkgPgJk4KIhh1nHf2LdVegfl/+Tz5s54BRD8LqJrM5G85eW+sbb4MdK/iElHuIij4jCsTdLAXCYviaIIAJvPUwQZSsLFbdi3+2hQR5CRu5/viKiEC0xUmqKTSCFSQC3dtYOdSCyr1NndUtn52vIMIY1E=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(26005)(8676002)(356005)(41300700001)(81166007)(4326008)(36756003)(36860700001)(47076005)(2616005)(83380400001)(426003)(8936002)(336012)(40460700003)(5660300002)(54906003)(82740400003)(186003)(2906002)(1076003)(6916009)(478600001)(316002)(6666004)(70206006)(82310400005)(70586007)(40480700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:13:57.6050
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f9b40064-74d7-478b-23a4-08dabb528867
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT066.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6102

Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
only. Thus, vgic_v3_emulate_sysreg is enabled for CONFIG_ARM_64 only.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from -
v1 - 1. Updated the commit message.

 xen/arch/arm/vgic-v3.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 015446be17..3f4509dcd3 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1519,6 +1519,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs *regs, uint64_t *r,
     }
 }
 
+#ifdef CONFIG_ARM_64
 static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
 {
     struct hsr_sysreg sysreg = hsr.sysreg;
@@ -1539,6 +1540,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
         return false;
     }
 }
+#endif
 
 static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr)
 {
@@ -1562,8 +1564,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs *regs, union hsr hsr)
 {
     switch (hsr.ec)
     {
+#ifdef CONFIG_ARM_64
     case HSR_EC_SYSREG:
         return vgic_v3_emulate_sysreg(regs, hsr);
+#endif
     case HSR_EC_CP15_64:
         return vgic_v3_emulate_cp64(regs, hsr);
     default:
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:05 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433024.685850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUH-0000Lz-Ph; Mon, 31 Oct 2022 15:14:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433024.685850; Mon, 31 Oct 2022 15:14:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUH-0000Lo-Lp; Mon, 31 Oct 2022 15:14:05 +0000
Received: by outflank-mailman (input) for mailman id 433024;
 Mon, 31 Oct 2022 15:14:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUG-0008Dn-NY
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:04 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2084.outbound.protection.outlook.com [40.107.237.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a74af888-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:03 +0100 (CET)
Received: from BN9PR03CA0586.namprd03.prod.outlook.com (2603:10b6:408:10d::21)
 by CH0PR12MB5172.namprd12.prod.outlook.com (2603:10b6:610:bb::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct
 2022 15:14:00 +0000
Received: from BN8NAM11FT062.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:10d:cafe::4c) by BN9PR03CA0586.outlook.office365.com
 (2603:10b6:408:10d::21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:00 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT062.mail.protection.outlook.com (10.13.177.34) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:13:59 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:13:59 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 08:13:59 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:13:58 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a74af888-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=coLUsn+FnEhbZRtmCf0D6FaqiVG1/orZMiO9xvSKBsTlYe5eS+ZUtO9OpnKbHVXbbPJ8fsSxbTxlbT9j9wIkc8QFdLebT5AWegv4WpnySvwIJrF0rUvT9QqwFR/fCkjxq9RZgDlQv9WRSgcbaSDX48lb/MJSCUWkZ74ugM5oYuP+QS7rJCgkiJnW6yxX6g1q4YwutxTGt0mIdvfU/pfNAvuwr1Ih4w5H6vkdNPm50JqTE940ljO6AEk3mUSEOaVAVftjUYZ0Bwf5TOGl3HjmoNOA5CKBN0QlZaPd6RMVlUk1KZaMk6LN1TGrCskrv6NbK5HcySU12fY9QBTiQ6ksCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=adYAdT9Zx/p/A9R392/UHvgvSHlcP+ELYd9uABjHU/Q=;
 b=A1JOzk5lDpl9/YEY7z1weMjhCfTFxGhrxclfPxQyVLpisQZcs/3LiD8sj+FIpv1VQh7VlQWVWBCyXZFOwhiI+o+Y/tE+rZpjCAKgztz7xRGQTyQ/71TaWfs+YiPYYKDdJQtdCyW23K8JF5/rRtK1WszcIO6RSvtlEhQ8sbiTtobWwnS7a2gmC5px+IgWrUcVoiNVAC3xt82UOMQrU73p37D6J+q+qW1p9nLKrfnSCWxcPiDm8ZuEWdkcyR5UgZ+VPflaUS7NQZE8sc4sQ2FnJlmKDrNyyg+X/fJqEHBosfHX7pUEu56ghdc5U8UIqtib/k3kGOlakF+l7A3HzJd/fQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=adYAdT9Zx/p/A9R392/UHvgvSHlcP+ELYd9uABjHU/Q=;
 b=MgGSYfk1aPwHePdl0kfrdyBprBVkO8RO2NnRhZSPAuzxbASH918wPpT8opGy8K1fMl5oBSCWubqAwVidQlLJ6QDyr5FSj0F6k+RnzIl/T+4Hlt8NEK8xxwN9x0tUlFTtar6iCDd5ewRDz+6B1nD4lE9tdS7BnDjDvMQXAoN13bE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the affnity level to arm64/arm32
Date: Mon, 31 Oct 2022 15:13:16 +0000
Message-ID: <20221031151326.22634-3-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT062:EE_|CH0PR12MB5172:EE_
X-MS-Office365-Filtering-Correlation-Id: 3810ea97-d708-4244-f7e8-08dabb5289de
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mXatm7IFJ5qHFisGsuFJLLhHFwnaecEWyikHz1EFVtOose/YQ72RjaCW4nM+CXOhz0x2w/ysgztZL7V9s+7aRFylKW8tW629Txl0TNYrZCeAdnVR6Fn7phNM8RP3zy+cgsk+r3BcNQCWkFGw6lgtwcShcJ1I7/OZIyo6dAad7cm35J2Tv5RqzZB+35sixVLXazLQky/ggucVQNJE611X4WikNAuJIlJi8v6U/95T0KtLWThaOEO57lYbHxxcqiyL3Am35nc7ZEo9ERZN0otK3ABC5kNFTi+q/QsWWt2zuPROgcmOdNrgtybS/7ZT7EXRiPEDr0oVCjCpPa9itYXAIyzZdte2/LA+y9W+M8V7zqdGpKDuR06saiCVlNFT7iT+V1hlRIfeoYdXxjJWd7rx1h2yznqoGxd/a+2nJvzjD5moPBf3GAFDjvFzR3izCRp1daIoJVYx7ztEMjduGH/2uFKSLqDmjfGNOQSHlsS7AiHkqu+RG4MwuIACbnvoureDt3TQsj6M2M0DaiVkTyU4qzoC2dOnVfUjJhXvSjFCr5f8MTD+WCSHWm7cyW4d0MDpsC0AH+qoKCgbYX1PWaDXu2Yg9F/jbBUQk8lwtImSRy+E/6rKri+iS/ftYtcVaCkoVciBu5i3Lx/hB+4/k6Jkp/H++6pkSD3P4g8z/huyEXrvYGLQ9g/jtR/xO44OkmD9/2Fula/H9/lrQDYs/PFvXNTM5nOZIsdN1AbWHfWtBgpToX1p27kX6OZYqA8sS4IbFEES38GnUiY90AE3iktmDlcerhtPFp0aBd+bOmRZqCxY1L2g0SBJ0bjBaugtYqibrnTH8dja9VtQ/LsB6JHzfhAHtTbodiSDYiZ9Ef6s87yEi7p4NMFPj8DtQuNfHjuZ
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(36756003)(8936002)(6666004)(70586007)(4326008)(316002)(8676002)(966005)(36860700001)(70206006)(41300700001)(54906003)(6916009)(5660300002)(40480700001)(2906002)(81166007)(356005)(426003)(83380400001)(186003)(478600001)(40460700003)(1076003)(82740400003)(26005)(2616005)(336012)(47076005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:13:59.9900
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3810ea97-d708-4244-f7e8-08dabb5289de
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT062.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5172

Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
include/asm/cputype.h#L14 , for the macros specific for arm64.

Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
asm/cputype.h#L54  , for the macros specific for arm32.

MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit.
For 64 bit :-

 aff_lev3          aff_lev2 aff_lev1 aff_lev0
|________|________|________|________|________|
40       32       24       16       8        0

For 32 bit :-

 aff_lev3 aff_lev2 aff_lev1 aff_lev0
|________|________|________|________|
32       24       16       8        0

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Rearranged the macro defines so that the common code (between arm32
and arm64) is placed in "arm/include/asm/processor.h".

 xen/arch/arm/include/asm/arm32/processor.h | 5 +++++
 xen/arch/arm/include/asm/arm64/processor.h | 8 ++++++++
 xen/arch/arm/include/asm/processor.h       | 6 ------
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/xen/arch/arm/include/asm/arm32/processor.h b/xen/arch/arm/include/asm/arm32/processor.h
index 4e679f3273..82aa7f8d9d 100644
--- a/xen/arch/arm/include/asm/arm32/processor.h
+++ b/xen/arch/arm/include/asm/arm32/processor.h
@@ -56,6 +56,11 @@ struct cpu_user_regs
     uint32_t pad1; /* Doubleword-align the user half of the frame */
 };
 
+/*
+ * Macros to extract affinity level. Picked from kernel
+ */
+#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * (level))
+
 #endif
 
 #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
diff --git a/xen/arch/arm/include/asm/arm64/processor.h b/xen/arch/arm/include/asm/arm64/processor.h
index c749f80ad9..295483a9dd 100644
--- a/xen/arch/arm/include/asm/arm64/processor.h
+++ b/xen/arch/arm/include/asm/arm64/processor.h
@@ -84,6 +84,14 @@ struct cpu_user_regs
     uint64_t sp_el1, elr_el1;
 };
 
+/*
+ * Macros to extract affinity level. picked from kernel
+ */
+#define MPIDR_LEVEL_BITS_SHIFT  3
+
+#define MPIDR_LEVEL_SHIFT(level) \
+         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
+
 #undef __DECL_REG
 
 #endif /* __ASSEMBLY__ */
diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
index 1dd81d7d52..ecfb62bbbe 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -122,13 +122,7 @@
 /*
  * Macros to extract affinity level. picked from kernel
  */
-
-#define MPIDR_LEVEL_BITS_SHIFT  3
 #define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
-
-#define MPIDR_LEVEL_SHIFT(level) \
-         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
-
 #define MPIDR_AFFINITY_LEVEL(mpidr, level) \
          (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:10 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433025.685861 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUM-0000fx-44; Mon, 31 Oct 2022 15:14:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433025.685861; Mon, 31 Oct 2022 15:14:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUL-0000fm-Vm; Mon, 31 Oct 2022 15:14:09 +0000
Received: by outflank-mailman (input) for mailman id 433025;
 Mon, 31 Oct 2022 15:14:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUK-0008Dn-CJ
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:08 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a95c0400-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:07 +0100 (CET)
Received: from MW4P221CA0026.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::31)
 by BL0PR12MB5012.namprd12.prod.outlook.com (2603:10b6:208:1ca::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 15:14:04 +0000
Received: from CO1NAM11FT099.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:8b:cafe::f2) by MW4P221CA0026.outlook.office365.com
 (2603:10b6:303:8b::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:04 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT099.mail.protection.outlook.com (10.13.175.171) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:03 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:01 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 08:14:01 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:00 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a95c0400-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W8TX21sAhjP3nW5WV+2hivONUUCVJZPgdpN600/IGnkldEaHcy2IEZUQdnUrJQNIsxzyCeVudLibomhH3WzEU0z6881J4aiqoV33qegj3+NVZzFSVD59PwzsOcqpD4KnCNOHx8ZLenWUftv1n1mlnvpJ+SZm1WxBlePtelodwSBeCY9sbVKIuXPNaFAxSohzCFJyzVy3RjwMBgSOfQq2GmTCgUGIPVgENmdZFjW7bh6+aFg8iFfwhN4hohjSuP/OLTFAQKO8XCKNMT5Is12Lt/Ef+PiRMht/yNEsZVWd1d8KgXF4QP57i6eRgwHUD7SMI+k+q2TRfs3MxNvnuXt2mA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6WPKgEE6G5c5YDrP4Py1fTMRs9CpcadylX4kzwc3sLM=;
 b=XzvQc3OF0lJZTdDPAfbMWvtjF8CLNj6bBOZSn1L7EOrMhFAP/1kkzydsta3H3iVzdlrCn8vdcCS8vABpMW0NPz9Y/5UZjc2mv4nmXeLbUv0Ig5FXQvO+sQnw39iIjca5ScVkm13FRsTBfRNs5fXDly7Gd3QP9XI9r/pfVLQpBLj50hiwfeN2hUVY2+A7mUWw4SmCAXBtwt/dWNwgyyQXwjeTIzpAHyGi8Avtnu1NoEF969M16d0BT/Im/MuWieEPyFobLdvJpw3xN7XYjh6WN1s0mx3Beyyp9bVcfcnHtyFK/YGo5Y0Oo/nqc4H9c7pXduRa6khAOeZS1Sy5ww+OBA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6WPKgEE6G5c5YDrP4Py1fTMRs9CpcadylX4kzwc3sLM=;
 b=tMwFD+RJmR4xgbBLZWzZqh52y3fjDwpQkLe5blCiCYJlKHo1YPiABeFEZHUVKEE3BHB9NUoia+7uoKQXwm9NZGCaBQ5Wmk8aXue9mTRvazaE7++yHBImlwlnVtQvkXtectMgRoFnvSmPCarueEpA0aRa2KozioppeOdPDYP7Ds4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on Aarch32
Date: Mon, 31 Oct 2022 15:13:17 +0000
Message-ID: <20221031151326.22634-4-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT099:EE_|BL0PR12MB5012:EE_
X-MS-Office365-Filtering-Correlation-Id: 585ad06b-5a1c-49df-3bcc-08dabb528c00
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AQITzW39YdiiWYAHCrloLC8dKy880ND0vdkY+8xBrifbu1Ag+TzJ98exC3krQ4AyQS5idIFyEX/DjTr2CpDKER3uMOPyaYvPk3jlfjKevy7y69Gj0W/mi6oprsmVqDGnbUitmNBt8WAd1J2ueRUuaEWHDUMy2mGAnCQbD/03WY9P2plp52/CaaQ3DLhL7vtm8xGjm/7hZNiGow5+iCVX+Ok4z3VEmnOVY6iUAdJUaWVuEFS28gsDCBmJ3xegctGEfRs85Jh2uWjXs6hZ4kpw75nGGaVBlQFc9qwgwurdcQ5rhlmVvoomOXQQ5fjb7ERf6X15ctUFzZ+Ig4WijIHl1jq8FYert/cXSu5JCdSU/Mx6hdU/th5KhvE6vWP7sbPBCh3V08fmhp2Dzmq5mXHcrArzmsjqSq8704UEedJMC3DmWrUpA+VPo0smZG5kaaJjLrkCmgkfuldinL/epikE2Mw8P5ak1rksDihmx/W/x7RFZWUl6H/W377Bo2ZmuynjWEjlPWQr1ZvQ7jkGf1sWWt3ZsUiQ09iL0JzE6T6HhRZ+CniKB8d0kFpsp4PW0BZXX5WiDXzzzNZTmsLf9eDiEE9i8+pVWrBvOpJswTL95Q26JTKNf8Cjo4uBA7L6zzqsKsPC6bqhnwwvKXWpxZ5kpgydIDvLVzwe8mHLx6jCtkgJmzQwzT4OA7MZch1E2gJnIjaIaVgZJPz2CYtywNcBs+KHVd/uehs2z8IDYT/xEmk7hhKxKTzd6R6OeMTMis51feixqDLRYX94x/BdMfoZGedqRcq2uEdCFamSu8870ek=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(356005)(81166007)(82740400003)(40480700001)(36756003)(2906002)(6666004)(478600001)(70586007)(4326008)(70206006)(316002)(40460700003)(8676002)(5660300002)(6916009)(8936002)(54906003)(41300700001)(82310400005)(36860700001)(186003)(2616005)(26005)(1076003)(47076005)(83380400001)(426003)(336012)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:03.5322
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 585ad06b-5a1c-49df-3bcc-08dabb528c00
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT099.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5012

In some situations (eg GICR_TYPER), the hypervior may need to emulate
64bit registers in aarch32 mode. In such situations, the hypervisor may
need to read/modify the lower or upper 32 bits of the 64 bit register.

In aarch32, 'unsigned long' is 32 bits. Thus, we cannot use it for 64 bit
registers.

The correct approach is to typecast 'mask' based on the size of register access
(ie uint32_t or uint64_t) instead of using 'unsigned long' as it will not
generate the correct mask for the upper 32 bits of a 64 bit register.
Also, 'val' needs to be typecasted so that it can correctly update the upper/
lower 32 bits of a 64 bit register.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Remove vreg_reg_extract(), vreg_reg_update(), vreg_reg_setbits() and
vreg_reg_clearbits(). Moved the implementation to  vreg_reg##sz##_*.
'mask' and 'val' is now using uint##sz##_t.

 xen/arch/arm/include/asm/vreg.h | 88 ++++++++-------------------------
 1 file changed, 20 insertions(+), 68 deletions(-)

diff --git a/xen/arch/arm/include/asm/vreg.h b/xen/arch/arm/include/asm/vreg.h
index f26a70d024..122ea79b65 100644
--- a/xen/arch/arm/include/asm/vreg.h
+++ b/xen/arch/arm/include/asm/vreg.h
@@ -89,107 +89,59 @@ static inline bool vreg_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr
  * The check on the size supported by the register has to be done by
  * the caller of vreg_regN_*.
  *
- * vreg_reg_* should never be called directly. Instead use the vreg_regN_*
- * according to size of the emulated register
- *
  * Note that the alignment fault will always be taken in the guest
  * (see B3.12.7 DDI0406.b).
  */
-static inline register_t vreg_reg_extract(unsigned long reg,
-                                          unsigned int offset,
-                                          enum dabt_size size)
-{
-    reg >>= 8 * offset;
-    reg &= VREG_REG_MASK(size);
-
-    return reg;
-}
-
-static inline void vreg_reg_update(unsigned long *reg, register_t val,
-                                   unsigned int offset,
-                                   enum dabt_size size)
-{
-    unsigned long mask = VREG_REG_MASK(size);
-    int shift = offset * 8;
-
-    *reg &= ~(mask << shift);
-    *reg |= ((unsigned long)val & mask) << shift;
-}
-
-static inline void vreg_reg_setbits(unsigned long *reg, register_t bits,
-                                    unsigned int offset,
-                                    enum dabt_size size)
-{
-    unsigned long mask = VREG_REG_MASK(size);
-    int shift = offset * 8;
-
-    *reg |= ((unsigned long)bits & mask) << shift;
-}
-
-static inline void vreg_reg_clearbits(unsigned long *reg, register_t bits,
-                                      unsigned int offset,
-                                      enum dabt_size size)
-{
-    unsigned long mask = VREG_REG_MASK(size);
-    int shift = offset * 8;
-
-    *reg &= ~(((unsigned long)bits & mask) << shift);
-}
 
 /* N-bit register helpers */
 #define VREG_REG_HELPERS(sz, offmask)                                   \
 static inline register_t vreg_reg##sz##_extract(uint##sz##_t reg,       \
                                                 const mmio_info_t *info)\
 {                                                                       \
-    return vreg_reg_extract(reg, info->gpa & (offmask),                 \
-                            info->dabt.size);                           \
+    unsigned int offset = info->gpa & (offmask);                        \
+                                                                        \
+    reg >>= 8 * offset;                                                 \
+    reg &= VREG_REG_MASK(info->dabt.size);                              \
+                                                                        \
+    return reg;                                                         \
 }                                                                       \
                                                                         \
 static inline void vreg_reg##sz##_update(uint##sz##_t *reg,             \
                                          register_t val,                \
                                          const mmio_info_t *info)       \
 {                                                                       \
-    unsigned long tmp = *reg;                                           \
-                                                                        \
-    vreg_reg_update(&tmp, val, info->gpa & (offmask),                   \
-                    info->dabt.size);                                   \
+    unsigned int offset = info->gpa & (offmask);                        \
+    uint##sz##_t mask = VREG_REG_MASK(info->dabt.size);                 \
+    int shift = offset * 8;                                             \
                                                                         \
-    *reg = tmp;                                                         \
+    *reg &= ~(mask << shift);                                           \
+    *reg |= ((uint##sz##_t)val & mask) << shift;                        \
 }                                                                       \
                                                                         \
 static inline void vreg_reg##sz##_setbits(uint##sz##_t *reg,            \
                                           register_t bits,              \
                                           const mmio_info_t *info)      \
 {                                                                       \
-    unsigned long tmp = *reg;                                           \
-                                                                        \
-    vreg_reg_setbits(&tmp, bits, info->gpa & (offmask),                 \
-                     info->dabt.size);                                  \
+    unsigned int offset = info->gpa & (offmask);                        \
+    uint##sz##_t mask = VREG_REG_MASK(info->dabt.size);                 \
+    int shift = offset * 8;                                             \
                                                                         \
-    *reg = tmp;                                                         \
+    *reg |= ((uint##sz##_t)bits & mask) << shift;                       \
 }                                                                       \
                                                                         \
 static inline void vreg_reg##sz##_clearbits(uint##sz##_t *reg,          \
                                             register_t bits,            \
                                             const mmio_info_t *info)    \
 {                                                                       \
-    unsigned long tmp = *reg;                                           \
+    unsigned int offset = info->gpa & (offmask);                        \
+    uint##sz##_t mask = VREG_REG_MASK(info->dabt.size);                 \
+    int shift = offset * 8;                                             \
                                                                         \
-    vreg_reg_clearbits(&tmp, bits, info->gpa & (offmask),               \
-                       info->dabt.size);                                \
-                                                                        \
-    *reg = tmp;                                                         \
+    *reg &= ~(((uint##sz##_t)bits & mask) << shift);                    \
 }
 
-/*
- * 64 bits registers are only supported on platform with 64-bit long.
- * This is also allow us to optimize the 32 bit case by using
- * unsigned long rather than uint64_t
- */
-#if BITS_PER_LONG == 64
-VREG_REG_HELPERS(64, 0x7);
-#endif
 VREG_REG_HELPERS(32, 0x3);
+VREG_REG_HELPERS(64, 0x7);
 
 #undef VREG_REG_HELPERS
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:11 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433026.685872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUN-0000wk-BJ; Mon, 31 Oct 2022 15:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433026.685872; Mon, 31 Oct 2022 15:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUN-0000wN-7h; Mon, 31 Oct 2022 15:14:11 +0000
Received: by outflank-mailman (input) for mailman id 433026;
 Mon, 31 Oct 2022 15:14:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUL-0008Dn-CL
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:09 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2049.outbound.protection.outlook.com [40.107.223.49])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a96bda4d-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:07 +0100 (CET)
Received: from BN9PR03CA0377.namprd03.prod.outlook.com (2603:10b6:408:f7::22)
 by DM4PR12MB7693.namprd12.prod.outlook.com (2603:10b6:8:103::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Mon, 31 Oct
 2022 15:14:04 +0000
Received: from BN8NAM11FT037.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:f7:cafe::33) by BN9PR03CA0377.outlook.office365.com
 (2603:10b6:408:f7::22) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:04 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT037.mail.protection.outlook.com (10.13.177.182) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:04 +0000
Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:03 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com
 (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 08:14:03 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:02 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a96bda4d-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lIlUhA9nPeUbK08Ns3YM7B4uXNSF8nxw7/7t1MpeUVU8EjQDUEVrPOPvLl3M3/2I8TOISZQaFA2ZtbPkeN9o09VUOPQXiTrlLuo2c+r1Vx3TKjOg0VMjuhPOJyxGc8mgEUvnbU4e6XnKi7/JlZ7dBnulzSFqx+kjFdh5owZOT7e1mxdnF4KNLYECyN2O//W4ImwT51jy2IZMMk0c5p8HGAzxm0SLvIa2/gZWYrhxUqdZVkjogZfGKcKVoDrQ5bQ9CWci9iNERHanZweLr10Fk1Jl1cpas9c6l7/GdDBdq0IAL17PFygz+05dBweJvoFYTp/1w7ahc6E9lPOf9MBg+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uduyDw2PWmugpgiAKKjLksIGjdch+A8RUHeYeJYCGgw=;
 b=mlR0TTZniMcgoeP7M6KxhIj3qVj2jjW8Jn4dAQQbE8w7o7Hv0ilUTMdttMEF5AyQ7UUhEzP/OYHCCsX6V8IZaUnv6PkpOtAUYzqWX4acjBIuqK3/ouB3AEdzuNxOs8fAEnKWmbty+owbmLsZ1lJaItG6ixrCupUM18VBwPJRWovqcn/fHRmS2CYJpnW5c0uXqyllnbA1xQyuuvPgYXP+sl4/nHXlcZYHOirE8WR644zPJOkBHW56SSGwxg+7toCkpH8yjZKkfuA4qPW4UkhprUWowNtdukWM/C6vYZyNRCGGsIfnxRv2uykVgPmGEnit35+vdz9QVqelh+90braqMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uduyDw2PWmugpgiAKKjLksIGjdch+A8RUHeYeJYCGgw=;
 b=TAyRydne170K1XnQr4xiLwr2b04XuzpxZ4XoGi5BwupoP1dBd+GmpZ11k/krJhxjV3IuYSDkufvAp9wiW47dJqpab60yVzmuC8oJArwe9EL8VIM/MWAU9SP8c4W+rdpVeZVGF8y27Z3JHyJq5/fAy4osuTb+Wg/OPGHxPeHuRp4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32
Date: Mon, 31 Oct 2022 15:13:18 +0000
Message-ID: <20221031151326.22634-5-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT037:EE_|DM4PR12MB7693:EE_
X-MS-Office365-Filtering-Correlation-Id: e56154ff-efbd-46f4-d190-08dabb528c47
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zoKfpl6yxS7d8XCNz/5HNEqxpTVgr2uL4pDaEC7r313hUyIunG5TRnY/+ulSkZ8w4Q0DuiMo5A/9zAt8KDl8EhqvoOfVJ5gvCS+KStrg0IA+fmy3h+NB7u3EjqUSD+xkfBpN8mgyJeMy+7jVkfPd16OJ1502juJgXMUr6AExsY3erZQCRPMp7PRkkJDjODVTgz0aSqwMZJdpHI40rClKbKwkqIExYBmnmxjgMCSEz3W7Q/8Qusv5vcIoP7Mxnk+Y5C3ciGKlNus2R4s7PvuJqJsnLeOMYvMIcZmAz2DZbZgzXMJZ4g4dx9BqwVpxVgqmzYne40Mg2tmd8NXqUbhsZKPmEn9DpghkABo/fJfJI/csY3aphkPddGvT8Sd7JXcybq6XbuGgMv53D7b7avx92/8m+I2UTt3cgxzzQ6CDtu7CH50jLXl/obBN/ffobr1pa1BMl6RheNVrXUfhN03P+QijxmxtNaHowN5RIiWsYQDt0ryC2BV6PkSnbQy8bf2+Qjsrky271ZWo6t3M+mwXSjbM5JoqjRKbe/rjBD9UF5MBvqzSY9XHmHliWCHj/OMmyMLpX9Gb2wijWCox1EDzBf414Zjo3Od2qFS4+vPAPfMkn+RF+SgxtjT/gYZIrDeJMj2hJhMr7jxCAwqBzmuwizx/nzGicByxlpD4Tyx+stGYlkSwAPKqM9yuJjNOlrgJ812Xf398tAUwGBmY8mNUgt8N4c2+ZgcScKRjCIRGtVlTLIlwAInfCnLgLD+9Lwtx5+5WGdHSpOsZqbBOZTvJOjFhR9jqpvyIfJn2oM02lS3IRckZPyuikNnk+UQlC2Up
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(136003)(396003)(451199015)(46966006)(36840700001)(40470700004)(54906003)(356005)(478600001)(1076003)(82740400003)(2906002)(81166007)(186003)(6916009)(6666004)(36756003)(316002)(41300700001)(82310400005)(336012)(70586007)(4326008)(8676002)(70206006)(40460700003)(8936002)(26005)(36860700001)(5660300002)(2616005)(47076005)(83380400001)(426003)(40480700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:04.1107
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e56154ff-efbd-46f4-d190-08dabb528c47
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT037.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7693

v->arch.vmpidr is assigned to uint64_t variable. This is to enable left shifts
for Aarch32 so that one can extract affinity bits.
This is then assigned to 'typer' so that the affinity bits form the upper 32 bits.

Refer Arm IHI 0069H ID020922,
The upper 32 bits of GICR_TYPER represent the affinity
whereas the lower 32 bits represent the other bits (eg processor
number, etc).

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
1. v1 - Assigned v->arch.vmpidr to "uint64_t vmpdir". Then, we can use 
MPIDR_AFFINITY_LEVEL macros to extract the affinity value.

 xen/arch/arm/vgic-v3.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 3f4509dcd3..e5e6f2c573 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -191,13 +191,15 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info,
     case VREG64(GICR_TYPER):
     {
         uint64_t typer, aff;
+        uint64_t vmpidr = v->arch.vmpidr;
 
         if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
-        aff = (MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 3) << 56 |
-               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 2) << 48 |
-               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 1) << 40 |
-               MPIDR_AFFINITY_LEVEL(v->arch.vmpidr, 0) << 32);
+        aff = (MPIDR_AFFINITY_LEVEL(vmpidr, 3) << 56 |
+               MPIDR_AFFINITY_LEVEL(vmpidr, 2) << 48 |
+               MPIDR_AFFINITY_LEVEL(vmpidr, 1) << 40 |
+               MPIDR_AFFINITY_LEVEL(vmpidr, 0) << 32);
         typer = aff;
+
         /* We use the VCPU ID as the redistributor ID in bits[23:8] */
         typer |= v->vcpu_id << GICR_TYPER_PROC_NUM_SHIFT;
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:14 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433028.685883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUQ-0001KA-PP; Mon, 31 Oct 2022 15:14:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433028.685883; Mon, 31 Oct 2022 15:14:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUQ-0001Ju-LM; Mon, 31 Oct 2022 15:14:14 +0000
Received: by outflank-mailman (input) for mailman id 433028;
 Mon, 31 Oct 2022 15:14:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUP-0008Dn-Lt
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:13 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2058.outbound.protection.outlook.com [40.107.220.58])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac948e34-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:13 +0100 (CET)
Received: from BN0PR04CA0069.namprd04.prod.outlook.com (2603:10b6:408:ea::14)
 by MW4PR12MB5604.namprd12.prod.outlook.com (2603:10b6:303:18d::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 15:14:09 +0000
Received: from BN8NAM11FT009.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ea:cafe::38) by BN0PR04CA0069.outlook.office365.com
 (2603:10b6:408:ea::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:08 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT009.mail.protection.outlook.com (10.13.176.65) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:08 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:07 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:06 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac948e34-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OeKhL96Zw7e7L9eZ/5IZAaQasBSl4JgavTTGCOKYoaTTt5vAdtlX8o1GD8LfcvbiglShgC95vt8PBjOjNLMuMsmlPioNPwUPgzU7rwIPWBUvLOxMV9E5EwHgHYErv88gqglMJQG53SgUhsCsHseg3NefLjp1ggpXgTfr6mqJA7WSy2AJmOykQnK8m/PdPA1m7ncXM/So013wTjHJi6gts0K9v9Et5nZDYFk5AMpxuzhkXFgPqaqdBQ+azM/bo7JJMdQbOskby0xD6bchr0HgaNMarjlwkYA+LXXi/G3OrFJCfUR1KJHH588yWQiy6lSaCUywVIiVQjB5BqEd5VKWrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/p5jkWoda03qGdQLpQMhA6Pfpa9oQEXMii4oL6oeQfo=;
 b=U4oPUJfOtdvW2Oa9WicG4Zky2xfKt+/t/uVkjBzytdnxqkSxRArx+t5kxz40OrJgPMeJJG9d0zZI6Zm4iJdK4LL0Uu9f3FN4h4LKYehnaNO+Br7PeiKXsPyz8Dv9bT5iCZcZQKmSeQiaS1wi7ZquMHW5xKkO+yJpKB4u8NNUsPNQuDkxcNX+y+7RD9X1XQ8040CdKBawpvQyR+M/hQ15+dkVLI50Ry9242doHQ4n3spf+Y65PB67wijcJR/8Vpzr+bahKBREeJemaKgeu0w4RvGNtcjqsMMO5pIpKtgn9qX9qJyf84R8AM42UaVNXeEyuPEPghVQlSaD2PLYK4KFxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/p5jkWoda03qGdQLpQMhA6Pfpa9oQEXMii4oL6oeQfo=;
 b=iMI4uOWxKrAhPJu2HX9BDpMduKSoEfBMmgpEIfeuT/6L4RhaeT3ponYzGJO5p3DFNcOUyR5JzOpQjAllOHY4gYOYhmwl1j17Dane3v13fzumFlTsKFFt/rlaZOwWHjoIr/wNNKbrQptIVG6RNVn60RfZB7xyqSb3uoG8IXy7ORE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 06/12] xen/Arm: vGICv3: Fix emulation of ICC_SGI1R on AArch32
Date: Mon, 31 Oct 2022 15:13:20 +0000
Message-ID: <20221031151326.22634-7-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT009:EE_|MW4PR12MB5604:EE_
X-MS-Office365-Filtering-Correlation-Id: d3368698-a592-4bf3-fdba-08dabb528f1d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u2zsv+y3hAmCawjxYt94RzsDAytQR4BT5ImykO+zdI1E3ULKBltKQd/WbkXj9yORxH5BTlM69LXuY8tk+xrft47U39Q4hRVIMqVYQcVT0g3adhIpaBBYtjMN0kiU/GlTph7JShBIO/3MGzgWr3ovCS19YQZFTbcT8Ryd0hGGXxkxnTOTycUs5sp/WiTvOimvXikR+CVtv8+95EPlfmOMAV6jgDZqDkjdNgd0CsUKDX9u19PCRxN6zhWQ96oyk77RjD1Mf7C/AVGLVUuvK8m7I7iOkyINw//v4JhKzz1bc62COwHJzK0tvgjUtxz8HzkKHYf1JKnhajQ1HUsNkNe3QQ0jVAtYrE8VuaZv8UW3mNeE7z8EKiT1OZ49YpiMmEwRh7ZW0EtPd8LkuwMa9jD2cmX8/C59OITlfEWCIeA9a3A/v+9vNrcIg71twMTj4O0CXwJ7vitmWi0ViPccxGiKkl3xKowtnSiSv21muL+XqYhyCqCa8k98DHaaWFLuEkt2Tp79NOiToPY+l8fTAKhfnYeQKEotBz4JvMry+S9u9NYPwU06/UXr9fx/nCuA+XdoKIwPINAjD08s6S650lQukIMCb3vig2ZoXMpLsc+h2FGIvGmY9pEGYKV6TY9LcICvCqJAX6yOOoQjlVLl7PsNbh6xZt6AKsESNz2OviK0M07+ycHre1kU5nm5b0VZ0QOpC3DeZdKRAYcahncLe59tGPGXNurEmDBp2Kbns1KgkEoajcukABX49ljp6uxmHr204J0N2Q3YhnnJl/Ngy1ayb08MzEF0a00em9uhKn4symA=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(47076005)(426003)(8936002)(82740400003)(4326008)(83380400001)(5660300002)(4744005)(40460700003)(316002)(2906002)(36756003)(478600001)(70586007)(6666004)(40480700001)(6916009)(54906003)(82310400005)(2616005)(41300700001)(1076003)(336012)(186003)(356005)(26005)(81166007)(8676002)(70206006)(36860700001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:08.8853
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d3368698-a592-4bf3-fdba-08dabb528f1d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT009.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5604

Refer Arm IHI 0069H ID020922, 12.5.23, ICC_SGI1R is a 64 bit register on
Aarch32 systems. Thus, the prototype needs to change to reflect this.
The reason being 'register_t' is defined as 'u32' on AArch32.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Updated the commit message.

 xen/arch/arm/vgic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index e5e6f2c573..1bae76a1e1 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1477,7 +1477,7 @@ write_reserved:
     return 1;
 }
 
-static bool vgic_v3_to_sgi(struct vcpu *v, register_t sgir)
+static bool vgic_v3_to_sgi(struct vcpu *v, uint64_t sgir)
 {
     int virq;
     int irqmode;
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:16 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433029.685894 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUS-0001cU-3o; Mon, 31 Oct 2022 15:14:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433029.685894; Mon, 31 Oct 2022 15:14:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUR-0001bx-W5; Mon, 31 Oct 2022 15:14:15 +0000
Received: by outflank-mailman (input) for mailman id 433029;
 Mon, 31 Oct 2022 15:14:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUR-0001KF-5W
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:15 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2056.outbound.protection.outlook.com [40.107.244.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id adb57d79-592e-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 16:14:13 +0100 (CET)
Received: from BN0PR04CA0068.namprd04.prod.outlook.com (2603:10b6:408:ea::13)
 by PH7PR12MB6587.namprd12.prod.outlook.com (2603:10b6:510:211::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Mon, 31 Oct
 2022 15:14:07 +0000
Received: from BN8NAM11FT009.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:ea:cafe::96) by BN0PR04CA0068.outlook.office365.com
 (2603:10b6:408:ea::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:07 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT009.mail.protection.outlook.com (10.13.176.65) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:07 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:06 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 08:14:05 -0700
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:04 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adb57d79-592e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YWYDt+Z0+ma2pcDsHZ8sruvDwsBN81x9WyPCYEHm/TT/hrWMbPzOgWkfma1mHh+TKMcJPRU+4RDLtMZ2ojiWYoSAB/Q5c2y2798NkncAVkJj9RDmM5DxyaVl7+sVlgIY81x2UFFp6TNZHGLnLi/u6hO87IpEsdsEczeggwBj+MojaAWL5M9nGFq9ADPQDZznNPz5PX+cGHNDqg/VewbcId046Brq8ED5KFweEfPACaO8TpdmxHkloLQmIoh4ceKkJWL30KPxV9TE155pO5zxCLSnxxuFppSeglvNdfAE8ukak56V5u+DKKyooxWtElHp00fbBgxmpQSqWJ2Lrj04mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T2SYspWuKTsvpT2QlqYFUE+9DLCWCRfTo28SXIdKHbk=;
 b=CTpQiRNk0waZEB/63VlNoupnlzMlRYD2ktfz+K7F+JCvnJ0vMGZ23pyB657v74/Qi7oDx8rFB0Vqc5GrCz4W1u8xT+LPAGc+4QgLu/1F9OaLWTX3Os9oitjMsZ4v7G6+YVE2LwfbOFm//MGdeVq1MgdPmOJ2JJhXJUfMI8x9BUcAr4X/ITxdT9FnhRVF0e35FCPXYQz/g36V0PT+hmAVvBedhIW1UH9naa6W09Ktf5BRYVdIiRqaV/WQxTbs70FoiM6+JWx+n1h6BVCQW9hCZ9QDAh2yfrD1OW1xS9TFPgzGvgcjpQkGPa9uYNnjCNMjLigJbfQKOyLDA6QxyqxFKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=T2SYspWuKTsvpT2QlqYFUE+9DLCWCRfTo28SXIdKHbk=;
 b=Gz3rQQEoxM4fbtT86aSjrALBdxSPz+Ps9bqGlPedLHYpAlYoOOEPbiJHeSC1pg+xg745RGEEHYnfpmPxbIuZqNpLWwCxEkUdy+dXeyI2kEd5bO4ex8/y2eXMY8OvjgSfpNWT1UJW0ZF5MxSM03Rwqhd5KcvANDrUnFUDV4Jexl0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 05/12] xen/Arm: GICv3: Fix GICR_{PENDBASER, PROPBASER} emulation on 32-bit host
Date: Mon, 31 Oct 2022 15:13:19 +0000
Message-ID: <20221031151326.22634-6-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT009:EE_|PH7PR12MB6587:EE_
X-MS-Office365-Filtering-Correlation-Id: 307c3c1e-15e8-4f41-aba9-08dabb528e23
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TlK4wcFgSFOPXpOkrK2fIndMYOWSf1ZOelYbkcKkHcNePuXYuKO2U219YIBunza7jxV4y2Lr6lGaj93JJV/mx8tE/m7xckyJdkXg89ASK3JL1zR5h5fCapwfOpupOfSbhdwJqMDZBnl8EJdcGN9quRWKOuWNkDv9L7UqQaC4e1U1IuYneGjgTR2Hxj4WzRsvBu42MWeWe4WWR9WCqfsuWPvezrsy7mMa8vYg6QfBiz9bBjrx/1ChYap2bQGfWxRJK9tyQh8/Gp0O/lFVG5L+eZ+avrYAqkDYCKoKTtbEEGEXd8YMSesH1padbeJ6UolAjkeZ7uaujLIpciLaibEfyAAJb4wYq70PKL3b1AyOU/oe820voKeMBBl3V51S2puSn6j1p3BWq60DplHWeU+I/BIwZooU+tNyvyEMXyl4BnaR/RCQwl53NWqKV2wWZK60c2twSwT4A3wIa6IwCd7aQSvYOLwtJkuBMezFI2Q5rnH5WlRnmSXQf6iAUk3Erfs/HcycHTJ/I+I02hOtvfFluNqMMldIu9ueKZeIRgIFqA+ZkOj9ztxpYmjLMPCmAswjcwCGOL1vidsfg1hzCv69OKhBhQAovJCzmw+0VIHfJXg2jwjZZAuTQekWajvfOILJXJwBjBG+tjA8CYExVkjkUDBjrJSxPAs95anapA4sjENw8LTFKlz8qWT6bgr895QYwpNURmrXSy9ltJ2BJD70i1/yOcVhDSeaI1ecfoV++z/hiUPWdYbJ/KWIavrR1NnLWEKu5YpgJvmt9JifyXqtp+J7FAqOAa1n6fftCO/YDklWldqa/Klom0QOjmjrqajUt0ciq+oGbm8XZG5CQwkY7g==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(82310400005)(81166007)(356005)(26005)(40480700001)(41300700001)(40460700003)(4326008)(8936002)(478600001)(6916009)(36860700001)(5660300002)(966005)(8676002)(70206006)(6666004)(54906003)(70586007)(316002)(2616005)(186003)(36756003)(426003)(47076005)(83380400001)(336012)(1076003)(2906002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:07.2292
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 307c3c1e-15e8-4f41-aba9-08dabb528e23
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT009.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6587

'unsigned long long' is defined as 64 bit across both aarch32 and aarch64.
So, use 'ULL' for 64 bit word instead of UL which is 32 bits for aarch32.
GICR_PENDBASER and GICR_PROPBASER both are 64 bit registers.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from -
v1 - 1. Extract the bug fix for incorrect bit clearing (GICR_PENDBASER_PTZ)
into a separate patch fix.
https://patchwork.kernel.org/project/xen-devel/patch/20221027185555.46125-1-ayankuma@amd.com/

 xen/arch/arm/include/asm/gic_v3_defs.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 728e28d5e5..48a1bc401e 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -134,15 +134,15 @@
 
 #define GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT         56
 #define GICR_PROPBASER_OUTER_CACHEABILITY_MASK               \
-        (7UL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT)
+        (7ULL << GICR_PROPBASER_OUTER_CACHEABILITY_SHIFT)
 #define GICR_PROPBASER_SHAREABILITY_SHIFT               10
 #define GICR_PROPBASER_SHAREABILITY_MASK                     \
-        (3UL << GICR_PROPBASER_SHAREABILITY_SHIFT)
+        (3ULL << GICR_PROPBASER_SHAREABILITY_SHIFT)
 #define GICR_PROPBASER_INNER_CACHEABILITY_SHIFT         7
 #define GICR_PROPBASER_INNER_CACHEABILITY_MASK               \
-        (7UL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT)
+        (7ULL << GICR_PROPBASER_INNER_CACHEABILITY_SHIFT)
 #define GICR_PROPBASER_RES0_MASK                             \
-        (GENMASK(63, 59) | GENMASK(55, 52) | GENMASK(6, 5))
+        (GENMASK_ULL(63, 59) | GENMASK_ULL(55, 52) | GENMASK_ULL(6, 5))
 
 #define GICR_PENDBASER_SHAREABILITY_SHIFT               10
 #define GICR_PENDBASER_INNER_CACHEABILITY_SHIFT         7
@@ -152,11 +152,11 @@
 #define GICR_PENDBASER_INNER_CACHEABILITY_MASK               \
 	(7UL << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT)
 #define GICR_PENDBASER_OUTER_CACHEABILITY_MASK               \
-        (7UL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT)
-#define GICR_PENDBASER_PTZ                              BIT(62, UL)
+        (7ULL << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT)
+#define GICR_PENDBASER_PTZ                              BIT(62, ULL)
 #define GICR_PENDBASER_RES0_MASK                             \
-        (BIT(63, UL) | GENMASK(61, 59) | GENMASK(55, 52) |  \
-         GENMASK(15, 12) | GENMASK(6, 0))
+        (BIT(63, ULL) | GENMASK_ULL(61, 59) | GENMASK_ULL(55, 52) |  \
+         GENMASK_ULL(15, 12) | GENMASK_ULL(6, 0))
 
 #define DEFAULT_PMR_VALUE            0xff
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:18 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433030.685905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUU-00020O-DP; Mon, 31 Oct 2022 15:14:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433030.685905; Mon, 31 Oct 2022 15:14:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUU-0001zw-9c; Mon, 31 Oct 2022 15:14:18 +0000
Received: by outflank-mailman (input) for mailman id 433030;
 Mon, 31 Oct 2022 15:14:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUT-0001KF-7l
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:17 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on2040.outbound.protection.outlook.com [40.107.93.40])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id aec69855-592e-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 16:14:16 +0100 (CET)
Received: from MW4PR04CA0059.namprd04.prod.outlook.com (2603:10b6:303:6a::34)
 by MN2PR12MB4269.namprd12.prod.outlook.com (2603:10b6:208:1d4::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct
 2022 15:14:13 +0000
Received: from CO1NAM11FT083.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:6a:cafe::f6) by MW4PR04CA0059.outlook.office365.com
 (2603:10b6:303:6a::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:13 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT083.mail.protection.outlook.com (10.13.174.92) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:12 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:12 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:10 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aec69855-592e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a383IlnrjGROp5pgfaCK9jSVQJebHe9cCg7QlBvm/R0+gnLgwAT+nOvWikdgx7aqkcGIVdTSc/9XeD86BhiNcMUAnS0tI2RoOBFynxEkDG7bVgcV21mcLXXX6QDXUCPFSZq93bC1vHv/B5eVaKAQhhhm3JhE8T4Ce6KnBc82xz+EciPwFO5tJ9k4q19U0+NhDjFYMSDX15uVJTHy6v3sPU66L+r5tsmudj+9m6gXtTSEucupk1ew2D3lK7y4z4aVeBte8GdDbTvKjBMGTqSiV7i3JPzEb3btwUUCI3SPKBJ/7o89iikYXNt6VOppF/SnPCGuWbJwrpCYjXLSxbVY+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jlEwmM1DJQevh7CK2V8wbq196nWQmioDOKQj3/Ylp8c=;
 b=GvUKvXmlBmi+WHAf606cj3tYuiG3zi2NfTcaEH1ms98KBxABuNN4wuBfcVQBCbEKRV1Lv73mWoRARjdff0cOXuncYbEpEi353EwDWNP2LJKTWVO7JKe2ztLclf29tcTo6h9gTfCRiOx15i8As9/dS3z7pKdv3wlo7sE2bfzQWDw2kNccqKXPy4ojHST2Nbk0VPkWIuYIYMd2iENn7aEtAT9mW+n8wuPTJXybZcekWhKLyAB1WouY+6Ge9eA2Sd/3wQ9JjLVjZScb/5QGY31l2QaA/SKMjookbFwRMFaoIOs8styLZdM63MG5kU66H49niI7NL3TqaJFzUnWczr7ktg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jlEwmM1DJQevh7CK2V8wbq196nWQmioDOKQj3/Ylp8c=;
 b=up8JLIApAe+Ewr+aTNh+ZMoexY/op7TmOhTAznQbAr193RNwVDaj3sZGmCEZ3/QrP14sJ9mrr0viBOwY3gU2tQwnIL9yvh8EEsdW32cAXUW8eVJNO11+0wiUOmCz007X9YyzQbiH2Mq9HPNs2iJt3vD7lq1+FFhFfIVmmelmSzo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 08/12] xen/Arm: GICv3: Define ICH_AP0R<n> and ICH_AP1R<n> for AArch32
Date: Mon, 31 Oct 2022 15:13:22 +0000
Message-ID: <20221031151326.22634-9-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT083:EE_|MN2PR12MB4269:EE_
X-MS-Office365-Filtering-Correlation-Id: 41a2843c-d5d2-4c25-76c8-08dabb52919b
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LUy5XsyIYlw1JIDWF55/M47+iXBehf3BfeMvc22vii0DQSz4tplkBrcaVchEQnBlVxRdt8XS+tJZutIfSHy6nLyhHV9VScfWRwxQZq9kySd0Xp90pKQVuki+kFf3h1j1um13VQ3nqiInFw7tUjX1T8ilQ84iIoBaBsONcLbiM4CdB1jYLMZI0B1y9JXGTblh6od9wov1QLNscxbfIkNERdal/qiAsXIYef4NrbND+AzGhoHP0gQbw8X3djtytoHaUhnUyDQRwxt0hrgUoYnyeuMNDW4IkzXTulLxXqG7KcieX/CxZpggXKs+EJ2EJ/5n3Rp8moy/1NbSxnEWw3r2xMPdDJjaN3zt0M7sod0N8rRbm74wCba8i1Ke3ja7TJfz0+v/x88NOWjRhD29dlJ2RYVUmdBj8q+4TCH6t84MwuVtY4qw/wFJAQvBTuoE634WNFbko7r0DezHHk5YwmGxIt8hOf9xoCV+ulZPv8cyNjfRNF7OrZMZaNDDE1WV9vWWR8QAAHtt/Wd+8vbyQgic0M1OMqhBK/cEpYTZdZcJBeMFEP8Elvay0Hu5KXOUOaPqtjN/nEgT7/TGYZ7nzP/SpTr+AqVZqCEqEeNSlZ/JB5b8U9EqPeMMMQOAvKTocfClO46+XPr2adLfKJNoBausCCX64lKef3lQVWoxqQtQuzyJAl66KkJ7qHF2cdOkiTfuLlfKTFjNHzBr0RF4i5CXb8F1PUxGeyZaO9UnLGs0g4XMc5QvNSewU2s3d9soiVKdCKHALC8buEwBFzYdb09sJsW0+LeVjHkZWmj//yVIRLAtnEQPhX3guqeuxKEpeCO0
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(40470700004)(46966006)(36840700001)(478600001)(6666004)(82310400005)(316002)(54906003)(26005)(6916009)(40480700001)(36860700001)(82740400003)(47076005)(2616005)(336012)(186003)(1076003)(36756003)(83380400001)(356005)(81166007)(40460700003)(426003)(2906002)(4326008)(8676002)(70586007)(70206006)(41300700001)(8936002)(5660300002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:12.9381
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 41a2843c-d5d2-4c25-76c8-08dabb52919b
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT083.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4269

Refer "Arm IHI 0069H ID020922",
12.7.1 - Interrupt Controller Hyp Active Priorities Group0 Registers 0-3
12.7.2 - Interrupt Controller Hyp Active Priorities Group1 Registers 0-3

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Moved coproc register definition to asm/cpregs.h.

 xen/arch/arm/include/asm/arm32/sysregs.h |  1 -
 xen/arch/arm/include/asm/cpregs.h        | 11 +++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
index 8a9a014bef..1b2915a526 100644
--- a/xen/arch/arm/include/asm/arm32/sysregs.h
+++ b/xen/arch/arm/include/asm/arm32/sysregs.h
@@ -81,7 +81,6 @@
 
 /* MVFR2 is not defined on ARMv7 */
 #define MVFR2_MAYBE_UNDEFINED
-
 #endif /* __ASSEMBLY__ */
 
 #endif /* __ASM_ARM_ARM32_SYSREGS_H */
diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h
index 4421dd49ac..bfabee0bc3 100644
--- a/xen/arch/arm/include/asm/cpregs.h
+++ b/xen/arch/arm/include/asm/cpregs.h
@@ -404,6 +404,17 @@
 #define ICH_LRC14_EL2              __LRC8_EL2(6)
 #define ICH_LRC15_EL2              __LRC8_EL2(7)
 
+#define __AP0Rx_EL2(x)            ___CP32(p15,4,c12,c8,x)
+#define ICH_AP0R0_EL2             __AP0Rx_EL2(0)
+#define ICH_AP0R1_EL2             __AP0Rx_EL2(1)
+#define ICH_AP0R2_EL2             __AP0Rx_EL2(2)
+#define ICH_AP0R3_EL2             __AP0Rx_EL2(3)
+
+#define __AP1Rx_EL2(x)            ___CP32(p15,4,c12,c9,x)
+#define ICH_AP1R0_EL2             __AP1Rx_EL2(0)
+#define ICH_AP1R1_EL2             __AP1Rx_EL2(1)
+#define ICH_AP1R2_EL2             __AP1Rx_EL2(2)
+#define ICH_AP1R3_EL2             __AP1Rx_EL2(3)
 #endif
 
 #endif
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:20 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433031.685915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUV-0002KH-Ro; Mon, 31 Oct 2022 15:14:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433031.685915; Mon, 31 Oct 2022 15:14:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUV-0002Hl-Kt; Mon, 31 Oct 2022 15:14:19 +0000
Received: by outflank-mailman (input) for mailman id 433031;
 Mon, 31 Oct 2022 15:14:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUT-0008Dn-Pr
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:18 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2074.outbound.protection.outlook.com [40.107.244.74])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ae4a3503-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:15 +0100 (CET)
Received: from MW4PR04CA0241.namprd04.prod.outlook.com (2603:10b6:303:88::6)
 by BY5PR12MB4321.namprd12.prod.outlook.com (2603:10b6:a03:204::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 15:14:11 +0000
Received: from CO1NAM11FT098.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:88:cafe::39) by MW4PR04CA0241.outlook.office365.com
 (2603:10b6:303:88::6) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:11 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT098.mail.protection.outlook.com (10.13.174.207) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:10 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:09 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:08 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae4a3503-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dto0V7H3b4IL1DVKz4Wqzp0kNxQBw0r4SaEIxl6iGEZYavWnHt1KzVD+8XLfbgAvJw6kAX88AnnDlPa4j8f/5rZ6qrbnCnZhBIKUUcAUHBdL+x9dcuWLR1rkcsAMi28W0N4a/OS9hvXjM+b9msupHuCKjhxTR/1KgiUyaEXHhtmkOptIUEdVJjL2x4yaZjMsZ+1lMECySx3e8JRg6RagjcggkU0Jsy4hd0FjNpxxIfkENauWcpWv5cxm1TdoO7s5KJJkI0LUbYqEPCFKBK4keN+v6ft7f3byVokx7t25o1bpDX5GkhSnKTilJmuUCARUeTJ8lrE2nEXeExnRTCJLJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BI24R+ivZImTUK+YWSPNKctw7x9+YZOXWotaP6tXxI4=;
 b=MZ0MRk88iI2bR5Z+qbLraS204tcqmrsIVpTTWcHDer9pi0iPfxSuGvX2+Yn5UgsrXiCV426PRakfJakc1wtsS+iU5bNt489TIsfa5HEEnmjw6CDVakjoa2wiRJr7C9EtL2Qz/3R+IWonmBr40aNFxdi/GYj12JanuIBsaefzAPhsh3TJZEB9MZuMekaka1N33Hsbby7UCA+pFNri3hfIH0lzCMSl33XgO3e1QGvDjwRt6bYwDQWq2Hn2YRZnLhASnAmLRMs4CMIUf1Og0mSbXHiQO48xgTqPNwb8Npxl20Ut84G0Kn9LoFJ8FNs9+a51h8mx/h+0KSfHLuUAkPvPPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BI24R+ivZImTUK+YWSPNKctw7x9+YZOXWotaP6tXxI4=;
 b=qSAYQKPoPDoSPuZGfW1Oqwq2qqwKvNlAKZ5anGv7rkocDc4xpcsGooUzWOLe/fHF5AH28ghhqHiCqZI9bnf+qZSK+Ne2KRWe60pB0B86gBzgZhotnSSQlHHG6P51pOPCjGKHhB+MvPPfrEyLDX4kM1CFCY3Q6sSGCplRLTt/BjM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 07/12] xen/Arm: GICv3: Define ICH_LR<n>_EL2 on AArch32
Date: Mon, 31 Oct 2022 15:13:21 +0000
Message-ID: <20221031151326.22634-8-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT098:EE_|BY5PR12MB4321:EE_
X-MS-Office365-Filtering-Correlation-Id: 6e574610-819b-45c6-c575-08dabb529060
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X2rRBsFs3DekPivs7MEQrJS4bNOIeyBGUC2GN5S+OLB3JY3TP/miFnsXWeQQBZesnOF3tuPhuTv4VYUJcwMiXLvjIiH2nS6y4an4E/tux4HAeef2gvDFUr7EXs1As/Gnxryr6xZAmJG4XOtk1fLBvTwlUUsuOEFNi8RKOtuFBz7F0D8g2NZD47+wtdJWYiouIsyF+hTONv7lNmtFvZ1OcLAA15KYCoEs4StMBAss87PR+xEl8iwa7LSy+cBsQhi+/sE69QI3PmrhU2qdEopF0TrtYJb4NfiNEKONnsROlzKAv6gMVq+37KNh2l6NQDW+2XLCFdWGXIQ0CmuKdHHvJpseCTlpWznNsu+rCz8iVDxd05/Twyz4abYIPocQjJrJbdT6QO3HP/dBJEkzH2oe4M0mZi8n360djfOnBrfxU4dS560pu8k1sDa4iW2UFgFmNLPx4y1qNdS+3bnMjDPx1Ca1iCX5Wo8hMY7ETDxFgjZyRit1/prJfclf3FhYTkfc6Pn74rTIcXAwYKmeCj9AyQju42rpXjU/L2SSx7h7P3ZSFjNqekT6A/lDGvx9EaiyDQOQa7quEeW5vpGI3zi2OIcbbimGDbnmVC6zGYvMNzw4XlkfNNHxVKvBwgCZ9PhxtPRvhbQLyhJDa0MjsKgpLnavGDqdxcPaGc8N/dnVbldy8dfiUyXE3QdiYrri/vCjAIBsi0g5DC5rLcM7aNG64qEoDSdVSxVvQue3bkfWrv+/oV1PW5gCg05ls5ukPTEEwsZGpDNr/9ejE3kGRovSVSGiBgpNUN6GrLQXbyV6suU=
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(40470700004)(36840700001)(46966006)(81166007)(356005)(82740400003)(36756003)(40460700003)(40480700001)(2906002)(30864003)(6666004)(70586007)(4326008)(316002)(8676002)(478600001)(8936002)(5660300002)(70206006)(6916009)(54906003)(41300700001)(82310400005)(36860700001)(1076003)(186003)(2616005)(26005)(336012)(47076005)(426003)(83380400001)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:10.8757
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e574610-819b-45c6-c575-08dabb529060
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT098.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4321

Refer "Arm IHI 0069H ID020922", 12.4.6, Interrupt Controller List Registers

AArch64 System register ICH_LR<n>_EL2 bits [31:0] are architecturally
mapped to AArch32 System register ICH_LR<n>[31:0].
AArch64 System register ICH_LR<n>_EL2 bits [63:32] are architecturally
mapped to AArch32 System register ICH_LRC<n>[31:0].

Defined ICH_LR<0...15>_EL2 and ICH_LRC<0...15>_EL2 for Aarch32.
For AArch32, the link register is stored as :-
(((uint64_t) ICH_LRC<0...15>_EL2) << 32) | ICH_LR<0...15>_EL2

Also, ICR_LR macros need to be modified as ULL is 64 bits for AArch32 and
AArch64.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Moved the coproc register definitions to asm/cpregs.h.
2. Use GENMASK(31, 0) to represent 0xFFFFFFFF
3. Use READ_CP32()/WRITE_CP32() instead of READ_SYSREG()/WRITE_SYSREG().
4. Multi-line macro definitions should be enclosed within ({ }).

 xen/arch/arm/gic-v3.c                    | 132 +++++++++++------------
 xen/arch/arm/include/asm/arm32/sysregs.h |  17 +++
 xen/arch/arm/include/asm/arm64/sysregs.h |   3 +
 xen/arch/arm/include/asm/cpregs.h        |  42 ++++++++
 xen/arch/arm/include/asm/gic_v3_defs.h   |   6 +-
 5 files changed, 131 insertions(+), 69 deletions(-)

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 018fa0dfa0..8b4b168e78 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -73,37 +73,37 @@ static inline void gicv3_save_lrs(struct vcpu *v)
     switch ( gicv3_info.nr_lrs )
     {
     case 16:
-        v->arch.gic.v3.lr[15] = READ_SYSREG(ICH_LR15_EL2);
+        v->arch.gic.v3.lr[15] = READ_SYSREG_LR(15);
     case 15:
-        v->arch.gic.v3.lr[14] = READ_SYSREG(ICH_LR14_EL2);
+        v->arch.gic.v3.lr[14] = READ_SYSREG_LR(14);
     case 14:
-        v->arch.gic.v3.lr[13] = READ_SYSREG(ICH_LR13_EL2);
+        v->arch.gic.v3.lr[13] = READ_SYSREG_LR(13);
     case 13:
-        v->arch.gic.v3.lr[12] = READ_SYSREG(ICH_LR12_EL2);
+        v->arch.gic.v3.lr[12] = READ_SYSREG_LR(12);
     case 12:
-        v->arch.gic.v3.lr[11] = READ_SYSREG(ICH_LR11_EL2);
+        v->arch.gic.v3.lr[11] = READ_SYSREG_LR(11);
     case 11:
-        v->arch.gic.v3.lr[10] = READ_SYSREG(ICH_LR10_EL2);
+        v->arch.gic.v3.lr[10] = READ_SYSREG_LR(10);
     case 10:
-        v->arch.gic.v3.lr[9] = READ_SYSREG(ICH_LR9_EL2);
+        v->arch.gic.v3.lr[9] = READ_SYSREG_LR(9);
     case 9:
-        v->arch.gic.v3.lr[8] = READ_SYSREG(ICH_LR8_EL2);
+        v->arch.gic.v3.lr[8] = READ_SYSREG_LR(8);
     case 8:
-        v->arch.gic.v3.lr[7] = READ_SYSREG(ICH_LR7_EL2);
+        v->arch.gic.v3.lr[7] = READ_SYSREG_LR(7);
     case 7:
-        v->arch.gic.v3.lr[6] = READ_SYSREG(ICH_LR6_EL2);
+        v->arch.gic.v3.lr[6] = READ_SYSREG_LR(6);
     case 6:
-        v->arch.gic.v3.lr[5] = READ_SYSREG(ICH_LR5_EL2);
+        v->arch.gic.v3.lr[5] = READ_SYSREG_LR(5);
     case 5:
-        v->arch.gic.v3.lr[4] = READ_SYSREG(ICH_LR4_EL2);
+        v->arch.gic.v3.lr[4] = READ_SYSREG_LR(4);
     case 4:
-        v->arch.gic.v3.lr[3] = READ_SYSREG(ICH_LR3_EL2);
+        v->arch.gic.v3.lr[3] = READ_SYSREG_LR(3);
     case 3:
-        v->arch.gic.v3.lr[2] = READ_SYSREG(ICH_LR2_EL2);
+        v->arch.gic.v3.lr[2] = READ_SYSREG_LR(2);
     case 2:
-        v->arch.gic.v3.lr[1] = READ_SYSREG(ICH_LR1_EL2);
+        v->arch.gic.v3.lr[1] = READ_SYSREG_LR(1);
     case 1:
-         v->arch.gic.v3.lr[0] = READ_SYSREG(ICH_LR0_EL2);
+         v->arch.gic.v3.lr[0] = READ_SYSREG_LR(0);
          break;
     default:
          BUG();
@@ -120,37 +120,37 @@ static inline void gicv3_restore_lrs(const struct vcpu *v)
     switch ( gicv3_info.nr_lrs )
     {
     case 16:
-        WRITE_SYSREG(v->arch.gic.v3.lr[15], ICH_LR15_EL2);
+        WRITE_SYSREG_LR(15, v->arch.gic.v3.lr[15]);
     case 15:
-        WRITE_SYSREG(v->arch.gic.v3.lr[14], ICH_LR14_EL2);
+        WRITE_SYSREG_LR(14, v->arch.gic.v3.lr[14]);
     case 14:
-        WRITE_SYSREG(v->arch.gic.v3.lr[13], ICH_LR13_EL2);
+        WRITE_SYSREG_LR(13, v->arch.gic.v3.lr[13]);
     case 13:
-        WRITE_SYSREG(v->arch.gic.v3.lr[12], ICH_LR12_EL2);
+        WRITE_SYSREG_LR(12, v->arch.gic.v3.lr[12]);
     case 12:
-        WRITE_SYSREG(v->arch.gic.v3.lr[11], ICH_LR11_EL2);
+        WRITE_SYSREG_LR(11, v->arch.gic.v3.lr[11]);
     case 11:
-        WRITE_SYSREG(v->arch.gic.v3.lr[10], ICH_LR10_EL2);
+        WRITE_SYSREG_LR(10, v->arch.gic.v3.lr[10]);
     case 10:
-        WRITE_SYSREG(v->arch.gic.v3.lr[9], ICH_LR9_EL2);
+        WRITE_SYSREG_LR(9, v->arch.gic.v3.lr[9]);
     case 9:
-        WRITE_SYSREG(v->arch.gic.v3.lr[8], ICH_LR8_EL2);
+        WRITE_SYSREG_LR(8, v->arch.gic.v3.lr[8]);
     case 8:
-        WRITE_SYSREG(v->arch.gic.v3.lr[7], ICH_LR7_EL2);
+        WRITE_SYSREG_LR(7, v->arch.gic.v3.lr[7]);
     case 7:
-        WRITE_SYSREG(v->arch.gic.v3.lr[6], ICH_LR6_EL2);
+        WRITE_SYSREG_LR(6, v->arch.gic.v3.lr[6]);
     case 6:
-        WRITE_SYSREG(v->arch.gic.v3.lr[5], ICH_LR5_EL2);
+        WRITE_SYSREG_LR(5, v->arch.gic.v3.lr[5]);
     case 5:
-        WRITE_SYSREG(v->arch.gic.v3.lr[4], ICH_LR4_EL2);
+        WRITE_SYSREG_LR(4, v->arch.gic.v3.lr[4]);
     case 4:
-        WRITE_SYSREG(v->arch.gic.v3.lr[3], ICH_LR3_EL2);
+        WRITE_SYSREG_LR(3, v->arch.gic.v3.lr[3]);
     case 3:
-        WRITE_SYSREG(v->arch.gic.v3.lr[2], ICH_LR2_EL2);
+        WRITE_SYSREG_LR(2, v->arch.gic.v3.lr[2]);
     case 2:
-        WRITE_SYSREG(v->arch.gic.v3.lr[1], ICH_LR1_EL2);
+        WRITE_SYSREG_LR(1, v->arch.gic.v3.lr[1]);
     case 1:
-        WRITE_SYSREG(v->arch.gic.v3.lr[0], ICH_LR0_EL2);
+        WRITE_SYSREG_LR(0, v->arch.gic.v3.lr[0]);
         break;
     default:
          BUG();
@@ -161,22 +161,22 @@ static uint64_t gicv3_ich_read_lr(int lr)
 {
     switch ( lr )
     {
-    case 0: return READ_SYSREG(ICH_LR0_EL2);
-    case 1: return READ_SYSREG(ICH_LR1_EL2);
-    case 2: return READ_SYSREG(ICH_LR2_EL2);
-    case 3: return READ_SYSREG(ICH_LR3_EL2);
-    case 4: return READ_SYSREG(ICH_LR4_EL2);
-    case 5: return READ_SYSREG(ICH_LR5_EL2);
-    case 6: return READ_SYSREG(ICH_LR6_EL2);
-    case 7: return READ_SYSREG(ICH_LR7_EL2);
-    case 8: return READ_SYSREG(ICH_LR8_EL2);
-    case 9: return READ_SYSREG(ICH_LR9_EL2);
-    case 10: return READ_SYSREG(ICH_LR10_EL2);
-    case 11: return READ_SYSREG(ICH_LR11_EL2);
-    case 12: return READ_SYSREG(ICH_LR12_EL2);
-    case 13: return READ_SYSREG(ICH_LR13_EL2);
-    case 14: return READ_SYSREG(ICH_LR14_EL2);
-    case 15: return READ_SYSREG(ICH_LR15_EL2);
+    case 0: return READ_SYSREG_LR(0);
+    case 1: return READ_SYSREG_LR(1);
+    case 2: return READ_SYSREG_LR(2);
+    case 3: return READ_SYSREG_LR(3);
+    case 4: return READ_SYSREG_LR(4);
+    case 5: return READ_SYSREG_LR(5);
+    case 6: return READ_SYSREG_LR(6);
+    case 7: return READ_SYSREG_LR(7);
+    case 8: return READ_SYSREG_LR(8);
+    case 9: return READ_SYSREG_LR(9);
+    case 10: return READ_SYSREG_LR(10);
+    case 11: return READ_SYSREG_LR(11);
+    case 12: return READ_SYSREG_LR(12);
+    case 13: return READ_SYSREG_LR(13);
+    case 14: return READ_SYSREG_LR(14);
+    case 15: return READ_SYSREG_LR(15);
     default:
         BUG();
     }
@@ -187,52 +187,52 @@ static void gicv3_ich_write_lr(int lr, uint64_t val)
     switch ( lr )
     {
     case 0:
-        WRITE_SYSREG(val, ICH_LR0_EL2);
+        WRITE_SYSREG_LR(0, val);
         break;
     case 1:
-        WRITE_SYSREG(val, ICH_LR1_EL2);
+        WRITE_SYSREG_LR(1, val);
         break;
     case 2:
-        WRITE_SYSREG(val, ICH_LR2_EL2);
+        WRITE_SYSREG_LR(2, val);
         break;
     case 3:
-        WRITE_SYSREG(val, ICH_LR3_EL2);
+        WRITE_SYSREG_LR(3, val);
         break;
     case 4:
-        WRITE_SYSREG(val, ICH_LR4_EL2);
+        WRITE_SYSREG_LR(4, val);
         break;
     case 5:
-        WRITE_SYSREG(val, ICH_LR5_EL2);
+        WRITE_SYSREG_LR(5, val);
         break;
     case 6:
-        WRITE_SYSREG(val, ICH_LR6_EL2);
+        WRITE_SYSREG_LR(6, val);
         break;
     case 7:
-        WRITE_SYSREG(val, ICH_LR7_EL2);
+        WRITE_SYSREG_LR(7, val);
         break;
     case 8:
-        WRITE_SYSREG(val, ICH_LR8_EL2);
+        WRITE_SYSREG_LR(8, val);
         break;
     case 9:
-        WRITE_SYSREG(val, ICH_LR9_EL2);
+        WRITE_SYSREG_LR(9, val);
         break;
     case 10:
-        WRITE_SYSREG(val, ICH_LR10_EL2);
+        WRITE_SYSREG_LR(10, val);
         break;
     case 11:
-        WRITE_SYSREG(val, ICH_LR11_EL2);
+        WRITE_SYSREG_LR(11, val);
         break;
     case 12:
-        WRITE_SYSREG(val, ICH_LR12_EL2);
+        WRITE_SYSREG_LR(12, val);
         break;
     case 13:
-        WRITE_SYSREG(val, ICH_LR13_EL2);
+        WRITE_SYSREG_LR(13, val);
         break;
     case 14:
-        WRITE_SYSREG(val, ICH_LR14_EL2);
+        WRITE_SYSREG_LR(14, val);
         break;
     case 15:
-        WRITE_SYSREG(val, ICH_LR15_EL2);
+        WRITE_SYSREG_LR(15, val);
         break;
     default:
         return;
@@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v)
     if ( v == current )
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   HW_LR[%d]=%lx\n", i, gicv3_ich_read_lr(i));
+            printk("   HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i));
     }
     else
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   VCPU_LR[%d]=%lx\n", i, v->arch.gic.v3.lr[i]);
+            printk("   VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]);
     }
 }
 
diff --git a/xen/arch/arm/include/asm/arm32/sysregs.h b/xen/arch/arm/include/asm/arm32/sysregs.h
index 6841d5de43..8a9a014bef 100644
--- a/xen/arch/arm/include/asm/arm32/sysregs.h
+++ b/xen/arch/arm/include/asm/arm32/sysregs.h
@@ -62,6 +62,23 @@
 #define READ_SYSREG(R...)       READ_SYSREG32(R)
 #define WRITE_SYSREG(V, R...)   WRITE_SYSREG32(V, R)
 
+#define ICH_LR_REG(INDEX)        ICH_LR ## INDEX ## _EL2
+#define ICH_LRC_REG(INDEX)       ICH_LRC ## INDEX ## _EL2
+
+#define READ_SYSREG_LR(INDEX)    ({                         \
+    uint64_t _val;                                          \
+    uint32_t _lrc = READ_CP32(ICH_LRC_REG(INDEX));          \
+    uint32_t _lr = READ_CP32(ICH_LR_REG(INDEX));            \
+                                                            \
+    _val = ((uint64_t) _lrc << 32) | _lr;                   \
+    _val; })
+
+#define WRITE_SYSREG_LR(INDEX, V) ({                        \
+    uint64_t _val = (V);                                    \
+    WRITE_CP32(_val & GENMASK(31, 0), ICH_LR_REG(INDEX)); \
+    WRITE_CP32(_val >> 32, ICH_LRC_REG(INDEX));           \
+});
+
 /* MVFR2 is not defined on ARMv7 */
 #define MVFR2_MAYBE_UNDEFINED
 
diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h
index 54670084c3..353f0eea29 100644
--- a/xen/arch/arm/include/asm/arm64/sysregs.h
+++ b/xen/arch/arm/include/asm/arm64/sysregs.h
@@ -471,6 +471,9 @@
 
 #define READ_SYSREG(name)     READ_SYSREG64(name)
 #define WRITE_SYSREG(v, name) WRITE_SYSREG64(v, name)
+#define ICH_LR_REG(index)          ICH_LR ## index ## _EL2
+#define WRITE_SYSREG_LR(index, v)  WRITE_SYSREG(v, ICH_LR_REG(index))
+#define READ_SYSREG_LR(index)      READ_SYSREG(ICH_LR_REG(index))
 
 #endif /* _ASM_ARM_ARM64_SYSREGS_H */
 
diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h
index 6daf2b1a30..4421dd49ac 100644
--- a/xen/arch/arm/include/asm/cpregs.h
+++ b/xen/arch/arm/include/asm/cpregs.h
@@ -362,6 +362,48 @@
 #define MVFR0_EL1               MVFR0
 #define MVFR1_EL1               MVFR1
 #define MVFR2_EL1               MVFR2
+
+#define ___CP32(a,b,c,d,e)        a,b,c,d,e
+#define __LR0_EL2(x)              ___CP32(p15,4,c12,c12,x)
+#define __LR8_EL2(x)              ___CP32(p15,4,c12,c13,x)
+
+#define __LRC0_EL2(x)             ___CP32(p15,4,c12,c14,x)
+#define __LRC8_EL2(x)             ___CP32(p15,4,c12,c15,x)
+
+#define ICH_LR0_EL2               __LR0_EL2(0)
+#define ICH_LR1_EL2               __LR0_EL2(1)
+#define ICH_LR2_EL2               __LR0_EL2(2)
+#define ICH_LR3_EL2               __LR0_EL2(3)
+#define ICH_LR4_EL2               __LR0_EL2(4)
+#define ICH_LR5_EL2               __LR0_EL2(5)
+#define ICH_LR6_EL2               __LR0_EL2(6)
+#define ICH_LR7_EL2               __LR0_EL2(7)
+#define ICH_LR8_EL2               __LR8_EL2(0)
+#define ICH_LR9_EL2               __LR8_EL2(1)
+#define ICH_LR10_EL2              __LR8_EL2(2)
+#define ICH_LR11_EL2              __LR8_EL2(3)
+#define ICH_LR12_EL2              __LR8_EL2(4)
+#define ICH_LR13_EL2              __LR8_EL2(5)
+#define ICH_LR14_EL2              __LR8_EL2(6)
+#define ICH_LR15_EL2              __LR8_EL2(7)
+
+#define ICH_LRC0_EL2               __LRC0_EL2(0)
+#define ICH_LRC1_EL2               __LRC0_EL2(1)
+#define ICH_LRC2_EL2               __LRC0_EL2(2)
+#define ICH_LRC3_EL2               __LRC0_EL2(3)
+#define ICH_LRC4_EL2               __LRC0_EL2(4)
+#define ICH_LRC5_EL2               __LRC0_EL2(5)
+#define ICH_LRC6_EL2               __LRC0_EL2(6)
+#define ICH_LRC7_EL2               __LRC0_EL2(7)
+#define ICH_LRC8_EL2               __LRC8_EL2(0)
+#define ICH_LRC9_EL2               __LRC8_EL2(1)
+#define ICH_LRC10_EL2              __LRC8_EL2(2)
+#define ICH_LRC11_EL2              __LRC8_EL2(3)
+#define ICH_LRC12_EL2              __LRC8_EL2(4)
+#define ICH_LRC13_EL2              __LRC8_EL2(5)
+#define ICH_LRC14_EL2              __LRC8_EL2(6)
+#define ICH_LRC15_EL2              __LRC8_EL2(7)
+
 #endif
 
 #endif
diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 48a1bc401e..87115f8b25 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -185,9 +185,9 @@
 #define ICH_LR_HW_SHIFT              61
 #define ICH_LR_GRP_MASK              0x1
 #define ICH_LR_GRP_SHIFT             60
-#define ICH_LR_MAINTENANCE_IRQ       (1UL<<41)
-#define ICH_LR_GRP1                  (1UL<<60)
-#define ICH_LR_HW                    (1UL<<61)
+#define ICH_LR_MAINTENANCE_IRQ       (1ULL<<41)
+#define ICH_LR_GRP1                  (1ULL<<60)
+#define ICH_LR_HW                    (1ULL<<61)
 
 #define ICH_VTR_NRLRGS               0x3f
 #define ICH_VTR_PRIBITS_MASK         0x7
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:21 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433034.685927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUX-0002ll-KW; Mon, 31 Oct 2022 15:14:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433034.685927; Mon, 31 Oct 2022 15:14:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUX-0002lQ-Dn; Mon, 31 Oct 2022 15:14:21 +0000
Received: by outflank-mailman (input) for mailman id 433034;
 Mon, 31 Oct 2022 15:14:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUV-0008Dn-Sd
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:19 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2043.outbound.protection.outlook.com [40.107.94.43])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afa5b701-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:18 +0100 (CET)
Received: from BN9PR03CA0865.namprd03.prod.outlook.com (2603:10b6:408:13d::30)
 by SA0PR12MB4445.namprd12.prod.outlook.com (2603:10b6:806:95::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 15:14:14 +0000
Received: from BN8NAM11FT058.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:13d:cafe::e3) by BN9PR03CA0865.outlook.office365.com
 (2603:10b6:408:13d::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:14 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT058.mail.protection.outlook.com (10.13.177.58) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:14 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:14 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:12 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afa5b701-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WkOKEKyXVKYXDOzx/YhjjaD/xQ2ZqNNtuWIZ+6K9xNnfsiMAJfN2ElTcyhrTvsMbnCJxKWWWbBP3W1eweQEvpx5ZJOgSBf9AgTrWaTXwBj+iuzEoIMz8JJYM7K/FPeM/cnBJToCmQCCu93GuOcBbsjWOW4gYUoBmwynBtZ9bUW1aD8T57VXNLIvx76zpWnQeiUb2k06e0CTjVMO4IH5DXATL812Ee7dBjn0Unz0rADWW/pQ3UKJvIYEK7Hs6qaeo7/Mh2ARUv5hwHWoO+TPEgefTzJzD7PNdGRsbt5jT3HXDNVd50YLf6aHzcuBKf+6uyEDsBbWxTx/9iuMljN5E5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ao6qIVyVbVJ+PXnUTss4wnvdQgwpAL4Cyg3ESb6Dh/4=;
 b=SadsscYPwyteA5kvGJioADb8Roo7LZXHWKRzOoYx5ksqJUg1HP/nEhUx9wNtpvqLDQQij+99+RMxyzNJEMNaAcuVUKP45cU4zBUrgs7lj4osTHAIr8+2M0J2WLWGoQLv+KFZAlcXvOfaxvKXpv6/5L6PQaWmLIm4Gv2sQy2qzja6OY59jo2U1lCcCO5K4D1PRBVlkZaAYqWjeAqm5TgEnt/SvE8vIPcmgqKt652urw//PhTCAs3Tif7ICgTPbhRdsk5q6zweX2B+M5VLa+DwPynrlEFAosEiNKRoFPFdSNkO7EGjpK+HFs+xWrKFRmuffGtkodgFlQKJ84MiFV5ofw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ao6qIVyVbVJ+PXnUTss4wnvdQgwpAL4Cyg3ESb6Dh/4=;
 b=ewThn8O7nX+nFQdCdPkAfTDLG39AqxwpDvczZu5PAwlF5Omb+RASdx5w1GD/srM1BsWw5yH+iUlJKZReD5O7zZ6YcbDs5jPryYWELxsji640MHvUhuU/kc5PLYR5lKPNX5T9Daa3DQeLlvRfKlilCc2ihTXUFewKv1chiPxTc98=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 09/12] xen/Arm: GICv3: Define GIC registers for AArch32
Date: Mon, 31 Oct 2022 15:13:23 +0000
Message-ID: <20221031151326.22634-10-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT058:EE_|SA0PR12MB4445:EE_
X-MS-Office365-Filtering-Correlation-Id: 15361d85-abd4-4b4a-d8c0-08dabb529286
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Rtzy1kiD28sIrq5SEZteyYBkdydYraRp38SewTdraALTgVkpVHygHuQOyBWDFbYkpxDU/YOEUO56bHZp0qKO7JEDQS5eL0No7MIabba1uXDcsLXpzIev+juHqODKHzwc9CgOZ/5FxuSEnhRv4hDDNyZECBs2G6bmVJsPFQhkWLtdS9NlG46XevHYdEx/kvhlxS3yVOhKSm96GSYYYcyi0rO9xCVHz+JtaD8waNH6XGnzaxRp4p6YCm3WF05wuEElxwbpO2SB68tE5s7umekUgNIivOvHZhczT6Hpr0HKMzlQ1nGaxQBZTUkFGjDGxCRzXEW6avr7SSsd32GBBSYBQpuni4SO03fZ+AWTeFq+067EC8x0CLT6EbPtL/SX8r0QtHg9nqSFFTG7gsqtyNsYtchiCbootIGZsmQ5IKbnqY5YRdzDLpQI56znvxp7sTFa1VsIqF2sClycndosuHEJvd8xzftOODZhWAiWGeqegdTl2tNxqRynQbRp8AtoQHU8pQx5tO7i2d7mkM3SO2jeJj7O1tzNQuSDEeZtCQzu+5eSYE2IPyPqojivHyEo9wxqLS15+Ui+bhZxVlAf/3sCLWiWvL4Y5mSnWCwoN8kYvuvAhFYoRuH6d7Ar1mukL09OPeh4Ep1uC6KGnfxykV7qi13I2KB6FTgDzPXT0Pj0yflNCFGQH1vmj1aA5Kxjapyr83nGXVLS9suzuy3R4eO8oYIGYEoUaJlCxbMxIETR0iSc5/etP2x9L4ulJFWoKxcPnrluBU9C2VxkOmoitk2+uG7TgJgeaUoGM1PoVutIuSKeikqSb00OzJTsd7bah/eB
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(83380400001)(82740400003)(478600001)(426003)(47076005)(2906002)(336012)(36860700001)(356005)(70206006)(70586007)(8676002)(40480700001)(81166007)(4326008)(82310400005)(2616005)(1076003)(186003)(36756003)(41300700001)(26005)(54906003)(40460700003)(6916009)(316002)(5660300002)(8936002)(6666004)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:14.5901
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 15361d85-abd4-4b4a-d8c0-08dabb529286
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT058.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4445

Refer "Arm IHI 0069H ID020922"
12.5.23 ICC_SGI1R, Interrupt Controller Software Generated Interrupt
Group 1 Register
12.5.12 ICC_HSRE, Interrupt Controller Hyp System Register Enable register
12.7.10 ICH_VTR, Interrupt Controller VGIC Type Register
12.7.5 ICH_HCR, Interrupt Controller Hyp Control Register
12.5.20 ICC_PMR, Interrupt Controller Interrupt Priority Mask Register
12.5.24 ICC_SRE, Interrupt Controller System Register Enable register
12.5.7 ICC_DIR, Interrupt Controller Deactivate Interrupt Register
12.5.9 ICC_EOIR1, Interrupt Controller End Of Interrupt Register 1
12.5.14 ICC_IAR1, Interrupt Controller Interrupt Acknowledge Register 1
12.5.5 ICC_BPR1, Interrupt Controller Binary Point Register 1
12.5.6 ICC_CTLR, Interrupt Controller Control Register
12.5.16 ICC_IGRPEN1, Interrupt Controller Interrupt Group 1 Enable register
12.7.9 ICH_VMCR, Interrupt Controller Virtual Machine Control Register

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Moved coproc regs definition to asm/cpregs.h

 xen/arch/arm/include/asm/cpregs.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h
index bfabee0bc3..62b63f4cef 100644
--- a/xen/arch/arm/include/asm/cpregs.h
+++ b/xen/arch/arm/include/asm/cpregs.h
@@ -415,6 +415,22 @@
 #define ICH_AP1R1_EL2             __AP1Rx_EL2(1)
 #define ICH_AP1R2_EL2             __AP1Rx_EL2(2)
 #define ICH_AP1R3_EL2             __AP1Rx_EL2(3)
+
+#define ICC_SGI1R_EL1             p15,0,c12
+
+#define ICC_SRE_EL2               p15,4,c12,c9,5
+#define ICH_VTR_EL2               p15,4,c12,c11,1
+#define ICH_HCR_EL2               p15,4,c12,c11,0
+
+#define ICC_PMR_EL1               p15,0,c4,c6,0
+#define ICC_SRE_EL1               p15,0,c12,c12,5
+#define ICC_DIR_EL1               p15,0,c12,c11,1
+#define ICC_EOIR1_EL1             p15,0,c12,c12,1
+#define ICC_IAR1_EL1              p15,0,c12,c12,0
+#define ICC_BPR1_EL1              p15,0,c12,c12,3
+#define ICC_CTLR_EL1              p15,0,c12,c12,4
+#define ICC_IGRPEN1_EL1           p15,0,c12,c12,7
+#define ICH_VMCR_EL2              p15,4,c12,c11,7
 #endif
 
 #endif
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433035.685938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUa-0003Lf-Uc; Mon, 31 Oct 2022 15:14:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433035.685938; Mon, 31 Oct 2022 15:14:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUa-0003LU-RR; Mon, 31 Oct 2022 15:14:24 +0000
Received: by outflank-mailman (input) for mailman id 433035;
 Mon, 31 Oct 2022 15:14:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUZ-0001KF-M2
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:23 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2080.outbound.protection.outlook.com [40.107.237.80])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b2b33758-592e-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 16:14:23 +0100 (CET)
Received: from BN8PR03CA0029.namprd03.prod.outlook.com (2603:10b6:408:94::42)
 by SJ1PR12MB6219.namprd12.prod.outlook.com (2603:10b6:a03:456::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 15:14:20 +0000
Received: from BN8NAM11FT114.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:94:cafe::af) by BN8PR03CA0029.outlook.office365.com
 (2603:10b6:408:94::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:19 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT114.mail.protection.outlook.com (10.13.177.46) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:19 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:18 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:17 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2b33758-592e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eNFufZ3uYA95z5tMniuK6MgVCrzABkjx0bI3JozzpL+fABa2pcd22E01oM4FXLXhctsxTfkx2oPDvmBwwHF9C1rA8tsRZK+HCd4bjWlFNKRfHIWeph0sE8tPKgKOQInaUNyqQq38cIbLow3e6eMCH7DJLnS2aWeMPw0iKiIUyRmO56CfC0NXNgOfzdBWqRTHunS5/JQzDCc48BnMMvc+Ht3CQDNdfM181mG4302cGlX6d3R6S7km6gX+v+iyXd10cqF757bWQbQLxsfH2rS/wl+G8Ehg73mTuaa1RZidfxc4apMKZm6AIf/MXvLo9/Kw7tSiV2w2Lr7ugjncZpqZoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ssqD6eDVxRSMIkTCVK1fqChl6nBTtHT7TooGtjeWbYQ=;
 b=AHQ9BwiBrtLXD4Par8Ov/NxBF46Gq7qIQqAVXDaeI+b2m/OcXkzxjU8ebjzlycPW3d79uqokO9/ib7hCuR40iApG6hV+fVWBikQ5ydW//6Cj3dkGxjOAU367qnGJeyHgPJACAoub0QOhOqxU/eLHdTIuT36pk+Jkg+d5KET2plpSKV+yK92Jdvp4V5Bxh8APDOS90dWynfmceaQzlLrev6wONYSMQEpjhxuWJUCvuQeuCh6ZN4i7cf3oOOcXnsN/p29BEvgPXdOZoiayYcbV3l15RX19FdC/HEf/0lPxZDtGlHM+G+a6mYzdzSVJbLjDfY1gaxiCcPP8pobhgi0nlw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ssqD6eDVxRSMIkTCVK1fqChl6nBTtHT7TooGtjeWbYQ=;
 b=hJ3UsfOE72xPkF5jbTBmX4nVQYDdF8SxPgtacMWTrmCto0JBzXD/sWvshtqllF7h1jABVvecCqLE9Ur2f+k9ueI3JxDMjWB6U8r9EMC6p+4TmPO+hBYTPWcYz0ekPEyGU3cNZp1GIo1JNnqV+xfuXwt7d73Re3gFIFy8d2Xur9Q=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 11/12] xen/Arm: GICv3: Define macros to read/write 64 bit
Date: Mon, 31 Oct 2022 15:13:25 +0000
Message-ID: <20221031151326.22634-12-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT114:EE_|SJ1PR12MB6219:EE_
X-MS-Office365-Filtering-Correlation-Id: 817997c4-64d5-4f93-355f-08dabb529557
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	m4PCC5K6hhyznZfO+zO0ygAnQgAt+px1ZRTWOx9cBxJVifT8n2rD7kBxROJbNlNFE15FiBBfXLKiPfLEnkUGS0mI8O0z5YQPA7c6SvaBYZ58gsF39ZWAROquTF6YG5igIZE2NgGvlUz5TskZwY9ZnFbZALIk3QK20+NjqHQuu7VT7BdU/XTCi65uVwT9QY4YXYlXzTlTIP0WEwjxMAY7HxLwMr+rSEcTgE5hi7iQ30ZB/PD2bQiQKuCyppUi/lasgHgSqq1lRP1PAMXLba7eC8F+GcNuo52HvYcq8EzjJIGQdVEz3k767SMuK7x83Mh7PZ5M7A0PfJFPwe5iV3uqfwXQ+VREzUdqQjz96Hf2CcC0fxxqytoxNyCYcelGeXQ0keySbCxPEZACPyUNEYCEvnhkN+yro0oQt2uZCJisreC6Baapx1BvFiD2TKiP+qT1qJwmFbtzZEJDyFeN2G2RNcJ2opdGZd7fbzrTN76fxMGKDwmXrA5DmJoLB9fLelZchI8MPb4AAI2skk8DMnSGP0D6B1NSzPqmn4tBeY1Y/SFnOABBaMKk36fRs65qage2R9UrUxay8T33UHoih60zj1ZqdzfvhLOKhb6hBIJUPy6wEpRPnmkywbXLHqKl0MERf+8JH9zjMAM4lARYAEFXhGkTyKfMpp43VyxS9EiWYZablWCWv/1k3XpNNWzPnJF8iJJQ29FYR28aP4PlT+g+Qohc8XdPjAArOY99N4FydatLl8z0TL92yACfceR5SIuYFdM1TXSeYVFLt0dTl8x5ESPyiWLhaO5x+SqenP6jof7WjTb4uLWRPlv0aUXZdzP6
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(70586007)(70206006)(8676002)(54906003)(316002)(6916009)(36860700001)(356005)(81166007)(83380400001)(2906002)(36756003)(478600001)(1076003)(8936002)(40480700001)(41300700001)(5660300002)(4326008)(336012)(2616005)(186003)(40460700003)(82740400003)(426003)(6666004)(47076005)(26005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:19.3110
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 817997c4-64d5-4f93-355f-08dabb529557
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT114.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6219

Defined readq_relaxed()/writeq_relaxed() to read and write 64 bit regs.
This uses ldrd/strd instructions.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changes from :-
v1 - 1. Use ldrd/strd for readq_relaxed()/writeq_relaxed().
2. No need to use le64_to_cpu() as the returned byte order is already in cpu
endianess.

 xen/arch/arm/include/asm/arm32/io.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/xen/arch/arm/include/asm/arm32/io.h b/xen/arch/arm/include/asm/arm32/io.h
index 73a879e9fb..d9d19ad764 100644
--- a/xen/arch/arm/include/asm/arm32/io.h
+++ b/xen/arch/arm/include/asm/arm32/io.h
@@ -72,6 +72,22 @@ static inline u32 __raw_readl(const volatile void __iomem *addr)
         return val;
 }
 
+static inline u64 __raw_readq(const volatile void __iomem *addr)
+{
+        u64 val;
+        asm volatile("ldrd %Q1, %R1, %0"
+                     : "+Qo" (*(volatile u64 __force *)addr),
+                       "=r" (val));
+        return val;
+}
+
+static inline void __raw_writeq(u64 val, const volatile void __iomem *addr)
+{
+    asm volatile("strd %Q1, %R1, %0"
+                 : "+Q" (*(volatile u64 __force *)addr)
+                 : "r" (val));
+}
+
 #define __iormb()               rmb()
 #define __iowmb()               wmb()
 
@@ -80,17 +96,22 @@ static inline u32 __raw_readl(const volatile void __iomem *addr)
                                         __raw_readw(c)); __r; })
 #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \
                                         __raw_readl(c)); __r; })
+#define readq_relaxed(c) ({ u64 __r = le64_to_cpu((__force __le64) \
+                                        __raw_readq(c)); __r; })
 
 #define writeb_relaxed(v,c)     __raw_writeb(v,c)
 #define writew_relaxed(v,c)     __raw_writew((__force u16) cpu_to_le16(v),c)
 #define writel_relaxed(v,c)     __raw_writel((__force u32) cpu_to_le32(v),c)
+#define writeq_relaxed(v,c)     __raw_writeq((__force u64) cpu_to_le64(v),c)
 
 #define readb(c)                ({ u8  __v = readb_relaxed(c); __iormb(); __v; })
 #define readw(c)                ({ u16 __v = readw_relaxed(c); __iormb(); __v; })
 #define readl(c)                ({ u32 __v = readl_relaxed(c); __iormb(); __v; })
+#define readq(c)                ({ u64 __v = readq_relaxed(c); __iormb(); __v; })
 
 #define writeb(v,c)             ({ __iowmb(); writeb_relaxed(v,c); })
 #define writew(v,c)             ({ __iowmb(); writew_relaxed(v,c); })
 #define writel(v,c)             ({ __iowmb(); writel_relaxed(v,c); })
+#define writeq(v,c)             ({ __iowmb(); writeq_relaxed(v,c); })
 
 #endif /* _ARM_ARM32_IO_H */
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:14:27 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:14:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433036.685948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUd-0003o0-Ck; Mon, 31 Oct 2022 15:14:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433036.685948; Mon, 31 Oct 2022 15:14:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWUd-0003nM-7b; Mon, 31 Oct 2022 15:14:27 +0000
Received: by outflank-mailman (input) for mailman id 433036;
 Mon, 31 Oct 2022 15:14:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUb-0001KF-Tt
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:26 +0000
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam11on2056.outbound.protection.outlook.com [40.107.223.56])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3f06997-592e-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 16:14:25 +0100 (CET)
Received: from BN9PR03CA0878.namprd03.prod.outlook.com (2603:10b6:408:13c::13)
 by MN2PR12MB4440.namprd12.prod.outlook.com (2603:10b6:208:26e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct
 2022 15:14:21 +0000
Received: from BN8NAM11FT079.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:13c:cafe::d6) by BN9PR03CA0878.outlook.office365.com
 (2603:10b6:408:13c::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:21 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT079.mail.protection.outlook.com (10.13.177.61) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:21 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:21 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:19 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3f06997-592e-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gzfLaBmB9hRMxjzUqTgLvUaZCKOkMk4+Bqa5VI6X/Qwbt2jJO/2A3Uekk5JJ8ia/G6BnqgfFE3Ef4LwpjPW24j2T3q+QpLjqZXAJMdzvdioJbruFG0kutOcOdkVaLY2q7L02J6/vzFUH4d9pXN3sNGEw/qkDTOc4nZ2BO1afDNWrHaxaS9sEbHK7pg04lDGs6GiYatRfBhIZXoJCRksPXlueu98nUQXIjP6epY6mkY1rA9yX1Tnw9cpsUEhVwcd3qeEnH2N/wjVZazTFSJ+jRwatIFjdEvH71WHfX26MzmdHG7DvsdmTTPVOR8vues4hO2tG6baPxQGaC0ouHFk4eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=thswsDnEpoVXekQFz2ERdchgMy9LbS20QZGymqiADZU=;
 b=H8jThX7ffAPSHjX/JHx2y7eQUeVDD1tg18ArZVZe6jb49I6QThM8Wje687UkpK51lSCYsPhB0hGJwdUpqB1bkz48pxyD483WGuzHEsgN/fz1YF4pH8F06yyjLoQ7WpQqGGd9xB2YLtymMKHmnRpJttJBP+fWrrp+IhDs6tomYA8adi82FYXIYQkqQO1hmbbC7Tg/i9PGobf1SwlceZEy3q7nkTYRoYKVxL+akRZm8LYrwYs3lFfc3bOzrXZios85hmIKkAqGGM0rVNi9oNwDDgSRIFYgCZXh1pQP3VrJUnEUuGpfykdCLbnJ8alqTc2k9mDhwjS1yqBSfK7ezF9w/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=thswsDnEpoVXekQFz2ERdchgMy9LbS20QZGymqiADZU=;
 b=tYhr3ZvXLqJgmskhKO0GQ839rE+PbNl9WaY8bRovC0lJnUnai6pKDPCCt2b3Omt2P7ELE70CYQ3abohKgUC/UUeVK3h55BDFEvmJO+JYaetyB1zs4bf3ThlrL3UqeiSSB0zAtUI4r3+hesaInqY+1uwTOWO+G5m6+0KCN2jIieE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32
Date: Mon, 31 Oct 2022 15:13:26 +0000
Message-ID: <20221031151326.22634-13-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT079:EE_|MN2PR12MB4440:EE_
X-MS-Office365-Filtering-Correlation-Id: c5f961f8-e35e-41ba-6937-08dabb5296b7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ul05mLEvhkOfwIr2YqPl13UCqovYsIUmykUUKu2cZkhqMJO86zranB6C5qNzh0N+iCbXDUcE49uZ2Ork/uq4MkrlzI9Xj7J99I75biCeXZm849Dr3V0HAvLQDvhspr+0lD9i3Tsn5a1AWoooeDDyguYpWdgrVfco/FW4ovieKHUlBe/CmEyb/p9B17zHwt5UQgex7qfLVQox95oM6wexjX6GM7C6GiLE70AQH3Bp36Att9fSsgPLf/oyERQSie22slt5VZebyMOafKGsd2w21cbQYjrg8GwR54iyjlBABCJMR+gUObWyiqnRd0rYAuT84hu7LIOL40SGEWMOvTsax8Ms0UmGAyJDylU6bHSmoPLT6iPlD2fK540e6Rvd/sBHrhg00c66/iR1DHDAC4qU/Bn4Dwn6/Sqk9X0H72f40y6G1xJvLEwAohDjJfLIPT5dkzdUHHiSFIoKQ610g1H1IrheMV0z6xXL23sOX55OiCfViyeWJGHGtndw40nNItxziK3Kv//Ul+8h1iGff/kgluN8k7/uCxwh16gBNtMMIE2UHPivBXSqIphaq57/aqCOd2gk8cmY+XiCm/60IlTUf5lErp+NHU0DP7wmfbtz8v3mQcT8UVrt86IWnEXBmqrZhlf0/Uc3hPP/pLVgES+8tQy71AAWnnN7WZK/gkRyzhaC+DJd/FuFni90yFusUnqUisZs21SozGAxGzk1hGYZTJnPWuWcT+0+4IWzycnt4kMFDYqKla8qBperfTDXLOfJsyfsP0433GG6U0dotyEIcGuFLFs8Vt8oKSNjMbfG79jVQjksfgtNqwcP+WdecLVR
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(46966006)(36840700001)(40470700004)(6916009)(36756003)(54906003)(316002)(478600001)(41300700001)(40480700001)(83380400001)(5660300002)(1076003)(186003)(40460700003)(356005)(26005)(426003)(47076005)(336012)(2906002)(36860700001)(82740400003)(2616005)(81166007)(6666004)(8936002)(8676002)(70206006)(70586007)(4326008)(82310400005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:21.6192
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c5f961f8-e35e-41ba-6937-08dabb5296b7
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT079.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4440

Refer ARM DDI 0487G.b ID072021,
D13.2.86 -
ID_PFR1_EL1, AArch32 Processor Feature Register 1

GIC, bits[31:28] == 0b0001 for GIC3.0 on Aarch32

One can now enable GICv3 on AArch32 systems. However, ITS is not supported.
The reason being currently we are trying to validate GICv3 on an AArch32_v8R
system. Refer ARM DDI 0568A.c ID110520, B1.3.1,
"A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not
implement LPI support."

Updated SUPPORT.md.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changed from :-
v1 - 1. Remove "ARM_64 || ARM_32" as it is always true.
2. Updated SUPPORT.md.

 SUPPORT.md                            | 6 ++++++
 xen/arch/arm/Kconfig                  | 4 ++--
 xen/arch/arm/include/asm/cpufeature.h | 1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index cf2ddfacaf..0137855c66 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -82,6 +82,12 @@ Extension to the GICv3 interrupt controller to support MSI.
 
     Status: Experimental
 
+### ARM/GICv3 + AArch32 ARM v8
+
+GICv3 is supported on AArch32 ARMv8 (besides AArch64)
+
+    Status: Supported, not security supported
+
 ## Guest Type
 
 ### x86/PV
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 1fe5faf847..7c3c6eb3bd 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -41,7 +41,7 @@ config ARM_EFI
 
 config GICV3
 	bool "GICv3 driver"
-	depends on ARM_64 && !NEW_VGIC
+	depends on !NEW_VGIC
 	default y
 	---help---
 
@@ -50,7 +50,7 @@ config GICV3
 
 config HAS_ITS
         bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
-        depends on GICV3 && !NEW_VGIC
+        depends on GICV3 && !NEW_VGIC && !ARM_32
 
 config HVM
         def_bool y
diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h
index c86a2e7f29..c62cf6293f 100644
--- a/xen/arch/arm/include/asm/cpufeature.h
+++ b/xen/arch/arm/include/asm/cpufeature.h
@@ -33,6 +33,7 @@
 #define cpu_has_aarch32   (cpu_has_arm || cpu_has_thumb)
 
 #ifdef CONFIG_ARM_32
+#define cpu_has_gicv3     (boot_cpu_feature32(gic) >= 1)
 #define cpu_has_gentimer  (boot_cpu_feature32(gentimer) == 1)
 /*
  * On Armv7, the value 0 is used to indicate that PMUv2 is not
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:15:19 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:15:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433053.685960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWVS-0006Se-UI; Mon, 31 Oct 2022 15:15:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433053.685960; Mon, 31 Oct 2022 15:15:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opWVS-0006SW-RG; Mon, 31 Oct 2022 15:15:18 +0000
Received: by outflank-mailman (input) for mailman id 433053;
 Mon, 31 Oct 2022 15:15:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7CAU=3A=amd.com=ayan.kumar.halder@srs-se1.protection.inumbo.net>)
 id 1opWUY-0008Dn-3L
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:14:22 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2055.outbound.protection.outlook.com [40.107.244.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b153b81a-592e-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 16:14:21 +0100 (CET)
Received: from BN9PR03CA0032.namprd03.prod.outlook.com (2603:10b6:408:fb::7)
 by BY5PR12MB4289.namprd12.prod.outlook.com (2603:10b6:a03:204::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct
 2022 15:14:17 +0000
Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com
 (2603:10b6:408:fb:cafe::42) by BN9PR03CA0032.outlook.office365.com
 (2603:10b6:408:fb::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 15:14:17 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:14:16 +0000
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:14:16 -0500
Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by
 SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31
 via Frontend Transport; Mon, 31 Oct 2022 10:14:15 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b153b81a-592e-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CbkmMuIK9oaqEfZSQCumgAodClTb8ZADs6gxEGMCZnY0UxfYCiXEgtAJqHGSCxfKuhdmOlWb7d4LExgBvYuJoPDIJl+e1CK6S8IBWT80VdmopGow4nz4lCTu1B90lWH7nnRUskHMQwjpYG6KzhKrfMczpo9ITQosXG6Wb0tXERHl4x9PX/MWh22MyKgu+rWfZA4D427Lj1yEUP3ztXNcDbVglKvHU5LYv/Ahwwx9AUO23J+xWdYYudlpdrjGidQI7F/iQTpz2fA1VQJIjgY0Z391TvqkRTyas/cu6OWDjgzXPDgU0TRgUdbRFUOtZj/QaohWSASkIi8VPs+lUrFwTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KHAPEWS3Ul1UwQcVWsmr+QDrrCPSDU3SzxfOHJarRiM=;
 b=O0IblExXSX3peEscDuJmVHq8SkT1HFqFukRukxV2M1KaqH0KMYpaKhFAcWQN+KCYe3o4VVAOfk9T1RIJmf2Sa5nkfRGDm3oQiqnWf/1J2Jpbrcqhf+5cPupnPuhAl9tMGNoow1cW1zjZT/PXmUAb6Ji9UlRQYc+LstYKFpbAo3KU030BteWXwpTTlbJc7S59MpqpLHHipBcN9aE9QC8JFMPHl+ZcF0SBLNuL1dUqzRrsYD5dse9xuySFU38bt/T2QY1xSQCYqsGUlMq8UCU6wdKiGRm4ORgI+u3dgSkvIpU0kRZupywUNboOt0AmkmT1CXF1Kf0KKSKEU4dPogMyQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KHAPEWS3Ul1UwQcVWsmr+QDrrCPSDU3SzxfOHJarRiM=;
 b=SRNLAlMeqZg9XjWooa3dOY8YC9IxFXgappA5xBpCwYN6p/QWQOFG4Z86eBSJEQke7bTMT8szapE811UXIbo05p6e1wXethV2i4p/3wsuGE87gBq5dah7BOaPIP61pBbvXQdO9n50LkvuG6iuP2LXeAzzDDmXUBJLvJZ+Any+jj0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
From: Ayan Kumar Halder <ayankuma@amd.com>
To: <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>, Ayan Kumar Halder <ayankuma@amd.com>
Subject: [XEN v2 10/12] xen/Arm: GICv3: Use ULL instead of UL for 64bits
Date: Mon, 31 Oct 2022 15:13:24 +0000
Message-ID: <20221031151326.22634-11-ayankuma@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221031151326.22634-1-ayankuma@amd.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT017:EE_|BY5PR12MB4289:EE_
X-MS-Office365-Filtering-Correlation-Id: d00e45a5-6ea6-4571-ac77-08dabb5293c7
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q3OU0pAqCKkVKEeX8Y++UZd2d4tIyKmJMc24hD+SdYuwPBeceZ/y+8mvJIiNNWwP/ypVdgLLnrRGb5OaSxlBZFfKCQCBgCNf1Rpj6vsVFBajMQyLfUF/f3leiaGIKuPZST26IaHvTS7muvamN8/KoD4hFO9kUjIqPtMg8wL4V9lg6WlO75J0Vg7uCD8Z1T5rIgccsV77ymIPVGaCd3rYFcF54Bdv6zXj44ktS1Iei0N3QVqe1w1clvvN7CJyGelzUkkb2Rde7N586QWnp5p/7wJgqQIqdBC/iHb2mxUeAYg3molsAmnPxH/AIzmlC0kPv2vTlwqaYXGlMIMgF7vZW8nPAWYVWn7A1x66RfR1uu3gTEdqon2u8bwSLaoSyDlQeajHC7Bxdy7kUdtV1EWVNEcz3W3zdrADVEYnBKTK1bW6xv/FnKQdVhu8ifnc8H/+dvdhnJZOuNnIY+znbWSKyDcHkr8W0iPHhtT68r/SiBlMv9f0d6QsiI9UJpM/gBm+a9Kq3xJRwNwVnscqmdsoIGScjFadXMSDO8GYAR83RKghtDORuj1qbu25iNUTMxQeOzjHI539+2H8xJMrbwszkUltNE8t8jppOegKb1579q/LHaZmX4XwZC6rDABzKZqQ4YbHtMgOUzLGIDtxJCODkSulTi9L+lxBSOIZ4GDWdRQa695oD9ryBy5v6v+ZvE+V6VXUj3vqU9vJOcN4ke2TfVzc9FjPkPEG8JSDF/PJ3kF3p/oml1s7thq0h0Ph2j58GSHWX7f2gpM1ZlEO8FlM1zuZxXhwdkxWsIsRRQUcHeFtcL+uISE/i7KhZh3g+Ok1
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(2616005)(40480700001)(336012)(5660300002)(82740400003)(26005)(2906002)(6916009)(316002)(1076003)(83380400001)(36756003)(186003)(478600001)(6666004)(54906003)(81166007)(47076005)(4326008)(8676002)(8936002)(36860700001)(70586007)(82310400005)(426003)(40460700003)(70206006)(356005)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:14:16.6926
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d00e45a5-6ea6-4571-ac77-08dabb5293c7
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	BN8NAM11FT017.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4289

"unsigned long long" is defined as 64 bits on AArch64 and AArch32
Thus, one should this instead of "unsigned long" which is 32 bits
on AArch32.

Also use 'PRIx64' instead of 'lx' or 'llx' to print uint64_t.

Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
---

Changed from :-
v1 - 1. Replace PRIu64 with PRIx64 so that the values are printed in hex as
desired.
2. Use ULL in GITS_BASER_RO_MASK as MMIO registers are always unsigned.

 xen/arch/arm/gic-v3-lpi.c              |  8 ++++----
 xen/arch/arm/gic-v3.c                  |  4 ++--
 xen/arch/arm/include/asm/gic_v3_defs.h |  2 +-
 xen/arch/arm/include/asm/gic_v3_its.h  |  2 +-
 xen/arch/arm/vgic-v3-its.c             | 17 +++++++++--------
 5 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 61d90eb386..9ca74bc321 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -134,7 +134,7 @@ void gicv3_set_redist_address(paddr_t address, unsigned int redist_id)
 uint64_t gicv3_get_redist_address(unsigned int cpu, bool use_pta)
 {
     if ( use_pta )
-        return per_cpu(lpi_redist, cpu).redist_addr & GENMASK(51, 16);
+        return per_cpu(lpi_redist, cpu).redist_addr & GENMASK_ULL(51, 16);
     else
         return per_cpu(lpi_redist, cpu).redist_id << 16;
 }
@@ -253,7 +253,7 @@ static int gicv3_lpi_allocate_pendtable(unsigned int cpu)
         return -ENOMEM;
 
     /* Make sure the physical address can be encoded in the register. */
-    if ( virt_to_maddr(pendtable) & ~GENMASK(51, 16) )
+    if ( virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16) )
     {
         xfree(pendtable);
         return -ERANGE;
@@ -281,7 +281,7 @@ static int gicv3_lpi_set_pendtable(void __iomem *rdist_base)
         return -ENOMEM;
     }
 
-    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK(51, 16)));
+    ASSERT(!(virt_to_maddr(pendtable) & ~GENMASK_ULL(51, 16)));
 
     val  = GIC_BASER_CACHE_RaWaWb << GICR_PENDBASER_INNER_CACHEABILITY_SHIFT;
     val |= GIC_BASER_CACHE_SameAsInner << GICR_PENDBASER_OUTER_CACHEABILITY_SHIFT;
@@ -329,7 +329,7 @@ static int gicv3_lpi_set_proptable(void __iomem * rdist_base)
             return -ENOMEM;
 
         /* Make sure the physical address can be encoded in the register. */
-        if ( (virt_to_maddr(table) & ~GENMASK(51, 12)) )
+        if ( (virt_to_maddr(table) & ~GENMASK_ULL(51, 12)) )
         {
             xfree(table);
             return -ERANGE;
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 8b4b168e78..d8ce0f46c6 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -417,12 +417,12 @@ static void gicv3_dump_state(const struct vcpu *v)
     if ( v == current )
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   HW_LR[%d]=%llx\n", i, gicv3_ich_read_lr(i));
+            printk("   HW_LR[%d]=%" PRIx64 "\n", i, gicv3_ich_read_lr(i));
     }
     else
     {
         for ( i = 0; i < gicv3_info.nr_lrs; i++ )
-            printk("   VCPU_LR[%d]=%llx\n", i, v->arch.gic.v3.lr[i]);
+            printk("   VCPU_LR[%d]=%" PRIx64 "\n", i, v->arch.gic.v3.lr[i]);
     }
 }
 
diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h b/xen/arch/arm/include/asm/gic_v3_defs.h
index 87115f8b25..3a24bd4825 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -195,7 +195,7 @@
 
 #define ICH_SGI_IRQMODE_SHIFT        40
 #define ICH_SGI_IRQMODE_MASK         0x1
-#define ICH_SGI_TARGET_OTHERS        1UL
+#define ICH_SGI_TARGET_OTHERS        1ULL
 #define ICH_SGI_TARGET_LIST          0
 #define ICH_SGI_IRQ_SHIFT            24
 #define ICH_SGI_IRQ_MASK             0xf
diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h
index fae3f6ecef..5ae50b18ea 100644
--- a/xen/arch/arm/include/asm/gic_v3_its.h
+++ b/xen/arch/arm/include/asm/gic_v3_its.h
@@ -38,7 +38,7 @@
 #define GITS_PIDR2                      GICR_PIDR2
 
 /* Register bits */
-#define GITS_VALID_BIT                  BIT(63, UL)
+#define GITS_VALID_BIT                  BIT(63, ULL)
 
 #define GITS_CTLR_QUIESCENT             BIT(31, UL)
 #define GITS_CTLR_ENABLE                BIT(0, UL)
diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
index 58d939b85f..c5e02b2c41 100644
--- a/xen/arch/arm/vgic-v3-its.c
+++ b/xen/arch/arm/vgic-v3-its.c
@@ -96,13 +96,13 @@ typedef uint16_t coll_table_entry_t;
  * in the lowest 5 bits of the word.
  */
 typedef uint64_t dev_table_entry_t;
-#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK(51, 8))
+#define DEV_TABLE_ITT_ADDR(x) ((x) & GENMASK_ULL(51, 8))
 #define DEV_TABLE_ITT_SIZE(x) (BIT(((x) & GENMASK(4, 0)) + 1, UL))
 #define DEV_TABLE_ENTRY(addr, bits)                     \
         (((addr) & GENMASK(51, 8)) | (((bits) - 1) & GENMASK(4, 0)))
 
 #define GITS_BASER_RO_MASK       (GITS_BASER_TYPE_MASK | \
-                                  (0x1fL << GITS_BASER_ENTRY_SIZE_SHIFT))
+                                  (0x1ULL << GITS_BASER_ENTRY_SIZE_SHIFT))
 
 /*
  * The physical address is encoded slightly differently depending on
@@ -112,10 +112,10 @@ typedef uint64_t dev_table_entry_t;
 static paddr_t get_baser_phys_addr(uint64_t reg)
 {
     if ( reg & BIT(9, UL) )
-        return (reg & GENMASK(47, 16)) |
+        return (reg & GENMASK_ULL(47, 16)) |
                 ((reg & GENMASK(15, 12)) << 36);
     else
-        return reg & GENMASK(47, 12);
+        return reg & GENMASK_ULL(47, 12);
 }
 
 /* Must be called with the ITS lock held. */
@@ -414,7 +414,7 @@ static int update_lpi_property(struct domain *d, struct pending_irq *p)
     if ( !d->arch.vgic.rdists_enabled )
         return 0;
 
-    addr = d->arch.vgic.rdist_propbase & GENMASK(51, 12);
+    addr = d->arch.vgic.rdist_propbase & GENMASK_ULL(51, 12);
 
     ret = access_guest_memory_by_ipa(d, addr + p->irq - LPI_OFFSET,
                                      &property, sizeof(property), false);
@@ -897,7 +897,8 @@ out_unlock:
 
 static void dump_its_command(uint64_t *command)
 {
-    gdprintk(XENLOG_WARNING, "  cmd 0x%02lx: %016lx %016lx %016lx %016lx\n",
+    gdprintk(XENLOG_WARNING, "  cmd 0x%" PRIx64 ": %" PRIx64
+             "%" PRIx64 "%" PRIx64 "%" PRIx64 "\n",
              its_cmd_get_command(command),
              command[0], command[1], command[2], command[3]);
 }
@@ -909,7 +910,7 @@ static void dump_its_command(uint64_t *command)
  */
 static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its)
 {
-    paddr_t addr = its->cbaser & GENMASK(51, 12);
+    paddr_t addr = its->cbaser & GENMASK_ULL(51, 12);
     uint64_t command[4];
 
     ASSERT(spin_is_locked(&its->vcmd_lock));
@@ -1122,7 +1123,7 @@ read_as_zero_64:
 
 read_impl_defined:
     printk(XENLOG_G_DEBUG
-           "%pv: vGITS: RAZ on implementation defined register offset %#04lx\n",
+           "%pv: vGITS: RAZ on implementation defined register offset %" PRIx64 "#04llx\n",
            v, info->gpa & 0xffff);
     *r = 0;
     return 1;
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 15:56:13 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 15:56:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433081.685971 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opX8m-0003Z1-Vz; Mon, 31 Oct 2022 15:55:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433081.685971; Mon, 31 Oct 2022 15:55:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opX8m-0003Yu-Ra; Mon, 31 Oct 2022 15:55:56 +0000
Received: by outflank-mailman (input) for mailman id 433081;
 Mon, 31 Oct 2022 15:55:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CXQ+=3A=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1opX8l-0003Yl-7w
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 15:55:55 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20052.outbound.protection.outlook.com [40.107.2.52])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f68c065-5934-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 16:55:53 +0100 (CET)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by AM7PR04MB6823.eurprd04.prod.outlook.com (2603:10a6:20b:102::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct
 2022 15:55:51 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022
 15:55:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f68c065-5934-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AIs+i+ZmvQvvqvVMX2jXqF13+2jFG9U9TlZEniV4ZgcmUbgrh+HB4k1Cn2Q+Te8QSQv4YsY5nnbkO+y+CjjN/AJcQR0b925vwkobyFYkcGN3BsGi+M4gqeDu6AbbCF3LYAJX09m6kt3+tus4i5p3IOapxnczhfWsR1wadwjGPlz01+qNUL0uKYPkdg7tSIQhEya5DtSwIL6yob4QuiKorttiALLtkO7TRQaa/CBKXjS3FLE9Nl60ewjX7AC2/F/vO6jtXqgjDkFigWgSlkYTGbpdTRqbFpJ66tJi6JxrR5v6+vx+fbz0baHvB7ssgbSw6t8xGXone3O8Md08L3Dddg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=43LYhshjj694LGAizJ/O2VDaAhBGlD3rOZX6GAlF0Ow=;
 b=MR7g2/YzniL0esrvvU7PQ0ZHAu5lVig9cONdz3sUs8sUNBZ2gl6kEkGrDtmWGUIt0lTWEgts++m1lxKuF6onWbjaWnfJtw15nwsc9tuOE7TvzmvcAmclv12lEbh/sUCcus89tevP/bmPlOulJYrFZhWo4Ix9NEaxL8fok9klTH/skn5Yvbn70rviaWBIKVDPF6qSMf3Is8KjDYtQslCWbfOLeqs1oyPDWs0DRol4D1eMYeU2NDS4nI3+XIKWiGqkN6AMcZ17bjv3rlyhW+7z4e0rTd5lAchvjfaTmXh9VseOoKLHUOyPGY4NIqEk7v6Bw1gxNqKdl0am/i0IOahytw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=43LYhshjj694LGAizJ/O2VDaAhBGlD3rOZX6GAlF0Ow=;
 b=Dq9WEQbcGsmy6KqHRqe0bkK9heDu4O7Z+9tj/g6Ofa90Ff9PLX41y/9R8tIFtxMrUJWe5iWfmjKoSEyb9kIGWRE5mBHNDPWrrX/kRu3zCQqwqKXkQlQj6mjAdZBrxncDzOF2WRykTjh6ObIFjJLKWbmJg6ufOMN/9AYO84INIH/0LsKfKjzx+xWlKh7IC9pDSQhi//QoQqQq6UgzlhJBa7i94jBigo4tRw7oi1zZ81F4kiRa1Y1ERjtKpKKFNYSVdJCs7LqzUyWbK5rdUuh4pQYW3ypNaxoX5MSw2UT3sG+lvy2yiDMRU7AMgmvvRkBOG+P1WeqwLarloS5bWfF+nA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d9022ce-4a46-e0cb-67c3-4124e1c0d2db@suse.com>
Date: Mon, 31 Oct 2022 16:55:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: x86/HVM: Linux'es apic_pending_intr_clear() warns about stale IRR
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0020.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::21) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6823:EE_
X-MS-Office365-Filtering-Correlation-Id: 3cd7453e-cc1a-42a5-0232-08dabb586280
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bXPLhPAZiRjXYMmLZh6oH5gs/G0kK8Np0pqbCCmeMW3Ksjk0uuuyddDZCIGQ9UE6V+R/gaGM5TnwWweD7ZAEij/y9/LotlxN5UWwFRmD46B1SoZaS5prvJzJvBQNtDUIfoptjf/0Kj8KhiKvztZb+JXMAPRMCpV9YaEZtHpqy4au7dsQ1QlZHYerW352VqOi/Ct21f2XxHJ2MEzkzlb9R3I6AMGGmbXAziv0Xx4wH3MR3Z6zlhwC/x9PYd0S/QPzdKx9O1oVou3esVK2TjXmUaOop7ouKoHcmE1czRGjvw8IJRtVTnUnfsaSC/FLEHcXIA4yMTP/Y7P536JimM6YPlbQ3rWpmPzqGx3r63zwXAsELJ5077eoPBJCEiyUoRSKw6lbbvvnznyv6/iOdmcWiG0xEhKbPSWRc/XQKAi6Rusk1Zpi8eqqTKMMtSKk16Uh16wbQ+AmvXP7Hgq1mXTBaO5YMuemR5kiLjqi8HELX5QNV0naW1fmMo8ncsxGGD0yZ35tSEEkX6cA6SOl98ZZ/i//LDohx4ncmPziRs6gqeyAR2Y7501dWwhRE62awmJbE6BsyI3aNiF7nCtdaR1XMxnT/rDVnnRKtbqThb/oikr5JQ1fznmDQxTRbmQCP+wzJqo3vDUBXzud6cNr2XO0eIUp/5MBQNrmZo6qjqtqCRX6z9ifHxoW0Z5p6+wXT5X1yF1Rk9vbXGA4K9tKYFu1hLmmO0MkaUf61hvbr4grm7l4yztSzK7cnnopJ0AluygyO9IkAT3FTTbbZnzulSk7RpjT1W7HxJkN6GIGTCnLNQo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(396003)(366004)(376002)(451199015)(31696002)(41300700001)(8936002)(478600001)(6486002)(5660300002)(86362001)(36756003)(83380400001)(316002)(26005)(8676002)(66556008)(4326008)(66476007)(2906002)(2616005)(6506007)(31686004)(186003)(54906003)(38100700002)(6916009)(6512007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Ymd3cUIzQkM3L3d1d1l4RGh0SkhVT3RmODJaODRVaVpRd3BOY2tDbG1KN3BC?=
 =?utf-8?B?eWFoT1JZK3FLazlNeS84RTBsWGZucndaRkhmSUFmb2FXQzgrNndkam0zQjRD?=
 =?utf-8?B?Mi9kT1dIWTJmYzA2RXUyQ0JVdStwZXN0SUlmQ2tDU2U0Z0UrOEpVb3hjMGpP?=
 =?utf-8?B?YUl0TE1VejlSdDJhS2hxazN1dS9rWmdEYXhOWHg2bm8yL1lCNGREKzBTZytO?=
 =?utf-8?B?akZ0S2tsMXVGdWk5YVNyUnZ1aDZiK2JlRE8yUWNMcjRyTFNiOFlicWl2dCtL?=
 =?utf-8?B?TkYyTnpSalBHbzJUWVZUOHl1UEYzaWhFZzlTNlBCTzdxK1RDKzJ2U1A3Rk5Y?=
 =?utf-8?B?THlFNXZmSEg0L2szMmhGU0hYV05QcjI0bDd4OHFxbUlRM1pPd2FEMU5YQVAr?=
 =?utf-8?B?eGdVTU9JUGFBVTdFYmh2N3gxVUp0SVdFR0ZYYlBQSGtTRjdCWjdIUXlGKzBG?=
 =?utf-8?B?cGI1TmZ3SEp4VjFrUTN4Y1JUUXRBb0lJUzVPdUc0NHdJZnFNdkZMcklqWDlk?=
 =?utf-8?B?SGpabnlSUkVwY25Ud1YrUWRnOHhXSS95Q2JETHZzaEEyRHNoUkRlQld4MXRQ?=
 =?utf-8?B?OTRaS2Q1Y25CVVYwdmMwS01NeG9DQStpaW1WV2xyejc0QXZYLzVmZXVFVWx4?=
 =?utf-8?B?cURuRWhEaDAyeTdRMy9zb0tPYk1zQ3czN2pRblEzVmtLYTgyUHQxeW1QZzJO?=
 =?utf-8?B?N3hsSmNlSTBrYno5a3JsdGFEcXFmSGNjWWRTeGd5M3J2VU4rQy9yWDFQL1Ba?=
 =?utf-8?B?aU5aRGZ6K3JHOE1nSUZzYW51dkdlSTVsakoxQjdxVGVJZGJnZ2dhejI3Vkpr?=
 =?utf-8?B?aFprUGs4SFdYeXZGRE1sTkNJVGdlcms3YkwyUnVxb3Z1RXQ4Y00rL2FUVFht?=
 =?utf-8?B?NXFMQ3F6NjZhNnRVOEtWUTJaTnRjUmdleWZaVVR2UFBldkFEOHlBdmYxeEww?=
 =?utf-8?B?RUgxZXMwT3dERlpwcGQxSFhVTElRN1V2ZGxoTWRMenBVSk15N1ZFazBMLzhV?=
 =?utf-8?B?aTVOU0liZkRjRVJQd1AyRFhlNW1abnpTRmZxWCtLWU81SWFKRVhMU1dhZ3Vv?=
 =?utf-8?B?N2FZTmRmMGZISHFVeGd2TjFLcEowaVVmdXo1alNxOE9Pa2IzZ2tWVmg5TWZz?=
 =?utf-8?B?N1RLQ2liMmltWHJXRmpoT0xHN1hsd3pxZ25qeDBEUVkwb0hJTUVLZVplTXAx?=
 =?utf-8?B?VmdPUmVveHlvUnJ4TCtiNmVWQzZwQlRoMzVQYklqZlFXRmpiZ1ZVZ1M5YnZY?=
 =?utf-8?B?UGkvWUtMT1pGN1lCdW9sREdQT29nbURESHlLM2NYN1R5eE9tTVZkdTZWa0Fz?=
 =?utf-8?B?WG9mZW1YOFY1eTF5R2FwdnlXUzNLMmhoODhHbEl4Ykk2RG5ZMk05RXMrYThX?=
 =?utf-8?B?QWJQV29WRTd0dlVEZDJOSW5rWEx4VEJrMU8wekJ2YURWM1JlUlJLME1RVVM1?=
 =?utf-8?B?cllQYmdZYjVuTEVBSW5IRzMyd1VwR0dxdm1peDlrV2h4TWZlSXBwTTdFazBz?=
 =?utf-8?B?MFk4SkYxaldSS1lPSExCUE5NQ3RGSkoxRkNBemdJT2E0K3NUZ3VnVnlFN1BF?=
 =?utf-8?B?WjV6OFdib2RDZHpzc1lDN3FOL0NjMmtoZzJCZE4wUkhXMDUrOGVEa2IvOG8y?=
 =?utf-8?B?YVMrSDlFZE94emZ4SmJvSThIb29wbzZLcjk5d0V5WTdndUJ0M0QyRkdEaTdi?=
 =?utf-8?B?bTZVSXJ6WUo3Q3VaZFJBMmFMT3lpWXQzUzhrbW1xNzFMN3QxNWRLZHBQaDVS?=
 =?utf-8?B?T0FsN3k0WDY1WTRNcGRwdkRwanMxSHNqb0pBN3RSRnNSM0ZvcDJ2ZklieVBX?=
 =?utf-8?B?Yi9oL1ZzdG1GWjhJSHV4V3pwT3N2ZEgyaXBhTzRuWXQ5T0dYQ2RJUUozS1Fy?=
 =?utf-8?B?S2Vvd1BPUmJqaUJqc1MwanZNaTk1MGVPOEVJMWRjYlFmdjBRQnZjQTduK0dt?=
 =?utf-8?B?NVdkd083ZXJRMmxsZVJSRFlneGlyOVVrZnF6d3RIdFJ4L2FNNEt3T2lLSzJ3?=
 =?utf-8?B?eERiL2kzWXR0Tjg1cjJCb3IyTlo2Wnk0L1l2Vnorem9XWEN2c0IyaW9FbnQ4?=
 =?utf-8?B?NTNvc1R0OEhlUlJYNGo3bm80KzF4czJzY3JoZGo5NmwwTUFIWE9EeHh0MVE0?=
 =?utf-8?Q?f11NCM5AvctJiulHvPfeeK4gl?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd7453e-cc1a-42a5-0232-08dabb586280
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:55:51.1825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JLkzfuWY0TMUf+dho+z5BwSYfpNq4oUbDuc7gUUVAkSHbhwUFAXsPhRg9KyRSerUkKu12xVCw18IyA8BI9jZ4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6823

Hello,

quite likely this isn't new, but I've ended up noticing it only recently:
On an oldish system where I hand a HVM guest an SR-IOV NIC (not sure yet
whether that actually matters) all APs have that warning issued, with all
reported values zero except for the very first IRR one - that's 00080000.
Which is suspicious by itself, for naming vector 0x13, i.e. below 0x20
and hence within CPU exception range.

For one I wonder about their logic: The function is called after setting
TPR to 0x10, which prevents the handling of vectors below 0x20 (and in
particular their propagation from ISR to IRR, if my understanding of the
process is right and the convoluted and imo partly incomplete SDM
description hasn't confused me). Plus the function runs when IRQs are
still off, which is another reason why nothing would ever propagate from
IRR to ISR while the function performs it work. Yet a comment there says

	/*
	 * If the ISR map is not empty. ACK the APIC and run another round
	 * to verify whether a pending IRR has been unblocked and turned
	 * into a ISR.
	 */

suggesting IRR bits could "promote" to ISR ones. And this, to me, is the
only justification for warning about leftover IRR bits (whereas I
certainly agree that the logic should result in all clear ISR bits, and
hence warning when one is still set is appropriate).

And then I got puzzled by our logic: vlapic_get_ppr() is called only by
vlapic_set_ppr(), vlapic_lowest_prio(), and vlapic_read_aligned(). Yet
in particular not by vlapic_has_pending_irq(). While it looks like we
don't really ignore TPR during delivery, this appears to be a strange
split approach: hvm_interrupt_blocked() checks TPR, whereas
vlapic_has_pending_irq() checks ISR. I wonder if subtle issues can't
result from that ...

Of course I'm yet to figure out how IRR bit 0x13 ends up being set in
the first place.

Any correction to my understanding as well as any useful insight would
be appreciated.

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 16:22:54 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 16:22:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433091.685982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opXYl-0007iz-29; Mon, 31 Oct 2022 16:22:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433091.685982; Mon, 31 Oct 2022 16:22:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opXYk-0007is-VB; Mon, 31 Oct 2022 16:22:46 +0000
Received: by outflank-mailman (input) for mailman id 433091;
 Mon, 31 Oct 2022 16:22:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CXQ+=3A=suse.com=JBeulich@srs-se1.protection.inumbo.net>)
 id 1opXYk-0007im-6X
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 16:22:46 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2063.outbound.protection.outlook.com [40.107.20.63])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4000f51d-5938-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 17:22:44 +0100 (CET)
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25)
 by DU2PR04MB8693.eurprd04.prod.outlook.com (2603:10a6:10:2dc::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Mon, 31 Oct
 2022 16:22:42 +0000
Received: from VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com
 ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022
 16:22:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4000f51d-5938-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HCRy5//z4Wwa7ZoN7ZSm4Rc85Q9TyQMpIyAiL4hlXlLG3SGW/DtYb+dUqtSAKU3G/8rKgNK5IXlWOzaUZqIW340vQonbBvdWEh3PEOR1rbp3+yCpL7nFzQeMn9oleeBFacqRycfnFRLUnBZHwEmAdPK5Gvk4/LZuUd5eWpn5z9u3wJiNA9/9XFqcGecPbhM2F3qgaVTLnL8a3/Enkrqlhk+Fyp8pc4MNpaplFLssjOug0CO573AR9G0WxJdo+aMYicN0cI+KcFrnfT5iA4a1C6TCIKm4jfIrkqkMcdAlq9H+IeNytL+2R32VCO1uX6z9Ipp7VOlWVdNpoZuXLi77sA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Gq9DuOI0BrKBl2/scw05GGHAC7mgzloluTb4Ec6eqe0=;
 b=lExKXBY7lQUJYEWVD02xFYL/xU3m/dsWjBPW+QsoskmSyyGgxMUbCJ1ReF9YMSV3H5YHswGVFiwamKQD1sJmWsVuoU9S8nMwULnyBXxjVtqpb+DGypE6eubD/R5/5delafKEQOElmcdsvdYREkiza+1SHrH5zLyjzyPjYacY4NwCDMJJrJgwhlKUXIrD/ezctURcc/fnEncbWZ6j+olUaTGFNkKNU6e335MCqmMzqN2hXnn4yqjn3e61SEQx5yihm1PBBKt9wrlGfkKKWKNtdxiMEa0wqzsS2hlkOg/xwj/K35x1AHC15nEtDUath4lfa4ArzCABi+dFqfPzYHyosQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Gq9DuOI0BrKBl2/scw05GGHAC7mgzloluTb4Ec6eqe0=;
 b=xrgBZpoYHFSYgc5Eec8S4IjCjP+Zers4rCsDCqtpl8kOsfpaGLmP4evXa3Kt7sAkYc1LR5c25v11lg0ZQKDEhysRRADy46x73d4/ATQ8rSch24o041/uxrHSswKAST7H1UjizkL6evNksMFz0ag0BXciaM6Ho6ET31R1I+MC47zbVnMW8VkQsf5Ilfg4dlADcmXZbeG9QLzpzx51JYTG3Btun9uUDa1UFEHp0VHl9kduGmMqVnYCMIcdsJkzFeO12d79y+8Z6WhBQLTPRHskr3yeL+LTBDHNlZfzkz6HhE/R+L0ArCXhENCHlVR4uL3SJFtgHsoQgGpdassrPEQjeg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2d1f7271-1399-f5ea-9519-9db4e4ca3de0@suse.com>
Date: Mon, 31 Oct 2022 17:22:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH for-4.17 v2 1/3] hvm/msr: load VIRT_SPEC_CTRL
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Henry.Wang@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20221028114913.88921-1-roger.pau@citrix.com>
 <20221028114913.88921-2-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20221028114913.88921-2-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: AM6P192CA0029.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:83::42) To VE1PR04MB6560.eurprd04.prod.outlook.com
 (2603:10a6:803:122::25)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8693:EE_
X-MS-Office365-Filtering-Correlation-Id: 750266e8-1153-4dce-40cf-08dabb5c22ee
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uch/vXBtJ/AR86avVcCkir8OLoWTH4GFsqG5AEqR5r0GYVHFboskRNBuefrnnb8LapPkh3amsXQPKlddDOlImQS/LJqvAmq5UTY4UlTUOM7qFFXTf0N36RvJyiiWDB5RhmU6G44CfDgQ/X1Hx1XS3w+sya/65zYJtUyn0hN+M6d9l9hImlNPqL+uXlU/VfEMNjxYxoWeOaU0ulxjAVUAOqmMlc99kdMmgOEK7pN9m1dTkGYYZ/5Ntlr/OH3HbKCAqt49nMWhSV6nVyxmQVJgDEMwDCntc7eV40dpqdMfNqi2hyYfJg9JJCrzceDwynGy24V1cjas/27yHdBPPemly40lZa4HXfL3Kh3l+UrnFxOzgXOwnaCC8DbTeB5KZFsNyQ/3PARbKm3T626Z1XrOE4iQv9MYhsYzDewEKYtpek5YOHiGAuDVhQIwX66SmIJOTzCr10syZgECRVKk0xH3tM9ts29Z99w+asmQEF9sI0SPb06gyak4qtkqJn8frQZWIh67T2xGe75s7woReRj1Lx0UdAexZ/HUhRsPhpE3IiMazEHWp2fCMsH89kCwUfsGVVkU9L0+Rd4hNr7u4s1ESNxYNgCfq8s/aUKazQa8gqBkZWq3q/pBWtdG2ZaupDjHC0Zxdl9YjZvcFE2V6g/A6VfLmjp98kdPOs8dKshhoxEQbMgNWMustaknimV2h6ZoDvl7EFO143jQ/pC0l5lwlE+0R+bpSCuPy1OQpFT8YhK2LRjS1AAKyKoQu2jMQGHL2qbFlE4Lnh3EbdnUB7f+o9PXieaV6v+UpEYFjxQMm2s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(376002)(39860400002)(136003)(346002)(451199015)(86362001)(31696002)(5660300002)(38100700002)(8936002)(41300700001)(54906003)(2906002)(8676002)(4326008)(66476007)(66556008)(316002)(6916009)(6486002)(66946007)(6512007)(53546011)(26005)(2616005)(83380400001)(186003)(478600001)(6506007)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGhzZzJ6NVp5cHNNL2N5WHZSclAzZmhuZW1PdDFEQnF2a29INnpRSjdhdkpl?=
 =?utf-8?B?THEvdmtaSkhqNGk3Z2JCbmU3U1F4aERqUVRuVUMyMW9NR0NrSy9QMnZRR3Nx?=
 =?utf-8?B?TkQ1aGpPeVJMazFZU3E4MzZteGp2S3E3clg4Y2hjU1dzZ1ZpZ2hNMkN3VzM2?=
 =?utf-8?B?akRlZU50UlFJdEJzT2ZqZ3UwU3lyMlY1bkg0dVpYSFVheTVqZ3FpeWtnU1Zo?=
 =?utf-8?B?blord2FLa1JpSVUxYW44c2VEcXhaTmdwVWh4LzZmSnZoNVJjODVxVWxIZ05z?=
 =?utf-8?B?WW5qeDE4OWJwRDd1aWs4d2s3VG14RVpGUWdrendLTUJMYzk4NGpiMGJlYU5R?=
 =?utf-8?B?TU1DeVpZSC9meWlFZUl1WmZOcXo4SmgySVY3YnkvUE5QczUwQXp0YzFBeHJN?=
 =?utf-8?B?T0FNQ2s5d1V0M2JkM2RCWVJQY3R4Uld2Wk9mZ0ZJTUhsMHgvcy9SMzNsQ0N0?=
 =?utf-8?B?dXFVR2tPaGpvU2VoaWxkNjdheHh0eWpqU3BQSGo0UXpKb3VVRDBYR0pRVGJL?=
 =?utf-8?B?YWdkQXY1ZG9EZm5iY0JxRUswUlNPNFJ1Q2VHK3ZnODBlOHV1RnNvMjRTTGJB?=
 =?utf-8?B?cmNYQkhISTQ3ZlJrMmVCUlZPYTJCS1luTWxQSmpRKzhOOEpHWW5KVVJRdHIv?=
 =?utf-8?B?S2x1Y1VlcmR5U2U0UllXSnpRVmQvZVNKcTJzQ1ZEamdOZlZpaTJDWXVhenc0?=
 =?utf-8?B?ZFo3V29lK3dEZWVLTmNnaHpJaGl0SkE4bnZUV2hwQXJablV1cHM3Q0gwempz?=
 =?utf-8?B?RVNyajI5bUVvYlNtRTQ2bDZhS1IvbTVXSVAwSFJSa3RQRldlYm1iUmFYdWQ4?=
 =?utf-8?B?YW9LbkZZZXpLZ2xTMW96dVExRWxoNERCanZZUnZlUHdtY1B4c0gyZDVtVkRv?=
 =?utf-8?B?T0xtMTFOTE0wV01QL244WkZ1U2pucFJnTjRLYnYrZWVhZ1hxUTZwQisyQk1E?=
 =?utf-8?B?d0tqTzE4TXh0ZGloY0ZSc3pnejhnc25zdHB0L3NldjRyNVJheTM0d0dlWUlv?=
 =?utf-8?B?S2NnR2RMdVRpZXRxVEtnbUxsOWdBMkdpNnR4U0J4N3dpUEJKSkJ0VC9QUzhG?=
 =?utf-8?B?WkJ0Y0tWNmZ1UUxZU1VuNmFvVkF6Tnd0SjFZVHl5QnpwdHhRWXVLZmFaQW1q?=
 =?utf-8?B?cERBZlNsb0hzbXpNekNMbTVPOWpFUyt2cFhWbGVqdDFNMHpydlExSHpwVjV0?=
 =?utf-8?B?MU03MXZiWkI5U2xSeUEwZjNrcmp2RGNncjNEVmhJYVhaWm9nbjlTb3A1L284?=
 =?utf-8?B?YkdObnU3TDl1OG9jMW5DWGkxZlVYcUgrU3JYTGZTWnZ1US81OTVxeFRLbWIr?=
 =?utf-8?B?TVNUbms0TEdjNER0Z1ppTTF5NVJOblFkMzhGVDh3cy9KV1hoU1NuVHowMjla?=
 =?utf-8?B?bTV3eDduVUwyV3lEeFg4bm9YODZJR3dMZHRhWkpBUUhlVytvdGJmeWppN1ln?=
 =?utf-8?B?eDZ1alRLcDlyVjRxNDN2SUdjbE1JRmFqQzB0WXpOVXNsVWFGM3dOcG9kaHdE?=
 =?utf-8?B?K2J5cC9iNC9uZU9GakFiWEFSWUo3UFNueGc5TEV6aXh6Y2QyU0d6Y0d2OGdm?=
 =?utf-8?B?dkk2T0NBLzltNmhtYnBBVmhNZ0duVE9XeWlkdVFhZUNDQkRlQVJiVi80ajhs?=
 =?utf-8?B?MlFFOGRYTm1NMlRCeUdVcllRSy9tY28xUHlCTThoUm1PRnFlM0sxQnpaTDVD?=
 =?utf-8?B?bHYzTjA1KzBzYW13bEtyM0FkZGJWaUZqMmUrZWtudU02QW9OaEhYMGhYbDE1?=
 =?utf-8?B?UzkzT2h0Y2lGZkVXSnAyUnVjRHdQbm9OcGhPRjljaWZ4NS9wcG10N3VaVjBo?=
 =?utf-8?B?VFkrSXhUMDRaVjlqZXZSbXVPeHZreXIwRG15bEExVnptMURDckJydzZuRnlG?=
 =?utf-8?B?NkZQeWwzVXVEa29xSlBvQnk0TTd1TUNYd3RDWmVvU2RFWEE4R3ArUkRMb3JE?=
 =?utf-8?B?M0lPN2hKUlJpd1lzbUVHZytUQUhPN2VyWXNaRWZ1MDJOdy9mSFpKeDJkOHFC?=
 =?utf-8?B?VG9hWDJZMHF4cUdzNHZuRTlzV3RxSm8ra0JnVkkzZWRITUVyL3pWOWU4cjNK?=
 =?utf-8?B?cm9VRHpseEorc2kzd0dma0t5djExWXJ3Ymsvejk1MU1qZkhka1BaYXNpUGwz?=
 =?utf-8?Q?TZ2dsin3KVpPUsGzEEQfFgxMA?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 750266e8-1153-4dce-40cf-08dabb5c22ee
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 16:22:42.5021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +96MkLNdz9mOtnGjqHv3olyNJ2KOaxis6nbEkxnCukKxzCaHzqDB7zN5uv7PqItpI+pisu6Gdx6qsaue75qIUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8693

On 28.10.2022 13:49, Roger Pau Monne wrote:
> Add MSR_VIRT_SPEC_CTRL to the list of MSRs handled by
> hvm_load_cpu_msrs(), or else it would be lost.
> 
> Fixes: 8ffd5496f4 ('amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> ---
> I'm confused as to why we have two different list of MSR to send and
> load, one in msrs_to_send[] and the other open-coded in
> hvm_load_cpu_msrs(), but given the release status it's no time to
> clean that up.

I guess this is an optimization, as looking up the MSR in msrs_to_send[]
would be an inefficient inner loop, with the result only used in a
boolean manner (entry present or not present). I do think though that
both places should have a comment referencing the respectively other one,
so both will (hopefully) be updated together. The same looks to apply to
arch_do_domctl()'s MSR handling, where I've screwed up for XFD{,_ERR}.

I'm puzzled by the ctxt->msr[i]._rsvd checking in the default: case. It
was me who added this 8.5 years ago, but I can't see the value of that
check considering the check in the next to final loop in the function.
Hmm, wait - this had an error checking purpose until commit f61685a66903
("x86: remove defunct init/load/save_msr() hvm_funcs"). I think the check
should have been removed at that point. That'll be a post-4.17 patch, I
suppose ...

Jan


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 16:32:09 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 16:32:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433098.685993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opXhl-00010T-4P; Mon, 31 Oct 2022 16:32:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433098.685993; Mon, 31 Oct 2022 16:32:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opXhl-00010M-0F; Mon, 31 Oct 2022 16:32:05 +0000
Received: by outflank-mailman (input) for mailman id 433098;
 Mon, 31 Oct 2022 16:32:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opXhj-00010C-88; Mon, 31 Oct 2022 16:32:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opXhj-0005dZ-2g; Mon, 31 Oct 2022 16:32:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opXhh-00089k-L6; Mon, 31 Oct 2022 16:32:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opXhh-0000Y8-J0; Mon, 31 Oct 2022 16:32:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=H7AT7mj7+8LqE4TS9LfPvO9ObwqPXg+EqL76D1BouVs=; b=MLO6lb/k0jDdfYU2T3ccQEOFx/
	OG9C7HTtO3gRbJJdebllDjOijj29z6dgW9flGcwjBIAWJq8geapL+NoaaCMLMmjRqnfCuut7/CfLO
	KYphzhPKaN26RqIBQILd4bDNZspnS7PjwVYx+iLsu4DTyICzqiqiOXItzdqsi+FaJkDU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174550-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 174550: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-examine:reboot:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression
    linux-linus:test-arm64-arm64-examine:reboot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression
    linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=30a0b95b1335e12efef89dd78518ed3e4a71a763
X-Osstest-Versions-That:
    linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 16:32:01 +0000

flight 174550 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174550/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-seattle   8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl-xsm       8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit2   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-vhd       8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-examine      8 reboot                   fail REGR. vs. 173462
 test-armhf-armhf-xl-arndale   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-credit1   8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-libvirt-qcow2  8 xen-boot               fail REGR. vs. 173462
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 173462
 test-arm64-arm64-examine      8 reboot                   fail REGR. vs. 173462
 test-arm64-arm64-libvirt-raw  8 xen-boot                 fail REGR. vs. 173462
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl           8 xen-boot                 fail REGR. vs. 173462
 test-armhf-armhf-xl-multivcpu  8 xen-boot                fail REGR. vs. 173462
 test-armhf-armhf-libvirt      8 xen-boot                 fail REGR. vs. 173462

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds      8 xen-boot                 fail REGR. vs. 173462

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 173462
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 linux                30a0b95b1335e12efef89dd78518ed3e4a71a763
baseline version:
 linux                9d84bb40bcb30a7fa16f33baa967aeb9953dda78

Last test of basis   173462  2022-10-07 18:41:45 Z   23 days
Failing since        173470  2022-10-08 06:21:34 Z   23 days   36 attempts
Testing same since   174550  2022-10-31 05:53:03 Z    0 days    1 attempts

------------------------------------------------------------
1528 people touched revisions under test,
not listing them all

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 143060 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 17:10:37 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 17:10:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433113.686004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opYIq-0005xZ-3W; Mon, 31 Oct 2022 17:10:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433113.686004; Mon, 31 Oct 2022 17:10:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opYIp-0005xS-Vx; Mon, 31 Oct 2022 17:10:23 +0000
Received: by outflank-mailman (input) for mailman id 433113;
 Mon, 31 Oct 2022 17:10:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opYIn-0005xI-Vg; Mon, 31 Oct 2022 17:10:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opYIn-0006FK-Ue; Mon, 31 Oct 2022 17:10:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opYIn-0002OP-FR; Mon, 31 Oct 2022 17:10:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opYIn-0007cm-Ey; Mon, 31 Oct 2022 17:10:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2cHn2MP6O7SLjcYKogvc95ILSg5eqJiKE6kmHRNJ1FU=; b=eiVUfr/dsnupAXo5Ufc/0jFXbd
	aLgNPVWXpwIKPZgnwol+IKd+K9/zsfMlv4cMpOO681N3zUifiko09x+t52fYb9ZFVdGmuNxP5wKYO
	N8yzYXGJCz3cZ/2nb6c4Ni4N8NeYIB0P3Zlgg31AouF5JOBRJ54RK7Xby+pxxNalCHaE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174554-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174554: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e9a3613ce0667fea2ac15f19cf8ef6aab4b73fdd
X-Osstest-Versions-That:
    ovmf=52199bf5326a8355d28b2d395db483f7c77d5a4d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 17:10:21 +0000

flight 174554 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174554/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e9a3613ce0667fea2ac15f19cf8ef6aab4b73fdd
baseline version:
 ovmf                 52199bf5326a8355d28b2d395db483f7c77d5a4d

Last test of basis   174548  2022-10-31 03:12:04 Z    0 days
Testing same since   174554  2022-10-31 12:40:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   52199bf532..e9a3613ce0  e9a3613ce0667fea2ac15f19cf8ef6aab4b73fdd -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 17:44:08 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 17:44:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433123.686015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opYpP-0001R1-L8; Mon, 31 Oct 2022 17:44:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433123.686015; Mon, 31 Oct 2022 17:44:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opYpP-0001Qu-HT; Mon, 31 Oct 2022 17:44:03 +0000
Received: by outflank-mailman (input) for mailman id 433123;
 Mon, 31 Oct 2022 17:44:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oXMc=3A=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1opYpO-0001Qo-BX
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 17:44:02 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99e0b59a-5943-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 18:44:00 +0100 (CET)
Received: from MW4PR03CA0305.namprd03.prod.outlook.com (2603:10b6:303:dd::10)
 by BL0PR12MB5505.namprd12.prod.outlook.com (2603:10b6:208:1ce::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.18; Mon, 31 Oct
 2022 17:43:57 +0000
Received: from CO1NAM11FT031.eop-nam11.prod.protection.outlook.com
 (2603:10b6:303:dd:cafe::c) by MW4PR03CA0305.outlook.office365.com
 (2603:10b6:303:dd::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend
 Transport; Mon, 31 Oct 2022 17:43:56 +0000
Received: from SATLEXMB03.amd.com (165.204.84.17) by
 CO1NAM11FT031.mail.protection.outlook.com (10.13.174.118) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 17:43:55 +0000
Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 12:43:54 -0500
Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com
 (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 10:43:54 -0700
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 31 Oct 2022 12:43:52 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99e0b59a-5943-11ed-91b5-6bf2151ebd3b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hjh+I5o8RhbtTJtdo0EtR5/FTmasSLgLSTtCfAlLrczMg3e9opMSxlNBz/6HdIQ/BWBuhcr9rK91+cJ6n9dIFVWud8yb7/+wHjjGxIjKn8A/1tWWexpUIrLLsrrZirpTb9Q1+YI+AQGxMuZy00/See+1KtX9Ein7SrMnRUSuxxR48fP3S14EhqfoP2B3waYhWVzYu3zjeOAIm/RLULWeBZssv6SnbtQb9L7s+BGTitH/7aST3M2Tl+TId6UjneySQpK1Zau23efuWFhTnMhDjopMmctiz4+QgxejrodNQtlttgp9fZf+PsyTowWxxaQsK5H9JR+cpjXvtWE4DcPKYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lvy+G2kZybtD5104OadHck5HK/nEkBIFHuU9n9YksSI=;
 b=Hfn8CS3P7aus9hmqsMaIIAaWKZ/7Y6SHI1GgO9spWg9XD35bdy3/AWEPH14ed9N4KSKqEgkLUCzbnpqFk05Pa1eGTx7CRCtnGEjzcWFfxmr68GSqRCcA93B2xq3tCaJdzHIJ0T+fvsPg3IzuhRXujhoUMKhvw9dyD18tS67qZbbI3BHv9sba3CX2IcNx6ojNUaMQmuaIBrpyE1jz8x/FnfMFuTPn38CvIVYymWPkM1ricOMR8MaJyCNjUup52DDc82W4wz9XA5qO1ZG1O5XwWrWzURjv1TPuUJ3LThT2IC5clxLLWCO9RKMaTL61lyKwoX9BFcYDmGtINMPakJPeRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=lvy+G2kZybtD5104OadHck5HK/nEkBIFHuU9n9YksSI=;
 b=wAv4YbSJR03fvo5S8TPVCCS24JNNmmyXiGOG2dKT/8fEn0QKIjT1SP5cOgqzXkoOV1KBMMX17IptrDcPABk3fgN6TB8VWOhFP+GzopPWHmsD1fSUK2HGALh/If0GJskeFWfzN5uf8uCwDtvZYWAzTlT5hvIm8JDlXrUpBlB3o0Y=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C
Message-ID: <b6504f3b-00c1-db31-2c40-94796f8cf161@amd.com>
Date: Mon, 31 Oct 2022 18:43:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [XEN v2 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable
 for Aarch64 only
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
 <20221031151326.22634-2-ayankuma@amd.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221031151326.22634-2-ayankuma@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1NAM11FT031:EE_|BL0PR12MB5505:EE_
X-MS-Office365-Filtering-Correlation-Id: 5a575089-a847-4780-2358-08dabb677b96
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6C6Lzw+EgxZVK/KYMzEWUZEqzEkH2+8k9jXwYV7JfYfcAzRDt05Go028+IGo6nG2jxWA3ju2j8+UAqOxt+YNWju+tQX9SXEZ7wlUV+MAaMckbDUSy1Q/T1v6qU+sNqc5uEw3BN0e0Mb62VnJtQ4GlwhEAHivsPIjcvMXlv8oDNEa/7Twu9/4+ZwQvN5nNoGFW9/QgRHlLBZRqsOy+/VYWU32UbO1AyqrSt29ZgO8GkQx9W6pA+HnTBDPZhYr/m0GN9904R7P5AHYQ3fq7vv01L3xb7UW1iyaHKc8/V8vjVs49i2bqISAT1MUoJqhwFVEzo4aaXN1P4w5OgG9J2DaWeYF278BWjya/jBgYNwWYWKe2nCHiH6s+iLcmgaGuTqiIOevnlNJ4LNfe699nH4Id+IZeCud27kX9zBaRK8+6hWRgMrkKimUt4j9ZUrMy6+joBwIAY6BQpgyS/NVZMHUhH9Sd2VK9rkEbLKe8zWtNcdKuWbJbJ2iskW2e0ilKmZxCxx0wWZcjIVASIy+s9cwREZudW3EmdIfDAF4iID4sm1Ys/tDu2w16K/BgdRiz7oFjXb7F9PhaSrnZC5r6hu6sGxkpypz0AyEL/1K0S17Qcq/Da7FKK/ZcufQ3+WJs6ZIflxkTHbqNrj2z28NCwjIOFcMwm1K5eGtRYRSo8HIFf2wVX+wlLIyvgKULN46H+M3da2LlV9qBBBKZY2sQZuAMmrjOkXDxSrbiMY66zL+NUzPgl/MKB+efPme8R2ncY2yxtYWFKZPbJrBEkwAcmOBvq7WoDZQND6QjlGjZT2nymbmFNP/QvRg/T8n7A4HmDsWaG1FQ5pIUro8A5pRRA1vfQ==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(46966006)(36840700001)(40470700004)(336012)(47076005)(2906002)(81166007)(26005)(426003)(44832011)(2616005)(186003)(5660300002)(8936002)(82310400005)(4744005)(356005)(40480700001)(31696002)(86362001)(36860700001)(36756003)(82740400003)(40460700003)(6666004)(478600001)(316002)(16576012)(8676002)(110136005)(54906003)(4326008)(53546011)(70586007)(31686004)(41300700001)(70206006)(36900700001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 17:43:55.4246
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a575089-a847-4780-2358-08dabb677b96
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1NAM11FT031.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5505

Hi Ayan,

On 31/10/2022 16:13, Ayan Kumar Halder wrote:
> 
> 
> Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state

I think when adding new code we should be taking the latest spec (which is I.a) as a base +
you are lacking the information \wrt page number, table, whatever contains this information
within ARM ARM.

Apart from that, wouldn't it be easier for those reading the commit to just write e.g.:
"Sysreg emulation is 64-bit specific, so guard the calls to vgic_v3_emulate_sysreg
as well as the function itself with #ifdef CONFIG_ARM_64."

Placing EC code in such statement is not very helpful.

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 17:53:55 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 17:53:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433127.686026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opYyq-00034b-J7; Mon, 31 Oct 2022 17:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433127.686026; Mon, 31 Oct 2022 17:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opYyq-00034U-G3; Mon, 31 Oct 2022 17:53:48 +0000
Received: by outflank-mailman (input) for mailman id 433127;
 Mon, 31 Oct 2022 17:53:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oXMc=3A=amd.com=Michal.Orzel@srs-se1.protection.inumbo.net>)
 id 1opYyp-00034O-Pq
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 17:53:47 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6a6e2ad-5944-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 18:53:46 +0100 (CET)
Received: from DM6PR13CA0062.namprd13.prod.outlook.com (2603:10b6:5:134::39)
 by DM4PR12MB7552.namprd12.prod.outlook.com (2603:10b6:8:10c::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Mon, 31 Oct
 2022 17:53:42 +0000
Received: from DM6NAM11FT095.eop-nam11.prod.protection.outlook.com
 (2603:10b6:5:134:cafe::28) by DM6PR13CA0062.outlook.office365.com
 (2603:10b6:5:134::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.17 via Frontend
 Transport; Mon, 31 Oct 2022 17:53:42 +0000
Received: from SATLEXMB04.amd.com (165.204.84.17) by
 DM6NAM11FT095.mail.protection.outlook.com (10.13.172.180) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 17:53:41 +0000
Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com
 (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 12:53:41 -0500
Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com
 (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct
 2022 12:53:41 -0500
Received: from [10.71.192.110] (10.180.168.240) by SATLEXMB03.amd.com
 (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.31 via Frontend
 Transport; Mon, 31 Oct 2022 12:53:39 -0500
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a6e2ad-5944-11ed-8fd0-01056ac49cbb
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b5W4YF8XpmelV2FPGxf3JsP/DZFwUamDOJsLcy6mwjZh3UxUc/JchJwVMb72V6SZRMpi6JeDs67wqYsinriGvkDQsC3dyp+eJ9Mb9r6ctOsD+myeP29qe3HLqJkgfnyXUCynCnHlDadlLAlQr/z3Dnm6sa9qLon/DfFYxtJbGvgIJJtk3CFam9zqiPeZWjlssiBsysgwWE7i0mDIvOAXlBXhGF35J4yc6fsOBKt3gyu0P1Okqd9Kmnfgh2pBOpzeA3uNw0gKYI2lnrmm2/MtyAf4Y4CT8GmkVQvrSuyDP3B+/MX8v91Sf1MbTo/LeewRPtCPg7wLCLMevq19ywZYvw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3lI9apOohtOYRNkGrKmwMe+hAxa4ro9RQPnCUNlVOww=;
 b=fldVU1/8O0hh0+wo3mfCRS1yhmNdi0D1N92tm4JJ0gc0kh7hl8UjH5GUmoghW3k+gO+oa3Gok7SM65DW4ECXgyynXgRGDP4yBQNUxC+Cpv6BA3sF4gvHLf2EtDwhsVzq07nEUJfUbzGpLNaDNVxzvwxqjR3xkDoRhtWPXwC/99q54YF34FVyJkNZ03aqG81+IED+vX0ysPZGhhdbGqpLVFb4nMJBLssSGZn60+et+Hs3nIWMO8KHdNl//pHMHqtZP/iuomiL9UM4IOLkvQRC8x7U5Klv6iEUJ9Z+HX+Muf0yqeNK2V59jrD0R0aEnv602uj3K9LXuOVgHGJ4ZXeU4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com;
 dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
 header.from=amd.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3lI9apOohtOYRNkGrKmwMe+hAxa4ro9RQPnCUNlVOww=;
 b=PWle0RkC6wptcy0xwtxl7M6BxB0sLMnVlTxFlfiVV+KKSuCIfe3HwJARouH8FwP2ZN+jvWmJUbn6YuBrv0qhjD+SqtzjdVRVuvhpIxl/rA/Del7tb8DJUPWmLT7CJIit9vVCZYiHPSiiqaWLWj2KInJ37Y3C4cKKcS2kRsWTWGo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
 smtp.mailfrom=amd.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <4271ac3e-04bf-7bbb-2db9-3216ac19e778@amd.com>
Date: Mon, 31 Oct 2022 18:53:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [XEN v2 02/12] xen/Arm: GICv3: Move the macros to compute the
 affnity level to arm64/arm32
Content-Language: en-US
To: Ayan Kumar Halder <ayankuma@amd.com>, <xen-devel@lists.xenproject.org>
CC: <sstabellini@kernel.org>, <stefanos@xilinx.com>, <julien@xen.org>,
	<Volodymyr_Babchuk@epam.com>, <bertrand.marquis@arm.com>,
	<burzalodowa@gmail.com>
References: <20221031151326.22634-1-ayankuma@amd.com>
 <20221031151326.22634-3-ayankuma@amd.com>
From: Michal Orzel <michal.orzel@amd.com>
In-Reply-To: <20221031151326.22634-3-ayankuma@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DM6NAM11FT095:EE_|DM4PR12MB7552:EE_
X-MS-Office365-Filtering-Correlation-Id: 75b0290c-8584-4075-f5b3-08dabb68d911
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gmjyEmvOxRGeUrZPLSqhDjFBeI0k6gmWEhTqdEF2g24bFlGaob7YJUrSvDDQpEs3ePE1sM1t6eE03hgQqLor4RfnRd74RC1b+jyApFQDPr0lFiPbpDksbGdQBCMvVkkC1+C9ArGc2KBc4QizI1h3kPi4vql4C5O3OHoBoKVF+vmgC81/tPDPpltUA5QMSA0YMP0kf2NUCes3gjzeL7EKWHHD2f0o5fJVEzwZdnbydtYOlvSRGQdUr/EN7mYUJT/6qniA6YnS+Xg9Bkj5zcQpderTuD1kqFmFQhqUqBqSqpGaZa2j/K5bwolvOo4pJoct2LN3CXu0hi1KBVIctAc+toXFYoewOp8RbI7hyCOS7wns7H62o0sch1s6HU/QhkgLaBnLCNthC3zwknFvNelkWKd6pHjXgsXawO5Aqhxu1oo8OZOuSknFbH4N55tFmP9vDy1Pzky0Tt/V2ZmFOj2P7/YnbsXtGNmY4TTx16jM2b8hQ4ueSdfkwTxsBkjV2Cqi9Kyfx98nfoeYClZsMZohLdIrDEXQzQytnaSnNnX1GM/ylyiDELRkkTSwKFq3yscDrFAOlPm8pBR7svWLoiAPQryAJOETPyBwBsDaWEY4Brl5zcR4t8B20iUVtjhD6ZVNN9x9+jQzhfMB85KsAqLUxPiJf1FvCgJ3Qfn/EevxxRDWdYwkBDbZ6HCvtOt3dtVmHHEqUKuX2/N0XWR9R5QFrZ6BpR1sgACvAHHI0D4sG9BgoJyB5LgP6yiaLnyohVX4MOsKqX53XmnBmHPO8Th5aPrjtWfgO4gl3awFCGdHfRytZnPXQuS4zEwd4xrHpPfRBQJu7C3SXQhV5B28bjsgckIHY3NRQjHmYIJlEx4/VeR2x221n7A3uNIgfeTqbqFY2JlDX/dIZtmgsxJzCxr9Xw==
X-Forefront-Antispam-Report:
	CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(39860400002)(136003)(396003)(451199015)(40470700004)(46966006)(36840700001)(70586007)(70206006)(40480700001)(966005)(54906003)(2616005)(356005)(8676002)(36860700001)(81166007)(110136005)(41300700001)(186003)(82740400003)(36756003)(478600001)(336012)(316002)(26005)(83380400001)(31696002)(426003)(4326008)(53546011)(16576012)(86362001)(40460700003)(47076005)(31686004)(2906002)(8936002)(82310400005)(44832011)(5660300002)(43740500002)(36900700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 17:53:41.8391
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 75b0290c-8584-4075-f5b3-08dabb68d911
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DM6NAM11FT095.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7552

Hi Ayan,

On 31/10/2022 16:13, Ayan Kumar Halder wrote:
> 
> 
> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm64/ \
You should not split the link as it is becoming unusable in that form.

> include/asm/cputype.h#L14 , for the macros specific for arm64.
> 
> Refer https://elixir.bootlin.com/linux/v6.1-rc1/source/arch/arm/include/ \
Same here.

> asm/cputype.h#L54  , for the macros specific for arm32.
> 
> MPIDR_LEVEL_SHIFT() differs between 64 and 32 bit.
> For 64 bit :-
> 
>  aff_lev3          aff_lev2 aff_lev1 aff_lev0
> |________|________|________|________|________|
> 40       32       24       16       8        0
> 
> For 32 bit :-
> 
>  aff_lev3 aff_lev2 aff_lev1 aff_lev0
> |________|________|________|________|
> 32       24       16       8        0
> 

Where did you get this info from?
FWICS by looking at ARM ARM DDI 0487I.a D17-6118,
"Aff3 is not supported in AArch32 state."


> Signed-off-by: Ayan Kumar Halder <ayankuma@amd.com>
> ---
> 
> Changes from :-
> v1 - 1. Rearranged the macro defines so that the common code (between arm32
> and arm64) is placed in "arm/include/asm/processor.h".
> 
>  xen/arch/arm/include/asm/arm32/processor.h | 5 +++++
>  xen/arch/arm/include/asm/arm64/processor.h | 8 ++++++++
>  xen/arch/arm/include/asm/processor.h       | 6 ------
>  3 files changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/arch/arm/include/asm/arm32/processor.h b/xen/arch/arm/include/asm/arm32/processor.h
> index 4e679f3273..82aa7f8d9d 100644
> --- a/xen/arch/arm/include/asm/arm32/processor.h
> +++ b/xen/arch/arm/include/asm/arm32/processor.h
> @@ -56,6 +56,11 @@ struct cpu_user_regs
>      uint32_t pad1; /* Doubleword-align the user half of the frame */
>  };
> 
> +/*
> + * Macros to extract affinity level. Picked from kernel
> + */
No need for a multiline comment here and everywhere else.

> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * (level))
> +
>  #endif
> 
>  #endif /* __ASM_ARM_ARM32_PROCESSOR_H */
> diff --git a/xen/arch/arm/include/asm/arm64/processor.h b/xen/arch/arm/include/asm/arm64/processor.h
> index c749f80ad9..295483a9dd 100644
> --- a/xen/arch/arm/include/asm/arm64/processor.h
> +++ b/xen/arch/arm/include/asm/arm64/processor.h
> @@ -84,6 +84,14 @@ struct cpu_user_regs
>      uint64_t sp_el1, elr_el1;
>  };
> 
> +/*
> + * Macros to extract affinity level. picked from kernel
> + */
> +#define MPIDR_LEVEL_BITS_SHIFT  3
> +
> +#define MPIDR_LEVEL_SHIFT(level) \
> +         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
> +
You should move these macros below __DECL_REG as they do not require having it defined.

>  #undef __DECL_REG
> 
>  #endif /* __ASSEMBLY__ */
> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h
> index 1dd81d7d52..ecfb62bbbe 100644
> --- a/xen/arch/arm/include/asm/processor.h
> +++ b/xen/arch/arm/include/asm/processor.h
> @@ -122,13 +122,7 @@
>  /*
>   * Macros to extract affinity level. picked from kernel
>   */
> -
> -#define MPIDR_LEVEL_BITS_SHIFT  3
>  #define MPIDR_LEVEL_MASK        ((1 << MPIDR_LEVEL_BITS) - 1)
> -
> -#define MPIDR_LEVEL_SHIFT(level) \
> -         (((1 << (level)) >> 1) << MPIDR_LEVEL_BITS_SHIFT)
> -
>  #define MPIDR_AFFINITY_LEVEL(mpidr, level) \
>           (((mpidr) >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK)
> 
> --
> 2.17.1
> 
> 

~Michal


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 18:37:26 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 18:37:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433137.686037 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opZep-0008Ko-Sw; Mon, 31 Oct 2022 18:37:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433137.686037; Mon, 31 Oct 2022 18:37:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opZep-0008Kh-Pv; Mon, 31 Oct 2022 18:37:11 +0000
Received: by outflank-mailman (input) for mailman id 433137;
 Mon, 31 Oct 2022 18:37:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7LD8=3A=citrix.com=prvs=2969372d8=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1opZeo-0008Kb-Kj
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 18:37:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0505c1c0-594b-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 19:37:08 +0100 (CET)
Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO
 NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175])
 by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256;
 31 Oct 2022 14:37:04 -0400
Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12)
 by PH0PR03MB5701.namprd03.prod.outlook.com (2603:10b6:510:42::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct
 2022 18:37:02 +0000
Received: from BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44]) by BYAPR03MB3623.namprd03.prod.outlook.com
 ([fe80::1328:69bd:efac:4d44%3]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022
 18:37:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0505c1c0-594b-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1667241427;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:content-transfer-encoding:
   mime-version;
  bh=rOHxKu4DsSSnf3ymWmgk+YRyj847/cxN+YG1jFezWzM=;
  b=NPQ3DiiWr+hrN5oz2k+pR5mSPX43y1L7UtH0vksGcUdRi5SPptcSjCk9
   vK+vdeOUoQVAMOucjxwkDC4f0p73q0coDPtaeDKJgdunYmJKtnzbAa+W0
   heq0TTJQASlMs8eouyIMXATBXsHiU9S/g5HevoJB/4H7jVr1tsHgwimp+
   0=;
X-IronPort-RemoteIP: 104.47.56.175
X-IronPort-MID: 83882607
X-IronPort-Reputation: None
X-IronPort-Listener: OutboundMail
X-IronPort-SenderGroup: RELAY_O365
X-IronPort-MailFlowPolicy: $RELAYED
IronPort-Data: A9a23:lnbtwq0Nuh2rPg3zUPbD5c1wkn2cJEfYwER7XKvMYLTBsI5bpzMCy
 jcfDTiBbP6JYDD9edwgb4ni/R5XvJSHnNVlSAE/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s
 J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo
 tq3qMDEULOf82cc3lk8tuTS9XuDgNyo4GlC5wRlPKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL
 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ
 OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDFBfq
 NZDbxQ0flPSi9O0yYv8EdtjmZF2RCXrFNt3VnBI6xj8VK9jareaBqLA6JlfwSs6gd1IEbDGf
 c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6Kk1EZPLvFabI5fvSjQ8lPk1nej
 WXB52njWTkRNcCFyCrD+XWp7gPKtXOgCNJISuXnnhJsqEKL3UM4OCQVaVi6qOu/h1WyQ+t9K
 mVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9WopWm1876VqXa5PnETJGpbPCscF1Javp/kvZ05iQ/JQpB7Cqmpg9bpGDb2h
 TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BwpJMisRiFaZWrGV
IronPort-HdrOrdr: A9a23:IHpjFai2azTs5ATdu1mOSTXdnXBQX3l13DAbv31ZSRFFG/FwyP
 rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578
 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu
 v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC
 zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+
 O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms
 hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP
 MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+
 PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI
 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wf9igF3ekJhlTVfsuaDQSTDFYzjsCnv/ITRsXGRv
 fbAuMlP8Pe
X-IronPort-AV: E=Sophos;i="5.95,228,1661832000"; 
   d="scan'208";a="83882607"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z40mwwSGFI/XP6xx6ruJ53zWtyhZc08cfWZw2BFqjLnytb6armDoVE0Uq680ncdU9Ul24lXAslYzdS8R0YKJ94CfgArXrHjv2/YuUazNM/Bi0+5XUwuZlHFobEKAII5yFzn0t8IPcXC9+qVKxD1TeLfW9smtkS/57BjVi0qRA3Td3Gc9r2pdZEhknZGIHDBP9p4fHGjm60Z8nJmNVZnsH8ngCAHgWWCzGyhOCcZb7ub8iQTISnGQqOju2Jmgd1tERCoRznKDgNEBTDalBm8nUInmQidDlxpfxG67y3x8edMc7vO6hTY+xzUy64qA43PEOG/4VpPrNmUfHR+zCRvOQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rOHxKu4DsSSnf3ymWmgk+YRyj847/cxN+YG1jFezWzM=;
 b=B9krWQ5j0ua+uOfOJP86DGL6gfw9TM4L7llJCMAY3SrQ+VoqYkO4dbFJ3PpWh1/3CGJji5i/G31aVLE5fw84k2H2yqa1h6o0QdmL8AYytBv/Ny62zo5nVriZdz/d7zaCXo5IPr2/gT2NhcE95Vb9mdAXIJTyux9F+IgfkZpLwlKju9/jPkxD42UstGcINjQo4battboJ9TGcAWkM9a5m86eyi6sLr7C+l9cmSt75Xo1Fmno2IZwBE/LZpnMNaQvQNZ2kP/+yCld13q0ynBVe+VbLKikANPhDgn+yPDMlxoevIJ/r6ocCBavhAtehPveir+3EYBXs9XcjaBOpsoT5/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=rOHxKu4DsSSnf3ymWmgk+YRyj847/cxN+YG1jFezWzM=;
 b=ilnpgiStBSxfzRpNo7auBu2YXsWwiLjha5glXfMAyMnwgCgXl8cKrarg7LkFZwNydRObjzJyxWVn/WE8Act5cpeiwHMOgjs4V8fzfyvupFwN5YAirf8bLMuZYKILRwClsBypGXUZoarS4wS7WKJOMefdIZiUKygeCXEzscLai6I=
From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: x86/HVM: Linux'es apic_pending_intr_clear() warns about stale IRR
Thread-Topic: x86/HVM: Linux'es apic_pending_intr_clear() warns about stale
 IRR
Thread-Index: AQHY7UFE3ShgMplOBEqVLVIh9xv/964o1QWA
Date: Mon, 31 Oct 2022 18:37:01 +0000
Message-ID: <ee91d4d2-e889-355b-4d5a-b40f3dabf81f@citrix.com>
References: <7d9022ce-4a46-e0cb-67c3-4124e1c0d2db@suse.com>
In-Reply-To: <7d9022ce-4a46-e0cb-67c3-4124e1c0d2db@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=citrix.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|PH0PR03MB5701:EE_
x-ms-office365-filtering-correlation-id: a6fca244-2bf8-413b-1d3a-08dabb6ee6dc
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Pf8TeWFPEaTHGdqPfxb7s004U0negzyfa6RM7dlEJ0NrRWeQTkVCnDzN/H0Xc4KQJF1hy5fh4n7LaBXUazpc1ETBwucGAV8dsbmh7OzQBfQt4T7zO4BCA8QLu9QDcGxwVVDaBhHuKGR9OnMgm/hHyBepnMizZ9y9hHqFpMrnbBiN/LBKgBnqLiT5bHLEiiyl4s0cRZLnacGsRMnDa9vIslv30tFRh04Zu7gkwM84B8em14k0T6U0qaaosFs5h4ym0lU5QDiISdvBwu+cTA1Tf/8ddbksgxvq3aiwTLWuBri5mUNzAvy7dR5vOREZ96EfTu1sUBpdw1Jca8d5kxSOFL4QgSOI5Bc1beQCAN0lF5GnIRahTeSZfnhy7txGtNfTMhINZcz3jw4HOg8t3KdLxjNkSgyiFYgwYTFEZZJkkdEuL+nX7O6ifbfyl4HNfgUFhGB4H19Bt2hFe37ufPd0WtJxw1FOfB3QRJQHxozyddkMIsDcs1F4jzPhZdXQYtgNZlQQ1wZiiyhGUyJdQMWSm2gombsgggWfvoZK+YJNdq3pSFCLdzxLbfkqQdytgTso6amSIP/dEX5IKOAIICjfP1x+Zuzngj0P+6hkHhxdJLq7TuCe079mfi9TRAUfYUrkM6nuAw6Hl4kqlcEe3LURsmUmXeeMiASh9aSnJH0UvzlpLchbJqZJRyZBkxqDwWOxTyd8CZSy8b5YK+MK/uY61LWgOnBTtTjRMfEdJe/D9Fuqzd50x86phI4QHJIwDu3jdfw0Sc7zM4cOCChUQZnoVCZ55vbmoDaHH4abopX2LWgajd3PX4tuKDcqvzF8KA6IyFFBd3pWc5N5Uusqg8izKQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(31686004)(478600001)(71200400001)(38070700005)(6486002)(110136005)(6506007)(316002)(82960400001)(4326008)(107886003)(83380400001)(64756008)(76116006)(38100700002)(66946007)(91956017)(66446008)(66476007)(66556008)(8676002)(8936002)(86362001)(53546011)(122000001)(36756003)(41300700001)(5660300002)(6512007)(2906002)(31696002)(26005)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?MEVMazRCZkErUzd5cGJlN2E2dHIyS1RYM0FuQ09HbEdxdC8rZElwNytrUlFO?=
 =?utf-8?B?OXZoRXFkdGFpQ0tlekZQRUVTTTZtTEVGWTh5Q2g2Mnk3VVBKUGZ2ZHEzOGpx?=
 =?utf-8?B?SnhLS01MKzVFUTFzNjZqTDQ0MW9WMDNFV3JKWjZybWsxcTl4SVlJZjM3RmVG?=
 =?utf-8?B?cTZmc2NzN0FTMTR6b0JiZGxuM1VpNndHb21yNFlXY0lyYlFxUGxZT1hpNGZx?=
 =?utf-8?B?QTl5cE9TM25mSEN4T0l5YVRJcVVNL0YrM0NNQzNZbSt4YlVjTTMrYXJYTzEr?=
 =?utf-8?B?RXBLWEVlWHBPaFhKZCtyU0YzMEg5ckVJU2lWUHlrR0U5NllOK2pxdEZ5czl2?=
 =?utf-8?B?WXNBZUVUMmxxNVJyOW9uWWQxQnlJeEVxV2hSSi8wZUVCc0xocjVkSVNGeXhv?=
 =?utf-8?B?T0J0eURGMUVRWW4rQ09meUVmZW1lUlZoSjRvek4rWDRGUWhrV2xTUU01b2xo?=
 =?utf-8?B?YU4xMC9GTFVnemVKWVRacHJ0VWlqUVI5LytjV0hNeEZrZ3VaamVOSDZGQ2xh?=
 =?utf-8?B?aTQzZkdFRnJRNlB3M3Z0Vytadm81ZnpNdUVqWTVQSU5zRzdoUU95SkNQNWxi?=
 =?utf-8?B?YUxWQ3p0a245NmxCSC8ya09MTHNhU0R5UklwMmRqTFA4NFo0M2l5aUoyVVNx?=
 =?utf-8?B?Yi8zdWZZMzdFMWxGeUk2bzhBR2tJcFM1bHJTU1Y1MmxKR0tTWnl0V0lQUWNv?=
 =?utf-8?B?aS9ncTQ4eVNMTXc2akIzaldSM1B0V0hxQ2VtbCt5clFRbTdiWFV3TElsTFZJ?=
 =?utf-8?B?dTdqNThZakhVQjJiQzBETXFIYWxaRnVMWkFncWZXdnRJTURKdzFGQzQzc05S?=
 =?utf-8?B?Q01vcTBWVCs0bGs4MTJlcTVtODh1QSttZUwwc0kwVVFFalJqT3Eyc29EREc3?=
 =?utf-8?B?VG5RVThYNnpiV0tQVEp2a09ENU16NEI3U2syd0FteHJGcjZCZnJPNENsVS9E?=
 =?utf-8?B?SFdxdGpiUHRvbmQxTWdNTXVuYUw4Q1RuRW1XWk1od092QVpxNEY3alNSYUh0?=
 =?utf-8?B?elVoRFRWOWVISkZRSmQ0YmtEZVp6SkExbDV5MW1OLzQxOFNxMUQzcHRaT3hP?=
 =?utf-8?B?aXhKYWNoalJkTVVvU1MxZldtdUdQaUpINDJVbGlkWTc3bW1BdlhYT1h6VEU0?=
 =?utf-8?B?eERjT2Zwdnl1alhSNnV6djRLMkplay82MlRtV2sxM2F3bjF2NGlUeWFScHN0?=
 =?utf-8?B?THBKQlZWZW1iUVpoaVVpdndldVFUZTdDczUwbmg2d2VFU1pqbC9wZlFaRGNY?=
 =?utf-8?B?czAzbk9XRC9MK3hLMGpJVVVwbGt4V2QyZVo0Nzc3ZE9mR1hmRElBU05jLzJw?=
 =?utf-8?B?cGNZWFVNVTcvbzBkWUxVdzRrZGJCWUxiSXMwdVgxZS9ta3R1S0Fla0NQVi9C?=
 =?utf-8?B?REx6SEhCMUtaVFBBbW01ejQzemtXK3hWVTQwOTNraWFoVnRLVHBlVjl1dTlJ?=
 =?utf-8?B?MThxV3BBVzcrZnRicGhXY0d1dnZjYXFBSkl3WlZGd2xZYTFobC9Vc3JTUlBR?=
 =?utf-8?B?YkFEVEE4ZEtwUHptbHIrM3JKNjMvR1dFMXBVamNZdVVKdmloWmR1YXlGaFJq?=
 =?utf-8?B?bGdJN3FqdVgrYW5jdjI4NkdqbkMxYW15b3ZUZ2pmd0Z6OHlCTmxobFJrUjVG?=
 =?utf-8?B?dnhXb3A1NUkrdng1UXh5ZktFVGFpbUsvSnhUY1ZIdEZBM1RKbnRQRE5wZ3p2?=
 =?utf-8?B?WUJlV0p1L3NZNU5TYUJISDFxWDdQZVovaFFOYmVvN0NhRE9CZ1RSQjlVRVd2?=
 =?utf-8?B?aGlFb2NrNE91S0hqK0Z4UkhoZE5kd2tOZEpvQklvWjZKbG5td282VlJOUGVE?=
 =?utf-8?B?S0Vvbnpsc3AybXJiN3JwRVBWQUY4MGpLM1VNRG12dEMzODFBN2Y2T0ZaL2RX?=
 =?utf-8?B?MkhBbDJCMUUrQ1NqaWFJUG8zcUVGanBqYkU3ZTFmR1VLK21SZ2JiMkoweU5y?=
 =?utf-8?B?dVJ4VTB2V0kvWE1jWUJVM2p3V3pjLys2WmdGanJMRXYxUW9QS1IwVjlJYzBh?=
 =?utf-8?B?Mjhyd1VqZVZkNllySmx0WlpjcnFqcTFxU1ppU1JpYXF4UTQ0T21XWTRvYUNG?=
 =?utf-8?B?WWhZMk14RFMvZFRwNUxVUHRZbTFTazIvUGFHY09GQ2E5VXBRREtleXdTcDFr?=
 =?utf-8?Q?xAqmN/yDmzHprCLufBzyZZq2l?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B3DDDBFFB2D6C641AC678BBFA93861DF@namprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: citrix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6fca244-2bf8-413b-1d3a-08dabb6ee6dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 18:37:02.0172
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pB5n5MKgW88BuN8iJ57Aw3Ogo8SchRkpO4Uw2aE3S5rljmemtbXGtdgLJWLavIq6c9Ht0+VuLtrhQvUFSXZDubwvKYilvMw8kP22WT8/EJI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5701

T24gMzEvMTAvMjAyMiAxNTo1NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEhlbGxvLA0KPg0KPiBx
dWl0ZSBsaWtlbHkgdGhpcyBpc24ndCBuZXcsIGJ1dCBJJ3ZlIGVuZGVkIHVwIG5vdGljaW5nIGl0
IG9ubHkgcmVjZW50bHk6DQo+IE9uIGFuIG9sZGlzaCBzeXN0ZW0gd2hlcmUgSSBoYW5kIGEgSFZN
IGd1ZXN0IGFuIFNSLUlPViBOSUMgKG5vdCBzdXJlIHlldA0KPiB3aGV0aGVyIHRoYXQgYWN0dWFs
bHkgbWF0dGVycykgYWxsIEFQcyBoYXZlIHRoYXQgd2FybmluZyBpc3N1ZWQsIHdpdGggYWxsDQo+
IHJlcG9ydGVkIHZhbHVlcyB6ZXJvIGV4Y2VwdCBmb3IgdGhlIHZlcnkgZmlyc3QgSVJSIG9uZSAt
IHRoYXQncyAwMDA4MDAwMC4NCj4gV2hpY2ggaXMgc3VzcGljaW91cyBieSBpdHNlbGYsIGZvciBu
YW1pbmcgdmVjdG9yIDB4MTMsIGkuZS4gYmVsb3cgMHgyMA0KPiBhbmQgaGVuY2Ugd2l0aGluIENQ
VSBleGNlcHRpb24gcmFuZ2UuDQoNClRvIGJlIGNsZWFyLCB0aGVzZSBhcmUgdGhlIFZNJ3MgQVBz
ID8NCg0KPiBGb3Igb25lIEkgd29uZGVyIGFib3V0IHRoZWlyIGxvZ2ljOiBUaGUgZnVuY3Rpb24g
aXMgY2FsbGVkIGFmdGVyIHNldHRpbmcNCj4gVFBSIHRvIDB4MTAsIHdoaWNoIHByZXZlbnRzIHRo
ZSBoYW5kbGluZyBvZiB2ZWN0b3JzIGJlbG93IDB4MjAgKGFuZCBpbg0KPiBwYXJ0aWN1bGFyIHRo
ZWlyIHByb3BhZ2F0aW9uIGZyb20gSVNSIHRvIElSUiwgaWYgbXkgdW5kZXJzdGFuZGluZyBvZiB0
aGUNCj4gcHJvY2VzcyBpcyByaWdodCBhbmQgdGhlIGNvbnZvbHV0ZWQgYW5kIGltbyBwYXJ0bHkg
aW5jb21wbGV0ZSBTRE0NCj4gZGVzY3JpcHRpb24gaGFzbid0IGNvbmZ1c2VkIG1lKS4gUGx1cyB0
aGUgZnVuY3Rpb24gcnVucyB3aGVuIElSUXMgYXJlDQo+IHN0aWxsIG9mZiwgd2hpY2ggaXMgYW5v
dGhlciByZWFzb24gd2h5IG5vdGhpbmcgd291bGQgZXZlciBwcm9wYWdhdGUgZnJvbQ0KPiBJUlIg
dG8gSVNSIHdoaWxlIHRoZSBmdW5jdGlvbiBwZXJmb3JtcyBpdCB3b3JrLiBZZXQgYSBjb21tZW50
IHRoZXJlIHNheXMNCj4NCj4gCS8qDQo+IAkgKiBJZiB0aGUgSVNSIG1hcCBpcyBub3QgZW1wdHku
IEFDSyB0aGUgQVBJQyBhbmQgcnVuIGFub3RoZXIgcm91bmQNCj4gCSAqIHRvIHZlcmlmeSB3aGV0
aGVyIGEgcGVuZGluZyBJUlIgaGFzIGJlZW4gdW5ibG9ja2VkIGFuZCB0dXJuZWQNCj4gCSAqIGlu
dG8gYSBJU1IuDQo+IAkgKi8NCj4NCj4gc3VnZ2VzdGluZyBJUlIgYml0cyBjb3VsZCAicHJvbW90
ZSIgdG8gSVNSIG9uZXMuIEFuZCB0aGlzLCB0byBtZSwgaXMgdGhlDQo+IG9ubHkganVzdGlmaWNh
dGlvbiBmb3Igd2FybmluZyBhYm91dCBsZWZ0b3ZlciBJUlIgYml0cyAod2hlcmVhcyBJDQo+IGNl
cnRhaW5seSBhZ3JlZSB0aGF0IHRoZSBsb2dpYyBzaG91bGQgcmVzdWx0IGluIGFsbCBjbGVhciBJ
U1IgYml0cywgYW5kDQo+IGhlbmNlIHdhcm5pbmcgd2hlbiBvbmUgaXMgc3RpbGwgc2V0IGlzIGFw
cHJvcHJpYXRlKS4NCg0KQm90aCB0aGUgU0RNIGFuZCBBUE0gYXJlIGZhaXJseSBjbGVhciB0aGF0
IElSUiBvbmx5IG1vdmVzIHRvIElTUiB3aGVuDQp0aGUgY29yZSBhY2NlcHRzIHRoZSBpbnRlcnJ1
cHQuDQoNClNvIEkgYWdyZWUgdGhhdCBub3RoaW5nIGluIElSUiB3aWxsIGFjdHVhbGx5IG1vdmUg
dG8gSVNSIGFzIGRlc2NyaWJlZCBieQ0KdGhlIGNvbW1lbnQuDQoNCj4gQW5kIHRoZW4gSSBnb3Qg
cHV6emxlZCBieSBvdXIgbG9naWM6IHZsYXBpY19nZXRfcHByKCkgaXMgY2FsbGVkIG9ubHkgYnkN
Cj4gdmxhcGljX3NldF9wcHIoKSwgdmxhcGljX2xvd2VzdF9wcmlvKCksIGFuZCB2bGFwaWNfcmVh
ZF9hbGlnbmVkKCkuIFlldA0KPiBpbiBwYXJ0aWN1bGFyIG5vdCBieSB2bGFwaWNfaGFzX3BlbmRp
bmdfaXJxKCkuIFdoaWxlIGl0IGxvb2tzIGxpa2Ugd2UNCj4gZG9uJ3QgcmVhbGx5IGlnbm9yZSBU
UFIgZHVyaW5nIGRlbGl2ZXJ5LCB0aGlzIGFwcGVhcnMgdG8gYmUgYSBzdHJhbmdlDQo+IHNwbGl0
IGFwcHJvYWNoOiBodm1faW50ZXJydXB0X2Jsb2NrZWQoKSBjaGVja3MgVFBSLCB3aGVyZWFzDQo+
IHZsYXBpY19oYXNfcGVuZGluZ19pcnEoKSBjaGVja3MgSVNSLiBJIHdvbmRlciBpZiBzdWJ0bGUg
aXNzdWVzIGNhbid0DQo+IHJlc3VsdCBmcm9tIHRoYXQgLi4uDQoNClRoaXMgaXMgcHJlY2lzZWx5
IHdoeSB3YW50IHRoZSBmaW5lIGdyYWluIHNldHRpbmdzIGZvciBBUElDDQphY2NlbGVyYXRpb24u
wqAgSSBrbm93IGZvciBjZXJ0YWluIHRoZXJlJ3MgYXQgbGVhc3Qgb25lIGJ1ZyBoZXJlLCBiZWNh
dXNlDQppdCBzdGlsbCBjYXVzZXMgd2luZG93cyB0byBleHBsb2RlIG9uIG1pZ3JhdGUuDQoNCj4g
T2YgY291cnNlIEknbSB5ZXQgdG8gZmlndXJlIG91dCBob3cgSVJSIGJpdCAweDEzIGVuZHMgdXAg
YmVpbmcgc2V0IGluDQo+IHRoZSBmaXJzdCBwbGFjZS4NCg0KMHgxMyBpcyBhIGxlZ2FsIHZlY3Rv
ciBmb3IgaW5jb21pbmcgaW50ZXJydXB0cyAoZm9yIHJlYXNvbnMgb2YgV2luZG93cw0KdXNpbmcg
MHgxZiBmb3Igc2VsZi1JUEkuKQ0KDQpFeGNlcHRpb24gd2lzZSwgaXQncyAjWEYsIHdoaWNoIGlz
bid0IHZlcnkgY29tbW9uLsKgIFhlbiBjb3VsZCBpbg0KcHJpbmNpcGxlIGhhdmUgaGFkIGFuIGV2
ZW50IGRlbGl2ZXJ5IHR5cGUgZXJyb3IgYW5kIHRyaWVkIHRvIGRlbGl2ZXIgYW4NCmV4Y2VwdGlv
biBhcyBhbiBJUlEsIGFuZCBJIGRvbid0IHRoaW5rIGFueSBvZiB0aGUgc2FmZXR5IGFzc2VydGlv
bnMgaW4NCmh2bV9pbmplY3RfZXZlbnQoKSB3b3VsZCBoYXZlIHRyaWdnZXJlZCBpbiB0aGlzIGNh
c2UuDQoNCkkgZG9uJ3QgZXhwZWN0IExpbnV4IHdpbGwgaGF2ZSBkZWxpYmVyYXRlbHkgSVBJJ2Qg
aXRzZWxmIHdpdGggdGhhdA0KdmVjdG9yLCBidXQgSSBzdXBwb3NlIGl0J3Mgbm90IGltcG9zc2li
bGUgaWYgaXQgY29uc3RydWN0ZWQgYW4gSVBJIGZyb20NCmEgYmFkbHkgaW5pdGlhbGlzZWQgdmFy
aWFibGUuwqAgQWx0ZXJuYXRpdmVseSwgdGhhdCB2ZWN0b3IgaXMgaW4gdGhlDQpQSUMncyBkZWZh
dWx0IHJhbmdlLCBzbyB3ZSBjb3VsZCBoYXZlIGFuIGVtdWxhdGlvbiBpc3N1ZSB0aGVyZS4NCg0K
DQpJZiBJIHdlcmUgeW91LCBJJ2QgZW5zdXJlIHRoZSBWTSBoYXMgNCBvciBmZXdlciB2Q1BVcywg
YW5kIHNldCB1cCAlZHINCnBvaW50aW5nIGF0IElTUlszMTowXSBpbiB0aGUgcmVncyBwYWdlLsKg
IFRoYXQgd2lsbCBjYXRjaCB3aGF0ZXZlcg0KaGFwcGVucyB0byBiZSB3cml0aW5nIGludG8gSVNS
LCBhbmQgdGhlIGJhY2t0cmFjZSB3aWxsIHByb2JhYmx5IGJlDQppbnRlcmVzdGluZy7CoCBKdXN0
IG1ha2Ugc3VyZSB5b3UndmUgZGlzYWJsZWQgaW50ZXJydXB0IHBvc3RpbmcgZmlyc3QsDQpiZWNh
dXNlIHRoYXQgaXMgdGhlIG9uZSBzb3VyY2UgdGhhdCB3aWxsIGJ5cGFzcyB0aGUgZGVidWdyZWdz
Lg0KDQp+QW5kcmV3DQo=


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 20:08:29 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 20:08:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433190.686066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opb4q-000328-QH; Mon, 31 Oct 2022 20:08:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433190.686066; Mon, 31 Oct 2022 20:08:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opb4q-000321-NS; Mon, 31 Oct 2022 20:08:08 +0000
Received: by outflank-mailman (input) for mailman id 433190;
 Mon, 31 Oct 2022 20:08:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opb4o-00031o-J9; Mon, 31 Oct 2022 20:08:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opb4o-0000rQ-Gj; Mon, 31 Oct 2022 20:08:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opb4o-0006f6-3q; Mon, 31 Oct 2022 20:08:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opb4n-0007pf-Ui; Mon, 31 Oct 2022 20:08:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YeXR79Nms61Dkqi/FuouYjNFilBfldVDkIdUZhvMrF4=; b=d1LZVhIUDtq26YQfSeXrBg+511
	KgQatOyrdVhUCuk7Kx5S6zpW+oDx6Qo4uesmuyigDDL+aKtvbrGDWrSkLoRn70jFLZVZrcyl+EAmf
	glRVi/ARPiwk5NToEHRnBY7teEB6jZ+IGwTgq9ugSX8ttpIpYvKiS4kr6j3tzO53amHg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174552-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 174552: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=7208429223963c405c62fa2611398f1aa8033593
X-Osstest-Versions-That:
    qemuu=75d30fde55485b965a1168a21d016dd07b50ed32
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 20:08:05 +0000

flight 174552 qemu-mainline real [real]
flight 174558 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174552/
http://logs.test-lab.xenproject.org/osstest/logs/174558/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 174558-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174546
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 174546
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174546
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174546
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174546
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174546
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174546
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174546
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                7208429223963c405c62fa2611398f1aa8033593
baseline version:
 qemuu                75d30fde55485b965a1168a21d016dd07b50ed32

Last test of basis   174546  2022-10-30 22:37:26 Z    0 days
Testing same since   174552  2022-10-31 10:40:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alberto Faria <afaria@redhat.com>
  Antoine Damhet <antoine.damhet@shadow.tech>
  Bin Meng <bin.meng@windriver.com>
  Bin Meng <bmeng.cn@gmail.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Dario Faggioli <dfaggioli@suse.com>
  David Hildenbrand <david@redhat.com>
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Eugenio Pérez <eperezma@redhat.com>
  Hervé Poussineau <hpoussin@reactos.org>
  Jason Wang <jasowang@redhat.com>
  Julia Suvorova <jusual@redhat.com>
  Jungmin Park <pjm0616@gmail.com>
  Kevin Wolf <kwolf@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Li Feng <fengli@smartx.com>
  Markus Armbruster <armbru@redhat.com>
  Markus Armbruster <armbru@redhat.com> (QAPI schema)
  Michael S. Tsirkin <mst@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Sam Li <faithilikerun@gmail.com>
  Si-Wei Liu <si-wei.liu@oracle.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Stefano Brivio <sbrivio@redhat.com>
  Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   75d30fde55..7208429223  7208429223963c405c62fa2611398f1aa8033593 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 20:23:12 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 20:23:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433197.686077 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opbJM-0005di-8R; Mon, 31 Oct 2022 20:23:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433197.686077; Mon, 31 Oct 2022 20:23:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opbJM-0005db-4s; Mon, 31 Oct 2022 20:23:08 +0000
Received: by outflank-mailman (input) for mailman id 433197;
 Mon, 31 Oct 2022 20:23:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=grsl=3A=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1opbJL-0005dS-9u
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 20:23:07 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d065576e-5959-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 21:23:03 +0100 (CET)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 5B2243200948;
 Mon, 31 Oct 2022 16:22:58 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Mon, 31 Oct 2022 16:22:59 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 31 Oct 2022 16:22:57 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d065576e-5959-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1667247777; x=
	1667334177; bh=qkh6jwHVi4/2Pk/o3gFdi5cX+vrKKYFs7z0PddyqqaM=; b=d
	hevvHmnVVOar2cbKPS0L1WQGgGhqkWjnXHfCq3kyRVUSrFznjImAzLrXSjMmQ74m
	culaPhSFHpRPXhfxPiqo43C5mf9HQHHszuStmnlTIUmAyKxEyNKE/6af6hUgRigx
	Pri1vQVqTBT57Fvz1NM+jjMNU3MuDqXFcEM0Q7+ox6HAIwPRDja2WwPyoh8bFF2u
	dNAESytFJFL3FxQGBpWlsctRcIJUSF+kSXjEISPRa0xkp036aLVSIizjd4nXl0bc
	5mjHsqiArKvbSOwMyhuMKx6Io/ez8um+AJ42lR3GsDCJ6+UFmtU103ofdzo4g+4M
	ab+LyW38/6JHauC8+4HPQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1667247777; x=1667334177; bh=qkh6jwHVi4/2Pk/o3gFdi5cX+vrK
	KYFs7z0PddyqqaM=; b=KVercjdM1b5d58lMpD4CjjOFdqtu30wy+NHs2ziSCyLr
	inuYmPBPi4nhNxdsM4y7VqkCmjx9Sz7/1DOr71ow+60p2r+iHBlDU0WqSUEFW2v/
	CBJZwpSQE3nLtsPGSpC0sTBvdAS0P6yQRIjZ3ypWk6j4PbPkGAbk1XX2bEBBZtIt
	mba2w/HPY++acWCgxc8+Pwu7IB5Hcf7+9rO06tlNeDb5KaFtCcCgzz/lQyy2UF+H
	MlEGc/8+ZQmFM+GOaRtr+Gcm0qysynLdHR39LA63yzO70QZJGH9wNzQh3zs5CKzg
	kTRIjtXxwMSGyGU5o5ND6ENiiTUiTHFtMeS6lOv9Ew==
X-ME-Sender: <xms:oS5gY4LexDBxho-FMSxVE3MIfYCFFPb7zfMbiJlUGxSMo3eVa21fNw>
    <xme:oS5gY4KlicfSLNPzClftUXOTUY6BkNXYuMaoEQL-L7bLiyqj89dQxe_43U7Caoszd
    Q4xURRc_lrI8sk>
X-ME-Received: <xmr:oS5gY4uchufENKgGhZdqrx2nlrh_TgocCVMAG-4ZbOikTarrO8pQgQU9AgIx>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgddufeeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg
    jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:oS5gY1b1_KOV9qGuhkZUBc2VjixE7sJ1efTHSt_9VgB5D5KVAWHy7g>
    <xmx:oS5gY_Z9qxKBvqIKhXcqFcE30DS6fgP4bsS_vLBnApnKU9Tw3zN6lA>
    <xmx:oS5gYxBC3vm-ou4gzYaa1u4cYfA2QhGUuAhDn_6uuS6TwCrHZIHOIg>
    <xmx:oS5gY0PoDiqoOPKmBmEhJyQhv0CxbdtaixqFU7T0g3JM28TjP5Pl0A>
Feedback-ID: iac594737:Fastmail
Date: Mon, 31 Oct 2022 16:22:54 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Sasha Levin <sashal@kernel.org>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 0/3] Stable backports of gntdev fixes
Message-ID: <Y2Aun1V6TMRwtx15@itl-email>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
 <Y194Q9lH3ye4jJOU@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="EArn+1gJx5niycp9"
Content-Disposition: inline
In-Reply-To: <Y194Q9lH3ye4jJOU@kroah.com>


--EArn+1gJx5niycp9
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 31 Oct 2022 16:22:54 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Sasha Levin <sashal@kernel.org>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 0/3] Stable backports of gntdev fixes

On Mon, Oct 31, 2022 at 08:24:51AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Oct 30, 2022 at 03:12:40AM -0400, Demi Marie Obenour wrote:
> > I backported the recent gntdev patches to stable branches before 5.15.
> > The first patch is a prerequisite for the other backports.  The second
> > patch should apply cleanly to all stable branches, but the third only
> > applies to 5.10 as it requires mmu_interval_notifier_insert_locked().
>=20
> Patches 1 and 2 now queued up, see my comments on 3.

Thanks!
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--EArn+1gJx5niycp9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmNgLp8ACgkQsoi1X/+c
IsF3iw/+JpjpEodUnYbUkft3jCaci1R7Bjb9z7tgZtacFO+fc89LlzCGPi9/fEe5
mWZVu003lIonXdB+ZI4ZhCo0aGaZE+BWpb0gB4XedNzGuddI6EGPbW5aJ1RcIsVY
sgljsPRZN/ONAIKdPtK2AAvqQKbEENmBzvAmzQHj+hoHMYVuwQ4qxF8FNw9VDb5s
2FL4pBTP//e1WXqhD8j7o/P+5tTHjvnfgwEqx2Xw918gJQrX1o2RoeA/+335hSff
a9+JbPLeyDX2B/dJmHXNuKpHWRP7zhfkR9EZbbNxn++MExARi7oGgYh0JYoIlIt7
iA1ZYgT2faXEKdehBhPjqwFzJ3bcVN0vV5LUk/DCcZoeiTHRTINy2GpkZGut31lf
lspeAq7r3x6/gCTTgyvDG1k8hd3YfEubTDCEsL0ruqCB4/vvbk7j3nscdd1/+tDh
INLt/a4HV50KFZuf+xetf/wIg0y6D98u7+lLqIN3qDNNKtRWbhJE9L8uopVVDqMG
nIbATG3PKS3moQ0qxs5zJtozHI3tuI+XYMmca+2uxWIENkhXuv432VwsAU5iZozi
6LaCJpibVO/OPlaVbYbtMIGzZUQUyEfB18v/9tIpMfIS1ojJDhQhfTwj96IXRjub
06pwbMf8RWOlF3117juxHMoOZyHTBJtN4IiNLtcnkLKKjpp93eY=
=1gyp
-----END PGP SIGNATURE-----

--EArn+1gJx5niycp9--


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 20:27:25 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 20:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433202.686089 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opbNU-0006R9-RI; Mon, 31 Oct 2022 20:27:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433202.686089; Mon, 31 Oct 2022 20:27:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opbNU-0006R2-Mj; Mon, 31 Oct 2022 20:27:24 +0000
Received: by outflank-mailman (input) for mailman id 433202;
 Mon, 31 Oct 2022 20:27:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=grsl=3A=invisiblethingslab.com=demi@srs-se1.protection.inumbo.net>)
 id 1opbNU-0006Qw-1M
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 20:27:24 +0000
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a314de3-595a-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 21:27:21 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 1281E320092F;
 Mon, 31 Oct 2022 16:27:17 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Mon, 31 Oct 2022 16:27:17 -0400
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 31 Oct 2022 16:27:15 -0400 (EDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a314de3-595a-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm3; t=1667248036; x=
	1667334436; bh=CcVMZSWC/nZz2RRW6ULZLxYdjPK/WNorJkNgpb/0MSg=; b=C
	Gqe8P3s1OnS3MpKKEyK/EcOoEb/6y0mt9jXOHEvcFXF/+dU/J26LNa/oFluM3iWf
	OZ3xnON9X9EIHoYm16gz0duEftEJykSuz40PxmmUteo2VOVYZWuE50P26r1oNY8t
	eSsqoAZ/7gGM2AZfgS42rncxqJrX+zO9qc9a5BfkLvNb7Hc1vwbGTK7byOIq8tfA
	V+LxuVjPKYKB4K9jruH/SZECvzU5mxIsXKhcKffpbdUyweGf5DQmFL94FD84sAEh
	EFFMA8JPShUSXhrhSp3y62VHYIPvt8K72ubkn2vGJPROjFbaZ0K/JlIr/72G1sdF
	2JXMZCVzVEQPz8St0YkdA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
	:feedback-id:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:sender:subject:subject:to:to
	:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
	fm3; t=1667248036; x=1667334436; bh=CcVMZSWC/nZz2RRW6ULZLxYdjPK/
	WNorJkNgpb/0MSg=; b=q/yhZmbJNTvMkqsnpNCo1kfNcj3AQY91oM4/gF0MOV8T
	DbCqI74sn8KTitSOp4Rvl9l0Z/tlL3pZ8QbcFtodCjvhjk193XxqTNc7fdpN4wN9
	v3XMgJehVOE19na7ZX3h4tR/M+xtgOsdGdWODvHBHlSZD0T9IHV3jKRmQs2hQp8j
	X1QT//lpptQZN90uZiOhuWykdeqbO/ZWHpQV3SUp/b1Uam82qhrix4QFv/MwGqPY
	JJbr+ZZE6P/DWrjliGpY+KuY6atsXegNz+FC/ALh9HylVGV0jzDVZOe51yBXk1cO
	uaWhP3WwLI/4boZJWRkp8Vurm8Gw+V36jVXEi2zEKA==
X-ME-Sender: <xms:pC9gYxYMyP657TPxStEIB_6Pyp9G7g_ZryXmd2TxajONM2ilbJje4Q>
    <xme:pC9gY4YFR7buTuoN__xZFExWmASV8TVf7-2aEfk2UW8r__7QpkLlgQWAyP3TvyLNj
    LliYWDAXm9agN8>
X-ME-Received: <xmr:pC9gYz8WHK7PfPtYAa85brbj_PmP5Q8p9OUwDYDoEk7GXGLNpfakjT8ukzAP>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudefgddufeeiucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi
    ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh
    hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff
    gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc
    frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs
    lhgrsgdrtghomh
X-ME-Proxy: <xmx:pC9gY_p-6cbaduINnB_fOB3-wDQUWl7NFeKj5y910g5qQQj7YX4TWg>
    <xmx:pC9gY8pwO5BdjWE47SqpX7XU0i4xFMXvsp3CFJaDlUEdXr84iuRdKA>
    <xmx:pC9gY1Qew3dyGMkrdsupcRBtpS2beaqnp0fqCaDu69VefAiRHsfdgw>
    <xmx:pC9gY0L9NIn90O9S19LWluB33xAuDV7hh4r9e8lVOFwYnaBsPuav7g>
Feedback-ID: iac594737:Fastmail
Date: Mon, 31 Oct 2022 16:27:13 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Sasha Levin <sashal@kernel.org>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	"M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 3/3] xen/gntdev: Accommodate VMA splitting
Message-ID: <Y2AvojXJ5IAGJyL8@itl-email>
References: <20221030071243.1580-1-demi@invisiblethingslab.com>
 <20221030071243.1580-4-demi@invisiblethingslab.com>
 <Y194M/6GboCwWiZX@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/fr8i7DH4beEBrSo"
Content-Disposition: inline
In-Reply-To: <Y194M/6GboCwWiZX@kroah.com>


--/fr8i7DH4beEBrSo
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 31 Oct 2022 16:27:13 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Sasha Levin <sashal@kernel.org>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	"M. Vefa Bicakci" <m.v.b@runbox.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 3/3] xen/gntdev: Accommodate VMA splitting

On Mon, Oct 31, 2022 at 08:24:35AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Oct 30, 2022 at 03:12:43AM -0400, Demi Marie Obenour wrote:
> > From: "M. Vefa Bicakci" <m.v.b@runbox.com>
> >=20
> > Prior to this commit, the gntdev driver code did not handle the
> > following scenario correctly with paravirtualized (PV) Xen domains:
>=20
> This is already in 5.10.152, do we need to add it again?

Not as far as I can tell.  I was looking at the linux-5.10.y branch and
didn=E2=80=99t think to check the patch queue.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--/fr8i7DH4beEBrSo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmNgL6IACgkQsoi1X/+c
IsEagA//Z0ru2SlxozIFeWNgC4gI9vchMR6d6fW/3iSKqQGB3wASQpAkDs/af/3b
0kUm20Gurees1D+b9yxy0FuRoCSZoL7Ukwypu2TFkMdYwrl1+xQnNINyWxXTx5dq
Mf1wuz5KdzGlzYsaktqzxdgkQGaelTWEJLrBoyNgLbbhKkAF6TDuv3h2SezybRPv
+H+mJi+6MVliKiRV55KbRh62FN2ZsU0jMzHRlCpm+XGtbXROYpF/ldyF3srXmVjp
4qvr77r1UpOYGJlRfdIhdAihhq3/yA4h2DLvE7tWjE0ySwev+tUkbF8y5p4QbPho
ZUrZUoRI/XX1/Bnqbgx37d0kIp1QctWkIokutQhoSIfsLZm2AX6kFVtv/9lKNzsl
cdX5U3aiUvPrjf3W8OIil/cVf4l/mjPBJH6kmkc1pZPr53ssxNAw9goeWqmGAKce
IYtx3eKzwPZV20euUCX+LR/+Ii+zWuMifI+iF3eWPc0qJhBp/N/9DrDXDP4dl3VC
g/+MYviZFbYsVn3xeW3x23JfxYUool3ztkvjM71pcQgUdQytpJj/R9PoDEpcC8Ax
4S4Arg99ghR2XrAjhsTAXgtbNXyXplZDwALfiFoEGnqZxxmuEaBVycyY775ak3vA
qLIJqdVSUtQhlhT2AjmCFCq38nvmzkQDQAQTMNkFbxNtF0BaLKI=
=4xEt
-----END PGP SIGNATURE-----

--/fr8i7DH4beEBrSo--


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 21:36:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 21:36:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433214.686110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcS7-0006Pd-0B; Mon, 31 Oct 2022 21:36:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433214.686110; Mon, 31 Oct 2022 21:36:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcS6-0006PW-TG; Mon, 31 Oct 2022 21:36:14 +0000
Received: by outflank-mailman (input) for mailman id 433214;
 Mon, 31 Oct 2022 21:36:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2TDv=3A=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1opcS4-0006AC-Ta
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 21:36:13 +0000
Received: from sonic308-55.consmr.mail.gq1.yahoo.com
 (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07bcad9e-5964-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 22:36:09 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic308.consmr.mail.gq1.yahoo.com with HTTP; Mon, 31 Oct 2022 21:36:07 +0000
Received: by hermes--production-ne1-c47ffd5f5-2l5gs (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 1d450870d12d3f727fe97841ca3633d5; 
 Mon, 31 Oct 2022 21:36:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07bcad9e-5964-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1667252167; bh=IGznKk12GJy9mx+cAyxhAXw1kam3mqzoP8wC6G/UoSU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=VfBFhH/IiUAMeyrtK6L++FniV0n17rJw2PDlx9wTqxSzCGXqld/wx3ZCHuYv4EB3chl8DM2EfZ7lGLmWR7YsHxj8o4S9a5gyq4fqslyVgaMYhYqhbb+sbnhgaRw+CMmvZ84iwssmV3QGMnqFX6new1EdpJSDsSrIbIWgkaLi+hL3szsFILOh9fBnZ6yRIUgk4CpsPJ8Sm1s5p+/wW8oaqrZkQz2/+jcOSKSZDj3DfVuphHBDEJavXJ8qZAgAAxsJ3W3qmyajWdDYd+xF6UW4Ia6XionhUi06HMWV/2mkxIs6+6nAPf40q/1+gfEyS+efJHYupXOKCZD9LyJEBTZjkg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667252167; bh=s1nJndFclxPJHpwkBlsE/zVpQGSKg5nGaHWBSiMCA8a=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Cp5PvtCcXALvHl5fwKJQ/Y1ZWz5Q/k1wYOZTgsPKpNpUiSLQOfPqpsK3J8DIo+aMmJWWyXqp1LoOPlg2zbMpi0rmXo5HsWDnNMJYSQWtr2tsh6VYl21FlRYEFT04Et3TEMR6NezF5q33Kg3NPbtIff+o9vR1gPGm6Rr6sXPRnKVAlZg5lCzROfWEAWjzzRPX+kq2N+WzDYwBraZKj80boW1XzFsVw5uROvDG/S3FFnrxoh6HC6V69uBRVO8VHUJUMoCa2hkc5DHcN8iMnqAJUbv6CWxFq5A0h2WLd/RbN1aQP24YltoKhSEoOwA2CUPXwe0daZZxV9a7xLN10rlF0Q==
X-YMail-OSG: xoK7.TAVM1nXfkqSkAXJsWIxt6aE3NfKJZ3GktAXsLafXoHi2CeRa8MEJ7hPomh
 B2GFQ8hoEa7NTLB2L7O4ROJpJVG96s10Z4TilyZznGUVJloj_2wnrCk5CdEu9Q2i4IJYc8MWEi8s
 XwB.1OyC1.VsjXU_GMrQlSQhLQ8ucr6R645zSAS_Nmj5_2uMbo4vp4g_0k5CF4t_AIEDwwtcw7Ow
 AAqJLiWQ11f50O0P2EgiWGzJEm.oRM.z14bKd7qjmHLUjdKFl0LC3B1wPEDTYX7TulqwOZwYPPNY
 VCdsxsvy50KHwQvtEluHvTqBdphz4G2zw9jb9bLySx3N60o7PARz8qI4E6daqDFbwK3eCJMNP6Vp
 yzj32037kX8D5cMcYBP6i1CBOzOLnpIbxi.t2XqjNwnz5n6wE6Jhps3SWovEfTKxugATkyZXdXwM
 4cYaEcMUfOOGE5SD5uAB3aLBl4exJBbgBgxPC_e5eW0qMWXYaBTxWBtPX0x40ea.UcfsUoEIXheG
 9NK_w2oqBNdnUV_FcY.u3m9yJGcXK9wmGTjDgByCytjs0y2sItAyIfQlQnw_bjF1qyI1rZN3u7nv
 BE6ZQmmvX7pUX__63pSd1SegWPXCdzaksVBRrXaEhm1hlZsSSKK7cljdw3bw15Go4UPJkUYftZQ6
 lT0nEHQ2WPO0YenbOh6_BeBLR6MFIEAAKFDHuuaXJMTfEraHx8hogw77FT34fX3G7olC7FZKZEKI
 4pR_DbA8PDysJoRpC3vXBmTQUTEKZ6_OlblbfK4XX0CO67LxYtdZI7mueSSZBoaCwV8wWdKBPAdu
 86MvRQWywf956GlEPipGMS.qn1_N63OCygcow5E2HIMSujS9egilINlBwvio9GPU7If.ywSjd8vk
 LNr3hICQstkUkXvNAYSNEafjP5TfmR6fnRFQq14EVyQ_pDX3AloLOVRWjeQprA_D4G1FOqQ3NDt4
 e_jk.U12tiY2g.IqeusMGQESGUFoMYVSDFtJe9OtCgIpJG.TMAwOCF_gKcyJsOjKXBjKANaz7MuG
 bRVBnOCsC6Mtj4cIpbZgl9hoE5cSLOezlDELq0jvy2yZTYRNP.MZ93wETl.bys3yyXsOr2w.iOHw
 ZkOHt1OSPstlHnm.mmwyPM51e.s1n0cQ6N5kE7mHwwyQZWGAWvn6PD2fLfm.qPX7VEKnsMts386J
 OmDuhxRx4zYFXFQwQgGgZWwhn9IwUZJI6yKm6Z99mqtkkygh2RNB2hbDBbJOuBz4mMdf0nVdceFW
 9lk_5H_h15z0UmZq._iXMIuORsBkcxTIxKN4RohKfuMcigyLR2U3lku8nqYvE1T3WM6r3G.SQ2sc
 D2O_VSl53Ku_yxzS3Z5Wnn.4aF2xYwJtP_OJjRV2agK6IlPhQ2J6BoNAiEZj4MZTG09wvwdZbuoT
 LUB0QzzzhpiG05KMkj.dI5DN1U6OMCfWLSNTjqTDt4R1pXb8yNL6TImOFssdIYaqch4f1._QdnLv
 rRXfEpRCsvFzj0RRsz3AICtomHLvabL.p8JMSimJYOanZxLZwV4zXKUMiFuN09G_b3mcvol30Luk
 LjNBesKDlKs4P2PZBzv53N31x_RuOgiRhCIV7Ob9M8ClcimvGLw38Lhg_1Klw69Ld6W3fy3U9XZE
 2MZAS.Mpn7LA1d.2P06ZhwMt8PD3S9mjOTw43uZbola6anOtpwFDAata28Sxvq08t2ZkcR_kY6Al
 gLyqPeOuc1Z7xbKcQfeQ8aB8FN.JHsuSH7Mqj.wPl8nOC7oqo1mv8amKs3Sgtm7m5TnD0jo7ByNi
 3DciyiaGtKSp4O.rsVxe15KorsEDPqf96Bh5vlZFB9tELRhGGg8AkKzFD3BrZNbE.ydCMm7GKrO.
 GaTSzbrSsfEz1mm9xRmpbE_Ira4AawFfWwJi5ng6xKH.J7rlj871dLfmUGtPx0H3LgkHlJJDcxKI
 yKoMuqe3_o1EcI423JSfLJ_1rvhEcxZ9wlYZkySmcpv1.FKD2EWuaRy_a7sIT87fyvvHaVmDZ74X
 JqJnfuv2zIb22mkpX5RgTG8JfMMCDJqK6vGm5ywTDxBQXlZTOM6qvoggX163tXEbP1lSL2MVCUhY
 3cdi_kSxAYT9xjDUDKo_zD.OokNoaE12D42kt1Pp7ohapba5HtmfTqNbfKnlhdRaZ8CMhVHaYBzK
 M9a6I2E0oyvpRP5lGYDDsmvax9kxBto0g6ash5ejR0s_0LdWv1TmvEb.jmrwGf3eWS_eBxDeCy1E
 GPGd.a6uK
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations
Date: Mon, 31 Oct 2022 17:35:52 -0400
Message-Id: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchuckz@aol.com>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1667242033.git.brchuckz@aol.com>
References: <cover.1667242033.git.brchuckz@aol.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 1040

When Qemu is built with --enable-xen and --disable-xen-pci-passthrough
and the target os is linux, the build fails with:

meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist.

Fixes: 582ea95f5f93 ("meson: convert hw/xen")

Signed-off-by: Chuck Zmudzinski <brchuckz@aol.com>
---
v2: Remove From: <email address> tag at top of commit message

v3: No change to this patch since v2

v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's
    email address to match the address used by the same author in commits
    be9c61da and c0e86b76

 hw/xen/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/meson.build b/hw/xen/meson.build
index 08dc1f6857..ae0ace3046 100644
--- a/hw/xen/meson.build
+++ b/hw/xen/meson.build
@@ -18,7 +18,7 @@ if have_xen_pci_passthrough
     'xen_pt_msi.c',
   ))
 else
-  xen_specific_ss.add('xen_pt_stub.c')
+  xen_specific_ss.add(files('xen_pt_stub.c'))
 endif
 
 specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 21:36:23 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 21:36:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433215.686121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcSB-0006gB-9M; Mon, 31 Oct 2022 21:36:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433215.686121; Mon, 31 Oct 2022 21:36:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcSB-0006g2-5G; Mon, 31 Oct 2022 21:36:19 +0000
Received: by outflank-mailman (input) for mailman id 433215;
 Mon, 31 Oct 2022 21:36:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2TDv=3A=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1opcS8-0006bP-WF
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 21:36:17 +0000
Received: from sonic306-21.consmr.mail.gq1.yahoo.com
 (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a7917e4-5964-11ed-8fd0-01056ac49cbb;
 Mon, 31 Oct 2022 22:36:14 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic306.consmr.mail.gq1.yahoo.com with HTTP; Mon, 31 Oct 2022 21:36:11 +0000
Received: by hermes--production-ne1-c47ffd5f5-2l5gs (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 1d450870d12d3f727fe97841ca3633d5; 
 Mon, 31 Oct 2022 21:36:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a7917e4-5964-11ed-8fd0-01056ac49cbb
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1667252171; bh=lUp3HSP1TAIWIvem3keOMtwYZCq25W+DMpaMWizwQ7o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=NoGQygL4UHhKlwiW+SVvwQKD4IhNC1iniRVPGMuosQiVwzedgpi3nSTsrapsFpjzz71xayZaZDhqP+t72BuS+XSfIDkAjsfVhb2/rrI03pMJHY7lUMIzHdGl/UHHV9ZIvf3/mCwAPLdXbk8IrNvCFb9F32vafI4odYpQY1wCM/E2Rq2kt9alo8oOe/8b4CM94BmiUtQ0aJ3wUf7WIjdknl6NBBpWV/is4SK6xAEic5A22vND6G3hCa7igkJ29e2QdNLaaPc1RHoUFtmbdtQ+0TS6MwxGpN6pqX0Y4/uTNUO7Zu1V/GWw7QWsJDfUk+oQDND0H0Ygw6ZqgqMClbZCIQ==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667252171; bh=lhYpS8kXk/l9ipGQjwGSK6jo6Jo0+l9WeUuGiT4eAyV=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HQxPjhR0+gRN0vZ5kYsnd3tQNqcorKUJjnygvO+DLLxVXBM5C5oAY8zUqLTtCsC9fKGe6emW5GKa2YVHOm39rXFTeAnJpB4uyqd7yRq2c3qKJTHSEGJ/3BoeiATuGcdpNVmVu8zJToIk+dG5kLIEVbPXxZIsXl1DnqTMK46mCHSyV/1nHv1IaWKkZpaw6hmOM+l7kk6SiGslIMKbS923skpWPUC4YNqdk1yDwiL07iz75x9YCrZFfLgo02RSXK+EeRyWOgsZA1ICPF2la5GBGgePy4lbzS9b7J2mybZiBCVMtWwvElVhyCGk2/u+QPhyo821wifcF3k0hzctSfHmIw==
X-YMail-OSG: RxpTOHUVM1l6UrAaCLg6FTbh7xX3D2u1rQyx6sDqhc1HssSb0N373gH_9z5VOjp
 vn3avlq_olm8k.kvC3QPBzjn4fgY.MipCt65w8hLRf_d5co6jUshXAOd8kvcZqWKdLcnI_xopgdm
 Gt9XlnVIqWdeqNRYbFwWXAnCq2cSreKxqSyNsV4X81Y4QeP8yezgr80.YeL9jmeUvYKlvkmqmEEI
 CgchAN2cbEE5ydOvartSXyZKrNToIWMHay42ASDyeEowMLie1WvHWMypajVotqj6W2TNfLTffnwf
 I992uHbq5zpzEmQmpsHh4baHXe6Wr2gzmrqJAQymBlVn_uBVwnVxRs2ST83mhSoLRILgV11eZ797
 hzZCpmsH3br_tD66DEATlD_qIrb59K1Io6Ixko2xQJohIpUBVQFXnJ5.S.1ocDjs3rgEQmGGE9TL
 fHhUR79Lszow.SGGXsD6Co7ulHwSdGm06oLR5GppsPSYy2DdXNXm4JO__p0slmgGD.9lwC5vzGuW
 vvecQmbyOlYxho51VBoJSakq9gwoW.3.Hs025KBsY.jGRJkDGl_u1oMcSZ7jO0nn83yesIX.pWzJ
 GSN5mxXMVoO59ls29gzMAxKIniEwBVNGTtJsMm08hBot5TSxcdrxq7vsVn7._0Ib7X.9gddNkVmU
 ms4TeGUHubaVC0ZwGIHwQTj4vVdrUHscn52ZlghNtjOuicufGkC42kwovRLE9OVIjmnv.5D7X3wn
 sZHrrO_vzm5hWSijXnr7Yi0uG1QlSzoB6dDv3KpmBn2qBeOmrMww2oVbavtZ5aF8VMNyt33mXdg8
 nrT_I2P7SZzIzBe_whX3IJsvF2Mbd74v5TNokOu6TCokHwsaf5bYfAdzw_3goMQOjeCCx7.oCmcM
 y6b8gJ20eZugCqjZJznRyboXbTEezaBNvR4E55aTxC17yhdzkpZn4v1t53BsHedQkcYJ7.GWbHZi
 9.g6JxEIAUDpePmbj.971XADLnWwEDEH7LqtvGvjS31jq7kyfcF00MlaaFl2Vbz.6i4Qiw2pv42a
 s6pv5A1jHAxjN1M0Kxj__t1QfZfUfOUXrRirW2XJTjCkEtclMBWy_hJu1jyhk.1ZphaiTztwCuHe
 T6ivKZ50Lmm63SdA71nFehhsue1iultH0NvQa3mUue8BhtQIqcnICozlulkjjvjVzmPqDXq8lgSG
 Kb1kfPv6R3d6CNqU.IHYjzb7nkSSgxB3WUBzAkszozovlo_bsPIwq3w15KS7VzAd71vhVnUG56eZ
 pdKwlpo0bm06rsMkUI0aytaxMJKaPWEvPJAqn7v1I6eGRQYAj8EJOrqgYNM07hfaYPC.oJ78Wc2D
 6jCoMYmJ6L.Fis9dLoZgliMtDjMbj9DIETXIVOPIv8Rtmwadrfu0SsmLwFEBmU3V4yLCTGByJeX9
 ETSpwlcCZIrAUcnTUQ.nStTzT6k9RplToRna_LhPV0YRN6rGdCEjkweprdzv0D1rb53PYP7bZns0
 Qkp0MDQQms2n4nciTP1agLT9D0kBu77_biIXJLoVSCwy4gAGQtLBxLUg7Y02Tbl91rsHyl02PUf1
 iWe1pJKdTdLDuhjFpUFxudKH8nN8lQ8BKbpLQe8adQYa03MUAuFxSvGZb7GgIEEPeHDiimsZrcFw
 aiHH.1pPOv1bta2UkxPoiAqM3.Gw4NiIIaWs_1NzYieqQkQAqFiX.cFlDSDsfWuH_WFpL.NPTLYr
 kaw5UUHDLMGBzihMU0_zR7J3ODMeZwg9FeLpZUkIOgC03TsnKe2mdZVGKpXjndPkM2pofjt_Npps
 T0aWDMT8E77oNXT7gFYgEpSyfUPuAjBEXCUJ8GKzlxchWPJP2iTrz3n55v5rn_Dwcy8gq7MH49f0
 Sh3ewmXSasF_wzhVSvnkz.weJDK2NK9uUf3LhJYUOAyFlk_C2VtFjQWQQxs_Mnk.YszQUo_4nQGD
 8vZaPqJSNJ55F0E1S.8AESKwjbJ8L4jeEGnUT23AoH40cyu3pCDoLrpt4qfqdO8raOclim_H8Kbb
 O6hpUOONhgeDjtPq3I03zw2Pj.hIn6ZyYrLGxJPq4Kh8MZ28nlIgORhJu2Sy0y1J.dj5b.0zdk1o
 icjEGfT1ZENqvv7sVadH5dauVuedHTTSWB_jYkXkJghehEWKK8V.9Ri0Ir4PEpRZ8CByoq9swjB8
 HYmDD_HrTVVYw6UViuKAQ.k4a4RSbUATwFns8JsjNwkiyGa4vD0noRzKylKTRB_IBfiQWILC34jz
 C.9yy01UHU29Xwg--
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v4 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru
Date: Mon, 31 Oct 2022 17:35:53 -0400
Message-Id: <f51e326fd82a31535730644a73e8bb41c496e4fc.1667242033.git.brchuckz@aol.com>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <cover.1667242033.git.brchuckz@aol.com>
References: <cover.1667242033.git.brchuckz@aol.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Length: 7942

Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus,
as noted in docs/igd-assign.txt in the Qemu source code.

Currently, when the xl toolstack is used to configure a Xen HVM guest with
Intel IGD passthrough to the guest with the Qemu upstream device model,
a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy
a different slot. This problem often prevents the guest from booting.

The only available workaround is not good: Configure Xen HVM guests to use
the old and no longer maintained Qemu traditional device model available
from xenbits.xen.org which does reserve slot 2 for the Intel IGD.

To implement this feature in the Qemu upstream device model for Xen HVM
guests, introduce the following new class, functions, types, and macros:

* XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE
* XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS
* typedef XenPTQdevRealize function pointer
* XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2
* xen_igd_reserve_slot and xen_igd_clear_slot functions

The new xen_igd_reserve_slot function uses the existing slot_reserved_mask
member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using
the xl toolstack with the gfx_passthru option enabled, which sets the
igd-passthru=on option to Qemu for the Xen HVM machine type.

The new xen_igd_reserve_slot function also needs to be implemented in
hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case
when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough,
in which case it does nothing.

The new xen_igd_clear_slot function overrides qdev->realize of the parent
PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus
since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was
created in hw/i386/pc_piix.c for the case when igd-passthru=on.

Signed-off-by: Chuck Zmudzinski <brchuckz@aol.com>
---
Notes that might be helpful to reviewers of patched code in hw/xen:

The new functions and types are based on recommendations from Qemu docs:
https://qemu.readthedocs.io/en/latest/devel/qom.html

Notes that might be helpful to reviewers of patched code in hw/i386:

The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does
not affect builds that do not have CONFIG_XEN defined.

xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an
existing function that is only true when Qemu is built with
xen-pci-passthrough enabled and the administrator has configured the Xen
HVM guest with Qemu's igd-passthru=on option.

v2: Remove From: <email address> tag at top of commit message

v3: Changed the test for the Intel IGD in xen_igd_clear_slot:

    if (is_igd_vga_passthrough(&s->real_device) &&
        (s->real_device.vendor_id == PCI_VENDOR_ID_INTEL)) {

    is changed to

    if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2)
        && (s->hostaddr.function == 0)) {

    I hoped that I could use the test in v2, since it matches the
    other tests for the Intel IGD in Qemu and Xen, but those tests
    do not work because the necessary data structures are not set with
    their values yet. So instead use the test that the administrator
    has enabled gfx_passthru and the device address on the host is
    02.0. This test does detect the Intel IGD correctly.

v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's
    email address to match the address used by the same author in commits
    be9c61da and c0e86b76
    
    Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 4 files changed, 48 insertions(+)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 0b1a79c0fa..a0f04ad62e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -402,6 +402,9 @@ static void pc_xen_hvm_init(MachineState *machine)
     }
 
     pc_xen_hvm_init_pci(machine);
+    if (xen_igd_gfx_pt_enabled()) {
+        xen_igd_reserve_slot(pcms->bus);
+    }
     pci_create_simple(pcms->bus, -1, "xen-platform");
 }
 #endif
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 0ec7e52183..50a63fe12e 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -950,11 +950,35 @@ static void xen_pci_passthrough_instance_init(Object *obj)
     PCI_DEVICE(obj)->cap_present |= QEMU_PCI_CAP_EXPRESS;
 }
 
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+    XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n");
+    pci_bus->slot_reserved_mask |= XEN_PCI_IGD_SLOT_MASK;
+}
+
+static void xen_igd_clear_slot(DeviceState *qdev, Error **errp)
+{
+    PCIDevice *pci_dev = (PCIDevice *)qdev;
+    XenPCIPassthroughState *s = XEN_PT_DEVICE(pci_dev);
+    XenPTDeviceClass *xpdc = XEN_PT_DEVICE_GET_CLASS(s);
+    PCIBus *pci_bus = pci_get_bus(pci_dev);
+
+    if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot == 2)
+        && (s->hostaddr.function == 0)) {
+        pci_bus->slot_reserved_mask &= ~XEN_PCI_IGD_SLOT_MASK;
+        XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n");
+    }
+    xpdc->pci_qdev_realize(qdev, errp);
+}
+
 static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
+    XenPTDeviceClass *xpdc = XEN_PT_DEVICE_CLASS(klass);
+    xpdc->pci_qdev_realize = dc->realize;
+    dc->realize = xen_igd_clear_slot;
     k->realize = xen_pt_realize;
     k->exit = xen_pt_unregister_device;
     k->config_read = xen_pt_pci_read_config;
@@ -977,6 +1001,7 @@ static const TypeInfo xen_pci_passthrough_info = {
     .instance_size = sizeof(XenPCIPassthroughState),
     .instance_finalize = xen_pci_passthrough_finalize,
     .class_init = xen_pci_passthrough_class_init,
+    .class_size = sizeof(XenPTDeviceClass),
     .instance_init = xen_pci_passthrough_instance_init,
     .interfaces = (InterfaceInfo[]) {
         { INTERFACE_CONVENTIONAL_PCI_DEVICE },
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index e7c4316a7d..40b31b5263 100644
--- a/hw/xen/xen_pt.h
+++ b/hw/xen/xen_pt.h
@@ -3,6 +3,7 @@
 
 #include "hw/xen/xen_common.h"
 #include "hw/pci/pci.h"
+#include "hw/pci/pci_bus.h"
 #include "xen-host-pci-device.h"
 #include "qom/object.h"
 
@@ -41,7 +42,20 @@ typedef struct XenPTReg XenPTReg;
 #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough"
 OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE)
 
+#define XEN_PT_DEVICE_CLASS(klass) \
+    OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE)
+#define XEN_PT_DEVICE_GET_CLASS(obj) \
+    OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE)
+
+typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp);
+
+typedef struct XenPTDeviceClass {
+    PCIDeviceClass parent_class;
+    XenPTQdevRealize pci_qdev_realize;
+} XenPTDeviceClass;
+
 uint32_t igd_read_opregion(XenPCIPassthroughState *s);
+void xen_igd_reserve_slot(PCIBus *pci_bus);
 void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val);
 void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
                                            XenHostPCIDevice *dev);
@@ -76,6 +90,8 @@ typedef int (*xen_pt_conf_byte_read)
 
 #define XEN_PCI_INTEL_OPREGION 0xfc
 
+#define XEN_PCI_IGD_SLOT_MASK 0x4UL /* Intel IGD slot_reserved_mask */
+
 typedef enum {
     XEN_PT_GRP_TYPE_HARDWIRED = 0,  /* 0 Hardwired reg group */
     XEN_PT_GRP_TYPE_EMU,            /* emul reg group */
diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c
index 2d8cac8d54..5c108446a8 100644
--- a/hw/xen/xen_pt_stub.c
+++ b/hw/xen/xen_pt_stub.c
@@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp)
         error_setg(errp, "Xen PCI passthrough support not built in");
     }
 }
+
+void xen_igd_reserve_slot(PCIBus *pci_bus)
+{
+}
-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 21:36:24 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 21:36:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433213.686099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcS5-0006AU-Ow; Mon, 31 Oct 2022 21:36:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433213.686099; Mon, 31 Oct 2022 21:36:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcS5-0006AN-M3; Mon, 31 Oct 2022 21:36:13 +0000
Received: by outflank-mailman (input) for mailman id 433213;
 Mon, 31 Oct 2022 21:36:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=2TDv=3A=aim.com=brchuckz@srs-se1.protection.inumbo.net>)
 id 1opcS3-0006AC-Kx
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 21:36:12 +0000
Received: from sonic311-24.consmr.mail.gq1.yahoo.com
 (sonic311-24.consmr.mail.gq1.yahoo.com [98.137.65.205])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07312e52-5964-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 22:36:08 +0100 (CET)
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic311.consmr.mail.gq1.yahoo.com with HTTP; Mon, 31 Oct 2022 21:36:06 +0000
Received: by hermes--production-ne1-c47ffd5f5-2l5gs (Yahoo Inc. Hermes SMTP
 Server) with ESMTPA ID 1d450870d12d3f727fe97841ca3633d5; 
 Mon, 31 Oct 2022 21:36:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07312e52-5964-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1667252166; bh=uxOwrD0U0H546e379z6pIj7ishCHeKXz2cYS+K7ZCSA=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=t4PsUBVbL+tFKr+SCIjGYKBa8LZKNdOhXiAlD8Ly2GVIw9xKKr7GAb6WLl8nkGWlL9rdNykimQXvuey826Pa902P/J+FkhDiPMR8A7yagH3KB2HywKVEc2YKSBHVehmvz3F7xcGkQnDXmp/Jc+0/izPD+GctV5hyPFJsMXGC5SV/MX6leP/eGcEhfahXzR5uoM9ojxit7mD9uSuh99+SYGUhuuS+dxHhgrO6pGQfoCH9bFoKy4NoFksxRYVc20PrSsWwXydXXXi4kdPe6/azfT8a5TuQDdoXQG9YnqIpFSdPefMnP09w8JstPUX8iMASOrXJKDnk2qaSz9jPJXUcmw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667252166; bh=LRLXbF/s7/ITJbULB0qtJPEFf5qS9irXKOaTvElYx3I=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QQqxT1+t3wWPEZ2YuPMqeG2lGig4FKsOxCc7iSM9SioH2/08Bri9fGMg0QMvnpo9jYMRhD5u7RCGJrbUq1FnZrVyHS6JsIMf/UbF1G2mtDBxOfkMU40FdBg5O3dZaqq4NZ6HAB5TTM/k0Zu7PxEyeyUi851bTcfkt178HNSU5CnltRmT10j+A8+On8/su50CwENmzIhYlyhW20bySUAX3bvxeKuZRTSqzeC5OUMZPMXIpfIn8JDBmTu8wer/FAsUcdKFvQe26ikGjQj4KXPfxG7W32lxgo2rLmsMrunrJctLBjV1AKXqL5LRX6KLrXQnbUWVMgFL9Prq5DNHk6lZ3g==
X-YMail-OSG: TrYy9g4VM1lWmXA0S3_Txh3IolAWizPT4cc1wBKX7DrboJBnewHToGBPbqJPiPo
 LXMUjBKN5dm.y1mMxLx9T2IGrHqRf3SqMpk9y6rvyTQFmJA8B41Z_DFJYaZW1rHhXKS9.L8pvtMS
 Kkoiv4BozHwDZZQmccnwgSaxoNyTGE0rqPFJzHbi2xThVJjb4byFJuafxtCqPV5OqxtwL9fvnQrL
 sTJ8zX2ymlG7.XouBq3yacHDhNiy.tFsMxjVvNzyJf4JAQCWGbKID4qrYHDMay7NFu5h1.4Cb4ga
 0psVCajKZyyf44HNZK0kC2ade4VSY4_tugvos_pxPkiOW3vaZyswY0Uq8BnEMozX3_phlA3yGJCv
 8yPybUXO5m4UHWmAO7PA8cOIFZ9XMzs2QbGrL.qm9H759_qFoajVGY6WiJ0.s.ydWDCg.HORmg27
 mBV7ZMeP0Q4750mJ9wLnnDcsSSEu.rwUOYgjjUzdkBeYyfTk6Bbe0OHwTglbUrjio3ETGIFJiXeD
 xTHm022rg7ZwKUnFeej1WZm18egsamcIB5_WVrvgrwfGURLCy8kAV7a3H3W5KH09Rkw.PVtRVovU
 GqPioWEuCEaBIWRc1aQgn_ZEaq15.dcGdwHa.qv298TQh6_MjHWIkQpp7XU6C0T.sm.aHh5Lyqdl
 C20.D54OoO0QSONrV8iXWza8n2wRys04kfknXiTqvpCp0.eYShKOMFoziAfWnjGsXe86cvlfyXUc
 odxYs6Xyy59JPo.G0z4SQYh6freIDjoVHxOaeMWYMN90eBYviYHozk_k29lv.KAptbL_LUFpH0L4
 bAIwDI9SR5CEaHS8jwKgCazVYg4ikOwsT4nu_h5gPJpmqeCfc6cpI.GVjZyzhWpXcdbZEXrPlxZN
 _qiQEh4xC21.VX7HhTvZZplbAF1eYT1j5j_NgW7vFg8RM5p7Q2oJud6hZl2_6v28OaIJhsDOv8sL
 Q446JpUE4klxwh9SxmGKEML_XeI5nZq2An3EuqYcGEIeZA8pNrheJxkcRWAF.mNSMDW7U2MdEQaS
 j.ZV1VLD9rIdfpM0xLiR8kIzYbYuetma6LuMzjkJScWwCcycCZygchycab4qsyNJ4mffmV9mmu7F
 qm8ooHzGqKFwpJU465pOc8u1gq40A1.BULOaYPMl9GRGRzr6uDQemUv8ohh5BGNi1DWj_l3zT8jB
 toKO8L__YcHil8ozB6vs4vRJEPgZTEf9qfOhmyxhqPniaKVzRRiTk5C4C0FhUmsoYxTQLJdVTLqV
 5cNzrNcntCMZKWFf_kiyqFzfxTgZ0yPgKM59L6alBoJUYEMlVwVQG5YWX7WekrTJyQ9uYWgWPpR3
 jLuE6x1AR8eCh_mN8uScWvTOIPd3I0FMTve8palMJNu0CMfkE.39yXp3QaFgeWlFSTYVoCaywAlv
 Wse2_IpIorDjOaqntZKad2_rD5aHknHNk0va96TLeisApzPCr4ncGMfZ_d_M68WlH.3lWzMkt1o_
 hNK1G40PYdvZdQh3XTOGVeQ1GcZtdtgvaHnkhiIrP8alfI5Wwa6RdxJEpeqbKCWJDtIvHwMaZE3l
 MdBzCfeZSLhwIfpHt.X2oYMNJU5SKPUh3xEqtn6T_IDLSkgu090iMUttM7tOnM_XRCAuctKqBEAr
 CnZauTtEeAh4yaqsLbfhy7058VL.L0fxbHp2tRNH4ROxc49.3orrEa1VPxppwtxqvm5Kdj1wJDkO
 SC3tKXYb25Kd8Netz5e7XEkqvgmArlgywyY1GH7ssOqZy.4cnyVstaI_4WEqR4ORvLDtKfzGO7Cr
 _b5ivGFcn8Bh9UI0mxDU33YlraZmWDSumETmG012Bu2iiILcOilXBAANYjKehG9h2GZSIYVNra21
 ovQelIX6fsXibhAXFvhulszrRAEc4RHKHFsipYcAa0VlwcUhAMQF9HecxOboBmJ.WyW34YqIhC.Q
 uEghrocvcRGcqCVNHbQRyEPZDXq7TksBpUZak_xTNYQLDxch.4gT3fUCfSWr3CzodhAWpoEOsGpJ
 q2qXPOFfRpy_t8DgB5mj35appz66z1SOgk4j7KO8M0PJZrfizhBnDUG9RtwOJnp.wkrkVVgTcA8B
 qwcwgYvq3mGi5BTl.bBZP0F.nmyaZz7LUGdvvU9me9lercry3L2sMLzYGIeYzWwLWDMsOBPTfCfk
 3Tr3f6FIEJHFKkfFdl9cE_.CeKJUogSbzcanBSVPIru89S6BkQ8OP4UcUMuqfPeidrs1uXpitkQg
 ftLSUzf0-
X-Sonic-MF: <brchuckz@aim.com>
From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	xen-devel@lists.xenproject.org
Subject: [PATCH v4 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD
Date: Mon, 31 Oct 2022 17:35:51 -0400
Message-Id: <cover.1667242033.git.brchuckz@aol.com>
X-Mailer: git-send-email 2.37.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
References: <cover.1667242033.git.brchuckz.ref@aol.com>
Content-Length: 1817

This is a series of two patches:

The first fixes FTBFS when --enable-xen and --disable-xen-pci-passthrough
configure options are set with when building for the linux target os.

The second fixes a regression that was introduced many years ago with the
upgrade from the Qemu traditional device model that is still available
from xenbits.xen.org and based on very old Qemu version 0.10.2.

The regression is that the Qemu traditional device model reserves slot 2
for the Intel IGD on the PCI bus when the Intel IGD is passed through
to a Xen HVM domain, but the current Qemu upsream device model does not
and in fact results in a different slot assigned to the Intel IGD.

This behavior does not conform to the requirement that the Intel IGD must
be assigned to slot 2, as noted in docs/igd-assign.txt in the Qemu source
code: "IGD must be given address 02.0 on the PCI root bus in the VM."

I have used the second patch of the series for the past two years with
no problems. Without the patch, the reliability of PCI passthrough of the
Intel IGD to a Xen HVM guest is very poor, and in some cases the guest
fails to start without the patch.

v2: Remove From: <email address> tag at top of message

v3: No change to this cover letter since v2

v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's
    email address to match the address used by the same author in commits
    be9c61da and c0e86b76 

Chuck Zmudzinski (2):
  xen/pt: fix syntax error that causes FTBFS in some configurations
  xen/pt: reserve PCI slot 2 for Intel igd-passthru

 hw/i386/pc_piix.c    |  3 +++
 hw/xen/meson.build   |  2 +-
 hw/xen/xen_pt.c      | 25 +++++++++++++++++++++++++
 hw/xen/xen_pt.h      | 16 ++++++++++++++++
 hw/xen/xen_pt_stub.c |  4 ++++
 5 files changed, 49 insertions(+), 1 deletion(-)

-- 
2.37.2



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 22:06:51 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 22:06:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433234.686136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcvX-0002q9-T8; Mon, 31 Oct 2022 22:06:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433234.686136; Mon, 31 Oct 2022 22:06:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcvX-0002q2-P5; Mon, 31 Oct 2022 22:06:39 +0000
Received: by outflank-mailman (input) for mailman id 433234;
 Mon, 31 Oct 2022 22:06:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opcvW-0002pZ-VE; Mon, 31 Oct 2022 22:06:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opcvW-0002nM-Qf; Mon, 31 Oct 2022 22:06:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opcvW-0003iA-AO; Mon, 31 Oct 2022 22:06:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opcvW-0000h4-9r; Mon, 31 Oct 2022 22:06:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fuHVZhTnvjVayqkcjD8RccQJIP59cj7pLlmiFTdlvgo=; b=l9d/zuYG3bnFJywdUnMt/crMNa
	X7ptyJ7J73FCzO0NJuSrozOkp7VWlnaYmtfDagExxkFxJrzIkqpMdtooKu4XsPzBsx4odLo71Iutp
	HV77JNrM/D/5SUmCcXZxoZbXRuXuNbfd8d0SMD+pp7WFN4JwHbA0AwewJHxUI2SPv+24=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174553-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 174553: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c229b16ba3eb5579a9a5d470ab16dd9ad55e57d6
X-Osstest-Versions-That:
    xen=e5a5bdeba6a0c3eacd2ba39c1ee36b3c54e77dca
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 22:06:38 +0000

flight 174553 xen-4.16-testing real [real]
flight 174559 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/174553/
http://logs.test-lab.xenproject.org/osstest/logs/174559/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt      8 xen-boot            fail pass in 174559-retest
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 174559-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 174559 like 174452
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 174559 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 174452
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 174452
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 174452
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 174452
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 174452
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 174452
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 174452
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174452
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 174452
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 174452
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 174452
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c229b16ba3eb5579a9a5d470ab16dd9ad55e57d6
baseline version:
 xen                  e5a5bdeba6a0c3eacd2ba39c1ee36b3c54e77dca

Last test of basis   174452  2022-10-26 11:59:49 Z    5 days
Testing same since   174553  2022-10-31 12:38:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Dario Faggioli <dfaggioli@suse.com>
  Igor Druzhinin <igor.druzhinin@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Jason Andryuk <jandryuk@gmail.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e5a5bdeba6..c229b16ba3  c229b16ba3eb5579a9a5d470ab16dd9ad55e57d6 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Mon Oct 31 22:09:04 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 22:09:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433240.686147 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcxr-0003Qa-AD; Mon, 31 Oct 2022 22:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433240.686147; Mon, 31 Oct 2022 22:09:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opcxr-0003QT-71; Mon, 31 Oct 2022 22:09:03 +0000
Received: by outflank-mailman (input) for mailman id 433240;
 Mon, 31 Oct 2022 22:09:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=tE5W=3A=linaro.org=philmd@srs-se1.protection.inumbo.net>)
 id 1opcxq-0003QN-D4
 for xen-devel@lists.xenproject.org; Mon, 31 Oct 2022 22:09:02 +0000
Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com
 [2a00:1450:4864:20::32c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9fd04e0f-5968-11ed-91b5-6bf2151ebd3b;
 Mon, 31 Oct 2022 23:09:01 +0100 (CET)
Received: by mail-wm1-x32c.google.com with SMTP id
 fn7-20020a05600c688700b003b4fb113b86so8907839wmb.0
 for <xen-devel@lists.xenproject.org>; Mon, 31 Oct 2022 15:09:01 -0700 (PDT)
Received: from [192.168.1.115] ([185.126.107.38])
 by smtp.gmail.com with ESMTPSA id
 z17-20020a05600c0a1100b003b492753826sm8508549wmp.43.2022.10.31.15.08.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 31 Oct 2022 15:08:59 -0700 (PDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fd04e0f-5968-11ed-91b5-6bf2151ebd3b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date:message-id:reply-to;
        bh=LyQShnvoJM7z9hDlodIpAOjZgHnaO9r8jiYZc/6MZBk=;
        b=mIrr1FJvWRAC4HmeE9iDwrehh2t7ieXggNwccLDO49TCTUgu+ATdQYxZG0d57XYsU5
         dUyfZOvp0PE38aUxByqtRb5L5sbJTLC+WlftxMdhbprHhqpx8gLkbsRQmohbkEJBo2Rp
         bFLSwTq/XL4UT2OdHLDqr2BUNATB10yO4DPVxkuYpgGXj2QhG61HGE0RjQ5PfFxqkyS7
         RQvQLUm3cyG1aaIZa/xzTI6ORokWu1Ik3JmxM16o53RZI26oXLcxU9J2lGvkpYVERgkf
         dUnp0+cIGihV4hrvz2l5iWGre2M0vNddAcnD26F5yFdHObssUOaTXpBVFSED0wU/AA/N
         yxQw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=LyQShnvoJM7z9hDlodIpAOjZgHnaO9r8jiYZc/6MZBk=;
        b=OPIOVUpEOWK2RRQ6HzeOCISUJcqh5cAuOdBh47p7cGb7/FMDqPQE7hmaLr1g/PQRoz
         sMZXr6gudF+JyzrgRC7O72p9Ir3JlasOVAtpZMKmfp8KoA1bCm4pCTuIXjUgoLsjKcrS
         S+OxnF+Mrluo47BK+Liqnn6cqDuCAqmw0tkoQdqHNG+DLZCQ1T1SBryQOzusCTK2cI9M
         fJzjHLDKSQ4zX4XrGtwOox9+awizwS2DM0k9mIxrn8VAJSlf+/pA6S4fOYzpmecDOZfe
         y0tt51uW9dfBXah8buMkK49j4XBIpe5Eg/UeC/tmkOAYbG8IUrgZJqfDoIWcB2ycIzUW
         lukA==
X-Gm-Message-State: ACrzQf3Vn23DcEGH/gEXXahqeQkxKT/m6Yl7rAQrZ3Npf//NUkXACFlY
	OwFsm4U5Z8ZN3jHagGoqBTExEQ==
X-Google-Smtp-Source: AMsMyM6DqV2a/e9jZ/s6CrUQ1j2rP0SxUQe5cljzbansYROltu/j3dGAfGioiDY1OQETpZMr9IGCeg==
X-Received: by 2002:a05:600c:4e45:b0:3cf:3e69:9351 with SMTP id e5-20020a05600c4e4500b003cf3e699351mr20182478wmq.2.1667254140857;
        Mon, 31 Oct 2022 15:09:00 -0700 (PDT)
Message-ID: <dccf8560-a4db-53e4-418e-402ba76d7570@linaro.org>
Date: Mon, 31 Oct 2022 23:08:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.0
Subject: Re: [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some
 configurations
Content-Language: en-US
To: Chuck Zmudzinski <brchuckz@aol.com>, qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org, QEMU Trivial <qemu-trivial@nongnu.org>
References: <cover.1667242033.git.brchuckz@aol.com>
 <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchuckz@aol.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchuckz@aol.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 31/10/22 22:35, Chuck Zmudzinski wrote:
> When Qemu is built with --enable-xen and --disable-xen-pci-passthrough
> and the target os is linux, the build fails with:
> 
> meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist.
> 
> Fixes: 582ea95f5f93 ("meson: convert hw/xen")
> 
> Signed-off-by: Chuck Zmudzinski <brchuckz@aol.com>
> ---
> v2: Remove From: <email address> tag at top of commit message
> 
> v3: No change to this patch since v2
> 
> v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's
>      email address to match the address used by the same author in commits
>      be9c61da and c0e86b76
> 
>   hw/xen/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/xen/meson.build b/hw/xen/meson.build
> index 08dc1f6857..ae0ace3046 100644
> --- a/hw/xen/meson.build
> +++ b/hw/xen/meson.build
> @@ -18,7 +18,7 @@ if have_xen_pci_passthrough
>       'xen_pt_msi.c',
>     ))
>   else
> -  xen_specific_ss.add('xen_pt_stub.c')
> +  xen_specific_ss.add(files('xen_pt_stub.c'))
>   endif
>   
>   specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



From xen-devel-bounces@lists.xenproject.org Mon Oct 31 22:19:01 2022
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 31 Oct 2022 22:19:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.433260.686214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opd7Q-0005kF-U4; Mon, 31 Oct 2022 22:18:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 433260.686214; Mon, 31 Oct 2022 22:18:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1opd7Q-0005k8-Pq; Mon, 31 Oct 2022 22:18:56 +0000
Received: by outflank-mailman (input) for mailman id 433260;
 Mon, 31 Oct 2022 22:18:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opd7Q-0005jy-4T; Mon, 31 Oct 2022 22:18:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opd7Q-000318-2i; Mon, 31 Oct 2022 22:18:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1opd7P-0004IG-Ig; Mon, 31 Oct 2022 22:18:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1opd7P-0006GZ-IH; Mon, 31 Oct 2022 22:18:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0hShe4ZGGob1duBV1L7e6IHEz+9LnUvfRQpQZZIGbds=; b=0J0nm8JSHU8HaR9CkTTruXrQn/
	a0CimAoSjpLFb31j9tWO/9fT5Nty5zdKXnFb0Ttsio3zmxJh3c5IdkfSTkuaBX3tdykREiXXqQt3F
	s1k3SjoY/H+yeIngjWvXwNNLfcTSg/GbTYNUdlmX5xfOLwTewBANm17PHQGw8HVoJuBg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-174557-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 174557: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=66772bc8523ce7898eb470efc7aef65c2062b2aa
X-Osstest-Versions-That:
    ovmf=e9a3613ce0667fea2ac15f19cf8ef6aab4b73fdd
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 31 Oct 2022 22:18:55 +0000

flight 174557 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/174557/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 66772bc8523ce7898eb470efc7aef65c2062b2aa
baseline version:
 ovmf                 e9a3613ce0667fea2ac15f19cf8ef6aab4b73fdd

Last test of basis   174554  2022-10-31 12:40:57 Z    0 days
Testing same since   174557  2022-10-31 17:42:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e9a3613ce0..66772bc852  66772bc8523ce7898eb470efc7aef65c2062b2aa -> xen-tested-master